Rename Probe implementations to be more idiomatic/brief

What does this PR do?
This PR renames the curl_json package and both the CurlJSON and Legacy probe implementations such that they can be referred to as curl.Probe and legacy.Probe. It also updates all external (to the probe package) references to those types to use the new names.
This change was originally suggested by @AlexVulaj in a comment on an earlier PR, citing the awkwardness of needing to refer to the probe implementations by names like curl_json.CurlJSONProbe. This suggestion is backed up by Effective Go:

The importer of a package will use the name to refer to its contents, so exported names in the package can use that fact to avoid repetition.... For instance, the buffered reader type in the bufio package is called Reader, not BufReader, because users see it as bufio.Reader, which is a clear, concise name.

As for the renaming of curl_json to curl

By convention, packages are given lower case, single-word names; there should be no need for underscores or mixedCaps... And don't worry about collisions a priori.

This PR doesn't cover docs; those will be updated with OSD-24417. Test names are also not covered (although it does update the error messages in the tests) for the sake of timeliness.

Codecov Report
Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 31.18%. Comparing base (705bbe5) to head (4ae48be).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   31.18%   31.18%
=======================================
  Files          12       12
  Lines        1119     1119
=======================================
  Hits          349      349
  Misses        752      752
  Partials       18       18

Files
Coverage Δ

pkg/probes/curl/curl_json_result.go
96.29% <ø> (ø)

pkg/probes/legacy/legacy.go
89.28% <100.00%> (ø)

pkg/verifier/aws/aws_verifier.go
26.47% <0.00%> (ø)

pkg/probes/curl/curl_json.go
75.94% <50.00%> (ø)

/lgtm

/approve


Error creating directory downloads/temp (Windows)

Very often while installing a package that requires a download, the installation will fail with an error about creation of downloads/temp:
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:72 (file):
  file problem creating directory: C:/src/vcpkg/downloads/temp
Call Stack (most recent call first):
  scripts/cmake/vcpkg_from_github.cmake:106 (vcpkg_download_distfile)
  ports/mypkg1/portfile.cmake:15 (vcpkg_from_github)
  scripts/ports.cmake:72 (include)

After such a failure, downloads/temp does not exist. Running the same command again succeeds, but leaves an empty temp directory behind, ready to trip over the next run of the command. Often runs of vcpkg end up alternating between working and erroring as they alternate between deleting and recreating the directory.
This has been reported before in #3057. That user said the problem mysteriously cleared up for them, but they didn't say they deleted their downloads so I suspect that these were cached and so vcpkg just never attempted to recreate downloads/temp.
I suspected maybe my virus scanner was causing the directory to linger but I tried disabling it and running on another machine with a different virus scanner, but I still had the same problem in both cases. TortoiseGit was not installed (I mention this because of the confusingly similar #3398 I had also been having).
In vcpkg_download_distfile.cmake, perhaps it would be a good idea to insert a short sleep, like 200ms, between the calls to file(REMOVE_RECURSE "${DOWNLOADS}/temp") and file(MAKE_DIRECTORY "${DOWNLOADS}/temp"). I would give that a go on my machines and see if it fixes it for me, but I don't know how to make cmake do a sleep.

Thanks for the investigation into what I'm sure is an incredibly frustrating issue!
I've applied the workaround suggested by @mengfan1102 to master -- I'm a bit more hesitant about adding a 200ms sleep since that does have a real, measurable performance impact for small libraries. I'd be happier with a solution that simply catches the download failure and then sleeps and retries. This way the "happy path" isn't affected.

@ras0219-msft  Agreed that mengfan1102's rename workaround is massively better than my suggestion of a short sleep. Great idea! I don't currently have access to the computer that this problem was worse on but I'm happy to believe this is fixed now, so I'll close this. Thanks everyone.

It seems even the current workaround is not enough in some situations. I am building vcpkg from inside a Docker container. If I build my required ports in two steps like below:
RUN ./vcpkg install first_thing
RUN ./vcpkg install other_thing

The second build will fail like this:
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:79 (file):
  file RENAME failed to rename
    /tmp/workdir/vcpkg/downloads/temp
  to
    /tmp/workdir/vcpkg/downloads/temp0
  because: Invalid cross-device link

And this is vcpkg_download_distfile.cmake:
76:    # Works around issue #3399
77:    if(IS_DIRECTORY "${DOWNLOADS}/temp")
78:        file(REMOVE_RECURSE "${DOWNLOADS}/temp0")
79:        file(RENAME "${DOWNLOADS}/temp" "${DOWNLOADS}/temp0")
80:        file(REMOVE_RECURSE "${DOWNLOADS}/temp0")
81:    endif()
82:    file(MAKE_DIRECTORY "${DOWNLOADS}/temp")

So far, the solution has been to build all in the same step or to delete the temp dir before the seconds build:
rm -rf vcpkg/downloads/temp
I still have not figured out why this container behaves this way.

I have the same issue. Could vcpkg_download_distfile.cmake not delete the temp directory as it's final step?

execute_process(COMMAND ${CMAKE_COMMAND} -E sleep 1 \\ 1 sec
function(sleep delay)
  execute_process(
    COMMAND ${CMAKE_COMMAND} -E sleep ${delay}
    RESULT_VARIABLE result
    )
  if(NOT result EQUAL 0)
    message(FATAL_ERROR "failed to sleep for ${delay} second.")
  endif()
endfunction(sleep)

file(REMOVE_RECURSE "${DOWNLOADS}/temp")
sleep(1)
file(MAKE_DIRECTORY "${DOWNLOADS}/temp")

Imagine my shock when I dusted off vcpkg to generate a new slew of binaries, only to be greeted by this error again. Reverting the fix was obviously the wrong thing to do. I was forced to reinstate it as Boost was impossible to install. I've also modded my ports.cmake in a similar vein:
@@ -120,10 +120,11 @@ if(CMD STREQUAL "BUILD")
     unset(BUILDTREES_DIR)

     if(EXISTS "${CURRENT_PACKAGES_DIR}")
-        file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}")
+        file(RENAME "${CURRENT_PACKAGES_DIR}" "${CURRENT_PACKAGES_DIR}-temp")
         if(EXISTS "${CURRENT_PACKAGES_DIR}")
-            message(FATAL_ERROR "Unable to remove directory: ${CURRENT_PACKAGES_DIR}\n  Files are likely in use.")
+            message(FATAL_ERROR "Unable to rename directory: ${CURRENT_PACKAGES_DIR}\n  Files are likely in use.")
         endif()
+        file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}-temp")
     endif()
     file(MAKE_DIRECTORY "${CURRENT_BUILDTREES_DIR}" "${CURRENT_PACKAGES_DIR}")

Reverting the fix was obviously the wrong thing to do. @ras0219-msft, can you reopen this? Can we detect Docker and behave accordingly, until the root cause there is rooted out?


Learning Rate Issue

I am trying to adjust my lr to find the best parameter. When I  use tf.keras.wrappers.scikit_learn, it can work. But  when I use scikeras, I can't adjust lr.
I use
model = KerasRegressor(model=network_model) GridSearchCV(estimator=model,param_grid=param_grid,scoring='neg_mean_squared_error',cv=5)

Would you mind giving a minimal reproducible example?

`def network_model(num=256,learning_rate=0.01,IMSIZE=128):
model=Sequential()
model.add(Flatten(input_shape=(IMSIZE,IMSIZE,3)))
model.add(Dense(num,activation='relu'))
model.add(Dense(1))
model.compile(loss='mse',optimizer=Adam(learning_rate),metrics=['mse'])
model.summary()
return model
from scikeras.wrappers import KerasRegressor
from sklearn.model_selection import GridSearchCV
param_grid = {
"num":[64,128,256,512,1024],
"learning_rate":[0.001,0.005,0.01,0.05],
'batch_size':[128,256,512],
'epochs':[30,50,100]
}
model = KerasRegressor(model=network_model)
grid_search = GridSearchCV(estimator=model,param_grid=param_grid,scoring='neg_mean_squared_error',cv=5)
grid_search.fit(x_train,y_train)
`

Thanks. I'm on vacation for the next couple days, I'll get around to this as soon as I can.

Please take a look at this notebook: https://colab.research.google.com/drive/1F612ADj4QDA1S4hMzWnNQB0yI8evl21D#scrollTo=tQP7rWirvaUp
I took your example and simplified it a bit. I see that the learning rate is being changed.

Hi @menelaus02, looping back here. Were you able to resolve your issue?

Hi @menelaus02, looping back here. Were you able to resolve your issue?

Hi, I have solved it. I found that I ought to add the initial value of parameters to the KerasRegressor so that it could run normally.  Otherwise it woud apper "Check the list of available parameters with estimator.get_params().keys()”.
model = KerasRegressor(model=network_model, verbose=False)  model = KerasRegressor(model=network_model, learning_rate=0.1, verbose=False)

Excellent, I'm glad you could get it to work. Are there any extra warnings or documentation you think might have helped catch this earlier?

Maybe we can mention in the documentation that if we compile the model and use the optimizer in a function, we need to initialize the value of the parameters even if we use the default parameters in the function.

Does you feel that this section cover the issue? https://www.adriangb.com/scikeras/stable/migration.html#id8

I think it is clear enough.

Great, would you mind closing the issue then?

No problem.


CMRotationMatrix (Attitude) is broken

When replacing vanilla CMMotionManager I get some flipped axes of the rotation matrix
I've stopped at a breakpoint in Attitude.init(_ attitude: CMAttitude) and let it assign self.quaternion
Comparing the rotation matrices yields the following results:
(lldb) po attitude.rotationMatrix
▿ CMRotationMatrix
  - m11 : -0.1969096064567566
  - m12 : 0.9799075722694397
  - m13 : -0.03173968195915222
  - m21 : -0.7388630509376526
  - m22 : -0.12703722715377808
  - m23 : 0.6617723703384399
  - m31 : 0.6444437503814697
  - m32 : 0.15376073122024536
  - m33 : 0.7490326166152954

(lldb) po self.rotationMatrix
▿ CMRotationMatrix
  - m11 : -0.19690976161972862
  - m12 : -0.7388631294669954
  - m13 : 0.6444438080182784
  - m21 : 0.979907719073764
  - m22 : -0.12703738138275833
  - m23 : 0.1537607421647839
  - m31 : -0.031739689326065
  - m32 : 0.6617724530725418
  - m33 : 0.7490325843885801

(lldb)

Expected behavior
To have the same axes would be nice..
Environment

Xcode 12.4
Swift 5.3
OS iOS 14.4

Temporary workaround is to flip the matrix.
I'm my case I did it during conversion to a simd_double4x4:
// conversion for vanilla CoreMotion:
//        m.columns.0.x = self.m11
//        m.columns.0.y = self.m21
//        m.columns.0.z = self.m31
//        m.columns.1.x = self.m12
//        m.columns.1.y = self.m22
//        m.columns.1.z = self.m32
//        m.columns.2.x = self.m13
//        m.columns.2.y = self.m23
//        m.columns.2.z = self.m33
//        m.columns.3.w = 1.0
//

 // For ComposableCoreMotion
        m.columns.0.x = self.m11
        m.columns.0.y = self.m12
        m.columns.0.z = self.m13
        m.columns.1.x = self.m21
        m.columns.1.y = self.m22
        m.columns.1.z = self.m23
        m.columns.2.x = self.m31
        m.columns.2.y = self.m32
        m.columns.2.z = self.m33
        m.columns.3.w = 1.0

Good find! Some of the math here file must be wrong or CoreMotion has a different basis than what we assume :/
Will look into it soon, but if the fix really is to transpose the matrix we'd be happy to except a PR to update that computed property.

Sorry, I have not worked on this in a while... Anyway, today I have some new findings:
I put a breakpoint inside DeviceMotion.init(_ deviceMotion: CMDeviceMotion):
po deviceMotion

QuaternionX -0.000882 QuaternionY -0.005251 QuaternionZ 0.932196 QuaternionW -0.361915 UserAccelX 0.001116 UserAccelY 0.000844 UserAccelZ -0.003047 RotationRateX -0.000685 RotationRateY 0.003429 RotationRateZ 0.000225 MagneticFieldX -15.539566 MagneticFieldY 8.030884 MagneticFieldZ -36.237579 MagneticFieldAccuracy 2 Heading 47.562225 SensorLocation 0 @<PHONE_NUMBER>23

po self.attitude
▿ Attitude
  ▿ quaternion : CMQuaternion
    - x : -0.000882195988422291
    - y : -0.005250768163730715
    - z : 0.9321958498359307
    - w : -0.36191515007517006

So far, so good.. if we continue:
po deviceMotion.attitude
CMAttitude Pitch: -0.524317, Roll: 0.312014, Yaw: -137.562226

po self.attitude.pitch * 180 / Double.pi
0.3120013533421466

po self.attitude.roll * 180 / Double.pi
-0.52432466754302

po self.attitude.yaw * 180 / Double.pi
-137.56508141514132

My conclusion is that the bases on CoreMotion is different than your assumptions and it's not just the rotation matrix that is broken.
I'll prepare a PR later tonight.

I've created a new PR with just the rotation matrix fix. The pitch/roll is still an issue. I've searched around the we in my quest to understand the quirks of CMQuaternion and have found this old SO post (unexpected results from glkquaternion conversion from cmquaternion)


drivers: flash: Fix Nios-II QSPI flash Coverity issue

Fix Coverity "Memory - corruptions (ARRAY_VS_SINGLETON)"
issue by type casting word_to_write to u8_t pointer and
adding a length check before memcpy operation.
Coverity CID: 182779
Signed-off-by: Ramakrishna Pallala<EMAIL_ADDRESS>

Codecov Report

Merging #6473 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #6473   +/-   ##
======================================
  Coverage    53.2%   53.2%
======================================
  Files         436     436
  Lines       41353   41353
  Branches     7937    7937
======================================
  Hits        22002   22002
  Misses      16127   16127
  Partials     3224    3224

Impacted Files
Coverage Δ

kernel/posix/pthread.c
62.5% <0%> (-0.5%)
:arrow_down:

samples/philosophers/src/main.c
98.43% <0%> (+1.56%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a44e8e...f052ade. Read the comment docs.

fixes Issue #6092


fix(channel): add missing timeout multiplication

Adds a missing multiplication of the passed timeout as the backend interprets the number in nano seconds. With this multiplication by one million the number passed to the backend will be interpreted in ms from the user perspective

Das sollte das problem mit den inapp messages beheben.


document sometimes exist and sometime not exists when i use java-driver-arangodb for query data

my environment running ArangoDB
I'm using the latest ArangoDB of the respective release series:

[ ] 2.8
[ ] 3.0
[ ] 3.1
[x] 3.2
[ ] 3.3
[ ] self-compiled devel branch

Mode:

[x] Cluster
[ ] Single-Server

Storage-Engine:

[ ] mmfiles
[x] rocksdb

On this operating system:

[ ] DCOS on

[ ] AWS
[ ] Azure
[ ] own infrastructure

[x] Linux

[ ] Debian .deb
[ ] Ubuntu .deb
[ ] SUSE   .rpm
[x] RedHat .rpm
[ ] Fedora .rpm
[ ] Gentoo
[ ] docker - official docker library
[ ] other:

[ ] Windows, version:
[ ] MacOS, version:

this is an AQL-related issue:
[ ] I'm using graph features
I'm issuing AQL via:

[ ] web interface with this browser:     running on this OS:
[ ] arangosh
[x] this Driver:

I've run db._explain("<my aql query>") and it didn't shed more light on this.
The AQL query in question is:
The issue can be reproduced using this dataset:
Please provide a way to create the dataset to run the above query on; either by a gist with an arangodump, or `db.collection.save({my: "values"}) statements. If it can be reproduced with one of the ArangoDB example datasets, it's a plus.

let doc = (let min = 1
let max = 100
for config_item in CONFIG_ITEM
    filter config_item.type == @type
    let in_v = (for v, e, p in min..max inbound config_item._id graph 'CI_Graph' filter v.type == "cabinet" or v.type == "location" or v.type == "datacenter" or v.type == @type  or v.type == "managedriver"  return v)
    let out_v = (for v, e, p in min..max outbound config_item._id graph 'CI_Graph' filter v.type == "cabinet" or v.type == "location" or v.type == "datacenter" or v.type == @type  or v.type == "managedriver"  return v)
    let device = UNION_DISTINCT([config_item], in_v, out_v)
    let search_place_item = (
        for item in device
            filter item.type == "cabinet" or item.type == "location" or item.type == "datacenter"
            return item
    )
    let search_components = (
        for v in device
            filter v.type ==  @type or v.type == "managedriver"
            return {
                _id: v._id,name: v.name,manageIp: v.manageIp,useState: v.useState,manufacturer: v.manufacturer,model: v.model,placeInfo: v.placeInfo,contactName: v.contactName,maintenanceExpireTime: v.maintenanceExpireTime
            }
    )
    let search = {
        "placeInfo": TRENDY::GETPLACEINFO(search_place_item),
        "components": search_components
    }
    filter TRENDY::GETVALUESTR(search) like @keywords for doc in device filter doc.type == @type return 1) return length(doc)

When I query the data with the same query statement, the data can be found and sometime can't be found,
i use the java-driver, what can i do, i need help

Hi,
do you use more than one coordinator and have a transparent loadbalancer in place?
Your sessions have to be sticky to one coordinator in order to work properly; else one coordinator will build the query, hold the cursor, and you will ask another coordinator for a cursor that it doesn't have.

em, I guess I got it.How to bind a request to a coordinator?or How to implement it in code

@CengSin The Java driver supports built-in load balancing. see here

this is my config of arangodb
@mpv1989 How should I modify it?

Your config looks good to me. As long as you don't run any additional, external load balancer the problem should not be on the client side.

 Do you see these problems only on the java driver or also on the webinterface?

@dothebart No, I don't use any loadbalancer in front of my cluster coordinators. this problem both java-driver and webinterface!

Ok, the query you've posted is pretty complex with many possible transitions coordinator<->dbserver - you way mant to add the output of explain to the original message - do you see any of the dbservers or coordinators restart?
In general, you should strive to optimize your query in a way that as less as possible dbserver <-> coordinator roundtrips occur.

@mpv1989 the properties only set a ip of this cluster, i set the acquireHostList=ture by properties for the system auto get the list, this function right?

@dothebart i don't know how to do
 you way mant to add the output of explain to the original message

you open the webinterface, go to the query editor, and instead of execute you press explain which will give an overview of how the query is executed in arangodb and how it is distributed in the cluster.
You then can edit your original report (first post in this thread) and add that information using cut'n'paste.

Query string:
 let doc = (let min = 1
 let max = 100
 for config_item in CONFIG_ITEM
     filter config_item.type == @type
     let in_v = (for v, e, p in min..max inbound config_item._id graph 'CI_Graph' filter v.type ==
 "cabinet" or v.type == "location" or v.type == "datacenter" or v.type == @type  or v.type ==
 "managedriver"  return v)
     let out_v = (for v, e, p in min..max outbound config_item._id graph 'CI_Graph' filter v.type ==
 "cabinet" or v.type == "location" or v.type == "datacenter" or v.type == @type  or v.type ==
 "managedriver"  return v)
     let device = UNION_DISTINCT([config_item], in_v, out_v)
     let search_place_item = (
         for item in device
             filter item.type == "cabinet" or item.type == "location" or item.type == "datacenter"
             return item
     )
     let search_components = (
         for v in device
             filter v.type ==  @type or v.type == "managedriver"
             return {
                 _id: v._id,name: v.name,manageIp: v.man...

Execution plan:
 Id   NodeType            Site       Est.   Comment
  1   SingletonNode       COOR          1   * ROOT
 40   SubqueryNode        COOR          1     - LET doc = ...   /* subquery */
  2   SingletonNode       DBS           1       * ROOT
 47   IndexNode           DBS          14         - FOR config_item IN CONFIG_ITEM   /* hash index scan */
 50   RemoteNode          COOR         14           - REMOTE
 51   GatherNode          COOR         14           - GATHER config_item ASC
 14   SubqueryNode        COOR         14           - LET in_v = ...   /* subquery */
  8   SingletonNode       COOR          1             * ROOT
  9   CalculationNode     COOR          1               - LET #30 = config_item.`_id`   /* attribute expression */   /* collections used: config_item : CONFIG_ITEM */
 10   TraversalNode       COOR          1               - FOR v  /* vertex */ IN 1..100  /* min..maxPathDepth */ INBOUND #30 /* startnode */  GRAPH 'CI_Graph'
 43   CalculationNode     COOR          1               - LET #34 = (v.`type` in [ "cabinet", "location", "datacenter", "networkswitch", "managedriver" ])   /* simple expression */
 12   FilterNode          COOR          1               - FILTER #34
 13   ReturnNode          COOR          1               - RETURN v
 21   SubqueryNode        COOR         14           - LET out_v = ...   /* subquery */
 15   SingletonNode       COOR          1             * ROOT
 16   CalculationNode     COOR          1               - LET #36 = config_item.`_id`   /* attribute expression */   /* collections used: config_item : CONFIG_ITEM */
 17   TraversalNode       COOR          0               - FOR v  /* vertex */ IN 1..100  /* min..maxPathDepth */ OUTBOUND #36 /* startnode */  GRAPH 'CI_Graph'
 44   CalculationNode     COOR          0               - LET #40 = (v.`type` in [ "cabinet", "location", "datacenter", "networkswitch", "managedriver" ])   /* simple expression */
 19   FilterNode          COOR          0               - FILTER #40
 20   ReturnNode          COOR          0               - RETURN v
 22   CalculationNode     COOR         14           - LET device = UNION_DISTINCT([ config_item ], in_v, out_v)   /* simple expression */   /* collections used: config_item : CONFIG_ITEM */
 28   SubqueryNode        COOR         14           - LET search_place_item = ...   /* subquery */
 23   SingletonNode       COOR          1             * ROOT
 24   EnumerateListNode   COOR        100               - FOR item IN device   /* list iteration */
 45   CalculationNode     COOR        100                 - LET #42 = (item.`type` in [ "cabinet", "location", "datacenter" ])   /* simple expression */
 26   FilterNode          COOR        100                 - FILTER #42
 27   ReturnNode          COOR        100                 - RETURN item
 35   SubqueryNode        COOR         14           - LET search_components = ...   /* subquery */
 29   SingletonNode       COOR          1             * ROOT
 30   EnumerateListNode   COOR        100               - FOR v IN device   /* list iteration */
 46   CalculationNode     COOR        100                 - LET #44 = (v.`type` in [ "networkswitch", "managedriver" ])   /* simple expression */
 32   FilterNode          COOR        100                 - FILTER #44
 33   CalculationNode     COOR        100                 - LET #46 = { "_id" : v.`_id`, "name" : v.`name`, "manageIp" : v.`manageIp`, "useState" : v.`useState`, "manufacturer" : v.`manufacturer`, "model" : v.`model`, "placeInfo" : v.`placeInfo`, "contactName" : v.`contactName`, "maintenanceExpireTime" : v.`maintenanceExpireTime` }   /* simple expression */
 34   ReturnNode          COOR        100                 - RETURN #46
 36   CalculationNode     COOR         14           - LET search = { "placeInfo" : TRENDY::GETPLACEINFO(search_place_item)   /* user-defined function */, "components" : search_components }   /* v8 expression */
 37   CalculationNode     COOR         14           - LET #48 = LIKE(TRENDY::GETVALUESTR(search)   /* user-defined function */, "%数据中心%")   /* v8 expression */
 38   FilterNode          COOR         14           - FILTER #48
 39   ReturnNode          COOR         14           - RETURN config_item
 41   CalculationNode     COOR          1     - LET #50 = LENGTH(doc)   /* simple expression */
 42   ReturnNode          COOR          1     - RETURN #50

Indexes used:
 By   Type   Collection        Unique   Sparse   Selectivity   Fields        Ranges
 47   hash   CONFIG_ITEM       false    true             n/a   [ `type` ]    (config_item.`type` == "networkswitch")
 10   edge   CONFIG_RELATION   false    false            n/a   [ `_to` ]     base INBOUND
 17   edge   CONFIG_RELATION   false    false            n/a   [ `_from` ]   base OUTBOUND

Traversals on graphs:
 Id   Depth    Vertex collections   Edge collections   Options                                   Filter conditions
 10   1..100   CONFIG_ITEM          CONFIG_RELATION    uniqueVertices: none, uniqueEdges: path
 17   1..100   CONFIG_ITEM          CONFIG_RELATION    uniqueVertices: none, uniqueEdges: path

Optimization rules applied:
 Id   RuleName
  1   move-calculations-up
  2   move-filters-up
  3   remove-unnecessary-calculations
  4   move-calculations-up-2
  5   move-filters-up-2
  6   replace-or-with-in
  7   use-indexes
  8   remove-filter-covered-by-index
  9   optimize-traversals
 10   remove-unnecessary-calculations-2
 11   scatter-in-cluster
 12   remove-unnecessary-remote-scatter

This problem is rarely seen in webinterface, but it often appears in java-driver. Because I want to use limit and check the amount of data that meets the criteria, I execute the roughly the same statement twice.I don't know if that's why.

like this

If you only want to count them, you could try to not return the full config item, but just 1 - there are probably other places in the subquery where you could reduce the amount of data by just returning required parts of the document

This will correct these mistakes? I return 1 in another method, but it seems useless


add possibility to check a decrypted value, before setting a password…

I added a new task to check and validate a current encrypted value, so wee only set a password value only if they don't match. This results in lesser restarts, because the value is actually not changing. Otherwise in my current runs, the encrypted value gets overwritten, the task results in "changed" and splunk need a restart.
As an example I changed the workflow for the configure_deploymentclient.yml task.

Is this something to be helping or considering to implement?

Just to make sure I understand this. This will prevent ansible from changing the encrypted pass4SymmKey every time it runs, or change it if it does not match the value of splunk_ds_key?
I like it being in a separate task, so it can be re-used for other encrypted values.
How have you tested this?

I already used it for one of my customers and at my company lab, because we wanted to optimize the workflow and reduce service restarts, due to no change of the pass4SymmKeys.
Actually it's pretty easy, the encrypted value gets decrypted with the splunk.secret and compared to the ansible variable.
I tested it with a running deployment, one time without any change, so nothing will happen and the playbook runs straight through to the end. if you change as an example the key for the deploymentserver pass4SymmKey then splunk restarts, as the file itself changed.


spec: Update language for magic bytes major version

Reading this with the parentheses removed: "Changes to the spec of the spec are binary backwards compatibile within the major version."


Add IQM's device

IQM's first Device: a 5-qubit quantum computer. This PR contains just the description — connectivity towards the actual quantum unit will be delivered in subsequent PR.
IQM Finland Oy: meetiqm.com

Ping @olliahonen

Friendly ping @olliahonen - as I see there are only two minor nits left and you have to sign the CLA.

Friendly ping @olliahonen - as I see there are only two minor nits left and you have to sign the CLA.

Thanks. It seems the CLA is a blocker for us at this point, unfortunately.

Friendly ping @olliahonen - as I see there are only two minor nits left and you have to sign the CLA.

Thanks. It seems the CLA is a blocker for us at this point, unfortunately.

Is there something we can help with regarding the CLA? Do you mind explaining what the blocker is, specifically?

Friendly ping @olliahonen - as I see there are only two minor nits left and you have to sign the CLA.

Thanks. It seems the CLA is a blocker for us at this point, unfortunately.

Is there something we can help with regarding the CLA? Do you mind explaining what the blocker is, specifically?

I got some clarification around the history of this conversation from Markus. Thanks! I'm happy to keep this open until the issues get resolved.

We've agreed to take a different approach here, thanks for all the support thus far and hoping to resume the collaboration very soon!


Serialize and deserialize arrays

This PR serializes and deserializes unbounded arrays. Tested locally with two Python scripts (listener and talker), using different permutations of OpenSplice and FastRTPS.

Thanks for the patch @esteve! I agree that the printf statements, while useful when debugging, are probably better left out.
With that comment addressed the changes lgtm. I'll just start some CI (assuming that removing the printf's won't impact the result):

Linux:

 /

OS X:

 /

@wjwwood the printf statements next to throwing exceptions seem to be a recurring pattern in eProsima's code:
https://github.com/eProsima/ROS-RMW-Fast-RTPS-cpp/blob/master/rmw_fastrtps_cpp/include/rmw_fastrtps_cpp/TypeSupport_impl.h#L402
https://github.com/eProsima/ROS-RMW-Fast-RTPS-cpp/blob/master/rmw_fastrtps_cpp/include/rmw_fastrtps_cpp/TypeSupport_impl.h#L481
https://github.com/eProsima/ROS-RMW-Fast-RTPS-cpp/blob/master/rmw_fastrtps_cpp/include/rmw_fastrtps_cpp/TypeSupport_impl.h#L239
so I'm going to leave the printf statements in this PR, just for consistency, though I agree they all should be removed since they don't add much value.

@richiprosima I've rebased this and removed the printf calls, this should be mergeable now.

Can you please trigger the CI builds for these changes.

CI:

Linux:

OS X:

Windows:

I tested this PR with my .Net wrapper and it seems to work fine, apart from passing c-typesupport messages to cpp.
What works:

Sending and recieving messages in program(s) that use c-typesupport
Recieving messages sent from a cpp program in a program that uses the same  messages but with c-typesupport.

What doesn't work:

Sending messages from a program that uses messages with c-typesupport and recieving them in a cpp program.

@firesurfer thanks for testing this PR. That's weird, once the messages go through the wire, the typesupport should matter. Do you have a concrete example which I can test? I recall I tested this between rclpy (c-typesupport) and rclpp (c++-typesupport), and it seemed to work, but I'll check again.

@esteve I tested it only with my C# wrapper so far. In my testing workspace ( https://github.com/firesurfer/rclcs_testing_ws ) I got one program that uses in C#  - test_cs.exe (c-typesupport) and one program that uses  c++ -  test_cpp (c++-typesupport). Sending a message from the C# program to another program that uses the C# wrapper works. But sending a message from the C# wrapper to the C++ program doesn't work.
On the other side a program that uses the C# wrapper receives the message published from a C++ program. I haven't had the time yet to investigate this issue further but I think I can find some time to have a deeper look at it tomorrow.

@firesurfer do you have the message definition you used? I can test it out and see if I can find the problem.

@esteve  this is my dummy message: https://github.com/firesurfer/rclcs_testing_ws/blob/master/src/test_msgs/msg/Dummy.msg

@firesurfer thanks!

CI with fastrtps whitelisted in test_communication
Master:

This PR:

TD;DR this PR does fix the serialisation/deserialisation of dynamic primitive array messages (DynamicArrayPrimitives and BoundedArrayPrimitives) but doesn't fix the other arrays test cases, it can be merged as is without resulting in any regression.
@esteve do you prefer:

to merge this as is and we'll create a follow-up PR to address the remaining array test failures
allow us to push commits on your branch and merge this PR once it fixes all the array serialization problems ?

Here is the results of my investigation for the remaining test failures:

All non array test failures (Nested/Primitives) are due to rclpy.spin_once() behaving differently with fastrtps and other rmw implementations, need more investigation to figure out why, quick fix: relax test timeout
StaticArrayPrimitives fails because fixed size string arrays are not serialized/deserialized properly (the function serializeArray is only applied the first rosidl_generator_c__String element and the rest of the array is dropped (c.f. https://github.com/esteve/ROS-RMW-Fast-RTPS-cpp/blob/a4d829308e18d3c3d24b58f903f803bd8f1ada18/rmw_fastrtps_cpp/include/rmw_fastrtps_cpp/TypeSupport_impl.h#L267)). It uses the size of the String array instead of the size of the char array so the communication works only if you have an array longer than the individual strings in that array
StaticArrayNested IMO same string (de)serialization problem as StaticArrayPrimitives, works well if we remove strings from the equation
DynamicArrayNested feature not implemented (c.f. this todo)
BoundedArrayNested I assume it is the same as DynamicArrayNested but we may uncover more modifications to be done once the previous test case is fixed

Thank you so much for looking into this @mikaelarguedas!
I think it'd be fine to just merge this PR and continue any remaining bits
in a follow-up PR, so that @firesurfer and I can keep working on our stuff.
What's in this PR, while not complete, is still some progress.
On Sep 16, 2016 03:47, "Mikael Arguedas"<EMAIL_ADDRESS>wrote:

TD;DR this PR does fix the serialisation/deserialisation of dynamic
primitive array messages (DynamicArrayPrimitives and
BoundedArrayPrimitives) but doesn't fix the other arrays test cases, it
can be merged as is without resulting in any regression.
@esteve https://github.com/esteve do you prefer:

to merge this as is and we'll create a follow-up PR to address the
remaining array test failures
allow us to push commits on your branch
https://github.com/blog/2247-improving-collaboration-with-forks and
merge this PR once it fixes all the array serialization problems ?

Here is the results of my investigation for the remaining test failures:

All non array test failures (Nested/Primitives) are due to
rclpy.spin_once() behaving differently with fastrtps and other rmw
implementations, need more investigation to figure out why, quick fix:
relax test timeout
StaticArrayPrimitives fails because fixed size string arrays are not
serialized/deserialized properly (the function serializeArray is only
applied the first rosidl_generator_c__String element and the rest of
the array is dropped (c.f. https://github.com/esteve/ROS-
RMW-Fast-RTPS-cpp/blob/a4d829308e18d3c3d24b58f903f803
bd8f1ada18/rmw_fastrtps_cpp/include/rmw_fastrtps_cpp/
TypeSupport_impl.h#L267
https://github.com/esteve/ROS-RMW-Fast-RTPS-cpp/blob/a4d829308e18d3c3d24b58f903f803bd8f1ada18/rmw_fastrtps_cpp/include/rmw_fastrtps_cpp/TypeSupport_impl.h#L267)).
It uses the size of the String array instead of the size of the char array
so the communication works only if you have an array longer than the
individual strings in that array
StaticArrayNested IMO same string (de)serialization problem as
StaticArrayPrimitives, works well if we remove strings from the
equation
DynamicArrayNested feature not implemented (c.f. this todo
https://github.com/eProsima/ROS-RMW-Fast-RTPS-cpp/blob/master/rmw_fastrtps_cpp/include/rmw_fastrtps_cpp/TypeSupport_impl.h#L305
)
BoundedArrayNested I assume it is the same as DynamicArrayNested but
we may uncover more modifications to be done once the previous test case is
fixed

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/eProsima/ROS-RMW-Fast-RTPS-cpp/pull/45#issuecomment-247500051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACDVIOcRlEGX1RVF878mh2RClBpLFYoks5qqfUtgaJpZM4JA9Vl
.

After talking to @mikaelarguedas we will merge this as-is and go from there. Thanks.

@esteve @firesurfer #58 may solve some of the issues you encountered. The tests are passing in both rclcpp -> rclpy and rclpy -> rclcpp for all message types


Fix#685

Closes #
✅ Checklist

[x] I have followed every step in the contributing guide
[x] The PR title follows the convention.
[x] I ran and tested the code works

Steps

Setting WHITELISTED_EMAILS in .env.example:

I added the WHITELISTED_EMAILS variable to .env.example under # OPTIONAL VARIABLES with the value matt<EMAIL_ADDRESS>I ensured that the application reads this environment variable correctly.

Testing
I have tested the changes in this pull request as follows:

** Values to check wether the WHITELISTED_EMAILS validation works

<EMAIL_ADDRESS>or<EMAIL_ADDRESS>

Screenshots
https://github.com/triggerdotdev/trigger.dev/assets/106991686/717704f3-5d3f-4fc1-9458-072b0614fe5c
💯

hey @nicktrn  should i change the error message to some thing like Access Denied!

should i change the error message to some thing like Access Denied

We can change the error message later, I think what's more important is to check what happens when you pass an invalid RegEx string in that env var.

thanks for reviewing  i will impliment the changes and let you know.


fix: don't attempt to import tuples if none are present

Description

References
Fixes #368
Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[x] I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

To summarize the changes: We added a check for len(storeData.Tuples) == 0 after initializing the FGA client. 2. If there are no tuples, we print a message and return the response immediately. The progress bar initialization and tuple import process only occur if there are tuples to import. This should resolve the issue you're experiencing while still allowing the model to be imported successfully

You can review and help me out with running the tests.

hey any update from the side of the reviewer?

you are welcome!


Website builds, but does no longer deploy after last push.

Update: The update seemed to have gone through. I am not quite sure what fails to deploy.


Enable "inside this collection" modal on agent page

Is your feature request related to a problem? Please describe.
The # matches button in the collection tiles only open the Inside the Collection modal in the Search Results page, but not on the agent page in related collections
Describe the solution you'd like
The # matches buttons should operate the same on both pages
Additional context
This isn't a major priority if we want to wait until search usability testing to see how these buttons hold up in testing.

I am noticing that the mockups don't have the hit counts on them. I think we can wait a bit on this one, but one other course of action is to hide those badges on agent pages. I'm not sure they're as meaningful in this context.


Test improvements for PHPUnit, composer and PHP

Changed log

Since this PHP package requires php-7.2 version at least, it can upgrade the PHPUnit version to 8.0+.
Adding the .phpunit.result.cache file that is generated by PHPUnit 8.x version.
Adding the php-7.3 version test during Travis CI build.
Remove the --dev option for `` command because the following deprecated message:

You are using the deprecated option "--dev". It has no effect and will break in Composer 3.

Since upgrading to the PHPUnit ^8 version, it should use the expectException and expectExceptionMessage methods to replace annotation approaches.
Using the assertStringContainsString assertion to replace assertContains for assert contained string.
According to the official PHPUnit doc, it should use the protected function setUp(): void and protected function tearDown(): void methods.

I can fix up the psalm warnings separately.

Thank you 👍


Allow MediaPipe with any points (do not force reduce)

For Zifan,

Calculate the mean and STD for all points
do not reduce_holistic
get relevant points in runtime to transfer

done in https://github.com/sign-language-processing/pose-anonymization/commit/dedfde88482cf82d1091aa3e35d00feab84df5a4


你们arm64包改名了,要更新

https://github.com/v2fly/v2ray-core/releases/download/v4.27.0/v2ray-linux-arm64.zip这个包被你们改名了,导致更新失败.
root@pizero5:~# ./go.sh -p http://<IP_ADDRESS>:2080
Installing V2Ray v4.27.0 on aarch64
Downloading V2Ray: https://github.com/v2fly/v2ray-core/releases/download/v4.27.0/v2ray-linux-arm64.zip
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100     9  100     9    0     0      1      0  0:00:09  0:00:05  0:00:04     2
awk: not an option: -e
[/tmp/v2ray/v2ray.zip]
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Shutting down V2Ray service.
Archive:  /tmp/v2ray/v2ray.zip
End-of-central-directory signature not found.  Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive.  In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip:  cannot find zipfile directory in one of /tmp/v2ray/v2ray.zip or
/tmp/v2ray/v2ray.zip.zip, and cannot find /tmp/v2ray/v2ray.zip.ZIP, period.
Failed to copy V2Ray binary and resources.

请换用新版的安装脚本来更新（请注意遵照官方文档中给出的迁移建议
Refer: https://www.v2fly.org/guide/install.html#linux-安装脚本


Patches for d-bus formulae on old and new OSX versions

Patches for homebrew/homebrew#50219 and mistydemeo/tigerbrew#412.

Per discussion in the homebrew issue thread, I've also included a patch for old versions of OSX that are not supported by mainline homebrew; this patch will be referenced in tigerbrew or other compat repos that want DBus support on pre-10.6. OSXes. If that's against policy here, I can pull the file from this PR and host it myself.


Facebook share image

As discussed in issue #986, adding an image to facebook share.
This will make sharing pages of the website on facebook much more visible on the feed.
The image used is the word "Express" as used on the homepage of the website.

LGTM.  Thanks @gonenduk


Adding instruction on how to see following channels

I was unable to upload an image in the correct path, but I suggest an instruction like this to show people what channels they are following.

Hey @CodyTVWeber, thank you for your contribution! 👍
That's a great idea, I uploaded a fitting image.
If you want to contribute in the future, you can upload images into the static img folder here: https://github.com/OdyseeTeam/odysee-docs/tree/main/static/img/en, adding it in markdown can be done using the same file name:
![](/img/en/<file name>.png)

Hmm, I thought I tried that and it didn't work.  But I'll try again if I make any more changes.  Ty! :)


Fix unclosed HTML comment in Sphinx template.

Coverage remained the same when pulling 3b4ea7006ec044107284b3df3d8e45ddf08e55f0 on tseaver:fix-unclosed_html_comment_in_sphinx_template into 8a42ef583ad59e467dc2b3ac29c3d4f20e03c537 on GoogleCloudPlatform:master.

LGTM after the fact.
How did you discover that?

I was trying to debug a 'tox -e docs' failure, and staring at the page, I couldn't see the section it should have been in.


Haddock (and maybe hoogle) should be hosted somewhere for easier linking in documentation

We could use github pages.

We might also want the guide somewhere.

@MatthewCroughan has been working on an Hercules CI effects thingy to both generate a website from sources, as well as publish them statically somewhere (such as gh-pages branch). We can build on top of that.

@srid Yes, I have the effect mostly written on the add-hercules-ci branch of plutonomicon. But I am somewhat blocked by https://github.com/hercules-ci/hercules-ci-effects/issues/45. I will simply make another runner for this repository if this isn't solved soon, however that would mean getting rid of the powerful runner we use, or buying another one of equal spec.

#266


composer

Hi could u make it composer install version ? Thanks

Done 👍
You can install CalenStyle using command composer require nehakadam/calenstyle.
Thank you for suggestion!


FIx container_ip function on Mac

When using docker machine on Mac tests can't access container ip directly, so I'm using docker machine ip

@PI-Victor @csrwng need one of you mac guys to review this please :)

uhm, sorry for the late reply. i'll have a look at this

Changing the test runner template to know about docker-machine seems like a bad move. Please correct me if I'm wrong as I'm not familiar with the details, folks on Windows and macOS can now run Docker without Docker Machine, and I believe this patch would break running the tests for them.
@luiscoms can't you instead ssh to the Docker Machine VM and run the tests from there?

@luiscoms did you arrive at this by creating your own s2i image from the template, or are you trying to test some specific existing image?

@rhcarvalho I meld some experiences that I have when creating and editing some images on my own.
Some examples:
luiscoms/s2i-java
luiscoms/springboot-maven3-centos
luiscoms/s2i-nginx

@csrwng Can you test it please?

@PI-Victor @csrwng could you please test this on macOS?

I just rebase this branch

I'm testing it locally, will update shortly

So I haven't been able to make this work for me. Using docker-machine with virtualbox driver, I get:
https://gist.github.com/csrwng/95415fdf07e0c4a8d8c84bbde813a7ef
With Docker for Mac, it works (kind of) but a test won't succeed because the ip of the container is not accessible from the host:
https://gist.github.com/csrwng/b5eba998f46dab4b3e1f0f2ec8464d13
It definitely could be I'm doing something wrong

@csrwng I guess that is that issue #603 provoking this

@luiscoms Hi Luis, please could you rebase onto latest s2i making sure you're building on top of a branch which contains bd892aff569b6514925d82ab64299c028dbb5031? I'm hoping that commit should fix #603.

It is already rebased to latest release, @csrwng could you please test again?

@luiscoms make test worked great now using docker-machine. Thx! Please squash your commits.

[merge]


[bug] [v2] Can not open the dev console

Describe the bug
It was working fine until today. I cannot open the dev console now, also the context menu is lacking the inspect option. I am on 2.0 latest beta.
Reproduction
No response
Expected behavior
No response
Full tauri info output
[✔] Environment
    - OS: Windows 10.0.22631 X64
    ✔ WebView2: 123.0.2420.97
    ✔ MSVC:
        - Visual Studio Build Tools 2019
        - Visual Studio Community 2022
    ✔ rustc: 1.75.0 (82e1608df 2023-12-21)
    ✔ cargo: 1.75.0 (1d8b05cdd 2023-11-20)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 21.6.0
    - pnpm: 8.15.5
    - yarn: 1.22.21
    - npm: 10.2.4

[-] Packages
    - tauri [RUST]: 2.0.0-beta.15
    - tauri-build [RUST]: 2.0.0-beta.12
    - wry [RUST]: 0.39.1
    - tao [RUST]: 0.27.0
    - @tauri-apps/api [NPM]: 2.0.0-beta.7
    - @tauri-apps/cli [NPM]: 2.0.0-beta.12

[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../build
    - devUrl: http://localhost:5173/
    - framework: Svelte
    - bundler: Vite

Stack trace
No response
Additional context
No response

Are we talking about tauri dev or tauri build ? Are you using the --release (dev) or --debug (build) flags?

We found the problem.
I am starting with tauri dev. But recently we added an updater. I was working on a branch, and my version was lower than the latest. It seems the updater kills the app and starts it again. In release mode. And I don't have the console.


What happened to the examples for this library?!!!

I would love to try this library out, however I am having trouble figuring out how to use this library without any documentation or examples to hack away at....

Sorry nobody has gotten back to you, but please don't make lots of separate issues for the same thing. I've moved the discussion to https://github.com/go-gl/gltext/issues/21.


Add time units to -i  widget

Cloned from https://linaro.atlassian.net/browse/WPERF-892
Change https://gitlab.com/Linaro/WindowsPerf/windowsperf/-/merge_requests/589 adds new feature for --timeout and -i command line option.
Note: This ticket is for -i widget only (both sampling and counting).
DOD:

If applicable allow users to use below time units.
We want users to be able to OPTIONALLY specify time in different units of time:

ms for milliseconds.
s for seconds.
m for minutes.
h for hours.
d for days.

Note: However, sleep 2h30m not allowed!

@Alaaeddine-chakroun


Added arithmetic version of pow (Fixes: #1809)

This should fix #1809
Checklist

[x] Math issue #1809

[x] Copyright holder: Columbia University
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[ ] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
dependencies checks pass, (make test-math-dependencies)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

@bob-carpenter are both of these candidates through implicit conversion?
lib/stan_math/stan/math/rev/fun/pow.hpp:305:26: note: candidate function [with T = double, $1 = void]
inline std::complex<var> pow(T x, const std::complex<var>& y) {
                         ^
lib/stan_math/stan/math/rev/fun/pow.hpp:320:26: note: candidate function
inline std::complex<var> pow(const std::complex<var>& x, int y) {

@bob-carpenter Looks like it's blowing up on a Mac in the downstream tests (I'm guessing it's a Mac cause of the use of /usr/local/Cellar which is a brew thing): https://jenkins.mc-stan.org/blue/organizations/jenkins/Stan/detail/downstream_tests/1438/pipeline
I swapped in explicitly the only overloads we need that C99 doesn't provide and to see what happens (pow(double, int), pow(int, double), pow(int, int)). On Ubuntu 16.04/clang++-6.0/gcc-5, the rosenbrock stuff compiles (as part of the Stan tests), but the compiler gave me errors about not having a pow(double, double) implementation:
test/unit/math/mix/fun/pow_test.cpp:37:12), double, double>' requested here
  stan::test::expect_ad(f, -0.4, 0.5);
              ^
./stan/math/prim/fun/pow.hpp:32:15: note: candidate function
inline double pow(double x, int y) {
              ^
./stan/math/prim/fun/pow.hpp:44:15: note: candidate function
inline double pow(int x, double y) {
...

So in this case it's not finding the C99 pow definitions.
I think this is because there's a difference in what:
using namespace stan::math;

and
using stan::math::pow;

mean. Because Rosenbrock uses the first, it works, and the tests use the second, they fail. If I modify the tests to use using namespace stan::math, they work (and find the C99 pow definitions).
Check the difference in rule 6 & 7 here: https://en.cppreference.com/w/cpp/language/namespace
using namespace expands the scope where ADL will look.

Okay so backing up a bit, what we want is:

Any time someone calls a standard function with Stan math autodiff types, they'll get the Stan math types

If someone calls the C math functions with Stan math autodiff types, undefined behavior (things probably fail)

Any time someone calls pow in the stan::math namespace, there will be no ambiguities between the standard C++ definitions, the Stan definitions, and the C definitions

I think what we need to do is inside stan/math/prim/fun/pow.hpp is:
namespace stan {
namespace math {
using std::pow;
}
}

This gets rid of any ambiguities between Stan and std::math and in the case where we're operating in the stan::math namespace we'll hit the std::pow definition with ADL before we find the C version so there won't be ambiguities there.

I switched the implementation to:
namespace stan {
  namespace math {
    using std::pow;
  }
}

And added a bunch of tests that I think should help catch problems during the math tests. I'm not sure I got everything though honestly. Can discuss further later if these tests pass.

From @SteveBronder

are both of these candidates through implicit conversion

Yes.  It requires promoting an int to std::complex<double> or a double to var.  But keep in mind that we absolutely need the implicit constructors for everything else in the interface to work.  It's part of the spec for std::complex that the constructors are implicit.

From @bbbales2

I switched the implementation to:

namespace stan {
  namespace math {
    using std::pow;
  }
}

We absolutely cannot have a namespace-level using statement.

We would like this to work idiomatically using argument-dependent lookup, no matter what T1 and T2 are:
using std::pow;
T1 x;
T2 y;
pow(x, y);

That means the solution may need to be having using std::pow in our model code.

We absolutely cannot have a namespace-level using statement.

Well I get that this is given out as advice, but why? I think this is the behavior we want.

I think this is the behavior we want.

Modulo we kinda define the behavior we want cause we can just change the code generation.

I acutally meant more in the sense of wanting to work with argument-dependent lookup (ADL).  That's the way to ensure that generic written code will work with Stan types dropped in.  Let me repeat.  The pattern we need to work to support an idiomatic ADL is:
using stan::math::var;
using std::pow;
auto w = pow(3.1., 2.5);  // resolves to std::pow
auto x = pow(var(3.1), 2);  // next three bring in stan::math::pow
auto y = pow(3.1, var(2));
auto z = pow(var(3.1, var(2));

In words, an idiomatic usage has a using XXX statement to bring in definitions for primitives, then definitions for other types are brought in by argument-dependent lookup.  That's why I was suggesting the using std::pow in the math library.
But, that's not going to work for us in models.  The reason is that the following using statement in our models will mess us up.
using namespace stan::math;

With both using statements, as in
using namespace stan::math;  // brings in stan::math::pow
using std::pow;

auto x = pow(3.1, 2.5);  // ambiguous between std::pow and stan::math::pow

we have the problem that the pow call is ambiguous.
then  we ran into was that mingw32 didn't implement pow(double, int) as the C++11 spec requires, so we were getting ambiguities with 1 promotion between pow(double, double) and pow(var, int).  We couldn't just write pow(T, int) with a qualifier that T be a var, because then it wouldn't be specific enough to beat the library function when the library function is defined by a compiler/library combo.  Remember that gcc, clang, mingw, and now apparently some 5.5 version of clang on Linux all have different behaviors around which pow overloads they define.
To summaize, I see two options:

The generic solution we're testing now, which should be OK as long as we make sure never to have using statements for std::pow and stan::math::pow in the same scope.

A model that
(a) has using std::pow; and similarly for all standard library functions that can be used as Stan functions,
(b) has using statements for all the Stan math functions that won't be brought in by ADL, and
(c) does not have a generic using namespace stan::math; statement.

From a math library client perspective, (2) is far superior.   But that's going to be a huge pain for us on the model side.  I think we should target getting there eventually.  That would also allow us to clean up all those stan::math::exp(...) examples in the generated code and replace them with exp(...).
The ideal long-term goal for generated model code would be completely generic in that users could drop in their own types as long as they supported the basic C++ built-in arithmetic and standard library functions.  That'd also require us to implement all Stan functions generically down to basic arithmetic;  as is, we have lots of functions with a double, var and fvar<V> implementation, but not a generic one for type T.

Looks like a Jenkins problem:

make: mkdir: Exec format error
make -j6 test/performance/logistic_test failed

I restarted the performance tests.

@serban-nicusor-toptal : No idea what's going wrong, but it appears to be a Jenkins test config issue (or general test config issue).  After restarting, it failed in exactly the same place.
But it's progress I could at least find the error in the performance tests on my own.  This is confusing, too, because we got the email with results of the performance tests, but there's not a simple file with "logistic" in the name among them.

Hey, it looks like the machine that ran the tests went down.
Cannot contact old-imac: java.lang.InterruptedException it is right above the mkdir error.
I've rebooted the build from the failing step, may be just a network error or the machine dies while running the build. We'll see after this run.

Thanks!  Looks like it worked.  I'll review and merge.

Since it's working, I made a post about the using declaration: https://discourse.mc-stan.org/t/using-std-pow-inside-stan-math-namespace/13975 like we discussed. So we can get comments there hopefully and get this merged by the weekend if nobody finds big problems.

So looking at all the candidate functions
                                            ^
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:153:17: note: candidate function
__MATHCALL_VEC (pow,, (_Mdouble_ __x, _Mdouble_ __y));
                ^

^ That's the one we want right?
What if for all the ones here we just change the signatures to use SFINAE to kick them out? So for instance the first one here would just be
template <typename Complex, typename Arith,
  require_complex_t<Complex>* = nullptr,
  require_arithmetic_t<Arith>* = nullptr>
inline std::complex<var> pow(const Complex& x, Arith y) {

I think that avoids namespace issues and preserves just using the standard lookup rules
lib/stan_math/stan/math/rev/fun/pow.hpp:320:26: note: candidate function
inline std::complex<var> pow(const std::complex<var>& x, int y) {
                         ^
lib/stan_math/stan/math/rev/fun/pow.hpp:140:12: note: candidate function [with T = int, $1 = void]
inline var pow(const var& base, T exponent) {
           ^
lib/stan_math/stan/math/rev/fun/pow.hpp:180:12: note: candidate function [with T = double, $1 = void]
inline var pow(T base, const var& exponent) {
           ^
lib/stan_math/stan/math/rev/fun/pow.hpp:242:26: note: candidate function [with T = int, $1 = void]
inline std::complex<var> pow(const std::complex<var>& x, T y) {
                         ^
lib/stan_math/stan/math/rev/fun/pow.hpp:305:26: note: candidate function [with T = double, $1 = void]
inline std::complex<var> pow(T x, const std::complex<var>& y) {
                         ^
lib/stan_math/stan/math/rev/fun/pow.hpp:119:12: note: candidate function
inline var pow(const var& base, const var& exponent) {
           ^
lib/stan_math/stan/math/rev/fun/pow.hpp:203:26: note: candidate function
inline std::complex<var> pow(const std::complex<var>& x,
                         ^
lib/stan_math/stan/math/rev/fun/pow.hpp:229:26: note: candidate function
inline std::complex<var> pow(const std::complex<var>& x, const var& y) {
                         ^
lib/stan_math/stan/math/rev/fun/pow.hpp:279:26: note: candidate function
inline std::complex<var> pow(const var& x, const std::complex<var>& y) {

What if for all the ones here we just change the signatures to use SFINAE to kick them out? So for instance the first below here would just be

So basically this signature won't allow for promotions from (double, int)?

idt int to double is the issue is it? It looks like because var and complex are implicitly convertible from arithmetic types they are candidates when we don't want them to be. Otherwise we could

Replace the second template with double
do require_t<std::is_same<double, T2>> for the sample template

Though 2 feels gross. I think the one I have above would work

I'd have to try this out, I think.
I mean, it's true we don't want doubles/ints promoting to vars through argument calls like that for efficiency, but that doesn't mean we aren't leaning on it somewhere I'm not thinking about.
By (double, int) I meant the first argument is double, second is int.

I mean, it's true we don't want doubles/ints promoting to vars through argument calls like that for efficiency, but that doesn't mean we aren't leaning on it somewhere I'm not thinking about.

I'm not sure where this would be true and I'm like 90% sure it's actually where the error comes from. @bob-carpenter thoughts? I could be missing something here

By (double, int) I meant the first argument is double, second is int.

I think just by doing the above thing the double double version is the only possible candidate

The discussion's now half on Discourse and half here, so I'll follow up here to comments posted on GitHub.
I believe @bbbales2 figured out the right solution to this problem---have a using std::pow; in the stan::math namespace.  I have one final question, though---will that introduce an ambiguity between std::pow and stan::math::pow if they're both in scope or does the compiler know they're the same function?
As I keep trying to emphasize, the pure type traits version isn't workable in general because it's not specific enough and won't get chosen over library versions in cases where we need it.  We might be able to come up with some hybrid solution that type traits out some of them and has other more specialized versions.
We want to allow double and int to promote to any of our scalar types (complex, var, complex-var, etc.).  Promoting never causes an error, just a loss of efficiency compared to a direct primitive implementation.  It's never a mistake in Stan to call a lower type function if available.

std::pow and stan::math::pow if they're both in scope

Should be tested here: https://github.com/stan-dev/math/pull/1810/files#diff-acb4663890da3d3806032f1554bea099R37

As I keep trying to emphasize, the pure type traits version isn't workable in general because it's not specific enough and won't get chosen over library versions in cases where we need it. We might be able to come up with some hybrid solution that type traits out some of them and has other more specialized versions.

Can you show me an example where this would fail to do what we want using type traits?

We want to allow double and int to promote to any of our scalar types (complex, var, complex-var, etc.). Promoting never causes an error, just a loss of efficiency compared to a direct primitive implementation. It's never a mistake in Stan to call a lower type function if available.

I think there's some confusion on my end here. Yes i agree we want to allow promotion, but if someone does
double x = 1.0;
int y = 2;
auto v = exp(x, y);

I don't see why we would ever want to allow that auto to resolve to complex etc. My worry is that if someone does something in stan math and doesn't do the right include order for usings then that's going to be possible.

The solution over here is probably the simpler stopgap to getting this to work if we don't want using std::pow in math: https://github.com/stan-dev/stan/pull/2906 .
I'm happy with just putting using std::pow in math or the generated code for now and bringing this issue up again after the release.
Getting rid of implicit casts in pow might work, but I don't think we'd want to do this generally just cuz it means writing tons and tons of functions.

There's a pow(T, int) and pow(T, T) built into the standard library definitions (but keep in mind which specific templates are available depends on library implementation---it's the wild west once you get to Windows and std::complex).  If you implement pow(T, U) with traits, it won't match better than these library definitions.  All of the unary functions are implemented as, e.g., exp(T), so there's an issue with these if you just try to traits them out.
I would suggest you try it for yourself.  Maybe there's something I'm missing here.

My worry is that if someone does something in stan math and doesn't do the right include order for usings then that's going to be possible.

When is overpromotion going to be a problem?  Each of the autodiff files should be including the primitive version, so I don't even see how it'll be a problem if we have the instantiations covered properly.
We've decided that end users should be using our top-level includes, which take care of this all at once.  Math library developers need to understand C++ include order.

@rok-cesnovar, @SteveBronder, @bob-carpenter, anyone want to get this?
This removes the mingw pow(double, int) implementation. Including std::pow in the code generation should make this unnecessary (https://github.com/stan-dev/stan/pull/2906#issuecomment-608524966).

Otherwise this is fine, but how do we stage the testing?

The stan and stanc3 code is already in (https://github.com/stan-dev/stan/pull/2906#issuecomment-608524966, https://github.com/stan-dev/stanc3/pull/492). This is the last one.
Presumably the stan stuff didn't get tested on Windows with mingw so it passed (got tested with g++).

Stanc3 had failures on master since the complex stuff was added. Adding using std::pow fixed that so I think we can proceed here.

@bob-carpenter this needs merged so that there aren't ambiguities between using std::pow and the pow(double, int) implementation currently in stan-dev/math/develop. I suspect cmdstan on mingw would fail now.


bug: Scrollling not working on Samsung S3, Android 4.3, Internet browser

Type: bug
Platform: android 4.3 browser
I posted this as a comment on #1433  but am not sure how to re-open it.
Re-posting here in a new issue - I hope that is appropriate.
I have this scrolling issue also.
On my own codebase I am using latest ionic (1.0.0-beta.14), while following codepen uses nightly.
The problem is reproduceable in both.
Here is the codepen:
http://codepen.io/dglenn/pen/xbLWEm
On my physical device (Galaxy S3 running Android 4.3) I cannot scroll the resulting list.
The other physical device I have is iPhone 4s on which it scrolls fine.
On desktops it works fine also.
Using browserstack I have run through a bunch of emulated devices, and they all seem to scroll fine, but the combination of Galaxy S3 running 4.3 is not available, so I am unable to confirm the exact platform versions this is happening on, but it is definitely happening on Galaxy S3 / 4.3 combination.
Note that Chrome on the same S3 scrolls correctly, this issue only affects the native browser.
I hope this is sufficient info, but please let me know if not.

Greetings @dannyg!
We are now requiring all issues to be submitted through our custom issue form so that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
This issue will be closed if not resubmitted through the form. Please fill out the rest of the form so that we may assist you.
Thank you for allowing me to assist you.

Just want to verify, you're seeing the issue once you compile down to an app right?

Hi Mike,
I am seeing this when running in browser.
i.e. if I just click on the CodePen link on my Galaxy S3 (using default browser) I cannot scroll the list.
Let me know if I can provide any further details,
Dan

Have you compiled this down into an app though and tested it?

Hi Mike,
I do not intend to compile my app for Android, but rather users will access via a browser (it will be deployed as an app for iOS).
If it helps with diagnostics though, I just compiled it to Android adk and ran it on the Galaxy S3, and can confirm that the scrolling suffers from the same problem.
(To confirm: all works fine on iOS whether via safari or deployed as an app).
Let me know if I can get further info.
Thanks,
Dan

Try changing the loop to this
http://codepen.io/mhartington/pen/VYyKRj
Also, try a simplified demo on the device. I just tested again, and wasn't able to reproduce the issue

Hi Mike,
I clicked on your codepen from my device - and it worked! It scrolled fine.
I looked at differences for a while scratching my head, and have discovered something.
Here is an exact fork of your code-pen that does NOT work on my device (cannot scroll):
http://codepen.io/dglenn/pen/NPXXGd
The only difference is I changed

to

i.e. from nightly build to the most recent beta of 1.0.0 (which is what I use locally).
So, there is some change in the ionic codebase between '1.0.0-beta.14' and 'nightly' that has fixed this issue.  I'm not sure which one.
Whatever the change was, I expect it will be in beta.15...
Thanks for your assistance Mike - still not sure what was causing it, but it should go away in next beta release.
Daniel

This is an issue again...
The nightly example above is not working:
http://codepen.io/mhartington/pen/VYyKRj
I'm using Ionic v1.1.1 myself and it is also not scrolling (updated since today)

I'm using Ionic 1.4.2, I upload app to Ionic View and open in Samsung Galaxy S3 to test, but scroll and CSS3 display:flex not work.

@adrianoresende http://caniuse.com/#search=display%3Aflex


Add highlighting to the changed lines

I think if the changed lines stay highlighted or somehow distinguishable from the unchanged lines, it makes this awesome tool much more usable.
Update: Seems like this is the place to start:  https://github.com/pomber/git-history/blob/master/src/history.js#L118

:+1: I'm working on this

I agree very much.


Do not configure secrets or content for analytics

This is the first part of removing Analytics integration.
It just updates the release notes, and removes the recipe that configures actions.json and shared secrets.
Signed-off-by: Marc A. Paradise<EMAIL_ADDRESS>

@srenatus I'd rather document it - deleting needed files without warning and with no fallback makes me nervous. While this release makes it so that new installs won't be compatible, leaving the files behind will - for a time at least - let people keep running their existing analytics installs without any nasty surprises.


[SR-13601] Boolean-valued case checking expressions

Previous ID
SR-13601

Radar
rdar://61035328

Original Reporter
@typesanitizer

Type
New Feature

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
New Feature, StarterProposal

Assignee
None

Priority
Medium

md5: 69379195ba792a711faff79b86aa3415

is duplicated by:

SR-4644 Create an expression for checking enum cases

Issue Description:
Allowing code patterns like (strawman syntax, we could potentially use ~= instead of =):
XCTAssertTrue(case .x(10) = expr1)
XCTAssertTrue(case .x(_) = expr2)

would make pattern checks more ergonomic.
The alternatives today are:

Use ==: Doesn't work if the type is not Equatable, doesn't work for ignoring bindings as in the second example.

Use an immediately invoked function expression (IIFE) with a switch statement: much more verbose than the suggested syntax.

See also: https://forums.swift.org/t/proposal-sanity-check-assigning-a-case-statement-to-a-boolean/40584

@AnthonyLatsis could you mention which issue this is a duplicate of?

Duplicate of #47221


Set-DBADBCompression Not Compressing All Tables Recommended for Compression

Steps to Reproduce
/*
SELECT
SCHEMA_NAME(sys.objects.schema_id) AS [SchemaName]
,OBJECT_NAME(sys.objects.object_id) AS [ObjectName]
,[rows]
,[data_compression_desc]
,[index_id] as [IndexID_on_Table]

FROM sys.partitions
INNER JOIN sys.objects ON sys.partitions.object_id = sys.objects.object_id
WHERE data_compression > 0
AND SCHEMA_NAME(sys.objects.schema_id) <> 'SYS'
ORDER BY SchemaName, ObjectName
*/

<#
   Get-Date | Out-File -FilePath C:\Users\LMarkum\Desktop\AdvWorks_CompressionResults_12-14-18.txt

$Results = Test-DbaDbCompression -SQLInstance LMarkum\SQL2017 -Database Adventureworks2017 | WHERE {$_.CompressionTypeRecommendation -NotLike "?" -AND $_.CompressionTypeRecommendation -NotLike "NO_GAIN" } | Out-File C:\Users\LMarkum\Desktop\AdvWorks_CompressionResults_12-14-18.txt -Append

Set-DBADBCompression -SqlInstance LMarkum\SQL2017 -Database AdventureWorks2017 -InputObject $Results

Get-Date | Out-File -FilePath C:\Users\LMarkum\Desktop\AdvWorks_CompressionResults_12-14-18.txt -Append
#>

Expected Behavior
The output of Test-DBADBCompression shows that this index, among others should be compressed.
ComputerName                  : LMARKUM
InstanceName                  : SQL2017
SqlInstance                   : LMARKUM\SQL2017
Database                      : AdventureWorks2017
Schema                        : Person
TableName                     : BusinessEntityContact
IndexName                     : PK_BusinessEntityContact_BusinessEntityID_PersonID_ContactTypeID
Partition                     : 1
IndexID                       : 1
IndexType                     : CLUSTERED
PercentScan                   :
PercentUpdate                 :
RowEstimatePercentOriginal    : 92
PageEstimatePercentOriginal   : 92
CompressionTypeRecommendation : ROW
SizeCurrent                   : 64.00 KB
SizeRequested                 : 56.00 KB
PercentCompression            : 12.50
Actual Behavior
When I run the above provided T-SQL to see what tables were compressed, I get no rows back.
Environmental data

PowerShell: <! PSVersion 5.1.17134.407, PSEdition Desktop, PSCompatibleVersions 1,2,3,4, BuildVersion 10.0.17134.407, CLR Version 4.0.30319.4200, WSManStackVersion 3.0, PSRemotingProtocolVersion 2.3, Serializationversion <IP_ADDRESS> >

SQL Server: <! Original problem occurred on Microsoft SQL Server 2008 (SP3) - 10.0.5500.0 (X64)   Sep 21 2011 22:45:45   Copyright (c) 1988-2008 Microsoft Corporation  Enterprise Edition (64-bit) on Windows NT 6.1  (Build 7601: Service Pack 1) (VM) .  I tested on  Microsoft SQL Server 2017 (RTM-CU9-GDR) (KB4293805) - 14.0.3035.2 (X64)   Jul  6 2018 18:24:36   Copyright (C) 2017 Microsoft Corporation  Developer Edition (64-bit) on Windows 10 Enterprise 10.0  (Build 17134: )  and had the same issue.>

Thanks for the report! We'll look into it shortly.

I'll take a look this weekend

Hey @lmarkum, I'm unable to reproduce. I think this line might be the problem, you are piping to Out-File so there is nothing in $Results. Can you check your $Results param and see if there is anything in it before you pass it into Set-DbaDbCompression.
$Results = Test-DbaDbCompression -SQLInstance LMarkum\SQL2017 -Database Adventureworks2017 |
WHERE {$_.CompressionTypeRecommendation -NotLike "?" -AND $_.CompressionTypeRecommendation -NotLike "NO_GAIN" } |
Out-File C:\Users\LMarkum\Desktop\AdvWorks_CompressionResults_12-14-18.txt -Append

I ran the following and then checked the compression and it looks ok.
$res = Test-DbaDbCompression -SqlInstance $svr -Database adventureworks2017 |
WHERE {$_.CompressionTypeRecommendation -NotLike "?" -AND $_.CompressionTypeRecommendation -NotLike "NO_GAIN" }

Set-DbaDbCompression -SqlInstance $svr -Database AdventureWorks2017 -InputObject $res -Verbose

Let me know what you think.

thanks Jess! will close as unable to repro

My apologies, I didn't see any notification about this issue from a couple of weeks ago, but I did see the notification about it being closed.
Some of the data is compressed, as shown in the data in the file produced by out-file. So, $Results isn't empty.  I want to be able to output what the command does and in my case it isn't compressing everything, I'll look at this more closely when I get back to work on 1/2.

Sounds good @lmarkum, let me know what you find out.


Move to production

You would have to change this line:
https://github.com/EOSC-synergy/eosc-perf/blob/74d8fe85d2be5a9018845150cbba8c6adaa5a990/app/controller/authenticator.py#L19
By this:
CONF_URL = 'https://aai.egi.eu/oidc/.well-known/openid-configuration'

This should now be configurable by turning debug on or off. See 7d571918eab7b69b213a7291e14af939f9dced75

As the service is now running in production, I think I can close this.


fix(metrics): Normalize dashes to underscores in metrics

Dashes are not supported in metric names on Sentry DDM. This updates
validation and replaces dashes with underscores. Tag keys in sentry
support dashes, too.

Marking this as draft. We are going to normalize this in Relay, so we can continue sending this too and later on allow dashes even.

Closing in favor of full normalization in https://github.com/getsentry/relay/pull/2769


Rust: other crates in workspace are not updated

Let's say both root Cargo.toml and libs/somelib/Cargo.toml have dependency A. When dependency A is updated, I get a pull request only for the root crate (and no PR for somelib). That often leads to having different dependency versions. If some struct instances of the library A are shared between the crates, that will definitely lead to a build failure.
Here's a simplified example of a project structure I'm working on:
/Catgo.toml
/Cargo.lock
/libs/somelib/Cargo.toml

My .dependabot/config.yml:
version: 1
update_configs:

  - package_manager: "rust:cargo"
    directory: "/"
    update_schedule: "live"

  - package_manager: "rust:cargo"
    directory: "libs/somelib/"
    update_schedule: "live"

^ I hope I haven't misconfigured anything, please, correct me if the issue is just on my side. At least I can see all the specified crates in dependabot dashboard, so I assume my configuration is correct...
I believe #1190 can help making this workflow more convenient, but for now just several separate PRs would be nice to have.

Hmm, Dependabot should already be dealing with Rust workspaces just fine - can you tag @dependabot in a PR which has this issue? It's hard to debug in the abstract.

@greysteil I've just tagged @dependabot in the PR. It's in a private repo, I assume that shouldn't be an issue for you to be able to check it?

Great, thanks - I’ll check it out.

I've just taken a look at the files Dependabot is processing from that repo. It looks like you have a [workspace] line in the top-level Cargo.toml, but you don't specify any members of that workspace. Then you specify a bunch of path dependencies, which I think you want to have as members of the workspace, but because they're not Dependabot treats them as though they were being vendored.
You can fix the above by adding a members = [...] line to your top-level Cargo.toml. There are some docs here on how that works.
Does the above make sense? I'll mark this as resolved if so.

@greysteil, thanks for looking into it!
Yeah, I though the problem would be with [workspace] too.
The thing is that cargo automatically treats all the path dependencies as workspace members, so you don't have to specify them manually. I think that dependabot should do it as well, if it sees the [workspace] section. Is it possible to implement the same functionality for it? That seems to be the right way to do it.
And in order to bring the full support for the manifest file, exclude has to be taken into account as well...
Here's the full documentation in The Cargo Book: https://doc.rust-lang.org/cargo/reference/manifest.html#the-workspace-section

Oh.. And another thing: I have all the workspace members specified in the .dependabot/config.yml. It doesn't seem to be completely ignored.. Though for some dependencies I receive PRs for workspace members, and for others I do not. My first assumption is that I will not receive PRs for members if the same dependency is specified in the root Cargo.toml.

The thing is that cargo automatically treats all the path dependencies as workspace members, so you don't have to specify them manually.

Oh interesting, we should definitely do that! I'll get that fixed.

Fixed in https://github.com/dependabot/dependabot-core/commit/9a08f39c12e20c1bcf73ea88a79b93492f508b6b which I'll deploy now. You'll want to remove the config file entries for everything other than the top-level Cargo.toml, as everything else will now be picked up automatically.

@greysteil That's not a general fix. I have a Cargo.toml like this:
[package]
# ...
[workspace]
members = ["not-a-path-dependency"]
[dependencies]
workspace-member = { path = "path-dependency" }

Both not-a-path-dependency and path-dependency should be workspace member, but path-dependency/Cargo.toml is not monitored (not shown in the "Monitored dependency files" list). (I'm using GitHub-native Dependabot.)

Thanks for the report @hyd-dev. I don't work on Dependabot directly anymore, but if you or anyone else is up for submitting a pull request I'm sure the team would be delighted. GitHub-native Dependabot uses this library under the hood, so you're in the right place! :octocat:

I wish to submit a PR but I don't know Ruby at all. However the logic is simple: just appending path_dependency_paths_from_file(file) to the Cargo.toml array unconditionally.


enhance setup of DNAT port-forwarding

Several cleanups and enhancements to the DNAT port forwarding which allows access to cloud VMs on hosts like blacher.arch.suse.de which run the clouds on private networks which aren't routable from within the corporate network. The main highlights are:

Supports separate non-conflicting DNAT ports for each cloud
Each cloud's iptables setup is now written to /etc/init.d/boot.mkcloud.d/$cloudname
/etc/init.d/boot.mkcloud is still supported for backwards-compatibility and for mkch*.cloud.suse.de hosts
Guards against duplicate rule insertion
Doesn't flush the PREROUTING chain every time
Adds forwarding for Hawk and mosh
Doesn't forward admin server ports on non-admin nodes, and vice-versa.

Supersedes #1193.

The Code Climate complaints can be ignored, because the FIXMEs are describing existing issues, not newly added ones.

 (3) S47P13 Implement new OS upgrade for nodes

@dguitarbite @bmwiedemann Please can you review this? Thanks!

+1

Rebased, and fixed mosh port forwarding to work with a range.

@bmwiedemann @dguitarbite Are you OK with this?

@aspiers Yes, +1. Merge merge.

:+1:

I have tested this late Friday evening last week. We should merge this change asap.
+1

still :+1:

@jdsn Thanks, but we're not using LGTM any more :-) You'll need to do a github code review going forwards.
@dguitarbite Thanks for the approval, but I wonder why github was still counting this as valid given that I did a force push after you submitted the approval ... I thought that was supposed to reset all votes, but I guess we'll learn how it behaves with future PRs ...
Gating failed but I guess it wasn't related to this PR but instead to a failure of chef-client on node -01:
[2016-09-26T11:18:57+00:00] ERROR: execute[populate-dispersion] (swift::dispersion line 111) had an error: Command timed out after 600s:
Command execeded allowed execution time, killed by TERM signal.

@aspiers Looks fishy, let us report this if it occurs again.


Sorting unread items first

Is there a way to sort the items of a feed by date with unread items first? What happens right now is that items are simply sorted by date, and if a new item is added with an older date it could end up at the end of the list.

Currently, there is no way to do this, but I think we can extend the existing article-sort-order with a new field, unread, and allow to specify multiple sorting fields like this: article-sort-order "date-asc,unread". This will first sort by date, and then by the "unread" flag. Since we're using stable sorting algorithms, the second sort will preserve the order for "equal" items, i.e. items within "read" and "unread" groups will both be sorted by date.
In the UI, users will have to either press g/G multiple times, use :set to change article-sort-order, or create a macro that calls sort/rev-sort multiple times.
How does that proposal sound? Do you see any holes in my thinking here?

Sounds good. However  for me it's enough to have a setting in the config file, I don't really care about a UI key for this. For example if there is a setting "unread first", the unread items will be at the top regardless of what sorting is in place.

Sure, but there are other users as well, and they might come up with similar-yet-different use-cases, like https://github.com/akrennmair/newsbeuter/issues/465. So I'm trying to come up with a design that covers more than one use-case while remaining actually useable.

Is there a chance this will be implemented?

As long as the issue is open, there's always a chance :) I'm not aware of anyone working on this right now though.
Since the proposed design didn't get any opposition in the 4 years that passed, here's a rough plan on how to implement this:

extend FeedSortStrategy and ArticleSortStrategy (include/configcontainer.h) to contain a sequence of sorts. This will likely break FeedContainer::sort_feeds() and RssFeed::sort_unlocked() -- fix them. Please extend the tests in tests/feedcontainer.cpp and test/rssfeed.cpp to demonstrate the new behaviour
if the methods weren't broken on the previous step, please add tests to demonstrate multiple sorts and fix the implementation
update ConfigContainer::get_feed_sort_strategy() to understand the syntax proposed above. Please add tests in tests/configcontainer.cpp. Ditto for get_article_sort_strategy()
update the documentation in doc/. You can run git grep -- -sort-order to find all the relevant places

This actually looks like something that a newcomer could do even with basic knowledge of C++ and English, so I'm labelling this issue accordingly.

Hey I would like to try and work on this! Im having trouble building newsboat on my mac but once it's figured out id love to contribute.

Good! Building on macOS might be tricky because of #2280. If you run into errors you can't figure out, please open a new issue and we'll try to help.


Extend certificate validity

Working on https://github.com/akka/akka-grpc/issues/352 I tried to use the certificates in play-scala-tls-example just to be bitten by expired certificates.
Turn out #77 was incomplete and was only extending the duration of some elements (but not the certificates).

Thanks @ignasi35.

Mergify! Y U NO MERGE?!


adding joi allow(null) to model associations

Description
As per the title adding allow null to enable removing of model associations.
Check List

[ ] All test passed.
[ ] Added/updated tests to ensure fix works without regression.

Great! Thanks bud!


Fix em fucntion to accept px or not

At the moment em() helper function falls down if px units are present in the argument value for either of the two arguments it accepts.
This PR fixes this issue, so the em() function now accepts arguments with px units and without.
See test here: https://codepen.io/anon/pen/NwqRZd

done


Remove "Question ID" from Program Admin view of applications

Program Admins would like to view applications within the web browser. It would make it more obvious which question within the form they were reviewing if the question text was more obvious. Right now, the "Question ID" is the first thing Program Admins see. They recommend removing "Question ID" and making the question text more obvious.
Describe the solution you'd like
Remove "Question ID" from the program admin's application review page. Increase the size of the question text.
Additional context
Screenshot included

This continues to be a sticking point for program admins when reviewing applications--For staff with Utility Discount Program, Emergency Bill Assistance (testing), and Ride Now (testing)


Typhon wallet is not working

I'm trying to connect typhon wallet  its not work for me .
Code I'm running :
import { useWallet, useLovelace, CardanoWallet } from "@meshsdk/react";  const { wallet, connected, name, connecting, connect, disconnect, error } = useWallet(); connect("typhoncip30");
Note :
I'm using latest version of @meshsdk/react
Error :

Hey @walifile try this instead: connect("Typhon Wallet")

Thanks @jeremybarnes2342 its work for me


Librivox

Source Site
https://librivox.org/
Value Provided
huge repository of public domain audiobooks
Licenses Provided
Public Domain // CC0
Implementation

[ ] 🙋 I would be interested in implementing this feature.

This appears to be the API: https://librivox.org/api/feed/audiobooks
Their forum also seems to be a good resource for learning about the API: https://forum.librivox.org/viewtopic.php?p=2153488&hilit=api#p2153488


[TF-TRT] Migrate saved calibration tables from attribute to asset

This PR does the following:
@bixia1 for review
CC: @tfeher @DEKHTIARJonathan

Adds functionality to allow saving and loading of calibration tables via asset files

It is implemented by attaching the calibrator to the engine cache, so that the calibrator is loaded in during inference time inside the TRTEngineCacheResource object.
After calibration, each TRTEngineOp has its calibration table saved to its own asset file

Removes the previous code for saving and loading of calibration tables via attributes
Currently, calibration tables are saved using attributes which means that the calibration tables count towards the 2GB ProtoBuf size limit. By migrating to asset files, the tables no longer count towards the 2GB limit and can be as large as necessary.

Can you use this method to detect whether it is running with TF1 vs TF2?

Sorry, naive question here: I imported #include "tensorflow/core/platform/enable_tf2_utils.h" inside trt_engine_op.cc, but I'm still unable to use the method tf2_execution_enabled(). I'm getting an error like this:
in function `tensorflow::tensorrt::TRTEngineOp::TRTEngineOp(tensorflow::OpKernelConstruction*)':
trt_engine_op.cc:(.text._ZN10tensorflow8tensorrt11TRTEngineOpC2EPNS_20OpKernelConstructionE+0x11e4): undefined reference to `tensorflow::tf2_execution_enabled()'.

Also, did you want me to use tf2_execution_enabled() as a replacement for my is_v2 attribute?

@bixia1 Can you please assist on above comments from @vict-guo. Thanks!

@vict-guo Can you please resolve conflicts? Thanks!

tf2_execution_enabled

Have you added the module dependence? Can you take a look at how this test tensorflow/core/platform/enable_tf2_utils_test.cc is built to see if that helps?

@gbaned I resolved the conflicts. @bixia1 I'm not sure how much more I'll be able to work on this since I've left Nvidia and don't have access the containers I used to use to build tensorflow with TF-TRT.

@vict-guo Can you please sign CLA. Thank you!

Signed the CLA

@vict-guo Can you please resolve conflicts? Thank you!

@gbaned Sorry, I probably don't have too much time to work on this PR anymore. This was a project I worked on at Nvidia and after leaving Nvidia I've lost access to the TF-TRT containers.

Thanks @vict-guo for your work on this PR so far! @gbaned I am taking this up, and I will update the PR.

Thanks @vict-guo for your work on this PR so far! @gbaned I am taking this up, and I will update the PR.

Hi @vict-guo and @tfeher  Thank you for your contribution!

Hi @tfeher Any update on this PR? Please. Thank you!

Hi @tfeher Any update on this PR? Please. Thank you!

Hi @tfeher Any update on this PR? Please. Thank you!

Hi @tfeher Any update on this PR? Please. Thank you!

Hi @tfeher Any update on this PR? Please. Thank you!

Hi @tfeher Any update on this PR? Please. Thank you!

Hi @tfeher Any update on this PR? Please. Thank you!

@tfeher @vict-guo  I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen! thank you for your contribution.


Feature request : relationship query

👋 Not sure this is the right place tot submit a feature request for the opslevel api, but here I go :
I am working on a contribution to the opslevel terraform provider so we can establish relationship between infrastructure and services via terraform. Unfortunately the Ops level api does not implement a query which allow to retrieve a single relationship by id. To work around this lack of feature, i had to specialise the resources (ie opslevel_infrastructure_relationship and use the relatedResources property.  It works, but its quite suboptimal and make the code un-necessarily complicated, and thus leaves little chance for the contribution to be accepted in the current state.
Implementing a "relationship" query and making it available in the golang client would remove the need for such workaround.

Hey @dstendardi - I have passed this onto the team responsible for this API and they have put a ticket in their backlog for this.  Unfortunately i do not have an ETA for when that might get done - your best bet is to talk to your opslevel support team so they can put added pressure to get the feature pushed up the backlog by product leadership.
If i hear the API is finished i'll report back here for you.  Thank you for suggestion and willingness to work on a community integration for us.  🎉

Thank you very much @rocktavious . Should i keep this feature request open for tracking or close it ?

@dstendardi ya its ok to have it open here - we or you will need to eventually put the API functionality into opslevel-go once its in the GraphQL API.  This can be the issue tracking that work. 👍


Add developer guide

Developer guides how to write your own handler. The README has link to the developer guide.

lgtm, outstanding work


Add top-level control on Cloud definition: key=enabled

This commit if applied will add the ability to enable or disable entirely a
cloud.
If a cloud is enabled=false  its configuration is not loaded by the scheduler.
This is a way for OPS to entirely disable a cloud.
It takes precedence over (future) taints and toleration.

@thomas-crowe  FYI


[Kit] does not support revisions

[Extract]
Tool does not extract revisoin rev=2 that is online:

[Deploy]
I deploy api v1, that is current:
  "name": ".../v1"
  "apiRevision": "1",
  "apiVersion": "v1",
  "isCurrent": true,

Then I want to deploy new revision toogether with the current one:
  "name": ".../v1"
  "apiRevision": "1",
  "apiVersion": "v1",
  "isCurrent": true,

and
  "name": ".../v1;rev=2"
  "apiRevision": "2",
  "apiVersion": "v1",
  "isCurrent": false
  "dependsOn":[ /v1 ]

With error:
 "error": {
    "code": "ValidationError",
   "message": "Can't change property Name for non-current revision ",
    "details": null
  }

I believe we only extract current revision. @RupengLiu to confirm.

For extractor, I'm going to mark this as a feature as we only support extracting the latest revision right now.  Requirement is "add an option to extract all revisions with a mechanism that allows them all to be imported again somewhere else".

@springcomp - if you wish this for creator as well, please open a new feature request as it is a different code base.

This project is now in "maintenance" mode. This means that no new features will be accepted and fixes will be limited to security fixes. We expect to retire the DevOps Resource Kit by the end of 2023. At that time, the DevOps Resource Kit repository will be archived and there will be no further updates.
While you are free to fork the DevOps Resource Kit yourself, we recommend that you migrate to the following products:

If you are using creator, switch over to using Bicep templates. Bicep is a descriptive language for describing infrastructure, fully supports all features of Azure API Management, and is covered in any support agreement that you have with Azure. You can find bicep modules and examples for handling API Management APIs at https://github.com/azure-samples/api-management-sample-apis.
If you are using extractor, switch your pipelines to use APIOps. APIOps applies the concepts of GitOps to API deployments. It is faster and more flexible than the DevOps Resource Kit.


Improved the looks of GUI

Gui looks are improved, need to add the looks and functionalities of "hide Image" and "reveal Image" buttons,

ButtonPanel has all the new functions regarding the new GUI.
ButtonComponents has the functions of the old GUI.
GuiComponents.java - creates the Frame and adds ButtonPanel to it.
MainDriver.java has the main method in it.


add nested test examples for Modspec Conformance Class: https://githu…

…b.com/metanorma/metanorma-ogc/issues/489
Metanorma PR checklist

[ ] Breaking changes (list related PRs)
[ ] Documentation update required (create task for this)
[ ] External dependency introduced (documentation update need)
[ ] Gem with native library introduced

merged into doc20230606


resync full node allows you to click on other tabs which will cancel resync

Other buttons should be disabled during resync.

They will not canceled, it will finish occasionally. But yes, we should disable that because sync task is very long and that is why the next requests to mwc713 will be waiting for a while. So UX will be not good.

Hide all controls for resync page: