Greenkeeper/greenkeeper lockfile 1.11.1

Coverage remained the same at 98.105% when pulling ddbb7e74ec5b83f36973f5106b729cfbff97f66d on greenkeeper/greenkeeper-lockfile-1.11.1 into 6ca30be0e285c83f0ef89cb69f93b94031c0957f on master.


support for conditional and (&&)

This directive works
m-if="false || true"
but this directive does not
m-if="false && true"
Is there a replacement character for && or is this a planned feature? Thanks!

This is because you are using the DOM as a template. If you provide a template option, this operator (&&) will work as expected.
See, the browser escapes certain characters automatically in attributes, and when it is parsing the HTML, it escapes both ampersands to &amp. This leads to the attribute value to be m-if="false && true". Moon attempts to compile this and it leads to an invalid template expression.
Here is a working example:

new Moon({
  el: "#app",
  template: `

Not Showing

Showing

`
});

jsFiddle link

I see, thank you.

No problem.

See, the browser escapes certain characters automatically in attributes, and when it is parsing the HTML, it escapes both ampersands to &. This leads to the attribute value to be m-if="false && true". Moon attempts to compile this and it leads to an invalid template expression.

Did you try the fix? Try putting the template in the template option rather than as a DOM element.

Yes, your fix works like a charm, but.. my template is really huge, i can't embed it in the javascript.

There's nothing Moon can do about that, since browsers compile the HTML. In v1, Moon will compile the escape codes as normal JavaScript codes, but for any previous versions you'll have to use template.
Templates aren't supposed to be in the DOM or in the JavaScript for production anyway. You should precompile them using either single-file components or passing Moon.compile's output as the render option.


Sha384Acc::lock() locks the register with a write instead of a read (as the register docs mention)

Noticed by NCC:
https://github.com/chipsalliance/caliptra-sw/blob/8b23c0a6d1fb727c932d2f84b9ca4aa543214da8/drivers/src/sha384acc.rs#L83-L86
This contradicts the register docs:

SHA lock register for SHA access, reading 0 will set the lock, Write 1 to clear the lock

Sha384::lock() is only used in fatal error handling, and I believe the intention there is to forcibly steal the lock so the SoC cannot use the peripheral (required for FIPS).

This is a documentation bug. Filed https://github.com/chipsalliance/caliptra-rtl/issues/216 to update the register doc.


what the different between MuZero_reward and total reward?

Hi,
In the Tensorboard for Tictactoe, I saw two diagrams abut reward,  MuZero_reward and total reward. What the different between MuZero_reward and total reward?

Hi,
In single player games, Total reward is the sum of the reward per episode. MuZero reward and Opponent reward are disabled.
In multiplayer games, MuZero reward is the sum of the rewards obtained by Muzero and Opponent reward is the sum of the rewards of the opponent. Total reward is the sum of the two.

@werner-duvaud thanks.


Use generic Process from Hugo v0.119.0 for card image processing

Hugo v0.119.0 introduced a new function Process that is more general
so we don't need the if block in the card.html image processing logic:
https://github.com/imfing/hextra/blob/main/layouts/shortcodes/card.html#L15

Seems pretty simple. I can take a look at this tomorrow afternoon if no one has gotten to it by then.

yes, it's pretty neat. with that new function, the interface of the card component could be further simplified.


GEOMESA-1841 Update HBase heatmap docs for geomesa:density and coproc…

…essor addition
Signed-off-by: Austin Heyne<EMAIL_ADDRESS>

@mdzimmerman any feedback?  Otherwise, it looks good to me!


[CLEANUP]  Extracting calls to pop a message dialog in TransGraph

To reduce code footprint and allow for consistent changes if needed.

@pentaho/ackbar


Add support for Laravel 6.0

Since Laravel 6 has been released. I think this package should support it?

I made a PR for this #28

See #125


fix: verify email address changes for individuals (resolves #590)

Hint text for email field: https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=1252%3A14249
Success notification for changing email: https://www.figma.com/file/AXufBnFAVHvGdsxnQMVhNF/The-Accessibility-Exchange-Wireframes?node-id=3739%3A94555

@greatislander the success message should read: "Your communication and consultation preferences have been updated. Please expect an email that asks you to verify your new email address."

@cherylhjli Michelle and I discussed this— the success message and the email verification message need to be separate.


Migrate SuccessResponseAsJsonObject rule to use context object to support OpenAPI 3

Related to #714

Codecov Report

Merging #807 into master will decrease coverage by 0.02%.
The diff coverage is 63.63%.

@@             Coverage Diff              @@
##             master     #807      +/-   ##
============================================
- Coverage     84.37%   84.35%   -0.03%
+ Complexity      992      988       -4
============================================
  Files           171      171
  Lines          2740     2736       -4
  Branches        421      416       -5
============================================
- Hits           2312     2308       -4
  Misses          215      215
  Partials        213      213

Impacted Files
Coverage Δ
Complexity Δ

...ly/rule/zalando/SuccessResponseAsJsonObjectRule.kt
69.23% <63.63%> (-7.24%)
15 <13> (-4)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b1890...78a9bd3. Read the comment docs.

👍

:+1:


Nudenet 1.0.0 can not be installed

In requirements.txt you are expecting to install nudenet 1.0.0 which can not be installed

Check my latest commit here


GH-2340: Fix Retrying Batch Error Handling

Resolves https://github.com/spring-projects/spring-kafka/issues/2340
The RetryingBatchErrorHandler - now called the FallbackBatchErrorHandler
pauses and resumes the consumer during retries, to allow it to poll the
consumer to avoid a forced rebalance.
However, if a normal rebalance occurs, for example if a new member joins,
the error handler does not re-pause the consumer and silently consumes
new records.
Add a mechanism to always re-pause the consume when in this retry mode.
cherry-pick to 2.9.x, 2.8.x
As well as the unit test, tested proper functionality by running two copies of a Boot app.

... and cherry-picked to 2.9.x .
It does not apply clearly to 2.8.x.
Would you mind taking a look, @garyrussell ?
Thanks

Back-ported to 2.8.x


Allow the node-driver-registrar image to be tweakable

This change will allow the installation of the CSI driver where all images are hosted locally in a private registry.

/assign @JoshVanL

Thanks @MattiasGees, we'll release a helm chart version (not an image version) after this is merged.
/lgtm
/approve
/ok-to-test


Add Vite+Svelte

I already have a fully configured Vite+svelte project, so please assigne me on this issues.

cc @vishal423 : as you are the lead on svelte blueprint, so you know the work will start soon

I think we should go with svelte/kit as used in the blueprint

Svelte kit is faster than vite ?

SvelteKit is a framework for web apps and it internally uses Vite

Ok fine, let's use SvelteKit so


Render */# instead of TYPE 'Lifted/TYPE 'Unlifted (fixes #473)

An attempt at making Haddock print something a bit nicer for one of the most common kinds you'll see.

Looks reasonable to me.

Merged. Thanks @RyanGlScott!


Change in behavior of mdformat-frontmatter output

We use mdformat to format markdowns. For automation and validation, the markdowns have yaml header with metadata about the document.
We use pre-commit hook to invoke mdformat and mdformat-frontmatter plugin so that the yaml can be ignored.
pre-commit version 2.17.0
mdformat version: 0.7.13
- repo: https://github.com/executablebooks/mdformat
    rev: 0.7.13 # Do not change version. 0.6.0 introduces breaking changes.
    hooks:
    - id: mdformat
      exclude: "CHANGELOG.md|docs/mkdocs_code_of_conduct.md|docs/api_reference"
      additional_dependencies:
      - mdformat-tables
      - mdformat-config
      - mdformat-frontmatter
      - mdformat-gfm

Notice that mdformat-frontmatter is formatting data in the header and inserting new lines.
example changes:
source-location: https://github.com/master/procedures/test-n/test-n.md

to
source-location:
  https://github.com/master/procedures/test-n/test-n.md

Expected behavior:
The new lines should not be added and yaml header should not be formatted at all.

Sorry for not getting back to you .. I'll have a look in the next few weeks.

Okay i've validated the behaviour as an issue.  Will be investigating the 'why'

We use mdformat to format markdowns. For automation and validation, the markdowns have yaml header with metadata about the document. We use pre-commit hook to invoke mdformat and mdformat-frontmatter plugin so that the yaml can be ignored. pre-commit version 2.17.0 mdformat version: 0.7.13
- repo: https://github.com/executablebooks/mdformat
    rev: 0.7.13 # Do not change version. 0.6.0 introduces breaking changes.
    hooks:
    - id: mdformat
      exclude: "CHANGELOG.md|docs/mkdocs_code_of_conduct.md|docs/api_reference"
      additional_dependencies:
      - mdformat-tables
      - mdformat-config
      - mdformat-frontmatter
      - mdformat-gfm

Notice that mdformat-frontmatter is formatting data in the header and inserting new lines. example changes:
source-location: https://github.com/master/procedures/test-n/test-n.md

to
source-location:
  https://github.com/master/procedures/test-n/test-n.md

Expected behavior: The new lines should not be added and yaml header should not be formatted at all.

This should now be fixed, however, there is still an indent structure enforcement - but the line endings should not be wrapped. @mrgadgil  could you test with v2.0.7

I think this is resolved now!


Basic stats

There's a stats component to hold player stats. Game jam it up and modify it from wherever you feel like.
Also you can click on squares during prep to add towers.

Oh and now turrets shoot enemies too


neuralynxio.py memmap possibly float instead of int

in code of memmapping the division could give floats instead of ints even if the result is even
data = np.memmap(self.sessiondir + sep + filename,
                                   dtype='<u2',
                                   shape=((filesize - 16384) / 2 / 56, 56),
                                   mode='r', offset=16384)

a simple workaround is to force it to int conversion (at least works in my case)
data = np.memmap(self.sessiondir + sep + filename,
                                  dtype='<u2',
                                  shape=(int((filesize - 16384) / 2 / 56), 56),
                                   mode='r', offset=16384)

Thank.
I guess this is already fixed in RP #385.

@samuelgarcia
Indeed! Thank you, then I must change to the development version rather than PyPi


Add Peter Sobolewski as a maintainer

@psobolewskiphd

Is that all that is required? nothing with the conda-forge bots/admin?

I'm not sure - usually being in the maintainer list + having commented on the feedstock is enough to be a maintainer... might need to prod a bot

It worked, I got the invite to the org today. Made a test PR and it lets me merge it.


An Error during pulling progress

Using the dashboard I found the Postgres image and pressed the pull button. During pulling progress I moved to the containers/images page, but there is nothing. And I checked using docker if images/containers really exist. And it was an error of the app. No problem docker. Then tried to refresh the page, and got an error.

Looks like, the error is in API. I've requested images during pulling progress and API still not responding now.

It responded when pulling finished.

But, After this, I realized that there is no problem with docker lib. Maybe the problem is with async or web framework, I don't know. But fixing this issue will be good. Or is this error only on my machine?

I am working on a new mechanism for pulling images. It will be fixed & implemented in the next releases.


Update and clean up Travis build

Sorry for the big commit, but these changes are all pretty inter-related. Splitting it up seemed like it would make things more complicated, not less.

Reworked .travis.yml. It used to be an auto-generated matrix, but the number of specific inclusions and exclusions made it confusing to try and update. I changed it to specifically list each build, ordered by Ruby version first and Rails version second.
Added Ruby 2.5 to supported Rails versions in .travis.yml.
Added stable git branches for Rails 5.1 and 5.2.
Removed redundant Rails git branches. Versions below 4.2 receive no updates, so testing these git branches was redundant with testing the released versions.
Updated each Ruby/Rails to latest patch version.
Fixed some dependency issues with newer Rails versions that were causing build errors.
Fixed an issue in the Rakefile that caused some versions to be tagged incorrectly, causing build errors.
Added a build for development version of Ruby using Rails 5.2 (failures allowed).
Removed tests of Ruby < 2.4 for Rails master.

Currently all released versions and stable branches build correctly. Rails master has a dependency issue causing failures, and Ruby-head has a segfault.
Please note that I did not intentionally remove any builds for old versions. The only builds I removed were git branches that were redundant with released gem versions. This PR is not meant to remove support for anything, only to improve coverage of new versions and maintainability of the build.

Rails master has a dependency issue causing failures.

I recently submitted a patch to fix this (https://github.com/rails/rails-controller-testing/pull/42) and it got merged in today. Do you mind trying to re-run the build to see how it goes?

Thanks @sikachu for addressing that. See build log here. Now rails-controller-testing loads, but building with Rails master still fails because of the problem addressed in #1997.

Wow ok, so first of all thanks for taking the time to do this but I'm going to need some help here..

Reworked .travis.yml. It used to be an auto-generated matrix, but the number of specific inclusions and exclusions made it confusing to try and update. I changed it to specifically list each build, ordered by Ruby version first and Rails version second.

Great, probably about time since we keep adding specific rails exclusions with each new version but I'd like this to be a seperate PR, and I'll need to verify no build version changes.

Removed redundant Rails git branches. Versions below 4.2 receive no updates, so testing these git branches was redundant with testing the released versions.

Please restore them, the point is to prove our compatibility with Rails, not visa versa, we can introduce regressions in new versions of RSpec that break older Rails. (We are changing our support policy for Rails see, #1967)

Added a build for development version of Ruby using Rails 5.2 (failures allowed).

Can you remove this, our build is too large as it is.

Please explain about the old Rails git branches. No older Rails were removed, only development branches for versions no longer in development, none of which have received a commit in years. Current master essentially tests these twice, once using RubyGems, and once using GitHub.

No the branches are the stable release branches, we maintain support for rspec-rails with those branches currently, we are hoping to reduce this at our next major release but for now we are committed to maintaining that compatibility no matter when they were last committed to.

I still don't get it, but I guess that's your call.
I submitted a separate PR that's just changes to .travis.yml. I pushed the other requested changes to this branch.

I forgot that some of the other file changes assumed that those git release branches were no longer needed. This needs further reworking if you're intent on preserving those, and I don't have the time or enthusiasm for it.
This PR still fixes a lot of things that needed to be fixed to support more recent versions of Rails. I'll leave it here for others to reference or build on to implement that support in a way that you'll find more acceptable.

Closed by #2001


correct hash for x64 x86 installer of teamviewer

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/pull/28941/commits/a2047f9ac4c51d83b125be0e7c755ef3fbded9dc

Couple things:

You can't modify manifests in two different folders right now with the way the validation process is set up. You have to split the changes to TeamViewer and TeamViewerHost into two PRs.
The version number changed with the new release of TeamViewer, so you'll have to change 15.21.8 everywhere you see it to 15.22.3 (including the folder name).

Edit: @Trenly beat me to it.

Thanks @jedieaston
@kdpuvvadi See these two PR's for an example on creating new versions

#28943
#28944


[Enhancement] (nereids)implement showCollationCommand in nereids

showCollation command is supported in legacy planner but not in nereids(new doris fe planner). you need implement the following showCollation command in nereids:
unsupportedshowCollationStatement
SHOW COLLATION wildWhere?

@starocean999 @LiBinfeng-01 Please assign this issue to me


As a developer using a custom build, when going to the Candid UI link generated by dfx deploy, I want to be able to choose a did file when the Candid canister cannot fetch the candid file

I'm always frustrated when I use a custom build (C++ in my case) and the dfx deploy command provides me a link to the Candid UI but because the did file is not available, the Candid UI throws an error.
In detail, it looks like this:
dfx deploy
Creating a wallet canister on the local network.
The wallet canister on the "local" network for user "default" is "rwlgt-iiaaa-aaaaa-aaaaa-cai"
Deploying all canisters.
Creating canisters...
Creating canister canister_1...
canister_1 canister created with canister id: rrkah-fqaaa-aaaaa-aaaaq-cai
Building canisters...
Executing ...my custom stuff...
...
Shrink WASM module size.
Installing canisters...
Creating UI canister on the local network.
The UI canister on the "local" network is "ryjl3-tyaaa-aaaaa-aaaba-cai"
Installing code for canister canister_1, with canister ID rrkah-fqaaa-aaaaa-aaaaq-cai
Deployed canisters.
URLs:
  Backend canister via Candid interface:
    canister_1: http://<IP_ADDRESS>:8000/?canisterId=ryjl3-tyaaa-aaaaa-aaaba-cai&id=rrkah-fqaaa-aaaaa-aaaaq-cai

When I go to the Candid interface in the browser using the provided link http://<IP_ADDRESS>:8000/?canisterId=ryjl3-tyaaa-aaaaa-aaaba-cai&id=rrkah-fqaaa-aaaaa-aaaaq-cai, it gives this error:
An error happened in Candid canister:
Error: Cannot fetch candid file
    at Object.fetchActor (http://<IP_ADDRESS>:8000/index.js:2:265325)
    at async http://<IP_ADDRESS>:8000/index.js:2:275457

Describe the solution you'd like
I can use the Candid UI just fine, if I first go the Candid UI main page, in above example that would be http://<IP_ADDRESS>:8000/?canisterId=ryjl3-tyaaa-aaaaa-aaaba-cai, and I then I am able to:

provide a canister ID, in above example rrkah-fqaaa-aaaaa-aaaaq-cai
choose a did file, by selecting it from disk

It would be nice if the Candid UI did not throw an error message when the did file cannot be fetched, but instead, pops up a warning, and goes to the Candid UI main page, with the canister ID already prefilled. I then simply select the did file from disk and we're good to go.

You can now use ic-wasm to embed the did file into the wasm module: ic-wasm a.wasm -o a.wasm metadata candid:service -v public -f a.did


Format of param tensor in data.pt

Hey @cheryyunl , I would like to know about the param tensor too, which stores the parameters of the policy network for every checkpoint. I am trying to adapt this framework onto my own dataset that I have acquired by training with PPO instead of SAC. In my training dataset, I tried storing the parameters for every checkpoint, in a list, as it is given by the agent.state_dict() function, which returns a dictionary of the agent's parameters. This format doesn't allow me to train on my dataset, so I would like to ask for the format in which the parameters are stored in the tensor for every checkpoint. Thanks!
Originally posted by @AmoghJuloori in https://github.com/cheryyunl/Make-An-Agent/issues/3#issuecomment-2269707564

You need to flatten the entire network into a vector and store it in 'param', as we mentioned in the paper. However, the exact size of the vector is up to the design of your autoencoder.

Oh okay, thank you for the help!


I can't comprehend this error

I am practically python illiterate, thank you in advance for creating exactly what I was looking for, I have encountered my first issue using this program for the first time.
trying to transform my first file I get this message:
File "/Library/Frameworks/Python.framework/Versions/3.12/bin/pptx2md", line 8, in <module>     sys.exit(main())              ^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx2md/__main__.py", line 121, in main     prs = Presentation(file_path)           ^^^^^^^^^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/api.py", line 28, in Presentation     presentation_part = Package.open(pptx).main_document_part                         ^^^^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/opc/package.py", line 73, in open     return cls(pkg_file)._load()            ^^^^^^^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/opc/package.py", line 157, in _load     pkg_xml_rels, parts = _PackageLoader.load(self._pkg_file, self)                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/opc/package.py", line 186, in load     return cls(pkg_file, package)._load()            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/opc/package.py", line 190, in _load     parts, xml_rels = self._parts, self._xml_rels                       ^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/util.py", line 215, in __get__     value = self._fget(obj)             ^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/opc/package.py", line 219, in _parts     content_types = self._content_types                     ^^^^^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/util.py", line 215, in __get__     value = self._fget(obj)             ^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/opc/package.py", line 203, in _content_types     return _ContentTypeMap.from_xml(self._package_reader[CONTENT_TYPES_URI])                                     ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/opc/serialized.py", line 35, in __getitem__     return self._blob_reader[pack_uri]            ^^^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/util.py", line 215, in __get__     value = self._fget(obj)             ^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/opc/serialized.py", line 49, in _blob_reader     return _PhysPkgReader.factory(self._pkg_file)            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/pptx/opc/serialized.py", line 135, in factory     raise PackageNotFoundError("Package not found at '%s'" % pkg_file) pptx.exc.PackageNotFoundError: Package not found at '3._Analisi_delle_dinamiche_II.pptx'
+
I am on Mac
Thank you for your patience
Alessandro

Hi, It seems to be caused by the pptx file not being found.
Please make sure that your current working directory (the output of pwd command) is the same as the directory where the pptx files resides. If not, use cd to go to there.


Unified runtime causes Metadata Portal to create QR bar code with same name

The WASM files for both frequency and frequency-rococo both use the name frequency in the metadata.  As a result, the Metadata QR code generation process is creating a frequency bar code for the frequency-rococo chain.
Consider this workflow run:
https://github.com/LibertyDSNP/metadata-portal/actions/runs/3753278560/jobs/6376380563
[2022-12-21T22:30:22Z INFO  metadata_cli::autosigner] :mag: Checking for updates for frequency-rococo
[2022-12-21T22:30:22Z INFO  metadata_cli::updater::wasm] FOUND RUNTIME INFO!
[2022-12-21T22:30:22Z DEBUG metadata_cli::updater::github] wasm.chain=frequency-rococo chain=frequency-rococo
[2022-12-21T22:30:22Z INFO  metadata_cli::autosigner] :date: Found version 3
[2022-12-21T22:30:22Z INFO  metadata_cli::updater::wasm] :arrow_down:  Downloading frequency-rococo runtime...
:gear: Generating /home/runner/work/metadata-portal/metadata-portal/public/qr/frequency_metadata_3.apng...

We could modify the Metadata Portal autosigner to not use the chain name from the metadata but the one that was used for the version check.   This would fix the filename collision BUT it's unclear if this would result in invalid metadata bar codes.

I modified the autosigner as described above BUT we will need to verify that the bar code for Rococo is valid to use.


Switch contact mechanics to pipeline function

ContactMechanics 1.0 will have a pipeline function that has can automatically carry out contact calculations. We should switch to using this pipeline function as it is (more thoroughly) tested outside of TopoBank.

The pipeline function exists in current ContactMechanics.

Related to #872.


Support for K8s v1.25

Are there any plans on releasing new versions?

Yeah, sorry-- a release is actually in the works, and I'm just doing document tidying, but life is kind of getting in the way. The code is finished and the doc review is about 70% done, so it's fairly close, but finding time has been challenging. I will try to make this happen soon.

Thank you! If you need any help, just let me know :))

Hey @Sharpz7 , I just wanted to follow up on this as it's been a while. I've actually had a release candidate for some time now, however I'm being thwarted in doing a final release I'm happy with as I'm getting some weird artifacts in my test bed. Resources are deleting, but k3s isn't allowing them to actually disappear. This is thwarting full integration testing, and I'm kind of a bit obsessive that this goes through successfully before I do a release.
If you don't want to wait until I figure this out, I'd be willing to do a pre-release for the next version. There will be no promises made here as I'm trying to sort out these problems (I suspect an update on my testbed for something has caused this), but it would allow you to move forward until I got these issues addressed.
Is this something you'd like to get your hands on?

Just to keep this alive, I've just released support for 23.x of the K8x client. This release will (hopefully) make adding support for new releases easier,  but I've never failed to run into at least a few headaches every time I have to process a new swagger file.
If you're dying for support of 25.x DM me and we can talk about what's involved.

Support for 24.x, 25.x, and 26.x just released. :-)


Meta "generator" tag in page header

References

Fixes https://github.com/DSpace/dspace-angular/issues/747

Description
This PR ensures that a "Generator" meta tag is set in the page header of each page in the DSpace UI.
Instructions for Reviewers
List of changes in this PR:

Ensures that a "Generator" meta tag is set in the page header of each page within DSpace
Aded tests to verify this

How to test this PR:

Setup this branch with a REST api that supports showing the dspaceVersion on the root endpoint
Inspect the DSpace UI page and verify that a "Generator" meta tag is present in the page headers

Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using yarn run lint
[x] My PR doesn't introduce circular dependencies
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

The dataservice has been updated to implement the findByHref and findAllByHref

The dataservice has been updated to implement the findByHref and findAllByHref

@tdonohue Thank you for the feedback! I do have one question though, currently the value 7.0-beta5-SNAPSHOT is coming directly from the REST API as can be seen here: https://dspace7.4science.cloud/server/#/server/api
Should we hardcode Angular to prepend this value with "DSpace " or should we cover this in the REST API?

@tdonohue Thank you for the feedback! I do have one question though, currently the value 7.0-beta5-SNAPSHOT is coming directly from the REST API as can be seen here: https://dspace7.4science.cloud/server/#/server/api
Should we hardcode Angular to prepend this value with "DSpace " or should we cover this in the REST API?

@Raf-atmire : excellent point.  You are correct in pointing out that the REST API should be returning DSpace 7.0-beta5-SNAPSHOT and not just 7.0-beta5-SNAPSHOT.  I agree with you that this PR is fine as-is...it's the REST API return value that needs correcting.
I'll create a new ticket to solve this on the REST API...this PR is therefore good as-is.  Thanks!

@Raf-atmire : excellent point.  You are correct in pointing out that the REST API should be returning DSpace 7.0-beta5-SNAPSHOT and not just 7.0-beta5-SNAPSHOT.  I agree with you that this PR is fine as-is...it's the REST API return value that needs correcting.
I'll create a new ticket to solve this on the REST API...this PR is therefore good as-is.  Thanks!

@Raf-atmire : Could you rebase this on main?  I was waiting to merge this until after we merged #970 (which was just merged).  However, merging that has changed some lint rules slightly...so that this PR now throws some minor lint errors (if you run yarn lint) locally:
/src/app/core/data/root-data.service.spec.ts:21:7
ERROR: 21:7     semicolon    Missing semicolon

/src/app/core/data/root-data.service.ts:72:55
ERROR: 72:55    array-type   Array type using 'Array<T>' is forbidden. Use 'T[]' instead.
ERROR: 85:71    array-type   Array type using 'Array<T>' is forbidden. Use 'T[]' instead.
ERROR: 99:113   array-type   Array type using 'Array<T>' is forbidden. Use 'T[]' instead.

Once those lint errors are solved, this PR can be merged.

@Raf-atmire : Could you rebase this on main?  I was waiting to merge this until after we merged #970 (which was just merged).  However, merging that has changed some lint rules slightly...so that this PR now throws some minor lint errors (if you run yarn lint) locally:
/src/app/core/data/root-data.service.spec.ts:21:7
ERROR: 21:7     semicolon    Missing semicolon

/src/app/core/data/root-data.service.ts:72:55
ERROR: 72:55    array-type   Array type using 'Array<T>' is forbidden. Use 'T[]' instead.
ERROR: 85:71    array-type   Array type using 'Array<T>' is forbidden. Use 'T[]' instead.
ERROR: 99:113   array-type   Array type using 'Array<T>' is forbidden. Use 'T[]' instead.

Once those lint errors are solved, this PR can be merged.


Complete isolated function support for function type descriptors and anonymous function expressions

Description:
https://github.com/ballerina-platform/ballerina-lang/pull/25423 adds initial support for isolated functions. Need to $title.
Need to also verify support for scenarios like
type F isolated function (int) returns int;
F f = x => x + 1;

Depends on https://github.com/ballerina-platform/ballerina-lang/issues/25563.

Once this is supported, need to mark langlib methods as isolated too.

Need to also verify https://github.com/ballerina-platform/ballerina-spec/issues/145#issuecomment-668404584.

isolated function support for function type descriptors and anonymous function expressions was merged with #25761. The langlib functions that are always isolated were also marked as isolated in line with the spec.
Closing this issue since the pending tasks have their own issues

Analyze closure isolated-ness wrt to the stack frame #25918
Introduce the @isolatedParam annotation and related analysis #25792


Support for Specification Extensions #11 (rebase of #21)

note: https://github.com/biocad/openapi3/pull/28/commits/9067ae9ccde74c3a4485b38274ce246c5b7ceeaa in this PR  solves the same problem that https://github.com/biocad/openapi3/pull/27 solves.


fix: add error handler when targetname is . and -P isn't specified

https://github.com/xmake-io/xmake/pull/3741

@waruqi Thank you very much ❤.

W: Failed to fetch http://ports.ubuntu.com/ubuntu-ports/dists/bionic-security/universe/source/Sources  Could not connect to ports.ubuntu.com:80 (<IP_ADDRESS>), connection timed out Could not connect to ports.ubuntu.com:80 (<IP_ADDRESS>), connection timed out [IP: <IP_ADDRESS> 80]
Seems to be a problem with the GitHub action itself.


[SCB-327] Update metrics publish data module (Re-organized)

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Re-organize commits of PR : https://github.com/apache/incubator-servicecomb-java-chassis/pull/550
Adjust metrics publish format to spring cloud netflix style
Before:
servicecomb.instance.system.cpu.load
servicecomb.instance.system.cpu.runningThreads
servicecomb.instance.system.heap.init
servicecomb.instance.system.heap.max
servicecomb.instance.system.heap.commit
servicecomb.instance.system.heap.used
servicecomb.instance.system.nonHeap.init
servicecomb.instance.system.nonHeap.max
servicecomb.instance.system.nonHeap.commit
servicecomb.instance.system.nonHeap.used
servicecomb.instance | operationName.producer.waitInQueue.count
servicecomb.instance | operationName.producer.lifeTimeInQueue.average
servicecomb.instance | operationName.producer.lifeTimeInQueue.max
servicecomb.instance | operationName.producer.lifeTimeInQueue.min
servicecomb.instance | operationName.producer.executionTime.average
servicecomb.instance | operationName.producer.executionTime.max
servicecomb.instance | operationName.producer.executionTime.min
servicecomb.instance | operationName.producer.producerLatency.average
servicecomb.instance | operationName.producer.producerLatency.max
servicecomb.instance | operationName.producer.producerLatency.min
servicecomb.instance | operationName.producer.producerCall.total
servicecomb.instance | operationName.producer.producerCall.tps
servicecomb.instance | operationName.consumer.consumerLatency.average
servicecomb.instance | operationName.consumer.consumerLatency.max
servicecomb.instance | operationName.consumer.consumerLatency.min
servicecomb.instance | operationName.consumer.consumerCall.total
servicecomb.instance | operationName.consumer.consumerCall.tps
Current:
jvm(statistic=gauge,name={name})
{name} include :
cpuLoad,cpuRunningThreads,heapInit,heapMax,heapCommit,
heapUsed,nonHeapInit,nonHeapMax,nonHeapCommit,nonHeapUsed
servicecomb.invocation(operation={operationName},role={role},stage={stage},statistic={statistic},status={status})

TagName
TagValue

operation
Operation Name

role
consume,producer

stage
queue,execution,whole

statistic
tps,totalCount,count,totalTime,max,waitInQueue (can compute latency = totalTime/count)

status
statusCode like 200, 404 ... etc

A output sample:

Coverage increased (+0.09%) to 87.326% when pulling feddcce8aa6b1817144c76a3863f8162d945c7d2 on zhengyangyong:SCB-327-2 into 9720cfc5c9f7ea2e7902a821ef031203ddfd8808 on apache:master.


Added simple mvn github action.

Hey.
Given the recent issues. I have added a github action which will try compile (and possibly test) the code. This will catch any build failures on PR requests. Hopefully helping to ensure that all code gets into master at least builds. It can be made more sophisticated later if required. We can also add a -DskipTests if the tests aren't passing to simply verify compilation.
(Converage is another option we could add.)

This github action should fail (see https://github.com/aubelsb2/JSONata4Java/runs/3275922421?check_suite_focus=true) as per issue: https://github.com/IBM/JSONata4Java/issues/170 However it shold help prevent issues like that in the future.

I apologize -- somehow I'd lost track of this request. I merged it today.

Do you know where a private key is expected (e.g., in an environment variable or file location)? I don't think I can check that into github...
gpg: directory '/home/runner/.gnupg' created
gpg: keybox '/home/runner/.gnupg/pubring.kbx' created
gpg: no default secret key: No secret key
gpg: signing failed: No secret key
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  28.314 s
[INFO] Finished at: 2022-05-20T11:55:30Z
[INFO] ------------------------------------------------------------------------
Error:  Failed to execute goal org.apache.maven.plugins:maven-gpg-plugin:1.6:sign (sign-artifacts) on project JSONata4Java: Exit code: 2 -> [Help 1]
Error:
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error: Process completed with exit code 1.

I've attempted to address this based on issue #196

No problem. I am a contractor so I am unavailable for periods of time. I will look into the issue when I get some time to work on it. Sorry it's been a while. I will discuss later on the issue.


Fix building against OpenSSL 3.0.0 (take 2)

Unlike OpenSSL 1, OpenSSL 3 requires build.info files in its fuzz/ directory to be present. Without it, the configure script fails. fuzz/ is excluded from the crate for space reasons; this change puts it back and excludes doc/ and demos/ instead, to get back below the 10MiB limit.
More information here: #102
This PR is like https://github.com/alexcrichton/openssl-src-rs/pull/103 but tries to use cargo package to make CI closer to a real build, rather than just rming a bunch of files in the main directory.
Signed-off-by: Nick Thomas<EMAIL_ADDRESS>

OK @alexcrichton, I've got a choice between two PRs for you.
Both use exactly the same fix for the actual build - creating fuzz/build.info and test/build.info files before running ./Configure, which is sufficient to get it to compile without those directories (so the exclude directives can stay as they are).
Where they differ is in how they modify CI - #103 duplicates the list of excluded files, makes the code directory RW, and rm -rfs those directories prior to running the tests.
This PR (which I prefer) uses cargo package to mirror the contents to target/package/openssl-src-<version>  before running the tests. The packaged version lacks the testcrate directory as well as the excluded paths.
It does mean we need to know the version of openssl-src that we're building, to construct the path. This is in Cargo.toml, but how to access it in a way that's sensible across all platforms is a bit of a vexed question :sweat_smile:
It's in cargo metadata, but that requires jq to parse it out, which isn't installed in CI. I didn't fancy trying to work out how to get access to it in windows.
Another option would be to grep | cut | tr the Cargo.toml file. I didn't try this one.
When we cargo run, it's provided as an envvar to the binary that gets built and executed. I took this approach, adding src/bin/output_version.rs. It's a bit weird, but it works.
Or we can just merge #103 :sweat_smile:

This approach seems cleaner to me as well.

I agree that this is better than hardcoding lists, but build scripts ideally shouldn't be modifying the contents of the directories that they're unpackaged into. I'm also wary to delete parts of OpenSSL's source tree that it actually needs to build and trying to fake our way to adding them back in.
Are there perhaps more targeted exclusions of files which don't affect the build system but still allow us to get the tarball under the 10MB limit?

We could also ask Crates.io to bump the limit for us. It seems like the official tarball off of openssl.org is ~14mb as well.

@alexcrichton hmm, I note that until just recently we were modifying the source code directly, not just the build system ;)
However, I've worked out that we can actually make test/ unnecessary, by using no-tests (instead of the former no-unit-tests). There's no way exclude fuzz/ that I can see, but leaving out test/ gets us back down to 11MiB.
I've just pushed a commit that takes out demos/ and doc/ as well, let's see if CI passes with it.

If we're all agreed that the CI changes are best like this, I@ll close #103

OK, this looks like it would do the trick @alexcrichton . WDYT?
openssl-src-rs$ du -bs target/package/*
60262607	target/package/openssl-src-300.0.0+3.0.0
9800148	target/package/openssl-src-300.0.0+3.0.0.crate

Thanks, looks good to me!


Steam deploy job consistently fails

Bug description
I'm using the example workflow from the getting started guide to build and upload my game to steam. The steam deploy job always fails, yet my build is always successfully uploaded to steam and playing the up-to-date game work just fine from the steam launcher.
I'm trying to understand why this happens. Is there anything I can do to improve my workflow definition? Caching is also not working for me, would that be related to the failure of this job?

Here's the output of the job:
Run game-ci/steam-deploy@v1
Run CyberAndrii/setup-steamcmd@v1
Downloading ...
Extracting ...
/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C steamcmd -f /home/runner/work/_temp/steamcmd_linux.tar.gz
Adding to the cache ...
Installing required dependencies ...
/usr/bin/apt-get --yes update
Reading package lists...
E: Could not open lock file /var/lib/apt/lists/lock - open (13: Permission denied)
E: Unable to lock directory /var/lib/apt/lists/
W: Problem unlinking the file /var/cache/apt/pkgcache.bin - RemoveCaches (13: Permission denied)
W: Problem unlinking the file /var/cache/apt/srcpkgcache.bin - RemoveCaches (13: Permission denied)
/usr/bin/dpkg-query --show --showformat='${db:Status-Status}\n' lib32gcc-s1
'installed
'Failed to update lib32gcc-s1, using installed version. This is the intended behavior for a rootless user.
Updating ...
/opt/hostedtoolcache/steamcmd/latest/i386/steamcmd.sh +quit
Redirecting stderr to '/home/runner/Steam/logs/stderr.txt'
ILocalize::AddFile() failed to load file "public/steambootstrapper_english.txt".
[  0%] Checking for available update...
[----] Downloading update (0 of 57385 KB)...
[  0%] Downloading update (0 of 57385 KB)...
[  0%] Downloading update (0 of 57385 KB)...
[  0%] Downloading update (0 of 57385 KB)...
[  0%] Downloading update (0 of 57385 KB)...
[  0%] Downloading update (0 of 57385 KB)...
[  0%] Downloading update (2738 of 57385 KB)...
[  4%] Downloading update (6744 of 57385 KB)...
[ 11%] Downloading update (9238 of 57385 KB)...
[ 16%] Downloading update (1[17](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:18)[18](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:20) of 57385 KB)...
[ 20%] Downloading update (14411 of 57385 KB)...
[ 25%] Downloading update (16880 of 57385 KB)...
[ 29%] Downloading update ([19](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:21)360 of 57385 KB)...
[ 33%] Downloading update (21836 of 57385 KB)...
[ 38%] Downloading update (24561 of 57385 KB)...
[ 42%] Downloading update (27029 of 57385 KB)...
[ 47%] Downloading update (29484 of 57385 KB)...
[ 51%] Downloading update (31947 of 57385 KB)...
[ 55%] Downloading update (34667 of 57385 KB)...
[ 60%] Downloading update (37116 of 57385 KB)...
[ 64%] Downloading update (39477 of 57385 KB)...
[ 68%] Downloading update (41243 of 57385 KB)...
[ 71%] Downloading update (42455 of 57385 KB)...
[ 73%] Downloading update (43693 of 57385 KB)...
[ 76%] Downloading update (45070 of 57385 KB)...
[ 78%] Downloading update (46304 of 57385 KB)...
[ 80%] Downloading update (47531 of 57385 KB)...
[ 82%] Downloading update (48872 of 57385 KB)...
[ 85%] Downloading update (50116 of 57385 KB)...
[ 87%] Downloading update (51343 of 57385 KB)...
[ 89%] Downloading update (52569 of 57385 KB)...
[ 91%] Downloading update (53885 of 57385 KB)...
[ 93%] Downloading update (55134 of 57385 KB)...
[ 96%] Downloading update (56361 of 57385 KB)...
[ 98%] Downloading update (57385 of 57385 KB)...
[100%] Download Complete.
[----] Applying update...
[----] Extracting package...
[----] Extracting package...
[----] Extracting package...
[----] Extracting package...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Cleaning up...
[----] Update complete, launching...
Redirecting stderr to '/home/runner/Steam/logs/stderr.txt'
/tmp/dumps insufficient permissions - delete and recreate
[  0%] Checking for available updates...
[----] Verifying installation...
[  0%] Downloading update...
[  0%] Checking for available updates...
[----] Download complete.
[----] Extracting package...
[----] Extracting package...
[----] Extracting package...
[----] Extracting package...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Installing update...
[----] Cleaning up...
[----] Update complete, launching Steamcmd...
Redirecting stderr to '/home/runner/Steam/logs/stderr.txt'
[  0%] Checking for available updates...
[----] Verifying installation...
Steam Console Client (c) Valve Corporation - version<PHONE_NUMBER>
-- type 'quit' to exit --
Loading Steam API...OK
Done
Run chmod +x $GITHUB_ACTION_PATH/steam_deploy.sh

#################################
#   Generating Depot Manifests  #
#################################

Adding depot1827641.vdf ...

"DepotBuildConfig"
{
  "DepotID" "1827641"
  "FileMapping"
  {
    "LocalPath" "./StandaloneWindows64/*"
    "DepotPath" "."
    "recursive" "1"
  }
  "FileExclusion" "*.pdb"
  "FileExclusion" "**/*_BurstDebugInformation_DoNotShip*"
  "FileExclusion" "**/*_BackUpThisFolder_ButDontShipItWithYourGame*"
}

Adding depot1827642.vdf ...

"DepotBuildConfig"
{
  "DepotID" "1827642"
  "FileMapping"
  {
    "LocalPath" "./StandaloneOSX/*"
    "DepotPath" "."
    "recursive" "1"
  }
  "FileExclusion" "*.pdb"
  "FileExclusion" "**/*_BurstDebugInformation_DoNotShip*"
  "FileExclusion" "**/*_BackUpThisFolder_ButDontShipItWithYourGame*"
}

Adding depot1827643.vdf ...

"DepotBuildConfig"
{
  "DepotID" "1827643"
  "FileMapping"
  {
    "LocalPath" "./StandaloneLinux64/*"
    "DepotPath" "."
    "recursive" "1"
  }
  "FileExclusion" "*.pdb"
  "FileExclusion" "**/*_BurstDebugInformation_DoNotShip*"
  "FileExclusion" "**/*_BackUpThisFolder_ButDontShipItWithYourGame*"
}

#################################
#    Generating App Manifest    #
#################################

/home/runner/work/_actions/game-ci/steam-deploy/v1/steam_deploy.sh: 62: [[: not found
/home/runner/work/_actions/game-ci/steam-deploy/v1/steam_deploy.sh: 64: [[: not found
"appbuild"
{
  "appid" "***"
  "desc" "v0.1.14"
  "buildoutput" "BuildOutput"
  "contentroot" "/home/runner/work/DINO-MERCS-unity/DINO-MERCS-unity/build"
  "setlive" "prerelease"

  "depots"
  {
    "1827641" "depot1827641.vdf"
    "1827642" "depot1827642.vdf"
    "1827643" "depot1827643.vdf"
  }
}

#################################
#    Copying SteamGuard Files   #
#################################

Steam is installed in: /home/runner/Steam
Copying /home/runner/Steam/config/config.vdf...
Copying /home/runner/Steam/ssfn...
Finished Copying SteamGuard Files!

#################################
#        Uploading build        #
#################################

Redirecting stderr to '/home/runner/Steam/logs/stderr.txt'
[  0%] Checking for available updates...
[----] Verifying installation...
Steam Console Client (c) Valve Corporation - version<PHONE_NUMBER>
-- type 'quit' to exit --
Loading Steam API...OK
Logging in user '***' to Steam Public...src/public/tier1/interface.h (264) : m_pModule
Warning: failed to set thread priority: set failed for priority 8
Warning: support for elevated priorities is most likely unavailable, suppressing future warnings
src/public/tier1/interface.h (264) : m_pModule
CHIDDeviceListSDL(): Couldn't load libSDL2-2.0.so.0, not enumerating devices
OK
Waiting for client config...OK
Waiting for user info...OK
[[20](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:22)22-12-07 [21](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:23):56:26]: Starting AppID *** build (flags 0x0).
[20[22](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:24)-12-07 21:56:26]: Building depot 1827641...

Building file mapping...
Scanning content
..... 46.3MB (12%)
...... 95.2MB (24%)
..... 134.3MB (35%)
..... 181.5MB (47%)
...... 227.6MB (59%)
..... 271.6MB (71%)
...... 319.9MB (83%)
..... 363.0MB (94%)
.
Uploading content...
 3.3MB (17%)
 5.6MB (30%)
. 9.3MB (50%)
 11.7MB (64%)
 14.2MB (77%)
 16.2MB (88%)
. 18.3MB (100%)

[2022-12-07 21:56:41]: Building depot 1827642...

Building file mapping...
Scanning content
..... 48.9MB (12%)
...... 98.7MB (24%)
...... 144.9MB (35%)
..... 187.9MB (46%)
..... [23](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:25)2.5MB (57%)
...... 276.9MB (68%)
...... 330.4MB (81%)
..... 374.5MB (92%)
....
Uploading content...
 3.0MB (15%)
 5.5MB (29%)
 7.5MB (40%)
. 9.7MB (51%)
 12.4MB (66%)
 15.5MB (82%)
. 17.7MB (94%)

[2022-12-07 21:56:56]: Building depot 1827643...

Building file mapping...

Uploading content...
 3.1MB (14%)
 6.2MB (30%)
. 8.8MB (42%)
 12.8MB (61%)
 15.5MB (74%)
. 18.3MB (88%)
 20.7MB (100%)

[2022-12-07 21:57:11]: ERROR! Failed to commit build for AppID *** : Failure

#################################
#             Errors            #
#################################

Listing current folder and rootpath

total 100K
drwxr-xr-x 16 runner docker 4.0K Dec  7 21:56 .
drwxr-xr-x  3 runner docker 4.0K Dec  7 21:53 ..
drwxr-xr-x  8 runner docker 4.0K Dec  7 21:55 .git
-rw-r--r--  1 runner docker   42 Dec  7 21:54 .gitattributes
drwxr-xr-x  3 runner docker 4.0K Dec  7 21:54 .github
-rw-r--r--  1 runner docker 1.1K Dec  7 21:54 .gitignore
drwxr-xr-x  4 runner docker 4.0K Dec  7 21:54 .idea
drwxr-xr-x  2 runner docker 4.0K Dec  7 21:54 .vscode
-rw-r--r--  1 runner docker   99 Dec  7 21:54 .vsconfig
drwxr-xr-x 27 runner docker 4.0K Dec  7 21:55 Assets
drwxr-xr-x  2 runner docker 4.0K Dec  7 21:57 BuildOutput
drwxr-xr-x  2 runner docker 4.0K Dec  7 21:55 DungbeetleServer
drwxr-xr-x  2 runner docker 4.0K Dec  7 21:55 Packages
drwxr-xr-x  2 runner docker 4.0K Dec  7 21:55 ProjectSettings
-rw-r--r--  1 runner docker  173 Dec  7 21:55 README.md
drwxr-xr-x  2 runner docker 4.0K Dec  7 21:55 RewiredBackup
drwxr-xr-x  3 runner docker 4.0K Dec  7 21:55 UserSettings
drwxr-xr-x  5 runner docker 4.0K Dec  7 21:55 build
-rw-r--r--  1 runner docker  304 Dec  7 21:56 depot1827641.vdf
-rw-r--r--  1 runner docker  298 Dec  7 21:56 depot1827642.vdf
-rw-r--r--  1 runner docker  302 Dec  7 21:56 depot1827643.vdf
-rw-r--r--  1 runner docker  304 Dec  7 21:56 manifest.vdf
-rw-r--r--  1 runner docker   83 Dec  7 21:55 omnisharp.json
drwxr-xr-x  3 runner docker 4.0K Dec  7 21:55 steamcmd
drwxr-xr-x  3 runner docker 4.0K Dec  7 21:55 windows_build

total 20K
drwxr-xr-x  5 runner docker 4.0K Dec  7 21:55 .
drwxr-xr-x 16 runner docker 4.0K Dec  7 21:56 ..
drwxr-xr-x  4 runner docker 4.0K Dec  7 21:55 StandaloneLinux64
drwxr-xr-x  3 runner docker 4.0K Dec  7 21:55 StandaloneOSX
drwxr-xr-x  5 runner docker 4.0K Dec  7 21:55 StandaloneWindows64

Listing logs folder:

/home/runner/Steam/logs/:
total 88K
drwxr-xr-x 2 runner docker 4.0K Dec  7 21:57 ./
drwxr-xr-x 7 runner docker 4.0K Dec  7 21:57 ../
-rwxr-xr-x 1 runner docker 1.1K Dec  7 21:56 appinfo_log.txt
-rwxr-xr-x 1 runner docker 9.1K Dec  7 21:57 bootstrap_log.txt
-rwxr-xr-x 1 runner docker 1010 Dec  7 21:56 cloud_log.txt
-rwxr-xr-x 1 runner docker 1.2K Dec  7 21:56 compat_log.txt
-rwxr-xr-x 1 runner docker 1.6K Dec  7 21:56 configstore_log.txt
-rwxr-xr-x 1 runner docker 4.1K Dec  7 21:57 connection_log.txt
-rwxr-xr-x 1 runner docker  251 Dec  7 21:56 content_log.txt
-rwxr-xr-x 1 runner docker   52 Dec  7 21:57 controller.txt
-rwxr-xr-x 1 runner docker  181 Dec  7 21:56 parental_log.txt
-rwxr-xr-x 1 runner docker  156 Dec  7 21:56 shader_log.txt
-rw-r--r-- 1 runner docker  647 Dec  7 21:56 stderr.txt
-rwxr-xr-x 1 runner docker  138 Dec  7 21:56 systemaudiomanager.txt
-rwxr-xr-x 1 runner docker  140 Dec  7 21:56 systemdisplaymanager.txt
-rwxr-xr-x 1 runner docker  136 Dec  7 21:56 systemdockmanager.txt
-rwxr-xr-x 1 runner docker 1.1K Dec  7 21:56 systemmanager.txt
-rwxr-xr-x 1 runner docker  414 Dec  7 21:56 systemperfmanager.txt
-rwxr-xr-x 1 runner docker   98 Dec  7 21:56 workshop_log.txt

Displaying error log

CAppInfoCacheReadFromDiskThread took 0 milliseconds to initialize
src/public/tier1/interface.h (264) : m_pModule
assert_20221207215620_17.dmp[1887]: Uploading dump (out-of-process)
/tmp/dumps/assert_20221207215620_17.dmp
assert_20221207215620_17.dmp[1887]: Finished uploading minidump (out-of-process): success = no
assert_20221207215620_17.dmp[1887]: error: libcurl.so: cannot open shared object file: No such file or directory
assert_20221207215620_17.dmp[1887]: file ''/tmp/dumps/assert_20221207215620_17.dmp'', upload no: ''libcurl.so: cannot open shared object file: No such file or directory''
src/public/tier1/interface.h (264) : m_pModule

Displaying bootstrapper log

[2022-12-07 21:55:54] Startup - updater built Dec 13 2017 05:27:43
[2022-12-07 21:55:54] Checking for update on startup
[2022-12-07 21:55:54] Checking for available update...
[2022-12-07 21:55:55] Download failed: http error 0 (client-download.steampowered.com/client/steam_cmd_linux)
[2022-12-07 21:55:55] Package file steamcmd_public_all.zip.b34b8da97a76159a60dc27b1b6da62b538602518 missing or incorrect size
[2022-12-07 21:55:55] Package file steamcmd_bins_linux.zip.vz.942f2cc97627404c2cc170a46c8752afa92c67db_19153875 missing or incorrect size
[2022-12-07 21:55:55] Package file steamcmd_siteserverui_linux.zip.vz.fc634823dd1831a88610f41bea8167a369bebb12_37365774 missing or incorrect size
[2022-12-07 21:55:55] Package file steamcmd_linux.zip.vz.88980b3581a48c17c9230ec19ff71373ad530ad9_2193605 missing or incorrect size
[2022-12-07 21:55:55] Downloading update (0 of 57385 KB)...
[2022-12-07 21:55:56] Error: Download of package (steamcmd_public_all) failed after 0 bytes (0).
[2022-12-07 21:55:56] Error: Download of package (steamcmd_bins_linux) failed after 0 bytes (0).
[2022-12-07 21:55:56] Error: Download of package (steamcmd_siteserverui_linux) failed after 0 bytes (0).
[2022-12-07 21:55:56] Error: Download of package (steamcmd_linux) failed after 0 bytes (0).
[2022-12-07 21:55:56] Package file steamcmd_public_all.zip.b34b8da97a76159a60dc27b1b6da62b538602518 missing or incorrect size
[2022-12-07 21:55:56] Package file steamcmd_bins_linux.zip.vz.942f2cc97627404c2cc170a46c8752afa92c67db_19153875 missing or incorrect size
[2022-12-07 21:55:56] Package file steamcmd_siteserverui_linux.zip.vz.fc634823dd1831a88610f41bea8167a369bebb12_37365774 missing or incorrect size
[2022-12-07 21:55:56] Package file steamcmd_linux.zip.vz.88980b3581a48c17c9230ec19ff71373ad530ad9_2193605 missing or incorrect size
[2022-12-07 21:55:57] Downloading update (2738 of 57385 KB)...
[2022-12-07 21:55:57] Downloading update (6744 of 57385 KB)...
[2022-12-07 21:55:57] Downloading update (9238 of 57385 KB)...
[2022-12-07 21:55:57] Downloading update (11718 of 57385 KB)...
[2022-12-07 21:55:58] Downloading update (14411 of 57385 KB)...
[2022-12-07 21:55:58] Downloading update (16880 of 57385 KB)...
[2022-12-07 21:55:58] Downloading update (19360 of 57385 KB)...
[2022-12-07 21:55:58] Downloading update (21836 of 57385 KB)...
[2022-12-07 21:55:59] Downloading update ([24](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:26)561 of 57385 KB)...
[2022-12-07 21:55:59] Downloading update (27029 of 57385 KB)...
[2022-12-07 21:55:59] Downloading update (29484 of 57385 KB)...
[2022-12-07 21:55:59] Downloading update (31947 of 57385 KB)...
[2022-12-07 21:56:00] Downloading update (34667 of 57385 KB)...
[2022-12-07 21:56:00] Downloading update (37116 of 57385 KB)...
[2022-12-07 21:56:00] Downloading update (39477 of 57385 KB)...
[2022-12-07 21:56:01] Downloading update (41243 of 57385 KB)...
[2022-12-07 21:56:01] Downloading update (42455 of 57385 KB)...
[2022-12-07 21:56:01] Downloading update (43693 of 57385 KB)...
[2022-12-07 21:56:01] Downloading update (45070 of 57385 KB)...
[2022-12-07 21:56:02] Downloading update (46304 of 57385 KB)...
[2022-12-07 21:56:02] Downloading update (47531 of 57385 KB)...
[2022-12-07 21:56:02] Downloading update (48872 of 57385 KB)...
[2022-12-07 21:56:02] Downloading update (50116 of 57385 KB)...
[2022-12-07 21:56:03] Downloading update (51343 of 57385 KB)...
[2022-12-07 21:56:03] Downloading update (5[25](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:27)69 of 57385 KB)...
[2022-12-07 21:56:03] Downloading update (53885 of 57385 KB)...
[2022-12-07 21:56:03] Downloading update (55134 of 57385 KB)...
[2022-12-07 21:56:04] Downloading update (56361 of 57385 KB)...
[2022-12-07 21:56:04] Downloading update (57385 of 57385 KB)...
[2022-12-07 21:56:04] Download Complete.
[2022-12-07 21:56:04] uninstalled manifest found in /opt/hostedtoolcache/steamcmd/latest/i386/package/steam_cmd_linux (1).
[2022-12-07 21:56:04] Found pending update
[2022-12-07 21:56:04] Applying update...
[2022-12-07 21:56:04] Extracting package...
[2022-12-07 21:56:10] Installing update...
[2022-12-07 21:56:10] Cleaning up...
[2022-12-07 21:56:10] Update complete, launching...
[2022-12-07 21:56:10] Shutdown

[2022-12-07 21:56:11] Startup - updater built Nov  4 2022 17:42:31
[2022-12-07 21:56:11] Startup - Steam Client launched with: '/opt/hostedtoolcache/steamcmd/latest/i386/linux32/steamcmd' '+quit'
[2022-12-07 21:56:11] Failed to load cached hosts file (File 'update_hosts_cached.vdf' not found), using defaults
[2022-12-07 21:56:11] Using the following download hosts for Public, Realm steamglobal
[2022-12-07 21:56:11] 1. http://media.steampowered.com, /client/, Realm 'steamglobal', weight was 1, source = 'baked in'
[2022-12-07 21:56:11] Checking for update on startup
[2022-12-07 21:56:11] Checking for available updates...
[2022-12-07 21:56:11] Downloading manifest: http://media.steampowered.com/client/steam_cmd_linux
[2022-12-07 21:56:11] Manifest download: send request
[2022-12-07 21:56:11] Manifest download: waiting for download to finish
[2022-12-07 21:56:11] Manifest download: finished
[2022-12-07 21:56:11] Download skipped: /client/steam_cmd_linux version<PHONE_NUMBER>, installed version<PHONE_NUMBER>, existing pending version 0
[2022-12-07 21:56:11] Nothing to do
[2022-12-07 21:56:11] Verifying installation...
[2022-12-07 21:56:11] Performing checksum verification of executable files
[2022-12-07 21:56:11] Unable to read and verify install manifest /opt/hostedtoolcache/steamcmd/latest/i386/package/steam_cmd_linux.installed
[2022-12-07 21:56:11] Verification complete
[2022-12-07 21:56:11] Downloading update...
[2022-12-07 21:56:11] Checking for available updates...
[2022-12-07 21:56:11] Downloading manifest: http://media.steampowered.com/client/steam_cmd_linux
[2022-12-07 21:56:11] Manifest download: send request
[2022-12-07 21:56:11] Manifest download: waiting for download to finish
[2022-12-07 21:56:11] Manifest download: finished
[2022-12-07 21:56:11] Downloaded new manifest: /client/steam_cmd_linux version<PHONE_NUMBER>, installed version<PHONE_NUMBER>, existing pending version 0
[2022-12-07 21:56:11] Download complete.
[2022-12-07 21:56:11] uninstalled manifest found in /opt/hostedtoolcache/steamcmd/latest/i386/package/steam_cmd_linux (1).
[2022-12-07 21:56:11] Extracting package...
[2022-12-07 21:56:17] Installing update...
[2022-12-07 21:56:17] Cleaning up...
[2022-12-07 21:56:17] Update complete, launching Steamcmd...
[2022-12-07 21:56:17] Shutdown

[2022-12-07 21:56:17] Startup - updater built Nov  4 2022 17:42:31
[2022-12-07 21:56:17] Startup - Steam Client launched with: '/opt/hostedtoolcache/steamcmd/latest/i386/linux32/steamcmd' '+quit'
[2022-12-07 21:56:17] Failed to load cached hosts file (File 'update_hosts_cached.vdf' not found), using defaults
[2022-12-07 21:56:17] Using the following download hosts for Public, Realm steamglobal
[2022-12-07 21:56:17] 1. http://media.steampowered.com, /client/, Realm 'steamglobal', weight was 1, source = 'baked in'
[2022-12-07 21:56:17] Checking for update on startup
[2022-12-07 21:56:17] Checking for available updates...
[2022-12-07 21:56:17] Downloading manifest: http://media.steampowered.com/client/steam_cmd_linux
[2022-12-07 21:56:17] Manifest download: send request
[2022-12-07 21:56:18] Manifest download: waiting for download to finish
[2022-12-07 21:56:18] Manifest download: finished
[2022-12-07 21:56:18] Download skipped: /client/steam_cmd_linux version<PHONE_NUMBER>, installed version<PHONE_NUMBER>, existing pending version 0
[2022-12-07 21:56:18] Nothing to do
[2022-12-07 21:56:18] Verifying installation...
[2022-12-07 21:56:18] Performing checksum verification of executable files
[2022-12-07 21:56:18] Verification complete
[2022-12-07 21:56:19] Shutdown

[2022-12-07 21:56:20] Startup - updater built Nov  4 2022 17:42:31
[2022-12-07 21:56:20] Startup - Steam Client launched with: '/opt/hostedtoolcache/steamcmd/latest/i386/linux32/steamcmd' '+login' '***' '***' '' '+run_app_build' '/home/runner/work/DINO-MERCS-unity/DINO-MERCS-unity/manifest.vdf' '+quit'
[2022-12-07 21:56:20] Failed to load cached hosts file (File 'update_hosts_cached.vdf' not found), using defaults
[2022-12-07 21:56:20] Using the following download hosts for Public, Realm steamglobal
[2022-12-07 21:56:20] 1. http://media.steampowered.com, /client/, Realm 'steamglobal', weight was 1, source = 'baked in'
[2022-12-07 21:56:20] Checking for update on startup
[2022-12-07 21:56:20] Checking for available updates...
[2022-12-07 21:56:20] Downloading manifest: http://media.steampowered.com/client/steam_cmd_linux
[2022-12-07 21:56:20] Manifest download: send request
[2022-12-07 21:56:20] Manifest download: waiting for download to finish
[2022-12-07 21:56:20] Manifest download: finished
[2022-12-07 21:56:20] Download skipped: /client/steam_cmd_linux version<PHONE_NUMBER>, installed version<PHONE_NUMBER>, existing pending version 0
[2022-12-07 21:56:20] Nothing to do
[2022-12-07 21:56:20] Verifying installation...
[2022-12-07 21:56:20] Performing checksum verification of executable files
[2022-12-07 21:56:20] Verification complete
[2022-12-07 21:57:12] Shutdown

#################################
#             Output            #
#################################

BuildOutput:
total 112K
drwxr-xr-x  2 runner docker 4.0K Dec  7 21:57 ./
drwxr-xr-x 16 runner docker 4.0K Dec  7 21:56 ../
-rwxr-xr-x  1 runner docker  297 Dec  7 21:57 app_build_***.log
-rwxr-xr-x  1 runner docker  [27](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:29)K Dec  7 21:56 depot_build_1827641.log
-rwxr-xr-x  1 runner docker  165 Dec  7 21:56 depot_build_1827641.vdf
-rwxr-xr-x  1 runner docker  [32](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:34)K Dec  7 21:56 depot_build_18276[42](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:44).log
-rwxr-xr-x  1 runner docker  165 Dec  7 21:56 depot_build_1827642.vdf
-rwxr-xr-x  1 runner docker  27K Dec  7 21:57 depot_build_18276[43](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:45).log
-rwxr-xr-x  1 runner docker  165 Dec  7 21:[57](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:59) depot_build_1827[64](https://github.com/timothymalcham/DINO-MERCS-unity/actions/runs/3642927755/jobs/6151020002#step:6:66)3.vdf
Error: Process completed with exit code 1.

How to reproduce

Workflow:
name: 🚀 Build Game & Deploy to Steam 🚀

on:
    push:
        tags:
            - 'v*'

jobs:
  buildForWindowsMacAndLinux:
    name: Build for ${{ matrix.targetPlatform }}
    runs-on: ubuntu-latest
    strategy:
      fail-fast: false
      matrix:
        targetPlatform:
          - StandaloneWindows64 # Build a Windows 64-bit standalone.
          - StandaloneLinux64 # Build a Linux 64-bit standalone.
          - StandaloneOSX # Build a OSX intel 64-bit standalone.
    outputs:
      buildVersion: ${{ steps.build.outputs.buildVersion }}
    steps:
      - uses: actions/checkout@v2
        with:
          fetch-depth: 0
          lfs: true

      - uses: actions/cache@v2
        with:
          path: Library
          key:
            Library-${{ matrix.targetPlatform }}-${{ hashFiles('Assets/**', 'Packages/**',
            'ProjectSettings/**') }}
          restore-keys: |
            Library-${{ matrix.targetPlatform }}-
            Library-

      - uses: game-ci/unity-builder@v2
        id: build
        env:
          UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}
        with:
          targetPlatform: ${{ matrix.targetPlatform }}
          versioning: Semantic

      - uses: actions/upload-artifact@v2
        with:
          name: Build-${{ matrix.targetPlatform }}
          path: build/${{ matrix.targetPlatform }}

  deployToSteam:
    needs: [buildForWindowsMacAndLinux]
    runs-on: ubuntu-latest
    steps:
      - name: Checkout Repository
        uses: actions/checkout@v2
        with:
          fetch-depth: 0

      - name: Download StandaloneWindows64 Artifact
        uses: actions/download-artifact@v2
        with:
          name: Build-StandaloneWindows64
          path: build/StandaloneWindows64

      - name: Download StandaloneLinux64 Artifact
        uses: actions/download-artifact@v2
        with:
          name: Build-StandaloneLinux64
          path: build/StandaloneLinux64

      - name: Download StandaloneOSX Artifact
        uses: actions/download-artifact@v2
        with:
          name: Build-StandaloneOSX
          path: build/StandaloneOSX

      - uses: game-ci/steam-deploy@v1
        with:
          username: ${{ secrets.STEAM_USERNAME }}
          password: ${{ secrets.STEAM_PASSWORD }}
          configVdf: ${{ secrets.STEAM_CONFIG_VDF}}
          ssfnFileName: ${{ secrets.STEAM_SSFN_FILE_NAME }}
          ssfnFileContents: ${{ secrets.STEAM_SSFN_FILE_CONTENTS }}
          appId: ${{ secrets.STEAM_APP_ID }}
          buildDescription: v${{ needs.buildForWindowsMacAndLinux.outputs.buildVersion }}
          rootPath: build
          depot1Path: StandaloneWindows64
          depot2Path: StandaloneOSX
          depot3Path: StandaloneLinux64
          releaseBranch: prerelease

Expected behavior
I would expect that if the build makes it to steam, then this job should not fail.

Any suggestions on what I can I do?

@timothymalcham whats your BuildOutput/depotbuild.log content ?
Also, do check in steamworks if the build actually uploaded but the Job failed, if that is so, its probably because of either using default branch or using custom branch that doesn't exist
If you are on the GameCI discord, I have posted a detailed post about it and other considerations while using steam-deploy (discord username Shiroyasha)

I just ran into the same issue, and suspect it's related to the following excerpt from your log (which also caused my build to fail, as well):
assert_20221207215620_17.dmp[1887]: Finished uploading minidump (out-of-process): success = no
assert_20221207215620_17.dmp[1887]: error: libcurl.so: cannot open shared object file: No such file or directory
assert_20221207215620_17.dmp[1887]: file ''/tmp/dumps/assert_20221207215620_17.dmp'', upload no: ''libcurl.so: cannot open shared object file: No such file or directory''
src/public/tier1/interface.h (264) : m_pModule

The solution is probably to install libcurl-dev, but I'll need to test myself and see.

@timothymalcham As it happens, I was experiencing the same commit failure + successful upload issue earlier today for my initial build. On a hunch, I checked the available branches under the SteamPipe tab and noticed that only the default branch was enabled initially, where my Action's releaseBranch input was configured to deploy to the prerelease branch (which did not yet exist).
After creating a branch matching the releaseBranch input for the action, I no longer received the error message.

Closing this issue, as it seems to be resolved by ensuring that the release branch has been created. Please feel free to re-open if there is actually another cause.


Leapmotion when UE4 game doesn't have focus

Hi,
I've been doing some experimentation and I have a couple of questions on some minor annoyances:
1- Is there a way to keep receiving leapmotion data when the UE4 game (or editor) doesnt have focus? Right now as soon as you alt tab the service is 'paused'
2- In a packaged build, when the hands are not seen by leap the hands are not hidden in game (leaving me with the hands obscuring the camera) -- Is this a bug or is there a quick fix that I can apply for this?
Thanks,
-Ozzadar

I've solved issue #1, found the EnableBackgroundTracking on leapcontroller; though I can't get it to work properly on BeginPlay or in Constructor. I have to stick it in my Tick function for it to work as intended.
Thoughts?

interesting on 2, if you bring your hands in view and out of the view again do they hide? There may be a toggle missing on the character bp

Nope, they stay visible no matter what I do.
It's quite perplexing. I've taken a look through the blueprints and can't seem to find the root cause. =/

and this only happens when the game is packaged?

Yeah, I just built a packaged game with the base blueprint and experienced the same behaviour (incase it was something wonky going on with my custom character)
Definitely something fishy happening =/

Oh, on a related note(to #1); it seems that leapmotion background tracking crashes unreal engine after a few minutes.
Read access violation error of some sort though I dont have the .pdb loaded so I cant track it down perfectly. I'll be attempting to check that out for you later (may even submit a change if I can fix it)

are you using the in-engine plugin or a project plugin using latest updates from this repo? Also what engine version?

4.12.4 and using the plugin included with the engine. Is that one woefully out of date?

It isn't and it is in fact probably the most stable release, but I have done some changes to the repo here which may or may not alleviate this problem. You can try it out by just downloading the repo, dragging the Plugins folder into your project. Let me know if that changes anything.


[CAMEL-13466] Fully populate (including routes which failed to start) routes to be stopped in the CamelContext

@oscerd I'm adding new tests to validate the behavior, but in the mean time, it would be great if you can take a look.

I'm not sure about this, I'd like to have feedback from @davsclaus too

I think it doesn't hurt the normal behavior.

@oscerd yes, I tested with both "success" and "failure" routes, and it works fine.

So the point is that the RouteStartupOrder list does not currently contain routes that failed to startup? And those "invalid routes" should be attempted to stop anyway?
And to ensure this, you add all defined routes with the addAll method? And if so, don't you add duplicate routes, eg all the existing routes that started up are already there.
So I think you should only add the routes which are not already present.
And would it be possible to create an unit test that reproduces this and verifies the fix. This is a core feature in camel to startup and shutdown gracefully and therefore unit test is much appreciated.

@davsclaus yes, I'm adding a test to illustrate. Good point to verify if a route doesn't appear twice.

I've updated the PR to avoid duplicated in the RouteStartupOrder list. I'm working on a test to illustrate.

Working on a fix with unit test. Closing this PR


Option to view the SQL code of a (scheduled) BigQuery SQL query in dbeaver

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
I would like to view the SQL code of (scheduled) queries from GBQ in dbeaver (shown with circles):

When I "View Data" on these queries they are automatically executed. I would like another option to be able to also inspect the SQL code for this query.
Like in the "Details" tab on the GBQ web UI:

Could you please clarify if GBQ stands for Google Big Query?

Could you please clarify if GBQ stands for Google Big Query?

Yes

You can open the View DDL with at least two ways (way 1 and way 2 steps are on the screen)

Way 1

Click on View View in the context menu.
By default the last opened tab will be opened (Properties, Data or ER Diagram). However if you're afraid of opening Data tab, you can set up here in preferences which tab should be opened by default.

Switch vertical tab to Definition

Way 2

Click on Generate SQL -> DDL in the context menu and get it.

@E1izabeth
This does not seem to work for any of the scheduled queries in my Google BigQuery project.
Always get "View definition not available":

I see. Thank you for explanation.

Hello, I have the same problem - I am not able to see DDL of views in Google BigQuery. Using both ways I get View definition not available.

@lukasheinz92
You can vote for the issue with 👍 under the issue description to promote it to a higher priority.

The same thing happens for Procedures. The DDL code is not available, it says "-- Source code not available"


Using keras.layers.BatchNormalization inside keras.layers.TimeDistributed causes bad validation loss/accuracy

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): tensorflow-gpu 1.13.1
Python version: 3.6.7
CUDA/cuDNN version: v10
GPU model and memory: GTX 980M

Describe the current behavior
Using BatchNorm inside a TimeDistributed layer results in poor validation performance. A model trained and validated on identical data can reach 100% train accuracy but never reach that when validating against the same sample. Removing the Batchnorm layer resolves the issue.
See the training results from a toy example:
500/500 loss: 1.6910 - sparse_categorical_accuracy: 0.2400 - val_loss: 1.7292 - val_sparse_categorical_accuracy: 0.2000
Epoch 2/100

500/500 loss: 1.2619 - sparse_categorical_accuracy: 0.5600 - val_loss: 1.6112 - val_sparse_categorical_accuracy: 0.2000
Epoch 3/100

500/500 loss: 0.9130 - sparse_categorical_accuracy: 0.9200 - val_loss: 1.5113 - val_sparse_categorical_accuracy: 0.2000
Epoch 4/100

500/500  loss: 0.6420 - sparse_categorical_accuracy: 1.0000 - val_loss: 1.4297 - val_sparse_categorical_accuracy: 0.2000
Epoch 5/100
...
...
...
500/500 loss: 8.2955e-04 - sparse_categorical_accuracy: 1.0000 - val_loss: 1.1042 - val_sparse_categorical_accuracy: 0.2000
Epoch 100/100

Describe the expected behavior
When training and validating on an identical sample, the model should get the same accuracy during both training and validation. To eliminate the possibility that this is caused by a difference between the running mean/variance and the batchwise mean/variance, a very small value of BatchNorm Momentum was trialed. It was observed that modifying Momentum appears to have no effect. BatchNorm should not affect a model's ability to make good predictions.
Code to reproduce the issue
The following code shows the issue. Run it a few times and watch the validation accuracy/loss.
from tensorflow import keras
import tensorflow as tf
import numpy as np
import random

time_steps = 5
sample_width = 20
kernel_size = 3
num_filters = 5
num_classes = 5

def build_graph():
    with tf.name_scope("SequenceProcess"):
        sequence_input = keras.layers.Input(shape=(time_steps, sample_width))

        with tf.name_scope("TimeDistributed"):
            sample_input = keras.layers.Input(shape=(sample_width,))

            conv = keras.layers.Reshape([sample_width, 1])(sample_input)
            conv = keras.layers.BatchNormalization(momentum=0.01)(conv)
            conv = keras.layers.Conv1D(num_filters, kernel_size, padding='same')(conv)
            encoded_sample = keras.layers.Reshape((num_filters * sample_width,))(conv)

            sample_model = keras.models.Model(sample_input, encoded_sample)

        processed_samples = keras.layers.TimeDistributed(sample_model)(sequence_input)
        fc = keras.layers.Dense(num_classes, activation='softmax')(processed_samples)

        sequence_model = keras.models.Model(sequence_input, fc)
        sequence_model.compile(loss='sparse_categorical_crossentropy', optimizer='adam', metrics=['sparse_categorical_accuracy'])

    return sequence_model

def generate_data():
    steps = []
    for i in range(time_steps):
        sample_data = np.random.rand(sample_width)
        steps.append(sample_data)
    steps = np.array(steps)

    labels = []
    for i in range(time_steps):
        label = random.randint(0, num_classes - 1)
        labels.append([label])
    labels = np.array(labels)

    input_data = []
    input_labels = []

    for i in range(1000):
        input_data.append(steps)
        input_labels.append(labels)

    return np.array(input_data), np.array(input_labels)

if __name__ == '__main__':
    data, labels = generate_data()
    model = build_graph()
    model.fit(data, labels, 10, 100, validation_split= 0.5)

@LukeBolly I am able to reproduce the issue on colab with Tensorflow-gpu 1.13.1 by executing multiple times.

Doing some debugging, turns out the running mean and variance aren't being updated:
if you add these lines after the fit
    weights = model.layers[1].layer.layers[2].get_weights()
    print('\nmean:\t\t' + str(weights[0][0]) + '\nrunning mean:\t\t' + str(weights[2][0]) + '\n')
    print('variance:\t' + str(weights[1][0]) + '\nrunning variance:\t' + str(weights[3][0]) + '\n')

you'll get the output:
mean:		1.1386212
running mean:		0.0

variance:	0.06730438
running variance:	1.0

https://github.com/keras-team/keras/issues/7466#issuecomment-500002720
https://github.com/keras-team/keras/issues/12400
https://github.com/keras-team/keras/pull/7467
If you've got an idea how I could work around this in the meantime, it would be much appreciated.

Updating to 1.14 yielded different but still incorrect results. On the plus side, at least the running mean and variance are being updated now:
mean:		1.2015477
running mean:		0.5039695

variance:	-0.19005191
running variance:	0.08481312

The current test doesn't catch the error because it just asserts that the values aren't 0 and 1

The running mean and variance update in 1.14, though the results still don't seem right
Epoch 1/5
500/500 - 2s - loss: 1.2191 - sparse_categorical_accuracy: 0.5640 - val_loss: 0.9704 - val_sparse_categorical_accuracy: 0.6000
Epoch 2/5
500/500 - 0s - loss: 0.2219 - sparse_categorical_accuracy: 1.0000 - val_loss: 0.9911 - val_sparse_categorical_accuracy: 0.4000
Epoch 3/5
500/500 - 0s - loss: 0.0514 - sparse_categorical_accuracy: 1.0000 - val_loss: 1.0707 - val_sparse_categorical_accuracy: 0.4000
Epoch 4/5
500/500 - 0s - loss: 0.0236 - sparse_categorical_accuracy: 1.0000 - val_loss: 1.0686 - val_sparse_categorical_accuracy: 0.4000
Epoch 5/5
500/500 - 0s - loss: 0.0139 - sparse_categorical_accuracy: 1.0000 - val_loss: 1.0246 - val_sparse_categorical_accuracy: 0.4000

gamma:		1.1039916
running mean:		0.18822414

beta:	0.15830743
running variance:	0.63675237

Given that the Momentum value is basically 0, shouldn't validation_accuracy be rougly equal to train_accuracy?

It turns out momentum is more complicated than I thought. A value of 0.5 makes the train and validation accuracies match.
Using a value of 0 causes the moving averages to overshoot, and you end up with something like this:
running mean:		1.0374619		running variance:	-0.82485986
running mean:		0.010333061		running variance:	0.9818245
running mean:		1.0272316		running variance:	-0.80686545
running mean:		0.020461679		running variance:	0.9640094
running mean:		1.017204		running variance:	-0.7892276
running mean:		0.03038919		running variance:	0.94654715
running mean:		1.0073754		running variance:	-0.7719393
running mean:		0.040119976		running variance:	0.9294311
running mean:		0.99774146		running variance:	-0.7549938
running mean:		0.04965794		running variance:	0.9126543

which explains the unstable validation loss.
Long story short, don't use a Momentum below 0.5 and don't use BatchNorm inside TimeDistributed in 1.13.


bug in WEB transfer

jq -n --arg orig $ORIGINATOR_ID --arg origDep $DEPOSIT_ID1 --arg rec $RECEIVER_ID --arg recDep $DEPOSIT_ID2 '{"transferType": "push", "amount": "USD 99.99", "originator": $orig, "originatorDepository": $origDep, "receiver": $rec, "receiverDepository": $recDep, "description": "Loan Pay", "standardEntryClassCode": "WEB", "sameDay": false, "CCDDetail": { "paymentInformation": "test payment" }, "WEBDetail": { "paymentInformation": "test payment", "paymentType": "single" } }' | curl -k -o - -s  --header "X-User-Id: $USER_ID" --request POST --url https://moov-paygate.$SANDBOX/transfers --data @- | jq .
{
  "error": "createACHFile: WEB: createWEBBatch: reoccurring WEB transfers are not supported yet"
}

In the detail above the WEB type is "single".  However, I get an error saying reoccurring WEB transfers are not support.
Are any WEB type transfers supported yet?

That is strange.. I took your JSON and verified the WEBDetail.PaymentType is single, so I'm not sure how that error is generated.
createWEBBatch: reoccurring WEB transfers are not supported is generated with the incoming paymentType, so it looks like the JSON had reoccurring.
In my tests I kept in the CCDDetail sub-object, but that's not read for WEB transfers.

This is what I was using to double check the JSON body:
func TestWEBTransfer__json(t *testing.T) {
	body := strings.NewReader(`{
"transferType": "push",
"amount": "USD 99.99",
"originator": "$orig",
"originatorDepository": "$origDep",
"receiver": "$rec",
"receiverDepository": "$recDep",
"description": "Loan Pay",
"standardEntryClassCode": "WEB",
"sameDay": false,
"CCDDetail": { "paymentInformation": "test payment" },
"WEBDetail": { "paymentInformation": "test payment", "paymentType": "single" }
}`)
	var req transferRequest
	if err := json.NewDecoder(body).Decode(&req); err != nil {
		t.Fatal(err)
	}

	t.Errorf("%#v", req)
	t.Errorf("%#v", req.WEBDetail)
	t.Error(req.WEBDetail.PaymentType == WEBSingle)
}

I'm not 100% on this because I have not had time to adding debugging statements.  However, I think the problem might be here:
transfer := req.asTransfer(id)
The asTransfer method does not appear to copy over the WEB, TEL or any other substructure.  So the values would all be nil.  This would trigger the error I see.

I started a build (v0.6.0-rc1) with this fix added - https://travis-ci.com/moov-io/paygate/builds/118348590


Hidden content is not calculated

Hi
First of all, thanks for such an awesome plugin, it works like a charm, I have used it in my project mentioned below and it works perfectly as expected.
However, I have a unique issue, in my project there is a hidden content, and on click of a button (button name is hidden content) we are showing the content inside the div, but when I click on the button only that div is expanding, not the other 2 div, also the parent div classes are not applying due to fixing the height at the initial level.
Below is the link.
http://pacificit.in/visitfree1/overview.html
Kindly check the below image to have a look at initial stage

Below is the image after I click on the hidden content button

This is common behaviour for any browser. Something that is "display:none" has no height nor width, therefore is not calculated. You could call the matchHeight again when you display new content to force the recalculation of the containers height.

Thanks for the input, it worked.

@livin52 is correct (although there is support for matching heights of elements that are inside hidden parents, but it may not always be reliable)
Generally dynamic content requires manual updates, see here.


Vmlinux

Upgrade libbpf submodule
Build libbpf static library using make
Upgrade bindgen crate
Add bpf_sys::type_gen::VmlinuxBtfDump that generates vmlinux.h from vmlinux image
Add logic on how to select methods of generating rust bindings

Methods of generating rust bindings
Rust bindings for structs and enums of the Linux kernel are used by BPF programs.
There are two methods for generating the rust bindings.

Generate rust bindings from the Linux kernel headers that are pre-installed
in the system. The Linux kernel headers are located by
bpf_sys::headers.

Generate rust bindings from vmlinux.h. It is generated on the spot by
bpf_sys::type_gen. The vmlinux is an
image of the Linux kernel so all data types including internal structs and
enums can be dumped into C source code from the vmlinux image.

Users of redBPF can select a preferred method for generating rust bindings by
setting environment variables explained as below.
Rules about method selection
In order to select a method between two methods, three environment variables are
involved: KERNEL_SOURCE, KERNEL_VERSION and REDBPF_VMLINUX.
Case 1. No setting
If none of the three environment variables are set, both two methods of
generating rust bindings will be tried. First, the method with the Linux kernel
headers is tried. If it fails, then the method with vmlinux is tried as
fallback.
Case 2. When REDBPF_VMLINUX is set
REDBPF_VMLINUX takes precedence over KERNEL_SOURCE and KERNEL_VERSION
environment variables. So the method of generating rust bindings of the Linux
kernel data structures for BPF programs is to vmlinux.h that is generated from
vmlinux image. No pre-installed kernel headers are required in this case.
Case 3. REDBPF_VMLINUX is not set, but any of KERNEL_SOURCE or
KERNEL_VERSION environment variables are set
The method of generating rust bindings of the Linux kernel data structures for
BPF programs is to use the kernel headers in the specified path. In this case
vmlinux is not required at all.
Possible REDBPF_VMLINUX values

A path to the custom vmlinux. e.g) REDBPF_VMLINUX=/boot/my-vmlinux-5.11.0

Special treatment for REDBPF_VMLINUX=system. If system is given, redBPF
tries to probe vmlinux from the well-known system paths and uses it

REDBPF_VMLINUX not set. The behavior of redBPF depends on whether
KERNEL_SOURCE and KERNEL_VERSION environment variables are given or not.

@rsdy I renamed VmlinuxBtfDump::whitelist to VmlinuxBtfDump::allowlist and re-pushed.
But I could not figure out how to use std::fs instead of libc::fopen because of the reason I mentioned above. Do you have ideas?

@rsdy I removed calling libc::fopen and used std::fs::File instead. It looks better. Thanks,


feat: Changed Azure.AppGwWAF.RuleGroups to the latest bot manager rul…

Fixes #2629
Changed Azure.AppGwWAF.RuleGroups to the latest bot manager rule set.
PR Summary

PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[ ] Change is not breaking
[ ] This PR is ready to merge and is not Work in Progress
Rule changes

[x] Unit tests created/ updated
[x] Rule documentation created/ updated
[x] Link to a filed issue
[x] Change log has been updated with change under unreleased section

Other code changes

[ ] Unit tests created/ updated
[ ] Link to a filed issue
[ ] Change log has been updated with change under unreleased section

Hi @BernieWhite.
Should I update to a new baseline? I'm unsure if this is considered a breaking change. It will cause previous deployments with the 0.1 version to fail if they use this baseline.
I also have discovered a problem when trying to analyze, after switching over to macOS. I'm considering to create a separate issue for this, but just want to check with you first if it's a quick one. I don't feel confident in this PR before I can verify that the test works for the rule as intended.
Building locally:
Rules processed: 4348, failed: 65, errored: 0
Run 92ec37ac4e2791505dba95ad042544f30c3e370e completed in 00:00:00.2359664
WARNING: One or more rules reported failure.
Output written to the following file: '/Users/benji/PSRule.Rules.Azure/reports/ps-rule-file2.xml'
Done /Test/Rules 00:00:00.7449080
Task /Test/TestDotNet
  Determining projects to restore...
  All projects are up-to-date for restore.
  BuildTool -- Building type index
  BuildTool -- 283 providers processed
  BuildTool -- Minify types
  BuildTool -- 283 providers processed
  BuildTool -- Minify environments
  BuildTool -- Minify policy-ignore
/Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/Data/Template/Mocks.cs(280,30): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/PSRule.Rules.Azure.csproj]
/Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/Data/Template/Mocks.cs(253,42): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/PSRule.Rules.Azure.csproj]
/Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/Data/Template/Mocks.cs(258,30): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/PSRule.Rules.Azure.csproj]
/Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/Data/Template/Mocks.cs(295,30): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/PSRule.Rules.Azure.csproj]
/Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/Data/Template/Mocks.cs(300,42): warning CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' annotations context. [/Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/PSRule.Rules.Azure.csproj]
  PSRule.Rules.Azure -> /Users/benji/PSRule.Rules.Azure/src/PSRule.Rules.Azure/bin/Debug/netstandard2.0/Microsoft.PSRule.Rules.Azure.Core.dll
  PSRule.Rules.Azure.Tests -> /Users/benji/PSRule.Rules.Azure/tests/PSRule.Rules.Azure.Tests/bin/Debug/net7.0/PSRule.Rules.Azure.Tests.dll
Test run for /Users/benji/PSRule.Rules.Azure/tests/PSRule.Rules.Azure.Tests/bin/Debug/net7.0/PSRule.Rules.Azure.Tests.dll (.NETCoreApp,Version=v7.0)
Microsoft (R) Test Execution Command Line Tool Version 17.8.0 (arm64)
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:00.15]     PSRule.Rules.Azure.ExpressionBuilderTests.BuildExpressionWithDateTimeAdd [FAIL]
  Failed PSRule.Rules.Azure.ExpressionBuilderTests.BuildExpressionWithDateTimeAdd [< 1 ms]
  Error Message:
   Assert.Equal() Failure: Values differ
Expected: 4/7/2023 2:53:14 PM
Actual:   4/7/2023 2:53:14PM
  Stack Trace:
     at PSRule.Rules.Azure.ExpressionBuilderTests.BuildExpressionWithDateTimeAdd() in /Users/benji/PSRule.Rules.Azure/tests/PSRule.Rules.Azure.Tests/ExpressionBuilderTests.cs:line 122
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Failed!  - Failed:     1, Passed:   210, Skipped:     0, Total:   211, Duration: 423 ms - PSRule.Rules.Azure.Tests.dll (net7.0)
ERROR: Command exited with code 1. {
            # Test library
            # dotnet test --logger trx -r (Join-Path $PWD -ChildPath reports/) tests/PSRule.Rules.Azure.Tests
            dotnet test tests/PSRule.Rules.Azure.Tests
        }
At /Users/benji/PSRule.Rules.Azure/pipeline.build.ps1:201 char:9
+         exec {
+         ~~~~~~
At /Users/benji/PSRule.Rules.Azure/pipeline.build.ps1:192 char:1
+ task TestDotNet {
+ ~~~~~~~~~~~~~~~~~
Build FAILED. 13 tasks, 1 errors, 0 warnings 00:00:13.0686350
Invoke-BuildExec: /Users/benji/PSRule.Rules.Azure/pipeline.build.ps1:201:9
Line |
 201 |          exec {
     |          ~~~~~~
     | Command exited with code 1. {             # Test library             # dotnet test --logger trx -r (Join-Path $PWD -ChildPath reports/)
     | tests/PSRule.Rules.Azure.Tests             dotnet test tests/PSRule.Rules.Azure.Tests         }

Running Invoke-PSRule:
PS /Users/benji/PSRule.Rules.Azure> invoke-psrule -f ./tests/PSRule.Rules.Azure.Tests/Resources.AppGwWAF.json -m PSRule.Rules.Azure -name 'Azure.AppGwWAF.RuleGroups' -Outcome Fail
format-default: Cannot process argument because the value of argument "name" is not valid. Change the value of the "name" argument and run the operation again.

@BenjaminEngeset  Yep, you're correct we should bump the rule set to 2024_03.

The issue PSRule.Rules.Azure.ExpressionBuilderTests.BuildExpressionWithDateTimeAdd I think might be with the date formatting on your system. I think we can treat this as a new bug, since this function should behave the same regardless of who runs it because it is meant to emulate the result from Azure.

The issue format-default: Cannot process argument because the value of argument "name" is not valid. Change the value of the "name" argument and run the operation again. may be an issue with PowerShell 7.4. or PSRule with PowerShell 7.4. Tracking it over here: https://github.com/microsoft/PSRule/issues/1723.
This shouldn't affect the Pester tests but to work around it for testing locally you can append  | Select-Object RuleName, Outcome, Recommendation to the end of your command line. Or you could use Assert-PSRule instead.

Thanks @BernieWhite! Suggestions made sense, so they are now implemented.
The | Select-Object approach did work for me after the cmdlet, so I were able to test the changes locally.
Let me know what you think.


Covalic support

These are a small handful of changes needed to get the full COVALIC functionality working using Romanesco as the worker.

@jeffbaumes Does this look good to merge?

LGTM