TF 2.1/tf.keras AdaDelta optimizer: default epsilon and learning rate values

Hi @tanzhenyu @lamberta @dynamicwebpaige There are two param default values for AdaDelta that look different from the original implementation. It is probably explained in past discussions (and if it is the case pls let me know where I can find it so we can close this issue.) Cheers.
Similar issues: https://github.com/tensorflow/tensorflow/issues/31024 and https://github.com/tensorflow/tensorflow/pull/31025.
TF 2.1 API docs for the Adadelta optimizer come from /optimizer-v2/, where:

The learning rate is set to 0.001:

Keras' implementation states that learning rate is 1.
optimizer.py (v1) sets it to 1 (synced with Keras, I suppose).
There's a Keras PR - https://github.com/keras-team/keras/pull/12841 - that proposed to change the LR from 1 to 0.001. It may have been reverted back to 1 (see commit https://github.com/keras-team/keras/pull/12888/commits/2009cab5217a57bfbb4dae88371640ce1bb4a0e9).

The default epsilon does not match the one in the original AdaDelta paper as well as Keras' implementation:

They use 1e-6 instead of 1e-7 ("Setting the hyperparameters to ε = 1e − 6 and ρ = 0.95...").

Sources:

TF 2.1 /optimizer_v2/:

@keras_export('keras.optimizers.Adadelta')
class Adadelta(optimizer_v2.OptimizerV2):
  ...
  def __init__(self,
               learning_rate=0.001,
               rho=0.95,
               epsilon=1e-7,
               name='Adadelta',
               **kwargs):

TF 2.1 optimizers.py - version 1:

class Adadelta(Optimizer):
...
  def __init__(self, lr=1.0, rho=0.95, epsilon=None, decay=0., **kwargs):
...

Keras optimizers.py:

class Adadelta(Optimizer):
...
    def __init__(self, learning_rate=1.0, rho=0.95, **kwargs):
...

Thanks for taking your time to look at this potential issue.

Hi @8bitmp3 , I also had a similar doubt when I came across the paper and the API documentation. I think according to the paper,the step size converges to 1 at end of training and the convergence occurs when the gradients and parameters updates are smaller. However there is a mismatch in the documentation which suggests that lr=0.001 whereas in the paper it is lr=1.0 and epsilon=1e-6. The less the LR I think it would be locally stuck in minima and not contribute significantly .

Hi @8bitmp3 ,@gadagashwini, Have made a comment in the  https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/keras/optimizer_v2/adadelta.py
The comment states the original details as mentioned in the paper with LR 1 and epsilon 1e-6.
PR #36832

@8bitmp3 I checked that @abhilash1910 PR https://github.com/tensorflow/tensorflow/pull/36849 got merged and I also reviewed that AddaDelta in keras-team/keras and tf.keras are in sync.
Here is the TF page on AdaDelta with the update.
Here is the link to AddaDelta in keras-team/keras.
  def __init__(self,
               learning_rate=0.001,
               rho=0.95,
               epsilon=1e-7,
               name='Adadelta',
               **kwargs):

Please verify once and close the issue if this was resolved for you. Thanks!


Add support for phoneHomeIntervalInSecs and deployment pass4SymmKey

Enhancements

Implements https://github.com/splunk/ansible-role-for-splunk/issues/35

Testing completed. All configurations generated correctly.


Relations: "on_delete" tag option and do I still need notnull?

With go-pg I had:
type Player struct {
  // ... many columns

  ProfileID int       `pg:",notnull,on_delete:CASCADE"`
  Profile   *Profile  `pg:"rel:has-one"`
}

I changed it to:
type Player struct {
  // ... many columns

  ProfileID int       `bun:",notnull,on_delete:CASCADE"`
  Profile   *Profile  `bun:"rel:has-one"`
}

But:

it writes in console:
WARN: bun: 2021/05/28 23:48:25 Player.ProfileID has unknown tag option: "on_delete"

Why?

do I need notnull in this line?
ProfileID int `bun:",notnull,on_delete:CASCADE"`

has unknown tag option: "on_delete"

Bun no longer automatically creates foreign keys and does not support on_detele, because it only worked for has-one relations. The new way is to specify ForeignKey when creating a table:
_, err := db.NewCreateTable().
	Model((*Book)(nil)).
	ForeignKey(`("author_id") REFERENCES "users" ("id") ON DELETE CASCADE`)
	Exec(ctx)
if err != nil {
	panic(err)
}

See https://bun.uptrace.dev/guide/queries.html#creating-tables

do I need notnull in this line?

Yes, notnull is used to specify NOT NULL SQL constraint.


Links to the design articles are broken

The recent reorganisation (commit # 8cdd84d) has broken all the links in the table on the main ReadMe page.  The docs were moved from the root of the /docs folder into the /scenario1 folder, but the links were not updated.
Personally, I'm not sure why they were moved? The concepts discussed within these excellent pages would apply to all scenarios. Burying them under a specific scenario page makes them harder to find (especially when the links on the landing page don't take you there. ;-) )

Looking at the contents I agree, and assume this was done in error or to prep for a future change. @kunalbabre
For now lets move it back with #32 (?)


Work with contracts deployed locally- dapp

Closes https://github.com/keep-network/keep-core/issues/1810
This PR adds a guide in the readme file on how to work with contracts that have been deployed to your local network. Additionally removes unused scripts that copied contracts artifacts to the src/contracts dir.

Is this one still up to date?

The script does a great job 🚀 ! @dimpar, let's also add info about this script and requirements in the readme file.

@pdyraga @r-czajkowski do you guys have additional comments or ready for merging?

I've addressed your comments @r-czajkowski @pdyraga Ready for another look.

looks good +1. Let's merge it!


raise ValueError("Invalid station.")

Dear all,
looks like this project is dead, at least there was no replay to any of the issues.
However, I tried to get it running with my hometown.
It is working with - name: "Hohenzollernplatz"
- name: "Pasing" is also working
but I am not able to add S-Bahn station Olching
      - name: "de:09179:6110"
      - name: "Olching"
      - name: "Olching (Obb.) Olching"
      - name: "Olching, Olching (Obb.)"

non of the names above are working.
same for "Eichenau".
Any idea, what is the correct name ?

I have the same problem here with "Daglfing".
I'm not into Python but i will give it a try over the Xmas holidays to debug.

I had the same issue with some of the stations in Kirchheim. After a lot of debugging, it seems that the mvg version of the class was too old. Manually changed the manifest.json to the latest version:
  "requirements": ["mvg==1.1.2"],
And now it works fine.

@jcgonzalezdelgado
thx for debugging but now its to late, I created my own addon ^^
https://github.com/Nisbo/another_mvg

@jcgonzalezdelgado thx for debugging but now its to late, I created my own addon ^^ https://github.com/Nisbo/another_mvg

I saw it! Liked it so much I ended up using it. Thanks a lot


1176: Configure locales in build config

Short description

Add the available locales to the build config and use them to configure the app locales.
Proposed changes

Add appLocales to build config
Fix builder.dart script
Use appLocales to configure the app locales

Side effects

None.
Resolved issues

Fixes: #1176.

To test this, you can set the system language to English and change one translation in app_en.arb to something else. For bayern this should not show up in the app while for nürnberg it should.


M1 Reflection - Nadhirah

What are the great things that your team is doing?
Every team member brings a unique skill to the table, which has been invaluable. Whether it's research, presentation skills, design, or technical know-how, each person has contributed significantly using their strengths.
Are there any things in the team that you wish could be changed?
While differences in opinions are natural, there have been a couple of occasions where disagreements took longer to resolve than necessary. Having a structured method for conflict resolution might help in the future.
Do you have any ideas that could improve the current situation of your team?
I believe that instituting regular feedback sessions, where team members provide constructive feedback to each other, can be a great way to continuously improve our teamwork and the quality of our work.


Merged rules with ::placeholder pseudo-selectors broken in v3.3.7

This one looks similar to https://github.com/jakubpawlowicz/clean-css/issues/561
.some-element {
    color: #d72319;
}
.some-other-element::placeholder {
    color: #d72319;
}

Gets merged to:
.some-element,.some-other-element::placeholder{color:#d72319}

which breaks the rule.
Should be:
.some-element{color: #d72319}.some-other-element::placeholder{color:#d72319}

We should treat ::placeholder selector as special too, see https://github.com/jakubpawlowicz/clean-css/blob/master/lib/utils/compatibility.js#L23


Implement real vs mock protocol parsers

Real and mock protocols require different arguments and this should be differentiated at the top level of the node.

What is this blocked by?


Fixed 'claim your state pension' link.

https://govuk.zendesk.com/agent/tickets/1157237
Also removed a couple of bits of 'hover' markdown.

Closing in favour of #1996.


InheritanceBoundary

The big advantage of implementing multiple views with a single widget tree and the OverlayPortal proposal is that overlays/views have access to the surrounding inherited widgets at their anchor point in the widget tree. However, some inherited widgets should not flow into a View or OverlayPortal.
Examples of widgets that should not be available:

the Material widget - a view needs to contain its own Material for buttons to draw splash effects on, it should not draw the splashes in the parent view
the view metrics from MediaQuery (needs to be split into ViewQuery and PlatformQuery, see https://github.com/flutter/flutter/issues/115375)
Navigator - it will be confusing if a sub-view can modify the navigation stack of the parent view, if that's required, the Navigator should be manually injected
Overlay - subviews need to contain their own Overlay if they want to show something in an overlay. It would be confusing if the subview's text handles and toolbars are drawn into the parent view's overlay

To support this, we could introduce an InheritanceBoundary that View/OverlayPortal could use to stop certain tagged InheritedWidget from propagating to their children. The InheritedWidget itself gets to decide whether it wants to propagate through the boundary or not.
Implementation Idea:
InheritanceBoundary is a mixin on Element that overrides Element._updateInheritance. Since that method is private (and should likely remain so) it needs to be implemented in framework.dart. Instead of just copying the list of inherited widgets from its parent, InheritanceBoundary will only copy the ones that are allowed to flow through the boundary. The InheritedWidget constructor is extended with a stopsAtInheritanceBoundary argument, which defaults to false. For an InheritedWidget subclass, it must be hard-coded to true or false and is not allowed to change. This property is used by the InheritanceBoundary to determine whether a given inherited widget is supposed to flow through the boundary or not.

cc @gspencergoog @Hixie @LongCatIsLooong @a-wallen @dkwingsmt @loic-sharma @HansMuller for thoughts

The material widget and the Overlay widget use findAncestorRenderObjectOfType instead of which walks the element tree instead of the regular element inheritance mechanism so updating Element._updateInheritance might not cut it.
https://master-api.flutter.dev/flutter/material/Material/maybeOf.html
https://master-api.flutter.dev/flutter/widgets/Overlay/maybeOf.html
https://master-api.flutter.dev/flutter/widgets/Element/findAncestorRenderObjectOfType.html
Looking at the full list of InheritedWidget extenders in the framework, most widgets in the list are just passing data / theme down the element tree and don't seem to be making assumptions about what surface the dependent widgets are on?
  the full list of InheritedWidget extenders in the framework
cupertino/interface_level.dart:class CupertinoUserInterfaceLevel extends InheritedWidget {
widgets/nested_scroll_view.dart:class _InheritedNestedScrollView extends InheritedWidget {
//    widgets/inherited_theme.dart:abstract class InheritedTheme extends InheritedWidget { // A bunch of themes extend this
widgets/router.dart:class _RouterScope extends InheritedWidget {
widgets/selection_container.dart:class SelectionRegistrarScope extends InheritedWidget {
widgets/media_query.dart:class MediaQuery extends InheritedWidget {
widgets/shortcuts.dart:class _ShortcutRegistrarMarker extends InheritedWidget {
widgets/overlay.dart:class _RenderTheaterMarker extends InheritedWidget {
widgets/localizations.dart:class _LocalizationsScope extends InheritedWidget {
widgets/navigator.dart:class HeroControllerScope extends InheritedWidget {
widgets/scroll_notification_observer.dart:class _ScrollNotificationObserverScope extends InheritedWidget {
widgets/primary_scroll_controller.dart:class PrimaryScrollController extends InheritedWidget {
widgets/autofill.dart:class _AutofillScope extends InheritedWidget {
widgets/scrollable.dart:class _ScrollableScope extends InheritedWidget {
// widgets/inherited_notifier.dart:abstract class InheritedNotifier extends InheritedWidget {
   widgets/autocomplete.dart:class AutocompleteHighlightedOption extends InheritedNotifier> {
   widgets/draggable_scrollable_sheet.dart:class _InheritedResetNotifier extends InheritedNotifier<_ResetNotifier> {
   widgets/focus_scope.dart:class _FocusMarker extends InheritedNotifier {
widgets/scroll_configuration.dart:class ScrollConfiguration extends InheritedWidget {
widgets/basic.dart:class Directionality extends _UbiquitousInheritedWidget {
widgets/basic.dart:class DefaultAssetBundle extends InheritedWidget {
widgets/actions.dart:class _ActionsMarker extends InheritedWidget {
widgets/restoration.dart:class UnmanagedRestorationScope extends InheritedWidget {
widgets/routes.dart:class _ModalScopeStatus extends InheritedWidget {
// widgets/inherited_model.dart:abstract class InheritedModel extends InheritedWidget {
widgets/shared_app_data.dart:class _SharedAppModel extends InheritedModel {
widgets/focus_traversal.dart:class FocusTraversalOrder extends InheritedWidget {
widgets/focus_traversal.dart:class _FocusTraversalGroupMarker extends InheritedWidget {
cupertino/theme.dart:class _InheritedCupertinoTheme extends InheritedWidget {
widgets/ticker_provider.dart:class _EffectiveTickerMode extends InheritedWidget {
widgets/form.dart:class _FormScope extends InheritedWidget {
material/button_bar_theme.dart:class ButtonBarTheme extends InheritedWidget {
material/menu_anchor.dart:class _MenuAnchorMarker extends InheritedWidget {
material/ink_well.dart:class _ParentInkResponseProvider extends InheritedWidget {
material/date_picker.dart:class _FocusedDate extends InheritedWidget {
material/tab_controller.dart:class _TabControllerScope extends InheritedWidget {
material/tooltip_visibility.dart:class _TooltipVisibilityScope extends InheritedWidget {
material/radio_theme.dart:class RadioTheme extends InheritedWidget {
material/switch_theme.dart:class SwitchTheme extends InheritedWidget {
material/flexible_space_bar.dart:class FlexibleSpaceBarSettings extends InheritedWidget {
material/calendar_date_picker.dart:class _FocusedDate extends InheritedWidget {
material/bottom_navigation_bar_theme.dart:class BottomNavigationBarTheme extends InheritedWidget {
material/scaffold.dart:class _ScaffoldMessengerScope extends InheritedWidget {
material/scaffold.dart:class _ScaffoldScope extends InheritedWidget {
material/scrollbar_theme.dart:class ScrollbarTheme extends InheritedWidget {
material/navigation_bar.dart:class _NavigationDestinationInfo extends InheritedWidget {
material/checkbox_theme.dart:class CheckboxTheme extends InheritedWidget {
material/navigation_rail.dart:class _ExtendedNavigationRailAnimation extends InheritedWidget {
material/data_table_theme.dart:class DataTableTheme extends InheritedWidget {
material/dropdown.dart:class DropdownButtonHideUnderline extends InheritedWidget {

Most widgets in the list are just passing data / theme down the element tree and don't seem to be making assumptions about what surface the dependent widgets are on?

We should do an audit of all those InheritedWidgets to see if any of them need an inheritance boundary. If it's only MediaQuery that's special, we could work around this in other ways (e.g. by just injecting the right MediaQuery into the View/OverlayPortal to hide the original one).
For those widgets, that use one of the find* methods: We could add a parameter to the find* methods to specify whether they should search across inheritance boundaries. Maybe the inheritance boundary should be named LookupBoundary or something like that instead since its not limited to inheritance...

Regarding Navigator: it's not uncommon to have menu buttons that pop/push routes (like a "Edit this section" button that brings you to an "Edit" page). What makes them special? If the menu system has to always carry a navigator parameter around, not the worse thing but that can be a bit awkward (the widgets in that tree have to be aware of that so they use the local navigator variable instead of Navigator.of).
Also navigator uses findRootAncestorStateOfType: https://master-api.flutter.dev/flutter/widgets/Navigator/maybeOf.html

Sifted through the list, besides MediaQuery, _ParentInkResponseProvider could potentially prevent an InkResponse widget from invoking its onTap callback if a descendant within a different View is highlighted. Other than that nothing stood out to me (given that View isn't used to show completely different contents, like a different page route, in which case we may want to remove everything inherited from the parent).
findAncestorRenderObjectOfType references where the caller may not know what the render tree looks like:

InputDecorator.containerOf: looks fine?
Material.of : clearly assuming the widget tree has the same shape as the render tree.
TapRegionRegistry.of: RenderBox hit region culling may prevent this one from working correctly.

We'll also have to look at the other BuildContext.find* calls (e.g. findAncestorStateOfType and friends). It may be worthwhile to just create a spreadsheet with all of them so we can audit what should go through the boundary and what not.

Yeah that I did. findAncestorState is used as an alternative to InheritedWidget when:

when the caller is doing one-off things (like for Navigator/Overlay) and doesn't want to establish a dependency
when the caller needs access to the root state not the closest state of the specified type (Navigator/Overlay).
when the caller knows exactly what the widget tree looks like, and tries to find an internal state without having to introduce an inherited widget

I didn't find any references to findAncestorStateOfType or findRootAncestorStateOfType in the framework that is directly making assumptions that could be broken by View/OverlayPortal (it's walking the element tree to find a state so that should usually be fine), but I think it kinda depends on how the caller uses the retrieved state, developers can still call findRenderObject on it, and then try to invoke methods on it, like InkWell/InkResponse does.
I think for the most part the exceptions (TapRegionRegistry, _ParentInkResponseProvider, and probably MediaQuery) are just assuming descendant widgets will be painted within their paint bounds.

I have been thinking a little more about widgets that expose themselves to descendants so they can modify the ancestor's UI states. Examples of these are Navigator.of, Scaffold.of, and AnimatedList.of. At first I found it a little odd that a sub view could modify things in the main view, e.g. when a subview pushes a route, the route actually appears in the main view. I thought that that would actually be confusing. However, the more I think about it the more I am arriving at the conclusion that that's actually how it should be - and it would be confusing if we special case these widgets to hide them from sub views. After all, if you have a purely declarative app where all UI state is derived from a global app state object you'd also be able to modify the global app state from a subview and that could change what's shown in the main screen. If you don't want the subview to modify the Navigator of the main view, you'd have to wrap your subview in a new Navigator.
The only exception I see to this pattern is the Overlay, IMO. The overlay promises that you can draw something on top of yourself - a contract that cannot be fulfilled if you're in a subview and the overlay widget is in the main view.
The other large class of lookup widgets are those that want to expose some kind of data to their descendants. Examples here are the Themes or the Directionality widget. Here, it is also clear that these should be available from within a subview.
The annoying exception in this class is the MediaQuery widget, which I wish we could split, but for the reasons outlined in https://github.com/flutter/flutter/issues/115375 we can't. So, we will have to special-case this one a little bit by having Views inject a MediaQuery with the correct data to hide the data from the main view. However, for the purpose of this issue, a View is not a lookup boundary for the MediaQuery.
This leaves us with a random collection of widgets that need to respect views as boundaries. From a quick survey these seem to be:

Overlay (as discussed above)
Material.of: subview shouldn't be able to draw ink splashes into the main view
TapRegionRegistry: the registry in the main view cannot intercept pointer events in TapRegions of subviews
Hero widget: Hero._allHeroesFor shouldn't see Heros in subviews because it can't actually Hero those. Similarly, nested Heros could be allowed if there is a View in between them.

While I haven't looked at every single "lookup widget" closely, I believe there aren't many more. We have about 100 widgets in the framework that utilize the lookup APIs discussed in this issue. So, the widgets requiring views to be boundaries are in the minority. None of them are InheritedWidgets that utilize the depend*/get* methods on BuildContext. All of these utilize the find*/get* methods on BuildContext.
So, to begin with, we could just give all the find*/get* methods on BuildContext an optional parameter to indicate whether they should penetrate look up boundaries. The lookup boundaries could still be a marker mixin on Element that we add to the View and OverlayPortal element. The find*/get* method implementations would have to be extended to check every element they process for the marker interface and potentially abandon the walk early if the new parameter is set. As a downside, this extra check would make the walk slightly slower...
In the future, we could also extend the marker interface to override _updateInheritance if we decide to extend the lookup boundary concept to InheritedWidgets.

There is one oddity with the Navigator and TickerMode that I just want to document here: Say you have the following widget tree:
    Navigator
        |
      RouteA
    /       \
content   subview

Basically a route that displays some content in the main view and also has a subview. When you now push a new route B on top of route A, it will hide the content of route A in the main view, but the subview remains visible because let's say it is in a separate window. Since the Navigator considers route A to be completely covered, it turns off the TickerMode for the subtree routed at RouteA. This will also stop animations in the subview - even though that one is still visible.
Questions:

This makes me wonder if TickerMode also needs to respect lookup boundaries. Should the subview not see the TickerMode of the route and therefore continue animating even when the route is covered? TickerMode is an InheritedWidget, so this would require that the depend*/get* methods on BuildContext also require support for lookup boundaries (i.e. by overriding _updateInheritance in the boundary mixin).
If TickerMode respects lookup boundaries, are there any use cases where you'd want to turn off animations across subviews? How would you do that if TickerMode doesn't penetrate into the subviews? Do we need a TickerMode where you can configure whether its visible through lookup boundaries or not?


[FLINK-11975][table-planner-blink] Support to run a sql query : 'SELECT * FROM (VALUES (1, 2, 3)) T(a, b, c)'

What is the purpose of the change
Support to run a sql query : 'SELECT * FROM (VALUES (1, 2, 3)) T(a, b, c)'
Brief change log

add writeToSink, translateNodeDag in batch and stream tableEnv
introduce SinkRules for batch and stream
Introduce subclass of TableSink, including BaseUpsertStreamTableSink, BatchTableSink, CollectTableSink, DataStreamTableSink
StreamExecSink/BatchExecSink implements ExecNode interface
StramExecValues/BatchExecValues implements ExecNode interface, add CodeGen for Values.
add Itcase test infrastructure, add Itcase to run SELECT * FROM (VALUES (1, 2, 3)) T(a, b, c)' for batch and stream

Verifying this change
ITCase
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (JavaDocs)

@JingsongLi  thanks for your comments. All done, except one minor question, TableSink interfaces still in Scala instead of Java, could do it later with all sinks and sources.

@KurtYoung Thanks for your comments. All done, except two minor question:

BatchCompatibleStreamTableSink could be introduced later when we really need it?
override def getDamBehavior: DamBehavior = DamBehavior.PIPELINED I don't understand your comment here.

+1 LGTM


caddy: withPlugins better error messages for untagged plugins

Things done

Context:
https://github.com/NixOS/nixpkgs/pull/358586#issuecomment-2564012300
https://github.com/NixOS/nixpkgs/pull/358586#issuecomment-2564016652
Continuation of #358586, better error messages for untagged plugins
When using pkgs.caddy.withPlugins, if a plugin is untagged upstream, users usually provide a commit SHA to replace to the tag/version. This will result in installCheckPhase failure as caddy build-info output uses pseudo-version number (e.g. v0.0.0-20170915032832-14c0d48ead0c).
Example error:
$ nom-build --expr 'with import ./. { }; caddy.withPlugins { plugins = [<EMAIL_ADDRESS>"github.com/caddy-dns/cloudflare@89f16b99c18e" "github.com/mholt/caddy-webdav@42168ba04c9dc2cd228ab8c453dbab27654e52e6" ]; hash = "sha256-wqXSd1Ep9TVpQi570TTb96LwzNYvWL5EBJXMJfYWCAk="; }'
...
> Running phase: installCheckPhase
> Plugins not found: github.com/caddy-dns/cloudflare@89f16b99c18e
> Plugins not found: github.com/mholt/caddy-webdav@42168ba04c9dc2cd228ab8c453dbab27654e52e6
...

The error output will change to the following:
$ nom-build --expr 'with import ./. { }; caddy.withPlugins { plugins = [<EMAIL_ADDRESS>"github.com/caddy-dns/cloudflare@89f16b99c18e" "github.com/mholt/caddy-webdav@42168ba04c9dc2cd228ab8c453dbab27654e52e6" ]; hash = "sha256-wqXSd1Ep9TVpQi570TTb96LwzNYvWL5EBJXMJfYWCAk="; }'
...
> Running phase: installCheckPhase
> Plugin "github.com/caddy-dns/cloudflare" have incorrect tag:
>   specified: "github.com/caddy-dns/cloudflare@89f16b99c18e"
>   got<EMAIL_ADDRESS>> Plugin "github.com/mholt/caddy-webdav" have incorrect tag:
>   specified: "github.com/mholt/caddy-webdav@42168ba04c9dc2cd228ab8c453dbab27654e52e6"
>   got<EMAIL_ADDRESS>...

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/5021


Added jitpack repo for radius

+1 I hope there won't any side effect on the build

I Fixed conflicts. Cant see any other changes that would ripple through the build.


Add react for the front end

[x] Add React
[x] Add Storybook
[x] Add MSW for storybook API mocking
[x] Add Home page
[x] Add config page
[x] Add logs page
[ ] Add dialog/flash component for successful actions
[ ] Add a css-in-js library (styled components? emotion?)
[ ] Add API endpoints for all of the app data
[ ] Build front end on deployment
[ ] Make sure the front end doesn't get cached on browsers

These issues will be easier once this is done: #21 #20 #5 #1

I'm trying to figure out how we want to build the front end.
Since the Piku server might not have node, we might want to build it before we push to the server. One solution would be to keep the built files committed, but I'm not a fan of that.
What do you think @rwnx ?

A) build on development
Because the piku server deploy mechanism uses git push, we can only send committed files, so if we're doing a "build before deployment" I think that may be our only option.
B) build on deployment
I'm worried about building a CRA app on a resource-constrained env. there's also a huge amount of dependencies for a cra build (eek)
I think A is the best solution but i totally agree it's a crappy developer experience.
We could improve the developer quality of life by:

putting some check in the CI/test to make sure that the committed files are up to date (i.e we won't build a release/pass tests if someone forgot to run "npm run build" and commit the result)


proxy js file failed

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via ASRC(Alibaba Security Response Center) where the issue will be triaged appropriately.

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description
the problem is, when i trying higress as our team new ingress gateway,  it proxy some of the Nginx's service js file return with empty file which size is 0
Ⅱ. Describe what happened

gateway log as above, and chrome console report

which refer to the request for js resource doesn't response with valid body, because of body_sent log is 0
Ⅲ. Describe what you expected to happen
below pic is directly request throught svc nodeport, it response greatly and with no console error

Ⅳ. How to reproduce it (as minimally and precisely as possible)

xxx
xxx
xxx

Ⅴ. Anything else we need to know?
Ⅵ. Environment:

Higress version:  1.3.3
OS : Kubernetes v1.23.8
Others:

Could you provide corresponding route configurations? Do you have any WASM plugin eanbled for this route?

throught Higress CURL Request:

Could you provide corresponding route configurations? Do you have any WASM plugin eanbled for this route?

Sure,

ROute configurtion are belows

svc  for nodePort

No WASM Plugin enabled in this route config

Did you use nginx as the upstream ?
cc https://github.com/xhlwill/blog/issues/17#issuecomment-848631589

Did you use nginx as the upstream ?
cc xhlwill/blog#17 (comment)

yes, the upstream svc is a nginx

Did you use nginx as the upstream ?
cc xhlwill/blog#17 (comment)

i have check the nginx log, but it seem to be normal in nginx part

throught Higress CURL Request: curl 'http://log.gitee.work/assets/login/js/chunk-vendors.705a060b.js' -H 'Accept: /' -H 'Accept-Language: zh-CN,zh;q=0.9,en;q=0.8' -H 'Cache-Control: no-cache' -H 'Connection: keep-alive' -H 'Pragma: no-cache' -H 'Referer: http://log.gitee.work/login' -H 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36' --compressed --insecure
throught nodeport CURL request: curl 'http://log.gitee.work:20571/assets/login/js/chunk-vendors.705a060b.js' -H 'Accept: /' -H 'Accept-Language: zh-CN,zh;q=0.9,en;q=0.8' -H 'Cache-Control: no-cache' -H 'Connection: keep-alive' -H 'Pragma: no-cache' -H 'Referer: http://log.gitee.work:20571/login' -H 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36' --compressed --insecure

I found the upstream host is <IP_ADDRESS>:8080 in your log.    Try this one：
curl 'http://<IP_ADDRESS>:8080/assets/login/js/chunk-vendors.705a060b.js' -H 'Host: log.gitee.work' -H 'Accept: /' -H 'Accept-Language: zh-CN,zh;q=0.9,en;q=0.8' -H 'Cache-Control: no-cache' -H 'Connection: keep-alive' -H 'Pragma: no-cache' -H 'Referer: http://log.gitee.work:20571/login' -H 'User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36' --compressed --insecure

in kubernete cluster ,curl response is normal

@johnlanni  so i think it 's not the problem of nginx, i have check the pod , pod ip is  <IP_ADDRESS>, direct request can  get normal response ,and even throught kubernetes nodeport svc also get normal response body that as well

@ray1888 Please run the tcpdump in higress-gateway's pod (maybe you should run this command on the node, or switch the pod user to root):
tcpdump -i any host <IP_ADDRESS> and port 8080 -A
Then access the js from browser, you will see the whole request headers in the  output of tcpdump.
Then try to curl <IP_ADDRESS>:8080 with these request headers, and find that which header will let the nginx return 200 but without response body.

@ray1888 Please run the tcpdump in higress-gateway's pod (maybe you should run this command on the node, or switch the pod user to root):
tcpdump -i any host <IP_ADDRESS> and port 8080 -A
Then access the js from browser, you will see the whole request headers in the output of tcpdump.
Then try to curl <IP_ADDRESS>:8080 with these request headers, and find that which header will let the nginx return 200 but without response body.

can i do the tcpdump at the gateway node? or only can do on the pod  working node?

@johnlanni  can this screenshot ok? or need i post with pcap file?

@ray1888 Please run the tcpdump in higress-gateway's pod (maybe you should run this command on the node, or switch the pod user to root):
tcpdump -i any host <IP_ADDRESS> and port 8080 -A
Then access the js from browser, you will see the whole request headers in the output of tcpdump.
Then try to curl <IP_ADDRESS>:8080 with these request headers, and find that which header will let the nginx return 200 but without response body.

i had tried to delete header one by one, and none of them effect to the response with curl to <IP_ADDRESS>:8080 as dest

@johnlanni  And i also try to curl in the higress gateway to dest svc js file, it also ok

but it still can't get from throught the higress to user browser response

@johnlanni can this screenshot ok? or need i post with pcap file?

Did you use curl try the headers of the output?
From the output of tcpdump, you can also find that nginx did not return the response body, which can prove that it was caused by nginx and not higress that discarded the response body.

@johnlanni can this screenshot ok? or need i post with pcap file?

Did you use curl try the headers of the output?
From the output of tcpdump, you can also find that nginx did not return the response body, which can prove that it was caused by nginx and not higress that discarded the response body.

yes, i have try that with curl to nginx , delete header one by one doesn't effect the response.

@johnlanni  i have some new clue, i do curl from kubernetes node to hostname , the curl result are below

i don't understand why it close the connection before the data response?

@ray1888 As you can see from the tcpdump output above, nginx did not return the response body. I think we need to find out the reason first.

@ray1888 As you can see from the tcpdump output above, nginx did not return the response body. I think we need to find out the reason first.

i directly curl from node will not close connectin before data tranfer finish. will it be request time over higress default timeout ?

@ray1888 As you can see from the tcpdump output above, nginx did not return the response body. I think we need to find

@ray1888 As you can see from the tcpdump output above, nginx did not return the response body. I think we need to find out the reason first.

i directly curl from node will not close connectin before data tranfer finish. from above ,it prove that , it not nginx problem?
will it be request time over higress default timeout ?@johnlanni

@ray1888 The response code is 200, and if it times out, the response code is 504.

@ray1888 The response code is 200, and if it times out, the response code is 504.

can it remote on dingding to assist to help

@ray1888 可以的，你可以在钉钉社区交流群找到我，昵称是澄潭

@johnlanni 问了一下公司策略，不能远程访问，但是我把tcpdump 命令输出到文件里面，然后给导出来了。
response.zip
里面有较多的ReAck 和 Dup ack，而且比较奇怪的是，这里我理解应该代理的是7层的协议？但是tcpdump 出来的都只有4层的协议，到目标Pod 8080端口的那些请求和返回

网关 Pod 和 Nginx 之间都经过了什么额外的节点呢？

网关 Pod 和 Nginx 之间都经过了什么额外的节点呢？

网关Pod 在Node2上， Node1 为对应域名解析的节点

but i also try apisix for proxy with same config, they didn't show the same issue

@ray1888 我看了抓包有大量的TCP重传，包括建立连接时就出现了，这个问题难道只出现在js请求上？其他请求不受影响？，这是higress往后端发送的请求，你在higress gateway的pod里用curl命令测试一下看：
GET /assets/login/js/chunk-ff542364.2fa1ed4b.js HTTP/1.1
host: log.gitee.work
accept-encoding: deflate, gzip
accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7
accept-language: zh-CN,zh;q=0.9,en;q=0.8
cache-control: no-cache
pragma: no-cache
purpose: prefetch
referer: http://log.gitee.work/login
user-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
x-forwarded-for: <IP_ADDRESS>
x-forwarded-proto: http
x-envoy-internal: true
x-request-id: 99ef8214-31bc-40a4-8062-802aa1051eef
x-envoy-decorator-operation: gitee-one-front.gitee.svc.cluster.local:80/assets/*
x-envoy-expected-rq-timeout-ms: 3000
x-envoy-attempt-count: 1
x-b3-traceid: 8ee55d9ddd763fc3b66f99e52a34a6d2
x-b3-spanid: b66f99e52a34a6d2
x-b3-sampled: 0
req-start-time:<PHONE_NUMBER>465
original-host: log.gitee.work

是的，只有JS有影响，其他的包括API转发都没问题

@ray1888 higress不会识别特定响应做处理，从抓包看，higress和后端之间从建连开始就一直有丢包重传，以及tcp包乱序等问题，跟你们的网络环境关系比较大（这个js响应比较大，可能触发了网络的问题），你可以尝试在你本地笔记本用kind部署一套higress，把原样的响应返回测试下，应该不会复现这个问题。

看了下这个不是正常的重传，SYN包没有等RTO（默认最小200毫秒）时间就重传了，只等了0.02毫秒，后面的数据包也是类似的情况，不是太久没收到ACK后才重传，而是一个包直接在网络上传2次。

你可以再抓一个浏览器和higress之间的包给我看下么，这个错误也很奇怪：
net::ERR_INCOMPLETE_CHUNKED_ENCODING

你可以再抓一个浏览器和higress之间的包给我看下么，这个错误也很奇怪： net::ERR_INCOMPLETE_CHUNKED_ENCODING

我先试试。晚点我这边再部署一个Kind，然后通过Nodeport访问JS那个服务试试

你可以再抓一个浏览器和higress之间的包给我看下么，这个错误也很奇怪： net::ERR_INCOMPLETE_CHUNKED_ENCODING

browser.zip

 看了下这个不是正常的重传，SYN包没有等RTO（默认最小200毫秒）时间就重传了，只等了0.02毫秒，后面的数据包也是类似的情况，不是太久没收到ACK后才重传，而是一个包直接在网络上传2次。

这里部分我刚刚看了一下啊，calico这边的RTO很小。tcpdump 出来的pod 是calico 上面的 pod ip，不确定是否会有影响呢？

是不是开启了WAF插件或者其他会buffer响应body的插件，最近有个用户遇到类似问题，是WAF插件导致的。
可以调高全局参数的 downstream.connectionBufferLimits 解决
WAF 插件会缓存请求 Body 和响应 Body，如果 Body 比全局配置中的 downstream.connectionBufferLimits 配置要大，会导致请求或响应异常
downstream.connectionBufferLimits 也不建议配置过大，可能导致网络传输慢时，网关内存占用过高


In My Library, replace search action with refresh (to check for latest chapters)

library isn't saved between app instances

Are we not enabling a search within your library? My batoto library has like 100+ manga in it...

^power user right here
Sure, we'll probably have search.

i'll get to this if i have time, shouldn't be too hard since all the pieces are there

Hm, I'm still not sure I understand the scope or purpose of this feature. Is it like: User hits refresh button -> immediately trigger a new chapter check over their library, and tell them if any of their manga has had an update that they have not read?

Hm.I'm thinking it might not be necessary. Do you have a case for taking it
out? Maybe the user opts out from automatic checking, but then it could
just check for new updates when opening the app.... Thoughts?
On Sat, Jan 9, 2016, 8:41 PM Austin Chen<EMAIL_ADDRESS>wrote:

Hm, I'm still not sure I understand the scope or purpose of this feature.
Is it like: User hits refresh button -> immediately trigger a new chapter
check over their library, and tell them if any of their manga has had an
update that they have not read?
—
Reply to this email directly or view it on GitHub
https://github.com/williamxu/MangoReader/issues/11#issuecomment-170314027
.


feat(lvm-localpv): make the installation of snapshot.storage.k8s.io CRDs optional

Why is this PR required? What issue does it fix?:
change for #203
What this PR does?:
This PR will enable the possibility to disable the installation of the volumesnapshot CRDs.
To prevent any regressions, the default has been set to true.
These resources are usually maintained and managed by the underlying kubernetes distribution. In case of OpenShift, it will automatically revert back the modifications made by this helmchart. This could be problematic if you use ArgoCD and have it on autosync.
Checklist:

[x] Fixes #203
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

this is infact impact me with argocd could this get merged with a small release

Closing this PR. This commit has been included in PR https://github.com/openebs/lvm-localpv/pull/243.


Create Navbar for the home page

Description
Create a navbar component for the home page to navigate between pages

!assign me @neokd

Done Bhai

@theavitw any updates on the navbar?

@neokd
sorry for delay was busy for some time
can you please elaborate more what kind of navbar you want.
I saw it already exist.

Ok I understood this issue
Basically setting up the image size as per screen
ok you can assign to me.

There should be proper Navbar in the new website which is there in the website folder . The link is the old website. It should follow the current color scheme and have proper nav links for now just add the existing navlinks in future we'll expand on the same


Update trunk with upstream changes via GitHub

Closing in favor of https://github.com/wordpress-mobile/react-native-reanimated/pull/12.


Weird QR-based requests on rogerth.at

Looks like the requests are coming from Facebook. So maybe the recommend feature in ios/android does something wrong?
/M/be-anzegem://q/s/h9cvIHLacLLZFsp8VhMqwhztj_ZJ6m0wk6m6ON6v5n8-/1
/M/be-anzegem://q/s/YB9mzrxis7pprL.w9dV8BRSeWw5cwN8zN3.LmGikwkY-/1

Tested android and iOS, both worked fine (Latest version)

I guess it's related to https://github.com/rogerthat-platform/rogerthat-backend/blob/master/src/rogerthat/pages/service_interact.py#L135 and https://github.com/rogerthat-platform/rogerthat-backend/blob/master/src/rogerthat/pages/service_interact_mobile.html#L29

No that would mean they viewed the url correctly via a desktop, and the main app_id of that service is rogerthat.
We have incorrect urls from anzegem, halen, veurne, herk-de-stad, staden in the last 2 days

Another one, with Whatsapp??

The one from whatsapp is not a valid url

Issue migrated to our-city-app/mobicage-backend#67


Hi, the element-plus has released a new version

and, there are some Breaking changes：
https://github.com/element-plus/element-plus/discussions/3020
and, maybe this resovler need change:
https://github.com/antfu/vite-plugin-components/blob/main/src/resolvers/element-plus.ts#L28

Seems like they have updated vite-plugin-element-plus mentioned in their doc to adopt the new change.


Add tests for do expressions

We currently have not a single test for doExpressions. We should add some tests to babylon.
Can take the examples from the official gist.
Tests should go into test/fixtures/experimental/do-expressions/
https://gist.github.com/dherman/1c97dfb25179fa34a41b5fff040f9879

Let me tackle this issue 🖐

Closed by #688.


Use pnpm

The workspaces key only works for npm, not pnpm or yarn. Vite don't care about that as well.

Thanks for raising this 🙏
I'm a big fan of pnpm, but I don't think it adds much to a trivial demo app like this.
And seeing as this is mostly intended to be an instructional example, I'd rather not add the complication of a package manager that less people are familiar with.

This adds pnpm support. I think it should work with yarn/npm as well.

$ npm install
npm ERR! code EUNSUPPORTEDPROTOCOL
npm ERR! Unsupported URL Type "link:": link:packages/js-exception

Can you try changing link: to file:?

file: works for npm	but not pnpm.
But actually the current link: approach doesn't work properly for pnpm either.
pnpm install passes fine, but then pnpm run build fails with:
[vite]: Rollup failed to resolve import "snabbdom" from ".ditto/packages/vdom/ditto-src/App.js".

I'm not entirely clear why that's happening, but I suspect this requires a workspace setup rather than just linked dependencies?
The next issue that's likely to come up is that generated packages/*/package.json files look like...
{
  "name": "vdom",
  "type": "module",
  "dependencies": {
    "js-task": "*",
    "js-unknown": "*",
    "snabbdom": "^3.5.1",
    "std": "*"
  }
}

Which also isn't pnpm compatible. So I suspect package manager will have to be added as a ditto configuration option so we can generate the appropriate format.


chore: unify docs

Changed Parameter to Parameters, to match the rest of the docs.  Also I've put all (missing) examples in a yaml container.

(closes https://github.com/mayope/keycloakmigration/issues/16)

Hey @MrDeerly  I didn't expect anyone to fix this for me and it was just a reminder :D But thanks a lot regardless :)

Released with version: https://github.com/mayope/keycloakmigration/releases/tag/0.2.33


Allow exec command to specify a different console

Instead of using the console related to the container, a new process run on an existing container can have its own console.

Coverage decreased (-0.09%) to 30.893% when pulling bcb572a42fce01783ed9b97695e75b0ada12525d on sboeuf/exec_diff_console into 69dce6fe43c6dac37b222a9bb95fad22b34e9cda on master.

Coverage decreased (-0.09%) to 30.893% when pulling 538a6cb9d0889fded427c7abde34ff19402b8f5e on sboeuf/exec_diff_console into 69dce6fe43c6dac37b222a9bb95fad22b34e9cda on master.

lgtm

@dlespiau sorry I should have mentioned to wait for virtcontainers patches to be merged first... In case of vendoring, please check that we actually have merged this into virtcontainers master, before to merge in the runtime.

or mark the PR as do-not-merge :)

Yeah I know I forgot to do that, shame on me!


feat: Auto register Third party devices on Dashboard #NEBD-2

automatically register third party devices on startup
keep the registration state saved in sqlite db
add buys loop env var that prevents diag startup for debugging

Issue

Link: https://nebraltd.atlassian.net/browse/NEBD-2
Summary:

How

Screenshots

References

Checklist

[ ] Tests added
[ ] Cleaned up commit history (rebase!)
[ ] Documentation added
[ ] Thought about variable and method names

Quick question - what does it display if the miner is already claimed in dashboard but the free trial has expired and they haven't paid?
@KevinWassermann94 maybe saying about claiming the free trial doesn't make sense in this case I'm not sure


Reduce complexity of DocumentService.searchRows

DocumentService.searchRows is flagged by Codacity as a very long method. In fact the method's body contains complex logic. It could be worth refactoring it to reduce complexity.
Side note: This issue came up in #531, which re-enables some Docs API unit tests. Still, the searchRows method is mocked by those tests, so in effect this method itself is not unit tested.

I think this ca be closed after #1136, the method is removed there.

Agreed. Closing :+1:


MUSIC PLAYER

Project title
MUSIC PLAYER
Web stack
HTML ,CSS ,JAVASCRIPT
Screenshot(mandatory)

Additional Context(mandatory)
application which can run on mobile as well as on laptop.
Are you contributing under any open-source program ?
codepeak 23

@GAGANRAGHAV this project is already present in or repo.


Importing fails webpack build

Hey Brian,
Thanks for putting your time into this polyfill. Unlike many of the options out there, this project is straightforward and easy to use.
When I was integrating it into my build, via webpack, I am getting a Reference error window is not defined error when bundling. This is contrary to the README that says I can use it with webpack 😢 .
Is it working for you?

Thank you for your kind words!
It is working for me; all of my own projects use Webpack at the moment.
Firstly, make sure you're on the latest version (check the project's NPM page) and that all of your bundles are using it. Unfortunately, a broken build was sent out a few publishes ago, so you might have gotten snagged by it.
Once that is confirmed, if it still isn't working, please paste or screenshot the error log in the dev console, as well as the block of code it links to.
Cheers!

I went to create a test case repo and realized it was an issue with some server rendering my project was doing. A plain webpack bundling succeeded. Ooops! Thanks for lending some advice.

Glad it all worked out. Thanks for the update.


custom config supported

custom config supported
guava removed

This change is

Coverage increased (+0.03%) to 57.803% when pulling f12b6e9f6add6293a6c6d70c3b407d80f0671b36 on custom-config into 1d806074db53622e9cf47c874cdf0c435df52f4e on master.


Refactor DB access methods

Swaps out the call to DB::instance() in favor of providing both DB::mapper() and DB::sql(). This allows you to use the SQL builder directly for queries that don't quite fit into the ORM's map of things.

Rebasing onto current master. Will force-push when completed.

Rebased for current master. @pgicking or @severity code review and merge please?

Looked through it, tested the routes more robustly than i did with my error catching branch :), merging


Add missing methods

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-communication-jobrouter

Many Update methods are still missing the without Response methods.

Many Update methods are still missing the without Response methods.

Whichs ones @williamzhao87 ?

Many Update methods are still missing the without Response methods.

Which ones @williamzhao87 ?
reclassifyJob, updateJob, updateWorker

Is this method needed?

Is this method needed?

These looks like convenience methods since they take the XXOptions class as parameter.  Shouldn't convenience methods return the entity rather than BinaryData?  Same comment for all convenience methods.

Some comments still need to be addressed

Addressed them. Let me know if there are any more missing. Thank you.

These looks like convenience methods since they take the XXOptions class as parameter. Shouldn't convenience methods return the entity rather than BinaryData? Same comment for all convenience methods.

This is still not addressed

Many Update methods are still missing the without Response methods.

Which ones @williamzhao87 ?

reclassifyJob, updateJob, updateWorker

This is still unaddressed

Should the XXWithResponse methods also take RequestOptions?

Should the XXWithResponse methods also take RequestOptions?

I believe convenience methods do not take RequestOptions. RequestOptions is similar to providing options such as CreateJobOptions. For example protocol methods take RequestOptions in request and return BinaryData.

Okay then this method should probably also not take RequestOptions:
public Mono<RouterWorker> createWorker(CreateWorkerOptions createWorkerOptions, RequestOptions requestOptions)

Yes, updated it.

Looks good to me, once the specs are updated


Update Wikidata-Toolkit to 0.13.1

Fixes #4593 and maybe #4577?

Uploads seem to stall at 0% with this upgrade, that is not exactly better!

Actually no it is fine!

Working like a well-oiled machine now on this new batch I just did... thank youuuuu! 🚴♀ 🚀


Gather creates a subdirectory with cluster name for gather logs

this commit creates a subdirectory name derived from kubeconfig
cluster.Name for gather logs to be stored in separate directories
under the root timestamped directory

Signed-off-by: Brent Salisbury<EMAIL_ADDRESS>

system test is failing because https://github.com/submariner-io/subctl/blob/393ddf864a1113d95f4dd242e475ab82e341fc26/scripts/test/system.sh#L46 needs to be changed too to reflect the actual cluster name "cluster1" and not "broker".

@skitt I believe this is the parent issue? I think we better track the issue in the board and not the PR.


Encountering NotImplementedException in .NET 5 + SSO + AssumeRole scenarios

Description

In my organization, we have begun the process of adopting SSO logins for our developer accounts. With or without SSO, as a developer I have an AWS Profile set up with the account I log in with which must then assume a role in another account in order to access the application's resources.
In our solution at large, we have processes which use .NET Framework, and some which use .NET 5. We have run into a problem related to the assuming of the application role with some of our existing code when we try to run it on .NET 5 (though I presume, any version of .NET Core would be the same) once we change to an SSO-enabled login account.
The code runs fine on .NET Framework. But on .NET 5, we're encountering a NotImplementedException in the AssumeRoleAWSCredentials.GenerateNewCredentials() code path.
Sample code
The code that follows isn't lifted exactly from our code, but distills the problem the are having down to a simple form. This sample uses C# 9 so that I can use top-level statements to eliminate the usual boilerplate of Main and such.
using System;
using Amazon.SimpleSystemsManagement;
using Amazon.SimpleSystemsManagement.Model;

IAmazonSimpleSystemsManagement client = new AmazonSimpleSystemsManagementClient();
var result = await client.GetParametersByPathAsync(
   new GetParametersByPathRequest
   {
       Path = "/qap/client/test",
       Recursive = true
   });

foreach (var item in result.Parameters)
{
   Console.WriteLine($"{item.Name}");
}

And here's a minimal csproj file for the NuGet references, etc.
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <LangVersion>latest</LangVersion>
    <TargetFrameworks>net472;net5.0</TargetFrameworks>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="AWSSDK.Extensions.NETCore.Setup" Version="3.7.1" />
    <PackageReference Include="AWSSDK.SimpleSystemsManagement" Version="<IP_ADDRESS>" />
    <PackageReference Include="AWSSDK.SecurityToken" Version="<IP_ADDRESS>" />
    <PackageReference Include="AWSSDK.SSO" Version="<IP_ADDRESS>" />
    <PackageReference Include="AWSSDK.SSOOIDC" Version="<IP_ADDRESS>" />
  </ItemGroup>

</Project>

Reproduction Steps

Configure ~/.aws/config for the SSO login. I've included what mine basically looks like below under Environment.
The code assumes we have the AWS_PROFILE set to the desired profile. In this example, "dev".
Use the AWS CLI to login:  aws sso login --profile dev
Build and run the sample application. When I run the .NET Framework version, it runs fine and lists the paths of the SSM parameters, as expected. It fails on .NET 5.

Logs

When run on .NET 5, the result is a Amazon.Runtime.AmazonClientException with an InnerException of System.NotImplementedException.  The exception details follow, though I've scrubbed the actual account ID and cut out a lot of the unimportant async-related stack frames.
Amazon.Runtime.AmazonClientException
  HResult=0x80131500
  Message=Error calling AssumeRole for role arn:aws:iam::<APPLICATION_ACCOUNT_ID>:role/OrganizationAccountAccessRole-Developer
  Source=AWSSDK.SecurityToken
  StackTrace:
   at Amazon.SecurityToken.AmazonSecurityTokenServiceClient.Amazon.Runtime.SharedInterfaces.ICoreAmazonSTS.CredentialsFromAssumeRoleAuthentication(String roleArn, String roleSessionName, AssumeRoleAWSCredentialsOptions options)
   at Amazon.Runtime.AssumeRoleAWSCredentials.GenerateNewCredentials()
   at Amazon.Runtime.RefreshingAWSCredentials.<GenerateNewCredentialsAsync>b__16_0()
   at System.Threading.Tasks.Task`1.InnerInvoke() in /_/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Future.cs:line 497
   at System.Threading.Tasks.Task.<>c.<.cctor>b__277_0(Object obj) in /_/src/libraries/System.Private.CoreLib/src/System/Threading/Tasks/Task.cs:line 2359
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state) in /_/src/libraries/System.Private.CoreLib/src/System/Threading/ExecutionContext.cs:line 274

   ---- removed a lot more async goop ----

   at <Program>$.<<Main>$>d__0.MoveNext() in W:\Samples\sso-assume-role-sample\Program.cs:line 6
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/ExceptionServices/ExceptionDispatchInfo.cs:line 56
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 173
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 150
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult() in /_/src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/TaskAwaiter.cs:line 105
   at <Program>$.<Main>(String[] args)

  This exception was originally thrown at this call stack:
    Amazon.Runtime.RefreshingAWSCredentials.GenerateNewCredentials()
    Amazon.Runtime.RefreshingAWSCredentials.GetCredentials()
    Amazon.Runtime.Internal.CredentialsRetriever.PreInvoke(Amazon.Runtime.IExecutionContext)
    Amazon.Runtime.Internal.CredentialsRetriever.InvokeSync(Amazon.Runtime.IExecutionContext)
    Amazon.Runtime.Internal.PipelineHandler.InvokeSync(Amazon.Runtime.IExecutionContext)
    Amazon.Runtime.Internal.RetryHandler.InvokeSync(Amazon.Runtime.IExecutionContext)
    Amazon.Runtime.Internal.PipelineHandler.InvokeSync(Amazon.Runtime.IExecutionContext)
    Amazon.Runtime.Internal.CallbackHandler.InvokeSync(Amazon.Runtime.IExecutionContext)
    Amazon.Runtime.Internal.PipelineHandler.InvokeSync(Amazon.Runtime.IExecutionContext)
    Amazon.Runtime.Internal.EndpointResolver.InvokeSync(Amazon.Runtime.IExecutionContext)
    ...
    [Call Stack Truncated]

Inner Exception 1:
NotImplementedException: The method or operation is not implemented.

Environment

The sample code above assumes that the AWS CLI (version 2.2.27) profile (~/.aws/config) is appropriately configured. Mine is something like:

[profile default]
region = us-east-1
output = json
sso_start_url = <MY_ORGANIZATION_START_URL>
sso_account_id = <MY_PERSONAL_ACCOUNT_ID>
sso_region = us-east-1
sso_role_name = QAP-Developer-AssumeRole

[profile dev]
source_profile = default
role_arn = arn:aws:iam::<APPLICATION_ACCOUNT_ID>:role/OrganizationAccountAccessRole-Developer
region = us-east-1
output = json

The code sample assumes that the AWS_PROFILE environment variable is set to select the desired profile (dev in this case).
SDK Version: <IP_ADDRESS>
Package Version: See the CSPROJ sample above.
OS Info: Windows 10
Build Environment: Visual Studio 2019 / JetBrains Rider 2021.2
Targeted .NET Platform: Building with .NET SDK 5.0.302, currently running on .NET Runtime 5.0.8

Resolution

[x] :wave: I can/would-like-to implement a fix for this problem myself

I have done a bit of debugging of the issue using custom builds of the SDK libraries in question and setting Visual Studio to stop on NotImplementedExceptions.
Long story short, I ultimately found that I seemed to correct the problem (at least in this case) by making Async versions of two methods:

In sdk/src/Core/Amazon.Runtime/Credentials/AssumeRoleAWSCredentials.cs, add an async version of AssumeRoleAWSCredentials.GenerateNewCredentials(), and in order to support that ...
In sdk/src/Services/SecurityToken/Custom/AmazonSecurityTokenServiceClient.Extension.cs, add an async version of AmazonSecurityTokenServiceClient.CredentialsFromAssumeRoleAuthentication() (CredentialsFromAssumeRoleAuthenticationAsync) that the new AssumeRoleAWSCredentials.GenerateNewCredentialsAsync() can call.  (Also requires adding this method to the ICoreAmazonSTS interface.)

So, in the end, my experimentation led me to make a custom build with this "patch": https://github.com/mattdg/aws-sdk-net/commit/043b592e885911b2f454658b3b0fef82c975fb80.  If I build the sample with my patched DLLs, the .NET 5 version now works.
I look to anyone more experienced with the workings of the SDK to say whether there are any problems with this, if it's not sufficient, etc??

This is a :bug: bug-report

Hi @mattdg,
Good morning.
I'm able to get error The method or operation is not implemented. from AWS SDK for .NET  when targeting .NET 5.0. Could you please share the following:

Credentials file sample
SSO configuration, including permission for assuming a role

Also confirm if you executed aws sso login --profile dev or aws sso login --profile default since AWS CLI appears to require required SSO configuration values: sso_start_url, sso_region, sso_role_name, sso_account_id even when using source_profile.
Thanks,
Ashish

Hi Ashish,
Yes, there appears to be some insistency with the CLI SSO login command or at least they config file doesn't seem to work the way one might intuit...  but that's another problem.  :-)
To perform the login, I guess it's OK to use aws sso login --profile default.  In practice, I typically initiate the login from the AWS web console and not the command line.  At any rate, once I'm logged in using the CLI and the default profile, I'm able to run
aws sts get-caller-identity --profile dev
and I get back
{
"UserId": "AROAJGXTOKUNRLQO7JN7K:botocore-session-1628533158",
"Account": "<APPLICATION_ACCOUNT_ID>",
"Arn": "arn:aws:sts::<APPLICATION_ACCOUNT_ID>:assumed-role/OrganizationAccountAccessRole-Developer/botocore-session-1628533158"
}
Once switched over to SSO logins, I no longer have a ~/.aws/credentials file (our IT folks instructed us to remove / rename it).
As for "SSO configuration, including permission for assuming a role"... if you mean how the accounts are configured, I'm not sure I have access to that.  All I can say is that however we are configured it seems to be correct and I don't think that has actually changed since before the SSO logins were enabled. (Even before SSO, we were using the same scheme with the same accounts and roles... the personal ones and the "application" ones). Plus, I don't think the code is actually getting far enough for that to matter?

Yeah, I don't even have permission to even see the list of user accounts, or list my own roles. :-)
As it's been explained to me though, the SSO account (<MY_ACCOUNT_ID> above) is able to assume roles and not much else.  One of which in my case is to be able to assume the one specified by the ARN.  (Well, my account can actually assume three roles... the same OrganizationAccountAccessRole-Developer role that exists in 3 different accounts... one account for each deployment environment.)

Running into this debugging in VS using SSO when I try to get a presigned URL from S3. Currently I can work around this by calling this in advance:
var creds = Task.Run(() => awsCredentials.GetCredentialsAsync()).Result;
It seems like the relevant code for   SSOAWSCredentials.GenerateNewCredentials() is blocked out with #if BCL. If you call the Async version ahead of time (as above) it caches the relevant info and the non-async GetCredentials call succeeds.

@ashishdhingra
Hi Ashish,
We are having the same issue outline above. Has this issue been escalated and given an ETA on a deployed fix?

I'm working on a fix now.


[WIP] Add support for grpc-web.

Description
Related
https://github.com/pion/ion-sdk-js/pull/77
Reference issue
Fixes #...

Nice! Does this work with https://github.com/improbable-eng/grpc-web/tree/master/client/grpc-web?

Nice! Does this work with https://github.com/improbable-eng/grpc-web/tree/master/client/grpc-web?

Yes, it runs very well.
I am trying to connect the flutter web, ts, and flutter native using grpc/grpc-web.

i wonder if it would be simpler to just provide an envoy config

grpc-web does not provide bidirectional streaming, and grpc web proxy is
required to provide websocket transport. I don’t know if envoy can make
grpc-web support bidirectional streaming.
Tarrence van As<EMAIL_ADDRESS>于 2020年10月22日周四 10:12写道：

i wonder if it would be simpler to just provide an envoy config
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pion/ion-sfu/pull/244#issuecomment-714176388, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHJQ4T2AD5XFAOWKOAPR4DSL6IIBANCNFSM4S2A3LCA
.

i think envoy support bidirectional grpc

i wonder if it would be simpler to just provide an envoy config

Now the PR supports grpc/grpc-web to use the same port, so we don't need to add envoy proxy.

LGTM


New teVirtualMidi backend

teVirtualMidi allows for creating virtual midi ports on windows. It's the same driver used by the loopMidi tool; the reason for using this backend instead of just using loopMidi, is that it allows for creating "non-loopback" midi ports. Where the input and the output don't just echo each other. This is needed for my very specific use case of writing a python script that sits as a translator between host software and a midi device, if I just used a loopback port, when the software wrote to the device, it would see it's own messages echoed back, which caused problems.
For this to work requires loopMidi being installed to get the driver. But don't actually need to run loopMidi
https://www.tobias-erichsen.de/software/loopmidi.html

Nice!
Any reason for not using https://github.com/complynx/pytemidi?

I also forgot to mention that the SDK is not free software and can’t be linked to MIDO unless authorized by the author.

Because I didn't think to see if someone had already done this? lol oh well, at least I got some learning experience with ctypes
This doesn't link to or use the SDK in any way, doesn't require the SDK to be installed. Just requires that the end user has installed loopMidi themselves. It does reference function names in the DLL which are also in the SDK, but I think that's acceptable (I'm not a lawyer etc)


tox 4 support

one issue to untangle is --pip-compile wants to --pip-compile twice when it detects any opts change, should probably only pip-compile once per env, and let the recreate skip that step


KeyError manuscript_id when running README snippet

When running the README code with rejected-article-tracker==1.5.6 on Python 3.9 linux, I'm getting the following error:
>>> # Run match
>>> RejectedArticlesMatch(
...             articles=articles,
...             config=config,
...             email=email,
...             results=results
...         ).match()
Traceback (most recent call last):
  File "/home/dhimmel/miniconda3/envs/rejected-article-tracker/lib/python3.9/site-packages/pandas/core/indexes/base.py", line 3361, in get_loc
    return self._engine.get_loc(casted_key)
  File "pandas/_libs/index.pyx", line 76, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/index.pyx", line 108, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/hashtable_class_helper.pxi", line 5198, in pandas._libs.hashtable.PyObjectHashTable.get_item
  File "pandas/_libs/hashtable_class_helper.pxi", line 5206, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'manuscript_id'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/dhimmel/miniconda3/envs/rejected-article-tracker/lib/python3.9/site-packages/rejected_article_tracker/src/RejectedArticlesMatch.py", line 28, in __init__
    self.articles = FilteredArticles(articles=articles)
  File "/home/dhimmel/miniconda3/envs/rejected-article-tracker/lib/python3.9/site-packages/rejected_article_tracker/src/FilteredArticles.py", line 8, in __init__
    self.articles = [ArticleItem(a) for a in self.__filter(articles)]
  File "/home/dhimmel/miniconda3/envs/rejected-article-tracker/lib/python3.9/site-packages/rejected_article_tracker/src/FilteredArticles.py", line 21, in __filter
    df = df[df['manuscript_id'] != 'draft']
  File "/home/dhimmel/miniconda3/envs/rejected-article-tracker/lib/python3.9/site-packages/pandas/core/frame.py", line 3455, in __getitem__
    indexer = self.columns.get_loc(key)
  File "/home/dhimmel/miniconda3/envs/rejected-article-tracker/lib/python3.9/site-packages/pandas/core/indexes/base.py", line 3363, in get_loc
    raise KeyError(key) from err
KeyError: 'manuscript_id'

Any idea what is causing this?
part of https://github.com/openjournals/joss-reviews/issues/3348

Is it because the example article doesn't use the article format later in the REAMDE? It uses Manuscript ID instead of manuscript_id?

Ah, well spotted! I've corrected this now and run the examples from the readme.md file. All working.


MBEDTLS_X509_ALLOW_UNSUPPORTED_CRITICAL_EXTENSION docs should include warning

In config.h, several of the options contain a strong warning:
\warning Depending on your PKI use, disabling this can be a security risk!

However, MBEDTLS_X509_ALLOW_UNSUPPORTED_CRITICAL_EXTENSION does not come with this warning. I reckon it probably should.
One of my tests checks that certificate chains with violated X.509 nameConstraints are not allowed. (Note that I don't use nameConstraints, and I don't care if chains with satisfied nameConstraints validate or not, I just want to fail chains with violated constraints. This is partly a box-checking exercise on my part, since the PKIX RFC5280 has a "MUST" for nameConstraints.
So, I'm very happy with the mbedTLS default behaviour, which is to reject certificates entirely which contain (critical) nameConstraints. Would it be possible to add a warning to config.h for MBEDTLS_X509_ALLOW_UNSUPPORTED_CRITICAL_EXTENSION, indicating the consequences?

I agree, we'll add the warning. I'm actually surprised we don't have that warning already, thanks for noticing.


Validation for strings that have more than just white space.

ValidateNotNullOrEmpty is not sufficient in all cases
Built in function Test-Path will return $true when -Path is just white space.

Test-Path -Path '   '
Returns $true
Expect it to write-error since that is its what it does when given $null.

I need to validate that my strings are not just white space. Can likely to that with Regx.  Would be useful if it were built in.
Proposed technical implementation details (optional)
(-not [string]::IsNullOrWhiteSpace($_))

Would like to see a no null or white space validation feature.
[Parameter(Mandatory)]
[ValidateNotNullOrWhiteSpace()]
[string] $Path,
Such that my function fails to be called when $Path is just white space, $null, or empty string.

Rather than create what is essentially a duplicate attribute, why not just have a settable property on the existing attribute to also check for whitespace? For example:
[ValidateNotNullOrEmpty(RejectWhitespace)]

Note - the specific issue with Test-Path appears to be fixed in 6.2.0
PSCore (1:2) >  Test-Path -Path ' '
False

As far as checking for whitespace in an argument,, you could use the ValidatePattern attribute with something like [validatepattern("^[^ ]*$")].

Yeah, I fixed that one. It bothered me far too much. 😄
The only way to get Test-Path to throw now is to actually pass it a $null value.


Updates

No, but I thought we'd use it in its original size. Not sure why I went with 150px width in the first place, but it looks good bigger too.


Update grover tutorial equation

Summary
Details and comments
Fixes #1222

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.364%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2333

Relevant Lines:
5380

💛  - Coveralls

cc: @jhwatrous


Flutter logo is clipped during animation

Long press on the animation to trigger this.
@Hixie

Weird. Can you give more information about platform and so on? This doesn't happen in general last I checked...

It looks like I'm running inside the iOS Simulator.  I'm happy to repro in person for you if you need.

A dump of the render tree would be useful.

Closing this since this view doesn't exist in the gallery anymore.


Add unary operation specializations

Add specialized dispatch functions for neg, conj, adjoint, transpose, expm inv and project.
It's include all JaxArray -> JaxArray functions except logm, for which jax does not have and implementation yet.
Functions composed multiple jax operation are jitted, but I did not benchmark them to see if it's useful.
Tests for the methods  conj, adjoint, transpose are included.
This PR comes after #2, it reuse conftest.py.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

87 of 90 (96.67%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+6.4%) to 95.455%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/qutip_jax/binops.py
35
38
92.11%

Totals

Change from base Build<PHONE_NUMBER>:
6.4%

Covered Lines:
147

Relevant Lines:
154

💛  - Coveralls

Is this ready to be merged?


hackathon_app looker updates

switch to using a group per hackathon
** don't assign Hackathon role directly - group gets it
bulk enable looker accounts given a list of hackathons

@josephaxisa just an fyi on more work I'm doing on the hackathon_app for you to review after the fact :-)


Simple fixes

I fix .gitignore for clean work with Git.
And I add small left padding for text's rects (look fields with and without borders, with borders and without padding this is not beauty).
And I replace clear button at center by height. This is more beauty too.
Good luck! Thank you!

@akhatmullin thanks, but I'd prefer to keep to the standard UITextField implementation, rather than introduce inherent padding that not all users may want. I would also suggest a global gitignore file: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

@jverdi thank you for this info


fix: typo in Engine, theese > these

Typo:
Ponder the meaning in theese lines:

to
Ponder the meaning in these lines:

Thanks for the correction @chrishutchinson.
I did not see your pull-request beforehand and corrected the typo myself within #165.
It is now fixed 🥳


duplicate alumni tab in sidebar

In the side menu bar the last two sections are the same, which is redundant.

The 4th button might be for the #56 events page, as the section is up on https://www.iiitdmj.ac.in/webix.iiitdmj.ac.in/#/events, but not visible in the sidebar.


Onboarding - make it better

Account page
1. When selecting account to change to “for your new EUR account”
2. When opening the account: “At least one payment pointer”
3. “Your balance is currently $0” should be “your balance is currently €0”
4. “To make your first transaction please add play money”

Transfer page
1. On the account onboarding, the icons should match or not be there at all
2. Transfer send page: explain/onboard all of the input fields on the screen
4. In the send/receive: explain “send” first in the onboarding text
5. Reviewing payment details, remove the “... for now” sentence.
6. Add an onboarding to the Request flow page
7. Check if you can do a skip on Send and Request onboarding steps

I don't know if this will help, but as I was going through the on-boarding flow I took screenshots and potentially broke the flow:
https://docs.google.com/document/d/1XBumEy2fbA0EOMG7r4I4KlUfU91m7joI4m_iMuU0wBU/edit#bookmark=id.qufyyshr54u2

I don't know if this will help, but as I was going through the on-boarding flow I took screenshots and potentially broke the flow:
https://docs.google.com/document/d/1XBumEy2fbA0EOMG7r4I4KlUfU91m7joI4m_iMuU0wBU/edit#bookmark=id.qufyyshr54u2

I will check out the document, we will do some revamping of the Oboarding in the very near future...AKA when I have time :D


feat: Frame switching methods

Added frame switching methods to the actions builder
Fixes: #5

Hey @viralpickaxe Why did you close this PR. Isnt that switchToIframe still needed ?

@viralpickaxe Please add reviewers who have write access so they can review and merge this PR.
@sipayRT @DudaGod  Can either of you review and merge this PR.
Would be great help to get the switchToFrame  method in for testing iFrames.


CASino integration with mobile apps

I intend to integrate the apis with mobile app

Sir, how to use this for beginner.


New schema yaml syntax (#790)

The SchemaLoader changes look really extensive in the diff, but it was mostly a refactor to extract the common behavior between v1/v2.

fixes #790


Feature/add helpers

This PR adds some useful methods and properties:

url property for the Issue model. It returns a relative URL that can be passed to the new client.get_absolute_url() method to construct a full URL.
client.issue_exists() method is a shortcut to check if issue exists.
client.get_issue_custom_field() helps with finding a specific custom field by name.

/rebase


Add support for LWG001

and changed name of LCT003
LCT003:
https://www.zigbee.org/zigbee-products-2/#zigbeecertifiedproducts/?view_30_search=lct003&view_30_page=1
LWG001:
https://www.zigbee.org/zigbee-products-2/#zigbeecertifiedproducts/productdetails3/5acc1330bfa55c1f9dae2523/

Hi Johan,
Do know when we can expect an update for this?


Query multiple table

Hi Reviewers,
Kindly find below the changes implemented ✍.
Changes introduced ♻

Create a table named owners ✔
Create a table named species ✔
Modify animals table ✔
Insert data to the owners and species table ✔
Use the primary key and foreign key mechanism for joining tables ✔
Query multiple tables ✔
Prepare complex queries that answer analytical questions ✔

Screenshots of the analytical queries.

1. What animals belong toMelody Pond?

2. List all animals that are Pokeman.

3.  List all owners and their animals.

3. List all animals owned by Dean Winchester that haven't tried to escape.

4.  List all Digimon owned by Jennifer Orwell.

5. List all animals owned by Dean Winchester that haven't tried to escape.

The query returned 0 rows.

5. Who owns the most animals?

Hello @mukhammadrizooff,
I am happy about the approval.
Thank you!


A slight grammatical change to avoid confusion

A slight grammatical change to avoid confusion while reading about the Network Policy in a specific namespace.

Hi @vinod827 thank you for your contribution. Please sign the CLA so we can accept your PR for review.
/assign

Hi @vinod827 thank you for your contribution. Please sign the CLA so we can accept your PR for review.
/assign

thanks, I have signed the CNCF ICLA

thanks, I have signed the CNCF ICLA

Hi @vinod827 thank you for your contribution. Please sign the CLA so we can accept your PR for review.
/assign

Hi, I have signed the CLA. Seems there is an issue with the required label as one of the check has not passed.

Hi @vinod827 thank you for your contribution. Please sign the CLA so we can accept your PR for review.
/assign

Hi, I have signed the CLA. Seems there is an issue with the required label as one of the check has not passed.

Hi @caseydavenport please serve as the technical reviewer for this and add an /lgtm when you feel it is correct and I'll take care of the rest.
Thanks

Hi @caseydavenport please serve as the technical reviewer for this and add an /lgtm when you feel it is correct and I'll take care of the rest.
Thanks

Hi @caseydavenport please serve as the technical reviewer for this and add an /lgtm when you feel it is correct and I'll take care of the rest.
Thanks

Hi @caseydavenport / @danwinship, I would really appreciate it if you can please add the label for the PR build to pass. thank you

Hi @caseydavenport please serve as the technical reviewer for this and add an /lgtm when you feel it is correct and I'll take care of the rest.
Thanks

Hi @caseydavenport / @danwinship, I would really appreciate it if you can please add the label for the PR build to pass. thank you

The proposed change is incorrect. See Casey's comments.

The proposed change is incorrect. See Casey's comments.

The proposed change is incorrect. See Casey's comments.

@danwinship , thanks, I have made changes as per the review comments given @caseydavenport
/assign @bradtopol

The proposed change is incorrect. See Casey's comments.

@danwinship , thanks, I have made changes as per the review comments given @caseydavenport
/assign @bradtopol

/lgtm

/lgtm

please add the necessarily approved label, thanks
https://prow.k8s.io/pr?query=is%3Apr+repo%3Akubernetes%2Fwebsite+author%3Avinod827+head%3Amaster

please add the necessarily approved label, thanks
https://prow.k8s.io/pr?query=is%3Apr+repo%3Akubernetes%2Fwebsite+author%3Avinod827+head%3Amaster

@bradtopol / @caseydavenport , please add the label to approve this PR

@bradtopol / @caseydavenport , please add the label to approve this PR


CUSTOM_ORIGIN_SERVER Adding custom_origin_server to CustomHostname st…

…ruct
Description
I added an optional custom_origin_server property to the CustomHostname struct so the cloudflare-go client can be used to create this special custom hostname.
Has your change been tested?
I added a new test for the optional property. go test ran successfully.
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

??? If https://godoc.org/github.com/cloudflare/cloudflare-go#CustomHostname is auto-generated, then it should show up. If not, instructions would be helpful.

Thanks for the PR @oh4real. I'm not seeing this field in the public API documentation. If you're seeing this in a response, are you able to raise a support ticket to get the documentation updated and confirm this is something that is intended to be used by the end users?

It's complicated. And no, like many, many things, is not in api.cloudflare.com
It's in the SSL for SAAS (Enterprise) docs: https://developers.cloudflare.com/ssl/ssl-for-saas/hostname-specific/hostname-specific/  This is publicly accessible, even though only available to Enterprise configured zones.
Also, if you are enterprise, when you go to create a custom host via the Admin console, it is an option:

I will try to submit a ticket to normal support for them to add this the enterprise feature to the API docs.

Appreciate the context. We've got this enabled on our Enterprise account and see what you've mentioned above.
The main caveat here we need to look out for is that if it's not documented, we don't really have a leg to stand on if something is changed unexpectedly. This isn't something the Cloudflare folks generally do but it's a good practice not to rely on anything that isn't publicly documented to avoid random breakages.
Keep us posted on the ticket status and if you hit any issues, we can ping some Cloudflare folks to either advise or take a look at getting some eyes on it.

I got a response from the support team.
Un/fortunately, the request has gone into an internal ticketing system for the API team, so I have no visibility on when/if the property/feature will ever make it into the official API.
Hi there,
Thanks for contacting Cloudflare support. My name is Andrew and I will be looking into this ticket for you.

Thank you for the information, I have created a ticket for our API team with the details in your ticket, asking them to update the documentation.

However, I have no ETA on when this will be completed.I will mark this as solved, but do let us know if you have any further questions or issues by replying to this e-mail or ticket.

Best regards,
Andrew B

They closed the ticket, so I don't think I should expect any updates to it.
I am open to suggestions on how to proceed?

@oh4real it looks like the documentation for this has been updated. If you can fix up the minor formatting issues here, we can look to get this one merged.

I missed your note on docs. I've updated per your formatting suggestions. Hopefully, branch is good.

Thanks for contribution @oh4real and my apologies for the delay in response.


Allow tag names to be updated

This is a follow up to #18378
Before
When a classification#name was changed, a new tag was assigned.
The existing tag was linked to records in the database. Those records were linked to a tag with an incorrect classification.
After
When a classification#name is changed, the corresponding tag is updated.
Now records linked to the tag are still linked and the classifications are valid.
Didn't we just undo this change?
2 Bad entries in classification factory were causing tests in many repos to fail when classifications were changed. Changing this factory to properly create classification/tags now means that the proper changes to classifications does not break other repo tests.

@simaishi Do you need me to do anything special to backport these?

master: https://bugzilla.redhat.com/show_bug.cgi?id=1666887
5.10: https://bugzilla.redhat.com/show_bug.cgi?id=1669269
5.9: https://bugzilla.redhat.com/show_bug.cgi?id=1668730

@kbrock As long as this PR can go to other branches as is, nothing is needed from you. I'll backport to each branch when appropriate. Thanks!

@kbrock All files are conflicting on backport to hammer branch. Please create a separate PR.

Backported to Hammer via https://github.com/ManageIQ/manageiq/pull/18436


Implement admin login page UI

Please get me on this issue

I'd love to tackle this issue, please


fix documentation and increment version number

Tiny PR, which just fixes spacing in docs so the yaml configs print properly and increments the version number for a release test.

Codecov Report

Merging #79 into develop will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #79   +/-   ##
========================================
  Coverage    84.44%   84.44%
========================================
  Files           12       12
  Lines         1305     1305
========================================
  Hits          1102     1102
  Misses         203      203

Impacted Files
Coverage Δ

pyDeltaRCM/_version.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8be88b...79de996. Read the comment docs.


Cannot import a dependency if a default entry is not present in its package.json

Describe the bug
I was trying to import "lodash.kebabcase": "^4.1.1" in my vite project. The app did not actually import it and gave me a log warning during development:
[vite] dependency lodash.kebabcase does not have default entry defined in package.json.

Reproduction

Add "lodash.kebabcase": "^4.1.1" to the vite project.
Import and use kebabCase function.
Run yarn dev.

System Info

required vite version: 1.0.0-rc.4
required Operating System: Kubuntu 20.04
required Node version: v12.18.0
Optional:

yarn version: 1.22.4
Installed vue version (from yarn.lock or package-lock.json): 3.0.0-rc.5
Installed @vue/compiler-sfc version: 3.0.0-rc.5

Logs (Optional if provided reproduction)

Run vite or vite build with the --debug flag
Provide the error log here.

This is expected.The dependencies inside package.json will be pre-bundled.


docs: add CloudPI RFC

thanks for the contribution @albrodfer1 ! let me review and will get back to you


v4l2_enc: update little typo

Only delete one left parentheses.
Signed-off-by: dongping wu<EMAIL_ADDRESS>

hi @xuguangxin , @uartie , @YuJiankang , please help to review. thanks.


added experience section

Fixes

Fixes #104 by @khushigarg1
Types of changes

[ ] Bug/Hot fix (non-breaking change which fixes an bug)
[x] New feature (non-breaking change which adds a functionality/feature)
[ ] Refactoring Old Code ( non-breaking change replacing already existing code)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

I added the experience command in a terminal portfolio so whenever the user writes the experience command it will show work experience.

Preview Link
(https://khushigarg1.github.io/Terminal-Portfolio/)

[x] I have read the CONTRIBUTING guidelines in repository.
[x] My pull request has a descriptive title and is attached to an existing issue.
[x] I haven't repeated the code and it follows established code style of repository.
[x] My branch is up-to-date with upstream branch.

Add a preview link for this by deploying it on your github pages and sharing the link here.

Also complete the form by adding issue number

Now completed the form

are you working on latest commit as Tab Autocomplete isn't working.

check this bug

Please check now.

still not working, also instead of showing experience directly next to it create a new line

Title
Paragraph
Paragraph

still not working, also instead of showing experience directly next to it create a new line

Title
Paragraph
Paragraph

Now check i fixed autocomplete tab issue.

Great 🚀


GLES3 support.

'target.es = true' and 'target.version = 300' now outputs GLES3 compatible shaders. A hook to set the version is still needed, or maybe output both version 100 and 300.

We will output both. Can't decide beforehand what we need.


Fixed recording_get and recording_delete and added recordign_delete_file

After @eclemens PR (https://github.com/hintmedia/zoom_rb/pull/4) ,  we can use request_headers for the authentication. Fixed path according to v2 API endpoint with authentication so that they works. And also added one method to delete recording with meeting_id and recording_id.

@shohey1226 bump. Let me know if you'll have time or not to get these changes made. If not, no worries, just close the PR and someone else can take it on. 👍

Closing due to lack of response.


add nomad_consul_tags option

Small PR to add tags for Nomad services registered in Consul :
https://www.nomadproject.io/docs/configuration/consul.html#tags

Cool, thank you!


Windows builds

This question is to anyone, who managed to build this on Windows previously: what setup did you use? Does it still work? The MinGW distro advertised on the main project page was broken by the addition of the time crate dependency I think. Even when removing the references to time it still doesn't want to compile for me. I tried with:

The original MinGW + MSYS
MSYS2 with mingw-w64-x86_64/i686 with rebuilt SDL dependencies.
TDM-GCC 32/64 bit toolchain.

All of these failed at some point of the compilation (I had all the dependencies).
Rust used: the beta, downloaded today from the official site (tried both i686 and x86_64).
gcc: various, from 4.8.2 - 4.9.1 I think
Sorry for no concrete error messages, but I'm writing this on the go. I'll post some results when I get home.

I was able to get it to compile on windows today, but I couldn't get it to link with the built libtcod.dll.
My setup was:

64-bit Windows 7
32-bit Rust compiler (rustc 1.0.0-beta (9854143cb 2015-04-02) (built 2015-04-02))
MSYS2 (using the "MinGW-w64 Win32 Shell" shortcut, and as a result 32-bit gcc)

For some reason ld keeps skipping libtcod.dll as if it has incompatible architecture, and I'm not sure how that would be possible.

This is really interesting, today cargo build worked for me out of the box, but all the examples crash on launch.

Never mind, I forgot to copy the libtcod DLLs after I reinstalled my VM, it actually works fine now. I have no idea why I was having so much trouble the last time. I even used the same version of everything.

May I ask what you ended up using? I'm currently stuck on getting the time crate to build. It keeps failing to build because "64-bit mode not compiled in" despite ensuring that all my compilers are 32-bit.

Oh, the (new?) Rust installer installs x86 and x64 versions separately. Removing the 64-bit one and updating my PATH fixed my problems.

I still don't know what originally caused my problems (I suspect that I had mixed i686 and x86_64 libraries / compilers as well. Still it might be worth mentioning on the main page, that this will only work on 32-bit toolchains.

As far as I'm concerned this is resolved. Could we close it?

Since both of you got it running, I'll close this -- we can reopen later if necessary.
It'll probably be a while before I do another round of Windows testing, but I'm happy to add fixes to the docs if you have specific suggestions.


restrictedcapabilities namespace is not allowed

During submission, I got this error
Package acceptance validation error: You don't have permissions to specify the following namespaces in the appx manifest file of the package ludosquest.appx: http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities
I imagine this allows to run full trusted EntryPoint="Windows.FullTrustApplication".
Any workaround here?

Ok, it seems I need to get permission to release a win32 desktop bridge app. Form to ask is here:
https://developer.microsoft.com/en-us/windows/projects/campaigns/desktop-bridge


[BUG] LSTUR and NRMS in News Rec Module

Description

Attention layer in LSTUR doesn't mask padding which will effect model performance
Can't save NRMS model

How do we replicate the issue?

Create a conda environment for gpu
run example/00_quick_start/nrms_synthetic.ipynb
run cell "model.model.save_model(path)"
run example/00_quick_start/lstur_synthetic.ipynb

Expected behavior (i.e. solution)

change get_config method of SelfAttention layer in reco_utils/recommender/newsrec/layers.py.
add masking attention weight in AttLayer2 layer.

same problem that could not save model in : reco_utils/recommender/newsrec/models/base_model.py
is it resolved please?


Mark tests by type

Use top level describe functions to denote test type - currently either unit or system. Update makefile to use these for different targets.

Slight change of plan - made different test suites that include only certain types. Directory structure changed inline.


Test pr for ot3 build

do nothing commit to test pr builds

This was always a test pr and the tests pass


Add dashboard to manage orders

 The underline should appear on Dashboard, not Orders.

What is the difference between this and the regular admin orders page?

The purpose of dashboard tab is to save the history of each order. I think it would be better to create a proper table to save that history. What your thoughts on it?


chore: combine frontend and backend into single container

It was requested by Metin, as I understand, to simplify HC setup. I don't have a strong opinion about this approach, from one side it really simplifies things, it would allow updating frontend and backend at the same time, but this doesn't seem to be a good practice. In docker-compose I can specify a restart policy for the whole container, but not for its process. For example, what should happen if the backend process gets crushed? Should nginx also be stopped or should the backend restart automatically? Should it be restarted infinitely? Notify the container manager somehow?
This PR is supported by the Æternity Crypto Foundation

It’s best practice to separate areas of concern by using one service per container. That service may fork into multiple processes (for example, Apache web server starts multiple worker processes). It’s ok to have multiple processes, but to get the most benefit out of Docker, avoid one container being responsible for multiple aspects of your overall application. You can connect multiple containers using user-defined networks and shared volumes.

https://docs.docker.com/config/containers/multi-service_container/

I strongly disagree with this PR/change.

🤷♀


Frontend and Backend Hacks

My Blog with hacks

Notes were good and all questions answered but the video was just 4 seconds of black, can resubmit for full credit


Close watcher after event is received.

Fixed and stress test shows no watcher creation errors and lsof has no fiiles opened for inotify.

Fixes #1080