Flutter-web: Snackbar not read in NVDA screen reader

Steps to Reproduce

Window's NVDA screen reader on.
Run flutter web with example snackbar app. https://docs.flutter.dev/cookbook/design/snackbars#interactive-example
Click button to show snackbar.

Expected results: Snackbar content should be read
Actual results: It is not read.
I did some investigation, per MDN

Simply including an aria-live attribute or a specialized live region role (such as role="alert") in the initial markup as it's loaded will have no effect.

Dynamically adding an element with an aria-live attribute or specialized role to the document also won't result in any announcement by assistive technologies (as, at that point, the browser/assistive technologies are not aware of the live region yet, so cannot monitor it for changes).

Always make sure that the live region is present in the document first, and only then dynamically add/change any content.

So we should first have an empty aria-live within dom and then change the content. However I don't see any workaround for this.
Semantic(liveregion:true, child: Text('')) won't create a live region since the content is empty. I couldn't add a meaningful live-region element either, because other platform: native Android works fine.
Any suggestions?

A little more details:

This shows up in JAWS and NVDA on Windows.
This sometimes happens in Chrome on Android.

A few ideas:

Delay the content of live regions in the Flutter Web implementation: the idea is to "trick" the AT into reading the contents of the live region.
Use global persistent live regions and copy the contents into them. This would satisfy the requirement that a "live region is present in the document first". This could get messy though because we'd need to maintain the same content in multiple places.

Also, now that we know that live regions on the web have the "live region is present in the document first" requirement, we could also allow creating empty live regions. This would allow the developer to control when the content appears.

I'd prefer not having developers create a new empty live regions, this add developer work.
I like the idea of delay.

When the semantic dom needs to be updated, we need to check if we need to insert a new aria-live element.
If a new element needs to be ADDED, flutter system should add a delay between (insert empty aria-live element to dom) and (update the content).
For update already existing aria-live element content, no delay is required.

This should benefit for all Semantic liveregion use case automatically for developers, not just for snackbar.

Hi @whsliuyun
This issue is reproducible on the latest stable and master channels.

Chrome (Windows): ❌
Chrome (Android): ✅

✅: No Issue ❌: Issue reproduced

Demo

Windows
Android

flutter doctor -v
[√] Flutter (Channel stable, 3.0.5, on Microsoft Windows [Version 10.0.19043.1766], locale en-US)
    • Flutter version 3.0.5 at C:\WIP\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (9 hours ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[√] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at C:\AndroidSDK
    • Platform android-32, build-tools 32.0.0
    • ANDROID_HOME = C:\AndroidSDK
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.2.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.2.32616.157
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[!] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio Electric Eel 2022.1.1
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    X Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[√] VS Code (version 1.69.1)
    • VS Code at C:\Users\ADMIN\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.44.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19043.1766]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 103.0.5060.114
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 101.0.1210.53

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[√] Flutter (Channel master, 3.1.0-0.0.pre.2030, on Microsoft Windows [Version 10.0.19043.1826], locale en-US)
    • Flutter version 3.1.0-0.0.pre.2030 on channel master at C:\WIP\flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dcdb9f1cde (88 minutes ago), 2022-08-02 03:21:07 -0400
    • Engine revision 3b2bd24a1e
    • Dart version 2.19.0 (build 2.19.0-53.0.dev)
    • DevTools version 2.16.0

[√] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at C:\AndroidSDK
    • Platform android-32, build-tools 32.0.0
    • ANDROID_HOME = C:\AndroidSDK
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.2.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.2.32616.157
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[!] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio Electric Eel 2022.1.1
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    X Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[√] VS Code (version 1.69.2)
    • VS Code at C:\Users\ADMIN\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.44.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19043.1826]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 103.0.5060.134
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 101.0.1210.53

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

But I see there's an open issue #75880 (flutter app is accessible when uses NVDA) that hasn't been fixed yet. Do you see it as the meta-issue of this issue?

I'd prefer to keep this issue. It's more actionable. I'll see if we should close #75880. I'm not sure what it means to fix that. It's probably a matter of fixing many little bugs.


Save lookup computation in blake

This change is

#815  👈
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on  Graphite

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.28%. Comparing base (e3858fb) to head (1cebae1).
Report is 6 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #815      +/-   ##
==========================================
+ Coverage   92.18%   92.28%   +0.10%
==========================================
  Files          90       92       +2
  Lines       12473    12579     +106
  Branches    12473    12579     +106
==========================================
+ Hits        11498    11609     +111
+ Misses        864      861       -3
+ Partials      111      109       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


1080p AI+ (BFUS) bricked with no backup

Hi! Someway I have bricked my 1080p AI+ (BFUSY4), only orange steady light.
I have no backup to follow the unbrick procedure, so  could I do it some other way?
Lots of thanks

What's the prefix of your cam?

I'm currently facing the same Problem. I wanted to use my Cam after I stored it for quite some time. I had no sdcard in it. Tried to get the latest Firmware on the card but no luck.
My cam used the Y21GA Firmware. No Backup available.

Try this:
https://github.com/roleoroleo/yi-hack-Allwinner-v2/issues/305#issuecomment-980365447


haskell_indent_if not lining up if statement?

I set this variable to 3 in the vimrc but am getting this behavior:

Is this a common issue?

Sorry, I cannot reproduce this :/

Indentation doesn't work for me either. I have copied the values exactly as they are in the readme.

The Readme was a little misleading about editing the .vimrc I've moved the needed configuration into the pathogen section. Please check if you have
syntax on
filetype on
filetype plugin indent on

in your .vimrc. Preferably directly after pathogen#infect().
If this does not work I presume that there is something wrong with your vim setup.
Kind regards,
raichoo

Hey Raichoo,
Thanks a lot for getting back man. I use Vundle to install packages. But I have the three settings (about syntax and filetype) exactly as you have suggested. But it still doesn't work.
It's a pity, because your plugin looks very promising.
Regards,
Rohit

I think a good way to find the problem would be to start with an empty .vimrc and build up from there. Something seems to interfere. Try it without the indentation settings etc. Maybe something is going wrong there. I'd really like to know the reason why this happens.
Kind regards, raichoo

Hey man,
I tried by starting from an empty .vimrc and carefully adding back stuff without any success.
During the weekend I decided to try out neovim, changed my plugin manager from Vundle to vim-plug and also removed a lot of cruft from my vimrc. I installed haskell-vim and it just worked. I don't know if the problem was with Vundle or vimrc.
The plugin works like a charm, thanks a lot for writing it.
Regards,
Rohit

Ah nice, another neovim convert :) I did the switch some time ago, but test the plugin in both.
Glad you like it. I'll leave this issue open in case @paperziggurat has some findings to report.
Kind regards,
raichoo

I'm using:
% vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Dec  2 2014 16:26:07)
Included patches: 1-273
Modified by Gentoo-7.4.273
I'm using pathogen and ... it's not working for me either. The only file I modified was .vimrc per your suggestions. I have no idea what else to say here, feel free to ask questions.

I've installed nvim now but unfortunately it doesn't work for me there either.
I do some simple testing, like foobarfoo x = if x > 5. Then I hit enter... nothing gets aligned. Bit annoyed by vim, don't take it personal :laughing:

I'm out of ideas what causes this. You might want to check with my .nvimrc if I'm doing something in there that might be missing.
https://github.com/raichoo/rcfiles/blob/master/nvimrc
Kind regards,
raichoo

If anyone else is having indent issues check your indentexpr :set indentexpr make sure its using the expression defined in the haskell-vim indentexpr=GetHaskellIndent().
My issue was I had vim2hs installed alongside haskell-vim which overrided the indent expression.

Ah! Finally someone with a clue of what's going on :D. Hopefully this will solve the issue.


update libraries - ic-web3-rs,ic-solidity-bindgen

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 60.216%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
3855

Relevant Lines:
6402

💛  - Coveralls


import-url/update: add --no-download flag

Add documentation for new dvc import-url dvc update flags  (--no-download)
related: iterative/dvc#7918

Hey @dtrifiro another note for future reference: please open PRs to this repo directly on the upstream (no fork). See https://github.com/iterative/dvc.org/wiki/2.-Pull-requests-for-core-DVC-changes for context. Thanks!

@dtrifiro Do you think it's realistic to get this drafted, reviewed, and merged this sprint?

In case @jorgeorpinel didn't already mention it, please open future docs PRs from this repo instead of a fork. That way, the changes will be deployed into an example app when you open the PR and it's easy for people to see what the final docs will look like. 🙏 No need to bother for this PR.

@jorgeorpinel I merged, but feel free to leave comments if you have them

Thanks for the feedback @jorgeorpinel, here's a new PR: https://github.com/iterative/dvc.org/compare/main...import-url-no-download-fixes
we can move the discussion there


Custom settings for black autoformat

I wanted to use black autoformatting for some specific purposes only, i.e. disabling most of its functionality and just let it format some specific parts (e.g, whitespace managing and import sorting).
Is there any way to adapt the settings of the black instance being used? I could not find a .toml file anywhere?
btw: black was a really bad choice of name by the authors. try searching for issues with black and so much unrelated stuff pops up.

I'm pretty sure the Spyder plugin respects pyproject.toml and the black configuration in there.
See https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#configuration-format
You can then place your pyproject.toml in the same folder as the file you want to format (see https://black.readthedocs.io/en/stable/usage_and_configuration/the_basics.html#where-black-looks-for-the-file), and run black. I just tested with adjusting line-length in the toml file, and that works.
Note that black in Spyder is not behaving entirely as it should https://github.com/spyder-ide/spyder/issues/17143
PS: I feel the pain re searching issues with common works, if its of help I recently discovered adding in:title to the filter (for example, is:issue is:open in:title black )

I wanted to use black autoformatting for some specific purposes only, i.e. disabling most of its functionality and just let it format some specific parts (e.g, whitespace managing and import sorting).

In that case, you can select the portion of text you want to auto-format with Black and go to the menu Source > Format file or selection with Black. Does that help too?

I wanted to use black autoformatting for some specific purposes only, i.e. disabling most of its functionality and just let it format some specific parts (e.g, whitespace managing and import sorting).

In that case, you can select the portion of text you want to auto-format with Black and go to the menu Source > Format file or selection with Black. Does that help too?

perfect! Exactly what I needed :)

Auto-sorting of imports needs that functionality added to the Python language server first (as I said in the other issues you posted earlier).
We'll try to implement it in the future.

I'm going to close this issue because I think your questions are solved now. But please post here again if you any more info about it.


Final-Release: use a more descriptive git tag

Use a more descriptive git tag for the release.
The problem with a 24.05-style tag is, that they will land in peoples pinned sources - and those people will wonder why they never get any updates.
This changes hopes to make this less prevalent by adding a more descriptive name for the actual git tag: It tags the branch-off for the new channel release, but it is not the actual channel.

cc @RossComputerGuy

I just wanted to throw my hat in on requesting this be reconsidered, since it breaks some down-stream integrations I've seen folks use, and that I use myself.
For context on the choice of yy.mm, it means git describe --tags HEAD has a reasonable version. For example, if the tag was 24.11 it would say:
% git describe --tags HEAD
24.11-1709-gff5fd5aff0b3

...but with the prefix, it now says:
% git describe --tags HEAD
branch-off-24.11-1709-gff5fd5aff0b3

which makes it a fair bit more confusing.

We could swap the order using lib functions inside of nixpkgs heh

I got similarly confused. Might it make more sense to do 24.11-post? The release- prefix feels like a branch to me, whereas the -pre or -beta suffix feels like a version.
That way the whole lifecycle looks like:

Beta
Pre
Post
Final(?) once the tag stops being maintained and we move to the next one.

(It also fiercely messes with my OCD 😅)


DamageEntityEvent regression

I am currently running

SpongeVanilla version: 1.12.2-7.2.3-RC373
Java version: 1.8.0_232
Operating System: Windows 10

Issue Description
Commit 4c3a4d4 introduced an important regression of DamageEntityEvent. Before this commit, cancelling the event was also stopping all damage related mechanisms such as: knockback, animals running, pigman getting angry, hurt time, hurt resistant time, entity getting on fire if hit by a flame arrow, etc. Now cancelling the event is just equivalent as setting the damage to 0, but there is no way using the API to stop all the previous mechanisms. I weigh the word "important" because this issue affects protection plugins and has a huge impact on pvp / pve servers.

This is problematic one way or another, because we've now got Forge behaviour, but now we have this issue occurring instead. Rock and a hard place.
What I suggest we do is bypass up to here. This will mean that FirstAid will keep working, but all other damage related effects are bypassed.

Actually, no, I know what's happened.
This original fix is wrong, in that it cancels everything if the damage is zero. In Forge, the method then continues, so having returned true there means that Forge behaviour would be followed through the method.
This meant that I misidentified the fix to FirstAid, which was to simply flip that boolean to true and instead ignored the result. That should not have happened.
I'll put up a PR shortly that I will need testing.


isEmpty for linked list

@bantic for you creates an isEmpty property on the linked list instead of the empty() function call.

thanks. I will update Marker to have an isEmpty property as well


Calculating script hash from P2TR address, its public key or Script

Does your library provide native conversion from p2tr address to its scripthash?
I need this for querying Electrumx indexer to discover unspent UTXOs belonging to P2TR address but didn't find more elegant way to do this than using custom hashlib-based function:
from pycoin.symbols.btc import network as btc_mainnet
from pycoin.symbols.xtn import network as btc_testnet
import hashlib

def get_script_hash(addr, network="mainnet"):
    if network == "mainnet":
        pycsymbol = btc_mainnet
    elif network == "testnet":
        pycsymbol = btc_testnet
    script = pycsymbol.parse.address(addr).script()
    return hashlib.sha256(script).digest()[::-1].hex()

The hash of the script is probably used in Electrumx to uniquely identify (for indexing purposes) the script.
Afaik it is not used in the Bitcoin protocol and thus the library does not support it. The way you calculate it above seems OK to me. Just send that to electrumx.

Thanks for the explanation. I will keep this function within my sandbox 1


Option to download stream

it wuld be really great to have an option to download the episode/video/stream from the each of the respective sections

Anime
K-Dramas
Manga
TV shows
Movies

And also, movies already have a download option

As for mangas, I am working on a download system, but I can't state an ETA.

MANGA DOWNLOAD
Added direct downloads for mangas

@real-zephex  Wouldn't making a new fetch function from anilist or consumet and add it to a new button component just work for the anime downloads ?

@real-zephex  Wouldn't making a new fetch function from anilist or consumet and add it to a new button component just work for the anime downloads ?

What does that even mean?


[Python] Make all subscription callbacks async capable

Support asyncio coroutines as callback arguments. This allows to write asyncio code easily. Still support regular callbacks.
This changes on what thread some of the callbacks are being made. So far, some of the callbacks have been made directly (from the Matter SDK thread), and some from the callee thread (from the event loop thread learned via asyncio.get_running_loop()).

SetResubscriptionAttemptedCallback -> even loop thread
SetResubscriptionSucceededCallback -> even loop thread
SetAttributeUpdateCallback -> SDK thread
SetEventUpdateCallback -> SDK thread
SetErrorCallback -> even loop thread

With this PR, all callbacks are done in the even loop thread, no matter if coroutines are used or regular routines.
Calling all callbacks in the event loop thread causes issues for the ZCLSubscribeAttribute  (legacy?) API. This PR now simply makes all callbacks asyncio capable. Coroutines as callback can only be used when using the new WriteAttribute()/ReadAttribute() API.
This also addresses at least one bug where create_task() is used on the even loop from the SDK thread. create_task() is not thread safe. This PR uses the thread safe alternative run_coroutine_threadsafe().
It also speeds up the tests slightly by avoiding fixed sleeps in TestCaseEviction.

I've added some additional commits which convert more of the tests to make use of the asyncio framework.

After further discussions internally we actually agreed that it is a more versatile API design to make all callbacks straight from the Thread the SDK makes the callback from. Some callbacks can be resorted already on that Thread, without the need to load the main event loop.
The main issue with the current implementation is that the callbacks are handled differently, and the semantics are not exactly documented. I intend to create a new PR which makes all callbacks to be called from the Thread directly, and document this accordingly. I expect that some tests will need adjustments as well.

Closing, reasoning see above.


AudioContext constructor options

Fixes #8891

One of the unit tests is failing but I'm not quite sure what's the reason. May someone provide guidance please?

Can you use optional properties rather than $Shape? E.g.
{| latencyHint?: 'balanced' | 'interactive' | 'playback' | number, sampleRate?: number |}

You need to record the test snapshots as the locations changed for the tests fetch and bom.
If you build flow you can run
flow/runtests.sh -b path/to/flow -r -t test-name

thanks @gkz, the PR should be good to go now, may you double check please?


Gently urge users to consider using yab.

YAB IS THE NEW TCURL

Coverage increased (+0.03%) to 85.333% when pulling a160a2fba7b8ac4e9f008b94256652719a17354b on deprecate into b7635426a3eb37a8923bf1eb9023983c1513772f on master.

Maybe point out they can replace "tcurl" with "yab" and it should Just Work.

Coverage increased (+0.03%) to 85.333% when pulling<PHONE_NUMBER>5a1265f2cfe4c4c88f071c892a6f44 on deprecate into b7635426a3eb37a8923bf1eb9023983c1513772f on master.

Coverage increased (+0.03%) to 85.333% when pulling<PHONE_NUMBER>5a1265f2cfe4c4c88f071c892a6f44 on deprecate into b7635426a3eb37a8923bf1eb9023983c1513772f on master.


hive engine chart

@Adesojisouljay What token chart is being displayed? Idea with this feature was slightly different.

No need new chart library, we already have highcharts integrated, please utilize that.
Idea was to have chart about each token just like Ecency mobile wallet page. Here I tried to make quick sketch:

Use space between token label and balance and display chart/price info as background and on mobile browsers, we don't need to show charts.
For tokens that doesn't have market history or chart data, then show straight line basically. (non changing price)

I haven't pushed some commits, that's was a sample in first commits.
I will check previous library.
On Wed, 9 Nov 2022, 2:50 pm Feruz M, @.***> wrote:

@Adesojisouljay https://github.com/Adesojisouljay What token chart is
being displayed? Idea with this feature was slightly different.

No need new chart library, we already have highcharts integrated,
please utilize that.
Idea was to have chart about each token just like Ecency mobile
wallet page. Here I tried to make quick sketch:
[image: image]
https://user-images.githubusercontent.com/3015990/200846759-4bc09f7c-203b-4243-a8c9-8586875d2210.png
Use space between token label and balance and display chart/price info
as background and on mobile browsers, we don't need to show charts.
For tokens that doesn't have market history or chart data, then
show straight line basically. (non changing price)

—
Reply to this email directly, view it on GitHub
https://github.com/ecency/ecency-vision/pull/1097#issuecomment-1308795576,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVAB2UXIFK2Q7RSPEFJYEZLWHOT2NANCNFSM6AAAAAARZODDMU
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes, will move that shortly
On Thu, 24 Nov 2022, 11:24 am Feruz M, @.***> wrote:

@.**** approved this pull request.
lgtm, HIVE_ENGINE_RPC_URL and chartApi should be under one file perhaps in
separate PR.
—
Reply to this email directly, view it on GitHub
https://github.com/ecency/ecency-vision/pull/1097#pullrequestreview-1192912657,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVAB2USQJSELCV7GNWKLMD3WJ467FANCNFSM6AAAAAARZODDMU
.
You are receiving this because you were mentioned.Message ID:
@.***>


Seperates multiple types with comma space

Fixes https://github.com/cloudflare/doca/issues/31

Thanks. Can you please fix this (npm run lint):
~/Projects/doca-bootstrap-theme: Relequestual-patch-1 npm run lint

><EMAIL_ADDRESS>lint /Users/miksu/Projects/doca-bootstrap-theme
> eslint components || true

/Users/miksu/Projects/doca-bootstrap-theme/components/objectDefinitionTable.js
  32:1  error  Line 32 exceeds the maximum line length of 100  max-len

✖ 1 problem (1 error, 0 warnings)

(I should set up travis to run npm run lint on PRs.)

Done! =]
I MAY make a few more pull requests. Finally got this thing working! =D

~/Projects/doca-bootstrap-theme: Relequestual-patch-1 npm run lint

><EMAIL_ADDRESS>lint /Users/miksu/Projects/doca-bootstrap-theme
> eslint components || true

/Users/miksu/Projects/doca-bootstrap-theme/components/objectDefinitionTable.js
  32:68  error  Trailing spaces not allowed  no-trailing-spaces
  33:65  error  Trailing spaces not allowed  no-trailing-spaces

✖ 2 problems (2 errors, 0 warnings)

~/Projects/doca-bootstrap-theme: Relequestual-patch-1

Also, in case that master was updated and there are merge conflicts, we prefer rebase over merge (it keeps the history clean and PR diff shows only your changes). But that's ok.

Sure. I was trying to do it directly through github rather than checking it out. In future I'll rebase =]

I can see the trailing spaces, and am about to push a change which removes them, however running npm run lint doesn't pick the issue up for me. I would guess you have some sort of global lint guide, which has elements you haven't included in this projects lint file.

Thanks.

I would guess you have some sort of global lint guide

I don't. We are using airbnb's config and it includes the no-trailing-spaces rule resulting to error.

We are using airbnb's config and it includes the no-trailing-spaces rule resulting to error.

We should be including whatever lint config we are using in the project as published to GitHub.

We do that.

@tajo cool I misinterpreted your response

Right, I noticed that, which is why it's weird it didn't pick up. Oh well.


Blog content make the text small regardless of the text in the blog.

on the /blog page the blog's content that appears below the blog heading. Make the text size of that small.

Corrected in 628230d9da2cd1bf08a0ef9447e428fcf1f6a16e


Registration Mail problem with german umlaut

e.g. Ã¶ instead of ö
check mail character encoding

Seems to be fixed for the current registration form – at least, I could not reproduce it anymore.
But please feel free to reopen if the error shows up again!


Make two fake terms and two fake frames

/benchmark plutus-benchmark:validation

Now with three frames to match the SOP work.

/benchmark plutus-benchmark:validation

/benchmark plutus-benchmark:validation

/benchmark plutus-benchmark:validation

Maybe I did something bad, let's check.

/benchmark plutus-benchmark:validation


能否再探索一下signalfd的情形？

如这里所述：https://news.ycombinator.com/item?id=10920243
如果应用程序是用signalfd来接收信号，gdb调试的时候一样拦截不到

The function signalfd has a similar problem with sigwait, and my method also works.
Please refer to src/signalfd_demo.c.
tks!


Specify text for PageChooserPanel button

Is your proposal related to a problem?
Our editing interface makes use of nested fields with PageChooserPanels:

The PageChooserPanel button uses a generic "+ Add" text, which can make it a bit ambiguous what is being added.
Describe the solution you'd like
It would be useful if we could pass a string to the PageChooserPanel widget that would be used for the button text:
PageChooserPanel(
    button_text="Add flavour",
    ...
)

This would be also useful for StreamBlocks  or StreamFields or blocks/fields that receive a list of blocks.
The "+" and the title of the button "Add" could be a big ambiguous. It would be great to have the ability to change that text


Unit test to demo #96 - clearParameters() discards batch

The test creates a table and inserts data using the batch API. In its current state, the test fails with the NPE described in issue #96.

Closes this in favor of #323. Thanks


Options with prompt=True are prompted twice

This happens once on parse and then again on run and is an artifact of how we have to support how BaseCommand splits this process into two stages. Should be able to come up with a workaround...

Fixed in 1.0.5


dont-merge(rln): onchain tree poc

chore(rln): onchain tree poc

Closing this PR since the PoC is ready - https://github.com/waku-org/research/issues/72


Add id to tasks

Add ids using Java UUID to tasks for #138
All tasks are assigned an id upon creation regardless if they are a floating task or an event. This is so that we can mutate a task from event to floating task without conflicts.
Also, it is possible for tasks to have duplicate attributes using id as unique identifier.
This branch still retains the original requirement for tasks to have unique names.

Coverage increased (+0.07%) to 91.451% when pulling c5a0ec1fe668f7dfecfcf3e63f5b386acdb21021 on task-uuid into 4e73ab0d40333f94e6ba3a9e633bc4aefc6665c6 on master.

UUIDs no longer needed.


Use querystring prop in ListingBody

New blocks schema adds querystring prop to listing block data, but it was not considered in listing body.
Added compatibility for new block schema and  backwards compatibility

@cekk could you please take a look?
https://github.com/kitconcept/kitconcept.volto/blob/71e71f9f741deee7b483d2611728efb2a426a22e/src/kitconcept/volto/upgrades.py#L6-L64

The code looks good. I've also tried it locally on a real db and the blocks seems migrated correctly. I'm waiting final review from a real Volto 13 environment from @giuliaghisini

@cekk could you please take a look?
https://github.com/kitconcept/kitconcept.volto/blob/71e71f9f741deee7b483d2611728efb2a426a22e/src/kitconcept/volto/upgrades.py#L6-L64

The code looks good. I've also tried it locally on a real db and the blocks seems migrated correctly. I'm waiting final review from a real Volto 13 environment from @giuliaghisini

It works well! now we are ready


Running msbot clone services results in "You need to upgrade your AZ CLI version to >= 2.0.52." but my version already is 2.0.52

Tool
Name: MsBot
Version: 4.3.0
OS: Windows 10
Describe the bug
Running the following command
msbot clone services --name "NlpWithDispatch" --luisAuthoringKey "" --folder "DeploymentScripts/MsbotClone" --location "westus" --appId "" --appSecret ""
Always results in
You need to upgrade your AZ CLI version to >= 2.0.52.
You can install the latest AZ CLI from https://aka.ms/az-cli-download
However my Azure CLI is already 2.0.52
az --version
azure-cli (2.0.52)
acr (2.1.10)
acs (2.3.12)
advisor (2.0.0)
ams (0.3.1)
appservice (0.2.8)
backup (1.2.1)
batch (3.4.1)
batchai (0.4.5)
billing (0.2.0)
botservice (0.1.2)
To Reproduce
Steps to reproduce the behavior:

Just run the command

[bug]

Hi @damadei, can you try the daily build (4.3.2-125) which can be found on MyGet?
To download it, you'll first need to change your npm registry to point to our MyGet gallery via this command
npm config set registry https://botbuilder.myget.org/F/botbuilder-tools-daily/npm/

Then install msbot via npm i msbot for a local install or npm i -g msbot. To reset your registry back to npmjs.org, you'll need to use the following command
npm config set registry https://registry.npmjs.org/

Hi @stevengum,
It worked with 4.3.2-129 and using Azure CLI 2.0.54
Thanks,
Daniel

Closing as this has been addressed with the latest public release of msbot, version 4.3.2. This version of msbot does not use the botservice extension, so you are not required to call az extension add -n botservice.
If you still run into this issue, please @mention me in this issue or open up a new issue.


Throws error for windows full path

This issue only reproduces on Windows OS.
Just giving it the drive letter or, AT MAX, the 3 char string (X:) the module works just fine, but if you give it a full path (eg.: D:\Temp) the module just spits a NOTFOUND error.
The module should work with full paths also, just like df works with paths on linux.

I can't seem to reproduce the issue. What version of Node and Windows are you running? Are you sure you have permission to read the directory you are trying to get disk usage information on?
I've been able to get disk usage information from both the main and external drives, and under subfolders, with and without trailing slashes:
> usage.checkSync('C:\\')
{ available:<PHONE_NUMBER>52,
  free:<PHONE_NUMBER>52,
  total:<PHONE_NUMBER>84 }
> usage.checkSync('C:\\Windows\\')
{ available:<PHONE_NUMBER>52,
  free:<PHONE_NUMBER>52,
  total:<PHONE_NUMBER>84 }
> usage.checkSync('G:\\')
{ available:<PHONE_NUMBER>16,
  free:<PHONE_NUMBER>16,
  total:<PHONE_NUMBER>96 }
> usage.checkSync('G:\\TEMP')
{ available:<PHONE_NUMBER>16,
  free:<PHONE_NUMBER>16,
  total:<PHONE_NUMBER>96 }
> usage.checkSync('G:\\TEMP\\')
{ available:<PHONE_NUMBER>16,
  free:<PHONE_NUMBER>16,
  total:<PHONE_NUMBER>96 }
>

I can't seem to reproduce the issue. What version of Node and Windows are you running? Are you sure you have permission to read the directory you are trying to get disk usage information on?
I've been able to get disk usage information from both the main and external drives, and under subfolders, with and without trailing slashes:
> usage.checkSync('C:\\')
{ available:<PHONE_NUMBER>52,
  free:<PHONE_NUMBER>52,
  total:<PHONE_NUMBER>84 }
> usage.checkSync('C:\\Windows\\')
{ available:<PHONE_NUMBER>52,
  free:<PHONE_NUMBER>52,
  total:<PHONE_NUMBER>84 }
> usage.checkSync('G:\\')
{ available:<PHONE_NUMBER>16,
  free:<PHONE_NUMBER>16,
  total:<PHONE_NUMBER>96 }
> usage.checkSync('G:\\TEMP')
{ available:<PHONE_NUMBER>16,
  free:<PHONE_NUMBER>16,
  total:<PHONE_NUMBER>96 }
> usage.checkSync('G:\\TEMP\\')
{ available:<PHONE_NUMBER>16,
  free:<PHONE_NUMBER>16,
  total:<PHONE_NUMBER>96 }

investigated the issue. my bad. it seems i was using diskspace, not diskusage. sorry


Sol1james patch 1

Updating doco to reflect the need to encapsulate the result set in a list when calling the all() method of an endpoint.
I'm not sure if it needs more explanation than this so I'm erring on the side of brevity.
See disscussion in #450

Hey, thanks for the PR! I'm not sure we'd want to make this the canonical example for .all()'s use though. The draw for converting .all() and .filter() to generators in the first place was to be a little more efficient with our IO operations. Directing user's to always cast to a list causes them to miss out on those. It's certainly the way to do it in some cases like yours where you find yourself iterating over the results more than once, but consider the case in which a user is looking for something in the results they're unable to filter on. With generators, if that result is found on the first page of a large result, they can exit the loop and save the subsequent queries to pull down the rest of the results.
I'm not saying we shouldn't mention it, like I pointed out in the issue, it's been brought up more than once since the change. I just don't know about it being the example. If that makes any sense.

I'll write a more nuanced description then.  If someone does use the all() method, what do they then need to do to start iterating over the collection from the beginning again?  Do they need to re-instantiate the API object with pynetbox.api()?
It would also be helpful to get some clarification about the mechanics of all this.  The all() method takes a parameter 'limit' - I assume that when you call all() it will fetch this number of records and presumably cache them?  And not do any more requests to the server across the network until the cache is empty?
And if you convert it to a list it will fetch the entirety of the result set which will be stored in the list?
It seems like the main question the user is faced with is whether they want to reduce network usage.  If they do they use all().  If they want the data stored locally they use list(all())

I'll write a more nuanced description then. If someone does use the all() method, what do they then need to do to start iterating over the collection from the beginning again? Do they need to re-instantiate the API object with pynetbox.api()?

Thanks, I appreciate the effort to clarify. To start over from the beginning you'd call .all() or .filter() again, but it's likely much more efficient to just save the results in a list.

It would also be helpful to get some clarification about the mechanics of all this. The all() method takes a parameter 'limit' - I assume that when you call all() it will fetch this number of records and presumably cache them? And not do any more requests to the server across the network until the cache is empty?

Close, but no caching. Limit is, in effect, passed on to the NetBox paginator. So each time we need to make a call for the next page it contains the same number of items specified by limit. For example, If you're iterating over the RecordSet and passed a limit of 50, when you reach the 50th item we'll make a call for the next 50 items and so on until you're done traversing the results.

And if you convert it to a list it will fetch the entirety of the result set which will be stored in the list?

Yes

It seems like the main question the user is faced with is whether they want to reduce network usage. If they do they use all(). If they want the data stored locally they use list(all())

More-or-less, though I'd always encourage using .filter() with some arguments unless you're dealing with an endpoint that only returns a few items.


Update nuspec NLog.Config and NLog.Schema

and update nuget.exe
<ContentFiles>, nuget 3.3+
fixes https://github.com/NLog/NLog/issues/2434

superseded by https://github.com/NLog/NLog/pull/2570


Remote Desktop Keyboard Layout

Hi there,
I'm using the last (I supposed) version and for all my serveur when I use "remote desktop" plugin I have the wrong layout.
I'm using an azerty keyboard
The client is configure in English
I use Windows Server 2016 (french version)
When I use remote desktop the keyboard layout mapped to the rdd session look like a strnage qwerty style
I don't know if there already exist an issue for that , I can't find it

0983254595

+84983254595

+84983254595

$200000000

Hi there,
Any news regarding the issue ?

Hi there,
Any news regarding the issue ?

Disclaimer: I am not affiliated with Microsoft or the Microsoft Docs teams here on GitHub.
Please use a real support instance like Microsoft Support or Microsoft Forums. This repository is intended for documentation improvement only.
Wish I could help, but this repository is not intended for regular support issues, support requests or support questions.
If you by any chance get feedback from Microsoft Support or Microsoft Forum members indicating that the current documentation needs to be amended/improved/adjusted, you are more than welcome to reopen this ticket or open a new ticket regarding your findings.
You may want to look elsewhere for answers, unless you have suggestions for improving one or more specific pages in the MS Docs repository.
The intention of this repository is to improve on the existing documentation by providing the users a way to report factual errors, improvement suggestions and request updates for new versions.
The MS Docs team members might not have time to answer your question, both due to the small size of the team and the big workload.
Try the following resources to get in touch with users who may be able to help you:

TechNet forums: https://social.technet.microsoft.com/Forums/en-US/home
MSDN: https://social.msdn.microsoft.com/Forums/en-US/home
Microsoft Community: https://answers.microsoft.com/

Disclaimer: I am not affiliated with Microsoft or the Microsoft Docs teams here on GitHub.
Please use a real support instance like Microsoft Support or Microsoft Forums. This repository is intended for documentation improvement only.
Wish I could help, but this repository is not intended for regular support issues, support requests or support questions.
If you by any chance get feedback from Microsoft Support or Microsoft Forum members indicating that the current documentation needs to be amended/improved/adjusted, you are more than welcome to reopen this ticket or open a new ticket regarding your findings.
You may want to look elsewhere for answers, unless you have suggestions for improving one or more specific pages in the MS Docs repository.
The intention of this repository is to improve on the existing documentation by providing the users a way to report factual errors, improvement suggestions and request updates for new versions.
The MS Docs team members might not have time to answer your question, both due to the small size of the team and the big workload.
Try the following resources to get in touch with users who may be able to help you:

TechNet forums: https://social.technet.microsoft.com/Forums/en-US/home
MSDN: https://social.msdn.microsoft.com/Forums/en-US/home
Microsoft Community: https://answers.microsoft.com/

Noted

Noted


I am measuring if its worth to do it right now.
What would be required to adapt https://github.com/epezent/implot to your api?

There is now https://github.com/4bb4/implot-rs which does exactly this :partying_face:


value-class-pattern should not insert space

From http://microformats.org/wiki/value-class-pattern#Basic_Parsing:

3. Where there are multiple descendants of a property with class name of value (multiple value elements)
1. if the microformats property expects a simple string, enumerated value, or telephone number, then the values extracted from the value elements should be concatenated without inserting additional characters or white-space.

php-mf2, mf2py, and gomf all agree on the expected value here:

http://pin13.net/mf2/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fmicroformats%2Ftests%2Fmaster%2Ftests%2Fmicroformats-v2%2Fh-card%2Fp-property.html
http://mf2.kylewm.com/?url=https%3A%2F%2Fraw.githubusercontent.com%2Fmicroformats%2Ftests%2Fmaster%2Ftests%2Fmicroformats-v2%2Fh-card%2Fp-property.html&parser=html5lib
https://willnorris.com/go/microformats/live?url=https://raw.githubusercontent.com/microformats/tests/master/tests/microformats-v2/h-card/p-property.html

I suspect there may be other tests affected by this as well, in which case I guess I'll fix them as I find them.

When I came to make this change to my parser I found it adds space based on the following rules. http://microformats.org/wiki/microformats2-parsing#parsing_for_implied_properties The way I read the parsing spec the value-class-pattern rules do not apply in this case.
I am going reverse this change for now. If you think I am wrong maybe we should put this up on http://microformats.org/wiki/microformats2-parsing-issues for discussion.

Really sorry @willnorris my mistake the p-* parsing rules clearly say value-class-pattern rule first, so you are correct. I will change my code to match.


feat/Truncate - Add the util

General summary
Add an util to be able to truncate a text like
"juani is amazing" -> "juani is..."
It can be used for chips and any other component
Check list

[ ] (if has style) Add need: review-integration label
[ ] (if has textual documentation) Add need: review-doc label
[x] (if has code) Add need: review-frontend label
[ ] (if has react) Check through the react dev check list
[ ] (if fix or feature) Add need: test label

Check out the contribution guide for general guidelines for submissions to the design system.

Isn't css already able to do this by itself? Do we really want to handle this manualy?

Looks good to me. However we currently only export packages/lumx-react/src/index.ts in the lib @lumx/react.
To have a @lumx/react/utils module we would need to modify the webpack config and add an entry to it.
@matmkian Do you think we could use a <Text> component that could apply this truncate, the dark/light theme, the typography?

@gcornut Good question -> what are "competitors" doing regarding that?

Thank you @radiuso for this PR! Like we discussed, we are not yet very sure how we want to introduce the text truncate and/or the Text component.
We'll explore and prototype all of this in the product and once the API is settled we'll add it to this repo.
For now we will close the PR. Thanks again!


gsoler3 Acrolinx quality push: troubleshoot-software-restriction-poli…

…cies.md

#assign: @robinharwood, @Xelu86
@robinharwood @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Install crash handlers with stack trace dump

Recently, OIIO sysutil.h added a way to set up a stack trace dump in
case of crash. Use those in OSL binary commands (it does not
automatically happen from the library). This only work with a new
enough version of OIIO, and only if that OIIO was compiled with a new
enough boost to contain boost's stack trace library (>= 1.65).
This is primarily to help developers figure out what's going on with
CI tests fail on remote machines -- you can't catch it in the
debugger, but maybe the stack trace will give you the clue you need as
to what's going on. I definitely don't expect it to be very helpful if
the crash happens in the JITed shader. But if the crash is in our code,
maybe it will help the detective work.
To that end, we also change the testsuite runtest.py so that when a
command fails entirely, print its console output.
And bump appveyor boost to 1.69, so that it's new enough to support
the stack trace library.

LGTM!


Error in object[[name, exact = TRUE]] : subscript out of bounds

Project Robyn
Describe issue
Error in object[[name, exact = TRUE]] : subscript out of bounds --> getting this issue due to hyperparameters not getting added into inputCollect
Provide dummy data & model configuration
The data does not have any issues, I Was able to run this same dataset before, the only thing is now I added in more media channel columns which I did not use before. I had an issue with the way the media variables were named (it did not like more than 1 underscore so I renamed everything to _s and _i for media variables and took out any other underscores and it fixed itself) but now im getting the same issue again
Environment & Robyn version
R version (R --version)
3.6
Error here!!
> InputCollect <- robyn_inputs(InputCollect = InputCollect, hyperparameters = hyperparameters)
Michaelis-Menten fitting for fbprosp_I out of range. Using lm instead
Michaelis-Menten fitting for yt_I out of range. Using lm instead
Michaelis-Menten fitting for disc_I out of range. Using lm instead
Error in object[[name, exact = TRUE]] : subscript out of bounds

This is the original input collect

> print(InputCollect)
Total Observations: 167 (weeks)
Input Table Columns (41):
  Date: week
  Dependent: orders [conversion]
  Paid Media: psoc_I, fbprosp_I, fbrmkt_I, nbsearch_C, bsearch_C, shop_C, drtv_I, yt_I, disc_I, native_I, brandtv_I, brandott_I, drott_I
  Paid Media Spend: psoc_S, fbprosp_S, fbrmkt_S, nbsearch_S, bsearch_S, shop_S, drtv_S, yt_S, disc_S, native_S, brandtv_S, brandott_S, drott_S
  Context: covidfear, promo, shiptimes
  Organic:
  Prophet (Auto-generated): trend, season on US
  Unused: categoryint, compsearch, newwebvisit, search_S, search_I, ytdisc_S, ytdisc_I, brpod_S, drdmail_S, brpp_S

Date Range: 2019-01-07:2022-03-14
Model Window: 2021-10-04:2022-03-14 (24 weeks)
With Calibration: FALSE
Custom parameters: None

Adstock: geometric
Hyper-parameters: Not set yet

These are my ad stocks - I used the hyper names so it should be proper
`> hyper_names(adstock = InputCollect$adstock, all_media = InputCollect$all_media)
 [1] "brandott_S_alphas" "brandott_S_gammas" "brandott_S_thetas" "brandtv_S_alphas"  "brandtv_S_gammas"  "brandtv_S_thetas"  "bsearch_S_alphas"
 [8] "bsearch_S_gammas"  "bsearch_S_thetas"  "disc_S_alphas"     "disc_S_gammas"     "disc_S_thetas"     "drott_S_alphas"    "drott_S_gammas"
[15] "drott_S_thetas"    "drtv_S_alphas"     "drtv_S_gammas"     "drtv_S_thetas"     "fbprosp_S_alphas"  "fbprosp_S_gammas"  "fbprosp_S_thetas"
[22] "fbrmkt_S_alphas"   "fbrmkt_S_gammas"   "fbrmkt_S_thetas"   "native_S_alphas"   "native_S_gammas"   "native_S_thetas"   "nbsearch_S_alphas"
[29] "nbsearch_S_gammas" "nbsearch_S_thetas" "psoc_S_alphas"     "psoc_S_gammas"     "psoc_S_thetas"     "shop_S_alphas"     "shop_S_gammas"
[36] "shop_S_thetas"     "yt_S_alphas"       "yt_S_gammas"       "yt_S_thetas"  `

`hyperparameters <- list(
+    brandott_S_alphas= c(0.5, 3)
+   , brandott_S_gammas = c(0.3, 1)
+   , brandott_S_thetas = c(0, 0.8)
+   , brandtv_S_alphas= c(0.5, 3)
+   , brandtv_S_gammas = c(0.3, 1)
+   , brandtv_S_thetas = c(0, 0.8)
+   , bsearch_S_alphas = c(0.5 ,3)
+   , bsearch_S_gammas = c(0.3 ,1)
+   , bsearch_S_thetas = c(0, 0.4)
+   , disc_S_alphas = c(0.5, 3)
+   , disc_S_gammas = c(0.3, 1)
+   , disc_S_thetas = c(0, 0.8)
+   , drott_S_alphas= c(0.5, 3)
+   , drott_S_gammas= c(0.3, 1)
+   , drott_S_thetas= c(0, 0.8)
+   , drtv_S_alphas = c(0.5, 3)
+   , drtv_S_gammas = c(0.3, 1)
+   , drtv_S_thetas = c(0, 0.8)
+   , fbprosp_S_alphas = c(0.5, 3)
+   , fbprosp_S_gammas = c(0.3, 1)
+   , fbprosp_S_thetas = c(0, 0.8)
+   , fbrmkt_S_alphas = c(0.5, 3)
+   , fbrmkt_S_gammas = c(0.3, 1)
+   , fbrmkt_S_thetas = c(0, 0.9)
+   , native_S_alphas = c(0.5 ,3)
+   , native_S_gammas = c(0.3 ,1)
+   , native_S_thetas = c(0 ,0.8)
+   , nbsearch_S_alphas = c(0.5 ,3)
+   , nbsearch_S_gammas = c(0.3 ,1)
+   , nbsearch_S_thetas = c(0, 0.6)
+   , psoc_S_alphas = c(0.5 ,3)
+   , psoc_S_gammas = c(0.3 ,1)
+   , psoc_S_thetas = c(0 ,0.8)
+   , shop_S_alphas= c(0.5 ,3)
+   , shop_S_gammas= c(0.3 ,1)
+   , shop_S_thetas = c(0 ,0.4)
+   , yt_S_alphas = c(0.5 ,3)
+   , yt_S_gammas = c(0.3 ,1)
+   , yt_S_thetas = c(0 ,0.8)
+   )`

@kyletgoldberg

Hi - it looks like you are using a fairly old version of R, could you make sure to update that as well as ensure you are using the latest version of Robyn and let us know if that solves the issue?

Hi Kyle I updated my Version of R but I still get this error

I'm now on R.4.1.0

Have you installed the latest version of Robyn?

Yes Robyn 3.6.1 is what I am using. I am available if you'd like to hop on a quick zoom and I can show you / screen share in case you want to look at any other options

Issue was solved in an outside convo - was related to versioning issues

Hi @kyletgoldberg and @jsatani-tonal. I am facing same issue.
My R version is 4.1.3 and Robyn version is 3.6.1 on my system. Can you guys please help?

It is happening for both geometric and weibull adstocks. Can we connect over a call if you have some time?

can you share the error message?

Please have a look at the file shared, Thanks.

@kyletgoldberg I have the latest version of Robyn 3.6.2 and also checked that there aren't any NAs in my data. Can we do a screen share to have a quick look please?

Okay sure, Let me try and come back to you. If the issue is not resolved, can we connect tomorrow at your convenience?

@anuragvimal we hope to keep the discussions on the github so that any problem solving we go through is preserved for posterity, but please keep us posted on the debug status

@anuragvimal  were you able to resolve this issue? I still have this issue and I'm running Robyn 3.6.2 but using Weibull this time.

I did and it said I was up to date on the remotes, and also the debugger did not specify where the error is happening, everything went through fine! SO I am unsure what to do! I will try to restart my R again and maybe it will work this time.

@jsatani-tonal the weibull is working fine on my end when i run through demo.R so if you could run through the debug on the specific function erroring out similar to how we did before that would be helpful

@jsatani-tonal were you able to figure this out?

Restarting my R session seems to solve it
On Tue., Apr. 12, 2022, 7:36 a.m. kyletgoldberg, @.***>
wrote:

@jsatani-tonal https://github.com/jsatani-tonal were you able to figure
this out?
—
Reply to this email directly, view it on GitHub
https://github.com/facebookexperimental/Robyn/issues/359#issuecomment-1096813155,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASWNNNBU5BWSABLE5QBQTUTVEWC6TANCNFSM5SC6W3DQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@anuragvimal any updates?

@kyletgoldberg @jsatani-tonal  Sincere apologies for the late reply..I was able to fix the error by specifying the accurate date format in dt_holidays argument..While doing this, I had the latest version of R Studio and Robyn installed..Thanks for all your help..

I get this error "Error in object[[name, exact = TRUE]] : subscript out of bounds" too often.
My R version is 4.1.3 and I loaded Robyn in early March. I get the error when I successfully run a model. I save the file and rename it and I modify something in the input, usually dropping a media or context variable or changing the window dates. Sometimes, R lets me run a few different file versions. Sometimes, the error happens on the attempt of the 2nd run. It happens when I run the line "InputCollect <- robyn_inputs(InputCollect = InputCollect, hyperparameters = hyperparameters_list)".
Solutions tried: I changed the name of the hyperparameter list. I run the step 2b for setup in one step. I've restarted the computer. I've restarted RStudio. I resave the csv file with the appropriate date format. I've  deleted all objects from the global environment.
The problem happens when trying to add the hyperparameter list into InputCollect. It starts working again but I don't know why it randomly works and doesn't work. The restart worked in the past, but it's not letting me proceed now. I'm frustrated with RStudio and desperately waiting for an official all-Python version.

Hey @GrizzledLotus thanks for reporting this. You mentioned you loaded Robyn in early March, but have you tried updating it to the latest version/commit? Please try once again and let us know if it persists. If it does, can you share with us a minimum reproducible example (anonymized) to help you debug?

hyperparameters_list <- list(

Media_1_alphas = c(0.5, 3)
,Media_1_gammas = c(0.3, 1)
,Media_1_thetas = c(0, 0.3)

,Media_2_alphas = c(0.5, 3)
,Media_2_gammas = c(0.3, 1)
,Media_2_thetas = c(0, 0.3)

,Media_3_alphas = c(0.5, 3)
,Media_3_gammas = c(0.3, 1)
,Media_3_thetas = c(0.3, 0.8)

,Media_4_alphas = c(0.5, 3)
,Media_4_gammas = c(0.3, 1)
,Media_4_thetas = c(0, 0.3)

,Media_5_alphas = c(0.5, 3)
,Media_5_gammas = c(0.3, 1)
,Media_5_thetas = c(0, 0.3)

,Media_6_alphas = c(0.5, 3)
,Media_6_gammas = c(0.3, 1)
,Media_6_thetas =c(0, 0.3)

,Media_7_alphas = c(0.5, 3)
,Media_7_gammas = c(0.3, 1)
,Media_7_thetas = c(0, 0.3)

,Media_8_alphas = c(0.5, 3)
,Media_8_gammas = c(0.3, 1)
,Media_8_thetas = c(0, 0.3)

,Media_9_alphas = c(0.5, 3)
,Media_9_gammas = c(0.3, 1)
,Media_9_thetas = c(0, 0.3)

,Media_10_alphas = c(0.5, 3)
,Media_10_gammas = c(0.3, 1)
,Media_10_thetas = c(0.1, 0.4)
)

InputCollect <- robyn_inputs(

dt_input = data_file
,dt_holidays = dt_prophet_holidays
,date_var = "MediaWeek" # date format must be "2020-01-01"
,dep_var = "TotalSales" # there should be only one dependent variable
,dep_var_type = "revenue" # "revenue" or "conversion"
,prophet_vars = c("trend", "season") # "trend","season", "weekday" & "holiday"
,prophet_country = "US"# input one country. dt_prophet_holidays includes 59 countries by default
,context_vars = c("context_1",

                "context_2",

                "Holiday_1",

                "Holiday_2",

                "Holiday_3",

                "Holiday_4",

                "Holiday_4",

                "Holiday_5",

                "Holiday_6",

                "Holiday_7",

                "Holiday_8",

                "Promo_1",

                "Promo_2",

                "Promo_3",

                "Promo_4",

                "Promo_5",

                "Promo_6"

) # e.g. competitors, discount, unemployment etc
,paid_media_spends = c("Media_1",

                     "Media_2",

                     "Media_3",

                     "Media_4",

                     "Media_5",

                     "Media_6",

                     "Media_7",

                     "Media_8",

                     "Media_9",

                     "Media_10") # mandatory input

,paid_media_vars = c("Media_1",

                   "Media_2",

                   "Media_3",

                   "Media_4",

                   "Media_5",

                   "Media_6",

                   "Media_7",

                   "Media_8",

                   "Media_9",

                   "Media_10") # mandatory.

paid_media_vars must have same order as paid_media_spends. Use media exposure metrics like

impressions, GRP etc. If not applicable, use spend instead.

#,organic_vars = c("newsletter") # marketing activity without media spend
#,factor_vars = c("events") # specify which variables in context_vars or organic_vars are factorial
,window_start = "20yy-mm-dd"
,window_end = "20yy-mm-dd"
,adstock = "geometric" # geometric, weibull_cdf or weibull_pdf.
,hyperparameters = hyperparameters_list # as in 2a-2 above
#,calibration_input = dt_calibration # as in 2a-4 above
)

Error in object[[name, exact = TRUE]] : subscript out of bounds
In addition: Warning message:
In check_datadim(dt_input, all_ind_vars, rel = 10) :
There are 29 independent variables & 212 data points. We recommend row:column ratio of 10 to 1

Ok, I'd need data_file as well to be able to replicate @GrizzledLotus

give me a few minutes to change the names and values

data_file.csv
@laresbernardo here's the file

Thanks.
Note: You have duplicated variable names for dt_input in different parameters. Check: Holiday_4
I was able to create the InputCollect object with your script, but I see no error:
> InputCollect
Total Observations: 208 (weeks)
Input Table Columns (12):
  Date: DATE
  Dependent: revenue [revenue]
  Paid Media: tv_S, ooh_S, print_S, facebook_I, search_clicks_P
  Paid Media Spend: tv_S, ooh_S, print_S, facebook_S, search_S
  Context: competitor_sales_B, events
  Organic: newsletter
  Prophet (Auto-generated): trend, season, holiday on DE
  Unused:

Date Range: 2015-11-23:2019-11-11
Model Window: 2016-11-21:2018-08-20 (92 weeks)
With Calibration: TRUE
Custom parameters: None

Adstock: geometric
Hyper-parameters for media transformations:
  facebook_S_alphas: [0.5, 3]
  facebook_S_gammas: [0.3, 1]
  facebook_S_thetas: [0, 0.3]
  print_S_alphas: [0.5, 3]
  print_S_gammas: [0.3, 1]
  print_S_thetas: [0.1, 0.4]
  tv_S_alphas: [0.5, 3]
  tv_S_gammas: [0.3, 1]
  tv_S_thetas: [0.3, 0.8]
  search_S_alphas: [0.5, 3]
  search_S_gammas: [0.3, 1]
  search_S_thetas: [0, 0.3]
  ooh_S_alphas: [0.5, 3]
  ooh_S_gammas: [0.3, 1]
  ooh_S_thetas: [0.1, 0.4]
  newsletter_alphas: [0.5, 3]
  newsletter_gammas: [0.3, 1]
  newsletter_thetas: [0.1, 0.4]

Can you try deleting the library and installing with remotes::install_github('facebookexperimental/Robyn/R')?

Thanks. Some notes following your script:

You have duplicated variable names for dt_input in different parameters. Check: Holiday_4
'window_start' must have format '2020-12-31'
column(s) not found: context_1, context_2
There are 26 independent variables & 212 data points. We recommend row:column ratio of 10 to 1

I was able to create the InputCollect object with your script, but I see no error:
> InputCollect
Total Observations: 212 (weeks)
Input Table Columns (57):
  Date: MediaWeek
  Dependent: TotalSales [revenue]
  Paid Media: Media_1, Media_2, Media_3, Media_4, Media_5, Media_6, Media_7, Media_8, Media_9, Media_10
  Paid Media Spend: Media_1, Media_2, Media_3, Media_4, Media_5, Media_6, Media_7, Media_8, Media_9, Media_10
  Context: Holiday_1, Holiday_2, Holiday_3, Holiday_4, Holiday_5, Holiday_6, Holiday_7, Holiday_8, Promo_1, Promo_2, Promo_3, Promo_4, Promo_5, Promo_6
  Organic:
  Prophet (Auto-generated): trend, season on US
  Unused: MarketBucket, FiscalYear, FiscalMonth, StoreSales, WebSales, Baseline_isJan, Baseline_isFeb, Baseline_isMar, Baseline_isApr, Baseline_isMay, Baseline_isJun, Baseline_isJul, Baseline_isAug, Baseline_isSep, Baseline_isOct, Baseline_isNov, Baseline_isDec, Baseline_isFY19, Baseline_isFY20, Baseline_isFY21, Baseline_isFY22, Holiday_9, Context_1, Context_2, Context_3, Context_4, Context_5, Promo_7, Media_0, Media_11, Media_12

Date Range: 2018-02-05:2022-02-21
Model Window: 2018-02-05:2022-02-21 (212 weeks)
With Calibration: FALSE
Custom parameters: None

Adstock: geometric
Hyper-parameters for media transformations:
  Media_1_alphas: [0.5, 3]
  Media_1_gammas: [0.3, 1]
  Media_1_thetas: [0, 0.3]
  Media_10_alphas: [0.5, 3]
  Media_10_gammas: [0.3, 1]
  Media_10_thetas: [0.1, 0.4]
  Media_2_alphas: [0.5, 3]
  Media_2_gammas: [0.3, 1]
  Media_2_thetas: [0, 0.3]
  Media_3_alphas: [0.5, 3]
  Media_3_gammas: [0.3, 1]
  Media_3_thetas: [0.3, 0.8]
  Media_4_alphas: [0.5, 3]
  Media_4_gammas: [0.3, 1]
  Media_4_thetas: [0, 0.3]
  Media_5_alphas: [0.5, 3]
  Media_5_gammas: [0.3, 1]
  Media_5_thetas: [0, 0.3]
  Media_6_alphas: [0.5, 3]
  Media_6_gammas: [0.3, 1]
  Media_6_thetas: [0, 0.3]
  Media_7_alphas: [0.5, 3]
  Media_7_gammas: [0.3, 1]
  Media_7_thetas: [0, 0.3]
  Media_8_alphas: [0.5, 3]
  Media_8_gammas: [0.3, 1]
  Media_8_thetas: [0, 0.3]
  Media_9_alphas: [0.5, 3]
  Media_9_gammas: [0.3, 1]
  Media_9_thetas: [0, 0.3]

Can you try deleting the library and installing with remotes::install_github('facebookexperimental/Robyn/R')?

I did my best to anonymize my data quickly.
i originally anonymized my copy and paste from RStudio and changed the dates to mm-dd etc. then i scrambled to change column names to fit. i apologize for the mismatch.
context_1 and context_2 were there
how do you recommend 10:1 row:column ratio at the same time as recommending a 6 to 18-month window to best capture recent media behavior? With weekly data that's 2.6 to 7.8 total allowed columns. I have 10-11 media columns alone. I'm pushing back on my media team to reduce variables, but it's been a hard sell. Plus, your own advice is to expand the medias into more granular sub-categories and your example on this page has 15 independent variables which would need almost 3 years of weekly data to fulfill your 10:1 recommendation.

I deleted my library. I reinstalled it using the remotes command you suggested. I had to manually install arules package in order to load reticulate. I still get the same error when trying to add hyperparameters to robyn_inputs, either as a separate step or all in one.

Don't worry, take your time to build the reproducible example so I can replicate the error you get by running exactly the code you share with me. We must be missing something given I haven't been able to replicate the error. And regarding the 10:1 recommendation, it's a rule of thumb more than a must. Maybe also consider combining those columns that are really sparse or low volume. And I noticed context_1 was actually Context_1, that's why it didn't find those columns.

GitHub_Help.txt
data_file.csv
I copied the R code into the text file attached. I ran the code and checked all the variable names and used the attached data_file.csv. I ran robyn_inputs both with and without the hyperparameter argument. I get the same 'subscript out of bounds error'.
I'm trying to persuade my company to use this modeling solution but I can't get it to run reliably to compare results to our current methodology. The code works. I have results, but then I make a change to the R file, or copy and paste into another folder to run another input file and I get this subscript error. Restarting worked once or twice, but now I've been stuck with this error and can't get it to run again.

Oh, I'm sorry to hear this! I ran your new shared code with no errors at all. Can you once again check if you have the latest version? packageDescription("Robyn")$GithubSHA1 should match "990aa8f768976b598e473ffdf9304e3242f76b7b". I can't seem to replicate this issue. Can you also share your sessionInfo()?

> packageDescription("Robyn")$GithubSHA1
[1] "990aa8f768976b598e473ffdf9304e3242f76b7b"
> sessionInfo()
R version 4.1.3 (2022-03-10)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19041)

Matrix products: default

Random number generation:
 RNG:     Mersenne-Twister
 Normal:  Inversion
 Sample:  Rounding

locale:
[1] LC_COLLATE=English_United States.1252  LC_CTYPE=English_United States.1252
[3] LC_MONETARY=English_United States.1252 LC_NUMERIC=C
[5] LC_TIME=English_United States.1252

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] arules_1.7-3 Matrix_1.4-0

loaded via a namespace (and not attached):
[1] compiler_4.1.3    generics_0.1.2    tools_4.1.3       remotes_2.4.2     grid_4.1.3        data.table_1.14.2
[7] lattice_0.20-45

my packageDescription output matches your expected value.

> InputCollect <- robyn_inputs(InputCollect = InputCollect, hyperparameters = hyperparameters_list)
Error in object[[name, exact = TRUE]] : subscript out of bounds
> sessionInfo()
R version 4.1.3 (2022-03-10)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows 10 x64 (build 19041)

Matrix products: default

Random number generation:
 RNG:     Mersenne-Twister
 Normal:  Inversion
 Sample:  Rounding

locale:
[1] LC_COLLATE=English_United States.1252  LC_CTYPE=English_United States.1252
[3] LC_MONETARY=English_United States.1252 LC_NUMERIC=C
[5] LC_TIME=English_United States.1252

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] reticulate_1.24 Robyn_3.6.2     arules_1.7-3    Matrix_1.4-0

loaded via a namespace (and not attached):
 [1] Rcpp_<IP_ADDRESS>       rpart.plot_3.1.0   lubridate_1.8.0    lattice_0.20-45    tidyr_1.2.0
 [6] png_0.1-7          lares_5.1.2        glmnet_4.1-4       digest_0.6.29      foreach_1.5.2
[11] utf8_1.2.2         R6_2.5.1           plyr_1.8.7         ggridges_0.5.3     httr_1.4.2
[16] ggplot2_3.3.5      pillar_1.7.0       rlang_1.0.2        lazyeval_0.2.2     rstudioapi_0.13
[21] data.table_1.14.2  nloptr_2.0.0       rpart_4.1.16       splines_4.1.3      stringr_1.4.0
[26] igraph_1.3.0       RCurl_1.98-1.6     munsell_0.5.0      compiler_4.1.3     pkgconfig_2.0.3
[31] shape_1.4.6        rPref_1.3          tidyselect_1.1.2   tibble_3.1.6       codetools_0.2-18
[36] fansi_1.0.3        crayon_1.5.1       dplyr_1.0.8        bitops_1.0-7       grid_4.1.3
[41] jsonlite_1.8.0     gtable_0.3.0       lifecycle_1.0.1    magrittr_2.0.3     pROC_1.18.0
[46] scales_1.2.0       RcppParallel_5.1.5 zip_2.2.0          cli_3.2.0          stringi_1.7.6
[51] doRNG_1.8.2        remotes_2.4.2      doParallel_1.0.17  xml2_1.3.3         ellipsis_0.3.2
[56] generics_0.1.2     vctrs_0.4.1        openxlsx_4.2.5     iterators_1.0.14   tools_4.1.3
[61] prophet_1.0        glue_1.6.2         purrr_0.3.4        rngtools_1.5.2     parallel_4.1.3
[66] survival_3.2-13    yaml_2.3.5         colorspace_2.0-3   h2o_<IP_ADDRESS>       rvest_1.0.2
[71] minpack.lm_1.2-2   patchwork_1.1.1

sorry. i ran the SessionInfo() first thing this morning before rerunning the code from last night. Here's the state right after i get the error.

@GrizzledLotus I ran the the code with your file as well this morning and didn't get any errors which makes it difficult for us to debug on our end. I think the best path forward would be if you could run debug(robyn_inputs) and then run the function again and go through the debug to see at which line the error is actually being fired since we can't reproduce on our end. Thanks for your patience here

I'm sorry. I don't  know how to interpret the debug() function. I tried it on Friday, but it highlights different section of code and then ends. I'll see if I have time to read up on the debug() function. It doesn't matter, I now get a different error message this morning. After shutting down my computer for the weekend and clearing the global environment in RStudio, I get this error message after running the same script for the same data file: ```
Error in check_datevar(dt_input, date_var) :
You must provide only 1 correct date variable name for 'date_var'

@GrizzledLotus what does your date_var have in it when you get that error?


re-enable RGB camera after FL calibration

re-enable RGB camera after FL calibration is over or dismissed.
LRS-852

Implementation replaced, see PR#12204


Integration tests in Github Actions freeze and cause timeout when triggered via a PR.

Description
In my workflow, we have two kinds of tests, unit tests and integration tests.
We trigger this workflow everytime there's a pull request to branch develop, or a direct push to develop.
The problem happens when  the workflow is triggered by a Pull request, not a direct push!
Unit tests always works fine in, but when it comes to integration tests, the workflow freezes until the 6 hours limit is reached.
note that all tests work fine locally and when the workflow is triggered by a direct push rather than a pull request
Virtual environments affected

[ ] Ubuntu 18.04
[X] Ubuntu 20.04
[ ] macOS 10.15
[ ] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Here's an example of a freezing workflow, triggered by a PR (yesterday), it froze until the timeout was reached.
https://github.com/stratosphereips/StratosphereLinuxIPS/runs/5006003607?check_suite_focus=true
Here's an example of the same tests running perfectly fine, triggered by a push to a branch (yesterday)
https://github.com/stratosphereips/StratosphereLinuxIPS/runs/5060242253?check_suite_focus=true
Here's another example of the same tests, triggered by a PR. (a week ago ago)!
everything was working fine and all integration tests (The job is called Test all files in our dataset) took 30 minutes to finish.
https://github.com/stratosphereips/StratosphereLinuxIPS/runs/4982459765?check_suite_focus=true
Is it regression?
No response
Expected behavior
No response
Actual behavior
No response
Repro steps

Clone the repo and create a new branch
git clone https://github.com/stratosphereips/StratosphereLinuxIPS && git checkout -b new_branch origin/develop

Make any change to your branch and open a pull request to branch origin/develop
NOTE: please open a PR to origin/develop not origin/master to be able to trigger the same workflow.

See the details of the required checks.

Hello @AlyaGomaa. Thank you for your report. We will take a look.

Hello @AlyaGomaa!
I was able to reproduce the issue and it's really weird behavior of the pull_request trigger. I tried to start the workflow using other PR related triggers like pull_request_review_comment and that also results in a build timeout error, but if I run build manually with workflow_dispatch everything works as expected.
As far as I can see, there were no changes on the Ubuntu-20.04 image between your successful build and the failed build, because both have the same image version - 20220123.1 (you can find it in Set up job of build log: Set up job -> Virtual Environment -> Version).
So it looks like changes from virtual-environments side did not affect your builds and we can suggest you to make a request in GitHub Support Community.

Hello @nikita-bykov
I opened a request and will update this issue with the solution if found.
Thank you.

Closing since issue is not related to images


Made window focus notification docs more precise

The previous doc was problematic:

In the case of a Window-node, the previous doc was misleading
The notification is also used for embedded (non-OS) window focus changes

Thanks!


Vercel deployment fails with TypeError related to RSS

Vercel deployment fails with below error, using latest Pliny:
[09:25:11.512] TypeError: String.prototype.replace called on null or undefined
[09:25:11.513]     at replace (<anonymous>)
[09:25:11.513]     at escape (file:///vercel/path0/node_modules/pliny/chunk-ECOO6QVZ.js:12:30)
[09:25:11.513]     at generateRss (file:///vercel/path0/node_modules/pliny/utils/generate-rss.js:23:22)
[09:25:11.513]     at generateRSS (file:///vercel/path0/node_modules/pliny/utils/generate-rss.js:36:17)
[09:25:11.513]     at rss (file:///vercel/path0/scripts/rss.mjs:6:3)
[09:25:11.513]     at postbuild (file:///vercel/path0/scripts/postbuild.mjs:6:22)
[09:25:11.513]     at file:///vercel/path0/scripts/postbuild.mjs:9:1
[09:25:11.513]     at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
[09:25:11.513]     at async Promise.all (index 0)
[09:25:11.513]     at async ESMLoader.import (node:internal/modules/esm/loader:530:24)

To Reproduce
Steps to reproduce the behavior:

Generate a new Pliny app
Deploy to Vercel
See error

Workaround
Vercel deployment will succeed after making these changes:

Disable RSS in components/SEO.tsx:
  {/* <Head>
    <link
      rel="alternate"
      type="application/rss+xml"
      title={`${description} - RSS feed`}
      href={`${siteMetadata.siteUrl}${router.asPath}/feed.xml`}
    />
  </Head> */}

Disable RSS in scripts/postbuild.mjs
async function postbuild() {
  // await Promise.all([rss(), sitemap(), search()])
  await Promise.all([sitemap(), search()])
}

Thanks, will have a further look into this one over the next few days

Don't seem to be getting any error from a freshly clone version. You can see an example over at https://github.com/timlrx/test-deployment

Thanks, I will check somewhere this week 💃

Fixed in<EMAIL_ADDRESS>👍


coturn: <IP_ADDRESS> -> <IP_ADDRESS>

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/coturn/coturn/releases.
meta.description for coturn is: "A TURN server"
meta.homepage for coturn is: "https://coturn.net/"
meta.changelog for coturn is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found <IP_ADDRESS> with grep in /nix/store/bs9m7nwd5yk3ll41209jlnavipfyxkhz-coturn-<IP_ADDRESS>

directory tree listing: https://gist.github.com/317c2e2b1c93344a2515e31b01698c36

du listing: https://gist.github.com/e1a44f204f48b413995e8518ce3574d2

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
coturn

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bs9m7nwd5yk3ll41209jlnavipfyxkhz-coturn-<IP_ADDRESS> \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A coturn https://github.com/r-ryantm/nixpkgs/archive/5c67b5ef94dca705d566a945ad841458e52a94d6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bs9m7nwd5yk3ll41209jlnavipfyxkhz-coturn-<IP_ADDRESS>
ls -la /nix/store/bs9m7nwd5yk3ll41209jlnavipfyxkhz-coturn-<IP_ADDRESS>/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package marked as broken and skipped:
- couchdb

1 package built:
- coturn

Maintainer pings
cc @ralith for testing.

Why was this closed?

@Ralith buggy bot


If a user is a member of a group of groups, please include the granular groups in the tokens

What version of UAA are you running?
4.14.x
How are you deploying the UAA?
I am deploying the UAA

Using our own internal tooling.

What did you do?

I created group A,B,C,D.
I created group ROLE_A
I added A,B,C,D as members of ROLE_A
I added user TOM as a member of group ROLE_A

What did you expect to see? What goal are you trying to achieve with the UAA?
I was expecting the tokens to include A,B,C,D scopes instead of just ROLE_A
I would like the applications enforcing permissions to not have to know about user-defined groups but individual and more granular scopes.
What did you see instead?
I got JWT tokens with scope ROLE_A :/

Closing due to inactivity.


MAAS Integration with LXD 3.0.0

Required information

Distribution: Ubuntu
Distribution version: 18.04
The output of "lxc info" or if that fails:

config:
  core.https_address: '[::]:8443'
  core.trust_password: true
  maas.api.key: MK4Qp5GKDLjUu2khVh:Fa9bjsD37tsANX3Hpr:YMdnsak5Ete2ypqqK3etvrr3cEA4pXhG
  maas.api.url: http://<IP_ADDRESS>:5240/MAAS
api_extensions:
- storage_zfs_remove_snapshots
- container_host_shutdown_timeout
- container_stop_priority
- container_syscall_filtering
- auth_pki
- container_last_used_at
- etag
- patch
- usb_devices
- https_allowed_credentials
- image_compression_algorithm
- directory_manipulation
- container_cpu_time
- storage_zfs_use_refquota
- storage_lvm_mount_options
- network
- profile_usedby
- container_push
- container_exec_recording
- certificate_update
- container_exec_signal_handling
- gpu_devices
- container_image_properties
- migration_progress
- id_map
- network_firewall_filtering
- network_routes
- storage
- file_delete
- file_append
- network_dhcp_expiry
- storage_lvm_vg_rename
- storage_lvm_thinpool_rename
- network_vlan
- image_create_aliases
- container_stateless_copy
- container_only_migration
- storage_zfs_clone_copy
- unix_device_rename
- storage_lvm_use_thinpool
- storage_rsync_bwlimit
- network_vxlan_interface
- storage_btrfs_mount_options
- entity_description
- image_force_refresh
- storage_lvm_lv_resizing
- id_map_base
- file_symlinks
- container_push_target
- network_vlan_physical
- storage_images_delete
- container_edit_metadata
- container_snapshot_stateful_migration
- storage_driver_ceph
- storage_ceph_user_name
- resource_limits
- storage_volatile_initial_source
- storage_ceph_force_osd_reuse
- storage_block_filesystem_btrfs
- resources
- kernel_limits
- storage_api_volume_rename
- macaroon_authentication
- network_sriov
- console
- restrict_devlxd
- migration_pre_copy
- infiniband
- maas_network
- devlxd_events
- proxy
- network_dhcp_gateway
- file_get_symlink
- network_leases
- unix_device_hotplug
- storage_api_local_volume_handling
- operation_description
- clustering
- event_lifecycle
- storage_api_remote_volume_handling
- nvidia_runtime
api_status: stable
api_version: "1.0"
auth: trusted
public: false
auth_methods:
- tls
environment:
  addresses:
  - <IP_ADDRESS>:8443
  - <IP_ADDRESS>:8443
  - <IP_ADDRESS>:8443
  architectures:
  - x86_64
  - i686
  certificate: |
    -----BEGIN CERTIFICATE-----
    MIIFTDCCAzSgAwIBAgIQSkN0jYBB/wT0hHA2QbzeDDANBgkqhkiG9w0BAQsFADA0
    MRwwGgYDVQQKExNsaW51eGNvbnRhaW5lcnMub3JnMRQwEgYDVQQDDAtyb290QG5v
    ZGUxNDAeFw0xODA2MDcxNDQ1NTRaFw0yODA2MDQxNDQ1NTRaMDQxHDAaBgNVBAoT
    E2xpbnV4Y29udGFpbmVycy5vcmcxFDASBgNVBAMMC3Jvb3RAbm9kZTE0MIICIjAN
    BgkqhkiG9w0BAQEFAAOCAg8AMIICCgKCAgEApEg+hGwilADwr4WxMOg++PkqRkZL
    mGvLUEPZH2VvpWP2kcGhu5zlZth3an9hyzAMmKsx9g6/1m1Uwcwe+5FcB/Phc9r/
    lU8h5rK2IL5ABnR4Rck+4dAEFiRWnGAhv5hgPCA9W5BZrxkthcSFh5voO3twIU+i
    qiO2Lu/Y9mC0frZfN0kcScjQ2ZfT57nFG7opxK3ugI8CRdDaBzU4yk6hvBgK5nIs
    RJF+JKX56MTvQWYc1F4wPiZ0HX1MNw413sIWu4q0YHg55U10f24F6TO9ZdyKYPF/
    4uBoiLOniWHT/Vgg7gHKVIZT3/0YNl9s5PJ+nLHbwLn9/xlJ9LEhHBJtfJl2rqAJ
    zIhIjkOQX2C0tG5sXRLEidthiSagJ1rzeFAlSXrCh5R+jHa501d9SUV4bDSQ2YWl
    UKTODWNvjkLqyohsevhNCa54vZeN5t3brsoeFYGcW82pzFspKOrpo4c+GHwu7zpT
    ENrqUTMHBc9o9Il1irTGWqcS9PMV7BZQkBAniHWhOIUCIex0Uc4m08wk+cw36+pu
    BY14aZrwPMGauMVJQxJXGqIHUyQXQBOCV3TvTWaBUCHNrnCd/7v8IvFlNE6Pzm8z
    71a86Vaa01nYZsHsITi7SDfDnlawmaPZkCxgdtZ9wpZMzj6wkaNhdCgtVUe+yvwY
    8bEuAYa+OdIhAakCAwEAAaNaMFgwDgYDVR0PAQH/BAQDAgWgMBMGA1UdJQQMMAoG
    CCsGAQUFBwMBMAwGA1UdEwEB/wQCMAAwIwYDVR0RBBwwGoIGbm9kZTE0hwQKHjwO
    hwQKAwQOhwTAqHoBMA0GCSqGSIb3DQEBCwUAA4ICAQAUygRrcbtsmUsvnVkEY6Oh
    ROUNQ86YYtJRYoc5vpl2kYYIAykn80qdXlHImPSP1iXJ1IOz5/KPL/MG909wJ0Vx
    DStyhQrejCEhZwk4yEoT2L/jOqffhG/y+XX1ALGhaaLMR0Y66Kek+mu8o4F5Y7De
    cJuwedgbKGnFYMw7uHJaxf1forfaxa6EHz+C+iTkN4ZiOUD6o18Rs+Uun0EhJ4UV
    F2H5J07ewqOEscczlT9G9ADAckShC2EF1zyDkZL8clnNNnuKBF9a+VkA3YFcFVaB
    tawCVQ/GyymKMmflZgIMaKtF245eA6HnlYjGhFiiJYHXjg4Tq96RyHzLupsFsome
    c5vsBS7BO12EWnavM233sJfcHMeBZi6Pds56SG5nHWW4dFWBYaXyf5aMoN9zqAda
    qhi3gb+yiFF5hoVkdVUigGEgKN1xQ7tEOZNADjVNibtk3p7yjRU/niD0uKn2Z5oU
    njUqjmkvTgt5eg8lcpA1xc1gwyMklXfI3gWiyXXuW75K6B7K3qmgUVcOB08SpFo9
    fYUNN5+7Wu7TsFI7N8PCPbZCtHeGADXpOP3eJgXUy0r5bnFmDToEI+ba/2gRuovS
    nB3BzoDM3GLNwdrwQ4MszaOk7NM+oxbkzzvWkuWhQCDH1VE0/tpHx5uJ/I5UQCiE
    t/T//ph0eyDSmGxVJP7SLw==
    -----END CERTIFICATE-----
  certificate_fingerprint: 2f791d30b593586a6f11a8417d591585601c38f0199761d8d6a6a7931aed0450
  driver: lxc
  driver_version: 3.0.0
  kernel: Linux
  kernel_architecture: x86_64
  kernel_version: 4.15.0-22-generic
  server: lxd
  server_pid: 7254
  server_version: 3.0.0
  storage: btrfs
  storage_version: 4.15.1
  server_clustered: true
  server_name: node14

Issue description

lxd init fails

config:
  core.https_address: '[::]:8443'
  core.trust_password: *******
  maas.api.key: MK4Qp5GKDLjUu2khVh:Fa9bjsD37tsANX3Hpr:YMdnsak5Ete2ypqqK3etvrr3cEA4pXhG
  maas.api.url: http://<IP_ADDRESS>:5240
cluster:
  server_name: node14
  enabled: true
  cluster_address: ""
  cluster_certificate: ""
  cluster_password: ""
networks: []
storage_pools:
- config:
    source: /data/bpool/local
  description: ""
  name: local
  driver: btrfs
profiles:
- config: {}
  description: ""
  devices:
    eth0:
      maas.subnet.ipv4: <IP_ADDRESS>/24
      name: eth0
      nictype: bridged
      parent: br161
      type: nic
    root:
      path: /
      pool: local
      type: disk
  name: default

Error: Failed to update server configuration: unsupported version: ServerError: 404 Not Found (

  <title>404 - No Such Resource</title>

No Such Resource

No such child resource.

)

This happened after an apt update and apt upgrade . I reinstalled the server using MAAS, and then didn;t do the apt update and apt upgrade and could register successfully
Later I realized that the MAAS URL was incorrect, when I added /MAAS it worked fine.  the problem was discovered after I used the yaml file in another server that was already upgradede with apt.
Maybe the request is a meaningful message if the MAAS server can't be contacted, or the URL is incorrect.

second error. If I try to move the container to a second node in another cluster, it gives me a MAAS error:

root@node14:~# lxc image copy ubuntu:b local: --copy-aliases --auto-update
If this is your first time running LXD on this machine, you should also run: lxd init
To start your first container, try: lxc launch ubuntu:16.04

Image copied successfully!
root@node14:~# lxc launch local:b test-161
Creating test-161
Error: {"hostname": ["Node with this Hostname already exists."]}
root@node14:~#  #### DELETED THE NODE FROM THE MAAS DNS STATIC ASSINGMENT ON ANOTHER LXD HOST.
root@node14:~# lxc launch local:b test-161
Creating test-161
Starting test-161
root@node14:~# lxc list
+----------+---------+------+------+------------+-----------+----------+
|   NAME   |  STATE  | IPV4 | IPV6 |    TYPE    | SNAPSHOTS | LOCATION |
+----------+---------+------+------+------------+-----------+----------+
| test-161 | RUNNING |      |      | PERSISTENT | 0         | node14   |
+----------+---------+------+------+------------+-----------+----------+

I had to manually start the bridge
https://bugs.launchpad.net/ubuntu/+source/nplan/+bug/1736975
This is how the bridge is automatically created from MAAS deployment on the node, it is indeed an anonymous bridge. I don't want a local IP, since I just want to use it for containers
Can LXD team help, push this bug to be fixed in netplan?  Please!! 👍
        br161:
            interfaces:
            - eno1.161
            parameters:
                forward-delay: 15
                stp: false

root@node14:~# ip link show br161
6: br161: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN mode DEFAULT group default qlen 1000
    link/ether 5a:82:fb:8e:ee:82 brd ff:ff:ff:ff:ff:ff
root@node14:~# ip link set up br161
root@node14:~# ip link show br161
6: br161: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP mode DEFAULT group default qlen 1000
    link/ether 5a:82:fb:8e:ee:82 brd ff:ff:ff:ff:ff:ff
root@node14:~# lxc start test-161
root@node14:~# lxc list
+----------+---------+---------------------+------+------------+-----------+----------+
|   NAME   |  STATE  |        IPV4         | IPV6 |    TYPE    | SNAPSHOTS | LOCATION |
+----------+---------+---------------------+------+------------+-----------+----------+
| test-161 | RUNNING | <IP_ADDRESS> (eth0) |      | PERSISTENT | 0         | node14   |
+----------+---------+---------------------+------+------------+-----------+----------+

Now.. second error, trying to move the container from one cluster to another cluster (each node an independent cluster.
root@node14:~# lxc move test-161 node15:
Error: Failed container creation: {"mac_addresses": ["MAC address 00:16:3e:24:68:67 already in use on test-161."], "hostname": ["Node with this Hostname already exists."]}
root@node14:~# lxc move test-161 node15:test-161-15
Error: Failed container creation: {"mac_addresses": ["MAC address 00:16:3e:24:68:67 already in use on test-161."]}

Steps to reproduce
First error (lxd init)

fresh cloud image install of Ubuntu 18.04,
apt update apt upgrade
lxd init with the given info (do not put the /MAAS in the MAAS URL )

Second error (MAAS integration, moving containers)

create two LXD hosts both cluster (I used the preseed of the first on the second one, Both registered on MAAS, but not part of the same cluster.

create a new container in node1

lxc add remote node2 IP

lxc move CONTAINER node2:

For the first part of the issue, there's no a lot we can do. You entered a bad URL and we showed the error that we're getting from the Go MAAS API client. I agree that those errors aren't pretty but it's not our code so there's not a lot we can do there.
We can't assume that you're missing /MAAS either because there are setups (including our own test MAAS) where the URL is different (when using reverse proxies).

The second issue is also not something we can fix as it's simply MAAS enforcing that there not be duplicate MAC addresses on the network and so refuses to let you copy the container.
You should be able to workaround this by passing -c volatile.eth0.hwaddr=SOME-OTHER-MAC, effectively causing the container copy to have a different MAC address which should then make MAAS happy.
After the move is successful and the source container gets deleted, you can then set the MAC back to the original value if you want, which may or may not result in MAAS giving you the same IP again.

Correct, it is a MAAS error, but maybe a nicer error, like MAAS server couldnt be reached would be nicer.
the netplan part, there is a workaround but ugly for 25 rack servers + 40 IBM blades with LXD. (Love the scripting for creating containers and executing commands in the containers, using pdsh and some custom scripts)
I experienced some instability with clusters if one went down, so I decided not to give them a try yet. that is why I am using separate clusters (one node each).  I dont have the time now.
But I am moving the container, not copying it.  I guess a copy and then delete would work, that would recreate it with a different MAC address, but I would have to use a different name
root@node14:~# lxc move test-161 test-161-2
root@node14:~# lxc move test-161-2 node15:
Error: Failed container creation: {"mac_addresses": ["MAC address 00:16:3e:24:68:67 already in use on test-161-2."], "hostname": ["Node with this Hostname already exists."]}
root@node14:~#

As you can see the first move within the same node works fine. and the name is also updated in MAAS
but the second one fails.  it is just unnatural if I want to preserve the name on a different host.  I understand that the copy mechanism is doing a temporary snapshot, copying the snapshot and then delete the information.
Can't the lxc move command do the MAC address trick ?

In a way, in the first command you do

unregister from MAAS
change of name with the same MAC
register in MAAS

on the second case you do:

snapshot, copy
register with the same MAC on MAAS --> Fails
delete of the original container in the original node

MAAS resgistration should be after the first container name is unregistered from MAAS as in the first move within the same node, shouldn't it?

Yes, lxc move should work fine with -s, that's because there is no such thing as a "move" in the API.
The client tool actually does a copy of the container from the first server to the second and then if that worked well, asks the source server to delete the container.
The local lxc move is a single API call that tells LXD to rename the container, so when doing that, you never have two containers with the same MAC, MAAS simply gets told that the container changed name.

Sorry.. I didn't get the -s part .. I don't see that flag in lxc move.
Adding a temp MAC address on the move every time you are moving a container frm one node to another is not usable.  specially in large deployments where you are not using openstack/juju.  how does openstack/juju solution work for moving a container form one node to another?
Thanks for the quick response.

Oops, sorry, meant -c, not -s and yeah, for some reason it's missing in lxc move, we'll fix that as there's no reason for it not to be allowed when moving a container between two servers (it won't work when renaming a container locally though).

For now, you can do lxc copy -c followed by lxc delete of the source container, which is effectively what lxc move does for you internally.

thank you.
I would appreciate if at some point in the long run there is a better alternative since as a feature request.  since for large deployments this is not manageable.  (although sometimes I do it, a copy and then update the MAC in case I want the same address at another node and shutting down the first one)

I'm working on fixing lxc move now to let you override configuration that way.
For LXD allowing you to move between two unrelated systems connected to the same MAAS without needing the config trick, I don't expect this to really ever be possible. But in the case where both systems are part of a LXD cluster, it should be possible and #4546 should help with that.

I added the following comment on the other issue
I found out that if I move a container that overrides the default profile where the MAAS networking information is, with its own set of eth0 networking without the MAAS information, the containers moves without a problem
ubuntu@node38:~$ lxc profile show default
config: {}
description: Default LXD profile
devices:
  eth0:
    **maas.subnet.ipv4: <IP_ADDRESS>/23**
    name: eth0
    nictype: bridged
    parent: br1
    type: nic
  root:
    path: /
    pool: default
    type: disk
name: default
used_by:
- /1.0/containers/maas-icts
ubuntu@node38:~$ lxc profile show maas
config:
  raw.lxc: |-
    lxc.cgroup.devices.allow = c 10:237 rwm
    lxc.apparmor.profile=unconfined
    lxc.cgroup.devices.allow = b 7:* rwm
  security.privileged: "true"
description: Default LXD profile
devices:
  eth0:
    name: eth0
    nictype: bridged
    parent: br1
    type: nic

Then, in theory, I can remove the MAAS networking configuration of the container in the target node, move the container without any issue, then add the container networking configuration.
Seems awkward but works. and I dont have to invent a MAC address every time I am moving a container
Still I believe this should be handled by LXD somehow at some point.  it is just not user fiendly and even tough lxd move command local and remote implementations are different, de behaviour should be the same

So not to affect other containers that are not being moved, for moving a container from one node to another node whose LXD are registered with MAAS,  Assuming that you are using default profile created with MAAS integration
The workaround thgat best suited for me is

Disable MAAS integration of the container by overriding eth0 with no MAAS integration (the container will be removed from MAAS DNS)
Move the container
Enable again the MAAS integration by not overriing the eth0 and using the default MAAS integrated one

Although somehow I feel that this should be done automatically and transparent for the user
lxc move c1 c2 and lxc move c1 host:c1 or lxc move c1 host:c2 should all of them have the same behaviour independently of MAAS or clustering


Windows 10 Version 1607 causes camera to crash

Required Info

Camera Model
SR300

Firmware Version
1.15.00 /  1.17.00

Operating System & Version
Windows 10 : version 1607	os build 14393.51

Build System
VS2015

The librealses seems to have problems with the recent windows 10 Build (version 1607) release on the 2.8.2016 .
I experince some random crashes of the camera. I could not pin done the exact line causing the issue but would recommand not to update to the current build yet.
(In case someone experinces the same problem, there is an option to revert the system back to the latest build ( without reinstalling the system). Officialy not available after 10 days with the new build.
UPDATE:
I testet this issue on different maschines :

Running old build of win 10 -> no problems with firmeware 1.15 /1.17
Running current build of win 10 -> error while init camera and set parameters
-> After reset to old build of win 10 -> no problems with firmeware 1.15 /1.17 anymore.
Running current old build of win 10 ->  no problems with firmeware 1.15 /1.17
-> After installing current build ->  error while init camera and set parameters

So this problems seems to be connected to the current windows build.
The error seems to be thrown here [uvc.wmf line 564] (https://github.com/IntelRealSense/librealsense/blob/master/src/uvc-wmf.cpp#L564)
when setting a F200/SR300 parameter.
ks_control->KsProperty((PKSPROPERTY)&node, sizeof(KSP_NODE), data, len, nullptr)
allways returns -2147467261 (HRESULT : E_POINTER Invalid pointer. ) which indicates an error.
Same program with previos build returns 0 (indicates no error).
If i do ignore those error some parameters are still beeing set to the camera. However it is not possible to check if it was executed correctly ( which usually results in a retry till it worked)
Is it possible, that some interfaces were changed at this point (windows side) ?

SOLVED:
Problem was that
ks_control->KsProperty((PKSPROPERTY)&node, sizeof(KSP_NODE), data, len, nullptr) does not accept nullpointer anymore. Changed to
ULONG bytes_received = 0;
check("IKsControl::KsProperty", ks_control->KsProperty((PKSPROPERTY)&node, sizeof(KSP_NODE), data, len, &b

Thank you, we'll make sure to integrate the fix


Allow entities moving to each other by the ratio of their max HP

This is really a nice mod and i like it, would you like to make it more "physical"?
From the theorem of momentum we know that $Ft = mv$, so $\frac {v_1} {v_2}=\frac {HP_2}{HP_1}$, I would love it if you made this too!

and what about considering the absorbing effect as well? If players eat goolden apple they will be pulled shorter.

You could take this one step further and just consider the hitbox size