the embedding_lookup() returns zeros when the index exceed embedding matrix size?

NOTE: Only file GitHub issues for bugs and feature requests.  All other topics will be closed.
I wrote an issues a month ago about the same problem #5260
I recently update the TF to latest master branch(0.11.head) without any custom modification and the commit hash is 55dbc54192a378c5e685c52595f42503f037320e
The tf.embedding_lookup() still do not raise error even though the index is exceeding the embedding matrix size. It automatically fills zeros as you can see in the below example.
I tested same code with two different machines and the result was same.
In the previous issue(#5260), @strategist333 said it raise an InvalidArgumentError in binary release.
But when I tested TF installed from source, it didn't...
 import tensorflow as tf
 import numpy as np

 embd_mat = np.linspace(1,10,10).reshape([10,1])*np.array([1,2,3]).reshape([1,3])
 idx = np.linspace(0,19,20)

 embd_in = tf.placeholder(tf.float32,[10,3])
 idx_in = tf.placeholder(tf.int32,[20])

 output = tf.nn.embedding_lookup(embd_in,idx_in)

 with tf.Session() as sess:
     sess.run(tf.initialize_all_variables())

     embd_out = sess.run(output,feed_dict={embd_in:embd_mat, idx_in:idx})

     print embd_out

The output of above code is,
[[  1.   2.   3.]
 [  2.   4.   6.]
 [  3.   6.   9.]
 [  4.   8.  12.]
 [  5.  10.  15.]
 [  6.  12.  18.]
 [  7.  14.  21.]
 [  8.  16.  24.]
 [  9.  18.  27.]
 [ 10.  20.  30.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]]

BTW, the binary release 0.11rc0 (Linux CPU version) does raise an error:
InvalidArgumentError (see above for traceback): indices[10] = 10 is not in [0, 10)
	 [[Node: embedding_lookup = Gather[Tindices=DT_INT32, Tparams=DT_FLOAT, _class=["loc:@Placeholder"], validate_indices=true, _device="/job:localhost/replica:0/task:0/cpu:0"](_recv_Placeholder_0, _recv_Placeholder_1_0)]]

Thanks for the answer. But it's weird that it does not raise an error in source version... By the way, I'm using GPU.

Oh, that makes a difference. When using binary 0.11rc0 Linux GPU version, no error is raised and the same output as yours is returned:
[[  1.   2.   3.]
 [  2.   4.   6.]
 [  3.   6.   9.]
 [  4.   8.  12.]
 [  5.  10.  15.]
 [  6.  12.  18.]
 [  7.  14.  21.]
 [  8.  16.  24.]
 [  9.  18.  27.]
 [ 10.  20.  30.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]]

I have Cuda 7.5, CuDNN 5 and Tesla K40c GPU.

@foxik thanks for the testing. It seems it happens only on GPU version. I tested on two machines which are (Cuda 7.0, cuDNN4, Titan black) and (Cuda 8.0, cuDNN5, 1080). I think it should be fixed...

This is most likely due to differences between the CPU and GPU OpKernels for the embedding lookup, and your code doesn't constrain where the variables are placed, so they are possibly on CPU in one case and on GPU in the other.
You could validate this by adding log_device_placement=True to your session ConfigProto, or explicitly constrain the device placement of the variables.

@prb12 I changed the code as below as you suggested,
import tensorflow as tf
import numpy as np

config = tf.ConfigProto(log_device_placement=True)

with tf.device('/gpu:0'):
    embd_mat = np.linspace(1,10,10).reshape([10,1])*np.array([1,2,3]).reshape([1,3])
    idx = np.linspace(0,19,20)

    embd_in = tf.placeholder(tf.float32,[10,3])
    idx_in = tf.placeholder(tf.int32,[20])

    output = tf.nn.embedding_lookup(embd_in,idx_in)

with tf.Session(config=config) as sess:
    sess.run(tf.initialize_all_variables())

    embd_out = sess.run(output,feed_dict={embd_in:embd_mat, idx_in:idx})

    print embd_out

and the output is,
init: (NoOp): /job:localhost/replica:0/task:0/gpu:0
I tensorflow/core/common_runtime/simple_placer.cc:827] init: (NoOp)/job:localhost/replica:0/task:0/gpu:0
embedding_lookup: (Gather): /job:localhost/replica:0/task:0/gpu:0
I tensorflow/core/common_runtime/simple_placer.cc:827] embedding_lookup: (Gather)/job:localhost/replica:0/task:0/gpu:0
Placeholder_1: (Placeholder): /job:localhost/replica:0/task:0/gpu:0
I tensorflow/core/common_runtime/simple_placer.cc:827] Placeholder_1: (Placeholder)/job:localhost/replica:0/task:0/gpu:0
Placeholder: (Placeholder): /job:localhost/replica:0/task:0/gpu:0
I tensorflow/core/common_runtime/simple_placer.cc:827] Placeholder: (Placeholder)/job:localhost/replica:0/task:0/gpu:0
[[  1.   2.   3.]
 [  2.   4.   6.]
 [  3.   6.   9.]
 [  4.   8.  12.]
 [  5.  10.  15.]
 [  6.  12.  18.]
 [  7.  14.  21.]
 [  8.  16.  24.]
 [  9.  18.  27.]
 [ 10.  20.  30.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]
 [  0.   0.   0.]]

What happens when you constrain to /cpu:0 in the with clause?  Do you not get an error exception?  As prb12@ commented, there are known subtle semantic differences between the CPU and GPU versions of some kernels.  When they involve error handling, like in this case, it's because the GPU kernels are launched asynchronously and there doesn't seem to be a good way of replicating the CPU kernel error handling without compromising performance.  As a matter of software engineering practice for code quality, it can be useful to test your models on CPU only to look for this kind of issue.

BTW, see https://github.com/tensorflow/tensorflow/blob/05ce371d64ce0c427f7706f0f58a9260a5a0470b/tensorflow/core/kernels/gather_functor_gpu.cu.h#L75-L77 which explains the checking is disabled in the GPU kernel. In case the indices are out of range, zeros are used: https://github.com/tensorflow/tensorflow/blob/05ce371d64ce0c427f7706f0f58a9260a5a0470b/tensorflow/core/kernels/gather_functor_gpu.cu.h#L42-L44. The links are to the latest version of the file.

@poxvoculi yes, I got an error when it is changed to CPU. I don't know much about CPU and GPU difference, but it seems that I need to test the model first on CPU before running on the GPU.
@foxik thanks! it seems because of the performance issue as explained above.

It is hard to send errors back from the GPU, thus we probably don't perform this check in the GPU implementation.  One solution might be to have the GPU version fill in NaNs instead of 0s; so you'll get failures earlier; and the offending kernel (embedding lookup) will be identified by adding finiteness checks.

I am having this same problem ever since I messed around with different versions of CUDA in an attempt to install tensorflow-gpu.
Now when I run a simple CNN, I get a warning message:  Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
But when I try a simple LSTM:

InvalidArgumentError (see above for traceback): indices[0,0] = 207 is not in [0, 188)
[[Node: embedding_2/Gather = Gather[Tindices=DT_INT32, Tparams=DT_FLOAT, validate_indices=true, _device="/job:localhost/replica:0/task:0/device:CPU:0"](embedding_2/embeddings/read, embedding_2/Cast)]]

Please see this stackoverflow link for full details: https://stackoverflow.com/questions/49777123/invalidargumenterror-see-above-for-traceback-indices0-0-195-is-not-in-0


Gh pages dev

A Helpful Guide For Navigating Our Branches

If this is a hotfix, make your PR against master.
If your change can ship immediately, make your PR against dev-tdvt.
If your change is for a future release, make your PR against the appropriate holding branch (eg dev-2020.1)

Also:

Please update the changelog of the project you modified, either under vNext or under a point release if you bumped the version.
If you are merging into master, update the root README.md if the PR includes a release of the SDK, Connector Packager, or TDVT.

Thank you and feel free to delete this from your PR description!

Adding missing test info and images to manual test md file.


fix refresh dashboard list when it's not first load

Description
There is an error that the dashboard list is not updated.
Related Issue :

How Has This Been Tested?

Need additional checks?
As we continue to add dashboards, make sure the dashboard list is updated.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

deploy to 1

@eltriny
After dashboard creation, the created dashboard does not have focus.

deploy to 2


Memory, missing barcodes, and R2 trimming

Hello!
First off, thanks so much for providing this tool for the single-cell community. I've been using cite-seq count regularly over the last few months and I've found one potential bug and have a couple of features that I'm hoping you could implement.

Bug: Occasionally when I use CSCount to align barcode reads to a 96-index reference using the following example script:

python /bin/CITE-seq-Count
-R1 /alpha/cmcginnis/NUC_BAR/NUC_BAR_S10_L001_R1_001.fastq.gz
-R2 /alpha/cmcginnis/NUC_BAR/NUC_BAR_S10_L001_R2_001.fastq.gz
-t /alpha/cmcginnis/CSCount/LMOlist.csv
-cbf 1 -cbl 16 -umif 17 -umil 26 -tr "[ATCG]{8}[A]{6,}" -hd 1
-wl /alpha/cmcginnis/NUC_L1_WL.txt
-o CSCount_NUC_wWL_111518.tsv
I receive an output where not all 96 barcodes are present (e.g., For the instance posted above, only 23/96 barcodes were present in the final csv). It's worth noting that this usually happens when I'm processing experiments in which I do not utilize all 96 barcodes -- for 96-plex experiments, I normally get 96 barcodes back -- and the barcodes I expect to be present never drop out. I figured that there may be a barcode QC step that removes barcodes with sufficiently few aligned reads, but when I look at my final count matrix, there are plenty of barcodes with exactly 0 UMIs.

Suggested Features: When I try to use CSCount on fairly large barcode FASTQs, I have to be very careful in terms of memory usage. I'm wondering if you could incorporate multi-thread processing into CSCount or, alternatively, load only enough of R2 to enable alignment (e.g., 18 bases instead of all 96). I believe either of these solutions would speed up CSCount tremendously and/or allow multiple instances to be run on a single core.

Hello @chris-mcginnis-ucsf and sorry for the late response, this issue has slipped through :(
On the plus side, the multi_processing branch is actually implementing the parallelization you asked for. The memory amount has also been drastically decreased and using a whitelist speeds up the processing because I don't deal with the reads that are not in the whitelist.
Using a whitelist for cell barcodes now also adds the missing ones, even if nothing matched to them. This was implemented a few versions ago. Which version are you using?

This has been fixed in the latest version.
Feel free to reopen it if necessary.


links with the table-striped gray background row color don't pass WCAG

related to https://github.com/Esri/calcite-web/issues/649
Perhaps the actual issue is the gray background for
.table-striped tr:nth-child(even) td {     background-color: #f8f8f8; }
WCAG passes AA for blue text of #0079c1 if the background color is #fcfcfc
.table-striped tr:nth-child(even) td {     background-color: #fcfcfc; }
@nikolaswise @paulcpederson @alansangma

@fgarofalo10 there is no brand gray in between white and off white: https://github.com/Esri/calcite-colors/blob/master/scss/variables.scss#L95
That said, we mix $white and $off-white to get #fcfcfc for the hover state of tabs, so we've used this color before. I wonder if we should add this color to the palette (maybe as $Calcite_Gray_075?)
Doing this makes the stripe very subtle:

Not sure if that is too subtle? Another option would be making links inside a striped table darker blue. The easiest way to do that would be to add a link-dark-blue modifier class.

@kyle-03674 @bstifle thoughts on the additional color, added to the palette?

I'm not sure the lighter gray background helps here. I like the solution in #649 where the button fill became white, but the row fill was the same. The row fill, as @paulcpederson says, is very subtle, so subtle than many displays would blow out that detail and just look "white." In fact, on many displays, $Calcite_Gray_100 might not even show.
Is there a problem to leaving tables as they are? Maybe I missed something

@kyle-03674 the accessibility compliance issue also occurs with a blue link <a href="#"> (#0079c1) against the current gray of a striped table row .table-striped tr:nth-child(even) td { background-color: #fcfcfc; }

ok, I've elected to just make the links $dark-blue which passes AA #661

ok

will be part of next release


Using HTTPQueryBuilder for github issue filing url

Description of changes
For github issue filing we are manually building the final url.
On this PR, I updated that logic to use HTTPQueryBuilder (which take care of url truncation too)
Also, update the max url length to 2000 (the de facto value)
Pull request checklist

[ ] Addresses an existing issue: Fixes #0000
[x] Added relevant unit test for your changes. (npm run test)
[x] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[x] Ran precheckin (npm run precheckin)
[ ] Added screenshots/GIFs for UI changes.

Looks fine except for minor comments.

@haonliu Updated.


Building from source fails on FreeBSD 10

I'm trying to install sqlite3 on a FreeBSD 10 box and am running into issues. First of all as far as I'm concerned (and based on the log output) you currently do not provide pre-built binaries for this platform and the install falls back to trying to build from source. This eventually fails with the following;
python: not found

I have a standard python2.7 install and have configured npm according to the node-gyp README:
$ npm config get python
/usr/local/bin/python2.7

Now I am not sure what actually happens (and this is merely a guess!) but having seen the action_before_build target in the build dependencies I wonder: Could it be that the pre-build step does not respect the npm config variable and tries to invoke the python command directly?
See this.
Either way, I'm using the following configuration:
$ npm config get python
/usr/local/bin/python2.7
$ node --version
v4.2.3
$ npm --version
3.5.2
$ uname -a
FreeBSD vagrant 10.2-RELEASE FreeBSD 10.2-RELEASE #0 r286666: Wed Aug 12 15:26:37 UTC 2015

Logs attached here:
npm-debug.log.zip
Any help would be really appreciated. Thank you.

I think I'm right in thinking that the hardcoded interpreter python in action in the action_before_build target in https://github.com/mapbox/node-sqlite3/blob/master/deps/sqlite3.gyp#L58 is the issue.
Whilst I could get the npm package to manually install, I'd consider the symlink to be a hack and would not consider using this approach during package building for example.
Whilst I'm not familiar with node-gyp, as far as I understand it should be able to use the right python interpreter (see my link to the README above).

Hi, not sure if you found a solution yet, but two things helped me;

ensure gmake installed
CXX="c++" npm install sqlite3 --sqlite=/usr/local/bin # wherever sqlite3 is installed

i've got gmake installed on the system, as well as sqlite3 form packages. However the solution above doesn't seem to work:
npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp install --fallback-to-build`
npm ERR! Exit status 126

From here, exit status 126 seems to suggest that "the command is found but is not executable". Maybe some permissions need fixing? Check permissions on node-pre-gyp executable, perhaps. Good luck!

@charlienewey i guess i should bring this up in the node-gyp repo as I don't think I have a node-pre-gyp executable. node-gyp is a dependency of sqlite3 and so i'd expect npm to download and execute it during install.

I also worked this around by (temporarily) adding a symlink from python to python2.7 but I agree that this should probably avoid hardcoding the command name and use the global setting as suggested in the node-gyp README.

Would you be able to try with v5.0.3? 🙂


[#12] modernize and reach parity with invenio-subjects-mesh-lite

modernize package + use galter-subjects-utils
release: v2023.1.2
closes #12 (really closed by https://github.com/galterlibrary/invenio-subjects-mesh-lite/pull/1 , but this puts a cap on the whole process)

@sharpattack it's not a bad idea to try the CLI locally when all the PRs have been merged and released. The changes are more for project management: reducing duplicate code, reducing different technologies, reducing spread of files.


training time

Training this method of "[Experimental_Code_Data]_Deep-Photo-Enhancer" spends seven days, but one iteration has not yet been completed and is this normal？I trained it on a single P40 GPU of the Nvidia. It used batch_size=12

Can you please tell me how to train the model,what is the command?

The command is python TF.py.  This problem has now been sorted.  Thanks a lot.


Show related submissions of automatic feedback block in  Text Exercises

Checklist

[ ] I tested all changes and all related features with different users (student, tutor, editor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[ ] Server: I followed the coding and design guidelines.
[ ] Server: I added multiple integration tests (Spring) related to the features (with a high test coverage)
[ ] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
[ ] Server: I implemented the changes with a good performance and prevented too many database calls
[ ] Server: I documented the Java code using JavaDoc style.
[ ] Client: I followed the coding and design guidelines.
[ ] Client: I added multiple integration tests (Jest) related to the features (with a high test coverage)
[ ] Client: I added authorities to all new routes and check the course groups for displaying navigation elements (links, buttons)
[ ] Client: I documented the TypeScript code using JSDoc style.
[x] Client: I added multiple screenshots/screencasts of my UI changes
[x] Client: I translated all newly inserted strings into English and German.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.

Motivation and Context

Description

Steps for Testing

Log in to Artemis
Navigate to Course Administration
...

Test Coverage

Screenshots

tested on ts1, looks good. there are some small code issues that mentioned above.

Displayed as described, tested on ts1 (this time also with the partial highlighting of suggestions)
Regarding the color of the find-icon:
The new color hints at the badge offering more / another functionality, but I do still think that an on hover color change might be beneficial - at least for me it indicates that an element is clickable.

As mentioned class="badge btn-primary findOrigin" might be sufficient to achieve this.

Changed the color, to highlight 👍

Tested on TS1.When I click the search icon, in every one of the given exercises, the table looks like this.

You need to clear the browser cache whener a PR has Translation changes.
Try Ctrl+Shift+R or CMD+Shift+R as a short cut.


Remove TODOs in Azure examples

What does this PR do?

Remove TODOs in Azure examples
Motivation

test-infra-cleaner is now ready to clean VMs and AKS clusters
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


python310Packages.aioesphomeapi: 13.4.1 -> 13.5.0

Diff: https://github.com/esphome/aioesphomeapi/compare/refs/tags/v13.4.1...v13.5.0
Changelog: https://github.com/esphome/aioesphomeapi/releases/tag/v13.5.0
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 219946 run on x86_64-linux 1

33 packages built:

esphome
home-assistant-component-tests.airthings_ble
home-assistant-component-tests.aranet
home-assistant-component-tests.bluemaestro
home-assistant-component-tests.bluetooth_adapters
home-assistant-component-tests.bluetooth_le_tracker
home-assistant-component-tests.bthome
home-assistant-component-tests.dormakaba_dkey
home-assistant-component-tests.esphome
home-assistant-component-tests.fjaraskupan
home-assistant-component-tests.govee_ble
home-assistant-component-tests.homekit_controller
home-assistant-component-tests.ibeacon
home-assistant-component-tests.inkbird
home-assistant-component-tests.kegtron
home-assistant-component-tests.keymitt_ble
home-assistant-component-tests.led_ble
home-assistant-component-tests.moat
home-assistant-component-tests.mopeka
home-assistant-component-tests.oralb
home-assistant-component-tests.qingping
home-assistant-component-tests.ruuvitag_ble
home-assistant-component-tests.sensorpro
home-assistant-component-tests.sensorpush
home-assistant-component-tests.snooz
home-assistant-component-tests.switchbot
home-assistant-component-tests.thermobeacon
home-assistant-component-tests.thermopro
home-assistant-component-tests.tilt_ble
home-assistant-component-tests.xiaomi_ble
home-assistant-component-tests.yalexs_ble
python310Packages.aioesphomeapi
python311Packages.aioesphomeapi


wallet: chanReserve & theirBalance fix

This commit fixes two miscalculations: an incorrectly calculated theirBalance by removing the subtracted pushMSat in the dual-funder workflow (pushMSat does not exist in the dual funder workflow and should therefore not be used) and an incorrectly calculated channel reserve. The channel reserve has a recommended value of 1% of the channel capacity, however we must multiply the capacity by 99, instead of adding it.

Sorry, it should be cap - (cap * 99) /100


Missing data fv 67

This is not complete. I am still waiting on some information to be able to handle gauges that sample at a frequency under 15 minutes.
Edit:
We now only consider data to be missing if the gap between adjacent datapoints is greater than 30 minutes. All dummy data points will be added in 15 minute increments. This does not affect the figure visual.

Not sure why tests are failing here. nosetests are passing locally.


Problem with creating user with properties other than the ones on the account

Hello,
I added to custom claims to the CreateProperties metadata of the MembershipRebootIdentityManagerService by the use of a custom metadataFunc.
I wanted to set Name, Phone and other custom claims, mandatory on the create and update...
However an error occurred when creating the user, because of the function CreateUserAsync on the MembershipRebootIdentityManagerService class.
The following code block (lines 288 to 291):
foreach (var prop in otherProperties)
{
SetUserProperty(createProps, acct, prop.Type, prop.Value);
}
The SetUserProperty fails when the property is a claim and not a field of the user account.
It implies that the account is already created, when before adding it invokes : UserAccountService.RemoveClaim.
it does the following
var account = base.GetByID(accountID);
if (account == null) throw new ArgumentException("Invalid AccountID", "accountID");
Which threw the error since the this.userAccountService.CreateAccount happens after.
The change i did, to do the otherproperties after the account is created on the repository.
It is not perfect, since it should on do so, for the claims, and not for example, Phone.. However, since they are not mandatory, this was a quick fix.

I am looking for gui configure for same as in memory come from database.. please help.. is this help to me how to create the client, scopeclaim and etc on GUI.. ANY OPEN source for this..


Update benchmarking.md with paper content

I'd suggest the following:

don't tell people to use computeSync(). Instead, tell them to do a complete x.getRepresentation(); send(); x = fromRepresentation() cycle, simulating a real application.
add (a short version of) the paper's discussion on the two benchmark types
Add the JMH code example from the paper (but a full version of it) to the .md file.
Maybe weave in some of the counting description from the paper, I thought that was pretty clear and concise.

I just noticed that by putting in the signature = scheme.restoreSignature(signature.getRepresentation()); stuff into the benchmark method, I actually move the blocking computation via getRepresentation into the benchmark method. That might actually mess with the benchmark.

Do you think actually mentioning the whole send and receive thing in there is helpful? You would not include networking in a benchmark like that, right? (I would do networking benchmarks separately). I think it is fine to mention the whole getRepresentation thing just as a mitigation for the lazy evaluation.

I like the send/receive because that’s what you want to measure, right? How much time until there’s a string available to send und how much time between receiving that string und getting the (say, Boolean) result.
If the test case is „create a signature, then verify it“, that’s not actually a useful scenario because you know the verification result already. No need to check.
I also object to the framing that lazy  computation is an issue that needs to be worked around by „forcing“ computation.
Our story can either be „we view test cases like this, where you imagine sending a value somewhere“ or „lazy evaluation sucks, so here is the workaround“. A middle ground is perhaps best, where we acknowledge that this is a likely source of benchmarking errors, but also explain how to think about the solution so that it makes sense even if lazy evaluation wasn’t a thing. I see the “send/receive” thing in that explainer role - computation isn’t done until you have bits in your hand.

I like the send/receive because that’s what you want to measure, right? How much time until there’s a string available to send und how much time between receiving that string und getting the (say, Boolean) result.
If the test case is „create a signature, then verify it“, that’s not actually a useful scenario because you know the verification result already. No need to check.
I also object to the framing that lazy computation is an issue that needs to be worked around by „forcing“ computation.
Our story can either be „we view test cases like this, where you imagine sending a value somewhere“ or „lazy evaluation sucks, so here is the workaround“. A middle ground is perhaps best, where we acknowledge that this is a likely source of benchmarking errors, but also explain how to think about the solution so that it makes sense even if lazy evaluation wasn’t a thing. I see the “send/receive” thing in that explainer role - computation isn’t done until you have bits in your hand.

My benchmark example is not meant to measure verification as part of a larger application, though, just purely the verification time (like you might see in the paper for the signature scheme). In that context lazy computation is actually an issue we need to just work around, and trying to justify the mitigations by talking about sending values around seems inappropriate.
If I were to take more of a "Benchmark the signature as if it was part of some larger application" angle, then I would find that more fitting.

But the „mitigation“ is also serializing and deserializing, no? I think all I want is not to have that sound unnatural, but weave it into a sensible story.
I think I fail to see the difference between benchmarking signing + verifying vs. benchmarking verifying. The code is the same in both scenarios (create sig, [serialize, deserialize], verify), just part that is „timed“ is different. Can you clarify? :)

But the „mitigation“ is also serializing and deserializing, no? I think all I want is not to have that sound unnatural, but weave it into a sensible story.

That sounds like we are kind of swiping the issues under the rug, no? What if the user just wants to measure purely the verification algorithm and not the whole sign->serialize->deserialize->verify process? I think it comes down to the fact that we need to inform them in a way that guarantees they won't fall for the lazy evaluation issues. I think the most clear way to do that is to mention them very clearly, instead of creating a nice story where the actual issues might end up being hidden. I can of course write something like "These are the issues, but actually if you benchmark like this, you won't run into them", but then I still have to mention what happens if they don't benchmark like that, i.e. "you still have to do the whole serialize->deserialize thing in any case". Just makes the whole doc unnecessarily complicated in my opinion.

I think I fail to see the difference between benchmarking signing + verifying vs. benchmarking verifying. The code is the same in both scenarios (create sig, [serialize, deserialize], verify), just part that is „timed“ is different. Can you clarify? :)

The part that is timed being different is quite relevant depending on what the user wants to measure and how they want to represent it. Measuring separately gives you more information in case you have, for example, multiple parties verifying each signature. Then measuring signing + verifying as one thing is not very useful. We don't know what the user wants to measure and why.

Ok, we had a discussion where we clarified what we wanted for the "Problem" section. I have integrated that feedback. Now it just remains to add some information on the new exp alg setter methods for DebugGroup etc.


Question : Portal For ArcGIS as an identity Store

How to configure Geoportal Server to use Portal for ArcGIS as an identity store ?

This should be a straightforward adapter configuration in gpt.xml. please see: https://github.com/Esri/geoportal-server/wiki/Portal-for-ArcGIS-Integration


Move statistics utilities into nested directory structure

As a Developer, I wish the the statistics_utils.py had more structure and each function was nested under a utils directory.

This would allow the utility functions to grow without bound and limit huge file sizes. Its easy to see dependencies with a single function (or very small number) per file.  Its also easier to search because can you limit searching to a specific branch of a directory.


docs: add Linode COSI to ADOPTERS.md

Explanation
Add Linode COSI to Adopters list.

Related issue
https://github.com/linode/linode-cosi-driver/pull/55

Proposed Changes

Checklist

[x] I have read the contributing guidelines.
[x] I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
[ ] This is a bug fix and I have added unit tests that prove my fix is effective.

Further Comments

Awesome, thank you @mhmxs !


Update Route

Add Update Route(post/patch method)
This route takes an order id and values that need to be changed. It loops through all the orders to find that order. If found update it if not then simply do nothing
Add documentation(comments) wherever necessary

I understood the point. I can do this well. Can you please assign this issue to me ?
You can check this link where i did this. https://github.com/chintansuthar72/Exercise-tracker-react-app/tree/master/backend/routes

I understood the point. I can do this well. Can you please assign this issue to me ? You can check this link where i did this. https://github.com/chintansuthar72/Exercise-tracker-react-app/tree/master/backend/routes

Sure!


Can I pass a custom class component to sizePerPageDropDown?

Sorry for bothering you.
I created a custom pagination component and want to pass it to sizePerPageDropDown option.
But as sample posted:
http://allenfang.github.io/react-bootstrap-table/custom.html#pagination
it seems that I can only pass a stateless function to it.
Would you please tell me how to pass a component to sizePerPageDropDown?
sizePerPageDropDown: props => this.mySize(props),
mySize = (props) => {   return (     <renderSizePerPageDropDown       changeSizePerPage={props.changeSizePerPage}       sizePerPageList={props.sizePerPageList}       currSizePerPage={props.currSizePerPage}     />   ); }

Sorry, I made a react mistake. The source above worked.


bash completion for docker swarm join-token

Ref: #24823
Please schedule for 1.12.0

Thanks @albers !
LGTM 🐭
/cc @thaJeztah @tiborvass

LGTM


[ Engine ] Broken .asi files loading

Playing Counter Strike 1.6 I use a FOV fix for playing widescreen.
Repo: https://github.com/Garey27/CS_Patches/releases/tag/0.4.1
With metahook patch dont work and looks like default:

With CS_Patches without metahook:

For installing CS_Patches you just need to put .asi file in the root folder ( Half-Life ) and it will load automatically.

Renderer.dll completely overrides the renderer thus any binary patch to it just won't work.
Are you looking for r_vertical_fov and viewmodel_fov?

Just installed metahook, without the renderer. I was trying to use a Fov
fix which is in the .así file not the MetaRenderer one.
El dom, 16 de jul. de 2023 8:29 p. m., hzqst @.***>
escribió:

Renderer.dll completely overrides the renderer thus any binary patch to
it just won't work.
Are you looking for r_vertical_fov
https://github.com/hzqst/MetaHookSv/blob/36f95f879a71a01cd3f58391ee3b0781b59cbd3b/Plugins/Renderer/gl_rmain.cpp#L2070
and viewmodel_fov
https://github.com/hzqst/MetaHookSv/blob/36f95f879a71a01cd3f58391ee3b0781b59cbd3b/Plugins/Renderer/gl_rmain.cpp#L2064
?
—
Reply to this email directly, view it on GitHub
https://github.com/hzqst/MetaHookSv/issues/299#issuecomment-1637215849,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANX2KMUW3RE3IWICY36U3TDXQR2ORANCNFSM6AAAAAA2MCB4QY
.

The debugger said that the CS_Fixes.asi was actually loaded without any problem:

Your issue is probably because the whole renderer was overrided by Renderer.dll,
The "widescreen fixed" has already be done in the Renderer though. (see docs)


dual-stack, virtctl: expose ipv6 services

What this PR does / why we need it:
Adapt the virtctl API to accept the IPFamily of a the service to
be exposed; it accepts 'ipv4' and 'ipv6' as families.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Release note:

Add `ip-family` to the `virtctl expose` command.

/cc @AlonaKaplan @phoracek

Reviewed again. Added one question. Other than that looks very good:)
I think I'll have to make another round just to be sure before lgtm, cause it is a long PR.
about the callbacks, I won't insist, whatever you prefer.

I've pushed a version where I removed the callbacks, let's see if this is clearer.
Also moved to the previous solution without the When clauses.

Reviewed again. Added one question. Other than that looks very good:)
I think I'll have to make another round just to be sure before lgtm, cause it is a long PR.
about the callbacks, I won't insist, whatever you prefer.

I've pushed a version where I removed the callbacks, let's see if this is clearer.
Also moved to the previous solution without the When clauses.

I really liked the new version:) I think it is more understandable. Thank you for this PR.
/lgtm

Thanks
/lgtm

/retest
Read the VM to know if it must be removed in the test tear-down.

/lgtm

/retest

/cc @AlonaKaplan
I think this should be reviewed as is, since the tests currently create the VMI once.
Destroying the VMIs and re-creating them makes the tests take > 10 additional minutes (just from +- 17 minutes to +- 28 minutes) .

/retest

/retest

/retest

/retest

Added the kubecli.KubevirtClient to the VM lambdas where it was missing and updated the name of the function that randomizes the string, as per @EdDev 's request.
Thanks for the thorough review.

Thanks for the fixes, I know the review process wasn't easy:)
/approve
/hold - there are some small comments, feel free to remove the hold once they are fixed.

Addressed the last of @AlonaKaplan 's comments; hope all is well now.
PS: I think it does look better without the duplicated code.

/retest


Invariant Violation: [React Intl] The Intl APIs must be available in the runtime

Polyfill api user agent doesn't work reliable for iOS embedded Safari. What we should do?
Invariant Violation: [React Intl] The `Intl` APIs must be available in the runtime, and do not appear to be built-in. An `Intl` polyfill should be loaded.
See: http://formatjs.io/guides/runtime-environments/

Finally fixed :)

how to fixed?

https://github.com/este/este/blob/master/src/browser/index.js

@steida 404 (  Please let me know how to fix?

Fixed:
import 'intl';
or
require('intl');


#1201 - Get health facilities with google places api

What does this pull request aim to achieve? 💯
In backend, provides data necessary for client to display list and map for health facilities
Please be concise and link any related issue(s):
For the backend, this PR resolves #1201

[X] I have checked that no one else is working on similar changes.
[X] I have read the latest README and understand the development workflow.
[X] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
[X] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[X] There are no merge conflicts.
[X] There are no console warnings and errors.
[x] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".
[X] The title describes the issue(s) being addressed using format: <issue_numbers> - <#1201 Get health facilities data> (e.g. #1127/#1130 - Update Git Branching Model)

@maskowe @davidoduk
Tested on Laptop and iphone:

Unable to see the nearest health facilities to my current location.
User is directed to 'Feeds' page while answering the onboarding question not list of hospitals as mention in the requirements on the notion page.
Please refer below GIF.

Please, let me know if there is some issue or I am missing something.

Will re-review with FE additions

@maskowe @davidoduk
Tested on Laptop and iphone:

Unable to see the nearest health facilities to my current location.
User is directed to 'Feeds' page while answering the onboarding question not list of hospitals as mention in the requirements on the notion page.
Please refer below GIF.

Please, let me know if there is some issue or I am missing something.

Please retest at https://feature1201-display-health-facilities.fightpandemics.xyz
If possible.

@maskowe @davidoduk
Tested on Laptop and iphone:

Unable to see the nearest health facilities to my current location.
User is directed to 'Feeds' page while answering the onboarding question not list of hospitals as mention in the requirements on the notion page.
Please refer below GIF.

Please, let me know if there is some issue or I am missing something.

Please retest at https://feature1201-display-health-facilities.fightpandemics.xyz
If possible.

@rabbi08 Thanks a lot for the thorough review.   In regards to:

With regards to Plainsboro Township, have eliminated Ranbaxy Pharmaceuticals Inc  and others that Google maps nearby search doesn't include.   Evidently, users have incorrectly identified with "pharmacy" as their category, even though they are not "pharmacies" but other types of establishments.

I have also included a new link under the type header "For more results for this facility type and location" which should fill in the gaps with the relevant facilities.   Google maps nearby search leans heavily on reviews and other metadata to determine what to show and not show.   For pharmacies, we should be cautious with our exceptions.   My solution is applicable to all locations for the pharmacy types.
For Proximare Inc -  Princeton, NJ
Google identifies this as a pharmacy also, so it must have eliminated it from the nearby list based on some other metadata that it has (or doesn't have).   We don't have access to this metadata and can't eliminate based on the generic name, so we have to include it as long as it's within the proximity set of results.

Even though sorting by distance wasn't a requirement initially, I've added this functionality.

I've eliminated the "overlap" of the markers into the description boxes when hovering over markers.  Any other issues with those markers that are overlapping each other should be easily manually worked around by expanding the map itself.   If you find that this doesn't address your issues, please let me know.

Thanks again - ready to retest.

@rabbi08 Thanks a lot for the thorough review.   In regards to:

With regards to Plainsboro Township, have eliminated Ranbaxy Pharmaceuticals Inc  and others that Google maps nearby search doesn't include.   Evidently, users have incorrectly identified with "pharmacy" as their category, even though they are not "pharmacies" but other types of establishments.

I have also included a new link under the type header "For more results for this facility type and location" which should fill in the gaps with the relevant facilities.   Google maps nearby search leans heavily on reviews and other metadata to determine what to show and not show.   For pharmacies, we should be cautious with our exceptions.   My solution is applicable to all locations for the pharmacy types.
For Proximare Inc -  Princeton, NJ
Google identifies this as a pharmacy also, so it must have eliminated it from the nearby list based on some other metadata that it has (or doesn't have).   We don't have access to this metadata and can't eliminate based on the generic name, so we have to include it as long as it's within the proximity set of results.

Even though sorting by distance wasn't a requirement initially, I've added this functionality.

I've eliminated the "overlap" of the markers into the description boxes when hovering over markers.  Any other issues with those markers that are overlapping each other should be easily manually worked around by expanding the map itself.   If you find that this doesn't address your issues, please let me know.

Thanks again - ready to retest.

@CamilaArias would you also see if any comments from design perspective? thanks 🎨

@CamilaArias would you also see if any comments from design perspective? thanks 🎨

@maskowe @davidoduk
I have following observations:

The distance is displayed in 'km' but in countries like 'US' distance unit is 'Miles'. @doheekim93 suggested to add it to Lokalise for customization,  so I will add new ticket for the same.

The results doesn't seem to be accurate as in the search. While searching for 'Pharmacy for zip code = 08536'
There are 2 pharmacy near to each other with almost same address but one is displayed and other is not. Please see below GIF: where nearest CVS location is not displayed:

We need to have GTM IDs for "Health Aid, location input, Hospitals, Pharmacies, Doctors" so total 5 GTM IDs.

Let me know if there are any questions/comments. Thanks

@maskowe @davidoduk
I have following observations:

The distance is displayed in 'km' but in countries like 'US' distance unit is 'Miles'. @doheekim93 suggested to add it to Lokalise for customization,  so I will add new ticket for the same.

The results doesn't seem to be accurate as in the search. While searching for 'Pharmacy for zip code = 08536'
There are 2 pharmacy near to each other with almost same address but one is displayed and other is not. Please see below GIF: where nearest CVS location is not displayed:

We need to have GTM IDs for "Health Aid, location input, Hospitals, Pharmacies, Doctors" so total 5 GTM IDs.

Let me know if there are any questions/comments. Thanks

@rabbi08 Thanks again.

Distance now defaults to miles (as in "6 mi") in the description for those (3) countries using imperial instead of metric system.
The CVS drug store very close to Plainsboro pharmacy is identified as a "drug store" instead of a "pharmacy" when I search google maps nearby.   My guess is that since the business user that entered this information left off "pharmacy" and the description shows only "beauty supplies and home health items", it was included in our results for "pharmacy" type.   This is more bad user data, that's why I've included the new link "For more results" in order for the FP users to make their own selection from each set.   Google has the metadata to make intelligent guesses about these pharmacies that we just can't get to with this API, unfortunately.

Actually, there are six elements, since there are two instances of LocationInput (one for the "Share your location..." element and another for the change location element).
For facility type buttons ("Hospitals, etc."):  id/selector: a#NH_FT0, a#NH_FT1, a#NH_FT2
For the two location input (text boxes): id/selector: span#NH_LC_EAZ and span#NH_LS_EAZ
For the Health Aid link (top nav):  id/selector:  a#NAV_NH
I did have to add a property to the tags in constants file for the buttons, so thanks for the catch.

@rabbi08 Thanks again.

Distance now defaults to miles (as in "6 mi") in the description for those (3) countries using imperial instead of metric system.
The CVS drug store very close to Plainsboro pharmacy is identified as a "drug store" instead of a "pharmacy" when I search google maps nearby.   My guess is that since the business user that entered this information left off "pharmacy" and the description shows only "beauty supplies and home health items", it was included in our results for "pharmacy" type.   This is more bad user data, that's why I've included the new link "For more results" in order for the FP users to make their own selection from each set.   Google has the metadata to make intelligent guesses about these pharmacies that we just can't get to with this API, unfortunately.

Actually, there are six elements, since there are two instances of LocationInput (one for the "Share your location..." element and another for the change location element).
For facility type buttons ("Hospitals, etc."):  id/selector: a#NH_FT0, a#NH_FT1, a#NH_FT2
For the two location input (text boxes): id/selector: span#NH_LC_EAZ and span#NH_LS_EAZ
For the Health Aid link (top nav):  id/selector:  a#NAV_NH
I did have to add a property to the tags in constants file for the buttons, so thanks for the catch.

@maskowe
I have following observations:

Please add scroll bar in the search results, when user scroll down in search results, only the search results should scroll and map should stay as is in the right pane of the window.
Also, for Point#2< "user bad data" for 'Pharmacy'> agree with your comments, but while searching for hospitals, also I am not getting expected results. Great if you can look into this as well. Please see below GIF for search result comparison:

The search result display two hospitals with same location but different name( one is hospital and other is medical facility/center) Please see below screenshot

the text, to show more search results, please update the text:
Update: "For more results for this facility type and location"
To: "Show more search results..."
Currently, this text navigate user to google maps. Shouldn't we keep user on our portal rather than redirecting to google. Great if we add pagination to show results in FightPandemics only, rather than redirecting, if that's feasible.

Please confirm this scenario @davidoduk @maskowe

@rabbi08 Thanks again.   I've moved the url for showing more results and changed text as requested.   Also added scrolling for the facility list on left, keeping map in position.
On the issue with Fresenius Medical Care in Trenton, NJ, I believe that this is Google metadata putting this in the hospital list, even though the establishment category is medical center.   It could be that these "medical centers" are included, we just haven't identified them in the hospital lists coming back from our api.   The Fresenius facility does show up at http://nj.hospitals-usa.org/item/fresenius-medical-care-mercer-capital-health-system/
so maybe that is why.

@rabbi08 Also on the pagination topic, we have purposely limited the output to 10 facilities due to bad performance beyond.   We can theoretically make another request for the next 10 (up to 20 only unfortunately).   But since google maps provides unlimited amount and have included/disincluded various facilities because of different factors, I don't believe that this is worth the effort and would also be misleading because of the unfortunate mismatch of both the results themselves and the presentation differences.   We can talk more in slack on this if you want.

Thanks @maskowe

Ok I agree with your comments for search results difference from google.
For scroll bar, please add the scroll bar to the search results and only search results should scroll not the header like 'Hospitals/Doctors/Pharmacy'.
Also, the the length of the search result pane should match with Google maps.

Please see below GIF.

@maskowe
Following are the observations while testing this feature on mobile:

For some options on both mobile and Desktop it is displayed as 'common.myqrganisation', 'common.language', 'common.no' there should not be 'common.' . Please see below screenshot and in below GIF in #4 too.

'Map view' text is displayed over the text in the search results. Please see below screenshot.

The scrolling is not smooth i.e. initially the search options are not displayed when user enter the location and navigate to the search results page, the 'Facility options-Hospitals,,, etc. " are NOT displayed. Please see below screenshot

The user need to scroll 2 times to view the Facilities. Please see below GIF showing the navigation.

Changed scrolling list to disinclude header, smoothed scrolling behavior and adjusted position of Map View/List View button to allow for some mobile devices to allow it to be shown.   Lambda testing showed that iPhones (most or all versions) not only do not show scroll bar for list, but actually introduce an upper scroll bar that other devices don't shown.   Needs to be tested outside of Lambdatest (on a real phone) to confirm this.

Thanks @maskowe
On the Desktop, the scrolling and width issues are working fine, Hence no issues have been observed in the desktop version.
But On MOBILE, (iPhone 11 Pro max) the 'Map view' is getting scrolled up... As per design, it should display in the Bottom of the page and centre aligned and should not be scrolled while user scroll the result sets.
Please see below GIF from mobile version:

Ready to retest iphones.   Because some older phones were hiding part of the view map button, I had to move it up a little.   So it appears higher on other phones.   Also, in order for the button to be properly positioned, had to fix the position of the facility type buttons and location and move the facility type header down, so there is some white space, but it had to happen to accommodate iphones.    If this is unacceptable, suggest that we not show the list header ("Hospitals") at all for mobile phones, as it really isn't necesssary, since the button is selected and it's obvious which facility type is listed.   Let me know if I can do that and thanks.

Thanks @maskowe
While testing on mobile view (iPhone 11 Pro max):

The 'Map view' option is displayed in the center of the page, it should be in the Bottom of the page century aligned and should be in one line.
There is white space over the list like in below GIF, notice the white space over the 'Hospitals' section.
When user scrolls within the list the white space exists and when user scroll on the white space 'White space' is gone and issue is fixed.

For the issues above please refer below GIF.

adding more observation from Mobile view (iPhone 11 Pro max):

On Health Aid page -> open the navigation menu from the top left menu bars, you will observe that, the navigation bar is overlapped by the Health Aid options. Please see below in below screenshot and video:

The 'languages' option is still displayed as 'Common.languages' hence the prefix 'common.' exist with the option of the menu bar and pop ups.

https://user-images.githubusercontent.com/67168400/108539761-65a32a00-72ae-11eb-987a-6221f71c5dbb.MP4

All issue fixed including "Language" bug.


move amp test and change op support to warning

Description
move amp test to follow naming convention for contrib features and change op support to warning
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] move test_amp to test_contrib_amp to follow the naming convention
[x] change op support to warning instead of test failure.

@marcoabreu I intended to wait until the discussion concludes too. Also, I'd like to remind you that vetos must be accompanied by technical justification https://www.apache.org/foundation/voting.html#Veto.

@mxnet-label-bot add [Test]

<EMAIL_ADDRESS>

met with @ptrendx today and we are proceeding with warning now.


BeautifulSoup complains about a missing feature.

I get the following error:
Traceback (most recent call last):
  File "/REDACTED/scripts/get_user_tweets.py", line 38, in target
    user = client.get_user_by_screen_name(username)
  File "/REDACTED/.venv/lib/python3.10/site-packages/twikit/client.py", line 1437, in get_user_by_screen_name
    response, _ = self.get(
  File "/REDACTED/.venv/lib/python3.10/site-packages/twikit/client.py", line 169, in get
    return self.request('GET', url, **kwargs)
  File "/REDACTED/.venv/lib/python3.10/site-packages/twikit/client.py", line 134, in request
    self.unlock()
  File "/REDACTED/.venv/lib/python3.10/site-packages/twikit/client.py", line 275, in unlock
    response, html = self.captcha_solver.get_unlock_html()
  File "/REDACTED/.venv/lib/python3.10/site-packages/twikit/_captcha/base.py", line 41, in get_unlock_html
    return response, parse_unlock_html(response.text)
  File "/REDACTED/.venv/lib/python3.10/site-packages/twikit/_captcha/base.py", line 82, in parse_unlock_html
    soup = BeautifulSoup(html, 'lxml')
  File "/REDACTED/.venv/lib/python3.10/site-packages/bs4/__init__.py", line 250, in __init__
    raise FeatureNotFound(
bs4.FeatureNotFound: Couldn't find a tree builder with the features you requested: lxml. Do you need to install a parser library?

I had to manually install lxml like so:
python3 -m pip install lxml

pip freeze:
anyio==4.4.0
beautifulsoup4==4.12.3
certifi==2024.6.2
exceptiongroup==1.2.1
filetype==1.2.0
h11==0.14.0
httpcore==1.0.5
httpx==0.27.0
idna==3.7
pyotp==2.9.0
sniffio==1.3.1
soupsieve==2.5
twikit==1.7.6
typing_extensions==4.12.2

added lxml to install_requires.


Continuous Sync causes out of memory error

I seem to encounter the following "out of memory error" in our current Android project every now and then:
Fatal Exception: java.lang.OutOfMemoryError: pthread_create (stack size 16384 bytes) failed: Try again
       at java.lang.VMThread.create(VMThread.java)
       at java.lang.Thread.start(Thread.java:1029)
       at com.couchbase.lite.replicator.PullerInternal.waitForPendingFuturesWithNewThread(PullerInternal.java:931)
       at com.couchbase.lite.replicator.PullerInternal.changeTrackerCaughtUp(PullerInternal.java:821)
       at com.couchbase.lite.replicator.ChangeTracker.runLoop(ChangeTracker.java:379)
       at com.couchbase.lite.replicator.ChangeTracker.run(ChangeTracker.java:246)
       at java.lang.Thread.run(Thread.java:841)

The app makes use of Couchbase Lite (version Forestdb:1.3.1), and is set to continuously push and pull against Sync Gateway 1.3.1.
Full stacktrace can be found here:
https://gist.github.com/robinvanemden/36c9ca90f9c6fac2a4f1a4a9367f5462

Hi @robinvanemden,
Thank you for reporting the issue.
Can you provide each document size, total number of documents, how many revisions each doc has? And also, do you use Sync Gateway for server? or CouchDB?
Thanks!

Of course!

Data/Disk usage for the relevant bucket in Couchbase Console: 32.4MB
Total number of documents: 3
Each document contains about 130 revisions
See example of one of the three documents here: https://gist.github.com/robinvanemden/fa219f390f71fe017fe438e099100d9e#file-example_birdy_document-js-L149
I use Sync Gateway 1.3.1 for server (together with Couchbase Server 4.1.1-5914 Community Edition)

@robinvanemden Thank you for your additional inputs.

I'm having the same problem.
My db on the Android Watch contains more than 600000 documents.

I get a lot of following logs:
Verification of void okhttp3.internal.http.HttpEngine.maybeCache() took 111.640ms
12-06 11:12:37.102 8508-8516/ W/art: Suspending all threads took: 29.380ms
12-06 11:12:38.451 8508-12968/ W/Sync: Error converting lastSequence: null to long.   I/art: Waiting for a blocking GC Alloc
12-06 11:13:28.715 8508-8516/? I/art: Waiting for a blocking GC Alloc
12-06 11:13:28.715 8508-8518/? I/art: Waiting for a blocking GC Alloc
12-06 11:13:31.676 8508-8519/? I/art: Alloc partial concurrent mark sweep GC freed 577147(41MB) AllocSpace objects, 0(0B) LOS objects, 24% free, 6MB/8MB, paused 5.064ms total 1.645s
12-06 11:13:31.676 8508-8518/? I/art: WaitForGcToComplete blocked for 2.200s for cause Alloc
12-06 11:13:31.676 8508-8518/? I/art: Starting a blocking GC Alloc
12-06 11:13:31.677 8508-8518/? E/System: java.lang.OutOfMemoryError: OutOfMemoryError thrown while trying to throw OutOfMemoryError; no stack trace available
12-06 11:13:31.677 8508-12968/? I/art: WaitForGcToComplete blocked for 1.897s for cause Alloc
12-06 11:13:31.677 8508-12968/? I/art: Starting a blocking GC Alloc
12-06 11:13:31.677 8508-8516/? I/art: WaitForGcToComplete blocked for 1.631s for cause Alloc
12-06 11:13:31.677 8508-8516/? I/art: Starting a blocking GC Alloc
12-06 11:13:31.677 8508-8516/? W/art: JNI WARNING: java.lang.OutOfMemoryError thrown while calling printStackTrace
12-06 11:13:31.680 8508-12969/? I/art: WaitForGcToComplete blocked for 1.602s for cause Alloc
12-06 11:13:31.680 8508-12969/? I/art: Starting a blocking GC Alloc
12-06 11:13:31.684 8508-12969/? E/AndroidRuntime: Error reporting crash
                                                  java.lang.OutOfMemoryError: Failed to allocate a 64 byte allocation with 3640 free bytes and 3KB until OOM
                                                      at java.lang.AbstractStringBuilder.enlargeBuffer(AbstractStringBuilder.java:95)
                                                      at java.lang.AbstractStringBuilder.append0(AbstractStringBuilder.java:146)
                                                      at java.lang.StringBuilder.append(StringBuilder.java:216)
                                                      at com.android.internal.os.RuntimeInit$UncaughtHandler.uncaughtException(RuntimeInit.java:80)
                                                      at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:693)
                                                      at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:690)

And the last logs when the app crashes:
12-06 11:13:28.715 8508-8519/? I/art: Waiting for a blocking GC Alloc
12-06 11:13:28.715 8508-8516/? I/art: Waiting for a blocking GC Alloc
12-06 11:13:28.715 8508-8518/? I/art: Waiting for a blocking GC Alloc
12-06 11:13:31.676 8508-8519/? I/art: Alloc partial concurrent mark sweep GC freed 577147(41MB) AllocSpace objects, 0(0B) LOS objects, 24% free, 6MB/8MB, paused 5.064ms total 1.645s
12-06 11:13:31.676 8508-8518/? I/art: WaitForGcToComplete blocked for 2.200s for cause Alloc
12-06 11:13:31.676 8508-8518/? I/art: Starting a blocking GC Alloc
12-06 11:13:31.677 8508-8518/? E/System: java.lang.OutOfMemoryError: OutOfMemoryError thrown while trying to throw OutOfMemoryError; no stack trace available
12-06 11:13:31.677 8508-12968/? I/art: WaitForGcToComplete blocked for 1.897s for cause Alloc
12-06 11:13:31.677 8508-12968/? I/art: Starting a blocking GC Alloc
12-06 11:13:31.677 8508-8516/? I/art: WaitForGcToComplete blocked for 1.631s for cause Alloc
12-06 11:13:31.677 8508-8516/? I/art: Starting a blocking GC Alloc
12-06 11:13:31.677 8508-8516/? W/art: JNI WARNING: java.lang.OutOfMemoryError thrown while calling printStackTrace
12-06 11:13:31.680 8508-12969/? I/art: WaitForGcToComplete blocked for 1.602s for cause Alloc
12-06 11:13:31.680 8508-12969/? I/art: Starting a blocking GC Alloc
12-06 11:13:31.684 8508-12969/? E/AndroidRuntime: Error reporting crash
                                                  java.lang.OutOfMemoryError: Failed to allocate a 64 byte allocation with 3640 free bytes and 3KB until OOM
                                                      at java.lang.AbstractStringBuilder.enlargeBuffer(AbstractStringBuilder.java:95)
                                                      at java.lang.AbstractStringBuilder.append0(AbstractStringBuilder.java:146)
                                                      at java.lang.StringBuilder.append(StringBuilder.java:216)
                                                      at com.android.internal.os.RuntimeInit$UncaughtHandler.uncaughtException(RuntimeInit.java:80)
                                                      at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:693)
                                                      at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:690)

I am using the latest version of cb lite:
couchbase-lite-android:1.3.1

@pasin @hideki please share your thoughts on this bug..

@NitzDKoder The stacktrace above couldn't tell much of the info what caused the memory issue. Is it the full stacktrace? Could you do memory profiling and share the result?

@pasin ok will try to get the full stacktrace.
App:

CBL 1.4.1 with phonegap- cbl listener active and remote sync on.
2)Heap size for per app is 96MB. Samsung J3 device.

Test case Scenario::
Client was activated over Wi-Fi.
Kept for network transitions automation
Steps of the test: Wi-Fi and 3G data are enabled.

Wi-Fi goes down
3G data goes down
3G data comes up
Wi-Fi comes up
Turn onAirplane mode
Turn of Airplane mode
Observation::

App crashed after 450 iterations while creating threads in app.
09-18 00:10:47.443 E/AndroidRuntime(25495): FATAL EXCEPTION: main
09-18 00:10:47.443 E/AndroidRuntime(25495): Process: com.att.eptt, PID: 25495
09-18 00:10:47.443 E/AndroidRuntime(25495): java.lang.OutOfMemoryError: pthread_create (1040KB stack) failed: Try again
09-18 00:10:47.443 E/AndroidRuntime(25495): 	at java.lang.Thread.nativeCreate(Native Method)
09-18 00:10:47.443 E/AndroidRuntime(25495): 	at java.lang.Thread.start(Thread.java:733)


[Improvement-10279] [Master] Dependent node log output optimization and fix checkstyle

Purpose of the pull request
close #10279

Codecov Report

Merging #10593 (421c656) into dev (15a8607) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev   #10593      +/-   ##
============================================
- Coverage     40.93%   40.92%   -0.01%
+ Complexity     4875     4873       -2
============================================
  Files           895      895
  Lines         36212    36212
  Branches       3987     3987
============================================
- Hits          14824    14821       -3
- Misses        19922    19927       +5
+ Partials       1466     1464       -2

Impacted Files
Coverage Δ

...ver/master/runner/task/DependentTaskProcessor.java
5.33% <0.00%> (ø)

...org/apache/dolphinscheduler/remote/utils/Host.java
43.47% <0.00%> (-2.18%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
51.38% <0.00%> (-0.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a8607...421c656. Read the comment docs.


update version and poetry

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1e05416) 98.46% compared to head (2c1b162) 98.46%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   98.46%   98.46%
=======================================
  Files          24       24
  Lines        1040     1040
=======================================
  Hits         1024     1024
  Misses         16       16

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


APPIMAGE_ROOT_DIR

In case APPIMAGE_ROOT_DIR is related to AppImage, then you can use the existing environment variables:

APPDIR - the directory in which the AppRun file resides
APPIMAGE - the directory in which the *.AppImage file resides

These are automatically set for you when running an AppImage.

Ok, thanks. Changed it to APPDIR

But make sure that this does not break when the user extracts the content of the AppImage and runs AppRun directly.


Fix controller pointers with Solvers

Overview
This change fixes issue with ability to select hand rays for solver tracking. There was the option to select a hand joint but the forward vector would point through the hand. Thus with a hand raised, it pointed up with gravity (relatively upwards to the sky) instead of straight out through the palm.
This change modifies the MotionController enum type to be more extensible and accurate as the ControllerRay type. Instead of looking for some odd (easily breaking code) of a visual's transform on the motion controller, the code now looks for a particular line pointer available which will work for both motion controller and hand controllers.
Also, updated scene to use styling seen in other scenes as well as cleaner radial set prefab instead of just box buttons list.

Also updates documentation and fixes some doc errors

Changes

Fixes: #6279

Verification

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):
git fetch origin pull/{PR_ID}/head:name_of_local_branch
git checkout name_of_local_branch

/azp run

@Troy-Ferrell, please resolve the merge conflict and re-run validation. Thanks!

/azp run


feature: External Table ( for ClickHouse )

PR checklist:

Did you run ClangFormat ?
Did you separate headers to a different section in existing community code base ?
Did you surround proton: starts/ends for new code in existing community code base ?

Please write user-readable short description of the changes:
New feature for creating External Tabels to connect to non-streaming data sources. In this first implementation, a ClickHouse External Table has been implemented.
Examples:
To create an external table:
CREATE EXTERNAL TABLE my_first_table SETTINGS type='clickhouse',address='my_clickhouse_server:9000',database='my_database',table='my_table',user='my_user',passowrd='my_password'

External tables do not accept the column list, it fetches its table structure from the remote data source. After the table is created, one can use DESCRIBE my_table to see its structure.
Then, it can be queried just like any tables/streams:
-- read data
SELECT * FROM my_external_table;

-- write data
INSERT INTO my_external_table VALUES (...);

-- use it as a materialized view target
CREATE MATERIALIZED VIEW some_view INTO my_external_table AS SELECT ...;

To drop an external table:
DROP EXTERNAL TABLE my_table

Hi @zliang-min , please test the behavior of connecting to a view or materialized view in ClickHouse.
Probably Proton can still read it but cannot write to it. If the user creates an external table connecting to a ClickHouse view, then try to use it as target for Proton Materialized view. The materialized view DDL should fail, instead of creation is done but no result while MV is running

Hi @zliang-min , please test the behavior of connecting to a view or materialized view in ClickHouse.
Probably Proton can still read it but cannot write to it. If the user creates an external table connecting to a ClickHouse view, then try to use it as target for Proton Materialized view. The materialized view DDL should fail, instead of creation is done but no result while MV is running

Checked, it works for views and materialized views.

(Jove Github Bot) added it to the current sprint.

(Jove Github Bot) moved this ticket out of the GitHub project(up to 1200 tickets for one project).


Document whether and how Universal Packages can be consumed without the azure CLI

This page doesn't include information on how to access this class of artifact without the azure CLI.   This is perhaps a duplicate of https://github.com/MicrosoftDocs/vsts-docs/issues/3834 but since this particular page duplicates some of that information, this would also be a useful fact to include here.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77bcd39f-91ab-bb93-40fc-dd4fc5f2374f
Version Independent ID: c228aece-669a-57d6-b3ed-d427586f8a61
Content: Publish and then download a Universal Package
Content Source: docs/artifacts/quickstarts/universal-packages.md
Product: devops
Technology: devops-artifacts
GitHub Login: @chasewilson
Microsoft Alias: phwilson

This will be really good if we can do that through HTTP call. We can perhaps use this as a source for Terraform modules

Hi @wez, @melcloud,
You must use the Azure CLI to download the package. Azure DevOps doesn't support direct HTTP/HTTPS download links or other ways to download the package. I've added this info to the article.
Thank you for calling this issue to our attention!

I've made my feelings known on #3834. But w/o a way to download (button, http) outside of requiring an install of the Azure CLI installed AND the azure-devops extension to the Azure CLI - universal package feeds are practically useless.


Remove JSON parser code from Stan

Summary
Removes the files that were moved to cmdstan in https://github.com/stan-dev/cmdstan/pull/726
This should be merged after the cmdstan PR is merged.
How to Verify
/
Side Effects
/
Documentation
/
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Rok Češnovar, University of Ljubljana

Would you mind resolving the conflicts?

Done, thank you for notifying me.

The move was done on cmdstan end so these files can now safely be removed.

Bumping this one, if anyone has time to review. This just removes 2500 lines by deleting the unused parser.

I'm not supposed to approve stuff here but @seantalts do you mind if I slam this one in? (Or just do it when you read this)

Not that huge of a hurry, but would like if it gets in 2.21.


General ShaderFX composition pins don't get created

If an unknown shader type is used as a composition, the pin won't be created and it cannot be assigned. This was working at some point.

Any chance we can have more detailed descriptions, repro case for this?


Bad Style in fastpy.constrain_solver.py

you use a class as namespace where the orginal code (https://github.com/sdiehl/numpile) doesn't use a class (here) (because the orginal code only uses one file a class as namespace could be helpful)
btw: why did you rename the decorator from autojit to fast? and why didn't you fork the orginal project?

Hi @nimaje
Thanks for taking the time to right this issue.
The problem was that the constraint solver apply function was colliding with Python's built-in function apply.
The main goal of the project is for me to understand Stephen's great tutorial, that's why I've been dividing into modules and starting writting some docstrings.
The reason for renaming autojit to fast is because, in my opinion, it express the purpose of what you want when using the decorator. I don't care if the function is compile just in time, I only care about it running fast.
The reason for not forking the original project was that the original code serves as a tutorial where having a single file and nothing else is a great approach. This repo have all this files for deployment and testing that would be distracting as a tutorial. In other words, I thought the point of forking was to later do a PR, but I don't think this project would improve Stephen's numpile but rather the opposite.

you could ignore the name collision because it's only a small module and you don't need the build-in apply (https://docs.python.org/2/library/functions.html#apply).
you should use the requirements.txt from the orginal project.

This https://github.com/tartavull/fastpy/commit/eec1dee5a85d78bd583cedd133b52b714a313e34 adds the requirements, thanks for the advise.
I'll do another commit for the apply


Client.muteMember() no longer working

I already checked the permissions of the bot, a client.muteMember(user, server) no longer mutes the user.
No error returned in console, the user and the server are resolvable and are OK.
It seems working, no promises in waiting but the user can continue to type in text channels

I'm pretty sure .muteMember is for voice, and not typing, as another method close to it is .deafen (voice).

I finally just did it :
client.muteUser = function (user, channel, callback) {
	var object = {"readMessages": false, "sendMessages": false};
	self.bot.overwritePermissions(channel, user, object, callback);
}

client.unmuteUser = function (user, channel, callback) {
	var object = {"readMessages": true, "sendMessages": true};
	self.bot.overwritePermissions(channel, user, object, callback);
}

@dayxhep Don't do that! You are removing the ability to mute and unmute users in a voice channel server-wide!
Make your own function instead, or use client.removeWritePerms or something.

muteUser() does not override muteMember() in my case ^^

Right, sorry about that. I misread it.


Disabled entry fields UI

If a field is locked or not editable on a page, the UI should look different than the editable pages. Perhaps the background of field is grayed out. Including a Moodle example of a locked/disabled field as a comparison
Ex: Admin editing a course property field.
Nightly Example

Duke Skin example

Moodle comparison example

This looks fixed to me


Changing background.

Please give more details about this issue and assign this to me.

@Alitindrawan24 I opened this issue and now assign this issue to me under hacktoberfest.

can you explain what would you do in this issue ? @taneeshaa15

@Alitindrawan24  This background looks messy, I will change the colors and make it look more good.

Can you attach the new background here ? If it look more better I will assign the issue @taneeshaa15

Ok look interested, already assigned @taneeshaa15


SIGSEGV when calling some CBLAS and LAPACKE functions

Some of our tests at Gonum that use OpenBLAS as the backing BLAS and LAPACK implementation have recently started to fail due to a segfault. I've bisected it to #1625 which is also supported by OpenBLAS output that I see:
OpenBLAS : Program will terminate because you tried to start too many threads.

that comes from that PR.
OpenBLAS build info:
 OpenBLAS build complete. (BLAS CBLAS LAPACK LAPACKE)

  OS               ... Linux
  Architecture     ... x86_64
  BINARY           ... 64bit
  C compiler       ... GCC  (command line : cc)
  Fortran compiler ... GFORTRAN  (command line : gfortran)
  Library Name     ... libopenblas_haswellp-r0.3.1.dev.a (Multi threaded; Max num-threads is 4)

Let me know what other information could help investigate this.

Are your gonum tests using fork() at some point ? A related issue was noticed in the review phase of #1625, but believed fixed before the PR was merged. @oon3m0oo ?

Indeed it was, and test_fork should be passing.
You should be able to spawn up to MAX_CPU_NUMBER * 2 * MAX_PARALLEL_NUMBER threads.  How many are you attempting to spawn?  Are you doing this manually or letting blas_server do it for you?

Are your gonum tests using fork() at some point?

Our tests don't use fork and Go's testing package does not either as far as I understand.

How many are you attempting to spawn?

There is no direct control of OS threads in Go, they are handled by its runtime.
 This value can be changed. If I add a debug output to memory.c before if (next_memory_table_pos > MAX_ALLOCATING_THREADS) and run the test with 1 CPU, I can see the debug output 4 times (typically), sometimes 5 times. If I set the number of CPUs to 2, the debug output appears 6 times (typically), sometimes 7 times. And so successively until segfault.
The debug output is always printed 3 times before the actual test is run, the remaining output is printed during the test. I cannot interpret these numbers because I don't know when get_memory_table is called. Hopefully you can extract something from it.

Are you doing this manually or letting blas_server do it for you?

For this comment I've been using our test for Zgbmv which calls internally cblas_zgbmv.

Did your build environment change recently ? If you did not specify NUM_THREADS, it will be guessed from the number of cpus seen on the build host - this is where the "Max num-threads is 4" at the end of the build info text comes from.

I didn't change the build environment, and I don't specify NUM_THREADS. I just use the defaults.
It's not clear to me what changed in memory.c that previously there was no segfault and now there is. Is the check now more rigorous? Or is there now a new limit on the number of threads?
I'm sorry I can't provide a better information, this touches on areas that I'm not very familiar with (Go runtime internals, OpenBLAS internals).

Possibly a silly suggestion, but could you try to double the value in the definition of MAX_ALLOCATING_THREADS (line 500 of memory.c) just to see if this makes the problem go away or leads to crashes elsewhere ?

If I double the value of {{MAX_ALLOCATING_THREADS}}, the problem goes away.
I'll try to provide a minimal reproducer for the current value soon.

Thank you. That should at least provide a workaround that allows to include the new code in  0.3.1

I've prepared a reproducer: OpenBLAS_issue_1641.zip
It requires a working Go installation but otherwise is self-contained. To run the test I use the following command inside the unpacked cblas directory:
env LD_LIBRARY_PATH=$HOME/src/OpenBLAS CGO_LDFLAGS="-L$HOME/src/OpenBLAS -lopenblas" go test -v

The code could be smaller but at least it reflects exactly what our test does.
In my effort to minimize it I made an interesting observation. The test generates an exhaustive set of all possible input arguments for some limited number of matrix sizes. It does it by having various nested for loops that loop over a set of values for a given parameter. When I removed one or two of these loops by fixing the corresponding argument to a single value, the number of debug output lines from my printf before line 547 in memory.c went down and local_memory_lable_pos never exceeded MAX_ALLOCATING_THREADS (8 in my case). There was no segfault.
I don't speak about threads here on purpose because I really don't know who is creating them in this case, Go runtime or OpenBLAS. It is not Gonum or our tests. Does this help?
Let me know if you run into any issues with running the test.

Thank you very much. This allowed me to reproduce the problem (after doing a go get golang.org/x/exp/rand), but I am not sure yet if it is just an off-by-one error or if MAX_ALLOCATING_THREADS actually needs to be doubled.
At least I can make the test pass by just adding 1 to the MAX_ALLOCATING_THREADS variable when I run it on a machine with 6 cores/12 threads.
However, limiting the OpenBLAS build to NUM_THREADS=4 to mimick your case makes it fail again,
unless I double MAX_ALLOCATING_THREADS. (Not sure yet if/how I could tell go to limit itself to just four threads however, so this could well be very much an expectable fault). Will do some more experiments with both old and new versions of memory.c later to try to determine how many threads or buffers it is actually trying to allocate.

Hmm. Same test but building and running on a dual-core laptop (so 4 threads by default) passes without any issues (and not needing any changes to MAX_ALLOCATING_THREADS). This was with go 1.7.5 rather than go 1.9 however due to using distribution packages for different OS versions.

Setting GOMAXPROCS to the same number as NUM_THREADS makes tests pass with go 1.9 (and 1 added to MAX_ALLOCATING_THREADS) in tests with a reduced NUM_THREADS setting as well.  go 1.7.5 just seems to be using a less aggressive default (?)

Actually it looks like an off-by-one, and I somehow managed to link to a version with the "+1" already included in my tests with go 1.7.5 on the dual-core box to get the contradicting "results"...
On both systems, Go will enter the function to try and set up NUM_THREADS*2 threads,  which will make next_memory_table_pos exceed MAX_ALLOCATING_THREADS by 1 exactly. (And I recall the initial form of the PR containing a comment that the number of threads here was "the server plus the number of threads in the pool", maybe it is the server that needs to be counted in here)

Just to let you know, I still get the segfaults with the latest develop branch (I focused on Zgbmv in order not to introduce LAPACK into the game but also some of our Lapack tests fail due to this). I wrote a smaller reproducer in Go which does not use the testing framework, and I can reproduce the segfault. Then I re-wrote it in C and there is no segfault. This means that this comes from how threads are handled/launched by the Go runtime and so at the moment the behavior is out of our control. We will consider what to do next on our (Gonum) side. Thanks for your help with this.

I also see the segfaults with the patch above (for Zgbmv and Dgeev).

Do you still see the segfaults when you set GOMAXPROCS to the number of threads as shown on the OpenBLAS build message (i.e., the NUM_THREADS in use for building OpenBLAS) ?

Re-running your reproducer, I now see the strange effect that most runs start 24 threads or less (and thus run flawlessly on the six-core cpu), but every now and then Go tries to get a 25th for no apparent reason, and OpenBLAS crashes. Even the successful runs differ in the distribution of the thread invocations, sometimes Go has called for 10 threads before the "RUN TestZgbmv" is printed, sometimes 11 (but only goes for a maximum of 23), or just 9 and then 24. This behaviour appears to be totally random, apparently caused by the random nature of the input matrix elements - so the reproducer is able to reproduce both "fixed" and "broken" results.
I have not yet tried to run this with the "old" memory.c to see how many times the corresponding(?)
routine gets entered there. @oon3m0oo any idea what is going on ?

I'm also seeing this error
OpenBLAS : Program will terminate because you tried to start too many threads.
whilst building octave.
The error is triggerd by a test script in the makefile.
If I set OMP_NUM_THREADS=1 the test passes.

openblas_config= USE_64BITINT= DYNAMIC_ARCH= DYNAMIC_OLDER= NO_CBLAS= NO_LAPACK= NO_LAPACKE= NO_AFFINITY=1 USE_OPENMP= SANDYBRIDGE MAX_THREADS=4
version=0.3.1
extralib=-lm -lpthread -lgfortran -lm -lpthread -lgfortran

Openblas was built with gcc-8.1.1.

@marrowsuck you can probably get around this by setting NUM_THREADS to a higher number at build time.
@oon3m0oo I am not sure if I am comparing apples and oranges, but there seems to be a huge number of calls to blas_memory_alloc with "procpos" set to 1 (that is, originating from the STACK_ALLOC macro in common_stackalloc.h) now compared to a few weeks ago.

Do you still see the segfaults when you set GOMAXPROCS to the number of threads as shown on the OpenBLAS build message (i.e., the NUM_THREADS in use for building OpenBLAS) ?

The default GOMAXPROCS is now num_cpu which does match the NUM_THREADS reported at the completion of make, but explicitly setting GOMAXPROCS to that value does still have the segfault behaviour. Setting GOMAXPROCS to any value lower than 6 (for a build with NUM_THREADS=8) though allows the Zgbmv test to complete without segfaulting (higher than this does fail).

(Sorry was moving house over the weekend)
To be perfectly honest I deduced the factor of 2 from the NUM_BUFFERS definition, and empirically it seemed to be necessary.  There's not really a cost to increasing that number, though, it just makes the table of pointers larger, and that's trivially small.  At the same time, it would be good to either figure out exactly what the "right" number is, or make the whole thing dynamic without impacting performance.

Making this thing dynamic would be ideal, if it is possible without impacting performance. At the moment however I am still struggling to understand if/how the second (the BUFFERS_PER_THREAD) dimension of your local_memory_table is used at all ?

My current impression is that they used to allocate more than one buffer, but with the new code any attempt to do this increments the new_memory_table_pos counter same as if it was for an entirely new thread. I may be wrong though. In any case we need to get rid of the current breakage first, I take it just increasing MAX_ALLOCATING_THREADS by a factor of two (or more)  would do ?

I think so, yes.  It just means more pointers in the table, shouldn't hurt anything.

Closing as 0.3.2 is released now

I've just tested this with a variety of GOMAXPROCS values (unset, <NUM_CPU, =NUM_CPU and >>NUM_CPU). All pass. Thanks.


Activate Enter keyword while editing workspace name

Is your feature request related to a problem? Please describe.
If the user wants to edit the workspace name he/she have to click on the edit button and once the editing is done the only way to save the status (changed name) is by clicking the green tick button provided.

Would be great if "ENTER" Keyword is activated for saving the renamed string (as an additional option) along with clicking the green tick button.

I would like to work on this issue, @GaganAgarwal77  kindly assign it to me!

Sure!

@goliakshay357 can u please add the label for swoc!


Include anchors for items that people would want to reference

What article on docs.github.com is affected?
https://docs.github.com/en/actions/reference/environment-variables#default-environment-variables
What part(s) of the article would you like to see updated?
Each of the environment variables could have an <a name=... or <a id= so that I could link to a specific variable instead of just a page section and say "search for it yourself".
Additional information

e.g. I'd love to be able to send a link like:
https://docs.github.com/en/actions/reference/environment-variables#GITHUB_BASE_REF
Basically, if you have a Foo	 it's probably helpful to everyone if there's a way to link to that by a pretty name (roughly #Foo, although possibly #kindof-Foo in case there are multiple cells of Foo and one of them is a kindof and another is, e.g. an otherkind).

Example 2:
https://docs.github.com/en/graphql/reference/objects#user
I'd like to be able to link to isLocked (...) for repositories (...) for something (for example User, although I think my original example is Organization):
| repositories (RepositoryConnection!) |
-- | -- | --

isLocked (Boolean)
If non-null, filters repositories according to whether they have been locked.

Thanks for the suggestion @jsoref! I'll triage this for the team to take a look 👀

Adding more anchors throughout the docs is definitely something that would be helpful and we'll look into! Since it needs to be done on a slower case by case basis, I'm going to close this issue in favor of several different internal issues where we're tracking potential updates.
Thanks for your continued interest in improving the GitHub docs ✨


no entry file inside docker image

Docker can't find server.js file inside the image. The way to reproduce:
$ node tools/publish.js foobar
$ docker run -p 8080:8080 api

response:
Error: Cannot find module '/usr/src/app/build/server.js'
    at Function.Module._resolveFilename (module.js:527:15)
    at Function.Module._load (module.js:453:25)
    at Function.Module.runMain (module.js:665:10)
    at startup (bootstrap_node.js:201:16)
    at bootstrap_node.js:626:3

Try running this:
$ docker-compose run --rm --no-deps api yarn        # Install Node.js dependencies
$ docker-compose run --rm --no-deps api yarn build  # Build the project into ./build
$ docker build --no-cache --tag api .               # Build the production "api" image
$ docker run -p 8080:8080 api                       # Check it works

@EclipticWld the current setup expects you to build the app first, then run docker build command that copies all the compiled output into the image (COPY . .), see Dockerfile. It is possible though to tweak Dockerfile so that it would build the app during image compilation and then prune non-production dependencies. Please, let me know if the later workflow works better for you.

Thank you @koistya! That was helpful to move forward.


chore: Enforce array type styles in TypeScript

This change enforces how we type arrays, e.g. choosing between:

string[]
Array<string>

I've gone for the array-simple option 1 which enforces that:

primitive types and type references use X[]
complex types use Array<X>

For example, we'd type an array of strings as string[], but an array
of a union type as Array<SomeUnionType>.

I don't feel strongly either - the one I picked follows the Google TS style guide, but happy to change it if you feel strongly. It's easily changed in the future too (it's fixable by eslint)


Update stream id handling in spec

Discussion in https://github.com/ReactiveSocket/reactivesocket/pull/92

Moved from a PR as my change was a one liner and no longer appropriate.  Let me know if you would like me to make a first pass at the changes, otherwise I am happy to leave it to you.

Thanks @yschimke. I will make the changes and file issues, will appreciate a review.

Is the updated text sufficient? https://github.com/ReactiveSocket/reactivesocket/blob/master/Protocol.md#stream-identifiers
Or should it have more details? For example, it does not discuss what happens when the max is hit.

I believe the text currently is sufficient to distinguish what to do. Rollover would be implicit as long as 0 is avoided and odd/even is maintained.

Change is made and considered sufficient, so closing this.


Config to disable discovery initiated SAMLBackend flows

The current SAMLBackend allows a flow to start with the
disco_response() endpoint, i.e., a client passing in the
entityID of the IdP to be used for authentication. In most
deployments the flow will fail after the backend receives the
SAMLResponse, parses it, and passes control to the frontend
since the frontend does not know to which relying party to redirect the
browser. But it is possible for some deployments to make a flow that
starts with the disco_response() work so just preventing such flows is
not acceptable. This commit enables configuring the SAMLBackend so that
flows are not allowed to be started at disco_response(), and when so
configured a flow that starts at disco_response() will raise an
exception with a useful message rather than continuing on to
a frontend and failing with UnknownError.
All Submissions:

[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Have you added an explanation of what problem you are trying to solve with this PR?
[X] Have you added information on what your changes do and why you chose this as your solution?
[X] Have you written new tests for your changes?
[X] Does your submission pass tests?
[X] This project follows PEP8 style guide.

Really usefull

Here is a use case where allowing discovery initiated SAMLBackend flows remains important.
Users do bookmark the discovery service (at the time they do it, it includes the return URL to SATOSA so the bookmark is in some sense valid). Yes, they should not do that, and education can help, but it cannot stop all users from bookmarking the discovery service.
So rather than stopping the flow entirely, it is helpful to be able to allow the user to go to the IdP and authenticate. Then when the user returns, a microservice can detect there is no SP requestor, and direct the user to the VO dashboard, which contains a list of all SPs to which the user can connect. They can then click on the SP and go through the SSO flow and get to the SP, even though they started the day from the discovery service.
I have one deployment that wants to support this scenario to help reduce the communications to the HelpDesk.

Exactly, the same use case here.
But I'd prefer to stop the flow first of all. Because users get frustration in the case of a failed Auth.
Moreover in case of SAML2 forceAuthn or MFA the frustration could be come more obvious. Just drop it whit an eloquent message (yes, redirect page) that remember to user that they are should initialize session from a real SP

This feature Is really important, keep It on top of the agenda!

The problem with starting a flow from the discovery-endpoint is that the proxy does not know what the originating SP really is. The proxy is lost and crashes.
To resolve this, a configurable handler will be registered. The handler by default will stop the flow. A user will be able to configure this handler to provide different behaviour - for example redirecting to an error page or a service-selection page.
This is similar to https://github.com/IdentityPython/SATOSA/pull/324 and those two will be handled by a similar mechanism.

To resolve this, a configurable handler will be registered. The handler by default will stop the flow. A user will be able to configure this handler to provide different behaviour - for example redirecting to an error page or a service-selection page.

or a default SP?

This is similar to #324 and those two will be handled by a similar mechanism.

completely agree


Shall we really keep array[idx] = something?

Maybe we should just introduce some update notation
return true and become (balances[receiver := new_receiver_balance])

and remove assignments into arrays.

I agree.


No LICENSE file

What is the license of git-hooks?

I see the license is embedded in files, but it would be good practice to have a LICENSE file in the root of the repo as well.

https://github.com/icefox/git-hooks/commit/0a9311b039b7af07827e1c2f5a2d53ebca212697


no such module 'KeyboardKit'

I have added library using package, but it still says as title.
Although it still receives the properties, but must enter the name completely

You must link it to the KeyboardKit target under Project Settings.

I have this more problem, although it's a bit rushed because I haven't studied it thoroughly, but can you tell me about when using KeyboardCustom, when I change the ColorScheme, I want the keyboard to change color according to the default keyboard. and the second problem is that the buttons to turn on capitalization, change the number format here can change the background color in common with the keyboard color?
Thank you very much

I'm not sure I follow.

can i call KeyboardsettingsLink right on KeyboardView in KeyboardCustom


Possible Docs Typo

Hi,
Just started reading the docs, was wondering if the overview page has a typo
https://getbootstrap.com/docs/4.3/layout/overview/
It mentions Sass everywhere but the syntax shown is actually Scss which is strange especially after coming from the introduction section which only talks about Scss.

SCSS (scss files) is one of the two syntaxes of Sass: https://sass-lang.com/documentation/syntax

Yes that's true but why mix the two in one page? No other page mentions Sass at all just Scss

According to me, there is no mix in layout overview page. No matches for "scss" word in the page.
Also, other page mentioning Sass: https://getbootstrap.com/docs/4.3/getting-started/webpack/#importing-precompiled-sass

I meant overview uses Sass while other pages used Scss for example the Theme page is full of it
But if you say its not an error good enough for me, sorry for the troubles

This page uses scss for file extension, folder name, etc. as It should be because BS use the SCSS syntax from Sass.

Sass is like Japanese. Japanese can be written in hiragana, katakana and kanji, but all are Japanese.
The Sass language has Saas and Scss syntax. Both are Saas languages.
Our documents use Saas (language) to refer to broader concept.

Japanese file > Hiragana file
Saas file > SCSS file

Thanks for the clarification, i've learned from this :)


I cannot change docusaurus logo favicon.ico

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Description
Hi, please help,I don't understand why my logo didn't change to the new one after running "npm run build."

Even after I changed it to my company's logo, nothing has changed.

Self-service

[ ] I'd be willing to address this documentation request myself.

The image in your screenshot is the nav logo, not the favicon. To change the nav logo, see the link below.
https://docusaurus.io/docs/api/themes/configuration#navbar-logo


WIP: Added some (hacky) code to keep track of container layouts.

This should hopefully fix the issue with stacked layouts.

still some issues with calculating the position for labels.