Random "An unexpected error has occurred" errors when browsing material-ui.com

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When i browse material-ui.com i get error "An unexpected error has occurred".
Expected Behavior 🤔
When i browse material-ui.com i don't get error "An unexpected error has occurred".

Steps to Reproduce 🕹
I don't have concrete steps to reproduce. It happens seemingly at random when I am navigating the website.
Context 🔦
I am trying to browse the documentation. It makes browsing the documentation unpleasant.
Your Environment 🌎
$ uname -a
Linux monika 5.11.17-300.fc34.x86_64 #1 SMP Wed Apr 28 14:21:28 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
$ google-chrome --version
Google Chrome 90.0.4430.93

Thanks for the report.
Do you remember on what pages this happened?
Event if you can't reproduce it, including the steps that caused a crash might help.

I will make a more comprehensive report when i get home, if i can reproduce it then. I got a lot of exceptions in console too, but i didn't closed the page.

Hello, i was unable to reproduce it through ~10 minutes of clicking around the page simulating usage. If the issue occurs again though normal usage, i will capture a screenshot of the page and include the console output. Sorry for unhelpful report :sweat_smile:.

@fossegrim It could be an issue related to cache, we have recently pushed a new version.

Hope this helps.
Issue persist when trying to navigate back to previous pages.

I could reproduce and find the origin: ethicalads polyfill the global URL, you can try new URL('https://www.zenhub.com/') it will fail with their polyfilled version.

It should be fixed now: https://github.com/readthedocs/ethical-ad-client/issues/59.

file:///home/olavfosse/Pictures/Screenshot%20from%202021-05-05%2013-18-56.png

Are you still seeing this error and if so can you point me to where?

Are you still seeing this error and if so can you point me to where?

Yes, I encountered the error ~1min before posting the picture. The URL is in the top of the screenshot.

I hit refresh on that page until I got an ethicalads ad and I couldn't reproduce it. It's possible it's a caching issue although that seems unlikely since the CDN cache was purged over 12 hours ago. I'll continue to investigate it.

Yeah, it might be a caching issue. I will clear my cache and keep you updated if it reoccurs.


smoothboot.json generate in wrong directory on linux

Linux file system use "/" Instead of "\"

Thanks for the find. I've replaced the backslashes with forward slashes which should fix this issue.


Update DataCategoryDropdown component buttonProps type

The recent merge of main and unified-fides-2 introduced a subtle typescript linting error but that doesn't effect runtime functionally. To get around the issue the prop object was casted as the correct type.
It would be better to properly type the buttonProps prop as MenuButtonProps instead ButtonProps. This will be more clear than casting the object to the correct type down inside the component.
These areas are a good starting point for updating this.
https://github.com/ethyca/fides/blob/5a485387d8af247ec6479e4115088cbbb8394d77/clients/admin-ui/src/features/dataset/DataCategoryDropdown.tsx#L59
and
https://github.com/ethyca/fides/blob/5a485387d8af247ec6479e4115088cbbb8394d77/clients/admin-ui/src/features/dataset/DataCategoryDropdown.tsx#L25
Updating this may cause some downstream changes.

@TheAndrewJackson should this be assigned to you?

@rsilvery Yes, I think that makes the most sense. I'll assign it to myself now 👍

As discussed on #1510, this update is no longer needed.


Add tsconfig changes to the 1.6 release notes

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
The "Build and tooling changes in 1.6.0" section should have an additional point mentioning that the tsconfig file has been changed since the previous versions.
Observed Behavior
The 1.6 release notes are missing the updates to the tsconfig.json file at the root which leads to issues like this one https://github.com/SharePoint/sp-dev-docs/issues/2495
(I looked at submitting a PR but seems GitHub does not allow forks and PRs to wikis)
Steps to Reproduce
Update any SPFx project from a previous version to 1.6 as per the release notes.

Thank @vman - I've updated the wiki page.  Let me know if it is unclear or incorrect.
Pat.


Broken on julia nightly

It broke last night. but it was working yesterday afternoon.
So it wasn't something we changed.
Further I can narrow it to some change that landed yesterday afternoon, as I built julia in the morning
It works on
Julia Version 1.11.0-DEV.169
Commit 912423456d (2023-07-25 15:59 UTC)

so we need to look at commits after that
error is:
JIT session error: Symbols not found: [ jl_global#11 ]
JIT session error: Symbols not found: [ jl_global#11 ]
JIT session error: Symbols not found: [ jl_global#37 ]
JIT session error: Symbols not found: [ jl_global#39 ]
JIT session error: Symbols not found: [ jl_global#38 ]
JIT session error: Symbols not found: [ jl_global#2 ]
JIT session error: Symbols not found: [ +ChainRulesCore.AbstractZero#58, jl_global#22, jl_global#60, jl_global#61 ]

See CI logs

Let's close this. The failures on nightly are different now.


Add conditional camera offset based on cursor - Hristov Rework, Part 1

About the PR

This PR focuses on the implementation of cursor-based camera offset for entities, which is intended to be used to simulate a scope for the Hristov. This is part 1 of a two-part Hristov rework; part 2 will focus on bullet behavior, damage and balance tweaks.
When active, the cursor offset feature causes the player camera to be offset by a dynamic amount based on how far away the cursor is from the middle of the game window. This effectively makes it so that you see further in one direction and less in the opposite.
The main system that handles this is EyeCursorOffsetSystem; to activate this, a component CursorOffsetRequiresWieldComponent is also added. Systems are refactored to facilitate these (more under Technical Details).
Why / Balance

The Hristov rework is split up in two parts as they implement different features and it would be fairly overwhelming to do both at once. The two parts are also fairly disconnected from each other codewise, so it's easier to implement.
The cursor offset is set at a max of 3 tiles, which makes the Hristov a much more valuable weapon as a sniper since it now allows ranged shots from outside a normal player's view. The tradeoff of not being able to see as much behind you is relatively minor (more downsides will be introduced in Part 2) but keeps the gun from just being "zoom out" functionality.
The gun requires wielding for the offset to be applied, which is suitable since one-handing it would allow the added range to be used by other one-handed guns.
Technical details

The offset is calculated to be set between 0 and a max distance based on the mouse cursor's position around the player. This is based on a circle radius from the middle of the screen which reaches out to 90% of either the width or height of the game window, whichever is lowest (which is going to be the height most of the time). If the distance between the point the offset currently to where the mouse cursor has moved is greater than a set value, the movement is capped to prevent instant snapping which didn't feel great.
The camera offset behavior has been mildly refactored; it's now run in a central update loop instead of being spread out across multiple systems(SharedCameraRecoilSystem) and risking triggering multiple times in one frame.
WieldableSystem in Shared has been turned into SharedWieldableSystem. This is to allow the Client system to interact with EyeCursorOffsetSystem, which must be in Client due to using mouse cursor input.
Media

https://github.com/user-attachments/assets/47305895-bd71-4a77-8720-14635f8c4dc9
Requirements

[x] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: Hristov now provides an increased view range of 3 tiles when wielded.

It would be so nice to look 4 or so tiles farther in any direction in exchange for being way easier to sneak up behind. Make gunfights allot more dynamic in general. In a vein similiar to what is shown here.

It would be so nice to look 4 or so tiles farther in any direction in exchange for being way easier to sneak up behind. Make gunfights allot more dynamic in general. In a vein similiar to what is shown here.

There's a soft limit involving the PVS range that makes it so you can't extend the offset too much. 3 is a decent number for general balance but it also keeps you from seeing pop-in

Looks really cool. We also need binoculars as an item now. Any way to make it so that it is not bound to being wielded?

It would be so nice to look 4 or so tiles farther in any direction in exchange for being way easier to sneak up behind. Make gunfights allot more dynamic in general. In a vein similiar to what is shown here.

There's a soft limit involving the PVS range that makes it so you can't extend the offset too much. 3 is a decent number for general balance but it also keeps you from seeing pop-in

Sounds about right, still any extra sight makes gun battles less shooting at the edge of your screen

Looks really cool. We also need binoculars as an item now. Any way to make it so that it is not bound to being wielded?

Yes - you need a system that hooks up for when it should activate/deactivate, but the event for checking it has the boilerplate for both the hands system and the equip system. I haven't tried it but theoretically the effect is additative, so should be able to use two binoculars and get the effect of both!

Looks really cool. We also need binoculars as an item now. Any way to make it so that it is not bound to being wielded?

Yes - you need a system that hooks up for when it should activate/deactivate, but the event for checking it has the boilerplate for both the hands system and the equip system. I haven't tried it but theoretically the effect is additative, so should be able to use two binoculars and get the effect of both!

but that is also - stupid, and dumb. is there any way you'd be able to make the system NOT require that?

Yes - you need a system that hooks up for when it should activate/deactivate, but the event for checking it has the boilerplate for both the hands system and the equip system. I haven't tried it but theoretically the effect is additative, so should be able to use two binoculars and get the effect of both!

but that is also - stupid, and dumb. is there any way you'd be able to make the system NOT require that?

I am not sure what you mean? If you want to make the camera offset work for when you hold an item in your hand without wielding, you need to code a component that calls the camera offset code when not wielding. It's not difficult, but since I am not implementing that functionality I don't have a reason to take time to include that in this PR.

Still progressing?

I've made some fairly major changes;
EyeCursorOffsetComponent have been split into a client and server component. This is to help split the functionalities of changing camera offset and camera PVS distance, which it now supports. This helps avoid situations where the offset extends beyond the PVS limit, which would cause pop-in.

Bulet .60 fly so slow(standard 25) if you zoom on enemy

I've made some fairly major changes; EyeCursorOffsetComponent have been split into a client and server component. This is to help split the functionalities of changing camera offset and camera PVS distance, which it now supports. This helps avoid situations where the offset extends beyond the PVS limit, which would cause pop-in.

Now i can increase distance "zoom" on rifle?

I've made some fairly major changes; EyeCursorOffsetComponent have been split into a client and server component. This is to help split the functionalities of changing camera offset and camera PVS distance, which it now supports. This helps avoid situations where the offset extends beyond the PVS limit, which would cause pop-in.

Now i can increase distance "zoom" on rifle?

Yes, this should be possible now. Previously it was gated by the default PVS, but now that can be increased. Be aware that too much zoom may impact performance due to the amount of entities being loaded!

I've made some fairly major changes; EyeCursorOffsetComponent have been split into a client and server component. This is to help split the functionalities of changing camera offset and camera PVS distance, which it now supports. This helps avoid situations where the offset extends beyond the PVS limit, which would cause pop-in.

Now i can increase distance "zoom" on rifle?

Yes, this should be possible now. Previously it was gated by the default PVS, but now that can be increased. Be aware that too much zoom may impact performance due to the amount of entities being loaded!

You already finished required changes? Label on pr still "awaiting changes"

3 weeks we wait...


Dead link in tutorial for Quadratic and Cubic Spline

Under Quadratic and Cubic Spline in this file , there are two dead links to https://www.math.uh.edu/~jingqiu/math4364/spline.pdf.

@ChrisRackauckas, can we close this as the links mentioned have been removed?


XmlParseError when parsing entities inside an attribute

Synced to the latest code. This fragment:

...

Note: foo is the name of a custom attribute, its actual name is not relevant.
causes an exception to be thrown from XmlEntityToken.GetEntity(). At this point, the _value variable seems malformed: color:blue;foo:quot
Is this a bug?

BTW, I'm switching to using AngleSharp's XML parsing because I need to handle entities beyond the default five defined by XML. AngleSharp's XmlTokenizer usually returns XmlTokenType.Entity. However in the case of attributes it wants to resolve them itself. Why?

Hm, yes seems like a bug. quot is a known entity in XML (there aren't many). Besides that, however, please note that the XML parser really throws exceptions (conforming with W3C) and that in general  HTML documents will result in invalid XML.
The reason for resolving entities is obvious. The attribute's value is always a string and therefore needs to be resolved immediately [to construct that string]. There is no (accessible or hidden) model behind it.

Thanks.
Just so I understand - in an XML where DTD's are supported, are the character entities declared by the DTDs allowed in attributes?
Assuming they are, what I'm looking for is a way of telling AngleSharp the entities that are valid for this xml document (without using a DTD.)
That will make the AngleSharp XML parser work for all entities without the complexity of DTDs and validation. XmlReader requires DTD's to make this work, which is why I am using AngleSharp. As I mentioned earlier, XmlTokenType.Entity allows the caller to resolve entities except for attributes. Some sort of hook for attributes would complete the picture.
Adding such a hook isn't urgent however; currently only the basic entities are being used in attributes.
Cheers

DTD (i.e. a validating XML parser) was once integrated (during v0.3 times), but isn't right now and won't be in the future.
DTD is another complex beast and the burden to support DTD fully would totally overshadow AngleSharp's HTML / CSS purpose. Therefore (and it is always announced that way) AngleSharp only provides a non-validating XML parser (capable of parsing any valid XML, but not capable of validating the document against a DTD). Hence there are no additional entities; only the ones defined in XML. One could, however, think about providing a service that is used for resolving entities.

To be clear, I also don't want DTDs, I think you may have misread.

I just wanted to be clear about DTD in AngleSharp. Anyway, thanks for report. I was able to spot the issue and fix the bug. The fix will be released with v0.9.3.

Great, thanks!


What exactly can one change through eas update?

The docs say that, once you have configured your project, you can use eas update to make changes without having to create a new build.
Precisely, the docs say that

Then, make any desired changes to your project's JavaScript, styling, or image assets.

But what exactly goes under "JavaScript"? Is it only the JSX itself? Or are npm packages included in that?
I would assume from this phrase that if I were to change my app.json/app.config.ts or my eas.json, I would need to make another build.
However, if I install a new package, do I need to create another build or just using eas update will do the trick?
When I say "docs", I am referring to this page:
https://docs.expo.dev/eas-update/getting-started/

NPM packages are included since they're part of the final bundle you're updating.

But what exactly goes under "JavaScript"? Is it only the JSX itself? Or are npm packages included in that?

Javascript from npm libraries is included, but react-native packages often have native code, so when you are adding or updating a package like that you need to rebuild your app.
If you update a package and run eas update, then js code from the new version would run with native code for the old version, which in some cases might work. What will happen depends on the package, there is no one rule on how compatibility is maintained.


Switch to DifferentiationInterface

Hi @olivierlabayle,
My new package DifferentiationInterface.jl is pretty much becoming the successor of AbstractDifferentiation.jl, so I took the liberty of opening this small PR to help you make the switch if you're interested

Okay this is a bit more complicated than I thought and I can't do it blindly. Can you tell me a little more about the objects f and point_estimates for which you compute derivatives? Apparently the output of f is either a scalar or a vector? What is the type of the individual point estimates?

Hi @gdalle, thank you for taking the time to open this PR. Could you tell me a bit more about your new DifferentiationInterface.jl as compared to AbstractDifferentiation.jl and the problems it solves. I can't see any deprecation or migration notes on their github.
The f function is any differentiable function taking a vector of real numbers point_estimates and outputing a real number or a vector thereof. I have mostly resorted to splatting for now to pass the inputs since point_estimates is usually not so high dimensional in the use cases of this package.

DI takes most of its inspiration from AbstractDifferentiation, while learning from its few design shortcomings. The main improvements wrt AD are the breadth of coverage (a dozen supported backends), the caching mechanism and support for mutation, the solid testing and benchmarking infrastructure, as well as the reliance on ADTypes for backend specification. The main limitation of DI right now is that it only supports a single argument, but it should be okay for your use case if we put the estimates into a vector.
DI is already being adopted by the SciML ecosystem, and aims to become a central component of the Julia package ecosystem. Part of this involves me spontaneously asking users (like yourself) what they need 😉
Is there a way to know a priori if f outputs a number or a vector? In DI, the relevant operators have different names: gradient and Jacobian respectively

Thanks that looks very promising and I'm looking forward to integrating AbstractDifferentiation.
The problem I see at the moment with single argument function is that it would be breaking since users would have to define f as a single argument function. Most of the functions fprovided by users are pretty simple (e.g. f(x,y,z) = [y-x, z-y]) and the jacobian could be computed easily by hand. The interface is rather a convenience than a necessity and changing the interface would make the function less readable and easy to write for a user.
I don't know if there is an easy way to look into f's output unfortunately, it is a priori completely unknown from this package.
So I'd say supporting multiple argument functions and a seemless way to compute jacobian or gradient would be ideal for the change :-)

I'm sorry I'm not sure I understand the question, but basically the purpose of this package is to estimate statistical quantities that can be multidimensional e.g. [x, y, z]. Once this is done, more quantities can be of further interest, e.g. differences. One could be interested in only one difference f(x,y,z) = y - z or all of them f(x,y,z) = [y-x, z-y]. The function f is really specified dynamically as a post analysis and even though we could force the user to return a vector f(x,y,z) = [y - z], this is not very natural. Does that make sense?

I think I have a way to handle this, which is to turn everything into a vector under the hood and always compute a Jacobian. Will update the PR accordingly


Tinker/PsySH improvements

Support includes — run php artisan tinker foo.php to include foo.php before starting the shell.
Add custom presenters for Illuminate Applications, and Eloquent Models and Collections.
Pass Laravel app to tinker as $app.

See #7152
/cc @GrahamCampbell

Looks cool :) ! Maybe squash?

There is also a Illuminate\Contracts\Support\Arrayable, perhaps that is more appropriate?

I figured scrutinizer would catch all of these. Is there anything we can do to make it better enforce the Laravel coding standard?

When we're switched to PSR-2 we probably can (at least more then now)

@barryvdh Arrayable seems a bit too broad to me. It might do as a fallback, but it's definitely not the best fit for both Model and Collection.
The intent of PsySH presenters is to provide a fairly specific, tailored representation of a class. Take MongoCursorPresenter for example… a more generic presenter could work, but with a specific one you get info that you actually care about, without the craziness of a full var_dump style pile of properties and values.
The Eloquent presenters here are stubs, and should likely be fleshed out a bit with things that make sense for them. For example, the Collection presenter would probably be better off extending ArrayPresenter rather than ObjectPresenter. To be honest, I haven't used Laravel a ton, so I'm not sure what would be most useful for them to display. I figured toArray was a good baseline to start with, and I'd get feedback on the PR :)

Ideally those methods would just implement __debugInfo() and use that in the presenters, right?

When we're switched to PSR-2 we probably can (at least more then now)

We're not switching to PSR-2 anymore. Taylor doesn't want to.

Yeah, __debugInfo support should probably be added to ObjectPresenter, that might be a better baseline.
But a presenter isn't supposed to be just var_dump (which is what __debugInfo is intended to be used for). There's still a case for more tailored presenters that know about your class specifically… for example, the MongoCursorPresenter above: it shows an "interesting" subset of the properties that would be returned from __debugInfo if it were implemented. It suppresses all sorts of connection bookkeeping info. It hides limit, skip, batchSize and flags if they're not set.
Because __debugInfo is intended to be a generic solution for dumping everything about a class, it'll never be as good an experience as a dedicated presenter.

@bobthecow Thank you for doing this. I'm really appreciate your time. Sorry about being super picky. :)

I think I've addressed all the code style things. Wanna take one last pass through and make sure?

How are we looking? Should I take a shot at __debugInfo for Application? Do you want me to rewrite history at all before this is merged?

How are we looking? Should I take a shot at __debugInfo for Application? Do you want me to rewrite history at all before this is merged?

Maybe. Not my call. Ping @taylorotwell.

With these changes I'm seeing the $user I create (Eloquent object) as a stdClass instance: http://d.pr/i/192Ey/5EZbGmzT
Which prevents me from doing some more Eloquent stuff to it.

Ooh. That's not right. I'll take a look.
Does it do what you'd expect when you var_dump it?

I'm not seeing that at all, @taylorotwell:

This is using User model I got by creating a blog via laravel/laravel:
composer create-project laravel/laravel blog "dev-develop@dev" --prefer-dist

@barryvdh See the current Collection and Model presenters for what I feel is a better fit for representing them.
Collection is now presented like a (non-associative) ArrayObject, and Models are presented as objects with properties that aren't pre-flattened and serialization-ready (i.e. the values are objects where appropriate, rather than just strings and numbers and nested arrays). If we just used Arrayable and flattened things into arrays, you'd have this:

Instead, we get this:

Moved to #7208.


DSU sideloader has been stuck on "Processing system partition" at 0% for 15 minutes

Same here

DSU user space size --> 10G

Any solution? Same here

It used to work fine but after 3-4 months I tried dsu for rom and this happened. I have infinix note 10


Marked moderate vulnerability

Description
Since it's not a bug and didn't fit in any other categories I thought it could potentially fit in this category so, the issue here is that there's a moderate vulnerability with the marked dependency in the marksy package, which was detected at their own repo and it's supposed to be fixed so I guess Docz should update this dependency (if not breaking anything)

I've been looking around and seems like the Marksy dependency is at it's latest version but it doesn't have the marked latest version see related thread on Marksy repo so I guess this is no use until they decide to use marked latest version with that fix...

Thanks for reporting this @alexvcasillas, we'll keep this issue open to track marksy's progress and update when we can 👍

Hey guys, any news? I'm looking forward to use DocZ on my project, but still have this vulnerability 😢

Hey guys, any news? I'm looking forward to use DocZ on my project, but still have this vulnerability 😢


Aggregated attributes replace any IdP attributes

This issue is imported from pivotal - Originaly created at Jun 6, 2017 by Thijs Kinkhorst
At least initially, if an attribute is marked for aggregation, only the values as returned by the AA should be sent to the SP. If the IdP happens to send the same attribute with (other) values, these should be discarded/replaced.
(In the future we imagine other operatiors like add. But our current use cases always require that the AA is authoritative for attributes that it is queried for.)

This is implemented together with #146683199, part of https://github.com/OpenConext/OpenConext-engineblock/pull/424 (Joris Steyn - Jun 16, 2017)


Consider extending androidx.ViewModel in MavericksViewModel

With mavericks 2.0, the MavericksViewModel no longer extends androidx.ViewModel. This makes it incompatible with the the new hilt viewmodel integration, which offers really useful things like assisted injection and the @ViewModelComponent / @HiltViewModels.
In our app, we use hilt at a lot of places, and also have increasing usage of mavericks. This incompatibility means that we will not be able to leverage this new hilt-managed component.
For now, we've been working around the issue by using custom entry points and the MvRxViewModelFactory (we're still on mvrx 1.x). However, there are no EntryPointAccessors in hilt which allow you to access the @ViewModelComponent: which means that our only option remains to use @Singleton component and manually manage any lifecycle awareness in the injected dependency.
I'm not familiar with the reasons why mavericks no longer extends ViewModel, but would you please reconsider it?

I saw some previous discussion in issue#419 about this, but it seems to be about mvrx 1.x. A lot of the changes in hilt are with the dagger 2.31 release, so I felt it was worth creating a new issue.
There's some more information in the dagger 2.31 release notes as well: https://github.com/google/dagger/releases/tag/dagger-2.31

I saw some previous discussion in issue#419 about this, but it seems to be about mvrx 1.x. A lot of the changes in hilt are with the dagger 2.31 release, so I felt it was worth creating a new issue.
There's some more information in the dagger 2.31 release notes as well: https://github.com/google/dagger/releases/tag/dagger-2.31

@rohandhruva This is an interesting new case that HIlt added. I'm not a Hilt expert but I'm not sure how much value @ViewModelComponent has very much value when using Mavericks.
One of the things that it includes is the SavedStateHandle but with @PersistState there isn't very much value in what it offers. You can just inject an object into your ViewModel constructur using a different component and it will behave the same because the lifecycle of a ViewModel instance is the same as the ViewModelComponent instance.
Correct me if I'm wrong though.

@rohandhruva This is an interesting new case that HIlt added. I'm not a Hilt expert but I'm not sure how much value @ViewModelComponent has very much value when using Mavericks.
One of the things that it includes is the SavedStateHandle but with @PersistState there isn't very much value in what it offers. You can just inject an object into your ViewModel constructur using a different component and it will behave the same because the lifecycle of a ViewModel instance is the same as the ViewModelComponent instance.
Correct me if I'm wrong though.

@gpeal , this is more about what component we define dependencies in. If we follow the recommended pattern of the ViewModel owning the Repository, we would likely define it in an @ViewModelScoped  component.
For most components like Activity and Application, we have the ability to access the corresponding hilt component using a custom EntryPoint. However, this is not an option for ViewModelComponent or ActivityComponent.
With the way things are now, we'd end up having to define this repository in a @SingletonComponent, which means that there is no lifecycle available to automatically cancel repository operations on dispose / clear.
Per my understanding, for all of this to work, the MavericksViewModelFactory will also need to call out to the ViewModelStoreOwner.getDefaultViewModelProviderFactory() if it implements HasDefaultViewModelProviderFactory. Is that feasible?

@gpeal , this is more about what component we define dependencies in. If we follow the recommended pattern of the ViewModel owning the Repository, we would likely define it in an @ViewModelScoped  component.
For most components like Activity and Application, we have the ability to access the corresponding hilt component using a custom EntryPoint. However, this is not an option for ViewModelComponent or ActivityComponent.
With the way things are now, we'd end up having to define this repository in a @SingletonComponent, which means that there is no lifecycle available to automatically cancel repository operations on dispose / clear.
Per my understanding, for all of this to work, the MavericksViewModelFactory will also need to call out to the ViewModelStoreOwner.getDefaultViewModelProviderFactory() if it implements HasDefaultViewModelProviderFactory. Is that feasible?

@rohandhruva Do you want to check out the repo and see if you can get something working? You can start with this PR as a base, just upgrade it from HEAD to 2.31.1
https://github.com/airbnb/MvRx/pull/495

@rohandhruva Do you want to check out the repo and see if you can get something working? You can start with this PR as a base, just upgrade it from HEAD to 2.31.1
https://github.com/airbnb/MvRx/pull/495

@gpeal sure, I can definitely give it a shot!
Also, for some context, where can I read more about why mavericks 2.0 stopped extending androidx.ViewModel?

@gpeal sure, I can definitely give it a shot!
Also, for some context, where can I read more about why mavericks 2.0 stopped extending androidx.ViewModel?

@rohandhruva We wanted people to be able to use MavericksViewModels anywhere in an application, not just in conventional ViewModel use cases. Plus, we figured that since we had the ability so simplify the class hierarchy, we might as well.
This case is tricky but important. We were about to release 2.0 so your timing is good. Any assistance in figuring out a way to get things to work as-is would be greatly appreciated.

@rohandhruva We wanted people to be able to use MavericksViewModels anywhere in an application, not just in conventional ViewModel use cases. Plus, we figured that since we had the ability so simplify the class hierarchy, we might as well.
This case is tricky but important. We were about to release 2.0 so your timing is good. Any assistance in figuring out a way to get things to work as-is would be greatly appreciated.

Thank you for the context! I see that you also have a PR #503 that is using a custom component.. Let me check out that branch real quick :)
I should mention, though, that with hilt and custom components, using them is not quite as straightforward. As you noticed, you'd have to use custom @EntryPoint everywhere, which also means that you don't get access to a lifecycle aware component as a default binding.
Also, another downside is that they don't flow in the hierarchy of hilt components. So for example if we now define a new Repository that is @MavericksViewModelScoped, we can't reuse it in an injected fragment: we would have to define a new binding for it.

Thank you for the context! I see that you also have a PR #503 that is using a custom component.. Let me check out that branch real quick :)
I should mention, though, that with hilt and custom components, using them is not quite as straightforward. As you noticed, you'd have to use custom @EntryPoint everywhere, which also means that you don't get access to a lifecycle aware component as a default binding.
Also, another downside is that they don't flow in the hierarchy of hilt components. So for example if we now define a new Repository that is @MavericksViewModelScoped, we can't reuse it in an injected fragment: we would have to define a new binding for it.

@rohandhruva In normal Hilt, ViewModelComponent has a parent of ActivityRetainedComponent and here it's SingletonComponent. I would make it ActivityRetainedComponent but I can't figure out how to get an entrypoint to it. However, I think there are limited downsides. I don't think you could use a @ViewModelScoped class in your injected fragment either because of the same reason:

You also won't need custom EntryPoints everywhere. You can have the custom component and entrypoint in one place and reuse it for all MavericksViewModels.

@rohandhruva In normal Hilt, ViewModelComponent has a parent of ActivityRetainedComponent and here it's SingletonComponent. I would make it ActivityRetainedComponent but I can't figure out how to get an entrypoint to it. However, I think there are limited downsides. I don't think you could use a @ViewModelScoped class in your injected fragment either because of the same reason:

You also won't need custom EntryPoints everywhere. You can have the custom component and entrypoint in one place and reuse it for all MavericksViewModels.

Discussion continued, and ended, in the referenced PR #503.


docs(falco-exporter): correct default value for image version

What type of PR is this?
/kind documentation
Any specific area of the project related to this PR?
/area falco-exporter-chart

What this PR does / why we need it:
Just small typo in the README.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Checklist

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 4b038aa789f705f54c01633d9f48dce8e982557e

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nibalizer
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [nibalizer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nibalizer
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [nibalizer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


fixed #439

I hope this is what you're looking for...

Why??

Why??

Thank you for your participation!
This has already been fixed in past commits


Updates several dependencies

Dependencies

updates jsoup to 1.11.3 (was 1.8.2)  …
updates jcommander to 1.72 (was 1.48)
updates to rtree 0.8.6 (was <IP_ADDRESS>)

Maven Plugins

updates compiler plugin to 3.8.0 (was 3.5.1)
updates source plugin to 3.0.1 (was 2.4)
updates javadoc plugin to 3.0.1 (was 2.10.3)
updates nexus plugin to 1.6.8 (was 1.6.4)
updates surefire plugin to 2.22.0 (was 2.20)

@kennycason Please consider a 1.14 release if this PR is accepted.

@rzo1 nice man! Thanks! Yeah, I have a few other branches I've been wanting to bundle up for a release.

I should also add, that I like bumping the versions to SNAPSHOT since it makes it more clear what is or isn't in a release. I was going to do this soon so thanks for doing it in advance.

@kennycason OK :) - Just tell me if I can support with something


Rotate osdCcsAdmin credentails on creation of each cluster

Rotate IAM access keys for the IAM user osdCcsAdmin user each time we use the client to create a cluster. There is no need to permanently store these credentials since they are only used on create, the cluster uses a completely different set of IAM credentials provisioned by this user.

/hold

I'm wondering what happens during moactl edit cluster, the credentials we used to create are stored in a secret in Hive, but will no longer be valid when calling the API...

/label tide/merge-method-squash

Apart from my comment about GetRegions, this looks fine to me

/hold cancel
@vkareh comments addressed, thanks!

/lgtm
Thanks @jharrington22! :)


An array of a custom type struct does not conform to KeyStringDecodable

This model
struct Pet: PostgreSQLJSONType, Codable {
    var name: String
    var type: String
}

struct Person: PostgreSQLModel, Migration{
    var id: Int?
    var title: String
    var pets: [Pet]
}

causes this fatal error:
Pet does not conform to KeyStringDecodable

This will be due to Conditional Conformances half backed implementation I believe. I think you might need to manually extend [Pet] to KeyStringDecodable

@0xTim I have a couple of ideas on how to fix this in Core. Hopefully one of them works.

Fixed by #111

@tanner0101
Now the migration is Ok and there is a jsonb column in database for pets. but when I try to write a Person to database I get this error
[ ERROR ] PostgreSQLDiagnosticResponse.jsonb_recv: ERROR: unsupported jsonb version number 123 (EngineServer.swift:144)
[ DEBUG ] Possible causes for PostgreSQLDiagnosticResponse.jsonb_recv: unsupported jsonb version number 123 (EngineServer.swift:150)
[ ERROR ] PostgreSQLDiagnosticResponse.jsonb_recv: ERROR: unsupported jsonb version number 123 (EngineServer.swift:144)
[ DEBUG ] Possible causes for PostgreSQLDiagnosticResponse.jsonb_recv: unsupported jsonb version number 123 (EngineServer.swift:150)```


Update interaction validation

Adds some checks to reject fields that are invalid for the interaction kind. Also corrects contact to be required.
This adds a RulesBasedValidator class-level validator to do cross-field validation in a more declarative fashion. It's similar to how cross-field validation was done for investment, but more generic.
I'm planning to split up validate_utils into two modules in a separate PR.

Codecov Report

Merging #515 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #515      +/-   ##
===========================================
+ Coverage    96.62%   96.64%   +0.02%
===========================================
  Files          125      125
  Lines         3789     3816      +27
  Branches       346      349       +3
===========================================
+ Hits          3661     3688      +27
  Misses          87       87
  Partials        41       41

Impacted Files
Coverage Δ

datahub/core/validate_utils.py
97.87% <100%> (+0.99%)
:arrow_up:

datahub/search/interaction/serializers.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280d726...c35e505. Read the comment docs.


Really slow codewars

The Codewars server runs so slow, even when I want to skip a kata, train, or just view my profile I have to wait 30ish seconds. Does this have to do with not having CW Red? Or is it just a server error?

CW is working poorly for everybody, and this is an old issue. Although, the problem seems to be move severe these last few days - everything times out very often, and the loading times may go as high as a minute.

The slowest part (at least for me) is the translation editor. Takes about 5 seconds to type in 1 character (that's why I always write it in my IDE).

@Steffan153, your problem is different from this one. I've never heard about the editor lagging for anybody (there is one kata with such problem but there's a reason for it to be unresponsive). You should probably raise a separate issue.

Yeah, CW is always slow, but like @FArekkusu wrote it's even slower the past few days. It's difficult to find the cause because nothing was changed.
I'm working on some optimizations and bug fixes right now and hoping that will help.
I have no idea about the editor issue. Maybe some extension is getting in the way?

Maybe some extension is getting in the way?

Yep! It worked fine with no extensions. :smikey:

Good to know it isn't always this bad, I just started two days ago and the 30+ second wait times from clicking a button is really starting to hit me- I wish it could be faster though, as far as experience it's been my favorite of all the "coding puzzles" sites (and its one of the few with good Elixir support)

The recent performance issue is most likely caused by the increased traffic. For some reason, Codewars had the highest number of new users per month last month (20% more than previous highest), especially towards the end of the month.
@samuelludwig All of the challenges now supports Elixir 1.9. The test output is not great, but I'm planning to improve and open source it sometime soon. Elixir is one of my favorite languages.

Great platform and love it, but the slowness is a real problem. Please could we have a look at this. I use this along with Repl.it as a teaching aid and it would be a shame to abandon. The editor is fine but loading My Solutions, All Solutions and Solutions of Users I am Following is unusable at times. Submissions can take very long too.

Great platform and love it, but the slowness is a real problem. Please could we have a look at this. I use this along with Repl.it as a teaching aid and it would be a shame to abandon. The editor is fine but loading My Solutions, All Solutions and Solutions of Users I am Following is unusable at times. Submissions can take very long too.

The performance issues for solutions page for kata with many solutions are known. It's one of the last few critical technical dept, and related to the problem with the database design I wrote here, and it requires a significant effort to fix. I'd like to fix it this year.

The performance issues for solutions page for kata with many solutions are known. It's one of the last few critical technical dept, and related to the problem with the database design I wrote here, and it requires a significant effort to fix. I'd like to fix it this year.


Various fixes to metrics emitted to Kafka in MR mode.

Summary of changes:

Added getProperties method to State.
File metrics reporting can add a suffix to the filename. This is useful in MR jobs where, before, all mappers would attempt to write to the same file.
Added schema registry functionality to Kafka metrics reporting. Since this needed KafkaAvroSchemaRegistry, refactored this class from gobblin-core to gobblin-metrics.

@zliu41 @liyinan926 can you review?

Also a typo buidlKafkaMetricReporter.

@zliu41 @liyinan926 addressed comments.

LGTM other than the above.


Typings nightmare with @types/xxx

This is not a bug, rather call for help.
Since recently packages started to install dependencies from @types repo.
From this moment on none of my projects is compilable as I am using Mocha for my tests, yet one of the packages uses Jest. Both of these packages declare "describe. it ..." in the global space.
So, I have @types/jest and @types/mocha installed in the node_modules folder.
As a result, no project will compile and my CI is out of order.
The only possibility that comes to my mind is to roll back to "classic" module resolution and copy the definitions into my project manually.
Is this true? Is there anything else I can do?
[EDIT]
I put moduleResolution to "classic" and it is still compiling stuff in the @types folder!!! WHY?

I am using Mocha for my tests, yet one of the packages uses Jest

Shouldn't that package have @types/jest as a devDependency rather than as a dependency? Then @types/jest won't be installed when you npm install your own module.
Generally the packages you depend on should not bring in their development dependencies (built/test infrastucture), just their executable code.  But I can't really tell if this is the situation from the description above.

Well, I am not that package developer and this is what happens. Installing that package "Jest" appears in my typings folder.

Can I ask what the package is? If it is a deps vs devDeps issue in their package, then the fix is simple for them to make and the problem will go away for you.

Hi, I already created an issue with this. But I guess, the problem is not so isolated. Is there any other mean of protection from this apart from waiting for package developer to update and release a new version? Thanks.

Hopefully someone else can answer if there's a workaround for this.
In the mean time it would be helpful if the team promoted the proper use of depDependencies with @types typings. In the last few blog posts (e.g. here) they show installing @types as normal dependencies, which means all clients of such packages will also needlessly get those types installed, even though they are not needed to run the package code.
At best it's a useless dependency for clients, but sometimes it may lead to clashes/errors such as the one you've reported here.

If you want a complex workaround, you should be able to manually remove the unwanted folder from your transitive @types by running npm shrinkwrap to pickle your dependencies, then edit the generates npm-shrinkwrap.json to remove the @types package you do not want to include. Then just delete it from disk and the shrinkwrap should prevent it from being installed for anyone else.
It's a bit of a kludge, but it can workaround packaging dependency conflicts like this.

I was really hoping that skipDefaultLibCheck will do good here as it its said to skip validation of .d.ts files, but it seems to do nothing as .d.ts files are still validated :/

@tomitrescak, just to make sure i understand, there are two projects, one depend on mocha, while the other use Jest? or is it that you have projects that depend on both?
if it is the earlier, then the fix is to use "types" : ["mocha"] in your tsconfig.json; this will instruct the compiler to only load @types/mocha in this project, then for the other project  "types" : ["jest"] .
if it is the later. then what you need is to "break the tie" between the two declarations in some way. so options, consider creating a new folder: "overrides" , and add "overrides\jest\index.d.ts" to be what you think jestshould be. then update your tsconfig.json to include "typeRoots": [".\overrides", ".\node_modules@types"]. What this does it tells the compiler to look for types first in ".\overrides\jest"and if it did not find it to look in".\node_modules@types\jest"`.
Ultimately the fix is on the declaration file side, and i would recommend you send a PR to DT with a fix that removes the declaration of it, declare etc.. to a different package that both jest and mocha depend on.
See http://www.typescriptlang.org/docs/handbook/tsconfig-json.html#types-typeroots-and-types for more details on this.

@mhegazy thanks for the explanation. That link really helped. My problem was the first one, where a project I'm depending on was installing "jest" into @types folder, while I am using mocha. They bothe depend on global variables which were clashing.
Would be great to point to that page in the list of the compiler options.

Added links to docs in https://github.com/Microsoft/TypeScript-Handbook/commit/a83f002e6fefe9d15059beeada6cc744310444c2

Fantastic, thanks!


girl have beard

You really did a great job. Thanks for sharing. When test some image, I found when person become old,  person will wear glass, some girl have beard. How to solve that?

Hi,
Thanks for your interest in our work!
To answer the question, for age editing direction, we leverage from PTI repo. Specifically, the age editing direction learned by InterfaceGAN on StyleGAN2 trained on the FFHQ dataset often adds glass when editing face images toward old. About the entangle phenomenon for adding beard when editing face image more aged, this issue also appears when we only use W-Encoder without our phase II refinement. We assume that the current age edit direction does not work well with the latent code inveted by phase I pSp/e4e W encoder. To mitigate this problem, learning better age editing direction may help.

@di-mi-ta thansk. By the way, so how to learn better editing direction?

Ok, Thanks for your advises. By the way, how can I learn better age editing direction. I have two ideas belows.

Generator z randomly, and map to w, then synthesis the image given pretrained stylegan2 model from nvidia, then label the image with smile/not smile , then learn the editing direction.

given many real-world images, then encode it to w given pSp encoder model. Then do as same as the first method.

Is it right? which is better?


Process .mjs files by default

Modules in node > 9.6.1 can use import syntax when ran with a flag on and using.mjs extension

Note that this feature is currently marked Stability 1: Experimental.

Maybe include just the docs change? Make the example '.mjs' and '.some-other-standardish-extension' rather than '.foo'/'.bar'? I found this relatively obscure.


Create new ClinGen evidence table in rewrite version

On the evidence page in the rewrite, can we please create a new data table that displays the ClinGen evidence data?
Example GraphQL API query
ACAD9 and Exercise intolerance with lactic acidosis
Data table

Data table column
Disease/phenotype
Reported disease/phenotype
Allelic requirement
Confidence

GraphQL API field
evidences.rows[x].disease.name
evidences.rows[x].diseaseFromSource
evidences.rows[x].allelicRequirement
evidences.rows[x].confidence

Sample data
Exercise intolerance with lactic acidosis
acyl-CoA dehydrogenase 9 deficiency
Autosomal Recessive
Definitive

Within the data table, can we please do the following?

Link the value in the "Disease/phenotype" column to the relevant profile page in the Platform
Link the value in the "Confidence" column to the relevant page in ClinGen using the following construct - https://search.clinicalgenome.org/kb/gene-validity/ + evidences.rows[x].recordId (e.g. Definitive)

QC checks

SLC19A3 (ENSG00000135917) and Leigh syndrome (Orphanet_506)
HRAS (ENSG00000174775) and Noonan syndrome (Orphanet_648)
CASQ2 (ENSG00000118729) and hypertrophic cardiomyopathy (EFO_0000538) - should have two rows in the data table with one row having an allelic requirement value of "Autosomal Recessive" and the other having a value of "Autosomal Dominant" and both rows should link to different pages on the ClinGen website

Please see below for further amendments to the table specification.
Summary widget
Widget text:
evidences.count records
Detail view
Detail view title:
ClinGen
Detail view description:
Manual gene-validity curations for target.approvedSymbol and disease.name. Source: ClinGen

Can we please make a small adjustment to the data table?
Show more rows

[ ] Implement "Rows per page" feature to allow users to set number of rows visible in table

@andrewhercules adjustments have been merged. Feel free to check again and close if done.

With the latest iteration of the GraphQL API, can we please make a small adjustment to the ClinGen evidence data table?

[ ] Update "Allelic requirement" column as previously, the field was a string evidences.rows[x].allelicRequirement; however, it is now an array called evidences.rows[x].allelicRequirements with an "s". Within the column, if there is only one entry in evidences.rows[x].allelicRequirements, please display the string. If there are two or more entries in evidences.rows[x].allelicRequirements, please list the entries in an unordered list

One of the fields in the GraphQL API has deprecated - recordId - and this breaks the external links to the ClinGen website.
In the "Confidence" column, can we please construct the link to ClinGen using the studyId value instead?
The link construct will remain the same:
https://search.clinicalgenome.org/kb/gene-validity/ + evidences.rows[x].studyId
For example: Definitive

As discussed:

[ ] Add reported disease/phenotype as tooltip in disease column. The tooltip content would be “Reported disease or phenotype:\n{diseaseFromSource}”


consider using on_main_thread for flush

i suspect the reason we had to flush multiple times was because we didnt run on the main thread.  obviously this decorator is only available in the beta, but might be worth trying in your redesign.
also, another possible issue : i think you are using ui.in_background to run the pipe.  i have observed that ui.in_background does not start a new thread, but instead queues commands onto a single background thread.  as a reuslt, there may sometimes be a longer delay than might otherwise be expected, for instance if calling another ui backgrounded call from within an already backgrounded call, the second call doesnt execute until the first function exits.   i think your sh_background is more robust.

I'll definitely try on_main_thread when it comes to the scrolling. Now I am still trying to figure out the higher level structure of the re-design. Ideally to have more modular components and better interfaces. It turned out to be quite tough.
As for ui.in_background, I only use it to run commands that explicitly require to run in background (with the ampersand suffix), e.g. some_script.py &. This is because I have no good way to terminate a regular background thread, but the ui.in_background runs in the same thread as the interactive prompt so it can be nicely stopped by tapping the "X" button, for which Pythonista raises KeyboardInterupt to the running thread and allow it shutdown nicely (releasing resources etc.)
I did notice tasks are queued automatically by ui.in_background and there are comments about it in the README file.

This is now the case in the new beta16 branch. No more delayed and repeated scrolls.


pip install incremental results in TypeError

The error is:
TypeError('string indices must be integers, not str',)

It doesn't show me a full traceback so I don't know how to debug.

To enable tracebacks for Stash commands, you can run stashconf py_traceback 1. There's also stashconf py_pdb 1 to automatically go into PDB on an exception.
However it's possible that Stash pip simply isn't compatible with incremental. Stash pip doesn't use the real setuptools and pip, it just emulates the most important parts, so anything that relies on advanced setuptools features might not work. (Correct me if I'm wrong, I'm not all that familiar with Stash pip's internals.)

@dgelessus you're right. install / update commands are wrapped with context manager which pops setuptools modules, fakes them, issues install / update and then restores them back.

I… I know it's not compatible? that's why I filed the bug? :)

Right, I wasn't saying it's supposed to be that way. :) Just wanted to explain that Stash's pip is currently a completely different tool than the regular pip, so you might find that many advanced features aren't supported yet. I can't help much with fixing this, it's been a while since I worked on Stash, and I didn't work on the pip command.
Have you tried using stashconf py_traceback 1 to enable tracebacks?

I tried that and then I did pip install incremental but I don't see a traceback.
If you do this in your pythoninsta, does it work?

OK, it seems that setting py_traceback doesn't help here, because pip catches and prints the exception itself. After a quick change to make it print the full traceback, this is what I get:
[~/Documents]$ pip install incremental
Querying PyPI ...
Downloading package ...
Opening: https://pypi.python.org/packages/8f/26/02c4016aa95f45479eea37c90c34f8fab6775732ae62587a874b619ca097/incremental-17.5.0.tar.gz
Save as: /private/var/mobile/Containers/Data/Application/988D9C11-8303-4F00-90CA-0AE759911328/tmp//incremental-17.5.0.tar.gz (15527 bytes)
     15527  [100.00%]
Extracting archive file ...
Archive extracted.
Running setup file ...
Traceback (most recent call last):
  File "site-packages/stash/bin/pip.py", line 494, in run
    return ArchiveFileInstaller._run_setup_file(setup_filename)
  File "site-packages/stash/bin/pip.py", line 676, in _run_setup_file
    ep = entry_points[epn]
TypeError: string indices must be integers, not str
Failed to run setup.py
Fall back to directory guessing ...
Error: Cannot locate packages. Manual installation required.

The issue seems to be that incremental's entry_points are a string? I didn't even know that was possible, but according to the Setuptools docs this is allowed and not deprecated or anything.

@dgelessus Thanks for investigating this. Adding support for entrypoint strings seems rather complicated, so should we just ignore entrypoint definitions as strings? At least until support for entrypoint strings is added?

@bennr01 The string version of entry_points is relatively easy to convert to a dict, using pkg_resources.split_sections. As far as I can tell, there's no difference between the string and dict formats after conversion.

@dgelessus Thanks :D I will start working on a patch right away.

This is now fixed in bennr01:entrypoint_improvements, but further testing may be required.
I was able to successfully install incremental and twisted.
If you want to update to the branch containing the fix, you can:

easy way: Click this link on a iOS-Device with pythonista3 and StaSh installed: pythonista3://launch_stash.py?action=run&args=--command%20%22selfupdate%20-f%20bennr01%3Aentrypoint_improvements%22
normal way: start StaSh and run the command selfupdate -f bennr01:entrypoint_improvements


Port Electrical Build doc to markdown

The doc to be ported
Refer to the project for context

Inspiration: Eric's README updates: https://github.com/nasa-jpl/open-source-rover/pull/226#issuecomment-729933744

Here is a comment so that you can assign the conversion to me.

completed

Is there a PR for this?

#245
I also have documentation updates in #243 and #248.
Sent from my iPhone

On Feb 10, 2021, at 4:23 PM, Kit Kennedy<EMAIL_ADDRESS>wrote:

Is there a PR for this?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or unsubscribe.


proposal: crypto/rsa: vary amount of randomness used by operations

We discovered that various routines pass a deterministic randomness source to RSA routines in tests to guarantee deterministic output (which is fine) but then they also end up implicitly relying on the fact that each RSA routine reads a certain amount of randomness given certain inputs (which is maybe not fine), which sets up the next read from that randomness source a certain way. If RSA were to read extra bytes, it would break the future reads from the random source.
https://golang.org/cl/63912 adds tests for this in dev.boringcrypto, to match Go 1.9, but @agl suggests that maybe we should break this code, to reserve future flexibility for crypto/rsa. It would suffice to read just a few extra bytes, and the randomness here does not have to be crypto-strength. Something like:
c := make(chan int)
close(c)
var n int
select {
case <-c:
	n = 0
case <-c:
	n = 1
case <-c:
	n = 2
case <-c:
	n = 3
}

would be good enough, or we could expose the runtime's fastrand to crypto/rsa.
/cc @agl @filosottile

Adam agrees that we should do this, so I think as far as a proposal we can accept this. The implementation is pending.


[Request for external] Codeunit 392 Reminder-Make - FilterCustLedgEntries and SetReminderLine

Hi, I was wondering if it would be possible to change the procedures FilterCustLedgEntries and SetReminderLine  Codeunit 392 from local to external.
My team and I use this procedure a lot in our code, and changing it to external would be a huge help.
Thanks for your work, have a nice day

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Go 1.21

Removed write timeout
Use log/slog instead of github.com/rs/zerolog

@AndersTrier please try this branch


docs(ComponentExample): allow to disable html preview

Problem

Some examples are broken.
Why it happens?
HTML preview is generated using react-dom which doesn't support createPortal() from react 💣
Solution
Disable preview for examples that uses React.createPortal() in initial state.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS

not completely agree that we should disable the HTML previews for these - is there any other way to solve this problem? Can we ignore this warning somehow?
I clearly recall that it was quite beneficial to see the dropdown's HTML structure during development of this component, as well as while providing bug fixes to it.

#1529


added the train for VotesBar

integrated part of #16

mainly the train part plus some folders for if we want to separate the pages

integrated #29


Support flif

http://flif.info/

I created an interface for the C decoding library: https://github.com/Razican/libflif_dec-rs
Maybe it can be used from here or it could be adapted. It uses current development snapshot.

Thank your, but we intend to use only en-/decoders written in Rust. So no, we can’t use it here.

Oh, that'd be great, maybe in some months I can help on it, but I currently don't have time to port all the algorithm :/

I wonder if corrode could help here.

What about @dgriffen's flif pure-Rust crate? Currently it supports only limited subset of flif images, but maybe it can be enabled behind disabled-by-default experimental feature?

Just to chime in on flif support: Flif might not make too much sense for a game library. The decoding speed is notoriously slow currently (both in the official implementation and in mine). This may be improved in time but is limited by the fact that the decoding is inherently single-threaded.

Image is being used outside of game libraries, such as with Servo.

Ah, yeah in that case putting flif behind a flag sounds like it would be the best option. I'm still working on getting full non-interlaced support. That said, some of the methods on ImageDecoder don't make much sense in a flif context, especially if the image is interlaced. For example: load_rect would require loading the entire image up to that point and then just returning the decoded region. Which may be more work than the user would be expecting.


Add upcasts to subtrees when compiling

Say, I have this
Entity expr = "x + y";
var func = expr.Compile<double, float, double>("x", "y");
func(3, 4);

It won't compile because you can't add a double to a float without upcasting float to double. So, when compiling, we just need MaxType(Type left, Type right) thing to choose the right type and upcast both operands to it.

the hierarchy is float < double so you have to add f at the end of 4
func(3,4f)

@KaranChadha10 sorry, didn't notice your comment. The hierarchy is here. Yes, float gets casted into double.
But func's type is Func<double, float, double>, so I see no point in writing the arguments as 3.0, 4.0f, as they will be converted into a double and a float automatically


As a user, I would like to see a navigation bar on all pages with links to every view in the webpage.

Things to discuss:

How should we collapse the navbar (hamburger icon or navbar increases in height to encompass links going on to new line)

Navbar stays fixed at top of screen, disappears on scroll down then reappears when scrolling up, or is transparent when scrolling down etc)

Color of links, styling on hover (link changes color, a bar is put underneath or on top of the link etc)

Which links to group and which to have in a dropdown (eg for authorization see both sign up and sign in, or have a dropdown which shows both options)

Are we creating a logo of some kind to put in the navbar.

Which links should float to the left, stay in the center, or float right.

Any other things we want to implement for the navbar initially.

Are we doing all of this with vanilla CSS?

yeah.  I can do it if no one else wants to I've made a few navbars with vanilla css.

Working on this now.

I'd love to see the logged-in to look a lot like Github's navbar. Nice, clean, simple.

At the moment we don't have avatars or usernames, so right now I'm thinking just a dropdown that starts with 'Your Profile' and Log out as an option.
For things like your organizations, your inventories etc, do we want those on the navbar or will we eventually add them to the dropdown under your profile.

I'm almost thinking that the only way to navi to your org/inv is via your dashboard. Not sure what's nicest for UX.

I think at the moment we can have all links directly on the navbar, and then if it gets too cluttered we can add it to a dropdown (or maybe just change it to a dropdown on mobile).  Dropdowns are nice to reduce clutter but add 1 extra click to user experience.
As for being able to navigation to your orgs/inventories, I'm a believer in being able to get anywhere on the application from the navbar and not having to navigate through other pages (at least for small applications like this).

Alex Idea:
Instead of a hamburger icon, have a star which links to your favorited inventories etc
Have 1 or 2 other links linking to dashboard/home or both.


Serializer support for Memcached backend

I believe memcached is the only backend who did not get a default serializer here https://github.com/pallets/cachelib/pull/63.
It this a conscious decision?

Serialization for memcached is not handled by cachelib like for other cache clients (such as redis or uwsgi) and it's currently done in packages/modules that we use for bindings like pylibmc, libmc, etc (most use pickle natively if I remember correctly). So, while related, adding support for custom serializers to cachelib.memcached will entail changes of a different nature when compared to what we see in #63.
I'm open to ideas here, but for now I plan on releasing #63 as is and revisit this in the future. @elnelsonperez

There is also one important thing - pylibmc and libmc has no ability to disable unpickling. GAE memcache and python-memcached allows to pass pickler/unpickler.


Replicating UILabel default vertical align

:tophat: What? Why?
@rishi420 was working on the vertical align issue pointed out in #24 and in #30 .
The idea that the original PR suggested ( #32 ) was to add a property to check if the user wanted to vertically align the text inside the label. In my opinion, the alignment should be the same as the default for a native UILabel.
Taking this in account, what I've done is just that, by default now ActiveLabel has vertical alignment.
Closes #24 , closes #30 , closes #32
Merry Christmas! :gift:
:ghost: GIF

LGTM


Fix unsound equivalence between Dates and numbers

fixes #5539

I'm trying to remember why we went out of our way to support this. I'm going to import it to test on our internal repositories to see if that surfaces the reason.

Based on the discussion in #5539 it may have been an unintended consequence of allowing numeric operations and comparisons on Dates. This PR preserves that quality of life feature, and still maintains a type level distinction between Date and number, which is important since it very much is not a number.
An example of the unsoundness is
const a: number = new Date() + 12;

leaving a string tagged in the type system as a number.

I think at least some of this problem was introduced in a7cb6da61d26f8590272571c1f8ca2ad762b08ba

thanks! one common pattern we used was new Date(date) to clone a date, so I added a constructor for that. otherwise, whatever motivation we had wasn't worth it because this PR uncovered a bunch of legit bugs.

But this still allows multiplying Date?
https://flow.org/try/#0MYewdgzgLgBAhgLhmArgWwEYFMBOMC8yWA7jACJxRYAUAlDAFQwCMATANxA


[#121566765] Fix and disable bosh resurrector

What
We are not sure if we want to use the features covered by Bosh Resurrector. Meanwhile we do Spike to determine if we want to use it, we will disable the feature.
But the feature was broken because an incorrect password, so we will fix it before disable it.
How to test?
First test that resurrector is fixed by:

Create a custom branch reverting the last commit

git checkout -b resurrector_wip
git revert HEAD
git push

 2. Deploy bosh running the pipeline (see README.md)

BRANCH=$(git rev-parse --abbrev-ref HEAD) make dev pipelines DEPLOY_ENV=...

 3. SSH on the bosh machine (via concourse) and check that the logs indicate that resurrector is working:

    ```
$ less /var/vcap/sys/log/health_monitor/health_monitor.log
...
I, [2016-08-11T14:37:07.946532 #19625]  INFO : Adding agent 547e8bff-aa6b-4efc-9b6c-29136e04071b (elasticsearch_master/553475a7-1c63-4633-9ff8-b71bf63bcf46) to hector...
I, [2016-08-11T14:37:07.946579 #19625]  INFO : Adding agent 9cec89fc-1f50-43f7-9546-ffcd86506c90 (elasticsearch_master/38ab835e-9319-452a-95be-47a79930bd37) to hector...
I, [2016-08-11T14:37:07.946629 #19625]  INFO : Adding agent 9b834ea3-8275-4a86-8e29-8da4b36a7945 (maintenance/eff717f7-8ba8-45f6-afda-fc77c3780236) to hector...
I, [2016-08-11T14:37:07.946676 #19625]  INFO : Adding agent e607d566-58ac-425e-92e2-d47dc1f425b2 (rds_broker/71e94328-b348-49c9-a004-440be55ab04b) to hector...
I, [2016-08-11T14:37:07.946721 #19625]  INFO : Adding agent 29b4ab30-f983-4a66-aff9-0bf6e45f98f0 (parser_z2/8259c347-cfce-43b9-be43-4e4ca1e68e6b) to hector...
I, [2016-08-11T14:37:07.946792 #19625]  INFO : Adding agent c26e4b4b-ce6d-476a-a478-7122e89e8c83 (queue/2a1e103a-be3b-49b7-a151-d6950cb1efcf) to hector...
I, [2016-08-11T14:37:07.981550 #19625]  INFO : [ALERT] Alert @ 2016-08-11 14:37:07 UTC, severity 1: process is not running
W, [2016-08-11T14:37:07.981627 #19625]  WARN : (Resurrector) event did not have deployment, job and id: Alert @ 2016-08-11 14:37:07 UTC, severity 1: process is not running
I, [2016-08-11T14:37:08.184654 #19625]  INFO : Managing 1 deployment, 47 agents
I, [2016-08-11T14:37:08.184767 #19625]  INFO : Agent heartbeats received = 170
I, [2016-08-11T14:37:09.033584 #19625]  INFO : [ALERT] Alert @ 2016-08-11 14:37:08 UTC, severity 1: process is not running
W, [2016-08-11T14:37:09.033710 #19625]  WARN : (Resurrector) event did not have deployment, job and id: Alert @ 2016-08-11 14:37:08 UTC, severity 1: process is not running
I, [2016-08-11T14:37:21.900812 #19625]  INFO : Agent `30c2ebbf-e414-4faa-a482-9d14131b61a0' shutting down...
I, [2016-08-11T14:37:21.900906 #19625]  INFO : Removing agent 30c2ebbf-e414-4faa-a482-9d14131b61a0 from all deployments...

Second, try to deploy the branch. To do so:

Checkout the original branch git checkout bugfix/121566765_turn_off_bosh_resurrector
Redeploy bosh: BRANCH=$(git rev-parse --abbrev-ref HEAD) make dev pipelines DEPLOY_ENV=...
check the log, to see if the resurrector is disabled.

Who?
Anyone but @keymon

Looks like resurrector is not disabled. Maybe the property for global switch is different. It is also hard to tell what's the status of resurrections, there are 2 switches. One global and one per VM. When you do bosh vms/instances it will tell you that resurrection is active on each VM, but that's a per-VM switch. I have not found out how to get global state of resurrection. When you do bosh status it gives you state of a lot of things (dns, snapshots etc.), but not resurrection...

Not sure it helps, but I remember reading in the BOSH v257 release notes (we're using v255.8):

Keep track of resurrection status globally when it's set via bosh vm resurrection off command
When temporarily turned off no new resurrection tasks will be enqueued

I am not sure what that really means. Perhaps that it would display the real, actual resurrection status for VMs taking the global switch into account? (that is, show that it's disabled when global is disabled?).
Still not sure where to find the status of the global switch...

Ok, so you can do bosh vm resurrection <new global state>. It accepts Resurrection paused state should be on/off, true/false, yes/no or enable/disable received "disabled". So I set it to off and now all VMs show resurrection state as paused. That's probably the feature described in the release notes, because I remember that before you could have VM resurrection state displayed as active, whereas it was globally disabled.
Nevertheless, I have checked the property in hm release spec and it doesn't seem like there is typo. Moreover, by default resurrection is disabled. So I am not sure what makes it active in this case...

I am worried if we are not not disabling it because this code:
https://github.com/cloudfoundry/bosh/blob/master/release/jobs/health_monitor/templates/health_monitor.yml.erb#L121
I am setting the property to "false", but maybe that is string that evaluates true. I am trying to test it.

Found out I have resurrection: true in my bosh manifest, but already using new HM user. Concourse says it picked the last commit from this branch, so I am going to investigate how is it possible that I have true instead of false...

OK, so there is resurrection: true in bosh-manifest/deployments/aws/090-bosh-aws-stub.yml - which overrides the false set in this PR...

I was able to render the health manager config using bosh-template-renderer (see description) and I can confirm that setting resurrector_enabled: false will disable it.
I removed that from the the stub.
I also fixed the bosh-template-renderer to make allow render the bosh templates.

I removed that from the the stub.

Sounds like we could do with a unit test for this. It would have caught this issue.

Sounds like we could do with a unit test for this. It would have caught this issue.

+1, I will see to implement some testing.

@alext @mtekel I added the tests to cover the changes in this story.

Now it works. There is still a catch that BOSH shows resurrection as active when you do bosh vms --details, but that's more of a BOSH issue...
merging


Update ci image

Update of test dependecies (lwd and zcash) in CI image dockerfile.

@nachog00 can you take a look at these conflicts?  Thanks.


FR: Update Buildtools 34.0.0-rc3 to 34.0.0

AGP 8.2 its minimum supports starts at 34.0.0

this is resolved in PR #128


Create a map that events can be posted to

We need to expand the map at /tour to make a map anyone can post to. @rapicastillo are there plans to make Progressive Events in a way that specific orgs can use the same map to just list their own events?

Yes. ProgressiveEvents is planning on going about creating a map for groups. Do you have the NB API keys?

Yes I do -- I can add you to our Nationbuilder account and you can grab
them from there.
On Tue, Jul 5, 2016 at 2:03 AM Rapi Castillo<EMAIL_ADDRESS>wrote:

Yes. ProgressiveEvents is planning on going about creating a map for
groups. Do you have the NB API keys?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BrandNewCongress/website/issues/87#issuecomment-230368466,
or mute the thread
https://github.com/notifications/unsubscribe/AAFHRoBIUUKIeOyz5M43jQV8UzQDQiSwks5qSa12gaJpZM4JEnTQ
.

That would be great.

Going to close this and merge it into #98


Send pre-workshop info to participants

[ ] JD to to send email around noon on Friday 9 Dec
[ ] MVD to send Egress email after on Friday 9 Dec


[AutoPR network/resource-manager] Add application gateway backendHealthOnDemand Operation

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/5552

(message created by the CI based on PR content)

Codecov Report

Merging #4783 into restapi_auto_network-march-release will decrease coverage by <.01%.
The diff coverage is 13.88%.

@@                          Coverage Diff                           @@
##           restapi_auto_network-march-release    #4783      +/-   ##
======================================================================
- Coverage                               49.83%   49.83%   -0.01%
======================================================================
  Files                                    6207     6207
  Lines                                  174146   174158      +12
======================================================================
+ Hits                                    86791    86792       +1
- Misses                                  87355    87366      +11

Impacted Files
Coverage Δ

.../operations/virtual_network_gateways_operations.py
11.68% <50%> (+0.03%)
:arrow_up:

.../operations/virtual_network_gateways_operations.py
18.03% <50%> (+0.16%)
:arrow_up:

..._01/operations/ddos_protection_plans_operations.py
17.57% <9.37%> (-1.98%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349d6a0...97f16dc. Read the comment docs.


reference site in spanish version: info popup blocks are not translated to spanish

added it to #8


Problem with the selection of elements whose classes contain special characters

The on_expand_selection callback function almost doesn't work for websites styled by tailwind as special characters need to escaped by double backslash to be selectable, for instance bg-[green] needs to be queried as bg-\\[green\\] otherwise the querySelector() will throw an Error.

fixed in v0.4.7 🎉


Update derive_var* naming convention

At the moment the programming strategy requires:

Please note that var prefix should be used only if the function name includes the name of the variable (e.g. derive_var_ady()). It should not be used if the variable name is supplied as an argument (e.g. derive_baseline(), which has a new_var argument).

[ ] The programming strategy should be updated such that derive_var_* is used for all functions which create a single variable and derive_vars_* for all functions which create more than one variable regardless of whether the functions provides a new_var parameter or not.
[ ] Functions which do not follow this convention should be renamed, e.g., derive_baseline() should be renamed to derive_var_baseline().

In the case of functions that optionally create more than one variable, do we wish to classify them as derive_var_* or derive_vars_*? E.g., derive_disposition_reason creates one variable by default but can be tasked to create two by changing a default argument value.

We should use derive_vars_* in these cases. An existing example is derive_vars_duration().

I feel like I am being hyper-pedantic so apologies, still tuning my mind to admiral: what about functions that create a variable as a consequence of an action that's not direct variable creation?  derive_summary_records can create DTYPE, but I'm not sure that's the primary purpose of the function.

derive_summary_records() certainly doesn't fit into this naming scheme. I'd leave it as it. I case a function adds one variable plus optionaliy tracibility_vars I'd still use derive_var_* as prefix.

when the package is checked via github actions, does that count as a fresh instance of R? i ask because it looks like i'm failing a check that is coded correctly but not throwing the deprecation warning because it hits the warning verbosity cooldown. when run as
rlang::with_options(lifecycle_verbosity="warning", {   derive_obs_number(   input,   by_vars = vars(USUBJID),   order = vars(AVISITN, AVAL)   ) })
i get the intended (and passing) behavior.

All unit tests are run in the same R session. {lifecycle} implements its warnings in a way that they are only displayed every 8 hours within a single session.


Select Julian dates

A small feature request: is it possible for the date edits to allow the user to specify a calendar?
At the moment, all date edits are put through as Gregorian, eg/ wd ac Q4115189 P580 '1402-02-26' -> result
It would be great if we could have some way to explicitly set a date to be Julian if desired. (Defaulting to Gregorian unless specifically stated otherwise would probably be sensible - most people won't need to think about calendar schemes)
Thanks!

it's now (v15.2.0 possible:
wd ac Q4115189 P580 '{"time":"1402-02-26","calendar":"julian"}'

I'm not sure I get the subtleties of Julian dates, so please let me know if you see anything weird


[Outlook] (manifest) contextual add-ins not supported in JSON manifest

Learn Build status updates of commit 7b805ba:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/includes/json-manifest-outlook-contextual-not-supported.md
:white_check_mark:Succeeded
View

docs/outlook/contextual-outlook-add-ins.md
:white_check_mark:Succeeded
View

docs/outlook/use-regular-expressions-to-show-an-outlook-add-in.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 7af029a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/includes/json-manifest-outlook-contextual-not-supported.md
:white_check_mark:Succeeded
View

docs/outlook/contextual-outlook-add-ins.md
:white_check_mark:Succeeded
View

docs/outlook/use-regular-expressions-to-show-an-outlook-add-in.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


allow listen_ip and ipv6_listen_ip to contain a String or Array

This allows one to pass multiple ipv4/ipv6 addresses to a specific vhost.  I also added ipv6 and a few ssl options to the www redirect block.

As far as i can tell the test in spec/defines/resource_mailhost_spec.rb would have been failing before this change.

Awesome. Sorely needed. Thanks for this.


join multiple lines

Multi line sentences like vim's help, cannot translate well.

fix by 0f448b9


viewportSize property

Hi, I'm trying to set the viewportSize but I'm having no luck - it just doesn't seem to set. I've tried with v2.0.2 and then with 2.0.6. Any idea what I am doing wrong?
        var phantom = Meteor.npmRequire('phantom');

        var _ph, _page, _outObj;

        console.log('Starting report generation...');

        phantom.create(['--ignore-ssl-errors=yes']).then(ph => {
            _ph = ph;
            return _ph.createPage();
        }).then(page => {
            _page = page;
            console.log('Setting onConsoleMessage');
            return _page.property('onConsoleMessage', function (msg) {
                console.log(msg);
            });
        }).then (() => {
            console.log('Setting paperSize');
            return _page.property('paperSize', {format: 'A4', orientation: reportData.reportorientation})
        }).then (() => {
            console.log('paperSize set successfully');
            console.log('Setting viewportSize');
            return _page.property('viewportSize', {width: 1920, height: 1080})
        }).then(() => {
            console.log('viewportSize set successfully');
            console.log('Opening report');
            return _page.open('http://phantomjs.org');
        }).then(status => {
            console.log('Preparing to render document');
            return _page.render(reportData.filePath);
        }).then(() => {
            console.log('Rendering completed');
            console.log('Phantom process completed successfully');
            _page.close();
            _ph.exit();
        });

Environment

OS: Windows 10 64-bit
Node version (node -v): v0.12.7
package version: 2.0.6
using Meteor

This might be related to #411.

@TWKDreamState do you get an error?

@amir20 no, no error. It renders as a PDF but no matter what I set for viewportSize, it doesn't seem to make any difference to the output at all. I think it's using the resolution of the monitor as it changes depending on what screen I am using.
I've tried running a script against the binary and that seems to work.

I am not sure why it's working for me then. Maybe viewportSize and paperSize is conflicting?
Here is what I had
import {create} from "phantom";

(async function() {
    const phantom = await create(["--ignore-ssl-errors=true", "--local-to-remote-url-access=true"]);
    const page = await phantom.createPage();
    await page.property("viewportSize", {width: 1920, height: 1080});
    await page.open("http://google.com/");
    await page.render("google.png");
    console.log("Page rendered.");
    phantom.exit();
}());

@amir20 I can confirm that removing the paperSize does indeed allow the viewportSize to work correctly.

That's a question for phantom I am not sure. This client is just a wrapper.


Run Github actions only once per day

Test failures were due to a numerical test error in the DynamicHMC tests. Hopefully they are gone after fixing a seed.

OK, now the test errors are the same as in https://github.com/TuringLang/Turing.jl/pull/1190:
ERROR: Unsatisfiable requirements detected for package CSV [336ed68f]:

OK, now the test errors are the same as in #1190:

thanks @devmotion. The error seems unrelated to changes in this PR, so I'm going to merge this now.


Expect random number but everytime is the same with Nunit

       [Test]
        [Repeat(10)]
        [AutoData]
        public void TestIt(int a,int b)
        {
            Assert.Positive(a + b);
        }

I use repeat attribute to let the method run 10 times,and I expect each time both a and b have different values but I got  the same value 10 times.

I'm getting the same results with this test code.
using AutoFixture.NUnit3;
using FluentAssertions;
using NUnit.Framework;
using System.Collections.Generic;

namespace UnitTestProject1
{
    [TestFixture]
    public class UnitTest1
    {
        private List<int> usedInts = new List<int>();

        [Test]
        [Repeat(10)]
        [AutoData]
        public void TestIt(int a, int b)
        {
            usedInts.Should().NotContain(a);
            usedInts.Should().NotContain(b);
            usedInts.Add(a);
            usedInts.Add(b);
        }
    }
}

Thanks guys for raising the issue.
I'm not using NUnit (prefer xUnit), so I don't have experience with this attribute at all. But according to the documentation it looks like an expected behavior. Could you please describe why you expect to have different input for each run?
cc @Kralizek as NUnit user - please share your opinion as well 😉

I never used the said attribute. But I agree, from the documentation you linked it would seem that the nunit execution engine would store the parameters used for the first execution.

to increase the randomness of test.

Well, it's more about the desirable behavior, rather than explanation that current behavior is incorrect 😉
If you wish, you could easily implement your own AutoData attribute that will have e.g. Repeat property. Use the existing implementation as a base.
Please let me know if you need my further assistance.

thank you for you suggestion,I'll have a try


Documention in this md file Test-EsxiCertMgmtChecks.md needs correction

Code of Conduct

[X] I have read and agree to the project's Code of Conduct.

Module Version
1.5.3
Motivation
No response
Suggestion
The description in Test-EsxiCertMgmtChecks.md is given for a wrong cmdlet (Test-VCFCertMgmtChecks ) which should be Test-EsxiCertMgmtChecks

Resolved.


Add russian locale

Add russian locale (#78)

Большое спасибо, this looks great. I appreciate the contribution.


Running button to « play » only specific groups.

It would be great to have a running button similar to rgthrees to run only the workflows in a specific group. This is interesting if you have different tools within a workflow like LLMs were you just want to have a query for a prompt that will help you but it’s not necessarily part of the main workflow. If that makes sense.

If this is an rgthree feature ( https://github.com/chrisgoringe/cg-controller/issues/454#issuecomment-2541394871 ), we could have, a button in each controller window that calls directly for this rgthree function.
We have plenty of space in the bottom header.
We could use the same icon.

But maybe we could have an user option to enable this first, like rgthree.

Yes that is it. when you select a group in the controller have that play button next to it.
Yeah it could be activated like rgthree or have it by default.

I’ll take a look at the rgthree version. My first preference would be to
hook into their code rather than reinventing.
On Sat, 14 Dec 2024 at 10:26 am, YVD @.***> wrote:

Yes that is it. when you select a group in the controller have that play
button next to it.
Yeah it could be activated like rgthree or have it by default.
—
Reply to this email directly, view it on GitHub
https://github.com/chrisgoringe/cg-controller/issues/455#issuecomment-2542541827,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBLMA5I57KAWI7OUAEA25L2FNULJAVCNFSM6AAAAABTSUNCWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBSGU2DCOBSG4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


[DATA-1053] Only use id as a package identifier in Get/DeletePackageRequest

Corresponding app PR: https://github.com/viamrobotics/app/pull/1151
Context here on the change to the package identifier.
The above app PR moves all usage to id. The first usage of PackageService in RDK is already using id: https://github.com/viamrobotics/rdk/pull/1829

@stevebriskin Could you force-merge this change? Have the corresponding app change approved and ready to merge right after.


Prevent direct access to interface statics.

Prevent direct access to interface statics.
For :def F1(i: Iface) and :def F2(o: Obj) handle reading statics.
static access tests.

@yegappan This, #13007, seems to take care of preventing access to the interface statics.
There 's the problem that
def F(i: I)
    var x = i.s_var
enddef

gets the compilation error as mentioned. The error's coming from vim9expr.c (I took a look (now that my  panic over statics is milder (still don't like the semantics but it is what it is)). Need to generate the code with the index from the object not the interface, the object was just pushed, not sure how to get hold of it and then generate the code.

This PR got a lot bigger, it now handles :def F1(i: Iface) and :def F2(o: Obj) reading statics through the argument. I haven't tried to write a static, or tried much at the script level; haven't tried access control; so there will need to be follow on PR(s).
Most important is to take a look at the overall approach, adding a is_static argument and isn_arg.classmember.cm_static. I did this first for the GET_ITF_MEMBER, and was going to ask for review on that. But then I took a look at GET_OBJ_MEMBER and saw that it was almost done as well; after all, the two are handled together in the code.
I think there's also a bug around vim9class.c::189. I'll fold in the fix if you agree.
Will look at tests now. They'll be needed whether or not this approach is sound.

Added small commit to fix scriptlevel crash: var x = I.s_var1 wrong messge: I.s_var1 = 7

Crap. There's a conflict with the last item in error.h. Wonder how that got there. I'll check it out.

Just my opinion, but a big PR that touches a lot of files and even adds a new struct member (probably avoidable) only to provide a temporary workaround to a crash that should be solved in some other way, also concerning the current bad implementation of interfaces that needs to be redesigned, is not worth it.

Re-assigned Enumber  for new error message, fixes conflict. vim9 tests pass.

Added some static access tests
Some additional tests to cover areas exposed by Codecov.
One part of static access protection (not generally covered yet)
    vim9expr.c::compile_class_object:423
        semsg(_(e_cannot_access_private_member_str), m->ocm_name);

Note: the additional siemsg not tested
    vim9class.c::object_index_from_itf_index:227

Not part of this change.
    vim9compile::compile_load_lhs with_index()
        return generate_GET_ITF_MEMBER(cctx, cl, lhs->lhs_member_idx, type,

@yegappan I think this is complete.
I was looking through my notes and list_instructions probably needs a tweak; it can be done as a follow on PR or an additional commit to this PR.
This PR essentially adds a cm_static option to ISN_GET_OBJ_MEMBER and ISN_GET_ITF_MEMBER.
Currently when disassembling we see
1 ITF_MEMBER 0 on I
1 OBJ_MEMBER 0

One thought is to append [ static] as needed. Current listing is unchanged.

Rebase/push to incorporate current master and fix conflict.
Next push, enhanced error message, will be easier to see only those changes.

@yegappan pushed error message update.


64bit Windows release

Any plans to add a 64bit client release for Windows?

There is currently no plan to add a 64 bit release for windows.  Why you might ask? 😆

It adds another point of failure for the application
Adds another architecture to test
The update server I use doesn't support it very well
32bit applications are smaller and run on both 32bit and 64bit
We still support windows 7 (which could be 32bit), when Chromium drops windows 7 support, which won't be for many years, we can consider dropping 32bit support.

TLDR: A long way in the future it might happen, but there is no real reason for it to happen right now