Unmanaged Empty Backlinks

Allows empty backlinks in unmanaged realm objects.
Fixes #1106

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

9 of 21 (42.86%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.1%) to 89.147%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/src/results.dart
5
17
29.41%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
3146

Relevant Lines:
3529

💛  - Coveralls

We should not change the output of the generator for this in my opinion. This should be handled in the accessor.

How could we know in the accessor that this is a backlink?

#1106

We have an user request with a reasonable argument: https://github.com/realm/realm-dart/issues/1106#issuecomment-1387179707

.NET throws an exception. Why are we diverging on this?

We have an user request with a reasonable argument: https://github.com/realm/realm-dart/issues/1106#issuecomment-1387179707


[BUG]Bedrock Claude Chatで最初の質問から、「回答中にエラーが発生しました。」で先に進めません。

Describe the bug
I am new to Amazon cloud. Never used before for the on-going project. Just a test project I have done before.
I wanted to try Bedrock Claude Chat.
When I input
"Which city is the capital of Japan?
To Reproduce
Steps to reproduce the behavior:
1.git clone https://github.com/aws-samples/bedrock-claude-chat.git
2.cd bedrock-claude-chat
chmod +x bin.sh
./bin.sh
3. Go to 'https://xxxxxxxx.cloudfront.net/.'
4. Login
5. Input  "Which city is the capital of Japan?
6. See error as Screenshot
Screenshots

Additional context

Have you enabled LLM models?

In the us-east-1 region, open Bedrock Model access > Manage model access > Check all of Anthropic / Claude 3, all of Amazon / Nova, Amazon / Titan Text Embeddings V2 and Cohere / Embed Multilingual then Save changes.

Thank you very much for your information. It is working now.


Render DELETE action for notifications

Notifications can be deleted through the DELETE method, yet we don't
render that as an available action when we return notification members
through GET. This is beecause the method has been enabled but no
action has been configured. Configuring a delete action solves this
problem.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1420872
@miq-bot add-label api, bug
@miq-bot assign @abellotti

Thanks @imtayadeway for fixing this  🎵


Bug 1999605: ceph: making script backward compatible with python2

Variable name exec, was raising an error with python2.
Renamed it to execErr.
Signed-off-by: Arun Kumar Mohan<EMAIL_ADDRESS>
Description of your changes:
Which issue is resolved by this Pull Request:
Resolves #
Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Skip Tests for Docs: Add the flag for skipping the build if this is only a documentation change. See here for the flag.
[ ] Skip Unrelated Tests: Add a flag to run tests for a specific storage provider. See test options.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.
[ ] Pending release notes updated with breaking and/or notable changes, if necessary.
[ ] Upgrade from previous release is tested and upgrade user guide is updated, if necessary.
[ ] Code generation (make codegen) has been run to update object specifications, if necessary.

@aruniiird Could you use cherry-pick -x <hash> to create the commit?

/bugzilla refresh

/ok-to-test
/cc @travisn


Changes to add CI telemetry event for logging a variable

Task name: PublishCodeCoverageV1
Description: Adding a CI telemetry event for publish code coverage V1 to log the variable disable.coverage.autogenerate
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) NA
Attached related issue: (Y/N) Y
Checklist:

[ ] Task version was bumped - please check instruction how to do it
[ ] Checked that applied changes work as expected

Can you please add the testing screenshot by running the PCCRV1 task by providing a sample cobertura.xml?

azp /run

/azp run


Move bulk of scope script logic into entrypoint.sh, extend testing

Fixes #523 by moving the detection and communication with Weave into the Scope container (and out of the scope script).
Will also help towards #329.
Also

Add test for clustering without weave
Update test image to docker 1.8
Stop publishers when they are replaces (fixes #531)
Poll DNS every 10s to speed up scope clustering

Why not move most of the logic straight into the go code? instead of the bash? Just expediency?

Why not move most of the logic straight into the go code? instead of the bash? Just expediency?

Yeah we should do that at some point; that would help with #510.  But thats a bigger change, and this gets us some of the way there for now.


printQRCode issue

[Sun Apr 26 2020 07:49:03.847]  LOG      [TypeError: _reactNativeEscPos.EscPos.printQRCOde is not a function. (In '_reactNativeEscPos.EscPos.printQRCOde("Proxima b is the answer!")', '_reactNativeEscPos.EscPos.printQRCOde' is undefined)]

Got this error on printQRCode, haven't the problem with printSample, just {QR[xxx]} is printed as-is. No QR code displayed.
@leesiongchan do you have an idea? I checked the code and the method is correctly defined.

Hi I see a typo, "printQRCOde" it should be "printQRCode"

Aha! Its my typo in README, I have fixed it!


Add tests for conditionals and loops

Currently missing testing for the new conditional and loop functionality.

Moved to issue #63.


Added missing value warning

jsYaml.safeLoad('test:', { 'onWarning': (err) => { throw err  } })
Input
test:
output
Missing value
at line 1

IMO it's better to leave this to linter tool. There is nothing wrong with this notation.

Maybe an additional event like 'onHint'? I don't want to use a linter only for this special case.

Maybe an additional event like 'onHint'? I don't want to use a linter only for this special case.

That's not enough for mainstream changes.  onXXX are kludges, and i strongly against adding new ones.

"I need that" - bad agument.
"Many users need that" - better, at least.

At first glance, suggested change is personal opinion based, with alternate solution (linter) already available. If i missed something - let me know.


[Bug] Activity code is not invoked inside await

Description of the bug
Trying to execute the same activity method multiple times with different args inside my workflow. Sometimes the code inside the activity does not run, but in the history it says its completed (no exceptions thrown)...
To Reproduce
workflow code (activity mentioned is "notifyCustomer"):
    #[WorkflowMethod]
    public function create($projectPayload)
    {
        $customer = yield $this->externalActivities->execute("createCustomer", [$projectPayload->hostName]);

        $property = yield $this->externalActivities->execute("createProperty", [$projectPayload->zipCode]);

        $createProjectWorkflow = $this->externalProjectWorkflow->execute([false]);

        yield Workflow::await(fn() => $this->projectOfferAccepted);
        yield $this->notificationActivities->notifyCustomer("A cleaner accepted your project offer");

        yield Workflow::await(fn() => $this->projectPreCharged);
        yield $this->notificationActivities->notifyCustomer("We reserved the project amount in you credit card");

        yield Workflow::await(fn() => $this->projectStarted);
        yield $this->notificationActivities->notifyCustomer("The cleaner has started the project");

        yield Workflow::await(fn() => $this->projectFinished);
        yield $this->notificationActivities->notifyCustomer("The cleaner has finished the project");

        yield Workflow::await(fn() => $this->paymentCreated);
        yield $this->notificationActivities->notifyCustomer("We successfully charged your credit card with the project amount");
    }

Activity code:
#[ActivityMethod]
    public function notifyCustomer(string $message)
    {
        Notification::create([
            "message" => $message
        ]);

        return Str::random();
    }

Screenshots/Terminal output
History with one of those been successfully executed and the other returning null:

Additional context
It might be because of the same activity name method... When changed the code to this:
yield Workflow::await(fn() => $this->projectOfferAccepted);
        yield $this->notificationActivities->notifyCustomer("A cleaner accepted your project offer");

        yield Workflow::await(fn() => $this->projectPreCharged);
        yield $this->notificationActivities->notifyCustomer2("We reserved the project amount in you credit card");

        yield Workflow::await(fn() => $this->projectStarted);
        yield $this->notificationActivities->notifyCustomer3("The cleaner has started the project");

        yield Workflow::await(fn() => $this->projectFinished);
        yield $this->notificationActivities->notifyCustomer4("The cleaner has finished the project");

        yield Workflow::await(fn() => $this->paymentCreated);
        yield $this->notificationActivities->notifyCustomer5("We successfully charged your credit card with the project amount");

And it worked (tried sometimes to make sure it was not a coincidence)

Closing due to no feedback.


Feature request: file navigation panel.

If micro would get its own navigation panel (should, maybe, behave just like Ctrl+G for help), then this would put it in a whole new league (from being an editor of files to being an editor of projects).
I am constantly in the situation where I need to open/close more files from the current directory/project/etc. Going through the tab completion is ok, but things could be better.
A navigation panel is much faster.
Also, temporary previews of the currently selected file in the panel would be "the bomb" :)
Keep up the good work!

Possible duplicate of #249
but I agree that a preview in the side panel would be amazing, but I think it is not really required

Yeah, was thinking of that initially.
The Linux/Unix philosophy, do one thing only, and do it well.
Still, it would be nice to have, even as a plugin.
I'm closing this. Thanks for pointing me to #249.
Cheers.


An extra title bar is shown for a second VS Code window in full screen mode

Steps to Reproduce:

Open a VS code window. Make it full screen
Open a new VS Code window
New window opens a  second tab in full screen mode
A Title bar is shown for second window which is not there for first window

New window no longer opens as a tab

Hmmm, it will be such a pity to remove this accidental feature.
This tab is great for multi-project navigation, especially in Mac where mission control just sucks at navigating.


Is this a replacement for the ControlledRouter component?

Hi!
I've just found this digging react router repos. I didn't inspect it too deeply but for me it seems like it's almost the same as this package.
Is this different? Or will the ControlledRouter replace need for this package when it's ready?
Thanks!

Short answer is yes. This is a replacement for the ControlledRouter.
AFAIK ControlledRouter uses two-way data flow but ConnectedRouter uses one-way data flow (follows the React/Flux way) and simplifies the logic inside.
This project was originated from the discussion by @lourd and @timdorr.

Thanks for the answer and the project =)
The say it's Redux implementation, it was strange if it's two-way data flow. But the discussion you mentioned makes it clear what the difference is.
BTW, Did you fix the time travel feature?

Yes. It works!


iOS Library not loaded: @rpath BleClientManager

I get following error message if I run on my iOS device:
dyld: Library not loaded: @rpath/BleClientManager.framework/BleClientManager   Referenced from: /var/containers/Bundle/Application/2674B4D0-D879-4940-84B3-3CE7994CFA82/ishareit.app/ishareit   Reason: image not found
My app freeze at the start screen. On android I had no problems, any ideas ?
Fixed
Add the Framework to Embedded binaries

The problem for me was that in Build Phases > Run Script I had the checkbox Run script only when installing checked for the carthage copy-frameworks script. That needs to stay unchecked.

I needed to do a project clean and rebuild, HTH

@jcady
Hi I did the sma ething but the error still existe in xcode 9.1
But working fine in xcode 8.3.2
Can you suggest how to make it work in xcode 9.1


feat: Add nullable = false to variables with defaults in submodules

Description
This PR sets nullable = false on variables in the policy and rule-group submodules.  This causes terraform to use the default variables instead of null when using the submodules outside of this module.
Motivation and Context
If you are trying to use the policy and/or rule-group submodules outside of the main module, you cannot utilize the defaults in the submodules' variables by using null as the value in a variable.
Breaking Changes
This should not break anything
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects
I applied the complete example and also validated that the submodules behave as expected when null values are passed into them.
[X] I have executed pre-commit run -a on my pull request

@bryantbiggs Not sure if you're the correct person to tag, but would be nice to get this reviewed/merged

its not going to be something added fairly quickly - theres quite a bit more work involved before this would be added


WIP: Tooltip

Do not merge yet! Progress:
No sorting:

With sorting (But the bins here are fake, its a work in progress):

Looks like great progress!
I think that a "Z=" before the scores (e.g., "Z=1.18", in the first
example), would help clarify what we are looking at.
On Mon, Dec 4, 2017 at 8:43 PM, Anisha Keshavan<EMAIL_ADDRESS>wrote:

Do not merge yet! Progress:
No sorting:
[image: screen shot 2017-12-04 at 8 41 42 pm]
https://user-images.githubusercontent.com/972008/33590362-9eb6c27e-d933-11e7-8760-4209fba00f84.png
With sorting (But the bins here are fake, its a work in progress):
[image: screen shot 2017-12-04 at 8 42 42 pm]
https://user-images.githubusercontent.com/972008/33590378-bd0b31a6-d933-11e7-8ccc-31607e2974d6.png
You can view, comment on, or merge this pull request online at:
https://github.com/yeatmanlab/AFQ-Browser/pull/216
Commit Summary

wip: tooltip shows on selected lines
wip: getting all info into the tooltip
wip/brk: extracting the labels
BRK: how to get bins

File Changes

M afqbrowser/site/client/css/style.css
https://github.com/yeatmanlab/AFQ-Browser/pull/216/files#diff-0 (16)
M afqbrowser/site/client/js/afqb.js
https://github.com/yeatmanlab/AFQ-Browser/pull/216/files#diff-1 (3)
M afqbrowser/site/client/js/sortable-table.js
https://github.com/yeatmanlab/AFQ-Browser/pull/216/files#diff-2 (36)
M afqbrowser/site/client/js/tract-details.js
https://github.com/yeatmanlab/AFQ-Browser/pull/216/files#diff-3
(119)

Patch Links:

https://github.com/yeatmanlab/AFQ-Browser/pull/216.patch
https://github.com/yeatmanlab/AFQ-Browser/pull/216.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/yeatmanlab/AFQ-Browser/pull/216, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHPNkhvPXPjKZxHxGT6byNoX6646Pxaks5s9MoKgaJpZM4Q1uhL
.

sorting on a number column:

sorting on a non-number column:

Also, for more than 2 bins:


v6: prefer components in normalizeComponent

We have been using v6.10.0 and one of our cell components was changed to use React.memo and the table unexpectedly stopped working. It looks like other have users reported issues with normalizeComponent in various versions and some fixes have been made.
Unfortunately some users have code that assumes the "components" are just a element factory and not a true React component. When these React components are defined inline this can cause  unmounts when the parent component is re-rendered. This branch will not fix that issue but I think instead users should avoid creating inline components and just use React context if you absolutely need to provide anything to these components.
The fix for us was to use isValidElementType from react-is for component detection and allow us to use React.memo, React.forwardRef, etc. We think this solution is cleaner and providers a more predictable API. We weren't comfortable with the existing String(component).includes('.createElement') detection and have a lot of examples where that fails.
I understand that this probably won't be merged but it could be helpful for others that might fork this lib. Thanks!
Other changes

updated prop-types peer dep to ^15.7.0 because that is when elementType was introduced
add react-is peer dep
update column "renderer" prop types to more closely reflect the new logic in normalizeComponent

Just running into the same issue with React.memo and React.forwardRefwrapped component.
Hope this PR got landed soon.

Make react-is a direct dependency and you've got yourself a deal.

Done! Thanks


Underscores in urls for pyproject.toml not supported for [tool.poetry.dependencies]

Sorry in advance if this isn't the right repository to file this issue under - I could not determine the source of the schema for this section of pyproject.toml.
I'm getting spurious validation errors for the urls in my [tool.poetry.dependencies] section.
It works for many of the entries, but any urls that have an underscore (or a few other characters like %20) in them are flagged as not matching the schema:
As an example pyproject.toml
[build-system]
requires = ["poetry-core"]

[tool.poetry]
name = "foo"
version = "0.1.0"
description = "my foo project"
authors = ["Name"]

[tool.poetry.dependencies]
my_repo = { git = "git@github.com:user/my_repo.git"}

This will report an error:
{"git":"git@github.com:user-roc/my_repo.git"} is not valid under any of the given schemas

Indeed this is not the right repository :-) The right repository is SchemaStore and they already have an issue for this AFAICT: https://github.com/SchemaStore/schemastore/issues/3575. So you can follow that one and I'll be closing this one. As soon as it's fixed on the SchemaStore side, it will work in Taplo.

@ia0 I have the exact same issue with taplo bundled in Even Better TOML in VSCode.
Is it because no version has been released for a year ?


move imgcat to non-iterm2 variant

Move dockerfile to this variant of imgcat https://github.com/eddieantonio/imgcat#build

Then test across platforms


Please ad the actual solution id to entry properties when calling "AvailableApps"

Currently you only list the internal id of the solution. Without the actual solution id, the one coming from package-solution.json, we have no way of getting the internal id for a solution we already know the actual id for. The current lack makes working with site scripts and the "InstallSolution" verb really annoying, as I have to install the solution before I can actually create the site script. Not really ideal for ISVs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 97580aa9-d30e-fc44-e83f-ae11422e7aa6
Version Independent ID: 83691fea-7fbc-1b87-7c3f-08152d28f136
Content: Application Lifecycle Management (ALM) APIs
Content Source: docs/apis/alm-api-for-spfx-add-ins.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Good suggestion, but the best place for feature requests is UserVoice https://aka.ms/sp-dev-uservoice as that's where MSFT triages feature reqests.


Feature: ColorFiltered

Useful link to dev team: https://api.flutter.dev/flutter/widgets/ColorFiltered-class.html
Implementation as part of Container or as stand-alone?


Compliance table

Codecov Report

Merging #33 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   41.12%   41.04%   -0.08%
==========================================
  Files          36       36
  Lines        3596     3603       +7
==========================================
  Hits         1479     1479
- Misses       2117     2124       +7

Impacted Files
Coverage Δ

src/types/types.jl
84.93% <ø> (ø)
:arrow_up:

src/JEMSS.jl
100% <ø> (ø)
:arrow_up:

src/decision/move_up/comp_table.jl
0% <0%> (ø)
:arrow_up:

src/decision/move_up/move_up_common.jl
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 495110f...ebe22b2. Read the comment docs.


Programmatic skip scenario feature

@sriv
This is a discussion and proposal for a programmatic skip scenario feature.
Before providing the actual code changes I'd like to discuss, review and agree on how this should be implemented in the different gauge components.
The proposed programmatic scenario skip feature is similar to the C# NUnit programmatic test ignore feature.
Scenario skip should be possible during execution of a correct scenario in a hook or step method.
Note that this is different from the present skip of a scenario during the validation phase when some step is missing or invalid.
Although the idea is that the outcome would be similar where the scenario is reported as skipped.
Implementation proposal:

'SkipScenarioException' is added to 'gauge-csharp-lib'
'SkipScenarioException' can be used in a hook or step method to programmatically throw an exception that indicates that the scenario execution is interrupted and results in a scenario skip.

'gauge-dotnet' has logic in  'HookExecutor Execute' and 'StepExecutor Exceute' to catch  'SkipScenarioException' and report the condition with 'ExecutionResult'
'SkipScenarioException' is not a scenario failure. An additional status bool 'skipScenario' is added to 'ExecutionResult'

The gauge runner has already logic to mark a scenario as skipped. This logic is used to handle  'skipScenario' in the  'ExecutionResult' during scenario execution.

Our question is now if the above is clear enough to proceed with actual updates implementation?

@sriv
Any comments regarding the above functionality proposal?

I need to think this through @PiotrNestor . The first thing that hits me is the impact on statistics especially for table driven execution.
And a couple of other scenarios. Will list them in some time.
More importantly, how would this feature help? Genuinely interested in the use case

@sriv
There are a number of use cases to programmatically skip a scenario:

An integration with a test management tool that holds the list of scenarios to be executed and drives the test suite execution. When a scenario starts, an API call to the test management is made to check if the scenario is in the run list. The scenario is then skipped if not in the list. Presently this functionality needs to be achieved using some cumbersome pre-execution step that matches the scenario list with the gauge tag functionality.
Some test condition, configuration or capability is not fulfilled at runtime. It is possibly more suitable to skip the test in stead of failing the test. Presently there is no such option. The 'tag' functionality it too static to handle this.
The programmatic skip functionality exists in other test frameworks. If they have it we want as well :)

hi @PiotrNestor , apologies for the delay.
As a feature I can understand this can be useful. I am interested to know your thoughts on the below:

gauge takes a list of scenarios as part of its arguments and the scenarios are expected to be run in order. Is this something that can help? i.e. rather than lazy evaluation of skipping a scenario it gets filtered out eariler. I am not referring to tag based filtration rather something like gauge run specs/spec1.spec:4 specs/spec1.spec:32 to run only two specific scenarios. The list can be computed based on input from your test planning tool.

The benefits: it keeps the logic of planning your test execution outside the test suite and your test suite need not connect to the test planner (useful if you are running it in CI).
it also helps to cache the result and keep it such that you dont need to fetch the list to be executed at every run if the data is static.
the cons: It makes the orchestration a bit tricky.
There is also an open issue with table row selection which might hamper this ( but to be fair, this will be the case irrespective of the approach)

data driven execution

when using a data table (or a csv) for table driven execution the same scenario gets executed repeatedly for each row. Adding conditional exemption should include a way to ignore the specific table row. (note that this is currently a flaw in gauge's design). to clarify: there is a --table-row flag that controls the execution of a table driven specification. The flaws are:
a. the table driven execution can be via spec table or scenario table or both. A single flag does not help.
b. the flag is universal, so there is no way to choose a specific row number for one table driven spec and another for a different one. Or even choose the --table-row flag to apply to a specific spec.

The reason to bring this up is that this could be a case to consider if we are programmatically skipping.
Beyond these, I think we also need to think about bringing in visibility into reasons for skipping the scenario in the reports, but that is a separate thing altogether.
In summary - I guess I am ok with this feature, and the first cut of this would be to ignore a scenario altogether without worrying about the implications on table driven v/s normal execution.

@sriv
We'll summarize how we'd like to proceed

@sriv

gauge takes a list of scenarios as part of its arguments
This feature is not good enough for the integration with a test management tool selecting a list of scenarios to run. Problems:

there is presently no way to automatically extract the list of scenario file:line references
the above list must be build before any specific test run because files might have been edited
The possible implementation needs then:
parse all spec files and build the scenario:line references
match the requested run scenario list with the above reference list
build the 'gauge list_of_files' command to run

If skip scenario during execution is available the above integration is simple.

there is presently no way to automatically extract the list of scenario file:line references

Have you seen https://manpage.gauge.org/gauge_list before? Basically gauge list --scenarios is expected to do this. We can of course enhance it if needed
I suppose if this list is good enough then comparing them with a run list to come up with a final list should be possible with a few script.
I am reminded of an issue where gauge run should take the list from stdin allowing chaini g of commands (Unix like) to work.
For example I was exploring the option to do gauge run < run.txt . I don't think this works yet, but just wanted to bounce off the idea.

I just realized that gauge list --scenarios lists the scenario names and not the : format. So I guess that needs to be built.
So, if you still prefer the solution of skipping scenarios programatically, I guess we can go with it.

@sriv
Yes, we have now an implementation that we're testing
We'll provide a PR when we think it's good :)

@sriv
We have now an implementation for this functionality.
I've added now:

https://github.com/getgauge/gauge-proto/pull/38
https://github.com/getgauge/gauge-csharp-lib/pull/42

When the above are accepted I can proceed with the relevant gauge-dotnet and gauge PR.
With the programmatic skip: on the scenario implementation side it's possible to:

define in 'BeforeScenario'

[BeforeScenario]
    public void BeforeScenario(ExecutionContext context)
    {
            throw new SkipScenarioException("Skip scenario execution in a before scenario hook");
    }

in a step definition

[Step("Skip scenario <reason>")]
public void SkipScenario(string reason)
{
    throw new Gauge.CSharp.Lib.Attribute.SkipScenarioException(reason);
}

I think your dependent commits have been merged now, so you can probably rebase this off master and use latest protos from go. Might be easier to start again with go.mod/sum rather than try and rebase commits.

@sriv
This is ready for review ...
The main points of the skip scenario sequence:

In the dotnet implementation, it's possible to throw SkipScenarioException in a scenario before hook or in a test step. Also gauge WriteMessage is used to report the reason for the skip.
The gauge-dotnet reports the skip scenario in the ExecutionResult as Success but with SkipScenario set to True.
The gauge runner stops the scenario execution and completes with the after hooks and teardown. The scenario is reported as skipped
Our tests show correct html and xml reports where the scenario is correctly reported as skipped

@sriv
Any progress on this PR?

@sriv ping!

Hi!
@sriv  Do you have any opinions regarding this PR? We'd like to know if it can be accepted, or if it needs to be improved/redesigned or if it should be considered as rejected altogether?
By accident I found these two requests as well, which I think will be party solved by this PR (we only updated Guage & the DotNet-runner, to getting working in Java then the Java-runner also needs the update too, obviously).
https://github.com/getgauge/gauge-java/issues/691
https://github.com/getgauge/gauge-java/issues/683
Best regards,

sorry about the delay @PiotrNestor @jensakejohansson  - been travelling a lot most summer and work is super tight.
I have approved this, but I guess this PR needs a rebase.

Apparently this was unreleased, so it's in 1.6.8. Hope it was ready to go....

Is the following issue resolved with this merge? https://github.com/getgauge/gauge/issues/2217

@sschulz92 Yes and No. It's solved, but we only implemented it all the way for dotnet/C#. So in C# you can do:
throw new Gauge.CSharp.Lib.Attribute.SkipScenarioException("message goes here");
And any ongoing scenario will stop executing and be reported as skipped.
So, there obviously support in Gauge for this now, but we only implemented the possiblity to trigger it in C#-lib. If you want to do it in other langauges you have to update the corresponding languge runner and lib to send the correct information to Gauge.
P.S
We placed the exception definition in the attribute-namespace by mistake, it doesn't make sense. It should have been:
throw new Gauge.CSharp.Lib.SkipScenarioException();
So maybe we'll move it later.
D.S

There is a PR here from @sschulz92 to add this to Python https://github.com/getgauge/gauge-python/pull/397 - along with some discussion about changing the way the specific step that generated the "skip" is represented in places like the html-report.

P.S We placed the exception definition in the attribute-namespace by mistake, it doesn't make sense. It should have been: throw new Gauge.CSharp.Lib.SkipScenarioException(); So maybe we'll move it later. D.S

If we're going to move it, we should probably do it sooner rather than later so we dont have to worry about so many folks using it and breaking backward compatibility.

@chadlwilson Agreed, we have some time today and will try to do PR during the day to change the namespace in csharp-lib.


fromRatio only supports RGB

The documentation says that fromRatio accepts both RGB, HSL and HSV objects, but only RGB objects is actually accepted:
See from-ratio.ts:
https://github.com/TypeCtrl/tinycolor/blob/3fb24fbc4e649d6ec25bf12041659a64daefd062/src/from-ratio.ts#L16-L27
This also fails typescript compilation if you try to provide HSL or HSV objects:

:tada: This issue has been resolved in version 2.5.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Non-informative exception messages while trying to use internal dictionaries

When I try to perform queries depended on internal dictionaries, I receive meaningless errors in error log by no reason and that's all I have.
:) select regionToName(12181, 'en');

SELECT regionToName(12181, 'en')

Received exception from server:
Code: 156. DB::Exception: Received from localhost:9000, <IP_ADDRESS>. DB::Exception: Dictionaries was not loaded. You need to check configuration file..

0 rows in set. Elapsed: 0.688 sec.

Then clickhouse-server crashes silently.
Connecting to localhost:9000.
Code: 210. DB::NetException: Connection refused: (localhost:9000, <IP_ADDRESS>)

The same behavior for
:) select regionToCity(980711);

SELECT regionToCity(980711)

Received exception from server:
Code: 156. DB::Exception: Received from localhost:9000, <IP_ADDRESS>. DB::Exception: Dictionaries was not loaded. You need to check configuration file..

0 rows in set. Elapsed: 0.479 sec.

So, I get the same result. Please see error log message:
<Error> Dictionaries: Cannot load dictionary! You must resolve this manually.

And the same info is in the normal log file
...
<Debug> ConfigReloader: Loading config '/etc/clickhouse-server/config.xml'
<Debug> ConfigReloader: Loading config '/etc/clickhouse-server/users.xml'
...
<Information> Dictionaries: Loading dictionaries.
<Debug> RegionsHierarchies: Adding default regions hierarchy from /opt/geo/regions_hierarchy.txt
<Debug> RegionsHierarchy: Reloading regions hierarchy
<Error> Dictionaries: Cannot load dictionary! You must resolve this manually.
<Debug> RegionsNames: Reloading regions names
<Debug> RegionsNames: Reloading regions names for language: ru
<Error> Dictionaries: Cannot load dictionary! You must resolve this manually.
...
<Debug> MemoryTracker: Peak memory usage (for query): 1.00 MiB.
<Debug> MemoryTracker: Peak memory usage (for user): 1.00 MiB.
<Debug> MemoryTracker: Peak memory usage (total): 1.00 MiB.
<Information> TCPHandler: Processed in 0.652 sec.
<Information> Dictionaries: Loading dictionaries.
<Debug> RegionsHierarchies: Adding default regions hierarchy from /opt/geo/regions_hierarchy.txt
<Debug> RegionsHierarchy: Reloading regions hierarchy

However, I'm sure that I have the correct configuration and geobase files.
<!-- Path to file with region hierarchy. -->
<path_to_regions_hierarchy_file>/opt/geo/regions_hierarchy.txt</path_to_regions_hierarchy_file>
<!-- Path to directory with files containing names of regions -->
<path_to_regions_names_files>/opt/geo</path_to_regions_names_files>

I have all the files needed (I generated it myself from open sources)
ubuntu@ubuntu-xenial:/opt/geo$ ls -la
total 10124
drwxrwxrwx 2 root root    4096 Oct 27 12:20 .
drwxr-xr-x 5 root root    4096 Oct 26 19:43 ..
-rwxrwxrwx 1 root root 6565160 Oct 27 12:03 regions_hierarchy.txt
-rwxrwxrwx 1 root root 7689036 Oct 27 12:03 regions_names_ru.txt

I have correct files format. First lines of regions_hierarchy.txt (region_id, , parent_id, , type_id )
137123030      13040   6
124640136      12356892       6
1379136505      137432388      6
13456889      24110   6

And region_names.txt
541359        Курчатов
17468313      Villeneuve
13791073      Noepoli
9809667       Campodolcino
54138        Нижегородская область
9800331       Cordovilla La Real
9809668       Poljana
541139        Нижний Новгород
1746315      Viviers
9809669       Lostock Gralam

So, I dived into the code a little, because error message is totally meaningless!
In https://github.com/yandex/ClickHouse/blob/master/dbms/include/DB/Dictionaries/Embedded/RegionsNames.h we have
static constexpr auto required_key = "path_to_regions_names_files";

I have that line in my config file. Then file names generation
const std::string & language = getSupportedLanguages()[language_id];
std::string path = directory + "/regions_names_" + language + ".txt";

And I have all of them, then there is file reading in the code, and I consider I have totally correct file format
DB::readIntText(region_id, in);
DB::assertChar('\t', in);
DB::readString(region_name, in);
DB::assertChar('\n', in);

I actually have all the code in this file read and I'm pretty sure I'm doing everything right. The same is for Regions Hierarchy https://github.com/yandex/ClickHouse/blob/master/dbms/include/DB/Dictionaries/Embedded/RegionsHierarchy.h
RegionsHierarchy(const std::string & path_ = Poco::Util::Application::instance().config().getString("path_to_regions_hierarchy_file"))
		: path(path_), file_modification_time(0), log(&Logger::get("RegionsHierarchy"))
{
}

...

DB::readIntText(region_id, in);
DB::assertChar('\t', in);
DB::readIntText(parent_id, in);
DB::assertChar('\t', in);
DB::readIntText(type, in);

What was really bad in the code when I dived in deeper, is absolute exceptions suppressions from informative ones to the general one. See https://github.com/yandex/ClickHouse/blob/1d836b2bf8fef378d47258957ff74ed3a4aff136/dbms/include/DB/Interpreters/Dictionaries.h
	void handleException(const bool throw_on_error) const
	{
		const auto exception_ptr = std::current_exception();

		try
		{
			throw;
		}
		catch (const Poco::Exception & e)
		{
			LOG_ERROR(log, "Cannot load dictionary! You must resolve this manually. " << e.displayText());
		}
		catch (...)
		{
			LOG_ERROR(log, "Cannot load dictionary! You must resolve this manually.");
		}

		if (throw_on_error)
			std::rethrow_exception(exception_ptr);
	}

Moreover, in some cases it may throw that general error, and all the server silently shuts down just because some dictionaries didn't loaded for some reason! giving no information to fix it at all because of "(...)" ...

Thanks for the report!
You are right. Code is not good, because message for std::exception (and other exceptions not descendant of Poco::Exception) is lost. Fixed https://github.com/yandex/ClickHouse/commit/350f73da02a0a0be94bf1dee32496198a2c6f928
In your case, dictionaries could not load, because (as mentioned in documentation):

A flat array is used for storing in RAM. For this reason, IDs shouldn't be more than a million.
https://clickhouse.yandex/reference_en.html#Internal dictionaries

and there is no check for it (look at RegionsHierarchy.h).
Thus, std::bad_alloc is thrown, and you don't see the message.

Thanks for your quick reply and the solution! It is really great!


feat: Support simple Arrays with Literals

Related: https://github.com/apache/arrow-datafusion/issues/2207
Hello!
This PR introduces support for simple arrays with literal. For example it can support [1,2,3] or nested: [[1,2], [3,4]], but it doesn't support array with expressions for example: [now()].
It's first iteration, I will send later another PR with implementing the new expression node which can holds expressions and optimizer to simplify it.
Thanks

Thank you @ovr !


Add RPC to specify an additional payload to stream alonwith component data

What's needed?
We need an RPC to specify an additional payload to stream along with component data. This payload would be overwritten by the next call to this RPC.
Proposed solution
One solution would be to add the following RPC with the specified request message:
service Microgrid {
  ...
  rpc AddAdditionalPayload(AddAdditionalPayloadRequest) returns (google.protobuf.Empty)
}

message AddAdditionalPayloadRequest {
    google.protobuf.Struct payload = 1;
}

The service would attach this payload to the outgoing data message according to the specs defined in frequenz-api-common.
Use cases
Copy-pasted from the issue linked below:
"This could be used to indicate the last activity or last command that was issued to an API, e.g., a charge command to the Dispatch API or Microgrid API. (such tags could be set on these APIs through their own RPCs)."
Alternatives and workarounds
No response
Additional context
https://github.com/frequenz-floss/frequenz-api-common/issues/207

Maybe it would be worth adding something to the use case section of the issue, at least for me it is not clear what is the intended use of this feature.

Maybe it would be worth adding something to the use case section of the issue, at least for me it is not clear what is the intended use of this feature.

Already mentioned:
"We need an RPC to specify an additional payload to stream along with component data."

For me that describe what the feature does, but not why it is needed. Why do we need specify an additional payload to stream along with component data? Who's going to use it and for what?

This was mentioned in the linked issue. I copy pasted the text from there.

This was mentioned in the linked issue. I copy pasted the text from there.

OK, I read the linked issue too but I still find it difficult to understand or see the use case, but maybe it is me just lacking some additional context.

(While we are discussing this, I will also mention that the issue template feels odd to me. The Use-Case should be present before the Solution szection. I generally add the "why" in the "what's needed" section, because mentioning it after proposing a solution feels odd.)

I'm not surprised, I created the template a long time ago as something experimental and wasn't improved since then :D.
That said, I think moving the use case before the proposed solution might be a bit noisy, at least in my experience use case is empty in 90% (?) of the cases, so it will just be distracting. I suggested GitHub to add an option to skip empty sections, which really don't make sense to put in the issue at all, but I doubt it will be implemented soon (or at all), so we could explore with different template approaches to avoid the noise.

OK, I read the linked issue too but I still find it difficult to understand or see the use case, but maybe it is me just lacking some additional context.

Okay, fair enough, I will try to extend the issue with more context.

so we could explore with different template approaches to avoid the noise.

Sounds good.

To me that issues is still confusing. Who would be the sender and who the receiver of that data? How often would it be sent?

Who would be the sender and who the receiver of that data?

Users, with their SDK apps. This data will also be available via the Reporting API.

How often would it be sent?

As frequently as they want.

To me that issues is still confusing.

Think of it as a user-specified tag. E.g.,

users could update the tag after issuing charge/discharge commands. That would tell them whether the data they receive is a result of their command or not.
this could also be used to stream arbitrary data through the Microgrid API/Reporting API. This about the working point from the FCR actor. ATM, there is no metric that captures it. Something like this would open up the API to send arbitrary tags, so that users can publish any data they want.

OK, now that I'm not the only one that doesn't understand this feature, I will keep pushing a little bit further, as for me it is still unclear how this is supposed to work exactly and what are real use ceases. For me it would be good to have some pseudo code but real example, like, I don't know, for FCR:
working_point = calculate_working_point()
client.charge(battery_id, tags={"working_point": working_point})
# now what?
async data for client.get_data(battery_id, "soc"):
     # data here will have somehow the tags attached here?
     # How is FCR supposed to use this information?

Maybe we should have a meeting to discuss/explain this feature better before moving forward?

sure

I got this feedback from @Marenz in a call:
Why stream the data back with the component data stream? Why not have a separate RPC for it?
(I will get to it later, after giving it some thought)

Feedback from @llucax:
Why have this feature in the Microgrid API at all? Just for convenience?


Feature request: Export typeof renderPage to allow for typing of createPageRenderer

Hello, I'd love to be able to type my createPageRenderer like this (or similar):
import { createPageRenderer, RenderPage } from "vite-plugin-ssr";

const renderPage: RenderPage = createPageRenderer({ viteDevServer, isProduction, root });

But currently, the type isn't being exported:
type RenderPage = typeof renderPage

Would love to go from any to a proper type, thank you!

I'm not sure I see the problem? What is it you want to achieve?

You're repeating yourself.
Closing as I don't see what your problem is.


Error Logging, Confidence Histogram, Auto-Save

added logging of samples which are not classified correctly to make
debugging easier (shows in log and saved to file)
added a histogram of confidence level of predictions to choose
threshold for „I did not understand that question“ and as indication of
model robustness
added auto-saving of confusion matrix plot to file

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Great! adding logging of samples which are not classified correctly to make
debugging easier.

Sorry that this was stale for so long. I'll close this PR as there is a merge conflict with the current master version. If you still want to add this feature, please fix the merge commit and let me know so I can reopen this.

@RolandJAAI I'd still be very keen to see this merged in. Would you be up for creating a new PR with this in it?

@amn41 @tmbo Yes, I will update the error logging asap to work with the master version. For us this is a really important feature to debug the NLU. I will leave the auto-save and confidence histogram aside for now as this is interesting but rather optional for most users.

if possible I'd love to get the histogram in there too!

Here is the new version including histogram ;) https://github.com/RasaHQ/rasa_nlu/pull/1277


get resource group from context

What is changed and how it works?

Issue Number: Close #xxx
What's Changed:

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
Please add a release note.

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with None.
If this PR will be picked to release branch, then a release note is probably required.

/release

/run-release

/run-build-release

/release

/release

/release


Outstanding!

My system isn't even fully installed yet and I have two instances of this running feeding into Home Assistant and it's absolutely amazing. Well-documented, well-executed, easy to get up and running, and so far rock solid. Seriously nice work. It's adding a huge amount of enjoyment to this system already. I've got template variables in HA to calculate real time COP, savings in terms of gallons, dollars, and pounds of carbon from the old oil system and so on. It's a bunch of fun squiggly lines and also just further reinforcing the feeling that I made the right choice with the system as a whole (incredibly it's outperforming the spec sheet by a pretty solid margin, which I wouldn't know without this library).
I'd expected to jump in and contribute something, but honestly it just feels complete at the moment. For a bit I had the thought of integrating some of the calculations for COP and such, but it kind of feels right that those calculations sit elsewhere and this is just a pure interface to the units themselves.
Thanks for the great work.

 It always feels good knowing it's not just me using something I've put a lot of effort into, especially all the polishing into getting it past the "works for [just] me" stage.


Built project, dependency error

I installed backpack via yarn add backpack-core --dev as the docs stated, and added build scripts as described to package.json.
I then built my program via yarn run build, removed my node_modules folder, and reinstalled with yarn --production.
I then ran node build/main, and this immediately failed because I was missing the module use-source-maps, which Webpack had required at the start of the built script.
Of course, with backpack-core installed, this is not an issue.
Could we please either amend the docs to say to install backpack-core as a full on dependency, or (preferred) direct Webpack to not generate sourcemaps when running backpack build?
My opinion on that is, when I'm running backpack in a dev environment, I want source maps to be there. However when I'm running in production, I no longer care about source maps, so I'd rather not have the (comparatively massive) dependencies of Babel and Webpack hanging around for something I don't care about. I assume this is your opinion too, since you want backpack to be installed via --save-dev.
Of course I know that I can manually configure these options (and plan to do so if necessary), but I love the concept of this package being easy to use and having sensible defaults.
Thanks for your time!

I just ran into this as well.
I'm actually kinda surprised that I haven't seen more complaints about this. Shouldn't this affect everyone that follows the instructions (install as a dev dependency, build for production w/ defaults)?

Moved it to regular dep in the readme. This basically will depend on whether you want/use source-maps in production. Will update the examples now.

We've also been using this mostly on heroku, so we usually just throw everything into dependencies anyway.

cross-spawn will also throw an error, after yarn --production.

it is beneficial to install backpack as a dev dependency. for example, it saves a good amount on disk space. backpack pulls in a number of deps including babel which are not needed at runtime.
currently, backpack can be installed as a dev dependency using the following workaround.
npm install backpack --save-dev
npm install source-map-support cross-spawn --save

@cdimascio @jaredpalmer is the following still the recommended way to install Backpack as a devDependency?
npm install backpack --save-dev
npm install source-map-support cross-spawn --save

Thanks :)


Replace udr id with name in geteffectiveroute

working on SDK changes and tests...

Hi @DeepakRajendranMsft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, AZPRBOT;

@markcowl  this is ready to be merged

No modification for NodeJS

 https://github.com/Azure/azure-sdk-for-python/pull/720


Document RigidBodies in character mode never sleeping automatically

See #7996.

Thanks!

Cherry-picked for 3.2.3.

Hello, I don't think the documentation for this is fully correct:

[b]Note:[/b] A RigidBody2D will never enter sleep mode automatically if its [member mode] is [constant MODE_CHARACTER]. It can still be put to sleep manually by setting its [member sleeping] property to [code]true[/code].

If sleeping is set to false then setting MODE_CHARACTER turns sleeping to true. I think there should be a documentation update for sleeping not (just) can_sleep.


Fixed: use 4 tuple for keys

Codecov Report

Merging #212 into master will increase coverage by 0.25%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   48.72%   48.98%   +0.25%
==========================================
  Files          33       33
  Lines        4236     4236
==========================================
+ Hits         2064     2075      +11
+ Misses       1979     1966      -13
- Partials      193      195       +2

Impacted Files
Coverage Δ

enforcer/utils/packet/packet.go
21.69% <0%> (ø)
:arrow_up:

monitor/linuxmonitor/linuxMonitor.go
72.54% <0%> (+10.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82fb91c...ca45daf. Read the comment docs.


mj-wrapper and outlook

Wrapping multiple mj-section's in an mj-wrapper produces an undesirable result in multiple versions of MS Outlook. The mj-wrapper width is 600px in Outlook, but the mj-section is also 600px. It seems to me that the padding for the wrapper is not taken into account here. Also the width of images inside mj-sections wrapped by mj-wrapper (with padding) should probably be recalculated in MJML.

Hi @janegbert, I'm having trouble understanding what you mean, maybe you could attach some code and visual elements to illustrate your point?
Wrapping multiple sections and adding a padding on wrapper should be working fine, here's a live example: https://mjml.io/try-it-live/components/wrapper

Thanks for the feedback @ngarnier. I'll try again:
Adding padding on the mj-wrapper component results in a too wide newsletter in Outlook.
Reproduction Steps:

Define to sections and wrap one of them in mj-wrapper
Add padding="24" to mj-wrapper
Test result/HTML in Outlook

Expected behavior:
I would expect the wrapper to be 600px wide (MJML default).
Observed behavior:
In Outlook the wrapper ends up being 636px wide.
Screenshots and GIFs

MJML version:
v. 3.3.0
Email clients the bug is seen on:
Outlook 2013

Ha, thanks a lot! I edited my answer after rereading your post but you saw it in the meantime. Anyway, thanks a lot for this detailed issue, it makes the problem very clear which is useful for tracking.

This is now fixed in MJML4 branch


Fix last_checked_at value in clusters_detail endpoint

Cannot be empty

Codecov Report

Merging #249 (b341eb8) into master (d2290b7) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   83.33%   83.22%   -0.11%
==========================================
  Files          24       24
  Lines         924      924
  Branches      331      331
==========================================
- Hits          770      769       -1
- Misses        154      155       +1

Impacted Files
Coverage Δ

...nts/AffectedClustersTable/AffectedClustersTable.js
99.11% <0.00%> (-0.89%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2290b7...b341eb8. Read the comment docs.


[SP-4997] - Backport of PDI-17630 - PDI - Hadoop Job Executor step do…

…esn't have the ability to scroll through fields in advanced mode (8.2 Suite)
@ssamora @RPAraujo

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  ui/src/main/java/org/pentaho/di/ui/spoon/Spoon.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.ui.spoon.Spoon

Instruction Change: -0.1% :small_red_triangle_down:


create index in transaction , which repairs test

@phschon  please check if you can repair the mfa test or if concurrent feature is not a must
@shamus  Such an index on big tables is always critical during deployment because of increasing CPU load. So we created it already on larger landscapes . For us the "IF exits" is therefore important .
New landscapes should get the index of course but then the lock is no problem because the DB there is almost empty

Hi y'all, any updates here?

to me the concurrent is not needed, therefore I would merge this one

I'm pretty sure concurrently is needed if we want to minimize downtime. Why is the test failing? It seems like something must be wrong with our tests if adding concurrently to an index creation is making them fail

@strehle We found (and fixed) a bug in our test runner that was causing the failure. https://github.com/cloudfoundry/uaa/commit/480760e909aab6de77e4bb41da5401aa34e87565
As such, can we close out this PR?

@joshuatcasey  thanks


fix: Show copy icon

SUMMARY
Fix issue to display the correct copy to clipboard icon
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE

AFTER

TEST PLAN
Log into Superset
Navigate to Datasets
Select on Dataset
Click on the View Results in the right corner (menu)
ADDITIONAL INFORMATION

[ ] Has associated issue:
[x] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API
[x] Fixes https://github.com/apache/incubator-superset/issues/11807

Codecov Report

Merging #11847 (156f60c) into master (4666445) will decrease coverage by 3.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11847      +/-   ##
==========================================
- Coverage   67.12%   63.40%   -3.72%
==========================================
  Files         915      459     -456
  Lines       44537    28171   -16366
  Branches     4235        0    -4235
==========================================
- Hits        29897    17863   -12034
+ Misses      14526    10308    -4218
+ Partials      114        0     -114

Flag
Coverage Δ

cypress
?

javascript
?

python
63.40% <ø> (-0.70%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/db_engine_specs/hive.py
54.08% <0.00%> (-29.97%)
:arrow_down:

superset/db_engine_specs/presto.py
69.76% <0.00%> (-12.53%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/utils/celery.py
96.42% <0.00%> (-3.58%)
:arrow_down:

superset/examples/world_bank.py
97.10% <0.00%> (-2.90%)
:arrow_down:

superset/examples/birth_names.py
96.51% <0.00%> (-2.33%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

superset/result_set.py
96.69% <0.00%> (-1.66%)
:arrow_down:

... and 459 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4666445...156f60c. Read the comment docs.

thanks for the fix!
Icon in `View Query` still needs to be styled, but the rest looks good. these icons may show up randomly im not able to test them all at this moment but the ones in View Query/Results/Samples are very visible

@junlincc

Actually, we can circle back for the nits/minutiae. I think this might solve an issue reported elsewhere, so I'm gonna merge it! :D
Thanks for the fix.


Does onPaymentMethodReceived gets fired with token generated from sandbox credentials

The sandbox iframe seems to generate mock data for shipping address/card/paypal account validation when a token generated using sandbox credentials is used. On client side, does onPaymentMethodReceived still get triggered with a payload with nonce, shipping address etc that can be sent to server side? Or can it be tested only with live credentials?

onPaymentMethodReceived should fire while using a sandbox account. The only difference will be that the values in the payload may be mock data.

Working now thanks, closing


unable to glob for dot files?

Describe the bug
Using --pattern there doesn't seem to be a way to match dot files, like .github, .gitignore, etc? I don't want these pushed with my static website.
To Reproduce
Try to run an 'az storage blob upload-batch' and ignore .gitignore with a --pattern ! match.
Expected behavior
There should be some syntax to be able to ignore dot files, but creating a --exclude switch like the aws-cli would be easiest.
Environment summary
azure/CLI@v1 on Github Actions

Thank you for reporting this issue. We will take a look. Please expect delay due to the holiday season.

Thanks.
Here are several of the patterns I've tried to use which seem to all behave in the same way, they either only match files that start with ., or g, or i, or t or don't match files that start with those characters:
--pattern "[!.git*]"
--pattern "!.git*"
--pattern '[!.git*]*'
--pattern '[!".git"*]*'
--pattern '[!^.git*]*'
--pattern '*[!git]*]*'
--pattern '[![.]git*]*'
--pattern '*[!git]*'

Reddit gave me some suggestions to try which exhibited the same behavior:
--pattern '^((?!\.git).)*$'
--pattern '[^((?!\.git).)*$]*'

The --pattern only supports limited patterns just as we said in help:
> az storage blob upload-batch -h

Command
    az storage blob upload-batch : Upload files from a local directory to a blob container.

Arguments
    ......
    --pattern                               : The pattern used for globbing files or blobs in the
                                              source. The supported patterns are '*', '?', '[seq]',
                                              and '[!seq]'. For more information, please refer to
                                              https://docs.python.org/3.7/library/fnmatch.html.
    ......

The [seq] and [!seq] is used like this way:

test_[0-9].* to match test_0.txt, test_1.py or test_2.md
test_[!A-Z]* to filter upper case

What you want is to match [!.]* or .[!g]* or .g[!i]* or .gi[!t]*, but unfortunately fnmatch doesn't support OR

Hi, I actually don’t want OR. I want to exclude “.git*”.
I didn’t think to check the command help, as I was using this doc which is brief and links you to python docs for further info: https://docs.microsoft.com/en-us/cli/azure/storage/blob?view=azure-cli-latest#az_storage_blob_upload_batch
I am new to Azure CLI so I’ll be sure to check the output of the command help in the future too.
I will see if ‘storage copy’ works when I am back at my desk tomorrow and report back, thanks for the suggestion.


Bad link in Always Encrypted enclave docs

https://docs.microsoft.com/en-us/windows/desktop/seccrypto/managing-certificates-with-certificate-stores/ 404 - does not exist
in https://github.com/MicrosoftDocs/sql-docs/blob/live/docs/relational-databases/security/encryption/configure-always-encrypted-enclaves.md

@jzabroski Thank you for the feedback.
The article has been updated.


Default or configure "Add Host" to Docker 1.10.3

Currently, we always install Docker Engine:latest when you use Docker Machine and this may cause problems in the future if the current version of Rancher does not support the latest version of Docker.  Creating a setting to allow an admin/user to default to this would be good.

By what mechanism?  https://get.docker.com/ installs latest and the only two documented options are worse (release candidate and experimental).

@vincent99 The plan is to pass in our own docker install script (at let's say get.docker.rancher.com), and then point the --engine-install-url to the hosted script. By doing that, we can control the version of docker that gets installed.

ok; you can use the releases CDN, something like https://releases.rancher.com/get-docker/1.10.sh.  There should be a setting for the default engine URL and add that setting name to the settings.public setting so the UI can read it.

Gotcha, thanks!

Tested with rancher-server version - v1.0.0-rc1
When adding hosts , "Advanced option" has "Docker Install URL"  which is defaulted to https://releases.rancher.com/install-docker/1.10.sh .
This value gets passed to docker machine create as  --engine-install-url parameter.
docker 1.10.3 gets gets installed in the hosts.
Able to set the "Docker Install URL" to a different script that points to a different version of docker. In this case , host that gets added uses the docker version pointed in the script.


"Sleeping" state missing in "mower_state_detail"

I think there's missing "Sleeping" in "mower_state_detail" in pl.json file.

Thank you for reporting. Same issue for the other languages. I will fix this.

@sander1988 I see that nobody wants to translate it :( I can do it but I'm not familiar with github at all and I do not know how to do this in a proper way.
If You can show me the proper path I can do that or I can paste a file right here.


Rename package

@rekmarks Something might be off on the repo settings, I can't push a new branch, so I had to fork to create this 🤔


Fix weights path

Makes save_weights_path more clear and adds overrides for this path to save weights to a different place if needed.

Hello @williamFalcon! Thanks for opening this PR.

In the file pytorch_lightning/trainer/trainer.py:

Line 240:111: E501 line too long (119 > 110 characters)

Do see the Hitchhiker's guide to code style


Actually react to HA events

Silly me, I implemented a thread to listen to the notification API in NCS and subscribe to HA events.. and we put those events on the main supervisor queue but the supervisor doesn't actually react to them. FIX IT!!!

Implemented in https://github.com/mzagozen/bgworker/tree/10-react-ha-stable.
I based it off of 4b26ded7347fb12753236c36bf255bf6aa878073, before the select branch was merged.


🎉🎉 Rearrange algorithm 🚑🚑

Do you want to request a feature or report a bug?
I want to request a feature. It's related to arrangement of events.
What's the current behavior?

Now, in this calendar, if there are more than two events having same start time, one of them cover the other events and I think it could be imporved by writing new rearrange algorithm.
What's the expected behavior?

It is expected to work as just like Toast UI Calendar.
Furthermore I'd like to to be a contributor for this awesome project. So if you don't mind can I make pull request for this feature? If so, I'm gonna optimize it and also write some explanation too!
Thank you.
=====
See how my algorithm handles plenty of events.

@ckcks12 I already created a pull request with similar updates on algorithm. It seems that maintainers didn't treat my proposal as a good solution and haven't approved it.
https://github.com/intljusticemission/react-big-calendar/pull/1405
Please create your pull request and maybe your changes will be merged. I am really interested in solving arrangement issues.

@dmitrykrylov  & @ckcks12,
Does your solutions cover stacked events? ref: #1440

@KhaledMohamedP  Yeah of course :) haha

above one is from 01:00 ~ 01:40 and the other one is from 01:40 ~ 02:10.
So, it worths $100 ? haha :laughing: :lol:

@KhaledMohamedP
You expect that those events are connected seamlessly? without the 2% padding between them?
I think the padding is not bad actually. The real problem is that they are not arranged properly in horizontal way.

Here's my solution. Mine is also trying to put padding between them. We can find this behavior in Google Calendar.

@KhaledMohamedP Btw, I just tested it now (with the version v0.22.1) and it works below.

Is it what you want?

@ckcks12 the issue is not with 30mins appointments, its usually with events shorter than 30 minutes (e.g. 20mins). You will need to change the slot selection to the following
 step={10}
 timeslots={6}

then, you will have to create a set of 20 minutes events in the same hour!

@ckcks12 I'd love to see what you came up with. In general we'd really like the arranging algorithm to be pluggable so folks can customize it, but i know that's not super easy to add. Overall We are open to new ways of doing stuff, but there should be good case for why the solution is better generally for people, as a library we need to meet the needs of many different use cases!
Please do feel free to open up a PR with what you've got!

@ckcks12 your solution provides a better alignment algorithm for events around the same time 👏
It also addresses this issue I reported a month ago #1440
Good job!

My team is also currently facing issues around event arrangement and would love to see this merged! Cheers.

It would be nice having this merged, pls!

Hey @jquense... love the plug-in, and totally understand if you're too busy to address this PR at the moment. Really appreciate all the effort that's been put into making this one of the best React calendars out there. But... can you let us know if there's no immediate plans to merge this PR or address the arrangement, as we'll need to explore other options for the project that my team is working on. We have a situation where there are quite a few overlapping events, and we just can't use the arrangement out of the box (attaching what it looks like). Thanks again for this library.


test 2

What happens?
okay
What did you expect to happen?
cool
How can we reproduce the issue?
test
Swagger/OpenAPI Example
No response

test comment


Looping videos show loading spinner for a split second before looping

I wonder if this can be prevented. If you use the browser layout, it will still pause for a split second (more than the browser does natively without fluidplayer at all) but not show a spinner.
Edit: After investigating more, the split second pause seems to stem from the fact that the css for the darkening screen is fading in. So basically, if the video is looping, don't let the class for the loading spinner take effect.
I worked around this problem by throwing out the loading spinner entirely... Which is a sacrifice, but not as bad as the almost epilepsy inducing screen darkening and annoying loading spinner coming up. This is especially "egregious" if the video is less than a second long, which occurs with our (user-submitted) content.
.fluid_video_wrapper .vast_video_loading:before {
    /*background-image: url("images/fluid_spinner.svg");*/
    background-position: center center;
    background-repeat: no-repeat, repeat;
    /*background-color: rgba(0, 0, 0, 0.2);*/
    content: '';
    position: absolute;
    height: 100%;
    width: 100%;
    top: 0;
    left: 0;
}

Hi @sinni800, I'll bring this up to be discussed further, but the spinner is trigger by the video events. If it's showing it's because the video has triggered it, which is correct but unwanted for such short videos. Perhaps the solution may be to give the option to turn it off in the Fluid Player parameters, rather than manually doing it. As said, I will look to get this discussed further.

What would maybe help is delaying adding the loading class. When the loading is triggered, fire a timeout for a hundred or 200 miliseconds. If the video is still in the state of loading, trigger the loading class.

Just for an update for people having the same issue until it's officially fixed:
In the current version, the loading spinner can be removed by a bit of style:
.vast_video_loading {
	display:none !important;
}

@sinni800  - Can you confirm if you could still reproduce the same issue and require an enhancement in the fluid player ?

@HariPriyaKuberSingh Yes, this issue is still present, We would like a loading spinner, but this way we can't have it since it still flickers the loading spinner for a single frame.

@sinni800 - thanks for the confirmation.The issue is being looked into and I will update the comments based on the progress. Thank you

@HariPriyaKuberSingh thank you for looking into it. It would be great if we could give our users with slower internet connections a loading indicator again.

@sinni800  - we have a fix for this in production now. can you please confirm if the issue is resolved?

moving the issue to closed since there is no response from the reporter


Imagery tiles requested when hidden behind other imagery

Imagery tiles are requested regardless of their visibility. If an imagery layer is below another opaque imagery layer its tiles will still get requested and rendered. Is it possible to detect this and not request those tiles?
Example:
var viewer = new Cesium.Viewer('cesiumContainer');
viewer.imageryLayers.addImageryProvider(Cesium.createTileMapServiceImageryProvider({
    url : Cesium.buildModuleUrl('firstlayer')
}));
viewer.imageryLayers.addImageryProvider(Cesium.createTileMapServiceImageryProvider({
    url : Cesium.buildModuleUrl('secondlayer')
}));

Robustly deciding that an imagery tile is occluded is hard because the tile may have alpha and/or it may be in a weird custom projection (soon... hopefully).
But an approximation that helps determine priority is a lot more doable.
Some thoughts:

use an rbush of imagery layer rectangles, we can compute which rectangles collide with an imagery tile
from this we can compute how much of the tile's rectangle is occluded, this probably involves a bunch of recursive Rectangle intersection ops or something
or just prioritize based on Z-index when there are collisions at all?


added files for new blog post

There is a problem with GitHub Actions
https://www.githubstatus.com/incidents/qzmhbwp7f6nn
so the blog has not been deployed yet.

There is a problem with GitHub Actions https://www.githubstatus.com/incidents/qzmhbwp7f6nn
so the blog has not been deployed yet.

Thanks for the information. The deployment went through now and the blog is available on the website. All other 2.24 changes are now queued to be deployed, as it seems like GitHub actions are still operational with longer wait times.


test-branch/execute-job/comment-from-wrong-user-on-pr/23278014-f58f-45b4-bcd8-5fe1caefd812

PR for testing 8e275ff1f65c0e43217d086e2bcd69da674cf823

/canonical/self-hosted-runners/run-workflows 8e275ff1f65c0e43217d086e2bcd69da674cf823


No unity file can be loaded

i cant open the file, its build on unity 2021.3.28f1 . is there any way to fix this?
the file im trying to open: https://easyupload.io/ooi0c2

Something is wrong with the block info data
You can try to ask about this in UnityPy Discord server


No service worker is registering

Fresh install using Chrome 72.0. No service worker is registered, no output in console.

Service worker file itself remains stalled forever. Any idea why that would happen ?


[Source Code]: Rename SupportedFileFormats to SupportedModelFormats

What's Up?
The tech.fastj.graphics.io.SupportedFileFormats class' purpose is to provide a list of supported formats for model reading and writing. It serves its purpose well, but the name can be misleading, and for future purposes is a bit too general. Later on in the future there will be other classes similar to it for other types of files being read, such as audio files.
My recommended solution is to change the class name to SupportedModelFormats, since it is much more representative of what the class is for.
Code of Conduct

[X] I agree to follow FastJ's Code of Conduct

Hi there! This seems like the perfect issue to get familiar with the internals... i'll PR the necessary changes :)

Sure thing!


DIGEQ-94 moving cassandra session call

What
Moving the call to set keyspace, as a timing issue on docker was causing this to break. We'll revisit this in the beta.
Who can review
@dhilton

LGTM :+1: - hatin' docker right now :D


Show query in url

with pushState there is no way for URL to contain the query

Why? Can't see such issue

with pushState, add query into url, like "#profile?id=1" for direct page access

This is because the URL like /#!/#about?a=b doesn't have much sense. But that a=b page query is still available in Page Data object where you can access it


Implement mobilenetv2 with ONNX Runtime backend

Instructions
Run server:
docker run --rm --net host -v $(pwd)/models:/models nvcr.io/nvidia/tritonserver:24.06-py3 tritonserver --model-repository=/models

Run benchmark client:
docker run --rm --net host nvcr.io/nvidia/tritonserver:24.06-py3-sdk perf_analyzer -u localhost:8000 -m mobilenetv2 --concurrency-range 1:8

Benchmark results
AWS EC2 instance type: c7a.2xlarge.
Let m be the number of model instances, n be the number of intra-op threads.

Experiment 1: m=4, n=1
Experiment 2: m=2, n=2
Experiment 3: m=1, n=4

Experiment 1
Concurrency: 1, throughput: 126.975 infer/sec, latency 7836 usec
Concurrency: 2, throughput: 245.791 infer/sec, latency 8093 usec
Concurrency: 3, throughput: 338.272 infer/sec, latency 8812 usec
Concurrency: 4, throughput: 425.694 infer/sec, latency 9337 usec
Concurrency: 5, throughput: 552.312 infer/sec, latency 9017 usec
Concurrency: 6, throughput: 539.899 infer/sec, latency 11064 usec
Concurrency: 7, throughput: 538.569 infer/sec, latency 12954 usec
Concurrency: 8, throughput: 541.96 infer/sec, latency 14715 usec

Experiment 2
Concurrency: 1, throughput: 210.602 infer/sec, latency 4711 usec
Concurrency: 2, throughput: 401.039 infer/sec, latency 4948 usec
Concurrency: 3, throughput: 503.033 infer/sec, latency 5931 usec
Concurrency: 4, throughput: 494.162 infer/sec, latency 8057 usec
Concurrency: 5, throughput: 492.89 infer/sec, latency 10105 usec
Concurrency: 6, throughput: 493.183 infer/sec, latency 12126 usec
Concurrency: 7, throughput: 493.041 infer/sec, latency 14159 usec
Concurrency: 8, throughput: 493.265 infer/sec, latency 16178 usec

Experiment 3
Concurrency: 1, throughput: 363.038 infer/sec, latency 2722 usec
Concurrency: 2, throughput: 485.889 infer/sec, latency 4082 usec
Concurrency: 3, throughput: 485.753 infer/sec, latency 6144 usec
Concurrency: 4, throughput: 485.815 infer/sec, latency 8201 usec
Concurrency: 5, throughput: 485.646 infer/sec, latency 10262 usec
Concurrency: 6, throughput: 485.301 infer/sec, latency 12327 usec
Concurrency: 7, throughput: 485.349 infer/sec, latency 14388 usec
Concurrency: 8, throughput: 485.169 infer/sec, latency 16451 usec

Benchmark (take 2)
This time we generate load from remote instance.

server: c7a.xlarge
client: t3.medium

https://gist.github.com/zhanpon/69ae6de3aa86998d9a5f72fbf630149c
Experiment 1
Concurrency: 1, throughput: 93.7372 infer/sec, latency 10490 usec
Concurrency: 2, throughput: 179.886 infer/sec, latency 10911 usec
Concurrency: 3, throughput: 265.332 infer/sec, latency 11116 usec
Concurrency: 4, throughput: 328.619 infer/sec, latency 11970 usec
Concurrency: 5, throughput: 397.725 infer/sec, latency 12394 usec
Concurrency: 6, throughput: 435.615 infer/sec, latency 13584 usec
Concurrency: 7, throughput: 443.091 infer/sec, latency 15578 usec
Concurrency: 8, throughput: 456.919 infer/sec, latency 17319 usec

Experiment 2
Concurrency: 1, throughput: 129.764 infer/sec, latency 7556 usec
Concurrency: 2, throughput: 245.578 infer/sec, latency 7968 usec
Concurrency: 3, throughput: 325.872 infer/sec, latency 9028 usec
Concurrency: 4, throughput: 367.377 infer/sec, latency 10715 usec
Concurrency: 5, throughput: 375.398 infer/sec, latency 13139 usec
Concurrency: 6, throughput: 377.027 infer/sec, latency 15724 usec
Concurrency: 7, throughput: 382.996 infer/sec, latency 18074 usec
Concurrency: 8, throughput: 380.85 infer/sec, latency 20810 usec

Experiment 3
Inferences/Second vs. Client Average Batch Latency
Concurrency: 1, throughput: 179.43 infer/sec, latency 5432 usec
Concurrency: 2, throughput: 297.012 infer/sec, latency 6584 usec
Concurrency: 3, throughput: 315.215 infer/sec, latency 9366 usec
Concurrency: 4, throughput: 320.973 infer/sec, latency 12298 usec
Concurrency: 5, throughput: 322.04 infer/sec, latency 15354 usec
Concurrency: 6, throughput: 328.216 infer/sec, latency 18111 usec
Concurrency: 7, throughput: 327.399 infer/sec, latency 21188 usec
Concurrency: 8, throughput: 331.103 infer/sec, latency 23978 usec


Set a default environment for tests in DefectDojo

Set a default environment for tests in DefectDojo
Description

During an import, the Environment will default to "Development", reducing clicks for the user

@mtesauro the fix is done in the new commit.

This PR breaks DD if the user decides to remove Development_Environment(name='Development'): https://github.com/DefectDojo/django-DefectDojo/issues/8636


Empty MCCP file written if download fails

If the MorseCodeCharPairs download fails, an empty file is created. This is a problem because if the MCCP file exists (but does not contain the correct information), a new download is not necessarily triggered.

This is difficult to test, but I believe it is fixed as of b91a177


Make it easier for users to supply own reads and reference

Currently the workflow is setup such that users supply a csv sheet specifying the samples and associated SRRs and reference. This makes running the workflow on public datasets very easy. However, if a user wanted to run the workflow on their own data it is not straightforward. I've made the workflow run on my own data, but it was definitely not straightforward. I had to organize the reads into the directory structure that Snakemake would have made had it downloaded the reads for me, so that the workflow would run everything after the downloading step.
I still haven't come up with a solution I like to this. Would appreciate ideas/thoughts.

One solution here may be a helper script to organize everything properly. This is what we ended up doing with the old Python-based pipeline; it is a little clunky but not unmanageable. Ideally the helper script would also create the proper sample sheets for the user, perhaps taking fixed values as command line parameters, or reading from a very simple config file.
An alternate solution would to be add some if-then logic to the Snakemake pipeline such that if the fastq files are specified as a full path instead of an accession, use the file at that path, and if the genome is specified as a full path rather than an accession, use that as the reference.
Not sure which would be easier for the user and/or easier to code and maintain.


Just an Idea - babel-plugin - api improvement - customization

First, thanks for this package ! It suits perfectly my needs :)
The only downside I see is the fact that the babel plugin does not allow customization
For exemple, I would like to have a component like this :
/// /src/routing/Async.js
import loadable from 'loadable-components'

export default (importFn) => loadable(importFn, {
    loadingComponent: () =>
My loader is too awesome

})

/// /app/index.js
import { Async } from 'omni:routing' // in my project this is an alias for /src/routing/index.js (which exports the Async component)

const Counter = Async(()=>import('./counter'))

const App = () => <Counter/>

export default App

I edited localy the babel plugin to allow to pass an option which defaults to "loadable-components"
{
    "plugins": [
        [ "loadable-components/babel", {
            "applyOnModuleName": "omni:async"
        }]
     ]
}

this allows me to do :
/// /app/index.js
import Async from 'omni:async'

const Counter = Async(()=>import('./counter'))

export default () => <Counter/>

i can now alias 'omni:async' to loadable-components to get it to work but no customization possible due to the way the babel plugin actually works
my idea is to change the babel plugin to do this :

loadable(() => import('./counter'))
// babel magic =>
loadable((() => {
  const fn = () => import('./counter')
  fn.modules = babelGrabbedModnames
  return fn
})())

so for any importFn function containing import() statements, the babel plugin will traverse the function, grab the modules used, and store them on the promise itself
this way, we can get them in the loadable function directly, and add the ability to create our own Async components without code duplication :)

Hi @Aetherall, first thanks for your interest!
I would like to know the original motivation of making an alias of loadable-components?
Also your idea is interesting but why not just giving a name option to Babel plugin?

I would like to know the original motivation of making an alias of loadable-components?

I wanted to reexport a function that has already options set (currying), so I can use custom defaults

Also your idea is interesting but why not just giving a name option to Babel plugin?

The whole point is to make the transformation agnostic, so it's contained into the import function and allow further customizations in the future
I already achieved my goals in the fork I made,
I also added getDerivedStateFromProps support and tried and failed to add react 16.4 support
(remove the _ of _context )

It concerns v2, I close it because it is outdated.


ACCESSOR_NON_UNIT error in validator

I'm exporting a blender scene using the latest add on in master and then opening it in https://gltf-viewer.donmccurdy.com/ and I get the error
Cannot read property 'joints' of undefined
The model has an armature and some animations. I'm attaching the gltf and the blender file. Thanks!
broken_model.zip

Skin issue seems to be fixed, but now have gltf error :

ACCESSOR_NON_UNIT

Skin issue seems to be fixed, but now have gltf error :

ACCESSOR_NON_UNIT

I know that one.  The model contains degenerate faces, and the exporter doesn't weed them out prior to export, resulting in zero-length normal vectors, which are invalid in glTF.
Quick fix is go into Edit Mode, menu, "Mesh" -> "Clean up" -> "Degenerate Dissolve".

Well, this is a duplicate of #1138, let's continue the discussion on the other ticket


Document Integration With React Native

➕ Enhancement Request
Timebox: 5d
Problem related to the enhancement request
We must document how this library can be integrated into a React Native project. This will improve how other people use the library and adjust any implementation details missing to guarantee compatibility with RN projects.
Acceptance Criteria

[ ] Create a markdown document explaining how to integrate our library with an RN project (Java Version, Gradle, AppCompat, XML, etc.)

Just to keep some notes, we need to think about how some parameters should fit in the Android version, for booleans seems to be something trivial.
As we can see here
zoomToFit: Boolean = true,
    enableImmersiveMode: Boolean = true,
    disableControls: Boolean = false,
    currentTimeTickInMs: Long = CURRENT_TIME_TICK_IN_MS,
    controlsVisibilityDurationInMs: Long = PLAYER_CONTROLS_VISIBILITY_DURATION_IN_MS,
    controlsCustomization: ControlsCustomization = ControlsCustomization(),
    transformSeekIncrementRatio: (tapCount: Int) -> Long = { it -> it * DEFAULT_SEEK_TIME_MS },
    previewThumbnailBuilder: ((timeInMillis: Long) -> ImageBitmap)? = null,
    settingsControlsCustomization: SettingsControlsCustomization = SettingsControlsCustomization()

Some parameters should receive some treatment, for example, Long variables, ControlsCustomization, and others


Cursor is not rendering at the correct place

I've been experiencing this since 0.177.0 and the latest 0.179.0 didn't fix the issue.
Any ideas?
edit Running Atom on OSX 10.10.1
edit 2 I'm using Input Sans as my font. The problem is not happening with default font.

@zero- Are you sure that you don't have something like
text-rendering: optimizeLegibility;

in your styles.less

What don't are you using? What themes?
On Saturday, February 14, 2015, Steel Brain<EMAIL_ADDRESS>wrote:

@zero- https://github.com/zero- Are you sure that you don't have
something like
text-rendering: optimizeLegibility;
in your styles.less
—
Reply to this email directly or view it on GitHub
https://github.com/atom/atom/issues/5559#issuecomment-74385657.

@steelbrain Good catch, it was text-rendering: optimizeLegibility; that was causing the problem. I removed that and now Input Sans works also.
Thanks guys!


login redirects to <IP_ADDRESS>

Can't login and configure plugin.

What step in the login workflow does not work for you?

I've had problems with configure login token, but after few tries it worked. Please close this issue.

Thanks! Closing issue. Please star the repo if you found it useful!

I'm having the same issue. After I approve access to my account in Google, it comes back to localhost and doesn't work.

The page freezes because we are requesting all your files and storing in cache. I requested the server shutoff after 30 seconds, which somtimes causes the page not to work. I will increase the timeout. The workflow should still work regardless of the timeout issue. Let me know if it doesn't.

Ah, it does, didn't realize. It does work. Sorry for the false alarm.
ᐧ
On Fri, Apr 8, 2016 at 11:58 AM, Alexander Zai<EMAIL_ADDRESS>wrote:

The page freezes because we are requesting all your files and storing in
cache. I requested the server shutoff after 30 seconds, which somtimes
causes the page not to work. I will increase the timeout. The workflow
should still work regardless of the timeout issue. Let me know if it
doesn't.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/azai91/alfred-drive-workflow/issues/10#issuecomment-207557769

Login is very slow and the page cannot freeze for a long time. Please improve that.


Doesn't work at all?

I'm not sure if Netflix changed its interface, but I've installed this extension for Chrome and it appears to do absolutely nothing.

Yes I noticed recently that the interface changed and need some time to fix it


feat: add couchbase 4.2.4 release

update couchbase with release 4.2.4

:tada: This PR is included in version 1.387.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Extension type] Web debugging support

Please note that this feature has been renamed: It is now the 'inline class' feature.

We fixed a couple of issues where expression evaluation of extension types would not work:

https://github.com/dart-lang/sdk/issues/53048
https://github.com/dart-lang/sdk/issues/53036

So for the short term extension types "work" from the debugger perspective, but the users would not have much useful information about the extension types as they do not exist at runtime.
Providing a useful experience would require bigger changes though the whole tooling ecosystem:

Design: describe how we present the static extension types to the user in the debugger UI
CFE (incremental compiler), frontend server, expression compiler worker: provide static types to the expression evaluation API.
vm service, vm, dwds: use the new API
DevTools: present static types and using new vm service API


onBackgroundMessage and onNotificationTap is not working in iOS

My iOS version is 16.4.1, and both onBackgroundMessage and onNotificationTap seem not working.
I've put a logger inside both events, and I'm able to receive the push notifications, but my logger doesn't trigger and the events seem not listening when notifications arrived.
I'm using it on Flutter StatefulWidget, and listening from the initState method.
I'm not using FCM, the BE server send directly to Apple APN service.
Any advice?
Thanks.

Hi @YanaWijaya,
Is your widget (the one setting up these listeners) running when the app starts, without any user interaction?
This sounds similar to the reason I explained in https://github.com/ben-xD/push/issues/12#issuecomment-1566183632. Please take a look at let me know.

Hi @ben-xD
Yes, my widget is running when the app starts and without user interaction.
As per your comment in this ticket I've tried to move the listener to higher up in the widget tree, I'm now put it on main.dart, but still no luck.
I've got this message when trying tapping the notification from background state

Is there any additional step that I need to configure in xcode, apart from turn on the Remote Notifications and Background Fetch capabilities?

For the example app, is it possible to clone the previous version (0.1.3) ?
Because the latest version requires me to upgrade my Dart version, if possible I want to avoid updating my Dart version.
Thanks

Hi @YanaWijaya,
If you want to run the example app, you could git checkout dbf1cacf3b5ee9f0b81b37d10a4ba92d260d008d or git checkout 0.1.3 to get an older version. However, this will probably not work with new versions of Flutter, but since you're using an old version of Dart, you're also on an old version of Flutter.
Just curious, what version of Dart/Flutter are you currently using?

I'm wondering if there is any additional step that I need to configure in xcode, apart from turning on the Remote Notifications and Background Fetch capabilities?

That's all that's needed :)

Hi @ben-xD and @YanaWijaya,  I'm having similar issues on iOS, but I receive a onNotificationTap on the second time a push notification is tapped.  The first time, the stream never picks it up.  I listen to the stream in the app's main method.  I'm also getting onNewToken and onMessage to work fine the first time.

Hey @ben-aw, this should be fixed by https://github.com/ben-xD/push/issues/16, available as 1.0.1.
Can someone report if they see the original issue faced in this ticket? Maybe @YanaWijaya or @danieljiwonkang98?

I think this is solved so I'll close it. Please reply if you see any existing issues.


[FEAT] add test to check db migration test presence (#5083)

Pull request opened by the merge tool on behalf of #5083

Merged into branches iso5 in 94c2e1cef0d5311224a4320dd50e4ee9b4697204


Post02

edit the message detail page css
backend function fixes
backend + front end integration

currently it is able to achieve:

comment: create, view all
like: create, delete
post: view detail


Parameter parsing question

Hi,
i´m currently playing with the code of execute_assembly_bin.nim trying to pass parameters to the .NET executable. A single parameter is successfully parsed but for two parameters its not working. Im am using the following code for parameter parsing:
import os
[...]
var cmd = ""
var i = 1
while i <= paramCount():
    cmd.add(paramStr(i))
    cmd.add(" ")
    inc(i)
echo cmd # Only for troubleshooting purpose
var arr = toCLRVariant([cmd], VT_BSTR)
assembly.EntryPoint.Invoke(nil, toCLRVariant([arr]))

To execute for example Rubeus i tried nimexecutable.exe kerberoast /nowrap which ends up in the Rubeus helpme (no recognizable parameter) but nimexecutable.exe kerberoast works fine.
@edit: Removing the cmd.add(" ") line works for one parameter, everything containing a space is not passed correctly.
Some ideas how to get this working?
Greetings

In addition the empty argument lines are not working for some .NET binaries. For example InternalMonologue cannot be used this way because there still is one argument given to the Entrypoint, which is "".
var arr = toCLRVariant([""], VT_BSTR) # Passing no arguments
assembly.EntryPoint.Invoke(nil, toCLRVariant([arr]))

This results in the help menu, because there still is some argument which is unknown:

Changing the code of Internalmonologue here to ignore the argument is one way but a nicer way would probably be not to pass any argument at this point i think.
InternalMonologue argument parsing Code:
        public static void Main(string[] args)
        {
            Dictionary<string, string> argDict = ParseArgs(args);
            //Set defaults
            bool impersonate = true, threads = false, downgrade = true, restore = true, verbose = false;
            string challenge = "1122334455667788";

            if (args.Length > 0 && argDict.Count == 0)
            {
                PrintHelp();
                return;
            }
            else if (args.Length == 0)
            {
                if (verbose) Console.Error.WriteLine("Running with default settings. Type -Help for more information.\n");

            }

Found the answer by myself. The following code works for empty arguments and passes more than one argument correctly for every tested .NET Binary so far:
var cmd: seq[string]
var i = 1
while i <= paramCount():
    cmd.add(paramStr(i))
    inc(i)
echo cmd
var arr = toCLRVariant(cmd, VT_BSTR)
assembly.EntryPoint.Invoke(nil, toCLRVariant([arr]))


Speech synthesis tutorial？

Can you summary Speech synthesis tutorial like this, if you have time. It will be better combine with this repo.
Just a suggestion ：）

Can you summary Speech synthesis tutorial like this, if you have time. It will be better combine with this repo.
Just a suggestion ：）

Thanks for your suggestion😀


Not an actual issue; just an "About" typo :P - replace: Download videos from Funimation a nd Crunchyroll via cli. w/ Download videos from Funimation and Crunchyroll via cli.

Not an actual issue; just an "About" typo :P - replace: Download videos from Funimation a nd Crunchyroll via cli. w/ Download videos from Funimation and Crunchyroll via cli.
OCD - it was bugging me and I can't submit pull requests for an "About" section edit xD

Done and thanks for the tip.


Keep original features order

When loading a Dataset from a JSON file whose column names are not sorted alphabetically, we should get the same column name order, whether we pass features (in the same order as in the file) or not.
I found this issue while working on #2366.

The arrow writer was supposing that the columns were always in the sorted order. I just pushed a fix to reorder the arrays accordingly to the schema. It was failing for many datasets like squad

and obviously it broke everything

Feel free to revert my commit. I can investigate this in the coming days

@lhoestq I do not understand when you say:

It was failing for many datasets like squad

All the test were green after my last commit.

All the tests were green after my last commit.

Yes but loading the actual squad dataset was failing :/


Godot 4 port?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I would definitely like to, making it bigger and better, but will depend on available free time.