Improve teamcity DSL code for bucket generation

After these changes, the functional tests from the buckets are only created in one place - no need to repeat the same code over and over again. The handling of the deferred test coverage has also been simplified.
This makes it possible to simplify the code even further in the future.

I.e. a parameter of the build changes from -Dscan.tag.ReadyforNightly to -Dscan.tag.ReadyforMerge. Can you check what causes this change?

Yes, see this commit message: https://github.com/gradle/gradle/pull/10728/commits/859bd5b64aa7f3f613aac96b63d8094399221125
I think I can fix it.

@blindpirate PTAL!


Switch API Key feature API from new steve to old norman

As per conversation the newer steve token endpoint is not ready and only supports admins
Calls for list and delete now use norman token and not steve management.cattle.io.token
Supporting components have been updated to use the different model
Also fixed a bug where tokens with 1+ month expiry times would cause exceptions

Note - There is a bug where the response to the create does not contain the correct expireAt value. This is masked when the user is admin as an updated value seems to be yeeted out via the socket. In non-admin world this doesn't happen and the expiry table remains empty until refresh. This is the same behaviour as Cluster Manager/Ember UI

Connected to #2087


Latest Flutter version

Hi,
When will the images be updated with the latest available flutter version?
Regards,
Sascha

Hey @sderungs99, probably today or tomorrow once Xcode 12.2 is released. In the meantime you can run flutter upgrade just to make sure you are getting the latest Flutter version.

Thank you!
Related to this, it looks like Cocoapods is also not yet upgraded to the latest version. Should I upgrade that as well via my script? Or are you also planning to update this soon?

Yeah, the new VM version will get all the gems and brew packages updates as well.

Awesome. Can we keep this issue open until the new image is a available?

The image with Xcode 12.1 got update. In the meantime working on Big Sur VMs with Xcode 12.2.


feat: appsmith ctl jest with workflow

Description
Refactored appsmith/deploy/docker/utils/bin/backup.js for unit tests.
Added jest test cases for backup
Added a workflow for running appsmithctl tests

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/perf-test ref=rhito/feat-create-run-meta-before-test-starts-compare-lt-st-for-prev-runs

/ok-to-test sha=68cdd524f489e45b682476d3130bdae478cc3ba2


Update README with default props

Also updated a few descriptions & general styling.

Thanks for the PR @JikkuJose


Error when running Shake build system

Given

macOS 10.15.3
Stack Version 2.1.3 x86_64 hpack-0.31.2
GHC 8.6.5
VSCode Insiders Version: 1.42.0-insider

When I type
git clone https://github.com/haskell/haskell-ide-engine --recursive
cd haskell-ide-engine && ./install.hs build

Then I get the following error message:
Error when running Shake build system:
  at want, called at src/Development/Shake/Internal/Args.hs:83:69 in shake-0.18.3-K6N2eLzVtai6jtZeWAmEIo:Development.Shake.Internal.Args
* Depends on: build
  at error, called at src/Development/Shake/Internal/Rules/File.hs:179:58 in shake-0.18.3-K6N2eLzVtai6jtZeWAmEIo:Development.Shake.Internal.Rules.File
* Raised the exception:
Error, file does not exist and no rule available:
  build

build is not a valid command.  See https://github.com/haskell/haskell-ide-engine/blob/master/README.md#building

Hi, I'm new to Haskell and I'm following these instructions:
https://marketplace.visualstudio.com/items?itemName=alanz.vscode-hie-server

@alanz I'm starting to make much better progress now.  After performing the following steps:
stack ./install.hs hie-8.6.5
stack ./install.hs data

Should I then install the VS Code extension?

Yes, the vscode extensions is required, but apparently its documentation is not up-to-date!

Thanks @alanz and @fendor for your assistance and this issue can be closed.


Octal literal error is usually duplicated

The binder issues an error on all octal literals that are in strict mode: inside a class or module.
The checker issues an error on all octal literal types, and octal literal values when the target is es5 or higher or the value is in the initialiser of an enum member.
export enum E {
    A = 12 + 01
}
const orbitol: 01 = 01

Expected: one error on each 01.
Actual: Two errors on each 01.
This means that octal literals nearly always get two errors, because most code targets es5 or higher and is inside a module.
The checker implementation is a bit flabby and inefficient, but is probably the best place to consolidate the errors -- and efficiency doesn't matter much for syntax that's hardly ever used. I don't think it would be difficult to re-create the equivalent of the binder's inStrictMode flag.

Hi @sandersn! I'm new to the repository (poking around in issues as a way to better understand the inner workings of Typescript.) I've found where the first duplicate error issue above arises and it seems like it might be most straightforward to fix within the binder.
If I'm interpreting the explanation above correctly, the conditional to issue an error for an octal literal in strict mode should first check that the target is < es5. (If the target is es5 or higher, a general error will be issued for the octal literal, so the strict mode error is unnecessary and redundant.)
Does that sound accurate?
I'll open a draft PR so that the location in the code & the suggested solution are a little clearer, but please don't hesitate to give feedback if I'm off base.


Support the generation of proofs compatible with Starkware Verifier

Support the generation of proofs compatible with Starkware Verifier
For this we should make sure the following steps are identical:

Fiat Shamir

Should use the same hash functions
Should aggregate data and hash in the same manner
Should append the data in the same order
If needed, should use the same hash to field function (Not needed with field native hashes)

Rap

Queries and trace extension should be done in the same manner as Starkware Prover

Merkle tree of evaluations should have concatenated evaluations. Only one should exist.

Proof of work should be added as an optional feature

Virtual columns should be aggregated in the same manner as the Starkware prover

Stark Proofs are already compatible. #729 covers layouts


pipenv: fix dependencies

setup_requires belong in nativeBuildInputs
requests is only for Python 2. We offer only a Python 3 version of
pipenv
setting PYTHONPATH is not needed because the magical sed expression
injects the dependencies in the executables. Otherwise, we would use
NIX_PYTHONPATH.
PIP_IGNORE_INSTALLED was needed because of PYTHONPATH, but since we do
not set that anymore we can remove.

Motivation for this change
Fixes #71110
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @berdario

cc recent contributors @adisbladis @greydot @dgarzon @zimbatm

Following works fine:
nix run -f . pipenv
pipenv install pip==18.0
pipenv shell
pip --version

Do not use nix-shell. That exports PYTHONPATH. Use nix run instead.


Type Error while posting JSON but only in Rspec

I'm making the following API call
      json = %q{{
         "answers" : [
            {
               "response" : "TEST",
               "question" : {
                  "title" : "TEST"
               }
            },
            {
               "question" : {
                  "title" : "Tests"
               },
               "response" : [
                  "Test"
               ]
            }
         ]
      }}
      json = JSON.parse(json)
      webhook = post("/test", json)

And it throws the following error
     TypeError:
       expected Array (got String) for param `response'
     # ./spec/requests/api/v1/test_spec.rb:32:in `block (3 levels) in <top (required)>'

It fails on the webhook   = post("/test", json) line.
Where this gets a bit crazy is that this JSON parses fine, and I can make a post request against the endpoint with this data format and get the desired response (outside of rspec). I'm not sure if this is a problem in how I'm formatting my code or if it is in the post method. If I change the type of response to a String or change the name of the key than this will send fine.

Off the top of my head this sounds like a possible Rack issue. I was able to reproduce and this is the top of the stack:
Rack::Utils::ParameterTypeError:
  expected Array (got String) for param `response'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/utils.rb:149:in `normalize_params'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/utils.rb:156:in `normalize_params'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/utils.rb:122:in `block in parse_nested_query'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/utils.rb:119:in `each'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/utils.rb:119:in `parse_nested_query'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/request.rb:369:in `parse_query'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/request.rb:215:in `POST'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/methodoverride.rb:39:in `method_override_param'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/methodoverride.rb:27:in `method_override'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/methodoverride.rb:15:in `call'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/runtime.rb:18:in `call'
# .gem/ruby/2.2.0/gems/activesupport-4.2.2/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/lock.rb:17:in `call'
# .gem/ruby/2.2.0/gems/actionpack-4.2.2/lib/action_dispatch/middleware/static.rb:113:in `call'
# .gem/ruby/2.2.0/gems/rack-1.6.2/lib/rack/sendfile.rb:113:in `call'
# .gem/ruby/2.2.0/gems/railties-4.2.2/lib/rails/engine.rb:518:in `call'
# .gem/ruby/2.2.0/gems/railties-4.2.2/lib/rails/application.rb:164:in `call'
# .gem/ruby/2.2.0/gems/rack-test-0.6.3/lib/rack/mock_session.rb:30:in `request'
# .gem/ruby/2.2.0/gems/rack-test-0.6.3/lib/rack/test.rb:244:in `process_request'
# .gem/ruby/2.2.0/gems/rack-test-0.6.3/lib/rack/test.rb:124:in `request'
# .gem/ruby/2.2.0/gems/actionpack-4.2.2/lib/action_dispatch/testing/integration.rb:297:in `process'
# .gem/ruby/2.2.0/gems/actionpack-4.2.2/lib/action_dispatch/testing/integration.rb:38:in `post'
# .gem/ruby/2.2.0/gems/actionpack-4.2.2/lib/action_dispatch/testing/integration.rb:344:in `block (2 levels) in <module:Runner>'
# ./spec/requests/test_spec.rb

I'll dig into it a bit more as in this same project I have many working request specs.

I believe the problem is that you are passing a ruby hash (with nested arrays and hashes) as the 2nd argument to post.  HTTP (which rack-test simulates) does not understand ruby hashes and arrays.  It understands only text.  Whenever I've used rack-test and done a POST request to a JSON API endpoint, I've always passed a JSON string as the second argument rather than ruby objects parsed from JSON.
There might be a way to make it work by setting the Content-Type request header to application/json (that way, rack-test will know what encoding you intend) but without that I don't see anyway it could possibly work to pass ruby objects.

@KingsleyKelly you should just be able to post the raw string to the endpoint and let rails do the json decoding

Hey guys thanks for the answers! Sorry for being slow to respond.
I got this working thanks to your help!
After submitting it as a string I get the following object
{"{\"answers\" : "=>{"{\"response\" : \"TEST\",\"question\" : {\"title\" : \"TEST\"}},{\"question\" : {\"title\" : \"Tests\"},\"response\" : "=>{"\"Test\""=>{"}"=>{"}"=>nil}}}}}

Where it's creating incorrect keys. This is why I switched to trying to parse the JSON before in the first place.
I checked in the env at this point and realised it wasn't being accepted as json by rails.
After specifying
{
  'HTTP_ACCEPT' => 'application/json',
  'CONTENT_TYPE' => 'application/json'
}

As the third argument it realised it wasn't a form and parsed it correctly.
Thanks again.

Just figured out what is happening. It has to do with the default request type being a "form" for the request. When Rack parses the form it attempt to merge nested hashes in an array. When the hash values are of different types it freaks out and cause the error you saw.
Here's a step-by-step expanding of the request and params adding more until it breaks:
post(
  "/docs",
  {
    "answers" => []
  }
)
# params => {}

post(
  "/docs",
  {
    "answers" => [
      { "hash" => { "key_a" => "value_a"} },
    ]
  }
)
# params => {"answers"=>[{"hash"=>{"key_a"=>"value_a"}}]}

post(
  "/docs",
  {
    "answers" => [
      { "hash" => { "key_a" => "value_a" }, "array" => ["value_a"] },
    ]
  }
)
# params => {"answers"=>[{"hash"=>{"key_a"=>"value_a"}, "array"=>["value_a"]}]}

post(
  "/docs",
  {
    "answers" => [
      { "hash" => { "key_a" => "value_a" }, "array" => ["value_a"] },
      { "hash" => { "key_b" => "value_b" }, "array" => ["value_b"] },
    ]
  }
)
# params => {"answers"=>[{"hash"=>{"key_a"=>"value_a", "key_b"=>"value_b"},
#                         "array"=>["value_a", "value_b"]}]}

post(
  "/docs",
  {
    "answers" => [
      { "hash" => { "key_a" => "value_a" }, "array" => "value_a" },
      { "hash" => { "key_b" => "value_b" }, "array" => ["value_b"] },
    ]
  }
)
# Exception!

The strange thing is for the one that cause the exception, if you change the order of the submitted params it works:
post(
  "/docs",
  {
    "answers" => [
      { "hash" => { "key_a" => "value_a" }, "array" => "value_a" },
      { "hash" => { "key_b" => "value_b" }, "array" => ["value_b"] },
    ]
  }
)
# params => {"answers"=>[{"hash"=>{"key_a"=>"value_a", "key_b"=>"value_b"},
#                         "array"=>["value_a"]},
#                        {"array"=>"value_b"}]}


Trigger builder-base update for go 1.21.9, 1.22.2

Issue #, if available: n/a
Description of changes: https://github.com/aws/eks-distro-build-tooling/pull/1391 and https://github.com/aws/eks-distro-build-tooling/pull/1390
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve

/lgtm


outdated kroki server

I am having issues rendering mermaid diagrams with kroki, but they render just fine using mermaid or asciidoctor-diagram.
Not sure what is the version of mermaid that is running on kroki.io, but I suspect it might be outdated.
Looking at kroki it seems to have the latest mermaid version (8.14.0).
Any chance you can update on your side?

This extension does rely on https://kroki.io or on a local server.
Could you please provide a reproduction case?

This extension does rely on https://kroki.io or on a local server.

But is it using your fork ? If so, it is outdated and using mermaid 8.5.0.
My diagrams render ok in the latest 8.14.0

Could you please provide a reproduction case?

Yes, let me try to get something that fails to you.

@Mogztter while trying to get a minimal example for you I found the problem.
When using note and the <> chars, we need to escape them as html entities < and >
But for some reasons, mermaid 8.14.0 does not need that.

But is it using your fork ? If so, it is outdated and using mermaid 8.5.0.
My diagrams render ok in the latest 8.14.0

No, this extension is using the version deployed on https://kroki.io/

When using note and the <> chars, we need to escape them as html entities < and >
But for some reason, mermaid 8.14.0 does not need that.

Could you please provide a minimal example?

Could you please provide a minimal example?

sequenceDiagram
    rect rgba(200, 150, 255, 0.2)
    participant John
    Note over John: Text in <<note>>
    end

With the mermaid cli this diagram renders as:
$ mmdc -i example.mmdc -o example.svg

But in Kroki.io it renders as:

If you replace <> with the respective html entities it renders ok:

Thanks for providing a minimal reproduction case. I believe this is a bug in yuzutech/kroki.
I cannot move this issue, so I've created a new one: https://github.com/yuzutech/kroki/issues/1253


Partner friendly apps

Pricing is configured per app and passed into common
Event fired on development shop handoff
Remove redundant application_charges
Move things from react-shopify-app into common... where they are common
Jobs for webhooks to take advantage of Sidekiq

@mib32 Good review, thanks. Updated please take a look.


Draggable tokens to represent players and monsters

Add player/monster tokens. The impetus is that while players can visualize the map, they have to mentally track their own position.  Beyond that, it may be necessary to stake a claim to a position for the sake of game rules.
Operations to be performed on tokens:

Create
Move
Delete

Other suggestions:

Color selection for tokens, so monsters of a certain type could all be a certain color. Perhaps from a palette.
Adjustable sizes for tokens, or ability to pick from a palette of size options at creation time. Since we do not know the scale of user's maps in advance, they might want tokens to correspond to their own grid system.
Ability to add a letter or sub image to a token to more easily identify that token, perhaps "A" for a character named "Alex" or the image of a bow for a player with a bow.
Players could move tokens. A complex permissions system may be overkill, but it might be nice for players to move tokens rather than constantly coordinating with the DM, e.g. "move my token 5 down and 2 to the left".

I also thought about a "Point Of Interest" Feature which allows Players or the DM to mark an area on the map (with a simple touch or click) so the other players/ the dm can see what point of a map they are referring to.

Hi guys, I was thinking about adding some kind of tokens feature to the app, as it would come in handy for us.
I was wondering how I could tackle this, and here are two ideas:

Tokens could just be a generic circle with text P1, P2, ..., Pn for Player 1, Player 2 etc. and M1, M2, ..., Mn for monsters. Other option would be a label system for each of them
Instead of making them draggable, perhaps if each token was unique (option 1 from point above) or had unique label (option 2 from point above), just trying to draw that token on the other place of the map would remove it from the old one?

And token sizes could be adjusted the same way as brush is right now.
Any opinions?

A simple approach would be to have a pool of perhaps eight colored circles representing the possible token types. Dragging a circle onto the board would result in the token being assigned a number (e.g. the first purple token would be assigned "1", the second would be "2", etc.).
@n1ru4l mentioned he was working on a CV approach to recognizing grid lines, that would allow snap-to-grid functionality.
My feeling is that there are many ways to add features to the basic principle, but just having something very simple and easy-to-code achieves 80% of the user value.

Yea, I am discussing with my friend between implementing this or #23 , as either one would fit our  needs as for this app (perhaps we will do both, if it will go smoothly). But approach with eight circles should be easy as well, so probably will stick to that. At the beginning just with a brush size, will wait for the grid lines recognition to adjust the code... Or leave it for someone else ;)

hey @Akzel, welcome on board it is always nice to have new contributors 🎉
I am currently on hold with my grid detection (as I run into some limitations and performance issues). I need to investigate a bit more. Before adding this advanced feature I will try to add a simple add grid feature which allows adding a grid by interactively setting the xStart, yStart, cellSize and gutterWidth (with a visual preview). I cannot give an ETA yet, but I will try to work on this on the weekend.
We can definitely add draggable tokens without first implementing the grid.
My main concerns for not having a grid before implementing this are the following:
We do not know the size a token must have (so that must be configurable). Of course, even with a grid, you need some setting to comply with the different obstacle/creature tokens
I would recommend implementing the draggable tokens as SVG elements on the object layer
https://github.com/apclary/dungeon-revealer/blob/a2d41c0ae03253a159d2eb9a381bad9709b351f0/src/object-layer.js#L95-L119
Instead of having a hardcoded amount of 8 tokens I would prefer right clicks which opens a menu for adding new tokens. With a right-click on a token on the board, you will also get an option for removing a token.
Let me know what you think.

@Quintasan

As for draggable tokens - sounds reasonable. As for the right-click adding to the board, I see a little bit of problem with adjusting token size to fit the grid, as this option should be then configured somewhere else. Option with just putting it next to the brush in my opinion is more intuitive (after all, left-side menu is a toolbox, so all tools should probably be in it), and allow us to implement possibility to change size by imitating the UI of brush.

Sounds reasonable!

Sounds good to me!

As I had some time today, I did first draft of the code - you can see result on this video.
Right now each token has a separate colour, and I had set amount of tokens to 28. Of course if you will have more than few tokens, you will quickly get lost which number is relevant to which colour, so some additional number will have to be added to the circle.
Would greatly appreciate any opinions about the UI, as the look of the tokens (and their relation to the brush circle radius) will certainly be changed in the upcoming days.

Great job!
I imagine the practical use case is that in a party of 3-5 players, each would want to be represented by their own color, and each monster type in a fight would also get its own color, with individual monsters of the same type differentiated by numbers. As the battle progresses, monsters would be removed from the board.
Here are a few possibilities:

Clicking on a token open the token menu and set the  value to that token.
To facilitate even easier removal of monster tokens, a trash can could appear on the screen somewhere while a token is in a drag state. Dragging the token to the trash can would immediately delete it.
You might also add a button on the token menu to remove all tokens.
A "clone" button on the token menu that duplicates the size and color of the selected token

Looks good! how about filling the whole token instead of just having a border?

There is a cool library for color pickers available: https://casesandberg.github.io/react-color/

I was doing a little analysis about which lib to use for right-click menu, and at the end I ended up with selecting react-context-menu. I also taken into consideration two others libraries:

react-contexify - too much (dev) dependencies in my opinion, I like to keep things as independent as possible :D
react-contextmenu - info that they are looking for maintainers is always a bad omen when it comes to support/fixes in the future, so I also prefer not to use this one

As you guys are the ones owning the repo, I would like to confirm that you are fine with my choice before I'll start implementation. Care for any opinion on this matter?
I'll probably try to include that react-color in the menu as well ;)

I’ll trust you or @n1ru4l on the technical or usability merits of either, but I do notice the selected library has far fewer weekly downloads than the others (120 vs. 24,000). I generally prefer to use the most popular library available that gets the job done for future proofing/googling but again, I trust either of you so if one has better features or is simpler to use then feel free, just wanted to double check.

I’ll trust you or @n1ru4l on the technical or usability merits of either, but I do notice the selected library has far fewer weekly downloads than the others (120 vs. 24,000). I generally prefer to use the most popular library available that gets the job done for future proofing/googling but again, I trust either of you so if one has better features or is simpler to use then feel free, just wanted to double check.
That's also a valid point I guess. I'll come back to this topic later on, when I'll figure out how to map clicking on PanZoom (as it catches all mouse events) to proper svg entry on ObjectLayer ;)

Also this project could use more contributors, so once you submit a PR or two I’ll add you if you want.
Not sure how much I'll be able to provide later on - normally I just add functionalities that I need for my own purposes and stop working on the projects... But we will see ;)

I had some issues with adding the right-menu context, so for the moment I gave up and provided posibility to remove token on right-click. Additionally color picker has been implemented - video.
Any opinions? If that would be enough (and based on the primary post I would say it is) I can submit a pull request for it.


Support baseline widely available browsers

Change web-vitals builds to support Baseline Widely Available—that is features available in the major browsers 30 months ago or more. This represents between 95.93%-98.69% of desktop browsers, and between 97.32%-99.15% of mobile browsers, according to RUM Archive.
Users wishing broader support can import and/or build the library themselves targeting more browsers but at the cost of larger bundle size for transpiled syntax, and with many of the features of web-vitals.js either unavailable, only partially available, or available with bugs in older browsers.

Can you add something to the description to explain the change? Also, we'll have to update the "browser support" section of the README to remove mentions of IE9.
Then (either in this PR or a follow-up, though maybe this PR makes more sense?) we should make the syntax changes we want to make to modernize the code, e.g. optional chaining, for..of, nullish coalescing, etc.

Done and done.

Build
Old bytes
New bytes
% Diff

web-vitals.attribution.iife.js
12487
11468
8.16%

web-vitals.attribution.js
12489
11473
8.14%

web-vitals.attribution.umd.cjs
12678
11659
8.04%

web-vitals.iife.js
7208
6581
8.70%

web-vitals.js
7197
6570
8.71%

web-vitals.umd.cjs
7399
6772
8.47%

@tunetheweb I made some updates, can you re-review?
@brendankenny can you review as well for a sanity check?

LGTM


Build pipeline

There needs to be 2 different build pipelines for beta and stable environments and when promoting different branches correct pipeline needs to be selected

when promoting to ci-beta, qa-beta and prod-beta beta build has to be ran
when promoting to ci-stable, qa-stable and prod-stable stable build has to be ran

Which build to pick up can be set by env variable.

ping @Fryguy

@karelhala Can you explain what you mean by beta pointing to stable? Release wise, the build process doesn't care about beta or stable. In other words, the build pipeline we have in place already does this. We just happen to release to beta and stable simultaneously at the moment, but they are completely separate Travis runs.  Is this what the rest of the changes in your original PR were doing? If so, can you just make a PR with those changes?

@karelhala In looking through your PR changes, it seems most was refactoring, and the actual change was that the "master" branch wasn't in the list of "beta" branches.  I threw a quick PR that just adds that one line to unstick this particular issue.
I do like the rest of your refactorings, particularly if they match what's in insights-frontend-common, so if you could make a PR with the refactorings I would appreciate that.

@Fryguy the problem here is tthat if you are pushing to *-beta branch some variable needs to be set (common script checks branch on which the build was started) and build in different way. I will create PR with refactoring stuff, but I think that you will have to update pormoe script to check if it is running beta build or not. You can check in RedHatInsights/catalog-static-deploy/blob/ci-beta/index.html that src="/apps/catalog..."  which is incorrect and it should be src="/beta/apps/catalog...". In the closed PR I wanted to split push to beta branhces from master and to stable branches from master-stable because that is how some apps are doing it.

The only thing that was missing was that "master" itself wasn't in the list of beta branches. #131 added that, and after merged all of those paths look correct...
ci-beta - https://github.com/RedHatInsights/catalog-static-deploy/blob/ci-beta/index.html#L11
qa-beta - https://github.com/RedHatInsights/catalog-static-deploy/blob/qa-beta/index.html#L11
ci-stable - https://github.com/RedHatInsights/catalog-static-deploy/blob/ci-stable/index.html#L11
qa-stable - https://github.com/RedHatInsights/catalog-static-deploy/blob/qa-stable/index.html#L11

Oh okay, nice! So this issue can be closed, thanks for the update.


ISPN-6150 Removed Spring 3 support

Removed Spring 3 support: https://issues.jboss.org/browse/ISPN-6150
I'm not sure how to flag proper branches for this - 9.0 and 8.3. Could you please give me a hand?

Rebased

Rebased

Rebased

Pulling

Pushed, thanks


Driving commodity

The demand driving commodity (the one governed by demand equation - growth rate and initial demand) is currently hard-coded as power. The user should be able to decide the demand-driving commodity.
This issue can be closed when the hard-coded demand-driving commodity is changed to a user input.

This seems like an acceptable approach, but this is not a bug. It's an enhancement.
We'll need a new input to indicate which commodity is the driving commodity. Which I think should default to power.

Yup that makes sense.

closed with https://github.com/ergs/d3ploy/pull/47 and https://github.com/ergs/d3ploy/pull/40


Evan/tx inclusion proofs via abci

Description
Use a custom ABCI Query
Closes: #851

unfortunately, testing this depends on the application, so it can only be properly tested there

This query is now properly tested in celestia-app https://github.com/celestiaorg/celestia-app/pull/708#discussion_r971202833


extended test timeout fix trial

extend timeout for extended test from 480 to 720

This is a trial code change to see if it changes gfx908 extended test timeout.

gfx908 extended test passed by increasing the timeout from 480 to 720.
It took 8h 32m (>480m=current timeout threshold).

The extended test passed by removing precheckin from extended test jenkins config..
The duration was 5h 32min.


Publishing my VS Code extension failed because of a virus check (false positive)

Describe the bug
Yesterday I published updates for four of my extensions. Three have passed and one failed because of a virus check. The extension which failed is https://github.com/L13/vscode-sh-snippets (Marketplace). With www.virustotal.com I figured out that the README.md causes the issue. The weird thing is only the "What's new" section has changed. If I scan the previous version of the README.md everything is fine.
Failed
https://github.com/L13/vscode-sh-snippets / Marketplace
Passed
https://github.com/L13/vscode-css-snippets / Marketplace
https://github.com/L13/vscode-js-snippets / Marketplace
https://github.com/l13/vscode-diff / Marketplace
Expected behavior
Publishing the extension should pass because my other snippet extensions have the same source and dependencies.

@L13
Based on results from virustotal.com, are you able to share details on what specifically in Readme.md caused the issue?

@seaniyer
The only detail I get ist that AVG and Avast detect this file as MacOS:Bundlore-DY [Adw] which doesn't make sense because it is a text file. But the site doesn't tell me what exactly causes it.
I played with some variations of the content in the file and finally I changed the examples in the readme at point 6 and 7 and now it passes. Which is a little bit strange because the same examples are in the previous file, too.


Clarify conditions when a Parameter object shall be defined mutually exclusive to a Reusable object

Regarding this allOf definition related to workflowId, operationId and operationPath, the specification indicates there are conditions to be met.  That's the reason I created these conditional statements.
https://github.com/OAI/Arazzo-Specification/blob/df64e14d36e4c963256cbdf1b4f3759d8ccd95c5/versions/1.0.0.md?plain=1#L391

The name location of the parameter. Possible values are "path", "query", "header", "cookie", or "body". When the step in context specifies a workflowId, then all parameters map to workflow inputs. In all other scenarios (e.g., a step specifies an operationId), the in field MUST be specified.

My interpretation of this section means if operationId or operationPath are the type defined, the reference can only be a Parameter object and the in attribute must be required.
If a workflowId is defined, either parameterObject or reusableObject may be defined.
Is that a correction interpretation?
Originally posted by @jeremyfiel in https://github.com/OAI/Arazzo-Specification/pull/224#discussion_r1702377928

@jeremyfiel no that's not the correct interpretation.

My interpretation of this section means if operationId or operationPath are the type defined, the reference can only be a Parameter object and the in attribute must be required.

It's perfectly valid to have a Reusable Object defined for a parameter within a step that specifies with an operationId or a operationPath.
Take the following example, which defines a Reusable Object which references a page parameter component and overrides the parameter value with a value of 1.
  reference: $components.parameters.page
  value: 1

If a workflowId is defined, either parameterObject or reusableObject may be defined.

This is correct. But to be clear regardless of operationId, operationPath, or workflowId, it is possible to have step parameters defined using either Parameter Object or Reusable Object

ok, so that means
if operationPath or operationId, >> reusableObject OR parameterObject with required: [in]
if workflowId >> reusableObject OR parameterObject and in is optional
allOf:
      - if:
          oneOf:
            - required:
                - operationPath
            - required:
                - operationId
        then:
          properties:
            parameters:
              items:
                oneOf:
                  - $ref: '#/$defs/reusable-object'
                  - allOf:
                      - $ref: '#/$defs/parameter-object'
                      - required:
                          - in
      - if:
          required:
            - workflowId
        then:
          properties:
            parameters:
              items:
                oneOf:
                  - $ref: '#/$defs/parameter-object'
                  - $ref: '#/$defs/reusable-object'

Can I suggest updating this text in the spec to clarify that?  What are the other scenarios?  operationId, operationPath, ???

In all other scenarios (e.g., a step specifies an operationId), the in field MUST be specified.

if workflowId >> reusableObject OR parameterObject and in is optional

When workflowId is specified then in within a Parameter Object has no meaning as all parameters map to workflow inputs.

if workflowId >> reusableObject OR parameterObject and in is optional

When workflowId is specified then in within a Parameter Object has no meaning as all parameters map to workflow inputs.

I'm not sure that mapping logic works. What is the behavior if you have parameters with name clashes?  I know we have a header and a path parameter that share a name.
I think the in has to be defined for a parameter no matter what and the Parameter Object should be revisited.
OAS has a notion of request parameters which can have path, header, query, cookie, but they also have a separate headers map for response headers.  That's already a mess, but allowing the behavior of a headers map that can be a request or a response would be sufficient and a nice upgrade.
unfortunately, there will be some use of non-http standardized headers out in the wild that don't use x-, where the use of x- would prevent a collision like this.
GET /workers/{aoid} HTTP/1.1
accept: application/json
aoid: "123333"

---

200 OK
content-type: application/json
aoid: "123333"

take this example... how does the reference resolve which parameter to modify?
arazzo: 1.0.0
info:
  title: test
  version: 0.0.1
sourceDescriptions:
  - name: arazzo
    type: arazzo
    url: https://example.com/arazzo.yaml
workflows:
  - workflowId: workflow1
    steps:
      - stepId: step1
        workflowId: workflow1
        parameters:
          - $ref: '#/components/parameters/aoid'
          - $ref: '#/components/parameters/aoid'
          - reference: '$components.parameters.aoid'
            value: '55555'
components:
  parameters:
    aoid:
      name: aoid
      value: '12345'

rereading #181
does it make sense to collapse the reusable object into the parameter object OR extend the parameter object with these additional properties to have a single reuse mechanism for Parameters.
couldn't we do something similar to the criterion object?
$comment: parameter-object
properties:
  name:
    type: string
  in:
    type: string
  value:
    type: string
  type:
    enum:
      - jsonpath
      - xpath
  context:
    type: string
required:
  - name
  - in
  - value

parameters:
  - name: my parameter
    in: path
    type: jsonpath
    context: $components.parameters.page
    value: 1

OR
update the resuable object naming to use context rather than reference.   that naming seems more consistent with the rest of the specification too.
$comment: reusable-object
properties:
  context:
    type: string
  type:
    enum:
    - jsonpath
    - xpath
  value:
    type: string
required:
  - context
  - type
  - value

I'm not sure that mapping logic works. What is the behavior if you have parameters with name clashes? I know we have a header and a path parameter that share a name.

A unique parameter is defined by the combination of a name and in fields.

I think the in has to be defined for a parameter no matter what and the Parameter Object should be revisited.

in MUST be specified when defined a parameter which is to be mapped to an API endpoint (as referenced by an operationId or operationPath. This is covered in the spec by the following verbiage: "When the step in context specifies a workflowId, then all parameters map to workflow inputs. In all other scenarios (e.g., a step specifies an operationId), the in field MUST be specified.".
In situations where parameters are being mapped to workflow inputs (e.g. when workflowId is defined at the step), in is not required as all parameters are mapped to inputs within the referenced Workflow.

That's already a mess, but allowing the behavior of a headers map that can be a request or a response would be sufficient and a nice upgrade.

I don't see a need to cover response headers as parameters in Arazzo only target API request elements or workflow inputs. It's fine for response headers to be returned from a step. If they are of interest, the will be mapped to step outputs.
Looking at the example you provide:
arazzo: 1.0.0
info:
  title: test
  version: 0.0.1
sourceDescriptions:
  - name: arazzo
    type: arazzo
    url: https://example.com/arazzo.yaml
workflows:
  - workflowId: workflow1
    steps:
      - stepId: step1
        workflowId: workflow1
        parameters:
          - reference: '$components.parameters.aoid'
            value: 'john doe'
          - reference: '$components.parameters.aoid'
            value: '55555'
components:
  parameters:
    aoid:
      name: aoid
      value: '12345'

This is not a valid parameter construct as it contains duplicate aoid parameters.

in MUST be specified when defined a parameter which is to be mapped to an API endpoint (as referenced by an operationId or operationPath. This is covered in the spec by the following verbiage: "When the step in context specifies a workflowId, then all parameters map to workflow inputs. In all other scenarios (e.g., a step specifies an operationId), the in field MUST be specified.".

in is only required when a parameter object is used, but a reusable object targeting a parameter doesn't require the same constraint.

This is not a valid parameter construct as it contains duplicate aoid parameters.

it doesn't contain duplicate parameters, it targets duplicate named parameters, but in reality, those two parameter definitions are unique, one is in: path the other is in: header.   The current spec doesn't define how to make this work.  This is a legal construct per the specification, apart from the schema validation. But, this does indeed pass schema validation because even with a uniqueItems: true definition on the parameter array, the different value creates a unique entry.

in is only required when a parameter object is used, but a reusable object targeting a parameter doesn't require the same constraint.

True, but reusable objects are just providing a referencing mechanism with some override affordances. Ultimately, they need to be resolved and in this context to a Parameter Object.

it doesn't contain duplicate parameters, it targets duplicate named parameters, but in reality, those two parameter definitions are unique, one is in: path the other is in: header.

I don't see in specified in the "aoid" parameter that is referenced in the example, so I am not sure how you determine that the two definitions are unique with one using in: path and the other using in: header.
There can be situations that we may not be able to have an opinion on from a schema validation perspective, but that's not to say they should not be exercised by resolvers and/or parsers.

Btw, just for reference, the OAS requires in for all parameters, Arazzo does not. Is that an oversight? only name, value are required.

This was deliberate to prevent authoring verbosity when defining parameters where workflowId is set. In this situation, all parameters are to be mapped to inputs on the referenced Workflow. Forcing authors to specify in: workflow for every parameter was removed as an affordance.

thanks @frankkilcommins   I think i'm clear on the expectations and usage of Parameter objects.


Service discovery: Operation cannot be fulfilled on deployments.apps "dns-operator"

subctl deploy-broker --dataplane --clusterid nmanos-cluster-a-tunnel --ikeport 501 --nattport 4501 --subm-debug --service-discovery --disable-cvo --kubecontext nmanos-cluster-a --globalnet
• Deploying broker  ...
✓ Deploying broker
• Creating broker-info.subm file  ...
✓ Creating broker-info.subm file
✓ A new IPSEC PSK will be generated for broker-info.subm
• Deploying Service Discovery controller  ...
✓ Deploying Service Discovery controller
* There are 1 labeled nodes in the cluster:
- ip-10-166-41-103.us-east-2.compute.internal
• Deploying the Submariner operator  ...
✓ Deploying the Submariner operator
✓ Created operator CRDs
✓ Created operator namespace: submariner-operator
✓ Created operator service account and role
✓ Updated the privileged SCC
✓ Created lighthouse CRDs
✓ Created lighthouse service account and role
✓ Created Lighthouse service accounts and roles
✓ Deployed the operator successfully
• Deploying multi cluster service discovery  ...
✗ Deploying multi cluster service discovery
✓ Added Lighthouse entry in the openshift-dns role
✓ Disabled the cluster version operator
✓ Added Lighthouse entry in the openshift-dns-operator role
✓ Updated DNS operator deployment
Error deploying multi cluster service discovery: error setting DNS up: Operation cannot be fulfilled on deployments.apps "dns-operator": the object has been modified; please apply your changes to the latest version and try again
subctl version: dev
built from git commit id: 75e93516fb1e39cfed71c4024555b9363218449f

Full report in:
https://qe-jenkins-csb-skynet.cloud.paas.psi.redhat.com/job/Submariner-OSP-AWS/158/HTML_20Report/

Running again seems to be passing broker-deploy, but then the join failed on same error:
subctl join --kubecontext nmanos-cluster-b --kubeconfig /mnt/skynet-data/ocp-install/merged_kubeconfig --clusterid nmanos-cluster-b-tunnel ./broker-info.subm --ikeport 501 --nattport 4501 --disable-cvo --subm-debug
* ./broker-info.subm says broker is at: https://api.nmanos-cluster-a.devcluster.openshift.com:6443
* There are 1 labeled nodes in the cluster:
- nmanos-cl1-bqjj2-worker-9wrwv
• Deploying the Submariner operator  ...
✓ Deploying the Submariner operator
✓ Created operator CRDs
✓ Created operator namespace: submariner-operator
✓ Created operator service account and role
✓ Updated the privileged SCC
✓ Created lighthouse CRDs
✓ Created lighthouse service account and role
✓ Created Lighthouse service accounts and roles
✓ Deployed the operator successfully
• Deploying multi cluster service discovery  ...
✗ Deploying multi cluster service discovery
✓ Added Lighthouse entry in the openshift-dns role
✓ Disabled the cluster version operator
✓ Added Lighthouse entry in the openshift-dns-operator role
✓ Updated DNS operator deployment
Error deploying multi cluster service discovery: error setting DNS up: Operation cannot be fulfilled on deployments.apps "dns-operator": the object has been modified; please apply your changes to the latest version and try again
subctl version: dev
built from git commit id: a755ca4c27cf4976e16892169125ade19da07456

https://qe-jenkins-csb-skynet.cloud.paas.psi.redhat.com/job/Submariner-OSP-AWS/182/Test-Report/

Can you retry?, it's an important bug, but I don't think it should be a blocker since a retry of subctl would fix it, an very likely happen only sometimes.

On a second attempt it has passed:
bash-4.2$ ./subctl join --kubecontext nmanos-cluster-b --kubeconfig /mnt/skynet-data/ocp-install/merged_kubeconfig --clusterid nmanos-cluster-b-tunnel ./broker-info.subm --ikeport 501 --nattport 4501 --disable-cvo --subm-debug
* ./broker-info.subm says broker is at: https://api.nmanos-cluster-a.devcluster.openshift.com:6443
* There are 1 labeled nodes in the cluster:
  - nmanos-cl1-bqjj2-worker-9wrwv
 ✓ Deploying the Submariner operator
 ✓ Created Lighthouse service accounts and roles
 ✓ Deploying multi cluster service discovery
 ✓ Updated existing Lighthouse entry in the openshift-dns role
 ✓ Updated existing Lighthouse entry in the openshift-dns-operator role
 ✓ Updated DNS operator deployment
 ✓ Restarted the DNS operator
* Discovering network details
    Discovered network details:
        Network plugin:  OpenShift
        Service CIDRs: [<IP_ADDRESS>/16]
        Cluster CIDRs: [<IP_ADDRESS>/14]
⠈⠁ Discovering multi cluster details     Discovered global network details for Cluster nmanos-cluster-a-tunnel:
        ServiceCidrs: [<IP_ADDRESS>/16]
        ClusterCidrs: [<IP_ADDRESS>/14]
        Global CIDRs: [<IP_ADDRESS>/19]
 ✓ Discovering multi cluster details
 ✓ Creating SA for cluster
 ✓ Allocated GlobalCIDR: <IP_ADDRESS>/19
* Submariner is up and running
 ✓ Deploying Submariner

But when running it in Automation it will fail unless adding a retry mechanism.
And of-course, if user get this failure --> We should add this workaround to the README.

In 0.4.0 this should go away.

This was fixed by @aswinsuryan

I confirm this is fixed now.


Line wrapping wrong in history.html on mobile

Near the http://example.comm/doc.html#link link, per offline discussion with a reader of the book.

Can't reproduce, closing.


Merge to master

https://ledgerhq.atlassian.net/browse/B2CA-1758

https://ledgerhq.atlassian.net/browse/B2CA-1758


Error IE11

Please provide us with the following information:

OS?

Windows  10. Linux

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

@angular/cli: 1.0.0-beta.32.3
node: 7.5.0
os: win32 x64
Repro steps.

Was this an app that wasn't created using the CLI? What change did you do on your code? etc.

ng new myapp -p gt
(No modification has been done to the application)
ng build
ng serve
(IE11) http://localhost:4200/
F5 again -- > then, jscript browser console throws error:
[Error]
SCRIPT5007: No se puede obtener la propiedad 'apply' de referencia nula o sin definir
vendor.bundle.js (43881,5)
... and the app crash.
Sorry, my OS is spanish.
The log given by the failure.

Normally this include a stack trace and some more information.

Mention any other details that might be useful.

Thanks! We'll be in touch soon.

You'll need to adjust the polyfills.ts file for your target browsers by uncommenting the appropriate sections.

that's right... i'd missed adjust polyfills.ts...
Thank you very much...

This should be uncomment by default. Certainly for IE 11

So which lines needs to be uncommented for IE 11 to work?

how to adjust polyfills ?
please explain

You make find polyfills.ts into you general project folder (by default src)
Then you find section  /** IE9, IE10 and IE11 requires all of the following polyfills. **/, and delete comments in this section.

Also, what I found out was that when I made the app via the CLI, it was like a year ago. The polyfills.ts file has changed in that time. So if that's also your case, you could copy/paste if from a fresh ng new, adjust by removing comments and your set.
IE works good now

I've error in ie 11 - proxy object is undefined.
ERROR ReferenceError: "Proxy" не определено

Now i've this polyfills.ts
https://gist.github.com/sergamers/21ba3fc86d09ce0a9b23bbc518d1870e

I have tried all of the above, uncommenting and installing the packages but still on IE it's giving "Syntax Error" polyfills file attached

Having the exact same problem as @c-science1


SegmentProcessorFramework Enhancement

Description
Enhance SegmentProcessorFramework with the following improvements:

Refactor reducer to:

Support CONCAT/ROLLUP/DEDUP merge type (using off-heap memory)
Support null values
Generate generic row file as intermediate file
Minimize the intermediate file generated (0 for CONCAT, 1 for ROLLUP/DEDUP)

Add GenericRowFileRecordReader which can directly read generic row file for a range of records to avoid creating extra intermediate files when generating segments
Add support for customized segment name prefix
Simplify the MergeRollupTaskExecutor to directly use the SegmentProcessorFramework

Codecov Report

Merging #7092 (87f6846) into master (c856c6c) will decrease coverage by 32.01%.
The diff coverage is 32.71%.

:exclamation: Current head 87f6846 differs from pull request most recent head 1749030. Consider uploading reports for the commit 1749030 to get more accurate results

@@              Coverage Diff              @@
##             master    #7092       +/-   ##
=============================================
- Coverage     73.56%   41.55%   -32.02%
+ Complexity       91        7       -84
=============================================
  Files          1491     1487        -4
  Lines         73408    73361       -47
  Branches      10573    10575        +2
=============================================
- Hits          54002    30483    -23519
- Misses        15882    40306    +24424
+ Partials       3524     2572      -952

Flag
Coverage Δ

integration
41.55% <32.71%> (-0.11%)
:arrow_down:

unittests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...not/core/minion/rollup/RollupRecordAggregator.java
0.00% <0.00%> (-87.50%)
:arrow_down:

...ment/processing/aggregator/MaxValueAggregator.java
0.00% <ø> (ø)

...ment/processing/aggregator/MinValueAggregator.java
0.00% <ø> (ø)

...ment/processing/aggregator/SumValueAggregator.java
0.00% <ø> (ø)

.../processing/aggregator/ValueAggregatorFactory.java
0.00% <0.00%> (ø)

...nt/processing/genericrow/GenericRowSerializer.java
68.90% <0.00%> (-24.32%)
:arrow_down:

.../core/segment/processing/reducer/DedupReducer.java
0.00% <0.00%> (ø)

...core/segment/processing/reducer/RollupReducer.java
0.00% <0.00%> (ø)

...on/tasks/merge_rollup/MergeRollupTaskExecutor.java
0.00% <0.00%> (-88.24%)
:arrow_down:

...inion/tasks/merge_rollup/MergeRollupTaskUtils.java
0.00% <0.00%> (-87.24%)
:arrow_down:

... and 963 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c856c6c...1749030. Read the comment docs.

LGTM, thanks for working on the enhancement.


[xcodegen] Allow output to be missing in compile_commands.json

This may not always be present for CI builds.
Resolves #77407

@swift-ci please smoke test

@swift-ci please smoke test Linux


[#5313] Correctly catch errors during bootstrap.

Motivation:
We not correctly catched errors during resolving in bootstrap and so may not have notified the future correctly.
Modifications:
Move code into try / catch block and try to fail the promise.
Result:
Promise is always notified

@Scottmitch PTAL

Cherry-picked into 4.1 (f8b306f61c682455390cf09d253a8b334d167d36)


knapsack.py

Related Issue

Info about the related issue

Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
Give a clear description what modifications you have made
Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] My code follows the guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly whereever it was hard to understand.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.

Screenshots(optional)

Original
Updated

original screenshot
updated screenshot

it did not seem that you opened an issue, Please make sure to raise an issue

This code is copied from geeksforgeeks


Allow to configure axios with keepAlive:true

Hello there,
for several clients of yours we use the BapiClient inside Firebase Functions.
When optimizing the functions we noticed that we cannot follow the best practices of Firebase:
https://firebase.google.com/docs/functions/networking#maintaining_persistent_connections
This is because the current implementation of the BapiClient doesn't allow to set the underlying httpAgent/httpsAgent.
It would be neat to do this without forking your library. Here is an example how axios is intending to allow this:
https://github.com/axios/axios/issues/1846#issuecomment-434208900
Best regards
Malte

We have moved to a fetch implementation now


getblocktemplate

./nexus getblocktemplate
error: {"code":-32601,"message":"Method not found"}
Please update getblocktemplate RPC

The blockhash is 128byte, txid (hence merkleroot) is 64byte; you're not simply going to be able to get this working in a stratum without massively modifying the stratum too.
Getblocktemplate isn't even the tip of the iceberg here..

There isn't a getblocktenplate command. This is deprecated and replaced by the Mining LLP


fix: change documentation to updated example

I'm submitting this PR to fix the documentation to be updated according to code example on this repo

Thanks for your contribution!! ♥
I'm sure this documentation will be great help for anyone who want to use this module 😁


Initial work on dynamic callback registration for worker choice:

PR Checklist

[x] Please add a description of your changes.
[ ] We need your changes to come with unit tests in order to keep this project in quality and easy to maintain.
[ ] Please add a link to the open issue or task that this pull request will resolve.
[ ] Add a note to the changelog to indicate the change.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If yes please indicate it and migration info into the CHANGELOG.md file.

Fix the pool interface definition hierachy
Add method for worker choice registration and use it in fixed pool

TODO: port dynamic pool to the registration API.
Signed-off-by: Jérôme Benoit<EMAIL_ADDRESS>

Looks good to me

Jerome's Class Diagram
@startuml
  title Jerome's Class Diagram

  interface IPoolInternal<Worker, Data, Response> implements AbstractPool
  interface IPool<Data, Response>

  abstract class AbstractPool<Worker, Data, Response> implements IPool, IPoolInternal

  class FixedThreadPool<Data, Response> extends AbstractPool implements IPoolInternal
  class DynamicThreadPool<Data, Response> extends FixedThreadPool implements IPoolInternal

  class FixedClusterPool<Data, Response> extends AbstractPool implements IPoolInternal
  class DynamicClusterPool<Data, Response> extends FixedClusterPool implements IPoolInternal
@enduml

Shinigami's Class Diagram
@startuml
  title Shinigami's Class Diagram

  interface IPool<Data, Response>

  abstract class AbstractPool<Worker, Data, Response> implements IPool

  interface IDynamicPool<Worker, Data, Response> extends AbstractPool

  class FixedThreadPool<Data, Response> extends AbstractPool
  class DynamicThreadPool<Data, Response> extends FixedThreadPool implements IDynamicPool

  class FixedClusterPool<Data, Response> extends AbstractPool
  class DynamicClusterPool<Data, Response> extends FixedClusterPool implements IDynamicPool
@enduml

So to explain my pain-points with your current state of this PR:
At the start your PR should solve one problem: Providing a callback registration for the strategy of choosing a worker.
But now you rearranged the interfaces and abstractions and even changed the intention of the IDynamicPool interface always providing a max property
And if I see it correctly in your PR your solution also doesn't provide a better solution in terms of omit the use of binding functions and passing protected functions as callbacks to another function (#191 L49)
And (IMO) as a really bad side-effect you really increased the complexity of the UML of this project,
and in addition to that I think you produced a virtual bug if I'm not wrong.
Your abstract class AbstractPool implements IPoolInternal and your interface IPoolInternal implements AbstractPool. This is a circular implementation and I think other languages than TypeScript wouldn't even compile that.
I am programming since 2014 in business and have seen and worked with languages like C#, Java, Ruby and at least JS/TS.
TypeScript is my main-language since 2017, so I write and had build up knowledge about this language for more than 3 years now.
tl;dr: Specially the case that this PR just adds complexity and doesn't solve it's original purpose of just registering a choose worker strategy so no protected functions doesn't needed to be bounded anymore lets me decide to cannot agree with merging that.
If @pioardi is in another opinion and don't have problems with merging that, I just can say: He is the boss and author of this project.

I'm sorry if some words are hard or written wrongly, but some of this could be due to I'm german native and therefore some english translations could be lost in my words.
Also I don't want to attack you (@jerome-benoit) personally in any way, I enjoy working with you both together and we have done a great job around the last week(s).

So to explain my pain-points with your current state of this PR:
At the start your PR should solve one problem: Providing a callback registration for the strategy of choosing a worker.
But now you rearranged the interfaces and abstractions and even changed the intention of the IDynamicPool interface always providing a max property

You can't provide such registration interface without making the same interface definition for pool. Try to do it from your initial PR and you will see by yourself.
IDynamicPool is a pointless interface in any way. You shall not have to implement an interface for one pool type only. To properly implement design pattern strategy with callbacks registration, you require a unique interface to all pool types, it's a requirement. The way it's done in that PR is debatable but not its requirement:

pool must have an interface fully describing the internal pool use and all pull implementations must implement it. All strategies (now and future) via callbacks require it to manipulate transparently all pool type classes (now and future).
pool must have a public interface for end users that all pool types must implement.
strategies callbacks consume the internal pool interface to manipulate pool classes.
pool must not inherit one from another.

And your classes diagram is not complete, all pools currently implements the IPool interface by inheritance. You can make the choice to state it explicitly in the code for readability by always adding the implements statement to classes. I do not care removing it but it makes the implementation of classes contracts implicit instead of explicit.

And if I see it correctly in your PR your solution also doesn't provide a better solution in terms of omit the use of binding functions and passing protected functions as callbacks to another function (#191 L49)

Arrow function are bound to this by default. The use of the protected methods as arguments will go away once the term initial on that PR will not be anymore in its description ;)
Hint: the internal pool interface will allow the manipulate pool classes inside strategies callbacks transparently.

And (IMO) as a really bad side-effect you really increased the complexity of the UML of this project,
and in addition to that I think you produced a virtual bug if I'm not wrong.
Your abstract class AbstractPool implements IPoolInternal and your interface IPoolInternal implements AbstractPool. This is a circular implementation and I think other languages than TypeScript wouldn't even compile that.

It will compile with warnings that can silenced, interfaces are just attribute and method signatures that a classes must implement: IPoolInternal extends the type from the abstract, not the class. And it's common way to define interface from abstract class that need to be extended in all OO languages.
I think you do not see yet the full picture of a proper strategy design pattern implementation via callbacks and the incremental path to reach it. The pool object manipulation inside external functions shall be avoided by sticking to the full OO implementation, but since strategy functions are currently factored out, let's reuse the factorisation first to allow to add strategies.
That PR is just a first step.

@jerome-benoit At first thanks not taking my comment as harassment or any kind of that :)
Give me some time over the weekend (maybe todays evening or tomorrow) so I can propose a draft on top of my PR parallel to your PR so we can compare each other
I will now enjoy a bit of free time in games and todays evening I'm in a weekly corona remote movie party with RL-friends ^^'
You could be right that I don't see the whole picture yet and maybe it is a new kind of design that I need to understand

Some additions:

We don't need to rush with this
That it only compiles with warnings that needs to be silenced hints me that we need to try out a better solution that doesn't compile with warnings
I created both class diagrams with the exact written explicite extensions/implementations and implicit extensions/implementations are left out, that's correct
But following the class diagrams it is totally okay to rely on implicit inheritance
Personally, I try to write as little code as possible, but to map all needed structural connections/inheritances correctly

@jerome-benoit At first thanks not taking my comment as harassment or any kind of that :)

We are just having software engineering discussion, it's normal to have disagreements and to debate them to find out the best solution.

@jerome-benoit except that you are cheating :wink: and now we have the member functions public, I think this PR now moves in the very right direction :+1:
As you are currently working on it I need to make a review when you are finished
Currently there are some warnings like missing JSDoc and missing enforced return types etc
You can use /** @inheritdoc */ for functions that already have JSDoc via their implemented interfaces
(https://github.com/gajus/eslint-plugin-jsdoc/issues/696#issuecomment-782012231)
You may also add inheritdoc to spellcheck list
@pioardi I think sadly it is really the best way/option we have to just set member function access to public, because this simplifies so many things
Even if unknown contributors create their own pool implementations, they could develop their own strategies and provide them to us

@pioardi I think sadly it is really the best way/option we have to just set member function access to public, because this simplifies so many things
Even if unknown contributors create their own pool implementations, they could develop their own strategies and provide them to us

If you look at the transpiled files, the internal interfaces are not directly exported, the abstract class for pool neither. So for TS use, that does not change anything unless you import some modules with the relative path directly to the file. But you can always bypass the module export and classes components scope that way by using JS.
One way to avoid changing the scope on methods on pool, is to only pass the workers array and the tasks map, and return only the index of the chosen worker or null to init a worker creation and the potential worker to destroy. That would the API really cleaner. But I do not plan to make it in that PR.

It is public


Support bool type (with implementation defined size)

Boolean types https://en.cppreference.com/w/cpp/language/types have implementation defined size. I think this poses a problem for Clang.jl:
const MLIR_C_INCLUDE = joinpath(@__DIR__, "..", "julia/usr/include/mlir-c") |> normpath
const MLIR_C_HEADERS = [joinpath(MLIR_C_INCLUDE, header) for header in readdir(MLIR_C_INCLUDE) if endswith(header, ".h")]
wc = init(; headers = MLIR_C_HEADERS,
          output_file = joinpath(@__DIR__, "lib/libmlir_api.jl"),
          common_file = joinpath(@__DIR__, "lib/libmlir_common.jl"),
          clang_includes = vcat(LIBCLANG_INCLUDE, CLANG_INCLUDE),
          clang_args = ["-I", joinpath(LIBCLANG_INCLUDE, ".."),
                        "-I", joinpath(MLIR_C_INCLUDE, "..")],
          header_wrapped = (root, current) -> root == current,
          header_library = x -> "libmlir",
          clang_diagnostics = false,
         )
run(wc)

displays
/home/mccoy/mlir_dev/julia/usr/include/mlir-c/Support.h:98:15: error: unknown type name 'bool'
/home/mccoy/mlir_dev/julia/usr/include/mlir-c/Support.h:103:15: error: unknown type name 'bool'
/home/mccoy/mlir_dev/julia/usr/include/mlir-c/../mlir-c/Support.h:98:15: error: unknown type name 'bool'
/home/mccoy/mlir_dev/julia/usr/include/mlir-c/../mlir-c/Support.h:103:15: error: unknown type name 'bool'

for C
/// Checks if the given logical result represents a success.
inline static bool mlirLogicalResultIsSuccess(MlirLogicalResult res) {
  return res.value != 0;
}

/// Checks if the given logical result represents a failure.
inline static bool mlirLogicalResultIsFailure(MlirLogicalResult res) {
  return res.value == 0;
}

Edit: this is possibility not an issue - but I just wanted to check.

Please add a link to the header that you're trying to wrap, so I can debug it on my machine.
The error complains about a common C error, error-unknown-type-name-bool, so a proper fix could be to add some compiler flags or do an ad-hoc fix to the source code.
Please double-check the build instructions of mlir-c, especially those compiler flags, and make sure they are correctly passed to clang_args  .

Yes - it's the MLIR C API headers: https://github.com/llvm/llvm-project/tree/main/mlir/include/mlir-c

OK, I'm going to take a look at it this weekend.

Hi @femtomc, adding the missing #include <stdbool.h> to Support.h will fix the problem.

OK, I just submitted the change to the upstream: https://reviews.llvm.org/D93588

Should be fixed now. Feel free to reopen if the issue persists.


FormFlow: change generated by navigation template messages #2

Maybe I wasn't clear enough in #1412
I didn't ask for the displayed text, but for the generated as a reply from the user text (after clicking a button to change corresponding field).
Example:
Bot

What do you want to change?
<Field 1 Description>
<Field 2 Description>

after clicking the first button for changing field1:
You

Field1Name

[Describe("This is the foo field", Message="foo")]
[Terms("foo")]
public string Foo;
Then foo will be typed when you press the "This is the foo field".


Draggging a file on the window causes infinite hang

Describe the bug
If you drag a file on Supermium window, browser will hang, and you'll be required to close and open it again.
To Reproduce
Drag a file on browser window.
Expected behavior
Browser keeps working.
Screenshots
Just imagine a hang window...
Desktop (please complete the following information):

OS: Windows 7 SP1 x64
122.0.6261.85 (Official Build) (64-bit)

Additional context
Add any other context about the problem here.

Unfortunately it's not reproducible on my end. The only option at this point is to write a renderer watchdog as I suspect the renderer process is to blame as it has been with issues with similar symptoms.

I wonder if it's related to classic theme again, like the tooltip bug. I'm going to try it with default Windows 7 theme whenever I boot into my 7 install.

Very strange, it happens completely random, it doesn't matter what theme you are using. It sometimes works perfectly and it sometimes hangs when performing any drag operation.


🎖 Ruby on Rails capstone project - Budget app 🎖

Project requirements

✅ No Linters error
✅ Used correct GitFlow.

Interactions

Splash screen

A simple page with the name of your app (yes, you need to choose one), and links to the sign up and log in pages.

Sign up and log in pages

The user should be able to register in the app with full name, email and password (all mandatory).
The user can log into the app using email and password.
If the user is not logged in, they can't access pages that require the user to be logged in (all the pages described below).

Home page (categories page)

When the user logs in, they are presented with the categories page.
For each category, the user can see their name, icon and the total amount of all the transactions that belongs to that category.
When the user clicks (or taps) on a category item, the application navigates to the transactions page for that category.
There is a button "add a new category" at the bottom that brings the user to the page to create a new category.

Transactions page

For a given category, the list of transactions is presented, ordered by the most recent.
At the top of the page the user could see the total amount for the category (sum of all of the amounts of the transactions in that category).
There is a button "add a new transaction" at the bottom that brings the user to the page to create a new transaction.
When the user clicks on the "Back" button (<), the user navigates to the home page.

"Added a new category" page

The user fills out a form to create a new category, indicating their name and icon (both mandatory).
The user clicks (or taps) the "Save" button to create the new category, and is taken to the home page on success.
When the user clicks on the "Back" button (<), the user navigates to the home page.

"Added a new transaction" page

The user fills out a form to create a new transaction with:

name (mandatory)
amount (mandatory)
categories (mandatory at least one)

The user click (or taps) the "Save" button to create the new transaction, and is taken to the transactions page for that category.
When the user clicks on the "Back" button (<), the user navigates to the transactions page for that category.

Testing requirements

Created unit and integration tests for all the most important components of your RoR application.

Technical requirements

used Postgres as your database.
used  devise for authentication.
validated all user input to make sure that anyone with bad intentions cannot compromise your app.
used  a view template engine of your choice (.erb).
deployed and accessible online.

📹 Demo video
🚀 Live Demo Link

Thanks for your review dear @andersonlebon 👏


No L2;2; or L1;2;

Hello, I noticed I do not see L1;2;* or L2;2;* when I convert to csv?
thanks
w

Check the source files: do they contains the Last values? This addon do not filter records, so the issue could be in the absense of 2  (Last) records in the sourced nrd files.

Thanks @eugeneilyin , effectively I needed to downoad new nrds. Strange they didnt have Last
In the new test I ran with the new nrd, I can see some L1;2;*
I do not see some L2;2;*
Is it expected?
I guess this is ok as that would be redundant with the L1;2;*, isn't it?
thanks
w

IDK what is in that nrd's, anyways this is just a converted, no filter functionality is applied inside.


Problems encountered during building from scratch

Nice project!
This issue(post?) records the obstacles and solutions I encountered during the construction process. Hope the maintainer can modify the script after seeing this to make the build process smoother.
Environment
docker: 27.1.0
image: nvidia/cuda:11.3.1-cudnn8-devel-ubuntu20.04
setup command:
sudo docker run -dit --gpus all                                         \
            -v.:/root                                                   \
            --privileged --network=host --ipc=host                      \
            --name phos nvidia/cuda:11.3.1-cudnn8-devel-ubuntu20.04

Waiting for user input
I used commands in readme to build:
./build.sh -3 -i

It got stuck during the installation of software-properties-common because the process requires user input to confirm time zone information, but there is no way to provide input.
Solution: Manually install software-properties-common or set TZ and DEBIAN_FRONTEND environment vars.
Missing ~/.cargo/env
After completing the first stage of the installation, the script prompted me to source ~/.bashrc. However, after sourcing it, I found that ~/.cargo/env was missing.
Solution: Install the rust toolchain:
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh

Missing header files
When building the Autogen and Remoting components, the process failed, and the log indicated that some header files were missing (see build_log/build_PhOS-Autogen.log and build_log/build_PhOS-Remoting.log for details):
../../pos/cuda_impl/utils/fatbin.h:26:10: fatal error: libelf.h: No such file or directory
   26 | #include <libelf.h>
      |          ^~~~~~~~~~
cpu-utils.c:9:10: fatal error: openssl/md5.h: No such file or directory
    9 | #include <openssl/md5.h>
      |          ^~~~~~~~~~~~~~~
cpu-client-driver.c:7:10: fatal error: vdpau/vdpau.h: No such file or directory
    7 | #include <vdpau/vdpau.h>
      |          ^~~~~~~~~~~~~~~

Solution: Install header files:
apt-get install -y libelf-dev libgl1-mesa-dev libssl-dev libvdpau-dev

Missing dynamic library
After completing the installation, I tried to launched hijack library using LD_PRELOAD, but it failed due to a missing libtirpc.so.3. I could only find /usr/lib/x86_64-linux-gnu/libtirpc.so.
Solution: Run the ldconfig command to generate libtirpc.so.3.
Hijacking failed
I tested the hijack with a hello world CUDA program, but no runtime APIs were hijacked. Running the ldd command to check library dependencies showed that no runtime library was included. It seemed that nvcc forces runtime library to be statically linked in user program binary.
Solution: Add the --cudart=shared argument to force dynamic linking of the CUDA runtime in the user program.

Thank you so much for your troubleshooting! We will check that and revise the doc accordingly :)

When running the llama-2  example code, I found some arguments are incorrect. Here is the patch:
diff --git a/examples/llama2-13b-chat-hf/download.py b/examples/llama2-13b-chat-hf/download.py
index 65e6020..3c6072c 100644
--- a/examples/llama2-13b-chat-hf/download.py
+++ b/examples/llama2-13b-chat-hf/download.py
@@ -32,7 +32,7 @@ model.save_pretrained(model_path)

 # download tokenizer parameter
 if not os.path.exists(tokenizer_path):
-    os.makedirs(model_path)
+    os.makedirs(tokenizer_path)
 tokenizer = AutoTokenizer.from_pretrained(model_id)
 tokenizer.save_pretrained(tokenizer_path)

diff --git a/examples/llama2-13b-chat-hf/inference.py b/examples/llama2-13b-chat-hf/inference.py
index 1fdac76..d7e7770 100755
--- a/examples/llama2-13b-chat-hf/inference.py
+++ b/examples/llama2-13b-chat-hf/inference.py
@@ -18,8 +18,8 @@ import transformers
 import time
 from transformers import AutoTokenizer, AutoModelForCausalLM, TextStreamer

-model = AutoModelForCausalLM.from_pretrained('/nvme/huggingface/hub/models--meta-llama--Llama-2-13b-chat-hf/snapshots/a2cb7a712bb6e5e736ca7f8cd98167f81a0b5bd8/').to('cuda:0')
-tokenizer = AutoTokenizer.from_pretrained('/nvme/huggingface/hub/models--meta-llama--Llama-2-13b-chat-hf/snapshots/a2cb7a712bb6e5e736ca7f8cd98167f81a0b5bd8/')
+model = AutoModelForCausalLM.from_pretrained('./model').to('cuda:0')
+tokenizer = AutoTokenizer.from_pretrained('./tokenizer')

 print(f"process id: {os.getpid()}")


NullPointerException in CraftingPattern.getOutputs

Issue description:
NPE when crafting IndustrialCraft Advanced Circuit via Pattern in Crafter. Normal Circuit does not throw Exceptions. I guess ItemStack can be null?
What happens:
Server shuts down with NPE at com.raoulvdberge.refinedstorage.apiimpl.autocrafting.CraftingPattern.getOutputs(CraftingPattern.java:203) (not sure why there's a curly in the current code at this line but i definitely just downloaded the latest version an hour ago)
What you expected to happen:
Item gets crafted... I guess?
Steps to reproduce:

Try to craft Pattern of IndustrialCraft Advanced Circuit in Crafter

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge: 1.10.2-<IP_ADDRESS>4
Refined Storage: 1.2.7 (updated from 1.2.4 in Direwolf's 1.10 pack)

Does this issue occur on a server? [yes/no]
yes
If a (crash)log is relevant for this issue, link it here:
http://pastebin.com/1BtZ1qFE
Full MC crash report just in case
http://pastebin.com/n7FVMCWj

Same as #586, fix incoming


error Couldn't find package "<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>on the "npm" registry.

We're seeing this in our build logs.
error Couldn't find package "<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>on the "npm" registry.
Also, this is returning 404 https://www.npmjs.com/package/@algolia/client-personalization
And
verbose 1.253948505 Request "https://registry.yarnpkg.com/@algolia%2fclient-personalization" finished with status code 404.

Thanks.
-josh

Same

Can confirm, encountering the same error with the latest version.
Either the package is not yet published (and still private), or someone has (accidentally?) unpublished it.

Yup same issue here
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@algolia%2fclient-personalization - Not found```

My money is on „not yet published” as this dependency seems to be a new dependency in v4.10.0:
https://github.com/algolia/algoliasearch-client-javascript/blob/4.10.0/packages/algoliasearch/package.json#L34 vs https://github.com/algolia/algoliasearch-client-javascript/blob/4.9.3/packages/algoliasearch/package.json
So pinning the version to v4.9.3 works for now, until the new/renamed package has been made available :)

I think this is due to an npm issue, seeing their status page.

this is blocking docusaurus classic template install altogether
npx @docusaurus/init@latest init my-website classic

It's definitely published, however I'm not sure whether npm has actually processed it. How come nobody used lockfiles?

How come nobody used lockfiles?

I am using package-lock.json, however I was in the middle of upgrading all dependencies :D That's when I noticed it.
Since the initial npm update has failed, I removed the node_modules and package-lock.json (like I do every now and then) and then re-installed everything from scratch, to also make sure that it's really installable.
Honestly, to me this issue is not a big deal at all. Until NPM has sorted out its publishing state of said package, I'll just keep using the previous version. No biggie :)

How come nobody used lockfiles?

Any method to create a lockfile on a fresh project that uses a package with ^ dependency? 🤔

I'm very sorry for the downtime this caused anyone, even though it said "published" for me, it did not mention the access was private (even though I ran npm access public @algolia/client-personalization and npm access public @algolia/recommend). Publishing a patch with --access public fixed it as far as I can tell.
Will make sure new packages in the future have a throwaway version published before relying on it, very sorry!

@Haroenv thanks for your quick help! It's always a pleasure to work with you and the fine folks at Algolia ☺
I can only speak for myself again: No harm, no foul, so don't worry =) If there were any learnings out of this, then it was already worth it ✌

Thanks for the fast support!

amazing! thanks for the fix 🥳

Sorry again for the misunderstanding on what was actually going wrong here (I thought it was eventual consistency first, but it turned out to be never consistency)
https://www.npmjs.com/package/%40algolia%2Fclient-personalization and https://www.npmjs.com/package/%40algolia%2Frecommend now seem accessible from a private tab for me, and show as public on the package page:

Since npm caches really heavily, I recommend to install 4.9.3 if you have any issues with retrieving the 4.10.0 or 4.10.1 packages, but I'll close it, as it seems you're able to install it now.

Thank you @Haroenv!!!


if two keywords that need to be highlighted come together, they will be in one line

for example: in java
//some comments
public static String json=""

this will be like:
//some commentspublic static String json=""

how to show code in two line?

@Warrie this looks strange because highlightjs preserves line breaks. Most likely something's wrong with the newline character in your java source file. Can you provide a reproducible example?

@Warrie Any update?

Closing.  We an reopen if Warrie comes back with a reproducible example. :-)  For now hoping all is well!


Document missing pnpmfile hooks

Adds documentation for;

filterLog
fetchers
importPackage
preResolution

Local/global pnpmfiles and how they interact is now also documented. For example readPackage is supported by local and global pnpmfiles, and both run with global going first so (global then local).

I am not sure we want people to know about these. All these hooks except filterLog were added for easier integration with stackblitz. Would anyone else want to use these low level hooks?

Would anyone else want to use these low level hooks?

The use case I have in mind sourcing package data directly from the npm_package rule (Bazel ruleset), such that content is identical across Bazel builds and external tools that use pnpm's node_modules (including IDEs).
There are alternatives.

Using Bazel's node_modules instance instead, a crude implementation of which exists here, however.

This breaks the pnpm patch workflow which relies on pnpm's node_modules existing.
Related: https://github.com/pnpm/pnpm/issues/8257
pnpm is able to do in-place mutation of node_modules which is faster than than copying over.
Symlinking would close this gap though (why didn't I think to do that before...)

Write generated sources into version control (what we are doing at Canva right now).

Prevents in-place modification of files. This pattern is unusual in the NodeJS ecosystem, but in the context of our build system such transforms are useful it allows input sources to be normalised (stripping comments, etc) to avoid unnecessary rebuilds, however.
Packages in pnpm's node_modules include more files than intended (e.g. .ts sources).
Need to confirm generated sources are up-to-date on CI.
Devs need to run an extra step whenever such packages are modified (a common complaint, especially when testing changes to a workflow like ESLint which operates outside of our build system).
More noise to sift through in code review (even with Github hiding the diff of these generated files).

Redirect workspace:* references to tarballs/directories built by Bazel (e.g. by mutating the lockfile). This alternative came about from ideation and has not been implemented. The cons of this haven't had much thought at this stage, off the top of my head it could affect dependency resolution (workspace packages are already by default something of a special case unless they are injected).

The use case I give likely runs into the same dependency resolution issue as mentioned in (3). The issue is not insurmountable (a great deal of flexibility is afforded across all the hooks) but would need to be carefully thought out.


How to set :multiple => false for selection

Here is a selection in a partial form:
<%= f.association :standards, :collection => Standard.active_std.all(:order => 'name'), :label_method => :name, :value_method => :id,  :prompt => "Choose std", :label => "Std：", :include_blank => true, :input_html => {:multiple => false} %>
The code above still displays 5 line options by default. What do I do if I want to only display one option?
Thanks.

You could give the multiple option inside the input_html hash of options.
  f.association ...., :input_html => { :multiple => false }

Please use the mailing list for questions.

Does not work. Tried again and before.

Here is the source code after adding :input_html => { :multiple => false }:
 Std：Choose std

I can't see the source code here. Please send your question to the mailing list, and include the html portion there. Thanks.

This should work fine since 2009-12-11, As you can see here: https://github.com/plataformatec/simple_form/commit/7235f4a177611573582c7049955e4094347da701

Posted to mailing list. Thanks.


Bug Report and some Helps

I have 3 Issues.
First I want to know if its possible to use xautolock with betterlockscreen and how to, here is the command for i3block:

exec_always --no-startup-id xautolock -time 10 -locker i3lock

How do I write to work in manjaro i3?

exec_always --no-startup-id xautolock -time 10 -locker betterlockscreen -l

The second problem is qutebrowser doesn't reconize the font:
http://i.imgur.com/zMm7pLu.png
The third problem is some kind of security bug, I was using my notebook and when I used the comand:

bindsym s exec --no-startup-id i3exit suspend, mode "default"

I was listening to some music and the command dint kill it, so I was "well, i need to stop the music and then block right?", so I acidentaly pressed enter and the betterlockscreen just released without any password, wtf. I cant reproduce this bug again, so i'm just reporting here.

Can you try these modified version?
i3exit
betterlockscreen

Reopen if you are still facing problems


Use C#'s native expection handling

I'm curious about why C#'s native catch-all isn't being used.
If there's a particular reason, I'd love to hear it!

This isn't catching C# exceptions, it's catching Win32 exceptions (like access violations). C# exceptions are already try/catched where they need to be (mostly). .NET can't catch access violations with try/catch without a lot of hacks nowadays, and usually those access violations aren't even triggered from GDWeave but rather a bug in the Godot Engine.


Update VS Code file spec

Reasons for making this change:
The current gitgnore doesn't account for VS Code files generated by the engine.
Links to documentation supporting these rule changes:
https://docs.unrealengine.com/4.26/en-US/WhatsNew/Builds/ReleaseNotes/4_18/
Granted it's not as refined as Rider or Visual Studio support, with the right extensions it works like a charm.

We have an existing Global\VisualStudioCode.gitignore that covers more than just this rule.


(PUP-7575) Add --job-id flag to puppet agent

Commit 4e05e16 added internal handling of job id for agent catalog
requests and report submission, but had no facility to actually provide
the job id to the agent. This commit now adds a --job-id flag which will
simply thread the provided value (which is an arbitrary string) through
to the catalog request and the report. This will allow correlating node
run reports with orchestration jobs in PuppetDB.

CLA signed by all contributors.


Manage notification information for each plugin separately

Some plugins frequently pop up notifications, so I was wondering if we could set the notification policy of a certain plugin to not prompt, so that I don't have to miss other notification information due to the intrusion free mode and won't be disturbed by the frequent pop-up notifications of a certain plugin

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


Write raw files?

Hi,
Any thought of adding a feature to write back raw files? I want to do some processing on the raw, undebayered data, write back to a RAW file, and then use a more advanced tool like darktable to do the actual processing.
Thanks!

This won't be supported as the underlying library libraw doesn't support it.


ARROW-6006: [C++] Do not fail to read empty IPC stream with schema having dictionary types

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1341fc1). Click here to learn what that means.
The diff coverage is 96.66%.

@@            Coverage Diff            @@
##             master    #4947   +/-   ##
=========================================
  Coverage          ?   89.05%
=========================================
  Files             ?      606
  Lines             ?    77493
  Branches          ?        0
=========================================
  Hits              ?    69008
  Misses            ?     8485
  Partials          ?        0

Impacted Files
Coverage Δ

cpp/src/arrow/ipc/read-write-test.cc
99.83% <100%> (ø)

cpp/src/arrow/ipc/reader.cc
86.77% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1341fc1...b442390. Read the comment docs.


Question about model performance of 2D version.

Hello, I'm wordering about 2DiTransformer.
PatchTST or Crossformer using Patching to improve model performance,
so when you try 2DiTransformer instead of original 1D version, can you see any improvement in model performance?

someone ran it and saw an improvement
why not just try it? i've made it simple enough no?


Slots opt-in button disappears after enabling the preview feature

Browser: Edge
Even though it's a one time opt-in option,  it's worth showing it in the feature under settings tab similar to other preview features:

This is by design, but @dariagrigoriu can confirm.

Yes - since we do not allow the settings to be turned off like the other settings we don't display it anymore.


Twitter API request with JSON body

I was trying to send a request to the Twitter API with JSON data instead of the usual form-encoded data but was not able to find any method that I could do this with.
Is this not possible currently with STTwitter?

related issue #275

I have same issue.  and I tried solve by adding isJSONPOSTRequest flag.
but this solution is pretty darty...
https://github.com/mironal/STTwitter/commit/3caea03b824ac5149fb227d901f76861b903e565