Create Mac and Linux Installer Script

Duplicate to #24, except for Linux and Mac.
It doesn't have to be in shell script. You can use Makefile, or even Python 2.7; because these two platforms have Python 2.7 pre-installed.
As for Linux distro, let's stick to Ubuntu derivates for now. No CentOS or any such distro.

Ok I can take this up if @koustuvsinha is busy with the Linux distribution. I feel comfortable using Python and Plumbum library. We shall talk a bit more about the architecture first though.

Ohh cool! I cannot thank you enough @byteknacker :+1:
I can assign in GitHub to only one person, but unofficially, I am assuming both of you are assigned. Should I create an epic?

Actually I have never really understood what an epic is. But yes please feel free to manage the project as you see fit. I will be partially doing that too.

This is now a priority. I am putting it for June 3 deadline, but I am okay if only a part of it is resolved by then. But whatever part would be resolved, should be resolved in a very reliable and testable way.

I will do it for Mac in Python.

Do you think we can merge this one just into zeus bash script directly instead of having a new script for it? Or should we keep this separate in another script like something like setup.sh?

Plumbum that I saw somebody mention somewhere else seems like an awesome way to make a multi-platform install script, I'm going to have to check it out more.

https://plumbum.readthedocs.org/ @dragon788 it is really awesome! But we decided to just use Bash.

any change it will run on ubuntu 16.04 or mint 18(beta) ?

Actually, I might add this feature.


Make default view render a single page angular app

The most common use of this module is for writing single page angular apps, yet the default view (index.html) does not include an ng-view and there's no express wildcard route for ensuring hard reloads don't 404. We should modify this behavior and/or provide very clear instructions on how to configure projects for the common case.
To get a single page angular app working should be as simple as:

Install bedrock-views
Install a bower package (or configuring a pseudo one) with the desired frontend
Start the server
Hit the root URL

This functionality landed in 2b5e02112ded5c0335b1ba25b3890f8e74ddcb5c.
However, the main landing page hasn't been changed so I'm keeping this issue open until we update it.


switch nydus-cached to mio

Right now nydus-cached is the only one left using event_manager. We can switch it to mio and drop event_manager dependency.

If no one works on it, I would like to work on it.

@uran0sH Wenyu, thanks so much for taking it.

@uran0sH Are you still working on it?

I am busy for preparing the final exam, so I have no time to work on it.


Add integration test module

At least one module should be added for integration test.
Smoke tests are needed to check that basic features works on Quarkus: client-side code generation, communication with endpoints, push, security
For example, we can set up:

the HelloWorld view, with textfield and button, calling an endpoint and updating the UI with the response
a view with a button that starts and stops PUSH messages; the endpoint could be a simple counter and the view shows the updated value
a public view, an authenticate view, a role protected view, a denied view

Since Testbench requires a license, to run the tests we can consider to use Selenium, Selenide or Playwright

I did some tests with Playwright and Selenide.
The first one seems good to me, as it was quite easy to create the test and had no great troubles and the documentation is pretty good.
I found more problems with Selenide, specially with shadow DOM, but maybe I did not use it correctly. Docs are a bit limited in my opinion.

After discussion, we agreed to use Selenide.
Since we will not have complex tests, Playwright can still be used in the future as an addition or replacement if needed.


[DEFECT] The "debug" mode is not a valid mode of operation

Defect Description
The "debug" mode is not a mode of operation for any case in the test cases in the folder: raven/plugins/HERON/tests
What did you expect to see happen?
Expected the capability to switch the mode of operation to "debug" as described in the docs.
What did you see instead?
An error message (see the image)

Do you have a suggested fix for the development team?
Describe how to Reproduce
Steps to reproduce the behavior:

Change the "mode" to "debug" mode in the "heron_input.xml" file into one of t he test cases in the folder: raven/plugins/HERON/tests
Run Heron: projects/raven/plugins/HERON/heron heron_input.xml

Screenshots and Input Files
heron_input1.txt
Platform (please complete the following information):

macOS Monterey 12.2

Dependencies Installation: Conda3

For Change Control Board: Issue Review
This review should occur before any development is performed as a response to this issue.

[x] 1. Is it tagged with a type: defect or task?
[x] 2. Is it tagged with a priority: critical, normal or minor?
[x] 3. If it will impact requirements or requirements tests, is it tagged with requirements?
[x] 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
[x] 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure
This review should occur when the issue is imminently going to be closed.

[x] 1. If the issue is a defect, is the defect fixed?
[x] 2. If the issue is a defect, is the defect tested for in the regression test system?  (If not explain why not.)
[x] 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
[x] 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
[x] 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?

Approved to close via #136.


Oracles: on_new_data() improvements

Hi,
As a user of orml_oracle, we've found some limitations regarding the on_new_data() callback when the oracle is fed:

on_new_data() should return a DispatchResult. A user could want to run custom logic that, if it fails, the oracle should not be fed. Right now, from the callback, we have no control over this situation.
on_new_data() should be called once with the whole list instead of one time per value. In our case, we use this callback as a trigger to make some expensive computations. We would save a lot of computation if we could combine this for all values.
on_new_data() should return the Weight. Because the user can run an expensive operation inside the callback, it will be awesome to reflect it to accurately the block time computation.

We can discuss any of the points. If you finally agree with them, I could also make a PR. Thanks!

All seems reasonable to me.

We need solid use cases to determine exactly how we want to do the change. A feature that no one is using is just a maintenance burden.
Also (4) is not compatible with (1). We need to have two different hook to achive both goals.

Why (4) is not compatible with (1)? The resulting signature adding these two points will be:
/// Triggers an event saying that a member has updated the key with a new value.
/// If this method fails, the Oracle update is finally not applied.
/// If the user wants to know the value, they should use `DataProvider`.
fn on_new_data(account_id: &AccountId, key: &Key) -> DispatchResult;

If the problem is that most implementors of OnNewData could need to use a DataProvider, it could be fixed as follows:
fn on_new_data<Provider: DataProvider>(account_id: &AccountId, key: &Key) -> DispatchResult {
    // As an implementor of this:
    // 1. I can choose if I really want the oracle to be updated or not returning an Err.
    // 2. I can trigger some computation for this event.
    // 3. I can read the value as DataProvider::get(key)
}

In our use case, we use oracles to set prices. For oracle members, they feed with fiat values, but for Oracle users through DataProvider, we offer the stable coin value, and therefore DataProvider does a mapping converting values. I can not trust the value of on_new_data() because the source of true is what DataProvider gives.

I see two use cases here:

Filter values before they are stored. This is used to reject invalid values.
Notify other pallets that new oracle is available.

1 should happen before the value is stored. 2 should happen after the value is stored.

I think both are the same case because the extrinsic is transactional, so:

Values are stored.
Notify new value is stored.
If the user rejects, the whole transaction is down, and nothing is stored.

But a provider can feed multiple values at once. So we need to either
for new_data in values
  with tranactional
    save(new_data)
    if !on_new_data(new_data)
      revert

or
let updated = values.filter_map |new_data| =>
  if on_pre_new_data(new_data)
    save(new_data)
    Some(new_data)
  else
    None

for new_data in updated
  on_new_data(new_data)

Both works but the second way is less overhead.

Yeah, with several values we have that issue.
To avoid choosing between an overhead (example 1) or complexity (example 2) solution, could we agree directly on all values or reject all if some of the value is not correct? From my point of view, it's like if I agree directly on the whole extrinsic called by the oracle member, which could make sense.
with transactional
  for new_data in values
    save(new_data)
  on_new_data(values) // Agree all or disagree all values

So, if there is an error, the member should call again with a correct list of values.

That could work. We just need to document it clearly.


[ONNX] support additional nllloss tests

Turns out a bunch of these tests did not really require dynamic unsqueeze support; their input nodes were constants. There is an issue with one test we should look into later but regardless with these changes many tests work.
Depends on #9039

Going to wait after #9039 to merge

Ok this is ready now


Yasemin's Mini Max

Added Yasemin's Mini Max bot to play Santorini. Looks two turns ahead (alpha = 2) and also prioritizes moving towards opponent and climbing to higher buildings.

For some reason it deleted half of the website files so I'm closing it

Forced reset my branch with main so all website files should be the same. Please can someone on the web dev side make sure it's ok? Thank you and sorry I messed up before


chore: Create AREnablePartnerOfferV1Improvements feature flag

This PR resolves []
Description
This PR creates a new feature flag (AREnablePartnerOfferV1Improvements) for Partner Offer v1 Improvements

#nochangelog
Need help with something? Have a look at our docs, or get in touch with us.

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against 913d1f36581e45fb149f10feb484d35debc50fb5


[SPARK-42153][UI] Handle null string values in PairStrings/RDDOperationNode/RDDOperationClusterWrapper

What changes were proposed in this pull request?
Similar to #39666, this PR handles null string values in PairStrings/RDDOperationNode/RDDOperationClusterWrapper
Why are the changes needed?
Properly handles null string values in the protobuf serializer.
Does this PR introduce any user-facing change?
No
How was this patch tested?
New UTs

cc @LuciferYang @dongjoon-hyun

@dongjoon-hyun @LuciferYang Thanks for the review.
Merging this one to master


Hard wrap at 120?

https://github.com/SepShr/MLCSHE/blob/cc5018836483c45b498e35d8bc4eff32a81e194f/CCEA.py#L214
It seems your editor has a small value for the hard wrap. Since we often have long variable/function names, I would suggest using a larger value, say 120, for it.
Then, the code will be look like this:
    complete_solutions_set = \
        collaborate_archive(a1, p2, joint_class, first_component_class) \
        + collaborate_archive(a2, p1, joint_class, first_component_class) \
        + collaborate_complement(p1, a1, p2, min_num_evals, joint_class, first_component_class) \
        + collaborate_complement(p2, a2, p1, min_num_evals, joint_class, first_component_class)

According to PEP 8 https://www.python.org/dev/peps/pep-0008/#id17, codes should be wrapped at 79. Though, they can be increased to 99 chars at most pending team decision. Additionally, all docstrings should be limited 72 chars. All in all, I can extend the hard wrap for code to 99, which are already wrapped at 80. Also all docstrings should be updated, since they are currently wrapped at 82.


Make sure the nightly CI has a different workflow name (#149)

Resolves #140 .

Codecov Report

Merging #150 (8f679e6) into master (497605b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   92.01%   92.01%
=======================================
  Files           6        6
  Lines         263      263
=======================================
  Hits          242      242
  Misses         21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 497605b...8f679e6. Read the comment docs.


resolv.conf no such file o directory

i just left to install docker on ubuntu 12.04 from this guide :
http://docs.docker.io/en/latest/installation/ubuntulinux/
and i got this
➜  ~  sudo docker run -i -t ubuntu /bin/bash
2014/03/26 11:45:17 Error: open /etc/resolv.conf: no such file or directory
any suggestions?

@unclejack @crosbymichael I am still seeing this issue today on docker version 1.12.6.
Why does /etc/resolv.conf gate running docker containers?

I too am still seeing this on my fully patched (as of today) Fedora Server 25 system running "Docker version 17.03.1-ce, build c6d412e".
$ journalctl -b |grep -i resolv.conf
Apr 21 16:18:58 filesrv.rob86.net avahi-daemon[1328]: Failed to open /etc/resolv.conf: Invalid argument
Apr 21 16:19:01 filesrv.rob86.net dockerd[1451]: time="2017-04-21T16:19:01.397160570-07:00" level=error msg="Failed to start container b2111a98e8050c720d26c341358e5916543cee2cf29e6f21328d1925fa32ec45: open /etc/resolv.conf: no such file or directory"
Apr 21 16:19:01 filesrv.rob86.net dockerd[1451]: time="2017-04-21T16:19:01.445159230-07:00" level=error msg="Failed to start container 35ab16d33c1e6611b74f9a28b0872c4200cf0b122a2c4c1649b0737a9e13171a: open /etc/resolv.conf: no such file or directory"
Apr 21 16:19:01 filesrv.rob86.net dockerd[1451]: time="2017-04-21T16:19:01.485162302-07:00" level=error msg="Failed to start container e31ad6359d6a846ebce0e13aa2bdd706dafedb4efd8e757a9f26ceef659b8f07: open /etc/resolv.conf: no such file or directory"
Apr 21 16:19:01 filesrv.rob86.net dockerd[1451]: time="2017-04-21T16:19:01.521160844-07:00" level=error msg="Failed to start container cd56af1b4ff3a104a2584f4f89209b158030e6f883e30d5e5302efd3ee6b7a66: open /etc/resolv.conf: no such file or directory"

I mitigated this by running sudo systemctl edit --full docker and adding the following line to the Service section:
ExecStartPre=/bin/bash -c 'until [ -s /etc/resolv.conf ]; do sleep 1; done'

My fc25 server gets its IP and DNS from DHCP, nothing statically configured. My DHCP server is a pfSense box if that matters.

I think there hasn't been a good answer on this and since I'm also experiencing this I'm reopening. @thaJeztah could you ping network maintainers? At this point I don't understand why container start is gated by network (we do have isolated machines where there's no resolv.conf file but we want to start containers anyway)

The resolv.conf manual (from glibc) states:
   If this file does not exist, only the name server on the local
   machine will be queried; the domain name is determined from the
   hostname and the domain search path is constructed from the domain
   name.

Therefore it should be assumed that a Linux system without a resolv.conf is a valid Linux system.
Other software such as golang's DNS resolv.conf loading logic, deals with missing or inaccessible resolv.conf in the same way: https://golang.org/src/net/dnsconfig_unix.go

Also, resolv.conf is not necessary on systems which use non-libc NSS modules such as nss-resolve or winbind, ldap, etc.

/cc @sanimej

This bug also prevent from using docker offline on some distributions.

Trying to fix it in: https://github.com/docker/libnetwork/pull/1847

just create an empty file names 'resolv.conf' at the place, my problem solved~

I see the fix for this was merged through https://github.com/moby/moby/commit/1ddeb11835600127a3319fc0dd3764e57ffbf521, which will be included in the upcoming 17.10 release; https://github.com/docker/docker-ce/blob/17.10/components/engine/vendor/github.com/docker/libnetwork/sandbox_dns_unix.go
closing, because this is resolved on master 👍


WIP: pkce integration omniauth

I was just in here browsing about PKCE and found this one: https://github.com/m0n9oose/omniauth_openid_connect/pull/80
Then when I refresh you just opened another one :o

duplicate #80

duplicate #80

But the other PR is closed, maybe we can get the attention of someone to open it again.


Tracking: base ledger prototype version 3

This is tracking issue for the base ledger prototype version 3 (a follow-up to base ledger prototype version 2 #62).
Goals:

integrate Ferveo/ABCI++ (blocked on tendermint release)

#357
#358
#362
#392

IBC integration for VPs/tx ICS20

#326
#327
#411
#480
#498
#607

PoS

#434
#435
#436
#437
#438
#439
#440
#441
#442
#443
#459
#460
#462
#463
#635
#637
#638
#639
#640

MASP integration - should start with a exploration/design doc
base ledger

#675
#674
#645
storage data schema (described in https://github.com/heliaxdev/anoma-prototype/pull/126)
#208
#258
#288
#4
#298
#167
#625
#88
#113
#189
#191
#315
#335
#634
#455
#472
#581
#583
#592
#602
#624
#625
#628
#634
#641

WASM

#678
#309
#79
#157 and #677
#21
#308
#22
#564

validity predicates

#25
#193
#495
#636

crypto

#163
#162
#646
#225

storage

#631
#632, #591
#633
#582
#7
#81
#372
#383
#626

gas & fees

#72
#293

continuous

#739
#740
updating dependencies
updating tooling
#481

lower priority:

#676
#578
#208
#250
#351
#352
#354
#403
#427
#455
#525

┆Issue is synchronized with this Asana task by Unito

I'm updating this issue

intent gossiper & matchmaker issues have been separated into #620

this workflow is replaced by project board https://github.com/orgs/anoma/projects/1


Update lockfile to pinned version of prettier

Commit 1dab9186d520aafb4cdb69eea777a23b9cf6528d downgraded the version
of the code reformatting tool ‘prettier’, leaving the version listed in
the lockfile out of date. Updating the lockfile should make CI happy
again.

Hm, fetching dependencies no longer fails, but now Travis reports an issue while building.

The building error seems to have been introduced by the same commit as the lockfile issue, 1dab9186d520aafb4cdb69eea777a23b9cf6528d.

The build process complains that the module js-levenshtein is missing. If I'm reading the lockfile correctly, that package was previously included as a transitive dependency of<EMAIL_ADDRESS>version. The update to<EMAIL_ADDRESS>may be what introduced the crash.

It might be worth sharing these conclusions so far with the team @andrewhercules, in case anyone else is unable to build the alpha branch.

@javfg can you please review this PR and then follow up with PR #132?

Hm, now that I try again locally, the build is no longer failing. Something may have changed in the dependency repositories. Do you know who could ask Travis to retry as well?

Maybe I can re-trigger the checks by changing the commit hash. I'll try that.

I see—my local build breaks if I build yesterday's alpha branch and then try to build this branch without cleaning out node_modules/ in between. I think it might be this issue: https://github.com/facebook/create-react-app/issues?q=is%3Aissue+is%3Aclosed+8810

This Travis documentation suggests that node_modules is cached by default. @javfg, do you know who would have the right permissions to clear that cache?

The issue in travis is related to browserstack. It has been failing for a long time, probably @mirandaio can chime in as I have no permissions on travis yet.

The issue I'm seeing is not, @javfg: I can reproduce and resolve it locally by clearing the cached node_modules/. Although I imagine the issue you mention will reappear once this one is resolved.

I hope we can resolve these ones; continuing to work on the code before they are resolved might allow more and more issues to sneak in unnoticed, and slow down development over time.

@fedde-s Thanks for this PR. We recently upgraded several dependencies but decided to keep and pin our prettier version as recommended in the docs since we don't want to reformat our codebase for every change a new version of prettier introduces. In that process, we forgot to update the yarn.lock file.

The issue I'm seeing is not, @javfg: I can reproduce and resolve it locally by clearing the cached node_modules/. Although I imagine the issue you mention will reappear once this one is resolved.

Ah, ok. I was checking the logs on travis but maybe went to the wrong one, as I saw the familiar browserstack error. In any case, we have to fix our CI.

@mirandaio, no blame intended! I saw the cause, checked the intention in the commit message, and found a step forward from where the codebase was :slightly_smiling_face:


Backout "Add tests for absolute positioning of children with padding in the parent"

Summary:
Backing out D50670457
Github PR is: https://github.com/facebook/yoga/commit/4f98bfe40a72aed0d5888d9d5c5d9c2340da7f4f
That PR started failing our workflows due to a build error in gtest. It seems unlikely that it is due to that change but backing it out to see if it fixes that issue.
https://github.com/facebook/yoga/actions/runs/6657567207/job/18095847672
Differential Revision: D50708256

@joevilches I think this is likely due to a change in the ubuntu-latest image.
The error is happening in headers for GCC stdlibc++. The clang build should instead be using LLVM libc++.
I think we could try to follow the solution in https://stackoverflow.com/questions/76859275/error-compiling-a-cpp-containing-stdchrono-errorstatic-constexpr-unsigned-fra in project-defaults.cmake, conditionally when compiling with Clang.

Here’s some information I found about the stdlib included by default. https://stackoverflow.com/questions/19774778/when-is-it-necessary-to-use-the-flag-stdlib-libstdc

Looks tentatively like https://github.com/facebook/yoga/pull/1440 should fix.


builde error

/mxnet/mshadow/mshadow/./base.h:163:26: fatal error: cusolverDn.h: No such file or directory    #include <cusolverDn.h>
Description
because my cuda version is 6.5, I change the /make/config.mk as follow
USE_CUDA_PATH = /usr/local/cuda-6.5
but when make -j8,find error "cusolverDn.h: No such file or directory"
what should I do? does the cuda version must be 8.0?
Environment info (Required)
ubuntu 16.04
cuda 6.5

@szha cuda 6.5 should be supported, right?
@994374821 did you try an older version of MXNet?


Fix crate compilation on stable, port to edition 2018

This branch fixes crate/example compilation for latest stable compiler release (1.32.0). RTFM example has been updated to use RTFM v0.4.0 (also somewhat restructured).
Crate version bumped to v0.7.0.

Sorry for being unreachable. I delivered by master thesis yesterday and moving the whole weekend. I will come back to this during the start of the upcoming week.

Finally got around to test things. It worked great, and the previous version doesn't even build. Thanks a ton @Tmplt for getting this in working order!
Sorry for taking so long with this. My excuse is that I've delivered my master thesis, moved and started a new job the last two weeks. However, it's not ideal that I'm the only person that can merge these PRs, and finding a co-maintainer for s32k144 and s32k144evb would be great. If you intend to use s32k with Rust in the future and would like to be involved on the maintainer side of these crates send me an e-mail and we will take it from there.
I will publish a new version on crates.io tonight. Just in case you have any objections and want to get another PR in first.

Sorry for taking so long with this.

No worries. Thanks for taking some time out of your busy schedule!

Just in case you have any objections and want to get another PR in first.

Nothing for now. Future PRs are likely to be feature additions.

If you intend to use s32k with Rust in the future and would like to be involved on the maintainer side of these crates send me an e-mail and we will take it from there.

I'll be in touch!


Develop connectors or plug-ins for external systems to access StarRocks【Easy】

Requirement Description

Provide plugins for Kettle like starrocks-bulk-loader or starrocks-bulk-insert.(Some UI developing works are needed during the proccess) - Java
Provide source and destination connectors for Airbyte. - Theoretically any language would be OK, but currently Python is preferred.
Provide a SQLAlchemy dialect which looks like starrocks://xxxx for a better querying experience within Superset. - Python

Mentor
@hffariel
Registration procedure
Step 1. Add a comment when you sign up. The comment can be a brief self-introduction and reason for signing up, including what you do, what you're good at, what you're interested in and your technology stack, and how familiar you are with StarRocks. Example:

I pick! My name is Johnny. I am from StarRocks and I have been working on database kernel development for 1 year. I am interested in OLAP, good at C++ programming, and have been using StarRocks for 6 months. I chose to solve this issue because I am familiar with execution engine.

Step 2. On your WeChat, add the StarRocks community assistant "StarRocks-1" as a WeChat friend and leave your GitHub ID. The assistant will invite you to a WeChat group based on the issue you picked.
Step 3. The mentor will communicate with all the participants who picked this issue and assign the task to the best match.
Before you start

Read the StarRocks GitHub workflow carefully, which provides the configurations of BE and FE and describes how to submit a pull request.
To learn more about StarRocks, read StarRocks documentation.

Pull request requirements

After you complete code development, upload the code to the StarRocks code repo as a pull request (PR).

PR title format: [SR GeekCamp] + PR title
Labels ：[Geek Camp 2022/feature]

After you submit your PR, comment on the status of your PR submission as requested under the Pinned Issue [StarRocks geek Camp 2022] page.

Comment format: "I have finished Issue #" + PR link id

Hi, this is ooobug. Now I am doing data engineering in a SaaS company and quite good at data munging such as etl and analysis, etc. I have expertise in Python language for about 4 years as well. This issue attracted me because of my enthusiasm for exploring like especially new realm anyway. So here I am. Let's make better ecosystem for Starrocks through joint efforts.

Is this ticket open to Spark? I see Starrocks has a Spark Connector based on Spark DataSource V1 API under Apache License v2 now.


Add UI/API warning when removing a custom role that is in use

SURE-4773

https://github.com/rancher/dashboard/issues/6578 has more details from the ticket, so closing that in lieu of the details there. Wish I saw this earlier...


Fix Finalization when other finalizers are in place

The webhook's isRemovingFinalizer func should check whether the change is less finalizers, obviously, and not specifically check whether the old Scaledobject has exactly 1 finalizer AND the new Scaled object has exactly 0.
This is to fix a use case in which ArgoCD performs cascading deletion which translates to a foregroundDeletion finalizer being added to the object, causing the current webhook implementation enter a loop of update-validate ("if not isRemovingFinalizer then update") instead of proceeding with deletion.
Checklist

[ x] I have verified that my change is according to the deprecations & breaking changes policy

[ ] Changelog has been updated and is aligned with our changelog requirements

[ X] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Nice catch!
Thanks for the fix :)

/run-e2e internal

/run-e2e internal

Not sure the failing check is relevant to my change 🤔

/run-e2e pause_scaledjob_test

/cherry-pick release/v2.12


got same translate result

Description
hey, I exported the model using the command it provide. but when I predict new query, it always output the same thing. I tried to check few things and find that response = stub.Predict(request, timeout_secs) (from serving_utils.py ) always return the same value. any idea whats got wrong here ?

Hallo(my input is this )
the output is :  In fact, the government does not want to protect itself or to do so. It is only a question, bigger than any other, that is necessary.
no matter what my input is I always got the same result.
...

Environment information
OS: <your answer here>
mesh-tensorflow==0.0.5
tensor2tensor==1.11.0
tensorboard==1.12.0
tensorflow==1.12.0
tensorflow-gpu==1.10.1
tensorflow-hub==0.1.1
tensorflow-metadata==0.9.0
tensorflow-probability==0.5.0
tensorflow-serving-api==1.12.0
tensorflow-tensorboard==1.5.1

$ pip freeze | grep tensor
# your output here

$ python -V
# your output here

Python 3.6.7 :: Anaconda, Inc.
For bugs: reproduction and error logs
# Steps to reproduce:
...

# Error logs:
...

I too got the same results for question answers problem for every test query after training the model for 130k steps and the loss for training had gone down to less than 1.


[podofo] Fails to protect PDF file

Describe the bug
PoDoFo up to now was capable (for several months) of protecting/encrypting PDF files programmatically. Today I performed vcpkg update and received various updates for podofo dependencies and my application now crashes while protecting the pdf with podofo. As the problem is related to crypto I think that the latest openssl updates may be causing the problem with podofo.
The relevant podofo code that triggers the issue is:
doc.SetEncrypted("",
                             "passwordstring",
                             PoDoFo::PdfEncrypt::ePdfPermissions_Print |
                             PoDoFo::PdfEncrypt::ePdfPermissions_Accessible |
                             PoDoFo::PdfEncrypt::ePdfPermissions_HighPrint,
                             PoDoFo::PdfEncrypt::ePdfEncryptAlgorithm_AESV2,
                             PoDoFo::PdfEncrypt::ePdfKeyLength_128);

Disabling this instruction disables pdf protection and podofo successfully creates a pdf again.
The bug occurs both on windows and macOS.
EDIT: Updated the PoC and the resulting error message.
Environment

OS: Windows 10 21H2 and macOS 12.3.1 Apple Silicon
Compiler: Apple Xcode 13.3.1 clang; Visual Studio 2019 latest update

To Reproduce
Steps to reproduce the behavior:

./vcpkg install podofo[fontconfig]

Run test code:
#include <iostream>
#include <podofo/podofo.h>

int main() {
    try {
        PoDoFo::PdfMemDocument doc;
        // you must provide orig.pdf
        doc.Load("orig.pdf");
        // enabling .SetEncrypted will cause the exception
        doc.SetEncrypted("",
                         "ownerPassword",
                         PoDoFo::PdfEncrypt::ePdfPermissions_Print |
                         PoDoFo::PdfEncrypt::ePdfPermissions_Accessible |
                         PoDoFo::PdfEncrypt::ePdfPermissions_HighPrint,
                         PoDoFo::PdfEncrypt::ePdfEncryptAlgorithm_AESV2,
                         PoDoFo::PdfEncrypt::ePdfKeyLength_128);
        //will be created when no error
        doc.Write("protected.pdf");
    }
    catch (PoDoFo::PdfError &e) {
        e.PrintErrorMsg();
    }

    return 0;
}

No compilation errors.

Expected behavior
A protected PDF should be created.
Failure logs
PoDoFo encountered an error. Error: 8 ePdfError_InternalLogic 	Error Description: An internal error occurred. 	Callstack: 	#0 Error Source: /Users/xxx/vcpkg/buildtrees/podofo/src/0e699739c2-e7dcab1c3c.clean/src/podofo/base/PdfEncrypt.cpp:985 		Information: Error initializing RC4 encryption engine
Additional context
The problem occurs both on Windows and on macOS.

The error points towards openssl:
int status = EVP_EncryptInit_ex(rc4, EVP_rc4(), NULL, NULL, NULL);
    if(status != 1)
        PODOFO_RAISE_ERROR_INFO( ePdfError_InternalLogic, "Error initializing RC4 encryption engine" );

I couldn´t get it to work by modifying the CMakeLists.txt but instead modified portfile.cmake:
vcpkg_configure_cmake(
    SOURCE_PATH ${SOURCE_PATH}
    PREFER_NINJA
    OPTIONS
        -DPODOFO_BUILD_LIB_ONLY=1
        -DPODOFO_BUILD_SHARED=${PODOFO_BUILD_SHARED}
        -DPODOFO_BUILD_STATIC=${PODOFO_BUILD_STATIC}
        -DPODOFO_NO_FONTMANAGER=${PODOFO_NO_FONTMANAGER}
        -DCMAKE_DISABLE_FIND_PACKAGE_FONTCONFIG=${PODOFO_NO_FONTMANAGER}
        -DCMAKE_DISABLE_FIND_PACKAGE_LIBCRYPTO=${IS_WIN32}
        -DCMAKE_DISABLE_FIND_PACKAGE_LIBIDN=ON
        -DCMAKE_DISABLE_FIND_PACKAGE_CppUnit=ON
        -DCMAKE_DISABLE_FIND_PACKAGE_Boost=ON
        -DPODOFO_HAVE_OPENSSL_NO_RC4=ON
)

The PoC now does not throw an exception anymore BUT it does NOT work as expected. It is still broken. Generated PDFs opened with Acrobat Reader ask for a password which is always incorrect even if all password are specified as empty in the code. PoDoFo and/or the PDF spec need RC4 legacy to function properly.

@derreisende77   could you please provide your CMakeLists.txt in VS.

cmake_minimum_required(VERSION 3.21)
project(pdf_test)

find_package(Fontconfig REQUIRED)
find_package(Freetype REQUIRED)
find_package(OpenSSL REQUIRED)
find_package(JPEG REQUIRED)
find_package(expat CONFIG REQUIRED)

add_executable(pdf_test main.cpp)

target_link_libraries(pdf_test PRIVATE /Users/XXX/vcpkg/installed/arm64-osx/lib/libpodofo.a)
target_link_libraries(pdf_test PRIVATE OpenSSL::Crypto)
target_link_libraries(pdf_test PRIVATE ${FREETYPE_LIBRARIES})
target_link_libraries(pdf_test PRIVATE ${Fontconfig_LIBRARIES})
target_link_libraries(pdf_test PRIVATE ${JPEG_LIBRARIES})
target_link_libraries(pdf_test PRIVATE /Users/XXX/vcpkg/installed/arm64-osx/lib/libunistring.a)
target_link_libraries(pdf_test PRIVATE expat::expat)

I am using CLion both on windows and macOS and CMAKE_TOOLCHAIN_FILE is set in the project.

Unfortunately, I haven't been able to reproduce this problem. Has it been solved now？@derreisende77

No. I opened a ticket with the library creators. And I am going to open a ticket for weak cypher support option for openssl.

BTW they released version 0.9.8 of PoDoFo. Also now available on github as they are migrating to it.


fix CurrentTime not positioning to a multiple of BlockAlign

setting CurrentTime of a WaveStream could result in the Position being set to something that is not a multiple of BlockAlign

what situation were you getting this issue in? This is normally handled one layer up e.g. (WaveFileReader, Mp3FileReader)

Hi Mark.
I'd only hit it in one of my own WaveStream subclasses, after refactoring it's callers from using Position (which I'd block aligned in the caller) to CurrentTime (which starting spitting garbage because my subclass relied on the caller doing the alignment).
It looks like I have misinterpreted these docs, particularly the word underlying:

If this is the case, be careful to ensure that the underlying stream is never set to a non block-aligned position. If it is, the resulting audio will be garbage.

I'd mistakenly interpreted this as a constraint of the WaveStream.Position property, and thought that the CurrentTime setter should respect this. Sorry, and thanks for such a great library.


Rework SELinux labeling more

First, in the install code, acquire a proper policy object.
Add helpers for writing files/directories that take a policy object and operate solely using fd-relative operations and don't fork off helper processes.
This is a notable cleanup because we don't need to juggle absolute file paths and fds, which avoids a lot of confusion. Our usage of a wrapper for the cap-std-ext atomic write API for generating files ensures that if the file is present, it will always have the correct label without any race conditions.
Change the one place we now call chcon as a helper process to be an explicit recursive selinux relabeling.  In the future we should switch to using a direct API instead of forking off /usr/bin/chcon - then everything would be fd-relative.

Ah OK right,

ERROR Failed to look up context for "./boot.1.1": No data available (os error 61)

We have more forcible labeling to do here.  Conceptually this one should be ostree side probably.

Ohh yeah, looking at the warning output there's quite a bit of work in ostree to handle this.  Updated https://github.com/ostreedev/ostree/issues/2804#issuecomment-2003725828
Maybe what we need here for all of that is just a single pass "relabel everything that isn't a deployment with usr_t".
Although

No SELinux label found for: "./deploy/default/deploy/f512f95348cbaa175f3361dea0f09ccaadd089909dacc3ffb0c0b7e602f4f2dc.0/etc/tmpfiles.d/bootc-root-ssh.conf"

That one should have worked with this.  But not sure about blocking on that.

OK yeah, I'm going to have to set up a dev/test environment for this "install from host with selinux=0" case, but...I think this latest push should get us a lot closer to working in that path.

OK cool!  Now we're just down to

No SELinux label found for: "./deploy/default/deploy/6f41b63072258824399f24f39c499e5ce22dd8e5d6942917b2b21b11f4ab5463.0/.ostree.cfs"

Which should be pretty tractable to fix in ostree.  (In practice it's not really relevant I think because policy isn't loaded until post-switchroot)


Minor fixes to FPS constant and timescale

This PR addresses a couple of feedback items from my previous PR.
Regarding documentation of timescales, unfortunately I haven't encountered any (though it may exist, somewhere) — it's all based on observations from working with AVFoundation on other projects. It quite frequently uses FPS*100 as a timescale when working with video.

Thanks for the followup!!


Use Keras (with tf 1.2)

Keras offers an excellently designed API for a variety of networks/optimizers. Most importantly, all of these networks can be run with the same API, which would allow users of demeter a ton of flexibility to plug in custom Keras networks. This mitigates the need for wrapper class around tf.slim (eg. what we're currently doing)
For the policy networks, we'd add a custom tf loss to a user provided Keras network like so: https://twitter.com/fchollet/status/834845037435420676
For policies where we need to adjust the step size in response to KL-divergence change, we can use LearningRateScheduler: https://github.com/fchollet/keras/issues/888
Keras is getting mainlined into tf 1.2, so I'm not sure how much of the first example works as of now.

example using only keras layers, everything else TF: https://github.com/rarilurelo/pcl_keras


Update kinfocenter.nix

Current symlink to systemsettings5 overwrites the kinfocenter binary!
(explains why running kinfocenter opens systemsettings instead of kinfocenter).
Have renamed the symlink from $out/bin/kinfocenter to the correct $out/bin/systemsettings5
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

targets the wrong branch


[PE-D][Tester D] Entries can contain invalid emails

New entries added accepts invalid emails as input

Labels: severity.Low type.FunctionalityBug
original: tyouwei/ped#1

Other issue covers this. #194. Closing duplicate.


⚠ Spryr has degraded performance

In c74a1ef, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4159 ms

Resolved: Spryr performance has improved in 81e90a2 after 7 minutes.


Doc on updating management cluster name in cluster spec

Issue #, if available:
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherry-pick release-0.12

/approve
/lgtm


Improved validation for patient bulk upload

BACKEND PULL REQUEST
Related Issue

Fixes #4372

Changes Proposed

Split out validation and saving operations on the patient bulk uploader.
Validation is more robust and acceptable format/values have changed slightly - see the PDF in https://github.com/CDCgov/prime-simplereport-site/pull/395 for a comprehensive summary.

Additional Information

Tests have also changed substantially; I've left comments where appropriate

Testing

You're able to upload valid CSV
Invalid CSVs kick back an error
Note that if the user submits an invalid file, we do not return an HTTP error, just a 200 and a list of error messages. This is consistent with the behavior in the test result uploader

Checklist for Primary Reviewer

[ ] Any large-scale changes have been deployed to test, dev, or pentest and smoke tested
[x] Any content updates (user-facing error messages, etc) have been approved by content team
[x] Any changes that might generate questions in the support inbox have been flagged to the support team
[x] GraphQL schema changes are backward compatible with older version of the front-end
[x] Changes comply with the SimpleReport Style Guide
[x] Changes with security implications have been approved by a security engineer (changes to  authentication, encryption, handling of PII, etc.)
[x] Any dependencies introduced have been vetted and discussed
[x] Any changes to the startup configuration have been documented in the README

@emmastephenson I'm assuming that right now (until Boban's changes get merged) we are expecting this slightly confusing user experience on the frontend:

It does return a 200 as expected and shows the errors found. I say confusing b/c it's green and has a check mark and says "Patients Uploaded".

@emmastephenson I'm assuming that right now (until Boban's changes get merged) we are expecting this slightly confusing user experience on the frontend:
It does return a 200 as expected and shows the errors found. I say confusing b/c it's green and has a check mark and says "Patients Uploaded".

@georgehager yep, that's correct. Until the new frontend is merged in, we'll get this toast listing the errors.


Added admoniton for a possible error fix

While following the tutorial I got a Permission Error and didn't know how to proceed.
I've tried adding a folder the system was looking for and then the process continued smoothly. I thought that adding this admonition to the tutorial may help others in case this happens to them as well.

I added an admonition to let people know a possible solution to a possible problem encountered after the "briefcase build android" command.

Personally at first I found myself lost and I was even looking for other python-to-android builders and came back just because I've not found any that convinced me.
Adding that hint may help others not lose their time by doing that.

PR Checklist:

[ ] All new features have been tested: the briefcase build android command worked and actually filled the folder. Now I have another problem with "briefcase runandroid", but I don't think it's correlated (the folder I manually created has been correctly filled by the "briefcase build android" command)
[x ] All new features have been documented
[ x] I have read the CONTRIBUTING.md file
[x ] I will abide by the code of conduct

Hello @giorgio-pasini, would you be able to upload the Briefcase log file for this error? I'm curious if there's anything we can do to prevent this altogether.

One compelling reason I found for this error is a background process acquired a handle for the cmdline-tools directory or a file/directory within it; for instance, a Windows file indexer or maybe an antivirus scanner.
I could replicate the error using open() on a file in one Python interpreter and trying to call os.rename() for its directory in another. A mitigation might be automatically retry....

Hello Russel,
I'll try to replicate the error from the very beginning cleaning up all the files.
I'll update you with what comes up.
Meanwhile, thanks for the kind and swift response!

@giorgio-pasini: Please check the logs directory of your project, and if you can find the log that corresponds to this error, upload it to the issue.
If the error was caused by what @rmartin16 thinks, I don't see how creating the directory manually would make any difference. Did you try running the same Briefcase command again before creating the directory? If so, did you get the same error, or a different one?
In any case, let's not clutter the documentation with workarounds for bugs that we can fix properly.


[BUG] With datadog/agent:7.55.3-jmx I cannot exclude java.lang metrics

I am trying to configure my kafka debezium connector with JMX metrics and found that we are not sending all the metrics. Some of them are lost because they are string or map etc which is fine. But some are truncated because there are too many metrics. This is the message in logs.
2024-08-07 16:00:29 2024-08-07 10:30:29 UTC | JMX | INFO | Instance | Found 356 matching attributes
2024-08-07 16:00:29 2024-08-07 10:30:29 UTC | JMX | WARN | CustomLogger | Number of returned metrics is too high for instance: jmx_instance. Please read http://docs.datadoghq.com/integrations/java/ or get in touch with Datadog Support for more details. Truncating to 350 metrics.

Also in datadog website > Metrics summary > filter by service name -- i only get 266 metrics. So we definitely are not over the limit.
Agent Environment
FROM datadog/agent:7.55.3-jmx
Config:
init_config:
    is_jmx: true
    collect_default_metrics: true
    new_gc_metrics: true
    service: {{ SERVICE_NAME|default("kafka_connect") }}
    conf:
      - include:
          domain: 'debezium.mysql'
      - exclude:
          attribute:
            - LastAppliedChange
            - LastRecoveredChange
            - Status
            - LastEvent
            - ChunkId
            - ChunkFrom
            - ChunkTo
            - TableFrom
            - TableTo
            - GtidSet
            - BinlogFilename
            - LastEvent
            - SourceEventPosition
            - LastTransactionId
            - Version
            - CommitId
            - BufferPool
            - Name
            - Type
            - UsageThreshold
            - commit-id
            - version

logs: []

instances:
  - host: localhost
    port: 9095
    rmi_registry_ssl: false
    name: jmx_instance

Describe what you expected:

Shouldn't i get most of the metrics in datadog website.
If we are exceeding the limit cant I exclude the java.lang and other java.* metrics? We get some of them from datadog integration with AWS ECS.

Steps to reproduce the issue:
This is the Dockerfile content
FROM datadog/agent:7.55.3-jmx

LABEL dd.agent.version="7.55.3"

RUN apt-get -y update \
  && apt-get -y upgrade \
  && apt-get -y clean \
  && rm -rf /var/lib/apt/lists/*

COPY conf.yaml /etc/datadog-agent/conf.d/kafka.d/conf.yaml

Hi, thank you for using Datadog.
The number on the metric summary page is lower because it shows number of distinct metric names, not taking tags into account (total number is visible after clicking on the metric name). Each matching JMX attribute becomes a metric, but multiple beans can use the same metric name, with bean attributes becoming metric tags (for an example please see the default config).
To exclude java metrics, you can add this filter to your JMX integration config:
- exclude:
  domain: java.lang

If you have any further questions, please feel free to contact Datadog support.


add enableAggregatedAPIs docs

What this PR does / why we need it:
Adds documentation for the enableAggregatedAPIs config option

Thanks @pidah !


Workers getting killed?

Any idea why that happens? There was nothing in worker.log.

Last lines before it gets killed:

Line 477210: [2016-07-31 04:40:11,157][  worker-1][    INFO][L 211] Creating a new direct request...
Line 477211: [2016-07-31 04:40:11,157][  worker-1][    INFO][L 218] Adding 'GET_MAP_OBJECTS' to RPC request including arguments
Line 477212: [2016-07-31 04:40:11,157][  worker-1][    INFO][L 179] Execution of RPC
Line 477213: [2016-07-31 04:40:11,158][  worker-1][    INFO][L 788] Starting new HTTPS connection (1): pgorelease.nianticlabs.com
Line 477272: [2016-07-31 04:40:11,486][  worker-1][    INFO][L 187] Cleanup of request!
Line 477273: [2016-07-31 04:40:11,486][  worker-1][    INFO][L 182] Point processed, 0 Pokemons seen!
Line 477330: [2016-07-31 04:40:11,891][  worker-1][    INFO][L 155] Visiting point removed (removed)
Line 477331: [2016-07-31 04:40:11,891][  worker-1][    INFO][L 211] Creating a new direct request...
Line 477332: [2016-07-31 04:40:11,891][  worker-1][    INFO][L 218] Adding 'GET_MAP_OBJECTS' to RPC request including arguments
Line 477333: [2016-07-31 04:40:11,892][  worker-1][    INFO][L 179] Execution of RPC
Line 477334: [2016-07-31 04:40:11,894][  worker-1][    INFO][L 788] Starting new HTTPS connection (1): pgorelease.nianticlabs.com
Line 477390: [2016-07-31 04:40:12,226][  worker-1][    INFO][L 187] Cleanup of request!
Line 477391: [2016-07-31 04:40:12,226][  worker-1][    INFO][L 182] Point processed, 0 Pokemons seen!
Line 477437: [2016-07-31 04:40:12,602][  worker-1][    INFO][L 155] Visiting point removed (removed)
Line 477438: [2016-07-31 04:40:12,602][  worker-1][    INFO][L 211] Creating a new direct request...
Line 477439: [2016-07-31 04:40:12,602][  worker-1][    INFO][L 218] Adding 'GET_MAP_OBJECTS' to RPC request including arguments
Line 477440: [2016-07-31 04:40:12,608][  worker-1][    INFO][L 179] Execution of RPC
Line 477441: [2016-07-31 04:40:12,611][  worker-1][    INFO][L 788] Starting new HTTPS connection (1): pgorelease.nianticlabs.com
Line 477491: [2016-07-31 04:40:12,936][  worker-1][    INFO][L 187] Cleanup of request!
Line 477492: [2016-07-31 04:40:12,936][  worker-1][    INFO][L 182] Point processed, 0 Pokemons seen!
Line 479155: [2016-07-31 04:40:25,216][  worker-1][    INFO][L 259] Worker (re)starting up!
Line 479156: [2016-07-31 04:40:25,216][  worker-1][    INFO][L  57] pgoapi v1.1.5 - Copyright (c) 2016 tjado https://github.com/tejado
Line 479157: [2016-07-31 04:40:25,216][  worker-1][    INFO][L  51] Login for: removed
Line 479158: [2016-07-31 04:40:25,217][  worker-1][    INFO][L 788] Starting new HTTPS connection (1): sso.pokemon.com
Line 479265: [2016-07-31 04:40:26,102][  worker-1][    INFO][L  96] PTC Login successful
Line 479266: [2016-07-31 04:40:26,104][  worker-1][    INFO][L 115] Starting RPC login sequence (app simulation)
Line 479267: [2016-07-31 04:40:26,104][  worker-1][    INFO][L 213] Creating a new request...
Line 479268: [2016-07-31 04:40:26,104][  worker-1][    INFO][L 222] Adding 'GET_PLAYER' to RPC request
Line 479269: [2016-07-31 04:40:26,104][  worker-1][    INFO][L 222] Adding 'GET_HATCHED_EGGS' to RPC request
Line 479270: [2016-07-31 04:40:26,104][  worker-1][    INFO][L 222] Adding 'GET_INVENTORY' to RPC request
Line 479271: [2016-07-31 04:40:26,104][  worker-1][    INFO][L 222] Adding 'CHECK_AWARDED_BADGES' to RPC request
Line 479272: [2016-07-31 04:40:26,104][  worker-1][    INFO][L 218] Adding 'DOWNLOAD_SETTINGS' to RPC request including arguments
Line 479273: [2016-07-31 04:40:26,104][  worker-1][    INFO][L 179] Execution of RPC
Line 479274: [2016-07-31 04:40:26,105][  worker-1][    INFO][L 788] Starting new HTTPS connection (1): pgorelease.nianticlabs.com

It's the new 5 second per scan limit.

http://imgur.com/kXrznPF seems like.

@pokemonracer line 188 of worker.py

Is it just me or do they not seem to be restarting after killed?

@vDrag0n yeah, they're not restarting. I'm getting a lot of workers getting exceptions now also.

Please check out v0.4.1. You'll probably want more workers than before.

How many more workers than before would you recommend? Also, is it better for the worker points to be overlapping? The circles that show in the overlay.

Each worker can scan one point every 5 seconds, and single cycle should finish under 15 minutes in order not to have missed spawns. That means keeping under 180 points per cycle should be enough.

More or less points per cycle is better? Got ~195 currently.

Less is better if you want to lower the load on each worker.

how do you calculate the points per cycle?

@vDrag0n just run worker.py and it tells you at the top

@pokemonracer do you solved the problem?


implement three bubble diagrams

Codecov Report

Merging #95 (7dd8ee5) into computgraph_xc (f764640) will decrease coverage by 0.68%.
The diff coverage is 6.89%.

@@                Coverage Diff                 @@
##           computgraph_xc      #95      +/-   ##
==================================================
- Coverage           54.11%   53.42%   -0.69%
==================================================
  Files                  43       43
  Lines                2785     2641     -144
==================================================
- Hits                 1507     1411      -96
+ Misses               1278     1230      -48

Impacted Files
Coverage Δ

src/FeynmanDiagram.jl
41.66% <ø> (ø)

src/frontend/parquet.jl
0.00% <0.00%> (ø)

src/computational_graph/graph.jl
80.83% <100.00%> (-0.92%)
:arrow_down:

src/quantum_operator/operator.jl
74.41% <100.00%> (ø)

src/diagram_tree/common.jl
50.00% <0.00%> (-5.56%)
:arrow_down:

src/computational_graph/common.jl
28.57% <0.00%> (-4.77%)
:arrow_down:

src/expression_tree/eval.jl
60.00% <0.00%> (-3.89%)
:arrow_down:

src/common.jl
60.95% <0.00%> (-2.12%)
:arrow_down:

src/expression_tree/tree.jl
70.00% <0.00%> (-2.10%)
:arrow_down:

src/parquet_builder/benchmark/diagram_count.jl
55.69% <0.00%> (-1.63%)
:arrow_down:

... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[8.x] Adding a replacement character

There was a problem if you specify an attribute with a "dot" in the name in $appends, laravel tries to call a method with a "dot" in the name, which is an error.
Example:
protected $appends = [
        "user.fio"
]

Error:
Call to undefined method App\\Models\\OwnerCar::getUser.fioAttribute()

Could be a breaking change for some applications?


Have to type cast value when binding for Input.

Describe the bug
When binding an Inputs value to a string. The value has to be typecast other wise you get an error that you can't assign a number to a string.  The error your receive is:

Type 'string | number | readonly string[]' is not assignable to type 'string | undefined'.
Type 'number' is not assignable to type 'string'.ts(2322)

Reproduction
let foo: string | undefined = $state();

<Input name+"field1" bind:value{foo}/>

Version and System Info
System:
    OS: macOS 14.6.1
    CPU: (8) arm64 Apple M1
    Memory: 79.28 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 22.0.0 - /opt/homebrew/bin/node
    Yarn: 1.22.17 - /opt/homebrew/bin/yarn
    npm: 10.5.1 - /opt/homebrew/bin/npm
    pnpm: 9.9.0 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 128.0.6613.120
    Safari: 17.6

Do you still get the same issue?

	<Input name="field1" bind:value={foo}/>

If is so, you can import type InputProps:

	<Input name="field1" bind:value={foo}/>


[Native API] ReadableArray/Map <-> WritableArray/Map

Is there any way to convert say, a ReadableMap to a WritableMap ?
Or maybe you have a better way to handle this use case:
I have a component that receives objects as props or as method parameters.
This component should be able to emit an event with one of the received objects as property of the event.
Then you have problem, because the RCTEventEmitter API only sends WritableMaps/Arrays, and you have no way to go from readable to writable, you can't even store a readable object as a property of a writable one.
Deep copy is possible, but there should a better, lower level way I think.
I ended up passing ids back in the event, then do a match on the javascript side.

cc @kmagiera @mikearmstrong001

except from making a copy there is no easy way right now. I think it shouldn't be that complicated to patch bridge to allow nesting readablemap in writablemap or just to allow readablemap/array as an argument.
I think that passing IDs is a better approach as it saves on bridge traffic. When you pass object to native and then pass it back to JS it'd still make a copy of that object (it will be serialized twice).

Yes, and the IDs method doesn't even really add any boilerplate or other annoyance. thanks

It seems you are satisfied with using ids, if so could you close the issue?

Use merge method in WriteableMap.


fix(barchartcard): add classname to top container, allow empty series prop

Closes #1685
Closes #1684
Summary

className prop is now added to the top container in BarChartCard
If series is an empty array, show the empty card state
If values is empty, do not generate colors, as theres nothing to add colors to

Change List (commits, features, bugs, etc)

Updated tests
Updated stories
Added values: null to defaultProps to be more explicit

Acceptance Test (how to verify the PR)

Add a custom className and see that its attached to the top BarChartCard container
Set series: [] and isEditable: true and see that the empty state renders

:tada: This PR is included in version 2.134.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Cant deploy to multiple Env

Im under a load balancing env so I need to run several deploys at once
This is my config
#config.ru
case ENV['TARGET'].to_s.downcase
when 'production1'
  activate :deploy do |deploy|
    deploy.method   = :rsync
    deploy.host   = 'static-prod'
    deploy.clean = true
  end
when 'production2'
  activate :deploy do |deploy|
    deploy.method   = :rsync
    deploy.host   = 'static-prod2'
    deploy.clean = true
end
when 'staging'
  activate :deploy do |deploy|
    deploy.method   = :rsync
    deploy.host   = 'static-dev'
    deploy.clean = true
  end
end

#Rakefile
namespace :deploy do
  def deploy(env)
    puts "Deploying to #{env}"
    system "TARGET=#{env} bundle exec middleman deploy"
  end

  task :staging do
    deploy :staging
  end

  task :production1 do
    deploy :production1
  end

  task :production2 do
    deploy :production2
  end
end

When I ran rake deploy:production1 its prints Deploying to production1 but nothing happens. Although if I ran TARGET=production1 bundle exec middleman deploy its works.
Any idea?

The pattern I use for multi-environment rake tasks is:
#Rakefile
task deploy: :environment do
    ...
end

Note that this is for Rails environments and probably needs a receptive style like your config.ru to pick up the variable, as I'm pretty sure this command compiles to: ENV=#{:environment} rake deploy
Hope this helps.


check for valid JDK on startup

We need to check for the existence of Java (which version?) on startup and show an error message if it does not exist.

We do not need to ship Java with the build tool; people can figure that part out on their own.

ClojureScript requires Java 7+
Clojure does not require JDK, just the JRE

Screenshot of page when java is not installed:


Favicon/logo background color

Very minor but irritating issue - I have Dark Reader (dark mode everywhere extension) installed, so I'm not sure if this is just a me problem.
The favicon is perfect, but the black background looks odd in the a) bookmark bar, b) against the menu (black on dark grey, very subtle), and c) tab.
idk what the solution looks like - perhaps just drop the background? mail logo only?

navbar logo has been updated in 4f51a88723fdc7562cb94d2b9a749066ff75423d; still need to update favicon

favicon fixed in https://github.com/eAbsentee/eAbsentee/commit/d6735bd7f8896a182b938b5601c23774cd959d85 and https://github.com/eAbsentee/eAbsentee/commit/5bc0e983cf81e9f0f768b040aaf7f4a41f5a78af


Number System Conversion

Feature ✅
Description

A menu-driven code to convert a given number from one base system to another
Menu:

Binary to Decimal
Binary to Octal
Binary to Hexadecimal
Decimal to Binary
Decimal to Octal
Decimal to Hexadecimal
Octal to Binary
Octal to Decimal
Octal to Hexadecimal
Hexadecimal to Binary
Hexadecimal to Octal
Hexadecimal to Decimal
Exit

Example

1.Decimal to Binary      2.Decimal to Hexadecimal        3.Decimal to octal
4.Binary to Decimal     5.Binary to Hexadecimal         6.Binary to octal
7.Hexadecimal to Decimal        8.Hexadecimal to Binary         9.Hexadecimal to Octal
10.Octal to Decimal     11.Octal to Binary      12.Octal to Hexadecimal
13.Exit
Enter your choice:
7
Enter a Hexadecimal number:
A
Decimal number is:10
1.Decimal to Binary      2.Decimal to Hexadecimal        3.Decimal to octal
4.Binary to Decimal     5.Binary to Hexadecimal         6.Binary to octal
7.Hexadecimal to Decimal        8.Hexadecimal to Binary         9.Hexadecimal to Octal
10.Octal to Decimal     11.Octal to Binary      12.Octal to Hexadecimal
13.Exit
Enter your choice:
13
Checklist:

[x] I have read the project guidelines.
[x] I have checked all the existing projects, before submitting a new project issue.
[x] This issue will be meaningful for the project.
[x] I will contribute more in future

Contributors are supposed to mention their coding language while asking for assignment

I'd like to contribute in Java

can you please assign to me for c?
Thank you

I would like to contribute in C++, thanks!

@nehalgupta8501 It has been assigned in c/c++, you can try another issue.

I could do this in python. Could you assign it to me?

Hi, my FIRST real issue, so I guess I have to ask you to assign it to me and then I can start working on it?
I would like to solve it with python or C#, thanks!

@itayz1230 Assigned for c#.

I would to contribute in GoLang.


Add introduction for SC UI

Preview https://github.com/asifdxtreme/service-center/blob/master/frontend/Readme.md

Codecov Report

Merging #131 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
+ Coverage   67.32%   67.37%   +0.04%
==========================================
  Files          18       18
  Lines        4190     4190
==========================================
+ Hits         2821     2823       +2
+ Misses       1194     1192       -2
  Partials      175      175

Impacted Files
Coverage Δ

server/service/services_dependency.go
67.6% <0%> (-0.71%)
:arrow_down:

server/service/governservice.go
65.53% <0%> (+1.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9a590...aadc604. Read the comment docs.

Coverage decreased (-0.1%) to 71.619% when pulling aadc6046d57a41b48d11f91332c49ff231b43f6a on asifdxtreme:master into 5d9a5908730d27b734e75d9fef9a9f9f77631b86 on ServiceComb:master.

Coverage increased (+0.05%) to 71.816% when pulling 1f0428296f7a7774fedb116a42700a139127860d on asifdxtreme:master into 5d9a5908730d27b734e75d9fef9a9f9f77631b86 on ServiceComb:master.

Coverage decreased (-0.02%) to 71.751% when pulling 1f0428296f7a7774fedb116a42700a139127860d on asifdxtreme:master into 5d9a5908730d27b734e75d9fef9a9f9f77631b86 on ServiceComb:master.

Coverage decreased (-1.6%) to 70.118% when pulling 9d5a716298e794a3aa7bda9fad2100b40e350ad6 on asifdxtreme:master into 5d9a5908730d27b734e75d9fef9a9f9f77631b86 on ServiceComb:master.


cx.param into a string doesn't handle url-decoding

When using cx.param to extract strings, I expected it to handle URL decoding for me. However, it did not. I would up writing some fairly complex code to deal with this. In general, I would expect this to be the default, with some way to request the "raw string" if I really wanted to get that, but at least there should be some super ergonomic way to "url-decode" your request parameters.
Question
Is this by design? Am I overlooking a simple way to do url-decoding?
Additional context
This is part of a flashcard app. The incoming request parameters are sometimes in other languages, so they are url-encoded utf-8.

Notes from triage: we should probably introduce a new API using https://docs.rs/serde_qs/0.5.0/serde_qs/ for this:
let params: MyType = cx.query();

Similar to how our current cx.body_json method currently works.

When I wrote the Context extension, serde_qs had outstanding bugs that were unresolved for longer than preferred. It looks like those have now been cleared up.
I wonder if we can resolve at least a portion of this issue by updating to that library.

serde_qs would be neat for query(), but it would not work for param() as they have different encoding rules.  Importantly, + should be decoded to space in query(), but should be left alone for param().

Uh what, how did me commenting that unassign him?

Is there a recommendation in the mean time for how to easily percent-decode parameters when fetching from Tide?


Lint + UI5 Component-preload

Coverage remained the same at 97.917% when pulling 50ff5f4e378047bd0389bfc5d18ac434f8e596c6 on develop into fcd60c11cd7ac77975ca3ac950814d3732b3e7bc on master.


Cube projections on 2d do not work for comparisons

To reproduce:

search for e.g. https://mpds.io/#plot/cube/inquiry/props=enthalpy of formation&classes=peer-reviewed
search for e.g. https://mpds.io/#plot/cube/inquiry/props=enthalpy of formation&classes=machine-learning

use comparison and try to project onto 2d.

In general, color-decoded numerical values in different datasets are impossible to compare.


1.10: keeps pushing same image

When running 1.10 I keep pushing the same images over and over again.  If I do docker push multiple times it doesn't seem to say "Layer already exists" for what I just pushed.

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Are you pushing to a v1 registry or v2 registry?
I'm not seeing these repeated pushes with either protocol version:
v2:
root@e61481334bc9:/go/src/github.com/docker/docker# docker push registry:5000/alpine
The push refers to a repository [registry:5000/alpine]
6b00b82071ac: Pushed
latest: digest: sha256:6371e0134ff330629c625f28d34b6357c99cc4c1c6ea1061b9375f7ff2f43706 size: 1352
root@e61481334bc9:/go/src/github.com/docker/docker# docker push registry:5000/alpine
The push refers to a repository [registry:5000/alpine]
6b00b82071ac: Layer already exists
latest: digest: sha256:6371e0134ff330629c625f28d34b6357c99cc4c1c6ea1061b9375f7ff2f43706 size: 1352

v1:
root@e61481334bc9:/go/src/github.com/docker/docker# docker push registry:5000/alpine
The push refers to a repository [registry:5000/alpine]
Sending image list
Pushing repository registry:5000/alpine
2b6968525989: Image successfully pushed
Pushing tag for rev [2b6968525989] on {http://registry:5000/v1/repositories/alpine/tags/latest}
root@e61481334bc9:/go/src/github.com/docker/docker# docker push registry:5000/alpine
The push refers to a repository [registry:5000/alpine]
Sending image list
Pushing repository registry:5000/alpine
Image 2b6968525989 already pushed, skipping
Pushing tag for rev [2b6968525989] on {http://registry:5000/v1/repositories/alpine/tags/latest}

This is interesting... So if I push the same images I was pushing before, it now says layer already exists.  What I was doing was pushing a series of images that were all based on the same common image.  As you can see below the 191273970f44: layer is in most of the images but each push would push it again.
v0.4.3-dev: digest: sha256:9988e24a06a194e7cee9beec070c01729b614de0f73a80d7ffbfec08bc1f62f3 size: 1372
The push refers to a repository [docker.io/rancher/os-base]
5f70bf18a086: Layer already exists
52a9cf3f11a8: Pushed
4d7890e8b3bf: Pushed
4e0a630d2bbc: Pushed
f42a904f1fd3: Pushed
191273970f44: Pushed
v0.4.3-dev: digest: sha256:65c892a5a43fa65a610266d5db0fd1d61adb6c74793a1e7bacc48fee3cd125ba size: 5151
The push refers to a repository [docker.io/rancher/os-acpid]
5f70bf18a086: Layer already exists
52a9cf3f11a8: Pushed
4d7890e8b3bf: Pushed
4e0a630d2bbc: Pushed
f42a904f1fd3: Pushed
191273970f44: Pushed
v0.4.3-dev: digest: sha256:86d3c446b9cd4f2a12d17b3cf18b42d665ffc9716759ba302f4882bea229b44d size: 5654
The push refers to a repository [docker.io/rancher/os-autoformat]
5f70bf18a086: Layer already exists
b5a18c111367: Pushed
6d0a6b94807d: Pushed
52a9cf3f11a8: Pushed
4d7890e8b3bf: Pushed
4e0a630d2bbc: Pushed
f42a904f1fd3: Pushed
191273970f44: Pushed
v0.4.3-dev: digest: sha256:c83f1d1be9c50c380ef261405f2120899fb9a2549e9f003ef32bc74e98611e47 size: 6666
The push refers to a repository [docker.io/rancher/os-cloudinit]
5f70bf18a086: Layer already exists
d143fff25776: Pushed
52a9cf3f11a8: Pushed
4d7890e8b3bf: Pushed
4e0a630d2bbc: Pushed
f42a904f1fd3: Pushed
191273970f44: Pushed
v0.4.3-dev: digest: sha256:c2f456a131cf8df6a30b4731d9a09d276261df58919115aad0261828b394e204 size: 6136
The push refers to a repository [docker.io/rancher/os-console]
5f70bf18a086: Layer already exists
6617e06170e4: Pushed
576a7382fe08: Pushed
7ad6b6b5a1a0: Pushed
52a9cf3f11a8: Pushed
4d7890e8b3bf: Pushed
4e0a630d2bbc: Pushed
f42a904f1fd3: Pushed
191273970f44: Pushed
v0.4.3-dev: digest: sha256:af28be0a926eeec2e9aa4edb051555d25064aef4c2eeba3c388d24ef45b4009c size: 7697
The push refers to a repository [docker.io/rancher/os-docker]
5f70bf18a086: Layer already exists
52a9cf3f11a8: Pushed
4d7890e8b3bf: Pushed
4e0a630d2bbc: Pushed
f42a904f1fd3: Pushed
191273970f44: Pushed
v0.4.3-dev: digest: sha256:bd9442e705d53dce71339ef2094fe5db06cad9587f23cce386384c50dea14da9 size: 5647
The push refers to a repository [docker.io/rancher/os-headers]
5f70bf18a086: Layer already exists
41a628dae1f0: Pushed
52a9cf3f11a8: Pushed
4d7890e8b3bf: Pushed
4e0a630d2bbc: Pushed
f42a904f1fd3: Pushed
191273970f44: Pushed
v0.4.3-dev: digest: sha256:26977edb654d8abdf865b29703d6c153e7de94dd535b35ff11b344c4d23c0098 size: 6127
The push refers to a repository [docker.io/rancher/os-network]
5f70bf18a086: Layer already exists
52a9cf3f11a8: Pushed
4d7890e8b3bf: Pushed
4e0a630d2bbc: Pushed
f42a904f1fd3: Pushed
191273970f44: Pushed

This looks like the classic cross-repository push issue. Currently, the registry doesn't know which other repositories a client has permission to access, so it only allows layers to be shared within a specific repository (such as rancher/os-base). The first time those layers are pushed to a different repository, they need to be re-pushed to prove to the registry that the client has access to them. (Note that the layers end up duplicated on disk even though they are pushed multiple times).
The good news is that there's active work underway to seamlessly share layers between different repositories. The first step is this registry-side PR: https://github.com/docker/distribution/pull/1269. @BrianBland also has some code for the engine that will make use of this to push a layer from a second repository where it already exists.

This item is already covered by #14018 in the roadmap. Closing this as a duplicate.

(Note that the layers end up duplicated on disk even though they are pushed multiple times).

"Don't" end up duplicated on disk perhaps?

"Don't" end up duplicated on disk perhaps?

Yes, thanks for the correction.

Cool. Yeah, we hit this bug regularly, so just want to make sure we're not blowing out our cloud storage bucket with a zillion copies of our debian base image.

Same here, I pushed my image and then pulled the same image and then when I pushed the same image it started uploading, instead of saying Already exists, please fix this issue.

@blackadmin what version of the registry are you using? This feature was implemented in docker 1.10, but requires registry 2.3.0 (also see https://github.com/docker/distribution/issues/1501)

@thaJeztah Sorry, but how to check registry version ? :)

@blackadmin are you running your own private registry, or Docker Hub? Docker Hub does not yet run  registry 2.3 (You can try sending an email to<EMAIL_ADDRESS>to check if there's a date known for 2.3 to be rolled out)

@thaJeztah Me on Docker Hub, ok got it.
Thank you very much :)


Add version: CoreyButler.NVMforWindows version 1.0.1

Pull request has been created with Komac v1.9.1 :rocket:
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/115389&drop=dogfoodAlpha

@wingetbot waivers Add Validation-Executable-Error


Built-in support for custom lookup class

I tried to monkey-patch Geocoder since the service I'm using is not officially supported, but I do have to override a bunch of public/private classes for the purpose.
The main issues here I see are:

Hard-coded list of support services, I can totally override the list, but there should be a more convenient way to do so. Is it possible to dynamically load all needed classes? Or is there any significant benefit for only requiring a class for spawn? We can obtain a list of all services configured and require all of them right?

Hard-coded support for only JSON format, again, I can override it, but XML response is also very common, can it be an official option? It can be a part of the configuration, even better, make it available for service-specific configuration.

Hi
We don't support monkey-patching well. This is mostly because we are very
open to everyone adding support for specific services directly to geocoder
gem. This is part of the reason why "there is significant benefit for only
requiring a class for spawn". Since we don't want geocoder to be heavy if
you're only going to use a specific service.

Though having a way to dynamically require a class during execution may
be a good idea. I'm not sure what the use cases of this are. Maybe the best
implementation of this is when Geocoder.configure() is called to ensure the
lookup is require/loaded.

Adding XML response handling is a good feature to have. I recommend that
the configuration options be within the lookup file itself.

Thanks,
Thu
On Mon, Oct 10, 2016 at 12:12 PM, Junhui Chen<EMAIL_ADDRESS>wrote:

I tried to monkey-patch Geocoder since the service I'm using is not
officially supported, but I do have to override a bunch of public/private
classes for the purpose.
The main issues here I see are:

Hard-coded list of support services, I can totally override the list,
but there should be a more convenient way to do so. Is it possible to
dynamically all needed classes? Or is there any significant benefit for
only requiring a class for spawn? We can obtain a list of all services
configured and require all of them right?
2.
Hard-coded support for only JSON format, again, I can override it, but
XML response is also very common, can it be an official option, it can be a
part of the configuration, even better, make it available for
service-specific configuration.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/alexreisner/geocoder/issues/1106, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBOwep8nnakali6JhrnOjpUS2NNZd02ks5qymQCgaJpZM4KSvHn
.


issue: possible feature list in error

D.today() + 0 # this cause error

TypeError: unsupported operand type(s) for +: 'BeautifulDate' and 'int'

This can just return the same value, which makes it more dynamic
because I was using a variable in adding date D.today() + inputFromUser*days which can be zero
although I can check It before, but it will be better if beautiful-date do this 😌😄😁

Even if inputFromUser is 0, inputFromUser * days will not be 0, it will be a zero-timedelta. So D.today() + inputFromUser*days will work as expected. And D.today() + 0 should cause an error because it does not make sense adding integer to a date.

Even if inputFromUser is 0, inputFromUser * days will not be 0, it will be a zero-timedelta. So D.today() + inputFromUser*days will work as expected:
>>> D.today() + 0*days
BeautifulDate(2021, 8, 29)

And D.today() + 0 should cause an error because it does not make sense adding integer to a date.

ok Thank you, that was a nice description  🙂

Just speculating, but check if you don't override days with some integer. That could cause inputFromUser * days to end up being 0


[sw] Make Rust a mandatory dependency

Right now Rust is an optional dependency. Build targets that depend on Rust are simply skipped if it is not installed. This then leads to test failures since Rust is required to build signed binaries. This is a bad user experience and leads to wasted time investigating the failures. The project is only going to depend on Rust more over time so we should just make it a mandatory dependency.

This is the case now with Bazel. Closing as Done.


Split learning update

Description

How has this been tested?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue) Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

The run will lead to an error when client #2 arrives before client #1:
[Server #11782] Starting round 1/6.
[ERROR][15:23:12]: Task exception was never retrieved
future: <Task finished name='Task-40' coro=<AsyncServer._handle_event_internal() done, defined at /usr/local/miniconda/envs/federated/lib/python3.8/site-packages/socketio/asyncio_server.py:502> exception=KeyError(1)>
Traceback (most recent call last):
File "/usr/local/miniconda/envs/federated/lib/python3.8/site-packages/socketio/asyncio_server.py", line 504, in _handle_event_internal
r = await server._trigger_event(data[0], namespace, sid, *data[1:])
File "/usr/local/miniconda/envs/federated/lib/python3.8/site-packages/socketio/asyncio_server.py", line 540, in _trigger_event
return await self.namespace_handlers[namespace].trigger_event(
File "/usr/local/miniconda/envs/federated/lib/python3.8/site-packages/socketio/asyncio_namespace.py", line 37, in trigger_event
ret = await handler(*args)
File "/usr/local/miniconda/envs/federated/lib/python3.8/site-packages/plato/servers/base.py", line 38, in on_client_alive
await self.plato_server.register_client(sid, data['id'])
File "/usr/local/miniconda/envs/federated/lib/python3.8/site-packages/plato/servers/base.py", line 133, in register_client
await self.select_clients()
File "/usr/local/miniconda/envs/federated/lib/python3.8/site-packages/plato/servers/base.py", line 206, in select_clients
sid = self.clients[client_id]['sid']
KeyError: 1
[INFO][15:23:12]: [Server #11782] New client with id #1 arrived.
[INFO][15:23:12]: [Server #11782] New client with id #3 arrived.

Lots of unused variables in split_learning_algorithm.py. For example, in line 108-128, I suggest removing unused variables by changing to:
    tic = time.perf_counter()

    # Initializing the optimizer
    get_optimizer = getattr(self, "get_optimizer",
                            optimizers.get_optimizer)
    optimizer = get_optimizer(self.model)

    grad_index = 0

    for __, (examples, __) in enumerate(data_loader):
        optimizer.zero_grad()
        outputs = self.model.forward_to(examples, cut_layer)
        outputs.backward(self.gradients_list[grad_index])
        grad_index = grad_index + 1
        optimizer.step()

    toc = time.perf_counter()

    logging.info("[Client #%d] Training completed.", self.client_id)
    logging.info("[Client #{}] Time used: {:.2f} seconds.".format(
        self.client_id, toc - tic))

Lots of commented out code in split_learning_server.py. These need to be cleaned up.

The bugs have been fixed, please oblige me with your valuable comments!

I have pushed some minor code cleanup. However, the client doesn't start with the current version correctly. The server simply waits for the client forever. Please test again.

Got it, I will check it as soon. Thanks a lot!


Add Window manager

:sweat_smile: Initial attempt at a window manager and layout modules, With Dock as first split. @bryphe would be good to get your feedback early since I imagine/am guessing you would have had an idea of how you wanted to approach this?

Outstanding (easier to say what isn't :laughing:)

[x] Separator
[ ] Use window size to calculate proportions for splits
... tbd

@bryphe would be good to get your feedback early since I imagine/am guessing you would have had an idea of how you wanted to approach this?

Sure! Thanks for checking in. I'm glad to see work starting on this, I miss window splits in Onivim 2!

Horizontal Splits:


Mol images in DataFrames are drawn only once in Jupyter Lab

Describe the bug
With the latest RDKit version 2021.09.4, the images of molecules in DataFrames are only drawn on the first display when using Jupyter Lab. On subsequent display attempts, the images are no longer drawn.
I have tested it with Pandas versions 1.4.1, 1.4.0, 1.3.5, 1.2.5 and 1.1.5 and the same problem occurs with all of them.
The error does not occur with RDKit version 2021.09.2 in combination with Pandas 1.4.1 or 1.1.5, the DataFrames are all displayed correctly here.
With RDKit version 2021.09.3, the already fixed error mentioned in ticket #4864 occurs with Pandas 1.4.1 as well as 1.1.5.
If you look specifically at the Jupyter notebook attached below in a text editor, you will see that on the first call, the molecule image is given as <img data-content=\"rdkit ..., while on the second call, the entry looks like <img data-content=\"rdkit ....
To Reproduce
Basically, all that needs to be done in a Jupyter notebook is to create any DataFrame with RDKit mol objects and then display it with e.g. df.head(). If the same cell is executed again, the molecules are no longer drawn.
This is an example notebook: 1.4.1_2021.09.4_bug.ipynb.txt
Expected behavior
The molecule images should be shown correctly in every call.
Screenshots
How it looks like:

How it should look:

Configuration (please complete the following information):

RDKit version: 2021.09.4
OS: Windows 10 and Ubuntu 18.04
Python version (if relevant): 3.9.10
Are you using conda? Yes
If you are using conda, which channel did you install the rdkit from? conda-forge

@mrcblt I can reproduce the problem and will look into fixing it.
Meanwhile, you can visualize the DataFrame as follows:
from rdkit import Chem
from IPython.display import HTML
from rdkit.Chem import PandasTools
import pandas as pd

def show_df(df):
    return HTML(df.to_html(notebook=True))

df = pd.DataFrame(dict(a=[1], s=['CCN']))
PandasTools.AddMoleculeColumnToFrame(df, smilesCol='s', molCol='m')

show_df(df)

show_df(df)


all: updates from upgrading paygate and localdev testing

account validation failed from amount model change

extra code wasn't deleted from the original change

missing X-Organization on some service->service requests
improper use of old userID value

Codecov Report

Merging #263 into master will decrease coverage by 0.15%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   61.46%   61.31%   -0.16%
==========================================
  Files          51       50       -1
  Lines        2943     2921      -22
==========================================
- Hits         1809     1791      -18
+ Misses        816      814       -2
+ Partials      318      316       -2


Disable vercel telemetry

Context: https://github.com/scaffold-eth/se-2-challenges/pull/245#pullrequestreview-2503416298
I think we need to disable telemetry by default, because

vercel cli asks to do additional actions to approve telemetry before deploy
I am not sure people want to vercel to collect their data

Vercel telemetry docs

Thankss! Yeah I think it's fine and makes sense to diable it 🙌


Implement controller and translator for KongVault

What this PR does / why we need it:

Implement the controller and the translator of KongVault to generate and configuration of custom vaults.
Which issue this PR fixes:

Major part of #5333.
Special notes for your reviewer:

Although the controller is not fully completed yet, to avoid the PR being too large to review, please review it and do not require a significant change on this PR.
Remaining parts:

https://github.com/Kong/kubernetes-ingress-controller/issues/5395 Validate the uniqueness of prefix
https://github.com/Kong/kubernetes-ingress-controller/issues/5387 Generate events for translation errors
Add integration tests for webhooks

PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

For posterity, since this is called out as incomplete, what are the specific remaining tasks? We should always try to mention those since reviewers won't inherently have that context, and can't accurately gauge whether a partial implementation will be compatible with the assumed future next steps.

Updated the comments on the PR and listed the follow up things after this PR.


⚠ Samsung has degraded performance

In 0ebab09, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2856 ms

Resolved: Samsung performance has improved in 85f0a57.


Add row errors page for admin site import interactions tool

Description of change
This adds the display of row-level validation errors to the admin site import interactions tool.
A maximum of 50 errors are displayed.
Files are stored in Redis between requests. Redis was chosen for simplicity, and as the files involved are relatively small.
Screenshot

To test

Create the admin-interaction-csv-importer feature flag and set it as active
Create a valid or invalid CSV file according to the spec on the page
Navigate to the interaction change list page in the admin site
Click on the 'Import interaction' link
Select your CSV file
Submit the form
If the file is valid, you should be redirected to the change list page. Otherwise, a list of errors should be displayed.

Example of a valid CSV file (replacing <an adviser name> with the name of an adviser):
kind,date,adviser_1,contact_email,service
interaction,01/01/2018,<an adviser name>,person@company.com,Account Management

Example of an invalid CSV file:
kind,date,adviser_1,contact_email,service
invalid,invalid,invalid,invalid,invalid
invalid,invalid,invalid,invalid,invalid

Checklist

[x] Has a new newsfragment been created? Check changelog/README.rst for instructions
[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

@marcofucci The integration with the serialiser validation rules will come later (as that requires the contact matching logic).


update: fiber version

Bumped the version of fibre as this is a minor version bump nothing seems to be refactored.

Solves https://github.com/getsentry/sentry-go/issues/868

Integration dependencies: If a security issue is discovered in one of our integration dependencies (for example, gin, echo, or negroni), it is the responsibility of the end user to make sure that those modules are updated in a timely manner in their applications.

https://github.com/getsentry/sentry-go/security/policy


push version 1.4.1 to CocoaPods

Hi, could you push 1.4.1 to CocoaPods ?
I can not find 1.4.1 directly via "pod search"

Oops, done!


[6/N] Use the drawLine, drawLines and drawJoinedLines functions from drawing.js

This PR replaces calls to path, moveTo and lineTo with calls to drawLine, drawLines, and drawJoinedLines from the drawing.js API.
See #405 for full discussion.

Coverage increased (+0.02%) to 6.016% when pulling 30aec135f9865da4ac356285366c4fccfa32fff6 on timleslie:drawing-js-6 into e00153bbe06585359b23374f1db512a26f87676f on cornerstonejs:master.

Just tested the tools involved and everything seems fine. Thanks!


Require that popFront and popBack be callable without parens.

Technically, prior to this change, it was possible to define popFront
and popBack to be callables that required parens - such as member
variable with an overloaded opCall or a delegate. It's unlikely that
anyone has actually declared popFront or popBack in this manner, but
it's possible. Because of that, calling popFront or popBack without
parens would technically not work with some valid ranges (even if such
ranges are unlikely to exist) and thus without this change, it's
arguably not valid to call popFront or popBack without parens in generic
code - especially in the standard library.
Andrei wants to be able to call popFront without parens in generic code,
and when I pointed out the existing problem with that, he wanted me to
change it so that it's no longer legal to have a range where popFront or
popBack is a callable that requires parens. So, this PR fixes that.
Now, technically, this is a breaking change, but it's highly unlikely
that it actually breaks any code, and I don't know of any way to do this
change in a way which would allow for any kind of deprecation message
for anyone trying to declare a range with a popFront or popBack that
would not work without parens. So, as far as I can tell, if we want to
make this change, we're stuck making a breaking change, but the odds of
it actually mattering seem low.

Is accessing a member variable without using it an error even without warnings enabled?

Yes, otherwise I was going to add a check for popFront and popBack needing to actually be functions, but it wasn't necessary.

What's the reasoning behind being able to call popFront without parens?

So we don't require unit tests for fixes anymore?

@jmdavis why can't you check both the old and the new behavior to avoid making breaking change immediately?

@jmdavis why can't you check both the old and the new behavior to avoid making it a breaking change immediately?

And how would I do that? If it we were dealing with a symbol such as a function or variable, it could be deprecated, but we're dealing with an eponymous template that's used to test that a particular piece of code compiles with the given type. Either something compiles with it, or it doesn't. There's nothing to attach a deprecation message to. And testing that either the old version compiles or the new version compiles doesn't do anything except keep the old behavior. I don't know of any way to change an eponymous template used as a trait such that it tests for something different without breaking any code that relied on the previous behavior. It's like changing the behavior of a function in-place rather than deprecating it and replacing it. It has one behavior, and then it has the other. You can warn folks ahead of time that the behavior is going to change, but it's still the case that at some point, you just have to flip the switch, and code that did one thing will now do another. In this case, it worked with callables other than functions before, and now it doesn't. I don't see any way to have a transition period unless we renamed isInputRange (which we're obviously not going to do).
Personally, I don't like calling popFront or any other void function without parens, but clearly some folks want to do it, and Andrei insisted on it being possible with popFront and wanted me to make the change, so I did. I'd be fine with it being decided that we undo this change and require that popFront be called with parens, but I don't see any way to make it cleaner.
Unfortunately, we'll run into exactly the same sort of problem if we ever manage to do something like make isRandomAccessRange and hasSlicing require that $ work with the range (which would be an utter disaster without https://issues.dlang.org/show_bug.cgi?id=7177 being implemented but would theoretically be quite manageable with 7177 being implemented; it would still break code though). So, a solution to this sort of problem would be nice, but I don't see one. Obviously, I could be missing something though.

Wow, that's a lot of text 😃. I was thinking of just duplicating the the whole check, like this:
template isInputRange(R)
{
    enum bool isInputRange = is(typeof(
    (inout int = 0)
    {
        R r = R.init;     // can define a range object
        if (r.empty) {}   // can test for empty
        r.popFront;       // can invoke popFront
        auto h = r.front; // can get the front of the range
    })) ||
    is(typeof(
        (inout int = 0)
        {
            R r = R.init;     // can define a range object
            if (r.empty) {}   // can test for empty
            r.popFront();       // can invoke popFront()
            auto h = r.front; // can get the front of the range
        }
    ));
}

You cannot add a deprecation message but you can allow both behaviors simultaneously.

Wow, that's a lot of text :smiley:

I've never exactly been known for being concise. :)

I was thinking of just duplicating the the whole check, like this:

What you're suggesting is semantically equivalent to not making any change to isInputRange at all. The problem is that if isInputRange requires that popFront be callable with parens, then all generic code needs to call it with parens; otherwise, there are potentially ranges which will pass isInputRange but not work with that code simply because of the lack of parens. If isInputRange requires that popFront be callable without parens, then no ranges which would declare popFront to be any sort of callable other than a function would actually be considered ranges, and since isInputRange doesn't allow popFront to be a variable, you can then call popFront with our without parens in generic code, and the code works either way. This change goes from the first behavior to the second, whereas what you're suggesting just leaves us at the first, without providing any kind of transition to the second.
There is no way to both allow ranges to define popFront to be a callable that requires parens and to allow generic code that should work on any range to then call popFront without parens.

What you're suggesting is semantically equivalent to not making any change to isInputRange at all.

Ah, right, my bad.

We're good here. Your point about due process is valid, however there is a line between avoiding gratuitous breakage and adding too much engineering for the sake of bureaucracy. In this case we'd break folks who did not follow the documentation (which requires popFront to be a method) and went with nonstandard code that defines popFront as a member of a type that in turn defines opCall.