Add option to set number of retries when no response

Related to addressing https://github.com/stephenplusplus/gcp-metadata/issues/10

PTAL

ping @stephenplusplus

Hey all, please take a look at my quick adjustments.

@stephenplusplus your changes lgtm, thanks!

Published 3.1.0

Thanks @nolanmar511!


[SPARK-38251][SQL] Change Cast.toString as "cast" instead of "ansi_cast" under ANSI mode

What changes were proposed in this pull request?

Change Cast.toString as "cast" instead of "ansi_cast" under ANSI mode.
This is to restore the behavior before https://github.com/apache/spark/pull/27608
Why are the changes needed?

There is no such a function "ansi_cast" in Spark SQL
Add/Divide/.. has different behavior under ANSI mode as well, but they don't have this special string representation.
As we are setting up new Github job for ANSI mode, this can avoid test failures from TPCDS plan stability test suites

Does this PR introduce any user-facing change?

Yes but quite minor, the string output of Cast under ANSI mode becomes "cast" instead of "ansi_cast" again.
How was this patch tested?

Existing UT

Merging to master


Shortcut for sftp.upload.file show me error on Vscode v1.25.1

My shortcut config:
{
        "key": "ctrl+cmd+u ctrl+cmd+u",
        "command": "sftp.upload.folder",
        "when": "editorTextFocus"
}

When I press shortcut with focus in file, the vscode show me an error:  Cannot read property 'resource' of undefined.
I guess the vscode didn't find the upload file in the action. So, how should I do?

With v1.7.0:
{
        "key": "ctrl+cmd+u ctrl+cmd+u",
        "command": "sftp.download.activeFolder",
        "when": "editorTextFocus"
}


Move "mesheryapp.dockerapp" folder under "install" folder

Description
A small chore is needed to be done in order to consolidate top-level folders. docker app package can be moved under the install folder.
Implementation

Move folder/files.
The Meshery Docker App deployment instructions will need to be updated with this new location.

@chandresh-pancholi Would you like to take this one?

@leecalcote sir, but there is no instructions for Meshery Docker App deployment.

@leecalcote I will look at it.

nope, I will write them in the coming days 😅

Done. ✔


What else?

This documentation is vague at best. Where are the downloaded files stored from then on? How are they deployed to the ADFS server or any server for that matter, given that they are not just html files, but something that runs. I'm guessing an Apache web server won't do it, and, IIS is not running on ADFS servers so where are the files put and how is a server instructed to run them. Furthermore, there's no "Compile" option or menu or whatever in Visual Studio which you just assume we all know how to use. We wouldn't be reading [rather poor] documentation if that were the case.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 473bc6ea-017f-52f3-7e58-81ecf58d2db8
Version Independent ID: 20965612-d6a9-35ea-c030-91c09372962e
Content: Build a web application using OpenID Connect with AD FS 2016
Content Source: WindowsServerDocs/identity/ad-fs/development/enabling-openId-connect-with-ad-fs.md
Product: windows-server-threshold
GitHub Login: @billmath
Microsoft Alias: billmath

#please-close

#assign:IngridAtMicrosoft


Don't force CSS styles

As the selector is embedded into a shadow root, you can't style any element from the outside. You do set some properties however which might not fit the general design of the parent site, most notably font-weight and font-size:
https://github.com/maxshuty/accessible-web-components/blob/master/src/components/simpleRange.js#L53
https://github.com/maxshuty/accessible-web-components/blob/master/src/components/simpleRange.js#L109
Would it be possible to either remove them or make them configurable via a CSS variable?
Other than the above mentioned, these might be interesting as well:

https://github.com/maxshuty/accessible-web-components/blob/master/src/components/simpleRange.js#L62 (needs appearance: none;)
https://github.com/maxshuty/accessible-web-components/blob/master/src/components/simpleRange.js#L75-L76
https://github.com/maxshuty/accessible-web-components/blob/master/src/components/simpleRange.js#L79 (border-width)
https://github.com/maxshuty/accessible-web-components/blob/master/src/components/simpleRange.js#L99 (dito)
https://github.com/maxshuty/accessible-web-components/blob/master/src/components/simpleRange.js#L104 (dito)
https://github.com/maxshuty/accessible-web-components/blob/master/src/components/simpleRange.js#L108 (should be auto)

@dgsiegel first off, apologies for the delayed reply. My notification settings were not set correctly on this repo.
I appreciate the input and I will make those customizable in the next release, I will try and get that out in the next few days.
Additionally I may consider adding CSS ::part and ::theme (if ::theme becomes a thing).


Pyyaml5.1

Description:
Update pyyaml to version 5.1.
Fixes CVE-2017-18342
Fixes #23195
Motivation for upgrade: Compatibility with Arch ecosystem:
https://aur.archlinux.org/packages/home-assistant/#pinned-696468
Checklist:

[x] The code change is tested and works locally. (NOTE: no functional change, only libs)
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io (NOTE: No functional change)

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works. (NOTE: No functional change)

Hi @BackSlasher,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

script/setup && script/test pass locally, waiting for server testing

Putting up for review

You should get some warnings in tests. Are you sure that you fixed them as I can not see it in your PR? Anyway, it's good to use cherry-pick. ;-) I will look at it as I had vacation a few days back and then it was I forget about the PR. You can see that I force-push it after my PR was closed.

Didn't get you @BKPepe - did you end up pushing your commit?
I'm mainly interested in actual PyYAML version requirement (because of Arch)

It can not be merged until tests are fixed, which was said in my PR.

Are we referring to these?
https://circleci.com/gh/home-assistant/home-assistant/34831?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Exactly. Didn't you get them locally?

I did, but they seemed like noise.
I see that there are other callsites, but I agree that we should handle them in a different PR. Will fix the test ones.

Hm. Are you sure that you fixed everything? What about:
tests/components/kira/test_init.py::TestKiraSetup::test_kira_empty_config
tests/components/kira/test_init.py::TestKiraSetup::test_kira_setup
tests/components/kira/test_init.py::TestKiraSetup::test_load_codes
  /home/circleci/repo/homeassistant/components/kira/__init__.py:63: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
    data = yaml.load(code_file) or []

Fix ( Hm, I'm not able to re-open my previous PR. ) : https://github.com/BKPepe/home-assistant/blob/63c5e930fbffdb6f47248885ffec86155b0badff/homeassistant/components/kira/init.py
Before pushing any commits, it's good to test it locally.

:( I wish I could move the PR back to draft so I can server-test without triggering everyone. Server-side testing is a lot faster than mine

made sure testing no longer contains warning on yaml loads.

Removed the include dir from .gitignore
This dir was created because I put the virtualenv inside the homeassistent git repo, which is the procedure I was used to (I am a bit rusty)

Thanks, looks good!

@balloob  @OttoWinter  as the adults, should we have a followup task to convert all of the loads to safe_load? I'm unsure what's happening with the different YAML libs, and whether the expected behavior is safe load (or we want to allow users to have executable code in their config)

@BackSlasher Can you show what instances of that you mean? At least the core configuration loader uses SafeLineLoader, so it's not affected by the CVE.

@OttoWinter I can't figure out where elsewhere the PyYAML lib is being used (I suspect both are imported using import yaml so it's hard for me to follow), but if we're using it somewhere else, we should make sure we're not calling load without anything.
It's possible that this is a no-op and I just don't know it


Add 404 and 500 page #446

I found https://github.com/denoland/fresh/issues/446 under 'good first issue', the initial pull request was left behind.

@hashrock done

the 500 page displays the exact same component with different text

@michael-pfister Thanks for your cooperative effort!
And thanks @UmbrellaCrow612 to prior PR!


Test/e2e resources section component 314m470

@cedricguillas Please check on:

src/popup/pages/app-container/home/resources-section/resources-section.component.tsx

As I have changed the condition on the file from
if (       activeAccount?.account?.voting_manabar?.current_mana !== undefined &&       activeAccount.rc?.percentage     ) {
To:
if (       activeAccount?.account?.voting_manabar?.current_mana !== undefined &&       activeAccount.rc?.percentage !== undefined     ) {
Because it was needed for the tests and seems to be lacking that.

@theghost1980 seems like you have conflicts. Please fix them before i can merge


Update to SC 5.2.2

Updates to SC client 5.2.2
Uses the new download endpoint to check versions

@alexh-sauce it seems downloads still do not work, please find details in #306


Term 3 Simulator Sources

The sources of this repository don't seem to relate to the term 3 release (even the corresponding tags don't). Could somebody commit and push those sources and/or explain why this hasn't been done so far?

Yeah, could you please update the source code? I somehow managed to compile your term3 source code, but it turns out that the code is term 1 simulator source code

Where do I find the term 3 sources (the highway scene)?

Hi! Have you found the source code?

Please use the Term 3 branch.


Use Internal.AspNetCore.Sdk as an MSBuild SDK

should resolve issues with occasional strange MSBuild caching issues in this repo
modeled after aspnet/Scaffolding#905
follows aspnet/BuildTools#729 recommendation to check in global.config file

see also Microsoft/msbuild#2914

@natemcmaster @pranavkm @ryanbrandenburg I doubt all of you need to review this (most of it is boilerplate). Feel free to choose a single victim reviewer between you.

5bddd226a3


Added code from bridge repo

The script and predicate code come from the POC found in the bridge repo. There will be future issues to update the POC into the final predicate and script for any message being sent to a contract

So this is just the code from the POC, but there is also the draft of the actual predicate / script /gateway abi that we should migrate over

So this is just the code from the POC, but there is also the draft of the actual predicate / script /gateway abi that we should migrate over

This repo is actually slightly different than the work we've got so far in the bridge repo. I think we should make this predicate a little more generic for many other projects to utilize. Basically make it a predicate for any project that needs a message sent to a contract. This would involve not being as strict on the outputs and making sure that the message value gets transmitted to the contract as well.
There will be a future issue to implement all this after the SDKs get updated and will include references to the previous work on the current bridge repo.


Payment sheet only displays "United States" in the "Country or Region" dropdown

Describe the bug
The "Country or region" section only displays "United States" and "United States Minor Outlying Islands"
To Reproduce
...
const { paymentIntent, ephemeralKey, customer } = await fetchPaymentSheetParams();

const { error, paymentOption } = await initPaymentSheet({
    customerId: customer,
    customerEphemeralKeySecret: ephemeralKey,
    paymentIntentClientSecret: paymentIntent,
    customFlow: true,
    testEnv: true,
});

...

const { error, paymentOption } = await presentPaymentSheet({
   confirmPayment: false,
});

Expected behavior
Provide the list of available countries to select.
Screenshots

Additional context
Was built using Expo following the example here.

Hm, I'm not able to reproduce. What versions are you using?

I just updated the module on my project to the latest version and I'm still getting the issue.
I'm also getting an ephemeral with the apiVersion at '2020-08-27' as observed in the example.
Does it have to do with any configuration I have set up in the stripe dashboard? The bank account I'm currently using is linked to a US account, might that be the issue?

@elco45 are you still having this issue? Have you checked if it occurs also on real device or only simulator?

Hello, @arekkubaczkowski I'm still having the same issue and it happens in both real devices and simulators. I'm still unsure of the reason...

Hey @elco45
This one is pretty weird. We use Locale.getISOCountries() to generate our list of countries, so I don't think it's an issue with your dashboard but rather your setup. It's curious that you see United States twice as well.
Would it be possible to build either the react example or the native android example with a fresh stripe account and fresh repository? You can keep it in test mode and not activate it. I'm wondering if something is not right with your java installation. I'm curious to see if the fresh build will have the full list of countries.

@elco45 have you had a chance to test this on the example app using a new Stripe account?


Run my-detection.py or detectnet.py with video instead of camera

Dusty,
I am looking through the code and I can see that there is an option to run video files through the detectnet and my-detection.
I am wondering if you can show me how it'd be done on the command line and also through changing the code for my-detection.

Using this code gave me the camera feed:
net = jetson.inference.detectNet("ssd-mobilenet-v2", threshold=0.5)
camera = jetson.utils.videoSource("/media/user/SD/videos/cardinals.mp4")      # '/dev/video0' for V4L2
display = jetson.utils.videoOutput("display://0") # 'my_video.mp4' for file

attempting to use detectnet.py
detectnet.py input_URI=file:///media/user/SD/jetson-inference/python/examples/indiana-birds.mp4

[video]  videoSource -- unsupported protocol (input_uri=file)
Traceback (most recent call last):
  File "/usr/local/bin/detectnet.py", line 54, in <module>
    input = jetson.utils.videoSource(opt.input_URI, argv=sys.argv)
Exception: jetson.utils -- failed to create videoSource device

even though input_URI appears to be an argument in detectnet.py
parser.add_argument("input_URI", type=str, default="", nargs='?', help="URI of the input stream")

Here's the page that talks about the different video I/O, including video files:  https://github.com/dusty-nv/jetson-inference/blob/master/docs/aux-streaming.md

From: DJT777 @.>
Sent: Sunday, April 25, 2021 12:13:53 AM
To: dusty-nv/jetson-inference @.>
Cc: Subscribed @.***>
Subject: Re: [dusty-nv/jetson-inference] Run my-detection.py or detectnet.py with video instead of camera (#1022)
attempting to use detectnet.py
detectnet.py input_URI=file:///media/user/SD/jetson-inference/python/examples/indiana-birds.mp4
[video]  videoSource -- unsupported protocol (input_uri=file)
Traceback (most recent call last):
File "/usr/local/bin/detectnet.py", line 54, in
input = jetson.utils.videoSource(opt.input_URI, argv=sys.argv)
Exception: jetson.utils -- failed to create videoSource device
even though input_URI appears to be an argument in detectnet.py
parser.add_argument("input_URI", type=str, default="", nargs='?', help="URI of the input stream")
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/dusty-nv/jetson-inference/issues/1022#issuecomment-826250471, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADVEGK5WGHNJH5T6RW545YTTKOJIDANCNFSM43QYUCCA.


Combinations

Before jumping into Pr first comment for assign.All Problem from Edabit. Link is mandatory to add
Problem statement: Create a function that takes a variable number of arguments, each argument representing the number of items in a group, and returns the number of permutations (combinations) of items that you could get by taking one item from each group.
Problem Link: https://edabit.com/challenge/G9QRtAGXb9Cu368Pw

Before submitting a PR please Check some details.Check Edabit for problem task

[ ] fileName formet should be in camelcase
example- returnTheNextNumber.py
[ ]  Add label for Problem
[ ]  In file there should be problem statement and link to probelm
example -

'''
    Probem Task : This program will add two numbers
    Problem Link : https://edabit.com/challenge/SFzHtm63XT6EYNHWY
'''
*/
def main():
    return a + b

This repository is vaild for HacktoberFest2020
Read before making PR - How to contribute on Github
Good Luck,

Can you assign this one to me, please?

[✓] Task Assigned

@tapish2000
Pull request for HacktoberFest will count from 1 october to 31 october

Yeah I will create a pull request on 1 October

please assign this to me. my code is written already


Optionally enable salt-minion

This PR adds support for running a salt-minion inside the container.
The service is disabled by default, but it can be enabled using the environment variable SALT_MINION_ENABLED=True.
Additionally, this PR renames the env variable SALT_API_SERVICE_ENABLED to SALT_API_ENABLED (for consistency with the new env variable). Backward compatibility will be provided until 3007.2.
More details will be provided as new commits are added...
Closes #237

Hi @abhi1693, could you build this branch and test it with your settings to make sure this development covers your requirements?


Consider using pre-commit.ci for style checking in CI

By using pre-commit.ci, we could eliminate the file related to the style CI configuration, e.g. .github/workflows/style.yml and substitute it with something that leverages the already present .pre-commit-config.yml and the configuration from the pyproject.toml.
This would allow us to add additional checks (see https://github.com/pre-commit/pre-commit-hooks), especially the check-added-large-files, which would prevent the user to commit the pixi.lock pulled from lfs, and the others checks already present in the pre-commit configuration.

Running the pre-commit check also on CI would be great! About the style checks (isort and black), I'd would just make sure about the following:

We can constrain the version of black as we currently do. In the past, new major releases (once per year, usually around January) introduced breaking changes. I prefer to bump manually the black pinning.
Right now the CI provides a nicely formatted diff in case there is a style mismatch. Before moving to ruff, let's be sure to get something comparable.

The formatting packages are already constrained in the .pre-commit-config.yml for both black:
https://github.com/ami-iit/jaxsim/blob/5b96fab839b84985030d78ca363a4d9c97e1d8d5/.pre-commit-config.yaml#L12
and isort:
https://github.com/ami-iit/jaxsim/blob/5b96fab839b84985030d78ca363a4d9c97e1d8d5/.pre-commit-config.yaml#L18
Do you prefer to have an error raised with the diff or just let the CI format the commited files?

Nope the pinning looks good. Can we match it with what specified in pyproject.toml? Considering the update policies, I guess that pinning the major versions would suffice.

The pre-commit configuration needs an exact tag or commit SHA. Can we stick with the current configuration since it matches:
# From pyproject.toml in #193
"black[jupyter] ~= 24.0"

?

Yes that sounds good, I thought it could handle less strict versioning.

FYI @giulero


Worker refactor and schedule on worker

What do these changes do?

Move operand ordering to worker (#4)
Refactor ExecutionActor in a more readable way
Add some doc translations
Simplify in-process tests
Improve coverage of ExecutionActor

Related issue number
Fixes #4

Replaced by #89 and a subsequent docs / test branch


One-shot Animated Tiles of the Same Type Maintain State

Godot version:
3.2.3.rc3.mono, though I doubt it's specific to the mono build
OS/device including version:
Windows 10, GLES3
Issue description:
I attempted to make an animated tile that looks like it's "falling" off the screen, similar to how tiles in Into the Breach fall when they are "destroyed". Once a single tile has fallen, if one-shot is on for the AnimatedTexture composing the tiles with that ID, the one-shot state will be maintained throughout all tiles of that type. The AnimatedTexture should be duplicated per tile which uses it.
Steps to reproduce:
Create an AnimatedTexture the old way and include it in a tileset. Make a tilemap which has multiples of the animated tile, and make sure it's a one-shot AnimatedTexture. Run it. Every tile will have the state once the first one which animates is completed - they will all complete and have the same state as well, for every tile which uses the same tile id. I have a nice repro project below.
Minimal reproduction project:
FallingIsometricTilesExperiment.zip
Work-around attempts
I attempted to work around this in multiple ways, one of which is included in the above. What I realized though is the AnimatedTexture is probably a unique resource that gets loaded once and is referenced in every tile from that point. So because one finishes, the rest maintain the same finished state. To that end, I tried using "make sub-resource unique" on just about everything I could get my grubby mitts on but couldn't get any of them to work. The final work-around for this is to not use the tilemap node directly to create falling tiles, but instead a separate node which does the falling; I'm okay with that, but thought the above should not be an unreasonable usecase.

What you can do here is create new tiles at runtime whilst duplicating the animated texture.
Replace your World.gd with the following:
extends Node2D

onready var tilemap = $TileMap

func _ready():
	var tiles = tilemap.get_used_cells()
	var tile_set = tilemap.get_tileset()
	var tile_id = len(tiles)
	for tile in tiles:
		tile_set.create_tile(tile_id)
		var duplicated_animated_texture = tile_set.tile_get_texture(0).duplicate()
		tile_set.tile_set_texture(tile_id, duplicated_animated_texture)
		tile_id += 1
		tilemap.set_cellv(tile, tile_id - 1)
		yield(get_tree().create_timer(1.0), "timeout")

It should work as expected.

That is...quite a work-around. Alright. I still think the above should be a valid usecase, but that said, I can close this if you want, as this work-around is pretty effective.

This is indeed a valid use case, however I'm closing this issue as it's not really a bug within the engine but rather a part of it's design.
If you would like us to follow up on this, please open a proposal at: https://github.com/godotengine/godot-proposals/


Fix typespec of Connection.cursor_to_offset/1

V1.4.3 introduced a breaking change in this function that used return an integer, that is not reflected in the documentation.

Thanks!


ci: cleanup unit test coverage

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
3984 unchanged lines in 300 files lost coverage.
Overall coverage decreased (-58.7%) to 20.696%

Files with Coverage Reduction
New Missed Lines
%

src/Tempest/Cache/src/Config/cache.config.php
1
0.0%

src/Tempest/Cache/src/IsCache.php
1
88.89%

src/Tempest/CommandBus/src/Config/commandBus.config.php
1
0.0%

src/Tempest/Auth/src/Config/auth.config.php
1
0.0%

src/Tempest/Console/src/Config/console.config.php
1
0.0%

src/Tempest/Console/src/Config/scheduler.config.php
1
0.0%

src/Tempest/Console/src/Exceptions/ConsoleException.php
1
0.0%

src/Tempest/Database/src/Builder/TableName.php
1
92.31%

src/Tempest/Debug/src/functions.php
1
0.0%

src/Tempest/Generation/src/SimplifiesClassNames.php
1
92.75%

Totals

Change from base Build<PHONE_NUMBER>1:
-58.7%

Covered Lines:
1153

Relevant Lines:
5571

💛  - Coveralls

@brendt - I know you'll hate this PR, BUT I believe it is important to really know where our unit coverage is. 😛

😂
It's just a number though. The only thing I'm interested in is being sure that when something is changed, will a test break somewhere telling me about it. I really don't care whether that's a unit or integration test.


v0.9.0

Two new top-level methods:

debugLog for modifying the behavior of an action caught when DEBUG is true
reset to reset a channel, or all channels

Hold up. Left comments in the respective PRs

Yup. Didn't plan to release tonight

We should move reset and debugLog to here: https://github.com/marionettejs/backbone.radio/blob/minor/src/backbone.radio.js#L126-L152

Closing this PR; will open a new one for the newer release. These other commits need work.


[Event Request] table 36 "Sales Header" - OnAfterCheckCreditLimit

Describe the request
Hello, can you please add a new Event OnAfterCheckCreditLimit in table 36 "Sales Header"?
    local procedure CheckCreditLimit()
    var
        SalesHeader2: Record "Sales Header";
        IsHandled: Boolean;
    begin
        SalesHeader2 := Rec;

        if GuiAllowed and
           (CurrFieldNo <> 0) and CheckCreditLimitCondition() and SalesHeader2.Find()
        then begin
            "Amount Including VAT" := 0;
            if "Document Type" = "Document Type"::Order then
                if BilltoCustomerNoChanged then begin
                    SalesLine.SetRange("Document Type", SalesLine."Document Type"::Order);
                    SalesLine.SetRange("Document No.", "No.");
                    SalesLine.CalcSums("Outstanding Amount", "Shipped Not Invoiced");
                    "Amount Including VAT" := SalesLine."Outstanding Amount" + SalesLine."Shipped Not Invoiced";
                end;

            IsHandled := false;
            OnBeforeCheckCreditLimit(Rec, IsHandled);
            if not IsHandled then
                CustCheckCreditLimit.SalesHeaderCheck(Rec);

            CalcFields("Amount Including VAT");
            OnAfterCheckCreditLimit(Rec);
        end;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnAfterCheckCreditLimit(var SalesHeader: Record "Sales Header")
    begin
    end;

Additional context
We have additional values to calculate the "Amount Including VAT" and need to recalculate it to prevent false values from being shown.
Internal work item: AB#547602

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 24072.


feat: add adaptative concurrency to rav requests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

63 of 64 (98.44%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 72.684%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tap-agent/src/agent/sender_account.rs
7
8
87.5%

Totals

Change from base Build<PHONE_NUMBER>6:
0.2%

Covered Lines:
5005

Relevant Lines:
6886

💛  - Coveralls


Modal app to merge to master

Statistics and Machine Learning Toolbox needs to be installed to use the APP
the present version of SimplusGT requires Symbolic math toolbox as well. So I added a installed toolbox check in Usermain.c. But it could be modified or commented out.
previous codes used for modal analysis are mostly not in use now but I intend to keep them to provide more flexibility. I will tidy them up someday.
Mode index selection in UserMain.c may no longer be necessary. I haven't deleted them though.

I disabled simulink model generation in the UserData Excel file but accidentally committed this change. This change can be rejected in the pull request

The GUI of app still has some bugs when using different screens.


(DO NOT MERGE) (RFC) Implement a C++ wrapper around the AIX ODM iteration API

This is a wrapper around the low-level querying and iteration of the AIX ODM API. Further wrappers could be built on top of this to wrap the concepts used in higher-level groups of class (for example, the {Predefined,Custom}{Device,Attribute} tables used in the configuration system)
This attempts to enforce the rules required by the ODM API itself, but unfortunately is not thread-safe, since std::mutex does not appear to be implemented for AIX in GCC 4.8
The examples directory is added just so I had a good place to dump an example of how this is intended to be used.

Travis does not like (rfc) in a commit message. Whatevs, not like we'd merge it in that state anyway

:+1: I'm curious if we could make this an abstract pattern we can use with other system calls where we need to iterate over a common resource. It wouldn't be trivial to abstract out.

This is only a couple hundred lines of code. I suspect the complexity of trying to abstract out all the little differences in how iteration APIs behave would be worse than the small amount of duplication between multiple implementations of the pattern

This probably also needs a const-correctness pass


[L2] Epic: Polygon, BSC, Arbitrum

An epic branch for the L2 Safes.

[ ] https://github.com/gnosis/safe-react/issues/2493 - New created safe doesn't have name ( reproducable for any network from L2 epic. The issue doesn't exist on dev)

@katspaugh , two questions

[ ]  what was our decision about addressbook importing between the chains ?Example: the user imports csv file with addresses from BSC to Polygon

[ ] is it possible to do switching between the networks in L2 epic to check the case when the users switchs between them in one browser?

what was our decision about addressbook importing between the chains

It's now showing only the addresses that were created on the current network. I think it's fine for this iteration.

is it possible to do switching between the networks in L2 epic to check the case when the user switches between them in one browser?

I'll make a ticket for it.


Fix wrong Boolean validation

is_bool() consider 1 and 0 are not booleans. Eloquent may store a boolean like 1 or 0 in database, so if value is 1 or 0 it's considered as a boolean.
This PR fixes a validation error when updating a resource with laravel-json-api. If you have an attribute which is Boolean in resource Schema and don't provide a value when updating the resource, old value will be value retrieved from database (So may be 1 or 0) and it would say provided value is not a bool (Since is_bool() php function consider those values as false).

You should be using a boolean cast on your model. So I don't think I can accept this PR.

Actually, scrub that - I'm reading this the wrong way round.
assertValue() is used on the value from JSON. The value in JSON should be a boolean, which is why is_bool is correct. I.e. there's no reason why 1 or 0 should be used in JSON when there is an actual boolean type in JSON.

In relation to the old value from the database - you absolutely need to use a boolean casts on your model, as that is how a boolean column should be set up on the model.

In relation to the old value from the database - you absolutely need to use a boolean casts on your model, as that is how a boolean column should be set up on the model.

Totally forgot casting boolean in this case. Thanks!

no problem. thanks for taking the time for doing the PR, hope I didn't sound too abrupt closing it down!


Support for SpringBootTest annotation when bootstrapping a Spring container

Summary

In Spring Boot the recommended way to fire up a test container to run your tests against isn't the @ContextConfiguration annotation but the @SpringBootTest annotation. The Cucumber Spring support doesn't currently check for this annotation so you have to add @ContextConfiguration as well as @SpringBootTest in order for Cucumber to initiate the bootstrapping of the Spring container.
See issue on Stack Overflow
Expected Behavior
When running cucumber tests against a Spring app, the @SpringBootTest annotation should be sufficient on a Spring test container class in order to bootstrap the container.

Current Behavior

Container only boostraps if you also add @ContextConfiguration  in addition to @SpringBootTest
Possible Solution

Change cucumber.runtime.java.spring.SpringFactory method annotatedWithSupportedSpringRootTestAnnotations to check for SpringBootTest annotation as well as others. NB this annotation not necessarily be in the classpath if you aren't using Spring Boot
Steps to Reproduce (for bugs)

Write a basic Spring Boot app (use http://start.spring.io/ to generate a simple one)
Write a class with an empty cucumber @Before annotated method, with the class annotated with @SpringBootTest
Run the cucumber suite. The presence of the @Before method should boot the Spring container. It doesn't

Context & Motivation

Simplification of test code, using the recommended Spring Boot way of bootstrapping a test container.
Your Environment

Version used: 1.2.5 (Spring Boot 1.4.1)
Operating System and version: Windows 7
Link to your project: N/A

This issue belong in the issue tracker for Cucumber-JVM. Isn't this already handled by https://github.com/cucumber/cucumber-jvm/issues/783, https://github.com/cucumber/cucumber-jvm/pull/1004 and/or https://github.com/cucumber/cucumber-jvm/issues/1061?


Geometric median fails for co-linear points that are symmetrical

As reported by Patryk Wozniczka during the Toronto hackathon, the geometric median calculation fails when the input points are

co-linear
symmetrical to the actual geometric point

Example
Below is a list of points with the coordinates that triggered the failure during the hackathon, as used in a DesignScript code block :
Point.ByCoordinates(260,600),
Point.ByCoordinates(285,600),
Point.ByCoordinates(310,600),
Point.ByCoordinates(335,600)

Investigation surfaces that the required ConvexHull fails to be created.
Potential ways to solve this would be

have a colinearity check on both X and Y coordinates of input points before attempting to make a convex hull
make upstream convex hull library work on co-linear points


!known_modules breaks the capability to use !proto with node type

I have a problem with my tern express plugin since I'm using "!known_modules". Tern express defines a Request which extends node http.IncomingMessage.
"!define": {
  request: {
        Request: {
          "!type": "fn()",
          prototype : {
            "!proto" : "http.IncomingMessage.prototype",
}

See https://github.com/angelozerr/tern-node-express/blob/master/node-express.js#L196
With tern 0.13.0 which used !node to extend node tern plugin, it worked well, now with !known_modules it doesn't work. I have debugged and it seems that it works because in 0.13.0, cx.paths stores http.IncomingMessage and http.IncomingMessage.prototype although 0.16.0 stores only http.IncomingMessage.
So in  0.13.0 https://github.com/ternjs/tern/blob/master/lib/def.js#L310  can return the cached http.IncomingMessage.prototype, 0.16.0 cannot do that.
My initial need is to use http.IncomingMessage.prototype in a custom node tern plugin.

@marijnh I have finxed my problem by copying node definitions inside cx.localDefs for node-express :
function preLoadDef(data) {
    var cx = infer.cx(), localDefs = cx.localDefs;
    if (cx.definitions["node"] && data["!define"] && data["!name"]== "node-express") {
      // copy node definition to localDefs to support "!proto" : "http.IncomingMessage.prototype", for request.Request
      for (var def in cx.definitions["node"]) {
        cx.localDefs[def] = cx.definitions["node"][def];
      }
    }
  }

It works great, but I don't know if it's a clean mean.

Did this ever work, though? The http in your path refers, if I understand correctly, to Node's built-in http module. That was never visible from another definition set, as far as I understand it.
We'll need a way to specify dependencies between JSON definitions, but that doesn't exist yet.

Did this ever work, though?

@marijnh I know it's not clean mean, because we expose node modules as global (and it's not like this, that node works). But it's the only mean that I have found to fix problem with express.

We'll need a way to specify dependencies between JSON definitions, but that doesn't exist yet.

Yes it should be very cool if we could specify dependencies like:
"!define": {
  request: {
        Request: {
          "!type": "fn()",
          prototype : {
            "!proto" : "!exports.http.IncomingMessage.prototype",
}

Hey guys, now I am trying to create a plugin for a framework that is an extension of express... so I need to define the prototype for one of my types as "!proto" : "application.Application.prototype" (which is coming from express)
Is there a way to accomplish that or that is still unsupported?
Regards
Orlando

There's still no way to declare dependencies between .json files, but in a plugin you can have your code load dependencies and then refer to the defs they produce.


ESP32C3 glitch on GPIO 4 (IDFGH-12763)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
during power up, I get a 20-30us low glitch on GPIO 4. On my board i have a reset delay IC (5230G). As soon as that releases the CHIP_EN pin I get the glitch. I simplified my circuit to isolate the problem. It is just a pullup resistor on GPIO 5, with a diode connecting GPIO 5 to GPIO 4. The cathode is connected to GPIO 4.
I have simplified the firmware down to only this being in app_main
void app_main()
{
    while(1) {
        vTaskDelay(1);
    }
}

I do not see any mention of this in the datasheet.

With ESP32-C3-DevKitM board, I didn't see a glitch on the GPIO4, after manually pushed the "RST" button. Not sure if it's related to chip revision, could you tell what chip revision of the esp32c3 you're using?
➤ esptool.py chip_id
esptool.py v4.8.dev3
Found 33 serial ports
Serial port /dev/ttyUSB0
Connecting....
Detecting chip type... ESP32-C3
Chip is ESP32-C3 (QFN32) (revision v0.3)

revision v0.3
esptool.py vv4.8.dev1
Serial port /dev/ttyACM0
Connecting...
Detecting chip type... ESP32-C3
Chip is ESP32-C3 (QFN32) (revision v0.3)
Features: WiFi, BLE, Embedded Flash 4MB (XMC)
Crystal is 40MHz
MAC: 34:b4:72:b5:6a:2c
Uploading stub...
Running stub...
Stub running...
Changing baud rate to 460800
Changed.
Warning: ESP32-C3 has no Chip ID. Reading MAC instead.
MAC: 34:b4:72:b5:6a:2c
Hard resetting via RTS pin...


Add a setting for hashtags in changeset comments

These hashtags have to be indicated somehow, e.g. with a different upload icon, a dot near it, or a different colour. Maybe ask once a day to clear hashtags.

Done in 2.0.


Hackathon project stup

Description
Initial setup of the Bridge screen and interface.

My bad, didn't mean to add this here


Provide a way to filter tests in test runners (and possibly Test Explorers)

It would be great to have a way to filter tests in various runners, like the vs runner or the Resharper runner or the Test Explorer in VS.
Current solutions I see in testing frameworks is to have a Trait concept identified by a string value. This seems a pretty good solution. The question is how would one implement Traits in Fixie (tbh I also like the the term "Tags").
The simplest thing I can think of is to have a separate "Convention stream", alongside Methods, CaseExecution, etc. but I am not very familiar with the codebase yet so this is a best guess.
I also don't know how all the different test runners determine "traits" or if they can even support them, so this is sort of a question mark in my mind. I am investigating.

From my research, it looks like Traits are explicitly used when discovering tests, but not when running them. I think a "minimum viable" version of this feature could be some Options convention, like "if there is an 'include' value then use that for Trait discovery" and then for running the tests, just use method prescribed in documentation for the console runner.

That sounds similar to my NUnit Categories sample convention, which allows for filtering when run from the console runner: https://github.com/fixie/fixie/tree/master/src/Fixie.Samples/Categories
Does TFS actually use the VS runner? An odd choice by MS if it does.

I should clarify: We are using the TFS Build Server (I don't like it but there you have it). That Build Server I am pretty sure is uing the VS Runner. I could shell out the test running to our powershell scripts (I do for the Acceptance tests) but then then our error messaging is  a bit convoluted. Additionally, there is still the issue that we cannot choose "categories" of tests to run in the Test Explorer, even when using the Fixie Runner, because there is no way for the Test Discoverer to pass in what tests to filter atm.

Understood. Thanks for clarifying!

Today, I've studied the implementation details of the NUnit VS Test Adapter, because it does take part in the traits infrastructure both for Test Explorer and TFS Build filtering.
My main focus was on the use of the VS-provided types from the Microsoft.VisualStudio.TestPlatform.ObjectModel namespace.
I don't declare defeat yet, but there's a definite "impedance mismatch" between the concepts VS wishes test runners had ("Hey everybody, be more like MSTest!") and the concepts the target test framework actually has.
Before I start laying out several possible plans of attack, I'd like some more input on the TFS Build use case.  When you configure things for NUnit, what does that look like?  Apparently there is a special string format for specifying what you want to run, a complex example being:
(TestCategory!=UI&(Priority=1|Priority=2))|(TestCategory=UI&Priority=1)

Some of what makes this tricky is that the part of all this that's baked into Visual Studio has a few strongly held opinions that are true for MSTest and absolutely false elsewhere.  For instance, at discovery time, Fixie deliberately only reports method groups as test cases instead of each test case that will actually exist at execution time (this applies to overloaded tests and more importantly to parameterized tests).  If I strayed from this focus on method groups, you get a horribly glitchy experience in the UI that you can experience with NUnit and I don't want to introduce for Fixie.  But, then that makes traits-per-test-case technically impossible.
Again, I don't give up, but the short version is that TFS Build and Visual Studio make some quite-false assumptions about how a test framework is going to work, and there might not actually be a good compromise here.  I'll keep researching.

hmm. Thanks for that insight. We use mstest right now as our test framework, not mstest. I will post what the filtering looks like tomorrow, but it has to do with adding TestCategoryAttributes("string") and then specifying these attributes with bitwise and/or operations.
Ok I may have a limited understanding of method groups, but, I would imagine you would have a Trait per Method Group, not Test Case. Although I could see enforcing this for method overloads may be tricky.
I hope that added info helps. And also, for my particular case, I think I could convince the devs to sue a diff runner for running tests locally and then just shell out the ci tests.  But the real question is whether there is a demographic of ppl stuck with such technology that may want to use Fixie?
Honest to God, I think Fixie may explode to the point where people will be like "Remember when we used Test FRAMEWORKS?" but the Msoft world is really hit or miss with this stuff.

I don't see a huge problem disallowing the traits-per-test-case situation and just Traiting by Method Group e.g. "Traits.Select(methodGroup => new Trait[] {'fast'})" or something like that. Usually Traits are used for filtering and I cannot imagine a use case where someone would not want all overloads on a method to be the same Trait. If they do, well then that is their problem.

Is there anything I can help with this?

Apologies for the delay. I've got a project at work wrapping up this week, so I haven't had quite enough time to look into this until now.  I would be greatly appreciative of your help, if you're still interested.
Regarding my concerns about MethodGroup, I think this new feature request is really telling me that I just plain got it a little wrong when I first implemented the VS runner, oversimplifying things.  I have a plan ready to take the opportunity to fix that as a part of making this feature work.
You'll see that I've created a new branch with no work on it yet, called "traits".  Please make sure that any PR for the traits feature is against that branch, so we can keep master open to things like urgent bug fixes.  I think this traits feature will be best handled as a series of smaller PRs against the traits branch, instead of all-at-once.  I want to break it into multiple PRs because:

It makes it a lot easier to review each piece. The previous attempt at traits had a lot going for it, but it was such a large PR that I had trouble bringing it in at a time when the rest of the infrastructure was still in flux.  I wasted that other developer's time and effort as a result, and I want to avoid similar trouble this time.
There are a few pieces of the overall feature I might be able to implement at the same time you're working on other parts.
My plan for the multiple PRs is probably wrong in some way I won't see until we're partway through it, and I don't want to waste your time handing you a very large but flawed design to implement :)

If you're still interested in helping, I'd like to see a first PR that does all of the following:
First, a new class, Trait, with read-only string properties Name and Value.
Next, the ability to define where traits come from in a convention, even though they definitely won't be very usable for anything until later Pull Requests.  The existing convention API support for parameterized cases will be our best model of how to implement this part.  Here's the goal, a snippet that we can place inside a custom convention:
Traits
    .Add<MyTraitSource>() //specify a type name that knows how to find traits
    .Add(new MyTraitSource()) //specify an instance of such a type
    .Add(methodInfo => enumerable of Trait) //specify a func that is equivalent to such a type

To accomplish this API, we'll need a TraitSource and TraitSourceFunc similar to ParameterSource and ParameterSourceFunc.  This time, though, we need the operations to be MethodInfo => IEnumerable<Trait>. See ParameterSourceExpression for how to create these 3 "Add" overloads, resulting in a new TraitSourceExpression. Armed with TraitSourceExpression, Convention can gain the Traits property from the above snippet.
If an end user can successfully define conventions in this way, even though they don't yet have any effect, I'll accept the PR.  There's probably very little of this that can be tested; we'll make sure we have good coverage in the followup PR that makes them more useful. We can talk about next steps once this first PR is in.

I agree small PRs is a great way to go. If I may sugest an alternative approach to breaking them down, however. We could go in a more "Minimum Viable Product" direction, where I can start with as simple a Trait as possible and implement it through the entire system. THis way we can get testing right away while still keeping the PR small, following the "Convention" conventions, and refactoring into more complex Traits.
Example: We could create only one Trait that either be turned off or on that will create a new Trait from the first letter of the test's class name. We can then test that the tests are grouped by this trait.
Here is a potential PR order:

one Trait for the first letter of the Method Gorup name that is always there.
The ability to turn off and on that Trait.
The ability to decide whether to use the first letter or the last letter of the Method Group name.
At this point, perhaps we can implement full-blown customization based on your guidelines.

What do you think of doing it this way? I will start implementing this stuff either way, however, due to an upcoming conference at which I am presenting I am not sure how far I will make it. I at least want to get the first PR out in the next week or two.

OK, this might be a silly quesion, but how are you running the tests in the codebase? You using the console runner?

At the command line, running just "build" will compile and run all the tests.  Inside VS, I run them with TD.NET.  Due to the lame way that VS detects and installs runners found in nuget packages, I can't actually use the VS Fixie runner to run Fixie's own tests.

Closing due to age, interest, and the upcoming deprecation of VSTest.
VSTest is being deprecated by the new Microsoft.Testing.Platform which will form the primary focus for v5. https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-platform-intro
Capabilities of the new platform are a work in progress on the MS side and will influence anything we do here on this side.


Quick and dirty design fix

Hi.
This is just a very simple fix for now, I will see for propose another design later tho but at least this is a good start i think.

Looks good!


⚠ api.piste.gouv.fr healthcheck has degraded performance

In 36b021f, api.piste.gouv.fr healthcheck (https://api.piste.gouv.fr/cassation/judilibre/v1.0/healthcheck) experienced degraded performance:

HTTP code: 200
Response time: 2718 ms

Resolved: api.piste.gouv.fr healthcheck performance has improved in b8d5c76.


MenuFlyoutItem doesn't support KeyValuePair as CommandParameter in Winui Desktop

Describe the bug
I am porting a UWP desktop bridge app to WinUI3 Desktop and found an issue when assigning a KeyValuePair to the CommandParameter of a MenuFlyoutItem.
The following code generates an exception when executing:
void ShowMoreMenu(bool isLocA, FrameworkElement senderElement)
{
  var vm = this.DataContext as ConflictsViewModel;
  var itemVM = (ConflictItemViewModel)senderElement.DataContext;
  MenuFlyout menu = new MenuFlyout();
  FontFamily fontFamily = new FontFamily("Segoe MDL2 Assets");
  var cmdParm = new KeyValuePair<bool, ConflictItemViewModel>(isLocA, itemVM);
  menu.Items.Add(new MenuFlyoutItem
  {
      Text = ResourceLoaderHelper.GetString("Menu-Open"),
      Icon = new FontIcon() { Glyph = "\xE8E5", FontFamily = fontFamily },
      Command = vm.OpenCmd,
      CommandParameter = cmdParm
  });
  ...
  menu.ShowAt(senderElement);
}

The exception is:
Exception thrown: 'System.Reflection.TargetInvocationException' in System.Private.CoreLib.dll
An exception of type 'System.Reflection.TargetInvocationException' occurred in System.Private.CoreLib.dll but was not handled in user code

When I remove the CommandParameter assignment or assign a 'real' object to it then it is OK.
I can work around this by creating a special class to hold the key and value, create an object and assign this to CommandParameter.
This seems to be a bug unless I missed something.
Steps to reproduce the bug
Create a WinUI Desktop app with a Page and a Button.
Call the above code when the button is clicked.
Expected behavior
No response
Screenshots
No response
NuGet package version
1.0.0
Packaging type
Packaged (MSIX)
Windows version
Windows 11 version 21H2 (22000)
IDE
Visual Studio 2022
Additional context
No response

Confirmed this is a bug, please continue to use your workaround until we can take a look.


Add docsify index file

example site: http://magicdawn.ml/clean-code-javascript
If this PR merged, have this settings will build a real doc page

Hey Tao!
I've trying to keep this along the same lines as Airbnb's JavaScript style guide, and other similar documents. I'll keep this in mind in the future and reopen this PR if need be. Keep the PRs coming!

Gotcha


Structured data for pre-degree qualifications

Is it worth documenting how we arrived at the underlying data that powers the design? That feels quite important for this feature.

@benilovj Added our analysis of the different qualifications and their breakdown, and a link to the spreadsheet we’ve been using. Let me know if you think this needs further detail.


[FEATURE] Ability to open multiple pointclouds

Is your feature request related to a problem? Please describe.
Right now on android you can open just one pcd at a time - we need to be able to select a bunch of files and open them at once.
Describe the solution you'd like
Just add EXTRA_ALLOW_MULTIPLE to the android content provider extra parameters.

Done, now it can open multiple files.


README.md

[x] a summary paragraph
[x] 4 functions descriptions
[x]  where your packages fit into the Python and R ecosystems

done


context for DefaultFunc

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

Generate default value based on tenant in context
field.String("id").
	GoType(ID("")).
	DefaultFunc(func(ctx) ID { return MustNew(MustTenantID(ctx)) }),

Motivation 🔦

Tenant prefix primary id - like pulid example - 1-user-abcd
Tenant scoped serial number
Default value based on other field
Type prefix primary id based on type in context instead set prefix for every schema like pulid

The defaults invoked in create one and createBulk  can access current context.

Hey @wenerme and thanks for proposing this issue. We use schema hooks for such use cases.
If you still think it should be added, I'll tag the issue as a proposal and we'll wait for more feedback about it here.
I find it nice to have this "default-ctx-func" as a small mutator that can update only one field, but I'm not sure it's really needed, because you can achieve that same thing (and much more) with a schema hook.

I use hook too, like
func (TenantSidMixin) Hooks() []ent.Hook {
	return []ent.Hook{
		hooks.HookSid(),
	}
}

hook like
func HookSid() ent.Hook {
	return func(next ent.Mutator) ent.Mutator {
		return ent.MutateFunc(func(ctx context.Context, mutation ent.Mutation) (ent.Value, error) {
			if mutation.Op().Is(ent.OpCreate) {
				s, ok := mutation.(interface {
					SetSid(v int)
				})
				if ok {
					id, err := NextSid(ctx, mutation)
					if err != nil {
						return nil, err
					}
					s.SetSid(id)
				}
			}
			return next.Mutate(ctx, mutation)
		})
	}
}

If default func support ctx, this can be write like
func (TenantSidMixin) Fields() []ent.Field {
	return []ent.Field{
		field.Int("sid").Immutable().DefaulFunc(func (ctx context.Context, mutation ent.Mutation)(int, error) {
                   return NextSid(ctx)
                }),
	}
}

The default func looks better than hook. Also, if changed the field type, the hook interface must change too, otherwise, the interface assertion will not match.

The hook can be registered like this
func (TenantSidMixin) Hooks() []ent.Hook {
	return []ent.Hook{
		hook.On(HookID, ent.OpCreate),
	}
}

func HookID(next ent.Mutator) ent.Mutator {
	return ent.MutateFunc(func(ctx context.Context, mutation ent.Mutation) (ent.Value, error) {
		s, ok := mutation.(interface {
			SetSid(v int)
		})
		if ok {
			id, err := NextSid(ctx, mutation)
			if err != nil {
				return nil, err
			}
			s.SetSid(id)
		}
		return next.Mutate(ctx, mutation)
	})
}

I agree it's longer, but not sure I like the idea we pass the mutation to the Default function.

@a8m but the context do not have type info

Related issues

https://github.com/ent/ent/issues/571
https://github.com/ent/ent/issues/549

Custom type handling is a lower level processing than column, but column hook can enable custom type handling.


dialog closes on $location.search() change even when reloadOnSearch:false

I noticed that when I have a dialog open and change a param using $location.search() that my dialog closes. (I have reloadOnSearch: false in my $routeProvider for the page in question).   Take for example that a user interaction within a dialog sets a query param in the address without firing a route change.
Looking into dialog in angular-bootstrap js, I see relavent code:
 Dialog.prototype._bindEvents = function() {
      ....
      this.$scope.$on('$locationChangeSuccess', this.handleLocationChange);
    };

 this.handleLocationChange = function() {
        self.close();
      };

Would it not make more sense to change this event to?
this.$scope.$on('$routeChangeSuccess', this.handleLocationChange);

This appears to fix it, but hate to make modifications to code supplied by third-parties since upgrades require going back in and remembering to make modifications again.   I can understand that if the route were to actually change that the dialog should close.  Maybe this could be supplied in opts, or possibly check the config?  I'm not sure the possibilities, but wanted to bring this up.

This is still an issue. Changing location.search instantly closes the dropdowns, with no apparent way to override.


Incorrect initial state of FSM after conversion from PN

To reproduce:
 - Open the attached pn.work
 - Choose Tools->Convert->Finite State Machine
Expected behaviour:
 - The sate with outgoing t1 even should be initial.
Observed behaviour:
 - Sometimes (but not always) the initial state is incorrect .
Looks like the information about the initial state is lost during Fst to Fsm conversion. AbstractModelConverter is extended with postprocessing() method to set the initial state correctly.

danilovesky at 2015-03-26T14:57:53Z:


Fixes for analyzers documentation

ArangoDB PR: https://github.com/arangodb/arangodb/pull/16571

@Simran-B @KVS85 Ready for review

Drafted for possible future usage.

@ansoboleva Should be closed IMO

No progress has been made regarding an improvement of the demo fastText model that would allow us to actually generate examples with it.


Feature Request: LARGE_BANNER

Please, implement LARGE_BANNER: https://firebase.google.com/docs/admob/android/banner

Done in<EMAIL_ADDRESS>https://github.com/floatinghotpot/cordova-admob-pro/commit/5119c0bf6878a61ce6afa5f69c928d0092ec32a4


Create remote storage bucket/folder for test data (SLC images)

Should be hosted on some service which is accessible to all. Ideally AIR could host something, as it would secure long-term access.

We can definitely do this. When is it needed by?
If needed within one month's time, I will create an S3 bucket on AWS. If not yet needed, I will create an S3 bucket in our own storage cluster in our data centre. We prefer the latter option since otherwise, we'd have to change it once we get our cluster going.

Hey, great!
If you prefer the latter option, that is fine with me. When would it be
available do you think?
Best regards Eigil
On Thu, 20 Oct 2022, 11:58 Joao Pinelo Silva, @.***>
wrote:

We can definitely do this. When is it needed by?
If needed within one month's time, I will create an S3 bucket on AWS. If
not yet needed, I will create an S3 bucket in our own storage cluster in
our data centre. We prefer the latter option since otherwise, we'd have to
change it once we get our cluster going.
—
Reply to this email directly, view it on GitHub
https://github.com/AIRCentre/SARProcessing.jl/issues/12#issuecomment-1285258063,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJRM2K65KIDJD2NNBDPZOVLWEEJVRANCNFSM6AAAAAARJKEC3A
.
You are receiving this because you authored the thread.Message ID:
@.***>

I estimate around 30-40 days.

Great that should be fine.
Best regards,
Eigil
From: Joao Pinelo Silva @.>
Date: Thursday, 20 October 2022 at 12.37
To: AIRCentre/SARProcessing.jl @.>
Cc: Eigil Yuichi Hyldgaard Lippert @.>, Author @.>
Subject: Re: [AIRCentre/SARProcessing.jl] Create remote storage bucket/folder for test data (SLC images) (Issue #12)
I estimate around 30-40 days.
—
Reply to this email directly, view it on GitHubhttps://github.com/AIRCentre/SARProcessing.jl/issues/12#issuecomment-1285310923, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJRM2K5UDEDBH2NZV7Z5NPLWEEOIJANCNFSM6AAAAAARJKEC3A.
You are receiving this because you authored the thread.Message ID: @.***>

Hi Joao, happy new year!
Is there a bucket for this now? best regards Eigil


'No items found' helper link not presented after removing all items

Expected behavior:
When you remove all items, you should get the helper starting link back
Actual behavior:
Helper link is not present
Steps to reproduce:
Be in the state with only one item
Delete that item
The 'No items found. Create a new item record' starting helper is not presented.
Screenshots (if applicable):
OS and Browser:

@tangollama I want to solve this issue.

@esbanarango swing away. Marked as in progress, per process.


Why this is infinite loop?

I encounters infinite loop when i run a saga_gui.py
First, the torch version caused the following error in def pca.
TypeError: linalg_eig() got an unexpected keyword argument 'eigenvectors'
So I changed it to the code below and the gui screen doesn't pop up when I run it and it's stuck in loading model file done.
`
def pca(self, X, n_components=3):
  n = X.shape[0]
  mean = torch.mean(X, dim=0)
  X = X - mean
  covariance_matrix = (1/n) * torch.matmul(X.T, X).float()

  eigenvalues, eigenvectors = torch.linalg.eig(covariance_matrix)

  # Convert complex eigenvalues and eigenvectors to real parts
  eigenvalues = eigenvalues.real
  eigenvectors = eigenvectors.real

  # Sort eigenvectors based on eigenvalues in descending order
  idx = torch.argsort(-eigenvalues)
  eigenvectors = eigenvectors[:, idx]

  proj_mat = eigenvectors[:, :n_components]
  return proj_mat

`
Why is this like that?

I think this problem doesn't get gui screen using ssh server.
How can we fix the problem?

Hi. Sorry for the late response. But the SAGA gui currently cannot support remote server (at least I failed). You may need x11 forwarding for this but I'm not sure whether it can work. You can use the notebook provided by us as a replacement.


”Viișoara”, ”Ormeniș”, ”Sântioana” are listed in the drop-down menu

Description:
When user writes ”Viișoara”, ”Ormeniș”, ”Sântioana” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Viișoara"

Expected results
The location appears in the drop-down menu as "Sat Viișoara, MUREȘ (Viișoara)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Ormeniș"

Expected results
The location appears in the drop-down menu as "Sat Ormeniș, MUREȘ (Viișoara)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Sântioana"

Expected results
The location appears in the drop-down menu as "Sat Sântioana, MUREȘ (Viișoara)".


Receiving Error OMRS-XTDB-REPOSITORY-0022 during operation

Hi,
Running the some of the lab notebooks with XTDB over Postgres (both txn and doc) and noticed that I am getting lots of errors of the form:
egeria Tue Apr 11 11:31:20 GMT 2023 cocoMDS1 Error OMRS-XTDB-REPOSITORY-0022 The requested ClassificationOrigin enumeration with ordinal or symbolic name null does not exist.                                                                    │
│ egeria Tue Apr 11 11:31:20 GMT 2023 cocoMDS1 Error OMRS-XTDB-REPOSITORY-0022 The requested ClassificationOrigin enumeration with ordinal or symbolic name null does not exist.                                                                    │
│ egeria Tue Apr 11 11:31:20 GMT 2023 cocoMDS1 Error OMRS-XTDB-REPOSITORY-0022 The requested ClassificationOrigin enumeration with ordinal or symbolic name null does not exist.
Is ClassificationOrigin not getting set? Other thoughts? This does not appear as an error to the client..

I also see the message:
Information OMRS-XTDB-REPOSITORY-0026 Cannot sort by property By property value (Ascending) on types: [ControlledGlossaryTerm, GlossaryTerm].
When I do a search for a glossary term?

Current hypothesis is that this may have been due to an old XTDB library being loaded. It seems to be working properly - when I made sure that the latest xtdb library was being sourced. Might be nice if we printed out library versions when we load them (maybe we do).

I hope to implement the above -- if so, it's a good time to revisit what could be logged.


adding github release image

I have removed the api key from the .drone.yml and added a new one as a drone secret instead

@Joseph-Irving do GH releases work now?

it sure does, I have tested it now, took me a little while to get it properly working


Spike for supporting arbitrary / dynamic heights

Note: This issue is a place for me to keep notes about an idea I have that I hope to eventually have enough time to focus on implementing.
All react-virtualized components currently require their cells to have explicit widths and heights. These dimensions can change from cell to cell but they must be known ahead of time in order for the windowing algorithms to determine which cells, and how many, to display. I think it might be possible to not require this information ahead of time and instead just use a fixed width and height (representative of an "average" cell) to do the initial, rough layout. Then as a cell is brought into view, its rough dimensions could be replaced with real dimensions and the overall grid-size could be adjusted slightly as necessary.
Because react-virtualized allows programmatically jumping directly to an item- it's possible that real cell measurements might be sparse within the overall tree but I think this approach may still work. This would enable cells with dimensions that are determined at runtime based on things like the amount of space required to display a string of text. It has a potential downside that the scrollbar may grow/shrink unexpected as a user scrolls if the real cell sizes are vastly different than the "average" sizes used for initial layout. It also has potential performance implications.

Came here to request this exact feature. I think some min- and maxHeight would be useful too, or is that something for the CSS of the individual rows?
I was thinking that when mounting a row, it could simply give it absolute positioning and the fixed width, and on its componentDidMount you measure and adjust the actual height. Since the row is absolutely positioned it is happy about being moved around when something above it changes its height, without causing the browser to recalc. I suppose that was what you have in mind?

More or less. But a lot of care would/will need to be taken to ensure that performance didn't suffer with this feature. I'm currently working (in a branch) on some optimization aimed at reducing the number of render calls and potentially caching grid cells. Those may help.
This feature is a big lift though. Not sure when I will find the time to get to it.

Since this is my pet request, I will add in some points of discussion that we had in our Discord conversations.
One approach to minimize performance impact on load could be to ask for a startingNumberOfRows that you keep in view regardless of height and once those are loaded, start calculating based on height. That parameter could also double up as minimumNumberOfRows which is what you can show if someone sets it.
I imagine you'd need a function which on scroll would keep making height calculation to see if rows loaded are within the viewport height?
The more I think of it, it seems like it is probably best to start this off for a simple component that performs the most basic case of lazy loading as that will avoid the complications that come with going directly to a component, etc. (although I am not sure if that diverges from the goal of the library..)

I was thinking more along the lines of the estimatedItemSize property of the iOS UICollectionViewFlowLayout :

Providing an estimated cell size can improve the performance of the collection view when the cells adjust their size dynamically. Specifying an estimate value lets the collection view defer some of the calculations needed to determine the actual size of its content. Specifically, cells that are not onscreen are assumed to be the estimated height.

Scrolling directly to an item does complicate things as you say but it's one of the primary features of this library so I don't want to drop it.

http://facebook.github.io/fixed-data-table/ offers this feature, any body looked into that how they do it?

fixed-data-table doesn't support other properties that react-virtualized does (like programmatically scrolling a cell within view) so their use case is probably easier than mine. But no, I haven't looked too closely at their implementation in a couple of months.

They didn't commit anything since 5 months, I am not sure it is maintained, but maybe, just maybe, they have good ideas regarding this particular thing.

I didn't mean to suggest they didn't. But this project is only maintained by me in my free time so I just haven't had the bandwidth to really bite this size of a feature off yet. Not sure when I will.

Can we access this things currently?

get the rows that currently in the window
get the speed of current scrolling
update them with new height/width values

If yes I could do the following:

If speed is higher than X, return  some fixed height/width
once speed gets slow enough, start calculating sizes and update it with new sizes
when speed is real high, we could even avoid rerendering at all, its a trick but with really high speed nobody will see the difference anyways.

1: get the rows that are currently in the window

This is possible via the onSectionRendered callback for Grid (or onRowsRendered if you're using VirtualScroll or FlexTable).

2: get the speed of current scrolling

No, this information is not available although you could certainly implement it with a HOC using the onScroll callback. A HOC to look at for ideas on doing this would be ScrollSync.

3: update them with new height/width values

The problem is determining which cells are visible based on the current scroll position. Unless you assume a fixed size for all cells, you can know which ones are visible for a given offset without knowing the sizes of all cells before that offset.
This ticket is basically for me to keep track of ideas regarding efficient ways to compute (and estimate) the sizes of the cells before- given that a user might jump to the middle or end of a virtualized component.

The problem is determining which cells are visible based on the current scroll position.

Maybe we don't need to know if it is really visible, we can calc heights for all rows in the window. We just need to keep window not too big, because otherwise there will be a bigger overhead.
I am  not sure how visible would be the flickr, because rows will be already rendered with some fixed height and then once we know the real height, rows gets resized.

Maybe we don't need to know if it is really visible, we can calc heights for all rows in the window. We just need to keep window not too big, because otherwise there will be a bigger overhead.

This would require rendering all of the cells which would defeat the purpose of the windowing approach.

Why all, we have a fixed amount of rows we render in the window, which is based on the initial row height, right?

We're misunderstanding each other somewhere. I think you're over-simplifying this a bit, but I think continued discussion of it via the GH issue probably isn't going to be as effective as just chatting. Feel free to hop on the Gitter room if you'd like to talk about it more. :)

Just saying that I would also really like to have such feature implemented! So much data with approximate height(s) need to be rendered efficiently

Hoping this makes its way into version 7. Myself and @kof are working on it from different angles.

This feature was introduced (in a limited way) via the version 7 CellMeasurer component.
This component could be improved significantly~ something I'd welcome contributions from others on~ but the basic functionality exists now, so I'm going to close out this issue.

Hi, can the CellMeasurer component be used in a Table? If not, is that support anywhere on the roadmap? Thanks!

No. Unfortunately Table and CellMeasurer can't be used together. (And support is not on the roadmap.)

Thanks for the quick reply. With that in mind, is there a way using this plugin to reap the benefit of sticky table headers without virtual scroll? Meaning, all row heights are calculated and rendered in the DOM?
My use case is similar to ones posted by others, where my row height simply cannot be calculated without retrieving data from the server first and rendering via Markdown.
Note that I am using this plugin as intended in other use cases within the project, and I've invested some time in formatting data to fit this plugin, so I'm invested in using it for the use case described above if I can.
Fantastic work, by the way. The virtualized table has been a performance lifesaver in my other use cases.

Thanks 😄
Hm. I have not yet needed to use CellMeasurer in a production app. I created it for others but I haven't had a use-case for it myself so I'm a bit of a disadvantage offering advice about edge-cases usage. I think it might be possible to combine the 2 but you would likely need to wrap CellMeasurer's getHeight function with your own function that set some boundaries.
I have heard a couple of other people say they use react-virtualized with react-measure instead of CellMeasurer. I haven't tried this myself, either, but maybe it would be worth looking into.

Hi, @bvaughn !  I've been looking into using react-virtualized's Collection component for a while but was unsure it was possible because of an issue like this.  Our usecase is laying out a set of nodes which can be either opened or closed -- opened nodes are wider and stacked in a column on the right.  A picture is worth a thousand words:

The key issue is that the column widths aren't identical (so the magical Masonry component doesn't work) and the height of each node can change.  As the layout is responsive, the height and width won't be known until things are mounted to the page.  Any recommendations on how I'd set up the positions and row/column indexing for a case like this?

@john-osullivan I'm not sure of a good way to achieve the kind of flowing/responsive layout you're describing within RV at the moment.

Bummer.  I'll leave a comment if I come up with a smooth system that can be contributed back to the library!

👍 That would be great @john-osullivan !


feat: add getNumberInputCells to BuiltinRunner method

Closes #348

@Godspower-Eze Can we add unit tests here to cover this implementation? reference for that: https://github.com/lambdaclass/cairo-vm/blob/4ea224a1068b43aaa3899d24e834475106e8a78f/vm/src/vm/runners/builtin_runner/mod.rs#L641-L685

@Godspower-Eze Can we add unit tests here to cover this implementation? reference for that: https://github.com/lambdaclass/cairo-vm/blob/4ea224a1068b43aaa3899d24e834475106e8a78f/vm/src/vm/runners/builtin_runner/mod.rs#L641-L685

Okay. I will add that later today


Add a configure method to the testing block to allow for configuring multiple test suites and avoid duplication

Related to #19870 and #19686

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

I like the idea of lazy registration with a configureEach for suites, but don't we need to specify the type of the suite as to be created (JvmTestSuite) well?  I suppose we'd just assume everything we're configuring is that same type.
This was just a quick change per the example in the 7.6 work document.  I didn't realize there was a method on Project that would work with these already.  I was aware using the all block with a filtering if to filter the selection would work, but I didn't think it was something we want to encourage, if we want to emphasize a declarative DSL.  I think it's easier to discuss these alternatives with some real code to look at, this was a quick change I'm happy to throw after in favor of something better.
Extracting a block to use an argument to configure is a little unintuitive, but maybe that's all we need.  We should probably add a snippet to the docs demonstrating that if we think it's the best solution.

I like the idea of lazy registration with a configureEach for suites, but don't we need to specify the type of the suite as to be created (JvmTestSuite) well? I suppose we'd just assume everything we're configuring is that same type.

Right, type is probably important here too. You can always get a more specialized type with withType(...), so configureEach(String names..., Action action) would be the type of the container.

I think it's easier to discuss these alternatives with some real code to look at, this was a quick change I'm happy to throw after in favor of something better.

I don't think this is something we want to recommend right now, but another idea here would be to make it easier to extend JvmTestSuite and get all of the same goodies.
So if you had multiple test suites that were supposed to be configured "the same", instead of writing:
testing {
    suites {
        integTest(JvmTestSuite) {
            // configuration
        }
        anotherIntegTest(JvmTestSuite) {
            // another copy of configuration
        }
    }
}

You could extend JvmTestSuite as MyTestSuite and write...
testing {
    suites {
        integTest(MyTestSuite)
        anotherIntegTest(MyTestSuite)
        withType(MyTestSuite) {
            // configuration
        }
    }
}

The test suites would be treated as JvmTestSuites in all other ways, but you'd have a way of identifying them as special and configuring them in their special way.
I think this fits into how we want test suites to be used by other ecosystems.

Extracting a block to use an argument to configure is a little unintuitive, but maybe that's all we need. We should probably add a snippet to the docs demonstrating that if we think it's the best solution.

I think "best solution" is a little strong. Inevitably, I don't think test suites are similar enough to one another that it'll make sense to try to de-duplicate a few lines. I think I would follow...

Duplicate it
If it truly applies to all, use all
If you have exceptions, make a trade-off between:

Duplicate it all again
Extract the common configuration to a block and apply that to the right elements
Use all, but filter things out with an if

None of these are wrong. They just span the gamut between declarative and imperative.

You could extend JvmTestSuite as MyTestSuite

I was wondering how this would work, since how would the binding know to create which class for the new interface?  I don't think it does without writing a plugin and re-implementing all the methods in DefaultTestSuite:
def "custom test suite type with shared config"() {
        given: "a build containing an interface extending JvmTestSuite"
        file("build.gradle") << """
            plugins {
                id 'java-library'
            }

            ${mavenCentralRepository()}

            interface MyCustomSuite extends JvmTestSuite {}

            testing {
                suites {
                    tests1(MyCustomSuite)
                    tests2(MyCustomSuite)

                    withType(MyCustomSuite) {
                        useSpock()
                    }
                }
            }

            task checkConfiguration {
                dependsOn tests1, tests2
                doLast {
                    assert configurations.tests1RuntimeClasspath.files.any { it.name == "spock-core-${DefaultJvmTestSuite.Frameworks.SPOCK.getDefaultVersion()}.jar" }
                    assert configurations.tests2RuntimeClasspath.files.any { it.name == "spock-core-${DefaultJvmTestSuite.Frameworks.SPOCK.getDefaultVersion()}.jar" }
                }
            }
        """

        expect:
        succeeds("checkConfiguration")
    }

yields:
* What went wrong:
A problem occurred evaluating root project '5wrdk'.
> Cannot create a MyCustomSuite because this type is not known to this container. Known types are: JvmTestSuite

I started to look at adding something like:
interface MyCustomSuite extends JvmTestSuite {}
abstract class DefaultMyCustomSuite extends org.gradle.api.plugins.jvm.internal.DefaultJvmTestSuite implements JvmTestSuite {
                DefaultMyCustomSuite(String name, ConfigurationContainer configurations, DependencyHandler dependencies, SourceSetContainer sourceSets) {
                    super(name, configurations, dependencies, sourceSets);
                }
            }

testing {
    suites.registerBinding(MyCustomSuite.class, DefaultMyCustomSuite.class);
}

which gets closer, but still yields:
* What went wrong:
A problem occurred evaluating root project 'cnyku'.
> Could not create an instance of type DefaultMyCustomSuite.
   > failed to access class org.gradle.api.plugins.jvm.internal.DefaultJvmTestSuite$VersionedTestingFramework from class DefaultMyCustomSuite_Decorated (org.gradle.api.plugins.jvm.internal.DefaultJvmTestSuite$VersionedTestingFramework is in unnamed module of loader 'app'; DefaultMyCustomSuite_Decorated is in unnamed module of loader org.gradle.groovy.scripts.internal.DefaultScriptCompilationHandler$ScriptClassLoader @6f28a07e)

I think I would follow...
Duplicate it
If it truly applies to all, use all
If you have exceptions, make a trade-off between:

Duplicate it all again
Extract the common configuration to a block and apply that to the right elements
Use all, but filter things out with an if

None of these are wrong. They just span the gamut between declarative and imperative.

It's probably worth adding a "Sharing Configuration Between Suites" section to the docs with some snippets demo-ing these and noting the preference order and any tradeoffs, as well as showing how to use the configure method on Project.
Want me to make a ticket for that for 7.6?

I was wondering how this would work, since how would the binding know to create which class for the new interface?

Yeah, it's not straightforward to do right now.  One approach would be to get rid of DefaultJvmTestSuite and somehow implement it based entirely on the managed properties in JvmTestSuite. That's tricky because we have state/bridging in there to keep old behavior working.
A variant of that is to move some of the implementation into JvmTestSuite as default methods or by making JvmTestSuite an abstract class. Neither of those options are as neat/clean.

It's probably worth adding a "Sharing Configuration Between Suites" section to the docs with some snippets demo-ing these and noting the preference order and any tradeoffs, as well as showing how to use the configure method on Project.

That sounds good to me.


[PARALLEL] Emit events for building images

Copy of https://github.com/docker/compose/pull/11498 so I can run CI without waiting for someone to approve it.

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Setup - Modification of binding action/key

Describe the branch you are working on
setup
Describe the problem or limitation you are having in your project
No response
Describe the feature / enhancement and how it helps to overcome the problem or limitation
A node class that can change button/action bindings needs to do the following requirements:

recognize if it contains a child of a button node, if not it needs to be warned
recognize any button when pressed and bind the button to the specified action, a prompt needs to appear when the button is pressed "Press any button to bind"
add a property to the node to specify the name and default case of the action, and bind and add at initialization time
show existing button bindings

Tip: Read the source code for Input, InputEvent and InputMap. The method for whether it contains buttons refers to the Area2D class, which should check if its children contain Collision2D (maybe a "get_children()" method).
Reference: https://www.youtube.com/watch?v=ZDPM45cHHlI
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
No response
If this enhancement will not be used often, can it be worked around with a few lines of script?
No response
Is there a reason why this should be core and not an add-on in the asset library?
No response

#Description
A action binder works as an element node for pannel containers, the idea is to create usr desgin config for keyboard layout.
e.g up : w. And an expected fonctionality is to bind an input key with the action e.g. up : tab -> w
#TODO：
Create a class action_binder (a 2D node) with the following functionality:
-- to auto detect if it contains a child node of the type BUTTON
-- a label of the action
-- a function to bind input key with the action


Remove automatic login on email confirmation (opr #662)

Successful password reset redirects to login view by default.

Successful email confirmation redirects to login view by default.

Updated password reset tests to check user doesn't get
logged in automatically.  (closes #662)

Added tests to test redirections on password reset
and email confirmation.

Did #137 instead - which makes sure can't re-use confirmation token, and adds option to not auto-login.


Fill operations contain no information about market fees

Playing around with market fees on a local testnet I've noticed that there's no data whatsoever indicating that market fees were charged. In a market with 50% market fees I placed an order to buy 6 USD, and only received 3 USD even though the fill operations say I received 6 USD as can be seen from the screenshot:

The missing 3 USD obviously went to the fee pool for the market due to the 50% market fee.
Here's the operation json for the first fill of 5 USD, as you can see there's no indication of market fees being charged:
[
0: 4,
1: {
  account_id: "1.2.7",
  fee: {
    amount: 25000,
    asset_id: "1.3.2"
  },
  order_id: "1.7.16",
  pays: {
    amount: 200000000,
    asset_id: "1.3.0"
  },
  receives: {
    amount: 50000,
    asset_id: "1.3.2"
  }
}
]

Yeah those market fees should be recorded in the v-op, and displayed in the GUI too...

Actually the fee is recorded, from the JSON:
fee: {
    amount: 25000,
    asset_id: "1.3.2"
  },

That's a 2.5 USD fee right there.
The GUI should be updated to show you got 5 USD but payed 2.5 USD fee.  The data you need is there, it's purely a GUI level problem, not a backend problem.

Closing, discussion should move to the above graphene-ui ticket as this is a UI problem.


Swapping container gives "invalid field terminationMessagePolicy for v1.Container"

What were you trying to do?
Swapping a local container with one in a remote kubernetes cluster on OSX. This might be related to #226?
What did you expect to happen?
The container is swapped successfully
What happened instead?

Logs:
Context: default-system, namespace: default, kubectl_command: kubectl
Running: (['kubectl', '--context', 'default-system', 'cluster-info'],)... ran!
Running 'ssh -V'...Running: (['which', 'torsocks'],)... ran!
Running: (['which', 'sshfs'],)... ran!
Running: (['kubectl', '--context', 'default-system', '--namespace', 'default', 'get', 'deployment', '-o', 'json', '--export', 'gateway-service'],)... ran!
Running: (['kubectl', '--context', 'default-system', '--namespace', 'default', 'delete', 'deployment', 'gateway-service'],)... deployment "gateway-service" deleted
 ran!
Running: (['kubectl', '--context', 'default-system', '--namespace', 'default', 'apply', '-f', '-'],)... error: error validating "STDIN": error validating data: found invalid field terminationMessagePolicy for v1.Container; if you choose to ignore these errors, turn validation off with --validate=false

I just verified that the problem does not occur with version 0.58. I downgraded now so I can continue using telepresence 👍

Thanks for the bug report and the workaround. What versions of Kubernetes are you running?
$ kubectl version --short
Client Version: v1.7.2
Server Version: v1.7.0

Ah, that could well be the problem, we're running a relatively old version on the server:
$ kubectl version --short
Client Version: v1.7.0
Server Version: v1.5.6

Should that version be supported still or are my options to keep the downgraded version of telepresence or upgrade kubernetes?

Adding a version check so that you can run the latest Telepresence shouldn't be a problem as long as it's just things like extra fields (terminationMessagePolicy in this case) that are causing the incompatibility. Stay tuned!


Error: API rate limit exceeded for installation ID xx

I was testing out a release config today and possibly due to some misconfig on my part I ended up with
https://github.com/bharathkkb/mono-bp-test/runs/2661822325?check_suite_focus=true
Then subsequent runs showed as passed but actually didn't
https://github.com/bharathkkb/mono-bp-test/runs/2661860431?check_suite_focus=true
Some searching seems to imply this is coming from GH possibly due to release-please querying something however this means I have to wait ( ~1 hr) to continue testing. It would be great if

we could fail after a reasonable number of API calls or allow user configurability
show status correctly in subsequent runs

the error was just cause you didnt specify bootstrap-sha in your release-please-config.json file.

We recently set up this action and were faced with this issue right from the start. While searching for this, I came to know that I may need to add bootstrap-sha considering the fact that we have an existing codebase and not a new one. So I added a .release-please-manifest.json with the following info:
{
  ".": "1.1.1",
  "bootstrap-sha": "last_release_commit_id"
}

But the error doesn't go away.
Moreover, while adding the action to our workflow, we used the default template for the workflow shown in the action documentation and added the following options under with:
release-type: php
package-name: our_package_name

What could we be doing wrong?
Besides, we are not sure what is this installation id?

Same here. I want to use the manifestcommand for my PHP projects but when testing I noticed that the manifest command combined with the  php release type hangs for several minutes until the API limit is spent. using node worked as expected because it is documented. is that document updated @bcoe?
What determinees the calls? One call for each commit made since the last tag?
@junaidbinfarooq I think the installatin ID is a unique repo number.

I have encountered this issue as well with a simple release type.
It worked the first time I added release-please to my ci file (PR created), but it had the wrong version so I closed the PR, updated my tags and tried again. Since then it is no longer working and giving the same API call limit error.
https://github.com/dkarter/dotfiles/runs/6549556709?check_suite_focus=true
Adding the manifest file did not help

I had this problem when adding the action to an existing repo with a Node setup, whereas when I previously tested on a fresh repo with the workflow included from the start it worked fine. You need to get the bootstrapping setup right.
To fix it, I removed the .yml workflow file and essentially stripped the repo of any release-please content (any *release-please* configs if you'd been trying to get them working like I did).
I then created a release-please-config.json file in the repo root with:
{
  "bootstrap-sha": "<THE_BOOTSTRAP_SHA>",
  "release-type": "node",
  "packages": {
    ".": {}
  }
}

Note the bootstrap-sha must be a full SHA.
I also added the.release-please-manifest.json file in the root starting from the version I wanted 2.0.0 with:
{ ".": "2.0.0" }

I then copied the workflow example from the documentation and kept just the release part (good to know you could add deploy or publish after that with if: ${{ steps.release.outputs.releases_created }}).
on:
  push:
    branches:
      - main
name: Run Release Please
jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: google-github-actions/release-please-action@v2
        id: release
        with:
          command: manifest
          token: ${{secrets.GITHUB_TOKEN}}
          default-branch: main

I then created a branch with those changes, and raised a PR to merge that back into the target branch main. The error stopped happening and my releases were created.
Hope that helps.

I am also experiencing this issues - even after adding a
"bootstrap-sha": "8ec612df76d**************66604770"
Any pointers on what to look for ?

I can say I'm facing the same problem with release type "python".

Can someone explain, what types of API calls release please action do?

We're having similar issues. Does a checkout help before running release-please? In the source, I can see it's mostly (entirely?) querying the GitHub API, even for things easily (and much faster) resolvable offline, like searching for merge commits.
Does it fall back to local git if it finds a .git directory? The docs use, if at all, actions/checkout after the release-please step.

I'm also not sure how much bootstrapping can help in an established repo. We've been using release-please for a while now, and have created circa a couple dozen releases already. We have hundreds of version tags which release-please all investigates. If we could ignore most of these (most originate from before adopting release-please), it'd probably greatly help in reducing the number of API calls. However, in the docs on bootstrapping, it says:

Note: once a release-please generated PR has been merged, this config value will be ignored for all subsequent runs and can be removed.

So bootstrapping to limit API calls and time taken (even if it didn't exhaust API limits the release-please job takes about 90s for us) seems a non-starter for already-established repositories. I tested and confirmed this as well; speciyfing a bootstrap-sha of circa a month ago didn't stop the tool from querying all previous releases either.
As far as I can see, the tool even issues API requests for queries like "all merge commits", which could be much easier and faster (disk vs network) via local git calls.

Could we reopen this ticket? I also experience this issue.

The problem is still! Today, March 15, 2023, two months have passed since the request to reopen it.

Can confirm that this is still a problem.

I'm still experiencing the same problem as well

Hey It's June! Just hit this issue. This is not a new repo and release please has been working fine for months now. We triggered it when merging a decent amount of PRs in quick succession (~6ish).

Hey It's June! Just hit this issue. This is not a new repo and release please has been working fine for months now. We triggered it when merging a decent amount of PRs in quick succession (~6ish).

Almost identical story here...

happening right now. for me.

Seeing the same problem. It would make sense to offer the option to use a checkout instead of the API to gather all the data that can be found in the git and only use the API for what is required from Github

same issue

I'm experiencing it too

I've just faced the same issue while trying to setup release-please on my repository for the first time.
Issue
I already had a workflow setup, as below, and the failure happened while running the GitHub Action.
on:
  push:
    branches:
      - main

permissions:
  contents: write
  pull-requests: write

name: release-please

jobs:
  release-please:
    runs-on: ubuntu-latest
    steps:
      - uses: google-github-actions/release-please-action@v3
        with:
          release-type: node
          package-name: cherrypush

My error messages looked the same as the message shared on this thread.

Solution
I've generated a new GitHub token here: https://github.com/settings/tokens
And made sure to provide repo write access, so I can use the token to create PRs.

Then I installed release-please CLI:
npm i release-please -g

And bootstraped it with:
release-please bootstrap \
  --token=$GITHUB_TOKEN \
  --repo-url=cherrypush/cherry-cli \
  --release-type=node \
  --initial-version=1.2.2

Note that I had to set a initial version because my package was already at version 1.2.2. That might not be the case for you.
The command above generated a pull request: https://github.com/cherrypush/cherry-cli/pull/21
I merged the pull request, and the workflow did its job, generating a new PR with the change logs:

https://github.com/cherrypush/cherry-cli/pull/22

Feel free to navigate the repo and reuse whatever fits you. It's open-source and MIT License.
I'm not certain this is the same issue for everyone, but hope it's helpful information anyway 🤗


Cookie Header Error

Here is a list of the videos that could not be downloaded, and the reason why:
https://youtu.be/OQCjakjCJu4?feature=shared Reason: An error occurred when parsing the Cookie header for Uri 'https://www.youtube.com/watch?v=OQCjakjCJu4&bpctr=9999999999&hl=en'.

Yea, this

Hey guys, just give a try to the latest version (1.9.24) and let us know if it works or not. Thanks!


Requests: Simple night mode & static color

Hey there!
I was experimenting with some arduino-ambilight-stuff by myself and could get some nice results, but then I came across your fork of Bambilight and I have to say: great work, mate! Everything works as intended, it is smooth and clear, runs stable (so far) and it's also very efficient (the biggest problem of my own work).
My own software is currently offering two features that I would like to see in your project aswell (because I will continue using yours :-D):

Night mode. You already implemented a night mode, but this only works together with the windows 10 night mode. Since I am preferring f.lux over windows 10 night mode, I would like to see support for f.lux...or, the lazy but still good working way: just add support for enabling night mode depending on the time of day. E.g. automatically change the color temperature as it is getting late in the evening. Of course as an another option for night light mode.
I like having some background light behind my screen, but I don't always want it to react to my screen. E.g. while working, a simple white background is better than actual ambilight. Please add an option to simply turn on a static white color. Also, the color temperature should be selectable (white 2000-6500k).

Greetings from the Sauerland!

Any updates on this? I'm maybe able to do this on my own. How does the adrilight program sends out data to the arduino?
You could basically define a static mode, which only update the color if it's get a new value from the computer.