GoRouter - themeMode update redirects back to initialLocation

Is there an existing issue for this?

[X] I have searched the existing package issues
[X] I have read the guide to filing a bug

What package does this bug report belong to?
go_router
What target platforms are you seeing this bug on?
Android
Have you already upgraded your packages?
Yes
Dependency versions
pubspec.yaml
This issue was reproduced on a brand new flutter app using: flutter create app -e
name: app_3_16_001_beta
description: "A new Flutter project."
publish_to: 'none'
version: 0.1.0

environment:
  sdk: '>=3.2.0-210.1.beta <4.0.0'

dependencies:
  equatable: ^2.0.5
  flutter:
    sdk: flutter
  go_router: ^11.1.4
  provider: ^6.0.5

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_lints: ^2.0.0

flutter:
  uses-material-design: true

Steps to reproduce

Run the provided example app.
Tap the login button to change to the / route (which happens to be the same as the initialRoute).
Tap the 'Go to Screen Prefs' button to switch to a route that's not the initialLocation.
Tap the 'Toggle Dark Mode' button to have the app change its themeMode.

Expected results
The themeMode should update.
The app should remain on the current screen.
Actual results
The themeMode updates, but this triggers a rebuild of the MaterialApp.router;

which reinits the routerConfig,
which reinits the initialLocation and redirect properties,
which brings the app back to the initialLocation (or the redirect path),
which appears to result in a loss of whatever routing stack there may have been prior to the themeMode change.

Code sample
Code sample
DartPad w/ Gist
GitHub Gist

Screenshots or Videos
No response
Logs
Logs
No errors were reported.

Flutter Doctor output
Doctor output
[√] Flutter (Channel beta, 3.16.0-0.1.pre, on Microsoft Windows [Version 10.0.22621.2428], locale en-US)
    • Flutter version 3.16.0-0.1.pre on channel beta at C:\dev\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f0abad66b2 (3 days ago), 2023-10-10 19:29:41 -0700
    • Engine revision 7ccdde78a7
    • Dart version 3.2.0 (build 3.2.0-210.1.beta)
    • DevTools version 2.28.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\apps\Android\Sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = C:\apps\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop Windows apps
    X Visual Studio not installed; this is necessary to develop Windows apps.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2022.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)

[√] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554 • android-x64    • Android 13 (API 33) (emulator)
    • Windows (desktop)            • windows       • windows-x64    • Microsoft Windows [Version 10.0.22621.2428]
    • Chrome (web)                 • chrome        • web-javascript • Google Chrome 117.0.5938.152
    • Edge (web)                   • edge          • web-javascript • Microsoft Edge 117.0.2045.60

[√] Network resources
    • All expected network resources are available.

Thanks for the report @KDCinfo
From the code sample you shared, it seem to be using third party packages like bloc and flutter_bloc. In order to properly narrow down the issue in go_router package, can you confirm if the reported behavior still persists without using the third party code implementation ?

Thanks for the updated repo. I was able to replicate the reported behavior.

 stable, master flutter doctor -v
[!] Flutter (Channel stable, 3.13.6, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 3.13.6 on channel stable at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ead455963c (5 days ago), 2023-09-26 18:28:17 -0700
    • Engine revision a794cf2681
    • Dart version 3.1.3
    • DevTools version 2.25.0
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.16.0-11.0.pre.92, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 3.16.0-11.0.pre.92 on channel master at
      /Users/dhs/documents/fluttersdk/flutter
    ! Warning: `flutter` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/flutter, which is not inside
      your current Flutter SDK checkout at
      /Users/dhs/documents/fluttersdk/flutter. Consider adding
      /Users/dhs/documents/fluttersdk/flutter/bin to the front of your path.
    ! Warning: `dart` on your path resolves to
      /Users/dhs/Documents/Fluttersdk/flutter/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/dhs/documents/fluttersdk/flutter.
      Consider adding /Users/dhs/documents/fluttersdk/flutter/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f69e45c4bb (80 minutes ago), 2023-10-16 23:32:13 -0400
    • Engine revision 6855e78a1a
    • Dart version 3.3.0 (build 3.3.0-29.0.dev)
    • DevTools version 2.28.1
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/dhs/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for
      more details.

[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13C100
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] IntelliJ IDEA Ultimate Edition (version 2021.3.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 65.1.4
    • Dart plugin version 213.7228

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.29.0

[✓] Connected device (3 available)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 15.3.1 19D52
    • macOS (desktop)           • macos                                    •
      darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 109.0.5414.119

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

I have the same problem. I added go_router to flutter skeleton app.

The GoRouter object is stateful, you need to store it into a permanent variable
In the original code, the buildRouter is called every time the theme changes, that cause the GoRouter to be created from scratch.

Could you possibly provide an example of how that would work (perhaps based on the provided code example)?

I tried changing the buildRouter method to a variable (final buildRouter = GoRouter() and calling the context.watch directly within the variable assignment, but it has issues in that using context.watch throws an exception, and context.read doesn't change the screen.

Also, I'm unaware of the protocol for if anyone comments or responds to closed tickets; should I open a new ticket with this last question?

Also, I'm unaware of the protocol for if anyone comments or responds to closed tickets; should I open a new ticket with this last question?

I think this is fine since it is not locked
Can you do context.watch inside the redirect directly?
      redirect: (context, nextState) {
        return !context.watch<AuthModel>().isAuth
            ? '/auth'
            : nextState.fullPath == '/auth'
                ? '/'
                : null;
      },

I think this is fine since it is not locked

Good to know. Thanks!

Can you do context.watch inside the redirect directly?

No. It throws an exception.
Exception has occurred.
_AssertionError ('package:provider/src/provider.dart': Failed assertion: line 274 pos 7: 'context.owner!.debugBuilding ||
          listen == false ||
          debugIsInInheritedProviderUpdate': Tried to listen to a value exposed with provider, from outside of the widget tree.

This is likely caused by an event handler (like a button's onPressed) that called
Provider.of without passing `listen: false`.

To fix, write:
Provider.of<AuthModel>(context, listen: false);

It is unsupported because may pointlessly rebuild the widget associated to the
event handler, when the widget tree doesn't care about the value.

The context used was: Router<Object>(dependencies: [UnmanagedRestorationScope, _InheritedProviderScope<AuthModel?>], state: _RouterState<Object>#2fbf4)
)

This seems like a provider bug that the assert is too strict

The way I did it, is defined GoRouter outside MainApp and inject it in
void main() {
  final router = GoRouter(
  ...
  );
  runApp(const MainApp(router: router));
}

class MainApp extends StatelessWidget {
  const MainApp({
    super.key,
    required this.router
  });
  final GoRouter router;

  ...
  return MaterialApp.router(
    ...
    routerConfig: router,
    ...
  );
  ...
}

And that did work, or still no?

Yup worked

Will give it a shot!

Oh wait, that's what I just tried. Are you accessing a dynamic value within the GoRouter config, like context.watch or a bloc listener (i.e. context.select)?

In my case I don't do routing in config. I just do context.go outside of it. Inside config, I use router.go in case of exceptions

I tried moving the router config assignment above the enter MainApp, and within the main as you have it, but the issue comes back down to the redirect throwing an error when trying to access its context param with a listener (e.g. .watch).
Perhaps this issue should be renamed to indicate a more specific issue with accessing a dynamic context-related value within the GoRouter's redirect property?

Updated code: moved config assignment
void main() {
  final navigatorKey = GlobalKey<NavigatorState>();

  GoRouter buildRouter = GoRouter(
    navigatorKey: navigatorKey,
    initialLocation: '/',
    routes: [
      GoRoute(
        path: '/',
        builder: (context, state) => const ScreenHome(),
      ),
      GoRoute(
        path: '/auth',
        builder: (context, state) => const ScreenAuth(),
      ),
      GoRoute(
        path: '/prefs',
        builder: (context, state) => const ScreenPrefs(),
      ),
    ],
    redirect: (context, nextState) {
      return !context.watch<AuthModel>().isAuth
          ? '/auth'
          : nextState.fullPath == '/auth'
              ? '/'
              : null;
    },
  );
  runApp(MainApp(
    buildRouter: buildRouter,
  ));
}

class MainApp extends StatelessWidget {
  const MainApp({super.key, required this.buildRouter});

  final GoRouter buildRouter;

  @override
  Widget build(BuildContext context) {
    return ChangeNotifierProvider(
      create: (context) => AuthModel(),
      child: Builder(builder: (context) {
        return MaterialApp.router(
          // routerConfig: buildRouter(
          //   authModel: context.watch<AuthModel>(),
          // ),
          routerConfig: buildRouter,
          title: 'App Title',
          theme: ThemeData(
            brightness: Brightness.light,
          ),
          darkTheme: ThemeData(
            brightness: Brightness.dark,
          ),
          themeMode:
              context.select((AuthModel model) => model.isDark) ? ThemeMode.dark : ThemeMode.light,
        );
      }),
    );
  }
}

class AuthModel extends ChangeNotifier {
  bool isAuth = false;
  bool isDark = false;

  void toggleAuth() {
    isAuth = !isAuth;
    notifyListeners();
  }

  void toggleDark() {
    isDark = !isDark;
    notifyListeners();
  }
}

class ScreenAuth extends StatelessWidget {
  const ScreenAuth({super.key});

  @override
  Widget build(BuildContext context) {
    final authModel = context.watch<AuthModel>();
    return Scaffold(
      appBar: AppBar(
        title: Text('Screen: [Auth] - isAuth: ${authModel.isAuth}'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.start,
          children: [
            const Padding(
              padding: EdgeInsets.symmetric(vertical: 32),
              child: Text('Auth Screen', style: TextStyle(fontWeight: FontWeight.bold)),
            ),
            ElevatedButton(
              onPressed: () {
                authModel.toggleAuth();
              },
              child: const Text('Log in'),
            ),
          ],
        ),
      ),
    );
  }
}

class ScreenHome extends StatelessWidget {
  const ScreenHome({super.key});

  @override
  Widget build(BuildContext context) {
    final authModel = context.watch<AuthModel>();
    return Scaffold(
      appBar: AppBar(
        title: Text('Screen: [Home] - isAuth: ${authModel.isAuth}'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.start,
          children: [
            const Padding(
              padding: EdgeInsets.symmetric(vertical: 32),
              child: Text('Home Screen', style: TextStyle(fontWeight: FontWeight.bold)),
            ),
            ElevatedButton(
              onPressed: () {
                context.push('/prefs');
              },
              child: const Text('Go to Screen Prefs'),
            ),
            const SizedBox(height: 16),
            ElevatedButton(
              onPressed: () {
                authModel.toggleDark();
              },
              child: const Text('Toggle Dark Mode'),
            ),
          ],
        ),
      ),
    );
  }
}

class ScreenPrefs extends StatelessWidget {
  const ScreenPrefs({super.key});

  @override
  Widget build(BuildContext context) {
    final authModel = context.watch<AuthModel>();
    return Scaffold(
      appBar: AppBar(
        title: Text('Screen: [Prefs] - isAuth: ${authModel.isAuth}'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.start,
          children: [
            const Padding(
              padding: EdgeInsets.symmetric(vertical: 32),
              child: Text('Prefs Screen', style: TextStyle(fontWeight: FontWeight.bold)),
            ),
            ElevatedButton(
              onPressed: () {
                authModel.toggleDark();
              },
              child: const Text('Toggle Dark Mode'),
            ),
          ],
        ),
      ),
    );
  }
}

According to the code, the provider should be above the context in redirect. I think the issue is context.watch doesn't allow being called during build phase. I am not sure why. But this looks like an issue in provider

Could be. I don't know enough about how it all works to know where or what the issue might be.
I've tried a variety of things, but have begun to move towards an alternative approach that stores each screen's path in a bloc, and compare it in the redirect to what GoRouter says the route is. If GoRouter says it's at /, but the bloc is at /prefs, then the redirect will use the path in the bloc's state.

New approach using bloc to store paths for comparison in the GoRouter `redirect` property:
class MainApp extends StatelessWidget {
  const MainApp({super.key});

  GoRouter buildRouter({
    required UserBloc userBloc,
  }) {
    return GoRouter(
      initialLocation: '/',
      routes: [
        // ...,
      ],
      refreshListenable: RefreshStream(
        userBloc.stream.map((UserState state) => state.isAuth),
      ),
      redirect: (context, nextState) {
        return !userBloc.state.isAuth
            ? '/auth'
            // : nextState.fullPath != userBloc.state.currentPath
            : nextState.fullPath == '/' && userBloc.state.currentPath == '/prefs'
                ? userBloc.state.currentPath
                : null;
      },
    );
  }

  @override
  Widget build(BuildContext context) {
    return BlocProvider(
      create: (context) => UserBloc(),
      child: Builder(builder: (context) {
        return MaterialApp.router(
          routerConfig: buildRouter(
            userBloc: context.watch<UserBloc>(),
          ),
          title: 'App Title',
          theme: ThemeData(brightness: Brightness.light),
          darkTheme: ThemeData(brightness: Brightness.dark),
          themeMode: context.select((UserBloc bloc) => bloc.state.isDark)
              ? ThemeMode.dark
              : ThemeMode.light,
        );
      }),
    );
  }
}

class ScreenHome extends StatelessWidget {
  const ScreenHome({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Screen: [Home] - isAuth: ${context.read<UserBloc>().state.isAuth}'),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.start,
          children: [
            const Padding(
              padding: EdgeInsets.symmetric(vertical: 32),
              child: Text('Home Screen', style: TextStyle(fontWeight: FontWeight.bold)),
            ),
            ElevatedButton(
              onPressed: () {
                /// This will update the path in the bloc.
                context.read<UserBloc>().setPath('/prefs');
              },
              child: const Text('Go to Screen Prefs'),
            ),

Because this is only an issue when switching the themeMode property, although a bit more work to store each path in the bloc for comparison, this appears to be an acceptable path forward, at least for my current need.
Thanks to you both for your input on all this.

A maneira como eu fiz isso, é definido GoRouter fora do MainApp e injetá-lo
void main() {
  final router = GoRouter(
  ...
  );
  runApp(const MainApp(router: router));
}

class MainApp extends StatelessWidget {
  const MainApp({
    super.key,
    required this.router
  });
  final GoRouter router;

  ...
  return MaterialApp.router(
    ...
    routerConfig: router,
    ...
  );
  ...
}

This solution worked for me too, thanks for sharing.

Another approach, which I aim to go with, is to ignore the themeMode and redirect altogether, and wrap each routable scaffold-based screen with a Theme; then do the themeMode detection based on brightness at that level. (Leave the redirect for just the isAuth.)

The Theme.of(context) method looks up the widget tree and retrieves the nearest Theme in the tree. If you have a standalone Theme, that’s applied. If not, Flutter applies the app’s theme. - Flutter Docs

If you want a component of your app to ignore the overall theme, create a ThemeData instance. Pass that instance to the Theme widget. - Flutter Docs

class MainApp extends StatelessWidget {
  const MainApp({super.key});

  @override
  Widget build(BuildContext context) {
    return BlocProvider(
      create: (context) => UserBloc(),
      child: Builder(builder: (context) {
        return MaterialApp.router(
          routerConfig: buildRouter(
            /// @Note: The `userBloc` is only used for the `isAuth` listener
            ///        (i.e. the `refreshListenable` property).
            userBloc: context.read<UserBloc>(),
          ),
          title: 'App Title',
          // theme: ThemeData(
          //   brightness: Brightness.light,
          // ),
          // darkTheme: ThemeData(
          //   brightness: Brightness.dark,
          // ),
          // themeMode: context.select((UserBloc bloc) => bloc.state.isDark)
          //     ? ThemeMode.dark
          //     : ThemeMode.light,
        );

class ScreenPrefs extends StatelessWidget {
  const ScreenPrefs({super.key});

  @override
  Widget build(BuildContext context) {
    return Theme(
      data: ThemeData(
        /// @Note: The `context.select` could be moved up to the `data`  property
        ///        to swap out the entire `ThemeData`.
        brightness: context.select((UserBloc bloc) => bloc.state.isDark)
            ? Brightness.dark
            : Brightness.light,
      ),
      child: Scaffold(


[BUG] enum members are not sorted alphabetically

Describe the bug
they aren't sorted alphabetically and they should be

:tada: This issue has been resolved in version 1.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


test: add a page with link to external markdown content

Description
The feedback after merging #186 was to use the content in markdown to match the format of the source content. This PR tests if markdown content with shortcodes (:smile:) renders successfully.
Related

#186

Checklist
Before submitting a Pull Request, please ensure the following:

[x] 🚨 This PR does not introduce breaking changes.
[ ] All CI checks (GH Actions) pass.
[x] Code is well-commented, especially in complex areas.
[x] Git history is clean — commits are squashed to the minimum necessary.

I will take the liberty to merge this PR. In case of any issues, I will quickly revert the changes!


[Feature Request] Any solution to highlight a\some date-range(s) but no affect to any action?

Existing Component
Yes
Component Name
datepicker
Description
The scenario is we need mark some date(s) highlights for user reference (such as mark up public holidays), but we don`t want to make any changes for action and behaviour to the calendar.
Such as Jan-1st to Jan-3rd is a public holiday, we wanna to display these dates as red background, but only presenting update, it still allow the user to select and when user select the date, all other actions follow what currently implemented.
Thanks for any suggestions.

没有提供相关支持。建议尝试操作 DOM 并修改 CSS。

https://github.com/charliekassel/vuejs-datepicker


Remove node 14 support

What does this PR do?
dd-trace is not supportnig node 14 anymore, removing builds for it and setting min supported version to node 16.

Motivation

Reduce package size.

@CarlesDD

Can we get rid of this directive now?

I don't think so, node 16 is still supported, and this check is checking that node is 16, not that is >16.


change archive type detection to use content disposition

fixes #246

Cool bug! would it more future proof if we were to detect the magic number of the download stream to decide the file types ?


How to set ParaView

I am a freshman in this field, and I wanna ask that how to set ParaView to display.

One simple operation for visualizing the result is to create a "Clip" along the heated region. You may refer to the official ParaView docs for other operations that suit your need.

I generate the .vtk files with Liver_Iso.txt in the models, and I wan to see a colorful display. But as you can see, I got a blue one. How can I fix it or change the data to get a colorful one. Thanks a lot!


Finalize the diagnostic engine if an error is thrown

Bug/issue #, if applicable: rdar://110782381
Summary
If an error is thrown before the documentation converter completes successfully, the diagnostic engine is never finalized. This means that diagnostic consumers that gather and write diagnostic as two separate steps won't write any diagnostics.
This PR changes that so that the diagnostic engine is finalized before the documentation converter returns from convert(...). It also makes the finalization synchronous so that callers can rely on any diagnostics having been written after `convert(...) ends—either successfully or with a thrown error.
Dependencies
None
Testing

Run docc convert with a --diagnostics-file /path/to/some-file.json and some content that result in an unexpected error (for example a symbol graph file with relationships but no symbols).

After the failed documentation build, the diagnostic file should have been created.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[ ] Ran the ./bin/test script and it succeeded
[ ] Updated documentation if necessary

@swift-ci please test

@swift-ci please test


Adds PyPI auto-deploy

fix #117

Coverage remained the same at 85.358% when pulling 3cb48f8506d722449947bd89b74665a647193672 on jtemporal-add-auto-deployment into 1ab0112086f948cd6075d4e37a1a34009cd34a2b on master.

Hey @jtemporal ! Is there any way to test it without really deploy to pypi?

Is there any way to test it without really deploy to pypi?

@lipemorais I'm looking into that right now! I'm not quite sure of that. And is definitely something necessary

Coverage remained the same at 85.358% when pulling e1860f16dce2ac8d55448efcdaddc61e05f64a90 on jtemporal-add-auto-deployment into 1ab0112086f948cd6075d4e37a1a34009cd34a2b on master.


Example not working

I've tried to run the example and pushed to a github page to see it in action on touch devices, but the drag and drop is not working properly:
https://cagarweyne.github.io/touch/
I've basically followed the steps for building the example from the repo, maybe I'm missing something?

Same here. Wonder if this is related to #34

It's working for me if I drag onto the text of another item.
Have you tried adding a background color to each item in the list?
It might not be detecting touches on the fully transparent parts of the item


use BasicAer instead of Aer

Aer is not currently a requirement of Ignis, but the topological codes use it. This causes Ignis import fail in case of no Aer availability. This fixes that to use BasicAer instead.

@mtreinish ok i did what you suggested.

When falling into BasicAer, I think it's important to display a warning, at least in the log. We've had cases in the past, when this automatic fall was more common, where users were not aware that their Aer was badly installed and therefore did not understand why the code was slow. Also, can consider to have Aer as a requirement to Ignis. As Ignis evolves, it seems natural that some verification algorithms will include simulations.

Yes a fallback used to lead to confusion before but then we started displaying an even stronger warning at the import qiskit level so whenever you try to use qiskit without Aer you get a warning.


bottom type can be a number only

also getattr doesn't work for me

In which case would bottom_type not be of type WellBottomType? I think that's the underlying issue.

My generated json save file contains entries that say bottom_type: 1
If I try importing them without this fix I get an error

This was actually an issue with the deserializer/initializer. Fixed with https://github.com/PyLabRobot/pylabrobot/commit/6dbff8d534663c7c4a20fe1e22b5d1357fd8d369. (the raw value in the JSON doesn't really matter, but made it a string for clarity)


Can I use this library also without Internet connection?

So for example can I use a local NTP server to get Time, Date and Timezone?

Can you add an example for this please?


._.DS_Store Image Not Found in gtf.Train(num_epochs=3) YOLO

Getting the following Assertion Error while training model for Object Detection in YOLO Format
To reach the colab file, click here
Executing Line : gtf.Train(num_epochs=3)
Using CUDA Apex device0 _CudaDeviceProperties(name='Tesla K80', total_memory=11441MB)

Using multi-scale 288 - 640
Caching labels (3135 found, 0 missing, 935 empty, 0 duplicate, for 4071 images): 100%|██████████| 4070/4070 [00:00<00:00, 5703.77it/s]
Caching labels (3135 found, 0 missing, 935 empty, 0 duplicate, for 4071 images): 100%|██████████| 4070/4070 [00:00<00:00, 6226.00it/s]Model Summary: 222 layers, 6.15291e+07 parameters, 6.15291e+07 gradients
Using 2 dataloader workers
Starting training for 3 epochs...

     Epoch   gpu_mem      GIoU       obj       cls     total   targets  img_size

  0%|          | 0/2035 [00:00<?, ?it/s]/usr/local/lib/python3.6/dist-packages/torch/cuda/memory.py:346: FutureWarning: torch.cuda.memory_cached has been renamed to torch.cuda.memory_reserved
  FutureWarning)
       0/2     1.97G      6.18      3.94       132       142         9       512:   6%|▌         | 115/2035 [01:21<24:56,  1.28it/s]
---------------------------------------------------------------------------
AssertionError                            Traceback (most recent call last)
<ipython-input-38-54da62eea228> in <module>()
----> 1 gtf.Train(num_epochs=3)

6 frames
/usr/local/lib/python3.6/dist-packages/torch/_utils.py in reraise(self)
    393             # (https://bugs.python.org/issue2651), so we work around it.
    394             msg = KeyErrorMessage(msg)
--> 395         raise self.exc_type(msg)

AssertionError: Caught AssertionError in DataLoader worker process 1.
Original Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/worker.py", line 185, in _worker_loop
    data = fetcher.fetch(index)
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/_utils/fetch.py", line 44, in <listcomp>
    data = [self.dataset[idx] for idx in possibly_batched_index]
  File "/content/Monk_Object_Detection/7_yolov3/lib/utils/datasets.py", line 435, in __getitem__
    img, labels = load_mosaic(self, index)
  File "/content/Monk_Object_Detection/7_yolov3/lib/utils/datasets.py", line 554, in load_mosaic
    img, _, (h, w) = load_image(self, index)
  File "/content/Monk_Object_Detection/7_yolov3/lib/utils/datasets.py", line 527, in load_image
    assert img is not None, 'Image Not Found ' + img_path
AssertionError: Image Not Found /content/hand_dataset/training_dataset/training_data/images/._.DS_Store

Total 2 such files were generated- ._.DS_Store and .DS_Store. Removing them solved the issue.
One can check for other files using
ls -a


feat(core): add "field mapper" which maps non MFF fields to MFF ones

This makes no sense since its best to always map those fields with custom script before passing to MF


fix Gradle 2.14 compatibility

This change makes the plugin use a snapshot version of the download task, which fixes an issue with Gradle 2.14. See https://github.com/michel-kraemer/gradle-download-task/issues/49 for details.
If you like, you can postpone this PR until the fixed version is available as proper release. I have a watch on the referenced issue nevertheless ;-)

thanks for this fix, however, I'd like to wait for an official release of the download task rather than use a snapshot version

@amirkibbar the 3.1.0 release is available now, which contains the fix for Gradle 2.14 compatibility.


phunk 5822

issue on #5822 error message says may fail trying to bid or purchase it"

Seems to be resolved


Some 'font-family' properties in the workbench CSS not work as expected due to lack of quotation marks

VSCode Version: 1.1 stable
OS Version: OS X 10.11.4

I tried to add '.SFNSDisplay-Light' value into the font-family property since 'SFUIText-Light' value does not work on latest OS X.
During the building process, quotation marks / apostrophes wrapping font names are removed. '.SFNSDisplay-Light' without quotation marks does not resolve to the font as expected, so Helvetica is used instead. After I add quotation marks back, it works.

What do you mean with during the building process? Where did you add that value?

@joaomoreno maybe this is due to our CSS optimizer that we run during the build? It might remove quotes from font families to minimize the CSS content.

@bpasero got my idea. There are quotation marks in CSS source cod, but nothing in workbench.main.css.

I see what you mean. The minifier does remove the quotes... but that is OK, the browser still parses it:

Names start with punctuation characters or digits (like ".SFNSDisplay")
must be wrapped with quotes to get parsed. According tow this article.
https://developer.mozilla.org/en-US/docs/Web/CSS/font-family (look at
"valid family names" section）
2016年6月2日 23:51，"João Moreno"<EMAIL_ADDRESS>I see what you mean. The minifier does remove the quotes... but that is OK,
the browser still parses it:
[image: image]
https://cloud.githubusercontent.com/assets/22350/15751465/7c19efd4-28ea-11e6-8ebc-21768da7d8d2.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/7122#issuecomment-223334761,
or mute the thread
https://github.com/notifications/unsubscribe/ABnEvG4G-THq8B1dedXsJzPzQetMU2FTks5qHvvwgaJpZM4IsTAX
.

punctuation characters and digits at the start of each token must be escaped in unquoted font family names

The dot . is escaped with a backslash in the minified version, that's why it works.

@joaomoreno OK. I've learned that. Thanks.


ORC-1274: Add a checkstyle rule to ban starting LAND and LOR

What changes were proposed in this pull request?
This PR aims to add a new check style rule to ban staring LAND and LOR to improve Java coding style.
Why are the changes needed?
Currently, Apache ORC has a mixed style and this PR proposes to change like the following to be consistent. Note that this is focusing on the position of the logical AND and OR operators instead of changing the indentation.
-    if (n >= FixedBitSizes.ONE.ordinal()
-        && n <= FixedBitSizes.TWENTYFOUR.ordinal()) {
+    if (n >= FixedBitSizes.ONE.ordinal() &&
+        n <= FixedBitSizes.TWENTYFOUR.ordinal()) {

-        if (values[offset].equalsIgnoreCase("true")
-            || values[offset].equalsIgnoreCase("t")
-            || values[offset].equals("1")) {
+        if (values[offset].equalsIgnoreCase("true") ||
+            values[offset].equalsIgnoreCase("t") ||
+            values[offset].equals("1")) {

-    return readPhase.contains(child.getReaderCategory())
-           || child.getReaderCategory() == ReaderCategory.FILTER_PARENT;
+    return readPhase.contains(child.getReaderCategory()) ||
+           child.getReaderCategory() == ReaderCategory.FILTER_PARENT;

How was this patch tested?
Pass the CIs with the newly added checkstyle rule.

Could you review this PR, @williamhyun and @guiyanakuang ?

+1 LGTM

Thank you, @guiyanakuang ! Merged to main.


Add include directories to OpenTimeConfig.cmake/OpenTimelineIOConfig.cmake

The auto-generated OpenTimeConfig.cmake/OpenTimelineIOConfig.cmake files are missing the include directories for the OTIO headers which makes compiling C++ programs difficult. This can be fixed by adding the "INCLUDES" argument to the install command for OpenTime/OpenTimelineIO. I'll submit a PR with the proposed change...

closed by https://github.com/PixarAnimationStudios/OpenTimelineIO/commit/600a9d758b7633ab341448caa410152eef6da3f8


Update ThreadX RTOS documentation

Close #7
Close #8

threadx/chapter2.md:
Replace duplicate of TX_BYTE_POOL_ENABLE_PERFORMANCE_INFO and its description with TX_BLOCK_POOL_ENABLE_PERFORMANCE_INFO.
threadx/ascii-character-codes-hex.png:
Replace 0x7B character: open curly bracket instead of close curly bracket.
threadx/chapter3.md:
Fix 'Memory Block Pools' header level (h3 -> h2).
threadx/chapter4.md
Fix 'tx_event_flags_performance_info_get' header level (h3 -> h2).
filex/chapter3.md
Correct the typos.

Thank you for those fixes, @neitsmarr. We appreciate your contributions.


Add fixes and updates for release-0.0

Adds fixes and updates for release-0.0.
Includes a (now) public Zenodo download link to acquire a pre-trained protein-nucleic acid sequence-structure model checkpoint.

@jeffreyruffolo, it looks like I can't merge this into main without write access. Would you be able to take a look at that when you get a chance?


[Flaky Test] Azure.Monitor.OpenTelemetry.Exporter.Tests.AzureMonitorExporterEventSourceTests.VerifyEventSource_Error_WithAggregateException

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1622893&view=ms.vss-test-web.build-test-results-tab&runId=32288564&resultId=115491&paneView=debug

Label prediction was below confidence level 0.6 for Model:CategoryLabels: 'Mgmt:0.5557361,Client:0.40559825,Service:0.033468973'

/cc @TimothyMothra

@JoshLove-msft this should be resolved now.
Please let me know if you see any more issues.
Thanks!

@JoshLove-msft this should be resolved now. Please let me know if you see any more issues.
Thanks!

Thank you for the quick fix!


Add t-shirt sizing for Azure instances

We have come up with t-shirt sizes for dedicated instances where each size maps to specific instance types for compute & database, so that we can control our costs, charge customers accordingly, and standardize across the fleet. That configuration is driven from TF. It's already effected for AWS in production so all instances are on a t-shirt size relevant to each customer. But we are yet to make that change for Azure. We need to implement, test and integrate end to end. See the screenshot for the per t-shirt size configuration:

Linked with wrong project so closing this and created new issue with correct project linked.


FR: QR Code showing your pub key to others can scan your QR code and add you

On your personal profile, when you click the share button, have an option to display a QR code so others can add you. I was at an event tonight where Damus users were able to do this with each other, but there was no easy way in person for people to share their pubkey with strangers.
IIRC (saw it for less than 2 seconds) Damus does it in the format of nostr:$pubkey like an href, likely worth emulating that so it's cross client compatible.

In the side menu you can generate and read qr code

doh, where were you yesterday? :D   Thanks!
Maybe the QR code should be the bottom half of that screen instead of an extra click to make it more intuitive


Typo: 'notificatins'

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

I'm a little uncertain; should I agree to a CLA for this?  Thanks!

@object88, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot


Updated and unified fastlane description

Also fastlane.tools update https://github.com/fastlane/fastlane.tools/pull/22

👍 LGTM


Silver snapshot stake program accounts 2

Add silver.snapshot_stake_accounts_2

Can do comparison with existing by epoch after it runs a few times

Add workflow schedule

FR and test on M
13:45:39  Finished running 1 incremental model, 8 data tests, 11 project hooks in 0 hours 0 minutes and 32.12 seconds (32.12s).
13:45:40
13:45:40  Completed successfully
13:45:40
13:45:40  Done. PASS=9 WARN=0 ERROR=0 SKIP=0 TOTAL=9

Incremental and test on M
13:47:21  Finished running 1 incremental model, 8 data tests, 11 project hooks in 0 hours 0 minutes and 35.30 seconds (35.30s).
13:47:21
13:47:21  Completed successfully
13:47:21
13:47:21  Done. PASS=9 WARN=0 ERROR=0 SKIP=0 TOTAL=9

Data in DEV
select *
from solana_dev.silver.snapshot_stake_accounts_2;

Really like the use of invocation_id!


Checkboxes are not checked with lazy default values + Material UI

Bug Report
Describe the Bug
When using Material UI + lazy default values,  checkboxes & radio buttons are not checked.
How to Reproduce
Add a MUI checkbox to a form, and set corresponding field to true by lazy default values.
Please see sandbox link below.
CodeSandbox Link
https://codesandbox.io/s/rcf-material-ui-lazy-default-5e0uq
Expected Behavior
The checkbox should be checked initially.
Your Environment

OS: MacOS
Browser: Chrome
Version: 89

@derekshih Thank you for giving this library a try. Because the <Checkbox /> and <RadioGroup /> are designed as controlled component, so we need to initialize the UI as below:
    <FormControlLabel control={<Checkbox />} name="single" label="single" />
+  <FormControlLabel control={<Checkbox defaultChecked />} name="single" label="single" />

    <RadioGroup name="mood" aria-label="mood" row>
+  <RadioGroup name="mood" aria-label="mood" row defaultValue="😊">


[HUDI-1468] Support custom clustering strategies and preserve commit …

…metadata as part of clustering
Fix clustering tests with commit metadata
Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@codope  Can you help tag places you made code changes on top of sk/clusteringImprovements branch ? This is a big PR, so it'll help me understand your changes better.


Add python3-distro to Dunfell

Issue #, if available:
Fixes https://github.com/aws/meta-aws/issues/95
Description of changes:
Added python3-distro package to zeus as an external recipe
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you for your contribution!!

Thank you for your contribution!!


Android notifaction crash on  silent: true

Hi, when i configure   silent: true  then when app go to background it's cause problems with android's notification bar, and close it or make app and android slowly, but when silent:false, app there are no problem with android... any idea ?
thanks

dansanti, did you ever figure this out? Same thing is happening on my app.


When starting the application, MediaQuery.of(context).size.width is 0, resulting in a persistent white screen

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
When starting the application, MediaQuery.of(context).size.width is 0, resulting in a persistent white screen
Expected results
When starting the application, MediaQuery.of(context).size.width is 0, resulting in a persistent white screen
Actual results
When starting the application, MediaQuery.of(context).size.width is 0, resulting in a persistent white screen
Code sample
import 'dart:async';
import 'dart:io';

import 'package:bot_toast/bot_toast.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_localizations/flutter_localizations.dart';
import 'package:get/get.dart';
import 'package:pms_mobile/global.dart';
import 'package:pms_mobile/i18n/index.dart';
import 'package:pms_mobile/pages/not_found/index.dart';
import 'package:pms_mobile/pages/setting/appearance.dart';
import 'package:pms_mobile/pages/setting/language.dart';
import 'package:pms_mobile/store/index.dart';
import 'package:pms_mobile/theme.dart';
import 'package:pms_mobile/utils/index.dart';

import 'routes/index.dart';

final botToastBuilder = BotToastInit();

Future<void> main() async {
  runZonedGuarded<Future<void>>(() async {
    try {
      WidgetsFlutterBinding.ensureInitialized();
      await Global.init();
      runApp(const MyApp());
      if (Platform.isAndroid) {
        SystemUiOverlayStyle systemUiOverlayStyle = const SystemUiOverlayStyle(
          statusBarColor: Colors.transparent,
          // systemNavigationBarColor: Color.fromRGBO(53, 64, 85, 1),
        );
        SystemChrome.setSystemUIOverlayStyle(systemUiOverlayStyle);
      }
    } catch (e) {
      print(e);
    }
  }, (error, stack) {
    UtilLog.error('runZonedGuarded', error, stack: stack);
  });
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    print(MediaQuery.of(context).size.width);
    print(MediaQuery.of(context).size.height);
    return GetMaterialApp(
      unknownRoute: GetPage(name: '/404', page: () => const NotFoundPage()),
      translations: TranslationService(),
      localizationsDelegates: const [
        GlobalMaterialLocalizations.delegate,
        GlobalWidgetsLocalizations.delegate,
        GlobalCupertinoLocalizations.delegate,
      ],
      locale: EnumLanguageMode.getMode(AppStore.to.appConfig.language),
      supportedLocales: const [
        Locale('zh', 'CN'),
        Locale('en', 'US'),
      ],
      fallbackLocale: const Locale('zh', 'CN'),
      initialRoute: AppPages.initial,
      getPages: AppPages.routes,
      theme: AppTheme.light(),
      darkTheme: AppTheme.dark(),
      themeMode: EnumThemeMode.getMode(AppStore.to.appConfig.themeMode),
      debugShowCheckedModeBanner: false,
      navigatorObservers: [BotToastNavigatorObserver()],
      builder: (context, child) {
        print('build');
        child = botToastBuilder(context, child);
        return child;
      },
    );
  }
}

import 'package:flutter/services.dart';
import 'package:get/get.dart';
import 'package:pms_mobile/service/index.dart';
import 'package:pms_mobile/store/index.dart';
import 'package:pms_mobile/utils/index.dart';

class Global {
  static Future<void> init() async {
    try {
      await Get.putAsync(() => StorageService().init());
      Get.put<AppStore>(AppStore());
      Get.put<HttpService>(HttpService());
      Get.put<UserStore>(UserStore());
      await _initNotificationService();
      await SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp, DeviceOrientation.portraitDown]);
      // checkAppVersion();
    } catch (e) {
    }
  }
}

_initNotificationService() async {
  try {
    print('_initNotificationService');
    Get.put<NotificationService>(NotificationService());
    await NotificationService.to.createNotificationChannel(kAndroidChannelNewMessage);
  } catch (e) {
  }
}

Screenshots or Video
error

Logs
Logs
[Paste your logs here]

Flutter Doctor output

Hi @laterdayi
In order to address the issue properly, please provide a completed and minimal reproducible code sample that doesn’t include 3rd party plugins or complex production code so that we may verify this.
Please provide the information (flutter doctor output) in text format instead of a screenshot for better readability.
Thank you!

@huycozy  Even with the newly created flutter project, this problem persists,

After I cloned the project, I did nothing but print MediaQuery.of(context).size

Flutter assets will be downloaded from https://storage.flutter-io.cn. Make sure you trust this source!
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel stable, 3.16.3, on Microsoft Windows [版本 10.0.19045.3693], locale zh-CN)
    ! Warning: `flutter` on your path resolves to E:\fvm\versions\stable\bin\flutter, which is not inside your current
      Flutter SDK checkout at E:\fvm\default. Consider adding E:\fvm\default\bin to the front of your path.
    ! Warning: `dart` on your path resolves to E:\fvm\versions\stable\bin\dart, which is not inside your current Flutter
      SDK checkout at E:\fvm\default. Consider adding E:\fvm\default\bin to the front of your path.
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[√] Android Studio (version 2022.3)
[√] Connected device (1 available)
[!] Network resources
    X A network error occurred while checking "https://github.com/": 信号灯超时时间已到

! Doctor found issues in 2 categories.

log.txt
This is my logcat log

12-13 14:44:37.014 I/GmsDebugLogger( 9252): [83] 1 [tflite_dynamite, vision.barcode]
12-13 14:44:37.015 D/OplusDisplayPolicy( 1984): com.semi.pms_mobile, no change cutoutMode: 1
12-13 14:44:37.017 I/flutter (13713): 0.0
12-13 14:44:37.017 I/flutter (13713): 0.0
12-13 14:44:37.017 W/Vision  ( 9252): Request for optional module download of tflite_dynamite failed. Request again.
12-13 14:44:37.018 W/Vision  ( 9252): Request for optional module download of barcode failed. Request again.
12-13 14:44:37.018 V/WindowManager( 1984): Changing focus from null to Window{d429bf9 u0 com.semi.pms_mobile/com.semi.pms_mobile.MainActivity},diplayid=0
12-13 14:44:37.019 I/Vision  ( 9252): Schedule retrying download tflite_dynamite,barcode at<PHONE_NUMBER> with backoff 40 seconds
12-13 14:44:37.019 D/CompactWindowManagerService( 1984): notifyCompactWindowState task: Task{e8b0f88 #38092 type=standard A=10394:com.semi.pms_mobile U=0 visible=true mode=fullscreen translucent=false sz=1}; hasFocus: true
12-13 14:44:37.019 D/ActivityTaskManager( 1984): onWindowFocusChanged Task{e8b0f88 #38092 type=standard A=10394:com.semi.pms_mobile U=0 visible=true mode=fullscreen translucent=false sz=1} would transfer to compact
12-13 14:44:37.021 D/Theia.NoFocusWindow( 1984): FocusWindowErrorScene cancelCheckFreezeScreen
12-13 14:44:37.022 D/CompatibilityChangeReporter( 1984): Compat change id reported: 158002302; UID 10394; state: ENABLED
12-13 14:44:37.023 D/ExtensionsLoader(13713): createInstance(64bit) : createExtendedFactory
12-13 14:44:37.023 D/ExtensionsLoader(13713): Opened libSchedAssistExtImpl.so
12-13 14:44:37.024 V/OplusZoomWindowDecorViewHelper(13713): setLastReportedMergedConfiguration mZoomDisplayHeight: 2340 getDecorView.261686923
12-13 14:44:37.029 D/OplusMovieIdle( 1145): updateLayerStacks,mOmiSupport is not supoort
12-13 14:44:37.029 I/SDM     ( 1002): HWCDisplay::GetColorModeCount: Supported color mode count = 3
12-13 14:44:37.029 I/SDM     ( 1002): HWCDisplay::GetColorModes: Color mode = 0 is supported
12-13 14:44:37.029 I/SDM     ( 1002): HWCDisplay::GetColorModes: Color mode = 7 is supported
12-13 14:44:37.029 I/SDM     ( 1002): HWCDisplay::GetColorModes: Color mode = 9 is supported
12-13 14:44:37.029 D/hw-ProcessState(13713): Binder ioctl to enable oneway spam detection failed: Invalid argument
12-13 14:44:37.042 D/OplusLayer( 1145): ~Layer() sequence=30659, name=Surface(name=1651a6b StatusBar)/@0x2524f8a - animation-leash of insets_animation#1 0xb400006ff56c5480
12-13 14:44:37.042 D/OplusLayer( 1145): ~Layer() sequence=30660, name=Surface(name=b742999 NavigationBar0)/@0xe66ed0c - animation-leash of insets_animation#0 0xb400006ff57c8740
12-13 14:44:37.043 D/OplusMovieIdle( 1145): updateLayerStacks,mOmiSupport is not supoort
12-13 14:44:37.043 I/ClipboardManagerTransactionHelper( 1984): Invalid transaction code = 6
12-13 14:44:37.044 I/ClipboardManagerTransactionHelper( 1984): Invalid transaction code = 6
12-13 14:44:37.058 D/OplusMovieIdle( 1145): updateLayerStacks,mOmiSupport is not supoort
12-13 14:44:37.059 V/OplusZoomWindowManagerService( 1984): onAnimationFinished:  r = ActivityRecord{b213d21 u0 com.semi.pms_mobile/.MainActivity t38092}
12-13 14:44:37.059 I/OplusAppSwitchManagerService( 1984):  handleAppVisible , r = ActivityRecord{b213d21 u0 com.semi.pms_mobile/.MainActivity t38092}
12-13 14:44:37.059 W/InputMethodManager(13713): Ignoring showSoftInput() as view=io.flutter.embedding.android.r{56b661 VFE...... .F....ID 0,0-1080,2292 #1} is not served.
12-13 14:44:37.060 W/InputMethodManager(13713): Ignoring showSoftInput() as view=io.flutter.embedding.android.r{56b661 VFE...... .F....ID 0,0-1080,2292 #1} is not served.
12-13 14:44:37.060 V/OplusZoomWindowManagerService( 1984): onAnimationFinished:  r = ActivityRecord{c64d61d u0 com.android.launcher/.Launcher t38060}
12-13 14:44:37.062 I/flutter (13713): 360.0
12-13 14:44:37.062 I/flutter (13713): 764.0
12-13 14:44:37.065 W/ActivityManager( 1984): setGlThreads detect 13713 13738
12-13 14:44:37.073 D/OplusLayer( 1145): setBuffer sequence=30667, name=SurfaceView[com.semi.pms_mobile/com.semi.pms_mobile.MainActivity](BLAST)#0
12-13 14:44:37.073 I/OplusLayer( 1145): VRR [FRTC] update from -1 to 0
12-13 14:44:37.073 D/SurfaceComposerClient(13713): VRR [FRTC] client handle [bufferId:18446744073709551615 framenumber:0] [ffffffff, ffffffff]
12-13 14:44:37.074 D/OplusMovieIdle( 1145): updateLayerStacks,mOmiSupport is not supoort

Thanks for the update. This is working as intended. Since you run the project in release mode, the Dart code runs faster (some known/related issues: https://github.com/flutter/flutter/issues/25827, https://github.com/flutter/flutter/issues/106858).
Closing this as a duplicate of those issues.


update dependencies

closes: DASH-576

#5698  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


fish/fish_themes port

Just found out about this theme recently and I love it - thank you for making it!
I'd like an integration with fish, a CLI shell. I already have the theme applied to my terminal emulator, but with the default settings, the autocomplete suggestions are so dark it's almost unreadable:

A fish-specific theme would fix this.
Examples:
https://github.com/folke/tokyonight.nvim/blob/main/extras/fish_themes/tokyonight_night.theme
https://github.com/scottmckendry/cyberdream.nvim/blob/main/extras/fish/cyberdream.theme
I'd be willing to make a contribution for this.

Go for it!

The theme is created!
I'd like to transfer this repo to the eldritch-theme organization, if possible.
From the screenshot, please let me know if any changes are wanted.

The theme is created!
I'd like to transfer this repo to the eldritch-theme organization, if possible.
From the screenshot, please let me know if any changes are wanted.

Looks good, request transfer

After you transfer, please open a PR to main repo updating README

Looks good, request transfer

Sorry, I'm kinda new to this - how would I go about this? Trying to transfer the repo directly tells me I don't have permission to create public repos for the organization.

Looks good, request transfer

Sorry, I'm kinda new to this - how would I go about this? Trying to transfer the repo directly tells me I don't have permission to create public repos for the organization.

Invited you to org


check disabled status on verifyIDToken

The verifyIDToken() function checks to see whether the ID token is revoked, but never actually checks to see whether or not the user is disabled.  This change makes it so that verifyIDToken() does check the disabled field by modifying checkRevoked().  The function is renamed to checkRevokedOrDisabled and now additionally includes a check to make sure that the user is not disabled.  A new authErrorCode corresponding to this case is added.  verifySessionCookie() is slightly modified to account for the fact that checkRevokedOrDisabled now returns 3 values instead of 2.  verifyIDToken() has been modified to raise an InvalidArgument error with authErrorCode of "ID_TOKEN_DISABLED" if the user is disabled.

I'm not sure how to fix the google-cla bot error.  It's complaining that "google-oss-bot" doesn't have a CLA signed.

You might want to rebase your commits at dev and do a force push, which should clean up the commit history.


Update README to include npm install

The current build instructions do not include an initial npm install step. As a result, most users will encounter errors due to missing packages, such as tsc, when attempting to run the build commands.
Steps to reproduce the behavior:
1.	Clone the repository.
2.	Follow the README instructions and try to run the build command.
3.	See error due to missing packages, such as tsc.

Expected behavior
The build should succeed without errors if all necessary dependencies are installed.
Suggested Fix
To ensure users have the required packages, please include an initial npm install command before the run steps in the documentation for building the project locally.

done


Leaflet CDN is unreachable

Leaflet's CDN is down: http://cdn.leafletjs.com/leaflet-0.7.3/leaflet-src.js
Maybe use Cloudflare's instead? (https://cdnjs.com/libraries/leaflet)

It's working for me. There has been an outage, but that should have been fixed: https://twitter.com/LeafletJS/status/603856231091064833 ?
For the upcoming release I'm bundling all dependencies and not use CDNs anymore.

Weird - it's down for me. Probably depends on the location.

It is also down for me - but it seems not to be a location issue but rather related to https: After deactivating the rule for Leaflet JS.com in HTTPS Everywhere everything works fine again.

cdn.leafletjs.com does not support HTTPS (neither does brouter.de).
Using Cloudflare would be an option, but I would rather move forward and bundle all with the upcoming release, unless people are still having issues with the Leaflet CDN.


Create minimal default.md in archetype file fixes #315

To fix the cast error, create a minimal default.md in the archetype
folder.

merged as fefd911


Adding utilities to backup stories to google Drive

Related issues:

closes #88
closes #105

To test, it is required to change the checkout to point to develop branch since master does not save stories into the saved_stories directory yet. (refers to #98 and #101)
This PR added the following utilities code block:

Mount gdrive
Backup stories from Collab instance to Gdrive
Restore stories from GDrive to Collab
Backup model from Collab to GDrive
Copy model from GDrive to Collab

1 and 2 is an attemp at #88 while 3 and 4 attempts to solve #105 (since copy from gdrive is way faster. This can also be used to backup finetune model from collab as well)
This does not conflict with either #102 or #93.

@ben-bay should be good to go! I think I edited the notebook with both mode on VSCode and some conflict happened

Amazing! Adding a few comments but this is really helpful


this pr is to add Apache License

this pr is to add Apache License

Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

duplicate of #2957


Update to sprockets 4

What
This PR updates sprockets to latest major versions, which require precompiled assets to be declared via manifest.js
Why
To keep our dependencies up to date. Fixes #1972
Notes
Configuration tested with:

[x] collections
[ ] content-publisher
[ ] email-alert-frontend
[ ] feedback
[ ] finder-frontend
[x] frontend
[x] government-frontend
[ ] govspeak
[ ] info-frontend
[ ] licence-finder
[ ] manuals-frontend
[ ] service-manual-frontend
[ ] smart-answers
[ ] whitehall
[ ] static

Visual Changes
n/a

Hey @alex-ju, as discussed on Slack, I've also been working on this - and I'm sorry we've ended up both putting energy into the same thing (I wonder what force of nature inspired us both.
The branch I've got is: https://github.com/alphagov/govuk_publishing_components/tree/sprockets-4-kevin and you can see the diff in: https://github.com/alphagov/govuk_publishing_components/compare/sprockets-4-kevin
Probably the major difference between our approaches is that I took a stance of supporting both Sprockets 3 and 4 for a while and warning users to upgrade.
There's a few things that seem to be working in your branch that surprise me too. I'll leave some comments surrounding those.
I'm not precious about my work on this so happy for you to make my bits or to open my own PR. Let me know your preference.

Hey @alex-ju, as discussed on Slack, I've also been working on this - and I'm sorry we've ended up both putting energy into the same thing (I wonder what force of nature inspired us both.
The branch I've got is: https://github.com/alphagov/govuk_publishing_components/tree/sprockets-4-kevin and you can see the diff in: https://github.com/alphagov/govuk_publishing_components/compare/sprockets-4-kevin
Probably the major difference between our approaches is that I took a stance of supporting both Sprockets 3 and 4 for a while and warning users to upgrade.
There's a few things that seem to be working in your branch that surprise me too. I'll leave some comments surrounding those.
I'm not precious about my work on this so happy for you to make my bits or to open my own PR. Let me know your preference.

A backwards compatible approach would be ideal – I couldn't manage to make it work. Considering you already have a branch up and that I won't be around for long (my recent PRs in this repo took on average a month to get merged) I'd rather retire this in favour of yours. It was a good experiment, but requires a breaking change and a mass update.


feat: org stats (locations / layers) [EP-2087]

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


一次录入多个字 Input multiple words at one time

`func (t *TextInput) idleState(newKeyOrCommand bool) textInputState {
.......
chars := input.InputChars()
if len(chars) > 0 {
return t.charInputState(chars[0]), true  //多个字一起传入  return t.charInputState(chars), tru
}
......
}
func (t *TextInput) doInsert(c []rune) {
.....
t.cursorPosition += len(c)  //一次加多个字符位
}
func fontStringIndex(s string, f font.Face, x int) int {
start := 0
end := len([]rune(s))  //convert to []rune
line(528)  sub := string([]rune(s)[:p])  不是有可能会出现out of index
`

I'm not sure I follow what the problem is? Please elaborate.

I'm not sure I follow what the problem is? Please elaborate.

sorry, it's not a bug, just add support for Chinese input

sorry, it's not a bug, just add support for Chinese input

I'm afraid I'm not at all familiar with Chinese, Japanese, Arabic, and similar languages, and how to work with them in the context of string manipulation (though I'm willing to learn, of course.)

I'm afraid I'm not at all familiar with Chinese, Japanese, Arabic, and similar languages, and how to work with them in the context of string manipulation (though I'm willing to learn, of course.)

Unfortunately GLFW doesn't support IMEs yet. I plan to add native transparent text fields https://github.com/hajimehoshi/ebiten/issues/1029 in the future.

Unfortunately GLFW doesn't support IMEs yet. I plan to add native transparent text fields https://github.com/hajimehoshi/ebiten/issues/1029 in the future.

textinput.zip

textinput.zip

Fixed, thanks!

Fixed, thanks!


Refactor Runner to be reusable

Moving phase_heading and wait_for_completion out of Runner to make them reusable for the Restart task.
This is a blocker to ship https://github.com/Shopify/kubernetes-deploy/pull/61.

Great review tips. I updated the PR 👌


Support for passing in CultureInfo to parser

Hi!
Great library, there seems to be an issue though when parsing numeric values.
In some languages comma "," is used as a delimeter, so '123.45' will not be parsed correctly into a double, instead it throws an exception.
If it would be possible to pass in CultureInfo one could pass in CultureInfo.InvariantCulture to be able to parse numeric values.
Another option would be to make the different parsing methods virtual to allow overriding certain methods.

I'm not sure culture information makes sense within the parser given CSS isn't a culture-specific language.  The goal of the library is to parse the raw CSS into an AST.  If you want to change number format, that would be best suited for code outside the library.   Otherwise you introduce transformations that don't exist in the CSS.  The parsed object model is one that, ideally, should be able to go from CSS text to memory and back again with very little lost in translation.  Granted, elements are normalized in some places.  However it wouldn't make sense to have a value such as width: 33.5% turn into width: 33,5%.  Doing so would render the CSS invalid.

Hi again!
This is about your sql parser and not the css parser :)
The problem is not that I want comma support, but rather dot delimeted fails when parsing.
say "field1 > 123.45" will throw an exception when parsing. So if '.' is the supported delimiter, then TryParse for double should then have CultureInfo.InvariantCulture

My apologies - too many parsers in my life.
You have an interesting point. Let me see what I can come up with..

@Ulimo in your opinion does it make more sense to configure it globally or per parser instance?

Hi again!
Well per parser instance I guess is more generic and allows more use cases, but globally is easier to implement.
For my use case globally works fine, as you mentioned in the sql spec you should use '.' as a delimeter and not comma.

The latest version has been posted to nuget.org.  Numeric values with decimal precision are only parsed in one spot making it possible to add an invariant culture to that parsing routine.  The current package should parse your query regardless of culture.


feat: removed mongofs and added graalvm

Sir @stephane-segning most of the builds are not passing please check them out.

Done!


Respect Number field's specified precision

This enables the formatter to format numbers based on the field's precision.

@darh below at line 210 the value's type was a bit random (sometimes string, sometimes float64) and I can't quite put my finger on why; any idea?


Officer hat sprite

Added classic blue police officer hat with police badge on front.
This was unasked for (no issue related) but was just easy to draw after the captain's hat and general's hat, so I just made it :rofl: Just ditch it if it doesn't fit in the project!

No, this is great, I'm sure we will use it. :smiley: You can give a comment in advance next time, so I can open a Hacktoberfest issue and you get the score for it! :champagne:

Oh, sorry! I'll keep it in mind next time, thank you :smile:


Add multilingual spell checker pre-commit hook

A lot of open and closed issues are simple typos. Spell checking should be automated on pre-commit stage (and later in CI). Discussed with @satwikkansal here
Suggested options:

cspell - default vscode checker how to add multiple languages in pre-commit
typos - fast Rust based checker, most likely English only

Let's stick to cspell since we're going to use it across translations.


Inconsistent result when CAS exists from proxy but not locally.

I have CI cache backed by S3 and here is an HTTP cache log:
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/ac/a559cd7910cbbe821525f48e6efef10964c4243aeff3b6747baffd1e2863c096 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/d35d521228f07e30b28984179d3435236ace2eddaadaa1526aaea58e39a389ba OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/615324b6d4553bf401f3e20e1d1e7fbb02f99f4d6a672f069157871547b0b4cb OK
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/0e5166cbbaee2f9bcb621398ab8f0c75deb169766d88b9f7b4047f39e2dcef31 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/f8e5351bad6c3c961fbc247790047c031508b98ae083f8d72483505c8c039931 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/6a36cd36e694976de00dd7aa55a8731a7fa9e06cde1a855d6409530bcfbd4e40 OK
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/f5ea44e96bcbec7c85633f0ebaecb16cc374ed1b1e2fb29513b76d0f1896289e OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/f8e5351bad6c3c961fbc247790047c031508b98ae083f8d72483505c8c039931 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/6a36cd36e694976de00dd7aa55a8731a7fa9e06cde1a855d6409530bcfbd4e40 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/3a56dc577ede5d09612ee47874719a67709bede1d54c7337709ba0f1b34e7eae OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/d35d521228f07e30b28984179d3435236ace2eddaadaa1526aaea58e39a389ba OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/615324b6d4553bf401f3e20e1d1e7fbb02f99f4d6a672f069157871547b0b4cb OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/4069577f6b77e0d8e22150e405f13faf31cc3973735a6613034cfbf88e9f3f09 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/39cda18dd362ba07607ecb7007f92a4270408b2eefd3a0b6ca4f7a06998f7de2 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/74a306028b6a3fe5f6635cf35c7b0844e816d6e689f8c9af1e5aebe0193ef4a1 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/bd62d11533ba6d63328b92369ec905eaa18380badbfc394603feef887388e062 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/a5bb7efae52fb008c3d3db5aaec798a74815d73bc786efacefc56a13b8f0336c OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/5c458a5e671110255be575f7f58b2e63931f3a7c6b960fa489e67343c87e1d61 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/5efafabd06c21547fa756512bbf92b3a8b1e9e9a6cf872080b4cadd8821f7c35 OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/400863baa375f1b465e0f72bfe6bc18f6ac13cc065fa9fc66254df9e88e7ff5c OK
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/aad80f9583cb54f43ea70280c68a737f01441f430f96c1f290fd0ee24c979009 OK
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/0e5166cbbaee2f9bcb621398ab8f0c75deb169766d88b9f7b4047f39e2dcef31
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/f5ea44e96bcbec7c85633f0ebaecb16cc374ed1b1e2fb29513b76d0f1896289e
2020/07/22 23:54:39  GET 404       <IP_ADDRESS> /cas/d35d521228f07e30b28984179d3435236ace2eddaadaa1526aaea58e39a389ba
2020/07/22 23:54:39  GET 404       <IP_ADDRESS> /cas/615324b6d4553bf401f3e20e1d1e7fbb02f99f4d6a672f069157871547b0b4cb
2020/07/22 23:54:39  GET 404       <IP_ADDRESS> /cas/6a36cd36e694976de00dd7aa55a8731a7fa9e06cde1a855d6409530bcfbd4e40
2020/07/22 23:54:39  GET 404       <IP_ADDRESS> /cas/f8e5351bad6c3c961fbc247790047c031508b98ae083f8d72483505c8c039931
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/d35d521228f07e30b28984179d3435236ace2eddaadaa1526aaea58e39a389ba OK
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/d35d521228f07e30b28984179d3435236ace2eddaadaa1526aaea58e39a389ba
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/400863baa375f1b465e0f72bfe6bc18f6ac13cc065fa9fc66254df9e88e7ff5c OK
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/400863baa375f1b465e0f72bfe6bc18f6ac13cc065fa9fc66254df9e88e7ff5c
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/bd62d11533ba6d63328b92369ec905eaa18380badbfc394603feef887388e062 OK
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/bd62d11533ba6d63328b92369ec905eaa18380badbfc394603feef887388e062
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/5c458a5e671110255be575f7f58b2e63931f3a7c6b960fa489e67343c87e1d61 OK
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/5c458a5e671110255be575f7f58b2e63931f3a7c6b960fa489e67343c87e1d61
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/39cda18dd362ba07607ecb7007f92a4270408b2eefd3a0b6ca4f7a06998f7de2 OK
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/39cda18dd362ba07607ecb7007f92a4270408b2eefd3a0b6ca4f7a06998f7de2
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/615324b6d4553bf401f3e20e1d1e7fbb02f99f4d6a672f069157871547b0b4cb OK
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/615324b6d4553bf401f3e20e1d1e7fbb02f99f4d6a672f069157871547b0b4cb
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/aad80f9583cb54f43ea70280c68a737f01441f430f96c1f290fd0ee24c979009 OK
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/f8e5351bad6c3c961fbc247790047c031508b98ae083f8d72483505c8c039931 OK
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/aad80f9583cb54f43ea70280c68a737f01441f430f96c1f290fd0ee24c979009
2020/07/22 23:54:39  GET 200       <IP_ADDRESS> /cas/f8e5351bad6c3c961fbc247790047c031508b98ae083f8d72483505c8c039931

Particularly, for entries like /cas/d35d521228f07e30b28984179d3435236ace2eddaadaa1526aaea58e39a389ba, S3 returns OK :
2020/07/22 23:54:39 S3 CONTAINS envoy-ci-build-cache-us-east-2 public-x64/cas/d35d521228f07e30b28984179d3435236ace2eddaadaa1526aaea58e39a389ba OK

While bazel-remote return 404 to Bazel:
2020/07/22 23:54:39  GET 404       <IP_ADDRESS> /cas/d35d521228f07e30b28984179d3435236ace2eddaadaa1526aaea58e39a389ba

And the download completes later:
2020/07/22 23:54:39 S3 DOWNLOAD envoy-ci-build-cache-us-east-2 public-x64/cas/d35d521228f07e30b28984179d3435236ace2eddaadaa1526aaea58e39a389ba OK

This result
WARNING: Reading from Remote Cache:
BulkTransferException

and a cache miss.

Thanks for the bug report.
Looking at instances of d35d521228f07e30b28984179d3435236ace2eddaadaa1526aaea58e39a389ba in your logs, I suspect that there are two concurrent requests for the blob:

request 1 arrives, the blob is not available locally, but a place is reserved in the LRU index, then bazel-remote starts downloading the blob from s3
request 2 arrives, the blob is still not available locally, and a place cannot be reserved in the LRU index because there's an in-progress download, and gives the 404 error
request 1 finishes downloading from s3, then successfully serves the blob

So this is almost certainly related to #267 - a shortcut was taken early on in bazel-remote's design, based on the assumption that such concurrent requests are rare enough to ignore. That assumption no longer seems to hold with more recent versions of bazel.
The reporter of that issue has gone quiet, so I will try implementing this myself. I might have a test build for you to try next week.

a shortcut was taken early on in bazel-remote's design, based on the assumption that such concurrent requests are rare enough to ignore. That assumption no longer seems to hold with more recent versions of bazel.

@mostynb Yes that's the case. I will open a bug in bazel as well to not request same blob.
I was able to hack a quick solution by return result from proxy directly when a blob is in progress: https://github.com/buchgr/bazel-remote/compare/master...lizan:inprogress?expand=1
Another potential quick workaround is return 503 instead of 404, that at least let bazel to retry the request instead of execute the action.
In our case, re-execute the action (which is a rules_foreign_cc build) will result slightly different result, which is foreign_cc's issue though. As this happens in an early action so the cache of targets depends on it will also be invalidated.

I will open a bug in bazel as well to not request same blob.

Note that this is also an issue on the bazel-remote side when you have multiple bazel clients interacting with the cache simultaneously.

I was able to hack a quick solution by return result from proxy directly when a blob is in progress: https://github.com/buchgr/bazel-remote/compare/master...lizan:inprogress?expand=1

I have made a start on the cleanup work to remove the assumption, and so far it appears to be easier than I thought. So I would prefer to focus on this, and hopefully have something ready for you to test fairly soon.

Another potential quick workaround is return 503 instead of 404, that at least let bazel to retry the request instead of execute the action.

That is an interesting idea, definitely worth investigating if my cleanup work takes too long.

Here's my work-in-progress fix: https://github.com/mostynb/bazel-remote/commits/concurrent_inserts

@mostynb thanks, I can confirm the branch fixes with my minimal case.


Update nn-d3d12-id3d12stateobjectproperties.md

@john-h-k : Thanks for your contribution! The author(s) have been notified to review your proposed change.


[DebugInfo] Move type size information to CompletedDebugTypeInfo

Remove the estimated type size from the DebugTypeInfo class, and move it to CompletedDebugTypeInfo. The type size is now computed by CompletedDebugTypeInfo::getFromTypeInfo, and is never the size of a fragment.

@swift-ci please test


Add ingressClassName field

We need to add ingressClassName support to customize ingress.

and host

Hi @adubkov, I guess this PR might suffice the request. WDYT?

@ishitasequeira Yes, it looks like it would solve this issue.

closing this as its a duplicate of 626


issue in darkmode theme

CPod v1.27.0
kubuntu 18.04
appimage
Description:
the text is light same as background in dark mode so you can't see the text of unselected option in a drop-down menu
*Other helpful information (e.g. Developer Tools console log, screenshots) if possible:

Thanks for submitting this issue. This bug has already been addressed in #109 and the fix will be included in the next release of CPod.


Material Design

Is there a plan to support google's material design ? It would make an interesting feature, wouldn't it?

Did someone has a work in progress in this area ? regards

Two other material design implementations (in React):

http://material-ui.com/#/components/buttons
http://sanderspies.github.io/react-material/

JS is used mostly to toggle class names which start animations, and to position things like the ripple on buttons (click on different places on a rectangular button).

The groundwork is in place with theming. It's a bit difficult to visualize all of it together in the current docs (which only support showing themes of the current element). But there's Material themes already for button, modal, and site.

Where is the best place to track the progress on the Material Design theme for all Semantic elements, collections, views and modules?

Does it exist yet?

There is no progress on this. If someone wants to contribute a complete Material theme, it would be an easy PR, but keep in mind the bar for design detail for the project is set at a certain level.

Hi guys can also check this one : http://www.material-ui.com/v0.15.0-alpha.2/

So where does this stand now, I'm looking at using some Material Degisn UI with semantic in a react project I'm currenty on.


Error when running Knife solo cook

Hi there,
I installed the latest version of chef with these configuration
gem "berkshelf", "~> 7.0.10" gem "chef", "> 16.6.14" gem "knife-solo", "> 0.7.0" gem "knife-ec2", "~> 2.1.0"
But when I run the command knife solo cook<EMAIL_ADDRESS>I get these errors:
Traceback (most recent call last):
14: from /usr/local/bin/knife:23:in ' 13: from /usr/local/bin/knife:23:in load'
12: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/bin/knife:24:in <top (required)>' 11: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/application/knife.rb:165:in run'
10: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife.rb:224:in run' 9: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife.rb:161:in subcommand_class_from'
8: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:129:in command_class_from' 7: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:115:in load_command'
6: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in load_commands' 5: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in each'
4: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in block in load_commands' 3: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in load'
2: from /Library/Ruby/Gems/2.6.0/gems/knife-windows-0.8.2/lib/chef/knife/winrm.rb:20:in <top (required)>' 1: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in require'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:54:in require': cannot load such file -- chef/knife/winrm_base (LoadError) 21: from /usr/local/bin/knife:23:in
'
20: from /usr/local/bin/knife:23:in load' 19: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/bin/knife:24:in <top (required)>'
18: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/application/knife.rb:165:in run' 17: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife.rb:224:in run'
16: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife.rb:161:in subcommand_class_from' 15: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:129:in command_class_from'
14: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:115:in load_command' 13: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in load_commands'
12: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in each' 11: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in block in load_commands'
10: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in load' 9: from /Library/Ruby/Gems/2.6.0/gems/knife-windows-0.8.2/lib/chef/knife/winrm.rb:20:in <top (required)>'
8: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:34:in require' 7: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:123:in rescue in require'
6: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems.rb:217:in try_activate' 5: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:1420:in activate'
4: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:1438:in activate_dependencies' 3: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:1438:in each'
2: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:1452:in block in activate_dependencies' 1: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:1418:in activate'
/System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:2302:in raise_if_conflicts': Unable to activate em-winrm-0.6.0, because winrm-2.3.5 conflicts with winrm (~> 1.2.0) (Gem::ConflictError) 22: from /usr/local/bin/knife:23:in '
21: from /usr/local/bin/knife:23:in load' 20: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/bin/knife:24:in <top (required)>'
19: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/application/knife.rb:165:in run' 18: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife.rb:224:in run'
17: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife.rb:161:in subcommand_class_from' 16: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:129:in command_class_from'
15: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:115:in load_command' 14: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in load_commands'
13: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in each' 12: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in block in load_commands'
11: from /Library/Ruby/Gems/2.6.0/gems/chef-16.6.14/lib/chef/knife/core/subcommand_loader.rb:105:in load' 10: from /Library/Ruby/Gems/2.6.0/gems/knife-windows-0.8.2/lib/chef/knife/winrm.rb:20:in <top (required)>'
9: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:34:in require' 8: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/core_ext/kernel_require.rb:123:in rescue in require'
7: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems.rb:216:in try_activate' 6: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems.rb:223:in rescue in try_activate'
5: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:1420:in activate' 4: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:1438:in activate_dependencies'
3: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:1438:in each' 2: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:1452:in block in activate_dependencies'
1: from /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:1418:in activate' /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/rubygems/specification.rb:2302:in raise_if_conflicts': Unable to activate em-winrm-0.6.0, because winrm-2.3.5 conflicts with winrm (~> 1.2.0) (Gem::ConflictError)

Hi @mgivi - as mentioned on https://github.com/matschaffer/knife-solo this gem is no longer maintained.
I’d recommend finding an alternate solution.


Revert "Bump node-addon-api from 8.1.0 to 8.2.0"

Reverts mmomtchev/ffmpeg#176
Node, wake up, summer is over, this is the nominal code path, it is not even on the exception path, if there are changes to how this must be used, say it and use a major version

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.89%. Comparing base (4242c50) to head (e607c20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   97.83%   97.89%   +0.06%
==========================================
  Files          21       21
  Lines        1664     1664
==========================================
+ Hits         1628     1629       +1
+ Misses         36       35       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


csrf validation

The OAuth2 state parameter is used as redirect target URL (it could be like a "next" maybe instead?). The state parameter should be secure random thingy we can check in the callback handler:
https://tools.ietf.org/html/rfc6749#section-4.1.1

The parameter SHOULD be used for preventing
cross-site request forgery

Also: http://www.twobotechnologies.com/blog/2014/02/importance-of-state-in-oauth2.html
Pls fix this. Thx.

isn't this a duplicate of #321 ?

Nope.
This is where the state parameter should be validated (instead it is used as a redirect target): https://github.com/bitly/oauth2_proxy/blob/a9c55bd6d1caeaa7ba20236b2e85129c8219b865/oauthproxy.go#L483
This is where it is generated: https://github.com/bitly/oauth2_proxy/blob/a9c55bd6d1caeaa7ba20236b2e85129c8219b865/providers/provider_default.go#L92

If the severity of this issue is what I think it is, this is definitely a CVE-worthy vulnerability.


Next-auth fails with OAuthAccountNotLinked on second signin with Google OAuth + MySQL

Describe the bug
When using Google OAuth with MySQL, the next-auth Account creation silently fails.
To Reproduce
Steps to reproduce the behavior:

Setup create-t3-app with next-auth with Google OAuth and MySQL DB.
Push default schema npx prisma db push
Sign in via /api/auth/signin
Sign out via /api/auth/signout
Sign in via /api/auth/signin

Expected behavior
User is signed back into their account.
Actual behavior
Next-auth throws an error.
OAuthAccountNotLinked

Debugging results
When using OAuth, next-auth creates an entry in both the User and the Account table. The Account table is used to verify repeated OAuth sign ins.
However, it turns out that some OAuth tokens (in my case from Google) are very long. The default DB Mapping for the type String is Text in PostgreSQL and SQLite but notably VARCHAR(191) in MySQL. This results in the INSERT statement into the Account table silently failing in the prisma adapter and a User being created without accompanying Account. That User has one and only one session where everything works as expected, and on second sign-in the missing entry in Account table will make the User inaccessible.
https://www.prisma.io/docs/reference/api-reference/prisma-schema-reference#string
Note: I used PlanetScale because it was referenced in https://init.tips/others and it uses MySQL. IMO, it would be nice if create-t3-app fully supported that one out of the box with next-auth and prisma.
Solution
I fixed this issue by annotating the two relevant token columns access_token and id_token with an explicit @db.text:
// Necessary for Next auth
model Account {
    id                       String  @id @default(cuid())
    userId                   String
    type                     String
    provider                 String
    providerAccountId        String
    refresh_token            String?
    access_token             String? @db.Text
    expires_at               Int?
    token_type               String?
    scope                    String?
    id_token                 String? @db.Text
    session_state            String?
    user                     User    @relation(fields: [userId], references: [id], onDelete: Cascade)

    @@unique([provider, providerAccountId])
}

This schema should work fine for PostgreSQL, MySQL, and Microsoft SQL Server. It might however cause issues for SQLite, CockroachDB and MongoDB. I only tested with MySQL and SQLite: MySQL this works, SQLite fails on npx prisma db push.
I am not sure if this warrants changing the default values since it doesn't seem to be universally compatible, but I wanted to contribute a write-up of this error since Google OAuth + MySQL seems like a reasonably common use case.

Thank you for noticing this.
These fields should be marked Text according to the Next-Auth.js docs
I think we have has this brought up before and changed it... The caveat is that Text is not supported on SQLite which would make the prisma db push fail if you don't change to for example MySQL or PostgreSQL...
Maybe we should have a warning if the user selects Next-Auth.js saying they need to change their db provider? That way we could have the correct default model.

Feel free to PR this if you're down!

So I've read in another issue that next Auth doesn't work with sqlite anyway. So the PR would change the schema used when prisma and Auth is selected with @db.text annotation and then print a warning that you may need to adjust the schema if you use something else than mysql/postgres/ms SQL.
Yeah, I will open a PR with the schema annotation and we can take any further discussion there.

Ok I just wanted to make super clear what is going on with SQLite so I ran a quick test on my existing app switching to that.

SQLite + next-auth works fine if you omit the @db.text. Whatever the default mapping for String? is seems to have enough capacity to hold the Google OAuth tokens at least.
SQLite does NOT support @db.text annotations and any attempts to use a schema that defines sqlite as adapter and uses that annotation will fail.

IMO, my preferred solution here would be to leave sqlite without @db.text as the default config and just put it like this.
datasource db {
    provider = "sqlite"
    // NOTE: When using MySQL, PostgreSQL or MS Server SQL, uncomment the @db.text annotations in model Account below
    // Further reading:
    // https://next-auth.js.org/adapters/prisma#create-the-prisma-schema
    // https://www.prisma.io/docs/reference/api-reference/prisma-schema-reference#string
    url      = env("DATABASE_URL")
}

// Necessary for Next auth
model Account {
    id                String  @id @default(cuid())
    userId            String
    type              String
    provider          String
    providerAccountId String
    refresh_token     String<EMAIL_ADDRESS>    access_token      String<EMAIL_ADDRESS>    expires_at        Int?
    token_type        String?
    scope             String?
    id_token          String<EMAIL_ADDRESS>    session_state     String?
    user              User    @relation(fields: [userId], references: [id], onDelete: Cascade)

    @@unique([provider, providerAccountId])
}

Too verbose?


Is there documentation for how to set up multiple menus?

First -- great plugin!  Sorry if I missed something, but I can't find any documentation for how to set up multiple menus like the ones shown on the demo page.  So far, everything else works like a charm!

@ptingiris the demo is not a true representation of how to setup multiple menus (it's mostly just for show). The only way it would actually work is if you nested them.
{{#burger-menu as |bm|}}
  {{#bm.outlet}}
    {{#burger-menu}} ... {{/burger-menu}}
  {{/bm.outlet}}
{{/burger-menu}}

Closing as this issue has been abandoned. Feel free to reopen if needed.


First release for version 0.1

Prepare documents, examples and tests before release and configure "pip" version using poetry
Soft deadline: 31.03.2023

Release for first version was performed - https://pypi.org/project/wiredflow/


Draw disks

To visualize planes or flat surfaces it'd be helpful to have a filled, non-wireframe disk.
Partial disks like sectors (pie slices) and rings could be supported by allowing the user to specify and inner/outer radius and start/end angle.

Added in #8.


scripts in demo

Hi, thanks for the job and it is really helpful. But I found that the scripts in demo failed during running. After adding "target/:target/lib/" to classpath, then it works.

make sure you are in path "ytk-learn"
cd ../../..


pivottable and d3 version 4.2.7

Hi
If I try to use d3 renderer example with the latest version of d3 (Version 4.2.7) I get an an error "An error occurred rendering the PivotTable results."
console gives:
$.pivotUtilities.d3_renderers.Treemap@file:///D:/Documents%20and%20Settings/Owner/My%20Documents/pivottable-master/dist/d3_renderers.js:71:9
$.fn.pivot@file:///D:/Documents%20and%20Settings/Owner/My%20Documents/pivottable-master/dist/pivot.js:938:20
$.fn.pivotUI/refreshDelayed</<@file:///D:/Documents%20and%20Settings/Owner/My%20Documents/pivottable-master/dist/pivot.js:1323:13
As I already use v4.2.7 in my project, is there a way to solve this issue ?
Thanks a lot, Jeff

I must admit I have not tested this code with D3 version 4, so I'm not sure what the incompatibilities are... I'm not even sure how well C3 works with D3 version 4 actually.

Here is the issue https://github.com/c3js/c3/issues/1648 tracking c3 and d3v4.

D3 v4+ is now supported by C3 v0.5+ so you should use that combination if you need a more recent version of D3. Please note that most of my efforts are going into Plotly support rather than C3 support at this point :)