fix tracelog timeformat

Issues associated with this PR
Your PR should present related issues you want to solve.
Sign the CLA
Make sure you have signed the CLA
Solutions
You should show your solutions about the issues in your PR, including the overall solutions,
details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases.
And you need to show the ut result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result
Code Style

Make sure Goimports has run
Show Golint result

Codecov Report

Merging #867 into stable will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           stable     #867      +/-   ##
==========================================
+ Coverage   55.65%   55.68%   +0.02%
==========================================
  Files         234      234
  Lines       23777    23771       -6
==========================================
+ Hits        13234    13237       +3
+ Misses       9329     9323       -6
+ Partials     1214     1211       -3

Impacted Files
Coverage Δ

pkg/trace/sofa/rpc/span.go
58.33% <100%> (ø)
:arrow_up:

pkg/log/logger.go
56.35% <0%> (+1.27%)
:arrow_up:

pkg/stream/stream.go
60% <0%> (+13.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 788bf97...924e97b. Read the comment docs.


Pitch Detection example doesn't work

Describe the bug
A clear and concise description of what the bug is.
https://github.com/rserota/wad#pitch-detection
Doesn't work. Using it in a CRA app and it was printing undefined undefined.
Expected behavior
A clear and concise description of what you expected to happen.
I would expect the note and pitch to get pritned.
To Reproduce
Include the smallest possible code snippet that reproduces this bug.
import { useEffect } from "react";

import Wad from "web-audio-daw";

export default () => {
  useEffect(() => {
    const voice = new Wad({ source: "mic" }); // At this point, your browser will ask for permission to access your microphone.
    const tuner = new Wad.Poly();
    tuner.setVolume(0); // If you're not using headphones, you can eliminate microphone feedback by muting the output from the tuner.
    tuner.add(voice);

    voice.play(); // You must give your browser permission to access your microphone before calling play().

    tuner.updatePitch(); // The tuner is now calculating the pitch and note name of its input 60 times per second. These values are stored in tuner.pitch and tuner.noteName.

    const logPitch = function () {
      console.log(voice);
      console.log(tuner.pitch, tuner.noteName);
      requestAnimationFrame(logPitch);
    };
    logPitch();
  });

  return
Microphone
;
};

Screenshots
If applicable, add screenshots to help explain your problem.
Device (please complete the following information):

Model: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I'm unable to reproduce this issue. Can you tell me what browser/OS you're using? Does pitch detection work for you without using react? Does your microphone work for other web audio applications?


help logs_manager

Traceback (most recent call last):
File "C:\Users\dedem\OneDrive\Belgeler\GitHub\whatsapp-osint\whatsappbeacon.py", line 11, in
from utils.logs_manager import Logs
ModuleNotFoundError: No module named 'utils.logs_manager'

@ch0coflake -> @awelmisin

@awelmisin, when you execute whatsappbeacon.py, in which directory are you located? You should run from the repository's root directory to avoid the Python interpreter not finding the reference 'utils.logs_manager'

   whatsapp-osint   git:(master) sudo python whatsappbeacon.py
Traceback (most recent call last):
File "/home/prophecy/Documents/git/whatsapp-osint/whatsappbeacon.py", line 11, in
from utils.logs_manager import Logs

Hey @deepsynthsec , in fact there is an error which causes the python script not to run because there is a folder missing, which we are adding now to this repository. I would suggest you to redownload now or create in the root folder, whatsapp-osint create a folder called "logs". It should be working with it.

Oh cool.
I was thinking maybe that it was a user issue. I thought that the logmanager.py has different permissions then the whatsappbeacon.py file.

@awelmisin mind pulling and trying again? Pull request #7 has been merged

same problem after pull, i thought it maybe access permissions but i chmod 777 the whole file and still traceback
Traceback (most recent call last):
File "/home/prophecy/Documents/git/whatsapp-osint/whatsappbeacon.py", line 11, in
from utils.logs_manager import Logs
ModuleNotFoundError: No module named 'utils.logs_manager'

Hello, I've just tested the new version and it's working.

I believe your problem is that you're executing this code from an incorrect path. You need to be in the root directory and run whatsappbeacon.py from within the root directory. If you don't, utils.logs_manager can never be found.
Are you running this code from VSCode? If so, make sure you specify the execution environment to be in the root directory, not from another dir. I recommend you test using cmder or other Windows-compatible shell that gives you more control over which directory you're at
@deepsynthsec

forgive me, im really a noob at this.
when you say root i have no idea what that means, do you mean root as "su"
or root of the repo. Im sorry if im expecting a lesson in python :)

No problem, I'm here to help @deepsynthsec. A root directory is the top level directory of the repository. So, for example, if you downloaded to /home/prophecy/Documents/git/whatsapp-osint, the root directory where you should run the file is from /home/prophecy/Documents/git/whatsapp-osint.
You should not run the python script from any other directory. When you run from VSCode, the default directory depends and can be changed in settings I believe (here's a link for more info https://stackoverflow.com/questions/38623138/vscode-how-to-set-working-directory-for-debugging-a-python-program)
I always use a terminal to run Python programs so I never run into issues like these.
Note that in my previous example, I'm executing the Python script from /home/$USER/git/whatsapp-osint. That's the root dir of the repository after I downloaded it.

I have tried to emulate what you have said and i think im clearly doing something wrong that doesnt have to do with the program. i ran as you said and have gotten this result

When i deactivate conda i get a selenium web driver error

I installed selenium with python and i seem to have it working?

Works perfectly... I thought i would add a write up just so others know how to fix it.
Reasons i think it didnt work:

Chrome needs to be installed
make sure selenium is installed from python correctly (update it)
run it from the repo root directory
listen to @jasperan

Thank you so much for your help

Haha thanks @deepsynthsec for the comments, see you around
#fixed


Fix broken links and grammar in UG and DG

Codecov Report

Merging #108 (76d69ca) into master (af77fcf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #108   +/-   ##
=========================================
  Coverage     75.57%   75.57%
  Complexity      582      582
=========================================
  Files            88       88
  Lines          1826     1826
  Branches        210      210
=========================================
  Hits           1380     1380
  Misses          393      393
  Partials         53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af77fcf...76d69ca. Read the comment docs.


Select Field is not set to 100% width

https://www.oxfam.ca/landing-page/shortcode-test-2-for-4site/
https://d.pr/i/FosT0S

Fixed

Fixed


[Site] Use monospace system font

TL;DR; i suggest to use native system fonts instead of webfont.
Follow https://github.com/symfony/ux/pull/1119, this time for the monospace font, with the same reasons.
Again, I put online some before/after captures*  with a slider tool to compare.
(* made on macOS Ventura / Firefox)
Captures here: https://smnand.re/w/b68eda/

I made two separate PR because developpers tend to be a little more sensible about code fonts :)

This time I can see the difference easily on https://smnand.re/w/b68eda/ - but I don't personally mind it.
Anyone have a strong opinion on the before/after of the code blocks in the link above?
Also, this will need a rebase now - after merging your other PR's ;)

We can play with the multiple font settings / axes.. I find it more readable like that but it's only a personal opinion.


Make a option to choose the device to output the item to (Milo)

It would be nice if I could output an item to a chest instead of just dropping it to the floor, this would be really nice, with VNC combined with a chest. If you don't have a neural interface, either because you are poor, or lazy.

If you place a chest in front of the turtle, it should place the items in the chest (have not tried but should work).

yeah i know...

VNC combined with a chest.


unicode/utf8: FullRune returns false for a known invalid byte

Any UTF-8 sequence that  starts with 0xc0 or 0c1 is ill-formed and DecodeRune always returns RuneError, 1 for such a byte. However, FullRune of []byte("\xc0") returns false, even though the spec says it will return true for known invalid bytes.
I can look into fixing this as part of a considering a table-based utf-8 decoder. A fix would be trivial if we adopt this algorithm.

CL 16940 already fixes this issue. Will add some more tests and another round of verifications before closing this.


New version: AbstractMCMC v3.3.2

Registering package: AbstractMCMC
Repository: https://github.com/TuringLang/AbstractMCMC.jl
Created by: @cpfiffer
Version: v3.3.2
Commit: d46ba9363cdd6d2f5ffae2fa79d38aacce333926
Reviewed by: @cpfiffer
Reference: https://github.com/TuringLang/AbstractMCMC.jl/commit/d46ba9363cdd6d2f5ffae2fa79d38aacce333926#commitcomment-67250531
Description: Abstract types and interfaces for Markov chain Monte Carlo methods

Please close this PR in favour of https://github.com/JuliaRegistries/General/pull/55251.


Move language.all_dictionaries to repository

This method uses the implicit db.session which is being broken as part of #503.
To change:
lute/term/routes.py:        language_dicts=Language.all_dictionaries(),

lute/models/language.py:        for lang in Language.query.all():

tests/orm/test_Language.py:    assert json.dumps(Language.all_dictionaries()) == exp

Done in develop

In 3.6.0 release.


A.04.TGR55.TGR56.language.affects.capabilities

This issue has been extracted from the issue list on:https://ies-svn.jrc.ec.europa.eu/issues/2685
Comment
'If the returned resource can be parsed as a valid XML document and if the document passes all the tests listed as prerequisites for this test'
Why do the tests need to be executed again, if they have been tested before ('prerequisites')?
The test cases and conformance classes in 'prerequisites' have a WFS 2.0.0 as the test object, while this statement is worded as if these would be test cases and conformance classes on a Capabilities document.
Proposed Change
Either drop the prerequisites and explicitly state the steps/assertions or omit the sentence.

Agreed. Proposal: remove the sentence:

If the returned resource can be parsed as a valid XML document and if the document passes all the tests listed as prerequisites for this test

in this test case


Update to 1.0.28: "Not enough storage is available to process this command"

When the update prompt to 1.0.28 came, I accepted. I was connected via RDP at the time. I disconnected from the session. Later, when I reconnected, the following error message asked to be posted here as an issue (see below).
This may or may not be a SyncTrayzor issue, since other programs died in weird ways once I reconnected to the RDP session (-> "Not enough Storage").
Restarting SyncTrayzor produced another crash, but reported from Windows (not SyncTrayzor). Screenshot failed, so no copy of this error message.
After a second restart of SyncTrayzor, it works fine.
System: Windows 7 Professional 64-bit, with "enough" free RAM and HDD
Version: <IP_ADDRESS>; Variant: Installed; Arch: Amd64
Path: C:\Program Files\SyncTrayzor\SyncTrayzor.exe
System.Windows.Media.Animation.AnimationException: Cannot animate the 'IconSource' property on a 'Hardcodet.Wpf.TaskbarNotification.TaskbarIcon' using a 'System.Windows.Media.Animation.ObjectAnimationUsingKeyFrames'. For details see the inner exception. ---> System.ComponentModel.Win32Exception: Not enough storage is available to process this command
   at System.Drawing.Icon.Initialize(Int32 width, Int32 height)
   at SyncTrayzor.NotifyIcon.NotifyIconResolutionUtilities.SetIconFromImageSource(TaskbarIcon taskbarIcon, ImageSource imageSource) in C:\projects\synctrayzor\src\SyncTrayzor\NotifyIcon\NotifyIconResolutionUtilities.cs:line 53
   at SyncTrayzor.NotifyIcon.NotifyIconResolutionUtilities.<>c.<.cctor>b__5_0(DependencyObject d, DependencyPropertyChangedEventArgs e) in C:\projects\synctrayzor\src\SyncTrayzor\NotifyIcon\NotifyIconResolutionUtilities.cs:line 33
   at System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   at System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
   at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
   at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType)
   at System.Windows.Media.Animation.AnimationStorage.OnCurrentTimeInvalidated(Object sender, EventArgs args)
   --- End of inner exception stack trace ---
   at System.Windows.Media.Animation.AnimationStorage.OnCurrentTimeInvalidated(Object sender, EventArgs args)
   at System.Windows.Media.Animation.Clock.FireEvent(EventPrivateKey key)
   at System.Windows.Media.Animation.Clock.RaiseAccumulatedEvents()
   at System.Windows.Media.Animation.TimeManager.RaiseEnqueuedEvents()
   at System.Windows.Media.Animation.TimeManager.Tick()
   at System.Windows.Media.MediaContext.RenderMessageHandlerCore(Object resizedCompositionTarget)
   at System.Windows.Media.MediaContext.AnimatedRenderMessageHandler(Object resizedCompositionTarget)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

The actual error bubbles up from Windows, as is Not enough storage is available to process this command. A bit of googling brings up some fairly sparse explanations (one two three four five).
My working hypothesis is that SyncTrayzor got unlucky: it happened to be the application which tried to do something which ended up exceeding the IRC stack size, and got denied. Virtual every google result suggests changing the registry key IRPStackSize: if this happens again, maybe that's a possibility...

I'll keep this in mind, should this error occur again (never did so far). That aside, I suppose you can close the issue, since it is not related to SyncTrayzor.

I think if this is related to SyncTrayzor, #151 will cover it, so I'll close this off.


Debug bulking test on windows [WIP]

Description
This PR is a response to https://github.com/apache/incubator-mxnet/issues/14368 and should not be merged as yet.  First step here is to recreate the Windows CI failure, along with additional debugging output to show whether the intended bulking environment variable settings are making it to the point of use.
Thanks to @perdasilva for identifying this issue.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@mxnet-label-bot [CI, Test, Windows]

If this latest commit passes CI, it will be ready for merging.  The problem is that when one performs in Python:
os.environ[<key>] = value

this effects what the C++ backend sees only on Linux.  Under Windows, some additional (and possibly windows-version-specific) work would be required to push the environment change to the msvcrt, which otherwise gets a copy of the environment at process start-up.  My preferred fix here is to resort to the more bomb-proof approach of setting environment variables, then spawning a new process to perform the test (although admittedly this is bypassed on Python2 due to lack of spawn support).

Ready for your review.  @perdasilva @eric-haibin-lin @szha


Fix for zephyr samples

@harshilbhatt2001 is there a dupicate pthread_attr_settacksize() in zephyr/posix/pthread.h ? should we remove that also

Yes, it is there and I'll remove it


User Management API deprecated

Colleagues on leave until 4 January

Still no date for deprecation - closing this PR as it will be easy to replicate when necessary.


Enable generic & cancer dataset

Extends cubi_tk/snappy/pull_sheets.py to support datasets without Family, Father, Mother, Sex and/or Disease status as comments in the sample sheet.
mRNA_seq also added to supported library types.
The library name is used as default for the folder name when missing.

Note that the call to api.investigations.get is replaced by api.samplesheet.retrieve. I hope that it is correct...

@ericblanc20, how did you test your changes? Is it something that could be used to stablish unit tests for SampleSheetBuilder?

@eudesbarbosa I just checked it worked with a cancer dataset that I needed to download.
Re SampleSheetBuilder: I don't know. I am not knowledgeable enough with the cubi-tk, Biomedsheets and altamisa code to judge.
It seems to me that samplesheet logic is hard-encoded in the different instance of IsaTabVisitor (in add_ped, pull_raw_data & pull_sheets). Without an overview of the whole projects (cubi-tk, Biomedsheets, altamisa, snappy), I find it difficult to write something more general & I just add what I need with the least amount of disruption to the rest of the code. (I should really learn more about those...)

@ericblanc20, implementing unit tests for this class doesn't look like a trivial task. I included a new ticket for it, #50.

@ericblanc20  and @holtgrewe , if the sodar-cli.api part is okay I suggest we just merge - this might even solve #52 and #53. I can take Friday to work on the unit tests, #50.


test PR with Github API

Please pull this in!

Docs Build status updates of commit a185772:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 136: [Error] Restore nuget package W:\sxuh-s\.optemp\dependentPackages\Microsoft.OpenPublishing.CommonPlugins\packages.config in folder:W:\sxuh-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in https://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects     Unable to find version '1.0.222' of package 'Microsoft.OpenPublishing.CommonPlugins'.       C:\Users\ContainerAdministrator\.nuget\packages\: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.222' is not found on source 'C:\Users\ContainerAdministrator\.nuget\packages\'.       https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2: Package 'Microsoft.OpenPublishing.CommonPlugins.1.0.222' is not found on source 'https://docfx.pkgs.visualstudio.com/docfx/_packaging/docs-build-v2-prod/nuget/v2'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Relation of Assessment-Results result to a specific standard

Is your feature request related to a problem? Please describe.
When Lula is building an Assessment-Results result object of findings and observations - we will need a way to identify which standard a result/finding/observation belongs to. This should align to decisions made in #327.
Describe the solution you'd like

Given a component-definition with multiple control-implementations exists
When lula validate is executed
Then An assessment-results artifact is generated with results/findings/observations including some identifier to the control-implementation (standard) evaluated.

Completed in #327


Improvements to update_arch_timings.py

This PR adds the following capabilities to the utility script:

Debugging output. It has to be enabled in the code via the DEBUG global variable
Handling of incomplete timing information. When the requested timing corner is not found then the next best is returned.
Support for the SETUPHOLD timing of SDF format.

Investigating...

Investigating...

This is due to https://github.com/SymbiFlow/symbiflow-arch-defs/pull/1406. IMO the install CI is not yet enabled, hence the failure.

Maybe that's the case. I can't get any log from Kokoro. Meanwhile I've started the make install locally.

So Install succeeded on my local machine.

@litghost After I've rebased this one onto master there is only Murax on A50T with ROI failing (diff fasm error). But I can see that this happens on the master branch too:
--- /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7-vendor/build/tests/9-soc/murax/murax_basys/artix7-xc7a50t-basys3-roi-virt-xc7a50t-basys3-test/toplevel.bit.fasm	2020-04-22 11:09:16.048458110 -0700
+++ /tmpfs/src/github/symbiflow-arch-defs-presubmit-xc7-vendor/build/tests/9-soc/murax/murax_basys/artix7-xc7a50t-basys3-roi-virt-xc7a50t-basys3-test/design_murax_basys_vivado.bit.fasm	2020-04-22 11:18:55.312344732 -0700
@@ -9069,7 +9069,6 @@
 INT_L_X6Y110.CLK_L1.FAN_BOUNCE5
 INT_L_X6Y110.CTRL_L0.FAN_BOUNCE1
 INT_L_X6Y110.CTRL_L1.FAN_BOUNCE1
-INT_L_X6Y110.FAN_ALT5.FAN_BOUNCE1
 INT_L_X6Y110.GFAN0.GND_WIRE
 INT_L_X6Y110.GFAN1.GND_WIRE
 INT_L_X6Y110.IMUX_L25.GFAN0
@@ -9281,7 +9280,6 @@
 INT_L_X6Y114.CTRL_L0.FAN_BOUNCE1
 INT_L_X6Y114.CTRL_L1.FAN_BOUNCE1
 INT_L_X6Y114.ER1BEG1.LOGIC_OUTS_L8
-INT_L_X6Y114.FAN_ALT5.FAN_BOUNCE1
 INT_L_X6Y114.GFAN0.GND_WIRE
 INT_L_X6Y114.GFAN1.GND_WIRE
 INT_L_X6Y114.IMUX_L10.GFAN0
@@ -9954,7 +9952,6 @@
 INT_L_X6Y135.ER1BEG2.ER1END1
 INT_L_X6Y135.ER1BEG3.ER1END2
 INT_L_X6Y135.ER1BEG_S0.SR1END3
-INT_L_X6Y135.FAN_ALT5.FAN_BOUNCE1
 INT_L_X6Y135.GFAN0.GND_WIRE
 INT_L_X6Y135.GFAN1.GND_WIRE
 INT_L_X6Y135.IMUX_L25.GFAN0
@@ -10181,7 +10178,6 @@
 INT_L_X6Y139.CLK_L1.FAN_BOUNCE5
 INT_L_X6Y139.CTRL_L0.FAN_BOUNCE1
 INT_L_X6Y139.CTRL_L1.FAN_BOUNCE1
-INT_L_X6Y139.FAN_ALT5.FAN_BOUNCE1
 INT_L_X6Y139.GFAN0.GND_WIRE
 INT_L_X6Y139.GFAN1.GND_WIRE
 INT_L_X6Y139.IMUX_L10.GFAN0

@mkurc-ant This is a known issue: https://github.com/SymbiFlow/symbiflow-arch-defs/issues/1400

Ok, So I think that we can merge this one?


Fix size on Attachements page

In my resources on the attachment tab.
It should show the correct size.

We have new mockup, do we really need to keep attachment size?

Not relevant, as we have a new design


(BUG) [RN] The "Try again" screen is not displayed after 3 failed attempts to pass FV

Precondition:
The FV page is opened
Steps to reproduce:

Perform  3 unsuccessful attempt to pass FV
Pay attention to the lack of the "Wa are looking for..." screen

Actual result: The "Wa are looking for..." screen isn't displayed after 3 failed attempts to pass FV
Expected result: The "Wa are looking for..." screen should be displayed after 3 failed attempts to pass FV

Checked on native 1.3.1-1
Desktop: Windows 10 // Google Chrome  86.0.4240.75

@WolfVV please check every issue you find on native also on QA and mention the result in your report.
please attach video for this  case

@sirpy ok I'll add the result from qa to the following issues
Isn't reproduced for the qa

@sirpy video from native https://www.screencast.com/t/z5uZm26nqy8

@serdiukov-o-nordwhale maybe this issue has been solved in #2675 PR?
can you verify please?

@serdiukov-o-nordwhale maybe this issue has been solved in #2675 PR?
can you verify please?

According to @MarianoAmado 's comments #2675 isn't ready to run. Also i found & fixed one more issue.
I performed an quick code analysis and haven't found any issues with high-level FV implementation (components & hooks)
Need to perform more detailed research:

I saw there were 2 liveness failed and one 'foreground loosed'.
After 'foreground loosed' we always redirecting to the intro. But as i see it wasn't the last one so we should have seen the 'try again later' instead of intro
@WolfVV have you seen the Zoom's 'retry' screen ? if no - we have to fix this too, the issue could be somewhere in processor/subscriber/sdk (as a reasul;t of incorrect merge)

@serdiukov-o-nordwhale you can see in the video that he sent the exact flow @WolfVV did.
@serdiukov-o-nordwhale can you make a code diff to find out if there was a merge issue?

@sirpy as i said - i need to perform more detailed refresh. How we have to prioritize FV bugs (also we have #2678) ? Regarding the fact we're moving to v9 now

@serdiukov-o-nordwhale @sirpy user gets the "switch to another device" screen after third scanning fake face
https://www.screencast.com/t/TKqK0DJy
Checked on  QA 1.9.1-2
Desktop: Windows 10 // Google Chrome  86.0.4240.183
Samsung S9 // Android 10


https://www.php-proxy.com/download/php-proxy.zip

With the recent updates (thank you!)- has this file been updated? I cant spot changes. Thanks.

it has been updated now:
https://www.php-proxy.com/download/php-proxy.zip

Brilliant thanks!


Improve authentication

Remove double authentication prompt
Move away from device code flow
Offer authentication method with app permissions for DevOps deployments

Script is rewritten with Microsoft.Graph - single interactive authentication (no longer device code flow) - if needed the connection part can easily be swapped to use a service principal based on the Microsoft.Graph logic. PR to follow

https://github.com/AlexFilipin/ConditionalAccess/wiki/Release-history#script-v20


Implement caching of remote environment files

As for now the environment-file content for remote files is fetched repeatedly even if the same url is used. Would be nice to cache the remote content to speed-up user experience. Simple steps to reproduce:
git clone https://github.com/oamg/convert2rhel
cd convert2rhel
tmt plan ls

Takes a very long time. Should be easy to implement using functools.lru_cache.

Relevant code is here:
https://github.com/teemtee/tmt/blob/69322f858719cb8c081ef1fc8a25d67300cbf71a/tmt/utils.py#L1032

@psss unless you want to implement the fix yourself, I'd take it.

I was thinking this could be a good material for newcomers. Definitely free for you as well ;-) Especially if you have some good idea how to solve this in a more elegant way.

I'm pretty sure I have no extra elegant idea, it just seems pretty simple and quick to resolve while being an obvious improvement, unlike a pile of type annotation patches that will be extremely helpful, not just this afternoon...


fix: Multiline selection fix

:tada: This PR is included in version 2.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ask for help

I just came into contact with this, and I just installed a part of the program. What should a novice do to start this project from scratch, how to configure the environment, and compile and burn

Just follow the installation guide. I do it every time for testing.
If you want to supress errors in PyCharm during development use Poetry to install dependencies.

how to configure the environment, and compile and burn

Compile and burn?  Compile/burn what??


[feat]: Add memory system

This is an adapted version of memory toolkit from the python goose.
It is used to store and retrieve memories in both global and local contexts.
Due to run dir still being in an ambiguous state - advice is to use global memory

this will be on by default for GUI but off by default for CLI - is that what we want?


favicon support

Hi,
It will be great to add favicon support.
This requires few steps/options:

Add ico type to the loader of jpg/jpeg/png/svg
make sure the ico is available from the root app somehow - myhost/favicon.ico
Maybe add favicons-webpack-plugin to generate all the different icons (for browser, iphone, windows tiles and so on)
change the html.jsx or maybe use html-webpack-plugin to generate the necessary code.
it can also be generated once using realfavicongenerator and insert it hardcoded to the html.jsx
should look something like

<link rel="apple-touch-icon" sizes="180x180" href={require('../../img/logos/favicons/apple-touch-icon.png')}/>
<link rel="icon" type="image/png" href={require('../../img/logos/favicons/favicon-32x32.png')} sizes="32x32"/>
<link rel="icon" type="image/png" href={require('../../img/logos/favicons/favicon-16x16.png')} sizes="16x16"/>
<link rel="manifest" href="/manifest.json"/>
<link rel="mask-icon" href={require('../../img/logos/favicons/safari-pinned-tab.svg')} color="#5bbad5"/>
<meta name="theme-color" content="#ffffff" />

(Also need to think about the manifest.json)
What do you think?

One more:
Using this code hardcoded in index.jsx it works on dev correctly.
But after compile when running in prod env, it looks like it look for the favicons pngs in the wrong folder ie:
href="/./assets/6f9927a38c643c8f5fcac15a6c15aa04.png

instead of:
href="/assets/./assets/6f9927a38c643c8f5fcac15a6c15aa04.png

(it should be with assets twice i think).
It only happen for the favicons, for other images it works correctly.
(i remember something similar before a month when running on dev which looks like it search something in the prod url)
Any idea?

Hi @GiladShoham
Yes, properly supporting favicon's would be nice I think.

I continue investigating the problem with my favicon and found:

in the index.jsx there is check if it's dev or not, if not it will add /assets and find the correct url with the assetMap
most of the images like the logo is found both under build/server/assets and build/client/assets and therefor found in the assets.json.
the favicon is found only on build/server/assets so it's not in the assetMap. so i can't use this same technics.

I consider adding ManifestPlugin to server plugins to create another assetMap but it looks very wrong for me, and it's kind of workaround instead take care the real problem.
Is there any reason why other pngs are both in client and server and those favicon not?
Does adding assetMap for the server assets is reasonable solution?
Thanks.

@GiladShoham

Is there any reason why other pngs are both in client and server and those favicon not?

I'm not sure what you are talking about, when I run 'npm run build' all the images are placed into build/client/assets

@GiladShoham Ah, I understand you now. You are talking about image files that are placed into build/server, during development phase, I will look into this, whether it is still needed...

@GiladShoham I think all your concerns raised in this ticket should be resolved by commit:
https://github.com/sysgears/apollo-fullstack-starter-kit/commit/1f84c6b4bc1219bf62a21d9cd9bf679f69e81dcf

@vlasenko
Thank you.
It's still needed.
Meantime i did some workaround.
I create new loader for the favicon files, without hashing in the name.
Then i faced another problem (when put it in the head on html.jsx) it didn't sent to the client.
So i required them as well in the body in hidden div (which is really bad solution), so when reference them in the link href in the head i found them.
By the way, here is a great article about favicons and web pack.
(it didn't worked very well for me exactly like this, it did create the files in the output, but still didn't sent to the client without the workaround).
And later i decided to move it to dedicated loader in the config.

@GiladShoham
Yes, I'm aware, that this can be tricky. I believe I have implemented it the proper way in the commit:
https://github.com/sysgears/apollo-fullstack-starter-kit/commit/1f84c6b4bc1219bf62a21d9cd9bf679f69e81dcf
As in that article I use require.context as well to require all the favicon images and favicon metadata from src/assets folder as specified in the link you have posted (by the way you can put other images into this folder and they will appear in assetMap with hash from their contents in the name). But above that I also use hashing on favicon files as I do for all the other image assets, so long term caching is done better then described in the link you posted - e.g. when underlying icon contents change - the name will also change, because hash from file contents changes.

Looks great!
I'll check it soon.
I think it will be better to copy the favicon.ico to the root as well (without hashing) because some browsers are looking for this exact file in the root by default.

@GiladShoham Yes, I think you are right. I have moved all assets into root URL and added exception for favicon.ico to not have hash in its name, please see commit:
https://github.com/sysgears/apollo-fullstack-starter-kit/commit/9c3ed91c566484989c6ab062d5de96b5c7bfda2b

@vlasenko
Thanks!
I'll merge it to my project in few days.


YJDH-100 | Excel export

Description :sparkles:

Add translations.

Add a field for SummerVoucher that indicates if the voucher has been exported by a handler to an excel file.

Set the handlers logging in with Azure ADFS as staff users. Certain user groups defined in the setting ADFS_CONTROLLER_GROUP_UUIDS should be allowed the staff status.

Add exporter that exports given SummerVouchers either to xlsx file or in memory object.

Add a view where the handlers can generate and download Excel files from submitted summer voucher applications.

Add tests.

Issues :bug:
YJDH-100
YJDH-97
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #256 (ed67644) into develop (af112dc) will decrease coverage by 0.75%.
The diff coverage is 94.11%.

@@             Coverage Diff             @@
##           develop     #256      +/-   ##
===========================================
- Coverage    95.63%   94.87%   -0.76%
===========================================
  Files          139       85      -54
  Lines         4720     2773    -1947
===========================================
- Hits          4514     2631    -1883
+ Misses         206      142      -64

Impacted Files
Coverage Δ

backend/shared/shared/azure_adfs/auth.py
84.12% <66.66%> (-2.08%)
:arrow_down:

backend/kesaseteli/applications/views.py
85.48% <85.48%> (ø)

...esaseteli/applications/exporters/excel_exporter.py
95.16% <95.16%> (ø)

...li/applications/migrations/0011_add_is_exported.py
100.00% <100.00%> (ø)

backend/kesaseteli/applications/models.py
100.00% <100.00%> (ø)

backend/kesaseteli/applications/tests/conftest.py
100.00% <100.00%> (ø)

...kesaseteli/applications/tests/test_excel_export.py
100.00% <100.00%> (ø)

backend/kesaseteli/common/utils.py
100.00% <100.00%> (ø)

backend/kesaseteli/kesaseteli/settings.py
92.00% <100.00%> (+0.16%)
:arrow_up:

backend/kesaseteli/kesaseteli/urls.py
87.50% <100.00%> (+0.83%)
:arrow_up:

... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af112dc...ed67644. Read the comment docs.


title argument passed to nested @OptionGroup has no effect

@OptionGroup behaves in an unexpected way with nested groups when title: argument value is specified.
ArgumentParser version: 1.2.2
Swift version:
swift-driver version: 1.62.15 Apple Swift version 5.7.2 (swiftlang-<IP_ADDRESS>.5 clang-14<IP_ADDRESS>)
Target: arm64-apple-macosx13.0
Checklist

[x] If possible, I've reproduced the issue using the main branch of this package
[x] I've searched for existing GitHub issues

Steps to Reproduce
Create a type that has properties using @OptionGroup property wrapper with title: argument passed. Uses this type then as @OptionGroup itself. This top level may specify or not specify its own title: argument, this doesn't make a difference on the observed outcome.
Expected behavior
Nested @OptionGroups have their title: values displayed and options grouped by these titles in help output.
Actual behavior
Nested @OptionGroups don't have their title: values displayed and options grouped by these titles in help output. All of the options are displayed within the top-level group, title: values on nested groups have no effect whatsoever.

Great spot, @MaxDesiatov — it would be great if these could preserve their titles when nested. What do you think the behavior should be if the "parent" option group also includes a title? That is, what should the help look like in this case?
struct A: ParsableArguments {
    @Flag var one = false
    @Flag var two = false
}

struct B: ParsableArguments {
    @Flag var three = false
    @Flag var four = false
}

struct Options: ParsableArguments {
    @OptionGroup(title: "Group A")
    var groupA: A

    @OptionGroup(title: "Group B")
    var groupB: B
}

struct Command: ParsableCommand {
    @OptionGroup(title: "All Options")
    var options: Options
}


Update monitor-functions.md

Added a section on configuration options for Java Agent on Functions. @AaronMaxwell - Please do not merge until. Need to review with Java team. Will let you know when they approve.

@AaronMaxwell
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


[URGENT] The link in the project description is a NSFW website

Maintainers please take note that the link in the description of this project is an adult website (probably with the same name as your project or the site was overtaken by nefarious actors) with popups which lead to dangerous links which could contain malware.
The website should be taken down and fixed immediately if it is the correct link to the project otherwise users visiting this project will have a negative experience.
I will be sending a mail regarding the same if this issue isn't resolved immediately.

Thank you, I removed it.

Great!

We will host on a new site with updated UI


Simple smart answers focus state update

What
Update the link focus states for the simple smart answers.
Why
The new focus states weren't being used everywhere.
Where

/settle-in-the-uk

Visual changes
Before:

After:

Before:

After:

Before:

After:

I've added a card to fix the line height issue https://trello.com/c/N1qAYOME


New version: vim.vim version 9.0.1093

Pull request has been automatically created using 🛫 WinGet Releaser.
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Ralph,
I overwrote some recent commits by accident. I think what happened was that I, firstly, forgot to create a new local branch in which to make some changes, tried to sync my local repo with the master GeMS repo, and was presented with conflicts which I assumed was were my code needed to be updated. But it looks like what happened was the master code got updated with my older code, because I commited locally and then pushed everything up to the master. I tried some reverts and now my commit train looks a mess and I can't explain it. The problem is no doubt correctable by someone much more savvy in git than I, but I think the easiest thing is for you to push your local repo up to github, assuming you have the most recent.
The commit where things last looked ok is ff9810f. After that, what's there is I think what I had before I started to mess around earlier today. I will look at this again tomorrow

In fact, it looks like I did do the revert correctly (eventually). The current repo has all of the files and changes documented in commits up to Nov 14, 2018. I assumed there had been commits since then that I then completely reset and eliminated from the history, but I don't think that's the case. It all looks good as far as I can tell.

I have been making edits today and everything looks ok. I'm going to close this issue.


Load Fusion without Wine Virtual Desktop

Not sure what is causing this and how I can change this, but in a previous installation i remember fusion loading up without a wine virtual desktop having to load up and contain the fusion window, and instead fusion appeared to look "native" with my OS.
I installed using the installer script from commit: ec0e484
Is there something i can do to get the old style application display, without having wine virtual desktop start up and containing the application?

yeah man, I don't know why but sometimes when you run the install script it's configured for virtual desktop and other times it is not.  to disable virtual desktop:

export WINEPREFIX=(line 3 from logs/wineprefixes.log)
wineconfig
graphics tab->uncheck virtual desktop & save

yeah man, I don't know why but sometimes when you run the install script it's configured for virtual desktop and other times it is not. to disable virtual desktop:

export WINEPREFIX=(line 3 from logs/wineprefixes.log)
wineconfig
graphics tab->uncheck virtual desktop & save

This worked out.
Just a minor correction "wineconfig" => winecfg. Maybe they change the command between wine versions? (I'm not familiar with Wine, so not sure)

I'll leave the issue open for now, because if the virtual desktop is sometimes being used when installing but not all the time.
Perhaps there is a way to update the install script to lock it to one of the options? (preferable off, i would think)

yeah man, I don't know why but sometimes when you run the install script it's configured for virtual desktop and other times it is not. to disable virtual desktop:
1. export WINEPREFIX=(line 3 from logs/wineprefixes.log)

2. wineconfig

3. graphics tab->uncheck virtual desktop & save

I haven't found where logs are, but i used export WINEPREFIX=$HOME/.autodesk_fusion/wineprefixes/default  and then winecfg as robert said and it worked out. Thank you !

wine: could not open working directory L"unix\home\ak\", starting in the Windows directory.
I am getting this error after trying to launch winecfg. It stalls here and no window opens up

I have disabled this function in the installer by default. But we need this when we would like to safe or export our projects.


Added Chunks*Iterator/Querier/Selector interfaces and implementations + More reuse!

Finally!! :muscle: :heart:
Sorry for the huge PR, but it's really hard to avoid. Even added some TODOs for further simplifications in the next PRs to avoid having it even bigger.
TODO: Fix/add more unit tests (:

Added Chunk versions of all iterating methods. It all starts in Querier/ChunkQuerier. The plan is that
Storage will implement both chunked and samples.
Added Seek to chunks.Iterator interface for iterating over chunks.
Mock, NewTestSeries, SampleSeriesIterator, and ChunkSeriesIterator are now available from storage package and reuses instead of
being recreated in many places. NewConcreteSeries was created to replace concreteSeries.
NewMergeChunkQuerier was added; Both this and NewMergeQuerier are now using generigMergeQuerier to share the code. A generic code was added.
Both Compactor and block Querier use exactly the same iterators. (blockChunkSeriesSet).

Signed-off-by: Bartlomiej Plotka<EMAIL_ADDRESS>

Would be nice to wait for stable to go out before merging this so we can easily backport tsdb fixes into master.

Yea @roidelapluie agree with you.. it's also far to be merged. (:
@brian-brazil I will explain, but I kind of consider splitting PR even more... maybe adding interfaces first, then implementations?

Ok, sorry for the noise. Will split this into smaller pieces - it's too huge even for me to address comments. It will take ages (:


cosmos-common: fix typo in the error message

It seems we added an extra single quote at the end of the message that should be removed.
dcos package install --yes kubernetes-cluster
By Deploying, you agree to the Terms and Conditions https://mesosphere.com/catalog-terms-conditions/#certified-services
Kubernetes on DC/OS.

	Documentation: https://docs.mesosphere.com/service-docs/kubernetes-cluster
	Issues: https://github.com/mesosphere/dcos-kubernetes-quickstart/issues
Installing Marathon app for package [kubernetes-cluster] version [stub-universe]
the custom manager: '/kubernetes', is not installed for this package'

pinging @kvish for a review


add unique constraint to process_file_connection_table

Need

prevent duplicates from being added to the process_file_connection_table

Approach

add unique constraint to process_file_connection_table
handle possible duplicate key errors with a rule
prevent implicit return from breaking rule

Testing

tested manually in db

Todo

reinit db after pr for adding file extension is merged into this one

Added requested changes into upsert pr which is rebased off of this one


Duplicate counts matrix

RSEM counts are duplicated:

1 file with separate ensembID and geneName
1 file with single combined column with pipe-separation.

Keep only the pipe separated file.

Fix in #37


Error: Unable to run "adb", check your Android SDK installation and       ANDROID_HOME environment variable:

Steps to reproduce
run flutter doctor in your fedora terminal

Actual results

Logs

Logs

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.22.2, on Fedora Linux 40 (Workstation Edition)
    6.9.5-200.fc40.x86_64, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
[✗] Chrome - develop for the web (Cannot find Chrome executable at
    google-chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2023.3)
[✓] VS Code (version 1.90.2)
[☠] Connected device (the doctor check crashed)
    ✗ Due to an error, the doctor check did not complete. If the error message
      below is not helpful, please let us know about this issue at
      https://github.com/flutter/flutter/issues.
    ✗ Error: Unable to run "adb", check your Android SDK installation and
      ANDROID_HOME environment variable:
      /home/barath/Android/Sdk/platform-tools/adb
[✓] Network resources

! Doctor found issues in 2 categories.

Flutter Doctor output

Doctor output

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.22.2, on Fedora Linux 40 (Workstation Edition)
    6.9.5-200.fc40.x86_64, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
[✗] Chrome - develop for the web (Cannot find Chrome executable at
    google-chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2023.3)
[✓] VS Code (version 1.90.2)
[☠] Connected device (the doctor check crashed)
    ✗ Due to an error, the doctor check did not complete. If the error message
      below is not helpful, please let us know about this issue at
      https://github.com/flutter/flutter/issues.
    ✗ Error: Unable to run "adb", check your Android SDK installation and
      ANDROID_HOME environment variable:
      /home/barath/Android/Sdk/platform-tools/adb
[✓] Network resources

! Doctor found issues in 2 categories.

Help me setup abd in Fedora 40


[Sage-525] Sage 3 - New Upsell Component

Description

Screenshots

Before
After

Testing in sage-lib

Testing in kajabi-products

(LOW/MEDIUM/HIGH/BREAKING) Description of the change and its impact with QA as the audience.

[ ] One more examples of the component in use to either test the change or verify the change has not had adverse effects.

Related

#525

Removing this from the Sage 3 Conversion milestone, as this is a New component, not a conversion.

Closing this PR as per https://github.com/Kajabi/sage-lib/issues/525#issuecomment-994937312


WIP fix: typescript

closes #995
Haven't tested yet. Will do a npm link or install from my branch to see if it works.

nvm, I see v8.0.5!


[native_toolchain_c] Add workaround for minSdkVersion 19 and 20

Closes: https://github.com/dart-lang/native/issues/171
Uses the workaround that the Android Gradle plugin uses: https://github.com/dart-lang/native/issues/171#issuecomment-1789064713.

coverage: 97.992%. first build when pulling c4638a23f8f890db51f2864d08efa719dbab0525 on investigate-android-19-20 into 45b5e6c816ad6913412e35a87d2beee0d838eb97 on main.


Modify Caffe example to use module interface

Description
Modify Caffe example to use module interface instead of the deprecated model interface.
 I finished coding on this PR)
[x] All changes have test coverage:
[x] Code is well-documented:

@pracheer @sandeep-krishnamurthy @madjam


Implement vertx auth

Extend pluggable configuratìon.

Use our own scheme instead, vx auth us more appropriate for web-only apps.


Create yolo.js

Description

[x] I have added a folder(Named it as my GitHub user id)
[x] I have added a Readme.md file inside the folder
[x] I understand the GitHub Forking Concept fully

new


mass.play_announcement plays the file but return an error and stop any HomeAssistant scripts sequence

What version of Music Assistant has the issue?
2.1.0b8
What version of the Home Assistant Integration have you got installed?
2024.6.4
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
when using MusicAssistant service "mass.play_announcement" the file is correctly played by the media_player entity, but HomeAssistant give error and if the service call is inside a script it stop the script sequence.

same problem with the service "tts.google_say" and a MusicAssistant player as media_player entity
How to reproduce
as said below
Music Providers
www folder on HomeAssistant installation
Player Providers
Chromecast
Full log output
mass.play_announcement error:
2024-06-24 15:28:11.099 INFO (MainThread) [music_assistant.players] Playback announcement to player Camera (with pre-announce: True): http://192.168.xxx.xxx:8123/local/01.mp3
2024-06-24 15:28:14.379 ERROR (MainThread) [music_assistant.webserver] Error handling message: players/cmd/play_announcement: file not found: http:/192.168.xxx.xxx:8123/local/01.mp3

tts.google_say error:
2024-06-24 16:43:45.794 INFO (MainThread) [music_assistant.players] Playback announcement to player Camera (with pre-announce: True): http://192.168.xxx.xxx:8123/api/tts_proxy/1e4e888ac66f8dd41e00c5a7ac36a32a9950d271_en_-_google_translate.mp3
2024-06-24 16:43:46.920 ERROR (MainThread) [music_assistant.webserver] Error handling message: players/cmd/play_announcement: file not found: http:/192.168.xxx.xxx:8123/api/tts_proxy/1e4e888ac66f8dd41e00c5a7ac36a32a9950d271_en_-_google_translate.mp3

Additional information
HomeAssistant error:
ERROR (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Error executing script. Error for call_service at pos 1: MusicAssistantError: file not found: http:/192.168.xxx.xxx:8123/local/01.mp3

What version of Home Assistant Core are your running
2024.6.4
What type of installation are you running?
Home Assistant Container
On what type of hardware are you running?
Raspberry Pi

for now solved adding in the HomeAssistant scripts:
continue_on_error: true

for "mass.play_announcement" and "tts.google_say" services

The error seems clear as it indicates the file is not found but you say it actually plays correctly? Please show the whole script. If you look closely at the error you will see a missing / in the url. It shows http:/ not http://

It's not important the whole script as HomeAssistant and MusicAssistant give the error simply using the "developer tools/services" in HomeAssistant (the screenshot i took is from the developer tools).
As consequence of the error any script terminate and doesn't go further.
As workaround using "continue_on_error: true" let HomeAssistant ignore the error and continue to run the script.
The error seems clear as it indicates the file is not found but you say it actually plays correctly?

Yes the file plays correctly on the media_player. So it seems like MusicAssistant do its job correctly but incorrectly returns an error pretending the file just played doesn't exist.
If you look closely at the error you will see a missing / in the url. It shows http:/ not http://

I saw that. However you can see the url i set in the developer tools has correctly "http://", only the line that reports the error in the web-ui has "http:/".
As mentioned before the file plays well on the media_player so I'm more inclined to believe that the "http:/" is a rendering error of the web-ui.

I'm not sure whether the missing / is just a display issue. Someone else reported a similar problem adding a radio URL. Its being looked at.

I'm having the exact same issue, down to the missing forward slash on http for the error. The only addition I have is that one of my squeezelites won't even play the file. Two of my three using lms lite, play even though it errors. The two that play are esp32 based and an amd manjaro 64 bit. The one not playing the file is a rpi 4b. In addition, chromecast devices using the mass media player also give the error but still play the file for announcements as well.
Just hoped to share in case it bears any fruit.

I can add that it fails to play on Sonos as well. I'm guessing Chromecast fixes the URL internally, but other platforms don't.

I'm having the exact same issue using a Chromecast player provider. The announcement plays successfully but the logs state file not found, this seems to also prevent playing music from resuming.

The last working version is 2.1.0b7. I'd recommend reverting to that, if house approval is a factor.

Updated to MusicAssistant 2.1.0b9 the issue is still present.

You don’t need to advise that it still isn’t working unless you are advised that it should be working .

I don't know if I'am allowed to say that (as no one advised me that it should be working nor there was any mention in the changelog), however I updated MusicAssistant to 2.1.0b13 and somehow the issue seems solved: at the moment HomeAssistant doesn't give any error on mass.play_announcement service call.
I have to mention that before MusicAssistant update I also updated to HomeAssistant 2024.7.1, so I don't know what update solved the issue.
Maybe they changed something as I saw that hass-music-assistant use homeassistant.helpers.config_validation to validate the url (but I'm not a programmer, so I don't know):
media_player.py
...
import homeassistant.helpers.config_validation as cv
...
        SERVICE_PLAY_ANNOUNCEMEMT,
        {
            vol.Required(ATTR_URL): cv.string,
            vol.Optional(ATTR_USE_PRE_ANNOUNCE): vol.Coerce(bool),
            vol.Optional(ATTR_ANNOUNCE_VOLUME): vol.Coerce(int),
        },
...

Great news. Let us know if you have any problems in the future.


linter: Implement from_configuration() for jsx_a11y/anchor-is-valid

[ ] implement
[ ] test w/ config
[ ] test w/ settings

Hello! I would like to address this issue!

Yes, please go ahead! 🚀


ipCookie missing

Hello,
I have angular app inside rails, with 'angularjs-rails' gem which is providing me ngCookies and I am injecting it successfully to angular app. But I am having issues with injecting ng-auth-token receiving following error:

 Uncaught Error: [$injector:modulerr] Failed to instantiate module bookApp due to:
Error: [$injector:modulerr] Failed to instantiate module ng-token-auth due to:
Error: [$injector:modulerr] Failed to instantiate module ipCookie due to:
Error: [$injector:nomod] Module 'ipCookie' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.

Here's list of injected modules:

  var app = angular.module('bookApp', ['ngRoute',
    'ngResource',
    'ui.router',
    'templates',
    'ngCookies',
    'checklist-model',
    'ng-token-auth']);

@booleanbetrayal Your answer is still coming in handy!


no .pickle file for /infer_images folder?

I'm very confused, I see there are a lot of images in the /infer_images folder, including /reg or regularization images, and the stylegan3 examples under /ffhq.

However, the pickle file I made in step 00 (face alignment) doesn't generate or include reg images, so when it's unpickled it just contains my (single) aligned cropped photo (I used the pretty print package to display the unpickled dictionary)

and gives me an error message about missing regularization images.
the pickle_path seems to default to another hardcoded location from a fellow named gavin, and this path includes stylegan3 in the name, hence my confusion

Please advise!

Oh! no need to worry about the .pickle file for /infer_images or stylegan3 now! ^_^
Ya, so I don't know exactly which of these changes I made fixed the issue, and I'm too laxy to check, but I guess these show what I did to get it to work. I had the right target in the .yaml file actually, and since FaceIdDatasetOneShot inherits from FaceIdDatasetStyleGAN3

I still needed to adjust the latter child class.
I guess there is only one id because I'm just training myself?

But In the paper it's possible to train multiple people and have them appear separate/distinct in a generated photo (which most other AIGC methods can't do btw! so that's awesome)

The, the other change I had to make was here I think? maybe not if the defaults are overwritten anyway, I'm not sure

I just added some print statements so I could better understand the logical flow of the _load_from_pickle() method

and here you can see the print statements in the output

We add an example using StyleGAN3 synthetic faces, https://github.com/ygtxr1997/CelebBasis/commit/71da8d906f0a6f91737a2713a9943dcd3d399fbe.
If there is only one id, the specific ids should be [0] instead of [1]. In specific ids, 1 means the  second ID, https://github.com/ygtxr1997/CelebBasis/commit/12156a1d85691b858c4e69ee8c1fa9c30e680e95.


Add oci oss support for Build/Core/Lms

updated cloud-store-sdk to 1.4.6 for supporting oci oss along with supporting class changes
Type of change
Please choose appropriate options.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Ran build job Build/Core/Lms

@ddevadat - Please handle the conflicts.

closed in favour of https://github.com/Sunbird-Lern/sunbird-course-service/pull/554


Remove compute test

I don't think this is useful to have around right now and it's blocking the GLES3 backend from working with the demo.
(We can always bring this back later if we want!)

I would approve this PR if it was just the compute commit, but it also includes several other PRs in it.


CoauthorshipCora dataset label error

Sorry, my fault, I not noticed the target has been processed, please delete this issue.
#--------------------------------
Here is my code:
data = dhg.data.CoauthorshipCora()
print(data['labels'][data['train_mask']])
Print output as follow:
tensor([7, 4, 5, 1, 7, 5, 6, 4, 4, 4, 4, 2, 4, 2, 1, 3, 3, 5, 6, 6, 7, 1, 5, 4,
1, 7, 7, 7, 1, 7, 3, 1, 6, 6, 5, 7, 7, 1, 4, 6, 6, 1, 5, 6, 6, 4, 7, 3,
1, 3, 4, 5, 1, 1, 3, 3, 1, 3, 6, 3, 1, 5, 1, 5, 2, 7, 1, 1, 3, 3, 5, 5,
4, 7, 4, 1, 1, 1, 2, 1, 2, 1, 5, 6, 7, 4, 5, 4, 6, 3, 1, 6, 0, 7, 1, 4,
4, 1, 1, 6, 7, 7, 6, 5, 6, 1, 1, 4, 7, 1, 3, 7, 1, 1, 3, 1, 2, 4, 4, 0,
5, 6, 4, 6, 1, 5, 1, 7, 5, 1, 7, 2, 4, 1, 6, 4, 1, 3, 5, 6])
The labels has "7", it contains 0 to 7, but the data['num_classes'] is 7, the labels should be 0 to 6.
Please let me know if anything wrong.

Sorry, my fault, I not noticed the target has been processed, please delete this issue.


[enhancement]: Hugging Face token not needed anymore!

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
https://github.com/huggingface/diffusers/issues/1447
This can simplify the workflow for new users significantly!
Code referring to the token can be removed. e.g.:
https://github.com/invoke-ai/InvokeAI/blob/38cd968130e386d188bdef68f9fbfbbbfabb2da0/scripts/configure_invokeai.py#L536-L541
Alternatives
No response
Aditional Content
I am not sure if we have to wait for the next release of the diffusers library for this functionality to be available, but I think it is not necessary.

it seems that my excitement got the best of me, even though sd1.4 does not require a token, sd1.5 stil does, probably because one is hosted by CompVis, the other by RunWayML.
I will close this for now, maybe it will be relevant in the near future.


OR clause an order of magnitude slower than multiple queries

For a database for ~100k nodes and around ~400k relations, running two unbound queries, each matching multiple relations, a single start node and a single end node is order of magnitude faster than a single query that matches a single start node and two end nodes.
First query (single start,  single end): 0:00:00.366949
Second query (single start,  single end): 0:00:00.050112
Third query (single start,  two end nodes): 0:00:03.874311
Might be worth investigating or at least documenting.
python kuzu==0.1.0
os is debian 12

Hi @udnaan, thanks for reporting!
This is probably a performance bug. If my understanding is correct, you mean something around the line of
MATCH (a: {id:0})-[e]->(b {id:1})

is much faster than
MATCH (a: {id:0})-[e]->(b)
WHERE b.id = 1 OR b.id = 2

I wonder if it's possible for you to share the three queries here. That would very helpful for me to debug the performance difference.

MATCH p = (f:Node1)<-[r:Type1|Type2]-(t:Node1)
WHERE f.id = $id_from AND t.id = $id_to

This is expected to be a faster query because the query will only scan relationship table Type1 and Type2.
On the other side
MATCH p = (f:Node1)<-[r]-(t:Node1)
WHERE f.id = $id_from AND t.id = $id_to and (r.Type = $type1 OR r.Type = $type2)

This will force the query to scan all relationship tables connected to Node1 and then performing an additional filter  (r.Type = $type1 OR r.Type = $type2).
Whether it will be order of magnitude slower depends on the size of each relationship table.

On another note, ideally, I'd wish for something like r.Type IN $types where $types is a list but that doesn't seem to be supported afaik
We have list_contains which should give a similar functionality. I'll add the IN support (to comply with Neo4j) this week. Thanks for pointing out.

That is understandable. However the issue is that two of these
MATCH p = (f:Node1)<-[r]-(t:Node1)
WHERE f.id = $id_from AND t.id = $id_to and r.Type = $type1
RETURN properties(nodes(p), 'name')

MATCH p = (f:Node1)<-[r]-(t:Node1)
WHERE f.id = $id_from AND t.id = $id_to and r.Type = $type2
RETURN properties(nodes(p), 'name')

Are significantly faster (~30x) than one of this
MATCH p = (f:Node1)<-[r]-(t:Node1)
WHERE f.id = $id_from AND t.id = $id_to and (r.Type = $type1 OR r.Type = $type2)
RETURN properties(nodes(p), 'name')

Which is an unexpected difference in performance. One would expect a single query to be slightly faster or at least on par  with two queries that perform the same match and return the same result. Not to say that this is something that should be immediately addressed but perhaps documenting it will be sufficient.

We have list_contains which should give a similar functionality. I'll add the IN support (to comply with Neo4j) this week. Thanks for pointing out.

Thank you to pointing this out.


AccessMode ReadWriteOnce

It is mentioned above under Volumes "Azure Disks are mounted as ReadWriteOnce, so are only available to a single pod". However, in he Kubernetes official documentation (https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes), it is mentioned that "ReadWriteOnce – the volume can be mounted as read-write by a single node". Then, it means all pods in that node can Read and Write to the volume and not a single pod. Which one is correct?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 724d659c-dcc8-7c77-1994-b3e8cc62eb8f
Version Independent ID: f6c82819-267b-6d05-fb0b-ced6f4eb5ca3
Content: Concepts - Storage in Azure Kubernetes Services (AKS)
Content Source: articles/aks/concepts-storage.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

Update: It implies single pod and not all pods in a node.
Azure Disks are not capable to take that type of workload where multiple pods are writing. If the requirement is that multiple pods can read write at the same time, Azure Files are recommended to be used. Underlying Azure files driver can take update from multiple pods at a time.


exclude float64 tests

This excludes all the tests that require float64.
This solves https://github.com/geohot/tinygrad/issues/891#issue-1736175051

Err, why do those tests have float64? They seem like very generic excludes

I have no idea why these tests have float64 (maybe to ensure the correctness and accuracy of exp) but every test model contains an elem_type : 11 (I'm not sure if elem_type:11 has something to do with float64 or not)
 input {
    name: "data"
    type {
      tensor_type {
        elem_type: 11
        shape {
          dim {
            dim_value: 3
          }
          dim {
            dim_value: 2
          }
          dim {
            dim_value: 2
          }
        }
      }
    }
  }

Unclear, am going to close. I want those tests

elem_type : 11 is just float64
onnx.helper.get_all_tensor_dtypes() # dict_keys([1, 2, 3, 4, 5, 6, 7, 9, 10, 16, 11, 14, 15, 12, 13, 8, 17, 18, 19, 20])
onnx.helper.tensor_dtype_to_np_dtype(11)  # dtype('float64')


Correction to the contrib/uri.hpp grammar

ABNF strings are case insensitive [RFC 5234 (ABNF) § 2.3] so the "v" in the definition of IPvFuture [RFC 3986 (URI) § 3.2.2] can be an uppercase V. Line 61 in contrib/uri.hpp should be
-         struct IPvFuture : if_must< one< 'v' >, plus< abnf::HEXDIG >, dot, plus< sor< unreserved, sub_delims, colon > > > {};
+         struct IPvFuture : if_must< sor < one< 'v' >, one < 'V' >>, plus< abnf::HEXDIG >, dot, plus< sor< unreserved, sub_delims, colon > > > {};

or something equivalent.

Thank you, looks like you are right!
(Let me just point out that we can write sor< one< 'v' >, one< 'V' > > shorter as one< 'v', 'V' >.)

RFC 3986 references RFC 2234 for ABNF, not RFC 5234, but there's no difference, both state that quoted strings are case-insensitive ASCII.

Duly noted, thanks ! (Your reactivity is quite something !)

Small things are better dealt with immediately (when there are 5 minutes to spare) :-)


AIP-135: allow force and etag in method_signature

AIP-135's linter rule only allow name: https://linter.aip.dev/135/method-signature
This contradicts AIP-135 guidance:
There should be exactly one google.api.method_signature annotation, with a value of "name". If an etag or force field are used, they may be included in the signature.

Should we be allowing force and etag in method_signature?

Should we be allowing force and etag in method_signature?

I think we should allow them, yes. We shouldn't require all possible combinations for any given service. The method signatures are really only shortcuts - library users can still populate a whole request if they want to. But I think the linter should allow them to be present. I think we should also allow there to be multiple signatures... otherwise we can't go from "one signature of just name" to "one for name, and one for name+etag".
We probably want to require that name is present in every signature though.


[SILGen] Fix a crash when a closure is converted to a block returning a value indirectly

Fix the type of the function argument added to the entry basic block.
rdar://127745392

@swift-ci please test

@swift-ci please test macOS

There's a bug (assertion failure) in IRGen, which I found just now.

@swift-ci please test

@swift-ci please test


[stable/grafana] Add support for extraExposePorts

Is this a new chart: no
What this PR does / why we need it:
exposing other service ports for sidecar containers.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@inseinjee
Could bump the chart version to latest please? Thank you.

/assign

/ok-to-test

/lgtm


travis: Build the production Dockerfile

By building the production Dockerfile as part of CI, we'll catch
errors before they get into the docker build system.  This would have
caught a rather annoying error much earlier in the development
process.

Ideally, this should fail travis as docker is currently broken.  Once we've fixed docker, travis should be happy and we should mere.

Build failed for the right reason.


BIOS Image download graph hangs during the workflow - leaves the node hung up

See internal ODR-597.
When we perform a BIOSImage to the node, the node gets stuck part way through the update at the screen shot attached - showing last line is "Stopping userspace bootsplash".
Tested on our releases 1.00, 1.1, both work ok.
https://---/redfish/v1/Systems/56e5e71a03791fa907aec37d/OEM/OnRack/Actions/BIOSImage
{ "filename": "S2S_3A14.BIN" }

{
<EMAIL_ADDRESS>"#Task_1_0_0.Task",
"Name": "Flash Quanta BIOS",
"TaskState": "Pending",
"Messages": [],
<EMAIL_ADDRESS>"/redfish/v1/TaskService/Tasks/65cc2254-3a56-4dff-9b46-4894ad3a7f61",
<EMAIL_ADDRESS>null,
"TaskStatus": "OK",
"StartTime": "2016-03-14T01:47:31.168Z",
"Description": "",
"EndTime": "2016-03-14T01:47:31.168Z",
"Id": "65cc2254-3a56-4dff-9b46-4894ad3a7f61",
"Oem":
{ "SystemId": "56e5e71a03791fa907aec37d" }

}

The task stays in pending and the node stays 'stuck' (we let it sit overnight) until I hit a ctrl-alt-del at the kvm window. From there the node continues to boot, firmware does not get upgraded, and we get a failed task back.
full task logs on the internal bug.
module:  Job.Catalogs.ProvideData
name:    ProvideCatalogDataJob
options:
  source: ami
  path:   systemRomId
taskId:  e55bfb00-004d-46ab-9bb1-0f874a596ee3
target:  56e5e72503791fa907aec387
[error] [2016-03-14T15:08:58.326Z] [on-taskgraph] [Task.Task] [Server] Task failed
 -> /node_modules/on-tasks/lib/task.js:261
error:          Error: Could not find a catalog entry for ami
taskId:         e55bfb00-004d-46ab-9bb1-0f874a596ee3
graphId:        de2a3164-f996-46b0-b0b8-fb79b43dcabc
injectableName: Task.Catalogs.Provide.Ami.BiosVersion
node:           56e5e72503791fa907aec387
[info] [2016-03-14T15:08:58.331Z] [on-taskgraph] [TaskGraph.TaskRunner] [Server] Task finished
 -> /lib/task-runner.js:296
instanceId:   e55bfb00-004d-46ab-9bb1-0f874a596ee3
state:        failed
taskRunnerId: 5e768d95-49f2-4a90-b245-457e6ea3a869
[debug] [2016-03-14T15:08:58.334Z] [on-taskgraph] [TaskGraph.TaskScheduler] [Server] Listener received task finished event, triggering evaluation
 -> /lib/task-scheduler.js:525
data:
  taskId:           e55bfb00-004d-46ab-9bb1-0f874a596ee3
  graphId:          de2a3164-f996-46b0-b0b8-fb79b43dcabc
  state:            failed
  error:
    """
      Error: Could not find a catalog entry for ami
          at /var/renasar/on-taskgraph/node_modules/on-tasks/lib/jobs/provide-catalog-data.js:67:23
          at tryCatcher (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
          at Promise._settlePromiseFromHandler (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/promise.js:507:31)
          at Promise._settlePromiseAt (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/promise.js:581:18)
          at Async._drainQueue (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
          at Async._drainQueues (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
          at Async.drainQueues (/var/renasar/on-taskgraph/node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)
          at process._tickDomainCallback (node.js:459:13)
    """
  context:

FYI @leoyjchang

@hohene :
For quanta BIOS update, it needs a special overlayfs because it needs some specified tools, so could you please first confirm you have used the correct overlayfs?

We are still hitting this issue.  Here's comments from the ODR - please see the ODR 597 for the latest logs.
Per Felix last round of comments:
tried on another Quanta, it has the same issue. I guess it may be due to following reason:
(1) We built a wrong overlayfs, the ami tools are broken. The probability is relative low because we should have use the same build procedure.
(2) The compatibility issue between the kernel and overlayfs. Because I see the microkernl kernel and fs is v3.16, but the overlayfs version that used in flash-quanta-bios is v3.13.
Hou, Andrew Heck, Joseph Broderick Phillips, Ben do you have any insight on this?
options: {
kernelFile: 'vmlinuz-3.16.0-25-generic',
initrdFile: 'initrd.img-3.16.0-25-generic',
kernelUri: '{{ api.server }}/common/{{ options.kernelFile }}',
initrdUri: '{{ api.server }}/common/{{ options.initrdFile }}',
basefs: 'common/base.trusty.3.16.0-25-generic.squashfs.img',
overlayfs: 'common/discovery.overlay.cpio.gz',
profile: 'linux.ipxe',
comport: 'ttyS0'
},
"bootstrap-ubuntu": {
"basefs": "common/base.trusty.3.13.0-32.squashfs.img",
"overlayfs": "common/overlayfs_quanta_t41_flash-v1.1-3.13.0-32.cpio.gz"
},
}

We ran the test again using code base from 4/13/2016 for the last round of testing.

@yyscamper @hohene: If it helps, the Quanta BIOS firmware upgrade was retooled: https://github.com/RackHD/on-skupack/tree/master/quanta-t41 and no longer requires the overlayfs.  The updated afulnx_64 included in the newer BIOS packages no longer has the runtime dependency to build a driver.
There is an open issue with the download files task not functioning: https://github.com/RackHD/on-http/issues/215, so once you get past the catalog issue you should encounter that failure with the 4/13/2016 build.

@hohene ^^ this won't help you with the 1.2 release work you're doing though, since we're not immediately incorporating SKU pack support into it. This refactor work is going to be effective in some  release after 1.2...

In the current images the overlayfs is missing the necessary files for the bundled afulnx_64 version to build the driver that it needs.  You may want to switch to the newer afulnx_64 binary that was used for the skupack work.

@hohene: If you are using the latest code, you also need to wait for this to go in: https://github.com/RackHD/on-http/pull/230.  After you get past the hangup caused by the afulnx binary in the 3.13 overlays, you will have an issue with the images being inaccessible.  The commit above re-exposes the files/md5sums on the southbound side.

@hohene ODR reference 597 has been closed out.  Is this github issue ready for closure as well?

Closing out issue, ODR-597 is no longer open.


WIP: Add support for saving to Reader

I made a start on https://github.com/andjosh/readwise-ruby/issues/1
I'm wondering if the existing code should be refactored to separate out the v2 and v3 APIs?

🤔 I don't know if the refactoring needs to happen now. The versions aren't in conflict with one another, and I (as a user) would rather not have to worry about the versioned interface (other than the version of the gem itself).

@andjosh @andyw8  If we could start namespacing it would be helpful. My take is that at any point if we need to maintain two versions of a feature it would be troublesome. We may not need to refactor old ones but new ones can go into whatever versioning they are in and we can eventually refactor the rest.
I can also pitch in.


release cycle

The libraries haven't been released under a new version for a while now.
Is the release cycle changed deliberately or is there something blocking it?

Hi @THETCR!
Recently we started using a new workflow internally that allows to deploy changes faster to the GitHub service without having to release gems explicitly to rubygems.org. Because of this, our release cycle to rubygems.org has become slower. I assume that's what you're asking about, right? We do plan to release a new version soon, and to make releasing to rubygems.org more frequent in general, most likely with some regular cadence. We'll let you know once we have something more concrete in place!

Hi @deivid-rodriguez. I'll echo @THETCR's comments, and to answer your question: yes, talking specifically about releases to rubygems.org.
The 0.215.0 release from Dec 7 is pretty long in the tooth and some of my projects that don't use the GitHub service are "stuck" until a new release is put out to rubygems.
I appreciate the update and am appreciative of the team. If this lapse of deployment to rubygems in the short term means long term benefits, I'll take it!

Hi @THETCR!
Recently we started using a new workflow internally that allows to deploy changes faster to the GitHub service without having to release gems explicitly to rubygems.org. Because of this, our release cycle to rubygems.org has become slower. I assume that's what you're asking about, right? We do plan to release a new version soon, and to make releasing to rubygems.org more frequent in general, most likely with some regular cadence. We'll let you know once we have something more concrete in place!

Would it be possible to share some insights about this workflow you're referring to? Or is that private/secret information?
I am currently consuming the dependabot core docker image  while still using the code directly. I do not consume the published gems
As a side note, the latest tag of this image was published about a month ago, but the latest tag is from over 3 months

We consume the built images directly, without needing to publish any gems to rubygems.org. So, yeah, that's a good idea if you don't want to depend on rubygems.org releases :)
The reason that image is out of date is because we have switched to building ecosystem specific images, to avoid having to maintain a giant monolithic image. The newer images are  here.

@deivid-rodriguez Do You somehow manage breaking changes between the code and all the built images? Before, the big monolithic image followed the same release cycle which doesn't seem to be the case anymore.
I was usually updating both the docker image and the gems together before. I wonder what would be the better approach now to not run in to situation where ruby code might not be compatible with one of the images (or you just make sure that all changes to docker images are backwards compatible?)

We don't make such backwards compatibility considerations at this stage. The idea is to have a regular release cadence so we can do with you did before and update images and code at the same time.

We consume the built images directly, without needing to publish any gems to rubygems.org. So, yeah, that's a good idea if you don't want to depend on rubygems.org releases :)
The reason that image is out of date is because we have switched to building ecosystem specific images, to avoid having to maintain a giant monolithic image. The newer images are here.

Do you have any example combining more than one ecosystem in one image? The previous setup worked really well for us and now it seems that we'll need to manage each one separately :/

No, I don't, sorry. When you come up with something feel free to share it with the rest of the community!

Hi @deivid-rodriguez ,
A solution would've been easily implemented by end-users if Dependabot supported updating gems that are directly sourced from git repositories.
Sadly it seems this is not supported (yet).

@deivid-rodriguez
I opened an issue for it (#6816 )

I spent some time thinking about ways we could improve this, and wrote up a tracking ticket here:

https://github.com/dependabot/dependabot-core/issues/7132

It has a bunch of notes, which seemed best as the first "first" post in an issue, so that's why I created a new ticket rather than tracking it here. So I'm going to close this one in favor of that...
It also highlights a few decisions we need to make, so I/we would appreciate input from the community if there's bits you have an opinion on.


Failing to run on Windows

I'm working on Win10x64.
npm Version 6.14.5
$ npm install delivers following warnings:
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\postcss-cli\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

$ npm start the following:
><EMAIL_ADDRESS>start [...]\wikibattle
> bin/wikibattle

Der Befehl "bin" ist entweder falsch geschrieben oder ("Command 'bin' was spelled wrong)
konnte nicht gefunden werden. (or couldn't be found.")
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>start: `bin/wikibattle`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!     [...]\AppData\Roaming\npm-cache\_logs\2020-06-17T08_19_31_038Z-debug.log

$ node bin/wikibattle at least works as such, but I will get this error message when looking at localhost:3000:
Not Found
404
Error: Not Found
    at [...]\wikibattle\src\app.js:99:15
    at Layer.handle [as handle_request] ([...]\wikibattle\node_modules\express\lib\router\layer.js:95:5)
    at trim_prefix ([...]\wikibattle\node_modules\express\lib\router\index.js:317:13)
    at [...]\wikibattle\node_modules\express\lib\router\index.js:284:7
    at Function.process_params ([...]\wikibattle\node_modules\express\lib\router\index.js:335:12)
    at next ([...]\wikibattle\node_modules\express\lib\router\index.js:275:10)
    at SendStream.error ([...]\wikibattle\node_modules\serve-static\index.js:121:7)
    at SendStream.emit (events.js:209:13)
    at SendStream.error ([...]\wikibattle\node_modules\send\index.js:270:17)
    at SendStream.onStatError ([...]\wikibattle\node_modules\send\index.js:421:12)

Would you be so kind and point me to a place to start looking for the issue?
The stacktraces aren't really helpful for me.
I have also tried to tell npm to use the terminal which comes with Git for Windows, which delivered the same result in the browser.
Of course I deleted npm's cache and the node_modules more than once, I even deleted the whole directory once and cloned from GitHub again.
Or is this rather a feature (not running under windows, only on Linux or OSX) than a bug?

we can change the "start" script to do node bin/wikibattle!
For the second issue, I think the html file isn't copied correctly. npm run html copies the index.html file from src/client/index.html in the public/ folder, which contains all the public static files. I think we may need to add it to the "prod" npm script at the end? npm run html is probably not windows-compatible unless you use mingw.
(A cool PR would be to use https://www.npmjs.com/package/cpy-cli instead of cp!)


Data dictionary for SDWIS

Note that there is already a data dictionary for SDWIS https://ofmpub.epa.gov/sor_internet/registry/datareg/searchandretrieve/datadictionaries/browse.do;jsessionid=2c9998464ce557f470536f9aad384e6001db2a0f2940d54cb3b10031ff4b3d35?displayDetails=&id=7300&verNr=1.0 However:

We want this to be in markdown format.
Each description should be more concise.
If all data is missing, we do not need to describe it in the data dictionary.
Is there anything interesting about the data not described in the EPA's data dict that would be important to note in ours?

With pull request #62, fields of interest have been added to the documentation. Two next steps: Add primary key/foreign key labeling, and add descriptions to these fields. After this, the "tldr" version of SDWIS data documentation will be in a good spot.


[No QA] Add DEBUG_ONYX_SET_STATE mode

Details
This PR will add the ability to debug Onyx setState() calls in development by opt-in
Fixed Issues
No issue in particular
Tests

Pull https://github.com/Expensify/react-native-onyx/pull/188 down
Copy /react-native-onyx to App/node_modules/react-native-onyx
Set ONYX_DEBUG_SET_STATE=true in .env
npm run web
Verify that you now see the Onyx Debug logs

[ ] Verify that no errors appear in the JS console

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps
None
Screenshots

Web

Mobile Web - Chrome
Testing on web should be sufficient as there is no UI changes and this is an opt-in behavior
Mobile Web - Safari
Testing on web should be sufficient as there is no UI changes and this is an opt-in behavior
Desktop
Testing on web should be sufficient as there is no UI changes and this is an opt-in behavior
iOS
Testing on web should be sufficient as there is no UI changes and this is an opt-in behavior
Android
Testing on web should be sufficient as there is no UI changes and this is an opt-in behavior

This one's ready now.

Hmm that's weird. I wonder if it's my changes or another recent change. There have been a few actually so maybe No QA isn't a good look 😄

Looks like tests were broken by 1.0.18. Gonna check that out now and see if I can figure out why. We haven't updated Onyx  in App for a few changes.

Actually, looks like the Onyx version with my changes was merged already here. But since then new changes were made here and a new Onyx version released.

Current QA steps are correct still (as those were not tested yet).
Going to do some additional testing on all platforms before taking this out of draft to make sure 1.0.22 doesn't break anything.

Ok tested on all platforms with the new Onyx version and this is ready for review. Mostly just did a smoke test and confirmed things aren't totally broken, but added videos for everything.

This PR will need to HOLD until https://github.com/Expensify/Web-Expensify/pull/35134 is on production as bumping the Onyx version breaks the IOU details page.

I guess we have already bumped Onyx in this PR here while I was OOO so this is no longer needed.