Cannot open the app

Hi,
I have used air-fullscreen ane 1.2.x before, everything works fine but sometimes cannot hide the navigation bar automatically. It seems that the issue is fixed, so that I downloaded the latest version 1.3.3. However after I have packaged the apk and installed on my device, the app cannot start. Eclipse only showing that Process com.xxx.xxx has died.
Thanks,
William

Can you confirm that you're using AIR 17 or above? (See issue #14)
Does this issue only affect a specific device or OS version?
Is there any additional information about the cause of the crash in DDMS?

Thanks for your reply, yes the problem is swf-version. I am using version 25 so that errors occurred. Now the app work great.


fix error message positioning on amount page

Details

https://github.com/Expensify/App/issues/29204#issuecomment-1755717630
Using absolute position for the error message to avoid displacing the input
Fixed Issues

$ https://github.com/Expensify/App/issues/29204
PROPOSAL: https://github.com/Expensify/App/issues/29204#issuecomment-1755717630
Tests

Login to ND
Click on FAB > Request Money > Manual
Click on Next
Verify that the error message is shown and input isn't displaced

[x] Verify that no errors appear in the JS console

Offline tests

na
QA Steps

Login to ND
Click on FAB > Request Money > Manual
Click on Next
Verify that the error message is shown and input isn't displaced

[x] Verify that no errors appear in the JS console

PR Author Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for the expected offline behavior in the Offline steps section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[ ] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

I'm using '12px of gap' below the error message, the same value that we use for non-touch devices (Web, Desktop) when BigNumberPad is not present.

What is original value?

Please share screenshot (before fix and after fix). We can always get approval from design team

cc: @Expensify/design for the best padding selection

I'm cool with 12px but can you show a side-by-side of what it looks like both with and without the error message present?

12px feels good to me too. (+1 I would also like to see side-by-side of with and without on a pretty common viewport size)

Yup, same!

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/108292595/c6154f23-578a-45e6-b097-5dbf1ca02ca5

Mobile Web - Chrome
https://github.com/Expensify/App/assets/108292595/ffd0d7c8-e9c6-4bcc-a1b1-79dbc61f9a03

Mobile Web - Safari
https://github.com/Expensify/App/assets/108292595/7c7ba417-08bc-47e0-aeab-f6fc323e8868

Desktop
https://github.com/Expensify/App/assets/108292595/1d944951-83a7-43db-b4ca-52e974addb3d

iOS
https://github.com/Expensify/App/assets/108292595/47f69d4c-19b8-435d-82d7-ff44b89ba5e4

Android
https://github.com/Expensify/App/assets/108292595/b0e82f4a-dcc5-4808-8f1d-6507fc294683

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.93-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.93-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.94-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.94-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.94-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


juniper_hyper in cartes.io needs to be updated?!

I'm very very a newbie in rust and juniper.
I've installed juniper_hyper using cargo.
The problem was I get an compile error with this code.
juniper_hyper::playground("/graphql").await
// Error: the trait bound `impl futures::future::Future: std::future::Future` is not satisfied
// required by `std::future::Future::poll`rustc(E0277)

Maybe, I think because this juniper_hyper uses futueres 0.1.29, so it can't use async/await syntax.
juniper_hyper 0.5.2 in Crates.io has futures^0.1 dependency
So, juniper_hyper needs to be updated to use futures 0.3^ which can use async/await syntax.
And also, I'm wondering why Cargo.toml of juniper_hyper 0.5.2 has futures 0.3.1 dependency, while juniper_hyper in Crates.io has futures^0.1.
Thank you.

Hello! Yes, the crates.io release is only compatible with an older hyper unless you use the compat layer of the futures crate. I would suggest using master of juniper and juniper_hyper until we do another release (soon, see https://github.com/graphql-rust/juniper/issues/737).
For version numbers on master, we only bump when doing a release so what is on master is not what is on crates.io even though the version numbers appear to be the same.


Huge handoff/matchups update

Okay Matt!
Here's the PR for the scripts/etc I mentioned in the email on Friday. It's huge, but most of it is redundant of previous PRs/PRs from ROSS_RS_mini_tools.
File overview:

GEE_scripts/guat_elsal_hon_getCenters.js: this is a modified version of Xiao's Chebyshev centers script -- I modified some of the parameters for use in our Rmd scripts, but this is nearly verbatim Xiao's script.
landsat_c2/forHandoffs/LandsatC2_M4-7_SurfaceRefTempStacks.Rmd, landsat_c2/forHandoffs/LandsatC2_M8-9_SurfaceRefTempStacks.Rmd, landsat_c2/forHandoffs/pySetup.R are dupes of the landsat_cs/literate_code/ folders, but they use the Chebyshev centers produced by the above script.
landsat_c2/literateCode/LandsatC2_M8-9_SurfaceRefTempStacks.Rmd - small tweaks to clean up the script.
programs/1_RS_collate_harmonize.Rmd small tweaks to account for additional GEE output in same folder (aka, more files from the landsat_c2/forHandoffs scripts
programs/3_regionalRS_collate_harmonize.Rmd - this is the same as the script programs/1_RS_collate_harmonize.Rmd, except it does collation of the regional Chebyshev center data.
programs/4_regional_handoff_calcs.Rmd - tweaks to account for more data from the regional Landsat stack.
programs/5_apply_handoff_coefficients.Rmd - little file to apply coefficients from programs/4_regional_handoff_calcs.Rmd to the Yojoa LS stack
programs/6_add_era5_data.Rmd - little file to add the ERA5 data to the Yojoa stack
programs/7_LSC2_secchi_matchup.Rmd - edited this to overmatch and filter by date window
I updated a bunch of the README's to clean up the repo

Progress:
Closes #9

@kathryn-willi will you please look at the README files in these to make sure they make sense?? THANK YOU!

That's a great point, @kathryn-willi! I'll add a little text to the primary readme to help with this.


script/build: prune the prod builds

Makes it so the build script applies all optimizations, rather than just some :sparkles:

Hurray for zopfli(1) :tada:


how to Set height and width of textdrawable

.beginConfig()  not accessale

[x] I have verified there are no duplicate active or recent bugs, questions, or requests
[x] I have verified that I am using the latest version.

Device/App info:

TextDrawable Version: ?
Android version: ?
Device Manufacturer: ?
Device Name: ?

Describe the bug
A clear and concise description of what the bug is.
Reproduction Steps

Expected behavior

Screenshots

Code and/or Logs

println("Hello, world!")

java.lang.RuntimeException: This is an example Exception log
    at com.package.name.HelloWorld
    at com.package.name.HelloWorld$ThisIsNotARealLog
    at android.app.Instrumentation.callActivityOnResume(Instrumentation.kt)

Additional context

use the xml properties or the corresponding methods like with any other view
https://github.com/jahirfiquitiva/TextDrawable#1-create-simple-tile


Monster Party Scene - add logic for navigating between monsters

In the current implementation of the monster party scene, when you try to navigate between the monsters in the party (if there is more than 1), the navigation does not work. Instead, you can only select the 1st monster in your party or the cancel button.
We need to add logic to support navigating between more than one monster.

This is being addressed as part of the code being worked on for https://github.com/devshareacademy/monster-tamer/issues/101.


Cold/Flu: Pre-populate 'Province' & 'Country' under Worksite Information

User Story
As an applicant, while filling my worksite information, it would be great for me to see the 'Province' and 'Country' pre-populated to 'BC' and 'Canada'.
Tasks
TBD
Acceptance Criteria
Auto-populate the 'Province' and 'Country' fields, as 'BC' and 'Canada' respectively -  We only service the province so there shouldn’t be a need for a further reach than that.

Working great in TEST

@Stella-Archer - I've confirmed that "BC" and "Canada" are pre-populated in the test environment.

sweet - PO approved and Closing this :)

Post  Deployment Test:
Looks good live :)

Closing


go routine leak

After libbpfgo.(*BPFLink).Destroy() call.
Detected while tackling tracee integration tests go routine leaks:
leaks.go:78: found unexpected goroutines:
        [Goroutine 421 in state syscall, with github.com/aquasecurity/libbpfgo._Cfunc_bpf_link__destroy on top of the stack:
        goroutine 421 [syscall]:
        github.com/aquasecurity/libbpfgo._Cfunc_bpf_link__destroy(0x7f942c710290)
                _cgo_gotypes.go:554 +0x4c
        github.com/aquasecurity/libbpfgo.(*BPFLink).Destroy.func1(0xa9ee1c?)
                /root/go/pkg/mod/github.com/aquasecurity/libbpfgo@v0.4.6-libbpf-1.1.0/libbpfgo.go:195 +0x46
        github.com/aquasecurity/libbpfgo.(*BPFLink).Destroy(0xc000fa98c0)
                /root/go/pkg/mod/github.com/aquasecurity/libbpfgo@v0.4.6-libbpf-1.1.0/libbpfgo.go:195 +0x25
        github.com/aquasecurity/tracee/pkg/ebpf/probes.(*traceProbe).detach(0xc0016e0570, {0xc003749b38?, 0xac5886?, 0xc0009396e0?})
                /home/gg/code/tracee/pkg/ebpf/probes/trace.go:82 +0x36
        github.com/aquasecurity/tracee/pkg/ebpf/probes.(*probes).DetachAll(0xc0009396f8?)
                /home/gg/code/tracee/pkg/ebpf/probes/probes.go:188 +0x92
        github.com/aquasecurity/tracee/pkg/ebpf.(*Tracee).Close.func1()
                /home/gg/code/tracee/pkg/ebpf/tracee.go:1428 +0x3a
        github.com/aquasecurity/tracee/pkg/capabilities.(*Capabilities).Required(0xc0002930c0, 0xc003749c68?)
                /home/gg/code/tracee/pkg/capabilities/capabilities.go:174 +0xc4
        github.com/aquasecurity/tracee/pkg/ebpf.(*Tracee).Close(0xc000612500)
                /home/gg/code/tracee/pkg/ebpf/tracee.go:1425 +0x89
        github.com/aquasecurity/tracee/pkg/ebpf.(*Tracee).Run(0xc000612500, {0x22a9d20, 0xc0010a0000})
                /home/gg/code/tracee/pkg/ebpf/tracee.go:1419 +0x8a5
        created by github.com/aquasecurity/tracee/tests/integration.startTracee
                /home/gg/code/tracee/tests/integration/tracee.go:72 +0x3f1
        ]
--- FAIL: Test_EventFilters (29.57s)

Context:

https://github.com/aquasecurity/tracee/pull/2784#issuecomment-1462854146

This is being solved after aquasecurity/trace#2784 was merged and through work on aquasecurity/trace#2688.

This seemed a false positive and is being solved after aquasecurity/trace#2784 was merged and through work on aquasecurity/trace#2688.


Multiline logs entry stays multiline when it is written to a file.

Hi,
It used to work because I referenced it in another issue #9 (which was not one).
But it does not work anymore:

time="2017-06-12T17:36:43+02:00" level=error msg="Command failed" ... Msg="raidcom: [EX_CMDRJE] An order to the control/command device was rejected
It was rejected due to SKEY=0x05, ASC=0x26, ASCQ=0x00, SSB=0xB958,0x0233 on Serial#(358702)
CAUSE : It cannot be deleted because the operation object LU is executing host I/O.
" Nature=Locked RequestID=2eebe597-e33a-55be-bd78-35d7ef6db86f Status=221 Subcommand=delete ....

I noticed that you use %v method for quoting, but as shown here that does not work as intended.
You may use fmt.Fprintf(b, "%q", value) instead but you'll need to strip the first and final character to remove the quotes.
Do you want me to do a pull request of any kind?

Removing quotes seems to be wrong but if there's no other way I'll accept that. PR would be welcomed.

I think that I'll remove QuoteCharacter option like they did for logrus https://github.com/sirupsen/logrus/pull/580


Oops; flutter has exited unexpectedly. (Version.Version.parse)

New version code is failing on parsing Android Studio version
(file upload doesn't support log so just dumped it here)
more /home/darrell/IdeaProjects/flutter/examples/flutter_gallery/flutter_01.log
Flutter crash report; please file at https://github.com/flutter/flutter/issues.
command
flutter --no-color upgrade
exception
FormatException: Could not parse "3.2".
package:pub_semver/src/version.dart 116                                Version.Version.parse
package:flutter_tools/src/android/android_studio_validator.dart 117    ConfiguredGradleValidator.validate
package:flutter_tools/src/doctor.dart 126                              Doctor.diagnose
package:flutter_tools/src/commands/upgrade.dart 80                     UpgradeCommand.runCommand
package:flutter_tools/src/runner/flutter_command.dart 148              FlutterCommand.verifyThenRunCommand
package:flutter_tools/src/runner/flutter_command.dart 119              FlutterCommand.run
package:args/command_runner.dart 194                                   CommandRunner.runCommand
package:flutter_tools/src/runner/flutter_command_runner.dart 221       FlutterCommandRunner.runCommand
package:args/command_runner.dart 109                                   CommandRunner.run.<fn>
dart:async                                                             Future.Future.sync
package:args/command_runner.dart 109                                   CommandRunner.run
package:flutter_tools/src/runner/flutter_command_runner.dart 150       FlutterCommandRunner.run
package:flutter_tools/executable.dart 128                              main.<fn>.<fn>
package:stack_trace                                                    Chain.capture
package:flutter_tools/executable.dart 127                              main.<fn>
package:flutter_tools/src/base/context.dart 76                         AppContext._run
package:flutter_tools/src/base/context.dart 66                         AppContext.runInZone.<fn>
dart:async                                                             runZoned
package:flutter_tools/src/base/context.dart 65                         AppContext.runInZone
package:flutter_tools/executable.dart 98                               main
/home/darrell/flutter/packages/flutter_tools/bin/flutter_tools.dart 8  main
===== asynchronous gap ===========================
dart:async                                                             _Completer.completeError
package:flutter_tools/src/android/android_studio_validator.dart 136    ConfiguredGradleValidator.validate
===== asynchronous gap ===========================
dart:async                                                             Future.Future.microtask
package:flutter_tools/src/android/android_studio_validator.dart        ConfiguredGradleValidator.validate
package:flutter_tools/src/doctor.dart 126                              Doctor.diagnose
===== asynchronous gap ===========================
dart:async                                                             _asyncThenWrapperHelper
package:flutter_tools/src/doctor.dart                                  Doctor.diagnose
package:flutter_tools/src/commands/upgrade.dart 80                     UpgradeCommand.runCommand
===== asynchronous gap ===========================
dart:async                                                             _asyncThenWrapperHelper
package:flutter_tools/src/commands/upgrade.dart                        UpgradeCommand.runCommand
package:flutter_tools/src/runner/flutter_command.dart 148              FlutterCommand.verifyThenRunCommand
===== asynchronous gap ===========================
dart:async                                                             _asyncThenWrapperHelper
package:flutter_tools/src/runner/flutter_command.dart                  FlutterCommand.verifyThenRunCommand
package:flutter_tools/src/runner/flutter_command.dart 119              FlutterCommand.run
package:args/command_runner.dart 194                                   CommandRunner.runCommand
===== asynchronous gap ===========================
dart:async                                                             Future.Future.microtask
package:args/command_runner.dart                                       CommandRunner.runCommand
package:flutter_tools/src/runner/flutter_command_runner.dart 221       FlutterCommandRunner.runCommand
===== asynchronous gap ===========================
dart:async                                                             _asyncThenWrapperHelper
package:flutter_tools/src/runner/flutter_command_runner.dart           FlutterCommandRunner.runCommand
package:args/command_runner.dart 109                                   CommandRunner.run.<fn>
dart:async                                                             Future.Future.sync
package:args/command_runner.dart 109                                   CommandRunner.run
package:flutter_tools/src/runner/flutter_command_runner.dart 150       FlutterCommandRunner.run
package:flutter_tools/executable.dart 128                              main.<fn>.<fn>
===== asynchronous gap ===========================
dart:async                                                             Future.Future.microtask
package:flutter_tools/executable.dart                                  main.<fn>.<fn>
package:stack_trace                                                    Chain.capture
package:flutter_tools/executable.dart 127                              main.<fn>

flutter doctor
encountered exception: FormatException: Could not parse "3.2".

#0      Version.Version.parse (package:pub_semver/src/version.dart:116)
#1      ConfiguredGradleValidator.validate (package:flutter_tools/src/android/android_studio_validator.dart:117)
<asynchronous suspension>
#2      Doctor.diagnose (package:flutter_tools/src/doctor.dart:126)
<asynchronous suspension>
#3      _doctorText.<anonymous closure> (package:flutter_tools/executable.dart:222)
#4      AppContext._run (package:flutter_tools/src/base/context.dart:76)
<asynchronous suspension>
#5      AppContext.runInZone.<anonymous closure> (package:flutter_tools/src/base/context.dart:66)
#6      _rootRun (dart:async/zone.dart:1150)
#7      _CustomZone.run (dart:async/zone.dart:1026)
#8      runZoned (dart:async/zone.dart:1503)
#9      AppContext.runInZone (package:flutter_tools/src/base/context.dart:65)
#10     _doctorText (package:flutter_tools/executable.dart:222)
<asynchronous suspension>
#11     _createCrashReport (package:flutter_tools/executable.dart:197)
<asynchronous suspension>
#12     main.<anonymous closure>.<anonymous closure> (package:flutter_tools/executable.dart:169)
#13     _rootRunBinary (dart:async/zone.dart:1170)
#14     _ZoneDelegate.runBinary (dart:async/zone.dart:714)
#15     StackZoneSpecification._handleUncaughtError (package:stack_trace/src/stack_zone_specification.dart:141)
#16     _CustomZone.handleUncaughtError (dart:async/zone.dart:1005)
#17     _Future._propagateToListeners (dart:async/future_impl.dart:586)
#18     _Future._completeError (dart:async/future_impl.dart:485)
#19     _SyncCompleter._completeError (dart:async/future_impl.dart:56)
#20     _Completer.completeError (dart:async/future_impl.dart:27)
#21     main.<anonymous closure>.<anonymous closure> (package:flutter_tools/executable.dart:130)
<asynchronous suspension>
#22     Chain.capture.<anonymous closure> (package:stack_trace/src/chain.dart:93)
#23     _rootRun (dart:async/zone.dart:1150)
#24     _CustomZone.run (dart:async/zone.dart:1026)
#25     runZoned (dart:async/zone.dart:1503)
#26     Chain.capture (package:stack_trace/src/chain.dart:91)
#27     main.<anonymous closure> (package:flutter_tools/executable.dart:127)
<asynchronous suspension>
#28     AppContext._run (package:flutter_tools/src/base/context.dart:76)
<asynchronous suspension>
#29     AppContext.runInZone.<anonymous closure> (package:flutter_tools/src/base/context.dart:66)
#30     _rootRun (dart:async/zone.dart:1150)
#31     _CustomZone.run (dart:async/zone.dart:1026)
#32     runZoned (dart:async/zone.dart:1503)
#33     AppContext.runInZone (package:flutter_tools/src/base/context.dart:65)
#34     main (package:flutter_tools/executable.dart:98)
<asynchronous suspension>
#35     main (file:///home/darrell/flutter/packages/flutter_tools/bin/flutter_tools.dart:8)
#36     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:259)
#37     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)

## Flutter Doctor
Running flutter doctor...
[✓] Flutter (on Linux, channel master)
    • Flutter at /home/darrell/flutter
    • Framework revision a745fd58be (29 minutes ago), 2017-02-22 14:35:49
    • Engine revision ab09530927
    • Tools Dart version 1.23.0-dev.0.0

[✓] Android toolchain - develop for Android devices (Android SDK 25.0.0)
    • Android SDK at /home/darrell/Android/Sdk
    • Platform android-25, build-tools 25.0.0
    • Java(TM) SE Runtime Environment (build 1.8.0_121-b13)

[-] Android Studio (version 2.3)
    • Android Studio at /home/darrell/android-studio
    ✗ Gradle not found.
    • Try updating or re-installing Android Studio.

@jakobr-google

This isn't the new version code, it's still using pub_semver. Are you synced past 3676ffe477c1f5b2013bcbbcb8547fcb743fb2af?

I synced this morning. Thought this bug might be related to new code added for #8298

Synced again... looks fixed so I might have been between useful versions.
/home/darrell/flutter/bin/flutter --no-color upgrade
Upgrading Flutter from /home/darrell/flutter...
Already up-to-date.
Upgrading engine...
Already up-to-date.
Flutter • channel master • https://github.com/flutter/flutter.git
Framework • revision a745fd58be (5 hours ago) • 2017-02-22 14:35:49
Engine • revision ab09530927
Tools • Dart 1.23.0-dev.0.0
Running 'flutter packages upgrade' in flutter_gallery...
Running flutter doctor...
[✓] Flutter (on Linux, channel master)
• Flutter at /home/darrell/flutter
• Framework revision a745fd58be (5 hours ago), 2017-02-22 14:35:49
• Engine revision ab09530927
• Tools Dart version 1.23.0-dev.0.0
[✓] Android toolchain - develop for Android devices (Android SDK 25.0.0)
• Android SDK at /home/darrell/Android/Sdk
• Platform android-25, build-tools 25.0.0
[✓] Android Studio (version 2.3)
• Android Studio at /home/darrell/android-studio
• Gradle version 3.2
[✓] Gradle (3.2)
• gradle-dir = /home/darrell/android-studio/gradle/gradle-3.2
• Consider removing the gradle-dir setting to use Gradle from Android Studio.
[✓] IntelliJ IDEA Community Edition (version 2016.3)
• Dart plugin version 163.13137
• Flutter plugin version 0.1.10
[-] IntelliJ IDEA Community Edition (version 2017.1)
• Dart plugin version 171.3019.10
• Flutter plugin not installed; this adds Flutter specific functionality.
• For information about managing plugins, see
https://www.jetbrains.com/help/idea/managing-plugins.html
[✓] Connected devices
• Android SDK built for x86 • emulator-5554 • android-x86 • Android 7.1 (API 25) (emulator)
Process finished with exit code 0

Thanks for confirming! If you run into this again please re-open.

And BTW, you should be able to remove the workaround for #8298 now (by running flutter config --gradle-dir=).


Enhancement: Smart Collection "Visible on" options

Plex's Smart collections have a "Visable on Library/Home/Shared Users' Home" option.
Is this something we can set/modify via PMM?

Not at the moment but it's a planned feature!


Request data utf-8 encoding

UTF-8 encoding the data object in constructor

@szmaorka I'm not sure that this should be merged, this feels implementation specific and not something we should impose on every user of Flight.
It's likely that we have users who's applications currently expect to be receiving data in UTF-8, UTF-16, ASCII, UTF-EBCDIC, etc and this could be a breaking change for their API. Encoding to UTF-8 is trivial if your application needs it and it's my belief that this feature should remain in the user space code, though of course @mikecao has the final word.

Agreed, we should not be enforcing any kind of encoding on the user.


Applying ReCept with Remarkable-hacks(from ddvk)

Hi, i wanted to know if this script/patch can be applied with the Remarkable-hacks script (author: ddvk)? Is there a risk of bricking the device?
Thank you!

I haven't tried it myself, but heard from others that it is no problem. That's also what I would have assumed, since recept filters the pen events before they hit the application.


How long do you want to support VS 2015?

I have the changes to migrate merge here: https://github.com/petermarcu/minecraft.client
I can make a PR into master or into a branch. Hopefully we don't let them diverge for too long though. The Msbuild solution based on VS 2017 RC is working well for me.

I'd prefer to have those changes in a separate branch if that's ok, until 2017 is RTM. Does this make sense?

If thats what you want. The tooling is RC either way :) So as I make changes to add blocks do you want me to make changes in that branch?

It shouldn't change the project file in either branch, so it should be easy enough to merge. I think. Let's try it, and if it proves too cumbersome, we can revise.

Ok, I'll make the PR

Thanks!

Can you create a branch in your repo called msbuild?

Yup. https://github.com/bleroy/minecraft.client/tree/msbuild

msbuild was merged into master. The project now requires preview 3 tooling.


Don't set SSL options unless we have an HTTPS URI

This is probably going to require a refactor of RestClient::Request.transmit, which currently receives a uri argument. SSL options are set up in various ways in initialize, where we don't yet know whether we have an HTTPS URI.
It seems like transmit should actually be private, but this could possibly be a breaking change, and will require rewriting some tests.

:+1: We have this issue too only with JRuby(1.7.18) on Windows.
Moved to rest-client 1.6.8 and it works fine.

It's works with JRuby <IP_ADDRESS>.pre2 and rest-client 1.8.0 :smile_cat:


Added support for file types across platforms

Added per platform file type support, so you can specify what kind of files you want the picker to support
Updated iOS's picker to use the non-deprecated UIDocumentPickerViewController
Minor tweaks, such as package updates

As mentioned in #24, UWP is entirely untested, but I've briefly tested that iOS, macOS and Android seem to work.

Just to update on the last commit: there was a rather nasty path formatting issue in the previous iOS implementation, where absolute paths were formatted as file:///some/path/here, instead of /some/path/here.
I previously worked around this by just wrapping the path in a new Uri(), but figured it would be better to properly fix it in the library itself, which was an easy fix.

So, what is the status on this? Should work across all? Just need to test UWP?

Yes, just needs UWP testing.
I'm also trying to get one or two iOS specific fixes included in this, although they're not directly related to the file type customization, but to how the iOS picker functionality is implemented and works in newer iOS versions.

Also slightly off topic, but I managed to fix the iOS sample (#2) as a part of this PR. :)

That is great on both!
Let me know whenever you're complete, I'll try to get UWP tested somewhere this week. When we're both done we can merge this.

There is one interesting mechanic with the iOS document picker. It allows to either import files, making a local copy of the file if necessary (currently the default), but also opening files directly.
I'm not actually sure which would make the most sense, since that would be more up to the type of application using the library, right?
Having the ability to directly edit files in iCloud Drive which don't necessarily belong to the current app would be great, but on the other hand, importing files is also important in my opinion.
One other thing I'm looking into is that I think the document picker also allows saving/exporting data, which may prove useful if true.
Any thoughts on these?

I think we should stick with the default: importing the file. If we see the need for editing files directly, we'll manage then.

One other thing I'm looking into is that I think the document picker also allows saving/exporting data, which may prove useful if true.

I don't quite get what you mean here

Yes, I agree. Never mind about the exporting part, I thought there was functionality for saving/exporting files using the picker.

In that light, how far along are you? If not ready, we could consider marking this as WIP until you're done. I see the latest changes have introduced some conflicts, sorry!

I think I'm actually done, just need to resolve the conflicts and fix the PR.

Was due to the build configuration. Seems to build now!


Update calling to 1.19.2-beta.2 on release/1.11.0-beta.2 hotfix branch

What

Update @azure/communication-calling to 1.19.2-beta.2
Add changelog entry

Why
To get hotfix for #3695
How Tested
CI + Internal bug bash will happen after PR

Keeping as draft until new communication-calling package drops

Will reapprove once communication-calling package drops, but looks good!

Hitting complete to deploy sample apps of release branch, but will continue to monitor github actions


[ADD] adding Minix name, my favorite and crazy cat.

Hi @sindresorhus, Please accept this pull request, it has a special and emotional reason for several humans from Venezuela and Costa Rica :)
Regards.

Sorry, but this list is locked as it's a list of popular cat names, and it doesn't make sense to arbitrary mutate it.
From the top of the readme:

Not accepting PRs for additional names.

@sindresorhus Sorry, my mistake by not read carefully

@waltervargas I encourage you to fork this and make your own with random cat names though ;)


fix(core): enable src with a function in addModule

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

While developing a module I came across a problem in its coverage.
If you are analyzing the modules such as pwa, moment-module, nuxt-i18n the coverage is made on top of the test folder and not the lib or src, this is why nuxt solves the module using esm by default, so the module is not is covered.
Today to test the modules we created a nuxt.config.js like this:
modules: [
  '@@'
]

and this has no coverage.
With this correction we can create like this:
modules: [
  require('../../')
]

and this has coverage
If we want to create the module using ESM and with coverage we have to add new configurations in jest and babel:
  "babel": {
    "presets": [
      [
        "env",
        {
          "modules": false
        }
      ]
    ],
    "env": {
      "test": {
        "presets": [
          [
            "env",
            {
              "targets": {
                "node": "current"
              }
            }
          ]
        ]
      }
    }
  },
  "jest": {
    "testEnvironment": "node",
    "collectCoverage": true,
    "collectCoverageFrom": [
      "lib/**/*.js"
    ],
    "transform": {
      "^.+\\.js$": "babel-jest"
    }
  }

and add the dependencies babel-jest and babel-preset-env
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[x] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

Codecov Report

Merging #4956 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #4956      +/-   ##
==========================================
+ Coverage   92.84%   92.85%   +<.01%
==========================================
  Files          73       73
  Lines        2419     2421       +2
  Branches      594      595       +1
==========================================
+ Hits         2246     2248       +2
  Misses        158      158
  Partials       15       15

Impacted Files
Coverage Δ

packages/core/src/module.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9308954...83960a5. Read the comment docs.

In description, should it be like this ?
modules: [ () => require('../../') ]

@pi0 I will suggest improvements in module-template

Fantastic investigation and improvement for module coverage. For ecosystem consistency, I suggest not documenting this to prevent module incompatibility for 2.x users prior to this version.
@ricardogobbosouza Would you please also open a PR on module template to reflect changes to the default test suit?

https://github.com/nuxt-community/module-template/pull/9


403 error from YT for every request

Hello. Last few days I'm getting 403 error when trying to download audio from YT. The error doesn't depend on region my instance is running on. Do you have any ideas why it's broken now? I suggest, it's YT's security updates

duplicate of https://github.com/lavalink-devs/youtube-source/issues/29


Add cached+supported thumbnail information to media info api

As per the last point on https://github.com/matrix-org/matrix-doc/issues/703

Spec proposal: https://github.com/matrix-org/matrix-doc/issues/1310


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

AWS CodeBuild CI Report

CodeBuild project: DDKIntegrationTestsD8472609-5SCHWjldmWcf
Commit ID: d91d5650de340029ca1a67dd837a8fd5b20a5f01
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Replace pnpm in README to selected package manager

Which project is this feature idea for?
Turborepo
Describe the feature you'd like to request
Replace the pnpm commands in the README from the basic turborepo example (which is used by npx create-turbo@latest) with the selected package manager from the CLI command
Describe the solution you'd like
Replace the pnpm commands in the README with the selected package manager
Describe alternatives you've considered
List commands for all package managers in the README

This could be as simple as modifying the README, or only including a template README with placeholders that gets processed by create-turbo. Could open up the ability to let the user add name to root package.json (or even specific workspaces, etc). cc @anthonyshew

Hi Team,
I feel interested in this good first issue and want to begin my open-source contribution with TurboRepo.
Will you please assign this to me?
Please let me know if this is the place where the feature is requested:
https://github.com/vercel/turbo/tree/main/examples/basic
with regards,
Depender K. Soni

I think the best way to do this would be a new transformer here: https://github.com/vercel/turbo/tree/main/packages/create-turbo/src/transforms
It could go into the package manager transformer as well, but I wouldn't be opposed to keeping that isolated and making a new, docs related transformer.

@DependerKumarSoni we already add the specified name to the root package.json for the basic example, so that doesn't need to be done. That's handled here: https://github.com/vercel/turbo/blob/main/packages/create-turbo/src/transforms/official-starter.ts#L56C20-L60
We discussed doing this for all examples, but originally decided against it. If we want to change that in the future it's a simple change here!

@DependerKumarSoni Letting AI give a better answer than I probably could myself: https://sdk.vercel.ai/s/vMcNAHx 😄

@Netail
I've updated the code by implementing a regex-based replace statement.
Kindly share your feedback and suggest any additional improvements.

Hi team,
PR #6747 has a rust-docs failure. Can you share details on the issues and any improvements needed? Also, there's a 'Code owner review required' message – guidance on the next steps would be great.

@tknickman I tried running turbo build --filter=create-turbo... but it shows the following error:

maccy@Dependers-MacBook-Pro turbo % pnpm run build --filter=create-turbo...

<EMAIL_ADDRESS>build
pnpm -- turbo run build --filter=docs

<EMAIL_ADDRESS>turbo /Users/maccy/Desktop/GitHub/turbo
pnpm run build:turbo && node turbow.js "run" "build" "--filter=docs"

<EMAIL_ADDRESS>build:turbo /Users/maccy/Desktop/GitHub/turbo
pnpm run --filter=cli build

<EMAIL_ADDRESS>build /Users/maccy/Desktop/GitHub/turbo/cli
make

/bin/sh: go: command not found
/bin/sh: go: command not found
cargo build -p turbo
make: cargo: No such file or directory
make: *** [turbo] Error 1
/Users/maccy/Desktop/GitHub/turbo/cli:
 >ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL<EMAIL_ADDRESS>build: make
Exit status 2
 >ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.

Then I created a new git clone of my forked repo and ran the same command after pnpm install. Got this:

/bin/sh: go: command not found
/bin/sh: go: command not found
cargo build -p turbo
Compiling zstd-safe v6.0.5+zstd.1.5.4
Compiling zstd-sys v2.0.8+zstd.1.5.5
Compiling libgit2-sys v0.14.2+1.5.1
warning: the feature trait_upcasting has been stable since 1.76.0-nightly and no longer requires an attribute to enable
--> crates/turborepo-lockfiles/src/lib.rs:1:12
|
1 | #![feature(trait_upcasting)]
|            ^^^^^^^^^^^^^^^
|
= note: #[warn(stable_features)] on by default
warning: turborepo-lockfiles (lib) generated 1 warning
Compiling turborepo-lib v0.1.0 (/Users/maccy/Desktop/GitHub/turbo/crates/turborepo-lib)
Compiling tracing-appender v0.2.2
error: failed to run custom build command for turborepo-lib v0.1.0 (/Users/maccy/Desktop/GitHub/turbo/crates/turborepo->lib)
Caused by:
process didn't exit successfully: /Users/maccy/Desktop/GitHub/turbo/target/debug/build/turborepo-lib->36cc3e6c1d12a8d6/build-script-build (exit status: 101)
--- stdout
cargo:rerun-if-changed=turbod.proto
cargo:rerun-if-changed=../../cli/internal/turbodprotocol
--- stderr
thread 'main' panicked at crates/turborepo-lib/build.rs:34:23:
schema compiler command: Error { kind: Failed, extra: "Failed to execute capnp --version: No such file or directory (os >error 2). Please verify that version 0.5.2 or higher of the capnp executable is installed on your system. See >https://capnproto.org/install.html" }
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
make: *** [turbo] Error 101
/Users/maccy/Desktop/GitHub/turbo/cli:
 ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL<EMAIL_ADDRESS>build: make
Exit status 2
 ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.
 >ELIFECYCLE  Command failed with exit code 1.

@tknickman
I have already pushed the updated code to #6747.
I request you to provide me with some feedback.

Any update on this? I see the story label got removed, but when generating a new turbo repo with npx create-turbo it still show pnpm dev in the develop section while I selected a different package manager

It looks like #6747 is close but has stalled.
@DependerKumarSoni, are you still able to work on it? Apologies for the delays on our side. Tom is on parental leave!

I have submitted a pull request addressing this issue: #9632. Please feel free to review it, and let me know if any further changes are needed.

I think some kind of generator would be preferred instead of listing all possible options in the same codeblock

I've made a pull request(https://github.com/vercel/turborepo/pull/9633) which I think will resolve this issue.


Question about pre-trained word-vector

can you tell me how do you use extra semantic knowledge in pre-trained word-vectors to correlate the seen and unseen classes

training phase: learn the relationship between visual features and word-vectors of seen classes
testing phase:  obtain unseen scores through visual features and  word-vectors of unseen classes

The correlation of seen and unseen classes is contained in the pre-trained word-vectors, e.g., given "cat", "dog" and "bus", "cat" and "dog" have higher word vector similarity


bolt apply: allow reading manifest from a named pipe

Prior to this commit bolt threw an error when given a manifest which
resolves to a named pipe:
$ bolt apply -t butter.example.com <(cat manifests/*.pp)

After this commit bolt allows reading from the named pipes!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@puppetlabs/skeletor kindly review

@lollipopman Can you clarify the use case for using named pipes in a bolt apply command? The example you provide would not actually work, since bolt apply expects a path to a single manifest file, whereas your example passes the code from potentially multiple manifest files.
$ bolt apply -t butter.example.com <(cat manifests/*.pp)

@beechtom thanks for reviewing. For my use case I am concatenating two manifests into a single file, so bolt will read them both as does puppet server in a typical setup. I can attest that at least in my use case it works successfully as bolt happily reads the concatenated file. I sure there are other reasons to support pipes, for instance perhaps you want to grep something out before applying?
$ bolt apply -t butter.example.com <(grep -v password site.pp)

@nicklewis any chance you could review?

This looks good. Can you add a release note to the commit please? Then this should be ready to merge.
The contributing doc has info about the format. I'm also happy to take care of it if you want.


Upgrade examples/integration rules_apple to 3.0.0-rc2

Needs #2556 for the macOSApp to actually build, but I want these changes to land separately.


Add custom options with filter

DEMO ONLY!!
PRs with UTs incoming!
Code already reviewed in

https://github.com/coveo/react-vapor/pull/872

https://github.com/coveo/react-vapor/pull/871

https://github.com/coveo/react-vapor/pull/869

https://github.com/coveo/react-vapor/pull/866

https://github.com/coveo/react-vapor/pull/863

Codecov Report

Merging #875 into master will decrease coverage by 0.2%.
The diff coverage is 89.43%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a93cd...8101326. Read the comment docs.

unless we say we start caring less about coverage (which I wouldn't mind doing and start focusing on meaningful UTs instead of quantity), you should try to cover what's reducing the coverage https://codecov.io/gh/coveo/react-vapor/pull/875/diff

Coverage updated


Add Considerations for Model, Logic and Storage

Added for Logic. Not added for Model and Storage because its quite self explanatory.


[Enhancement]  Add "filteredRows" in the event from the new 'on-search' Event

Issue Type

[ ] Enhancement

Version
2.0.0-beta.5
Expected Behavior
I would like to also get the 'filteredRows' back in the event from the new 'on-seach' Event.
At least is there a way for me to get that data?
I would like to get all the data from the filteredRows, but if that is not that easy or may cause a performance issue for every on 'key-up' event then at least get the number of filteredRows.  That way I can display the number somewhere else in my template.
Current Behavior
Only the searchTerm is being returned in the event.

this is now fixed in version 2.0.0-beta.6

@xaksis Awesome, Thanks for the quick update.
So far really loving the simplicity of your this  module.
Thanks


Feature: BitClout landing page

What's been done:

Added dark logo for BitClout
Added new landing page for BitClout environment (suggests redirecting to DiamondApp)

Screenshots:

it was fun till it lasted XD


can we install on ubuntu vm?

Hey there, i see you made a tutorial for docker on local setup,
How should i install on a ubuntu 22.04 virtual machine.

We've put up a docker which you can use to setup on ubuntu. You may check this out: https://github.com/bolna-ai/bolna/tree/master/local_setup


Allow Catniss to select a avatar

Catniss will be able to select which avatar they wish to play as on the create lobby page because pictures are easier to remember than words and because cat pictures are adorable and Catniss wants to be able to choose the cutest one.
Tasks:

[ ] Buttons for each avatar option for Frontend
[ ] Backend should assign Catniss to avatar
[ ]

Need create lobby page done before we can work on this.


add postup/down scripts

https://github.com/firezone/firezone/issues/1146

Thanks for the contribution! I'll see if I can find some time to review this soon.

Pull Request Test Coverage Report for Build 4e8ed967d2f3a81bfba831f53a4054a777819e1e-PR-1151

19 of 28 (67.86%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.002%) to 66.504%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

apps/fz_http/lib/fz_http/devices.ex
19
28
67.86%

Files with Coverage Reduction
New Missed Lines
%

apps/fz_http/lib/fz_http/devices.ex
1
88.07%

Totals

Change from base Build 157ac0bb38df1ed162e60362d9ba58bedf7d91b6:
0.002%

Covered Lines:
1223

Relevant Lines:
1839

💛  - Coveralls

Closing for now -- will revisit later for client apps.


Bug: File with max views gets deleted before getting shown

What happened?
Trying to access a file which has one view remaining results in a 404 page and the file getting deleted.
https://user-images.githubusercontent.com/2225711/199967091-8a33ef7b-ae95-45c8-a802-2320c61a9bdf.mp4
Version
upstream
What browser(s) are you seeing the problem on?
Chrome
Zipline Logs
No response
Browser Logs
No response

possible that sending in to a service like discord where discord caches the image for easier grabbing so it displays faster, that i could have counted that as a view and then once hit the view limit, it will delete it

Well I didn't send the link anywhere, I opened it right away.

hmm. weird i dont know then. sorry

It's because the views get updated before the image is actually served, so when you open it, it updates, then serves you the content. For things like Discord unfortunately there is nothing I can do about that, possibly checking user agents is one solution but I'm not sure.

adding a way to make it so certain ips/domains do not count towards that max view would be cool but hard to implement


cub::DeviceSegmentedReduce::Reduce  error

I found an error when using cub::DeviceSegmentedReduce::Reduce, see the code below:
int32_t num_rows = row_splits_array.Dim() - 1;
const int32_t *row_splits = row_splits_array.Data();
argmax_internal::PairInputIterator<float> input_iter(values_data);
argmax_internal::PairOutputIterator<float> output_iter(output_data);
argmax_internal::PairMaxOp<float> op;
argmax_internal::Pair<float> initial_pair{initial_value, -1};

// This code is based on the example here:
// https://nvlabs.github.io/cub/structcub_1_1_device_segmented_reduce.html
std::size_t temp_storage_bytes = 0;

// the first time is to determine temporary device storage requirements
cub::DeviceSegmentedReduce::Reduce(
    nullptr, temp_storage_bytes, input_iter, output_iter, num_rows,
    row_splits, row_splits + 1, op, initial_pair, c->GetCudaStream()));
Array1<int8_t> d_temp_storage(c, temp_storage_bytes);
cub::DeviceSegmentedReduce::Reduce(
    d_temp_storage.Data(), temp_storage_bytes, input_iter, output_iter,
    num_rows, row_splits, row_splits + 1, op, initial_pair,
    c->GetCudaStream()));

I upload the bad case to (https://drive.google.com/drive/folders/1Bm4BHFzniAxCcnqHFPE3S3bccrriaJg5?usp=sharing), the value_data is the array in values.txt the row_splits_array is the array in splits.txt and the error result is in error.txt, the initial_value is -inf.
The error occurred in the second last sublist, the max value of the second last sublist should be the first one, but the output is the 42th. And I tried to construct some new test case by picking out some of these sublists(including the error one), the result was right. So, I thought it it not an error for particular data, it may be an error about number of the sublists, the result of the sublist in position i of n would be not right, especially the ones in the tail.

@danpovey
The issue is reported here.  We are making an all-in-one .cu file for easy reproducing.

There is a bug in our internal code, sorry!


Support import the mind-ar-js with unpkg CDN

https://unpkg.com/mind-ar-js/dist/mindar-image-three.prod.js
<script
      async
<EMAIL_ADDRESS>    ></script>
    <script type="importmap">
      {
        "imports": {
          "three"<EMAIL_ADDRESS>          "three/addons/"<EMAIL_ADDRESS>+          "mindar-image-three": "https://unpkg.com/mind-ar-js/dist/mindar-image-three.js"
        }
      }
    </script>

@hiukim @jmschrack Could you check it ?

Hi, what was the problem?

Hi, what was the problem?

Oh，i can get it with<EMAIL_ADDRESS>


Cannot download R2G dataset

I'm trying to download R2G dataset outside of the HBP Collab.
I've installed fairgraph from the master branch and acquired an access token from the HBP website.
from fairgraph.client import KGClient
from fairgraph.minds import Dataset
import os
token = os.environ['HBP_AUTH_TOKEN']
client = KGClient(token)
dataset = Dataset.by_name("reach_to_grasp", client, api="query", resolved=True)

The returned dataset is None.
I tried v0.5.1 and 0.4.0 tags, none of them worked - I got HTTPError (I can post the traceback if it will help).

The code you provided works for me when supplied with a token from Nexus and not an environmental token. Could you try that approach to see if the code will return the correct result?

I think the link for the tokens should be https://nexus-iam.humanbrainproject.org/v0/oauth2/authorize

I get an error with the Nexus token too.
Does it mean that only specific people could your API to download R2G?


Isue when entering credentials

Hi,
I get this error message just after entering my one-time remarkable code. Any idea why?
Thanks in advance,
ReMarkable credentials Error
/Users/amaurygouverneur/MyDocuments/KTH/Research/zotero_remarkable_connector/ZRMconnector/node_modules/node-fetch/lib/index.js:683
throw new TypeError(${value} is not a legal HTTP header value);
^
TypeError: Bearer <!doctype html>reMarkable

Yes the reMarkable API has changed since i uploaded this project (for security and reliability reasons mainly) and i haven't had time to update the project since.
So if you happen to have some time and are able to have some knowledge about the new RM API, give it a go ;)


Update li_link method call in Storage/Filers listnav

This is fix for Storage/Filers list navigation(now it renders the view again), it updates name of method for building list navigation from li_link_if_nonzero to renamed method li_link. Also it removes :title argument as it's created inside li_link method and :action  as default is 'show'.

@jzigmund Would you please provide a description for this PR.  It is not obvious why you are proposing this change nor what it will accomplish.  A reader can probably figure it out by reading the code, but please help the reader with a clear description.

Verified in UI.


ORC-351: [C++] Increase buffer in Decimal*ColumnWriter to required size

Can you add a test as well? Thanks.


Bug when creating a folder in subfolder

When i create a folder in a subfolder; two folders get created; one in subfolder (appropriate place) and another in the same level as the folder i am in (buggy).
Thanks.

@1dot44mb I'm sorry for these buggy subfolder features.
Bug confirmed. Will check it tomorrow.

Hello, @1dot44mb .
We currently support only two-level folders.
This issue will be a future feature.

Thanks @g0110280

We should remove the "create folder" button at the second level folder. @g0110280

Fixed by @g0110280 in https://github.com/UniSharp/laravel-filemanager/releases/tag/1.4.0-alpha
Allow creating unlimited, multi-level folders.


Add Dashboard testing

Add CMakeLists.txt and necessary CTestConfig.cmake file to submit to
dashboard found at open.cdash.org
Update testing where possible to switch to Chrome.
General Fixes to testing scripts.

LGTM.


fix: add cancellation of LDAP connection on deletion of LDAP server

Previously, deletion requests for LDAP configurations with a non-zero Auto Sync time frequently hung indefinitely. In the current fix, cancellation of LDAP connection attempts on deletion of LDAP servers has been added, which ensures that hanging deletion requests are avoided

tested by qa


screen flickers when replicating dat while share dialogue is open

Got a screen cap of this? This has happened in the past and is difficult to
recreate
On Thu, Jan 12, 2017, 14:30 Julian Gruber<EMAIL_ADDRESS>wrote:

Assigned #140 https://github.com/datproject/dat-desktop/issues/140 to
@yoshuawuyts https://github.com/yoshuawuyts.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/datproject/dat-desktop/issues/140#event-920713392,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWleq5EVMUaCzl-4x5LDvgabKwc2UA4ks5rRirlgaJpZM4LhwCv
.

sure: https://youtu.be/vhkw7a1Cczc

it's flickering whenever the repo update event fires

I wouldn't say this is critical for the stabilize milestone

when this happens it's almost impossible to dismiss the dialogue, so it's also a functionality bug.

This bug is really cool; it triggers for me when I hit "copy"

ah ok, it's because of the nested onload stuff - dang, knew I had to try a better design. On it now tho; gonna polish this puppy :sparkles:


Blank tab confirmation in browser android

What version of Wallet are you using?
Last version your wallet
Steps to Reproduce
i tried to do it in android browser.  after clicking connect.  confirmation tab appears but blank no action.  I think this needs to be fixed in the future.  thanks

Expected Behavior
I hope fix your bug
Actual Behavior
Problem tab confirmation open with android browser

We currently do not support the android browser, but we look forward to fixing it.


studioProvider types don't match

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
1.5.0
Current Behavior
Just updating the package, then building it I get this error
Type error: Type 'LivepeerProviderFn<StudioLivepeerProvider>' is not assignable to type '() => LivepeerProvider'.
  Call signature return types 'StudioLivepeerProvider' and 'LivepeerProvider' are incompatible.
    The types of 'createAsset' are incompatible between these types.
      Type '(args: CreateAssetArgs) => Promise<Asset>' is not assignable to type '<TSource extends CreateAssetSourceType>(args: CreateAssetArgs<TSource>) => Promise<MirrorSizeArray<TSource, Asset>>'.
        Types of parameters 'args' and 'args' are incompatible.
          Type 'CreateAssetArgs<TSource>' is not assignable to type 'CreateAssetArgs'.
            Type 'CreateAssetArgs<TSource>' is not assignable to type '{ name: string; meta?: Record<string, string>; file: File | ReadStream; uploadSize?: number; onUploadProgress?: (progress: number) => void; } & { file: ReadStream; uploadSize: number; }'.
              Type 'CreateAssetArgs<TSource>' is missing the following properties from type '{ name: string; meta?: Record<string, string>; file: File | ReadStream; uploadSize?: number; onUploadProgress?: (progress: number) => void; }': name, file

  57 | );
  58 |
> 59 | const livepeerClient = createReactClient({ provider: studioProvider() });
     |                                            ^
  60 |

Expected Behavior
No error
Steps To Reproduce

Update studio app to 1.5.0
yarn install
yarn build

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

This is occurring because the livepeer version is outdated on studio, closing as not a bug


encoding in lat,lon but decoding in lon,lat

My encoding program:
polyline6 = encode_coordinates(collector, 6).decode('utf-8')

where collector is like [ [lat,lon], [lat,lon] .... ]
My decoding program:
points = decode_polyline(str.encode(d1['polyline6']),6)
latitude = [x[0] for x in points]
longitude = [x[1] for x in points]

But upon checking the values I'm finding the lat and lon have been switched and I have to do this to make up for it:
longitude = [x[0] for x in points]
latitude = [x[1] for x in points]

I cross-checked in my db and confirmed that the lat-long data there isn't switched originally; it's as it should be.

Update: I used polyline library:
points = polyline.decode(d1['polyline6'], 6)

... and got the same mixed results when decoding the polyline that was encoded by pypolyline : Got [lon,lat] output. :(

Update: Re-tested with some sample data.. no fault found with decode_polyline() function. Some weird thing happening during data prep on my end, nothing amiss on this library's end, sorry false alarm


Drop Node@10 support

Per https://github.com/uuidjs/uuid/issues/598#issuecomment-984540423 I'm adding this to the list of things for v9

Did this in #643


read() in DB_cache fails when catching E_WARNING with custom error handler

Hi,
when using set_error_handler() and matching E_WARNING, the read() method in CI_DB_Cache fails at L146, this because file_get_contents() emits an E_WARNING when it does not find the file.
This should fix it:
if ( ! is_file($filepath) OR FALSE === ($cachedata = @file_get_contents($filepath)))

Please revert your second commit (it's completely unrelated and doesn't do anything either way) and remove the error suppression op from the file_get_contents() call - it doesn't make sense anymore with the is_file() check.

Done! I'm sorry, I did not intended to push it here.


feat: add argument --dryRunOnly to only run initial tests

This is to provide a better option to check if the Stryker configuration is correct.
Prevent rollbacks, as a dry-run takes less time than a full test run.
closes: #3088

Released in v6.3 🎉
https://github.com/stryker-mutator/stryker-js/releases/tag/v6.3.0


unevaluatedProperties in subschema does not work correctly with allOf

What version of Ajv are you using? Does the issue happen if you use the latest version?
7.0.0-rc2
Ajv options object
use the 2019 version of the validator
var ajv2019 = require('ajv/dist/2019').default;
var ajv = new ajv2019();

JSON Schema

{
  "properties": {
    "rootObject": {
      "type": "object",
      "allOf": [
        {
          "$ref": "#/definitions/subLevel"
        },
        {
          "properties": {
            "topLevelProp": { "type": "string" }
          },
          "required": ["topLevelProp"]
        }
      ],
      "unevaluatedProperties": false,
    }
  },
  "definitions": {
    "subLevel": {
      "type": "object",
      "properties": {
        "subLevelProp": { "type": "string" },
      },
      "required": ["subLevelProp"],
      "unevaluatedProperties": false,
    },
  },
}

Sample data

{
  "rootObject": {
    "subLevelProp": "a",
    "topLevelProp": "a",
  }
}

Your code

link to code sample: https://runkit.com/bourbongit/5fd73f6aa58c7a001a4b01f1
var ajv2019 = require('ajv/dist/2019').default;
var ajv = new ajv2019();
let validate = ajv.compile(schema);
console.log(validate(data));
console.log(validate.errors)

Validation result, data AFTER validation, error messages
strict mode: missing type "object" for keyword "properties" at "#" (strictTypes)
false
[
  {
    keyword: 'unevaluatedProperties',
    dataPath: '/rootObject',
    schemaPath: '#/definitions/subLevel/unevaluatedProperties',
    params: { unevaluatedProperty: 'topLevelProp' },
    message: 'should NOT have unevaluated properties'
  }
]

What results did you expect?
The data should evaluate successfully against the schema. Indeed the unevaluatedProperties in the scope of a subLevel should not consider properties defined by its enclosing schema as "unevaluated" because they are evaluated by the parent schema.
"rootObject": {
"subLevelProp": "a", --> evaluated by the sub-schema "subLevel"
"topLevelProp": "a", --> evaluated by the top-level schema "rootObject"
}
Otherwise it's simply impossible to have a data matching this schema.
A workaround is to remove the unevaluatedProperties from the subschema subLevel, and it works. However this is a problem in large complex schemas where sub-schemas are used in different places, sometimes as top-level schemas, sometimes as sub-schemas, and we want to enforce unevaluatedProperties to true eveyrwhere.
Are you going to resolve the issue?
no

I believe it is how it is specified in JSON Schema draft-2019-09. Inner unevaluatedProperties is supposed to only account for properties evaluated by adjacent/sibling keywords, it would know nothing about its parent schema.
See https://datatracker.ietf.org/doc/html/draft-handrews-json-schema-02#section-<IP_ADDRESS>:

The behavior of this keyword depends on the annotation results of
adjacent keywords that apply to the instance location being
validated.  Specifically, the annotations from "properties",
"patternProperties", and "additionalProperties", which can come from
those keywords when they are adjacent to the "unevaluatedProperties" keyword.
Those three annotations, as well as
"unevaluatedProperties", can also result from any and all adjacent
in-place applicator (Section 9.2) keywords.  This includes but is not
limited to the in-place applicators defined in this document.

The key word in this paragraph is "adjacent".
Further, there is a test in JSON Schema Test Suite that shows that unevaluatedProperties also can't "see" inside cousins, not only parents:
https://github.com/json-schema-org/JSON-Schema-Test-Suite/blob/master/tests/draft2019-09/unevaluatedProperties.json#L594
The idea of this keyword is that you would only use it in your top level schema that you actually use to validate data, while any components used by it won't have unevaluatedProperties.
If you need a schema that is used both as a component and as an independent schema you can always define it:
{
  "$ref": "#/definitions/subLevel",
  "unevaluatedProperties": false
}


Key.PubKey NullReferenceException

There seems to be a bug with key.PubKey:
var key = new Key(Encoders.Base58.DecodeData("JEKNVnkbo3jma5nREBBJCD7MJVUPAg5THBwPPejEsG9v"));
Console.WriteLine(key.PubKey); //NullReferenceException

As a library user I'd have expected new Key(...) to throw if invalid data is provided. If that is not feasible Key.PubKey should not crash with a forbidden exception type.

Isn't that a testnet Bitcoin address you want to parse as a key?

In .NET it's impossible that the result of calling a constructor is null. Are you sure your sample is correct? Maybe your original code has a try-catch block that you missed when pasting here.

@knocte The property is null, not the key: the PubKey.

@GSPP By the way this is the correct way of doing what you want:
var key = Key.Parse("JEKNVnkbo3jma5nREBBJCD7MJVUPAg5THBwPPejEsG9v");
And it throws this:
System.FormatException Invalid string
And so figured it's indeed not a valid key (as I suspect, it's a testnet address.)
Yet, it'd be nicer if format exception would be thrown when calling new Key(bytes) too.

The property is null, not the key: the PubKey.

Mmm, what? Console.WriteLine() can print a null string without problems without throwing NullReferenceException, do the test ;-)

@knocte Indeed, I know what you mean. The trick is, the PubKey is more like a function than a property 😄
public PubKey PubKey
{
	get
	{
		if(_PubKey == null)
		{
			ECKey key = new ECKey(vch, true);
			_PubKey = key.GetPubKey(IsCompressed);
		}
		return _PubKey;
	}
}

Ah, fuck! didn't think about this, of course.
But if that's the implementation of PubKey property, it cannot throw NRE, unless GetPubKey() function can throw a NRE?

Oh, the ECKey() ctor could throw as well. Even if what @GSPP could be done in a better way, I think this is a valid report that should be fixed. NREs are always bugs.

There are two issues here:

Properties should rarely, preferably never throw exceptions.
new Key(bytes) should throw a format exception just like Key.Parse does.

This is a bug, Pubkey should never be null.

Ha interesting, I thought all 32 bytes could be a private key, but this is not the case ?!

Wow, JEKNVnkbo3jma5nREBBJCD7MJVUPAg5THBwPPejEsG9v is actually the N parameter of the curve.

Ok so it was a bug, NBitcoin was not checking correctly if the Key was valid.


feat: added purge parameters to the manifest

Feat added purge parameters to the manifest
Added parameters for purge in manifest generation based on API v3.
Example:
module.exports = {
   purge: [
    {
      type: 'url',
      urls: ['http://www.example.com/image.jpg'],
    },
    {
      type: 'cachekey',
      urls: ['http://www.example.com/image1.png', 'http://www.example.com/image2.png'],
      method: 'delete',
    },
    {
      type: 'wildcard',
      urls: ['http://www.example.com/*'],
    },
  ],
}

For the full example, see: ./lib/utils/generateManifest/helpers/azion.config.example.js
Tests:
yarn jest lib/utils/generateManifest/generateManifest.utils.test.js -t "jsToJson - Purge"

Bonus:
fix: update digitalCertificateId field configuration to accept number type
It was updated in the Ajv schema to authorize multiple types.
And added the number type in the digitalCertificateId field of the Domain.

:tada: This PR is included in version 3.1.0-stage.4 :tada:
The release is available on:

npm package (@stage dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(fonts): Add support for fallback fonts (v2)

Alternative to #198 . It  is a big breaking change to the config. If you set the fonts you now need to add []. For example:
serif = {
  package = pkgs.dejavu_fonts;
  name = "DejaVu Serif";
};

Becomes:
#       v--- IMPORTANT!
serif = [{
  package = pkgs.dejavu_fonts;
  name = "DejaVu Serif";
}];
#^-- IMPORTANT!

I'm getting build issues when using this branch 🥲
I'll look over the diff to try and debug it.
This is the build log: https://github.com/jalil-salame/NixOsConfig/actions/runs/7276308829

I think I found the issue

I didn't :c

Not sure why this is failing - from the error message my best guess would be that we are using package somewhere where we should be using { name, package }.

I will grep for this case again as soon as I have time.

Not sure why this is failing - from the error message my best guess would be that we are using package somewhere where we should be using { name, package }.

I will grep for this case again as soon as I have time.

I'm confused; I couldn't find this case anywhere but changing the functions to catAttrs fixed the build issues...

Strange, I wonder if the issue is actually fixed or if catAttrs just filtered it out.

Collect each attribute named attr from a list of attribute sets. Sets that don't contain the named attribute are ignored.

It passed :tada: this PR is now ready to be merged c:

Rebased on top of master and addressed conflicts so it can be merged. Is anything blocking this? I don't want to keep going back and fixing small conflicts on this PR.

Applying the following patch on my Home Manager configuration:
From 5f88a66d30bf014109ce8a41350447621d100515 Mon Sep 17 00:00:00 2001
From: NAHO<EMAIL_ADDRESS>Date: Fri, 9 Feb 2024 23:04:41 +0100
Subject: [PATCH] feat(modules/stylix): support fallback fonts

---
 flake.lock                 | 11 ++++-----
 flake.nix                  |  2 +-
 modules/stylix/default.nix | 46 ++++++++++++++++++++++----------------
 3 files changed, 34 insertions(+), 25 deletions(-)

diff --git a/flake.lock b/flake.lock
index 8b35089..f58efc3 100644
--- a/flake.lock
+++ b/flake.lock
@@ -555,15 +555,16 @@
         ]
       },
       "locked": {
-        "lastModified":<PHONE_NUMBER>,
-        "narHash": "sha256-MJ4deL9tTzowkGpW9Iq+k3cSKo2gnvyIkIuFctNz/dQ=",
-        "owner": "danth",
+        "lastModified":<PHONE_NUMBER>,
+        "narHash": "sha256-KTAvqoFbvUmzfPgN3vxlr8FABlbJ9gbwRTYtSQ3HfWw=",
+        "owner": "jalil-salame",
         "repo": "stylix",
-        "rev": "f3b302dd9bb66fcdd1ed3f185068a5f1000eb863",
+        "rev": "20e410269dc0432e6884a1a31403951abf6c155f",
         "type": "github"
       },
       "original": {
-        "owner": "danth",
+        "owner": "jalil-salame",
+        "ref": "fallback-fonts-v2",
         "repo": "stylix",
         "type": "github"
       }
diff --git a/flake.nix b/flake.nix
index 97da286..a1c6fa2 100644
--- a/flake.nix
+++ b/flake.nix
@@ -73,7 +73,7 @@
         nixpkgs.follows = "nixpkgs";
       };

-      url = "github:danth/stylix";
+      url = "github:jalil-salame/stylix/fallback-fonts-v2";
     };

     # Add the 'systems' input for consistent versioning across inputs.
diff --git a/modules/stylix/default.nix b/modules/stylix/default.nix
index a758aa5..1365865 100644
--- a/modules/stylix/default.nix
+++ b/modules/stylix/default.nix
@@ -17,25 +17,33 @@
       };

       fonts = {
-        emoji = {
-          package = pkgs.noto-fonts-emoji;
-          name = "Noto Color Emoji";
-        };
-
-        monospace = {
-          package = pkgs.nerdfonts.override {fonts = ["FiraCode"];};
-          name = "FiraCodeNerdFont";
-        };
-
-        sansSerif = {
-          package = pkgs.ibm-plex;
-          name = "IBMPlexSans";
-        };
-
-        serif = {
-          package = pkgs.crimson;
-          name = "Crimson";
-        };
+        emoji = [
+          {
+            package = pkgs.noto-fonts-emoji;
+            name = "Noto Color Emoji";
+          }
+        ];
+
+        monospace = [
+          {
+            package = pkgs.nerdfonts.override {fonts = ["FiraCode"];};
+            name = "FiraCodeNerdFont";
+          }
+        ];
+
+        sansSerif = [
+          {
+            package = pkgs.ibm-plex;
+            name = "IBMPlexSans";
+          }
+        ];
+
+        serif = [
+          {
+            package = pkgs.crimson;
+            name = "Crimson";
+          }
+        ];

         sizes = {
           terminal = 7;
--
2.43.0

results in the following build error:
$ home-manager switch --flake <FLAKE>
error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'home-manager-generation'
         whose name attribute is located at /nix/store/5gc4ncnkzcgma8fl1qabm8v9kj7w68gl-source/pkgs/stdenv/generic/make-derivation.nix:352:7

       … while evaluating attribute 'buildCommand' of derivation 'home-manager-generation'

         at /nix/store/5gc4ncnkzcgma8fl1qabm8v9kj7w68gl-source/pkgs/build-support/trivial-builders/default.nix:98:16:

           97|         enableParallelBuilding = true;
           98|         inherit buildCommand name;
             |                ^
           99|         passAsFile = [ "buildCommand" ]

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: infinite recursion encountered

       at «none»:0: (source not available)

For reference, the following follow-up patch still causes the infinite recursion encountered error:
From a82f82470a83a7ea08c514d3f02ec8f0db10d15d Mon Sep 17 00:00:00 2001
From: NAHO<EMAIL_ADDRESS>Date: Fri, 9 Feb 2024 23:18:34 +0100
Subject: [PATCH] feat(modules/stylix): set 'monospace' font to default

---
 modules/stylix/default.nix | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/modules/stylix/default.nix b/modules/stylix/default.nix
index 1365865..7325a01 100644
--- a/modules/stylix/default.nix
+++ b/modules/stylix/default.nix
@@ -24,13 +24,6 @@
           }
         ];

-        monospace = [
-          {
-            package = pkgs.nerdfonts.override {fonts = ["FiraCode"];};
-            name = "FiraCodeNerdFont";
-          }
-        ];
-
         sansSerif = [
           {
             package = pkgs.ibm-plex;
--
2.43.0

The following patch applies this PR on my Home Manager configuration:

You should be able to remove the [], because we coerce font to fontList. I recently rebased this PR. I might've introduced errors then; my NixOS configuration uses this directly, but I haven't updated the flake: https://github.com/jalil-salame/configuration.nix

You should be able to remove the [], because we coerce font to fontList.

If the following patch is what you mean, then I am still receiving the same infinite recursion error:
From 559ce887a081d6d9e157693bb91cfccebbb17894 Mon Sep 17 00:00:00 2001
From: NAHO<EMAIL_ADDRESS>Date: Fri, 9 Feb 2024 23:33:55 +0100
Subject: [PATCH] fix(modules/stylix): convert list to attribute set

---
 modules/stylix/default.nix | 46 ++++++++++++++++----------------------
 1 file changed, 19 insertions(+), 27 deletions(-)

diff --git a/modules/stylix/default.nix b/modules/stylix/default.nix
index 1365865..a758aa5 100644
--- a/modules/stylix/default.nix
+++ b/modules/stylix/default.nix
@@ -17,33 +17,25 @@
       };

       fonts = {
-        emoji = [
-          {
-            package = pkgs.noto-fonts-emoji;
-            name = "Noto Color Emoji";
-          }
-        ];
-
-        monospace = [
-          {
-            package = pkgs.nerdfonts.override {fonts = ["FiraCode"];};
-            name = "FiraCodeNerdFont";
-          }
-        ];
-
-        sansSerif = [
-          {
-            package = pkgs.ibm-plex;
-            name = "IBMPlexSans";
-          }
-        ];
-
-        serif = [
-          {
-            package = pkgs.crimson;
-            name = "Crimson";
-          }
-        ];
+        emoji = {
+          package = pkgs.noto-fonts-emoji;
+          name = "Noto Color Emoji";
+        };
+
+        monospace = {
+          package = pkgs.nerdfonts.override {fonts = ["FiraCode"];};
+          name = "FiraCodeNerdFont";
+        };
+
+        sansSerif = {
+          package = pkgs.ibm-plex;
+          name = "IBMPlexSans";
+        };
+
+        serif = {
+          package = pkgs.crimson;
+          name = "Crimson";
+        };

         sizes = {
           terminal = 7;
--
2.43.0

I recently rebased this PR. I might've introduced errors then; my NixOS configuration uses this directly, but I haven't updated the flake: https://github.com/jalil-salame/configuration.nix

I see that your NixOS configuration still uses []: https://github.com/jalil-salame/configuration.nix/blob/main/nixos/stylix-config.nix#L15-L26.
Am I improperly applying your patch, or is there a bug?

Even entirely removing stylix.fonts causes the infinite recursion error:
From 6a75eccd8e8256061131651650d9e29bc8367786 Mon Sep 17 00:00:00 2001
From: NAHO<EMAIL_ADDRESS>Date: Fri, 9 Feb 2024 23:40:57 +0100
Subject: [PATCH] feat(modules/stylix): apply default fonts

---
 modules/stylix/default.nix | 26 --------------------------
 1 file changed, 26 deletions(-)

diff --git a/modules/stylix/default.nix b/modules/stylix/default.nix
index a758aa5..ef16b06 100644
--- a/modules/stylix/default.nix
+++ b/modules/stylix/default.nix
@@ -16,32 +16,6 @@
         size = 22;
       };

-      fonts = {
-        emoji = {
-          package = pkgs.noto-fonts-emoji;
-          name = "Noto Color Emoji";
-        };
-
-        monospace = {
-          package = pkgs.nerdfonts.override {fonts = ["FiraCode"];};
-          name = "FiraCodeNerdFont";
-        };
-
-        sansSerif = {
-          package = pkgs.ibm-plex;
-          name = "IBMPlexSans";
-        };
-
-        serif = {
-          package = pkgs.crimson;
-          name = "Crimson";
-        };
-
-        sizes = {
-          terminal = 7;
-        };
-      };
-
       image = pkgs.fetchurl {
         url = "https://www.pixelstalk.net/wp-content/uploads/2016/05/Epic-Anime-Awesome-Wallpapers.jpg";
         sha256 = "enQo3wqhgf0FEPHj2coOCvo7DuZv+x5rL/WIo4qPI50=";
--
2.43.0

Either the breaking change adoption is unclear, or a bug has been introduced.

You should be able to remove the [], because we coerce font to fontList.

If the following patch is what you mean, then I am still receiving the same infinite recursion error:
From 559ce887a081d6d9e157693bb91cfccebbb17894 Mon Sep 17 00:00:00 2001
From: NAHO<EMAIL_ADDRESS>Date: Fri, 9 Feb 2024 23:33:55 +0100
Subject: [PATCH] fix(modules/stylix): convert list to attribute set

---
 modules/stylix/default.nix | 46 ++++++++++++++++----------------------
 1 file changed, 19 insertions(+), 27 deletions(-)

diff --git a/modules/stylix/default.nix b/modules/stylix/default.nix
index 1365865..a758aa5 100644
--- a/modules/stylix/default.nix
+++ b/modules/stylix/default.nix
@@ -17,33 +17,25 @@
       };

       fonts = {
-        emoji = [
-          {
-            package = pkgs.noto-fonts-emoji;
-            name = "Noto Color Emoji";
-          }
-        ];
-
-        monospace = [
-          {
-            package = pkgs.nerdfonts.override {fonts = ["FiraCode"];};
-            name = "FiraCodeNerdFont";
-          }
-        ];
-
-        sansSerif = [
-          {
-            package = pkgs.ibm-plex;
-            name = "IBMPlexSans";
-          }
-        ];
-
-        serif = [
-          {
-            package = pkgs.crimson;
-            name = "Crimson";
-          }
-        ];
+        emoji = {
+          package = pkgs.noto-fonts-emoji;
+          name = "Noto Color Emoji";
+        };
+
+        monospace = {
+          package = pkgs.nerdfonts.override {fonts = ["FiraCode"];};
+          name = "FiraCodeNerdFont";
+        };
+
+        sansSerif = {
+          package = pkgs.ibm-plex;
+          name = "IBMPlexSans";
+        };
+
+        serif = {
+          package = pkgs.crimson;
+          name = "Crimson";
+        };

         sizes = {
           terminal = 7;
--
2.43.0

I recently rebased this PR. I might've introduced errors then; my NixOS configuration uses this directly, but I haven't updated the flake: https://github.com/jalil-salame/configuration.nix

I see that your NixOS configuration still uses []: https://github.com/jalil-salame/configuration.nix/commit/a3ce3b2944791604693dde69a3494faa2d09b08d.

Yup, I use it because I set a fallback font (NerdFont symbols only), but if I didn't it is not necessary.

Am I improperly applying your patch, or is there a bug?

There probably is a bug. Thanks for noticing.

So far what I can tell is that dunst(?) is accessing the fonts before they are fully evaluated, but I need to look more into it before I come to a conclusion and can push a fix.

Am I improperly applying your patch, or is there a bug?

There probably is a bug. Thanks for noticing.

So far what I can tell is that dunst(?) is accessing the fonts before they are fully evaluated, but I need to look more into it before I come to a conclusion and can push a fix.

Mark the PR as ready once it's intended for review.

Am I improperly applying your patch, or is there a bug?

There probably is a bug. Thanks for noticing.

So far what I can tell is that dunst(?) is accessing the fonts before they are fully evaluated, but I need to look more into it before I come to a conclusion and can push a fix.

Mark the PR as ready once it's intended for review.

Sorry about that, I haven't had time to fix this. It broke locally so I had to rebase it, but I don't have time to look into the issue...

I can't figure out what is causing the infinite recursion in @trueNAHO 's case. I'll try removing the coercing code and checking again.

Removing the coercion to a list did not work T-T.

I don't know what is going on with the infinite recursion, it was not the coercing code, so it probably has to do with builtins.head being eager while we need some construct like lib.mkIf instead. I don't know how to build such a construct though, so I give up. Feel free to take over or close this.

I can't figure out what is causing the infinite recursion in @trueNAHO 's case. I'll try removing the coercing code and checking again.

Do you not encounter a infinite recursion encountered error?

I can't figure out what is causing the infinite recursion in @trueNAHO 's case. I'll try removing the coercing code and checking again.

Do you not encounter a infinite recursion encountered error?

I do encounter it, I just could not find the cause. I tried turning off different parts of the config, but nothing worked.

Do you not encounter a infinite recursion encountered error?

I do encounter it, I just could not find the cause. I tried turning off different parts of the config, but nothing worked.

Simplifying the PR with https://github.com/danth/stylix/pull/201#discussion_r1590336460 does not resolve the issue. This seems to be a rather nasty infinite recursion encountered error...
However, the PR itself seems fine. I assume the problem stems from something seemingly unrelated within Stylix.

Would it not be better to supersede this PR with the one mentioned in https://github.com/danth/stylix/issues/216#issuecomment-1921235916? Although that PR would need to be superseded as well to resolve the pending suggestions (and attract new attention).

Would it not be better to supersede this PR with the one mentioned in #216 (comment)? Although that PR would need to be superseded as well to resolve the pending suggestions (and attract new attention).

Ideally yes, but its been open for ~2 years now

Would it not be better to supersede this PR with the one mentioned in #216 (comment)? Although that PR would need to be superseded as well to resolve the pending suggestions (and attract new attention).

Ideally yes, but it has been open for ~2 years now

https://github.com/nix-community/home-manager/pull/2732 has been merged.

Would it not be better to supersede this PR with the one mentioned in #216 (comment)? Although that PR would need to be superseded as well to resolve the pending suggestions (and attract new attention).

Ideally yes, but it has been open for ~2 years now

:tada: great work! Thanks! Feel free to close this issue then!

🎉 great work! Thanks! Feel free to close this PR then!

Does https://github.com/nix-community/home-manager/pull/2732 cover what you wanted to do with this PR?

Not really, what I'd want is to pull the defaultFonts.* and get my apps to follow it (specifically Wezterm). But this can be done using a different PR

Not really, what I'd want is to pull the defaultFonts.* and get my apps to follow it (specifically Wezterm). But this can be done using a different PR

Depending on the discussion in https://github.com/danth/stylix/issues/366, we might still need this PR.


Installation fails on R4.1.2: undefined exports: geom_euler

Attempted to install this package according to the instructions in the README, and got this error:
> devtools::install_github("nicolash2/ggvenn")
Downloading GitHub repo nicolash2/ggvenn@HEAD
✔  checking for file ‘/tmp/Rtmp8LG4RT/remotes4930512dfc52/NicolasH2-ggvenn-28c0c60/DESCRIPTION’ (917ms)
─  preparing ‘ggeuler’:
✔  checking DESCRIPTION meta-information ...
─  checking for LF line-endings in source and make files and shell scripts
─  checking for empty or unneeded directories
   Omitted ‘LazyData’ from DESCRIPTION
─  building ‘ggeuler_0.1.0.tar.gz’

* installing *source* package ‘ggeuler’ ...
** using staged installation
** R
** byte-compile and prepare package for lazy loading
** help
*** installing help indices
** building package indices
** testing if installed package can be loaded from temporary location
Error: package or namespace load failed for ‘ggeuler’ in namespaceExport(ns, exports):
 undefined exports: geom_euler
Error: loading failed
Execution halted
ERROR: loading failed
* removing ‘<R_HOME>/library/ggeuler’
Warning message:
In i.p(...) :
  installation of package ‘/tmp/Rtmp8LG4RT/file4930495836cb/ggeuler_0.1.0.tar.gz’ had non-zero exit status

Thank you for bringing this to my attention, I just fixed and uploaded it and you should be able to
The error occurred due to the renaming process. Hopefully all remnants of the old package name are now gone.


VSCode hangs with 100% CPU in Code Helper process when viewing specific file

VSCode Version: Code 1.13.1 (379d2efb5539b09112c793d3d9a413017d736f89, 2017-06-14T18:13:05.928Z)
OS Version: Darwin x64 16.6.0
Extensions:

Extension
Author
Version

vscode-markdownlint
DavidAnson
0.9.1

vscode-docker
PeterJausovec
0.0.16

sort-lines
Tyriar
1.3.0

githistory
donjayamanne
0.2.0

python
donjayamanne
0.6.5

cpptools
ms-vscode
0.11.4

csharp
ms-vscode
1.10.0

mono-debug
ms-vscode
0.15.6

Ruby
rebornix
0.12.1

Steps to Reproduce:

mkdir vscodehang && cd vscodehang
wget https://raw.githubusercontent.com/mono/mono/c7b19b52fd671233cf2daab451f09c7591c859b1/mcs/class/Mono.Security/Mono.Xml/MiniParser.cs
code .
Open MiniParser.cs
VSCode gets unresponsive and offers to reopen window

Can reproduce this in latest insider, even when only pasting the file contents from https://raw.githubusercontent.com/mono/mono/c7b19b52fd671233cf2daab451f09c7591c859b1/mcs/class/Mono.Security/Mono.Xml/MiniParser.cs

I can also repro, vscode crashes, might be a text mate grammer going inffinite

Reproduced with
private static readonly ushort[] tbl = {
		(ushort)(((ushort)CharKind.LEFT_BR << 12) | ((ushort)ActionCode.STATE_CHANGE << 8) | 1),

and adding additional
(ushort)(((ushort)CharKind.LEFT_BR << 12) | ((ushort)ActionCode.STATE_CHANGE << 8) | 1),

array items brings TextMate to a standstill.

This issue was moved to dotnet/csharp-tmLanguage#76


Remove CrateComponent load mechanism

Instead load all componenets via CrateNode. The dependencies are all
known and available at compile time.
There is no need to use a discovery mechanism to find them.

@dobe please review

@dobe can you take a look at this again?

ack