Config Import RRD data handling

Config Import RRD data handling
Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
When importing a config that has been exported with Do not backup RRD data. unchecked the rrddata part of the export does not get stripped on import unless Exclude console settings from import. is checked.
What happened
In preparation for the update to 23.7 on our main instance we recently updated a test instance of OPNsense from 23.1.10 to 23.7.1_3 (see https://github.com/opnsense/core/issues/6728 for details; unrelated to the current issue). With the release of 23.7.2 the blockers we encountered before seemed to have been resolved and we decided to update the test instance, export the lastest config from the production environment (still on the latest 23.1 release due to the previous blockers) and import the config on the test instance. Right after a successful import the config history (System > Configuration > History) showed that our config supposedly grew from around 600 KB to around 10 MB and the diff showed that an rrddata block was now considered part of the config. Comparing the Health graphs (Reporting > Health) on both systems indicated that the data was correctly imported. As everything seemed to be working, except for the supposedly grown config, we exported the config of test system (23.7.2) once without RRD data and once with it to see the results. The export without RRD data still contained the rrddata block from the old export and the export with RRD contained two rrddata blocks (the old and a new one). As a workaround we removed the rrddata block from the new export that should not have contained any block to begin with and imported the modified config. This brought our config size back down to its original value. Exporting without RRD data gave us a clean config file, exporting with RRD data gave us a config file with RRD data. Importing the new export with RRD data (this time exported from 23.7.2) brought the config size to 10 MB again and the issue resurfaced. Importing an export with two rrddata blocks resulted in a 20 MB config and repeating the process added almost 10 MB each time, because another rrddata block got added to the config.
Looking at the source of src/www/diag_backup.php we quickly found the code at fault:
https://github.com/opnsense/core/blob/587a50cb7c8c04af71f36ccc74a1464383916607/src/www/diag_backup.php#L258-L267
If rrddata is set on a full restore the if in line 259 evaluates as true: the rdd data gets imported (line 261) and the rrddata is removed from the config (262).  As a consequence of this the first part of the if in line 264 can never be true, because it‘s the same condition as line 259, which means the rrddata has already been stripped from the config (line 262). This means the check to determine if the config has to be written to file effectively only checks if keepconsole is part of the POST parameters.
Based on the code we tried importing our config with Exclude console settings from import. checked. With this checkbox active the import properly writes the config without rrddata to disk, no matter how many rrddata blocks the used config contains.
I don’t know if this matches your preferred style, but this is the diff of a fix I tested on our system:
diff --git a/src/www/diag_backup.php b/src/www/diag_backup.php
index 8f67583f6..21442ac91 100644
--- a/src/www/diag_backup.php
+++ b/src/www/diag_backup.php
@@ -245,7 +245,9 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') {
                         $do_reboot = true;
                     }
                     $config = parse_config();
-                    if (!empty($pconfig['keepconsole'])) {
+                    $keepconsole = !empty($pconfig['keepconsole']);
+                    $got_rrddata = !empty($config['rrddata']);
+                    if ($keepconsole) {
                         // restore existing console settings
                         foreach ($csettings as $fieldname => $fieldcontent) {
                             if ($fieldcontent === null && isset($config[$fieldname])) {
@@ -256,12 +258,12 @@ if ($_SERVER['REQUEST_METHOD'] === 'GET') {
                         }
                     }
                     /* extract out rrd items, unset from $config when done */
-                    if (!empty($config['rrddata'])) {
+                    if ($got_rrddata) {
                         /* XXX we should point to the data... */
                         rrd_import();
                         unset($config['rrddata']);
                     }
-                    if (!empty($config['rrddata']) || !empty($pconfig['keepconsole'])){
+                    if ($got_rrddata || $keepconsole){
                         write_config();
                         convert_config();
                     }

Expected behavior
We expected the system would strip the rrddata block from the config when importing it, just like old versions of OPNsense used to.
To Reproduce
Steps to reproduce:

Go to System > Configuration > Backups
Uncheck Do not backup RRD data.
Click on Download configuration
Choose the just downloaded file as input for the restore option
Uncheck Exclude console settings from import.
Click on Restore configuration

Optionally you can also uncheck Reboot after a successful restore. when restoring the config.
Describe alternatives you considered
Importing with Exclude console settings from import. checked to avoid the issue, but that defeats the purpose of a restore on identical hardware.
Environment
Versions:

OPNsense 23.7.2-amd64
FreeBSD 13.2-RELEASE-p2
OpenSSL 1.1.1v 1 Aug 2023

CPU type:

Intel(R) Xeon(R) CPU D-1518 @ 2.20GHz (4 cores, 8 threads)

@Daggolin https://github.com/opnsense/core/commit/318be6ab60e7fc50c3a75ae7de37047d415d8ba3 should fix the issue. thanks for reporting.


Uppercase on Label Issue

Why the label is converted to uppercase? I think it's doesn't necessary. Can I change it to normal text?

#47


Create option batching strategies beyond simple batching for stream options

For first release we will have a simple batching strategy in place for streams. We need to see if we should provide other batching strategies in a future release.

Closing due to insufficient interest. If you would like to see this supported, please respond to this issue


create baseTexture in the middleware before loading starts

this code will work:
loader.add('something.png');
loader.load();
//loading started but we want to use that NOW
var tex = Texture.fromImage('something.png');

Couple notes:

Don't change the package.json version in PRs
This change makes texture loader run both before and after, which I don't understand

Couple notes:

Don't change the package.json version in PRs
This change makes texture loader run both before and after, which I don't understand

We had loooong chat in gitter and I admit that this thing needs work. I just wanted fromImage to work through new shiny loader with middlewares and I dont care about that invariant: "all objects must be created only when resources are ready". I thought that BaseTexture can be some kind of promise for an image.

We had loooong chat in gitter and I admit that this thing needs work. I just wanted fromImage to work through new shiny loader with middlewares and I dont care about that invariant: "all objects must be created only when resources are ready". I thought that BaseTexture can be some kind of promise for an image.


Float16 version of besselj0

From the discussion in #18, it might be useful to also provide lower precision Float16 as well. Here is a first pass at this for besselj0 it has a maximum relative error of 1.303792e-5 which is good enough for Float16.
It is also much faster...
julia> @benchmark Bessels.besselj0_Float16(x) setup=(x=rand()*10)
BenchmarkTools.Trial: 10000 samples with 1000 evaluations.
 Range (min … max):   3.618 ns … 31.208 ns  ┊ GC (min … max): 0.00% … 0.00%
 Time  (median):     11.285 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):    9.753 ns ±  5.091 ns  ┊ GC (mean ± σ):  0.00% ± 0.00%

  █               ▁▁  ▆▆▄▅    ▆ ▅   ▃                    ▂    ▂
  █▃▁▃▅▄▃▄▁▁▁▁▁▁▁▁██▁▁████▅█▆▄█▄█▁▇▅█▇▇██▇▇▆▁▁▁▁▁▁▁▁▁▁▁▁▁█▁▄█ █
  3.62 ns      Histogram: log(frequency) by time      25.2 ns <

 Memory estimate: 0 bytes, allocs estimate: 0.

julia> @benchmark Bessels.besselj0(x) setup=(x=rand()*10)
BenchmarkTools.Trial: 10000 samples with 1000 evaluations.
 Range (min … max):   4.914 ns … 34.692 ns  ┊ GC (min … max): 0.00% … 0.00%
 Time  (median):     25.608 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   22.534 ns ±  7.523 ns  ┊ GC (mean ± σ):  0.00% ± 0.00%

                                                        █
  ▅▂▁▂▂▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁█▂▅▂▂ ▂
  4.91 ns         Histogram: frequency by time        27.2 ns <

 Memory estimate: 0 bytes, allocs estimate: 0.

The function right now was doing everything in Float64 so need to go through and fix this. It is probably best to do all these calculations in Float32? I'm not for sure if there is that much of a performance gain from doing this in Float16. I think the power series for small arguments can be done in low precision but will need to be careful again with the cos(x+xn) term.
And a side note. I tried the integral version of besselj0 = cos(-xsin(\theta)) d\theta integrated from 0 to pi and found that for small arguments this could be evaluated fairly quickly but large arguments it oscillates too much to be worth it.

Using Float64 for the math is reasonable, it should be similar speed (at least for scalar stuff)

Sounds good! I think I'll plan to do all the calculations in Float32 as that should be plenty for this precision? Might be helpful for GPU computing? Though, maybe I should spend some time on the pure 'Float32' implementation instead which would only require two more digits of accuracy.... I'll play around with that as simply converting the Float16 to Float32 and converting it back takes a non-negligible amount of time here it appears...


Crash

Hi,
I've a crashed and it's detailed in the log core with:
[17:38:43] [log-core] exception 0XC0000005 (ACCESS_VIOLATION) from Vectored Exception Handler catched; shutting log-core down
1998/messages': stream truncated
I have the discord plugin, mysql and raknet plugin - all the latest version.
There is no error or message in the console and it doesn't close or crash but causes the server to hang completely. I have to close the server off.

Ingame freezes completely, you can move etc but no cmds or speak.
if you re-connect - console will eventually kick you as you didn't login.

The issue is not related to Pawn.RakNet.

With all due respect katursis I only started having this issue when using pawnraknet.

Attach full server_log.txt.

Hi Katursis,
There is no extra log in server_log - it's standard prints from the gamemode, no errors or anything.
The only log is that line from the log core.
When it locks up I cannot type ingame or perform CMDs. When I try to click X on the console it doesn't turn off straight away, it freezes for a second or two then closes. If you quit ingame and relogin it won't let you connect, it doesn't initialize you but in the console it eventually says:
Kicking [IP HERE] because they didn't logon to the game.
Do you have a discord I could message you on for speedier communication?
Thank you,

katursis#1818


Update memory cache sample and docs

@danroth27 @sebastienros @Rick-Anderson
The primary change for memory cache was the replacement of IEntryLink with CreateEntry.

Hi @Tratcher, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

:shipit:


latest update bug

hey,
my project was working just fine until i updated my nuxt version yesterday, now i receive this error

any ideas?

By what we can read, the issue seems to be in vue-awesome.
Can you show more code snippets?

i solved it by changing the import from
import 'vue-awesome/icons'
import Icon from 'vue-awesome/components/Icon'

To
var Icon = require('vue-awesome/components/Icon.vue')
(it was working with nuxt 0.9.7 by the way)
thanx.


Trigger br-ex configuration only once in MicroShift

otherwise it breaks on reboot.

lgtm

/lgtm
it was verified manually

/retest


Task 2

@Jegan-git500
Task -2
Code verified.
Task -3
Code verified.
Task -4
Code verified.
Task -5
Code verified.
Task -6
Code verified.
Task -7
Code verified.
Task -8
Code verified.
Task -9
Code verified.
Task -10
Code verified.

@Jegan-git500
Task -11
Code verified.
Task -12
Code verified.
Task -13
Code verified.
Task -14
Code verified.
Task -15
Code verified. invalid output check the index
Task -16
Code verified.
Task -17
Code verified.


up,down,left,right keys not working for games

I am emulating the up,down,left,right keys with accelerometer  based gestures,it is working perfectly for text editor,ppt and other windows but the keys are not emulated when I am trying to control the games to emulate up,down,next,previous from the accelerometer

There are some programs which seem to ignore PyAutoGUI's key strokes and mouse movements. I know that A/V software common prevents software from clicking on its windows (so viruses can't shut off A/V). Though there may be other reasons why programs like games ignore PyAutoGUI as well.
I'll leave this issue open until other people with more Windows internals knowledge could answer or help figure this out.

I am seeing the same / similar behaviour with mouse movements not being seen by a flash game in Edge. Works fine in Chrome and Firefox. My script moves the mouse to an item on screen and wants to click on it. But the flash game doesn't see the mouse movement, so it won't 'highlight' the item. Any click generated by pyautogui will not work because the item is not highlighted.
When I use the physical mouse, it works fine.
It's Edge specific. I'm not using any AV other than the built in Windows Defender. Im local admin, both Edge and python running as the same (local admin) user.

I have done some fiddling and if you use mouse_event directly instead of the SetCursorPos, it fixed the problem for me. I don't a PR ready, but used the code from this class on SO to test:
https://stackoverflow.com/questions/4263608/ctypes-mouse-events?rq=1

I also get same problem

This problem is due, to the use of VK key input in pyautogui. The games, where you experience the problem is because, they use direct input. For that you can use pydirectinput module, which is same like pyautogui. I.e they have same functions and methods with same name


Revert "Revert "[Distributed] Generate SIL for DistributedActor.resolve""

Reverts apple/swift#38994

@swift-ci test


alert_text_args based on event ID or ignore MISSING VALUE?

This concerns converting Sigma to Elastalert via script(thank you Cyb3rWard0g)
Is there a way to configure alert_text_args in the config.yml based on the alert? I mean without editing each signature.yml file?
I have these args;
alert_text: "Event ID: {} \nUsername: {} \nHost: {} \nParentProcess: {} \nCommands: {} \nMessage: {}"
alert_text_type: alert_text_only
alert_text_args:
    - winlog.event_id
    - winlog.event_data.SubjectUserName
    - winlog.computer_name
    - winlog.event_data.ParentProcessName
    - winlog.event_data.CommandLine
    - message

which work great with event ID 4688 but I get missing values with 4625.
f88e112a-21aa-44bd-9b01-6ee2a2bbbed1_0
Event ID: 4625
Username: mycomputer
Host: hostname.net
ParentProcess: <MISSING VALUE>
Commands: <MISSING VALUE>

...is there a way to only receive the params from alert_text_args IF there's something there?  And not even show the  something I'd have to add to each yml signature?
Hah, or I could just be doing it all wrong.
Thank you!

We also recommend asking questions on the Gitter channel
https://gitter.im/Yelp/elastalert

Yelp/elastalert is no longer maintained. Please use jertel elastalert. Questions to the discussion below
https://github.com/jertel/elastalert/discussions


Quiet light theme breaks activity bar icon contrast

https://github.com/Microsoft/vscode/issues/25103


Update pgvector to v0.6.0, fourth attempt

Reverts the revert at 7e8529bec127aa13f5f4a819a24495c0a8e18aea
NOTE: This should not be merged before we fix the problem with autoscaling and the DSM allocation (https://github.com/neondatabase/autoscaling/issues/800)

I suggest you consider bumping the version of pgvector to 0.70 since that is the latest.

Replaced by https://github.com/neondatabase/neon/pull/7726 - we plan to do a skip level upgrade of pgvector from 0.5.x to 0.7.x


Using canvas

Hi. Could you tell me how to use canvas to draw map layer with your directive?

You have two possibilities:

Create your own canvas, above (z-index) the map like this:

#map {
    display: block;
    width: 100%;
    height: 100%;
    position: relative;
    z-index: 1;
}

#canvas {
    display: block:
    width: 100%;
    height: 100%;
    position: absolute;
    z-index: 2;
    pointer-events: none; /* this will allow you to scroll the map and pass-through all the events */
}

and then just simply get it in javascript and draw anything on it:
var canvas = document.getElementById('canvas');
var context = canvas.getContext('2d');

// drawing logic

You can use this plugin for Leaflet: https://github.com/CartoDB/Leaflet.CanvasLayer and use with mapObject given by leafletData.getMap() promise.

Doesn't leaflet support canvas out of the box?

Look at the code and the examples.
https://github.com/tombatossals/angular-leaflet-directive/blob/master/src/services/leafletLayerHelpers.js

If the functionality is missing then see if you can add it.

This issue was moved to angular-ui/ui-leaflet#53

I'm going to rework&redesign angular-leaflet-directive to be compatible with Leaflet v1.0. It will mantain almost all its functionality, and will be compatible with the current features of the directive, but I must start from a fresh point, so I'm going to close this issue. If you think it must be worked with the new version, please reopen it.


Introduce --profile

Chrome DevTools compatible profiler

Add to docs/website?

Add to docs/website?

Add to docs/website?

@dotansimha @kamilkisiela added some docs for this feature


Fix long options rendering.

#177

Could you rebase on current master? I'll try to merge it then

@TomasVotruba yeah will do soon.

Closing as outdated

Closing as outdated


Add jainpatel25

Related issue

What changes does this PR do?
Screenshots (If any)
Questions

I change it and make new one


Add support for SSO (Single Sign-On) season

Rabbit season

Flaky Test
Failure Summary
Logs

[chromium] should display user profile information correctly.
The test timed out waiting for the expected text "User Profile" in the page, but it received an empty array instead.
Logs ↗

[chromium] should return list of users correctly.
The API call to get the list of users failed with a 404 Not Found error.
Logs ↗

[chromium] should display error message for invalid login correctly.
The expected HTTP status code 401 was not received, instead a function was returned.
Logs ↗

[chromium] should login with credentials correctly correctly.
The login request to the server failed with a 404 Not Found error.
Logs ↗

... and 1 more

View Full Report ↗ ⋅ Docs

Flaky Test
Failure Summary
Logs

[chromium] should display user profile information correctly.
The test timed out waiting for the expected text "User Profile" in the page, but it received an empty array instead.
Logs ↗

[chromium] should return list of users correctly.
The API call to get the list of users failed with a 404 Not Found error.
Logs ↗

[chromium] should display error message for invalid login correctly.
The expected HTTP status code 401 was not received, instead a function was returned.
Logs ↗

[chromium] should login with credentials correctly correctly.
The login request to the server failed with a 404 Not Found error.
Logs ↗

... and 1 more

View Full Report ↗ ⋅ Docs


Redis upgrade

Description
Part of the dependency upgrades, but since it jumps a major version, I think it is better to have a separate PR for it.
How Has This Been Tested?
Test suite were ran locally.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Can you rebase this off of main? It conflicts with your other PR.

I rebased and it turns out latest redis-namespace only requires redis 4+, so redis doesn't need to be upgraded yet. Not sure why bundler resolved it to version 5 before :man_shrugging:

Thank you!


Is there a  bug in Memory usage  of 0.21.0 ?

Memory usage 95%？？？

I want to konw  Which version fuse you used ?

fuse version is not relevant here. did memory grow over time? could you note the memory usage before/after doing the 500MB write in #457? If you have a list of steps you take to reproduce this it would be very helpful

I use aws S3 bucket ，upload 50G file。the memery usage more than 50%。Finally ，Causing process exit，and upload failed !!!

the upload speed could arrive 120MB/S , but Memory usage is too high。I think there must be a bug !

fuse version is not relevant here. did memory grow over time? could you note the memory usage before/after doing the 500MB write in #457? If you have a list of steps you take to reproduce this it would be very helpful

I will rum "./goofys   --debug_fuse --debug_s3 --region  cn-north-1   goofys   /root/new/ >& goofys.log " to get the log file .

fuse version is not relevant here. did memory grow over time? could you note the memory usage before/after doing the 500MB write in #457? If you have a list of steps you take to reproduce this it would be very helpful

I am looking source code ,hope too find the problem ,why Memeroy Uasge is so high, and goofys process exit.

fuse version is not relevant here. did memory grow over time? could you note the memory usage before/after doing the 500MB write in #457? If you have a list of steps you take to reproduce this it would be very helpful

I found goofys binay file ,which make build by myself , it's can upload 50G file ,and Memeroy Uasge is only 50%。 I think if the release version of goofys is not correct?

what does goofys --version say for your own goofys binary?

For what it's worth, the underlying AWS S3 library is known to use huge amounts of memory when uploading. See https://github.com/aws/aws-sdk-go/issues/2228 and https://github.com/aws/aws-sdk-go/issues/2036.

I don't use the upload manger

There was a similar bug in rclone (which is also using AWS SDK) but was fixed in their latest version. Maybe you can gain some insights from their fix.


Fixes #127

PR Description 📜
This PR adds an auto-commenting feature to the new issues that'll be raised.
Fixes #127

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[ ] I have added screenshot for review.

## Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

@Durgesh4993 Sir kindly review the PR and merge it.
Thank you!

@Durgesh4993 Yeah, I'll do it.

@Durgesh4993 I'm done with the changes. Kindly review.
Thank you!


Support BYO certificates for all Dispatch Solo endpoints

Feature Request
Detailed Description

Customer may configure Dispatch Solo with their own certificates.
Context

Possible Implementation

Complexity

[ ] Low - Simple enhancement or bug fix, no architectural changes or refactoring
[ ] Medium - Change requires some thought, but is relatively isolated
[ ] High - Significant architectural change or large refactor

Closing as a duplicate of #642


action widget appears in wrong spot

not sure of a repro yet
https://user-images.githubusercontent.com/29464607/207683528-6043310e-8ec4-49cc-88d3-f05cbd154138.mov

For me I can repro 100% by:

Run bad command like git chekout
Resize the panel up or down
Ctrl+.

this happens bc we set the rendering context on the first render and then don't update it on resize
https://github.com/microsoft/vscode/blob/12c6a4f40a3ed84a8f060465ca9dcb9e5041598c/src/vs/workbench/contrib/terminal/browser/xterm/quickFixAddon.ts#L271

Issue marked as unreleased but unable to locate closing commit in repo history. If this was closed in a separate repo you can add the insiders-released label directly, or comment \closedWith someShaThatWillbeReleasedWhenThisIsRelesed.


Fix: bug on description & tag update for duplicate entity names

Describe your changes :

I worked on the bug in EntityTable UI.
For detailed description, see: https://github.com/open-metadata/OpenMetadata/issues/10067

Type of change :

[x] Bug fix

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

- TBD (I'm struggling on setting up test env)

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] All new and existing tests passed.

Reviewers

Frontend: @open-metadata/ui

Great work @nuang-ee  🙌🏻,
Thanks for the contributions ✨


Create an event when the result is empty

Create an event when the result is empty

@shad-k Sorry bro, I already had assigned this issue to me

@carloschneider no worries.


imitatingUserId not cleaned correctly

PHP Version: 8.2   | Shopware Version: <IP_ADDRESS>  | Affected area / extension: Platform(Default)

Expected behaviour:
When "Logged in as customer" the field imitatingUserId contains the user id of the logged in admin user. When the customer logs out of their account, our "impersonating" session also gets logged out due to the token being rotated.
The imitatingUserId in our context should now be empty, as we are not logged in anymore.
Actual behaviour:
When "Logged in as customer" the field imitatingUserId contains the user id of the logged in admin user. When the customer logs out of their account, our "impersonating" session also gets logged out due to the token being rotated.
However our Context still contains the 'imitatingUserId'. Even when logging in as any other user, the imitatingUserId is not cleared.
How to reproduce:

Login as customer via Admin
Check the imitatingUserId field (for example by dumping it somewhere)
Log in as this customer, using the password, in another browser or incognito
Log out the new browser
The original session will also be logged out, but still have the imitatingUserId field.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-39277
[created from NEXT-39277, comment 507032]

@akf-bw since you opened the PR, maybe do you have time to have a look?

@mstegmeyer @runelaenen In your example, since you "killed" the first original session, there was never a true logout with a CustomerLogoutEvent which normally clears this field.
Since we need to store the imitatingUserId as sw-imitating-user-id in the PHP session, this attribute is not cleared correctly in this case and would only be gone after a successful logout or when the PHP session ends for that browser.

@akf-bw Good point! Thanks for the fix!

[public]

Status Change: Open

This issue is ready for implementation.
[created from NEXT-39277, comment 509926]

[public]

Status Change: In Progress

Work on this issue has started. It is now being implemented.
[created from NEXT-39277, comment 509927]

[public]

Status Change: In Review

Work on this ticket is complete and is now pending review.
[created from NEXT-39277, comment 509928]

[public]

FixVersion Change: <IP_ADDRESS>

This issue will be / was solved in Shopware version <IP_ADDRESS>.
[created from NEXT-39277, comment 509929]

[public]

Status Change: Resolved

The ticket has been successfully completed; the solution is implemented and verified.
[created from NEXT-39277, comment 510154]

I just ran into this issue as well. Thanks for providing a fix!


refactor(cli): support "description" in "gas commit" command

Pull Request Test Coverage Report for Build 948582535

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.92%

Totals

Change from base Build 946269612:
0.0%

Covered Lines:
4854

Relevant Lines:
5716

💛  - Coveralls


Cleans up CSS formatting

General CSS cleanup.
Additions

Adds missing comments at the top of several page-specific CSS files.

Removals

Excessive whitespace and newlines.

Changes

Moves comments to their own line.
Fixes comment grammar.
Changes to inline comment styling.
Replaces hardcoded color with variable.

Testing

Site-wide

Review

@sebworks
@jimmynotjim

Preview
No change (or there shouldn't be anyway!)

:+1:  Nice Work


Update green.css

Final Fix For The index page poster image not loading

Update Successful! Thank You For your Contribution.


RHIDP-1703: Revert querying of OCP Cluster Ingress

Revert the automatic querying of the OCP Cluster Ingress for the domain to use for the clusterRouterBase as regular users do not have access to this resource, only cluster admins.
Checklist

[x] Chart version bumped in Chart.yaml according to semver.
[x] Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
[ ] JSON Schema template updated and re-generated the raw schema via pre-commit hook.
[ ] List tests pass for Chart using the Chart Testing tool and the ct lint command.

Revert the automatic querying of the OCP Cluster Ingress for the domain to use for the clusterRouterBase as regular users do not have access to this resource, only cluster admins.

I guess the issue that the reverted commit was supposed to fix should be somehow reopened here or in JIRA as not fixed? janus-idp#167?

makes sense, yeah

@rm3l From what I can see there is not a programmatical way to solve this issue. The issue is really solved via the documentation that describes what information should be placed in the clusterRouterBase field. I was also thinking that maybe we could just have this code run if the user is a cluster-admin, but I don't see a way using helm to determine that as the install just fails on the lookup command, even if it is just used in an if block.

/approve

Two approvals, I am going to go ahead and merge this.

@rm3l From what I can see there is not a programmatical way to solve this issue due to limitations in Helm. The issue is really solved via the documentation that describes what information should be placed in the clusterRouterBase field. I was also thinking that maybe we could just have this code run if the user is a cluster-admin, but I don't see a way using helm to determine that as the install just fails on the lookup command, even if it is just used in an if block.

No problem, just wanted to make sure that people who reported the original issue (https://github.com/janus-idp/helm-backstage/issues/167) were aware of this revert in case they expected the original issue to have been implemented (and were maybe depending on it) in which case this PR would have been a potential breaking change.
But after a closer look at https://github.com/janus-idp/helm-backstage/issues/167, it was requested in https://github.com/parodos-dev/orchestrator-helm-chart/issues/12. But it seems from their Chart.yaml that they are no longer using the RHDH Chart, but are now using the RHDH Operator instead.
So I guess we don't need to create a JIRA issue for https://github.com/janus-idp/helm-backstage/issues/167


use of undeclared crate or module proptest

Summary
Problem
Running cargo test fails with the following:
error[E0433]: failed to resolve: use of undeclared crate or module `proptest`
 --> rhizome/src/test_utils/rvg.rs:1:5
  |
1 | use proptest::{
  |     ^^^^^^^^ use of undeclared crate or module `proptest`

This happens because proptest is an optional dependency, and only installed when the test_utils feature is enabled.
Impact
I'm unable to run tests locally without manually specifying the feature each time.
Solution
Since there's no way to enable this feature for the test profile, proptest should be unconditionally installed as part of the dev-dependencies:
[dev-dependencies]
proptest = { version = "1.0" }

Good catch. I had some intentions before this on how to push for certain feature flags, but going simple is better here.


chore: update README.md

adding a banner informing users about the new project

@Chriscbr Can we merge this with admin permissions? The error that we are seeing here is something I have seen in multiple PRs and hence opened an issue on the projen repo: https://github.com/projen/projen/issues/1747


Remove challenge Question Password entries

$subject

Duplication of https://github.com/wso2/product-is/pull/18172


ARROW-4679: [Rust] Implement in-memory data source for DataFusion

This PR adds a new memory-based table implementation and updates the DataFusion benchmarks to load CSV data into memory before the benchmark starts and then measure the performance of executing queries against in-memory data.
This PR also renames the data source traits and organizes them better in a new namespace.
Finally, it is now possible to register arbitrary data sources with the execution context.

@sunchao @paddyhoran @kszucs Would appreciate a review when you get a chance

Hi @paddyhoran this is ready for re-review now. Thanks.


TypeError: -0.034149169921875 has type float, but expected one of: int, long

Note: Providing complete information in the most concise form is the best way to get help. This issue template serves as the checklist for essential information to most of the technical issues and bug reports. For non-technical issues and feature requests, feel free to present the information in what you believe is the best form.
For Q & A and discussion, please start a discussion thread at https://discuss.mxnet.io
Description
I am trying to convert a very simple image classification model from MXNet to ONNX and I get the error below:
TypeError                                 Traceback (most recent call last)
 in ()
----> 1 converted_model_path = onnx_mxnet.export_model(sym, params, [input_shape], np.float32, onnx_file)
~/anaconda3/envs/mxnet_p36/lib/python3.6/site-packages/mxnet/contrib/onnx/mx2onnx/export_model.py in export_model(sym, params, input_shape, input_type, onnx_file_path, verbose)
81         onnx_graph = converter.create_onnx_graph_proto(sym_obj, params_obj, input_shape,
82                                                        mapping.NP_TYPE_TO_TENSOR_TYPE[data_format],
---> 83                                                        verbose=verbose)
84     elif isinstance(sym, symbol.Symbol) and isinstance(params, dict):
85         onnx_graph = converter.create_onnx_graph_proto(sym, params, input_shape,
~/anaconda3/envs/mxnet_p36/lib/python3.6/site-packages/mxnet/contrib/onnx/mx2onnx/export_onnx.py in create_onnx_graph_proto(self, sym, params, in_shape, in_type, verbose)
251                     initializer=initializer,
252                     index_lookup=index_lookup,
--> 253                     idx=idx
254                 )
255
~/anaconda3/envs/mxnet_p36/lib/python3.6/site-packages/mxnet/contrib/onnx/mx2onnx/export_onnx.py in convert_layer(node, **kwargs)
90             raise AttributeError("No conversion function registered for op type %s yet." % op)
91         convert_func = MXNetGraph.registry_[op]
---> 92         return convert_func(node, **kwargs)
93
94     @staticmethod
~/anaconda3/envs/mxnet_p36/lib/python3.6/site-packages/mxnet/contrib/onnx/mx2onnx/_op_translations.py in convert_weights_and_inputs(node, **kwargs)
180                 dims=dims,
181                 vals=np_arr.flatten().tolist(),
--> 182                 raw=False,
183             )
184         )
~/anaconda3/envs/mxnet_p36/lib/python3.6/site-packages/onnx/helper.py in make_tensor(name, data_type, dims, vals, raw)
171         field = mapping.STORAGE_TENSOR_TYPE_TO_FIELD[
172             mapping.TENSOR_TYPE_TO_STORAGE_TENSOR_TYPE[data_type]]
--> 173         getattr(tensor, field).extend(vals)
174
175     tensor.dims.extend(dims)
TypeError: -0.034149169921875 has type float, but expected one of: int, long
Environment info (Required)
MXNet 1.4
ONNX 1.11.0
Linux env.
What to do:

Download the diagnosis script from https://raw.githubusercontent.com/apache/incubator-mxnet/master/tools/diagnose.py
Run the script using python diagnose.py and paste its output here.

Arch         : ('64bit', '')
------------Pip Info-----------
Version      : 10.0.1
Directory    : /home/ec2-user/anaconda3/envs/amazonei_mxnet_p36/lib/python3.6/site-packages/pip
----------MXNet Info-----------
Version      : 1.4.0
Directory    : /home/ec2-user/anaconda3/envs/amazonei_mxnet_p36/lib/python3.6/site-packages/mxnet
Commit Hash   : b5811362951
----------System Info----------
Platform     : Linux-4.14.123-86.109.amzn1.x86_64-x86_64-with-glibc2.9
system       : Linux
node         : ip-172-16-191-155
release      : 4.14.123-86.109.amzn1.x86_64
version      : #1 SMP Mon Jun 10 19:44:53 UTC 2019
----------Hardware Info----------
machine      : x86_64
processor    : x86_64
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                2
On-line CPU(s) list:   0,1
Thread(s) per core:    1
Core(s) per socket:    2
Socket(s):             1
NUMA node(s):          1
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 79
Model name:            Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz
Stepping:              1
CPU MHz:               2299.814
BogoMIPS:              4600.06
Hypervisor vendor:     Xen
Virtualization type:   full
L1d cache:             32K
L1i cache:             32K
L2 cache:              256K
L3 cache:              46080K
NUMA node0 CPU(s):     0,1
----------Network Test----------
Setting timeout: 10
Timing for MXNet: https://github.com/apache/incubator-mxnet, DNS: 0.0024 sec, LOAD: 0.4924 sec.
Timing for Gluon Tutorial(en): http://gluon.mxnet.io, DNS: 0.1753 sec, LOAD: 0.4681 sec.
Timing for Gluon Tutorial(cn): https://zh.gluon.ai, DNS: 0.2536 sec, LOAD: 0.4653 sec.
Timing for FashionMNIST: https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/gluon/dataset/fashion-mnist/train-labels-idx1-ubyte.gz, DNS: 0.0282 sec, LOAD: 0.5889 sec.
Timing for PYPI: https://pypi.python.org/pypi/pip, DNS: 0.0055 sec, LOAD: 0.1260 sec.
Timing for Conda: https://repo.continuum.io/pkgs/free/, DNS: 0.0035 sec, LOAD: 0.0306 sec.
Package used (Python/R/Scala/Julia):
(I'm using  Python)
Build info (Required if built from source)
Compiler (gcc/clang/mingw/visual studio):
Jupyter Notebook
MXNet commit hash:
(Paste the output of git rev-parse HEAD here.)
Build config:
(Paste the content of config.mk, or the build command.)
Error Message:
(Paste the complete error message, including stack trace.)
Minimum reproducible example
(If you are using your own code, please provide a short script that reproduces the error. Otherwise, please provide link to the existing example.)
I trained a model by following the notebook below:
https://github.com/awslabs/amazon-sagemaker-examples/blob/master/introduction_to_amazon_algorithms/imageclassification_caltech/Image-classification-transfer-learning-highlevel.ipynb
Steps to reproduce
(Paste the commands you ran that produced the error.)

Train a model in the notebook above.
Run the code below on the model artifacts
converted_model_path = onnx_mxnet.export_model(sym, params, [input_shape], np.float32, onnx_file)

What have you tried to solve it?

@mxnet-label-bot add [Bug, ONNX]

@wmlba Could you share the symbol and params file of the trained model?


appDev readme update

appDev readme update

I have read the CLA Document and I hereby sign the CLA

recheck


How to turn off log printing

Hi,I don't want to print these logs in console, is there something that can be done

enableLog to false inside GetmaterialApp

I have enableLog: false in my GetMaterialApp declaration and the logs still show. I'm on GetX 4.6.5.

I have enableLog: false in my GetMaterialApp declaration and the logs still show. I'm on GetX 4.6.5.

Me too.

Just to offer a workaround: Get.isLogEnable = false; seemed to work for me (not using a GetMaterialApp though).

is there a specific point where i need to put Get.isLogEnable = false;? i found it didn't work for me putting before the GetMaterialApp or putting before i runApp (right before i initialize with Get.put).

@matthewkooshad I had placed it early. The app had a main -> runZonedGuarded -> runApp flow. I did put the Get.isLogEnable = false; into the runZonedGuarded function, a bit before runApp. So that was after WidgetsFlutterBinding.ensureInitialized(); initializing Firebase and EasyLocalization and such, but before a first Get.put() and before runApp.
But that app did not use GetMaterialApp, so it is possible it won't work for you.


MessagingException::errors() does not really return string[]

Describe the bug
MessagingException or the classes that inherit it (NotFound, InvalidMessage, etc) have errrors property which by php doc should be a string[]. But that is not true. An example:
array(1) {
	["error"]=>
	array(4) {
		["code"]=>
		int(404)
		["message"]=>
		string(31) "Requested entity was notfound."
		["status"]=>
		string(9) "NOT_FOUND"
		["details"]=>
		array(1) {
			[0]=>
			array(2) {
				["@type"]=>
				string(51) "type.googleapis.com/google.firebase.fcm.v1.FcmError"
				["errorCode"]=>
				string(12) "UNREGISTERED"
			}
		}
	}
}

To Reproduce
Send for example a push notifications with and old (unregistered) puth token to firebase api.
Expected behavior
I would expect more detailed errors structure or an property named $originalError which would be simply of type array, not string[].
Environment (please complete the following information):

OS: eny
PHP version: 7.4.7
Firebase SDK Version: 5.10.0

The PHPDoc is fixed with https://github.com/kreait/firebase-php/commit/e613798df618c666d586135be7dea51b46ee38f4, thanks for the notice!


Availability on conga-forge

Dear @javiber,
Thanks a lot for this repo!
Is there any chance you can make it available on conda-forge?

Hi @ilyanoskov,
I'm sorry for not getting back to you sooner, I hadn't turned on the notifications for this repo yet.
I don't have much experience publishing to conda and poetry refuses to support it so this probably will not be implemented any time soon unfortunately.
I'm open to any contribution that can make this possible though.
Cheers


python web app tutorial is inaccurate

https://docs.microsoft.com/en-us/azure/app-service/app-service-web-get-started-python tells me to modify main.py but this file doesn't exist. There is only hostingstart-python.py. Also, I'm familiar with Flask web apps but this sample code doesn't look anything like a regular Flask app. I'm confused...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ac1cd213-5a9f-ae10-73b5-96061bfbd9d9
Version Independent ID: cec78ca0-f4c0-970e-dde0-44db72d3819f
Content: Create a Python web app in Azure
Content Source: articles/app-service/app-service-web-get-started-python.md
Service: app-service-web
GitHub Login: @cephalin
Microsoft Alias: cephalin;cfowler

@rajrsingh Thanks for the feedback! We are currently investigating and will update you shortly.

@rajrsingh You are asked to download the project files at the start of the session by using the below bash command in a git cmd window.
git clone https://github.com/Azure-Samples/python-docs-hello-world
I am able to see the main.py file after running the above command.

In the main.py file, the below flask python code is included, which is a simple hello world app. Please note the commands included in the doc are a mixture of Git bash and Azure CLI, which are management commands meant to get the web app, and deployment credentials up and running.
`from flask import Flask
app = Flask(name)
@app.route('/')
def hello_world():
return 'Hello, World!'
if name == 'main':
app.run()
`
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and tag me in your reply. We will gladly continue the discussion.

Hi there!
Thanks for this tutorial.
In web.2.7.config file, line 6:
D:\home\site\wwwroot\env\Scripts\activate_this.py
File web.3.4.config, line 4:
value="D:\home\site\wwwroot\env\Scripts\python.exe" />
I do not think this file exist anywhere on our Azure account?
Please advice.
Thanks
Dean


webextension-polyfill support

Has anyone managed to use this package with webextension-polyfill ?

This package doesn't use the browser.* API provided by the polyfill, but rather the chrome.* API natively provided by Chrome and all WebExtension-compliant browsers. It won't matter whether you use the polyfill or not.

Thanks for the quick reply.
BTW, any idea why the store might not work on firefox?
I have an options page that stores some data that is read from the popup page, and it works fine on Chrome but not Firefox.
After reading about the option storageArea I thought maybe passing browser.storage.sync would do the trick, if there were some logic detecting what kind of storage is being used, and would also make the store work on Safari.


EditorInterface.new().get_current_directory() Doesn't work after godot4-beta14

Godot version
godot4-beta14
System information
Ubuntu 22.04.1 LTS
Issue description
In godot4-beta14 EditorInterface.new().get_current_directory() does not work and this error message gets generated:
Native class "EditorInterface" cannot be constructed as it is abstract.
Static function "new()" not found in base "EditorInterface".

If I try to use it like EditorInterface.get_current_directory(), this error message gets generated:
Cannot call non-static function "get_current_directory()" on the class "EditorInterface" directly. Make an instance instead.

This is a loop and makes get_current_directory() method unusable.
Steps to reproduce

Just make a Scene and add a node.
Attach a script to it.
Paste current content into it:

func _ready() -> void:
	EditorInterface.new().get_current_directory()

Run the scene.

Minimal reproduction project
It doesn't really need any reproduction project, the case is obvious.

Please check the documentation for EditorInterface: https://docs.godotengine.org/en/latest/classes/class_editorinterface.html

Note: This class shouldn't be instantiated directly. Instead, access the singleton using EditorPlugin.get_editor_interface.

That does not work too.
EditorPlugin.get_editor_interface().get_current_directory()

Returns this error:
Cannot call non-static function "get_editor_interface()" on the class "EditorPlugin" directly. Make an instance instead.

You should have a script that extends EditorPlugin (i.e. an instance of EditorPlugin), and from it you call get_editor_interface() to have the singleton instance.
It's like any non static methods, you can't call Node.get_node() directly but if your script extends Node, you can use get_node().

Thanks. 🙏


[WIP] client->server streaming

basic protocol
C --> invocation(target:"SaveFile", streamingUpload:true) --> S
// server builds a single hub instance
C --> chunk1 --> S --> hub
C --> chunk2 --> S --> hub
C --> chunk3 --> S --> hub
C --> streamComplete --> S --> hub
// the same hub instance aggregates the chunks, does final processing, and returns result
C <-- invocationComplete <-- S <-- hub

Example code users would write is in the sample files.
Changes to existing protocol:

Invocation now has a streamingUpload flag, which indicates that the server should keep the hub open, and route all following StreamItems with the same invocation id to that hub.
New message streamComplete, which the client sends to indicate that all stream items have been sent, and that the server should now return a value.

This broke lots of stuff sorry.

I want to set some context on this for the other reviewers: This is a WIP PR to start discussing the protocol changes. We'll need to iterate on that a bunch before merging. In the meantime @DylanDmitri is working on getting this working end-to-end in a prototype form. We may just end up closing this PR, cleaning it up and reissuing one.
So comment away, but I just wanted to set the right context for this discussion :)

Most functionality is in and tested.
Still todo ::

Parsed errors

Big refactoring that's needed -- make the upload stream part more modular.
There's currently three "paths" through the whole process. All involve the client sending an invocation message to the server.

SendAsync Expects no response. Sends an InvocationMessage without an InvocationId.
InvokeAsync Expects one response. Sends an InvocationMessage with an InvocationId, and the id is included in the reponse.
StreamAsChannelAsync Function call returns a channel; multiple stream items are written to this channel. Sends a StreamInvocationMessage with an id.

Currently, this streaming upload code applies only to the InvokeAsync branch. If one of the parameters passed to invoke async is a ChannelReader, an InvocationMessage is sent with a flag set to true. On the server, another channel reader is constructed and passed to user code.
The refactoring would make the streaming upload code more general, so that users can pass a ChannelReader through all three kinds of requests (SendAsync, InvokeAsync, and StreamAsChannelAsync).

New plan for the streaming upload protocol. Rather than track and route upload channels by invocationId, we introduce a new channel id.

On generating an InvocationMessage, for each channel reader parameter the client

generates an id
replaces the channel reader with a placeholder string like "channel id=43"

The server, on receiving a message, can see that the target hub method takes channel readers as parameters. For each channel reader parameter in the method, the server looks at the corresponding received placeholder string, and

verifies it has the correct format
reads the id
creates a new channel
stores the writer in the _channelStore under the given id
passes the reader through to the hubmethod

This solves three problems at once

clarifies what the placeholder should look like
allows a way to route StreamItems to SendAsync invocations, even without an invocationId to go off of
allows multiple channel readers to be passed through a single invocation

replaces the channel reader with a placeholder string like "channel id=43"

I like it, but let's use a JSON object. I don't like mangling strings here :). Something like { "_streamId": 43 }

stores the writer in the _channelStore under the given id

Is the _channelStore on HubConnectionHandler or HubConnectionContext? If it's on the former, it's global to the whole server, so we can't rely on client-generated IDs for uniqueness.

Currently, the client sends a single string, which is used as the channel id. If there's a need to communicate additional variables (maybe channel type/size, stream direction, etc) then it makes sense to transition to a JSON object.
Currently, the _channelStore is on the DefaultHubDispatcher, because that's where it's used. This may be a bad location. Each client is currently generating and sending stringified GUIDs, which has other downsides but there's no risk of collision.

No conflicts now 😄

On further consideration, removing the hasStream flag from InvocationMessage. The new StreamPlaceholder serialization/deserialization makes the flag effectively redundant.

@DylanDmitri @anurse I'd like to do a design review of this before merging.

@dotnet-bot test Windows Release Spanish Language x64 Build please


Socratic Seminar 07 (2024-03-30) Topic Collection

Please comment with a link to topics you want to share or discuss on our next BitDevs meetup.
@okjodom and @munjesi are looking to host this on the 30th of March, 2024

We haven't had any discussion on mining or the protocols involved in mining. I think StratumV2 would be a great way to kick this off!

Please comment with a link to topics you want to share or discuss on our next BitDevs meetup.
@okjodom and @munjesi are looking to host this on the 30th of March, 2024

We haven't had any discussion on mining or the protocols involved in mining. I think StratumV2 would be a great way to kick this off!

Fair enough. However, I'd want us to have (built) stronger mining expertise before we dig into the protocols, development and current application of SV2

We haven't had any discussion on mining or the protocols involved in mining. I think StratumV2 would be a great way to kick this off!

Fair enough. However, I'd want us to have (built) stronger mining expertise before we dig into the protocols, development and current application of SV2

Sounds good, what do you have in mind?

nACK


doesnt download anything, just stayed on "processing...".

it does the same in incognito, and after i've cleared cookies and cache. have removed and reinstalled code but still does the same. :[
[some things edited out bcoz privacyyy]
was trying to dl this score >> https://musescore.com/user/35272338/scores/6460635

There is a dedicated channel on Discord to post those missing scores

added https://ipfs.io/ipfs/QmZfSPmw9Pp1W3giGbwDNxgyujaVmoe7bt4ZP488BNErhn


Dependencies and settings update

This PR updates the dependencies to their latest (and compatible) versions. These are not the final dependencies, so in a future the list can be changed.

@kiroco12 Are the errors in Travis expected?

@vejeta yes, are expected. There isn't any code modifications so it won't compile


chore: update example projects

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b033004) 93.85% compared to head (a95837b) 93.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1153   +/-   ##
=======================================
  Coverage   93.85%   93.85%
=======================================
  Files          53       53
  Lines        3433     3433
  Branches      476      476
=======================================
  Hits         3222     3222
  Misses        211      211

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(templates/vercel): add $schema in vercel config file

Vercel recently added support for $schema in the vercel.json to enable autocompletion and valdiation of the config file.
This PR add the $schema to the Vercel template.

@xstevenyung The file have moved to templates/vercel/vercel.json, would you mind redoing your PR?

@xstevenyung The file have moved to templates/vercel/vercel.json, would you mind redoing your PR?

can you also update templates/vercel-ts/vercel.json 😄

Updated, thanks for the heads up !

thanks @xstevenyung! Vercel recently introduced a "builder" so this file shouldn't be necessary anymore


Minimal code changes

Most of all, I made the code more readable in some code structures, for the user and the team, and some reuse of lines.

Hello! Thanks for your contribution.
I saw that you removed the print_start function in pysgi/_print.py, it serves to inform which host and port the server is running on. Also, the print_start function call is still present in pysgi/wsgi.py, in the PySGI.run() method.
If you have any reason for this, please leave a comment so we can discuss it. Other than that, everything is fine! Please re-add the function and resubmit your pull request.

Perdón me había liado, ni me había dado cuenta que lo había eliminado, perdón por mi fallo (~y por mi edit~), aunque solo seria agregarlo si así lo desea

All very well! Thanks for your contributions, I hope to receive more of your help in my projects!


Adding saml2 support backport to Stable/quincy

trying to backport "Adding saml2 support" to quincy

I'm not sure I should try to backport only c692f23

https://paste.ubuntu.com/p/3xwWdpCQhk/
@UtkarshBhatthere I uploaded test, the first one is with current quincy. the next one is with patched one.

Thanks for the test output @xtrusia. I will approve this backport PR.


Backfill Cost Thresholds for existing teams in Developer CoP

Describe the issue
Several teams are operating already and they may not have cost threshold automation.
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context
Add any other context, attachments or screenshots
Definition of done

Organize Dev CoP meeting
Get each financial threshold info from MoU docs
apply the cost thresholds per formula in 952 on each team

Closing this ticket as detailed discussion was had at developer CoP and teams are exploring budget-related capabilities with our support.


Improve better types

References [link the ticket here]
Motivation and context
[Describe the problem we're solving and lay out the solution]
Before
[Describe the current behavior and / or add a screenshot of the current state]
After
[Describe the new behavior and / or add a screenshot of the new state]
How to test
[Add a deep link and instructions how to verify the new behavior]

Thanks so much for the help! It was awesome. The other PR is merged so we can close this one.


UI | Full Table name is not displayed on the Table Home Page

Affected module
Does it impact the UI, backend or Ingestion Framework?
UI
Describe the bug
A clear and concise description of what the bug is.
Full Table name is not displayed on the Table Home Page
To Reproduce

Have table with a long name

Screenshots or steps to reproduce

Expected behavior
A clear and concise description of what you expected to happen.
Display the full Table name, at-least upon Hover
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: [e.g. 0.8]: 0.11.5
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.

+1 for showing the full table name upon hover. @sidhreddy thank you for reporting this and welcome back. It's been a long time!


Adds a Maven Exec plugin to the samples

Motivation and Context

Adds a Maven Exec plugin so it's easier to execute a sample from the command line with a mvn exec:java command.
Description

The Maven Exec plugin allows to run a sample from the command line with a single Maven command. The only issue for now, is that the configuration files are hard coded in samples/sample-code/src/main/java/com/microsoft/semantickernel/Config.java
    public static final String OPEN_AI_CONF_PROPERTIES = "samples/java/semantickernel-samples/conf.openai.properties";
    public static final String AZURE_CONF_PROPERTIES = "samples/java/semantickernel-samples/conf.azure.properties";

I didn't want to do any refactoring, so I'm leaving these property files as they are. But for the Maven exec plugin to work, I update manually the content of the AZURE_CONF_PROPERTIES. But I assume these properties will change and we will update the Maven exec plugin accordingly.
Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
[ ] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with dotnet format
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

@agoncal any chance you can rebase your branch so that it doesn't bring changes that are already in?

I am going to close this in favour of #1850 that adds maven exec


cveUser and cvePass for dependency-check.sh CLI

Hello,
I'm working on a mirror of NVD database in a JFrog/Artifactory artifactory repo which requires authorisation.
I have set the --cveUrlBase and --cveUrlModified correctly but there seems to be no way to set the username and password when using the CLI client.
In the Maven dependency check there is  and  setting.
Is there any way of setting these for the CLI client?
Thank you and Merry Christmas.

Sorry about the missing arguments. You can create a properties file with:
cve.user=user
cve.password=pass

Then include the properties using the --propertyfile custom.properties in the CLI.

While the CLI argument is being added in the next release - I would recommend continuing to use the properties file to avoid storing credentials in the history...

While the CLI argument is being added in the next release - I would recommend continuing to use the properties file to avoid storing credentials in the history...

Awesome thank you @jeremylong do you have a link I can use to buy you a coffee/beer?

Awesome thank you @jeremylong do you have a link I can use to buy you a coffee/beer?

@rjpearce only thing I have setup is GH sponsors: https://github.com/sponsors/jeremylong

@rjpearce only thing I have setup is GH sponsors: https://github.com/sponsors/jeremylong

Thanks. @jeremylong I haven't been able to get it working using the properties file.
In the log output I can see the username and password being set:

Thanks. @jeremylong I haven't been able to get it working using the properties file.
In the log output I can see the username and password being set:

The CVE creds are used in two places:
https://github.com/jeremylong/DependencyCheck/blob/41ae5d5fcf9ff7c97f852e5069302813b4ce996e/core/src/main/java/org/owasp/dependencycheck/data/update/nvd/DownloadTask.java#L128
https://github.com/jeremylong/DependencyCheck/blob/52c689c635ca301145796c4f3abdbf385e1f3027/core/src/main/java/org/owasp/dependencycheck/data/update/NvdCveUpdater.java#L340
From there you can trace into the Downloader and eventually end up at:
https://github.com/jeremylong/DependencyCheck/blob/52c689c635ca301145796c4f3abdbf385e1f3027/utils/src/main/java/org/owasp/dependencycheck/utils/HttpResourceConnection.java#L202-L204
Which then calls:
https://github.com/jeremylong/DependencyCheck/blob/52c689c635ca301145796c4f3abdbf385e1f3027/utils/src/main/java/org/owasp/dependencycheck/utils/URLConnectionFactory.java#L161-L173

The CVE creds are used in two places:
https://github.com/jeremylong/DependencyCheck/blob/41ae5d5fcf9ff7c97f852e5069302813b4ce996e/core/src/main/java/org/owasp/dependencycheck/data/update/nvd/DownloadTask.java#L128
https://github.com/jeremylong/DependencyCheck/blob/52c689c635ca301145796c4f3abdbf385e1f3027/core/src/main/java/org/owasp/dependencycheck/data/update/NvdCveUpdater.java#L340
From there you can trace into the Downloader and eventually end up at:
https://github.com/jeremylong/DependencyCheck/blob/52c689c635ca301145796c4f3abdbf385e1f3027/utils/src/main/java/org/owasp/dependencycheck/utils/HttpResourceConnection.java#L202-L204
Which then calls:
https://github.com/jeremylong/DependencyCheck/blob/52c689c635ca301145796c4f3abdbf385e1f3027/utils/src/main/java/org/owasp/dependencycheck/utils/URLConnectionFactory.java#L161-L173

@rjpearce with the recent release - are you still having issues with the basic auth?

@rjpearce with the recent release - are you still having issues with the basic auth?

Hi Jeremy,
Thank you, Sorry for the slow response.
I have run a quick re-test with 6.0.5 using the new command line args for cveUser/cvePass and everything is working as expected.
We ended up not using Artifactory for our solution. We switched to a very simple solution by building a Docker container based on owasp/dependency-check that has runs dependency-check with --updateonly. This leverage depdency-checks functionalit to cache NVD data to build a daily docker image. We then tag it and consume the image.
Below is the code I used to ascertain auth sanity:
Source info: https://hub.docker.com/r/owasp/dependency-check
docker pull owasp/dependency-check:$DC_VERSION docker run --rm \     -e user=$USER \     -u $(id -u ${USER}):$(id -g ${USER}) \     --volume $(pwd):/src:z \     --volume "$DATA_DIRECTORY":/usr/share/dependency-check/data:z \     --volume $(pwd)/odc-reports:/report:z \     owasp/dependency-check:$DC_VERSION \     --scan /src \     --format "ALL" \     --project "$DC_PROJECT" \     --cveUser 'foo' \     --cvePassword 'secret' \     --cveUrlBase http://host.docker.internal:8000/nvdcve-1.1-%d.json.gz \     --cveUrlModified http://host.docker.internal:8000/nvdcve-1.1-modified.json.gz \     --out /report
A simple web server
`import http.server
import socketserver
import base64
class GetHandler(http.server.SimpleHTTPRequestHandler):
def do_GET(self):
expected_auth = b'Basic ' + base64.b64encode('{}:{}'.format('foo', 'secret').encode('ascii'))
actual_auth = self.headers.get('Authorization', '').encode('ascii')
if expected_auth == actual_auth:
print('Credentials valid')
else:
print('Credentials invalid')
print('Headers -------')
print(self.headers)
print('--------')
http.server.SimpleHTTPRequestHandler.do_GET(self)
PORT = 8000
Handler = GetHandler
with socketserver.TCPServer(("", PORT), Handler) as httpd:
print("Listening on port", PORT)
httpd.serve_forever()
`
Listening on port 8000
Credentials valid
Headers -------
Authorization: Basic Zm9vOnNlY3JldA==
Accept-Encoding: gzip, deflate
User-Agent: Java/14.0.2
Host: host.docker.internal:8000
Accept: text/html, image/gif, image/jpeg, *; q=.2, /; q=.2
Connection: keep-alive

Hi Jeremy,
Thank you, Sorry for the slow response.
I have run a quick re-test with 6.0.5 using the new command line args for cveUser/cvePass and everything is working as expected.
We ended up not using Artifactory for our solution. We switched to a very simple solution by building a Docker container based on owasp/dependency-check that has runs dependency-check with --updateonly. This leverage depdency-checks functionalit to cache NVD data to build a daily docker image. We then tag it and consume the image.


beaker icon for test is not shown

ADD ISSUE DESCRIPTION HERE
Version: 1.66.2
Commit: unknown
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/101.0.4951.67 Safari/537.36
Embedder: server-distro

To clarify is the beaker icon from an extension?

/duplicate of #148795

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

See https://code.visualstudio.com/docs/python/testing#_configure-tests for Python (including screenshot showing beaker) and https://code.visualstudio.com/api/extension-guides/testing for details for extension developers.


Build binomial tree that grows towards strike at maturity

Ideally do this in python and analyse convergence speed, i.e. contingent on #9

Numerically more stable and convergences faster if the mid point of the tree hits the strike at maturity - this is especially important for discontinuous payoffs, e.g. digitals


Cannot read properties of undefined (reading 'position')

Hi, thank you for your fork
However, I got the following error when trying it
TypeError: Cannot read properties of undefined (reading 'position')
    at eval (plugin:time-block-planner:3412:49)
    at Array.filter (<anonymous>)
    at parsePlanItems (plugin:time-block-planner:3407:78)
    at DayPlanner.getPlanItems (plugin:time-block-planner:3719:12)
    at async DayPlanner.updateUI (plugin:time-block-planner:3658:27)
    at async DayPlanner.updateStatusBarOnFailed (plugin:time-block-planner:3709:7)

It seems that in the parser.parsePlanItems function , the following code was used
  const listItemsUnderPlan = metadata.listItems?.filter((li) => {
    const isBelowPlan =
      li.position.start.line > planHeading.position.start.line;

    if (isBelowPlan && !nextHeading) {
      return true;
    }

    return li.position.start.line < nextHeading.position.start.line;
  });

And according to the docs, it doesn't have such position property
Plugin version 0.1.1
Obsidian version 1.4.2
Hope this helps

Hello, @qazxcdswe123!
Thank you for the input! Please share the daily plan file that gives you the error + the plugin config file (<your-vault>/.obsidian/plugins/time-block-planner/data.json.

{
  "mode": "DAILY",
  "completePastItems": true,
  "circularProgress": false,
  "nowAndNextInStatusBar": false,
  "showTaskNotification": false,
  "timelineZoomLevel": "2",
  "timelineIcon": "calendar-with-checkmark",
  "breakLabel": "BREAK",
  "endLabel": "END",
  "startHour": 6,
  "timelineDateFormat": "LLLL",
  "centerNeedle": true,
  "plannerHeading": "Day planner",
  "plannerHeadingLevel": 2
}

The content of the daily plan file is one the left side of the picture

@qazxcdswe123 please update the plugin and re-check.

Oh it works now, thankyou


docs: Add Azure File Storage Volume Driver plugin

Adds Azure File Storage volume driver that we have out there for a while to Docker docs.
Signed-off-by: Ahmet Alp Balkan

Haha, how could I forget you?
one nit, but LGTM otherwise

@thaJeztah fixed.

LGTM, thanks @ahmetalpbalkan


Migrate to AtomLinter organization?

@smockle Would you be interested in moving this to the AtomLinter org? You would still have admin rights on the repo, but would gain the help of others working on improving the code if necessary and helping with issues.
If you are interested contact myself or @steelbrain on Atom's Slack instance.

@Arcanemagus I’m very interested in that, thank you! I’ll join the Slack instance.

Done! :tada:

:tada: :tada: :tada:


don't warn "no interpreter found" for Shared ELF objects.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

We don't wish to print "no interpreter found" when the object is a shared library
@sjackman

We don't wish to print "no interpreter found" when the object is a shared library

Why not? Can we avoid running the method that prints this exception?

Why not? Can we avoid running the method that prints this exception?

i have no objection,  have to  talk to @sjackman .

@MikeMcQuaid It's a shortcoming in the API of PatchELF::Patcher. The only way to test whether an ELF has an interpreter is to call PatchELF::Patcher::interpreter and catch an exception when it has no interpreter. It'd be a better API design IMO for interpreter to return nil` when there is no interpreter.  https://www.rubydoc.info/github/david942j/patchelf.rb/PatchELF/Patcher#interpreter-instance_method

I'm going to approve and merge this PR as is, because it's strictly better than the status quo. A refactoring is needed though. I'll comment in a sec.

@rmNULL Please open a PR to factor out ELFShim::interpreter that returns nil when there is no interpreter.
Please change keg_relocate.rb to use this new function.
https://github.com/Homebrew/brew/blob/2e05306b06a0251597b8b3db54106f5189124124/Library/Homebrew/extend/os/linux/keg_relocate.rb#L44-L45
Please remove with_interpreter? after verifying there are no callers to this function.


Fix WORKDIR change in contrib plain_single_backend_deployment

Hey, I just made a Pull Request!

Following the changes done in the Backend Dockerfile and the change of WORKDIR to /app, the container wasn't starting anymore because it couldn't find the k8s-config.yaml config file.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

Tugboat has finished building the preview for this pull request!
Link:

https://pr4676-h6lwvgp7wb4vyxtiljoxlbzvk2hkzwov.tugboat.qa

Dashboard:

https://dashboard.tugboat.qa/603636f265f8176a0ef8daa4


feat: graceful shutdown

Description
added graceful shutdown
Changes
src/relay/mod.rs, src/relay/federation/mod.rs, src/events/mod.rs files
Related Issues
issue#203
Checklist

[ ] Tests included
[x] Build pass
[ ] Documentation
[x] Code format and docstring

i wonder why there are a lot of clippy warning but the clippy github actions still green.


Changes campaign_country to campaign_language

Fixes #19
Change parameter campaign_country to campaign_language for POST /campaign/signup`.
Supports having campaigns in various languages independent of the country the campaign is from.

:+1:


Open-VSX version not being updated (stuck at 1.3.14 while Marketplace is at 1.4.1)

Hi,
Can you please look into why there have been no updates lately at https://open-vsx.org/extension/Vue/volar?
Thank you.

Updated, thanks for letting me know.


Visiting the page is not possible from edit mode

If you press the visit page button in page edit mode an 404 error appears:
http://test.alchemy-cms.com/admin/pages/6/visit

I cant reconstruct this issue. Its working for me without any problems.
Do you notice this problem on every page, or just on certain pages?

This was on the old http://new.magiclabs.de page. After removing the subdomain ;) . Closing this issue


Update DG to include manual testing instructions and refactor sequence diagrams

Add manual testing instructions for undo and redo commands
Refactor sequence diagrams for UndoSequenceDiagram-Logic and UndoSequenceDiagram-Model

Documentation looks good, but the error messages for undo and redo lack punctuation, ties in with issue #133

Oh right good catch, I'll get those punctuation inconsistencies sorted out.


web-grpc client (non-WASM) from Rust.

Feature Request
Crates
tonic-web
Motivation
We recently managed to make AWS Lambda gRPC compatible thanks to tonic and tonic-web.
There is however currently no way to call those from pure Rust clients, as they require HTTP2 and the whole thing we did expects gRPC web.
Proposal
Not sure exactly. I'd like to implement that, but I'd really appreciate some guidance as to what is the best way to proceed.
If you agree such a feature is indeed desirable, could you give me a hint on how to implement it?
Thanks!
Alternatives
Not really. Perhaps I missed something.

Well, I finally managed to implement something that works well.
But, as I suspect - given the lack of reaction until now - there is no real interest in supporting that in tonic-web, I won't bother trying to make it match the current library standards.
Let me know if that ever changes.

Any information about how you did this?

@john-h-k Our startup was eventually closed but all our code was open-source.
I think you'll find what you are looking for here: https://github.com/legion-labs/legion/blob/main/crates/lgn-online/src/grpc/web/client.rs
Disclaimer: it is probably not the best Rust code around: we had just started learning Rust. Still, it did work. I had to read on a whole of cryptic gRPC documentation.
Our resulting code would wrap a regular HTTP 1.1 endpoint and fake an HTTP2 content (on both the way in and the way out) as to satisfy tonic's requirements.
The main limitation, from what I recall, is that since gRPC/web can't benefit from server pipelining, you can't support streaming requests.
It's been a while since I wrote this so sorry if I can't give out more detailed information. Hopefully that still helps.

This now exists via https://github.com/hyperium/tonic/pull/1472


Colour beads by predominant (?) region of sampling

> hcl(seq(0, 300, length.out=7))
[1] "#FFC5D0" "#F0CFAF" "#CCDAA9" "#A4E2C3" "#9CE0E6" "#C2D5FB"
[7] "#EDC8F5"

Region
RGB

Africa
#FFC5D0

Asia
#F0CFAF

China
#CCDAA9

Europe
#A4E2C3

North America
#9CE0E6

Oceania
#C2D5FB

South America
#EDC8F5

Switched North America and Australia - large amounts of pink wasn't that attractive

Need colour legend - where is this going to go?


report empty legacy passphrase as no passphrase

Issue Number

#1483
Overview

678f595e8e3b6d14044a0d21e623b4f55b73a7e2
:round_pushpin: report empty legacy passphrase as no passphrase
Legacy wallets imported through via XPrv might have an empty passphrase set. The passphrase is empty from a client perspective, but in practice it still exists (it is a CBOR-serialized empty bytestring!).
Therefore, if we detect an empty passphrase, we chose to return the metadata as if no passphrase was set, so that clients can act in consequences.

Comments

bors r+


[9.x] Add ability to discard Eloquent Model changes

Project::updating(function (Project $model) {
    /*
     * The project update should be a change request
     */
    $changeRequest = new ProjectChangeRequest([
        'original' => array_intersect_key($model->getRawOriginal(), $model->getDirty()),
        'changes' => $model->getDirty(),
    ]);

    $changeRequest->source_model()->associate($model);
    $changeRequest->save();

    // Now we can simply ignore all attribute changes and only save `status="change_request"`
    $model->discardChanges();

    $model->status = 'change_request';
});

Signed-off-by: Mior Muhammad Zaki<EMAIL_ADDRESS>

Seems almost same as this PR: https://github.com/laravel/framework/pull/37756

Hi!
Just curious about how is it different from refreshing models.

@amitmerchant1990
refresh() reloads the model data from the database. You do a database call, and can get attributes that might have changed from another requests in the meanwhile.
discardChanges() will, eh, discard any unsaved changes, and return the model to its original state, without performing a database call.


[macro lang] Design principle around handling of annotations and nulls

Now that you mention it, I feel icky about ignoring annotations.  That seems likely to lead to users of the macro being surprised by data-loss.
We could use a written-down design principle on this sort of thing, as well as related topics like handling of nulls (typed, untyped, and mis-typed).

Originally posted by @toddjonker in https://github.com/amazon-ion/ion-docs/pull/249#discussion_r1222278807
At very least, the system macros should be consistent.

The keys provided to make_struct are an interesting and subtle case.


convert bytefields in common to usable fields

Instead of having a handy way to quickly instantiate the various protocols in common as standalone bytefield,
lets make them fields, that can be used in other bytefields.
these fields may allow their internal fields to be overwritten via arguments
#bytefield(
  ip(
    data: tcp(
      dst_port: [80] // set internal field content
      src_port: bytes(2)[#box(width:100%,height:100%,fill:grey)[random]] //replace internal field
    )[
      GET ...
    ]
  )
)

Sounds like a good idea.
But maybe we can even support both versions like common.ipv4 just stays like it is and common.fields.ipv4 returns the field or something similar.
Happy to accept a PR if you like to implement this. Otherwise i put it on the list for future plans.


Lots of per frame allocations relating to use of string formatting

Looking at the Unity profiler I am seeing that Zenject is generating garbage per frame.
The biggest culprits are the two tickable handlers:
void UpdateTickable(ITickable tickable)
{
    // - Allocation for use of string formatting.
    // - Allocation for use of 'params' keyword (equivalent to new object[] { arg1, arg2 }).
    using (ProfileBlock.Start("{0}.Tick()".With(tickable.GetType().Name())))
    {
        tickable.Tick();
    }
}

Removing ProfileBlock avoids some of this garbage:
void UpdateTickable(ITickable tickable)
{
    tickable.Tick();
}

I propose that the above is changed to the following:
void UpdateTickable(ITickable tickable)
{
    // Allow `ProfileBlock.Start` to perform formatting when enabled.
    // Instead of accepting `params object[]` provide several overloads to
    // accept a fixed number of parameters.
    using (ProfileBlock.Start("{0}.Tick()", tickable.GetType().Name()))
    {
        tickable.Tick();
    }
}

For testing purposes I removed the ProfileBlock from these two functions and performance was instantly better.
TaskUpdater is another culprit of per frame allocations due to use of System.Linq there are internal allocations plus enumerator allocations.
Changing the following:
public void UpdateRange(int minPriority, int maxPriority)
{
    // Make sure that tasks with priority of int.MaxValue are updated when maxPriority is int.MaxValue
    foreach (var taskInfo in _sortedTasks.Where(x =>
        !x.IsRemoved && x.Priority >= minPriority && (maxPriority == int.MaxValue || x.Priority < maxPriority)))
    {
        Assert.That(taskInfo.Priority.HasValue);
        _updateFunc(taskInfo.Task);
    }

    ClearRemovedTasks(_sortedTasks);
}

to the following instantly helped to improve performance:
public void UpdateRange(int minPriority, int maxPriority)
{
    // Make sure that tasks with priority of int.MaxValue are updated when maxPriority is int.MaxValue
	foreach (var taskInfo in _sortedTasks)
	{
		if (!taskInfo.IsRemoved && taskInfo.Priority >= minPriority && (maxPriority == int.MaxValue || taskInfo.Priority < maxPriority))
		{
			Assert.That(taskInfo.Priority.HasValue);
			_updateFunc(taskInfo.Task);
		}
	}

    ClearRemovedTasks(_sortedTasks);
}

For some reason this foreach statement is also allocating an enumerator despite the fact that LinkedList<T> defines a struct enumerator.
Looking at the profiler there are several other places where Zenject is allocating per frame.

Removed OnGUI in UnityEventManager.  I think our allocations per frame should be zero now.

Awesome stuff, I will check it out!


UI issue: Back to top button

Describe the bug

A clear and concise description of what the bug is.
The button uses 2 images and it can be made more efficient.

To Reproduce

Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

A clear and concise description of what you expected to happen.

Possible solution

Describe the solution you thought of.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.You can also mention your system environment in which you are running it.

@tanishq-arya Go ahead with the issue. Happy learning:)

I have made something like this

Looking good! Just increase the radius of the circle if possible and then make a PR.


Reason mixer control does not work

Not reproducible. The CC messages from the Live mixer to the Reason mixer are not supposed to go through the Router. Use the MIDI Port "IAC (Live to Reason" to send the mixer CC messages directly to Reason. Make sure the automation overrides on the Reason mixer's faders are correctly configured to use the port "IAC (Live to Reason)", controllers #41 to #48 for channels 1 to 8.


Add a new predicate failure for non-matching withdrawals

Current predicate failure that checks whether withdrawal matches the amount in the reward account is totally misleading. It is reported as WithdrawalsNotInRewardsCERTS, which is also the predicate failure that is used for reporting non-existent reward accounts. We need to create proper predicate failure for that and also fix the name and refactor validateZeroRewards function, cause that is even more misleading.

This has been postponed until next era, unless we decide that we will have another intra-era hardfork that advances Conway era to PV11


Always read/write files using UTF-8 encoding

This is an attempt to fix the farm build issue: https://github.com/ambiata/eminence/pull/183
/cc @tmcgilchrist

:100: for always writing stuff in UTF-8, but why not use Data.Text.IO.{write,read}File?

@olorin as far as I can tell {write,read}File uses whatever the system encoding is (i.e. the LANG environment variable)

Yep, you're correct, I was misreading the docs. :shaved_ice:

It's failing for other reasons now, so I suppose that's classified as success.

Added a yak for this: https://github.com/ambiata/yak/issues/75


implicitly defining DEBUG mode in MessageColumnIO causes 80% performance overhead

parquet-column jar leverages slf4j and log4j as default logger, neglecting to define a log4j configuration, defaults to DEBUG log level.

public class MessageColumnIO extends GroupColumnIO {
  private static final Logger LOG = LoggerFactory.getLogger(MessageColumnIO.class);

  private static final boolean DEBUG = LOG.isDebugEnabled(); // <------
}

this "magic behavior" defaults parquet library to be in DEBUG mode, without any notification or warnings. Unfortunately, the RecordConsumerLoggingWrapper implementation generates 5x performance overhead in comparison to the MessageColumnIORecordConsumer implementation, causing a massive hit in performance and wasteful server utilization.

IMHO there are two things that could prevent such issue:

printing a message to STDOUT notifying about DEBUG mode being set to active.

defaulting to MessageColumnIORecordConsumer implementation, and waiting for explicit configuration to define DEBUG mode, and use RecordConsumerLoggingWrapper.

In the past 2 years, this issue probably cost my company 50,000$ in excessive cloud costs!

Reporter: Elad Yosifon
Note: This issue was originally created as PARQUET-2036. Please see the migration documentation for further details.

Gabor Szadovszky / @gszadovszky:
[~elad_yosifon], thanks for reporting this.
I am not sure I get the actual circumstances leading to getting to the DEBUG log level without an explicit configuration.
The "magic behavior" was implemented to allow JIT to remove the logging parts from the compiled code so it'll run faster. Without this static flag the code would at least check the log level at each value read/write even if the log level is much higher than DEBUG.
About your tips for preventing the issue. Do you think printing to the STDOUT would help? I think STDOUT is only checked in cases when there is an error. If you do not realize you have a performance impact you would not notice the message on STDOUT either. Meanwhile, if you start checking the logs it would be clear that the log level is DEBUG.
What do you mean by "waiting for explicit configuration"? I think isDebugEnabled should return the explicit configuration of the log level. parquet-mr uses SLF4J just to allow the users (other components) to specify a logging FW and configuration.


output window all gray

I recently got a new PC and installed everything fresh from latest installers, incl. Visual Studio 2022 Enterprise and VsColorOutput through the VS Extension manager.  Now all text in the output window is gray. What do I do to get the color coding to work?
... when I edit the VsColorOutput64 options field "Build Text" from the default gray to white, then the output text does indeed become white. But when I edit the field "Build Message" nothing changes in the output window.

@IngmarBitter, It seems that the right repository for the issue is vscoloroutput64.

Here is the same issue https://github.com/mike-ward/VSColorOutput/issues/139

is indeed the same as #139 and the same fix worked for me:
just delete  %AppData%/VSColorOutput64/vscoloroutput.json


Login after Logout does not work: unsafe deactivated widget's ancestor

Great Example, thank you for your work.
However, there is something that still does not seem to work correctly with your example code.
The following error happens repeatedly when doing the following steps:

start the app
enter username/password
press Login button  --> the LoginSuccessPage shows successfully !
press Logout button
enter username/password again
press Login button --> here the app freezes !!!!!

The following error message is shown:
Error: Looking up a deactivated widget's ancestor is unsafe.
At this point the state of the widget's element tree is no longer stable.
To safely refer to a widget's ancestor in its dispose() method, save a reference to the ancestor by calling dependOnInheritedWidgetOfExactType() in the widget's didChangeDependencies() method.
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 288:49      throw_
packages/flutter/src/widgets/framework.dart 4347:9                                <fn>

Do you have any idea on how I can log in after having logged out ???
P.S. Closing the app and re-opening ends up being logged-in immediately after such a crash. But I would like to log-in without having to close the app and re-open it again first.

phantastic ! This helped. It is now working fine.
Thank you very much.
(I was on the right track - also pinpointed the two times (Route<dynamic> route) => false to be the place where things go wrong. But I was not able to find any solution since I am quite new to Flutter)


updates dockerhub docs

change-type: patch

Hello @Page- This is a very very minor detail but considering many people are changing to Flowzone now and are using this template for their docker projects I think this bit can get messy in the future if people use the old variable.
If I understood this wrongly and it should still be DOCKER_REGISTRY_USER/DOCKER_REGISTRY_PASS please ignore.

So DOCKER_REGISTRY_USER is what's actually set on all the orgs atm but I agree the names of the secrets in flowzone and the org should match so I'll just duplicate the org secrets with both names and we can start transitioning to standardized naming


Should it be eventHubConnectionString instead of IotHubConnectionString

[Enter feedback here]
In the document, it uses IotHubConnectionString, and then read events from the iot hub's default eventHub. However, this will throw an invalid connectionString error. Looks like it has to be an eventHubConnectionString

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 681e10a1-05d3-5761-2afd-42602a7efecf
Version Independent ID: f72e21b1-3530-8554-f1f1-fc66b222a485
Content: Real-time data visualization of your IoT hub data in a web app
Content Source: articles/iot-hub/iot-hub-live-data-visualization-in-web-apps.md
Service: iot-hub
GitHub Login: @robinsh
Microsoft Alias: robinsh

Thanks; I’ll make sure it’s on the top of the list.
Robin
From: Michael Huang @.>
Sent: Thursday, April 8, 2021 1:45 PM
To: MicrosoftDocs/azure-docs @.>
Cc: Robin Shahan @.>; Mention @.>
Subject: [MicrosoftDocs/azure-docs] Should it be eventHubConnectionString instead of IotHubConnectionString (#73486)
[Enter feedback here]
In the document, it uses IotHubConnectionString, and then read events from the iot hub's default eventHub. However, this will throw an invalid connectionString error. Looks like it has to be an eventHubConnectionString

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 681e10a1-05d3-5761-2afd-42602a7efecf
Version Independent ID: f72e21b1-3530-8554-f1f1-fc66b222a485
Content: Real-time data visualization of your IoT hub data in a web apphttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fazure%2Fiot-hub%2Fiot-hub-live-data-visualization-in-web-apps%23download-the-web-app-from-github&data=04|01|Robin.Shahan%40microsoft.com|3c07c5f6f4b040c18fc808d8facf36c3|72f988bf86f141af91ab2d7cd011db47|1|0|637535115173298700|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Hu8MxTwMHMeLXIqzRtgiaGrn%2BaBRnPj1bGRh%2BA97Mhg%3D&reserved=0
Content Source: articles/iot-hub/iot-hub-live-data-visualization-in-web-apps.mdhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fblob%2Fmaster%2Farticles%2Fiot-hub%2Fiot-hub-live-data-visualization-in-web-apps.md&data=04|01|Robin.Shahan%40microsoft.com|3c07c5f6f4b040c18fc808d8facf36c3|72f988bf86f141af91ab2d7cd011db47|1|0|637535115173308653|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Sc4HgjCIEwdR4bKY7wfTJJHjUHBVOxADm1ZEQ2YgyWk%3D&reserved=0
Service: iot-hub
GitHub Login: @robinshhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frobinsh&data=04|01|Robin.Shahan%40microsoft.com|3c07c5f6f4b040c18fc808d8facf36c3|72f988bf86f141af91ab2d7cd011db47|1|0|637535115173308653|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=cMjJQGMh%2B5J%2BJpvDtjFSu0qlqjNjBlGIl%2B2Pzb1ue1k%3D&reserved=0
Microsoft Alias: robinsh

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F73486&data=04|01|Robin.Shahan%40microsoft.com|3c07c5f6f4b040c18fc808d8facf36c3|72f988bf86f141af91ab2d7cd011db47|1|0|637535115173308653|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Yk7kYTt6lm6on%2BUsLOY8GMVkZaPGhhJX8EIe8x%2Bbrxo%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADK7Q2BIZKDIZADV5UKS25LTHYIVXANCNFSM42TU2QSQ&data=04|01|Robin.Shahan%40microsoft.com|3c07c5f6f4b040c18fc808d8facf36c3|72f988bf86f141af91ab2d7cd011db47|1|0|637535115173318609|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=sFejmSqy43BcIB%2FHQErov2aWMMY%2Bm3DBjkXC%2Bt30vh8%3D&reserved=0.

I vaguely remember that we used to use one of those connection strings to access the data from the other service, and the EG people  changed it so you have to use "the right one", but I have no notes written down about it. Does anybody know anyone on the EG team that we can ask?
Robin

#reassign wesley mcswain

wesley is not a valid GitHub ID, or is not a collaborator on this repo.

#assign wesmc7777

@jinyanghuang @robinsh  Hi!
I looked over this and tested it myself.  This should work as documented. It worked for me.
The IoT Hub connection string should get converted to an event hub compatible connection string in this line of code - event-hub-reader.js line#16.
If it is failing for you, I wonder if the environment variable was correctly set, or maybe you could be using an older version of the code?

I assume you have verified the environment variable by echoing it?  echo %IotHubConnectionString%
Also have you tried pulling down the latest version of the sample with git clone https://github.com/Azure-Samples/web-apps-node-iot-hub-data-visualization.git?

I hve no idea, this was a GH issue put in by a customer. If you say it works as written, I'll take your word for it. And I will update my local version of the sample. Thanks for both of you.

@jimyanghuang I don't understand. If you tested it and it works, why are you saying there's a problem? Are you saying "The IoT Hub connection string is not getting converted to an event hub compatible connection string the line 16?" Are you running this through VS Code or as a web app with environment variables?

#please-close
@jinyanghuang After you review my previous response and answer those questions, if you're still having trouble let me know and I can assist you further.


my_val loss is high with your configure setting for your generate plates

Hi @qjadud1994
I trained your Plates with your setting training but the loss is't reach that you have achieve 0.01 , but my val loss was 26 , why ?
OS : Ubuntu 16.04 LTS
GTX : 1080 ti
RAM :32 GB

I tested this problem, i've solved this problem with number of large dataset. around 500k images got the val_loss 0.12.

@mzeynali hi, how long does it take you to get val_loss to 0.12, I try a dataset which contains around 700k images, and use Nvidia M40 , at least the first 9 hours, model's val_loss stay around 17. I try to load the checkpoint model weights and see the prediction, it is garbage, something like '.8********', and all the prediction is the same value. Have you encounter this problem?  Could you share some tips, thank you!


Draft: install SAP libs in the Maven local repository

DO NOT MERGE, DRAFT!
@cunningt @luigidemasi
As we discussed, this is a PR that demonstrates users installing the three SAP libraries in their Maven repository instead of using a lib folder. So for example using version 3.1.4 for sapjco and 3.1.1 for sapidoc on Linux x86 64 bit the user would have to run three commands:

mvn install:install-file -DgroupId=com.sap.conn.jco -DartifactId=sapjco3 -Dversion=3.1.4 -Dpackaging=jar -Dfile=sapjco3.jar

mvn install:install-file -DgroupId=com.sap.conn.idoc -DartifactId=sapidoc3 -Dversion=3.1.1 -Dpackaging=jar -Dfile=sapidoc3.jar

mvn install:install-file -DgroupId=com.sap.conn.jco -DartifactId=sapjco3 -Dversion=3.1.4 -Dclassifier=linux-x86_64 -Dpackaging=so -Dfile=libsapjco3.so

Some drawbacks compared to using the lib folder strategy:

If the user uses a different version for sapjco or sapidoc, he has to update the pom.xml
The command for the native library is OS dependent so error prone. If a different classifier was used the pom.xml also has to be updated.
The standalone version of the quickstarts (not sure if we should keep them here or not as this is for SpringBoot) uses the Camel Maven Plugin which doesn't have an option to add extra dependencies. We would therefore have to use the lib folder strategy.

Given those drawbacks I think I prefer keeping the lib folder strategy but maybe I'm missing something. We can improve on it as @luigidemasi suggested and use a single lib folder too.
Let me know what you think!

Nice job - this would be a huge improvement over what we currently have.    The only thing I worry about - and this doesn't really fall under the scope of this PR but is something I think we need to figure out when documenting the process - is how to explain to users which platform-dependent library (so, dylib, etc) they need for their particular platform.     I guess we only have to worry about supported platforms, but I think we need to do some mapping there of platform to library.