Inconsistent docs: Objects / Adding properties

The docs say:
file.js:3:16,16: undefined
This type is incompatible with
  file.js:8:7,12: string

In other words, Flow knows enough to infer that whenever the x property of o does exist, it is a number, so a string should not be expected.

So the text piece is not consistent with the code sample / output. Also it's not illustrative enough, as the order of foo() and bar() calls differs from the previous code snippet

Closing this out, per my comment on #1345. Thanks for the report!

@gabelevi looks like the new snippet of the code still lacks the return statement:
function foo(p) { p.x = 42; }
function bar(q) { q.f(); }

here the bar function doesn't return anything (return type is always underfined). My assumption is that it's not exactly what you wanted to illustrate by this snippet, considering the explanation below:

Flow knows enough to infer that whenever the x property of o does exist, it is a number, so a string should not be expected.

Gah, yeah, I see it. I'll patch it quickly.


Create a third_party/freetype2 repository for Flutter

We are currently using Fuchsia's third_party/freetype2 repository but may need to diverge from their build scripts

I don't seem to have the Create Project capability: https://gerrit-review.googlesource.com/Documentation/access-control.html#capability_createProject
/cc @godofredoc

Updated permissions, can you please give it another try?

Created: https://flutter.googlesource.com/third_party/freetype2/

The project is ready, please let us know if you find issues with permissions.

Permissions are required to import the repository's history

@jason-simmons can you please share the source repository and commands?

The repository should start from this commit in Fuchsia's FreeType repository:
https://fuchsia.googlesource.com/third_party/freetype2/+/f91671ab0d50a073631cd69823d8bb32f16216ce

This is done, please take a look and reopen if something does not work.
https://flutter.googlesource.com/third_party/freetype2/


Maybe it should be CallbackType.Coordination

https://github.com/apache/incubator-servicecomb-saga/blob/bdf8efe8155661582c32ca737d6f8122a6072680/omega/omega-spring-tx/src/main/java/org/apache/servicecomb/saga/omega/transaction/spring/ParticipateMethodCheckingCallback.java#L27
Maybe it should be
  public ParticipateMethodCheckingCallback(Object bean, CallbackContext callbackContext) {
    super(bean, callbackContext, CallbackType.Coordination);
  }

Thanks for point that out, it's my bad. I will submit a quick fix for it.

Just committed a quick fix for it. https://github.com/apache/incubator-servicecomb-saga/commit/63d71938e376eac280999d65e468a693df5e601a


CLI: Expose debug port if the service is enabled

If the debug service is enabled in config, the CLI should expose its port when launching the container.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Revise for-loop style

for (auto i = 0ul; i < goal->trajectory.joint_names.size(); ++i)
could be written as
for (std::size_t i = 0; i < goal->trajectory.joint_names.size(); ++i)
or
for (size_t i = 0; i < goal->trajectory.joint_names.size(); ++i)
which avoids using a typed literal and auto in favour of the classic type and type-agnostic literal which improves readability.
Any takes on this? @v-lopez perhaps?

I'd go with the size_t i = 0 version.
I can go over the code and look for these. I'm currently working on https://github.com/ros-controls/ros2_controllers/issues/38 and I can take this afterwards.

Can I get this is issue assigned to me?

If the index is only used to get the element, this:
for (std::size_t i = 0; i < goal->trajectory.joint_names.size(); ++i) {
  std::string joint_name = goal->trajectory.joint_names[i];
  do_stuff(joint_name);
}

Can also be written like the readable:
for (auto joint_name : goal->trajectory.joint_names) {
  do_stuff(joint_name);
}


Improve user click away detection

When a page contains multiple autocomplete components, the x-on:click.away listener may detect click.away events from the other autocomplete components if the user not pinpoint accurate when clicking inside the input field.  This is exacerbated when the user is moving the mouse slightly when the click is made.  This issue has been raised before in the AlpineJS repo:
https://github.com/alpinejs/alpine/discussions/1399
Essentially the recommended approach for maximum "click away" behaviour detection is to use the mousedown event when outside the component.  Luckly we can apply the away or  outside AlpineJS modifier to the mousedown listener to achive the desiered result.
As a bonus, this change will make the autocomplete away detection more accurate on mobile devices when a tap away is sometimes a scroll (mousedown) event...

@dircm Thanks! Looks good to me.


Split rendering driver project setting into renderer_name and rendering_driver

Closes: https://github.com/godotengine/godot-proposals/issues/4261
This also exposes OpenGL to the project creation menu and re-exposes the renderer switch button in the top right hand corner of the editor.
Things to consider during review:

Organization of the project settings. I organized the project settings as suggested in https://github.com/godotengine/godot-proposals/issues/4261, but it feels a little awkward.
Using enums instead of strings for renderer name and rendering driver. In 3.x we had a VideoDriver enum which we used throughout the engine instead of exposing strings directly. I think we should consider having a RenderingDriver enum and a RendererName enum which we pass around to avoid doing risky string operations all over the engine.

I blindly made some changes to the iOS and Android platforms, would be nice if someone from each team can confirm that the changes look okay.
Screenshots of exposed menus:

Great work! However, I wonder if it's worth it to reintroduce the the renderer switch button in the menu bar. This is something which will be changed very rarely during development for that it takes quite some space.

Great work! However, I wonder if it's worth it to reintroduce the the renderer switch button in the menu bar. This is something which will be changed very rarely during development for that it takes quite some space.

I was thinking the same thing. Especially since the new renderer names are much longer than GLES3/GLES2 (as they were in 3.x). I was thinking I would enable it here and then let the UI/UX people fix/remove it as they see fit.

Why hide the rendering API from the user? Why call GLES3 just called "Compatibility"? I think it would make sense to let users know that it's GLES3. Same for the Vulkan ones, I don't see a reason to hide that it's Vulkan.

Why hide the rendering API from the user? Why is GLES3 just called "Compatibility"? I think it would make sense to let users know that it's GLES3. Same for the Vulkan ones, I don't see a reason to hide that it's Vulkan.

I am with aaron on this. I think that hiding the api name from user will lead to confusion. My 2 cents.

Why hide the rendering API from the user? Why is GLES3 just called "Compatibility"? I think it would make sense to let users know that it's GLES3. Same for the Vulkan ones, I don't see a reason to hide that it's Vulkan.

In 4.0, different drivers can be used for a same rendering backend. The Clustered and Mobile backends will be usable both with Vulkan and Direct3D 12 depending on the target hardware and user preference.
The Compatibility backend will be usable both with OpenGL directly and with ANGLE (for GPUs where OpenGL support is problematic).

@Calinou I disagree, it's extremely relevant, not an implementation detail.

Graphics APIs are something that every game developer has some knowledge about, and even many gamers know about the existence of Vulkan, OpenGL, and DirectX.

The choice of graphics API is directly related to the hardware it can run on. If somebody knows what specific devices they want to support, they can look up which APIs those devices support.

I blindly made some changes to the iOS and Android platforms, would be nice if someone from each team can confirm that the changes look okay.

@clayjohn The Android changes looks good.

Why hide the rendering API from the user? Why is GLES3 just called "Compatibility"? I think it would make sense to let users know that it's GLES3. Same for the Vulkan ones, I don't see a reason to hide that it's Vulkan.

Its not hidden. OpenGL3 is the driver, not the renderer. The choice of driver is still presented to the user. On top of that, Users have never been able to explicitly set the Rendering API. The GLES3 driver mostly confirmed to OpenGL ES 3.0 like the name implies, but on web it is limited to the set of features in the WebGL specification and on Desktop it is limited by OpenGL 3.3. This PR lets us actually expose the selection of rendering API to the user.

Sorry @clayjohn , bit late to the discussion and about to potentially throw a monkey wrench into it :)
Looking to the (near) future and the wish to make the engine more extendable with more implementations, either full renderers like the GLES3 one (possibly a raytracing backend that was discussed), different drivers such as our DirectX backend that works with the RD renderer as a replacement/alternative to Vulkan, or additional RD renderers such as the planned deferred renderer, having these selections hardcoded the way that we do will become a nightmare.
I wonder if we need some way to register the available options and make the selection on the projection creation window and dropdown selection more generic?

I don't see harm in printing the supported driver/API in the hint text for each option. That's definitely not something that would stand in the way of this PR, just a bit about how we present the information to the user.
Options and how they separate target platforms make sense to me. The names may need to be bikeshed, but it's not too critical.

Notes from September 9th meeting:

Change compatibility to gl_compatibility
Have two codepaths one for compatibility and one for rendering_device
Rename clustered to forward+

Updated to:

remove GL_Compatibility renderer from project selection (will expose in another PR)
remove renderer selection from upper-right hand corner of editor (needs more discussion how this should be exposed)
rename "clustered" renderer to "forward_plus"
rename "compatibility" renderer to "gl_compatibility"

Should now be ready for review by @reduz

@aaronfranke @HeadClot I have removed the change to the project manager and I have updated the top post to highlight how this PR allows users to directly choose their graphics API for selected rather than before where it was fixed based on renderer choice.
Please let me know if you find this more suitable. To be perfectly frank, I don't fully understand your opposition to this PR in the first. We can't name the mobile renderer "Vulkan Mobile" because it may be running over Metal, WebGPU, D3D12, or Vulkan. One thing we could do is expose renderer choice and driver choice in the project manager so users can explicitly choose the renderer they want to us and the graphics API that they want to target.

@clayjohn Good points. With Metal, as far as I know it's using MoltenVK, which is Vulkan on top of Metal, but I guess maybe this isn't the case for D3D12 and WebGPU. Anyway, what about something like this?

@clayjohn Good points.With Metal, as far as I know it's using MoltenVK, which is Vulkan on top of Metal, but I guess maybe this isn't the case for D3D12 and WebGPU. Anyway, the menus you presented make a lot of sense to me, so the driver name is still shown, just not in the project manager. How about something like this?

That seems fine to me. Although to be clear, I have reverted the project manager changes in this PR and I won't make further changes in this PR. Those changes will have to be made in another PR. This PR is just about updating project settings now. I understand that reduz wants to make a proposal for the Renderer/Driver selection in the Project Manager.

I think its good, but I feel "renderer_name" can be open to confusion with the driver, IMO we should rename both the setting and the class to "rendering method", to better differentiate. I am also wondering whether "rendering driver" should be renamed to "rendering device driver".

Looks good to me, we may need to clean up main at some point, but can be done at another time. Need agreement from @BastiaanOlij about renaming the renderer scene class to rendering method.

Rebased, so should be ready to merge! @akien-mga
One thing I shouldv'e highlighted in the original post is that projects made in an earlier 4.0 version will have the project setting warning label appear on older projects in the ProjectManager. The warning can be safely ignored, but we will want to flag it in the next couple of blog posts:

One thing I shouldv'e highlighted in the original post is that projects made in an earlier 4.0 version will have the project setting warning label appear on older projects in the ProjectManager. The warning can be safely ignored, but we will want to flag it in the next couple of blog posts:

To avoid confusion, maybe we can keep the old names temporarily for compatibility, and add some code to actually remove them from project.godot when opening in beta 2+?

Looks fine overall, should be good to merge once the remaining comments are solved.

Looks fine overall, should be good to merge once the remaining comments are solved.

Thanks for checking! Pushed a fix with your suggested changes

@akien-mga @aaronfranke Thank you both for reviewing! All of your comments should be addressed now

Thanks!


esp_image: Checksum failed. (IDFGH-8043)

Environment

Module or chip used:  ESP32C3
IDF version : v4.3.2
Build System:         idf.py
Compiler version :8.4.0
Operating System:     Windows
(Windows only) environment type: ESP Command Prompt
Using an IDE?: No
Power Supply:  external 3.3V

Problem Description
I'm getting  esp_image: Checksum failed. error during boot of controller. I did OTA using esp_https_ota and after successful upgrade device was working properly. But after 2 months I got this error that controller can't boot due to checksum failed.  And out of 100 devices 4 devices are getting this kind of error. Which means it's hard to reproduce this.
Expected Behavior
It should work properly even after 2-3 months or a year.
Actual Behavior
After 2-3 months it's getting checksum failed error during boot.
Debug Logs
ESP-ROM:esp32c3-api1-20210207
Build:Feb  7 2021
rst:0x3 (RTC_SW_SYS_RST),boot:0xc (SPI_FAST_FLASH_BOOT)
Saved PC:0x403d153a
SPIWP:0xee
mode:DIO, clock div:1
load:0x3fcd6100,len:0x1944
load:0x403ce000,len:0x8d4
load:0x403d0000,len:0x2dc0
entry 0x403ce000
I (35) boot: ESP-IDF v4.3.2-dirty 2nd stage bootloader
I (35) boot: compile time 16:52:33
I (35) boot: chip revision: 3
I (37) boot_comm: chip revision: 3, min. bootloader chip revision: 2
I (44) boot.esp32c3: SPI Speed      : 80MHz
I (49) boot.esp32c3: SPI Mode       : DIO
I (54) boot.esp32c3: SPI Flash Size : 4MB
I (58) boot: Enabling RNG early entropy source...
I (64) boot: Partition Table:
I (67) boot: ## Label            Usage          Type ST Offset   Length
I (75) boot:  0 sec_cert         unknown          3f 06 0000d000 00003000
I (82) boot:  1 nvs              WiFi data        01 02 00010000 00006000
I (90) boot:  2 otadata          OTA data         01 00 00016000 00002000
I (97) boot:  3 phy_init         RF data          01 01 00018000 00001000
I (105) boot:  4 ota_0            OTA app          00 10 00020000 001c2000
I (112) boot:  5 ota_1            OTA app          00 11 001f0000 001c2000
I (120) boot:  6 fctry            WiFi data        01 02 003b2000 00006000
I (127) boot: End of partition table
I (132) boot_comm: chip revision: 3, min. application chip revision: 2
I (139) esp_image: segment 0: paddr=00020020 vaddr=3c130020 size=43074h (274548) map
I (188) esp_image: segment 1: paddr=0006309c vaddr=3fc90000 size=0580ch ( 22540) load
I (193) esp_image: segment 2: paddr=000688b0 vaddr=40380000 size=07768h ( 30568) load
I (200) esp_image: segment 3: paddr=00070020 vaddr=42000020 size=12ec08h (1240072) map
I (389) esp_image: segment 4: paddr=0019ec30 vaddr=40387768 size=086d8h ( 34520) load
I (395) esp_image: segment 5: paddr=001a7310 vaddr=50000000 size=00010h (    16) load
E (396) esp_image: Checksum failed. Calculated 0x12 read 0x32
E (401) boot: OTA app partition slot 0 is not bootable
E (407) esp_image: image at 0x1f0000 has invalid magic byte (nothing flashed here?)
E (415) boot: OTA app partition slot 1 is not bootable
E (421) boot: No bootable app partitions in the partition table
ESP-ROM:esp32c3-api1-20210207
Build:Feb  7 2021
rst:0x3 (RTC_SW_SYS_RST),boot:0xc (SPI_FAST_FLASH_BOOT)
Saved PC:0x403d153a
SPIWP:0xee
mode:DIO, clock div:1
load:0x3fcd6100,len:0x1944
load:0x403ce000,len:0x8d4
load:0x403d0000,len:0x2dc0
entry 0x403ce000
I (35) boot: ESP-IDF v4.3.2-dirty 2nd stage bootloader
I (35) boot: compile time 16:52:33
I (35) boot: chip revision: 3
I (37) boot_comm: chip revision: 3, min. bootloader chip revision: 2
I (44) boot.esp32c3: SPI Speed      : 80MHz
I (49) boot.esp32c3: SPI Mode       : DIO
I (54) boot.esp32c3: SPI Flash Size : 4MB
I (58) boot: Enabling RNG early entropy source...
I (64) boot: Partition Table:
I (67) boot: ## Label            Usage          Type ST Offset   Length
I (75) boot:  0 sec_cert         unknown          3f 06 0000d000 00003000
I (82) boot:  1 nvs              WiFi data        01 02 00010000 00006000
I (90) boot:  2 otadata          OTA data         01 00 00016000 00002000
I (97) boot:  3 phy_init         RF data          01 01 00018000 00001000
I (105) boot:  4 ota_0            OTA app          00 10 00020000 001c2000
I (112) boot:  5 ota_1            OTA app          00 11 001f0000 001c2000
I (120) boot:  6 fctry            WiFi data        01 02 003b2000 00006000
I (127) boot: End of partition table
I (132) boot_comm: chip revision: 3, min. application chip revision: 2
I (139) esp_image: segment 0: paddr=00020020 vaddr=3c130020 size=43074h (274548) map
I (188) esp_image: segment 1: paddr=0006309c vaddr=3fc90000 size=0580ch ( 22540) load
I (193) esp_image: segment 2: paddr=000688b0 vaddr=40380000 size=07768h ( 30568) load
I (200) esp_image: segment 3: paddr=00070020 vaddr=42000020 size=12ec08h (1240072) map
I (389) esp_image: segment 4: paddr=0019ec30 vaddr=40387768 size=086d8h ( 34520) load
I (395) esp_image: segment 5: paddr=001a7310 vaddr=50000000 size=00010h (    16) load
E (396) esp_image: Checksum failed. Calculated 0x12 read 0x32
E (401) boot: OTA app partition slot 0 is not bootable
E (407) esp_image: image at 0x1f0000 has invalid magic byte (nothing flashed here?)
E (415) boot: OTA app partition slot 1 is not bootable
E (421) boot: No bootable app partitions in the partition table
ESP-ROM:esp32c3-api1-20210207
Build:Feb  7 2021
rst:0x3 (RTC_SW_SYS_RST),boot:0xc (SPI_FAST_FLASH_BOOT)
Saved PC:0x403d153a
SPIWP:0xee
mode:DIO, clock div:1
load:0x3fcd6100,len:0x1944
load:0x403ce000,len:0x8d4
load:0x403d0000,len:0x2dc0
entry 0x403ce000
I (35) boot: ESP-IDF v4.3.2-dirty 2nd stage bootloader
I (35) boot: compile time 16:52:33
I (35) boot: chip revision: 3
I (37) boot_comm: chip revision: 3, min. bootloader chip revision: 2
I (44) boot.esp32c3: SPI Speed      : 80MHz
I (49) boot.esp32c3: SPI Mode       : DIO
I (54) boot.esp32c3: SPI Flash Size : 4MB
I (58) boot: Enabling RNG early entropy source...
I (64) boot: Partition Table:
I (67) boot: ## Label            Usage          Type ST Offset   Length
I (75) boot:  0 sec_cert         unknown          3f 06 0000d000 00003000
I (82) boot:  1 nvs              WiFi data        01 02 00010000 00006000
I (90) boot:  2 otadata          OTA data         01 00 00016000 00002000
I (97) boot:  3 phy_init         RF data          01 01 00018000 00001000
I (105) boot:  4 ota_0            OTA app          00 10 00020000 001c2000
I (112) boot:  5 ota_1            OTA app          00 11 001f0000 001c2000
I (120) boot:  6 fctry            WiFi data        01 02 003b2000 00006000
I (127) boot: End of partition table
I (132) boot_comm: chip revision: 3, min. application chip revision: 2
I (139) esp_image: segment 0: paddr=00020020 vaddr=3c130020 size=43074h (274548) map
I (188) esp_image: segment 1: paddr=0006309c vaddr=3fc90000 size=0580ch ( 22540) load
I (193) esp_image: segment 2: paddr=000688b0 vaddr=40380000 size=07768h ( 30568) load
I (200) esp_image: segment 3: paddr=00070020 vaddr=42000020 size=12ec08h (1240072) map
I (389) esp_image: segment 4: paddr=0019ec30 vaddr=40387768 size=086d8h ( 34520) load
I (395) esp_image: segment 5: paddr=001a7310 vaddr=50000000 size=00010h (    16) load
E (396) esp_image: Checksum failed. Calculated 0x12 read 0x32
E (401) boot: OTA app partition slot 0 is not bootable
E (407) esp_image: image at 0x1f0000 has invalid magic byte (nothing flashed here?)
E (415) boot: OTA app partition slot 1 is not bootable
E (421) boot: No bootable app partitions in the partition table

Other items if possible

sdkconfig file : sdkconfig

Can anyone help?

@JiaLWang Can you please help me or connect with the right person for this issue?

Hi Hipal,
Is it using wifi OTA?
Best regards,
Jialiang Wang 王家亮
Software Engineer｜Espressif Systems
www.espressif.comhttps://www.espressif.com/
Wi-Fi & Bluetooth MCUs and AIoT Solutions I Espressif Systemshttps://www.espressif.com/
Espressif Systems (688018.SH) is a public multinational, fabless semiconductor company established in 2008, with offices in China, the Czech Republic, India, Singapore and Brazil. We have a passionate team of engineers and scientists from all over the world, focused on developing cutting-edge Wi-Fi-and-Bluetooth, low-power, AIoT solutions.
www.espressif.com
#303A, Block 2, 690 Bibo Road,
Zhang Jiang High-Tech Park, Shanghai, China

From: Hipal Sakhreliya @.>
Sent: Wednesday, November 9, 2022 3:12 PM
To: espressif/esp-idf @.>
Cc: Wang Jialiang @.>; Mention @.>
Subject: Re: [espressif/esp-idf] esp_image: Checksum failed. (IDFGH-8043) (Issue #9547)
[External: This email originated outside Espressif]
@JiaLWanghttps://github.com/JiaLWang Can you please help me or connect with the right person for this issue?
—
Reply to this email directly, view it on GitHubhttps://github.com/espressif/esp-idf/issues/9547#issuecomment-1308311408, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AVHQ2CFRFONQVDHCMJE5VILWHNFGBANCNFSM56KN6G4Q.
You are receiving this because you were mentioned.Message ID: @.***>

@JiaLWang yes it is using wifi ota. But problem occurs without ota as well with  new code flashed.

@Alvin1Zhang  Would you please help with it? Thanks.

@JiaLWang @Alvin1Zhang Please look into the problem

@Alvin1Zhang Can you please help me with this?

@hipal31
firstly please help read out the flash ID and the status register when the device is broken, and post it here:

install & export in IDF
run esptool.py flash_id
run esptool.py read_flash_status

and then do you have enough broken devices? if so, please try if re-flash the device can make it work again. (to see if this is a irreversible issue)
Michael

@ginkgm Thanks for the reply.
Until now I received 15 devices with same issue. I did re-flash the device and kept it for testing. After re-flashing It's working.
Right now I don't have broken device at present with the issue to read flash id. I'll send once I receive a new broken device.
Regards,
Hipal

@hipal31
firstly please help read out the flash ID and the status register when the device is broken, and post it here:

install & export in IDF
run esptool.py flash_id
run esptool.py read_flash_status

and then do you have enough broken devices? if so, please try if re-flash the device can make it work again. (to see if this is a irreversible issue)
Michael

Hi @ginkgm ,
Recently I received a broken device, in which

After running esptool.py flash_id command, result is :

Connecting....
Detecting chip type... ESP32-C3
Chip is ESP32-C3 (revision 3)
Features: Wi-Fi
Crystal is 40MHz
MAC: 34:b4:72:4f:25:3c
Uploading stub...
Running stub...
Stub running...
Manufacturer: 20
Device: 4016
Detected flash size: 4MB
Hard resetting via RTS pin...

After running esptool.py read_flash_status command, result is :

Connecting...
Detecting chip type... ESP32-C3
Chip is ESP32-C3 (revision 3)
Features: Wi-Fi
Crystal is 40MHz
MAC: 34:b4:72:4f:25:3c
Stub is already running. No upload is necessary.
Status value: 0x0200
Hard resetting via RTS pin...

After that I run idf.py erase-flash and idf.py flash commands to re-flash module and it's working fine after re-flashing.

Please let me know if anything needs to be performed at my side and help me find out solution.
Regards,
Hipal

@ginkgm please look into the issue.

@hipal31 ,
This looks like a random problem, which may be related to many factors (power supply, PCB, SW, or the flash itself). We have a team dealing with this kind of issues. Please help raise a ticket here:
https://cqms.espressif.com/ticker/add
Please also include this Github issue in the ticket, and our support team will contact with you.

@ginkgm can I have your email for it?


Consider leaving layer canvas composition up to the browser

Since we now have a single canvas element per layer, I'm curious if we could see better performance by leaving composition up to the browser (instead of drawing all to a single map canvas).

My experiments in #6182 showed that css rotation (even if hardware accelerated) is quite slow. And then there's vector layers which are directly rendered to the map canvas. But if someone wants to work on that and the result is a performance gain, I'd not be opposed.

Right.  That was a hasty suggestion.  Vector layers make this a non-starter.


The subtype has no constraint, with type variable bound with another

The following program currently fails to typecheck :
class A[X, Y: X]
  fun foo(y: Y) =>
    let x : X = consume y

Building builtin -> /private/tmp/ponyc/packages/builtin
Building . -> /private/tmp/a
Error:
/private/tmp/a/a.pony:3:15: right side must be a subtype of left side
    let x : X = consume y
              ^
    Info:
    /private/tmp/a/a.pony:2:14: Y #any is not a subtype of X #any: the subtype has no constraint
      fun foo(y: Y) =>

In my opinion, the compiler should be able to infer that Y <: X, given the bounds on the type variables.
Interestingly, the following works
class A[X, Y: X]
    var f : A[X, Y] = A[X, Y]

But this doesn't, with the same error as above
class B[X, Y: X]
class A[X, Y: X]
    var f : B[X, Y] = B[X, Y]

FYI: with latest compiler, on El Capitian for me, compilation of this program never terminates.

Yes forgot to mention, this is latest compiler on Sierra for me

In my opinion, the compiler should be able to infer that Y <: X, given the bounds on the type variables.

I agree, though I'd like to get input from @sylvanc, since I suspect that there may be subtle issues with capabilities here. Specifically, I want to make sure we can still use is_cap_sub_cap_bound to check the subtype relationship for a pair of specific references to X and Y. Some quick thought experiments make me believe that we can, but I want to get a sanity check from @sylvanc first.

@jemc and @plietar I think you're right, this should be allowed. The subtype relationship is established.


ListView needs to be bounded to enable virtualization

ListView is intelligent about not creating more item container elements than are necessary to fill the screen (plus some caching). But that only works if it knows the bounds. If you put a ListView in something like a StackPanel or ScrollViewer, there are no bounds, and the UI virtualization is broken. This should be called out as a note in this documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a184d49-6889-2082-f5ea-5c651f40e429
Version Independent ID: f220e171-6cbb-aca9-6324-0c7ae55bc3aa
Content: ListView Class (Windows.UI.Xaml.Controls) - Windows UWP applications
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.ui.xaml.controls.listview.yml&version=GBlive&_a=contents
Product: uwp
Technology: winrt-reference
Git Login: jwmsft
Microsoft Alias: jimwalk

Hi @MikeHillberg - Thanks for taking the time to let us know about this issue and we sincerely apologize for the delayed response.
This topic contains a link to the https://docs.microsoft.com/en-us/windows/uwp/debug-test-perf/optimize-gridview-and-listview topic, which seems to address your concern in some depth.
Does this address your issue adequately?

Just searched about this topic, and I think that's not clear enough. The doc only mentioned about ItemsPanel, but I think what OP means is that the container of the whole ListView should have size limit. If you do something like this
<Page>
    <StackPanel>
        <ListView .../>
    </StackPanel>
</Page>

then there will be no virtualization.


Workflow with color highlighter

Is the only method to edit the colors by using short cut? WHen i click on the color nothing happens or this intended?
Even though it looks very nice and super usefull

Hi @schroef

WHen i click on the color nothing happens or this intended?
Even though it looks very nice and super usefull

I don't agree. The standard hot keys (ctrl+e) the most convenient. Thanks for the feedback.


Customise Logging configuration

Hi all,
I was wondering whether it is possible to change the logging configuration when creating/updating a state machine. From my current understanding the loggging configuration is set to default:
https://github.com/aws/aws-step-functions-data-science-sdk-python/blob/1e036cedd220dae3a41f1c875e9a522df9f75bb8/src/stepfunctions/workflow/stepfunctions.py#L212-L220
https://github.com/aws/aws-step-functions-data-science-sdk-python/blob/1e036cedd220dae3a41f1c875e9a522df9f75bb8/src/stepfunctions/workflow/stepfunctions.py#L254-L258

Hi @DyfanJones,
You're right. Workflow class doesn't expose a logging configuration parameter but there's no reason it shouldn't be in there as an optional parameter. By default, logging is off.
The API parameter is a dictionary (see boto3 docs) but there might be some abstraction we can do to help make it easier to set up.


Should support a way to enter data without having to modify the configuration file manually

Acceptance

[ ] Users can use commands from ugc (e.g. ugc module add, ugc module edit, ugc module reset) to modify the configuration on the fly for any supported property that can be edited.

Tasks

[ ] TBC.

Analysis
It would be interesting to have the ability to do all of this primarily via an intuitive interface. In other words, keep using ugc as a CLI tool, but input the data via a clean UI (front-end in a web browser) and then process the data to be stored on disk (back-end API calling the CLI in the background).
Incidentally, in the process of creating commands to be consumed by an API, this would lead to a way of performing all the necessary actions from the CLI too.

Seems like a decent amount of work for a feature that has not been requested yet :slightly_smiling_face:.

WONTFIX: Will re-open as needed. 🙂


Inline code block: escapes text

### Markdown

'''md
spoilers
!> this is a spoiler
'''

Spoilers in inline code doesnt work `!> it's messed up`

Ah, I see. It's not necessarily the !> tag, but things that need escaping.

Yes I found this on ' too. So how does
!>

look like? Like here spelled out or just a >? If the former, then it is just a matter of making the inline thing work like the block thing. Right?

Is this fixed? I can't remember. I merged a thing the other day.

Fixed !


fix: remove quotation from logging

Summary
Remove quotation from BasicLogging so that our logs can be recorded in telemetry correctly with the existing QuotationScrubber
Tests
Ran tests and verified loggings don't contain quotations anymore.
Dependency changes
No dependency changes

/azp run

Codecov Report

Merging #1461 (a439066) into master (3eb4661) will decrease coverage by 83.83%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb4661...a439066. Read the comment docs.


Don't swallow panic messages from thread pool

Closes #375.
Overview
From the documentation:

For safety reasons, a panic inside a worker thread will not be isolated, but rather propagate to the outside of the pool.

That's exactly what we want.
I have confirmed via a strategically placed panic! that panic messages are propagated to the toplevel as expected from within something like pool.scoped(|scope| scope.execute(|| panic!("bla"))).

Checklist

[ ] Updated the documentation (code documentation, command help, ...)
[ ] Tested the change (unit or integration tests)
[x] Amended the changelog in release.nix (see release.nix for instructions)

I tried something like this, too, but I stumbled over the fact that scoped_threadpool does not immediately rethrow panics in every circumstance (it tries to finish all current jobs in the pool before rethrowing the panic).
This makes sense for the use-case of that library, which is batching small-ish jobs, but I’m afraid we can’t use it for lorri for that reason.

We merged #435, which solves the problem with a more general solution.


Compiler inserts "void 0" in a place where it doesn't have to

This issue was imported from Closure Compiler's previous home at http://closure-compiler.googlecode.com
The original discussion is archived at:
http://blickly.github.io/closure-compiler-issues/#823

The original code was:
// Helper to wrap an object's inherited/own properties in a clean one.
function wrap(stuff) {
  var result = {};
  for (var x in stuff) {
    result[x] = stuff[x];
  }
  return result;
}
// Loop over the foo array and invoke baz with a wrapped instance of a foo item.
for (var i = 0; i < foo.length; i++) {
  baz(wrap(new foo[i]));
}

Output:
for (var a = 0;a < foo.length;a++) {
  var b = new foo[a], c = {}, d = void 0;
  for (d in b) {
    c[d] = b[d];
  }
  baz(c);
}
;


pre-trained model for EDVR

Hi, thank you for sharing your exciting works!
Would you like to share the pre-trained model of EDVR trained on BD degradation?
(i.e. the model yielded 27.85dB on Vid4 in paper 'BasicVSR: The Search for Essential Components in Video Super-Resolution and Beyond')
thanks!

You can ask Kelvin<EMAIL_ADDRESS>for this pretrained model


MetaMask - RPC Error: execution reverted

Describe the bug
The error MetaMask - RPC Error: execution reverted will occasionally occur when trying to remove on-chain group members.
To Reproduce
Steps to reproduce the behavior:

Go to any on-chain group with member.
Select a member to remove.
Select OK for remove confirmation.
See error Some error occurred! Check if you're on Sepolia network and the transaction is signed and completed.
Browser console will show error  MetaMask - RPC Error: execution reverted .

Sometimes the transaction will pass instead of error.
Expected behavior
The selected member should be removed successfully without any error.
Screenshots
Bandada alert error message

Browser console error message

This issue is due to the Semaphore Subgraph is not working properly after a member is removed, see issue: https://github.com/semaphore-protocol/semaphore/issues/858
Bandada could wait for the issue to be fixed or use the SemaphoreEthers class instead of the SemaphoreSubgraph class here: https://github.com/bandada-infra/bandada/blob/main/apps/dashboard/src/api/semaphoreAPI.ts#L1
Semaphore @semaphore-protocol/data docs: https://github.com/semaphore-protocol/semaphore/tree/main/packages/data#readme


node 16

there is a problem with the globals types. needs investigation…

See https://stackoverflow.com/a/68328575


Built-in support more linters and formatters

If I want to make a PR to add a lot more linters and formatters that I use as I migrate from null-ls, would you be okay with 1 PR that adds a bunch, or would you prefer separate PRs for each one?
I'm looking to add:
Linters

eslint_d
stylint
luacheck
shellcheck
codespell

Formatters

eslint_d
stylint
prettier_d_slim
markdownlint
cbfmt
stylua
shfmt
fish_indent
gofmt
swiftformat
nixfmt

thinking about how to write test case for these tools.

@glepnir am I good to go ahead and create a PR for several formatters (isort, djhtml, cbfmt, shfmt, prettierd)?

go for it :)

Guard.nvim was a bit too buggy for me so I switched to efm-langserver. It seems to work a lot better going through LSP.

interesting. You're not filing any bugs just making some bad comments here.


No signal in Dynamic Mode!

I am receiving the spoofed signal in "static mode" but not in the "Dynamic mode". I am using the Andriod "GPS Test" for analyzing the received spoofed signal. I have noticed that while transmitting the Dynamic Mode signal via the HackRF, it works as a jamming signal i.e. noting is displayed including the authentic GPS signal's strength.
P.S. I am using the include user motion file  "triumphv3.txt".

Have you figured the problem out I am having the same issuse?

@ShahZahidKhan Have you been solved this problem? I am using Gps Test on Android, too, and it's doesn't work in dynamic mode for me.


vscode-extensions.ms-python.vscode-pylance: 2022.1.5 -> 2022.7.11

Description of changes
Updated ms-python.vscode-pylance to the latest version (CHANGELOG.md).
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

vscode-extensions.ms-python.vscode-pylance

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Version is already at: 2022.7.11
Can you take the opportunity and complete the meta field?
Ideally keeping a reference for downloadPage (at vscode marketplace) and homepage at github.

Next time make sure to squash commits. I should have squashed it. But I didn't notice/forgot to do it. My mistake.


[Feature] [v 0.3] Special classes (objects) for aggregated data (polygons)

Semivariogram regularization requires access to the aggregated dataset variogram. It can be calculated automatically (as in v 0.2.X), but the regularization process has a too big responsibility, and it should be enhanced.
The thing is to create special objects to handle areal data in a way that is fast and effective.

[x] PolygonDataClass : stores and manages aggregated data sources,
[x] AggExperimentalVariogram : experimental variogram of areal data,
[x] AggTheoreticalVariogram : as above, but the theoretical models.

So, in the process of regularization, a user will gain a lot more control than it is given now. The regularization will be performed in four main steps:

Prepare Areal Data (Polygons).
Analyze variogram of Areal Data.
Create a Theoretical Model of Areal Data.
Regularize variogram.

Those steps can be overridden by auto_fit_transform() method that will be a copy of the current algorithm behavior (v 0.2.X).

Aggregated Theo fn is not required, Experimental Variogram is passed into TheoreticalVariogram and it contains a valid data structure.


Delegate quantization to mapbox-vector-tile library

The mapbox-vector-tile library has the option to quantize coordinates while encoding now. Instead of it being done in tilequeue before passing it to the formatter, it should just be delegated to mapbox-vector-tile to avoid having multiple implementations.

Would the formatter also enforce topological correctness on the output geoms to meet v2 MVT spec?

It would be the responsibility of the mapbox-vector-tile library.

@zerebubuth Can you confirm this is working as expected on dev and will also on prod?

Over to @rmarianski as Monday is a holiday in the UK for Matt.

@rmarianski see https://github.com/mapzen/TileStache/commit/73af54bd19a38cf429591c88cc8dbd64b122936e#commitcomment-17314785

Verified that the updated code has been deployed, and that it loads in tangram.


[ENH] NGFF format support

Co-authored-by: Satrajit Ghosh<EMAIL_ADDRESS>Supersedes: https://github.com/bids-standard/bids-specification/pull/1103
Example data: https://github.com/bids-standard/bids-examples/pull/315

This looks good, thanks @satra and @TheChymera for this initiative!
Regarding the example and validation, there are 4 JSON fields that are currently checked for consistency between the JSON metadata and the OME-TIFF metadata:
PixelSize, Immersion, NumericalAperture and Magnification.
Is NGFF using the same OME data model? If so, it may require to update the description of those fields and the validator accordingly.

mariehbourget commented 5 days ago
Is NGFF using the same OME data model? If so, it may require to update the description of those fields and the validator accordingly.

@mariehbourget, the latest versions of NGFF will also support the same OME-XML as is embedded in OME-TIFF so for those fields, the same validation would be feasible. However, there's added complication that some values on your list like PixelSize also have a representation in NGFF. They are intended to be the same value in two representations, but you might decide to cross-validate.

@sappelhoff on it, needs a bit more work since thus far paths are all treated as files, so validating directories needs to be built into the logic.

@sappelhoff there we go :) damage should be undone now.

no validator PR. Could you please open one?

Should be handled by: https://github.com/bids-standard/bids-specification/pull/1104/committ/4fb2574bf5502e697f46018058f49996ffd4a9fd

Also have a PR for the production JS validator: https://github.com/bids-standard/bids-validator/pull/1467

@tsalo ok, ready :)

@mariehbourget I added a new commit expanding the explanation of OME-ZARR (aka NGFF).
@chrisgorgo
@CPernet
@Remi-Gau
looks good?


ynet.co.il

Ynet news\newspaper
Match found in list.34.hosts.ubuntu101.co.za.domains:
ynet.co.il

It looks strange that it redirects me to https://www.ynet.co.il/home/0,7340,L-8,00.html ...

@funilrys  where at:

https://github.com/Ultimate-Hosts-Blacklist/adblock.mahakala.is/search?utf8=✓&q=ynet&type=

On what file?
And shallalist? for malware?
I can try to dig in it but it's a news site.
If stats is the issue then it something else but I think it should be first identified as a domains which either have malware or have stats all over it compared to one specific subdomain.

@elico Please report to GitHub documentation:

Only files smaller than 384 KB are searchable.

We use our internal search script.
A web app for deep searching will be available soon (I'm working on it as one of many side projects related to this repository).
About our structure

This repository compile all clean.list which are present in all input source repositories.
This repository compile domains.list if clean.list is not present in the input source repository we are currently fetching.

@funilrys I have a ready to use web dns and ICAP services which we can just use.
The update rate is 2M records update in less the 60 seconds and on a ATOM based machine it can take up to 3-4k requests per second no problems

It looks strange that it redirects me to https://www.ynet.co.il/home/0,7340,L-8,00.html ...
That just looks like some really bad Microsoft IIS setup

This is probably why 2 lists have flagged the domain. ynet.co.il needs to review their ad policies for public display. I run a number of sites with ads and have them carefully setup not to display anything of a mature nature.

@elico not sure if you have any contact with the admin's of ynet, suggest they be contacted and told to review their adsense display policies under > Allow & Block Ads > Content > Sensitive Categories

About the following:

@funilrys I have a ready to use web dns and ICAP services which we can just use.
The update rate is 2M records update in less the 60 seconds and on a ATOM based machine it can take up to 3-4k requests per second no problems

That comment is out of the scope of this issue.
Please start a new issue, a global or personal discussion so we can follow in our daily or weekly repositories/issues work.
Respectively:

Global discussions about this repository :  Slack
Personal discussions:

Slack Private Messsage
@mitchellkrogza

KeyBase

@funilrys

KeyBase

About this issue:
As @mitchellkrogza previously detailed, we are not whitelisting this (yet!?).

Closing.

ok will move where ever it fits later.(sorry for the long thread)
@mitchellkrogza I have not reviewed but I know they have adsense or something similar.
I will not contact their Admins since I don't really care... I just have seen people here using it daily for new so I was wondering.
I do know that *.ynet.co.il is being deeply censored for by the more "conservative" community here is Israel.

Thanks @elico if we can get more clarity on ynet.co.il we would certainly review it again.

@mitchellkrogza @funilrys The site itself has commercials but it's a local news site.
I do not like this site or it's methods and the commercials are probably there because of some JS which are fetching the adds from other sites and domains.

mrb.upapi.net
cdn.taboola.com
ecdn.firstimpression.io
...

just load the page with adblock plus(developer tools open (F12)) and see what domains pops up that might be worth blocking.
Also I just wanted to clear out that I have here a local ISP which does very deep content filtering on these pages(to the JS level) due to these ads being present.
The news sites around the globe are just a step forward from the news industry of the old times.
These who are getting paid by the clients are not presenting these ads/commercials.


May I Get A Copy Of Your Prebuild AAPT Version Source Code?

The Apk is obfuscated and the decompiled resouce xml contains 3-byte utf-8 char as the xml element name. The official aapt source code don't support this kind of xml file(myabe it's not allowed in XML standard).
I found the aapt use a EXPAT as its XML parser. The function utf8_isName3 in xmltoc.c file is used to determine the 3 byte char is a allowed as a name.
I try to modify the aapt source code, build my aapt and replace the prebuild aapt in apktool.jar but I enconter a problom:
W: ERROR: Unknown option '--forced-package-id'
I don't find this option in aapt souce code.
Maybe you modify the aapt code:
I run the  command: aapt.exe v
the output is:
Android Asset Packaging Tool, v0.2-eng.ibotpe.20190216.092407
I try to patch the prebuild appt.exe, I found the utf8_isName3 function is inline into a big function and I can't patch easily and avoid crash.
maybe I can't get a copy of your source and build my version.
Of course  I will  appreciate you deeply if you can offer the support this kind xml file.
below is the snippet of xml file :

<o.ʰ android:paddingLeft="@dimen/component_padding" android:paddingTop="@dimen/component_padding" android:paddingBottom="@dimen/component_padding" android:layout_width="fill_parent" android:layout_height="wrap_content"
xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto">
<o.ڒ android:id="@id/subheader_name" android:layout_marginRight="@dimen/component_padding" android:text="@string/name" app:layout_constraintLeft_toLeftOf="parent" app:layout_constraintRight_toRightOf="parent" app:layout_constraintTop_toTopOf="parent"<EMAIL_ADDRESS>/>
......
</o.ʰ>
the complete file is attached.
track_screen_edit_inner.zip
Thanks your GREAT work again.

It is right here - https://github.com/iBotPeaches/platform_frameworks_base, branch apktool_9.0.0.
May you share the patch for the utf8 name?


Beta

Branch contains primary implementation before issues tracking.

Test Timeline category item(s) should return: a JSON with status OK and result consistent with the schema and data values passed


Fix UI issues after upgrade console to 4.10

Jira: https://issues.redhat.com/browse/DBAAS-402

Fixed Instance table is not centered issue.
Fixed the search bar display issue in dev dashboard.

@yzhao583 can you add the screenshot for the fix :)


TFServing supports for general collections of metrics.

/kind feature
I saw this issue #1036 and was wondering will it be good to provide an API that will allow us to define our own metrics collector. A building block/API that can be extended should be good enough (this will accommodate more user specific use cases).

Moving https://github.com/kubeflow/kubeflow/issues/4514

/good-first-issue

Hi @yuzisun , could you please assign this feature to me? I'd like to contribute to it.

/assign @Yael-F


feat(host): aware of kubelet eviction config

What this PR does / why we need it:
Fixes: https://github.com/yunionio/cloudpods/issues/11591

Does this PR need to be backport to the previous release branch?:

release/3.7
release/3.6

/area host

/lgtm


In the editor, moving by word when on the first position leads to error

Open a Playground
Type 42
Press Cmd+Left
Press Cmd+Left

Fixed for now.


[WIP][WEB] Add Img2Img Stable diffusion.

Add FastAPI server in order to support multi page web.
Add Img2Img Stable Diffusion.

Signed-Off-by: Gaurav Shukla<EMAIL_ADDRESS>

Closing this one as Img2Img pipeline is already added.


Check if pods contain security identities before running test

I recently got this flake:
time="2018-11-14T10:41:41Z" level=debug msg="running command: kubectl exec -n kube-system cilium-m5xs7 -- cilium policy trace --src-k8s-pod default:app2-85b74b9c79-gvfjc --dst-k8s-pod default:app1-9d8945dc9-4lxnh --dport 80"
cmd: "kubectl exec -n kube-system cilium-m5xs7 -- cilium policy trace --src-k8s-pod default:app2-85b74b9c79-gvfjc --dst-k8s-pod default:app1-9d8945dc9-4lxnh --dport 80" exitCode: 1 duration: 288.554522ms stdout:

stderr:
level=info msg="Detected MTU 1500" subsys=mtu
level=info msg="Waiting for k8s api-server to be ready..." subsys=k8s
level=info msg="Connected to k8s api-server" ipAddr="https://<IP_ADDRESS>:443" subsys=k8s
level=info msg="Waiting for k8s api-server to be ready..." subsys=k8s
level=info msg="Connected to k8s api-server" ipAddr="https://<IP_ADDRESS>:443" subsys=k8s
Error: Cannot get security id from k8s pod name: cilium-identity annotation not set for pod app1-9d8945dc9-4lxnh in namespace default
command terminated with exit code 1

The annotation was set but it was not set with the command was executed. The output of controller status shows it was successfully 5s ago.
Controller Status:   58/58 healthy
  Name                                               Last success   Last error   Count   Message
  sync-identity-to-k8s-pod (24821)                   5s ago         never        0       no error

https://github.com/cilium/cilium/blob/f4cc278c5cc9de3ee62c7633f0470c36f7abbc6d/test/k8sT/Policies.go#L199-L205
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/8048/testReport/junit/k8s-1/12/K8sPolicyTest_Basic_Test_checks_all_kind_of_Kubernetes_policies/
6c7aa6c4_K8sPolicyTest_Basic_Test_checks_all_kind_of_Kubernetes_policies.zip

Happened again: https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/4941/testReport/junit/k8s-1/12/K8sPolicyTest_Basic_Test_checks_all_kind_of_Kubernetes_policies/

Happened again: https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/4964/testReport/junit/k8s-1/12/K8sPolicyTest_Basic_Test_checks_all_kind_of_Kubernetes_policies/

Again: https://jenkins.cilium.io/job/Ginkgo-CI-Tests-Pipeline/4972/

Not seen in a long time.


Set up custom command in ir.py

Add base for custom annotation to ir.py for the case that no annotation is provided

Please make this a draft PR if it doesn't yet pass tests and is not ready to be merged :)


chore: add release_stage field to definitions

Because

With https://github.com/instill-ai/pipeline-backend/pull/414 the release_stage property will be displayed and filtered by in the component definition lists.

This commit

Adds the release property for the existing connectors

Next steps ⏭

This field, along with others, will be documented so it is clear how to set it in new contributions.
In the console connector and operator lists, unimplemented components will be hidden.

QA
curl --request GET \
  --url "localhost:8080/vdp/v1beta/component-definitions?filter=release_stage=RELEASE_STAGE_ALPHA" \
  --header 'accept: application/json' | jq -c '.component_definitions[] | if .type == "COMPONENT_TYPE_OPERATOR" then .operator_definition  else .connector_definition end | {title,release_stage}'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 10285    0 10285    0     0   223k      0 --:--:-- --:--:-- --:--:--  228k
{"title":"Instill Model","release_stage":"RELEASE_STAGE_ALPHA"}
{"title":"OpenAI","release_stage":"RELEASE_STAGE_ALPHA"}
{"title":"Numbers Protocol","release_stage":"RELEASE_STAGE_ALPHA"}
{"title":"Pinecone","release_stage":"RELEASE_STAGE_ALPHA"}
{"title":"JSON","release_stage":"RELEASE_STAGE_ALPHA"}
{"title":"Redis","release_stage":"RELEASE_STAGE_ALPHA"}
{"title":"Airbyte Destination","release_stage":"RELEASE_STAGE_ALPHA"}
{"title":"BigQuery","release_stage":"RELEASE_STAGE_ALPHA"}
{"title":"Google Cloud Storage","release_stage":"RELEASE_STAGE_ALPHA"}
{"title":"Google Search","release_stage":"RELEASE_STAGE_ALPHA"}


How do I uninstall the tool?

Have you tried these steps?
Is there already an open topic for this issue?
Please include the following information.

OS Version:
Mac model:
Dongle or replaced card?:
Used dongle/card:

Your Issue:
Steps done to try to fix the issue:

run the tool again and pick option 3 or 4 depending on if you created backups when you initially ran the tool...


Added variable name

PR Fixes:

1
2

Resolves #[340]
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I assure there is no similar/duplicate pull request regarding same issue

Hello @ASIMNEUPANE , you can close this PR , as this issue has been fixed by harkirat a while ago.

fixed already


Spelling correction

Minor spelling correction.

@ChristopherMank Thank you for catching this. It looks like more than one reader noticed this, as another PR for this same change came through: https://github.com/MicrosoftDocs/vsts-docs/pull/1180 I happened to see that one first so I merged that one. Thanks again for your contribution.

@ChristopherMank sorry, I saw yours and did a search and thought I found a different instance 😊


[BUG] Deadlock in distribution with multiple 4090

Describe the bug
I'm trying to train a model with multiple 4090 gpus, but it always gets stuck and no report is shown. But when training with 3090 everything is fine. I strongly suspect that a deadlock occurs.
A simplest python code is attached.
from torch.optim import AdamW
from diffusers import StableDiffusionPipeline
import os
import torch.distributed as dist
import torch
import deepspeed

from datetime import timedelta
import torchvision

master_addr = os.environ.get("MASTER_ADDR", 'localhost')
master_port = os.environ.get("MASTER_PORT", 12345)
master_uri = f"tcp://{master_addr}:{master_port}" #if master_addr else 'localhost'
world_size = int(os.environ['OMPI_COMM_WORLD_SIZE'])
world_rank = int(os.environ['OMPI_COMM_WORLD_RANK'])
local_rank = int(os.environ['OMPI_COMM_WORLD_LOCAL_RANK'])

torch.cuda.set_device(local_rank)
dist.init_process_group(
    backend='nccl',
    init_method=master_uri,
    world_size=world_size,
    rank=world_rank,
    timeout=timedelta(hours=5),  # 5 hrs
)
torch.cuda.synchronize()

config = {'flops_profiler': {'detailed': True, 'enabled': False, 'module_depth': -1, 'profile_step': 1, 'top_modules': 3}, 'fp16': {'enabled': True}, 'gradient_accumulation_steps': 1, 'tensorboard': {'enabled': True, 'job_name': 'tensorboard_log', 'output_path': './'}, 'train_micro_batch_size_per_gpu': 16, 'zero_allow_untested_optimizer': True, 'zero_force_ds_cpu_optimizer': False, 'zero_optimization': {'allgather_bucket_size': 500000000.0, 'contiguous_gradients': True, 'offload_optimizer': {'device': 'cpu', 'pin_memory': True}, 'overlap_comm': True, 'reduce_bucket_size': 500000000.0, 'reduce_scatter': True, 'round_robin_gradients': True, 'stage': 2}}

model = torchvision.models.vgg16(pretrained=False)
model.to('cuda')
optimizer = AdamW(model.parameters(), lr=1e-3, betas=(0.9, 0.98), weight_decay=1e-3)

model, optimizer,_,_ = deepspeed.initialize(
    config_params=config,
    model=model,
    optimizer=optimizer,
)

Any response will be greatly appreciated!!
To Reproduce
Steps to reproduce the behavior:
copy the provided python code into test.py
Run the provided python file with CUDA_VISIBLE_DEVICES=0,1 AZFUSE_USE_FUSE=0 QD_USE_LINEIDX_8B=0 NCCL_ASYNC_ERROR_HANDLING=0 mpirun -np 2 python test.py
Expected behavior
Run the code successfully without getting stuck.
ds_report output

[2023-10-01 21:04:04,088] [INFO] [real_accelerator.py:158:get_accelerator] Setting ds_accelerator to cuda (auto detect)
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
 [WARNING]  async_io requires the dev libaio .so object and headers but these were not found.
 [WARNING]  async_io: please install the libaio-dev package with apt
 [WARNING]  If libaio is already installed (perhaps from source), try setting the CFLAGS and LDFLAGS environment variables to where it can be found.
async_io ............... [NO] ....... [NO]
fused_adam ............. [NO] ....... [OKAY]
cpu_adam ............... [NO] ....... [OKAY]
cpu_adagrad ............ [NO] ....... [OKAY]
fused_lamb ............. [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
random_ltd ............. [NO] ....... [OKAY]
 [WARNING]  sparse_attn requires a torch version >= 1.5 and < 2.0 but detected 2.0
 [WARNING]  using untested triton version (2.0.0), only 1.0.0 is known to be compatible
sparse_attn ............ [NO] ....... [NO]
spatial_inference ...... [NO] ....... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/miniconda3/envs/disco/lib/python3.10/site-packages/torch']
torch version .................... 2.0.1+cu118
deepspeed install path ........... ['/miniconda3/envs/disco/lib/python3.10/site-packages/deepspeed']
deepspeed info ................... 0.10.3, unknown, unknown
torch cuda version ............... 11.8
torch hip version ................ None
nvcc version ..................... 11.8
deepspeed wheel compiled w. ...... torch 2.0, cuda 11.8
shared memory (/dev/shm) size .... 251.83 GB

Screenshots
If applicable, add screenshots to help explain your problem.
System info (please complete the following information):

OS: Ubuntu 22.04
GPU count and types: 1 machine with x8 4090
Python version: 3.10
Any other relevant info about your setup

Launcher context
CUDA_VISIBLE_DEVICES=0,1 AZFUSE_USE_FUSE=0 QD_USE_LINEIDX_8B=0 NCCL_ASYNC_ERROR_HANDLING=0 mpirun -np 2
Docker context
Are you using a specific docker image that you can share?
No
Additional context
Add any other context about the problem here.

I just found I don't have an global nvcc installed. Would this be the crux?

Any update on this problem? Further, I believe that this issue is not only associated with DeepSpeed, but with distribute training on 4090.

@volcverse, @Rbrq03 apologies for the delayed response on this. Unfortunately, repro'ing this hang will be difficult since it seems to be hardware specific. Can you try debugging on your side by using py-spy to inspect the stack trace and identify the hang location. See the link below for guide on using py-spy
https://github.com/stas00/ml-engineering/blob/master/debug/torch-distributed-hanging-solutions.md

@Rbrq03 @tjruwase
Thanks for the response.
NCCL_P2P_DISABLE=1 works for me.
It seems that 4090 doesn't support p2p, so disable it everything will be fine.

@tjruwase @volcverse
Thanks for your kind response and providing the tool for debugging this issue. I do believe NCCL_P2P_DISABLE=1 works in some cases in my experience. Unfortunately, this command fails in other cases. I will try to use the tool.

@volcverse and @Rbrq03 thanks for your responses. I am glad that a workaround is available for some cases. I also agree that this issue is not due to DeepSpeed. So, I will close this ticket for now. Please feel free to update or re-open if needed. Thanks!


Appstudio update test-component-pac-fqpl

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-fqpl-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
18 seconds
clone-repository

✅ Succeeded
30 seconds
build-container

✅ Succeeded
18 seconds
inspect-image

✅ Succeeded
24 seconds
deprecated-base-image-check

✅ Succeeded
45 seconds
clamav-scan

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
40 seconds
label-check

✅ Succeeded
39 seconds
optional-label-check

✅ Succeeded
4 seconds
show-sbom

✅ Succeeded
5 seconds
show-summary

Pipelines as Code CI/test-component-pac-fqpl-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
35 seconds
build-container

✅ Succeeded
11 seconds
inspect-image

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
35 seconds
clamav-scan

✅ Succeeded
13 seconds
clair-scan

✅ Succeeded
10 seconds
sbom-json-check

✅ Succeeded
15 seconds
label-check

✅ Succeeded
15 seconds
optional-label-check

✅ Succeeded
8 seconds
show-sbom

✅ Succeeded
9 seconds
show-summary


bench command supports --no-fail-fast flag.

Fix for #4228.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors: r+
Thanks @dethoter!

:pushpin: Commit 63e5c17 has been approved by alexcrichton

:hourglass: Testing commit 63e5c176eba7d6bd8167719c9f1625f4f9c34c20 with merge cc8aa6f03274a91c3f3d86835ab36eb7de5099f0...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing cc8aa6f03274a91c3f3d86835ab36eb7de5099f0 to master...


fix typo

Gentle ping @ericniebler
Should be an easy review. Apologies for the noise if any. Thanks :)

Sorry for the delay!


Fix missing preview images on 50/50-style filterable lists

Preview images in 50/50-style filterable lists unfortunately got lost in the shuffle when we broke out the controls template from the list template. This PR fixes that problem.
Changes

Corrects the image data being passed to the info unit template by the filterable list template

Testing

Load up http://localhost:8000/consumer-tools/everyone-has-a-story/ and see no images
Pull branch
Reload the page and see empty space where the images would appear, if they were uploaded to your local Wagtail instance

If you want to double-check things, you can upload a new preview image (on the Configuration tab) to one of the listed stories, then reload the list page and see that it appears.

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the CFPB development guidelines
[x] Passes all existing automated tests
[x] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Visually tested in supported browsers and devices (see checklist below :point_down:)
[x] Project documentation has been updated
[x] Reviewers requested with the Reviewers tool :arrow_right:

Shoot I saw this, but since there are regularly missing images from the site when viewing locally I didn't pick up on it :( Thanks for catching!


HLS Live stream - Chromecast reproduction fails

Have you read the FAQ and checked for duplicate open issues?:
Yes
What version of Shaka Player are you using?:
v2.3.6
Can you reproduce the issue with our latest release version?:
Yes
Can you reproduce the issue with the latest code from master?:
Yes
Are you using the demo app or your own custom app?:
Demo app
What browser and OS are you using?:
Chrome 64 - Ubuntu
What are the manifest and license server URIs?:
Shaka demo asset: Shaka Player History (Live, HLS)
Also tested with a custom stream, same result.
(NOTE: a copy of the manifest text or an attached manifest will not be enough to reproduce your issue, and we will ask you to send a URI instead)
What did you do?
Start playing stream, initialize cast from player's controls.
What did you expect to happen?
Content being casted.
What actually happened?
Cast reproduction fails.

When you say that "cast reproduction fails", do you mean that the receiver app fails to load, or that it loads but fails to play the stream?
I tried casting that sample from our Ubuntu lab machine, and it launched the receiver app but failed to play there. I tried other computers to cast from and other Chromecasts to cast to, and they failed to play Shaka Player History (Live, HLS) also.
Looking at VV output, the cast sender is receiving 'seeking' events, so it might be that the Chromecast is stuck trying to get into the seek window.

It's the same behavior you experienced, it launches the receiver app but fails to play the stream.

I tried using my WIP change for #1307, and the asset played correctly. So it definitely looks like this is a problem with the narrow seek window on HLS livestreams.
I think that it is seeking ahead to the start of the window and buffering, but by the time it is done buffering the start of the window has slipped ahead of the buffered range. So it seeks ahead again, and so on and so forth, in a loop.
I suppose you could just wait on the change for #1307, but requiring someone to turn on an optional configuration option just for one of our sample assets to work properly seems non-ideal. Perhaps it'd be better to make the seek range on live HLS a little bit wider than 0s, by default. Investigation will be required.

@theodab, how much wider does the seek range need to be to avoid this?  Take a look at 7edb11ba39285bc9f92edbc1b88dbcb163b43c71 and see if MIN_SEEK_RANGE needs to be increased.

Ok, I've tried a few values for MIN_SEEK_RANGE. 1s played, but was a bit choppy; it periodically had to pause and seek forward. Of the values I tried, 3s was the smallest that didn't have any choppiness.

This change is for the sake of the cast receiver, so you won't be able to see it in effect until we update the cast receiver.
It also doesn't fix things for v1 Chromecasts; no matter how much longer I made MIN_SEEK_RANGE, our test v1 Chromecast was unable to play that livestream reliably. I'll have to look into what additional problem is plaguing our playback on v1 Chromecasts, and address it in a followup CL.

The changes that have been made so far are in v2.3.7 and will also be in our upcoming v2.4.0 release.  I'm going to bump this to v2.5 for any additional investigation that is needed.

Cherry-picked for v2.4.2.

Cherry-picked for v2.3.10.


[Codebundle] Run GCP Cloud Function

Scope
A taskset which authenticates with GCP and runs a cloud function, returning the stdout for the report
Requested By (Optional)

RunWhen

Related Integrations

GCP Cloud Functions

Definition of Done

[ ] Codebundle Implementation accomplishes scope (or provide a justification for why it may differ)
[ ] Attach a screenshot of the codebundle pushing a metric locally (if an SLI) or showing a report (if a taskset)
[ ] Attach a screenshot of the SLI or Taskset running in a workspace.

Optional Comments

This codebundle request and detail history is being migrated to an internal tracking tool for authors. Please reach out to the RunWhen team if you have any questions.


RPC hex digits are encoded with leading zeroes

They should not include leading zeroes, according to this: https://github.com/ethereum/go-ethereum/commit/ec75953f509a94ccb20bd346a2413bfee1281072#diff-246ab05b6eef408c71b1b3ba43be0ca6R28
In particular, the error I got is:
json: cannot unmarshal hex number with leading zero digits into Go struct field Log.logIndex of type hexutil.Uint

This is when running embark simulator

Closing as this issue is somewhat outdated compared to the current version of Status Embark


[Improvement] Handle non-writable mount points

If /db and /log result to not be writable in user mode, redirect them to /tmp/db and /tmp/log respectively.

Fixes situation seen in #27


Load semantic tokens from a document using a sourcekitd request instead of the 0,0 edit

This allows us to cancel the semantic tokens request. It is also the last step to allow us to open and edit documents in syntactic-only mode.
It also means that we no longer need to send a WorkspaceSemanticTokensRefreshRequest to the client after sourcekitd has updated its semantic tokens since with the new design the DocumentSemanticTokensRangeRequest will simply return the results once it has the updated semantic token.

https://github.com/apple/swift/pull/69294
@swift-ci Please test

@swift-ci Please test

@swift-ci Please test

@swift-ci Please test Windows


Run CPU expensive operations on a dedicated thread

Some knowledge about Rust captured in the 2nd commit message.

Is this a complete fix for https://github.com/itchysats/itchysats/issues/1064 ?

Is this a complete fix for https://github.com/itchysats/itchysats/issues/1064 ?

Not yet.

Is this a complete fix for #1064 ?

I am not sure if it is a fix for this at all. It fixes the heartbeats not being sent in the test. If the cause for #1064 are scheduling issues, then might also fix it but I haven't looked into #1064 specifically.

bors r+


Feedback on extension syncing UX

@rebornix gave me feedback that he would have wanted a warning or something when syncing so many extensions. Additionally cancellation and a progress bar would have been good as syncing 100 extensions take quite a long time.
First time experience where a user wants to ignore extensions is also tough.
Some random ideas:

Or after pressing OK and you have selected Extensions present a dialog saying which extensions you want to sync?

Themes
blah 1
blah 2
Languages
blah 1
blah 2

I'd like to share a bit more about the bad experience I got for syncing extension the first time across machines. When it asks me if I want to sync Extensions, my first impression is why not. However since I have 100 extensions installed on another machine, my workbench exploded

Vim and Atom keymap tries to beat each other
Multiple custom Welcome page
Tons of first time usage notifications
Error/Warning for missing dependencies
C++ extension immediately starts to download C++ tool chain.

This also leads to noise running fans

It's way beyond my expectation as firstly I forgot that I have so many extensions and at least half of them were no longer used. They were not uninstalled as I didn't know they exist. Secondly, I can't stop the whole syncing process, installing an extension is not an atomic operation/transaction so there is no easy way to undo. Lastly, extension storages are not synced, so they all think I'm a fresh new user.
Considering that side effects of installing an extension is not controlled by us, we may want to give users enough information about what they are syncing and warn that it might be costly.
BTW, we may also want to call out that for extensions, this feature is Automatic Downloading instead of syncing.

Thanks for the ideas, I will think about these.

👎 on the "automatic downloading" wording part, to me they mean the same thing and we should be consistent.


The driver_options configuration option is always set to nil if it isn't specified in the environment for rake, overriding other options

I set the driver options in my teaspoon_env:
config.driver_options = ['--ignore-ssl-errors=yes']

However, the options seemed to be completely ignored when I ran the tests from the CLI. I dug into the Teaspoon code, and I found that the options are indeed being set, but they're getting unset afterwards.
Specifically, the problem originates all the way up in teaspoon.rake. It fetches the options from the environment:
options = {
  files: ENV["files"].nil? ? [] : ENV["files"].split(","),
  suite: ENV["suite"],
  coverage: ENV["coverage"],
  driver_options: ENV["driver_options"],
}

This then gets handed down to Teaspoon.configuration.override_from_options, which blindly sets each value, even if it's nil:
def self.override_from_options(options)
  options.each { |k, v| override(k, v) }
end

It might be better to ignore nil values in this method, something like this:
options.compact.each { |k, v| override(k, v) }

I'm not sure what would be best given the other options, though. Perhaps it should be handled higher up in the call stack?

Thanks for submitting this issue, Alexis. A fix is in master if you'd like to give it a try, or it will go out with the next release.


Encryption rename open-rewrite rule

Type of change

Enhancement / new feature

Description
Building on #1043 as it move the maven co-ordinates I thought I'd experiment with an Open Rewrite which would automatically perform the migration. I'm not sure
Additional Context
To test the rule I added a dependency on the old name to the sample pom and asked it to update it.
mvn -U org.openrewrite.maven:rewrite-maven-plugin:run \
  -Drewrite.recipeArtifactCoordinates=io.kroxylicious:kroxylicious-migrations:0.5.0-SNAPSHOT \
  -Drewrite.activeRecipes=io.kroxylicious.rewrite.maven.EncryptionModuleToRecordEncryption \
  -pl :kroxylicious-sample

[INFO] Scanning for projects...
Downloading from central: https://repo.maven.apache.org/maven2/org/openrewrite/maven/rewrite-maven-plugin/maven-metadata.xml
Downloaded from central: https://repo.maven.apache.org/maven2/org/openrewrite/maven/rewrite-maven-plugin/maven-metadata.xml (5.6 kB at 15 kB/s)
[INFO]
[INFO] ----------------< io.kroxylicious:kroxylicious-sample >-----------------
[INFO] Building Sample filters 0.5.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] >>> rewrite-maven-plugin:5.23.3:run (default-cli) > process-test-classes @ kroxylicious-sample >>>
[INFO]
[INFO] --- maven-enforcer-plugin:3.4.1:enforce (enforce-plugin-versions) @ kroxylicious-sample ---
[INFO] Rule 0: org.apache.maven.enforcer.rules.RequirePluginVersions passed
[INFO]
[INFO] --- maven-enforcer-plugin:3.4.1:enforce (enforce-java-versions) @ kroxylicious-sample ---
[INFO] Rule 0: org.apache.maven.enforcer.rules.version.RequireJavaVersion passed
[INFO]
[INFO] --- maven-enforcer-plugin:3.4.1:enforce (enforce-systemtest-isolation) @ kroxylicious-sample ---
[INFO] Rule 0: org.apache.maven.enforcer.rules.dependency.BannedDependencies passed
[INFO]
[INFO] --- directory-maven-plugin:1.0:highest-basedir (resolve-rootdir) @ kroxylicious-sample ---
[INFO] Highest basedir set to: /Users/sbarker/development/kroxy/kroxylicious
[INFO]
[INFO] --- formatter-maven-plugin:2.23.0:format (format-sources) @ kroxylicious-sample ---
[INFO] Processed 6 files in 923ms (Formatted: 0, Skipped: 0, Unchanged: 6, Failed: 0, Readonly: 0)
[INFO]
[INFO] --- impsort-maven-plugin:1.9.0:sort (sort-imports) @ kroxylicious-sample ---
[INFO] Processed 10 files in 00:00.019 (Already Sorted: 10, Needed Sorting: 0)
[INFO]
[INFO] --- maven-resources-plugin:3.3.1:resources (default-resources) @ kroxylicious-sample ---
[INFO] Copying 1 resource from src/main/resources to target/classes
[INFO]
[INFO] --- maven-compiler-plugin:3.12.1:compile (default-compile) @ kroxylicious-sample ---
[INFO] Nothing to compile - all classes are up to date.
[INFO]
[INFO] --- formatter-maven-plugin:2.23.0:format (format-test-sources) @ kroxylicious-sample ---
[INFO] Processed 4 files in 115ms (Formatted: 0, Skipped: 0, Unchanged: 4, Failed: 0, Readonly: 0)
[INFO]
[INFO] --- maven-resources-plugin:3.3.1:testResources (default-testResources) @ kroxylicious-sample ---
[INFO] Copying 1 resource from src/test/resources to target/test-classes
[INFO]
[INFO] --- maven-compiler-plugin:3.12.1:testCompile (default-testCompile) @ kroxylicious-sample ---
[INFO] Nothing to compile - all classes are up to date.
[INFO]
[INFO] <<< rewrite-maven-plugin:5.23.3:run (default-cli) < process-test-classes @ kroxylicious-sample <<<
[INFO]
[INFO]
[INFO] --- rewrite-maven-plugin:5.23.3:run (default-cli) @ kroxylicious-sample ---
[INFO] Using active recipe(s) [io.kroxylicious.rewrite.maven.EncryptionModuleToRecordEncryption]
[INFO] Using active styles(s) []
[INFO] Validating active recipes...
[INFO] Project [Sample filters] Resolving Poms...
[WARNING] Failed to download io.kroxylicious:kroxylicious-encryption:0.5.0-SNAPSHOT. Attempted URIs:
  - file:///Users/sbarker/.m2/repository/
[WARNING] Failed to download io.kroxylicious:kroxylicious-encryption:0.5.0-SNAPSHOT. Attempted URIs:
  - file:///Users/sbarker/.m2/repository/
[WARNING] Failed to download io.kroxylicious:kroxylicious-encryption:0.5.0-SNAPSHOT. Attempted URIs:
  - file:///Users/sbarker/.m2/repository/
[WARNING] Failed to download io.kroxylicious:kroxylicious-encryption:0.5.0-SNAPSHOT. Attempted URIs:
  - file:///Users/sbarker/.m2/repository/
[INFO] Project [Sample filters] Parsing source files
[INFO] Running recipe(s)...
[WARNING] Failed to download io.kroxylicious:kroxylicious-bom:0.5.0-SNAPSHOT. Attempted URIs:
  - file:///Users/sbarker/.m2/repository/
[WARNING] Changes have been made to kroxylicious-sample/pom.xml by:
[WARNING]     io.kroxylicious.rewrite.maven.EncryptionModuleToRecordEncryption
[WARNING]         org.openrewrite.maven.ChangeDependencyGroupIdAndArtifactId: {oldGroupId=io.kroxylicious, oldArtifactId=kroxylicious-encryption, newGroupId=io.kroxylicious, newArtifactId=kroxylicious-record-encryption}
[WARNING] Please review and commit the results.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  17.187 s
[INFO] Finished at: 2024-02-29T15:49:56+13:00
[INFO] ------------------------------------------------------------------------

Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonarcloud warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

It seems like a good idea, but I'd leave it for another time.
If I were to do one thing to aid transition from 0.4.1 to 0.5.0 I'd alias the factory and keep backward compatibility with the old field names in the config.  However I see the delay that'd cause to 0.5.0 outweigh benefits to a small number of users.

It seems like a good idea, but I'd leave it for another time.

Why would you leave it? Its working, its already done.

If I were to do one thing to aid transition from 0.4.1 to 0.5.0 I'd alias the factory and keep backward compatibility with the old field names in the config. However I see the delay that'd cause to 0.5.0 outweigh benefits to a small number of users.

Yes, I was planning something similar along with keeping the old maven coordinates for a release cycle.

So we've released 0.5.0 without this so its moot now. But I think the idea is worth revisiting for other API migrations later.


Last Push Payload Infinite Loop on iOS

Hi everybody,
I was wondering how are you avoiding an infinite loop when using the setNotificationOpenedHandler on iOS.
Since you get the last push payload every time the app is opened, even if the user already saw the push, every subsequent app open will take them to the push's deep link.
Steps to reproduce:

Send a push notification with a deep link payload
Tap the notification
The app will take the user to the deep link's page (If implemented)
Close the app
Open the app
setNotificationOpenedHandler will be triggered with the last push payload and the app will handle the last push again.
The app will take the user to the deep link's page (If implemented)

Steps 4-6 will repeat forever every time the app is opened.
Is this the intended behavior for your application?
A way to fix this is to stop querying for the last push payload every time the setNotificationOpenedHandler is set and instead only trigger it went the actual system's didReceiveNotification function is called.
I can open a pull request if that makes sense
Thanks for the help.

I believe I was running into this issue on Android too, but simply stored the messageId from the payload of the previously opened notification to work-around it. Great to see this though!

Thank you for writing about it.
I'm going to take a look of this asap and then either fix the issue (if so) taking into consideration Gabriel's fix or probably looking for a different solution.

It's already available in iterable_flutter: 0.5.4 🤓


AlignVariablesSection:min_width is not using spacecount

Hi!
I upgraded to 4.6.0 from a bit older version and noticed that Variables section started to align differently. Looks like version 4.5.0 changed how AlignVariablesSection:min_width works and introduced AlignVariablesSection:fixed_width which is same as old behaviur. That works for me. But I believe there is a bug in the new AlignVariablesSection:min_width. It does not obey the spacecount and is always using 4 as minimum spaces.
See attached configuration file and test file where variables section is aligned differently than test cases. I was expecting same (tighter) alingment for both.
variables_section_align_issue.zip

Yes, I see that I'm using fixed separator instead of configured one. I will fix that. I have also noticed that AlignVariablesSection first round the length to the closest multiply of four and then add 4 as separator. Now it will just round (token length + minimal separator) to closest multiply of four, for example:
Variable with length 33 waswas rounded to 36 and then +4 = 40 width
Now such variable with default separator: (33 + 4) rounded will still give 40. But with configured separator, ie 2: (33 + 2) rounded gives us 36.
This already make the output bit more concise. There will be additional changes in separate PRs as well, most likely I will allow to ignore too long tokens (kinda max_width) and other changes from open issues.

After my changes, it appears that your example code is aligned in the same way:


Add tn.copy_node

The tn.copy operation is a little API heavy for just copying a single node. For example, the shortest code you can write to copy a single node looks like:
a = tn.Node(...)
a_copy = tn.copy(a)[0][a]

The [0][a] can be kinda messy, so it would be nice to have just a tn.copy_node operation to make this more obvious.

Perhaps tn.copy_node is not the best naming convention, given we have a CopyNodeclass?

oh shoot good point.

I am open to suggestions. I agree we shouldn't use this name.

Can I work on this issue?

Go for it.

ok@Thenerdstation

Since we have more than one type of BaseNode right now, should we maybe have BaseNode.copy() implementations for the subclasses? Then tn.copy() and tn.copy_node() can just call node.copy(), irrespective of the subclass.

Yes!

good idea!

Closing as we now have a node.copy() method.


Getting Error while integrating plotly js with single-spa-angular

While trying to integrate plotly js with single-spa-angular, in a browser console i'm getting an error, but if I try with standalone angular app, it's working fine. I have raised a stackoverflow  issue on that.
In that issue I have tried with angular 11 with related dependencies version, even I tried with latest version of dependencies with angular 12 but no luck getting same error only.
Please help me to solve this issue. Thanks.

I don't spend much time on maintaining single-spa-angular, so if others can help with this one that would be appreciated.


TSFile - remove from background_fetch plugin.

TSFile and related plugin API are being deprecated. This removes those from the background_fetch plugin, along with some other clean up.

https://github.com/apache/trafficserver/blob/master/tests/gold_tests/cache/background_fill.test.py

Hmmm, I'll have to double check.

@ezelkow1 is going to take over this PR

This was fixed with #10980


Release/v1.0.1

Codecov Report
Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 59.72%. Comparing base (638de7f) to head (0af7bc9).

Files
Patch %
Lines

...s/Classes/Core/Private/Streaming/DataFetcher.swift
50.00%
2 Missing and 1 partial :warning:

...s/Core/Private/Streaming/DataSessionDelegate.swift
60.00%
2 Missing :warning:

.../Classes/Core/Private/Streaming/DataProvider.swift
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   59.62%   59.72%   +0.10%
==========================================
  Files          45       45
  Lines        2006     1984      -22
  Branches      944      933      -11
==========================================
- Hits         1196     1185      -11
+ Misses        734      723      -11
  Partials       76       76

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Ignore possible SecurityException from InterfaceBuilder.IsDevMachine

I was getting this SecurityException on a dev machine under full IIS using the ApplicationPoolIdentity

Should mention, I was also getting this exception with 15.2 so maybe back-port.

thanks for the fix I tried to fetch your repo however it downloads everything from the beginning and treats it like its not a fork but a different repo. I wonder what is the reason for this, maybe you forked my repo (apobekiaris) instead of the main (eXpand) repo

Strange!  No, I forked from the main eXpand repo, 16.1 branch.  I didn't know you had a personal fork.
Looking at the github page for this PR it all looks normal - fork of expand:16.1, 1 file changed.

merged with <IP_ADDRESS>


Update Blog “cat”

Automatically generated by Netlify CMS

👷 Deploy Preview for magenta-dragon-0c2e51 processing.

Name
Link

🔨 Latest commit
140efa0da051a615379656634bef832cd6d25f0e

🔍 Latest deploy log
https://app.netlify.com/sites/magenta-dragon-0c2e51/deploys/65b08fb997d6100008f53aaf


Fix/constants

updated constants.js removed unused code.  made a commit with all un used consts at the bottom of the page commented out before pushing with the code removed so its easy to reference in the history later if needed.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.


File::Stat: return local time for atime, ctime and mtime

stat = File.stat(__FILE__)
pp stat.atime
pp stat.mtime
pp stat.ctime

Before:
stat.atime = 2016-04-18 17:07:24 UTC
stat.mtime = 2016-04-18 17:07:19 UTC
stat.ctime = 2016-04-18 17:07:19 UTC

After:
stat.atime = 2016-04-18 14:07:53 -0300
stat.mtime = 2016-04-18 14:07:19 -0300
stat.ctime = 2016-04-18 14:07:19 -0300

I think it's easier to work with local times regarding file information.

Given the DST issues and general unpolished timezone support yet, I'm not sure I'd like to +1 this just yet. Maybe put on hold until that's more solid? :)

Hehe, sounds good :-)
Time is a struct wrapping an UInt64, so creating a Time is very cheap, no heap memory needed. But computing local time involves calling LibC.gettimeofday, but I guess that's fast too.

#codetriage
I rebased this patch on 0.21.1 and it works as specified.
Since this was opened, #2481 has shipped, which added more Timezone-aware behaviors.
Time.now also reports a TZ-aware value like so: 2017-03-17 21:01:37 -0400, so it seems like some degree of TZ-awareness is shipped?

Time only handles UTC and Local. I have some unpublished code to make Time use 128bits and have nanosecond precision and timezone offset, but it's incomplete.


fix: don't attach default sg

Description
Do not attach default security group to vsi when security_group_ids is defined.
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

Need to test
Do we know what happens to an existing deployment with that change. Does the default security group get removed from the VSI?

Need to test
Do we know what happens to an existing deployment with that change. Does the default security group get removed from the VSI?

Created one with default sg initially then updated terraform to apply a new sg i created and remove default and all worked as expected.

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 2.12.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


React-native how to navigate to stackNavigator page from outside header component

Hi I want to open a stackNavigator page from outside component of header and footer. I have different buttons on the footer and want to open different stackNavigator pages onPress. The this.props.navigation not exist in the custom component then how to access navigator?
Code..
const MainNavigation = StackNavigator({
_home: {
screen: Home,
},
_myPlannerStack: {
screen: StackNavigator({
_myPlanner: { screen: MyPlanner },
_addCustomItem: { screen: AddCustomItem },
}),
},
_exhibitorDirectory: { screen: ExhibitorDirectory },
_seminarsAndEvents: { screen: SeminarsAndEvents },
_shuttlesAndMaps: { screen: ShuttlesAndMaps },
_theMarket: { screen: TheMarket },
});

this post have same issue which I am facing...
https://stackoverflow.com/questions/45751497/how-to-link-from-outside-into-navigator-for-example-from-a-global-footer/45751950?noredirect=1#comment78480828_45751950

closing since the question was answered on SO


[ru] Update KubeCon dates for 2023-2024

/assign @shurup

Hi @Arhell! Since my #44158 is merged now, let's reflect these changes in your PR here please?

@shurup done

@Arhell thank you! One small issue is still here, though :-) The KubeCon NA 2024 link should lead here since the original URL (with no year) will bring you to the KubeCon NA 2023 website.

@shurup done

Perfect, thanks! Let's finally merge it :sweat_smile:
/lgtm
/approve


Using ChainRulesCore for adjoint definition

Using rrule from ChainRules would be a lot more general and allow using other AD frameworks than Zygote.

https://juliadiff.org/ChainRulesCore.jl/stable/converting_zygoterules.html would be useful.

Thanks! Absolutely, it's on the ToDo-list and even mentioned as future work in the realted publication. We are currently preparing a larger patch, releasing in about 2-3 weeks together with an update for FMI.jl. We will try to consider this point as well.

Probably, the right way today would be to use AbstractDifferentiation.jl?

@ThummeTo I don't think so. AbstractDifferentiation.jl is more about say switching between Zygote or ForwardDiff or Diffractor that chain together individual rules for function gradients. But here what we are doing is in a sense defining a gradient rule for our function and that should still be ChainRules[Core], I think.

Added ChainRulesCore and ForwardDiff-Fallback in #15


Change traccar 3 default map to Google Maps

Hi Anton,
Is it possible for me to change the default maps to google maps ? Which code i've to edit ?
Thank you

There is a work-around to get Google Maps layers:
https://www.traccar.org/map-layers/
Note that you need a permission/license from Google to use their tile server.

if i have api keys on google... what can i  use google maps is a default layer in my traccar...?

If you have premium business Google Maps license, then ask their support if you are allowed to use tile server directly. That's the only option at the moment.
If you don't have premium license, you are not allowed to use Google Maps for GPS tracking.


Add ArgumentAttribute?

Is your feature request related to a problem? Please describe.
Only way how i can get input argument is using context?
var input = context.Argument<EntityInput>("input");

Is there any limitation on adding an attribute?
[Argument("input")] EntityInput input

Describe the solution you'd like
Add ArgumentAttribute(name) or may be i missed thing how i can do it?

Where would you like to apply this argument?

@PascalSenn
descriptor.Field<EntityResolvers>(x => x.CreateEntity(default!, default!))
  ...

// EntityResolvers
public async Task<EntityModel> CreateEntity(
	IResolverContext context,
        [Argument("input")] EntityInput input)
{
	// var input = context.Argument<EntityInput>("input");
	...
}

you do not need this attribute:
descriptor.Field<EntityResolvers>(x => x.CreateEntity(default!))
  ...

// EntityResolvers
public async Task<EntityModel> CreateEntity(EntityInput input)
{
        input
	...
}

How does this resolves arguments(input1: EntityInput, input2: EntityInput)? will i get same-typed arguments in they order?

If I'm not mistaken, it will use the name of the method argument when generating the name for the argument in the schema.  In other words, so long as you declare your method as public async Task<EntityModel> CreateEntity(EntityInput input1, EntityInput input2), then it will create arguments with the names of input1 and input2.  If you declare your method as public async Task<EntityModel>CreateEntity(EntityInput baseInput, EntityInput diffInput), then it will create arguments with the names of baseInput and diffInput.

I am declaring schema in code first, @TheJayMann is this about pure-code first?

I'm not really using pure code first, I'm using code first via fluent API rather than via attributes.  However, I'm nearly certain this is an area where both fluent API and attribute style work the same way, i.e. common to both.

@PascalSenn How does this works? Fluent api is prioritised? How HC is resolving which to use?

@sergeyshaykhullin  It takes the code first configuration of the arguments and then adds arguments for all parameters
When you have a parameter called XYZ and you configure fluently an XYZ argument nothing will be applied
If you have a parameter XYZ and you configure fluently a ZYX argument you will have two arguments

Gonna close this for now. Let us know if you have any more questions


Journal 11 - HPC calling runJOB not entering properly

It doesnt crash, but it doesnt do what it's supposed to do from my laptop. It works from the HPC though :(

This was originally Tutorial 11, but our method has changed widely during the summer so need to update.