HDFS-16831. [RBF SBN] GetNamenodesForNameserviceId should shuffle Observer NameNodes every time

Description of PR
HDFS-16831
The method getNamenodesForNameserviceId in MembershipNamenodeResolver.class should shuffle Observer NameNodes every time. The current logic will return the cached list and will caused all of read requests are forwarding to the first observer namenode.
The related code as bellow:
@Override
public List<? extends FederationNamenodeContext> getNamenodesForNameserviceId(
    final String nsId, boolean listObserversFirst) throws IOException {
  List<? extends FederationNamenodeContext> ret = cacheNS.get(Pair.of(nsId, listObserversFirst));
  if (ret != null) {
    return ret;
  }
  ...
}

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1 :x:
mvninstall
3m 40s
/branch-mvninstall-root.txt
root in trunk failed.

+1 :green_heart:
compile
3m 48s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 36s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 31s

trunk passed

+1 :green_heart:
shadedclient
28m 29s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 41s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
24m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 19s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

73m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5098

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5ecda8112937 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 15470ab94a91c304b21992590a0c3f1c837957ed

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/1/testReport/

Max. process+thread count
604 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@omalley @simbadzina Master, please help me review this PR too.  It works well locally.
The method getNamenodesForNameserviceId in MembershipNamenodeResolver.class should shuffle Observer NameNodes every time.

@goiri Sir, thanks for your review. I have updated this PR, please help me review it again when you are available. Thanks so much.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 20s

trunk passed

+1 :green_heart:
compile
0m 52s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 37s

trunk passed

+1 :green_heart:
mvnsite
0m 49s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 44s

trunk passed

+1 :green_heart:
shadedclient
24m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 36s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 20s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 31s

the patch passed

+1 :green_heart:
shadedclient
23m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
41m 57s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

146m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5098

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux fa858f60893c 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a2b59c388f6e1cf8dbbd51cade5417780e3b8c22

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/2/testReport/

Max. process+thread count
3581 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@ZanderXu Thanks for your contribution, we should fix the checkstyle issue.

@ZanderXu Thanks for your contribution, we should fix the checkstyle issue.

@slfan1989 Sir, thanks for your review. I have fixed the checkstyle in the last commit.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 25s

trunk passed

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 50s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  4s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 39s

trunk passed

+1 :green_heart:
shadedclient
24m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 53s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
23m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
42m  0s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

146m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5098

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 4ae9d29d7aa3 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2a0cff36d95301c31bf8c77d49f7192718c84aa0

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/3/testReport/

Max. process+thread count
3623 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

+1 LGTM after last commit. @ZanderXu - Do you think we need to add a UT ?

@ashutoshcipher Sir, thanks for your review. I will add one UT to test it. Do you have some good ideas to test shuffling result?

@ashutoshcipher @goiri @slfan1989 Sir, I have add one UT to test it. Please help me review it again. Thanks so much.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 10s

trunk passed

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 39s

trunk passed

+1 :green_heart:
mvnsite
0m 52s

trunk passed

+1 :green_heart:
javadoc
0m 57s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 38s

trunk passed

+1 :green_heart:
shadedclient
24m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 42s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 42s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

+1 :green_heart:
mvnsite
0m 39s

the patch passed

+1 :green_heart:
javadoc
0m 37s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 29s

the patch passed

+1 :green_heart:
shadedclient
23m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
40m 32s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

145m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5098

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5d7d54321b74 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ebadfb1c0c5c834b355d6b9b777a8b3f4a3fb62e

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/4/testReport/

Max. process+thread count
2288 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks @ZanderXu . I am +1 along with @goiri comments.

Thanks @ZanderXu . I am +1 along with @goiri comments.

+1  along with @goiri comments.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
39m  3s

trunk passed

+1 :green_heart:
compile
0m 55s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 42s

trunk passed

+1 :green_heart:
mvnsite
0m 59s

trunk passed

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 36s

trunk passed

+1 :green_heart:
shadedclient
21m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 42s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 39s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 26s

the patch passed

+1 :green_heart:
mvnsite
0m 44s

the patch passed

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 26s

the patch passed

+1 :green_heart:
shadedclient
20m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
23m 19s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

121m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5098

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9fb903214903 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 2329cb79ca390d2275ec623ebb0b96276fc5e4ef

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/6/testReport/

Max. process+thread count
2456 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 24s

trunk passed

+1 :green_heart:
compile
1m  0s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 43s

trunk passed

+1 :green_heart:
mvnsite
1m  1s

trunk passed

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m  0s

trunk passed

+1 :green_heart:
shadedclient
24m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 38s

the patch passed

+1 :green_heart:
compile
0m 41s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
0m 41s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 31s

the patch passed

+1 :green_heart:
shadedclient
24m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
42m 45s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

150m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5098

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ee7402af6c08 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4451a8438835a2598a111411570cefa033daec07

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/5/testReport/

Max. process+thread count
2377 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri Sir, can help me review this PR again? Thanks so much.

@simbadzina Master, can you help me review this PR when you are available?

@simbadzina Master, can you help me review this PR when you are available?

Code generally looks good to me. Just one small recommended change to test the shuffling.

\

To test the shuffling, one approach would be to call namenodeResolver.getNamenodesForNameserviceId() 100 times in a loop and check if ever the two observers swap positions in the list. If there is never a swap we fail the test.
The test will be probabilistic but the chance of it flaking will be extremely low 0.5^100.
List<? extends FederationNamenodeContext> observerList3 ;
    for(int i = 0; i < 100; i++) {
      observerList3 = namenodeResolver.getNamenodesForNameserviceId(NAMESERVICES[0], true);
      assertEquals(FederationNamenodeServiceState.OBSERVER, observerList3.get(0).getState());
      assertEquals(FederationNamenodeServiceState.OBSERVER, observerList3.get(1).getState());
      if (observerList3.get(0).getNamenodeId().equals(observerList2.get(1).getNamenodeId()) &&
          observerList3.get(1).getNamenodeId().equals(observerList2.get(0).getNamenodeId())) {
               return;
      }
}
Assert.fail("Observer order never changed.");

@simbadzina Thanks for your nice suggestion, I will do it.

@simbadzina master, I have modified the UT, please help me review again, thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 49s

trunk passed

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 35s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 31s

trunk passed

+1 :green_heart:
shadedclient
20m 50s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 18s

the patch passed

+1 :green_heart:
shadedclient
20m 27s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
22m 35s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

117m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5098

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cbf532c9a828 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d154c049d9fd2419eb8c98bb45d95070d4ba14f5

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/7/testReport/

Max. process+thread count
2242 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5098/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Merged, thanks @ashutoshcipher @simbadzina @slfan1989 @goiri for your review. Thanks so much.


LoadAsync does not work

No entities end up being tracked.
Repro:
public class BloggingContext : DbContext
{
    public DbSet<Blog> Blogs { get; set; }

    protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        => optionsBuilder.UseSqlServer(@"Server=(localdb)\mssqllocaldb;Database=LoadAsyncTest;Trusted_Connection=True;");
}

public class Blog
{
    public int Id { get; set; }
    public string Title { get; set; }
}

public class Program
{
    public static void Main()
    {
        Task.Run(async () =>
        {
            await MainAsync();
        }).Wait();
    }

    public static async Task MainAsync()
    {
        using (var context = new BloggingContext())
        {
            context.Database.EnsureDeleted();
            context.Database.EnsureCreated();

            context.AddRange(new Blog(), new Blog());
            await context.SaveChangesAsync();
        }

        using (var context = new BloggingContext())
        {
            await context.Blogs.LoadAsync();

            Console.WriteLine(context.ChangeTracker.Entries().Count());
        }
    }
}

Output is 0; expected output is 2.
When run with Load instead of LoadAsync, output is 2 as expected.
Note that there are currently zero tests for LoadAsync.

Note that the LoadAsync code in EntityFinder should be updated when this bug is fixed.


[1.12.0rc3] Filesystem error (rm infinite loops) deleting files with overlay2

Output of docker version:
Client:
 Version:      1.12.0-rc3
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   8f59970
 Built:        Tue Jul  5 21:14:32 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.0-rc3
 API version:  1.24
 Go version:   go1.6.2
 Git commit:   8f59970
 Built:        Tue Jul  5 21:14:32 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 3
 Running: 3
 Paused: 0
 Stopped: 0
Images: 68
Server Version: 1.12.0-rc3
Storage Driver: overlay2
 Backing Filesystem: xfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge null host overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: apparmor seccomp
Kernel Version: 4.2.0-34-generic
Operating System: <unknown> (containerized)
OSType: linux
Architecture: x86_64
CPUs: 32
Total Memory: 58.97 GiB
Name: jenkins9-uswest2ctestopia
ID: BEK3:U2QA:ZHYB:7KZB:DY6C:UPKP:KHEA:44EC:XM7Z:WV76:6EYZ:MQIY
Docker Root Dir: /ephemeral/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Insecure Registries:
 [redacted]

Additional environment details (AWS, VirtualBox, physical, etc.):
AWS, on a heavily modified Ubuntu lucid machine.
Steps to reproduce the issue:
These steps are causing the failure for us:

docker run -ti our_lucid_image bash
rm -rf /usr/lib/locale/C.UTF-8/

This happens reliably on one host for us, but not on others using the same version of Docker, the same image, and also overlay2. I'm still trying to find a way to reproduce this outside of the affected host.
Describe the results you received:
The rm never finishes, and we receive this output:
ckuehl@jenkins9-uswest2ctestopia:/etc/cron.d$ docker run -ti our_lucid_image bash
root@1864923f173d:/# rm -rf /usr/lib/locale/C.UTF-8/
rm: cannot remove directory `/usr/lib/locale/C.UTF-8/LC_MESSAGES': Directory not empty

I strace'd the rm process, and it is looping this forever:
getdents(3, /* 0 entries */, 32768)     = 0
lseek(3, 0, SEEK_SET)                   = 0
getdents(3, /* 14 entries */, 32768)    = 448
unlinkat(3, "LC_ADDRESS", 0)            = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_COLLATE", 0)            = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_CTYPE", 0)              = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_IDENTIFICATION", 0)     = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_MEASUREMENT", 0)        = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_MONETARY", 0)           = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_NAME", 0)               = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_NUMERIC", 0)            = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_PAPER", 0)              = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_TELEPHONE", 0)          = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_TIME", 0)               = -1 ENOENT (No such file or directory)
getdents(3, /* 0 entries */, 32768)     = 0
lseek(3, 0, SEEK_SET)                   = 0
getdents(3, /* 14 entries */, 32768)    = 448
unlinkat(3, "LC_ADDRESS", 0)            = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_COLLATE", 0)            = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_CTYPE", 0)              = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_IDENTIFICATION", 0)     = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_MEASUREMENT", 0)        = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_MONETARY", 0)           = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_NAME", 0)               = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_NUMERIC", 0)            = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_PAPER", 0)              = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_TELEPHONE", 0)          = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_TIME", 0)               = -1 ENOENT (No such file or directory)
getdents(3, /* 0 entries */, 32768)     = 0
lseek(3, 0, SEEK_SET)                   = 0
getdents(3, /* 14 entries */, 32768)    = 448
unlinkat(3, "LC_ADDRESS", 0)            = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_COLLATE", 0)            = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_CTYPE", 0)              = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_IDENTIFICATION", 0)     = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_MEASUREMENT", 0)        = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_MONETARY", 0)           = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_NAME", 0)               = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_NUMERIC", 0)            = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_PAPER", 0)              = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_TELEPHONE", 0)          = -1 ENOENT (No such file or directory)
unlinkat(3, "LC_TIME", 0)               = -1 ENOENT (No such file or directory)
getdents(3, /* 0 entries */, 32768)     = 0
lseek(3, 0, SEEK_SET)                   = 0
getdents(3, /* 14 entries */, 32768)    = 448

If I exec into the container, I get this:
root@1864923f173d:/# ls -l /usr/lib/locale
total 4
drwxr-xr-x 1 root root 4096 Jul 13 21:17 C.UTF-8
root@1864923f173d:/# ls -l /usr/lib/locale/C.UTF-8/
ls: cannot access /usr/lib/locale/C.UTF-8/LC_ADDRESS: No such file or directory
ls: cannot access /usr/lib/locale/C.UTF-8/LC_COLLATE: No such file or directory
ls: cannot access /usr/lib/locale/C.UTF-8/LC_CTYPE: No such file or directory
ls: cannot access /usr/lib/locale/C.UTF-8/LC_IDENTIFICATION: No such file or directory
ls: cannot access /usr/lib/locale/C.UTF-8/LC_MEASUREMENT: No such file or directory
ls: cannot access /usr/lib/locale/C.UTF-8/LC_MONETARY: No such file or directory
ls: cannot access /usr/lib/locale/C.UTF-8/LC_NAME: No such file or directory
ls: cannot access /usr/lib/locale/C.UTF-8/LC_NUMERIC: No such file or directory
ls: cannot access /usr/lib/locale/C.UTF-8/LC_PAPER: No such file or directory
ls: cannot access /usr/lib/locale/C.UTF-8/LC_TELEPHONE: No such file or directory
ls: cannot access /usr/lib/locale/C.UTF-8/LC_TIME: No such file or directory
total 0
?????????? ? ?    ?     ?            ? LC_ADDRESS
?????????? ? ?    ?     ?            ? LC_COLLATE
?????????? ? ?    ?     ?            ? LC_CTYPE
?????????? ? ?    ?     ?            ? LC_IDENTIFICATION
?????????? ? ?    ?     ?            ? LC_MEASUREMENT
drwxr-xr-x 1 root root 28 Jul 13 21:17 LC_MESSAGES
?????????? ? ?    ?     ?            ? LC_MONETARY
?????????? ? ?    ?     ?            ? LC_NAME
?????????? ? ?    ?     ?            ? LC_NUMERIC
?????????? ? ?    ?     ?            ? LC_PAPER
?????????? ? ?    ?     ?            ? LC_TELEPHONE
?????????? ? ?    ?     ?            ? LC_TIME
root@1864923f173d:/# ls -l /usr/lib/locale/C.UTF-8/LC_MESSAGES
ls: cannot access /usr/lib/locale/C.UTF-8/LC_MESSAGES/SYS_LC_MESSAGES: No such file or directory
total 0
?????????? ? ? ? ?            ? SYS_LC_MESSAGES

If I run a new copy of our_lucid_image, I can ls -l and view all of the files. No errors appear until I try to remove that directory.
Describe the results you expected:
The directory should be deleted.
I'm still trying to reliably reproduce this on another machine, any suggestions are very welcome.

On that same host:

Happens after restarting Docker
Happens after removing all containers (including stopped containers)
Happens after removing all images (besides the one affected image)
Happens after removing all images and all containers, then pulling that image again
Happens after stopping Docker daemon, rm -rf /var/liib/docker, starting Docker, pulling, and trying again.

It still happens only with the one internal image (but this doesn't happen with that same internal image on different hosts).
I then upgraded to 1.12.0rc4 from 1.12.0rc3 (without wiping out /var/lib/docker) and confirmed this still happens.

ping @dmcgowan ^^

Can you also reproduce this with the overlay driver? What driver were you using previously?

@dmcgowan I can't reproduce this with overlay or aufs (I removed /var/lib/docker. We were using aufs previously.

@dmcgowan sorry, the above comment posted too soon. I can reproduce this with overlay, but not with aufs.

@chriskuehl thanks, that is helpful. From the strace it appears that rm -rf is repeatedly reading the entries to the same directory using an FD to a lower layer. Since that FD will never change and it is doing an lseek to the beginning, it is looping forever. This seems weird to me since the directory being changed should have been copied up to the top layer, will explore more to see if I can find a case which just reproduces that flow. This would also explain why the files are deleted afterwards since a subsequent ls will be operating on the copied up version.

This looks similar to this bug: https://github.com/coreos/bugs/issues/1097
Both the centos and ubuntu Dockerfiles at the bottom of the first post reproduce the issue on overlay2 (but not aufs) for me, and do so on two different machines (both Ubuntu lucid with 1.12rc3 and overlay2, though only one has the original issue I reported with our image).
So it seems like a kernel upgrade might help; I'm trying that now.

Are the hosts in which you are not seeing the problem using the same kernel version and xfs?

@dmcgowan same kernel version, but the hosts where I am not seeing the problem are all extfs instead of xfs (specifically ext3). I will find another host with xfs to test on.

@dmcgowan good thinking, trying this on another host with xfs as the backing filesystem (and same kernel version) reproduces the issue on our custom lucid container.

I recall something about this in kernel threads ping @rhvgoyal (I remember something xfs related, not about the rm loop) and Ubuntu uses a patched a version of overlay fwiw ;)

I confirmed that this still happens on the linux-image-4.4.0-28-generic kernel from xenial (tested on lucid, though).

Above I originally said I reproduced it on the xenial 4.4.0-28-generic kernel. It was actually the trusty kernel, sorry.
I'm able to reproduce this on trusty. It seems to work fine on xenial (probably different kernel patches despite both using their version of 4.4.0-28-generic?). Here are my steps:
$ vagrant init ubuntu/trusty64
$ vagrant up
$ vagrant ssh

# upgrade kernel
vagrant$ sudo apt-get update
vagrant$ sudo apt-get -y install linux-image-4.4.0-28-generic xfsprogs
vagrant$ sudo shutdown -r now
$ vagrant ssh

# make an XFS volume for /var/lib/docker
vagrant$ dd if=/dev/zero of=test.img bs=100M count=10
vagrant$ mkfs.xfs test.img
vagrant$ sudo mkdir /var/lib/docker
vagrant$ sudo mount -o loop test.img /var/lib/docker

# install Docker with overlay2
vagrant$ curl -fsSL https://test.docker.com/ | sh
vagrant$ echo 'DOCKER_OPTS="-s overlay2"' | sudo tee -a /etc/default/docker
vagrant$ sudo service docker restart
vagrant$ sudo docker info | grep -E 'overlay2|xfs'
Storage Driver: overlay2
 Backing Filesystem: xfs

# replicate bug
vagrant$ echo test.img > .dockerignore
vagrant$ tee Dockerfile <<EOF
FROM ubuntu:trusty
RUN apt-get update && apt-get install -qy python-setuptools
RUN easy_install pip
RUN pip install --upgrade setuptools
EOF
vagrant$ sudo docker build -t test .

FWIW, on Fedora + kernel 4.6.3 everything's working fine with XFS as backing FS


Updating URL for point to MS Downloads

The URL to download the templates was using GitHub.  I've redirected this to the new MS Downloads link.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


sql: augment statement logging with a txn counter

PR: https://github.com/cockroachdb/cockroach/pull/41929
From release notes:

The structured payloads used for SQL audit and execution logs now include a transaction counter since the beginning of the session. Statements issued inside the same SQL transaction will thus be logged with the same counter value, thus enabling per-transactions grouping during log analysis. Separate sessions use independent counters. [#41929][#41929] {% comment %}doc{% endcomment %}

cc @ericharmeling, @ianjevans, this might be SQL observability, not sure.

This is about the log messages, so it should be my area.

Closed by #10273.


[DOC] Update paper referenced in Arsenal docs

Reference Issues/PRs
Fixes #1885
What does this implement/fix? Explain your changes.
Replace previous citation with the citation from springer : https://link.springer.com/article/10.1007/s10994-021-06057-9#citeas
Does your contribution introduce a new dependency? If yes, which one?
No.
Any other comments?
No.
PR checklist
No.
For all contributions

[x] I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.

@all-contributors add @Cyril-Meyer for doc

[x] The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

Before :

After :


Svitlana4

last three commits added functionality to delete buttons, new idea inserts, relating two tables (tested on two users) and add status to ides(private or public)
Fix new idea insert
aa4fd58
Add status to idea
84df4a3
Added delete idea functionality
8f46dc6

resolved merging conflicts locally. outdated PR request


cache: oldValue, newValue don't work because of reference

Since cacheHandlers returns eg cache.get() things like oldValue, newValue don't work cause of reference.
eg:
const payload = data.d as IDK;
const oldValue = await cacheHandlers.get("something", ID);

await cacheHandlers.set("something", ID, payload);
const newValue = await cacheHandlers.get("something", ID);

oldValue === newValue // true

Hope explanation isn't so bad.

I already have a work around for that so I would do that.

I already have a work around for that so I would do that.

Hmm now I tested it with more functions and got a different result. Means not all events work the same way in that regards.

Hmm now I tested it with more functions and got a different result. Means not all events work the same way in that regards.

Since cacheHandlers returns eg cache.get() things like oldValue, newValue don't work cause of reference.
eg:
const payload = data.d as IDK;
const oldValue = await cacheHandlers.get("something", ID);

await cacheHandlers.set("something", ID, payload);
const newValue = await cacheHandlers.get("something", ID);

oldValue === newValue // true

Hope explanation isn't so bad.

Examples of such events?

Since cacheHandlers returns eg cache.get() things like oldValue, newValue don't work cause of reference.
eg:
const payload = data.d as IDK;
const oldValue = await cacheHandlers.get("something", ID);

await cacheHandlers.set("something", ID, payload);
const newValue = await cacheHandlers.get("something", ID);

oldValue === newValue // true

Hope explanation isn't so bad.

Examples of such events?


Add milestone support

We need to add enable users to attach every task to a milestone by name

Milestone support was partially added but is only active for already created milestones. It doesn't create new milestones.


hello how to fix "too many requests retry in 1 hour from website"

Ripme version:
Java version:
Operating system:

Exact URL you were trying to rip when the problem occurred:
Please include any additional information about how to reproduce the problem:

Expected Behavior
Detail the expected behavior here.
Actual Behavior
Detail the actual (incorrect) behavior here. You can post log snippets or attach log files to your issue report.

You left the template absolutely untouched.

The website he's referring to is ImageFap.
The HTTP status 429 (Too Many Requests) keeps showing in RipMe logs when ripping galleries URLs from a single TXT file (1 gallery URL per line).
I checked the "Save URLs only" option in RipMe configuration in order to perform the downloads with WGET.
Here is my system configuration :
RipMe version : 1.7.93
Java version : 1.8.0_261
Operating System : Windows 10 2004


Makefile: populate cloud for the register_fqdn task based on the value

i.e. if the user uses by default public cloud, if cx.tetrate.info is used than the cloud for the change has to be AWS, if gcp.cx.tetrate.info - GCP and azure.gcx.tetrate.info - Azure.

resolved


Add reference to Unicode section

A little in-place reminder for those who already garbage collected the contents of the "Getting Started" chapter.
EDIT: I put it as part of the first exercise as that should be the first time the issue of inputting special characters arises for anyone working through the book.

My bad, I just noticed that several paragraphs further down, there is the following explanation:

You may have noticed that ℕ and → don't appear on your keyboard.
They are symbols in unicode.  At the end of each chapter is a list
of all unicode symbols introduced in the chapter, including
instructions on how to type them in the Emacs text editor.  Here
type refers to typing with fingers as opposed to data types!

This is a good and more thorough explanation that what I have in this PR, but I daresay it is not well-placed. Could we move this explanation up, near the first exercise?

Moved to issue #958


Header in Enatega Multivendor Admin not performing according to proper UI/UX

Describe the bug
1- Enatega Dashboards Avatar full is not clickable
2- Welcome message is not needed and should be removed
To Reproduce
Steps to reproduce the behavior:

Click on Avatar Icon

Expected behavior
Explained more in this video
https://www.loom.com/share/51774dc7eb7740f0a6088459d3bbfb30

@SharanGoharKhan  I'd like to take this issue if it has not been assigned or fixed already

@Odigietony You can work on it.

fixed


Add a basic test

Start setting up the testing APIs.

Ugh, bitten by my own laziness: Caused by: java.lang.IllegalStateException: Unsupported OS: linux. Will fix that and circle back.


add flux interval enforcement example

This example demonstrates how to ensure consumers of a kubernetes cluster don't slam a cluster's API or some git repositories by configuring flux to sync too frequently. The example also shows how one would enforce argument values in a deployment spec.
Signed-off-by: circa10a<EMAIL_ADDRESS>

@timothyhinrichs addressed your comments, think it is acceptable to merge?


Uncaught Error: ENOENT: no such file or directory, lstat '~/Downloads/Atom.app/Contents/Resources...

[Enter steps to reproduce:]

...
...

Atom: 1.57.0 x64
Electron: 9.4.4
OS: macOS 11.4
Thrown From: codesync package 2.2.0
Stack Trace
Uncaught Error: ENOENT: no such file or directory, lstat '/Users/loca/Downloads/Atom.app/Contents/Resources/app.asar.unpacked/node_modules/github/bin/.git/index.lock'
At internal/fs/utils.js:220

Error: ENOENT: no such file or directory, lstat '/Users/loca/Downloads/Atom.app/Contents/Resources/app.asar.unpacked/node_modules/github/bin/.git/index.lock'
    at lstatSync (fs.js:906:3)
    at Object.fs.lstatSync (electron/js2c/asar.js:235:27)
    at handleFileCreated (/packages/codesync/lib/event_handler.js:60:12)
    at /packages/codesync/lib/codesync.js:23:11
    at Function.simpleDispatch (/private/var/folders/lt/7j0swcl55qb9r1xjjgv_2cxw0000gn/T/AppTranslocation/53D6994B-C07E-46F8-82C4-5A20AAA33B1B/d/Atom.app/Contents/Resources/app/static/<embedded>:11:1186190)
    at Emitter.emit (/private/var/folders/lt/7j0swcl55qb9r1xjjgv_2cxw0000gn/T/AppTranslocation/53D6994B-C07E-46F8-82C4-5A20AAA33B1B/d/Atom.app/Contents/Resources/app/static/<embedded>:11:1187631)
    at s (/private/var/folders/lt/7j0swcl55qb9r1xjjgv_2cxw0000gn/T/AppTranslocation/53D6994B-C07E-46F8-82C4-5A20AAA33B1B/d/Atom.app/Contents/Resources/app/static/<embedded>:11:413570)
    at PathWatcher.onNativeEvents (/private/var/folders/lt/7j0swcl55qb9r1xjjgv_2cxw0000gn/T/AppTranslocation/53D6994B-C07E-46F8-82C4-5A20AAA33B1B/d/Atom.app/Contents/Resources/app/static/<embedded>:14:27018)
    at /private/var/folders/lt/7j0swcl55qb9r1xjjgv_2cxw0000gn/T/AppTranslocation/53D6994B-C07E-46F8-82C4-5A20AAA33B1B/d/Atom.app/Contents/Resources/app/static/<embedded>:14:25754
    at Function.simpleDispatch (/private/var/folders/lt/7j0swcl55qb9r1xjjgv_2cxw0000gn/T/AppTranslocation/53D6994B-C07E-46F8-82C4-5A20AAA33B1B/d/Atom.app/Contents/Resources/app/static/<embedded>:11:1186190)
    at Emitter.emit (/private/var/folders/lt/7j0swcl55qb9r1xjjgv_2cxw0000gn/T/AppTranslocation/53D6994B-C07E-46F8-82C4-5A20AAA33B1B/d/Atom.app/Contents/Resources/app/static/<embedded>:11:1187631)
    at NSFWNativeWatcher.onEvents (/private/var/folders/lt/7j0swcl55qb9r1xjjgv_2cxw0000gn/T/AppTranslocation/53D6994B-C07E-46F8-82C4-5A20AAA33B1B/d/Atom.app/Contents/Resources/app/static/<embedded>:14:23000)
    at watcher.c.debounceMS (/private/var/folders/lt/7j0swcl55qb9r1xjjgv_2cxw0000gn/T/AppTranslocation/53D6994B-C07E-46F8-82C4-5A20AAA33B1B/d/Atom.app/Contents/Resources/app/static/<embedded>:14:24649)

Commands
     -0:09.7.0 grammar-selector:show (atom-text-editor.editor.is-focused)

Non-Core Packages
codesync 2.2.0

Thank you for reporting the issue @queilawithaQ. v.2.3.0 is out with a fix. Please try that.


Hook doesn't find hooking points through passthrough platforms

@DrNeroCF we have two ways to solve the problem:

Not use the tilemap. Use "prefabs" for pass-through platforms, like the HookTarget
Use two tilemaps, one dedicated to the pass-through platforms.

That's because we can't set physics layers per tile in a tileset, instead it's a global setting on the tilemap node. Working around that would require quite a bit of hacky, bug-prone code.
I've tested both and 1. seems most flexible to me as we could draw pretty floating platforms, attach particle effects, animate them a bit... What would you prefer?
In either case you would need to click on the nodes in the Scene docker to switch from one to another.


Refactor analytics service

Context
Nessie's handling for analytics was already good but since I'm already porting the other core functionality, I might as well change everything to reflect the djs template. This project has made me realise I need to update the base template anyway since I never accounted for buttons and subcommands
Every event seems to be working normally:

Change

Remove vscode settings
Refactor analytics handler
Update events

There's probably room for more improvements here. Possibly create the analytics service as a class instead?


[wip] feat(@jest/environment, jest-resolve, jest-runtime): support URL as module specifier in mocking APIs

Fixes #14040
Closes #14297
Summary
The idea is to support URL strings and URL objects as module specifiers in mocking APIs. Recent versions of Node allow URLs almost everywhere where module specifier can be passed. So this feels like a natural step forward. For the beginning I think it is better to focus on mocking APIs only, altho there are other APIs in Jest packages which could take URL.
This PR is based on the ideas I came up while reviewing #14297. I think the problem is not the node: schema, but the fact that jest-resolve was not made to support URL. That is relatively new feature in Node.
For example, currently Jest logic treats node:fs and fs as two separate modules. Adding support for URL specifiers this gets solved. That is not just about stripping node:, but about supporting URL strings.
This also can be useful for ESM where import.meta.url is an URL string. I don’t have any use case, but in theory dynamic mocking and importing based on import.meta.url could be implemented.
Test plan

[x] current tests are passing
[ ] add units tests
[ ] add e2e tests
[ ] add type tests
[ ] documentation

Yeah, this would be awesome! 👍

Thanks for encouragement. I just think my current approach is wrong: ignoring schemes is not the same as to support them. Would be better to use URL strings as module identifiers instead of current module ID logic. That is more or less what Node does in with EMS modules. Worth to give a try.

Using strings as identifiers under the hood sounds like a good idea 👍

This one is rather involving. Can find spare time at the moment.


Implement fs:unix_file_mode(path) XPath function for audit rules.

This function returns the Unix permissions in numeric octal format e.g 0600 for a filesystem path. On Unix platforms this is obtained directly from the filesystem, but on Windows we'd have to manually calculate it from the ACLs.

Added in 9960d4301b37f768bacd4067df8a27505899f5ae.


Crashes when run over SSH or in Docker

When running tccst remotely over SSH it can't get the terminal size and crashes.
ssh server ./tccst code

Assuming the program is placed on server in the home folder and with a folder code containing source code to read.
When running inside a Docker container it doesn't crash but always gets a width and height of 0, exiting with a wrong error that says it couldn't find any source code to read.
docker run --rm -it -v $PWD:/volume tccst

Assuming the program is put in a Docker image with /volume set as workspace folder and $PWD being some code project with Rust source code.

Todo: verify that term size works in Docker when using SSH

So it works for Docker just fine but doesn't with SSH. It works already now by the typical workflow of first logging in via SSH and then running firstly on the machine.
Only if using the run-and-exit style for SSH (like in the issue description) it doesn't work. But this may just be an extra ssh option that's just missing.
Mostly I'm interested in the docker support (wanted to add a Dockerfile to the repo but then stumbled upon this). Did the SSH part only out of curiosity.

Only if using the run-and-exit style for SSH (like in the issue description) it doesn't work. But this may just be an extra ssh option that's just missing.

Does this mean that crossterm shows the correct size is you do run-and-exit style ssh?

No this is the only situation where it doesn't work and you get an error back. You can't even get anything back from the event function as it always fails in this case.

Are you happy for me to close this with a wont-fix tag, as it seems to be an issue outside of this project?

Yeah sure. Just opened this as it would have been nice to provide a Docker image as well.
But I guess most people just install it locally anyways as there is no config file or any extensive setup coming with it.


Cannot vagrant up on Ubuntu 14.04

Ran into this
 gilani@debris: vagrant up
/usr/share/vagrant/plugins/provisioners/docker/plugin.rb:13:in `require_relative': /usr/share/vagrant/plugins/provisioners/docker/config.rb:23: syntax error, unexpected tPOW (SyntaxError)
      def run(name, **options)
                      ^
/usr/share/vagrant/plugins/provisioners/docker/config.rb:43: syntax error, unexpected keyword_end, expecting $end
    from /usr/share/vagrant/plugins/provisioners/docker/plugin.rb:13:in `block in <class:Plugin>'
    from /usr/lib/ruby/vendor_ruby/vagrant/registry.rb:27:in `call'
    from /usr/lib/ruby/vendor_ruby/vagrant/registry.rb:27:in `get'
    from /usr/share/vagrant/plugins/kernel_v2/config/vm_provisioner.rb:34:in `initialize'
    from /usr/share/vagrant/plugins/kernel_v2/config/vm.rb:223:in `new'
    from /usr/share/vagrant/plugins/kernel_v2/config/vm.rb:223:in `provision'
    from /home/gilani/Sandbox/lita-dev/Vagrantfile:60:in `block in <top (required)>'
    from /usr/lib/ruby/vendor_ruby/vagrant/config/v2/loader.rb:37:in `call'
    from /usr/lib/ruby/vendor_ruby/vagrant/config/v2/loader.rb:37:in `load'
    from /usr/lib/ruby/vendor_ruby/vagrant/config/loader.rb:104:in `block (2 levels) in load'
    from /usr/lib/ruby/vendor_ruby/vagrant/config/loader.rb:98:in `each'
    from /usr/lib/ruby/vendor_ruby/vagrant/config/loader.rb:98:in `block in load'
    from /usr/lib/ruby/vendor_ruby/vagrant/config/loader.rb:95:in `each'
    from /usr/lib/ruby/vendor_ruby/vagrant/config/loader.rb:95:in `load'
    from /usr/lib/ruby/vendor_ruby/vagrant/environment.rb:265:in `config_global'
    from /usr/lib/ruby/vendor_ruby/vagrant/environment.rb:519:in `block in action_runner'
    from /usr/lib/ruby/vendor_ruby/vagrant/action/runner.rb:36:in `call'
    from /usr/lib/ruby/vendor_ruby/vagrant/action/runner.rb:36:in `run'
    from /usr/lib/ruby/vendor_ruby/vagrant/environment.rb:283:in `hook'
    from /usr/lib/ruby/vendor_ruby/vagrant/environment.rb:139:in `initialize'
    from /usr/bin/vagrant:105:in `new'
    from /usr/bin/vagrant:105:in `<main>'

Looks like you installed Vagrant with a system package instead of via the official installer from https://www.vagrantup.com/. I believe the official installer is the only supported method. Whatever version you are using is packaged with a version of Ruby older than 2.0.

I see, thanks @jimmycuadra. I'm download the official .deb right now. Will update this thread.

It's also worth noting that if you already have a development environment on your Ubuntu system, you don't really need the Lita development environment at all. It's just supposed to be a self contained system for people who are very new to programming or to Ruby.

That makes sense, but I just wanted to try it out. I'm kinda new to Ruby myself :)
I ran into another error:
vagrant up
Bringing machine 'default' up with 'virtualbox' provider...
==> default: Checking if box 'coreos-stable' is up to date...
==> default: Clearing any previously set network interfaces...
==> default: Preparing network interfaces based on configuration...
    default: Adapter 1: nat
    default: Adapter 2: hostonly
==> default: Forwarding ports...
    default: 22 => 2222 (adapter 1)
==> default: Running 'pre-boot' VM customizations...
==> default: Booting VM...
==> default: Waiting for machine to boot. This may take a few minutes...
The guest machine entered an invalid state while waiting for it
to boot. Valid states are 'starting, running'. The machine is in the
'poweroff' state. Please verify everything is configured
properly and try again.

If the provider you're using has a GUI that comes with it,
it is often helpful to open that and watch the machine, since the
GUI often has more helpful error messages than Vagrant can retrieve.
For example, if you're using VirtualBox, run `vagrant up` while the
VirtualBox GUI is open.

The primary issue for this error is that the provider you're using
is not properly configured. This is very rarely a Vagrant issue.

Hard to say without more information. Usually oddities with the VMs can be resolved by restarting your computer. As horrible as that is, that's pretty much the state of virtual machine software these days.

Faced same issue on Ubuntu 14.04 and vagrant vagrant_1.4.3, after update to vagrant_1.8.1 its working fine for me....

Make sure VT-X Virtualization is enabled in your BIOS.


Empty grey box with text "loading.." when running HiGlass-python

Hi, I am a new user of HiGlass. I am using higlass-python with a jupyter notebook. Our lab has the Higlass server running on one of our machines at the address HTTP://MACHINE-ADDRESS:8989. When I run Higlass client on a juypter notebook on this machine, I don't see the expected widgets, instead, I see the following gray screen with the text "loading..."

I am aware of the issue 1071 and the gray box above results from running the same code and data here: https://github.com/higlass/higlass/issues/1071#issue-1055742734
I made sure that I have clodius>=0.17.1 as described in issue 1071.
However when I do ts.tiles(['x.0.0.0']) as suggested in issue 1071, I get the following error:

My notebook doesn't have access to npmatrix even though I have the right version of clodius. Can you help me figure out when I am doing wrong here?
Packages and versions:
Jupyter notebook Version: 6.4.6
clodius Version: 0.17.1
higlass-python Version: 0.4.4
Thanks!
Anu

Hi, sorry for the delayed reply. Would you mind posting the full code snippet that you're trying to run?
The npmatrix function is defined here: https://github.com/higlass/clodius/blob/develop/clodius/tiles/npmatrix.py


Facts HTML and icons

HTML information and icons added for the 'Facts' section.
CSS for layout and scaling to come in a later pull.

The content looks good. Do those icons have SVG versions we can use instead though?

I will find svgs for you and re-commit.

Update @hedgehog125 - svgs are only available on premium.  Can they stay as pngs? I feel like it's not a great use of my time to hunt through and find different images at this point...

@Jo-Pickering Yeah, PNGs are probably fine. What license are they under though?

This is the site I've gotten them from : https://www.flaticon.com/search?word=ai
I've saved all the links they've given me:
Menu icons created by Freepik - Flaticon
Travel icons created by Freepik - Flaticon
Ai icons created by photo3idea_studio - Flaticon
Fast food icons created by Darius Dan - Flaticon
*also updating 1 image because I didn't have the link saved.

To match with the upcoming credits.md file


feat: add scoutapm 1.9.0 release

update scoutapm with release 1.9.0

:tada: This PR is included in version 1.46.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Implement Wasm proposal: non-trapping-float-to-int-conversions

Closes https://github.com/paritytech/wasmi/issues/355.

Codecov Report

Merging #359 (09752c3) into master (8830ee3) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   78.70%   78.88%   +0.18%
==========================================
  Files          96       96
  Lines       10852    10907      +55
==========================================
+ Hits         8541     8604      +63
+ Misses       2311     2303       -8

Impacted Files
Coverage Δ

tests/spec/v1/mod.rs
100.00% <ø> (ø)

wasmi_v1/src/engine/bytecode/mod.rs
100.00% <ø> (ø)

wasmi_v1/src/module/compile/operator.rs
98.07% <ø> (ø)

core/src/value.rs
67.14% <100.00%> (+1.23%)
:arrow_up:

wasmi_v1/src/engine/code_map.rs
88.18% <100.00%> (+0.41%)
:arrow_up:

wasmi_v1/src/engine/exec_context.rs
96.74% <100.00%> (+0.11%)
:arrow_up:

wasmi_v1/src/engine/func_builder/mod.rs
92.21% <100.00%> (+0.16%)
:arrow_up:

wasmi_v1/src/module/compile/mod.rs
38.07% <100.00%> (+1.42%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8830ee3...09752c3. Read the comment docs.


feat(frontend): Sind function

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Implement the SIND function. This implementation is slightly different from the PSQL implementation. I do not return an error on SIND(Inf), but instead return NaN.

Tracking Issue
PSQL implementation

Checklist For Contributors

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[x] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[x] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[ ] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

SQL commands, functions, and operators

Release note
Implement the trigonometric function Sind

how about uncommenting the following test cases and see if they can also pass

Good idea. I will uncomment the sind tests


[FALSE-POSITIVE]

Domains or links
https://gontop.app
More Information
How did you discover your web site or domain was listed here?

Website was hacked
Incorrectly marked as Phishing on Phishtank or OpenPhish

These both. I have installed GPL plugin in my woocomerce site which added virus in my site. Now I have removed the folder of that site & created my site newly. But virustotal still showing virus in my site.
Have you requested removal from other sources?
Please include all relevant links to your existing removals / whitelistings.
Additional context
I am writing to address an important concern regarding the URL and files associated with https://gontop.app. Our site is completely free of viruses, malware, or any phishing activities. However, it has come to our attention that several URL-checking sites are incorrectly flagging our site as a potential threat.
This information is categorically false. We have thoroughly checked our site and all associated files, ensuring they are secure and safe for users. We request a re-evaluation to rectify these false positives and reflect the true nature of our site's security.
Thank you for your attention to this matter.
:exclamation:
We understand being listed on a Phishing Database like this can be frustrating and embarrassing for many web site owners. The first step is to remain calm. The second step is to rest assured one of our maintainers will address your issue as soon as possible. Please make sure you have provided as much information as possible to help speed up the process.
Send a Pull Request for faster removal
Users who understand github and creating Pull Requests can assist us with faster removals by sending a PR to mitchellkrogza/phishing repository, on the falsepositive.list file

https://github.com/mitchellkrogza/phishing/blob/main/falsepositive.list
Please include the same above information to help speed up the whitelisting process.

I'm not convinced this domain have solved it's issues...

Logger output

+17

gontop.app
1
get
doc
https://gontop.app/

+17

behind-the-scene
0,3
get
xhr
https://[ff00::]/nscl/moz-extension://7f5a4c01-d385-48df-9101-326bb6e1c065/syncMessage?id=e69e2cd70f.9838%2Chttps%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26sol%3DMjA6MTcyMDk1NzE2ODo0NDhhNzQ1YTpmMDdhODVmYmNlMmQ5YzVhM2QwNDBjZjY3ZDM1ODcwODcxZTZiZWMxY2NjNGI0YmZkMGU1ZTRkNWQ3NmRlZmIyOgEZguU%253D%26s%3D1783%3A1098514&url=https%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26sol%3DMjA6MTcyMDk1NzE2ODo0NDhhNzQ1YTpmMDdhODVmYmNlMmQ5YzVhM2QwNDBjZjY3ZDM1ODcwODcxZTZiZWMxY2NjNGI0YmZkMGU1ZTRkNWQ3NmRlZmIyOgEZguU%253D%26s%3D1783%3A1098514&top=true&msg=%7B%22id%22%3A%22fetchChildPolicy%22%2C%22url%22%3A%22https%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26sol%3DMjA6MTcyMDk1NzE2ODo0NDhhNzQ1YTpmMDdhODVmYmNlMmQ5YzVhM2QwNDBjZjY3ZDM1ODcwODcxZTZiZWMxY2NjNGI0YmZkMGU1ZTRkNWQ3NmRlZmIyOgEZguU%253D%26s%3D1783%3A1098514%22%7D

+16

gontop.app
1
get
doc
https://gontop.app/.well-known/sgcaptcha/?r=%2F&sol=MjA6MTcyMDk1NzE2ODo0NDhhNzQ1YTpmMDdhODVmYmNlMmQ5YzVhM2QwNDBjZjY3ZDM1ODcwODcxZTZiZWMxY2NjNGI0YmZkMGU1ZTRkNWQ3NmRlZmIyOgEZguU%3D&s=1783:1098514

+13

behind-the-scene
0,3
get
xhr
https://[ff00::]/nscl/moz-extension://7f5a4c01-d385-48df-9101-326bb6e1c065/syncMessage?id=1056b9d181d.05e%2Chttps%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26y%3Dipr%3A<IP_ADDRESS>%3A1720957167.845&url=https%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26y%3Dipr%3A<IP_ADDRESS>%3A1720957167.845&top=true&msg=%7B%22id%22%3A%22fetchChildPolicy%22%2C%22url%22%3A%22https%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26y%3Dipr%3A<IP_ADDRESS>%3A1720957167.845%22%7D

+13

gontop.app
3
get
image
https://d1rozh26tys225.cloudfront.net/loader.svg

+13

gontop.app
3
get
image
https://d1rozh26tys225.cloudfront.net/robot-suspicion.svg

+12

gontop.app
1
get
doc
https://gontop.app/.well-known/sgcaptcha/?r=%2F&y=ipr:<IP_ADDRESS>:1720957167.845

+12

behind-the-scene
0,3
get
xhr
https://[ff00::]/nscl/moz-extension://7f5a4c01-d385-48df-9101-326bb6e1c065/syncMessage?id=29d11657d0.a126%2Chttps%3A%2F%2Fgontop.app%2F&url=https%3A%2F%2Fgontop.app%2F&top=true&msg=%7B%22id%22%3A%22fetchChildPolicy%22%2C%22url%22%3A%22https%3A%2F%2Fgontop.app%2F%22%7D

+0

gontop.app
1
get
doc
https://gontop.app/

Kindly Check now please. The site is live now.
On Sun, Jul 14, 2024, 5:43 PM spirillen @.***> wrote:

Logger output
+17 gontop.app 1 get doc https://gontop.app/
+17 behind-the-scene 0,3 get xhr https://
[ff00::]/nscl/moz-extension://7f5a4c01-d385-48df-9101-326bb6e1c065/syncMessage?id=e69e2cd70f.9838%2Chttps%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26sol%3DMjA6MTcyMDk1NzE2ODo0NDhhNzQ1YTpmMDdhODVmYmNlMmQ5YzVhM2QwNDBjZjY3ZDM1ODcwODcxZTZiZWMxY2NjNGI0YmZkMGU1ZTRkNWQ3NmRlZmIyOgEZguU%253D%26s%3D1783%3A1098514&url=https%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26sol%3DMjA6MTcyMDk1NzE2ODo0NDhhNzQ1YTpmMDdhODVmYmNlMmQ5YzVhM2QwNDBjZjY3ZDM1ODcwODcxZTZiZWMxY2NjNGI0YmZkMGU1ZTRkNWQ3NmRlZmIyOgEZguU%253D%26s%3D1783%3A1098514&top=true&msg=%7B%22id%22%3A%22fetchChildPolicy%22%2C%22url%22%3A%22https%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26sol%3DMjA6MTcyMDk1NzE2ODo0NDhhNzQ1YTpmMDdhODVmYmNlMmQ5YzVhM2QwNDBjZjY3ZDM1ODcwODcxZTZiZWMxY2NjNGI0YmZkMGU1ZTRkNWQ3NmRlZmIyOgEZguU%253D%26s%3D1783%3A1098514%22%7D
+16 gontop.app 1 get doc
https://gontop.app/.well-known/sgcaptcha/?r=%2F&sol=MjA6MTcyMDk1NzE2ODo0NDhhNzQ1YTpmMDdhODVmYmNlMmQ5YzVhM2QwNDBjZjY3ZDM1ODcwODcxZTZiZWMxY2NjNGI0YmZkMGU1ZTRkNWQ3NmRlZmIyOgEZguU%3D&s=1783:1098514
+13 behind-the-scene 0,3 get xhr https://
[ff00::]/nscl/moz-extension://7f5a4c01-d385-48df-9101-326bb6e1c065/syncMessage?id=1056b9d181d.05e%2Chttps%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26y%3Dipr%3A<IP_ADDRESS>%3A1720957167.845&url=https%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26y%3Dipr%3A<IP_ADDRESS>%3A1720957167.845&top=true&msg=%7B%22id%22%3A%22fetchChildPolicy%22%2C%22url%22%3A%22https%3A%2F%2Fgontop.app%2F.well-known%2Fsgcaptcha%2F%3Fr%3D%252F%26y%3Dipr%3A<IP_ADDRESS>%3A1720957167.845%22%7D
+13 gontop.app 3 get image
https://d1rozh26tys225.cloudfront.net/loader.svg
+13 gontop.app 3 get image
https://d1rozh26tys225.cloudfront.net/robot-suspicion.svg
+12 gontop.app 1 get doc
https://gontop.app/.well-known/sgcaptcha/?r=%2F&y=ipr:<IP_ADDRESS>:1720957167.845
+12 behind-the-scene 0,3 get xhr https://
[ff00::]/nscl/moz-extension://7f5a4c01-d385-48df-9101-326bb6e1c065/syncMessage?id=29d11657d0.a126%2Chttps%3A%2F%2Fgontop.app%2F&url=https%3A%2F%2Fgontop.app%2F&top=true&msg=%7B%22id%22%3A%22fetchChildPolicy%22%2C%22url%22%3A%22https%3A%2F%2Fgontop.app%2F%22%7D
+0 gontop.app 1 get doc https://gontop.app/
—
Reply to this email directly, view it on GitHub
https://github.com/mitchellkrogza/Phishing.Database/issues/898#issuecomment-2227315191,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZJ3Q4YATFV7USFVIFT4SGTZMJP5FAVCNFSM6AAAAABK3A7ET6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGMYTKMJZGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

and is it cleaned for for your fingerprinter? and opened for the public domain to visit? last time you used fingerprinter from cloudflare to prohibit the public internet to access your site and only allow members of the walled garden, which are limiting the number of people who can/will visit your site in the first place and you are loosing costumers.
/.well-known/sgcaptcha/?r=%2F&y=ipr:<IP_ADDRESS>:1720957167.845

Site was on development. There wew virus because of using GPL plugin in
wordpress site. Now its all clear
On Mon, Jul 15, 2024, 6:24 PM spirillen @.***> wrote:

and is it cleaned for for your fingerprinter? and opened for the public
domain to visit? last time you used fingerprinter from cloudflare to
prohibit the public internet to access your site and only allow members of
the walled garden, which are limiting the number of people who can/will
visit your site in the first place and you are loosing costumers.
/.well-known/sgcaptcha/?r=%2F&y=ipr:<IP_ADDRESS>:1720957167.845
—
Reply to this email directly, view it on GitHub
https://github.com/mitchellkrogza/Phishing.Database/issues/898#issuecomment-2228381649,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZJ3Q433ENNTDK3EKQL4HG3ZMO5RLAVCNFSM6AAAAABK3A7ET6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRYGM4DCNRUHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Your domain is still not on the open web and controlled by cloudflare.

I (@spirillen) can help you in https://github.com/mitchellkrogza/phishing/ unless you release the site to the public. As public declared, I no longer accessing the walled garden https://matrix.rocks/notes/9vkszovs0v

No. I am not using cloudflare cdn in my site. Its working for me.
On Mon, Jul 15, 2024, 7:39 PM spirillen @.***> wrote:

Your domain is still not on the open web and controlled by cloudflare.
image.png (view on web)
https://github.com/user-attachments/assets/98366db3-18f2-4acb-b343-76eb664ceaee
I @.*** https://github.com/spirillen) can help you in
https://github.com/mitchellkrogza/phishing/ unless you release the site
to the public. As public declared, I no longer accessing the walled garden
https://matrix.rocks/notes/9vkszovs0v
https://camo.githubusercontent.com/c358b90e1310b7bb95f9941a48eb200df3c6ebe50887431d473f0e167ddd01b5/68747470733a2f2f6f70656e67726170682e6769746875626173736574732e636f6d2f326662383837306461643537353036646364353735616330376535646563316338383062626664336662643537396236623232313236366261616665373131362f6d69746368656c6c6b726f677a612f7068697368696e67
https://camo.githubusercontent.com/95e35b1ddbd18e9680ef4876f3544fdf46e2116b5fefc3f6a48e1e427ea75b59/68747470733a2f2f6769746875622e6769746875626173736574732e636f6d2f66617669636f6e732f66617669636f6e2e737667
GitHub
GitHub - mitchellkrogza/phishing: Central Repository for Adding Domains /
Links to the Phishing.Database project -
https://github.com/mitchellkrogza/Phishing.Database/
https://github.com/mitchellkrogza/phishing
Central Repository for Adding Domains / Links to the Phishing.Database
project - https://github.com/mitchellkrogza/Phishing.Database/ -
mitchellkrogza/phishing
https://camo.githubusercontent.com/6898d8f5894916b38982fc9a8f27ae5138b43d9ac3c9ca3b61a2322577a34811/68747470733a2f2f6d61747269782e726f636b732f66696c65732f38383563623138372d653464322d343032612d616433622d316437643230626639616534
https://camo.githubusercontent.com/6e43990b657b6dfd316be6c92cdc4321489b0fa85d6bf45ebce68b119070376c/68747470733a2f2f6d61747269782e726f636b732f66696c65732f30303539316536342d633135312d346138652d383530312d333138373633313332363666
Matrix Rocks
Jerry Mouse @.*) https://matrix.rocks/notes/9vkszovs0v
Feels god no longer to be slaving for propertarian OS, that Ubuntu have
turned into, withheld update for ransom. This gives the meaning of
#ransomeware a new twist of meaning.
Yes, this gives me back a good feeling in my stomachs, knowing I'm back on
FOSS OS form #Debian, even tho a lot of package are outdated and need
personal actions to get up to date, such as the unbound v1.17 with a lot of
security issues which isn't addressed and fixed until version 1.20, but
that one is still held in the testing (former SID) repo, rather than
getting it released.
And this makes me wondering on how they determine which Alpha releases
should be force down to the stable repo, such as wayland, that can't
recover displey:0 from the sleep state, unless you reboot the system,
while stable releases like unbound are withheld. This would make the first
time experience of Debian as a buggy and not properly maintained distro,
making people running away screaming, only to never come back. Yes, it took
me a couple of days to notice the dropdown on the #SDDM login screen,
allowing me to switch back to good old stable #x11 window system.
Please Debian-devs, set X11 as default windows engine and leave waylands
to the experimental group running on the testing releases. The rest of us
have chosen Debian for stability not a endless counts of total brake downs,
while actually doing literally nothing...
IF you are using Debian stable, please share your stories.
This said, I've become rather firmly determined that no more
packages/apps/programs that gets in touch with the walled
Garden/big5/BigTech surveillance network, will be installed on my network
anymore, this includes and is not limited to Element (Chat client) using
matrix.org network as primary network, this in running over cloudflare.
A few exception would be vsCode and my sponsored IDE's from jetbrains's
opensource license.
Have a nice wet/sunny summer depending on your current location... (Can
see it looks a tad moist somewhere this summer
https://matrix.rocks/notes/9vkrkl6g8z)
#debian #ubuntu #wayland #x11 #internetsecurety #dnsbomb #walledgarden
#cloudflare #big5 #bigtech #anime #rain (📎1)
—
Reply to this email directly, view it on GitHub
https://github.com/mitchellkrogza/Phishing.Database/issues/898#issuecomment-2228530574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZJ3Q45ZI4GJ4EAFIF5A6LTZMPGHPAVCNFSM6AAAAABK3A7ET6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRYGUZTANJXGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Also users are ordering product continuously.
On Mon, Jul 15, 2024, 7:48 PM Saju Chakma @.***> wrote:

No. I am not using cloudflare cdn in my site. Its working for me.
On Mon, Jul 15, 2024, 7:39 PM spirillen @.***> wrote:

Your domain is still not on the open web and controlled by cloudflare.
image.png (view on web)
https://github.com/user-attachments/assets/98366db3-18f2-4acb-b343-76eb664ceaee
I @.*** https://github.com/spirillen) can help you in
https://github.com/mitchellkrogza/phishing/ unless you release the site
to the public. As public declared, I no longer accessing the walled garden
https://matrix.rocks/notes/9vkszovs0v
https://camo.githubusercontent.com/c358b90e1310b7bb95f9941a48eb200df3c6ebe50887431d473f0e167ddd01b5/68747470733a2f2f6f70656e67726170682e6769746875626173736574732e636f6d2f326662383837306461643537353036646364353735616330376535646563316338383062626664336662643537396236623232313236366261616665373131362f6d69746368656c6c6b726f677a612f7068697368696e67
https://camo.githubusercontent.com/95e35b1ddbd18e9680ef4876f3544fdf46e2116b5fefc3f6a48e1e427ea75b59/68747470733a2f2f6769746875622e6769746875626173736574732e636f6d2f66617669636f6e732f66617669636f6e2e737667
GitHub
GitHub - mitchellkrogza/phishing: Central Repository for Adding Domains
/ Links to the Phishing.Database project -
https://github.com/mitchellkrogza/Phishing.Database/
https://github.com/mitchellkrogza/phishing
Central Repository for Adding Domains / Links to the Phishing.Database
project - https://github.com/mitchellkrogza/Phishing.Database/ -
mitchellkrogza/phishing
https://camo.githubusercontent.com/6898d8f5894916b38982fc9a8f27ae5138b43d9ac3c9ca3b61a2322577a34811/68747470733a2f2f6d61747269782e726f636b732f66696c65732f38383563623138372d653464322d343032612d616433622d316437643230626639616534
https://camo.githubusercontent.com/6e43990b657b6dfd316be6c92cdc4321489b0fa85d6bf45ebce68b119070376c/68747470733a2f2f6d61747269782e726f636b732f66696c65732f30303539316536342d633135312d346138652d383530312d333138373633313332363666
Matrix Rocks
Jerry Mouse @.*) https://matrix.rocks/notes/9vkszovs0v
Feels god no longer to be slaving for propertarian OS, that Ubuntu have
turned into, withheld update for ransom. This gives the meaning of
#ransomeware a new twist of meaning.
Yes, this gives me back a good feeling in my stomachs, knowing I'm back
on FOSS OS form #Debian, even tho a lot of package are outdated and need
personal actions to get up to date, such as the unbound v1.17 with a lot of
security issues which isn't addressed and fixed until version 1.20, but
that one is still held in the testing (former SID) repo, rather than
getting it released.
And this makes me wondering on how they determine which Alpha releases
should be force down to the stable repo, such as wayland, that can't
recover displey:0 from the sleep state, unless you reboot the system,
while stable releases like unbound are withheld. This would make the first
time experience of Debian as a buggy and not properly maintained distro,
making people running away screaming, only to never come back. Yes, it took
me a couple of days to notice the dropdown on the #SDDM login screen,
allowing me to switch back to good old stable #x11 window system.
Please Debian-devs, set X11 as default windows engine and leave waylands
to the experimental group running on the testing releases. The rest of us
have chosen Debian for stability not a endless counts of total brake downs,
while actually doing literally nothing...
IF you are using Debian stable, please share your stories.
This said, I've become rather firmly determined that no more
packages/apps/programs that gets in touch with the walled
Garden/big5/BigTech surveillance network, will be installed on my network
anymore, this includes and is not limited to Element (Chat client) using
matrix.org network as primary network, this in running over cloudflare.
A few exception would be vsCode and my sponsored IDE's from jetbrains's
opensource license.
Have a nice wet/sunny summer depending on your current location... (Can
see it looks a tad moist somewhere this summer
https://matrix.rocks/notes/9vkrkl6g8z)
#debian #ubuntu #wayland #x11 #internetsecurety #dnsbomb #walledgarden
#cloudflare #big5 #bigtech #anime #rain (📎1)
—
Reply to this email directly, view it on GitHub
https://github.com/mitchellkrogza/Phishing.Database/issues/898#issuecomment-2228530574,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZJ3Q45ZI4GJ4EAFIF5A6LTZMPGHPAVCNFSM6AAAAABK3A7ET6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRYGUZTANJXGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Not in the list. Closing.


lobster: init

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I might maintain the package at some point, for now I'm still exploring it.

I tested this, it works. would be happy if you would also maintain it?


Handle browserstack use-case better

For browserstack we have to start only remote web driver, let’s adjust driver factory and if selenium_url contains hub.browserstack.com then don’t start android or ios driver.

done. if hub.browserstack.com detected as part of selenium url we will start mobile drivers via
driver = new RemoteWebDriver(new URL(seleniumHost), capabilities);

verified by customer


Better title cutting

Would super love to not use the emojis library but it seems like emojis don't really have a single block in unicode.
Ofc we could just include a static list of emojis or reference an external list

hmm, why would negating [A-Za-z0-9] not work?

merged into AddderBot https://github.com/feederbox826/mass-hash/commit/4bb6379795c6ea465d61e41f9c92db53068187be


Added a bot test mode

Added the ability to run the emulator in "bot test mode" if the environment BOT_UNDER_TEST is set to an email of one of the identities specified in tokens.json.  When this occurs the emulator will intercept responses sent to test requests that have an X-Bot-Responses header.  It will wait until it gets requests from the BOT_UNDER_TEST and build a consolidate response body so that that a test framework can inspect the bot requests that were generated in response to any given test input.

I'll need more background here certainly. Can you provide an example of how this feature would be used.
If something needed to tweak or consolidate payload depending on HTTP Headers, I would opt for a proxy architecture, such as the one I created for the webhook-affinity proxy
If a bot test framework was to be built, I would suggest to add an instrumentation mode (which is certainly close to the BOT_UNDER_TEST env proposed here), so that the emulator would send real-time notifications, or may be add some kind of "monitor feature" like Spark has for Cisco internal needs. Again let's start from a sample of what needs to be achieved.

Here's a project with an example:  https://github.com/jpjpjp/bot-test-framework-example

Note: I've integrated the non bot-test related parts of the PR:

the PUT /memberships/:id not implemented


InflatePaths

hello
Paths64 InputPoly = {V1, V2, V3};
Paths64 OutputPoly = InflatePaths(InputPoly , -20, JoinType::Miter, EndType::Polygon, FLT_MAX);

I want to generate an indented polygon using this function. Is there any way to ensure that the vertices of InputPoly and OutputPoly are in the same order?

Vertex order should be preserved.
However, for closed paths, output (solution) paths will commonly start at different vertices to the input paths.

How do I keep the same order as OutputPoly from InputPoly

e.g.
Paths64 OuputPoly = InflatePaths(InputPoly , -20, JoinType::Miter, EndType::Polygon, FLT_MAX);

InputPoly: (0, 0) (600, 0) (300, 250) (600, 500) (0, 500)
I want to get the same order as InputPoly: (20, 20) (545, 20) (269, 250) (545, 480) (20, 480)
but i get OuputPoly: (545, 20) (269, 250) (545, 480) (20, 480) (20, 20)

Is there any way to do that? thanks.

It's as I said above.

I'm sorry, but I don't understand what you mean
‘Vertex order should be preserved’ How do I preserve the order of the vertices?

Let's say your input polygon is ordered 0,1,2,3,4,5.
Then as an example (and assuming mitered joins) your output polygon could be ordered 3,4,5,0,1,2 (but not 3,2,1,0,5,4).

Sorry, you'll have to work that out yourself.

Well, thanks for the answer


feat: add markdown support for app description

Adds Markdown support for App description using react-markdown.
This is currently only a client-side addition, as we are not doing any validation server-side. However it should be safe, since react-markdown is safe by default.
I've added a simple Preview-tab when editing the description. I don't think a WYSWIG-editor is needed for now, since basic markdown is pretty simple. But it could be something we could improve upon later.
We should however probably mention that the description supports markdown, and maybe link to a resource?
I've set some styles to prevent abuse of eg. headers, so they cannot dominate other headers on the page.

Having a sentence indicating Markdown support would be a good, easy improvement here.

Also, very minor, but I find the chosen component names a little bit out of the ordinary. I think the main problem is that they read like verbs instead of nouns. I tend to use these rules when naming a component:

I guess, and normally I would probably agree. But I just followed the already established convention in the app. As you can see it's divided into pages like UserApp and UserAppEdit - to differentiate the different pages - edit mode and non-edit mode. But I can change these.
Regarding Summarise I agree, and this was just due to me rewriting a function to a component, and I should probably have called in Summary. But it's a generic component, so AppDescriptionSummary is too concise.
Not sure what AppDescriptionTextArea would refer to? WriteContent and PreviewContent refer to the tab-names and I think the names for those are fine.


fix(errors): Handle randomness generation and invalid random values as errors in cryptographic code

Motivation
We want to avoid some panics in some cryptography code. There are some specific problems that were pointed by the audit.
This should close https://github.com/ZcashFoundation/zebra/issues/6338
The code modified here is currently not used but we expect to use it in the future and we will want to avoid panics.
Solution
Most related code use a string as an error with this pattern.
However, this is not always possible, for example if you want to do that here you will get the following compiler error:
inherent associated types are unstable
see issue #8995 <https://github.com/rust-lang/rust/issues/8995> for more information

So i think that limitation might be the cause of not using try_fill_bytes() in the first place.
What is needed is our own errors for handling this and that is what this PR tries to do.
I think all the string errors should be eventually refactored to this but i didnt wanted to do that here as it will be too intrusive so i just fixed what was pointed by the audit ticket.
Review
I think anyone can review, the names chosen could be improved maybe.
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?

[ ] Does it change concurrent code, unsafe code, or consensus rules?

[ ] How do you know it works? Does it have tests?

Follow Up Work
Add errors for all string errors used inside zebra-chain ?

Looks great, thanks for making minimal changes!
I'd just like to check a few cryptographic details.

I'm not sure we're going to be able to get a cryptography review until after RWC and/or Easter so this may have to move to Sprint 8

I'll review this.

This is waiting for a final review from Deirdre when she gets back.

@oxarbitrage @upbqdn @teor2345 I made some suggestions in https://github.com/ZcashFoundation/zebra/pull/6385/commits/ed6596a1b8c591872ec8d731d343978d04a87a53, lmk what you think?

I question the idea that we want to avoid a panic when a cryptographic RNG fails. https://github.com/ZcashFoundation/zebra/issues/6338#issuecomment-1514918706


ruff server now supports commands for auto-fixing, organizing imports, and formatting

Summary
This builds off of the work in https://github.com/astral-sh/ruff/pull/10652 to implement a command executor, backwards compatible with the commands from the previous LSP (ruff.applyAutofix, ruff.applyFormat and ruff.applyOrganizeImports).
This involved a lot of refactoring and tweaks to the code action resolution code - the most notable change is that workspace edits are specified in a slightly different way, using the more general changes field instead of the document_changes field (which isn't supported on all LSP clients). Additionally, the API for synchronous request handlers has been updated to include access to the Requester, which we use to send a workspace/applyEdit request to the client.
Test Plan
https://github.com/astral-sh/ruff/assets/19577865/7932e30f-d944-4e35-b828-1d81aa56c087

(This is in draft because I'd like to hold off reviews until the downstream PRs are merged in, and also because I still need to make a test plan video for this)

Sorry for jumping in on a Draft PR. Before publishing, would you mind explaining what happens for editors not supporting the changes field?

the most notable change is that workspace edits are specified in a slightly different way, using the more general changes field instead of the document_changes field (which isn't supported on all LSP clients).

Sorry for jumping in on a Draft PR. Before publishing, would you mind explaining what happens for editors not supporting the changes field?

It's the document_changes field that isn't supported on all clients. changes should have universal support.
From the LSP specification:
If a client neither supports `documentChanges` nor `workspace.workspaceEdit.resourceOperations`,
then only plain `TextEdit`s using the `changes` property are supported.

Would you mind explaining the reasoning behind this

This involved a lot of refactoring and tweaks to the code action resolution code - the most notable change is that workspace edits are specified in a slightly different way, using the more general changes field instead of the document_changes field (which isn't supported on all LSP clients).

From the LSP specification

A workspace edit represents changes to many resources managed in the workspace. The edit should either provide changes or documentChanges. If the client can handle versioned document edits and if documentChanges are present, the latter are preferred over changes.

So it seems we should be using documentChanges when we can.

The main reason I switched from documentChanges to changes was over concerns about supporting older versions. I think what I'll do is refactor our code to support documentChanges but use changes as a fallback.

You're probably right that changes could be supported without issue. My general policy with features tied to client capabilities is that we should have a fall-back in case that capability doesn't exist, but I should reconsider whether that makes sense going forward. I'm going to err on the side of backwards compatibility for now.


Black screen fade in/out

First of all thanks for this awesome plugin !
Is it possible to show and hide the loading screen with a black screen fade in/out effect ?

Hi, it is not possible at the moment.

Thank you for your answer. Good luck !

Hi, You can do the fade in effect before you call open level. And fade out your loading screen after the map loaded.
@MetalMarmotte


Fix map product preview not showing.

[x] joeferner
[x] mwizeman joeybrk372 jharwig sfeng88

Also Removes viewport restoring when switching clients (was only client.) This matches graph behavior as that was removed in 4.0, and was bugging. Added an enhancement to add
back with persisting across session the viewport. The product will simply fit when opened.
Viewport still saves to store for the map search popover.
Points of Regression: Map previews
CHANGELOG
Fixed: Map product previews not showing

LGTM


Stop using pickles

Pickle is insecure (in the sense that a one shouldn't unpickle pickles from untrusted machines) and may be abused for hiding malicious code. I guess that they at least should not be shipped but should be generated on user's machine. But the better solution may be to eliminate them at all.

Are you referring to pickled data in the pdfminer/cmap directory?  That's basically a set of data constants that is part of the code.  If strangers can modify files in your site-packages directory (or wherever you install pdfminer) then they can modify the code as well.  I don't see how pdfminer using pickles in this way exposes a security risk.
If you're referring to some other use of pickles then please explain.

If strangers can modify files in your site-packages directory (or wherever you install pdfminer) then they can modify the code as well.

Yes,  but there is lot of buts. I'ts an ideal place to hide a backdoor which cannot be found by just diffing and grepping. They can also be used to place a backdoor by a compromised python installation stealthy. They also have some compatibility issues. If you wanna keep the pickles, they should be created on local machine of the one installing pdfminer.

Certainly your points about inspectability and compatibility are reasonable.  Personally I'm not fond of the pickles anyhow.  Not sure why these aren't just .py files, letting them compile to .pyc on first use.  But that would need removal of $CMAP_PATH otherwise it's another vector for code injection.


Add Cirrus Assessment to pledges

New PR following many changes after submitting PR https://github.com/opentffoundation/manifesto/pull/61

@ZIJ new PR turned out to be easier (I've abandoned PR https://github.com/opentffoundation/manifesto/pull/61)


halp1111!

when i launch tf2 with fedoraware and join casual i cant to anything just spectate pls halp fedora users with wisdom!!

you should press E or SPACE

how that fix

its just lets you to play normally

without you being stucc spectating?

yes

yay thanks i will try

what ur discord

THANK YOU VERY MUCH!!!!!!1!

it still persist noo

did it worked first time?

yes

but now no

retry in console then try again

ok

thanks again

ok