Feature card: Theming

Detailed description
This component right now isn't 100% themable. We need to make sure we add the right dependencies and such and make sure we're using the proper tokens so it can be themed properly.
Example in UseCase pattern

Additional information

FeaturedLink Functional Specs
Carbon color tokens

Additional information

[ ] Correct theme in UseCase pattern
[ ] theme mixin like other patterns
[ ] uses correct color tokens
[ ] Knobs to change theming of

The feature card should not include theming options at this time.  We will be creating a separate issue to fix the feature card for high contrast.  Closing.


'dotnet' is not recognized as an internal or external command, operable program or batch file.

Problem encountered on https://dotnet.microsoft.com/en-us/learn/dotnet/hello-world-tutorial/install
Operating System: windows
I ran into the "'dotnet' is not recognized as an internal or external command,
operable program or batch file" issue after install dotnet on my system. My operating system version is windows 10 Pro 64-bit (10.0 Build 19043)

Did you successfully install the .NET SDK? It should be somewhere under "Program Files/Dotnet". You can check the installation @imohweb


Member Prediction wrong in Typescript Code....

I've the following Typescript Code:
(I only show parts of the class)
export enum ParserState {
    None,
    ParseBinary,
    ParseMember,
    ParseBinaryNoMember,
}
export class ExpressionToFilterElementParser extends ExpressionVisitor {

	state: ParserState;

	protected override visitBinaryExpression(binaryExpression: BinaryExpression) {
		this.currentFilterElement.FilterType = getOperationType(binaryExpression.operator);
		this.state = ParserState.ParseBinary;
		if (!this.visit(binaryExpression.left))
			return false;

		if (this.state == ParserState.ParseMember)
			this.state = ParserState.ParseBinaryNoMember;
		if (!this.visit(binaryExpression.right))
			return false;

		return true;
	}

	protected override visitMemberExpression(memberExpression: MemberExpression) {
		if (this.state == ParserState.ParseBinary || this.state == ParserState.ParseMember) {

			this.state = ParserState.ParseMember;

			this.visit(memberExpression.object);
			this.currentFilterElement.FilterField += '.'
			this.visit(memberExpression.property);
		}
		return true;
	}
}

Typescript complains that in line
   if (this.state == ParserState.ParseMember)
            this.state = ParserState.ParseBinaryNoMember;

the condition always returns false, cause ParserStates do not overlap. But the call to this.visit two lines before could modify the state of this.state

le sigh
#9998

https://github.com/microsoft/TypeScript/issues/44336#issuecomment-859070807

I will fix the issue in the evening, sorry

@MartinJohns
Sorry, for doing it wrong (again). Hopfully it's better so

When I see how mayn issues there are linked in #9998, wouldn't it be better to disable the FlowAnalysis (at least after function calls wich could modify state) as default, and enable it via setting?
Or introduce a way to mark functions if they have side effects or not.

#9998 itself explains why that would be a bad idea: TS would have to assume every single function call modified your local state and reset all your narrowings, making CFA practically useless.
mad for the side effect annotation, see #7770.

i think it's mostly useless since in classes most methods would modify the state of a class variable. If not, it does not need to be a method of the class? (if it is a function, then this maybe could be different, but i would not asume so)


StyleGuide - Naming

Consider clarifying what we mean by "symbol" here. Not all devs may be familiar with this term as used in this context.

I agree on this, but not sure "where" we should do it.

We can put it on the glossary and link it in the guide at least the first time.

Or in the naming overview, where we first use it.

Having a glossary definitely sounds like a good idea. Where the first usage of the term symbol is, we can refer to the glossary to keep things DRY.
// cc @johnpapa


Should get_requires_for_build_editable return (at least) ["pip>21.3"]?

Editable installs via pip<21.3 require a setuptools based build. Otherwise you'll get errors like:
ERROR: File "setup.py" or "setup.cfg" not found. Directory cannot be installed in editable mode: /Users/isaac/github/anndata
(A "pyproject.toml" file was found, but editable mode currently requires a setuptools-based build.)

Would this be solved by having get_requires_for_build_editable to add "pip>21.3" to requirements?

I don't think so, because older versions of pip won't look at get_requires_for_build_editable, so it won't help them. :wink: Even if they did, it would only be installed in the temporary build environment.
More philosophically, part of the aim of standardising editable installations is that you don't necessarily have to use pip at all - you could implement another frontend which can use the same mechanisms. (I'm not sure there's really any point for editable installs, but even so...)

I don't think so, because older versions of pip won't look at get_requires_for_build_editable

Ah yeah, fair. Is there a way to even specify this? I think older versions of pip may just fail before looking at any requirements.

More philosophically, part of the aim of standardising editable installations is that you don't necessarily have to use pip at all - you could implement another frontend which can use the same mechanisms

I like that we can tell new contributors for a set of packages that you create an dev install with pip install -e, and we don't have to care about standardising on a build backend.

I'm not sure there's really any point for editable installs

Would you consider the symlink install editable?

Is there a way to even specify this?

The mechanism for editable installs was only standardised recently. Before that it was just a setuptools feature that pip knew about. Creating a setup.py which gives a helpful error message for python setup.py develop might do it - I don't know exactly what pip does if there's both pyproject.toml and setup.py.

Would you consider the symlink install editable?

In case it wasn't clear, I meant there's not much point creating an alternative frontend for editable installs, as I think pip install -e . covers the only thing you'd want it for. I can definitely see the use of editable installs in general.
I do consider the symlink install as a variant of editable installation. Unfortunately, it's one that's not possible with the new standard mechanism.


Dataset needing

Hi everyone,
there are many datasets used in this book, but I didn't see source page links attached in the content. Could someone share those dataset please? Thank you!

Have you got it? If so, can you share?

Hi folks, sorry about the long delay in my response. We do not own the rights to those datasets, hence we can not include them in this repo. We provided links to the datasets where we could, but those may be out of date now as well. I think the best course of action is to search for those datasets and download them from scratch. Sorry, we did not have a good solution to the problem.

Hi folks, sorry about the long delay in my response. We do not own the rights to those datasets, hence we can not include them in this repo. We provided links to the datasets where we could, but those may be out of date now as well. I think the best course of action is to search for those datasets and download them from scratch. Sorry, we did not have a good solution to the problem.

Thank you，Alice!

Have you got it? If so, can you share?

Not yet, I am gonna looking for it by myself


Fix issues with documentation comments [phab:D435]

Created by zarko at 2015-07-28 23:38:37:
(Amusingly,) the indexer will complain about
visibility rules if private members are mentioned
in comments. Turn that off.
Also protect against an assertion about performing
lookups in linkage specs.

shahms accepted this revision at 2015-07-28 23:52:02

zarko closed via commit 5deadc9d33b369a850f0383604c4b667ab431a6b at 2015-07-28 23:52:58


Msgpack upgrade

upgrade msgpack, removes a lot of compiler warnings and should allow us to switch to a newer C++ standard

Coverage remained the same at 96.233% when pulling 0cbfce2e615d28127931e26f5da88e11028adcf7 on hendrikmuhs:msgpack-upgrade into 2dc9b3fe4188e9b56515701eafd0bcd2de8bd6cc on KeyviDev:master.


Can't find variable: ControlPanel

Is this one of the two demos from this repo?  Your own project?  Posting a red error screen without any context isn't very useful.  If I had to guess, perhaps you have a missing import or a typo in the variable name (i.e. controlPanel vs. ControlPanel).  If you shared some of the code then someone can see what may be happening.

import React from 'react';
import Drawer from 'react-native-drawer'
import { StyleSheet, Text, View } from 'react-native';
export default class App extends React.Component {
closeControlPanel = () => {
this._drawer.close()
};
openControlPanel = () => {
this._drawer.open()
};
render () {
return (
<Drawer
ref={(ref) => this._drawer = ref}
content={}
>

)
}
}

`import React from 'react';
import Drawer from 'react-native-drawer'
import { StyleSheet, Text, View } from 'react-native';
export default class App extends React.Component {
closeControlPanel = () => {
this._drawer.close()
};
openControlPanel = () => {
this._drawer.open()
};
render () {
return (
<Drawer
ref={(ref) => this._drawer = ref}
content={}
>

)
}
}
`

`import React from 'react';
import Drawer from 'react-native-drawer'
import { StyleSheet, Text, View } from 'react-native';
export default class App extends React.Component {
closeControlPanel = () => {
this._drawer.close()
};
openControlPanel = () => {
this._drawer.open()
};
render () {
return (
<Drawer
ref={(ref) => this._drawer = ref}
content={}
>

)
}
}`

`import React from 'react';
import Drawer from 'react-native-drawer'
import { StyleSheet, Text, View } from 'react-native';
export default class App extends React.Component {
closeControlPanel = () => {
this._drawer.close()
};
openControlPanel = () => {
this._drawer.open()
};
render () {
return (
<Drawer
ref={(ref) => this._drawer = ref}
content={}>

)
}
}`

@brije111 I saw some email traffic that you had posted some code, but I don't see it here... did you resolve your issue?

I tried to post code many times but when I paste the code in this box It looks good but when I submit, I get some line or part of my code not visible. Sorry for the email traffic you got. I was not aware of this that you will get new email on every comment that I've tried and deleted immediately. So now I'm posting screenshot of my code. Please have a look

Line 16: content={<ControlPanel />}
You need to either define ControlPanel as a new class in App.js, or import it in order to use it. Same goes for MainView on line 18.

**ControlPanel ** is not defined ,so came the error .


Automatic log file uploading on critical error

As title says. Unsure how it would be implemented.
Possibly a hard-coded discord webhook url? Probably not the best way to go about it.

Decided against this because critical errors can vary from anything as small as an invalid cookie to as major as a total code breakage.


Add polyglot support for service proxy stub implementations

Please consider adding this capability, or some alternative to the ServiceProxy concept that enables polyglot implementations of services. We have a few event bus interfaces that can only be specified on paper because the implementations are javascript.

Service Proxies leverage on the codegen project so they should work with all supported languages if i'm not mistaken.

As a reference see:
https://github.com/pmlopes/kambi-2016/blob/master/data-storage-client/src/main/resources/Client.groovy
https://github.com/pmlopes/kambi-2016/blob/master/frontend/src/main/resources/server.js#L13
They are both Groovy and JS proxies of:
https://github.com/pmlopes/kambi-2016/blob/master/data-storage-service/src/main/java/io/vertx/workshop/data/DataStorageService.java

@pmlopes the client yes, but not the implementation. Service proxies are based on Java interface. This concept does not really exist in some language such as ... JavaScript.

@chefhoobajoob @cescoffier you're right I didn't read the issue properly.

I was thinkering on this and managed to get it working in a "hackish" way:
https://github.com/pmlopes/vertx3-nashorn.next/blob/master/services/src/main/resources/service.js
The interface defines the API and then the JS verticle implements it.


Increase the numbers of beta users

[x] Invite beta testers in the 3 month plans blog post
[ ]  Ask randomly users if they want to join beta action. Offer swag for active users.

Let's keep a flag that shows if the user has seen the suggestion. The aim is to actually in different times show every user at least once the opportunity to switch to the Beta channel.

we could add a flag to user record in desktop app local database?

need a mockup of the window that asks user if they want to join beta

wheres the mockup?

Let's keep it simple. No fancy hovering things, just a simple alert showing some text.

me gusta


[$250] Description hint no limit

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.46-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728384374955399
Action Performed:

Create a workspace
Go to workflows and enable rules
Go to categories page and select any item
Enable Require description
Set 'Description hint' with a long params

Expected Result:
Like other descriptions, we should set the limit to 1000 characters.
Actual Result:
With a lot of characters (about over 10000), can still submit the form.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/3660cb8b-05e8-489e-83b5-12d76298cd55
https://github.com/user-attachments/assets/30c72ed4-5eb7-45ff-84df-af4d14a9e9de

Add any screenshot/video evidence

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021843818784644336369
Upwork Job ID:<PHONE_NUMBER>644336369
Last Price Increase: 2024-10-09

Issue OwnerCurrent Issue Owner: @Pujan92

Proposal
Please re-state the problem that we are trying to solve in this issue.
Category Description Hint currently has no character limit.
What is the root cause of that problem?
We haven't added a maxLength to the hint input, nor are we showing any error during validation. As a result, any number of characters can be added to the input.
What changes do you think we should make in order to solve the problem?
We have two options to address this:

Add a maxLength to commentHint input.

https://github.com/Expensify/App/blob/bdc3a157b5504f05ae2c0a56555de2c8839c21cf/src/pages/workspace/categories/CategoryDescriptionHintPage.tsx#L67-L69
maxLength={CONST.WORKSPACE_CATEGORY_DESCRIPTION_HINT_LIMIT}

Add the validate function to FormProvider, where we return an error for the commentHint key if values.commentHint exceeds the character limit.

Something like this:
https://github.com/Expensify/App/blob/bdc3a157b5504f05ae2c0a56555de2c8839c21cf/src/pages/workspace/categories/CategoryDescriptionHintPage.tsx#L55-L56
validate={validate}

const validate = (values: FormOnyxValues<typeof ONYXKEYS.FORMS.WORKSPACE_CATEGORY_DESCRIPTION_HINT_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.WORKSPACE_CATEGORY_DESCRIPTION_HINT_FORM> => {
    const errors = {};
    const categoryDescriptionLength = ReportUtils.getCommentLength(values.commentHint);
    if (categoryDescriptionLength > 50) {
        ErrorUtils.addErrorMessage(errors, 'commentHint', translate('common.error.characterLimitExceedCounter', {length: categoryDescriptionLength, limit: 50}));
    }

    return errors;
};

As for the character limit, we can check if the backend has set any constraints for commentHint. If not, I feel a limit of 50 or 100 characters should be sufficient for hint text. However, we can finalize this after further discussion.
What alternative solutions did you explore? (Optional)

Hi, just dropping by because I found this issue on upwork. I see that you already have proposals that would work, but are all frontend solutions which is half of the fix. While a frontend fix is great for honest mistakes and and efficient, the backend should also reject any long entries that make its way through. It's important for security reasons because your backend could be vulnerable to very low level attacks. At the very least, make sure to check to see that your database has a character limit

@abzokhattab's proposal of providing the maxLength prop looks fine to me for this issue.
🎀👀🎀 C+ reviewed

@RachCHopkins or @dukenv0307 (since you reported this), do you know where the "Description hint" is used? I went thought the testing steps and I don't see the hint when I'm creating an expense or editing it.

@dukenv0307 I'm assuming this is some special dev version here, because I was the same. I figured with so many proposals I was the only person who didn't have the Hint on their version. Can you confirm, please?

I was trying to confirm that there was a real issue with not limiting the hint... but if it is not used anywhere yet I would just HOLD on trying to fix something that is not really broken.

@aldo-expensify I believe it is raised because for each input we are specifying the length restriction and for many description fields I see that 1000 limit is applied. May be it is for the consistency but I am not sure though.
https://github.com/Expensify/App/blob/4c90d62a6a56ff0000031eceeb9195d30a041a8a/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersDescriptionPage.tsx#L60
https://github.com/Expensify/App/blob/4c90d62a6a56ff0000031eceeb9195d30a041a8a/src/pages/tasks/NewTaskDescriptionPage.tsx#L51-L53
It is shown on the category details page.

Closing!


Use clang-15 to compile eBPF files

While working on https://github.com/inspektor-gadget/inspektor-gadget/pull/1448 @wedaly found that there was a verifier error with older clang versions. So, we decided to update and use clang-15.

I'll manually push the ebpf-builder image once we merge this PR.


Google Tag Manager Invalid HTML, CSS or JavaScript.

Firstly, thanks a lot!
Copied the snippet to a new tag in Google Tag Manager.
<script<EMAIL_ADDRESS>        integrity="sha384-4iJteL1FYnj4Ju83AJvNthpx5gZ1QaXCamXhY3lxhAjTNXUN+NXq5LQV/fXOSRme" type="module" crossorigin defer />
Seems to be the integrity parameter. Any suggestions?

Interesting. Does it fine after removing the integrity="..." part?

Thanks for taking the time to reply @weebney. Yes, it works if I remove the integrity flag.

Okay, this one is weird. GTM is correct about what your tag being invalid- in standard HTML, <script> tags can not be self closing (i.e. <script />). As for why removing the integrity hash fixes this, I have no idea, but you should probably correct it for the sake of correctness. Below is what you should copy paste as a replacement. Still super weird, though.
<script<EMAIL_ADDRESS>integrity="sha384-4iJteL1FYnj4Ju83AJvNthpx5gZ1QaXCamXhY3lxhAjTNXUN+NXq5LQV/fXOSRme" type="module" crossorigin defer></script>


Shrinking a Pixmap with interpolation / smoothing.

I am trying to shrink Pixmaps with interpolation.
In the docs it says I can use this to get smooth resizing with pixmap.drawPixmap(...):
Pixmap.setFilter(Pixmap.Filter.BiLinear);

When I tested this, I could produce a nice interpolated image when the size is increased, but if the size is reduced, the results look identical to when Pixmap.Filter.NearestNeighbour is used. I.e. no smoothing.
Is this a bug or a feature with the Pixmap.Filter.Bilinear? Am I doing something wrong? Is there maybe an alternative way of shrinking Pixmaps smoothly?
Thanks!

https://github.com/libgdx/libgdx/wiki/More-Info

I've just figured out this is the same issue as previously reported in #2923, apologies.
I made a small example app and put it in that thread


[Concurrency] Initialize local variable in `tryDiagnoseExecutorConfor…

…mance`
Resolves: rdar://108458906

@swift-ci please smoke test

@ktoso Could you please add a test-case for this too?

@swift-ci please smoke test macOS platform

Thanks a lot! I'll see if I can figure out a way to test this

@swift-ci please smoke test


Errors on key up

script.mjs:57 Uncaught TypeError: Cannot read properties of undefined (reading 'center')
[Detected 1 package: token-lean]
    at enableLean (script.mjs:57:43)
    at Object.onUp (script.mjs:41:13)
    at Function._executeKeybind (foundry.js:1629:58)
    at KeyboardManager._processKeyboardContext (foundry.js:1669:33)
    at KeyboardManager._handleKeyboardEvent (foundry.js:1707:10)
    at foundry.js:1362:54

This happens with and without token being selected.

This doesn't seem to be a problem anymore. Thanks for the report anyway.


Fixed secondary video on realtek

Summary: Fixed secondary video on realtek
Type: Fix
Test Plan: Unittests, Component tests, YT conformance tests
Jira: RIALTO-521

https://jenkins.code.rdkcentral.com/job/github-triggered/50349/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/15142/ started

https://jenkins.code.rdkcentral.com/job/build-component/89636/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/21905/ started.

https://jenkins.code.rdkcentral.com/job/build-component/89637/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/21906/ started.

Sanity tests for ['RPI4 Mediaclient'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/42001/

Sanity tests for ['RPI4 Mediaclient'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/42002/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/42012/

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/273/

'['BCM Reference Refapp2']' Sanity test FAILURE, investigation pending.
Build Job/Num: build-brcm-refboard2/7538
Flash BCMREF [FAILURE]
BCMREF - Video Test skipped [FAILURE]
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-bcmref-refapp2-flow/10492/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/42061/

https://jenkins.code.rdkcentral.com/job/github-triggered/50510/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/15228/ started

https://jenkins.code.rdkcentral.com/job/build-component/89762/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/15229/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/22000/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/22001/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/15230/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/50513/ started

https://jenkins.code.rdkcentral.com/job/build-component/89764/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/22002/ started.

Sanity tests for ['RPI4 Mediaclient'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/42158/

Sanity tests for ['RPI4 Mediaclient'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/42159/

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/15233/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/50518/ started

https://jenkins.code.rdkcentral.com/job/build-component/89771/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/22006/ started.

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/284/

Sanity tests for ['RPI4 Mediaclient'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/42166/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/42176/

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/289/

https://jenkins.code.rdkcentral.com/job/github-triggered/50601/ started

https://jenkins.code.rdkcentral.com/job/build-component/89838/ started.

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/22065/ started.

Sanity tests for ['RPI4 Mediaclient'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/42282/

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/42287/


[Editor] Avoid an exception when copying an existing editor

/botio integrationtest

When integration tests are successful on Windows, it means that they all failed... :)
Anyway I forgot to run test sequentially in order to avoid clipboard issues between Chrome and Firefox.
/botio integrationtest

/botio integrationtest

/botio unittest


Login vs Logout redirects controller names

Not sure if this is an issue or we have configured it wrong but we are noticing that whilst using the oidc client, the login redirect is going to accounts/login whilst the logoff redirect is going to account/logoff.
I could not figure out if this could be overwritten (configured) but I do find it odd that one is plural and the other is singular.

Your question sounds unrelated to this repo.

@brockallen Maybe I am looking in the wrong place.  Here is our setup.
We are running Identity Server 4 on one server.  We have build an Angular App that runs on another server.  We are using the oidc client to communicate between the two.  I will be honest, I am not an angular developer so I am just providing what was given to me by our front-end developer.
When a user goes to the angular app, it verifies they have logged in.  If they have not then he is calling a method in the oidc client which is redirecting them back to our auth authority / accounts/login
When the user clicks on the logout link, again he says he is calling a method on the oidc which is then sending the user to the auth authority / account/logout
Tracing the flow in devtools I noticed that actually its going to authority / authorize so maybe its a configuration in Identity Server I have missed?

@brockallen After digging more into this, this has nothing to do with oidc or identity server, sorry about the confusion.


Could you add MTS-Mixers into your library?

hi,
I saw MTS-Mixers: Multivariate Time Series Forecasting via Factorized Temporal and Channel Mixing was published 6 days before your TimesNet paper.
Could you add this model into your library?
Here is their code. https://github.com/plumprc/MTS-Mixers

Cool, thanks for your recommandation. We will add this into out todo list.

Hi, after a deep discussion, we decided to delay the development of this work. You may find its code from their authors.


[Translate ru] redirects

Check out a review request at GitLocalize

Thanks for the contribution! Due to the way DevSite works, we can't translate _book.yaml, _project.yaml, _toc.yaml, _footer.yaml, _redirects.yaml, _upper-tabs-*.yaml files. I'm going to close this for now. Thanks


Further clarification on internet clients

You say "Configuration Manager does not automatically send the client upgrade package to Configuration Manager cloud-based distribution points.", but I noticed that it DOES send up a copy of the Client Package automatically (at least as of 1810 it does) to cloud distribution points.  There is no separate client upgrade package as far as I can tell anymore, so how has the behavior changed in respect to internet-based clients.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7000ae26-9f15-9644-55b9-e5db68c47ff2
Version Independent ID: 8a672552-6e90-cd91-419c-ba6a5292fabf
Content: Upgrade clients - Configuration Manager
Content Source: sccm/core/clients/manage/upgrade/upgrade-clients-for-windows-computers.md
Product: configuration-manager
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Changed. Thanks @Yevrag35


show plain text until the page fonts load

this is just an idea, but I think it would be nice -- rather than a flash of garbage characters users see the ayah itself then 2 seconds later it swaps into madani font (e.g. assuming it just loaded)

this would be awesome! I have no idea how to implement this though :(

I mean, i might have a way but I don't like it...

i've done it before (determining when the font is ready), some kind of
magic -- i forgot how but i'm sure i could recall if i thought hard enough
On Fri, Apr 8, 2016 at 8:13 PM Mohamed El Mahallawy <
<EMAIL_ADDRESS>wrote:

I mean, i might have a way but I don't like it...
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/quran/quran.com-frontend/issues/268#issuecomment-207542599

Can use this: https://fontfaceobserver.com/

Salam, guys You are doing great, i am thinking to start contributing this holy project. So i start implemented this feature as my first commit. right?
Then i have a question:
Q: how to do we ensure that two persons are not working on same problem?

@mahboob-awan good suggestion, as I am already working on it here!

I think a good way to do this is to tag the issue in a PR as early as possible?

Okay, just as I have here ^^

@mmahalwy aha, so just create a "wip" and tag the issue and keep working on. Yes, seems a nice plan. Thanks

Thank you sir!

this is done!


Immich 1.66 released

Message
A new release
Stages

[x] Read the release notes and figure out if I need to do something.
[x] Run ./update.sh old-tag new-tag like ./update.sh v1.52.1 v1.53.0 to diff a few select files and make relevant changes.
[x] Read Immich Discord to get a feeling if there is any critical bugs (and maybe wait for a dot release).
[x] Check for new releases of the Immich CLI.
[x] Build and test it locally.
[ ] Push it to a branch in a PR, let CI run it's tests.
[ ] Merge the PR.
[ ] Wait for snapcraft build service to do it's thing and release a build to edge channel.
[ ] Promote it to the beta channel and test it.
[ ] Promote it to candidate and live with it my self for an appropriate amount of time.
[ ] Promote it to stable.

Upstream https://github.com/immich-app/immich/pull/3053 changes the ffmpeg parameters, it starts to use a new-ish parameter 'fps_mode`, 4.2.7 with is bundled in this snap do not support this option so this throws:
Unrecognized option 'fps_mode'

It's a little work to build ffmpeg (that's why I used the binaries included in Ubuntu 20.04, that's core20 is based on). This is my preferred solution so I will investigate this approach:

https://trac.ffmpeg.org/wiki/CompilationGuide/Ubuntu

If this is to tricky to maintain, complete or I just run out of time I will consider the static builds.

Yeah, I bundled the static binary :)


Constraints on version of KeyCloak to use?

We have been discussing the need to use a RedHat endorsed / supported version of KeyCloak, rather than the latest stable one.
We should write up the pros and cons to make an educated decision.
Decision drivers to consider

We aim at deploying the solution in the NASA MCP. Does MCP impose any restrictions on that? (brought up by @wildintellect and @freitagb)
Do we share the security criteria RedHad applies to their selection of KeyCloak version?
Does the version RedHat uses get better support and is that a relevant benefit for us?
What to similar projects do? Is it relevant to keep things similar to e.g. ESA EOEPCA+?

Acceptance critera

[ ] Documented constraints on which versions of KeyCloak can be considered for a VEDA production solution

This is obsolete because we learned that RedHat will soon add support for KC 26.


Feat new landing

Please rebase on top of master.

CLA should be ignored. I verified it's good.

(the CLA status will never resolve, I'm going to merge this once all reviewers are okay)


Add Reference Table To Map Error Codes

Ticket Goals
In the database we use reference tables to make outputs from the database more clear. For instance a database might now a sausage is item_id: 14490. While this is efficient to store and easy for the computer to use, if I query the table to see how many sausages we've sold I need to know its code. A reference table maps these ids to actual words. So for instance it would map "Sausage" to 14490.
Bringing things back to Semaphore. We recently added a table that logs errors from different model runs. The table saves the error code that ill explain below but not the text representation. We need to add a reference table to the database such that we can create more clear outputs.
Ticket Coverage
This ticket requires you to work with our database migration pipeline. Something hard to explain in a single ticket but id be more than happy to show you how it works. In short when we update our database we write a special script tools/DatabaseMigration. This script is responsible for updating the database to the next version with the update method. In case something goes wrong and we need to lower the version of the database it also has a rollback method that undoes all its changes.
Ticket Steps

Identify the next version of the database, you can look in the Database migration folder and see what the last version was. Just add one to the second number. Create a folder for the new version and a script. Look at the other migration scripts to see how to do this.
Write update method: This update should add the reference table and add the entries. The entries should then be mapped as foreign keys to the rows in the model run table.
Write rollback method: The rollback method should delete all the data in the reference table and drop the reference table.
The migration script needs to be tested. You should try instantiating a new Database, updating an already existing database, rolling back an empty reference table, and finally rolling back a reference table that has rows in it.

Helpful Info!
Semaphore runs have for exit codes found below:
0 - Success
-1 - Missing Data Error
1 - Ingestion Error
2 - Semaphore Error
Thus the reference table needs to link these together. So

Code
Result

0
Success

-1
Missing Data Error

1
Ingestion Error

2
Semaphore Error

The table should start with the ref_prefix. I might call it something like ref_predictionResults

Should this go to @jeremiahsosa77 Please remember you aren't doing this alone! Please ask questions in the help chat! Feel free to ask to pair with people too! Do as much as you can alone but this is a lot so please ask for help!


Made Driller a top concept

Removed Driller as a narrower concept of Contractor

As per all other comments: don't reduce the information content of the vocabs: find better ways to view (query) the data as needed.
Changes to simplify things here will only set a precedent that you should do bad modelling to suit some simple purpose.

@nicholascar while I understand your comments, I don't think that is the issue here.
driller is not a narrower term of contractor.
a driller might not be a contractor.
Also, there is an error in this vocab that is fixed in this PR - duplication of contractor in Top Concepts.

Maybe I'm wrong, but it seems having contractor, operator, and driller all as top concepts, would imply that drillers are never contractors or operators.
We will have instances where driller would be either contractor->driller (a drilling subcontractor) or operator->driller (staff drillers/own rigs). The distinction could be a valuable metric for evaluating factors affecting exploration success, so it might be nice to have two 'driller' concepts instead of one.

If it gets hard to work out what something is Driller and/or Contractor then I suppose you’d best have separate Concepts. You could dual tag an Agent as both a Contractor and a Driller.... I assume you don’t want to allow that in a UI but data wise multiple roles would be fine.

In the geoprops model, we have one entry for Operator - in Borehole header table, and one entry for driller in the Wellbore table. This could be the same party or different parties.
If you want to know if someone is a contractor - then we could record that elsewhere - a simple contractor register.

@nicholascar @DavidCrosswellGSQ
A driller may be an operator or a contractor.
But it begs the question of whether we need driller as a role concept at all if the data model itself defines the drilling 'role'. The entry in the driller field is-and-can-only-be a driller by definition.
Then the role in the org table becomes whether the operator is doing the driller or a contractor is doing the drilling.

@nicholascar @DavidCrosswellGSQ  PR one month old. Do we have a resolution?

@KellyVance I still stand by this change and would like it approved.

Not for me to decide, sorry!
You can always model soemthing with a direct property:
<a> eg:hadDriller <b> .

Or with a general relation + role:
<a> eg:hadRelatedAgent <b> .

<b> eg:hadRole <Driller> .

And the choice can be semantically neutral (i.e. you can entail one from the other) so it's really just a style thing. If the specific property, eg:hadDriller, would be well understood and common you could use that. If the Agent + Role pattern would be generally applicable, like for lots of potential roles + a common vocab, you could use that.

I'm still a little unsure about the implications. But if you want to reopen this request I'm comfortable approving this and adjusting if/when it breaks.


changed the hover effect of features section in footer section of iskcon events page

add a screenshot and also the issue that u are targetting

issue:

issue resolved as i have changed the hover effect of all the features links present in footer

also mention issue

The features links like read a shlok and all other features which were when hovered, were not visible due to same text colour as of background and were also very small as compared to the overall website font.
Thus i updated the css and made changes to improve the ui

I am talking about issue number that u are solving

the issue number shows #497


[GH-#507] Contracts and calls state trees

Implemented initial version of calls and contracts and their state trees
resolves #507

@Artur64 @DanielaIvanova @gspasov will you review?

Maybe will be great if you add some documentation in README.md

@cytadela8 can you review again?
@DanielaIvanova We will add documentation in the readme once we finish everything related with the creating and calling of contracts.

@Artur64 @d-velev @gspasov Could you rereview?

whats the status here?


Add Five Nights At Freedy's 3 "Die In A Fire" by The Living Tombstone, EileMonty, Orko

Song Name
Five Nights At Freedy's 3 "Die In A Fire"
Artist Name
The Living Tombstone, EileMonty, Orko
Source
Youtube
Youtube Link
AibtyCAhyQE
Direct File Link
No response
Song ID
697828
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 23325320

accept


Cannot be compiled in Flutter 1.9

I got following message while building my app:
Compiler message:
/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_stetho-0.4.1/lib/src/http_client_response.dart:5:7: Error: 'StethoHttpClientResponse' can't implement both 'Stream<Uint8List>' and 'Stream<List<int>>'
 - 'Stream' is from 'dart:async'.
 - 'Uint8List' is from 'dart:typed_data'.
 - 'List' is from 'dart:core'.
class StethoHttpClientResponse extends StreamView<Uint8List>
      ^
/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_stetho-0.4.1/lib/src/http_client_request.dart:54:42: Error: The argument type 'HttpClientResponse' can't be assigned to the parameter type 'Stream<Uint8List>'.
 - 'HttpClientResponse' is from 'dart:_http'.
 - 'Stream' is from 'dart:async'.
 - 'Uint8List' is from 'dart:typed_data'.
Try changing the type of the parameter, or casting the argument to 'Stream<Uint8List>'.
      createResponseTransformer(id).bind(response),
                                         ^
Compiler failed on /Users/chao-chih/case/air-guard/lib/main.dart
Finished with error: Gradle task assembleDebug failed with exit code 1

And here is my flutter version:

chao-chihde-iMac:air-guard chao-chih$ flutter doctor -v
[✓] Flutter (Channel stable, v1.9.1+hotfix.2, on Mac OS X 10.14.5 18F132, locale zh-Hant-TW)
    • Flutter version 1.9.1+hotfix.2 at /flutter
    • Framework revision 2d2a1ffec9 (5 days ago), 2019-09-06 18:39:49 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

Thanks

same too


Migrating to a specific version

First off, thanks for creating this great tool!
I'd really like to be able to just migrate to a specified version, without having to worry about whether the migration would be up or down. This is already kinda possible; for db-migrate up I can specify the version I want to migrate to. So this leaves two problems:

Determining whether to migrate up or down.
Granted, this one is of less importance. It would be more of a convenience feature.

Migrating down to a specified version
This one is really key to me.  The way I'd like to do that is by tying each of my application's versions to a specific database version. The update/rollback scripts would then run a migration for a specific version. This is currently impossible, because a rollback script would have to know how many versions to roll back (as per db-migrate down -c [count]).

Any thoughts on this?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27457284-migrating-to-a-specific-version?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F73887&utm_medium=issues&utm_source=github).

This basically possible and easy to implement, and this needs to address the lowest or highest (to be) executed migration.
But I think this wouldn't be enough, if we want this feature I would also suggest to introduce tagging  of this different points in time.

Yeah, I took a quick peek at the code, and it does indeed seem really easy to implement. You basically already have all of the functionality for going up. Honestly, I was kinda surprised it was possible for going up, but not for going down.
The tagging would be nice, but it wouldn't be strictly necessary for me. I will just have a configuration file that contains the version that is compatible with this version (AKA revision) of my application. So as my application evolves, I just increment the version in the config file. Rolling back will then become really easy, as the CI environment would just have to checkout a specific revision and subsequently migrate to the database version as specified in the config file.


File upload not correctly documented

If you want to upload a new file, there is no documentation or sample, it is just for creating and uploading.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7d4935f4-d5c1-f7c3-eeb0-f8b5e5fd406f
Version Independent ID: 766ee1b8-4c5d-054b-d7ec-1825d8f5d50b
Content: Quickstart: Azure Blob storage library v12 - JavaScript
Content Source: articles/storage/blobs/storage-quickstart-blobs-nodejs.md
Service: storage
Sub-service: blobs
GitHub Login: @mhopkins-msft
Microsoft Alias: mhopkins

@mehdijalal Thanks for your question. We are checking on this and will respond to you soon.

@mehdijalal Just for clarification: Have you referred to this article: Blob samples

@mehdijalal I'd recommend posting your question in https://social.msdn.microsoft.com/forums/azure/en-US/home?forum=windowsazuredata since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Model links between GSBPM and GSIM

The Unece "Supporting Standards" group lists kinks between GSBPM sub-processes and GSIM objects. These links could be rendered via a RDF object property. A GSIMObject class could also be created to scope the domain or range of this property.

Several points to discuss here:

name of mother class for all GSIM "objects": GSIMObject? GSIMClass?
should we create sub-classes for each group (GSIMBaseObject, GSIMExchangeClass)?
or/and, keeping referring to PROV-O, create GSIMAgent, GSIMActivity and GSIMEntity?
name of properties linking GSIM and GSBPM: currently, "input" and "output" seem to be used
do we define these properties as sub-properties of PROV properties (used, wasGeneratedBy), or even directly use the PROV properties?

Could Class and Object be ModelElements?
GSIMModules where the Modules are Base, Concept, Exchange, Structure, Business.
I agree to using provo and any other international ontologies we can.
GSIM and GSBPM could  be linked by input, output, support and guide. Ref Data Flow Diagrams
Will we need OWL2 object properties and datatype properties?

Decided during 23/02/21 meeting: create GSIMClass, with equivalent class GSIMObject and daughter GSIMEntity.
Implemented in Turtle by commit https://github.com/linked-statistics/COOS/commit/2a811f05d3704f9e9ec9100fbcbde96a9b32340f, https://github.com/linked-statistics/COOS/commit/74b0ae1a6b01182c04d11268b271223f73e349e3 and https://github.com/linked-statistics/COOS/commit/f1515ddc0bb0ff6031fe4c2767119d4d0152e5e9
For GAMSO and GSBPM we did not keep the name of the model in the name of the classes (e.g. ActivityArea and not GAMSOActivityArea, Phase and not GSBPMPhase), so why should we for GSIM? But if we drop the GSIM part, we are left with "Class" or "Object", not very informative. So, since GSIM is a statistical information model, why not "StatisticalInformationClass", or "StatisticalInformationObject"?

I think StatisticalInformationObject/Class works. The question of whether we need the term "statistical" in the name has been raised by Edgardo:

I agree with the proposal of removing “GSIM” prefix and substitute it by a generic one. However, my hesitance is whether it is necessary to qualify them by “Statistical”. Will there be Objects or Classes other than “statistical” in the scope? If not, and for the sake of shortening the names, I would just say “InformationObject” and ”InformationClass”.

Given we included GAMSO, we might want to support information entities that are not statistical. Having said that, GSIM is a statistical model, same as GSBPM, so it's scope is the statistical information entities.
I suggest to have InformationClass at the top and StatisticalInformationClass/Object as subclasses for the GSIM objects.

We are fine with a superclass called "informationClass" as source node for GSIM subclasses.
This can be linked as a stub to the corresponding GSBPM Objects.
After the link has been extablished we can derive other GSIM classes by further specification, so it is fine if the class looks seldom "informative" at this level.
With InformationObject being an instance of the class instead. What do you think?
Paolo & Adele

@FlavioRizzolo DDI-CDI uses InformationObjet, I think, which is consumed and produced by activities

So, following your suggestion, I would go for prov:Entity -> coos:InformationObject -> coos:StatisticalInformationObject

@FlavioRizzolo
We discussed different possibilities previously for representing links between GSIM objects and GSBPM sub-processes, in particular the idea of representing individuals sub-processes as some kind of "abstract" or "prototype" individuals with class-like features so they can be used as domains or ranges of properties. We mentioned OWL NamedIndividual as a possibility, but I checked in the specifications and I understand that OWL named individuals are just individuals that have an IRI (https://www.w3.org/TR/owl2-syntax/#Individuals).
Actually, considering how GSBPM sub-processes are currently declared in  COOS, typing them as owl:NamedIndividual might actually restrict the possibilities. Just typing them as coos:SubProcess as it is currently done does not entail that they are individuals (https://stackoverflow.com/questions/37157883/member-of-an-owlclass-versus-owlnamedindividual), if I understand correctly. You could still add axioms treating, for example, http://id.unece.org/activities/subProcess/7.3 as a class, using metamodeling. However, I'm not sure we want to go that way.

Example of InformationObjects being inputs and outputs of Activities:
Consider "Design Frame and Sample". Inputs are "DataSet", "DataStructure", "Variable", and "Population", and outputs are "Process Method" and "Rules", among others. Those are GSIM objects, which seem to be individuals of either coos:InformationObject, or coos:StatisticalInformationObject, to be more precise.  They seem to me to be at the same level of "abstract" individuals as "Design Frame and Sample" is an "abstract" individual of the subProcess class. That aligns with prov:used/prov:wasGeneratedBy as well, and their inverses.

Also, a question: currently, InformationObject (or Entity) is defined as "Mother of all classes defined in GSIM" and StatisticalInformationObject (or Entity) as "Information object representing statistical information". Should both be the definition of StatisticalInformationObject (or Entity)? To me GSIM doesn't apply to other type of information, e.g. HR, Finance, Procurement, etc.

I know GSIM is "Statistical Information Model"..... but are all GSIM objects "statistical information"? I am thinking of something like "Process Step", "Process Control Design" or "Identifiable Artefact", they might be concepts needed for the statistical production process, but don't seem so "statistical" information as "Population" or "Variable"?

The introduction of Statistical Concept might be confusing for GSIM users that already have Concept (https://statswiki.unece.org/display/clickablegsim/Concept) with subtypes Population, Universe, Unit Type, Variable and Category.

Regarding the adjective 'Statistical'. When NSIs contribute data sets to national catalogues/portals and European portals then users know the content is statistical through dct: publisher, dct: creator, foaf: Agent, dcat: theme, dct:subject, skos:Concept etc etc. I am still worried that by using the adjective Statistical everywhere we might be reducing out interoperability with other international and national groups and organisations eg national mapping agencies. The end users simply want to find data sets and combine them with other data sets. Are our data sets different from other data sets or is it 'just' that our organisations try to adhere to certain quality criteria? Are we giving ourselves more work by introducing the adjective Statistical and at the same time reducing the quality for our users?  How open is our data when we use terms that are not used by other organisations?

I am still worried that by using the adjective Statistical everywhere we might be reducing out interoperability with other international and national groups and organisations eg national mapping agencies. The end users simply want to find data sets and combine them with other data sets. Are our data sets different from other data sets or is it 'just' that our organisations try to adhere to certain quality criteria? Are we giving ourselves more work by introducing the adjective Statistical and at the same time reducing the quality for our users? How open is our data when we use terms that are not used by other organisations?

This is a good point. Other than statistical products, the rest, i.e. data point, data structure, dataset and all its sub-classes, doesn't really need to be "statistical".

Also, a question: currently, InformationObject (or Entity) is defined as "Mother of all classes defined in GSIM" and StatisticalInformationObject (or Entity) as "Information object representing statistical information". Should both be the definition of StatisticalInformationObject (or Entity)? To me GSIM doesn't apply to other type of information, e.g. HR, Finance, Procurement, etc.

I know GSIM is "Statistical Information Model"..... but are all GSIM objects "statistical information"? I am thinking of something like "Process Step", "Process Control Design" or "Identifiable Artefact", they might be concepts needed for the statistical production process, but don't seem so "statistical" information as "Population" or "Variable"?

I feel the same way. It seems to me that objects in the Concepts and Structures groups are Information Entities whereas objects in the Business group are rather "Business" Entities. Not sure what to think of Exchange though.

Based on the recent comments, I have two questions to discuss:
Question 1: Should we add Business Entity as a child of prov:Entity to capture at least the GSIM Business group?
Question 2: Should we remove Statistical Information Entity entirely?

Regarding the relationship between Dataset, Data Structure and Data Point, both GSIM and DDI CDI have the same relationships as the proposed diagram above.
From GSIM:

From DDI CDI:

Wait for conclusion of the discussion in the GSIM revision Task Team

@FranckCo @flo7894 Please find an analysis of this issue in https://github.com/linked-statistics/COOS/wiki/Issue-19-analysis-note


Add python usage examples

Nice work! Thanks for sharing with everyone. Any chance you could add python usage examples to the list of languages on the main page? Please consider that for the py family. Thanks again.

Hey this is a typescript lib and doesn’t support python right now. The contracts it used could be written in python to support python apps.
https://github.com/banteg/multicall.py < this does what you want in python I think?

Oh, I see. I appreciate your feedback. Thank you!
Thanks again for the reference, it's exactly what I was looking for.


Remove empty structure

in some cases, there are structures with a little "arrow down" but when clicking on it there is nothing. As we can't do anything with it maybe we can get rid of them?
(notice the arrows down without any content)

They are basically "supposed to be expandable", but not ATM due to lack of features. #255 for example. Please open more specific issue if there's no existing.

I understand that for now they are empty and it is planned that they will be populated.
I wanted to suggest to hide them until it is supported. What is the timeframe to have them supported? If it is more than a month, my personal point of view is that it is worthy to hide them. They will reappear anyway as soon as the support will be added. In the mean time it will avoid to have users like me wondering what is happening with all these fields and trying to click each of them. it is also wasting a lot of place.


Demo site - Added InputFile 'known issues' section

Pull Request
📖 Description
FluentInputFile does not work with serverside blazor in conjuction with Autofac IoC.
This PR contains a code snippet in the demo site for the workaround. -> https://www.fluentui-blazor.net/InputFile
The following root issue is documented below
🎫 Issues
aspnetcore#38842
✅ Checklist
General

[ ] I have added tests for my changes.
[ ] I have tested my changes.
[ ] I have updated the project documentation to reflect my changes.
[ ] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

[ ] I have added a new component
[ ] I have added Unit Tests for my new compontent
[ ] I have modified an existing component
[ ] I have validate Unit Tests for an existing component

@microsoft-github-policy-service agree


do not set global $ansi but still check it for false

setting code had no effect since it sets it to false and then always to true, so just check if it is == false so we do not add a new global, but still keep those checks working

Note the $ansi = true setting has been moved to the top so the possible false setting can have the appropriate effect. Even so, I think you have a fair point with regards to the global. I am just not sure it is the best way to go b/c it can be a bit confusing that nil != false for $ansi. Maybe I should have used a $noansi flag instead, that could have been left unset, and then set to true to deactivate ANSI. But I am not sure I should change it now.

Btw, sorry about not responding to this sooner! Turns out I have not been getting email notifications of PRs for this project (not sure why).

moving $ansi to the top should be fine

Ok. Cool. I am going to open a ticket for this though for future consideration. I agree it would be better not to set a global by default.


Copy symlinks as symlinks

Copy symlinks as symlinks
This PR add the flag -l to rsync in order to copy symlinks as symlinks.
Use case:
I use docker-osx-dev in my Node.js project.
Node package manager, NPM symlinks executables in node_modules/.bin.
Example:
gulp -> ../gulp/bin/gulp.js

This way allows developper to directly use node_modules/.bin. Furthermore, NPM allows us to define "scripts" where $PATH has been automatically append with this directory.
Hope it's clear. I tried to write tests... Hum... I didn't find where place it...
Thanks for this project, really useful in our workflow.

Thanks for the PR!
Regarding tests, we have some unit tests in docker-osx-dev.bats, but we have been blocked on integration tests due to #7. See #97 for the latest status.

The -l (--links) flag should not be necessary if --archive is used.
From man rsync:
If --links is specified, then symlinks are recreated with the same target on the destination.
Note that --archive implies --links.


Professor's title doesn't shown correct in Professors Page

While exploring the professors page I found that each professor's title is shown incorrectly.
The issue is shown in the image below.

Professor's title is "kathigitis", while it has be professor. It isn't translated.

Excellent, thank you!


(calibre) Outdated

Checklist

[X] I have checked the moderation queue that no new version has been submitted (only visible when logged in), or the submitted package version has failed the automated checks.

Please navigate to the following link to view the moderation queue.

[X] I have verified that the new version is a stable release.
[X] I have looked to see if there are any Bug reports that prevents a new version being submitted and that no existing Outdated Reports have been created.
[X] I have verified the new version has a Windows binary (EXE or MSI installer, Zip or other archive, etc).

New Software Version
7.0.0
Download location
https://download.calibre-ebook.com/7.0.0/calibre-64bit-7.0.0.msi
Package Page
https://community.chocolatey.org/packages/calibre

Newer version
https://github.com/kovidgoyal/calibre/releases/download/v7.1.0/calibre-64bit-7.1.0.msi

7.2 is released.
https://github.com/kovidgoyal/calibre/releases/tag/v7.2.0

A PR for this has been made, and merged.  An updated version of Calibre should be available soon once all the automated checks as complete.
Thanks to @TheCakeIsNaOH for doing this PR.


bugfix: update MLFlowLogger's status to be FAILED when training raises an error

What does this PR do?
If a trainer with MLFlowLogger raises an error, the user should be able to see the MLflow's screen to check the training has been failed.
MLflow's status remains "RUNNING" even after trainer.fit raises an error in the current implementation, so the user cannot know whether the training is still in progress or failed.
Fixes #12291
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

The commit has succeeded to fix the bug, but failed to pass an existing unit test, which I couldn't find a solution to.
Can anyone help me with the draft PR?

I would appreciate it if you approve running the workflows 🙂

I would appreciate it if you approve running the workflows 🙂

Most of team was OOO. Sorry about the delay.

The commit has succeeded to fix the bug, but failed to pass an existing unit test, which I couldn't find a solution to.
Can anyone help me with the draft PR?

Which test was it?

@awaelchli
Thank you for your review and modification!

Which test was it?

It was tests/utilities/test_cli.py::test_cli_distributed_save_config_callback.
Although the latest implementation has passed the test, the failed test can be reproduced on commit dbbfef817a3fff52a4d0b98ef68ae39f03863f56.

@awaelchli @daniellepintz
Do you have any update on this?
I understand some PRs may be pending because of the 1.6 release.

@carmocca Is there anything I can help to merge the PR?

@ritsuki1227 I created a fix in #14762 to unblock this PR for the remaining issues.

@ritsuki1227 before we merge, would you mind checking again your MLFlow use case, that the status is reported as you expect? Thank you!

@awaelchli Thank you for your commits! I've checked mlflow logger worked correctly on the use case.

Awesome, let's get it in then! Thanks a lot for your help in making the integration with PL better!


Update view when changing state

While playing with redux-dev-tools I have noticed that the Router updates the view only as a response to location change.
Stepping through the navigation steps was not updating the view.
I think that location change should eventually cause the view update, but the "source of truth" should be the state.

From the source, it looks like the router updates the state as a result of location change: https://github.com/hyperapp/router/blob/48d81a0cca9ce0545905021b1cd78d9d4840a33d/src/location.js#L30
Are you suggesting that the order should be click link -> state change -> location change -> view updated rather than click link -> location change -> state change -> view updated, or are you saying there is a bug in the implementation?

I think that the logic you describe is correct: location change -> state change -> view update.
But when only the state changes - the view should also update.
location is a side effect, the changes in the state should be reflected in the view regardless the location.

So my first concern should be not looking at how the state catch the new location, but how a Link set a location :
https://github.com/hyperapp/router/blob/48d81a0cca9ce0545905021b1cd78d9d4840a33d/src/Link.js#L22
I tend to use the view more like an update/subscribe point to the state changes. So, I would love to see the following pattern.
click link -> state change -> location change
                          &-> view render

Sounds like it will need to handle page refresh differently?

What are you thinking ? Do you agree the API should stay the same ?
If everything is handled by the state, how would you give history.{go,back,forward} power to the user ?

I think the location change should trigger the stage change, then view change.
But changing router's state (that's what redux-dev-tools is doing) should also update the view

maybe...
location change -> (state change -> view change)
making
state change -> view change just work.

I need more clue, but is this not the current behavior ?
I have not authored the router, but looking at the source code, we have the following pattern.
location change -> state change -> view change

Subscribe to location change
https://github.com/hyperapp/router/blob/48d81a0cca9ce0545905021b1cd78d9d4840a33d/src/location.js#L42

Set the location in state at location change
https://github.com/hyperapp/router/blob/48d81a0cca9ce0545905021b1cd78d9d4840a33d/src/location.js#L31-L37

Commit state update to call the render view
https://github.com/hyperapp/router/blob/48d81a0cca9ce0545905021b1cd78d9d4840a33d/src/location.js#L26-L28

@mickeyvip can you share a link to the code you have the error with?

I didn't look into a code, but the problem is that view is not updated when only state changes.

set should be called when only state changes.
state should change when location changes.

From where are you changing the state.location ? Another action ?

another action, specifically I am using redux-dev-tools

Just to clarify why I thought this was issue worthy, the devtools hoa replaces the state in full on time travel.  So if the routes are determined based solely on the state this behavior shouldn't be happening.

Then, now I see where the problem is.
We were looking at the subscription, but the problem is near the consumption. The view render is correctly called, but the new expected Route is not rendered.
By default, the Route renderer is awaiting the window.location.pathname to match the path parameter.
https://github.com/hyperapp/router/blob/48d81a0cca9ce0545905021b1cd78d9d4840a33d/src/Route.js#L3-L4
This is because in Hyperapp, component are stateless but someone tried to give ease to user using the Route component. (cc @JorgeBucaran)
From my seat : You should use the location parameter to make your Route component strongly related to the state.location changes.
<Route parent path="/topics" location={state.location} render={TopicsView} />

I am not a redux-devtool user, can you, please, give it a try for me ?

@Swizz, if I am understanding correctly - this is the way

So, we need to document this. This one affect Route, Redirect and Link.
The code is present but the documentation is not.

@Swizz, what do you mean by

the code is present

The code also needs a change, right?

@Swizz, so just add location={state.location}?
I'll give it a try.
Thank you!

So the only need is to clarify this in the documentation.
Do you agree ?

@Swizz , just tried it out.. There is a problem.
When I added location={state.location} - the page starts reloading when routing...

@mickeyvip did you use e.preventDefault()?

Hang on that is in the Link component...  Hmm, not sure why it's reloading on Link click.

@andyrj , just got home and trying it on my hope PC - works! No reloads.

@mickeyvip Does #59 solve this issue on your side ?

@Swizz , just checked Hyperapp 1.2.5, @hyperapp/router 0.5.0, hyperapp-redux-devtools 1.1.6.
It is working as expected with dev tools without additional location={state.location}.

@mickeyvip Can we close then? 🎉

Yes! Thanks!


Add macOS CI

Attempted this tonight. There are a lot of conditions present in the build that assume linux or windows. Also BSD sed doesn't like the way you're using it. Not sure exactly what it's complaining about yet.
diff --git a/WORKSPACE b/WORKSPACE
index 7a40338..77f6e45 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -60,7 +60,7 @@ http_archive(
 http_archive(
     name = "bazel_clang_tidy",
     # Hack to have every .h-header treated as C++.
-    patch_cmds = ["""sed -i '47i \\    args.add("-xc++")' clang_tidy/clang_tidy.bzl"""],
+    patch_cmds = ["""sed -i'' -e '47i \\    args.add("-xc++")' clang_tidy/clang_tidy.bzl"""],
     sha256 = "e2721c47f4215ac36ad1da55ebdb968a094125dbc397aa7733f067001600b2ee",
     strip_prefix = "bazel_clang_tidy-133d89a6069ce253a92d32a93fdb7db9ef100e9d",
     url = "https://github.com/erenon/bazel_clang_tidy/archive/133d89a6069ce253a92d32a93fdb7db9ef100e9d.tar.gz",
@@ -82,7 +82,7 @@ http_archive(
 # boringssl//:ssl cheats and pulls in private includes from boringssl//:crypto.
 http_archive(
     name = "boringssl",  # OpenSSL + ISC
-    patch_cmds = ["""sed -i '33i package(features=["-layering_check"])' BUILD"""],
+    patch_cmds = ["""sed -i'' -e '33i package(features=["-layering_check"])' BUILD"""],
     sha256 = "6369980cd79b3847a17a8e078dce37688671911a6fadb1c84e27fb505d827511",
     strip_prefix = "boringssl-22b3ea0c113b544e4334377541cabe8d8038d0c7",
     url = "https://github.com/google/boringssl/archive/22b3ea0c113b544e4334377541cabe8d8038d0c7.tar.gz",
@@ -187,7 +187,7 @@ http_archive(
     # in MSVC debug builds with "cannot seek string_view iterator after end".
     # See: https://github.com/SFML/SFML/issues/2113
     patch_cmds = [
-        "sed -i 's/if (begin + trailingBytes < end)/if (trailingBytes < std::distance(begin, end))/' include/SFML/System/Utf.inl",
+        "sed -i'' -e 's/if (begin + trailingBytes < end)/if (trailingBytes < std::distance(begin, end))/' include/SFML/System/Utf.inl",
     ],
     sha256 = "6124b5fe3d96e7f681f587e2d5b456cd0ec460393dfe46691f1933d6bde0640b",
     strip_prefix = "SFML-2.5.1",
diff --git a/os/BUILD b/os/BUILD
index e74e060..9ed76ae 100644
--- a/os/BUILD
+++ b/os/BUILD
@@ -9,11 +9,13 @@ cc_library(
 OS_DEPS = select({
     "@platforms//os:linux": [],
     "@platforms//os:windows": [":windows_setup"],
+    "//conditions:default": [],
 })

 OS_LOCAL_DEFINES = select({
     "@platforms//os:linux": [],
     "@platforms//os:windows": ["WIN32_LEAN_AND_MEAN"],
+    "//conditions:default": [],
 })

 cc_library(
@@ -21,6 +23,7 @@ cc_library(
     srcs = select({
         "@platforms//os:linux": ["memory_linux.cpp"],
         "@platforms//os:windows": ["memory_windows.cpp"],
+	"//conditions:default": ["memory_linux.cpp"],
     }),
     hdrs = ["memory.h"],
     copts = HASTUR_COPTS,
@@ -29,6 +32,7 @@ cc_library(
         "@platforms//os:windows": [
             "-DEFAULTLIB:Kernel32",
         ],
+	"//conditions:default": [],
     }),
     local_defines = OS_LOCAL_DEFINES,
     visibility = ["//visibility:public"],
@@ -51,6 +55,7 @@ cc_library(
     srcs = select({
         "@platforms//os:linux": ["system_info_linux.cpp"],
         "@platforms//os:windows": ["system_info_windows.cpp"],
+	"//conditions:default": ["system_info_linux.cpp"],
     }),
     hdrs = ["system_info.h"],
     copts = HASTUR_COPTS,
@@ -60,6 +65,7 @@ cc_library(
             "-DEFAULTLIB:Shcore",
             "-DEFAULTLIB:User32",
         ],
+        "//conditions:default": [],
     }),
     local_defines = OS_LOCAL_DEFINES,
     visibility = ["//visibility:public"],
@@ -83,6 +89,7 @@ cc_library(
     srcs = select({
         "@platforms//os:linux": ["xdg_linux.cpp"],
         "@platforms//os:windows": ["xdg_windows.cpp"],
+        "//conditions:default": ["xdg_linux.cpp"],
     }),
     hdrs = ["xdg.h"],
     copts = HASTUR_COPTS,
@@ -93,6 +100,7 @@ cc_library(
             "-DEFAULTLIB:Kernel32",
             "-DEFAULTLIB:Ole32",
         ],
+        "//conditions:default": [],
     }),
     local_defines = OS_LOCAL_DEFINES,
     visibility = ["//visibility:public"],
diff --git a/third_party/ftxui.BUILD b/third_party/ftxui.BUILD
index 97e4ca8..3aa8a10 100644
--- a/third_party/ftxui.BUILD
+++ b/third_party/ftxui.BUILD
@@ -19,6 +19,7 @@ cc_library(
             "_UNICODE",
             "UNICODE",
         ],
+        "//conditions:default": [],
     }),
     strip_include_prefix = "include",
     visibility = ["//visibility:public"],
diff --git a/third_party/imgui-sfml.BUILD b/third_party/imgui-sfml.BUILD
index eb84244..bbbdaf1 100644
--- a/third_party/imgui-sfml.BUILD
+++ b/third_party/imgui-sfml.BUILD
@@ -17,6 +17,7 @@ cc_library(
     linkopts = select({
         "@platforms//os:linux": ["-lGL"],
         "@platforms//os:windows": ["-DEFAULTLIB:opengl32"],
+        "//conditions:default": ["-lGL"],
     }),
     visibility = ["//visibility:public"],
     deps = [
diff --git a/third_party/sfml.BUILD b/third_party/sfml.BUILD
index 0fc0c8f..adb0635 100644
--- a/third_party/sfml.BUILD
+++ b/third_party/sfml.BUILD
@@ -17,6 +17,10 @@ cc_library(
             "src/SFML/System/Win32/**/*.cpp",
             "src/SFML/System/Win32/**/*.hpp",
         ]),
+        "//conditions:default": glob([
+            "src/SFML/System/Unix/**/*.cpp",
+            "src/SFML/System/Unix/**/*.hpp",
+        ]),
     }),
     hdrs = glob([
         "include/SFML/*",
@@ -31,6 +35,9 @@ cc_library(
         "@platforms//os:windows": [
             "-DEFAULTLIB:winmm",
         ],
+        "//conditions:default": [
+            "-pthread",
+        ],
     }),
     strip_include_prefix = "include/",
     visibility = ["//visibility:public"],
@@ -58,6 +65,10 @@ cc_library(
             "src/SFML/Window/Win32/*.cpp",
             "src/SFML/Window/Win32/*.hpp",
         ]),
+        "//conditions:default": glob([
+            "src/SFML/Window/Unix/*.cpp",
+            "src/SFML/Window/Unix/*.hpp",
+        ]),
     }),
     hdrs = glob(["include/SFML/Window/*"]),
     copts = ["-Iexternal/sfml/src/"],
@@ -74,6 +85,10 @@ cc_library(
             "-DEFAULTLIB:user32",
             "-DEFAULTLIB:winmm",
         ],
+        "//conditions:default": [
+            "-lGL",
+            "-lX11",
+        ],
     }),
     strip_include_prefix = "include/",
     visibility = ["//visibility:public"],
@@ -83,6 +98,10 @@ cc_library(
             "@xrandr",
         ],
         "@platforms//os:windows": [],
+        "//conditions:default": [
+            "@udev-zero",
+            "@xrandr",
+        ],
     }),
 )

@@ -104,6 +123,10 @@ cc_library(
             "-lX11",
         ],
         "@platforms//os:windows": [],
+        "//conditions:default": [
+            "-lGL",
+            "-lX11",
+        ],
     }),
     strip_include_prefix = "include/",
     visibility = ["//visibility:public"],
diff --git a/third_party/spdlog.BUILD b/third_party/spdlog.BUILD
index 2bce3e9..46a3636 100644
--- a/third_party/spdlog.BUILD
+++ b/third_party/spdlog.BUILD
@@ -16,6 +16,7 @@ cc_library(
     linkopts = select({
         "@platforms//os:linux": ["-lpthread"],
         "@platforms//os:windows": [],
+        "//conditions:default": ["-lpthread"],
     }),
     strip_include_prefix = "include",
     visibility = ["//visibility:public"],
diff --git a/third_party/unifex.BUILD b/third_party/unifex.BUILD
index 72fb717..46c473e 100644
--- a/third_party/unifex.BUILD
+++ b/third_party/unifex.BUILD
@@ -16,6 +16,7 @@ cc_library(
             "include/unifex/win32/detail/*.hpp",
             "source/win32/*",
         ]),
+        "//conditions:default": glob(["source/linux/*"]),
     }),
     hdrs = glob([
         "include/unifex/*.hpp",
@@ -23,6 +24,7 @@ cc_library(
     ]) + [":config_header"] + select({
         "@platforms//os:linux": glob(["include/unifex/linux/*.hpp"]),
         "@platforms//os:windows": glob(["include/unifex/win32/*.hpp"]),
+        "//conditions:default": glob(["include/unifex/linux/*.hpp"]),
     }),
     includes = ["include/"],
     strip_include_prefix = "include",
diff --git a/third_party/zlib.BUILD b/third_party/zlib.BUILD
index 71374ba..e853cb8 100644
--- a/third_party/zlib.BUILD
+++ b/third_party/zlib.BUILD
@@ -12,6 +12,7 @@ cc_library(
     local_defines = select({
         "@platforms//os:linux": ["Z_HAVE_UNISTD_H"],
         "@platforms//os:windows": [],
+        "//conditions:default": ["Z_HAVE_UNISTD_H"],
     }),
     visibility = ["//visibility:public"],
 )

Yeah, the conditions being linux/windows is intentional so I can keep track of where we'll have to deal with OS-specific parts. E.g. SFML needs src/SFML/Window/macOS/*.cpp instead of src/SFML/Window/Unix/*.cpp, different font paths in //os/xdg, whatever macOS uses for its display server instead of X11, etc.
If you have a compiler/bazel setup that works on macOS, adding just //util/... to CI would be a good first step since there are no OS-specific bits or dependencies there. Most people that have looked at building hastur for macOS have gotten stuck on the toolchain setup.


Automating VirusSeq release date that was run on DNA stack:

Just a note about this issue that seems to be minor
We could use the following command to extract the VirusSeq release date that was run on DNA stack:
   dnastack collections list | jq -r '.[] | select(.slugName=="virusseq") | .description' | sed -e 's:
:\n:g' -e 's:
:\n:g' | grep 'Release:' | grep -oE '[A-Z][a-z]+ [0-9]{1,2}, [0-9]{4} [0-9]{2}:[0-9]{2} (a.m.|p.m.)'
Note in addition to our dnastack CLI this command requires having jq installed.

Extension of Issue #42

I just test and correct the command line and this one could be used in the download.sh script @anwarMZ
dnastack collections list | jq -r '.[] | select(.slugName=="virusseq") | .description' | sed -e 's:
:\n:g' -e 's:
:\n:g' | grep 'Release:' | grep -oE '[A-Z][a-z]+ [0-9]{1,2}, [0-9]{4} [0-9]{1,2}:[0-9]{2} (a.m.|p.m.)'

Anther alternative without requiring the jq program and uses build in python:


⚠ Bofrost.be has degraded performance

In 8ace042, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1298 ms

Resolved: Bofrost.be performance has improved in d59470e.


Monitoring for MariaDB status needed

What version (commit) do you encounter this issue on?
All
What type of issue is this (bug, feature, documentation, regression)?
Feature
What is the expected behavior?
No more "my number of session hit max_connection setting" situations
What is actually happening?
MariaDB and it's health is virtually unmonitored
What were you attempting to do when you encountered this error (give as much detail as possible)?
We need to monitor important status parameters like

Current Number of DB sessions in relation to max_connection setting
Max_used_connections in relation to max_connection setting
Open_files < open file limit
Innodb_row_lock_time_avg < 5000 ?
Innodb_deadlocks = 0
Aborted_clients < 1/s
Aborted_connects < 1/s
Access_denied_errors = 0

How can we reproduce this issue?

How can we verify your issue is addressed?
Above checks are implemented
If this is a large issue, what can be done immediately to alleviate the issue while working on a longer-term solution?

What is your evaluation on the importance of this issue, and why?

What branches / milestones do you believe this issue should target?
The list below is what is currently supported for backports
Remove branches (lines) you do not wish to target.

[ ] Master
[ ] liberty-12.2

DocImpact: This section is to be completed by the issue owner as part of the issue's resolution.
Does your change require documentation?

[ ] Yes, and I submitted an issue to Docs issues
[ ] Yes, and I contributed a documentation patch to docs-rpc
[ ] No documentation required for this change

@BjoernT there is an existing database plugin and alarms are raised for some of the metrics it generates, are you aware of this? On the face of it, this setup seems to cover some of your request. How do the connection alarms that exist relate to your description of the expected behaviour?

In today's bug triage, we discussed that we might need to add some more metrics/alarms based on @BjoernT's original report.
We need more information around:

thresholds for alarms
which metrics aren't presently being provided by the current galera plugin
whether the customer in question even had MaaS enabled

Added thresholds for the last two alarms

Thanks @BjoernT !

[ ] Reproduce the issue. (N/A)
[ ] Create a PR for fix and/or docs.
[ ] Incorporate feedback from pull request reviews.
[ ]  What is the gating for this on DEV and/or QE? Add related gating if appropriate. Also make sure current gating passes with this fix.
[ ] Reach out to reporter to determine if the fix is resolving the issue.
[ ] What are the upgrade impacts (if any).
[ ] What are the backports are needed (if any).

@BjoernT
"Current Number of DB sessions in relation to max_connection setting"
Cloud you provide a little more insight as to what exactly you are wanting to monitor here? It seems very similar to the point you listed after that:
"Max_used_connections in relation to max_connection setting"
Thanks!

Basically current number of sessions , max_used_connections < max_connections limit

@BjoernT that already seems to be implemented in the plugin here[1].
Did you have anything else in mind? Or is this alarm fine? If it's fine we can just add alarms for the remaining points you mentioned above.
[1] https://github.com/rcbops/rpc-openstack/blob/master/rpcd/playbooks/roles/rpc_maas/templates/galera_check.yaml.j2#L26-L36

Yes when you look at the description, we need to verify which metrics we are checking, I got more listed like deadlocks etc

@BjoernT @sigmavirus24
"Aborted_clients < 1/s
Aborted_connects < 1/s"
These checks might be a little harder to implement, since the each check is done, by default, every 60 seconds. MariaDB also doesn't provide this status variable as a rate of change, but as cumulative value as far as I know.
I could do something with the "Uptime" status variable. I could divide the Uptime with the number of aborted clients, then set a threshold. That way we get the average number of aborted clients relative to the uptime. The tricky part is figuring out a good threshold. If we keep the threshold at 1, then just keep in mind that it will take a while for Uptime/aborted_clients to equal 1 and MaaS won't ever pick up the exact moment aborted_clients > 1/s.
Thoughts?

F.Y.I - PR is up #1242.
Still trying to figure out what the best threshold for Innodb_row_lock_time_avg could be. I'm doing research on this now.

I would actually capture the rate in a small pickle database and then divide it by the time difference  to get per second growth. Using uptime will ruin the results

@BjoernT It looks like the rate function modifier does what I want[1]:
https://developer.rackspace.com/docs/rackspace-monitoring/v1/developer-guide/#constructs-with-function-modifiers

@alextricity25 Yepp looks good

PR #1242 ready for review and feedback.

PR #1242 ready for another look.

This has merged in master. Now waiting for checks to pass for the liberty-12.2 backport. #1269

Features have been added and backported to liberty12-2. I'm closing this.


BUG in menu

How to reproduce this bug:

Go to : http://foundation.zurb.com/sites/docs/
with a touch screen tap for exemple "Tutorial"
=> the menu open
try to tap a submenu example : "Lessons"
=> the menu close an don't open the page

What should happen:
the page sould open the link
What happened instead:
=> the menu close and nothing
The problem is reproductible with
=> chrome on windows 10
=> firefox on windows 10
=> edge on windows 10
=> chrome on android device

First of all, are you talking about phones or tablets ?
Because there is no such menu -> submenu in mobile
there is only hamburger menu  which opens a menu and all the links are there only

I have view this bug with a computer or tablet no with a tel ;)

The code example of the page http://foundation.zurb.com/sites/docs/dropdown-menu.html was affected it's don't change the hash with tap

Yup this is a issue with touch screen!

In short ,
This is a bug specific to Dropdown Menu. The Links are not clickable on any submenu of the dropdown menu within any Touch Screen devices(mobile, desktop, tablet, etc) !
Thanks for reporting.
cc / @kball @gakimball

I don't know if is oki after this  change in /js/foundation.dropdownMenu.js  aparently it work
        // Handle Leaf element Clicks
        if (_this.options.closeOnClickInside) {
          this.$menuItems.on('click.zf.dropdownmenu touchend.zf.dropdownmenu', function (e) {
            var $elem = $(this),
                hasSub = $elem.hasClass(parClass);
            if (!hasSub) {
              return true;      //this is added
              //_this._hide();  //this is remove
            }
          });
        }

in the develop branch it's ok ;)


[Bug]: Tap to page article interrupts scrolling

Steps to Reproduce

Go to settings
Go to  gestures
Turn on 'Tap to page article'
Select a article
Scroll from corners

Expected behavior
Solution: Change 'Tap to scroll' positon to sides of the next article button.

Screenshots or screen recording
No response
Device, Operating system, and app version
Device: Redmi note 8 pro
Android: 11, Miui 12.5
App version: 2024.11.1074-dev

This is working as expected though I'll reword the setting for clarity.
This feature is intended to work as an alternative to swipe scrolling on E Ink devices where scrolling animation can cause UI jank (https://github.com/jocmp/capyreader/discussions/497). So the idea is to use tap scrolling or gesture scrolling but not both.


validate and process traffic split root service as fqdn

The SMI Spec states that the root service in a traffic split should be an fqdn. Currently, we allow a service name with no namespaces suffix as a root service. We also allow a root service with a namespace suffix that is not the same namespace as the namespace where the traffic split is created (we drop the namespace suffix and use the namespace of the traffic split). We also do not validate anything beyond the first element in the root service string after splitting it. Ex. If the root service is "bookstore.foo.hello.world" and the namespace of the traffic split is "bar", we could use the bookstore service in the bar namespace as the root service (bookstore.bar). We also only support Kubernetes services as traffic split root services. This issue is to track the work to correctly process and validate a root service in a traffic split where the root service is a Kubernetes service.

This has already been fixed with #2794


[CFE] Another kind of wrong async return semantics

A similar topic is currently being discussed in #44395, this is different, but shares several characteristics.
Consider the following program:
Future<int> f() async {
  await null; // We're not evaluating the `throw` expression synchronously.
  throw 'f';
}

Future<Future<int>> g() async {
  await null; // We do not reach `f()` synchronously.
  return f();
}

void main() async {
  var x = await g(); // Should just assign the `Future<int>` to `x`, but throws.
  print('Done');
}

The invocation f() should return a Future<int> which is completed with the thrown object and stack trace arising from the throw expression in the body of f. That future has a type (statically and dynamically) which is the future value type of g, and hence that future should be used to complete the Future<Future<int>> which has been returned when g was invoked. In main, this Future<Future<int>> is the value of the evaluation of g(), and it is awaited. The resulting object should be the Future<int> which was completed with an error.
However, the program actually throws rather than assigning that future to x, in dart, whereas dart2js correctly reaches the print statement and completes the execution of main (and at that point it throws, because remaining computations are handled after main terminates).
I would consider this to be a bug in the VM, or in the VM specific Kernel code transformations performed by the CFE. However, I think it would be useful to double check the intended behavior in the language team first.
@lrhn, @leafpetersen, @natebosch, @jakemac53, @stereotype441, @munificent, WDYT?

The g function should indeed return the future as value, not await it and return its value, so g's returned future is completed with the future returned by f().
The var x = await g(); should then assign that value to x and continue unabated, printing Done and then later report an uncaught async error.
That's what dart2js does (according to dartpad.dev), but the VM doesn't print Done.
With more instrumentation:
Future<int> f() async {
  print("4");
  await null; // We're not evaluating the `throw` expression synchronously.
  print("7");
  throw 'f';
}

Future<Future<int>> g() async {
  print("1");
  await null; // We do not reach `f()` synchronously.
  print("3");
  var res = f();
  print("5: $res"); // Should be `5: Instance of 'Future<int>`
  return res;
}

void main() async {
  print("0");
  var fut = g();
  print("2: $fut"); // Should be `2: Instance of 'Future<Future<int>>`
  var x = await fut; // Should just assign the `Future<int>` to `x`, but throws.
  print("6: $x"); // Should be `6: Instance of 'Future<int>`
  print('Done');
}

This prints 1-7 in order when compiled with dart2js (with Done coming before 7 since no-one awaits the completion of the f() future).
On the VM it skips 6 and "Done". The types of the futures are fine. If f returned 1 instead, the VM behaves correctly, so this is error related.
Agree, bug in VM.

Why wouldn't it still be a bug that the VM throws at await fut?

When M4 runs, it notifies listeners on F3.
There are none, and it's an error future, so we report an uncaught top-level error.

I guess the crucial point is that F1 does not count as a listener on F3.
Even though we could say, intuitively, that the error completion has not been orphaned as long as we may await F1 and then await F3, it still counts as an orphaned error completion unless F3 is actually awaited before it is completed.
Is that really the semantics that we want? Maybe the message is that you simply never want to use Future<Future<T>> for any T after all?

The VM doesn't throw at await fut. It just terminates the isolate before it's notified that fut has completed with a perfectly valid Future<int> value. A future value which happens to have already completed with an error at that point, but await fut; doesn't care.

I guess the crucial point is that F1 does not count as a listener on F3.

It doesn't. From the perspective of g (which returns F1), the F3 future returned by f is just a value. It doesn't even know that it's a future, because all it checks is whether it's a Future<Future<int>>, which it isn't. Then it plows full-speed into the value propagation track and completes F1 with F3 as a value. No-one adds a listener on F3 at any point, nor should they since no code here actually waits for, or wants, or even knows what to do with, an int.
The semantics of error futures is that it's an uncaught async error if they complete with an error without having any listener. When you call completeError on a Completer, it's an asynchronous completion, and you have until some later microtask to add an error listener. The general rule is that if a function returns a Future`, you must synchronously await it or attach an error listener. The next microtask might be too late. (Using a synchronous completer, you should be certain that you have already returned/released the future in an earlier microtask, otherwise it's too soon to complete with an error.)
And also heck yes, you never want to use Future<Future<X>>. Ever. For anything. It's bad design! (Why wait for something that you then have to wait for again? Just make it one Future<X>) And it's dangerous because you risk not getting the inner future in time to attach error handlers to it, because we do not promise anything about the order of futures actually being completed, only ever that it's "in a later microtask". If you choose to do Future<Future<X>> anyway, you should either make sure the inner future never has an error, or make sure to .ignore() the error when you receive it, so the error won't be considered uncaught. It's a high caliber foot gun.
You can end up with a Future<Future<X>> by "accident", if you have a generic asynchronous API which you instantiate with a future. In practice that API is likely flawed, and should be documented as "don't use with futures", because you can't ignore asynchrony in asynchronous code. (You should not have a stream of futures either, it's also a double wait where you should only have a single wait, don't tell anyone until the result is actually ready).

@lrhn, thanks for the great analysis! I think there's no obvious improvement on the table, so I'm closing this.


Revisit Link tests

Many builtin links are simple wrappers for corresponding functions. In order to test such link, it should be enough to check whether the underlying function is called with correct arguments.
However, currently, the same checks as the corresponding functions are being done in link tests.
For example, links_tests/connection_tests/test_linear checks whether forward/backward computations are correct, while the same checks are done in functions_tests/connection_tests/test_linear.
Those are duplicated checks which are waste of not only computational resource, but also implementation cost.

This is still an issue.

I will start working on removing duplicate tests (between links and functions) and check if it'll give some improvements in test running time. Additionally, as mentioned in the above comments we'd ideally want to do some basic tests.
Function tests will be further refactored (overhaul) in separate PRs.


Loop basic blocks splitting

Right now, the loop analysis describes the loop by a header Ebb and a list of Ebbs pertaining to the loop. However, because Ebb are extended basic blocks, this description include instructions that are not part of the loop (they are after the back edge branch instruction in the Ebb),
This is a problem because the LICM pass will move upstream instructions that are not in the loop. It does't break the code because moving SSA definitions upwards (in the dominator tree) is always allowed but it will break code locality.
The way to solve this problem is to represent loops in the loop analysis as a list of couples (Ebb,Inst) where Inst is the last back edge to appear in Ebb, Ebb being part of the loop. Then the LICM pass would stop moving instructions around when it reaches Inst.
I will implement that later, the issue is just a reminder.

One problem with this representation is that parts of an EBB can belong to three or more loops if it contains back-edges to different loop headers.
It would be possible to enforce a constraint that an EBB belongs to at most two loops. The loop analysis can split any EBBs that would belong to more than two loops.

Implemented in #133

This is implemented in #133, which is merged in the better_licm pass. Further development tracked by #393.


Bleed-in into previews

[ ] readme styling does not adopt to theming anymore
[ ] table styles are broken


Need new invite link for discord in README.md

Having issues using the discord link

That's odd. I'm not having any issues with that link
Could you try https://discord.gg/9RsCg4pcFz

was able to join with the link on the actual website

weird now that I loook its the same link... not sure why it was having issues then when using it from github


How do you debug this project?

I am trying to set breakpoints and debug this app to better understand some parts.
However I don't get the original source but instead some HTML. Please see screenshots.
Also, And use gulp, why not Webpack 2 ?

@acpower7 Webpack is not the right choice for libraries at the moment. For Material 2 we need a lot of flexibility to generate Metadata files to support AOT and more.
From looking at your sources in the screenshot I can see that you try to open the files from the src/ path.

Once the demo-app is served, the dist/ folder will be served, and all other web requests that are invalid will be redirected to the index HTML file.

You should just the .js files and those will be automatically mapped to the associated TS file.

Thanks for the reply.
I'm not sure I undertand as I can't find a dist folder in the chrome tools, or even an src/ path. The .js files are es5 and .ts files all show html. Can you give me more clear instructions.

What happens if you now click on the slide-toggle folder and open the TS file? Does that work?

No it doesn't. Honestly this whole project has a very poor development process, I would have expected more from Google.

edit

Hey, I really don't want to create a new issue......

Take a look at PR https://github.com/angular/material2/pull/2753 and also notice that the UMD bundles still don't have any sourcemaps. Will will address that in a follow-up PR.

So how do you guys currently debug this library, set breakpoints etc? How do you do it?

So if we run into issues with components:

Most of the time the unit-tests are showing errors and can be solved then easily.
Debugging most of the time does happens in the unit tests and in the demo-app

Also the sourcemaps for the demo-app & e2e-app are only broken since recently.
So basically there is no big secret about debugging here. We just write a lot of tests that can detect issues quickly.


Keyboard support

This project looks very cool, though it unfortunately does not support keyboard led control.
As described in the Aura SDK FAQ at https://www.asus.com/campaign/aura/us/SDK.html, Aura SDK also has support for keyboards (and mice), while this project only supports motherboard, GPU and DRAM control. Please see if it is possible to add a controller for keyboards (mice would of course be nice too, though not relevant in my case).

I'll try to support them, but I'm blind here as I dont have any ROG Keybord or mice.