Leanback launcher missing on fire tv

Leanback launcher not showing up
On Launch on boot 1.1.2
On fire tv

Fire TV is not a target for this project.


Bugfix/correction guidelines text

Changed alignment of Correction Guidelines to leading
Fixed upper case letter of Add/Edit Feedback sheet

Here are the screenshots:


Update to new Google Play design

Originally reported by Joel Pomales:

It appears that the new Google Play music update broke Nuvola Player 2.5. Is the 3 beta any better?

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/14896265-update-to-new-google-play-design?utm_campaign=plugin&utm_content=tracker%2F3931937&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F3931937&utm_medium=issues&utm_source=github).

Closing in favour of tiliado/nuvolaplayer#100


Logout

How to verify which user logout from the portal

according to the jwt token from  req header
i wil send token through  the req


remove pipeline runs after once the build is finished

CLOUDBLD-10154

Signed-off-by: Harsh Modi<EMAIL_ADDRESS>Maintainers will complete the following section

[x] Commit messages are descriptive enough
[x] Code coverage from testing does not decrease and new code is covered
n/a JSON/YAML configuration changes are updated in the relevant schema
n/a Changes to metadata also update the documentation for the metadata
[x] Pull request has a link to an osbs-docs PR for user documentation updates

https://github.com/containerbuildsystem/osbs-docs/pull/216 created

Coverage dropped but it's just the CLI, which we don't seem to test at all


ran 2to3 on repo quick upgrades from python 2 to 3

Ran library https://docs.python.org/3/library/2to3.html on the repo to do an easy quickpass upgrade for some python 2 to python3 items.
The tests all pass if the data is copied in place. Marking them as skips has not been done.

This was merged but github doesn't think so

This was merged but github doesn't think so

Why does GitHub think differently?


recursors eliminating to Type _

This is the same issue as in #5: recursors currently can only be defined if they eliminate to Prop or Sort _. In the HoTT library, I would like to avoid Prop as much as possible, and defining recursors so that they eliminate to Sort _ would require changing most of the library so that it accepts propositions as input.
For example: if we want that trunc.rec and quotient.rec (in init.hit) both eliminate to Sort _, we need to redefine is_trunc n A, eq, pathover to all accept Props (and when I tried that, I got universe issues, probably because we now have max u 1 floating around in many places).
@gebner If you're willing to go through the code of the [recursor] attribute and the induction tactic, and support recursors to Type _ (i.e. Sort (_+1)), then that would be great. If not, then that's also fine, and I'll try to write a hinduction tactic which does exactly that.

I agree, we should be using Type everywhere.  Mixing Type and Sort leads to the level inference problem you've seen.  Maybe it would work if we used Sort instead of Type everywhere, but that's not very pretty.
I am not sure I will be able to modify recursor_info and the induction tactic to support recursors eliminating into Sort (u+1).  It's more than just a cosmetic change, and I'm not sure Leo would accept it.  I guess hinduction is the way to go.

The hinduction tactic now exists and works.


Dataset page - under development catch all

There is many small things here and there issing on the dataset page. This issue is intended to catch all those small issues as we spot them

[ ] doi should resolve to a url
[ ] doi should indicate if it is linking to an external url or the page itself.
[ ] tabs should be async using ui router https://github.com/gbif/portal16/issues/137
[ ] there is missing data for collections, curatorial units and more. go through all possible data and ensure that it is included somewhere or consciously excluded
[ ] metrics tab is largely unimplemented https://github.com/gbif/portal16/issues/138
[ ] taxonomy tab is still in its early stage. how to navigate? async? show species info inline? and much more. See also https://github.com/gbif/portal16/issues/139
[ ] show geographical coverage on map
[ ] when no geographical coverage provided then show card telling that (if no occurrences either)
[ ] origin tab is missing info and styling.
[ ] add sync, modified date in corner as on occurrence pages
[ ] download link is leading no where (we haven't a download page yet)
[ ] hover effects on metrics on landing page so that it is known that they are links
[ ] inform user if we haven't been able to index or isn't done indexing the dataset yet (partial result)
[ ] altmetrics tag if we want to support that
[ ] async counts to make the page load faster
[ ] option to customize your highlighted information
[ ] would be nice to show summary taxonomy info (like largest denominating  taxa or such) - so that it is easy to know what the dataset mainly contains.
[ ] account for html in citation strings. allow italics and links fx

I think the list of vernacular names could be styled to make it more accessible. Something like putting language in caps in front and keeping everything in neat columns. I tried to illustrate my idea here

(if using background color on language it should probably be done nicer than I did ;))
Anyway, just an idea...

@dnoesgaard is this related to dataset or species pages?

My bad, this is of course related to species pages, not to datasets. Sorry!

@MortenHofft from the publisher's perspective, it is very important the existing functionality of the dataset page be retained. Existing functionality that has gone missing and represents a regression and release blocker IMHO include:

Contributor's ORCID missing - https://github.com/gbif/portal16/issues/318
Interpretation issues and other data stats missing from dataset (metrics) page - https://github.com/gbif/portal16/issues/300 & https://github.com/gbif/portal16/issues/138
The metrics tab on dataset page is not shown for checklists - https://github.com/gbif/portal16/issues/331
Dataset page: Links to "occurrences" and "species" are not working - https://github.com/gbif/portal16/issues/312
Alternate identifier "Source webpage" mislabelled 'URL" - https://github.com/gbif/portal16/issues/303
Technically served by link doesn't work - https://github.com/gbif/portal16/issues/302
Confusing and potentially wrong dates shown on dataset page - https://github.com/gbif/portal16/issues/299
Metadata (EML) link gives 404 - https://github.com/gbif/portal16/issues/291
Display general Distribution for dataset - https://github.com/gbif/portal16/issues/320
LInk to dataset homepage? - https://github.com/gbif/portal16/issues/219
Chapter title is covered by tabs - https://github.com/gbif/portal16/issues/306

Hi @kbraak. Thanks. I don't agree that they are all release blockers and/or regressions. So for those we could have someone else evaluating it @ahahn-gbif and @timrobertson100
As an example: take your release blocker " Chapter title is covered by tabs - #306 "
That an anchor scrolls 1 cm too long isn't a release blocker IMHO. The functionality wasn't there before and even if it had been I wouldn't call it a release blocker.
So maybe it would be useful if we aligned our understanding of what a release blocker is?


Update icon links to 1.4

These are still failing. At this point, it's probably just best to wait until the templates PR gets through and I can update it all in bulk.


Create sample.png

Adding a new folder to get a sample image in

did pass checks

Important: Your connector could be running on old configuration. Navigate to the connector configuration window and confirm update to the latest configuration.


split manual into an operator manual and an end user guide?

The current manual contains instructions for both operators and end users. This is confusing.
It may not be possible to get a clean break here, in which case we could just maintain a separate user guide and keep them in sync.

Like what level of elaboration do you want. I can go all out for the LUSER and IRCOP guides.

I think the current manual will become the operator manual. The end user manual will go in a different direction, but I haven't really decided what yet.

Honestly I wonder if we shouldn't just have the 'user manual' in a separate repo, and yeah have it build whenever we do a release but also just have it easily presented on the website too? Users probably aren't going to go out of their way to dig through the ircd release to find a markdown file, we can just link it in the motd or something similar.

Moving to a separate repo might be premature, but a definite +1 for publishing it to the website.
We could also link to the rendered view of the file on the stable branch, since that's what we currently do for the operator manual: https://oragono.io/manual.html

Moving to a separate repo might be premature, but a definite +1 for publishing it to the website.
We could also link to the rendered view of the file on the stable branch, since that's what we currently do for the operator manual: https://oragono.io/manual.html

Why doesnt it just display the manual in markdown or mediawiki or whatever format you like
Like I can expand this to be focused on LUSERs and with channel management. My random attempt at listing out services is  here


kubectl kustomize v. 1.21 not supporting YAML references

What happened:
After upgrading kubectl to version 1.21 kustomize command fails when YAML anchors are references by '<<'
What you expected to happen:
As it was in v. 1.20, command should provide correct output, but not the erorr
How to reproduce it (as minimally and precisely as possible):
Given this 2 files:

kustomization.yaml
api.yaml

kustomization.yaml:
---
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

resources:
  - api.yaml

api.yaml:
apiVersion: v1
kind: Service
metadata:
  name: service
  labels: &labels
    label: test
spec:
  selector:
    <<: *labels

Execute kubectl kustomize . and see the following output:
v. 1.20:
apiVersion: v1
kind: Service
metadata:
  labels:
    label: test
  name: service
spec:
  selector:
    label: test

v. 1.21:
Error: map[string]interface {}{"apiVersion":"v1", "kind":"Service", "metadata":map[string]interface {}{"labels":map[string]interface {}{"label":"test"}, "name":"service"}, "spec":map[string]interface {}{"selector":map[interface {}]interface {}{"label":"test"}}}: json: unsupported type: map[interface {}]interface {}

So, now kubectl cannot recognize << while parsing yaml. Replacement with any string fixes the issue. Even "<<" fixes it.
Environment:

Server version doesn't matter, 'cause it's happening on a client command step

It may be fixed just by flattening api.yaml like this
apiVersion: v1
kind: Service
metadata:
  name: service
  labels: &labels
    label: test
spec:
  selector: *labels

but it's very strange to have previous version working with YAML standard syntax and newest version not.

It can be fixed by changing api.yaml to
apiVersion: v1
kind: Service
metadata:
  name: service
  labels: &labels
    label: test
spec:
  selector: *labels

but it's strange to see that previous version of tool was working with standard YAML syntax and the newest one isn't

We have been experiencing a lot of issues with regard to the use of anchors. Following YAML that used to work with kubectl v1.20.4 no longer seems to be working and errors out with the message : node must be a scalar, sequence or map.
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
   name: &app my-app
 subjects:
 - kind: ServiceAccount
   name: *app
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
   name: *app

Also rendering https://github.com/knative-sandbox/eventing-kafka-broker/releases/download/v0.22.1/eventing-kafka-controller.yaml using kubectl kustomize errors out due to the following usage:
          livenessProbe:
            !!merge <<: *probe
            initialDelaySeconds: 20

Similarly rendering https://github.com/knative-sandbox/eventing-kafka/releases/download/v0.22.3/source.yaml errors out due to the use of YAML anchors.

Kubectl 1.21 contains a large version bump to Kustomize, from v2 to v4. There are already several issues open on the Kustomize repo about problems with YAML anchors. Please follow along there. I believe the most relevant to this particular case is https://github.com/kubernetes-sigs/kustomize/issues/3614.
/triage duplicate
/close


Xargo: Suggest overriding the toolchain to nightly instead of changing it for the whole system

In production environments and many other places it is desirable not to depend on non-stable features, as much as possible. As a consequence, I suggest to replace the line that changes the toolchain to nightly globally, to an override, to change only for the current project:
 rustup default nightly

to be replaced with:
rustup override set nightly

Or even better (for those folders which are also a repository): create a rust-toolchain file with nightly in it, like clippy does for its own repo:
https://github.com/rust-lang/rust-clippy/blob/master/rust-toolchain#L1

@eddyp Thanks for the suggestion, implemented in 45bdfd20b5a34fe956b6a7812edd2c744fee4cd5


proposal: x/pkgsite: package tours (additional documentation type for packages)

Proposal Details
Background
Go packages can have two distinct forms of documentation:

Comments anchored to identifiers as described by Godoc: documenting Go code and Go Doc Comments.

Runnable (API) examples as described by Testable Examples in Go

Both of these are rendered in godoc and pkgsite.
These two forms of documentation serve somewhat overlapping/disjoint purposes:

Go documentation comments are mostly in the vein of reference manual.
Runnable (API) examples are minimal viable demonstrations of an API at the very least to sometimes complete end-to-end examples (which it is is predicated by how complicate the API is to work with).

Problem
In this public discussion, it became clear that a type of documentation is missing for users: step-by-step tutorials or material that focuses on an end-to-end developer journey.  This led to a thought about how we could fix this gap in a nice Go-like way.
Proposal
What if we expanded the documentation servers to enable users to create their own API tours à la A Tour of Go?  A package could have multiple tours to demonstrate the journeys.
Imagine a hypothetical Go module at github.com/matttproud/rot13 that follows a directory structure like this:
$ tree rot13
rot13
├── cmd
│   └── rot13
│       ├── rot13.go
│       ├── rot13_test.go
│       └── rot13_x_test.go
├── endtoend
│   ├── endtoend_test.go
│   └── testdata
│       ├── input.txt
│       └── output.txt
├── go.mod
├── rot13.go
├── rot13_test.go
└── rot13_x_test.go

We could have a directory structure like this:
rot13
│   … earlier elements elided …
├── tours
│   ├── basic.article
│   └── advanced.article
│   … later elements elided …

Then the respective documentation servers would have some sort of internal support to run tours (e.g., use what binary tour uses).  When viewing the respective package in the viewer, the table of contents for the package would also include a heading that lists sub-elements of available tours (tracer shot):

This has the advantage of keeping the documentation for extended workflows adjacent to the code so that it can be always fresh.
Perhaps this could even be extended to support the present tool, too.
Rejected Alternatives
There is technically a third form available: the blog post (e.g., Go Concurrency Patterns: Context), but …

these blog posts are seldom back-linked to the Go package documentation.
findability is not great either with the blog posts (especially older ones).
sometimes the blog posts are superseded with new information/methodologies.

@fzipp That's true and arguably omitted from the top-comment. But I think a guided tour is still a qualitatively different and more helpful form of documentation, especially when considering that there might be multiple scenarios.

There are several cross-cutting considerations here:

The community has done a particularly good job socializing what good documentation is.  A poignant example to me is that for over a decade, there was a set of undocumented syntax rules before the article Go Doc Comments was published.  I don't fault the Go Team for that.
Documentation for a user journeys is somewhat similar to the concept of a codewalk here.  The thing is, due to the implicit need for pagination or sectioning of the documentation (e.g., Step 1. Open drawer, Step 2. Pull out carrot peeler, etc) with the amount of structuring required, potential length, and the number of different journeys a package could have, the top-level documentation block for a package could get very unwieldy.  Some of existing standard library packages do have long ones, but I can think of a couple of foundational business logic libraries in my workplace that are not too complicated but that would easily add multiple hundreds of lines to a hypothetical package's doc.go file.  The package's central documentation is fine for some things, but not others.  Nevertheless, I fully agree that it is underutilized.
It seems like there isn't consensus among the Go Team on what is appropriate package documentation versus external documentation (e.g., 1 and 2: these are all points/misunderstandings that have caused users to trip up that I wanted to clarify).  This is to say that if I wanted to document more user journeys of standard library APIs, I suspect these contributions would be easily accepted in ordinary Go documentation comments or even as examples.

We need a multi-pronged solution to documentation.  Developers who want do the right thing (there are many of us who do) simply do not have the means.

I use the example docs extensively in my open source projects. If I could build a programmatically tested tour with the Go tool, I would probably do that instead of using a README because the README can get out of sync pretty easily.


add leminiscate calculator

fix #2120
Added leminiscate calculator

@khareyash05 I just wanted to ask that can we make the PR even before the issue is assigned?

@sairish2001 Kindly help me with these conflicts


Incorrect matbench folds when performing classification

The classification option is not being passed through to the final k-fold call (which should select StratifiedKFold and not KFold. This will not affect any results for balanced input data sets.

Closed by #55.


[Feature] Adds basic support for image content in OpenAI chat routes

This adds piping so that OpenAI Chat Requests can forward input images to be properly processed by LLaVa type models.  This includes a bit of piping, expanded OpenAI request types (copied from openai-python) and some testing.
I've tested this manually by running:
python3 -m sglang.launch_server --model-path liuhaotian/llava-v1.5-7b --tokenizer-path llava-hf/llava-1.5-7b-hf --chat-template vicuna_v1.1 --port 30000

and
python test/srt/test_openai_server.py

Output came out as expected:
 Paris. The country is known for its rich history, art, culture, and cuisine. It is also home to the
 United Nations Educational,
 Paris. The country is known for its rich history, art, culture, and cuisine. It is also home to the
 United Nations Educational,
 The capital of France is Paris. (pronounced "Par-ee")
 The image displays a graph with various data points, including a line that goes from 0 to 100.

There are several other lines on
 1. United States - Washington D.C.
2. Canada - Ottawa
3. Mexico - Mexico City

@fozziethebeat Thanks!

Thanks for taking the contribution!


char-list-to-string not defined in Emacs 24

First, thanks for the awesome package. It made my day!
I'm trying the Emacs script, but I'm getting the following:
equal: Symbol's function definition is void: char-list-to-string

I'm running Emacs 24 on MacOSX. Thanks!

I think I've fixed it in this commit: https://github.com/Paczesiowa/hsenv/commit/884627ed96c029f5b87fb7a3a82b0d78da26716e (btw. virthualenv changed name to hsenv). if it still doesn't work, please open a new issue on hsenv's issue tracker.

Yes, thank you very much. That fixed it! Also moved over to hsenv.


Books menu

Complete HTML integration of books menu:

Upon clicking the button, we must be taken to the specific book type (fiction or non-fiction)
Upon clicking further buttons, we must be taken to the specific genre of books in each type of book

Completed


[Feature Request] Changes to Reference CodeLens.

 Wouldn't it be great if they were to be improved?
Here are my problems:

Enums look horrible:

0 References just looks annoying here:

Am I going to use these anywhere except inside the only class they can be accessed in?:

Code Lens looks too much like a whole line (reducing the font size doesn't help):

So, here are some solutions with some mockups:

Remove reference Code Lens from enum items:

Add an option to disable Code Lens if there are no references:

Add an option to disable Code Lens for private and/or protected members:

Add an option to use Line Lens instead (what the Ionide extension uses):

There can also be an alternative solution to all this: put the reference Code Lens inside the gutter:

If you can't do this due to some limitations, I'll report this as an issue on Visual Studio Code.

Closed because this idea is dead.

forgot to close


Rework of CIVREP penalties for destroying buildings

Current state:
All home buildings (with the exceptions of buildings defined in KP_liberation_cr_ign_buildings per map) are counted on mission load and on sector capture. If the count of buildings on sector capture is smaller - a CIVREP penalty is deducted. (On Talvivaara penalty per building is set to 0).
Suggested change:
Instead lowering rep on destroying most of the home buildings and possibly having to expand the KP_liberation_cr_ign_buildings list enormously to include weird cases of walls being considered homes etc. It might be cooler to have a per map list of "important buildings" (ex. two story brick buildings in Talvivaara, admin building etc., not wooden huts) that will have the penalty for destruction (possibly higher than currently).
A list like that would probably be fairly easy to do on small (and historical) maps with not many cities (ex. Talvivaara - not that many big buildings) but would be way more time consuming to make on big (especially vanilla) maps.

Also we could count the destroyed homes as currently, but deduct some smaller penalty every X destroyed homes globally


derive(Schema) introduces incorrect bounds instead of doing perfect derive

This is a known issue in Rust that derive(Clone), derive(PartialEq), etc., don't infer the proper bounds. They will require each type parameter to implement the trait instead of looking at what is actually needed by the type definition (called perfect derive).
For some reason, serde derive macros do perfect derive. It would be nice if Schema derive macro would also do so. Here is a small reproduction example:
# Cargo.toml
[package]
name = "foo"
version = "0.1.0"
edition = "2021"

[dependencies]
postcard = { version = "1.0.8", features = ["experimental-derive"] }
serde = { version = "1.0.201", features = ["derive"] }

[patch.crates-io.postcard]
git = "https://github.com/jamesmunns/postcard.git"
rev = "4e1104d9e2e1ef6f9b2473cf5da7d9d58fd8f6fd"

// src/lib.rs
use postcard::experimental::schema::Schema;
use serde::{Deserialize, Serialize};

pub trait View<'a> {
    type Type<T: Wire<'a>>: Wire<'a>;
}

#[derive(Serialize, Deserialize, Schema)]
pub enum Api<'a, T: View<'a>> {
    Foo(T::Type<Foo<'a>>),
}

#[derive(Serialize, Deserialize, Schema)]
pub struct Foo<'a> {
    buf: &'a [u8],
    ret: u32,
}

pub enum Id {}
impl<'a> View<'a> for Id {
    type Type<T: Wire<'a>> = T;
}

pub trait Wire<'a>: Serialize + Deserialize<'a> + Schema {}
impl<'a, T: Serialize + Deserialize<'a> + Schema> Wire<'a> for T {}

#[test]
fn api_schema() {
    let schema = Api::<Id>::SCHEMA;
}

Running cargo test gives the following error:
error[E0599]: the variant or associated item `SCHEMA` exists for enum `Api<'_, Id>`, but its trait bounds were not satisfied
   --> src/lib.rs:29:29
    |
9   | pub enum Api<'a, T: View<'a>> {
    | ----------------------------- variant or associated item `SCHEMA` not found for this enum because it doesn't satisfy `Api<'_, Id>: Schema`
...
19  | pub enum Id {}
    | ----------- doesn't satisfy `Id: Schema`
...
29  |     let schema = Api::<Id>::SCHEMA;
    |                             ^^^^^^ variant or associated item cannot be called on `Api<'_, Id>` due to unsatisfied trait bounds
    |
    = note: trait bound `Id: Schema` was not satisfied
    = note: the following trait bounds were not satisfied:
            `Api<'_, Id>: Schema`
            which is required by `&Api<'_, Id>: Schema`

In particular, it thinks that Id must implement Schema, while only Id::Type<Foo<'a>> (i.e. Foo<'a>) needs to.
When looking at the cargo expand output, we can see the difference between serde::Serialize and postcard::Schema:
    #[automatically_derived]
    impl<'a, T: View<'a>> _serde::Serialize for Api<'a, T>
    where
        T::Type<Foo<'a>>: _serde::Serialize, // This is the correct bound.
    { ... }
// versus
impl<
    'a,
    T: View<'a> + ::postcard::experimental::schema::Schema, // This is an incorrect bound.
> ::postcard::experimental::schema::Schema for Api<'a, T> { ... }

This issue is blocking #143.

I am very open to getting this fixed, but my proc-macro skills are fairly limited. If you can find a way to do it, I'm all ears.


Newbie, encryption passphrase help needed

Please paste the output of the following command here: sudo edit-chroot -all
![screenshot 2017-02-23 at 5 06 57 pm](https://cloud.githubusercontent.com/assets/20023802/23286132/802e74f6-f9ea-11e6-9a23-ee709c7ad9ed.png)

Password:
name: precise
encrypted: yes, locked
Unmounting /mnt/stateful_partition/crouton/chroots/precise. . .

Please describe your issue:
I am brand new to using crouton or actually hacking in any sense, if not to basic coding. I was trying to install crouton and every time I attempted to install it it required an encryption passphrase. I've only been playing with crosh for about a day and I don't recall setting this passphrase. Is it asking me to set one? In which case why does it say "failed to decrypt precise"? Please help!
(line of code: //(its -u because if I don't update the folder it says "theres already something in that folder"
chronos@localhost / $ sudo sh ~/Downloads/crouton -e -t xfce -u
/usr/local/chroots/precise already exists; updating it...
Enter encryption passphrase for precise: "BLAH BLAH BLAH"
Failed to decrypt precise
I have tried my password I set, my username, ENTER, precise, and just about anything else I could think of.
-Pocky
If known, describe the steps to reproduce the issue:

@Pocky4141,
You don't have to encrypt your chroot, it's just an option that's important to some.
Also, even if you do want to encrypt your chroot you can do it after installation and configuration.
If you can't get into your chroot you may be better off deleting it and starting over.
To delete it, use this: `
sudo delete-chroot -n precise
To install a crouton chroot without encryption initially just leave out the '-e' option, like -
sudo sh ~/Downloads/crouton -t xfce
Once installed and setup you can encrypt it if you like with an update, like -
sudo sh ~/Downloads/crouton -e -u
Also, without specifying a 'release' with the '-r' option you'll get the default 'precise' release.
Hope this helps,
-DennisL

Ah wonderful thanks


add ability to compute aggregated stage damage functions

to support HEC-FDA, we need the ability to compute aggregated stage damage functions.
The inputs to the aggregated stage damage function will simply be a series of hydraulic data providers, an aggregation location, and a structure provider.
the output will be a x values of elevation, and an inline histogram for each x value representing damages.

Test dataset here: https://drive.hecdev.net/share/pi6ztii8

gratzi


feat(#29): texts, text-embeddings

ref #29

PR-Codex overview
The focus of this PR is to enhance text processing and embedding generation for repositories.
Detailed summary

Added textualize_repos.py to create textual metadata for repositories.
Updated embed.py to use "texts" as the source for embeddings.
Modified similar.py to read from a specified corpus file.
Created textualize.py to combine repository text data into a single field.
Added tests for textualize.py and english.py.
Updated file names and content related to text processing.

The following files were skipped due to too many changes: steps/semantic_similarity.py

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@h1alexbel OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@h1alexbel Done! FYI, the full log is here (took me 13min)


editor does not respond while saving scene has GIProbe

Operating system or device, Godot version, GPU Model and driver (if graphics related):
master 6aa331e
Issue description:

editor does not respond while saving scene has GIProbe.
it happens often.
Steps to reproduce:
try to save a scene has GIProbe multiple times.
then it stuck on saving.
I think it stuck in this loop.
https://github.com/godotengine/godot/blob/master/servers/visual/visual_server_scene.cpp#L334-L337
Link to minimal example project:

save_giprobe_scene.tar.gz

open this project
select Spatial node
add instance child scene
select main.tscn
save scene

can you procure a demo scene that triggers this? I have never encountered
this problem
On Mon, Nov 27, 2017 at 9:21 AM, volzhs<EMAIL_ADDRESS>wrote:

[image: image]
https://user-images.githubusercontent.com/8281454/33266403-dbc7f42e-d3b8-11e7-80cc-5ee135c8db43.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/13338#issuecomment-347166074,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z24XbkDhz2sfW-0tuYvI5HkqGB_Hpks5s6qk8gaJpZM4QrjCK
.

@reduz try to do ctrl+s multiple times fast.
It happens randomly.

@reduz

it happens material tester demo also (with gi probe)
it happens more often when play scene.

@reduz
save_giprobe_scene.tar.gz

open this project
select Spatial node
add instance child scene
select main.tscn
save scene

still happen with attached example project. :cry:

will try to fix today
On Wed, Nov 29, 2017 at 8:46 AM, volzhs<EMAIL_ADDRESS>wrote:

still happen with attached example project. 😢
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/13338#issuecomment-347836606,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z219WhhOP-sLxGJLMb0n9z8Gu2kloks5s7UQdgaJpZM4QrjCK
.

I could reproduce it with the current master branch using https://github.com/Calinou/godot-sponza. It does not happen all the time, but it did happen for me right now (this was when autosaving the scene to play it, after having changed project settings without hitting save manually).
As debugged by @volzhs, there's an infinite sleep loop:
(gdb) bt
#0  0x0000003d94c103ed in nanosleep () from /lib64/libpthread.so.0
#1  0x000000000157603e in OS_Unix::delay_usec (this=0x7fffd697c070, p_usec=1) at drivers/unix/os_unix.cpp:267
#2  0x000000000255fb0f in VisualServerScene::instance_set_base (this=0x7f8edfe3e020, p_instance=..., p_base=...) at servers/visual/visual_server_scene.cpp:336
#3  0x0000000002569528 in VisualServerScene::free (this=0x7f8edfe3e020, p_rid=...) at servers/visual/visual_server_scene.cpp:2961
#4  0x00000000024ea84e in VisualServerRaster::free (this=0x47a82f0, p_rid=...) at servers/visual/visual_server_raster.cpp:78
#5  0x00000000025041d8 in VisualServerWrapMT::free (this=0x47e4010, p1=...) at servers/visual/visual_server_wrap_mt.h:537
#6  0x0000000001fcaa2e in VisualInstance::~VisualInstance (this=0x184c33f0, __in_chrg=<optimized out>) at scene/3d/visual_instance.cpp:134
#7  0x0000000001f8d1ad in GIProbe::~GIProbe (this=0x184c33f0, __in_chrg=<optimized out>) at scene/3d/gi_probe.cpp:1524
#8  0x00000000011438ef in memdelete<Node> (p_class=0x184c33f0) at core/os/memory.h:117
#9  0x0000000001c81817 in Node::_notification (this=0x1885fa30, p_notification=1) at scene/main/node.cpp:163
#10 0x0000000000ec064e in Node::_notificationv (this=0x1885fa30, p_notification=1, p_reversed=true) at ./scene/main/node.h:45
#11 0x0000000001f5a7e1 in WorldEnvironment::_notificationv (this=0x1885fa30, p_notification=1, p_reversed=true) at scene/3d/scenario_fx.h:41
#12 0x000000000275b2ec in Object::notification (this=0x1885fa30, p_notification=1, p_reversed=true) at core/object.cpp:923
#13 0x0000000002758435 in Object::_predelete (this=0x1885fa30) at core/object.cpp:385
#14 0x0000000002763688 in predelete_handler (p_object=0x1885fa30) at core/object.cpp:1904
#15 0x00000000011438cf in memdelete<Node> (p_class=0x1885fa30) at core/os/memory.h:115
#16 0x0000000001713576 in EditorNode::_save_scene (this=0x75596c0, p_file=..., idx=-1) at editor/editor_node.cpp:1031
#17 0x0000000001712e67 in EditorNode::_save_scene_with_preview (this=0x75596c0, p_file=..., p_idx=-1) at editor/editor_node.cpp:980
#18 0x0000000001719a2e in EditorNode::_run (this=0x75596c0, p_current=false, p_custom=...) at editor/editor_node.cpp:1763
#19 0x000000000171d6f7 in EditorNode::_menu_option_confirm (this=0x75596c0, p_option=38, p_confirmed=false) at editor/editor_node.cpp:2251
#20 0x000000000170fba5 in EditorNode::_menu_option (this=0x75596c0, p_option=38) at editor/editor_node.cpp:664
#21 0x0000000000fbbcfe in MethodBind1<int>::call (this=0xc4ad160, p_object=0x75596c0, p_args=0x1848dc30, p_arg_count=1, r_error=...) at core/method_bind.gen.inc:729
#22 0x000000000275b16f in Object::call (this=0x75596c0, p_method=..., p_args=0x1848dc30, p_argcount=1, r_error=...) at core/object.cpp:913
#23 0x000000000275c93b in Object::emit_signal (this=0x99f2ad0, p_name=..., p_args=0x7fffd6979ce0, p_argcount=0) at core/object.cpp:1194
#24 0x000000000275ce93 in Object::emit_signal (this=0x99f2ad0, p_name=..., p_arg1=..., p_arg2=..., p_arg3=..., p_arg4=..., p_arg5=...) at core/object.cpp:1239
#25 0x0000000001d4ffaf in BaseButton::_gui_input (this=0x99f2ad0, p_event=...) at scene/gui/base_button.cpp:145
#26 0x00000000017ddd4e in MethodBind1<Ref<InputEvent> >::call (this=0x536b150, p_object=0x99f2ad0, p_args=0x7fffd697ab10, p_arg_count=1, r_error=...) at core/method_bind.gen.inc:729
#27 0x000000000275a51a in Object::call_multilevel (this=0x99f2ad0, p_method=..., p_args=0x7fffd697ab10, p_argcount=1) at core/object.cpp:747
#28 0x000000000275ad57 in Object::call_multilevel (this=0x99f2ad0, p_name=..., p_arg1=..., p_arg2=..., p_arg3=..., p_arg4=..., p_arg5=...) at core/object.cpp:853
#29 0x0000000001cadacf in Viewport::_gui_call_input (this=0x5b0a620, p_control=0x99f2ad0, p_input=...) at scene/main/viewport.cpp:1461

I did some changes that may fix it, but I'm not sure because I still can't reproduce. Please give it a check.

it still happens with 431dfc14585fa12750b2c1ef2e7efaeed6df2f68


SyntaxError error int_adyen_controllers/cartridge/controllers/Adyen.js#587

SyntaxError
Sitegenesis 104.0.0
Code version compatibility mode: 18.10
Adyen 20.1.3
To Reproduce
Reach shipping page - 404 page will be presented instead
ERROR PipelineCallServlet|16165454|Sites-SiteGenesis-Site|COShipping-Start|PipelineCall|UqVsEFTq6x custom []  Error while executing script 'app_storefront_controllers/cartridge/controllers/COShipping.js': syntax error (int_adyen_controllers/cartridge/controllers/Adyen.js#587)
function clearAdyenData(paymentInstrument) {
Transaction.wrap(() => {
paymentInstrument.custom.adyenPaymentData = null;
paymentInstrument.custom.adyenMD = null;
});
}
It works with
function clearAdyenData(paymentInstrument) {
Transaction.wrap(function() {
paymentInstrument.custom.adyenPaymentData = null;
paymentInstrument.custom.adyenMD = null;
});
}
Same for
cartridges/int_adyen_controllers/cartridge/scripts/payment/processor/Adyen_Component.js :116
Same for int_adyen_overlay/cartridge/scripts/adyenLevelTwoThreeData.js:61
ERROR PipelineCallServlet|28077616|Sites-SiteGenesis-Site|COSummary-Submit|PipelineCall|UqVsEFTq6x custom []  Error while executing script 'app_storefront_controllers/cartridge/controllers/COSummary.js': syntax error (int_adyen_overlay/cartridge/scripts/adyenLevelTwoThreeData.js#61)
at int_adyen_overlay/cartridge/scripts/adyenCheckout.js:53
ERROR PipelineCallServlet|29120317|Sites-SiteGenesis-Site|COSummary-Submit|PipelineCall|UqVsEFTq6x custom []  Error while executing script 'app_storefront_controllers/cartridge/controllers/COSummary.js': invalid property id (int_adyen_overlay/cartridge/scripts/adyenLevelTwoThreeData.js#70)
ES6 is not supported, can you please update all occurrences or add a list in integration guide about compatible versions of Sitegenesis

Hey @milica-popovic-osf,
Thanks for pointing this out. It is indeed not transpiling properly on some environments.
in that case try replacing the contents of the file babel.config.js with
/* eslint-disable */
module.exports = function (api) {
  api.cache(true);
  return {
    presets: [["@babel/preset-env"]],
    plugins: [
      ["@babel/plugin-transform-runtime", { helpers: false }],
      "@babel/plugin-proposal-optional-chaining",
      ["@babel/plugin-proposal-decorators", { legacy: true }],
      "@babel/plugin-proposal-class-properties",
    ],
    exclude: "node_modules/**",
  };
};

and also install any missing modules (i.e. @babel/plugin-proposal-decorators and @babel/plugin-transform-runtime)
In the meantime we'll work on a proper fix for this for the following release.
Regards,
Zaid
Adyen

Hi,
I am using the last version of your cartdrige in SFRA and the trick worked.
I also had to make a correction in the transpiled Adyen.js at line 549.  I removed the JSON.parse of the variabile connectedTerminals.
Thank you


ENH: API Docstrings

WORK IN PROGRESS. @ebolyen & @nbokulich, feel free to push docstrings to this branch.

This can be reviewed whenever - I have been building the development builds of the dev-docs against this PR, btw.


Fix incorrect SQL generated by row_number composed with other things

Also adds an implementation of row_number() for the postgres backend
Closes #868

Thanks!


Falcon 4 Allied Forces

MSI Afterburner reports this game originally as "DD" which is directdraw 1-7. With dxwrapper, I can make it run in D3D9.
But RTX can run only in the main menu. When I click "Fly" to start the 3D part, it goes to a non responding state and game crashes. If I do not inject RTX, the game runs fine.

[General]
RealDllPath                = AUTO
WrapperMode                = AUTO
LoadCustomDllPath          =
ExcludeProcess             =
IncludeProcess             =
RunProcess                 =
WaitForProcess             = 0
DisableLogging             = 0

[Plugins]
LoadPlugins                = 0
LoadFromScriptsOnly        = 0

[Compatibility]
Dd7to9                     = 1
D3d8to9                    = 0
DDrawCompat                = 0
Dinputto8                  = 0
DisableGameUX              = 0
EnableDdrawWrapper         = 1
EnableD3d9Wrapper          = 1
EnableDinput8Wrapper       = 0
EnableDsoundWrapper        = 0
HandleExceptions           = 0
SingleProcAffinity         = 0

[DDrawCompat]
DDrawCompat20              = 0
DDrawCompat21              = 0
DDrawCompat32              = 0
DDrawCompatDisableGDIHook  = 0
DDrawCompatNoProcAffinity  = 0

[ddraw]
ConvertToDirectDraw7       = 0
ConvertToDirect3D7         = 0
DdrawOverrideBitMode       = 0

[Dd7to9]
DdrawAutoFrameSkip         = 0
DdrawEmulateSurface        = 0
DdrawEmulateLock           = 0
DdrawForceMipMapAutoGen    = 0
DdrawFlipFillColor         = 0
DdrawFixByteAlignment      = 0
DdrawEnableByteAlignment   = 0
DdrawRemoveScanlines       = 0
DdrawRemoveInterlacing     = 0
DdrawReadFromGDI           = 0
DdrawWriteToGDI            = 0
DdrawDisableDirect3DCaps   = 0
DdrawLimitDisplayModeCount = 0
DdrawCustomWidth           = 0
DdrawCustomHeight          = 0
DdrawUseNativeResolution   = 0
DdrawOverrideWidth         = 0
DdrawOverrideHeight        = 0
DdrawIntegerScalingClamp   = 0
DdrawMaintainAspectRatio   = 0

[d3d9]
AnisotropicFiltering       = 0
AntiAliasing               = 0
EnableVSync                = 0
ForceVsyncMode             = 0
OverrideRefreshRate        = 0
LimitPerFrameFPS           = 0
EnableWindowMode           = 1
WindowModeBorder           = 1
SetInitialWindowPosition   = 0
InitialWindowPositionLeft  = 0
InitialWindowPositionTop   = 0
FullscreenWindowMode       = 0
ForceExclusiveFullscreen   = 0
ForceMixedVertexProcessing = 0
ForceSystemMemVertexCache  = 0
SetSwapEffectShim          = 0
DisableMaxWindowedMode     = 0
ForceDirect3D9On12         = 0
GraphicsHybridAdapter      = 0

[FullScreen]
FullScreen                 = 0
ForceWindowResize          = 0
WaitForWindowChanges       = 0

[dinput8]
DeviceLookupCacheTime      = 0
FilterNonActiveInput       = 0
FixHighFrequencyMouse      = 0
MouseMovementFactor        = 0
MouseMovementPadding       = 0

[dsound]
Num2DBuffers               = 0
Num3DBuffers               = 0
ForceCertification         = 0
ForceExclusiveMode         = 0
ForceSoftwareMixing        = 0
ForceHardwareMixing        = 0
ForceHQ3DSoftMixing        = 0
ForceNonStaticBuffers      = 0
ForceVoiceManagement       = 0
ForcePrimaryBufferFormat   = 0
PrimaryBufferBits          = 16
PrimaryBufferSamples       = 44100
PrimaryBufferChannels      = 2
AudioClipDetection         = 0

LOGS:
13276 00:28:01.106 Starting DxWrapper v1.2.7200.25
13276 00:28:01.106 Running from: D:\Games\Falcon 4 Allied Forces\dxwrapper.dll
13276 00:28:01.106 Reading config file: D:\Games\Falcon 4 Allied Forces\dxwrapper.ini
13276 00:28:01.107 Micro-Star International Co., Ltd. MS-7C56 1.0 (Desktop)
13276 00:28:01.107 Micro-Star International Co., Ltd. MPG B550 GAMING PLUS (MS-7C56) 1.0 (Desktop)
13276 00:28:01.107 NVIDIA GeForce RTX 4070 SUPER
13276 00:28:01.107 Windows 10 Enterprise 64-bit (10.0.22621)
13276 00:28:01.107 FalconAF.exe (PID:25108)
13276 00:28:01.112 Environment variable __COMPAT_LAYER = "DWM8And16BitMitigation HighDpiAware"
13276 00:28:01.112 Windows is newer than, Windows Vista: 1 Windows 7: 1 Windows 8: 1
13276 00:28:01.112 Disabling High DPI Scaling...
13276 00:28:01.112 Loaded library: user32.dll
13276 00:28:01.112 Loaded library: shcore.dll
13276 00:28:01.112 Loading 'ddraw.dll'...
13276 00:28:01.112 Hooking ddraw.dll APIs...
13276 00:28:01.200 Loaded library: d3d9.dll
13276 00:28:01.200 Enabling ddraw wrapper
13276 00:28:01.200 Enabling d3d9 wrapper
13276 00:28:01.200 Loading 'd3d9.dll'...
13276 00:28:01.200 Loaded library: C:\Windows\system32\d3d9.dll
13276 00:28:01.200 Hooking d3d9.dll APIs...
13276 00:28:01.200 Loaded library: winmm.dll
13276 00:28:01.200 Installing memory management hooks
13276 00:28:01.200 Installing messaging hooks
13276 00:28:01.200 Installing display mode hooks
13276 00:28:01.201 Installing registry hooks
13276 00:28:01.201 Installing Win32 hooks
13276 00:28:01.201 Installing GDI & User32 hooks
13276 00:28:01.201 Loaded library: gdi32.dll
13276 00:28:01.201 Loaded library: kernel32.dll
13276 00:28:01.201 DxWrapper loaded!
13276 00:28:01.248 dd_DirectDrawEnumerateExA
13276 00:28:01.248 d9_Direct3DCreate9
13276 00:28:01.248 Redirecting 'Direct3DCreate9' ...
13276 00:28:01.618 Creating interface m_IDirect3D9Ex::m_IDirect3D9Ex (00EBCB60) IID_IDirect3D9
13276 00:28:01.619 m_IDirect3D9Ex::LogAdapterNames Adapter: 0 \.\DISPLAY1 NVIDIA GeForce RTX 4070 SUPER
13276 00:28:01.619 dd_DirectDrawCreateEx
13276 00:28:01.619 Direct3D9SetSwapEffectUpgradeShim Calling 'Direct3D9SetSwapEffectUpgradeShim' ... 0
13276 00:28:01.619 Redirecting 'DirectDrawCreate' IID_IDirectDraw7 to --> 'Direct3DCreate9'
13276 00:28:01.619 Creating interface m_IDirectDrawX::m_IDirectDrawX (00EA8B70) converting interface from v7 to v9
13276 00:28:01.619 Redirecting 'Direct3DCreate9' ...
13276 00:28:01.619 Creating interface m_IDirect3D9Ex::m_IDirect3D9Ex (00EBCB80) IID_IDirect3D9
13276 00:28:01.619 Creating interface m_IDirect3DX::m_IDirect3DX (00EC1FB8) converting interface from v7 to v9
13276 00:28:01.629 m_IDirect3DX::~m_IDirect3DX (00EC1FB8) deleting interface!
13276 00:28:01.629 m_IDirectDrawX::~m_IDirectDrawX (00EA8B70) deleting interface!
13276 00:28:01.629 m_IDirect3D9Ex::~m_IDirect3D9Ex (00EBCB80) deleting interface!
13276 00:28:01.629 m_IDirectDrawSurfaceX::CleanupSharedEmulatedMemory Deleting 0 emulated surfaces!
13276 00:28:01.629 Direct3D9SetSwapEffectUpgradeShim Calling 'Direct3D9SetSwapEffectUpgradeShim' ... 0
13276 00:28:01.629 Redirecting 'DirectDrawCreate' IID_IDirectDraw7 to --> 'Direct3DCreate9'
13276 00:28:01.629 Creating interface m_IDirectDrawX::m_IDirectDrawX (00EA9740) converting interface from v7 to v9
13276 00:28:01.629 Redirecting 'Direct3DCreate9' ...
13276 00:28:01.629 Creating interface m_IDirect3D9Ex::m_IDirect3D9Ex (00EBCCC0) IID_IDirect3D9
13276 00:28:01.629 Creating interface m_IDirect3DX::m_IDirect3DX (00EC1FB8) converting interface from v7 to v9
13276 00:28:01.629 m_IDirect3DX::~m_IDirect3DX (00EC1FB8) deleting interface!
13276 00:28:01.629 m_IDirectDrawX::~m_IDirectDrawX (00EA9740) deleting interface!
13276 00:28:01.629 m_IDirect3D9Ex::~m_IDirect3D9Ex (00EBCCC0) deleting interface!
13276 00:28:01.629 m_IDirectDrawSurfaceX::CleanupSharedEmulatedMemory Deleting 0 emulated surfaces!
13276 00:28:01.629 m_IDirect3D9Ex::~m_IDirect3D9Ex (00EBCB60) deleting interface!
13276 00:28:01.768 Direct3D9SetSwapEffectUpgradeShim Calling 'Direct3D9SetSwapEffectUpgradeShim' ... 0
13276 00:28:01.768 Redirecting 'DirectDrawCreate' IID_IDirectDraw7 to --> 'Direct3DCreate9'
13276 00:28:01.768 Creating interface m_IDirectDrawX::m_IDirectDrawX (00EA90B0) converting interface from v7 to v9
13276 00:28:01.772 WndProc::AddWndProc Creating WndProc instance! WND(01490CE4,FalconDisplay,{0,0,1024,768})
13276 00:28:01.772 m_IDirectDrawX::CreateD3D9Device Direct3D9 device! 1024x768 refresh: 0 format: D3DFMT_UNKNOWN wnd: WND(01490CE4,FalconDisplay,{0,0,1024,768}) params: {1024,768,D3DFMT_UNKNOWN,1,0,0,1,WND(01490CE4,FalconDisplay,{0,0,1024,768}),1,0,D3DFMT_UNKNOWN,0x0,0,0x80000000} flags: 0x46
13276 00:28:04.606 Creating interface m_IDirect3DDevice9Ex::m_IDirect3DDevice9Ex (00ED93B8) IID_IDirect3DDevice9
13276 00:28:04.609 m_IDirectDrawX::CreateSurface2 Primary surface 0x0 dwFlags: 0x21 ddsCaps: 0x2238, 0x0, 513
13276 00:28:04.609 Creating interface m_IDirectDrawSurfaceX::m_IDirectDrawSurfaceX (1225F130) converting interface from v7 to v9
13276 00:28:04.609 Creating interface m_IDirectDrawSurfaceX::m_IDirectDrawSurfaceX (1225F3B8) converting interface from v7 to v9
13276 00:28:04.609 Creating interface m_IDirect3DX::m_IDirect3DX (00EE9EB0) converting interface from v7 to v9
13276 00:28:04.609 m_IDirectDrawSurfaceX::GetAttachedSurface2 Error: failed to find attached surface that matches the capabilities requested: {{ DDSCAPS_ZBUFFER },0x0,0x0,0x0} Attached number of surfaces: 1 MaxMipMapLevel: 0 Caps: {{ DDSCAPS_3DDEVICE  DDSCAPS_BACKBUFFER  DDSCAPS_COMPLEX  DDSCAPS_FLIP  DDSCAPS_LOCALVIDMEM  DDSCAPS_VIDEOMEMORY },0x0,0x0,0x0}
13276 00:28:04.609 m_IDirectDrawX::CreateSurface2 Found Stencil surface: D3DFMT_D16_LOCKABLE
13276 00:28:04.609 Creating interface m_IDirectDrawSurfaceX::m_IDirectDrawSurfaceX (1225F8A8) converting interface from v7 to v9
13276 00:28:04.609 Creating interface m_IDirect3DDeviceX::m_IDirect3DDeviceX (1225FB30) converting interface from v7 to v9
13276 00:28:04.609 Creating interface m_IDirect3DSurface9::m_IDirect3DSurface9 (00EBAC58)
13276 00:28:04.609 Creating interface m_IDirect3DSurface9::m_IDirect3DSurface9 (00EBA730)
13276 00:28:04.610 Creating interface m_IDirect3DSurface9::m_IDirect3DSurface9 (00EBA940)
13276 00:28:04.628 DdrawWrapper::ProxyQueryInterface Query Not Implemented for IID_IMediaStream from IID_IDirectDraw7
13276 00:28:04.628 DdrawWrapper::ProxyQueryInterface Query Not Implemented for IID_IAMMediaStream from IID_IDirectDraw7
13276 00:28:04.684 m_IDirectDrawSurfaceX::CopySurface Error: Invalid rect: {0,0,720,576} -> {1408,716,2432,1484}
13276 00:28:04.688 m_IDirectDrawX::CreateD3D9Device Direct3D9 device! 1024x768 refresh: 0 format: D3DFMT_UNKNOWN wnd: WND(01490CE4,FalconDisplay,{1396,664,2444,1496}) params: {1024,768,D3DFMT_UNKNOWN,1,0,0,1,WND(01490CE4,FalconDisplay,{1396,664,2444,1496}),1,0,D3DFMT_UNKNOWN,0x0,0,0x80000000} flags: 0x44
13276 00:28:04.688 m_IDirectDrawX::CreateD3D9Device Recreate device! Last create: WND(01490CE4,FalconDisplay,{1396,664,2444,1496})->WND(01490CE4,FalconDisplay,{1396,664,2444,1496})  Windowed: 1->1 0x46->0x44
13276 00:28:04.689 m_IDirect3DDevice9Ex::~m_IDirect3DDevice9Ex (00ED93B8) deleting interface!
13276 00:28:04.689 m_IDirect3DSurface9::~m_IDirect3DSurface9 (00EBA838) deleting interface!
13276 00:28:04.689 m_IDirect3DSurface9::~m_IDirect3DSurface9 (00EBAC58) deleting interface!
13276 00:28:04.689 m_IDirect3DSurface9::~m_IDirect3DSurface9 (00EBA8E8) deleting interface!
13276 00:28:06.585 Creating interface m_IDirect3DDevice9Ex::m_IDirect3DDevice9Ex (00EFB568) IID_IDirect3DDevice9
13276 00:28:06.585 m_IDirect3DDeviceX::~m_IDirect3DDeviceX (1225FB30) deleting interface!
13276 00:28:06.585 m_IDirect3DX::~m_IDirect3DX (00EE9EB0) deleting interface!
13276 00:28:06.585 m_IDirectDrawX::~m_IDirectDrawX (00EA90B0) deleting interface!
13276 00:28:06.585 m_IDirect3DDevice9Ex::~m_IDirect3DDevice9Ex (00EFB568) deleting interface!
13276 00:28:06.585 m_IDirectDrawSurfaceX::CleanupSharedEmulatedMemory Deleting 0 emulated surfaces!
13276 00:28:06.585 m_IDirectDrawSurfaceX::~m_IDirectDrawSurfaceX (1225F130) deleting interface!
13276 00:28:06.585 m_IDirectDrawSurfaceX::~m_IDirectDrawSurfaceX (1225F3B8) deleting interface!
13276 00:28:06.585 m_IDirectDrawSurfaceX::~m_IDirectDrawSurfaceX (00EFBDE0) deleting interface!
13276 00:28:07.752 Direct3D9SetSwapEffectUpgradeShim Calling 'Direct3D9SetSwapEffectUpgradeShim' ... 0
13276 00:28:07.765 m_IDirectDrawX::CreateD3D9Device Direct3D9 device! 3840x2160 refresh: 0 format: D3DFMT_UNKNOWN wnd: WND(01490CE4,FalconDisplay,{0,0,1024,768}) params: {3840,2160,D3DFMT_UNKNOWN,1,0,0,1,WND(01490CE4,FalconDisplay,{0,0,1024,768}),1,0,D3DFMT_UNKNOWN,0x0,0,0x80000000} flags: 0x46
13276 00:28:09.376 Creating interface m_IDirect3DDevice9Ex::m_IDirect3DDevice9Ex (00EFB8D8) IID_IDirect3DDevice9
13276 00:28:09.415 m_IDirectDrawX::CreateD3D9Device Direct3D9 device! 1024x768 refresh: 0 format: D3DFMT_UNKNOWN wnd: WND(01490CE4,FalconDisplay,{0,0,1024,768}) params: {1024,768,D3DFMT_UNKNOWN,1,0,0,1,WND(01490CE4,FalconDisplay,{0,0,1024,768}),1,0,D3DFMT_UNKNOWN,0x0,0,0x80000000} flags: 0x46
13276 00:28:09.443 m_IDirectDrawX::CreateSurface2 Primary surface 0x0 dwFlags: 0x21 ddsCaps: 0x2238, 0x0, 513
13276 00:28:09.443 m_IDirectDrawSurfaceX::GetAttachedSurface2 Error: failed to find attached surface that matches the capabilities requested: {{ DDSCAPS_ZBUFFER },0x0,0x0,0x0} Attached number of surfaces: 1 MaxMipMapLevel: 0 Caps: {{ DDSCAPS_3DDEVICE  DDSCAPS_BACKBUFFER  DDSCAPS_COMPLEX  DDSCAPS_FLIP  DDSCAPS_LOCALVIDMEM  DDSCAPS_VIDEOMEMORY },0x0,0x0,0x0}
13276 00:28:09.444 m_IDirectDrawX::CreateSurface2 Found Stencil surface: D3DFMT_D16_LOCKABLE
13276 00:28:09.444 Creating interface m_IDirect3DDeviceX::m_IDirect3DDeviceX (1228C398) converting interface from v7 to v9
13276 00:28:10.236 Creating interface m_IDirectDrawPalette::m_IDirectDrawPalette (1577A6E0)
13276 00:28:10.239 Creating interface m_IDirectDrawPalette::m_IDirectDrawPalette (1577F108)
13276 00:28:10.239 Creating interface m_IDirectDrawPalette::m_IDirectDrawPalette (1577F938)
13276 00:28:10.240 Creating interface m_IDirect3DTexture9::m_IDirect3DTexture9 (00ED2528)
13276 00:28:10.240 Creating interface m_IDirect3DTexture9::m_IDirect3DTexture9 (00ED2628)
13276 00:28:10.241 Creating interface m_IDirect3DTexture9::m_IDirect3DTexture9 (00ED22A8)
13276 00:28:25.245 m_IDirectDrawPalette::~m_IDirectDrawPalette (15780168) deleting interface!
13276 00:28:25.245 m_IDirectDrawPalette::~m_IDirectDrawPalette (157835C0) deleting interface!
13276 00:28:25.245 m_IDirectDrawPalette::~m_IDirectDrawPalette (16180088) deleting interface!
13276 00:28:25.251 m_IDirectDrawX::CreateD3D9Device Direct3D9 device! 1024x768 refresh: 0 format: D3DFMT_UNKNOWN wnd: WND(01490CE4,FalconDisplay,{1396,664,2444,1496}) params: {1024,768,D3DFMT_UNKNOWN,1,0,0,1,WND(01490CE4,FalconDisplay,{1396,664,2444,1496}),1,0,D3DFMT_UNKNOWN,0x0,0,0x80000000} flags: 0x44
13276 00:28:25.251 m_IDirectDrawX::CreateD3D9Device Recreate device! Last create: WND(01490CE4,FalconDisplay,{1396,664,2444,1496})->WND(01490CE4,FalconDisplay,{1396,664,2444,1496})  Windowed: 1->1 0x46->0x44
13276 00:28:25.254 m_IDirect3DDevice9Ex::~m_IDirect3DDevice9Ex (00EFB8D8) deleting interface!
13276 00:28:25.254 m_IDirect3DTexture9::~m_IDirect3DTexture9 (12315758) deleting interface!
13276 00:28:25.254 m_IDirect3DTexture9::~m_IDirect3DTexture9 (00E60950) deleting interface!
13276 00:28:25.254 m_IDirect3DTexture9::~m_IDirect3DTexture9 (00ED22A8) deleting interface!
13276 00:28:25.901 m_IDirectDrawX::CreateD3D9Device Error: failed to create Direct3D9 device! D3DERR_NOTAVAILABLE 1024x768 refresh: 0 format: D3DFMT_UNKNOWN wnd: WND(01490CE4,FalconDisplay,{1396,664,2444,1496}) params: {1024,768,D3DFMT_UNKNOWN,1,0,0,1,WND(01490CE4,FalconDisplay,{1396,664,2444,1496}),1,0,D3DFMT_UNKNOWN,0x0,0,0x80000000} flags: 0x44
13276 00:28:25.901 m_IDirectDrawX::CreateD3D9Device Direct3D9 device! 1024x768 refresh: 0 format: D3DFMT_UNKNOWN wnd: WND(01490CE4,FalconDisplay,{1396,664,2444,1496}) params: {1024,768,D3DFMT_UNKNOWN,1,0,0,1,WND(01490CE4,FalconDisplay,{1396,664,2444,1496}),1,0,D3DFMT_UNKNOWN,0x0,0,0x80000000} flags: 0x44

With RTX injected:

This is the RTX Remix log file - might give some additional hints.
FalconAF_d3d9.log

Game does not support frame generation - when disabled RTX loads.


feat(exec/builder): add GetDashes method to ExecutableStep interface

What does this change
Adds a GetDashes() method to the ExecutableStep interface such that implementations can modify the dashes appended to flags.
As proposed in https://github.com/deislabs/porter/pull/681#issuecomment-539102454
What issue does it fix
N/A, but used by https://github.com/deislabs/porter-terraform/pull/25
Notes for the reviewer
Is there a way to have this new method be "optional"? Or will we need to add implementations of the method in the other mixins that implement ExecutableStep?
Checklist

[x] Unit Tests
[ ] Documentation

[ ] Documentation Not Impacted

Is there a way to have this new method be "optional"? Or will we need to add implementations of the method in the other mixins that implement ExecutableStep?

So what I was suggesting was that instead of adding it to the existing interface was to make a new interface. And only Steps that need to override the default -- + - implement that interface. Then ExecuteStep can check if step implements that optional interface, if not it can supply the default Dash struct instance to ToSlice().
It's very close to what you have now.

@carolynvs ah I see.  Thanks so much for working with me on this.  I think I have it now... PTAL when convenient.

💃 🕺


display bug when inserting an H5P.ImageHotspotQuestion inside an H5P Interactive Book

display bug when inserting an H5P.ImageHotspotQuestion inside an H5P Interactive Book
see attached screenshot
wrong display of this css rule here:
.h5p-image-hotspot-question::before {
content: '\f059';
}

This is not an issue with the H5P CLI tool. At least not directly.
When you view content with the H5P CLI tool, it will always load all the dependency libraries regardless of whether they are actually used in the respective content or not. (side note to @devland: Don't know if you'd want to change that. I've never felt a performance issue locally by that behavior.)
In your case, H5P.ImageHotspots is loaded and comes with https://github.com/h5p/h5p-image-hotspots/blob/master/styles/image-hotspots.css#L91-L93 which unfortunately collides with the CSS class name h5p-image-hotspot-question that H5P.ImageHotspotQuestion is using. You can verify this easily by inspecting the before pseudo-element that you see in your screenshot. It will be filled by the stylesheet of H5P.ImageHotspots. You can reveal that bug on any H5P integration if you have a content type that loads both H5P.ImageHotspotQuestion and H5P.ImageHotspots - just put both in a Column ...

Fixed in https://github.com/h5p/h5p-image-hotspots/pull/115

Closing this since it is not an h5p-cli issue.


Betroll as gamble option

[x] Create command group for gamble commands
[x] Create command
[x] Randomize dice and generate embed
[x] Edit value in database

Preview of embed

Preview of the feature:


Add SyncStatusHelper and SyncStatusView

Adds SyncStatusHelper and SyncStatusView classes
Closes #3
SyncStatusHelper can be used like this:
final helper = SyncStatusHelper(
  ditto: ditto,
  subscriptions: [
    subscription1,
    subscription2,
  ],
  // optional, defaults to 5 seconds
  idleTimeoutInterval: Duration(seconds: 1),
);

print(helper.status);                        // either idle or syncing
print(helper.statusFor(subscription1));      // either idle or syncing
print(helper.lastUpdatedAt(subscription1));  // `DateTime` (or null if it has never updated)

Also adds a Widget: SyncStatusView, which displays the info in a list

This looks great! How hard would it be to break this out and merge it to main without waiting on the other branch?


fix(chat): add error messages for failed publish requests (Issue #1481)

Description:
Add receiving error messages through Next proxy api and displaying them in failed publish requests: approve, create and rulesList
Issues:

Issue #1481

UI changes

Checklist:

[x] the pull request name complies with Conventional Commits
[x] the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
[x] the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
[x] I confirm that do not share any confidential information like API keys or any other secrets and private URLs

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review

/deploy-review


HBASE-26943 HMaster page style display confusion

https://issues.apache.org/jira/browse/HBASE-26943

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m  6s
master passed

+1 :green_heart:
compile
2m 31s
master passed

+1 :green_heart:
checkstyle
0m 41s
master passed

+1 :green_heart:
spotbugs
1m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 10s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m  9s
the patch passed

+1 :green_heart:
compile
2m 26s
the patch passed

+1 :green_heart:
javac
2m 26s
the patch passed

+1 :green_heart:
checkstyle
0m 41s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 54s
Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.

+1 :green_heart:
spotbugs
1m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

33m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4369/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4369

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux dac2526d6de2 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / af13c6d4c6

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
64 (vs. ulimit of 30000)

modules
C: hbase-http hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4369/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 47s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 42s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
shadedjars
4m 11s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 41s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
4m  5s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 39s
hbase-http in the patch passed.

+1 :green_heart:
unit
177m  5s
hbase-server in the patch passed.

197m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4369/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4369

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 6b6e31ecaceb 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / af13c6d4c6

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4369/1/testReport/

Max. process+thread count
2922 (vs. ulimit of 30000)

modules
C: hbase-http hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4369/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
2m 21s
master passed

+1 :green_heart:
compile
0m 53s
master passed

+1 :green_heart:
shadedjars
3m 40s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 12s
the patch passed

+1 :green_heart:
compile
0m 53s
the patch passed

+1 :green_heart:
javac
0m 53s
the patch passed

+1 :green_heart:
shadedjars
3m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 37s
hbase-http in the patch passed.

+1 :green_heart:
unit
188m 56s
hbase-server in the patch passed.

207m 42s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4369/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/4369

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 0cfeec8345b9 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / af13c6d4c6

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4369/1/testReport/

Max. process+thread count
2952 (vs. ulimit of 30000)

modules
C: hbase-http hbase-server U: .

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4369/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Thanks for the review @ndimiduk , will merge the commits soon.

Commits merged, closing the PR.


Search Coordinates do not work

If you make any edition in RapID you can not select search coordinates to transfer to a even near location using Lat/Long data.
ID allow that without problems

The issue somehow was solved in Version 1.0.7


[RFE] Consider different base image

As title, this issue is tracking work looking into a different base image.
Currently BRO uses registry.suse.com/bci/bci-micro:latest as a base image for the final result. We could reduce the footprint by going down to the busybox BCI, and/or by using scratch. In either case having a reduced footprint will improve security concerns related to this image.
Here are the options, we have:
Option 1: Switch to Busybox base
This reduces the file size quite a bit - 5MB compressed, ~20MB on disk.
Option 2: Switch to scratch base
This reduces the file size quite a bit - 10MB compressed, ~40MB on disk.
This is most optimal from a security POV as the only thing in the container is our binary.
However, because the only thing in the image is our binary you cannot exec into the container.
Instead one would have to sidecar the pod with a shell specific image.
Option 3: Switch to scratch and busybox base
This is the "why not both" option. We pick one as the default and one as an opt-in.
Ultimately this could be the ideal solution as it gives us benefits of both options.
I would be in favor of picking scratch as default and suffixing the busybox version as different.
This way we know all our users are working with the minimal version by default, rather than opting in.
However, the idea can work just the same in the other direction with scratch based images being opt-in.

@alexandreLamarre - I wonder if option 3 is the way to go here, but with a delay in picking how we publish variants? Specifically meaning, if we switch to busybox base right now we can reduce the footprint now without much concern of issue. Then down the road we can evaluate which base image should be default and which one opt-in?

Pushing this out to backlog since current images state makes this less concerning. (Maybe aim for 2.10)


Add moony's merge tooling to the repo

About the PR

thanks to @moonheart08 for the tool.
should hopefully make upstream merges a bit less painful.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

no cl no fun

moony's just gonna upstream it, apparently


Installation Guide Needed

Hi mate!
You can add a installation guide, where to put or how to put the database credentials to running the migrations or how to put the Access Key?

Hello @padagoal ,

How to run migration?
The app will run database migration scripts when start.
https://github.com/kelp404/electron-s3-file-manager/blob/v0.1.1/src/main-process/index.js#L88

How to set access key?
Go to settings tab.