Tracking paths to error locations

My directory structure is as follows:
jbuild
jbuild-workspace
src/
  jbuild
  ...
examples/
  foo.ml
  jbuild
  ...

src contains a library and examples example applications.  If I go to the examples directory and issue a build command from there (e.g. from an editor), an error in example foo.ml would be reported using location examples/foo.ml.  This is a problem for inferring correct error locations.  The editor does not know where the root of this path is, because we are in a (potentially even deeper) subdirectory.
Could you please print the absolute path of the root for error messages for a particular build when jbuilder is invoked so editors can infer the correct path?  E.g. Vim allows you to pattern match on the build output to keep track of directory stacks for correct errors locations.  A somewhat unique string should be used to correctly identify this location message, preferably an existing make-like Entering directory message that Vim or Emacs already understand.

I admit I'm a bit fuzzy on what is recommended way of invoking the build system from the editor. Myself I use some emacs lisp code that guesses the project root by looking for a few key files (Makefile, _oasis, jbuild-workspace...) and then set the build command to something like cd ... && make.
So the idea would be to have an option --make-style-errors and/or possibly an environment variable to make jbuilder print:
Entering "<absolute path>"

before reporting an error?

Yes, something like that would work.  I don't think it would be a good idea to have everybody write their own editor scripts for how jbuilder determines build roots or maybe even changes directories during build operations.

Entering ... doesn't make much sense, jbuilder builds everything at once. I'm ok adding a compatibility option for editors but making it the default will make things confusing

It's not a big deal.  Various messages can coexist.  You can choose your own, maybe something like jbuilder root is ....
I'm not sure how jbuilder works, but it would certainly be necessary to never change directories if different directories are built in parallel.  All paths would have to start at the root to avoid confusing editors.

Btw., if anybody needs a quickfix for now when building from within a subdirectory of the root, just create a Makefile containing e.g.:
.PHONY: all
all:
        @echo jbuilder: Entering directory \`$(abspath $(dir $(lastword $(PWD))))\'
        @jbuilder build --dev @all

Then a simple call to make should do what you want.

The handling of C-files makes things more complicated then.  Since you presumably build them in parallel, I guess the best way would be to only print the directory change right before emitting an error message, making sure that there is no race condition that could insert another message between the directory change message and the error message.
I'm not sure (cd <dir> && ...) is unique enough.  There may also be a chance that the S-expression pretty printer, if it's being used here, will break lines, which makes pattern matching in editors more difficult.

The standard way of launching a build system in Emacs is M-x compile, usually bound to C-c C-c.
Unless there is a strong motivation, it would be better to keep the sentence Entering directory '<dir>' — you can put anything you want before it but it must end the line —, otherwise editors will need to be told about it.
Another possibility (which I'm not particularly fond of) is to invoke OCaml compilers with absolute file names, the errors will then contain the full path and links to errors will work.

I implemented @bobot's suggestion. Initially I was thinking about printing Entering directory ... before every command that output something given that commands are not all run from the same directory. However this clutters the output and given that all ocamlXXX commands are run from the root, printing it only once at the beginning is enough for most cases.
Unfortunately, it still doesn't help for C stubs. The problem with C stubs is that when you call ocamlc -c src/file.c, you get file.o rather than src/file.o. As a result the command has to be executed in src. Maybe we could workaround this problem by doing a rename just after the ocamlc -c ... and sandbox the action to avoid race conditions.

jbuilder now prints directory changes, but the format does not match the patterns typically defined in Vim configurations for make.  E.g. it prints:
Entering directory '...'

But most Vim errorformat configurations would expect something like the following:
jbuilder: Entering directory `...'

This would require the following changes:

Print jbuilder:  before Entering directory to indicate the build tool.
Use a backtick to open the quoted directory (keep the regular tick at the end).

I have updated my personal (public) OCaml Vim configuration to support both kinds of ticks, which is what other configurations do now, too.  GNU make is apparently switching to saner quoting.  But it would help if jbuilder stayed compatible with legacy make error formats.

I agree about not supporting deprecated formats but @mmottl has a point when he says that the line is still prefixed by make: (hence, here, jbuilder:).  Emacs is not sensitive to that but Vim may be.

Some platforms (e.g. Mac OS X) still ship with old make programs by default.  I agree that in case of the backtick it's probably better to push editor maintainers to update accordingly.  I still think the prefix should be there, not just for make, but because it also helps determine what program produced a log message.  This may be helpful for projects with mixed build tools.

Any change that the corresponding "Leaving directory …" messages could be added? Otherwise, when dune is run in a sequence of other programs, the messages output y those programs are misinterpreted by editors.
For example, the following case is broken: project root is in /project/, and I have the following makefile in /project/codegen/:
../build/codegen/cppgen.exe:
	dune build cppgen.exe

example.cpp: build example.in
	../build/codegen/cppgen.exe example.in

a.out: example.cpp
	g++ example.cpp

run: a.out
	./a.out

When I execute make run, dune says that it's entering /project/, and then when g++ runs and prints errors or warnings Emacs is confused and understands these relative to /project/.  This wouldn't happen if dune printed Leaving directory `/project' after completing the build.

It just feels a tad heavy :/ In your particular case, why not put the rules in the dune file directly? Then you just need one single call to dune.

It just feels a tad heavy :/

That's a fair point.  Maybe under a flag?

In your particular case, why not put the rules in the dune file directly? Then you just need one single call to dune.

I didn't realize this was possible.   In practice, the rules tend to be more complicated.  Can I do things like enumerating all files with a certain extension and run a command on each in dune? (Also,  I (and to a larger extent people that I work with) have more experience with make, so I'm wary of using dune for more than the OCaml and Coq parts of my projects — but I'm open to being convinced ^^).

Well, I won't try to convince you as the truth is, as soon as you go off the beaten track it's indeed pretty verbose compared to make. That said, if you do write the custom dune rules, then you get all the benefits that come with dune: polling mode, soon the shared cache, etc...
Adding a flag would be an option yeah. On the other hand having too many specific options tends to clutter the documentation. We generally try to just do the right thing without offering configuration unless it's really needed.
Thinking about this again, it's only one line at the end of the build and the Entering ... line was added precisely for Emacs. So if adding the Leaving ... line helps integration in Emacs, let's just do it.
Do you want to write the patch? The Entering ... line is printed in the prepare function in src/dune/scheduler.ml. You can just setup a at_exit hook at the same time as printing this line.

Neat.  Yes, I can (try to) prepare a patch.
One more question, though, to make sure that I have this right. Why was the fix for the original issue to print the directory when compilation starts, rather than printing error messages relative to the current directory? Is it because the messages are printed by OCaml itself (and hence can't be adjusted to be relative to the directory in which dune was invoked? (I imagine that even if OCaml could be adjusted, any other binary would need the same treatment, which is unmanageable)

That's exactly the idea. We would need to parse the output of commands and rewrite filenames.

Done (roughly 4 months later :tada:) in #3072


Simplified nix flake for build, dev shell, and cached build

I see #60. Honestly not sure which method is better at the moment. This PR allows local building with nix build and a development shell with nix develop. Ideally adding an entry to nixpkgs might solve #60 and #32 since it will be built into the eco-system. Open to discussion. Still learning nix myself.

This is a really awesome pr! I've used nix a little bit but not enough to know the proper ways to do things. Ss there some kind of way to make sure this builds correctly in our CI?

I am not sure I understand: Is there a desire to use nix instead for CI? As these changes aren't necessary or intended to replace a working CI, unless it's needed.

Hey! Love to see work on packaging lsp-ai for nixpkgs! I currently am using my own local package (https://github.com/mergemoveagree/nixos-configuration/tree/d9baa33e94b2680957defcc776704e4443266417/pkgs/lsp-ai) that was initialized with nix-init. While I am also relatively new to nix, I've combed through a mountain of different package flakes to try and find idiomatic styling.
Here are some differences between our flakes that I think would be beneficial to add:

use outputHashes rather than allowBuiltinFetchGit -- the hashes are in my "callBuilder.nix" file so you could just copy them from there
include a "default.nix" generated by flake-compat for the folks who don't want to switch to nixos-unstable just yet
Consider moving the package into an overlay -- I see this in a lot of other flakes for big projects

I'm not the most knowledgeable, but I'm happy to try and answer any questions or help research things we both know!

This is a really awesome pr! I've used nix a little bit but not enough to know the proper ways to do things. Ss there some kind of way to make sure this builds correctly in our CI?

I am not sure I understand: Is there a desire to use nix instead for CI? As these changes aren't necessary or intended to replace a working CI, unless it's needed.

I think he's referring to ensuring that the nix package builds (which theoretically could fail even if the rust package can compile via the normal imperative commands). There seems to be some documentation already over using nix in CI, and if there are no immediate plans to merge into the nixpkgs repo, there's an official tutorial on using GitHub Actions to automatically push binaries to a Cachix binary cache (to prevent everyone building the same derivation on their own systems) if this project were to adopt one.

This is a really awesome pr! I've used nix a little bit but not enough to know the proper ways to do things. Ss there some kind of way to make sure this builds correctly in our CI?

I am not sure I understand: Is there a desire to use nix instead for CI? As these changes aren't necessary or intended to replace a working CI, unless it's needed.

I think he's referring to ensuring that the nix package builds (which theoretically could fail even if the rust package can compile via the normal imperative commands). There seems to be some documentation already over using nix in CI, ~and if there are no immediate plans to merge into the nixpkgs repo~ (updated based on latest comment), there's an official tutorial on using GitHub Actions to automatically push binaries to a Cachix binary cache (to prevent everyone building the same derivation on their own systems) if this project were to adopt one.

That is exactly what I am referring to. I'm a bit worried to merge this in without actually using nix myself and having no way to verify that it is consistently working. I know a lot of people do use it and I would love to have a flake, but I want to make sure it is sustainable.

That is exactly what I am referring to. I'm a bit worried to merge this in without actually using nix myself and having no way to verify that it is consistently working. I know a lot of people do use it and I would love to have a flake, but I want to make sure it is sustainable.

Since I've set up my flake to be mainly for package distribution and this PR set this up to be for the devShell, I could make make a PR to this PR (or directly contribute, whatever is preferred) with parts of my lsp-ai flake and also a GitHub Actions CI for building the nix package if @ProjectInitiative is open to working together!

Chiming here to show interest.
Any updates on this? @ProjectInitiative @mergemoveagree

If we get something tested and working for a few people I'm happy to merge it in! I'm not very experienced with writing my own flakes though so heavily relying on everyones thoughts here.

Update on my side - my bad, actually - that lsp-ai has been merged into nixpkgs so I guess this PR is obsolete.

It isn't obsolete necessary, there might be a desire from a dev perspective to have a nix-ified dev shell. From a consumer environment, yes, the nixpkg version (slightly different to conform to nixpkg standards) is gtg for consumers of the package. I haven't had a ton of time to test this specifically since I haven't needed to contribute to the project codebase directly.


[TF-TRT] Provide a way to use different Grappler optimizers for the function library than the main graph

This is a POC that probably needs some refining. During TF-TRT conversion, we need to turn on different optimizers during optimization of the main graph and TRTEngine functions. Since other functions are inlined, it is effectively equivalent to using different optimizers for the function library.
How it works

Add fields to RewriterConfig to specify an alternate list of optimizers and custom optimizers, along with a boolean to toggle the use of these alternate lists. The default behavior doesn't change (i.e same optimizers for the main graph and function library)
Add an optional parameter to MetaOptimizer::OptimizeGraph() and helper functions to know whether the main graph or function library is being optimized, and set this parameter when optimizing the function library in MetaOptimizer::OptimizeConsumeItem().
When optimizing the function library, get the optimizer list from these new fields if the boolean is true.

Example of TRT conversion logs (BERT Base)
Optimization results for grappler item: tf_graph
  constant_folding: Graph size after: 2884 nodes (-409), 3897 edges (-410), time = 2186.9751ms.
  layout: Graph size after: 2884 nodes (0), 3897 edges (0), time = 1524.755ms.
  constant_folding: Graph size after: 2884 nodes (0), 3897 edges (0), time = 447.266ms.
  TensorRTOptimizer: Graph size after: 521 nodes (-2363), 664 edges (-3233), time = 4766.79492ms.
  constant_folding: Graph size after: 229 nodes (-292), 445 edges (-219), time = 247.384ms.
Optimization results for grappler item: TRTEngineOp_0_2_native_segment
  constant_folding: Graph size after: 8 nodes (0), 7 edges (0), time = 1.111ms.
Optimization results for grappler item: TRTEngineOp_0_1_native_segment
  constant_folding: Graph size after: 36 nodes (0), 37 edges (0), time = 45.684ms.
Optimization results for grappler item: TRTEngineOp_0_0_native_segment
  constant_folding: Graph size after: 2689 nodes (0), 3132 edges (0), time = 455.876ms.

TODO

[ ] Gather feedback
[ ] Add tests
[ ] Change defaults in trt_convert.py

@Nyrio This PR is in draft, any update on this? Please. Thanks!

@gbaned This is on hold. I will close or open for review in the coming days.


[help needed]How to create account from operator with JAVA ?

Hi experts,
Is possible to create account by using java ? We would like to create a dedicate account and user, when a new tenant is getting on board .
We assume we need following steps:

  create a JWT of an acount

  call $SYS.REQ.ACCOUNT.<account-id>.CLAIMS.UPDATE with the created JWT

  create user's JWT

Is this solution correct ?
if yes I have futher questions:
We can create a nkey for account:
NKey accountNey = NKey.createAccount(new SecureRandom());
char[] publicKey = accountNey.getPublicKey() ;   //AD7UONU43U2BAYJJW6T37IOTPS5YGZZCWDFPRCSHA6IUXFLZHXVJKGGW
char[] privateKey = accountNey.getPrivateKey() ;  //PACHPUHPIXL5IU6GWO75XWWISATLHDWIQCJUPDXGAGEDDMKSC2GDD72HG2ON2NAQMEU3PJ57UHJXZO4DM4RLBSXYRJDQPEKLSV4T32UVELQQ
char[] seed = accountNey.getSeed() ;    //SAAAI56Q55C5PVCTY2Z37W62ZCICNM4OZCAJGR4O4YAYQMNRKILIYMOCZI

But we are confused when we construct the JWT for account.
the decoded JWT of account looks like this :
{
  "jti": "some caculted value",
  "iat":<PHONE_NUMBER>,
  "iss": "OXXXXXXXXXX",  // operator's signing key
  "name": "MY NAME",
  "sub": "AXXXXXXXXXX",   // I guess it is the value of accountNey.getPublicKey()
  "nats": {
    "limits": {
      "subs": -1,
      "data": -1,
      "payload": -1,
      "imports": -1,
      "exports": -1,
      "wildcards": true,
      "conn": -1,
      "leaf": -1,
      "mem_storage": -1,
      "disk_storage": -1,
      "streams": -1,
      "consumer": -1
    },
    "signing_keys": [
      "AXXXXXXXXXX".
    ],
    "default_permissions": {
      "pub": {},
      "sub": {}
    },
    "type": "account",
    "version": 2
  }
}

How to fill in the sub and signing_keys fields ?
Is there any example ?
Thank and best regards
Cheng

I'm not exactly sure, but for now, do the JwtUtils help? https://github.com/nats-io/nats.java/blob/main/src/main/java/io/nats/client/support/JwtUtils.java
I don't know if the unit test will give more information either, but here it is: https://github.com/nats-io/nats.java/blob/main/src/test/java/io/nats/client/support/JwtUtilsTests.java
Also I suppose you've already read this: https://docs.nats.io/running-a-nats-service/configuration/securing_nats/auth_intro/jwt

I'm not exactly sure, but for now, do the JwtUtils help? https://github.com/nats-io/nats.java/blob/main/src/main/java/io/nats/client/support/JwtUtils.java
I don't know if the unit test will give more information either, but here it is: https://github.com/nats-io/nats.java/blob/main/src/test/java/io/nats/client/support/JwtUtilsTests.java
Also I suppose you've already read this: https://docs.nats.io/running-a-nats-service/configuration/securing_nats/auth_intro/jwt

Hi, thanks so much for your reply. The unit test and JWTUtils are helpful for creating a user. We are struggling with how to create an acount.
The different between creating account and user is, account' JWT contains a signing_key.


(Darwin x64) VS Code webviews causing VS Code to freeze up

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.77.0
OS Version: Darwin x64 22.4.0

Steps to Reproduce:

Install the Git Graph extension in a freshly installed vscode.
Open a project with Git history.
Click the button Git Graph on the Status Bar to open the webview.
Scroll quickly.

Why send the extension problem to the vscode repository?

In an issue related to the extension, it was mentioned that this seems to be an upstream issue. https://github.com/gitkraken/vscode-gitlens/issues/2389#issuecomment-1353838776
It works well on VSCodium Version: 1.77.0 + OS: Darwin x64.
It works well on VS Code Version: 1.77.0 + OS: Windows.
It works well on VS Code Version: 1.70.2 + OS: Darwin x64 and most previous versions.
It started causing freeze up on VS Code Version > 1.70.2 + OS: Darwin x64.
It can be reproduced on VS Code Insiders Version: 1.78.0 + OS: Darwin x64.

Video display
As shown in the video, I lost control of the mouse and had to force quit the program. Unfortunately, no *.dmp files were generated.
https://user-images.githubusercontent.com/19925192/229354265-c885e42f-5f16-4ac3-9683-50f02192e01e.mp4

I can only provide a system-generated report, but I'm not sure if it will be helpful.
Problem Report for Code.zip

Duplicate of https://github.com/microsoft/vscode/issues/148226#issuecomment-1426458831


ngl-viewer reset widgets values when it shouldn't

Scenario such as enabling the hud should not reset all the scene parameters.

Probably fixed in 74a851cac931aaacb9d726ebf31c2da12c579fcf


⚠ Bofrost.de has degraded performance

In 843bd17, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1291 ms

Resolved: Bofrost.de performance has improved in b769fd9.


Update to the latest Pulumi NuGet

I'm going to use Random for some integration testing of the core Pulumi library itself, so I need the latest changes to do so. Are you okay to release a new version here @stack72 ?

@stack72 Ouch, it's not that easy, we also need the lates TF Gen... When is that one coming?


Causal loop diagrams with indeterminates

Implement a new theory whose models are causal loop diagrams with links of positive, negative, or unknown/indeterminate polarity.
The double theory is already implemented in the core as th_nullable_signed_category and in the Wasm bindings as ThNullableSignedCategory, so the work here is to add the theory to the frontend, perhaps with a new glyph for the indeterminate link, such as a question mark near the arrowhead.

The styling of links with unknown/indeterminate polarity seems to vary in the literature. Figure 7 in this paper is an example of decorating links with the symbols "+", "-", or "?".


Updated help for plugin registration task

@sagarhgaikwad This looks good. Just a few things.
How comes you have the solutionId with empty Guid in the sample json file?
Perhaps we need to change the Id of the schema file to the url of the schema file in GitHub? At the moment it is example.com

Excellent. This is great. Just remove your connection string from MoveSolutionComponents.ps1 before I can Merge :)


Images in the user guide are gone

I think it might be related to the website migration work we've been doing recently. Needs to be fixed. Thanks for reporting @jiang95-dev


Add alternative space options for Multitrace operators

Added options other than P1 for Helmholtz multitrace.
Added Laplace multitrace.

@tbetcke Do you think the space options I've offered here are sensible (and sensibly named)?


cask-repair curl fails for JDK 8 & 11

Due to Oracle updating their license agreement for downloading/using JDK, then issuing cask-repair which uses curl to download the package is failing with 404. However, visiting the Oracle page and accepting the license to download JDK 11 or 8, will transfer you to a sign-in page. Logging in with an Oracle account allowed me to download either JDK 11 or 8 without issues. I don't know if this should be something corrected by Oracle or if homebrew-cask will have to deprecate relinking to download either of those JDKs. JDK 12 did not require me to log in with an Oracle account for downloading. Also, cask-repair on oracle-jdk which is version 12 had no problems. Probably another transition by Oracle to only offer their commercial JDK for only subscribers and pushing all non-subscribers to OpenJDK. Maybe not; just a coincidence.

Just checked the cask info for java11 and for some reason it references OpenJDK but java8 references the Oracle distribution. Either way, the cask-repair java8 version still fails to download. I'll file an issue with homebrew-cask to either stay consistent with java* distributions or just switch them all to OpenJDK to avoid confusion.

I'll just close this issue and submit a new one to homebrew-cask. I don't believe this should be a cask-repair issue since it retrieves the file URL using what is stored by homebrew-cask. One of the parent directories of the URL for the file download has changed.


Fix samples/subsys/mgmt/mcumgr/smp_svr/sample.mcumgr.smp_svr.bt failing to compile

Fixing regression introduced by #63967.

Added second commit with fix for failing west build -p -b lpcxpresso55s69_cpu0 -T samples/net/wifi/sample.net.wifi.mikroe_wifi_bt_click with
In file included from /w/zephyr/zephyr/include/zephyr/sys/util_macro.h:34,
                 from /w/zephyr/zephyr/include/zephyr/irq_multilevel.h:15,
                 from /w/zephyr/zephyr/include/zephyr/devicetree.h:20,
                 from /w/zephyr/zephyr/include/zephyr/device.h:12,
                 from /w/zephyr/zephyr/drivers/serial/uart_mcux_flexcomm.c:14:
/w/zephyr/zephyr/include/zephyr/device.h:85:41: error: 'device_dts_ord_DT_N_S_soc_S_peripheral_50000000_S_flexcomm_88000_P_dmas_NAME_tx_PH_ORD' undeclared here (not in a function); did you mean 'DT_N_S_soc_S_peripheral_50000000_S_flexcomm_86000_P_dmas_NAME_tx_PH'?
   85 | #define DEVICE_NAME_GET(dev_id) _CONCAT(device_, dev_id)

The reason for failure was that I changed shell UART backend to use asynchronous UART API by default if supported (forcing enabling of this API). On some targets additional configuration is required (e.g. DMA) so compilation fails if that setup is missing. Reverted back to use interrupt driven as the default one (unless asynchronous API is already enabled).


Azure Function won't compile, run - resource locked / not found

Functions that were running on timers / queue triggers stopped compiling due to resource not being found:
2017-06-21T03:12:35.134 warning CS8021: No value for RuntimeMetadataVersion found. No assembly containing System.Object was found nor was a value for RuntimeMetadataVersion specified through options.
2017-06-21T03:12:35.134 error CS0009: Metadata file 'D:\Windows\Microsoft.NET\Framework\v4.0.30319\mscorlib.dll' could not be opened -- Access to the path is denied.

Repro steps

Run any function under specific function app (Can't publicly disclose)

Expected behavior
Function to compile and run
Actual behavior
Error upon execution of any of the functions within the parent function app:
2017-06-21T03:12:35.134 Function started (Id=d3c7e7e9-5b8f-4da8-a356-5184119f0eab)
2017-06-21T03:12:35.134 Function compilation error
2017-06-21T03:12:35.134 warning CS8021: No value for RuntimeMetadataVersion found. No assembly containing System.Object was found nor was a value for RuntimeMetadataVersion specified through options.
2017-06-21T03:12:35.134 error CS0009: Metadata file 'D:\Windows\Microsoft.NET\Framework\v4.0.30319\mscorlib.dll' could not be opened -- Access to the path is denied.
2017-06-21T03:12:35.134 (1,1): error CS0518: Predefined type 'System.Object' is not defined or imported
2017-06-21T03:12:35.134 error CS0518: Predefined type 'System.Object' is not defined or imported
2017-06-21T03:12:35.134 error CS0518: Predefined type 'System.Threading.Tasks.Task`1' is not defined or imported
2017-06-21T03:12:35.134 error CS0400: The type or namespace name 'System.Object, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089' could not be found in the global namespace (are you missing an assembly reference?)
2017-06-21T03:12:35.134 error CS0518: Predefined type 'System.Object' is not defined or imported
2017-06-21T03:12:35.134 (3,24): error CS0518: Predefined type 'System.String' is not defined or imported
2017-06-21T03:12:35.134 (3,15): error CS0518: Predefined type 'System.Void' is not defined or imported
2017-06-21T03:12:35.134 (5,9): error CS0012: The type 'Object' is defined in an assembly that is not referenced. You must add a reference to assembly 'mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089'.
2017-06-21T03:12:35.134 (5,9): error CS0518: Predefined type 'System.Object' is not defined or imported
2017-06-21T03:12:35.134 (5,14): error CS0518: Predefined type 'System.String' is not defined or imported
2017-06-21T03:12:35.134 (5,14): error CS0518: Predefined type 'System.Object' is not defined or imported
2017-06-21T03:12:35.134 (5,14): error CS0518: Predefined type 'System.Int32' is not defined or imported
2017-06-21T03:12:35.134 (5,5): error CS0518: Predefined type 'System.Void' is not defined or imported
2017-06-21T03:12:35.134 Function completed (Failure, Id=d3c7e7e9-5b8f-4da8-a356-5184119f0eab, Duration=0ms)

Known workarounds
Delete and remove function app (not ideal).
I tried to restart / stop the function app however the buttons are disabled.
Related information
These are C# functions that were functioning for weeks prior and working today then tonight when out when trying to create another generic function.

Restarted via azure cli and the issue is fixed.  Web app still have function start/ stop / restart disabled.


@sweir27 => [Artwork] Add other series by the artist to page

Last series related rail!

Looks like...all the other instances of this rail on pages 😝

Easy peasy!


Allow importing pointer-returning methods as throwing.

Leftover bits of SE-0055. Now that pointer nullability is reflected in the type system, we can properly import throwing methods with non-object pointer return types.
Note that Swift still won't let you declare them. That's coming next.

@swift-ci Please test

@swift-ci test

@jrose-apple This now passes in CI.


[System] - Toggle System Appearance not working

Extension
https://www.raycast.com/extensions/system
Description
Using the command Toggle System Appearance seems like it is not working. I checked the extensions tab and made sure the extension is activated. Using the system settings and changing the appearance manually is working. Other commands from the systems extension like eject all disks or lock screen etc. are working.
Steps To Reproduce
Using the command.
Current Behaviour
Nothing
Expected Behaviour
Switch from light to dark mode and vice versa.

I have the same issue when the 'Toggle System Appearance' command does not work, but other system commands work correctly.

Turning System Events on for the Raycast fixed this problem.
Privacy & Security -> Automation -> Raycast

Thanks @sergiivelykodnyi, this one helped me!


not syncing/refreshing

Yesterday I had feeds, today - Netnewswire thought it wasn't connected to the inter-webs (when all was fine). I exported my feeds -- have the OPML. I was on NNW 4, so I upgraded and trashed the old and launched the new - still no feeds filled. These are "on my mac" and the version is updated. It looks like it's updating (I see a short progress bar) but can't see anything - thoughts?

I assume you clicked the refresh button, and also tried quitting and restarting the app.
It really looks like it’s not connected to the internet. Could it be something like Little Snitch blocking connections?

yes tried all of those things. I'm connected - (sending to you for instance) - NNW just doesn't think so. I can see the refresh bar getting things on the refresh, but then they are not showing up on either the preview or read pane - so app knows it's connected. just not opening the feeds. And - it's not just my feeds - I tried adding and it won't add:

and when I did a refresh (took me a few times to get a snap) -- there were feeds coming in on this...but not showing up.

Thanks for the quick response - I love NNW - don't want to stop using it, but there is something strange going on. I'll trash and reinstall again though

It definitely looks like something is preventing NetNewsWire from connecting to the internet.
Are you running any antivirus or firewall software?  Is this a work computer where someone may have changed some firewall settings on it without you knowing?

took all of it offline to check and still no go

Ok - resolved with a full restart.

Whew! Thanks for letting us know.


Cannot turn off wordwrap

VSCode Version: Code 1.10.1 (653f8733dd5a5c43d66d7168b4701f94d72b62e5, 2017-03-02T00:33:15.706Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions: none

Despite careful perusal of the settings (including the "Toggle Words Wrap" menu option), lines continue to wrap on screen.  This issue seems oddly intermittent --, sometimes when I load up the editor, word wrap is OFF, but after switching tabs, it turns ON.
Specifically, this issue affects PHP files I am editing.  Other files don't seem to have this issue (JS,HTML, CSS...).
Steps to Reproduce:

modify settings to turn off word wrap
frustration

duplicated here: https://github.com/Microsoft/vscode/issues/21801
I have the same issue.

Let's track in #21801


SAM validation error - No real operator in CIGAR

I used ReadTools v.0.2.2.r_4831abfbac to add read groups to a BAM-file and got the following error message:
SAM validation error: ERROR: Read name E00300:175:H3LYTALXX:6:1103:27813:5546#ACAGTGAT, No real operator (M|I|D|N) in CIGAR

This is the respective read pair:
E00300:175:H3LYTALXX:6:1103:27813:5546#ACAGTGAT 99      2L      1       70      150S    =       1       129     TTTTTTCGGTTCTTGACTGGGGCGGAGCGTGAACGCTCAGCTCTGTTTTCTCGGGAAAAAATACAAGCGCGAACTCCGCGTCGTGTTAAAGACATATATATTTTTTTAATCTCATTGATCTTTTTTTGCTGTTCTTTGCTTGTGGTTCTT  AAFFFKKKKAKKKKKKFKKKKKKKKAKKKFKKKKKKAF7KKKKKFFKKKKFKKKKKKKFKKKKAKKKKKKK<AKKKKKFFKKKKKKKKAKKKKFAKKKKKKKKKKKKFAA<KK7FKKKKKKKKKAKKKKKKAFKKKKKKKFKKFF7<FKA  AM:i:8  AS:i:256        MD:Z:114        NM:i:0  PG:Z:novoalign.I        PQ:i:438        SM:i:8  UQ:i:256
E00300:175:H3LYTALXX:6:1103:27813:5546#ACAGTGAT 147     2L      1       70      21S129M =       1       -129    ACTGGGGCGGAGCGTGAACGCTCAGCTCTGTTTTCTCGGGAAAAAATACAAGCGCGAACTCCGCGTCGTGTTAAAGACATATATATTTTTTTAATCTCATTGATCTTTTTTTGCTGTTCTTTGCTTGTGGTTCTTTTAGGAATTAATTGG  <KFAKKKKKKKKKKKKKKKKKKKKKKKKKF<KKKKKKKKFKKKKKKKKKKKKKKKKFKKKKKKKKKKKKKKKKKKKKKFKFKKKKKKKKKKKKKFKKKKKKKKKKKKKKKKKKKFKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKFFFAA  MD:Z:129        PG:Z:novoalign.I        AM:i:8  NM:i:0  SM:i:70 PQ:i:438        UQ:i:166        AS:i:166

Thanks a lot for looking into this, Daniel.
Cheers,
Thomas

Thanks @ThomasTaus (I edited your comment for making it more readable). I think that this will be solved by providing an option for SAM validation¡, so I will have a look after refactoring (#32).

Hi @ThomasTaus, can you have a look if the last release solve this problem? Just run the same command line as you did before but including the option --VALIDATION_STRINGENCY SILENT to be sure.
If it is not solved, I think that this is an specific issue of the library to handle SAM/BAM files and I can't do much more. Actually I don't fully understand how a BAM file could contain a read completely soft-clipped (150S).
I close the issue because I tried to solve it as far as I could. Open a new issue if you find more bugs and thanks for reporting it.


Suggested feature to refuse additional cookies when connecting from EU

I added this line very quickly, after line 44 in the file scraper.py, contained in the "scraping" folder:
driver.execute_script("window.scrollTo(0, document.body.scrollHeight)")
driver.find_element(By.ID, "W0wltc").click()

it works as intended, as I needed it to click to not accept additional cookies when it opens the google images pages in incognito mode, and I suggest you to add it for those connecting from the EU, maybe with a check so that if it does not appear for users from other countries it does not give an error.
I cannot provide the edit myself as I don't have git here and I am not savy with contributions on github yet.
I hope this helps, as this tool helped me immensely.

Thank you for your important suggestion. However, I can't replicate the issue that you are describing by connecting to EU servers via VPN. So, can you provide any related screen shots if possible?

This is the popup that is superimposed on the google images website the first time you open the page (or when you do it in incognito mode)


Wrapped: Cast generic types to AnyObject explicitly

Trying to build SwiftGodot on Windows results in the following errors:
C:\Projects\SwiftGodot\Sources\SwiftGodot\Core\Wrapped.swift:197:46: error: argument type 'T.Type' expected to be an instance of a class or class-constrained type
    guard let superStr = getSuperType (type: type) else {
                                             ^
C:\Projects\SwiftGodot\Sources\SwiftGodot\Core\Wrapped.swift:170:54: error: argument type 'T.Type' expected to be an instance of a class or class-constrained type
    let retained = Unmanaged<AnyObject>.passRetained(type)
                                                     ^

Explicit cast to AnyObject seems to fix the issue.

Building on Ubuntu also has this issue. I'm using Swift 5.9 toolchain in both cases.

Thank you for your patch, and apologies for the delay, I missed it!


Cherry-pick #1632 into release-1.21

What this PR does / why we need it:
Cherry-pick #1632 into release-1.21 branch.
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:

Release note:

NONE

@jichenjc Could you take a look?
This attempts to fix issues in the release-1.21 branch, seen in open backport attempts #1784 and #1775.

/retest

@MPV Its not required or recommended to backport.
/hold

/close
Back port to previous branches not recommended, only bug fixes allowed

Ah, looks like skipping tests for backports instead was the resolution for those issues. Thanks for your time on this. 👍


deprecated?

Also the related Get-CsTeamsMobilityPolicy  is deprecated, so is this set one thesame? In which case a note should be added to the article like the Get one e.g.. NOTE: Please note that this cmdlet was deprecated and then removed from this PowerShell module. This reference will continue to be listed here for legacy purposes.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0dcf829-c8b6-7fc5-9f77-2b9c34584dda
Version Independent ID: a6cd191e-2926-8ba6-5503-fa99c5c21561
Content: Set-CsTeamsMobilityPolicy (skype)
Content Source: skype/skype-ps/skype/Set-CsTeamsMobilityPolicy.md
Service: skypeforbusiness-powershell
GitHub Login: @saragava
Microsoft Alias: saragava

@officedocsbot assign @yogkumgit

Thanks for noticing, adding the missing note thru a PR.

@get-itips  Thank you very much for the contribution and updating the documentation with PR. @obhayes Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


test-scaleway-ubuntu1604-x64-1 out of disk space

Test_openjdk11_j9_extended.system_x86-64_linux_xl:
https://ci.adoptopenjdk.net/job/Test_openjdk11_j9_extended.system_x86-64_linux_xl/260/console
01:40:25  ERROR: [ssh-agent] Could not register BouncyCastle on the remote agent.
01:40:25  java.nio.file.FileSystemException: /tmp/resource-1967337190559246248: No space left on device

Looks like leftover docker images

Have dont a it of a clearout but still lots of images left. @smlambert would you expect machines used for the external testing to leave lots of images around between runs and if so do you know the total requirements for the space in /var/lib/docker? We may have to remove the docker tag from this particular machine as it's a bit more space limited than the ones at some of our other providers :-)

We clean up the machine at the end of each test run, but if the run is aborted, we are unable to clean it up.    We plan to add a 'docker prune' step (https://github.com/AdoptOpenJDK/TKG/issues/45), but yes, if a machine is short on space, you may wish to remove the tag.

On the basis that we're no longer short on Linux/x64 machines to run tests on I'll do that for now and close this/ sw.tool.docker removed from test-scaleway-ubuntu1604-x64-1


Graceful shutdown

This PR introduces a new client method named shutdown, which allows the client to gracefully close the connection to the broker.
Implementation details:
The request_tx sends a Request::Disconnect. As a result, the handle_outgoing_disconnect method of the MqttState sets the MqttConnectionStatus to a new enum value named Disconnecting. To verfiy the client is currently disconnecting, MqttState now exposes a is_disconnecting method returning a bool.
This allows the mqtt event loop to verfiy, whether the NetworkError::NetworkStreamClosed error is actually expected to happen or not and jump out of the reconnect loop. For convenience, I pulled the should_reconnect_again function into the impl of the Connection, alleviating the necessity of passing in both, the reconnect opts and now also the is_diconnecting flag (as we don't want to be reconnected when we gracefully shutdown - even if our reconnect options state otherwise)

ping

I've left some comments

I can't see them 😢

Almost there. Few nits. We should be good to go after those changes :)

I'll merge this and fix those :). Thanks for you contribution

Sorry - had somewhat of a stressful week! But thanks for taking over though 👍
Should I open another issue w.r.t. to the pause / resume issue so that we can discuss todos there?

Sorry - had somewhat of a stressful week! But thanks for taking over though

Not a problem :)

Should I open another issue w.r.t. to the pause / resume issue so that we can discuss todos there?

Sure. That'll help


boot: zephyr: move to non-deprecated GPIO flags

GPIO_DIR_IN has been replaced by GPIO_INPUT, GPIO_PUD_PULL_UP by
GPIO_PULL_UP, and gpio_pin_read() by gpio_pin_get_raw().  Update the
code to use the preferred API if it available.  This avoids
deprecation warnings in the build.
Signed-off-by: Peter Bigot<EMAIL_ADDRESS>

This patch works against both master and topic-gpio in Zephyr.  @nvlsianpu

zephyr fork synchronized, please upgrade the reference in your convenience.

@pabigot ^^ https://github.com/zephyrproject-rtos/zephyr/pull/22369


Branch coverage in finally block unexpectedly affected by catch block

Describe the bug
If a block such as
try:
   # some code
finally:
  # some finally code

has 100% branch coverage, then adding an exception block can change things even when the exception isn't triggered:
try:
     # some code
except SomeException as e:  # pragma: no cover
    raise SomeOtherException() from e
finally:
    # some finally code

The finally code branch coverage goes down.
To Reproduce
How can we reproduce the problem?  Please be specific. Don't link to a failing CI job. Answer the questions below:

What version of Python are you using? See coverage debug sys output below.
What version of coverage.py shows the problem? The output of coverage debug sys is helpful. See coverage debug sys output below.
What versions of what packages do you have installed? The output of pip freeze is helpful. Nothing relevant, I run coverage from a venv and my code under test has no dependencies.
What code shows the problem?  Give us a specific commit of a specific repo that we can check out. If you've already worked around the problem, please provide a commit before that fix. https://github.com/vsajip/pagesign/blob/ac5c6c1096763b1f858efbdf7385564f394246b9/pagesign.py
What commands did you run? coverage run --branch test_pagesign.py

$ coverage debug sys
-- sys -------------------------------------------------------
               coverage_version: 6.4.4
                coverage_module: /home/vinay/.local/share/virtualenvs/coverage/lib/python3.7/site-packages/coverage/__init__.py
                         tracer: -none-
                        CTracer: available
           plugins.file_tracers: -none-
            plugins.configurers: -none-
      plugins.context_switchers: -none-
              configs_attempted: .coveragerc
                                 setup.cfg
                                 tox.ini
                                 pyproject.toml
                   configs_read: /home/vinay/projects/pagesign/setup.cfg
                    config_file: None
                config_contents: -none-
                      data_file: -none-
                         python: 3.7.3+ (heads/3.7:0ff08b061b, May 11 2019, 09:27:05) [GCC 7.4.0]
                       platform: Linux-4.15.0-193-generic-x86_64-with-debian-buster-sid
                 implementation: CPython
                     executable: /home/vinay/.local/share/virtualenvs/coverage/bin/python3
                   def_encoding: utf-8
                    fs_encoding: utf-8
                            pid: 51020
                            cwd: /home/vinay/projects/pagesign
                           path: /disk2/vinay/.local/share/virtualenvs/coverage/bin
                                 /home/vinay/.local/share/virtualenvs/coverage/lib/python37.zip
                                 /home/vinay/.local/share/virtualenvs/coverage/lib/python3.7
                                 /home/vinay/.local/share/virtualenvs/coverage/lib/python3.7/lib-dynload
                                 /home/vinay/.local/lib/python3.7
                                 /home/vinay/.local/share/virtualenvs/coverage/lib/python3.7/site-packages
                    environment: HOME = /home/vinay
                   command_line: /home/vinay/.local/share/virtualenvs/coverage/bin/coverage debug sys
                sqlite3_version: 2.6.0
         sqlite3_sqlite_version: 3.22.0
             sqlite3_temp_store: 0
        sqlite3_compile_options: COMPILER=gcc-7.5.0, ENABLE_COLUMN_METADATA, ENABLE_DBSTAT_VTAB,
                                 ENABLE_FTS3, ENABLE_FTS3_PARENTHESIS, ENABLE_FTS3_TOKENIZER, ENABLE_FTS4,
                                 ENABLE_FTS5, ENABLE_JSON1, ENABLE_LOAD_EXTENSION, ENABLE_PREUPDATE_HOOK,
                                 ENABLE_RTREE, ENABLE_SESSION, ENABLE_STMTVTAB, ENABLE_UNLOCK_NOTIFY,
                                 ENABLE_UPDATE_DELETE_LIMIT, HAVE_ISNAN, LIKE_DOESNT_MATCH_BLOBS,
                                 MAX_SCHEMA_RETRY=25, MAX_VARIABLE_NUMBER=250000, OMIT_LOOKASIDE,
                                 SECURE_DELETE, SOUNDEX, TEMP_STORE=1, THREADSAFE=1

Expected behavior
I didn't expect to see partial branch coverage for the finally block when adding an except block that isn't triggered.
Additional context
See source lines 262 and 520 in https://app.codecov.io/gh/vsajip/pagesign/commit/ac5c6c1096763b1f858efbdf7385564f394246b9/pagesign.py - though sometimes codecov.io can't display the page. When testing locally, the annotation for a block such as
L01 try:
L02     # some code
L03 except SomeException as e:  # pragma: no cover
L04     raise SomeOtherException() from e
L05 finally:
L06     # some finally code

says L06 ↛ exit and with a tooltip that says line L06 didn't except from function '<funcname>', because the raise on line L04 wasn't executed. This is confusing because I wouldn't have expected L06 to "except from function" - not sure what's meant there.
Can I add or change pragmas to avoid this decrease in coverage?

Short reproducing program:
import os
import subprocess
import tempfile

class CustomException(Exception): pass

def run_command(cmd, wd):
    p = subprocess.Popen(cmd, cwd=wd,
                         stdout=subprocess.PIPE, stderr=subprocess.PIPE)
    stdout, stderr = p.communicate()
    if p.returncode == 0:
        return stdout, stderr
    else:  # pragma: no cover
        raise subprocess.CalledProcessError(p.returncode,
                                            p.args,
                                            output=stdout,
                                            stderr=stderr)

def main():
    fd, fn = tempfile.mkstemp(prefix='test-')
    os.write(fd, b'Hello, world!')
    os.close(fd)
    try:
        run_command(['ls', '-l', fn], os.getcwd())
    except subprocess.CalledProcessError as e:  # pragma: no cover
        raise CustomException('Child process failed') from e
    finally:
        os.remove(fn)
    return 0

if __name__ == '__main__':  # pragma: no branch
    main()

I think I understand what is happening here.  In your first code example:
try:
   # some code
finally:
  # some finally code

the "finally" code can only execute one way: because "some code" has finished.  There's only one path through the finally code, and it is executed, giving you 100% branch coverage.
In the second code:
try:
     # some code
except SomeException as e:  # pragma: no cover
    raise SomeOtherException() from e
finally:
    # some finally code

there are two ways to run "some finally code": "some code" can finish normally (which it does), and "raise SomeOtherException" can happen (which it doesn't).  There are two paths through the finally code, and only one of them happens.  This gives you 50% branch coverage.
The complicating factor here is the pragma noting that the raise can never happen.  Coverage.py isn't taking that into account in deciding on the branch coverage in the finally clause.  I'm not sure what it would take for it to understand that, but it's an interesting case.
In the meantime, you can add # pragma: no branch to the line with 50% branch coverage to indicate that you know it is only partial.

OK, thanks for the explanation. Shall I close the issue? I ask in case you want to look into it further. I added some test cases to mak sure the exception was raised, and now I have 100% coverage again.
Thank you so much for all your work on coverage.


UseQuery does not fetch when using enabled, initialData, staleTime and a variable querKey

Describe the bug
When using staleTime > 0, the enabled flag attached to some state, a variable query key related to some state, and a initialData value, the query does not fetch when the cache key changes. removing the initialData option or the stateTime setting makes it work but not in the way we want it to (since I need staleTime and initialData). Worked around by not setting initialData and then checking for the current data value.
Your minimal, reproducible example
https://codesandbox.io/s/fragrant-bash-83ql2o?file=/src/App.js
Steps to reproduce

Click enable
Click any of the other boxes to change the queryKey
Check console, state is changing but the refetch is not happening

Expected behavior
I expect that when the queryKey changes, if we already have non stale data for the new key the non stale data is shown, if the data is stale the query runs again.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
Windows 11
Newest Chrome and firefox
Tanstack Query adapter
react-query
TanStack Query version
4.29.1
TypeScript version
4.9.5
Additional context
I've added redux to my example because I thought it was the culprit, but it seems it's actually the initialData/staleTime combo

Please provide an example without redux to help the community maintainers troubleshoot this issue better

I have noticed that your staleTime is 360000, if you set the staleTime to 60 then your statement "the query does not fetch when the cache key changes" would be false because it does fetch but there is a delay.

https://stackoverflow.com/questions/75346877/react-query-staletime-and-cached-value

Changed the example to remove redux. I don't see how staleTime should matter when the query key is changing. And like I said, removing the initialData option enables it to run for some reason(?).

Yes, for every query key change it is supposed to trigger the queryFn. However, since you have such a high staleTime plus initial data, to react-query this query is actually fresh therefore it would not call the queryFn.
So my conclusion is that this is not a bug.
Please read https://tanstack.com/query/v4/docs/react/guides/initial-query-data#staletime-and-initialdataupdatedat

I'm sorry but if it's supposed to refetch with the new query arguments, then why staleTime even matters?
My data hardly changes(only through user interaction, which changes the queryKey) thats why I have a high staleTime, so I don't hit the user with loading side effects when they navigate away and back.
My reasoning is: I need initial data to avoid dealing with undefined(value and type), I need staleTime to avoid loading screens when they are not needed, if the queryKey changes(changing filtering params/user interaction changes the data in the backend) then the query should be able to like you said trigger the fn.
In my undertanding initialData is there if the query hasn't finished fetching yet/failed, staleTime starts ticking as soon as the fetch is done.
I see that the docs you've sent does say that initialData actually sets the staleTime for itself, is there a way to workaround this? I would rather not have if(data!==undefined) and data?.... everywhere in my code

"I'm sorry but if it's supposed to refetch with the new query arguments, then why staleTime even matters?"
It matters because as soon as the new query is created it is 'fresh' due to the initial data, therefore it wouldn't even call queryFn. Therefore it is not a bug suggest we move this to discussions.
I highly recommend you install devtool to help you visualise what is going on.

"so I don't hit the user with loading side effects when they navigate away and back."
https://tanstack.com/query/v4/docs/react/guides/window-focus-refetching

initialData is persisted to the cache. It's treated as if that data were fetched from the network. So if you provide initialData and a staleTime, you will not get a refetch even when the key changes. I think you are just looking for placeholderData.
Please read: https://tkdodo.eu/blog/placeholder-and-initial-data-in-react-query

Thanks for the help!

@TkDodo  Thanks for clarifying here, but I thought I'd mention there's a reason I might not want to use placeholder data.
For example, say you've got a list of items, and you're going to be polling it every 10 seconds for updates. We don't want it be showing a flash of an empty list every 10 seconds as it polls.
It's worth mentioning too, that you can use initialData and have it be immediately stale if you set the initialDataUpdatedAt to 0.

We don't want it be showing a flash of an empty list every 10 seconds as it polls.

that's not what placeholderData would do. If you use a refetchInterval, it will only show the placeholder instead of the first empty state. After that, it will keep the stale data always.

It's worth mentioning too, that you can use initialData and have it be immediately stale if you set the initialDataUpdatedAt to 0.

yes that also works.


TWA-ViP Bug: Redirect to visualisation page when landing page is disabled

The platform is currently redirecting to the wrong page path when landing page is disabled. It should redirect to the explore page path

Issue has been resolved in a previous PR, and is working in 5.8.0


TEXT attribute is not extracted correctly from the filename

For ART200-Work_with_article.PGM.SQLRPGLE, The TEXT should be Work with article instead Work with article.PGM

bug still exists

bug still exists


Unable to run the LocalizationSample

@ryanbrandenburg after changing to VS 2017, I'm not able to run the LocalizationSample, when I run dotnet run I got this error:
LocalizationSample.csproj : error MSB4040: There is no target in the project.
The build failed. Please fix the build errors and run again.

@hishamco it is unclear to me what exactly the issue is here. You shouldn't need to run dotnet new to run the LocalizationSample since it already exists, so I assume you mis-typed. For the record I'm able to successfully launch and visit the LocalizationSample from VS2017 (granted, I'm using the very newest version).

Sorry for the typo, I run dotnet run. I update my VS yesterday to update 4 but I didn't try it, but still wondering why it doesn't work from the command line?!!

The CLI now requires that you provide a TFM if your project targets multiple frameworks, so you can't do dotnet run on projects like this anymore, you have to do dotnet run -f netcoreapp1.1. That said, the error message given when this happens does nothing to make that clear, so I'm going to file a bug against the CLI to that effect.

There's already an issue for this: dotnet/cli#4684.

Thanks a lot @ryanbrandenburg


[@azure/service-bus] support managing authorization rules for queues

Is your feature request related to a problem? Please describe.
I was expecting for ServiceBusAdministrationClient to be able to manage AuthorizationRules (including SAS) for entities (i.e. queues) inside a service bus namespace. However this is only possible for topics, as documented in the api reference
function createRule(topicName: string, subscriptionName: string, ruleName: string, ruleFilter: SqlRuleFilter | CorrelationRuleFilter, ruleAction: SqlRuleAction, operationOptions?: OperationOptions): Promise<WithResponse<RuleProperties>>

However, queues support granular authorization rules as well, which seem only to be manageable by ServiceBusManagementClient of @azure/arm-servicebus, but that requires much more overhead than @azure/service-bus does
Describe the solution you'd like
I'd like the ServiceBusAdministrationClient to support createRule not only for topics, but for queues as well.
If I'm not missing anything, this isn't possible besides with the other package right now.

@proohit Thanks for the feedback!  Currently this isn't something we support across languages (.NET/Java/Python/JS).  We will have a look.

@proohit I think you may have been confused by the name Rule.  The ServiceBusAdministrationClient only supports a subset of management APIs, and this particular method createRule is for managing subscription rule SQL filter https://learn.microsoft.com/en-us/azure/service-bus-messaging/service-bus-messaging-sql-filter.  We don't support creating authorization rules in ServiceBusAdministrationClient.

Hmm yes, it seems like I misunderstood the rule. Maybe refining the documentation on SQL filter rules on rule management functions would help for clarification.
Anyways, we will go with @azure/arm-servicebus. Thanks for your time and clearing that up.


Feature/read a customer

This PR is to resolve #2.
I added

read_customers(customer_id) in service/routes.py
test_read_a_customer(self) in tests/test_models.py

The function looks good, but in service/routes.py line 98-109 is not tested, please add some more test cases to cover them.

@yuchenzhao726 Does the test_read_a_customer(self) function in tests/test_models.py not test it?

@yuchenzhao726  I added the test cases. Thanks so much for your help!


added method for async component update

epic giantswarm/giantswarm#242
deps

https://github.com/giantswarm/app-service/pull/563
https://github.com/giantswarm/api/pull/188
https://github.com/giantswarm/app-client-go/pull/60
https://github.com/giantswarm/cli/pull/451

LGTM


Settings - Pending Requests Title

Current State
Currently a settings pending request just has "update policy" title:

However, this is not entirely clear to the user what that means. If the user clicks Details, they see a super long list of changes, which are overwhelming to parse through & not very human readable:

This creates a problem for approvers not knowing what request needs to be approved.
Desired State
Is there a way for us to create a more user friendly set of templates for common changes? For example, in this case I changed the policy to increase Voting Duration from 1 to 2.

hey @ori-near
That's a good point, we can edit the title as we want since that’s set by us
So if you have preference for title for all three kinds of request (duration, threshold, members)let me know, I will make the update.

Hi @Megha-Dev-19 as we discussed yesterday, let's update the Title column to include the affected area (e.g. "Update Policy – Members Permissions", "Update Policy – Voting Thresholds") etc and just use whatever we call the page in the settings navigation menu to represent the area.
Within the actual details popup, we could have two sections:
Summary
@user requested to increase voting from x to y
Transaction Details
Include the existing black section
Let me know if you have any questions!


Can't get scrollWidth from jsDOM node

I'm testing React components and one of my components tries to access the scrollWidth property of a jsDOM node. When I run my tests and log the result of  scrollWidth all I get is undefined, where as in the browser I get the correct value.
This is the line of code that logs undefined:
React.findDOMNode(this.refs.sizer).scrollWidth
However, if try to access className I receive the correct value.

Basically a dupe of #1013. jsdom does not do layout, so unless you want to help write a headless CSS layout engine, this is going to be ... hard.


Feature: add getResource and getResourceAsFile operators on Http

Tests are in #1061

Codecov Report

Merging #1074 (6ba3e84) into main (32d29e0) will increase coverage by 0.09%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1074      +/-   ##
==========================================
+ Coverage   56.89%   56.99%   +0.09%
==========================================
  Files          73       73
  Lines        2269     2274       +5
  Branches       62       71       +9
==========================================
+ Hits         1291     1296       +5
  Misses        978      978

Impacted Files
Coverage Δ

zio-http/src/main/scala/zhttp/http/Http.scala
75.53% <83.33%> (+0.91%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d29e0...6ba3e84. Read the comment docs.


Feature: Database Maintenance

Feature Target Details
Consider adding a scheduled run for update-processed.
Why is this change needed?
This would help to ensure the database is updated for previously renamed or deleted files on a semi-regular basis. This shouldn't run too often due to the time needed to run the function and the added disk operations, but once a week seems sensible.
Additional context
Track last in a new database table. This will provide a history and allow for checking if it's time for a new run.
Update-Database.ps1 script file will should be leveraged to insert the table.
Additionally shrinking the database might be considered at this time.

Also consider adding integrity checks of the database prior to performing actions.
if ((Invoke-SqliteQuery -DataSource "C:\Users\taylor\Downloads\MediaDB.SQLite" -Query "PRAGMA integrity_check").integrity_check -eq 'ok') {
# Do a thing
 }


Passing ASCII art from ascii-image-converter

Description

[x] Does this issue still occur in the master branch?

Hello,
I tried to use neofetch with an artwork I have generated with ascii-image-converter. However, it breaks neofetch if the artwork is generated with colour. I understand that neofetch isn't supposed to be used this way, but I'd still like to find a solution since it's not practical to recreate the nuances of colour using only six colours, manually.
Is there any way to use an ASCII artwork with colour, without using the colour flags internally defined by neofetch?
Thanks a lot :)
Neofetch version 7.1.0 (installed with brew on macOS)
Screenshot
Image with colour: no info is shown (more like pushed to the side somehow)

Image without colour: infos are shown correctly

Config file, Verbose log, ASCII artwork
Thank you !

This is fixed in HyFetch 1.4.0 / neowofetch 7.3.0 by the pull request https://github.com/dylanaraps/neofetch/pull/1543.

This PR is merged into hyfetch since this repo (dylanaraps/neofetch) seems no longer maintained.
HyFetch is a fork of neofetch with LGBTQ pride flags, but the repo also maintains an updated version of the original neofetch, addressing many pull requests that are not merged in the original repo.
Read the "Running Updated Original Neofetch" section for more info!

Thanks for the reply, I tried neowofetch and it worked charm :)
Thanks !


[bug] still: Make sure to build avante (missing avante_templates) on ask

Linux, latest commit 2b89f0d529add18fd39cee37073c17c8179b2358 (the same behavior with v0.0.2)

Plug setup, default config
cd ~/.local/share/nvim/plugged/avante.nvim

build.sh runs fine && downloads stuff
build dir now has 2 .so libs, avante_templates.so  avante_tokenizers.so

but still getting the error:

E5108: Error executing lua: ....local/share/nvim/plugged/avante.nvim/lua/avante/llm.lua:59: Make sure to build avante (missing avante_templates)
stack traceback:
        [C]: in function 'error'
        ...local/share/nvim/plugged/avante.nvim/lua/avante/path.lua:75: in function 'get'
        ....local/share/nvim/plugged/avante.nvim/lua/avante/llm.lua:59: in function 'stream'
        ...al/share/nvim/plugged/avante.nvim/lua/avante/sidebar.lua:1266: in function 'handle_submit'
        ...al/share/nvim/plugged/avante.nvim/lua/avante/sidebar.lua:1319: in function <...al/share/nvim/plugged/avante.nvim/lua/avante/sidebar.lua:1309>

Doing something wrong?

is this vim-plug?

yes, but I only used it for "checkout"; I am running the build steps && checking state manually in the .local/... dir, so imo not an issue of plug

Or is it some directory issue maybe?

Specifically, inspecting the module (with assert at L138) loaded here: https://github.com/yetone/avante.nvim/blob/b8c484148a4fc93cecd48e3f061ee5dea63c618a/lua/avante/path.lua#L135
I get:
Error executing vim.schedule lua callback: ...local/share/nvim/plugged/avante.nvim/lua/avante/path.lua:140: "module 'avante_templates' not found:
	no field package.preload['avante_templates']
	no file './avante_templates.lua'
	no file '/home/runner/work/neovim/neovim/.deps/usr/share/luajit-2.1/avante_templates.lua'
	no file '/usr/local/share/lua/5.1/avante_templates.lua'
	no file '/usr/local/share/lua/5.1/avante_templates/init.lua'
	no file '/home/runner/work/neovim/neovim/.deps/usr/share/lua/5.1/avante_templates.lua'
	no file '/home/runner/work/neovim/neovim/.deps/usr/share/lua/5.1/avante_templates/init.lua'
	no file './avante_templates.so'
	no file '/usr/local/lib/lua/5.1/avante_templates.so'
	no file '/home/runner/work/neovim/neovim/.deps/usr/lib/lua/5.1/avante_templates.so'
	no file '/usr/local/lib/lua/5.1/loadall.so'"

so it is a dir issue.

A working workaround is to move the .so files to /usr/local/lib/lua/5.1/. But I think there might be a better way to add the build dir into "path" or wherever lua looks for stuff. Gonna try && fix this.

For avante.tokenizers and templates to work, make sure to call require('avante_lib').load() somewhere when entering the editor. We will leave the users to decide where it fits to do this, as this varies among configurations. (But we do recommend running this after where you set your colorscheme)

Did you call this somewhere?

Updated avante to latest and getting same error

can you set version = false to lazy to make sure you are pulling the latest version?
also can you check if the build directory under ~/.local/share/nvim/lazy/avante.nvim is built correctly?
We have updated the build instruction to make it work better with lazy.

can you set version = false to lazy to make sure you are pulling the latest version?
also can you check if the build directory under ~/.local/share/nvim/lazy/avante.nvim is built correctly?
We have updated the build instruction to make it work better with lazy.

I've set lazy = false and also add build = "make" from README.md
And now it's working again, thank you @aarnphm

@aarnphm Hi, thanks for the great plugin.
I have a similar issue, however, with a different reason, when I run lua require("avante_templates"), I got this error:
E5108: Error executing lua error loading module 'avante_templates' from file '/data/home/acw759/.local/share/nvim/site/lazy/avante.nvim/lua/../build/avante_templates.so':
        /lib64/libm.so.6: version `GLIBC_2.29' not found (required by /data/home/acw759/.local/share/nvim/site/lazy/avante.nvim/lua/../build/avante_templates.so)

My machine's GLIBC version is 2.27, do you have any solution for this?

build = "make" is providing an arm binary on Mac OS. For Intel macs, need to use build = "make BUILD_FROM_SOURCE=true".

hmm if you want to have binary for intel mac feel free to contribute to the release CI

build = "make" is providing an arm binary on Mac OS. For Intel macs, need to use build = "make BUILD_FROM_SOURCE=true".

This should be mentioned in the README.


🐛 [Bug]: [TimePicker] 滚动选择时间二次点击无法滚动至指定位置

Version
latest
Vue Version
latest
Link to minimal reproduction
https://opentiny.design/tiny-vue/zh-CN/os-theme/components/time-picker
Step to reproduce
官网示例
What is expected
点击后滚动至指定位置
What is actually happening
No response
Any additional comments (optional)
No response

Fixed by @wNing50 on #1169


Model type not yet supported by TreeExplainer: <class 'tensorflow.python.keras.engine.sequential.Sequential'>

I am trying to use shap on an LSTM neural net I created with Keras. My imports are these:
from tensorflow.keras.preprocessing.sequence import TimeseriesGenerator
from tensorflow.keras.models import Model, Sequential, load_model
from tensorflow.keras.optimizers import SGD, Adam
import tensorflow as tf

from tensorflow.keras.layers import *

And my architecture is this:
## model taken from here: https://www.tensorflow.org/tutorials/structured_data/time_series?fbclid=IwAR1CfmX6adoEpeVF9hqc1eNMf7AJIZM0pEzWpyMvbfFizxsa2uR97yDvgKQ#recurrent_neural_network
model = Sequential()
model.add(LSTM(32, return_sequences=False, input_shape=(n_input, X.shape[1])))
model.add(Dense(24))
model.compile(loss='mean_squared_error', optimizer='adam', metrics=['mse'])

model.fit(train_generator, validation_data=val_generator, epochs=15, verbose=1,
             callbacks=[modelsave_cb])

Unfortunately, I get the above-mentioned error message:
Exception: Model type not yet supported by TreeExplainer: <class 'tensorflow.python.keras.engine.sequential.Sequential'>
What's the source of the problem? Doesn't shap work with LSTMs and sequential? Or should I maybe import the layers in a different way, as suggested here? Thanks

Hi,
TreeExplainer is used to interpret decision tree based models. I think you'll have better luck making shap work on your model with DeepExplainer.
I hope this documentation example helps: https://shap.readthedocs.io/en/latest/example_notebooks/text_examples/sentiment_analysis/Keras LSTM for IMDB Sentiment Classification.html


Q: Recommended in-browser IconVG decoder?

Hi! Do you know of any usable work, or have any recommendations, for IconVG decoding in the browser?
I'm thinking of something that'd be able to replace inline elements, like say <img src='data: image/x-iconvg;base64,iklWRwMLEVFRsbE1gVkzWYGBqTWFlTR9lX19NYV1NH11fW2I' />, with the rendered image.
I suppose compiling @Hixie's contributed DART decoder to JS might be a fruitful approach – though of course supporting the current IconVG format would be preferred.
Thanks!

I don't know of anything that's usable 'out of the box'.
Hixie's Dart decoder is a good place to start, but as you said, it needs upgrading to the latest file format version.
You could also try compiling the C code to WASM and writing a canvas backend (as opposed to Cairo or Skia).
Either approach would require a bit of work, though.


Support for mixins on MethodViews

It looks like @menudoproblema already has PR open for this: #1276
I'm filing this issue to register my interest in having support for implementing HTTP methods via mixins on MethodView classes as well.

On second thought, maybe it's clearer not to have method handlers come in from mixins.


Consider reversing order of release notes list

The release notes slide down on the left when the title is clicked. To me, it seems natural that the most recent notes would be first in the list.

Never mind, I was reading the list incorrectly. It is already in this order!


Create index.d.ts

Just a simple declare module so typescript doesn't cry. Please also upload a new NPM package with this. Thank you 🙏

Hey! I am so so sorry I missed this, for some reason I didn't have notifications on for this repo!
I'll test this out and merge it if we all good!

This has been fixed in the 2.0.0 rel: https://github.com/ghostdevv/rollup-obfuscator/releases/tag/v2.0.0


[ENH] groupby_agg refactor

PR Description
Please describe the changes proposed in the pull request:

Add dropna parameter, to include null values in groupby column. (thanks to minimum Pandas version 1.1)
Add examples to docstrings

This PR improves groupby_agg.

PR Checklist

Please ensure that you have done the following:

[x] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.

[x] If you're not on the contributors list, add yourself to AUTHORS.rst.

[x] Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Quick Check
To do a very quick check that everything is correct, follow these steps below:

[x] Run the command make check from pyjanitor's top-level directory. This will automatically run:

black formatting
flake8 checking
running the test suite
docs build

Once done, please check off the check-box above.
If make check does not work for you, you can execute the commands listed in the Makefile individually.
Code Changes

If you are adding code changes, please ensure the following:

[x] Ensure that you have added tests.
[x] Run all tests ($ pytest .) locally on your machine.

[x] Check to ensure that test coverage covers the lines of code that you have added.
[x] Ensure that all tests pass.

Documentation Changes

If you are adding documentation changes, please ensure the following:

[x] Build the docs locally.
[x] View the docs to check that it renders correctly.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

@ericmjl ; once complete_refactor is ok, this one should be resolved; one of the fails is dependent on the complete_refactor PR

Let's merge!


HA 2023.7 problems.

Updating HA and is getting:
Logger: zhaquirks
Source: custom_zha_quirks/ts0601_trv_siterwell.py:60
First occurred: 09:39:02 (1 occurrences)
Last logged: 09:39:02

Unexpected exception importing custom quirk 'ts0601_trv_siterwell'
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/zhaquirks/__init__.py", line 454, in setup
    importer.find_module(modname).load_module(modname)
  File "<frozen importlib._bootstrap_external>", line 605, in _check_name_wrapper
  File "<frozen importlib._bootstrap_external>", line 1120, in load_module
  File "<frozen importlib._bootstrap_external>", line 945, in load_module
  File "<frozen importlib._bootstrap>", line 290, in _load_module_shim
  File "<frozen importlib._bootstrap>", line 721, in _load
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/config/custom_zha_quirks/ts0601_trv_siterwell.py", line 60, in <module>
    class SiterwellManufCluster(TuyaManufClusterAttributes):
  File "/usr/local/lib/python3.11/site-packages/zigpy/zcl/__init__.py", line 165, in __init_subclass__
    raise TypeError(f"Duplicate definitions exist for {duplicates}")
TypeError: Duplicate definitions exist for ['window_alarm']

If need more logs i can providing it.
Thanks in advance Jacekk !!

Hi,
unfortunately I'm on vacation in Italy. Please check for duplicate of window_alarm code. Did you maybe copy/paste something?

Sounds great !!!
I using your standard quirk and have working well and i think its not copy past error but it can waiting than all TRV is idle for the moment and we can taking one look then you is back at home.
Have one great holiday in Bella Italia !!!!

I was finding the typo in the quirks is was:
            SITERWELL_WINDOW_ALARM_ATTR: ("window_alarm", t.uint8_t, True),
            SITERWELL_VALVE_JAMMED_ALARM_ATTR: ("window_alarm", t.uint8_t, True),

and changing it to:
            SITERWELL_WINDOW_ALARM_ATTR: ("window_alarm", t.uint8_t, True),
            SITERWELL_VALVE_JAMMED_ALARM_ATTR: ("valve_alarm", t.uint8_t, True),

and ZHA is loading it OK and looks working but i have not testing the functions of window open and valve alarm.
Good for other user can getting the quirk working and you can taking one look later in October / November if its being OK then we need the TRVs working.
Great thanks for help and support for our TRVs !!!

PR made so you can committing it if you like so its being easier for other users.

Not sure that this is exactly the same quirk as mine, but I also noticed the above error on a siterwell quirk I was using (its also on a beca based TRV quirk that I have), but I also noticed that whilst the above one liner does allow the quirk to load, I was getting other errors. The errors, and the fix I applied are here:
https://community.home-assistant.io/t/zclattributedef-object-is-not-subscriptable/590645

Fundamentally it looks like update 2023.7 has changed the ZCLAttributeDef class, and any quirk that uses code like this:-
self.attributes[record.attrid][0]
Will break, and needs changing to this:
self.attributes[record.attrid].name

@rofo69 That was actually corrected long time ago.


Need service transport diagnostic feature

When diagnosing Jadeite bugs it would be nice to have call tracing like GBS. Probably the most straight forward would be a switch that enabled logging to separate files on both the client and server with a unique serial number to identify "transactions."
Better yet, we could log server and client files to one client file but that could run into interleaved writes on the client if one isn't careful.
See client methods BrowserUpdate>>basicIssueCommand:session: and server method RowanCommandResult class>>addResult: as possible logging hooks.

I'm going to call this complete. One can turn on Logging in the transcript, then Browse Jadeite Logs.


Cannot navigate in proxied page

Awesome library.
I just forked the code and set up my own heroku instance, and I removed the Origin header check (that browsers don't send), so that I can test in-browser.
This works. https://sirchester-proxy.herokuapp.com/https://google.com. However, try to search for something, I get:
Invalid host: search

It's not only on google, but generally, when using this proxy, navigation is broken.

This is the wrong tool for your task. CORS Anywhere should only be used for fetching specific requests (possibly from other origins). It is not a generic web proxy. You shouldn't remove the Origin check, as that exists to stop direct browsing of remote content (which is a security issue, because you'd be allowing arbitrary remote content to run code on your origin).
This is a duplicate of: #61, #359, #399


Personal Desk Booking Page - UI

User story

As a user
I want / need to see a UI page for booking personal desks
So that I can select a date and time as well as select my desk preferences

Acceptance criteria

The UI page for booking personal desks should show the text: Hello username, book a personal desk
The page should provide a calendar to select a date and an option to enter a time for booking desks
The page should offer options to select preferences specified by the company (drop down menues, use mock data): location, building, room, desk type
The page should show a search button to initialize the booking search process
Only frontend

Definition of done (DoD)

The code has been peer-reviewed by at least one team member
The documentation was updated if necessary
The bill of materials was updated if necessary
Working dev setup was created

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

The page should be available through a seperate entry in the top bar.

add react-datepicker to bill of material

Is this currently set up to have a start date+time and end date+time or only one date+time?

@qy21gafy We can do that both, we'd implement a start and end time if that is correct.


fix(delayWhen): only deprecates when subscriptionDelay presents

Noticed this after vscode starts showing the deprecation from jsdoc, not sure how to test this change tho.

api_guardian is failing, not exactly have fixing in mind, could use some help.

Thanks for the PR.

... not sure how to test this change tho.

We should add some dtslint tests to make sure that the deprecations work as expected. ATM, there aren't many examples of this, as the ExpectDeprecation assertion was something that I added in anticipation of fixing up these sorts of false positives - and I've not yet got around to that. For an example, have a look at of:
https://github.com/ReactiveX/rxjs/blob/338b1746e11247bbdc6d617b634fab900717288f/spec-dtslint/observables/of-spec.ts#L122-L139
To run the dtslint tests, use npm run dtslint.
Note that there is also an ExpectNoDeprecation assertion.

api_guardian is failing

You should be able to use npm run api_guardian:update to update its files.

Updated, have spec-dtslint and api_guardian included.

Thank you @imcotton


Include whitespace after checkbox

The current behaviour after pressing <CR> on a checkbox line is the following (where | is the cursor position):
- [ ] first line
- [ ]|

I would like for it to also create a newline after the checkbox, like this:
- [ ] first line
- [ ] |

require('autolist').setup({
  checkbox = {
    right = '%] ',
  },
})

But that makes no difference.

Huh that’s weird, I’ll give it a look in a bit

Oups

should be fixed

Works, now thank you very much!


chore: normalize package.json

Codecov Report

Merging #69 (f984e12) into main (ccbef75) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   78.37%   78.37%
=======================================
  Files           1        1
  Lines          37       37
  Branches       17       17
=======================================
  Hits           29       29
  Misses          7        7
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccbef75...f984e12. Read the comment docs.


No available sqlitebrowser

Hi all.
I'm trying to install sqlitebrowser but got this message
Error: No available formula with the name "sqlitebrowser" It was migrated from homebrew/core to caskroom/cask. You can access it again by running:   brew tap caskroom/cask
Please take a look and give me advise.
Thanks.

brew cask install sqlitebrowser

Many thanks, just new to mac

@thanhngvpt no worries.


Updated CVSSv4.0 based on specifications

Pull request CVSSv4.0 updated accordingly to specifications

Would appreciate this being reviewed/approved as soon as possible.  I'd like to merge this into https://github.com/FIRSTdotorg/cvss-v4-calculator first thing Monday morning.

@ViperGeek I am firmly against rushing this change. In current state it would be very hard to understand and maintain. In current state it would not be a good reference implementation.
Hello @giorgioditizio ! If this code works as expected, then it is a great proof-of-concept. However, from my point of view it is hard to understand and very hard to maintain as is.
I see some options:

Use this as a proof-of-concept branch, which we can test against. Then write a proper solution based on properly written computation requirements (do we have them available already)?
Gradually improve this merge request, so it can be understood by multiple contributors and maintained in the future.
Merge it as is, but I would like you as a contributor to also commit to a lot of changes to the code to make it easier to understand and maintain. I cannot commit to maintain this code as is in the future.

Hi @skontar I understand there have been issues in the past getting consistent results with floating point implementations in the past. I think one solution is to say "We assume that you are running this on IEEE 754 double precision floating point standard", and we make explicit how rounding works (Round Up to nearest Multiple, ie Math.ceil(x*10)/10. That should cover most languages/compilers/architectures.
Finally, because you haven't been attending the meeting I assume you are unaware that we planned to release the calculator (at least in a prototype form) at the FIRST conference this week. This is something that has been discussed and planned for. Moreover, while there are some last minute changes, many of your concerns has been available and actively worked on by myself Fabio, and Giorgio since mid-March. We are aware this is far from perfect, but we were working towards an implementation that satisfied the SIG requirements, allowed us to test multiple options, and rapidly prototype. As I am sure you have experienced, stripping away the code that is used for testing often results in something less than perfect.
I understand your are uncomfortable with current state as a reference implementation, and I would agree. I would stress that we should merge this branch and present it as a prototype for public comment, and we will work with you to create a more acceptable reference implementation.

@bjedwards there are unfortunately far more problems with floating-point arithmetic. It can be reduced by the approach you proposed, but not fully eliminated. For example even different order of calculations, which may still fit the requirements, may cause issues. However, it can be fully eliminated by doing all computations in fixed point arithmetic (basically by multiplying everything by 10) and then shifting decimal point as the last operation.
Thank you for the explanation of the intended approach. It seems that I should have attended some of the meetings to have a better understanding of intended steps. I am sorry for misunderstanding. I believe what you propose is a good plan. Lets see if it will work for at least some of us to quickly meet to discuss how exactly to proceed.

Hi @giorgioditizio . We had a discussion with other SIG members to clarify the intention of this pull request and followup work. Please disregard the review comments.
After we merged license changes, there is now a conflict. If you could resolve the conflict I can merge it. Thanks!

Hi @skontar . I resolved the conflict and fixed the code accordingly to the remaining review comments. Let me know if it is ok. Thanks


Module not found: Can't resolve 'dgram'

I install some libp2p's packages on my Node.js project and I wrote some codes like below.
const libp2p = require('libp2p')
const TCP = require('libp2p-tcp')
const WS = require('libp2p-websockets')
const spdy = require('libp2p-spdy')
const secio = require('libp2p-secio')
const MulticastDNS = require('libp2p-mdns')
const DHT = require('libp2p-kad-dht')
But the multicast-dns module was occurs some error.
./~/multicast-dns/index.js
Module not found: Can't resolve 'dgram' in '/Users/sangwoojoo/Documents/work/clock-core/node_modules/multicast-dns'

Which version of npm and nodejs are you using?

@joowh85 not being able to replicate this one. Could to try with a fresh npm install?


Updated the description of AllowManagement OS parameter

Docs Build status updates of commit f1e2274:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/.sourcemap-maml-0.json
:white_check_mark:Succeeded

docset/docs-conceptual/mdop/toc.yml
:white_check_mark:Succeeded
View (win-mdop2-ps)

docset/docs-conceptual/winserver2012-ps/toc.yml
:white_check_mark:Succeeded
View (winserver2012-ps)

docset/docs-conceptual/winserver2012r2-ps/toc.yml
:white_check_mark:Succeeded
View (winserver2012r2-ps)

docset/docs-conceptual/winserver2016-ps/toc.yml
:white_check_mark:Succeeded
View (WindowsServer2016-ps)

docset/docs-conceptual/winserver2019-ps/toc.yml
:white_check_mark:Succeeded
View (WindowsServer2019-ps)

docset/docs-conceptual/winserver2022-ps/toc.yml
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/mdop/agpm/add-controlledgpo.yml
:white_check_mark:Succeeded

docset/mdop/agpm/get-controlledgpo.yml
:white_check_mark:Succeeded

docset/mdop/agpm/index.yml
:white_check_mark:Succeeded

docset/mdop/agpm/lock-controlledgpo.yml
:white_check_mark:Succeeded

docset/mdop/agpm/publish-controlledgpo.yml
:white_check_mark:Succeeded

docset/mdop/agpm/remove-controlledgpo.yml
:white_check_mark:Succeeded

docset/mdop/agpm/unlock-controlledgpo.yml
:white_check_mark:Succeeded

docset/mdop/appv/convertfrom-appvlegacypackage.yml
:white_check_mark:Succeeded

docset/mdop/appv/index.yml
:white_check_mark:Succeeded

docset/mdop/appv/test-appvlegacypackage.yml
:white_check_mark:Succeeded

docset/mdop/appvclient/add-appvclientconnectiongroup.yml
:white_check_mark:Succeeded

docset/mdop/appvclient/add-appvclientpackage.yml
:white_check_mark:Succeeded

docset/mdop/appvclient/add-appvpublishingserver.yml
:white_check_mark:Succeeded

docset/mdop/appvclient/disable-appvclientconnectiongroup.yml
:white_check_mark:Succeeded

docset/mdop/appvclient/enable-appvclientconnectiongroup.yml
:white_check_mark:Succeeded

docset/mdop/appvclient/get-appvclientapplication.yml
:white_check_mark:Succeeded

docset/mdop/appvclient/get-appvclientconfiguration.yml
:white_check_mark:Succeeded

docset/mdop/appvclient/get-appvclientconnectiongroup.yml
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#sign-off

@ManikaDhiman This PR changes more than 5000 files. Your branch is not clean. You need to fix your branch. It may be easiest to start over.

It looks like you have local builds turned on for the Microsoft Docs Authoring Pack in VS Code. You need to turn that off and start over.

I will start afresh with a clean branch--closing this PR. Thanks!


Remove support for format-specific renames, replace with ser or de specific renames

This effectively reverts #69, and restores the functionality added in #62. This feature that allows format-specific renames has never been used, and it's complicating the implementation of #207.
According to #61, if one uses serde to serialize requests that pass url-encoded parameters to a server, it might get responses back with a different capitalization scheme. This patch restores the behavior implemented in #62.
This closes #211.

This also adds support for renaming containers and variants.
Closes #207, #182, #195


feat: add class var pluginOrigin to set plugin header

Current dependencies on/for this PR:

main

PR #95   (this PR)

This comment was auto-generated by Graphite.


[MODFISTO-273] - Cansel invoice cross-modules test

These tests were merged with the MODINVOICE-270 PR.