refactor(frontend): clean up redundant field HandleConflictBehavior

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Checklist For Contributors

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

[ ] My PR DOES NOT contain user-facing changes.

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

Installation and deployment
Connector (sources & sinks)
SQL commands, functions, and operators
RisingWave cluster configuration changes
Other (please specify in the release note below)

Release note

For all breaking changes, we could use a script to do the upgrade in the future. We thereby decide to change this anyway. cc. @BugenZhao


Clarification that text-valued variables and attributes can be Unicode strings or UTF-8 char arrays

See issue #141 for discussion of these changes.
Release checklist

[NA] Authors updated in cf-conventions.adoc? Add in two places: on line 3 and under .Additional Authors in About the authors.
[Y] history.adoc up to date?
[Y] Conformance document up to date?

Whoo Hoo! thanks all for getting this through!


Host kubernetes/pause on gcr.io

I believe this just requires changing the image name here, but I wanted to check that there isn't other work to do before we move it. IIRC, the pause pod is cached on containervm, so we should make sure the gcr.io/google_containers/pause tag is also cached.
cc @vmarmol, @dchen1107

kubernetes/pause is cached in ContainerVM image, should we remove it after gcr.io host kubernetes/pause?

I am going to do this, since I plan to push etcd_server to gcr.io today.

@dchen1107, I think we still want to cache it in ContainerVM image, just with the gcr.io tag.


Updated gradle server task to use properties files, and minor cleanup.

Pull Request Test Coverage Report for Build 2453

2 of 3 (66.67%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.643%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server/src/main/java/com/netflix/conductor/bootstrap/Main.java
0
1
0.0%

Totals

Change from base Build 2450:
0.0%

Covered Lines:
9183

Relevant Lines:
13378

💛  - Coveralls


Doc fix 3

oh no, now I have to finish stuff I've been coding, don't I?

/giphy simpsons excellent


WIP: Deep Gaussian process module

Deep Gaussian process module implementing the doubly stochastic variational inference deep GP.
I still need to add the mean function for intermediate layers but the code works as it currently is.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Question: I would like to add the mean function to intermediate layers. I'm wondering what the best way to do this is?
The way I plan on doing it is to add both the mean function and the mean variable to the graph:
for i in range(self.n_layers):
    layer_inputs = ... # m.X for the first layer, m.f_{i-1} for subsequent layers
    ... other stuff ...
    # new bit for mean function
    mean_gluon_func = ... # some gluon function
    mean_func =  MXFusionGluonFunction(mean_gluon_func)
    setattr(graph, 'mean_func_' + str(i), mean_func)  # mean function
    setattr(graph, 'mean_' + str(i), mean_func(layer_inputs) )  # mean variable
    # pass mean variable in to conditional GP (for f) but not GP for U
     ... other stuff ...

I then need to be able to evaluate the mean function in the inference algorithms compute() method. Will the mean function appear in the variables dictionary that is supplied to the compute() method?


solana_token_audit#4: Allowing redundant operations

Description
Several operations of dubious value are allowed in the system, should they really be allowed?
• Transfers from and to the same account.
• Minting 0 tokens.
• Burning 0 tokens.
• Assigning the current owner as the new owner of an account.
Proof of Issue
Filename: token/cli/src/main.rs, token/program/src/processor.rs
Severity and Impact Summary
A Null operation or an operation that is allowed but has no impact on the state or the effect is
void on the blockchain will still have a computational cost. This opens up to a possible DDoS
attack where malicious actors would incur cost on the processing of the transactions and
thereby could block the processing of legitimate transactions.
Recommendation
If current behavior is not desired, introduce logical checks to verify that the operations are only
allowed when they make an actual difference to the accounts.

The operations mentioned in this issue's description all require the payer to pay for the transaction.  In addition:

Transfers to and from the same account doesn't enforce that the owner is present because the process function returns early if the source and destination account are the same.  This could potentially result in a cheap(er) exploit.
Minting above I presume is referring to MintTo (since when Mint'ing no amount is specified.  In the case of MintTo the cost of minting zero or non-zero coins is the same.   Preventing the minting of zero coins doesn't protect against anything.
Burning zero tokens incurs the cost of the account owner's signature but could potentially be done indefinitely.
Assigning an account owner to the same owner incurs the cost of the account owner's signature and would be the same as assigning owners in round-robin between a collection of keys.

None of the above operations stand out as a serious threat.  In terms of the cheap transfer to one's self, we could enforce that the owner was a signer before we return that also seems trival.
Keeping the operations as they are either saves the logic to enforce against these cases or are useful for testing.

@mvines @CriesofCarrots Feel free to reopen if you disagree


Enabled templated hostfile

Fixed templating options so that templated hostfiles work.
Removed extra debug task from the beginning which I had forgotten there
in another commit.

Of course.


Remove uses of temp_await from PubGrubDependencyResolver

Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test

@swift-ci test


CI: v1.7: K8sFQDNTest: Testapp is not ready after timeout

Both K8sFQDNTest Restart Cilium validate that FQDN is still working and K8sFQDNTest Validate that multiple specs are working correctly are failing.
https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/19866/
test_results_Cilium-PR-Ginkgo-Tests-Validated_19866_BDD-Test-PR-K8s-1.17.zip
The above is the only occurrence of this failure we could find thus far.
Stacktrace
/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.17-gopath/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:384
Testapp is not ready after timeout
Expected
    <*errors.errorString | 0xc0004add90>: {
        s: "Timeout reached: timed out waiting for pods with filter -l zgroup=testapp to be ready",
    }
to be nil
/home/jenkins/workspace/Cilium-PR-Ginkgo-Tests-Validated/k8s-1.17-gopath/src/github.com/cilium/cilium/test/k8sT/fqdn.go:69

Initial investigations
The tests are failing because the test applications fail to deploy:
cmd: kubectl get pods -o wide --all-namespaces
Exitcode: 0
Stdout:
 	 NAMESPACE     NAME                               READY   STATUS              RESTARTS   AGE     IP              NODE   NOMINATED NODE   READINESS GATES
	 default       app1-68cb4f68c5-ssdkk              0/2     ContainerCreating   0          4m1s    <none>          k8s1   <none>           <none>
	 default       app1-68cb4f68c5-xmfsr              0/2     ContainerCreating   0          4m1s    <none>          k8s1   <none>           <none>
	 default       app2-776cf4f9c6-kjplv              0/1     ContainerCreating   0          4m1s    <none>          k8s1   <none>           <none>
	 default       app3-65f9dc989c-g84ms              0/1     ContainerCreating   0          4m1s    <none>          k8s1   <none>           <none>
	 kube-system   cilium-d54xk                       1/1     Running             0          5m17s   <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system   cilium-operator-789d9866b7-dp88b   1/1     Running             0          5m17s   <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system   cilium-operator-789d9866b7-vxq9q   1/1     Running             0          5m17s   <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system   cilium-vdz9q                       1/1     Running             0          5m17s   <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system   coredns-767d4c6dd7-8w67z           1/1     Running             0          4m57s   <IP_ADDRESS>       k8s2   <none>           <none>
	 kube-system   etcd-k8s1                          1/1     Running             0          54m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system   kube-apiserver-k8s1                1/1     Running             0          54m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system   kube-controller-manager-k8s1       1/1     Running             0          54m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system   kube-proxy-jd4sp                   1/1     Running             0          52m     <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system   kube-proxy-l7tbp                   1/1     Running             0          54m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system   kube-scheduler-k8s1                1/1     Running             0          54m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system   log-gatherer-7mdfl                 1/1     Running             0          51m     <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system   log-gatherer-mkchn                 1/1     Running             0          51m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system   registry-adder-kpr6t               1/1     Running             0          52m     <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system   registry-adder-vfvp9               1/1     Running             0          52m     <IP_ADDRESS>   k8s1   <none>           <none>

Stderr:

They fail to deploy because of the following:
Events:
  Type     Reason                  Age                   From               Message
  ----     ------                  ----                  ----               -------
  Normal   Scheduled               4m13s                 default-scheduler  Successfully assigned default/app1-68cb4f68c5-ssdkk to k8s1
  Warning  FailedCreatePodSandBox  4m12s                 kubelet, k8s1      Failed to create pod sandbox: rpc error: code = Unknown desc = [failed to set up sandbox container "f2c3fbda8edf5efbebd51299b505cf8aa5f22f919c6bc41202c7857cac4626e0" network for pod "app1-68cb4f68c5-ssdkk": networkPlugin cni failed to set up pod "app1-68cb4f68c5-ssdkk_default" network: failed to find plugin "cilium-cni" in path [/opt/cni/bin], failed to clean up sandbox container "f2c3fbda8edf5efbebd51299b505cf8aa5f22f919c6bc41202c7857cac4626e0" network for pod "app1-68cb4f68c5-ssdkk": networkPlugin cni failed to teardown pod "app1-68cb4f68c5-ssdkk_default" network: failed to find plugin "cilium-cni" in path [/opt/cni/bin]]
  Normal   SandboxChanged          11s (x20 over 4m11s)  kubelet, k8s1      Pod sandbox changed, it will be killed and re-created.

/opt/cni/bin/cilium-cni should only be removed when we uninstall Cilium (cni-uninstall.sh), when Cilium pods stop. Cilium pods are however up and haven't been restarted.
/cc @qmonnet

Same networkPlugin cni failed to set up pod "redis-master-phzcv_default" network: failed to find plugin "cilium-cni" in path [/opt/cni/bin], failed to clean up sandbox container error in pods_status.txt in the K8sPolicyTest GuestBook Examples checks policy example test from #13228, https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-K8s/3555/testReport/junit/Suite-k8s-1/15/K8sPolicyTest_GuestBook_Examples_checks_policy_example/ .

This test was quarantine, so I'm unsure if this issue is still relevant.

Not sure whether this is the same, but I've hit the same test failing on #15634 for v1.8: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-kernel-4.9/163/testReport/junit/Suite-k8s-1/16/K8sFQDNTest_Restart_Cilium_validate_that_FQDN_is_still_working/

@tklauser yes, opening that link, downloading the artifacts, then opening up the "pods_status.txt" you can find the same error as reported in this comment above:
https://github.com/cilium/cilium/issues/12795#issuecomment-701006527

@joestringer I did the same but was a bit puzzled: the pod scheduling continued after that error, as if it was eventually resolved. It seemed the readiness/liveness probes were the real issue :thinking:

Maybe the ordering and timeouts are just misaligned here? I see what you mean, in the original v1.7 version the pods stayed in ContainerCreating. Was that just because we didn't wait long enough in the first case? Or it really gets stuck in the original report and in the new report it is able to resolve itself?


Include dynamicAssets during findAssetsInViteManifest

IS
In the production build, css required by dynamically imported (lazy) components is ignored during server rendering, resulting in flashes of unstyled content.
SHOULD
The html rendered by the server should include assets required by dynamically imported components to avoid the flashes of unstyled content.
PROPOSAL
There might be a better way, but by making the following changes to lib/manifest/vite-manifest.js the server will include the assets:
--- vite-manifest.js    2024-03-26 20:35:48.782476412 +0100
+++ vite-manifest-new.js        2024-03-26 20:37:56.720628174 +0100
@@ -30,10 +30,13 @@

                stack.push(id);

+               const dynamicImports = id.startsWith('virtual:') ? undefined: chunk.dynamicImports
+
                const assets = [
                        ...(chunk.assets || []),
                        ...(chunk.css || []),
                        ...(chunk.imports?.flatMap(traverse) || []),
+                       ...(dynamicImports?.flatMap(traverse) || []),
                ];
                const imports = chunk.imports?.flatMap(traverse) || [];
                const all = [...assets, ...imports].filter(Boolean);

This solution isn't perfect because it doesn't detect if the dynamic import is actually executed during ssr (lazy component loaded).. But this proposal might atleast be a first step, as it opens up the door for css code splitting on a per-route level.
What do you think?
P.S. I can make a PR if you like this :).

Yeah the main issue as you suggested is that we don't know if that CSS file is used, so maybe loading it is a mistake. What we should do is maybe preload it? and the lazy component will mount the css when it loads, and the preload should make sure its immediately there.. i think this makes sense but not sure, could use some html css loading expertise here @ryansolid

Yupp, this suggestion basically replaces one tradeoff with a different one ☺.
I also pinged you in the Solid Discord Suggestions section. There I conceptualized a different solution which would involve changes in multiple fronts (vite plugin/babel, dom-expressions, vinxi), but would result in a very precise css preload even for the lazy loaded modules.
https://discord.com/channels/722131463138705510/1222299712850231356

This bug is quite disruptive for us, and the workaround to use cssCodeSplit does not work with solid-start https://github.com/solidjs/solid-start/issues/1324.
The code above works very well, but it effectively pre-loads all dynamic imports, the following code only pre-loads the css portion of dynamic imports.
...(dynamicImports?.flatMap(traverse).filter(i => i.endsWith(".css")) || []),


Device 1 is not a termcap terminal device

What did you expect to happen?
I wanted to call M-X in order to select a capture template.  My org-capture settings:
(after! org-capture
    (setq org-capture-templates
          '(("t" "Todo" entry (file+headline "~/work/sync/org/inbox.org" "Tasks")
             "* TODO  %?\n")

            ("m" "Meeting" entry (file+headline "~/work/sync/org/inbox.org" "Meetings")
             "* MEETING  %?\nSCHEDULED: %t\n%U\n%a\n")

            ("b" "Bookmark (Clipboard)" entry (file+headline "~/work/sync/org/bookmarks.org" "Bookmarks")
             "** %(org-web-tools-insert-link-for-clipboard-url)\n:PROPERTIES:\n:TIMESTAMP: %t\n:END:\n%?"  :prepend t)

            ("s" "Code Snippet" entry
             (file+headline "~/work/sync/org/inbox.org" "Snippets")
             "* %?\t%^g\n#+BEGIN_SRC %^{language}\n\n#+END_SRC")

            ("j" "Journal" entry (file+olp+datetree "~/work/sync/org/journal.org")
             "*  %?\n")))
)

What actually happened?
When I try to select t for TODO I get:
Device 1 is not a termcap terminal device

Additional details:

Steps to reproduce:

M-X
Select t

System information:
https://pastebin.com/rBGF71mP

Your steps to reproduce are incomplete. I assumed you mean M-x org-todo then t.
In which case, I cannot reproduce this. I suspect this is a private config issue. Please try to reproduce the issue in the sandbox without your private config. I will reopen this once I have more leads to investigate it.

Sorry, I've meant SPC X then I see Select a capture template and select t. But after restarting emacs, the problem is gone. I'll try to provide steps you can also reproduce.


Typo ALT+ → ALT+<single letter>

https://docs.microsoft.com/en-us/sql/ssms/customize-menus-and-shortcut-keys?view=sql-server-2017

@hyoshioka0128 : Thanks for your contribution! The author, @stevestein, has been notified to review your proposed change.

Verified the update.
@hyoshioka0128 Thanks!


Fix block_size picking in megatron_lm_gpt_pretraining example.

What does this PR do?
If no block_size is explicitly passed, and the tokenizer happens to have a model_max_length of less than 1024, the current example will produce a bad block_size. With this change, we only cap block_size to 1024 if tokenizer.model_max_length is actually greater than 1024.
Who can review?
Tagging @pacman100 / @sgugger as the authors of the surrounding code.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Sanitize Site Names

What happened:
I created a site with sitename with a suspected invalid character. When I attempted to take the site through the workflow, the site spin-up failed with an Exit code 1.
What you expected to happen:
I expected the site to come up all the way.
How to reproduce it (as minimally and precisely as possible):
Create a folder with an invalid site name and use it as the default site name or just run ddev config and try plugging in a site name with invalid characterts.
Anything else do we need to know:
People might have folder names that we have to sanitize (e.g. they interact with their folders through Finder and use invalid characters in the folder name. In general, the sitename input should be sanitized.
Related source links or issues:
Console Output
➜  src mkdir invalid-drud-site\?
➜  src cd invalid-drud-site\?
➜  invalid-drud-site? cp -R ../drud-d7/docroot .
➜  invalid-drud-site? ddev config
Creating a new ddev project config in the current directory (/Users/csterling/src/invalid-drud-site?)
Once completed, your configuration will be written to /Users/csterling/src/invalid-drud-site?/.ddev/config.yaml

Project name (invalid-drud-site?):

The docroot is the directory from which your site is served. This is a relative path from your application root (/Users/csterling/src/invalid-drud-site?)
You may leave this value blank if your site files are in the application root
Docroot Location: docroot
Found a drupal7 codebase at /Users/csterling/src/invalid-drud-site?/docroot
➜  invalid-drud-site? ddev start
Starting environment for invalid-drud-site?...

Adding hostfile entry. You will be prompted for your password.
Password:
Failed to start invalid-drud-site?: exit status 1

Mostly we should be able to handle the vast majority of characters, anything that's utf-8. Except what's not allowed in a domain name right?
It looks like the old ascii rules are in http://www.ietf.org/rfc/rfc1034.txt
And the new IDNA rules are in https://en.wikipedia.org/wiki/Internationalized_domain_name
So we probably just have to choose a strategy and then normalize for it. IMO forcing ascii would be OK.

Looks like we're proceeding on this. Removing the "needs decision" blocker and adding flags for tests. Not sure documentation is necessary if we end up prompting the user that we only support alphanumeric + dash character as input!

This tripped me up. I was reviewing https://github.com/drud/ddev/pull/712/files#diff-0c9a20c1c50fca454d4715bf175e38bdR135 and I tried to pass in the project name "test^☃site" (because honestly, who doesn't want to have a snowman domain name). It broke when running ddev start. Perhaps a regression from here? https://github.com/drud/ddev/pull/339

Updated the milestone to reflect when this was officially released.

We need to solve this bug. It trips people from time to time.


a IDE warnning, can ignore

at line 840, it report a warning ,Function name must be callable. may be because $json_decoder has initialize null in line 43,thx

Hi. Which IDE are you using?


Refactor connect_lazy to return Channel directly

Fixes #708
Motivation
Most of the object creation and error validation is already done in Endpoint::new and as such Endpoint::connect_lazy should not be returning any errors since the connection is evaluated on-demand and cannot fail when building a channel. Meanwhile the API gives the wrong impression that the call may fail (does it ping the service beforehand? who knows)
Solution
Use Channel directly instead of wrapping it in Ok(Channel)

Thanks! :)


feat: allow using image name as well as marketplace image

This change is

Does README need to be updated since new input parameter was added?


Failed to restore a snapshot from different deployment

Hi,
I tried to restore a Snapshot from a different deployment but it failed with this error :
Error: failed tracking update progress: 1 error occurred:

	* found deployment plan errors: deployment [b96c9e4507b53592c5e699c97f11dbd9] - [elasticsearch][ca301491281d4359a3efe6151e4688a4]: caught error: "plan failed due to unknown error"

This is my Terraform code :
resource "ec_deployment" "deployment" {
  name                   = "es-deployment"
  region                 = var.region
  version                = "7.10.2"
  deployment_template_id = "aws-io-optimized"

  traffic_filter = [
    ec_deployment_traffic_filter.authorized_ip.id,
    ec_deployment_traffic_filter.vpce_dev.id,
    ec_deployment_traffic_filter.vpce_prd.id
  ]

  elasticsearch {
    topology {
      size                      = "15g"
      size_resource             = "memory"
      zone_count                = 2
      instance_configuration_id = "aws.data.highio.i3"
      node_type_data            = "true"
      node_type_ingest          = "true"
      node_type_master          = "true"
      node_type_ml              = "false"
    }

    snapshot_source {
      source_elasticsearch_cluster_id = "<id-es-cluster>"
      snapshot_name                   = "<snapshot-name>"
    }
  }

  kibana {
    topology {
      instance_configuration_id = "aws.kibana.r4"
      size                      = "1g"
      size_resource             = "memory"
      zone_count                = 1
    }

  }
}

I'm using Terraform v0.14.4 and elastic provider elastic/ec v 0.1.0-beta
I tried to restore manually the same snapshot from the Elastic console and it works as expected.
So it looks like a bug in the provider.
Thank you.

hi @hdryx,
thanks for opening this bug report, the source_elasticsearch_cluster_id requires you to set the source Elasticsearch resource_id, this is not the Deployment ID but the resource_id for the Elasticsearch cluster which is generally different from the Deployment id, see our documentation.
Could you confirm that is the case?

Hi,
I confirm that i used the ID of the Elasticsearch_cluster and not the ID of the deployment.
Thanks.

Thanks I'll add it to the backlog to investigate.

hi @hdryx,
I haven't been able to reproduce the failure that you're seeing, in fact, I was able to create a deployment and restore a snapshot from a different deployment, It took a while but it did succeeded:
$ terraform apply
ec_deployment.example_minimal: Refreshing state... [id=78fd2ee921684fa51f84e890a092d2f4]

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # ec_deployment.second will be created
  + resource "ec_deployment" "second" {
      + alias                  = (known after apply)
      + apm_secret_token       = (sensitive value)
      + deployment_template_id = "aws-io-optimized-v2"
      + elasticsearch_password = (sensitive value)
      + elasticsearch_username = (known after apply)
      + id                     = (known after apply)
      + name                   = "second"
      + region                 = "us-east-1"
      + version                = "7.12.1"

      + elasticsearch {
          + autoscale      = (known after apply)
          + cloud_id       = (known after apply)
          + http_endpoint  = (known after apply)
          + https_endpoint = (known after apply)
          + ref_id         = "main-elasticsearch"
          + region         = (known after apply)
          + resource_id    = (known after apply)

          + snapshot_source {
              + snapshot_name                   = "__latest_success__"
              + source_elasticsearch_cluster_id = "91f4d594f97c43b3b36f56a1fedf594b"
            }

          + topology {
              + id                        = (known after apply)
              + instance_configuration_id = (known after apply)
              + node_roles                = (known after apply)
              + node_type_data            = (known after apply)
              + node_type_ingest          = (known after apply)
              + node_type_master          = (known after apply)
              + node_type_ml              = (known after apply)
              + size                      = (known after apply)
              + size_resource             = (known after apply)
              + zone_count                = (known after apply)

              + autoscaling {
                  + max_size             = (known after apply)
                  + max_size_resource    = (known after apply)
                  + min_size             = (known after apply)
                  + min_size_resource    = (known after apply)
                  + policy_override_json = (known after apply)
                }
            }
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

ec_deployment.second: Creating...
ec_deployment.second: Still creating... [10s elapsed]
[..]
ec_deployment.second: Still creating... [13m40s elapsed]
ec_deployment.second: Creation complete after 13m42s [id=5c12d78269da361f3bf8a31940922813]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

were the two deployments in the same region? It's one of the requirements for the snapshot restoration process to work successfully as documented in the registry.

I've just re-tried restoring a snapshot into an already created cluster and it actually failed because we weren't setting the restore strategy, once a deployment has been created the restore strategy should be not set to "full", so it seems we've got a bug.


Arrays/structs break when loading pandas df into duckdb

What happens?
When loading a pandas df with array columns into duckdb, it seems to transform them into strings.
The version of duckdb in use is 0.3.2. pip3 install duckdb==0.3.2
Duckdb's indexing has recently changed from a base of 0, to a base of 1. The examples below will be indexed incorrectly if you are using a more recent version of the module.
So an array [1234, 5678] will become -> "[1234, 5678]".
Array[0] will give you a value of ""
Array[1] will give you a value of [
Array[2] ... 1, etc.
It's a similar behaviour to this, where it's incorrectly transforming pandas objects into their corresponding duckdb variations.
To Reproduce
Duckdb -> Pandas -> Duckdb
import duckdb
import pandas as pd

con = duckdb.connect()

sql = """
CREATE TABLE testing AS (
    SELECT ['tom', NULL, 'robin'] as a,
    ['thomas', 'robyn'] as b
)
"""

con.execute(sql)
test = con.execute("select * from testing").fetch_df()
con.register("test_df", test)

sql = """
select
a, b,
a[0] as a_0,
a[1] as a_1,
b[0] as b_0,
b[1] as b_1
from test_df
"""

con.execute(sql).fetch_df()

|   | a                      | b                   | a_0 | a_1 | b_0 | b_1 |
|---|------------------------|---------------------|-----|-----|-----|-----|
| 0 | ['tom', None, 'robin'] | ['thomas', 'robyn'] | [   | '   | [   | '   |

Pandas -> DuckDB
import duckdb
import pandas as pd
import numpy as np

test = {
    "a": [1, 2, 3, 4, 5],
    "b": [np.array([1,2,3]), np.array([2]), np.array([3]), np.array([4,6]), np.array([5])],
    "c": [np.nan, np.nan, np.array([4,5,6]), np.nan, np.array([1,2,3])],
}

test_df = pd.DataFrame(test)

con = duckdb.connect()
con.register("test_df", test_df)

sql = """
select b, c,
b[0] as b_0, b[1] as b_1, b[2] as b_2,
c[0] as c_0, c[1] as c_1, c[2] as c_2
from test_df
"""

con.execute(sql).fetch_df()

Parquet -> DuckDB (works correctly!)
from pyspark.context import SparkContext
from pyspark.sql import SparkSession
import duckdb
sc = SparkContext.getOrCreate()
spark = SparkSession(sc)
from pyspark.sql import Row
data_list = [
    {"a": ['robin', 'john'], "b": ['robyn', 'james']},

        ]

df = spark.createDataFrame(Row(**x) for x in data_list)
df.createOrReplaceTempView("df")
df = df.repartition(1)
df.write.mode('overwrite').parquet("test_parquet/")

con = duckdb.connect()

sql = """
select
a, b,
a[0] as a_0, a[1] as a_1,
b[0] as b_0, b[1] as b_1,
from 'test_parquet/*.parquet';
"""

con.execute(sql).fetch_df()

|    | a                 | b                  |   a_0 | a_1   |   b_0 | b_1   |
|---:|:------------------|:-------------------|------:|:------|------:|:------|
|  0 | ['robin', 'john'] | ['robyn', 'james'] |   nan | robin |   nan | robyn |

Spark -> Pandas -> DuckDB.  (Does not work)
from pyspark.context import SparkContext
from pyspark.sql import SparkSession
sc = SparkContext.getOrCreate()
spark = SparkSession(sc)
from pyspark.sql import Row
data_list = [
    {"a": ['robin', 'john'], "b": ['robyn', 'james']},

        ]

df = spark.createDataFrame(Row(**x) for x in data_list)
df.createOrReplaceTempView("df")

df_as_pandas = df.toPandas()
con = duckdb.connect()
con.register("test_df", df_as_pandas)

sql = """
select
a, b,
a[0] as a_0, a[1] as a_1,
b[0] as b_0, b[1] as b_1,
from test_df;
"""

print(con.execute(sql).fetch_df().to_markdown())

|    | a                 | b                  | a_0   | a_1   | b_0   | b_1   |
|---:|:------------------|:-------------------|:------|:------|:------|:------|
|  0 | ['robin', 'john'] | ['robyn', 'james'] |       | [     |       | [     |

Parquet -> Arrow -> Duckdb (works as intended!)
import duckdb
import pyarrow.parquet as pq

con = duckdb.connect()
sql = """
COPY (
    SELECT ['tom', NULL, 'robin'] as a,
    ['thomas', 'robyn'] as b
) TO 'test.parquet'
"""
con.execute(sql)

f = "test.parquet"
test_arrow = pq.read_table(f)

sql = """
select
a, b,
a[0] as a_0,
a[1] as a_1,
b[0] as b_0,
b[1] as b_1
from test_arrow
"""
con.execute(sql).fetch_df()

|   | a                      | b                   | a_0 | a_1 | b_0    | b_1   |
|---|------------------------|---------------------|-----|-----|--------|-------|
| 0 | ['tom', None, 'robin'] | ['thomas', 'robyn'] | tom |     | thomas | robyn |

Duckdb -> Pandas -> Arrow -> Duckdb (also works!)
import duckdb
import pandas as pd
import pyarrow as pa

con = duckdb.connect()

sql = """
CREATE TABLE testing AS (
    SELECT ['tom', NULL, 'robin'] as a,
    ['thomas', 'robyn'] as b
)
"""

con.execute(sql)
test = con.execute("select * from testing").fetch_df()
test_arrow = pa.Table.from_pandas(test)

sql = """
select
a, b,
a[0] as a_0,
a[1] as a_1,
b[0] as b_0,
b[1] as b_1
from test_arrow
"""
con.execute(sql).fetch_df()

|   | a                      | b                   | a_0 | a_1 | b_0    | b_1   |
|---|------------------------|---------------------|-----|-----|--------|-------|
| 0 | ['tom', None, 'robin'] | ['thomas', 'robyn'] | tom |     | thomas | robyn |

OS:
iOS
Splink version:
3.0.1
Have you tried this on the latest master branch?

[X] I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

[X] I agree

I think this might be working with duckdb 0.5.1 @ThomasHepworth ?

This works with newer versions of pandas/spark/duckdb.  If anyone still has this issue they should upgrade their dependencies.  Closing


Azure AD redirects to signin page

Seems like the new developer portal is redirecting back to /signin page instead of /signin-aad which is causing authentication to fail. Is this a known issue?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 692852cd-11a6-1d6b-9540-caec9d0f14a4
Version Independent ID: 4c376561-6015-6dab-e23e-feffe74ccc8b
Content: Authorize developer accounts by using Azure Active Directory - Azure API Management
Content Source: articles/api-management/api-management-howto-aad.md
Service: api-management
GitHub Login: @miaojiang
Microsoft Alias: apimpm

@bureus Thank you for your feedback! We will review and get back to you with our findings.

@mike-urnun-msft: thanks a lot, i have tried this in two different instances of APIM in Standard tier and its consistent between both. Some more findings, seems like the redirect URL towards Azure Ad is set to /signin during the code credential flow. So it seems not to be related to that we have enabled the setting to force redirect anonymous users to the sign in page either, which i also tried to disable.

Yep, I'm seeing this as well, the redirect URL provided to the flow appears to be to signin rather signinaad.
The redirect URL value provided in the identity provider settings in the portal is also using the legacy URL of https://apimanagement.portal.azure-api.net/signin-aad rather than the new URL of https://apimanagement.developer.azure-api.net/signin-aad so following this guide leads to the wrong redirect URL being used in the AAD application.

@mike-urnun-mstf: Any news :)

I'm also having same issue. Every time when I login it redirects me to login page again. Please update if there is any quick fix for the same. This is very critical for the client delivery. Please help get quick resolution.

I believe this is because after AAD signin the page authentication token is provided to /subscriptions/xxx/resourceGroups/xxx/providers/Microsoft.ApiManagement/service/xxx/identity?api-version=2018-06-01-preview where "xxx" is the actual value in the URL and the the correct IDs are not being substituted. I think this may also be the legacy version of the API that is being included.

Same here.
Any news ?

Hi. tried to follow this documentation today. There's an issue with the redirect URIs. You will need to configure both (new and legacy) in the app registration. The AAD consent page is also only available through the legacy portal.

Hi everyone, will update with my findings soon.

@bureus @ehrnst @nbarrasson @mattosaurus I've tried reproducing this but didn't run into any issues. It looks like this was resolved of as part of: Azure/api-management-developer-portal#299
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


animation jumps on Mozilla Firefox

I just changed this, works now
.c100:hover > span {
/* width: 3.33em;
line-height: 3.33em;
font-size: 0.3em; */
color: #307bbb;
transform: scale(1.4);
}


fix(more resources): fix porting and functionality [r8s-103]

Fixes r8s-103

Closed in favour of https://github.com/portainer/portainer-suite/pull/8

Closed in favour of https://github.com/portainer/portainer-suite/pull/8


Only mmap files on local, non-removable filesystems

Experiments with mmaping found that it is slower (about 2x) than just reading the contents using read()/pread() with a reasonable buffer (128kB or more). To that effect I'd rather remove the mmap path altogether.


HDDS-10384. RPC client Reusing thread resources.

What changes were proposed in this pull request?
The old PR https://github.com/apache/ozone/pull/6270 has been reverted due to a bug. This PR fixed the bug and recreated the PR.
root cause
The root cause of the bug in the old PR is that the future put into the executePutBlock of CommitWatcher#futureMap may be overwritten by the last closed executePutBlock. Therefore, the buffer cannot be released correctly.
Fix
Change the CommitWatcher#futureMap from ConcurrentMap<Long, CompletableFuture<xxx>>       to ConcurrentMap<Long, List<CompletableFuture<xxx>>>  Records and releases all futures with the same key, so all the future can be released.
A detail log about this bug：
2024-03-03 18:49:16,741 [Thread-955] ERROR storage.BlockOutputStream (BlockOutputStream.java:executePutBlock(512)) - executePutBlock putFlushFuture flushPos 4194304, flushFuture java.util.concurrent.CompletableFuture@8bc6bca[Not completed], close false, force false
2024-03-03 18:49:16,741 [Thread-955] ERROR storage.BlockOutputStream (RatisBlockOutputStream.java:putFlushFuture(120)) - putFlushFuture flushPos 4194304 flushFuture java.util.concurrent.CompletableFuture@8bc6bca[Not completed]

In the next log， we can see the entry {4194304, CompletableFuture@8bc6bca} has been overwritten by the {4194304, CompletableFuture@4230f10c}

2024-03-03 18:49:16,741 [Thread-955] ERROR storage.BlockOutputStream (BlockOutputStream.java:executePutBlock(512)) - executePutBlock putFlushFuture flushPos 4194304, flushFuture java.util.concurrent.CompletableFuture@4230f10c[Not completed], close true, force true
2024-03-03 18:49:16,741 [Thread-955] ERROR storage.BlockOutputStream (RatisBlockOutputStream.java:putFlushFuture(120)) - putFlushFuture flushPos 4194304 flushFuture java.util.concurrent.CompletableFuture@4230f10c[Not completed]
2024-03-03 18:49:16,741 [Thread-955] ERROR storage.BlockOutputStream (RatisBlockOutputStream.java:waitOnFlushFutures(127)) - waitOnFlushFutures getFutureMap keySet [4194304] keySet Value [java.util.concurrent.CompletableFuture@4230f10c[Not completed]]

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10384
How was this patch tested?
Twice 10x10  tests for TestSecureOzoneRpcClient,TestFreonWithPipelineDestroy,TestOzoneRpcClientWithRatis#ALL all passed. （In order to make all tests pass, this test code includes a fix for the unstable test testParallelDeleteBucketAndCreateKey HDDS-10143）
https://github.com/xichen01/ozone/actions/runs/8138828724/attempts/1
https://github.com/xichen01/ozone/actions/runs/8138828724

@szetszwo could you please take a look?

@xichen01 , thanks for digging out the root cause!

... the future put into the executePutBlock of CommitWatcher#futureMap may be overwritten by the last closed executePutBlock. ...

Is this an existing bug?  It seems the previous PR does not cause the bug.

... Change the CommitWatcher#futureMap ...

Let's don't change it.  We may chain the futures as below:
+++ b/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/RatisBlockOutputStream.java
@@ -115,7 +115,9 @@ void updateCommitInfo(XceiverClientReply reply, List<ChunkBuffer> buffers) {
   @Override
   void putFlushFuture(long flushPos,
       CompletableFuture<ContainerCommandResponseProto> flushFuture) {
-    commitWatcher.getFutureMap().put(flushPos, flushFuture);
+    commitWatcher.getFutureMap().compute(flushPos,
+        (key, previous) -> previous == null? flushFuture
+            : previous.thenCombine(flushFuture, (prev, curr) -> curr));
   }

Thanks @xichen01 for continuing work on this, @szetszwo for the review.


No "unique_id" in the child table

Thank you for the great work!
I am trying the tool on the Airbnb dataset and I managed to generate both parent_samples and child_samples.
However, I noticed that user_id only exist in parent_samples while it's missing in child_samples. Is there a way then to identify for each row in child_samples, which user_id it belongs to?

Sorry for the confusion. Just forgot to export the index while saving as csv files.


Assign free port for metrics when in standalone mode

Once the metrics PR has been merged, we need to add behaviour to set the metrics port dynamically when running in standalone mode similar to how the HTTP and gRPC ports are handled: https://github.com/dapr/cli/blob/359e2eb8e36f7a5446af1a4569c94ddf2c30764b/pkg/standalone/run.go#L79
I think this is preferable to disabling the metrics as people can do that using --enable-metrics false easily enough and there will be scenarios where people want to use metrics for standalone deployments (even just for development purposes).

See my PR. It solves it by simply using a random port.


Remove all v1client code

Delete all contents from class YubicoClient, and make it final with a private constructor. This will make all attempts to use it fail at compile time instead of runtime.
The idea is to make release 3.0.4 with this breaking change - intentionally violating semver to make downstream builds break - and then delete the v1client subproject completely so that 3.0.4 will be the final release of v1client.

LGTM! Thanks.


Ideas/ToDo - More data types as parameters, return value, and inside struct

I'd like to see the following things get implemented. I can help if I get some guidance.
Data Types (highest priority top to bottom):

byte

float

int

long

short

byte array

float array

int array

long array

short array

Struct data types:
Struct Arrays
It would be great to have arrays inside structs as well.

The latest version of struct supports double, i32array, doubleArray, stringArray, please refer to the latest readme for more details. retTypeLen is deprecated in the latest version, and arrayConstructor is added to specify the legal length of the returned array.

the correct d.ts type will be refined in the next release

Great. Thanks.

support long type aka i64 in 1.0.32

Great. Thanks.

support byte, byteArray aka u8, u8Array in 1.0.33

Is there any plan to add DataType.ExternalArray for array of pointer? @zhangyuang


Add Tuya single button switch  TS004F _TZ3000_ja5osu5g

Existing signature before quirk:
{
  "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4742, maximum_buffer_size=66, maximum_incoming_transfer_size=66, server_mask=10752, maximum_outgoing_transfer_size=66, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)",
  "endpoints": {
    "1": {
      "profile_id": "0x0104",
      "device_type": "0x0000",
      "input_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0x0004",
        "0x0006",
        "0x1000",
        "0xe001"
      ],
      "output_clusters": [
        "0x0003",
        "0x0004",
        "0x0006",
        "0x0008",
        "0x000a",
        "0x0019",
        "0x1000"
      ]
    }
  },
  "manufacturer": "_TZ3000_ja5osu5g",
  "model": "TS004F",
  "class": "zigpy.device.Device"
}

Signature after quirk:
{
  "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4742, maximum_buffer_size=66, maximum_incoming_transfer_size=66, server_mask=10752, maximum_outgoing_transfer_size=66, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)",
  "endpoints": {
    "1": {
      "profile_id": "0x0104",
      "device_type": "0x0820",
      "input_clusters": [
        "0x0000",
        "0x0001",
        "0x0003",
        "0x0004",
        "0x1000",
        "0xe001"
      ],
      "output_clusters": [
        "0x0003",
        "0x0004",
        "0x0006",
        "0x0008",
        "0x000a",
        "0x0019",
        "0x0300",
        "0x1000"
      ]
    }
  },
  "manufacturer": "_TZ3000_ja5osu5g",
  "model": "TS004F",
  "class": "ts004f.TuyaSmartRemote004FSK_v2"
}

Tested in HA, and HA correctly receives button presses now:

Fixes https://github.com/zigpy/zha-device-handlers/discussions/2212
Checklist

[x] The changes are tested and work correctly
[ ] pre-commit checks pass / the code has been formatted using Black
[ ] Tests have been added to verify that the new code works

Great you was getting it working and doing on PR !!!
Interesting is if the first version is working for the same "manufacturer" was working or if tuya have doing one new firmware version with the (crazy) change.
Naming of the class naming and reusing the old class DA is up to the maintainers but for me its looks OK !!

PS: add in the first post for linking the issue:
Fixes https://github.com/zigpy/zha-device-handlers/issues/2212

Thanks for the PR! There are some minor changes that could be made to clean this up slightly.

Thanks - I had no idea exactly what I was doing with this, just what I managed to get working... I was hoping that someone with more of a clue could optimise it :)
I think I've done what you've asked properly - if you could please give it your eyeballs again and confirm.

Not sure if it's a quirk implementation issue, but the TS004F by _TZ3000_ja5osu5g (Single Button) seems to have issues interpreting data.
Behaviour : Button keeps switching back to "on" by itself after a while.
Although the commands are pretty straight forward for toggle, on and off:
[zigpy.zcl] [0xA502:1:0x0006] Decoded ZCL frame: OnOff:toggle()
[zigpy.zcl] [0xA502:1:0x0006] Received command 0x02 (TSN 90): toggle()

[zigpy.zcl] [0x5CAF:1:0x0006] Received ZCL frame: b'\x11\xcd\x01'
[zigpy.zcl] [0x5CAF:1:0x0006] Decoded ZCL frame: OnOff:on()
[zigpy.zcl] [0x5CAF:1:0x0006] Received command 0x01 (TSN 205): on()

[zigpy.zcl] [0xF0EA:1:0x0006] Received ZCL frame: b'\x11\x1f\x00'
[zigpy.zcl] [0xF0EA:1:0x0006] Decoded ZCL frame: OnOff:off()
[zigpy.zcl] [0xF0EA:1:0x0006] Received command 0x00 (TSN 31): off()

the switch would trigger back on by itself upon receiving this one (note Bool.true:1) with no user interaction:
[zigpy.zcl] [0x4D62:1:0x0006] Received ZCL frame: b'\x18!\n\x00\x00\x10\x01'
[zigpy.zcl] [0x4D62:1:0x0006] Decoded ZCL frame header: ZCLHeader(frame_control=FrameControl<0x18>(frame_type=<FrameType.GLOBAL_COMMAND: 0>, is_manufacturer_specific=0, direction=<Direction.Server_to_Client: 1>, disable_default_response=1, reserved=0, *is_cluster=False, *is_general=True), tsn=33, command_id=10, *direction=<Direction.Server_to_Client: 1>)
[zigpy.zcl] [0x4D62:1:0x0006] Decoded ZCL frame: OnOff:Report_Attributes(attribute_reports=[Attribute(attrid=0x0000, value=TypeValue(type=Bool, value=<Bool.true: 1>))])
[zigpy.zcl] [0x4D62:1:0x0006] Received command 0x0A (TSN 33): Report_Attributes(attribute_reports=[Attribute(attrid=0x0000, value=TypeValue(type=Bool, value=<Bool.true: 1>))])
[zigpy.zcl] [0x4D62:1:0x0006] Attribute report received: on_off=<Bool.true: 1>

Not sure if it's a quirk implementation issue, but the TS004F by _TZ3000_ja5osu5g (Single Button) seems to have issues interpreting data. Behaviour : Button keeps switching back to "on" by itself after a while.
Although the commands are pretty straight forward for toggle, on and off:

If you hold the button down for ~3-4 seconds, it should change modes and work properly.

@AnalogThinker Pleas post the diagnostic from the device card so can see with quirk (if) its using.

Sure thing.
I have pulled 2 diags :

The first one (ending in e81.json) is the default diag, indeed detected as ON_OFF_SWITCH, with the odd "StartUpBehaviour" feature that does not change the issue however it's set
The second one (ending in 0df.json) is the diag after manually applying a quirk as the py code as suggested in issue 3108, which disabled the button entirely, although being connected.

zha-12430ffcfde958073c7ce7432ab1fb85-_TZ3000_ja5osu5g TS004F-435e26c054c689c5cb33ed9d52615e81.json
zha-12430ffcfde958073c7ce7432ab1fb85-_TZ3000_ja5osu5g TS004F-f11e5bfb65847fab16d313da482cb0df.json

The second one shall working "normal" then its have loading the the quirk for on switch.
The first one have: "quirk_class": "zigpy.device.Device", so light commands shall working but "tuya scene" commands not util you is getting on working quirk loaded for it.

Please add also _TZ3000_egvb1p2g model, added model as mentioned in https://github.com/zigpy/zha-device-handlers/discussions/2212#discussioncomment-9431055 works great.
Existing signature before quirk:
   "ieee": "**REDACTED**",     "nwk": 7408,     "manufacturer": "_TZ3000_egvb1p2g",     "model": "TS004F",     "name": "_TZ3000_egvb1p2g TS004F",     "quirk_applied": false,     "quirk_class": "zigpy.device.Device",     "quirk_id": null,     "manufacturer_code": 4742,     "power_source": "Battery or Unknown",     "lqi": 120,     "rssi": -70,     "last_seen": "2024-07-02T20:26:23",     "available": true,     "device_type": "EndDevice",     "signature": {       "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4742, maximum_buffer_size=66, maximum_incoming_transfer_size=66, server_mask=10752, maximum_outgoing_transfer_size=66, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)",       "endpoints": {         "1": {           "profile_id": "0x0104",           "device_type": "0x0000",           "input_clusters": [             "0x0000",             "0x0001",             "0x0003",             "0x0004",             "0x0006",             "0x1000",             "0xe001"           ],           "output_clusters": [             "0x0003",             "0x0004",             "0x0006",             "0x0008",             "0x000a",             "0x0019",             "0x1000"           ]         }       },       "manufacturer": "_TZ3000_egvb1p2g",       "model": "TS004F"     }


UTC in the JwtBearer

When validating the JWT with ValidateLifetime = true in TokenValidationParameters it won't work if the timestamps (iat, exp, nbf) in the JWT is based on UTC (var now = DateTimeOffset.UtcNow;) but it will work if the timestamps  is based on the servers time (var now = DateTimeOffset.Now;) since both my issuer and consumer runs on the same machine.
This code is working but the validation fails when I change .Now to .UtcNow (see above):
      var now = DateTimeOffset.Now; // Should be UtcNow, see https://tools.ietf.org/html/rfc7519

      var claims = new List<Claim>
      {
        new Claim(JwtRegisteredClaimNames.Jti, Guid.NewGuid().ToString()),
        new Claim(JwtRegisteredClaimNames.Iat, now.ToUnixTimeSeconds().ToString(), ClaimValueTypes.Integer64)
      };

      // Create the JWT
      var jwt = new JwtSecurityToken(
        issuer: _settings.Issuer,
        audience: _settings.Audience,
        claims: claims,
        notBefore: now.DateTime,
        expires: now.DateTime.Add(_settings.Expiration),
        signingCredentials: _settings.SigningCredentials
      );

      var encodedJwt = new JwtSecurityTokenHandler().WriteToken(jwt);

      return new
      {
        accessToken = encodedJwt,
        expiresIn = (int)_settings.Expiration.TotalSeconds
      };

JwtSecurityToken and related components are over here: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet

Is JwtBearer just using JwtSecurityToken for the validation?

@brentschmaltz can you take a look and see if we need to move this bug to another repo?

Ping @brentschmaltz .

Validation is preformed by JwtSecurityTokenHandler.ValidateToken
https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/master/src/System.IdentityModel.Tokens.Jwt/JwtSecurityTokenHandler.cs#L735

Closing because there doesn't seem to be any further action required here. If there are further issues with this, please open a new issue in https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet. Thanks!


ide-helper:models Makes no effect

Laravel version: 5.8.38
PHP 7.3.15
When I try to use this command, I have no annotations added to the class. If I choose not to write to the class — it creates empty _ide_helper_models.php:
<?php

// @formatter:off
/**
 * A helper file for your Eloquent Models
 * Copy the phpDocs from this file to the correct Model,
 * And remove them from this file, to prevent double declarations.
 *
 * @author Barry vd. Heuvel<EMAIL_ADDRESS> */

What's the worst: No errors/warnings/ in logs. No messages of any kind even with -vvv tag.
Models location seems to be correct, in the config file:
    // config/ide-helper.php

    'model_locations' => array(
        'app',
    ),

This is what I see in the console:

Which version of ide-helper? :)

Is the database connection working correctly? This is required for this command
There are some exception catch parts which swallow it 😬, maybe one of them was triggered. Can you add some debug statement to them?

IDE Helper version : * v2.7.0

Is the database connection working correctly? This is required for this command

DB connection is alright in tinker and/or artisan commands. Not sure how to check it specifically for ide-helper.

Where is your model(s) exactly located?
Please paste the code of a model which does not work (remove/replace sensitive information).

Same. it doesn't work when I do php artisan ide-helper:models User

@mfn
Models are all located in app/ directory. One model example:
<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
use App\Traits\HasSubdomainScope;

class CustomField extends Model
{
    use HasSubdomainScope;

    public $timestamps = false;

    protected $guarded = [];

    public function scopeTypeLead($query)
    {
        return $query->where('element_type', 'lead');
    }
    public function scopeTypeContact($query)
    {
        return $query->where('element_type', 'contact');
    }
    public function scopeTypeCompany($query)
    {
        return $query->where('element_type', 'company');
    }

    public function getHtmlAttribute()
    {
        switch ($this->field_type) {
            case \Amo\CustomField::CF_TYPE_BIRTHDAY:
            case \Amo\CustomField::CF_TYPE_DATE:
                return date('d.m.y', strtotime($this->value));
            case \Amo\CustomField::CF_TYPE_CHECKBOX:
                return $this->value ? 'Да' : 'Нет';
            case \Amo\CustomField::CF_TYPE_MULTISELECT:
                return $this->subdomain($this->subdomain)
                    ->where('element_type', $this->element_type)
                    ->where('element_id', $this->element_id)
                    ->where('field_id', $this->field_id)
                    ->pluck('value')->implode(', ');
            default:
                return $this->value;
        }
    }

    public function getFieldTypeAttribute()
    {
        if ($this->element_type === 'contact') {
            return (int)amo($this->subdomain)->getContactCustomFieldById($this->field_id)['type_id'];
        }

        return (int)amo($this->subdomain)->getLeadCustomFieldById($this->field_id)['type_id'];
    }
}

Nothing stands out to me; also since you said all models are affected, i.e basically none works…
Two suggestions:

put up a public repo on github showing the problem
start debugging yourself
I would probably start looking what \Barryvdh\LaravelIdeHelper\Console\ModelsCommand::loadModels "finds" and take it from there.

does it discover the models?
in the main foreach loop starting at https://github.com/barryvdh/laravel-ide-helper/blob/f3d841c0a30645a8bbf908e89ab31acf0053ad93/src/Console/ModelsCommand.php#L209 there are some conditions skipping the model; is any of them triggered?

I was having a similar issue to this.  Running php artisan ide-helper:models generated the correct _ide_helper_models.php file with content, but running php artisan ide-helper:models \App\Development (where Development is my Model) resulted in an empty file, as described above.
  Presumably the namespace separators are being interpreted by the shell as escape characters and causing the model not to be found.
Anyway, with the quotes it works.

At some point, this doesn't work again.


DEMO

It would be so useful if we can test the tracker with our own video. Can you please share the demo script if existed ?

Thanks for your advice. Currently, I'm not available to extend and test this function. However, you can refer to pytracking/run_video.py in PyTracking or tracking/video_demo.py in STARK. I think it can be smoothly integrated since the organization of our project is similar to their code.

Thanks for your reply. Actually I worked on pytracking recently I will try your suggestion if I can make it work I will share the results.

@MUHAMMEDZEYN I want demo my video with aiatrack as you said. have you found a way ?


Hook to modify shortcuts created by WSLg

Is your feature request related to a problem? Please describe.
My specific problem/use-case is related to my use of genie (https://github.com/arkane-systems/genie) to run Linux services under systemd, and in particular, using GUI applications which either must themselves run thus or depend on services therein. At the moment, this works perfectly launching them from my usual shell, but not from the Start Menu shortcuts.
That said, I think there is also a general issue here in which people may wish to modify the way in which the created shortcuts run their GUI applications to set the environment/profile/etc, per - for example - #46 , #11, etc.
Describe the solution you'd like
Ideally, I would like to be able to configure a template for the shortcuts created by WSLg, so that I could transform - for instance - the automatically created target
C:\Windows\System32\wslg.exe ~ -d Debian gnome-system-monitor

to
C:\Windows\System32\wslg.exe ~ -d Debian genie -c gnome-system-monitor

or to
C:\Windows\System32\wslg.exe ~ -d Debian my-gui-profile ; gnome-system-monitor

etc., which is to say, effectively modify the Linux command line in between the .desktop file and the Windows shortcut to include the extra behavior wanted.
Describe alternatives you've considered
The obvious way to solve this without any WSLg changes would be to simply modify the Exec= line in all the relevant .desktop files to include the extra part, but that involves a lot of individual file mods that will be overwritten by package updates, inelegant even if automated, and would also affect any other application that makes use of the .desktop files. Solving this in one place would be much more elegant.

That's a great suggestion, we'll look at adding a mechanism for this. We're looking into the problem of the profile not being applied when launching an application from the start menu, we realize this is annoying especially for folks using framework based DPI scaling... but having the ability to further customize the launch string with some preamble is a great suggestion.

This will come in handy running MS edge on Wayland e.g C:\Windows\System32\wslg.exe ~ -d Ubuntu microsoft-edge --enable-features=UseOzonePlatform --ozone-platform=wayland


make small annotations easier to see

In some cases annotators will add some small noisy / erroneous annotations a bit randomly, they're currently quite difficult to see (which makes QC quite difficult), example:

has in fact 5 annotations, not 3, one is a tiny rectangle at the top, another is barely visible and is inside page 2.
Some possible fixes are:

showing (in small font) the number of annotations on each image (even checked), so that this kind of case is easier to detect (it will also improve things for #41)
making the colors a bit different maybe?
have a way to not display the thumbnails and instead just the annotations. I'm on a laggy Internet today so thumbnails don't load very fast, and I realize that not having the thumbnails is sometimes quite helpful, so maybe there could be a button "display annotations only" somewhere in the UI that could be toggled for the whole directory?

N.B.: we should also probably add a mechanism to ignore those in the post processing

or maybe we can add a warning in the UI (with the same warning UI as usual) for cases where there's a huge difference between the largest and the smallest annotations (like a factor of 100 in area), or when there are duplicate boxes

here's the same image without the thumbnails, easier to debug for that case:

added #annotations / expected as a first step: https://scamqc.bdrc.io/?folder=demo%2FW1KG8718-I1KG8739%2F

then there could be a warning when more than expected (which could not be bypassed by checking the image? wdyt?)
also yes there could be a different color for annotations "100x" smaller
(not sure where to put the "no thumbnail" option yet but I'll find a way!)

this is a great start, thanks a lot!

small annotations (with area < 100x the largest) get a warning:

warning now stays when image checked but too much annotations:

this is great, thanks a lot!

fixed keeping small annotation orange when image checked: https://scamqc.bdrc.io/?folder=demo%2FW1KG8718-I1KG8739%2F

added menu entry (in Filter images) to toggle thumbnail loading:

this is great, thanks a lot! One small thing: in rare cases some annotations are meant to be small like annotations that have a tag, is it possible to disable this feature for tagged annotations? Thanks!

done: https://scamqc.bdrc.io/?folder=demo%2FW1KG8718-I1KG8739%2F
(added a specific color for tagged annotations as well, and display separately in annotation count near image name)

This is perfect, thanks!


Parallelize removeReferencesToVendoredSources

Motivation
Closes #620 by using GNU parallel to remove references to vendored sources in multiple files at once.
Checklist

[ ] added tests to verify new behavior
[ ] added an example template or updated an existing one
[ ] updated docs/API.md (or general documentation) with changes
[X] updated CHANGELOG.md

It's worth noting that this change can make builds non-reproducible. In my case, the only non-reproducible bit is a list of JS files in the index.html. It's the same list, but the elements are in different orders.
Non-reproducibility can be really bad for some builds, so this change should probably be opt-in. That would mean the behavior of the hook should change based on something in mkCargoDerivation. What's the best way of doing that?

Why would it be non-repro? The end result should always be the same, no?

Oops, turns out this was just the project I was testing with. It seems like the non-reproducibility is because of the stdweb crate and nothing to do with this PR. I've since tested this PR with a different project and the result was reproducible both with and without this parallelism.

It seems like the non-reproducibility is because of the stdweb crate and nothing to do with this PR

You think you can follow through with them to address it? Would be great if Rust ecosystem was aware that byte-to-byte reproducibility is important to many people. :)

I'd love to, but stdweb has received no new commits in over 5 years, and all the PRs are totally inactive, so it's probably better for anyone using it to switch to something different.

Just chiming in to mention it's not just stdweb that has this issue with trunk builds: My assets/ dir containing some 100 font and png files gets included

Would it make sense to have some hook/filter attribute to disable for bulk stuff that people sometimes have and don't care if it has references, or it possibly can't and there's no point of tryint go fix it up?

Would it make sense to have some hook/filter attribute to disable for bulk stuff[...]?

Yes, I was hoping to find a setting for that! But running it in parallel would already be a huge improvement: I think a setting would be a good next step after parallelization lands.

Thanks again for the PR @DoctorDalek1963 ! I'm going to close this in favor of https://github.com/ipetkov/crane/pull/625 which is able to achieve a really good speedup here without needing to use parallel (more context can be found here: https://github.com/ipetkov/crane/issues/620#issuecomment-2131570054 )
I'm going to close this for now, but feel free to reopen if you think there are other improvements to be had!


How to ensure Leopard website remains up to date?

See #138 for a recent example of confusion because leopardjs.com is apparently running a version of Leopard/sb-edit from before 2021. I'm not familiar with the leopard-website codebase, and it doesn't appear to have any documentation—details on how to get it to "work" and for Leopard devs to keep the released site up to date would be appreciated!
Ideally I feel like it should be tied to NPM releases or something, right now it looks like it must take some manual intervention to update to the latest Leopard and sb-edit versions? Which apparently hasn't happened since before 2021 (see linked issue above), meaning any compatibility changes semi-recently introduced just aren't available to the general populace (including people testing recent Leopard additions).
/cc @PullJosh

I just redeployed the website manually. (Required clicking one button.) Previous deployment was 336 days ago. Hopefully the latest sb-edit version is being used now?

Receiving an error when redirecting to the Codesandbox.
{"error":"This endpoint requires the params `files` or `parameters` in order to work. See https://codesandbox.io/docs/importing#create-wizard for more details."}

Looks like no query params are being passed.  Running latest Chrome on Windows 11.

@micahlt That is not a new issue. It also happened previously. Try with a different project.


[Bug] Cancel Schema change job is useless in BE

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
1.2 or master also
What's Wrong?
When I have a long schema change job, I want to cancel it and create a new schema change job. It fails sometime.
Example:
I has a large table that has many columns. I choose column A to add bitmap index. But i regret it. I want to add bitmap index for column B. So I cancel the job, and create a new schema change job and then the job fails.
LOG:
W0206 17:32:49.308645 1579747 schema_change.cpp:1751] failed to obtain schema change lock. base_tablet=12198
W0206 17:32:49.354110 1579747 task_worker_pool.cpp:558] failed to alter tablet|signature=12450|base_tablet_id=12198|new_tablet_id=12450|error=Internal error(error -216):     @     0x55e5ed6fb0a4  doris::Status::ConstructErrorStatus()
@     0x55e5ed6fb565  doris::Status::OLAPInternalError()
@     0x55e5edb0821c  doris::SchemaChangeHandler::process_alter_tablet_v2()
@     0x55e5edf1df00  doris::EngineAlterTabletTask::execute()
@     0x55e5eda9c019  doris::StorageEngine::execute_task()
@     0x55e5edab9612  doris::TaskWorkerPool::_alter_tablet()
@     0x55e5edac6819  doris::TaskWorkerPool::_alter_tablet_worker_thread_callback()
@     0x55e5ee2a5805  doris::ThreadPool::dispatch_thread()
@     0x55e5ee29bbef  doris::Thread::supervise_thread()
@     0x7f6fa610b17a  start_thread
@     0x7f6fa641fdc3  __GI___clone
@              (nil)  (unknown)
The code in fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java:CancelImpl is about the cancel. And we can learn that the cancel just happens in FE. It will not cancel the workflow in BE and BE will do the cancel job until finish. It can make things weird. I cancel the job, but I fail to add new job.
What You Expected?
When input the cancel command, the schema change job will be canceled completely.
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Can you give a more detailed test case?
For example, create a table, create a bitmap index for column A, and the SQL script to cancel the bitmap index.

I think we can use the ssb case generated by tools dir (tools/ssb-tools).  Generate 100 gigabytes of data for the table lineorder and choose two columns to simulate the problem.

https://doris.apache.org/zh-CN/docs/dev/sql-manual/sql-reference/Data-Definition-Statements/Alter/ALTER-TABLE-BITMAP

plz assign it to me~ I will have a try.

plz, unassign me, sry for not completing it.

Let me have a try.


GUI Supports importing and exporting files in docker containers

Is your feature request related to a problem? Please describe.
Whenever I want to import and export files in a container it's a hassle
Describe the solution you'd like
Adding a GUI to the container makes it easy to import and export files
Describe alternatives you've considered
docker desktop gui makes it very easy to import and export files in containers
Additional context
Operations in docker desktop

Instead of creating another GUI, I suggest expose the container files inside the finder via "network sharing"

For now, I'd recommend using OrbStack's image file sharing (when it does the job and container access isn't truly necessary).

For now, I'd recommend using OrbStack's image file sharing (when it does the job and container access isn't truly necessary).

Thank you for your advice, but due to special reasons, I often need to import and export files from a running docker image. I need to give up using orbstack for the time being, but I still like using this product and hope it will develop better

Added for the next version!
https://twitter.com/kdrag0n/status/1730954219769770410

Released in v1.2.0.


Example?

I'm trying to fully grasp keycloak passport + passport + next auth.
Do you have an example of how to do this ?
Using your example, I get a authorizationURL is required.

example open-id config
{
"issuer": "http://localhost:8080/auth/realms/demo",
"authorization_endpoint": "http://localhost:8080/auth/realms/demo/protocol/openid-connect/auth",
"token_endpoint": "http://localhost:8080/auth/realms/demo/protocol/openid-connect/token",
"token_introspection_endpoint": "http://localhost:8080/auth/realms/demo/protocol/openid-connect/token/introspect",
"userinfo_endpoint": "http://localhost:8080/auth/realms/demo/protocol/openid-connect/userinfo",
"end_session_endpoint": "http://localhost:8080/auth/realms/demo/protocol/openid-connect/logout",
"jwks_uri": "http://localhost:8080/auth/realms/demo/protocol/openid-connect/certs",
"grant_types_supported": [
"authorization_code",
"implicit",
"refresh_token",
"password",
"client_credentials"
],
"response_types_supported": [
"code",
"none",
"id_token",
"token",
"id_token token",
"code id_token",
"code token",
"code id_token token"
],
"subject_types_supported": [
"public"
],
"id_token_signing_alg_values_supported": [
"RS256"
],
"response_modes_supported": [
"query",
"fragment",
"form_post"
],
"registration_endpoint": "http://localhost:8080/auth/realms/demo/clients-registrations/openid-connect"
}

Ditto anyway to get an example here. I have it half working based on browsing this README and passport's documentation


appdome-build-2secure-android 1.0.6

What to do if the build fails?
At the moment contributors do not have access to the CI workflow triggered by StepLib PRs. In case of a failed build, we ask for your patience. Maintainers of Bitrise Steplib will sort it out for you or inform you if any further action is needed.
New Pull Request Checklist
Please mark the points which you did / accept.

[ ] I will not move an already shared step version's tag to another commit
[ ] I read the Step Development Guideline
[ ] I have a test for my Step, which can be run with bitrise run test (in the step's repository)
[ ] I did run bitrise run audit-this-step (in the step's repository - note, if you don't have this workflow in your bitrise.yml, you can copy it from the step template.)
[ ] I read and accept the Abandoned Step policy

Hi @elish266 can you please update your branch with the latest steplib master?

Done.
Thanks.
On Sat, 13 May 2023 at 00:12, Vikas @.***> wrote:

Hi @elish266 https://github.com/elish266 can you please update your
branch with the latest steplib master?
—
Reply to this email directly, view it on GitHub
https://github.com/bitrise-io/bitrise-steplib/pull/3828#issuecomment-1546306997,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOV53AQ4OTKVKXOQIKNSCCDXF2RSHANCNFSM6AAAAAAX4JZ5ZI
.
You are receiving this because you were mentioned.Message ID:
@.***>


[AzureMonitorLiveMetrics] poc refactor metrics

This change removes the OTel Metrics API and instead adds extra properties to the DocumentIngress class. These extra properties can be used to calculate metrics during Post.
Changes

update Customizations/QuickPulseSDKClientAPIsRestClient.cs to handle errors from service.
new class LiveMetricsBuffer which is used to encapsulate all the metrics that we send to LiveMetrics.
new partial class Manager.Metrics which encapsulates creating the MonitoringDataPoint. This includes both the Document and Metrics.

API change check
API changes are not detected in this pull request.


Display ASnum and ASName and CountryCode in IP result boxes

Display ASN/Name after the IP result box copy/external link, and before the start of integrations. I'd like the ASNumber to present on top of the ASName to conserve horizontal space. Experiment with a smaller font to make it work. Display the CountryCode in a column to the right of ASNum/ASName.
ASNum / ASName values can be retrieved from either SPUR, URLScan or VirusTotal results, focus on SPUR, but if not present, then check URLScan, and then VT results.
Find the values in:
SPUR -> as.number, as.organization and geoLite.country
URLScan -> page.asn, page.asnameand page.country
VT -> asn, as_organization and country

this has been completed


no print process

te@te:/home/yuan/mmdetection$ python tools/train.py "/home/yuan/mmdetection/configs/mask_rcnn_r50_fpn_1x.py"
2019-09-18 12:00:40,278 - INFO - Distributed training: False
2019-09-18 12:00:40,879 - INFO - load model from: torchvision://resnet50
2019-09-18 12:00:41,126 - WARNING - The model and loaded state dict do not match exactly
unexpected key in source state_dict: fc.weight, fc.bias
loading annotations into memory...
Done (t=0.00s)
creating index...
index created!
2019-09-18 12:00:44,790 - INFO - Start running, host: te@te, work_dir: /home/yuan/mmdetection/work_dirs/mask_rcnn_r50_fpn_1x
2019-09-18 12:00:44,790 - INFO - workflow: [('train', 1)], max: 100 epochs
+++++++++++++++++++++++++++++++++++++++
From the beginning of the training to the end, the log and checkpoint can be generated, but there is no printing process.
How to make it print the train process if I wang to see？

I found the reason, the log generation interval is too large, change the interval in log_config can solve the problem

I found the reason, the log generation interval is too large, change the interval in log_config can solve the problem

Hello.I met the similar problem.When I use distributed training,there is no print.And the model is bad,it seems that the model learned nothing.Can you help me?

Hello.I met the similar problem.When I use distributed training,there is no print.And the model is bad,it seems that the model learned nothing.Can you help me?

Sorry, I only have one gpu and have not tried distributed training. Your model can work in single gpu？If so, maybe I don't know how to solve your problem.

Hello.I met the similar problem.When I use distributed training,there is no print.And the model is bad,it seems that the model learned nothing.Can you help me?

I also found this weird bug that the logger won't print out anymore.  It takes me a long time to figure out that it's caused by the logger.HasHandlers() function, which always returns the True even the logger.handlers = [], so I change it to len(logger.handlers) > 0, then  the problem is solved.


Request for reopening issue #2491 : enum as index signature

This issue got 103 downvote before locked and the close is not reasonable.

Is this not what you want? #26797

@jack-williams link to 2491 added to 26797. Closing issue.


Implicit type conversions

Pyhon implicitly converts ints to floats when one of the operands is a float, or when the op is division. Should we follow this approach or enforce strict types?
I think the former because it makes the code feel more Pythonic, and I don't think it will cause much confusion as long as we stick to only doing it with int/float.

I'm not sure, implicit conversion in shaders smells like trouble... What's the use case for it? You have to be explicit about input and output types anyway right?

The use case is being able to write e.g. n / 3 instead of f32(n) / 3.0 inside a shader.

I see. Maybe I'm overthinking this :) I was mostly wondering how much control you would want to have over the generated spirv code in optimization scenarios, but maybe it's just not a very big deal

Closing. I think the answer is no. SpirV is much more strictly typed than Python, and it's ok to "feel" that when writing a shader.
Plus it helps to argue about the types of your code if scalar literals comply with the types of other values in an operation:
...
b = a + 1   # I now know that b is an integer type,
            # otherwise the compiler would have complained


ci: fix PR title check and issue template indentation

Fix PR title check by changing trigger to pull_request_target

Preventing security and permission issue, see https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/

Change indentation of issue template to 2 spaces

Same as the oldest yaml file in this repo (.circleci/config.yml)
Now all the yaml files in this repo are applied to 2 spaces indentation
I am sorry for making this mistake 2 month ago

We just happened to be working on this problem today, and thank you very much for your contribution. We will confirm this PR later. 🥰

:tada: This PR is included in version 1.17.2 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


[http]: count sent and received bytes for http stream

Commit Message: Count the number of bytes sent to and received from upstream server per request and store them in stream_info for better observability.
Additional Description:NA
Risk Level:NA
Testing:will add testing for the new metric.
Docs Changes:add doc for the new metric.
Release Notes:NA
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Thanks for working on this!
/assign @KBaichoo

/assign @yanavlasov

This pull request is ready for another round of review.

/retest

Can you add doc changes  (e.g. in https://www.envoyproxy.io/docs/envoy/latest/configuration/observability/access_log/usage) and a release note? Thanks!

/retest

/retest

@mattklein123 as maintainer on-call, can you  assign (to non-Googler) for review? Thanks!


Tab key not switch directly to confirmation field from password field

Tested in verion 19.07.0 and 19.07.2 but probably it's in all verions 19.07.x

Steps to reproduce

Go to router password in settings.
Input password in "Password"
Input tab key to switch to "Confirmation"
Focus is not in input "Confirmation" (in previous version e.g. 18.06.7 tab key switch directly to input "Confirmation" - one press tab instead of two press)
I added gif to show this impediment.

Yes, because the first tab stroke focuses the reveal button. Works as intended.


Retry HTTP requests if they time out

The util module contains helper functions for sending HTTP requests. We need to allow a retry option to send the requests n times (default could be 3) when there is a timeout. This will allow handling failures in Macaron analyze action more deterministically.

It looks like this check
https://github.com/oracle/macaron/blob/fa2622b588546888041cbf3a0c07a67841a98080/src/macaron/util.py#L48-L49
is required because the loop here
https://github.com/oracle/macaron/blob/fa2622b588546888041cbf3a0c07a67841a98080/src/macaron/util.py#L42
hammers on the target host which can be interpreted as a DOS attack from the user’s machine.[^1]
[^1]: And worst case that gets the user’s host (temporarily) banned from accessing the target host altogether.
It would probably make sense to add a time.sleep() (maybe with exponential backoff) into the loop.


Random bits mostly related to framework and gameobject/character.

I think bot can be ignored here. GameObject.GetRadius() function now indeed takes a (bool) argument (you can see that eg. in Character.GetRadius override), but having a default should make the change non-breaking for users.


[WIP] Reskin - text italicized on iPhone WTF?

Closes #1735

I can't really test this as I never was able to replicate the 'italics'. @azadikoff / @decentdao/design could one of you who was seeing it prior, test it out?

I'm still seeing this on my iPhone. Also, attempting to debug and fix now too.

I’m still not seeing the background color in Firefox mobile. Italics went away though 👍
Browser metadata
Path:      /
Browser:   Firefox 125.3 on iOS 17.4.1
Viewport:  393 x 793 @3x
Language:  en-US
Cookies:   Disabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved


”Mircești”, ”Iugani” are listed in the drop-down menu

Description:
When user writes ”Mircești”, ”Iugani” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Mircești"

Expected results
The location appears in the drop-down menu as "Sat Mircești, IAȘI (Mircești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Iugani"

Expected results
The location appears in the drop-down menu as "Sat Iugani, IAȘI (Mircești)".


[CTIS] Add weekly weights to microdata

Description
Add two new fields to the microdata.
weight_wf are the weekly "full" (new definition) weights; weight_wp are the weekly "partial" (old "full" definition) weights. Each of these weights files covers a week period, Sunday through Saturday. Weekly weight files are usually released 1-3 days after the end of the week; the "normal max" is 5-6 days and files have been uploaded up to 9 days after the end of the week.
This is set up so that every time the pipeline is run, it attempts to add weekly weights. If no appropriate weekly weights are available (i.e. the weekly weights aren't recent enough), then those columns are NA but are still reported in the microdata. Them being missing doesn't impact an observation's inclusion in the microdata.
The new make targets are structured assuming that we'll be running the WEEKLY_WEIGHTS target every day. If new weekly weights are available, the weekly weights pipeline is run.
We will need to delay the monthly roll-up process to account for the several days past the end of the week it takes to receive weekly weights. I'm assuming this is set in a cron job.
Changelog

Makefile -- add new targets and variables for weekly weights pipeline, and generalize existing targets (e.g. tidy) to work in the weekly case.
Test params files, and local and production template files -- add weekly weights dir field.
contingency_run.R, test-contingency-run.R, test-integration.R, test-weights.R -- changed name of join_weights to add_weights since, with refactoring, it acts more like a wrapper.
run.R -- change name of join_weights; Add flag indicating that we want to include weekly weights in the microdata.
weights.R --

Rename join_weights to add_weights
Add boolean arg to indicate if want to add weekly weights or not. FALSE (do not add) by default. If TRUE, we load weekly weights from the params-provided weekly weights dir and join full (new definition) and partial (old full definition) them on. The normal weight column is temporarily renamed to avoid overwriting it.
Since we now have three join steps, factor that out into a new function load_and_join_weights

test-gold-individual.R -- create new weekly weights fields to the reference data.

what setup will we need in prod?

We need to add this line to docker_run.sh
    -v "${workdir}"/fb-incoming-weekly:/facebook/fb-incoming-weekly \

The microdata with weekly weights are saved to the normal microdata folders so there's nothing new to add there.
We need to delay the monthly roll up run (I'm assuming this is done as a cron job?) so that it waits for microdata with weekly weights to become available. I guess the worst case is that the last day of the month is on a Sunday, the first day of the weekly weighting range. The weights wouldn't be available until the next Thursday (5 days after the end of the week) at the "normal max" delay, which would be 11 days after the end of the month.


Unfinished sentence in the Install Memgraph section

In the Install Memgraph section of the docs, the first paragraph is unfinished:

If you're new to Memgraph we recommend running Memgraph Platform, a multi-container application. It includes the database

I think there is just a weird line break + empty row


#455 do not render any tile positions until our parent container has a

This is a fix for #455

Hi,
thanks for the contribution!
I informed the responsible developers.
Regards
Andreas

Tracked as<PHONE_NUMBER>

—
Sent from Mailbox
On Tue, Jun 2, 2015 at 11:00 AM, Andreas Kunz<EMAIL_ADDRESS>wrote:

Tracked as<PHONE_NUMBER>
Reply to this email directly or view it on GitHub:
https://github.com/SAP/openui5/pull/456#issuecomment-107849630

M--
—
Sent from Mailbox
On Tue, Jun 2, 2015 at 12:59 PM, Сергей Чеботарев<EMAIL_ADDRESS>wrote:

—
Sent from Mailbox
On Tue, Jun 2, 2015 at 11:00 AM, Andreas Kunz<EMAIL_ADDRESS>wrote:

Tracked as<PHONE_NUMBER>
Reply to this email directly or view it on GitHub:
https://github.com/SAP/openui5/pull/456#issuecomment-107849630

Wxfcsc
—
Sent from Mailbox
On Tue, Jun 2, 2015 at 12:59 PM, Сергей Чеботарев<EMAIL_ADDRESS>wrote:

—
Sent from Mailbox
On Tue, Jun 2, 2015 at 11:00 AM, Andreas Kunz<EMAIL_ADDRESS>wrote:

Tracked as<PHONE_NUMBER>
Reply to this email directly or view it on GitHub:
https://github.com/SAP/openui5/pull/456#issuecomment-107849630

L
—
Sent from Mailbox
On Tue, Jun 2, 2015 at 11:00 AM, Andreas Kunz<EMAIL_ADDRESS>wrote:

Tracked as<PHONE_NUMBER>
Reply to this email directly or view it on GitHub:
https://github.com/SAP/openui5/pull/456#issuecomment-107849630

Hello Mr. Blechschmidt,
Apparently, you have not agreed with the SAP OPENUI5 CLA (you can find additional information here please read it https://github.com/SAP/openui5/blob/master/CONTRIBUTING.md).
So for now in order to process this pull request you need to add the following comment (just after this one):
"I hereby declare to agree to the OpenUI5 Individual Contributor License Agreement."

I hereby declare to agree to the OpenUI5 Individual Contributor License Agreement.


New App Icon

see #49

Would love to have a app icon instead of a black dot only.
Plus an option to hide the menu bar icon would be nice.
What do you think?

I don't think it makes sense to make it seem like an app where you can control your music, this is just a utility, a really useful one at that, but it isn't a music control app like your icon implies

Well, I agree that the dot is too simple but I wanted the thinnest menu bar icon possible. I'm thinking about something different. About the icon hiding : I cannot make it invisible because then it would be impossible to reach the menu and to quit. But there are handy macOS utilities for this purpose, check out Vanilla for example : https://matthewpalmer.net/vanilla/


azure: Apply various small wording improvements and typo fixes

In particular, get rid of the term "starter" which sounds a bit like
"for starters", i.e. for beginners.
Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

/rebase

Merging despite the unrelated Docker build failure which is fixed separately in #3571.