where should keep_attrs be set in groupby, resample, weighted etc.?

I really should not open this can of worms but per https://github.com/pydata/xarray/issues/4450#issuecomment-697507489:

I'm always confused about whether ds.groupby(..., keep_attrs=True).mean() or ds.groupby(...).mean(keep_attrs=True) is correct. (similarly for rolling, coarsen etc.)

Also as I try to fix the keep_attr behavior in  #4510 it would be good to know where they should go. So I tried to figure out how this is currently handled and found the following:
ds.xxx(keep_attrs=True).yyy()

all fixed

ds.xxx().yyy(keep_attrs=True)

coarsen (fixed in  #5227)
groupby
groupby_bin
resample
rolling (adjusted in #4510)
rolling_exp (fixed in #4592)
weighted

So the working consensus seems to be to to ds.xxx().yyy(keep_attrs=True) - any comments on that?
(Edit: looking at this it is only half as bad, "only" coarsen, rolling (#4510), and rolling_exp would need to be fixed.)
Detailed analysis

import xarray as xr
ds = xr.tutorial.open_dataset("air_temperature")
da = ds.air

coarsen
ds.coarsen(time=2, keep_attrs=True).mean() # keeps global attributes
ds.coarsen(time=2).mean(keep_attrs=True) # keeps DataArray attributes
ds.coarsen(time=2, keep_attrs=True).mean(keep_attrs=True) # keeps both

da.coarsen(time=2).mean(keep_attrs=True) # error
da.coarsen(time=2, keep_attrs=True).mean() # keeps DataArray attributes

groupby
ds.groupby("time.month").mean(keep_attrs=True) # keeps both
da.groupby("time.month").mean(keep_attrs=True) # keeps DataArray attributes

ds.groupby("time.month", keep_attrs=True).mean() # error
da.groupby("time.month", keep_attrs=True).mean() # error

groupby_bins
ds.groupby_bins(ds.lat, np.arange(0, 90, 10)).mean(keep_attrs=True) # keeps both
da.groupby_bins(ds.lat, np.arange(0, 90, 10)).mean(keep_attrs=True) # keeps DataArray attrs

ds.groupby_bins(ds.lat, np.arange(0, 90, 10), keep_attrs=True) # errors
da.groupby_bins(ds.lat, np.arange(0, 90, 10), keep_attrs=True) # errors

resample
ds.resample(time="A").mean(keep_attrs=True) # keeps both
da.resample(time="A").mean(keep_attrs=True) # keeps DataArray attributes

ds.resample(time="A", keep_attrs=False).mean() # ignored
da.resample(time="A", keep_attrs=False).mean() # ignored

rolling
ds.rolling(time=2).mean(keep_attrs=True) # keeps both
da.rolling(time=2).mean(keep_attrs=True) # keeps DataArray attributes

ds.rolling(time=2, keep_attrs=True).mean() # DeprecationWarning; keeps both
da.rolling(time=2, keep_attrs=True).mean() # DeprecationWarning; keeps DataArray attributes

see #4510
rolling_exp
ds.rolling_exp(time=5, keep_attrs=True).mean() # ignored
da.rolling_exp(time=5, keep_attrs=True).mean() # ignored

ds.rolling_exp(time=5).mean(keep_attrs=True) # keeps both
da.rolling_exp(time=5).mean(keep_attrs=True) # keeps DataArray attributes

weighted
ds.weighted(ds.lat).mean(keep_attrs=True) # keeps both
da.weighted(ds.lat).mean(keep_attrs=True) # keeps DataArray attrs

edit: moved rolling after #4510, moved rolling_exp after #4592 and coarsen after  #5227

Looking at the list above — does this mean that all functions are aligned now? Or what's remaining before we close?

I think this can be closed.


[Impeller] create explicit skia variants for benchmarks

After impeller android is switched on by default we will need to explicitly create skia variants of our benchmarks (since the existing benchmarks will be transitioned over to skia).  When we did the switch iOS we hand picked some benchmarks to bring over.  Options listed were: the new gallery, platform views.

Holding off until post 3.22 stable release.


[Bug]: Connect to a Dynatrace env using company's proxy

Description
Hi,
I am trying to configure this extension, and I'm having trouble adding a Dynatrace environment:
2024-05-13T14:16:44.564Z [ERROR][utils.conditionCheckers.checkUrlReachable] Request failed with status code 407
2024-05-13T14:16:44.565Z [ERROR][treeViews.commands.environments.addEnvironment] The environment URL entered is not reachable.

In fact, in my company we're using a proxy server and it looks like this extension doesn't use the "http.proxy" vscode setting nor my OS env variables (HTTP_PROXY or HTTPS_PROXY).
What do you think? Am I missing smth ?
Thanks,
Steps to reproduce

Click "Add environment" in the "ENVIRONMENTS" section.
Enter the URL.

Support information

[X] Screenshots
[ ] Extension manifest file
[ ] YAML snippets
[X] Support archive (see here)

Hi, please try using the dedicated VSCode settings for proxy configuration (as documented here):
http.proxy
http.proxyStrictSSL
http.proxyAuthorization

If these end up not working I will transfer this bug to an RFE for adding proxy support in our extension.

Hi Radu,
I tried with the following:
"http.proxy": "http://USER:PASSWORD@PROXY_URL:PORT",
"http.proxyAuthorization": null,
"http.proxyStrictSSL": false

It doesn't work.
Same result with OS environment variables HTTP_PROXY and HTTPS_PROXY.
Yes, you can transfer this as an RFE.
Thank you.

Hi Radu,
Update: actually, the extension correctly uses the http_proxy, https_proxy and no_proxy env variables.
My problem, connecting to our Dynatrace Managed is elsewhere since the command "dt-sdk upload ..." returns [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain
The axios 'Request failed with status code 407' was not that verbose.
So, the extension correctly uses proxy settings when setting the proxy's env variables.
Thank you.
Regards,

@ydas1lva from the extension we don't use dt-sdk for the upload. It would be the same axios client that's used when you first register your tenant.
Try using our settings for uploading a custom CA or disabling SSL. These are documented here


feature: add Sizeof and Alignof to unsafe

This adds Sizeof and Alignof to unsafe. Without access to the node, I dont see a way to add Offsetof, so it is left out for now.
The hook logic was also moved out of the interpreter, to keep it a little cleaner. This should also make any further extensions easier to fit in without changes to the interpreter code.

package main

import (
	"fmt"
	"reflect"
	"unsafe"
)

type foo struct {
	A string
	B string
}

func main() {
	fmt.Println(unsafe.Offsetof(foo{}.B)) // 16

	structField, ok := reflect.TypeOf(foo{}).FieldByName("B")
	fmt.Println(structField.Offset, ok) // 16 ok
}

This code can get structure field offset, but i don't know how to add it to the yaegi interpreter.
I can only add a simple api but with two parameter,   offset(s interface{}, field string)  to "stdlib/unsafe".


chore: Share single chainConfig and review node-related utilities

Closes #1373

startFuelCore now re-uses launchNode instead of having its own node-launching logic
@fuel-ts/utils now exports a defaultChainConfig and a defaultConsensusKey which is used everywhere in the source code.
The chainConfig.json file inside the .fuel-core folder at the root also uses the same chain config. The run-node script has been modified to copy over the contents of the chain config file from the utils package.

@arboleya yep that makes sense if autoStartFuelCore is the only function that's used externally. I thought these two functions served two different purposes. Is autoStartFuelCore just a wrapper?

@Dhaiwat10 Yes, it's sort of a wrapper.

@arboleya looks like the failing tests are unrelated and flaky. Please feel free to re-review

@arboleya @Torres-ssf thanks for the in-depth reviews, guys. I have made the adjustments and also marked the PR with a breaking change since we removed multiple params from the launchNode function.

Should I update the changeset as well? 🤔


[Bug]: Get started button on the website redirects to a page not found.

On the main website https://www.copilotkit.ai/  when clicking on the get started button the website open a page https://docs.copilotkit.ai/what-is-copilotkit which is not found.

I can fix this issue assign it to me please.

Is anyone working on the project ?

where is this page https://www.copilotkit.ai/ on github repositry

I would like to work on this issue, please assign me

Thanks for reporting! We're on it. Unfortunately, our public website is not open-source so we need to fix this internally.

Thanks for reporting! We're on it. Unfortunately, our public website is not open-source so we need to fix this internally.

Glad I could help.

Thank you @South-IN for reporting this!


Only able to accept one TCP/IP connection at a time

Run tcp_server example (requires fix, due to sockname and peername changes; will PR).
generic_unix test:
Open a connection to endpoint using, for example, netcat.  Sned/receive packets.
Open a second connection.  No packets sent or received.
Under investigation.

Fixed in PR https://github.com/bettio/AtomVM/pull/167.
This bug does not apply to ESP32 socket driver.

Fixed


htmlify.p6 leaks memory

The smallish old laptop may be my fault but I am having trouble understanding how a few meg of hand written pod files require more than 2Gig to convert to web pages.  The memory footprint keeps growing and somewhere around a 2.5 Gig virtual size (about 2 Gig RAM) it crashes with
Writing type document for IO::Spec::Cygwin ...
duplicated path /tmp/ron-76609-pod_to_pyg.pod
duplicated path /tmp/ron-20623-pod_to_pyg.pod
duplicated path /tmp/ron-79720-pod_to_pyg.pod
... more duplicated path lines ...
MoarVM panic: Memory allocation failed; could not allocate 1884356 bytes

use Pod::To::HTML;

# This sample code leaks.
# After noticing that perl6/doc/htmlify.p6 seemed to leak memory
# I tested for a leak against the smallest file in the doc tree ...
#   doc/Type/X/Pod.pod6
# If you take out the code block that pod does not seem to leak.

=begin pod

    No code block, no leak, no problem.

=end pod

my $last-pod;
loop (my $i = 0; $i < 1_000_000; $i++) {
    say $i if $i %% 10_000;
    $last-pod = Pod::To::HTML.render($=pod[0]);
}
say $last-pod;

One likely culprit is a Proc::Async/tap leak documented in RT #130494

I have 1GB ram for my machine, but it is require memory more than I expected. In the end, I have to download a precompiled documentation at https://docs.perl6.org/perl6.xhtml

As noted on ticket RT 130494, the Proc::Async leak seems essentially fixed.   I then went and retested the POD codeblock leak and that seems fixed too. "make html" now builds for me on 32-bit Ubuntu with 2 GB ram.  If I don't hear back otherwise then planning to close this ticket in a day or two.


Allow moderated secrets usage on PRs from forks

This PR implements the approach recommended by this article from Github's ‘Security Lab’ to allow the usage of secrets on PRs from forks of the message_ix repository.

Add a "receive" CI workflow.

Run on all PRs into main.
Fail if (a) the PR is from a fork and (b) it does not have a certain label, currently "safe to test".

Adjust the "pytest" CI workflow:

Add a workflow_run: event trigger. Invoke this trigger every time the "receive" workflow completes (success or failure).
Skip the main pytest and tutorials jobs if the "receive" workflow failed.
Invoke actions/checkout with the right options to use the fork PR branch.

With this merged, it would be up to some user with ‘write’ permissions on the current repo to give a first look-over of any PR from and then add the "safe to test" label. (The label could also be removed again at any time.)
How to review
Per the documentation:

This [workflow_run] event will only trigger a workflow run if the workflow file is on the default branch.

This means we will need to:

Merge this PR.
Create or update another PR (#770 was suggested).
Confirm that the pytest workflow is invoked and runs successfully; if not, open a follow-up PR to adjust the workflow(s).

PR checklist

[x] Continuous integration checks all ✅
~Add or expand tests; coverage checks both ✅~ N/A; CI changes only
~Add, expand, or update documentation.~
~Update release notes.~

@glatterf42 FYI this appears not to have worked exactly as intended 🥲
When I opened #894:

This workflow run on main was triggered —which should not have happened, or it should have exited early because that is not a PR from a fork.
It failed, because this value https://github.com/iiasa/message_ix/blob/433868d874533b0b6741c8f54d18b037890265a6/.github/workflows/pytest.yaml#L82
…appears to be a JSON structure rather than the desired string "iiasa/message_ix".

I'll make a note to come back and revisit this.


Implicit type conversion error on MSVC

What is the issue you have?
Wrong type is deduced when json object is use in an expression with some other arithmetic types.

Please describe the steps to reproduce the issue. Can you provide a small but working code example?

// Compiled using MSVC 15.8.8
#include <iostream>
#include "nlohmann/json.hpp"

int main()
{
    nlohmann::json _j = R"({"Value":12.34})"_json;
    double x = _j["Value"]; // prints 12.34 here
    double y = _j["Value"] * 0.01; //prints 0.12 here
    std::cout << x << "  " << y << '\n';
    return 0;
}

What is the expected behavior?
It should either fail to compile (as it does in gcc and clang), or deduce the correct type when mixed with  arithmetic types in an expression and prints 12.34 and 0.1234.

And what is the actual behavior instead?
MSVC compilation succeeds without error/warning (with /W4 and /permissive- flag). The second _j["Value"] calls the implicit conversion function with unsigned int type, converts it to double, then does the multiplication. It prints 12.34 and 0.12 instead.

Which compiler and operating system are you using? Is it a supported compiler?
MSVC 15.8.8 on Windows 10, x64

Did you use a released version of the library or the version from the develop branch?
3.3 (through vcpkg)

If you experience a compilation error: can you compile and run the unit tests?
No compilation error.

I can confirm the code does not compile with Clang (tried Xcode 10). I also agree that the result right now is wrong, but I am not sure why MSVC behaves differently here.

My current workaround is to provide operators for json type and an arithmetic type, e.g.
template <typename T, typename = std::enable_if_t<std::is_arithmetic_v<T>>>
T operator*(const nlohmann::json& _j, T v)
{
    return _j.get<T>() * v;
}

It solves the problem but I'm wondering if there is a more elegant way.

Thanks for your response.
If implicit conversion is allowed but can potentially produce wrong result, it might be a good idea to disable it all together, at least for MSVC.
BTW, I created a PR as the link to #958 is broken in ReadMe.md.


New Extension of  To-Do List

Is your feature request related to a problem? Please describe.
I thing we can add onr more extension for to-do list
where user can save his/her tasks and can make changes or close them
Describe the solution you'd like
there should be one chrome extension which will open on oone cllcik
Additional context

this could be the basic look of the to-do list extansion
of course i will enhace it and make more beautiful
What problem is this feature trying to solve?
adding new feature extension of to-do list
How do we know when the feature is complete?
i will make PR for it

Already added to my repository #35

Already added #35

yes i ahve closed this is issue that's why


Intermittent Cmdlet failures inside a container with error "An error occurred when creating the WebSocket with the factory of type 'CoreClrClientWebSocketFactory'"

Describe the issue
We're getting intermittent failures during Cmdlet execution with the new 'Microsoft.BusinessCentral.xxx.dll' modules for PS7. There does not seem to be a pattern, looks like a race condition, something that happens only under load even. Not really reproduceable. The same execution might fail and then work in a few minutes. The error we get is this:
An error occurred when creating the WebSocket with the factory of type 'CoreClrClientWebSocketFactory'. See the inner exception for details.
Might be related to #3435.
As I said, the container spins up fine. Everything works as expected. After a while the cmdlets executed from inside the container start failing with the message above. Once the error occurred, it keeps repeating. After a while they stop and things work again. No matter what cmdlet we invoke.
We are using the new cmdlets from Admin\Microsoft.BusinessCentral.xxx.dll using PWSH 7.4.1 inside the container. This only seems to happen on our pipelines when building apps with a rather large dependency chain. We therefore cannot even use the PS5 version of the cmdlets because things time out and the build fails for other reasons.
Scripts used to create container and cause the issue
New-BcContainer `
            -containerName <name>
            -accept_eula
            -artifactUrl https://bcpublicpreview.azureedge.net/sandbox/24.0.16410.16790/w1
            -auth 'UserPassword'
            -Credential ...
            -useBestContainerOS
            -allwaysPull
            -updateHosts
            -shortcut None
            -licenseFile ...
            -accept_outdated
            -runSandboxAsOnPrem
            -EnableTaskScheduler:$false
            -dns "<IP_ADDRESS>"
            -multitenant:$false
            -Isolation HyperV
            -restart "always"

Full output of scripts
Creating new container 'BC24-PVW'
BcContainerHelper is version 6.0.11
BcContainerHelper is not running as administrator
UsePsSession is True
Host is Microsoft Windows 10 Enterprise - 10.0.19045.4170
Docker Client Version is 24.0.7
Docker Server Version is 24.0.7
Removing Desktop shortcuts
Fetching all docker images
Fetching all docker volumes
Using image mcr.microsoft.com/businesscentral:ltsc2019
Creating Container BC24-PVW
Style: onprem
Multitenant: No
Version: 24.0.16410.16790
Platform: 24.0.16743.0
Generic Tag: <IP_ADDRESS>
Container OS Version: 10.0.17763.5576 (ltsc2019)
Host OS Version: 10.0.19045.4170 (22H2)
Using HyperV isolation
Using locale en-US
Disabling the standard eventlog dump to container log every 2 seconds (use -dumpEventLog to enable)
Using license file C:\xxxxx.bclicense
Additional Parameters:
--network=nat
-e USEFOR="BuildPipes"
--env customNavSettings=EnableTaskScheduler=False
Files in C:\ProgramData\BcContainerHelper\Extensions\BC24-PVW\my:
- AdditionalOutput.ps1
- HelperFunctions.ps1
- license.bclicense
- MainLoop.ps1
- SetupVariables.ps1
- updatehosts.ps1
Creating container BC24-PVW from image mcr.microsoft.com/businesscentral:ltsc2019
e9301a355ef8dccda41b5c5079222460f9f1643108c6d3bfdd6090b4d8f699f1
Waiting for container BC24-PVW to be ready
Using artifactUrl https://bcpublicpreview.azureedge.net/sandbox/24.0.16410.16790/w1
Using installer from C:\Run\240
Installing Business Central: multitenant=False, installOnly=False, filesOnly=False, includeTestToolkit=False, includeTestLibrariesOnly=False, includeTestFrameworkOnly=False, includePerformanceToolkit=False, appArtifactPath=c:\dl\sandbox\24.0.16410.16790\w1, platformArtifactPath=c:\dl\sandbox\24.0.16410.16790\platform, databasePath=c:\dl\sandbox\24.0.16410.16790\w1\BusinessCentral-W1.bak, licenseFilePath=c:\dl\sandbox\24.0.16410.16790\w1\Cronus.bclicense, rebootContainer=True
Installing from artifacts
Starting Local SQL Server
Starting Internet Information Server
Copying Service Tier Files
c:\dl\sandbox\24.0.16410.16790\platform\ServiceTier\Program Files
c:\dl\sandbox\24.0.16410.16790\platform\ServiceTier\System64Folder
Copying Web Client Files
c:\dl\sandbox\24.0.16410.16790\platform\WebClient\Microsoft Dynamics NAV
Copying ModernDev Files
c:\dl\sandbox\24.0.16410.16790\platform
c:\dl\sandbox\24.0.16410.16790\platform\ModernDev\program files\Microsoft Dynamics NAV
Copying additional files
Copying ConfigurationPackages
C:\dl\sandbox\24.0.16410.16790\platform\ConfigurationPackages
Copying Test Assemblies
C:\dl\sandbox\24.0.16410.16790\platform\Test Assemblies
Copying Extensions
C:\dl\sandbox\24.0.16410.16790\w1\Extensions
Copying Applications
C:\dl\sandbox\24.0.16410.16790\platform\Applications
Copying dependencies
Importing PowerShell Modules
Restoring CRONUS Demo Database
Setting CompatibilityLevel for CRONUS on localhost\SQLEXPRESS
Modifying Business Central Service Tier Config File for Docker
Creating Business Central Service Tier
Installing SIP crypto provider: 'C:\Windows\System32\NavSip.dll'
Starting Business Central Service Tier
Importing license file
Stopping Business Central Service Tier
Installation took 135 seconds
Installation complete
Initializing...
Setting host.containerhelper.internal to <IP_ADDRESS> in container hosts file
Starting Container
Hostname is BC24-PVW
PublicDnsName is BC24-PVW
Using NavUserPassword Authentication
Creating Self Signed Certificate
Self Signed Certificate Thumbprint 473828FC5080153845A054283BD2D4D1A22A6E7E
DNS identity BC24-PVW
Modifying Service Tier Config File with Instance Specific Settings
Modifying Service Tier Config File with settings from environment variable
Setting EnableTaskScheduler to False
Starting Service Tier
Registering event sources
Creating DotNetCore Web Server Instance
Using application pool name: BC
Using default container name: NavWebApplicationContainer
Copy files to WWW root C:\inetpub\wwwroot\BC
Create the application pool BC
Create website: NavWebApplicationContainer without SSL
Update configuration: navsettings.json
Done Configuring Web Client
Using license file 'c:\run\my\license.bclicense'
Import License
Creating http download site
Setting SA Password and enabling SA
Creating admin as SQL User and add to sysadmin
WARNING: This license is not compatible with this version of Business Central.
Creating SUPER user
WARNING: This license is not compatible with this version of Business Central.
WARNING: This license is not compatible with this version of Business Central.
Container IP Address: <IP_ADDRESS>
Container Hostname  : BC24-PVW
Container Dns Name  : BC24-PVW
Web Client          : http://BC24-PVW/BC/
Dev. Server         : http://BC24-PVW
Dev. ServerInstance : BC
Setting BC24-PVW to <IP_ADDRESS> in host hosts file

Files:
http://BC24-PVW:8080/ALLanguage.vsix

Container Total Physical Memory is 8.5Gb
Container Free Physical Memory is 5.6Gb

Initialization took 48 seconds
Ready for connections!

Creating Container user winrm
Reading CustomSettings.config from BC24-PVW
Cleanup old dotnet core assemblies
Container BC24-PVW successfully created

Use:
Get-BcContainerEventLog -containerName BC24-PVW to retrieve a snapshot of the event log from the container
Get-BcContainerDebugInfo -containerName BC24-PVW to get debug information about the container
Enter-BcContainer -containerName BC24-PVW to open a PowerShell prompt inside the container
Remove-BcContainer -containerName BC24-PVW to remove the container again
docker logs BC24-PVW to retrieve information about URL's again```

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
- does it happen all the time? no
- did it use to work? no

Are you using BcContainerHelper functions or are you using Invoke-ScriptInBcContainer with your own script?

Could you try to give it 12G of RAM and see whether this is a memory issue?  use -memoryLimit

In issue #3435 he is also using latest build of Windows 10 (22H2) - 10.0.19045.4170
Have you seen this on other OS' - could you try running with agents on Server 2022 or on Windows 11 machines?

Are you using BcContainerHelper functions or are you using Invoke-ScriptInBcContainer with your own script?

Neither. We are actually running our own service (.NET8) inside the container that executes the cmdlets. It creates a PS session and loads the module, then executes scripts.

Could you try to give it 12G of RAM and see whether this is a memory issue? use -memoryLimit

Will try and let you know.

Have you seen this on other OS' - could you try running with agents on Server 2022 or on Windows 11 machines?

Yes. At the moment we're having somewhat similar issues on 3 machines, all running the same version. We've seen this also on Windows Server 2016 (10.0.14393) and Windows Server 2019 (10.0.17763.5576). Currently don't have access to any Server 2022 or Windows 11 machines myself, but many of my colleagues use Windows11. I don't have anything reported from them - yet.

Some more details:
It looks like this might be a load issue. While I am still not really able to reproduce it on my machine, I have enable some debug logging and the results that are coming in are a bit confusing but all point in the same direction:
I've received some instances of The remote party closed the WebSocket connection without completing the close handshake. errors. Looks like the service closes connections? Would align with the original message of failing to set up the websocket.
On a different machine I've received reports of operations timing out because the service crashes. I have looked for details in the container's event log but found none (no usual .NET stacktrace), just the kernel fault.
Faulting application name: Microsoft.Dynamics.Nav.Server.exe, version: 24.0.16743.0, time stamp: 0x65a80000
Faulting module name: KERNELBASE.dll, version: 10.0.17763.5576, time stamp: 0x35679fc4
Exception code: 0xe0434352
Fault offset: 0x00000000000349b9
Faulting process id: 0x7bc
Faulting application start time: 0x01da7b9168810999
Faulting application path: C:\Program Files\Microsoft Dynamics NAV\240\Service\Microsoft.Dynamics.Nav.Server.exe
Faulting module path: C:\Windows\System32\KERNELBASE.dll
Report Id: e6f84387-ea3f-4e14-83ec-9df85102e8eb
Faulting package full name:
Faulting package-relative application ID:

Afterwards the event log is full of messages that the health check failed.

Yeah - this looks like the Service Tier crashes and then subsequent admin commandlets will fail with coreclrclient... - that makes sense.
Now we just need to figure out why the service tier crashes:-(

Tried this:
Invoke-ScriptInBcContainer -containerName bcserver -scriptblock {
   1..100 | % {
     Get-NavAppInfo -serverinstance $serverinstance | % {
       Get-NavAppinfo -serverInstance $serverinstance -id "$($_.AppId)"
     }
   }
}

Doesn't give any problems here.

I just reproduced this on my machine. Here's the output of the event log:
Type: System.InvalidOperationException
Message: An error occurred when creating the WebSocket with the factory of type 'CoreClrClientWebSocketFactory'. See the inner exception for details.
Source: System.Private.ServiceModel
HResult: -2146233079
StackTrace:
     at System.ServiceModel.Channels.ClientWebSocketTransportDuplexSessionChannel.CreateWebSocketWithFactoryAsync(X509Certificate2 certificate, TimeoutHelper timeoutHelper)
     at System.ServiceModel.Channels.ClientWebSocketTransportDuplexSessionChannel.OnOpenAsync(TimeSpan timeout)
     at System.ServiceModel.Channels.CommunicationObject.OnOpenAsyncInternal(TimeSpan timeout)
     at System.ServiceModel.Channels.CommunicationObject.System.ServiceModel.IAsyncCommunicationObject.OpenAsync(TimeSpan timeout)
     at System.ServiceModel.Channels.ServiceChannel.OnOpenAsync(TimeSpan timeout)
     at System.ServiceModel.Channels.CommunicationObject.OnOpenAsyncInternal(TimeSpan timeout)
     at System.ServiceModel.Channels.CommunicationObject.System.ServiceModel.IAsyncCommunicationObject.OpenAsync(TimeSpan timeout)
     at System.ServiceModel.Channels.CommunicationObject.OpenAsyncInternal(TimeSpan timeout)
     at System.ServiceModel.Channels.ServiceChannel.CallOnceManager.CallOnce(TimeSpan timeout, CallOnceManager cascade)
     at System.ServiceModel.Channels.ServiceChannel.Call(String action, Boolean oneway, ProxyOperationRuntime operation, Object[] ins, Object[] outs, TimeSpan timeout)
     at System.ServiceModel.Channels.ServiceChannelProxy.Invoke(MethodInfo targetMethod, Object[] args)
     at generatedProxy_1.OpenAdminConnection(ConnectionRequest)
     at InvokeStub_IAdminService.OpenAdminConnection(Object, Span`1)
     at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
     at generatedProxy_2.OpenAdminConnection(ConnectionRequest)
     at Microsoft.Dynamics.Nav.Management.ServerInstanceConnection.DoOpenAdminConnection(IAdminService adminService) in s:\repo\src\Platform\Management\Prod.Management\ServerInstanceConnection.cs:line 322
     at Microsoft.Dynamics.Nav.Management.ServerInstanceConnection.InternalValidate() in s:\repo\src\Platform\Management\Prod.Management\ServerInstanceConnection.cs:line 212
     at Microsoft.Dynamics.Nav.Management.NavCommand.ProcessRecord() in s:\repo\src\Platform\Management\Prod.Management\NavCommand.cs:line 493
StackTrace:
     at System.ServiceModel.Channels.ClientWebSocketTransportDuplexSessionChannel.CreateWebSocketWithFactoryAsync(X509Certificate2 certificate, TimeoutHelper timeoutHelper)
     at System.ServiceModel.Channels.ClientWebSocketTransportDuplexSessionChannel.OnOpenAsync(TimeSpan timeout)
     at System.ServiceModel.Channels.CommunicationObject.OnOpenAsyncInternal(TimeSpan timeout)
     at System.ServiceModel.Channels.CommunicationObject.System.ServiceModel.IAsyncCommunicationObject.OpenAsync(TimeSpan timeout)
     at System.ServiceModel.Channels.ServiceChannel.OnOpenAsync(TimeSpan timeout)
     at System.ServiceModel.Channels.CommunicationObject.OnOpenAsyncInternal(TimeSpan timeout)
     at System.ServiceModel.Channels.CommunicationObject.System.ServiceModel.IAsyncCommunicationObject.OpenAsync(TimeSpan timeout)
     at System.ServiceModel.Channels.CommunicationObject.OpenAsyncInternal(TimeSpan timeout)
     at System.ServiceModel.Channels.ServiceChannel.CallOnceManager.CallOnce(TimeSpan timeout, CallOnceManager cascade)
     at System.ServiceModel.Channels.ServiceChannel.Call(String action, Boolean oneway, ProxyOperationRuntime operation, Object[] ins, Object[] outs, TimeSpan timeout)
     at System.ServiceModel.Channels.ServiceChannelProxy.Invoke(MethodInfo targetMethod, Object[] args)
     at generatedProxy_1.OpenAdminConnection(ConnectionRequest)
     at InvokeStub_IAdminService.OpenAdminConnection(Object, Span`1)
     at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
     at generatedProxy_2.OpenAdminConnection(ConnectionRequest)
     at Microsoft.Dynamics.Nav.Management.ServerInstanceConnection.DoOpenAdminConnection(IAdminService adminService) in s:\repo\src\Platform\Management\Prod.Management\ServerInstanceConnection.cs:line 322
     at Microsoft.Dynamics.Nav.Management.ServerInstanceConnection.InternalValidate() in s:\repo\src\Platform\Management\Prod.Management\ServerInstanceConnection.cs:line 212
     at Microsoft.Dynamics.Nav.Management.NavCommand.ProcessRecord() in s:\repo\src\Platform\Management\Prod.Management\NavCommand.cs:line 493
----------------------------------
Type: System.Net.WebSockets.WebSocketException
ErrorCode: 0
WebSocketErrorCode: Faulted
NativeErrorCode: 0
Message: Unable to connect to the remote server
Source: System.Net.WebSockets.Client
HResult: -2147467259
StackTrace:
     at System.Net.WebSockets.WebSocketHandle.ConnectAsync(Uri uri, HttpMessageInvoker invoker, CancellationToken cancellationToken, ClientWebSocketOptions options)
     at System.Net.WebSockets.ClientWebSocket.ConnectAsyncCore(Uri uri, HttpMessageInvoker invoker, CancellationToken cancellationToken)
     at System.ServiceModel.Channels.CoreClrClientWebSocketFactory.CreateWebSocketAsync(Uri address, WebHeaderCollection headers, ICredentials credentials, WebSocketTransportSettings settings, TimeoutHelper timeoutHelper)
     at System.ServiceModel.Channels.ClientWebSocketTransportDuplexSessionChannel.CreateWebSocketWithFactoryAsync(X509Certificate2 certificate, TimeoutHelper timeoutHelper)
StackTrace:
     at System.Net.WebSockets.WebSocketHandle.ConnectAsync(Uri uri, HttpMessageInvoker invoker, CancellationToken cancellationToken, ClientWebSocketOptions options)
     at System.Net.WebSockets.ClientWebSocket.ConnectAsyncCore(Uri uri, HttpMessageInvoker invoker, CancellationToken cancellationToken)
     at System.ServiceModel.Channels.CoreClrClientWebSocketFactory.CreateWebSocketAsync(Uri address, WebHeaderCollection headers, ICredentials credentials, WebSocketTransportSettings settings, TimeoutHelper timeoutHelper)
     at System.ServiceModel.Channels.ClientWebSocketTransportDuplexSessionChannel.CreateWebSocketWithFactoryAsync(X509Certificate2 certificate, TimeoutHelper timeoutHelper)
----------------------------------
Type: System.Net.Http.HttpRequestException
HttpRequestError: ConnectionError
Message: An operation on a socket could not be performed because the system lacked sufficient buffer space or because a queue was full. (localhost:7086)
Source: System.Net.Http
HResult: -2147467259
StackTrace:
     at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
     at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
     at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
     at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
     at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
     at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
     at System.Net.Http.AuthenticationHelper.SendWithAuthAsync(HttpRequestMessage request, Uri authUri, Boolean async, ICredentials credentials, Boolean preAuthenticate, Boolean isProxyAuth, Boolean doRequestAuth, HttpConnectionPool pool, CancellationToken cancellationToken)
     at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
     at System.Net.WebSockets.WebSocketHandle.ConnectAsync(Uri uri, HttpMessageInvoker invoker, CancellationToken cancellationToken, ClientWebSocketOptions options)
StackTrace:
     at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
     at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
     at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
     at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
     at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
     at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
     at System.Net.Http.AuthenticationHelper.SendWithAuthAsync(HttpRequestMessage request, Uri authUri, Boolean async, ICredentials credentials, Boolean preAuthenticate, Boolean isProxyAuth, Boolean doRequestAuth, HttpConnectionPool pool, CancellationToken cancellationToken)
     at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
     at System.Net.WebSockets.WebSocketHandle.ConnectAsync(Uri uri, HttpMessageInvoker invoker, CancellationToken cancellationToken, ClientWebSocketOptions options)
----------------------------------
Type: System.Net.Sockets.SocketException
Message: An operation on a socket could not be performed because the system lacked sufficient buffer space or because a queue was full.
SocketErrorCode: NoBufferSpaceAvailable
ErrorCode: 10055
NativeErrorCode: 10055
Source: System.Net.Sockets
HResult: -2147467259
StackTrace:
     at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
     at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
     at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|285_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
     at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
StackTrace:
     at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
     at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
     at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|285_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
     at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)

What did you do?
Ran my script?

No. I have set memoryLimit to 12GB on a fresh new container and then I ran a part of our build pipeline that builds packages and deploys dependencies.
This time however, the service did not crash. It's still up and running, but I can no longer issue any management cmdlets as they all fail with the same message.
The strange thing is: we're using the same identical setup with the same identical scripts for 3ish years now, never had an issue with them. Only with BC24 it started misbehaving.
I'll try to replicate and log the actual cmdlet calls that are being made and update you.

A lot of things changed in BC24 in this layer, but this obviously shouldn't fail.
Try
netstat -ab
inside the container - what does that return?

How are you creating sessions, running commands and removing sessions again?
Using New-PsSession or Start-Job or???

Ran my script?

Now I did. You were almost there. Just iterating up to 100 is not enough, it needs to go up a little more. See below. Mine broke at 145.

netstat -ab inside the container - what does that return?

It fills my screen with tons and tons of lines like the following
[pwsh.exe]
  TCP    [::1]:61233            BC24-PVW:7086          ESTABLISHED

Here's a clean repro:
Enter a container using Open-BcContainer -pwsh $true -containerName <name> and then run the following script:
$ServerInstance = "BC"
$WarningPreference = "SilentlyContinue"
1..1000 | % {
	$sw = [System.Diagnostics.StopWatch]::StartNew()
	Get-NavAppInfo -serverinstance $serverinstance -TenantSpecificProperties -Tenant "default" | % {
		Get-NavAppinfo -serverInstance $serverinstance -Name "$($_.Name)" -Publisher "$($_.Publisher)" -Version "$($_.Version)" -TenantSpecificProperties -Tenant "default" | out-null
	}
	$sw.Stop()
	Write-Host "$_ : $($sw.Elapsed))"
}

It will eventually release some sockets back to the OS, but way too slow. A development server or container that is heavily deployed against will fatigue fast.

I can definitely repro that

Create a v24 container and run:
Invoke-ScriptInBcContainer -containerName bcserver -scriptblock {
  $WarningPreference = "SilentlyContinue"
  1..10 | % {
    $sw = [System.Diagnostics.StopWatch]::StartNew()
      Get-NavAppInfo -serverinstance $serverinstance -TenantSpecificProperties -Tenant "default" | % {
        Get-NavAppinfo -serverInstance $serverinstance -Name "$($_.Name)" -Publisher "$($_.Publisher)" -Version "$($_.Version)" -TenantSpecificProperties -Tenant "default" | out-null
    }
    $sw.Stop()
    Write-Host "$_ : $($sw.Elapsed))"
  }
}

The error is in the CmdLets of BC24 - will check whether a fix will make it into BC24


Iteration Plan for April 2020

April 2020 Plan
Last month, the App Center team made some changes in the Diagnostics service to improve navigation and reduce the number of clicks needed to access relevant information. We added persistent filters, more details in the crash report view, and added a symbols management UI for Android and Windows apps. On the distribution side, we fixed few bugs and improved the overall experience of in-app update. Finally, engineering improvements were made to increase the reliability and scalability of our services.
This month, we have the following features planned:
API

[x] Introduce App-level API tokens [#167]

Build

[x] Update Android NDK version to support the latest version

Test

[x] Upgrade Appium support to version 1.17.x

Distribution

[x] Improve upload speed [Note: being rolled out gradually to all the customers using App Center Portal]
[ ] Improve deep linking to release experience [#140]
[x] Improve in-app update experience on Android [#1650]

Diagnostics

[ ] Improve symbol management experience
[ ] Insights into versions affected by same crash group

SDK

[x] Support Sparkle EdDSA Signatures for Mac releases [#1410]
[ ] Add support for Mac Catalyst* [#1578]

Support

[x] Switch customer support interface from bubble-chat style to email-based interaction

any updates on https://github.com/microsoft/appcenter/issues/880 or https://github.com/microsoft/appcenter/issues/143 or https://github.com/microsoft/appcenter-sdk-dotnet/pull/658?
the feedback from the community is pretty clear - Xamarin.Mac support would help us a lot.

Many of the top-requested features have been sitting there for months. Some of them are causing a lot of pain (e.g. #125) yet would take very little engineering time to implement. Is there a reason they keep getting deferred?

@phatmann Thanks for the feedback. I will escalate this internally and will share an update soon.

@ahdbilal  pleas please include #125

@nor0x unfortunately no updates on Xamarin macOS support. We will continuously evaluate this in our planning.

Any updates regarding #159?

Would love to see https://github.com/microsoft/appcenter/issues/1313

@winnie Can you please share the rationale of why macOS is not getting the focus a lot of the community require?


No Data on dashboard for Unity Android

Unity editor version: 2017.4.21f1
Firebase Unity SDK version: 5.5.0
Firebase plugins in use : Analytics, Messaging
Additional SDKs you are using : Facebook, Singular, Google play services 0.9.64
Platform you are using the Unity editor on : Mac OS Mojave
Platform you are targeting : Android, iOS
Scripting Runtime : Mono and IL2CPP
I used Firebase SDK for messaging and analytics and implemented as described in the documentations. For iOS, everything is working fine, I am able to see custom events on dashboard. But for Android platform, Firebase console is not registering any data.
Have you been able to reproduce this issue with just the Firebase Unity quickstarts (this GitHub project)? No, Using sample app, I am able to get events on firebase dashboard for androids.

Hi @Ansh2020 It appears that you're using an old SDK version. Could you try using the latest version and see if the issue persists? Otherwise, please send a runnable example so I could identify why this issue occurs. Thanks!


[Feature] Supporting Drag Target to Merge

Use case:
Drag one item to another so that I can merge the one to another object when I drop. (It's like in Android/iOS home screen where you can drag apps to folders or drag into another that it creates a folder) Basically supporting both drag and drop, and when dropped into another item (before reorder) user can have ability to merge the items.
Simple action: https://i.stack.imgur.com/bIS09.gif
So user can either re-order, or merges the items together before the next index moves.

Hi @objectorientedperson
That sounds like a great feature and shouldn't be too hard too implement. I will add this feature to my roadmap for the next major version 4.0.0.

@karvulf thank you so much. Cannot wait!

@karvulf any progress for the next version?

I wish I could say yes, but I just hadn't enough time to implement your feature. I am still on the process to rebuild the drag and drop functionality. This is the most important and complicated feature, so it takes a lot of time that I need. I hope in the beginning of the next year, I will finish that. @objectorientedperson

What you could think of, did you try to implement your feature request with just a normal GridView. In your case you don't want to reorder the items, right? So I am pretty sure that this implementation should also work without this package. @objectorientedperson

Glad to hear it will be available soon.
My case is reorder + merge, yes with current widgets we can add merge functionality but I need them both. And there is no any plugin/library does that.

hi @karvulf, would be glad to hear from you for any updates.

Hello @objectorientedperson
I am very sorry, I totally forgot to notify you. Could that solve your issue? #89
The user built a solution to delete an item, probably that could also be something useful for your usecase.

Hello @objectorientedperson
I am very sorry, I totally forgot to notify you. Could that solve your issue? #89
The user built a solution to delete an item, probably that could also be something useful for your usecase.


LLVM instrumentation coverage on embedded tests

Relevant crate: defmt-test (although could be relevant for any generated runners etc).
In the past year rustc has added the unstable instrument-coverage feature for collecting code coverage: docs. This works reasonably well and generally provides more accurate results than process tracing tools. The way it works is to associate regions of code with some counters, add some extra functions and then the compiler adds in function calls to record when each location is ran. When the process exits it saves the results to a file and then using a combination of the instrumented binary and this file you can get the code coverage results.
Now I've done a little bit of investigation in a separate project https://github.com/xd009642/llvm-embedded-coverage which demonstrates how to remove the File IO. LLVM provides some external functions/symbols (docs: https://clang.llvm.org/docs/SourceBasedCodeCoverage.html ) which you can use to instead operate on a buffer.
The way I envisage this feature would allow people to run their tests on target, and then the buffer with the profraw data be transferred  over JTAG/USB/whatever to the host machine where it is collected and saved to a file default.profraw to match the current UX of using it in rustc. The transferring of the data down the wire and signalling it shouldn't be printed but saved to a file is currently an unknown for me - I'm not familiar enough with defmt's workings.
There's currently some usability faff. The serialization isn't streaming so you need the entire buffer available and the size cannot be known before compilation (depends on the amount of code included, dead-code elimination etc can change this). So without the alloc feature you may find the buffer is too small to serialize and you can't collect coverage. This is currently the only big issue I see, for these instances I've made the max buffer size configurable via an env var, if it's too small the program panics with a message saying how big it should be.
It does without saying I anticipate this feature to be optionally compiled in only if -Z instrument-coverage is present in the rust flags, so for normal users this should have no effect. I'd also be very interested in implementing this as I've already done a bunch of work with the format and this has significant overlap with some of the work I may have to do for my main project https://github.com/xd009642/tarpaulin

From some discussion that went on I've upped the PoC to make it no_std, in a branch and ran into https://github.com/rust-lang/rust/issues/81684 I'll still be looking into this but it may be more a distant dream than something easily graspable

As a data point:
I looked into -Z instrument-coverage and also minicov months ago. The main issue I saw at the time was that -Z instrument-coverage increased program size (Flash size) and RAM usage (iirc? .bss?) in a way that's proportional to the amount of source code, e.g. number of dependencies. So having a 100kLoCs svd2rust crate in the dependency graph made the program not fit in the target, regardless of whether the crate's API was used or not. Unsure if that's just a bug.
What seemed more promising in terms of Flash & memory footprint was directly using one of LLVM coverage passes, boolean flags something? I forget the flag name. That produced branch coverage data but it was not in any standard format like profdata so extra work would be needed to convert the raw data into something that other tools accept. I did not look into that.

It will increase bss for the counter variables. One solution for that is to add the #[no_coverage] attribute to any svd2rust generated code, but I'm not sure if it's stable yet but that would reduce the impact of the problem.
I'll have to look at the llvm coverage passes and see how they work, it's not an area I've looked at!


chore: codescan modifications

This PR address code scan false positives with the exception of G104 errors, which may no longer be needed.

@padamstx I updated the new results to use inline comments, and updated the previous above line entries to be consistent throughout.

:tada: This PR is included in version 5.6.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[TEST] - Non-functioning Mocha tests

Current non-functioning tests:

[ ] POST data/blob
[x] GET data/getData (route file is wrongly named, test file is wrongly named)
[x] GET device/info
[x] POST data/new (route file is wrongly named, test file is wrongly named)

The /data routes also have style issues. Please use ESLint to ensure consistent style and convention.

@Lepabryce @Golem8
Team, let's ensure that the tests are passing. Please check for failing tests as mentioned by Matt before we make any other pull requests. Thank you.

The test passes when using the github version of formidable. #34 makes formidable 2.x.x a dependency, and the fileWriteStreamHandler method used to upload to s3 was added in formidable 3.x.x
Is it possible to modify the automated test using something like this, and go back to using the github version of formidable?

@matt8100


Use camelCase identifiers in the JS API.

[x] I have read the section in CONTRIBUTING.md about pull requests.
[x] My changes are appropriately documented.
[ ] My changes have sufficient test coverage.

Does it need any tests?

[ ] The test suite won’t run on my local machine. (before or after)

This fixes #325.

@j-f1 It looks like there's a problem in win32.js, take a look at the test output.
Also, what part of the testsuite is not running locally?

Could you also add a NEWS entry? (An entry under both "Changed" and "Deprecated".)

@malept  Sorry for the delay. I’ve added the changes requested.
The problem doesn’t make sense. Presumably, the files are minified somehow (see this line).
When I try to run the test locally, it downloads Electron, then nothing happens.

The problem doesn’t make sense. Presumably, the files are minified somehow

I think this is an artifact of the code coverage module.


Add unsupported plugins

Add the Outdoor Smart Plug and Lamp Dimming Smart Plug.
Fixes #83
Fixes #84

As I mentioned in #84, no longer applicable, but thank you :)


Add a warning on Drafter.js being deprecated soon

The failing test might be because of caching C++ drafter. Rebuilding without cache.


Corrected ISO code for Great Britain from UK to GB.

Hi, thank you for your contribution.
If I got the ISO norm right (see link provided https://en.wikipedia.org/wiki/ISO_3166-2:GB), the ISO code GB is linked to United-Kingdom and not only Great-Britain.
Data should then be Royaume-Uni,0.457,GB.

GB is the ISO code for the "United Kingdom of Great Britain and Northern Ireland".
See https://www.britannica.com/story/whats-the-difference-between-great-britain-and-the-united-kingdom
But see also https://help.avalara.com/Frequently_Asked_Questions/AvaTax_FAQ/ACTION_NEEDED%3A__Northern_Ireland_ISO_code_update_for_businesses_selling_into_Northern_Ireland
This is an intensively political point.
I'm not able to test the issue in Northern Ireland, as I don't live there.

Ok, still we must cover Northern Ireland. Based on the provided links, we should add a specific line for Northern Ireland. The energy mix could be either 0.458 (Ireland) or 0.457 (Great Britain) or 0.4575 (average of both).

I've been researching and reflecting on this.
I'm fairly sure that the GB code remains applicable for computers in Northern Ireland.
I believe the new XI code is only used for customs and tax purposes, see https://taxation-customs.ec.europa.eu/system/files/2020-11/use_of_gb_and_xi_codes_guidance.pdf
I propose to put 'Grande-Bretagne et Irlande du Nord'.
As a string, this is rather long, but I don't think that matters?
'Royaume-Uni' is confusing in this context, and led to the incorrect UK code being used.
'Grande-Bretagne' alone is inaccurate, and could upset people in Northern Ireland.
Would you agree?

Sounds good to me ! Thank you for the dive in regulations 😉


HDFS-17472. [FGL] gcDeletedSnapshot and getDelegationToken support FGL

[FGL] gcDeletedSnapshot and getDelegationToken support FGL

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ HDFS-17384 Compile Tests _

+1 :green_heart:
mvninstall
45m  5s

HDFS-17384 passed

+1 :green_heart:
compile
1m 22s

HDFS-17384 passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
compile
1m 15s

HDFS-17384 passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
checkstyle
1m 13s

HDFS-17384 passed

+1 :green_heart:
mvnsite
1m 22s

HDFS-17384 passed

+1 :green_heart:
javadoc
1m  7s

HDFS-17384 passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 45s

HDFS-17384 passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 19s

HDFS-17384 passed

+1 :green_heart:
shadedclient
35m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 12s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  5s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
javac
1m  5s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 58s

the patch passed

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
javadoc
0m 54s

the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

+1 :green_heart:
spotbugs
3m 14s

the patch passed

+1 :green_heart:
shadedclient
35m  9s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
228m 40s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

380m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6743/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6743

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8d4af09480ea 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17384 / 7f82bcf7a0ba76485b6125df7cd40a73f42c1f37

Default Java
Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu220.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~20.04-b06

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6743/1/testReport/

Max. process+thread count
3511 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6743/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Thanks for contribution. Merged.


Ps1 issues on a chromebook

Whenever I upload the rom for Metal Gear Solid on my Chromebook, it crashes and I have to power refresh. Sometimes it gets to the "Select Master ROM screen" before crashing, and when I select a .cue or .m3u file it crashes. Can my Chromebook just not run games made on the Playstation, or is there a fix for this? I really want to emulate the Playstation on my Chromebook.

@BinBashBanana I've noticed this in the new cores in my repository too (although, I've only experienced it with the fceumm core) so there's definitely some cause, probably within retroarch itself.

If your chromebook itself is crashing, the issue is probably not enough RAM. Can you also test with the Mupen64Plus-Next core?

@Senshi209 If you wouldn't mind, can you give me some advice on finding PS1 ROMS and running them?

@Senshi209 just wondering, does the tab crash (does it give an out of memory error?), does the emulator just freeze? Or does something else happen

Tested the Mupen64Plus-Next Core with Ocarina of Time and Goldeneye 007. They work, however sometimes the emulator freezes and I refresh the page. Mysteriously, with the ps1 emulator, my CHROMEBOOK crashes, not just the emulator. To play n64 I usually use the other n64 core, ParaLLEI. It doesn't make the emulator freeze in between and I am currently doing a playthrough of Ocarina of Time on it, the emulator works. Sometimes there are minor texture glitches, but ParaLLEI works.
HaxsMaster, to upload a rom, you should have a folder with the bin and cue files for the game you would like to play. For multi-disk games, simply add the bin and cue files for each disk and put them in the same folder. You also have to create an m3u file, which you can find how to do here(this is for another emulator called OpenEmu however it teaches you how to create m3u files)https://gist.github.com/emilyst/4cbe6a11739bd2c43e9418322a9575ce
When you have your folder, then select choose rom file in webretro and when it says upload directory, upload the folder you created for the game you wanted to play. Sorry if its kind of confusing.

Do you guys know why the Mupen64Plus-Next Core works but not Beetle PSX?

@Senshi209 I suspect it may have something to do with the sheer limitations of a chromebook. But where can I find consistent downloads for those .bin and .cue files? If they were ZIP archives, that would be greatly convienient.

@HaxsMaster The sheer limitations of a chromebook would make sense, but then how come it runs Mupen64Plus-Next? It doesn't make sense, because if this was because of specs, then n64 wouldn't run on my chromebook but it does. @BinBashBanana, is this a problem with retroarch itself? Because it doesn't make sense that a chromebook runs n64 but not ps1. That too, it runs the Mupen64Plus-Next n64 core.
@HaxsMaster here is where I usually download ps1 roms: https://vimm.net/vault/PS1
It has a ton of roms, and I use it to download games for my emulators.

@Senshi209 You can run games like Mario 64 on chromebook, though it may be a specialized version since it was apparently made in HTML. And you can run N64 games at 60 frames. However, the limitations of the system itself result in the game running at 30 frames, which is the max.

Yes, I beat the HTML version of sm64 on my chromebook. However, I am playing OoT for the n64 through the emulator on my chromebook, and it works very well. So why doesn't ps1 work?

Perhaps due to the amount of data that the chromebook has to process? From my knowledge, PS1 games were huge compared to N64 games, especially since they used CDs rather than cartridges. Are the download sizes any different? And also, any help on unzipping the .7z files since I'm also on Chromebook?

I'm not sure if its because of the size of the file, because I think that just depends on how much space you have left on your computer. Plus, the n64 was more powerful than the ps1, so if n64 games run and not ps1 then im guessing its some kind of bug.
Try this for the .7z files: https://extract.me/

Interesting note that the N64 was more powerful. I'll have to fact check that, but yeah, I'd agree that it is probably more dependent on the space left.
So I just have to create a separate folder for the .bin and .cue files once I have uncompressed them, and use that as a directory for the emulator, right?

No, not seperate folders. Put all the files in the same folder.

Has anybody figured out what's happening? If it helps, I am using a Dell Chromebook 3100.

Chances are your chromebook literally doesn't have enough memory, there's no way to really fix this, sorry. The reason why n64 works is because the roms are much smaller, so PlayStation takes more memory. Sorry about this

@Senshi209 When I used the extraction tool (on chromebook) It ended up freezing at 7 to 8%. How long does it usually take?

Yeah ive gotten these issues for PlayStation core also

Can you go to ChromeOS diagnostics and tell me how much RAM (memory) you have?

Its a school chromebook I don't think I could

how do I free this up?

This is re3

@sDetective specs look ok, and the funny graphics can be fixed by going to "More" > "Pre-start options" > "Use software renderer" in the menu bar before choosing the ROM.

its not there

These are the only thing available

Oh wait do you mean in the main retroarch settings?

yep that fixed the issue

Whenever I upload the rom for Metal Gear Solid on my Chromebook, it crashes and I have to power refresh. Sometimes it gets to the "Select Master ROM screen" before crashing, and when I select a .cue or .m3u file it crashes. Can my Chromebook just not run games made on the Playstation, or is there a fix for this? I really want to emulate the Playstation on my Chromebook.

How are you able to use this on chromebook?


Changing first workspace folder restarts extensions

Issue Type: Bug
Changing the first folder in a workspace restarts the extension host.
This is a problem because it breaks the extension's ability to listen for workspace lifecycle events like workspace.onDidChangeWorkspaceFolders (the extension cannot catch an event that changes folder 0 since it's being restarted).
VS Code version: Code 1.21.1 (79b44aa704ce542d8ca4a3cc44cfca566e7720f1, 2018-03-14T14:39:09.335Z)
OS version: Darwin x64 17.3.0
Reproduces without extensions

This issue directly affects extensions that use the proposed FileSystemProvider api (https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.proposed.d.ts#L227).
Test:

An extension registers a filesystem provider with workspace.registerFileSystemProvider for a certain scheme (e.g., ftp)
Adding folders to the workspace that have this scheme work fine; that is, they are handled by the intended provider ✅
Moving folders around that affect the first folder in the workspace breaks this pattern though; the extension restarts, and the mapping between scheme and provider is lost (even if the extension re-establishes it on its activation event). Workspace files that have been fetched with the intended provider will now attempt to be accessed with the default filesystem provider, resulting in ENOENT etc. ❌

This can be confirmed with the https://github.com/jrieken/ftp-sample extension, or another similar implementation.

Unfortunately this is by design so that we do not break our deprecated rootPath property in the API that is always the first root folder.
/cc @jrieken


CodeBERT

I appears Microsoft have a neat little BERT model for code search and basic comment generation, code translation, and simple refactoring. With faster inference in C++, perhaps someone can make a neat VSCode extension or CLI for it...
https://github.com/microsoft/CodeBERT

How would you imagine these models are used in practice? For code search or something else?

How would you imagine these models are used in practice? For code search or something else?

A use case that I was looking into is filtering code data to particularly trainable examples, like done in phi-1

Code search would be the easiest use-case for it, but it seems is can also support very basic code generation/editing. I suppose this model can be useful in the ggml-org/p1 project.

Are working on the codebert? my email<EMAIL_ADDRESS>


Will you include S4 and other state-space models in your benchmark?

You have included Mamba in the leaderboard and survey paper, but this model is not intended for time series analysis; it is better suited for language modeling. There are several state-space models specifically designed for time series analysis, such as S4, S5, DSS, and S4D.

Thanks for your recommendation. We have a long to-do list, where SSM is an important subtask.


Do not show zero total file size for globus objects

For objects accessioned via globus and for which individual file sizes (either some or all in an object) are not available, we do not want to show 0 in the collection item list table.  Instead we will show a message (TBD by Astrid, something like "not available*"), and then at the bottom of the page, we will have a legend indicating why it's not available (TBD something like "* = items deposited through Globus do not have file sizes computed")
Note it may be possible (based on #3231) for some files to have no file size and some files to have a file size.  In this case, we still do no want to show the total object size, because it will not be accurate.  So the determination of whether to show the total file size or not is not "0" but maybe if globus was used to upload files at any point (again, based on what we learn in #3231)
Note: do the investigation in #3231 first, because the results of that will determine how we implement this

Place "NA*" in the size column, and then place a footnote at the bottom of the table:
"*File sizes are not available for deposits made using Globus."

While we could put NA we actually do know the sizes so I would be in favor of fixing the problem.

With what we learned in #3231 I think we need to:

[ ] Modify globus_client to return file sizes as well as file names
[ ] Modify h2 to persist the file size when fetching files from Globus
[ ] Write a program to populate the missing file sizes

Turns out globus_client already has a GlobusClient.list_files() that works nicely:
3.2.0 :011 > GlobusClient.list_files(user_id<EMAIL_ADDRESS>path: 'katebar/work19057')
 => [#<struct GlobusClient::Endpoint::FileInfo name="/uploads/katebar/work19057/version1/bh979th0089.zip", size=4695>]


Added window size changes

Added changes to allow user selected window size

Good catch! I fixed it and merged the changes.
On Mon, Apr 23, 2018, 2:06 PM mitchneutron<EMAIL_ADDRESS>wrote:

@mitchneutron requested changes on this pull request.
Just my one comment! Other than that, it looks good.
In Source/Holodeck/Sensors/Private/HolodeckViewportClientPublisher.cpp
https://github.com/BYU-PCCL/Holodeck/pull/67#discussion_r183520968:

PrimaryComponentTick.bCanEverTick = true;

}
void UHolodeckViewportClientPublisher::BeginPlay() {
// This must come first, since the HolodeckSensor parent class will
// call GetNumItems, which needs the ViewportClient.
ViewportClient = Cast(GEngine->GameViewport);

const FVector2D ViewportSize = FVector2D(ViewportClient->Viewport->GetSizeXY());
Width = ViewportSize.X;
Height = ViewportSize.Y;

It would probably be best to put these lines inside of the if statement
below, in the case that Holodeck isn't on and so the viewport client isn't
actually a UHolodeckViewportClient.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BYU-PCCL/Holodeck/pull/67#pullrequestreview-114535576,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVLXQDoGKsVcs66vE4xQdOdsNZFYbbAHks5trjRFgaJpZM4Td1x4
.


Allow validator for the whole object

Currently there is no easy way to create validator for field of object type (e.g. Moment.js). Extending list of exclusions each time can be to complicated. Simple approach is to add top level validator for object together with low level validators, user of the library can choose, which validator he needs more.

Looks like my pull request #264 more or less duplicates this one. Oops! Hopefully one of ours will get merged in. (This one unfortunately lacks unit tests, so that might be part of the problem.)


tools/create-gce-image.sh: enable encrypt+verity in the image

See discussion on https://github.com/google/syzkaller/pull/1410 for details.
If we enable encrypt+verity features in the root image, then we can get more coverage for these things. However, we need newer mkfs on the host to build such images. So this will require upgrading the host OS too.

@dvyukov is there any update on this?  There's also interest in enabling the -E encoding=utf8 mkfs option so that the ext4 Unicode / casefolding support in kernel v5.2+ will be fuzzed too.

No updates and no ETA. We just need 1 binary, but getting it will involve recreating whole syzbot infrastructure from scratch manually, other things will probably break in process and will need to be fixed.

I am working on this.
-O encrypt and -E encoding=utf8 are incompatible, so we need to choose one for the root disk:
$ mkfs.ext4 -O 64bit,ext_attr,encrypt,verity,extents,huge_file,flex_bg,dir_nlink,sparse_super,resize_inode,has_journal -E encoding=utf8 disk.raw
mke2fs 1.45.6 (20-Mar-2020)
mkfs.ext4: The encrypt and casefold features are not compatible.
They can not be both enabled simultaneously.

Any preference?

I'd prefer -O encrypt, though I am biased because I maintain the encryption support.  There are kernel and e2fsprogs patches in progress to support encrypt and casefold together, but they are taking longer than expected.

There are kernel and e2fsprogs patches in progress to support encrypt and casefold together, but they are taking longer than expected.

An update on this: ext4 supports encrypt and casefold together since Linux v5.13.

FWIW: We had encrypt and verity enabled for a while now.
However I'm about to submit a PR to deactivate verity again. Ext4 images with verity enabled can't be mounted on linux v5.3 and before, causing a ton of bad bisections.
If we think this is important we need support for picking different rootfs images based on kernel version during bisection. We already have something similar for compiler versions.

If we think this is important we need support for picking different rootfs images based on kernel version during bisection. We already have something similar for compiler versions.

I think in the end it might well be the way to go.

Agreed, though for now we should get under control what we have.


settings: Make CSS selector more specific in table rows in org settings.

Fixes #7374.
Since we use table-layout: fixed, the width of the first
row are applied to all the remaining rows, thus wrapping all the columns
to 20% width. This is fixed by making the selector specific to only
user_rows and not the editable data row.
Also, this bug was present in the Organization Settings > Users as well due to the same reason.

@brockwhittaker can you review this?

Looks good to me!

Merged, thanks @aero31aero!


can't change language en to zh in DBeaver 6.20 CE

System information:

Operating system (distribution) and versionqin
win10 x64 1903
DBeaver version
6.20CE
Additional extensions

Connection specification:

Database name and version
Driver name
Do you use tunnels or proxies (SSH, SOCKS, etc)?

Describe the problem you're observing:
can't change language en to zh

Steps to reproduce, if exist:
Include any warning/errors/backtraces from the logs

DBeaver CE (from Windows Store) is a single language application, it supports only English language at the moment (because of Microsoft Store policy)
Workaround: install DBeaver by downloading installer from dbeaver.io/dbeaver.com web site.

DBeaver CE (from Windows Store) is a single language application, it supports only English language at the moment (because of Microsoft Store policy)
Workaround: install DBeaver by downloading installer from dbeaver.io/dbeaver.com web site.

okay...but I like this version,because it's seems strat faster than previous version and update is more convenient.Unable to switch languages has little impact.😂


Updated the shortform library to allow for a firmware package of multiple firmware images

Update the library for creating reports and the samples to allow for multiple firmware images in a single package.

Still working with partners to determine how/if to allow multiple firmware images per document.


Fix warnings

There's a ton of warnings, needs to be fixed
https://github.com/detunized/password-manager-access/actions/runs/9181199542

Fixed in proton branch


Impossible to infuse stuff like shelves

Minecraft Version: 1.18.2
Forge Version: 40.1.60
Mod Version: 1.18.2-5.3.6
Single Player or Server: Server
Describe problem (what you were doing; what happened; what should have happened):
Hello there ! I was trying to get infused hellshelves
I saw you needed to enable the enchantments for the mod, which was always the case, I have the 45 lvls, all the right stats (that being right the right stats or more of them)
But despites all of this, I still can't infuse anything, even after trying multiple times and enchanting other items, impossible to get them... which is pretty sad because you need to infuse stuff to go further in the mod :/
Video/images/gifs (direct upload or link):

That gui isn't an apotheosis enchanting table, so you have another incompatible mod installed.  You'll have to remove it.


Return bool functions, checkConsolidationStatus function

Return bool functions

I think this return structure is better then the if-else approach - just less lines and more readable IMO

checkConsolidationStatus

break loop if wallet1Consolidation is found (_wallet2 is in allDelegationsWallet1)
only go through allDelegationsWallet2 if wallet1Consolidation is true
return true as soon as _wallet1 is found in allDelegationsWallet2 loop

(the above made the declaration of wallet2Consolidation bool redundant so it was removed)

revised approach based on @brookr suggestion and optimisation of checkConsolidationStatus function


Node: Add command JSON.STRLEN and JSON.STRAPPEND

Issue link
This Pull Request is linked to issue (URL): https://github.com/valkey-io/valkey-glide/issues/2375
Checklist
Before submitting the PR make sure the following are checked:

[x] This Pull Request is related to one issue.
[x] Commit message has a detailed description of what changed and why.
[x] Tests are added or updated.
[x] CHANGELOG.md and documentation files are updated.
[x] Destination branch is correct - main or release
[x] Commits will be squashed upon merging.

merging since last push was to resolve conflict and apply linter only, last passing modules job: https://github.com/valkey-io/valkey-glide/actions/runs/11585600001/job/32254801091?pr=2537


test for NotImplemented in ne; add eq and ne to ttProgram.Program

_g_l_y_f.Glyph objects have handy __eq__ and __ne__ methods. However their program attribute did not, so it was using object's default id(self) == id(other), which returns False even when the content of two Program instances is the same.
So I added that.
While doing this I noticed that there are other classes in fonttools which similarly implement __eq__ and __ne__, but they have a problem in that, __ne__ is defined as not self.__eq__(other), but when the type(self) != type(other), then __eq__ will (correctly) return NotImplemented, and thus __ne__ will return not NotImplemeted, which is always False no matter what.
This can lead to illogic results like:
>>> from fontTools.ttLib.tables.DefaultTable import DefaultTable
>>> t = DefaultTable('test')
>>> t == 0
False
>>> t != 0
False

The latter of course should return True.
So I changed all __ne__ to first check if __eq__ returned NotImplemeted, and if so return that as well. This will delegate the comparison to the superclass (object) -- which, in the example above, will return True.

>>> t == 0
False
>>> t != 0
False

That is awesome :)

but that is even more awesome:
>>> t == 0
False
>>> not (t == 0)
True

Thanks, I just wondered what that would yield :)


Search blogs

This should bring the search functionality to the blogs section. We still need to work on UI/UX.
For testing this functionality locally, we need an application on Algolia for credentials keys. I have added .env.example for required variables. Since the Algolia index updates only on build time the application needs to be built once before running the development server.
Also, the types are passed for now.( WIP: fix them soon)
For the review app, I will be adding those environment variables, so it should be working.
Fixes #2712

Seems like the Heroku deploy doesn't have the git info needed for the modification date, I ran into something similar with GH Actions and needed to change to a non-shallow checkout- maybe we just need to git checkout in the Heroku deploy script?

@yalozhkin can you please confirm UI with the latest deployment.
For the back button on blog pages, can you give me a little idea of the icon, text, and placement?
I have reverted the changes getting modified info using git as Heroku doesn't seem to work that way. I feel introducing git to the Heroku deployment flow would not be the optimal solution.
So, I have thought to introduce a field modified_at or updated_at and add a pre-commit hook which will update the date if there are any changes on those posts.
@iterative/websites If the above approach seems good then I will proceed with that else as @rogermparent  mentioned, we can merge this for 1st iteration and discuss and work on another issue/PR for improving the search especially for partial updating the indexes.

So, I have thought to introduce a field modified_at or updated_at and add a pre-commit hook which will update the date if there are any changes on those posts.

This field would be in the blog's frontmatter? Would this approach be completely automated or would blog post writers need to manually add this field? If we do something like this, we'd probably want it to be completely automated 🤔

@iterative/websites If the above approach seems good then I will proceed with that else as @rogermparent mentioned, we can merge this for 1st iteration and discuss and work on another issue/PR for improving the search especially for partial updating the indexes.

Personally, I think we could merge as a 1st iteration and then work on partial updating later.

This field would be in the blog's frontmatter? Would this approach be completely automated or would blog post writers need to manually add this field? If we do something like this, we'd probably want it to be completely automated 🤔
Yes, the field will be on the blog's front matter. I just tried with the pre-commit script and no the blog author doesn't need to add the field. It will be automatically added on commit. The cons would be a little bit of delay on commit.

I can push those changes here or should I do it on another branch?

@iterative/websites, is there anything blocking this pr from being merged as a first iteration?

is there anything blocking this pr from being merged as a first iteration?

I don't see anything that disqualifies it, and it seems the deploy error is just a random Heroku error, but I do think we should run another deploy attempt to ensure everything builds before merging to master.

The redeploy works! Once conflicts are resolved, we should be good to go.

@iterative/websites, is there anything blocking this pr from being merged as a first iteration?

Yes, I think we are waiting for the review on UI changes @yalozhkin requested.

That said, do we have the right environment variables set up? I think we had a discussion on whether to have an index for review apps or not and were learning toward no-

Yes, I had them setup on review env vars as well as production vars on heroku.

does the build break if we don't have the algolia env vars on?

No, the build would not break if we don't have them set. It will just skip them.

It looks like we have got positive feedback from @yalozhkin on slack.

We already have another PR opened for #3239. If we want to merge this we can continue with the discussion there.

Looks like I had missed the response on the Figma board.
Is there any reference for UI/UX, I can take for this implementation?

Where would the back link lead? Back the main blog page - then it's not really needed, it's not critical at least.
As a next step (separate PR), let's please make the search bar hidden under the icon in the top menu or some other place (see medium for example)
I think now it grabs a bit too much attention at the main page + if we put an icon we can keep it at all the pages.

Where would the backlink lead? Back the main blog page - then it's not really needed, it's not critical at least.

Yeah, it's "Back to blog". Also, we can rely on browser back button, too.

As a next step (separate PR), let's please make the search bar hidden under the icon in the top menu or some other place (see medium for example)
I think now it grabs a bit too much attention at the main page + if we put an icon we can keep it at all the pages.

That sounds good. We can start a separate PR on improving the search placements after this get merged. I like how Gatsby has setup the search.

Looks fine to me, but weren't we going to remove the dev_blogs index and make only production index?

If so we would want to either make the search component visible only on the production server or make the base URL to the current website base URL like it's on Search Docs( the results always open on live production URL not locally.)

If so we would want to either make the search component visible only on the production server or make the base URL to the current website base URL like it's on Search Docs( the results always open on live production URL not locally.)

The latter sounds like a perfectly fine solution, even if we're unable to change the base url on deploy previews' search such that it's slightly broken on those previews like the docs search, the search is primarily meant for users on production so I'd say it's worth taking that downside.

I think #3264 is also ready to get merged to this branch.
Once that gets merged, I think we can merge this to master as well.

changes that need to be done:

[ ]  change trigger from current branch to master branch
[ ] remove current environment variable for index name which will default to dvc_blogs for the index name.


test/unpack_strategy: Handle svn unzip unavailable

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

Skip those tests that require svn or unzip.

Maybe change the messages to "Subversion not installed." and "`unzip` not installed.".

Done.

Merged. Thanks for the review, Markus!


fix: GET /metrics call

When reviewing application insight on Oplog I found a GET /metrics call that fails 100% of the time.
This isnt used anywhere in the front-end, and neither is there an endpoint set up for it, so the implications for the application is minimal. But we should find out what's happening and resolve this, mainly so that our log isnt overcrowded with this same call that fails.

The metrics endpoint is queried by Radix to collect application specific metrics. Unless we have specific monitoring needs, we should disable the call by setting monitoring to false in radixConfig.yaml

The monitoring for this "/metrics" call has been disabled.


Add full, authenticated retrieval using the Source API (for JSON content)

Few notes:

Per the title, just covering JSON for now. Not that it'll be difficult to add other formats, but starting with just the JSON to support the data API from India.
Now that there's a fair amount more meat in the function, restructured tests around individual units (with one end-to-end happy path).
Ended up storing service account credentials in S3. Bundling them into the Lambda package made it hard to keep the file hidden, and it didn't feel like encrypting individual fields in env variables was any better than using S3.

 Write/deploy a retrieval Lambda with support for the example source content type

There used to be a time where s3 buckets default permissions were quite open... That's would be an argument against putting creds there but I believe this time has passed. Please kindly confirm perms on that metdata bucket, thanks.

Yep, made sure that it's private by default.


Connection to netlify and git

I'm always frustrated when  the app does not redeploy directly to the same netlify project. Or connects with Git directly. I'm not sure what work mode you recommend. just copy paste all project every time?

@migkast , you noted a very valid flaw, I think Stackblitz are looking into it as part of this issue https://github.com/stackblitz/bolt.new/issues/49
Fyi @Nemikolh


[BUG][LinuxOS] No package 'libkvspicUtils' found

OS : Linux
Version : Ubuntu 20.04.5
Checking for module 'libkvspicUtils'
--   No package 'libkvspicUtils' found

That wasnt the problem actually, when I give the make command the missing module is getting built but there are actually more missing libraries that need to be built like for example "kvs_gstreamer_sample" "gstkvssink"

Not sure I understand. Can you clarify the exact issue? Your screenshots suggest you have the samples built and the libraries. What is the error?

The second screenshot is from a youtube video with all the libraries built the first screen are those that were built for me they are incomplete

I require the kvs_gstreamer_audio_video_sample but it is not built in mine

@AbhinavSandru ,
Please provide the following details:

What version of the SDK are you building?
Have you followed the README to install gstreamer on your system?
What Cmake command are you running? To generate the samples, you need to run cmake .. -DBUILD_GSTREAMER_PLUGIN=ON.


Update READMEs, change version of packages to v1.0

make READMEs uniform across repository to facilitate user understanding
bump version of packages to 1.0.0 as we've hit the milestone

Splitting in two PRs


simplify report generation

Moves logic to create and run in a temp directory to one location.
Removes duplicate Rmd filenames.
Adds a new report directory used for PDF generation.
Inside this directory new temporary directories will be created when rendering reports.
Adds achilles to fix rendering report_dummy_app.Rmd (example gene WASH7P).
Updates OpenShift deployment template to create a temporary reports directory.
Fixes #104

Why is the default dir in your new fun() still code/?

Why is the default dir in your new fun() still code/? To get the template?

I not sure I understand the question. I moved the changing directory logic to the end of the process. When we enter the new function render_rmarkdown_in_tempdir we are still in the /code directory. At the point we run file.copy we are inside the temp directory. The rmd_path variable needs to be an absolute path or the file.copy function will fail.


The lb module resources are not checked while elb and alb are.

What happened?
The AWS provider has three load balancer modules: elb, alb, and lb.
The alb and lb modules are the same resources with different names (presumably for historical backwards compatibility), but there are no policies checking for resources that are of the lb family.
Example
You can see alb and elb policies here: https://github.com/pulumi/compliance-policies/tree/main/vendor-aws/aws
And you can see that there is also and lb module in the provider here: https://www.pulumi.com/registry/packages/aws/api-docs/lb/
Output of pulumi about
N/A
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Implemented and available in<EMAIL_ADDRESS>


Trouble installing after updating Hoobs to 3.3.5

Issue

Hello, Today I updated my Hoobs version (3.3.5) and try to install the Hue plugin.
Sadly I got an error message (see below)
Is that because I updated to the new version, or am I missing something else?
Thanks in advance for the help.
Log Messages

14-4-2021 18:19:49  ERR!
14-4-2021 18:19:49  code ETARGET
14-4-2021 18:19:49 npm
14-4-2021 18:19:49
14-4-2021 18:19:49 ERR!
14-4-2021 18:19:49
14-4-2021 18:19:49 notarget
14-4-2021 18:19:49  No matching version found for<EMAIL_ADDRESS>14-4-2021 18:19:49 npm
14-4-2021 18:19:49
14-4-2021 18:19:49 ERR!
14-4-2021 18:19:49
14-4-2021 18:19:49 notarget
14-4-2021 18:19:49  In most cases you or one of your dependencies are requesting
14-4-2021 18:19:49 npm
14-4-2021 18:19:49
14-4-2021 18:19:49 ERR!
14-4-2021 18:19:49
14-4-2021 18:19:49 notarget
14-4-2021 18:19:49  a package version that doesn't exist.
14-4-2021 18:19:50
14-4-2021 18:19:50 npm ERR!


"Go to file" feature stumbles when typing any file name

Issue Type: Bug
Greetings to everyone,
since the release of 1.52.x I've encountered an issue with "Go to file" pop-up form.
Basically, non deterministically, when I type a name of a file I'm look for the input form stumbles for aprox. 2 seconds (I guess the UI of VSCode stops as well) and only AFTER that everything goes back to normal.
Sorry for the vague description, I can't make a gif to visualise the issue (non deterministic), the only conditions I can give you are the big picture:
It DOESN'T happen all the time (during my working hours aprox. 5-10 times a day)
It happens in any project structure and complexity (small files or big files - doesn't matter)
It happens only in VScode 1.52.x and above
I didn't try to use VScode without any extensions for that I can't work without them and wait until whether or not the issue persist.
I'm open to give any further info if needed.
As always, thank you for the amazing tool!
VS Code version: Code 1.52.1 (ea3859d4ba2f3e577a159bc91e3074c5d85c0523, 2020-12-16T16:30:02.420Z)
OS version: Darwin x64 20.1.0
Remote OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.18GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: Ipernet

OS
Windows_NT x64 10.0.19041

CPUs
Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)

Memory (System)
15.94GB (6.82GB free)

VM
0%

Extensions (23)

Extension
Author (truncated)
Version

bracket-pair-colorizer
Coe
1.0.61

auto-close-tag
for
0.5.9

auto-rename-tag
for
0.1.5

remote-containers
ms-
0.154.1

remote-ssh
ms-
0.62.0

remote-ssh-edit
ms-
0.62.0

remote-wsl
ms-
0.52.0

vscode-remote-extensionpack
ms-
0.20.0

sublime-keybindings
ms-
4.0.7

vscode-icons
vsc
11.0.0

alignment
ann
0.3.0

path-intellisense
chr
2.3.0

indent4to2
Com
0.1.2

vscode-eslint
dba
2.1.14

vstortoise
flo
1.2.2

beautify
Hoo
1.5.0

svn-scm
joh
2.13.5

vscode-cflint
Kam
0.3.4

vscode-cfml
Kam
0.5.3

vscode-filesize
mkx
2.1.4

prettify-json
moh
0.0.3

vscode-paste-and-indent
Rub
0.0.8

sass-indented
syl
1.8.13

This might be caused by our new automatic port forwarding feature which scans the remote OS for available ports in order to forward them locally (https://github.com/microsoft/vscode/issues/112843)

~This might be caused by our new automatic port forwarding feature which scans the remote OS for available ports in order to forward them locally (#112843)~ This cannot be the case because the remote OS is Windows.

Thanks for keeping in touch! Sadly I still can't give any more information than above-mentioned ones. The only sure thing is, again, the fact that it doesn't happen on the releases bellow 1.52

when I type a name of a file I'm look for the input form stumbles for aprox. 2 seconds

Can you tell me a little more about what exactly you are seeing?

Hi, so I tried to figure out some valuable messages in devtools of the VScode and here is the result. When I tap CMD+P and start to write any filename, the UI of the VSCode freezes completely for about 1.5 - 2 seconds and according to logs I suspect it's ColdFusion related extensions. (I'm not sure whether CFLinter or CFML syntax).
Since I can't shut down those extensions during my development, I don't know what else I could do in order to track the cause of the issue. Any help?

Hi, so I tried to figure out some valuable messages in devtools of the VScode and here is the result. When I tap CMD+P and start to write any filename, the UI of the VSCode freezes completely for about 1.5 - 2 seconds and according to logs I suspect it's ColdFusion related extensions. (I'm not sure whether CFLinter or CFML syntax).
Since I can't shut down those extensions during my development, I don't know what else I could do in order to track the cause of the issue. Any help?

I would guess that this is just related to search itself, but I don't have a guess as to why this just shows up with 1.52. Do you think it makes a difference based on what you start typing in cmd+P?

I would guess that this is just related to search itself, but I don't have a guess as to why this just shows up with 1.52. Do you think it makes a difference based on what you start typing in cmd+P?

I would guess that this is just related to search itself, but I don't have a guess as to why this just shows up with 1.52. Do you think it makes a difference based on what you start typing in cmd+P?

I understand you, it's hard to tell even from my user's perspective what causes this undeterministic behaviour. It would be much easier to see it in action by recording a video but it's impractical to record my entire working day. From my experience since the 1.52.x version came up, it makes no difference on what I type in the searching bar. I see it happen and it happens in any project I've been working so far: small, medium and big ones - 0 difference.
I really like your product and I'll make sure next time I'll be more precise and have more concrete evidence. For now I'll cope with my issue and investigate more on the matter. I'll try to monitor devtools on the second monitor when the searching bar freezes again and see what I can do.
Thank you!

I would guess that this is just related to search itself, but I don't have a guess as to why this just shows up with 1.52. Do you think it makes a difference based on what you start typing in cmd+P?

I understand you, it's hard to tell even from my user's perspective what causes this undeterministic behaviour. It would be much easier to see it in action by recording a video but it's impractical to record my entire working day. From my experience since the 1.52.x version came up, it makes no difference on what I type in the searching bar. I see it happen and it happens in any project I've been working so far: small, medium and big ones - 0 difference.
I really like your product and I'll make sure next time I'll be more precise and have more concrete evidence. For now I'll cope with my issue and investigate more on the matter. I'll try to monitor devtools on the second monitor when the searching bar freezes again and see what I can do.
Thank you!

Please let me know if there is any new info. Also 1.53 will be released within the next week.


SQL Azure incorrectly detected as SQL Server 2014

Which version and edition of Flyway are you using?
Flyway Community Edition 6.0.0 by Boxfuse
If this is not the latest version, can you reproduce the issue with the latest one as well?
(Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
command-line (Powershell, pswh, cmd)
Which database are you using (type & version)?
SQL Azure
Which operating system are you using?
Windows 10 64 bit
What did you do?
(Please include the content causing the issue, any relevant configuration settings, the SQL statement that failed (if relevant) and the command you ran.)
.\flyway -user=REDACTED -password='myPassword' -url="jdbc:sqlserver://RedactedRedacted.database.windows.net;databaseName=RedactedRedacted;" -connectRetries=60 migrate
corrected typo in URL
What did you expect to see?
Flyway Deployment to Azure SQL Azure
What did you see instead?
Flyway Community Edition 6.0.0 by Boxfuse
Database: jdbc:sqlserver://REDACTEDREDACTED.database.windows.net:1433;useBulkCopyForBatchInsert=false;cancelQueryTimeout=-1;sslProtocol=TLS;jaasConfigurationName=SQLJDBCDriver;statementPoolingCacheSize=0;serverPreparedStatementDiscardThreshold=10;enablePrepareOnFirstPreparedStatementCall=false;fips=false;socketTimeout=0;authentication=NotSpecified;authenticationScheme=nativeAuthentication;xopenStates=false;sendTimeAsDatetime=true;trustStoreType=JKS;trustServerCertificate=false;TransparentNetworkIPResolution=true;serverNameAsACE=false;sendStringParametersAsUnicode=true;selectMethod=direct;responseBuffering=adaptive;queryTimeout=-1;packetSize=8000;multiSubnetFailover=false;loginTimeout=15;lockTimeout=-1;lastUpdateCount=true;encrypt=false;disableStatementPooling=true;databaseName=REDACTEDREDACTER;columnEncryptionSetting=Disabled;applicationName=Microsoft JDBC Driver for SQL Server;applicationIntent=readwrite; (Microsoft SQL Server 12.0)
ERROR: Flyway Enterprise Edition or SQL Server upgrade required: SQL Server 2014 is no longer supported by Flyway Community Edition, but still supported by Flyway Enterprise Edition.

Also noticed this error, please let me know if another issue should be created.
'eName' is not recognized as an internal or external command, operable program or batch file.
ScreenCast of issue.

Thanks for the report - the second part (the eName issue) has already been reported at https://github.com/flyway/flyway/issues/2487 and we'll answer that one there.

We have a fix - will be shipped in 6.0.1 and pushed to the repo asap.