/reinvite not working

/reinvite doesn't seem to work - just sends the error message "Choose target party member to reinvite"

7646315
#817

https://github.com/HasKha/GWToolboxpp/commit/0243a630f1fab002524719fb83ddb098314eb0fb

I don't remember which TB version broke it, but it used to be possible to invite people who aren't in your party at all. This no longer works, and doesn't even give an error message.
When targeting some people, the feature works correctly, but for most I just get the choose a party member to reinvite error.

Has never worked this way, and for a good reason - the yellow highlight on the party window is not directly related to the in game targeting system and there are some situations where the person highlighted in the party window doesn’t match the current target window in game.
Just to check, are the people you’re targeting to reinvite already party members or not, and are you targeting them in game or via the party window, related to the point above?

Unless I have Alzheimer's, I distinctly remember it working that way, but it sounds like you're misunderstanding me.
What I want to be able to do is to target anyone in the outpost (including henchmen), use /reinvite, and have it send a party invitation to them. If they were already in the party and I'm the leader, it should kick them before reinviting. If I am not the party leader, it should first leave the party - the exception would be if I currently have a hero selected.
For this point, the people I'm targeting are already in the party, and I'm the leader, trying to reorder them. It makes no difference which way I target them. Right now I'm in a party of 4 of my own accounts, and /reinvite works correctly on just one member, regardless of how I selected them. When I put a different account as leader, it has the same problem, but with a different party member. Most of the time, targeting myself leaves and reinvites, but not always.

Following on from #918, it appears that there are multiple "parties" that make up an overall party, particularly when heroes are involved.  The parties are not necessarily the same between players.  On one account, my character with a hero has a different PartyInfo to the character without a hero - the former includes heroes and the latter does not; I assume to handle inviting and dismissing heroes independently of other players.
This is why I changed the IsPlayerInParty function to search through the players array of the reinviting characters' party - it is not identical functionality.  I likely did not explain that well enough in my quick PR before bed, however.

When I change the GetPlayerPartyMember function to not return, and instead use a breakpoint to output every party the player is in, I get these results for my second account (with no heroes in party):
Party found: 0x0000000f
Party found: 0x00000015
Party found: 0x00000019

I do not believe the GetPlayerPartyMember function is useful or really useable due to this, so I propose removing it and implementing the changed IsPlayerInParty function from #918.

I think you’re looking in the wrong place here - break on the error message that we’re addressing (I.e the one about the player not being in the party when reinviting) - according to you, at this point your new function returns true, but the original would return false in error. Inspect the result of the various affected gwca variables used in both methods to find the problem.
The point I’m trying to make here is that this is addressing a symptom to fix a specific use case, rather than figuring out what’s actually going on, which might later affect other features if we don’t address it. Regardless of if we simplify this function or not, the why is more important

Regarding the different party ids, I would understand if these were different for different players in an outpost - if 100 players had heroes, that would be 100 parties, but it may be that the server only assigns these to your client when it’s in range in an effort to manage memory better client side, so you’d perhaps only have 40 parties because you can only see 40 players

That is exactly what I did.  I placed a breakpoint on the if statement before the error message, refactored combined conditions into separate variables to inspect more easily, then dug down until I reached that code.  Admittedly I skipped the IsHenchmanInParty and IsHeroInParty as I could not observe any issues with reinviting them.

IsAgentInParty

IsHenchmanInParty/IsHeroInParty (skipped, guess I should check these)
GetPlayerByAgentId (works great)
IsPlayerInParty (doesn't work)

GetPlayerPartyMember (the out parameter will never work consistently)
GetPartyInfo (works fine)

To reiterate, my alt account was in three parties simultaneously, according to GetParties as run from my main account's client.  I chose to "address the symptom" because GetPlayerPartyMember is entirely unused other than this, and may indeed be unsound.  In hindsight, it is more likely that there is just old no-longer-used parties floating around in memory that GetParties may return until there is a cleanup, so doing reverse engineering work to figure that out might be the "morally correct" thing to do.
That said, the feature has been broken for a year.  I don't see any issue with slapping a bandaid on it, making a note of the potential backend issues, and coming back to them.

The point I’m trying to make here is that this is addressing a symptom to fix a specific use case, rather than figuring out what’s actually going on, which might later affect other features if we don’t address it.

sure, but since nobody has been able to find the root cause in almost a year since I created the issue, I (and probably plenty of other users) will be very grateful for the fix (=

Ah ok thanks for the break down, this is interesting because it tells us that the party array doesn’t mean what we thought it did in context, so the function that was causing the problem needs to be rewritten. I’ll merge this in when I’m at the pc again.
This stuff isn’t about morals or coding practice or any of that crap anyway, it’s about learning how the gw code behaves so we can interface with the game in a better way - helps to avoid weird bugs like this when the gw client doesn’t use variables like we think it does

I had a little look further into the other parts and while I haven't managed to observe issues with reinviting heroes or henchmen, I did manage to get a henchman to show as in multiple parties after combining parties that both had that henchman present, so there may indeed be more to fix.

Double check you're using the latest version, also worth asking if the player that its not working for has pending party invites on their end

No that’s fine, but if you can easily recreate the issue with your own alts then we can throw some test versions your way to debug the problem - let me know if you’re able


Upgrade to Cloud/Boot 2.0, add CORS support

Related to https://github.com/spring-cloud-stream-app-starters/app-starters-release/issues/134
See https://stackoverflow.com/questions/48675312/how-do-i-patch-the-spring-cloud-stream-http-source-app-starter-to-support-cors
Fixes spring-cloud-stream-app-starters/http#13

@artembilan it seems like there is a compilation issue:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project spring-cloud-starter-stream-source-http: Compilation failure
[ERROR] /Users/ctzolov/Dev/projects/scdf/tmp/merge-gh-12-http-source/http/spring-cloud-starter-stream-source-http/src/main/java/org/springframework/cloud/stream/app/http/source/HttpSourceConfiguration.java:[91,26] cannot access javax.servlet.Filter
[ERROR] class file for javax.servlet.Filter not found

Do the tests pass for you?

Rebased, squashed and merged at 3d089dc


Short solution needed: "How to rename key in Redis" (php-redis)

Please help us write most modern and shortest code solution for this issue:
How to rename key in Redis (technology: php-redis)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

How to rename key in Redis


Redesign segno-ui.com site

site-wide search
SPA (if possible)
maybe use sticky headers for long pages (see https://codepen.io/CITguy/pen/XgeboV for demo)

SegnoUI is a design system (for CITguy products) comprised of:

Principles
Color Palette
Typography Definitions
Custom Elements (+ core CSS)

interactive demos with code snippets

Grid and Spacing System
Voice & Tone

Optional/Unknown Requirements:

Sketch assets (may be able to automate, unsure at present)

Closing. Will be converting to Storybook to focus on the custom elements, rather than the entire design system.


Draft: NT4.1 support

Description
This pull request introduces support for NetworkTables v4.1 while maintaining backward compatibility with version 4.0. The primary goal is to enable seamless integration with NetworkTables servers that have upgraded to v4.1, while ensuring that existing functionality for v4.0 remains intact.
Currently, there are no tests written for 4.1, which should absolutely be added. All the tests for v4.0 still pass, with minor modifications to ensure that the code is running at 4.0 instead.
Changes Made
New Feature: Added support for NetworkTables version 4.1.
Compatibility: The code has been structured to preserve compatibility with NetworkTables version 4.0. The default behavior remains as it was for version 4.0, ensuring that users running older servers won't experience any disruptions.
Conditional Logic: Implemented conditional logic to detect the server's version during runtime. If the server supports version 4.1, the code will automatically switch to using the new features and improvements introduced in this version.
Questions for Reviewers
Are there any concerns about maintaining backward compatibility with version 4.0? Have we covered all possible scenarios where compatibility might be affected?
Have we implemented the conditional logic for version detection in an efficient and reliable manner? Are there any potential edge cases that we might have missed?
Are there any performance considerations or optimizations that need to be addressed to ensure the smooth operation of the code with version 4.1?

Any feedback and suggestions for improvement are highly welcomed.
Note: The changes for the documentation make PRs get a bit messy. Would it be worthwhile changing it so the docs build only on merges to main?

Hi, please merge in beta and run CI again. I took a quick glance... did we implement the PING and PONG requirements? Maybe RTT sufices

Not 100% sure what's needed for the PING and PONG. Most of the logic for this was pulled from AdvantageScope since they had already done the upgrade and have their own library for it.

hi @CrispyBacon1999 can you rebase? I got it working with 4.1 on the beta branch, but your code might have improvements

@CrispyBacon1999 If you have hardware to test this on, I rebased in beta

I don't have it tonight, but I should be able to test tomorrow if I remember to.

I was able to test the connection to a physical robot tonight and it worked perfectly! Connected properly over NT4.1 and I was able to poll values from the robot.


Adds support for statefulset worker deployment

This change allows Cribl workers to be deployed using a Kubernetes statefulset.  This is useful when using source or destination persistent queuing with EFS volumes as restarted pods will be re-attached to the correct persistent volume and the queue processed correctly.
To use a statefulset deployment configure the attribute deployment to the new value statefulset and
the new attribute extraVolumeMounts.claimTemplate to an object describing the persistent volume claim during deployment of the logstream-workergroup Helm chart.
Example
deployment: statefulset

extraVolumeMounts:
- name: persistent-queue
  mountPath: /opt/cribl/queues
  readOnly: false
  claimTemplate:
    metadata:
      name: persistent-queue
    spec:
      accessModes:
        - ReadWriteOnce
      resources:
        requests:
          storage: 20Gi

Important: Ensure when configuring your destination queues that the 'Queue file path' setting is set to /opt/cribl/queues.

Hi @grantjforrester, can you please ensure your PR contains new unit tests and fixtures (sample value files) that will have coverage for your changes? Thank you!

I have now added unit tests for StatefulSet deployment.


show me my repo ...

I searched my github repository (github.com/ghdwlsgur/govpn) on the goreportcard homepage, but I get the following error.
[error]
There was an error processing your request: Could not analyze the repository: could not download repo: could not get latest module version from https://proxy.golang.org/govpn/@latest: bad request: invalid escaped module path "govpn": malformed module path "govpn": missing dot in first path element
Initially the module name was govpn, I changed the module name to github.com/ghdwlsgur/govpn but I keep getting the following error.
Help me!!! 😭😭😭

@ghdwlsgur please try pushing a new tag -- the module name is incorrect in v0.1.2

Thank you for quick response !! 👍🏻👍🏻👍🏻
I will release a new release and come back.

https://goreportcard.com/report/github.com/ghdwlsgur/govpn
Oh yeah i'm so feel goooooooooooooood
solved it !!!! Thank you

@ghdwlsgur no problem, glad I could help 😄


CA certificate for TLS support

I suggest to add CA certificate support to this cookbook. We are using own CA certificate and probably a lot of people doing the same.
Also I did slight style fixes and added libcap-bin package as it is not coming with ubuntu-12.04

@murat1985 Please rebase and make changes I mentioned. After that this is :+1: to merge!

Rebased with a guard for debian family platforms. CentOS 7 has this binary in distribution. Local kitchen tests are green, thanks.

Not sure but we're still getting the error... try rebasing again?

I am removing the deploying of certificates from this cookbook. It has caused a lot of problems, and over the past few months I have decided its better left for a wrapper cookbook. We will supply a wrapper cookbook called vault-cluster which will deploy certificates using a custom resource.


Fix compiler warning on format string

I was getting compiler warnings on format string type mismatch:
[  6%] Building CXX object CMakeFiles/ClangBuildAnalyzer.dir/src/BuildEvents.cpp.o
/Users/brett/git/ClangBuildAnalyzer/src/BuildEvents.cpp:55:92: warning: format
      specifies type 'long' but the argument has type 'int64_t'
      (aka 'long long') [-Wformat]
  ...t1=%7ld t2=%7ld par=%4i ch=%4zi det=%s\n", i, (int) event.type, event.ts...
        ~~~~                                                         ^~~~~~~~
        %7lld
/Users/brett/git/ClangBuildAnalyzer/src/BuildEvents.cpp:55:102: warning: format
      specifies type 'long' but the argument has type 'long long' [-Wformat]
  ...%7ld par=%4i ch=%4zi det=%s\n", i, (int) event.type, event.ts, event.ts+event.dur...
     ~~~~                                                           ^~~~~~~~~~~~~~~~~~
     %7lld
2 warnings generated.

Superseded by #80


Fix scope for obtaining instantVisio token

Only a user who needs to use Premium video features needs a token
find the best spot where to place token obtention logic

Need to merge #330 before starting this one


Add confirmation page

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/13151
PROPOSAL: https://github.com/Expensify/App/issues/13151#issuecomment-1359691865
Tests

Go to concierge > Click call icon
Fill data > Request call
Verify you see a confirmation page with fireworks gif

Go to settings > security
Change password > Fill data > save
Verify you see a confirmation page with fireworks gif

Go to settings > payments > Add payment method
Bank account > Fill data to add the bank account
Verify you see a confirmation page with fireworks gif

Import and render TransferBalancePage in some other component (for example ProfilePage, don't forget to remove the code for profile page)
Return true in the if statement
https://github.com/Expensify/App/blob/3ecec61a503dd180f6d302d6f565f6ee4f114825/src/pages/settings/Payments/TransferBalancePage.js#L155
Go to the page where you rendered the TransferBalancePage
Verify you see a new gif for dark theme

Import and render ActivateStep in some other component
Go to the page where you rendered the ActivateStep
Verify you see a loading gif and there's no button
Make goldWallet true https://github.com/Expensify/App/blob/3ecec61a503dd180f6d302d6f565f6ee4f114825/src/pages/EnablePayments/ActivateStep.js#L39
Verify you see the confirmation fireworks gif and a button
Note: At ios you will see that the header is near the status bar. It is because in ActivateStep the ScreenWrapper isn't present as the parent because the parent component of ActivateStep already contains a ScreenWrapper.

Go to settings > workspaces >
Open a workspace > Connect bank account
Choose connect manually > Fill data > Save
Fill company info form and save
Verify you see a new gif for dark theme (Note: you will see the loading indicator first, the gif only shows up for brief moment)

[x] Verify that no errors appear in the JS console

Offline tests

No offline specific steps
QA Steps

Go to concierge > Click call icon
Fill data > Request call
Verify you see a confirmation page with fireworks gif

Go to settings > security
Change password > Fill data > save
Verify you see a confirmation page with fireworks gif

Go to settings > payments > Add payment method
Bank account > Fill data to add the bank account
Verify you see a confirmation page with fireworks gif

Go to settings > payments
Transfer balance > go through the steps
Verify you see a confirmation page with fireworks gif

Go to settings > workspaces >
Open a workspace > Connect bank account
Choose connect manually > Fill data > Save
Fill company info form and save
Verify you see a new gif for dark theme (Note: you will see the loading indicator first, the gif only shows up for brief moment)

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/101883770/209000410-0f10e9fd-3683-4e0b-a1de-3aa0189bee3a.mov
https://user-images.githubusercontent.com/101883770/209008565-45e59f86-9619-4d46-9408-4dc7abec051a.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

I found a bug (not related to the PR) on pressing cross at confirmation screen of transfer balance page it navigates to the payments pages instead of closing the modal

Thanks @Puneet-here. Changes are looking good. Will review it today.

@shawnborton Tagging you here for a review because I am jsut a bit concerneed about the background colour on some of the gifs. For example look at this:

I am not sure if it was raised in other places, but I could not see it in the comments. The Hex of the gif green bg does not seem exactly the same as the app background. You can also check the screenshots in the PR body from Puneet and you can see the colour different there too.
Since the images are hosted in cloud we can update that without touching this PR. so I think it is NAB, but wanted to note this

Good catch. I think we might have to live with this until we replace these GIFs with Lottie animations, where we will have perfectly crisp SVG animations and no background color.

That being said, I'll flag this to Augenblick and see if they have any ideas!

Great, thanks, wanted to get a confirmation this is not a blocker 🙇

Nice, these look great 🎆

Okay we have two new gifs we can try to fix the BG issue that @mountiny spotted, @Puneet-here can you test with these locally and show us some screenshots? If these look better, I will upload to Cloudfront.
animations.zip

@shawnborton, it still doesn't match completely with the background
https://user-images.githubusercontent.com/101883770/209223826-f23ceb57-b775-4745-a2d9-1782974605d4.mov

Okay no worries, appreciate you giving that a shot! I say we just keep what we have for now and we'll revisit these with Lottie down the road.

Thank you for updating that, I see this is not super enforced 🙇
We are missing a checklist from @sobitneupane :/

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @mountiny in version: 1.2.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@mountiny @shawnborton Can you pls validate the following steps internally? We do not have active wallet to be able to transfer. Rest steps we are QA-ing

Go to settings > payments
Transfer balance > go through the steps
Verify you see a confirmation page with fireworks gif

I see fireworks on the transfer page!

🚀 Deployed to production by @chiragsalian in version: 1.2.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Seems this PR caused a regression, i.e missed catching this bug where the welcome text is not centered in Spanish!

Thanks @Santhosh-Sellavel for linking the issue. Though the bug precedes this PR and was existent in some confirmation screens like PasswordConfirmationScreen and RequestCallConfirmationScreen, It should have been caught in this PR.


can't compile example code on osx

Hello. I'm trying to compile the single-export example on my OSX 10.9.3 machine. I do as instructed but get:
Undefined symbols for architecture x86_64:
  "_main", referenced from:
     implicit entry/start for main executable
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

What is this all about? Should I do something differently.

Possible reasons:
Apple has removed support for gcc, gcc is  symlink to Clang. Although Clang should be with
compatible gcc's frontend despite this. Nevertheless,  you can confirm that gcc is a symbolic reference to Clang by resolving the symlink:
$ readlink -f `which gcc`

The more likely reason is that dotc is not using Apple system headers:
#include "stdio.h"
#include "stdlib.h"

First, do what the error message suggests and pass -v what headers are causing to link... Please do this, if this still possible in 2016.
This is actually rather concerning. I hope that whatever linking actually failed. Thankfully, in this case, Apple's autocratic policies end-to-end control of their systems forces you to use their standard libraries, so custom standard libraries with voodo black magic will not work. :-P
Anyway you can fix this by simply changing all occurences of #include "watever.h" to #include <watever.h>. The second (angle brackets) refers to a system installed library.
gcc is the hardcoded compiler: https://github.com/substack/dotc/blob/master/bin/dotc but because you are an Apple user gcc $(CFLAGS) = clang $(CFLAGS) for all intents and purposes.


Do not save mat files version 7.3 for portability reasons... your view on this

Currently mat files are saved wth version 7.3, which is not Octave compatible:
getMatComment ~/Documents/DynaSimData/demos/demo_sPING_1/data/study_sim1_data.mat
ans = MATLAB 7.3 MAT-file, Platform: GLNXA64, Created on: Fri Sep 29 15:36:20 2017 HDF5 schema 1.00 .

Could we save mat files other than 7.3 by default for portability reasons?
I guess we could always use 'try catch' for mat files >2GB, and then use 7.3...

I think this was the main reason we started using v7.3 as a default: https://github.com/jsherfey/dnsim/issues/58 IIRC, the data size limitations without using 7.3 were extremely limiting.
That said, this shouldn't be hard to add as an option, like what @kupiqu suggested. We could also add an option that the 7.3 flag is simply removed if Octave is being used, rather than Matlab.
IMHO, the default should be 7.3, since

most people will be using Matlab, not GNU Octave
common DynaSim use cases and even just moderately long simulations will fail,
similarly, we shouldn't expect the average user to have to understand MAT file format differences/limitations
in the event of failure to save or reaching an error (if 7.3 were not the default in the second case above), DynaSim's current error handling is minimal and nonexistent in many places, so we'd have to specify add error handling to make it clear.

Sure, but why not trying saving other than 7.3 first inside a try-catch conditional?
The only reason to not doing it is because if it fails then it takes more time to save.
I agree on all the other things you said, but consider that even dsDemos fails running because it opens previously saved mat files, so portability is an issue.
Currently we cannot publish a paper saying we support Octave in DynaSim if even the demos of the paper don't work.
I guess we can do a hack to workaround the issue of the demos, but there is no portability of data between Matlab and Octave at all if we don't use try-catch...

for completeness, other mat versions have advantages compared to 7.3, like data compression, but yes, one cannot save beyond 2GB, which is important, no doubt of it

Of course, all what I'm saying would be transparent to the final user...

That's a good point, and another reason to do try/catch is that Octave may add capability of the same flag in the future. A try/catch block should catch the error very quickly.
It's also a great point that we need to fix this if we want to claim DynaSim works with Octave out of the box.

Another extra reason would be porting data easily e.g. from matlab to python or rlang. Not sure to what extent these languages can load mat files saved as v7.3, I think they can't, but I may be wrong

Is there a way to check whether DynaSim is being run inside Octave? If so, I like the idea of having an "octave_flag", and if it's true, saving without v7.3. That way you don't slow down saving of files for people running in Matlab.
Also, we need to think of an alternative solution for large data sizes in Octave. The "octave_flag" could trigger saving less of the data, as well, although I don't know how exactly to handle that.

I am firmly against an octave flag. There is no need for it as this can be totally automatized and make the whole thing transparent to the final user (we don't want an Octave user to run code and get errors and then have to look documentation to realize there is such flag, so he starts using it).

Making v7.3 the default for saving is not my first option either because of the portability rationale above, but that is not my decision to make, but of all of us as a team (weighted if you like), which I will respect, of course. But note that if that is decided, dsDemos must be changed such a way it doesn't raise errors in Octave. Somebody will have to work on this before submission of the paper (or change its content to omit Octave is supported).

Here, I would certainly understand and welcome the use of a flag: matversion_flag

Consistent with my view, I would suggest putting any version but 7.3 as default, and then within try catch errors, (a) set the flag to 7.3 if needed, as well as (b) inform the user that this can be set at startup in dsSimulate, etc.

This way, all code and data becomes portable unless strictly needed or explicitly decided so: the code detects the need, raising a warning (and being able to work around having to do it more than once, if there are several save instructions).
My 2cts

We could also highly recommend in documentation, even say so when running demos, that if someone is using matlab only and not interested in porting data to e.g. R or Python, then it is better to use matversion_flag to 1 (name of the flag can, and should, be changed to make it more explicit, but you get the point).

If we decide that v7.3 should be default, writing a matlab porting function that opens a mat file v7.3 and saves it v7 or below would also be interesting to have (valid for files that are < 2GB)
This would be useless for Octave users (that don't have access to Matlab) as they would not be able to use it anyway, but could be useful for Matlab users that want to port small amount of data to R/Python (as well as to Octave, although it's tricky to infer why a Matlab user would port from Matlab to Octave...)

In fact, Octave also has options to save files >2GB (the reason why there is no way to make this compatible with Matlab, I assume, comes from Matlab being closed, but that's another story...)
In any case we could save a flag as 1 by default for mat compatibility (or to 0 if we decided that it would be better to prioritize >2GB against portability), and try/catch would set it to 0 when needed (so it would use 7.3 for Matlab, and 'hdf5' for Octave, when striclty needed or desired).

Btw, please note that the limit of 2GB is applied to variables, not to the final size of the mat file. Sorry I was confusing this above.

I vote for using v7.3 as a backup in a try-catch block, for all the reasons
mentioned above. It also seems like the simplest solution.
On Wed, Oct 4, 2017 at 2:43 PM, kupiqu<EMAIL_ADDRESS>wrote:

Btw, please note that the limit of 2GB is applied to variables, not to the
final size of the mat file. Sorry I was confusing this above.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/DynaSim/DynaSim/issues/228#issuecomment-334251971,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQFlefJl8MNGyBWsdi_nHzFtTytto5ewks5so9G5gaJpZM4Psm0q
.

Current status in dev is mat files are saved as v7, unless an error in a try/catch block is triggered (Var > 2GB), then depending on reportUI, mat file is saved as either v7.3 or hdf5
Yet to do:
Flag to choose between portability-safe (v7) vs trycatch-safe (v7.3/hdf5).
Also, once implemented: when portability is active, it should nevertheless be switched once a catch is triggered (to avoid triggering further catch's), given that portability is not guaranteed anymore.

Done (commit 78003278ef911ca5065877a84f1d706bb295e7c7)


Duplicates texts in Blazor

Trying to use Mark.js in a server side Blazor project together with a DevExtreme Blazor Grid, I discovered that texts get highlighted but also non-hilghlighted text from other grid rows get duplicated back and forth to other cells.
My wild guessing is that the way Blazor manipulates the DOM inteferes with the way Mark.js does. Or it is something specific to the DevExtreme grid.
I removed the idea of using Mark.js (and other JS highlighting libraries) altogether for now.
While my issue report here is of very poor quality, I simply want to use it as a reminder for others that will come here to be aware of when using Blazor.

Hi,
Thanks for submitting.
Please read the contribution guidelines and provide the required information named there.

You can simply close this issue, unfortunately I have currently no time to investigate further and just wanted to note the Blazor relationship somewhere public.


Adding additional related resources links

Contributing to the Azure Architecture Centre after an MVP call with @EdPrice-MSFT

Docs Build status updates of commit c088099:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/example-scenario/apps/devops-dotnet-webapp-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

#Sign-Off

@EdPrice-MSFT,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Consumer stops receiving messages after group rebalance

Hi,
I'm regularly facing the issue when consumer stops receiving messages after group rebalance and the only way to fix that is to restart the process. After some investigation I found that the problem seems to be connected to DLQ producer. When group rebalance happens consumer.commitSync(...) throws CommitFailedException, this exception is then passed to error handler (see KafkaMessageListenerContainer) , and DLQ error handler fails with NPE as soon as exception has no associated message (see KafkaMessageChannelBinder). After that kafka-consumer thread quietly dies. With default error handler, exception is simply logged and consumer recovers processing.
Versions:
spring-cloud-stream-binder-kafka-1.1.0-RELEASE (not sure if the issue persists in later versions)
kafka-clients-<IP_ADDRESS>-cp1 (confluent platform)
Properties:
spring.cloud.stream.kafka.binder.auto-create-topics=false
spring.cloud.stream.bindings.input.destination=stream.test-input-topic
spring.cloud.stream.bindings.input.group=stream.test-group
spring.cloud.stream.bindings.output.destination=stream.test-output-topic
spring.cloud.stream.kafka.bindings.input.consumer.auto-commit-offset=true
spring.cloud.stream.kafka.bindings.input.consumer.enable-dlq=true
spring.cloud.stream.bindings.input.consumer.partitioned=true
spring.cloud.stream.bindings.input.consumer.concurrency=3
spring.cloud.stream.bindings.input.consumer.header-mode=raw
spring.cloud.stream.bindings.input.consumer.max-attempts=10
spring.cloud.stream.kafka.bindings.output.producer.sync=true
spring.cloud.stream.bindings.output.producer.header-mode=raw
Thanks!

Marking as bug. Possibly requiring a fix in Spring Kafka as well.

@andrewtyt Any chance you can re-test your scenario using the latest snapshots - 1.3.0.BUILD-SNAPSHOT? I could not reproduce the issue. However, I tried the same thing with 1.1.0.RELEASE of the binder also and 3 consumers in the same group are consuming from the topic even after a group rebalance (with dlq settings on the consumer is enabled). So, we need to understand how exactly you were able to get that commit exception. Thank you!

@sobychacko Please take a look at this sample, it simulates long-running message processing thus forcing group re-balance.
Steps to reproduce:
1 Run the sample on any non-empty topic
2 Verify that consumer thread exists, you can simply search by name "-kafka-consumer-1" in thread dump http://localhost:8080/dump
3 Wait until something like "...Error XXX occurred while committing offsets..." appears in log. On my local environment it fails on 1st or 2nd message
4 Check thread dump again, there should be no consumer thread

@andrewtyt Thanks for the sample. I ran it, however, my consumer was still processing messages after the error you mentioned. Here is a snippet from the log:
2017-09-07 13:16:49.851  INFO 76892 --- [afka-consumer-1] o.s.c.s.b.k.KafkaMessageChannelBinder$1  : partitions revoked:[sc_154.input-0]
2017-09-07 13:16:49.851 ERROR 76892 --- [afka-consumer-1] o.a.k.c.c.internals.ConsumerCoordinator  : Error UNKNOWN_MEMBER_ID occurred while committing offsets for group sc_154.group
2017-09-07 13:16:49.854  INFO 76892 --- [afka-consumer-1] o.s.c.s.b.k.KafkaMessageChannelBinder$1  : partitions assigned:[sc_154.input-0]
2017-09-07 13:16:49.856  INFO 76892 --- [afka-listener-3] sc_154.Configuration                     : Simulating long-running operation
2017-09-07 13:17:19.860  INFO 76892 --- [afka-listener-3] sc_154.Configuration                     : Simulating long-running operation
2017-09-07 13:17:49.861  INFO 76892 --- [afka-listener-3] sc_154.Configuration                     : Simulating long-running operation
.....
.....

@sobychacko Yes, processing goes on coz consumer thread [afka-consumer-1] fetches batch of messages from Kafka and another thread [afka-listener-3] processes messages from batch one by one. "Simulating long-running operation" just tells us that [afka-listener-3] thread is alive and processes rest of messages from current batch. And as I see from your logs there is no output from [afka-consumer-1] after ERROR line which means that consumer thread is actually terminated (otherwise it'd complain about re-balance) and no more messages will be fetched from Kafka.

@sobychacko I've improved sample a bit, now long-running logic is simulated for the first 5 messages only. At some point processing stops and no more messages are fetched from Kafka.

@andrewtyt thanks for further explaining the issue. The only way I can reproduce this issue is by using the Brooklyn version of Spring Cloud Stream which uses the 0.9 Kafka client. I upgraded your sample to use Chelsea (and spring boot 1.5.2 as parent) and Ditmars.M2 (and spring boot 1.5.6 as parent).  In both cases, I am not seeing the rebalance and the same listener thread keep consuming. Both Chelsea and Ditmars bring in the 0.10 kafka client and spring kafka 1.1.x.
Is upgrading to either Chelsea or Ditmars an option for you? Ditmars will be generally available before the end of this month.
Here is the log output from your sample using the Chelsea version:
2017-09-08 11:33:05.577  INFO 94909 --- [afka-consumer-1] o.a.k.c.c.internals.ConsumerCoordinator  : Setting newly assigned partitions [sc_154.input-0] for group sc_154.group
2017-09-08 11:33:05.591  INFO 94909 --- [afka-consumer-1] o.s.c.s.b.k.KafkaMessageChannelBinder$3  : partitions assigned:[sc_154.input-0]
2017-09-08 11:33:05.611  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:33:36.063  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:34:06.068  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:34:36.073  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:35:06.079  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:35:36.084  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:36:06.087  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:36:36.093  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:37:06.098  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:37:36.105  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:38:06.110  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:38:36.115  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:39:06.120  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:39:36.124  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:40:06.128  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:40:36.136  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:41:06.140  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:41:36.144  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:42:06.148  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:42:36.156  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:43:06.163  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:43:36.167  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:44:06.173  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:44:36.180  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:45:06.182  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:45:36.188  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:46:06.194  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:46:36.198  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:47:06.203  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:47:36.208  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
2017-09-08 11:48:06.213  INFO 94909 --- [afka-listener-1] sc_154.Configuration                     : Simulating long-running operation
......
......
......

@sobychacko Currently we're using Kafka server 0.9 on production so in our case upgrade to later version of Spring Cloud Stream in our applications is only possible with downgrade to 0.9 Kafka client. I've tested Chelsea + Kafka client 0.9 and the issue is still reproducible...
Anyway I guess the issue can be closed. As workaround we've disabled DLQ functionality and are planing migration to Kafka 0.11.
Thank you.

@andrewtyt 0.9 client will have this problem and using Chelsea with 0.9 client won't help. Will close the issue for the time being as this doesn't happen with 0.10 clients and later Scst versions. Please report if you see the same problems there. Thank you for the valuable suggestions above!

Closing the issue as the general recommendation is to upgrade to a 0.10 (or above) client.


Improve ockam vault default by displaying the default vault name when no argument is passed

Current behavior
If you run ockam vault default <NODE_NAME> then you can currently only set the default vault. If you run ockam vault default without any other arguments it results in an error like this:

Desired behavior
When no arguments are passed, it should display the default vault name.
Please take a look at this file to get started.
Please make sure that the bats tests and other Rust tests work after this change.

We love helping new contributors! ❤
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.

Hey @nazmulidris,
I would like to work on this.

All yours @am-a-man


In 2.0.0-beta.1 - Error: No value accessor for form control - when using md-input-container

Bug,:  In 2.0.0-beta.1, when using  md-input-container , the form page displays no input elements.  Using md-input,  the input elements display properly.
What is the expected behavior?
The CHANGELOG for beta.1 says
 "The <md-input> element is deprecated in favor of <md-input-container>. "

What is the current behavior?
When md-input is changed to md-input-container,  the input elements in the form do not display.
I have tried it with and without this import in the component managing the page
import { FormBuilder, FormGroup, Validators, FormControl } from '@angular/forms';

and the input elements do not display in either case. My app.module.ts loads FormsModule for all components.
What are the steps to reproduce?
This HTML works with MD 2.0.0-beta.1
<md-input id="country" name="country" class="required" aria-labelledby="country" [(ngModel)]="residenceModel.country"
  i18n-placeholder="select country placeholder" placeholder="Country" type="text"  size="30" maxlength="30">
</md-input>

When md-input is changed to md-input-container for just one input element, all input elements in the form cease to display.  There is no Console error.  The form just stops displaying input elements.
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd
What is the use-case or motivation for changing an existing behavior?
Behavior should match the statement in the CHANGELOG.  An error in one input should not break all other inputs elements.
Which versions of Angular, Material, OS, browsers are affected?
I' m using Angular 4.0.0-beta.1,  @angular/material": "2.0.0-beta.1" with Chrome and FF
Is there anything else we should know?
A similar Issue was filed and corrected in August.  Something seems to be broken again.

Well, the situation is not as bad as it looked.  I took the the CHANGELOG statement literally as "deprecated in favor of" meaning a direct substitution.  The new docs show that two other things happen - a wrapping and a change in the tag.  This code works.
<md-input-container>
<input md-input id="country" name="country" class="required" aria-labelledby="country" [(ngModel)]="residenceModel.country"
  i18n-placeholder="select country placeholder" placeholder="Country" type="text"  size="30" maxlength="30">

The CHANGELOG could be stated more clearly, but I could have looked at the docs first.  Closed.


Prep for 36.0.0

Which issue does this PR close?

Closes #3889.
Rationale for this change
Biweekly Release

What changes are included in this PR?
Update version to 36.0.0
See rendered changelog here: https://github.com/iajoiner/arrow-rs/blob/prep_for_36.0.0/CHANGELOG.md

Are there any user-facing changes?
Yes

@alamb @tustvold


media/UPDATE_REMOTE_MEDIA action is never called

When using the demo and monitoring the Redux State, I have noted the the UPDATE_REMOTE_MEDIA action is not called, and therefore the video stream from the user I am calling is never displayed.

This issue is related to https://github.com/ciscospark/spark-js-sdk/pull/493

@cseale, can you pul down the latest code and see if the issue has been resolved? We pushed out some updates to the sdk that should fix this issue.

@bzang yup can confirm this is resolved. Also experienced a strange issue where localhost was not being treated as secure in any browser I used. Don't know if it was related to any changes made to the SDK at any time or sounds familiar to you?
Either ways I will close this particular issue.


[TA] unified letter cases in sdk/textanalytics/azure-ai-textanalytics/README.md

Description
I unified some of the latter cases in sdk/textanalytics/azure-ai-textanalytics/README.md because the section names fluctuated, some are capitalized and others are not.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

Thank you for your approval!


Short solution needed: "Show hardware info in CLI" (ubuntu)

Please help us write most modern and shortest code solution for this issue:
Show hardware info in CLI (technology: ubuntu)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Show hardware info in CLI


♻Combine migrations

🏗Structure rewrite request

Tasks to be done:

[ ] Make sure no update migrations are present
[ ] Make sure no renaming migrations are present
[ ] Make sure no removing migrations are present

NOTE: Please do not update any column types while working on this issue, do not update the the names of columns, do not delete columns
Description

Combine all the migrations for the all to get rid of the update, renaming or deletion of columns in the migrations. This task is not a critical one but rather important one to keep the project structure as simple and as easy to follow for the team

✅Done --> see pr https://github.com/liberu-genealogy/genealogy-laravel/pull/39

✅Done --> see pr https://github.com/liberu-genealogy/genealogy-laravel/pull/39


feat: implement root_path parameter to App

Closes #37
I realize the docs could be a lot better, that will have to be done in a second pass

Codecov Report

Merging #63 (9d9eba7) into main (bba3161) will decrease coverage by 0.04%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   97.39%   97.34%   -0.05%
==========================================
  Files         141      142       +1
  Lines        4562     4594      +32
  Branches      590      595       +5
==========================================
+ Hits         4443     4472      +29
- Misses         75       77       +2
- Partials       44       45       +1

Impacted Files
Coverage Δ

xpresso/applications.py
96.87% <94.44%> (-0.54%)
:arrow_down:

tests/test_docs/advanced/test_root_path.py
100.00% <100.00%> (ø)

tests/test_routing/test_mounts.py
100.00% <100.00%> (ø)

tests/test_docs/advanced/test_websockets.py
92.00% <0.00%> (-8.00%)
:arrow_down:

@sm-Fifteen tagging you in case you care to review, otherwise I'll probably merge Monday or something


NIFI-12488: Add support for dynamic sensitive properties for the ExecuteProcess processor

Summary
NIFI-12488
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 21

Licensing

[x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[x] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[x] Documentation formatting appears as expected in rendered files

The build failed for me locally but on totally unrelated tests (Registry) so I assume it's okay.

Thanks for the quick reply @lfrancke. If you get to the point where you don't think you will be able to complete the changes, I recommend noting these details on the Jira issue for future implementation.

Thanks again for suggesting this improvement @lfrancke. Based on the current state of the PR and previous comments, I am closing it for now, but feel free to open it again if you have the opportunity to work through the rest of the Processor and implement the additional changes necessary.

I'm sorry for the silence. Thank you!
I'm back with the customer that requested this only in February and might pick it up then, we'll see if they are still interested.


Mix doesn't respect hue angle specification

Problem
I was trying to recreate some of the examples from the CSS 5 mixing drafts, as this project seems to be a playground for expressing those ideas, and I realized I could not get mix to recognize the specified angle adjuster to use:
new Color('lch(52% 58.1 22.7)').mix('lch(NaN NaN 257.1)', 1 - 0.7523, {hue: "shorter", space: "lch"});
// lch(52% 58.1 351.6)

new Color('lch(52% 58.1 22.7)').mix('lch(NaN NaN 257.1)', 1 - 0.7523, {hue: "longer", space: "lch"});
// lch(52% 58.1 351.6)

Expectation
In the above examples, I would expect that when longer was used, the return would be:
new Color('lch(52% 58.1 22.7)').mix('lch(NaN NaN 257.1)', 1 - 0.7523, {hue: "longer", space: "lch"});
// lch(52% 58.1 80.761)

I suspect this is unintentional and should be able to replicate such examples in the color 5 spec.

Yes, this project is indeed being used as a playground for CSS Color 4, CSS Color 5,CSS Color HDR and CSS Typed Object Model.
By the way why are you setting L and C to NaN? As far as I recall, we only have special handling for NaN on hue (for achromatic colors). However, yes you should be getting a different angle there; this is a bug.
new Color('lch(52% 58.1 22.7)').mix('lch(52% 58.1 257.1)', 1 - 0.7523, {hue: "longer", space: "lch"});

In fact it would be nice if people could type examples straight from CSS Color 5 and they worked, instead of having to transform the syntax as you did. But that should be a separate issue.

The hue interpolation keyword handling

By the way why are you setting L and C to NaN?

Because it works and it is unclear that this wasn't supposed to be allowed. The code will return the other channel (for any channel) if the other is NaN.
The official docs actually do this, just not directly through the string.
// Two kinds of fade out to transparent
lime.range(new Color("transparent"));
lime.range(new Color(lime.space, [NaN, NaN, NaN], 0), {space: lime.space});

Related, the API documentation for the options object for color.range() does not mention the hue option, although the interpolation docs use it in examples. And when it is not used, the default does not seem to be shorter.

This issue was resolved by #338


Delete leftover clusters selected and wizard reducers in UI

Description
Noticed in logimbue-data.json file while investigating integration test failures.
Goals

Reserve global store for authentication, authorization, and feature flags.
Delete leftover requests in sagas for unused container-specific data in global store.
Delete unused container-specific data from global store.
Move container-specific data from global store, so cause-and-effect is clearer within containers and as prerequisite for future container plugins.

Residue

Investigate unrelated error in local deployment several seconds after clicking Next when creating new cluster.
Investigate whether there are any references to search reducers:

searchOptions
searchModifiers
searchSuggestions

Although cluster sagas are not strictly needed, because network sagas request clusters directly instead of indirectly via action, wait to delete (see next point).
Delete clusters reducer after Network Graph makes its own request instead of the following references:

Containers/Network/Page.js
Containers/Network/Graph/Graph.js
Containers/Network/Header/ClusterSelect.tsx

Checklist

[x] Investigated and inspected CI test results
[x] ~Unit test and regression tests added~

Testing Performed

yarn build in ui
wc build/static/js/*.chunk.js in ui

branch - master: -6343 = 9493869 - 9500212

yarn start in ui

manual testing

/main/network

See /v1/clusters request
See no temporary console log, because network sagas request clusters directly instead of indirectly via action

/main/clusters

See change from empty array to non-empty array for searchModifiers and searchSuggestions but not searchOptions
Create cluster (see residue)

Regarding Residue:

This happens to my local deployment as well.
It looks like the only instance of getClustersSearch* is in Containers/Clusters/ClustersPage.js and is an unused prop for that component. There are 4 instances of setClustersSearch* (1 in the former file, 3 in searchSagas.js) but all should be able to be deleted since they are never accessed anywhere.


Feature 512  fixing Bar File Export

PR for fixing Issue #512

ok to test

ok to test

ok to test

ok to test

ok to test

ok to test

ok to test

ok to test

Bar file version up is necessary.


Positioning

How can I set the (absolute) position of the editor? There are no top, left, height, width properties.
I currently use  $('.rich-text-editor.view.expand').css('top','160px'); but this doesn't work if there is more than one editor since they all have the same classes and there are no id or name attributes to differentiate between them.

Wrapping it with a custom element?
<div style="position:absolute;top:0;left:0;">
  <textarea></textarea>
  <script>new RTE(document.querySelector('textarea'));</script>
</div>

Thank you so much!


Add block/boolean NSPredicates, NSCompoundPredicate, and NSArray predicate method

I added some of the NSPredicate implementation, including block predicates and true/false predicates, NSCompoundPredicate (which should be complete I believe), and an implementation to NSArray.filteredArrayUsingPredicate.
My current simple NSPredicate work only works with nil for substitution bindings since I don't fully understand how those work yet, or if they're even applicable to block based predicates.
"Not" compound predicates trigger a precondition if the array of subpredicates is empty. This is similar to what happens in Foundation on Apple platforms.

Patch looks good, but the compiler crashes on linux when compiling NSCompoundPredicate. =(
I'm investigating, but in the meantime can you rebase so that we don't have commits with the wrong license in them in the project history?

https://bugs.swift.org/browse/SR-204

Actually there is some confusion here about required/convenience initializers; Darwin Foundation doesn't correctly mark them so there is nothing to go on except to look at what happens there.
I think the block initializer may also be a problem, since technically it's a factory method and returns an instance of NSBlockPredicate instead of storing the block in the NSPredicate superclass.

To work around the factory method problem, I guess NSPredicate just has to gain knowledge of these modes (block, permanent true/false, etc) instead of using a subclass.
In any case I can't seem to figure out how to work around the compiler crash at the moment.

I'm setting up a linux env to test on so I can try to figure out what's going on too. I'll rebase later tonight as well

Just rebased against latest master. I also rewrote NSPredicate a little bit to use a private enum to represent the different predicate types in a more idiomatic swift way. This had led to a small change on NSCompoundPredicate, which may compile on linux now (I can't seem to build swift on ubuntu 15.10 due to some odd linker issues I have not yet resolved so I can't verify this).
On a slightly unrelated note (though present in the PR) I encountered an API issue here (also with Darwin foundation) which I notified the swift-corelibs-dev list about, and I'm prepared to make a proposal to swift-evolution if necessary to fix it, unless it's just a nullability bug on apple's end: https://lists.swift.org/pipermail/swift-corelibs-dev/Week-of-Mon-20151214/000170.html

I've finally gotten a working linux environment I can test in. I figured out the compiler bug; in NSCompoundPredicate if the subpredicates array is of type [NSPredicate] the compiler does not crash; there must be some issue compiling code that does implicit upcasts to [AnyObject]. I will update SR-204 with this info as well.

changing the test to
func test_filterNSArray() {
        let predicate = NSPredicate { (obj, bindings) -> Bool in
            return (obj as? NSString).map({ $0.length <= 2 }) == true
        }

        let array = NSArray(array: ["1".bridge(), "12".bridge(), "123".bridge(), "1234".bridge()])
        let filteredArray = array.filteredArrayUsingPredicate(predicate).map { $0 as! NSObject }

        XCTAssertEqual(["1".bridge(), "12".bridge()] as [NSObject],
                       filteredArray)
    }

works around the compiler crash

I didn't encounter a crash in the tests; by changing the type of the array I was also able to work around the crash. I havent used more recent builds of swift though so maybe something else was introduced that broke it there. If I have time this weekend I'll look at it.

Thanks for this pull request!! swift-corelibs-xctest requires a usable NSPredicate in order to implement -[XCTestCase expectationForPredicate:evaluatedWithObject:handler:] -- see SR-907 for details.
Is there any way we can help get this pull request merged? Is it possible that rebasing and testing with the latest Swift compiler may resolve the crash?

I can certainly rebase with master and test again in the next couple of days. If the API changes to this are still necessary to work around the crash (changes i would argue are warranted even if the crash is fixed), is it OK to leave them in?

Let's get it rebased first, then we can run it through CI and see if the crash is fixed at least.

Just rebased, and undid the change that caused the crash on linux. I don't have my linux environment handy, but it compiles on the latest development snapshot toolchain on os x.

@parkera Could you ask @swift-ci to please test? :bow:

@swift-ci Please test

Yup, looks like a segfault in the compiler. Maybe put the workaround back in?

I made a change that might work, but I can't test in linux right now. This change keeps the external API in sync with Darwin Foundation but tries to explicitly cast to [AnyObject] from [NSPredicate]. Could someone kick off a ci test? If this fails, then I can try changing the subpredicates property back to [NSPredicate] but that will bring the APIs out of sync again, unless the radar I filed awhile back (rdar://23894694) will be addressed this summer.

Looks like it's no good, there's still a segfault. I have access to a Linux machine, I'll try to find a workaround on my end as well.

Thanks! If nothing else works I will make the change that alters the API.

On Apr 6, 2016, at 2:34 PM, Brian Gesiak<EMAIL_ADDRESS>wrote:
Looks like it's no good, there's still a segfault. I have access to a Linux machine, I'll try to find a workaround on my end as well.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/apple/swift-corelibs-foundation/pull/127#issuecomment-206506553

@klundberg What change would that be? Sorry if it's already somewhere above, I'm having trouble finding it.

I had changed the type of the subpredicates property from [AnyObject] to [NSPredicate] to work around the crash initially, but that's not what the type is in Darwin Foundation, so that would be an API incompatibility if we introduced it to work around the compiler bug.

On Apr 6, 2016, at 4:47 PM, Brian Gesiak<EMAIL_ADDRESS>wrote:
@klundberg https://github.com/klundberg What change would that be? Sorry if it's already somewhere above, I'm having trouble finding it.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/apple/swift-corelibs-foundation/pull/127#issuecomment-206559290

There is a current open bug to rename that to be properly generically qualified so; lets err on the side of ambition and claim that will be resolved in favor of changing it. The differential shouldn't hold this up (just is worth noting)

@phausler thanks for the go-ahead. I was hoping this would be the case since it's clearly the better API :)

Cleaned up my commits, undid some testing changes I forgot to undo before committing last time, and rebased!

Cool, let's run this through the tests one more time.

@swift-ci please test

Looks like a different crash than before. I'll fix it up tonight or tomorrow and try to get my linux VM in a state that I can test with myself.

filteredArray as! [NSObject] can be re-written as filteredArray.map { $0 as! NSObject } perhaps that might work-around the crasher?

That might work; I came up with what I think is a simpler approach though: test NSArray objects for equality, not swift arrays. No need for fancy casting workarounds in that case..

Simpler in this case is better. Especially when we have a persistent compiler crash lurking in the shadows.

@swift-ci Please test


Update to GHC 7.10

Still needs:

[x] aschem to be updated
[x] Convert tabs to spaces since 7.10 has -fwarn-tabs by default (https://ghc.haskell.org/trac/ghc/ticket/9230)

This is ready for review.
I can successfully compile and run the eTeak GUI with these changes. In order to compile, though, I had to remove the hooks in Setup.hs to make the manual, since I get inconsistent errors during that process.


Would be great if you can share some dialog examples first

Hi Prof, the dataset is released now. Any questions can be asked here.

Thanks a lot!
On Sun, Sep 19, 2021, 11:57 AM Tom Young @.***> wrote:

Hi Prof, the dataset is released now. Any questions can be asked here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tomyoung903/FusedChat/issues/2#issuecomment-922495924,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7IU7U32PCZKAWKUO7PVP3UCYB45ANCNFSM5EE6YTLQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


fix: Correct variable name from response_jsonpath to records_jsonpath

Background
I wanted to use this tap to extract a list of jobs from dbt and port that over to target-snowflake. When I went to run the tap, I only got one record back and a warning message:
time=2023-03-15 13:57:02 name=tap-dbt level=INFO message=Properties ('status', 'data', 'extra') were present in the 'jobs' stream but not found in catalog schema. Ignoring.
{"type": "RECORD", "stream": "jobs", "record": {"account_id": "1"}, "time_extracted": "2023-03-15T00:57:02.160870Z"}

Looking at the response JSON from the API, the keys:

status
data
extra

Are top-level keys in the JSON. I then found that there is a variable called response_jsonpath in the streams.py program, which looks like it should go and get the data from the data key.
response_jsonpath = "$.data[*]"

However it is incorrectly named. The correct property is named records_jsonpath:
https://sdk.meltano.com/en/latest/classes/singer_sdk.RESTStream.html#singer_sdk.RESTStream.records_jsonpath
Change
Replace response_jsonpath variable name with records_jsonpath to use the correct property in the Meltano Singer SDK.
Testing
Upon changing the variable name, valid output was produced:
tap-dbt --catalog jobs.json --config config.json
time=2023-03-15 14:01:12 name=tap-dbt level=INFO message=tap-dbt v0.3.0, Meltano SDK v0.7.0
time=2023-03-15 14:01:12 name=tap-dbt level=INFO message=Skipping parse of env var settings...
time=2023-03-15 14:01:12 name=tap-dbt level=INFO message=Config validation passed with 0 warnings.
time=2023-03-15 14:01:12 name=tap-dbt level=INFO message=Skipping deselected stream 'accounts'.
time=2023-03-15 14:01:12 name=tap-dbt level=INFO message=Beginning full_table sync of 'jobs'...
time=2023-03-15 14:01:12 name=tap-dbt level=INFO message=Tap has custom mapper. Using 1 provided map(s).
{"type": "SCHEMA", "stream": "jobs", "schema": {"properties": {"id": {"type": "integer"}, "account_id": {"type": "string"}, "project_id": {"type": "integer"}, "environment_id": {"type": "integer"}, "name": {"type": "string"}, "dbt_version": {"type": ["string", "null"]}, "triggers__github_webhook": {"type": "boolean"}, "triggers__schedule": {"type": "boolean"}, "triggers__custom_branch_only": {"type": "boolean"}, "execute_steps": {"items": {"type": "string"}, "type": "array"}, "settings__threads": {"type": "integer"}, "settings__target_name": {"type": "string"}, "state": {"type": "integer"}, "generate_docs": {"type": "boolean"}, "schedule__cron": {"type": "string"}, "schedule__date__type": {"type": "string"}, "schedule__time__type": {"type": "string"}, "created_at": {"type": "string"}, "updated_at": {"type": "string"}, "deferring_job_definition_id": {"type": ["integer", "null"]}, "lifecycle_webhooks": {"type": "boolean"}, "lifecycle_webhooks_url": {"type": ["string", "null"]}, "is_deferrable": {"type": "boolean"}, "generate_sources": {"type": "boolean"}, "cron_humanized": {"type": "string"}, "next_run": {"type": ["string", "null"]}, "next_run_humanized": {"type": ["string", "null"]}}, "type": "object"}, "key_properties": ["id"]}
time=2023-03-15 14:01:12 name=tap-dbt level=INFO message=INFO METRIC: {'type': 'timer', 'metric': 'http_request_duration', 'value': 0.477716, 'tags': {'endpoint': '/accounts/{account_id}/jobs', 'http_status_code': 200, 'status': 'succeeded', 'context': {'account_id': '1'}}}
time=2023-03-15 14:01:12 name=tap-dbt level=INFO message=Properties ('run_generate_sources', 'raw_dbt_version', 'deactivated', 'run_failure_count') were present in the 'jobs' stream but not found in catalog schema. Ignoring.
{"type": "RECORD", "stream": "jobs", "record": {"execution__timeout_seconds": 0, "generate_docs": false, "id": 213, "account_id": 1, "project_id": 1, "environment_id": 2, "name": "My Job Name", "dbt_version": null, "created_at": "2021-11-23T21:22:55.966932+00:00", "updated_at": "2021-11-24T02:33:01.090718+00:00", "execute_steps": "[\"dbt run -s some_models\"]", "state": 1, "deferring_job_definition_id": null, "lifecycle_webhooks": false, "lifecycle_webhooks_url": null, "triggers__github_webhook": false, "triggers__git_provider_webhook": false, "triggers__custom_branch_only": true, "triggers__schedule": false, "settings__threads": 4, "settings__target_name": "uat", "schedule__cron": "0 * * * *", "schedule__date__type": "every_day", "schedule__time__type": "every_hour", "schedule__time__interval": 1, "is_deferrable": false, "generate_sources": false, "cron_humanized": "Every hour", "next_run": null, "next_run_humanized": null}, "time_extracted": "2023-03-15T01:01:12.915643Z"}

Cheers for the approval and merge 🥳 . I am only able to get 100 records out for the job list, so I may be raising another PR at some point to update the JobsStream to use pagination (once I get my head around it 😄 )


New esp-hal release

Oops, almost forgot to update the documentation index 😅  (This will by automated before the next release, already working on it)


Update What's new

[Enter feedback here]
What's new only, doesn't go into any of our docs.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f30dbb9e-d64d-a925-01ca-00d9d035e6c1
Version Independent ID: f30dbb9e-d64d-a925-01ca-00d9d035e6c1
Content: What's new in ASP.NET Core 8.0
Content Source: aspnetcore/release-notes/aspnetcore-8.0.md
Product: aspnet-core
Technology: aspnetcore-releasenotes
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Associated WorkItem - 115462

@Rick-Anderson Is this for preview 5 only or 1-5?

@Rick-Anderson Is this for preview 5 only or 1-5?

Hopefully 1-5

I made other issues for 1-3, and you made one for 4 that I self-assigned, so this one can be for Preview 5 only.


Applicant Receipt Upload Interface

What data does the user need to provide along with the uploaded file?

Hey @dpoirier! Thanks for working on this.
Ideally, they'd put in a USD amount. Right now, this process involves them e-mailing me documents, and me opening them, checking the amount, converting to USD as necessary, and then saving them.
For accounting/tax reasons, their expenses need to cover their grant. It'd be cool if the website showed this (since it knows about both the grant size and the sum of all expenses), but that's not a critical feature. Since we have CSV export, I can totally do that manually :)
I'm the emeritus chair, so feel free to ping me if you have any further FA specific things :) @ashfall is the new FA chair, she should probably also get pinged :)

@lvh @ashfall
Do you want any text to go with the receipt upload?  I was assuming you'd want things like what the receipt was for, maybe a date, that kind of thing?
besides just uploading receipts, what do applicants need to do with them? do they need a list of uploaded receipts?  do they need to be able to delete them?  edit them?

The minimal feature set is an append-only upload field + dollar amount field. A description field would be a cool extra, and I guess it wouldn't be that much more work. Editing does happen occasionally, but it's fine if that's just the admins doing that through the Django admin interface or something: that's a rare event, and it's important we know when this stuff changes & why :)

Okay @dchukhin let's not do delete or edit then, but I think we can add a description field quite easily so let's do that.

sounds good; user will not have the ability to delete their uploaded receipts, but will be asked to provide a desription

@lvh @ashfall under what circumstances should we show the "upload receipts" button to users on their dashboard?  I would think they should have applied for aid and have accepted an offer (application is in "accepted" state); is that it?

That sounds about right: They should have applied for aid, we should've extended a grant offer, and they should've accepted our offer of the grant.
Thanks for working on this!

Confirmed.
Sent from my iPhone

On Aug 2, 2015, at 14:08, Ashwini Oruganti<EMAIL_ADDRESS>wrote:
That sounds about right: They should have applied for aid, we should've extended a grant offer, and they should've accepted our offer of the grant.
Thanks for working on this!
—
Reply to this email directly or view it on GitHub.

@dchukhin there you go, application should have status STATUS_ACCEPTED to show the upload receipts button.

thanks; this has been updated in the pull request

Fixed in #427.


Unable to create instances, front end issue

I have tried multiple browsers and I have not been able to create instances. It seems like this may be a front end issue since I am able to click on "create instances" up to 5 times before it grays out. Edge keep getting 500 error messages as well.


Repeater entering INVALID state on child running

https://github.com/aigamedev/btsk/blob/8124c3e73719a05638a053782a749d039ae7cedf/BehaviorTree.cpp#L205
Is this intended? What I'm seeing is that following this logic, the Repeater as soon as one of the children is in running phase, will return INVALID as it's status.
This will in turn go back to the base class Behavior that will see that the status != RUNNING, and terminate the behavior.
Since the implementation of a basic Repeater has an empty ::onTerminate seems like nothing is effected if that's a top level node. However the side effects show as soon as it is used to repeat a set of actions further down the tree.
Shouldn't it return a RUNNING state instead?
Maybe I'm misinterpreting the intended behavior, as we want the action to be repeated quickly in the same frame / context?
One of the examples from the aigamedev paper says "shootPlayer" 3 times. If that is a sequence in itself, (like imagine an old sniper rifle: reload, aim, shoot, reload, aim, shoot..) each phase may have a short running period.
If that's not how it is intended ok, but otherwise I see that as a potential problem.
Thank you

// Inside Repeater::tick() method
for (int i = 0; i < repeatCount; ++i) {
    // Execute the child node
    Status childStatus = child->tick();

    if (childStatus == BH_RUNNING) {
        // If the child is still running, return BH_RUNNING
        return BH_RUNNING;
    } else if (childStatus == BH_FAILURE) {
        // Handle failure (e.g., repeat or exit)
        return BH_FAILURE;
    }
    // Handle success (e.g., repeat or exit)
}
// All repetitions completed, return BH_SUCCESS or BH_FAILURE based on the logic.


Namecalling the result of a binary/ternary expression containing a literal causes type inference to fail to complete

The following code gives a "Type inference failed to complete" error and generates a blocked type error on strict mode:
local test = if true then "hello" else "goodbye"
test:upper()

This seems to happen with any binary or ternary expression that includes a literal, which later gets namecalled. The same thing happens with this code, and many similar variations:
local test = true or true
test:a()

Didn't realize this was already reported minutes before in #1508


docs: add VLMedia to users list

VLMedia added to user list

Codecov Report

Merging #11386 into master will decrease coverage by 4.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11386      +/-   ##
==========================================
- Coverage   65.79%   60.94%   -4.86%
==========================================
  Files         838      838
  Lines       39903    39889      -14
  Branches     3662     3662
==========================================
- Hits        26254    24309    -1945
- Misses      13548    15399    +1851
- Partials      101      181      +80

Flag
Coverage Δ

#cypress
?

#javascript
62.67% <ø> (ø)

#python
59.90% <ø> (-1.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86f779...eb2a43e. Read the comment docs.

Thanks for the contribution! Would you mind adding your GitHub alias next to the link (see e.g. komoot above).

done

Welcome aboard!


srp_energy component not working: Value error connecting to SRP. too many values to unpack (expected 4)

Getting an error on startup when using the srp_energy component.
Error: Value error connecting to SRP. too many values to unpack (expected 4)
Config:
- platform: srp_energy
  username: !secret srp_username
  password: !secret srp_password
  id: !secret srp_id

AdrianG on the forums is getting the same error: https://community.home-assistant.io/t/srp-energy-sensor-added-in-83-not-working-getting-errors/81804

Seems like this issue is caused by the data containing an unexpected extra column. In my case this is the 'rate' column that defines whether the power was consumed on-peak or off-peak.
Here are the parts of the code that are probably throwing the error:
        history = [{
            ATTR_READING_TIME: isodate,
            ATTR_READING_USAGE: kwh,
            ATTR_READING_COST: cost
            } for _, _, isodate, kwh, cost in self._usage]

            for _, _, _, kwh, _ in usage:
                daily_usage += float(kwh)

I'm not sure what the solution is, since it seems like not everyone will have this extra 'rate' column.

Has there been any progress on this?  I would be happy to provide test data or do what I can to help.

No progress from me on this. I will see what I can do this week. It should be a relatively easy fix I just don't have any kind of HomeAssistant development environment setup right now.

It looks like this was fixed in srpenergy 1.0.6  and pushed to PyPI so if we change line 22 to
REQUIREMENTS = ['srpenergy==1.0.5']
and update the package it may work.

@keassol Please test my PR #22307. Will merge it once I hear back from you.

FYI, just tested this as a custom component and it works.  No more error and the sensor is being loaded with the data from SRP.

@keassol Mind marking that PR "approved" then?


Use Vim builtin 'strftime' to create timestamps in logs.

Just stumbled upon the TODO while reading the code, so here is a solution.
Disclaimer: I have not actually tested the code on other platforms, but it did not break anything on my Linux and according to https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx all the format characters used here are supported on Windows.
Edit: just realized the call to cat below is not cross-platform, but I am not aware of an easy way in Vimscript to append a string to a file (without reading the entire file first).

Thanks. Every little step toward cross-platform is a good one!


Use scoped styles for the CSS fade transition styles

Description of changes:

Turn the fade-enter/leave styles into aphrodite scoped classes, to not conflict with other global fade-enter/leave/active css classes.

Checks:

[x] Please confirm npm run lint ran successfully
[x] Please confirm that only /src and /examples/src are committed

This is a really old PR so I'm going to close it.
If it still applies, please open a new PR with rebased changes.


Forgotten double underscore for useage?

https://github.com/johnwparent/APBPoster/blame/master/installing.rst#L17

Good catch, that is supposed to be a link placeholder.


Update title of AutoPlay Carousel section of Carousel demo (#5643)

this closes #5643

@Rajneesh2223 Thanks for you contribution.


make fetch callback argument always object

Coverage decreased (-0.0%) to 95.01% when pulling e7aba4800ca1a174e332c5476a76663b0eaa9503 on make-fetch-arg-always-object into b0cae7786cd68c8077e1d66f7490755769116ca9 on master.


Phase 3: Remove IBM license header

Once all the Apache OW repos. correctly reference this repo for use of "scancode";  we will remove the "ApacheIBMLicenseHeader.txt" as all source should use one of the official Apache headers.

Is ok to remove I we use the tool by our own config

long since done


Commit files to doc-build(-dev)? using Github GraphQL

Problem: read more here

Cloning it in a GitHub Action workflow takes about 4 minutes, even with a --depth 1

Solution: as suggested by ~@LysandreJik~ @julien-c (edit by @LysandreJik), use Github GraphQL createcommitonbranch mutation. And this PR does that
I've tested it on accelerate here and it is working here
btw, can confirm that pushing with GraphQL is way fater since we do not need to clone doc-build-dev (which is roughly 30GB in size atm)
todo (note for myself):

[ ] revert to main branch use in ref for the doc-builder checkout

as suggested by @sgugger, renamed command doc-builder commit -> doc-builder push

Thank you all for the kind words. Obviously, I am learning from the best team, and excited to keep learning and keep the momentum going!

When I tested on transformers, I needed this change:
https://github.com/huggingface/doc-builder/blob/59e8f863bc878ed2b62403500c6bcd5f26003710/src/doc_builder/commands/push.py#L70-L75
Here, you can see output of a successful run (23 seconds vs ):
create_additions took 0.3139 seconds or 0.01 mins
Committed additions chunk: 1/4
Committed additions chunk: 2/4
Committed additions chunk: 3/4
Committed additions chunk: 4/4
commit_additions took 21.2038 seconds or 0.35 mins

please let me know wdy about this change @LysandreJik @sgugger @julien-c


Syntax error

How can the following syntax error be resolved:
SyntaxError: Unexpected token < in JSON at position 0
at chrome-extension://fkkiamalmpiidkljmicmjfbieiclmeij/dist/chromeiql.js:60748:23

I see this when I am not authenticated with the endpoint I'm trying to query

Is there any provision for setting Headers? Because I think I will need to set some headers to set the endpoint correctly.

I see this when I am not authenticated with the endpoint I'm trying to query. It could also indicate the endpoint is generally unavailable or set up incorrectly. You might try a known test endpoint like https://fakerql.com/graphql

Webiste is not available, getting the same error as @sra-013. Did you fix it?


ModLog: fix AttributeError in on_member_update

Sentry Issue: BOT-4R
AttributeError: 'Role' object has no attribute 'get'
  File "discord/client.py", line 312, in _run_event
    await coro(*args, **kwargs)
  File "bot/cogs/moderation/modlog.py", line 511, in on_member_update
    new = value.get("new_value")

Unhandled exception in on_member_update.

The iterable_item_removed and iterable_item_added diffs only contain the actual value added or removed (e.g. a discord.Role in the above error) rather than having a new_value and an old_value. The code was incorrectly trying to access old and new values for the iterable changes. I've completely removed the need for these iterable diffs. The commit message goes into slightly more detail.
I also removed code that checked diffs for discord.User attributes. The on_member_update event won't be dispatched for those attributes (I got confirmation the old code didn't work by examining old logs). Instead, on_user_update should be used. Should this event be implemented, or are logs for the user, discriminator, and avatar not needed?

In that case, I'll base a new branch off this one and refactor the cog along with adding on_user_update. There's currently a lot of redundant code. I'll leave this PR alone cause it doesn't remove any functionality we didn't already have.


The downlink can't be sent in the Class-B mode.

Is this a bug or a feature request?
Bug
What did you expect?
In the Class-B mode, the ping-solt downlink should be sent from the forwarder side.
What version are your using?
ISM Band : EU868
Beacon Packet Forwarder for Lora Gateway :  4.0.1
Lora concentrator HAL library version info : 5.0.1
End-Node : LoRaWAN1.1
LoRa Gateway Bridge : 2.4.1
GNSS module : GMM-G3
Could you share your log output?
I tested the class-b function but alway get the jit error during downlink, the value in the tmms field from JSON down message seems wrong so the ping-solt downlink is always rejected by forwarder side,  the  logs as below,
*. On the end-node side log
Network Joined
~DEVICE_STATE_REQ_BEACON_TIMING
Frame send
~DEVICE_STATE_BEACON_ACQUISITION
MLME_BEACON_ACQUISITION, Received Acquisition.

*. On the forwarder side log
….
JSON down: {"txpk":{"imme":false,"tmms":1217653456000,"freq":869.525,"rfch":0,"powe":14,"modu":"LORA","datr":"SF12BW125","codr":"4/5","ipol":true,"size":23,"data":"oAys0wGFBAADVwcAAQozTmQZLi4QsYM=","brd":0,"ant":0}}
INFO: [down] a packet will be sent on timestamp value 344686124 (calculated from GPS time)
src/jitqueue.c:140:jit_enqueue(): Current concentrator time is 346122413, pkt_type=1
src/jitqueue.c:251:jit_enqueue(): ERROR: Packet REJECTED, timestamp seems wrong, too much in advance (current=346122413, packet=344686124, type=1)
ERROR: Packet REJECTED (jit error=2)
……
*. The downlink command
mosquitto_pub -h <IP_ADDRESS> -t application/1/device/2000000000000021/tx -m "{"reference": "abcd1234","confirmed":true,"fPort":10,"data":"OTQ1Mwo="}" -q 1 -u admin -P admin
*. The device profile

Let me validate this. I'll come back to this next week.

I can't reproduce the issue and all is working fine here (tested with Multitech Conduit with onboard GNSS module). I don't think your GNSS module is supported for Class-B:
https://github.com/Lora-net/lora_gateway/blob/a955619271b5d0a46d32e08150acfbc1eed183b7/libloragw/src/loragw_gps.c#L281


[BugFix] Fixed Additive noise

Description
This PR fixes the additive noise operator
Motivation and Context
This change is required because additive noise wasn't doing what it was supposed to do, it never called _add_noise on actions.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:

[x] Bug fix (non-breaking change which fixes an issue)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide (required)
[x] I have updated the tests accordingly (required for a bug fix or a new feature).

@nicolas-dufour the tests are failing, I had to revert this. Can we re-open and fix the tests?


[Packaging] drop support for python 3.5

knack 0.7.0rc1 has dropped support for python 3.5.
Resolve #12525
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

drop python 3.5

hi @fengzhou-msft  why knack drop 3.5 support? what's impact to users if stopping support 3.5?

knack relies on mock 4.0 which dropped python 3.5. This impacts users using pip install with python 3.5. Telemetry shows the rate for python 3.5 in the past week is less than 0.5%.


Timesheet - 05/05/2021- Bojan Ilijevski

Task 1
Managing social media
Answering private messages on Instagram and Facebook
Following/Unfollowing people on social media
Working on analytics report
Time Spent
1.5 hour

Total Time Spent
1.5 hour
Account Number
b1b1e90107d804e5317c8527129ceaededdcb162a6737112b88712742a08bb72

Approved


Long task list obscures configuration cache issues in HTML report

Expected Behavior
I can see all relevant information in the report.
Current Behavior
I can't. When the task list is long, the header will obscure the report output. This example from a very recent 7.5 daily snapshot shows the problem (I can't see the "Build configuration inputs" since they're sitting under the header):

Context
Harder to diagnose configuration cache issues than it should be.
Steps to Reproduce
Run a Gradle job with many tasks and configuration cache issues.
Your Environment

Same for our project but we have many many more problems 😃 !

Tasks redacted for company reasons however it highlights the issue.


Notification settings

Added sound, vibration, and light control settings as well as quiet hour selection settings.

:+1:  looks good to me!


Knowledge Upload / docs/embedding/vector db (chromadb.sqlite3) creates Duplicate embedding

Bug Report
=
Installation Method
Docker: ghcr.io/open-webui/open-webui ghcr.io/open-webui/open-webui:dev /
Environment

Open WebUI Version: v0.3.32

Operating System: [e.g., docker cont.]

Browser (if applicable): [e.g., Chrome / Firefox latest]

Expected Behavior:
One collection db / embedding per document
Actual Behavior:
2 collections / Duplicate embedding per document
see screenshots
Description
Bug Summary:
Workspace
Knowledge
Upload --> Creates Duplicate embeddings
Reproduction Details
Steps to Reproduce:
Workspace
Knowledge
Upload -->
Logs and Screenshots
sqlite db showing dups

vector_db showing 2

One's for the file itself, another's for the collection.