How to access files when S3 is integrated?

So this previously works before S3, I can access the file in client with no problem, but after I followed S3 tutorial, when I click Collection.findOne(...).link(), it says File Not Found :(.
I checked that file is uploaded to S3 and the versions.original.meta.pipePath is correct. Am I accessing it incorrectly with link() or is there anything wrong with my setup?
Thanks!
Meteor-Files: 1.9.10
Meteor: 1.6.1
OS: Mac Browser:Chrome
Debug info:
I20180419-01:56:00.295(-4)? [FilesCollection] [Upload] [DDP Start Method] Got #-1/1 chunks, dst: ***.pdf
I20180419-01:56:00.388(-4)? [FilesCollection] [Upload] [DDP] Got #1/1 chunks, dst: ***.pdf
I20180419-01:56:00.393(-4)? [FilesCollection] [Upload] [DDP] Got #-1/1 chunks, dst: ***.pdf
I20180419-01:56:00.394(-4)? [FilesCollection] [Upload] [finish(ing)Upload] -> resumes/nCQJtLq7RBX3GZHEj.pdf
I20180419-01:56:00.398(-4)? [FilesCollection] [Upload] [finish(ed)Upload] -> resumes/nCQJtLq7RBX3GZHEj.pdf
I20180419-01:56:00.428(-4)? [FilesCollection] [_preCollectionCursor.observe] [changed]: nCQJtLq7RBX3GZHEj
I20180419-01:56:00.432(-4)? [FilesCollection] [_preCollectionCursor.observe] [removed]: nCQJtLq7RBX3GZHEj
I20180419-01:56:00.637(-4)? [FilesCollection] [unlink(nCQJtLq7RBX3GZHEj, original)]
I20180419-01:56:04.202(-4)? [FilesCollection] [find({}, undefined)]
I20180419-01:56:06.938(-4)? [FilesCollection] [download(/cdn/storage/resumes/Rbosirjxbv3q9CyY9/original/Rbosirjxbv3q9CyY9.pdf, original)]
I20180419-01:56:06.939(-4)? [FilesCollection] [download(/cdn/storage/resumes/Rbosirjxbv3q9CyY9/original/Rbosirjxbv3q9CyY9.pdf)] [_404] File not found

Hello @vanshady ,

Can you go to S3 and observe uploaded file, to confirm it's moved to S3?
S3 requires bucket, IAM, and policy setup, described here, have followed this procedure?

@dr-dimitru
Yes for both 1 and 2, I can download the file that I uploaded and I made sure that everything is configured as your tutorial

For reference, here is my collection file
import { FilesCollection } from 'meteor/ostrio:files';
import { Meteor } from 'meteor/meteor';
import { _ } from 'meteor/underscore';
import { Random } from 'meteor/random';
import stream from 'stream';
import S3 from 'aws-sdk/clients/s3';
import fs from 'fs';

const s3Conf = Meteor.settings.s3 || {};
const bound = Meteor.bindEnvironment(callback => callback());
let Resumes;
// Check settings existence in `Meteor.settings`
// This is the best practice for app security
if (s3Conf && s3Conf.key && s3Conf.secret && s3Conf.bucket && s3Conf.region) {
    // Create a new S3 object
    const s3 = new S3({
        secretAccessKey: s3Conf.secret,
        accessKeyId: s3Conf.key,
        region: s3Conf.region,
        // sslEnabled: true, // optional
        httpOptions: {
            timeout: 6000,
            agent: false,
        },
    });

    // Declare the Meteor file collection on the Server
    Resumes = new FilesCollection({
        debug: true,
        storagePath: Meteor.settings.public.resumesStoragePath,
        collectionName: 'resumes',
        // Disallow Client to execute remove, use the Meteor.method
        allowClientCode: false,

        onBeforeUpload(file) {
            if (file.size <= 10485760 && /pdf|doc|docx|jpg|png|pages/i.test(file.extension)) {
                return true;
            } else {
                return 'Please upload PDF/DOC/DOCX resume, with size equal or less than 10MB';
            }
        },

        // Start moving files to AWS:S3
        // after fully received by the Meteor server
        onAfterUpload(fileRef) {
            // Run through each of the uploaded file
            _.each(fileRef.versions, (vRef, version) => {
                // We use Random.id() instead of real file's _id
                // to secure files from reverse engineering on the AWS client
                const filePath = Meteor.settings.public.current_event + '/' + (Random.id()) + '-' + version + '.' + fileRef.extension;

                // Create the AWS:S3 object.
                // Feel free to change the storage class from, see the documentation,
                // `STANDARD_IA` is the best deal for low access files.
                // Key is the file name we are creating on AWS:S3, so it will be like files/XXXXXXXXXXXXXXXXX-original.XXXX
                // Body is the file stream we are sending to AWS
                s3.putObject({
                    // ServerSideEncryption: 'AES256', // Optional
                    StorageClass: 'STANDARD',
                    Bucket: s3Conf.bucket,
                    Key: filePath,
                    Body: fs.createReadStream(vRef.path),
                    ContentType: vRef.type,
                }, (error) => {
                    bound(() => {
                        if (error) {
                            console.error(error);
                        } else {
                            // Update FilesCollection with link to the file at AWS
                            const upd = { $set: {} };
                            upd.$set['versions.' + version + '.meta.pipePath'] = filePath;

                            this.collection.update({
                                _id: fileRef._id,
                            }, upd, (updError) => {
                                if (updError) {
                                    console.error(updError);
                                } else {
                                    // Unlink original files from FS after successful upload to AWS:S3
                                    this.unlink(this.collection.findOne(fileRef._id), version);
                                }
                            });
                        }
                    });
                });
            });
        },

        // Intercept access to the file
        // And redirect request to AWS:S3
        interceptDownload(http, fileRef, version) {
            let path;

            if (fileRef && fileRef.versions && fileRef.versions[version] && fileRef.versions[version].meta && fileRef.versions[version].meta.pipePath) {
                path = fileRef.versions[version].meta.pipePath;
            }

            if (path) {
                // If file is successfully moved to AWS:S3
                // We will pipe request to AWS:S3
                // So, original link will stay always secure

                // To force ?play and ?download parameters
                // and to keep original file name, content-type,
                // content-disposition, chunked "streaming" and cache-control
                // we're using low-level .serve() method
                const opts = {
                    Bucket: s3Conf.bucket,
                    Key: path,
                };

                if (http.request.headers.range) {
                    const vRef = fileRef.versions[version];
                    const range = _.clone(http.request.headers.range);
                    const array = range.split(/bytes=([0-9]*)-([0-9]*)/);
                    const start = parseInt(array[1]);
                    let end = parseInt(array[2]);
                    if (isNaN(end)) {
                        // Request data from AWS:S3 by small chunks
                        end = (start + this.chunkSize) - 1;
                        if (end >= vRef.size) {
                            end = vRef.size - 1;
                        }
                    }
                    opts.Range = `bytes=${start}-${end}`;
                    http.request.headers.range = `bytes=${start}-${end}`;
                }

                const fileColl = this;
                s3.getObject(opts, function (error) {
                    if (error) {
                        console.error(error);
                        if (!http.response.finished) {
                            http.response.end();
                        }
                    } else {
                        if (http.request.headers.range && this.httpResponse.headers['content-range']) {
                            // Set proper range header in according to what is returned from AWS:S3
                            http.request.headers.range = this.httpResponse.headers['content-range'].split('/')[0].replace('bytes ', 'bytes=');
                        }

                        const dataStream = new stream.PassThrough();
                        fileColl.serve(http, fileRef, fileRef.versions[version], version, dataStream);
                        dataStream.end(this.data.Body);
                    }
                });

                return true;
            }
            // While file is not yet uploaded to AWS:S3
            // It will be served file from FS
            return false;
        },
    });

    // Intercept FilesCollection's remove method to remove file from AWS:S3
    const origRemove = Resumes.remove;
    Resumes.remove = function (search) {
        const cursor = this.collection.find(search);
        cursor.forEach((fileRef) => {
            _.each(fileRef.versions, (vRef) => {
                if (vRef && vRef.meta && vRef.meta.pipePath) {
                    // Remove the object from AWS:S3 first, then we will call the original FilesCollection remove
                    s3.deleteObject({
                        Bucket: s3Conf.bucket,
                        Key: vRef.meta.pipePath,
                    }, (error) => {
                        bound(() => {
                            if (error) {
                                console.error(error);
                            }
                        });
                    });
                }
            });
        });

        // remove original file from database
        origRemove.call(this, search);
    };
} else {
    // Declare the Meteor file collection on the Server
    Resumes = new FilesCollection({
        storagePath: Meteor.settings.public.resumesStoragePath,
        collectionName: 'resumes',
        // Disallow Client to execute remove, use the Meteor.method
        allowClientCode: false,

        onBeforeUpload(file) {
            if (file.size <= 10485760 && /pdf|doc|docx|jpg|png|pages/i.test(file.extension)) {
                return true;
            } else {
                return 'Please upload PDF/DOC/DOCX resume, with size equal or less than 10MB';
            }
        },
    });
}

if (Meteor.isClient) {
    Meteor.subscribe('resumes.all');
}

if (Meteor.isServer) {
    Meteor.publish('resumes.all', () => Resumes.find().cursor);
}

export default Resumes;

Hello @vanshady

Please post Client logs from browser's console
Post screenshot of "Network" Tab in DevTools, with opened "Headers" tab on the failed request

Weirdly, I didn't change anything, and it suddenly works, maybe it's because of meteor cache? I'm closing the issue.

Weirdly, I didn't change anything, and it suddenly works

🎉👍👏

maybe it's because of meteor cache?

No, Meteor has only bundler cache. Your changes wasn't applied.
Have you ran meteor reset?

No, I didn't. It's so weird

Okay... Happening sometimes with Meteor.
Please, support this project by:

Star on GitHub
Star on Atmosphere
Check other packages we have made
Share on Facebook and Twitter
Donate via PayPal

Just donated 😉Thank you for such a great project and keep up the good work.

@vanshady are you ok with appearing in our supporters list?

definitely, my pleasure

Done on dev
@vanshady thank you for support, it means a lot for us. And thank you for choosing our lib.


Implement Dataset Class for Tabular Data

Discuss the approach here before implementing

I would like to work on it.
Approach :
1. Segregate numerical and categorical (dtype = "object") columns from the DataFrame, and also keep track of columns which have all unique values (like instance ids).
2. Fill in NULL/NaN values with mean, for numerical and mode for categorical features.
3. Type cast categorical data to Pandas "category" data type and use its inbuilt 'codes' method to encode the feature into integers.
4. Return a dictionary with {column name : corresponding value at requested index} as key : value pairs.


Remove active queries metrics that are never set

I noticed we define these metrics but never set them. I guess they should be safe to remove then.

Ping @yngveaasheim


How to use QuickFilter to search for a list of items

I'm dealing with rows that have a serial number column. In that column there can be 1 to many serial numbers in the form of a string. Adding a QuickFilter attribute to the Serial Number field only produces errors when I try and search. Here's what the field looks like:
[LinkingSetRelation(typeof(LineItemRow), "InvoiceID", "SerialNumber")]
[DisplayName("Serial Number(s)"), Size(100), Width(150)]
public List<String> SerialNumber
{
            get { return Fields.SerialNumber[this]; }
            set { Fields.SerialNumber[this] = value; }
}

Please let me know if I can elaborate on anything.

Duplicate post on my part due to my account being incorrectly flagged. Please see #4373.


bug in mode selection

Hi Zach,
to select the modes for the source frame,
line 351 of the waveform.py, type needs to be int, before being passed to the Cython function.
This made it work for me:
l = np.ascontiguousarray(lmodes, dtype=np.intc)
m = np.ascontiguousarray(mmodes, dtype=np.intc)

Thanks for making this an issue. I have fixed this problem in some current updates that I will be pushing soon. Alternatively, when using select_modes you can pass an numpy array of dtype np.int32 or np.intc, e.g.,
np.array([(2, 2), (2,1)], dtype = np.int32)
Future updates will do this internally so that the user does not have to do this manually


SJDELMONTE.STI.EDU.PH have to create PR all over again this until it merges.

@gatzCooper I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host sjdelmonte.sti.ph not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Week 19 Review Ticket

Individual Work

College Board Grading Section 3
Class to Database Implementation
API/Class implementation

.95 API
.95 DB
.9 CPT


Added exception catches from dependencies.

Now you can easily throw exception from dependencies and that will stop task execution and safely return you an error.
Also it should be useful for scenario described in #132.

Codecov Report

Merging #153 (869f3fc) into develop (e66f3aa) will increase coverage by 3.38%.
The diff coverage is 80.47%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           develop     #153      +/-   ##
===========================================
+ Coverage    67.62%   71.01%   +3.38%
===========================================
  Files           37       42       +5
  Lines          942     1297     +355
===========================================
+ Hits           637      921     +284
- Misses         305      376      +71

Impacted Files
Coverage Δ

taskiq/abc/middleware.py
100.00% <ø> (ø)

taskiq/abc/result_backend.py
100.00% <ø> (ø)

taskiq/cli/scheduler/run.py
0.00% <0.00%> (ø)

taskiq/cli/watcher.py
0.00% <ø> (ø)

taskiq/cli/worker/log_collector.py
100.00% <ø> (ø)

taskiq/cli/worker/process_manager.py
0.00% <0.00%> (ø)

taskiq/cli/worker/run.py
0.00% <0.00%> (ø)

taskiq/events.py
100.00% <ø> (ø)

taskiq/receiver/params_parser.py
96.87% <ø> (ø)

taskiq/result_backends/dummy.py
100.00% <ø> (ø)

... and 23 more

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


sweeper: Prevent nil pointer reference crash in logging

Change Description
Hey.
I'm running into a very peculiar crash regarding bumpFee on Neutrino.
bumpFee in turn calls sweeper's SweepInput.
The faulty code is the logging of input.UnconfParent(), as it will be nil on Neutrino (it doesn't know unconfirmed stuff) which the logger does not like.
Though I'm surprised this crash is not present elsewhere, as the logging itself is faulty regardless. It tries to directly use UnconfParent() *TxInfo, which I assume would be nil if there's no unconfirmed parent, regardless of backend used.
That's my understanding of things, if you know more feel free to correct me.
The sweeper itself handles any UnconfParent() usage correctly.
Cheers.
Steps to Test
Try fee bumping a channel opening with Neutrino as backend. It will crash without this fix.
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[x] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[x] Commits follow the Ideal Git Commit Structure.
[x] Any new logging statements use an appropriate subsystem and logging level.
[ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
[ ]  There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our  Contribution Guidelines for further guidance.

Are you sure this is the problem tho? Golang will catch this case for you at least thats also what the testcase says:
❯ make unit-debug   log="stdlog info"  pkg=sweep  case=TestSuccess
 Running debug unit tests.
GOEXPERIMENT=loopvar go test -v -tags="dev stdlog info"  -test.run=TestSuccess -test.timeout=180m github.com/lightningnetwork/lnd/sweep
=== RUN   TestSuccess
2023-12-13 17:58:52.263 [INF] SWPR: Sweeper starting
2023-12-13 17:58:52.263 [INF] SWPR: Sweep request received: out_point=0100000000000000000000000000000000000000000000000000000000000000:0, witness_type=CommitmentTimeLock, relative_time_lock=0, absolute_time_lock=0, amount=0.00010000 BTC, parent=(<nil>), params=(fee=1 blocks, force=false, exclusive_group=nil)
2023-12-13 17:58:52.364 [INF] SWPR: Candidate sweep set of size=1 (+0 wallet inputs), has yield=0.00005140 BTC, weight=486
2023-12-13 17:58:52.364 [INF] SWPR: Creating sweep transaction 016518c495e39b3f4b8122c1c981365682f898104a265e998a142e9647a969b3 for 1 inputs<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000:0 (CommitmentTimeLock)) using 10000 sat/kw, tx_weight=486, tx_fee=0.00004860 BTC, parents_count=0, parents_fee=0 BTC, parents_weight=0
2023-12-13 17:58:52.364 [INF] SWPR: Cancelling RegisterSpendNtfn for<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000:0
2023-12-13 17:58:52.364 [INF] SWPR: Spend ntfn channel closed for<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000:0
2023-12-13 17:58:52.364 [INF] SWPR: Sweeper shutting down...
--- PASS: TestSuccess (0.10s)
PASS
ok  	github.com/lightningnetwork/lnd/sweep	0.472s

@ziggie1984 I got a stack trace into lnd. But yes I'm also a bit confused why it crashes.

@ziggie1984 I got a stack trace into lnd. But yes I'm also a bit confused why it crashes.

Can you share ?

Debugging is not best when chugging lnd into an .xcframework for mobile, but this is what I got from latest master ac9ca02:

#0	0x00000001039d55b4 in github.com/lightningnetwork/lnd/input.(*TxInfo).String ()

Okay, so the problem seems to go a lot deeper than this.
It looks like there is a bug is in the gomobile runtime, and only for the gomobile macOS target (iOS and Android work fine).
The normal go runtime has a routine for catching panics regarding nil pointer dereference, and is instead printing <nil>.
https://cs.opensource.google/go/go/+/master:src/fmt/print.go;l=588-594
		// If it's a nil pointer, just say "<nil>". The likeliest causes are a
		// Stringer that fails to guard against nil or a nil pointer for a
		// value receiver, and in either case, "<nil>" is a nice result.

We are not yet why this doesn't trigger for gomobile macOS.

Regarding this error and the comment in golang, I would rather guard the nil pointer case in the stringer rather then everywhere else, if we decide to change this. Depending what comes out of your analysis regarding the gomobile behavior on MacOS. Maybe don't catch this behavior at all?

stringer rather then everywhere else, if we decide to change this

Sure I was leaning towards that as well after figuring out more how things work here.

Depending what comes out of your analysis regarding the gomobile behavior on MacOS.

If the error is in go or gomobile, I'm thinking they'd accept a patch for this, as it's clearly not following normal go runtime conventions. But we'll see and dig deeper.

are you using golang.org/x/mobile/cmd/gomobile to make the go code runnable for iOS ?

Yes that's correct.
This program can be used to build for Android (.aar), iOS, and macOS (.xcframework).

I have created a separate Swift macOS program showcasing this super weird go runtime bug.
https://github.com/hsjoberg/GoNilPointerDerefCrash

We solved the issue. It's Xcode's lldb debugger that flips out by the nil pointer usage.
https://github.com/golang/go/issues/23511
Closing this pull request as it does not really make sense to change anything.


Move tests to TestItems.jl

Codecov Report
Base: 79.27% // Head: 80.19% // Increases project coverage by +0.91% :tada:

Coverage data is based on head (ce49cff) compared to base (420d0c5).
Patch coverage: 93.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   79.27%   80.19%   +0.91%
==========================================
  Files           5        4       -1
  Lines         193      207      +14
==========================================
+ Hits          153      166      +13
- Misses         40       41       +1

Impacted Files
Coverage Δ

src/vector.jl
98.03% <0.00%> (-1.97%)
:arrow_down:

src/intervals.jl
80.00% <100.00%> (+4.24%)
:arrow_up:

src/PatternFolds.jl

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


C#: Use custom project setting for C# project files name

Backports 9c698629499a9a8fffb74a3ec4c2bfac6b7a1484 to 3.x
Fixes #27030
An important difference from the master version is I renamed the settings to be more consistent with how we name C# settings in 3.x:

dotnet/project/assembly_name → mono/project/assembly_name
dotnet/project/solution_directory → mono/project/solution_directory
dotnet/project/c#_project_directory → mono/project/c#_project_directory

Created as a draft since this is not in master yet (pending the merge of the dotnet6 branch).

Created as a draft since this is not in master yet (pending the merge of the dotnet6 branch).

This doesn't need to wait for that one to be merged.

Fair enough, but we usually want changes to be merged in master first and I wasn't sure if that code may change before it gets merged.

Cherry-picked for 3.5.1.


Updates and improvements for macOS Sierra

This allows installation with the current Public Beta Installer and possibly even the final version if I guessed its installer's name correctly.
I've also fixed/improved a few of the  install instructions and updated the name from OS X to macOS.

Thanks for the work on this, I'll hopefully get time to test soon—though haven't had time to test any of the Sierra betas yet!

Yeah, just keep it around and I'll update it when the final is released. It should still work with El Capitan if that's the installer provided by the user but I did't  have that around to test.

The final release of Sierra is here! I might get some time to test with the final release, but if not, and someone else can, I'd be happy to merge after things are polished for final release!

I've tested it with Sierra and added a few minor troubleshooting tips. I've also merged your commit https://github.com/geerlingguy/macos-virtualbox-vm/commit/95592c437003de24ba7cda8a0344175a7b231d23. I've chosen slightly softer language because unlike the Betas, the final macOS Sierra does indeed boot with just 16MB video memory.

Thanks so much!


[Feature] Recognize to Rust Language

Recognize from Python to Rust
Currently, active work is underway to unload the processor; searching for a signature is a complex operation for the CPU, especially for a language where there is an asynchronous approach, because of this, asynchrony for the recoginze method disappears.
What has already been done:
The search for song signatures from Python to Rust has been rewritten.
integration of this module through pyo3, as is done with pydantic.
There is very little left, but now you can see the preliminary results.
Before
Test for 20 iterations.
async def main():
    shazam = Shazam()
    t = time.perf_counter()
    a = await asyncio.gather(*[shazam.recognize_song("data/dora.ogg") for _ in range(20)])  # blocking code
    t2 = time.perf_counter()
    print(t2-t)

loop = asyncio.get_event_loop_policy().get_event_loop()
loop.run_until_complete(main())

>>> 23.145966300013242

After:
Test for 50 iterations.
async def main():
    sender = rust.Recognizer()
    t = time.perf_counter()
    a = await asyncio.gather(*[sender.recognize_path("data/dora.ogg") for _ in range(50)])
    t2 = time.perf_counter()
    print(t2 - t)

>>> 2.246784299990395

https://github.com/shazamio/ShazamIO/issues/76#issuecomment-1961610344


Mythic upgrades 3.0.1 and its dependencies doesn't work

Mod Name
mythic upgrades
Mod Homepage
https://www.curseforge.com/minecraft/mc-mods/mythic-upgrades
Minecraft version
1.20.1
Describe the bug
Mythic upgrades mod doesn't work with connector, it doesn't even let the game launch, it crashes
Steps to reproduce

...
Logs

Additional context
No response

v2.3.2 apparently works but I seem to have resource reload failure with it.
'
It works fine starting the game and setting resources, but then in-game or after returning to menu it will constantly fail until next boot. It crashed once and it mentioned it luckily, so I removed and that fixed it. According to the mod page, versions 2.4.0+ onwards don't work on Sinytra.


Make it possible to specify REGION for VLAN_Group scope.

User Story
Nelly is using Nautobot in his company which operates multiple DCs.
Vlan100 is used in the L2 networks of SiteA and SiteB.
SiteA has an identical Vlan100 with different roles.
Therefore, we would like to manage the VlanGroups separately, but currently the only way to do this is to create VlanGroups in Site and Global.
I would be happy if I could create a VlanGroup in the range of RegionA, which includes SiteA and SiteB.
External Dependencies (Optional)
I was inspired by the following Issue.
https://github.com/netbox-community/netbox/issues/5284
In NetBox 2.11.
The scope of a Vlan_group can be [ location,rack,region,site,site group,cluster,cluster group ].
This is very useful and can meet the requirements of customers with multiple sites.

Thanks for the request! Just adding a note that this request potentially ties in to some of the more general rework of the location/organizational model that we've been discussing for a while under #230.

Since migrating Regions and Sites to Locations in 2.0, this should now be satisfied.


Copy to the current dir

When running yo horizon-angular2 it creates a subfolder horizon_angular2_chat_app.
This subfolder is redundant. Just copy the template to where the generator is being issued from.

Commit:  	d63aca2 fixes this issue


Release: plugin-component 1.8.1

[ ] generate TypeScript Definition Files from JavaScript
[ ] provide consistency of define between rax & react, Closes #235

Codecov Report

Merging #238 (7faadca) into master (f605bbc) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 7faadca differs from pull request most recent head 880b3ea. Consider uploading reports for the commit 880b3ea to get more accurate results

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   77.71%   77.71%
=======================================
  Files          31       31
  Lines        1149     1149
  Branches      234      223   -11
=======================================
  Hits          893      893
- Misses        234      256   +22
+ Partials       22        0   -22

Impacted Files
Coverage Δ

packages/ice-npm-utils/src/index.ts
87.85% <0.00%> (ø)

packages/generate-project/src/checkEmpty.ts
22.22% <0.00%> (ø)

packages/generate-project/src/formatProject.ts
69.13% <0.00%> (ø)

packages/iceworks-cli/src/command/config/index.ts
93.33% <0.00%> (ø)

...ackages/iceworks-cli/src/command/generate/index.ts
87.87% <0.00%> (ø)

...iceworks-cli/src/command/init/addSingleMaterial.ts
38.05% <0.00%> (ø)

...s-cli/src/command/generate/generateMaterialData.ts
78.82% <0.00%> (ø)

...s-cli/src/command/init/initMaterialAndComponent.ts
77.77% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f605bbc...880b3ea. Read the comment docs.


Tweak ci build script to support CI build targeting any source branch.

Removed deprecated build definitions.
Added support to explicitly specify source branch.
Note: Source branch could probably be determined from upstream remote,  but it is not very reliable.

Fix #1089

@DHowett-MSFT is added to the review. #Closed

:shipit:


esp32 how to detect terminal(putty etc.) connected? (IDFGH-4718)

Logging decreases processing power. If the usb is not connected I want to turn off logging.
How to detect usb attached and terminal(putty etc.) connected?

Hi @drony,
I'm afraid there's no way to detect the connection by itself, at least not a normal dev board. If you're designing your own hardware then you could probably connect a signal from the USB/serial chip directly to the ESP32 for this purpose.
One thing you could do is listen for serial input and only start logging in this case. Then when you open your terminal you type a character to enable logging, and you could use a different character to end logging.
Increasing the baud rate from the default is also a good way to decrease the overhead of logging in a task, although there is always some overhead as you note.

thanks for advice

If you know that the serial terminal is expected to support VT-100 escape sequences, you can use linenoiseProbe function. This function will return 0 if the connected terminal does support VT-100, and non-zero if the terminal doesn't support VT-100 or is absent.
This is used in the "system/console" example: https://github.com/espressif/esp-idf/blob/73db142403c6e5b763a0e1c07312200e9b622673/examples/system/console/main/console_example_main.c#L164-L178.

i will try. thanks

thanks it's worked

@drony Thanks for sharing the updates, could the issue be closed now? Thanks.


Mark .{1..9} as generic file-extensions

Description
Successor of #4258, which makes use of Linguist's new generic extensions feature. To recap:

Many files on GitHub receive an incorrect classification of "Roff", simply because their filenames end in a numeric suffix:
Gemfile-3.0.3
GFDL-1.2
AFL-1.2
mkfontscale-1.1.1

Change-logs and version-numbers are particularly problematic examples of these. The ValveSoftware/steam-runtime, for instance, was shown as 72.8% Roff (until I fixed it), because of three license files with version-numbers. haskell-CI/haskell-ci was another example (until fixed). You can find those and more by checking GitHub's list of trending Roff repositories.

Checklist:

[x] I am adding new or changing current functionality

[x] I have added or updated the tests for the new or changed functionality.

@lildude Once this gets merged, and with your blessing, I'll follow-up with a PR to move the generic extensions list to its own file (lib/linguist/generic.yml).

Once this gets merged, and with your blessing, I'll follow-up with a PR to move the generic extensions list to its own file (lib/linguist/generic.yml).

Go for it. 🙇♂

Done. 👍 See #5070.


Fix a bug with date

Coverage remained the same at 44.807% when pulling f72c6faddc175728e11c6b55aa776d657b8deb96 on sylvestre:master into 4c84383b98ec50bcb6e99cb29a823c99fa9e157d on mozilla:master.


chore: bump (v4.14.0-rc2)

[x] Remove _root_.ENNReal.inv_div since upstreamed to Mathlib https://github.com/leanprover-community/mathlib4/pull/18704
[x] Remove Int.floor_le_iff since upstreamed to Mathlib https://github.com/leanprover-community/mathlib4/pull/18552
[x] Remove dense_iff_iUnion_ball since upstreamed to Mathlib https://github.com/leanprover-community/mathlib4/pull/19294
[x] Remove dist_eq_of_dist_zero since upstreamed to Mathlib https://github.com/leanprover-community/mathlib4/pull/19294
[x] Remove IsTop.isMax_iff since upstreamed to Mathlib https://github.com/leanprover-community/mathlib4/pull/19305
[x] Remove Int.Icc_of_eq_sub_one since upstreamed to Mathlib https://github.com/leanprover-community/mathlib4/pull/19308

This upstreaming+bumping PR is almost ready to merge.
I have upstreamed some theorems, bumped, upgraded stuff accordingly, but I needed to add one sorry here since gcongr didn't make progress after bumping Mathlib.
CC: @grunweg @fpvandoorn

Probably related: https://leanprover.zulipchat.com/#narrow/channel/428973-nightly-testing/topic/.2319314.20adaptations.20for.20nightly-2024-11-20

Fixed the sorry and pushed some clean-ups. Opened at #185 - just pushing here somehow didn't work, and I don't feel like debugging why.

Thank you, Micheal!
I'll take a look at it later at home and then I think we'll be ready to merge.

:+1: Feel free to cherry-pick #186 into this branch also: otherwise, I can rebase that PR when this one has landed.

Thanks!


gperftools: fix build on ARM

Motivation for this change
The default use of libunwind by tcmalloc segfaults on ARM. For example, starting mongodb immediately crashes (I'll include the backtrace below, for future searches).
This fix removes the use of libunwind on ARM. I've verified this fixes mongodb on aarch64. Other descriptions of the issue say this exact problem also hits aarch32, so the diff covers both architecture variants.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Backtrace
Without this fix, this is my backtrace when mongodb crashes on start, on aarch64:
#0  0x0000007faaedf934 in access_mem () from /nix/store/800ilx46h9s56yr24z73y4ppjlgninxb-libunwind-1.4.0/lib/libunwind.so.8
#1  0x0000007faaee022c in _ULaarch64_is_signal_frame () from /nix/store/800ilx46h9s56yr24z73y4ppjlgninxb-libunwind-1.4.0/lib/libunwind.so.8
#2  0x0000007faaee0834 in _ULaarch64_step () from /nix/store/800ilx46h9s56yr24z73y4ppjlgninxb-libunwind-1.4.0/lib/libunwind.so.8
#3  0x0000007fab8f82e8 in GetStackTrace_libunwind(void**, int, int) [clone .part.0] ()
   from /nix/store/z0k99bd8s25qryw29h5kkmljyqdz7lya-gperftools-2.7/lib/libtcmalloc.so.4
#4  0x0000007fab8f86c0 in GetStackTrace(void**, int, int) ()
   from /nix/store/z0k99bd8s25qryw29h5kkmljyqdz7lya-gperftools-2.7/lib/libtcmalloc.so.4
#5  0x0000007fab8e8fd8 in tcmalloc::PageHeap::GrowHeap(unsigned long) ()
   from /nix/store/z0k99bd8s25qryw29h5kkmljyqdz7lya-gperftools-2.7/lib/libtcmalloc.so.4
#6  0x0000007fab8e9264 in tcmalloc::PageHeap::New(unsigned long) ()
   from /nix/store/z0k99bd8s25qryw29h5kkmljyqdz7lya-gperftools-2.7/lib/libtcmalloc.so.4
#7  0x0000007fab8e7450 in tcmalloc::CentralFreeList::Populate() ()
   from /nix/store/z0k99bd8s25qryw29h5kkmljyqdz7lya-gperftools-2.7/lib/libtcmalloc.so.4
#8  0x0000007fab8e7670 in tcmalloc::CentralFreeList::FetchFromOneSpansSafe(int, void**, void**) ()
   from /nix/store/z0k99bd8s25qryw29h5kkmljyqdz7lya-gperftools-2.7/lib/libtcmalloc.so.4
#9  0x0000007fab8e7724 in tcmalloc::CentralFreeList::RemoveRange(void**, void**, int) ()
   from /nix/store/z0k99bd8s25qryw29h5kkmljyqdz7lya-gperftools-2.7/lib/libtcmalloc.so.4
#10 0x0000007fab8eac20 in tcmalloc::ThreadCache::FetchFromCentralCache(unsigned int, int, void* (*)(unsigned long)) ()
   from /nix/store/z0k99bd8s25qryw29h5kkmljyqdz7lya-gperftools-2.7/lib/libtcmalloc.so.4
#11 0x0000007fab8fb5b8 in tcmalloc::allocate_full_malloc_oom(unsigned long) ()
   from /nix/store/z0k99bd8s25qryw29h5kkmljyqdz7lya-gperftools-2.7/lib/libtcmalloc.so.4
#12 0x0000007fab3d9be4 in ?? () from /nix/store/lhm57ki56ndzwnz6qsg9iii5ljzc3350-gcc-9.3.0-lib/lib/libstdc++.so.6
#13 0x0000007fabd47abc in call_init.part () from /nix/store/ajn7yh1fm35f8lv3pfmbf7d1f3c1vwkw-glibc-2.30/lib/ld-linux-aarch64.so.1
#14 0x0000007fabd47bc0 in _dl_init () from /nix/store/ajn7yh1fm35f8lv3pfmbf7d1f3c1vwkw-glibc-2.30/lib/ld-linux-aarch64.so.1
#15 0x0000007fabd3b104 in _dl_start_user () from /nix/store/ajn7yh1fm35f8lv3pfmbf7d1f3c1vwkw-glibc-2.30/lib/ld-linux-aarch64.so.1

Is there anything I can do to help advance this @vcunat?

Thanks.  I also added 44391a72b


Patch doc shareinstance / new builder

Add extra explication and context to better understand newBuilder impact.
inform that the configuration of the original instance is kept
inform that a configuration of the original instance may be overriden

@swankjesse do we need the CLA for doc comments? https://github.com/square/okhttp/blob/master/CONTRIBUTING.md

I have done the CLA since the beginning


angular2-google-maps not work with Angular 4 AOT build

I'm using the new angular 4 quickstart seed app: https://angular.io/docs/ts/latest/guide/setup.html
I'm running an npm build:aot in git bash and I get the following bash error:
"'AgmCoreModule' is not exported by node_modules/angular2-google-maps/core/index.js"
Version of angular 2 google maps: "angular2-google-maps": "^0.17.0",
My home module thats using it:
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';
import { AgmCoreModule } from 'angular2-google-maps/core/index.js';

import { HomeComponent } from './home.component';

@NgModule({
  imports: [CommonModule, AgmCoreModule.forRoot({apiKey: 'xxx'})],
  declarations: [HomeComponent],
  exports: [HomeComponent]
})
export class HomeModule { }

This is my systemjs.config:
/**
 * System configuration for Angular samples
 * Adjust as necessary for your application needs.
 */
(function (global) {
  System.config({
    paths: {
      // paths serve as alias
      'npm:': 'node_modules/'
    },
    // map tells the System loader where to look for things
    map: {
      // our app is within the app folder
      'app': 'app',

      // angular bundles
      '@angular/core': <EMAIL_ADDRESS>      '@angular/common': <EMAIL_ADDRESS>      '@angular/compiler': <EMAIL_ADDRESS>      '@angular/platform-browser': <EMAIL_ADDRESS>      '@angular/platform-browser-dynamic': <EMAIL_ADDRESS>      '@angular/http': <EMAIL_ADDRESS>      '@angular/router': <EMAIL_ADDRESS>      '@angular/forms': <EMAIL_ADDRESS>
      // other libraries
      'rxjs':                      'npm:rxjs',
      'angular-in-memory-web-api': 'npm:angular-in-memory-web-api/bundles/in-memory-web-api.umd.js',
      'angular2-google-maps':      'npm:angular2-google-maps/core'
    },
    // packages tells the System loader how to load when no filename and/or no extension
    packages: {
      app: {
        defaultExtension: 'js',
        meta: {
          './*.js': {
            loader: 'systemjs-angular-loader.js'
          }
        }
      },
      rxjs: {
        defaultExtension: 'js'
      }
    }
  });
})(this);

Worked for me well. Angular CLI project, angular-cli version 1.0.0, angular version 4.0.0, angular2-google-maps version 0.17.0

Was that with AOT build? and do you have a seed app example I could look at?

Yes, it was built with ng build --prod --aot. It was a clean angular-cli app, so you can try it by yourself

Thanks. Where can I get a  angular-cli app?

http://lmgtfy.com/?q=angular-cli

angular-cli doesnt seem to use AOT?
I had a look at this one: https://github.com/angular/angular-cli

can you send me a link to an angular cli that uses aot

https://github.com/angular/angular-cli/wiki/build there's an AOT option

Thank you thats  a really good seed app. Do you know how to serve the dist folder using that app?

i do an ng build --prod --aot --output-hashing=none which creates the dist folder for production release fine. Next I want to serve that dist folders index to check the aot performance

Please read the docs
angular-cli is not related to this repo so I suggest you to stop offtopic

I close this because Github Issues are for bug reports and feature request. Please use the Gitter Angular Room for these kind of questions.


Pixelated edges of images on webkit browsers

https://stackoverflow.com/questions/7908168/image-resize-gives-slight-brief-pixelation-in-webkit-browsers

only happened on older versions of my pc, so idk, will close for now


docs folder not generated

The docs folder is not included in generation

Human resources are concentrated in https://github.com/giovannicandido/generator-spring-spa


Adding a new guide & logo for dark mode

Hi! So I've noticed a few issues mentioning problems they're having setting up conversation continuity. While I'm not familiar with all the platforms mentioned, I did recently set up conversation continuity using my installation on Heroku and SendGrid.   I've created a guide that goes through this step by step. I've also added a dark mode logo - see https://docusaurus.io/docs/api/themes/configuration#navbar-title--logo.

@patrickobriain  Thanks a ton for taking this up. Looks great ❤
We will add this to the sidebar as well and get it merged.


[Bug]-[230]:When an action is deleted, remove its reference from the action collection as well

Is there an existing issue for this?

[X] I have searched the existing issues

Description
Follow up to https://github.com/appsmithorg/appsmith/pull/13297
Steps To Reproduce
Create a JS function and delete it. Check the JS object in the DB.
Public Sample App
No response
Version
Cloud

JS Obj creation 6m: 2300
apply 5% requirement: 115
Stats

Stat
Values

Reach
115

Effort (months)
<>

@nidhi-nair what is the impact of this issue? How does it affect the user's app?

@subrata71 can you figure out what is going on here and what is the impact of this issue.

This is due to one type of data inconsistency in MongoDB. This is explained here.
There are in total 4 types of data inconsistencies found with respect to JS objects in MongoDB. And this is depicted here.

Issue:-
JS Object already exists even though it doesn't.
Screenshot of the issue:-

From Team SuperKalam


xds_rate_limit: implemented xds rate-limit and alerts

Description: This PR implements a mechanism to detect when xDS update requests go over a pre-specified limit.
Issue: https://github.com/envoyproxy/envoy/issues/2169
What it does:

Detects when xDS update requests go over the limit.
Issues one log warn level when over the limit is detected.
Limits warnings to one log on every 5 seconds.

Risk Level: Low
Testing: unit test, manual testing.
Signed-off-by: Gabriel<EMAIL_ADDRESS>

@htuch @gsagula is asking for design direction before finishing this PR, can you do that?

@htuch Thanks for all the directions! I've done few changes already, and it looks so much better. I'll do the rest tomorrow.

Per new release note policy please add a release note with any applicable feature docs to https://github.com/envoyproxy/data-plane-api/blob/master/docs/root/intro/version_history.rst. Thank you!

@htuch I would like to retake the work on this PR, but it looks like that I should first wait for https://github.com/envoyproxy/envoy/pull/2930 to lend. I already have some changes that make sense to be pushed anyway. So, I will go ahead with those.

@isaachier Thank you for the review. I left your last comment unchanged because that code might when https://github.com/envoyproxy/envoy/pull/2930 gets merged. Also, I'm not 100% sure whether or not the empty destructor is Envoy's style.

@gsagula #2930 is now merged FYI.

Thanks, @htuch! I'll work on it a bit later today.

@htuch @jmarantz Thanks for the great and detailed review. I will take a look at later or over the weekend.

@htuch @jmarantz Feel free to take another look. Thanks!

@jmarantz Feel free to take another look. The 3 possible outputs depending on the error:
Actual log message:
[2018-04-11 07:32:36.985][6459313][trace][upstream] source/common/config/grpc_mux_impl.cc:80] Sending DiscoveryRequest for foo: version_info: "baz"

Does NOT contain the expected substring:
Sendng DiscoveryRequest for foo: version_info

Expected:
[debug]Received gRPC message for foo at version baz
[trace]Sending DiscoveryRequest for foo: version_info

To be subset of:
[2018-04-11 07:35:49.390][6462210][debug][upstream] source/common/config/grpc_mux_impl.cc:160] Received gRPC message for foo at version baz
[2018-04-11 07:35:49.390][6462210][warning][upstream] source/common/config/grpc_mux_impl.cc:63] Too many sendDiscoveryRequest calls for foo
[2018-04-11 07:35:49.391][6462210][trace][upstream] source/common/config/grpc_mux_impl.cc:80] Sending DiscoveryRequest for foo: version_info: "baz"

Expected log message:
[2018-04-11 07:38:07.250][6464857][warning][upstream] source/common/config/grpc_mux_impl.cc:63] Too many sendDiscoveryRequest calls for foo

To contain log level:
trace

But found:
warning

@jmarantz Feel changes in the macros and failure messages. Feel free to take another look. Thanks!

@jmarantz No problem. Thanks again for reviewing it.

Ah, one clarification: I have reviewed only the logging macro changes.

@htuch No problem, thank you for the directions. As per @mattklein123 request, this should be in the release notes. I'll do it tomorrow after the data-plane migration.

Hi @gsagula , thanks for a great change, long awaited! We tried to test it out today, recompiled envoy with the new changes and it still seems quite overloaded with discovery requests. Envoy is at 95% CPU usage. E.g. during a ~15 second test run the "too many" message is printed 3 times, but the "Failed to load certificate chain from " is printed 1740 times.
The original issue is described here https://github.com/envoyproxy/envoy/issues/3079#issuecomment-381544807

@ikatson this change doesn't actually rate limit the requests, it just warns. I think we will consider doing actual rate limiting in a follow up. @gsagula @htuch what's the POR here?

Yep, this just rate limits log messages for the warn but could be used to do full rate limiting. The main problem I have is distinguishing between rapid updates and spinning. If we can set some sensible threshold and make it configurable then we can easily add this based on the PR that was merged.

@htuch @mattklein123 Few ideas tracked in https://github.com/envoyproxy/envoy/issues/2169 that I think if implemented together will help:

sending an error message to the xDS server
checking for repeated identical update messages
adding configurable rate limits

(1) and (2) should be quicker to implement, but if we are going to fail updates, we definitely want (3) as well. WDYT?

@gsagula, personally, I would just implement (3) and set the default limit to 1 update per second (or something), and allow the configuration to raise it.

Sounds good. Just to confirm, no fail updates yet. Should I create an issue to track it?

i'm OK with (3). I continue to have reservations that this might mask broken management design if we fix it by rate limiting. What will happen is Envoy will be doing periodic polling instead of long polling effectively. Maybe this is OK with folks who don't want to think too hard about management server implementation.

For anyone interested in how to actually workaround the broken management (until a better design is approved by envoy maintainers), here's how we workaround it, i.e. there will be no need for rate-limiting in this case, as envoy will not re-initiate the discovery request
https://github.com/ikatson/envoy/pull/1

@ikatson that PR you link to doesn't work. It masks failure such that the management sever never learns that a specifier API resource didn't apply correctly. This is a key feature in xDS, the ability of the management server to learn that a configuration failed to apply cleanly and why.

Thanks @htuch, in our case we don't need the management server to learn about it, all we need is envoy to ignore the resource and load the good ones. We also put into management server a scheduled thread, that sends updates once in a while even if nothing changed, to reconcile whatever are the errors that might have been transient, like missing clusters.
Because that's breaking a lot of things, I did not send this PR into envoy upstream, but just created it in  my fork as a proof-of-concept, as someone might benefit from it like we did.


Supporting generators / yield

Hi,
is there a way for PHPCPP to support generators/yield the same way it is working under PHP right now: https://www.php.net/manual/en/language.generators.syntax.php
so one can have a C++ extension class that has a method that iterates through an iterator/array and yields it results into PHP script? e.g.
<?php foreach($myCppExtension.iterate() as $id => $val){...}

Checked in your manuals but couldn't find anything about generator support unless I have missed something?

No there is no such equivalent. C++ does not have a yield-mechanism as far as I know.
Conceptually, Generators are syntactic sugar, and you can achieve a more or less similar behavior using iterators (although with more lines of code).


Deal with keras embedding layers

I was trying to use DeepLIFT to analyse my text classification model but it will throw key error about embedding layers since there is no key about embedding in layer_name_to_conversion_function function. So it is impossible to use DeepLIFT to model that use keras embedding layers?

You can use the DeepSHAP/DeepExplainer implementation of DeepLIFT which
does not require you to write additional conversion functions.
https://github.com/slundberg/shap
On Wed, Jul 8, 2020 at 11:59 AM Kangyu Zheng<EMAIL_ADDRESS>wrote:

I was trying to use DeepLIFT to analyse my text classification model but
it will throw key error about embedding layers since there is no key about
embedding in layer_name_to_conversion_function function. So it is
impossible to use DeepLIFT to model that use keras embedding layers?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/kundajelab/deeplift/issues/108, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABDWEJ52V2P6XCFMZOYFMDR2S6XNANCNFSM4OU3NPKA
.

Another thing that could be done is to subset the model to only include the layers that come after the embedding layer, and then supply the output of the embedding layer as the input to this subsetted model. This would give you the importance scores at the level of the embedding layer, which could then be mapped back to the individual words. But it would be worth checking that the architecture of the model after the embedding layer is supported by this deeplift implementation; if the architecture is not supported, then the shap library’s implementation of DeepLIFT would probably be the better way to go as Anshul said.


[AIRFLOW-2854] kubernetes_pod_operator add more configuration items

Make sure you have checked all steps below.
Jira

[ ] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2854

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:
kubernetes_pod_operator is missing kubernetes pods related configuration items, as follows:

image_pull_secrets

Pull secrets are used to pull private container images from registries. In this case, we need to configure the image_pull_secrets in pod spec file

service_account_name

When kubernetes is running on rbac Authorization. If it is a job that needs to operate on kubernetes resources, we need to configure service account.

is_delete_operator_pod

This option can be given to the user to decide whether to delete the job pod created by pod_operator, which is currently not processed.
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[ ] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3697 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3697   +/-   ##
=======================================
  Coverage   77.57%   77.57%
=======================================
  Files         205      205
  Lines       15772    15772
=======================================
  Hits        12235    12235
  Misses       3537     3537

Impacted Files
Coverage Δ

...irflow/example_dags/example_kubernetes_operator.py
75% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87013d7...02da54b. Read the comment docs.

PTAL？

Any updates on this PR? Support for private repos is a really important feature.

@Fokko
Thank you for your comment. I have fixed the relevant code, in addition I added support for the hostnetwork configuration, please review, thanks.

@Cplo Thanks for adding these features!  Noticed a small bug (I think) when trying to set image_pull_secrets, even though the KubernetesPodOperator accepts the parameter, the value is not passed to the generated pod.
I add the following line to the execute method and works as expected.
pod.image_pull_secrets = self.image_pull_secrets
Haven't contributed to the project before so feel free to make the update.


add support for the system JDK

If the JDK version is available in the system, then use it

If JVM_VERSION_MAJOR does not match the version in the system, then the system version is used, and the requested version should be used.
For example, the command JVM_VERSION=7u80 ./jdkw java -fullversion should return the version of java full version "1.7.0_80-b15", instead of java full version "9.0.4+11"


final changes

Everything looks good and follows CA now since the API that were created with the adapter patter are now made in the use case factories.


python3Packages.sphinxcontrib-bibtex: 2.1.4 -> 2.2.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 118537 at 6018c844 run on x86_64-linux 1

2 packages built successfully:

python38Packages.sphinxcontrib-bibtex
python39Packages.sphinxcontrib-bibtex


Force open duplicate tab

It could seem strange, but i WANT to open duplicate tab. I open it with context menu "Duplicate Tab". How can I tell the extension not to close THIS tab at this time?
Can we have some shortcut to skip verification?
Or maybe we can ignore tabs duplicated with context menu?

How can I tell the extension not to close THIS tab at this time?

The feature exist, but you have to enable it.
You can either set a shortcut key for the action

or enable the "Force Duplicate Tab" option tab context entry on the preferences

Thank you!


Update Tigris to the latest version

[x] Update Tigris and client to the latest version
[x] Ensure that our smoke test still works.
[x] Ensure that it works on macOS.
[x] Check if it works on Windows.

@w84thesun Please check that the current main works on Windows: environment starts with Tigris, all tests pass

Everything works fine on Windows.


GitLab merge request update improvement

If a merge request changes then GitLab will send a new event on the webhook with "action" = "update".  We should try to be a little smarter about handling this.
The current issue is that once a MR is in we start testing the current upstream branch with the MR.
Then if the MR changes (even if the assigned status changes, or other non commit related changes) then if the upstream branch commit has changed we cancel tests and start a new round of testing.
This is problematic since several apps (like BISON) get updated frequently due to MOOSE submodule updates. So if someone assigns someone to a MR, or adds labels, etc, then it could trigger a new round of testing.

I looked at the Json that GitLab is sending and it seems it uses update for both new commits on the MR branch as well as any other changes to the MR, like labels, status, etc. There doesn't seem to be any way to differentiate from the json alone.
 This would be different then what we do for GitHub.


Reduce complexity in CytoSnake scripts

Mentioned in #37 in this comment
The script design is unnecessarily complex, since we are only using a single function call; therefore it should be encapsulated into a single main() function to reduce complexity instead of two.
Example:

import cytotable

def function1(param1, param2, param3):
   # enter code here
   cytotable.convert(param1, param2, param3)
   return 0

def main ():
   p1 = snakemake.param[0]
   p2 = snakemake.param[1]
   p3 = snakemake.param[2]

   function1(p1, p2, p3)

if __main__ == "__name__"
   main()

can be reduced to:

def main ():
   p1 = snakemake.param[0]
   p2 = snakemake.param[1]
   p3 = snakemake.param[2]

   function1(p1, p2, p3)

if __main__ == "__name__"
   main()

small update regarded about this issue:
turns out that sectioning parameters is not ideal for instances where there are two functions used from the same parameter. Therefore the best approach is the load in the whole configuration instead of sectioning it.
First we the scripts have to be designed in order for it to be simple enough to allow whole config integration.


default tacky.conf setup & examples are using lower case true for the SSL "enabled=" statement.

tacky.conf and setup are using lower case true for the SSL "enabled=" statement.
My read is it should be True, just like the "client_cert_required" below it in the samples and default taky.conf.
This is also in the deployment guides, etc. I guess it is possible that true also evals to True, but I'm now suspicious.
Background:
Been running taky for a while with DPS on an obscure port. Life was good. Due to more users and specifically, some on iTAK, I decided to expose 8443 rather than the high port used previously.
Once doing that, I immediately seeing many gets and posts in the DPS log from scanners. Clearly fishing, luckily not finding marti. Looking for common web exploits.
After chasing firewall settings, blackholing scanners, etc, still occurring. How were they getting in if SSL was enabled? Noticed the true vs True in the config. Changed to True, and no more bogons in the log, just legit traffic even on 8443.
I hope I'm wrong, but if not, folks need to check their taky.conf for this.

OK, I'm perplexed... configparser.getboolean docs use lowercase examples for true/false. But then say: "These string values are checked in a case-insensitive manner."
TOML docs indicate they should always be lowercase.
I'm trying both, but not seeing the bogons either way. Perhaps it was something else, but I was alarmed when I was seeing the GETs and POSTs from foreign entities that did not have the cert.
Feel free to close if you are confident of the behavior!


Uncaught Error: Cannot decorate a destroyed marker layer

[Enter steps to reproduce:]

...
...

Atom: 1.36.0 x64
Electron: 2.0.18
OS: Unknown Windows version
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot decorate a destroyed marker layer
At C:\Users\tempast\AppData\Local\atom\app-1.36.0\resources\app\static\<embedded>:11

Error: Cannot decorate a destroyed marker layer
    at DecorationManager.decorateMarkerLayer (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:519692)
    at TextEditor.decorateMarkerLayer (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:27615)
    at BufferSearch.setEditor (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:723928)
    at ~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:179012
    at refEditor.map.t (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:14:2787015)
    at RefHolder.map (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:14:2737323)
    at Proxy.observeEmbeddedTextEditor (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:14:2787008)
    at ~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:178901
    at Function.simpleDispatch (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:1172021)
    at Emitter.emit (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:1173462)
    at PaneContainer.didChangeActiveItemOnPane (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:446819)
    at Pane.setActiveItem (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:455679)
    at Pane.activateItem (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:457849)
    at TabBarView.t.exports.TabBarView.onClick (~/AppData/Local/atom/app-1.36.0/resources/app/static/<embedded>:11:1123108)

Commands
     -9:40 core:backspace (input.hidden-input)

Non-Core Packages
atom-ide-ui 0.13.0
go-debug 1.6.2
go-plus 6.1.0
go-signature-statusbar 1.2.3
pull-request 0.2.1

Thanks for the report!  Can you confirm a few things for us?

What were you doing at the time of the error?
Is the error is reproducible?
If reproducible, do you see the error in safe mode (atom --safe)?

Got the same error right after switching desktop in MacOS, the current page loaded in Atom was a Unstaged Change page with no file selected.
If that can help you.

Also having the exact same problem. If I open a number of Unstaged Changes tabs when reviewing a commit, then use Cmd+W to close them all the tabs do not close the first time and I get this error.

I just got this error after clicking a project search result. I can't reproduce it.

@equals215 @lukeredpath - if you're seeing this error when using the GitHub package, you can subscribe to https://github.com/atom/github/issues/2073.  If you happen to have specific repro steps that work consistently, feel free to share theme in https://github.com/atom/github/issues/2073 (I tried your steps @lukeredpath but couldn't reproduce, maybe I didn't have enough diff tabs open?).

I got this error after closing a project search.

Now got a similar error every time I started a new comment in Go and then wrote 3 chars (spaces didn't count). For example, this line triggered the error:
fmt.Println("lol") // 123

Few minutes later the bug just disappeared.
Error: Cannot decorate a destroyed marker
    at DecorationManager.decorateMarker (/usr/share/atom/resources/app/src/decoration-manager.js:183:27)
    at TextEditor.decorateMarker (/usr/share/atom/resources/app/src/text-editor.js:2124:41)
    at new Selection (/usr/share/atom/resources/app/src/selection.js:20:41)
    at TextEditor.addSelection (/usr/share/atom/resources/app/src/text-editor.js:3233:27)
    at /usr/share/atom/resources/app/node_modules/text-buffer/lib/display-marker-layer.js:79:24
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app/node_modules/event-kit/lib/emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app/node_modules/event-kit/lib/emitter.js:141:34)
    at MarkerLayer.module.exports.MarkerLayer.createMarker (/usr/share/atom/resources/app/node_modules/text-buffer/lib/marker-layer.js:438:28)
    at MarkerLayer.module.exports.MarkerLayer.markRange (/usr/share/atom/resources/app/node_modules/text-buffer/lib/marker-layer.js:225:25)
    at DisplayMarkerLayer.module.exports.DisplayMarkerLayer.markBufferRange (/usr/share/atom/resources/app/node_modules/text-buffer/lib/display-marker-layer.js:105:58)
    at TextEditor.addSelectionForBufferRange (/usr/share/atom/resources/app/src/text-editor.js:2860:38)
    at TextEditor.createLastSelectionIfNeeded (/usr/share/atom/resources/app/src/text-editor.js:3285:18)
    at TextEditor.getLastCursor (/usr/share/atom/resources/app/src/text-editor.js:2652:16)
    at TextEditor.getCursorBufferPosition (/usr/share/atom/resources/app/src/text-editor.js:2435:23)
    at SubsequenceProvider.bufferToSubsequenceMatches (/usr/share/atom/resources/app/node_modules/autocomplete-plus/lib/subsequence-provider.js:149:60)
    at Array.map (native)
    at SubsequenceProvider.getSuggestions (/usr/share/atom/resources/app/node_modules/autocomplete-plus/lib/subsequence-provider.js:271:18)
    at providers.forEach.provider (/usr/share/atom/resources/app/node_modules/autocomplete-plus/lib/autocomplete-manager.js:300:58)
    at Array.forEach (native)
    at AutocompleteManager.getSuggestionsFromProviders (/usr/share/atom/resources/app/node_modules/autocomplete-plus/lib/autocomplete-manager.js:271:21)
    at AutocompleteManager.findSuggestions (/usr/share/atom/resources/app/node_modules/autocomplete-plus/lib/autocomplete-manager.js:263:23)
    at AutocompleteManager.requestNewSuggestions (/usr/share/atom/resources/app/node_modules/autocomplete-plus/lib/autocomplete-manager.js:704:18)
    at AutocompleteManager.showOrHideSuggestionListForBufferChanges (/usr/share/atom/resources/app/node_modules/autocomplete-plus/lib/autocomplete-manager.js:770:18)
    at Function.module.exports.Emitter.simpleDispatch (/usr/share/atom/resources/app/node_modules/event-kit/lib/emitter.js:25:20)
    at Emitter.module.exports.Emitter.emit (/usr/share/atom/resources/app/node_modules/event-kit/lib/emitter.js:141:34)
    at TextBuffer.module.exports.TextBuffer.emitDidChangeTextEvent (/usr/share/atom/resources/app/node_modules/text-buffer/lib/text-buffer.js:1699:32)
    at TextBuffer.module.exports.TextBuffer.transact (/usr/share/atom/resources/app/node_modules/text-buffer/lib/text-buffer.js:966:18)
    at TextEditor.transact (/usr/share/atom/resources/app/src/text-editor.js:1826:30)
    at mergeIntersectingSelections (/usr/share/atom/resources/app/src/text-editor.js:1373:25)
    at TextEditor.mergeSelections (/usr/share/atom/resources/app/src/text-editor.js:3209:26)
    at TextEditor.mergeIntersectingSelections (/usr/share/atom/resources/app/src/text-editor.js:3180:42)
    at TextEditor.mutateSelectedText (/usr/share/atom/resources/app/src/text-editor.js:1372:23)
    at TextEditor.insertText (/usr/share/atom/resources/app/src/text-editor.js:1338:23)
    at TextEditor.object.(anonymous function) [as insertText] (/usr/share/atom/resources/app/node_modules/underscore-plus/lib/underscore-plus.js:77:33)
    at TextEditorComponent.didTextInput (/usr/share/atom/resources/app/src/text-editor-component.js:1651:30)

Installed packages:
Built-in Atom Packages (92)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>(disabled)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>Community Packages (8)
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

@rsese I've hit this one a few times over the last few days.
Can anyone on the @atom/github-package take a look at some of these stack traces? I'm seeing objects in my stack traces such as RefHolder that I know are in that package's code. On the other hand I'm also seeing references to BufferSearch which are from find and replace.
@rsese I think we should elevate the priority of this. It may even be a blocking issue if we haven't observed it on stable.

I think atom/github#2105 will take care of these. We'll likely cherry-pick it to the 0.28.0 line as well, especially if we confirm that it's no longer occurring on nightly once that ships.

Ahh awesome, thanks @smashwilson :+1:  Wasn't sure if a fix for https://github.com/atom/github/issues/2073 might potentially resolve this issue where people see the error when not specifically using the GitHub package.  If people still hit this error with https://github.com/atom/github/issues/2073 resolved, I'll make sure to bring it to the next meeting @nathansobo 👍


[WIP] Branch for Windows Support [ECR-587]

Overview
All changes aimed at Windows support must target this branch. Right now the changes should be totally compatible with other systems, but we can't afford accidentally breaking master right before release.

See: https://jira.bf.local/browse/ECR-587
Definition of Done

[ ] There are no TODOs left in the code
[ ] Change is covered by automated tests
[ ] The coding guidelines are followed
[ ] Public API has Javadoc
[ ] Method preconditions are checked and documented in the Javadoc of the method
[ ] Changelog is updated if needed (in case of notable or breaking changes)
[ ] The continuous integration build passes


document that you need to run npm run build

to run the fastapi thing

Rebased and force pushed to this branch so no merge conflicts

lgtm :)


[cloud_firestore] How to run Transaction update on a field inside array of the document

I know I can do this on the top level field of the document. But I'm trying to run a transaction update on a field inside of the array of the document.
My 'quiz' document is structured:
{
  title: '123',
  questions: [
    {
      title: 'question1',
      answers: [
        {
          title: 'answer1',
          votes: 0
        }
      ]
    }
  ]
}

And here is the code that I'm working with:
    final DocumentReference postRef = Firestore.instance.document('quizes/' + id);
    Firestore.instance.runTransaction((Transaction tx) async {
      DocumentSnapshot postSnapshot = await tx.get(postRef);
      if (postSnapshot.exists) {
        await tx.update(postRef, <String, dynamic>{'questions[0].answers[0].votes': postSnapshot.data['questions'][0]["answers"][0]["votes"] + 1});
      }
    });

Hi @bbvDeveloper
Please see https://flutter.dev/community for resources for asking questions like this,
you may also get some help if you post it on Stack Overflow.
Closing, as this isn't an issue with Flutter itself,
if you disagree please write in the comments and I will reopen it
Thank you


Clean up CA1032 code analyzer rule/usage

Minor clean up of the analyzer rule CA1032 for exceptions. Aligning on the same approach.
Almost all (if not all) exceptions in the SDK don't have a parameterless constructor, to force passing useful error messages. The PR align all the exceptions to follow the same approach.
We might need to revisit this rule in future if serialization and exception routing becomes a requirement, allowing parameterless ctors only for serialization, and blocking PRs that introduce throwing exceptions without useful info.

Can we just disable the rule in our editorconfig and remove all the #pragma disable directives?

@lemillermicrosoft yeah I was thinking the same but I felt like I shouldn't touch the global rules. @shawncal thoughts?

We might need to revisit this rule in future if serialization and exception routing becomes a requirement, allowing parameterless ctors only for serialization

Binary formatter is being deprecated:
https://github.com/dotnet/designs/blob/main/accepted/2020/better-obsoletion/binaryformatter-obsoletion.md


Use consistent matcher pattern semantics for UsesType, UsesMethod, etc.

In order to ensure consistent syntax for identifying a type via FindTypes, UsesMethod, etc., extract the common matcher logic for re-use across these common tools.
E.g., MethodMatcher will match on methods within subpackages off org.openrewrite using ..*, as in org.openrewrite..* *(..). Whereas FindTypes is less forgiving about matching sub-packages. It will not match on subpackages when provided with org.openrewrite..* -- it will only accept immediate first-level packages, as in org.openrewrite.*.

This would be a good thing to do, but I think we're likely to keep kicking this down the road for a while longer.


Contents of Viewer not syncing anymore (Npp v7.7)

Issue description
After the upgrade to Notepad++ v7.7 (64-bit) this morning, the syncing of the contents in the preview windowrefresh did not work anymore. Tried to 'refresh', but that did not work either. I had to restart the session to see my result. Soame goes for the automatic scrolling, that broke as well.
Markdown to reproduce
  Please post the markdown code producing the described issue, if any

Screenshot
First screenshot, in the middle of an edit session:

Second screenshot, after having save the file:

Third screen shot, after having performed a View / Refresh:

Environment

Notepad++
Notepad++ v7.7   (64-bit)
Build time : May 19 2019 - 13:05:35
Path : C:\Program Files\Notepad++\notepad++.exe
Admin mode : OFF
Local Conf mode : OFF
OS : Windows 10 (64-bit)
Plugins : DSpellCheck.dll MarkdownViewerPlusPlus.dll mimeTools.dll NppConverter.dll

MarkdownViewer++ X.Y.Z

Windows 10 (x64)

bump!

Can confirm the bug for 64 bit, the 32 bit version is having no problems.

Can confirm the bug for 64 bit, the 32 bit version is having no problems.

Okay, thanks. Already an idea of when it's gonna be fixed please?

Same issue here on 64 bit. Interim workaround is to close and open (by hitting Ctrl-Shift-M twice) which forces a Refresh.

Can also confirm this bug for NP++ 7.7.1 64bit on Windows 10

Same problem in one of my PC,but not occurs in another one.It's strange

@medivh91 could it be that the PC where it does not occur is 32bit? Or, on that PC, where it does not occur, which version of NP++ are you using?

I have the same issue. I'm running notepad++ v7.7.1 64-bit and markdown++ v<IP_ADDRESS>64.  I seem to remember it working correctly the first time I installed markdown++, but after a few minutes of using it now it doesn't automatically refresh - my current work around is to just switch document tabs.

@medivh91 could it be that the PC where it does not occur is 32bit? Or, on that PC, where it does not occur, which version of NP++ are you using?

Version 7.6.6 is OK.When I update NP++ to 7.7.1,it has same problem

The issue is still relevant; no automatic updates in the previewer.
I run Notepad++ v7.7.1 (64 bit) with MarkdownViewer++ v<IP_ADDRESS>64

Same here, but hint: another plugin has the same issue! So maybe the bug is inside Notepad++, not in the plugins!
Details:
Tried out in: Npp (1) v7.7.1 64-bit on Win10 (bad) and (2) Npp v7.7.1. 32-bit on Win7 (good).
Tried out plugins: MarkdownViewer++ (v<IP_ADDRESS>25) and NppMarkdownPanel (v0.4.0) (both downloaded fresh 2019-08-12).
I haven't tried to check if the issue is known to the Notepad++ developers.

"I may be slow to respond"...
I'll say! It has been TWO and a HALF months now. Still nothing. C'mon dude! Your move...

Same problem.
Win7
Notepad++ v7.7.1 (64-bit)
MarkdownViewer++ v<IP_ADDRESS>64

We have enough confirmations of the issue. The issue occurs with MarkdownViewer++ v<IP_ADDRESS>64 and older versions but only under Notepad 7.7.1 64 bit, this is already known. Only add new comments if you have new informations.

Any idea of an ETA for a fix?

Still happening after upgrade to Npp 7.8.1 64-bit
MD Viewier <IP_ADDRESS>64
Win 10 Enterprise 1803

Bump. Same issue here.

same issue here. NPP 7.7.1 (64 bit);  MDVPP 0.8.2; win 10pro 1909

same issue here.
NPP 7.8.1(64bit)
MDVPP <IP_ADDRESS>64
Windows 10 pro 1909

Same issue notepad++ 7.8.9 (64 bit)
Win 10 Pro 1909 build 18363.959

confirmed broken.

Same issue confirmed. Thanks for the double Ctrl+Shift+M trick.

This is still an issue. I am using 7.9.2 x64 and Markdown Panel plugin.
View is not refreshed.

This is still an issue. I am using 7.9.2 x64 and Markdown Panel plugin.
View is not refreshed.

Still not working with Notepad++ 7.9.1 x64 and freshly downloaded Markdown++. Judging by the history of this ticket, it never will.

Still a issue with Notepad++ 7.9.1 x64 / Markdownviewer++ version: <IP_ADDRESS>64 and NppMarkdownpanel version 0.5.0
Any new plugin to substitute these ones?

As @wilfreddijksman has linked, this is a problem with Npp 64bit v7.7 and up. They changed an API to use 64bit precision for document position instead of the previous 32bit, something that would only come into play for documents approaching 1GB in size. That breaks all plugins that used that API.
Because of the ridged way Npp handles plugins (each version of Npp has a fixed list of plugins and fixed versions for each of those plugins) even if this MarkdownViewer++ plugin is changed to work with newer 64bit versions of Npp, it will remain broken in all versions from v7.7 up until the version that first points to the fixed version of this plugin.
Npp has combined a dumb, hard-coded plugin list with a pointless API change that breaks several plugins in that list and they are completely at fault in this. It is ridiculous and indefensible. You can rebuild this plugin's .dll with the changes to scintilla.h and import it as an off-book plugin to make it work with 64bit or install the 32bit version of Npp instead. You could also step away from Npp altogether in search of a better managed project.

Npp has combined a dumb, hard-coded plugin list with a pointless API change (possibly just pulled up from Scintilla) that breaks several plugins in that list. It is ridiculous and indefensible, if anything, Npp should have rolled back the Scintilla version as soon as this disaster came to light.

@CapinWinky Let's keep it constructive. It's also a free product and all things considered, I think it's pretty good.


Renaming the package

Cloud formation is the actual thing that we want to control. Troposphere is just a means to an end. Thus, changing the package name.

Oh, file names are my fault. I will sort that out.
Wish I can make a PR for repo name change, but that will happen once I merge this PR.

👍


Fix graceful-timeout variable

During enhancing go-swagger generator as mentioned in issue #1714, as an accident in #1730 the command line parameter --graceful-timeout=50s was interpreted as float and for WithTimeout multiplied by *time.Second
The code doesn't fail but context deadline exceeded will be immediately executed.
This fixes the issue.

Hello. How come you can update a template and commit without regenerating bindata.go ?

Yes it should. There is a script .githools/pre-commit/50xxx for that

Ah, again the commit signing involved... Best to rebase and sign in one pass (every commit is required to be signed...)

Is further action required by my side for the PR to be merged?
The signing is sth. I haven't done before, I need to get used to that...

this checks all your commits...

one is sign-off the other is sign with pgp key.
You're missing the sign with pgp key. Just the last commit will be fine.

https://help.github.com/articles/about-commit-signature-verification/

git hooks don't get installed automatically you have to enable them manually first and then it should start to work.

Okay @casualjim  so ... I signed with commit -s isn't that fine? I believe I did the same for #1730 . DCO check is also fine, what is the issue?

@gregorhollmig  -s only add your email to the commit text.  I think the new CI check also verifies that your commit is cryptographically signed with a PGP signature. You can check this for example, when doing git log --show-signature. This means configuring PGP keys, and configuring git to use these keys to PGP-sign your commits.

@casualjim there is no mention in CONTRIBUTING.md that PGP signature is required.  Is this an intentional change?  If so, it should be added there.

Yep, this came a bit unannounced... This could also be detailed here: https://github.com/go-swagger/go-swagger/tree/master/docs/guidelines

This PR is not the right place to have this discussion


added Benchmark.NET example

You can see the execution results here:

BenchmarkDotNet v0.13.12, Windows 10 (10.0.19045.3930/22H2/2022Update)
AMD Ryzen 7 1700, 1 CPU, 16 logical and 8 physical cores
.NET SDK 8.0.101
  [Host]     : .NET 8.0.1 (<IP_ADDRESS>001), X64 RyuJIT AVX2
  Job-DRZFED : .NET 8.0.1 (<IP_ADDRESS>001), X64 RyuJIT AVX2

InvocationCount=1  LaunchCount=10  RunStrategy=Monitoring
UnrollFactor=1  WarmupCount=10

Method
Configuration
Mean
Error
StdDev

Benchmark
Akka.(...)ation [46]
1.872 ms
0.0592 ms
0.1747 ms

Benchmark
Akka.(...)onfig [57]
40.350 ms
1.1138 ms
3.2842 ms


Millisecond precision for AUTO_GENERATE_ATTRIBUTE_STRATEGY.EPOCH_DATE

Is there a reason why the autogenerated epoch date is converted from milliseconds to seconds?
(I've also seen this pattern in a contractor's dynamodb storage implementation, so I am curious.)
https://github.com/typedorm/typedorm/blob/631b8fa2a5410c068f90b7c66d8449ab139d94a2/packages/core/src/classes/metadata/auto-generated-attribute-metadata.ts#L47
I am willing to open a PR to add support for millisecond epoch date.
Proposing: AUTO_GENERATE_ATTRIBUTE_STRATEGY.EPOCH_DATE_MILLISECONDS

@tylerthardy
By definition, Epoch Time is the number of seconds that have elapsed since January 1, 1970 (midnight UTC/GMT), thus in seconds.


[Feature]: Make container hostnames available in the Docker host

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Make container hostnames available from the Docker host.
It means you can, for instance, log in through SSH into your server where Coolify is installed and then connect to a Postgres container directly through the container's host name (e.g. cld*******************ejf).
It could be done by automatically synchronizing running Docker containers with the host's /etc/hosts file. Like this script: https://gitlab.com/jarylc/docker-hosts-sync
See also related question on the Coolify Discord: https://discord.com/channels/459365938081431553/1077307563957301338
Why should this be worked on?
The feature allows you to access your containers through SSH tunnels instead of making them public or instead of trying to get their temporary IP manually. It's very useful for connecting tools like Postgres administrators (e.g. DBeaver) from a developer's local machine to the server.

I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.
Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.
Thanks for your understanding.


GPL-478 - Samples released from CGaP to "CGAP Extraction" to be creat…

…ed in SS.
Closes #47

Are we going to backfill the MLWH, populating the 'wrangled' column for those already imported?

Was v easy to review for its size, thanks :)


[Serious Bug] It seems that I cannot quit from the animation after playing it long enough.

As title. So I think it will be great if you could provide a config option in setup so that we can specify which key(s) we want to use to quit the animation.

It says ... written, so I thought the obfuscated result were indeed saved. (but it doesn't, I know)
I don't know how to jump back to the original buffer.

I think it will be great if you could provide a config option in setup so that we can specify which key(s) we want to use to quit the animation.

True. will add it shortly 😅

@tamton-aquib Here is the config I used for the testing: (i.e. I was passing {} into the setup, instead of calling setup())
config = function() require('zone').setup {} end

and regarding the point:

I don't know how to jump back to the original buffer.

This is indeed a serious bug. I cannot get rid of the obfuscated result, and it covers the source buffer. I did try <Esc>, <C-c>, <C-o>, but still cannot get rid of it. I was thinking about whether there might be some conflict between zone.nvim and my existing plugins. I guess the culprit might be related to the async. behaviour of vim.schedule (but not sure!) Might be you could start from here.

Hey, I've been fiddling around but haven't stumbled upon this type of bug yet 🤔 .
Also I tried setting keymap for <Esc> but it isnt working for some reason (prolly all the scheduling and stuff)
Can u try with a minimal config? Or can u share ur config so i can try in my free time? 😅

I just experienced this again, let me show you what it looks like:
https://user-images.githubusercontent.com/24765272/205460249-0e4ce8a8-cd8f-450a-a0c2-415d4b0e5fc1.mov
The details about my steps to reproduce it (always run into this situation):

Let the animation run.
Switch to my favorite browser and do something else.
After like 5 mins, then switch back. The animation can stop, but cannot be canceled. And it also covers my neo-tree.nvim filetree, as shown in the demo.

[...] Or can u share ur config so i can try in my free time?

Sorry I cannot share my config since it's a private Repo. As I mentioned in the previous comment I didn't do anything special about zone.nvim's setup. I guess the culprit is probably the filetree plugin neo-tree.nvim I'm using.

Ah, thanks for the detailed info 😄.
Last question: Does it happen with other styles? or is it just treadmill?

@tamton-aquib I just tried epilepsy and my cursor got frozen and neovim became very laggy when it happen:
https://user-images.githubusercontent.com/24765272/205474392-7e508383-4d71-4e93-b93f-6cd706115ad3.mov

Ah i see, thanks for taking the time to test it. I'll get on it soon.

hey @tamton-aquib i encountered it too and there's another problem, it doesn stop with insert mode, :w, q idk why and for me it flickers too

demo_zone_bug.mov

ur bufferline looks sick can i get its config? @nyngwang

I have pushed a temporary fix for this issue, please update and let me know 😅 .


KV key-name case mismatch

Do you want to request a feature or report a bug?
Discovered a BUG in using storeconfig and later reading data using kv provider (consul).  It appears that staert/kv library (https://github.com/containous/traefik/blob/master/vendor/github.com/containous/staert/kv.go#L233) always converts the key to lowercase.  The template for kv/kv provider (https://github.com/containous/traefik/blob/master/templates/kv.tmpl#L51) uses proper casing, as it is defined in the golang structs.
What did you do?
Executed ./traefik --configFile=configs/traefik_dev.toml --debug --consul --consul.endpoint="consul.***:8500"
What did you expect to see?
Expected to get correct value for passHostHeader setting (equal to false)
What did you see instead?
Got an error in the log saying Cannot get key traefik/frontends/na-nginx/passHostHeader Key not found in store, setting default true
Output of traefik version: (What version of Traefik are you using?)

################################################################
# Global configuration
################################################################

logLevel = "DEBUG"

defaultEntryPoints = ["http"]

MaxIdleConnsPerHost = 200 # Default: 200

IdleTimeout = "180s" # Default: 180s

InsecureSkipVerify = true # Default false

[healthcheck]
interval = "30s" # Defautl 30s

################################################################
# Entrypoints
################################################################

[entryPoints]
  [entryPoints.http]
  address = ":8081"

################################################################
# API Backend
################################################################

[web]
  address = ":8080"

################################################################
# Consul KV Backend
################################################################

[consul]
endpoint = "consul.***:8500"
watch = true
prefix = "traefik"

If applicable, please paste the log output in debug mode (--debug switch)
DEBU[2017-09-11T15:31:18-05:00] Cannot get key traefik/backends/na-nginx-lab/circuitbreaker/expression Key not found in store, setting default
DEBU[2017-09-11T15:31:18-05:00] Cannot get key traefik/backends/na-nginx-lab/loadbalancer/method Key not found in store, setting default
DEBU[2017-09-11T15:31:18-05:00] Cannot get key traefik/backends/na-nginx-lab/loadbalancer/sticky Key not found in store, setting default false
DEBU[2017-09-11T15:31:18-05:00] Cannot get key traefik/backends/na-nginx-lab/healthcheck/path Key not found in store, setting default
DEBU[2017-09-11T15:31:18-05:00] Cannot get key traefik/backends/na-nginx-lab/circuitbreaker/expression Key not found in store, setting default
DEBU[2017-09-11T15:31:18-05:00] Cannot get key traefik/backends/na-nginx-lab/maxconn/amount Key not found in store, setting default
DEBU[2017-09-11T15:31:18-05:00] Cannot get key traefik/backends/na-nginx-lab/loadbalancer/method Key not found in store, setting default
WARN[2017-09-11T15:31:18-05:00] Error checking new version: Malformed version: d54417acfe2be53021c60576e645964dc2d3a236
DEBU[2017-09-11T15:31:19-05:00] Cannot get key traefik/backends/na-nginx-lab/maxconn/extractorfunc Key not found in store, setting default
DEBU[2017-09-11T15:31:19-05:00] Cannot get key traefik/backends/na-nginx-lab/loadbalancer/sticky Key not found in store, setting default false
DEBU[2017-09-11T15:31:19-05:00] Cannot get key traefik/backends/na-nginx-lab/healthcheck/path Key not found in store, setting default
DEBU[2017-09-11T15:31:19-05:00] Cannot get key traefik/backends/na-nginx-lab/maxconn/amount Key not found in store, setting default
DEBU[2017-09-11T15:31:19-05:00] Cannot get key traefik/backends/na-nginx-lab/maxconn/extractorfunc Key not found in store, setting default
DEBU[2017-09-11T15:31:19-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/circuitbreaker/expression Key not found in store, setting default
DEBU[2017-09-11T15:31:19-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/loadbalancer/method Key not found in store, setting default
DEBU[2017-09-11T15:31:19-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/loadbalancer/sticky Key not found in store, setting default false
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/healthcheck/path Key not found in store, setting default
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/circuitbreaker/expression Key not found in store, setting default
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/maxconn/amount Key not found in store, setting default
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/loadbalancer/method Key not found in store, setting default
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/maxconn/extractorfunc Key not found in store, setting default
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/loadbalancer/sticky Key not found in store, setting default false
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/healthcheck/path Key not found in store, setting default
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/maxconn/amount Key not found in store, setting default
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-beta/maxconn/extractorfunc Key not found in store, setting default
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/circuitbreaker/expression Key not found in store, setting default
DEBU[2017-09-11T15:31:20-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/loadbalancer/method Key not found in store, setting default
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/loadbalancer/sticky Key not found in store, setting default false
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/healthcheck/path Key not found in store, setting default
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/circuitbreaker/expression Key not found in store, setting default
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/maxconn/amount Key not found in store, setting default
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/loadbalancer/method Key not found in store, setting default
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/maxconn/extractorfunc Key not found in store, setting default
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/loadbalancer/sticky Key not found in store, setting default false
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/healthcheck/path Key not found in store, setting default
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/frontends/na-nginx/entrypoints Key not found in store, setting default empty
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/maxconn/amount Key not found in store, setting default
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/backends/traveler-risk-management-service-beta/maxconn/extractorfunc Key not found in store, setting default
DEBU[2017-09-11T15:31:21-05:00] Cannot get key traefik/frontends/na-nginx/passHostHeader Key not found in store, setting default true
DEBU[2017-09-11T15:31:22-05:00] Cannot get key traefik/frontends/na-nginx/entrypoints Key not found in store, setting default empty
DEBU[2017-09-11T15:31:22-05:00] Cannot get key traefik/frontends/travel-risk-management-service/entrypoints Key not found in store, setting default empty
DEBU[2017-09-11T15:31:22-05:00] Cannot get key traefik/frontends/na-nginx/passHostHeader Key not found in store, setting default true
DEBU[2017-09-11T15:31:22-05:00] Cannot get key traefik/frontends/travel-risk-management-service/passHostHeader Key not found in store, setting default true
DEBU[2017-09-11T15:31:22-05:00] Cannot get key traefik/frontends/travel-risk-management-service/entrypoints Key not found in store, setting default empty
DEBU[2017-09-11T15:31:22-05:00] Cannot get key traefik/frontends/travel-risk-management/entrypoints Key not found in store, setting default empty
DEBU[2017-09-11T15:31:22-05:00] Cannot get key traefik/frontends/travel-risk-management-service/passHostHeader Key not found in store, setting default true
DEBU[2017-09-11T15:31:23-05:00] Cannot get key traefik/frontends/travel-risk-management/passHostHeader Key not found in store, setting default true
DEBU[2017-09-11T15:31:23-05:00] Cannot get key traefik/frontends/travel-risk-management/entrypoints Key not found in store, setting default empty
DEBU[2017-09-11T15:31:23-05:00] Validation of load balancer method for backend na-nginx-lab failed: invalid load-balancing method ''. Using default method wrr.

It seems like the fix could be to convert all the keys to lower-case in https://github.com/containous/traefik/blob/master/provider/kv/kv.go.  Thoughts?

Closed by #3015.