The disjunction macro

Following https://github.com/jump-dev/JuMP.jl/issues/3513#issuecomment-1757920537
What is the full range of syntax you want the macro to support? Why even have a macro? What is the trade-off of just having a functional form?

For @disjunction, the main motivation for the macro is container creation. It is a common use-case to create disjunctions over sets. It is not currently used for an any specialized expression parsing, though this may be added in the future. One complicating factor for @disjunction is that is it tricky to distinguish the anonymous singleton case from the vectorized case which is what leads to most of the complexity.
From the JuMP extension perspective, it would be nice to not have to duplicate all the helper methods:
https://github.com/hdavid16/DisjunctiveProgramming.jl/blob/d7e8e7a09b1cb39d628b25d9a0cded2345c9664d/src/macros.jl#L1-L133
A lot of repetition of JuMP-like macro code happens when making the build calls that potentially create containers and parse naming:
https://github.com/hdavid16/DisjunctiveProgramming.jl/blob/d7e8e7a09b1cb39d628b25d9a0cded2345c9664d/src/macros.jl#L230-L260

Now that Oscar has finished his public API for macro extensions in JuMP and released them in the latest release, we should update the macros to use the API. This should simply the macro code quite a bit :)

This was fixed with #110.


process_confirm_path: Invalid packet received. Size too small.

Tested versions
Godot v4.3.rc1.mono - Linux Mint 21.3 (Virginia) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4060 Ti - AMD Ryzen 7 5700X 8-Core Processor (16 Threads)
System information
Godot v4.3.rc1.mono - Linux Mint 21.3 (Virginia) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4060 Ti - AMD Ryzen 7 5700X 8-Core Processor (16 Threads)
Issue description
E 0:00:01:0455   process_confirm_path: Invalid packet received. Size too small.
<C++ Error>    Condition "p_packet_len != 6" is true.
<C++ Source>   modules/multiplayer/scene_cache_interface.cpp:138 @ process_confirm_path()
This issue occurs on the client peer after the connection is establish, after the first RPC is sent, but before the RPC checksum is returned. This is not causing an issue for the running game, but it IS producing the error.
This error occurs in 4.3rc1, it does NOT occur in 4.2.2
Steps to reproduce
Setup client and server and RPCs. Run.
Minimal reproduction project (MRP)
My project involves 3 interdependent server projects and a client project...not really possible to reduce the project to a minimal project.

My project involves 3 interdependent server projects and a client project...not really possible to reduce the project to a minimal project.

Please make sure you are running the same godot version on all the 3 servers and the client, the multiplayer protocol has changed between Godot 4.2 and 4.3 .

My project involves 3 interdependent server projects and a client project...not really possible to reduce the project to a minimal project.

Please make sure you are running the same godot version on all the 3 servers and the client, the multiplayer protocol has changed between Godot 4.2 and 4.3 .

You guys changed network protocol between minor versions?

You guys changed network protocol between minor versions?

Yes, and will likely change again (not in patch releases though). Godot versioning is not exactly "semver".
In general, we don't guarantee runtime multiplayer compatibility between different engine versions (though again, we always maintain network compatibilities in patch releases compatibility unless it's required by a security fix).
There is a proposal (https://github.com/godotengine/godot-proposals/issues/3533) about adding a way to handle version mismatches which might be worth implementing going forward.

Yes, and will likely change again (not in patch releases though). Godot versioning is not exactly "semver".

For standalone features of course....but this is interconnection. You don't do that. :)
it's called tech locking when you do this and it's generally considered undesirable because it has what are called downstream negative impacts.
Lets say I build a godot server that provides services for many games....I have 1 game that was built with godot 4.3...Now I have to update the server too....uh oh....now all the other games that connect to this server are throwing errors, so now I have to update ALL of those games, and push those updates to all clients.
This is not a good thing to do....

Lets say I build a godot server that provides services for many games...

That's simply not how the Godot high level multiplayer work, it is not among its design goals.
The multiplayer API is designed to support one game at a time, you can have "rooms" in the server (e.g. if you want multiple "matches" in the same instance, though the overhead is rarely worth it), but the server and clients must share at least part of the scene tree, and script RPCs must matches.
It's a protocol for multiplayer games (game logic synchronization), not for your backend infrastructure (there are much better protocols for that, like HTTP).

If you MUST make an update like this between minor versions, you really should ensure backwards compatibility.

I disagree, keeping backwards compatibility on the high level multiplayer protocol would add a lot of overhead over time, which means worse network performance, and higher bandwidth usage, which are the number one priority.
Note that the only thing you need to do, is re-export your game with the new version, and release an update for your game. It is quite expected that you cannot play on a server hosting a new version of a game with an outdated client.

I would suggest this is a release blocker...

I disagree... Again, the protocol is not meant (and never was) to be compatible across different Godot versions.
I agree this should be noted in the release notes, which is why the PR that made the changes (https://github.com/godotengine/godot/pull/90027) has the "breaks compat" flag.

Yeah I see it, I just wish I had known about that conversion or I would have participated in it.
Realize that in the technical world, use case our side of design principles is developed by users, not developers...developers can design a thing, but users figure out the ways to use it.
I can make a strong argument why Godot DOES work the way I said and that is WAS designed to work that way (for instance, supporting multiple interfaces, and concurrent clients, servers, and mixing clients and servers on a single runtime. When these things are availaible to the user base, you can bet your user base is going to find ways to use them, and you can't say that's not how Godot works...because quite simply, it does work that way and it does it very very well.
You can (and I have) built application gateways and server clustering in to Godot using MultiPlayerAPI....just because it wasn't envisioned to be used that way, doesn't mean it shouldn't be used that way.


⚠ API - Lens has degraded performance

In c2180f9, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 503
Response time: 586 ms

Resolved: API - Lens performance has improved in 2c79895 after 6 minutes.


07/05/2018 03:57 : Create Pull Request for branch prTesting_2018070503 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Not able to convert FHIR bundle data

Hi Team,
The liquid template is not working with bundle entry array looping correctly! But if I change the name of Resource or ResourceType to something else it gives the correct output.

Could you provide your input data, output data and templates to let us understand your issue better?

@rishabsood9, do you have additional information to share?


Improve serializing/string conversions + some other opportunities to optimize code

Consider the following snippets:
Example 1:
## objects.nim

proc newMessage*(data: JsonNode): Message =
    result = data.`$`.fromJson(Message)

# or ...

proc `[]=`(obj: ref object, fld: string, val: JsonNode) =
    for name, field in obj[].fieldPairs:
        if name == fld:
            field = ($val).fromJson(typeof(field))

# etc ...

and just about anything that use fromJson but cannot take in JsonNodes
Example 2:
# it's cool that we can do something clean like this in Nim:
        let row = newActionRow @[
            newButton(label = "Lose ?", idOrUrl = "lost", style = Danger),
            newButton(label = "Win ?", idOrUrl = "won", style = Primary)
        ]

... but we can do even better:
# notice the lack of `@`, we're using arrays instead of seq == statically allocated array == more speed !
        let row = newActionRow [
            newButton(label = "Lose ?", idOrUrl = "lost", style = Danger),
            newButton(label = "Win ?", idOrUrl = "won", style = Primary)
        ]

... which brings us to
openArray and other stringing shenanigans :

Using more sink and openArray[char] in the code when possible
Using procs that can accept JsonNode instead of converting them to string which is surely a way too costly operation for functions that run as often as newMessage

profiling as we go
The main trap of optimizing stuff is that we think we are making things faster when in fact we are making them slower, every change must come with microbenchmark to ensure we are not shooting ourselves in the foot

Issue with openArray is that it cannot be a parameter for async procs (Since it cant be guaranteed that the array/seq it is pointing to will still be alive). Could use something like an Iterable concept that kinda achieves the same effect (Although it would increase the binary size if used with lots of different array sizes).
The reason for the string conversion is because of the use of jsony, could switch to jsonutils. While it isn't faster in benchmarks, not needing to convert to/from strings could make it faster (Another benefit, jsonutils has better error messages).
Has with most API clients, biggest slowdown will be network. Would be good to analyse refactoring requester.nim to use a pool of clients instead of creating a new one everytime to see if it gives lower latency
Rest of the suggestions seem good though :rocket:


Set adaptersdk-interfaces to stable version

https://internal.almoctane.com/ui/entity-navigation?p=131002/6001&entityType=work_item&id=620120

A developer build has not yet been created for this branch. Click here to go ahead and create the build...

CI Build Link:
http://sou-jenkins2.swinfra.net:8080/job/FileAnalysisSuite/job/FileAnalysisSuite~adaptersdk-impl-jaxrs~preUS620120~CI


Fix playlist and cover art download

This fixes a few problems caused by the latest Spotify API updates.

The old track JSON endpoint no longer works (which was needed to retrieve cover art), so Spotipy is now used instead. Note that this fix has only been applied to the --large-cover-art option (since that's what I use). Without this option, cover art remains broken.
Playlist loading now correctly makes use of pagination in the API. Before, only a single request was made, which caps the loaded playlist size at 100.
Also, for some reason, playlist emptying was still on by default (regardless of the --remove-from-playlist option). I commented the code causing this.

Actually, my bad, I see a lot of these issues have been fixed already in another branch. Feel free to close this PR and I'll just submit another one in the correct branch with the playlist loading fix I wrote.


auto-update not working on mac

VSCode Version: 1.2.1 tried to update to 1.3.0
OS Version: OSX 10.11.5

Steps to Reproduce:
I'm not working as a root user. Each time the app asks me to download/install the update, it seems to work, but when the app is restarted, I get the old version. After a while the app asks again to update.
I always need to download the new version manually from the site and install it.

Does root own the Applications folder?

On the Applications folder the owner is root, the group is admin. But vscode is actually under /Applications/Tools. That folder is owned by myroot (an admin user) and group admin

And what's the user you are logged in as?
Does it reproduce after a system reboot?
Do you see any error messages in the Console OS X app?

after a reboot I still have the same problem.
There are however errors in the console:
13/07/16 11:03:02,490 ShipIt[614]: Couldn't abort install and restore owned bundle to previous location file:///Applications/Tools/Visual%20Studio%20Code.app, error NSError { domain: NSPOSIXErrorDomain, code: 2, description: "No such file or directory" }
13/07/16 11:03:04,267 ShipIt[614]: Installation error: Error Domain=NSPOSIXErrorDomain Code=13 "Permission denied" UserInfo={NSLocalizedDescription=Permission denied}
13/07/16 11:03:04,267 ShipIt[614]: ShipIt quitting
13/07/16 11:03:04,295 ShipIt[619]: Resuming installation attempt 2
13/07/16 11:03:04,309 ShipIt[619]: Couldn't abort install and restore owned bundle to previous location file:///Applications/Tools/Visual%20Studio%20Code.app, error NSError { domain: NSPOSIXErrorDomain, code: 2, description: "No such file or directory" }
then after some attempts:
13/07/16 11:03:10,103 ShipIt[621]: Too many attempts to install, aborting update
13/07/16 11:03:10,105 ShipIt[621]: Error aborting installation: Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory" UserInfo={NSLocalizedDescription=No such file or directory}
13/07/16 11:03:10,140 ShipIt[621]: Application launched at file:///Applications/Tools/Visual%20Studio%20Code.app
13/07/16 11:03:10,140 ShipIt[621]: ShipIt quitting

Closing as duplicate of #3520


Move config options to app.config instead of the Express app object.

In order to decouple us from Express we might want to namespace config options to app.config instead of using app.set() and app.get(). The rationale:

node-config already exposes the .get and .set functionality
with Express it’s kind of a weird legacy API inconsistency because you can do app.get for a route as well which is confusing
It might help us decouple from Express a bit more instead of relying on the .get and .set functionality.
It gives a central place to access config values so you can dynamically set and get them. Basically a basic synchronous in memory service.
app.config is a bit more explicit, especially for people that are new to Feathers/Express

To get this done

[ ] Assign the node-config instance to app.config
[ ] Alias Express' app.get and app.set to app.config.get and app.config.set except for when registering an Express get route. This might mean implementing with the Buzzard release when the engine adapters are more established.

Related
https://github.com/feathersjs/feathers/issues/258

Our v3 version of Feathers decoupled from Express still supports the normal app.get and app.set so I don't think this super relevant anymore.


local deployment fails to upload the certificate

happen sporadically, in particular on Linux. amp -s localhost cluster create -t local
..............................................................................+++
.................+++
e is 65537 (0x10001)
Generating RSA private key, 2048 bit long modulus
.....................................................................................................................+++
.............................................................+++
e is 65537 (0x10001)
Signature ok
subject=/C=US/ST=California/L=Santa Clara/O=Axway/OU=Atomiq/CN=dashboard.local.atomiq.io
Getting CA Private Key
checking if the certificate secret is already defined
creating the certificate secret
open /stacks/local.atomiq.io.pem: no such file or directory
won't deploy the proxy stack, there's no certificate

the certificate is expected to be in the /stacks directory of the container where the amp-stacks volume is mounted. But the certificate is generated in the host folder after that volume is created.
The reason why it works most of the time is because the amp-bootstrap image version 1.1.0 contained a previously generated local certificate.


gui: add used balance to overview page

Second part of solving https://github.com/bitcoin-core/gui/issues/769
Add used balance to the overview page for wallets with the avoid_reuse flag enabled
Prerequsite:

Part one: https://github.com/bitcoin/bitcoin/pull/28776

overview page when avoid_reuse is enabled

overview page when avoid_reuse is not enabled

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews
See the guideline for information on the review process.
A summary of reviews will appear here.

🤔 There hasn't been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.

What is the use case here? (And the avoid_reuse flag in general...)

@BrandonOdiwuor

Second part: Fixes #769
Add used balance to the overview page for wallets with the avoid_reuse flag enabled
Prerequsite:

Part one (should be merged first): Wallet: Functions to enable adding used balance to GUI overview page bitcoin/bitcoin#28776

If you are still working on this PR, please address https://github.com/bitcoin/bitcoin/pull/28776#discussion_r1557805199.

@hebasto Sorry I will be updating the PR description
There was a change in implementation. I created a different PR (https://github.com/bitcoin/bitcoin/pull/29062) based on the recommendation to refactor the getbalance() function which touches the bitcoin repo. trying to get it merged so that I can update this PR

There was a change in implementation. I created a different PR (bitcoin/bitcoin#29062) based on the recommendation to refactor the getbalance() function which touches the bitcoin repo. trying to get it merged so that I can update this PR

Okay. Until then, marking this PR as a draft.

🤔 There hasn't been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.


Wraper -> Wrapper

Coverage remained the same when pulling c1b1371e8dbd27fbe796bbebe7a22f4192fd863f on aeosynth:patch-1 into 4c093c3583662f20f3342d59f73d61bb96f7d826 on thenables:master.


Bug: Pasting over content starting with an empty node appends instead of replace

Pasting over content that starts with an empty node leads to appending instead of replacement.
https://github.com/user-attachments/assets/9ed8bd65-6a1e-4312-979f-f5635a7691a8
Lexical version: 0.18.1+dev.esm
Steps To Reproduce

go to playground. Press 'Enter'.
Type any text or insert any block in the 2nd line
Select all, then press paste

The current behavior
Appends to the selected content instead of replacing it on paste
The expected behavior
The text that is selected should replaced not append to.
Impact of fix

Pasting content is pretty fundamental to a text editor. This behaviour can lead to weird behaviours for all users.

@trueadm hey, I'd like to contribute to this one. Mind assigning?

@hunxjunedo there's no need for assignment, when/if you have a solution then you can submit a PR


Season 4 - Mess w/ Seasons

id	key	identifier	csr_key	season_id	season_version	name	description
1	1-1	Season1	CsrSeason1	1	1	Heroes of Reach - Part 1
2	1-2	Season1-2	CsrSeason1-2	1	2	Heroes of Reach	Because of you, we found Halo, unlocked its secret...
3	2-1	Season2	CsrSeason2	2	1	Lone Wolves	A red carpet and unexpected guests.
4	2-2	Season-Winter-Break-22	CsrSeason2	2	2	Winter Update	Drop into battle with sharp wits and even sharper ...
5	3-1	Season3	CsrSeason3-1	3	1	Echoes Within	Sometimes our greatest challenges lie just beneath...
6	2-3	Season2	CsrSeason2-3	2	3	Lone Wolves	A red carpet and unexpected guests.
7	2-4	Season-Winter-Break-22	CsrSeason2-3	2	4	Winter Update	Drop into battle with sharp wits and even sharper ...
8	4-1	Season4	CsrSeason4-1	4	1	Infection	The delicate line between friend and foe.

Somehow:

2-1 is now 2-3
2-2 is now 2-4

We have data in the database for either already :/
Need to wait on Zeny, then decide if we migrate old/new or new/old and build some remap.

{
    "data": [
        {
            "id": 1,
            "version": 2,
            "name": "Heroes of Reach",
            "description": "Because of you, we found Halo, unlocked its secrets, shattered our enemy's resolve.",
            "narrative_blurb": "",
            "image_urls": {
                "season_logo": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoic2Vhc29ucy9pbnNpZ25pYV9zMV9SQ0hfNTEyLnBuZyIsIm9wdGlvbnMiOnt9fQ%3D%3D",
                "card_background": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoicHJvZ3Jlc3Npb24vU3dpdGNoZXIvU2Vhc29uX1N3aXRjaGVyX1MxX1JDSC5wbmciLCJvcHRpb25zIjp7fX0%3D",
                "battlepass_background": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoicHJvZ3Jlc3Npb24vU2NyZWVuQmFja2dyb3VuZHMvc2Vhc29uX3Vwc2VsbF9iYWNrZ3JvdW5kX1MxLnBuZyIsIm9wdGlvbnMiOnt9fQ%3D%3D"
            },
            "properties": {
                "identifier": "Season1-2",
                "csr": "CsrSeason1-2"
            },
            "availability": [
                {
                    "start_date": "2021-06-20T17:00:00.000Z",
                    "end_date": "2021-10-20T17:00:00.000Z"
                }
            ]
        },
        {
            "id": 2,
            "version": 3,
            "name": "Lone Wolves",
            "description": "A red carpet and unexpected guests.",
            "narrative_blurb": "Cortana’s dominion has ended, but the merciless forces of the Banished have rushed to fill the void, decimating all who stand in their way.\n\nSpartan Commander Agryna has enlisted a new generation of Spartans and is preparing them to face the Banished—and perhaps even more dangerous foes.\n\nBut a few scattered Spartans remain in the field. These Spartans are rugged and resourceful. Hunters in the dark. And they call themselves… Lone Wolves.",
            "image_urls": {
                "season_logo": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoic2Vhc29ucy9pbnNpZ25pYV9zMl9sb25ld29sdmVzXzUxMi5wbmciLCJvcHRpb25zIjp7fX0%3D",
                "card_background": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoicHJvZ3Jlc3Npb24vU3dpdGNoZXIvU2Vhc29uX1N3aXRjaGVyX1MyX0xXLnBuZyIsIm9wdGlvbnMiOnt9fQ%3D%3D",
                "battlepass_background": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoicHJvZ3Jlc3Npb24vU2NyZWVuQmFja2dyb3VuZHMvc2Vhc29uX3Vwc2VsbF9iYWNrZ3JvdW5kLnBuZyIsIm9wdGlvbnMiOnt9fQ%3D%3D"
            },
            "properties": {
                "identifier": "Season2",
                "csr": "CsrSeason2-3"
            },
            "availability": [
                {
                    "start_date": "2021-10-20T17:00:00.000Z",
                    "end_date": "2022-07-19T17:00:00.000Z"
                }
            ]
        },
        {
            "id": 2,
            "version": 4,
            "name": "Winter Update",
            "description": "Drop into battle with sharp wits and even sharper knives.",
            "narrative_blurb": "Cortana’s dominion has ended, but the merciless forces of the Banished have rushed to fill the void, decimating all who stand in their way.\n\nSpartan Commander Agryna has enlisted a new generation of Spartans and is preparing them to face the Banished—and perhaps even more dangerous foes.\n\nBut a few scattered Spartans remain in the field. These Spartans are rugged and resourceful. Hunters in the dark. And they call themselves… Lone Wolves.",
            "image_urls": {
                "season_logo": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoic2Vhc29ucy9pbnNpZ25pYV9TMi01X1dVXzUxMi5wbmciLCJvcHRpb25zIjp7fX0%3D",
                "card_background": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoicHJvZ3Jlc3Npb24vU3dpdGNoZXIvU2Vhc29uX1N3aXRjaGVyX1MyLTVfV1UucG5nIiwib3B0aW9ucyI6e319",
                "battlepass_background": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoicHJvZ3Jlc3Npb24vU2NyZWVuQmFja2dyb3VuZHMvc2Vhc29uX3Vwc2VsbF9iYWNrZ3JvdW5kX1MyLTUucG5nIiwib3B0aW9ucyI6e319"
            },
            "properties": {
                "identifier": "Season-Winter-Break-22",
                "csr": "CsrSeason2-3"
            },
            "availability": [
                {
                    "start_date": "2022-07-19T17:00:00.000Z",
                    "end_date": "2022-09-27T17:00:00.000Z"
                }
            ]
        },
        {
            "id": 3,
            "version": 1,
            "name": "Echoes Within",
            "description": "Sometimes our greatest challenges lie just beneath the surface.",
            "narrative_blurb": "Spartan Dinh picked up something dangerous in the field... Since returning to the Academy with Spartan Eklund, a Banished menace has haunted his dreams and memories, threatening to extend its reach.\n\nConfident they have contained the threat, Commander Agryna devotes herself to rebuilding the UNSC, training her Spartan recruits for the inevitable coming conflict with the Banished.\n\nStill, Dinh can't shake the feeling that something deeper is at play—and he needs your help. Time to burrow into the heart of the Academy and root out the source of the echoes within.",
            "image_urls": {
                "season_logo": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoic2Vhc29ucy9pbnNpZ25pYV9zM19FV181MTIucG5nIiwib3B0aW9ucyI6e319",
                "card_background": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoicHJvZ3Jlc3Npb24vU3dpdGNoZXIvU2Vhc29uX1N3aXRjaGVyX1MzX0VXLnBuZyIsIm9wdGlvbnMiOnt9fQ%3D%3D",
                "battlepass_background": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoicHJvZ3Jlc3Npb24vU2NyZWVuQmFja2dyb3VuZHMvc2Vhc29uX3Vwc2VsbF9iYWNrZ3JvdW5kX1MzLnBuZyIsIm9wdGlvbnMiOnt9fQ%3D%3D"
            },
            "properties": {
                "identifier": "Season3",
                "csr": "CsrSeason3-1"
            },
            "availability": [
                {
                    "start_date": "2022-09-27T17:00:00.000Z",
                    "end_date": "2023-06-20T17:00:00.000Z"
                }
            ]
        },
        {
            "id": 4,
            "version": 1,
            "name": "Infection",
            "description": "The delicate line between friend and foe.",
            "narrative_blurb": "As Spartan Dinh grappled with the aftermath of his encounter with the Banished AI Iratus, he confirmed suspicions that something deeper was at play, and that Iratus was no longer as contained as once thought./n/nIratus has now infected the Academy systems, transforming their training simulations into a fight for survival as the Banished AI hijacks the Spartans’ Mjolnir armor to turn friend into foe./n/nThe Academy stands at the brink of collapse as the Spartans fight to contain the AI’s influence.",
            "image_urls": {
                "season_logo": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoic2Vhc29ucy9pbnNpZ25pYV9TNF9JTl8yNTYucG5nIiwib3B0aW9ucyI6e319",
                "card_background": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoiL3Byb2dyZXNzaW9uL1N3aXRjaGVyL1NlYXNvbl9Td2l0Y2hlcl9TNF9JTi5wbmciLCJvcHRpb25zIjp7fX0%3D",
                "battlepass_background": "https://api.halodotapi.com/games/halo-infinite/tooling/cms-images?hash=eyJpZGVudGlmaWVyIjoiaGkiLCJwYXRoIjoicHJvZ3Jlc3Npb24vU2NyZWVuQmFja2dyb3VuZHMvc2Vhc29uX3Vwc2VsbF9iYWNrZ3JvdW5kX1M0LnBuZyIsIm9wdGlvbnMiOnt9fQ%3D%3D"
            },
            "properties": {
                "identifier": "Season4",
                "csr": "CsrSeason4-1"
            },
            "availability": [
                {
                    "start_date": "2023-06-20T17:00:00.000Z",
                    "end_date": "2023-10-17T17:00:00.000Z"
                }
            ]
        }
    ],
    "additional": {
        "total": 5,
        "query": {
            "language": "en-US"
        }
    }
}

update csrs set season_key='2-2' where season_key='2-4';
update csrs set season_key='2-1' where season_key='2-3';

update games set season_number=2,season_version=1 where season_number=2 & season_number=3;
update games set season_number=2,season_version=2 where season_number=2 & season_number=4;

update service_records set season_key=2-1 where season_key=2-3;
update service_records set season_key=2-2 where season_key=2-4;

Resolved with manual queries.


B #2491: install.sh accepts -G and -f parameters

What branches does this go to? Suggestion, since it is a bug:

master
one-5.6
one-5.6-devel

Agree with branches.
I also updated README.md.


update kbd shortcuts

###Why
Since, in the rebuild-command.md page keyboard shortcuts are not in the updated version of github docs. As mentioned in this link https://github.com/github/docs/blob/main/contributing/content-style-guide.md#keyboard-shortcuts, so they need to be updated according to updated keyboard shortcuts.
Closes https://github.com/github/docs/issues/13906
What's being changed (if available, include any code snippets, screenshots, or gifs):
In place of these keyboard shortcuts (Shift + Command + P/ Ctrl + Shift + P) I updated them as (Shift + Command + P/ Ctrl + Shift + P) to meet new Github content content style guide.
Thank you, if any changes needed plz suggest me.

Check off the following:

[ check] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
[ check] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@Paras-Saini Thanks so much for opening a PR! I'll get this triaged for review ⚡


graphical glitch when resizing vim pane down

When I have two tmux panes on top of each other, with the top one focused and running nvim, when I resize down to make the upper pane larger, vim renders itself resized in the other direction (smaller, higher) for a split second before rendering itself resized correctly in the other direction.
Here's a gif showing the behaviour:

I'm running neovim nightly (NVIM v0.5.0-418-g87d892afa) and tmux 3.0a
Let me know if you can reproduce this!

I have definitely noticed this before. I though it was a network hiccup with my connection (I do development for work on a remote server over SSH). I'll look into why it's happening

@jameh I simplified the resizing process and I think #6 should fix this. I'm not seeing it happen on my Mac at the moment... I'm not sure if that's because it's happening so fast or because it's fixed.
Try it out and let me know!

with bc5af8e, resizing from nvim is even more broken:
In a tmux window split like above, with nvim in the top pane and focused:

alt-j from nvim shrinks the nvim window, but the tmux pane is not resized

alt-j is meant to grow the nvim pane

alt-k from nvim either:

shrinks the nvim window, and the tmux pane is shrunk also (if nvim window and tmux pane are the same size) or:
grows the nvim window, leaving the tmux pane the same size.
note alt-k is meant to increase the size of the nvim pane

when testing, I checked out bc5af8e from both my .config/tmux/plugins folder and from .config/nvim/plugged folder and restarted tmux. The same behaviour was experienced from the latest master commit also.

Here's a screengrab

Couple questions, did you install with tpm?
Also have you tried running without any custom settings? If not, you can try cd’ing to the root of this repo and run make from a new terminal without tmux running. It will run tmux/vim with the basic .tmux.conf/.vimrc provided under /test. That will guarantee it isn’t something from your configs.

I did install with tpm.
I did not try running without custom config, but I just tried running make and I get the same results on bc5af8e:

and the same results with the most recent master commit also.

I see the problem. The workflow is: try to resize in Vim, if that has no effect, pass that command to Tmux. It works for left/right/up resizing. It doesn't work for down resizing because Vim acts on that command and resizes the window in the wrong direction to grow the command area.
Working on a fix.

@jameh Should be fixed with latest release

It seems to be fixed now! thanks for your work!


As a user I need to tag a set of people or delete tag from a set of people

Write a massop command to tag/delete tag from a group of people


Notice: iOS Flipper Known Compatibility Issues

As of RN 0.69.2+ and Flipper 0.158.0, there are several issues with other config plugins that are incompatible with Flipper on iOS. This thread documents the known plugin / pod combinations with issues. Where possible, we try to link out to other threads to provide a complete picture of the problem.
❌  expo-firebase-analytics
Relevant Threads: #26
reason Firebase requires use_frameworks and is not compatible with Flipper at this time 1, 2, 3
resolution If you do not believe you need use_frameworks, you may set the ECF plugin's ios.stripUseFrameworks = true which will ensure there are no use_frameworks lines in your podfile. However, other libraries may not build if you do this. Instead, we recommend turning off Flipper on iOS by setting ios.enabled = false as this will still let you use Flipper for Android.

any updates on this?

Hi @Nsquik. Unfortunately the use_frameworks + flipper is a known incompatibility that can't be worked around. The short explanation is that use_frameworks links common libraries such as Folly in a way which Flipper can no longer use. There are pretty complex workarounds with minimal success linked in the original post. (see: https://github.com/invertase/react-native-firebase/issues/6332)
If you absolutely need Flipper and Firebase, I suggest Mike's solution:

It's going to be a while until it's all easy out of the box while this happens, until then v14 of this module is always available...

I'm sorry I don't have a better answer. :\


LoadLibrary for Lazy P/Invoke Improvements

This change improves the loadlibrary for Lazy P/Invoke by propagating
DllImportSearchPath attribute value to runtime and tries to imitate the
CoreCLR behavior. In particular, this change ensures we look for native
libraries in the directory where the executable resides by default.

I already addressed the feedbacks by moving the BaseDirectoy to bootstrapper. However, as per our offline discussion I am closing this PR, because 1. @sergiy-k  is unblocked by the https://github.com/dotnet/corert/pull/3592 and 2. He has a duplicate PR doing the same AppContext. BaseDirectory for Unix thing through P/Invoke in https://github.com/dotnet/corert/pull/3588
/cc: @yizhang82


Improve accessibility

What feature would you like?
Various changes can be made to improve accessibility for disabled users:

[x] Add descriptive text for label attached to theme toggle. This should only be visible to screen readers
[x] Change h5 heading at top of file list to an h2 heading (ie. don't skip heading ranks)
[ ] Choose different secondary accent colors for dark and light themes. Change the brightness for primary and secondary theme colors to improve contrast against the page background
[ ] Limit animations when prefers-reduced-motion is set
[x] Reconfigure sitemap generate such that sitemap.xml is located under the root domain?
[x] Remove duplicate meta charset declaration
[ ] Remove section elements if possible. All page content aside from the header and footer are essentially in the same section, and it is not ideal to declare sections without titles

Duplicate meta charset declaration removed in e1246e84af3c4dcb4fc3d3a73173d0004953c19b.

Sitemap directory changed in b4b02ffaa9519fa7f43a05c1e89aef4d66cb3b6c.

h5 heading changed to h2 in 585401fe7c828b3070f50eef76a057254beed2b7.

Label added to theme toggle in e2b564bae68a9fe2d9d3756d7ed2e142ea15a6f5.

Theme colors updated in 736600e03eb848634977c7e96e78b2c2870ebaf3. Alert colors may require further tweaking to meet APCA standards.

prefers-reduced-motion support added in #31


Bin vendor root dir specify

Hey guys!
Explicitly passing the project's root dir to the build_bootstrap.php script
This takes advantage of a recent change in the SensioDistributionBundle which allows this. A specific situation this addresses is when the vendor dir is symlinked, and the build_bootstrap.php script mistakenly places the bootstrap.php.cache in ../app of the vendor dir's real location (instead of actually inside the project).
See: https://github.com/sensio/SensioDistributionBundle/pull/9
Thanks!

You should use escapeshellargs for the rootDir too

#215 does the same fix but with the call to escapeshellargs


Setup openshift environment for almighty

ref: https://trello.com/c/pNaZbq8r/49-setup-openshift-environment-for-almighty

@kwk : I would like to contribute here, any guidelines please ?

@pranavgore09 thanks for offering your help. We're in the middle of figuring out ourselves how to proceed and currently there's not much that we can do on our side. As soon as we have something, I'll let you know, okay?

@pranavgore09 actually there is something you can do: We need to run the almighty core process as non-root inside a container. Please find out what approach is best here and maybe create a PR for modifying the Dockerfile.deploy. Thank you

Sure, thanks @kwk for consideration.

@pranavgore09 I've created an issue (#167) and a fix  for the user problem (#168). This should do the trick.

We consider this done when https://github.com/almighty/almighty-core/pull/186 is upstream?

We consider this done when #186 is upstream?
Yes @aslakknutsen . I think this can be considered done. Currently it's only the two of us (singing: "just the two of us") who can access the worker through SSH but that's fine, I guess.


License

Could you please choose a license to this repository?
Thank you very much for the great work!
Kind regards,
Michael

Mit is what I usually use. Does that work?
On 3:14PM, Mon, Aug 17, 2015 Michael Barroco<EMAIL_ADDRESS>wrote:

Could you please choose a license to this repository?
Thank you very much for the great work!
Kind regards,
Michael
—
Reply to this email directly or view it on GitHub
https://github.com/notablemind/jupyter-nodejs/issues/12.

That's fine, thanks!

added


Juniper Book (master) generation is not working.

Describe the bug
Seems to book (master) generation issue.
To Reproduce
If you go to subscription page, you will find below text instead of plain old generated html.
Currently there is an example of subscriptions with [warp][warp], but it still in an alpha state. GraphQL over [WS][WS] is not fully supported yet and is non-standard.

    Warp Subscription Example
    Small Example

[Coordinator]: https://docs.rs/juniper_subscriptions/0.15.0/struct.Coordinator.html [SubscriptionCoordinator]: https://docs.rs/juniper_subscriptions/0.15.0/trait.SubscriptionCoordinator.html [Connection]: https://docs.rs/juniper_subscriptions/0.15.0/struct.Connection.html [SubscriptionConnection]: https://docs.rs/juniper_subscriptions/0.15.0/trait.SubscriptionConnection.html [Future]: https://docs.rs/futures/0.3.4/futures/future/trait.Future.html [warp]: https://github.com/graphql-rust/juniper/tree/master/juniper_warp [WS]: https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md [GraphQLError]: https://docs.rs/juniper/0.14.2/juniper/enum.GraphQLError.html [Schema]: ../schema/schemas_and_mutations.md

Expected behavior
It should have generated proper html
Additional context
I haven't checked other pages for issues. But best guess is it might be there and fixing one page should fix all pages.

@kunjee17 yup, there is some mess around links.  I've planned to fix it eith the subscriptions layer being polished altogether. However, earlier PRs are still welcome 😉

Hi! I think this has been fixed. (The links are still broken though.) When I do mdbook build in docs/book it seems to be fine:

However, I had to add a title in SUMMARY.md otherwise it stopped generating content at Type System: Other types: Union. Did you not have this problem?


UX improvements for our workflows

Context
In a recent call with an instrument scientist it became clear that our notebooks of reduction workflows are unnecessarily unclear for non-programmers, even when considering an expert user who does want to see and access all the details.
Based on my notes, here are a couple of suggestions of potential improvements.
Suggestions

Replace "providers" with "workflow steps", avoiding Sciline terminology.
Replace "pipeline" with "reduction".
Avoid param dicts: Mixing of collecting/setting params in a dict as well as setting them on a Pipeline is confusing. It is not obvious to users that this is equivalent.
Add wrappers for pipeline creation that include defaults, mainly to facilitate 3.) above.

Example
Change
params = loki.default_parameters()
params[QBins] = ...
pipeline = sciline.Pipeline(loki.providers, params=params)
pipeline[ReturnEvents] = True

to
reduction = loki.LokiReduction()
reduction[QBins] = ...
reduction[ReturnEvents] = True

If customization of providers is required, we can have something like
reduction = sans.Reduction(
    steps=loki.workflow_steps + sans.workflow_steps,
    params=loki.default_parameters())

Sounds like some very good suggestions.
Maybe we should even settle on either using the term "workflow" or the term "reduction"?
For example:
reduction = sans.Reduction(
    steps=loki.reduction_steps + sans.reduction_steps,
    params=loki.default_parameters())

I think we still need to distinguish two things: The "Reduction" (previously pipeline), and the "Workflow", created by it?

From a programming point of view, I don't like the word reduction in this context. It clashes with reducing collections.
What was this scientist's opinion of 'task graph'?
Another alternative for pipeline would be 'workflow builder'.

But... we are not writing this for programmers, right? I don't think you are suggesting we should not call it "data reduction" any more? And ultimately, the data reduction is reducing collections (a collection of data points at pixels into data for Q values).

No, we should not try to change the name used in science. But this does not mean that we should use it as a variable name.
If you want to get philosophical, I would say that pipelines are not reductions. They represent an infinite set of possible reductions. So they are builders, not the concrete reduction/workflow.

I think we still need to distinguish two things: The "Reduction" (previously pipeline), and the "Workflow", created by it? Not sure how the steps should be named?

Not sure what you mean. Do you mean that we should distinguish between the constructor of the pipeline and the pipeline itself, or do you mean we should distinguish between the pipeline and the task-graph created when we request a provider?
Regarding pipeline / task graph I think we should avoid creating task-graphs in the workflows and instead almost always
do pipeline.compute(Type) instead of something like ioq = pipeline.get(Type); ioq.compute(). The latter is confusing for some users because it's easy to mix up the task graph with the result.

I think we still need to distinguish two things: The "Reduction" (previously pipeline), and the "Workflow", created by it? Not sure how the steps should be named?

Not sure what you mean. Do you mean that we should distinguish between the constructor of the pipeline and the pipeline itself, or do you mean we should distinguish between the pipeline and the task-graph created when we request a provider?

I meant the latter.

Regarding pipeline / task graph I think we should avoid creating task-graphs in the workflows and instead almost always do pipeline.compute(Type) instead of something like ioq = pipeline.get(Type); ioq.compute(). The latter is confusing for some users because it's easy to mix up the task graph with the result.

Good point. Maybe we can avoid working with TaskGraph? The main reason for it is that it avoid specifying keys multiple times:
iofq = pipeline.get(IofQ)
iofq.visualize()
iofq.compute()

vs
workflow.visualize(IofQ)
workflow.compute(IofQ)

but maybe that is fine and less confusing?

Shall we discuss this online?

No we should not.

Good point. Maybe we can avoid working with TaskGraph? The main reason for it is that it avoid specifying keys multiple times:

I prefer the second version because it's explicit about what domain type is referenced. (Is it normalized iofq, sample iofq, background iofq etc). It also has less state, which is good in a notebook where it's easy to loose track of what variables references what where.
To make it slightly less verbose we can give the Pipeline a shorter name, something like wf instead of workflow.

I think the suggestions are good, and there are also good discussion points. Let's set up a meeting to talk about this.

Summary from meeting:

Naming: use workflow = loki.LokiWorkflow()
set parameters on pipeline, do not use params[QBins]
use workflow.compute(IofQ) instead of explicitly using the task graph in the notebooks.


No operation saved

Hello! I just install the bundle,
I'm on symfony 4.2
this is my configuration file:
dh_doctrine_audit:
    table_prefix: 'audit_'
    table_suffix: ''
    timezone: 'Europe/Paris'
    enabled: true
    entities:
        AppCore\Entity\MyEntity: ~

the schema update commande work fine
bin/console doctrine:schema:update --force
But when I update or create content (CRUD operation), There are no change in /audit, to debug I did dump in the onFlush()
this is where I did dump
public function onFlush(OnFlushEventArgs $args): void
    {
        $em = $args->getEntityManager();
        $transaction = new AuditTransaction($this->manager->getHelper());

        dump($em, $transaction->getEntityManager(), __METHOD__);

Here the results of dump

Two unitOfWork are different.
To fix this temporary I did this in the DoctrineSubscriber : $transaction->setEntityManager($em);
And add setEntityManager method to AuditTransaction
Thanks in advance.

Not only UnitOfWork are different but EntityManager too... that's usually the case when using a secondary database to store audits.
Could you please provide me a sample test project or code sample to reproduce the issue?

This is my doctrine configuration file content:
doctrine:
    dbal:
        # configure these for your database server
        driver: 'pdo_mysql'
        server_version: '5.7'
        charset: utf8mb4
        default_table_options:
            charset: utf8mb4
            collate: utf8mb4_unicode_ci

        url: '%env(resolve:DATABASE_URL)%'
    orm:
        auto_generate_proxy_classes: true
        naming_strategy: doctrine.orm.naming_strategy.underscore
        auto_mapping: true
        mappings:
            DonisoCore:
                is_bundle: false
                type: annotation
                dir: '%kernel.project_dir%/src/Doniso/Core/Entity'
                prefix: 'DonisoCore\Entity'
                alias: DonisoCore
            DonisoUsers:
                is_bundle: false
                type: annotation
                dir: '%kernel.project_dir%/src/Doniso/Users/Entity'
                prefix: 'DonisoUsers\Entity'
                alias: DonisoUsers

Sorry I don't it is difficult to provide sample test but I can share all configurations files which can help

What's the namespace of your entities? (the ones you want to audit)

This is a sample of one ENtity
namespace DonisoCore\Entity;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\ORM\Mapping as ORM;
use Symfony\Component\Validator\Constraints as Assert;

/**
 * @ORM\Entity(repositoryClass="DonisoCore\Repository\CourseRepository")
 */
class Course extends BaseEntity
{
}

in my database I have a table called course_audit
And in the Audit route /audit
I have My Entity there DonisoCore\Entity\Course

Your dh_doctrine_audit.yaml file mentions AppCore\Entity\MyEntity as an audited entity (so under the AppCore\Entity namespace) but your doctrine.yaml suggests your entities are in DonisoCore\Entity and DonisoUsers\Entity namespaces.
Are you using version 3.x of the bundle?

Oh you replied before I post my last message :) so I suppose you use 3.X version of the bundle and  annotations to declare which entity is auditable

this is the real content of my dh config file
dh_doctrine_audit:
    table_prefix: 'audit_'
    table_suffix: ''
    timezone: 'Europe/Paris'
    enabled: true
    entities:
        DonisoCore\Entity\Academy: null
        DonisoCore\Entity\CAP: null
        DonisoCore\Entity\Course: null

I'm using 3.0.0 based on composer show command

@dtraore thanks, now I need some time to try to reproduce the issue on my side. I'll keep you updated.

Ok thanks to you.

@dtraore could you post the result of bin/console debug:config DoctrineBundle please?
Also, a sample of code that reproduce the issue would be helpful.

Probably related to #157

Hello here you is the output of doctrine bundle config command:
λ php bin/console debug:config DoctrineBundle

Current configuration for "DoctrineBundle"
==========================================

doctrine:
    dbal:
        default_connection: default
        connections:
            default:
                driver: pdo_mysql
                server_version: '5.7'
                charset: utf8mb4
                default_table_options:
                    charset: utf8mb4
                    collate: utf8mb4_unicode_ci
                url: '%env(resolve:DATABASE_URL)%'
                host: localhost
                port: null
                user: root
                password: null
                logging: true
                profiling: true
                profiling_collect_backtrace: false
                options: {  }
                mapping_types: {  }
                slaves: {  }
                shards: {  }
        types: {  }
    orm:
        auto_generate_proxy_classes: true
        default_entity_manager: default
        entity_managers:
            default:
                naming_strategy: doctrine.orm.naming_strategy.underscore
                auto_mapping: true
                mappings:
                    DonisoCore:
                        is_bundle: false
                        type: annotation
                        dir: 'D:\wamp64\www\doniso/src/Doniso/Core/Entity'
                        prefix: DonisoCore\Entity
                        alias: DonisoCore
                        mapping: true
                    DonisoUsers:
                        is_bundle: false
                        type: annotation
                        dir: 'D:\wamp64\www\doniso/src/Doniso/Users/Entity'
                        prefix: DonisoUsers\Entity
                        alias: DonisoUsers
                        mapping: true
                query_cache_driver:
                    type: array
                    namespace: null
                    cache_provider: null
                metadata_cache_driver:
                    type: array
                    namespace: null
                    cache_provider: null
                result_cache_driver:
                    type: array
                    namespace: null
                    cache_provider: null
                class_metadata_factory_name: Doctrine\ORM\Mapping\ClassMetadataFactory
                default_repository_class: Doctrine\ORM\EntityRepository
                quote_strategy: doctrine.orm.quote_strategy.default
                entity_listener_resolver: null
                repository_factory: doctrine.orm.container_repository_factory
                hydrators: {  }
                filters: {  }
        proxy_dir: '%kernel.cache_dir%/doctrine/orm/Proxies'
        proxy_namespace: Proxies
        resolve_target_entities: {  }

The hot fix that I did is to override some file which are :
dh_doctrine_audit.event_subscriber.doctrine:
    class: DonisoAdmin\AuditHotFix\DoctrineSubscriber
    arguments<EMAIL_ADDRESS>    tags:
      - { name: doctrine.event_subscriber, connection: default }

  dh_doctrine_audit.manager:
    class: DonisoAdmin\AuditHotFix\AuditManager
    arguments:
      -<EMAIL_ADDRESS>      -<EMAIL_ADDRESS>    public: true

  DonisoAdmin\AuditHotFix\AuditManager:
    alias: dh_doctrine_audit.manager
    public: true
  DonisoCore\Security\ClassRoomVoter:
    class: DonisoCore\Security\ClassRoomVoter
    tags: [ security.voter ]

I can share these file if need.

@dtraore Sorry for the delay, this should be fixed in master branch as you can now configure several entity managers both for storage and as audit event sources. I close this issue but feel free to reopen it if needed.

Hello, I just updated from the 'old' audit which was working perfectly with Symfony 5.2. The configuration is default and really standard with one DB. With the old everything word fine but now nothing gets logged.  Someone has an idea what could be wrong?
Current configuration for "DoctrineBundle"
==========================================

doctrine:
    dbal:
        default_connection: default
        connections:
            default:
                url: '%env(resolve:DATABASE_URL)%'
                driver: pdo_mysql
                server_version: '5.7'
                charset: utf8mb4
                default_table_options:
                    collate: utf8mb4_unicode_ci
                host: localhost
                port: null
                user: root
                password: null
                logging: true
                profiling: true
                profiling_collect_backtrace: false
                profiling_collect_schema_errors: true
                options: {  }
                mapping_types: {  }
                slaves: {  }
                replicas: {  }
                shards: {  }
        types: {  }
    orm:
        auto_generate_proxy_classes: true
        default_entity_manager: default
        entity_managers:
            default:
                naming_strategy: doctrine.orm.naming_strategy.underscore_number_aware
                auto_mapping: true
                mappings:
                    App:
                        is_bundle: false
                        type: annotation
                        dir: /Users/rafaelegli/Desktop/Server/drehscheibe/src/Entity
                        prefix: App\Entity
                        alias: App
                        mapping: true
                query_cache_driver:
                    type: null
                metadata_cache_driver:
                    type: null
                result_cache_driver:
                    type: null
                class_metadata_factory_name: Doctrine\ORM\Mapping\ClassMetadataFactory
                default_repository_class: Doctrine\ORM\EntityRepository
                quote_strategy: doctrine.orm.quote_strategy.default
                entity_listener_resolver: null
                repository_factory: doctrine.orm.container_repository_factory
                hydrators: {  }
                filters: {  }
        proxy_dir: '%kernel.cache_dir%/doctrine/orm/Proxies'
        proxy_namespace: Proxies
        resolve_target_entities: {  }

dh_auditor:
    enabled: true
    timezone: 'Europe/Zurich'
    providers:
        doctrine:
            table_prefix: ~
            table_suffix: '_audit'
            entities:
                App\Entity\Action: ~
                App\Entity\ActionUser: ~
                App\Entity\Address: ~
                App\Entity\AddressContactNote: ~
                App\Entity\AddressLog: ~
                App\Entity\Alert: ~

Hi @e9li
Could you please open a new issue? Also, do you also have annotations in your entities?


pull request for e2e test at 12/31/2016 21:56:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


feat: add lambda ruby wrapper for layer

This PR continues the work from https://github.com/open-telemetry/opentelemetry-lambda/pull/918.
Since ruby lambda instrumentation is released (rubygems), so it's time to create the actual wrapper for it.

Thanks @mwear.
@xuan-cao-swi Before merging this and testing the release process, please update the release-ruby-layer.yml release-group: prod to dev (or remove that line). After we're happy with the build artifact, we can change it back to prod.

@xuan-cao-swi Before merging this and testing the release process, please update the release-ruby-layer.yml release-group: prod to dev (or remove that line). After we're happy with the build artifact, we can change it back to prod.

Thanks @tylerbenson , I have updated to dev


Panic when fetching files from private repo

I'm trying to fetch a private repo with some LFS files, but then I'm running in this error:
$ git-lfs smudge images/freeing-from-isp/antenna-12dbi.jpg
Error downloading object: images/freeing-from-isp/antenna-12dbi.jpg (1fac16f7e0c1b632e79ddaed0bdbc70958c6de66cf2fdbcbe484f5a11b7e4e36)

exit status 1
goroutine 1 [running]:
github.com/github/git-lfs/lfs.Stack(0x0, 0x0, 0x0)
	/Users/rick/go/src/github.com/github/git-lfs/lfs/errors.go:557 +0x80
github.com/github/git-lfs/commands.logPanicToWriter(0x7f00906a01e8, 0xc8200262a8, 0x7f00906a0d00, 0xc8200eca30)
	/Users/rick/go/src/github.com/github/git-lfs/commands/commands.go:184 +0xf7f
github.com/github/git-lfs/commands.logPanic(0x7f00906a0d00, 0xc8200eca30, 0x0, 0x0)
	/Users/rick/go/src/github.com/github/git-lfs/commands/commands.go:148 +0x421
github.com/github/git-lfs/commands.handlePanic(0x7f00906a0d00, 0xc8200eca30, 0x0, 0x0)
	/Users/rick/go/src/github.com/github/git-lfs/commands/commands.go:123 +0x4e
github.com/github/git-lfs/commands.LoggedError(0x7f00906a0d00, 0xc8200eca30, 0x96a3a0, 0x21, 0xc8200f5c98, 0x2, 0x2)
	/Users/rick/go/src/github.com/github/git-lfs/commands/commands.go:73 +0x82
github.com/github/git-lfs/commands.smudgeCommand(0xb5cfa0, 0xc82000fbb0, 0x1, 0x1)
	/Users/rick/go/src/github.com/github/git-lfs/commands/command_smudge.go:77 +0xd89
github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra.(*Command).execute(0xb5cfa0, 0xc82000fb00, 0x1, 0x1, 0x0, 0x0)
	/Users/rick/go/src/github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra/command.go:477 +0x403
github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra.(*Command).Execute(0xb5dfe0, 0x0, 0x0)
	/Users/rick/go/src/github.com/github/git-lfs/vendor/_nuts/github.com/spf13/cobra/command.go:551 +0x46a
github.com/github/git-lfs/commands.Run()
	/Users/rick/go/src/github.com/github/git-lfs/commands/commands.go:88 +0x23
main.main()
	/Users/rick/go/src/github.com/github/git-lfs/git-lfs.go:34 +0x12e

Here is the clone with trace: http://pastebin.com/db5aiMe7
Here is the log: http://pastebin.com/ycdYErQ8

Your ssh attempt returned an error. Here's the relevant part from the first trace log:

trace git-lfs: ssh<EMAIL_ADDRESS>git-lfs-authenticate bcdonadio/blog.git download
trace git-lfs: ssh: download attempted with<EMAIL_ADDRESS> Error: exit status 1

What happens when you run ssh manually?
$ ssh<EMAIL_ADDRESS>git-lfs-authenticate bcdonadio/blog.git download

You should get a JSON object with href and header properties. Don't paste that for me :)

Oh. I think I can paste that.
$ ssh<EMAIL_ADDRESS>git-lfs-authenticate bcdonadio/blog.git download
Deploy keys can not access Git LFS objects on private repositories

I can't have a read-only key with LFS?

Ah, GitHub deploy keys don't work right now. It's on our list to fix.

Ok, not an issue with git-lfs, but with the github deployment, then.
Closing this issue.

@technoweenie Any update on this? I've checked my VCR cassettes into LFS because it was making pull-requests noisy but now I can't use Semaphore or any other CI.

Not yet.

Are there any workarounds for this? It's a blocking issue for us that prevents us from transitioning to our repos to GitHub.

The only work around now is using another form of authentication, including user ssh keys, oauth tokens, or personal access tokens.  I'll post in here once deploy key support is active on github.com.

Are there instructions somewhere for using personal access tokens in this way? I've heard that suggested elsewhere, but haven't been able to get it to work. I continue to get error messages about deploy keys.

Create one at https://github.com/settings/tokens and use it in place of your password.

What about using it from a cloud CI system that would otherwise use a deploy key? I've read the docs on the personal access token page, but am still not able to auth from Travis. Git is still trying to use the deploy key it has rather than the credentials I'm supplying it.

Ah yes, you'll want to use an HTTPS git remote. Personal access tokens don't work over SSH.

Hmm, that's still not working for me. I opened a support ticket, which might be a better place for this discussion. Although I'm also happy to continue here if that's preferable.

Deploy keys should work on github.com now. If not, send me details at https://github.com/contact so I can look into it. Or contact me there if you're interested in GitHub Enterprise.


Add translating info

Duplicate of #200

Duplicate of #200

Yeah fair enough, @westnordost is much more descriptive than mine.


Fix service uri test to fix issue on Xamarin

Test if url is relative (and not absolute) to bypass the behavior difference between IsWellFormedUriString in .NET and in Mono.
Discussed offline with @cthrash

Hi @Benjiiim, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Benjamin Talmard). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Thanks, Ben! This fix is already in the tree so closing out this PR


clang-format all the things!

This is mostly automated, although clang-format does not do well with long comments on the end of a line, e.g.
int x = 5; // this means that five is the value of x and x has the value five blah blah

so I had to fix these up manually.  I also added some TODO(jlebar)s for other cleanups I want to do.

Travis CI fails though. I suspect you just need to rebase onto my fix thereof.


Prepare release 1.10.18

Proposed changes:

patch fix release 1.10.18

@hotzenklotz tag is pushed, 1.10.18 should be on pypi in about an hour

Thank you very much! ❤


Download images more than 1000?

Hey, Thanks for the wonderful tool !! It's a great help.
I wanted to ask how to change the limit of -m which is max. limit 1000 right now.
If we want to download more than 1000 images, then what to do?

Hi.
Sorry for my late response. I don't think there is a way at the moment since that's a hard max. from the underlying module that fast class uses.


Docs: Add a section to explain how to make it work with nextjs and/or webpack

Hi there
I'm using nextjs and winston-loki which has snappy has a peerDependency, and I'm getting the following error:
error - ../../node_modules/.pnpm/@napi-rs+snappy-darwin-arm64<EMAIL_ADDRESS>Module parse failed: Unexpected character '�' (1:0)
You may need an appropriate loader to handle this file type, currently, no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
(Source code omitted for this binary file)

Import trace for requested module:
../../node_modules/.pnpm/@napi-rs+snappy-darwin-arm64<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>../../packages/next/dist/logger/index.js
../../packages/next/logger/index.mjs
./src/views/Homepage/server/getServerSideProps.tsx
./src/views/Homepage/index.ts

I think the error is because nextjs/webpack doesn't know how to process a file with an extension .node.
Maybe we can add, in the readme file, a section about how to fix this problem? 🤔 I have found this webpack-loader but I don't know if this is the recommended way.
Thanks.
SO: macOS
package manager: pnpm v7.18.0
winston: "v3.8.2",
winston-loki: "v6.0.6"
snappy: 7.1.1

After implementing the node-loader, now I get these errors:

@GiancarlosIO -- did you ever get this to work? I'm facing the same problem trying to use nextjs + webpack.

See https://github.com/napi-rs/use-napi-rs-packages-with-bundlers


feat(threat) adds a compatible parser with threat protection

The parser is compatible with the normal expat parser. It will check for a variety of constraints and error out if it hits one;
		depth = 3,				-- depth of tags

		-- counts
		maxChildren = 3,		-- max number of children (DOM2;  Element, Text, Comment,
		                        -- ProcessingInstruction, CDATASection). NOTE: adjacent text/CDATA
								-- sections are counted as 1 (so text-cdata-text-cdata is 1 child).
		maxAttributes = 3,		-- max number of attributes (including default ones), if not parsing
								-- namespaces, then the namespaces will be counted as attributes.
		maxNamespaces = 3,		-- max number of namespaces defined on a tag

		-- sizes
		document = 200,			-- size of entire document in bytes
		buffer = 100,			-- size of the unparsed buffer in bytes
		comment = 20,			-- size of comment in bytes
		localName = 20,			-- size of localname (or full name if not parsing namespaces) in bytes,
								-- applies to tags and attributes
		prefix = 20,			-- size of prefix in bytes (only if parsing namespaces), applies to
								-- tags and attributes
		namespaceUri = 20,		-- size of namespace uri in bytes (only if parsing namespaces)
		attribute = 20,			-- size of attribute value in bytes
		text = 20,				-- text inside tags (adjacent text/CDATA)
		PITarget = 20,			-- size of processing instruction target in bytes
		PIData = 20,			-- size of processing instruction data in bytes

Inspired by;

https://docs.sensedia.com/en/api-platform-guide/4.2.x.x/interceptors/security_xml-threat-protection.html
https://tech.forums.softwareag.com/t/xml-threat-protection/236959
https://docs.mulesoft.com/api-manager/2.x/apply-configure-xml-threat-task
https://github.com/Trust1Team/kong-plugin-xml-threat-protection

@mwild1 Any thoughts on this?

If it's:

[x] optional
[x] tested
[ ] documented
[x] doesn't bloat the library (~9KB)

it seems fine to me. I don't personally have a use-case for it, as I think limiting after parsing has less value than limiting before parsing. After parsing I'm not sure exactly what the attack vectors are.
I also didn't spot any tests where the problematic elements are split over multiple :parse() calls. I don't think it makes any difference for this code, but it's probably a case worth testing for.

I also didn't spot any tests where the problematic elements are split over multiple :parse() calls. I don't think it makes any difference for this code, but it's probably a case worth testing for.

These: https://github.com/lunarmodules/luaexpat/pull/3/files#diff-86a7914fbb76f29cacca5d77f9553eee05de506bfdb11a0a2c6d0af0ad0bd4b5R378-R454

it seems fine to me. I don't personally have a use-case for it, as I think limiting after parsing has less value than limiting before parsing. After parsing I'm not sure exactly what the attack vectors are.

So far what I've seen folks do is use libxml2, parse the full doc, traverse it and throw an error if it doesn't stay within the limits set. There is limited value in that, hence I wanted to create it on top of expat, since it streams.
While it streams it will record the validation error, stop the parser and when the parse call returns it will replace the results with the validation error.
So while not perfect, it will stream & validate, it does not depend on first parsing the entire document. So I think it addresses your comment...

So while not perfect, it will stream & validate, it does not depend on first parsing the entire document. So I think it addresses your comment...

Yeah, not the whole document I understand. Doing it after that is pointless :)
But some of the limits, such as the size of an attribute value, can only be caught after the string has been parsed and imported into Lua, right? So if I do: <data foo='[...2GB of data...]'/> it would blow up the RAM before rejecting the value. I guess I'm just not really sure what "threat" these limits are supposed to be protecting against.

Correct. Hence the generic document size to maximize the docs itself. And despite not being able to address the whole thing, memory pressure for validating "good" docs will be reduced drastically, whereas with crafted "bad" docs it will still go up. (use-case is a proxy, where the document is not actually consumed on the proxy itself, just validated before being send upstream)

But some of the limits, such as the size of an attribute value, can only be caught after the string has been parsed and imported into Lua, right?

just added a new commit that introduces "unparsed buffer" checks. That should deal with the issue.

converted to draft since it needs the new handlers from #17


[Spaces UX] Improve descriptions and labels

Description
Fixes https://github.com/dust-tt/tasks/issues/1736
Relatedly, bumps sparkle for front
Risks
na
Deploy
front

PMRR


feat(console): Adds custom commands based on container labels

Update
Finally implemented as
LABEL io.portainer.commands.my-command-name="mycommand"
--
Given we have an image/container running with lables as porainer.commands.*
e.g.
docker run --rm -it \
-l portainer.commands.ls_tmp="ls -lah tmp" \
-l portainer.commands.ls_workdir="ls -lah" \
bash bash

portainer commands section would add those to commands dropdown

idea is to have handy commands based on your image available in dropdown which I believe would be best to specify in Dockerfile as labels (rather than managing them in portainer instance)
closes similar #1684 #1874

@ncresswell thoughts on this?

Ok, this will probably need to be documented though. Not sure where as we don't have any user guide yet.
Should we add an information line to this view to specify that extra commands can be added via labels?

No, we can handle it from documentation and our “to be created” user guide.
From: Anthony Lapenna<EMAIL_ADDRESS>Sent: Thursday, 16 August 2018 7:35 AM
To: portainer/portainer<EMAIL_ADDRESS>Cc: Neil Cresswell<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [portainer/portainer] feat(console): Adds custom commands based on container labels (#2159)
Ok, this will probably need to be documented though. Not sure where as we don't have any user guide yet.
Should we add an information line to this view to specify that extra commands can be added via labels?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_pull_2159-23issuecomment-2D413310281&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=UMdZ-Yxo1E3QQOhbDoWIyd87wmfg6vPSBi_t5pu_Wag&s=1lUzoIFQpca5igHV2RvBkvWEi5N73Aj1-orDa-F0iVE&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlVmnpLni0UU5de9stQklvtSct4NNks5uRHfwgaJpZM4V9AbS&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=UMdZ-Yxo1E3QQOhbDoWIyd87wmfg6vPSBi_t5pu_Wag&s=iQiSFp5wH0egkn9BJldRZLIFlb1iiqDEHyYKdt_Hgxo&e=.

Thanks @hasnat :+1:

Is this feature documented anywhere? I could not find anything.

@tobiasholler indeed, it is not documented, we'll add it to our documentation.

on thing I noticed not long ago was with commands which are not interactive e.g. cat, ls they work but you only get to see results for split second, page reloads back to console screen. When it was implemented command output used to hang there,  being non interactive as intended. Probably needs to be looked after.

@hasnat yeah container console view was designed to work with interactive commands, maybe we can provide the same feature with the container-attach view, I'll discuss it internally.


Position ID in devices table sometime is Null or zero

I deploy the traccar server on a VPS-Windows and using with MySQL database.
System working with some mobile phones as clients.
But sometime the positionId don't appear in device record, so I can't locate where current device on the map. And one serious problem that the totalDistance attribute is reset to 0 after that.
This problem sometime happen with some devices not all devices.
Thank you for your help.

You should probably check logs and trace all the messages for the devices that have problems.

I think problem is here!
Do you have any suggestion to solve this problem?
Thanks

2017-10-01 15:24:12  WARN: Incorrect string value: '\xE1\xBA\xA3ng ...' for column 'address' at row 1 - SQLException (... < QueryBuilder:477 < DataManager:327 < DefaultDataHandler:27 < ...)
2017-10-01 15:24:12  WARN: Incorrect string value: '\xC6\xA1n, B...' for column 'address' at row 1 - SQLException (... < QueryBuilder:477 < DataManager:327 < DefaultDataHandler:27 < ...)

Errors like that usually mean incorrect database encoding. It has been discussed a few times before. Use search.


Added redis docker image

LGTM. Will merge then investigate the test failures, don't seem related to this


added offline google fonts

Solved issue #11, I added the css properties of the google fonts used in the code itself so that these fonts could be used while the system has no internet connection.

I have some suggestions regarding this PR:

It seems you are working on master branch. Ideally, you should avoid working on master/main. This is because, there may be newer changes in upstream which you may want to pull to the master of your fork. If you are working on master, pulling these changes in your master will be difficult. It is always preferred that you work on a feature branch and send a PR from that feature branch. This allows your master to easily sync with the upstream master. You can read the contribution guidelines for a good idea for the workflow.

@font-face seems like a good choice. However, you are still referencing an http url. This means that the user will need an active internet connection for the font to load. I wanted the ttf/woff/woff2 fonts included in the fonts folder itself. You can refer to this link for a step by step guide on how to do that.

I recommend you to change your branch and send a fresh PR. Thanks again :smile:


[Issue] Using --subscription with sub name causes portal link to break

Provide sub name --subscription with azd up
Click the portal link

To be honest, surprised how much actually worked :-).  I think internally we'll want to work in terms of Subscription IDs, so we should add code very early in the process that converts a subscription name to an ID and store that.


Use a single io_context

Turns out Timer for performing database cleanup was spawning its own thread... Replaced it with a plain steady_timer and existing io_context.

Oops, this broke unit tests. Will update in a moment.

Updated to make the tests pass again. Since Database no longer creates a new thread for clean-up, I create a new thread manually in it_removes_expired_entries, which is a hack (but it is how it's been used all along) since Database is not meant to be used in a multithreaded application.


Automation - Bumping the upstream Dockerimage version to python:3.7.12 for validation tests

The curl version in python:3.7.0 started to have issues with the test_certificates test suite.
The image python:3.7.12 has a newer curl version that worked fine locally while running these tests.

Rebased to include the AMI fix.
https://github.com/rancher/rancher/pull/36200

Jenkins run with the test_certificate test suite was successful.

LGTM


Add labels to RHODS YAML files

Fixes RHODS piece of MGDSTRM-7351

@tiffanynolan  @fmcdonal @AedinC @MelissaFlinn Please review.

also Aron responsible for RHODA checks were generated after er created his PR: https://github.com/redhat-developer/app-services-guides/pull/633

I spotted that the Approve and run button is now showing. I clicked it and it now generated the checks with 1 failing as suspected due to the schema file being updated.

Juntao walked me thru the whole process. What are "Checks"? He didn't say
anything about them.
Vince Conzola
Red Hat https://www.redhat.com/
100 E. Davie Street
Raleigh, NC 27609
@.***    T:<PHONE_NUMBER>
M:<PHONE_NUMBER>
https://red.ht/sig
On Tue, Feb 7, 2023 at 6:49 AM fmcdonal @.***> wrote:

@.**** approved this pull request.
all look good to me but I still see no "Checks" triggered from generating
the PR, could Juntao help?
—
Reply to this email directly, view it on GitHub
https://github.com/redhat-developer/app-services-guides/pull/634#pullrequestreview-1286946745,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFOEA6Z5QXD35RTUHSKRO2TWWIZFVANCNFSM6AAAAAAUTEHGCY
.
You are receiving this because you authored the thread.Message ID:
@.***
com>

@vconzola if you remember on our call I showed you the "Checks" tab beside "Files changed".

@fmcdonal I remember where they are in GitHub, I'm just trying to understand what they mean and how they get generated. But it looks like they're in there now, so I'm not going to worry about it.


Extra step on installing ESP32 SDK with xs-dev

Installing the ESP32 SDK through xs-dev setup --device=esp32 requires an extra step.
Environment is a MacBook Air M1 2020 running on macOS 13.1 (22C65).
⠧ Installing esp-idf tooling
All done! You can now run:

  . ./export.sh

✔ Installing esp-idf tooling
ℹ Sourcing esp-idf environment
✔
  Successfully set up esp32 platform support for Moddable!
  Test out the setup by starting a new terminal session, plugging in your device, and running: xs-dev run --example helloworld --device=esp32
  If there is trouble finding the correct port, pass the "--port" flag to the above command with the path to the /dev.cu.* that matches your device.

Problem is, the correct folder for running . ./export.sh is not mentioned .
Correct procedure is
cd /Users/USER/.local/share/esp32/esp-idf
. ./export.sh

Could xs-dev manage this extra step?
Thank you!

FWIW – Moddable SDK 3.5.0 and later takes care of that step automatically. That's mentioned in the release notes:

ESP32 builds in environments that have not sourced $IDF_PATH/exports.sh now automatically source it

That should eliminate the need for xs-dev to perform this step.

Thank you for your answers.
It is a good idea to silence the installer, as there is (too) much documentation to read!


Blog about the tools we use

https://coderefinery.zulipchat.com/#narrow/stream/141114-help/topic/the.20tools.20we.20use/near/274442615

Thanks for reminding about this. This would be a super useful write-up.


As a user, I want to grant specific permissions to others so that only certain people can access my files or folders.

As a user, I want to grant specific permissions to others so that only certain people can access my files or folders.


Document viewing locking strength with EXPLAIN

Fixes #6699, #6903, #6920.
Summary of changes:

Add a new section to EXPLAIN docs called 'Find out if a statement is
using SELECT FOR UPDATE locking', with an example showing how to
check.

List out the SQL statements that have support enabled by default for
SFU locking.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7304bbe86e784361b1dc3d013bb11e874b498809/
Edited pages:

v20.1/explain.md

@nvanbenschoten in case it helps your review, some context for the structure of only putting this on the EXPLAIN page is:
If you are using UPDATE, UPSERT, etc. and they are now magically faster under contention, you don't need to care. So we don't put any mention of locking on those pages.
However, if you are using EXPLAIN, you might be debugging or trying to figure something out, in which case we mention it here (with links to affected statements), since we must in any case mention the new EXPLAIN output field.
I do have a question as well:

Do you think we should link to the session var for toggling SFU locking from this EXPLAIN doc section?  Since folks are possibly testing/troubleshooting stuff here?  My sense was "maybe" but I'm not sure if/when users should ever toggle it unless they are pretty expert, and/or working with our Support team.  My sense is that linking it from here will tend to slightly "encourage" its use due to higher visibility.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8bc71450da665d54fbc8a419aa925650f2f1e62d/
Edited pages:

v20.1/explain.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/344d85a468e9deacb75fb61c60b048019aca44bb/
Edited pages:

v20.1/explain.md


Slight change for issues view

GitHub seem to have released a small change yesterday which uses columns on the PR page. These two CSS declarations are now breaking the display:
/* Issues/PRs */
.discussion-sidebar {
  width: 280px !important;
}
.discussion-timeline {
  width: calc(100% - 300px) !important;
}

I've found just removing them seems to revert to the old behaviour :+1:
Before

After

The fix worked for me. 👍

Was wondering why this was happening to me! I was ignoring for now haha. Can you open a PR?

One thing to mention. I did the same fix and now my files changed tab is a bit wonky and the comments are not full width.

In general the fix works good for me.
@SkylerLS I am not sure if I understand what screen is getting worse in your testing

The files changed screen of a pull request.
It is the 3rd tab beside Conversation | Commits | Files Changed

@SkylerLS I don't believe I ever changed the max-width for comments in code there.

May have been a conflicting extension then. I have a number of GitHub view and functionality related extensions. Consider my point to be invalid then! The original fix still worked for me.


Modified Table 3.

I changed the way to calculate thresholds and FPRs in Table 3. The central value of a threshold and a TPR was calculated by using the entire dataset in each selection criteria, but is calculated by the average of bootstrap resampling in this version.

Please revert the table calculations to include the threshold and TPR from the data themselves, while using the bootstrap samples to estimate the scatter.


snapshot/git/gitdb: implement bundlestore backend

Current coverage is 59.47% (diff: 47.05%)

Merging #209 into master will decrease coverage by 0.24%

@@             master       #209   diff @@
==========================================
  Files            81         82     +1
  Lines          3786       3884    +98
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2261       2310    +49
- Misses         1322       1357    +35
- Partials        203        217    +14

Powered by Codecov. Last update fc7239a...da394bb


peach: 0.9.8 -> 1.0.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/peachdocs/peach/releases.
meta.description for peach is: "Web server for multi-language, real-time synchronization and searchable documentation"
meta.homepage for peach is: "https://peachdocs.org/"
meta.changelog for peach is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.0.0 with grep in /nix/store/g99880nr1xfn5bfnypy4h3wqd2xx65i5-peach-1.0.0
found 1.0.0 in filename of file in /nix/store/g99880nr1xfn5bfnypy4h3wqd2xx65i5-peach-1.0.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
peach

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/g99880nr1xfn5bfnypy4h3wqd2xx65i5-peach-1.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A peach https://github.com/r-ryantm/nixpkgs/archive/fa9851e859c795010fef297fabca0f1fec7bed73.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/g99880nr1xfn5bfnypy4h3wqd2xx65i5-peach-1.0.0
ls -la /nix/store/g99880nr1xfn5bfnypy4h3wqd2xx65i5-peach-1.0.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

peach

Maintainer pings
cc @IvarWithoutBones for testing.

It looks like upstream has been renamed to ASoulDocs, that will need to happen in nixpkgs as well.

Renamed package to asouldocs in this PR: https://github.com/NixOS/nixpkgs/pull/188673


Added trade-off plot

@Lovemore-Gakava The trade-off plot is ready for your review.

@chen-chen-stat thanks for setting this up. I have added a few comments regarding adding the argument zscore and/ tscore in the functions to make them dynamic. We will need to update the readme to include the new figure. Otherwise all looks great.

@Lovemore-Gakava Thank you for your previous review and comments. The updated PR is ready for your review.


The Documentation section leads to a dead link

Trying to look at the documentation linked in the readme, leads to a dead link "https://nteract.gitbooks.io/hydrogen/".

It does work, no ?

I also can't access the documentation for some reason...

@paul-grassl I actually found out that our router/ISP/DNS was the problem. Check if you can access it from a different Wi-fi, or via 4G on your phone.
The solution for me was to add googles DNS (<IP_ADDRESS>) in my wifi settings.

thanks that resolved it for me :)


nixos/lib/test-driver: use QMP API to watch for VM state

Description of changes
Following https://github.com/nix-community/lanzaboote/issues/213
I realized that our test framework is terrible when it comes to boot-level crashes or hangs.
This is because the framework has no way to distinguish between a rightful long computation which shows random panic on the screen and an actual boot-level panic that prevent any further movement.
Who is responsible for knowing this? Computers usually have a concept of POST codes, which are there to communicate some code that says the current state of the machine, e.g. panicked, running, shutdown, memory failures, etc.
In VMs, there's no reason we could not have the same and even better.
This is what we attempt to bring by wiring up the QMP API which is the rich API that QEMU has internally and can keep us in touch with the current VM state: https://www.qemu.org/docs/master/interop/qemu-qmp-ref.html#qapidoc-81.
The only challenge of this PR is that the QEMU QMP API is inherently asynchronous, and our code is very synchronous. No problem, we will:

[ ] Create either an event loop per test or event loop for each machine (whatever make sense)
[ ] Schedule any async call on that event loop (loop.run(...))
[ ] We can schedule any listening of events on that loop and provide a handler to react with a reference to the Machine APIs.

The aim of this PR is to enable enough technology to showcase a fix of the mentioned issue in the first place.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Triggering eval after it was fixed on master.
@ofborg eval

@tfc I would like to get this merged as-is as any downstream consumer can start building things on the top of that.
Once we understand more how we want to drive this, we can incrementally improve the new APIs.
I also want to discuss the new APIs with @nikstur and @ElvishJerricco.

@ofborg test login

I think I fucked up and didn't rebase everything so will rerun the test
Le ven. 20 oct. 2023, 13:39, Jacek Galowicz @.***> a
écrit :

@ofborg https://github.com/ofborg test login
—
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/257535#issuecomment-1772667297,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACMZRE5UFDM2LT7V75VTGDYAJWHBAVCNFSM6AAAAAA5IQ3VSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZSGY3DOMRZG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

@ofborg test login

@RaitoBezarius, this PR introduced regression on non-NixOS machines!
Here is just a minimal NixOS test:

before PR, works: nix run github:alexoundos/minimal-nixos-test-flake?rev=b1a57b24eb74dde875ba441fe37a47940a4ef3bc#checks.x86_64-linux.dummy-test.driver
after PR, fails: nix run github:alexoundos/minimal-nixos-test-flake?rev=ecaf8ebcf3eb4b457744a501c279ee858f77a93d#checks.x86_64-linux.dummy-test.driver

Traceback (most recent call last):
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/bin/.nixos-test-driver-wrapped", line 9, in <module>
    sys.exit(main())
             ^^^^^^
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/__init__.py", line 126, in main
    driver.run_tests()
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/driver.py", line 159, in run_tests
    self.test_script()
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/driver.py", line 151, in test_script
    exec(self.tests, symbols, None)
  File "<string>", line 1, in <module>
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/driver.py", line 169, in start_all
    machine.start()
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/machine.py", line 1132, in start
    self.qmp_client = QMPSession.from_path(self.qmp_path)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/qmp.py", line 50, in from_path
    return cls(sock)
           ^^^^^^^^^
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/qmp.py", line 44, in __init__
    self.send("qmp_capabilities")
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/qmp.py", line 98, in send
    return self._wait_for_new_result()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/qmp.py", line 58, in _wait_for_new_result
    self.read_pending_messages()
  File "/nix/store/0q8sk7njr8nbbp2gww6m4yrm2f52j375-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/qmp.py", line 62, in read_pending_messages
    line = self.reader.readline()
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/qp5zys77biz7imbk6yy85q5pdv7qk84j-python3-3.11.6/lib/python3.11/socket.py", line 706, in readinto
    return self._sock.recv_into(b)
           ^^^^^^^^^^^^^^^^^^^^^^^
ConnectionResetError: [Errno 104] Connection reset by peer

(Sorry, the Traceback is not exactly from this test run, but the messages are the same)

@tfc, regardless of the problem cause on non-NixOS machines, I think it would be nice to have an option to disable QMP.

It would be nice to know the root cause though of the failure on non-NixOS machine, that's not normal.

It would be nice to know the root cause though of the failure on non-NixOS machine, that's not normal.

Agree. But I confirmed this behavior on 2 non-NixOS machines already. It's currently a blocker for our team, since we depend on running the test driver, passing arguments to it in non-interactive mode.
@RaitoBezarius, I should've noted that driverInteractive works just fine on non-NixOS: nix run github:alexoundos/minimal-nixos-test-flake?rev=ecaf8ebcf3eb4b457744a501c279ee858f77a93d#checks.x86_64-linux.dummy-test.driverInteractive --no-interactive. But such mode still opens up a qemu window which is not desirable (same behavior was before PR too).

Understandable, I guess you can revert this commit in the meantime but we really need a root cause analysis or more logs on what's going on. I don't have non NixOS systems that can run a VM test so... Unfortunately I cannot reproduce anything you sent so far.
It'd be helpful to have full systems details like OS, presence of sandbox, etc. What nix-info gives you.

@AleXoundOS I am not able to reproduce your problem on Debian 12

@AleXoundOS I am unable to reproduce your problem on Debian 12.

I am unable to reproduce your problem on Debian 12

Tested on Fedora and it works too!
The problem is indeed specific to Arch Linux. Both machines which fail are Arch Linux in my case.

(I just looked up this PR after brief confusion, so I'm going to leave this here for posterity.)
When qemu fails to run, e.g. because you specified fatally wrong QEMU_OPTS, then you might get a stack trace that will (on the surface) look like an error related to QMP. Look closer, and you'll realize that the problem occurs even earlier. Below, the root cause for being unable to connect to the QMP socket is the address resolution that failed earlier.

$ QEMU_OPTS="-vnc example.invalid:1337,reverse" ./result/bin/nixos-test-driver

Finished at 21:55:29 after 0s
[...]
additionally exposed symbols:
    client, server,
    vlan1,
    start_all, test_script, machines, vlans, driver, log, os, create_machine, subtest, run_tests, join_all, retry, serial_stdout_off, serial_stdout_on, polling_condition, Machine
>>> start_all()
start all VMs
client: starting vm
mke2fs 1.47.0 (5-Feb-2023)
qemu-kvm: -vnc example.invalid:1337,reverse: warning: short-form boolean option 'reverse' deprecated
Please use reverse=on instead
qemu-kvm: -vnc example.invalid:1337,reverse: address resolution failed for example.invalid:5500: Name or service not known
Traceback (most recent call last):
  File "", line 1, in
  File "/nix/store/…-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/driver.py", line 173, in start_all
    machine.start()
  File "/nix/store/…-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/machine.py", line 1089, in start
    self.qmp_client = QMPSession.from_path(self.qmp_path)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/…-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/qmp.py", line 50, in from_path
    return cls(sock)
           ^^^^^^^^^
  File "/nix/store/…-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/qmp.py", line 44, in __init__
    self.send("qmp_capabilities")
  File "/nix/store/…-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/qmp.py", line 98, in send
    return self._wait_for_new_result()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/…-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/qmp.py", line 58, in _wait_for_new_result
    self.read_pending_messages()
  File "/nix/store/…-nixos-test-driver-1.1/lib/python3.11/site-packages/test_driver/qmp.py", line 62, in read_pending_messages
    line = self.reader.readline()
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/…-python3-3.11.8/lib/python3.11/socket.py", line 706, in readinto
    return self._sock.recv_into(b)
           ^^^^^^^^^^^^^^^^^^^^^^^
ConnectionResetError: [Errno 104] Connection reset by peer

Of course it'd be nice if the testing framework would abort directly after the qemu failure. I don't know and didn't check whether that's possible.


Add bazel buildsystem support

This introduces necessary infrastructure and changes to make ign-common build with Bazel.

Looks good, but I'm getting a test failure in PluginLoader here. Are you getting any failures on your end?

Fixed


Fix broken unit tests

Two unit tests failed but where not fixed immediately

Solved in version 1.3.0


503 Service Unavailable

Hi,
Since this morning, I tried to compile with webpack but in my CI logs (on gitlab), I have this issue :
error An unexpected error occurred<EMAIL_ADDRESS>Request failed \"503 Service Unavailable\"".
Please let me know about it !
Thank you

The service is back so I close this issue !!

just to clarify, if yarn or npm have issues, you should not file bugs to every module you're trying to bundle :sweat_smile:


Gce guide

@caseydavenport I tried looking it up, but couldn't find any information on the GCE route limit