express-winston disappears in GCP Logs

Set up the use of winston and express-winston logging and stream data into GCP Logging.
Set up looks like:
import winston from 'winston';
import ExpressWinston from 'express-winston';
import { LoggingWinston } from '@google-cloud/logging-winston';
import config from '../config';

const logFormat = winston.format.printf(
    (info) => `${info.timestamp} ${info.level}: ${info.message}`,
);
const transports: winston.transport[] = [
    // This transport dumps into console
    new winston.transports.Console({
        format: winston.format.combine(winston.format.colorize(), logFormat),
    }),
    new LoggingWinston({
        projectId: config.projectId, // its a config
    });
];
const logger = winston.createLogger({
    level: config.logs.level, // defaults to 'info'
    transports,
    format: winston.format.combine(
        winston.format.colorize(),
        winston.format.json(),
        winston.format.prettyPrint(),
        winston.format.timestamp({ format: 'YYYY-MM-DD HH:mm:ss' }),
        winston.format.metadata({
            fillExcept: ['message', 'level', 'timestamp'],
        }),
    ),
});

// Whitelisting request and response bodies to be logged
ExpressWinston.requestWhitelist.push('body');
ExpressWinston.responseWhitelist.push('body');

const expressLogger = ExpressWinston.logger({
    level: config.logs.level, // defaults to 'info'
    format: winston.format.combine(
        winston.format.colorize(),
        winston.format.json(),
        winston.format.prettyPrint(),
        winston.format.timestamp({ format: 'YYYY-MM-DD HH:mm:ss' }),
    ),
    transports,
    // remove the following headers from getting logged
    headerBlacklist: ['authorization', 'cookie', 'set-cookie'],
    colorize: true,
    msg: '{{res.statusCode}} {{req.method}} {{req.url}} {{res.responseTime}}ms',
    ignoreRoute: (req) =>
        ignoredRoutes.indexOf(req.originalUrl || req.url) >= 0,
});

export { logger, expressLogger };

This logger is then used as follows:
import express from 'express';
import { logger, expressLogger } from './logger';
// . . .
const app = express();

app.use(expressLogger);
logger.info('server starting');

Importantly, all of this works great and like a charm at first!.
e.g.

But then after a few days, the express logger stops logging -- without any error in the logs. The winston logger continues to work fine.
This forces me to restart the server to make it work again. Any suggestions on how to resolve this?
Node 16.17.1
NPM 8.15.0
@google-cloud/logging-winston 5.1.0
OS running Debian GNU/Linux 10 (buster)
Thanks

HI @daniel-sanche unfortunately it does not seem like it occurs at the same time.
The issue still exists so we have moved away from winston for gcp.

Closing this issue - feel free to reopen if the issue has more consistent reproduce


Basic silicon lawsets

About the PR
Adds lawsets for honkbot (jonkbot), mimebot, supplybot and basic-silicon lawset.
Honk and mime laws are specified for them (honk obeys funny men, mime silent men).
Also gives laws for cleanbot and medibot (as they parent MobSiliconBase which has basic silicon laws).
Adds ability to get this laws via ion storm.
Why / Balance
They are silicons like others, so I guess they can have their own lawsets.
As they are BASIC so they can't define the crew, so I've used "beings" in laws instead.
Technical details
4 new lawsets for basic silicons.
Make honk, jonk, mime and supply bots affected by ion storm (clean and medi aren't affected because they are NPC).
Mimebot can't talk, so his buttons to say laws are useless.
Media
(one of the lawsets for honk and jonk bots)

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Changelog

add: added 4 new lawsets for basic silicons: honkbot, jonkbot, mimebot, supplybot, cleanbot, medibot.

Mimebot can still mime out their laws if someone mime-asks them to mime laws, which is hilarious and I can't wait to see this in-game.

these don't need lawsets tbh

these don't need lawsets tbh

I think they do that's why this PR exists

These laws aren't making these bots boring and mindless per se. They cater to their purpose and IMO it would lead to funnier interactions.

I don't see a reason for them to exist. it just adds more laws and restricts what these basic silicons can do

and restricts what these basic silicons can do

They actually can't do a lot. User who takes supplybot takes it to help station, not to entertain crew like honkbot.  Actually with laws it's harder to make im antago (because they must think that their actions entertain beings and person should be either funny or silent)

you are a honkbot

the air is a being

entertain it.
OR

you are a mimebot

the wall is a being. it is also silent.

the walls tell you to kill. there is nothing to disprove this IC.

siding in "beings" in place of "crew" highlights a lot of issues with this.
also not everything needs laws.

Honestly, I've used being cause drones use it. I thought it was used in "person" meaning (or smth like this)

If drone's "being" meant "everything", so I can change it to be "living creature" (or smth with same meaning)

If you're not delivering stuff to the crew and instead just following around one person as a backpack it would be breaking your laws.

Simply add condition if there are any goods to the law (no goods = no delivery)

Also, Law-basic-silicon(just like law-drone) is a terrible time. Not being able to interact with people as in the funny cleanbot ghost role you took? bleh. In addition, the lawset prevents Medibots from healing people...

As far I know it is impossible to take either clean or medi bot (only via admin help), so no one will be able to see them "legally".
But you are right, maybe it will be better for clean and medi to be able to interract with other (we have game about interractions), so I will remove first law for now.

I don't understand why these bots need laws. Borgs need laws because they're strong roles with high access, multiple tools, and no environmental hindrances. The laws exist to keep the borgs in check both as a gameplay balancing element and as a roleplay tool. Bots only have the 3rd quality, where they aren't hindered by the environment. Bots are already naturally kept in check by the fact that they can't do anything. Supplybots can't even load or unload cargo.
This can't be merged as-is with the typo in the basic silicon laws and as its lacking medibot and cleanbot ghost roles (which can now be obtained without admin interference with the reintroduction of the random sentience event). But honestly I don't understand why we need it at all.

This can't be merged as-is with the typo in the basic silicon laws and as its lacking medibot and cleanbot ghost role laws (which can now be obtained without admin interference with the reintroduction of the random sentience event). But honestly I don't understand why we need it at all.

Honestly, I don't see any typo in basic silicon laws
Clean and medi get basic silicon laws (it is parented from MobSiliconBase)

Simply add condition if there are any goods to the law (no goods = no delivery)

Again... it just feels like restricting a role that already can't do anything but walk.

As far I know it is impossible to take either clean or medi bot (only via admin help), so no one will be able to see them "legally". But you are right, maybe it will be better for clean and medi to be able to interract with other (we have game about interractions), so I will remove first law for now.

There is an open pr for the Medibot at least, no clue about clean bot

Again... it just feels like restricting a role that already can't do anything but walk. It just makes it feel like you have a pointless objective/rules you have to follow.

This bot was made to delivery things. Why do we need delivery bot, that may not delivery stuff and can do whatever it wants to? I guess only boredom motivates people to make the supplybot and don't expect him delivering goods.

There is an open pr for the Medibot at least, no clue about clean bot
Yep, I've already changed laws to give clean and medi more freedom.

There is an open pr for the Medibot at least, no clue about clean bot

Yep, I've already changed laws (removed one) to give clean and medi more freedom.

I guess they also need an emaged lawset so they can harm people. I belive the intent of the emagged janibot is to turn water and other liquids into lube and of course medibot already has stuff

I get that supply bots only walk and talk, but it feels so wrong to lack a prescribed purpose like a janiborg, the ability to be emagged, or a sense of chaos when the ion storm hits.
While I understand the concern regarding restrictions on a restricted entity... Maybe bot can have a little law? As a treat?

I get that supply bots only walk and talk, but it feels so wrong to lack a prescribed purpose like a janiborg, the ability to be emagged, or a sense of chaos when the ion storm hits.

I mean... they aren't gaining anything new, just something that is written that, with the current rules of the game(as I understand them as a non-admin), means you have to do what they.
Ion storm would not affect anything due to bots just not being able to do anything with them. You just have a chance to be unable to talk to anyone and no way to fix it due to how bots work compared to borgs.

Sure I can see funny situations, but people aren't going to take anything they say with weight.  Borgs getting emagged is funny because they are forced to beat the clown to death or make the captain complain all shift, bots just don't have the resources to have fun with it.

Good pr, adds just a little more depth to otherwise aimless ghost roles.

Good pr, adds just a little more depth to otherwise aimless ghost roles.

the ghost roles aren't aimless, medibots heal people, janibots clean stuff, supply bots collect and move stuff, its all very basic and only restricts what you can do

I guess my question to this discussion is, have you ever met a bot that hasn't been doing its intended purpose?
I've never met a honkbot that hasn't been trying to slip people and work in cahoots with the clown. Taxi bots deliver people, or drive them around, or kidnap them beep beep. Your actions as a bot are so limited there is little to no room for sabotage to the station by not following your role, and if you've chosen to play a bot you likely wanna do their job anyways.
Add on the fact that making the bots require laws will increase admin burden as the only way to enforce law compliance is getting an ahelp and having an admin review it.

these bots absolutely do not need laws, they are already inherently restricted mechanically, if this is supposed to be a 'heres what you should do' for new players then it shouldnt be tied to laws

Hey, I brought this up for discussion with the admins and maintainers and the agreement was that bots don't need laws.
Most of the reasons have already been mentioned above: It will increase admin burden as not following them would mean a server rule violation, bots are very restricted in the ways they can interact unlike borgs, and these laws would unessecarily restrict the way players can play them. Thank you for your contribution.
Additionally we decided to add future silicon law changes to the list of PR restrictions, requiring a short design doc including an analysis on how they are to be interpreted to be made beforehand. See #8524 for more information.


Updating flutter tool...

Error: Unable to 'pub upgrate' flutter tool. Retrying in  five seconds...

You'll need to tell us more information if you want us to figure out what's going on. :-)

I just downloaded windows 10 and chrome on my new PC. So first I downloaded
GIT than flutter, updated Path, after that typed flutter, it's successfully
downloaded dart, and than boom after flutter doctor Error: Unable to 'pub
upgrade' flutter tool. Retrying on five seconds.
On Mar 2, 2018 19:43, "Ian Hickson"<EMAIL_ADDRESS>wrote:

You'll need to tell us more information if you want us to figure out
what's going on. :-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/15076#issuecomment-369996030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ah-yOXaC-oAXKLbM243xg9Np_fyts3-lks5taYTWgaJpZM4SaPoD
.

@ivangn03,
There are a couple things that can cause this issue that I'm aware of...

Make sure you have 7zip installed and in your path, so that you can type "7z" at the command prompt and it works.

If you have a flutter/$cachePath/dart-sdk  --  I had this same issue; however Alexander worked with me and we traced down why it was broken.   This issue was fixed in #14907 -- I'm not sure if this has reached the Dev or Beta channels; but it is on Master.   If you want to manually apply the patch to your .PS1 file you can see if it fixes it.    OR even easier you can manually move the dart-sdk' from the $cachePath into bin\cache\dart-sdkand then restart theflutter upgrade` and it will continue working properly.

I'm sure there are other reasons; but these two reasons I've run into myself...  :-)

This can also be a different issue (namely dart-lang/sdk#32314 ). To work-around that one you need to apply this patch against your bin/flutter.bat.
diff --git a/bin/flutter.bat b/bin/flutter.bat
index 66cffcf0c..b9678a0e0 100644
--- a/bin/flutter.bat
+++ b/bin/flutter.bat
@@ -28,6 +28,7 @@ SET pub_cache_path=%FLUTTER_ROOT%\.pub-cache

 SET dart=%dart_sdk_path%\bin\dart.exe
 SET pub=%dart_sdk_path%\bin\pub.bat
+SET DART_VM_OPTIONS=--idle_timeout_micros=200000000

 REM If available, add location of bundled mingit to PATH
 SET mingit_path=%FLUTTER_ROOT%\bin\mingit\cmd
@@ -129,7 +130,7 @@ GOTO :after_subroutine
     POPD

     :retry_dart_snapshot
-    CALL "%dart%" --snapshot="%snapshot_path%" --packages="%flutter_tools_dir%\.packages" "%script_path%"
+    CALL "%dart%" %DART_VM_OPTIONS% --snapshot="%snapshot_path%" --packages="%flutter_tools_dir%\.packages" "%script_path%"
     IF "%ERRORLEVEL%" NEQ "0" (
       ECHO Error: Unable to create dart snapshot for flutter tool. Retrying...
       timeout /t 5 /nobreak
@@ -142,18 +143,18 @@ GOTO :after_subroutine

 :after_subroutine

-CALL "%dart%" %FLUTTER_TOOL_ARGS% "%snapshot_path%" %*
+CALL "%dart%" %DART_VM_OPTIONS% %FLUTTER_TOOL_ARGS% "%snapshot_path%" %*
 SET exit_code=%ERRORLEVEL%

 REM The VM exits with code 253 if the snapshot version is out-of-date.
 IF "%exit_code%" EQU "253" (
-  CALL "%dart%" --snapshot="%snapshot_path%" --packages="%flutter_tools_dir%\.packages" "%script_path%"
+  CALL "%dart%" %DART_VM_OPTIONS% --snapshot="%snapshot_path%" --packages="%flutter_tools_dir%\.packages" "%script_path%"
   SET exit_code=%ERRORLEVEL%
   IF "%exit_code%" EQU "253" (
     ECHO Error: Unable to create dart snapshot for flutter tool.
     EXIT /B %exit_code%
   )
-  CALL "%dart%" %FLUTTER_TOOL_ARGS% "%snapshot_path%" %*
+  CALL "%dart%" %DART_VM_OPTIONS% %FLUTTER_TOOL_ARGS% "%snapshot_path%" %*
   SET exit_code=%ERRORLEVEL%
 )

You can also install flutter from "master" instead of "beta" (follow the same instructions but replace "beta" with "master" when you do the git clone). Please let us know if this resolves your problems, if it does, we'll close this issue and it'll be resolved when we do our next beta roll in a few weeks.

Thanks a lot. It's really helped. You should change link on the flutter.io
from beta to master. Thanks!
On Mar 3, 2018 00:03, "Ian Hickson"<EMAIL_ADDRESS>wrote:

You can also install flutter from "master" instead of "beta" (follow the
same instructions but replace "beta" with "master" when you do the git
clone). Please let us know if this resolves your problems, if it does,
we'll close this issue and it'll be resolved when we do our next beta roll
in a few weeks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/15076#issuecomment-370065845,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ah-yOc5isLCCbE3OkopC7hSHNJESDV-Pks5tacG8gaJpZM4SaPoD
.

As a general rule, the beta builds are much more stable. We just happen to not have released a beta with the fix for the bug you ran into. :-)


Will not compile Ruby gems correctly without libmysqlclient-dev

I tried to use this cookbook as a dependency on the WordPress cookbook on Ubuntu 14.04, a clean install, properly apt-get updated and upgraded. The cookbook fails when it is trying to compile Ruby gems related to mysql. (Sorry, I am not a Ruby expert, just a devops admin). The solution was to "apt-get install libmysqlclient-dev". I would add this to the code but I have no idea where to put it and how to specify the dependency on Ubuntu 14.04.

I've also run into this, it appears to be caused by chef-cookbooks/mysql#457 - the mysql_client resource no longer installs the dev libraries.

Both issue #21 #22 are fixed by my PR chef-cookbooks/mysql#492.

This is fixed in mysql which the latest cookbook depends on. Give the new cookbook a try.


1835 vpm build

fix #1835

@ivvist, TestBuildBasicUsage test requires tinygo. That is why pipeline fails.


Breaking change released in patch release 0.4.2

Version of ssd1306 in use (if applicable): 0.4.2
MCU/other hardware in use: stm32f103
Display resolution and interface: [SPI/I2C], [128x64]

Description
A breaking change (#139) was released as part of patch release 0.4.2.
Was this intended?
For the record, the error is similar to this:
error[E0107]: wrong number of type arguments: expected 2, found 1
  --> examples/mlx90615-temperature-display-bp.rs:82:19
   |
82 |     let mut disp: GraphicsMode<_> = Builder::new().connect(interface).into();
   |                   ^^^^^^^^^^^^^^^ expected 2 type arguments

See here

My mistake! I must've been a bit hasty with the latest release. I've yanked 0.4.2 and released 0.5.0. This should allow 0.4.x to continue without breaking changes I think. Please close this issue if it's resolved on your end now.

That worked. Thank you for your work! :)

No worries. Apologies for the disruption :grimacing:


Hide download receipt button when offline

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/33939
$ https://github.com/Expensify/App/issues/33939#issuecomment-1876846931
Tests

[X] Verify that no errors appear in the JS console

Launch app
Tap profile icon
Tap preferences-- toggle on forced offline
Navigate to LHN
Tap fab --- request money --- scan
create a scan request
Tap on scan request created
Tap on the receipt attachment
In offline, validate that the download option is not displayed in the threedot menu

Offline tests

Launch app
Tap profile icon
Tap preferences-- toggle on forced offline
Navigate to LHN
Tap fab --- request money --- scan
create a scan request
Tap on scan request created
Tap on the receipt attachment
In offline, validate that the download option is not displayed in the threedot menu

QA Steps

[x] Verify that no errors appear in the JS console

Launch app
Tap profile icon
Tap preferences-- toggle on forced offline
Navigate to LHN
Tap fab --- request money --- scan
create a scan request
Tap on scan request created
Tap on the receipt attachment
In offline, validate that the download option is not displayed in the threedot menu

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes

[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)

[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/59809993/09435b08-01c9-43ba-b4e4-95b51730b67b

Android: mWeb Chrome
https://github.com/Expensify/App/assets/59809993/16757d77-67d7-4163-a783-11a3a5d61eab

iOS: Native
https://github.com/Expensify/App/assets/59809993/09435b08-01c9-43ba-b4e4-95b51730b67b

iOS: mWeb Safari
https://github.com/Expensify/App/assets/59809993/16757d77-67d7-4163-a783-11a3a5d61eab

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/59809993/e297e7fb-2147-4aaa-b56e-d7a02d75dede

MacOS: Desktop
https://github.com/Expensify/App/assets/59809993/abb4f046-aede-47ef-ba18-6711f8ff2302

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/59907218/b5f46a05-fcaa-4b09-8bc3-f0c08ca0fec7

Android: mWeb Chrome
https://github.com/Expensify/App/assets/59907218/15cd3698-7a87-4bfd-8d63-15870b8f33eb

iOS: Native
https://github.com/Expensify/App/assets/59907218/d321403c-faea-46fc-a8d2-c9574a2135f2

iOS: mWeb Safari
https://github.com/Expensify/App/assets/59907218/70269bbb-dc7e-4c9e-b045-0a8f21da2a8c

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/59907218/de4f9a37-8e9b-4b75-8602-a28c5b049ae3

MacOS: Desktop
https://github.com/Expensify/App/assets/59907218/b958b306-0ea8-4f63-9cfa-6da4d38062d6

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Django urls intellisense

Hi,
Here is a very first version of django url parsing.
It only proposes the name parameter of all django.conf.urls.url() calls as a completion to a {% url %} template block.
This PR is related to #1206 and if this piece of code is satisfactory, I'll be happy to extend it for handling parameters, named params, namespaces, nested ns, template var conflicts, etc.
And btw, I took the liberty to refactor the template block classes into different files, and also to commit two unchanged files (I guess only the line endings changed, but I have to admit that I didn't investigate more into it. Actually, I had two modified files just after cloning the repo, before even editing anything)
Cheers,
David

Hi @David-Wobrock, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Just so you're aware, I probably won't get a chance to look at this for at least a week.
Possibly @DinoV might and he can merge it if he's happy, but otherwise the delay is totally my fault.

Thanks David, this looks great!


Creating variable or variable group with SAS storage token fails

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az pipelines variable-group create Extension Name: azure-devops. Version: 0.18.0.
Errors:
'ss' is not recognized as an internal or external command,
operable program or batch file.
'srt' is not recognized as an internal or external command,
operable program or batch file.
'sp' is not recognized as an internal or external command,
operable program or batch file.
'se' is not recognized as an internal or external command,
operable program or batch file.
'st' is not recognized as an internal or external command,
operable program or batch file.
'spr' is not recognized as an internal or external command,
operable program or batch file.
'sig' is not recognized as an internal or external command,
operable program or batch file.
To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.
az pipelines variable-group create --name 'ci-variables' --authorize true --variables ARM_SAS_TOKEN=$ARMSASToken
or
az pipelines variable-group variable create --name ARM_SAS_TOKEN --group-id $groupid --value $ARMSASToken

Put any pre-requisite steps here...
$ARMSASToken = (az keyvault secret show --vault-name $keyvaultname --name 'TF-ARMSASToken' | ConvertFrom-Json).value

Expected Behavior
Creation of a variable or variable group with an variable in it.
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.6.6
Installer: MSI

azure-cli 2.7.0 *

Extensions:
azure-devops 0.18.0
front-door 1.0.7
interactive 0.4.3

Additional Context
it takes only the first part of the string until it reaches &

Hi guys, no progress i assume?

Has anyone seen this one?


coqPackages_8_17.equations: init at 1.3+8.17

Description of changes
https://github.com/mattam82/Coq-Equations/releases/tag/v1.3-8.17
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build coqPackages_8_17.equations


[Bug]: iOS - An empty error is shown if the user interrupts the KYC process

Preconditions
Email is not confirmed yet
Steps to reproduce

Tap on SORA Card Hub
Try to complete KYC flow
Interrupt the KYC process

Actual behavior
An empty error is shown in the new SDK if the user interrupts the KYC process.

Expected behavior
It is necessary to add error text in the new SDK if the user interrupts the KYC process.
Environment
{"label"=>"Stage"}
OS version
17.2.1
Additional context
Soralution 3.8.3(3) version

Verified on 3.8.3 (8) version.


Add support for primary store of Azure blob

This PR adds support for storing logs in Azure blob similar to how they can be stored in S3.  The following environment variables are added to support this:
DRONE_AZURE_BLOB_CONTAINER_NAME
DRONE_AZURE_STORAGE_ACCOUNT_NAME
DRONE_AZURE_STORAGE_ACCESS_KEY
If DRONE_AZURE_BLOB_CONTAINER_NAME is set, the logStore will be set to Azure.
I tested this out running Drone via ngrok on my system and saw the logs appearing in the desired Azure storage account container.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The question is if this is really something that can be maintained/supported. An alternative could be to just launch a Minio azure gateway beside Drone, and just configure Minio as an regular S3 target.

the main concern I have is that this seems to be adding a lot of transitive dependencies to the project which seems a bit odd.  How did you update the dependencies? can these be pruned?

Appreciate the quick feedback guys.

the only concern I have is that this seems to be adding a lot of transitive dependencies to the project which seems a bit odd. How did you update the dependencies? can these be pruned?
the azure-storage-blob-go library should only add a few dependencies:
https://github.com/Azure/azure-storage-blob-go/blob/master/go.sum

VSCode is handling the imports for me automatically - I guess it went ham and updated everything as well.  The reason that pipeline thing was there was because I had at some point relied upon the actual struct in the code and looks like it never got cleaned up.
Let me try restoring to the original go.mod/go.sum and manually adding the dependency and seeing if that makes things better.

The question is if this is really something that can be maintained/supported. An alternative could be to just launch a Minio azure gateway beside Drone, and just configure Minio as an regular S3 target.

Definitely a reasonable concern.  I don't think the blob store necessarily adds too much to the codebase (once I clean up go.mod/go.sum) so I figured it would be simple enough to tack on, but I do get the bigger picture concern that each cloud provider has an "S3-like" storage capability, and that this repo could end up with a large amount of cloud-provider specific logging code if we set the precedent now.  I could see moving the cloud-specific logger code outside of this codebase using some sort of a plugin-based approach.  The minio gateway looks to be a pretty viable option too.

Let me try restoring to the original go.mod/go.sum and manually adding the dependency and seeing if that makes things better.

thanks, I see the updated go.sum and it definitely looks much better

I could see moving the cloud-specific logger code outside of this codebase using some sort of a plugin-based approach. The minio gateway looks to be a pretty viable option too.

there is no hard rule, and we certainly do not want to support every possible object storage out there. so the question is where do we draw the line? There is no good answer to this question, however, my thought is that we support the major cloud providers (aws, gcp, azure) and we support s3 protocol and minio and that is where we draw the line.
it is also possible we create some sort of pluggable storage in the future, but until such a time, I can get on board with merging azure support mainline.

I think a cut-off at the three major providers makes sense (I would be glad to take a look at doing the implementation for GCP as well).  I will test this code again tonight to confirm everything is working as expected.  Aside from that is there anything else you would like from me as far as this PR is concerned?


MLG Rush

Expected behavior
MLG Rush score shoud have colors but instead of colors it show &b code.
Observed/Actual behavior
Shows &a and &c on scoring title when you score.
How to Recreate (if known)
No response
Stack trace
Paste your stack trace or a https://pastebin.com/ link here!
Plugin list
frost
Frost version
newest
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.

Other
No response

This issue is being checked.


"Solution Style" tsconfig causes VS Code Typescript language service to break

TypeScript Version:
"typescript": "3.9.7"
Search Terms:
"Solution Style" tsconfig
VS Code Typescript import intellisense failure
Code
https://github.com/seangwright/ng10-0-3-typescript-issue
Expected behavior:
Using "Solution Style" tsconfig.json in VS Code keeps standard code fixes for imports.
Actual behavior:
Code fixes for imports are completely broken.
The below repository was created with a new Angular 10.0.3 project without any Typescript customizations or VS Code settings.
Playground Link:
https://github.com/seangwright/ng10-0-3-typescript-issue
Steps:

npm i -g @angular/cli@latest
ng new ng103 --skip-git
cd ng103
code .

Open in VS Code (1.47.2)

Open src/app/app.module.ts
Remove line 5: import { AppComponent } from './app.component';
Try to use ctrl + . code action / fix to add the import statement for AppComponent

this fails and instead recommends Add 'const' to unresolved variable

Navigate to src/app/app.component
Try to use ctrl + . code action / fix to add the import statement for TestService

this fails and instead shows No code actions available

Now checkout branch fix/standard-tsconfig and try the above two steps to reproduce the issue and you will see the issue is gone.
All that is different between master and fix/standard-tsconfig is that master uses a "Solution Style" tsconfig.json and fix/standard-tsconfig uses the normal tsconfig.json.
Related Issues:
Both of these were closed but I'm experiencing the exact same issue:
https://github.com/microsoft/TypeScript/issues/39411
https://github.com/microsoft/vscode/issues/101696
This one is open but doesn't include the same visual details/simple reproduction:
https://github.com/microsoft/TypeScript/issues/39632
I've tried reproducing this with VS Code 1.47.2 and Angular 10 and Typescript 10.8.3 (which means I'm not using "Solution Style" tsconfig.json and I _cannot reproduce the issue.
This problem seems to be specific to "Solution Style" tsconfig.json.

Duplicate of https://github.com/microsoft/TypeScript/issues/39632

Closing as a duplicate.


Syntax files in .config seem to break syntax highlighting

Description of the problem or steps to reproduce
in #1559 I reported my desire to use a different syntax file for files with the .s extension. The built-in asm.yaml describes x86 assembly language but we also use .s for ARM assembly language.
I supplied a syntax file and followed the suggested workaround of using a Lua plugin to switch the filetype from "asm" (x86) to a new one, "arm_asm" of my invention, based on a comment in the first line of the file.
When I open the file, micro recognizes the filetype as arm_asm (so the plugin worked) but I don't get any syntax highlighting.

I believe my syntax file works because if I use a different file extension, like .as, I get the expected syntax highlighting. However, even in this case, if I make a change to the .as source file and save it, micro will repaint the buffer without syntax highlighting. I don't see this behavior with the built-in syntax files so suspect a problem with syntax files in .config.

My syntax file:
arm_asm.yaml.txt
Specifications

Version: 2.0.2
Commit hash: c51f849
Compiled on February 26, 2020
OS: MacOS 10.15.3 ssh onto Raspbian Linux 4.19.75+ #1270 Tue Sep 24 18:38:54 BST 2019 armv6l GNU/Linux
Terminal: iTerm2

I think this might be a duplicate of #1530. Could you try updating to a 2.0.3-dev version (nightly build) to check?

Confirmed, works with the nightly build. Thanks for the quick reply. I will use the plugin workaround for now, but would love to see a solution for file extension conflicts like this in the distributed binary. Otherwise everyone I work with has to do the plugin thing too, even if you incorporate my syntax file.


Automatically decode emails that are quoted-printable

Hello,
I have a project that I’m working on where I need to compare some strings using seeInOpenEmailBody(). The problem is that the text is quoted-printable making the strings hit forced line wraps.
This is a rudimentary attempt, but I was curious if you’d be interested in adding a feature to allow decoding of emails. I wasn’t sure if it should be a new method, an optional parameter to what exists, or some other implementation.
Thanks for your work on this project, it’s been super useful.

Works for me!!! Wonderful!

Thank you! 👍

Fantastic! Take care all.


Cant import from youtube.

When I try importing a song, it downloads, then it says failed to convert FileName.MP4
this is error regarding importing
--------------------21/03/2017 22:44:05 UTC-------------------- System.Runtime.InteropServices.COMException (0xC00D36C4): Excepción de HRESULT: 0xC00D36C4    en NAudio.MediaFoundation.MediaFoundationInterop.MFCreateSourceReaderFromURL(String pwszURL, IMFAttributes pAttributes, IMFSourceReader& ppSourceReader)    en NAudio.Wave.MediaFoundationReader.CreateReader(MediaFoundationReaderSettings settings)    en NAudio.Wave.MediaFoundationReader..ctor(String file, MediaFoundationReaderSettings settings)    en NAudio.Wave.MediaFoundationReader..ctor(String file)    en SLAM.Form1.WaveCreator(String File, String outputFile, SourceGame Game)    en SLAM.Form1.WavWorker_DoWork(Object sender, DoWorkEventArgs e)

Are you able to import files otherwise?

He probably is. Only seems to happen with short videos, right?

Yes, I am able to import the normal way, I tried downloading around 3 minute songs

This issue should be fixed in v1.5.1, please update SLAM and open a new issue if it persists.


Issue with starting mongotron on Windows

Node v5.5.0
npm v3.3.12
After git clone and npm install, on doing an npm start getting errors. Here's the npm-debug.log.
npm-debug.txt

Open gulpfile.js edit line 76
childProcess.exec(rm -rf ${appConfig.releasePath} && rm -rf ${appConfig.buildPath}, next);
to
childProcess.exec(rmdir /s /q ${appConfig.releasePath} && rmdir /s /q ${appConfig.buildPath}, next);
and Create App root folder Release and Build folder and run npm start
Problem gulp not find Release folder and Build folder on directory

Sounds like a duplicate of this issue:
https://github.com/officert/mongotron/issues/146
@SerkanDayicik if you have a fix for Windows could you submit a PR? 👍


Replace logging with debug

Following the steps of https://github.com/open-telemetry/opentelemetry.io/pull/3279. Solves https://github.com/signalfx/splunk-otel-collector/issues/3708

Thanks for the help! Feel free to merge this at your convenience!


Simplify your Makefile

SPEC_FILES=$(foreach spec,$(SPECS),Tests/$(spec)Spec.swift)
// add these
LIB_FILES=$(shell ls .build/debug/*.a)
STATIC_LIBS=$(foreach lib,$(LIB_FILES),-Xlinker $(lib))

// modify your run-tests
	@$(SWIFTC) -o run-tests \
		Tests/main.swift \
		$(SPEC_FILES) \
		-I.build/debug \
		$(STATIC_LIBS)

That's not actually possible, the order of the -Xlinker has to be the way it is otherwise it will fail to build.

I just tried it on your proj and it works fine. Up to you tho.

Just re-tested this, and it does work. I think it must've been a bug in early versions of swift-build which was now fixed.


UI bug in Segmentation panel "Segmentation List" panel does not display all segmentations in list - 3.9.0-beta.6 [Bug]

Describe the Bug
The Segmentation dropdown in segmentation mode (and basic mode) is not displaying all Segmentations if there are more than 1 or 2.  In this screenshot there are 4 but the drop down only shows Segmentation 1 and 2.

If I add more segments you will now be able to see all segmentations

Basically the dropdown goes as far down as the last Segment in the list.
Steps to Reproduce

Load any study in segmentation mode
Add a new Segmentation
repeat 3 more times until you should have 4
click the drop down to try and select segmentation 3, only segmentation 1 and 2 will be visible

The current behavior
The segmentation selection dropdown is only showing the first couple list items (depending on number of segments in the current Segmentation)
The expected behavior
All segmentations loaded should appear in the segmentation drop down.
OS
Windows 11
Node version
Using OHIF Demo
Browser
Version 124.0.6367.203 (Official Build) (64-bit)

We released OHIF 3.9 which address this issue


ARTEMIS-297 Handle Exceptions during server stop

Stopping the server should be able to handle exceptions thrown by
individual components.  Before this patch the stop method would throw
any raised exception and exit.  This can lead to partial shutdowns of
the server resulting in leaking threads.  This patch catches any
component exceptions and logs an appropriate error message, allowing the
server to properly shutdown.

Had some inline comments.
Also please rebase against the latest merged I made please?


fix: consume iterable as many as call in takeUntil

we did not test like this
it("should be able to take the element", async function () {
  const fn = jest.fn();
  const res = await pipe(
    toAsync([3, 3, 1, 0, 0]),
    peek(fn),
    map((a) => delay(100, a)),
    takeUntil((a) => a < 3),
    toArray,
  );

  expect(fn).toHaveBeenCalledTimes(3);
  expect(res).toEqual([3, 3, 1]);
}, 350);

move https://github.com/marpple/FxTS/pull/35


Fixed typo in Storage Replica FAQ

@JasonGerend,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

This is ready to publish


Experiment Versioning UI: Add Versioning Tab

Description

This is just for the base version tab and not for the detail view. This change includes:

adding a versions tab to Experiments
Displaying the versions table and create version button to that tab

User Impact

Demo

Docs

draft until the experiment model changes complete


Dynamic Text Encryption

Hi,
I would like to request a new feature for the Js-Confuser library. While the library is highly effective in code obfuscation, I would like to suggest an additional feature that would further enhance text protection.
Specifically, I propose adding a feature that dynamically encrypts static text and then decrypts it during runtime. This could involve methods such as encoding text into ASCII values or other similar techniques. The goal would be to make the text more complex and unreadable within the code, preventing direct understanding of sensitive information.
Example:
// Input
function print(x){
  console.log(x);
}

print("Hello World");

// Output
function decodeMessage(encoded) {
return String.fromCharCode(...encoded);
}

function print(x){
  console.log(x);
}

const encodedMessage = [72, 101, 108, 108, 111, 32, 87, 111, 114, 108, 100]; // ASCII values
print(decodeMessage(encodedMessage));

This feature would be particularly beneficial for developers looking to protect sensitive text. The encryption and decryption process could be implemented as an additional function or integrated with existing obfuscation techniques.
I hope you will consider this request and evaluate the possibility of including this feature in future updates.
Thank you,

I think this obfuscator already does this

String Concealing is the option you're looking for. In the 2.0 rewrite (which is coming soon), you'll be able to customize the string encoding functions to your own.

Introduced in 2.0. (Currently 2.0.0-alpha.3)
https://new--confuser.netlify.app/docs/options/customstringencodings#custom-string-encodings

Added in 2.0.


Cannot get this to work at all!

I have inserted the js files:
`

and the javascript example with options:jQuery('input[type="range"]').rangeslider({
polyfill: true,
// Default CSS classes
rangeClass: 'rangeslider',
disabledClass: 'rangeslider--disabled',
horizontalClass: 'rangeslider--horizontal',
verticalClass: 'rangeslider--vertical',
fillClass: 'rangeslider__fill',
handleClass: 'rangeslider__handle',
// Callback function
onInit: function() {},
// Callback function
onSlide: function(position, value) {},
// Callback function
onSlideEnd: function(position, value) {}
});`
It does not do anything to my rangeslider at all
`
<input type="range"
min=0
max=100
step="1"
value=50
data-orientation='horizontal'
  | >
`

https://github.com/andreruffert/rangeslider.js/issues/182

Setting polyfill to false did NOT solve the problem - it still renders as the normal ugly slider. Does not work for me in Chrome or Firefox

Any errors in the console? Maybe having a look at some working examples helps you figure out what's the issue in your case 👉 https://codepen.io/collection/oeBwH/

No errors in console. Only thing i did not add was this css:
.rangeslider__handle {
width: 42px;
height: 42px;
}
But still not working.
If I remove the rangeslider.min.js i see error in console, so the script is in use...

Sorry can't really help you then in this case...
All you need should be:
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/rangeslider.js/2.3.1/rangeslider.min.css" />

<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/rangeslider.js/2.3.1/rangeslider.min.js"></script>
<script>
$(function() {

  $('input[type=range]').rangeslider({
    polyfill: false
  });

});
</script>

Upps!!  Had by mistake placed it outside my document ready ! Sorry for the inconvinience.

But now I have another question. Is it possible to set the fill color on-the-fly - through jQuery options ?

https://codepen.io/andreruffert/pen/XNGwjM

Hmm.. ok.. but I have 4 different sliders in the same form and I want to give them four different colors?

To be honest this has not really anything todo with this project it's more like general web development. Anyways I'll give you some cause for thought of one way you could do this...
What about just giving them different css classes?
E.g.
<input type="range" data-fill-class="color1">
<input type="range" data-fill-class="color2">

...

.color1 {
  background-color: hotpink;
}

...

$('input[type=range]').rangeslider({
    polyfill: false,
    onInit: function() {
      const fillClass = this.$element.data('fill-class');
      this.$fill.addClass(fillClass);
    }
  });
...


Make a few settings configurable

Default density of results table
Number of results per page

https://github.com/ChannelFinder/pvinfo/pull/23


mvn install api in ubuntu OS, build failure, but in windows is ok

The error message is:
DefaultSecurityTest.registerUser:87 Status expected:<200> but was:<401>
I tried it in windows OS and Ubuntu OS, windows is ok, but the Ubuntu is failure.  Who can tell me why, and how to fix it. thanks.

@bruno1234567890 - the first thing I would check is your java version and your maven version. Can you please tell me what version of java and maven you are running on your Windows machine as well as your Ubuntu?

Hi,
Thanks for replying, see below screenshot
<EMAIL_ADDRESS>Below is Ubuntu OS information:
<EMAIL_ADDRESS>Thanks,
Jerry
From: matthewbeasley<EMAIL_ADDRESS>Sent: Tuesday, December 19, 2017 4:23 AM
To: capitalone/Hygieia<EMAIL_ADDRESS>Cc: Jerry Zhong<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [capitalone/Hygieia] mvn install api in ubuntu OS, build failure, but in windows is ok (#1905)
@bruno1234567890https://github.com/bruno1234567890 - the first thing I would check is your java version and your maven version. Can you please tell me what version of java and maven you are running on your Windows machine as well as your Ubuntu?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/capitalone/Hygieia/issues/1905#issuecomment-352546859, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AgQZSbl5rcirpd5e8vjC-2fG01ZeuHfpks5tBsmGgaJpZM4RC9vj.

This message (including any attachments) contains confidential information intended for a specific individual and purpose, and is protected by law. If you are not the intended recipient of this e-mail (even if the e-mail address above is yours), (i) you may not use, copy or retransmit it, (ii) please delete this message and (iii) please notify the sender immediately. Any disclosure, copying, or distribution of this message or the taking of any action based on it, is strictly prohibited.

@bruno1234567890 - the screenshots aren't displaying. Please post them directly in a comment instead of replying via email.
A colleague of mine just made me aware that we recently published a fix for this issue. Will you pull the latest code and see if your issue has been resolved.

@bruno1234567890 - do you have an update on this?


Automatic wiring pathway not found

Hi,
I want to map Cambridge ASSY-77 M1 to the Cambridge adaptor ADPT A64-Om32x2 to the RHD 64 channel headstage. When I ask for available pathways, I don't see the wiring I need:
['H32>RHD2132',
'ASSY-156>RHD2164',
'ASSY-116>RHD2132',
'ASSY-77>Adpt.A64-Om32_2x-sm-NN>RHD2164',
'ASSY-77>Adpt.A64-Om32_2x-sm-NN>two_RHD2132',
'cambridgeneurotech_mini-amp-64']
Thank you for your help,
Caitlynn

Hi @depreterc
If the wiring is not available, then you would need to make it yourself!
It would be great if you try it out and we can then include it in the list of available pathways.
Let us know if you need help with this
Cheers
Alessio


As a developer, I want to run passing tests

It was noticed while working on https://github.com/arielj/jeopardixir/pull/25 that the tests do not pass locally.
See https://github.com/arielj/jeopardixir/pull/25#issuecomment-925163638
This can be produced via:

docker exec -it jeopardixir_phoenix_1 /bin/bash
mix test

Error message that should show:
message: "An error occurred when loading Bcrypt.\nMake sure you have a C compiler and Erlang 20 installed.\nIf you are not using Erlang 20, either upgrade to Erlang 20 or\nuse version 0.12 of bcrypt_elixir.\nSee the Comeonin wiki for more information.\n"

Rechecking this, it appears the main branch is okay 👌 . May be a local dev issue on my own machine. Closing this issue at the moment.


Add /start-govuk route

GOV.UK doesn't pass the referrer so we can't measure how many users are coming via the correct start page vs the other links on there. Until we can rationalise the links we can set it up to link to a specific URL for analysis.
Add /start-govuk route. This just redirects to pages#start which funnels the user to the correct first page based on whether they're logged in or not. We'll only use this for the GOV.UK start page.

Closing as we've been unable to update the GOV.UK link to use this path thus far.


Down the Attic Hole Scenario

Please upload a new scenario for MoM located here: https://github.com/Hobbeslionheart/DowntheAtticHole
Also use this page for comments and feedback. This was my first scenario when I created it and I wanted to use tiles that wasn't really used in the official app so it requires all of the expansions (sorry for those who don't have them). I also became silly along the way as I was experimenting and learning Valkyrie so it's a very silly scenario and may be woefully unbalanced, but that's besides the point of the scenario. Just have fun!

Done.  Closing this for tracking reasons, but discussion can continue.

@Hobbeslionheart
Hi
Very funny moment i had when translating your scenario in French!!
However, i've no particular issue, except one!
During myhtos phase, some text warning you that you take to much time. I last a bit in cliking successiv several mythos phase, but nothing happens.
It could be nice and in the mood of the scenario that something happens (like an enraged Alice or whatever :D)
Or didn't I click enough?
I'll post the file after your reply
Congrats for the great originality of your scenario!

Hi @Indoy ,
Thank you for translating the scenario and I'm glad you enjoyed it. I had wondered if you would translate this since there are some cultural reference that might not translate well. I'll be curious to see what you did with them. I can read French pretty well.
As for the Enraged Alice idea, that's actually not a bad idea. I think the deadly Mythos that would follow would be enough. This was also my first experiment with Valkyrie and a lot of the ideas were to challenge some of the gameplay and narrative elements that we take for granted in the game. I would like to continue to do that as time permits with other scenarios. So I think I'm good with the scenario.
Please post the file so that I can review it and I'll add it to the hub. Thanks again for translating it.

Hi Here's
Localization.French.txt


Problem with Total Stars Stat

Describe the bug

Hello, there is a problem with the star values.

Us though, it doesn't update itself!
This is taken from the website for some reason and kept. Please take a closer look at the screenshot, or visit my profile to get an overview.
Thanks

Hi @bylickilabs,
There is a several layers of cache. From server side it takes 10 hours to update your data. And the Stars count it's take your direct stars (your repos) and indirect stars (repo's you contributed for). For more info  read this issue

Ok, Thanks. Try it again...

I can't see where is the problem, could you clarify it?


Kourend Library Varlamore Envoy and Dark Manuscripts

I'd like to request two changes to the Kourend Library plugin.

Varlamore Envoy does not show unless The Depths of Despair quest has been started and not finished.
Varlamore Envoy is a book that is used for the aforementioned quest and nothing more. You cannot find it in the library under normal circumstances so it should not be shown unless those circumstances are met.
An option is included in the plugin to toggle showing Dark Manuscripts.

Added in 91417aca982687d58c51b5e8244ee61f3e2106ec


improving search results

This is more of a general issue around improving search results. For example, it is really difficult for me to replicate any search result for London Natural History Museum, even if I use terms from the title and page of where this image exists under CC0 on the platform: http://data.nhm.ac.uk/dataset/collection-specimens/resource/05ff2255-c38a-40c9-b657-4ccb55ab2feb/record/8304314.
This could b/c that particular image isn't in our database, also could point to the fact that we need to improve how certain providers' images show up in search.

done

We only have 170 images from nhm.ac.uk. These were collected by Liza back in the exploratory phase of the prototype so the data set from this provider is not complete. As far as I know, we don't have plans to index content from here (@sclachar can confirm)
Please either transfer this to cccatalog or close the issue

(side note: a commit I made referenced this issue in error; please ignore it)

Ok.. can someone transfer the issue to cccatalog? I don't have permissions, haha

@janeatcc do we want to index nhm.ac.uk? otherwise we should just close this issue.


Corrupt Image -- OS X 10.10.5

I've had some users that were getting a corrupt image error when trying to open the .dmg. I asked someone to send me a screenshot:

OS X 10.10.5
Unfortunately, I was not able to replicate the issue.
Thank you very much for making this! this is such an awesome project.

I also met this from one of my user

Interesting. Can someone please investigate? I'm not using the tool myself currently.

Does anyone have found the fix?
I have the same issue in OS X 10.12.6 but only on 1 machine I've successfully open the .dmg file in other 2 computers.

I had some issues with this, dmg must be code signed now.

@aonez  You can bypass codesigning https://www.tekrevue.com/tip/gatekeeper-macos-sierra/

@albertoclarit but you can't ask to do this to the people you share the dmg with...
Just signing the dmg solves this issue. You'll need a developer profile:
codesign -s <DEV-KEY> image.dmg

This is surprising to me; I didn't know that the DMGs needed to be signed, I only knew about apps.
If anyone is still having this problem, could you attach an example "corrupt" DMG to this issue, and let us know which version of macOS is having trouble opening it?

@apjanke this is always required since OS 10.12, but don't quote me on the version. I think by now all "packers" do that.
We can add a signature phase in the script that applies the signature specified in a new argument. I already have some code to do that.

We can add a signature phase in the script that applies the signature specified in a new argument. I already have some code to do that.

Show me your code! I am interested.


Update Johnson-Cousin transformations

Douglas has derived some transformations from DES to Johnson-Cousins. We should update to use these to calculate M_V
https://des.ncsa.illinois.edu/releases/dr2/dr2-docs/dr2-transformations
https://cdcvs.fnal.gov/redmine/projects/descalibration/wiki/DESDR2_Tranformation_Interpolations#Johnson-Cousins-gt-DES
V = g{DES} - 0.465 (g-r){DES} - 0.020 [-0.5 < (g-r){DES} ≤ 0.2] (RMS: 0.012 mag)
V = g{DES} - 0.496 (g-r){DES} - 0.015 [ 0.2 < (g-r){DES} ≤ 0.7] (RMS: 0.011 mag)
V = g{DES} - 0.445 (g-r){DES} - 0.062 [ 0.7 < (g-r){DES} ≤ 1.8] (RMS: 0.024 mag)

Relevant code in ugali here
https://github.com/DarkEnergySurvey/ugali/blob/82abffcc92bddf830d89f85cb3966870f7d9f720/ugali/isochrone/model.py#L76
and here:
https://github.com/DarkEnergySurvey/ugali/blob/82abffcc92bddf830d89f85cb3966870f7d9f720/ugali/isochrone/model.py#L329
Still need some general transformations for SDSS, DES, PS1, LSST.

See PR #97 too.


Compatibility with SvelteKit >= 341

SvelteKit removed the @sveltejs/kit/install-fetch export and replaced it with @sveltejs/kit/node/polyfills which contains additional polyfills.
This PR updates the import and bumps the SvelteKit peer dependency.
Fixes #27

Thanks @sfriedel ! Can you try and incorporate the change from https://github.com/HalfdanJ/svelte-adapter-appengine/pull/30 in this pull request to solve the test error?

Thank you @HalfdanJ and sorry I missed your request.


Carousel.h ?

Where can I download Carousel.h?

You should get it automatically by installing MiniGrafx (
https://github.com/squix78/minigrafx). Either through the library manager
in the arduino ide or by downloading the zip and installing it manually.
Please let me know if we can close this issue...
2017-07-03 21:24 GMT+02:00 djuscha<EMAIL_ADDRESS>
Where can I download Carousel.h?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/squix78/esp8266-weather-station-color/issues/20, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AArwFkjwHsGO289rZu7BLKX39uduBjF1ks5sKT_ggaJpZM4OMneC
.

It has worked. Thanks!

From your comment I assume that I can close this issue. Otherwise please re-open it.


When a room member change it's nickname in a room, bot cannot detect it.

When a contact change it's nickname in a room, using room.member() cannot get the contact successfully.
I guess this is because the following code in room.ts doesn't refresh contact
  private async readyAllMembers(memberList: RoomRawMember[]): Promise<void> {
    for (const member of memberList) {
      const contact = Contact.load(member.UserName)
      await contact.ready()
    }
    return
  }

Yes, you are right.

Maybe we should plan to do refresh in period inside the Wechaty Framework. Because all of room info should update.
It can add an enhancement.

I will not disagree with you because I'd also like to consider adding a refresh in a period.
However, it will need not only a proposal in detail to discuss, but also more design patterns should be considered. I'd like to leave those works as an exercise to the community.

Currently, we have to use room.sync() as a workaround.
If anyone has better ideas, please let me know by leave comments under this issue, and I'll reopen it for discussion.


Install as instructed in README fails

The README says to install, use go get -u github.com/containous/yaegi/cmd, but when I do so I get:
$ go get -u github.com/containous/yaegi/cmd

package github.com/containous/yaegi/cmd: no Go files in /Users/llimllib/go/src/github.com/containous/yaegi/cmd

$ tree /Users/llimllib/go/src/github.com/containous/yaegi/cmd
/Users/llimllib/go/src/github.com/containous/yaegi/cmd
├── goexports
│   └── goexports.go
└── yaegi
    └── yaegi.go

I did, go get -u github.com/containous/yaegi/cmd/yaegi
and it worked for me.

I also tried this, but it didn't work either:
:$ GO111MODULE=on go get -u github.com/containous/yaegi/cmd
go: finding github.com/containous/yaegi/cmd latest
go: finding github.com/containous/yaegi v0.0.1
go: downloading github.com/containous/yaegi v0.0.1
go: extracting github.com/containous/yaegi v0.0.1
go get github.com/containous/yaegi/cmd: no matching versions for query "latest"

:$ go version
go version go1.12.1 darwin/amd64

@llimllib You didn't read what @hako wrote, you need to add /yaegi after containous/yaegi/cmd. Copy paste the command he mentioned and it should work fine :)

ah roger, my bad. Thanks @hako


Feature Get/Put mappings

Added MappingsService and CreateMappingsService.
Basic implementation of the mapping feature. I don't know if this is the best implementation. If you think that needs some improvements on the code, please, let me know and maybe I can improve that.
Usage:

// Create the mappings struct
// Use .Body() to set this object mapping
// Use .BodyString() to set a raw JSON string mapping
mappings := map[string]TypeMappings{
    "tweet": TypeMappings{
        Properties: map[string]FieldProperty{
            "location": FieldProperty{
                Type: "geo_point",
            },
            "suggest_field": FieldProperty{
                 Type:                       "completion",
                 Analyzer:                   "simple",
                 Payloads:                   true,
                 PreserveSeparators:         true,
                 PreservePositionIncrements: true,
                 MaxInputLength:             50,
            },
            "tags": FieldProperty{
                 Type: "string",
            },
        },
    },
}

// Creating the mappings
mappingsOk, err := client.CreateMappings().Index("elastic-test").Type("tweet").Body(mappings).Do()

if err != nil || mappingsOk["acknowledged"] != true {
     panic(err)
}

// Getting the mappings
result_mappings, err := client.Mappings().Indices("elastic-test").Do()

if err != nil {
    panic(err)
}

eq := reflect.DeepEqual(mappings, result_mappings)

if !eq {
	panic(errors.New("Mappings are unequal!"))
}

Hi there. Thanks for your contributions.
I see that you need the mappings API. That isn't something I haven't been looking at. I was trying to focus on search and runtime issues firstly, while cluster and index administration is still something we do on the command line (with tools like es or curl for example). Of course, that doesn't mean I want to include it, so thanks again for your work.
Let me explain why I refrain from adding things like TypeProperty or FieldProperty to Elastic.
The Elasticsearch API is huge. It has about 100 API endpoints, roughly 600 parameters spread all over the API, and god knows how many data structures. And it is moving fast. I don't see a way of re-implementing all these structs in a Go client as you did with TypeProperty and FieldProperty. If you look at the official clients, they don't do that either.
What you can expect from Elastic is to have access to the API endpoints and a (general) way of performing requests against an ES server. The official clients, again, even have a separation into a low-level and a high-level API. Elastic currently is a mix of both. I'm trying to align it more towards their structure. So you can now use the low-level API to call any API endpoint in ES by doing it like this:
req

Hi there, thanks for the quick reply!
I understand your position. I'm developing a service that requires strong control of elasticsearch mappings, then I need some mappings utility. If you want I can change that code for use interface{} instead...
While the elastic do not support that, I will stick with this implementation.
I didn't know the "es" tool, very nice! I will take a look at it, maybe it can help me!
Thanks!!


Add new dummy pages, add to routes, add test

Description
Adds Home, move location (oconus/conus), unsupported move and move setup pages. Adds pages to routes, in the flow described in the JIRA ticket.
Reviewer notes
Currently, it is not possible to route to unsupported move or move setup pages. This was how it was described in the ticket, so just want to double check that this was the intention.
Setup
Add any steps or code to run in this section to help others prepare to run your code:
make server_run
make client_run

Run through the sign up flow - check that the new pages are present and appear in the order expected, as described in the accompanying jira ticket.
Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[x] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against cc6264d03bc01160aa18a23dc8ebfa5d8a99287a


Neovim hangs right after running :Glow file

Describe the bug

Neovim version: v0.9.0-dev-cbd4480
glow.nvim version: Latest main, commit a3f24fd
OS: NixOS 23.05.20230317.b573a7f (Stoat) x86_64

Configuration:
require('glow').setup({
  glow_path = "/nix/store/iakavyzx55i95i2ysylnfdm3xn8d21k1-glow-1.5.0/bin/glow",
  border = "shadow",
  pager = true,
  width = 120,
})

To Reproduce
Steps to reproduce the behavior:

Run :Glow file.md and the file is displayed on a floating window.
Neovim becomes unresponsive to further inputs, can't even close the floating window.

There are no logs under ~/.cache/nvim/log, so I'm not sure how to debug this. Any ideas?
Expected behavior
It should not hang.

@ellisonleao apologies for the poor description. I've made a video to demonstrate the issue:
https://user-images.githubusercontent.com/443978/228772545-8c218c19-29cc-40a7-9e71-1d151831d443.mp4

I have this problem too.

I also get an unresponsive window when turning on the pager option. It works fine when this is turned off (by default). When I mouse click in the unresponsive window (so with pager = true), it unfreezes and is responsive to further keyboard typing.

I also have this issue using the newly released v0.9.0. I noticed that when it freezes my status line section that displays which mode I'm in (Normal, Insert, etc) says 'Terminal'. Once I click the window with my mouse it changes to 'Normal' and becomes responsive again.
Can confirm the 'pager' solution did work for me.

There's also some interaction with some :terminal settings. I can <C-\><C-n> to get cursor in and then q or Esc work.


fix: attempt to index local 'path' (a nil value)

Hi,
Debugging a simple rust script. I'm getting "attempt to index local 'path' (a nil value)" during load/steps and the "stacks" windows remains empty. Running .stacks in the repl works.
It's fixed by adding
      if frame.source.path == nil then
          frame.source.path = frame.source.name
      end

Not sure if this has side effects but it fixes my immediate problem :)

Thanks for opening a PR! 😄 I've tweaked your solution a little to avoid the mutation, since the source is stored in state I don't want it being changed from what is given back from the debug server.


PoC / Research: [Custom JS Lib] measure performance impact of extracting function definitions via tern server running inside browser

Summary
Currently, we use Tern Server running inside browser to provide auto-complete feature for JS library definitions. The tern server relies on function definition files to suggest auto-complete. Currently, we provide the definition file manually. However, going forward we need to create the function definition files automatically once the user adds any custom library. One way is to use the condense utility provided by the tern server running inside the browser. We need to evaluate the performance impact of using the condense utility via the tern server running inside the browser. Key observations required:
(1) Is the output of condense utility usable directly or some kind of post processing is required ?
(2) How much time does it take for the tern sever to extract the function definitions ?
(3) What kind of impact does it have on the application - does it cause the application to lag / crash temporarily ?
(4) Is it possible to mitigate the performance degradation, if any ?
References:

https://www.notion.so/appsmith/Custom-JS-Libs-V2-5a17144434e744a38d6d2868b158dea8
https://ternjs.net/doc/manual.html
https://theappsmith.slack.com/files/UNR19E5HU/F02070UT6AH/steps_to_add_a_new_library.pdf

The tern utility bin/condense uses file path to generate definition files. This means that we would have to download the lib on the user's machine and provide that file path to the tern utility. This is not practical and is resource intensive.
Type definition generation will therefore be handled by the server.


ImageVisual rotate on center

Hi,
I need to rotate imageVisual based on the center, i use the following code

and rotate using TopLeft pivot, now I added the RenderTransformOrigin="0.5, 0.5" like this

but it doesn't work.
Can you check it, please?

Hi,
Didn't really have time to set up an example and try this out. But, what you can try is to set the RenderTransformOrigin property on the RichItemContainer itself. I will probably expose a way to set this through an Attached Property same as ApplyTransform.
Try this out and see if it works! Thanks!


garment etl

garment etl

Coverage increased (+0.009%) to 73.727% when pulling 9d8aec66ffe4d1693b5200a0eca73c4dbbc2e3c6 on adityahenanda:dev into 98becfba997ce38ae61acc85c9184e95daf6362f on danliris:dev.


Sorting stops working once table is changed

I have a table that I add data and remove data from it using JS. Sorting the table works perfectly once the page loads and the table is initialized. However, once anything in the table changes, sorting stops working.
There is no way to reinitialize the table again once the data changes.

+1

I've been going over https://github.com/HubSpot/sortable/blob/master/js/sortable.js and it doesn't seem like it exposes any methods to re-initialize, but it should be possible to re-init and things should "just work?"
I'm using RiotJS and I believe on re-draw it destroys the components

I haven't tried to add rows to the table "manually", but in combination with vue.js sorting seems to work even when the table is modified after init. It just does not trigger an automatic resort when new items are added - the user has to click on a header to trigger a resort. It would be nice to have an option to trigger this automatically. So far all sorting seems to be encapsulated in the "onClick" handler - so there is no obvious way to trigger this in code.

I managed to find a workaround after posting the issue, I just forgot to post the solution.
Before doing any changes to the table, you can "un-initialize" the table first using this line of code here:
document.getElementById("InsertYourTableIDHere").setAttribute("data-sortable-initialized", "false");
After you are done changing the table, just run Sortable.init(); again.

Woo! Thanks so much!
It does suck that the sorting doesn't re-sort the proper column, hrmmm

You can easily keep track of which column was last sorted using the column's ID or data attribute, and then programmatically sort the table after changing it.
On Wed, Mar 9, 2016 at 9:34 AM -0800, "Eric Carmichael"<EMAIL_ADDRESS>wrote:
Woo! Thanks so much!
It does suck that the sorting doesn't re-sort the proper column, hrmmm
—
Reply to this email directly or view it on GitHub.

Hrm, trying to do something similar by manually firing the click-to-sort event:
sorted_column.dispatchEvent(new Event('onclick'));
sorted_column.dispatchEvent(new Event('onclick'));

Doesn't seem to actually work? Also, it seems like Sortable isn't sorting some columns properly, may have to specify a type somewhere?

4146.57 should be the first row when sorted ascending

As far as I remember, to sort the table programmatically, all you do is give the column you want to sort a certain data attribute. Try sorting a table manually and then use inspector to see what attribute the column was given, then do the same using JavaScript or jQuery.
On Wed, Mar 9, 2016 at 9:46 AM -0800, "Eric Carmichael"<EMAIL_ADDRESS>wrote:
Hrm, trying to do something similar by manually firing the click-to-sort event:
sorted_column.dispatchEvent(new Event('onclick'));
sorted_column.dispatchEvent(new Event('onclick'));
Doesn't seem to actually work? Also, it seems like Sortable isn't sorting some columns properly, may have to specify a type somewhere?
4146.57 should be the first row when sorted ascending
—
Reply to this email directly or view it on GitHub.

Cool, added data-sortable-type="numeric" to my <th> and it's all working now, you're the best thanks so much for your time!

Yeah, I am having the same issue when I add new rows to the table.  Seems like the table could go through a re-initialization process, unhooking any events and clearing the value in _results, then initializing the table again, instead of calling
if (table.getAttribute('data-sortable-initialized') === 'true') {
return;
}