Move forecast.Config.process method to Forecast class

The solution in #166 does not allow to override the logic for a specific Forecast subclass. To do that, the processing logic should be attached to the Forecast class instead of Config.
The method is now also renamed to the more descriptive as_json_dict.
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Job PR-169/1 is complete.
Docs are uploaded to http://gluon-ts-staging.s3-accelerate.dualstack.amazonaws.com/PR-169/1/index.html

Codecov Report

Merging #169 into master will decrease coverage by 0.01%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   78.15%   78.13%   -0.02%
==========================================
  Files         120      120
  Lines        6775     6778       +3
==========================================
+ Hits         5295     5296       +1
- Misses       1480     1482       +2

Impacted Files
Coverage Δ

src/gluonts/model/forecast.py
67.56% <16.66%> (-0.57%)
:arrow_down:

Actually, this breaks the current behaviour. Here samples is not set for non-sampling forecasts, instead of setting an empty list.

I will prepare a fix.


:seedling: Bump IPAM to v1.6.4

Bump IPAM to v1.6.4

/test metal3-ubuntu-e2e-integration-test-release-1-6


docs: metrics: document any metrics run side effects

Running the metrics tests has some side effect. We should document those in the metrics readme at least. These effects include at least:

reset/restart of docker and proxy
deletion of any running or stopped existing containers

We added a warning here: https://github.com/clearcontainers/tests/pull/758
Closing


Add laps per hour for agility courses

#6836
Adds laps per hour for agility courses using the XPTrackerPlugin
When doing laps, the XPTracker will change "Actions" to "Laps"

Instead I would probably just put this on the existing agility overlay which shows laps until level.


[instrumentation] google-genai tracing

provide auto instrumentation for
https://pypi.org/project/google-genai/

Still not prod ready. Probably affects priority


View All Roles Option

User Story
AS A business owner,
I WANT to be able to view and manage the departments, roles, and employees in my company,
SO THAT I can organize and plan my business.

Acceptance Criteria
GIVEN a command-line application that accepts user input,
WHEN I choose to view all roles,
THEN I am presented with the job title, role id, the department that role belongs to, and the salary for that role.

Complete. See PR #21.


[now-cli] Improve getLink error reporting

Stop reporting syntax errors in .now/project.json to sentry. Instead, output an error message and exit.
Here's the error message:
Error! Now project settings could not be retrieved. To link your project again, remove the ".now" directory.

Tests?


set main trace for charts

Description
Chart can have several traces. To fully support decimator, the user should be able to set the main trace
Acceptance Criteria

[ ] Ensure new code is unit tested, and check code coverage is at least 90%
[ ] Propagate any change on the demos and run all of them to ensure there is no breaking change
[ ] Ensure any change is well documented

or specify wich decimator for which trace ...

@FredLL-Avaiga you can have a look at this
https://github.com/Avaiga/front-end-experiments/tree/main/decimator
Let me know if you need anything else

tx


WPS for querying ECCC weather forecasts through the GeoMET WPS service for the watershed of interest.

Description

Self info:
WCS for netcdf example link:
https://geo.weather.gc.ca/geomet?SERVICE=WCS&VERSION=2.0.1&REQUEST=GetCoverage&COVERAGEID=RDPA.24F_PR&SUBSETTINGCRS=EPSG:4326&SUBSET=x(-180,56.25000000000001)&SUBSET=y(12.211180191503997,85.70184378613162)&FORMAT=image/netcdf&TIME=2020-03-10T12:00:00Z

Replace COVERAGEID with the product (RDPS/GDPS)
Probably want to change the 12Z to 6Z for Canada, if available

Variables description from: https://directory.spatineo.com/service/12371/
ETA_PR --> Precip accum [kg/(m^2)]
ETA_RN --> Rain accum [kg/(m^2)]
ETA_SN --> Snow accum [kg/(m^2)]
ETA_TT --> Air temperature [°C]

@huard I have started the WPS process and test suite but there seems to be an intrinsic limitation in GeoMet:
"Note that queries with time ranges or multiple time values are not currently supported on GeoMet for both TIME or DIM_REFERENCE_TIME parameters. Only single time queries are supported."
What I gather from this is that we can only download one forecast step at a time... not super useful if we want to download 4 variables on say 40 time steps for each of 4 models (RDPS/GDPS/REPS/GEPS). Initial tests have shown that there is no time coordinate in the returned WCS-called netcdf...
see branch "wps_geomet" for details...

@huard @tlogan2000 It might take a while before we can extract large amounts of data in single calls from GeoMET. Can we have a plan B where we download the ECCC forecasts from the datamart every day and store it temporarily on THREDDS (or elsewhere) for the past, say, 3-4 days? The data on Datamart is accessible for full forecasts (all lead-times at once) so that would make things much simpler.
I don't know how complicated it would be to setup an auto-download process for the required files, but if it's possible it's probably the next best thing. Or else we'll have to resort to submitting like 640 GeoMET requests each time we want to do a forecast.
Any comments or suggestions welcome!

Creating the proper download script is probably the jump-off point and the most critical.  Automating it to run every day should be fairly simply for Long I would think....

Creating the proper download script is probably the jump-off point and the most critical. Automating it to run every day should be fairly simply for Long I would think....

Yes.  Someone write the script, I can hook it up to our cronjobs on PAVICS easily.

It would seem ECCC has an "Advanced Message Queuing Protocol" (AMQP) that allows automatically receiving the desired forecast data as soon as it is available: https://eccc-msc.github.io/open-data/msc-datamart/amqp_fr/
It runs in python so should be relatively easy to implement I would think? I know some hydropower utilities use this and usually works well.
Now just trying to find the good variables on the datamart, which seems to be proving more difficult than anticipated...

Closed with #321


Proposal: classify uncaught errors in tests as "errors" not as "failures"

Do you want to request a feature or report a bug?
Feature
What is the current behavior?
Jest treats failed assertions and uncaught errors in a test case both as failures.
What is the expected behavior?
I maintain jest-junit, a testResultsProcessor that provides valid jUnit xml files for CI & reporting systems. This spec differentiates a test failure and a test error.
A test error, according to the junit spec, is classified as:
An errored test is one that had an unanticipated problem, for example an unchecked throwable; or a problem with the implementation of the test.
What I am proposing is that Jest adds an additional test status of "error" for these cases.
The current documentation for testResultsProcessors shows the following test statuses:
"status": "failed" | "pending" | "passed",
I am more than happy to contribute and willing to take this work on myself, if necessary. But before I do I wanted to get feedback from Jest maintainers and the community if this would cause problems.
Please provide your exact Jest configuration
System:
OS: macOS Sierra 10.12.6
CPU: x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
Binaries:
Node: 8.5.0
Yarn: 1.5.1
npm: 5.3.0
npmPackages:
jest:
wanted: ^22.4.3
installed: 22.4.3

I created a repository that highlights the issue behind this proposal clearly. In it, you'll see that an uncaught error in a test and a failed assertion in a test all result in the same output for a testResultsProcessor.
https://github.com/palmerj3/jesterrorproposalsamplerepo

+1 and it would be great to also have "skipped"

@rickhanlonii yeah jest-junit assumes "pending" is skipped

Might be an issue that we throw from expect, so we'd need some instanceof checks and whatnot. Same with assert, if people use that.
I'm 👍 on the idea, though 🙂

@SimenB @rickhanlonii @mjesun what are your final thoughts on this?
I'm happy to start working on a PR for this if there is approval but I haven't gotten much reception here.

I think it makes sense 🙂 Richer reporting is always nice. Might be something https://github.com/Raathigesh/majestic can use as well

Still +1, but now I'm curious about @SimenB's comment about throwing - we wouldn't want to limit assertions to the Jest expect library so how would we implement this with breaking third party assertions people are using?
One option would be to check for a blacklist of errors like SyntaxError which should not be thrown from matchers. What do you think @palmerj3?

@rickhanlonii implementation detail :)
If there is general agreement that this would be a nice feature then I'm sure we'll figure it out through the PR process. The blacklisting sounds reasonable.

Using whatever mechanism https://www.npmjs.com/package/bounce uses for system errors seems reasonable to me.

Yes, it would be amazing if runners could inject their own statuses, and colors for those statuses.
Basically, jest is really two things that would be really nice to make more separable: a test framework (a jasmine fork) and a super awesome parallel test runner/watcher.

Ok I'm going to consider this community supported :)  I have a long plane ride this week so I plan on starting work on it.

@palmerj3 Were you able to look into it?
FWIW, I support error in addition to failed, but if we could implement it in a way which allows us to also support other statuses, such as warning, that's be awesome.


Support webm and AV1 rollalty free codecs.

mp4 is covered in patents and royalies, it would be good to support the open source rollalty free formats like webm and av1. Also av1 is considered better than HEVC itself.

I second this!

Have you tried to upload something with this format? It may already work. If not, we don't plan to do this anytime soon. Mp4 is widely supported and most creators are familiar with it. Thank you for the suggestion.


syscall: Return full error details.

Don't discard the original error object as it contains essential
information for problem determination.
Signed-off-by: James O. D. Hunt<EMAIL_ADDRESS>

LGTM

LGTM

@sameo @jodh-intel do you know why travis and coveralls are waiting for "status to be reported" ? The CI is stuck.


refactor: clean model validation

          1 Warning

:warning:
There're changes, but no changelog.

  Generated by :no_entry_sign: Danger


Append plotfiles with date/time

Make the filenames for the plots more useful by appending with current date/time

This has now been completed after plotfiledate branch merged with master: https://github.com/kramergroup/openImpala/commit/6485c58630a5f3b4e3349b4464805f03731ada00


TraitDiffRule$Severity type change in 1.46.0

Hi!
I was trying to update our version of Smithy from 1.45.0 to 1.47.0 in smithy4s, but bumped into an issue: our generated code for smithy.api breaks binary compatibility against its previous version.
One of such breakages, probably the most obvious one is this:
method severity()smithy.api.TraitChangeSeverity in class smithy.api.TraitDiffRule has a different result type in current version, where it is smithy.api.Severity rather than smithy.api.TraitChangeSeverity

I recognize this may an "us" problem more than Smithy's problem, but is this kind of breakage expected in 1.x? Even smithy-diff considers an enum shape rename an ERROR:
//> using dep software.amazon.smithy:smithy-model:1.47.0
//> using dep software.amazon.smithy:smithy-diff:1.47.0
import software.amazon.smithy.model.Model
import software.amazon.smithy.diff.ModelDiff
import scala.jdk.CollectionConverters._

def parse(s: String) = Model
  .assembler()
  .addUnparsedModel("test.smithy", s)
  .assemble()
  .unwrap()

@main def run = {
  val m1 = parse("""$version: "2"
  |namespace demo
  |
  |@private
  |structure Hello {
  |  greeting: Greeting
  |}
  |
  |@private
  |enum Greeting {
  |  FOO
  |  BAR
  |}
  |""".stripMargin)
  val m2 = parse("""$version: "2"
  |namespace demo
  |
  |@private
  |structure Hello {
  |  greeting: GreetingNew
  |}
  |
  |@private
  |enum GreetingNew {
  |  FOO
  |  BAR
  |}
  |""".stripMargin)

  ModelDiff.builder().oldModel(m1).newModel(m2).compare().getDiffEvents().asScala.foreach(println)
// [NOTE] demo#GreetingNew: Added enum `demo#GreetingNew` | AddedShape test.smithy:9:1
// [ERROR] demo#Hello$greeting: The shape targeted by the member `demo#Hello$greeting` changed from `demo#Greeting` (enum) to `demo#GreetingNew` (enum). The `smithy.api#enum` trait was found on the target, so the name of the targeted shape matters for codegen. | ChangedMemberTarget test.smithy:5:3
}

Sorry to hear that impacted you. This was a private shape in the prelude, so it seemed like fair game and not a breaking change to change it given we needed to reuse this shape in other parts of the prelude for less specific purposes. I'm surprised something would codegen private shapes from smithy.api like this. If that's a requirement of smithy4s, we'll be more careful of changes to the prelude in the future.

You can close the ticket, let's talk about it in another channel, clearly the fact that it's private makes it fair game

@mtdowling, apologies but I'm compelled to ask @kubukoz re-open the issue, after giving it some further thoughts. I'm happy to open a new issue if you think it'd be preferable.
The concept carried by @private in smithy prevents the direct referencing of a shape from other namespaces. However, it doesn't prevent their indirect referencing. It is the case, for instance, for the smithy.api#Example shape that is used in the smithy.api#examples trait.
If we make the parallel with Java, it'd be akin to having a public class carry an accessor, the return type of which would be private. This would simply not pass compilation.
Now the thing is that code-generating traits can be useful. As a matter of fact, the original smithy tooling is facilitating this usecase. Smithy4s generates code for all shapes from all models it encounters, trait or not, and for better or worse, this generated code is used in applications (as opposed to tooling).
If we avoided the generation of private trait shapes from the prelude, we'd find ourselves in a conundrum with regards to "what should we do with members of public shapes that target private shapes ?". Omitting them is hardly a solution : in the case of @examples, the smithy.api#Example is the valuable bit of information, despite being tagged as private in the smithy prelude.
So my point is that, the smithy @private doesn't make the renaming of shapes fair-game after all, because if end users can "instantiate" traits and provide values for the private shapes, then users should be in the right to want to query/manipulate those values using generated code, which implies that @private shapes should be subject to a similar degree of strict-ness/principle-ness than other shapes when it comes to evolving them.

If that's a requirement of smithy4s, we'll be more careful of changes to the prelude in the future.

Therefore, it'd be greatly appreciated if you folks could indeed be more careful of changes to the prelude in the future.

That makes sense. We use protocol and validation traits at runtime too in some code bases. Those code bases don’t generate documentation traits and model specific traits like what’s mentioned in the issue, so it wasn’t an issue there. If something is generating them all, then I could see how it’d be impacted.
I don’t think it’s worth rolling back now that it’s deployed. To prevent an unintended break of smithy4s, we could potentially add a chain build or something via GitHub actions from this repo to smithy4s (contributions here are very welcome).

Yeah no need to rollback this time around, we'll manage. I'm more interested to avoid a future mis-hap
@kubukoz and I will discuss contributing a "chain build", see what'd be possible.
Thank you for your understanding 👍


Missing one-hot vector

Hello :)
The documentation mentions that MT10 and MT50 augment environment observations with a one-hot vector which identifies the task.. When I create a MT10 instance (using the code below) I do not get the task id. Could you please explain what am I missing.
import metaworld
import random

mt10 = metaworld.MT10() # Construct the benchmark, sampling tasks

training_envs = []
for name, env_cls in mt10.train_classes.items():
  env = env_cls()
  task = random.choice([task for task in mt10.train_tasks
                        if task.env_name == name])
  env.set_task(task)
  training_envs.append(env)

for env in training_envs:
  obs = env.reset()  # Reset environment
  a = env.action_space.sample()  # Sample an action
  obs, reward, done, info = env.step(a)  # Step the environoment with the sampled random action

The shape of obs is (12,) and not (13,)

@avnishn

Hi @shagunsodhani,
Thanks for checking out Metaworld! We recently updated Metaworld to a new API that by default does not append task one-hot ids to the observations of environments. Even though we had appended task one-hot ids to observations when we originally ran metaworld, we received the feedback that this design constricted researchers when they went to implement their own multi-task algorithms. Researchers were looking for ways to use their own task-ids.
That being said, I think there should some out of box solution for appending one-hot ids to observations from Multi-task environments. We (the Metaworld maintainers) will discuss whether we should have some tooling in the Metaworld package that allows to users to append task one hot ids to the observations of environments.
Lastly,
I noticed that you said

The shape of obs is (12,) and not (13,)

This behavior is correct, however if you were to append a one-hot to the observation, its length would never be (13,).
One hots have the shape of (num_environments,) where num_environments is the number of environments in a multi task benchmark. They take the form `[0,0,0,0,....,1, 0, 0] where there is a single 1 in the place in the one-hot to represent the task number, and 0s in all other positions. This would mean in MT10, if we were using task 1, where task 1 corresponds to some environment in MT10, the one-hot could be [1, 0, 0, 0, 0, 0, 0, 0, 0, 0].
For MT10 and MT50, num_environments would be 10 and 50 respectively, making the shape of observations from the those MT benchmarks (22,) and (62,)
While we're developing a solution to your problem, feel free to use this gym wrapper from our sister package, Garage.
It contains enough functionality to append one-hots to environments.
Please, let me know if you have any more questions!
best,
Avnish

Thanks for the answer. Could you please point me to the commit where the code is aligned with the benchmark proposed in the paper. While it is useful to have an ever-evolving benchmark, it makes it quite hard to replicate other's results and to build on them.

And if there is a more recent, stable, version of the benchmark, please point me to that as well :)

@shagunsodhani the current code on master is the most faithful to the original paper. Much of the improvements in the past year have been around enhancing reproducibility of the original results.

@ryanjulian Maybe I am missing something obvious but I see some clear differences:

 The observation space is represented as a 3-tuple of either the 3D Cartesian positions of the end-effector, the object, and the goal, or the 3D Cartesian positions of the endeffector, the first object, and the second object, and is always 9 dimensional. - I think the obs space is 12 dim on the master version.

The positions of objects and goal positions are fixed in all tasks in this evaluation, so as to focus on acquiring the distinct skills, rather than generalization and robustness. - This does not hold in the current version imo.

Please do not take this as some sort of criticism. I am thankful that your team open-sourced the benchmark. I have been trying to reproduce the results for a few weeks now and some of these differences mean I can not just reuse the params mentioned in the paper.
I think improving the benchmark is an imp thing but knowing which version of the benchmark corresponds with the paper will be helpful as well.

Hey guys - could you please provide some help here :)

Hi @shagunsodhani sorry for not answering your follow up questions earlier. I am not an original author, however I am now a maintainer and I'll do my best to answer your 3 inquiries.

the observation space is in fact of the shape (12, ) now. And it technically always was, allow me to explain:

The observation space before was (xyz-sawyer, xyz-object, xyz-goal) for most environments. The XYZ goal would be 0ed out for the metarl benchmark. In practice, we did however always pad the observations of these environments to match environments of the form (xyz-sawyer, xyz-object1, xyz-object2, xyz-goal), and would 0 out the entries of the observation belonging to xyz-object2 if there was no 2nd object in those environments.

the statement that goal and object states are held to be the exact same is true when one uses the Multitask-RL benchmarks, but not the Meta-RL benchmarks. In those benchmarks Meta-RL benchmarks every time set task is called on an environment it's initialization will change (goal and initial object position)

the current version of the benchmark is the most stable and most true to the original paper. We don't have access to the version that was originally used to run for the paper under this repo, and are planning to update the results on the publicly available Metaworld.

Hi @shagunsodhani I'm going to close this issue for now because I believe that I have answered your question. Please do @ me and reopen this issue if you have more questions :)

Thanks for all the replies @avnishn . I will get back if I have any other questions.


Dependency issues at time of update?

For the past few versions, since v19.09.2, no longer able to update Authentic Theme, with the following error:

Installing this version of Authentic Theme 19.12 requires latest and/or possibly unreleased version of Usermin 1.740 to work properly. There might be incompatible changes, that could stop the theme from working as designed. To bypass this warning, and force install the theme anyway click here, or upgrade Usermin to the latest development version first using console, by running update-from-repo.sh script from its directory.

Screenshot: https://prnt.sc/izstit
When checking for package updates in Virtualmin, it says "All installed packages are up to date," also when running the apt-get update / apt-get upgrade commands as root there is nothing to update/upgrade either.
Is that normal that Authentic Theme requires unreleased Usermin version to update?

Hi, Sergey.
Actually, it's been released. (Check Webmin.com website).
There was some bug in our deploy script, that failed to pull updates to Virtualmin repo.
We're fixing it in a bit. Sorry about that.

@serj86
If your using Ubuntu/Debian a quick fix is to add
deb http://download.webmin.com/download/repository sarge contrib
to /etc/apt/sources.list
Then apt update & apt upgrade and you should be able to update Authentic Theme


Do not complete past items for the template file

The template file should not be automatically modified by the plugin as it is just a template that will be reused.

What is your setup? The plugin never touch the templater file and just pass it to templater plugin so it shouldn't happen. My first guess is maybe the templater file is accidentally set to day planner file. Can you reproduce it in the empty vault?


Add .editorconfig

I'm finding that I'm adding the .editorconfig file to each install of WPStarter (next to .env). Any chance of getting this added to the default?
# This file is for unifying the coding style for different editors and IDEs
# editorconfig.org

# WordPress Coding Standards
# http://make.wordpress.org/core/handbook/coding-standards/

root = true

[*]
charset = utf-8
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
indent_style = tab

[{.bowerrc,.jscsrc,.jshintrc,*.json,*.yml}]
indent_style = space
indent_size = 2

[*.txt]
end_of_line = crlf

[*.md]
trim_trailing_whitespace = false

The second block could also have an eslint selector too.

The JSON-ish files could also be captured via [{.*rc,*.json,*.yml}], which would account for an .eslintrc (or even a .babelrc) file.
No idea if that's better than explicitly enumerating files (that might not even be there at all), though.

I'm good with .*rc - nice spot.

@GaryJones when you can file a PR to dev and I'll merge. Thanks!

[ ] Add into templates directory.
[ ] Add to Config re validation / existence of file.
[ ] Documentation.

What else is needed to wire this template up?

@GaryJones those three steps are more than enough for me.

I'm reconsidering this for v3.
I don't want people to be forced to a specific style when using WP Starter. With v3 there's the possibility to add (reusable) custom steps, and I see creation of .editorconfig to be a good candidate for that.
Because this is not going to happen for v2, I think I can close this.
Thanks to anyone involved, I hope now work has been made already for this. Here I see no commits.


Modify Telemetry Default Bucket

Two objectives:

Add a default bucket for telemetry
Increase the interval between heartbeats from every 10 minutes to daily

Note: The Makefile currently overrides the segmentToken property during the build process via the LD_FLAGS variable. So this change won't stick if using make dev-apply unless the Makefile is modified.

Hardcode of any tokens is bad practice. Please add token to the GH secrets and reference it as env variable (SEGMENT_TOKEN) in the build workflow

as discussed in slack: this is intentional and will allow us to track telemetry for locally built 2A installations. the token itself is not a secret and can be easily distributed (we already distribute it to built versions of 2A, so if somebody knows how segment works they could figure out the token also from the built version)


Support --no-sandbox flag for deployments in Docker and on cloud as root - done

See here - https://github.com/open-rpa/node-red-contrib-tagui/issues/7#issuecomment-996499956

Fixed in TagUI v6.102. If you are using TagUI v6.46 and above, you can get this update with tagui update command or MS Word plug-in Update TagUI button. If not, you can get TagUI v6.46 from this installation page before performing the update. For list of changes since TagUI v6.46 release in mid-June 2021, visit this link (also found at TagUI installation page).

By creating a dummy file (either blank or with text it's both ok) tagui/src/tagui_no_sandbox, TagUI will run Chrome with the --no-sandbox option. This option is needed to run Chrome as root user (for eg on the cloud) or in a Docker container.

Fyi @ruthtxh

Root cause for above issue is some Docker security policy changed.

Closing since this change has made its way into the latest packaged release.


About Quality Classifier

Before Asking 在提问之前

[X] I have read the README carefully. 我已经仔细阅读了 README 上的操作指引。

[X] I have pulled the latest code of main branch to run again and the problem still existed. 我已经拉取了主分支上最新的代码，重新运行之后，问题仍不能解决。

Search before asking 先搜索，再提问

[X] I have searched the Data-Juicer issues and found no similar questions. 我已经在 issue列表 中搜索但是没有发现类似的问题。

Question
Thank you for sharing this great project.
I am now attempting to train a Quality Classifier for other languages.
Could you please tell me which base architecture (base model) you used for training the Quality Classifier (GPT3, and Chinese)?
Additional 额外信息
No response

Thanks for your interest! You can find the details on how to use our provided script to train your own classifier, as well as information about its underlying architecture (based on PySpark and LogisticRegression), in our doc.

Thank you for your kind reply :)


iOS 13 Support

Hey, just a heads up - this package fails with the error cnerrordomain 102 in iOS 13 since it tries to access the note field, which now requires a special entitlement com.apple.developer.contacts.notes that's only available by submitting an application.
My fix was to simply comment out the two refererences to note in RNUnifiedContacts.swift.
...
// CNContactNoteKey
...
// addString(&contact, key: "note", value: cNContact.note)
...

Interesting. So there's no way to obtain the notes without individually submitting an application to Apple?

Their stance is that notes are a privacy issue since users put sensitive info there, so they're locking it down going forward. From what I can gather the people who've submitted applications haven't even been given a response. It could be one of those things where they're only going to allow the biggest players to play, but that's just speculation on my part.

Thanks for the additional info. I'm going to release a new major version since this will break existing apps using this library that are trying to access the .notes attribute.
Then in a future version we can add an option to include it if the app using this library has request specific permission / entitlement for it.
Thanks!

This has been merged into master and released to npm as v2.0.0-pre.2. Update your package.json accordingly or use master branch.
NOTE: You will no longer be able to access the note attribute of a Contact so update your app if you're doing that.

Hi @joshuapinter, are there any other breaking changes in v2.0.0-pre.2? I checked the release description but it didn't say anything. Just wanted to confirm. Thanks.

Not sure at this point. I have fallen short on developing this and keeping up with the CHANGELOG. I'm hoping to change that during this self-isolation period.

I upgraded and haven't noticed any issues on iOS till now 😄

🤞 :)


Use default wake interval for WorkerPool

Currently Interval defaults to unset/zero which will result in worker pools that spin and peg all available cycles querying for new jobs. This patch changes the default interval to use the same logic for NewWorkerPool as NewWorker and use a default of QUE_WAKE_INTERVAL or five seconds if unset.

@titanous am I misreading this? it looks like it defaults to 5 seconds: https://github.com/bgentry/que-go/blob/4ad3cf5c7e0aa6382d5a437deed9951efbe5d2fa/worker.go#L49-L54

It's overriden on line 162.

Doh. I'll look into adding a test for this but gonna merge the fix right away. Thanks! :v:


Box shadow below the header sticks to the right.

Possible fix: Use Compass transform mixin in the header mixin file.

This happens on browser which do not support the unprefixed transform rule.

The left: 50% and translateX(-50%) may not be required if simplyleft: 0 is used.


Incorrect target displayed in vscode status bar on startup

Brief Issue Summary
When starting or loading a vscode project with vscode-cmake-tools enabled and shown in the vscode Status Bar at the bottom, the "active target" display always starts out as "[all]", even though a more specific target may have been saved/restored after project load (and will thus be applied if user presses the "Build" action in the Status Bar).
Expected:

With vscode-cmake-tools displaying status in the vscode Status Bar:
click the target in the status bar to change it from e.g. "[all]" to e.g. "[install]".
Save project and window state and quit vscode.
Open vscode again, and load prior project and window state (if not already loaded automatically, depending of course on how you started vscode).
CMake "active target" should display in Status Bar as "[install]" since that's the actual active target. (See below.)

Apparent Behavior:
In step 5 above, CMake status instead displays as "[all]".  However, upon clicking on the active target field in the status bar, the status is immediately updated to reflect the true state of the active target, i.e., "[install]" in the example sequence above.
This is very confusing because it appears that pressing the "Build" action on the status bar will run CMake (for target all) -- however, it will in fact run CMake install, which is clearly a different result than just CMake (all).
This is evidently a display issue, not a state-restoring issue, as the active target is correctly restored from the previous session as install, but the control doesn't indicate such!
Note: upon clicking the Build action, the status does in fact change from "[all]" to "[install]" immediately (without the user having to click on the active target field directly), the very first time the user clicks it.

Open vscode after having previously set the active target to "[install]" per above steps.
Observe immediately after the project is loaded, that the active target is incorrectly displayed as "[all]".
Clicking the target or clicking Build will immediately refresh the state of the target displayed to "[install]". (Though of course, the user may not have meant to do an install since they didn't see that indicated at the time they clicked Build in the latter case.)

Platform and Versions

Operating System: macOS
CMake Version: 3.18.4
VSCode Version: 1.53.0
CMake Tools Extension Version: 1.5.3
Compiler/Toolchain: Clang 12.0.0

Other Notes/Information
I don't believe this is macOS-specific, though I have not verified this on other platforms. It seems like just an update bug for the initial state of the control in the vscode status bar UI as implemented by the vscode-cmake-tools plugin.

Thank you for reporting this problem. I reproduce the wrong status bar label but only when no configure process is done. Do you have configureOnOpen set to false?
When you build, if no configure was run already, it will be performed before the build so that's why the status bar label is updated.
Even so, it's still a bug and we will address it. Just note that if your project configures immediately after being opened you won't see the inconsistency.

@slgoldberg Please use the workaround to configureOnOpen. Please let us know if you're still facing issues. Closing this. Thanks!

Thank you for taking a look at this!
Yes, that's correct, I did have "configureOnOpen" set to false -- I don't
recall ever doing that, but it's definitely true. Maybe it was because I
adopted this very early on, and something was broken back then. Who knows.
Anyway -- I modified my settings to change configureOnOpen to true, and I
believe this works correctly. Thanks again.
Steve
On Wed, Jul 5, 2023 at 11:08 AM Garrett Campbell @.***>
wrote:

@slgoldberg https://github.com/slgoldberg Please use the workaround to
configureOnOpen. Please let us know if you're still facing issues. Closing
this. Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-cmake-tools/issues/1649#issuecomment-1622232111,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCJXL5OTS7FSIPC7RG2X6DXOWT5RANCNFSM4XDUWUDQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


feat: support subscriptions over IPC

we were lacking support for subscriptions over IPC.
this modifies the service handler so it supports subscriptions as well, this is modelled after the jsonrpsee websocket handler.

Codecov Report

Merging #2667 (7df3596) into main (9fe84bf) will decrease coverage by 55.74%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main    #2667       +/-   ##
===========================================
- Coverage   71.41%   15.67%   -55.74%
===========================================
  Files         500      500
  Lines       64483    64609      +126
===========================================
- Hits        46050    10128    -35922
- Misses      18433    54481    +36048

Flag
Coverage Δ

integration-tests
15.67% <0.00%> (-1.96%)
:arrow_down:

unit-tests
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

crates/rpc/ipc/src/server/ipc.rs
0.00% <0.00%> (-60.00%)
:arrow_down:

crates/rpc/ipc/src/server/mod.rs
0.00% <0.00%> (-72.81%)
:arrow_down:

... and 371 files with indirect coverage changes


docs: clang-format-9

We've settled on using clang-format-9 as the default clang-format
version to be used within the project.  Other versions will likely
work acceptably, but to ensure that a pull request won't be rejected
due to formatting, developers should use clang-format-9.
Note that I do not have a Fedora machine, and did not attempt
to update the Fedora documentation.
BUILD.md:

consistent formatting for literal commands and switches
clang-format-9 and clang-tidy-9
Ubuntu instructions on getting clang-format-9 and clang-tidy-9
minor spelling fixes

CONTRIBUTING.md:

clang-format-9
minor spelling fixes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

posting a different PR based on the dev branch


Roll Flutter Engine from c50eb8a65097 to 015f3b1dec53 (2 revisions)

https://github.com/flutter/engine/compare/c50eb8a65097...015f3b1dec53
2024-09-05<EMAIL_ADDRESS>[engine] always force platform channel responses to schedule a task. (flutter/engine#54975)
2024-09-05<EMAIL_ADDRESS>Fix unexpected ViewFocus events when Text Editing utilities change focus in the middle of a blur call. (flutter/engine#54965)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC codefu@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Reason for revert: breaking flutter-dashboard


Missing DLP Tier 1 support in 7MS/Mozilla/BodgeIt themes

In v8.4.0 the following packaged customizations would become invalid due to missing declaration of keywordsForPastebinDataLeakChallenge on one of their products:

7ms.yml
bodgeit.yml
mozilla.yml

:information_source: Read #792 carefully for details about the puzzle aspect and how the challenge is supposed to work before submitting any PR or creating any PasteBin entries!

How to fix this issue

[ ] One product in each config must be chosen as the Pastebin Leak Challenge Product and receive keywordsForPastebinDataLeakChallenge property with a list of expected trigger words
[ ] An anonymous PasteBin paste must be created for each config that makes sense in the "back story" of the chosen unsafe product and contains the trigger words (including a little puzzle to find them)
[ ] The internetResourcesSpec.js placeholder xit's must be filled for each new PasteBin paste and be activated

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@bkimminich, weren't we using two products for the validation of the Pastebin Challenge? And I believe we can put a section in the docs the prerequisites for setting up this challenge as it would vary from installation to installation.

No, only one product, but we chose two "ingredients" as a danger-combo and the puzzle was to identify them in your pasted data.
It will be documented for custom configs how this challenge needs to be prepared, but as the Juice Shop delivers 3 extra sample configs out of the box, those must be complete and all challenges should work. That's why I opened this reminder-issue to address it before 8.4.0 goes live.


updating plugins for 1.3.0 - error: Server does not allow request for unadvertised object

git checkout v1.3.0
M	externals/binaryen
M	libraries/fc
M	libraries/wabt
Previous HEAD position was c71d22451 Merge pull request #87 from EOS-Mainnet/master
HEAD is now at 0f6695cb8 Merge branch 'develop'

git submodule update --init --recursive
warning: unable to rmdir 'test/emscripten': Directory not empty
warning: unable to rmdir 'test/spec': Directory not empty
warning: unable to rmdir 'test/waterfall': Directory not empty
Submodule path 'externals/binaryen': checked out '16d641f62ab14df845c87a63efe4d991b508d19a'
error: Server does not allow request for unadvertised object 4dc8375d7d3e02ab1177ab5c22835f75b45c845a
Fetched in submodule path 'libraries/fc', but it did not contain 4dc8375d7d3e02ab1177ab5c22835f75b45c845a. Direct fetching of that commit failed.

For a very old git checkout of EOS.IO, the easiest option is to simply delete your existing eos directory and git clone from scratch.  Fighting your way through git's confusion about months of changes showing up at once isn't worth your time.


Fix reference to ctx.method in router.js

I believe this.method is from an older version of Koa?
It should be ctx.method, this.method is undefined.

Should have checked PRs first, #215


URBDRC channel support

Freerdp now supports redirecting USB devices from clients to servers through the URBDRC channel. Is it possible to implement URBDRC support for xrdp server using Linux gadget subsystem interface or USBIP kernel module interface?

I'm going to move this to a discussion so that it gets an exposure to a wider audience.
Unless I'm missing something, neither of these interfaces seems designed for this type of operation. It might be possible to get something working, but it is likely to be pretty complex, and as such is unlikely to be something we'd want to take on the maintenance for.
This project seems more along the lines of what we'd need, but it's not yet of production quality.
I could well be wrong though. Anyone else?


Is this project dead ?

Hi,
I would like to know if this project is still being maintained?
There are 13 PRs and 50 issues.
The swift 5 support is still not present, the last release was almost 2 years ago.
I can make a pull request to add it and fix all warnings, but I have to know if I should do in a fork or in this repo.
Thank you for your answer.
Sincerely

@bfrolicher thanks for reaching out. Yes it's still being maintained, I will focus more on this repo to keep it updated. Please help submit your PR to support Swift 5 if you have time. Cheers.

update: I have just released v0.7 which supports Swift 5 and fixes all warnings.


Feature#471a

Renamed addresses as address_client and address_server depending on wich side is calling

There are some conflicts on this PR


fix(tabbable): correct some returned types

Closes #
📝 Description
This PR simply fixes some TypeScript types from the package @zag-js/tabbable, by explicitly adding returned types.
⛳ Current behavior (updates)
The current .d.ts file in<EMAIL_ADDRESS>declares that some API returns HTMLElement.
/**
 * Returns the first focusable element within the element
 */
declare function getFirstTabbable(...): HTMLElement;

🚀 New behavior
But they should return HTMLElement | null.
/**
 * Returns the first focusable element within the element
 */
declare function getFirstTabbable(...): HTMLElement | null;

💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
N/A

Thanks for this PR @ocavue.
I love your work on Aria UI; it looks exciting. I wonder if you would be interested in contributing to Zag.js so we can support web components? Using preact-signals is a clever approach.


PushNotificaton init on iOS does only returns invalid token - not gcm format

Expected Behaviour
PushNotification.init() should deliver the GCM token with the on.register() method.
Actual Behaviour
push.on passes unknown token (APNS?)
example: e42c18e50e3bac33950fb65710db0696482b409a4dac08ff108e273c6828a7c2
Reproduce Scenario (including but not limited to)
GCM project with Apple push certificate for development and production has been created.
PushPlugin version 1.6.4 (with senderId set on install)
Cordova version 6.0.0
Steps to Reproduce

Start application
look into return values of on.registration

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

iOS 9.3.1

(Android) What device vendor (e.g. Samsung, HTC, Sony...)

Apple iPad 2

Cordova CLI version and cordova platform version
cordova --version
6.0.0
cordova platform version ios

Installed platforms: ios 4.0.1
Plugin version
cordova plugin version | grep phonegap-plugin-push

phonegap-plugin-push 1.6.4 "PushPlugin"
Sample Push Data Payload
not necessary
Sample Code that illustrates the problem
PushNotification.init({
          android: {
            senderID: "#senderId",
            icon: "icon",
            forceShow: true
          },
          ios: {
            senderId: "#senderId",
            gcmSandbox: true,
            alert: "true",
            badge: "true",
            sound: "true"
          },
          windows: {}
        });

Logs taken while reproducing problem
{registrationId: "e85f54f498baca96943a4e5dcecebe35aed8ba7f2292230ae49881d11b51d853"}

The GCM token and APNS token look quiet different. What you are seeing there (since you said you are on iOS) is the APNS token. It looks like it is working as intended.
What problem are you having exactly?

I was able to fix it now, at some time the device.ready() was removed so the registration happend to early. Stragely this was not an issue on android but only on iOS. (I want to send iOS push notifications using GCM so i needed the GCM token instead of the APNS)
Thx anyway!


Add timestamp to TXs on home screen

See https://projects.invisionapp.com/share/Y5QIVUGTVER#/screens/357708988
Each TX in "Activity" should show the timestamp in "time ago" format.
e.g. 2 min ago

@marcinbodnar You can use transaction.blockTimestamp for the data, and something like momentjs to convert to "time ago"

Closed by #257


Implement declarative (attribute-based) configuration

So that rules can be applied to particular controllers/methods/functions by placing a ThrottlingTrollAttribute on them.

Done in v7.0


reduce_mean is not numerically accurate on GPU

For smaller size matrix tf.reduce_mean works fine.
But for larger size matrix floating point results are not accurate.
I am running on CUDA 7.0, Titan X.
import tensorflow as tf

mat3 = tf.get_variable("mat3", [4500,4500], initializer=tf.constant_initializer(-1.))
reduce_mat3_ref = tf.reduce_mean(mat3)
with tf.Session('') as sess:
    tf.initialize_all_variables().run()
    reduce1 = sess.run(reduce_mat3_ref)
    print(reduce1) # on CPU this is -1.0, on GPU this produces -1.00006
    assert(reduce1 == -1.)

Also on CUDA 8.0, GTX 980/GTX 1080, result is off by 5.86509705e-05

Relevant issue: #2625
Although I don't think numpy uses any of those stable methods, and it still gives exact result on the problem above, so something else is going on

There's a PR for Eigen to support double at the moment:
https://bitbucket.org/eigen/eigen/pull-requests/216/enable-efficient-tensor-reduction-for/diff
You can add yourself to the interest list of that PR. As soon as that's available, you can explicitly make your input tensor to be of dtype double and get the accuracy you prefer. How does that sound?

the problem using both float on GPU and CPU, the results does not agree on each other. and this example is trivial enough, all the numbers are -1 in the entry. Float's precision should have been sufficient.

I believe this is a duplicate of #3103, which was closed as "working as intended".
The basic problem is that there's a speed/accuracy tradeoff for reduce_mean.  Even though your example seems trivial, with the entire matrix initialized to -1.0, there are 20M+ entries (4500*4500).  Note that float32 can represent integral numbers in the range [-16M,+16M] without loss of precison (24 bits):
https://en.wikipedia.org/wiki/Single-precision_floating-point_format
So we expect to see some error if we accumulate all of the -1.0 entries and divide at the end to compute the mean.  This also explains why smaller matrices didn't exhibit the problem.
Hope this answers your question!


22 create sign up page

Created a signup form.
Password length validation.
Checked if the passwords match.
Made a call to the API.
Moved the data-access folder to the client folder. Update call.js file.
Removed user-validator middleware and pasted the code in the controllers.
Added google fonts.

Hi Rayane,
did you already pulled the development into your signup page branch ?

Hi Rayane,
did you already pulled the development into your signup page branch ?

Hi @dirk-jacobs I am doing this now.


MWPW-146129 App Launcher overlaps the menu in Unav in the devices

Description
In non dekstop viewports, if the user clicks on one of the unav buttons while the menu is open, the popovers and the menu overlap. This PR brings the behavior in line with what happens on AEM.
Related Issue
Resolves: MWPW-146129
Testing instructions
See the JIRA ticket
URL for testing:
Before: https://main--milo--adobecom.hlx.live
After: https://unav-mobile--milo--sharmrj.hlx.live

I'm not sure why unit tests are failing. The global-navigation tests seem to be passing (and global-navigation is the only modue I've touched).

Verified the changes and we done see overlap issue now. PF below screenshots

Personally, I would have still integrated this into the closeOnClickOutside logic, which would have also covered the use-case where a user clicks anywhere outside the hamburger menu area, but maybe that can happen in the future.

The issue with that is that it changes the current behavior in mobile viewports where tapping in the thin area outside the menu (when it's open) does nothing. I'm not sure if the current behavior should change.


Infinite scroll limited to 3-5 pages

I'm not sure if this is an AVE issue or if Voat isn't cooperating, but infinite scroll rarely returns more than 3-5 pages before returning "Sorry, I couldn't find more content".

I think this is a Voat issue.
It only happens with your front page when logged in right?

Yeah, the front page. I don't know if it happens elsewhere, I'm not all that adventurous. Log-in status doesn't seem to be a factor though, I hardly ever log in.
I haven't spent much time there lately (it's gotten way too political for me), but I do still scroll through a handful of pages of top posts. Infinite scroll used to work. The site has been performing shittier as a whole, so maybe that's the cause.

I replicated the bug without AVE. Infinite scroll works fine, after page 4 there is simply no more content to load.
I think the front page sorting algorithm is finite in some way. I'll dig into Voat's code and see if something can be done.


Throw exceptions instead of errors in stringToArray

This PR aims to:

Throw exceptions from LvArray::input::stringToArray() instead of errors. This will help to add context to these parsing errors by catching these exceptions, as a lot of parsing function & method propose to.
Detect when a token is missing before a '}'
Slightly reformulate some error messages and add one when a comma is placed just before the ending brace.

GEOS Issue related: #2320
GEOS PR : #2357

@corbett5 @rrsettgast
Can you put the appropriate protections in place such that

does not happen anymore? I'm upgrading LvArray as a submodule and I'm impacted by this premature merge.

@corbett5 @rrsettgast
Can you put the appropriate protections in place such that

does not happen anymore? I'm upgrading LvArray as a submodule and I'm impacted by this premature merge.

?? There we no limitations on who could merge a PR. They are in place now.

I'm not sure there are many protections on submodules.****


updated SDK to 9.1.16

modified info text for adding other networks (and enabling modules since the plugin can do that now)
added additional frameworks/libraries required by new version
moved external library licenses to root

cc: @MaxGabriel @ekilah

lgtm besides that small question

i guess this is 9.1.14, not 9.1.16 as the name suggests. @KarimP i'll merge the PR, but since 9.1.16 is just a bugfix on top of 9.1.14 i'll probably replace it after merging the PR


Create Pseudo code

Issue Number:
Issue Description:
Summary of solution:

Can this issue be closed?
Should any new issues be added as a result of this solution?
Have you named your branch in a descriptive way? Remember to name your branch in a unique and descriptive manner in order to properly reflect the issue or feature.
Thanks for contributing!

Please provide a description of the scope and purpose of this proposed change.
Thanks!

of a local optimization routine

what is it you're trying to accomplish here? Do you have an area where you would apply this optimization? Perhaps you could explain more thoroughly?


Not working with PyCharm 2017.3.2

Just udpated from PyCharm 2017.2.3 to 2017.3.2 and the CodeGlance plugin is no longer working.
Tried deactivating/reactivating and uninstall/install (with restarts in between) and nothing works.
Later I re-installed PyCharm with JetBrain's JRE, but that didn't change anything.
More Info

This is on a Windows 10 machine.
A colleague has PyCharm 2017.3.1 on a Mac and the plugin is working fine.

Not Working for me  also . Here is my environment.
IntelliJ IDEA 2018.1 EAP (Ultimate Edition)
Build #IU-181.3007.14, built on January 24, 2018
IntelliJ IDEA EAP User
Expiration date: February 23, 2018
JRE: 1.8.0_152-release-1136-b5 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Windows 10 10.0

Not showing on macOS 10.12 either.

same operation system, same phpstorm version, different computers, on 1 is working on the other it doesn't.
Can we assist somehow so you can somehow see what's the reason it doesnt work ? cuz obviously its random ?
maybe we can clear some cache somewhere ?

I just realised it still works on smaller files.

Suddenly stopped working on ubuntu 16.04 LTS, worked fine before. Resintall of plugin didn't help.
PyCharm 2017.3.3 (Professional Edition)
Build #PY-173.4301.16, built on January 11, 2018
JRE: 1.8.0_152-release-1024-b11 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Linux 4.4.0-116-generic

Ok, now working.  In fact, I think it always worked, except I didn't know how to make it visible.  It probably was hidden during PyCharm's update.
Press Shift + Ctrl + G to toggle visibility!

Like @Brunarspunar, I too had this checkbox set to disabled.  It seemed to have happened on its own.  I reinstalled several times with no success. Wasn't until I read this Issue that I found the problem was that disabled checkbox.

Hate to say it, but #metoo on the disabled.  Something, prolly an IntelliJ update, changed it.

It was not working for me, later found out I had to restart the IDE after installing. It works fine now.


Deciding on a journal

This could give us some guidance: http://www.software.ac.uk/resources/guides/which-journals-should-i-publish-my-software
Any suggestions? I think everyone's constraints are the same:

Open
On arxiv also

I like the look of http://openresearchsoftware.metajnl.com/

You might also consider publishing each major release of the code on Figshare or Zenodo, so its citable  by DOI.

That's done @langner: https://zenodo.org/record/45187#.VrhJUVSLRhE
(There's a badge on the README.)

I like the look of http://openresearchsoftware.metajnl.com/

:+1: Looks great to me.

Ah yes. Way cool.

There's a couple of things about that journal that need to be thought about (fees):
http://openresearchsoftware.metajnl.com/about/submissions/

There's a couple of things about that journal that need to be thought about (fees):

To be clear, if we did go anywhere with fees, I would be able to cover them through CU.

It looks like the JORS submission policy has changed slightly since we last looked. They now offer a LaTeX template. Going with them :)

Actually, looking at the template. It's mildly restrictive, going to drop the editor a line.

This is now on the JORS branch: https://github.com/Axelrod-Python/An-open-reproducible-framework-for-the-study-of-the-iterated-prisoners-dilemma/tree/jors
Waiting to hear back from editor and also to get author info OK'd.

This is another option: http://www.springer.com/economics/economic+theory/journal/182
(CU could cover the open access fees: I'd rather not go with a closed open access solution like this.)

closed open access solution.....

I don't understand what that means - but I'm happy for it to be published wherever you think best!

This: http://www.worldscientific.com/worldscinet/igtr is also an option and they have this as their OA policy: http://www.worldscientific.com/page/open

Actually, looking at the template. It's mildly restrictive, going to drop the editor a line.

What's the restriction?

I don't understand what that means - but I'm happy for it to be published wherever you think best!

It's the ridiculous situation where:

Academics do the research (paid for by the tax payer);
They submit it to a journal;
Everyone complains that papers should be viewable by all;
Journals kindly offer to for a small fee (usually around £1500) make the article available to all;
Academics Tax payers pay this fee

In essence there's open access and open access: one of them is real the other is just were publishers get paid twice (and academics still do all the work).

This: http://www.worldscientific.com/worldscinet/igtr is also an option and they have this as their OA policy: http://www.worldscientific.com/page/open

The policy page lists three 'Full Open Access Journals', but igtr isn't one of them.

It's the ridiculous situation where: .....

Ah! I see. That stinks and I'd rather go nowhere near it!

What's the restriction?

They want quite a strict structure: here is an example http://openresearchsoftware.metajnl.com/articles/10.5334/jors.104/

Overview
Availability
Reuse potential

We could write an article in that format but it would read as more of a "brochure" than the current paper. There's nothing stopping us writing that one as well.
I've asked if something a bit different would be of interest to the journal.

The policy page lists three 'Full Open Access Journals', but igtr isn't one of them.

Missed that.

The policy page lists three 'Full Open Access Journals', but igtr isn't one of them.

Yup: http://www.worldscientific.com/page/igtr/submission-guidelines says: "Once the paper is accepted, authors are assumed to cede copyrights of the paper over to World Scientific Publishing Co.". That ones gone.

IGTR: None of the articles in there have the open access icon next to them

I like the look of http://www.springer.com/business+%26+management/operations+research/journal/10287 (gambit papers have gone there) but there is a fee for open access: http://www.springer.com/gp/open-access/springer-open-choice

I really like the look of http://www.hindawi.com/journals/gt/

This is another option: http://www.mdpi.com/journal/games/apc

I really like the look of http://www.hindawi.com/journals/gt/

$195 seems like a more reasonable publishing fee!

This is another option: http://www.mdpi.com/journal/games/apc

500 CHF is slightly more but still better than > $1000!

500 CHF is slightly more but still better than > $1000!

Apparently: £362

Could also go for PLOS ONE although that has a high cost again: $1,495 USD
http://journals.plos.org/plosone/s/publication-fees
This would/could be covered by CU.

I'm out of my depth here - if it's open access, I'm happy. Go with whatever might suit you best.

I'm out of my depth here - if it's open access, I'm happy. Go with whatever might suit you best.

I'm happy to make a call at some point, will keep writing down things here in case anyone has any objections.

I've just been speaking to the editor of JORS who clarified the required structure. We could add the availability and reuse sections and then it would be fine. They did however also suggest: http://toms.acm.org/ which looks good too.

Have decided to go with JORS. Setting the jors branch of this repo to the default one. Going to spend some time reading over it this pm but basically there now.

Afterthought: perhaps we could just publish on arxiv and choose a journal later?

Hey Karol, was going to do both today: put it on arxiv and submit to JORS. If you think there's a particular reason to hold fire with the journal let me know :)

Afterthought: perhaps we could just publish on arxiv and choose a journal later?

If it was good enough for Grigori Perelman......

If it was good enough for Grigori Perelman......

Haha true. I guess the only reason to do so would be because we want to think about the journal a bit more. I'm happy with JORS: any reservations? (Re-opening the issue)

I'm happy with JORS: any reservations? (Re-opening the issue)

None whatsoever.

I'll hold fire till tomorrow @langner :+1:

Paper has been submitted. :) :+1:

I was expecting some of the parts to be more fleshed out, but it's all good.


Invalid metric type error for metric types containing capitals

Bug Report
What did you do?
Upgraded from 2.3.2 to 2.4.0
What did you expect to see?
New features, and existing targets still being scraped successfully.
What did you see instead? Under which circumstances?
It appears all targets that have any capitals in the metric type cause the scrape for this target to fail. For example:

Metric Type
Scrape Success

counter
Yes

Counter
No

COUNTER
No

I've scraped the same targets from a 2.3.2 Prometheus and they're being appended just fine. Unfortunately 2.4.0 cannot be rolled back. For reference, we're using this .NET Library.
Environment

System information:
Running in docker, using this image: quay.io/prometheus/prometheus:v2.4.0

Prometheus version:
prometheus, version 2.4.0 (branch: HEAD, revision: 068eaa5dbfce6c08f3d05d3d3c0bfd96267cfed2)
build user:       root@d84c15ea5e93
build date:       20180911-10:46:37
go version:       go1.10.3

Logs:

level=warn ts=2018-09-13T06:10:37.93652152Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9095/metrics msg="append failed" err="invalid metric type \"COUNTER\""
level=warn ts=2018-09-13T06:10:39.071841437Z caller=manager.go:430 component="rule manager" group=node.rules msg="Error on ingesting results from rule evaluation with different value but same timestamp" numDropped=4
level=warn ts=2018-09-13T06:10:40.851112422Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9101/metrics msg="append failed" err="invalid metric type \"COUNTER\""
level=warn ts=2018-09-13T06:10:41.875560035Z caller=scrape.go:804 component="scrape manager" scrape_pool=custom_tls_scrape_targets target=https://<removed>/api/metrics msg="append failed" err="invalid metric type \"Gauge\""
level=warn ts=2018-09-13T06:10:42.917636496Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9095/metrics msg="append failed" err="invalid metric type \"COUNTER\""
level=warn ts=2018-09-13T06:10:44.068456756Z caller=manager.go:430 component="rule manager" group=node.rules msg="Error on ingesting results from rule evaluation with different value but same timestamp" numDropped=4
level=warn ts=2018-09-13T06:10:45.85053895Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9101/metrics msg="append failed" err="invalid metric type \"COUNTER\""
level=warn ts=2018-09-13T06:10:46.873520059Z caller=scrape.go:804 component="scrape manager" scrape_pool=custom_tls_scrape_targets target=https://<removed>/api/metrics msg="append failed" err="invalid metric type \"Gauge\""
level=warn ts=2018-09-13T06:10:47.919258931Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9095/metrics msg="append failed" err="invalid metric type \"COUNTER\""
level=warn ts=2018-09-13T06:10:49.077866213Z caller=manager.go:430 component="rule manager" group=node.rules msg="Error on ingesting results from rule evaluation with different value but same timestamp" numDropped=4
level=warn ts=2018-09-13T06:10:50.851515285Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9101/metrics msg="append failed" err="invalid metric type \"COUNTER\""
level=warn ts=2018-09-13T06:10:51.884877924Z caller=scrape.go:804 component="scrape manager" scrape_pool=custom_tls_scrape_targets target=https://<removed>/api/metrics msg="append failed" err="invalid metric type \"Gauge\""
level=warn ts=2018-09-13T06:10:52.916790359Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9095/metrics msg="append failed" err="invalid metric type \"COUNTER\""
level=warn ts=2018-09-13T06:10:54.072958435Z caller=manager.go:430 component="rule manager" group=node.rules msg="Error on ingesting results from rule evaluation with different value but same timestamp" numDropped=4
level=warn ts=2018-09-13T06:10:55.851243421Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9101/metrics msg="append failed" err="invalid metric type \"COUNTER\""
level=warn ts=2018-09-13T06:10:56.875002334Z caller=scrape.go:804 component="scrape manager" scrape_pool=custom_tls_scrape_targets target=https://<removed>/api/metrics msg="append failed" err="invalid metric type \"Gauge\""
level=warn ts=2018-09-13T06:10:57.933876143Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9095/metrics msg="append failed" err="invalid metric type \"COUNTER\""
level=warn ts=2018-09-13T06:10:59.087553114Z caller=manager.go:430 component="rule manager" group=node.rules msg="Error on ingesting results from rule evaluation with different value but same timestamp" numDropped=4
level=warn ts=2018-09-13T06:11:00.850462158Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9101/metrics msg="append failed" err="invalid metric type \"COUNTER\""
level=warn ts=2018-09-13T06:11:01.944988067Z caller=scrape.go:804 component="scrape manager" scrape_pool=custom_tls_scrape_targets target=https://<removed>/api/metrics msg="append failed" err="invalid metric type \"Gauge\""
level=warn ts=2018-09-13T06:11:02.916852138Z caller=scrape.go:804 component="scrape manager" scrape_pool=kubernetes-pods target=http://<IP_ADDRESS>:9095/metrics msg="append failed" err="invalid metric type \"COUNTER\""

Also worth mentioning, checking the metrics with promtool packaged with 2.4.0 says all is well.

That's invalid output, only counter is valid. The client library will need to be fixed.

Shouldn't the promtool check detect this then?

It should, that's a bug in promtool.

See: https://github.com/prometheus/common/issues/143

Sounds fair, I'll close this issue and let the issues raised against the client library and promtool be fixed instead.


feat: add pre-commit CI formatter Checker

Summary of changes
Changes introduced in this pull request:

add pre-commit CI formatter

Reference issue to close (if applicable)

Closes #254
Other information and links

@samuelarogbonlo The website for the pre-commit action says generally you want to use pre-commit.ci which is faster and has more features.. Should we use the action or the website?

pre-commit.ci probably but then we would have to install the github application and set-up a plan.

Let's do that, then.

Alright! Closing this PR.


Receive added (With suggested changes)

Should i do anything else? New to github

No it's not necessary. I just need to merge it into master.
But let me just test a little more and think if this is the correct way of handling downlinks. I find this solution nice and simple, but I need to think about and test confirmed uplinks too.
What makes me think twice about how it is done now is that you always need to do a hasRX() after every TX. On the one hand this is a simple and understandable solution, which makes the library usable to more people, but a more elegant solution would be if the TX function returned a status.
For example at the moment tx() returns a false if the transmission was unsuccessful. And it returns true if it was successful and/or a acknowledgement was received. False is the same as 0, and true is a positive number. If we return a 1 for successful transmission and a 2 for successful transmission with data received, it could work well.
But as I said I need to think which way will be the best. I'd rather do it correctly now than changing the API later.

The TX functions now return one of three enum values:

TX_FAIL = 0, //The transmission failed. In the case of a confirmed message that is not acked, this will be the returned value.
TX_SUCCESS = 1, //The transmission was successful. Also the case when a confirmed message was acked.
TX_WITH_RX = 2 //A downlink message was received after the transmission. This also implies that a confirmed message is acked.


How can we set the itemSize in the viewport ?

How can we set the max item for the viewport like the itemSize in the cdk-virtual scroll ?

Issues are for reporting bugs, not for Questions. Read through the documentation. If you're still confused, read through the source code or submit a question on StackOverflow. Sorry, we don't have the time/resources to help you research.


Update to Go 1.20.2

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/approve


com.estimote.coresdk.common.exception.EstimoteCloudException: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x63cc14b0: Failure in SSL library, usually a protocol error

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

My Android device/devices supports BLE and has Android OS version >= 4.4
My Android device/devices have Bluetooth enabled
My app has Location Permissions granted

Basic information
**Estimote SDK version:1.4.0
**Android devices affected:Samsung GT-I9305
**Android OS version affected:4.4.4
**Beacon hardware version:G1.12
Description
[Description of the issue]
When we launch our application that includes the Estimote SDK, we receive Exceptions and nothing seems to work.
If we try function
InternalEstimoteCloud.getInstance().getDevices(new CloudCallback<List>() {
@Override
public void success(List beacons) {
We don't pass throw failure callback
but the success callback is called with List beacons that contains no elements
===
The rest of application is working well, but no events are called if we are near a Beacon
We use
beaconManager.startLocationDiscovery();
(Optional) Steps to reproduce:

Launch app

**Expected behavior:LoadDeviceList and monitoring receive beacons
**Actual behavior:loadDeviceList return an empty list and monitoring never finds beacons
Logs and code
05-31 15:13:18.135 28368-28368/com.cosm.stepin.test I/EstimoteSDK: BeaconService.onCreate:79 Creating beacon service for android version 19
05-31 15:13:18.155 28368-28368/com.cosm.stepin.test E/dalvikvm: Could not find class 'android.bluetooth.le.ScanSettings$Builder', referenced from method com.estimote.coresdk.scanning.bluetooth.settings.EstimoteScanSettingsFactory.settingsForLollipop
05-31 15:13:18.155 28368-28368/com.cosm.stepin.test W/dalvikvm: VFY: unable to resolve new-instance 84 (Landroid/bluetooth/le/ScanSettings$Builder;) in Lcom/estimote/coresdk/scanning/bluetooth/settings/EstimoteScanSettingsFactory;
05-31 15:13:18.155 28368-28368/com.cosm.stepin.test E/dalvikvm: Could not find class 'android.bluetooth.le.ScanSettings$Builder', referenced from method com.estimote.coresdk.scanning.bluetooth.settings.EstimoteScanSettingsFactory.settingsForMarshmallow
05-31 15:13:18.155 28368-28368/com.cosm.stepin.test W/dalvikvm: VFY: unable to resolve new-instance 84 (Landroid/bluetooth/le/ScanSettings$Builder;) in Lcom/estimote/coresdk/scanning/bluetooth/settings/EstimoteScanSettingsFactory;
05-31 15:13:18.155 28368-28368/com.cosm.stepin.test E/dalvikvm: Could not find class 'android.bluetooth.le.ScanSettings$Builder', referenced from method com.estimote.coresdk.scanning.bluetooth.settings.EstimoteScanSettingsFactory.settingsForNougat
05-31 15:13:18.155 28368-28368/com.cosm.stepin.test W/dalvikvm: VFY: unable to resolve new-instance 84 (Landroid/bluetooth/le/ScanSettings$Builder;) in Lcom/estimote/coresdk/scanning/bluetooth/settings/EstimoteScanSettingsFactory;
05-31 15:13:18.155 28368-28368/com.cosm.stepin.test D/dalvikvm: DexOpt: unable to opt direct call 0x01ba at 0x02 in Lcom/estimote/coresdk/scanning/bluetooth/settings/EstimoteScanSettingsFactory;.settingsForLollipop
    DexOpt: unable to opt direct call 0x01ba at 0x03 in Lcom/estimote/coresdk/scanning/bluetooth/settings/EstimoteScanSettingsFactory;.settingsForMarshmallow
05-31 15:13:18.160 28368-28368/com.cosm.stepin.test D/dalvikvm: DexOpt: unable to opt direct call 0x01ba at 0x04 in Lcom/estimote/coresdk/scanning/bluetooth/settings/EstimoteScanSettingsFactory;.settingsForNougat
05-31 15:13:18.325 28368-28368/com.cosm.stepin.test D/EstimoteHelper: [Estimote] - Connected to beacon service
    [Estimote] - Data is not yet loaded
05-31 15:13:25.450 28368-28368/com.cosm.stepin.test E/EstimoteSDK: InternalEstimoteCloud$7.failure:531 javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x63cc14b0: Failure in SSL library, usually a protocol error
    error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error (external/openssl/ssl/s23_clnt.c:744 0x5cdf6d74:0x00000000)
05-31 15:13:25.460 28368-28368/com.cosm.stepin.test E/EstimoteHelper: [Estimote] - Error getting list of beacons
    com.estimote.coresdk.common.exception.EstimoteCloudException: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x63cc14b0: Failure in SSL library, usually a protocol error
    error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error (external/openssl/ssl/s23_clnt.c:744 0x5cdf6d74:0x00000000)
        at com.estimote.coresdk.cloud.internal.InternalEstimoteCloud$7.failure(InternalEstimoteCloud.java:535)
        at com.estimote.coresdk.repackaged.retrofit_v1_9_0.retrofit.CallbackRunnable$2.run(CallbackRunnable.java:53)
        at android.os.Handler.handleCallback(Handler.java:733)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:146)
        at android.app.ActivityThread.main(ActivityThread.java:5679)
        at java.lang.reflect.Method.invokeNative(Native Method)
        at java.lang.reflect.Method.invoke(Method.java:515)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1291)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1107)
        at dalvik.system.NativeStart.main(Native Method)
    Caused by: com.estimote.coresdk.repackaged.retrofit_v1_9_0.retrofit.RetrofitError: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x63cc14b0: Failure in SSL library, usually a protocol error
    error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error (external/openssl/ssl/s23_clnt.c:744 0x5cdf6d74:0x00000000)
        at com.estimote.coresdk.repackaged.retrofit_v1_9_0.retrofit.RestAdapter$RestHandler.invokeRequest(RestAdapter.java:394)
        at com.estimote.coresdk.repackaged.retrofit_v1_9_0.retrofit.RestAdapter$RestHandler.access$000(RestAdapter.java:219)
        at com.estimote.coresdk.repackaged.retrofit_v1_9_0.retrofit.RestAdapter$RestHandler$1.obtainResponse(RestAdapter.java:277)
        at com.estimote.coresdk.repackaged.retrofit_v1_9_0.retrofit.CallbackRunnable.run(CallbackRunnable.java:42)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
        at com.estimote.coresdk.repackaged.retrofit_v1_9_0.retrofit.Platform$Android$2$1.run(Platform.java:134)
        at java.lang.Thread.run(Thread.java:841)
    Caused by: javax.net.ssl.SSLHandshakeException: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x63cc14b0: Failure in SSL library, usually a protocol error
    error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error (external/openssl/ssl/s23_clnt.c:744 0x5cdf6d74:0x00000000)
        at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:449)
        at android.net.SSLCertificateSocketFactory.verifyHostname(SSLCertificateSocketFactory.java:234)
        at android.net.SSLCertificateSocketFactory.createSocket(SSLCertificateSocketFactory.java:483)
05-31 15:13:25.465 28368-28368/com.cosm.stepin.test E/EstimoteHelper:     at com.android.okhttp.Connection.upgradeToTls(Connection.java:131)
        at com.android.okhttp.Connection.connect(Connection.java:107)
        at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
        at com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
        at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
        at com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
        at com.android.okhttp.internal.http.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:296)
        at com.android.okhttp.internal.http.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:503)
        at com.android.okhttp.internal.http.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:136)
        at com.estimote.coresdk.repackaged.retrofit_v1_9_0.retrofit.client.UrlConnectionClient.readResponse(UrlConnectionClient.java:73)
        at com.estimote.coresdk.repackaged.retrofit_v1_9_0.retrofit.client.UrlConnectionClient.execute(UrlConnectionClient.java:38)
        at com.estimote.coresdk.repackaged.retrofit_v1_9_0.retrofit.RestAdapter$RestHandler.invokeRequest(RestAdapter.java:325)
    	... 7 more
    Caused by: javax.net.ssl.SSLProtocolException: SSL handshake aborted: ssl=0x63cc14b0: Failure in SSL library, usually a protocol error
    error:14077438:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert internal error (external/openssl/ssl/s23_clnt.c:744 0x5cdf6d74:0x00000000)
        at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
        at com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:406)
    	... 21 more

[Cleaning up stale issues following the rebranding of Estimote SDK to Estimote Fleet Management SDK]
Feel free to re-open this issue if the problem still persists with the latest version of the SDK, and affects the fleet management APIs (BulkUpdater, connecting to beacons and changing settings, etc.).
For enter/exit events, we're asking developers to migrate to our Proximity SDK:
https://developer.estimote.com/proximity/android-tutorial/
If you need any help with the migration, let us know on our forums:
https://forums.estimote.com


rclone tries to PUT swift segments container every time

I'm using rclone v1.38 with an OpenStack Swift cluster.
When setting the --swift-chunk-size option rclone splits large files into chunks which it stores in a separate swift container, named the same as the destination container but with _segments added on the end.
I'm using credentials for Swift that don't have authorisation to create or update containers, only objects within them. So I create the container manually with another set of credentials.
but then rclone sends a PUT request to the _segments container - it looks like it blindly does this rather than checking if it already exists. It receives a 403 forbidden code from Swift of course. it just retries a few times and gives up.
I think that it should make a HEAD request on the container to see if it already exists first and skip the PUT if it already does.
Also worth noting is that rclone seems not to give any hint what it's doing regarding chunks/segments. I've tried running it with all the verbose options but it never mentions the _segments container use at all. It only says:
2017/10/24 12:34:43 ERROR : DSC_1345.MOV: Failed to copy: Operation forbidden
which is rather misleading!

this patch works for me - I can't see any tests that need updating for this specific code, let me know if I missed something.

Thanks for fixing this!  Unfortunately the integration tests don't test the large file handling as it would involve transferring a lot of data...


Make it a function?

So it can be used to check is given module installed globally.
I just happened to look around my old issues and found https://github.com/tunnckoCoreLabs/get-installed-path/issues/22#issuecomment-435577820 where it seems I made a function that is named like this package, haha. :laughing:
I created a few libs around that before few years.

https://github.com/tunnckoCoreLabs/get-installed-path
https://github.com/tunnckoCore/detect-installed
https://github.com/tunnckoCore/is-installed

I'm actually okay with the is-installed one. So we can just link it here :)
I'm going to update them and move them to my monorepo these days.

I'm not clear on what the benefit of making it a function is?


Implement into_inner for Utf8Array and BinaryArray for reusing Buffer allocations

Many kernels operate directly on the underlying buffer, creating a new allocation for a new buffer with updated values, and re-use the other components of the array like the offsets, bitmap, etc.
In many cases, the the output of the kernel is transient, and the allocation for the buffer can be reused - as we run the kernel over a big set of arrays, we can reuse the same scratch buffer (similar to the scratch buffers used in the io modules).
Exposing into_inner allows applications to re-use the scratch allocation instead of calling out to the allocator for every array.
PrimitiveArrays and BooleanArrays already have an into_inner which deconstruct themselves into their constituent components - here we just bring Utf8Arrays and BinaryArrays in line with the other array types.

LGTM.
BTW, The Buffer is copy free, so it's free to call array.values().clone()

Yeap, seems good. :+1:


Ensuring stackSize of ItemStack is compatible with network encoding

Found a bug while playing with the StorageDrawers support.
When a stack (module 256) has a size greater than 127, the item appears as a block of air in the cooking table recipe and crafting is impossible.
This is caused by Minecraft's function PacketBuffer.writeItemStack() that encode stackSize on a single (signed) byte.
The solution proposed here is the easiest one I found, that only fakes the stackSize sent over the network (and keep message compatibility).
There could be other ways to correct this issue, but they would break message compatibility with previous client/server mod version, like:

encoding ItemStack manually using a short or an int
no longer encoding ItemStack and only sending minimum required elements (I am not sure of that, but  stackSize does not look like being used).

Regards,
Vlaeh

Sorry for the late response, been busy with other projects.
The problem was caused by MessageRecipes because it was passed those "invalid" stacks from findAndSendRecipes, so I feel a cleaner solution is preventing the issue right there instead of doing the back-and-forth with the stack size. It will now create a capped copy of the ingredient stack if necessary.


[Driver] Invalid base input argument while input "--help" in MIOpenDriver

$ ./bin/MIOpenDriver --help
Invalid Base Input Argument
Usage: ./driver *base_arg* *other_args*
Supported Base Arguments: conv[fp16|int8|bfp16], CBAInfer[fp16], pool[fp16], lrn[fp16], activ[fp16], softmax[fp16], bnorm[fp16], rnn[fp16], gemm, ctc, dropout[fp16], tensorop[fp16], reduce[fp16]

The argument "--help" is "Invalid Base Input Argument". But it should be recognized logically. The ParseBaseArg function has some problems.
https://github.com/ROCmSoftwarePlatform/MIOpen/blob/b7630f76dad1926e224a23d5e470e44987d84fc3/driver/driver.hpp#L137-L162

This is intentional. The list of supported options ("help") depends on the "base argument". For example, pooling and convolutions have substantially different options.
I recommend closing this.

@atamazov I've learned that, thank you.


[Credentials] Add a test case to reproduce chase.com issue with custom form

Reviewer: @shakyShane
Asana: https://app.asana.com/0/1205996472158114/1207793442006227/f
Description
The chase.com logon form is currently not autofilling. This PR does two things:

Fixes the FormAnalyser to include window.location.hash part of the URL so that the form is correctly recognized as login. That fixes one problem that at least the input fields on focus are autofilling on their own
Adds a form and test case to reproduce the actual issue on chase.com. The form contains two input elements, and a submit button that are in shadow root, with the form element that is outside shadow root. (The test currently breaks, but we want to aim to fix it. Skipping it with a @skip annotation).

Steps to test

Closing this, main PR likely to merge today!


minor doc issue

https://github.com/Nayni/fluse/blame/main/website/docs/plugin-typeorm.md#L51
s/faker/orm/

Thanks for reporting!


mWeb -  Future dates for DOB date picker are not disabled in personal info page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue was found when executing #8176
Action Performed:

Go to workspace > Connect Bank Account
Choose any option > Go to company step
Fill the form and save > Personal information step

Expected Result:
Verify DOB field date picker doesn't allow selecting future dates
Actual Result:
Future dates for DOB date picker are not disabled
Workaround:
Unknown
Platform:

Where is this issue occurring?

Mobile Web

Version Number: 1.1.44
Reproducible in staging?: Y
Reproducible in production?:  Y (New feature)
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/158900765-c913ddd9-ba03-45b1-95d9-92d5eb757875.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
Issue was found when executing #8176

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

I'm able to reproduce this locally. I'll take a look at it so that hopefully we can get it fixed quickly.

Safari on IOS does not support the max attribute on date inputs (source here). We set the max attribute here.

Although this doesn't correctly set a maximum date on mWeb, it works on Web. Since this is a new feature I'm going to removed the deploy blocker label.

I agree this is fine to accept, we have verification that won't allow users to input future dates, so nothing can go wrong and Safari will start to support this prop at some point.


Content-Type for static content seems to be overridden by javalin

Hi.
It seems like the StaticResourceHandlers content type is overriden by Javalin. This should be deferred.
Possibly the default header should not be set at all if there is a static resource handler.
It might also be useful to configure the MimeType mapping so that more content types might be correctly set.
If there is a way to work around this, that would be greatly appreciated.

I found a fix. PR coming soon.

Seems to have resolved itself. Strange

I'll close this issue then. Please re-open if it happens again.


Correct cp1252 encoding in utf-8

Description, Motivation and Context
I noticed an encoding issue in tools\chocolateyInstall.ps1 of tor-browser, so I found and solved other similar issues thanks to the Python script given in the first commit description.
How Has this Been Tested?
Except:

https://github.com/chocolatey-community/chocolatey-packages/commit/ee1d11b172235e1a947a46e6dc6de27ba0574cfb#diff-aae96f15f0ec487d0ff4b45ad768a1c36c8378749fe23d9e2f5e690168a285f4L2-R2
https://github.com/chocolatey-community/chocolatey-packages/commit/5fef977571d5ba5c5c2259392fc4b644ce677f6b

I am sure of my method.
Checklist:

[X] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[ ] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the chocolatey test environment.
[ ] The changes only affect a single package (not including meta package).

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

pspp AppVeyor issue isn't related to my two changes: Readme.md and pspp.nuspec.

This looks fine to me, and I am going to approve it. But would like a second pair of eyes on it in case I'm missing something obvious.

Let me know if what I did isn't fine.

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

:x: Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.


Updated Play with K8s URL

The Play with K8s website URL is broken, so updated with the new URL.

Thanks!


.runsettings  ScreenCaptureVideo, how to increase the resolution?

Hello,
Could you please assist in configuration of ScreenCaptureVideo in .runsettings.  When I use this capability only part of my screen is recorded.  Is there a way to adjust the Resolution that it captures?

@aalmanza-autosoft -- thank you for your question.  Are you following a specific docs.microsoft.com article?  Meanwhile, please consider these resources:

Visual Studio on Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

Thanks for the reply!
Yes, I am following this document that has an example of the .runsettings that includes the video recording config.
https://docs.microsoft.com/en-gb/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2017#example-runsettings-file

@pavelhorak @AbhitejJohn Do we have more information on ScreenCaptureVideo element? I haven't found a vstest platform doc for that yet.

I believe that ScreenCaptureVideo captures the entire screen, so there is no parameter to adjust the resolution. I'd guess that the reason for capturing the part of the screen only could be caused by having multiple displays with different resolutions used, etc.
@AbhitejJohn any thoughts?

@pavelhorak : Oh, I'm not familiar with that data collector as much. We'd want to take a deeper look at what happens under the covers. My best guess would be resolution as well. Perhaps switching to the device recommended resolution might help.

Is there a limitation on resolution? I have my laptop screen set to 1920 X 1080 and its still only recording a portion of the screen.

@aalmanza-autosoft If there's no parameter to adjust resolution, but only part of the screen is captured, this sounds like a bug or new feature that is needed. To make sure that this is logged in the right place, please use the Report a Problem tool to report the issue. When you do this, your report becomes part of the work items that are listed in the in the Visual Studio Developer Community, which allows you to engage directly with the engineering team while they address and fix the problem.


Fixed path to example image

Previous path didn't work if the working directory was the examples folder.

It fixes it in this case but not when you open it from the main repository which is a bit unfortunate. Maybe we can use another approach here

I think only allowing to run it from the examples directory is fine.
(unless of course there is a simple way to make it work from other directories as well)

Other options would be to use include_bytes or get the path relative to std::env::current_exe

Any updates on this one ?

I think it's fine to close this without merging. It would be nice if the working directory didn't matter, but most users probably run examples with cargo run --example from the project root anyways, so I'll just close this one.


add a flag to disable plotting confusion matrix in test

Rasa version: master
Python version: 3.7
Operating system (windows, osx, ...): macos
Issue:
Plotting confusion matrix can be time consuming and sometimes we don't care for it, therefore it makes sense to add an option to ignore the plot. Also, for nlu, I think it is better to create pdf directly instead of creating matplotlib windows first (it doesn't work on gcloud from terminal)
in case of --debug option, still turn off matplotlib debug
Another thing right now confusion matrix is unreadable (at least for core), color boxes and numbers are not aligned, also numbers overlay:

I've tested current (master) behaviour in our docker image (that would pick up Matplotlib TkAgg backend), here are results:

"rasa test nlu" renders confmat.png and hist.png, no issues with pup-up window
"rasa test coe" renders story_confmat.pdf, no issues pop-up window

On Mac OS I also don't have any pop-ups for both of the commands.
So if there was an issue with creating pop-up window on headless environments, it's not there anymore.
So I'd suggest that this ticket's goal is to introduce "--no-plot" flag with default value set to "false" that would completely skip rendering of confusion matrix and histogram.
@Ghostvv if there's an issue with readability of confusion matrix I think we should create a separate "enhancement" issue and track it separately.

sure, we should tackle them separately

@degiz moved this to review-required


Fix typos in 01-workflows.md

This commit fixes typos in the document.
Reference to non-existing function chargeMonthlyFee is replaced with chargeCustomerForBillingPeriod

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


image: fix for openssh-server installation (v2)

Previous PR #272

change v1->v2:

Modified to add sshd-regen-keys if openssh-server is included in either IMAGE_PREINSTALL or IMAGE_INSTALL.

Purpose of pull request
This commit fixes a build warning/error that occurs when installing openssh-server. The build warning/error is below.
WARNING: emlinux-image-base-1.0-r0 do_rootfs_postprocess: Looks like you have ssh host keys in the image but did  not install "sshd-regen-keys". This image should not be  deployed more than once.
ERROR: emlinux-image-base-1.0-r0 do_rootfs_postprocess: Install the package or forcefully remove this check!

The warning and error are caused by a function in isar's commit 0f7ce73b1bf30da52b0cf7a8c9b1ebb7828b2684. To resolve them, it is necesarry to install sshd-regen-keys manually.
This commit will install it automatically when openssh-server is installed.
Build Test
added following line into conf/local.conf.
MACHINE = 'qemu-arm64'
IMAGE_PREINSTALL:append = " openssh-server"

and build by bitbake.
$ bitbake emlinux-image-base

@hiromotai7 thanks.


Reset Password on Azure hosted Parse Server

The tutorial here taught to initialize through javascript. My question is do we must initialize this through js only or is it possible through java? Because I have initialized my parse connection through java and wish that I could continue with it.
        Parse.initialize(new Parse.Configuration.Builder(getApplicationContext()).applicationId("XXXX").server("http://XXXX.azurewebsites.net/parse/").build()
        );

That is for the initialization of Parse Server, which is done in JavaScript. Your clients can continue to use Java.


Curve3D::sample_baked_up_vector() returns value perpendicular to its previous value after merge

Godot version
8ab3e73a799bbfa862403747a5de9fc96ba83149
System information
Ubuntu 22.04
Issue description
Prior to 8ab3e73a799bbfa862403747a5de9fc96ba83149, Curve3D::sample_baked_up_vector() returned a somewhat plausible up vector for some curves, however since 8ab3e73a799bbfa862403747a5de9fc96ba83149 it returns a vector perpendicular to the old value. Original PR #64212
The simple attached project displays the angle between the first curve point up vector, and the global up vector
8ab3e73a799bbfa862403747a5de9fc96ba83149

8ab3e73a799bbfa862403747a5de9fc96ba83149^

Additional screenshots here: https://github.com/godotengine/godot/pull/64212#issuecomment-1320811390 (more difficult to reproduce because it requires rebasing another change)
Steps to reproduce

Create a Node3D
Assign it a Curve3D
call Curve3D::sample_baked_up_vector()
Observe the value with Godot after 8ab3e73a799bbfa862403747a5de9fc96ba83149
Observe the value with Godot 8ab3e73a799bbfa862403747a5de9fc96ba83149^

Run the attached project to accomplish the same
Minimal reproduction project
Run the example scene in this project to show this behavior Curve3D Up Vector Test.zip

cc @xiongyaohua

I thought I'd also note in the original PR there was quite a bit of discussion about whether or not the up vector is naturally a property of Curve3D or if it belongs elsewhere. I'm not sure any conclusions were reached but it obviously has a bearing on whether Curve3D::sample_baked_up_vector() should exist at all.
The sample_baked_with_rotation() method which @xiongyaohua added in that PR is more useful than sample_baked_up_vector() anyway, every use of sample_baked_up_vector() that I can think of is ultimately trying to establish a basis for some transform anyway. Perhaps the real fix is to simply drop the sample_baked_up_vector() method entirely.

Sorry for the late reply, as I am occupied by other things recently. I will investigate.