Assertoor test must check the tx spammer is working as expected as part of the stability check

Right now the tx spammer is part of the assertoor run but nothing checks it works, after the initial blob tx checks we can check for inclusion of txs in the stability_check which doesn't produce txs, if it found them then the tx spammer should be working.

This are the logs on the tx spammer:
No seed provided, creating one
sending at f93ee4cf8c6c40b329b0c0626f28333c132cf241
Spamming 2 transactions per account on 100 accounts with seed: 0x59f8f4a571d6e05e
sending at f93ee4cf8c6c40b329b0c0626f28333c132cf241
Spamming 2 transactions per account on 100 accounts with seed: 0x59f8f4a571d6e05e
sending at f93ee4cf8c6c40b329b0c0626f28333c132cf241
Spamming 2 transactions per account on 100 accounts with seed: 0x59f8f4a571d6e05e
sending at f93ee4cf8c6c40b329b0c0626f28333c132cf241
Spamming 2 transactions per account on 100 accounts with seed: 0x59f8f4a571d6e05e
sending at f93ee4cf8c6c40b329b0c0626f28333c132cf241
Spamming 2 transactions per account on 100 accounts with seed: 0x59f8f4a571d6e05e
sending at f93ee4cf8c6c40b329b0c0626f28333c132cf241
Spamming 2 transactions per account on 100 accounts with seed: 0x59f8f4a571d6e05e
sending at f93ee4cf8c6c40b329b0c0626f28333c132cf241
Spamming 2 transactions per account on 100 accounts with seed: 0x59f8f4a571d6e05e
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
sending at f93ee4cf8c6c40b329b0c0626f28333c132cf241
Spamming 2 transactions per account on 100 accounts with seed: 0x59f8f4a571d6e05e
sending at f93ee4cf8c6c40b329b0c0626f28333c132cf241
Spamming 2 transactions per account on 100 accounts with seed: 0x59f8f4a571d6e05e
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
Waiting for transactions to be mined failed: context deadline exceeded
sending at f93ee4cf8c6c40b329b0c0626f28333c132cf241
Spamming 2 transactions per account on 100 accounts with seed: 0x59f8f4a571d6e05e


Friday not displaying

I found out just now that the calendar doesn't have Friday.

Haha
Please read the props in the readme


[SILGen] Don't SILGen an @objc entry point for a deinit with no body

In general we'll want to investigate what we are and aren't SILGen-ing for textual interfaces of resilient modules, but for fragile modules we may as well generate everything we can for potential optimization purposes.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - d6ae8913c150e107d46e3c08bb9f5865b704a762

…*sigh* right.

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - d6ae8913c150e107d46e3c08bb9f5865b704a762

Build failed
Swift Test OS X Platform
Git Sha - d6ae8913c150e107d46e3c08bb9f5865b704a762

Hm. We have been testing those with non-@objc entry points, but not with @objc. I'll add that.
(Right now we're mostly trying to get the stdlib and overlays all building successfully, and this one came up in Foundation while the others didn't. But that doesn't mean we shouldn't have tests.)

@swift-ci Please smoke test

Uh, hm, that's fun. I guess we're emitting unnecessary thunks for constructors too, but it's only a problem on Linux!

Filed SR-8877 for the Linux failure. I want to get the console output before moving on, so
@swift-ci Please smoke test Linux

Linux CI run on old test file
@swift-ci Please smoke test

Ugh, right, that kills the previous job for normal tests. Oh well.


NotesTab

Fulfills #572

Doing some functional testing. Looks great! One thing I noticed is the character count in the description collides with the text.


What is the plan to support beam search

I have noticed that LightLLM currently seems to only support decoding through sampling. Additional decoding methods such as BeamSearch and GreedySearch are not yet supported. I would like to know about the development plans in this regard.

We have an internal version that supports beam search, but we feel like beam search doesn't add much value to diversity generation, so we have been keeping it out to maintain simplicity in the framework. Is there a rigid use case where beam search is a must-have?

I believe that beam search is a must-have feature for the LLM serving framework.

@feifeibear ok, we will support this feature soon.

@feifeibear ok, we will support this feature soon.

Thanks! let me if you need help.


Bump MSRV

Because of:
error: package `regex-syntax v0.8.2` cannot be built because it requires rustc 1.65 or newer, while the currently active rustc version is 1.63.0

Nix flake update

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7f98ec2) 82.57% compared to head (c2ad6b1) 81.84%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   82.57%   81.84%   -0.73%
==========================================
  Files          23       23
  Lines        4844     4837       -7
==========================================
- Hits         4000     3959      -41
- Misses        844      878      +34

see 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


ckbcomp: 1.133 -> 1.187

Motivation for this change
Package update and remove the last reference to anonscm.debian.org which is now closed.
/cc @dezgeg
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Success on aarch64-linux (full log)
Attempted: ckbcomp
Partial log (click to expand)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v8x8lf1rvvz6197009qrzrm5cjrls1xl-ckbcomp-1.187
gzipping man pages under /nix/store/v8x8lf1rvvz6197009qrzrm5cjrls1xl-ckbcomp-1.187/share/man/
strip is /nix/store/6dpnd5aniypn8124mmy8f88s4mq2zl07-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v8x8lf1rvvz6197009qrzrm5cjrls1xl-ckbcomp-1.187/bin
patching script interpreter paths in /nix/store/v8x8lf1rvvz6197009qrzrm5cjrls1xl-ckbcomp-1.187
/nix/store/v8x8lf1rvvz6197009qrzrm5cjrls1xl-ckbcomp-1.187/bin/ckbcomp: interpreter directive changed from "/usr/bin/perl" to "/nix/store/y1fhdnmisp4fhpjg6s9ij10ka24k1zww-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/v8x8lf1rvvz6197009qrzrm5cjrls1xl-ckbcomp-1.187...
/nix/store/v8x8lf1rvvz6197009qrzrm5cjrls1xl-ckbcomp-1.187

Success on x86_64-linux (full log)
Attempted: ckbcomp
Partial log (click to expand)
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qnv3zcqfrvs0clshpajpc6rgykf9smm6-ckbcomp-1.187
gzipping man pages under /nix/store/qnv3zcqfrvs0clshpajpc6rgykf9smm6-ckbcomp-1.187/share/man/
strip is /nix/store/rpbg8gmqxhz8g61p1plz5d2srs84pvmv-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qnv3zcqfrvs0clshpajpc6rgykf9smm6-ckbcomp-1.187/bin
patching script interpreter paths in /nix/store/qnv3zcqfrvs0clshpajpc6rgykf9smm6-ckbcomp-1.187
/nix/store/qnv3zcqfrvs0clshpajpc6rgykf9smm6-ckbcomp-1.187/bin/ckbcomp: interpreter directive changed from "/usr/bin/perl" to "/nix/store/1dzsd6drn31dgp3hk74x2h87j6jdj55b-perl-5.28.0/bin/perl"
checking for references to /build in /nix/store/qnv3zcqfrvs0clshpajpc6rgykf9smm6-ckbcomp-1.187...
/nix/store/qnv3zcqfrvs0clshpajpc6rgykf9smm6-ckbcomp-1.187


awless list listeners does not include target groups

@moshloop The listing of the listener will not include its targetgroups. It seems the AWS API sees listeners as an intermediary components sitting between loadbalancers and targetgroups and that there is no obvious API call to link the two directly.
But using the awless show command, you can have the full tree of relations for the 3 components starting from the load balancer. Run:
awless show name_of_my_loadb

(note: you can add the local flag -l allowing offline exploration of resources using the local storage previoulsy synced.)
In the lineage section, you will see the listeners attached to this loadb. In the applied on, section you will see the targetgroups it applies on.

I am ultimately trying to get the target group ARN from a loadbalancer but I
don't see a way of doing that  - the tree might display it, but I can't get just
the ARN
The AWS cli does return it: aws elbv2 describe-listeners --load-balancer-arn
{    "Listeners": [        {            "ListenerArn":
"arn:aws:elasticloadbalancing:eu-central-1:xxxb5adde7",
            "LoadBalancerArn":
"arn:aws:elasticloadbalancing:eu-central-1:xxxx2a",            "Port": 80,
            "Protocol": "HTTP",            "DefaultActions": [                {
                    "Type": "forward",                    "TargetGroupArn":
"arn:aws:elasticloadbalancing:eu-central-1:xxxf8b02"                }
            ]        },        {            "ListenerArn":
"arn:aws:elasticloadbalancing:eu-central-1:x59810",
            "LoadBalancerArn": "arn:aws:elasticloadbalancing:eu-central-1:3xa",
            "Port": 443,            "Protocol": "HTTPS",
            "Certificates": [                {
                    "CertificateArn": "arn:aws:acm:eu-central-1:xfc8c"
                }            ],            "SslPolicy":
"ELBSecurityPolicy-2016-08",            "DefaultActions": [                {
                    "Type": "forward",              "TargetGroupArn":
"arn:aws:elasticloadbalancing:eu-central-1:xxxx:targetgroup/xxxxx/xxxxx"
                }            ]        }    ]}
On Thu, Feb 1, 2018 3:22 PM, Simon Caplette<EMAIL_ADDRESS>wrote:
@moshloop  The listing of the listener will not include its targetgroups. It
seems the AWS API sees listeners as an intermediary components sitting between
loadbalancers and targetgroups and that there is no obvious API call to link the
two directly.
But using the awless show  command, you can have the full tree of relations for
the 3 components starting from the load balancer. Run:
awless show name_of_my_loadb
(note: you can add the local flag -l  allowing offline exploration of resources
using the local storage previoulsy synced.)
In the lineage section, you will see the listeners attached to this loadb. In
the applied on, section you will see the targetgroups it applies on.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I will see how if I can implement a way to get this information in the listing and mimic what the aws-cli does.
In the meantime (and a bit more cumbersome) to get the targetgroup ARN from a loadbalancer you can do:

awless show my-loadbalancer-name
Look at the section Applied on and grab the name of any targetgroup you want in there.
Then with the name from above do awless show my-target-group-name -l

@moshloop Fixed on master.
I have added the TargetGroups column in the listing of listeners. I display the short ARN for this column since their could be multiple TargetGroup for a listener.
Let me know is that is ok and fixes the issue for you. Thanks.

@simcap awesome - thanks, will test and let you know if their are any issues


densenet  OOM

11g   batch is 1，but still OOM....why

The graph occupies a large amount of GPU memory. Better with advanced GPUs.


Delete CloudService tests from the stable release

This PR will be used to remove CloudServices from the master branch as its swagger file is being removed from future stable releases. We will use the <IP_ADDRESS>-preview.1 (<IP_ADDRESS>) release and github tag to recreate the .Net SDK branch at the time of the CLoudService release for future development in CloudServices.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[ ] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version,

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

Attempted editing the Azsdk.RP.Props file to prevent CI failures.


Updated ember required and ember validators

Resolves #

To get the updated version of ember-cli-babel which is causing depreciation warnings

Changes proposed:

Updating ember-validators as it's current version is already having updated babel version
Also updating ember-require-module as babel version is being update in https://github.com/offirgolan/ember-require-module/pull/8

Note

Will be pushed to review when new version is released in ember-require-module after merging https://github.com/offirgolan/ember-require-module/pull/8

Tasks:

[ ] Added test case(s)
[ ] Updated documentation

@kprasadpvv will this be merged? What's the status on this?

@kprasadpvv will this be merged? What's the status on this?

@RosarioAleCali I'm waiting for the maintainers to merge https://github.com/offirgolan/ember-require-module/pull/8 , but I'm not seeing any reviews being happened on it since march 2nd.
cc @offirgolan can you review  and merge these PR's plz

https://github.com/offirgolan/ember-require-module/pull/8
https://github.com/offirgolan/ember-cp-validations/pull/703

Let's hope @offirgolan or some other maintainer will publish a new release, need to see more Ember addons being active again!

@offirgolan can you review or point to a person that can merge? Would be great to get this merged!

Apologies for the delay, I've been on vacation. I'll be transferring this to adopted addons in the next day or so.

@kprasadpvv This should be unblocked now right? (due to https://github.com/adopted-ember-addons/ember-require-module/pull/9 being merged)


Support for Jenkins

@romainneutron, i would love to add support for Jenkins, can you identify the environment parameters that are used in src/environment.js and how to test them.

@siddharthkp I'm interested in helping here. I have a project at work that builds via Jenkins. I'd like to start displaying bundle/chunk sizes in our PRs, so ideally a bundlesize job could be triggered by a PR then run in jenkins and send back results to the PR.
Are there any known issues with private repos?

@wbeard nope, should work as long as you have a token with access to the private repo

@siddharthkp from first glance, Jenkins may be tricky. I've found some mappings from jenkins environment vars to the vars needed in environment.js, but they change depending on what set of plugins you're using. I'll try to open up a PR and see if I can test the changes on my side later today.

Also, I really like what you're doing here. I've had some similar ideas around this. Would love to chat! I'm on twitter if you want to dm @thewillbeard.

I think you'd need to have an actual Jenkins plugin that executes the bundle size script in order to get the best integration experience. A Jenkins plugin could display the information directly on the permalink page for the build, or as an option in the sidebar.

@Daniel15,
I don't know how Jenkins works 😓
From what you're saying, anyone can make a plugin that runs the bundlesize cli, right?
Is it possible to add github status as well? As long as commit sha and github token is exposed, we should be good

@Daniel15 I think you're right. I got it working w/ Github Pull Request Builder, which was cool, but it doesn't have a good way to display the output of bundlesize back to the commit status.

@wbeard Can you please let me know how (steps) to make it working?

Closing this issue for now because it has not had recent activity. Thank you for your contributions.


Capturing group with lua replacement interpreter using ripgrep

Is it possible to deal with capturing groups with the lua replacement interpreter using ripgrep? I would like to do the following:
Search:
foo(bar)baz(.*)

Replace:
if groups[2] ~= nil and groups[2] ~= "" then
  return "yes: " .. groups[2]
else
  return "no 😢"
end

Thanks for your clarification! I'm sorry to hear about the PR situation. It seems like the author has shifted focus to other projects. I hope your PR gets reviewed soon!

Closing this issue for now but like I said I am always open to adding the functionality if the capture groups become available on the ripgrep output at some point.


Add files via upload

http://www.dcc.vccs.edu/ redirects to danville.edu

@Daminer5 I am sorry, the domain vccs.edu is blacklisted because the school allows to register an email address there even if you are not a student of the school. If you are the student of this school, please apply with official document (OFFICIAL DOCUMENT tab at https://www.jetbrains.com/shop/eform/students).


ci: pin actions, use built-in cache

Summary

Issues

Doesn't look like it's working, cache isn't being pulled ever, and is not saved more often than not...


Ensure Spark Session Timeout is 100 Seconds

Reports have come back that the spark session creation timeout is still 60 seconds, even though we set the following in our sparkmagic config:
'livy_session_startup_timeout_seconds': 100

I believe it is @Charles-Gagnon 's PR removed the config from configBase in extensions/notebook/src/jupyter/jupyterSessionManager.ts:
https://github.com/microsoft/azuredatastudio/commit/abbb1e54da5ad9f49e9f22eb03b6ee468490503a#diff-5de6eb5a3d545e9854995d40855bad9d

Ah, good catch. Thanks @shanyu!


Occasional error message in admin log from LocalizationProvider

Description of bug
Occasional error message in admin log. Can someone look at this line of code and see if this is correct?
Screenshots

It appears that the highlighted line below will always throw an exception?
Globals.ApplicationPath is always a physical path, and .MapPath() is expecting a virtual path?

Affected version

[ ] 10.00.00 alpha build
[X] 09.11.02 latest supported release

Globals.ApplicationPath either pulls a configuration value or uses HttpRequest.ApplicationPath, which is documented as returning "The virtual path of the current application".
https://github.com/dnnsoftware/Dnn.Platform/blob/e1a0e483e1b09060abc44dd61b6c82f0cd9f96d4/DNN Platform/Library/Common/Globals.cs#L295-L313
Does that absolute path match a value in your web.config for InstallationSubfolder?

Brian, thanks for your quick reply :)
I do not have a InstallationSubfolder setting in web.config.
And thanks for correcting me--I was mistaking ApplicationPath for PhysicalPath :)
So any idea where the physical path is coming from?
BTW, that code on line 303 looks wrong to my old and weary eyes....on the first access, applicationPath will be null, and if the setting is missing, applicationPath will be set to string.Empty, so on subsequent property accesses, it will just keep returning string.Empty...?
Shouldn't it be:
applicationPath = string.IsNullOrEmpty(Config.GetSetting("InstallationSubfolder")) ? HttpContext.Current.Request.ApplicationPath.ToLowerInvariant() : (Config.GetSetting("InstallationSubfolder") + "/").ToLowerInvariant();

The exception coming from line 300 in LocalizationProvider, and that is what's on that line. Not sure if this is an issue just with the activeforums module or not. I haven't seen this happen often, but I will keep my eye out to see if it happens again.


[desktop_drop] error C2220: cpp compile error

i used this library on flutter v3.7.0 without any problem for windows platform.
but when i upgrade to v3.13.0 i faced this error : (also on v3.10.6 and beta  v3.14.0-0.1.pre have same error )
[my_project_path]\windows\flutter\ephemeral\.plugin_symlinks\desktop_drop\windows\desktop_drop_plugin.cpp(150): error C2220: the following warning is treated as an error [[my_project_path]\build\windows\plugins\desktop_drop\desktop_drop_plugin.vcxproj]
[my_project_path]\windows\flutter\ephemeral\.plugin_symlinks\desktop_drop\windows\desktop_drop_plugin.cpp(150): warning C4701: potentially uninitialized local variable 'hwnd' used [[my_project_path]\build\windows\plugins\desktop_drop\desktop_drop_plugin.vcxproj]
[my_project_path]\windows\flutter\ephemeral\.plugin_symlinks\desktop_drop\windows\desktop_drop_plugin.cpp(150): warning C4703: potentially uninitialized local pointer variable 'hwnd' used [[my_project_path]\build\windows\plugins\desktop_drop\desktop_drop_plugin.vcxproj]
Exception: Build process failed.

i tried these solutions :

delete windows folder and create again by flutter create --platforms=windows,web .
delete build folder
change sdk - it woks on 3.7.0
flutter clean and flutter pub cash restore
update visual studio community 2022 and visual studio build tools 2019 to latest version
visual studio build tools config :

Same. This problem should occur in desktop_drop 0.4.2. I change the code in desktop_drop_plugin.cpp
from:
HWND hwnd; if (registrar->GetView()) {   hwnd = registrar->GetView()->GetNativeWindow(); }
to:
HWND hwnd = registrar->GetView()->GetNativeWindow();
Now it works for me. But I don't know if this will lead to other unknown problems.

I have the same problem here but in debug mode only and when switch to release mode the problem gone

Using this line I managed to disable warnings shown in debug console
#pragma warning(disable : 4701 4703)

Put this line above this method
#pragma warning(disable : 4701 4703)
    void DesktopDropPlugin::RegisterWithRegistrar(
        flutter::PluginRegistrarWindows *registrar)
    {
        auto channel =
            std::make_unique<flutter::MethodChannel<flutter::EncodableValue>>(
                registrar->messenger(), "desktop_drop",
                &flutter::StandardMethodCodec::GetInstance());

        HWND hwnd;
        if (registrar->GetView())
        {
            hwnd = registrar->GetView()->GetNativeWindow();
        }

        channel->SetMethodCallHandler([](const auto &call, auto result)
                                      { result->NotImplemented(); });

        auto drop_target = new DesktopDropTarget(std::move(channel), hwnd);

        auto plugin = std::make_unique<DesktopDropPlugin>(drop_target);

        registrar->AddPlugin(std::move(plugin));
    }

in
<project_name>\windows\flutter\ephemeral\.plugin_symlinks\desktop_drop\windows

Thanks for the detailed issue. I'll release an other version to pub.dev lately.


Design Meeting Notes, 6/18/2024

Coverage Reporting
https://github.com/microsoft/TypeScript/pull/58850

C8

Coverage system that wraps V8, the JS engine Node uses.
We currently have a task like this where you can run npm tests -- --no-lint --coverage.
Problem: when you bundle our entire codebase with esbuild, the file is huge. The built-in tools for C8 don't work well for processing a coverage report on TypeScript.

Monocart: a different preview tool that not only can preview the entire produced file, but can work with sourcemaps and give details on branches that are or are not hit.
Also has an output mode for codecov, a service to track code testing coverage.
Probably don't want to have the comment that says "your coverage has fallen!" and gates merging, but we do want a coverage report.

Downside: it makes CI run slower (doubles it!).

Would be great to figure out "which tests rely on a given branch executing?"

VS Code might be exploring this with https://github.com/microsoft/vscode/pull/212196

Why are we doing this if we don't want to actually make it visible?

Good question.
We have >97% coverage of the checker, but many many uncovered branches.

We want to wait on ways to make this all run faster before it's in CI - but first let's add an optional peer dep to c8 so people can run it locally.

Knip
https://github.com/microsoft/TypeScript/pull/56817

Utility to flag down functions not used outside the file, drop unused files, and drop utilities that are not used but also not exported as part of the public API.
Make exceptions by adding a /** @knipignore */ tag to the preceding comment.
Last time we talked about this, wasn't there an installation time delay?

Yes, but since then knip has shaved down its dependency tree.

What about running time?

About 7s - not bad.
We're thinking of just doing it in CI.

@internal Tagging

Basically a way to formally encode what --stripInternal is supposed to do, and say it only applies to JSDoc comments.

Allows you to write // Do not add an @internal tag to the next declaration, since TypeScript will now consider that unrelated.

With --stripInternal, we've always said "it has bugs, ehhh, arguable behavior."
This is a way to make it more formal - or at least more predictable.
Does this add overhead because we'd now start to ask for JSDoc comments in emit.

More "Primitive" Operations in Core Utilities
https://github.com/microsoft/TypeScript/pull/58873

Started out with a trace where the internal some function was just a big hot path.
Lots of operations that implicitly do more work than you might expect - but have decent alternatives.

|| checks for truthiness, but ?? only checks for null/undefined.
Explicit checks for undefined are faster than truthiness.
for-of loops create iterators but for (let i = 0; i < arr.length; i++) doesn't.

PR makes some changes, mostly isolated to core.ts to avoid too much noise.
Unfortunate that there's no free lunch here. The abstraction comes at an explicit cost.

for-of loops create iterators but for (let i = 0; i < arr.length; i++) doesn't.

I'd have expected for (const foo of foos) {} to be highly optimized by engines at this point.  Since the iterator for arrays doesn't actually do anything, I'd be surprised if most engines didn't optimize it away in this case.

I'd have expected for (const foo of foos) {} to be highly optimized by engines at this point. Since the iterator for arrays doesn't actually do anything, I'd be surprised if most engines didn't optimize it away in this case.

Still not really, a for-of-loop is still often many times slower than a for-loop, e.g. this has a difference of 10x in v8 , and 4x in jsc (curiously inlining the forOfLoop function makes v8 have a 4x difference as well):
const arr = Array.from({ length: 10_000_000 }, () => Math.random());

function forLoop() {
    let sum = 0;
    for (let i = 0; i < arr.length; i += 1) {
        sum += arr[i];
    }
}

function forOfLoop() {
    let sum = 0;
    for (const v of arr) {
        sum += v;
    }
}

console.time("for-loop");
for (let i = 0; i < 100; i += 1) {
    forLoop();
}
console.timeEnd("for-loop");

console.time("for-of-loop");
for (let i = 0; i < 100; i += 1) {
    forOfLoop();
}
console.timeEnd("for-of-loop");


smaller header

I already asked this on reddit but no matter what I do I can't get it the way I want it.   Here's a pic of opera vs FF](https://imgur.com/a/NEBvfap)  as you can see the header in FF is much taller almost double the size.
What I want is the urlbar and the tabs right under so all this wasted space disappears.  Not sure if its even possible  Another thing when I minimized my tabs the new tab button disappeared. The button is still there but the plus sign is gone - and the button is only visible when I hover over it.
I've used nighttab for approx 8 months now and I was convinced it couldn't be any better than it was - you proved me wrong. This is truly the icing on the cake

For your new tab issue please take a look at the 5th bullet point in the instructions.
Other than that I can only suggest setting all the urlbar related CSS variables to 0 or as low as you can. That should reduce the height of the header area. Changes beyond that kind of fall outside the scope of what I created this configuration to look like. If the wasted space you are referring to is to the left of the urlbar between it and the back/forward buttons, it is there is because the urlbar has its contents centered and its width forced to a large value so that is in the middle. You can play around with the the selectors related to those properties to achieve the look you want.

the wasted space I'm referring to is that I want the tabs closer to the urlbar - so there's not so much spoace between them.  I feel the header area is very high and thought if I got the tabs closer to the urlbar it woiuld be smaller?    Anyways - big thanks for this.  I thought zombiefox had invented perfection with nighttab but you actually improved it. So thank you

for the plus sign to come back for the new tab - it seems one need to have the tabs a t least at 25 px height. Mine are at 18 atm and the plus sign won't appear.  This is no big issue for me thoug as I use ctrl -t for new tab and ctrl -w for closing tabs-. I use a tiling window manager so I'm, used to keybindings for everything.   If possible I could remove the whole new tab button altogether

I got it to where I'm happy with it now so I'll close this.

@pjhalsli if you're still trying to decrease the height of the header, here are a couple things i did:

decrease --tab-height and --tabs-container-height from 32, 140 to 27, 70, respectively
decrease --urlbar-container-margin to 0
decrease --urlbar-text-size to 12pt
add some css for hiding the bookmarks bar: #PersonalToolbar { display: none !important; }
decrease the .browser-toolbar padding-top to 1

You probably don't need to do all that depending on the look you're going for, but you can play around with those settings

I got mine to look pretty neat actually - but thank you   :-)


Add an "unknown" EC2 flavor, and fall back to it

Hopefully its hardware configuration is so obviously-useless that it can't be mistaken for real data.
Having the VM show up with very bogus data seems better than the alternative -- skipping over it and pretending it doesn't exist at all.
@Fryguy hopefully you have some input on my choices of null-ish data: am I doing anything that's likely to break something (e.g., 0 RAM), or is there anything I can make even more clearly wrong (0 / -1 CPUs, perhaps)?
https://bugzilla.redhat.com/show_bug.cgi?id=1081600

I think this is fine.  The only other thing I can think of is to just put a nil for the keys and then have nil logic in the parser to just not populate those fields / relationships.


Access ODBC queries with [ODBC;...].table references fail under pyodbc but work elsewhere (VBScript, .NET)

The Microsoft Access Database Engine allows us to include tables from an external database by prefixing the table name with the database location. If the database location is an ODBC data source the prefix is of the form
SELECT ... FROM [ODBC;DSN=mydsn].tablename

or
SELECT ... FROM [ODBC;DRIVER=...;SERVER=...;...].tablename

Testing shows that such queries work when called via Access ODBC from VBScript and .NET, but fail when called via Access ODBC using pyodbc.
Working VBScript code:
Option Explicit
Dim conn_str_sql
conn_str_sql = "DRIVER=ODBC Driver 11 for SQL Server;SERVER=<IP_ADDRESS>,52865;DATABASE=master;Trusted_Connection=yes;"
Dim conn_str_accdb
conn_str_accdb = "DRIVER={Microsoft Access Driver (*.mdb, *.accdb)};DBQ=C:\Users\Public\empty.accdb;"
Dim con
Set con = CreateObject("ADODB.Connection")
con.Open conn_str_accdb
Dim rst
Set rst = CreateObject("ADODB.Recordset")
Dim sql
sql = "SELECT COUNT(*) AS n FROM [ODBC;" + conn_str_sql + "].INFORMATION_SCHEMA.TABLES"
WScript.Echo sql
rst.Open sql, con
WScript.Echo rst(0).Value
rst.Close
con.Close

Failing pyodbc code:
import pyodbc
conn_str_sql = r"DRIVER=ODBC Driver 11 for SQL Server;SERVER=<IP_ADDRESS>,52865;DATABASE=master;Trusted_Connection=yes;"
conn_str_accdb = r"DRIVER={Microsoft Access Driver (*.mdb, *.accdb)};DBQ=C:\Users\Public\empty.accdb;"
conn = pyodbc.connect(conn_str_accdb, autocommit=True)
crsr = conn.cursor()
sql = "SELECT COUNT(*) AS n FROM [ODBC;" + conn_str_sql + "].INFORMATION_SCHEMA.TABLES"
print(sql)
crsr.execute(sql)
print(crsr.fetchval())
crsr.close()
conn.close()

The complete ODBC traces are attached. The difference in behaviour appears to be that shortly after SQLExecDirectW is called (line 640 in the vbs trace, line 192 in the Python trace) a call is made to SQLDriverConnectW which is failing under pyodbc.
That call returns SQL_SUCCESS_WITH_INFO for vbs, as shown by the following excerpt starting at line 681 of the vbs trace ...
cscript  odbc_d 15f8-9a8    ENTER SQLDriverConnectW
        HDBC                0035C6C0
        HWND                00000000
        WCHAR *             0x6E23B274 [      -3] <Invalid string length!>
        SWORD                       -3
        WCHAR *             0x6E23B274
        SWORD                       -3
        SWORD *             0x00000000
        UWORD                        1 <SQL_DRIVER_COMPLETE>

cscript  odbc_d 15f8-9a8    EXIT  SQLDriverConnectW  with return code 1 (SQL_SUCCESS_WITH_INFO)
        HDBC                0035C6C0
        HWND                00000000
        WCHAR *             0x6E23B274 [      -3] <Invalid string length!>
        SWORD                       -3
        WCHAR *             0x6E23B274
        SWORD                       -3
        SWORD *             0x00000000
        UWORD                        1 <SQL_DRIVER_COMPLETE>

        DIAG [IM006] [Microsoft][ODBC Driver Manager] Driver's SQLSetConnectAttr failed (0)

... while the corresponding call from Python returns SQL_ERROR, as we see starting at line 233 of the Python trace:
pythonw.exe -c  1318-1600   ENTER SQLDriverConnectW
        HDBC                00149388
        HWND                00000000
        WCHAR *             0x6E23B274 [      -3] <Invalid string length!>
        SWORD                       -3
        WCHAR *             0x6E23B274
        SWORD                       -3
        SWORD *             0x00000000
        UWORD                        1 <SQL_DRIVER_COMPLETE>

pythonw.exe -c  1318-1600   EXIT  SQLDriverConnectW  with return code -1 (SQL_ERROR)
        HDBC                00149388
        HWND                00000000
        WCHAR *             0x6E23B274 [      -3] <Invalid string length!>
        SWORD                       -3
        WCHAR *             0x6E23B274
        SWORD                       -3
        SWORD *             0x00000000
        UWORD                        1 <SQL_DRIVER_COMPLETE>

        DIAG [S1110] [Microsoft][ODBC Driver Manager] Only SQL_DRIVER_NOPROMPT is allowed when connection pooling is enabled (0)

odbc_trace_vbs_success.txt
odbc_trace_py_error.txt

I just fixed a bug in which could explain the SQLExecDirectW.  Can you retest with 4.0.6?

No change with 4.0.6. ODBC trace was the same, right down to the line numbers.

Additional data point: I knew that the default settings for ODBC Connection Pooling were "off" for the Access ODBC drivers and "on" for the SQL Server ODBC drivers. I switched off connection pooling for "ODBC Driver 11 for SQL Server" in the ODBC Administrator (odbcad32.exe), rebooted the machine, and re-ran the test. The results were the same: the SQLDriverConnectW call still fails with "Only SQL_DRIVER_NOPROMPT is allowed when connection pooling is enabled".

Solution: The issue can be avoided by adding
pyodbc.pooling = False

before calling pyodbc.connect.


fix: concurrency warnings pre swift 6 support

What kind of change does this PR introduce?
This is part of the Swift 6 mode support, some concurrency warnings will become errors when Swift 6 is enabled.
This PR fixes a couple of concurrency warnings, by not using the ISO8601DateFormatter, which isn't Sendable in favor of the DateFormatter, which is Sendable and is already being used on some places

I tried the new version, but this change seems to have broken the API completely.
SELECT and INSERT don't work anymore. For example, I get this error :
Swift.DecodingError.dataCorrupted(Swift.DecodingError.Context(codingPath: [_JSONKey(stringValue: "Index 0", intValue: 0), CodingKeys(stringValue: "created_at", intValue: nil)], debugDescription: "Invalid date format: 2024-06-15T18:12:04+00:00", underlyingError: nil))
Although the date string in the error output seems to be OK.
I'm using Xcode 15.4, with Swift 5.


Ripple effect on button needed

Ripple effect option on button needed  for best UX!

Hey,
I am skeptical about that. I am not sure if the ripple should cover the whole component or just the button.

Ripple won't be an eye candy since the button has 2 independent clickable areas

left to right or right to left ripple will work!


[v3] Configure online editor

This issue is part of the migration to v3. You can read full details about the various changes here.
In Exercism v3, students can now choose to work on exercises directly from their browser, instead of having to download exercises to their local machine. The track-specific settings for the in-browser editor are defined in the top-level "online_editor" field in the track's config.json file. This field is defined as an object with two fields:

"indent_style": the indent style, either "space" or "tab".
"indent_size": the indent size, which is an integer (e.g. 4).

You can find a full description of these fields in the spec.
Goal
The "online_editor" field should be updated to correspond to the track's best practices regarding indentation.
Example
"online_editor": {
  "indent_style": "space",
  "indent_size": 4
}

Tracking
https://github.com/exercism/v3-launch/issues/2

I'm happy to stick with 4 spaces for now. I'm not sure if Raku has a generally accepted style, but I imagine it would inherit a similar style to Perl.


visual studio and docker-compose not working

I already created the following ticket: https://github.com/microsoft/ApplicationInsights-Profiler-AspNetCore/issues/189 but have been advised to raise it here instead:
I created a brand new .net 6 web app and selected enable docker support, I then copied in the latest app insights and configured.
<Project Sdk="Microsoft.NET.Sdk.Web">

	<PropertyGroup>
		<TargetFramework>net6.0</TargetFramework>
		<Nullable>enable</Nullable>
		<ImplicitUsings>enable</ImplicitUsings>
		<UserSecretsId>98a17432-a18a-471c-b956-6cd9f60a0ca3</UserSecretsId>
		<DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
		<DockerComposeProjectPath>..\docker-compose.dcproj</DockerComposeProjectPath>
	</PropertyGroup>

	<ItemGroup>
		<PackageReference Include="Microsoft.ApplicationInsights.Profiler.AspNetCore" Version="2.5.0" />
		<PackageReference Include="Microsoft.VisualStudio.Azure.Containers.Tools.Targets" Version="1.17.0" />
	</ItemGroup>

</Project>

var builder = WebApplication.CreateBuilder(args);

// Add services to the container.
builder.Services.AddApplicationInsightsTelemetry();
builder.Services.AddRazorPages();

var app = builder.Build();

// Configure the HTTP request pipeline.
if (!app.Environment.IsDevelopment())
{
    app.UseExceptionHandler("/Error");
    // The default HSTS value is 30 days. You may want to change this for production scenarios, see https://aka.ms/aspnetcore-hsts.
    app.UseHsts();
}

app.UseHttpsRedirection();
app.UseStaticFiles();

app.UseRouting();

app.UseAuthorization();

app.MapRazorPages();

app.Run();

and (appsettings.development.json):
{
  "DetailedErrors": true,
  "Logging": {
    "LogLevel": {
      "Default": "Information"
    }
  },
  "ApplicationInsights": {
    "InstrumentationKey": "<guid>"
  }
}

I then ran using "docker" - not docker compose
The AI telemetry appeared straight away. All was well.
I then used the instructions at https://learn.microsoft.com/en-us/visualstudio/containers/tutorial-multicontainer?view=vs-2022 to ad the docker-compose project.
I then started using "docker-compose". Now the application insights are no longer collected by visual studio.

Hi @TimothyMothra I have been advised to tag you in this issue

Not sure how we can help... Have you ensured that the appsettings is correctly copied when running in docker? Or try hardcoding instrumentation key in code itself.

I was under the impression that you didn't need a instrumentation key to see the results in visual studio.
This isn't about the logging appearing in Application Insights in the portal, this is about developer mode and seeing the values in visual studio.
Either way, the value is in app settings correctly.
As I said, all I chose to do is change the setting from docker, to docker-compose and the values do not show in visual studio.
Hard coding the values is not a great idea anyways, as this is production code for a real application with many moving parts, and the chances of one of the devs accidentally saving a change like that would be high.

I was able to repoduce this. Thanks for the feedback and creating the developer community issue @AnthonyDewhirst.  I added a bug to our internal backlog to look into why this isn't working with Compose projects.

This is now resolved internally.  It should make its way out in the next 17.6 Preview release

Great.
Does that mean it will also be in 17.5.2?
On Fri, 3 Mar 2023, 00:54 Devin Breshears, @.***> wrote:

This is now resolved internally. It should make its way out in the next
17.6 Preview release
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/ApplicationInsights-dotnet/issues/2731#issuecomment-1452780926,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAE44CJY24O2ISVNKOO3RQDW2E6LRANCNFSM6AAAAAATWOTTJQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

No, unfortunately 17.5.2 is already locked down.   With that said I am not sure this would meet the 17.5 servicing bar.


few questions about current code

Hello, could you answer these questions:

Why there are no separate val/train transformers? For example, does ImageNet need to replace random transforms with these: transforms.Resize(256), transforms.CenterCrop(224)?
What's the VAE architecture for ImageNet with 224x224 inputs? Currently, only 32x32 is given
Do you plan to release code for segmentation task?

Yes you are correct about the transformers.
We are trying to release the code for the segmentation task, as well as the VAE architectures, and checking the old code to ensure they are consistent with the experiments ran. For ImageNet the inputs were resized to 32x32 for the VAE model.

[Regarding Imagenet] Hi, can you explain the reason for using global imagenet statistics (mean and stdev) in imagenet transforms [here]? I am confused because in your experiments you start training with only 10% of data, therefore why are we standardizing our 10% data with global statistics ? -- Shouldn't we calculate the mean and stddev separately for this 10% data ?


Total Number of Parameters

Feature request: Ability to see number of parameters for entire model in a model overview.

Duplicate of #204


fix a typo in readme of project3

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove incorrect warning from lib

Issue
Incorrect warning is issued in the logs on machine charms warning about containers. I think the warning was designed for Kubernetes charms, but the symptom it warns about is mostly mitigated by the inclusion of pebble_ready as the default refresh event.
Solution
Remove the log entry!

This was actually added to check for podspec charms, too, rather than defaulting to pebble_ready.
Now that it's being used on machine charms (👍 by the way!), the "goal" of the refresh_event argument is, basically, "if the charm which instantiated this library is restarted/rescheduled/has an IP change, please update the endpoint". The goals there should probably be updated, or we can pass refresh_event:
        if not refresh_event:
            if len(self._charm.meta.containers) == 1:
                if "kubernetes" in self._charm.meta.series:
                    # This is a podspec charm
                    refresh_event = [self._charm.on.update_status]
                else:
                    # This is a sidecar/pebble charm

We weren't really able to find anything better than update_status for podspec charms, but if there's a reasonable pattern for machine charms ( on.start, on.install, etc), it would be better to add that.
Really, prometheus_scrape is the first one of the libraries doing this, since scraping is a pretty general target, but it's a pattern, even a small one, which we should probably extract out so it can be reused by other observability (and potentially other) libraries as a generalized "my IP address may have changed, go update peer data/relation data/etc to for gossip/cluster/scrape"


Metadata in v1.2.0 for old API (2015-12-19) has "-" separators instead of "_"...breaks old metadata searchs

Rancher Version:
v1.2.0
Docker Version:
v1.2.3
OS and where are the hosts located? (cloud, bare metal, etc):
Mac (local dev); Servers with RedHat 7.2
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Rancher single instance (local); Rancher HA (cloud)
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
curl http://rancher-metadata.rancher.internal/2015-12-19/containers
3=minerva-prod_equipment-query_1
Results:
On Rancher v.1.1.0, it returns: 3=minerva-prod_equipment-query_1
On Rancher v1.2.0, it returns 3=minerva-prod-equipment-query-1
Expected:
3=minerva-prod_equipment-query_1

We had to move to using - instead of _ due to Docker changes that caused Rancher to no longer work with the names with _.
Here are some of the old issues about it:
https://github.com/rancher/rancher/issues/5195
https://github.com/docker/docker/pull/23740

@deniseschannon is there a way to determine what version of Rancher is running from Metadata service?

@dsvmacdonald I don't believe there is a way to determine the Rancher version from the metadata service. I'm not sure how you're tooling is setup, but would you be able to access the Rancher API to figure it out from the API?

I'm accessing the metadata service within my container in the entrypoint.sh script.  I really don't want to add rancher access keys to container to query api from container.  I have requested a feature enhancement to add this data to the metadata service.

There is a label you can set which will cause you to be provided with the API URL and a set of keys to access it from the container of you want to talk to the API, they don't have to be manually maintained.
But as I said in #6984 you can probably use labels, create_index, or uuids to accomplish what you're trying to do without assuming a particular name for the container.


Forcefully unlock files locked by other processes

Other processes are locking haloce.exe to write to it, which prevents us from writing our binary patches.
Propositions
A. Write to copy of haloce.exe, leaving the locked file as-is (mostly)

Rename the directory entry of the file to haloce.exe.0.bak. This won't touch the file itself. Instead, we change filesystem information about the file. Confusing, I know. System.IO.FileInfo?
Copy "haloce.exe.0.bak" to "haloce.exe" as new file in the same directory.
Resume normal "haloce.exe" activities.
B. Close file handles with filename 'haloce.exe'
Use SysInternal's Handle app/lib to get a list of processes' File handles of filename "haloce.exe". See Handles feature of ProcessHacker 3.
Close each handle. Suitable API in System.Management

Examples

IObit Unlocker
Process Hacker
SysInternals Handles, Handles64, ProcessExplorer

Biiig dumpy
Use System.IO.File.Open() to check if file is locked (share: none)
https://www.cloudsavvyit.com/2956/how-to-manage-open-file-handles-with-powershell#testing-for-locked-files
https://www.cloudsavvyit.com/2956/how-to-manage-open-file-handles-with-powershell#openfiles-utility
https://www.cloudsavvyit.com/2956/how-to-manage-open-file-handles-with-powershell#the-handle-application
https://www.majorgeeks.com/files/details/unlocker.html
https://docs.microsoft.com/en-us/sysinternals/downloads/handle
https://lockhunter.com/download.htm
https://docs.microsoft.com/en-us/dotnet/api/system.io.filestream.unlock?view=net-5.0
https://docs.microsoft.com/en-us/dotnet/api/system.io.filestream.handle?view=net-5.0
https://docs.microsoft.com/en-us/dotnet/api/system.io.file.openhandle?view=net-6.0
https://docs.microsoft.com/en-us/dotnet/api/system.io.fileinfo?view=net-5.0
https://docs.microsoft.com/en-us/dotnet/api/system.io.fileshare?view=net-5.0
https://docs.microsoft.com/en-us/dotnet/api/system.io.file?view=net-5.0
https://docs.microsoft.com/en-us/windows/win32/api/winternl/nf-winternl-ntquerysysteminformation
~~https://docs.microsoft.com/en-us/dotnet/api/microsoft.visualbasic.filesystem.unlock?view=net-5.0~~
~~https://devblogs.microsoft.com/dotnet/file-io-improvements-in-dotnet-6~~
~~https://stackoverflow.com/questions/2225733/how-to-forcefully-unlock-a-file-in-c~~
~~https://stackoverflow.com/questions/47977927/error-the-process-cannot-access-the-file-because-it-is-being-used-by-another-pro~~
~~https://dotnet-assembly.blogspot.com/2012/10/c-check-file-is-being-used-by-another.html~~
~~https://www.codeproject.com/questions/141068/file-is-being-used-by-another-process~~

https://www.nirsoft.net/utils/opened_files_view.html
We could just add this as an embedded resource to be extracted and run and a command line util when needed.

Scratch that NirSoft suggestion. Use Microsoft SysInternals' Handles/Handles64.

OpenedFilesView does not have an EV-signed driver. It will not work under Secure Boot.
Handles is better >:)


fix(dependency): Mongoose 4.4.7 bug

Fixes an issue with Mongoose 4.4.7 that causes the database connection.db property to be  undefined. This issue is causing our builds to fail.
Sets the Mongoose version to ~4.4.3 <4.4.7 for now until we investigate further. This should solve the issue of our failing builds, when the dropdb Grunt/Gulp task is ran with the E2E tests.
For more context:
this line https://github.com/meanjs/mean/blob/master/gruntfile.js#L277 was throwing an exception during our builds, since the dropdb task is run with the E2E tests. This seemed to cause the Protractor tasks to time-out. However, there was no indication of this exception being thrown from our dropdb task when running with grunt test or in the Travis builds. I had to explicitly run grunt test:e2e to see this exception that led me to this fix.

Merging this since it's a small change, and we need to have our builds passing. It's disruptive to all the contributors that the builds aren't passing.
@meanjs/contributors

@mleanos
Ok but let's keep investigating what's the issue here.


Requesting just a title without an artist causes a crash

It also doesn't appear to be getting tracked correctly.

rc8


Destroying a group with a sprite containing an animation on the onComplete signal causes a JS error.

Example code:
this.enemy_sprite = this.group.create(x, y, 'zombie');
this.enemy_sprite.scale.set(1);
this.enemy_sprite.scale.x = -1;
this.enemy_sprite.smoothed = false;
this.enemy_sprite.anchor.set(0.5, 0.5);

this.walk_anim = this.enemy_sprite.animations.add('walk');
this.walk_anim.onComplete.add(this.destroy, this);
this.walk_anim.play(10, false);

this.destroy = function() {
    this.group.destroy(true);
}

causes a JS error:
Uncaught TypeError: Cannot read property 'getFrame' of null phaser.js:53464
Phaser.Animation.update phaser.js:53464
Phaser.AnimationManager.update phaser.js:52802
Phaser.Sprite.preUpdate phaser.js:37442
Phaser.Group.preUpdate phaser.js:21860
Phaser.Group.preUpdate phaser.js:21860
Phaser.Stage.preUpdate phaser.js:20367
Phaser.Game.updateLogic phaser.js:26737
Phaser.Game.update phaser.js:26684
Phaser.RequestAnimationFrame.updateRAF phaser.js:46614
Phaser.RequestAnimationFrame.start._onLoop phaser.js:46598

Note: delaying the "group destroy" by using setTimeout seems to fix it, but it's not a proper solution...
My guess is that the animation keeps running for a couple more frames even when the onComplete signal was sent?
Using Phaser 2.2.2

It doesn't keep running. The problem is group.destroy triggers a destroy of the animation from within the update - but later on, in the same update, the (now invalid) _frameData.getFrame is called.

There is a patch for the issue.
In the meantime the best work-about is probably to keep using setInterval(.., 0).

Fix merged in dev.

Downloaded Tarabon yesterday, the bug still occurs. But setTimeout seems to work just fine.

@trueicecold Make sure to build locally (and not just a build pulled from git) when testing these 'latest and greatest' in dev.
If you can still reproduce it on dev, please create a minimal test case and I'll take look at it. There are several different scenarios to guard and it is very possible that one is missed. In my local tests I was able to destroy the sprite/animation/group from within the onXYZ events of the animation.

Bug still active
Uncaught TypeError: Cannot read property 'preUpdate' of undefinedc.Group.preUpdate @ phaser.js:21393c.Stage.preUpdate @ phaser.js:19862c.Game.updateLogic @ phaser.js:26381c.Game.update @ phaser.js:26327c.RequestAnimationFrame.updateRAF @ phaser.js:44881c.RequestAnimationFrame.start.window.requestAnimationFrame.forceSetTimeOut._onLoop @ phaser.js:44865


Use local storage instead of cookie

Some folks are concerned about security of cookies to implement sign in. We used cookie to pass access token to web client app. Server does not analyze or trust this cookie. Javascript application should extract token from cookie and put it into authorization header to request server. Cookie used only as convenient storage to cache access token on client side. Though, we marked cookie as "secure", it only means, that browsers will not send it over http (only via https) - RFC6265. With same-origin policy, browser should not send cookie to another domains. Though, even in the RFC it noted as unreliable. That is, there are may be cases, when browser leaks our access token to non-trusted parts.
So, we should change our implementation. We should put access token into header of the first response, not in cookie, so that it would not be stored by browser automatically. Javascript application should move it from header to local storage (or store only in memory - in the global variable, for example).
It's desirable to keep user signed in and multi-tab support. Currently, it achieved by cookie storage and both cookie and token expiration time. Cookie is visible in different tabs and preserved while not expired.
We may need use a local storage to achieve this without cookie. See https://blog.guya.net/2015/06/12/sharing-sessionstorage-between-tabs-for-secure-multi-tab-authentication/, for example.
Related: revoke access tokens on server at logout.

Marked it as a bug, because it badly affects security.

BTW, in LR we used local storage to store token. May reuse that code.

We do not have such strict security requirements in LR. I think, as a first step, we won't implement in-memory storage with broadcast channel and polyfill (https://developer.mozilla.org/en-US/docs/Web/API/BroadcastChannel, https://gist.github.com/alexis89x/041a8e20a9193f3c47fb). We also won't sync tabs with local storage's events.
As a first steps we should implement:

url parameter in callback handler;
pass token in header, not in cookie;
store token into local storage;
access token revocation on logout, remove it from local storage;
with "stay logged in" flag we should issue token with longer expiration period than without it;
without "stay logged in" flag we should try to perform logout when last tab of the app is being closed, if possible;

Related #13.

Moved url param for redirect into new #15.

Unfortunately, javascript cannot read headers of the current document, headers are only available in ajax request. So, best we can do is to immediately remove cookie and store token in the local storage, so that browser would not put this cookie into subsequent requests. Nothing the server can help here.


[Event Request] Database::"Whse. Worksheet Line" - Function MovementCreate - OnBeforeMovementCreate

We like to request the following Event:
Object: Database::"Whse. Worksheet Line"
Function: MovementCreate
Publisher Event: OnBeforeMovementCreate
Reason: To implement custom business logic
Where is the event placed:
procedure MovementCreate(var WhseWkshLine: Record "Whse. Worksheet Line")
var
CreateMovFromWhseSource: Report "Whse.-Source - Create Document";
IsHandled: Boolean;
begin
IsHandled := false;
OnBeforeMovementCreate(WhseWkshLine, IsHandled);
if IsHandled then
exit;
CreateMovFromWhseSource.SetWhseWkshLine(WhseWkshLine);
CreateMovFromWhseSource.RunModal;
CreateMovFromWhseSource.GetResultMessage(3);
Clear(CreateMovFromWhseSource);
end;
Event Code:
[IntegrationEvent(false, false)]
local procedure OnBeforeMovementCreate(var WhseWkshLine: Record "Whse. Worksheet Line"; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Update Besu dependencies

PR Description
Besu upgraded from 0.9.0 version few months back - https://github.com/hyperledger/besu/pull/6422 so can upgrade our version as well.
Leaving as draft because of following Besu changelog in release https://github.com/hyperledger/besu/releases/tag/24.3.0:

Following the OpenMetrics convention, the updated Prometheus client adds the _total suffix to every metrics of type counter, with the effect that some existing metrics have been renamed to have this suffix. If you are using the official Besu Grafana dashboard (available here), just update it to the latest revision, that accepts the old and the new name of the affected metrics. If you have a custom dashboard or use the metrics in other ways, then you need to manually update it to support the new naming.

Fixed Issue(s)
Fixes #8327
Documentation

[X] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[X] I thought about adding a changelog entry, and added one if I deemed necessary.

I've fixed the tests and am comparing to the current stable version to check which metrics we should adjust in the dashboard. Please don't merge this until further notice.

This is now ready for merge.

I've cleared the change logs and have added an entry for breaking changes. The announcements were for the previous release.


Prefix block-progression on NZ and BO flags

What
Prefix block-progression to -ms-block-progression.
Why
I don't know much about this property but seems to be deprecated or only used on old IE version. (source, source). I'm using the SVGs inside React + Typescript and I get a type error because block-progression needs to be prefixed by -ms-block-progression.
I don't even know if we need to keep it, maybe we can remove?

You might want to switch to writing-mode instead since that seems to be the official standard.
At the same time, w3schools suggests writing-mode is defaulted to horizontal-tb which is the setting we use. You should be able to fully remove this as it matches the default.

You might want to switch to writing-mode instead since that seems to be the official standard.
At the same time, w3schools suggests writing-mode is defaulted to horizontal-tb which is the setting we use. You should be able to fully remove this as it matches the default.

I will remove the values then.

I will remove the values then.

@lipis Was wondering if there's any feedback for this and my other PR?

@lipis Was wondering if there's any feedback for this and my other PR?

Sounds good!


need to add recursive searching of directories with -r tag

rust has good documentation on this topic, and I already have experience with doing this in rust

Recursive now works, but the files found are not sorted. This is issue #16. Closing.


enhanced Date Time component

Proposed Changes

Closes #8994

[x] Change 1: The text area and selection component for date and time should align with the user’s system time preference.

[x] Change 2: Users should be allowed to enter "01" in the minutes part of the component. Similarly, this behavior should be allowed for all other date and hour parts as well

this error was causing because when we finished writing minutes, cursor was pointing back to minutes. I made changes such that after typing minutes, cursor loops back to day, making it easier to change date completely if needed without changing cursor position with mouse.

@ohcnetwork/care-fe-code-reviewers
Merge Checklist

[ ] Add specs that demonstrate bug / test a new feature.
[ ] Update product documentation.
[ ] Ensure that UI text is kept in I18n files.
[ ] Prep screenshot or demo video for changelog entry, and attach it to issue.
[ ] Request for Peer Reviews
[ ] Completion of QA

Summary by CodeRabbit

New Features

Enhanced hour input functionality now supports a 12-hour format.
Improved navigation logic between input fields for a smoother user experience.
Streamlined input change handling for easier transitions between fields.

Bug Fixes

Resolved issues with input navigation that previously restricted field transitions based on index.

@ohcnetwork/care-fe-code-reviewers
I had made commit with time taking hour as 12 for 12 am or pm, it failed 1 test, but when i reverted it back to 00 it passed all the test cases.
I tried to run cypress tests locally, but, in all tests, page was loading till timeout
Please guide me on how to proceed further

[ ] user system preference is still not taken account by the component, its one of the issue pointers look into it
[ ] check the code rabbit flagged issues
[ ] look into the cypress failure in your PR

@nihal467 @rithviknishad please review this

so happy by your support to new contributor's. thank you


Fix warnings

Fixing some random warnings and deprecations:
warning: variable "post" is unused
  lib/tilex/slack.ex:7

warning: clauses for the same def should be grouped together, def notify/2 was previously defined (lib/tilex/integrations.ex:5)
  lib/tilex/integrations.ex:27

warning: unexpected beginning of EEx tag "<%=" on end of expression "<%= end %>", please remove "=" accordingly
  lib/tilex/web/templates/shared/post.html.eex:19

warning: function Tilex.Router.Helpers.post_url/3 is undefined (module Tilex.Router.Helpers is not available)
  lib/tilex/integrations.ex:21

19:29:45.050 [warn] Warning: No valid AppSignal configuration found, continuing with AppSignal metrics disabled.
warning: unused alias Endpoint
  test/features/developer_creates_post_test.exs:12

Awesome! 👍


🐛 BUG: Rename symbol doesn't work inside <script> tags,

Describe the Bug
If I try to do rename symbol inside a

I don't think it is quite like #496 , but maybe we should re-open that one instead

It could be! Go to symbol also doesn't work on my environment, I was just trying to fix this one issue at a time.
Do we know if this ever worked? To try to change extension versions.

I think it's a recent regression, I wouldn't suggest going back in version that much like the issue you linked suggested. I think both issues will be fixed once I merge in https://github.com/withastro/language-tools/pull/879, which I'll be doing once I get back from holidays next week


Unpinned JDK version in CircleCI settings.

It seems that Debian based distributions have moved to 8u191 and
replaced the one off 8u181b13 (current release for Ubuntu 18 is
8u191b12).
Problem:
Due to a strange one-off build of Java (8u181b13), a number of things broke within Maven builds (surefire, Jetty, etc...). With the release of an official OpenJDK build to Debian, CircleCI should in theory work without pinning the version to the older, 8u171.
I have tested building DropWizard under 8u191 and it builds without issue.
Solution:
Removed the pinned version.
Result:
The build should succeed.

NOTE: CircleCI does not have the newest Java available yet.


Global constant namespace

This closes #185.
As discussed in #185, I used namedtuple for the namespace.
Moreover, to make it constant, or immutable, I converted all the lists and dicts to tuples and MappingPrxoyTypes, respectively.
Since they become immutable, I decided to share a single namedtuple object across all the apps, by assigning it as an internal (protected) class attribute _constants.
For the access, BaseApp now provides a read-only property constants.
Since the global constant namespace is independent to Qiwis object, the setter function set_global_constant_namespace() is defined in module-level.
For the naming convention of namedtuples, I mimicked the Python built-in type name styles, e.g., contextmanager, unittest, namedtuple, defaultdict, etc.
Now the setup.json can contain "constant" section as well.

It seems the GitHub action cannot install the dependencies well. I tried several times to pass.


Whisper added

Enter <c-u> to enter transcription mode. Feels kind of cool actually. It's sort of far from being mergeable though:

[x] pyaudio is sort of a heavy dependency to add as it requires platform specific dependencies. I don't want to require users to run brew install portaudio before running pip install mentat. One option could be making it an optional dependency using extras_require and try/catching the pyaudio import.
~* [ ] Cost tracking for whisper~ No longer using api
[x] The feel of the transcription. It could be a lot snappier. I think it's better to transcribe with the already transcribed portion passed in so it doesn't bounce around as it is re-transcribed slightly differently. Also keeps costs down. See point 2 here
[x] Should probably separate the audio logic and the whisper logic. Someone suggested they wanted this feature accessible from the python_client as well but I'm not sure exactly how that should work or what it would be useful for.
[x] tests

any idea why I'm getting this?

any idea why I'm getting this?

Oh, input_device_index=3 probably shouldn't be hardcoded. I'll look into having it detect the system default.

Error I get when trying pip install -e . on macos:

Fixed by installing portaudio with brew
https://stackoverflow.com/a/33821084

On another note its pretty cool to be talking to my terminal haha

@waydegg I've found them pretty accurate. I have a high quality mic though and I'm trying to talk clearly. I think ideally we'd run the medium or large model but with my amd graphics card I've had trouble getting the model to actually run on the GPU so only the tiny model feels responsive enough. Model size could definitely be in the config (though that leads to another problem that the /config command can't easily change client side settings). We could also support the openai api as well which serves the large model. I've found it less well documented than the python libraries though. And it costs money.
And yeah I'm aware of the hoops. There's a different hoop for every os. I was thinking we could have pyaudio as an optional requirement. GPT tells me we can put this in setup:
extras_require={
      'voice':  ['pyaudio'],
 }

And then users can install voice pip install .[voice]. Of course for the actual brew package we could simply include portaudio.
I'm going to look into using sounddevice first though. I think it might be a better library than pyaudio in a few ways and there documentation suggests you don't need anything special to install it. Can you confirm pip install sounddevice works on macos without extras?
Another question I had for you: pyright is complaing faster_whisper has no stub files.
One final question: Can you replace tiny with Large-v2 and report the performance on your m3? I'm curious.

Yeah it might just be my mic (using the built-in mic). If I raise my voice the transcriptions get better lol.

Another question I had for you: pyright is complaing faster_whisper has no stub files.

Yup!

And then users can install voice pip install .[voice]. Of course for the actual brew package we could simply include portaudio.

Nice.

Can you confirm pip install sounddevice works on macos without extras?

I can install it without any extras (uninstalled portaudio before installing sounddevice and it worked). Haven't tried actually using sounddevice and running it tho

One final question: Can you replace tiny with Large-v2 and report the performance on your m3? I'm curious.

Yup will try now

So I can run the Large-V3 model, but when we get the results in mentat I'm only getting the first few words of whatever it is I'm saying

Huh, that's weird. Maybe it's the model being slow? If you wait a bit you don't get more of the transcript?

If I wait for the model to process each word and then I say the next one it works haha

Alright, in my opinion this is ready for review now. The following things would be nice to have but I don't think necessary for merge or the most valuable thing to work on. I'll make an issue for what we merge without:

[ ] Stop word for whisper. E.g. if the user says "end/stop/period" then whisper ends itself. Ideally user configurable.
[ ] User configurable model selection
[ ] User ability to choose openai api instead of local model
[ ] Post transcription send to gpt for edits. Can get fancy here and try to put give helping context. Like if the user says "pyaudio" whisper will probably guess "pie audio" but if we put an included file in context then gpt may be able to edit it to pyaudio. Just putting all the unique tokens represented in the code context might help a lot and not cost a ton? The user should be able to turn this feature off because it will add cost and latency.
[ ] I think the current "frozen_timestamp" algorithm works well enough and is pretty simple. But there are a lot of things to try around detecting silence and splitting there and adding the previous transcript as prompt.

I'm getting pretty poor transcriptions on the default tiny model (On M2 macbook air) Trying base now and it's still pretty bad, it seems to be overwriting transcriptions? I'm not sure but there may be a bug.
Feels like this will be a really nice feature to have!
Could we display the audio device being used?

After discussion yesterday I decided to make two major changes:

We now use the API to transcribe. This turns out to be so fast there's no reason to make sequential calls and pre transcribe the conversation as the user is talking.
We transcribe on the server side accessible through the /talk command
Also recordings are now logged to ~/.mentat/logs/audio which should hopefully make debugging easier. Luckily the net effect is that the PR is a lot simpler. I feel like I should write some kind of test before merging but I'm not exactly sure what I want to test because it's basically just a wiring up of sounddevice/soundfile to the openai api.

Just tested it out for the first time and holy cow it's really good and cool! I know this had already taken a while to merge in, but I had one more idea; would it be difficult to stream openai's output? I think it could be pretty quick to add and would really level up the experience for me.


chore: add volunteer Schleidens

Thank you for volunttering @Schleidens. Added some comments.

Thank you for volunttering @Schleidens. Added some comments.

I'll clean it, thx for your review.

Thanks for making quick changes!


Initial German support

Adding preliminary support for German (and potentially other Western European languages).
Supported: reference_based, source_based, reference_free.
Missing only the factual_consistency notebooks, since I will need to find good data for that.

Awesome work @ischender! When this is ready for review later, let me know and I'll assign a reviewer.

@yosukehigashi I am supposed to assign this to you, but I don't seem to be able to...

Assigned to Yosuke! (Sorry, I assumed Alex would be able to set the reviewer)

Thanks for the massive contribution @ischender! I'll review this ASAP

Thanks for the great work!! Just a few minor comments, but overall looks great!

thank you, I will be on the suggestions as of next week

@yosukehigashi I should have implemented all the suggestions/changes, unless something managed to slip by (sorry if to).
Can you have a look when you can?

@yosukehigashi I should have implemented all the suggestions/changes, unless something managed to slip by (sorry if to). Can you have a look when you can?

Thanks for the updates! I'll take a look later today

@yosukehigashi , I tried a quick and dirty implementation using "EIStakovskii/bert-base-german-cased_fluency" in a version of langcheck.metrics.de._fluency_local and ran a quick test...
It seems pretty bad.

While with the the translation we get what we expect:

Please note that the first 2 sentences are pretty much as bad in German as in English...

]

As you can see, they get mostly the same value:

(interestingly, the translation was done with different engines)
Parrot, that has SOME multilingual properties since it's based on T5 (not mT5 though) does worse than translation (the reason I switched to translations) but better than the bert-based model

Thoughts?

Looks like all comments have been resolved so I'll merge this now. Thanks @ischender!🇩🇪


unLoadPanels function is not working

I implemented the animations drag and droping them to HTML elements, each time i added an animation i have to clean the array of elements so the new animation could be applied. I made some changes to that function, i don´t really know  the purpose of this function but it worked for me.
unLoadPanels : function() {
    var objectInstance = this;
    for (var index = 0; index < this.containerPanels.length; ++index) {
        jQuery(this.containerPanels[index]).unbind(objectInstance.namespace);
    }
    this.containerPanels = [];
}

It's somekind of a reset feature, it works both days for me, not sure what happened, but I'm glad you figured it out.

No problem, good job. Tnx.


Improve API for cyclical element-effect references

For example, say you had a page with two buttons, each one when clicked should disable the other button.
In other web frontend UI frameworks, you would do something to this effect
let b1 = element_ref();
let b2 = element_ref();

let e1 = |_| b2.disable();
let e2 = |_| b1.disable();

<button ref=b1 onclick=e1>Click me!</button>
<button ref=b2 onclick=e2>Xor me!</button>

This pattern is not currently possible in leptos, as instead of creating a reference with interior mutability that can be set and then used later in the lifecycle of a component, the _ref property simply assigns to an uninitialised variable a reference to the element. This is fine, as long as you do not need this kind of cyclical construction.

See #120
The NodeRef type is backed by an untracked signal internally, which makes it Copy. Thanks for talking through the API with me! I think this should be pretty good.


Allow content to be defined with datapacks / resources packs

Datapacks and resources packs (refereed to as packs) can allow custom content to be added to the game without making a mod. If Roadworks supported packs then creators will be able to define custom signs, markings, etc (refereed to as road objects) .
This will mean people can create "content packs" which may include road objects, etc from other countries (for example "European-style signage").
As of 1.21 Minecraft allows custom music and paintings to be made with packs, also, other mods like Patbox's Brewery or Minecraft Transit Railway support custom content with packs too.
It would be nice if Roadworks had support for packs as it would:

increase maintainability of the mod (since you no longer need to manually modify the registry for every road object)
allow people to create road objects

This would require a big refactor to achieve however it will greatly improve the options which this mod can have.

Added in https://github.com/znepb/roadworks/commit/cd0ad1c07f1526378dceed83882f9fd12213d0db


Add Windows Terminal configuration

Windows Terminal is a really powerful tool that I have been using pretty much daily in different computers (work/home), so I thought it would be a good idea if I could share my own configuration amongst these computers.
Steps

[ ] Add new Windows Terminal *.yaml file for Windows only.
[ ]  Add new step (Windows only) to install the specified *.yaml file.
[ ]  Add symlinks for the configuration files used by Windows Terminal.

Found one issue during the development of this feature: As many other Microsoft applications, the configuration for Windows Terminal is not really a dotfile, the configuration is stored directly into some hidden folders within APPDATA and also in the original folder where the application is installed.


Lock dependencies via pip-compile

Pip can lock dependencies to a specific version with a specific hash. This ensures that the dev environment remains deterministic.
More Info
Example from Specter Wallet

Possibly implement this via pipenv:
https://pipenv.pypa.io/en/latest/


Re-using existing ALB.

Guys I'm sorry if I am posting my question in improper place, but:
I've got AWS ALB left after previous k8s setup.
Can I somehow re-use ALB and related Target Groups and preserve their settings like Route 53 mappings and ssl certificates? Or it is possible only set up new ALB with alb-ingress-controller and then will need to set everything up again?

+1

Currently the controller must manage the ALB completely. Any changes made to the ALB would be seen as an undesired state and rolled back.


G3

Change Description
Description of change / link to associated issue.
Steps to Test
Steps for reviewers to follow to test the change.
Pull Request Checklist
Testing

[ ] Your PR passes all CI checks.
[ ] Tests covering the positive and negative (error paths) are included.
[ ] Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

[ ] The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
[ ] Commits follow the Ideal Git Commit Structure.
[ ] Any new logging statements use an appropriate subsystem and logging level.
[ ] Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
[ ] There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

2120 of 3263 (64.97%)  changed or added relevant lines in 57 files are covered.
49 unchanged lines in 14 files lost coverage.
Overall coverage increased (+0.01%) to 58.744%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

htlcswitch/link.go
7
8
87.5%

channeldb/graph_cache.go
54
56
96.43%

lnwire/features.go
15
17
88.24%

lnwire/lnwire.go
9
11
81.82%

graph/validation_barrier.go
17
20
85.0%

lnrpc/devrpc/dev_server.go
0
3
0.0%

discovery/message_store.go
6
10
60.0%

lnwire/gossip_timestamp_range.go
36
40
90.0%

lnwire/msat.go
21
25
84.0%

channeldb/models/channel_auth_proof.go
1
7
14.29%

Files with Coverage Reduction
New Missed Lines
%

queue/gc_queue.go
2
96.51%

watchtower/wtclient/session_negotiator.go
2
80.32%

server.go
2
64.05%

fn/list.go
2
97.33%

chainntnfs/btcdnotify/btcd.go
2
82.07%

htlcswitch/mock.go
2
75.14%

discovery/gossiper.go
2
79.67%

rpcserver.go
2
71.49%

chainntnfs/bitcoindnotify/bitcoind.go
3
81.5%

htlcswitch/mailbox.go
4
93.19%

Totals

Change from base Build<PHONE_NUMBER>0:
0.01%

Covered Lines:
127560

Relevant Lines:
217146

💛  - Coveralls


feat(tracing) [DSC] Dynamic Sampling Context continuation

Describe the idea
As a server side platform PHP applications instrumented with the Sentry SDK should continue to propagate dynamic sampling context data to all outgoing requests.
The SDK should extract Dynamic Sampling Context from incoming requests, and propagating DSC to downstream SDKs.
Requirement:
When a PHP application receives a request which has baggage attached with sentry values,
It shall propagate those same value in further outgoing requests
so that contextual data is preserved across the continuation of trace
what should be sent?
baggage header

[ ] sentry-trace_id
[ ] sentry-public_key
[ ] sentry-sample_rate
[ ] sentry-release
[ ] sentry-environment
[ ] sentry-user_id
[ ] sentry-user_segment
[ ] sentry-transaction

Traces Envelope Header

[ ] trace_id (string)
[ ] public_key (string)
[ ] sample_rate (string)
[ ] release (string)
[ ] environment (string)
[ ] user_id (string)
[ ] user_segment (string)
[ ] transaction (string)

where should it be sent?

in dynamic sample context (by baggage header)
in the envelope header
meta data (was/is being done in JS to be check if still necessary)

Example:
Here is an example from the Sentry UI, where the implementation has already begun on the latest versions of the JS SDK. A request from the front end to a down stream applications includes in the request header baggage

Why do you think it's beneficial to most of the users
This ensures that further downstream applications connected in a distributed trace will contain all contextual data required for dynamically sampling based on upon the contextual data from the head of the trace.
Possible implementation
Implementation has already begun (at the time of this creation) on JS and Android. Refer to the SDK Developer documentation for further information
For full up to date requirements according to SDK Developer specifications please see the associated documentation.
Dynamic Sampling Context
Original PR for full context
Add spec for Dynamic Sampling Context #613

baggage is standardized from the W3C spec, and then we further defined it based on our interpretation and usage of the spec

Hi @stayallive ,
any chance you could take a look at this one? it's been done on JS, and in progress on Python and mobile SDKs, then ruby and PHP are the next we'd like to cover.
We can have a sync with @Lms24 and @sl0thentr0py about the implementation on JS and Python respectively

@smeubank yes I will take a look at this, let me read in on it a bit and get back to you if I have any questions!

within this issue we will handle adding source to transaction names: in dev docs to be linked


Add SERVER_NAME and SERVER_PORT key to rack env.

Rack::Builder did not work because these variables were missed from env hash.

Any chance this could be included in a release, @tarcieri?

Released in 0.2.2

Thanks @tarcieri


Services not restored after uninstalltion

After uninstalling the module from Magisk then copy the uninstall.sh script on termux , still services are not restored. Play integrity breaks and can't use GPay. Seems like factory reset is the only solution

When I uninstalled this module and ran the uninstall.sh script, I was able to get the newest version of Play Integrity Fix (v18.2) working. This module definitely breaks Play Integrity Fix though. I don't see why the uninstall.sh script that is provided here on GitHub is not automatically run when you remove the module from Magisk. Is there a good reason why this is not implemented?


i18n(ko-KR): update server-side-rendering.mdx

Description (required)

update server-side-rendering.mdx
#9700

Related issues & labels (optional)

Closes #
Suggested label:

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

ko
guides/server-side-rendering.mdx
Localization changed, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


support validator in OpenAPI generator

We need to add validator support in openapi gen.  It is treated as advanced topic in origin issue, but is quite important in most cases.

support basic validator (generate more complex json schema)
support customized validator (by vendor extension)


[#143868179] Deploy walking skeleton of Compose service broker

What
https://www.pivotaltracker.com/story/show/143868179
We want to deploy the Compose service broker as an application on the platform.
How to review
Preferably review in conjunction with https://github.com/alphagov/paas-compose-broker/pull/1
Deploy from this branch and make sure all of the tests passed. The tests haven't been changed, but the ordering of tasks in the CF deploy has.
The broker is a 'walking skeleton', so doesn't need to actually provision anything. Its 'correct' behaviour is to error when actually performing all operations except the Services endpoint for returning the catalog.
Example of checking it serves the catalog:
curl -k -u compose-broker:$PASSWORD_FROM_CF_SECRETS https://compose-broker.${DEPLOY_ENV}.dev.cloudpipelineapps.digital/v2/catalog

Before merging ⚠
Review and merge https://github.com/alphagov/paas-compose-broker/pull/1 and then remove the temporary commit on this branch.
Who can review
Anyone but me or @combor

I have marked this as WIP because we hit this issue: https://github.com/cloudfoundry/cli/issues/939, which means if you deploy twice the deployment fails with:
Enabling access to all plans of service mongo for the org service-brokers as admin...
FAILED
Server error, status code: 400, error code: 260002, message: This combination of ServicePlan and Organization is already taken: organization_id and service_plan_id unique

Discussed with @alext and @combor and agreed to not enable the service at all and add a custom acceptance test which adds it (which should be removed automatically when the test org is deleted). Also, it was suggested to move the catalog.json file from paas-compose-broker to paas-cf, as it is deploy/runtime configuration. A copy of it can be kept in the paas-compose-broker as a useful example.

The pipeline no longer enables the service access. I've added a custom acceptance test which just checks the marketplace. See commit message for details. Ready for review again.

I believe I have addressed all comments. This is probably ready for re-review.

This is ready to re-re-check.


optimize log init

What this PR does:
log init optimize
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Codecov Report

Merging #408 (26cbc76) into master (1246a7e) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   41.48%   41.45%   -0.03%
==========================================
  Files         131      131
  Lines        7564     7569       +5
==========================================
  Hits         3138     3138
- Misses       4184     4189       +5
  Partials      242      242

Impacted Files
Coverage Δ

pkg/client/client.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Preparing Nistats for retirement

In preparation for freezing the Nistats repo with one last release, here are my ideas and question:

It will be released as 0.0.1rc .
The minimum required Nilearn version is 0.4. However I believe we should bump it up, to a minimum 0.5.2, the last release with Python2 support. 0.4 is way too low.
I will set a new max_version to 0.6.3 , so people with Nilearn 0.7.0 and above cannot install Nistats.

Yes, makes sense.


Properly handle transparency of 3D models

Currently we don't properly render 3D models with transparency correctly. The original client is displaying them properly, even with edge cases:

It seems that the objects are properly drawn from the back to front (the rings are one mesh, so I wonder how they are poperly sorted!)
Entities are seen through transparent objects

We should analyse this model in Izlude in depth and figure out, how we can best handle this kind of transparency.

This is the current way how we render this structure. It seems the original client either renders the transparent nodes by sorting it's primtives by depth each frame (and doing alpha blending properly that way), or implements depth peeling. Knowing the DX7 API, a sorting of primtives seems more logical.
We currently only sort the nodes, which is not enough for this specific model. We could implement order independent transparency, but this feels like a waste of resources for the very few models that have intersecting transparency.

I will for now close this issue, since I think order independent transparency is something that is currently not needed, since it would add a lot of complexity and cost to our renderer (especially since we use MSAA a lot).
If somebody would like to add this later, I suggest using Weighted Blended Order-Independent Transparency (WBOIT). We would need to fill another render target with the information of the transparent objects, that uses following encoding:
// Single RGBA16F texture format:
R: Weighted premultiplied red   (color.r * alpha * weight)
G: Weighted premultiplied green (color.g * alpha * weight)
B: Weighted premultiplied blue  (color.b * alpha * weight)
A: Revealage (background visibility)

The weight would be calculated like this way:
 let weight = alpha * max(
        0.01,
        min(3000.0,
            pow(in.position.z, 4.0)
        )
    );

We would need to add a full screen triangle render pass with the following fragment shader:
@fragment
fn composite_fs(input: VertexOutput) -> @location(0) vec4<f32> {
    let packed = textureLoad(packed_texture, vec2<i32>(input.position.xy), 0);

    let weighted_color = packed.rgb;
    let revealage = packed.a;

    // We use length as weight sum approximation
    let final_color = weighted_color / clamp(
        length(weighted_color),
        0.00001,
        50000.0
    );

    return vec4<f32>(final_color, revealage);
}


Add phone numbers to City Pages

Feature request
Calling can be more effective at reaching elected officials than emailing, as calls are harder to ignore. I propose we add phone numbers (and associated names, titles of officials) to city pages and recommend submissions include them.
Potential future issues: Including a shortened script to use for phone calls.

Linking to Discord convo here for a little more context (where many of us are super on board!)


certmgr: fix kubernetes system certs recreate loop

Avoid unnecessary regeneration of kubernetes system certs
Kubernetes system certs have a CN which is not a vaild DNS name (e.g. system:kube-proxy). The new certmgr has a check that the requested CN and hosts match the DNS names and IP:s of the actual cert on disk. This check always fails for kubernetes system certs, causing them to be regenerated every 30m. This restarts kube-apiserver et al. and causes a lot of noise and service interruption.

Things done
Patch certmgr to ignore DNS and IP checks for CN:s with : in the name (I will file a PR with the upstream certmgr repo as well).

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I will file a PR with the upstream certmgr repo as well

Did you get around to this?