Add average dpl plot

To address #473 , we add an extra line plot when the dpl in plot_dipole is a list. All individual trial lines are colored gray while the average one is green. And if the dpl is a Dipole instance, the single trial will be green.
Below is the current behavior:

Also, I changed the way to turn dpl into a list, as a function should not modify its parameters especially when the purpose is to draw something. Because the user may expect the dpl to stay the original type after multiple calls of the visualization function (for reasons like refining styles).

Some questions:

Do we need to change the alpha of those individual trials?
Should we increase the line width for the average dpl data like this one?

This is great! I think the gray for the individual trials looks good, but perhaps a slightly thicker line for the average? I'm thinking 1.25 - 1.5x compared to the gray lines

I would indeed add an alpha to the individual trials if there are multiple trials.

@chenghuzi could you add/update some tests? Smoke tests are fine for visualization.

@chenghuzi could you add/update some tests? Smoke tests are fine for visualization.

Sure, will add them once the implementation looks good to us.

looks good! also I'd call it alpha instead of individual_alpha and clarify in the docstring that it's applied only to individual trials.
…

Sure, fixed in 8aad9cb

tests remain, and after that you can update whats_new.rst. Getting close!

Codecov Report

Merging #475 (d7efb7c) into master (52620b2) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   90.45%   90.29%   -0.17%
==========================================
  Files          18       18
  Lines        3395     3399       +4
==========================================
- Hits         3071     3069       -2
- Misses        324      330       +6

Impacted Files
Coverage Δ

hnn_core/dipole.py
91.61% <100.00%> (+0.05%)
:arrow_up:

hnn_core/viz.py
83.73% <100.00%> (+0.26%)
:arrow_up:

hnn_core/parallel_backends.py
80.50% <0.00%> (-1.82%)
:arrow_down:

hnn_core/mpi_child.py
96.38% <0.00%> (-0.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52620b2...d7efb7c. Read the comment docs.

I don't quite get why circleCI is not working on your pull request @chenghuzi. I tried to make a dummy pull request on #476 and that did run circleCI:

Does this also happen in your other pull request?

I don't quite get why circleCI is not working on your pull request @chenghuzi. I tried to make a dummy pull request on #476 and that did run circleCI:

Does this also happen in your other pull request? Maybe try pushing a new commit to see if the problem goes away?

I noticed that sometimes neuron.yale.edu is not accessible and probably that might be the reason it fails tests

For completeness: CircleCI does not trigger builds for first-time contributors to avoid passing the secrets ... probably a security hazard. See here.
I'll push a dummy commit here to trigger the build and check if everything is alright.

something wrong in this example here @chenghuzi : https://2173-168215891-gh.circle-artifacts.com/0/html/auto_examples/workflows/plot_simulate_evoked.html#sphx-glr-auto-examples-workflows-plot-simulate-evoked-py
There are only 2 dipoles but 3 are being plotted. If average=False, the average dipole shouldn't be plotted at all. I think the if-else condition needs fixing

also why is the default color of the plot not black when only one dipole is plotted?

something wrong in this example here @chenghuzi : https://2173-168215891-gh.circle-artifacts.com/0/html/auto_examples/workflows/plot_simulate_evoked.html#sphx-glr-auto-examples-workflows-plot-simulate-evoked-py
There are only 2 dipoles but 3 are being plotted. If average=False, the average dipole shouldn't be plotted at all. I think the if-else condition needs fixing

Oh sorry I forgot that. Fixed in d7ec7837a39998ccf32852b7af78aa8c60599912

also why is the default color of the plot not black when only one dipole is plotted?

I thinks it's because the color of plot in Dipole is None and is passed to plot_dipole.

I think all corner cases are addressed now, merging. Thanks @chenghuzi ! Congratulations on your first pull request 🎉

What I’m proposing is that the color argument apply a uniform color across all trials if no average is to be computed and plotted. If it’s the case that we want individual trials to always be plotted in grey, than we should clarify in the docstring that the color parameter only applies to an average dipole if/when it’s computed within the plot_dipole function. I’m not sure this is the case, as there have been times when e.g. I’ve computed the trial-average dipole outside the plot_dipole function and then wished to plot it as a certain color within a preexisting matplotlib axes instance, but I’ll let @jasmainak and @ntolley weigh in here as well.

On Mar 25, 2022, at 7:07 PM, Huzi Cheng @.***> wrote:

@chenghuzi commented on this pull request.
In hnn_core/viz.py:

 if ax is None:
     _, ax = plt.subplots(1, 1, constrained_layout=True)

 if isinstance(dpl, Dipole):
     dpl = [dpl]

   average = False

   alpha = 1

Then the same parameter color has different meanings in that case, which I think may create even more confusion. In our current implementation, color is just for the averaged dpl line but not for individual dpls. As for the case of average=False, I don't think manually assigning different colors for different trials will be meaningful. Of course, a straightforward solution is to add another parameter like individual_colors as a list of color values.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

@rythorpe old comment?

Woah. Yeah something in the interwebs broke - I wrote this last spring.


[fix] Transform "modulepreload" into "preload" when files are compiled

Both by dev server and for the build. When output format is systemjs, module becomes regular js.

Done during https://github.com/jsenv/jsenv-core/pull/187


Usage?

How are you supposed to use this in a rails app? Copy the file into my app?
thx

Hi Stoivo
This is a collection of ruby example scripts that uses Clickatell HTTP and Rest APIs.
To use the examples you require the rest-client gem:
gem install rest-client
So you are welcome to copy the example files into your app if you like, but you’ll probably have to change it quite a bit to fit your solution seeing as the intention with these scripts was to help get you started.

thx, I think I will just copy the things I need.
What I really wanted to know is if there is a option to to
# in initializer
Clickatell.config.username = 'username'
Clickatell.config.passward = 'password'
Clickatell.config.api_key = 'key'

# in my class
require 'clickatell'

Clickatell.send('093139231', ' Here come some msg')
Clickatell.get_reminding_sms
``

No worries,
The examples don't include any Clickatell class that you can use like that, they are just simple instances of the RestClient class, so you are limited to the API of that gem. See https://github.com/rest-client/rest-client.
You can always write your own Clickatell wrapper class that will keep things nicely abstracted.

yes, thx so much! :sparkles:


Broken CI build due to CallHandshakeTest on different JVMs

effectiveOrderInRestrictedJdk11() - okhttp3.CallHandshakeTest

java.lang.AssertionError:
Expecting:
  <["TLS_AES_128_GCM_SHA256",
    "TLS_AES_256_GCM_SHA384",
    "TLS_CHACHA20_POLY1305_SHA256",
    "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
    "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
    "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256",
    "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
    "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
    "TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256"]>
to contain exactly (and in same order):
  <["TLS_AES_128_GCM_SHA256",
    "TLS_AES_256_GCM_SHA384",
    "TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
    "TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
    "TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
    "TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256"]>
but some elements were not expected:
  <["TLS_CHACHA20_POLY1305_SHA256",
    "TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256",
    "TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256"]>

Order of ciphers and new ciphers are availability and I think back ported https://bugs.openjdk.java.net/browse/JDK-8204192

Low priority, I think skipped on wrong platforms or fixed otherwise.


Feature Request: Reaction status indicator without full action UI

It would be nice if the Reaction status icon option was available without the full indicator (Pre helpers 2.0 style), since Reaction is usually the main one that requires tracking.
Per our discussion on Discord, perhaps it could be a case of supressing the additional UI.

Added in 2.0.5


Issue with blank fields

Hello Lucas,
first of all, great job on the PCF Controls. They are awesome.
Just two things, do you intend to add a solution for the background of multiple choice fields as well?
And somehow on all of the PCF Controls if the field is empty (without any value). It automatically shows
a fill (date = dd/MM/yyyy) or 0 for an empty field. Is it possible to get rid of this?
Thanks in advance for your help.
Regards Roman

Hi @r0man5k,
for now at least the date is difficult to change for the placeholder.
I will have a look at the 0 for the other inputs.
I guess the multiple choice field is not yet a thing for us, but will come in the future.
Maybe one of the PCFs from my colleague can help in between: https://github.com/Panbaa
I will update the Repo as soon as I can release some new versions. But it will take some time.


New buzz patterns still do not work

The buzz patterns introduced in #1889 still do not work on my watch (sched v0.13, alarm v0.33, firmware 2v14), e.g. if I select ':' as buzz pattern I only get silence. '.' still is the strong pattern. Does anyone else have this problem?
I have attached the sched.js:
sched.js.txt
The code for ":"-pattern seems to be there. Does anyone have a clue what might be wrong?

I've been using this for a while it seems to work fine for me.
Have you tried actually just calling require("buzz").buzz(":") from the IDE and seeing what happens?

Same, with require("buzz").pattern(":") in the console (left) part of the IDE, nothing happens, "." works. I wonder what actually gets executed when I put that in the console, I don't see it fetching buzz.js.
When I paste the full code from buzz.js I get a noise, so it generally works:
pattern = pattern => new Promise(resolve => {
  function doBuzz() {
    if (pattern == "") resolve();
    var c = pattern[0];
    pattern = pattern.substr(1);
    const BUZZ_WEAK = 0.25, BUZZ_STRONG = 1;
    const SHORT_MS = 100, MEDIUM_MS = 200, LONG_MS = 500;
    if (c == ".") Bangle.buzz(SHORT_MS, BUZZ_WEAK).then(() => setTimeout(doBuzz, 100));
    else if (c == ",") Bangle.buzz(MEDIUM_MS, BUZZ_WEAK).then(() => setTimeout(doBuzz, 100));
    else if (c == "-") Bangle.buzz(LONG_MS, BUZZ_WEAK).then(() => setTimeout(doBuzz, 100));
    else if (c == ":") Bangle.buzz(SHORT_MS, BUZZ_STRONG).then(() => setTimeout(doBuzz, 100));
    else if (c == ";") Bangle.buzz(MEDIUM_MS, BUZZ_STRONG).then(() => setTimeout(doBuzz, 100));
    else if (c == "=") Bangle.buzz(LONG_MS, BUZZ_STRONG).then(() => setTimeout(doBuzz, 100));
    else setTimeout(doBuzz, 100);
  }
  doBuzz();
});

pattern(":");

I might have an idea now. I have a widget widshipbell installed that also loads buzz.js. It was installed before the changes to buzz.js, so does not include the new patterns. Now what does happen when multiple files require a module? I guess only the first one wins? So if the widget requires buzz.js and loads the old buzz.js the new buzz.js from the scheduler is not loaded?
If so we maybe should bump the version number on all apps that require a module if that gets updated.

Now what does happen when multiple files require a module?

I'd never considered that! Yes, it's the first one that wins.
This wouldn't be an issue for apps, it's just where you have widgets/boot code as those are loaded at the same time as others.
I guess there's a good argument that actually the App Loader should load buzz.js into a file called buzz in storage - so then all apps use the same version. Also not having that code inside them would make them load quicker


feat(lambda): create list aliases functionality

Creates the list_aliases functionality
Redesign internal storage of aliases to correct mistaken implementation (The same alias name could be created under the same lambda pointing to different versions)
Adds tests for new functionality

Let me know if you want docs updated as part of this PR

Will look into the failing test


Add isingxy generator

Before submitting
Please complete the following checklist when submitting a PR:

[x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!

[ ] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.

[ ] Ensure that the test suite passes, by running make test.

[x] Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.

[x] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:

Hi @multiphaseCFD, my original idea was to separate this PR from other changes, but it seems like we have already merged all changes in the release branch to master. Thus this PR becomes obsolete and I close this PR. Sorry that I have made you another work 😿

Hi @chaeyeunpark, No problem at all! My pleasure!


Rename the expected_exception option

The current name of the expected_exception option is misleading. It can easily be misinterpreted as the developer expecting the model to always  throw these exceptions given the behaviour one observes in PHPUnit when using @expectedException and the like.
Talking to other people on the conferences we talked about this bundle we got some good suggestions for a better name. Amongst these are the following (I probably forgot some):

intercept_exception
catch_exception
validation_exception
handle_exception
throws
catch

Maybe, if you explain again here what the consequence of this option is, we might get a better understanding of what the naming should indicate

What this option does is the following: You give it a list of exception classes that may be thrown by your domain model when the data is written from the form to your model. These exceptions will then be caught and do not bubble up. Instead they will be handled by the GenericExceptionHandler which will attach a FormError to the form based on the exception message.

I suggested catch on Twitter but with this list I think handle_exception is an even better suggestion. It describes very accurately what it would do.

i would like to move away from exception specific terminology. right now we're just supporting exceptions, but there are way more advanced pattern of dealing with invalide state:
e.g. https://martinfowler.com/articles/replaceThrowWithNotification.html
IMO we should focus on the fact that we are converting domain specific errors to form errors.
might be quite hard to tackle all in one, but we should think about different concepts of error_strategy and i guess the ExceptionHandler extension point is a pretty good start

it might be quite impossible to handle all different strategies of error handling in user domain so we need to come up with an very simple extension point to solve that issue
my best idea so far
$builder
    ->add('fieldName', FieldType::class, [
        'errors' => [
            Error::byException('price_error', [PriceException::class])
                ->withMessage('form_error.translation_key')
                ->withTranslationDomain('form_errors'),
        ],
    ]);

with
class Error
{
    public static function byException(string $name, string|string[] $expectedTypes = null): self { ... }
}

pull request waiting for review at #55


Issue with k8s.io/docs/reference/

This is a...

[ ] Feature Request
[ ] Bug Report

Problem:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/
api doc reference not working properly due to jquery-2.2.0.min.js and bootstrap.min.js not found.
https://kubernetes.io/js/jquery-2.2.0.min.js 404 (Not Found)
https://kubernetes.io/js/bootstrap.min.js 404 (Not Found)
Proposed Solution:
put back the missing JS file
Page to Update:
https://kubernetes.io/...

1.11
1.12
1.13

1.12 works. 1.11 and 1.13 doesn't work.


How does this deal with the npm paths issue? (Users..AppData vs Program Files)

Or, what exactly does this module do? I can't tell from the Readme here on Github. The big issue with Windows installs is that node is in Program Files, but npm seems to want to be in the user's AppData path. Anything installed with -g will go to AppData by default. There are two npms in a Windows install, as soon as you use -g. How does this module handle the two separate npms?
Thanks,
Joe Duarte

Exactly - this module finds where npm is currently installed and updates exactly that version.

Hi Felix – Sorry, I'm dense. npm is installed in two different places. So when you say that this tool finds where npm is installed and updates that version, which of the two installs are you referring to? A key complication with npm on Windows is the dual install. How does the tool address this? Does it update both installs?
FYI, the npm wiki page that links to your tool is mistaken about the path environment variables. They say that the node installer puts C:\Program Files (x86)\nodejs before C:\Users\<username>\AppData\Roaming\npm, and that this is an issue. I've tested this on Windows 8.1 and 10, and what the node installer actually does is put C:\Program Files (x86)\nodejs in System paths, and C:\Users\<username>\AppData\Roaming\npm in User paths. They're in totally different environment variables – neither one is "before" or after the other. I don't know what the implications of this are.

Hey @JoeArizona - the beauty of open source is that you can just read the source code and find all your answers there. However, to respond to your questions:

If you run npm, a program is run. We find that program - and update it. You can try this yourself with Get-Command npm | Select-Object -ExpandProperty Definition.
System comes before User. To the shell, they're concatenated.


[sfml] Update to 2.6.1

Fixes https://github.com/microsoft/vcpkg/issues/35082

[X] Changes comply with the maintainer guide
[X] SHA512s are updated for each updated download
[ ] The "supports" clause reflects platforms that may be fixed by this new version
[ ] Any fixed CI baseline entries are removed from that file.
[ ] Any patches that are no longer applied are deleted from the port's directory.
[X] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[X] Only one version is added to each modified port's versions file.

Usage test pass with following triplets:
x86-windows
x64-windows
x64-windows-static

https://github.com/SFML/SFML/releases/tag/2.6.2
2.6.2 is out now!


Laravel 10.x Compatibility

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.
Before merging, you need to:

Checkout the l10-compatibility branch
Review all comments for additional changes
Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

:warning: Shift updated your build matrix for Laravel 10. However, since you are supporting older versions of Laravel, you need to add the following exclusions:
exclude:
  - laravel: 10.*
    php: 8.0
  - laravel: 10.*
    php: 7.4

:warning: Shift updated your build matrix for Laravel 10. However, since you are supporting older versions of Laravel, you need to add the following exclusions:
exclude:
  - laravel: 10.*
    php: 8.0
  - laravel: 10.*
    php: 7.4

:warning: Shift updated your build matrix for Laravel 10. However, since you are supporting older versions of Laravel, you need to add the following exclusions:
exclude:
  - laravel: 10.*
    php: 8.0

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 10. However, you should review these changes to ensure the desired combination of versions are built for your package.

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.
To do so, temporarily add Shift's fork to the repositories property of your composer.json:
{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-api-response-helpers.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:
{
    "require": {
        "f9webltd/laravel-api-response-helpers": "dev-l10-compatibility",
    }
}

Finally, run: composer update


Animations currently not working on some browser-device combinations

Image viewer animations are currently not working on (at least) the following combinations:
Desktop + Edge
Desktop + IE 11
iPad Mini + Safari
iPad Mini + Firefox
Maybe this is a general Angular 2 issue. It is working e.g. on:
Desktop + Chrome
Desktop + Firefox
Nexus 5 + Chrome
Nexus 5 + Firefox

Apparently Angular 2 is based on web-animations (https://medium.com/google-developer-experts/angular-2-animate-router-transitions-6de179e00204).
Let's include that polyfill:
https://github.com/web-animations/web-animations-js

Adding the polyfill fixes the issues for all browser combinations listed above. For now IE 11 behaves a little bit juddery. Should create a Plunkr for this an raise an issue.


It's not possible to install sharp

I used sharp for about a year on another app, no problems at all for that period.
Now I am trying to install it on another app, through npm, and it is just not possible.
I tried upgrading my npm, I tried using both --unsafe-perm and --ignore-scripts, I tried deleting the npm_modules and package.json, to then run npm install... It just doesn't work!
I even tried adding "minipass": "2.7.0" on dependencies, nothing is fixing the issue.
I've seen the same issue popping up from 2019
ERROR:
sharp: Downloading https://github.com/lovell/sharp-libvips/releases/download/v8.11.3/libvips-8.11.3-linux-x64.tar.br remote:        sh: 1: prebuild-install: Permission denied remote:        make: Entering directory '/tmp/build_e87a24ec/node_modules/sharp/build' remote:          CC(target) Release/obj.target/nothing/../node-addon-api/nothing.o remote:          AR(target) Release/obj.target/../node-addon-api/nothing.a remote:          COPY Release/nothing.a remote:          TOUCH Release/obj.target/libvips-cpp.stamp remote:          CXX(target) Release/obj.target/sharp-linux-x64/src/common.o remote:        ../src/common.cc:24:10: fatal error: vips/vips8: No such file or directory remote:         #include <vips/vips8> remote:                  ^~~~~~~~~~~~ remote:        compilation terminated. remote:        sharp-linux-x64.target.mk:139: recipe for target 'Release/obj.target/sharp-linux-x64/src/common.o' failed remote:        make: *** [Release/obj.target/sharp-linux-x64/src/common.o] Error 1 remote:        make: Leaving directory '/tmp/build_e87a24ec/node_modules/sharp/build' remote:        gyp ERR! build error

I had the same issue the first time when I executed npm i sharp, but the second time I executed npm i -verbose sharp and it installed successfully.

I am currently running into the same thing. I vendored the build, and the build is now going fine. But when uploaded to the cloud foundry environment the rebuild fails on this exact error.
 However the path while building is different from the path on the cloud foundry environment. Could that be the issue?

已收到，谢谢


XSS security problem

If give some data like this to the component,  it will execute js and get cookie:
const data = `{data: \"<img onerror='alert(document.cookie)' src='invalid-image' />}`

<JSONPretty id="json-pretty" data={data} />

People all using this component should be careful about input and do more check.
This is because this component use dangerouslySetInnerHTML;

I think people should be warned in README about it before start using this component.

fixed in v2.0.1


Format and fix error in languages file

Realized something might of broke so here's fix 😅

woops i already fix it lol

you can prob close it


Shopify analytics 2

Instrument Shopify Analytics
The goal of this analytics implementation is to make sure the analytics admin dashboard is connected
Events instrumented

[x] Page view

Before submitting the PR, please make sure you do the following:

[ ] Read the Contributing Guidelines
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
[ ] Update docs in this repository according to your change
[ ] Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

ohh I didn't notice I had a bad merge


Fixed issue with customer filter popover and added confirmation for r…

Fixed up custom filter removal confirmation and blank popover as per issue 1825

Thanks, it's merged!


Batch Workaround for Deserialization of Long Properties

Description
There is a bug in the Batch Service: all properties defined as longs in our TypeSpec are returned from the service side as strings.
The service team is working on a fix for this issue in our next API release.
In the meantime, this PR temporarily resolves the bug by:

Modifying the deserialization code to handle a string input so there is no issue with accessing these properties
Adding test coverage for the deserialization of all of the long properties to determine that they are being deserialized without errors.

Once the new API is released on the service side, we will revert these temporary deserialization changes and verify that the service side logic works with the test coverage added in this PR.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-compute-batch


bug: Inline projections don't have correct version when appending to an existing stream (quickappend)

Found as part of https://github.com/JasperFx/marten/issues/3307, Inline projections take their revision from the version of the last event appended to a stream, but for quickAppend this is not a valid version.
This is the tests I was using for performance, one of them is failing due to this issue, so the rest can be removed if you dont care about them. The size of the streams / iterations are scaled way back to make the tests fast.

Got it with some merge/rebase clumsiness. @elexisvenator Thanks for doing all the work to find this issue and to repro it!


[Bug] Doesn't work with Grafana 6.5.0

Describe the bug
When viewing any boomtable panel in Grafana version 6.5.0, I get the error _this.$sce is undefined and the panel is blank, i.e none of our boomtable panels are currently working.
Version Details:

Grafana version : 6.5.0
Plugin version : 1.30

I confirm, after upgrading to 6.5.0 the plugin stops working.

I got same error _this.$sce with Grafana v6.5.0 (commit: 24a5d2f) and plugin v 1.3.0.

grafana confirmed that this is a generic issue and nothing to do with the plugin. Grafana team fixex this via https://github.com/grafana/grafana/issues/20662 . So you may need to upgrade grafana once new version available.

I can confirm that the issue now is resolved in Grafana v 6.5.1.


Simplify code using TS2 inference smarts

Typescript 2 is smarter about inferring types, so we can clean up some old code to take advantage of it. This breaks npm run docs since typedoc is still using Typescript 1.8, so we'll need to update typedoc before merging this.
This includes #833

Superseded by #950.


KEEP-only pool contracts

For users who don't have the required minimum stake for staking, we want to add an option to lock your KEEP and earn rewards. This KEEP-only pool will act as a bridge to easier KEEP staking and help new users to reach the required minimum stake.
This PR implements a contract for the pool based completely on the solution from ampleforth/token-geyser.
Contracts IStaking, TokenPool and TokenGeyser were copied from the referenced repo with just minor tweaks:

updated pragma to reflect the one used by our project,
align functions ordering to meet our linting requirements.,
defined a separate role for rewards tokens locking (04150b9bd7537cc0b3c50437dd448c99a7d2c8dc)

The KeepTokenGeyser contract is a generic contract that supports an ERC20 token as a stake and distributes KEEP token in rewards.
KEEP tokens for distribution can be locked in the contract from any address holding rewardDistribution role. The contract supports the "approve and call" pattern, so it can be funded from Escrow via KeepTokenGeyserRewardsEscrowBeneficiary.
For the KEEP-only pool we defined KeepVault contract that uses KEEP as both staking and distribution tokens.
The constructor requires few parameters (with proposed values):

initialSharesPerToken: number of shares to mint per staking token on a first stake (1)
durationSec: length od time to linearly unlock the rewards tokens (1 month)
maxUnlockSchedules: max number of unlocking schedules, how many periods do we want to have, a guard against hitting gas limit (`12)
startBonus: % that stakers get right after staking, it grows linearly to 100% over a bonus period (30)
bonusPeriodSec: a period over which bonus grows to 100% (1 month)

More about the bonus:

Applies an additional time-bonus to a distribution amount. This is necessary to encourage long-term deposits instead of constant unstake/restakes. The bonus-multiplier is the result of a linear function that starts at startBonus and ends at 100% over bonusPeriodSec, then stays at 100% thereafter.

Reference issue for KEEP Token Dashboard: https://github.com/keep-network/keep-core/issues/2255
Depends on: https://github.com/keep-network/keep-core/pull/2244

Linting checks are failing right now because I already included rules from upcoming PR https://github.com/keep-network/keep-core/pull/2244 that is not yet merged to master.

Linting checks are failing right now because I already included rules from upcoming PR https://github.com/keep-network/keep-core/pull/2244 that is not yet merged to master.

Linting checks are failing right now because I already included rules from upcoming PR #2244 that is not yet merged to master.

#2244 has just been merged, we can update here @nkuba

Linting checks are failing right now because I already included rules from upcoming PR #2244 that is not yet merged to master.

#2244 has just been merged, we can update here @nkuba


Some documentation appears backwards

Synchronous code
When testing synchronous code, omit the callback and Mocha will automatically continue on to the next test.
The callback is not introduced till the Asynchronous section right below.
Asynchronous code
All "hooks", that is before(), after(), beforeEach(), afterEach() may be sync or async as well, behaving much like a regular test-case.
Hooks aren't described till after this section.

Doesn't seem like an issue. The documentation is not really meant as a linear explanation, but as a reference manual in which you look up things.


[Question]: is a non-default windowSize properly enforced in KQL queries?

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Description
I have a question concerning the windowSize value of an alert:
We have configured one of the alerts, the VMOSDiskReadLatencyAlert to use a windowSize of 1 hour  [PT1H] instead of the default 15 minutes [PT15M].
This all seems to work just fine when redeployed, the alerts windowSize [or aggregation granulatiry as it's called in the portal condition] is correctly adjusted to 1 hour.
However when looking at the KQL query used in both the documentation and the portal show up using the following:

where it seems that avg(Val) by bin(TimeGenerated, 15m) still only checks for the last 15 minutes.
We still get the alerts popping up for some servers, even though the average value over the period of an hour doesn't exceed the threshold for the machines.
Am I right at thinking the KQL query also needs to adjust based on the value provided for the windowSize, or can someone explain me how this works and why the values differ [and perhaps should]?
This issue seems to be the case for not just this specific alert, but also others, but this is a clear working example in our environment.

Hello @powershellpr0mpt,
thanks for your question. WindowsSize and aggregation performed by the Summarize are different. There's no adjustment needed since the windowsSize is driving the time range of data to be considered (last 1h of data) whilst the summarize is aggregating data in that windows based on intervals (15m). This second aggregation is only meant to relax the customer from the alert fatigue and to have only one record to be checked. Too many records could either creates false positives or too many alerts.
Hope that helps.
Thanks,
Bruno.

Thanks for the explanation @Brunoga-MS , makes it a lot clearer for me and my colleagues.
Unfortunately there's not much explanation on this subject in MS docs either [as far as I was able to locate], so this was helpfull!
This can be closed now 👍🏻

Thanks @powershellpr0mpt.


Added buttons event

Added event for minimize - maximize buttons
wrote some css, html and some script for minimize and maximize buttons

Create an issue before making PR, 2 of you made same kind of PR.


Fix transport dependencies

Ensure we don't ship transitive analyzers, and all transport packages are packed.

@dotnet/razor-compiler for review please

@chsienki looks ilke a few real failures in the PR


⚠ Jenkins Plugins Artifactory has degraded performance

In 5240de4, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1189 ms

Resolved: Jenkins Plugins Artifactory performance has improved in d9bf02d after 2 hours, 12 minutes.


Fix missing imagePullSecrets

When I tried to deploy the backport/images branch I ran into some authentication errors. This is with pullPolicy: Always  on every image in my values.yaml file.
I'm a bit unsure about two things:

Why this wasn't an issue when I tested my branch
Why imagePullSecrets isn't needed in every yaml file that references a container

With these changes I can successful deploy to my cluster.

Hmm, I don't understand either. I would expect the pull secrets to be required everywhere. I would have said 'maybe some of the templates don't honour pullPolicy' but for example cmdesc does and that doesn't currently have the imagePullSecrets. I will need to go through and add the secrets to every Pod, I think.

Hey @amrc-benmorrow, I've gone through all the pods and added imagePullSecrets to all of them. I've pulled the changes from v2-stable and tested them but I'm not sure that means much as the original PR worked for me.


fixed a few certainty scores out of range

Newly imputed missing article titles to the tei corpus with no-mention articles


Warnings if a game is impossible to convert because of the unexistence update file

This is an idea more than a issue, i wanted to convert spiderman 3, but i didn't realize later that this game doesn't have an update, soo is impossible to convert it in ofw, so that's why i want to say, a method to recognize games who are impossible to convert, pops a message saying, "this game can not be converted to ofw because there is not updates for this game", or something like that warning users the impossibility to converted some games.
i know i can check the compactibility list on internet, but a little message could save me hours of researching why spiderman 3 can not be converted.
thanks for your hard work, greatings and bye.

https://www.reddit.com/r/ps3homebrew/wiki/cfw2ofw#wiki_checking_compatibility

Can't be converted because the update have psn eboot kind and the method depend on it. (You can't run bluray eboot from hdd, only psn eboot)


Services: Dnsmasq DNS - remove "Register DHCP leases" option

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
The option "Register DHCP leases" is a remnant of our predecessor and doesn't seem to work as it should, since it's highly unlikely the registrations did work properly the last years and we use Unbound nowadays as our standard, it makes sense to remove the option and point people to Unbound when migrating old configurations.
To Reproduce
Explained in https://github.com/opnsense/core/issues/5627
Describe alternatives you considered
Rewrite dhcpleases as we did for Unbound and fix the issue, but  providing the same option in two places in the same product is suboptimal anyway. Since there are some use-cases where it does make sense to have a separate dns forwarder available, removing DNSMasq in full doesn't seem to be needed either.
Additional context
https://github.com/opnsense/core/blob/dedb11793547e270aa65cab8778eda4fc6663ebe/src/etc/inc/plugins.inc.d/dnsmasq.inc#L272-L277
^^ now seem to be the time.

#5119

@fichtner if you agree on removal, we can close https://github.com/opnsense/core/issues/5119 (which I missed to be honest, but given the usage of dnsmasq I don't think we should spend too much time trying to revive features that are hardly used)

Tested by @fichtner, tracking leases does seem to work without issues, which doesn't warrant feature removal for now as we can't assess how many people are actually using it. Which leaves https://github.com/opnsense/core/issues/5119 the valid ticket for now as we're not planning for full removal of dnsmasq just yet (maybe in the future, but only with an exit strategy).


Introduce nodes roles

Introduce roles for nodes, like calculation and projection

Done in https://github.com/andreyleskov/MightyCalc/releases/tag/0.3.0


Biopower plant TOD fractional generation causes simulation to fail

Boiler overdesign factor is specified in percent in UI but is treated as a factor in SSC. For example over-design of 10% in SAM UI is intended to mean a design factor of 1.1 but is passed to SSC as 0.1.

Fixed in 98b6c5f4d40191c7d4a217b57ececb6dababd522


Add port of TclRegaScript to settings and deploy script

I've set up recently a ccu2 on my Raspberry Pi with the help of your great docker image.
My Raspberry is running homebridge with the plugin homebridge-homematic. This plugin makes all ccu2 devices visible in Apple HomeKit. It uses the port 8181 for communicating with the ccu2. With this pull request I've added this port to the settings and the deploy script.
I tried to find a list of used ports of HomeMatic to check if more ports are missing. The only one I could find is in the Wiki of OpenHAB, do you know a better list?

If any put is missing it could also be added using the optional field variable. But if there are any other you miss then please send another PR.


Development

Bundle details + Userop Page new UI

Some reason my view is fucked. Could the data be center aligned ?

Hey, Align [Home/Recent UserOps/Address] with JiffyScan Logo - Center aligned will also work once the Activity tab is added

Heading Tabs (Overview, Calldata, Logs) need to have 22px size instead of 14px, and remove allCaps
Non-selected Tabs have a different color - Subtext - 9E9E9E
Add Black as the default color for selected Tab

Header up to Tabs fields has White Color - FFFFFF
Everything below that has Background Color - FAFAFA

In Bundle page, please add the profit percentage in brackets.


General feedback

High level stuff

Writing directly to stores is an anti-pattern. I might consider something like galleryActions.initialise() in the gallery constructor.
Consider a view/container design pattern to decouple the application logic (actions, state from stores) from the UI. The container has no props, but has store state that it applies to the single "view" component it is responsible for rendering. It listens to events from the view component and calls actions. This would liberate you to take something like the item component and move it to a completely different area of the CMS, used in a different context.
Probably should start thinking about some shouldComponentUpdate hooks. Although React diffs the VirtualDOM and makes minimal DOM mutations, it still takes a lot a work to calc that diff, and shouldComponentUpdate can bypass that all together, if, for instance, newProps === prevProps && newState === prevState.
One way that check can be easily defeated is through function binding in the render() method, e.g. <button onClick={this.handleClick.bind(this)}>. Every time you bind, you create a new reference to that function and therefore prevProps.onClick !== newProps.onClick every single time, defeating your shouldComponentUpdate.
Consider moving XHRs to the action layer. Things tend to scale better that way, as it becomes increasingly more likely that multiple stores will want the result of a server call.
Consider creating an API wrapper class singleton to tidy up all the jQuery.ajax.
Consider creating two action types: server and view, to manage optimistic updates and fetched data:

createFolder: (data) {
	galleryDispatcher.dispatch({
		action: CONSTANTS.ITEM_STORE.CREATE,
		type: CONSTANTS.VIEW_ACTION,
		data: { title: 'New folder' },
		silent: silent
	});
	API.post('/folder/', data)
	   .then(response => {
			galleryDispatcher.dispatch({
				action: CONSTANTS.ITEM_STORE.CREATE,
				type: CONSTANTS.SERVER_ACTION,
				data: response.body,
				silent: silent
			});
		});
}

This definitely starts to get verbose, and I would recommend creating some factories to generate these actions.
Minor bits

Consider removing var keywords in favour of const or let to provide some control over mutations
Consider using Babel stage 0 to allow class properties. This provides two very nice bits of syntactical sugar:

static propTypes = {

}

over MyClass.PropTypes = {}
and
myEventHandler = (e) => {

}

over this.myEventHandler = this.myEventHandler.bind(this);

Awesome - thanks for reviewing this!


Make node extrinsics feeless and remove fund_node hook

But for DIY, this opens up a 0 cost attack vector on the chain itself

agree but we don't have a plan to make nodes certified right now. I propose we change this in a later stage


Move Cypress directory and convert it to JavaScript

As tsc keep generating js files unexpectedly and this project is JavaScript based. It is good to standardized everything to one language.

[x] Convert to JS
[x] Move cypress into test/cypress

Related: #1780
FYI @tamasmagyar


Fixed problem creating Interval literals with full ranges

Type of change: bug fix

Impact: no functional change
Development Phase:  implementation

boundary testing was not taking binary point into account correctly
add tests to show where things work and where they are supposed to fail

Release Notes
A bug that affected could cause exceptions when creating intervals with range specifiers was fixed, e.g. val iLit = 6.0.I(range"[0,6]") would fail even though 6 is legal in that range.

Since this is a bugfix, should it be backported to 3.2.x?

If it needs (or is based on) intervals, it shouldn't be backported. Otherwise, I'd say yes, but let's get @chick's input.

Oh right, intervals are not in 3.2, nevermind!


tendermint-rs: bump to 0.23.5

Based on: https://github.com/oasisprotocol/oasis-core/pull/4481

Will be updated in https://github.com/oasisprotocol/oasis-core/pull/4480/files


not work feature #1693 on relation columns

Package
filament/tables
Package Version
2.11.0
Laravel Version
9.9.0
Livewire Version
2.6
PHP Version
8.1.2
Bug description
when using relational columns selectable not work corrcetly
for example i have products table with user.name column
Tables\Columns\TextColumn::make('user.name')->searchable()->sortable()->toggleable(),
when add toggable() on this column not work toggling
and one small improve to RTL version add one css class to dropdown : rtl:pl-0
Steps to reproduce
No response
Relevant log output
No response

This has been fixed by #2187 and will be in the next release.


Update StringType repr

Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN

Fill out the following pre-review checklist:

[ ] I am adding a new automated test(s) to verify correctness of my new code
[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency

Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.

@sfc-gh-aalam I'm very confused why this test failed from this change. It looks irrelevant to StringType.
FAILED tests/integ/test_udf.py::test_udf_timestamp_type_hint


Replace zlib with zlib-ng

Closes #707.
This change replaces the dependency on zlib with zlib-ng. This is a fork of zlib with improved performance, including support for hardware acceleration. It also adds tests to the CesiumUtility Gunzip implementation.

@kring zlib-ng is available in VCPKG as well.  Should I incorporate these changes into my VCPKG PR?

@jherico we haven't reviewed this yet, but I suspect it should be a pretty decent win with no downside, so I think yes, we'll want it in the vcpkg PR eventually. I don't want to create work for you when we haven't even given you the review we owe you yet, though!

Thanks @azrogers!


Refactor: Replace graphql-type-json with graphql-scalars

This should be non-breaking, as apps have graphql-type-json as dependency on their own. After merging this, the starter should also switch to graphql-scalars.

PR Checklist

[x] Verify if the change requires a changeset. See CONTRIBUTING.md

@nsams @johnnyomair now this targets next and I also included a changeset

Upgrad-Script: https://github.com/vivid-planet/comet-upgrade/pull/17


Added option to insert a chip when user hits space (similarly as enter).

Hi @mohbasheer,
This PR adds an option to add text to the chips from the moment the user presses space.
It makes the UI a bit more user friendly. Like in the case of email addresses (where space is forbidden anyway) the user can continue typing email addresses and on every space an email address will be added as a new chip.
Let me know what you think.
Koen

I may not check for next few days. Going for vacation I'll let you know.
Thanks Man
On Thu, Dec 22, 2016 at 12:02 AM koenvd<EMAIL_ADDRESS>wrote:

Hi @mohbasheer https://github.com/mohbasheer,
This PR adds an option to add text to the chips from the moment the user
presses space.
It makes the UI a bit more user friendly. Like in the case of email
addresses (where space is forbidden anyway) the user can continue typing
email addresses and on every space an email address will be added as a new
chip.
Let me know what you think.
Koen
You can view, comment on, or merge this pull request online at:
https://github.com/mohbasheer/angular-chips/pull/27
Commit Summary

Added option to insert a chip when user hits space (similarly as
enter).

File Changes

M dist/angular-chips.js
https://github.com/mohbasheer/angular-chips/pull/27/files#diff-0
(11)
M dist/angular-chips.min.js
https://github.com/mohbasheer/angular-chips/pull/27/files#diff-1 (2)
M src/js/directives/controls/chip_control.js
https://github.com/mohbasheer/angular-chips/pull/27/files#diff-2
(11)

Patch Links:

https://github.com/mohbasheer/angular-chips/pull/27.patch
https://github.com/mohbasheer/angular-chips/pull/27.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mohbasheer/angular-chips/pull/27, or mute the thread
https://github.com/notifications/unsubscribe-auth/AESlZ0GM7kK7Lzd_odZ5nGQTsYWvM6Gaks5rKU2NgaJpZM4LTGX_
.

I'll check and let you know.

Is this gonna get merged  ?

Sorry dude. Thanks for your effort.
I checked the code it's breaking some existing flow. Mostly I'll discard
this changes. I'll let you know the road map for the new changes if you are
interested you can contribute. But I can't do it immediately I'll be busy
with current project for next 4 weeks we can do after that. Thanks for your
time and effort.
On Thu, 13 Apr 2017 at 7:52 PM, jeson114<EMAIL_ADDRESS>wrote:

Is this gonna get merged ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mohbasheer/angular-chips/pull/27#issuecomment-293869438,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AESlZ1-91iyq3rZWFr2uCpBblZdIciIWks5rvgx_gaJpZM4LTGX_
.


Workaround 'go mod tidy' for Renovate PRs

Summary
This workaround means that 'go mod tidy' has to be executed manually once in a while.
Checklist

[x] Categorize the PR by setting a good title and adding one of the labels:
fix, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[x] Update documentation.
[x] Update tests.

With #98 this PR became obsolete


1 fps on Intel Integrated Graphics

This image says it all:

When using Intel Integrated Graphics I get 1 fps. If I used a proper GPU I assume I will get better FPS?

Yes, the ray tracer is designed to be executed on GPUs. Integrated graphics don't have enough power to render at interactive frame rates.


improve error handling flags to curl

current invocation is extremely fragile if tcp sockets are spuriously shutdown (this can happen when changing networks, or just due to a bad ISP)
--retry-all-errors is the only way to make curl robust against this type of failure.
targeted at master instead of staging since fetchurl uses fixed-output derivations, and thus changing it will not cause mass rebuilds.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I'm quite amenable to this change, because I've encountered flakiness in the area that has caused nixpkgs-review to fail, for instance. I've added @NixOS/stdenv as a reviewer since it's a fairly thorough change to expectations.


EmptyFixedStreamMessage.completionFuture() should be succeeded afte…

…r sending an HttpRequest
Motivation:
When an HttpClient sends an HttpRequest without its body, the completion future of the request cannot be succeeded because the HttpRequestSubscriber cancels the subscription after sending HTTP headers. In order to fix that, check whether any of onComplete or onError has been invoked when the request has been sent. If it has not been invoked, invoke subscription.request(1) in order to let the publisher have a chance to produce the last call.
Modifications:

Invoke subscription.request(1) one more time after the request has been sent.
Correct misbehavior of the write timeout timer.
Add HttpRequestSubscriberTest.

Thanks, reviewers!


HyperV support?

Hiya, thank you for publishing Vagrant boxes for macOS!
Would it be possible to offer HyperV provided boxes as well? Unfortunately, Docker in Windows relies on HyperV these days, and HyperV is unable to run concurrently with the VirtualBox hypervisor. In other words, developers working with Windows hosts must choose to boot with either HyperV enabled to run Docker, or else HyperV disabled to run VirtualBox and Vagrant. But if the macOS Vagrant boxes were integrated with the HyperV provider, then Windows users would be able to hack on Docker and Vagrant projects at the same time, without having to constantly reboot. What do you think?

macOS cannot be ran on Hyper-V. In addition, by license macOS cannot be ran on non-Apple hardware. I guess you could run Windows on an iMac and run Hyper-V on top of that, but you'd still have the problem of getting it to work in the first place.


Add a "What Does Thorn Do For You" section to the website

This should help clear up some misconceptions about what Thorn does and what you should use it for.

Things like:

Authentication, re-authentication, etc
User, and pre-existing data creation
Required field population
-- What does it do with the other fields?
Clean up (after the test, what does it do with the data?)
Anything else is does "automagically" for us?


Moved base vertex classing hiding outside of get_schema_from_schema_graph

We should have no reference to the OrientDB base vertex class name in get_graphql_schema_from_schema_graph.

No. If you put it None, you'll get a runtime error.
On Fri, May 17, 2019 at 9:48 AM bojanserafimov<EMAIL_ADDRESS>wrote:

@bojanserafimov commented on this pull request.
In graphql_compiler/init.py
https://github.com/kensho-technologies/graphql-compiler/pull/296#discussion_r285130589
:

@@ -184,16 +188,16 @@ def get_graphql_schema_from_orientdb_schema_data(schema_data, class_to_field_typ
(string -> {string -> GraphQLType}). Used to override the
type of a field in the class where it's first defined and all
the class's subclasses.

   hidden_classes: optional set of strings, classes to not include in the GraphQL schema.

   hidden_classes: set of strings, classes to not include in the GraphQL schema.

                   By default we hide the base OrientDB vertex class to make the schema

                   more syntactically sweet.

It's still optional set of strings
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kensho-technologies/graphql-compiler/pull/296?email_source=notifications&email_token=AFNYYYVZN75NL4W4HC67QI3PV2ZTDA5CNFSM4HNU7GG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBY64WAQ#pullrequestreview-238930690,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFNYYYQQPXGKFGBXY37LZDTPV2ZTDANCNFSM4HNU7GGQ
.


Feature/template selector command

version that only overrides necessary files to make updating spectate easier in the future

allows user to pick template only during spectate create
first creates default template, then overrides required files
also put templates into constants.js

Delete keys/token.json from ur branch 😂


Fixed #74 - Check types and values when creating Gravatar instances

Implemented the validations to check correct values and data types of the parameters of the Gravatar class also implemented the respective tests and modified an already existing test to expect an error.

Did some basic cleanup for the tests and decided to stop 2.7 support, merging now


Parameterize more of tikv over KvEngine for snapshots

What have you changed?
More engine abstraction. Part of https://github.com/tikv/tikv/issues/4184.
This builds off of https://github.com/tikv/tikv/pull/6122. New commits start at "snap_io: Use KvEngine bound instead of Snapshot ".
This fixes https://github.com/tikv/tikv/issues/6124 by getting rid of mutually-recursive associated types in engine_traits. It does so by adding a type parameter for the engine type to various traits. e.g. Snapshot is now
trait Snapshot<E> where E: KvEngine { }

and is implemented only for a specific engine. e.g.
impl Snapshot<RocksEngine> for RocksSnapshot { }

It makes more of tikv generic over engines.
What is the type of the changes?

Engineering (engineering change which doesn't change any feature or fix any issue)

How is the PR tested?
cargo test --all --no-run
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
no
Does this PR affect tidb-ansible?
no
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)

I'm just going to close this and wait until https://github.com/tikv/tikv/pull/6122 is merged to avoid needing re-reviews.


Add 1.3.8 and 3.0.0 to performance testing

Add 1.3.8 and 3.0.0 to performance testing  with http_logs as well as nyc_taxis workloads
Description
Describe what this change achieves.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #3255 (0b95395) into main (eaa92b5) will decrease coverage by 0.27%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main    #3255      +/-   ##
==========================================
- Coverage   91.72%   91.46%   -0.27%
==========================================
  Files         172      172
  Lines        4991     4991
==========================================
- Hits         4578     4565      -13
- Misses        413      426      +13

Impacted Files
Coverage Δ

src/system/temporary_directory.py
64.44% <0.00%> (-28.89%)
:arrow_down:

src/system/os.py
94.73% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Make primitive tests go back and forth, fix float params in imported functions

Adding tests that go back and forth makes the testing more robust, as it tests the interaction of a larger part of the system.
Addresses #180, but there is still more to do, for example generating a warning when an imported function takes f32/f64, or marking it as deprecated with a link to this issue.

I'm not sure if I can "pause" the PR, I've had an idea to encode the floats as integers to avoid the issue, since there is a conversion already going on with the WasmAbi::AbiType type.
But it's only being converted on the host and not in the plugin. Not sure if that is intentional or why is that.

Not entirely what you mean by encoding floats as integers? Do you intend to transmute the types?

Not directly transmute, but yes. I tried this:
impl WasmAbi for f32 {
    type AbiType = u32;

    #[inline]
    fn to_abi(self) -> Self::AbiType {
        u32::from_le_bytes(self.to_le_bytes())
    }

    #[inline]
    fn from_abi(value: Self::AbiType) -> Self {
        Self::from_le_bytes(value.to_le_bytes())
    }
}

but it didn't work. Wasmer fails at runtime, saying that the function signatures don't match:
---- test::primitives stdout ----
thread 'test::primitives' panicked at 'called `Result::unwrap()` on an `Err` value:
Link(Import("fp", "__fp_gen_import_primitive_f32_add_one",
IncompatibleType(Function(FunctionType { params: [I64], results: [F32] }),
Function(FunctionType { params: [I64], results: [I32] }))))',
src\spec\bindings.rs:29:63

After some digging, I found out that the WasmAbi type conversion is done only on host, but not in the plugin. I tried to draw it into a picture:

I don't know why the plugin "glue" code doesn't convert the primitive types to their abi types like the host code does. Maybe it is an oversight? What confuses me is that it works for bool, whose abi type is u8. I tried to change it to u16 and that works too. I guess wasmer converts it for you? I will have to try that.

Ok, more research showed me that the abi conversion is not needed on the plugin side, because bool is converted to u8 automatically. Somehow. Although it is done so by "modulo 2" rather than equality with 0, but I guess that doesn't matter.
So I see 2 options now:

Add the abi conversions on the plugin side as well. This would allow to pass floats and integers and bypass the wasmer float argument issue
Keep the code as it is, including the "array" workaround as an example of passing floats into an imported function

Ok, I have updated the PR. I have split the float methods into 2: one that uses the workaround, and one that doesn't:
fn import_primitive_f32_add_one(arg: f32) -> f32;
fn import_primitive_f64_add_one(arg: f64) -> f64;

fn import_primitive_f32_add_one_wasmer2(arg: [f32; 1]) -> f32;
fn import_primitive_f64_add_one_wasmer2(arg: [f64; 1]) -> f64;

fn export_primitive_f32_add_three(arg: f32) -> f32;
fn export_primitive_f64_add_three(arg: f64) -> f64;

fn export_primitive_f32_add_three_wasmer2(arg: f32) -> f32;
fn export_primitive_f64_add_three_wasmer2(arg: f64) -> f64;

but because all both the wasmer and deno runtimes are using the same protocol and plugin, i had to implement the "wasmer2 workaround" imported methods in the ts runtime as well. So I added tests for them too, because why not.
Also, I have updated the generated files, so it should look good now.

Please add a CHANGELOG entry (feel free to mention yourself ;)) and I'll merge it!

:tada:


S3 blobstore compiled_package_cache mixup

Describe the bug
Bosh versions newer than v270.10.0 confuse compiled_package_cache and blobstore when using s3 resource.
We attempt to deploy deployments in the same way as with previous Boshes but it says that it cannot find objects in it's blobstore (404 errors) during a deployment.
We have two buckets. One for compiled_package_cache, the other for the agent and the blobstore itself.
Bosh is able to pick up the objects from the compiled_package_cache (see extract below) but then after that it appears to get confused between it's actual blobstore (used by agent) and the compiled_package_cache.
To Reproduce
Steps to reproduce the behavior:

Deploy a bosh director on vSphere 6.5 with s3 backed compiled_package_cache, blobstore and agent env
Upload a release
Deploy a deployment using the release
Check the logs

Expected behavior
We would expect Bosh to use compiled_package_cache to download anything compiled and ready to go and use the blobstore for everything else
Logs
Successful grabbing of stuff from compiled_package_cache:
{"time":1590145487,"stage":"Preparing package compilation","tags":[],"total":1,"task":"Downloading ''golang-1-linux/f1e8a3f1bc4ef98c4fd7bed15b9e39e24c15cb413f827321da75d82d6bb6ab8c'' from global cache","index":3,"state":"started","progress":0} {"time":1590145491,"stage":"Preparing package compilation","tags":[],"total":1,"task":"Finding packages to compile","index":1,"state":"finished","progress":100}')
The later steps in the same task show an error when trying to retrieve the package that it's just downloaded from the package cache performing operation get: NoSuchKey: The specified key does not exist.
Versions (please complete the following information):

Infrastructure: vSphere
BOSH version: 271.0.0
BOSH CLI version: 5.3.1
Stemcell version: ubuntu-xenial/621.57
BOSH DNS: 1.21.0
Credhub: 2.6.0
UAA: 74.15.0
BPM: 1.1.7

Deployment info:
...
"blobstore":{"provider":"s3cli","options":{"bucket_name":"env.bucketname","credentials_source":"static","access_key_id":"env_our_amazing_id","secret_access_key":"env_secret_access_key","region":null,"enable_signed_urls":false,"host_style":false,"port":our_port,"host":"fqdn_of_internal_s3_resource","s3cli_config_path":"/var/vcap/data/director/tmp","s3cli_path":"/var/vcap/packages/s3cli/bin/s3cli"}}
...
"compiled_package_cache":{"provider":"s3cli","options":{"bucket_name":"compiled-package-cache","credentials_source":"static","access_key_id":"our_amazing_id","secret_access_key":"our_incredible_key","region":null,"s3cli_config_path":"/var/vcap/data/director/tmp","s3cli_path":"/var/vcap/packages/s3cli/bin/s3cli","port":our_port,"host":"fqdn_of_internal_s3_resource"}}
...
"agent":{"env":{"bosh":{"blobstores":[{"options":{"access_key_id":"env_our_amazing_id","bucket_name":"env.bucketname","credentials_source":"static","host":"fqdn_of_internal_s3_resource","port":our_port,"region":"us-east-1","secret_access_key":"env_secret_access_key"},"provider":"s3"}]

We use bosh-deployment manifests then apply our own ops files and interpolate values from various sources
Additional info
We've done bosh upload-release <thing_thats_borked> --fix and then re-ran but we still get the same errors.
It looks like Bosh is able to grab stuff from compiled_package_cache and then putting the blob for it back into the compiled_package_cache (incorrectly), which is utterly useless. When Bosh then wants to deploy, it looks in the main blobstore for the blob. It's not there. We get 404.
If we check the actual S3 buckets, we can see Bosh writing blobs to the wrong bucket (compiled_package_cache) instead of the actual blobstore.
Not sure what's caused this change in behaviour in more recent versions. If anyone has any Bosh secrets, please let us know.

At the moment the plan is to remove the compiled package cache entirely. If you want to weigh in on why you find it valuable, the discussion thread is here: https://lists.cloudfoundry.org/g/cf-bosh/topic/deprecating_global_compiled/71382035?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,71382035

Hi @mrosecrance, the plan is perfectly fine, however the shared compiled cache is not removed yet and the behaviour that @thelangley described breaks deployments. Is this considered a bug that can be fixed or due to the plan to remove shared cache it's
not gonna be fixed?

I think we'll remove it before wanting to address any bugs related to it.


Make changes required for building apko on top of base image.

This is a preparation to allow apko building on top of base image.

Allow ignoring signature for specific apk index - the one from the base image is not signed. We could sign it artificially, but perhaps explicitly ignoring is ok.
Add some tests for resolution to make sure some convoluted cases.
Fix apk index parsing - apko saves the apkindex file in a way that even if there are no provides / depends it still puts the empty value for p: and D: tokens. "".split(" ") results in one element array [""].
Split ResolveAndCalculateWorld into Resolve and Calculate so that apko can later add some logic in between. This is important, because Resolve operates on apk indexes only, while calculate fetches packages - this will not be possible for packages from base image, as some of them might be private.
Changed the InstalledPackage struct to have  []tar.Header instead of []*tar.Header. This makes it consistent with AddInstalledPackage arguments. Not strictly needed, can do conversions wherever needed instead.

@sfc-gh-ptabor @imjasonh - hopefully these are all changes needed in go-apk to make apko on top of base image.

Consider renaming the PR to: Initial refactorings for expanding base image support in apko
Please tag an issue that tracks this effort e2e in apko... to have references to all the PRs in a single place.


Allow for different variations of spaces when comparing license texts

When comparing license text, spaces and NBSP in the license XML work.  Other variations such as NNBSP will not match when comparing to normal ASCII spaces.
This is an enhancement request to allow the following Unicode characters to be considered equivalent to an ASCII space:

U+202F   NARROW NO-BREAK SPACE (HTML   · NNBSP)
U+2007   FIGURE SPACE (HTML  )
U+2060 WORD JOINER (HTML  · WJ)

Reference LicenseList-XML PR 925

Resolved by PR #205


Use pyfmaps instead of py fm

This replaces the import of pyFM from a forked branch of mine with the newly released PyPi installation.

Codecov Report
Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (b470f19) 44.00% compared to head (452e45b) 36.99%.
Report is 27 commits behind head on main.

Files
Patch %
Lines

src/napari_shape_odyssey/_spectral/expansion.py
15.62%
54 Missing :warning:

src/napari_shape_odyssey/_sample_data.py
6.45%
29 Missing :warning:

src/napari_shape_odyssey/_signatures/signatures.py
45.45%
6 Missing :warning:

src/napari_shape_odyssey/_spectral/spectral.py
77.77%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   44.00%   36.99%   -7.01%
==========================================
  Files          15       17       +2
  Lines         325      419      +94
==========================================
+ Hits          143      155      +12
- Misses        182      264      +82

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Sorting by Trader Buy on Peacekeeper Page Produces Random Result

Describe the Issue
Items sorted by Trade Buy on Peacekeeper's Trader page don't sort properly

Expected Behavior
Items should sort as expected
To Reproduce
Go to Peacekeeper trader page, sort by Trader Buy
Client
Desktop
Browser
Chrome
Relevant Console Log Output
No response
Extra Information
No response

Fixed with #643, thank you for reporting!


⚠ Bofrost.es has degraded performance

In 007f462, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1589 ms

Resolved: Bofrost.es performance has improved in d042ea5 after 10 minutes.


Performance is remarkably slower when passing bindings to query

Environment
Knex version: 3.0.1
Database + version: Azure SQL Database
OS: Windows 11
Select applicable template from below.
Bug
I am getting extremely slow response times when using knex with any kind of bindings. It does not matter if the bindings are used by knex.raw or knex query builder.
// Handle filtering
const query = knex<Reading>('Readings')
query.where('TeamID', '=', '1234')
// Here some additional filters are added
query.limit(pageSize).offset(offset)
query.select<Reading[]>(columnsToReturn)

console.time('KnexRawSQLQuery')
const sql = query.toSQL()
const rawSQLData = await knex.raw<Reading[]>(sql.sql, sql.bindings)
console.timeEnd('KnexRawSQLQuery') // 921ms

console.time('KnexRawQuery')
const rawData = await knex.raw<Reading[]>(query.toString())
console.timeEnd('KnexRawQuery') // 27ms

console.time('KnexQuery')
const data = await query
console.timeEnd('KnexQuery') // 926ms

The above time logs yield the following results:

KnexRawSQLQuery - 921ms
KnexRawQuery - 27ms
KnexQuery - 926ms

What kind of validation is happening when passing bindings to the query since the query takes ~34x longer to complete? Is there a way to optimize the usage of bindings?
The tests were conducted towards the same remote database, and the table contains around 375.000 rows.
If more information is needed please feel free to ask.

can you test the same with sqlite to see if it is db-specific?

+1

Can you please create a minimal reproduction with docker compose for the db + generate large mock data and I'll try to take a look


More test assertion

I wrote more assertions for existing test and some improvements

Hello @Ethical-Ralph
Thanks for taking out time to contribute to this package. Kindly resolve the conflict in the PR to enable us to review.

@Ethical-Ralph  any progress with resolving the conflict?


status_printer.h:53:38: error: ‘int64_t’ has not been declared

A recent change post v1.12.0 release has caused this build error:
Run docker exec -w /root/ninja multiarch cmake --build build
[  1%] Generating lexer.cc
[  2%] Generating depfile_parser.cc
[  4%] Building CXX object CMakeFiles/libninja-re2c.dir/depfile_parser.cc.o
[  5%] Building CXX object CMakeFiles/libninja-re2c.dir/lexer.cc.o
[  5%] Built target libninja-re2c
[  6%] Building CXX object CMakeFiles/libninja.dir/src/build_log.cc.o
[  8%] Building CXX object CMakeFiles/libninja.dir/src/build.cc.o
[  9%] Building CXX object CMakeFiles/libninja.dir/src/clean.cc.o
[ 10%] Building CXX object CMakeFiles/libninja.dir/src/clparser.cc.o
[ 12%] Building CXX object CMakeFiles/libninja.dir/src/dyndep.cc.o
[ 13%] Building CXX object CMakeFiles/libninja.dir/src/dyndep_parser.cc.o
[ 14%] Building CXX object CMakeFiles/libninja.dir/src/debug_flags.cc.o
[ 16%] Building CXX object CMakeFiles/libninja.dir/src/deps_log.cc.o
[ 17%] Building CXX object CMakeFiles/libninja.dir/src/disk_interface.cc.o
[ 18%] Building CXX object CMakeFiles/libninja.dir/src/edit_distance.cc.o
[ 20%] Building CXX object CMakeFiles/libninja.dir/src/eval_env.cc.o
[ 21%] Building CXX object CMakeFiles/libninja.dir/src/graph.cc.o
[ 22%] Building CXX object CMakeFiles/libninja.dir/src/graphviz.cc.o
[ 24%] Building CXX object CMakeFiles/libninja.dir/src/json.cc.o
[ 25%] Building CXX object CMakeFiles/libninja.dir/src/line_printer.cc.o
[ 27%] Building CXX object CMakeFiles/libninja.dir/src/manifest_parser.cc.o
[ 28%] Building CXX object CMakeFiles/libninja.dir/src/metrics.cc.o
[ 29%] Building CXX object CMakeFiles/libninja.dir/src/missing_deps.cc.o
[ 31%] Building CXX object CMakeFiles/libninja.dir/src/parser.cc.o
[ 32%] Building CXX object CMakeFiles/libninja.dir/src/state.cc.o
[ 33%] Building CXX object CMakeFiles/libninja.dir/src/status_printer.cc.o
In file included from /root/ninja/src/status_printer.h:19,
                 from /root/ninja/src/status_printer.cc:15:
/root/ninja/src/status.h:29:33: error: ‘int64_t’ has not been declared
   29 |                                 int64_t start_time_millis) = 0;
      |                                 ^~~~~~~
/root/ninja/src/status.h:30:46: error: ‘int64_t’ has not been declared
   30 |   virtual void BuildEdgeFinished(Edge* edge, int64_t start_time_millis,
      |                                              ^~~~~~~
/root/ninja/src/status.h:31:34: error: ‘int64_t’ has not been declared
   31 |                                  int64_t end_time_millis, bool success,
      |                                  ^~~~~~~
/root/ninja/src/status_printer.h:30:51: error: ‘int64_t’ has not been declared
   30 |   virtual void BuildEdgeStarted(const Edge* edge, int64_t start_time_millis);
      |                                                   ^~~~~~~
/root/ninja/src/status_printer.h:31:46: error: ‘int64_t’ has not been declared
   31 |   virtual void BuildEdgeFinished(Edge* edge, int64_t start_time_millis,
      |                                              ^~~~~~~
/root/ninja/src/status_printer.h:32:34: error: ‘int64_t’ has not been declared
   32 |                                  int64_t end_time_millis, bool success,
      |                                  ^~~~~~~
/root/ninja/src/status_printer.h:50:36: error: ‘int64_t’ has not been declared
   50 |                                    int64_t time_millis) const;
      |                                    ^~~~~~~
/root/ninja/src/status_printer.h:53:38: error: ‘int64_t’ has not been declared
   53 |   void PrintStatus(const Edge* edge, int64_t time_millis);
      |                                      ^~~~~~~
/root/ninja/src/status_printer.h:60:3: error: ‘int64_t’ does not name a type
   60 |   int64_t time_millis_ = 0;
      |   ^~~~~~~
/root/ninja/src/status_printer.h:20:1: note: ‘int64_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
   19 | #include "status.h"
  +++ |+#include <cstdint>
   20 |
/root/ninja/src/status_printer.h:63:3: error: ‘int64_t’ does not name a type
   63 |   int64_t cpu_time_millis_ = 0;
      |   ^~~~~~~
/root/ninja/src/status_printer.h:63:3: note: ‘int64_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
/root/ninja/src/status_printer.h:71:3: error: ‘int64_t’ does not name a type
   71 |   int64_t eta_predictable_cpu_time_total_millis_ = 0;
      |   ^~~~~~~
/root/ninja/src/status_printer.h:71:3: note: ‘int64_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
/root/ninja/src/status_printer.h:76:3: error: ‘int64_t’ does not name a type
   76 |   int64_t eta_predictable_cpu_time_remaining_millis_ = 0;
      |   ^~~~~~~
/root/ninja/src/status_printer.h:76:3: note: ‘int64_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
/root/ninja/src/status_printer.h:102:38: error: ‘int64_t’ has not been declared
  102 |     void UpdateRate(int update_hint, int64_t time_millis) {
      |                                      ^~~~~~~
/root/ninja/src/status_printer.cc: In member function ‘virtual void StatusPrinter::EdgeAddedToPlan(const Edge*)’:
/root/ninja/src/status_printer.cc:63:5: error: ‘eta_predictable_cpu_time_total_millis_’ was not declared in this scope
   63 |     eta_predictable_cpu_time_total_millis_ += edge->prev_elapsed_time_millis;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.cc:64:5: error: ‘eta_predictable_cpu_time_remaining_millis_’ was not declared in this scope
   64 |     eta_predictable_cpu_time_remaining_millis_ +=
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.cc: In member function ‘virtual void StatusPrinter::EdgeRemovedFromPlan(const Edge*)’:
/root/ninja/src/status_printer.cc:77:5: error: ‘eta_predictable_cpu_time_total_millis_’ was not declared in this scope
   77 |     eta_predictable_cpu_time_total_millis_ -= edge->prev_elapsed_time_millis;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.cc:78:5: error: ‘eta_predictable_cpu_time_remaining_millis_’ was not declared in this scope
   78 |     eta_predictable_cpu_time_remaining_millis_ -=
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.cc: At global scope:
/root/ninja/src/status_printer.cc:84:6: error: no declaration matches ‘void StatusPrinter::BuildEdgeStarted(const Edge*, int64_t)’
   84 | void StatusPrinter::BuildEdgeStarted(const Edge* edge,
      |      ^~~~~~~~~~~~~
/root/ninja/src/status_printer.h:30:16: note: candidate is: ‘virtual void StatusPrinter::BuildEdgeStarted(const Edge*, int)’
   30 |   virtual void BuildEdgeStarted(const Edge* edge, int64_t start_time_millis);
      |                ^~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.h:23:8: note: ‘struct StatusPrinter’ defined here
   23 | struct StatusPrinter : Status {
      |        ^~~~~~~~~~~~~
/root/ninja/src/status_printer.cc: In member function ‘void StatusPrinter::RecalculateProgressPrediction()’:
/root/ninja/src/status_printer.cc:109:29: error: ‘eta_predictable_cpu_time_remaining_millis_’ was not declared in this scope
  109 |                             eta_predictable_cpu_time_remaining_millis_;
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.cc:115:8: error: ‘time_millis_’ was not declared in this scope
  115 |       (time_millis_ >= 15 * 1e3) &&
      |        ^~~~~~~~~~~~
/root/ninja/src/status_printer.cc:119:17: error: ‘cpu_time_millis_’ was not declared in this scope
  119 |         (double)cpu_time_millis_ / finished_edges_;
      |                 ^~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.cc:122:17: error: ‘eta_predictable_cpu_time_total_millis_’ was not declared in this scope
  122 |         (double)eta_predictable_cpu_time_total_millis_ /
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.cc:147:46: error: ‘cpu_time_millis_’ was not declared in this scope
  147 |   int64_t edges_known_runtime_total_millis = cpu_time_millis_;
      |                                              ^~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.cc: At global scope:
/root/ninja/src/status_printer.cc:176:6: error: no declaration matches ‘void StatusPrinter::BuildEdgeFinished(Edge*, int64_t, int64_t, bool, const std::string&)’
  176 | void StatusPrinter::BuildEdgeFinished(Edge* edge, int64_t start_time_millis,
      |      ^~~~~~~~~~~~~
/root/ninja/src/status_printer.h:31:16: note: candidate is: ‘virtual void StatusPrinter::BuildEdgeFinished(Edge*, int, int, bool, const std::string&)’
   31 |   virtual void BuildEdgeFinished(Edge* edge, int64_t start_time_millis,
      |                ^~~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.h:23:8: note: ‘struct StatusPrinter’ defined here
   23 | struct StatusPrinter : Status {
      |        ^~~~~~~~~~~~~
/root/ninja/src/status_printer.cc:275:8: error: no declaration matches ‘std::string StatusPrinter::FormatProgressStatus(const char*, int64_t) const’
  275 | string StatusPrinter::FormatProgressStatus(const char* progress_status_format,
      |        ^~~~~~~~~~~~~
/root/ninja/src/status_printer.h:49:15: note: candidate is: ‘std::string StatusPrinter::FormatProgressStatus(const char*, int) const’
   49 |   std::string FormatProgressStatus(const char* progress_status_format,
      |               ^~~~~~~~~~~~~~~~~~~~
/root/ninja/src/status_printer.h:23:8: note: ‘struct StatusPrinter’ defined here
   23 | struct StatusPrinter : Status {
      |        ^~~~~~~~~~~~~
/root/ninja/src/status_printer.cc:419:6: error: no declaration matches ‘void StatusPrinter::PrintStatus(const Edge*, int64_t)’
  419 | void StatusPrinter::PrintStatus(const Edge* edge, int64_t time_millis) {
      |      ^~~~~~~~~~~~~
/root/ninja/src/status_printer.h:53:8: note: candidate is: ‘void StatusPrinter::PrintStatus(const Edge*, int)’
   53 |   void PrintStatus(const Edge* edge, int64_t time_millis);
      |        ^~~~~~~~~~~
/root/ninja/src/status_printer.h:23:8: note: ‘struct StatusPrinter’ defined here
   23 | struct StatusPrinter : Status {
      |        ^~~~~~~~~~~~~
gmake[2]: *** [CMakeFiles/libninja.dir/build.make:356: CMakeFiles/libninja.dir/src/status_printer.cc.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:208: CMakeFiles/libninja.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2
Error: Process completed with exit code 2.

I use MCM to build statically linked binaries against muslc built on Alpine Linux.
It said that this commit looks to be the culprit:

looks like just a missing include of stdint.h/cstdint @ #musl

https://github.com/ninja-build/ninja/commit/da11ea219bd05cfa884c48a748fb0734d08305a1

If you want to avoid having to open such an issue in the future, contribute a GitHub Action that builds with musl :)

yes


Space Hub App

In this pull request, We will be working with the real live data from the SpaceX API. Our task is to build a web application for a company that provides commercial and scientific space travel services.

Learning objectives :

Use React documentation
Use React components
Use React props
Use React Router
Connect React and Redux
Handle events in a React app
Write unit tests with React Testing Library
Use styles in a React app
Use React hooks
Apply React best practices and language style guides in code
Use store, actions and reducers in React
Perform a code review for a team member

Screenshots

Thank you


Merge master into dev

Hey @samtstern, I accidentally merged master into all my PRs so merging this one will simplify the diffs quite a bit.

No problem. (I do remember GitHub being smart enough to know when a merge from the CLI is pushed to close the PR automatically, hence me making this one. 🤷♂)


Samplegen: Java sample enhancements

Fix #2554

@vchudnov-g PTAL

PTAL @vchudnov-g

Codecov Report

Merging #2555 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2555      +/-   ##
============================================
- Coverage     86.59%   86.59%   -0.01%
+ Complexity     5496     5494       -2
============================================
  Files           464      463       -1
  Lines         21699    21686      -13
  Branches       2383     2382       -1
============================================
- Hits          18790    18778      -12
  Misses         2047     2047
+ Partials        862      861       -1

Impacted Files
Coverage Δ
Complexity Δ

.../transformer/java/JavaSampleImportTransformer.java
89.88% <ø> (ø)
25 <0> (ø)
:arrow_down:

...codegen/viewmodel/SampleFunctionParameterView.java

...e/api/codegen/transformer/InitCodeTransformer.java
94.56% <0%> (+0.09%)
100% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2bcbc4...d75e5e9. Read the comment docs.

Codecov Report

Merging #2555 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2555   +/-   ##
=========================================
  Coverage     86.59%   86.59%
  Complexity     5494     5494
=========================================
  Files           463      463
  Lines         21686    21686
  Branches       2382     2382
=========================================
  Hits          18778    18778
  Misses         2047     2047
  Partials        861      861

Impacted Files
Coverage Δ
Complexity Δ

.../transformer/java/JavaSampleImportTransformer.java
89.88% <ø> (ø)
25 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1071950...41a532a. Read the comment docs.

I'll merge it now to catch an artman release. We can adjust the comments in future PRs.


Run SonarCloud only on pull requests to master

Run SonarCloud less often to reduce build times for normal CI builds.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: eborquez sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

i


Support BitBucket issue tracker

Describe the solution you'd like
We’re migrating from HockeyApp which supports BitBucket as an issue tracker.
Appcenter doesn’t support BitBucket for issue tracking but all of our code and issues are on BitBucket. This is really important for a smooth migration.
To make matters worse, the current HockeyApp integration with BitBucket is failing due to API changes…
Describe alternatives you've considered
None.

Thanks for the feature request! We don't have immediate plans to address add support for BitBucket but I'll keep the issue open to track interest. We understand this is an important feature and I'll post here if I have any updates.

Just wanted to add my +1 to thi, and also note that's a bit odd you support Bitbucket for source control but not issues.
PS: HockeyApp had support for issues as well.


Original qbcore character select overlaps

as you can see the original ui is still there, any way to fix this without breaking any other game mechanics?


cmd/dist: Consider using "git describe" for "go version" string

The current code for VERSION.cache results in output like
$ go version
go version devel +2937d88 2014-12-09 22:08:45 +0000 linux/amd64

Many git projects use git describe for this. For example, Git itself has https://github.com/git/git/blob/master/GIT-VERSION-GEN#L15 which, adjusted to lightweight tags and a different naming convention, would lead to:
$ git describe --tags --match "go[0-9]*" --abbrev=7 HEAD 2>/dev/null
go1.4beta1-394-g2937d88

Or even noting uncommitted changes:
$ git describe --tags --match "go[0-9]*" --abbrev=7 --dirty=+ 2>/dev/null
go1.4beta1-394-g2937d88+

As part of cmd/dist, it could look something like this:
$ go version
go version devel go1.4beta1-394-g2937d88+ linux/amd64

and this would also seem to make the explicit branch logic in src/cmd/dist/build.c unnecessary, as "git describe" can already look for tags.
This is useful (to me, at least) because it immediately communicates more than just that sha1 in the original; it tells me what tag I'm near, how far away from it I am, it includes the sha1 from earlier, and then can even mark dirty working trees so I know to suspect my build to be tainted.

The hash and date seems fine. Not worth changing.


#115 [SPANS] Made underlineOffset compatible with the box-sizing: border-box

Issue
See - https://github.com/recogito/text-annotator-js/issues/115
Changes Made

~Replaced offset definition using the paddingBottom with the height. In that way, the height of the highlight span will get properly extended both using the content-box and border-box.~, see https://github.com/recogito/text-annotator-js/pull/116#issuecomment-2213215373
Added box-sizing: border-box reset to the test examples

Disclaimer
Most of the changes come from the IDE's formatted that applied 2 space indentation to the test files. To see only meaningful differences - hide the whitespace diff:

I might be missing something here. But isn't that just a different way to achieve the same result? Either you apply height + padding, or use box-sizing: border-box and change the height. If we want to protect against an external stylesheet unintentionally setting border-box on the highlight layer element, we should probably just give it box-sizing: content-box explicitely?

I might be missing something here. But isn't that just a different way to achieve the same result?

Yeah, it is. The box-sizing: border-box is just a more widespread and intuitive sizing approach.

on the highlight layer element, we should probably just give it box-sizing: content-box explicitly?

However, I think that this suggestion makes sense, and applying box-sizing: content-box to the .r6o-annotation will our needs

I think this can be closed in favor of https://github.com/recogito/text-annotator-js/commit/dbdbf86b3d09e8db17ce7e21ceed6477e953078f?

I think this PR can still be beneficial for:

Traceability of the changes. It explicitly describes that we intend to support the content-box
Makes the border-box a default for the test pages, which is relevant for the prevailing majority of the consumers
Applied the IDE's autoformatting and frees me from constantly tweaking it 😅


Nginx Ingress goes down after updates for config

Hello there, I faced with an issue for Nginx ingress. I need to add some config to the nginx pod and I used kubeprod-manifest.jsonnet.
// Cluster-specific configuration (import "https://releases.kubeprod.io/files/v1.6.1/manifests/platforms/aks.jsonnet") {         config:: import "kubeprod-autogen.json",         // Place your overrides here          nginx_ingress+: {            config+: {                data+: {                    "proxy-body-size": "20m",                },            },          },          prometheus+: {            storage:: 32768,          } }
I applied this manifest with kubeprod install aks ...
And received an error from Prometheus like
ERROR Error: Error updating statefulsets kubeprod.prometheus: StatefulSet.apps "prometheus" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', and 'updateStrategy' are forbidden
and more importantly I couldn't load kibana, grafana or prometheus page anymore from my domain

Could you suggest something here?

Hello there, maybe this output from Nginx ingress could help
` - - [09/Dec/2020:07:21:47 +0000] "GET /oauth2/auth HTTP/1.1" 401 21 "-" "Mozilla/5.0 [kubeprod-oauth2-proxy-4180] [] 102:4180 21 0.004 401 4549f29063eb6dc6533b9
2020/12/09 07:21:47 [alert] 23#23: worker process 19880 exited on signal 11 (core dumped)
[09/Dec/2020:07:23:03 +0000] "GET / HTTP/2.0" 404 19 "https://kibana.myhost.net/" "Mozilla/5.0 [kubeprod-oauth2-proxy-4180] [] :4180 19 0.004 404 1d5dc91c49e70943d64
2020/12/09 07:23:03 [alert] 23#23: worker process 20417 exited on signal 11 (core dumped)

[09/Dec/2020:07:23:19 +0000] "GET /oauth2/auth HTTP/1.1" 202 0 "-" [kubeprod-oauth2-proxy-4180] [] :4180 0 0.004 202 0574d8a22bf443586a46f8dd53
terminate called after throwing an instance of 'std::logic_error'
what():  basic_string::_M_construct null not valid
2020/12/09 07:23:20 [alert] 23#23: worker process 19846 exited on signal 6 (core dumped)

[09/Dec/2020:07:23:20 +0000] "GET /oauth2/auth HTTP/1.1" 202 0 "-" " [kubeprod-oauth2-proxy-4180] [] 2:4180 0 0.004 202 3081e55b59b3aac1b86b32
terminate called after throwing an instance of 'std::logic_error'
what():  basic_string::_M_construct null not valid
2020/12/09 07:23:20 [alert] 23#23: worker process 20457 exited on signal 6 (core dumped)
`

Hi,
I am afraid that, in the case of statefulsets, not all parameters can be edited after deploying (immutable fields). In this kind of cases, you may need to remove and redeploy the prometheus statefulset in order to work. About the other issue, could you show the status of all the deployed pods?

Hi @javsalgar, regarding prometheus I used doc from this repo here is the link https://github.com/bitnami/kube-prod-runtime/blob/master/docs/components.md#override-storage-parameters
But, in any case, the second problem is more important for me.
kubectl get pods -n kubeprod --kubeconfig ~/.kube/config_prod  NAME                                        READY   STATUS      RESTARTS   AGE alertmanager-0                              2/2     Running     0          5d cert-manager-6cd798c5fb-hq6kb               1/1     Running     1          5d elasticsearch-curator-1607595000-np7x4      0/1     Completed   0          4d11h elasticsearch-curator-1607681400-hq77x      0/1     Completed   0          3d11h elasticsearch-curator-1607767800-bvb8l      0/1     Completed   0          2d11h elasticsearch-curator-1607854200-2bp22      0/1     Completed   0          35h elasticsearch-curator-1607940600-wmngm      0/1     Completed   0          11h elasticsearch-logging-0                     2/2     Running     0          5d elasticsearch-logging-1                     2/2     Running     0          5d elasticsearch-logging-2                     2/2     Running     0          5d external-dns-77f88c88b4-hkm94               1/1     Running     0          5d fluentd-es-kbs44                            1/1     Running     41         5d fluentd-es-ktltz                            1/1     Running     49         5d fluentd-es-lrm5g                            1/1     Running     47         5d fluentd-es-swpdg                            1/1     Running     1          5d grafana-0                                   1/1     Running     0          5d kibana-595959859f-4h8w5                     1/1     Running     0          5d kube-state-metrics-659b5b4889-2tsxw         2/2     Running     0          5d nginx-ingress-controller-56c8d9c74b-7jrnw   1/1     Running     0          5d nginx-ingress-controller-56c8d9c74b-7r5vp   1/1     Running     0          5d node-exporter-4b45g                         1/1     Running     0          5d node-exporter-f4qhr                         1/1     Running     0          5d node-exporter-qxw2d                         1/1     Running     0          5d node-exporter-xxzgb                         1/1     Running     0          5d oauth2-proxy-688c59b975-8pzfh               1/1     Running     0          5d oauth2-proxy-688c59b975-crqn5               1/1     Running     0          5d prometheus-0                                2/2     Running     0          5d
There everything is up and running, but ingress doesn't work. It works partially. I can authorise myself with auth.mydomain.com. And after that, I could load kibana or grafana pages but always receive those errors like in my screenshot. I had similar before and only one thing helped - reinstalling all k8s cluster. How to rebuild or reconfigure ingress without reinstalling all cluster? Thanks

Could you provide the Kibana and Grafana logs to see if there's anything meaningful?

I could connect to Grafana or Kibana with kubectl port-forwarding from my local PC. I can see logs for all pods in kibana. The problem is that I couldn't connect that stuff trough ingress. Not only app from kubeprod namespace also our app through ingress. With port-forwarding everything works. Output from Nginx  you already have seen in previous comments. What logs are you interested in? Pod?

For example, if you try to open kibana.myhost.com with a clean browser. You couldn't do that. Nginx doesn't redirect to the authorization page for some reason.

Hi,
Indeed, it seems that the nginx process could be crashing for some reason
2020/12/09 07:23:03 [alert] 23#23: worker process 20417 exited on signal 11 (core dumped)

Did you try installing it with the default values and it worked? That could help us get to the exact configuration value that is making nginx crash.

Hi,
The problem is that if I delete everything with
kubecfg delete kubeprod-manifest.jsonnet
And install with a clean configuration with
kubeprod install aks .... I'll get the same behaviour for ingress.
The only way is to delete the AKS cluster and create a new one. After that, I can install BKPR with even customized values.
But if I want to add something later I can't do that due to that ingress behaviour. I got the same result after 3 attempts.

Hello there, As I see it is difficult to find the reason for my problem. Does somebody use BKPR with AKS?


PS4 Remote Play don't kill process when controller is emulated

Create settings.xml file, and put this line inside:
true
After injection PS4 Remote Play process won't kill itself when you hit the X button in the upper right corner.

Hi, please provide the full contents of your settings.xml file.

true
true
true

https://pastebin.com/Qf5jiZeC