Support rxjava , kotlin flow and livedata in the database.

Is your feature request related to a problem? Please describe.

Currently we don't use any of the wrappers  ( i.e. rxjava, kotlin flow, livedata etc.)
Describe the solution you'd like

Add support for these because they'll make development for the consumer considerably easier, since room will automatically update the data when new data is added to the database.
Additional context

I think datastore does have something similar. Also this could be a low / medium priority since it isn't a necessity at the moment and would require significant restructuring of the api.
Would you like to work on the issue?

Maybe, after discussion with the code owners.

I ran benchmarks and it seems that flow and live data actually perform better than the standard List return type, although I did use an emulator with unlocked clocks so this may not be entirely accurate (I do not have access to a physical device at the time). Also, even if adding flows/livedata does slightly affect the performance I think the tradeoff would definitely be worth it. cc @f-odhiambo @jingtang10

@yigit @florina-muntenescu @kevinmost @stevenckngaa
Wonder if this is something that you expected - and if you have any general advice on this

I would prefer to avoid this until we have a client blocked by it.
Crafting these wrappers is not an easy API work and requires constant maintenance going forward. For cases were it is straightforward, there are compatibility artifacts that can be used by clients.


Enable individual LUTs

This PR introduces the capability of computing individual correction LUTs by exposing Boolean flag in the schema for each individual correction.
TO DO:

Modify the stack processor to enable/disable individual corrections
Solve QA computation for weather model troposphere

The s1_geocode_stack.py will have to be changed to: https://github.com/vbrancat/COMPASS/blob/single_lut/src/compass/s1_geocode_stack.py#L287 this one currently will make invalid YAMLs by having the single bool... not sure if we really want to expose all 6 on/off options to that script though. That seems excessive, especially if we expect most people will want the corrections (assuming they all improve things)

The paths from my changes are a mess. I'll fix them as soon as #148 gets merged into main as I see no point in fixing them now and after another merge with main.


feat: add citation file

Adding citation file as requested.
@matthewfeickert could you check if I did this correctly?
We decided to not name anyone in the citation directly but take everyone in by mentioning the contributors.
Closes #891

lol. atlantis bot is going wild!

@matthewfeickert Thanks for the review!
I was wondering, do you use a tool to update the versions everywhere when you want to do a release, or is it just search and replace?

I was wondering, do you use a tool to update the versions everywhere when you want to do a release, or is it just search and replace?

Yes. In pyhf we use tbump to bump the versions everywhere in the code base as part of the release process.

pyhf's tbump.toml
pyhf's bump version GitHub Actions workflow (most relevant bit is here)

He @matthewfeickert,
Thanks a lot for your input, I'm a little uncomfortable with the version stuff that's why I procrastinated this PR a little, sorry for that. I'll work on automating the bumping in a different PR as nothing about the release is automated currently but it is high on my radar.

Sounds great @ruben-arts. Nothing to apologize for on your end though. I think it is very nice that this is being looked at period, so I don't think you should feel any timeline pressure here. :+1:


indexer-agent: Indexer rules update triggers immediate deployment allocation reconciliation

Currently indexing rule updates do not immediately trigger reconciliation and the delayed response causes distrust of the agent and encourages taking actions outside the agent.  Rule change events should lead to immediate reconciliation and, if applicable, on-chain action.

@fordN any idea on how this will be addressed?
IMO, the largest issue with this delayed response is with on-chain events (closing / opening allo's). If there is a lot of required work to make the rule change events immediate, could an interim solution be to have the agent default: 120_000 ms loop time configurable as seen in this update to the service nodes (https://github.com/graphprotocol/indexer/pull/229/commits/568df2610f25e4b56c837e05defd696b9d780f58) ?
Would there be any negative effects to making the reconciliation loop quicker as opposed to the 2 minutes?

@Aderks this issue has been resolved with the merging of #352 and will be included in the next release.


Feature: allow custom description after helm release upgrade

Feat(helm): allow custom description after helm release upgrade. Fixes #3581
Signed-off-by: Arash Deshmeh<EMAIL_ADDRESS>

@thomastaylor312  Thank you for the review. I can submit PRs for those two commands as well if needed.

@adshmh I think it would belong in this PR since it is the same feature. Are you ok with pushing another commit adding this for the two other commands?

@thomastaylor312 sure, I just updated the PR to include delete and rollback commands as well.

Rebased the PR to resolve the conflicts.
@bacongobbler would appreciate it if you could take a look.


fix: update private changed for liveview 0.19.0 (closes: #8)

This resolves the incompatibility introduced in LiveView 0.19.0.
Closes #8

The new logic pushed us over Credo's complexity limit. Any preference on how to resolve this? Maybe splitting the logic to find the {events, merged?} out to a separate helper function?

Hi @dfalling,
I think we can resolve it indeed by extracting some private helper functions.
  defp put_event(socket, events) when is_map_key(socket.private, :__changed__)
  defp put_event(socket, events) when is_map_key(socket.private, :__temp__)

And the event reducer too.
  defp event_reducer(["hd", %{c: changes}], _merged?, query, change),
     do:  {["hd", %{c: push_or_merge_head_change(changes, query, change)}], true}

  defp event_reducer(event, merged?, _query, _change),
      do: {event, merged?}

Could you give it a try? :)

@dfalling Thanks for your contribution!

Sure thing, thanks for the great lib!


No wheels for Python 3.11 and 3.12

Currently there are no wheels for Python 3.11 and 3.12. Would it be possible to add those to cibuildwheel.yml?

Hi @jsolbrig !
Thanks for reaching out, of course we can add newer versions!
Would you like to add those and open a PR?
Best,
@sbrodehl

I have added the newer python versions.
Please let me know if you need anything else!
Best,
@sbrodehl

@sbrodehl Thank you! I had actually forked and implemented, but found that my jobs weren't being picked up so I couldn't test what I did.


Analyzer error when doing constructor tear-off

class A {
  A(int i);
}

void main() {
  // these are ok (but dart lint encourages tear-off)
  [].map((e) => A(e));
  [].map((e) => A.new(e));

  // this is an error: The argument type 'A Function(int)' can't be assigned to the parameter type 'dynamic Function(dynamic)'.
  [].map(A.new);
}

This is correct behavior.
The error is correct. The torn off constructor cannot take any value as argument, so it cannot be used as a function with dynamic as parameter type.
Wrapping in (e) => …(e) seems like it should do nothing, but due to type inference, the type inferred for e is actually dynamic, what is then implicitly downcast where is used.
If you had written it as (dynamic e) => A(e as int), it would be clearer that it isn't just forwarding the argument to the constructor, but it's a different function, with different typing, than the tear-off.

Good catch!
It looks  like unnecessary_lambdas is wrongly linting these cases:
  [].map((e) => A(e));
  [].map((e) => A.new(e));

and that we should fix these false positives in the linter.
Thanks for the report @MohiuddinM!


Missing packages

The following can be used to obtain a list of all packages that are available via PyPI:
with ServerProxy(index) as client:
    packages = client.list_packages()

For some packages the site and the json is missing. Why is that so? Is that because packagers remove their package but it doesn't disappear entirely from the database?
Example xlrd3k
I was using the following index https://pypi.org/pypi

I think the JSON and page 404's when the package doesn't have any releases and is just registered.

That seems like a plausible reason. Do you know of a method/call to tell whether this is indeed the case?
I have a script that fetches the JSON of each package and stores it. When updating the database the script retries those packages that failed the previous time.

@dstufft
I would have thought there'd be empty mapping for json and some sort of placeholder page saying that this package is registered but does not have any releases?
Is there any specific reason it's not this way?
PS: Is this something I should try doing?

Closing because this is likely then a duplicate of https://github.com/pypa/warehouse/issues/1388.

Indeed.

Is there any specific reason it's not this way?

It seems no one came about to doing it.


🔄 synced file(s) with worgarside/github-config-files

synced local file(s) with worgarside/github-config-files.

This PR was created automatically by the repo-file-sync-action workflow run #11800831517

This PR is empty, closing it. :no_good:


Scheme list

Lists a local authorities schemes on the home recycling page.
This currently only lists dry schemes until the API for grouping schemes by property type is in, a separate issue has been created to update this later.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Remove internal information from the README

In the README we list the symbols we support, but we also list the internal Puppet Pops type.  Users don't actually know what that is, indeed most people don't care.
I think it should be removed, and just list the common names e.g.
Supported symbols are Class, Defined Types, Attributes and Variables
Instead of;
Supported symbols:

Symbol
Puppet Class

Class
Puppet::Pops::Model::HostClassDefinition

Defined Type
Puppet::Pops::Model::ResourceTypeDefinition

Attribute
Puppet::Pops::Model::AttributeOperation

Variable
Puppet::Pops::Model::AssignmentExpression

Interested in your opinion @michaeltlombardi

I concur with removing the puppet class information, only the symbols really matter to the end user.

Complete


Added callback for when item drag position is changed.

Hi,
I added a callback that provides the user with information when an item is dragged to a new position. I use this to hide dialogs and do any work needed while the items are moving.

Hi! Thanks, I'll take a look at this PR on this weekend ;)

LGTM. Thanks!


Fix it

Hi @osilverstein, This is a significant update that addresses many issues. I really appreciate the effort. Thank you!

Hi @osilverstein, This is a significant update that addresses many issues. I really appreciate the effort. Thank you!

Ah that is my bad. That is a mistake. Unfortunately, very little code here would work in any other environment due to our infra being split.
Additionally, the code is of poor quality and represents our research and is not production ready.
Sorry!


Maximum Selection Size

Allow the developer to limit the number of items that can be selected in a multi-select control.

+1

+1

+1

+1

+1

If anyone wants to have a max limit, see the following comment:
https://github.com/angular-ui/ui-select/pull/348#issuecomment-63736469

+1

+1

+1

+1

+1

+1

+1

#1110

Should be solved with https://github.com/angular-ui/ui-select/pull/1110


Publish javadoc & sources of 0.13

It seems something went wrong during the publication of 0.13 to the bintray repository. The sources jar is missing:
https://jcenter.bintray.com/io/moquette/moquette-broker/0.13/
Though I just noticed they are also missing for 0.12.
0.11 does have sources.

Fixed with commit https://github.com/moquette-io/moquette/commit/3f54b59688d237896145ddfd00b1aaf3afbf0489


Windows Plugins presubmit is failing on flutter/plugins

New PRs to flutter/plugins are getting a failed "Windows Plugins" presubmit, the cirrus link directs to the flutter dashboard which has no useful information.
Sample PRs with the failure:

https://github.com/flutter/plugins/pull/3220
https://github.com/flutter/plugins/pull/3213

This is currently blocking all flutter/plugins PRs.

This is because now Windows build_tests are competing for the same bots used by plugins. To fix this problem we need to:

First move capacity from the windows 10 machines to windows server.
Move all framework-luci devicelab tests to use windows server.
Move all framework builds to use windows server.

based on competition, shall the plugins builds remain in the queue rather than directly fail?

I thought they were failing after a few mins, the ones linked here are failing immediately which means there are 0 Windows Server machines available

https://chromium-swarm.appspot.com/botlist?c=id&c=task&c=os&c=status&d=asc&f=pool%3Aluci.flutter.try&f=os%3AWindows-Server&k=os&s=id I see machines available.
I would expect long queue time but not seeing failures immediately.

Are all these windows bots the same config of 8 cores? We used to have 32 cores bots, which flutter/plugins are currently using.

The windows machines got downgraded yesterday to use 8 cores. We need to remove the explicit dimension for 32 cores

Working on a PR to fix this.

Meta-issue question: can we make the bot status page linked from PRs give useful feedback here (e.g., "Unable to schedule job; zero available machines meet job requirements") instead of a page that just has no information and essentially a link to nowhere?

The link in checks page will link to the build details only if the task is scheduled. If failed before being scheduled, the build id will not be available.
Instead if we can obtain the taks id (like 4f86ca6c72bfff10), then it is more useful to have this link.
But as currently supported from cocoon backend, the build is triggered via buildbucket, the task id maybe not available AFAIK.

The new config has been propagated. Just retried the failed builds from the above two PRs, and they are running now.

Let's open a bug for the usability request there are many of those that we'll need to address once we have the reliability and scalability parts under control.

Created issue to track the usability: https://github.com/flutter/flutter/issues/69242.

This still doesn't seem to be resolved...
https://github.com/flutter/plugins/pull/3213

That is a test/build problem https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8865161897106601168/+/steps/Run_plugin_tests/0/steps/drive_examples/0/stdout

Ohh thanks, that is being worked on as well.


op-guide: document CN certs in security.md

Address some of the confusion from #8020

lgtm, thanks
/cc @jesseendahl


Implement Leave class to encapsulate employee leave request

Implement Leave class
Implement LeaveBuilder and other util classes for unit testing
Update gitignore to include /bin/ folder

closes #61


Error: Cannot find module ´electron-squirrel-startup´ - Vite or Vite with Typescript on execute .exe

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
^7.5.0
Electron version
32.1.2
Operating system
Windows 11
Last known working Electron Forge version
No response
Expected behavior
Open executable successfully
Actual behavior
This error occurs after using the command: electron-forge make. Once the application is built, when double clicking on the .exe it throws the following error:

This ERROR occurs when using  vite or vite-typescript templates. If we use webpack or webpack-typescript it works without problems.
Steps to reproduce

Open a terminal and execute: npm init electron-app@latest my-app -- --template=vite or npm init electron-app@latest my-app -- --template=vite-typescript
Execute: npm run make
Execute the .exe created by npm run make
¡ERROR!

Additional information
Files:

Package json:
{
  "name": "my-app",
  "productName": "my-app",
  "version": "1.0.0",
  "description": "My Electron application description",
  "main": ".vite/build/main.js",
  "scripts": {
    "start": "electron-forge start",
    "package": "electron-forge package",
    "make": "electron-forge make",
    "publish": "electron-forge publish",
    "lint": "echo \"No linting configured\""
  },
  "devDependencies": {
    "@electron-forge/cli": "^7.5.0",
    "@electron-forge/maker-deb": "^7.5.0",
    "@electron-forge/maker-rpm": "^7.5.0",
    "@electron-forge/maker-squirrel": "^7.5.0",
    "@electron-forge/maker-zip": "^7.5.0",
    "@electron-forge/plugin-auto-unpack-natives": "^7.5.0",
    "@electron-forge/plugin-fuses": "^7.5.0",
    "@electron-forge/plugin-vite": "^7.5.0",
    "@electron/fuses": "^1.8.0",
    "electron": "32.1.2",
    "vite": "^5.0.12"
  },
  "keywords": [],
  "license": "MIT",
  "dependencies": {
    "electron-squirrel-startup": "^1.0.1"
  }
}

I encountered the same problem, I built an electron application based on vite according to the documentation on the official website, and completed the steps required to integrate vue3 according to the documentation on the official website, it can start normally during development, but the package built application, when starting, it will prompt that the error of "electron-squirrel-startup" was not found.

I found a solution for when using VITE. Vite does not handle imports as well as webpack does.
To quickly fix this bug with VITE, in the main.ts or main.js file instead of using require(“electron-squirrel-startup”) we can use commonjs import as follows:
// @ts-expect-error -> In vite there are no types for the following line. Electron forge error
import started from "electron-squirrel-startup";

// Handle creating/removing shortcuts on Windows when installing/uninstalling.
if (started) app.quit();

My main.ts:
import { app, BrowserWindow } from "electron";
// @ts-expect-error -> In vite there are no types for the following line. Electron forge error
import started from "electron-squirrel-startup";

import path from "path";

import express from "express";

import { APP_CONFIG } from "@/src/config/config";

declare const MAIN_WINDOW_VITE_DEV_SERVER_URL: string;
declare const MAIN_WINDOW_VITE_NAME: string;

// Handle creating/removing shortcuts on Windows when installing/uninstalling.
if (started) app.quit();

const createWindow = () => {
  // Create the browser window.
  const mainWindow = new BrowserWindow({
    title: "JSON Transformer",
    width: 800,
    height: 600,
    webPreferences: {
      preload: path.join(__dirname, "preload.js"),
    },
  });

  // and load the index.html of the app.
  if (MAIN_WINDOW_VITE_DEV_SERVER_URL) {
    mainWindow.loadURL(MAIN_WINDOW_VITE_DEV_SERVER_URL);
  } else {
    mainWindow.loadFile(
      path.join(__dirname, `../renderer/${MAIN_WINDOW_VITE_NAME}/index.html`)
    );
  }

  // Open the DevTools.
  if (APP_CONFIG.GENERAL.DEBUG_MODE) mainWindow.webContents.openDevTools();
};

// This method will be called when Electron has finished
// initialization and is ready to create browser windows.
// Some APIs can only be used after this event occurs.
app.on("ready", createWindow);

// Quit when all windows are closed, except on macOS. There, it's common
// for applications and their menu bar to stay active until the user quits
// explicitly with Cmd + Q.
app.on("window-all-closed", () => {
  if (process.platform !== "darwin") {
    app.quit();
  }
});

app.on("activate", () => {
  // On OS X it's common to re-create a window in the app when the
  // dock icon is clicked and there are no other windows open.
  if (BrowserWindow.getAllWindows().length === 0) {
    createWindow();
  }
});

// In this file you can include the rest of your app's specific main process
// code. You can also put them in separate files and import them here.

const server = express();
server.get("/api/data", (req, res) => {
  res.json({ message: "Hello from the backend!" });
});
server.listen(3000, () => {
  console.log("Backend running on http://localhost:3000");
});

This temporarily fixes the problem until the creators of electron-forge fix it.

I think this one has a fix: https://github.com/electron/forge/pull/3713

@DiegoLibonati 's solution is helpful for the problem I'm facing; it just needs the following modifications to resolve it.
// src/main.js
const { app, BrowserWindow } = require('electron');
const path = require('node:path');

// Handle creating/removing shortcuts on Windows when installing/uninstalling.
if (require('electron-squirrel-startup')) {
  app.quit();
}

Modify to
// src/main.js
import { app, BrowserWindow } from 'electron';
import path from 'node:path';
import started from 'electron-squirrel-startup';

// Handle creating/removing shortcuts on Windows when installing/uninstalling.
if (started) {
  app.quit();
}


Can you provide details of the environment

ex: Python version, Tensorflow version
thanks!

Hi @WMars The code was tested on python3. Version of other packages I am not sure, its been 4 years..


fix(manager): fixing myriad of issues that came with 2.5

@ShlomiBalalis Do we need to backport it to manager-2.5 branch?
Do we even have branches for manager in ccm?

@ShlomiBalalis Do we need to backport it to manager-2.5 branch?
Do we even have branches for manager in ccm?

@roydahan We do not, we only use master


falcon-40b out of memory

Hi! I am trying to finetne falcon-40b with a single A100 GPU of 80GB memory. I tried with decreasing the micro batch size to be 1 however it is still OOM for both adapter_v2 and lora with bfloat16-mixed / fp-16. Any suggestion on how to solve this issue without using multiple GPU? Thanks a lot!

I tried again with 2 A100 GPUs but still OOM. Set device = 2 and tried both lora and adapter_v2. Any help would be appreciated!

Falcon 40B won't fit in a single 80GB card.
I will report back when I find out what's the minimum memory requirement to fine-tune it. But I don't have access to A100 80GB right now

Any luck with finetuning? Running into OOM while trying to fine tune Falcon40B on a 8 GPU A100 80 GB machine. Tried reducing num_devices, micro_batch_size, lower lora rank.
Update: Looks like the recent main don't support multi GPU training. Any plans/threads to support that feature?

@gpravi Distributed support for LoRA is tracked in #161

So currently it's not possible to finetune Falcon 40B using Lit-parrot, right?

@weilong-web  Yeah, I don't think it works out of the box... Looks like someone managed to finetune Falcon 40b - https://github.com/Lightning-AI/lit-gpt/issues/198

@weilong-web Yeah, I don't think it works out of the box... Looks like someone managed to finetune Falcon 40b - #198

I am able to use this tool to finetune 40b: https://github.com/rmihaylov/falcontune

@lynngao
I was able to finetune on the Falcon 40B instruct 4 bit version.
Were you able to finetune on the 40B model? I ran into this issue while saving the checkpoint - https://github.com/rmihaylov/falcontune/issues/19

@lynngao
I was able to finetune on the Falcon 40B instruct 4 bit version.
Were you able to finetune Falcon 40B model? I ran into this issue while saving the checkpoint

No I only tried the 4bit version.

@weilong-web Yeah, I don't think it works out of the box... Looks like someone managed to finetune Falcon 40b - #198

I am able to use this tool to finetune 40b: https://github.com/rmihaylov/falcontune

Were you able to run it in DPP or only single GPU?

@lynngao
I was able to finetune on the Falcon 40B instruct 4 bit version.
Were you able to finetune Falcon 40B model? I ran into this issue while saving the checkpoint

downgrading bitsandbytes to 0.37.2 worked for me (took me a few days to find this thread..)
https://github.com/TimDettmers/bitsandbytes/issues/324

@alexeiga Nice. Can you please let us know the configurations?
Also, the current main branch doesn't implement multi gpu training. How did you manage to implement it?

@alexeiga Nice. Can you please let us know the configurations?
Also, the current main branch doesn't implement multi gpu training. How did you manage to implement it?

i tried to, but without success... was only able to go single gpu, but training is VERY slow.

`QLoRA finetuning support is tracked in #176. Until that is supported, you can try the suggestions described in https://github.com/Lightning-AI/lit-gpt/blob/main/tutorials/oom.md


Add indexes

Indexes required to search/sort faster:
created_at
visible
title

thank your for these awesome changes


Usage improvements

Api PR | Implementation PR
This pull request should improve the overall experience from the view of a plugin developer.
It should be merged before API Revision 3.0.
In summary, this pull request contains the tiny improvements that I think are needed to get into API Revision 3.0.
Please don't close this PR until Revision 3.0 as I may commit a few other changes in the meantime.

Can you please provide a quick summary of the changes, and the benefits that they bring?

Of course.
The Entity interface in SpongeAPI had a bunch of convenience methods for teleporting:
getWorld();
getLocation();
setLocation(Location);
setLocationSafely(Location);
getRotation();
setRotation(Vector3d);
setLocationAndRotation(Location, Vector3d);
setLocationAndRotationSafely(Location, Vector3d);
setLocationAndRotation(Location, Vector3d, EnumSet<RelativePositions> relativePositions);
setLocationAndRotationSafely(Location, Vector3d, EnumSet<RelativePositions> relativePositions);
transferToWorld(String worldName, Vector3d position);
transferToWorld(UUID uuid, Vector3d position);

I added these methods:
getPosition();
setPosition(Vector3d);
setPositionSafely(Vector3d);
setPositionAndRotation(Vector3d, Vector3d);
setPositionAndRotationSafely(Vector3d, Vector3d);
setPositionAndRotation(Vector3d, Vector3d, EnumSet<RelativePositions> relativePositions);
setPositionAndRotationSafely(Vector3d, Vector3d, EnumSet<RelativePositions> relativePositions);
transferToWorld(String worldName, Vector3d position, Vector3d rotation);
transferToWorld(UUID uuid, Vector3d position, Vector3d rotation);

After talking to @Zidane he said that I should make a pull request for it and all other (minor) things I want to fix.
This Implementation PR only implements the new methods I mentioned in this post.
For more information about what I changed too, see the commits in Api PR.

Closing this as all of the changes in API need to be separate PR's.


Key server is ON but Dev manager can't fetch

I put my TV Wired Ip adress, then the passphrase on the manager click finish and "please wait" pops, wait a couple of seconds and eventually the failed to fetch private key screen pops up, I look at my TV and its Key server is still on. How can I fix this please?

It just occurred to me, earlier I tried the root my.tv method and it didn't work (it restarted as usual but didn't install homebrew application) hence why I got to here. Could this be the cause?

Hi, are you able to ping the TV from your computer?

How do I do that?

https://www.wikihow.com/Ping-an-IP-Address

Here's what I got

OK. So this means your computer can access the TV.
What about accessing http://IP:9991/webos_rsa with your browser?

Nope get refused connection error

This means the "Key Server" was not turned on properly. Did you turn the dev mode on, and wait for it to reboot?

Yes it rebooted and dev mode stays on even after turning off the TV, the "Key Server" doesnt tho, I turn it on and it stays on but if I turn off the TV and check it again it's always OFF

Key server is off by default and will be off if rebooted. When you turn key server on, you need to leave the TV as is and continue the setup procedure on the computer. If you still seeing errors, that probably means something wrong happened on Developer mode app side.
I'd suggest:

Turn developer mode off, then uninstall the developer mode app.
Reset the TV if that doesn't work.

OK I had uninstalled it and installed again (The credentials and Dev was still ON) didn't work, then I did like you said first turn OFF and then reinstall the app and it worked. Thank you for the fast help and for developing such tools, my world with Smart TVs has not been what I have expected but you made it a little more brighter👌

OK, ich hatte es deinstalliert und erneut installiert (die Anmeldeinformationen und Dev waren immer noch aktiviert), es hat nicht funktioniert.   Meine Welt mit Smart-TVs war nicht das, was ich erwartet hatte, aber Sie haben sie ein wenig heller gemacht👌

Had the same problem. This method helped me too! Thank you very much!


Radio group does not have the correct value when submitted in a form.

Describe the bug
When using a Radio group in a form, the group will pick the last radio button as its default value, even if it is not checked. Setting other buttons as checked does nothing visually or semantically (if you set the last radio button as checked, it will pick the second to last button as the default value).
Selecting other buttons before hitting submit does not change the value -- you must first select the last button first, and then click on another option to change the value.
The way around this bug is to set all radio buttons as checked (this visually doesn't show anything), and it will behave as expected.
This was done using React.
To reproduce
Create a React form element like so in your webview panel:
export default function FindingForm() {
  const onFormSubmit = useCallback((e: FormEvent<HTMLFormElement>) => {
    e.preventDefault();
    const data = new FormData(e.currentTarget);
    const finding: Record<string, any> = {};
    data.forEach((v, k) => (finding[k] = v));
    console.table(finding);
  }, []);
  const formRef = useRef(null);

  return (

      <form id="form" onSubmit={onFormSubmit} ref={formRef}>

          <VSCodeRadioGroup orientation="horizontal" name="difficulty">
            <VSCodeRadio value="Hard">Hard</VSCodeRadio>
            <VSCodeRadio value="Medium">Medium</VSCodeRadio>
            <VSCodeRadio value="Easy">Easy</VSCodeRadio>
          </VSCodeRadioGroup>

        <VSCodeButton type="submit" form={formRef.current}>
          Submit
        </VSCodeButton>
      </form>

  );
}

Expected behavior

In the panel, click "Submit" without choosing an option. In the dev console, the form should be empty.
Click on "Hard" and hit "Submit". In dev console, it should show that "hard" was selected.

Current behavior

In the panel, click "Submit" without choosing an option. In dev console, it will show "easy" as being selected.
Click on "Hard" and hit "Submit". In dev console, it will still show "easy".
Click on "Easy" and then click on "Hard" and hit "Submit". In dev console, it will now print "hard" as being selected.

Additional context
Also setting one of the VSCodeRadio elements as checked does not do anything. Nothing visually occurs, and the value is not considered checked.

Updated packages and issue was resolved.


Add ZeroMQ unbind function types

The functions are defined here:
https://github.com/JustinTulloss/zeromq.node/blob/master/lib/index.js#L300-L347
Also added tests for these.

Hi, made the callbacks optional.

@panuhorsmalahti thanks mate!


429 from citymind

homeassistant-1  | 2024-07-29 07:59:21.193 INFO (MainThread) [homeassistant.setup] Setting up citymind_water_meter
homeassistant-1  | 2024-07-29 07:59:21.193 INFO (MainThread) [homeassistant.setup] Setup of domain citymind_water_meter took 0.00 seconds
homeassistant-1  | 2024-07-29 07:59:21.197 INFO (MainThread) [custom_components.citymind_water_meter.managers.config_manager] loaded: {'meters': {}, 'use-unique-device-names': True}
homeassistant-1  | 2024-07-29 07:59:21.198 INFO (MainThread) [custom_components.citymind_water_meter] Finished loading integration
homeassistant-1  | 2024-07-29 07:59:43.519 INFO (MainThread) [homeassistant.components.sensor] Setting up citymind_water_meter.sensor
homeassistant-1  | 2024-07-29 07:59:43.520 INFO (MainThread) [homeassistant.components.number] Setting up citymind_water_meter.number
homeassistant-1  | 2024-07-29 07:59:43.520 INFO (MainThread) [homeassistant.components.switch] Setting up citymind_water_meter.switch
homeassistant-1  | 2024-07-29 07:59:43.520 INFO (MainThread) [homeassistant.components.binary_sensor] Setting up citymind_water_meter.binary_sensor
homeassistant-1  | 2024-07-29 07:59:43.520 INFO (MainThread) [custom_components.citymind_water_meter.managers.coordinator] Start loading citymind_water_meter integration, Entry ID: c561c369e885d4bd3cf858cd7d21c1e8
homeassistant-1  | 2024-07-29 07:59:43.521 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update None --> Establishing connection to API, Initializing API
homeassistant-1  | 2024-07-29 07:59:44.285 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Establishing connection to API --> Connected to the API
homeassistant-1  | 2024-07-29 09:09:52.047 ERROR (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Connected to the API --> Failed to access API, Failed to send HTTP request, Endpoint: https://eu-customerportal-api.harmonyencoremdm.com/consumption/last-read, Method: GET, HTTP Status: Too Many Requests (429)
homeassistant-1  | 2024-07-29 09:10:52.049 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Failed to access API --> Establishing connection to API, Initializing API
homeassistant-1  | 2024-07-29 09:10:52.759 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Establishing connection to API --> Connected to the API
homeassistant-1  | 2024-07-29 09:10:52.996 ERROR (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Connected to the API --> Failed to access API, Failed to send HTTP request, Endpoint: https://eu-customerportal-api.harmonyencoremdm.com/consumer/myalerts, Method: GET, HTTP Status: Too Many Requests (429)
homeassistant-1  | 2024-07-29 09:11:52.999 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Failed to access API --> Establishing connection to API, Initializing API
homeassistant-1  | 2024-07-29 09:11:54.377 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Establishing connection to API --> Connected to the API
homeassistant-1  | 2024-07-29 09:29:53.041 ERROR (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Connected to the API --> Failed to access API, Failed to send HTTP request, Endpoint: https://eu-customerportal-api.harmonyencoremdm.com/consumption/last-read, Method: GET, HTTP Status: Too Many Requests (429)
homeassistant-1  | 2024-07-29 09:30:53.042 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Failed to access API --> Establishing connection to API, Initializing API
homeassistant-1  | 2024-07-29 09:30:53.329 ERROR (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Establishing connection to API --> Failed to access API, Failed to send HTTP request, Endpoint: https://eu-customerportal-api.harmonyencoremdm.com/consumer/login, Method: POST, HTTP Status: Too Many Requests (429)
homeassistant-1  | 2024-07-29 09:31:53.330 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Failed to access API --> Establishing connection to API, Initializing API
homeassistant-1  | 2024-07-29 09:31:53.628 ERROR (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Establishing connection to API --> Failed to access API, Failed to send HTTP request, Endpoint: https://eu-customerportal-api.harmonyencoremdm.com/consumer/login, Method: POST, HTTP Status: Too Many Requests (429)
homeassistant-1  | 2024-07-29 09:32:53.634 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Failed to access API --> Establishing connection to API, Initializing API
homeassistant-1  | 2024-07-29 09:32:53.920 ERROR (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Establishing connection to API --> Failed to access API, Failed to send HTTP request, Endpoint: https://eu-customerportal-api.harmonyencoremdm.com/consumer/login, Method: POST, HTTP Status: Too Many Requests (429)
homeassistant-1  | 2024-07-29 09:33:53.921 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Failed to access API --> Establishing connection to API, Initializing API
homeassistant-1  | 2024-07-29 09:33:54.196 ERROR (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Establishing connection to API --> Failed to access API, Failed to send HTTP request, Endpoint: https://eu-customerportal-api.harmonyencoremdm.com/consumer/login, Method: POST, HTTP Status: Too Many Requests (429)
homeassistant-1  | 2024-07-29 09:34:54.197 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Failed to access API --> Establishing connection to API, Initializing API
homeassistant-1  | 2024-07-29 09:34:55.222 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Establishing connection to API --> Connected to the API

I did restart my HA instance a few times this morning, so I'm not sure if that's the root cause. Is anyone else seeing this?

FWIW, I just tried logging in to the rym-pro web portal and it was fine.

May have recovered:
2024-07-29 09:34:55.222 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Establishing connection to API --> Connected to the API
2024-07-29 09:59:55.557 ERROR (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Connected to the API --> Failed to access API, Failed to send HTTP request, Endpoint: https://eu-customerportal-api.harmonyencoremdm.com/consumer/myalerts/settings, Method: GET, HTTP Status: Too Many Requests (429)
2024-07-29 10:00:55.558 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Failed to access API --> Establishing connection to API, Initializing API
2024-07-29 10:00:56.404 INFO (MainThread) [custom_components.citymind_water_meter.managers.rest_api] Status update Establishing connection to API --> Connected to the API

When you are opening the web portal it is different than process runs and collects data,
429 error means that it tried too many time in small time window,
Which version of the integration are you using?

It resolved itself after a few hours, and I haven't seen it since, so this can probably be closed.
This was with 3.0.8.
I'm aware that the portal has a slightly different flow; my point in mentioning that was that when the website was calling the same APIs, it wasn't being rate limited, which suggested to me that perhaps there may be an issue with the sequence of calls, or something else.

that's was superfine to mention that it was working, but i tried to explain why the 429 appears, because the integration is doing polling of infromation and we don't know exactly what is the right timing to do that, so it's a fine tuining process to avoid abusing the server and ignoring it,
thanks for the update

no worries, I didn't take offense. I know what a 429 means, but I know that others might not.


Error executing action enable on resource 'icinga2_feature[command]'

Getting this error running chef-client. My setup includes:
chef-icinga2 = 2.9.1
ruby = 2.4.0
yum[icinga2] =   2.6.0-1.el6
yum[icingacli] =  2.4.0-2.el6
icingaweb2 = 2.4.0
This is the exception:
* icinga2_feature[command] action enable

    Error executing action `enable` on resource 'icinga2_feature[command]'

    RuntimeError
    ------------
    feature not available - command

    Cookbook Trace:
    ---------------
    /var/chef/cache/cookbooks/icinga2/libraries/resource_feature.rb:34:in `block in <class:Icinga2Feature>'
    /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:78:in `run_action'
    /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in `block (2 levels) in converge'
    /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in `each'
    /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:106:in `block in converge'
    /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/runner.rb:105:in `converge'

    Resource Declaration:
    ---------------------
    # In /var/chef/cache/cookbooks/icinga2/recipes/server_web2.rb

     95: icinga2_feature 'command'

    Compiled Resource:
    ------------------
    # Declared in /var/chef/cache/cookbooks/icinga2/recipes/server_web2.rb:95:in `from_file'

    icinga2_feature("command") do
      provider Chef::Provider::Icinga2Feature
      action :enable
      retries 0
      retry_delay 2
      default_guard_interpreter :default
      provides :icinga2_feature
      declared_type :icinga2_feature
      cookbook_name "icinga2"
      recipe_name "server_web2"
    end

Running handlers:
[2017-01-18T16:10:01+00:00] ERROR: Running exception handlers
Running handlers complete
[2017-01-18T16:10:01+00:00] ERROR: Exception handlers complete
Chef Client failed. 13 resources updated in 32 seconds
[2017-01-18T16:10:01+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
[2017-01-18T16:10:01+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
[2017-01-18T16:10:01+00:00] ERROR: icinga2_feature[command] (icinga2::server_web2 line 95) had an error: RuntimeError: feature not available - command
[2017-01-18T16:10:02+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

weird, this should not fail.
I do not suspect it is caused by ruby version, chef-client uses embedded ruby.

I also tried a diff version, same result.

@vkhatri do you have any ideas or something I can look into? We're running a big monitoring solution that I'm trying to upload cookbooks to and we're a bit under the water.
Any help would be appreciated.

@vkhatri any timeframe on this? If there's any way I can rollback to a previous version I would that as well. We were on 2.6.5. If I go back to that, I will get the wrong GIT repo issue. So, kind of stuck at this point. If this gets escalated we might drop this solution.

Patching the old cookbook you've installed and update to the current git repo isn't an option? (at least I would apply such a workaround if it is urgent)

Thanks @dnsmichi that's exactly what we did this morning. It's a hack, but it fixes the issue. We'll try this back again when the fix is pushed to the marketplace.

@luijar Could you share the OS details, especially the platform version.
I ran kitchen tests and did not see any issue.
Also, could you please share the output of below command?
# icinga2 feature list

# ls /etc/icinga2/features-available

for some reason, resource icinga2_feature[command] is unable to find the command.conf under /etc/icinga2/features-available

Thanks @vkhatri Those instructions helped me resolve my issue. In fact the features were all missing for some reason. I don't know what that is, but I suspect it's our error somehow. I was able to SCP the features from our second Icinga master server and things are back to normal. Again, I don't know if this is our mistake or something else. Here's the info you requested anyways, perhaps it's an issue in the chef-icinga scripts:
Before the fix, running icinga2 feature list:
Disabled features:
Enabled features: ido-mysql

the /etc/icinga2/features-available only had ido-mysql

@luijar Glad to see you got it working. Cookbook does not create/delete features configuration files directly, it relies on /usr/sbin/icinga2 feature [enable|disable].


Noticeable delay opening a markdown file (source)

I am noticing a delay when I click on a markdown file until it opens. I think this is a regression from the new markdown extension but I am not sure what piece could cause it.
//cc @jrieken if you have clues

It's starting a process that encapsulated the rendering

A dupe of #7066

@jrieken I see this when opening the markdown file in source, not preview. I am aware of the delay when previewing.

hm... is the grammar we are using?

Holy moly - the parsing/loading the grammar is slow. Tho it only happens once/the first time. @aeschli @alexandrudima ideas how to seep that up?
CPU-20160627T140746.cpuprofile.zip

This sounds like an opportunity for a great new plist-to-json node module. I'd love to write that :)

Maybe we can use the native DOMParser for this (https://developer.mozilla.org/en-US/docs/Web/API/DOMParser)

@jrieken vscode-textmate is a node module and should in theory not use browser API. We can, as always make it injectable with a different plist parser.

I am on the path of writing a plist parser.
before:

after:

Tho, I'd still like to see how it compares to the DOMParser ;-)

before.CPU-20160630T185643.zip
after.CPU-20160630T185657.zip
before:

after:

To the verifier: please check that you can get the previous (slow) parser when setting the "hidden" preference editor.useExperimentalParser = false. I've added this to have a fallback in case my 10x faster parser has a bug, so we can switch back to the SAX based parser based on a setting. I will remove the setting after our confidence grows, by default the setting is on (use faster parser by default).

Works great in terms of performance 👍


example cleanup and README.md update

example cleanup and README.md update

Coverage remained the same at 97.959% when pulling 03ea3656b5c9f9c6ced016b8fca0fbce4bc0b1da on development into 7fedb11f7378df3db408c96f6e128003ac9ac7cf on master.


Update to README.md

These updates are meant to improve the ability to read and edit the raw markdown file. It also fixes some small mistakes I made on the original README.md rewrite.

This pull request was closed due to some other mistakes I made earlier.


fix bug doing rabit call after finalize

fix bug: doing rabit call after finalize in spark prediction phase #1420
The above has fixed the fucntion of predict(testSet: RDD[MLVector], useExternalCache: Boolean = false),but predictLeaves() and predict(testSet: RDD[MLDenseVector], missingValue: Float)
have the same problem.so I fixed them.

Codecov Report

Merging #2079 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2079   +/-   ##
=======================================
  Coverage   30.67%   30.67%
=======================================
  Files          72       72
  Lines        5836     5836
  Branches      583      583
=======================================
  Hits         1790     1790
  Misses       3970     3970
  Partials       76       76

Impacted Files
Coverage Δ

src/objective/regression_obj.cc
90.39% <0%> (-0.57%)
:x:

src/data/simple_dmatrix.cc
58.66% <0%> (+0.66%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd19b7a...34f5219. Read the comment docs.

merged thanks

Thank you!


Union is missing

Union is not implemented if I'm correct, but it is advertised in the ReadMe. Is there a simple way to activate it?

In the context of this library, you can just render each object to get the same effect as a Union. (The CSG operations in ln don't actually compute a new geometry)

But if I would render both objects I would still have the putlines of both.


Adding mat-option dynamically to mat-select from .ts file(Using JavaScript)

Bug, feature request, or proposal:
Adding or Creating 'mat-option' dynamically to 'mat-select' from .ts file(using JavaScript).
Is it possible to create or add 'mat-option' dynamically?
What is the expected behavior?
Need to create or add 'mat-option' dynamically from .ts file using JavaScript.
What is the current behavior?
Currently we can add 'mat-option' using *ngFor.
"
<mat-select placeholder="Toppings" [formControl]="toppings" multiple>
<mat-option *ngFor="let topping of toppingList" [value]="topping">{{topping}}

"
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular: 5.2.3
angular-material: 5.1.1
Windows 10
typescript: 2.7.1
All Browsers

Yes it's possible.
this.toppingList.unshift("newValue"); or this.toppingList.push("newValue");

Yes, we can add values to the toppingList array. But, I need to add '' element to the template using JavaScript.

I'm not sure to understand...
You have a select element, with multiples options (equals to toppingList size) generated by the for loop. If you want to add another option to this select just grow your list (toppingList here).
If it's not your goal, describe it with an example or a picture of what you want to achieve.

Please keep GitHub issues for bug reports / feature requests. Better avenues for troubleshooting / questions are stack overflow, gitter, mailing list, etc.


Fix alert showing text in one line

IMHO breaking words should be the default

@Ruffio stylelint threw Expected "word-break" to come before "border" so I needed to reorder rules.

If we need something like this, I'd rather go the route of #27863. Closing on this for that PR, and waiting on some other improvements that hopefully come in v5. Thanks though!

Makes all the sense! 👍


where to find client logs

@kacf @pasinskim can you please make sure this is (still) accurate?
In particular on my QEMU instance, /var/lib/mender/logs/ does not exist, which was a bit suspicious.

In particular on my QEMU instance, /var/lib/mender/logs/ does not exist, which was a bit suspicious.

I haven't tested it, but from what I can piece together by quickly skimming the code, it looks like they are placed one level higher, in /var/lib/mender. This is the main piece of the puzzle, it assigns the data store path directly, and I can't see there are any further path additions after that in the constructor.

Thanks @kacf, I tested and you were right. The deployment logs are directly under /var/lib/mender.


Change form view to by site, subject, and folder

Test Notes

Click the "Report" button and verify that the Form tab of the report has site, subject, and folder nest columns.

"In the form view we need to have this by site, subject, and folder – yes, this will be the length of the original input dataset."

I feel like this is gonna crash the browser...


How to run hubot as a daemon with docker?

I'm trying to run a hubot without any adapter (I think it will fallback to the default shell adapter).
If docker run -it, it works well.
If docker run -d, it seems to exit immediately.
What is the recommended way to run hubot as a daemon.

Maybe that working example can help you? https://github.com/Dynamictivity/hewbot-docker

Another (different) example that works for me: https://github.com/pchaigno/hewbot/blob/657614144bc2898d39a45ec49c15b7765244871e/Dockerfile

Thanks for your help. I'm using supervisord and not changing anything about hubot now. It works.


Added concurrent compaction switches

This PR adds checkboxes in two places:

in the classic batch ingestion wizard

in the compaction configuration UI

These both set the context.taskLockType accordingly, to either 'APPEND', 'REPLACE' or undefined based on the checkbox state and the current spec.

@lorem--ipsum, could you please also add a switch in the streaming ingestion wizard that adds an APPEND lock to the context when concurrent compaction is enabled?


feat: Vertical Image Slider Mini Project

Vertical Image Slider
I have developed a vertical image slider using HTML5, CSS3, and vanilla JS.
Please assign this issue to me and add the 'hacktoberfest-accepted' label to avoid any issues.

go ahead @RoshanMhatre  And don't forget to attach the screenshot of your project while opening a PR

PR raised for this issue.
Please review.


cannot use library when use_frameworks! is enabled in podfile

❌  /Users/me/github/flock-react-app/node_modules/react-native-linear-gradient/BVLinearGradient/BVLinearGradient.h:2:9: 'React/RCTView.h' file not found
#import <React/RCTView.h>
^
▸ Compiling BVLinearGradientManager.m
❌  /Users/me/github/flock-react-app/node_modules/react-native-linear-gradient/BVLinearGradient/BVLinearGradientManager.h:1:9: 'React/RCTViewManager.h' file not found
#import <React/RCTViewManager.h>
I am using React Native 0.53.3, and React Native Linear Gradient 2.3.0
The problem appears when I add use_frameworks! in my Podfile, and disappears when I remove it

Did you install it via Pods?
Try to remove your Pods directory and do a pod install again.

+1

+1

+1


Add sidenav hero

Bug/issue #, if applicable: 89092590
Summary
Implements a Hero section into Docc-render, that is to be used in tandem with the new Sidebar functionality

Dependencies
#51
Testing
Make sure you download and unzip the .doccarchive - SlothCreator.doccarchive.zip
Steps:

run VUE_APP_DEV_SERVER_PROXY=/path/to/SlothCreator.doccarchive npm run serve
Visit http://localhost:8080/documentation/slothcreator
Assert there is a hero section with icons of the same type, as the items in the sidebar.

Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.

[x] Added tests
[x] Ran npm test, and it succeeded
[x] Updated documentation if necessary

Closed in favour of - https://github.com/apple/swift-docc-render/pull/56


Add helpers at /apis/{apiName}/listeners/{eventPath}

This includes the commit from #693.
Add helper URLs:
GET /apis/{apiName}/listeners/{eventPath} - list all listeners matching this event on this API
POST /apis/{apiName}/listeners/{eventPath} - create a new listener for this event on this API

Test coverage is not quite complete; will come back to finish it shortly. Code should be complete though.

Codecov Report

Merging #696 (d52645a) into main (9e451ef) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #696   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          321       321
  Lines        19646     19719   +73
=========================================
+ Hits         19646     19719   +73

Impacted Files
Coverage Δ

pkg/fftypes/contract_listener.go
100.00% <ø> (ø)

pkg/fftypes/contracts.go
100.00% <ø> (ø)

...rnal/apiserver/route_get_contract_api_listeners.go
100.00% <100.00%> (ø)

internal/apiserver/route_get_contract_apis.go
100.00% <100.00%> (ø)

...nternal/apiserver/route_get_contract_interfaces.go
100.00% <100.00%> (ø)

...nal/apiserver/route_post_contract_api_listeners.go
100.00% <100.00%> (ø)

internal/blockchain/ethereum/ethereum.go
100.00% <100.00%> (ø)

internal/blockchain/fabric/fabric.go
100.00% <100.00%> (ø)

internal/contracts/manager.go
100.00% <100.00%> (ø)

...ternal/database/sqlcommon/contractlisteners_sql.go
100.00% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e451ef...d52645a. Read the comment docs.

Also, in the header comment of the PR (and soon in API descriptions fyi @nguyer ) would be good to note the 409 conflict behavior that allows apps the ability to do a create-if-not-exist check on startup with this great new API.


Source code of electronic scale sensor

#1732 Add the source code of electronic scale sensor

感谢提交 Pull Requests！
Thanks for submitting a pull request.


Crash Minecraft Fabric 1.19.2

Describe the Bug
The game left the Launcher and even loaded. But at the end of loading, the game crashes, returning to the launcher with the following message
The game crashed whilst rendering overlay
Error: java.lang.NullPointerException: Cannot invoke "net.minecraft.class_5944.method_34583(String, Object)" because "$$2" is null
The only mob that is giving this problem is Create Fabric 0.5.1c for version 1.19.2 of Minecraft
Reproduction Steps

Mod installed in the folder
Launcher opens normally
Game starts to load but crashes

Expected Result
The game was expected to open normally.
Screenshots and Videos

Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.1c
Minecraft Version
1.19.2
Other Mods
There are around 220 mods (Libs included), they all work normally, the game only crashes when Fabric is added
Additional Context
No response

please attach the crash report

please attach the crash report

Crash Report Attached

please downgrade fabric api to 0.76


InfluxDb Sources

What this PR does / why do we need it:
Introduces sources for InfluxDb to be able feed Hazelcast Jet from it.
Checklist

[ ] No checkstyle issues (./gradlew check)
[ ] No tests failures (./gradlew test)
[ ] Documentation which complies with README template (see templates/README.template.md).
[ ] Update List of modules section on the root README with your module.
[ ] Javadoc

* No checkstyle issues (./gradlew check)
* No tests failures

These two should be tested by the PR builder - so not sure if they need to be in the checklist.

* No checkstyle issues (./gradlew check)
* No tests failures

These two should be tested by the PR builder - so not sure if they need to be in the checklist.

They are already enforced by the PR builder but it is better if you make sure those are passing before raising the PR.

what about the Hazelcast CLA? this should be in checklist too

what about the Hazelcast CLA? this should be in checklist too

It actually is in the checklist but I've removed that for my PR :)

I'm not sure how useful this batch sources are. Streaming source would be much more useful. There's Kapacitor from influxdb guys themselves, maybe we can use the same api.

The plan would be to add streaming version later, currently it's only useful for querying historical data.


Add Landau Forte Academy Tamworth Sixth Form

Schools official site https://lfatsf.org.uk

@ArchieW1 Pull request merged. Thank you!


Security fix, uplift HAPI FHIR version to 3.8.0

Summary
Security fix, uplift HAPI FHIR version to 3.8.0
@ysmwei @sc036868 @karthisuku

Merged. Thanks @karthisuku for review.


add angular-protractor to typings

Thanks, I forgot about that, will test.

I feel like this doesn't do much unless we move the tests to typescript.

@Foxandxss If you're using an editor that supports it, you can do a triple-slash ref within the .js files and still get some degree of code completion and such from the typings.

I'm gonna update to protractor 4 soon. That comes with typings
El 22 ago. 2016 10:36 PM, "Matt Distefano"<EMAIL_ADDRESS>escribió:

@Foxandxss https://github.com/Foxandxss If you're using an editor that
supports it, you can do a triple-slash ref within the .js files and still
get some degree of code completion and such from the typings.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/preboot/angular2-webpack/pull/121#issuecomment-241541897,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCZ1atxBIYLyWiaawzsu20I0dK30y4fks5qighYgaJpZM4JGFAN
.


Eval dispatch

This will prevent webview_eval being run before WKWebView has been initialized.
The weird looking dispatch roundabout is necessary because all UI code must be called from the main queue.
I am open to cleaner alternatives.

Ok, some checks didn't pass. Investigating now. Will update.

Ok,  so this is an issue with cgo from what I can tell. It doesn't like dispatch_queue_t eval_queue;.  From the cgo docs:

Using //export in a file places a restriction on the preamble: since it is copied into two different C output files, it must not contain any definitions, only declarations. If a file contains both definitions and declarations, then the two output files will produce duplicate symbols and the linker will fail. To avoid this, definitions must be placed in preambles in other files, or in C source files.

Trying to see what I can do.

Alright, we are back in business


fix background color style

fix #2301

[x] I've read and followed the contributing guide on how to create great pull requests.
[x] I've updated the relevant documentation for any new or updated feature
[x] I've linked relevant GitHub issue with "Closes #"
[x] I've added a visual demonstration under the form of a screenshot or video

if the inset was set, background was #f7f7f7, I think the preview mode follows the dev

I believe the preview is correct, it's the canvas that overlays a slight transparent grey when nothing is selected. The idea is to emphasize something is selected by slightly dimming the rest. It gives the illusion of a grey background.
We can start by disabling this overlay when nothing is selected. If this turns out to still be confusing we will disable it altogether and rely purely on the blue box to indicate selection

we will disable it altogether and rely purely on the blue box to indicate selection
I chose this way

we will disable it altogether and rely purely on the blue box to indicate selection

I chose this way

@Janpot
It only shows the blue button active, which can help shrink the code that doesn’t need to calculate it a lot.

If we don't want a background at all, you may as well remove this whole component

If we don't want a background at all, you may as well remove this whole component

If we don't want a background at all, you may as well remove this whole component

actually, I removed the whole component but the [chromium] › integration/rest-basic/index.spec.ts:36:5 › rest runtime basics  this test will occur an error.
let me dive into deeper

Yes, you may have to move the data-testid="page-overlay" one comonent up

@Janpot
after my in-depth study,
We can’t maybe directly delete this part of PinholeOverlay, because it is not only for emphasizing something that is selected, but also for canceling the status of active when something is selected.

I added a test for the status of active

If the PinholeOverlay does have utility and the only issue was the darkening of the UI I think just removing that darkening should do!
Thanks for adding a test for this, I'll leave some comments on it.

@apedroferreira
help agree on this pr if this pr can be merged.

With my comments above, here's how I would vertically space the test, order the variables and change variable names to improve readability and make the test as easy to understand as possible:
const editorModel = new ToolpadEditor(page);

  await editorModel.goToPageById('K7SkzhT');

  await editorModel.waitForOverlay();

  const textField = editorModel.appCanvas.locator('input');
  const textFieldNodeHudTag = editorModel.appCanvas
    .getByTestId('node-hud-tag')
    .filter({ hasText: 'textField' });

  await clickCenter(page, textField);
  await expect(textFieldNodeHudTag).toBeVisible();

  const textFieldBoundingBox = await textField.boundingBox();
  await page.mouse.click(textFieldBoundingBox!.x + 150, textFieldBoundingBox!.y + 150);
  await expect(textFieldNodeHudTag).toBeHidden();


React Native WebView don't have access to camera on some android devices

Bug description:
Facing issues on some android devices with camera access. I am using webview for biometric authentication through webview with camera access. Additionally, i use react-native perission library to get access to camera, before getting to webview, all access are granted, but still camera does't appear in webview, so authentication is failed. After that api reject authentication with result "No camera detected"
Expected behavior:
Working and accessed camera displayed on webview
Screenshots/Videos:

Environment:

OS: Android
OS version: 10
react-native version: 0.70.14
react-native-webview version: 13.8.2
model: HUAWEI P30 lite

<WebView
        onShouldStartLoadWithRequest={onShouldStartLoadWithRequest}
        geolocationEnabled
        mediaPlaybackRequiresUserAction={false}
        mediaCapturePermissionGrantType="grant"
        javaScriptEnabled
        originWhitelist={['*']}
        allowsInlineMediaPlayback
        source={{ uri: url ?? '' }}
        scalesPageToFit
        startInLoadingState
        useWebKit
      />

Maybe connected with this issue #3206

Hi did u fix the issue? Im facing the same :(

@Ravshanichk , any luck ?

same here

same here

Any update on this?


How to submit myself plugin to pinpoint

I've finished a new plug-in for alibaba’s druid data source.

Hello @symark
First of all, Thank you for our interest and contribution to Pinpoint Community:)
you can take a look in to our contribution guide first. It may look a lot at the first glance. But most of them are probably taken care of if you are ready for the contribution:)
If you need any further help,  write here~ I'll follow you up~

thx,i understand.


Add ChangeLog file for release

/kind feature
This repository is evolving very fast, and the migration to CCM is probably very painful for a lot of people. To ease the migration, and have better communication with users, I suggest adding a ChangeLog with the most important changes\bug fixes for each release.

@oz123 Thanks, we know the issue..I have already raise a PR to enable release notes automation.

@adisky could we add link to the PR here , so we could track and close the issue when done

@ramineni sure
https://github.com/kubernetes/test-infra/pull/15419

/remove-lifecycle stale

This can be closed.

@adisky there is a release which followed the PR mentioned here, but I still don't see the release notes. Is this issue resolved really?

@oz123 we will take care of it from this release, that's the reason kept the bug open.

Cool, it seemed like fetja is closing the issue so I wanted to make sure it's not forgotten.
I found this link:
https://relnotes.k8s.io/?areas=provider%2Fopenstack
Maybe this should be linked in a simple file called Changelog?

@oz123 Those are currently changes for intree provider only not for external. For external its not generated yet, we will try to take care of it in the same way generated for intree. Will be taken care fro this release.
@lingxiankong is on it

/assign @lingxiankong

I have finally got a script working, so from this release (v1.18.0) we are going to use the Release note in the PR description to generate our release note, I've already added/modified the content for all the merged PRs since v1.17.0 as needed, so the output of my script is like the following:
## Changelog since v1.17.0

### Action Required

* openstack-cloud-controller-manager: Support OpenStack Octavia by default as load balancer implementation, Neutron-LBaaS has been deprecated in OpenStack since Queens release and no longer maintained in openstack-cloud-controller-manager. So it's strongly recommended to use Octavia if upgrade to the latest openstack-cloud-controller-manager docker image. (#977, @lingxiankong)

### Other notable changes

* cinder-csi-plugin: rescan-on-resize option added to scan and check new block device size before a filesystem resize. Applicable for VMWare hypervisors (#861, @kayrus)
* Support multi-arch images for all maintained services/binaries.  (#910, @ricolin)
* k8s-keystone-auth: Support mapping from Keystone roles to Kubernetes users/groups. (#953, @lingxiankong)
* cinder-csi-plugin: Cluster admin can define `search-order` in cloud configuration for node metadata information retrieval. (#920, @jichenjc)
* cinder-flexvolume-driver: The driver is deprecated from cloud-provider-openstack repo. (#937, @lingxiankong)
* octavia-ingress-controller: Support to create TLS Ingress. The TLS support requires OpenStack Barbican deployed in the cloud, TLS Ingress creation will fail if Barbican is not available. (#927, @lingxiankong)
* openstack-cloud-controller-manager: Delete the floating IP only if it is created dynamically by the cloud controller manager. (#930, @lingxiankong)
* manila-csi-plugin: bumped csi-provisioner to 1.4.0 and csi-snapshotter to 1.2.2 (#911, @gman0)
* cinder-csi-plugin: Support volume cloning. (#868, @ramineni)
* openstack-cloud-controller-manager: Support predictable and proper server IP addresses search order. (#884, @kayrus)

/cc @ramineni @chrigl

@lingxiankong Awesome !! Thanks.
If we could categorize  the deprecation , features etc. would be good, from next release it can be taken care while adding in release note I suppose.

If we could categorize the deprecation , features etc. would be good, from next release it can be taken care while adding in release note I suppose.

That needs more customized pre-defined strings which may bring complexity, let's go with this way first and see if could get some feedback.

See v1.18.0 release: https://github.com/kubernetes/cloud-provider-openstack/releases/tag/v1.18.0


Update preservica-client-fs2 to 0.0.57

About this PR
📦 Updates uk.gov.nationalarchives:preservica-client-fs2 from 0.0.55 to 0.0.57
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "uk.gov.nationalarchives", artifactId = "preservica-client-fs2" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "uk.gov.nationalarchives", artifactId = "preservica-client-fs2" }
}]

labels: library-update, early-semver-major, semver-spec-patch, commit-count:1

Superseded by #14.


fix the blockquote light mode shading on docs

Small bug fix following #428 - the blockquotes in light mode were too dark to be legible. This PR corrects the color scheme.
before/after preview of change:

I like this - thanks!  However, there seems to be a small knock-on effect on the details shortcut:

For me, the top box (Why do I need a Spin interface?) is now so light that it no longer stands out as a box at all (whereas the second one, below the tables, is perfect).


Update privacy-shutter-notification.md

Added a phrase to describe what the AVS driver should do if underlying HW does not support the privacy shutter.

Thanks for the PR, @kasumman!


Custom Font

I'm a Mac user of Ferdi, and I don't really like to see the default font on Ferdi. I'm not sure this applies to everyone, since this is very subjective.
Would it be possible to include a feature in the settings page where you could set the font, just like how one would set the accent colour.
You could do this in VS Code, and something like that would be amazing to have in Ferdi.
VS Code Feature

Current Font:

I would love it if this was implemented.
Thanks a lot for considering this!

You can follow these steps to set fonts. Unfortunately, it gets lost if you quit or reload the app:

Go to View > Toggle Service Developer Tools
In the right side menu you will see  "styles" tab, click on it
Search for font-family in the body element and update it according to your preferences.

Interestingly Ferdi allows custom CSS per service. However, it may not be what you want as the font of the menus, etc do not change with this method.

If the CSS file isn't opened by now, it should open your file explorer/finder so you can navigate to whatsapp/user.css.
Once the file is open, paste the following CSS, replacing the my-awesome-font with your font name:

body {
  font-family: 'my-awesome-font';
}


Deployed website fails to render on Safari

Describe the bug
This seemed to worked yesterday. At least on a different device, but today the website does not render. I have not changed anything in the code.
Also note that the website renders perfectly fine on Google Chrome on my Pixel phone.
To Reproduce
Go to https://andreped.dev.
Expected behavior
Website should render seamlessly and be browser-invariant.
Screenshots

System (please complete the following information):

OS: [e.g. iOS] macOS
Browser (and its version) [e.g. chrome, safari] safari

Interesting. It does not render with Edge on macOS either. Perhaps there is a firewall issue on the network. I recently added custom web hosting to the website. Perhaps that was done wrong.

Tested Safari on my macbook at home and it worked fine, so it is likely a firewall issue.

Hmm, interesting. On the same macbook at home using Safari, when going to andreped.dev, the website first becomes impossible to reach, but after two seconds we get redirected. Something is definitely not working as it should...

Well, today it renders fine. I guess it just took some time.


Napari gui part4

Hi @jo-mueller
So I wrote most of the last part to create napari plugins.
The 'publish part' is still empty. I am trying this draft PR you mentioned. :)
Could you take a look? Also, @haesleinhuepf wanted this last part to be brief, but I couldn't make it smaller than this (unless we take the github repository part out). What do you think?

Hi Marcelo, I added a short paragraph on how to package source files, upload them to PyPi and have them distributed on the napari hub - do you think it's sufficient?

Hi Johannes @jo-mueller ,
Yes, I tested here and it worked. I also updated the blog main page. From my point of view, it is OK to merge.
As we discussed earlier, we can take out the "github desktop / github tutorial" out afterwards and put it into a separate blog post if desired.
I will just ask Robert @haesleinhuepf to take a look/review when he's back before publishing.


Fix Singularity installation on Travis CI

Fix #589

Cool, didn’t know about the apt addon. Do you still need the apt-get update line then?

That was in the warning message somewhere in fact...
I didn't try without tbh, I'll try right now

Definitively not needing it.
Thanks for spotting that @marcelm :-)


Example of the reporter option

hi all, I have react-a11y working and am seeing warnings in my browser console. I'd like to experiment with the reporter option, however I can't get it to work. Can you provide an example of the correct format?
I've tried passing in an object or a function to the reporter key, but I know I'm not getting it. It's also unclear to me what values the reporter keys should have. Everything I've tried has resulted in the following error:
Uncaught (in promise) TypeError: r is not a function
    at e.<anonymous> (a11y.js:190)
    at e.<anonymous> (test.js:229)
    at r (runtime.js:65)
    at Generator._invoke (runtime.js:303)
    at Generator.e.(:5000/meded/anonymous function) [as next] (http://[our site]/dist/vendor.js:33:82860)
    at r (asyncToGenerator.js:17)
    at asyncToGenerator.js:28

After talking it over with a colleague, I understand better how the reporter option works; that it's a call back in which I can modify how the warning is logged. Here's what I came up with to get it to look like what I wanted:
const reporterFn = (warning) => {
    const { msg, url, ...restOfWarning} = warning;
    const properties = ['AX', 'children', 'displayName', 'severity', 'tagName'];
    properties.map(property => {
      delete restOfWarning[property];
    });
    console.groupCollapsed('%c a11y issue', 'color: white; background-color: #e02549; padding: 3px 10px 3px 5px;');
    console.log(msg);
    console.log(restOfWarning);
    console.log('More info:', url);
    console.groupEnd();
  };


--mark-watched isn't working anymore

The first time I used it worked, but it hasn't worked since then.
I have attached the --verbose and --dump-pages logs. However I did remove some of the dumped pages from the log because they contained my email. If you need those pages I can email them to you I just didn't want them on here.
log.txt
Thanks for making this tool, and supporting it.

The first time I used it I didn't have the user-agent switch set, but when it stopped working I set that to try and see if that would resolve it.

It works fine at the moment. Can you check again?

Just tested it again and it seems to be working for me now. I'll start
using it in my scripts. Thanks
On Sun, May 1, 2016 at 8:59 AM, Sergey M<EMAIL_ADDRESS>wrote:

It works fine at the moment. Can you check again?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/rg3/youtube-dl/issues/8830#issuecomment-216051739


Javadoc error

In SecretLeaseContainer:
           SecretLeaseContainer container = new SecretLeaseContainer(vaultOperations,
  		taskScheduler);

  final RequestedSecret requestedSecret = container
  		.requestRotatingSecret("mysql/creds/my-role");
  		// You can have as many LeaseListeners as you want.

  container.addLeaseListener(new LeaseListenerAdapter() {
  	public void onLeaseEvent(LeaseEvent leaseEvent) {

  		if (requestedSecret == leaseEvent.getSource()) {

  			if (leaseEvent instanceof LeaseCreatedEvent) {

 			}

  			if (leaseEvent instanceof LeaseExpiredEvent) {

  			}
  		}
  	}
  });

The error is LeaseEvent, LeaseCreatedEvent, LeaseExpiredEvent were changed to prepend
Secret, eg SecretLeaseEvent.
The javadoc should be fixed.

Thanks a lot for raising this ticket. Care to submit a pull request?

I did so!


chore: migrate databuilder to neo4j-driver 4.4.5

NOT BW COMPATIBLE, UPGRADE NEO4J DB >= 3.5.5

Migrated amundsen-databuilder to use neo4j-driver 4.4.5

could you also change those version in docker file?

wait which one? I just updated the neo4j python driver but the neo4j db version is fine since its >3.5


Aggregate mozilla-central script

This is the script I'm using to calculate progress of mozilla-central migration to Fluent.

Concretely, if nobody but you can run the thing, it's an r-.

I don't understand. What do you need to be able to run the thing except of adjusting the two variables at the top?

Looking at irc and this patch, the revset is wrong, I still think the README has the right one.

The revset in README cannot work since it uses pushhead("central") and pushhead takes no arguments - https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/pushlog/init.py#l880
I tested the revset locally and it seems to work. Can you be more specific on what makes the revset incorrect (and how to correct it if you know :)).

And I prefer --cwd over positional params.

On it.

The revset in README cannot work since it uses pushhead("central") and pushhead takes no arguments - https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/pushlog/init.py#l880

The one in mozext does, https://dxr.mozilla.org/hgcustom_version-control-tools/rev/307f3c28687630bf91b4c19c913f0c677e0ae724/hgext/mozext/init.py#54-55
Here's what I have in .hg/hgrc in m-c:
[extensions]
fsmonitor =
mozext = ~/.mozbuild/version-control-tools/hgext/mozext
firefoxtree = ~/.mozbuild/version-control-tools/hgext/firefoxtree
push-to-try = ~/.mozbuild/version-control-tools/hgext/push-to-try

The one in mozext does, https://dxr.mozilla.org/hgcustom_version-control-tools/rev/307f3c28687630bf91b4c19c913f0c677e0ae724/hgext/mozext/init.py#54-55

As per sheehan who maintains the vct, mozext is deprecated:

sheehan> gandalf: can you try disabling mozext and running that command again? the mozext implementation uses the "changetracker.db" database, whereas pushlog uses pushlog2.db. I have plans to remove the former

Updated per Pike's verbal feedback:

Switched to command line arguments for mc path and gh-pages path
Switched the query to use the last push before the date, rather than the first after
Removed merge() from revset

Read for review

Updated to feedback. Ready for review.

Thanks! I like it!


[⚠ Requires recreating the snapshots to benefit from the fix] Properly guide cloud-init to use NetworkManager

Summary
Cloud-init does not generate the connections config correctly for NetworkManager as stated in issue https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/issues/772. By creating the necessary file, cloud-init will properly configure NetworkManager and resolve the IPv6 issue on our Nodes. IPv6 for Pods is step two.
Detailed info
Cloud-init correctly reads the configuration given by Hetzner, but incorrectly detects systemd-network as the network service instead of the actual NetworkManager. This is due to a missing /etc/NetworkManager/NetworkManager.conf file, which is required according to cloud-init's source code: https://github.com/canonical/cloud-init/blob/main/cloudinit/net/network_manager.py#L381
By creating this file before generating the network config, cloud-init is correctly guided to use NetworkManager and a valid file is written to /etc/NetworkManager/system-connections/cloud-init-eth0.nmconnection. The NetworkManager.conf file creation is performed in the packer file because the network configuration is generated early in the process, making it too late to create the file in cloudinit_write_files_common for example.

⭐ FYI people, here's how to upgrade existing clusters https://github.com/kube-hetzner/terraform-hcloud-kube-hetzner/discussions/794 ⭐


zpopmin not supported?

when trying to use zpopmin(key):

ioredis throws an error 'zpopmin is not a function'
the IDE autocomplete does not provide any arguments list for zpopmin (but does provide argument lists for all other sorted set commands)

can it be the zpopmin is not (yet) supported?
what would be a workaround?

The latest version of ioredis should support zpopmin. Note that ioredis depends on redis-commands v1.3.6 for the support for this command (https://github.com/luin/ioredis/blob/master/package.json#L37).

Just released v4.1.0 that supports this command.

thanks for the quick response.
updated to the latest but still get an error: "ReplyError: ERR unknown command zpopmin"

Could you run npm ls to see what the version of ioredis & redis-commands?

└─┬<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>

Could you please confirm that zpopmin works with the latest ioredis/redis-commands?
I tested the newest versions and they work with ALL sorted sets commands EXCEPT zpopmin and zpopmax!

blocking pop ops on sorted sets was only introduced in redis v5 so upgrading redis server to v5 solved it...

@ashamia We use Redis as a service on Azure.  We couldn't see any upgrade. Do you have any advice?


Fix incorrect types in packer.

The scripts fails because PosixPaths aren't casted to strings where they should be. The JSON has been changed to use strings for the file keys as using naked PosixPaths is broken for me (tested on 3.9, and 3.11 on Linux.)

Oh yeah I have this fixed locally- my bad.
I'll push the change soon

should be fixed in 466d4a0.


Missing confirmation dialogs on "clear all marks" and "save on exit"

Currently, simple "c" press will cause irreversible loss of all marks.
I suggest:

Adding confirmation dialog when clearing marks
Either add manual save as a shortcut or ask to save when exiting.

Hello.

I agree, this would be nice to have.
I don't follow. Right now marks are never cleared on exit, they can only be remove with 'u' or 'c'.

On point 2,
I meant that if you accidentally cleared all marks or just want to ignore the changes in current session, it would be nice to have a prompt to confirm savings of the changes when exiting.

Thanks!


Make user account details editable

Allow users to update their account details:

username
email
password

Originally posted by @bbronzan in https://github.com/StatCan/StatCan.OrchardCore/issues/21#issuecomment-632881639

Is a duplicate, sorry!


Attempts to download a >1GB files fail

Steps to reproduce

Attempt to download a large ~1GB file using the dropbox.filesDownload() method

Expected Result

File gets downloaded fine.

Actual Result

A V8 memory error is logged and the download fails:

Logs
/node_modules/dropbox/src/download-request.js:27
  res.on('data', function (chunk) { res.text += chunk; });
                          ^
RangeError: Invalid string length
    at IncomingMessage.<anonymous>  node_modules/dropbox/src/download-request.js:27:27)
    at emitOne (events.js:96:13)
    at IncomingMessage.emit (events.js:189:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at IncomingMessage.Readable.push (_stream_readable.js:134:10)
    at HTTPParser.parserOnBody (_http_common.js:123:22)
    at TLSSocket.socketOnData (_http_client.js:411:20)
    at emitOne (events.js:96:13)
    at TLSSocket.emit (events.js:189:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at TLSSocket.Readable.push (_stream_readable.js:134:10)
    at TLSWrap.onread (net.js:551:20)

Notes
AFAIK RangeError: Invalid string length is a V8 out-of-memory error. It basically complaints that a string's length is too long. Perhaps res.on('data') response should accumulate on a Buffer instead to circumvent this?

Thanks!
On Jun 13, 2017 6:38 PM, "Nicholas Kyriakides"<EMAIL_ADDRESS>wrote:

Steps to reproduce

Attempt to download a large ~1GB file using dropbox.filesDownload()
method

Expected Result

File gets downloaded fine.

Actual Result

A V8 memory error is logged and the download fails:

Logs
/node_modules/dropbox/src/download-request.js:27
res.on('data', function (chunk) { res.text += chunk; });
^
RangeError: Invalid string length
at IncomingMessage. (/Applications/MAMP/htdocs/matchmaker/node_modules/dropbox/src/download-request.js:27:27)
at emitOne (events.js:96:13)
at IncomingMessage.emit (events.js:189:7)
at readableAddChunk (_stream_readable.js:176:18)
at IncomingMessage.Readable.push (_stream_readable.js:134:10)
at HTTPParser.parserOnBody (_http_common.js:123:22)
at TLSSocket.socketOnData (_http_client.js:411:20)
at emitOne (events.js:96:13)
at TLSSocket.emit (events.js:189:7)
at readableAddChunk (_stream_readable.js:176:18)
at TLSSocket.Readable.push (_stream_readable.js:134:10)
at TLSWrap.onread (net.js:551:20)
Notes
AFAIK RangeError: Invalid string length is a V8 out-of-memory error. It
basically complaints that a string's length is too long. Perhaps
res.on('data') should use a Buffer instead to circumvent this?`
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/dropbox/dropbox-sdk-js/issues/139, or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2ScITvm-hSUMpDh9xWQ2CQu1944k2Bks5sDzmigaJpZM4N5R9N
.

An alternative solution:
What we can do to circumvent this limitation is to grab a temporary download link for that particular file, and then issue a GET, using https to stream the download into a file.
The problem with the "native" dropbox.filesDownload() method is that the response accumulates as a binary string on res.text. Streaming the file ameliorates that.
const fs = require('fs');
const https = require('https');
const Dropbox = require('dropbox');

const dropbox = new Dropbox({.. your opts here});

const downloadLargeFile = (path) => {
   return new Promise((resolve, reject) => {
     dropbox.filesGetTemporaryLink({
       path: path
     }).then((result) => {
       const writePath = path.resolve(__dirname, `large-file.zip`);
       const ws = fs.createWriteStream(writePath);
       const req = https.get(result.link, res => {
         res.pipe(ws);
       });

       req.on('close', resolve);
       req.on('error', reject);

     }).catch(reject)
   })
 }

// Usage
downloadLargeFile('/large-file.zip').then(() => {
 // file was saved to 'file.zip'
}).catch(err => {
  // handle err
})

@pran1990 duplicate of #101 and the PR #137 could update download-request.js and upload-request.js to return the Response object rather than buffered body. The Response object returns the stream (node-fetch) and has standardised methods to return different types of data, i.e. res.blob(), res.arrayBuffer() and res.json(). It also has properties for determining the response type (res.ok) and limiting duplicate consumption of the same stream (res.bodyUsed). Current methods in your SDK are very opposed to your company's primary focus was on syncing large files between different operating systems...
Please read: https://developer.mozilla.org/en-US/docs/Web/API/Response

I'm not sure I agree that this is a dupe of #101 (though certainly a streams-based solution should handle upload and download).  I don't have a problem with lack of stream support on upload, since I'm doing multipart upload on anything over 8Mb, and that doesn't cause any heartburn.  But not being able to download large files (due to lack of stream support) is kind of a deal killer.  I also don't see any support for doing a range request to get around this.   It seems like the ability to download large files is pretty key and that not having that should be a pretty high priority fix.

You wouldn't add stream uploads and not downloads. No contributor from Dropbox looks after this repo - might as well be depreciated - just use the fetch lib and your own wrapper to use the generated routes file in this lib from Stone.

Fair enough.  I guess the description "streams" in #101 followed by a conversation of a few posts talking about upload didn't necessarily convince me that download was assumed (particularly given that the inability to handle large files via streams in either direction doesn't really inspire confidence in how the original implementors might go about addressing this).
My original assumptions coming here (from the Dropbox developer portal) was that this API was robust, tested, and well supported by Dropbox (and I assumed that it was what Dropbox themselves used for their own web app).  I appears that all of those assumptions were incorrect (this is basically a toy API that's somewhere between poorly supported and not supported at all by Dropbox).  I wish that was in the README.
I'm fine with just using the REST endpoints directly, but I wish I'd started there instead of writing a bunch of code using this SDK.

And certainly no offense is intended to anyone not being paid by Dropbox that's trying to make this SDK better.

Thanks for the feedback! I'll send this along to the team.

At least for Node.js, this is a very easy fix.  There's a bunch of code in download-request.js that is building the giant string.  If you just eliminated that code and returned the res object from SuperAgent, then the caller would have a streamable object that they could either pipe or gather themselves into a string/blob in a few lines of code.  And that is exactly how any Node developer would expect this API to work.  I'd be happy to put together a PR for this (it would be a single-file, very straightforward change), but it would be a breaking change.

Yeh that would be unsupportable as a UMD package. The only option for native browser features and streams for node is the Fetch API.
I think the team instead of the project manager should probably trying to deduce what is right for users and Dropbox. I only see you guys doing what could be automated with Travis CI and posting updates rather than trying to deduce a reasonable solution design from our feedback. I've heard you guys are big on Go Lang so I'm more than disappointed your JS is this dated.

On 23 Aug 2017, at 5:56 pm, Bob Dickinson<EMAIL_ADDRESS>wrote:
At least for Node.js, this is a very easy fix. There's a bunch of code in download-request.js that is building the giant string. If you just eliminated that code and returned the res object from SuperAgent, then the caller would have a streamable object that they could either pipe or gather themselves into a string/blob in a few lines of code. And that is exactly how any Node developer would expect this API to work. I'd be happy to put together a PR for this (it would be a single-file, very straightforward change), but it would be a breaking change.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

My point was really just that the API is poorly designed and should return a readable stream instead of a chunk of data (string/blob).  Whether that readable stream is in fact a Superagent response object, or a Fetch response body ReadableByteStream doesn't really matter (in terms of the API definition).  It's just a stream that can be handled the way you would expect (you can pipe it or accumulate it or whatever) in either case.
I get that there's excitement around a Fetch-based rewrite, but I don't understand where that is or who decides if or when that gets merged (or really who's running this circus).  I feel like I'm looking at this trainwreck and just trying to pry the cars apart and you're working on a new bullet train (I'm fully supportive of that, but it doesn't help the passengers who are currently on fire).
I'm going to change my fork to pass back the readable stream (actually the Superagent response object, but nobody needs to know that) - because I need large file download to work like right this second and I have no shame.  I'll check back and see if a more architecturally pure solution has emerged and maybe I can abandon my hack/fork.

@BobDickinson, did you change your fork to pass back the readable stream?  I'd like to see how you did it.

@groovymarty - I did make a local change to test it, but never committed.  Frankly, I'm pretty disappointed by this library and am about ready to abandon it (maybe just write my own shim to call the REST API endpoints directly).  As I've said above, this library seems poorly designed, even more poorly tested, buggy, and pretty much abandoned by Dropbox (if they ever even did support it).
That being said, it's pretty simple to fix this for Node.js only (@sidhuko is correct that a broader solution is required for browser/UMD support of streams).
First, you want to turn off buffering if the response by passing false to buffer(), then you want to eliminated the parse call altogether.  See:
https://github.com/dropbox/dropbox-sdk-js/blob/fd6f91d6ff5570ccbdb8b2e87dbd8176bedec8eb/src/download-request.js#L92
The in the responseHandler above that, instead of doing:
data.fileBinary = response.res.text;

Just do:
data.readableStream = response.res;

Then you'll have a readableStream member in the returned object that you can do whatever you want with.

@BobDickinson - Thanks for the suggestion.. but piping the superagent's response did not work for me.  According to this SO answer you're supposed to pipe the superagent request instead.
But that didn't work either; for some reason a chunk of data at the beginning of my file was always missing.  And superagent still ran the data through a parser which buffered the entire response in memory.. no way to turn this off, and bad because my files are large.
So, following your other suggestion, I abandoned the SDK (and superagent) for this part of my application and just built my own request to the Dropbox API with straightforward node.js tools.. basically just request.post() then .pipe().  Works great.  (I'm still using the SDK for other things besides downloading.)
Agree it's frustrating when things don't work as advertised!


[Event Request] Codeunit 5815 "Undo Sales Shipment Line" - New event OnAfterCheckSalesShptLine()

Hello,
We would need a new event OnAfterCheckSalesShptLine() in procedure CheckSalesShptLine() in codeunit "Undo Sales Shipment Line".
New event:
    [IntegrationEvent(false, false)]
    procedure OnAfterCheckSalesShptLine(var SalesShipLine: Record "Sales Shipment Line"; var TempItemLedgEntry: Record "Item Ledger Entry")
    begin
    end;

Here:
    local procedure CheckSalesShptLine(SalesShptLine: Record "Sales Shipment Line")
    var
        TempItemLedgEntry: Record "Item Ledger Entry" temporary;
        IsHandled: Boolean;
        SkipTestFields: Boolean;
        SkipUndoPosting: Boolean;
        SkipUndoInitPostATO: Boolean;
    begin
        IsHandled := false;
        OnBeforeCheckSalesShptLine(SalesShptLine, IsHandled, SkipTestFields, SkipUndoPosting, SkipUndoInitPostATO);
        if IsHandled then
            exit;

        with SalesShptLine do begin
            if not SkipTestFields then begin
                if Correction then
                    Error(AlreadyReversedErr);
                if "Qty. Shipped Not Invoiced" <> Quantity then
                    if HasInvoicedNotReturnedQuantity(SalesShptLine) then
                        Error(Text005);
            end;
            if Type = Type::Item then begin
                if not SkipTestFields then
                    TestField("Drop Shipment", false);

                if not SkipUndoPosting then begin
                    UndoPostingMgt.TestSalesShptLine(SalesShptLine);
                    UndoPostingMgt.CollectItemLedgEntries(
                        TempItemLedgEntry, DATABASE::"Sales Shipment Line", "Document No.", "Line No.", "Quantity (Base)", "Item Shpt. Entry No.");
                    UndoPostingMgt.CheckItemLedgEntries(TempItemLedgEntry, "Line No.", "Qty. Shipped Not Invoiced" <> Quantity);
                end;
                if not SkipUndoInitPostATO then
                    UndoInitPostATO(SalesShptLine);

                //++ New Event
                OnAfterCheckSalesShptLine(SalesShptLine, TempItemLedgEntry);
            end;
        end;
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Assumption of supervisor in the readme.

Hi,
I am not a expert in php and Supervisor and just want to be sure to understand the below documentation correctly.
We are adding an additional service in Supervisor by copying our config file, named supervisor.config to the /etc/supervisor/conf.d folder.
In the docs we read the below:

/etc/supervisor/conf.d/*.conf: If you have some other extra supervisor conf files, place here.

See https://github.com/dwchiang/nginx-php-fpm/blob/master/README.md#part-1-base-image.
Is it true that with adding our config file the processes nginx and php-fpm are still managed by supervisor? In other words adding our config file is a merge additional configuration?

From what i can see from the config file below (specifically for bullseye), I can tell it should be,
https://github.com/dwchiang/nginx-php-fpm/blob/master/Dockerfiles/bullseye/conf/supervisord.conf
it has nginx and php-fpm already and it will include your supervisor conf from the conf.d folder
https://github.com/dwchiang/nginx-php-fpm/blob/70873195f7fa024b7d2779dc7f5695616de2279f/Dockerfiles/bullseye/conf/supervisord.conf#L28-L29
Check out your image flavour Dockerfile and conf folder for more info,
and you can always try running the image yourself and try :)

Thanks for the reaction. It indeed is. If ran the container and looked in the supervisord log file (/tmp/supervisord.log) and can confrim they are running. Thanks for the help!