Inconsistent output in array_to_latex()

Information

Qiskit Terra version: Qiskit Terra 0.18.3
Python version: Python 3.9.7
Operating system: Windows 10 (x64)

What is the current behavior?
array_to_latex() does not emit consistent latex depending on the sign of a numpy array element
For example: -5.664 gets emitted as the fraction -708/125 while 5.664 is not converted to a fraction
Steps to reproduce the problem
In a Jupyter notebook:
b = np.array(
[
[-5.664 - 3.623j, 7.672 - 4.470j, 1.864 - 7.149j],
[0.766 - 4.821j, -4.413 - 0.228j, 9.759 + 4.256j],
[1.0335 - 3.672j, 3.890 - 5.741j, 7.760 + 3.812j],
]
)
display(array_to_latex(b, prefix=r"\mathbf{B}="))
-5.664 is displayed as -705/125 but if the value is negated (to 5.664) it appears as 5.664 (not as a fraction)
What is the expected behavior?
The function _proc_value(val) at line 60 in array.py should return the same latex output
for the floating point parameter val, independent of the sign of val
Suggested solutions
In qiskit-terra\qiskit\visualization\array.py in function _proc_value(val)
Line #77 currently written as
if num + denom < 20:
Line #77 should be written as
if abs(num) + abs(denom) < 20:
Existing code causes -5.664 to get displayed as -708/125 because num = -708, denom = 125,
thus num + denom is (-708 + 125) = -583 which is less than 20,
therefore -5.664 gets converted to the fraction -708/125
Whereas 5.664 is left as 5.664 in the returned latex string
Proposed fix uses the sum of the absolute values of num and denom, to avoid the inconsistency when val is negative

This seems like an oversight, thanks for the report!

Can I work on this issue?

Sure, I'll assign you.  Let us know if you've got any questions.

Hi @deeksha-singh030 - Any success yet on implementing this fix? I'm teaching a QIS course starting January 4th - was just wondering as I am creating the slides for the class using screen shots from Qiskit. Thanks!

Hello @dbiersach - I'm sorry for being this late, I've had a medical emergency. I'm continuously trying to install qiskit-terra from source but while installing developer-requirements there is an error(exit status -1 while installing scikit-learn) occurring. I've tried to update everything and all versions as per qiskit are fine in my system but not able to install. Please help me with it.

@dbiersach without testing, I think bug is probably this line, should be abs(num) + abs(denom). If you have a local fork, you could try changing it and see if that fixes your problem.
https://github.com/Qiskit/qiskit-terra/blob/8e54baaab15fb8d3217c931f9ffc24b619277dd9/qiskit/visualization/array.py#L77

@deeksha-singh030 sounds like a problem with scikit-learn, do you have more information?

@frankharkins error that I was getting:
ERROR: Command errored out with exit status 1:
command: 'C:\Users\HP\anaconda3\envs\QiskitDevenv\python.exe' 'C:\Users\HP\anaconda3\envs\QiskitDevenv\lib\site-packages\pip_vendor\pep517\in_process_in_process.py' prepare_metadata_for_build_wheel 'C:\Users\HP\AppData\Local\Temp\tmp0260uiiy'
cwd: C:\Users\HP\AppData\Local\Temp\pip-install-s9f3kxlz\scikit-learn_2d90922b7b764b8194d880b3c7e64b6d
Complete output (71 lines):
Partial import of sklearn during the build process.
C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools_distutils_msvccompiler.py:528: UserWarning: Fallback spawn triggered. Please update distutils monkeypatch.
warnings.warn(
Traceback (most recent call last):
File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools_distutils_msvccompiler.py", line 522, in _fallback_spawn
yield bag
File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools_distutils_msvccompiler.py", line 510, in spawn
return super().spawn(cmd, env=env)
File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\numpy\distutils\ccompiler.py", line 88, in
m = lambda self, *args, **kw: func(self, *args, **kw)
TypeError: CCompiler_spawn() got an unexpected keyword argument 'env'
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools\_distutils\_msvccompiler.py", line 501, in link
    self.spawn([self.linker] + ld_args)
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools\_distutils\_msvccompiler.py", line 509, in spawn
    with self._fallback_spawn(cmd, env) as fallback:
  File "C:\Users\HP\anaconda3\envs\QiskitDevenv\lib\contextlib.py", line 153, in _exit_
    self.gen.throw(typ, value, traceback)
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools\_distutils\_msvccompiler.py", line 531, in _fallback_spawn
    bag.value = super().spawn(cmd)
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\numpy\distutils\ccompiler.py", line 88, in <lambda>
    m = lambda self, *args, **kw: func(self, *args, **kw)
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\numpy\distutils\ccompiler.py", line 171, in CCompiler_spawn
    raise DistutilsExecError('Command "%s" failed with exit status %d%s' %
distutils.errors.DistutilsExecError: Command "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\bin\HostX86\x64\link.exe /nologo /INCREMENTAL:NO /LTCG /MANIFEST:EMBED,ID=1 /LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\lib\x64 /LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\ucrt\x64 /LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\um\x64 objects\test_program.obj /OUT:test_program.exe" failed with exit status 1158

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\HP\anaconda3\envs\QiskitDevenv\lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 349, in <module>
    main()
  File "C:\Users\HP\anaconda3\envs\QiskitDevenv\lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 331, in main
    json_out['return_val'] = hook(**hook_input['kwargs'])
  File "C:\Users\HP\anaconda3\envs\QiskitDevenv\lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 151, in prepare_metadata_for_build_wheel
    return hook(metadata_directory, config_settings)
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools\build_meta.py", line 174, in prepare_metadata_for_build_wheel
    self.run_setup()
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools\build_meta.py", line 267, in run_setup
    super(_BuildMetaLegacyBackend,
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools\build_meta.py", line 158, in run_setup
    exec(compile(code, _file_, 'exec'), locals())
  File "setup.py", line 319, in <module>
    setup_package()
  File "setup.py", line 315, in setup_package
    setup(**metadata)
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\numpy\distutils\core.py", line 135, in setup
    config = configuration()
  File "setup.py", line 201, in configuration
    config.add_subpackage("sklearn")
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\numpy\distutils\misc_util.py", line 1016, in add_subpackage
    config_list = self.get_subpackage(subpackage_name, subpackage_path,
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\numpy\distutils\misc_util.py", line 982, in get_subpackage
    config = self._get_configuration_from_setup_py(
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\numpy\distutils\misc_util.py", line 924, in _get_configuration_from_setup_py
    config = setup_module.configuration(*args)
  File "sklearn\setup.py", line 85, in configuration
    cythonize_extensions(top_path, config)
  File "C:\Users\HP\AppData\Local\Temp\pip-install-s9f3kxlz\scikit-learn_2d90922b7b764b8194d880b3c7e64b6d\sklearn\_build_utils\_init_.py", line 47, in cythonize_extensions
    basic_check_build()
  File "C:\Users\HP\AppData\Local\Temp\pip-install-s9f3kxlz\scikit-learn_2d90922b7b764b8194d880b3c7e64b6d\sklearn\_build_utils\pre_build_helpers.py", line 113, in basic_check_build
    compile_test_program(code)
  File "C:\Users\HP\AppData\Local\Temp\pip-install-s9f3kxlz\scikit-learn_2d90922b7b764b8194d880b3c7e64b6d\sklearn\_build_utils\pre_build_helpers.py", line 76, in compile_test_program
    ccompiler.link_executable(
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools\_distutils\ccompiler.py", line 731, in link_executable
    self.link(CCompiler.EXECUTABLE, objects,
  File "C:\Users\HP\AppData\Local\Temp\pip-build-env-vn7kffy7\overlay\Lib\site-packages\setuptools\_distutils\_msvccompiler.py", line 503, in link
    raise LinkError(msg)
distutils.errors.LinkError: Command "C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\bin\HostX86\x64\link.exe /nologo /INCREMENTAL:NO /LTCG /MANIFEST:EMBED,ID=1 /LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\lib\x64 /LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\ucrt\x64 /LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.19041.0\um\x64 objects\test_program.obj /OUT:test_program.exe" failed with exit status 1158

@deeksha-singh030 Sorry I'm not really sure what's causing that. You could try up/downgrading python version?

@frankharkins  I'm working with python 3.9.7.

Can you show the full install command for scikit-learn, or whatever you're installing right now?  It seems to indicate that you're trying to build scikit-learn from source, but that shouldn't be necessary at all - you should be able to install it by wheel.

@jakelishman I was installing qiskit-terra  from source as per the commands given the qiskit documentation.

@deeksha-singh030 are you still working on this?

@frankharkins I've made the required changes as suggested by @dbiersach in the issue. Please take a look on it.
Sorry for being so late. I was trying to do this after installing qiskit-terra from source and I'm still not able to do it from source.  It would be very helpful if you could help me how to work on issues from source.


Docker image

Hey folks,
we would like to use this worker in our k8s-cluster.
For now, we're building our own image like that:
FROM openjdk:15-jdk
ARG VERSION=0.4.0

COPY zeebe-dmn-worker-$VERSION.jar app.jar

ENTRYPOINT [ "java" ]
CMD [ "-Djava.security.egd=file:/dev/./urandom", "-Dzeebe.client.broker.contactPoint=zeebe-gateway:26500", "-jar", "/app.jar"]

Is there a chance to implement an "offical" Dockerfile as there is for other workers like script or http?
Regards!

Hi @Hermsi1337!
I'm working on it :sweat_smile: I'll publish the docker image in the next days.
I'll notify you when it's done :balloon:

Ok. The docker image is built and published. Please have a look at https://github.com/zeebe-io/zeebe-dmn-worker/tree/master#docker
Does this work for you?

Wow, works like charm! Many thanks @saig0 <3
One question aside:
We've written Helm-Charts for all workers in order to deploy them to k8s. Would you accept pull-requests for Helm-Charts?

@Hermsi1337, that is awesome! I would love to integrate them :rocket:


add support for UPM

VPM will use UPM so I think this is useful in the feature. The package.json I added includes configuration only for VPM.

Sorry, I forgot to mention. If possible, can you create new release (1.1.1)? I want a tag (version) that includes package.json.

Done.

Thank you


Cannot start plasmashell

Describe the bug
Cannot start plasmashell
Steps To Reproduce
Steps to reproduce the behavior:

plasmashell --replace

Expected behavior
plasmashell starts
Logs
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, xcb.

zsh: IOT instruction (core dumped)  plasmashell --replace

Logs with QT_DEBUG_PLUGINS=1
Cannot load library /nix/store/b7p2kyi3qn281x9b9bz4qjhan53vgmj4-qtbase-5.15.8-bin/lib/qt-5.15.8/plugins/platforms/libqxcb.so: (/nix/store/8bmp6r3a0xfha3wj36phlc47clh9w81l-glibc-2.35-224/lib/libc.so.6: version `GLIBC_2.36' not found (required by /nix/store/jj9ffqy88cffrywn1kgpxkgkkzs5rj4m-libICE-1.0.10/lib/libICE.so.6))
QLibraryPrivate::loadPlugin failed on "/nix/store/b7p2kyi3qn281x9b9bz4qjhan53vgmj4-qtbase-5.15.8-bin/lib/qt-5.15.8/plugins/platforms/libqxcb.so" : "Cannot load library /nix/store/b7p2kyi3qn281x9b9bz4qjhan53vgmj4-qtbase-5.15.8-bin/lib/qt-5.15.8/plugins/platforms/libqxcb.so: (/nix/store/8bmp6r3a0xfha3wj36phlc47clh9w81l-glibc-2.35-224/lib/libc.so.6: version `GLIBC_2.36' not found (required by /nix/store/jj9ffqy88cffrywn1kgpxkgkkzs5rj4m-libICE-1.0.10/lib/libICE.so.6))"

Notify maintainers
@ttuegel @nyanloutre

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.24, NixOS, 23.05 (Stoat), 23.05pre474054.85b081528b9`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.3`
 - channels(aroun): `""`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Hum, my bad, I am using a custom build of plasma-workspace. I guess I have to update it and recompile the whole thing...


find-cache-dir

Consider using find-cache-dir to locate the default cache directory. This is what babel-loader and eslint-loader are already doing, so it shouldn't surprise the user. I'm personally interested in this because I don't like unnecessary configuration (changing plugin options), .gitignore / .eslintignore / .prettierignore / .dockerignore / .*ignore bloat, and longer directory listings.
One thing to look out for is that yarn wipes out node_modules/.cache on every install, apparently, but no big deal, this is just a cache.

Sounds like a great idea, thanks for the heads up!


Views in Navbar disappear when rotating while shrunk

First time posting an issue; hope I'm not breaking an "rules"
Anyways, I'm using TLYShyNavBar with a TableView and it works great for the most part. However, the Title object in my NavBar disappears when the NavBar is "shy," as seen in this video: http://youtu.be/Eb2B4J040ak
My NavBar is Opaque, and I fixed that bug with self.extendedLayoutIncludesOpaqueBars = true — not sure if that's affecting it.
Let me know if any other info is needed. Thanks!

After some testing, this only happens when translucency is off.

Then probably it's a duplicate of #7 , thanks for the report!


Make it possible to configure SAUCE_API_HOST from environment

add environment variable which sets the SAUCE_API_HOST. This is
required to use the new EU datacenter.
use this variable in all the places

Cf. https://github.com/bermi/sauce-connect-launcher/pull/140 for a similar change in sauce-connect-launcher.

[x] We will have to update the sauce-connect-launcher dependency, once this is merged.

This is just what I need 👍

@AlexanderMoskovkin would you kindly review this PR? :)

Or maybe @AndreyBelym, do you have any input on this?

I would really like this feature to be merged due to network latency problems with US SauceLabs.

Very good, I would really like to see this PR merged as well.

Thank you for your contribution, I'll publish it and update testcafe-browser-provider-saucelabs today.

Great, I'll wait for the update of the browser provider!

@douwekasemier thank you for your patience, I've published<EMAIL_ADDRESS>that contains the updated saucelabs-connector module and supports switching API endpoints.


add deis CLI unit tests

related to #2392. Our CLI is being covered by our integration test suite, but there are some changes that would be more fitting as unit tests for a faster response time.

I know that we've tossed around the idea of re-writing the client in Go to take advantage of static compilation as well as having the ability to share resources between the controller and the client, so it may be more worthwhile to punt on this one for a little bit.

Tracking in #3806


Wishlist.

(Love the project, awesome work).
I see Devin/this project doing demos like "do this simple video game from scratch", or "do a to-do list web app", starting from zero and using whatever libraries/technologies it prefers.
Those are neat, but I don't think they are the most useful, at least for some people.
Here's what I would want/need these projects to do, in case that would be useful to know, in the form of the prompts as I'd ask them of the agents:

(Coming into my existing project/database), tell it: « in src/lib/Editor.ts, there's a function to resize images according to the specs it finds in the database, I'd like that function (and the other sub-functions it calls) to be put into a new library named Resizer.ts in src/lib/utils/, and change Editor.ts to use that library »

« Once that's done, find other places in the code where we resize images, and for each, change them to use the new Resizer library. »

« In src/test, using the same format and testing library as I am already using in my tools, write a series of tests for the Resizer library. You can find "sample" images to resize inside of data/samples/resized-images/ »

« My project is made of two parts, the scripts (run with Node) in src/, and the ui (written in Vuejs, run in the browser) in ui/src/. Each part has its own "Page" class/abstraction with different functions/properties. I'd like you to join both of these into a single file/class that both the scripts and the UI can call/use. This is tricky because a few of the libraries the "scripts"-side class uses will not work in the browser. You must find a solution that allows us to have only one class everything imports, but to not have errors in the browser despite this. Propose and explain in detail a possible solution to this problem for me to review, then if I like the solution I'll ask you to implement it. »

If your project was able to do this, it would completely change my life.
Just a wishlist :)
Awesome work by the way.

I second that, brilliant work !
One feature I would find really useful -
Cache requests and outputs that work, so they could be re-used during future executions.
Thanks.

Sorry, we are currently at a high intensity of work, so the response is very slow. We are solving the scenario you mentioned, please wait for a while.


Active item styling

Heya guys, i'm using this as a horizontal picker sort to speak... with text data (almost like the simple example on start page)
Is there a way to style the active item?

⚠ You did not follow the contributing guidelines!
As stated in these:

You need to fill out the issue template. This step is mandatory! Not doing so will result in your issue getting closed. Don't take this personally if this happens, and feel free to open a new issue once you've gathered all the information required by the template.

Regarding your question, see #320.


Implement Sunburst chart

We need to implement a segmented pie chart for UI Kit
https://www.figma.com/design/i3KCEXUXgAb6CfO1sYX2h3/SSA-dashboard?node-id=7630-12176&t=Xcx968UL1mUXjJcW-4
For the legend we need to allow displaying totals in the 1st column (with percent values in brackets). The overall total is inside the circle.
The popup for each small area displays the title of the area (i.e. BTC), its percentage, the option title (i.e. 'In Use'), and its percentage.

we need to adjust the following:

overall total should be not calculated in the chart but received as a parameter (incl. the dimension)
percents should be calculated in the control.
we should be able to configure whether to show/hide percents as well as provide rounding parameters (0,1,2 digits after comma)
dimensions on the legend should be also configurable (and it should be possible not to use them)
on the popups we need to show values and percentage (now - only percentage)


Update installer.nsi

@RocketChat/core
Sometimes on windows machine , installing a new version gives error and doesn't change icons and other system cached files over the previous version. With these changes, the installer will detect a previous version of the program if applicable and then ask to completely uninstall it by running the uninstaller and then start with new installation process.

How does one test this out?

@graywolf336 Do you mean reproducing the bug ? or testing the changes to installer ?
I am really sorry , but i have very little clue of testing installers. This my first time dealing with it.
Though i am now curious about testing too. If you can suggest anything please do.


Blackscreen with ESP32-24325024R /driver chip ST7789

I thought that buying any yellow ESP type would work, but when I flashed two versions, one with a micro USB port and one with two USB ports, the flashing was successful. However, when I unplugged the power and plugged it back in, the screen didn't show anything. Can anyone help me?

Here is the picture

It looks like you're using the 2.4" CYD variant. Unfortunately, for now, only the 2.8" modules are supported by this webflasher


AYON workfiles tools: Revisit workfiles tool

Changelog Description
Revisited workfiles tool for AYON mode to reuse common models and widgets.
Additional info
Reused models and widgets from ayon_utils. Button "Go to current context" works. Refresh button refreshes workfiles too.
Testing notes:

Launch DCC/host of your choice
Open workfiles tool
Try few standard things with workfiles tool

Try to open/save workfiles
Change context and open/save
Save artist note
Open published file
Copy published file
Hit refresh (should refresh all folders, tasks and workfiles)

I saw this commit - I think that's nice ❤ but was just wondering whether this was implemented to resolve certain bugs or issues? I'm asking because it's totally possible to save new files without the work files tool which might not have the info stored regardless of whether the workfiles tool would have done so.

Mmt, retesting...

Actually I found two issues, one warning after Workfiles dialog shows up:

and secondary  when file is saved:

Actually I found two issues, one warning after Workfiles dialog shows up: (in AE)

Strange, that code didn't change in this PR.


fix: ODS-2054 issues

During the nightlies exectuion (e.g.: autotrigger-smoke/124) the test "ODS-2054 - Verify Openvino_IR Model Via UI" was failing, and it was because the flow has been modified

Test results after modifications:


[v2.0] Port previous development branch to new main + PHPUnit 8.x support

With this pull request we restore the old development branch into the current main branch and, on top of that, we merge changes from #639 (based on the codebase from v1.1) and convert to PHPUnit 8.x all remaining tests for classes that didn't exist in the stable branch. Quite a bunch of things changed for v2.0 compared to v1.1 and after reviewing all of the changes I decided to preserve all of them as they are for this PR as I'm still OK with the overall direction. This doesn't mean that everything is set in stone, some changes still need work and other things might change again.
Commit 592dd91 was required due to the nature of the change or PHPUnit would have been unable to complete running the test suite. On the other hand there's still a failing test related to compatibility with Redis 6.0 (slightly different response payload to COMMAND INFO), I already have a fix but purposely left this change for a later pull request.
This doesn't address any deprecated function in recent PHPUnit releases (PHPUnit\Framework\TestCase::at() is the worst offender but there are a couple of more) which will need to be fixed, some fixes are easy others are not.
This pull request addresses #624 and integrates work from #639 so they can both be closed as soon as this one is merged into main.

Incredible work. Just started looking into the files :)

Just to make things clear, most of the feedback that will be provided here won't be implemented with this PR (I mean stuff like this, this and this) but will be handled separately with specific pull requests with direct references to these comments.
The reason for this PR is to get a general review of what's going to be merged in main and eventually fix oversights mostly related to the merge of two diverging branches. Still, any kind of quick feedback or requests for clarification would be appreciated, I think it's a great opportunity even if I'm plenty aware that going through such a massive changeset is demanding.

Just for information, I got the test suite running locally on PHP 8.0 by using composer install --ignore-platform-reqs to bypass the version constraint of phpspec/prophecy which is still preventing phpunit from being installed on this runtime. The test suite runs just fine. I don't think it's possible to configure our workflow so that --ignore-platform-reqs is used only when running builds on PHP 8.0, but I'm just too new to GitHub Actions to know that for sure. Anyone?

Just for information, I got the test suite running locally on PHP 8.0 by using composer install --ignore-platform-reqs to bypass the version constraint of phpspec/prophecy which is still preventing phpunit from being installed on this runtime. The test suite runs just fine. I don't think it's possible to configure our workflow so that --ignore-platform-reqs is used only when running builds on PHP 8.0, but I'm just too new to GitHub Actions to know that for sure. Anyone?

Running tests for PHPUnit 8 in a separate workflow file makes sense. That's one way to do it.

Just for information, I got the test suite running locally on PHP 8.0 by using composer install --ignore-platform-reqs to bypass the version constraint of phpspec/prophecy which is still preventing phpunit from being installed on this runtime. The test suite runs just fine. I don't think it's possible to configure our workflow so that --ignore-platform-reqs is used only when running builds on PHP 8.0, but I'm just too new to GitHub Actions to know that for sure. Anyone?

@nrk please take a look on #646

@nrk please take a look on #646

@b1rdex Nice and clean! Thanks!

If there's nothing to add or review, I'm going to merge this sometime tomorrow (CEST) along with #646. Separate pull requests addressing the rest of the feedback not implemented here will follow.

@nrk: Fantastic!

Guess what? :tada: And with #646 we also have PHP 8 covered.

By the way I don't have a PR for class names in the Predis\Command\Redis namespace yet. They will be changed for sure, but I think it's low priority for now and it's mostly a chore. In the meanwhile I'm still deciding how to properly handle the conversion $commandID => FQCN in Predis\Command\Factory::createCommand(). Maybe I'll just open a separate issue for now and we'll see.


Support a default mono_pkg.yml for subpackages

Most of the packages in https://github.com/dart-lang/build want the exact same travis config (actually, all of them I think), but today they all need their own .travis.yml file.
It would be nice if I could provide like a default.travis.yml in the root, and it would apply that to any package which didn't have one.

So, @jakemac53, is this done, sorta?

not really, I changed the title though now that we are using .mono_repo.yml files

@jakemac53 what about a root .mono_repo which would have files you could sync over? Could maybe even use some of the package info or something from dependent pubspecs?

Maybe mono_pkg.shared.yml?

...or a key within mono_repo.yml?


python310Packages.reolink-aio: 0.3.1 -> 0.3.2

Diff: https://github.com/starkillerOG/reolink_aio/compare/refs/tags/0.3.1...0.3.2
Changelog: https://github.com/starkillerOG/reolink_aio/releases/tag/0.3.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 214139 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.reolink
python310Packages.reolink-aio
python311Packages.reolink-aio


[BUG] Need to enforce using >1 core.

Describe the bug
When only one CPU core is available, by default cellfinder will try to keep 2 cores free, meaning that -1 cores are available, and nothing runs.
To Reproduce
Run cellfinder with default settings on a CPU with one core
Expected behavior
Run on the single core that's available.

Fixed in 8031fded41f0dc1495b3a2e2523a056a1582370c, by increasing required imlib version.


Connect your Android device: Android Basics with Compose

URL of codelab
In which task and step of the codelab can this issue be found?
Describe the problem
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Hello @A-zouine,
Thank you for reaching out to us.
Could you please give us some more context, like what exactly is incorrect?
May be some logs, screenshots and filters you are using will help.

Duplicate of #232, #231

Closing this issue, since there is no issue description.
Please create a new one, if you need help.
All the best learning Android.


Binder RuntimeException from the binder stub implementation.

Not sure if this is a butterknife bug but sometimes I get an error

SDK 23
Support libs 23.0.0
Gradle plugin: 1.3.0
Gradle: 2.6

 W/Binder﹕ Caught a RuntimeException from the binder stub implementation.
    java.lang.NullPointerException
            at android.view.WindowManagerGlobal.dumpGfxInfo(WindowManagerGlobal.java:449)
            at android.app.ActivityThread$ApplicationThread.dumpGfxInfo(ActivityThread.java:1116)
            at android.app.ApplicationThreadNative.onTransact(ApplicationThreadNative.java:582)
            at android.os.Binder.execTransact(Binder.java:404)
            at dalvik.system.NativeStart.run(Native Method)

That stacktrace doesn't include ButterKnife code and that's a binder problem which is something ButterKnife doesn't use. This almost certainly has nothing to do with this library.

:+1: just saw Binder and get confused, sorry.

@caipivara I am also getting the same log. What is the issue ?


Complete rewrite for V6 release

This pull request is for the complete rewrite of this project. The aim is to create a robust codebase that is modular, flexible and easy to maintain. Below is a list of features and functionality that is to be implemented. The list is updated continuously and might change as development is progressing.
Functionality list

[ ] Unit tests

[ ] Common mock utilities: Create common mocks and utilities used when creating unit tests.
[ ] Good coverage: Aim for high test coverage through unit testing all possible components in the application.

[ ] Core

[x] Application entrypoint: Starting file (index.ts).
[x] ShardClient: The client responsible for connecting a set of shards.
[ ] ShardManager: The manager responsible for spawning a set of shard clients to utilize multiple processes.

Needs clarification with Eris.

[x] DeploymentDispatcher: Manages verification and deployment of application commands to Discord API.
[x] CoreValidator: Responsible for validating critical configuration and required dependencies.

[ ] Events

[ ] Client

[ ] guildCreate, interactionCreate, ready, etc.:  Handle relevant events from discord.js client.

[ ] Player

[ ] playerStart, playerFinish, willAutoPlay, etc.: Handle relevant events from discord-player player.

[ ] Process

[ ] uncaughtException, unhandledRejection, etc.: Handle relevant events from Node.js process.

[x] EventHandlerManager: Initializes event listeners for the defined event handlers.

[ ] Interactions

[ ] Autocomplete:

[ ] Play: Execution logic for autocomplete trigger in the /play command.
[ ] Lyrics: Execution logic for autocomplete trigger in the /lyrics command.

[ ] Component

[ ] ButtonPauseResumeTrack: Execution logic for button component used to pause and resume tracks.
[ ] ButtonPreviousTrack: Execution logic for button component used to go back in queue.
[ ] ButtonNextTrack: Execution logic for button component used to go forward in queue.
[ ] ButtonFiltersDisable: Execution logic for button component used to disable current audio filters.
[ ] SelectMenuFilters: Execution logic for select menu component used to select audio filters.
[ ] Others: Other components not yet planned.

[ ] Slashcommand

[ ] Back: Execution logic for the /back slash command.
[ ] Filters: Execution logic for the /filters slash command.
[ ] Help: Execution logic for the /help slash command.
[ ] History: Execution logic for the /history slash command.
[ ] Join: Execution logic for the /join slash command.
[ ] Leave: Execution logic for the /leave slash command.
[ ] Loop: Execution logic for the /loop slash command.
[ ] Lyrics: Execution logic for the /lyrics slash command.
[ ] Move: Execution logic for the /move slash command.
[ ] Nowplaying: Execution logic for the /nowplaying slash command.
[ ] Pause: Execution logic for the /pause slash command.
[ ] Play: Execution logic for the /play slash command.
[ ] Queue: Execution logic for the /queue slash command.
[ ] Remove: Execution logic for the /remove slash command.
[ ] Seek: Execution logic for the /seek slash command.
[ ] Settings: Execution logic for the /settings slash command.
[ ] Shards: Execution logic for the /shards slash command.
[ ] Shuffle: Execution logic for the /shuffle slash command.
[ ] Skip: Execution logic for the /skip slash command.
[ ] Status: Execution logic for the /status slash command.
[ ] Stop: Execution logic for the /stop slash command.
[ ] Volume: Execution logic for the /volume slash command.

[x] InteractionHandler: Responsible for handling incoming interactions and routing them to correct executor.
[ ] HookManager: Manages loading and execution of hooks for interactions.

[ ] Services

[ ] Insights

[x] LoggerService: The logger service used throughout the application.
[x] HealthCheckService: Health check service for managing and running defined health checks.
[ ] MetricService: Service used throughout the application to collect different metrics.

[ ] Player

[ ] PlayerService: The service used for interfacing against discord-player.

[ ] Security

[ ] RateLimitService: The service used for managing rate limits for users.

[ ] Storage

[ ] PrismaClient: Client for prisma ORM.
[ ] StorageClient: The storage client used for storing and retrieving persistent data.

[ ] Utilities

[ ] EmbedHelper: Helper utility for generating embeds, replies and related data.
[ ] LocaleHelper: Helper utility for translation throughout the bot.
[ ] FormattingUtility: Helper utility for formatting values.

[ ] Validation

[ ] ValidationHandler: Handles the validators defined in subfolder.

Other notable changes

The project now follows a more object-oriented approach, utilizing dependency inversion to allow for unit testing.
Change from npm to pnpm for a faster package manager.
Change from eslint and prettier w/ their extensions to @biomejs/biome for a faster and all-in-one linter and formatter.
Change from discord.js to eris as Discord API client library to reduce memory consumption.

Closing, will be tracked at https://github.com/mariusbegby/cadence/issues/9 instead.


WIP: Update to use Perl 5.30.0

Description
This PR adds omnibus overides to upgrade the version of Perl to 5.30.0 and sqitch to a compatible version (0.9999).
Signed-off-by: Christopher A. Snapp<EMAIL_ADDRESS>Issues Resolved
#2166
Check List

[ ] New functionality includes tests
[ ] All buildkite tests pass
[ ] Full omnibus build and tests in buildkite pass
[X] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
[ ] PR title is a worthy inclusion in the CHANGELOG

https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2783#ab96bea6-2edb-4967-bae3-6f755a75cbae

https://buildkite.com/chef/chef-chef-server-master-omnibus-adhoc/builds/2829#0c8f7189-3902-4b7f-84de-582060dc19b2

Closing this out since we're not working this one right now and we'll just bump the pin in a new branch


Failed autosizing columns of worksheet 'Subscriptions'

''
The property 'HorizontalAlignment' cannot be found on this object. Verify that the property exists and can be set.
At C:\Program Files\WindowsPowerShell\Modules\ImportExcel\7.1.2\Public\Set-ExcelRange.ps1:107 char:17

...               $Range.Style.HorizontalAlignment = $HorizontalAlignment

CategoryInfo          : InvalidOperation: (:) [], RuntimeException
FullyQualifiedErrorId : PropertyNotFound

The property 'Format' cannot be found on this object. Verify that the property exists and can be set.
At C:\Program Files\WindowsPowerShell\Modules\ImportExcel\7.1.2\Public\Set-ExcelRange.ps1:128 char:17

...             $Range.Style.Numberformat.Format = (Expand-NumberFormat $ ...

CategoryInfo          : InvalidOperation: (:) [], RuntimeException
FullyQualifiedErrorId : PropertyNotFound

WARNING: Failed autosizing columns of worksheet 'Subscriptions': You cannot call a method on a null-valued expression.
WARNING: Failed adding PivotTable 'P1': Index operation failed; the array index evaluated to null.
WARNING: Failed adding chart for pivotable 'P1': Cannot bind argument to parameter 'PivotTable' because it is null.
''

I don't know reason ,in line 302 get empty variable! When run outside the scrip  json has null id values and can't run  ConvertFrom-Json, in [].data has null values to id
$Resource = az graph query -q  "resources | where subscriptionId == '$SUBID' | order by id asc" --skip $Limit --first 1000 --output json --only-show-errors | ConvertFrom-Json

I found a fix, put limit lenght in properties  where strlen(properties) < 123000
$Resource = az graph query -q  "resources | where subscriptionId == '$SUBID' |  where strlen(properties) < 123000 | order by id asc" --skip $Limit --first 1000 --output json --only-show-errors | ConvertFrom-Json

Hi,
Yea, very strange behavior.
Thanks for the fix, I included it in the version 1.4.11.
Thanks

Thanks @ClaudioMerola !
it is not perfect because exclude resources witch big strings in properties.definition.actions, like big Logic Apps. In may company 3!


StorageLoader: handle return code of 4 for EmrEtlRunner in snowplow-runner-and-loader.sh

See https://github.com/snowplow/snowplow/issues/2546

For what I understand from this comment, it should output error-specific message and exit with 0?

Correct


vm/vmss create: don't throw when tries to retrieve image to extract the plan information

The context is some images are still being staged and not yet published, hence image API won't go through. Instead of fail (therefore block the create), the suggested change is to warn. I am fine with it, as using market place image with plan is a minority scenario.
The code to wrap inside a try-catch is here

Prioritizing it per CRP team's ask


[PR Workflow] If BreakingChangeReviewRequired gets removed due to an update, the ARMChangesRequested label incorrectly sticks on the PR

Workflow-bot doesn't have a proper rule for it:

https://github.com/Azure/azure-rest-api-specs/blob/main/.github/comment.yml

Example occurrence of this problem:

https://github.com/Azure/azure-rest-api-specs-pr/pull/14001#event-9996675767

This will be properly fixed with:

https://github.com/Azure/azure-sdk-tools/issues/6624

The PR summary logic for the label says it should stay if already present: source

Looks like we are also missing a rule for someone removing ARMSignedOff

Related recent improvement:

https://github.com/Azure/azure-sdk-tools/issues/8145


isTweening in Velocity.js?

What's the GSAP isTweening equivalent in Velocity?
I can't seem to find anything similar in the docs.

You can check if element has class velocity-animating.

That's a bit ugly tbh. The engine should have something faster that doesn't need to check the DOM.

var $element = $('.element').velocity('slideUp');
$element.data().velocity.isAnimating

That makes more sense.
Thanks @makshh !

Just be aware that this is unsupported behaviour - and may change in future versions (it should get an announcement if we change how it stores data though)


ox.plot_route_folium returns "KeyError:<PHONE_NUMBER>"

Hello dear developers! Thank you for your work!
I am writing master thesis and trying to use osmnx
While using ox.plot_route_folium it returns error: "KeyError:<PHONE_NUMBER>"
Will be glad for any feedback!

Please reread the new issue template and contributing guidelines. Incompletely filled-out issues and all how-to questions are automatically closed.


feat: container image build ci for push image to github registry

Use GitHub CI to build the latest Container image on git push and store container image on GitHub registry
Signed-off-by: Pratik Raj<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

which use case is missing with the current docker image?

Current docker image hosted on Dockerhub, which is having rate-limit.
Under a on-prem or org network , it get exhausted easily.
i.e. why added workflow to build and store it in ghcr, Github Own Container Registry

OK, then why is the workflow pushing on every git push, rather than for every tag (like docker hub)?

@Rajpratik71 then why is the workflow pushing on every git push, rather than for every tag (like docker hub)?


Overwrite variableSassFiles config

Short description of the problem:
Does  not have a way to overwrite variableSassFiles in ionic config
What behavior are you expecting?
Have ability to overwrite/update current variableSassFiles in config file through package.json/process.env
Steps to reproduce:

moved /src/app/variables.scss file to another location
run $ ionic serve
get Error:

sass: stdin, line: 1
 File to import not found or unreadable: .../src/app/core/variables.scss Parent style sheet: stdin
sass failed

Which @ionic/app-scripts version are you using?
v1.0.0
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
suggest to add configs as other variables, such as sourceFileName in https://github.com/driftyco/ionic-app-scripts/blob/master/config/cleancss.config.js#L8

Yes, you should be able to configure all paths by customizing the scss.config.js file.
https://github.com/driftyco/ionic-app-scripts#custom-configuration
Thanks,
Dan


why both

Hi, love cvui.
Why does it seems that I need both cvui image and imshow to display an image. I've tried them individually but then they don't show anything at all.
cvui::image(frame, 25, 25, im_with_keypoints);
...
cvui::imshow(WINDOW1_NAME, frame);
Thank you.

Hi, im not the specialist out there, but as far as I know you can put multiple images on frame, but it won't show up until you call imshow(window, frame), because you have to pass the frame to window to show it

The explanation provided by @WojOstr nailed it. For further understanding, @coldstart01 , the function cvui::image() is one (of the many) drawing primitives cvui has. They all work putting pixels in a frame (a  cv::Mat). When you are done drawing things (images, checkboxes, etc), you need to call OpenCV's function to show the frame in a window.
cv::imshow() is that function. Since cvui does a lot of heavy lifting under the hook, e.g. detect shortcut keys, it has its own version of imshow named cvui::imshow. In practice they do the same thing (show a frame in a window), but cvui's one some things extra.
Is it clear now?

Ive built a few GUIs with cvui and its lightweight construction has allowed me to control ooencv programs in real time with transparent overlays. Its easy, made my programs more responsive. For example i made an overlay that implemented in real time control over many if the params. Thanks for helping further understanding.
--
On Mon, Apr 5, 2021, at 4:53 PM, Fernando Bevilacqua wrote:

The explanation provided by @WojOstr https://github.com/WojOstr nailed it. For further understanding, @coldstart01 https://github.com/coldstart01 , the function cvui::image() is one (of the many) drawing primitives cvui has. They all work putting pixels in a frame (a cv::Mat). When you are done drawing things (images, checkboxes, etc), you need to call OpenCV's function to show the frame in a window.

cv::imshow() is that function. Since cvui does a lot of heavy lifting under the hook, e.g. detect shortcut keys, it has its own version of imshow named cvui::imshow. In practice they do the same thing (show a frame in a window), but cvui's one some things extra.

Is it clear now?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Dovyski/cvui/issues/106#issuecomment-813643595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMAYAAWDHYPCOTJROKZ6RVLTHIPNPANCNFSM4ZZZ5KZA.

I am very glad to hear that, @coldstart01, thank you!


Fix bug when a dimension has only one value

When a dimension has only one value it needs to be wrapped in an array so
the length used when computing the offset is the one of the array and not
the value string itself.
Adds splitting the data also by ; , and tabs (according to the pc-axis spec),
instead of only by spaces.

Thank you @amaia !


Interop support for Numba?

@AviKav Although I have heard of them, I have never used anaconda or numba before. Can you tell me how you think the interop should work ?

@AviKav From what I can see numba does not have the ability to create arrays from existing device pointers. It also doesn't return device pointers so users can copy to it manually. Any support we add now will have to do a costy two way transfer (arrayfire --> numpy --> Numba).
Unless I am wrong, you will have to create an issue on Numba to support external CUDA libraries.

Nevermind, I found DeviceNDArray which seems like it should do the trick.

@AviKav I added support to create arrayfire arrays from numba arrays similar to what is happening for numpy and PyCUDA. I'll need to add functions to go in the other direction.
I am closing this issue and dealing with the reverse transfers over here:
https://github.com/arrayfire/arrayfire-python/issues/128


Add document for ambiguity handling

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

@annelo-msft @chunyu3 The audience are the codegen users (i.e., service team) who are curious about the logic how the signature of method is generated.

it might be helpful to think about how this document works in the context of larger documentation efforts

For sure. But seems customer is asking for this document so I think we could continue this PR, and after we decide how to refactor we could move this page to that efforts.

is this what we're doing today, or does it take into account future plans

This is what we are doing today. It doesn't take any non-branding cases into account.


Line numbers alignment problems

I'm using Prism with both the Line Highlight and Line Numbers plugins, downloaded a few days ago, and am having several issues with line number alignments.
With Firefox, I get the following alignment:

I tried fixing the height of the highlighted number with
    .line-highlight {
    margin-top: 0em;
    }

which seemed to do the trick in Firefox:

But in Google Chrome, the alignment is wrong no matter what. Without setting "margin-top" to 0em, I get:

Setting "margin-top" to 0em lifts the number a little bit, but not enough.
My installation is at http://rintze.zelle.me/csl-validator/ . To reproduce, select "0.8.1 (styles only)" as the CSL schema version to validate against, and use https://raw.githubusercontent.com/citation-style-language/styles/master/dependent/nature-biotechnology.csl as address. The page currently has some inline CSS to set "margin-top" to 0em.
A second issue is that resizing to a smaller window results in line wrapping of the code, but the line numbers don't change to accommodate:

You can add the following css:
pre {
overflow: auto;
word-wrap: normal;
white-space: pre;
}

This should be fixed by #732.


feature request: filetype field to formatters

Did you check existing requests?

[X] I have searched the existing issues

Describe the feature
Would be really nice to add a filetype field containing a table with the default filetypes associated with the formatter. It would really help to setup the formatters .
Provide background
No response
What is the significance of this feature?
strongly desired
Additional details
No response

What's the problem with the formatters_by_ft table?


configuration rule clarity

Describe the bug
Currently the logic of resolving command line flags combined with configuration lookup is split not very well. Half resides in main.rs the other in config.rs.
Sa

args.rs unified that


Speed comparison with GBParsy

I was looking for a fast way of processing large amounts of genbank entries, and found your library. It definitely offers an improvement over biopython, but I'm wondering why did you not include GBParsy in the speed comparison? It is a parser written in pure C, and likely even faster than gb-io.

Lee TH, Kim YK, Nahm BH. GBParsy: a GenBank flatfile parser library with high speed. BMC Bioinformatics. 2008 Jul 25;9:321. doi: 10.1186/1471-2105-9-321. PMID: 18652706; PMCID: PMC2516526.

https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2516526/
https://github.com/thlee/gbfp/

Hi @xapple,
I did not include GBParsy because i was not aware of this project, and since it's not on PyPI it's not exactly the most convenient, tools-included GenBank parser out there. Additionally, I tried to build from source from the GitHub repository you linked, but the code seems quite outdated (it still uses the PyString_FromStringAndSize C API, which was removed from Python 3)...

Yes, you are right, the code was written in 2008 which is sixteen years ago, and is probably not compatible with the current Python C API. Also, it has not been uploaded to PyPI or conda-forge.
Digging a bit deeper I did realize that the code on the GitHub repository is an export of the old google-code repository and doesn't represent the latest version. The repository has v0.5.0 while the supplementary file of the publication iteself includes v0.6.0 (2008-07-10) at:
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC2516526/bin/1471-2105-9-321-S1.tgz


add rbac checks in all the pages

Fixes

https://issues.redhat.com/browse/HAC-3430
Description

Add access checks to the pages and show an no access state if user does not have enough access to view or perform an primary action on a page.
Type of change

[x] Feature

Screen shots / Gifs for design review

Add Integration test page:

Browser conformance:

[x] Chrome
[x] Firefox
[x] Safari
[ ] Edge

cc: @beaumorley @Misjohns @christianvogt

/cc @rottencandy @christianvogt

Thanks @abigaeljamie. I have updated the content and screenshots.


Instrument Tests with SingleThreadedUnaryStreamMultiCallable

The existing unit test suite should be instrumented to test both the original multi-threaded unary-stream code path and the single-threaded version introduced in https://github.com/grpc/grpc/pull/20753.

This has already been resolved.


Viaversion + Animated Frames [Maps don't work in 1.9]

What version of ViaVersion are you using? Type /ver viaversion
0.7.9
What version of Spigot are you using? Type /ver
1.8.8
What plugins are you using? Type /plugins

Are you using any additional software like BungeeCord? If so, what software and version? (Please list your plugins as well)
No bungee, newest of all
How does this error happen? login? Using an item?
Rejoining and maps are blank for some people and for some not
Is there an error in the console? Use pastebin.com. Is there a kick message?
No error

I think its viaversion because on a test server, tested both 1.8 and 1.9 and it worked just fine

Does it work in 1.8? I have no problems with it both versions

also happens on 1.8

ViaVersion is not changing the packets for 1.8 clients. I don't think ViaVersion is causing this, please make sure you update all your plugins to the latest 1.8 version

Fixed, didnt do anything.The only thing that happen was that the vps got a restart

Great to hear that :smile:


github sync

Add a type annotation, T, to AbstractControl and ControlGroup, which is tied to the StreamController parameter for [_valueChanges] and the Stream parameter for [valueChanges].
This allows users of ControlGroup to listen on [valueChanges] and expect a certain type in their listen callback.

Merging on red.


What's the better way to update?

How can I update FoundationPress to get new functionality without break my site? What folders should I upgrade?

How do I update from say, Foundation 6.1.2 to Foundation 6.2? Typing in 'foundation update' just shows lines of bower cached and bower validate items:
bower cached        git://github.com/zurb/foundation-sites.git#6.1.2
bower validate      6.1.2 against git://github.com/zurb/foundation-sites.git#~6.1.0
bower cached        git://github.com/FortAwesome/Font-Awesome.git#4.4.0
bower validate      4.4.0 against git://github.com/FortAwesome/Font-Awesome.git#~4.4.0
bower cached        git://github.com/zurb/motion-ui.git#1.1.1
bower validate      1.1.1 against git://github.com/zurb/motion-ui.git#~1.1.0
bower cached        git://github.com/kenwheeler/slick.git#1.5.9
bower validate      1.5.9 against git://github.com/kenwheeler/slick.git#~1.5.9
bower cached        git://github.com/jquery/jquery-dist.git#2.1.4
bower validate      2.1.4 against git://github.com/jquery/jquery-dist.git#~2.1.4
bower cached        git://github.com/jquery/jquery-dist.git#2.2.1
bower validate      2.2.1 against git://github.com/jquery/jquery-dist.git#>=1.7
bower cached        git://github.com/ten1seven/what-input.git#1.1.4
bower validate      1.1.4 against git://github.com/ten1seven/what-input.git#~1.1.2
I'm running FoundationPress 2.3

Hi @ChrisAynesworth ,
We have an open pull request for the latest Foundation update. Just need to fix a few issues before it's merged into the master branch. If you plan on upgrading yourself, you should follow this upgrade guide.
Cheers,
Ole Fredrik

Thanks Ole, and for your theme!
I'll be looking for those latest changes. I guess my question was also on the scope of why running foundation udpate doesn't do anything?


Update testing.md

Description
Move ScalaTest above Junit and Specs2 repositories or else build fails with Error in fail: scalatest_classpath requires mapping of scalatest_classpath provider id on the toolchain @io_bazel_rules_scala//testing/toolchain:testing_toolchain_type
Motivation
Ran into this issue while trying to set up the scalatest toolchain.

@googlebot I signed it!

@googlebot I signed it!

Thanks for looking into this @gfl-chris. Are you only using ScalaTest in your project? I think documentation is confusing as it does not explain that the type of test framework toolchains is the same, and only the first one will be used. Would you mind clarifying it in the doc with this change. Otherwise folks who copy/paste from instruction and want to use other frameworks will run into the same issue as you had with ScalaTest.
If you want to use more than one test framework, you should define custom testing toolchain with relevant dep providers.

Thanks for looking into this @gfl-chris. Are you only using ScalaTest in your project? I think documentation is confusing as it does not explain that the type of test framework toolchains is the same, and only the first one will be used. Would you mind clarifying it in the doc with this change. Otherwise folks who copy/paste from instruction and want to use other frameworks will run into the same issue as you had with ScalaTest.
If you want to use more than one test framework, you should define custom testing toolchain with relevant dep providers.


openspace: init at 0.11.1

Hi :)
Motivation for this change
This adds a new package: OpenSpace, an open source astrovisualization project, and one of its dependencies: SOIL (Simple OpenGL Image Library).
This kind of works for me, but please note that this build is not very usable for now. This is a first attempt. Also, Linux doesn't seem to be well supported upstream, hence the various patches (I will open an issue upstream to discuss them).
This PR was successfully built against release-18.03 and nixos-unstable.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] (except for meta.maintainers) Fits CONTRIBUTING.md.

This PR was successfully built against release-18.03.

@GrahamcOfBorg build openspace

@grahamcofborg build openspace

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: openspace
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: openspace
Partial log (click to expand)
shrinking /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/usr/share/openspace/bin/Sync
shrinking /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/usr/share/openspace/bin/OpenSpace
shrinking /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/usr/share/openspace/bin/OpenSpaceTest
shrinking /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/usr/share/openspace/lib/libSpice.so
shrinking /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/usr/share/openspace/lib/libLua.so
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1/bin
patching script interpreter paths in /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1
checking for references to /build in /nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1...
/nix/store/0lb3p0flp9zdfzfpsl547ycx4njik6fb-openspace-0.11.1

Failure on aarch64-linux (full log)
Attempted: openspace
Partial log (click to expand)
In file included from /build/hdf-4.2.14/hdf/src/hdf.h:155:0,
                 from /build/hdf-4.2.14/hdf/src/dfp.c:32:
/build/hdf-4.2.14/hdf/src/hdatainfo.h:29:5: error: unknown type name 'uint16'
     uint16 tag;
     ^~~~~~
/build/hdf-4.2.14/hdf/src/hproto.h:1957:18: error: unknown type name 'int32'; did you mean 'int'?
building of '/nix/store/ylhwahgicq098qg61lf0sncgsr59f32q-hdf-4.2.14.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/x9sd7zdk62b7kc04y4j98xfcgvy4qy49-gdal-2.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bkz7k7z7p7lsiygpnqw2cgiqvqr13128-openspace-0.11.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/bkz7k7z7p7lsiygpnqw2cgiqvqr13128-openspace-0.11.1.drv' failed


[Bug] Sagemaker workspace cannot be terminated normally under Research-GPC account

Re-testing this against Research-GPC and Application-Prod to determine if its account-specific, possibly fixed by Friday's bug hunt, etc.

Both tests terminated successfully!  Closing this out, but if it happens again let's make sure to note in detail all the circumstances under this issue, and re-open it.


[Snyk] Upgrade @aws-sdk/client-sqs from 3.606.0 to 3.609.0

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to upgrade @aws-sdk/client-sqs from 3.606.0 to 3.609.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.

The recommended version was released on 23 days ago.

Release notes

Package name: @aws-sdk/client-sqs

3.609.0 - 2024-07-023.609.0(2024-07-02)
Chores

add clean-nested make target (#6250) (bc48ccea)
bump smithy versions (#6243) (3da4203c)
core:  emit warning for Node.js versions < 18.x (#6247) (3c64d786)
codegen:  bump smithyVersion=1.50.0 (#6245) (72db2b5a)

Documentation Changes

fix link to middleware stack blog post (#6234) (675cdf84)
update FetchHttpHandler link (#6244) (15066e95)

New Features

client-ec2:  Documentation updates for Elastic Compute Cloud (EC2). (c155b9e2)
client-fms:  Increases Customer API's ManagedServiceData length (b5ca0231)
client-s3:  Added response overrides to Head Object requests. (ac9f3d20)

For list of updated packages, view updated-packages.md in assets-3.609.0.zip

3.606.0 - 2024-06-283.606.0(2024-06-27)
Chores

client-sso-oidc:  move sts to peer (#6224) (1cc4de91)

Documentation Changes

client-rds:  Updates Amazon RDS documentation for TAZ export to S3. (cee790fe)
client-cloudfront:  Doc only update for CloudFront that fixes customer-reported issue (85a220c6)

New Features

clients:  update client endpoints as of 2024-06-27 (9cc63d2c)
client-datazone:  This release supports the data lineage feature of business data catalog in Amazon DataZone. (dc63d2cb)
client-qconnect:  Adds CreateContentAssociation, ListContentAssociations, GetContentAssociation, and DeleteContentAssociation APIs. (c6917b44)
client-application-auto-scaling:  Amazon WorkSpaces customers can now use Application Auto Scaling to automatically scale the number of virtual desktops in a WorkSpaces pool. (2bd900fc)
client-quicksight:  Adding support for Repeating Sections, Nested Filters (be6cd948)
client-workspaces:  Added support for WorkSpaces Pools. (729c2087)
client-mq:  This release makes the EngineVersion field optional for both broker and configuration and uses the latest available version by default. The AutoMinorVersionUpgrade field is also now optional for broker creation and defaults to 'true'. (8c6b66ae)
client-sagemaker:  Add capability for Admins to customize Studio experience for the user by showing or hiding Apps and MLTools. (c8b653f9)
client-chime-sdk-media-pipelines:  Added Amazon Transcribe multi language identification to Chime SDK call analytics. Enabling customers sending single stream audio to generate call recordings using Chime SDK call analytics (2028122c)
client-elasticache:  Add v2 smoke tests and smithy smokeTests trait for SDK testing. (d3a5651d)

For list of updated packages, view updated-packages.md in assets-3.606.0.zip

    from @aws-sdk/client-sqs GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (2206850) to head (e0df7ad).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #21   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           87        87
=========================================
  Hits            87        87

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Updating old Studio docs for Applications

Our Studio docs were out of date which often lead to confusion for users who were editing Applications via Studio. My goal for this page was to tailor it to a user who will be approaching Applications editing from the Studio perspective instead of the typical developer perspective that the Applications docs cover. Feel free to make any update or just let me know if there's stuff you'd like me to change. Thank you!

Making the executive decision that this is much better than what we have right now, so I'm going to merge it. Take a look if you to verify. Thank you!


Bump framework version

$subject

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6556866174

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6556866174
Status: success


Propagate canary_watch_time to StatefulSet

Needed for https://github.com/cloudfoundry-incubator/cf-operator/pull/692.
To do canary rollouts like Bosh does, we should support the canary_watch_time property.
We need to propagate this property from the BoshManifest to the StatefulSet, so the rollout controller can access it.
I also added a validation to the ValidatingWebhook so that we notice early if the property is misconfigured.

Will be part of https://github.com/cloudfoundry-incubator/cf-operator/pull/692


republish on Hex

Hi HashNuke!
I reproduced the problems w/ :ibrowse described in this issue
Now it's great you committed a change fixing this, but you must've messed with Hex - the 0.5.9 package published on Hex doesn't have this commit.. so again we need to use Hound via Github ref in our deps, which screws things a bit.
Please republish package on Hex and keep it in sync with your tags.
Also note that you can overwrite the same ver of the Hex package only during 1 hour after publishing, so now you'll need to make it 0.5.10 or sth.
Cheers :]
herenowcoder

Too late but done. So closing this now :)
Thanks @herenowcoder ~!


[Bug] - Config Server: Agent Mapping is not applied when no config file exists

Describe the bug
When there are no files in the working directory of the config server, the default mapping does not work for inspectIT Agents.
Expected behavior
The default mapping should be usable when no custom files are in the file system.

I tried to reproduce the bug in 3 different ways:

Way:
Deleting all the config files in the config view filetree (the ocelot default config cannot be deleted, so this was the only directory left there).
With this method I could not reproduce the bug.

Way:
Deleting all the agent mappings in the agent mapping view. This resulted the agent not having any mapping at all and throw an error.
It sounds reasonable, that when there is no agent mapping, no agent mapping can be found, so I believe that this way is the intended way how things should work.

Way:
Deleting the working_directory folder in the inspectit-ocelot folder.
The working_directory got created again after restarting the config server and the agent could find the default mapping.
Also with this method I could not reproduce the bug.


Keep getting "Verification failed while extracting<EMAIL_ADDRESS>

Category

[x] Question
[x] Bug
[ ] Enhancement

When running "npm install" I am getting following error, already tried to very and clean the cache with no luck:
npm ERR! Verification failed while extracting<EMAIL_ADDRESS>npm ERR! sha1-iImCPTaoQl6Dxjxki9BWOfq/Wwg= integrity checksum failed when using sha1: wanted sha1-iImCPTaoQl6Dxjxki9BWOfq/Wwg= but got sha512-SZARibyCQB+1j5b7g/6CrsUBA8pz9Yh1z+2RhXMlJcLyGkUmSriKgRmHnPjpjogQSGUAARTIFaYIMncfqL+8Pg== sha1-w6MYuEq9uEl8jKzi5LPU8hoPAII=. (1467748 bytes)

I too have this issue . . . tarball data for<EMAIL_ADDRESS>(sha1-iImCPTaoQl6Dxjxki9BWOfq/Wwg=) seems to be corrupted

Same here npm WARN tarball tarball data for<EMAIL_ADDRESS>(sha1-iImCPTaoQl6Dxjxki9BWOfq/Wwg=) seems to be corrupted. Trying one more time.

Same for me:
npm WARN tarball tarball data for<EMAIL_ADDRESS>(sha1-iImCPTaoQl6Dxjxki9BWOfq/Wwg=) seems to be corrupted. Trying one more time.

Start from new machine - yo @microsoft/sharepoint - Congratulations!  Solution pzl-script-editor is created.  Run gulp serve to play with it! Run Gulp Serve and get this error - Error: Cannot find module '@microsoft/sp-build-web' so run npm i @microsoft/sp-build-web - get error tarball data for<EMAIL_ADDRESS>(sha1-iImCPTaoQl6Dxjxki9BWOfq/Wwg=) seems to be corrupted

Could try this solution instead for a script editor I haven't tried to deploy it yet: https://github.com/jcoleman-pcprofessional/True-Script-Editor

Hi Mikael why does the file package-lock.json in react-script-editor refer to "https://onedrive.pkgs.visualstudio.com/_packaging/odsp-npm/npm/registry" in the dependencies section rather than https://registry.npmjs.org ?  Regards  Nigel

I had the same issue with<EMAIL_ADDRESS>I solved the issue by updating my development environment to use a higher version of the @microsoft/sp-polyfills package: nodejs version 10.17.0 (this is the working version for SharePoint Framework), Yoeman (version 3.1.0). I deleted node_modules, the package-lock.json in the solution folder, then I run npm install.
Now I'm using<EMAIL_ADDRESS>and seems to be fine.

hi Daniel Judele, can i have mail id. mine<EMAIL_ADDRESS>

Got it working: modified \package-lock.json, line 874, correct value is “sha1-w6MYuEq9uEl8jKzi5LPU8hoPAII=” for "integrity". Also needed to modify name attribute, line 4, in \config\package-solution.json because "@" made the value invalid.
Owner of this project: please fix the issues as described above!

@ZeweiS thanks a lot! This fixed the issue for me :D
How did you reach this solution?

After a long day struggling with this, @DanielJudele solution save me from a from a headache. Thank you so much for sharing.

@ZeweiS and @DanielJudele - combination of both solutions worked for me!  Thank you so much!!!

Got it working: modified \package-lock.json, line 874, correct value is “sha1-w6MYuEq9uEl8jKzi5LPU8hoPAII=” for "integrity". Also needed to modify name attribute, line 4, in \config\package-solution.json because "@" made the value invalid.
Owner of this project: please fix the issues as described above!

@ZeweiS THANK YOU!  This worked.

Hi @ZeweiS  I'll mark this issue as closed as it seems that an earlier pull request may have solved this issue.
If you find that you're still experiencing the issue, feel free to re-open it.


Gradle generates broken links in logs

Current Behavior
When running out of memory, Gradle outputs the following log message:
The Daemon will expire after the build after running out of JVM Metaspace.
The project memory settings are likely not configured or are configured to an insufficient value.
The daemon will restart for the next build, which may increase subsequent build times.
These settings can be adjusted by setting 'org.gradle.jvmargs' in 'gradle.properties'.
The currently configured max heap space is '512 MiB' and the configured max metaspace is '256 MiB'.
For more information on how to set these values, visit the user guide at https://docs.gradle.org/8.0-rc-2/userguide/build_environment.html#configuring_jvm_memory
To disable this warning, set 'org.gradle.daemon.performance.disable-logging=true'.
Daemon will be stopped at the end of the build after running out of JVM Metaspace

The provided link is not right, and should be changed to
-https://docs.gradle.org/8.0-rc-2/userguide/build_environment.html#configuring_jvm_memory
+https://docs.gradle.org/8.0-rc-2/userguide/build_environment.html#sec:configuring_jvm_memory

Steps to Reproduce
Not a real "steps to reproduce" but here is a link to a GitHub Actions job that triggers it: https://github.com/SimonMarquis/SealedObjectInstances/actions/runs/4097340460/jobs/7065637485#step:4:156
I guess we could also reduce the java allowed memory amount to something very small to trigger it every time.
Your Environment

Build scan URL: not relevant, but here it is https://scans.gradle.com/s/ylkb4lwsl6u3y
Solution
Fix broken URLs used with DocumentationRegistry.getDocumentationFor(String id, String section).

Thank you for your interest in Gradle!
The issue is in the backlog of the relevant team and is prioritized by them.

Thanks, and fyi I've prepared a corresponding PR here if that helps:

#23786


FIX-#5137: df.info failure with default columns

What do these changes do?
Fixes the failure in the linked issue, caused by attempting to index a dataframe w/ default integer columns by using a string instead. Hopefully there aren't any dataframes out there that rely on a column name being stringified before being used as an index.

[x] first commit message and PR title follow format outlined here

NOTE:  If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

[x] passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
[x] signed commit with git commit -s
[x] Resolves #5137
[x] tests added and passing
[x] module layout described at docs/development/architecture.rst is up-to-date

@noloerino could you rebase? it should fix CI


Added more descriptive disconnect messages.

This fixes #10 by adding more specific error messages based on the type of disconnect encountered.
As per the Socket documentation for socket.disconnect(), the disconnect event provides a reason value, which I have incorporated and tested.

Seems good! :)


Add development information to the documentation

This update to the docs will help future contributors to get the development environment ready to code, as I needed these steps clarified on discord.

Thanks for updating this @dan1d !  "shake it device violently until you see the React Native dev menu" - awesome feature lol
@akinwale please review at your earliest convenience.

Thanks @akinwale, I didn't noticed these two mistakes
Let me know if I solved the issue.

@dan1d friendly reminder :)

@tzarebczan  will update EOD. Finishing a PR now :+1:

Hmm, I've re-tested Hot Reloading but this time worked for me, I'm very sure that I've saw a console output that said something along the lines of "hmr is not active", I will keep an eye if I see that exception again,  It is working for me currently so I've updated the docs.
@akinwale @tzarebczan


Password Generation for Selected Criteria

GIVEN I need a new, secure password
WHEN all prompts are answered
THEN a password is generated that matches the selected criteria

Issue was addressed in previously committed branch, the password generator is now able to create a password based on the users input


[SPARK-50583][INFRA][FOLLOW-UP] Fix 3.5 daily build

What changes were proposed in this pull request?
Fix 3.5 daily build
if: (inputs.branch != 'branch-3.5') && (${{ env.PYSPARK_IMAGE_TO_TEST }} != '')

the condition returns true for branch-3.5
Why are the changes needed?
Fix 3.5 daily build
Does this PR introduce any user-facing change?
no, infra-only
How was this patch tested?
manually check
1, ${{ inputs.branch != 'master' && env.PYSPARK_IMAGE_TO_TEST != '' }}
skipped in PR build

https://github.com/zhengruifeng/spark/actions/runs/12354167258/job/34474934451
2, ${{ inputs.branch != 'branch-3.5' && env.PYSPARK_IMAGE_TO_TEST != '' }}
runned in PR build
Was this patch authored or co-authored using generative AI tooling?
no

merged to master

May I ask what was the root cause of the daily CI failure, @zhengruifeng ?
Thank you so much for fixing this. However, do you think we can hold on a little this kind test infra refactorying during 3.5.4 voting periods, @zhengruifeng ? If we cannot trust CIs, we cannot make a release. I hope this kind of irrelevant activity is not going to be a release blocker.

@dongjoon-hyun
the expression if: (inputs.branch != 'branch-3.5') && (${{ env.PYSPARK_IMAGE_TO_TEST }} != '') always return true, so the step is not skipped at branch-3.5

Oh, I meant when this bug happens, @zhengruifeng ? Does this bug introduced recently?

This bug was introduced in https://github.com/apache/spark/pull/49193 @dongjoon-hyun


1549: Fix logos in MA/NYC emails

Ticket
Resolves FFS-1549.
Changes
These logos weren't loading because there was no asset_host specified.
Let's re-use the DOMAIN_NAME env var for it.
Context for reviewers
N/A
Testing
Tested in development by copying this config into development.rb and
verifying it was used in the Rails mailer.

Yeah, interesting, it seems possibly related. I'm going to merge and we can accept this in demo.


Provide an explicit Dockerfile and modified standalone.conf.

Also chown the dirs to jboss.
This later step may not be needed if the base image already does this.

When Openshift runs the container, it doesn't take into consideration the user that is defined in the dockerfile, but it uses 'random' UID. The UID range can be set per project by setting the openshift.io/sa.scc.uid-range metadata annotation, but by default we can assume it's pretty much random.
So chowning everything to jboss user doesn't help us.
this is what the OS online course says:
In a pure Docker environment, simple Dockerfiles may generate images that fail to run in OSE 3. Most of the time, this is because the image needs to run as root or some other fixed UID. But OSE runs containers using a random UID. The fix is making sure folders written to while running the container have a+rwx permissions.

I like having the explicit Dockerfile vs. the auto-generated one.  One negative though  is that we can no longer parameterize the base image name and other info.  I submitted a PR to the docker-maven-plugin (https://github.com/fabric8io/docker-maven-plugin/pull/686) to allow variable substitution in the Dockerfile, so hopefully with a future release of the plugin we can more easily switch out the base image.

lgtm, the travis went crazy, but I was able to build it locally and use it in openshift with the openshift/origin-metrics-cassandra:v1.4.1 as C* image and it works like a charm

I think this bombs on travis as the used docker-compose.yml file has no volume defined for the data directory.
volumes:
    - /tmp/opt/hawkular/server:/opt/data

(But that is more or less a guess)

Travis is now (almost) happy after the volume has been added. There are still 2 failures where operations fail, but inside container they would not be expected to work anyway.
Merging this now.


Fix flake (again)

Bump haskell.nix to get ghc927
Temporarily disable test involving cardano-ping

looks like it still does not eval: https://ci.zw3rk.com/eval/29089#tabs-errors

ghc 9.2.7 support is not yet merge in haskell.nix: https://github.com/input-output-hk/haskell.nix/pull/1854


Subsequent messages terminate TCP stream?

Executing req_pq runs fine and I receive the data I expect, after processing it accordingly I send req_DH_params but upon waiting for the response I find the connection has closed, this also happens if I try sending an additional req_pq.
What could be causing this specifically and under what conditions does MTProto close a TCP connection? Is there some sort of acknowledgement I have to send before my data? Or am I expected to open a new connection?

You should receive an MTProto error before the connection is closed. Usually, the error means that you violated the protocol.

I don't seem to be receiving any error information, the connection literally just closes after it receives my data.

The sent data is likely to be completely wrong. You can find handshake examples in https://core.telegram.org/mtproto/samples-auth_key.

It does look like I'm encoding everything correctly and the request I'm sending is definitely the right size, here's a log of the responses and requests:
REQUEST SENT: eeeeeeee280000000000000000000000000000007037ee5e14000000f18e7ebe303d562b8c4854a7f9debb5403800023
RESPONSE RECIEVED:<PHONE_NUMBER>000000018012787037ee5e4800000063241605303d562b8c4854a7f9debb540380002344c3ab94f11a05d26497d1d72165a14a08286f4331ac0a8b0500000015c4b51c02000000029f4ba16d109296216be86c022bb4c3
REQUEST SENT: eeeeeeee540100000000000000000000000000008e37ee5e40010000bee412d7303d562b8c4854a7f9debb540380002344c3ab94f11a05d26497d1d72165a14a045c5cd5570000000470126d03000000216be86c022bb4c3fe00010005eff8b98b855778f4d6151656d6fbe0a47f4dafa407c735fbd950816f513317b56bbdf44a682b22022dba8857016bd4bfa5fe01067fcb4238896844c3d8c8d4dd1a703e804bfba8a0a327bd745b6483eb4474821e7436c4ca7b99eb5758e94e50869db39ae25f4f39eeb35c3ebf86ab06496c9d649889c38f95582bcfa90180d3c7c7ec1c2704240bb9e1bea33189ab4eb5621eac2e7d3f3471707d8d785d38cbf3c779787595ced7e63c35d788f2a2305b703b73a2391e889f6517d07450aaf43a211227dd8e7fcd2b96f6c96d3b9e98d60c639dbc1a9d1970994761a2070d4922e3bb2988d649906f75b3f2c9f2be786ddf58a3cf65c432be0d456aadcf92
END OF TCP STREAM

Is the encrypted checked to ensure it's padded with secure randomness by any chance? It's the only thing I can think of that might be the problem

Tried it, still broken

@faissaloo Random padding should be used only when connecting through dd/ee MTProto-proxies.

Does that go for this too? https://core.telegram.org/mtproto/auth_key#presenting-proof-of-work-server-authentication
It says data_with_hash := SHA1(data) + data + (any random bytes); such that the length equals 255 bytes;

No, this padding must always have specified length.

Using the auth key tutorial I've managed to verify that I'm generating the correct bytes for p_q_inner_data at least, my prime decomposition is also verified so the only thing I can think that it might be is something to do with the RSA encrypting things wrong.
Is the padding available for the auth key tutorial? Or would you be able to provide an unencrypted vs encrypted example and the fingerprint for the public key that encrypted it?

I can only point you to RSA implementation in TDLib: https://github.com/tdlib/td/blob/f45d80fe16f99d112d545b7cd74ce46342fe3437/td/mtproto/RSA.cpp.

Hmm, ok I'll take a look at that and try comparing it to my implementation, thanks. Let me know if you want the test vectors once I finish capturing a few results from it.

How do I #include the RSA implementation? #include <td/mtproto/RSA.h> doesn't seem to work

This is a private header. You need to include all TDLib's source code for that.

Seems like the RSA is working as intended

Actually here's a question, should I be creating a new connection when sending req_DH_params or is it ok to continue to use the same connection I used to send req_pq?

You must not create new connection.

Does req_pq_multi pay attention to the message id? I'm wondering if perhaps my message id implementation is broken and only the second message causes it to fail somehow?

In case of incorrect message_id you should receive corresponding error from MTProto, not connection close.
You need to choose and use public RSA key corresponding to the given fingerprint. Obviously, you need only one RSA key.

Ok so it seems like that stuff's not the problem. I went ahead and implemented a ping/pong and it seems to indicate the problem is deeper, when I send pings I don't get a response and after the second ping the stream terminates. I find it strange that I req_pq_multi gets a response but ping doesn't. I don't need to be authenticated to perform pings right?

Wait a second, do I not need to send the transport code before every message?

As I know, you need to be authenticated by MTProto to use ping.
Transport code is sent only once. Then you need to send only packet length before each packet.

Alright looks like that got it, I was sending the transport code on every request. Thanks a ton.

And the server closed the connection because too big packet length was received. Congratulations!


1.3 Subarray with given sum

Description:
Given an unsorted array of non-negative integers and a sum, find if there is a subarray with a given sum.
Input:
An array and a sum.
Output:
The indices of the subarray that adds up to the sum.
Example:
Input: [1, 4, 20, 3, 10, 5], sum = 33
Output: 2 to 4

Please assign this issue to me!

@strivedi4u  Please assign this issue to me i would love to solve it.