[WIP] add python 3.8, 3.9 support and migration to pytest

Description
fix  #3046, related to #2886, #2939
I'm trying to add python 3.8 and 3.9 support.

Motivation and Context

Have you tested this? If so, how?

@honnix @dlstadther @Tarrasch
cc @ravwojdyla
Does anybody know how to run CI with py38 environment on travis?
Timeout on tox step will always be occurred.
https://travis-ci.org/github/spotify/luigi/jobs/762401923
(I'm sorry for very very dirty and many commits. I'll squash later.)

@hirosassa 🤔 is py38 also timing out locally?

@ravwojdyla No, This is just occurred only on travis.

@hirosassa interesting. Travis has limited support for debugging builds: https://docs.travis-ci.com/user/running-build-in-debug-mode/. But I imagine we can't use that here, in the meantime we could also add -vvvv to tox commands in ./scripts/ci/conditional_tox.sh to hopefully see more output and maybe the cause?

@ravwojdyla Thank you! I'll try -vvv option.

@ravwojdyla The cause of timeout is resolving dependencies on python 3.8 and I fixed it. Thanks!
I'll struggle against some failure tests.
https://travis-ci.org/github/spotify/luigi/builds/762528137

@hirosassa thanks for the update. Oh wow, there is quite a lot of failures on py38!
FYI @lallea since you have mentioned you've been using luigi on py38 in https://github.com/spotify/luigi/issues/3046#issuecomment-781431232. There seem to be quite a number of test failures, hopefully that doesn't affect your workloads, just wanted to let you know.

@hirosassa what do you think is the right way forward?

@ravwojdyla Thanks for the heads up. Lots of failures, indeed, and on core things. Surprising, since we have not seen any trouble. Works on our machines. :-)

@ravwojdyla @lallea I fixed almost all of the failures now (most of failures comes from coverage bug on python 3.8 and fixed by update it).
https://travis-ci.org/github/spotify/luigi/builds/762532477
https://travis-ci.org/github/spotify/luigi/jobs/762532486

That's a huge relief! Really appreciate your work @hirosassa!

@ravwojdyla @honnix @dlstadther
Almost, all of the tests passed. Do you have any idea to solve following test's error?
test/scheduler_test.py::StableDoneCooldownSecsTest::test_sending_same_task_twice_without_cooldown_leads_to_double_run

=================================== FAILURES ===================================
_ StableDoneCooldownSecsTest.test_sending_same_task_twice_without_cooldown_leads_to_double_run _
self = <scheduler_test.StableDoneCooldownSecsTest testMethod=test_sending_same_task_twice_without_cooldown_leads_to_double_run>
@with_config({'scheduler': {'stable_done_cooldown_secs': '0'}})

def test_sending_same_task_twice_without_cooldown_leads_to_double_run(self):

    second_run_result = self.get_second_run_result_on_double_run()

  self.assertEqual(second_run_result.scheduling_succeeded, False)

E       AssertionError: True != False
test/scheduler_test.py:366: AssertionError
----------------------------- Captured stdout call -----------------------------
INFO: No prior state file exists at /var/lib/luigi-server/state.pickle.  That test was introduced by https://github.com/spotify/luigi/commit/b4e44336ff4550a78e09e5aa03e1c2720fb3e985 as a fix for https://github.com/spotify/luigi/issues/2644: https://github.com/spotify/luigi/blob/7508cdf8af8161adfbe2d911e71f7aab38152a48/test/scheduler_test.py#L304-L366
has a number of knobs to tweak like the time_to_check_secs, time_to_run_secs, parallel_scheduling_processes. Maybe adding a couple of log messages between the steps would make it a bit more obvious why the task if failing. Also tweaking the knobs to more extreme values just for the debugging purposes?

@hirosassa

WARNING: Failed saving scheduler state
Traceback (most recent call last):
File "/home/travis/build/spotify/luigi/luigi/scheduler.py", line 448, in dump
with open(self._state_path, 'wb') as fobj:
FileNotFoundError: [Errno 2] No such file or directory: '/var/lib/luigi-server/state.pickle'

Does this directory: /var/lib/luigi-server exist at the time of the test run?

@ravwojdyla Thank you for your suggestion. I checked existence and writability of the directory by this code, and found the following logs
INFO: state path: /var/lib/luigi-server/state.pickle, exists?: False, writable?: False
INFO: state path dir: /var/lib/luigi-server, exists?: False, writable?: False
INFO: state path root dir: /var/lib, exists?: True, writable?: False

However, there's no mkdir or preparation of the directories 🤔

@hirosassa that actually might be a red herring. So it seems like test_sending_same_task_twice_without_cooldown_leads_to_double_run is flaky on the travis CI only. Very weird. To limit this down, maybe we should try to run only a single environment instead of the test full matrix (essentially I wonder if there's some interaction there).

@ravwojdyla I found the reason test_sending_same_task_twice_without_cooldown_leads_to_double_run fails!
I removed coverage command in https://github.com/spotify/luigi/pull/3048/commits/644b445bcdb0e6d67fb8b230f31ebf0d3bb97543 , then all the core test passed.

https://travis-ci.org/github/spotify/luigi/jobs/764230493
https://travis-ci.org/github/spotify/luigi/jobs/764230497
https://travis-ci.org/github/spotify/luigi/jobs/764230503
https://travis-ci.org/github/spotify/luigi/jobs/764230507

@hirosassa great news! I wonder if this is a known issue(?) and what's the proper way forward?

@ravwojdyla finally! 🎉
https://travis-ci.org/github/spotify/luigi/builds/764698712

@Tarrasch @honnix @dlstadther cc @ravwojdyla @lallea
This PR is ready for review. Please check!

Great work @hirosassa!!

👋 @lallea do you mind taking a look (review) as well (if you have time) please. I assume you would like to have this in as well :)

@dlstadther Thank you for the review! added in f7053d9

All looks good to me, with the reservation that I know little about pytest.
Thanks @hirosassa for putting down all this work!

👋   @honnix @narape what's the best way to request review/merge from the Spotify Team?

:+1:  LGTM, @hirosassa Thanks for the contribution

Thanks for your comments and reviews! @ravwojdyla @lallea @dlstadther @narape

@hirosassa thanks for all you great work!
Btw, just noticed that it might be also worth updating the setup.py to include python 3.{8,9}. Let me know if that's something you would like to handle as well.

@ravwojdyla Oh, I missed it. I'll submit small PR to fix this.


test against local manifests

Building off of #12
This is similar functionality to what dry-run.rb has. When developing a test or working on a bug, we often modify manifest files to reproduce an issue. In order to use the CLI those manifests have to be pushed up to a repo so they can be fetched in the fetch_files step.
With this change, we can specify --local-repo . and the CLI will mount the directory in the location the updater expects it to be, so it can skip most of the fetch_files step. Thus we don't need to push up every change to the repo before running dependabot.
Unfortunately the file fetcher will only use the repo contents if job.clone? is true, and the CLI can only control the vendor_dependencies? flag on the job definition.
This seems weird, but I don't actually see that flag used anywhere else, so this might be ok?

Nice!

This seems weird, but I don't actually see that flag used anywhere else, so this might be ok?

I think it's indeed only used here, yeah. Ideally we might want to change this receive an explicit clone flag to make things less weird, but this hack should work fine I believe.

@pavera It sounds like you're saying don't rely on a flag but examine /home/dependabot/dependabot-updater/repo and let's say if a .git directory exists then set :repo_contents_path?
I think that sounds like a good idea.
I'll probably merge this first and then swing around to implement that in core unless anyone has any objections.

We can already do this with the -v flag.
Example: dependabot test -f tests/smoke-go.yaml -v "$(pwd):/home/dependabot/dependabot-updater/repo"
This skips the fetch portion of the job:
I, [2022-10-10T17:42:35.989873 #937]  INFO -- sentry: ** [Raven] Raven 3.1.2 configured not to capture errors: DSN not set
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
INFO <job_cli> Starting job processing
INFO <job_cli> Finished job processing

Yeah it's a little more typing, but maybe set an alias?


File include should use locateResource

Hi,
Our fixtures grow quite large and we usually split them up and use the include feature. It's quite annoying to use a relative path, it would be great to specify the bundle path.
Example status quo:
include:
  - "../../Bundle/DataBundle/DataFixtures/ORM/Templates/something.yml"

Example expected:
include:
  -<EMAIL_ADDRESS>
I guess we would need to go through the files and use<EMAIL_ADDRESS>to translate the paths into actual file paths.
Thoughts?

Hi @estahn,
Well I'm a bit lost at why you have to use relative paths or include statements. You can use this convention to use an environment base fixtures. If you need something more granular, you can always DataLoaders, in which case you can use the bundle path.
If it's not clear enough, maybe try to give me you're current usage: how are you loading the fixtures and how are you organising fixtures files?

@theofidry It doesn't relate to environments, rather to different bundles. Our setup for symfony is ApiBundle, DataBundle, StorefrontBundle, BackOfficeBundle, etc. In DataBundle we have our base fixtures, e.g. users, countries, etc. Now i want to be able to write fixtures in ApiBundle that include those base fixtures.
In regards to the DataLoaders i don't see the need and would rather avoid using them. Our setUp method looks like:
    public function setUp()
    {
        $this->fixtures = $this->loadFixtureFiles(array(
<EMAIL_ADDRESS>        ));
    }

Does this clarify it?

Sorry for the late answer @estahn.
The fixture loader indeed takes only care of loading fixture files, loading them, checking for duplicates, resolving paths, are not its job, they are done by the Finders and Resolvers.
But you could have your own wrapper to do this more easily for you use case.

@estahn I doubt it will change anything for you right now, but that's something that will be changed for AliceBundle v2 which will rely on alice v3.

This has been integrated to AliceBundle 2.x :)


Times should be stored as time.Time

Duration should be measured using monotonic clocks, this can be done by using standard time.Time and time.Duration instead of storing int64 unix epoch times. https://golang.org/pkg/time/#hdr-Monotonic_Clocks

I can prepare a PR if it is agreed on, but it will most likely break the backwards compatibility.

I think that would be a good improvement. Any opinion, @cgordon?

That is a great idea. I've been working on a new version of bender that uses more idiomatic Go (and less memory). I have rewritten the core loop (and have been using it for a new project), but I haven't (yet) had time to rewrite the HTTP and Thrift tutorials to use it. You can take a look here: https://github.com/cgordon/bender.
As I get time this week, I'll try to add some other new things, including a simple JSON output format for the timing events and some Python tools to generate useful statistics from that output.

@cgordon since you've been working on a new version could you consider allowing user to provide their own time measure checkpoints (optional)?
Setup before sending a request might take a long time and interfere the results. I've encountered that while doing simple UDP loadtests (I've stripped not important parts):
func UDPExecutor(_ int64, request interface{}) (interface{}, error) {
	datagram := request.(*Datagram)

	// This part can take quite long and we'd like to ignore it in time measures
	conn, err := net.Dial("udp", addr)
	if err != nil {
		return nil, err
	}
	defer conn.Close()

	// Start measure here
	conn.SetWriteDeadline(time.Now().Add(timeout))
	_, err = conn.Write(datagram.Data)
	if err != nil {
		return nil, err
	}

	buffer := make([]byte, bufferSize)
	conn.SetReadDeadline(time.Now().Add(timeout))
	n, err := conn.Read(buffer)
	if err != nil {
		return nil, err
	}

	return buffer[:n], nil
}

My "temporary fix" was to calculate it manually and return the results as a struct
// Response represents a udp response received
type Response struct {
	Start   time.Time
	End     time.Time
	Elapsed time.Duration
	Data    []byte
}

But it also means that histogram and other recorders need to be adjusted for this new format. It would be really good to have a generic solution to this.

@earlgreyz That's an interesting idea. I've been having the request generator do all the initialization for our load testing, and passing everything into the executor, but I can see how you may want to avoid that here. It looks like the easiest option to make this work would be to redefine the RequestExecutor to return four values: the response, the start time, the end time and an error. Then, rather than the main loop tracking the start and end time, the request executor would need to do so. In that case, it would also be easy to write a little wrapper function that did the timing (for people who don't need that fine control). Does that sound like it would do what you want?

@cgordon yes, that seems like a good solution


stats: disable global stats in config

These are already being filtered out of our stats inclusion list, so this isn't a user-facing change, but this is needed to support the singleton removal work in https://github.com/envoyproxy/envoy-mobile/pull/2129.
Splitting this out into its own PR to reduce the scope of the singleton removal change.
Risk Level: Low
Testing: None
Docs Changes: N/A, not a user-facing change
Release Notes: N/A, not a user-facing change

haha I meant in the code, but worst case folks can blame and look a the PR :-P

Added some more inline in the code here https://github.com/envoyproxy/envoy-mobile/pull/2371


8.18.1 RN

Please add the same RN that was added to 8.12.6:
* We updated the [SAP HANA](/refguide8/saphana) driver to 2.7.9.
* We now allow JDBC URL options to set data source properties for SAP HANA.
* We disabled the `transactionalLobs` option in SAP HANA.

Please add the same RN that was added to 8.12.6:
* We updated the [SAP HANA](/refguide8/saphana) driver to 2.7.9.
* We now allow JDBC URL options to set data source properties for SAP HANA.
* We disabled the `transactionalLobs` option in SAP HANA.


[SMALLFIX]Move site properties constant to constants.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16286/
Test PASSed.


Merge Tilemaps into Master Branch

Summary
With the tilemaps plugin slowly nearing its conclusion, a merge into the master branch is imminent. As a prerequisite, all content-side development issues of the Tilemaps Plugin v1.0 milestone need to be successfully dealt with. Optional post-release additions to the tilemaps plugin have already been moved out of this milestone.
Analysis

After merging into master but before release, there should be a testing session with the community to iron out all the rough edges.
The overall API should be considered stable.
Documentation should have reached a sufficient state.
The process of setting up a tilemaps environment from scratch should be as user-friendly as possible.

Done.


Definition Lists kills footnotes

Definition Lists is unstable as they quick mess up footnotes
Here Footnotes work
Term 1
Term 2
:   Definition a

Term 3
:   Definition b

Welcome to the demo of Parsedown Extra [^1]:

1. Write Markdown text on the left
2. Hit the __Parse__ button or `⌘ + Enter`
3. See the result to on the right

This is an interactive demo of

[^1]: [Parsedown Extra](https://github.com/erusev/parsedown-extra) is an extension of [Parsedown](/) that adds support for [Markdown Extra](https://michelf.ca/projects/php-markdown/extra/).

And here it dosn't
Apple
:   Pomaceous fruit of plants of the genus Malus in
    the family Rosaceae.

Orange
:   The fruit of an evergreen tree of the genus Citrus.

Apple
:   Pomaceous fruit of plants of the genus Malus in
the family Rosaceae.

Orange
:   The fruit of an evergreen tree of the genus Citrus.

Apple
:   Pomaceous fruit of plants of the genus Malus in
    the family Rosaceae.
:   An American computer company.

Orange
:   The fruit of an evergreen tree of the genus Citrus.

Term 1
Term 2
:   Definition a

Term 3
:   Definition b

Term 1

:   This is a definition with two paragraphs. Lorem ipsum
    dolor sit amet, consectetuer adipiscing elit. Aliquam
    hendrerit mi posuere lectus.

    Vestibulum enim wisi, viverra nec, fringilla in, laoreet
    vitae, risus.

:   Second definition for term 1, also wrapped in a paragraph
    because of the blank line preceding it.

Term 2

:   This definition has a code block, a blockquote and a list.

        code block.

    > block quote
    > on two lines.

    1.  first list item
    2.  second list item

Welcome to the demo of Parsedown Extra [^1]:

1. Write Markdown text on the left
2. Hit the __Parse__ button or `⌘ + Enter`
3. See the result to on the right

This is an interactive demo of

[^1]: [Parsedown Extra](https://github.com/erusev/parsedown-extra) is an extension of [Parsedown](/) that adds support for [Markdown Extra](https://michelf.ca/projects/php-markdown/extra/).

Summary:

Nesting block level elements will break footnotes and abbreviations
Nesting inline elements is ok
Nesting single line breaks is ok
Nesting full empty lines will trigger malfunction on footnotes and abbreviations
Description list itself will render correctly, only footnotes and abbreviations are affected
This behavior is replicable on Parsedown website https://parsedown.org/extra/


Add a command for generating cloud-init user-data with a JWT

$ ./brkt generate-user-data -h
usage: brkt generate-user-data [-h] --jwt JWT [-v]

Generate cloud-init user-data that is passed to the AWS RunInstances
API.

optional arguments:
-h, --help     show this help message and exit
--jwt JWT      JSON Web Token that the encrypted instance will use to
                 authenticate with the Bracket service. Use the generate-jwt
                 subcommand to generate a JWT.
-v, --verbose  Print status information to the console

LGTM

Could you and I chat a bit about how to migrate the functionality from brkt_make_userdata to brkt-cli?  I'm not trying to migrate it all right now, but it would be good to know roughly how we'll do it so that it doesn't require changing args and such to this new generate-user-data command.

Sure thing. Let's talk tomorrow.

Will open a new PR to address the issues that Adam brought up.


Update CNAME

right now the github site is redirecting to grin-tech.org apparently, but if it were not it then mimblewimble.github.io would resolve correctly and I, or anyone else, could forward their domain to that address. I'm not sure that just changing this file will do it but I don't see what else it's doing.

It’s actually a setting in the repo - should I change to grin.mw?

It’s actually a setting in the repo - should I change to grin.mw?

you can try it I'm not sure how it works, looking up now what I have to change on my side to make it correspond

@0xb100d I’ve just changed the config in github settings to point to grin.mw which should have updated the CNAME as well.
On your end, could you create an A record for
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

Detailed instructions:
https://help.github.com/en/articles/managing-a-custom-domain-for-your-github-pages-site

Looks like it works now! But not defaulting to https, despite me having set that in the settings... will investigate.

@lehnberg not seeming to work for me... will check https on my side as well

i'm on the gitter

https is now the default when I access grin.mw - and the redirect is in place!
Thanks for helping setting this up @0xb100d, and for offering up the domain.
This PR can probably be safely closed now.

Closing, no longer valid


[2171] Render different carry over content between cycles

Context
Content changes between cycles.
Changes proposed in this pull request

Candidates see different candidate when they are carrying over between cycles because their application statuses might have changed unexpectedly and while they can update their details, they can't actually apply yet.

https://github.com/user-attachments/assets/d3fffc04-a48f-42b4-b6dd-08521bcf8bad

Updated content when viewing viewing the 'Your applications' tab between cycles.

https://github.com/user-attachments/assets/043042d9-6097-4f44-b923-0804c3d95923
Guidance to review
Move forward in the recruitment cycle with applications in different states and see what happens.
Things to check

[x] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[x] This code does not rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[x] API release notes have been updated if necessary
[x] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[x] Required environment variables have been updated added to the Azure KeyVault
[x] Inform data insights team due to database changes
[x] Make sure all information from the Trello card is in here
[x] Rebased main
[x] Cleaned commit history
[x] Tested by running locally
[x] Add PR link to Trello card

 Review the candidate scenarios in Apply that require content changes


Symfony5 support

Bumped the dependencies and made changes for Symfony 4.4 and Symfony 5.  Not sure if this will still work with Symfony 3 through.

Coverage decreased (-2.9%) to 76.279% when pulling 59fb9b964412c86342cfc05684a0dd53b108a844 on survos:symfony5 into 62566649e6b0205b557bc6a17ffbb11168c39bc2 on bordeux:master.

Thank you for support


Implement anyhow or thiserror through the core and server crates

Need more robust error handling to be implemented, through either mechanism. Anyhow would be easier, and we aren't a library so don't need strict error types.

Closing as it is now just general code qual improvements


Memory Game Flip the Card

Is your feature request related to a problem? Please describe.
Hii I'm a GSSoc22 contributor.
In this Project There are certain objects and are hidden you have to flip the card and match the object all the objects are in the pair. you have to find them all.
Describe the solution you'd like.

Describe alternatives you've considered.
Features of the project

Selected card will turn and will reveal the Object behind it.
Card will automatically flip out if the object underneath doesn't match the other object you clicked.

Add any other context or screenshots about the feature request here.
No response

Assign me


VLAN Issue

Hello,
I'm trying to configure bungee/waterfall to send players via a VLAN IP, and it works for a local IP.
However, it seems to not support a external VLAN IPs as it's not sending players to the specified backend. However, can ping the port just fine via telnet, and various other methods.
Is this a known issue or am I just missing something blatantly obvious.

No errors oddly enough, just responds with the usual could not find the server, but that's obviously not the case as I can receive server information regarding the specified server from bungee/waterfall.
Waterfall's eth0
ifconfig eth0 eth0      Link encap:Ethernet  HWaddr 00:25:90:E3:3D:64           inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>           inet6 addr: fe80::225:90ff:fee3:3d64/64 Scope:Link           UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1           RX packets:16207 errors:0 dropped:0 overruns:0 frame:0           TX packets:26966 errors:0 dropped:0 overruns:0 carrier:0           collisions:0 txqueuelen:1000           RX bytes:1555487 (1.4 MiB)  TX bytes:2168420 (2.0 MiB)           Memory:f7180000-f71fffff
The external server (connecting to)'s eth0
ifconfig eth0 eth0      Link encap:Ethernet  HWaddr 00:25:90:E5:0D:66           inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>           inet6 addr: fe80::225:90ff:fee5:d66/64 Scope:Link           UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1           RX packets:5014 errors:0 dropped:0 overruns:0 frame:0           TX packets:4948 errors:0 dropped:0 overruns:0 carrier:0           collisions:0 txqueuelen:1000           RX bytes:483472 (472.1 KiB)  TX bytes:476288 (465.1 KiB)           Memory:f7180000-f71fffff

I implemented it based on what information the datacenter provided, and all seems to work as I can use our own packet system. However, bungee is the only point of issue whilst everything else recognizes the configuration just fine.

Sure thing, I'll be there shortly.

Resolved, netty was conflicting with an invalid routing situation.
Thanks @fuzzybot for the advice.


Form Wave Project

Project title
Form Wave Project
Project Description
A form that loads like wave.
Stack:
And in order to tick the check box just but x inside them for example - [x] like this. Please delete options that are not relevant.

[x] Html
[x] CSS
[x] JavaScript
[ ] ReactJS

/assign


MSDKUI-1914: [Android] Improve guidance components layouts

Fixed GuidanceEstimatedArrivalView - all empty states - missing double dashes
Fixed GuidanceStreetLabelView - general corner handling
Signed-off-by: Vijay Yadav<EMAIL_ADDRESS>

Codecov Report

Merging #115 into master will increase coverage by 1.6%.
The diff coverage is 87.5%.

@@             Coverage Diff             @@
##             master     #115     +/-   ##
===========================================
+ Coverage     73.11%   74.72%   +1.6%
+ Complexity     1643      998    -645
===========================================
  Files           129       69     -60
  Lines          5672     3952   -1720
  Branches        874      440    -434
===========================================
- Hits           4147     2953   -1194
+ Misses          855      749    -106
+ Partials        670      250    -420

Impacted Files
Coverage Δ
Complexity Δ

.../here/msdkui/guidance/GuidanceStreetLabelView.java
84.37% <87.5%> (-0.63%)
11 <1> (+1)

...e/msdkuiapp/routing/RoutingInstructionsFragment.kt

...java/com/here/msdkuiapp/common/PermissionsUtils.kt

.../com/here/msdkuiapp/routing/OptionPanelFragment.kt

...ere/msdkuiapp/routing/RouteManeuverListFragment.kt

.../here/msdkuiapp/routing/SubOptionPanelPresenter.kt

...m/here/msdkuiapp/routing/SubOptionPanelFragment.kt

...msdkuiapp/guidance/GuidanceNextManeuverFragment.kt

...com/here/msdkuiapp/routing/OptionPanelPresenter.kt

...m/here/msdkuiapp/position/AppPositioningManager.kt

... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe05363...ef760dd. Read the comment docs.


Disable calculated read/write capacity alarms for on demand tables

The alarms currently fire on any usage of the table because the provisioned capacity can be zero.

If we wanted to do this would have to make it work across new and old implementations. The latter is harder because alarms are not currently deleted, so you might want to update to a very high threshold instead as a simple fix.

@tomhaigh I think this mitigates this issue: https://github.com/justeat/AwsWatchman/pull/26


with handling seems to be broken in 0.11.0

Versions

Elixir: 1.15.7
Styler: 0.11.0

Example Input
defmodule Foo do
  @moduledoc false
  def run(arg) do
    with value <- arg do
      value
    end
  end
end

Stacktrace / Current Behaviour
foo$ mix format
** (Styler.StyleError) Error running style Blocks on lib/foo.ex
   Please consider opening an issue at: https://github.com/adobe/elixir-styler/issues/new
** (RuntimeError) unexpected `with` parent ast: {{:__block__, [line: 3], [:do]}, {:with, [do: [line: 4], end: [line: 6], line: 4], [{:<-, [line: 4], [{:value, [line: 4], nil}, {:arg, [line: 4], nil}]}, [{{:__block__, [line: 4], [:do]}, {:value, [line: 5], nil}}]]}}

    (styler 0.11.0) lib/style/blocks.ex:220: Styler.Style.Blocks.replace_with_statement/2
    (styler 0.11.0) lib/style/blocks.ex:79: Styler.Style.Blocks.run/2
    (styler 0.11.0) lib/zipper.ex:367: Styler.Zipper.do_traverse_while/3
    (styler 0.11.0) lib/styler.ex:37: anonymous fn/4 in Styler.style/3
    (elixir 1.15.7) lib/enum.ex:2510: Enum."-reduce/3-lists^foldl/2-0-"/3
    (styler 0.11.0) lib/styler.ex:35: Styler.style/3
    (styler 0.11.0) lib/styler.ex:65: Styler.format/3
    (elixir 1.15.7) lib/enum.ex:2510: Enum."-reduce/3-lists^foldl/2-0-"/3

Skipping style and continuing on

kerry nooo! just when i thought i'd thought of it all. thanks for the minimal repro, will have it fixed in a jiffy.

(just to be clear, this is only blowing up when we're trying to delete a with statement that has no pattern matching and so could've been written as just plain code, which is also the sole child of a function -- i didn't break all with handling 😂 )

(just to be clear, this is only blowing up when we're trying to delete a with statement that has no pattern matching and so could've been written as just plain code, which is also the sole child of a function -- i didn't break all with handling 😂 )

Sadly it turns out that antipattern cropped up several times in my code 🙄

my heart goes out to you.
i've got the fix for the "unexpected ast" kaboomy,  just seeing if i can easily get it to replace your exact snippet with just value rather than value = arg\nvalue

@kerryb any chance you'd be interested in running main against your codebase to see if there's anything else i should get in before releasing 11.1 on hex?

Just tried it, and my withs have been tidied up with no issues :-)
Thanks for the quick fix!

cheers, 0.11.1 is on hex. hope you like your codebase just that little bit more now :)


Extend lambda lifting to the branches of switch

This extends lambda_lift to perform the following transform:
def f(x, y, z):
    def true_branch():
        return y

    def false_branch():
        return z

    return switch(x < 0, true_branch, false_branch)()

# ==>

def f(x, y, z):
    def true_branch(_y, _z):    # <- Add free variables of both branches
        return _y

    def false_branch(_y, _z):   # <- Add free variables of both branches
        return _z

    return switch(x < 0, true_branch, false_branch)(y, z)   # <- Add args

This transform is able to remove free variables in a lot more situations than before.

I have also extended removing unused parameters to branches of switch.
The GraphInterfaceRewriter class implements a generic framework for lambda lifting, removing unused parameters and generally any optimization that modifies the external interface of a graph (number of parameters, type of output, and so on).


image.asset->url returns null

When in preview mode image.asset->url returns null
image.asset works fine, and returns the correct object with _ref and _type, but when appending ->url it returns null
Works fine when not in preview mode

This isn't enough information to help us help you. I'm closing this issue for now but feel free to re-open if you can provide us with a link to a codesandbox or a github repo where we can reproduce the problem :)


code formatting

Formatted code (using Black)
exact same code but much easier to read and maintain.

Thank you very much.


Delay formatter setup until reporter needs to notify something

By delaying formatter setup until the reporter needs to tell someone something we allow people to access reporter public apis without triggering doubling up on formatters.
Fixes #2224

@JonRowe what do you want to do with this? Seems legit?

(I'm happy to take it over and rebase etc...)

@xaviershay this should be ready for re-review

I corrected the typo and added some comments explaining the formatter counts for future reference.


MXNet hangs when creating an NDArray on a GPU Context in Scala

Description
MXNet hangs when I create an NDArray on a GPU context while using Scala bindings, every time the computer is restarted. But gets fixed as soon as I initialise an NDArray on GPU using python bindings.
Do the python bindings do anything more (in terms of cuda initialisation etc.) compared to Scala bindings when we create an NDArray on gpu?
This issue seems very strange, and happens to quite a few people I came across.
We are using MXNet 1.3.1 installed from source.
Environment info (Required)
----------Python Info----------
Version      : 3.7.1
Compiler     : GCC 7.3.0
Build        : ('default', 'Dec 14 2018 19:28:38')
Arch         : ('64bit', '')
------------Pip Info-----------
Version      : 18.1
Directory    : /home/satya/anaconda3/lib/python3.7/site-packages/pip
----------MXNet Info-----------
Version      : 1.3.1
Directory    : /home/satya/Documents/workspace/mxnet_1.3.x/python/mxnet
Hashtag not found. Not installed from pre-built package.
----------System Info----------
Platform     : Linux-4.4.0-142-generic-x86_64-with-debian-stretch-sid
system       : Linux
node         : DS5
release      : 4.4.0-142-generic
version      : #168-Ubuntu SMP Wed Jan 16 21:00:45 UTC 2019
----------Hardware Info----------
machine      : x86_64
processor    : x86_64
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                40
On-line CPU(s) list:   0-39
Thread(s) per core:    2
Core(s) per socket:    10
Socket(s):             2
NUMA node(s):          2
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 85
Model name:            Intel(R) Xeon(R) Silver 4114 CPU @ 2.20GHz
Stepping:              4
CPU MHz:               1201.406
CPU max MHz:           3000.0000
CPU min MHz:           800.0000
BogoMIPS:              4391.30
Virtualization:        VT-x
L1d cache:             32K
L1i cache:             32K
L2 cache:              1024K
L3 cache:              14080K
NUMA node0 CPU(s):     0-9,20-29
NUMA node1 CPU(s):     10-19,30-39
Flags:                 fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch epb invpcid_single intel_pt ssbd ibrs ibpb stibp kaiser tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm mpx avx512f rdseed adx smap clflushopt clwb avx512cd xsaveopt xsavec xgetbv1 cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts hwp hwp_act_window hwp_epp hwp_pkg_req pku flush_l1d
----------Network Test----------
Setting timeout: 10
Timing for MXNet: https://github.com/apache/incubator-mxnet, DNS: 0.0026 sec, LOAD: 0.5413 sec.
Timing for Gluon Tutorial(en): http://gluon.mxnet.io, DNS: 0.0016 sec, LOAD: 0.3943 sec.
Timing for Gluon Tutorial(cn): https://zh.gluon.ai, DNS: 0.0019 sec, LOAD: 0.3664 sec.
Timing for FashionMNIST: https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/gluon/dataset/fashion-mnist/train-labels-idx1-ubyte.gz, DNS: 0.0014 sec, LOAD: 0.5715 sec.
Timing for PYPI: https://pypi.python.org/pypi/pip, DNS: 0.0048 sec, LOAD: 0.1934 sec.
Timing for Conda: https://repo.continuum.io/pkgs/free/, DNS: 0.0013 sec, LOAD: 0.0341 sec.

Package used (Python/R/Scala/Julia): Scala and Python
For Scala user, please provide:

Java version: 1.8.0_201
Maven version: 3.6.0
Scala runtime if applicable: 2.11.6

Build info (Required if built from source)
Compiler (gcc/clang/mingw/visual studio):
MXNet commit hash: 96b4b6ef3c60c63644a7c4d672109b97561b839d
Build MXNet from source command:
make -j32 USE_BLAS=mkl USE_CUDA=1 USE_CUDA_PATH=/usr/local/cuda USE_CUDNN=1 USE_OPENCV=1
Build Scala bindings command:
make USE_BLAS=mkl USE_CUDA=1 USE_CUDA_PATH=/usr/local/cuda USE_CUDNN=1 USE_OPENCV=1 scalainstall
Minimum reproducible example
val ctx = Context.gpu(0)
val arr = NDArray.zeros(ctx = ctx, shape = Shape(2,2))
// hangs ...

I go try something similiar in python
import mxnet as mx
arr = mx.ndarray.array([1., 2., 3.], ctx = mx.gpu(0))

above python code works fine.
I go back and try the same in Scala and it starts working. Seems very strange. Any help is appreciated.

@mxnet-label-bot add [Scala, Bug]

@andrewfayres , please take a look.

@andrewfayres I found that even creating a GPU Tensor in pytorch first and then trying MXNet-Scala works fine after a system restart, but not the other way round. Does this seem like some cuda resource that is needed gets cached after using it via python and then gets available??

That's what I'm leaning towards. I'm going to try and reproduce it in a few different places to see if I can narrow down the cause.

I tried on two different machines (my personal laptop and an AWS EC2 instance) and haven't been able to reproduce this behavior. Can you please provide the following information:
CUDA version:
CUDNN version:
OS (looks like ubuntu but which release):
GPU Model:
Also, when you say that it hangs does that mean completely or does it eventually resume? I'm not sure what could be causing this issue. Both Python and Scala should be calling are calling the same MXNDArrayCreateEx method to create the NDArray. All the context stuff is being handled by the engine. If I could reproduce this I think I can figure out where it's hanging and determine why but currently I'm stuck.

There's an initialization delay of a few seconds. Maybe this is being mistaken as hanging?

@andrewfayres I am unable to reproduce this in docker and don't have more time to look into this at the moment. I will reopen this issue if I find anything in the future. Thanks for your time!


bugfix: Throw RpcException when NacosException occurred

What is the purpose of the change
see #8381 #8225
Brief changelog

Make the exception more explicit
Threw RepException instead of logging

Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[x] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #8382 (8d723d9) into 3.0 (6c8046a) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                3.0    #8382      +/-   ##
============================================
- Coverage     63.23%   63.00%   -0.23%
+ Complexity      311      310       -1
============================================
  Files          1099     1099
  Lines         46054    46009      -45
  Branches       6955     6921      -34
============================================
- Hits          29122    28990     -132
- Misses        13680    13755      +75
- Partials       3252     3264      +12

Impacted Files
Coverage Δ

...org/apache/dubbo/registry/nacos/NacosRegistry.java
0.00% <0.00%> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
62.06% <0.00%> (-20.69%)
:arrow_down:

...rg/apache/dubbo/remoting/utils/PayloadDropper.java
76.92% <0.00%> (-15.39%)
:arrow_down:

...ng/transport/dispatcher/WrappedChannelHandler.java
43.47% <0.00%> (-15.22%)
:arrow_down:

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
:arrow_down:

.../remoting/transport/netty4/NettyServerHandler.java
61.36% <0.00%> (-9.10%)
:arrow_down:

.../dubbo/remoting/transport/netty4/NettyChannel.java
58.41% <0.00%> (-7.93%)
:arrow_down:

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
:arrow_down:

.../remoting/transport/netty4/NettyClientHandler.java
61.01% <0.00%> (-6.78%)
:arrow_down:

...dubbo/remoting/exchange/support/DefaultFuture.java
87.27% <0.00%> (-6.59%)
:arrow_down:

... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8046a...8d723d9. Read the comment docs.


How can I reduce the db file size?

Add a large file and then file delete (using FileStorage.Delete(fileID))
But, does not decrease the size of the database file.
I want to reduce the file size. is there any options?

Hi @bbolgumer, take a look on issue #18

Hi @bbolgumer, just to know, current master branch version support shrinks now!


Proposal: Remove the "POST" on saved txs

Saved txs have the word "POST" next to them, that looks like a bug, maybe a carry over from a HTTP API.

We should remove the POST


[BUG] Remove tags from multiple hypervisor resources but tags on some resources not cleaned

Library name and version
id='Azure.ResourceManager',version='1.9.0',
Describe the bug
I am observing that the tags on specific resources in hypervisor will not be removed as proper if you try to delete those tags from those resources with multiple times call.
Created multiple virtual machines with network interface, os disk, virtual machine etc resources. (3 or more virtual machines need to be introduced).
Try to remove tags from disk one by one (as part of loop, you can delete tags with same way in loop from virtual machine, network interfaces etc) with no specific time interval setup in this clean tags loop.
 try  {      var tags= client.GetGenericResource(identifierinstance).GetTagResource();      var pr= new TagResourcePatch()      {          PatchMode = TagPatchMode.Delete,      };      //setup tags key value to pr (TagResourcePatch())      return (await tags.UpdateAsync(WaitUntil.Completed, patchReq).ConfigureAwait(false)).Value.Data;  }  catch (Exception e)  {      ////  }
Maybe you will find an exception due to issue https://github.com/Azure/azure-sdk-for-net/issues/41063 or not find any exception with everything running as proper. Them you go to hypervisor side, found tags not remove to specific one of mulitple disks. Other resources like network interface, virtual machine, other disk etc tags have been cleaned successfully.
Go to hypervisor, resource group, actitivy log, to that disk, looks like no alarm or error from hypervisor side log,

Expected behavior
All identicated tags will be removed from those resources.
Actual behavior
tags on specific os disk will not be cleaned as proper.
Reproduction Steps
Please refer to description in "Describe the bug" you will find de steps to reproduce it.
Environment
windows
.NET SDK:
Version:           8.0.100

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Thank you @weizhang1233 for reaching us, @HarveyLink  will follow up your question.

Hi @weizhang1233 , We can't repro your issue with following code:
async Task<TagResourceData> UpdateTagResourceAsync(ArmClient client, ResourceIdentifier id)
{
    var tags = client.GetGenericResource(id).GetTagResource();
    var patchReq = new TagResourcePatch()
    {
        PatchMode = TagPatchMode.Replace,
        TagValues =
        {
            {"key1", "value1"},
            {"key2", "value2"},
        }
    };
    return (await tags.UpdateAsync(WaitUntil.Completed, patchReq)).Value.Data;
}

Please make sure there is no other tags in the disk resource, the remove operation could only apply on the matched key/value.
If possible, please capture and attach the request/response payload, it could help us to identify the issue.

@jsquire Any updating? Thanks

@weizhang1233 : I have no insight into the current state.  As mentioned earlier, @HarveyLink is the engineer assigned to assist.  Any updates will come from them.

n 3 sets of resources( with VM, vnet, ipaddress, networkinterface, nsg, disk). The tags could be set and removed as we want.

I did some research today, do found some instersting behavior.
While operate the tag value of Disk, it seems we need to add delay(Thread.Sleep()) between update and remove methods to make both operations work. Otherwise, it won't do the update and leave the remove not working.
The delay should be more than 7 seconds, this is the least time I found so far.
In conclusion, based on the above results, I believe this should be a service issue.

@HarveyLink Saw you ad needs-author-feedback label. What's the the information you need?
What I am doing is introduce a TagResourcePatch with patch mode as TagPatchMode.Delete, then add some tags to  TagResourcePatch.TagValues, which will be deleted from hypervisor resource. Run updateAsync to to execute removing.
What do you mean add delay between update and remove methods?  I tried to delete tags on one resource successfully. But if you try to delete tags from multiple virtual machines (Include resources disk, nic etc to each individule), tags on some specific resource not moved as proper.

"I did some research today, do found some interesting behavior.
While operate the tag value of Disk, it seems we need to add delay(Thread.Sleep()) between update and remove methods to make both operations work. Otherwise, it won't do the update and leave the remove not working.
The delay should be more than 7 seconds, this is the least time I found so far.
In conclusion, based on the above results, I believe this should be a service issue."


Generated code subtypes must consider case-sensitivity when modeling value set as an enumeration

We currently assume that all value sets generated into code subtypes are sourced from code systems that are case sensitive. We need to check this in the code generator and may need generate equalsIgnoreCase logic in some cases.

Wrote a small program to look at the generated classes, pull off the @System annotation and then look up the CodeSystem resource in FHIRRegistry. The output is attached.
codeSystemCaseSensitive.txt

None of the code systems used when generating Code subtypes are case insensitive. Only one code system did not have a corresponding CodeSystem resource in the registry: http://unitsofmeasure.org


Fix NPM static analysis

It looks like packages may have been locked on the last run. This copies the config into the home directory to ensure the project config is maintained before adding the new token.

Deploy preview for hopeful-hamilton-4090b9 ready!
Built with commit 1aed8401d2c9552e809fa1cfbf1c15bf1309fbb6
https://deploy-preview-749--hopeful-hamilton-4090b9.netlify.com


GridStack javascript component and wrong element moving

In my AngularJS application I'm using GridStack component with a single column layout.
Right now I have an issue with a programmatic component moving.
For example I have a list of 5 elements:
e1
e2
e3
e4
e5

According to my application logic I have to move e1 to 3(third) place by Y axis. In order to do this I use GridStack.move method:
move(e1, 0, 3)

So far everything works fine. In order to move the same element to the position #4 I call:
move(e1, 0, 4)

So far everything works fine too.
But when I try to move this element back to position #2 with a following code:
move(e1, 0, 2)

it is moves to position #3 instead that is wrong.
Please use a following demo in order to reproduce this behavior:
http://decisionwanted.com/#/decisions/61209/comparison-of-antivirus-software-for-windows
Use input for entering a position number, for example 1, 2, 3, 4 etc in order to move the first element(Zemana Antiloger and Antimalware)
How to correctly move element back to a lower position than current ?

Hey @Artgit ! Looks like I need a username and password for this site?
Programmatically moving widgets shouldn't be any problem. I can take a quick look at this when you provide user/pass, but it's possible that this may have to be resolved in the angular-gridstack repo.

Closing due to inactivity. Please reopen with more information if necessary.


Add English window sentences

Add English window sentences, following the same pattern as currently defined for other binary sensors.

Thank you, @vivobg, but that will not work, unfortunately. There's a conflict with the cover domain (device_class: window), same as for doors. You have to have the same sentences for both and there's no differentiator.
The proper solution (work in progress, but slow work) is to have a means of picking targets from multiple (domain, device_class) combinations - in this case, (cover, window) and (binary_sensor, window) so that you can ask how many windows are open and it can reply counting devices from both domains. I can assure you the sentences will be updated accordingly after that particular update.

Ah, I wasn't aware of this. Makes sense. @tetele Is there anything I can help with on the proper solution?

Not unless you want to implement everything yourself, in core, intents and hassil.


Event description

Create a description based on https://docs.google.com/document/d/1QS2J0VUgpInXVMlwc39JspuqJs3XcplY8QZRLJiq31A/edit# and add it to the landing page for the event

This is located in https://github.com/pycon-mentored-sprints/write_ups/blob/master/description.md

This is now published at https://us.pycon.org/2019/hatchery/mentoredsprints/


Update version to 2.1.1

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Update version to 2.1.1
Why
Prepare release of 2.1.1
Known limitations
N/A

Reference Server Preview is available here:https://anchor-ref-pr962.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr962.previews.kube001.services.stellar-ops.com/


Can't unpublish kata translation

The kata author for this one and me had some issue while trying to approve the translation (you can read it in more detail in the relevant discussion).
I have tried to unpublish it, but the button doesn't seem to do a thing.
I also tried creating a new translation, but it refuses to make me create another Python version: that is surely wanted, but isn't it a bit dangerous? Suppose user X goes around publishing poor and/or not working of everything with language Y, de facto preventing other users to translate a kata in Y again, and you get a nasty picture.
Wouldn't it be better to have a warning if you try to translate a given kata in a language that has already a pending (of course, not an approved) translation?
Finally, I would like a way to permanently delete my translation drafts (I created one of the same kata in Coffeescript while trying stuff around this issue and it has no meaning to me, of course).
Thanks again for your kind attention :)

I just ran into an issue with publish not doing anything, it was an expired token issue which I was able to workaround by clearing my cookies and re-logging in. Its not clear to me that this is the same issue as yours.
We don't allow multiple root level translations for the same language, because then there would be all kinds of conflicts. Additional translations can be added by forking an existing translation of the same language.
if you are unable to create a new python translation because the old one is not shown (possibly rejected) then that would definitely be an issue.

Hi Jake and thanks,
we ultimately succeeded indeed by forking the kata. I get your point on not allowing more translation, though forking an existing translation I think I may feel a bit like a thief, but I think I'll deal with it if such a situation ever arises.
All clear for now on this front \m/


Add support for altering BigQuery column types

resolves #2546
Description
Implements functionality to alter BigQuery column types using dbt.
Checklist

[x] I have signed the CLA
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

I just want to clarify my understanding of the implications: dbt only uses the alter_column_type method within the expand_column_types method, which is a noop on BigQuery. Out of curiosity, do you have a specific use case for this?
In any case, I agree with your rationale (in #2546) that:

the default implementation doesn't work on BQ, so anything (even a compilation error) is better than the status quo
without BQ having a great way of implementing this, best to implement it in a SQL-first way

I'm a little uneasy that it requires replacing the entire table, but I guess that's the best of what they recommend. I'm still hopeful for support someday of alter table ... remove column (adding new type + removing old type is how we do this on other databases), or alter table ... alter column set data type ... (though this frequently has limitations when implemented).

Hey @jtcohen6, the reason I'm implementing this is because my team is planning to use dbt to handle some of our schema management and we have probably 90% of what we need already with the macros that currently exist. So considering there was an alter_column_type macro, figured it made sense to just implement it to actually work with BigQuery.
In terms of specific schema management use case, our dbt source tables get loaded through various mechanisms and schema changes get propagated through. These schema changes can then cause breaks in our downstream tables that are based on incremental loads. This doesn't mitigate that, but I've built a mini schema management tool that leverages dbt macros to allow us to fix / update schemas as needed. So for this particular macro, in the rare case where a data type got changed, we can use this macro to fix the downstream table's schema.

Got it, that sounds reasonable—and cool that you're doing so much of it with dbt macros!
If someone's going to be calling this method from an external tool, I think it's fair to say they've read through the codebase around adapter methods. I'd be in favor of adding an inline code comment, caveat usor, that quotes or paraphrases from the BQ docs:

Changing a column's data type using a query requires you to scan the entire table. The query charges can be significant if the table is very large.

Just to make sure we're on the same page, is adding that as a jinja comment to the top of the macro what you had in mind?

Yes, that's exactly what I had in mind—a quick note and link to that BQ docs page, within a Jinja comment, at the top of the bigquery__alter_column_type macro.

Hey @jtcohen6 any other changes needed?

Looks like the redshift tests triggered a redshift bug, I'm just re-running that from failed. The postgres tests look like an issue I fixed a while ago, but this PR is pretty old so I assume it just hasn't pulled in the fix.
I'm perfectly comfortable merging this in as it is once the redshift test passes. Nothing this PR changes should care about the OS.


Please add a license file and a screen shot

I'd like to add this to awesome-zsh-plugins, but I prefer to add themes with screen shots in the readme so that users can see what they look like without having to install them.
Also, please add a license file, some people won't use any code that doesn't have an open source license. If you don't have one in mind, https://choosealicense.com is a good resource to help you select an appropriate one.
Thanks!

Thank you very much for your reminder, I have added license and preview of the effect

Added it, thanks.


File system performance improvement

https://github.com/MicrosoftDocs/WSL/issues/604
Please check the issue.
One of the great advantages of WSL2 is the seamless use of Linux on Windows and the interworking of file systems.
It is of great significance for software developers.
It also makes up for some troublesome things of developing software on Windows.
For example, some operations can be more convenient under Linux.
This can be achieved through the WSL2 subsystem.
But I can't have the same code on Windows, in the WSL2 subsystem, which obviously doesn't reflect the value that WSL2 brings to the Windows platform.
If the code needed to build the Java project in Linux is in the Windows System D drive, the performance at build time is very poor.
The code of the Windows System D drive must be copied to the Linux file system.
If so, why should I use the WSL2 Linux subsystem?
Instead of using VirtualBox?
If WSL2's performance for accessing the Windows file system is extremely poor, why do you want to exchange visits?
In this way, WSL2 seems to be of little value!

I'm also a Java developer
When I was using WSL2, I wasted about a month. My conclusion is:
1.  WSL 's file system does not mount as well as VirtualBox does.
2.  The code is saved in the user directory of disk C, which is very unsafe and inconvenient to set up the WSL installation disk. If you write Java or PHP code, it is recommended to buy a Mac computer.


Message: javascript error: webpackJsonp is not defined

this error started to happen unexpectedly just now.

https://github.com/mukulhase/WebWhatsapp-Wrapper/pull/1003

#1003

thanks man, works fine. Can you pass your e-mail or whatsapp? I'd like to make you a proposal

send-me a email<EMAIL_ADDRESS>i will reply you with my WhatsApp.

no send message

no send message

Functions need to be check, i only fixed store until now.

open chat is not working either, @bobaoapae if you can help, thanks.

open chat is not working either, @bobaoapae if you can help, thanks.

give me more details of the function that is not working please.

hey, thanks a lot. i am not familiar with this library but i was using createWid with Store.Cmd.openChatAt to move to specific chat user . now the createWid module is gone but i saw the OpenChat object in neededObjects . tried the window.OpenChat which is undefined. and window.Store.OpenChat needs some parameters . so my problem is navigating to<EMAIL_ADDRESS>chat window.
thanks again

@erickmourasilva you think can you help with this opening xxx numbers chat window directly ?

window.WAPI.openChat = async function (id, msg) {
let idFind = Store.WidUtils.createUserWid(id);
let chat = await Store.Chat.find(idFind);
var openChat = new Store.OpenChat();
openChat.props = {msgText: msg};
openChat.openChat(chat);
};

{
id: "WidUtils",
conditions: (module) => (module.createWid) ? module : null
}

@bobaoapae thanks a lot. Can I contact you too, via an email ?
thanks again, and you too @erickmourasilva .

Yeah, of course. My e-mail is<EMAIL_ADDRESS>

Yeah, of course. My e-mail is<EMAIL_ADDRESS>
will do . thanks


Adds --compound and --keyframe_interval command line options

adds --compound as boolean to enable reordering
adds --keyframe_interval which I think could be useful to specify other value than 30, say, for when encoding 60fps videos.

Looks good.
As a matter of naming, --compound doesn't tell you very much. The only reason you'd ever want to disable it is if you want very low intrinsic latency. Maybe a --low_latency flag would be better?

Renamed --compund to --low_latency.

Another note, it was suggested to me that the GOP/KF switch be named similarly to x264 for familiarity.  That would look like --keyint/-I (capital i) if we wanted to match.

Thanks!


Removed SQL Request classes

removed SQLRequest classes
moved SQLResponses to test package and made them simple wrappers
simplified SQLTransportExecutor

Please Review @seut @dobe @mfussenegger or @matriv

Current coverage is 81.19% (diff: 100%)

Merging #4355 into master will increase coverage by 0.03%

@@             master      #4355   diff @@
==========================================
  Files          1306       1300     -6
  Lines         44249      44008   -241
  Methods           0          0
  Messages          0          0
  Branches       7029       6996    -33
==========================================
- Hits          35910      35732   -178
+ Misses         5692       5626    -66
- Partials       2647       2650     +3

Powered by Codecov. Last update 6679553...3d92f01


Add al_general.py

I added the py file and versioned it up.
I don't understand what the change in setup.py (install_requires=[...]) is about. Is it because I used 3 digits in the version instead of 2?


Issue #229 fix

Thanks for submitting this!
This has been merged. I did some refactoring and bug fixes. Please let me know if you see any issues with my changes. Thanks.


[KARAF-6784] Add ENV KARAF_EXEC to dockerfile

I gonna test and take a look. Thanks !

retest this please

I gonna add this in the script as well.


feat: add pip cache

Add pip cache to Setup python step

Just to be sure: as per docs the
cache: 'pip'

seems to cache pip’s internal cache between workflows (and therefore between workflow VMs) of the same run — but that’s not stated explicitly. Is that correct?
Furthermore, note that SLSA Build Level 3 requires to

prevent runs from influencing one another, even within the same project.

The term “run” isn’t clearly defined, but we need to keep in mind that while the public PyPI artifactory is trusted, caches in between are not because modifications/tempering is invisible to us (see also cache poisoning). (And that includes an AWS Artifactory or the like!)
Also, looking at the runtimes of the Check change set workflow  I get values (random sampling) ranging from 3m 55s, 4m 25s to 5m 31s, 6m 17s and up to 7m 7s, 8m 8s — with this change clocking in at 7m 45s:

So, do we have a measurable impact resulting from this?

@behnazh what do you think of this comment: https://github.com/pre-commit/pre-commit/issues/2847#issuecomment-1514683897

@behnazh what do you think of this comment: pre-commit/pre-commit#2847 (comment)

This solution seems to have similar issues for build isolation. We have designed _build.yaml reusable workflow in a way to be fully isolated, e.g., by limiting the inputs to the workflow and not using any third-party GitHub Actions (except for the trusted Actions from GitHub itself). Enabling caching breaks the isolation security property.


Running initial Sabayon causes Heroku app to restart (NodeJS/Express)

After configuring the Sabayon app and running it for the first time, it causes the target application to restart itself multiple times. Furthermore, it isn't successfully creating the certificate after validating everything twice. I've followed all the instructions, but I'm trying to figure out why this might not be working.
Whenever I try to enable the SNI lab, it says
! Couldn't find that feature.

I believe it's because the feature is now a part of Heroku paid plans. What might be going wrong that's causing the app to restart itself?
I'm using a NodeJS & Express app. I'm also running KeystoneJS as a framework, which might be getting in the way.

Hi,
Indeed, the lab flag isn't required anymore. I've removed it from the readme.
Yes also, SNI is only available on heroku paid plans. You cannot use this tool if your main app isn't using an heroku paid plan.
You should expect one restart every time sabayon generates/updates certificates, as it needs to set the appropriate config vars.
Multiple restarts are definitely weird. Could you copy/paste the sabayon app logs associated with those restarts?
Thanks

I don't think it's an issue of restarts, but that it appears to be timing out after a certain point in time. My app takes some time to start up, which is a problem moreso on my end than yours. I was able to add the certificate manually, which isn't ideal but I'll try to see if I can reapproach this issue soon.

You can set the RESTART_WAIT_TIME config var on the sabayon app to wait a number of seconds before expecting the app to have restarted.
The default is 20 seconds.

I'm going to close this issue, as it doesn't seem to be calling for any remediation items on the sabayon codebase.


Global Popover Options

Is there a way to change / set the default popover config options? Like if I want arrow: false as default, instead of setting it individually on all popovers, could I set it once globally somehow? I tried standard JS global settings for functions but maybe my syntax was off.
Thanks.

I've added the new global method 'setDefaultOptions(options)', now you can change the default options with this global method.
Thanks.

Cool. Thanks.


Finish up the load/save stuff

Incorporate gists (#19)
Make "save" actually work
Make UI not horrible
Add a "delete" too

("delete" point raised by https://twitter.com/f1ac5

Closing in favour of #150


Improve test coverage

Since the project is growing up quickly and there aren't many tests to guarantee the code won't break due to changes, we need to improve our quality control.
The structure of the code seems stable enough for us to ensure its stability increasing the test coverage.

We need to check the actual test coverage and set the desired percentage.

Closing because the project was broken down into smaller projects and the remaining code is only for generating packages.


wrist dislocation

wrist dislocation
DEF: displacement of any of the small carpal bones which make up the wrist out of their normal position in the wrist joint
SYN: dislocated wrist

Added new term:
wrist dislocation MP:0030864


Update requirements

Codecov Report

Merging #377 (9ac8bbd) into main (8e31cfc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   90.17%   90.17%
=======================================
  Files         336      336
  Lines       11965    11967    +2
  Branches      852      853    +1
=======================================
+ Hits        10789    10791    +2
  Misses       1041     1041
  Partials      135      135

Files
Coverage Δ

connections/tests/test_apartment_model.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


14 - CSS:  (Main) Style results container and results cards

Style the results container and results cards displayed within.

results container looks great and uniform with the rest of the project


Increase static array size in NRVO test

Because GDC actually returns int[3] in registers on 64bit when the function is marked static.
Actually, it returns int[3] in registers regardless.  So I guess a bug report on DMD non-conforming ABI should be raised then...

Bug raised: https://issues.dlang.org/show_bug.cgi?id=14711

Ping @9rnsr - since you wrote this test.

@ibuclaw When I had fixed the issue, I had checked only the generated code in Win32. So this change is not bad to me. Thanks.


Finalise the language switch toggle

The design for desktop should be finished by now, but there might be some changes for mobile? #496
Acceptance criteria

The markup must make sense semantically
It must be accessible for both keyboard users and screen readers

It's a bug with url, missing /

Updated the design and fixed the issue with the missing slash,


Add Sqlsrv driver

Description
This PR adds Sqlsrv driver based on @qury work. I'm not experienced with MSSQL but not many changes were needed.
The code has been cleaned up a bit and a few minor changes have been made to make the tests working.
Some tweaks are probably needed, so if anyone takes the time to review it, I would appreciate adding code suggestions to make things easier for me.
Closes #3612
Checklist:

[x] Securely signed commits
[x] Unit testing, with >80% coverage
[x] Conforms to style guide

You rock! Thanks for getting this one across the finish line, and @qury - you're a rockstar! Thanks for all of your work on this.

Documentation user_guide_src/source/intro/requirements.rst need to be updated  below:
A database is required for most web application programming.
Currently supported databases are:

and remove MS SQL below :
Not all of the drivers have been converted/rewritten for CodeIgniter4.
The list below shows the outstanding ones.

You can fix rector error with run :
vendor/bin/rector process

I'm sorry I haven't had a chance to look at this yet. I've only used MSSQL moderately but I did follow the original work. I suspect this is good but it is a pretty big addition and merits a full review.
Is there anyone else watching this who is familiar with MSSQL and could do a review?

I tried in ci4-album with Sqlsrv driver, with album - track table relation at https://github.com/samsonasik/ci4-album/pull/8/checks?check_run_id=1209486951 , running test got the following error:
   ┐
   ├ Exception: [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Cannot truncate table 'album' because it is being referenced by a FOREIGN KEY constraint.
   │
   ╵ /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/codeigniter4/system/Database/Sqlsrv/Connection.php:539
   ╵ /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/codeigniter4/system/Database/BaseConnection.php:724
   ╵ /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/codeigniter4/system/Database/BaseConnection.php:652
   ╵ /home/runner/work/ci4-album/ci4-album/vendor/codeigniter4/codeigniter4/system/Database/BaseBuilder.php:2774
   ╵ /home/runner/work/ci4-album/ci4-album/test/Controller/AlbumTest.php:25
   ┴

The foreign key is using :
$this->forge->addForeignKey('album_id', 'album', 'id', 'CASCADE', 'CASCADE');

at https://github.com/samsonasik/ci4-album/blob/ac5d31f53beb67384d82b90bbe2e0da2d80492d0/src/Database/Migrations/2020-03-26-203957_Track.php#L29
which should automatically handle truncating like in MySQL.

The database itself does not allow truncating a table that has a remote constraint.
The only solution would be to drop the constraint, truncate the table and re-create the constraint.

ok, another issue I found is it somehow can't do model->db->affectedRows() got undefined property stdClass::$numrows

I believe that problem with TRUNCATE will also occur in Postgre, so if we want to add this functionality (truncate when foreign keys are present), we should probably address this in the separate PR that will add support to all handlers (via special parameter for this method).
As for numrows, I will try to look into it.

@samsonasik It should be fixed now.

@michalsn thank you. The stdClass::$numrows error seems fixed now.
The next seems find a tweak how to make controller test that extends CIDatabaseTestCase works without error : "Cannot truncate table 'album' because it is being referenced by a FOREIGN KEY constraint"

@samsonasik Is there no issue with truncate on Postgre?

I tried, but not in run tests, I will check.

@michalsn
If a table1 has a foreign key to table 2 then you can truncate table1 without any issues however you can't truncate table2.
SQL used
ALTER TABLE [dbo].[table1] ADD FOREIGN KEY ([table2]) REFERENCES [dbo].[table2] ([id]) ON DELETE CASCADE ON UPDATE CASCADE

@michalsn @qury Thank you. Just tried run test in PostgreSQL ,and it got same error:
 ✘ Index album has no data
   ┐
   ├ ErrorException: pg_query(): Query failed: ERROR:  cannot truncate a table referenced in a foreign key constraint
   ├ DETAIL:  Table "track" references "album".
   ├ HINT:  Truncate table "track" at the same time, or use TRUNCATE ... CASCADE.

It seems that need manual clean up data in controller test for Postgres and Sqlsrv then.

@qury I was referring to the code example given by @samsonasik and he is using truncate() combined with disableForeignKeyChecks() (link) which will work for MySQL and SQLite (probably).
That's why I proposed to address this in the separate PR to make it possible to produce the same functionality for all drivers. Probably something like truncate(true)? idk really - I haven't thought it out yet. And I'm not sure if this will happen.
Anyway for now, truncate "problem" is out of the scope for this PR, since this is completely valid behavior.

@qury We have some commented lines in the code. Is it something that will be useful when doing some changes later or it can be cleared up?

@michalsn They can be cleared up.
Also thanks for taking this over :+1:

Seems like we have a temporary problem with sqlsrv extension (not available) after updating from PHP 7.4.10 to PHP 7.4.11. I tried to use a specific version number (the latest preview) as a workaround but without a luck 😕

is it possible to pin php-version to 7.4.10 ?

No, we can only specify a minor version 😞

Well... apparently on Monday everything decided to start working again 🤷♂

@lonnieezell @MGatner @samsonasik @paulbalandan @qury All tests look good. I think I would like to merge it at this stage. This will allow other developers to battle-test it even more and then we should be able to fix any possible bugs before the next release.

I agree. I still haven't actually used it but I've been through the code and read all the comments, and I will be very glad to see this get some use!

One more time - thank you @qury!

Good work!
Is anyone working on the version with PDO ?
I'd like to help.
I have used the driver made available by microsoft (with CI3) and has served me very well.
https://github.com/microsoft/msphpsql/releases


Typo error in the title

type error in the title, I think, it should be "Cloudflare" not "Clouldflare"
"Tutorial: Configure Clouldflare with Azure Active Directory B2C"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 550c80cc-f367-779e-5668-42d213423c4e
Version Independent ID: 4658e649-f888-bb4a-8001-b5cc94f392ae
Content: Tutorial to configure Azure Active Directory B2C with Cloudflare Web Application Firewall - Azure AD B2C
Content Source: articles/active-directory-b2c/partner-cloudflare.md
Service: active-directory
Sub-service: b2c
GitHub Login: @Gargi-Sinha
Microsoft Alias: gasinh

@userr17
Thanks for your feedback! We will investigate and update as appropriate.

Thank you! I just made a pull request to fix the typo in the title and the other typo in that paragraph. https://github.com/MicrosoftDocs/azure-docs-pr/pull/157582


use node-red-node-test-helper for node tests

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Proposed changes
Use new node-red-node-test-helper module in core for consistency and ease of maintenance with contrib node unit tests as discussed
Checklist

[x] I have read the contribution guidelines
[x] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[x] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 87.755% when pulling 10d8ca30b042eada12ddf0370c8d696c3e042c44 on SenseTecnic:use-test-helper-module into 4ebb5d099e9f1589b142bd374645eb6ed7167f0b on node-red:master.


 I get the feeling that it's down to the number of gits we're trying to serve. Have been adding 20-30 gits a day and went over 1200 on Friday (whilst I was away) and at some point this error started appearing. (we're using v0.5.0 btw)
When trying to go to the root of the gitlist directory (where the index appears) I get a very long error listing all the gits and saying it can't find a match... when trying to go into a specific git directly we see an error along the lines of Oops can't find route to GET /foo/bar.git.

Hi am actually having the same issue with the root repository folder contains 70 repositories (and some are folders that have sub-repos).
Is there any suggestioin to fix this?
Thanks
Best regards
Andrea

I don't think there's a quick fix.
At the moment, all available repositories get compiled into a regex to match the URL instead of searching for them on-demand. The related code and its logic needs to be changed to support more repositories.

Hi, thanks for your reply.
I see your point, do you happen to know what would the current limit be?
Thanks
Andrea

I see.
Thanks for the info :)


[Feat]: Implement lazy loading to the pages

What feature?
I would like to implement lazy loading to all the pages.
Lazy loading is a technique that can be used to improve the performance of a website by delaying the loading of resources until they are needed. This can help to reduce the initial load time of a page, which can improve the user experience.
The benefits of lazy loading include:

Reduced initial load time
Improved user experience
More responsive website

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please assign me this issue so that I can work on this issue under GSSOC'23.

@JasonDsouza212 Any update on this please?


Secret syncer basics

Q
A

Bug fix?
no

New feature?
yes

API breaks?
no

Deprecations?
no

Related tickets
-

License
Apache 2.0

What's in this PR?

Implementing the basics for a new operator working together with the webhook, which - if enabled - will periodically check if the secrets used by a resource that has the alpha.vault.security.banzaicloud.io/reload-on-secret-change annotation set to true are still the same version as in Vault, and if not, updates the resource ensuring it has the the latest version of the secrets.
This feature will support only deployments first. Implemented in this PR:

a new logic in the webhook that adds a new alpha.vault.security.banzaicloud.io/secret-version-hash annotation with the hashed value of the path and current version of the Vault secrets to the deployment
a temporary CLI tool that accepts the name (and namespace) of a deployment, and collects the used Vault secrets again, generates the hash, compares it to the one in the annotation, and if they are not matching, updates the annotation which causes the pods to restart, and the webhook doing its job again, but now with the latest version of the secrets. The logic implemented here will be the part of an operator later.

The new collector package can find Vault secret paths to collect that are specified:

as env in the pod template in the following format: vault:secret/data/mysql#MYSQL_PASSWORD
in a secret or configmap through valueFrom or envFrom in the following format: vault:secret/data/mysql#MYSQL_PASSWORD. It also uses the contents of the kubectl.kubernetes.io/last-applied-configuration annotation, because if the secret or configmap mutation is also enabled in the webhook, the value of these Vault secrets already being injected into them so the original Vault secret path can only be found there. Also if the secret change affected a secret stored in a k8s secret or configmap, that also needs to be re-applied which achieved by patching them with the contents of the last-applied-configuration annotation.
in the vault.security.banzaicloud.io/vault-env-from-path annotation in the pod template
in vault templates from configmaps specified in the vault.security.banzaicloud.io/vault-agent-configmap annotation in the pod template

Why?

To make the first steps towards a new operator that keeps resources mutated by the Bank-Vaults webhook up to date with Vault.
Additional context

Steps for local testing:

Prepare a kubernetes cluster (recommended with Docker desktop or kind)
Start the operator with make operator-up
Create the namespace vswh (kubectl create namespace vswh)
Create a Vault instance with kubectl apply -f operator/deploy/cr.yaml
Build a local version of the webhook: docker build . -t ghcr.io/banzaicloud/vault-secrets-webhook:local -f Dockerfile.webhook
Install the webhook:

helm upgrade --install vault-secrets-webhook charts/vault-secrets-webhook \
    --set replicaCount=1 \
    --set image.tag=local \
    --set image.pullPolicy=IfNotPresent \
    --set configMapMutation=true \
    --set deploymentSecretSync=true \
    --set configmapFailurePolicy=Fail \
    --set podsFailurePolicy=Fail \
    --set secretsFailurePolicy=Fail \
    --set vaultEnv.tag=latest \
    --namespace vswh

Apply the test deployment: kubectl apply -f test/deploy/test-deployment-sync.yaml
Check if the annotation is present in the deployment: kubectl get deploy hello-secrets-sync -o jsonpath='{ .metadata.annotations.alpha\.vault\.security\.banzaicloud\.io/secret-version-hash }'
Start port-forwarding Vault: kubectl port-forward vault-0 8200:8200 and in another terminal instance, export some important envs that the CLI tool needs:

export VAULT_TOKEN=$(kubectl get secrets vault-unseal-keys -o jsonpath={.data.vault-root} | base64 --decode)

kubectl get secret vault-tls -o jsonpath="{.data.ca\.crt}" | base64 --decode > $PWD/vault-ca.crt
export VAULT_CACERT=$PWD/vault-ca.crt

export VAULT_ADDR=https://<IP_ADDRESS>:8200

Run the CLI tool: go run cmd/vault-secrets-syncer/main.go deploy hello-secrets-sync. The last log should say Secrets are up to date
Now change a secret in Vault in the same terminal window: vault kv patch secret/mysql MYSQL_PASSWORD=updated3xtr3ms3cr3t
Run the CLI tool again and observe in its logs and also with kubectl get deploy hello-secrets-sync -o jsonpath='{ .metadata.annotations.alpha\.vault\.security\.banzaicloud\.io/secret-version-hash }' that the annotation is indeed has been changed and the pods restarted, and in the pod logs the new secret has been echoed.

Checklist

[x] Code meets the Developer Guide
~User guide and development docs updated (if needed)~
~Related Helm chart(s) updated (if needed)~

This POC is now in a draft PR in its own repo: https://github.com/bank-vaults/vault-secrets-reloader/pull/2


Add default reviewers for release PRs

When a release PR is created, it needs to be approved by a certain set of approvers. Would be nice if there could be a default set of reviewers for each project that release-please would then add

As mentioned in #2038, reviewers feels out of scope of this automation. There is often more logic desired for assigning or requesting reviews.
This most straightforward way on GitHub is to add a CODEOWNERS file/rule for the files that need updating.


Make sure all configs on the main branch are compatible with experimental changes (i.e. seed -> checkpoint name)

Making a note of this here to make sure it's not lost prior to publicising the library

@s-maddrellmander don't forget to close this issue when done

The new configs in #421 and #423 are modular and much more maintainable. The issue mentioned here is fixed.


[WIP] Move to 2021

closing #404

Hey I think @utam0k has once previously noted that building with 2021 edition took quite a while, but I have tested with the 1.54.1 today, and both dev and release builds were compiling in reasonable time. So I think we can now migrate to 2021 edition, if there are no other issues. 👍

Is it 1.56.1? It works fine for my local with rustc 1.56.1.

Oops, yeah I meant 1.56.1 :sweat_smile: :sweat_smile:

@chenyukang I believe this PR can restart!

@chenyukang I believe this PR can restart!

Synced with main, please review it.


Implement -R command-line option (#818)

This has been done at JBCNConf 2019 Hackergarten with the help of @4lber10.

Looks good! Thank you! 🎉

As discussed in #808, this should trigger a version update to 2.1.0.

True.
I can update the version soon.


keras is no longer supported, please use tf.keras instead.

while running example given on homepage of SHAP-  "Deep learning example with DeepExplainer (TensorFlow/Keras models) " getting this error. Please suggest. ( is there no support for keras only and we have to use tensorflow's keras)?

When using Keras from TensorFlow (from tensorflow.keras import ...) then the warning is still present, but SHAP complains about something different afterwards, i.e., the softmax activation function of the MNIST example. When a sigmoid is used instead then the code runs and produces an image very similar to the example on the homepage (but still with the warning about keras not being supported).
Full working code for reference:
'''Trains a simple convnet on the MNIST dataset.
Gets to 99.25% test accuracy after 12 epochs
(there is still a lot of margin for parameter tuning).
16 seconds per epoch on a GRID K520 GPU.
'''

from __future__ import print_function
#import keras
#from keras.datasets import mnist
#from keras.models import Sequential
#from keras.layers import Dense, Dropout, Flatten
#from keras.layers import Conv2D, MaxPooling2D
#from keras import backend as K
### Note: all instances of keras.something in the code below
### changed to tf.keras.something
import tensorflow as tf
from tensorflow.keras.datasets import mnist
from tensorflow.keras.models import Sequential
from tensorflow.keras.layers import Dense, Dropout, Flatten
from tensorflow.keras.layers import Conv2D, MaxPooling2D
from tensorflow.keras import backend as K

batch_size = 128
num_classes = 10
epochs = 1 # original: 12

# input image dimensions
img_rows, img_cols = 28, 28

# the data, split between train and test sets
(x_train, y_train), (x_test, y_test) = mnist.load_data()

if K.image_data_format() == 'channels_first':
    x_train = x_train.reshape(x_train.shape[0], 1, img_rows, img_cols)
    x_test = x_test.reshape(x_test.shape[0], 1, img_rows, img_cols)
    input_shape = (1, img_rows, img_cols)
else:
    x_train = x_train.reshape(x_train.shape[0], img_rows, img_cols, 1)
    x_test = x_test.reshape(x_test.shape[0], img_rows, img_cols, 1)
    input_shape = (img_rows, img_cols, 1)

x_train = x_train.astype('float32')
x_test = x_test.astype('float32')
x_train /= 255
x_test /= 255
print('x_train shape:', x_train.shape)
print(x_train.shape[0], 'train samples')
print(x_test.shape[0], 'test samples')

# convert class vectors to binary class matrices
#y_train = keras.utils.to_categorical(y_train, num_classes)
#y_test = keras.utils.to_categorical(y_test, num_classes)
y_train = tf.keras.utils.to_categorical(y_train, num_classes)
y_test = tf.keras.utils.to_categorical(y_test, num_classes)

model = Sequential()
model.add(Conv2D(32, kernel_size=(3, 3),
                 activation='relu',
                 input_shape=input_shape))
model.add(Conv2D(64, (3, 3), activation='relu'))
model.add(MaxPooling2D(pool_size=(2, 2)))
model.add(Dropout(0.25))
model.add(Flatten())
model.add(Dense(128, activation='relu'))
model.add(Dropout(0.5))
### Note the sigmoid here instead of softmax,
### resulting in slightly lower classifier accuracy ###
model.add(Dense(num_classes, activation='sigmoid'))

#model.compile(loss=keras.losses.categorical_crossentropy,
#              optimizer=keras.optimizers.Adadelta(),
#              metrics=['accuracy'])
model.compile(loss=tf.keras.losses.categorical_crossentropy,
              optimizer=tf.keras.optimizers.Adadelta(),
              metrics=['accuracy'])

model.fit(x_train, y_train,
          batch_size=batch_size,
          epochs=epochs,
          verbose=1,
          validation_data=(x_test, y_test))
score = model.evaluate(x_test, y_test, verbose=0)
print('Test loss:', score[0])
print('Test accuracy:', score[1])

import shap
import numpy as np

background = x_train[np.random.choice(x_train.shape[0], 100, replace=False)]
e = shap.DeepExplainer(model, background)
shap_values = e.shap_values(x_test[1:5])
# plot the feature attributions
shap.image_plot(shap_values, -x_test[1:5])

Same problem here

I can confirm the issue occurs with other keras models. Here is the full error text I get for one of my Keras 2.3.1 models:
keras is no longer supported, please use tf.keras instead.
Traceback (most recent call last):
  File "./test_shap.py", line 159, in <module>
    explainer = shap.DeepExplainer(model, train_data.X_train[:1000])
  File "/usr/local/lib/python3.6/dist-packages/shap/explainers/deep/__init__.py", line 80, in __init__
    self.explainer = TFDeepExplainer(model, data, session, learning_phase_flags)
  File "/usr/local/lib/python3.6/dist-packages/shap/explainers/deep/deep_tf.py", line 96, in __init__
    self.model_inputs = _get_model_inputs(model)
  File "/usr/local/lib/python3.6/dist-packages/shap/explainers/tf_utils.py", line 66, in _get_model_inputs
    assert False, str(type(model)) + " is not currently a supported model type!"
AssertionError: <class 'lib.keras_models.Binary_LSTM'> is not currently a supported model type!

I am getting the same issues too, was this resolved or any patches to get around?
keras is no longer supported, please use tf.keras instead.
Traceback (most recent call last):
  File "mlp_classifier.py", line 54, in <module>
    e = shap.DeepExplainer(mlp_model, X_train)
  File "/usr/local/lib/python3.8/site-packages/shap/explainers/_deep/__init__.py", line 84, in __init__
    self.explainer = TFDeep(model, data, session, learning_phase_flags)
  File "/usr/local/lib/python3.8/site-packages/shap/explainers/_deep/deep_tf.py", line 99, in __init__
    self.model_inputs = _get_model_inputs(model)
  File "/usr/local/lib/python3.8/site-packages/shap/explainers/tf_utils.py", line 68, in _get_model_inputs
    assert False, str(type(model)) + " is not currently a supported model type!"
AssertionError: <class 'sklearn.neural_network._multilayer_perceptron.MLPClassifier'> is not currently a supported model type!

I resolved this issue by re-running my model with tensorflow.keras instead of just keras (for example, I replaced any imports that looked like "from keras import LSTM" with "from tensorflow.keras import LSTM" and then re-ran). Hope this helps!

@osrussell  - Do you mean you did this? It doesn't works for me:
import tensorflow as tf
from tensorflow.keras.regularizers import l1_l2
from tensorflow.keras.regularizers import L1L2

def create_model(conv_filters, lstm_units, dense_units, learning_rate, dropout_rate,optimizer, activation):
    model = tf.keras.Sequential([
        tf.keras.layers.Conv1D(filters=conv_filters, kernel_size=1, activation='relu', input_shape=(X_train_scaled.shape[1], X_train_scaled.shape[2]),bias_regularizer=L1L2(l1=0.0, l2=0.00001),activity_regularizer=L1L2(1e-5,1e-4)),
        tf.keras.layers.Dropout(dropout_rate),
        tf.keras.layers.Bidirectional(tf.keras.layers.LSTM(lstm_units, return_sequences=True),activity_regularizer=L1L2(1e-5,1e-4)),
        tf.keras.layers.Flatten(),
        tf.keras.layers.Dropout(dropout_rate),
        tf.keras.layers.Dense(dense_units, activation='relu', kernel_regularizer=l1_l2(l1=0.01, l2=0.01)),
        tf.keras.layers.Dropout(dropout_rate),
        tf.keras.layers.Dense(1)
    ])

Fixed by #2943


Proof for ENABLED TRUE fails

Hi, I was using ENABLED within TLAPS and encountered the following curiosity.
I have not found a way to prove ENABLED TRUE. This also applies to similar examples which are not of the form ENABLED <<F>>_v for which F is a formula and v a variable. See the code example below.
Perhaps this is by design? However, I don't immediately see why ENABLED TRUE shouldn't be true, and why TLAPS manages to show that the more complicated form ENABLED <<TRUE>>_x holds as shown below.
\* Proof Fails
THEOREM ENABLED TRUE
PROOF OBVIOUS

\* Proof Succeeds
THEOREM \A x : ~(x'=x) => ENABLED <<TRUE>>_x
PROOF OBVIOUS

\* Proof Fails
THEOREM \A F : F => ENABLED F
PROOF OBVIOUS

\* Proof Succeeds
THEOREM \A F, v : F /\ ~(v=v') => ENABLED <<F>>_v
PROOF OBVIOUS

I understand that in the literature Enabled is usually only used with the form <<F>>_v. However the, documentation usually states something along these lines:

For any action A, we define Enabled A to be the predicate that is true for a state iff it is possible to take an A step starting in that state
page 6, https://lamport.azurewebsites.net/pubs/lamport-actions.pdf

edit: typo; version: TLA+ Toolbox 1.7.4; tlapm 1.4.5

The two examples that succeed do so because the formula on the left-hand side of the implication is trivially false. The \A and \E quantifiers range over values, not state variables, so (looking at the second formula) x' just reduces to x because it is considered a constant.
Support for reasoning about ENABLED is relatively recent and is not included in the distribution, which you appear to be using. In order to reason about ENABLED, you will need to build tlapm from source and then use the ExpandENABLED directive. Preliminary examples are in examples/SimpleEventually.tla and examples_draft/SimpleExampleWF.tla.


Factor LightingEffect out of Renderer

This patch factors the code for the lighting effect out of the all-sing,
all-dance "Renderer" class and into a self-contained LightingEffect
class. Also, gather all the various shaders and resources used by the
lighting effect into //escher/effects/lighting alongside LightingEffect.
Finally, fix a bug with where we were drawing the floating action button
so that it is actually centered under the user's finger.

@j9brown @schwa423

I'm going to land this TBR figuring that you all actually have a sensible work/life balance.  :)
Happy to iterate based on feedback when we're back in the office.


Updated BrowserPanel.java

Previous versions did not sync the bug issues found:
https://github.com/nus-cs2103-AY1819S2/forum/issues/22

Updated link in BroswerPanel.java


community: let's feature Git Rev News!

I noticed Git Rev News is not mentioned on git-scm.com/community, I think it would be nice to mention it there.
@peff @chriscool

totally agree @phil-blain :)
Do you want to make a PR adding a 'Newsletter' section to https://git-scm.com/community ?

PR sent!


Not rendering, just a empty div

I'm trying to use it, but, inspecting, I'm getting a div without contents:

No browserify errors or console errros.
What can it be?

I've had this happen as well. It seemed to be around the time I updated everything from React 0.13 to 0.14, to me it seems like the GoogleChartLoader might have errored silently. I might not be completely following all of it properly but the Chart.js is hitting the render method which gives the empty div but then it gets to https://github.com/RakanNimer/react-google-charts/blob/master/src/components/Chart.js#L24 but that line might not be working? I didn't see any network traffic showing that the javascript for the google chart was getting downloaded which is probably why the chart doesn't load.
In my case at least, the issue seems to be as a part of the build process for my bundle since something isn't getting included. Even after including "scriptjs" it didn't seem to help. Have you fixed yours yet @TiagoGouvea ?
my package.json:
{
  "name": "dashboard",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "babel-preset-es2015": "^6.1.18",
    "babel-preset-react": "^6.1.18",
    "browserify": "^12.0.1",
    "combined-stream": "^1.0.5",
    "eslint-plugin-react": "^3.8.0",
    "gulp": "^3.9.0",
    "gulp-babel": "^6.1.0",
    "gulp-eol": "^0.1.1",
    "gulp-plumber": "^1.0.1",
    "gulp-react": "^3.1.0",
    "gulp-watch": "^4.3.5",
    "memory-streams": "^0.1.0",
    "react": "^0.14.7",
    "react-dom": "^0.14.7",
    "react-dropdown-button": "^1.0.11",
    "react-google-charts": "^0.2.0",
    "react-select": "^0.9.1",
    "react-slick": "^0.10.0",
    "react-widgets": "^3.1.7",
    "scriptjs": "^2.5.8",
    "vinyl-source-stream": "^1.1.0",
    "xhr": "^2.2.0"
  }
}

I haven't @ericfowler303

I have found the same thing. The problem is that errors cause some promise to be rejected, but then nothing is done with the rejection value. By adding a breakpoint in q.js (in the Promise.prototype.then function) I was able to at least fix the problem. Once the configuration was correct my graph did show.
Unfortunately, I did not find which promise was rejected...

I ran into the same problem -- specifically with the bar chart example.  It seems like one of the more recent commits has not been published despite the version bump. When I run
npm install react-google-charts@latest
At line 91 of Chart.js I get:
if ((this.props.data !== null && this.props.data.length === 0) || this.props.columns.length === 0) {
	return;
}

This doesn't match up with the latest version of Chart.js visible here within the project.
This bug (or at least one cause of it) seems to be fixed with @kmayer 's commit, but pulling the latest version of the package does not have his changes.

Exactely as @jeffersonpark mentioned. The distribution in NPM directory is not up-to-date with the master branche. I solved this by installing direct from the git repository instead
npm install RakanNimer/react-google-charts

Very good nanndoj!
Thanks!

Hey !
Thanks for reporting this, I updated the npm package to match the the code in ther repo.
Let me know if the issue resurfaces.
Cheers !

Same issue here with
        <Chart
          chartType="LineChart"
          width="600px"
          height="400px"
          options={{
            title: 'chart',
          }}
          data={[
            ['column_one_label', 'column_two_label'],
            [1, 2],
            [2, 3],
          ]}
        />

Can't use latest version unfortunately because of https://github.com/RakanNimer/react-google-charts/issues/26


1.2.17a Set up Recovery Phrase/Double check/ loading

1. User Story
As a user....
2. Acceptance Criteria

tbd
tbd
tbd

3. Related Issues

[ ] Create all related issue for this issue, label them, assign them, and move them to the right projects.
[ ] tbd
[ ] tbd

4. Wire Frame
Add:

Screenshot
Figma link to specific element

5. Design

Figma link: https://www.figma.com/file/ERJ7bYyBWdqJw1ID9nZJ2N/Designs?node-id=7904%3A10665

updated @steffenkrogmann


Fix #200 ReflectionSingleValueDecoder.decode and ReflectionKeyedDecoder.decode

Fix #200 ReflectionSingleValueDecoder.decode and ReflectionKeyedDecoder.decode to return the truthy value when the context is active.

I couldn't think of the good work around to pass the test.


Grammar/Typo correction in docs-contributing-section

@arslannoorpansota Thanks for this patch :+1: However most of your edits are not typos. I also think that the current punctuation is correct.

also maybe fix the typo in "grammar" in your title :D

@jacobtylerwalls Please have a look and proceed to merge!

Hi, it looks like some comments are still unaddressed.
https://github.com/django/django/pull/15195#discussion_r779629656
https://github.com/django/django/pull/15195#discussion_r774216886

@jacobtylerwalls  It requires a maintainer to approve running workflows!