Handle Rspec negated be_able_to for actions list

Currently, the rspec matcher handles list of actions correctly for to be_able_to case and returns successfully when the user is allowed to perform all the specified actions.
But, it doesn't work correctly for a list of actions for the negated cases.
# Ability
can [:read, :create, :update], Account

it { is_expected.to be_able_to([:read, :create], Account.new) }  # Passes when user is allowed to perform both actions (read, create)

it { is_expected.not_to be_able_to([:destroy, :read], Account.new) }  # Passes even though user is allowed to read

The underlying issue is this line
actions.all? { |action| ability.can?(action, *args[1..-1]) }

It will return false when we have some true values and even one false value.
PR fixes the issue by making use of => https://relishapp.com/rspec/rspec-expectations/docs/custom-matchers/define-a-custom-matcher#matcher-with-separate-logic-for-expect().to-and-expect().not-to

We are planning to disable negate able_to matcher for multiple actions. This lead to a lot of confusion in the past. See https://github.com/CanCanCommunity/cancancan/pull/796

@coorasse thanks for the update. Closing PR.


[Typography] Small improvements

Switch the default variant between typography v1 and v2.
Don't apply the scale twice
Round the letter spacing value
Makes Material-UI less opinionated regarding the letter-spacing value. I think that the specification is promoting a too strong letter-spacing value, at least for a minor release. I'm softening the change.

do we interpret the spec?

We do interpret the specification, as Google is doing with all its products. Even the Material Design specification website and the MDC Web implementations are interpreting the spec. There are two topics here.
The first one is around keeping 14px as the default font size when using the Typography component. To achieve that, we need to switch body 1 with body 2. Also, I think that we should use the next typography for the regression tests.
The second topic is around not changing the letter spacing too quickly. We can always change the letter spacing in v4.0.0 to a final value. I don't think that we should be updating our implementation faster than Google is updating it's products. I haven't seen them executing on the new letter spacing yet.


bump: tag and release v1.0.1

Release
This would mean tagging e2f4237fb6ac602f68a786afaaf6388fb30b866d as v1.0.1 to release.
Vote
We need at least 4 approvals from 6 maintainers to release notation v1.0.1.

[ ] Junjie Gao (@JeyJeyGao)
[ ] Milind Gokarn (@gokarnm)
[ ] Patrick Zheng (@Two-Hearts)
[ ] Pritesh Bandi (@priteshbandi)
[ ] Rakesh Gariganti (@rgnote)
[ ] Shiwei Zhang (@shizhMSFT)

Changes
The code changes compared to v1.0.0 include:

#761
#762
#758
#763
#760
#757
#764
#714
#766
#774
#775
#780
#781
#782
#779
#794
#795
#797
#796
#789
#786
#785
#799
#803
#800
#776
#805
#787
#810
#815
#814
#813
#818
#819

Full Changelog: https://github.com/notaryproject/notation/compare/v1.0.0...e2f4237fb6ac602f68a786afaaf6388fb30b866d
Action Requested
Please respond LGTM (approve) or REJECT (request for changes).

Codecov Report

Merging #820 (e2f4237) into release-1.0 (7f8e86c) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@             Coverage Diff              @@
##           release-1.0     #820   +/-   ##
============================================
  Coverage        63.94%   63.94%
============================================
  Files               40       40
  Lines             2291     2291
============================================
  Hits              1465     1465
  Misses             700      700
  Partials           126      126

Files
Coverage Δ

internal/version/version.go
100.00% <ø> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Since v1.0.1 is a patch release, the following feature in the main branch is NOT cherry-picked.

#798


Use SPDX expression in package license field

We use an SPDX expression for the license field in package.json instead of the non-standard list of licenses. This is the standard format that NPM recommends.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


initial pull

- What I did
- How I did it
- How to verify it
- A picture of a cute animal (not mandatory but encouraged)

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "master" git@github.com:docker/docker.git somewhere
$ cd somewhere
$ git rebase -i HEAD~204
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

I think this was opened by mistake, so I'll close it


feat: new travis stage and auto release

:tada: This PR is included in version 3.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add Character: Sheldon Cooper

Hero Description
Sheldon is a theoretical physicist, Sheldon is a fan of comic books, science fiction series, collectible card games, video games and RPG.

Inspiration
the big bang series.

Moves
Idle
Sheldon is thoughtful.

[STICK] Walk
Walkcycle.

[LEFT] String Theory
sheldon activates the clock on his arm, creating a barrier of vibrant strings surrounding the enemy and paralyzes him for 5 seconds.

[MIDDLE] Worm Hole
Sheldon creates wormholes to teleport around the map.

[RIGHT] Sheldonbot
He becomes a robot. As several times they said that in the series he was a robot.
it creates sound waves that irritate your opponents and cause damage.

[Q] The Big Bang
sheldon uses the power of the mind to create an explosion of the big bang.

OPTIONAL
[E] TAUNT
Stephen Hawking plays a prank on Sheldon.

Tasks

[x] Idle
[x] Walk
[x] [LEFT] add skill name
[x] [MIDDLE] add skill name
[x] [RIGHT] add skill name
[ ] [Q] add skill name

creation and walk 8 hrs.

worm hole  11:30 hrs.

idle: 4 hrs

sheldonbot: 9:30 hrs
character animation: sheldon takes a robot from his bag and places it on the floor.

project: the robot walks towards the opponent.

final action: the robot launches a sound attack on the opponent.

string theory: 6 hrs
sheldon activates the watch on his arm, creating a barrier of vibrant strings.

taunt: 5:30 hrs

the big bang: 6 hrs


feat: Add support for time-zone, 3 & 5 digit years: Cast from string to timestamp, compatibility guide update.

Which issue does this PR close?
Closes #376
Rationale for this change
What changes are included in this PR?
Added 3 & 5 digit year, time-zone support, compatibility guide update.
How are these changes tested?
Through Unit tests, fuzz tests.

Thanks @akhilss99. Could you run make format to fix the code formatting?

@andygrove, can you please run the CI build again? thanks!

Triggered.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.55%. Comparing base (ded3dd6) to head (bee83f3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #704      +/-   ##
============================================
- Coverage     33.57%   33.55%   -0.03%
+ Complexity      830      816      -14
============================================
  Files           110      110
  Lines         42608    42564      -44
  Branches       9352     9361       +9
============================================
- Hits          14306    14282      -24
+ Misses        25347    25322      -25
- Partials       2955     2960       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Can anyone please run the build?
thanks

Triggered again.


Don't throw Call init form after socket Connect Success RelaySDK(SingnalWair)

Hello Team,
 I am not able to throw call after connection Socket success.

I am making call like this method
// Make Call
this.client.newCall({ destinationNumber: this.state.extension, video: { facingMode: 'user' } })
// this.state.extension -><PHONE_NUMBER>0. USA Country
No any Log show in terminal after call Init register user.
Error Show : TypeError: undefined is not an object (evaluating '_this4.client.newCall')
Thanks
Vivek Shukla

Hi @viv578ek, from the TypeError seems the this.client is not defined.
Please make sure to read our Getting Started docs page and follow the vanilla example here.

Hi @edolix
But I am not getting any log related to call initiations our end.

And I am also fallow all process as per shared Documents.

Since your this.client variable is undefined, no call can start so this means no logs. The only log you have is undefined is not an object.
Double check your client setup or share a snippet code to see the client init - thanks!

Ok let me try again

I'm going to close this one for now.
Can you open a support ticket from your SignalWire account by visiting https://<SPACE_NAME>.signalwire.com/support_tickets/new? You can reference this Github issue in it, but the technical support staff will be able to assist you more and narrow down the issue, since the problem doesn't seem to be a technical SDK one, but something possibly with your configuration / client setup.
Thanks!


Swift3.0

I'm submitting this request to master, but I believe that there should be a swift-3 branch instead. What I would propose as the timeline would be:

Maintain 2.3 and 3.0 branches until Xcode 8 GM is released.
Keep the 2.3 branch long term for legacy support.
Merge 3.0 into master.
When the next version of Swift is released, create a legacy swift-3.0 branch off of master.

This way, user's of the framework can target a specific branch if they need legacy support, or master if they want the most current version.
Thoughts?

OK. We should support two versions of Swift with different branches.
I started swift-3 branch here #8 and merged #7 to it.


Add checkIgnore to this Repo

User is requesting some method similar to that of the other SDKs where we can ignore data being sent to Rollbar. This is a little trickier considering the config file is yml.
internal: https://app.intercom.io/a/apps/rlisg82q/inbox/inbox/849049/conversations/15591684072

Like @ajtran is saying, it would be great if we could use checkIgnore on rollbar bundle to disable some redondant messages.
Thank you by advance !

This is supported in the latest release with the following configuration in app/config/config.yml or app/config/config_*.yml:
rollbar:
    enabled: true
    access_token: YouAccessToken
    environment: YourEnvironmentName
    check_ignore: '\MyClass::checkIgnore'

The check_ignore config option takes a PHP callable as a string.


Serving pocketbase from a  reverse proxy in a route other than root route / always resolves to 404 not found

Recently, I've been trying to serve pocketbase in /pocket route. I've set up an NginX config to do so, however, I always get 404 not found error. My NginX config kind of looks like this:
server {
        listen 80;
        listen [::]:80;

        server_name {MY_DOMAIN} www.{MY_DOMAIN};

        return 302 https://$server_name$request_uri;
}

server {
        listen 443 ssl http2;
        listen [::]:443 ssl http2;

        ssl_certificate /etc/ssl/website/public.pem;
        ssl_certificate_key /etc/ssl/website/private.pem;

        server_name {MY_DOMAIN} www.{MY_DOMAIN};

        root /var/www/html/;

        index index.html index.htm;

        location / {
                proxy_set_header Host $http_host;
                proxy_set_header X-Forwarded-By $remote_addr;

                proxy_pass "http://<IP_ADDRESS>:4000";
        }

       location /pocket {
               proxy_set_header Host $http_host;
               proxy_set_header X-Forwarded-By $remote_addr;

               proxy_pass "http://<IP_ADDRESS>:8090";
       }

}

What I think is, when we pass request came to /pocket route, the URL pathname does not change. So, we are hitting indirectly to a route that doesn't exist in pocoetbase ( which kinda look like this to pocketbase when we want admin dashboard: /pocket/_). Is there a way to fix it from NginX itself? Or, pocketbase needs some change?

What if we use sub domain ? pocket.yourdomain.com 😬 😬

@Mr-M1M3 Ah, I think you need a rewrite rule, eg.:
location /pocket {
    rewrite ^/pocket(.*) /$1 break;

    ...
}

@Mr-M1M3 Ah, I think you need a rewrite rule, eg.:
location /pocket {
    rewrite ^/pocket(.*) /$1 break;

    ...
}

Hey, that doesn't seem to be working. Can you provide full locatio context? Also, are you sure that the regex is the correct one? Shouldn't the regex end with with a $ sign?

@Mr-M1M3 Sorry, I haven't tested the above. It was just an example. I'll try to find sometime next week to test the subpath setup in more depth and eventually update the nginx example config.
And yes, the regex should end with $. For more complete examples you can check https://www.nginx.com/blog/creating-nginx-rewrite-rules/.

@Mr-M1M3 Sorry, I haven't tested the above. It was just an example. I'll try to find sometime next week to test the subpath setup in more depth and eventually update the nginx example config.
And yes, the regex should end with $. For more complete examples you can check https://www.nginx.com/blog/creating-nginx-rewrite-rules/ and https://nginx.org/en/docs/http/ngx_http_rewrite_module.html#rewrite.

Thanks for your concern ^^ ^^ ^_^

@ganigeorgiev Hello, I managed to fix it by the help of ChatGPT. ChatGPT told me turn proxy_redirect to off and it worked justas expected. Sorry, for not mentioning that, although other valid api routes returned 404, visiting /pocket/_ redirected to /_.

Hi, I do like this in Nginx.
location /v2 {
    proxy_set_header Connection '';
    proxy_http_version 1.1;
    proxy_read_timeout 180s;

    proxy_set_header Host $host;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header X-Forwarded-Proto $scheme;

    proxy_pass http://service-pocketbase:8090;
  }

when I access using api.xxx.com/v2 it display like this.
{
    "code": 404,
    "message": "Not Found.",
    "data": {}
}

What I am missing here? Thanks in advance.

@sonyarianto I think you may need a rewrite rule before the proxy_pass directive, something like:
rewrite /v2/(.*) /$1  break;

@ganigeorgiev wow thank you for quick answers :) It works now. Just share mine here.
location /v2 {
    rewrite /v2/(.*) /$1  break;

    proxy_set_header Connection '';
    proxy_http_version 1.1;
    proxy_read_timeout 180s;
    proxy_set_header Host $host;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header X-Forwarded-Proto $scheme;
    proxy_set_header X-Forwarded-By $remote_addr;

    proxy_pass http://service-pocketbase:8090;
  }

then now I can access it via https://api.xxxxx.com/v2/_/
Now I have /v1 (back-end using PHP), /v2 (back-end using Pocketbase), /v3 (back-end using pure Go), /v4 (back-end using Rust) etc hahaha. Nice :)
Again thank you @ganigeorgiev for Pocketbase.


Use Go cache in CI

Codecov Report
Patch and project coverage have no change.

Comparison is base (e940f49) 77.90% compared to head (38557f6) 77.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   77.90%   77.90%
=======================================
  Files          36       36
  Lines        3362     3362
=======================================
  Hits         2619     2619
  Misses        616      616
  Partials      127      127

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Adds the Feature: sidebar component

Overview
Adds a filterable set of categorized sample queries on the sidebar component
Demo
Optional. Screenshots, curl examples, etc.
Notes
Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.
Testing Instructions

Load the app
Check the left side of the app and see the sidebar component
Click on the samples.
Search for the particular sample you want to fire

The text inside the rows are not vertically aligned

The font is in the Sidebar component is different from the rest of the application.

Closing this as it is a duplicate of #136
Recommendations in the comments have been done in the above pull request


Allow classname as prop on table components

Realised that i could not add classnames to some table Components like tableHead, I think adding an optional classname prop to the components for extra styling would be lovely. Would love that. Open to even working with the team to accomplish that. Thank you.

This would enable the addition of more personal styling to table components. Noticed almost all the table components do not accept classnames as optional props

Relates to: #75


gonic: Fix build error

Add missing zlib
ZHF: #122042

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Thanks! Unsure how it built locally and when we merged?


Global change of HostPrivlegedName to HostPrivilegedName

This is just a minor spelling fix.
I can rebase on to master if that is preferred.

LGTM :+1:


NavigationLauncher with custom style map

Hello,
I just want to know if it is possible to change the style (for example to Satellite) when we are in navigation mode.
Thank you in advance.
Bye

Reply here: https://github.com/mapbox/mapbox-navigation-android/issues/2319


mute video when loaded

please how can I mute te video when loaded, until users taps on it before it unmutes?
How can I make the videos autoplay?

Hi.
The default setting is already set to Autoplay. So, You do not need to set it. and if you want to mute on the start of the video, Use this:
FlickManager? flickManager;

@override
  void initState() {
    super.initState();
    flickManager = FlickManager(
      videoPlayerController: VideoPlayerController.network("https://assets.mixkit.co/videos/preview/mixkit-spinning-around-the-earth-29351-large.mp4"),
    );
    flickManager!.flickControlManager!.mute();
  }

Hope this worked else feel free to open this issue.
@atishpaul Thanks.


Refereeing

Would be cool if we fix the names on markdown and have links to our various github repo next to our names on the list. Using markdown Would also give improved functionality to our project

Yes. any suggestion on how to achieve this?

we can proceed with this by switching to a markdown file format
by using a "[name](github url)" syntax we can have every contributor attach their various github account link to their name.
This would make this repo a reference point to check on the improvement of the various github profiles of the interns of this cohort

cc @tobisupreme @Omafovbe @oseunabiola @Succynice Can we switch from the text to markdown file so we can capture the GitHub link of each person.

Yes we can.
Do we ask contributors to update their names with their github profiles, or do we assign people to do all of that?

Will changing to markdown automatically include the GitHub user link for
those whose names have been included? For those contributing it's easier
for them to include their GitHub link.
On Wed, 17 Aug 2022, 09:34 Olúwásetèmi, @.***> wrote:

cc @tobisupreme https://github.com/tobisupreme @Omafovbe
https://github.com/Omafovbe @oseunabiola
https://github.com/oseunabiola @Succynice https://github.com/Succynice
Can we switch from the text to markdown file so we can capture the GitHub
link of each person.
—
Reply to this email directly, view it on GitHub
https://github.com/Oluwasetemi/altschool-opensource-names/issues/621#issuecomment-1217685206,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEXP2H7VOE3Q62ZBVZZ4JBLVZSP2TANCNFSM56T5GD2Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

It will not be automatically put, no.

We have to draft a post on slack to this effect which I think we can assign to @tobisupreme . Existing people with names in the repo can update name with GitHub link.
It will be another wave of PRs. Scared.

Please can we agree on a format for contributors to add their GitHub link
so we don't have different formats and someone has to be assigned to
correcting it eg. Omafovbe Imonikosaye - https://github.com/Omafovbe or
Omafovbe (https://github.com/Omafovbe)
On Wed, 17 Aug 2022, 10:29 Olúwásetèmi, @.***> wrote:

We have to draft a post on slack to this effect which I think we can
assign to @tobisupreme https://github.com/tobisupreme . Existing people
with names in the repo can update name with GitHub link.
It will be another wave of PRs. Scared.
—
Reply to this email directly, view it on GitHub
https://github.com/Oluwasetemi/altschool-opensource-names/issues/621#issuecomment-1217754108,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEXP2H64S6I5S7M3LQDB6ITVZSWI3ANCNFSM56T5GD2Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

We have [Name](GitHub Link).
This is my thought.

Yes. [Name](github link) so that the link is hyperlinked to the name. Clicking on it will lead to the user profile

@tobisupreme I don't think we have concluded on using markdown as against
text file.
On Wed, 17 Aug 2022, 10:58 Tobi Balogun, @.***> wrote:

Yes. [Name](github link) so that the link is hyperlinked to the name.
Clicking on it will lead to the user profile
—
Reply to this email directly, view it on GitHub
https://github.com/Oluwasetemi/altschool-opensource-names/issues/621#issuecomment-1217794148,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEXP2H7VMLKO44EDOED4KFTVZSZVVANCNFSM56T5GD2Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

We have to draft a post on slack to this effect which I think we can assign to @tobisupreme . Existing people with names in the repo can update name with GitHub link.
It will be another wave of PRs. Scared.

We also have to update the readme too 😅
Personally, I think that we should leave it at the names.txt

@tobisupreme I don't think we have concluded on using markdown as against
text file.
On Wed, 17 Aug 2022, 10:58 Tobi Balogun, @.***> wrote:

Yes. [Name](github link) so that the link is hyperlinked to the name.
Clicking on it will lead to the user profile
—
Reply to this email directly, view it on GitHub
https://github.com/Oluwasetemi/altschool-opensource-names/issues/621#issuecomment-1217794148,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEXP2H7VMLKO44EDOED4KFTVZSZVVANCNFSM56T5GD2Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

No we haven't. I'm merely sharing my thoughts too


Message Bubble

Not really an issue, but more of a question really. How can I make a chat message bubble like the one on iMessages? More precisely, how can I apply some style to the entire section? The bubble's width must depend on the text width and have a maximum.

Inside your UICollectionViewCell have a UIView as the background of the message bubble. Apply a corner radius to this view to make it more bubble like. Put a UILabel inside the UIView and lay it out with autolayout so that the leading or trailing edge of the UIView is >= some_padding of the UICollectionViewCell's leading or trailing edge. That way it'll adjust the width of the bubble manually. Do the height calculations manually inside the section controller based on the width supplied by the collectionContext. That's basically it.

Yes! That's why I ended up doing but without autolayout.
I thought that there was a way to use multiple cells to do this:

But maybe they actually do it! The top/bottom cell has top/bottom bordered radius and they all are padded with the same value!

Check out how I create bubbles composed of multiple cells in GitHawk as well.
https://github.com/GitHawkApp/GitHawk/blob/master/Classes/Issues/Comments/IssueCommentBaseCell.swift
Both single-cell and multi cell strategies are ok! Just go with what works best for you.
Sent with GitHawk

OMG thanks @rnystrom and @yusuftor ☺
Sent with GitHawk


embed_options in mimebundle is NoneType (error when calling chart.save in Altair to a PDF)

Having trouble interpreting the error message when calling chart.save to a PDF.
    chart.save(os.path.join(outputdir, title + ".pdf"), engine="vl-convert")
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/altair/vegalite/v5/api.py", line 1214, in save
    save(**kwds)
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/altair/utils/save.py", line 200, in save
    perform_save()
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/altair/utils/save.py", line 162, in perform_save
    mimebundle = spec_to_mimebundle(
                 ^^^^^^^^^^^^^^^^^^^
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/altair/utils/mimebundle.py", line 77, in spec_to_mimebundle
    embed_options = preprocess_embed_options(embed_options)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/local/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/site-packages/altair/utils/mimebundle.py", line 321, in preprocess_embed_options
    embed_options = embed_options.copy()
                    ^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'copy'

I have import vl_convert as vlc (although no other references to vlc in my code) and I've done pip install vl-convert-python but there's nothing in that trace that indicates it's dropped out of Altair into vl_convert. The Altair instructions are dead simple (https://altair-viz.github.io/user_guide/saving_charts.html) so I've clearly missed something.
Keeping you busy today!

Hey @jowens, you don't have to import vl_convert for this to work. This error is in Altair before it gets to invoking vl-convert.  Can you open an issue in the altair repo (https://github.com/altair-viz/altair) with a repro and the exact version of altair you're using?
I can't reproduce this with a simple test, and looking at the code in https://github.com/altair-viz/altair/blob/v5.2.0/altair/utils/mimebundle.py, it doesn't look like embed_options should ever be None when passed into preprocess_embed_options.
One quick thing to look at is, what's the result of?
import altair as alt
alt.renderers.options.get("embed_options", {})

Could you include this result in the Altair issue?

Hate to make your life harder, really I do.
print(alt.renderers.options.get("embed_options", {}))
vf.enable()
print(alt.renderers.options.get("embed_options", {}))

prints
{}
None

Oh wait that's vegafusion. That's not you.

I've disabled vf and everything works as expected.

Oh, that's really helpful!  I'll open a VegaFusion issue to avoid setting this to None.


DataFrame._data deprecation in pandas

Fixes test failure in upstream:
FAILED dask/dataframe/tseries/tests/test_resample.py::test_series_resample[frame-ohlc-5-h-left-right] - FutureWarning: DataFrame._data is deprecated and will be removed in a future version. Use public APIs instead.

Xref https://github.com/pandas-dev/pandas/pull/52003.

[x] Tests added / passed
[x] Passes pre-commit run --all-files

_mgr should be fine for now.
You could iterate over all columns of the DataFrame to collect the arrays, but this is obviously slower then accessing them directly. So not really a good idea if performance is relevant here. I guess hash_pandas_object is not what you are looking for?

_mgr should be fine for now.

Sounds good 👍

I guess hash_pandas_object is not what you are looking for?

Ah, good point. If there was a utility in pandas that we could offload this to, and there weren't any serious performance regressions, we probably would. I'll open a separate issue for this

xref https://github.com/dask/dask/issues/10083


Add a "Quick edit" option to change the class name directly in the Diagram Editor

Added with checkin 98df5d27b74f9c1fbd943a41e0d272e7bd316e3f


0.12.0-final release tag?

Would it be possible to get 0.12.0-final tagged? cpp-netlib-0.12.0-rc1 is a dependency of osquery 1.7.2, but usually Homebrew requires actual release tags, not release candidate tags, to be used for the stable specs. Are there any show stoppers preventing a 0.12.0-final release tag? Thanks!
https://github.com/Homebrew/homebrew/pull/50362#issuecomment-200870340
https://github.com/facebook/osquery/pull/1918
https://github.com/facebook/osquery/issues/1920

I'm going to tidy up the master branch and create an -rc2 which should also be -final after a quick round of testing/qualification.

Tagged cpp-netlib-0.12.0-rc2, which should turn into cpp-netlib-0.12.0-final unless things break unexpectedly. See https://github.com/cpp-netlib/cpp-netlib/tree/cpp-netlib-0.12.0-rc2

@deanberris Thanks: https://github.com/Homebrew/homebrew/pull/50375


Simulation stuck in LL/SC livelock when using ARM+O3 CPUs with MESI_Three_Level and MESI_Two_Level protocols

Describe the bug
A multi-threaded application using pthread_barrier_wait to synchronize all threads results in simulation hanging forever when the core count is sufficiently high (>= 8).
Further inspection (with --debug-flags=Exec) shows that the root cause is a LL/SC livelock.
There was an attempt to fix this issue for MESI_Two_Level here, but never got merged.
Affects version
develop head (37ca944)
gem5 Modifications
Apply the following patch:
diff --git a/src/mem/ruby/protocol/MESI_Three_Level-msg.sm b/src/mem/ruby/protocol/MESI_Three_Level-msg.sm
index 740011ac83..f0159af64d 100644
--- a/src/mem/ruby/protocol/MESI_Three_Level-msg.sm
+++ b/src/mem/ruby/protocol/MESI_Three_Level-msg.sm
@@ -83,6 +83,9 @@ structure(CoherenceMsg, desc="...", interface="Message") {
   bool functionalRead(Packet *pkt) {
     // Valid data block is only present in message with following types
     if (Class == CoherenceClass:PUTX ||
+        Class == CoherenceClass:PUTX_COPY ||
+        Class == CoherenceClass:INV_DATA ||
+        Class == CoherenceClass:DATA ||
         Class == CoherenceClass:DATA_EXCLUSIVE) {
         return testAndRead(addr, DataBlk, pkt);
     }

It (partially) fixes functional reads in MESI_Three_Level, a requirement to run the test in SE mode.
It is enough for some simple testing, but it might still hit a functional read failure.
To Reproduce

Apply the patch provided above.
Compile gem5 with scons build/ARM_MESI_Three_Level/gem5.opt
Download aarch64 tool-chain from here (don't use newer versions because they rely on clone3 syscall, which is not supported in SE mode).
Save the following code as llsc.cpp:

#include <iostream>
#include <pthread.h>

constexpr unsigned iteration_count = 1000;
constexpr unsigned thread_count = 8;
pthread_barrier_t barrier{};

void *thread_fn(void *id) {
  for (unsigned i = 0; i < iteration_count; ++i) {
    std::cout << "thread_" + std::to_string(*static_cast<unsigned *>(id)) +
                     ": begin of iteration " + std::to_string(i) + "\n";
    pthread_barrier_wait(&barrier);
    std::cout << "thread_" + std::to_string(*static_cast<unsigned *>(id)) +
                     ": between pthread_barriers\n";
    pthread_barrier_wait(&barrier);
    std::cout << "thread_" + std::to_string(*static_cast<unsigned *>(id)) +
                     ": end of iteration " + std::to_string(i) + "\n";
  }
  return nullptr;
}

int main(int, char **) {
  pthread_t ts[thread_count - 1];
  unsigned ids[thread_count];
  pthread_barrier_init(&barrier, nullptr, thread_count);
  for (unsigned i = 0; i < thread_count - 1; ++i) {
    ids[i + 1] = i + 1;
    pthread_create(&ts[i], nullptr, &thread_fn,
                   static_cast<void *>(&ids[i + 1]));
  }
  ids[0] = 0;
  std::cout << "Start test\n";
  thread_fn(static_cast<void *>(&ids[0]));
  std::cout << "End test\n";
  for (unsigned i = 0; i < thread_count - 1; ++i) {
    pthread_join(ts[i], nullptr);
  }
  pthread_barrier_destroy(&barrier);
  return 0;
}

Compile llsc.cpp with aarch64-linux-g++ llsc.cpp -static -O3 -pthread -o llsc
Execute the simulation with build/ARM_MESI_Three_Level/gem5.opt /workspace/gem5/configs/deprecated/example/se.py --cpu-type DerivO3CPU --ruby -n 8 --cmd llsc
The same test can be done with MESI_Two_Level.

Terminal Output
Eventually, the simulation will stop printing anything, and after some time it will print a warning about "consecutive store conditional failures" like this:
thread_3: begin of iteration 47
thread_5: begin of iteration 47
thread_7: begin of iteration 47
thread_0: begin of iteration 47
thread_2: begin of iteration 47
thread_6: begin of iteration 47
thread_4: begin of iteration 47
thread_1: begin of iteration 47
thread_0: between pthread_barriers
thread_3: between pthread_barriers
thread_6: between pthread_barriers
thread_2: between pthread_barriers
thread_4: between pthread_barriers
thread_1: between pthread_barriers
thread_7: between pthread_barriers
thread_5: between pthread_barriers
thread_0: end of iteration 47
thread_7: end of iteration 47
thread_3: end of iteration 47
thread_5: end of iteration 47
thread_2: end of iteration 47
thread_6: end of iteration 47
thread_1: end of iteration 47
src/arch/arm/isa.cc:1824: warn: context 4: 100000 consecutive store conditional failures
src/arch/arm/isa.cc:1824: warn: context 3: 100000 consecutive store conditional failures

Expected behavior
1000 iterations successfully executed and the simulation finished with the end of the last active thread context.
Host Operating System
Running docker with image built using the following Dockerfile:
FROM ubuntu:24.04
RUN DEBIAN_FRONTEND=noninteractive apt -y update && \
    DEBIAN_FRONTEND=noninteractive apt -y upgrade && \
    DEBIAN_FRONTEND=noninteractive apt -y install \
    build-essential scons python3-dev git pre-commit zlib1g zlib1g-dev \
    libprotobuf-dev protobuf-compiler libprotoc-dev libgoogle-perftools-dev \
    libboost-all-dev libhdf5-serial-dev python3-pydot python3-venv python3-tk \
    mypy m4 libcapstone-dev libpng-dev libelf-dev pkg-config wget cmake doxygen \
    python3-pip python3-matplotlib python3-numpy python3-ujson
# Setup latest version of ARM's cross-compiler that does not use clone3 syscall
RUN cd /opt && \
    wget https://toolchains.bootlin.com/downloads/releases/toolchains/aarch64/tarballs/aarch64--uclibc--stable-2022.08-1.tar.bz2 && \
    tar xf aarch64--uclibc--stable-2022.08-1.tar.bz2 && \
    mv aarch64--uclibc--stable-2022.08-1 aarch64 && \
    for b in addr2line ar as c++filt cpp elfedit g++ gcc gcc-ar gcc-nm gcc-ranlib gcov gcov-dump gcov-tool gprof ld ld.bfd nm objcopy objdump ranlib readelf size strings strip; \
    do update-alternatives --install /usr/bin/aarch64-linux-${b} aarch64-linux-${b} /opt/aarch64/bin/aarch64-linux-${b} 30; done
ENV XDG_CACHE_HOME=/tmp/

Host ISA
ARM
Compiler used
g++ (Ubuntu 13.2.0-23ubuntu4) 13.2.0
Additional information
I created a local fix for MESI_Two_Level and I'm currently working on a similar fix for MESI_Three_Level. If no one is working on this issue (or planning to work on this issue), I can open a PR with my fixes.

Fix merged, closing the issue.


Fixes concaveshape not selecting in viewport

This PR resolves the issue of ConcaveShapes not being selectable in the Viewport.
Partially addresses: #32177

Looks fine. We might get some performance degradation because the collision lines are not cached like get_debug_mesh is. But I would merge as-is and the caching can be added later if we see it's needed.

get_debug_mesh() returns an ArrayMesh, generated from get_debug_mesh()... Is there anyway to simply get the points from the ArrayMesh?

Looks fine. We might get some performance degradation because the collision lines are not cached like get_debug_mesh is. But I would merge as-is and the caching can be added later if we see it's needed.

get_debug_mesh() returns an ArrayMesh, generated from get_debug_mesh()... Is there anyway to simply get the points from the ArrayMesh?

Yes, you could theoretically et the line points from the ArrayMesh but I think it's a safer option to cache the lines and the mesh separately. This way we don't depend on the specific ArrayMesh implementation.

Thanks!


Brew fetch while installing packages?

It might be worth considering fetching packages into a local cache when downloads' take a long time. I'm not sure how feasible this is or if this has been considered before. Just wanted to throw the idea out there. Thanks!
I think bundler does this?

They are already in Homebrew's local cache :wink:.


Option to autogenerate swagger

It would be nice to have the option to auto-generate an OpenAPI (swagger) definition on route mounting step and expose it at some configurable path with default value /openapi

You have this middleware https://github.com/fliptoo/swagger-express to generate the swagger-ui with express ;).

see #76


PRODTASKS-305: PNC sources not found

retest this please

retest this please

@jdcasey Examining the CI output I am seeing
[INFO] Downloading: http://indy:8080/api/group/public/com/redhat/red/build/kojiji/2.0-SNAPSHOT/maven-metadata.xml

[WARNING] Checksum validation failed, expected <?xml but is 11860d522f3dc21252f064c4bf46316950be2549 for http://indy:8080/api/group/public/com/redhat/red/build/kojiji/2.0-SNAPSHOT/maven-metadata.xml
[WARNING] Could not validate integrity of download from http://indy:8080/api/group/public/com/redhat/red/build/kojiji/2.0-SNAPSHOT/maven-metadata.xml: Checksum validation failed, expected <?xml but is 11860d522f3dc21252f064c4bf46316950be2549
[WARNING] Checksum validation failed, expected <?xml but is 11860d522f3dc21252f064c4bf46316950be2549 for http://indy:8080/api/group/public/com/redhat/red/build/kojiji/2.0-SNAPSHOT/maven-metadata.xml

Unfortunately I am unable to examine the Indy instance - it doesn't appear to be fetching the new SNAPSHOTs from sonatype - a new SNAPSHOT of kojij has been deployed to https://oss.sonatype.org/content/repositories/snapshots/com/redhat/red/build/kojiji/2.0-SNAPSHOT/maven-metadata.xml

retest this please

retest this please


API Interceptor: Ability to return the error message set by an interceptor

Added changes to enable and interceptor to send back an error message in response.
We will send that message back to the user.
Also added a new test to check the error message set by an interceptor.
https://github.com/rancher/rancher/issues/7773

@cjellick please review

LGTM


Upgrade Ruby to 2.6.1

Upgrade Ruby to 2.6.1, see commits for more details.

Given these changes are dependant on each other, for example, I would guess that the Dockerfile won't build on 2d7b360014f6f6873f9164e52435fd2c70cb9129 as the Ruby version won't match the .ruby-version file, it might be neater to have a single commit, but I'm fine with this as well.


Exposing Type on Class

This addresses issue 221.
I added a Type property to Class to get the Type representation of a class.

Hi @michaelaird, thanks for contributing!
I like this idea, but I think adding a Type property to Class can be a bit confusing from an API perspective. A cleaner solution might be to support casting a Class as Type via operator overloading.. I'll give it a try using your PR as a starting point.

I like your idea as well. Let me know if you’d like me to take a second
crack at it and I can try to send a new PR later today.
On Sun, Oct 15, 2017 at 10:01 AM Fredrik Hagnelius<EMAIL_ADDRESS>wrote:

Hi @michaelaird https://github.com/michaelaird, thanks for contributing!
I like this idea, but I think adding a Type property to Class can be a bit
confusing from an API perspective. A cleaner solution might be to support
casting a Class as Type via operator overloading.. I'll give it a try using
your PR as a starting point.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/frhagn/Typewriter/pull/225#issuecomment-336713599,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANX6WyU8q4rXVXfjB50KYksnL8aFDNSks5sshBQgaJpZM4P5L5C
.


updates for libc6++ on pi 0, node 10

updating to handle downlevel libc6++ on jessie

Warnings

:warning:

Please include an updated CHANGELOG.md file.This way we can keep track of all the contributions.

  Generated by :no_entry_sign: dangerJS

Hi Sam, it seems this branch has conflicts.

we need this

This does not fail when run locally

Will look into all the failing Travis builds tomorrow. Need to be fixed before I can release the next master (Jan 1st).

Cool. I pulled latest develop, did npm install, and ran the two test suites. Both worked
The failure is some timeout problem with weather test cases.

See: https://github.com/MichMich/MagicMirror/issues/1840


Highlight colors for Simple Objects do not match the new design

Steps to Reproduce

Open Ketcher
Add Simple objects on canvas (e.g. Shape Ellips, Shape Rectangle, Shape Line)
Add Benzene ring and any atoms
Select all and look at selection colors

Actual behavior
Highlight colors for Simple Objects do not match the new design
Expected behavior
Highlight colors for Simple Objects is match the new design
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.11.0-rc.1

The color is lighter than that of templates and atoms.

When selecting and hovering over an Ellipse or Rectangle, the inner area is highlighted.

Points for changing the scale are filled with highlights, which makes them less noticeable.

When selecting and hovering over a word, the word is completely filled and the text disappears


[LB-101] Fix Nested BugLocalizer Initialization

Overview
This PR fixes an issue observed when hitting the /initialization endpoint: The BugLocalization class would be initialized on each source code file in a repository. Additionally fixes encoding error found when creating embeddings for preprocessed source code files.
Changes Made

routes.py: Removed unnecessary bug_localizer object
preprocess.py: Added init function
preprocess_source_code.py: Added encoding option for UTF-8

Check failing due to the embedding unit test - could force push since the tests are no longer accurate.


Changing return type to overcome PHPStan and other analysis problems …

…in other projects

@choks87 thanks a lot, i think this is an inconsistency that we forgot about, since the KafkaProducerInterface is "new" :smile_cat:


Issue with Importing Configurations with Dependencies or Two-Step Process in frodo

Frodo CLI Version
CLI: v2.0.1-0
Library: v2.0.1-1
Node: v20.11.1

Issue Description
I am encountering difficulties with importing configurations using frodo-cli when the configurations have dependencies or require a two-step process. The tool does not handle these cases correctly.
Example
When exporting my email service configuration with the command:
bash
frodo service export -i email my-tenant
I receive the following export data:
json
{
  "meta": {
    "exportDate": "2024-08-03T02:03:10.608Z",
    "exportTool": "frodo",
    "exportToolVersion": "v2.0.1-1 [v20.11.1]",
    "exportedBy"<EMAIL_ADDRESS>    "origin": "https://openam-my-tenant.forgeblocks.com/am",
    "originAmVersion": "7.6.0"
  },
  "service": {
    "email": {
      "_id": "",
      "_type": {
        "_id": "email",
        "collection": false,
        "name": "Email Service"
      },
      "emailAddressAttribute": "mail",
      "emailImplClassName": "org.forgerock.openam.services.email.MailServerImpl",
      "emailRateLimitSeconds": 1,
      "from"<EMAIL_ADDRESS>      "location": "alpha",
      "message": "con",
      "nextDescendents": [
        {
          "_id": "smtp",
          "_type": {
            "_id": "smtpTransports",
            "collection": true,
            "name": "SMTP"
          },
          "emailImplClassName": "org.forgerock.openam.services.email.MailServerImpl",
          "hostname": "smtp.mail.com",
          "password": null,
          "port": 465,
          "sslState": "SSL",
          "username"<EMAIL_ADDRESS>        }
      ],
      "port": 465,
      "sslState": "SSL",
      "subject": "sub",
      "transportType": "smtp"
    }
  }
}

When attempting to import this configuration using:
frodo service import -A my-tenant-profile
I encounter the following error:
Error importing services
Error putting realm full service configs
Error putting realm full service config email
HTTP client error
Code: ERR_BAD_REQUEST
Status: 400
Reason: Bad Request
Message: Data validation failed for the attribute, Transport Type
"If I delete the transportType attribute, the import will work."
The import process fails with a 400 Bad Request error, indicating a data validation issue related to the "Transport Type" attribute. This issue occurs with configurations that have dependencies or require a multi-step import process

I was able to reproduce this.

@spirit69110s , I confirmed the issue and will be working on a remedy.

@spirit69110s this issue has been fixed in Frodo CLI 2.0.1. Please let me know if this still does not work for you.

Thank you for your assistance. I appreciate it , it is working now


Kubernetes kubectl backend

Support for a backend using the kubectl executable.
Requires:

The executable kubectl must on both the agent and the server.

Supports:

Environment variables for configuration.
Network isolation and internet access.
Configuration control through environment variables.
Container features:commands: [string],
image: string,
environment: {},
pull: bool,
detached: bool,
privileged: bool,
alias: string,
dns: [string],
dnssearch: [string],

Does not support:

Local volumes.
Multiple volumes.
Volumes on detached steps (or services), without custom PVC class.
Configuration control through CLI commands.

See readme in backend folder for more help.

@LamaAni Awesome work again thank you very much. Super interesting to see this approach of using kubectl. Why did you prefer using kubectl instead of the go-api or some otherway? Did you had a look on #552 and if so is there a difference to that approach?
It contains some pretty nice changes apart from the backend, but I would like to separate some of them as they can probably be merged independently from this PR. Could you do that, or should I try that and link you.

@anbraten TBH, I have not looked hard at that PR. But I was not going to "overtake" someones draft. Seemed poor manners.
As for the other changes. Yea. we can separate them. Feel free to do that or I'll do that once I solve some small issues I have at the moment.
I wrote this because I needed a kubernetes backend more quickly with full single pipeline network isolation and proper resource cleanup (as dose exist in docker, due to my clients security concerns) where multiple players can only access their "own run" and the internal company network or the internet. You will also see in my implementation that I prefer a more "server side" configuration approach, where the configuration is blocked on the Kubernetes side (see the README.md file for envs and how to configure the network pipeline isolation). This allows me as admin to clear the CI against the network and code security requirements and SLA.
As for the kubectl question :)
I general, I would prefer the go native client, but it has some issues I know from another o.s. project I have (python client). Mainly, the application of a yaml configuration, e.g. you cannot just configure a yaml and expect the native client to execute it as you would with,
kubectl apply -f [file]

This means the configuration would become very hard and would require the handling of multiple resource types (Not to mention inflate the code).
For future use I wrote the "client" library in such a way that a future PR may replace it with a native client, one that accepts yaml. You can find a python example of such a clientI wrote, that accepts yaml, here.
If anyone else is willing to write client that uses the go native client as a backend I am game! You can replace the kubectl with something more native. In the next two-three pushes I am gonna remove all dependency on kubectl from the other files and achieve client.go isolation, which will allow this.
I hope that helps :) and you guys would consider this as a basis.

please resolve conflicts :)

please resolve conflicts :)

Nice!

@6543 Updated. See another fix, for errors in new PR.

Codecov Report

Merging #784 (e9c0114) into master (90dcc77) will increase coverage by 0.02%.
The diff coverage is 100.00%.

:exclamation: Current head e9c0114 differs from pull request most recent head 14a70c4. Consider uploading reports for the commit 14a70c4 to get more accurate results

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
+ Coverage   51.80%   51.82%   +0.02%
==========================================
  Files          80       80
  Lines        6050     6053       +3
==========================================
+ Hits         3134     3137       +3
  Misses       2737     2737
  Partials      179      179

Impacted Files
Coverage Δ

server/shared/procBuilder.go
86.34% <100.00%> (+0.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90dcc77...14a70c4. Read the comment docs.

https://github.com/woodpecker-ci/woodpecker/pull/552 is prevered ... but some snipeds from here should be moved over

Hi, well. I would like to keep this since I am still using this controller. I can keep it in my branch or keep this as legacy. The current implementation works well.

in this patch here are some bit's worth porting to the native implementation!
so as long as I did not have looked through this completely I'll keep it open, after I did so I'll notify via a comment here ...


Feature request: static file serving support

From #97

Nginx serves static files

Now that can be (IMO) a more interesting feature request for Granian.

I think it would be very useful to have some sort of static file serving functionality.
Either something like nginx's try_files where granian could first check a folder for a match, and if not, fall back to the RSGI/ASGI/WSGI app, or maybe just support mapping URL paths to folders.
A plus would be if granian could optionally serve those files with far-future expiry headers. nginx does the following when using expires max:

The max parameter sets “Expires” to the value “Thu, 31 Dec 2037 23:55:55 GMT”, and “Cache-Control” to 10 years.

From https://nginx.org/en/docs/http/ngx_http_headers_module.html
This is the only feature which is missing for me to make granian a one-stop solution to serve everything with a single ingress, no sidecars or similar.
(I'd be willing to work on this with some guidance, or fund it if that's helpful.)

I think this would be a useful feature for a lot of deployments out there, I definitely agree this should be implemented in the near future. I don't think this will be in time for 1.7, but possibly we can target 1.8.
In terms of implementation, here are some notes I can think of at the moment:

we would need 2 additional configuration parameters, one for the folder path to serve, one for the URL path to expose that folder to (might be smth like --static-path-mount my_app/static --static-patch-route /static
this potentially affects only the build_service! macro here https://github.com/emmett-framework/granian/blob/a6cfc2f1f9d94ae7f57d6400cfee071eac328aa5/src/workers.rs#L169-L180 thus the best implementation would probably be to add a new macro and switch which macro gets used by the accept loop based on wether a static path is defined (on worker boot)
the main attention point should be on the security of that endpoint: the implementation should do some type of checks to avoid exploiting that path going outside of the target folder (eg: avoid /static/../../../some_file_in_root_path)
the expiration can probably be an additional param, I don't see any particular difficulties there


User Administration

I miss there the admin access, which could create, edit or delete each user.

Actually it's usable just since 694a6317fa20a56f1657069cfda154d57be9545d


pkg/blobserver/localdisk: staticcheck

Closing this, see my comment here:

https://github.com/perkeep/perkeep/pull/1405#issuecomment-894727096


Set window type hint?

what I want
I want my window to have a specific window type. It seems to be impossible to accomplish with monomer yet.
why it is good
Window managers will draw windows differently depending on their window type. For example, i3 will draw dialog windows as floating and other types of windows as tiled. Big difference!
how to get it
The way to have it may be similar to #30?…

Hi @kindaro!
Sorry for the delay. Does the SDL_WINDOW_POPUP_MENU flag listed here do what you need?
If it is something supported by SDL2 I can expose it, within reasonable limits (SDL2 is a really large library).

I'll close the issue for the time being. Please re-open if needed. Thanks!

Thank you Francisco. An onset of overwhelming sadness put me away from checking my inbox for a while so I did not see your answer. I am recovering and hopefully soon I could get back to my Monomer projects.
How can I detect if this flag does what I need? How do I pass it to Monomer? I am sorry if this is a dumb question. Please point me to the relevant haddock if there is one.
Judging from the name alone, it should work.
I cannot re-open this issue, no such button is offered anywhere I can see.

@kindaro I just re-opened the issue. I'll add the functionality and let you know.


On the fly request body gzipping is broken by utf-8 default encoding

Expected behavior
Given API under test requires gzipped json body,
And I created HTTPSampler with a JSR223 preprocessor
When I run tests
Then server returns 200 reponse code.
Actual behavior
Then server returns 500 code, and says 'not in gzip format'
Steps to reproduce the problem
Was broken in 7450e4b0497c9a37c44852912e8d3dc2d0ee644e(fix: use UTF-8 as a default encoding in HTTP sampler)
JMeter Version
5.6.1
Java Version
openjdk 17.0.8 2023-07-18
OS Version
Debian GNU/Linux 12 (bookworm)

Please provide a reproducer. What are you trying to achieve?

The code in the sample is
GZIPOutputStream gzip = new GZIPOutputStream(out);
gzip.write(requestBody);
gzip.close();

sampler.getArguments().getArgument(0).setValue(out.toString(0));

I am afraid this is not going to work as it attempts using String where byte[] should be used.
Note .toString(0) deprecated method.
As a workaround, you might try iso-8859-1 encoding. That encoding is bytesafe (== it converts byte -> char -> byte without losing contents), however, in any case it would be a workaround only, and the proper solution would be to support byte[] in HTTPArgument.


Fix nav links in dark mode

Navbar links are not clearly visible in dark mode, and they become smaller too.

@abhijeet007rocks8 Please assign me this issue.


radare2-cutter: 1.7.1 -> 1.7.2

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: radare2-cutter
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: radare2-cutter
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/c3rarlbspamrz6s22kcizlij1s835b9q-radare2-cutter-1.7.2
shrinking /nix/store/c3rarlbspamrz6s22kcizlij1s835b9q-radare2-cutter-1.7.2/bin/Cutter
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c3rarlbspamrz6s22kcizlij1s835b9q-radare2-cutter-1.7.2/bin
patching script interpreter paths in /nix/store/c3rarlbspamrz6s22kcizlij1s835b9q-radare2-cutter-1.7.2
checking for references to /build in /nix/store/c3rarlbspamrz6s22kcizlij1s835b9q-radare2-cutter-1.7.2...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/c3rarlbspamrz6s22kcizlij1s835b9q-radare2-cutter-1.7.2

Success on aarch64-linux (full log)
Attempted: radare2-cutter
Partial log (click to expand)
shrinking RPATHs of ELF executables and libraries in /nix/store/r0ldscshm6ifr4pg3458p3hhva0nj5gs-radare2-cutter-1.7.2
shrinking /nix/store/r0ldscshm6ifr4pg3458p3hhva0nj5gs-radare2-cutter-1.7.2/bin/Cutter
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r0ldscshm6ifr4pg3458p3hhva0nj5gs-radare2-cutter-1.7.2/bin
patching script interpreter paths in /nix/store/r0ldscshm6ifr4pg3458p3hhva0nj5gs-radare2-cutter-1.7.2
checking for references to /build in /nix/store/r0ldscshm6ifr4pg3458p3hhva0nj5gs-radare2-cutter-1.7.2...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/r0ldscshm6ifr4pg3458p3hhva0nj5gs-radare2-cutter-1.7.2


Missing sobol icons

These are the Icons that are outstanding in Sobol that didn't have good alternatives in feather.
I simply took them from material and font-awesome and put them here. I would suggest this be a very temporary solution and that we should remake/tweak them. (Especially the font-awesome ones cause their sizing is weird.
@btn0s let me know if you have any concerns with going this route while you are working on making permanent replacements.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3c64e93). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             master     #1   +/-   ##
=======================================
  Coverage          ?   100%
=======================================
  Files             ?      5
  Lines             ?     34
  Branches          ?      3
=======================================
  Hits              ?     34
  Misses            ?      0
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c64e93...3076732. Read the comment docs.


[Fix #10506] Fix an error for Style/RaiseArgs

Fixes #10506.
This PR fixes an error for Style/RaiseArgs when raise with new method without receiver.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


RS-119: Optimal Image Storage Solutions for ROS-Based Computer Vision

New blog post about integrating ReductStore with ROS for robotic applications.

@atimin I made quite some changes to the ROS demo repo and blog for your review.


Waterbulter - S3 - Revisions broken

Purpose:
SVCS-314
Currently S3 revisions always download the latest version.
This PR fixes that.
Changes:
Updated  waterbutler/providers/s3/provider.py def download accept arg revision instead of version
Updated  tests/providers/s3/test_provider.py def test_download_version use are revision instead of version
Side effects
None
[#SVCS-314]

Coverage remained the same at 75.731% when pulling c484df55d3807c1296c7e91f7dacf4893805e317 on TomBaxter:feature/svcs-314 into 2c5d8c3d30772840436ad20fad95d236b7f55f3a on CenterForOpenScience:develop.

Coverage remained the same at 75.731% when pulling 26a0910f3f22d2c919adc75ff58f1f068eda650e on TomBaxter:feature/svcs-314 into 425a3296014126931847d466b77673716516e2a7 on CenterForOpenScience:develop.

Coverage remained the same at 89.118% when pulling 683eafdc0279af1af015590d6c90cd06f36ade4d on TomBaxter:feature/svcs-314 into ba5573122292d5baa4d62635cab773278e2ee876 on CenterForOpenScience:develop.

@cslzchen Updated changes section with reference to the call that uses revision instead of version.

Lovely!  Moving to RTM.


Setup pre-commit hook with lint-staged and tests

Adds a couple of npm scripts for linting and sets up pre-commit for lint-staged and tests.

Looks like a duplicate of #15. Either should be fine. This doesn't add prettier though.


Fixing the way session data is mocked for different cases

Fixing the way session data is mocked for different cases

CI: No security warnings found


Remove license section from README

Description
This PR removes the License section from the main README.md, since we already have a LICENSE file and a CITATION.cff file (both recognized by GitHub frontend/metadata, as well as Zenodo when a release is made).

Related issues:

#11

Instructions to review the pull request

Check that CHANGELOG.md has been updated if necessary

Review online by checking the bottom of the README on this branch.

Thanks for the review!


Ak delete code not being ported from picard

As per internal discussions, we're removing the illumina package from hellbender's scope (for now at least) so I deleted all those classes.
Also, for the following tools I wasn't able to get enough userbase/usecases so they are going away too.
ScatterIntervalsByNs
BaitDesigner
BamIndexStats
CheckTerminatorBlock
ConvertSequencingArtifactToOxoG
ExtractSequences
FifoBuffer
MarkDuplicatesWithMateCigar
UpdateVcfSequenceDictionary
VcfFormatConverter
ViewSam

@lbergelson please review

@akiezun I removed a few more things.  Up to you where you think AdapterPair and the newly extracted IlluminaAdapatorPair should live.

I don't see anything else that can be deleted along with these.  I think that coveralls isn't reporting coverage today, so don't wait on it.

Coverage remained the same at 71.42% when pulling 4c7a7f968ba7f5f790d7f186a51869584468b4be on ak_delete_code_not_being_ported_from_picard into 0cd1c9a886be886ea81d46cdfe0bbd54e16edfd0 on master.

Coverage decreased (-1.17%) to 71.43% when pulling 159d65eddf85916fc7f9be6783e88bd94ce7a25f on ak_delete_code_not_being_ported_from_picard into 0cd1c9a886be886ea81d46cdfe0bbd54e16edfd0 on master.

Coverage decreased (-1.21%) to 71.43% when pulling 0795e105b3f15fa21aab748d9118c1072598e403 on ak_delete_code_not_being_ported_from_picard into 758f3969522676cc49e9109266b702dc3a05329d on master.

Coverage decreased (-1.17%) to 71.57% when pulling 99d3d34ec907ab396e3dca54e1374de8da07164e on ak_delete_code_not_being_ported_from_picard into 55661c1ee94659fc4a43a088302b306de7704f17 on master.


Add a CI server

drone.io is free for open source projects.

https://travis-ci.org/ is also a popular site for open source.

:+1: Will do, especially once I get more tests in place. There's some refactoring that has to happen first (unless I want to rewrite the tests later...) which will happen as soon as I get my feet back under me.

+1

Also looking into integrating https://coveralls.io

Okay, using Travis CI. Thanks for the suggestion @groob!


Crash when editing markdown that contains lots of code span backticks

I don't exactly have a minimal repro case for this yet, And I've seen it with both even and off numbers of backticks in the text. But it seems to be related to code spans cross paragraph boundaries... maybe.
I have a branch that reproduces the crash here: https://github.com/MohamedRejeb/compose-rich-editor/pull/442

Thanks for reporting this, I'm checking it.


Update Raiffeisen Bank Serbia image

Hi,
This PR just updates the Raiffeisen Bank Serbia image since they updated their system/UI.
Unfortunately, they didn't update the password rules.
Best regards.

Thank you for the contribution!


feat: Add Subito theme to catalog app

📋 Changes

Replace The legacy LBC theme with subito new theme and update the color visibility so that each theme use its own colors
🤔 Context
Subito has finished building their theme
📸 Screenshots

🗒 Other info

Yep we don't test it anymore in Spark, it's not yet removed in Polaris though 👍


Add the French translation

Damn that took me a lot of time!
I start from the principle that improvements can be done to this traduction and that it's not perfect (but almost 😏). By the way, I will improve it along the time and make updates to follow your book's ones.

Lovely. You also want to add 'fr' to LANGS.md in the top directory.

And feel free to add yourself here: https://github.com/bagder/http3-explained/blob/master/HOWTO-TRANSLATE.md#main-translators

For the LANGS.md file, I put French in the alphabetical order (to explain why it's in second)


Management API needs building

Currently we don't have a management API of any kind, which makes it pretty hard to conceptualize how to use identity-manager-sts as a user. Operations we need to support are:

Creation and management of issuers, including claim mappings
Binding of issuers to tenants/directories (see #23)
Minting of persistent tokens (see #24)

In general, an API pattern that uses at most one UUID for a resource is desirable. For example:
/issuers                 # create/list issuers
/issuers/{uuid}          # get/update/delete issuer
/issuers/{uuid}/bindings # create/list issuer bindings
/bindings/{uuid}         # get/update/delete binding

Closed with #33.


Update Set-OwaMailboxPolicy.md

https://github.com/MicrosoftDocs/office-docs-powershell/issues/4322

Docs Build status updates of commit 74b05e1:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 74b05e1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/client-access/Set-OwaMailboxPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 6356d9b:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 6356d9b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/client-access/Set-OwaMailboxPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 7b39e85:
:clock10: Full build: the average full build time is 11 min(s) 47 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 7b39e85:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/client-access/Set-OwaMailboxPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Android][iOS][Dev-tool] Vue.mixin cannot work

I create a index.js for mixins and import it in entry.js, It can work on Web, but it cannot work on IOS and Android (use Weex Playground).
//index.js
export default {   methods: {     test () {       return 'mixins'     }   } }
//entry.js
import Vue from 'vue'
import mix from '@/mixins/index'
import weex from 'weex-vue-render'
Vue.mixin(mix)
weex.init(Vue)
//HelloWorld.vue
<template>
<text class="message">{{test()}}</text>
</template>

Please follow the issue template and provide your runnable demo.
I will just close the issue, feel free to reopen it with your demo.

me too


ava performance

The ava dataset does not exceed 16.03 mAP. How can you achieve 21.3 mAP?

The ava dataset does not exceed 16.03 mAP. How can you achieve 21.3 mAP?

I want to ask you about where I can find these two files.
data/ava/ava_video_resolution_stats.csv  &data/ava/ava_dense_proposals_train.FAIR.recall_93.9.pkl
Thank you.


Charm start

Added functionality and unit tests to get the charm to start with monogdb running with a single unit in a replicaset.
Note there aren't capabilities for robust config options and passwords as these will be done in the following commits after the spec document is generated.

LGTM, let's get merged and move on to the next PR :rocket:


Update StrBuilder.java to be in line with changes proposed in TEXT-234

fixed documentation of setNewLineText, getNewLineText and appendNewLine to reflect the proposed changes in commons-text

@TobiasKiecker
Thank you for your PR.
-1: See my comments in your other PR. If you want to update the docs here, feel free to do the same as I did in TEXT.


Run SonarCloud only on pull requests to master

Run SonarCloud less often to reduce build times for normal CI builds.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Kalyan-Alamuru sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


home-assistant: pin the 'astral' dependency version

Motivation for this change
https://hydra.nixos.org/build/122651265
hass doesn't support Astral 2.x, there is a long standing bug report open.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build home-assistant


fix: uninstall scripts

Problem

pip uninstall is not executed and the startup process stops at that line.
cuDNN package installation check is always false.

Solution
Specify a string instead an array to the launch.run().
If an an array is specified, a python shell will start.
launch.is_installed() cannot check pip package names, so use try and version().

Brilliant, I wasn't aware of this behaviour (If an an array is specified, a Python shell will start.)
I'll test it now, and hopefully, this will help a lot of folks with install issues.

Good catch!


Allows viewing event log and sending emails to end users when samples are scanned

Not the prettiest, but seems functional.  There is no warning or confirmation when you send emails, so be careful to fill out the form completely for now.

This seems good, haz screenshot by chance? Travis looks like it got angry about a change on a route.

@AmandaBirmingham, since you're working on the scanning page in parallel right now, would it be possible to do a review here?
On slack, @dhakim87 commented that it may be good to require a technician click a confirmation button before sending the email, or to at least present the content of the email to the technician. I'm not sure what's best here, curious about thoughts

Review with Dom and Kat:

Based on sample status, autofill as much as possible.
Send email based on clicking the add scan button, so long as an email needs to be sent - full policy is tbd, but should be similar to “status has changed and checkbox is checked and all information necessary to send email template is available”
Keep a checkbox determining whether to send email on the page (What are rules for persistence of this between samples/sessions?)
When sample status changes, (and checkbox is unchecked), send email dependent on new status.

@dhakim87 Interesting feedback from the Dom/Kat review!  Can you please talk with MacKenzie in the wet lab, if you haven't already? AFAIK she is most likely to be the person actually clicking the button that sends an email, and in earlier discussions of the barcode-scanning-related functionality, she had some requirements that surprised me (like not wanting the sample status dropdown set to what we knew the status of the sample was in the db when there was a problem with it, but instead wanting the wet lab personnel to be required to change it manually ...)

Checked the email chain, MacKenzie's feedback was included, Kat was not in the call.  My mistake.

In the next review, please give special attention to ruleset.js, it's my attempt at a framework to simplify implementing business logic on client side by letting you separate out, cache, name, and combine the jquery $().change(...) calls.  It could definitely use some more layers of syntactic sugar, but it helped a heck of a lot for simplifying enabling/disabling, showing/hiding, changing text, and everything else.
I used it heavily in implementing the feedback from Dom and MacKenzie.

For a slightly simpler diff, merge the unit test PR prior to this one.

:+1: pending comment from our call


Support RTL

Fixes #

Checklist

[ ] Includes UI tests
[ ] Readme is updated

Description

Thanks for creating this @EssamSoft! Will review it today


Show Files in relationship

Hi i need a custom relationship,
i have a users table that every user has a file in files table
i store file name in name column
i need show download button in users BREAD.
How i can do this?
NO SLACK PLEASE

Slack is preferred, but I'm assuming there's a reason for your request not to use slack... Feel free to post in DevDojo forums instead: https://devdojo.com/forums/category/voyager.  You could also ask in the larachat slack, laravel discord, or laracasts forums if any of those work better for you.
We're really trying to keep github focused on code issues, not help requests.


Cannot config thanos sidecar cluster.peers in Prometheus Operator

What did you do?
Here my config promtheues operator with thanos sidecar:
apiVersion: monitoring.coreos.com/v1
kind: Prometheus
metadata:
name: prometheus
namespace: monitoring
spec:
replicas: 1
retention: 1d
serviceAccountName: prometheus
baseImage: quay.io/prometheus/prometheus
version: v2.11.0
serviceMonitorSelector:
matchLabels:
release: istio-monitor
resources:
requests:
memory: 400Mi
thanos:
baseImage: quay.io/thanos/thanos
version: v0.7.0
peers: thanos-peers.monitoring.svc.cluster.local:10900
objectStorageConfig:
key: thanos.yaml
name: thanos-objstore-config
Did you expect to see some different?
Environment

Prometheus Operator version:
v2.11.0

Kubernetes version information:
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.0"

Kubernetes cluster kind:
EKS

Issue
I cannot see "cluster.peers: thanos-peers.monitoring.svc.cluster.local:10900" in container args thanos-sidecar.

Here is result thanos-sidecar when i describe pod:
thanos-sidecar:
Container ID:  docker://c7d5d922ee0652aefd90c95184486c015a3a39fe275844d3ff24ac36998020f9
Image:         quay.io/thanos/thanos:v0.7.0
Image ID:      docker-pullable://quay.io/thanos/thanos@sha256:fe9cb36d0539f6b8a544e1a27fdb93bd67d533261443104476fa97ef41660b2e
Ports:         10902/TCP, 10901/TCP
Host Ports:    0/TCP, 0/TCP
Args:
sidecar
--prometheus.url=http://localhost:9090/
--tsdb.path=/prometheus
--grpc-address=[$(POD_IP)]:10901
--http-address=[$(POD_IP)]:10902
--objstore.config=$(OBJSTORE_CONFIG)
May I config wrong?
Anything else we need to know?:

Cluster peers has been removed in Thanos, gossip doesn't exist anymore, discovery happens just from the querier side.


修复api/paddle/nn/functional/mse_loss_cn.html文档

PR types
Bug fixes
PR changes
Docs
Describe
涉及到的 文档
mse_loss_cn.html
参数reduction描述中，如果 :attr: reduction 为 'none' 格式错误

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Mac seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Update location-of-data-in-teams.md

Removing the additional and unnecessary details of customer data storage within the different M365 workloads.
Updating the countries where GoLocals have been launched.

@GabGonzalezPM Please sign CLA. Thanks.


Players should be able to choose an action when its their turn; call/raise or fold

refer to mockup for button choice; fold button and a call/raise button

closed commit: a225372a9476abe4271285d78539b37dd05fd345


Use caffe instead of Torch

Hi
Is it prefer to use caffe framework instead of torch ?

Please see https://github.com/cmusatyalab/openface/blob/master/CONTRIBUTING.md.
This is also a duplicate of #1.


Added channel for API 26 and above

This is a fix for music controls not showing up in API 26. They required a Channel setup for API 26.

This PR should be merged since it fixes issues on newer Androids

@homerours when will this get merged?


Scrolling

Cache the lines (BTree over line IDs?), request new lines using the render_lines API. screen position encoded by (f64,f64) for smooth scrolling. A scrollbar.

Working on it.


Measurable Category: should support a static panel with information above the diagrams

Description
Option to move the existing 'About' static panel or create a new one.
May need to move the exports under tree
Resourcing
We would like to add this request to the Waltz team's feature backlog

Moving the panel looks good, however the static panel titles look a bit out of place.
Decided the best solution is to make static panel optionally render a title based on the presence of the static_panel::title value in the database.  This in turn means we will need to updated the DDL (the column is currently non-nullable) and update the static panel admin screens to relax the required constraint.

Now that panel titles are nullable, we need something better to show in the panel list.   Decision is to show the title and fallback to showing an italicized version of the first 50 chars of the content if the title is not available.


Allowed passing in target name to makefile

Small makefile change to allow for target name being different from processor name

I don't want this because it requires me to type two different commands when changing tests rather than one

Oh i see. I suppose you couldn't just flash the same executable when trying out two different tests. That makes sense.

I'll close then.


Coverage results for each run and stage must be integrated with Jenkins pipeline

To properly collect, publish and aggregate our test results we need a proper Jenkins pipeline where each stage of the pipeline has it's own separate container.

Fixed, in mitaka.

Fixed.


[SPARK-35109][SQL] Fix minor exception messages of HashedRelation and HashJoin

What changes were proposed in this pull request?

It seems that we miss classifying one SparkOutOfMemoryError in HashedRelation. Add the error classification for it. In addition, clean up two errors definition of HashJoin as they are not used.
Why are the changes needed?

Better error classification.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Existing tests.

cc @cloud-fan could you help take a look when you have time? Thanks.

Test build #137501 has started for PR 32211 at commit 2cf5940.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42075/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42075/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42075/

Test build #137501 has finished for PR 32211 at commit 2cf5940.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137501/

Thanks! Merged to master.

Test build #137570 has started for PR 32211 at commit 2cf5940.

Thank you @maropu for review!

Test build #137570 has finished for PR 32211 at commit 2cf5940.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137570/


Document testNamePattern example (#4732)

Resolve #4732
Summary
Despite the name, I got confused with exactly what --testNamePattern was used for and found I wasn't alone StackOverflow
Test plan
To resolve it I added an example in the docs CLI section. I ran the docs server locally and was satisfied. It's a simple change so I do not expect there should be no issue with publishing.

Thanks!


React Moralis not working with Vite Built React App

Hello! So I have built my react app using vite rather than create react app. I installed react-moralis via yarn and I imported the MoralisProvider Component into my main.jsx and wrapped the App component as seen below:

And when I run the app I get this issue:

I was confused about this until I read that I needed to have the moralis pacakage installed as react-moralis requires it as a dependency so I installed moralis via yarn and thought that would fix the issue until I got this error in the console:

Would anyone happen to know how I could go about fixing this issue?
Thanks for the help!

Hmm, seems to be an issue with how Vite is handleing ES6 modules.
I saw this post (https://community.parseplatform.org/t/vue-vite-parse-js-error-super-expression-must-either-be-null-or-a-function/2001), a similar error on Parse (Moralis bootstrapped from Parse, so this is likely the same error)
We have little experience in Vite, and need to check if this is an issue that we can solve, or if it is a configuration of Vite for example.

Possibly related to: https://github.com/MoralisWeb3/Moralis-JS-SDK/issues/271

This type of error commonly comes out from wrong import or circular dependencies, and, as shown in the attached svg graph generated by the madge package, this SDK has 55 circular dependencies. Hopes it can help ;)

No worries! thank you so much reading through the links you sent me helped me figure out how to get it working in development and production. I appreciate the help!


[CI] Add Dockerfile lint testing to Travis

We should add Dockerfile lint testing now that we're starting to add some basic Docker support to the project.
The Project Atomic team has a Dockerfile linter that we can consume:
docker run -it --rm --privileged -v `pwd`:/root/ projectatomic/dockerfile-lint dockerfile_lint -f centos7_base

Alright, I have a PR incoming for this one, love this idea.
My build is failing due to the The command "ansible-lint --exclude=roles site.yml" exited with 2. as discussed earlier today, but, the new checks are passing. The results are available here in my travis
I made a couple small changes to the Dockerfile.

To pass a check for the a couple pieces of meta data, especially "recommended labels" while not completely necessary now, they're bits of info used by k8s / openshift, and might be useful for now. I put the "Version" as the value {placeholder} as we don't have any tagged releases right now. These do not impact the functionality of the container.
Added yum -y clean all as suggested by the lint.

Additionally I added the --permissive flag to the dockerfile_lint command as otherwise it fails on warnings, and I'm not sure if some of the warnings are things we want.
One of which is that it warns about having an sshd server, and for a good reason, it used to be a crutch to install a sshd server instead of using nsenter, and... now we just use docker exec -it container_name /bin/bash to debug a container. Unsure if we want sshd for another reason. (Running an sshd in a container is not invalid, so, there are reasonable reasons to do so)

Thanks! I've merged this down.


Antialiasing for cube animation

Test across devices before merging
Check if quality improvement outweighs the added overhead

Removed production files to simplify merging to master


4 ➡ 5

➡ Forward port
Port ign-rendering4 to main
Branch comparison: https://github.com/ignitionrobotics/ign-rendering/compare/main...ign-rendering4
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@adlarkin , I addressed your comments and pushed, let's see if Windows CI comes back now.

Windows already failed, it looks like there's an issue with getting dependencies for the build (https://build.osrfoundation.org/job/ign_rendering-pr-win/1442/consoleFull#1273209513aa60f765-a60a-427d-900c-dc128ab22287):
Missing: ignition-common4 (Components: graphics, events)

Ahhhh
-- 	Cannot build component [graphics] - Missing: ignition-utils1
Here we go: https://github.com/ignition-tooling/gazebodistro/pull/30

Nice catch, I missed that when scanning Windows CI. https://github.com/ignition-tooling/gazebodistro/pull/30 has been approved, so I think all we need to do now is merge that and then run Windows CI one last time :crossed_fingers:

All :green_circle:


Tags and multiple attribute not working together with jquery 3.4.1

Hello there. I found a problem with select multiple and tags set to true value. After that can't write more than 4 characters in the search element. Problem is with jquery 3.4.* and select2 4.0.7 (checked lower version - 4.0.6 - not working too) version, with jquery 3.3.1 it's working property. I will give you an example:
jquery 3.4.1 - not working
jquery < 3.4.1 - working

Duplicate of https://github.com/select2/select2/issues/5485.


Cannot Import Any Module., Error Is Unexpected Token <

I have installed angular2-cookie, ng2-smart-table, angular-2-data-table..
and when i import module, error is always "Unexpected token <at eval ()"
any new module can't import.. please help me.

For support requests you can use gitter or take a look at project's the wiki page in order to get more complete idea on how the it works.

Facing same issue.Not getting any solution for this.


Unspecified error

On the recommendation of @stranak, I tried to use the tool to display our ALTOs created within the https://atrium-research.eu/ project. Unfortunately, the ALTO content will not load and display. The problem may be that the ALTO is for multiple pages, which I don't know how to address within the tool. Would it please be possible to advise or issue a fix if there is any problem on the application side?
I'm attaching the files I'm working with:
OCR_data.zip

Hey @motyc, happy to see that someone is trying to use this code.
The problem was indeed that the ALTO file has multiple pages inside it. Unfortunately the code does work only if every page is in a separate file.
What I did to make your example data work

split your data into 2 files (each with one page)
change the file extension from .alto to .xml (otherwise you can't import it)

Here is the project (folder) which you can directly load into ocr-editor and it should work
atrium-project.zip

Dear Filip, thank you for such a swift advice! I can confirm that project works and also that I have been able to reproduce the steps to make it working for our data. We will transform the input data to make imports possible. Thank you again.


Is there any way to handle error while take effect is pending

try {
   const timeout = setTimeout(() => {throw new Error('Error')}, 3000);
   yield take('SOME_ACTION');
   clearTimeout(timeout);
 } catch(e) {
   console.log('error catched')
 }

An error thrown after 3 sec if take effect doesn't resolved, but i can't catch an error.
Is it even possible to catch error in my case?

I guess the race effect will fit your needs : https://redux-saga.js.org/docs/advanced/RacingEffects.html


[question] svg-icon.json format

I did not find an explanation in the source code, commits or documentation of how svg-icons.json was generated
What format was used to create the mesh icon?
Thanks.

@heshan0131  please.

@xr0master please sit tight since we're taking a break for the Christmas holidays.

@chrisirhc Please don't replay if you don't know answer. Have a nice holiday


Added payload for repo_dispatch event

This is 1/2 of the solution to https://github.com/iasql/iasql-engine/issues/937. The other half is https://github.com/iasql/iasql-on-iasql/pull/98.

I am not great with github actions yaml. Have you tested this? If so, how?

I am not great with github actions yaml. Have you tested this? If so, how?

I am not great with github actions yaml. Have you tested this? If so, how?

I am still in the process of testing (which is why the PR is still in draft). I will explore changing the triggers to run on my PR branch and observing the flow.


⚠ Bofrost.be has degraded performance

In 4cabf35, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2002 ms

Resolved: Bofrost.be performance has improved in 7cd867f after 20 minutes.


Potentially contradictory Analyst access for Plans

I’ve got a hopefully easy question about the way Analyst permission are explained, especially regarding Plans.
My understanding is that as an Analyst role, I can look at the Plans Analysis page to see the analysis of behaviors, but I can’t actually launch a plan. But when I go into the MS tenant and look at some of the Plans blades, it looks like I can submit a Plan.
Here in the documentation, I see a few potential contradictions in what Analysts get for Plans permissions
1.	Role Description

Does “full access” include the ability to launch Plans?
2.	User Access chart

Create plans that help participants improve workplace behaviors

Analysts appear to have access to Plans, with only the People Manager being limited in scope
3.	Function Performed

Here, Analysts are not listed as being able to set up and manage change plans.
Would it be possible to review and update the documentation for the current Plans functionality for the Analyst role so it's more clear on what the Analyst can and cannot do with regards to Plans?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d80edf7d-e15e-15fe-f2f7-ec92690e3832
Version Independent ID: 9ea8d852-234a-62db-ae36-6e21a99d2344
Content: User roles in Workplace Analytics - Workplace Intelligence
Content Source: WorkplaceAnalytics/Use/User-Roles.md
Product: wpa
GitHub Login: @madehmer
Microsoft Alias: v-pausch

Hi m-m-powers,
You're absolutely right. Analysts can also create plans, and the docs did not reflect this correctly. This wasn't always an option for analysts, but it is now. I'm in the process of updating the documentation and I'll post a link here once that's done.
Thank you!
-- paul9955, Workplace Analytics documentation

Hi m-m-powers,
You're absolutely right. Analysts can also create plans, and the docs did not reflect this correctly. This wasn't always an option for analysts, but it is now. I'm in the process of updating the documentation and I'll post a link here once that's done.
Thank you!
-- paul9955, Workplace Analytics documentation

The docs have been updated accordingly. Thanks Paul for updating the dos and m-m-powers for your feedback. Closing this since the issue has been resolved.

The docs have been updated accordingly. Thanks Paul for updating the dos and m-m-powers for your feedback. Closing this since the issue has been resolved.


IE10 not supported anymore

In the previous version Chrome and FireFox were not working as expected (no prezi effect), but IE10 en Safari did.
In this version the IE10 version is not supported anymore, but FF and Chrome are?
Would be nice if impress would be cross-platform.

I'm not sure which versions you mean - nothing major changed in years in impress.js.
It's possible that browsers updated/changed some of their implementations making impress.js supported in more browsers.
IE10 was never supported out of the box as is didn't implement classList or dataset attributes from HTML5. I don't know if it changed, but probably didn't.

It's actually the jmpress.js, the jquery plugin, a working example in IE10 you can find on:
on http://new.digirent.nl/examples/impress/
But not working om FF and Chrome.
Your current version is working in Chrome and FF but not in IE.

jmpress is completely separated project, rewritten from scratch as far as I know, so it has simply other requirements and browser support.
So for help with browser support for that I suggest consulting their repository: https://github.com/jmpressjs/jmpress.js

Closing because it was probably reported in the wrong repo.


Add ComboBox Component and Widget

Add ComboBox component from Spectrum https://react-spectrum.adobe.com/react-aria/ComboBox.html

It would be very useful if this would have the ability to display images as show here https://react-spectrum.adobe.com/react-aria/examples/user-combobox.html

If the selection is empty and the user typed something into the text field don't clear the input on losing focus. Preserve the typed-in value in the control (show error if necessary).
If the selection is empty and the user typed an exact match of the option select that option on loss of focus.


Continually getting errors at DAX step and typo in tutorial

[Enter feedback here]
The tutorial says in text to do many to one in one direction but it looks like the image shows the opposite.
This is at the step in the tutorial for creating the model, after the dataflow and pipeline.
Separate from that or possibly related, I keep getting errors of various sorts and it "reverts to previous version" but the previous version can't be edited to add a DAX measure or anything else without that same error.  I started over from scratch since no way to back up in time or undo things, but got the same errors at the same point.  Cannot get past the modeling step.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c55d0f50-08ee-2361-fe1f-8a1e6df76dca
Version Independent ID: c55d0f50-08ee-2361-fe1f-8a1e6df76dca
Content: Tutorial: Microsoft Fabric for Power BI users - Power BI
Content Source: powerbi-docs/fundamentals/fabric-get-started.md
Service: powerbi
Sub-service: pbi-fundamentals
GitHub Login: @itsnotaboutthecell
Microsoft Alias: alpowers

Thanks for your comment, @suetholen. This issue has been assigned to the doc author for review.

Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. Both the product and documentation has changed since this issue was opened. Therefore, we are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.


Frontend-issues

[Current coverage][cc-pull] is 56.31% (diff: 100%)

Merging [#529][cc-pull] into [development][cc-base-branch] will not change coverage

@@           development       #529   diff @@
=============================================
  Files                4          4
  Lines              396        396
  Methods             43         43
  Messages             0          0
  Branches            48         48
=============================================
  Hits               223        223
  Misses             173        173
  Partials             0          0

Powered by Codecov. Last update [64d1942...cdb458b][cc-compare]
[cc-base-branch]: https://codecov.io/gh/fossasia/open-event-webapp/branch/development?src=pr
[cc-compare]: https://codecov.io/gh/fossasia/open-event-webapp/compare/64d1942d789ba49fcc2ab6d7ecc0735faba70d7a...cdb458bc61c873c27476d1bb493a0a1231e331bc?src=pr
[cc-pull]: https://codecov.io/gh/fossasia/open-event-webapp/pull/529?src=pr

@mariobehling about the comment
Rethink usability, why are there different font sizes in dropdown menu?
Can you please elaborate with a snapshot. I am feeling difficult to find it exactly.

No, problem. Do first what you can and we follow up step by step.

@mariobehling @aayusharora can we merge this first ? right now there are UI fixes
The rethink usability topic is open ended, we can do that in a future PR. We can discuss that more in a separate issue too if we want

Yes @championswimmer It's already cover lot of fixes, kindly merge.


can this be made to work for geojson

my overlay is a geojson acting as a fog of war, so when I pan/drag the map it shows the boundary where no geojson is loaded exposing my map before I am ready, I would like to know If I could get this buffering to happen with my geojson too.
thanks to you for contributing to the leaflet community! Greatly appreciated!

I used the following to set padding on the renderer which seems to have such an effect for GeoJSON
var paddedRenderer = L.svg({ padding: 0.8 });

var geo = L.geoJSON(states,{style:mapstyle, renderer: paddedRenderer});