add --no-vcs option to cargo package

If cargo package is run for a crate that is not version controlled in
a way that cargo expects, git2 will overreach upwards and grab a
irrelevant .git repo. This change adds --no-vcs as an option to
cargo package to prevent this.

r=me, but there are general concerns on introducing too many flags to cargo and also there's a soft feature freeze in effect, so I'm not sure if we should land this.
But the change itself makes sense and looks reasonable! 🙂

This isn't so much adding a feature as it is removing a feature that was introduced in an August commit. The latest cargo introduced this vcs behavior in cargo package and ended up breaking our continuous integration of Rust packages in Chrome OS. It's incredibly important that CI for rust packages works on Chrome OS, so I ask that you may an exception to the soft feature freeze. I would be happy to discuss this further, if need be.

@zachreizner, Do you happen to know what PR caused the problem? (You say it is from August so I thought you may know.) Can you make a reproducible example, so that we can track it down? Do you have more information on what problems the current behavior is causing you? Can you add a test to this PR?

The PR was #5886. I don't have a good example, but I will work on one if that helps.
The problem with the behavior of cargo package today is that it violates the portage ebuild sandbox used to verify that a package (in the linux package manage sense) is only using files inside of its own working directory during the build phase. The way the sandbox works is by checking what files get touched by the build process, rather than outright preventing such invalid access. I know this system sounds rather fragile, but it's important for saving headaches later down the line with non-reproducible builds. Also, every other build system is able to stay within its working directory, and I think cargo should be no different.

I think we should be able to fix this by pushing the check_repo_state call under opts.list (which early returns) and under if !opts.allow_dirty.  Wouldn't that fix your use cases @zachreizner?  Can anyone spot any drawbacks?

Soft echo that accompanying this the change with a test would be 🔝.

When you say under if !opts.allow_dirty, do you mean that if --allow-dirty is passed in, no vcs info checking will occur? If so, that seems like it would solve the issue.

Want to try a local build with that change to confirm?

Thanks for the PR @zachreizner! I think we're always up for taking PRs that fix bugs!
I would personally be inclined, though, to fix this perhaps not with an option to cargo publish but rather with better inference behavior on behalf of Cargo. This seems like a flag that would only be passed in pretty niche use cases, so it'd be best if we didn't have to add a new flag at all!
For example I think we could improve our inference and say something like:

Take the current package being published and its workspace root. The manifests of these two packages have a common path as an ancestor.
Walk up the filesystem looking for a git repository to at most that common ancestor, but look no further.

I think that would help prevent reaching too high in your case perhaps? (most crates are their own workspace so they wouldn't look much farther than that directory)

I apologize, but my analysis of the problem our build system was facing is slightly incorrect. The issue is actually that the ~/trunk/src/platform2 directory, which is where many of our Rust and non-Rust packages are placed, has a .git directory that looks like this:
~/trunk/src/platform2 $ ls -lh .git
-rw-r--r-- 1 zachr eng 1.2K Nov  8 16:45 COMMIT_EDITMSG
lrwxrwxrwx 1 zachr eng   48 Oct 30  2015 config -> ../../../.repo/projects/src/platform2.git/config
lrwxrwxrwx 1 zachr eng   67 Oct 30  2015 description -> ../../../.repo/project-objects/chromiumos/platform2.git/description
-rw-r--r-- 1 zachr eng  128 Oct  3 16:08 FETCH_HEAD
-rw-r--r-- 1 zachr eng   32 Nov  7 11:29 HEAD
lrwxrwxrwx 1 zachr eng   61 Oct 30  2015 hooks -> ../../../.repo/project-objects/chromiumos/platform2.git/hooks
-rw-r--r-- 1 zachr eng 573K Nov  8 16:45 index
lrwxrwxrwx 1 zachr eng   60 Oct 30  2015 info -> ../../../.repo/project-objects/chromiumos/platform2.git/info
lrwxrwxrwx 1 zachr eng   46 Oct 30  2015 logs -> ../../../.repo/projects/src/platform2.git/logs
-rw-r--r-- 1 zachr eng    0 Nov  8 16:45 MERGE_RR
lrwxrwxrwx 1 zachr eng   63 Oct 30  2015 objects -> ../../../.repo/project-objects/chromiumos/platform2.git/objects
-rw-r--r-- 1 zachr eng   41 Nov  7 11:29 ORIG_HEAD
lrwxrwxrwx 1 zachr eng   53 Oct 30  2015 packed-refs -> ../../../.repo/projects/src/platform2.git/packed-refs
lrwxrwxrwx 1 zachr eng   46 Oct 30  2015 refs -> ../../../.repo/projects/src/platform2.git/refs
lrwxrwxrwx 1 zachr eng   64 Oct 30  2015 rr-cache -> ../../../.repo/project-objects/chromiumos/platform2.git/rr-cache
lrwxrwxrwx 1 zachr eng   49 Oct 30  2015 shallow -> ../../../.repo/projects/src/platform2.git/shallow
lrwxrwxrwx 1 zachr eng   59 Oct 30  2015 svn -> ../../../.repo/project-objects/chromiumos/platform2.git/svn

All of those symlinks are outside the sandbox, which is what triggers our problem. Therefore anything that preempts searching inside of the .git directory prevents the sandbox violation. My original PR with --no-vcs does this, as would @dwijnand's suggestion to have allow_dirty preempt any vcs_info checking. @alexcrichton's suggestion to only search as high as the workspace and package's common ancestor would also prevent searching this .git directory, I think. Am I correct in assuming that the simple case for this hypothetical ceiling directory would be the same directory as where the package's Cargo.toml is?
For example, we have a package in ~/trunk/src/platform2/vm_tools/9s with a Cargo.toml file at ~/trunk/src/platform2/vm_tools/9s/Cargo.toml. Assuming no explicit workspace, the ceiling for searching for a .git directory is simply ~/trunk/src/platform2/vm_tools/9s. Does that sound reasonable?

If someone is publishing with allow_dirty and a dirty tree then what good is the cargo_vcs_info? So +1 for  reusing the allow_dirty flag.

Is there an error message available from cargo for the original issue, here?  Is it just that the found parent repo is in fact dirty?  I don't follow how #5886 (I authored) would have changed that behavior?
@Eh2406: specifically, if check_repo_state finds a repo that is dirty, then cargo_vcs_info is not generated.

Ok thanks for the explanation @zachreizner, makes sense that my previous suggestion wouldn't work. I think we can't say, though, that a git directory is only searched for in the Cargo.toml directory because crates are often located throughout a git repository (and aren't always in a workspace).
At this point the best solution may be to update cargo and/or git2 to respect env vars like GIT_CEILING_DIRECTORIES, which I believe is already a standard-ish env var in with git, and in this system I imagine y'all could configureGIT_CEILING_DIRECTORIES to be beneath the git root here.

Sorry I should also elaborate more as well. I would personally prefer to not add a new feature (flag) for this since it seems like a pretty niche feature. I'm trying to brainstorm other ideas we can adapt existing concepts and/or existing ideas to avoid adding a new feature/flag.
I'd personally be ok with the adaptation of --allow-dirty as well, it seems slightly odd to me but so do all the various routes here

it seems slightly odd to me but so do all the various routes here

given GIT_CEILING_DIRECTORIES is in the official docs it seems like the less ad-hoc solution.

LGTM. Invoking with --allow-dirty means that the state of the vcs is not relevant to what is being packaged, so it makes sense not to look at the vcs state.

Title has been updated. Do we want an update added to https://github.com/rust-lang/cargo/pull/6280#issue-229191337 as well?

Thanks @zachreizner!
@bors: r+

:pushpin: Commit fd5fb6e2dc4c6b06402d4c14df270edf6cd56b57 has been approved by dwijnand

:hourglass: Testing commit fd5fb6e2dc4c6b06402d4c14df270edf6cd56b57 with merge e70bccff8b3aee537d28dd14d4205df319e3260e...

:sunny: Test successful - status-appveyor, status-travis
Approved by: dwijnand
Pushing e70bccff8b3aee537d28dd14d4205df319e3260e to master...


replace ci prefix only at rewriting part

Signed-off-by: Tianle Huang<EMAIL_ADDRESS>Description
We observed that https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.0/latest/linux/arm64/builds/opensearch/manifest.yml
is being redirected to
https://ci.opensearch.org/distribution-build-opensearch/1.3.0/1204/linux/arm64/builds/opensearch/manifest.yml
and ended up with AccessDenied error. Thus we shall not remove ci/dbc during redirect. Instead, it shall only happen at the rewrite part.
Issues Resolved
Test
update unit test for this.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1681 (b6a6c0f) into main (9cb1ffb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1681   +/-   ##
=========================================
  Coverage     94.74%   94.74%
  Complexity       14       14
=========================================
  Files           166      166
  Lines          3501     3501
  Branches         25       25
=========================================
  Hits           3317     3317
  Misses          181      181
  Partials          3        3

Impacted Files
Coverage Δ

...loyment/lambdas/cf-url-rewriter/cf-url-rewriter.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb1ffb...b6a6c0f. Read the comment docs.

Could there be a missing test case that can be added? I'm not certain from the current logic if all scenarios are getting coverage.

Thought about this as well. The underlying issue is that the url without ci/dbc ( https://ci.opensearch.org/distribution-build-opensearch/1.3.0/1204/linux/arm64/builds/opensearch/manifest.yml) doesn't work. I could create a follow up issue to see how we can gate such.

-----------------------------|---------|----------|---------|---------|-------------------
File                         | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-----------------------------|---------|----------|---------|---------|-------------------
All files                    |     100 |      100 |     100 |     100 |
 lambdas/cf-url-rewriter     |     100 |      100 |     100 |     100 |
  cf-url-rewriter.ts         |     100 |      100 |     100 |     100 |
  https-get.ts               |     100 |      100 |     100 |     100 |
 lib                         |     100 |      100 |     100 |     100 |
  artifacts-public-access.ts |     100 |      100 |     100 |     100 |
  buckets.ts                 |     100 |      100 |     100 |     100 |
  build-artifact-stack.ts    |     100 |      100 |     100 |     100 |
  identities.ts              |     100 |      100 |     100 |     100 |
-----------------------------|---------|----------|---------|---------|-------------------

Test Suites: 3 passed, 3 total
Tests:       13 passed, 13 total
Snapshots:   0 total
Time:        3.3 s

Hi @tianleh, the new changes are deployed. Please check.
Thanks!

Tried the below URLs:
https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.0/latest/linux/x64/builds/opensearch/manifest.yml
https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.0/latest/linux/arm64/builds/opensearch/manifest.yml
Looks like its working 🥳

Link to main issue https://github.com/opensearch-project/opensearch-build/issues/1492


Fix rename property patch from type to method

Found an issue with renaming the field from Type to Method.
We thought we had tested with a latest image update, rebuild, push, and test but we missed the CRD regeneration.
Since we do not support PlainText I am going to remove it from the enum and CRD.

cc @mtulio

I just ram a couple of tests in one cluster with those changes. The test will create custom configurations to validate those scenarios:

Cleaning spec.storage.oss to check if the operator will set the default values
Create a custom bucket name, with default values (encrypted AES256)
Create a custom bucket name, with encryption method AES256 ('OSS-Managed')
Create a custom bucket name, with encryption method using KMS

See the results:
#> Creating buckets with prefix: test-image-registry-202112142102
#> Starting... checking initial config
#> Getting current image-registry CRD storage:
{
  "managementState": "Managed",
  "oss": {
    "bucket": "test-px2zh-image-registry-us-east-1-pfwjtxeyibgumpyyinthwtxafj",
    "endpointAccessibility": "Internal",
    "region": "us-east-1"
  }
}
#> Getting current image-registry deployment variables:
{
  "name": "REGISTRY_STORAGE_OSS_BUCKET",
  "value": "test-px2zh-image-registry-us-east-1-pfwjtxeyibgumpyyinthwtxafj"
}
#> Cleaning current OSS configuration...
config.imageregistry.operator.openshift.io/cluster patched
#> Getting current image-registry CRD storage:
{
  "managementState": "Managed",
  "oss": {
    "bucket": "test-px2zh-image-registry-us-east-1-reisqbntuuuqiddigiipafgtwa",
    "endpointAccessibility": "Internal",
    "region": "us-east-1"
  }
}
#> Getting current image-registry deployment variables:
{
  "name": "REGISTRY_STORAGE_OSS_BUCKET",
  "value": "test-px2zh-image-registry-us-east-1-reisqbntuuuqiddigiipafgtwa"
}
#> List bucket on OSS oss://test-px2zh-image-registry-us-east-1-reisqbntuuuqiddigiipafgtwa
Object Number is: 0

1.081995(s) elapsed
#> Creating a custom bucket with name: test-image-registry-202112142102-custom
config.imageregistry.operator.openshift.io/cluster patched
#> Getting current image-registry CRD storage:
{
  "managementState": "Managed",
  "oss": {
    "bucket": "test-image-registry-202112142102-custom",
    "endpointAccessibility": "Internal",
    "region": "us-east-1"
  }
}
#> Getting current image-registry deployment variables:
{
  "name": "REGISTRY_STORAGE_OSS_BUCKET",
  "value": "test-image-registry-202112142102-custom"
}
#> List bucket on OSS oss://test-image-registry-202112142102-custom
Object Number is: 0

1.300383(s) elapsed
#> Create a bucket with KMS encryption: test-image-registry-202112142102-kms
config.imageregistry.operator.openshift.io/cluster patched
#> Getting current image-registry CRD storage:
{
  "managementState": "Managed",
  "oss": {
    "bucket": "test-image-registry-202112142102-kms",
    "encryption": {
      "kms": {
        "keyID": "be41ecd4-4124-4e85-b84c-135e5cbab113"
      },
      "method": "KMS"
    },
    "endpointAccessibility": "Internal",
    "region": "us-east-1"
  }
}
#> Getting current image-registry deployment variables:
{
  "name": "REGISTRY_STORAGE_OSS_BUCKET",
  "value": "test-image-registry-202112142102-kms"
}
#> List bucket on OSS oss://test-image-registry-202112142102-kms
Object Number is: 0

1.100638(s) elapsed
#> Create a bucket with AES256 encryption: test-image-registry-202112142102-aes256
config.imageregistry.operator.openshift.io/cluster patched
#> Getting current image-registry CRD storage:
{
  "managementState": "Managed",
  "oss": {
    "bucket": "test-image-registry-202112142102-aes256",
    "encryption": {
      "method": "AES256"
    },
    "endpointAccessibility": "Internal",
    "region": "us-east-1"
  }
}
#> Getting current image-registry deployment variables:
{
  "name": "REGISTRY_STORAGE_OSS_BUCKET",
  "value": "test-image-registry-202112142102-aes256"
}
#> List bucket on OSS oss://test-image-registry-202112142102-aes256
Object Number is: 0

1.126230(s) elapsed
#> Show buckets created with prefix [test-image-registry-202112142102]
2021-12-14 21:04:04 -0300 -03         oss-us-east-1        Standard    oss://test-image-registry-202112142102-aes256
2021-12-14 21:03:20 -0300 -03         oss-us-east-1        Standard    oss://test-image-registry-202112142102-custom
2021-12-14 21:03:42 -0300 -03         oss-us-east-1        Standard    oss://test-image-registry-202112142102-kms

This is the bucket encryption settings:

custom/default (AES256)

AES256

KMS

@mtulio Thanks for this. I think we are ready for review. This will be required before we can merge openshift/cluster-image-registry-operator/pull/724.

/approve

Based on the tests above:
/lgtm


Crashlytics report not being received for iOS

Crashlytics Report are not being received for iOS.

@AliMeer  please test and close this.


Add Update System

Is your feature request related to a problem? Please describe.
Currently, TimerX does not have a update system
Describe the solution you'd like
A Update button in the about window in the long run. In the short run, a Upgrade Code can be added to keep config but still update and use the same AppData folder.
Describe alternatives you've considered
None

Cool idea, gonna add this to my todo list!

Maybe send a daily ping to GitHub for new releases and if it exists, getting the MSI using some module. If we are on Linux or macOS, wget must be preinstalled, so we could try using that to get installers.

I'll try making a basic Tk UI on this, don't blame me. I am giving a heads-up that I am installing Replit so that we could make REPLs for repos here. Moreover, this would help others to create REPLs too.

I think I hit a jackpot on this. Maybe this could be my well-worth first feature of the app. Testing on the branch here, if you got something for this, test it and then commit it there.

Wait, why did you assign me of all people?
Alright, I accept it. Now what?

I thought you were working on it on the other repo?

I did a simple local test of unifying the update system with the upstream(https://github.com/TimerX-App/TimerX) code. It failed horribly. However, the update window does work. Maybe I need to rewire more of the code to the upstream code, which I am adding now here. Kind of like a link, idk how it'd work out.
Can you tell me where you got the Fluent icons? I know you posted it, but I need it now for some more icons.

fluenticons.co

Okay... One part of merging succeeded. I am uploading the changes now. Will link the commit to this.

Thanks for the link!

Read description in 34769d3 to run.

Commit not highlighted?

Alright, I'll be frank with you. I don't know what I should do now! Tell me what I should do and I will do it after Republic Day. Till then, our biggest priority is #64.

I'll start a Repl today, @sumeshir26 can you join it? It would be between 9 AM to 10 AM IST.

OK, no prob

Starting in 10 minutes, or maybe five, who knows?

Ok, logging in...

Did you get any problems? I see you on .replit only

Done by #83


Refactoring and Implementing Message data object

Q
A

Is bugfix?
❌

New feature?
✔

Breaks BC?
✔

Fixed issues
-

Note: Do not merge without targets.

👍


Adds vc-contacts Web Component

Adds vc-contacts Web Component

This repo has been moved to : https://github.com/Vonage-Community/blog-voice-web_components-contacts_ui


Remove redundant collection conversion

Found when reading code base on Intellij IDEA.
It seems that there are no redundant conversions but this.

Codecov Report

Merging #992 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #992   +/-   ##
=======================================
  Coverage   85.35%   85.35%
=======================================
  Files          75       75
  Lines        2362     2362
  Branches      159      159
=======================================
  Hits         2016     2016
  Misses        346      346

Impacted Files
Coverage Δ

.../core/shared/src/main/scala/io/circe/Decoder.scala
92.52% <0%> (-0.32%)
:arrow_down:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
90% <0%> (ø)
:arrow_up:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
92.3% <0%> (ø)
:arrow_up:

...scala/io/circe/shapes/LabelledHListInstances.scala
100% <0%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9099c...ec333b9. Read the comment docs.

Good catch!


Add TPC-H query 16 to TpchQueryBuilder

Adds TPC-H query 16 to TpchQueryBuilder.
Extends TpchBenchmark and ParquetTpchTest with query 16.
| # Num Threads/ Drivers | Velox(seconds) | DuckDB(seconds) |
|:----------------------:|:--------------:|:---------------:|
|            1           |      2.20      |       1.53      |
|            4           |      0.92      |       0.67      |
|            8           |      0.86      |       0.61      |
|           16           |      0.95      |       0.57      |

DuckDB seems to have a count distinct operator. So it performs better.

@mbasmanova can you review this? Thanks.

@pramodsatya There are CI failures. Would you take a look?

@pramodsatya There are CI failures. Would you take a look?

The CI failures are fixed, could you please review/help merge these changes? @mbasmanova @kgpai

@pramodsatya Can you add output of printPlanwithStats so we can validate the bottleneck ?


investigate podman over docker

podman can in theory run systemd inside, but no support for macos, so need a vm like docker-desktop
keep an eye on:

https://github.com/floelinux/ice-machine
https://floelinux.github.io/

https://github.com/moby/hyperkit for macos


bugfix: dialog will be shown on top

I had the problem, that dialogs are not shown on top. The problem is, that the "top" attribute, which is delivered via the event from the component to the service, is passed in an "extraData" json object.

Hi @be-ndee! Thank you very much for your PR. Could you please fix the test case that fails please? I'll merge it asap after it's fixed! 😉


Dark mode

Feature Description
I'd like to request the addition of a dark mode to the CEL Playground for a better user experience.
Is your feature request related to a problem?
No.
What alternatives have you considered?
Implement a toggle switch on the navbar for users to switch between light and dark mode.
Additional Context
If you'd like to work on this or have questions, please comment below for more information.

@matheusfm I would like to work on this.

Hi @pateldivyesh1323
Your contributions are welcome. Feel free to open a PR.
Let me know if you have any questions about the feature description.

@matheusfm Do you have anything in mind about how it should be implemented or the color theme?

I just suggest adding a toggle switch to the right side of the navbar.
The color theme should be consistent with the current palette, if it makes sense.
Please feel free to suggest colors here.

@pateldivyesh1323 can I assign this issue to you?

Yes, I think it's a good idea.
If you need an icon, please refer to Phosphor icons.
Here are some dark-themed playgrounds for inspiration:

https://helm-playground.com/
https://play.permify.co/
https://play.sqlc.dev/

@matheusfm where can I find light mode logo of cel playground?

@matheusfm I have attached the PR. Please review it.

Thank you @pateldivyesh1323. I'll review it.


Pointer propagation fix for powerset-cherrypick

[ ] Tests added for any new code
[x] Ran make fmt-fix (or had formatting run automatically on all files edited)
[ ] Documentation added for any new functionality
[ ] Entries added to ./unreleased/ for any new functionality

closes #2606

Codecov Report

Merging #2607 (0f358a4) into main (8e5b9b9) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2607      +/-   ##
==========================================
- Coverage   78.47%   78.46%   -0.02%
==========================================
  Files         445      445
  Lines       15640    15643       +3
  Branches     2594     2583      -11
==========================================
  Hits        12274    12274
- Misses       3366     3369       +3

Impacted Files
Coverage Δ

...syte/apalache/tla/bmcmt/rules/aux/CherryPick.scala
93.80% <100.00%> (+0.05%)
:arrow_up:

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Shouldn't this update the changelog, so we bump the version when cutting the release?

I didn't think this ticked "Entries added to ./unreleased/ for any new functionality`, but following the link, I guess bugfixes also qualify. We should update the PR template, "any new functionality" is imprecise.


RFC Declare @throws in phpdoc

This suggestion discusses the adding of standard @throws phpdoc to any method that is known to throw exceptions (or calls methods that throw these exceptions).
Pros:

better visibility to users of what exceptions code can throw.
Ability to track semver violations where exception types change

Cons:

If we adopt this, we'll need to essentially add these everywhere we throw exceptions in a big PR.
We'll need to maintain this going forward also

I suggest that we vote to either go all in on this, or agree to avoid adding this to core.
cc @silverstripe/core-team for discussion.

Strong +1 for adding these

or calls methods that throw these exceptions
I'm hoping it's a "common sense" type thing here, otherwise this could turn into a maintenance nightmare

+1 for documenting exceptions throw directly by methods. We can't document exceptions thrown by dependant methods really, otherwise everything would probably have an annotation

I'm in favor, but how does this impacts our commitment to semver. Do we consider this part of our official API?
If it is, then you better think things through before saying "this method throws Exception X",  because you've got to wait until the next major release to change it if you change your mind.

The contract we have with semver, as I understand it, is to not break anyone's code. This change might affect developer ergonomics, but I don't see how it could break functional code.

Yeah. Documenting existing exceptions doesn't affect semver. Adding or removing actual exceptions would though.

ok, just direct methods then. ;)

Is there a linter / static analyser that can help us with this?

<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="SilverStripe">
    <rule ref="Squiz.Commenting.FunctionCommentThrowTag">
    ...
    </rule>
</ruleset>

Is there a linter / static analyser that can help us with this?

PHPStorm does do this out of the box, but I'm not sure what linters replicate that

Is there a linter / static analyser that can help us with this?

https://plugins.jetbrains.com/plugin/7622-php-inspections-ea-extended- is a very good and popular plugin that helps me finding this kind of documentation error (and other stuff) in PHPStorm.
It can afaik also fix the missing @throws automatically.

rfc/accepted for ensuring that all methods that directly throw exceptions (rather than methods they call e.g. parent::foo() or $this->bar() throwing them)?

No feedback in 6 weeks, removing feedback required label

Is there a way to enable it without forcing us to immediately fix them every where?

How much time would it take to add it everywhere in a single package?

Not sure if this is the best way of doing this, but travis has a TRAVIS_COMMIT_RANGE variable. We could use that to pick out only the files that have changed on the current PR build and run some stricter tests on those files only.


Provide a way to "manually" register annotated classes to avoid any scanning

Using Neo4j-OGM in environments like Java EE or OSGi can be really annoying, because it tries to scan the Classpath for annotated classes. I prefer the solution to manually register the classes and to avoid the scanning hassle.
Instead of
sessionFactory = new SessionFactory(configuration, packageName );
I would like to alternatively do
sessionFactory = new SessionFactory(configuration, myNode, myNode, myRelationship );

This has been added in the latest release.


Module downloading failed - No address associated with hostname (tfhub.dev)

I am trying to run this Semantic Similarity with TF-Hub Universal Encoder
But in the module initialization, downloading is failed with
URLError: <urlopen error [Errno -5] No address associated with hostname>
Also tried in my local machine and a remote machine that is in another network, both hits the same error.
Seems the downloading server is down?
Full log is attached in here:
INFO:tensorflow:Using /tmp/tfhub_modules to cache modules.
INFO:tensorflow:Downloading TF-Hub Module 'https://tfhub.dev/google/universal-sentence-encoder-large/3'.
---------------------------------------------------------------------------
gaierror                                  Traceback (most recent call last)
/usr/lib/python3.6/urllib/request.py in do_open(self, http_class, req, **http_conn_args)
   1317                 h.request(req.get_method(), req.selector, req.data, headers,
-> 1318                           encode_chunked=req.has_header('Transfer-encoding'))
   1319             except OSError as err: # timeout error

/usr/lib/python3.6/http/client.py in request(self, method, url, body, headers, encode_chunked)
   1238         """Send a complete request to the server."""
-> 1239         self._send_request(method, url, body, headers, encode_chunked)
   1240

/usr/lib/python3.6/http/client.py in _send_request(self, method, url, body, headers, encode_chunked)
   1284             body = _encode(body, 'body')
-> 1285         self.endheaders(body, encode_chunked=encode_chunked)
   1286

/usr/lib/python3.6/http/client.py in endheaders(self, message_body, encode_chunked)
   1233             raise CannotSendHeader()
-> 1234         self._send_output(message_body, encode_chunked=encode_chunked)
   1235

/usr/lib/python3.6/http/client.py in _send_output(self, message_body, encode_chunked)
   1025         del self._buffer[:]
-> 1026         self.send(msg)
   1027

/usr/lib/python3.6/http/client.py in send(self, data)
    963             if self.auto_open:
--> 964                 self.connect()
    965             else:

/usr/lib/python3.6/http/client.py in connect(self)
   1391
-> 1392             super().connect()
   1393

/usr/lib/python3.6/http/client.py in connect(self)
    935         self.sock = self._create_connection(
--> 936             (self.host,self.port), self.timeout, self.source_address)
    937         self.sock.setsockopt(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)

/usr/lib/python3.6/socket.py in create_connection(address, timeout, source_address)
    703     err = None
--> 704     for res in getaddrinfo(host, port, 0, SOCK_STREAM):
    705         af, socktype, proto, canonname, sa = res

/usr/lib/python3.6/socket.py in getaddrinfo(host, port, family, type, proto, flags)
    744     addrlist = []
--> 745     for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
    746         af, socktype, proto, canonname, sa = res

gaierror: [Errno -5] No address associated with hostname

During handling of the above exception, another exception occurred:

URLError                                  Traceback (most recent call last)
<ipython-input-4-b76b84710602> in <module>()
----> 1 embed = hub.Module(module_url)
      2
      3 # Compute a representation for each message, showing various lengths supported.
      4 word = "Elephant"
      5 sentence = "I am a sentence for which I would like to get its embedding."

/usr/local/lib/python3.6/dist-packages/tensorflow_hub/module.py in __init__(self, spec, trainable, name, tags)
    103     """
    104     self._graph = tf.get_default_graph()
--> 105     self._spec = as_module_spec(spec)
    106     self._trainable = trainable
    107

/usr/local/lib/python3.6/dist-packages/tensorflow_hub/module.py in as_module_spec(spec)
     29     return spec
     30   elif isinstance(spec, str):
---> 31     return native_module.load_module_spec(spec)
     32   else:
     33     raise ValueError("Unknown module spec type: %r" % type(spec))

/usr/local/lib/python3.6/dist-packages/tensorflow_hub/native_module.py in load_module_spec(path)
     97     tf.OpError: on file handling exceptions.
     98   """
---> 99   path = compressed_module_resolver.get_default().get_module_path(path)
    100   module_def_path = _get_module_proto_path(path)
    101   module_def_proto = module_def_pb2.ModuleDef()

/usr/local/lib/python3.6/dist-packages/tensorflow_hub/resolver.py in get_module_path(self, handle)
    383     """
    384     if self.is_supported(handle):
--> 385       return self._get_module_path(handle)
    386     else:
    387       raise UnsupportedHandleError(

/usr/local/lib/python3.6/dist-packages/tensorflow_hub/resolver.py in _get_module_path(self, handle)
    465       raise UnsupportedHandleError(
    466           self._create_unsupported_handle_error_msg(handle))
--> 467     return resolver.get_module_path(handle)
    468
    469   def _create_unsupported_handle_error_msg(self, handle):

/usr/local/lib/python3.6/dist-packages/tensorflow_hub/resolver.py in get_module_path(self, handle)
    383     """
    384     if self.is_supported(handle):
--> 385       return self._get_module_path(handle)
    386     else:
    387       raise UnsupportedHandleError(

/usr/local/lib/python3.6/dist-packages/tensorflow_hub/compressed_module_resolver.py in _get_module_path(self, handle)
    103
    104     return resolver.atomic_download(handle, download, module_dir,
--> 105                                     self._lock_file_timeout_sec())
    106
    107   def _lock_file_timeout_sec(self):

/usr/local/lib/python3.6/dist-packages/tensorflow_hub/resolver.py in atomic_download(handle, download_fn, module_dir, lock_file_timeout_sec)
    311     tf.logging.info("Downloading TF-Hub Module '%s'.", handle)
    312     tf.gfile.MakeDirs(tmp_dir)
--> 313     download_fn(handle, tmp_dir)
    314     # Write module descriptor to capture information about which module was
    315     # downloaded by whom and when. The file stored at the same level as a

/usr/local/lib/python3.6/dist-packages/tensorflow_hub/compressed_module_resolver.py in download(handle, tmp_dir)
     99
    100       url_opener = url.build_opener(LoggingHTTPRedirectHandler)
--> 101       response = url_opener.open(request)
    102       return resolver.download_and_uncompress(cur_url, response, tmp_dir)
    103

/usr/lib/python3.6/urllib/request.py in open(self, fullurl, data, timeout)
    524             req = meth(req)
    525
--> 526         response = self._open(req, data)
    527
    528         # post-process response

/usr/lib/python3.6/urllib/request.py in _open(self, req, data)
    542         protocol = req.type
    543         result = self._call_chain(self.handle_open, protocol, protocol +
--> 544                                   '_open', req)
    545         if result:
    546             return result

/usr/lib/python3.6/urllib/request.py in _call_chain(self, chain, kind, meth_name, *args)
    502         for handler in handlers:
    503             func = getattr(handler, meth_name)
--> 504             result = func(*args)
    505             if result is not None:
    506                 return result

/usr/lib/python3.6/urllib/request.py in https_open(self, req)
   1359         def https_open(self, req):
   1360             return self.do_open(http.client.HTTPSConnection, req,
-> 1361                 context=self._context, check_hostname=self._check_hostname)
   1362
   1363         https_request = AbstractHTTPHandler.do_request_

/usr/lib/python3.6/urllib/request.py in do_open(self, http_class, req, **http_conn_args)
   1318                           encode_chunked=req.has_header('Transfer-encoding'))
   1319             except OSError as err: # timeout error
-> 1320                 raise URLError(err)
   1321             r = h.getresponse()
   1322         except:

URLError: <urlopen error [Errno -5] No address associated with hostname>

UPDATE
Also tried
wget 'https://tfhub.dev/google/universal-sentence-encoder-large/3?tf-hub-format=compressed' -O /tmp/module.tar.gz
in my local and it is not working either.
resec@mpc:~$ wget 'https://tfhub.dev/google/universal-sentence-encoder-large/3?tf-hub-format=compressed' -O /tmp/module.tar.gz
--2018-08-15 01:57:33--  https://tfhub.dev/google/universal-sentence-encoder-large/3?tf-hub-format=compressed
Resolving tfhub.dev (tfhub.dev)... failed: No address associated with hostname.
wget: unable to resolve host address ‘tfhub.dev’

Same here.

Same here

TF Hub team is aware of tfhub.dev name resolution issue and is working on
addressing it. We will update this thread once the issue is fully
resolved. Apologies
for any inconvenience.
On Wed, Aug 15, 2018 at 7:47 AM bombdiggity<EMAIL_ADDRESS>wrote:

Same here
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/hub/issues/136#issuecomment-413100218, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AbunTAWN91qXYpk5irlK7uaab6UM1vDMks5uQ7XlgaJpZM4V9bar
.

tfhub.dev name resolution is back up. If you see any issues, please let us
know.
Apologies for any inconvenience.
On Wed, Aug 15, 2018 at 8:15 AM Andrey Khorlin<EMAIL_ADDRESS>wrote:

TF Hub team is aware of tfhub.dev name resolution issue and is working on
addressing it. We will update this thread once the issue is fully resolved. Apologies
for any inconvenience.
On Wed, Aug 15, 2018 at 7:47 AM bombdiggity<EMAIL_ADDRESS>wrote:

Same here
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/hub/issues/136#issuecomment-413100218,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbunTAWN91qXYpk5irlK7uaab6UM1vDMks5uQ7XlgaJpZM4V9bar
.

Thank you. This issue seems to be resolved.

Thank you. Confirmed!

thanks!

hmmm, sorry, I just checked on colab, my local, and remote machine on aws, seems the tfhub.dev name resolution is still down, the errors are the same as above, did I missed something?

oh , it is still down . @akhorlin

Yeah. Just checked. It's down again.

it's not working today i tried using but get same error

Yes, worked once and then down again.

We are investing again. We will update the thread once we know more.
On Wed, Aug 15, 2018 at 9:51 AM Hao Xi<EMAIL_ADDRESS>wrote:

Yes, worked once and then down again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/hub/issues/136#issuecomment-413121718, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AbunTBLBpxNo2mGxcbvVFYX5gEPVWRUlks5uQ9MXgaJpZM4V9bar
.

tfhub.dev should be back up and functioning as of 10:30 GMT+2. Please
report any further issues.
On Wed, Aug 15, 2018 at 10:49 AM Andrey Khorlin<EMAIL_ADDRESS>wrote:

We are investing again. We will update the thread once we know more.
On Wed, Aug 15, 2018 at 9:51 AM Hao Xi<EMAIL_ADDRESS>wrote:

Yes, worked once and then down again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/hub/issues/136#issuecomment-413121718,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AbunTBLBpxNo2mGxcbvVFYX5gEPVWRUlks5uQ9MXgaJpZM4V9bar
.

thanks! seems it is working stably again, closing this.

One reason could also be that Pow is installed. Uninstalling helps in this case.

@ThiagoSousa No, it is accessible.

$ curl -L "https://tfhub.dev/google/imagenet/inception_v3/feature_vector/1?tf-hub-format=compressed" | tar -zxvC /tmp/model
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0 curl: (6)    Could not resolve host: tfhub.dev
gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
$ ping www.google.com
PING www.google.com (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=44 time=59.2 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=44 time=58.8 ms
^C
--- www.google.com ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1001ms
rtt min/avg/max/mdev = 58.841/59.061/59.282/0.328 ms
$ ping https://tfhub.dev
ping: unknown host https://tfhub.dev

hi，@akhorlin can not download any model again，I have same problem like @santle

You might having some local (or ISP) mis-configuration issues. The download
seems to work as expected (at least from the EU):
curl -L "
https://tfhub.dev/google/imagenet/inception_v3/feature_vector/1?tf-hub-format=compressed"
| tar -zxvC /tmp/model123
% Total    % Received % Xferd  Average Speed   Time    Time     Time
Current
Dload  Upload   Total   Spent    Left
Speed
0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--
0
./
./saved_model.pb
0 77.3M    0 89972    0     0   178k      0  0:07:23 --:--:--  0:07:23
178k./variables/
./variables/variables.index
./variables/variables.data-00000-of-00001
100 77.3M  100 77.3M    0     0  60.1M      0  0:00:01  0:00:01 --:--:--
97.5M
./assets/
./tfhub_module.pb
On Mon, Nov 19, 2018 at 10:29 AM fengzhi09<EMAIL_ADDRESS>wrote:

hi，@akhorlin https://github.com/akhorlin can not download any model
again，I have same problem like @santle https://github.com/santle
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/hub/issues/136#issuecomment-439826996, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AbunTNUSPr73IL-jWGDuEuNEgrt5_53zks5uwnoTgaJpZM4V9bar
.

I have same installation fail to connect and to tensorflow wheel file , I'm using Ubuntu on Oracle VM box. Python 3.5, any help?

the file I'm trying to access is (tensorflow/linux/tensorflow-1.12.0-py3-none-any.whl) , I tried,   /mac/tensorflow-1.12.0-py3-none-any.whl   , /Linux/tensorflow-1.8.0-py3-none-any.whl   as well


Latest version of Flutter forbids pure_mixpanel version

Steps to Reproduce

I have done flutter upgrade
The pure_mixpanel is an important part of my project so now it is not allowing the app to run since it is forbidden for the newer version of the dart.
Tried doing flutter channel master flutter upgrade
Tried doing flutter packages get an error was thrown

Logs

The current Dart SDK version is 2.3.1-dev.0.0.flutter-a0290f823c.

Because flutter_app depends on pure_mixpanel >=1.0.0 which requires SDK version >=1.19.0 <=2.2.1, version solving failed.
Running "flutter packages upgrade" in flutter_app...
pub upgrade failed (1)

alok$ flutter doctor -v
[✓] Flutter (Channel master, v1.5.9-pre.193, on Mac OS X 10.14.4 18E226, locale en-US)
    • Flutter version 1.5.9-pre.193 at /Users/alok/flutter
    • Framework revision 3a6acb8c25 (9 minutes ago), 2019-05-09 09:23:30 -0700
    • Engine revision 644db5a49c
    • Dart version 2.3.1 (build 2.3.1-dev.0.0 a0290f823c)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/alok/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.0, Build version 10A255
    • ios-deploy 1.9.4
    • CocoaPods version 1.6.0

[!] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] Connected device (1 available)
    • iPhone 6s • 9A574CD8-03A5-45F6-B9BB-73E72D7E858D • ios • iOS 12.0 (simulator)

! Doctor found issues in 1 category.

Updating packages to support newer SDKs is up to the package maintainer; this isn't an issue on the Flutter side. Issues like this should be filed in the project of the package itself (in this case, it looks like someone has already done that: https://github.com/seenickcode/pure_mixpanel/issues/8)


Update README.markdown

Fixed 2 typos
Critical Changes
Changes
Issues Closed

Thank you for your contribution @Amanda-Styles!!!

Hello @Amanda-Styles - I am very sorry but need to close this PR for technical reasons. Your changes (and some more typoes) are incorporated over here: https://github.com/SFDO-Community/declarative-lookup-rollup-summaries/pull/1073
We will soon create a HowTo to detail the steps needed to create a PR on this repo. Thank you very much and once again sorry for the inconvenience.


Breakpoints or errors cause Godot window to be flagged as "Not Responding" by Windows

Tested versions
This happens to me in 4.2.2 and 4.2.1 but not in 3.5.3.
System information
Godot v4.2.1.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated Radeon RX 580 Series (Advanced Micro Devices, Inc.; 31.0.21910.5) - AMD Ryzen 5 1400 Quad-Core Processor (8 Threads)
Issue description
Basically if there is an error OR a breakpoint, the runtime goes "not responding" and needs to close. It makes it impossible to debug anything. Screenshot of a project with nothing but a breakpoint causing this:

Steps to reproduce
Add a breakpoint in any line of code that will run, and run the project
Minimal reproduction project (MRP)
n/a

CC @bruvzg

This should be already fixed by https://github.com/godotengine/godot/pull/94452

Duplicate of #73374 then.


Started work on items

Got a few functions to 100% and started defining structs.

Thanks! I might move some of the item_static / itembase files around, I meant for the actor/ folder to only contain the processes, though d_a_* picked up a bit too much.

Thanks! I might move some of the item_static / itembase files around, I meant for the actor/ folder to only contain the processes, though d_a_* picked up a bit too much.

Yeah that's fine by me, I wasn't sure what the exact directory structure should be.


scripts: pytest: execute 'zephyr.exe' in application build directory cwd

Execute zephyr.exe in application build directory as 'current working
directory' (cwd). This makes sure that native_sim specific drivers (like
flash simulator with file backend in flash.bin) are using unique context
for external resources with relative paths.
This fixes executing native_sim tests in twister with flash simulator.
Previously a shared flash.bin was used for all executed zephyr.exe
processes in twister. After this patch a unique flash.bin file is used
for each tested sample, since those flash.bin is placed in application
build directory instead of twister root directory.

@gchwier  @PerMac  please review


Move toolchains documentation URL from failure message to suggestion list

Fixes #24560

@bot-gradle test rFM

I've triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test and mereg

@bot-gradle test and merge

I've triggered a build for you.


Manually roll an arangodb cluster

I only had a quick chance to look at the docs, but it seems to be heavily focused on using the planner and kickstarter to launch the cluster.
I am interested in using nomad which is a task scheduler to run the cluster using docker.
Is it possible to configure and set up the cluster manually?

The current development of arangodbs clustering is heading into the direction of mesosphere; You may want to have a look at Max' blogpost about that to consider in your deployment strategy; Future tooling in ArangoDB will be based on that. (Yes, its also using docker containers)

Previously, I looked at mesos and in fact opened a few issues on the ArangoDB-mesos project. However, I think nomad is much easier to deploy and manage (single binary), so I am using that to build a PoC cluster.
Is there simply no way to set up the cluster manually via configuration files?

We also use vagrant (now otto ?) from hashicorp for some of the VM images we offer. In general, you need to start the agency with the parameters, tell arangod where to find it and which ports it should bind. You may get a head start by looking at what planner and kickstarter puzzle out for them, and do similar. Regarding what the cluster middleware for Mesosphere does, (and will learn to do) @neunhoef or maybe @m0ppers will be able to offer deeper insights. If you plan to develop configuration engines for nomad, we'll be happy to assist.

It's great to here there's the possibility to get a cluster going manually. I am planning to build some docker images to work with nomad and consul, so that it's easy to deploy an ArangoDB cluster onto nomad.
I haven't had a change to look at the source of planner and kickstarter, but will have a look soon. I think it would be great if a manual deployment scenario (without kickstarter and planner) can be added to the manual.

Since we're currently not going to start documentation efforts on this, here some pointers where to read .js source (you will have to have a localy compiled arangodb git clone with configure using --enable-maintainermode - see README_maintainers.md for more details)

<EMAIL_ADDRESS>invoked from the shell via ./scripts/unittest.js shell_server --cluster true
startInstance() is used to set up the cluster using the kickstarter and the planner:

<EMAIL_ADDRESS>configuration builder for the cluster nodes.
<EMAIL_ADDRESS>to launch the instances of arangodb and etcd.

However, this may be subject to change in the future. We're also currently working on a mini-mesos setup, which uses docker images for its machines.

:+1: for factoring out the cluster logic.  I'm a fan of Consul also and it would be great to have Arango locate its cluster through Consul service (DNS) directory and have the Arango cluster health status incorporated into Consul health checks.
I do really appreciate that Arango can cluster itself without requiring the user to separately manage a HA k/v store.  However, any user with defense against failure scenarios (hence, cluster) probably already is running a HA config store of some kind.

I just wanted to comment in this issue as well and note that we have recently devised a tool that makes it much easier to deploy ArangoDB clusters. See https://github.com/arangodb-helper/ArangoDBStarter and https://www.arangodb.com/2016/12/starting-arangodb-cluster-easy-way/

Closing the issue now since the we now have the ArangoDBStarter and the questions have basically been answered.


How to implement a position or velocity PID controller in Python binding?

I'm trying to implement a position and velocity PID controller in m=MuJoCo. Due to the SISO nature of actuators in the MuJoCo environment, I know that each component of the PID controller can be separated into 3 different actuators. While the P and D controllers can be built with the combination of the pre-defined actuator/position and actuator/velocity, how can one implement the integral controller?
And to my knowledge, the PID controller can also be implemented by a general actuator as well by using user defined callbacks mjcb_act_gain and mjcb_act_bias. How can one go about implementing these callbacks within the python binding for MuJoCo? And how can one define what the control input is for a general controller (ex. whether the control is position for position PID or velocity for PI control)

You can add an integrator to actuators which will integrate ctrl, but the integral of the joint position is something you'll have to compute in user code.
Callbacks from python
Read the relevant docs and or the code

Thank you for the response. Regarding the first bullet point, can't I simply use the joint position as the ctrl to the actuator then?
Also, per documentation, to simulate a MIMO controller, we use a combination of actuators such as a position and velocity for a PD controller. It says that the velocity actuator would take the reference velocity of the robot. Does this mean the desired velocity or the current velocity of the joint?
If my robot were to be position controlled, wouldn't the input to the D controller be the derivative of the positional error, not the velocity, which would make it velocity controlled instead?

Regarding the first bullet point, can't I simply use the joint position as the ctrl to the actuator then?

Not exactly, what you want to integrate the error right. But yes, if you compute the error you can pass that and you have your I controller.

Does this mean the desired velocity or the current velocity of the joint?

Desired.

If my robot were to be position controlled, wouldn't the input to the D controller be the derivative of the positional error, not the velocity, which would make it velocity controlled instead?

Correct.
I strongly recommend that you make a trivial model with say one horizontal slider joint and a known mass (so everything is trivially analytical), and then experiment with this model to see that actuation behaves in the way you expect.


Support --pretty expanded output

Sometimes it's useful to get the --pretty expanded output. It would be nice if there was a button to do this.

Absolutely :+1:

Closing as --pretty is unstable but we have rustfmt now instead


Prompt categories

I've come up with the following categories for prompts:

Frameworks
Libraries
APIs (HTML5 and third-party)
Tasks

Here's some examples for each:
Frameworks

Examples

Angular
React
Meteor
Ionic
Cordova
Cycle.js
Express
Koa

Prompts

Todo App
Dig into the docs
Try new things
Something else

Libraries

Examples

Lodash/Ramda
Natural
Image processing

Prompts

Make a cool demo
Dig into the docs
Make a tutorial / blog post

APIs

Examples

WebRTC
Oxford API
Geolocation
FileReader / FileWriter
WebGL

Prompts

Build something cool
Make a tutorial / blog post

Tasks

Data Science (analyze dataset)
Make a website / app
Draw up an architecture

Anybody want to fork my Meteor project? https://github.com/abraxasrex/selfcinema

React & Web RTC anyone??

Shape Detection, Geolocation, and SocketIO!

Thanks, guys! Keep 'em coming!

Made a sphere using webgl, added link to tutorial I followed here:  https://github.com/YonasBerhe/spherewebgl

^awesome! I'm looking into making a tetris game with webgl in the near future.


wasmd installation issues

runtime/cgo
gcc_libinit_windows.c: In function '_cgo_beginthread':
gcc_libinit_windows.c:143:27: error: implicit declaration of function '_beginthread'; did you mean '_cgo_beginthread'? [-Werror=implicit-function-declaration]
143 |                 thandle = _beginthread(func, 0, arg);
|                           ^~~~~~~~~~~~
|                           _cgo_beginthread
cc1: all warnings being treated as errors
make: *** [Makefile:96: install] Error 1

Windows is not supported yet. make install works only on linux and macOS


Add developer info for creating a new JLL release

I just came across smesh and I'm excited to see it in action!

Thanks for the review!

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d0387db) 45.94% compared to head (e48b0f8) 45.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   45.94%   45.94%
=======================================
  Files           3        3
  Lines        1269     1269
=======================================
  Hits          583      583
  Misses        686      686

Flag
Coverage Δ

unittests
45.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


pi algo -> pi

Looking at the coherence in between the excel sheet and the data generated by the code
PI Algorithm pi_fpeis said to generate [pi_FPE_ap.yaml,pi_FPE_ml.yaml, pi_l_MOS_ap.yaml, pi_l_MOS_ml.yaml, pi_r_MOS_ap.yaml, pi_r_MOS_ml.yaml].
The two  first ones PIs are not described in the excel sheet. We find a PI pi_fpe that is not used. Should it be duplicated?

The excel sheet has been updated. The '_ap' and '_ml' extensions indicate in which direction the PI is calculated (_ap: anteroposterior direction, _ml: mediolateral direction). Hope it works for you now.

Ok, good
It seems the pi_r_fpm is not in the excel anymore. I guess I can copy pi_l_fpm, updating left with right?

Yes, you can.

Done


Remove version: BellSoft.LibericaNIK.22.Full version 24.0.2

Moved to https://github.com/microsoft/winget-pkgs/pull/166337

Related to #165799

Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/bell-sw/LibericaNIK/releases/download/24.0.2+1-22.0.2+11/bellsoft-liberica-vm-full-openjdk22.0.2+11-24.0.2+1-windows-amd64.msi
OK
(Automated message - build 912)

https://github.com/microsoft/winget-pkgs/pull/166337


pdf1 no 103

I am reading pdf1, 10.4 Lab
`4. Submit job, JCL(CBL0001J), within the DATA SET section.

View that job output using the JOBS section.

• COBRUN:SYSPRINT(101) - COBOL program compiler output
• RUN:PRTLINE(103) - COBOL program execution output, `

They speak about 103 output

I've tried on the machine, I've just 101 and 102 but no 103.
Can you try and confirm please ?

You should be able to see 101, 102, 103.
If you still can't see it, can you post some screenshot over at the #cobol-programming-course channel on the Open Mainframe Project Slack?
We can help you faster there :)

You should be able to see 101, 102, 103.
If you still can't see it, can you post some screenshot over at the #cobol-programming-course channel on the Open Mainframe Project Slack?
We can help you faster there :)


moved 1155 deployments into protocol-deployments/1155

Current dependencies on/for this PR:

main

PR #314

PR #305

PR #317   👈
PR #315
PR #307
PR #262

PR #299

PR #312

PR #303

PR #309

PR #289

PR #294

PR #295

PR #273

PR #288

PR #284

PR #280

This stack of pull requests is managed by Graphite.

will re-do in the future


Create Search Query

Create a query that allows the user to filter through their applications.

This is not necessary for the MVP and I want to get a better idea of how the front end will work before I start creating filters and queries.

We ended up just creating a search bar that filters applications if it finds a word from the search bar.


Deleting node without head pointer in linked list

issue === #659

I did the required changes.
please review it again.

resolve conflict

can u give any hint I am unable to figure out the issues?
On Thu, May 6, 2021 at 10:42 AM ShriKrushna Bhagwat <
@.***> wrote:

resolve conflict
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Algo-Phantoms/Algo-Tree/pull/1547#issuecomment-833229768,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOBXJENVFCPBMP3BETP7BYTTMIQLPANCNFSM42RNRQRA
.

https://github.com/Algo-Phantoms/Algo-Tree/pull/1870
I was a little confused so I created fresh or with changes. Please review it.


[Feature request] MFA/2FA/Google Authentificator

Hi!
This is a quick request :)
Would it be possible to add Google Authenticator ? ( https://github.com/scheb/2fa )
Have a good day,
Samuel

Yes, it looks like a fairly simple integration. I am not in a position to deal with it at the moment, but I can take a look at it next week. Thanks for the link :wink:


Bigger sizes

Another one that'll be a hell of a lot of work, but bigger sizes going up on powers of 2 from existing sizes (96, 128, 192, 256) would be cool.

@jbt Coming on 3 years later on this and I understand why there is no SVG, although larger PNG sizes would be nicer.
How were these built? Did you make the 64's then script to scale down?

Every single one was done individually in Photoshop, at all the different sizes. That's obviously very time-consuming and doesn't make it particularly easy to just run stuff off at bigger sizes (what can I say, it seemed like a good idea at the time). And unfortunately, we simply haven't had the time or resources to put into a proper update, much as we'd like to :(

That's fine - I understand :) Shame there is no way of easily scaling these up.


Add network PulseChain

Add PulseChain network to the list of networks.

Yes please :)

Yes, I second this.  One of the most important L1s right now,

Pulsechain is the most important L1 chain. So please add.

Kindly add Pulsecahian, it would be most appreciated.

This would be tremendous.

Pulsechain has a ton of activity and users. Do it!

Add PulseChain network to the list of network please.

Thanks for posting this PR.

Yes, please add Pulsechain


Update package.json github references

Specially the bugs and homepage since they point to a 404 right now
https://github.com/styled-components/stylelint-processor-styled-components/blob/master/package.json#L29-L31

Oh yeah haha. We just fixed up #85 but didn't see it was also those 2 places. Cheers!

Duplicate of #48

Duplicate of #48
Oh yeah you're right, you already had this pointed out. In that case I'll close #48 :).

Yeah the issue was a bit vaguely worded. I should've just taken care of it immediately, thanks for handling it!


Crash possibly related to upgrade from Beta 2 to Beta 7

I recently released a new version of my company's app and some users have run into a crash when the app starts.  I personally haven't been able to reproduce the crash, but it happened to my manager and part of the crash log is below.  The new version upgrades ASDK to 2.0.2 (from 1.9.81) and PINRemote Image from Beta 2 to Beta 7.  It seems like it might be related to the way defaultImageCache in PINRemoteImageManager changed to delete the disk cache.  Based on the stacktrace, it would appear to occur at  https://github.com/pinterest/PINRemoteImage/blob/ed2e439faf2462097c8cbe5ce7a526299a2f2267/Pod/Classes/PINRemoteImageManager.m#L251 , since that's the only place removeItemAtURL is used by PINRemoteImage.
Do you have any insight as to why this might happen, or if it might be something on my end that's not correct?
Partial crash log attached, we had trouble getting it to symbolicate.
crashlog.txt

@KristopherGBaker it's really hard to tell without a stack trace. I would be more inclined to guess this has something to do with the race condition in PINAnimatedImageManager. Was your manager loading any GIFs?

I'll see if I can get the full stack trace.  We aren't loading any GIFs.

Full desymbolicated crash log attached.  Based on the exception code 0x8badf00d, the problem is that the app is taking too long to start and thus being killed by the system.  My best guess at this point is if the old disk cache is large, it may be taking too long to remove it while the app is starting in some cases.
crashlog-full.txt

@KristopherGBaker are you still seeing this crash? Beta 9 has attempted to address this.

@garrettmoon I am no longer seeing this crash, and am currently using beta 9.

Awesome! Thanks for reporting back.

Just information for anyone who faced this issue:
I also experienced this issue, and PR #391 and 3.0 beta 12 fixed it.


Add a modal

Is your feature request related to a problem? Please describe.
Most people depend face difficulty creating modal using just HTML, CSS and JS.
Describe the solution you'd like
Clicking a button should open a modal.

Pls assign this issue to me @akkaraju-satvik

Pls assign this issue to me @akkaraju-satvik

I have already implemented this.


Fix test timeout

Integration test timeouts are defined by env.Timeout so they it can be adjusted according to each environment's needs.

Codecov Report

Merging #989 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   49.82%   49.77%   -0.05%
==========================================
  Files          29       29
  Lines        2033     2033
==========================================
- Hits         1013     1012       -1
- Misses        839      840       +1
  Partials      181      181

Impacted Files
Coverage Δ

core/client/client.go
29.37% <0%> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367e689...2bb48f7. Read the comment docs.


Add render support for all of the string config options for external materializations

Fixes #55
Obvi we have a workaround that is fine, but I think it will be more intuitive for folks if the location arg (and any other string options for external) work just like pre_hook and post_hook and allow configuration via jinja template args.

Good idea @jwills! So you can use eg. this.identifier in the location?

Good idea @jwills! So you can use eg. this.identifier in the location?

exactly; location="/here/is/some/path/to/{{ this.identifier }}.parquet" will work seamlessly


Fix invalid pose data when controllers are becoming inactive

Fix #110.

I'm not a fan of including the controller models into the plugin, they are specific to one platform with no consensus yet by OpenXR on how controller models will be exposed through the OpenXR API. There is also no sure way to pick the correct controller model for the controller actually used.
IMHO they belong in platform specific libraries or made available as a separate asset.
We should start looking into that as it seems that Microsoft and Oculus now have two competing APIs for exposing controller models while Valve is I believe working on something as well, we should be able to come up with something that allows us to request a controller model (or scene in this case now that both are GLTF based) and it deciding how this data is loaded depending on which extension is available.

I'm not a fan of including the controller models into the plugin, they are specific to one platform with no consensus yet by OpenXR on how controller models will be exposed through the OpenXR API. There is also no sure way to pick the correct controller model for the controller actually used.
IMHO they belong in platform specific libraries or made available as a separate asset.
We should start looking into that as it seems that Microsoft and Oculus now have two competing APIs for exposing controller models while Valve is I believe working on something as well, we should be able to come up with something that allows us to request a controller model (or scene in this case now that both are GLTF based) and it deciding how this data is loaded depending on which extension is available.

The included controller models are just for the demo, not to be used as plugin provided models. I put them in that location because that's where the parent scene is, but they can be moved in the demo only directory.
The bug went on for so long because we didn't have controller models to visualize, hence didn't realize it was happening. I included them in the demo to prevent that from happening.

The included controller models are just for the demo, not to be used as plugin provided models. I put them in that location because that's where the parent scene is, but they can be moved in the demo only directory.
The bug went on for so long because we didn't have controller models to visualize, hence didn't realize it was happening. I included them in the demo to prevent that from happening.

Ah, apologies, I didn't realize the path. Hmm it'll look weird having mismatching controllers when you're on a different platform but I guess it's better then showing nothing.. Indeed not visualizing what is going on does make it easy for bugs to go unnoticed.

I've addressed the feedback on the PR. It should be ready to go!

Thanks!


Manipulating List View Elements

I'm not entirely sure how I want to do this (probably needs some more component-ing of each element), but a few things I want to accomplish in regards to manipulating the list view elements:

[ ] Allow the toggling on/off of list view elements
[ ] Have the rest of the elements fill the entire space
[ ] Allow the dragging and repositioning of elements
[ ] Allow custom sizing

I've given this some thought, and other custom sizing, I think most of this is unnecessary. I'm going to bin this issue for now.


Cannot Set AgConfiguration in Sql VM AG Listener

AgConfiguration seems to be used to configure Automatic Failover, Sync Commit, Readable Secondary mentioned in https://docs.microsoft.com/en-us/azure/azure-sql/virtual-machines/windows/availability-group-azure-portal-configure?view=azuresql&tabs=azure-cli#create-availability-group, however it's marked as readOnly and cannot be set in PUT api.
Swagger: https://github.com/Azure/azure-rest-api-specs/blob/2f2b633d940230cbbd5bcf1339a2e1c48674e4a2/specification/sqlvirtualmachine/resource-manager/Microsoft.SqlVirtualMachine/preview/2021-11-01-preview/sqlvm.json#L1049

@myc2h6o Apologies for the late reply. Thanks for reaching out to us and sharing this feedback. I see that the Service team has already been involved on this.
@azureSQLGitHub Could you please look into this and share an update ? Awaiting your reply.

Fixed by #19189


Patch 1

of -> in

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.7 out of 9 committers have signed the CLA.:white_check_mark: lvscar:white_check_mark: luics:white_check_mark: MrRaindrop:white_check_mark: Jinjiang:white_check_mark: YorkShen:white_check_mark: littleseven:white_check_mark: acton393:x: miomin:x: jiuyuegui

wrong branch to commit?


Cloud pod limitations

We need to investigate how this impacts us:
https://github.com/awslabs/amazon-eks-ami/blob/master/files/eni-max-pods.txt
https://learnk8s.io/kubernetes-node-size#:~:text=On Google Kubernetes Engine (GKE,be%20increased%20up%20to%20250

I think we're OK here.


Enable refresh_token usage for public clients

Does CF UAA have a configuration that allows for public clients who used PKCE in the authorization code grant flow (and thus don't have a client_secret) to use a refresh_token without requiring a client_secret in the refresh request?

Are you referring using the code_challenge without a client_secret? https://docs.cloudfoundry.org/api/uaa/version/76.5.0/index.html#overview

@jwdomes  I think you mean option from https://github.com/cloudfoundry/uaa/pull/1888 where you can omit client_secret in authz code flow. Because in refresh_token grant you are right, this is not prepared for public usage.
We need to have the information about client_auth in the token, because I dont want to allow a refresh flow without a secret in cases where the token was requested with a secret

@strehle - would there be any option to implement the refresh_token grant flow for public clients that makes use of the code_challenge and/or code_verification in lieu of the client_secret used for non-public clients?
@Tallicia -

Is an empty string solution sufficient for your need, or is there something more?
It appears that the CF CLI uses the refresh endpoint using a public client as well: https://github.com/cloudfoundry/cli/blob/main/api/uaa/refresh_token.go#L48 They do pass client credentials in the Authentication header with value of: "UAAOAuthClient": "cf", "UAAOAuthClientSecret": "" refresh_token.go request.SetBasicAuth(client.config.UAAOAuthClient(), client.config.UAAOAuthClientSecret())

Does this imply that the refresh_token can be obtained with an empty client_secret?

@jwdomes yes I can do this, however the refresh would work for tokens which are received only via authorization_code.
The cf client - typically used for "cf login" is if no changes are done a oauth2 client with an empty secret "" and "authorized_grant_types: password refresh_token".
This means, you should use here the known empty secret for a refresh flow. This client has normally no authorization_code in the list.
The term public and PKCE is bound to grant type "authorization_code". This combination should replace the implit flow.
In such scenarios you completly omit the parameter "client_secret" and/or Authorization header.
So my fix would allow a refresh flow only for such tokens. Tokens via password grant , e.g. "cf login " are bound to password grant and for this grant type the standard has no public usage allowed.
btw: https://oauth.net/2.1/ is not yet official.
If you use spring security in your client, then you can see how it works if you set in your application.yml

client-secret is omitted (or empty)
client-authentication-method is set to none (ClientAuthenticationMethod.NONE)

see:
https://docs.spring.io/spring-security/reference/servlet/oauth2/client/authorization-grants.html

First PR ready: https://github.com/cloudfoundry/uaa/pull/2385
-> store the client authentication in UAA context.
Next we then use this and check for refresh flow that public tokens can be refreshed

created a PR  https://github.com/cloudfoundry/uaa/pull/2402 and to be on safe side , also with standard
https://oauth.net/2.1/ , this will be allowed only if

token before was generated without a secret
refresh rotation is enabled


[Bug]:

What happened?
Nightly checks are failing for test TestPreparedBackupSharepointE2ESuite\TestSharepointDetailsCmd_lists.
Corso Version?
latest
Where are you running Corso?
Github actions
Relevant log output
In CI:

 tester.go:44: TestPreparedBackupSharepointE2ESuite/TestSharepointDetailsCmd_lists run at 2024-01-18T04:20:55.38868359Z
  Logging to file: /home/runner/work/corso/corso/src/testlog/run-nightly.log
  Error: no items in backup
      sharepoint_e2e_test.go:340:
          	Error Trace:	/home/runner/work/corso/corso/src/cli/backup/sharepoint_e2e_test.go:340
          	            				/home/runner/work/corso/corso/src/cli/backup/sharepoint_e2e_test.go:309
          	Error:      	Received unexpected error:
          	            	no items in backup
          	            		/home/runner/work/corso/corso/src/cli/backup/backup.go:31
          	Test:       	TestPreparedBackupSharepointE2ESuite/TestSharepointDetailsCmd_lists
          	Messages:   	{msg:"no items in backup", labels:[], values:{clues_trace:8220455b}}

Unable to reproduce in local. CORSO_E2E_TESTS & CORSO_NIGHTLY_TESTS are set to true.
=== RUN   TestPreparedBackupSharepointE2ESuite
    tester.go:44: TestPreparedBackupSharepointE2ESuite run at 2024-01-22T18:26:32.878346484Z
    tester.go:44: TestPreparedBackupSharepointE2ESuite run at 2024-01-22T18:26:32.878389986Z
    tester.go:44: TestPreparedBackupSharepointE2ESuite run at 2024-01-22T18:26:38.392993262Z
    storage.go:38: testing at s3 bucket [corso-testing-hiteshp] prefix [corso_integration_test/TestPreparedBackupSharepointE2ESuite-2024-01-22T18:26:38.392993262Z]
=== RUN   TestPreparedBackupSharepointE2ESuite/TestSharepointDetailsCmd_lists
    tester.go:44: TestPreparedBackupSharepointE2ESuite/TestSharepointDetailsCmd_lists run at 2024-01-22T18:27:16.047683691Z
Logging to file: /home/hitesh/.cache/corso/logs/2024-01-22T18-26-32Z.log
=== RUN   TestPreparedBackupSharepointE2ESuite/TestSharepointDetailsCmd_lists/detail_0
--- PASS: TestPreparedBackupSharepointE2ESuite (61.41s)
    --- PASS: TestPreparedBackupSharepointE2ESuite/TestSharepointDetailsCmd_lists (18.24s)
        --- PASS: TestPreparedBackupSharepointE2ESuite/TestSharepointDetailsCmd_lists/detail_0 (0.00s)
PASS
ok  	github.com/alcionai/corso/src/cli/backup	61.457s

Recurring instances:

1/18/2024, 10:19 AM
1/19/2024, 10:14 AM


.clap plugin

hey! is it possible to make this a .clap plugin too?

That's not planed, sorry.

what framework is this built off of?

Basically it's XUiDesigner https://github.com/brummer10/XUiDesigner so plain LV2.
but heavily modified to suit the needs.
However, as I've put the Neural-Amp-Modeler and the RTNeural loaders into self contained C++ classes it wont be to hard to reuse them in other projects. Same is true for the convolver class and the dcblocker.

what is RTNeural?

contained C++ classes
so does rhat mean i can easily make a clap with them?

RtNeural is a other Neural Network Modeler engine: https://github.com/jatinchowdhury18/RTNeural
You can download models for it here for example: https://cloud.aida-x.cc/all
It is not so wide spread then NAM as it is newer, but it is really good as well, and extreme lightweight in CPU consumption.

so does rhat mean i can easily make a clap with them?

when you are a developer and know how to write/read C++, yes.


Feature: Add paging

Needed because you want to fetch the graph for a longer time period and then zoom in.
Fetching all logs for example a week is just too much data.
Idea:
Only fetch first 1000 rows for the log.
Issue event from background worker when we should fetch next 1000.
Use the count that's already implemented by the worker.

Paging not possible with AppInsights.
Solved by limiting number of rows downloaded (max 5000)
fetch is now done in background thread to not hang UI when receiving large responses.
Resolved in #8


Added support for arbitrary attributes and !important styles

Mostly a fix for #6. I couldn't find any way to set arbitrary attributes in a browser environments. This adds a special attrs property with special handling analogous to that of style.
I also added support for !important flags on styles. Currently if you say something like style: { 'width: 800px !important' }, setProperty will ignore the style entirely.

merged into 2.0.2, sorry I missed this for so long!


another mistake - Heart On Your Sleeve

As soon as I noticed the achievement wasn’t working, I got frustrated! Either update to show that it’s not functional, or provide clear instructions on how to unlock it! Liking Issues didn’t produce any results.

Fixed https://github.com/Schweinepriester/github-profile-achievements/commit/c52c6767883d49245ec7ccb8a2f4b97c595559d3


how to train without mask ?

Just like the title mentions , how can we train without masks for custom datasets ?
Im assuming it comes from JSON COCO segmentations, which is an empty list.
I tried dict(type='LoadAnnotations', with_bbox=True, with_mask=False) and removed 'gt_mask', so that im left with dict(type='Collect', keys=['img', 'gt_bboxes', 'gt_labels'], but to no luck.
Still, after running python tools/train.py configs/plastic/mask_rcnn_r50_caffe_fpn_mstrain-poly_1x_plastic.py
I get following error:
  File "tools/train.py", line 220, in <module>     main()   File "tools/train.py", line 216, in main     meta=meta)   File "/home/dev/Development/Python/anaconda/open-mmlab/mmdetection/mmdet/apis/train.py", line 208, in train_detector     runner.run(data_loaders, cfg.workflow)   File "/home/dev/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 127, in run     epoch_runner(data_loaders[i], **kwargs)   File "/home/dev/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 50, in train     self.run_iter(data_batch, train_mode=True, **kwargs)   File "/home/dev/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/runner/epoch_based_runner.py", line 30, in run_iter     **kwargs)   File "/home/dev/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/parallel/data_parallel.py", line 75, in train_step     return self.module.train_step(*inputs[0], **kwargs[0])   File "/home/dev/Development/Python/anaconda/open-mmlab/mmdetection/mmdet/models/detectors/base.py", line 248, in train_step     losses = self(**data)   File "/home/dev/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl     return forward_call(*input, **kwargs)   File "/home/dev/anaconda3/envs/open-mmlab/lib/python3.7/site-packages/mmcv/runner/fp16_utils.py", line 109, in new_func     return old_func(*args, **kwargs)   File "/home/dev/Development/Python/anaconda/open-mmlab/mmdetection/mmdet/models/detectors/base.py", line 172, in forward     return self.forward_train(img, img_metas, **kwargs)   File "/home/dev/Development/Python/anaconda/open-mmlab/mmdetection/mmdet/models/detectors/two_stage.py", line 150, in forward_train     **kwargs)   File "/home/dev/Development/Python/anaconda/open-mmlab/mmdetection/mmdet/models/roi_heads/standard_roi_head.py", line 113, in forward_train     gt_masks, img_metas)   File "/home/dev/Development/Python/anaconda/open-mmlab/mmdetection/mmdet/models/roi_heads/standard_roi_head.py", line 173, in _mask_forward_train     self.train_cfg)   File "/home/dev/Development/Python/anaconda/open-mmlab/mmdetection/mmdet/models/roi_heads/mask_heads/fcn_mask_head.py", line 144, in get_targets     gt_masks, rcnn_train_cfg)   File "/home/dev/Development/Python/anaconda/open-mmlab/mmdetection/mmdet/core/mask/mask_target.py", line 60, in mask_target     pos_assigned_gt_inds_list, gt_masks_list, cfg_list) TypeError: 'NoneType' object is not iterable
I though before I change anything else in the core, its best to ask what the solution is before I hack/ruin the entire code.
Clearly segmentation coordinates arent required in the coco json annotation files ??
Its working but Im sure its a bad idea on how I did it :D
I added [0,0,0,0,0,0] to all the segmentations in the json file, able to train now though.

@whiteplatin If you don't want mask, you should use faster rcnn instead of mask rcnn

Thanks!  Thats what I ended up doing yesterday. Just wanted to see if theres another way.


feat(controlsList): passing through Chrome's controlsList attribute

Google Chrome allows an attribute 'controlsList', which allows you to
blacklist certain controls, like the download button. This change passes
the attribute through so that it can be used with ReactAudioPlayer.
https://googlechrome.github.io/samples/media/controlslist.html
Originally filed in #35, but I closed that one since React didn't support the attribute.
However, support was added in 15.6.2, so this should be good now.

Thanks for following up on this!  Works for me locally and the PR looks perfect.  I'll go ahead and merge this and then make a new release shortly.


The requested module '' does not provide an export named ''

Describe the bug
Ever since updating to the latest SvelteKit my project has had nothing but random error after random error. Sometimes a "SemiColon missing" or "export not provided" or you name it. A meaningless change such as adding a space, removing the space, and rebuilding makes it work -- until I make any changes again, then a new random error shows.
So I decided to just start over from scratch with a fresh folder, new create svelte@latest my-app -- but the issue came up here too. I installed adapter-static npm i -D @sveltejs/adapter-static and npm run build works fine. But when I start the preview server, I get the following:
error when starting preview server:
file:///~/svelte.config.js?ts=1670677968927:1
import adapter from '@sveltejs/adapter-static';
       ^^^^^^^
SyntaxError: The requested module '@sveltejs/adapter-static' does not provide an export named 'default'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)

Note: while this fresh project shows The requested module '@sveltejs/adapter-static' does not provide an export named 'default' - in my original project this would be random. One time it might be adapter-static, but the next it might be The requested module './endpoint.js' does not provide an export named 'is_endpoint_request'
Reproduction
To reproduce:

Run create svelte@latest my-app to install SvelteKit (skeleton, TypeScript, no lint, prettier, no Playwright)
Run npm i -D @sveltejs/adapter-static for Adapter Static
Update svelte.config to use adapter static adapter: adapter({  pages: 'build',  assets: 'build',  fallback: 'app.html',  precompress: true }) (the defaults)
Run npm run build then npm run preview

Logs
~MYPROJECTFOLDER % npm run build

> PROJECT build
> vite build

vite v4.0.0 building for production...
✓ 38 modules transformed.
10:28:29 PM [vite-plugin-svelte] dom compile done.
package         files     time     avg
@sveltejs/kit       2   35.2ms  17.6ms
PROJECT           2   28.0ms  14.0ms

vite v4.0.0 building SSR bundle for production...
✓ 45 modules transformed.
10:28:30 PM [vite-plugin-svelte] ssr compile done.
package         files    time     avg
PROJECT           2   6.4ms   3.2ms
@sveltejs/kit       2   3.7ms   1.9ms
Generated an empty chunk: "hooks".
.svelte-kit/output/server/vite-manifest.json                   1.27 kB
.svelte-kit/output/server/chunks/hooks.js                      0.00 kB
.svelte-kit/output/server/entries/fallbacks/layout.svelte.js   0.24 kB
.svelte-kit/output/server/entries/pages/_page.svelte.js        0.32 kB
.svelte-kit/output/server/chunks/paths.js                      1.72 kB
.svelte-kit/output/server/entries/fallbacks/error.svelte.js    3.07 kB
.svelte-kit/output/server/chunks/index.js                      3.22 kB
.svelte-kit/output/server/index.js                            82.07 kB

Run npm run preview to preview your production build locally.
.svelte-kit/output/client/vite-manifest.json                                         2.27 kB
.svelte-kit/output/client/_app/immutable/chunks/1-b05b467d.js                        0.09 kB │ gzip:  0.10 kB
.svelte-kit/output/client/_app/immutable/chunks/0-04ae84d6.js                        0.09 kB │ gzip:  0.10 kB
.svelte-kit/output/client/_app/immutable/chunks/2-ff982b2b.js                        0.10 kB │ gzip:  0.10 kB
.svelte-kit/output/client/_app/immutable/components/layout.svelte-cd8f1078.js        0.54 kB │ gzip:  0.36 kB
.svelte-kit/output/client/_app/immutable/components/pages/_page.svelte-84041f18.js   0.83 kB │ gzip:  0.48 kB
.svelte-kit/output/client/_app/immutable/components/error.svelte-bb1aab01.js         2.13 kB │ gzip:  0.98 kB
.svelte-kit/output/client/_app/immutable/chunks/singletons-c1916556.js               2.58 kB │ gzip:  1.34 kB
.svelte-kit/output/client/_app/immutable/chunks/index-7f3551f2.js                    6.87 kB │ gzip:  2.79 kB
.svelte-kit/output/client/_app/immutable/start-df02c78a.js                          28.29 kB │ gzip: 10.91 kB

> Using @sveltejs/adapter-static
  Wrote site to "build"
  ✔ done
~MYPROJECTFOLDER % npm run preview

><EMAIL_ADDRESS>preview
> vite preview

error when starting preview server:
file:///~/svelte.config.js?ts=1670678915071:1
import adapter from '@sveltejs/adapter-static';
       ^^^^^^^
SyntaxError: The requested module '@sveltejs/adapter-static' does not provide an export named 'default'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:124:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:190:5)

System Info
System:
    OS: macOS 13.0
    CPU: (10) arm64 Apple M1 Max
    Memory: 33.77 GB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 19.1.0 - /opt/homebrew/bin/node
    npm: 8.19.3 - /opt/homebrew/bin/npm
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 108.0.5359.98
    Safari: 16.1
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.90
    @sveltejs/adapter-static: ^1.0.0-next.49 => 1.0.0-next.49
    @sveltejs/kit: next => 1.0.0-next.581
    svelte: ^3.54.0 => 3.54.0
    vite: ^4.0.0 => 4.0.0

Severity
blocking all usage of SvelteKit
Additional Information
I originally brought this up in Discord: https://discord.com/channels/457912077277855764/1050686836370055218, brought it here when it happened on a fresh setup.
This is preventing me from working on an update to my app that I am supposed to launch in 5 days to my customers. 🥹
I hope it's an easy fix, I am frazzled... no idea what else to try.
Thank you.

Works fine for me with the following envinfo:
  System:
    OS: macOS 12.5.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 79.53 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 19.1.0 - ~/.nvm/versions/node/v19.1.0/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.0/bin/yarn
    npm: 8.19.3 - ~/.nvm/versions/node/v19.1.0/bin/npm
  Browsers:
    Chrome: 108.0.5359.98
    Chrome Canary: 110.0.5468.0
    Firefox: 107.0.1
    Safari: 15.6.1
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.90
    @sveltejs/adapter-static: ^1.0.0-next.49 => 1.0.0-next.49
    @sveltejs/kit: next => 1.0.0-next.581
    svelte: ^3.54.0 => 3.54.0
    vite: ^4.0.0 => 4.0.0

IOW identical package versions, and I installed Node 19.1.0 to verify that wasn't the issue.
 Are you seeing anything similar with other projects?

Ah, I don't have any other projects currently... packed those away some time ago.
But I wouldn't put it past Node being the culprit. Could be a coincidence that it started after an npm update to get the latest SvelteKit.
Interestingly, the errors have gone away "-ish." 😀 By that I mean every once in a while it pops up, but not every time. I can work again, but I feel like I'm coding on eggshells (as if to be extra safe or something lol).
Probably unrelated, but I had to comment out vitePreprocess() in new svelte.config because I was getting Sourcemap for "/~/src/lib/components/COMPONENTNAME.svelte" points to missing source files for every component (below works fine).
preprocess({
	postcss: true
})

Bringing it up in case it gives any clues.
Thank you for the reply Rich, I appreciate it. 🙏

Closing as the original issue has been resolved and we can't reproduce it.

For anyone ending up here after searching for

The requested module '@sveltejs/kit/vite' does not provide an export named 'vitePreprocess'

update vitePreprocess import statement to import { vitePreprocess } from '@sveltejs/vite-plugin-svelte'
for more info refer https://kit.svelte.dev/docs/migrating-to-sveltekit-2#vitepreprocess-is-no-longer-exported-from-sveltejs-kit-vite

For anyone ending up here after searching for

The requested module '@sveltejs/kit/vite' does not provide an export named 'vitePreprocess'

update vitePreprocess import statement to import { vitePreprocess } from '@sveltejs/vite-plugin-svelte'
for more info refer https://kit.svelte.dev/docs/migrating-to-sveltekit-2#vitepreprocess-is-no-longer-exported-from-sveltejs-kit-vite

That was also my problem and your suggestion solved it for me, thank you @Nikhil1920

For anyone ending up here after searching for

The requested module '@sveltejs/kit/vite' does not provide an export named 'vitePreprocess'

update vitePreprocess import statement to import { vitePreprocess } from '@sveltejs/vite-plugin-svelte'
for more info refer https://kit.svelte.dev/docs/migrating-to-sveltekit-2#vitepreprocess-is-no-longer-exported-from-sveltejs-kit-vite

Thank youuu!

For anyone ending up here after searching for

The requested module '@sveltejs/kit/vite' does not provide an export named 'vitePreprocess'

update vitePreprocess import statement to import { vitePreprocess } from '@sveltejs/vite-plugin-svelte'
for more info refer https://kit.svelte.dev/docs/migrating-to-sveltekit-2#vitepreprocess-is-no-longer-exported-from-sveltejs-kit-vite

MVP, thank you!


Removed incorrect "Transform" preview from visual shaders

Transform outputs cannot be previewed - by doing so the editor will emit error and draw a white rect instead any valid result - this PR removes the eye icons as well as previews generation

Thanks!


A menu item to install plugins

Is your feature request related to a problem?
I'm very happy when a new version is delivered! But I need to download all plugins again.
Describe the solution you'd like:
I would like a menu to install the plugins easier. A kind of choice list with the compatible plugins.

Hi @RodrigoCarlstrom,
in the meantime you can move the plugin code into your APP_DATA_DIRECTORY (C:\users\username\AppData\roaming\camunda-modeler\resources\plugins): https://github.com/camunda/camunda-modeler/tree/master/docs/plugins#plugging-into-the-camunda-modeler. Usually it's hidden on Windows, but you can enable it in the explorer.
Then the plugins are available for all installations.

Hi @ingorichtsmeier , can you point out where can I find this on Mac?
I'm using the 4.6 Modeler version.
Thanks!

Hi @cunhaandrey,
have a look at this docs page: https://github.com/camunda/camunda-modeler/tree/master/docs/search-paths.
Seems to be ~/Library/Application Support/camunda-modeler/resources
As a windows user I can't try it out by myself.
Hope this helps, Ingo

Hi @ingorichtsmeier ,
Thanks for the reply. Unfortunately, it is not like that, there is no "resources" folder. This is what "we" got as Mac Users:
cd ~/Library/ApplicationSupport/camunda-modeler/
➜  camunda-modeler tree
.
├── Cache
│   ├── 3d9a301dc614a54d_0
│   ├── 5c4cf5a965e844b5_0
│   ├── dc003a4af54ec73a_0
│   ├── fba8f33e70274862_0
│   ├── index
│   └── index-dir
│       └── the-real-index
├── Code\ Cache
│   └── js
│       ├── index
│       └── index-dir
│           └── the-real-index
├── Cookies
├── Cookies-journal
├── GPUCache
│   ├── data_0
│   ├── data_1
│   ├── data_2
│   ├── data_3
│   └── index
├── Local\ Storage
│   └── leveldb
│       ├── 000003.log
│       ├── CURRENT
│       ├── LOCK
│       ├── LOG
│       ├── LOG.old
│       └── MANIFEST-000001
├── Network\ Persistent\ State
├── SS -> /var/folders/t3/y511ksts1lx7y2prj2xjwjdw0000gn/T/.com.camunda.CamundaModeler.UiAMTA/SS
├── Session\ Storage
│   ├── 000003.log
│   ├── CURRENT
│   ├── LOCK
│   ├── LOG
│   ├── LOG.old
│   └── MANIFEST-000001
├── SingletonCookie ->
├── SingletonLock ->
├── blob_storage
│   └── d72f921b-c8b8-4015-980c-291d66dca7db
└── config.json
11 directories, 32 files
I will keep looking. Let me know if you have any Camunda who works on Mac.
Thanks,
Andrey

You need to create that directory if it does not exist. Let's keep the issue focussed. If you have additional question regarding how to use our tools, please refer to our forum.


apply scc command is incorrect

when using the command list in open shift markdown file to create SCC resources,  i met this error:
[rockets@openshift1 scc]# oc apply -f --validate=false .
error: Unexpected args: [.]
See 'oc apply -h' for help and examples.
after modify command like this - oc apply -f --validate=false .     it's passed

Thanks for the issue.  Fixed


QUB/TVA, "Unsupported URL"

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
Canada
Provide a description that is worded well enough to be understood
Qub/TVA no longer seems to be supported.
Example URL: https://www.tvaplus.ca/tva/le-baiser-du-barbu/le-baiser-du-barbu-886644190
Using a VPN, making my laptop look like it's coming from Montreal, Canada. The video URL of works within my Windows Firefox web browser.
Qub/TVA worked about one year ago. I had yt-dlp<EMAIL_ADDRESS>at that time, and put in the "extractor" folder the tva.py file in this patch.
This issue I'm reporting is different than this issue, that also reports that Qub/TVA doesn't work, but instead reports that it doesn't work due to failed JSON metadata.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp -vU --write-sub "https://www.tvaplus.ca/tva/le-baiser-du-barbu/le-baiser-du-barbu-886644190"

[debug] Command-line config: ['-vU', '--write-sub', 'https://www.tvaplus.ca/tva/le-baiser-du-barbu/le-baiser-du-barbu-886644190']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [f0993391e] (pip)
[debug] Python 3.11.9 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 3.0.13 30 Jan 2024)
[debug] exe versions: ffmpeg 6.0-full_build-www.gyan.dev (setts), ffprobe 6.0-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.18.0, brotli-1.0.9, certifi-2023.05.07, mutagen-1.46.0, requests-2.32.3, sqlite3-3.45.1, urllib3-2.1.0, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1829 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[generic] Extracting URL: https://www.tvaplus.ca/tva/le-baiser-du-barbu/le-baiser-du-barbu-886644190
[generic] le-baiser-du-barbu-886644190: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] le-baiser-du-barbu-886644190: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://www.tvaplus.ca/tva/le-baiser-du-barbu/le-baiser-du-barbu-886644190
Traceback (most recent call last):
  File "C:\Users\stepi\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\yt_dlp\YoutubeDL.py", line 1626, in wrapper
    return func(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\stepi\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\yt_dlp\YoutubeDL.py", line 1761, in __extract_info
    ie_result = ie.extract(url)
                ^^^^^^^^^^^^^^^
  File "C:\Users\stepi\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\yt_dlp\extractor\common.py", line 740, in extract
    ie_result = self._real_extract(url)
                ^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\stepi\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.11_qbz5n2kfra8p0\LocalCache\local-packages\Python311\site-packages\yt_dlp\extractor\generic.py", line 2526, in _real_extract
    raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://www.tvaplus.ca/tva/le-baiser-du-barbu/le-baiser-du-barbu-886644190

... except that the metadata is now in ['pageProps']['staticEntity'] instead of ['initialProps']['pageProps']['fallbackData'].
The qub.ca pages now redirect to tvaplus.ca.