Reactive Javalin with Kotlin coroutines

At this moment it's just a quick follow up to the conversation on Discord about the async context and the natural expansion of non-blocking io that became an industry standard.
Benefits:

Limit various huge thread-pools that impacts the memory footprint
Simplify async requests by a providing a dedicated api

Candidates:

Kotlin Coroutines (preferred, probably the best solution atm)

Pros: Should be really simple to implement, great support from Kotlin and its libraries
Cons: It's Kotlin, so Java apps can't really benefit from this feature. It should be probably provided in a dedicated module.

RxJava

Pros: Works in every JVM based environment, it's known because of the Spring WebFlux
Cons: Quite a huge library, not as great as coroutines and I have no idea if it is hard to implement.

Loom

Already implemented, but still unstable and requires whole dedicated JVM.

Some related conversations in the past:

Inspired by Spring WebFlux support for project reactor
Reactive Streams
Async event-loop

@dzikoysk this ticket is a bit different from what we discussed on Discord. It has always been my intention for Javalin to offer a simple and blocking model, which is sufficient for the majority of use cases. If your service has a couple of slow endpoints, or your are lucky enough to use a HTTP or DB library that supports futures, we have the ctx.future(future) method, which I think works fairly well (at last after the recent changes).
A general rewrite to be more async friendly is not something I think will be positive for the project. The simple change from ctx.result(future) to ctx.future(future) sparked a lot of discussion in different GitHub issues and on different chat servers, with a lot of confusion and a lot of people talking past each other. I think the project should stay simple and blocking, both for the sanity of the community, and it's primary maintainer (😅). I'm not knowledgeable enough about Java async to feel confident in providing a good solution.
The cons you listed for Kotlin Coroutines and RxJava are huge, so I will fight hard to keep this out of the core. If someone wants to make a module then that's still possible.
Personally I am a big fan of Loom, which is why Loom is enabled by default now (if it's present in the runtime). For people who need a mature and reactive setup on older Java versions I would rather point them to Vert.x.
All of this being said, I still see value in having a simple method lifting the request out of the request threadpool, so I'm very open to that.

@tipsy First of all, I don't want to make you feel I'm pushing you to implement this. As you already said, you don't have experience with this part of web development, so we need a common ground to discuss related topics. At this moment, the reactivity is just a magic blackbox for you. I understand also why you're a fan of Loom - you can just benefit from the concept without really exploring it. I'll try to a little describe the scenario and possible solution and if you're still sure you don't want to see it in the project, it probably means I failed in the explanation part.
About

this ticket is a bit different from what we discussed on Discord

It's not really different, because marking a HttpRequest as async and then processing it independently is exactly what nio stands for and where reactive solutions just simplifies the handling. By rejecting similar issues and refusing to at least partly (e.g. Kotlin only) support this concept, we're also no more lightweight web framework, as the resources consumption in a real world app is just much higher than in the used widely these days reactive alternatives.
Scenerio
As an example, Jetty by default starts with thread-pool that may scale probably up to 200 threads. Now, by integrating various services like standard db, tasks let's why have around another 100 threads. We already wasted more than 250MB of memory just to keep these OS level threads and where most of them are just blocked awaiting for response. Of course, that's the case when the app really do something, in a test env the app doesn't consume it, because there is no real traffic. In a contrast, standard reactive microservice uses fixed thread-pool around 16 threads for the whole application.
In general

Blocking server: good for CPU-heavy operations where we can maximize the performance gained by running task in a dedicated thread. In case that we don't really use CPU, it just wastes a lot of resources and makes async programming literally a pain by handmade implementations and utilities of concurrent systems. That's just bad for everyone.
Non-blocking server (reactive): Slower, because of thread context switching and various mechanisms, but thanks to the improved architecture, we can use make a better use of created threads.

Web developers realized that the standard server in most cases just awaits for a result from another source rather than uses CPU and do something heavy. These days we use microservices deployed to the cloud, so we just want to limit resources consumption where we can.
Assumptions

The implementation has to be simple, a few lines of code that just delegates the processing to another place.
The implementation should not affect any of the existing methods.

Just one new method in API or none in case of some kind of a auto detection

Solution
I'll talk about coroutines as I'm quite sure an implementation is even simpler than the current future api implementation. I also don't really now about the internals of RxJava and how to boot it up. I guess it might be similar to submitting a task to a dedicated ExecutorService (like in Loom).
What is suspended function? It's a built-in into the language modifier that marks method as a method that might be run into the async context:
suspend fun doSomething() { } // that's all, as user you don't really have to know anything more about

The usage might look like this:
suspend fun handle(ctx: Context) {
  // findAll is also suspend, so there is a suspend call chain and Kotlin handles it
  // we don't need to do anything more, Kotlin is going to manage this automatically under the hood
  val result = mongoRepository.findAll()
}

We can also provide .async method dedicated for suspend functions. It might be registered using Kotlin extension functions, so the Java users won't even see this in their api.
fun handle(ctx: Context) {
  ctx.async { // async starts , also suspend
    val result = mongoRepository.findAll()
  }
}

To launch such a method we just need to create a dispatcher that is based on some ExecutorService:
httpRequest.startAsync()

launch(dispatcher) {
  handle.invoke(ctx)
}

That's pretty much all, user can now limit the thread-pool assigned to Jetty to let's say 16 threads (based that he has 16 logical cpus) and then set up the dispatcher size also to 16 threads. The app now runs on 32 threads and the outcome should be similar to the app that runs on 300 threads. Of course, to compare exact values we'd need a benchmark, but it should be something around these values.
Summary
In this section I'll rather talk about my opinion on the topic and personal preferences, as the content above was meant to be "objective" - as far as possible of course.

The simple change from ctx.result(future) to ctx.future(future) sparked a lot of discussion in different GitHub issues and on different chat servers, with a lot of confusion and a lot of people talking past each other

I don't really think it's really related. That's confusing, because it changes existing API. It also still bases on CompletableFutures that are great utility to say that we don't have value yet, but it doesn't really change the handling process and its cost.

Personally I am a big fan of Loom, which is why Loom is enabled by default now (if it's present in the runtime).

It sounds great, but it's still unstable and we don't have any guarantee about it, so it's unusable in production environments. Another thing is, do you really want to submit any non-marked as async code having a promise it'll work properly. Using various languages and libraries we always have to explicitly define if it should be run in async context. We just read the code and see how it should be invoked. It's just a loose thought about "silent fibers", not really related to the topic of this issue.
That's all for now I think, I hope it removes the magic aspect of the implementation and as you see, it should be even easier to support than the good api for futures which was kinda problematic for a while.

Using various languages and libraries we always have to explicitly define if it should be run in async context.

Not with Loom no. The JVM runtime internally knows where a virtual thread yields and does it.  That is, as part of loom the jdk internals have been modified to yield at all the places needed such as IO, lock, Thread.sleep() etc [with the caveat around the use of sychronized]. So like golang / goroutines.

The app now runs on 32 threads and the outcome should be similar to the app that runs on 300 threads.

Only if it is reactive all the way. So for example we can not use jdbc and need to change to use something like r2dbc (or perhaps use a store that provides a reactive driver like mongo as in your examples above). As a side note, for myself I've looked pretty closely at r2dbc and for example their own benchmark does not have it as fast as jdbc. r2dbc vs jdbc is almost another full separate topic but ultimately if a stack is using jdbc then it is not going to be "reactive all the way".

The app now runs on 32 threads

We get exactly this same effect with Loom with arguably some benefits:

We just need to start using ExecutorService based on virtual threads (so basically no change to existing apps)
We can use any and all existing libraries including JDBC drivers (with a caveat around synchronized keyword wrapping IO).
For debugging, try catch, stack traces we get the same simplicity we have today (and seems like the main reasons some people revert back from reactive stacks)
Anything that uses ThreadLocal like MDC still work
AOP style things like @Transactional and @Timed still work
Maybe virtual thread park/unpark cost is cheaper than thread context switch cost (this is expected as part of Loom but unproven yet?)

If you are in the reddit r/java community you would have seen there has been a lot of discussion on Loom and reactive frameworks like Webflux and Vertx.  What is rather interesting is the number of people who have tried spring webflux etc and then decided to go back. It does not seem to be 1 way adoption if that sample is accurate.
Anyway, one of the more recent discussions: https://www.reddit.com/r/java/comments/m3n0jw/will_loom_make_vertx_rxjava_and_event_loop_based/

It sounds great, but it's still unstable and we don't have any guarantee about it

To me unstable is the wrong word. I've been playing around with the last few EA releases and it's been perfectly stable. I'm using the latest EA release for a Loom demo tomorrow and it is pretty darn impressive.  Sure, it almost certainly won't be in the officially released 17 but 18 might be realistic and that is maybe 8 months away?

kotlin suspended function

To me this comes under the "coloured function problem" (https://journal.stuffwithstuff.com/2015/02/01/what-color-is-your-function/). Java (like golang) remains a language without methods marked/annotated/indicated as being async (unlike C#, javascript and kotlin coroutines).
Ultimately it depends on what time frame a project works to in terms of stack choice and API design and if you believe Loom makes all the reactive libraries somewhat legacy (including kotlin coroutines).
I definitely recommend trying loom if you haven't already.

All you've listed here is more like a follow up to the Loom references in my thread. I've tested it and various other projects as I'm a quite a huge fan of these researches - not gonna lie that Valhalla is my favorite. Anyway, it is not a production ready solution for now, it's still a choice for people who hosts their apps locally and may agree on some consequences caused by their choices. My proposal is not against Loom, but it's directed to people who don't want to build the entire application around Loom, because of various reasons.

Only if it is reactive all the way. [...]

That's true, but it's not related to this issue. User has to cover this cases, not the maintainer of Javalin.

We get exactly this same effect with Loom with arguably some benefits

Of course they're, native fibers are just great and doesn't require some kind of stub abstraction layer created on top of the language that does not support such a features.

What is rather interesting is the number of people who have tried spring webflux etc and then decided to go back. It does not seem to be 1 way adoption if that sample is accurate.

Many people tried many technologies and they didn't liked it. The fact about RxJava and reactive programming in general is that the topic is really hard and requires a lot of experience to do it right. As I said in my previous comment - I don't think that Javalin is the best place to implement this anyway.

Coloured function problem [...] Ultimately it depends on what time frame a project works to in terms of stack choice and API design and if you believe Loom makes all the reactive libraries somewhat legacy

In general, all references to the technology that is not widely used are based on a believe and hope. It might be even a case for Kotlin, because the belief that someday Java will catch-up the functionalities that Kotlin provides (and it is happening right now in the official Java releases), will just make it redundant. I'm talking about people that require the solution now and the existing possibilities are just fine for them.
In theory, let's say that Loom might be merged into the official Java releases and we're sure it won't be even a case in the next LTS (17), but rather around 19. It means that in a next few years people still won't be able to use this in this project, that's kinda sad. Even if we'll finally see Loom in Java 19, it doesn't mean that the whole community will use Java 19. Various teams are just fine by using older LTS releases for a while.
That was a perspective of end-users, what about library maintainers and so on. Loom won't make them disappear, it might just reduce their audience in the future.
In the end, why do we assume that proposed coroutines are against fibers. Probably that's the most painless way to write that reactive-like code these days. The dispatcher may use Loom's ExecutorService as well in the future.

I think the project should stay simple and blocking, both for the sanity of the community, and it's primary maintainer (😅). I'm not knowledgeable enough about Java async to feel confident in providing a good solution.

Just wanted to chime in and mention that being a newbie to Java, coming from Node.js and Go where I didn't have to think very much about concurrency, I really like Javalin because of how easy it is for me to understand. I appreciate the effort that's been put into keeping the framework simple and lightweight when it comes to programming model (even if it isn't "lightweight" when it comes to efficient use of OS resources, as pointed out by @dzikoysk). I like that it's sticking around and fulfilling that niche.

@mattwelke this proposal is not against any of the value represented by Javalin, I'd say it's just another area to cover as a simple enhancement to simplify async usage and related scenarios using a tiny layer.

As a research and some kind of PoC for this thread, I'm currently during tests of the one of javalin-rfcs module that provides simple routing based on coroutines:

https://github.com/reposilite-playground/javalin-rfcs

The coroutines support is developed as a plugin and does not require modified version of Javalin. The API is quite stable at this moment, so I decided to use it in a real-world app, so on, I'm implementing this as a part of my open source project (on experimental branch, as well as the rewritten OpenApi plugin that uses annotation-processor):

https://github.com/dzikoysk/reposilite/tree/3.0

More details about progress and results I share on Javalin's Discord server.

@dzikoysk This is really cool and I think it might be worth using Discussions on GitHub for the details, that way people who aren't on the Discord or who don't know where to find the conversations on Discord can see it here.
@tipsy Thoughts on adding Discussions to this repo?

@mattwelke Thanks :) I don't quite like GH Discussions as I feel it's more for projects that really need to move away "spam" related to questions about framework and how to use it rather than topics about its development. I also use mostly Discord to communicate on various servers, so I prefer to post it there.
Speaking of the issue, I don't think this feature will be a part of official Javalin as I don't see the interest in this topic, probably because of the narration around Loom and how it solves related conversations in the further years without changing anything.
I'm quite sure that even if I fully test my reactive-routing plugin it's just not possible to merge it in the current form. This plugin somehow solves problems raised by #1267 and #1278 and proposes an abstraction on top of that. To be honest, the builtin implementation could be much more simple, probably just a few lines, but its design should be a part of conversation where contributors agree that it's something they want to implement. As we can see, it's more like a fun fact and there is no involvement in this area, so I guess it just won't happen.  That's ok, luckily it's possible to use it as a plugin what's enough for me :)

Does the Javalin project have a concept of official plugins?  You're right that there isn't a huge interest in Kotlin coroutine Javalin, but there is some interest. And I bet that among those who are interested, they'd prefer using an official plugin if they could.

Kind of through https://github.com/javalin. Probably the organization may find more attention when #1297 will happen. Anyway, that's still part of my research as a part of Reposilite project and its playground repository as mentioned above, so I don't think it could be used as an official plugin - it uses, and probably will use even more, various non-common extensions such as e.g. expressible to provide better experience in developing an app that I can relay on with a pretty straightforward implementation. Speaking of the official plugin, I think it should limit external dependencies to the minimum and provide only the functionality it stands for.

@mattwelke Does the Javalin project have a concept of official plugins?

No, but it's something I want to look into after releasing Javalin 4.

@mattwelke Thoughts on adding Discussions to this repo?

I agree with @dzikoysk here, I think issues (or discord) are better than Discussions. We don't have the amount of traffic that justifies introducing it, IMO.

the ctx.result(future) already allows using suspending functions using the jdk future coroutine library

the ctx.result(future) already allows using suspending functions using the jdk future coroutine library

As I said before using, this is what we're currently testing with plugin api - javalin-rfcs :: javalin-reactive-routing. Unfortunately only http routes can be covered with this, as other handlers such as before & after does not support async requests (even if it is exposed in Context in these routes). Another topic is that even ctx.resultFuture() was not thread-safe for like 3 years (#1385) and still has some problems (discussion on Javalin's discord server).

also, one of the best parts about javalin is its simple blocking nature -- if i wanted a tonne of async - I would just use vertx instead

Introducing any of the proposed changes does not affect blocking context, so referring that in this thread is kinda pointless. I could somehow agree with this statement if it would be a conversation about introducing async context at the first place, but as we can see it's available for a while and people use it so there is an area to provide enhancements. There is also a slightly difference between building a fully reactive engine and providing a partial support initializing such a context.
Anyway, also I said, I'm quite sure we won't see such enhancements to the core project, but I'm still for improving the current implementation to provide/simplify the possibility of introducing such a support through plugin api.

Experimental coroutines-based routing implementation is now available as a submodule of javalin-routing-extensions plugin. Example usage:

https://github.com/javalin/javalin-routing-extensions#coroutines


Disable service binding related integration tests

What type of PR is this:
/area testing
The purpose of this PR is to test the impact of removing the integration tests related to service binding.
It introduces an SKIP_SERVICE_BINDING_TESTS environment variable which indidate to skip tests related to service binding.
This variable has been set to true for OpenShift and Windows tests on IBM Cloud, to disable these tests for PRs.
The tests will still run during the nightly tests.

e2e_test.go:Context("starting with non-empty Directory add Binding", func() { can use skipping.

No, I would like to keep the tests for e2e tests.

Also, wouldn't you need to modify IBM pipelines to export the env var? I believe the tests are still run on OpenShift, since I do not see any difference between the number of k8s and oc tests.

In case you missed.

Also, wouldn't you need to modify IBM pipelines to export the env var? I believe the tests are still run on OpenShift, since I do not see any difference between the number of k8s and oc tests.

In case you missed.

I defined the env var in the pipelines, but after the job has been created. It seems the env variables are considered at the time the job is created (not the time it is started).
Let me try again

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests
[FAILED] [74.869 seconds]
User guides: Quickstart test Java quickstart guide [It] should test the complete java springboot quickstart output in order
/go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:217

  [odo]  âš   0/3 nodes are available: 3 pod has unbound immediate PersistentVolumeClaims. preemption: 0/3 nodes are available: 3 Preemption is not helpful for scheduling.


Import new Android overlay

This was recently added in swiftlang/swift#72161 and swiftlang/swift#72634. I've been building it with this patch on my daily Android CI since then, finagolfin/swift-android-sdk#151, and natively on Android too.
@ahoppen, should be an easy review.

@swift-ci Please test


[CI] C++ code style (naming) investigation

What

Define our C++ and C naming conventions for code within the OpenAssetIO code base.

Timeboxed to half a day
Why
Our code should be consistent, and a documented standard is required so we can (at a later date) add CI checks etc.
Acceptance Criteria

An agreed naming convention for C++ and C code.
Contribution documentation updated to cover the convention.

Out of scope

Automated checks

Addressed in #227


rock64 not responsive / doesn't boot, but LEDs light up

maybe i'm missing something obvious - extremely possible - but my board is unusable since upgrade to the 195 kernel from 188
there is simply no hdmi output and the board does not connect to the network. the leds turn on, with ethernet connected both ethernet leds turn on after a few seconds, and without ethernet just the green ethernet led
this happens on both the original sdcard with ayufan's stretch, and another sdcard with a number of different distros (ayufan 6.27 stretch, ayufan xenial, armbian ubuntu, armbian stretch nightly) copied over a number different ways (suse image studio, dd, etcher)
i've tried different sd cards, different sd->usb adapters, different power sources, different network switches and different displays
additionally, i have no uart output, except some gibberish when power or tx is connected - although i haven't used uart before so i can't really expand too much on this [this is most likely due to incompat uart adapter (c2102), new ones are in transit]
hope i'm proven idiot on this one

You are not. The 0.6.26 is completely broken, because of broken kernel init. It is having crash loop.
This issue is fixed in 0.6.27.

to clarify, the issue isn't that i can't boot 6.26 - it's that i can't boot anything

.0.6.21 doesn't work either

Hi, I am facing the same issue after upgrading to 195. Now the board can only boot from Emmc and it just keep rebooting. And I am no longer able to boot from SD to flash Emmc again (https://forum.pine64.org/showthread.php?tid=4924). Any instruction to recover the board in this situation?

I just booted the 0.6.28 easily. It worked OK.

Thx for ur reply. I don’t hv the usb->Emmc adapter. I used to follow the tutorial in the previous post to flash Emmc again if the upgrade fail to boot. Any instruction that can allow me to boot from SD again then flash the latest image?

Remove eMMC, and use SD only.

Hi, I tried another SD card and managed to boot now. Flashing latest image now. Thx

Why is this closed again?

It seems, the problem has something to do with HDMI. when  i switched the resolution, i los the screen entirely. I had to disconnect power for 1 minute before i could get the screen back and i got a rose stripe on the left screen. Could be display driver...

board looks like it's dead...there is nothing on uart with ch340g adapter
power usage looks to be ~.05A on power-on jumping to ~.065A when the ethernet LEDs kick in and

Similar thing happened to me.
I was unable to boot anything since i purchased it.

32GB SanDisk micro SD
Standard power cable
2A Powerbrick
Rock64
Tried multiple different OSs (last try was Raspbian latest)
When connected to power (With every OS I tried):
All led's light up statically. No HDMI output.
Me and a friend bought two units from the official store. His worked. Mine didn't. (He used the exact same configuration)

32GB SanDisk micro SD
Standard power cable
2A Powerbrick
Rock64
Tried multiple different OSs (last try was Raspbian latest)
When connected to power (With every OS I tried):
All led's light up statically. No HDMI output.
Me and a friend bought two units from the official store. His worked. Mine didn't. (He used the exact same configuration)

I bought ROCKPRO64 and I have the same issue with that , did you get it

Same here, Brought a ROCK64 4G back in April and recently got an RMA board which took like a month to return once I sent off my old one. That is also not working with literately ANYTHING, tried different SD cards, EMMC modules, Power Supplies, HDMI Cables, Monitors just everything. Biggest waste of money tbh..

Connect UART. See what is failure.
Use your friends SD card.
On Sun, Oct 28, 2018 at 9:23 PM Michael Dexter<EMAIL_ADDRESS>wrote:

32GB SanDisk micro SD
Standard power cable
2A Powerbrick
Rock64
Tried multiple different OSs (last try was Raspbian latest)
When connected to power (With every OS I tried):
All led's light up statically. No HDMI output.
Me and a friend bought two units from the official store. His worked. Mine
didn't. (He used the exact same configuration)
I bought ROCKPRO64 and I have the same issue with that , did you get it
Any success? I am in the same boat, having tried xubuntu, bionic-minimal
and RaspBSD. At most I get a green LED and the network port LEDs.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ayufan-rock64/linux-build/issues/145#issuecomment-433738166,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACTpQQa5GeeuKA5N2P1lSCD1ZWlRHxVxks5uphJPgaJpZM4TA09d
.

Hi
Just to say im also affected:
Rock64 not the pro version with 4 GIG ram.
Noting boots or gives a live sign.
Images i tried:
ROC-RK3328-CC-ubuntu18.04-LXDE_20180920.img
ROC-RK3328-CC_Debian9-Arch64_20180525.img
stretch-minimal-rock64-0.7.8-1061-arm64.img
Armbian_5.65_Rock64_Debian_stretch_default_4.4.162_desktop
stretch-minimal-rock64-0.7.9-1067-arm64.img

I have same problem. rockpro64 4g emmc 12v/4A. Tried all roms.
The first boot - everything good.
After some time, board is stuck. Sometimes stucking reproduced when send "poweroff" command on board.
And board looks like died. Nothing help.  Power LED and ethernet are lighted only. No white LED.
Refreshing emmc rarely helps. Helps wait some time. And boot works.
I have UART but when I geting this problem - a board shows only on every reset:
DDR Version 1.12 20180518
In

Once I saved this log, may be it can help: https://p.devtrue.net/ihx6ta3/

Update:
I was able to boot the openmediavault jessi armhf build. After that i installed u-boot and now i can boot Armbian images without changeing anything.
I packed the whole thing in a little guide for octoprint as this is my use case for the rock:
-> https://github.com/foosel/OctoPrint/wiki/Setup-on-Rock64-running-Armbian
Hopes this helps some of you :-)

It worked for me openmedia and am running ubuntuu 18.04 LTS and wifi is
also working. but had problem with video, it’s playing fast
On Mon, Nov 5, 2018 at 12:00 PM Manuel<EMAIL_ADDRESS>wrote:

Update:
I was able to boot the openmediavault jessi armhf build. After that i
installed u-boot and now i can boot Armbian images without changeing
anything.
I packed the whole thing in a little guide for octoprint as this is my use
case for the rock:
->
https://github.com/foosel/OctoPrint/wiki/Setup-on-Rock64-running-Armbian
Hopes this helps some of you :-)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ayufan-rock64/linux-build/issues/145#issuecomment-435951553,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Am8N1K8IgrlgjJ7V8zcvzckmmz90z6q-ks5usG6qgaJpZM4TA09d
.

Really, only under openmediavault rock64_write_spi_flash.sh works, there is a difference, on others:
libmtd: error!: MEMERASE64 ioctl failed for eraseblock 10 (mtd0)
error 110 (Connection timed out)

flash openmediafault arm64 image and attach to hdmi display
you will get terminal screen where u can run ur commands
sudo apt-get upgrade
sudo apt-get update
sudo apt-get install aptitude tasksel
tasksel
now choose operating system that u want to install
install ubuntu , u will get success
On Wed, Nov 7, 2018 at 3:11 AM Lev Lybin<EMAIL_ADDRESS>wrote:

Really, only under openmediavault rock64_write_spi_flash.sh works, there
is a difference, on others:
libmtd: error!: MEMERASE64 ioctl failed for eraseblock 10 (mtd0)
error 110 (Connection timed out)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ayufan-rock64/linux-build/issues/145#issuecomment-436539246,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Am8N1C-6KqdRB-kCJHWEH3fY0cZE369qks5uspWggaJpZM4TA09d
.

Thx, I can install and I can boot. But if do power off(not always reproduced), or await - board doesn't will respond, boot doesn't work again.
On pine64 / armbian / dietpi forums I found same issues, no answers, because not all have trouble. https://forum.pine64.org/showthread.php?tid=5258
I have Forsesee 16 gb too from official store.
UART shows in this time:
DDR Version 1.12 20180518
In
Logs on emmc empty - nothing strange before stuck.
I turn off power supply, await 20-30 minutes, turn on, and a board works again, white LED lighted up.
I have only two logs attached above with kernel crash.
Under all images (rockpro64) I can't flash spi, m25p80 spi32766.0: flash operation timed out
I just experimented and notice that.
I was able to flash spi only under LibreELEC, also https://github.com/ayufan-rock64/linux-u-boot/releases , but under linux in this repository - I got errors.

MR24=0x8
MR25=0x0
CS = 1
MR0=0x18
MR4=0x2
MR5=0xFF
MR8=0x8
MR12=0x72
MR14=0x72
MR18=0x0
MR19=0x0
MR24=0x8
MR25=0x0
channel 0 training pass!
channel 1 training pass!
change freq to 400MHz 0,1
channel 0
CS = 0
MR0=0x98
MR4=0x2
MR5=0xFF
MR8=0x8
MR12=0x72
MR14=0x72
MR18=0x0
MR19=0x0
MR24=0x8
MR25=0x0
CS = 1
MR0=0x18
MR4=0x2
MR5=0xFF
MR8=0x8
MR12=0x72
MR14=0x72
MR18=0x0
MR19=0x0
MR24=0x8
MR25=0x0
channel 1
CS = 0
MR0=0x98
MR4=0x2
MR5=0xFF
MR8=0x8
MR12=0x72
MR14=0x72
MR18=0x0
MR19=0x0
MR24=0x8
MR25=0x0
CS = 1
MR0=0x18
MR4=0x2
MR5=0xFF
MR8=0x8
MR12=0x72
MR14=0x72
MR18=0x0
MR19=0x0
MR24=0x8
MR25=0x0
channel 0 training pass!
channel 1 training pass!
change freq to 800MHz 1,0
ch 0 ddrconfig = 0x101, ddrsize = 0x2020
ch 1 ddrconfig = 0x101, ddrsize = 0x2020
pmugrf_os_reg[2] = 0x3AA1FAA1, stride = 0xD
OUT
U-Boot SPL board init

U-Boot SPL 2017.09-rockchip-ayufan-1025-g482cd6ec8b (Jul 26 2018 - 08:18:48)
booted from eMMC
Trying to boot from MMC1
NOTICE:  BL31: v1.3(debug):d98d16e
NOTICE:  BL31: Built : 15:03:07, May 10 2018
NOTICE:  BL31: Rockchip release version: v1.1
INFO:    GICv3 with legacy support detected. ARM GICV3 driver initialized in EL3
INFO:    Using opteed sec cpu_context!
INFO:    boot cpu mask: 0
INFO:    plat_rockchip_pmu_init(1151): pd status 3e
INFO:    BL31: Initializing runtime services
WARNING: No OPTEE provided by BL2 boot loader, Booting device without OPTEE initialization. SMC`s destined for OPTEE will return SMC_UNK
ERROR:   Error initializing runtime service opteed_fast
INFO:    BL31: Preparing for EL3 exit to normal world
INFO:    Entry point address = 0x200000
INFO:    SPSR = 0x3c9

U-Boot 2017.09-rockchip-ayufan-1025-g482cd6ec8b (Jul 26 2018 - 08:18:55 +0000)

Model: Pine64 RockPro64
DRAM:  3.9 GiB
DCDC_REG1@vdd_center: ; enabling
DCDC_REG2@vdd_cpu_l: ; enabling
DCDC_REG3@vcc_ddr: ; enabling (ret: -38)
DCDC_REG4@vcc_1v8: set 1800000 uV; enabling
LDO_REG1@vcc1v8_dvp: set 1800000 uV; enabling
LDO_REG2@vcc3v0_touch: set 3000000 uV; enabling
LDO_REG3@vcc1v8_pmu: set 1800000 uV; enabling
LDO_REG4@vcc_sd: set 3300000 uV; enabling
LDO_REG5@vcca3v0_codec: set 3000000 uV; enabling
LDO_REG6@vcc_1v5: set 1500000 uV; enabling
LDO_REG7@vcca1v8_codec: set 1800000 uV; enabling
LDO_REG8@vcc_3v0: set 3000000 uV; enabling
SWITCH_REG1@vcc3v3_s3: ; enabling (ret: -38)
SWITCH_REG2@vcc3v3_s0: ; enabling (ret: -38)
vcc1v8-s0@vcc1v8_s0: set 1800000 uV; enabling (ret: -38)
dc-12v@dc_12v: set 12000000 uV; enabling (ret: -38)
vcc-sys@vcc_sys: set 5000000 uV; enabling (ret: -38)
vcc3v3-sys@vcc3v3_sys: set 3300000 uV; enabling (ret: -38)
vcc-phy-regulator@vcc_phy: ; enabling (ret: -38)
vdd-log@vdd_log: ; enabling (ret: -38)
MMC:   sdhci@fe330000: 0, dwmmc@fe320000: 1
SF: Detected gd25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB
*** Warning - bad CRC, using default environment

In:    serial@ff1a0000
Out:   serial@ff1a0000
Err:   serial@ff1a0000
Model: Pine64 RockPro64
Net:   eth0: ethernet@fe300000

in tasksel try to install ubuntuu desktop
On Fri, Nov 9, 2018 at 1:31 AM Lev Lybin<EMAIL_ADDRESS>wrote:

MR24=0x8
MR25=0x0
CS = 1
MR0=0x18
MR4=0x2
MR5=0xFF
MR8=0x8
MR12=0x72
MR14=0x72
MR18=0x0
MR19=0x0
MR24=0x8
MR25=0x0
channel 0 training pass!
channel 1 training pass!
change freq to 400MHz 0,1
channel 0
CS = 0
MR0=0x98
MR4=0x2
MR5=0xFF
MR8=0x8
MR12=0x72
MR14=0x72
MR18=0x0
MR19=0x0
MR24=0x8
MR25=0x0
CS = 1
MR0=0x18
MR4=0x2
MR5=0xFF
MR8=0x8
MR12=0x72
MR14=0x72
MR18=0x0
MR19=0x0
MR24=0x8
MR25=0x0
channel 1
CS = 0
MR0=0x98
MR4=0x2
MR5=0xFF
MR8=0x8
MR12=0x72
MR14=0x72
MR18=0x0
MR19=0x0
MR24=0x8
MR25=0x0
CS = 1
MR0=0x18
MR4=0x2
MR5=0xFF
MR8=0x8
MR12=0x72
MR14=0x72
MR18=0x0
MR19=0x0
MR24=0x8
MR25=0x0
channel 0 training pass!
channel 1 training pass!
change freq to 800MHz 1,0
ch 0 ddrconfig = 0x101, ddrsize = 0x2020
ch 1 ddrconfig = 0x101, ddrsize = 0x2020
pmugrf_os_reg[2] = 0x3AA1FAA1, stride = 0xD
OUT
U-Boot SPL board init
U-Boot SPL 2017.09-rockchip-ayufan-1025-g482cd6ec8b (Jul 26 2018 - 08:18:48)
booted from eMMC
Trying to boot from MMC1
NOTICE:  BL31: v1.3(debug):d98d16e
NOTICE:  BL31: Built : 15:03:07, May 10 2018
NOTICE:  BL31: Rockchip release version: v1.1
INFO:    GICv3 with legacy support detected. ARM GICV3 driver initialized in EL3
INFO:    Using opteed sec cpu_context!
INFO:    boot cpu mask: 0
INFO:    plat_rockchip_pmu_init(1151): pd status 3e
INFO:    BL31: Initializing runtime services
WARNING: No OPTEE provided by BL2 boot loader, Booting device without OPTEE initialization. SMC`s destined for OPTEE will return SMC_UNK
ERROR:   Error initializing runtime service opteed_fast
INFO:    BL31: Preparing for EL3 exit to normal world
INFO:    Entry point address = 0x200000
INFO:    SPSR = 0x3c9
U-Boot 2017.09-rockchip-ayufan-1025-g482cd6ec8b (Jul 26 2018 - 08:18:55 +0000)
Model: Pine64 RockPro64
DRAM:  3.9 GiB
DCDC_REG1@vdd_center: ; enabling
DCDC_REG2@vdd_cpu_l: ; enabling
DCDC_REG3@vcc_ddr: ; enabling (ret: -38)
DCDC_REG4@vcc_1v8: set 1800000 uV; enabling
LDO_REG1@vcc1v8_dvp: set 1800000 uV; enabling
LDO_REG2@vcc3v0_touch: set 3000000 uV; enabling
LDO_REG3@vcc1v8_pmu: set 1800000 uV; enabling
LDO_REG4@vcc_sd: set 3300000 uV; enabling
LDO_REG5@vcca3v0_codec: set 3000000 uV; enabling
LDO_REG6@vcc_1v5: set 1500000 uV; enabling
LDO_REG7@vcca1v8_codec: set 1800000 uV; enabling
LDO_REG8@vcc_3v0: set 3000000 uV; enabling
SWITCH_REG1@vcc3v3_s3: ; enabling (ret: -38)
SWITCH_REG2@vcc3v3_s0: ; enabling (ret: -38)
vcc1v8-s0@vcc1v8_s0: set 1800000 uV; enabling (ret: -38)
dc-12v@dc_12v: set 12000000 uV; enabling (ret: -38)
vcc-sys@vcc_sys: set 5000000 uV; enabling (ret: -38)
vcc3v3-sys@vcc3v3_sys: set 3300000 uV; enabling (ret: -38)
vcc-phy-regulator@vcc_phy: ; enabling (ret: -38)
vdd-log@vdd_log: ; enabling (ret: -38)
MMC:   sdhci@fe330000: 0, dwmmc@fe320000: 1
SF: Detected gd25q128 with page size 256 Bytes, erase size 4 KiB, total 16 MiB
*** Warning - bad CRC, using default environment
In:    serial@ff1a0000
Out:   serial@ff1a0000
Err:   serial@ff1a0000
Model: Pine64 RockPro64
Net:   eth0: ethernet@fe300000
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ayufan-rock64/linux-build/issues/145#issuecomment-437264110,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Am8N1GFGfn5GgrMVr1Qgu0YD_nrqSIA0ks5utSE8gaJpZM4TA09d
.

It is strange, but, really, one day without crashes with bionic-lxde-rockpro64. I removed additional packages by https://github.com/ayufan-rock64/linux-package/blob/master/root/usr/local/sbin/install_desktop.sh
Why under bionic-lxde-rockpro64 works, but under others kernel crashes...
I don't see in logs now:
[ 3966.656954] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 3969.286859] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 3971.284889] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 3973.738677] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 4007.029496] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 4009.548435] xhci_hcd 0000:01:00.0: WARN Event TRB for slot 2 ep 2 with no TDs queued?
[ 4042.996762] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 4045.515788] xhci_hcd 0000:01:00.0: WARN Event TRB for slot 2 ep 2 with no TDs queued?
[ 4079.018244] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 4081.538333] xhci_hcd 0000:01:00.0: WARN Event TRB for slot 2 ep 2 with no TDs queued?
[ 4094.056556] EXT4-fs error (device sdf1): ext4_find_extent:910: inode #302082: comm scavenger: pblk 438336000 bad header/extent: invalid magic - magic f39, entries 17478, max 20872(0), depth 26550(0)
[ 4125.045784] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 4158.064591] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 4158.082063] xhci_hcd 0000:01:00.0: WARN Event TRB for slot 2 ep 2 with no TDs queued?
[ 4189.052740] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 4222.070111] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd
[ 4224.589439] sd 2:0:0:0: timing out command, waited 180s
[ 4224.590309] sd 2:0:0:0: [sde] tag#0 UNKNOWN(0x2003) Result: hostbyte=0x00 driverbyte=0x08
[ 4224.590339] sd 2:0:0:0: [sde] tag#0 Sense Key : 0x4 [current]
[ 4224.590365] sd 2:0:0:0: [sde] tag#0 ASC=0x40 <<vendor>>ASCQ=0x99
[ 4224.590396] sd 2:0:0:0: [sde] tag#0 CDB: opcode=0x88 88 00 00 00 00 00 d6 45 b1 e0 00 00 00 20 00 00
[ 4224.590417] blk_update_request: I/O error, dev sde, sector<PHONE_NUMBER>
[ 4255.043288] usb 10-3: reset SuperSpeed USB device number 3 using xhci_hcd

Nov 09 16:08:15 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:08:17 rockpro64 kernel: xhci_hcd 0000:01:00.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?
Nov 09 16:08:50 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:08:53 rockpro64 kernel: xhci_hcd 0000:01:00.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?
Nov 09 16:09:06 rockpro64 kernel: EXT4-fs error (device sde1): ext4_find_extent:916: inode #302082: comm scavenger: pblk 851474688 bad header/extent: invalid magic - magic c19c, entries 4923, max 17809(0), depth 19583(0)
Nov 09 16:09:36 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:10:01 rockpro64 CRON[1399]: pam_unix(cron:session): session opened for user root by (uid=0)
Nov 09 16:10:01 rockpro64 CRON[1400]: (root) CMD (/home/rock64/stat.sh | /home/rock64/ansi2html.sh > /var/www/html/index.html)
Nov 09 16:10:01 rockpro64 CRON[1399]: pam_unix(cron:session): session closed for user root
Nov 09 16:10:10 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:10:10 rockpro64 kernel: xhci_hcd 0000:01:00.0: WARN Event TRB for slot 1 ep 2 with no TDs queued?
Nov 09 16:10:41 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:11:14 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:11:47 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:11:47 rockpro64 kernel: sd 2:0:0:0: timing out command, waited 180s
Nov 09 16:11:47 rockpro64 kernel: sd 2:0:0:0: [sdd] tag#0 UNKNOWN(0x2003) Result: hostbyte=0x07 driverbyte=0x00
Nov 09 16:11:47 rockpro64 kernel: sd 2:0:0:0: [sdd] tag#0 CDB: opcode=0x88 88 00 00 00 00 01 9d 99 11 e0 00 00 00 20 00 00
Nov 09 16:11:47 rockpro64 kernel: blk_update_request: I/O error, dev sdd, sector<PHONE_NUMBER>
Nov 09 16:12:19 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:12:20 rockpro64 kernel: sd 2:0:0:1: [sde] tag#0 UNKNOWN(0x2003) Result: hostbyte=0x05 driverbyte=0x00
Nov 09 16:12:20 rockpro64 kernel: sd 2:0:0:1: [sde] tag#0 CDB: opcode=0x8a 8a 00 00 00 00 00 00 00 08 00 00 00 00 08 00 00
Nov 09 16:12:20 rockpro64 kernel: blk_update_request: I/O error, dev sde, sector 2048
Nov 09 16:12:20 rockpro64 kernel: Buffer I/O error on dev sde1, logical block 0, lost sync page write
Nov 09 16:12:20 rockpro64 kernel: EXT4-fs error (device sde1): ext4_find_extent:916: inode #302082: comm scavenger: pblk 851474688 bad header/extent: invalid magic - magic c19c, entries 4923, max 17809(0), depth 19583(0)
Nov 09 16:12:20 rockpro64 kernel: EXT4-fs (sde1): previous I/O error to superblock detected
Nov 09 16:12:53 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:13:26 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:13:57 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd
Nov 09 16:14:27 rockpro64 kernel: usb 8-2: reset SuperSpeed USB device number 3 using xhci_hcd

I think I found solution:
add in /etc/default/extlinux
systemd.gpt_auto=0 usbcore.autosuspend=-1
sudo update-extlinux.sh and reboot
But still have question what diffrent between minimal and desktop, why problem is not reproduced under desktop version, I found one diffrence only $SIZE, hm...

Crashed again on bionic-lxde, it's good, no weirdness ) Works stable only with usbcore.autosuspend=-1
When kernel crashes - board stuck, need turn off power and wait 10-60mins.

Crashed again on bionic-lxde, it's good, no weirdness ) Works stable only with usbcore.autosuspend=-1
When kernel crashes - board stuck, need turn off power and wait 10-60mins.

@llybin Did you simply add this line:

systemd.gpt_auto=0 usbcore.autosuspend=-1

to the end of the /etc/default/extlinux file?

Board is still stuck sometimes, but less often. Need to try more recent mainline kernels. Look on https://www.armbian.com/rockpro64/ Community there is more active.

Same issue as described in the original post
version (Latest Release) rockpro64 0.7.9

Please gry 0.8.0rc12
On Sun, 2 Jun 2019 at 22:22, Daniel Mayovskiy<EMAIL_ADDRESS>wrote:

Same issue as described in the original post
version (Latest Release) rockpro64 0.7.9
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ayufan-rock64/linux-build/issues/145?email_source=notifications&email_token=AASOSQJBE2AY2DW7XRTYNH3PYQTVHA5CNFSM4EYDJ5O2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWX5HTY#issuecomment-498062287,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASOSQJOOSGF4VDS634ZKGLPYQTVHANCNFSM4EYDJ5OQ
.


Generator interface does not extend IterableIterable interface

The Generator object is returned by a generator function and it conforms to both the iterable protocol and the iterator protocol.

However, lib.es2015.generator.d.ts only defines Generator to extend Iterator and not also IterableIterator.
https://github.com/microsoft/TypeScript/blob/131875bb849c0a9c56c26d09881453aace0cbfed/lib/lib.es2015.generator.d.ts#L23-L29
I wonder if there are technical reasons for this or if such is intentional. When writing functions that receive an Iterable<T>/IterableIterator<T> I can pass in something typed Generator<T> as it satisfies the same structure as Iterable<T>/IterableIterator<T> but if want to add to the %IteratorProrotype% Object and expose that to the type system I have to merge declarations with not only IterableIterator<T> but also Generator<T>, it would be simpler if Generator<T> already extended IterableIterator<T> which would, from what I can tell, be inline with the ECMAScript spec.
Thank you.

@rbuckton can probably speak to this

Is there a reason it needs to? Generator defines a [Symbol.iterator]() method with a more specific return type than what IterableIterator provides.
Inheriting from IterableIterator can cause some problems, as well. IterableIterator inherits from Iterator<T>, so the TNext type argument is defaulted to undefined, which means that not every Generator is assignable to an IterableIterator. This is actually by-design, since IterableIterator was never correctly typed.
Consider the following:
function * f(): IterableIterator<number> {
  let count = 0;
  while (true) {
    yield count++;
  }
  return count;
}

function * g(): Generator<number, number, boolean> {
  let count = 0;
  let running = true;
  while (running) {
    running = yield count++;
  }
  return count;
}

In earlier versions of TypeScript, we did not distinguish between the yielded or returned value, and did not type the value passed via next, so code written for earlier versions of TypeScript could do this:
for (const value of f()) {
  console.log(value);
  if (value > 10) break;
}

When we introduced more specific types for generators, we didn't want to break existing code, however we did want to provide an error if you write this:
for (const value of g()) { // error: Cannot iterate value because the 'next' method of its iterator expects type 'boolean'
                           // but 'for-of' will always send 'undefined'
  console.log(value);
  if (value > 10) break;
}

IterableIterator essentially exists for backwards-compatibility, and to explain the behavior of built-in iterators for Array, Map, Set, etc.. User defined generators should use the more specific Generator type when possible. We may eventually change the definition of IterableIterator to accept additional type arguments, but that would necessitate changing Iterable as well. This is something we have held off from doing as that could have far-reaching consequences in declaration emit.

Also note that Generator<T> is not the same as IterableIterator<T> because the default type argument for TNext for a Generator<T> is unknown. If you want to accept a Generator that is compatible with IterableIterator<T>, you must specify its TReturn and TNext type arguments: Generator<T, any, undefined> (or Generator<T, void, undefined>, Generator<T, unknown, undefined>, etc.).


Update kind manifest image tags during upgrade flow

We maintain a list of images that are referenced upstream in Kind's CNI and PV storage manifests and containerd config file. We use this list for find-and-replace operations on certain files on the Kind node image, to replace them with EKS-A kindnetd and local-path-provisioner/local-path-helper images and EKS-D pause image. When bumping Kind versions, the upstream tags may change, which requires us to update the image tags list otherwise the find-and-replace will fail.
This PR adds logic to update this image list whenever we bump the Kind version.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherrypick release-0.21

/cherrypick release-0.20


Switch bad rows output to be Avro-based

We are working towards supporting Thrift for our raw events; it makes sense to move our bad records output to Thrift too as a first step. Currently it is using a plaintext JSON format which is a bit niche.
Also the bad records output is not currently consumed by any further systems (unlike good record output), making this an easier change than the good record output.

JSON is just easier for most analysis purposes, closing.


YouTube player closes when removing YouTube app from back stack.

I start my activity and the android-youtube-player starts playing video. Now I go to YouTube app in phone by clicking on YouTube icon in android-youtube-player, and then I kill the YouTube app by removing it from the back stack. I am back in my app, but the android-youtube-player has closed. Is this because the android-youtube-player uses service from YouTube app and when the it is force closed the service is no longer available? I would like to know is there any way to have control on this behaviour.

The library does not depend on the YouTube app. The issue is most likely in
your code.
On Mon, Nov 29, 2021, 6:29 AM Sreehari R. K. @.***>
wrote:

I start my activity and the android-youtube-player starts playing video.
Now I go to YouTube app in phone by clicking on YouTube icon in
android-youtube-player, and then I kill the YouTube app by removing it from
the back stack. I am back in my app, but the android-youtube-player has
closed. Is this because the android-youtube-player uses service from
YouTube app and when the it is force closed the service is no longer
available? I would like to know is there any way to have control on this
behaviour.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PierfrancescoSoffritti/android-youtube-player/issues/794,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABY4R44PVMDD345PFRJBDBDUOMMULANCNFSM5I6KROZA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Integrate llvm-project at ad81d019a62d and bump dependencies

LLVM_COMMIT=”ad81d019a62d33e5d1f232844b83d3e164e4b160”
MHLO_COMMIT=”2cb5b72500ad17158d0977a4e231acf6fc8c2467”
TF_COMMIT=”2b8be560396d110eb9858a2dddd90b59a1809bd3”

I think for the bufferization changes you probably need something like this https://github.com/iree-org/iree/commit/389207132d2c11ed2e57fe842155c6ea0f3767e0
That commit is part of the pad_fusion branch in IREE. You can cherry pick it if that helps.

Heads up this commit might not go through. It was just to test if an earlier integrate thats blocked by another issue had been resolved: https://github.com/iree-org/iree/pull/12154. See here for more context: https://discord.com/channels/689900678990135345/1073765115964428358/1073765120129388604

I think for the bufferization changes you probably need something like this 3892071 That commit is part of the pad_fusion branch in IREE. You can cherry pick it if that helps.
You'll need it if these two changes have made it through the integrate
<EMAIL_ADDRESS>

Not needed anymore.


Remove capybara-webkit

It no longer installs on macOS Sierra (the [wiki] recommends checking out an old version of Homebrew to install Qt5.5), making it difficult to run tests on a new computer.
In addition, we don't have any Javascript tests.
Thus, the easiest thing is just to not use capybara-webkit.

@edwardloveall Please review

I suspect the tests will fail due to vulnerable gems, but will otherwise pass. (That's what happens on my machine.

I opened #72 to update the vulnerable gems.


[CIVP-18337] Use civis jupyter notebook v1.0.0

Update to civis-jupyter-notebook version 1.0.0

Since this is more than a micro version update, I am also updating Kubernetes image prepulls.


viber: fix no internet error

Description of changes
Viber does not connect to the internet.
Issue was also posted here: https://github.com/NixOS/nixpkgs/issues/193398
Judging by online sources it seems that viber relies on older version of openssl, but the one included in the derivation is "the latest".
Things done
Package input for openssl was changed from openssl to openssl_1_1.
Tested on nixos and non-nixos.

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Ping to maintainer @jagajaga

@jagajaga you should have waited for ofborg to finish evaluation..

Or have tested the change.


Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/4949, or mute the thread
https://github.com/notifications/unsubscribe/AF-Z2wGZ_5Apw79uHNqV3BVsWnpeyylCks5qG9WcgaJpZM4IqN03
.

The development of the icons is now here, please join if you are interested with godot design


LLVM Support

Hello,
Setting "Project properties" ("Configuration Properties\General\Platform Toolset") in Visual Studio 2022 to "LLVM (clang-cl)" leads to linker error:
lld-link: error: could not open 'C:\Project\threaded\packages\lua.5.4.7\build\native\lib\x64\ERROR\Release\lua.lib': no such file or directory

Yes, I can confirm, the current nuget package is not compatible with the LLVM toolset.
I will prepare a fix and a patch release.

@romanf-dev , please try the following as workaround until I can supply a package update release with proper LLVM-Support:

Open the "Project properties"
Go to "Referenced Packages" > "Lua"
Change "Runtime Platform" from "Default" to "v143"

Please, tell me if that works for you, and unblocks you.
(Even if that works for you, leave this issue open. I will introduce real ClangCL support into the package.)

Thank you! The workaround works well.

Upcoming patch release <IP_ADDRESS> introduces ClangCL-built binaries

Still the same error after update to the latest package


bower install doesn't work.

bower install querystring grabs a different package.
from bower search querystring:
querystring git://github.com/anodynos/node2web_querystring.git

Fine for me.

I'm still able to install using the full URL, but the installation instructions here do not work for me.

sorry about that, we used a template to generate the readme and we didn't publish to bower before the other querystring lib was registered.  We need to update the name of the lib and update the readme.  Any suggestions for names?

stringJawn


MeshNetworks: support gateways with node ports

We currently read just the LB IPs for a service and populate it in the
ClusterExternalAddresses field. In cases where the service is exposed via
a NodePort, this PR adds the ability to read all (or subset of) node IPs and populate the
service, along with the port mappings for the node port.
There are several TODOs in this file, esp around controller.go where I am not sure what is the
initial behavior of the system when we get a slew of node and service update events.
So opening the PR early to see what others think.

@rshriram: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

lint_istio
77981103860ef0362c825983198834d961131494
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

lint_istio
77981103860ef0362c825983198834d961131494
link
/test lint_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

lint_istio
77981103860ef0362c825983198834d961131494
link
/test lint_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

lint_istio
77981103860ef0362c825983198834d961131494
link
/test lint_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

lint_istio
77981103860ef0362c825983198834d961131494
link
/test lint_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

lint_istio
77981103860ef0362c825983198834d961131494
link
/test lint_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

lint_istio
77981103860ef0362c825983198834d961131494
link
/test lint_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
77981103860ef0362c825983198834d961131494
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

lint_istio
77981103860ef0362c825983198834d961131494
link
/test lint_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
77981103860ef0362c825983198834d961131494
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
77981103860ef0362c825983198834d961131494
link
/test gencheck_istio

integ-multicluster-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-multicluster-k8s-tests_istio

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

unit-tests_istio
77981103860ef0362c825983198834d961131494
link
/test unit-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-multicluster-k8s-tests_istio

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-local-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-local-tests_istio

release-test_istio
77981103860ef0362c825983198834d961131494
link
/test release-test_istio

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-galley-k8s-tests_istio

integ-distroless-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-distroless-k8s-tests_istio

integ-mixer-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-multicluster-k8s-tests_istio

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

integ-galley-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-galley-k8s-tests_istio

integ-mixer-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-multicluster-k8s-tests_istio

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-conformance-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-conformance-k8s-tests_istio

integ-mixer-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-multicluster-k8s-tests_istio

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-galley-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-mixer-k8s-tests_istio

integ-multicluster-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-multicluster-k8s-tests_istio

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-galley-k8s-tests_istio

integ-conformance-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-conformance-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

integ-mixer-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-mixer-k8s-tests_istio

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-galley-k8s-tests_istio

integ-conformance-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

integ-telemetry-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-telemetry-k8s-tests_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-galley-k8s-tests_istio

integ-conformance-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-galley-k8s-tests_istio

integ-conformance-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
77981103860ef0362c825983198834d961131494
link
/test integ-security-k8s-tests_istio

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-galley-k8s-tests_istio

integ-conformance-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test lint_istio

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-galley-k8s-tests_istio

integ-conformance-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

My question is: If the gateway service is exposed by NodePort, then it can be easily set up with node ip address + port
type Network_IstioNetworkGateway struct {
	// Types that are valid to be assigned to Gw:
	//	*Network_IstioNetworkGateway_RegistryServiceName
	//	*Network_IstioNetworkGateway_Address
	Gw isNetwork_IstioNetworkGateway_Gw `protobuf_oneof:"gw"`
	// The port associated with the gateway.
	Port uint32 `protobuf:"varint,3,opt,name=port,proto3" json:"port,omitempty"`
	// The locality associated with an explicitly specified gateway (i.e. ip)
	Locality             string   `protobuf:"bytes,4,opt,name=locality,proto3" json:"locality,omitempty"`
	XXX_NoUnkeyedLiteral struct{} `json:"-"`
	XXX_unrecognized     []byte   `json:"-"`
	XXX_sizecache        int32    `json:"-"`
}

It makes sense unless we want to automatically register it.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test gencheck_istio

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-galley-k8s-tests_istio

integ-conformance-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-security-k8s-tests_istio

lint_istio
497fb67da15ccacddfb6202f3cc267cd2e2e2b29
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test unit-tests_istio

integ-distroless-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-distroless-k8s-tests_istio

integ-galley-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-galley-k8s-tests_istio

integ-conformance-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-conformance-k8s-tests_istio

integ-multicluster-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-security-k8s-tests_istio

lint_istio
497fb67da15ccacddfb6202f3cc267cd2e2e2b29
link
/test lint_istio

gencheck_istio
497fb67da15ccacddfb6202f3cc267cd2e2e2b29
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-multicluster-k8s-tests_istio

integ-mixer-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-telemetry-k8s-tests_istio

integ-pilot-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-pilot-k8s-tests_istio

integ-security-k8s-tests_istio
879f93c9ad0eb423eee15bb2c3d0f2ffd3bbca9d
link
/test integ-security-k8s-tests_istio

lint_istio
497fb67da15ccacddfb6202f3cc267cd2e2e2b29
link
/test lint_istio

gencheck_istio
497fb67da15ccacddfb6202f3cc267cd2e2e2b29
link
/test gencheck_istio

unit-tests_istio
497fb67da15ccacddfb6202f3cc267cd2e2e2b29
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Request for CDN and snowpack: JavaScript code should contain a TypeScript triple-slash directive in addition to x-typescript-types

Reasons

While I don't know who made up x-typescript-types, I am sure that triple-slash directive is TypeScript standard.
Author of vscode-deno (Deno Language Server) seems to struggle with supporting both triple-slash directive and x-typescript-types (this claim is yet to be confirmed).

Proposal
If requested JavaScript file has a correspoding TypeScript definition, add <references types="/-/types.d.ts" /> to the very top of the JavaScript file.

My understanding is that the two are conceptually different.

<references types="/-/types.d.ts" /> says "hey, load these type declarations as well".
x-typescript-types says "hey, these type declaration are actually MY type declarations"

In the past, these things have been better discussed on the Deno issue tracker. We're just an implementation of the spec/behavior that they've defined. /cc @kitsonk if he has any thoughts to add

Ah, so I was mistaken then! Thanks for the extra info @kitsonk.
@KSXGitHub feel free to connect me with the vscode-deno maintainer(s) if they're having trouble with anything related to importing from Pika CDN.

I suspect the issue that @axetroy is having is related to denoland/deno#4000 which has a fix merged into master today.  This impacted the triple slash directive as well.

X-TypeScript-Types and the triple slash reference directive are effectively the same to Deno.

Since they are the same, would it cause any trouble if a JavaScript module has both X-TypeScript-Types and <references types="..." /> pointing to the same URL?

I suspect the issue that axetroy is having is related to denoland/deno#4000 which has a fix merged into master today. This impacted the triple slash directive as well.

Unlikely, I have workaround for this (create a deps.ts and run deno fetch deps.ts). Result: Deno fetches type definition, use that for typechecking, but the IDE does not.

I'd suggest giving that latest PR fix a chance to bake a bit (looks like it was only merged to master a couple of hours ago).

@FredKSchott BTW, if I don't want to you cdn.pika.dev directly, instead, I want to use snowpack to generate my own Deno modules locally, how it's going to serve TypeScript definition? After all, local files don't have HTTP headers.

Another thing, I just noticed in https://github.com/pikapkg/snowpack/issues/264#issuecomment-609889287 that you wrote references (plural) instead of reference, this is a mistake that I also make.

Okay, so I dug into things a bit, and now I'm even more confused. The TS docs describe the functionality that I'd originally described: /// <reference types="..." /> describes a type declaration file as a dependency, not as the declarations that match the file itself. See: https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html
@kitsonk am I missing something, or are Deno and TS treating this triple-slash differently?

am I missing something, or are Deno and TS treating this triple-slash differently?

As I said before. Triple slash directives are not valid in JavaScript to the TypeScript compiler.  Because of the developer familiarity though, we adopted them in Deno.  I felt that it would lead to confusion, but Ry liked the ergonomics of it.  The compiler simply ignores them in other runtimes (maybe tries to load them if you have "checkJs" enabled).  But again, it is, in my opinion, the way to do it when you can't do X-TypeScript-Types.  If we really think it leads to confusion though, we should adopt some other semantics, so people don't get confused.

Gotcha, thanks for clarifying. I don't have any hard opinions here either way, just want to make sure I understood. Either way, I would suggest documenting this departure from TypeScript's documented behavior specifically, since I'd guess that plenty more people will read the TS docs and not realize that this is something that Deno handles differently.

For TypeScript files it handles it as normal (as in normal Deno module resolution).  Though 99.9% of the time it isn't a useful behaviour in Deno.  Clearly overloading it does cause confusion.  Now that we have a proof point, I think we should change it before 1.0, which I will raise in Deno.


[experiment] Fix jvm prebuild checking

/gcbrun exp -n dk-test-jvm14 -m vertex_ai_gemini-1-5 -b jvm

Report is looking good.