Rg Memory Leak

Before I get into it, I'll start with the vscode "Report Issue" which said I had too much text or something and I needed to paste it in here.

VS Code Version: Code - Insiders 1.55.0-insider (9b2ee7fb7d970b9a628fdb3545bdd01d67078d16, 2021-03-11T05:14:35.442Z)
OS Version: Linux x64 5.10.27-dirty

Steps to Reproduce:

Open multi-root workspace
Search for 'TIFFFieldWithTag'

Does this issue occur when all extensions are disabled?: Didn't disable them since it appears unrelated given 2 previous searches worked with no issue.

It happened 3 times with that one search.
The first time, I didn't realize what was happening until it was too late and I had to wait for OOM to kick and kill off "rg".
Apr 16 05:26:15 computerName kernel: Out of memory: Killed process 3001853 (rg) total-vm:4516264kB, anon-rss:2336064kB, file-rss:0kB, shmem-rss:0kB, UID:1000 pgtables:4716kB oom_score_adj:0

The second time, I tried it again to make sure I was watching htop to see if it was vscode.
The third time was to get the status information below for that test.
One of the searches I did before which worked with no issue was '_TIFFmalloc(tsi'. I just tried it again right now (after those 3 failures), and it worked fine again.
Out of curiosity, I tried that failed search again and the memory spiked again with no results. VERY odd.
Status Before The Search:
Version:          Code - Insiders 1.55.0-insider (9b2ee7fb7d970b9a628fdb3545bdd01d67078d16, 2021-03-11T05:14:35.442Z)
OS Version:       Linux x64 5.10.27-dirty
CPUs:             Intel(R) Core(TM) i3-4130 CPU @ 3.40GHz (4 x 3392)
Memory (System):  7.23GB (1.09GB free)
Load (avg):       4, 3, 9
VM:               0%
Screen Reader:    no
Process Argv:     --crash-reporter-id a2928a5c-190e-4d25-8038-9980bdeb3821
GPU Status:       2d_canvas:                  enabled
                  gpu_compositing:            enabled
                  multiple_raster_threads:    enabled_on
                  oop_rasterization:          disabled_off
                  opengl:                     enabled_on
                  protected_video_decode:     unavailable_off
                  rasterization:              disabled_software
                  skia_renderer:              enabled_on
                  video_decode:               disabled_software
                  vulkan:                     disabled_off
                  webgl:                      enabled
                  webgl2:                     enabled

CPU %   Mem MB     PID  Process
    0<PHONE_NUMBER> code-insiders main
    0       37  3006260    zygote
    0       74  3006323      gpu-process
    0       37  3006262    zygote
    0        0  3006266      zygote
    0       59  3006351    utility
    0<PHONE_NUMBER>    window (tiffdump.c - tiff (Workspace) - Visual Studio Code - Insiders)
    0<PHONE_NUMBER>      extensionHost
    1       30  3006547        <pathTo>/.vscode-insiders/extensions/ms-vscode.cpptools-1.1.3/bin/cpptools
    0       15  3006638        <pathTo>/.vscode-insiders/extensions/ms-vscode.cpptools-1.1.3/bin/cpptools-srv 3006547 0
    0       59  3006571        <pathTo>/VSCode-linux-x64/code-insiders <pathTo>/VSCode-linux-x64/resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=3006391
    0       59  3006422      watcherService
    0       59  3006461      searchService
    0<PHONE_NUMBER>    shared-process
    0       59  3006451      ptyHost
    0        0  3006530        /bin/bash

Workspace Stats:
|  Window (tiffdump.c - tiff (Workspace) - Visual Studio Code - Insiders)
|    Folder (tiff): 2 files
|      File types: txt(1)
|      Conf files:
|    Folder (jpeg-6b): 147 files
|      File types: c(72) h(13) doc(8) 1(6) st(5) jpg(4) bcc(2) cfg(2) dj(2)
|                  mac(2)
|      Conf files:
|    Folder (libtiff): 1180 files
|      File types: man(236) dll(140) c(105) html(104) rtf(60) 3tiff(38)
|                  mui(36) in(27) ldf(27) 1(25)
|      Conf files: tasks.json(1)

Status During The Search:
Version:          Code - Insiders 1.55.0-insider (9b2ee7fb7d970b9a628fdb3545bdd01d67078d16, 2021-03-11T05:14:35.442Z)
OS Version:       Linux x64 5.10.27-dirty
CPUs:             Intel(R) Core(TM) i3-4130 CPU @ 3.40GHz (4 x 3392)
Memory (System):  7.23GB (0.12GB free)
Load (avg):       6, 3, 9
VM:               0%
Screen Reader:    no
Process Argv:     --crash-reporter-id a2928a5c-190e-4d25-8038-9980bdeb3821
GPU Status:       2d_canvas:                  enabled
                  gpu_compositing:            enabled
                  multiple_raster_threads:    enabled_on
                  oop_rasterization:          disabled_off
                  opengl:                     enabled_on
                  protected_video_decode:     unavailable_off
                  rasterization:              disabled_software
                  skia_renderer:              enabled_on
                  video_decode:               disabled_software
                  vulkan:                     disabled_off
                  webgl:                      enabled
                  webgl2:                     enabled

CPU %   Mem MB     PID  Process
    0<PHONE_NUMBER> code-insiders main
    0       37  3006260    zygote
    9       59  3006323      gpu-process
    0       37  3006262    zygote
    0        0  3006266      zygote
    0       52  3006351    utility
   10<PHONE_NUMBER>    window (tiffdump.c - tiff (Workspace) - Visual Studio Code - Insiders)
    0<PHONE_NUMBER>      extensionHost
    0       67  3006547        <pathTo>/.vscode-insiders/extensions/ms-vscode.cpptools-1.1.3/bin/cpptools
    0        0  3006638         <pathTo>/.vscode-insiders/extensions/ms-vscode.cpptools-1.1.3/bin/cpptools-srv 3006547 0
    0       59  3006571        <pathTo>/VSCode-linux-x64/code-insiders <pathTo>/VSCode-linux-x64/resources/app/extensions/json-language-features/server/dist/node/jsonServerMain --node-ipc --clientProcessId=3006391
    0       52  3006422      watcherService
    0       59  3006461      searchService
    2     3532  3006826        <pathTo>/VSCode-linux-x64/resources/app/node_modules.asar.unpacked/vscode-ripgrep/bin/rg --hidden --ignore-case -g !**/.git -g !**/.svn -g !**/.hg -g !**/CVS -g !**/.DS_Store -g !**/node_modules -g !**/bower_components -g !**/*.code-search --max-filesize<PHONE_NUMBER>4 --no-ignore-parent --follow --crlf --auto-hybrid-regex --regexp TIFFFieldWithTag\r?\n --no-config --no-ignore-global --json --multiline -- .
    0       89  3006403    shared-process
    0       52  3006451      ptyHost
    0        0  3006530        /bin/bash

Workspace Stats:
|  Window (tiffdump.c - tiff (Workspace) - Visual Studio Code - Insiders)
|    Folder (tiff): 2 files
|      File types: txt(1)
|      Conf files:
|    Folder (jpeg-6b): 147 files
|      File types: c(72) h(13) doc(8) 1(6) st(5) jpg(4) bcc(2) cfg(2) dj(2)
|                  mac(2)
|      Conf files:
|    Folder (libtiff): 1180 files
|      File types: man(236) dll(140) c(105) html(104) rtf(60) 3tiff(38)
|                  mui(36) in(27) ldf(27) 1(25)
|      Conf files: tasks.json(1)

Extension | Author (truncated) | Version
-- | -- | --
xml | Dot | 2.5.0
vscode-nuget-package-manager | jmr | 1.1.6
cortex-debug | mar | 0.3.7
csharp | ms- | 1.23.9
cpptools | ms- | 1.1.3
msbuild-project-tools | tin | 0.3.15

Include A/B experiment info
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256197
vstry244:30244315
pythonvsdeb440:30224570
pythonvsded773:30223139
pythonvspyt875:30259475
pythonvsnew554:30265444
pythontb:30258533
wslfolderdoc:30278405
vspre833cf:30267465
pythonptprofiler:30281269
vscnewfiletextcf:30288478
vshan820cf:30276953
pythondataviewer:30285072
vscus158cf:30286554
vscgsv2:30286872

EDIT0:
I went ahead and downloaded the latest insider, and it's still an issue in that:
Version: 1.56.0-insider
Commit: 25785b97e533b15ae3b12e48aaf4187416437e62
Date: 2021-04-15T05:14:30.209Z
Electron: 11.4.2
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.10.27-dirty

EDIT1:
AGH! Okay, I forgot I had mounted a mostly unrelated iso in a temporary folder in that libtiff git folder since I was already working in there.
After I noticed that and unmounted/removed it, the search went fine.
What I cannot explain is why that particular search failed but the others succeeded.
I don't know if you want this to remain open to explore the "why", or just close it since I figured out how it was a problem in my case.
I hold the possibility that the mounted iso folder contained large data files (multi-gb) that "rg" may have been trying to load wholly into memory. But again, I don't know why the other searches still worked.

It seems to me like the problem is indeed that massive file which ripgrep would try to load into memory. Can you reproduce the problem with standard CLI version of ripgrep? If so maybe file an issue on the project's repo, https://github.com/BurntSushi/ripgrep.
I will close this as being a configuration issue with search excludes, if using the CLI rg never produces this issue we may look more into it.

cc @RMacfarlane for the first paragraph re issue reporter.

Whoof, okay ignore all the stuff below "EARLIER".
It seems copying/pasting the "rg" command from the "status" output above is no bueno. The "**" was making bash do some REALLY wonky stuff I think, and those globs needed to be in quotes.
Pressing the up-key in the console for going back in the command history showed that wonkiness clearly.
I also found the regex had to be in quotes too.
Once everything was quoted, I could replicate the rg memory hogging.
Failed:
$ rg --hidden --ignore-case -g '!**/.git' -g '!**/.svn' -g '!**/.hg' -g '!**/CVS' -g '!**/.DS_Store' -g '!**/node_modules' -g '!**/bower_components' -g '!**/*.code-search' --max-filesize<PHONE_NUMBER>4 --no-ignore-parent --follow --crlf --engine auto --regexp "TIFFFieldWithTag\r?\n" --no-config --no-ignore-global --multiline -- .
Individual Changes That Succeeded:

Dropping the "--max-filesize" down to a low value. (I don't have 17GB of available RAM. I don't have 8GB of available RAM. "I don't have a square to spare.")
Dropping the "\r?\n"
Dropping the "--multiline"
The iso with large files still had to be mounted to cause the issue. I'm sure that makes sense with the "--multiline" being used.

**Just so you don't miss something I included below, "--auto-hybrid-regex" is deprecated according to the man. It's why I changed that in the command to "--engine auto".
EARLIER
Okay, it wasn't even about the iso mounted path with large files... (or maybe not only that)
I can see that the search term was NOT 'TIFFFieldWithTag', but rather a '\r?\n' was appended to it when I selected the text to copy (probably along with '--multiline' which was added to "rg" because of those characters).
I tried it with 'TIFFFieldWithTag' as-is (no cr/lf), and it worked fine, even with the mounted iso.
Succeeded:
unmounted iso; 'TIFFFieldWithTag\r?\n'
mounted iso; 'TIFFFieldWithTag'
Failed:
mounted iso; 'TIFFFieldWithTag\r?\n'
I've been trying to use the command stated in the "status" output above (/VSCode-linux-x64/resources/app/node_modules.asar.unpacked/vscode-ripgrep/...) in a terminal, but for some reason, can't get it to fail (hog memory).
I'm in the libtiff directory with the mounted iso, so I'd think that would do it, but it doesn't. It just returns with:
mntiso*/.git: No such file or directory (os error 2)
mntiso*/.svn: No such file or directory (os error 2)
mntiso*/.hg: No such file or directory (os error 2)
mntiso*/CVS: No such file or directory (os error 2)
mntiso*/.DS_Store: No such file or directory (os error 2)
mntiso*/node_modules: No such file or directory (os error 2)
mntiso*/bower_components: No such file or directory (os error 2)
mntiso*/*.code-search: No such file or directory (os error 2)
{"data":{"elapsed_total":{"human":"0.006754s","nanos":6754122,"secs":0},"stats":{"bytes_printed":0,"bytes_searched":0,"elapsed":{"human":"0.000000s","nanos":0,"secs":0},"matched_lines":0,"matches":0,"searches":0,"searches_with_match":0}},"type":"summary"}

So NO results are found (even though there are)
As an aside, while looking at the rg man, I saw:
--auto-hybrid-regex
           DEPRECATED. Use --engine instead.

Okay, I dumbed it down a lot since rg just wasn't working right for me in a console...
I started with "rg TIFFFieldWithTag". Fine.
Then "rg --regexp TIFFFieldWithTag". Fine.
Working all the way back to what I suspected to be an issue "-g !/.git". Those "" stuff caused havoc, in the end relating to an "argument list too long" error.
Without any of the "-g" parameters, even the "failed" command worked (though there were no 'TIFFFieldWithTag\r?\n' found, which makes me wonder how I even managed to paste that into the search to begin with).
I think bash is doing some weird stuff when I use those sub wildcard stuff.
Even trying "rg -g !**/.git TIFFFieldWithTag"... wth! Ahhh, okay. Starting over up top.

Thanks for the detailed report! To summarize: your query string unintentionally included a newline, causing ripgrep to go into multiline mode. In multiline mode, ripgrep loads files into memory, causing high memory use. This can potentially be mitigated via the --max-filesize parameter to ripgrep.
cc @roblourens for if we might want to support a setting for overriding  --max-filesize.


Make example close to real world scenario: ejb separate deployment, and web client calls ejb

Make example close to real world scenario: ejb separate deployment, and web client calls ejb

How to  invoke below ejb method from a springboot application running outside liberty?
SampleStatelessBean.hello()


arch: arm: Remove header shims

This commit removes the header shims introduced after AArch32/64
re-organisation in the commit d048faacf234061f6fb70e4926446268a68442bd.
Signed-off-by: Stephanos Ioannidis<EMAIL_ADDRESS>

So we agreed to keep these for 2 releases?

So we agreed to keep these for 2 releases?

I do not recall "agreeing" on that in an official manner, but the commit message at the time says 2 releases and it was approved:
The shim will go away after two releases, so make sure to adapt your
application for the new locations.

Based on other deprecation policies we have, I do not think there is any point in keeping these for more than two releases. What do you think? @ioannisg

Added a commit to fix all deprecated path references.

So we agreed to keep these for 2 releases?

I do not recall "agreeing" on that in an official manner, but the commit message at the time says 2 releases and it was approved:
The shim will go away after two releases, so make sure to adapt your
application for the new locations.

Based on other deprecation policies we have, I do not think there is any point in keeping these for more than two releases. What do you think? @ioannisg

Agreed

How about the shims in include/arch/arm/aarch32/cortex_r, @stephanosio ?

How about the shims in include/arch/arm/aarch32/cortex_r, @stephanosio ?

@ioannisg It has not been two releases since those were added, so I left them (though, I would actually prefer to get rid of them now).

How about the shims in include/arch/arm/aarch32/cortex_r, @stephanosio ?

@ioannisg It has not been two releases since those were added, so I left them (though, I would actually prefer to get rid of them now).

OK, then, maybe they can stay for one release more, to honor the same policy. No strong preference on that, but let's leave it outside this PR.


Looks like go get github.com/golangci/golangci-lint/cmd/golangci-lint@latest is no longer working with Go 1.16, and I suspect they won't fix that now that 1.18 is out. So our choice is to either cut support for 1.16, or pin to an older version of the linter. I opted for the latter.


Real API Gateway endpoints unreachable when moto submodules

Moto Version: 2.2.15
Boto3 Version: 1.20.7
I have a test that mocks ssm, but attempts to reach a real excute-api API Gateway endpoint. It appears that the responses_mock may be catching it? Despite not loading an API Gateway mock, I am getting a "The method is not implemented" message.
https://github.com/spulec/moto/blob/a912fc4cac1d4e66401e1772fe3c7a4182c2040e/moto/core/models.py#L450
https://github.com/spulec/moto/blob/master/moto/core/models.py#L485-L500
An example test
from moto import mock_ssm

@pytest.fixture
def set_ssm(monkeypatch):
    monkeypatch.setenv("AWS_DEFAULT_REGION", "us-east-2")
    with mock_ssm() as _:
      ... create client and do things ...
      ssm_c.put_parameter(
            Name=PLATFORM_CONFIG_NAME,
            Value=json.dumps(data),
            Type="String",
            Overwrite=True,
            DataType="text",
        )

        yield ssm_c

def test_token(self, set_ssm):
   real_function()

If I put a breakpoint() in moto/core/models.py(322)_find_first_match(), the request below catches in that function for reasons that do not make sense to me. I would not expect moto to even be involved at this point, but I have to imagine the fact that it is a execute-api.<region>.amazonaws.com url is contributing to the issue.
https://github.com/spulec/moto/blob/master/moto/core/models.py#L315-L319
import requests

def real_function():
   ... use ssm (this works with moto as expected) ...
   real_endpoint = "http://<api-id>.execute-api.<region>.amazonaws.com/<path>"
   payload = {}
   response = requests.request("PUT", url, headers=headers, data=payload) # return 400
   print(response.text) # returns 'The method is not implemented'

I'm happy to try to contribute a fix, but not sure where to start.

Hi @getglad, that is on purpose, actually - we intercept all requests to AWS to prevent people from accidentally changing their real infrastructure.
One option would be to at least make this behaviour configurable via an environment variable. The majority would want to intercept everything, as a fail-safe, but for expert users the option should be there to connect to AWS itself.
If you'd like to contribute, a PR is always welcome!
Our documentation has info on how to get started as a contributor: http://docs.getmoto.org/en/latest/docs/contributing/index.html
For this specific feature, the logic that intercepts all AWS calls currently resides here: https://github.com/spulec/moto/blob/master/moto/core/models.py#L485:L500
All environment variables are located in moto/settings.py, so we should add another called something like 'MOTO_ALLOW_AWS_ACCESS' = 'true'/'false'
I haven't tested it out yet - but it might be as simple as placing an if-statement around that block, if not settings.allow_aws_access(): # add the not_implemented callbacks (and write a test for it of course).
Let me know if that makes sense - happy to help out if you get stuck!

Hi @getglad, it's been a while, but this feature is now part of the latest alpha-release: moto==5.0.0alpha2
The new mock_aws-decorator has an option to configure exactly which URL's you want to passthrough:
@mock_aws(
    config={"core": {
        "mock_credentials": False,
        "passthrough": {
            "urls": ["execute-api.*.amazonaws.com"],
            "services": []}}}
)

See the release announcement here: https://github.com/getmoto/moto/issues/7198
Are you able to upgrade and verify that this works for you?

Moto V5 has now been released, so I'll close this.
Release: https://pypi.org/project/moto/5.0.0/
Documentation about this feature: http://docs.getmoto.org/en/5.0.0/docs/configuration/index.html


Official docker image layer?

Wondering if it exists or if plans exist to add a docker image layer like composer has:
COPY --from=composer /usr/bin/composer /usr/bin/composer

Duplicate of #137


API /issue endpoint returns pull requests

Gitea version (or commit ref): 1.9.0+dev-377-g5908bb103
Can you reproduce the bug at https://try.gitea.io:

[x] Yes (provide example URL)
[ ] No
[ ] Not relevant

Description
When making an API request to the /issues endpoint the items returned include both pull requests and issues, which causes the pagination links to not be accurate. This is probably related to #7297
In the example-repo2 there are 14 issues with 8 pull requests mixed in. Doing an API request with no query parameters returns the following headers:
curl -I -H  "accept: application/json" -H  "authorization: Basic XXXXXX" -X GET "https://try.gitea.io/api/v1/repos/jerrykan/example-repo2/issues"

HTTP/2 200
content-type: application/json; charset=UTF-8
date: Wed, 26 Jun 2019 02:43:13 GMT
link: <https://try.gitea.io/api/v1/repos/jerrykan/example-repo2/issues?page=2>; rel="next",<https://try.gitea.io/api/v1/repos/jerrykan/example-repo2/issues?page=2>; rel="last"
set-cookie: XXXXXX
set-cookie: XXXXXX
set-cookie: XXXXXX
x-content-type-options: nosniff
x-frame-options: SAMEORIGIN

Looking at the Link response header there should only be two pages of items to return. However when both pages are requested:
curl -s -H  "accept: application/json" -H  "authorization: Basic XXXXXX" -X GET "https://try.gitea.io/api/v1/repos/jerrykan/example-repo2/issues" | jq .[].title

"branch8"
"Issue 14"
"Issue 13"
"Issue 12"
"branch7"
"branch6"
"branch5"
"branch4"
"Issue 11"
"Issue 10"

curl -s -H  "accept: application/json" -H  "authorization: Basic XXXXXX" -X GET "https://try.gitea.io/api/v1/repos/jerrykan/example-repo2/issues?page=2" | jq .[].title

"Issue 9"
"Issue 8"
"Issue 7"
"Issue 6"
"branch3"
"branch2"
"branch1"
"Issue 5"
"Issue 4"
"Issue 3"

We can see that the branch* pull requests are included in the results, and that Issue 2 and Issue 1 are missing from the results
What I would expect is that no pull requests are included in the results, which would result in the Link response header URLs being correct.

I believe this is still a valid bug

I marked #7299 bug because of pagination problem.

I think we should close this one and keep #7297 open


[extensions: kill_filter]: should not save the per-route-entry config in filter config member

Title: kill_request filter should not save the per-filter_config from route-entry in its member variable
Description:
This is a vulnerability issue: kill_request filter should not save the config pushed from XDS (route entry).
`
// Route-level configuration overrides filter-level configuration.
if (decoder_callbacks_->route() && decoder_callbacks_->route()->routeEntry()) {
const std::string& name = Extensions::HttpFilters::HttpFilterNames::get().KillRequest;
const auto* route_entry = decoder_callbacks_->route()->routeEntry();
const auto* per_route_kill_settings =
    route_entry->mostSpecificPerFilterConfigTyped<KillSettings>(name);

if (per_route_kill_settings) {
  envoy::type::v3::FractionalPercent probability = per_route_kill_settings->getProbability();
  kill_request_.set_allocated_probability(&probability);  //XXXXXXXX
}

}
`
In multiple tenancy proxy, an attack could be that one tenant (untrusted) specify any header or any probability.
I am also confused why the per-route-entry level config overriding is not applied before we decide " is_kill_request ".

cc @htuch @xiaobinxbw

cc @ahedberg

I don't think it's a vulnerability in that any production proxy should never have this filter linked in.
In terms of a functional issue, I think when I was reviewing this, I had assumed we were saving to filter per-instance state. Is this not the case?

for the mt tenancy case, I don't think this is fair: this is saying we are
saving per-route(per tenancy) config to a per-instance state, which I think
is not desired.
OTOH, I think the per-route config overriding should happen before it
computes the header or the probability as well, instead of saving
the config and let the kill triggered later by some other unintentional
testing request?
On Sun, Feb 28, 2021 at 10:37 AM htuch<EMAIL_ADDRESS>wrote:

I don't think it's a vulnerability in that any production proxy should
never have this filter linked in.
In terms of a functional issue, I think when I was reviewing this, I had
assumed we were saving to filter per-instance state. Is this not the case?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/envoyproxy/envoy/issues/15216#issuecomment-787471303,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2I6TAYGAFYEYVLMUQ27LTTBJPMVANCNFSM4YJD463A
.

--
Xin Zhuang

I'm confused; filter per-instance state is per-request. Are we saving to filter per-instance or factory here?

ah, my bad. For some reason I kept tripping over the fact that a filter instance is created per-request, thinking that's it's per-connection.
it's not saving to the per-instance factory here.
I also noticed that the filter only allows per-request probability overriding, but not the whole killSetting overriding, but I am not curious to ask why tho.
sorry for the confusion, let me close this issue.


Weird formatting of  node inside  node in Surface Catalogue

I formatted surface_catalogue using the main surface branch and found this change weird.
Before

    {example.code}

After

    {example.code}

@tiagoefmoraes So sorry for the delay in responding to this.
I did see it when you first submitted it, and since got distracted with work and life.
Do you know if it's since been fixed in Surface itself? If not, I'll try to take a look in the next couple weeks.

@tiagoefmoraes Thanks again for reporting this!
I attempted to reproduce it, but I wasn't successful. Here's where I ended up with the test I was using to play around with it:
test "issue 64" do
  assert_formatter_outputs(
    ~S"""

            {example.code}

    """,
    ~S"""

            {example.code}

    """
  )
end

(The test passes.)
Note that surface_formatter considers the contents of  tags whitespace-sensitive, and therefore it's intentional that your "outdented" {example.code} stays outdented.
However, the attributes of  (namely class, phx-hook, and id) should be intended in alignment with the start of the opening  tag. Which, you can see in the test case above, does happen with the latest version of surface_formatter.
I'm going to close this ticket, but of course feel free to reply if new information or related scenarios appear! Thanks again.


ld-linux-x86-64.so missing

Hello,
When I install node-red-contrib-v8-cpu-profiler in Node Red v3.0.2 I get an error message: ERR_DLOPEN_FAILED.
In the logs I have:
[info]  - node-red-contrib-v8-cpu-profiler:v8-cpu-profiler : Error: Error loading shared library ld-linux-x86-64.so.2: No such file or directory (needed by /config/node-red/node_modules/v8-profiler-next/build/binding/Release/node-v93-linux-x64/profiler.node)
Any idea?

@Motik68,
Somebody else already reported this issue here.  I have no idea why it happens for some users.  Unfortunately he has not reported this as an issue in the v8-profiler-next repository (which I use for this Node-RED node), so the problem is not solved yet...
Bart

Thank you for your answer @bartbutenaers. I solved the issue by adding gcompat, which contains ld-linux-x86-64.so, to my system. Don't know why it was missing in the first place, but I am using Node Red as a ready-made docker container inside Home Assistant, so I guess it was omitted there.

Hi @Motik68,
Thanks for sharing your solution!!

@bartbutenaers , i have the exact same issue, the problem lies on the integration of baremetal or very small images created under docker which doesnt embed this library. it sound logical that under home assistant you have those issues since home assistan addons relies on docker images.
here is the libs i could find on the official nodered docker image :
bash-5.1$ ls /lib/
apk/                   libapk.so.3.12.0       libc.musl-x86_64.so.1  libkmod.so.2.3.7       libudev.so.1.6.3       mdev/                  udev/
firmware/              libblkid.so.1          libcrypto.so.1.1       libssl.so.1.1          libz.so.1              modules-load.d/
ld-musl-x86_64.so.1    libblkid.so.1.1.0      libkmod.so.2           libudev.so.1           libz.so.1.2.12         sysctl.d/
bash-5.1$ ls /usr/lib
Scrt1.o                   libbrotlidec.so.1         libctf-nobfd.so.0         libgcc_s.so               libitm.so                 libmpdec.so.3             libpsx.so.2.64            libstdc++.so.6.0.29
bash                      libbrotlidec.so.1.0.9     libctf-nobfd.so.0.0.0     libgcc_s.so.1             libitm.so.1               libmpfr.so.6              libpthread.a              libstdc++fs.a
bfd-plugins               libbrotlienc.so.1         libctf.so.0               libgdbm.so.6              libitm.so.1.0.0           libmpfr.so.6.1.0          libpython3.10.so.1.0      libsupc++.a
crt1.o                    libbrotlienc.so.1.0.9     libctf.so.0.0.0           libgdbm.so.6.0.0          liblzma.so.5              libncursesw.so.6          libpython3.so             libudev.so.1
crti.o                    libbz2.so.1               libcurl.so.4              libgdbm_compat.so.4       liblzma.so.5.2.5          libncursesw.so.6.3        libreadline.so.8          libudev.so.1.6.3
crtn.o                    libbz2.so.1.0.8           libcurl.so.4.8.0          libgdbm_compat.so.4.0.0   libm.a                    libnghttp2.so.14          libreadline.so.8.1        libutil.a
engines-1.1               libc.a                    libdl.a                   libgmp.so.10              libmagic.so.1             libnghttp2.so.14.21.2     libresolv.a               libxnet.a
gcc                       libc.so                   libedit.so.0              libgmp.so.10.4.1          libmagic.so.1.0.0         libopcodes-2.38.so        librt.a                   libzstd.so.1
libatomic.a               libcap.so.2               libedit.so.0.0.68         libgomp.a                 libmenuw.so.6             libpanelw.so.6            libsqlite3.so.0           libzstd.so.1.5.2
libatomic.so              libcap.so.2.64            libexpat.so.1             libgomp.so                libmenuw.so.6.3           libpanelw.so.6.3          libsqlite3.so.0.8.6       modules-load.d
libatomic.so.1            libcc1.so                 libexpat.so.1.8.8         libgomp.so.1              libmpc.so.3               libpcre2-8.so.0           libssl.so.1.1             python3.10
libatomic.so.1.2.0        libcc1.so.0               libffi.so.8               libgomp.so.1.0.0          libmpc.so.3.2.1           libpcre2-8.so.0.11.0      libssp_nonshared.a        rcrt1.o
libbfd-2.38.so            libcc1.so.0.0.0           libffi.so.8.1.0           libisl.so.22              libmpdec++.so.2.5.1       libpcre2-posix.so.3       libstdc++.a               ssh
libbrotlicommon.so.1      libcrypt.a                libformw.so.6             libisl.so.22.0.0          libmpdec++.so.3           libpcre2-posix.so.3.0.2   libstdc++.so
libbrotlicommon.so.1.0.9  libcrypto.so.1.1          libformw.so.6.3           libitm.a                  libmpdec.so.2.5.1         libpsx.so.2               libstdc++.so.6

if you re interrested to report to the nodered maintainers, for them to include the lib in next images, problem might be the portability.

Hi @ouinouin,
Unfortunately my private live at the moment doesn't allow me to digg into detail in this kind of issues.
If you know the solution, please be my guest to report it with the Node-RED core team.
If I am not mistaken you need to do it in this repository.
And if you do, please add a link to your ticket here so others can do a follow up.
Thanks!!
Bart

I worked around this by adding this to my docker-compose.yml
entrypoint: "/bin/bash -c 'apk add gcompat && bash entrypoint.sh'"

Maybe worth documenting?

I worked around this by adding this to my compose.yaml
entrypoint: "/bin/bash -c 'apk add gcompat && bash entrypoint.sh'"

Maybe worth documenting?

actually i m taking a bit of time to try this, but i get the following resulta while doing docker-compose up :
Attaching to nodered nodered  | ERROR: Unable to lock database: Permission denied nodered  | ERROR: Failed to open apk database: Permission denied nodered exited with code 99
@Impact123 do you have a custom docker nodered image  or something ?

I don't use this any more but I just have
image: nodered/node-red

you might have to use
user: root

whether you want to do that is your choice, of course

@ouinouin I just tested this and you can't switch to root from normal user which makes sense.
But you can do this
user: root
entrypoint: "/bin/bash -c 'apk add gcompat && su -c ./entrypoint.sh node-red'"

The container is started as root but node-red itself is started as node-red.
It's shown as impact because my user's UID is 1000 as well but su doesn't seem to accept it as an argument.
$ docker compose top node-red
node-red
UID      PID    PPID   C    STIME   TTY   TIME       CMD
impact   2625   2604   0    11:25   ?     00:00:00   /bin/bash ./entrypoint.sh
impact   2638   2625   0    11:25   ?     00:00:00   node-red

$ docker compose exec node-red grep node-red /etc/passwd
node-red:x:1000:1000:Linux User,,,:/usr/src/node-red:/bin/ash

$ id
uid=1000(impact) gid=1000(impact) groups=1000(impact),...

Does that help?

@Impact123 nice test, it will be helpful for many docker users.
i could start the profiling, unfortunately all the consumed time i was seeking for is located in internal functions of nodered :-D


Fixed _has_dns_propagated not returning False when failed

The hook currently doesn't work for me. The issue seems to be with _has_dns_propagated. It doesn't return False when failed. As create_all_txt_records specifically checks for == False, the hook assumes the DNS has propagated.

Nice catch! I should've been more careful back in 2128fca.


Add withOptions

Codecov Report

Merging #6 (26fd7fb) into main (77764fb) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           46        80   +34
=========================================
+ Hits            46        80   +34

Impacted Files
Coverage Δ

lib/index.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77764fb...26fd7fb. Read the comment docs.


feat: Add generated docs for languages and translations

Fixes #332

This has now been updated with all translations, too.  Please take a look when you have time!


Fix for case where refiner test runs in under 1 millisecond

Fix for case mentioned in chat where refiner test relies on 'now()' being after entity creation time.
@cromwellian is this the only test failure that you observed?

Fix for case mentioned in chat where refiner test relies on 'now()' being after entity creation time.
@cromwellian is this the only test failure that you observed?

Yes


Do we want date of creation boilerplate in GB?

（本稿完成日期：2018年1月）
Should something like this appear if we have a known created date?

Addressed by #32


import jQuery in the component

refs #52
This enhancement will mean that our users won't need to include jQuery in their project. This shouldn't break for anyone who has already included jQuery, but can we test in our projects before it gets merged into master.
Cheers
Brock

Works perfectly for me.

Hi,
When will this PR be added?
thanks

Sorry, waiting on a review from my colleagues, @paul-watkins-croud @kingy04
Will it help if I release a prerelease for testing?

Cheers, this has been released in v2.5.0

Awesome! Thanks!


Create Q1Q2-2024-dev-vtnerd.md

Will the use of hyphens, instead of underscores, in the filename cause issues? If so, I can close and create a new pull request.


psbt finalizer: error early on too short signatures

I forgot to append the ANYONECANPAY flag with my boutique signer for hand-testing and spent some time before realising we were actually treating the last byte of the sig as a valid SIGHASH_ALL in the finalizer !
I believe it's cleaner to error early on too short signatures.

An alternate strategy would be to just try and parse the signature with the "sighash byte" removed and fail early if that doesn't work.

Yes, can try this approach. Alternatively we could check the hashtype is standard: what do you think about adding a new method to SigHashType upstream which would fail on non-standard types (something like from_u32_standard)?

An alternate strategy would be to just try and parse the signature with the "sighash byte" removed and fail early if that doesn't work.

We already do that in the current finalizer code. Maybe this catches all errors as it unlikely that we form another valid der formatted secp signature if we remove one byte.
Treating unknown flags as all must have a backward compatibility good reason, that I can't think of right now.
https://github.com/rust-bitcoin/rust-bitcoin/blob/5bd61967b231939626dd847fd82cc5da33052dc1/src/blockdata/transaction.rs#L676-L689
I think for this case, it is useful to have a method like from_u32_standard.

Treating unknown flags as all must have a backward compatibility good reason

Yep, this is consensus behaviour (but not standard!).

I think for this case, it is useful to have a method like from_u32_standard.

Will PR it upstream, should be trivial.

Yeah, bitcoin core has aIsDefinedHashtypeSignature, but I think this may be context dependant because, in tapscript, we have a SIGHASH_DEFAULT too. But we can think about that later.

Done here https://github.com/rust-bitcoin/rust-bitcoin/pull/573

Yeah, bitcoin core has aIsDefinedHashtypeSignature, but I think this may be context dependant because, in tapscript, we have a SIGHASH_DEFAULT too. But we can think about that later.

Yes. Bitcoin-Core has EvalChecksigPreTapscript which indirectly call this check, for Tapscript it's checked in SignatureHashSchnorr.

Should we close this PR?

iirc i was waiting for a release of rust-bitcoin. Will check and close if needed

No, yeah i'm waiting for a rust-bicoin release since https://github.com/rust-bitcoin/rust-miniscript/pull/233#issuecomment-779695097

Is the recent 0.26.2 release sufficient?

Yes, just pushed an update that leverages the new from_u32_standard from https://github.com/rust-bitcoin/rust-bitcoin/pull/573 instead.

ACK b8432e11ae824ca2a906e80fd414cdb6f1e9e1a3


Bug: Sway/window "{shell}" format replacement not working (argument not found)

I'm using Waybar v0.9.13 on Manjaro and trying to include the shell (xdg_shell or xwayland) information on the window module, but that does not work. It makes the module not show and throw errors to stderr.
Config:
  "sway/window": {
    "format": "{title} [{shell}]"
  },

Full config (without the shell, bc it does not work): https://github.com/paulodiovani/dot-files/blob/main/home/user/.config/waybar/config
Expected behavior

Show the window name + shell in the desired format (e.g. "Zoom [xwayland]")

Current behavior

When included {shell} on sway/window#format config, the module is not rendered (nothing is shown)
Sway output includes (in journalctl): [error] sway/window: argument not found

Screenshots
Without shell. Format: {title}

With shell. Format: {title} [{shell}]

The "shell" feature was added on Aug 10, 2022 so after the release of waybar 0.9.13 in may. You will have to wait for the next release 0.9.14 or compile it yourself from master.

Perfect. Compiling from latest git worked. :)

Thanks.


Allow a custom image cursor

Fixes #8764
Looks like we have no choice put to force users to put their image file in the runelite directory to avoid breaks between machines. Alternative implementation to #8774 and simpler because it just adds another dropdown choice instead of a file chooser. Result is the same though in terms of having my own crab cursor. 🦀

I don't think the average user would be capable of putting a cursor image into ~/.runelite. What about being up a file selection dialog?

That is not portable

I don't think the average user would be capable of putting a cursor image into ~/.runelite. What about being up a file selection dialog?

That is what I first did at https://github.com/runelite/runelite/pull/8774

How hard would it be to store the cursor image in the config?

Do we do this anywhere else currently? I imagine base64 encoding the image probably won't be too bad, but I am worried about what would happen if the user uploads some bogus or really large file.

Given that #10237 has users place notification.wav into ~/.runelite, I feel we can have this plugin ask for the same.

I suppose so.... if you want to pick this up feel free

In that case, I'll probably just reopen https://github.com/runelite/runelite/pull/8774 and touch it up.

This is rebased and ready for another look.


Missing translatable components and overflowing date on tables

Lunar version: 0.1.4

Expected Behaviour:
Every texts should be translatable within the hub
Date should be displayed clearly
Actual Behaviour:
Some texts are missing translations
Date is not readable when selecting a range
Steps To Reproduce:
The best example is the "Orders" tab within the hub

(Every english words are missing translations, for clarity "Statut" is a translated word)

Good spot! @skyrowl Are you interested in taking a look at these?

Closing due to now using Filament panel


add new optional field non_shipping_rpms to support 4.3

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   70.81%   70.81%
=======================================
  Files          11       11
  Lines         257      257
  Branches       33       33
=======================================
  Hits          182      182
  Misses         74       74
  Partials        1        1

Impacted Files
Coverage Δ

validator/schema/image_schema.py
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a1e476...47f158b. Read the comment docs.


Tie python tests into CIT

There are some test_* things in tools/ that should ideally be run as part of submit check

@elmsfu - Is this done now?

@elmsfu - Is this done now?

Not to my knowledge SymbiFlow/symbiflow-arch-defs#520 runs tests under symbiflow-arch-defs/utils.
We should consider gathering coverage information.

Hrm, the Python tests do seem to be running?
if [ -e env/bin/activate ]; then . env/bin/activate; fi; which py.test; py.test --ignore third_party --ignore .git --ignore env --ignore build --ignore docs/venv --ignore fuzzers --ignore minitests --ignore experiments --doctest-modules --junitxml=build/py_test_results.xml
/home/travis/build/SymbiFlow/prjxray/env/bin/py.test
============================= test session starts ==============================
platform linux -- Python 3.6.3, pytest-4.4.0, py-1.8.0, pluggy-0.9.0
rootdir: /home/travis/build/SymbiFlow/prjxray
collected 15 items
docs/markdown_code_symlinks.py .                                         [  6%]
prjxray/lib.py .                                                         [ 13%]
prjxray/util.py .                                                        [ 20%]
tests/test_util.py .                                                     [ 26%]
utils/cmp.py .                                                           [ 33%]
utils/sort_db.py .........                                               [ 93%]
utils/xjson.py .                                                         [100%]

Closing. Looks like you fixed it in #491


Blue dot doesn't show on the map right after user grant permissions on Android

🐛  Bug Report
When I open a map and press button, which calls function that query user's current location for the first time and user grant permissions, blue dot doesn't show on the map. I will get user's location, but the dot is not there. When I open the map again, everything works as expected.
On iOS it works just fine.
Configuration
Android simulator with Android 10 and real device with Android 9
Version: 5.3.2+2
Platform:

[x] :robot: Android

Flutter doctor result
[✓] Flutter (Channel stable, 1.20.2, on Mac OS X 10.15.6 19G2021, locale en-GB)
• Flutter version 1.20.2 at /Users/user/development/flutter
• Framework revision bbfbf1770c (10 days ago), 2020-08-13 08:33:09 -0700
• Engine revision 9d5b21729f
• Dart version 2.9.1
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/user/Library/Android/sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
✗ Android license status unknown.
Try re-installing or updating your Android SDK Manager.
See https://developer.android.com/studio/#downloads or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions.
[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.4.1, Build version 11E503a
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[!] IntelliJ IDEA Community Edition (version 2020.1.4)
• IntelliJ at /Applications/IntelliJ IDEA CE.app
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• For information about installing plugins, see
https://flutter.dev/intellij-setup/#installing-the-plugins
[✓] VS Code (version 1.48.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.13.2
[✓] Connected device (1 available)
• iPhone 11 Pro (mobile) • 5D097071-2FD7-481A-B5B6-AC5D438FFB15 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)

@TenPetr, to me it looks like this is more a problem with the map plugin then the geolocator. We only fetch the location of the device and not handle any map or other system events that work with the map.
We did however released a new release candidate of the geolocator plugin which handles retrieving locations a lot better then the current version, you could give it a try. But otherwise I would look at the map plugin you are using (e.g. the google_maps plugin tries to acquire the device's location all by it self so it by passes the geolocator al together here).


Travis CI not running tests

I can't make Travis CI work (spoiler: I haven't used it before). Check it our here.
For every single test, the log states:
Test did not run: the test bundle stopped running or crashed before the test suite started.

The tests are only run for the OS X target.

Do you need to update xctool ? and use    - LANG=en_US.UTF-8 setting.
I think it could be deleted. as a first step
env:
   global:
   - LANG=en_US.UTF-8

before_install:
- brew update
- brew outdated xctool || brew upgrade xctool

try removing sdks and clean
.travis file
osx_image: xcode7.1

language: objective-c

- xctool build -project Async.xcodeproj -scheme "Async iOS"
- xctool build -project Async.xcodeproj -scheme "Async OSX"
- xctool  build test -project AsyncTest/Async.xcodeproj -scheme "AsyncOSX"

after_success:
- bash <(curl -s https://codecov.io/bash)

Here is a problem. When I run this command on my local PC, it crashes
- xctool  build test -project AsyncTest/Async.xcodeproj -scheme "AsyncOSX"
Probably it's the same bug on travis
Test did not run: the test bundle stopped running or crashed before the test suite started.

application requires at least Mac OS X version 10.11.0 (10.11), but is being run on 10.10.5 ( 10.10.5/14F1021), and so is exiting.
CRASH REPORT: AsyncOSX_2015-11-03-213633_Konstantins-MacBook-Pro.crash

Process:               AsyncOSX [83287]
Path:                  /Users/USER/*/AsyncOSX.app/Contents/MacOS/AsyncOSX
Identifier:            AsyncOSX
Version:               1.0 (1)
Code Type:             X86-64 (Native)
Parent Process:        xctool [82726]
Responsible:           iTerm [227]
User ID:               501

Date/Time:             2015-11-03 21:36:31.949 +0100
OS Version:            Mac OS X 10.10.5 (14F1021)
....

When I open project and try to run tests they are failing.
Unit test should be ruined very fast, it it takes more that 0,5 second to run a test - it's way to much

I copied some else .travis.yml, so most things aren't because I know they need to.
Whether I use xctool locally or xcodebuild` it works just fine.
I've changed som thing in the tests, so they're less likely to fail due to GCD acting up e.g. som "after" 1.1 second fired 1.09 seconds after. Now I have padding of time on both sides of target.
The length of the tests are to wait for testing dispatch_async_after. Since they respond ±200 ms, the test have target times to 1-2 seconds. Could probably reduce a bit, but then the tests would be less accurate.

if it works local it should also work remotely. Just make sure to use OS X 10.10.5
Also here is mine very simple travis file, and it works
https://github.com/kostiakoval/PiList/blob/master/.travis.yml

Travis doesn't support 10.11?

nope :( not yet, you can see it in the log error message.
https://travis-ci.org/duemunk/Async/builds/89083187

application requires at least Mac OS X version 10.11.0 (10.11), but is being run on 10.10.5 ( 10.10.5/14F27), and so is exiting.

just change the target to older OS X version. then it works

Also change the SDK?

Oh, that one is set to "Latest" so should work fine.

Check my changes I did in this PR

Yeah, I've included them! Thanks :+1:

The tests work now!! Thanks for the help.
The iOS build fails though. Due to some code signing. Is it really necessary to set that op to make it work?

nope I don't think so. But you need to set correct signing setting in the project

Would this by any change be "correct"?


Enum encoding

closes #352
blocked by FuelLabs/sway#1872
the CI fails because it is using forc 0.15.1 which does right padding on enum values, while our code does left. There is an e2e test to check for this regression and it is making the CI fail. When this PR is ready to be merged the CI environment will have to be updated to use 0.15.2. @vnepveu
Context on the problem/solution
Tokens are used to encode/decode arguments to/from the VM.
Previously Enums were represented as Tokens that had only the discriminant and the Token that is pointed to by that discriminant. This is inadequate to properly encode enums. More context in the issue.
In order to inform the encoder of the enum's variants, a third argument was given to the EnumSelector -- a Vec<ParamType> which holds the types of the variants of the enum in question.
The encoder then proceeds to determine the biggest variant and pad the enum appropriately.
The decoder was changed to ignore the extra padding so as not to read into the next argument.
About doing it in compile time RFC
Theoretically, the proper encoding size for all custom enums could have been determined at compile-time and baked into our custom enums.
I took the liberty of trying out this approach as well, you can take a look at it here.
This same process was done inside the abigen! macro and the resulting word size was baked into the EnumSelector during its creation in into_tokens. For decoding the size was also given to the ParamType making it of the signature: ParamType::Enum(variations, usize).
Although I cannot overstate how much I like doing it during compile time, ultimately I decided against it because it seemed to damage code cohesion. The hardcoded enum size was baked into the generated Enum types -- that rubbed me the wrong way. Although Tokens don't exist for anything else but to facilitate encoding/decoding, it felt out of place to have such a hard coded number beside a bunch of types -- as if I'm taking a bit of what used to be the responsibility of the encoder (to determine VM type sizes) and putting it into our custom types.
I'd like to hear your thoughts on this. Do you find the compile-time approach acceptable? Is the damage to cohesion palpable to you as well?
Although it goes without saying that the compile-time approach is more performant, I found the differences to be negligible. Especially in the light that I don't see anybody passing overly deeply nested types which would require a bunch of recursions to figure out its type should it ever be an enum variant.
Since coding/decoding types is temporally coupled to making a network request, I cannot see that we would ever get any noticeable speedup compared to the time the network request took.
Where to put an e2e test?
The code is covered by unit tests. Ideally, I'd have an e2e test showing that the VM receives the enum correctly, doesn't mangle other arguments, and properly returns it.
I don't know where to put it... the rest of the tests of that kind live in fuels-abigen-macro -- but they are testing that the code-generation is working correctly, and that is not what I would test.
Was thinking of creating a similar integration tests folder in fuels-core if that is alright with everyone?

Commits can be squashed

Commits can be squashed

Thanks, didn't consider that. I've squashed them :)

Fix CI. I don't understand where the enum_input Sway test project comes into play, and so I don't understand why the unit_type_enum and use_enum_input were removed.

Hey @vnepveu , "use_enum_input" sway project was used by the "unit_type_enums" and "workflow_use_enum_input" harness tests. They didn't test whether the contract understood the enums as we did. And mostly didn't check whether we understood the enums as the contract did. Both are important for proper enum functioning.
Both those tests were merged into one as per suggestion, which is now called 'enum_as_input'.
The new e2e test checks that a standard enum, as well as a 'unit' one, can be passed into and received from a contract function -- and that nothing was mangled in the process.
Since these are e2e tests it is difficult to single out only one thing to test with them. For example:
The 'contract understood our enums as we did, and we understood its enums as it did' basically means that the coding/decoding of enums is working properly. There is already a test for that but it is specifically geared towards guarding against a regression -- i.e. it has extra parameters around the enum so that they might get mangled in the case of a regression in forc which we can detect.
The new 'use enum as input' test has a bit of overlap with the encoding test but it tests our handling of code generation as well -- that we can handle generating code for both standard and unit type enums when they appear as direct inputs/outputs to a function.

My question specifically is "why is the test project still here if it's not used anywhere"

My question specifically is "why is the test project still here if it's not used anywhere"

Here is the list of all tests projects in my branch:
https://github.com/segfault-magnet/fuels-rs/tree/segfault_magnet/352-enum-encoding/packages/fuels-abigen-macro/tests/test_projects
It doesn't contain 'use_enum_input'.
I've added 'enum_as_input' and 'enum_encoding' both of which are used in the harness.rs.

It contains enum_as_input, got confused with all the renaming

ok sry got confused.


Minimizing / Maximizing godot using the taskbar after saving crashes godot

Godot version
4.0 rc1
System information
Windows 10
Issue description
Using the taskbar to min/max the godot window will crash godot if you have saved your game (I use ctrl+s to save my game)
Steps to reproduce
Create an 3D project. Save it, minimize and maximize the window using the taskbar.
Minimal reproduction project
N/A

I have also testing the window buttons at the top right, using these cause godot to freeze and then crash for me as well

Ok so after restarting my computer the problem went away. Should I leave this up?

This might have been unstable graphics drivers after an update and before a reboot then. (Or drivers got in a failed state for some reason and started misbehaving for the rest of the session.)

I see. Thanks for your attention to this problem :)


Duplicate module name: react-native

The podspec cause the problem as below when I try react-native start after pod install.
Loading dependency graph...(node:73522) UnhandledPromiseRejectionWarning: Error: jest-haste-map: @providesModule naming collision:
  Duplicate module name: react-native

React is deprecated in Cocoapod.
RNGestureHandler.podspec
s.dependency "React"

And it makes others confused even they are using react-native link instead of cocoapod.

@JeffGuKang I had the same issue and it was solved by adding React/Yoga to my podfile like @lebedev suggested:
pod 'React', :path => '../node_modules/react-native'
pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'
pod 'RNGestureHandler', :path => '../node_modules/react-native-gesture-handler'


tests integ: Introduce the bridgelib module

Extract the Linux Bridge helpers from the linux_bridge_test module in
order to reuse them in other tests.

@Nandan307 , this may help you with your other tests.

Coverage remained the same at ?% when pulling 763e2cd368af0b65ec26c8ec6d75b6045641444f on EdDev:tests-bridgelib into 10688dead995231478001f333672cf6df598c042 on nmstate:master.


BonSai Tree 3 World Load Crash and tick lag

I tried to use this mod with other mods I have and I at first noticed a slight hesitation about once a minute or so, figured maybe it was due to loading new Chunks at first.
Then today I went to load an old world, did that successefully so closed that world and opened another to have a crash.
I read through my logs to find that BonSai Tree 3 did indeed crash the system.  I'm hoping to help resolve the problem as I love your mod.
I'm including my crash report and my long list of mods I and my family use on our home server
crash-2022-02-03_00.00.17-fml.txt
.

Mods as follows
Additional Lanterns
Alex's Mobs
AmbientSounds
Amplifed Nether
Appleskin
Aquaculture
Aquatic Torches
AutoRegLib
Balm
Biomese O Plenty
Blue Skies
Buddy Cards
Caelus
Carpet Stairs Mod
Catalogue
Chalk
Chunk Loaders
Citadel
Cloth Config
Configured
Controllable
CraftTweaker
CreatFA
CreativeCore
Croptopia
Curios
CuriosElytra
Dungeons Arise
Elemental Swords
Enchantment Descriptions
Ender Chest
Falling Leaves
Fast Leaf Decay
FlyWheel
Framework
Funriture
GlobalXP
Gobber2
Goblin Traders
Golden Hopper
Inverntory Sorter
Iron Chest
Iron Furnaces
JEI
MCW Lights
MCW Roofs
Multi
Nether PortalFix
Optifine
Patchouli
Placebo
Quark
Quark Oddities
Recall
Refined Storage
Refined storgar Addons
ShetiphianCore
Silent Gear
Silent Lib
Simple Magnets
Sit
Sky Villages
Smarter Farmers
Sophisticaed Backpacks
Storage drawers
Structure Gel
SuperMartijn Config Lib
SuperSmartijn Core Lib
TerraBlender
Tetra
Textirel Backup
TheOne Prob
Trash Slot
WitherSkeleton Tweaks
World Edit
Xaeros Minimap
Xaeros World Map.

You are missing libnonymous.

This looks like a version issue with the dependent Libnonymous.  Class not found likely means you are using a older version of this mod that does not have the class that Bonsai uses.
Try updating the version of Libnonymous (backup first though as that might break your other mods that use that library mod.


Unique solution of Regression

Feature Request
Hello. I use SR to fit a dataset, while the result for each running is not the same. For example this is a result of one running:

And this is another:

Here the results are totally different. Is there any settings or hyperparas to make the result unique? :)

If you find a different solution each time (excluding real degeneracies, like how x/2.0 and x*0.5 are identical), then that means you haven’t run the search long enough. Try increasing niterations so it can do a deeper search. Also see https://astroautomata.com/PySR/tuning/ for tips.
If you want identical solution regardless of convergence, you can also use deterministic=True.


Explore

Adds a search bar to the dropdown called 'Explore'. Still needs to implement the actual search functionality.
Refactors navbar to use  components that function correctly both on develop and builds.
Installs react-fontawesome
Closes #55

Also made it so dropdown do not automatically expand on smaller devices - this way if a user adds several dropdowns to the navigation, they will not overcrowd the navMenu when active


Support for Swift CocoaLumberjack Pod dependency

Hi! Thank you for a great tool!
I wanted to check if it's possible to support Swift CocoaLumberjack available as a Pod using 'CocoaLumberjack/Swift' reference? This is the how CocoaLumberjack suggests referencing the module from Swift projects:
platform :ios, '8.0'

# You need to set target when you use CocoaPods 1.0.0 or later.
target 'SampleTarget' do
  use_frameworks!
  pod 'CocoaLumberjack/Swift'
end

Currently, LumberjackConsole is using Pod 'CocoaLumberjack'.
In my app, there are other libraries that also reference 'CocoaLumberjack/Swift' Pod, so having the console to point to the 'CocoaLumberjack' Pod introduces problems with dependency tree.
I wonder if we could have a fix for that or maybe you could point to some workarounds?
Thank you!

If this project works with CocoaLumberjack/Swift, then feel free to Pull Request it.
You can test it by forking the project, modifying the podspec, and then add git: <YourFork> to test it.


Traits concept

How I think traits could work. Note this does not work at the moment, it is only concept. .
Benefits:
The user dont have to modify the element routine depending on material type, but can get the material response from all materials (by passing the deformation gradient).
Some other stuff I though about:
I think we should decide what the material should output, ie dSdE or dPdF etc...
If we should allow "delta-strains" (Δε) or force ε + state variable.

So the goal with traits is to be able to call any material function from your element routine and get back the stress and tangent that you element routine is based upon.
So if your element routine is based on the work pairs S and E, you can now call material_response_S_dSdE (name up for discussion), and you will get back S and dSdE.
If someone else uses element routine with work pair P and dPdF, they can call material_response_P_dPdF.
and so on... People can add more work pairs function if they like, but I guess there are only 2 or 3 common ones...
Instead of having very explicit function names as above, it could be possible to also associate a material with a "output" trait, and then we could maybe reduce the code a bit (now it quite a lot of copy pasting), but I dont think we should overuse the trait system...

What do you think of allowing to pass a singleton type, similar to how the stress/strain wrappers work? The default could be interfered from the StrainTrait (to be the work-conjugate stress type to the strain type probably), but in an element routine that requires a certain stress type the singleton type could be passed to make sure to get the right returns.
I think this wouldn't really be any different to the explicit function names, but it would make the call to the material routine much more consistent with the small strain routines and it would not add an additional trait (also the returned stress type should probably not be a property of the material - you could want the same material to return S in one element routine and P in another).

Thanks @koehlerson
I was able to slim the code a bit by defing a "tangent output struct/trait"
The user call is now:
mat = NeoHook(λ = 1.0, µ = 1.0)
state = initial_material_state(mat)
F = Tensor((2.0, 0.0, 0.0, 1.0, 1.0, 0.0, 0.0, 0.0, 1.0))
Δt = 0.0

S, dSdE, state = material_response(dSdE(), mat, F, state, Δt)

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@ebcf0a4). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage        ?   87.53%
=======================================
  Files           ?        8
  Lines           ?      337
  Branches        ?        0
=======================================
  Hits            ?      295
  Misses          ?       42
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebcf0a4...705ecc4. Read the comment docs.

Annoyingly this gives an error
S, dSdE, state = material_response(dSdE(), mat, F, state, Δt)
I must change name of the output variable name dSdE to something else for it work. Should find a new name for dSdE()...maybe with partials deriviatives instead.

 I did a rebase and all commits duplicated for some reason... Does not matter though, it will be squashed-merged.

I messed this branch up...open new PR...


Clarify component instantiation remark

Fixes #13694
For reverting "can be" back to "isn't," the original was correct (i.e., "isn't"). That's the point of what Steve is saying ... person.Address can throw, but person can't.
Thanks @tdykstra! 🏍

These are trivial updates, so I'm going to go ahead with this. 🏃


Fides.js modal overlay blocks interaction with the website

Bug Description
In this screenshot, there is an (invisible) modal overlay div that covers the entire page and prevents my ability to click any of the Cookie House buttons, etc.

This is surprising - although we call this component a "modal" I'd expect it to be more like a dialog so I should still be able to scroll the page, click on buttons, etc.
Steps to Reproduce

Run the E2E test environment locally
Open the modal
Try to click on any of the Cookie House elements

Expected behavior
Scrolling & clicking in the original website continue to work

Closed by https://github.com/ethyca/fides/pull/3480

moving to done


sbt occasionally outputs "Copying runtime jar." and completes successfully after 1 second

steps
sbt version: 1.3.5
Run sbt as usual
problem
Occasionally sbt outputs Copying runtime jar. and nothing else, no exit code(i.e. sbt completed succesfully). It completes in 1 second when this happens.
If I re-run sbt, it works fine.
expectation
If there is a problem, sbt should not just output Copying runtime jar. and exit, but rather print out an error message.
notes

This might be a duplicate of https://github.com/sbt/sbt/issues/5270.

@eed3si9n  Yes: I believe it is. Might as well close this bug. Sorry for the duplication.


Convert MockWebServer to run on Okio.

Closes #1175.

More work done here. Still not passing all tests.

More work done here. Still not passing all tests.

LGTM

LGTM

Since this is spiraling into a bigger change than I wanted (since API changes have to happen) I'm going to break it up into multiple PRs.


Mock react-ga library during tests

Type

Improvement to existing feature

Description
Currently, tests try to call the real React-GA library and produce warnings:

By mocking the react-ga library we make it so that its initialize function becomes stubbed out and never get truly executed.
For discussion
I think it would be also possible not to mock react-ga in individual test files, but to create a __mocks__ directory at the same level as node_modules, and create a react-ga file with a mock version of react-ga (see jest docs). The advantage of this approach is that we won’t have to mock react-ga in individual test files. The disadvantage is that a root-level __mocks__ folder looks unnecessary and ugly. Not sure which option to prefer.

I think the __mocks__ folder would be a better solution to this than adding individual mock statements for react-ga.

Although it looks ugly, I like the idea of having the __mocks__ directory as it has a very good purpose. Since ga and similar functionalities will be used throughout the app, it would be better to go with this approach so that the tests can remain simple.

I couldn’t make the __mocks__ directory work for me. However, an alternative solution that I found was to put jest.mock command in a setup file, which looks, I think, even nicer than the solution with the __mocks__ folder.
(I also moved setup-enzyme.ts file in the tests folder)

Are there any more changes that need to go into this PR?

@imran-ebi yes, I just added the last commit to remove test awareness from analytics-service itself.


Staging

That's quite a lot of files to review and ideally we'd have time to discuss the needed changes.
We'll first test the change on lists.dev and then lists.stg and if we're happy with needed changes (we have to reconvert all mailman archives) we can merge into main branch and so it will be rolled out to prod.

The PR was sent with the intention of having something tangible to start with and it doesn't have to be the final one. New changes and adjustments are always welcome so we can implement the project needs.
We certainly want to do the mailman archives reconvert after testing and retesting what we have in both dev and stg.
For prod, once we agree about the project needs and their implementation is tested, I would like to suggest, if possible, the project to wait until the CentOS Stream 9 distribution release to switch the website design, so both distribution and website are visually consistent at the same time. If something could be chained in the distribution release process to make the website to switch its design when the new ISO files are available that would be perfect although it is not strictly necessary.
Thanks @arrfab for your time and efforts. Appreciate a lot your guidance.
Best regards.

As discussed on irc, let me merge that in staging branch and reapply on dev and stg instances automatically to see how it goes .
We can adapt from there


API Manager deployment fails due to undefined url & protocol

In my case, unfortunately with commented these 2 lines deployment has failed.
https://github.com/Azure-Samples/AI-Gateway/blame/ff11430921b54d7452cad820ed6cf1c69318ed8a/labs/built-in-logging/main.bicep#L285
I believe, the same will be true for mock pool.
https://github.com/Azure-Samples/AI-Gateway/blame/ff11430921b54d7452cad820ed6cf1c69318ed8a/labs/built-in-logging/main.bicep#L302

Thanks Alexander! Are you using the latest az command line?

Yes, the latest CLI available at that moment was used.  version: 2.60


WIP: Update clientside from coffeescript to es6

TODO for 2019-game page: add global ajax listener to update score on page when call occurs from game.

Rebased on master just now


Cant sign in

Your environment
Windows 11
op-vscode version:
v1.0.4
VS Code version:
1.71.0
CLI version:
2.5.1
OS:
Steps to reproduce
run this

What happened?

What did you expect to happen?

Notes & Logs
["ERROR" - 12:00:35 PM] Error executing CLI command

I also wonder if this has anything to do with windows hello, because I can't enable windows hello due to group policy

never mind. it is caused by no windows hello.


vmsnapshot: Add quickview to the list of VM Snapshot

Description
This PR is used to fix the Quick access menu bar missing for VM Snapshots
Fixes https://github.com/apache/cloudstack/issues/4607

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
UI
After fixed:

How Has This Been Tested?

UI build: :heavy_check_mark
Live QA URL: http://primate-qa.cloudstack.cloud:8080/client/pr/4614 (JID-3828)

UI build: :heavy_check_mark
Live QA URL: http://primate-qa.cloudstack.cloud:8080/client/pr/4614 (JID-3828)


How to combine with another container (like wekan)?

Forgive me if I have misunderstood, but how would one go about combining this with another container such as wekan for example:
https://github.com/wekan/wekan/wiki/Install-Wekan-Docker-in-production

It's simple. Don't expose the port on the host (it's what the reverse proxy ist for).
Leave out these lines:

ports:
- 8081:80

Instead you want to add the following environment variables to the Wekan container:

VIRTUAL_HOST = domain
VIRTUAL_PORT = 8081
LETSENCRYPT_HOST = domain
LETSENCRYPT_EMAIL = your email that shows up in the certificate

Thanks very much!
So would I need to stop the existing docker containers (ie. the reverse proxy etc) first?
I am currently running this setup:
https://help.nextcloud.com/t/nextcloud-nginx-reverse-proxy-letsencrypt-in-docker-containers/1687
Ideally I would like to be able to add additional containers (and remove them) with minimal disruption to the existing running containers.

Thanks my friend.
Okay, so I have the following as my docker-compose.yml but I can't seem to get it to work. It builds fine and I can see the containers running via docker ps -a however when I visit the domain I get an nginx 503 error page....?  Any thoughts?  Is there a complete step-by-step guide somewhere perhaps like the one you did for nextcloud+nginx+letsencrypt?
wekan:
  image: mquandalle/wekan
  links:
    - wekandb
  environment:
    - MONGO_URL = mongodb://wekandb/wekan
    - ROOT_URL = https://projects.domain.tld
#    - MAIL_URL = smtp://user:pass@mailserver.example.com:25/
#    - MAIL_FROM =<EMAIL_ADDRESS>
# Insert environment variables so we can use the existing reverse proxy setup.
    - VIRTUAL_HOST = projects.domain.tld
    - VIRTUAL_PORT = 8081
    - LETSENCRYPT_HOST = projects.domain.tld
    - LETSENCRYPT_EMAIL =<EMAIL_ADDRESS>

#  ports:
#    - 8081:80

wekandb:
   image: mongo
   volumes:
     - /mnt/docker/wekan/data:/data/db

Issue closed due to age.


Refine filtering / selection range (number/time) by text input

Allow selecting the end point and adjusting the end point by text.
This will allow for finer control of the range selection.
Options:

Click on the end-point in the filter summary
Click on the breadcrumb - the number

For time, this would be a calendar widget.

For time selections, consider using https://github.com/dbushell/Pikaday . It doesn't have other dependencies, and looks well designed.


It should report errors on too many actions

A workflow file may contain up to 100 action blocks. Action blocks must have a unique identifier and must have a uses attribute.
https://developer.github.com/actions/creating-workflows/workflow-configuration-options/#events-supported-in-workflow-files

:tada: This issue has been resolved in version 1.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Vercel deployment docs conflict

The default Vercel deploy docs state that you don't need any additional configuration to deploy static sites, while the @astrojs/vercel docs state that you need a vercel.json.
https://docs.astro.build/en/guides/deploy/vercel/#static-site
https://docs.astro.build/en/guides/integrations-guide/vercel/#why-astro-vercel
I'm happy to make a PR, but I'm not sure which docs are correct.

Thanks for this, @alex-grover! This is a documentation issue, but not the one you're thinking of!
In fact, both docs are correct because the Vercel integration is only for SSR, and is not necessary for deploying static sites.
Someone added a note for the adapter usage about the vercel.json file in the wrong place on that adapter page, and it's misleading right now because it looks like it's related to static site deployment. I have a note to go and change that information's location to be further down the page, where it's clear that it is a note about this SSR adapter's usage. I'm sorry you hit this before I could get that change made!
I'm assuming the original wording I intend to revert to at the top of the page would not be confusing?

If you’re using Astro as a static site builder — its behavior out of the box — you don’t need an adapter.
If you wish to use server-side rendering (SSR), Astro requires an adapter that matches your deployment runtime.

thanks for the clarification! your proposed updates make sense to me 👍🏽


Add async_read support for pull_blob API

This API allows blobs input stream integrate seamless with following blob processing using Rust's asynchronous IO types like async_compression.
Fixed: #53
Signed-off-by: Wang, Arron<EMAIL_ADDRESS>

@arronwy I've just published v0.9.4 that features your patch

@arronwy I've just published v0.9.4 that features your patch

Thanks a lot for your quick review and new v0.9.4 release, much appreciated!

@flavio Not a big deal for something this small, but generally a feature add should probably be a new minor release rather than patch (so 0.10.0)


[release-0.5] Update k8s apimachinery

related to ECOPROJECT-1741

/test ?

/test 4.12-openshift-e2e

see https://github.com/medik8s/self-node-remediation/pull/148 for a working version

closing in favor of #148


question and help❓ how could  memory_efficient_attention_forward could work on the concatenating batches?

memory_efficient_attention_forward is invoked in prefill phase.
This function expects the input tensor to have a shape of [batch_size, num_seq, num_head, head_size].
However, previously, the queries and other tensors were transformed using torch.view, torch. unsqueeze, resulting in a shape of
[1, batch_size * num_seq, num_head, head_size].
Doesn't this difference in tensor format from what memory_efficient_attention_forward pose a problem? How do we ensure that the final result is correct?
in my own test. concating batches does not have the same result..., please enlighten me.
import torch
from xformers import ops as xops

device="cuda"
dtype=torch.float16
#[B,M,H,K]
query = torch.rand((3, 136, 32, 64), dtype=dtype, device=device)
key = torch.rand((3, 136, 32, 64), dtype=dtype, device=device)
value = torch.rand((3, 136, 32, 64),dtype=dtype, device=device)

resized_query = query.view(-1, 32, 64).unsqueeze(0)
resized_key = query.view(-1, 32, 64).unsqueeze(0)
resized_value = query.view(-1, 32, 64).unsqueeze(0)

scale=1.0/(query.size(-1)**0.5)
print(scale)
out1 = xops.memory_efficient_attention(query, key, value, scale=scale)
out2 = xops.memory_efficient_attention(resized_query, resized_key, resized_value, scale=scale)
out2 = out2.view(3, 136, 32,64)
print(out1.shape,out2.shape)
# the TWO results are not same.
assert torch.allclose(out1, out2, atol=1e-2, rtol=1e-2)

I have the same question while reading source code. What is the answer of this issue?

to my understanding, memory_efficient_attention_forward has
an argument : attn_bias which is initialed as BlockDiagonalCausalMask.  it may be related to this.

Hi thesues, your comment has just solved my confusion about this question, thanks a lot


chore: refine collect-windows-logs.ps1 to enable crt by default

What type of PR is this?
/kind feature

What this PR does / why we need it:
Enable crt by default for collecting containerd information. Give an option to disable since it costs time in some cases.
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.409%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
2620

Relevant Lines:
3669

💛  - Coveralls


Seeing progression update

I know that we can see progression update in notifications. Good
It would be good to see progression also directly on the program bar, for movies and series, by a progressbar bar or any other way.
Thank you.
Mizuu is briilliant.

Not quite sure how it should be implemented or why it'd be necessary. There's a reason why Android has a notification bar :-)


[T4A3][T13-B3]Ong Qi Yong

Ready for review

Generally a good job. Notice that it is not a good idea to expose your variables unless it's necessary.


x/mobile: ld: illegal text-relocation to 'type..eq.[0]string'

When including the generated gomobile framework in another framework, calling gomobile framework method causes linker failure with message "ld: illegal text-relocation to 'type..eq.[0]string'"

Duplicate of https://github.com/golang/go/issues/9210.

The only workaround before #9210 is fixed is to keep targeting SDK version 22.
<uses-sdk
        android:minSdkVersion="15"
        android:targetSdkVersion="22" />

@rakyll Sorry if I wasn't clear. This is for iOS framework. When code of custom iOS framework calling methods that are generated by gomobile cause illegal text-relocation.

Sorry, it was not clear from the text.
/cc @crawshaw

updated the original report.

Hi @KennyAtBaidu. Can you tell if this is coming from the ARMv7 or ARMv8 (arm64) binary? (You can extract the individual .a files by running gomobile with the -work.)
For ARMv7 it looks like we are not compiling as PIC for iOS, which is easy to fix. For ARMv8 I was under the impression the compiler was generating PC-relative code by default, but I tried to confirm with a quick inspection of the compiler and it's not clear to me.

Hi @crawshaw
It seems like
bind -work

gives me x86_64, armv7, and arm64 architecture. I'm not really familiar about PIC, is there anything I can do on my end?

Ok great, then this might be easy to fix. I'll try to attach a cl later today.

do we have any updates? I also hit into this.
can I know how to workaround this if we cann't fix it immediately.

same here. And thank you for your great effort.

I spent a couple of unproductive days trying to make PC-relative relocations work with darwin/arm. I'm close: the right instructions are generated, it's just the arithmetic is off. It will probably take me the rest of the week to make this work, assuming no other serious bugs appear.
In the mean time, you can extract the arm64 binaries as described above and work exclusively with those. This means your programs won't run on older iOS hardware, but it may be enough to keep you going for now.

I have not had any luck generating a pc-relative macho relocation on arm. Every relocation I've tried (including SECTDIFF encoded as a scattered relocation) has ignored the PC-relative bit, and instead gives me an absolute relocation or zero.
If anyone has any ideas I'm all ears.
Meanwhile, next week I'll try setting up the exact environment that produced this error and see what about the text relocation is bothering it. Maybe there's some other way to make Xcode happy.

I can see the individual statics with -work, can you briefly explain how I can get them back into xcode?
Otherwise is there another quick way of getting the embedded framework to function?

I just tested this and it works fine (except for a warning) with armv7+arm64. It stops working when I add amd64 to the fat binary.

I did something like this to generate the binary without amd64:
FRAMEWORK=Mysdk # this is your package name capitalized
gomobile bind -target=ios -prefix=$FRAMEWORK
cd $FRAMEWORK.framework/Versions/A
lipo Coresdk -thin armv7 -output /tmp/armv7.a
lipo Coresdk -thin arm64 -output /tmp/arm64.a
lipo -create /tmp/armv7.a /tmp/arm64.a -output $FRAMEWORK

@crawshaw hi, is there anything we can help with to help you fix this issue?

I backported https://github.com/golang/go/commit/aea4222f673ee9189ba81548978b091004afe994 to go 1.6 and it's working way better.

@crawshaw @cherrymui thanks for your hard work on this issue.
I tested this on tip but I'm getting the following error:
gomobile bind -target=ios
gomobile: reading export data: /var/folders/y_/ws09jpg90_b5y710wmd7kvj5sbl416/T/gomobile-work-499035079/fakegopath/pkg/darwin_arm/path/to/my/sdk.a: unknown version:
make: *** [ios] Error 1

so I backported the commit to go 1.6 but when compiling I'm getting a similar error to the previous one:
ld: illegal text-relocation to 'go.string.*' in /test/sdk.framework/sdk(go.o) from 'runtime.interhash' in /test/sdk.framework/sdk(go.o) for architecture armv7

Let me know if we can provide more information.

@dcu is the first error in your comment, about "reading export data", fixed? I believe I saw the CL go by updating the gcimporter, and have no been able to replicate that error message.

@crawshaw no, sorry I forgot to update here.
This got fixed after #15519 and updating gomobile.  it works on both 1.6 and 1.7.
Now we are getting errors when trying to install on a armv7 device because of a signature (according to the error message). Some of the issues are reported here: #15657
The other issue is that enabling armv7 requires the 386 sim I'm not sure why.


Search dialog covers the underlying line at the top of editor.

Search dialog covers the underlying line at the top of editor. This is particularly an issue when that line contains the string that you just searched. Is there anyway we can fix this? Any ideas? Thank you.

Doesn't the dialog disappear when you search, so that it can not cover something you 'searched' only something that you are 'going to search'?

the dialog will not disappear if it's in 'replace' mode, thus if the 1st line contains a matching it will never appear, i think amshali was right here


CAMEL-20044 Backport breakOnFirstError Fix to Camel 4

Description
The fix for breakOnFirstError that was merged in #11959
Target
main
Tracking
CAMEL-20044

@orpiske
Just copied over the commits
Am looking at changes that may be necessary for the tests

@orpiske Just copied over the commits Am looking at changes that may be necessary for the tests

Ok updated tests

/component-test kafka

https://github.com/apache/camel/actions/runs/6888126595

tests 2.log
Camel 4 changes probably need a bit more adjustments. Attaching the logs ...

The CI cannot run full test as there are local files changed that are not in the PR. This usually happens in camel-catalog etc.

Thanks for your contribution @CodeSmell!


TIM-134 feat(events): create events activity sidebar design

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#83
#82  👈
#81
#80
#79
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xdjeremy and the rest of your teammates on  Graphite


[1.10.2] Block updates are performed even when notifyNeighbors is set to false

If notifyNeighbors is set to false, blocks like torches still fall even though physics should be ignored.
https://github.com/SpongePowered/SpongeAPI/blob/master/src/main/java/org/spongepowered/api/block/BlockSnapshot.java#L123

This is now changed with https://github.com/SpongePowered/SpongeAPI/pull/1315 and you should be able to restore without block physics and notifying neighbors.


Cross: Setting up Azure

AS A developer
I WANT access Azure
SO THAT I can read/contribute to resources on Azure platform

[ ] Users are added and roles assigned accordingly

Could I have input on who needs access?

This is a good question!
I would suggest at the very least @yahya130, but ideally people on the team that are writing code so we can give access to view of the resources of at least the 'dev' environment for testing/debugging.  Other environments may not or should not give us access.
Off the top of my head from the MSFT side that would be:
@martinkearn
@decodingahmed
@Adele-Churchill-13
@guypritchard
@yahya130
For the ability to view resources.
From the Netgroup side @joonasroosalung may have a better idea.
I believe we'll have at least one Service Principal which is capable of creating/modifying resources in various environments to be used by Terraform to do its work, but I think we have a separate issue for that.
@martinkearn  - anyone I'm missing here, anyone anything I've not thought about?

@keijoraamat would it be worth adding the following tasks/AC's to this item?

Create resource group on Azure (suggested name: rg-beurokratt-dev )
Create storage container on Azure manually to store the terraform state file

We have access to the resource group and can create resources and we have a service principal.