Won't change language

I've included the bootstrap dropdown to my main menu. It shows up correctly, and I can select another language. But it doesn't actually switch languages; my application always shows up in English. And it resets the language switch to English if I reload the browser page. Is there anything you have to do besides adding the language switch to your page?

Was my error. I placed the i18n files under /client, because I wanted to put them next to the corresponding templates.


Support Container-based tests inherit Jenkins settings for git repos and branches

In our External tests, which are container-based tests, we set a new local environment inside the container different from jenkins host settings, since using default get.sh (code link). This caused problem in some situations, e.g. release JDK version doesn't match with openj9 master branch functional tests inside container. Several steps to support this:

[ ] Pass git repos and branches in Jenkins parameters into docker
[ ] update get.sh parameters to inherit Jenkins settings for git repos and branches (code link)
[ ] modify other test.sh files in external tests, similar as above step

try https://github.com/adoptium/aqa-tests/blob/master/scripts/testenv/testenvSettings.sh


transfer xattr with selinux filter

It does not make sense to try and transfer selinux xattrs as the selinux context of the files are based on the storage type. For example nfs_t for nfs, fuse_t for glusterfs, container_t, for others. However it may still be reasonable to want to transfer other xattrs. In order to do that we'd have to filter selinux xattrs, which this is supposed to do, though it is completely untested.

Closing. Re-open if needed.


Unable to use own types

type MyType string

type Response struct {
 Type MyType json:"type"
}

It falls into an endless loop when trying to create a schema for documentation

I found the problem. It affects part of primitives with the custom types. I've already fixed it. Will be part of a next release.

New release is available: https://github.com/meteran/gnext/releases/tag/v0.7.0
It fixes the discussed issue.


chore: upgrade typescript

FYI Bun fails to minify TypeScript v4 but it succeeds with v5 so this hides this error


TheIDE windows version shows parsing errors

I downloaded Protect package from:
https://www.ultimatepp.org/forums/index.php?t=rview&th=5547&goto=49922
When I open "ProtectEncrypt" from linux, parsing is OK:

But when I open it from Windows 10 Enterprise LTSC in vmware workstation, it shows parsing errors:

I've attached the source files(put "Protect" and "Xed" in uppsrc, and "ProctecEncrypt" in MyApps):
ProtectPackage.zip

This might be fixed in the current master, please check.

Problem still exists:

If you activate Assist diagnostics in Settings/Assist, there should be
"Current file parse errors" in Assist menu. Can you dump that list here?
Also, looking at the screenshot, it feels like it is possibly actual error.
If it is not "private" code, can you send me "ProtectEncrypt"?
On Wed, Sep 6, 2023 at 7:41 AM Song Yadong @.***> wrote:

Problem still exists:
[image: xxx]
https://user-images.githubusercontent.com/1529102/265904100-e771f15e-948c-410d-bbb5-154f06042e81.png
—
Reply to this email directly, view it on GitHub
https://github.com/ultimatepp/ultimatepp/issues/162#issuecomment-1707701299,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARH2352Z2FZT3SE6OSIJP3XZAEHPANCNFSM6AAAAAA4CNOH7Y
.
You are receiving this because you commented.Message ID:
@.***>

Everything is in the zip. Put "Protect" and "Xed" in uppsrc, and "ProctecEncrypt" in MyApps:
ProtectPackage.zip

parse_errors.txt

Well, it does not build either. The problem is in Xed - VERSION file
conflicts with standard library version file. Renaming VERSION to VERSION0
fixes both build and Assist.
On Wed, Sep 6, 2023 at 12:06 PM Song Yadong @.***>
wrote:

Everything is in the zip. Put "Protect" and "Xed" in uppsrc, and
"ProctecEncrypt" in MyApps:
ProtectPackage.zip
https://github.com/ultimatepp/ultimatepp/files/12460929/ProtectPackage.zip
—
Reply to this email directly, view it on GitHub
https://github.com/ultimatepp/ultimatepp/issues/162#issuecomment-1708049515,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARH23774FDGDRQSZP2KDE3XZBDK3ANCNFSM6AAAAAA4CNOH7Y
.
You are receiving this because you commented.Message ID:
@.***>

Thanks. MSVC17 compiler is OK with VERSION file. I'm just wondering why Linux does not have such problem.

Linux: "VERSION" vs "version" I think - win32 is case insensitive.
All that said, maybe assist handling of internal includes is not quite
correct - I put that dir at the end of include path...
Mirek
On Thu, Sep 7, 2023 at 2:46 AM Song Yadong @.***> wrote:

Thanks. MSVC17 compiler is OK with VERSION file. I'm just wondering why
Linux does not have such problem.
—
Reply to this email directly, view it on GitHub
https://github.com/ultimatepp/ultimatepp/issues/162#issuecomment-1709305136,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARH23YUB4E4I76F3YI354DXZEKPLANCNFSM6AAAAAA4CNOH7Y
.
You are receiving this because you commented.Message ID:
@.***>

OK, clear now.


ISPN-13997 Configuring memory max-size as non-byte value causes failu…

https://issues.redhat.com/browse/ISPN-13997

Integrated into main, thanks @ryanemerson !


Fixed use of concat on label and control in order to work with cells

I fixed use of concat on label and control in order to work with Cells (https://github.com/apotonick/cells).
In Cells concat returns array instead of string and this code throw error about problem with convert ActiveSupport::SafeBuffer to Array.

Is this fix still needed to work with the latest version of Cells? If so I'll consider merging it in. Thanks for the PR!

I tested with Cells 4.1.2 (released 2 days ago) and it works without this fix.


Flasher not detecting my device

The flasher doesn't detect my device. I have tried 3 different cables to connect to it, and nothing is working. Here are the logs:
`
Note:Detect serial port changed.
Note:Auto MAP serial port.Port-->COM3
Note:Serial port connected.
Note:Begin find ESP8266.
`

Im getting the same thing, just with COM4 port


Issue #925: Added noncopy constructor for Tensor and TensorT

Added methods reserve() and constructor for Tensor and TensorT

Looks good - only thing would be to add a test, and we can then merge. You can add this on the Tensor test file.

Just following up, do you think you would be able to have a look with a short test @ThePseudo  ?

Sorry for the delay, at some point stuff happened and I lost track of a few things (one being this). I created a short test, which could be expanded upon, but is basically "inspired" by the other test already present. I hope this works!

No worries @ThePseudo, thank you for following up - running test suite

@ThePseudo it seems tests failing, did you run locally?

The terrible thing is that I am not really an expert in the Google test suite... but I found that the tests were failing for a good reason, apparently, and it is building. Which is strange, since "it worked on my machine", but let's try this out

Thank you @ThePseudo - remaining commment on a small docstring change required

It should be done now, but tell me if the format is not correct (I took inspiration from previous docstrings)

Added extra suggestion as it needs to follow the same format as rest of docstrings

Thank you @ThePseudo - signed commit required, and we should be able to wrap it up :)

Thank you @ThePseudo - signed commit required, and we should be able to wrap it up :)

Forgot it, now added! :D

Thanks!


Make wallet_handle injectable when creating connection

Signed-off-by: Patrik Stas<EMAIL_ADDRESS>

Codecov Report

Merging #525 (74f3959) into main (9a59824) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   54.99%   54.99%
=======================================
  Files         168      168
  Lines       14588    14588
  Branches     4031     4031
=======================================
  Hits         8023     8023
  Misses       2357     2357
  Partials     4208     4208

Flag
Coverage Δ

integration-aries-vcx
42.85% <0.00%> (ø)

unittests-agency-client
23.61% <ø> (ø)

unittests-aries-vcx
51.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aries_vcx/src/handlers/connection/connection.rs
52.58% <0.00%> (ø)

aries_vcx/src/handlers/out_of_band/receiver.rs
34.28% <0.00%> (ø)

aries_vcx/tests/utils/devsetup_agent.rs
50.15% <0.00%> (ø)

aries_vcx/tests/utils/scenarios.rs
50.09% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.


Implement Virtual Filesystem Infastructure

wrap IO operations into pluggable modules
associate a "VFS" with a HTTP scheme (e.g. http -> HttpFileSystem)
only asynchronously reading whole files, and subranges from files for now
first implementation for HTTP

-> special: MemoryFileSystem, for preloading files into memory, where special-case synchronous file access is required (e.g. for third party libs)

closing old bugs


[bugfix] - fix CallArg <-> SuiJson conversion logic

Description
This PR fixes a move value to SuiJson bug, SuiJson was mainly used for displaying human readable json back in the day, the move object to json conversion was "best effort" and occasionally converting number into ascii strings. This PR changes the conversion and now uses the function signature to determine the correct type before doing the conversion.
This RP also changes the input parameter of SuiProgrammableTransaction to SuiCallArg instead of using SuiJsonValue directly.
Test Plan
SuiJson conversion logic are covered by unit tests
Also did some manual test locally.
Example PT response:
{
    "jsonrpc": "2.0",
    "result": {
        "digest": "3FuXQ4UHg7jUCWGrTvmagDYmq2wXggRU5S8Gx7YKQSkz",
        "transaction": {
            "data": {
                "messageVersion": "v1",
                "transaction": {
                    "kind": "ProgrammableTransaction",
                    "inputs": [
                        {
                            "type": "object",
                            "objectType": "sharedObject",
                            "object_id": "0x0000000000000000000000000000000000000000000000000000000000000005",
                            "initial_shared_version": 1,
                            "mutable": true
                        },
                        {
                            "type": "object",
                            "objectType": "immOrOwnedObject",
                            "object_id": "0xf2e2c3cf773758027959170d2d7369a08c3be9d455a35b3d316feaa1950fa453",
                            "version": 1,
                            "digest": "6aQw2cGxuSmf6SuLd8C7t2LnStM293GSi5D1kVwKPYsD"
                        },
                        {
                            "type": "pure",
                            "valueType": "address",
                            "value": "0xc64291042b33e860faa3f733953676cd7bc24462bf8fc79bc1d3ac2ac214ebc2"
                        }
                    ],
                    "commands": [
                        {
                            "MoveCall": {
                                "package": "0x0000000000000000000000000000000000000000000000000000000000000002",
                                "module": "sui_system",
                                "function": "request_add_stake",
                                "arguments": [
                                    {
                                        "Input": 0
                                    },
                                    {
                                        "Input": 1
                                    },
                                    {
                                        "Input": 2
                                    }
                                ]
                            }
                        }
                    ]
                },
                "sender": "0xce1bf7db5ad6b04bfc305c049f08b80d5ccdc5d6d65d2ded13e95516d1e9fa22",
                "gasData": {
                    "payment": [
                        {
                            "objectId": "0x3121afc2890c0eb0cad14d495b4682618c12a1ac73577e7f9a45b04619c755d9",
                            "version": 3,
                            "digest": "DWnuhB7WGepk4bHysVs4jvpDA1bMcWdEqgzoX6zkRHeq"
                        }
                    ],
                    "owner": "0xce1bf7db5ad6b04bfc305c049f08b80d5ccdc5d6d65d2ded13e95516d1e9fa22",
                    "price": 1,
                    "budget": 100000
                }
            },
            "txSignatures": [
                "AFCWZe8Gy8m/enRPZEygzUq23H3O8IANSYnP4jHc5i8pSJdt0f8ZBrUH+0vwnlxyos9A0CzPcoCKSWm66ZbMJgvMmmv2BbuYf+KmNsqJ2ti6sOAiFwS/SbKh1OCWydu6vg=="
            ]
        },
        "timestampMs":<PHONE_NUMBER>370,
        "checkpoint": 1160
    },
    "id": 1
}

I don't see many new tests. Are you confident we don't need additional tests?

I don't see many new tests. Are you confident we don't need additional tests? @patrickkuo

I have added a few unit tests for String and option type as they require special handlings, the rest is covered by e2e tests, we have quite a few e2e tests in TS SDK which tests from move to the SDK end.

I don't see many new tests. Are you confident we don't need additional tests? @patrickkuo

I have added a few unit tests for String and option type as they require special handlings, the rest is covered by e2e tests, we have quite a few e2e tests in TS SDK which tests from move to the SDK end.

Right, I missed the SuiJson one, thank you.


Questions about DSPy Optimizers

DSPy is a important part of this project, I haven't seen code that load optimizer output into module.
Do you use DSPy optimizers for prompting? Could you share some of your experience with that? It will be very helpful for people to understand better about this project.
Thanks.

Thanks for your question! The project is developed before many cool DSPy optimizers came out, so we haven't included them in our codebase.
Using DSPy optimizers to optimize prompts could be a cool thing to explore especially when you want to run STORM with smaller LMs. I would suggest initiating a discussion in DSPy community where you are more likely to get response or useful experience.


Definition of done in the PRs points to the development guidlenes

Description
Definition of done does not point to the coding guidelines. Maybe a general link to the development section of the documentation can be added.
We noticed this during reviewing #30
Goals
Make sure all contributors follow the development processes of Ankaios.
Tasks

[ ] do it 😉

The DoD shall also request the documentation to be up to date.

This should be done as part of #36 IMHO.

Closed in favor of #36.


Add olm + catalogs to mgmt cluster

Testing:
./bin/hypershift install --hypershift-image quay.io/ecordell/hypershift:mgmtcatalogs14
./bin/hypershift create cluster --pull-secret=./build01config.json --aws-creds=<aws creds> --name="guest" --base-domain=devcluster.openshift.com --release-image=<image>

./build01config.json should be a pull secret for the build01 ci cluster
<image> should be a release image from cluster-bot built with build openshift/operator-framework-olm#69,operator-framework/operator-marketplace#396
the pull-secret for the ci-cluster needs to be added to the default serviceaccount both in the hypershift namespace and in the clusters-guest namespace so that imagelookup pods succeed

Results:

default catalogs are deployments in the host cluster
default catalogs auto-update via imagestreams with scheduled import (instead of relying on the host's catalog-operator to update)
actual CatalogSource objects for the defaults are in the normal place in the guest (openshift-marketplace) but instead of referencing the catalog images directly, they point to the service address of the catalogs in the host.
additional CatalogSources can be added to the guest
catalog-operator and packageserver need to talk to services in the guest and the host (for user-provided and default catalogs), so they both have the vpn sidecar and a dnsmasq sidecar (that can check both guest and host dns to resolve catalog endpoints)

TODO
Guest nodes lack credentials for redhat registries - this means many operators fail to install, for example:
Failed to pull image "registry.redhat.io/openshift4/ose-clusterresourceoverride-operator-bundle@sha256:081a1e247e2d4be1b502b7e336d73ae03d0203bd1ad8d03ce2d7bf61ae969ebe": rpc error: code = Unknown desc = unable to retrieve auth token: invalid username/password: unauthorized: Please login to the Red Hat Registry using your Customer Portal credentials. Further instructions can be found here: https://access.redhat.com/RegistryAuthentication

Resource Usage
Host resources used with 1 custom catalog (on guest), 4 default catalogs, 1 operator installed, otherwise at rest.
catalog-operator 364.9 MiB	0.005 cores
olm-operator     121.2 MiB	0.008 cores
packageserver    91.7 MiB	0.020 cores
packageserver    86.2 MiB	0.020 cores
---------------------------------------
all operators    664 MiB 0.053 cores

certified-operators 135.4 MiB	0.016 cores
community-operators 181.8 MiB	0.019 cores
redhat-marketplace  110.4 MiB	0.012 cores
redhat-operators    191.6 MiB	0.014 cores
-------------------------------------------
all catalogs        619   MiB   0.061 cores

total 1283 MiB, 0.114 cores

Potential savings:

packageserver should only have 1 replica (- 90MiB)
catalogs should stream their contents instead of building the entire response in memory (-500MiB)
catalog-operator package cache should (configurably) flush to disk instead of staying in memory (-200MiB)
improve at-rest client-go caching (?? MiB)

target total: ~400MiB

Will need reconciled with @csrwng's work in https://github.com/openshift/hypershift/pull/200 which we expect to merge next week, we're moving away from the template system

I want to discuss how to reconcile this with @csrwng's refactor away from templates in this operator; merging ~35 more right now seems like it could be fatal to the effort. I propose Cesar's refactor merges first and then all new contributions to the operator (including this one) follow the new template-free pattern.
/hold

I also want to revisit the DNS discussion to understand what we can do with CoreDNS to avoid managing dnsmasq for any reason whatsoever.

/close
replaced by https://github.com/openshift/hypershift/pull/265


Update README with dependencies and environment variables

To use accessibility, there is a dependency on Taiko Plugin
npm install --save-dev taiko-accessibility

Also steps assume presence of environment variables like APP_ROOT_URL.
Document all environment variables and any other dependencies.

PR #10 fixes this.


create action for tool

Allow cyclonedx-node-npm to be executed using github actions
name: Generate SBOM

on:

jobs:
  sbom:
    runs-on: ubuntu-latest
    steps:
    - uses: CycloneDX/cyclonedx-node-npm
      with:
        path: "."

thanks for the contribution, @fnxpt, but
could you give any context to this particular Pull request ?
I don't see a description, and the commit message only says "create action for tool".
I will put this PR on "DRAFT" until this is clarified.

Firstly: let's discuss via #473 the reasons behind it, to help understand responsibilities and capabilities of such a GH-Action.

Issues I have with the current state of the pullrequest, that need to be discussed:
There are multiple things to be considered, before your solution could be actually taken into account:
Your solution would always install some version of @cyclonedx/cyclonedx-npm via npm, while it is sitting in a repo with a probably different version of the tool itself.
This might conflict with user expectations.
How should action versioning work? The version of an GH action is a tag.
If the action just uses installs always the latest version of @cyclonedx/cyclonedx-npm, this conflicts with the tools version.
And it does not know semantic versioning -  having a proper action sitting in the same repo as the tool is cumbersome and error-prone.

Ok, so the @GHaction is a branch but it was just to give context, when used, users should use either a branch or a tag, and maybe we should add an additional parameter to get a specific version of the tool

updated the PR with an input for the version and also some instructions on the README

Hello, @fnxpt, I am the author and maintainer of this tool.
Please come to #473 and tell what all this is about.
Let's talk first, implement later. :)

Closing this since we can use npx to run it directly


Add & delete attachments possibility

@alexsdutton @cchurch @chris-bradley Please have a look.

@pierrejochem Unfortunately (or maybe fortunately?) I haven't had to use this library in awhile, and don't have access to a SharePoint environment to test.  However, any implementation seems better than raising NotImplementedError to me.

But I have :smile: Great work from you guys!

@cchurch I could contribute to the project

@cchurch I would make the merges and testing

@pierrejochem I ended up writing the exact same code for the add function. When I try to add an attachment using a str object as the content I receive a vague error:
``  File "", line unknown
XMLSyntaxError

Hello @bash-j
I need more Details. Could you please try first my version from here:
https://github.com/pierrejochem/python-sharepoint

Hi @pierrejochem
I found the content returned by the request was empty because the server was returning a 400 error, so lxml had nothing to parse. I discovered SharePoint is expecting a base64 array. After a lot of trial and error I found the following code works with a string, a text file and binary files.
def add(self, filename=None, content=None, upload_file=None):
       if upload_file:
           if not filename:
               filename = upload_file
           with open(upload_file, "rb") as filein:
               f = filein.read()
               econtent = base64.b64encode(f).decode()
       else:
           econtent = base64.encodebytes(content.encode()).decode()
       xml = SP.AddAttachment(SP.listName(self.list_id),
                              SP.listItemID(str(self.row_id)),
                              SP.fileName(filename),
                              SP.attachment(econtent))
       response = self.opener.post_soap(LIST_WEBSERVICE,
                                        xml,
                                        soapaction='http://schemas.microsoft.com/sharepoint/soap/AddAttachment')

Sorry, yes of course:
https://msdn.microsoft.com/en-us/library/lists.lists.addattachment(v=office.12).aspx
attachment => A byte array that contains the file to attach by using base-64 encoding.
It was self-evidently for me so I have not ask for it. But you found it by yourself and that is important.


no license options for tools create

Sub-issue from #142.
The licenses select dropdown at tools/create contains no options.

@sxren i wonder if we want to be more selective re our list of licenses (where did you pull these from). Also what do you think about patching upstream vs here (very happy to take this direct patch now to get stuff moving).

Would be great to see that license info published as (Linked) Open Data.

@akuckartz comments on the licenses as license data should go to https://github.com/okfn/licenses

@rgrp the data is from http://licenses.opendefinition.org/licenses/groups/od.json
can you clarify patching upstream?

@sxren see the comment in #142 about the upstream repo for the creator being https://github.com/okfn/datapackage-init - though I note in this specific case if we are inlining the license data we probably want to do it here though we could do it into the datapackage-init repo (demo directory).

@rgrp gotcha! so only patch the view here. put the rest in datapackage-init.

@sxren how are you doing on merging this upstream?


Define number of archives to keep

When the archive mode is activated, we would like to configure how many archives will be kept on the IPT.
Ex: keep the 10 last versions of each resource

This seems very sensible.
As a workaround, I wonder if a periodic, manual process that removed historical versions and restarted the IPT would simply remove them. If anyone gets a chance to test it, please post the results here.

For a manual procedure (advanced users only):
Be aware this has potential for unrecoverable data loss, and should only be attempted by someone familiar with the consequences

remove the versions from the resource.xml as described in this issue comment
locate the associated files to remove and delete them from the file system. e.g. to remove version 1.1 of resource you delete:

aaa-1.1.rtf
dwca-1.1.zip
eml-1.1.xml

restart the IPT

Like #1508 , it's sensible, indeed, but there is a problem to fix: how to avoid too much disk consumption, when auto publish is used.
And again, a manual process could be the solution - even if I trust more java code with unit testing than manual operations :)
Here is the PR: https://github.com/gbif/ipt/pull/1514

Thanks for working on this. I've merged it into the master branch, and tested it on UAT.


Abandoned?

Is this repo abandoned?

Seems like it, but its working good as it is. I did all necessary fixes on m fork https://github.com/reaz1995/telescope-vim-bookmarks.nvim , if someone  have problem with keymaps just add them to telescope keymaps for normal mode mappings, like so:
["dd"] = require('telescope').extensions.vim_bookmarks.actions.delete_all,
["dx"] = require('telescope').extensions.vim_bookmarks.actions.delete_at_cursor,
["dc"] = require('telescope').extensions.vim_bookmarks.actions.delete_selected,
["dv"] = require('telescope').extensions.vim_bookmarks.actions.delete_selected_or_at_cursor,

Seems like it, but its working good as it is. I did all necessary fixes on m fork https://github.com/reaz1995/telescope-vim-bookmarks.nvim , if someone have problem with keymaps just add them to telescope keymaps for normal mode mappings, like so:
["dd"] = require('telescope').extensions.vim_bookmarks.actions.delete_all,
["dx"] = require('telescope').extensions.vim_bookmarks.actions.delete_at_cursor,
["dc"] = require('telescope').extensions.vim_bookmarks.actions.delete_selected,
["dv"] = require('telescope').extensions.vim_bookmarks.actions.delete_selected_or_at_cursor,

Hi I have the issue  here. Do you know how to solve  it?

Hi there! Sorry for taking so long to respond - I'm not using vim-bookmarks anymore, so I won't maintain this plugin anymore. If somebody wants to take over, let me know!


Protect main branch

We want to protect the main branch of the repository so that developers have to submit merge requests to incorporate changes.

Added.


500 Internal Error (universe.js)

universe.js:139 GET https://rinkebysidechain-land.webaverse.com/1-100 500 (Internal Server Error)
getParcels @ universe.js:139
(anonymous) @ 58571433-b050-4470-80da-2ebc543b4763:12
(anonymous) @ 58571433-b050-4470-80da-2ebc543b4763:104

This looks like it may be cached? But it's because of the constant, we can hardcode it as mainnet now, since rinkeby is not used https://github.com/webaverse/app/blob/master/constants.js#L14
Similar to #902

Looks like this was fixed after updating to latest version


[SPARK-23792][DOCS] Documentation improvements for datetime functions

What changes were proposed in this pull request?
Improved the documentation for the datetime functions in org.apache.spark.sql.functions by adding details about the supported column input types, the column return type, behaviour on invalid input, supporting examples and clarifications.
How was this patch tested?
Manually testing each of the datetime functions with different input to ensure that the corresponding Javadoc/Scaladoc matches the behaviour of the function. Successfully ran the unidoc SBT process.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

ok to test

mind resolving the conflicts?

Test build #91606 has started for PR 20901 at commit 6dea103.

@HyukjinKwon, merge conflicts have now been resolved

Test build #91620 has started for PR 20901 at commit 2544d93.

Test build #91606 has finished for PR 20901 at commit 6dea103.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91606/
Test FAILed.

Test build #91620 has finished for PR 20901 at commit 2544d93.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91620/
Test PASSed.

Test build #4291 has started for PR 20901 at commit 2544d93.

Test build #4291 has finished for PR 20901 at commit 2544d93.

This patch fails Java style tests.
This patch does not merge cleanly.
This patch adds no public classes.

The failure isn't related:
[error] (kubernetes-integration-tests/*:checkstyle) java.io.FileNotFoundException: checkstyle-config.xml (No such file or directory)
[error] Total time: 258 s, completed Aug 25, 2018 2:45:08 PM

(There has never been a checkstyle-config.xml in the project)
Master test jobs don't hit this, but a few other PR builder jobs do. Some don't. Weird, I'll try again.

Test build #4292 has started for PR 20901 at commit 2544d93.

Test build #4292 has finished for PR 20901 at commit 2544d93.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged to master


Planet blacklist/whitelists

Version of Advanced Rocketry
AdvancedRocketry-1.12.2-1.4.0-88-universal
Have you verified this is an issue in the latest unstable build
N/A
Version of LibVulpes
LibVulpes-1.12.2-0.2.8-32-universal
Version of Minecraft
1.12.2
Description of the problem
Allow us to blacklist biomes from spawning on other planets such as twilight forest biomes from spawning on other planets.

there's the 'BlacklistedBiomes' list in thr advancedRocketry.cfg config that can be used to do just that.


feat(steaming): use table_id as topN prefix for keyspace

What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Replace operator_id to table_id for TopN.

Add a fields table_id in TopNode proto. This is designed to use indenpendent table_id to replace operator_id
gen_table_id when build the stream_fragemnet and recaluc truely table_id when generate_steam_graph
use keyspace::table_root to replace keyspace::executor_root for table_id prefix
refactor some code logic for pattern match

Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

https://github.com/singularity-data/risingwave/issues/2925
https://github.com/singularity-data/risingwave/pull/1987

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.李堉 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Pls sign the CLA

Is this PR conflicts with yours? cc @wcy-fdu
Also I don't quite remeber, what's the PK of top_n in the internal table?

Is this PR conflicts with yours? cc @wcy-fdu
Also I don't quite remeber, what's the PK of top_n in the internal table?

sort key + original pk


Float FAQ images to the right within text blocks

This one would be nice to clean up!

I just committed some code to main for this, right after you fixed the layout bug on the /error page


Get user from FirebaseFirestore

Hello,
I try to get specific user, and for that I create user_service but when I try to get a user I have this error:

Unhandled Exception: type 'Timestamp' is not a subtype of type 'int?' in type cast

The line affected by the error is the following:

createdAt: json['createdAt'] as int?,

My code is the follow :
  Future<types.User?> readUser() async {
    final User? user = _firebaseAuth.currentUser;
    final DocumentReference<Map<String, dynamic>> docUser =
        FirebaseFirestore.instance.collection('users').doc(user!.uid);
    final DocumentSnapshot<Map<String, dynamic>> snapshot = await docUser.get();

    if (snapshot.exists) {
      return types.User.fromJson(snapshot.data()!);
    }
    return null;
  }

thanks for your help,

Hi! AFAIR firebase stores dates in some firebase's format, and you need to modify it to milliseconds (int) before using User.fromJson. Similarly to this line https://github.com/flyerhq/flutter_firebase_chat_core/blob/main/lib/src/util.dart#L114


[HUDI-3468][RFC-48] Support sync with DataHub

Read with pictures
https://github.com/xushiyan/hudi/blob/HUDI-3468-rfc-48-datahub-sync/rfc/rfc-48/rfc-48.md

@xushiyan in the future, please always grab the RFC number first. in the README and then proceed to author the RFC itself. 48 is already taken on master. I am going to make this 49


Normalize format of config file

This will let us script changes to it with less noise in the diffs.

This broke in some interesting way. I'm guessing some configlet change, maybe, since when I run the unit tests script locally I also see failures with no changes in master. Whatever the issue is, it's the same in xkotlin, so I assigned myself to all the related issues while I investigate.
See https://github.com/exercism/configlet/compare/v1.1.0...v2.0.0 for the relevant configlet changes.

Confirmed, if I update the unit-tests script to explicitly use configlet v1.1.0 (the prior release to today's v2.0.0) then unit tests run fine. Reading that diff more closely...

@stkent I made those changes in Configlet—how can I help?

config.json does not include [_template].

Where is _template?

@kytrinyx the output I'm seeing is this warning:
config.json does not include [_template].

However, I see it in the current config file:
"ignored": [
  "_template",
  ".gradle",
  "build",
  "docs",
  "gradle",
  "scripts"
],

I have just started to look at the configlet diff posted above; perhaps your more experienced eyes can spot any regression there faster than I will be able to? ❤ 🤞

This is the problem: https://github.com/exercism/xkotlin/tree/master/exercises/_template
@stkent The assumption we make is that every directory within exercises is an exercise. If you place the _template in the root, that would fix this.

There's a _template dir nested in exercises that is meant to be the seed for new exercises.

Ahh, gotcha, thanks!. Which line of configlet is hiccuping there (for my own edification)?

It's not a configlet problem, it's a conceptual problem. We used to tell Configlet to ignore directories named certain things (per the config.json). When we removed that, configlet assumes that every single directory it finds within the exercises directory is an exercise. The code is here: https://github.com/exercism/configlet/blob/master/configlet/track.go#L100-L123

The change that caused this to fail is removing the IgnoredDirs() here: https://github.com/exercism/configlet/pull/17/files#diff-40e62472ea4139af33eebcc8f65668ebL94

Ah ha! In that case I would humbly suggest that for clarity we might want to update the error message:
config.json does not include [_template].

to something more explicit like:
Exercise named _template found in exercises directory but not declared in the exercises block in config.json.

Haha yes. You did.
So... you could also stick it in "deprecated" in config.json, which would mean that configlet would stop complaining about it.
I will update the error message, though. That's a good call.

I've relocated the template to the root dir in both xkotlin and xjava; that seems cleaner than deprecating a fake exercise. Thanks for taking on the error message update!

@kytrinyx if you could please rebase this against master, the CI build should now pass!

w00t! Thank you!

Build is timing out; Travis seems 🐌 tonight. Trying again tomorrow.

Build still timing out today 🤔. Gonna play with some speedups here. @sdavids13 can you see anything in the recent commit history that might be slowing down recent builds?

I'm going to rebase so it builds within the 50 minute limit!

I'm going to rebase so it builds within the 50 minute limit!

A most excellent measure!

Are there going to be merge conflict headaches with https://github.com/exercism/xkotlin/pull/51?

Yes, but I'm happy to take care of fixing up #51.


tests/test_cmdline.py::CmdLineStdoutTest::test_cmd_help fails on large terminals

The test CmdLineStdoutTest::test_cmd_help in tests/test_cmdline.py checks for a certain number of lines in the output.
However, optparse formats the output according to the terminals column count (often given by the environment variable COLUMNS; if detection fails, 80 is used).
The smaller the terminal the more line breaks occur.
The current test tests against at least 30 lines. Which is fulfilled on smallish terminals (e.g. 80 columns).
However, on larger terminals (e.g. 200 columns) every option description fits into one line reducing the count to 23 and the test fails.
This pull request changes the test to test against 20 lines (to have some leeway) to also support large terminals.
The number of lines in the help output of a command depends on the terminal.
An alternative way would be to always run the test suite with COLUMNS=80 set as environment variable.
However, this puts the burden onto the user which have to ensure to have the "correct" environment.

Thanks!


Add corona certificate to the apple wallet

Hi,
Would be great to be able to add the certificate to the apple wallet.
Is there any plan to implement this feature?

Internal Tracking ID: EXPOSUREAPP-7811

@abrenner94 Thanks for the suggestion. This is a duplicate of:
https://github.com/corona-warn-app/cwa-app-ios/issues/2965
https://github.com/corona-warn-app/cwa-wishlist/issues/646
https://github.com/corona-warn-app/cwa-wishlist/issues/732
https://github.com/corona-warn-app/cwa-wishlist/issues/755

Internal Tracking ID: EXPOSUREAPP-7811

@dsarkar Can this be closed?


Add test to reproduce behaviour

#1275
We are totally brainfucked, but this should reproduce our confusing somewhat.

Great... I was able to reproduce the error I'm getting within our application by writing a failing but broken test case. I'll invest some time tomorrow to debug our application stack as the error must be somewhere there. Maybe some broken event subscriber or something similar - will see. @malarzm: do you wan't me to remove the test case?

@gruberro I've included all tests from here in #1278 so whatever suits you :)

I finally found the "making it buggy" trigger (https://github.com/doctrine/mongodb-odm/commit/ab89a77dd3a50707e348ba26b2e8235cc9acd629). By using a preUpdate lifecycle callback (even if it's doing nothing) elements are removed from the collection. I lost some hair either in the meantime ;)

I suppose that'll be because UnitOfWork recomputes change sets for document that had preUpdate callback - I remember that the same trigger was reported when reusing embedded document that was already scheduled for orphan removal.

So is this a bug or expected behaviour?

Unfortunate but expected (as of now) behaviour I'd say.

Even though it loses data? with 1.0.2 it works, and with 1.0.3 we lose items...

@alcaeus wrote full explaination on why is this happening: https://github.com/doctrine/mongodb-odm/issues/1275#issuecomment-156501140. If we don't merge #1278 for whatever reasons (I for one don't like making it O(n)) you may add items in new collection and replace the old one entirely.

@sharpner @gruberro Closing this to consolidate discussion into #1278.
We'll take a look at what exactly is going on with preUpdate and see if we can work around it.


Added unit test for MutationDetail

Fixes #2567

@sufyanAbbasi  PTAL?

Why do we need test coverage for a data class?

Why do we need test coverage for a data class?

Yes, writing a separate test file might not require or can be covered with another dependent file, but

This file is mentioned in my task list as it's a 0% code coverage
IMO, writing test cases might look extra but it's good to have as we can say we have both dependent and independent test cases written which is helping us to achieve 100% code coverage

WDYT?

Adding coverage via this way doesn't achieve anything. I'd recommend not adding it. Instead, we should see which code flow should have covered these files and add tests for that.
For e.g. MutationDetail object is created when displaying the SyncStatusFragment. So, adding unit tests for this fragment should automatically cover these files as well.

Got it, let me close this pr and we will cover it with the SyncStatusFragment . Thanks


Update AmazonCore.php

I'm sorry, I'm afraid I don't quite understand the purpose of this change. The setStore method already takes care of handling null and is needed to set important parameters. Additionally, this would break the feature that chooses the store automatically when there is only one store in the config file. Is there another reason for this change that I am not aware of?

I'm sorry Thomas I wanted to make the change in my own forked repository. I accidentally added it to your original reposirtory. At least I can try to describe the the problem I solved with that change. Maybe you can do something with it.
In my implementation I instantiate different classes like "Amazonfeed", "AmazonOrder" etc.
Most of the time I instantiate them without parameters, because I want to inject them to other classes and functionality. That means sometimes I maybe instantiate the class and not directly use it.
But when I instantiate any of the classes without parameters I get the warning of "Store $s does not exist!",'Warning'. The store is almost always set after I instantiate the class. So my log is flooded with the same warning message. So I made this change to keep my log clean.

Okay, I see. I had a hunch based on the title and description that it wasn't meant to be here.
As for your implementation, it sounds like you already have more than one store in your config, as otherwise it would be automatically selecting it when no key is passed. If that is true, you could create a dummy store in your config and always use its key when setting up the object.


By when will Azure AD B2C with SAML be in GA?

I got to know from support team that Azure AD B2C using SAML is in public preview. From when is that in preview? and when can I expect that to be in GA?

@yashwanth-yenugu Thank you for your question. Can you please share with us the URL of the doc that you are having issues with?
Please note that we scope issues on this repro to feedback related to the docs. If you have a product question, please post it on MSDN or Stack Overflow. Thank you for your understanding.

@yashwanth-yenugu Since we have not heard back from you we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly reopen the issue and continue the discussion.


Fix timestamp validation in BlockInfo to match the documentation

BlockInfo was validating timestamps as follows:
if (timestamp - now) > tolerance:

However, such verification leads to incorrect validation of blocks when downloading old blocks. To make it match the documentation which says that

The timestamp in the new BlockInfo message must be less than the peer’s measured local time, adjusted to UTC, plus a network time synchronization tolerance that is greater than or equal to zero.

I changed the verification to this:
if timestamp > now + tolerance:

The existing code works as expected, and in fact, is equivalent to what's in the documentation functionally.  If now is in the future, the left side of the comparison will be negative, which will still have the clause evaluate to False.
It works, as-is, in catch-up mode (i.e. with old blocks) - in fact, the current line of code fixes an issue where the previous version did not, so we've addressed this problem in the past.

I do want to say thanks for the PR, though.  One thing to note, that in future PR's, make sure you commit using git commit -s: we require signed-off commits.
Please refer to the Contributor's Guide.

Closing: See above comments


CXP-1127: 1:M SQL Server connectors create extensive load on the database server

@ramanenka please retarget against DBZ-2975 (the current target branch is a backup before the rebase). Please also update the commit message to start with "DBZ-2975:".

This seems to be related to https://github.com/sugarcrm/debezium/pull/31 – this is where streamEvents started being called in a loop.


RedissonReactiveSubscription is not initialized properly and as a result - no messages are handled

Expected behavior
In case of using through org.springframework.data.redis.core.ReactiveStringRedisTemplate, I expect to handle messages from the channel I subscribed to via reactiveRedisTemplate.listenTo(channel)
Actual behavior
The subscription via reactiveRedisTemplate.listenTo(channel) is happening and redis-cli PUBLISH channel hello returns (integer) 1, but NO messages are handled.
Spent some time debugging, I noticed that anonymous subclass of BaseRedisPubSubListener  is created in RedissonReactiveSubscription.receive() with overridden onMessage(CharSequence channel, Object msg) method which as I understand should handle all the messages from redis channel (by the way, perhaps you could explain why BaseRedisPubSubListener overrides onMessage with empty implementation? ).
In fact the listener handles all messages and swallows it somewhere, debugging the message hits onMessage breakpoint, but nothing happened then.
By the way, in some unexplainable cases (I really don't know how to explain it) somewhere in the code the SubscribeListener is initialized and message that is handled by that listener is handled downstream (happens only in debug mode with some combination of breakpoints placed:)).
But event in that base, a single message first handled by BaseRedisPubSubListener empty implementation of onMessage and only then by SubscribeListener which translates the message downstream.
I tried a lot of times but didn't understand what is really needed to achieve this.
Steps to reproduce or test case

Initialize ReactiveStringRedisTemplate with regular spring config (example attached).
Call reactiveRedisTemplate.listenTo(channel) and subscribe to it.

Redis version
5.0.5
Redisson version
org.redisson:redisson-spring-data-22:3.12.4
Redisson configuration
@Bean(destroyMethod = "shutdown")
    public RedissonClient redissonClient() {
        Config config = new Config();
        config.useSingleServer()
                .setDnsMonitoringInterval(-1)
                .setTimeout(commandTimeoutMillis)
                .setAddress("redis://" + host + ":" + port);
        return Redisson.create(config);
    }
@Bean
public ReactiveRedisConnectionFactory redisConnectionFactory(RedissonClient redissonClient) {
    return new RedissonConnectionFactory(redissonClient);
}
 @Bean
ReactiveStringRedisTemplate reactiveRedisTemplate(ReactiveRedisConnectionFactory redisConnectionFactory) {
    return new ReactiveStringRedisTemplate(redisConnectionFactory);
}

Unable to reproduce it. Here it the code:
        RedissonConnectionFactory factory = new RedissonConnectionFactory(redisson);
        AtomicReference<byte[]> msg = new AtomicReference<byte[]>();

        ReactiveStringRedisTemplate template = new ReactiveStringRedisTemplate(factory);
        template.listenTo(ChannelTopic.of("test")).doOnEach(s -> {
            msg.set(s.get().getMessage().getBytes());
        }).subscribe();

        ReactiveRedisConnection connection = factory.getReactiveConnection();
        connection.pubSubCommands().publish(ByteBuffer.wrap("test".getBytes()), ByteBuffer.wrap("msg".getBytes())).block();

        Awaitility.await().atMost(Duration.ONE_SECOND)
                    .until(() -> Arrays.equals("msg".getBytes(), msg.get()));

Yes, I saw it is overridden, but it doesn't reach the overridden onMessage.
I tried few more times and found out that line https://github.com/redisson/redisson/blob/88172a2a24fa0b5e52c4a0721290cf5b10517b0c/redisson-spring-data/redisson-spring-data-22/src/main/java/org/redisson/spring/data/connection/RedissonReactiveSubscription.java#L65
is executed only when I put a breakpoint on it in debug mode and call it in "evaluate expression" menu.
and as a result of not executing the above line, the following listener addition https://github.com/redisson/redisson/blob/88172a2a24fa0b5e52c4a0721290cf5b10517b0c/redisson-spring-data/redisson-spring-data-22/src/main/java/org/redisson/spring/data/connection/RedissonReactiveSubscription.java#L174
is not performed.
Here is how I an subscribing to it completely:
@Autowired
    private ReactiveStringRedisTemplate reactiveRedisTemplate;

    @EventListener(ApplicationReadyEvent.class)
    public void subscribe() {

            return reactiveRedisTemplate.listenTo(ChannelTopic.of("topic"))
                    .flatMap(message -> {
                        log.info("evicting redis cache: " + message.getMessage());
                        return reactiveRedisTemplate.delete(reactiveRedisTemplate.scan(ScanOptions.scanOptions()
                                .match("*" + message.getMessage() + "*").build()));
                    });
    }

And it successfully works with Letuce, just replacing the dependency without changing anything in the code

I updated test code. Still executes successfully:
        RedissonConnectionFactory factory = new RedissonConnectionFactory(redisson);
        AtomicReference<byte[]> msg = new AtomicReference<byte[]>();

        ReactiveStringRedisTemplate template = new ReactiveStringRedisTemplate(factory);
        template.listenTo(ChannelTopic.of("test")).flatMap(message -> {
            msg.set(message.getMessage().getBytes());
            return template.delete("myobj");
        }).subscribe();

        ReactiveRedisConnection connection = factory.getReactiveConnection();
        connection.pubSubCommands().publish(ByteBuffer.wrap("test".getBytes()), ByteBuffer.wrap("msg".getBytes())).block();

        Awaitility.await().atMost(Duration.ONE_SECOND)
                    .until(() -> Arrays.equals("msg".getBytes(), msg.get()));

https://github.com/redisson/redisson/blob/88172a2a24fa0b5e52c4a0721290cf5b10517b0c/redisson-spring-data/redisson-spring-data-22/src/main/java/org/redisson/spring/data/connection/RedissonReactiveSubscription.java#L65
executes once subscibe process has completed

Could you try my code example?

I found the bug subscribe and receive methods should be synchronized.

https://github.com/redisson/redisson/blob/88172a2a24fa0b5e52c4a0721290cf5b10517b0c/redisson-spring-data/redisson-spring-data-22/src/main/java/org/redisson/spring/data/connection/RedissonReactiveSubscription.java#L65
executes once subscibe process has completed

I completely understand that, but as I see, It is not executed at least at the time when https://github.com/redisson/redisson/blob/88172a2a24fa0b5e52c4a0721290cf5b10517b0c/redisson-spring-data/redisson-spring-data-22/src/main/java/org/redisson/spring/data/connection/RedissonReactiveSubscription.java#L175
should add the channels to collection

Fixed! Could you try it with attached version?
redisson-spring-data-22-3.12.5-SNAPSHOT.jar.zip

Thanks. Will let you know once I try.

It introduced a new issue)
Now the method onMessage is triggered for all listeners despite the channel they are listening to.
What I mean:
reactiveRedisTemplate.listenTo(ChannelTopic.of("channelA")) .doOnNext(message -> log.info("evicting cache: for channelA")
reactiveRedisTemplate.listenTo(ChannelTopic.of("channelB")) .doOnNext(message -> log.info("evicting cache: for channelB")
->
redis-cli PUBLISH channelA hello returns (integer) 1
->
Sometimes the message is handled by wrong listener ("evicting cache: for channelB" is logged) but only in debug mode.
In regular mode -> no messages are handled.

Just wondering. Is there any reason to deny creating of appropriate listener right in the https://github.com/redisson/redisson/blob/88172a2a24fa0b5e52c4a0721290cf5b10517b0c/redisson-spring-data/redisson-spring-data-22/src/main/java/org/redisson/spring/data/connection/RedissonReactiveSubscription.java#L60 ?

Just wondering. Is there any reason to deny creating appropriate listener right in the

Because receive() method hasn't been invoked.

Here is updated version:
redisson-spring-data-22-3.12.5-SNAPSHOT.jar.zip

Fixed

Actually it was not)
Sorry, didn't have a time to check earlier but it still does not work.
Once I have more time, I will debug and find the actual line that does not work.
Please reopen

Could you provide test case ?

Just performed the same actions.
Just config I provided already.
Just started the app.
Just sent PUBLISH command to the channel and got '1' in response back but no messages are handled.

Did you use the latest version I attached?
Unable to reproduce it using follow test:
RedissonConnectionFactory factory = new RedissonConnectionFactory(redisson);
AtomicLong counter = new AtomicLong();

ReactiveStringRedisTemplate template = new ReactiveStringRedisTemplate(factory);
template.listenTo(ChannelTopic.of("test")).flatMap(message -> {
     counter.incrementAndGet();
     return Mono.empty();
}).subscribe();

template.listenTo(ChannelTopic.of("test2")).flatMap(message -> {
     counter.incrementAndGet();
     return Mono.empty();
}).subscribe();

ReactiveRedisConnection connection = factory.getReactiveConnection();
connection.pubSubCommands().publish(ByteBuffer.wrap("test".getBytes()), ByteBuffer.wrap("msg".getBytes())).block();

Awaitility.await().atMost(Duration.ONE_SECOND)
                    .until(() -> counter.get() == 1);

It just does not work.
Tested a lot of times of course with the version you attached.
The following test fails at the last line, so no messages are handled:
`
@Test
void testSubscribe() throws InterruptedException {
Config config = new Config();
config.useSingleServer()
.setDnsMonitoringInterval(-1)
.setAddress("redis://localhost:6379");
    RedissonClient redissonClient = Redisson.create(config);
    RedissonConnectionFactory redissonConnectionFactory = new RedissonConnectionFactory(redissonClient);
    ReactiveStringRedisTemplate reactiveStringRedisTemplate = new ReactiveStringRedisTemplate(redissonConnectionFactory);

    AtomicLong counter = new AtomicLong();
    reactiveStringRedisTemplate.listenTo(ChannelTopic.of("test")).flatMap(message -> {
        counter.incrementAndGet();
        return Mono.empty();
    }).subscribe();

    reactiveStringRedisTemplate.listenTo(ChannelTopic.of("test2")).flatMap(message -> {
        counter.incrementAndGet();
        return Mono.empty();
    }).subscribe();

    Long received = reactiveStringRedisTemplate.convertAndSend("test", "msg").block();
    assertThat(received).isEqualTo(1);

    Thread.sleep(2000);
    assertThat(counter.get()).isEqualTo(1);
}`

Just a reminder - subscription just works with Lettuce.

It works fine for me. Even if sleep is just 100ms

Perhaps Spring version does some impact something.
I am on org.springframework.boot:spring-boot-starter-webflux:2.2.6.RELEASE

set logging level TRACE for org.redisson to see Redis commands processed by Redisson

Perhaps Spring version does any impact something.
I am on org.springframework.boot:spring-boot-starter-webflux:2.2.6.RELEASE

It works well either.

I will try with more detailed log level today.

**Listener initialization: **
`@Slf4j
@Component
public class OnStartSubscriber {
private ReactiveStringRedisTemplate reactiveRedisTemplate;

@EventListener(ApplicationReadyEvent.class)
public void subscribe() {
    reactiveRedisTemplate.listenTo(ChannelTopic.of("test"))
            .doOnNext(message -> log.info("got the message - " + message.getMessage()))
            .blockLast();
}

@Autowired
public void setReactiveRedisTemplate(ReactiveStringRedisTemplate reactiveRedisTemplate) {
    this.reactiveRedisTemplate = reactiveRedisTemplate;
}

}`
**gradle dependencies part: **
`    implementation "org.redisson:redisson-spring-data-22:3.12.4"
repositories {
    flatDir {
        dirs 'local-libs'
    }
}
implementation name: "redisson-spring-data-22-3.12.5-SNAPSHOT"`

**After application start, 2 such commands were sent: **
redis-cli PUBLISH test test-message
Full output in console:
`2020-04-22 13:17:54.943  INFO 1941 --- [  restartedMain] CacheApplication             : Started CacheApplication in 8.327 seconds (JVM running for 8.823)
2020-04-22 13:17:55.008 TRACE 1941 --- [sson-netty-2-27] o.r.client.handler.CommandEncoder        : channel: [id: 0x94dead08, L:/<IP_ADDRESS>:49848 - R:localhost/<IP_ADDRESS>:6379] message: *2
$9
SUBSCRIBE
$4
test
2020-04-22 13:17:55.019 TRACE 1941 --- [sson-netty-2-27] o.r.client.handler.CommandPubSubDecoder  : reply: *3
$9
subscribe
$4
test
:1
, channel: [id: 0x94dead08, L:/<IP_ADDRESS>:49848 - R:localhost/<IP_ADDRESS>:6379], command: null
2020-04-22 13:18:13.133 TRACE 1941 --- [sson-netty-2-27] o.r.client.handler.CommandPubSubDecoder  : reply: *3
$7
message
$4
test
$12
test-message
, channel: [id: 0x94dead08, L:/<IP_ADDRESS>:49848 - R:localhost/<IP_ADDRESS>:6379], command: null
2020-04-22 13:18:39.369 TRACE 1941 --- [sson-netty-2-27] o.r.client.handler.CommandPubSubDecoder  : reply: *3
$7
message
$4
test
$12
test-message
, channel: [id: 0x94dead08, L:/<IP_ADDRESS>:49848 - R:localhost/<IP_ADDRESS>:6379], command: null
`

If you send message from redis-cli then you need to use StringCodec on Redisson side

So how to use it?
What else needs to be added to the configuration?

use Config.setCodec method

No, it does not work even with config.setCodec(new StringCodec());

Unable to reproduce.


bcmod cast to int for compatibility php 72

minimum changes needed for php 7.2 support

Thank you for this fix.


Bad Redirect(s).

This link sends me to a broken link page. That page does link to the correct page (which raises the question of why it stands in between at all), but what's weird is that it thinks I want to go to the "user documentation". Both the original link and the (I believe correct) link it suggests are in the developer documentation.
Also strange that the command line arguments to run the client are considered developer material.

I believe this specific issue should be fixed now that the links have all been redone.
With regards to command line parameters, ideally those should only have to be used by a technical user or under an otherwise atypical circumstance.

Not all technical users are developers, but it's up to you.


enhancement(switch): Update the Switch to reflect the latest design

Fixes #875
Fixes #858

This looks good @guillaumevincent . The only comment/question I have is that the label should change from On to Off when the switch is flipped to the left and vice versa. Not sure how you show that here without JS, but the way that the preview is now is somewhat misleading.

@mcarrano thank you for the merge
For me DOM modification should be done in JS with React

@mcarrano maybe the label should say something other than "on" or "off" for the example? It could just say "label" or "option" something generic like that.

Maybe that's a better idea @mcoker . If we can't toggle the actual label, then I think it's confusing as is. What do you think @guillaumevincent ?

I agree @mcarrano
Thank you @mcoker for the review
I updated the PR


User Defined types - inconsistant visualization of tool tips

Bicep version
Bicep CLI version 0.23.1 (b02de2da48)
Describe the bug
We have the following example for main.bicep
type foo = {
  @description('''Source port ranges.
    Can be a single valid port number, a range in the form of \<start\>-\<end\>, or a * for any ports.
    When a wildcard is used, that needs to be the only value.''')
  sourcePortRanges: string[]
}

param foo1 foo

We intentionally put additional indent on new lines for better readability.
When we have not entered the parameter in bicep parameter's file and we want to see the description and type of the parameter the visualization is the following:

if we have entered the parameter and we hover over it visualization is different and not correct:

The first visualization is the one that is correct and the second one should be the same.
To Reproduce
Provided
Additional context
Add any other context about the problem here.

The 2nd visualization is being rendered as markdown - because of your indentation, the 2nd & 3rd lines are treated as a code block.
I agree we should fix this to be consistent. In the meantime, if you want a workaround, change:
  @description('''Source port ranges.
    Can be a single valid port number, a range in the form of \<start\>-\<end\>, or a * for any ports.
    When a wildcard is used, that needs to be the only value.''')
  sourcePortRanges: string[]

To:
  @description('''Source port ranges.
Can be a single valid port number, a range in the form of \<start\>-\<end\>, or a * for any ports.
When a wildcard is used, that needs to be the only value.''')
  sourcePortRanges: string[]

@anthony-c-martin  yeah, I am aware of the workaround but we started to do the additional indent for better readability. If we start to revert that we will have worse readability and when you fix it we will have to add the indent again. So I would rather wait for this fix instead of doing a ton of work twice. I would assume is not so hard to fix as you already have the right way to render in code.

we started to do the additional indent for better readability.

Sorry for the digression, but should we update multiline strings to allow users to set the left margin (like C# raw string literals do)?
If you're writing a description for a property on a type that's deeply nested, shunting everything over to the file's left margin might look odd:
type myType = {
  some: {
    very: {
      deeply: {
        nested: {
          @description('''A description
that
spans
multiple
lines.''')
          property: string
        }
      }
    }
  }
}

It would be easier to follow the type's structure if Bicep multiline strings worked like C# raw string literals, e.g.:
type myType = {
  some: {
    very: {
      deeply: {
        nested: {
          @description('''A description
            that
            spans
            multiple
            lines.
            ''')
          property: string
        }
      }
    }
  }
}

The description in the second example would today end with \n            , so this would be a backwards incompatible change, though I'm not sure how disruptive it would be.

Sorry for the digression, but should we update multiline strings to allow users to set the left margin (like C# raw string literals do)?

We discussed this at length when designing multi-line strings, but I can't remember the reason we chose to preserve whitespace accurately.
I do remember there were concerns about copy+pasting source code or anything else that could potentially have its meaning changed unexpectedly - this was before loadTextContent() which I think makes it less of a concern. I can't remember if this was the deciding factor however.

I do remember there were concerns about copy+pasting source code or anything else that could potentially have its meaning changed unexpectedly - this was before loadTextContent() which I think makes it less of a concern. I can't remember if this was the deciding factor however.

That makes sense, though the user experience for adding documentation to nested properties certainly has room for improvement. I'll comb through some older issues to see if there are alternatives we could look at and bring it up at a team discussion.

I like @jeskew approach.

@stephaniezyen any rough time line when it can be fixed? Excluding the things Jonny suggested.


Further improve clamping

Note this is a PR into #4493  You might want to add ?w=1 to the url because this is a minor change that looks like more because of indentation.
Previously, we would only clamp a billboard or label at it's highest terrain level, we wouldn't "go backwards". This was thought to be a performance benefit.  However, in practice it makes it really easy
for clamping to be incorrect and you end up with billboards either constantly floating or below ground.  This change removes that further optimizaiton and as far as I can tell, clamping is now always correct.
The downside of this is that we are doing a big more work and clamping was already slow.  However, since most of the time clamping is doing nothing and then bursts, upping the time slice improved performance without any major degradation in frame rate. Once we further optimize the terrain
picking code (which is why clamping is so slow to begin with), we could probably further reduce the timeslice.

15ms is a lifetime.

Yes, I agree.  However most of the time we actually spend 0ms doing anything so we only use up the 15ms under load and the temporary drop in frame rate doesn't address interactivity.  Long term the unified time slicing would obviously just use whatever time remains in the target frame rate.

I don't want to merge this in haste; let's wait until we can discuss with @bagnell.

Yep, that's why I did a separate PR.

Can we retarget this to master so we can merge #4493?

Done.

I can still reproduce the bug in this branch.

As @bagnell mentioned, this appears not to fix the problem complete.  Looking at the code further and discussing it with him, the optimization is probably correct anyway, so we currently have no idea why certain points still end up floating or buried.  We'll have to revisit the issue as soon as we have time.


Deprecate JaasLoginModuleConfiguration in 2.1

Deprecate JaasLoginModuleConfiguration and delegate the responsibility primarily to the KafkaJaasLoginModuleInitializer in spring-kafka. There are some duplicate code in JaasLoginModuleConfiguration and no need to directly use the javax.secutiry.auth.login.AppConfigurationEntry as the spring-kafka layer takes care of that.

On further review, we can't easily deprecate JassLoginModuleConfiguration or the methods in it. There are some elements of it such as the setControlFlag method which can be simplified given the corresponding changes from spring-kafka. But at the moment, it doesn't warrant a refactoring of this class, thus closing this issue.


Throw TypeError when accessing array with out-of-bound index in strict mode

This is for issue https://github.com/Microsoft/ChakraCore/issues/2083

@dotnet-bot test this please

@jianchun could you please help take a look?

Talked with @jianchun offline and it is Ok to take the fix now.


dx textbox join error

Hi
When i use this :
<dx-text-box ([value])="treeViewFilterString" [valueChangeEvent]="keyup">

i get this error :

It has to do with the valueChangeEvent property, when i removed it, the error is gone, when i replace it with something like [visible]="false" no error and the control is hidden.
Thanks.

When i changed it to variables it seems to work.
in my ts :
public modeValue: string = "search";
public changeValue: string = "keyup";
in html :
<dx-text-box [mode]="modeValue"
([value])="treeViewFilterString"
[valueChangeEvent]="changeValue">
Just the value binding does not seem to work at this point.
Can i not declare these values inline (search, keyup) ?
Thanks.

Ok, also found it, dont bind values if you want it inline, i had [mode]="keyup" but it was supposed to be mode="keyup" for inline setting of the property.
Thanks.

Yes, @christophedemey . You are correct. You should not use square brackets to bind a string option. See Static String Option Value topic. Or, if you use them, wrap the bound value in additional single quotes:
[valueChangeEvent]="'keyup'"


Feature: Updated the design of the headers on Widgets

Feature: Update the header of Home page widgets
Motivation & Context

Improved UI

PR Checklist

[x] Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
[x] Did you build the app and test your changes?
[ ] Did you check for accessibility? You can use Accessibility Insights for this.
[ ] Did you remove any strings from the en-us resource file?

[ ] Did you search the solution to see if the string is still being used?

[ ] Did you implement any design changes to an existing feature?

[ ] Was this change approved?

[ ] Are there any other steps that were used to validate these changes?

Screenshots

The header should be 40 high, and the hover backplate 32 high.
Also there should be less padding for the top and bottom of the widgets, as it feels off balanced.

Done. Ready for review.


Is it possible to combine Instant NeRF with Mobile NeRF?

If so, the result would be crazy!

Yes, of course.
We didn't do it mostly because the PSNR of the scenes would be a tad lower (bad for publishing).

See https://github.com/kim-jinuk/hash_mobilenerf.git

Have a project page?

I wrote the wrong link, please check the link above again.


Pinecone retriever throwing: KeyError: 'text'

My query code is below:
pinecone.init(
    api_key=os.environ.get('PINECONE_API_KEY'),  # app.pinecone.io
    environment=os.environ.get('PINECONE_ENV')  # next to API key in console
)
index = pinecone.Index(index_name)
embeddings = OpenAIEmbeddings(openai_api_key=os.environ.get('OPENAI_API_KEY'))

vectordb = Pinecone(
    index=index,
    embedding_function=embeddings.embed_query,
    text_key="text",
)
llm=ChatOpenAI(
    openai_api_key=os.environ.get('OPENAI_API_KEY'),
    temperature=0,
    model_name='gpt-3.5-turbo'
)
retriever = RetrievalQA.from_chain_type(
    llm=llm,
    chain_type="stuff",
    retriever=vectordb.as_retriever()
)
tools = [Tool(
    func=retriever.run,
    description=tool_desc,
    name='Product DB'
)]
memory = ConversationBufferWindowMemory(
    memory_key="chat_history",  # important to align with agent prompt (below)
    k=5,
    return_messages=True
)
agent = initialize_agent(
    agent='chat-conversational-react-description',
    tools=tools,
    llm=llm,
    verbose=True,
    max_iterations=3,
    early_stopping_method="generate",
    memory=memory,
)

If I run:
agent({'chat_history':[], 'input':'What is a product?'})
It throws:

File "C:\Users\xxx\AppData\Local\Programs\Python\Python311\Lib\site-packages\langchain\vectorstores\pinecone.py", line 160, in similarity_search
text = metadata.pop(self._text_key)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'text'

This is the offending block in site-packages/pinecone.py:
 for res in results["matches"]:
            # print('metadata.pop(self._text_key) = ' + metadata.pop(self._text_key))
            metadata = res["metadata"]
            text = metadata.pop(self._text_key)
            docs.append(Document(page_content=text, metadata=metadata))

If I remove my tool like the line below, everything executes (just not my tool):
tools = []
Can anyone help me fix this KeyError: 'text' issue?  My versions of langchain, pinecone-client and python are 0.0.147, 2.2.1 and 3.11.3 respectively.

From having a first look (without knowing more about the setup):
Might it be that the PineconeDB is empty?
Depending on your setup, you (having documents locally or already a Pinecone index created), you might want to try
vectordb = Pinecone.from_existing_index(
    index_name=index,
    embedding=embeddings,
)

Or Pinecone.from_documents.  What you are currently doing is initializing Pinecone. If however the pinecone client tries to perform a similarity search, there is nothing to be found?

same problem here, any solution?

+1 here. Subscribing.

+1 PInecone retrieval seems broken. It either flips out with 'text' error or hangs indefinitely.

Pinecone doesn't store documents explicitly; it only stores ids, embeddings, and metadata. So, if when querying Pinecone you'd like to have access to the documents themselves, you should add them to the metadata, as illustrated here. If you add them under a text key in the metadata, the KeyError should resolve.
Alternatively, you can specify your own key name when you initialize Pinecone, via text_str. Code reference is here.

This explains a lot - thank you.  However, wouldn't storing the entire text of a document in addition to the vector drastically increase the storage requirements?  I believe Pinecone also suggests avoiding pieces of metadata that are very unique, which this certainly would be.
Is it not possible to use the vector data itself as an input to ChatGPT for answering questions on the data?  From above, it sounds like you need to do as follows:

Embed the text and store both the vector and original text at Pinecone.
Perform a similarity search on the Pinecone index to find relevant documents.
Take text from Pinecone metadata and feed that back into the LLM for QA.

Appreciate any additional ideas.  Thanks.

Your alternative is to store the document text elsewhere and then store a
reference / URL to it in the pinecone metadata. This is what I do with Tana
notes, for example. Pinecone is the search index - Tana is the content
repository.
On Thu, Jun 15, 2023 at 3:13 PM Peak Prosperity @.***>
wrote:

This explains a lot - thank you. However, wouldn't storing the entire text
of a document in addition to the vector drastically increase the storage
requirements? I believe Pinecone also suggests avoiding pieces of metadata
that are very unique, which this certainly would be.
Is it not possible to use the vector data itself as an input to ChatGPT
for answering questions on the data? From above, it sounds like you need to
do as follows:

Embed the text and store both the vector and original text at
Pinecone.
Perform a similarity search on the Pinecone index to find relevant
documents.
Take text from Pinecone metadata and feed that back into the LLM
for QA.

Appreciate any additional ideas. Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/hwchase17/langchain/issues/3460#issuecomment-1593592203,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAUCPNHIWD7INUAK5SNXW3XLNNE7ANCNFSM6AAAAAAXJ5SREY
.
You are receiving this because you commented.Message ID:
@.***>

Thanks, @verveguy .  I created a table in our SQL database that references the vector ID and it seems to be working well.

same problem here, any solution?
text = metadata.pop(self._text_key)
KeyError: 'text'

In my situation, I encountered an issue due to the metadata associated with the vectors, specifically the need to include a key labeled "text" (e.g., "text": text). I found the solution to this problem in the comment at this GitHub link, which proved to be extremely helpful for me.

Is there any update about the issue. I am also getting this error:
from langchain.vectorstores import Pinecone

text_field = "text"

# switch back to normal index for langchain

vectorstore = Pinecone(
    index, embed.embed_query, text_key='text'
)
query = "when "

vectorstore.similarity_search(
    query,  # our search query
    k=3  # return 3 most relevant docs
)
Found document with no `text` key. Skipping.
Found document with no `text` key. Skipping.
Found document with no `text` key. Skipping.
[]

Same issue, any updates?

I solve the problem. Here is a detailed explanation and for last a question for @langchainTeam.
When you create a record on pinecone by yourself for example (pinecone documentation):
pc = Pinecone(api_key='YOUR_API_KEY')
index_name = "docs-quickstart-index"

pc.create_index(
    name=index_name,
    dimension=8,
    metric="cosine",
    spec=ServerlessSpec(
        cloud='aws',
        region='us-east-1'
    )
)

index = pc.Index(index_name)

index.upsert(
    vectors=[
        {"id": "vec1", "values": [0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 0.1], "metadata": {"type": "doc1"}},
        {"id": "vec2", "values": [0.2, 0.2, 0.2, 0.2, 0.2, 0.2, 0.2, 0.2], "metadata": {"type": "doc2"}},
        {"id": "vec3", "values": [0.3, 0.3, 0.3, 0.3, 0.3, 0.3, 0.3, 0.3], "metadata": {"type": "doc3"}},
        {"id": "vec4", "values": [0.4, 0.4, 0.4, 0.4, 0.4, 0.4, 0.4, 0.4]}
    ],
    namespace="ns1"
)

It doesnt add the metadata field "text", only your custon metadata in case you put one, and you can do a similarity search to that vectors with no problem (pinecone documentation)
index.query(
    namespace="ns2",
    vector=[0.7, 0.7, 0.7, 0.7, 0.7, 0.7, 0.7, 0.7],
    top_k=3,
    include_values=True
)

When you create a vector on pinecone by langchain for example (langchain documentation):
vectorstore = PineconeVectorStore(index_name=index_name, embedding=embeddings)

vectorstore.add_texts(["More text!"])

It adds to the vector a metadata field named "text" that is the actual text embeded.

And then, with that metadata field, you can do:
vectorstore.similarity_search(query="More Text")
Or alternatively, with the retriver interface:
retriver = vectorstore.as_retriever()
results = retriver.invoke("More Text")

My question is, Which concept im missing ? Why have a vectorstore with the vector values (the vector representation of the text) if I have to run the querys on the "text" metadata field with te actual text ? Thank you for your time, and I appreciate your response to help resolve my doubt. In summary, why maintain a vectorstore with vector values if queries ultimately need to be run on the 'text' metadata field with the actual text?

@CessarGL I had the same issue since I stored vectors as shown on the pinecone website. I think the point of including "text" as a metadata is for the language model to interpret the context. Vector search only retrieves the similar vectors but vector itself are jusyt bunch of numbers. In order for the LLMs to understand the semantic meanings of each vector I think you need to attach content under text to the vectors.

i also faced the same error.   as @Mizuki8783 said, add text content

@CessarGL I had the same issue since I stored vectors as shown on the pinecone website. I think the point of including "text" as a metadata is for the language model to interpret the context. Vector search only retrieves the similar vectors but vector itself are jusyt bunch of numbers. In order for the LLMs to understand the semantic meanings of each vector I think you need to attach content under text to the vectors.

exactly, add text content in metadata along with vector embedding. i solved the error by doing so.


Update dependencies

Thank you!

@royriojas Will you make patch release?

yes, in a few

done!

Thanks!


Potency Bonus is inconsistently applied to polymorphed unarmed attacks

Is:
Currently, when automatic bonus progression is used, a potency bonus is automatically added to regular unarmed attacks and NOT to polymorphed unarmed attacks. RAW, this is CORRECT:

If you take on a battle form with a polymorph spell, the special statistics can be adjusted only by circumstance bonuses, status bonuses, and penalties.

However, in Foundry, if a character wears handwraps of mighty blows, they WILL receive a potency bonus when they make unarmed attacks while polymorphed. RAW this is INCORRECT.
One could interpret the way polymorph rules interact with ABP in one of two ways, but Foundry is inconsistent about which ruling is correct:
Interpretation 1: The allowed list of bonuses while polymorphed doesn't explicitly include potency bonuses. One might argue that this is because ABP is a variant rule that was introduced after the core rules were written, and ABP has a history of being incompletely adjudicated in the core rules. Under this interpretation, potency bonuses should be added to the list of allowable bonuses. In other words, polymorph attacks should be treated like unarmed attacks, which automatically get potency bonuses even without items.
Interpretation 2: The RAW are correct and complete, even when ABP is used. Because potency bonuses are not called out in the rules for polymorph, they should be ignored 100% of the time when polymorphed. In other words, polymorph attacks should be treated like spell attacks, which don't get potency bonuses as characters level up.
SB:
If ruling 1 is used, then potency bonuses should be applied to polymorphed attacks regardless of whether or not handwraps of mighty blows are equipped, as they should be treated like ordinary unarmed attacks (which don't require handwraps in ABP). This ruling is less supported by the core rules and relies on conjecture about how the game should be balanced under ABP.
If ruling 2 is used, then all unarmed attacks while polymorphed should explicitly remove any potency bonuses from their modifiers, even if they come from items like handwraps. This is the RAW interpretation and probably should be used, but Foundry currently doesn't explicitly remove potency bonuses from polymorphed attacks.

Not able to reproduce. Are you sure the PC's unarmed attack modifier just isn't higher?


Module appearing with 100% branch coverage in report after namespace is excluded

Hello,
I'm using version 2.7.0 of your package and keep running into an issue. We have two test projects (unit test project and integration test project). Both use xunit 2.4.1 if it matters. I've been trying to exclude the integration tests from the unit test code coverage, but the best I can get is for the report to say 100% of branching logic is covered in my integration tests, which heavily skews the reports.
The command I'm using is running within its own docker container that executes the dotnet test command: docker run --name container-unit-tests {containerId} '/p:CollectCoverage=true' '/p:Exclude=[*]Company.Project.IntegrationTests.*' '/p:CoverletOutputFormat=cobertura' '/p:CoverletOutput=/var/test-results/'

The second Module is just the executable itself, which is why there is no additional namespace. The web API is a .NET Core 3.0 project (I don't know if there are any known issues with 3.0, I tried to search but couldn't find any)

After messing around more, you want to do something along the lines of /p:Exclude=[Your.Namespace.Module]* to exclude the entire module. If you do Module.* it will think you're allowing everything at the module level itself.


Add more inline documentation/comment for PooledByteBufAllocator/PoolArena/PoolChunkList

Netty internals are in general very well documented (one of the best I've seen). However, the aforementioned 3 classes barely have any comment. Would be great to improve them.

@trustin as you wrote most of it maybe something for you :) ?

@normanmaurer Sure. It's basically an implementation of jemalloc + some optimization, but yeah, I can add some comments.

@trustin thanks buddy!

Would also totally appreciate some comments there :)


Division by Zero error sporadically occurs

On some conifigurations of RAM, GPU, grad_accumulation steps and batch size, the code runs well but throws division by zero error in others.
More context: I updated transformers to 4.38.1. So that could also cause the issue.
Traceback (most recent call last):
File ".../lib/python3.10/site-packages/torch/multiprocessing/spawn.py", line 69, in _wrap
fn(i, *args)
File ".../direct-preference-optimization-main/train.py", line 44, in worker_main
trainer.train()
File ".../direct-preference-optimization-main/trainers.py", line 383, in train
mean_train_metrics = {k: sum(v) / len(v) for k, v in batch_metrics.items()}
File ".../direct-preference-optimization-main/trainers.py", line 383, in
mean_train_metrics = {k: sum(v) / len(v) for k, v in batch_metrics.items()}
ZeroDivisionError: division by zero
Made this adjustment for the time being : mean_eval_metrics = {k: sum(v) / len(v) if len(v) > 0 else 0 for k, v in all_eval_metrics.items()}
Underlying issue is not fixed.

The issue is the same as: https://github.com/eric-mitchell/direct-preference-optimization/issues/10
Need to ensure that the effective batch size per GPU = (batch_size)/ (num_gpus*accumulation_steps) is 1 or more or else the chunk size will be 0 and no training or evaluation will happen.


(Desktop) Portfolio - positions - % change

We show 4 characters after decimal point in some instances of the % change, let’s update this to only show 2.
Rules for this:

IF % change => 0.005 THEN show change of 0.01 (in green/red depending)
IF % change <0.005 THEN show no change (i.e. 0.00% in grey)

looks good - closing


undefined method `classify' for custom action

module Fastlane
  module Actions
    module SharedValues
      ARCHIVE_DIR = :ARCHIVE_DIR
    end

    class ArchiveAction
      def self.run(params)
        raise "Workspace is not set".red unless ENV['WORKSPACE']
        raise "Scheme is not set".red unless ENV['SCHEME']

        Actions.sh("xcodebuild -workspace #{ENV['WORKSPACE']} -scheme #{ENV['SCHEME']} -configuration Debug -destination generic/platform=iOS archive -archivePath #{ENV['SCHEME']}.xcarchive | xcpretty -c")
        Actions.sh("xcodebuild -exportArchive -archivePath #{ENV['SCHEME']}.xcarchive -exportPath #{ENV['SCHEME']} -exportFormat ipa | xcpretty -c")

        ipa_file = "./#{ENV['SCHEME']}.ipa"

        raise "No ipa file found in #{ipa_file}".red unless File.exist?(ipa_file)

        Actions.lane_context[SharedValues::ARCHIVE_DIR] = ipa_file
      end
    end
  end
end

After update to latest fasten, I got this:
lib/fastlane/actions/actions_helper.rb:93:in `block in load_external_actions': undefined method `classify' for "archive":String (NoMethodError)

Could you run sudo gem update fastlane_core and see if that fixes the problem?

@KrauseFx
sudo gem update fastlane_core
Updating installed gems
Nothing to update

current version is fastlane-0.1.9

I just copied your action and it's working fine. Could you post the full stack trace?

@KrauseFx
Sure,
/Users/skitsko/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fastlane-0.1.9/lib/fastlane/actions/actions_helper.rb:93:in `block in load_external_actions': undefined method `classify' for "archive":String (NoMethodError)
	from /Users/skitsko/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fastlane-0.1.9/lib/fastlane/actions/actions_helper.rb:88:in `each'
	from /Users/skitsko/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fastlane-0.1.9/lib/fastlane/actions/actions_helper.rb:88:in `load_external_actions'
	from /Users/skitsko/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fastlane-0.1.9/lib/fastlane.rb:26:in `<module:Fastlane>'
	from /Users/skitsko/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fastlane-0.1.9/lib/fastlane.rb:17:in `<top (required)>'
	from /Users/skitsko/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fastlane-0.1.9/bin/fastlane:5:in `require'
	from /Users/skitsko/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/fastlane-0.1.9/bin/fastlane:5:in `<top (required)>'
	from /Users/skitsko/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bin/fastlane:23:in `load'
	from /Users/skitsko/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/bin/fastlane:23:in `<main>'

Great, that helped. I pushed a fix. Please install it using sudo bundle install && sudo rake install and let me know if that fixes your problem :+1:
Also, would you like to submit your action as official fastlane action?

@KrauseFx yes, thanks for fast fix. I like xcpretty more than xctool, so yes, we can publish it. But first I think we need to polish it a bit.

Just published a release: https://github.com/KrauseFx/fastlane/releases
That sounds interesting. If you don't mind sharing them, I'd be happy to include them in fastlane.


Sprite Upload Error: TypeError: Cannot read properties of undefined (reading 'get')

Expected Behavior
Please describe what should happen
Actual Behavior
Describe what actually happens
Steps to Reproduce
Explain what someone needs to do in order to see what's described in Actual behavior above
Operating System and Browser

e.g. Mac OS 10.11.6 Safari 10.0
when  package offline version , Select sprite ,It is report Sprite Upload Error: TypeError: Cannot read properties of undefined (reading 'get') what happen it is?

You need to update all package version and external resource version. The Arduino Nano has been delete in recently version.


How can to lazyload in before run

Hi,
I have some dependencies which need to be loaded for run method. But I am not getting hoe to achieve it
app.run(["myDep", function(myDep){
});

I need to lazy load the myDep

could you do something like that ?
app.run(["$ocLazyLoad", "$injector", function($ocLazyLoad, $injector){
  $ocLazyLoad.load('myDep').then(function() {
    var myDep= $injector.get('myDep');
    // do something with myDep
  }, function(err) {
    console.error(err);
  });
});

And if I need to load multiple dependencies, How can I do. I tried with array but then it gives error

You'll need to call $injector multiple times, once for each dependency.
$injector is a service from Angular, not for $ocLazyLoad :)


feat: Combine VIS PRs and refactor provider

Since it is not straight forward to test the dependency chain of the open vis PRs, I merged the other ones in this PR. This includes
https://github.com/datavisyn/visyn_core/pull/7
https://github.com/datavisyn/visyn_core/pull/49
https://github.com/datavisyn/visyn_core/pull/54
https://github.com/datavisyn/visyn_core/pull/60
https://github.com/datavisyn/visyn_core/pull/62
https://github.com/datavisyn/visyn_core/pull/55

We're using the following interfaces / enums which are not exported anymore:
EBarDirection, EBarDisplayType, EBarGroupingType, IBarConfig. We defenitely need IBarConfig

We're using the following interfaces / enums which are not exported anymore: EBarDirection, EBarDisplayType, EBarGroupingType, IBarConfig. We defenitely need IBarConfig

In Reprovisyn, we are using all specific vis configs. If this is not recommended, please let us know what to change in reprovisyn.

@dvmoritzschoefl Thanks for the latest refactoring and fixing the Ordino integration. Regarding the status of this PR: Did you address the Bob's feedback already?
I still see the plotly toolbar in the sankey diagram and in addition to that I would like to zoom and pan in this plot. Could you add this?

Could you please limit the x-axis label length and add a text-overflow: ellipsis
Otherwise the actual plot area becomes really small (see the screenshot)

Could you please limit the x-axis label length and add a text-overflow: ellipsis Otherwise the actual plot area becomes really small (see the screenshot)

I do not see an easy way to do this. I also think this is out of scope for this PR which is only there to combine the existing vis into one framework. (Except the bug was introduced in this PR of course)

Some other bugs I found while testing your branch in bioinisght:

For the column selection (numerical and categorical) we had a tool tip with name + description before. Now it is missing
The y-axis labesl of the bar chart should all be left aligned

The hexbin plot does not resize vertically when i reduce the mosaic height in bioinisight

the default for most vis frameworks is to right align items on the y axis, which is what makes most sense. what you see here is an artefact of the ellipsis which is hardcoded in the barchart (and not responsive like in plotly)
as for the hexbin plot yes, it does not seem to resize at all when the area is shrinking i will take a look at that

In the previous version we had a tooltip for categorical / numerical columns that we used in BioInsight to display more information on the selected items:

In the previous version we had a tooltip for categorical / numerical columns that we used in BioInsight to display more information on the selected items:

@dvdanielamoitzi  I'm a bit confused, did this use to work but it does not work any more? I just tried this in Reprovisyn, and the tooltip works as expected:


Do not need to restard service when executing ns management

What would you like to be added:
Why is this needed:
When Kmesh is deployed, if we label a namespace to let Kmesh manage the traffic of pods in the namespace there is currently a need to restart the service. Actually, we do not want to restart the service.

/assign

ping @weli-l


Training makes model incoherent

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Train successfully
Current behaviour
Training leaves the model incoherent.
Steps to reproduce

Use config specified below
Set learning rate = 0 to so dataset does not matter
train until the 300th checkpoint
run inference on the checkpoint model

Config yaml
base_model: /mnt/m2_4tb/text-generation-webui/models/MiniMA-3B
model_type: LlamaForCausalLM
tokenizer_type: LlamaTokenizer
is_llama_derived_model: true
load_in_8bit: false
load_in_4bit: false
strict: false
datasets:

path: /mnt/m2_4tb/Layla-datasets/datasets_formatted/layla/openchat.topicalchat.sharegpt.jsonl
ds_type: json # see other options below
type: sharegpt

dataset_prepared_path: last_run_prepared
val_set_size: 0.05
output_dir: ./out
sequence_len: 2048
sample_packing: true
pad_to_sequence_len: true
adapter:
lora_model_dir:
lora_r:
lora_alpha:
lora_dropout:
lora_target_linear:
lora_fan_in_fan_out:
wandb_project:
wandb_entity:
wandb_watch:
wandb_run_id:
wandb_log_model:
gradient_accumulation_steps: 4
micro_batch_size: 2
num_epochs: 3
optimizer: adamw_bnb_8bit
lr_scheduler: cosine
learning_rate: 0
train_on_inputs: false
group_by_length: false
bf16: true
fp16: false
tf32: false
gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true
flash_attn_cross_entropy: false
flash_attn_rms_norm: true
flash_attn_fuse_qkv: false
flash_attn_fuse_mlp: true
warmup_steps: 100
eval_steps: 0.05
eval_table_size:
save_steps: 300
debug:
deepspeed: deepspeed/zero3.json # multi-gpu only
weight_decay: 0.1
fsdp:
fsdp_config:
special_tokens:
bos_token: ""
eos_token: ""
unk_token: ""
Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
3.10
axolotl branch-commit
main
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

I wonder if it's due to not calling post_training on the model, which has just been fixed. Could you retry this on the latest main?

I believe I read another issue where you mentioned this #744 . Closing this in favor of that.


Colored dcmdump output

It would be interesting to have the project's dcmdump print colored output for better readability and analysis.
This would give tag numbers, attribute names, and respective values, in different colours if the output device is a TTY.
termcolor seems to be the right way to do this.

@Enet4 I'm interested in taking this on! To clarify, in the example you mentioned there would be 3 colors assigned, one each for numbers, attribute names, and values? And do you have any preference on the colors used?

Yes, the colours would differ among different components in a line.
To be honest, I did not specify concrete colours because this is likely going to be an iterative process for obtaining a good palette. Still, here's what I would picture as a good starting point for a dark background:

a slightly darker shade of grey for the tag numbers;
known attribute names in bold if supported by the platform
values in a brighter colour, which could even depend on the data type and hint their validity: white or yellowish white for string values, light green for dates and times, red for invalid dates/times (this is already checked by dcmdump).

But again, we'll only know if they work well once tried out.
I will be able to test this on both Linux and Windows.

Makes sense, thanks for clarifying! I can take an initial stab at some of the colors and then we can try them out to see what works

@Enet4 I've been taking a look at termcolor, and it looks like the main benefit compared to something like colored is support for earlier versions of Windows. Is support for Windows versions before 10 a priority here? If so I can keep going forward with termcolor, but wanted to check because it looks like using colored is simpler overall

That does seem to be an easier API. Feel free to use it for now. Then we can evaluate the outcomes based on platform support and performance.

Resolved in #80