Migrate TorchAudio to use complex tensors in place of real tensors of shape (..., 2)

Complex Tensors were released in 1.6 release of torch. The progress of complex numbers support in torch can be tracked here. This issue is meant to outline the tasks that need to be completed to migrate torchaudio API to use these newly added complex tensors.
The general plan for this migration, would be to add a local USE_COMPLEX flag to avoid bc breaking changes. This flag detect if the input is complex or not. If it's not complex, the old code (that supports the real tensors with  shape (..., 2)) will be used and the returned tensor will be a real tensor. If it's complex, the returned tensor will be a complex tensor.
Here's a demo PR for this migration: https://github.com/pytorch/audio/pull/758
Here's the tracker for the issue for deprecation of torch.fft functions. The new torch.fft.fft functions will take as input and return complex tensors instead of the real representation of complex tensors.
torchaudio.functional

[ ]  spectrogram (uses torch.stft)

[ ] (deprecate) complex_norm (same as torch.abs())

[ ] (deprecate) mag_phase

[ ] (deprecate) angle (same astorch.angle())

[ ] [WIP] phase_vocoder

[x] _measure (uses torch.rfft, complex_norm) (#941)

[ ] griffinlim (uses torch.istft, torch.stft)

torchaudio.transforms

[ ] Spectrogram

[ ] MelSpectrogram

[ ] GriffinLim

[ ] [WIP] TimeStretch

[ ] (deprecate) ComplexNorm

[x] Vad (#941)

torchaudio.compliance.kaldi

[x] spectrogram (uses torch.rfft) (#941)

[x] bank (uses torch.rfft) (#941)

cc. @vincentqb @mthrok
cc. @mruberry, who is working on the old API of torch.ftt deprecation, for visibility.

Thanks @anjali411.
Do we have an estimate on completion of this migration?
(By the completion of the migration, I mean we will only support complex dtype.)
I assume after all the implementation is completed, we want to have certain release cycles where users can opt-in for complex dtype, and make sure that some major downstream users migrate too.

Can you remind me why the flag USE_COMPLEX is needed here @anjali411 ?
to detect if the input is complex and if we should use the code for complex case (instead of the (..., 2) style float tensors. It also ensures we don't break autograd support in torchaudio (since it relies on torch for autograd correctness).

Can you remind me why the flag USE_COMPLEX is needed here @anjali411 ?
to detect if the input is complex and if we should use the code for complex case (instead of the (..., 2) style float tensors. It also ensures we don't break autograd support in torchaudio (since it relies on torch for autograd correctness).

Right, so the concern is that we could be passing a real tensor, which we want to treat as complex with zero imaginary for instance. In that case, we no longer need to detect whether the tensor is real or complex, right? We can just go through the complex path. Is that right?

This issue is replaced by #1337


Questions about benchmarking performance

Hardware Resources
CPU and Memory
24(vCPUs)96 GiB
Operating System
CentOS 7.9 64-bit
Data set size
$ du -h
100K	./nation
5.3G	./lineitem
266M	./customer
1.3G	./orders
866M	./partsupp
19M	./supplier
100K	./region
139M	./part
7.8G	.

Performance Test Results
cargo run --release --features "simd mimalloc" --bin tpch -- benchmark datafusion --iterations 10 --path ./tpch-parquet --format parquet --query 1 --batch-size 8192 --partitions 20
    Finished release [optimized] target(s) in 0.23s
     Running `/home/zhoupu/yukunpeng/arrow-ballista-master/target/release/tpch benchmark datafusion --iterations 10 --path ./tpch-parquet --format parquet --query 1 --batch-size 8192 --partitions 20`
Running benchmarks with the following options: DataFusionBenchmarkOpt { query: 1, debug: false, iterations: 10, partitions: 20, batch_size: 8192, path: "./tpch-parquet", file_format: "parquet", mem_table: false, output_path: None }
Query 1 iteration 0 took 2630.6 ms and returned 4 rows
Query 1 iteration 1 took 2581.2 ms and returned 4 rows
Query 1 iteration 2 took 2593.9 ms and returned 4 rows
Query 1 iteration 3 took 2585.9 ms and returned 4 rows
Query 1 iteration 4 took 2559.2 ms and returned 4 rows
Query 1 iteration 5 took 2570.1 ms and returned 4 rows
Query 1 iteration 6 took 2554.7 ms and returned 4 rows
Query 1 iteration 7 took 2567.0 ms and returned 4 rows
Query 1 iteration 8 took 2592.3 ms and returned 4 rows
Query 1 iteration 9 took 2653.5 ms and returned 4 rows
Query 1 avg time: 2588.83 ms

Questions

Do the results of this benchmark performance test meet expectations?
What are some ways to optimize performance?

Do the results of this benchmark performance test meet expectations?

Hi @artorias1024  -- these results look like they are approximately inline with what I have seen

What are some ways to optimize performance?

There are some thoughts here:
https://github.com/apache/arrow-datafusion/blob/b9f6e6b7c353c1109bd7b306008e006db29b46f8/docs/source/user-guide/library.md#optimized-configuration
Beyond that I think 'profile and then improve the bottlenecks' is what we have

I think this question has been answered and has been inactive for some time, so closing it down


Lyrics move Spotify up

When you open the Lyrics Page (native Spotify Lyrics) and the Song comes to an end, it moves the whole page up

@MGPlayzYT any suggestion regarding this Sir ?

@HypedDomi Im out for a while so it will take some time to fix the issue
Please be patient
Thanks for letting us know this problem your suggestion make bloom better

@MGPlayzYT any suggestion regarding this Sir ?

I'm not really sure what's causing this but it probably has something to do with Spicetify.

@HypedDomi Im out for a while so it will take some time to fix the issue
Please be patient
Thanks for letting us know this problem your suggestion make bloom better

Yeah thats fine. Take your time 👍

I'm gonna have to leave this up to someone who knows how to fix this, sorry for the inconvenience.

@HypedDomi is this issue still presents?

The last time i checked it was still there

try updating Spotify to the latest version and running the installation script again
it must fix the issue

@HypedDomi

The fix is not that good

try updating Spotify to the latest version and running the installation script again it must fix the issue

Sadly, I still have the issue. But yeah, I can live with that. It goes back when a new Song starts and only happens in the last 10 Seconds

Sorry for the situation ill try something to fix that I really apologize you both for this problem
Until I figure out a way to correct this issue I recommend you both to use spicetify lyric plugin for a better experience (this is not a fix, this is just a recommendation as a temporary solution)

@HypedDomi This issue was fixed by @miukyo so now you might good to go. Btw ill leaves this open for you to conform the fix
Thanks @miukyo
And all the participants

@nimsandu you're welcome.

Yep works. Thank you Miukyo


Support for Gitea/Forgejo instances

Not everyone has their projects on Github (fortunately).
Would it be possible to add support to the badge tool/website for Gitea/Forgejo instances?
For example: codeberg.org
Off course the preference would be for us to be able to add any Gitea or Forgejo instance.

Ah! I totally didn't realize that... On the main page there is zero information about "any git repository is supported and we have some automated check if it concerns a Github repository".
That, in combination with the very prominent Github login button probably put me on the wrong track.
When I clicked the "get your badge now" button, the next page said: "You may select from one of your GitHub repos OR provide information about some other project."
To me that sounded like "my github repo OR someone else's github repo"... after reading the entire text again, I guess the lower parts of the text can be construed as "any git repo".
Of course its entirely up to you guys but perhaps it'd be good to slim down the text somewhat and start it off with something like:
"You can use any valid git URL for this tool. If you point to a GitHub repository, we have some additional automatic checks that we can do. These automatic checks will be expanded to other services in the future."
If you're up for it, I could give it a rewrite as a PR if desired?

Actually, we don't limit repos to git. There are people who use mercurial, subversion, CVS, whatever, and those are fine. We have even less automation support for non-git, but we can handle them. We encourage distributed version control systems, but they are not required to get started.
As for a proposed rewrite, sure, I'd love to see what you come up with! The text is in config/locales/en.yml - from there it's translated to many other languages.

My apologies, I will not be contributing to the docs to suggest a rewrite.
Setting up an entire Ruby dev environment just to be able to preview some docs is not something I want to do right now. (note that the install script doesn't work for me on 22.04 LTS as PhantomJS doesn't have an install candidate.
Apart from that, I looked at the content of the config/locales/en.yml file and determined it is a little bit of a mess that I'd prefer not to spend my energy on right now.
Again, my apologies and good luck in the future.

If you wantvwmro tell me "change text again to bbb" that would br helpful. No need to set up a dev environment.
The text is in snippets to support many languages.


Move Conditional Logic from .pubxml to Project Files

The conditional logic for PublishReadyToRun and PublishTrimmed properties was moved from the .pubxml files to the project file, ensuring proper configuration for Debug and Release builds regardless of the platform.

/azp run

/azp run

@ShashankNay @Scottj1s  why removed Conditional Logic added into WinUI.Desktop.Cs.SingleProjectPackagedApp.csproj  and not in ProjectTemplate.csproj?

@Scottj1s You guys could put the condition on the PropertyGroup and then have only one of each property, no need to specify the False ones.
<PropertyGroup Condition="'$(Configuration)' != 'Debug'">

<PublishReadyToRun>True</PublishReadyToRun>
<PublishTrimmed>True</PublishTrimmed>

</PropertyGroup>


Added test and package to pipeline configuration

Original pull request by Thomas Moeller (Bitbucket: TheHubbit, GitHub: TheHubbit).

I only tested the steps on my computer locally. The Bitbucket pipeline currently doesn't run in my repo (I guess I should buy some build time now). Not sure if sudo is needed in docker image or not.

Original comment by Bastiaan Veelo (Bitbucket: veelo, GitHub: veelo).

The main repo also has just 3.5 minutes left, so that won't be enough. I'm merging, and we'll see whether it works or not next month :-)


help add repo  gstreamer and it's various plugins

gstreamer is strong and powerfull, many open source depend on it. but it is complex  to port。

Already have a request
https://github.com/Microsoft/vcpkg/issues/1474
And here is the port, but...
https://github.com/fujii/vcpkg/tree/gstreamer

@Voskrese thanks, how about those plugins ,gst-plugins-good, gst-plugins-base?

@zuowanbushiwo Yes, as if, until you do it yourself, no one will do it

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


openebs should never try to install crd for snapshot/volumesnapshotcontent/volumesnapshot

Description

Other storages like rook.io or even longhorn requires the user manually install the snapshot operator and crds in the cluster if the user wants to have snapshots enabled. If the user already have installed those to provide those features for ceph or longhorn, it wont be possible to helm install openebs because it will fail complaining for already existing crds not created by the chart.
Expected Behavior
Helm should not try to install those cluster crds related to snapshots.
Current Behavior
it fails
Possible Solution

Add the documentation for it and do not try to install OR add a install-snapshot-crds helm value.
Steps to Reproduce
Install k8s snapshot operator and crds manually
try to deploy openebs like this:
 helm install openebs openebs/openebs --set cstor.enabled=false --set nfs-provisioner.enabled=false --set localprovisioner.enabled=false --set zfs-localpv.enabled=false --set lvm-localpv.enabled=true  --set ndmOperator.enabled=false  --set ndm.enabled=false --namespace openebs --create-namespace --set snapshotOperator.enabled=false

It will fail:
Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: CustomResourceDefinition "volumesnapshotclasses.snapshot.storage.k8s.io" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "openebs"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "openebs"

Would --skip-crds help here?

No really. That would skip installation of the required openebs crds.
What I ask here is that openebs crd should not contain  snapshot/volumesnapshotcontent/volumesnapshot crds.
Just as in rook.io ( ceph) and longhorn, if the user want support for that, the user should install those CRDs. That way one can have ceph, openebs and longhorn without conflicts.

Same issue here; conflicts when using multiple CSI-based storage solutions.

Found the solution.
Use lvm-localpv.crd.volumeSnapshot=false

The cStor, zfs-localpv and lvm-localpv helm charts already have this switch for disabling the installation for these CRDs (Included in 3.10.0). Closing this.

I just got tripped up trying to do this for zfs-localpv. The following worked:
zfs-localpv:
  crd:
    volumeSnapshot: false

But it looks like there is a new chart version in the works in which it'll change to be the following:
zfs-localpv:
  crds:
    csi:
      volumeSnapshots:
        enabled: false

Maybe that'll save someone some time

The same workaround for cStor
cstor:
  crd:
    volumeSnapshot: false


Use go install over go get

Apparently using go get is deprecated for installing packages: https://golang.org/doc/go-get-install-deprecation

I realized this only applies to Go 1.17, and we haven't changed our version to that yet.


added nice hover effects to the pictures

Sorry I forgot to remind you, don't merge this, I did this a long time ago


android:allowBackup should not be used in library

Hi,
property:  "android:allowBackup" shouldn't be used in library because it cause an error with building app on prodction

You are right.
Forgot to remove it.
I will make an version today and change it.

ok, Great!

Fixed on 1.0.8.


Fix license file

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

about/license_family 'Boost' not allowed. Allowed families are AGPL,
APACHE, BSD, CC, GPL, GPL2, GPL3, LGPL, MIT, MOZILLA, NONE, OTHER,
PROPRIETARY, PSF, and PUBLIC-DOMAIN.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Precompilation warning

This is a minor issue:
WARNING: method definition for OneHotArray at ~/.julia/packages/MicroCollections/yJPLe/src/onehot.jl:79 declares type variable N but does not use it.

This is now fixed in https://github.com/JuliaFolds2/MicroCollections.jl, and is now on the General registry


Feature Request: Ability to Sort by Moded Items

Would it be possible to be able to filter the list of items in the equipment listing to show only modded items from penumbra? Being able to easily select my modded items would be amazing for quickly changing outfits. I know this is something Anamnesis does for TexTools mods already and it would be wonderful to see here too.

Not easily.


@import url("./test.css") does not work within css files

Link to reproduction
N/A
Describe the Bug
If you are using css instead of scss, importing css files into your main file does not work.
Error output:
Error: Can't resolve 'test.css' in '/path-to-project/node_modules/payload/dist/admin/scss'
    at finishWithoutResolve (/path-to-project/node_modules/enhanced-resolve/lib/Resolver.js:369:18)

The workaround for now is to use scss files, which works as expected.
To Reproduce
// file: payload.config.ts

import { webpackBundler } from '@payloadcms/bundler-webpack'
import { mongooseAdapter } from '@payloadcms/db-mongodb'
import { lexicalEditor } from '@payloadcms/richtext-lexical'
import path from 'path'
import { buildConfig } from 'payload/config'

export default buildConfig({
  admin: {
    bundler: webpackBundler(),
    css: path.resolve(__dirname, './css/styles.css'),
  },
  collections: [],
  db: mongooseAdapter({
    url: process.env.DATABASE_URI,
  }),
  editor: lexicalEditor(),
})

/* file: css/styles.css */

@import url("./test.css")

/* file: css/test.css */

body {
  background-color: red;
}

Payload Version
2.2.2
Adapters and Plugins
@payloadcms/bundler-webpack

Font files are also unable to be imported unless they are in the top level file.

I think the way forward here is to provide your own custom webpack alias, this will allow files to be found when imported within inside of the admin/scss/app.scss file.
Here is an example:
// file: payload.config.ts

import { webpackBundler } from '@payloadcms/bundler-webpack'
import { mongooseAdapter } from '@payloadcms/db-mongodb'
import { lexicalEditor } from '@payloadcms/richtext-lexical'
import path from 'path'
import { buildConfig } from 'payload/config'

export default buildConfig({
  admin: {
    bundler: webpackBundler(),
    css: path.resolve(__dirname, './css/styles.css'),
        webpack: (config) => ({
      ...config,
      resolve: {
        ...config.resolve,
        alias: {
          ...config?.resolve?.alias,
          '~css': path.resolve(__dirname, './css'),
         // ^^ this line
        },
      },
    }),
  },
  collections: [],
  db: mongooseAdapter({
    url: process.env.DATABASE_URI,
  }),
  editor: lexicalEditor(),
})

/* file: css/styles.css */

@import '~css/test.css';

/* file: css/test.css */

body {
  background-color: red;
}

This will fix the inability to import font files as well, for example:
/* file: css/fonts.css */

@font-face {
  font-family: 'YourFontName';
  src: url('~css/my-font.woff') format('woff2');
  font-weight: normal;
  font-style: normal;
}


Have an ansible role, that wrap the functionality

As a devops team, it could be of lot of valuable to have an ansible role that run the tool automatically.
one can directly call the sh script available when installing the rpm page like this.
docker run purbon/kafka-topology-builder:latest kafka-topology-builder.sh  --help
Parsing failed cause of Missing required options: topology, brokers, clientConfig
usage: cli
    --allowDelete          Permits delete operations for topics and
                           configs.
    --brokers <arg>        The Apache Kafka server(s) to connect to.
    --clientConfig <arg>   The AdminClient configuration file.
    --help                 Prints usage information.
    --quite                Print minimum status update
    --topology <arg>       Topology config file.

this could later be as well integrated into cp-ansible.

initial development of that is taken care at https://github.com/purbon/ansible-kafka-topology-builder

closing this here in favour of the separate repo

closing this here in favour of the separate repo


Integrate angular material 2 scss framework

Abandoning the @angular/material NodeJS package due to importing errors with SystemJS.
The alternative is a currently a toss-up between two CSS libraries, Materialize and Material Design Lite. I'm leaning towards the latter for faster load times.


Switch validate to serviceValidate for increased functionality

I have an implementation of flask-cas that supports attribute handling from the serviceValidate endpoint. Is this functionality of interest to the maintainer of the library? If so I can submit a pull request.

Sure. Lets have a look!

I'm going to look into adding a 'filter by attribute' sort of decorator similar to login_required which will make sure the user has the correct attribute to access content. Expect something later this week.

Sounds interesting


[FLINK-7998] private scope is changed to public to resolve access exception

Looks good but I have not tested. Can we also fix the parameter swap referenced in the JIRA?

@greghogan @naeioi have done some changes in both TPCHQuery3.scala and TCPCHQuery3.java

Thank you for fixing this, merging.


Add  ebi survey banner

Here is how the banner is displayed on the ols website

Nice! We will merge this in just before the survey is due to start!


Add jest config

[x] Add jest config
[x] Test a basic existing function.

Interesting Notes:
How to configure jest with typescript? https://jestjs.io/docs/getting-started
Reference to globals in jest? https://jestjs.io/docs/api
How to mock in jest? https://jestjs.io/docs/mock-function-api#typescript-usage

comments addressed,  @kindoflew!


Add a license file

According to your package.json file, this app is intended to be released under MIT licensing. However, without a LICENSE file, it is hard for visitors (or GitHub) to see this.
https://help.github.com/articles/open-source-licensing/

And thanks again!


Spacing issue with Unity's new UI in 2019.3x

https://crayz.tv/files/sharex/Unity_2019-06-01_18-30-22.png
https://github.com/Chaser324/unity-build/blob/e600119a8449bfe4e72f9540bb6986ca8a9e46f9/Editor/Build/UI/UnityBuildGUIUtility.cs#L66
Setting the above line to GUI.skin.textArea solves the problem.

👍 omg thank you So much do you plan to make a pull request  to change it ?


Audio.java

Audio for your project :)

Can you add more details around what is the feature you are trying to add? And how you are using it in project. I can only see independent Audio.java Its not been referenced anywhere!!

With this code you can add sound effects, for example when client deposits money, sound effect when clicking buttons or even background music.

I forgot that your code is not user friendly, it's not GUI.


macOS: Window position and size isn't remembered

The app always opens in a 500x500 square near the centre of the screen. It should follow the default mac behaviour of re-opening at the previous size and position.
See the following for ideas on how to solve it:

https://github.com/tauri-apps/tauri/issues/3740
https://github.com/tauri-apps/tauri-plugin-window-state
https://github.com/tauri-apps/plugins-workspace/issues/250

Hi, thanks alot for the report. I wasnt aware of this because i don use macos normally. But really great suggestion! Ive added the plugin you linked to. Next version should include this.

Thanks for the quick fix! I'll give it a try locally shortly and report back if there's any issues.


DB updater service project

Added Db updater service project

Let's convert this project into a standalone microservice, with its own API, Dockerfile and requirements.txt

This PR is approved, feel free to merge :)


logger: allow configuring what logs get sent to the remote logging service

Allow configuring what logs get sent to the remote logging service by respecting the RUST_LOG_REMOTE environment variable. If RUST_LOG_REMOTE is not set then fall back to look at the normal RUST_LOG environment variable.

/land

@bmwill let's cherry-pick this to the release branch and submit for gatekeeper review?

/cherry-pick release-1.4

@bmwill :cherries: Opened PR #9192 to cherry-pick these changes into release-1.4


trying to use x32 arch

Hi, @shishodiyas 👋 ! Thank you for your question! I suggest you check the documentation for the setup-node action because there you can find all the needed information on how to put inputs properly. In your case, instead of x32 you can use x86.
I'm going to close this issue now, If you have any question feel free to ping us! 💌


Some questions about debug mode

Hi! There is some question about debug mode.
In my case, I do not want to any interaction about X server. However,when I set debug to 0, It reports key error "ret[generic]" while running demo.py . I'm just starting to use this code. Can you give me some advise to solve the problem?

I have commited all cv2.imshow  code and run demo.py in debug 1.But I still not clear how to use debug 0 .

Hi,
Sorry for the confusion, --debug 0 is not implemented properly in the code, as I didn't take care of opt.debug > 0 and opt.debug >= 0. Please use debug 1 if you just want to visualize the bounding boxes or debug 2 if you want to visualize the heatmaps as well.

Thx for reply! I got it!


Workbench Color Themes drop down list box is empty

Issue Type: Bug
I was trying different workbench color themes and after I changed it 3 times, then the drop down list box went empty (i.e. I cannot change the workbench color theme any more because there are now 0 listed).  I am stuck in the last one I chose.
VS Code version: Code 1.31.0 (7c66f58312b48ed8ca4e387ebd9ffe9605332caa, 2019-02-05T22:35:56.624Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E3-1505M v6 @ 3.00GHz (8 x 3000)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
63.85GB (57.16GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Did you make ant changes to the installed extension?
Can you verify that the default themes are still installed?

Hi,
I did not make any changes to the installed extension.
I have verified that the default theses are still installed.
I was able to work around the bug after noticing that there was "color theme" menu item hanging directly off the "option gear" in the lower left hand corner of the left vertical icon bar.  This showed all the themes and I was able to change my theme repeatedly using this menuitem.

From: Martin Aeschlimann<EMAIL_ADDRESS>Sent: Wednesday, February 13, 2019 12:54 AM
To: Microsoft/vscode
Cc: Anthony LaMark; Author
Subject: Re: [Microsoft/vscode] Workbench Color Themes drop down list box is empty (#68544)
Did you make ant changes to the installed extension?
Can you verify that the default themes are still installed?
[screenshot from 2019-02-13 09-52-51]https://user-images.githubusercontent.com/6461412/52699097-419d0780-2f75-11e9-867c-a5803cef7ea0.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vscode/issues/68544#issuecomment-463112936, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADD6WqfquSstl9a020VfncNYP7WLWxzJks5vM9LcgaJpZM4a3ijI.

Where was the empty color theme drop down list box that you saw?
Settings UI? Settings.json editor?

Settings ui
Anthony LaMark
562.221.3079
Squadra Technologies
Sent from phone

From: Martin Aeschlimann<EMAIL_ADDRESS>Sent: Wednesday, February 13, 2019 11:30:11 AM
To: Microsoft/vscode
Cc: Anthony LaMark; Author
Subject: Re: [Microsoft/vscode] Workbench Color Themes drop down list box is empty (#68544)
Where was the empty color theme drop down list box that you saw?
Settings UI? Settings.json editor?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vscode/issues/68544#issuecomment-463334348, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADD6WhANkivM4KRZAEZtjLsrZLI6-GDtks5vNGfDgaJpZM4a3ijI.

This is covered by https://github.com/Microsoft/vscode/issues/67452 and https://github.com/Microsoft/vscode/issues/67462


[ACR] Change audience to be optional

Resolves https://github.com/Azure/azure-sdk-for-python/issues/22229

/azp run python - containerregistry - tests-weekly

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-containerregistry

/azp run python - containerregistry - tests-weekly

/azp run python - containerregistry - tests-weekly

/azp run python - containerregistry - tests-weekly

/azp run python - containerregistry - tests-weekly

/azp run python - containerregistry - tests-weekly

/azp run python - containerregistry - tests-weekly

/azp run python - containerregistry - tests-weekly


Fix regex in test_print_report

The PR fixes a test failure introduced by #6254.  With unit='ns', a long cell can change the number of spaces.

Jenkins, test this please

Jenkins CI test (for commit 28ae11e09fb0777de82e1f56aee0b7330a8420ef, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

LGTM


Processing order of late events is undefined

It seems like the "late API message" mechanism (which just clamps the timestamp to the start of the current frame) results in undefined processing order, and that's why we're having problems like https://github.com/olofson/koboredux/issues/401 and https://github.com/olofson/koboredux/issues/512.

I don't think this matters, actually - or rather, avoiding this issue does not solve the problem. After some experiments with this, I've concluded that the aforementioned Kobo Redux problems can occur even if messages arrive in order.
It seems like the problem is with creating or finding the A2_TNEWVOICE placeholder handles, which are to serve as event queues for voices not yet instantiated.

Turns out the Kobo Redux problems were eliminated by avoiding dropped messages due to API buffer overflows, so I'm leaving this for the next release.


Eval symlinks in input files

My $GOPATH is ~/golang, but I also like to have all my projects in ~/projects. That's why I symlink my projects from $GOPATH in ~/projects.
All the go tools work without problems in a symlinked directory (go *, golint, goerr, vim-go, gofmt, goimports, ...) but ffjson fails with:
Error: error=Could not find source directory: GOPATH=[".../golang"] REL="..." path="":

This (minor) change allows ffjson to be executed in symlinked directories.

Thank you!


Git - Add support for cancelling long commit operation (including its pre-commit script)

Type: Bug
When using the 'Source Control' panel to commit/push, sometimes it get stuck endlessly (the blue line above the 'Message' field keeps running forever to show that something is running in the background).
The only way I to cause it to stop - it to close ALL instances of VS Code, and re-open them.
This happens more than you might expect (like once in a few weeks).
Please develop a way to stop git commands that are running in the background (it would also be helpful when regretting very large commits and want to stop them during the (long) commit time)
VS Code version: Code 1.74.2 (e8a3071ea4344d9d48ef8a4df2c097372b0c5161, 2022-12-20T10:26:09.430Z)
OS version: Darwin x64 19.6.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
8, 4, 3

Memory (System)
32.00GB (0.55GB free)

Process Argv
-psn_0_65552 --crash-reporter-id 61cd818d-44a5-46cb-a1bd-ccd50a28ca90

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

god
bas
0.0.104

vscode-eslint
dba
2.2.6

gitlens
eam
13.2.0

vscode-pull-request-github
Git
0.56.0

vscode-graphql-syntax
Gra
1.0.5

todo-tree
Gru
0.0.220

rainbow-csv
mec
3.5.0

dotenv
mik
1.0.1

vscode-typescript-next
ms-
5.0.202301100

oso
oso
0.32.0

code-spell-checker
str
2.14.0

pdf
tom
1.2.2

vscode-icons
vsc
12.0.1

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
azure-dev_surveyone:30548225
pyindex848:30577860
nodejswelcome1:30587005
282f8724:30602487
3d0df643:30613357
f6dab269:30613381
fim-prod:30623723
vscsbc:30628655

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.74.3. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

I've upgraded to the following version, and the problem still exist:
Version: 1.74.3
Commit: 97dec172d3256f8ca4bfb2143f3f76b503ca0534
Date: 2023-01-09T17:07:18.579Z
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0
Sandboxed: No

@Asaf-S, sorry to hear about the issue that you are facing. When the issue reoccurs would you be able to provide a screenshot of VS Code? Also the logs from the git output window would be helpful to track down the command that is being executed. Do you have any git commit hooks configured on the repository? Does is occur when you leave the commit input empty and you try to commit?

@lszomoru - thank you for responding.

I'll take a screenshot when this happens again, but I also think you can easily reproduce it by adding a never-ending task in the pre-commit git script. There's just no way to cancel such a task that is running in the background.
From my experience, the logs are being outputted to the OUTPUT -> Git logs only AFTER the end of the task, so you'll probably see nothing there. And, again, I don't think the log will help here, as the problem is that there's no way to cancel such a git task that is running in the background.
I do have git commit hooks, the pre-commit one is doing all sorts of things, like checking the spelling, ES-Lint, prettier, and among others running the tests. This cannot be the problem, the problem is that there's no way to cancel such a git task that is running in the background.
As to your question Does is occur when you leave the commit input empty and you try to commit? - I didn't really understand what you meant by saying commit input empty if you mean the pre-commit script, then I guess that it will cause the git background tasks to hang more rarely - however, the problem is that there's no way to cancel such a git task that is running in the background, like in a situation where you accidentally tried to commit 100 GB of data.

Hope I was clear about what the problem is :)

@Asaf-S, thank you very much for the additional information. While there is a setting git.supportCancellation that can be enabled in order to add support for cancelling a sync operation, there is no way to cancel a commit operation. I will update the title of this issue in order to make it clear that this is a feature request for adding cancelation support to the commit operation.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Related: #66821.
Related on Stack Overflow: How can I abort a commit from VS Code's UI?


'Encoding::UndefinedConversionError ("\x89" from ASCII-8BIT to UTF-8)' with latest version

Hi,
with version 1.3.5 I get the following exception:
Encoding::UndefinedConversionError ("\x89" from ASCII-8BIT to UTF-8)
I am using chunky with rqrcode. With version 1.3.4 I do not have this issue. Because of that I open the issue here.
I am doing smth. like this:
File.open(tmp_file.path, 'w') {|f| f.write barcode.to_png(height: 200, margin: 25, xdim: 100) }
Is there smth. I have to change in my code? Pending further notice I stick to v 1.3.4.
Cheers and thanks for your work!

Is it possible to get a full stack trace so I can see where exactly this exception occurs?
My best guess is that this commit introduced the issue.

Hi @wvanbergen,
unfortunately I do not get a better trace, sorry.
But your guess seems right, I uncommented the line in chunky 1.3.5 and it worked again as expected...
Cheers

Please do not reverse afc1918, this is the correct way of doing things. The problem is in your own code:
barcode.to_png returns a binary blob (ASCII-8BIT) as expected. And you are trying to save that into a file. The issue is that the default file opener uses UTF-8 for the encoding. You need to tell it to open it as a binary: File.open(tmp_file.path, 'wb').

@tweksteen is absolutely right, this was my mistake - with 'wb' it works as expected. Anyway, I guess this would be worth of a note in the changelog. Thanks for all your responses!


rocket command not working

this is a screenshot of the error i get when trying to run it - https://gyazo.com/a1fe21bf81281a831bd6c010c2039528
also it only says this if you use the command from console

I am getting this problem too. Any workarounds other than having to go in-game and type it?

only way i have found is to admin yourself then do them in game

Fixed


CIV-9786 Refactor Free from order after hearing scheduled

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)
[ ] Screenshot attached for the Evidence of manual testing
[ ] Functional, Smoke and API tests have been run locally
[ ] Full gradle build and run tests with coverage have been completed (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-9786
Change description
Update the wording and list options on free form order after hearing scheduled
Testing branch and instruction
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No


Can Manifest Mode can configure every package seperatly?

Environment
Windows
To Reproduce
Like:
{     "name": "your-project-name",     "version-string": "1.0",     "dependencies": [         {             "name": "<libname>",             "triplet": "x64-windows-static"         }     ] }
### Tasks

Thanks for posting this issue. Can you describe it in more detail? Are you intending to create a separate file for each port?

i'm trying to use vcpkg to install different package with different triplets (in manifest mode)

like:
{
"name": "my_project",
"version-string": "0.1",
"dependencies": [
{
"name": "openssl",
"version": "1.1.1",
"triplet": "x64-windows-static"
},
{
"name": "fmt",
"version": "7.1.3",
"triplet": "x86-windows"
},
{
"name": "sqlite3",
"version": "3.36.0",
"triplet": "x64-linux"
}
]
}


"Postârnacu", "Ungureni" are listed in the drop-down menu

Description:
When user writes ”Postârnacu” and "Ungureni" the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Postârnacu"

Expected results
The location appears in the drop-down menu as "Sat Postârnacu, DÂMBOVIȚA (Cornești)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Ungureni"

Expected results
The location appears in the drop-down menu as "Sat Ungureni, DÂMBOVIȚA (Cornești)".


Face Group

I am using meshio to convert FLAC3D  (v.7) data to VTK format.  Would it be possible to include face groups into this conversion? Attached you will find a simple model. The model contains only one surface as a fracture, represented by a group of face entities (attached picture). We may have up to 100 surfaces that represent fracture distribution in our model.
Best Regards,
Alireza Hassanzadegan

Ping @keurfonluu.

Sure, I'll look into that.

Fixed via #886.


Support custom param root in hk.get_parameter()

I am trying to implement a NAS algorithm and in my network I have multiple cells that share some architecture parameters.
Currently, to share a parameter, I have to pass it as argument to the __init__ function and create it with hk.get_parameter somewhere higher up in the tree.
It would be nice if hk.get_parameter accepted a rootPath parameter so that I can tell it to get a parameter that is global to the tree instead of one that is local to the current module.

Hi @jaideepheer , thanks for the details! We'd prefer to not make get_parameter more complex at the moment, it is already a new concept for users and a bit confusing to folks getting started.
I think your proposed work around is good (passing in the parameter to one of the module methods). You may also find it convenient to pass in a module rather than the parameter itself. You may find that some common code can be put into this "shared"/"common" module and reused between both architectures.
For folks reading along I made an example of what I meant here: https://colab.research.google.com/gist/tomhennigan/0dfe032cff5210aa16f9671b07f87bb1/example-of-parameter-sharing-via-shared-module.ipynb


[144714671] update readme and store to reflect defence feedback

What does this PR do?
Implement feedback received from the defence session.
Description of Task to be completed?

Include application heroku link in readme.
Refactor headers in the readme.
Use markdowns to format the sections contained in the readme.

How should this be manually tested?
NA
Any background context you want to provide?
NA
What are the relevant pivotal tracker stories?
#144714671
Screenshots (if appropriate)
NA
Questions:
NA

Coverage remained the same at 47.059% when pulling 1b0df1a112c8ff38d170b6891a80563fe01e424e on implement-defence-feedback-144714671 into 8ad29609602d9394486b7e3e145fd04e6941c476 on develop.


upgrade to the latest version of scalajs?

Do you have plans to upgrade the settings?

Would you like to submit a pull request?

I am just starting to learn scala.js. Don't know how to work with the settings yet.


Got some question of supports.

Does this repository doesn't support multimodal models such as llava?

unfortunately not yet, but i want to support it when i have some free time.


Fix distribution error

When trying to create a distribution with insufficient inventory in stock, the error handling now more closely matches the error handling in the transfers controller. In addition, coffee script has been added to ensure that fields behave as intended after a failed distribution creation. Finally, a bug that allowed a distribution to contain any quantity of an item if the stock in a location was 0 has been fixed.

:100:


IJCK #2 R2C3

p. 9 “If the volume-history of an RCM experiment is provided in the ChemKED file, it is stored in this attribute as a namedtuple ,” Question: Is this format able to handle the case when a shock tube measurement is accompanied with a pressure history?

We currently support a constant preignition pressure rise, but not an actual pressure history—but it would be quite simple to extend to this. I can probably tackle that fairly easily.
@bryanwweber any opposition?

I would suggest referring to our changes to the time-histories field in https://github.com/pr-omethe-us/PyKED/issues/91

ah, crap. I guess we need to update the text to reflect those changes.

Well, those changes haven't been made yet, so maybe just a footnote would be good.

This is the discussion I am adding to the response:

The current version of ChemKED can represent a constant preignition pressure rise
in shock tubes through the \yabox|pressure-rise| key. It does not currently
support specifying a pressure time-history, although we are planning to extend
support for more time histories for both shock tubes and rapid compression
machines in a future version (for, e.g., pressure, volume, piston position, light
emission, OH emission, and absorption). See \url{https://github.com/pr-omethe-us/PyKED/issues/91} for our discussion on these plans.

And I added a footnote to page 7:

Future versions of ChemKED will support specifying additional time histories for rapid compression machine and shock tubes (e.g.,pressure, volume, light emission, OH emission). These will follow the specification format given for volume.


Svelte 5 support

This updates the library to Svelte 5. This breaks compatibility with Svelte 4.
Went with $derived.by over $effect to compute _crumbs in the Breadcrumbs component as it is side-effect free now and runs fine on the server.
Did some initial testing and it seems fine, but more testing will be needed.

Did some more testing. Should be good for review.

Really sorry about the delay, new job had me super busy there. This looks great to me, thanks again for helping out with this!


Overview and extension manifest for VSIX marketplace

Overview and extension manifest for VSIX marketplace.
For use in automated publishing of the VSIX.

/azp run


bug no work copy

It doesn't work to copy

UH OH.. lemme look into this :(

Hi, can u run the following command within the directory?
git pull


Make movies with povray

VTK has an exporter for povray.  It actually works.  With a little TLC this might be useful for making flashier movies.

This is super exciting! Having to play my trajectories back at 1 fps or lower to render movies in Director was getting annoying ;-)

A few test renders-
http://people.csail.mit.edu/patmarion/software/director/media/movies/

Hi Pat,
Any idea on when this feature might land? I've seen your branch (https://github.com/RobotLocomotion/director/compare/master...patmarion:add-povray-exporter) and wondered where and how we can help with TLC to get it into master. We're facing the issue of having to play back at 1-fps as well.
Cheers,
Wolf

i don't have any plans to continue developing this branch in the near term, but I'd be happy to merge it into master after just a little clean up.  It's basically in a working state, except I'm sure I broke a couple things when I rebased it.
I can make the code in moveexporter.py general purpose and move all the custom code into an example script.  There are also some pov-ray files required that are not in this branch but I have them in my dropbox.
Maybe we can schedule a time to talk on gchat while we try to get it working on your machine, then you can take it from there?

Sounds great - any time after Thursday is good, perhaps early next week?


Sort v1.9.1 backports complexity

test-backport-1.9

test-backport-1.9

retest-runtime

retest-gke

retest-4.19

retest-4.19

test-backport-1.9

test-backport-1.9

retest-gke

retest-runtime

test-1.18-4.19

test-backport-1.9

retest-runtime

test-backport-1.9


Move DocumentSync to VSContracts

Summary of the changes

Move the TextDocumentSync Endpoint to VS Contracts

Fixes: https://github.com/dotnet/razor-tooling/issues/6366

Of particular note is that if you want to return Unit (as void is not legal with JSONRPC) you must define your endpoint as a IJsonRpcNotificationHandler<Param> instead of a IJsonRpcResponseHandler<Param, Unit>, or it will fail to bind. That one ate ~2 hours lol.

Of particular note is that if you want to return Unit (as void is not legal with JSONRPC) you must define your endpoint as a IJsonRpcNotificationHandler<Param> instead of a IJsonRpcResponseHandler<Param, Unit>, or it will fail to bind. That one ate ~2 hours lol.

Ahhh ya I ran into that too a little while back. Drove me nuts similarly. Sorry I didn't share earlier 😢


KAFKA-14491: [2/N] Refactor RocksDB store open iterator management

This PR refactors how the list of open iterators for RocksDB stores is managed. Prior to this PR, the openIterators list was passed into the constructor for the iterators themselves, allowing RocksDbIterator.close() to remove the iterator from the openIterators list. After this PR, the iterators themselves will not know about lists of open iterators. Instead, a generic close callback is exposed, and it's the responsibility of the store that creates a new iterator to set the callback on the iterator, to ensure that closing an iterator removes the iterator from the list of open iterators.
This refactor is desirable because it enables more flexible iterator lifecycle management. Building on top of this, RocksDBStore is updated with an option to allow the user (i.e., the caller of methods such as range() and prefixScan() which return iterators) to pass a custom openIterators list for the new iterator to be stored in. This will allow for a new Segments implementation where multiple Segments can share the same RocksDBStore instance, while having each Segment manage its own open iterators. (See https://github.com/apache/kafka/pull/13143 for more.)
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

There is a test failure -- seems you need to update shouldCloseIterator() test and set a callback via onClose()?

Thanks @mjsax , fixed now. Wasn't sure whether it'd be better to add a dummy close callback just for the single test or for all tests (even the ones which do not call close(), and therefore it doesn't matter). Only added it for the single test for now to keep things simple.

Checkstyle error:
> Task :streams:checkstyleTest

[2023-01-26T22:45:54.179Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-13142/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBRangeIteratorTest.java:396:44: '{' is not followed by whitespace. [WhitespaceAround]

[2023-01-26T22:45:54.179Z] [ant:checkstyle] [ERROR] /home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-13142/streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBRangeIteratorTest.java:396:45: '}' is not preceded with whitespace. [WhitespaceAround]


failing unit tests

Hi, it seems there is currently the smoke test failing.

How could I help here too? =)

Hi Daniel, looks like the build is okay now.  I am going to close this, please open a new issue if you continue to run into this.


can not decode frame if I use cisco's openh264 dll version 2.1.0 or later.

can not decode frame if I use cisco's openh264 dll version 2.1.0 and later.

dll ver
encode
decode

2.0.0
OK
OK

2.1.0
OK
NG

I think it may effect of https://github.com/cisco/openh264/commit/bbcc2cb202d01767d42aa2b545735342e82f281f.

Difference from v2.0.0 to v2.1.0 is TagBufferInfo structure member.
unsigned char* pDst[3] is added.
// v2.0.0
typedef struct TagBufferInfo {
  int iBufferStatus;             ///< 0: one frame data is not ready; 1: one frame data is ready
  unsigned long long uiInBsTimeStamp;     ///< input BS timestamp
  unsigned long long uiOutYuvTimeStamp;     ///< output YUV timestamp, when bufferstatus is 1
  union {
    SSysMEMBuffer sSystemBuffer; ///<  memory info for one picture
  } UsrData;                     ///<  output buffer info
} SBufferInfo;

// v2.1.0
typedef struct TagBufferInfo {
  int iBufferStatus;             ///< 0: one frame data is not ready; 1: one frame data is ready
  unsigned long long uiInBsTimeStamp;     ///< input BS timestamp
  unsigned long long uiOutYuvTimeStamp;     ///< output YUV timestamp, when bufferstatus is 1
  union {
    SSysMEMBuffer sSystemBuffer; ///<  memory info for one picture
  } UsrData;                     ///<  output buffer info
  unsigned char* pDst[3];  //point to picture YUV data
} SBufferInfo;

and retrieve output data from sDstBufInfo.pDst.
// v2.0.0
pDecoder->DecodeFrame2 (NULL, 0, pData, &sDstBufInfo);
pDst[0] = pData[0];
pDst[1] = pData[1];
pDst[2] = pData[2];

// v2.1.0
pDecoder->DecodeFrame2 (NULL, 0, pData, &sDstBufInfo);
pDst[0] = sDstBufInfo.pDst[0];
pDst[1] = sDstBufInfo.pDst[1];
pDst[2] = sDstBufInfo.pDst[2];


lib: posix: Do not redefine PATH_MAX in unistd.h

This constant should be defined in limits.h.  Define it in limits.h in
the minimal libc, and use the definition found in newlib's includes.
Values in newlib includes range from 1024 to 4096.
The rationale is that all code should use the same value; having
buffers specified with different sizes will lead to interoperability
and out of bounds array writes.
Signed-off-by: Leandro Pereira<EMAIL_ADDRESS>

Codecov Report

Merging #7664 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7664      +/-   ##
==========================================
- Coverage   54.97%   54.97%   -0.01%
==========================================
  Files         481      481
  Lines       53794    53794
  Branches    10473    10473
==========================================
- Hits        29574    29573       -1
- Misses      19939    19940       +1
  Partials     4281     4281

Impacted Files
Coverage Δ

lib/posix/fs.c
47.94% <ø> (ø)
:arrow_up:

lib/posix/pthread.c
69.34% <0%> (-0.51%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6944d...e60adb5. Read the comment docs.


Playback stalled after using a "skip back" feature

I'm looking at an issue on a 2018 LG TV.  I suspect it's related to "buffer trimming" by the OS when there's more data in the SourceBuffers than memory allows (the OS had to reclaim some resources).  I guess it could be Shaka doing an explicit remove()?
The problem is happening when I use a "skip back" button in our UI.  You know the type of "quick review" feature that seeks back something like 30 seconds when you want to quickly repeat what just played.
What I'm seeing is that playback jumps back as expected, and plays OK for a short time, but then playback stops.  In the logs, I see a "waiting" event from the video element because there's no buffered data at currentTime.
When it happens playback doesn't resume.  To recover we must quit the player and restart.
It's an intermittent issue, but here's what I've extracted from logs for one instance when it happened:

seeking event (to time 1549.57)
seeked event (currentTime reports 1549.57)
canplay, play, playing events (currentTime reports 1549.57)
checking buffered ranges on video element reports  1549.505044 => 1576
progress event
Shaka log message reports: "Ignoring large gap at 1549.546 size 10.970043999999916"
3 seconds after the "playing" event I see a "waiting" event

currentTime at that instant reports a time of 1552.549
checking buffered ranges of video element reports  1560.516044 => 1576

IMO, this is primarily an issue with the underlying webOS player pipeline.  It appears to be making poor choices when it comes to choosing data to discard!  However, I'm wondering if you'd expect Shaka to attempt to reload data around the video element's currentTime when this type of "buffer trimming" occurs on resource limited devices.

I think I see the bug.  When we do an append, we cache the video's current time and pass that around.  As part of the append, we evict data behind the playhead according to streaming.bufferBehind configuration.  We do the eviction based on the cached current time and after we fetch the segment.
So it is possible that, while downloading the segment, we seek backward.  The seek happens immediately and we detect it as a buffered seek and do nothing.  Then after the download is done, we evict based on the old time.  This evicts the time around the current time and we don't re-download those segments.
You could work around this by setting streaming.jumpLargeGaps to true, but that will just cause us to jump ahead again and basically ignore your seek backwards.

This is actually fairly easy to reproduce on Chrome on desktop.  Just start in the middle of the video and use video.currentTime -= 3 in DevTools several times.  It works better on a slower connection so the video buffers.

I am able to reproduce fairly easily with v3.1.1, but cannot reproduce on the latest release (v3.2.1).  Can you try with the latest version to see if it has been fixed?

Can you test with v4.3.3? Thanks!


Remove logging module

Once https://github.com/GoogleCloudPlatform/jetty-runtime/issues/68 is complete, there are no users of the JSON log formatter in the logging module, so it should be removed.

Could you elaborate on what logging module you'll remove? I am using JSON logging with openjdk-image right now. I just want to make sure I can continue to use it.
Currently, I'm writing JSON logs to /var/log/app_engine/app-test.json; it seems to work well. Thank you!

@tanin47 we have removed the com.google.cloud.runtimes.logging.JsonFormatter class.    Are you using this class directly?
Note that it has already been removed and this issue should have been closed. Will leave open until we determine if you are using it or not.

Ok, I've got it now. And, no, I am not using that class. I'm using net.logstash.logback.encoder.LogstashEncoder. We are good. Thank you.

@tanin47 Can you share your logging configuration for the benefit of others who might want to use it?

Definitely! Here's is my logback.xml:
<!-- https://www.playframework.com/documentation/latest/SettingsLogger -->
<configuration>
    <appender name="FILE" class="ch.qos.logback.core.rolling.RollingFileAppender">
        <file>/var/log/app_engine/app-play.json</file>
        <append>true</append>
        <rollingPolicy class="ch.qos.logback.core.rolling.FixedWindowRollingPolicy">
            <fileNamePattern>/var/log/app_engine/rolled-app-play-%i.json</fileNamePattern>
            <minIndex>1</minIndex>
            <maxIndex>10</maxIndex>
        </rollingPolicy>
        <triggeringPolicy class="ch.qos.logback.core.rolling.SizeBasedTriggeringPolicy">
            <maxFileSize>5MB</maxFileSize>
        </triggeringPolicy>
        <encoder class="net.logstash.logback.encoder.LogstashEncoder">
            <includeContext>false</includeContext>
            <fieldNames>
                <thread>[ignore]</thread>
                <levelValue>[ignore]</levelValue>
                <logger>logger</logger>
                <version>[ignore]</version>
            </fieldNames>
        </encoder>
    </appender>

    <logger name="play" level="INFO" />
    <logger name="application" level="DEBUG" />

    <root level="INFO">
        <appender-ref ref="FILE" />
    </root>
    <shutdownHook/>
</configuration>

Please note that rolling logs is essential.
And, in build.sbt, we include the below library:
libraryDependencies ++= Seq(
  "net.logstash.logback" % "logstash-logback-encoder" % "4.0",
  "com.typesafe.scala-logging" %% "scala-logging" % "3.1.0"
)

And, in the code, we can write JSON logs with extra fields as shown below:
import net.logstash.logback.marker.Markers._

import com.typesafe.scalalogging.{Logger => ScalaLogger}
import net.logstash.logback.marker.Markers._
import org.slf4j.Marker
import play.api.{Logger => PlayLogger}

import scala.collection.JavaConversions._
import scala.language.implicitConversions

object Logger {
  def getLogger: ScalaLogger = {
    ScalaLogger(PlayLogger(new Throwable().getStackTrace()(2).getClassName.stripSuffix("$")).logger)
  }

  implicit def mapToMapEntriesAppendingMarker[K, V](m: Map[K, V]): Marker = {
    append("extras", m: java.util.Map[K, V])
  }
}

import Logger._

val logger = getLogger
logger.info(Map("some-field" -> "some-value"), "some-message")

@tanin47 This is great! Thanks for sharing!


chore(wallet-sdk): update paperWallet code snippet for wallet-sdk

See ss below for changes

📝 Changed routes:

…ard/wallets/wallet-sdk

(view full size)

Commit e5c41c52ca57814ca524bd9ff17266db60531244 (https://thirdweb-r81qjus6n.thirdweb-preview.com).


locate file yourself error

i get this error on win 11.

Thanks for the note!
Can you describe the steps you took to get here?
I am not a Windows user but this tells me that you have maybe created an Alias and this is looking for its source?

I followed the standard procedure when installing apps on Windows:

Downloaded the file to my desktop.
Executed it.
A shortcut was created on the desktop.
I launched the shortcut.
I encountered an error.

I suspect the shortcut can't locate the necessary file on my computer. Despite searching thoroughly, I couldn’t find "Memex Local Sync Helper.exe" or even just "Helper.exe". The only related file I found was "Uninstall Memex Local Sync Helper.exe".

replicated on w11 pro/admin account.

Sam on my Windows 10 machine, moreoever after manually unpacking installer .exe  and running Memex Local Sync Helper.exe, message says this application is not for my computer. I have standard i7 base pc running windows 10 with admin priv.

same on Windows 10.
https://community.memex.garden/t/memex-local-sync-helper-is-not-found/2216

I wish we could export and import our data without any extra apps.

my issue is resolved after the v0.0.4. if others can confirm too I can close the issue.

I can confirm, it is working now.

resolved


feat: suport annotations in the adapter override spec

Allows support for Annotations in the adapterOverride spec
closes #1394

I didn't see any specific tests for these files (but I'm happy to add them if they are just structured differently).

Hey @knechtionscoding, thanks for the contribution!
You need to update CRDs to make new attributes available in the components' specifications. We have a Python script to propagate these changes automatically, all you have to do is update hack/crd-update/crd-update.py:
diff --git a/hack/crd-update/crd-update.py b/hack/crd-update/crd-update.py
index 6f78d5a4..855dc14b 100755
--- a/hack/crd-update/crd-update.py
+++ b/hack/crd-update/crd-update.py
@@ -17,6 +17,11 @@ try:
           description: Kubernetes object parameters to apply on top of default adapter values.
           type: object
           properties:
+            annotations:
+              description: Adapter annotations.
+              type: object
+              additionalProperties:
+                type: string
             labels:
               description: Adapter labels.
               type: object

then run ./hack/crd-update/update-all-crds.sh and commit all changes after the script finishes its job.
Regarding the tests. There is a totally outdated and inefficient TestAdapterOverrideOptions, and we need to make it relevant someday, meanwhile, the easy path is to add (Pod)Annotation objectOption in deployment_test.go and knservice_test.go to validate its effect on the adapter.

@tzununbekov I think I've got all of that done, let me know if there's anything left!

Yes, perfect! I forgot about the codegen update, so I took care of it to get this PR merged today. Thanks!

Appreciate the help to get it over the finish line @tzununbekov !


Add support for inferring ipython height

Codecov Report

Merging #300 (2ec9dfb) into main (b00c52d) will decrease coverage by 0.14%.
The diff coverage is 37.50%.

:exclamation: Current head 2ec9dfb differs from pull request most recent head 515ee88. Consider uploading reports for the commit 515ee88 to get more accurate results

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   67.48%   67.34%   -0.14%
==========================================
  Files         206      206
  Lines       11657    11632      -25
  Branches     1743     1696      -47
==========================================
- Hits         7867     7834      -33
- Misses       3376     3385       +9
+ Partials      414      413       -1

Flag
Coverage Δ

unittests
67.34% <37.50%> (-0.14%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...interactive/app/src/lib/component/html/__init__.py
83.95% <14.28%> (-3.15%)
:arrow_down:

meerkat/dataframe.py
75.57% <55.55%> (-0.38%)
:arrow_down:

... and 10 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Major Updates to DataIO Class

This PR has significant updates to the DataIO class, as summarized below.
update 1:
I changed the way in which output files are written. Previously, they were written by default. Now, the user has the option to write the output to file, and they must also specify the name of the output. Generally, this is done with the "output_name=my_file" option. This addresses the following open issues:
https://github.com/cositools/cosipy/issues/63
https://github.com/cositools/cosipy/issues/49
update 2:
Chunking of the UnBinnedData.py class. This class reads the photon data from a tra file and writes it to either a fits or h5 file. This will not be need for most users, as they will start with the unbinned fits file. But nevertheless, reading large tra files can be problematic, especially for users with basic laptops. I've added an option to do this in chunks. Specifically, the user can now specify 'event_min' and 'event_max', which are the min and max event numbers that will be read. This allows a user to chunk the raw tra file as needed. Note that the UnBinnedData.py class also has a method for combining multiple fits files: combine_unbinned_data.
update 3:
Connected to the spacecraft file. The dataIO has been getting its pointing information directly from the tra file. I've now given the option to instead get the pointing information from the spacecraftfile class, i.e. based on an input orientation file. This option is available by specifying 'use_ori=True' in read_tra. Note that for now I have left use_ori=False as the default, in which case the pointing information comes directly from the tra simulation file. I've done some testing to verify that the ori file gives the same results, however, I think a bit more testing could be warranted, which is why I've left it as an option for now.
In order to make this work I needed to make a small update to SpaceCraftFile.py: In the parse_from_file method I added 'comments=("#","EN")' in np.loadtxt. This interprets "EN" as a comment, in addition to "#". This is needed b/c most ori files end with "EN".
update 4:
Added units to binned histogram, and also made psichi axis a healpix object. For now I have also left the old method, just in case it's needed for some sanity checks. By default the new method is used, but the old method can be used by specifying psichi_old=True. Again, I will eventually remove this once we now the updated method is working ok. I directly compared the new method to the old method, for both Galactic and local coordinates, and verified that they are identical. This addresses the following open issues:
https://github.com/cositools/cosipy/issues/76
https://github.com/cositools/cosipy/issues/73
update 5:
I updated the dataIO test in cosipy/tests/dataIO. Note: For testing the unbinned updates of this PR one can simply run test_unbinned_data_with_MEGAlib.py.
The following open issues are also taken care of with this PR:
https://github.com/cositools/cosipy/issues/66
https://github.com/cositools/cosipy/issues/90
I still have the following updates to make:
Implement the yaml configurator
Initialize binning with response
Add more unit tests
Change print to logging info
Add kinematic tests to the UnBinnedDataClass (similar to the MEGAlib reader).
These will be done before the release of DC2.
With the above updates, it's a good place to make a PR. Please let me know if there are any questions, issues, etc.

Hi Chris, thanks for the pull request, it looks great! I only have a minor comment regarding the feature:

Specifically, the user can now specify 'event_min' and 'event_max', which are the min and max event numbers that will be read.

This is a good feature to improve the event reading. But when a user gets a tra file, how does the user get the knowledge of the number of events he/she will need? It looks like a similar feature to the time cut, which is more intuitive for the user to make the decision of the events to extract.
Also there might be a confusion raises by the term "event_min",  "event_max" and "min and max event numbers"
Here the "numbers" are actually the number ID you assigned to each event starting from the first event. It could be misunderstood as the total number instead of number ID.
So changing the description and the name of variables might help:
event_min --> min_event_num_id
event_max --> max_event_num_id
min and max event numbers --> min and max event number ID

Hi Yong,
Thank you for your review.
This feature is just a way to allow for the data to be read in chunks, which is only needed to deal with memory issues, depending on the user's system. It is not really a similar feature as the time cut, which is a selection on the data that effects the data analysis.
"The number ID is equivalent to N_events at each iteration in the for loop"
This is not necessarily true. In the simulation file this is true, because the number ID starts at 0 and increases linearly. However, the tra files are usually extracted with mimrec, which applies some cut on the simulated data, so the number IDs do not increase linearly. But anyways, the number IDs don't actually matter here.
"Here the 'numbers' are actually the number ID to each event starting from the first event. It could be misunderstood as the total number instead of number ID."
I think you have this mixed up. The 'numbers' are indeed the total number of events. Again, the whole point here is to read in the data in smaller chunks.
"But when a user gets a tra file, how does the user get the knowledge of the number of events he/she will need?"
In general the user should extract all the events. If they want to make some cuts on the data based on some specified selections, that is done in another function. To choose how many events to read in at once depends on what the user's system can handle, i.e. you only need this if you're trying to convert a large file and don't have enough RAM. In general though, most common users won't use this function, because they will be starting with the data in fits file formate.
I see that my docstring might be a bit confusing. What if I add a note like this:
Note: event_min and event_max correspond to the total number of events in the file, which is not necessarily the same as the event ID number. The purpose of this is to allow the data to be read in chunks, in order to overcome memory limitations, depending on the user's system.

Hi Chris,
Thank you for the explanation! The new docstring makes more sense. Thank you!

Ok, thanks. It's been updated.

@hiyoneda Ok, fixed now.

I've checked the added functions, and it is ready to merge. One thing I noticed is that the pointing value changes a bit when using the orientation file.
Using GalacticScan.inc1.id1.crab2hr.extracted.tra.gz and 20280301_first_2hrs.ori, I checked 'Zpointings (glon,glat)' for the first ten events with/without "use_ori", like
analysis = UnBinnedData(yaml)
analysis.data_file = os.path.join(test_data.path,analysis.data_file)
analysis.ori_file = os.path.join(test_data.path,analysis.ori_file)
analysis.read_tra(event_max = 10)
cosi_dataset = analysis.cosi_dataset
analysis.read_tra(event_max = 10, use_ori = True)
cosi_dataset_use_ori = analysis.cosi_dataset
cosi_dataset['Zpointings (glon,glat)'] - cosi_dataset_use_ori['Zpointings (glon,glat)']

The output of the last line is
array([[0.00041339, 0.00093654],
       [0.00041168, 0.0009327 ],
       [0.00040577, 0.00091946],
       [0.00040558, 0.00091903],
       [0.00040556, 0.00091898],
       [0.00040525, 0.0009183 ],
       [0.00040472, 0.00091711],
       [0.00040274, 0.00091266],
       [0.0004002 , 0.00090697]])

The difference is less than 0.1 degrees, much smaller than the COSI angular resolution, so I consider it does not matter, but want to share it.

Thanks @hirokiyoneda
For future reference, the dataIO is using a linear interpolation between between time stamps in the ori file (which uses a 1s cadence). I'm not sure exactly what MEGAlib is doing, but based on your test, it looks like it's using the same pointing for each event between timestamps. The difference are small, but we should test this further in the future.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-28-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4021

Questions ?
Please refer to the Backport tool documentation


Add incremental backup?

Hi @Unknwon,
I need to backup from gogs to other disks (a networked storage, it's a directory on Linux).
Now gogs backup is a complete compressed document, which requires a lot of storage space, longer backup time.
Can consider adding an incremental backup option and does not compress the backup?

Hi... though this is a reasonable feature request, but I know very little (almost nothing) about how to do incremental backup. I would love to have such feature as well.
In fact, if you don't backup Git repositories (just database and other files), the archive size should be reduced in significant amount. Is that what you're looking for?

I need to back up all the data.

Sorry, my English is not good.
The main reason for using English is that other people are expected to participate in the discussion, but it seems that no one else is interested in the issue right now.
If you are interested in my ideas, we can communicate by email.
My email:  echo 'YW50b25jaGVuQGhvdG1haWwuY29tCg=='|base64 -d

@antonchen You can join Gogs Discord and PM me.


trodes_to_nwb blows up when refNTrodeID is either 0 or -1 or not set

in the trodesconf file, if refNTrodeID is -1 or 0, this line of code blows up
https://github.com/LorenFrankLab/trodes_to_nwb/blob/main/src/trodes_to_nwb/convert_rec_header.py#L211
When refNTrodesId is not set, this line blows up
https://github.com/LorenFrankLab/trodes_to_nwb/blob/main/src/trodes_to_nwb/convert_rec_header.py#L228
because this line is not called
https://github.com/LorenFrankLab/trodes_to_nwb/blob/main/src/trodes_to_nwb/convert_rec_header.py#L210

@samuelbray32 Normally I try to fix bugs myself. However, this bugs requires a discussion of the research-rules to determine how these state should be operated.

Since this sets the reference that will later be used when importing to spyglass, my assumption is that it should be defined at this time and shouldn't be a nullable option.  Can ask at group meeting tomorrow as well and see what people think

@samuelbray32 yes, if you used a reference channel for your recording during data acquisition, you should set it. But it's possible that you didn't set any reference channel, as in our case. So it should be possible to set this to e.g. -1.


Fix the gap between triangle and rectangle

Could you please provide more details on the bug (browser, version, etc) and a working example for this update?


Added Execute Resource

I wanted to be able to just call the mvn, in kind of an execute way, hopefully this is seen as useful enough for inclusion.

Since the CLA hasn't been signed in over 6 month for this PR I'm going to close it out at this point.  If the author would like to sign the CLA feel free to open up the PR again.


ColorFlow problem?

From a Reddit post.....

Hey!
I've been testing LockGlyphX with ColorFlow 3 and found a minor issue - when unlocking, ColorFlow 3 will revert (and post a notification) which LockGlyph doesn't seem to get. Then when the device relocks without music playing, LockGlyph is still colored. Any idea what's wrong?

This should be fixed now


SocketTimeoutException: Read timed out when executing HTTPS requests

From<EMAIL_ADDRESS>on July 31, 2012 09:43:21
Version of google-http-java-client (e.g. 1.5.0-beta)? 1.10.3 Beta Java environment (e.g. Java 6, Android 2.3, App Engine)? Android 4.1 (Google Nexus) Describe the problem. I'm using an HttpTransport got with AndroidHttp.newCompatibleTransport() to perform multiple requests to a server using the HTTPS protocol. Both using WiFi and 3G, I sometimes get this exception when executing a request:
07-31 17:14:40.659: W/System.err(7558): java.net.SocketTimeoutException: Read timed out
07-31 17:14:40.659: W/System.err(7558):     at org.apache.harmony.xnet.provider.jsse.NativeCrypto.SSL_read(Native Method)
07-31 17:14:40.659: W/System.err(7558):     at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl$SSLInputStream.read(OpenSSLSocketImpl.java:675)
07-31 17:14:40.659: W/System.err(7558):     at libcore.io.Streams.readSingleByte(Streams.java:41)
07-31 17:14:40.659: W/System.err(7558):     at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl$SSLInputStream.read(OpenSSLSocketImpl.java:659)
07-31 17:14:40.659: W/System.err(7558):     at libcore.io.Streams.readAsciiLine(Streams.java:201)
07-31 17:14:40.659: W/System.err(7558):     at libcore.net.http.HttpEngine.readResponseHeaders(HttpEngine.java:560)
07-31 17:14:40.659: W/System.err(7558):     at libcore.net.http.HttpEngine.readResponse(HttpEngine.java:813)
07-31 17:14:40.659: W/System.err(7558):     at libcore.net.http.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:274)
07-31 17:14:40.659: W/System.err(7558):     at libcore.net.http.HttpURLConnectionImpl.getResponseCode(HttpURLConnectionImpl.java:486)
07-31 17:14:40.659: W/System.err(7558):     at libcore.net.http.HttpsURLConnectionImpl.getResponseCode(HttpsURLConnectionImpl.java:134)
07-31 17:14:40.659: W/System.err(7558):     at com.google.api.client.http.javanet.NetHttpResponse.(NetHttpResponse.java:37)
07-31 17:14:40.667: W/System.err(7558):     at com.google.api.client.http.javanet.NetHttpRequest.execute(NetHttpRequest.java:91)
07-31 17:14:40.667: W/System.err(7558):     at com.google.api.client.http.HttpRequest.execute(HttpRequest.java:895)
Note that:

Other HTTP requests complete normally in the meantime.
My connection and read timeouts are set respectively to 10 and 20 seconds.

There are other users experiencing this issue with the error reporting library ACRA, which might use google-http-java-client as well. This is the link to the issue: https://code.google.com/p/acra/issues/detail?id=128 How would you expect it to be fixed? No idea, I don't even know if it's a library or system issue.
Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=146

So if we will use google-http-java-client  sameversion as Android 7.1(or above) , in our projects, then we will be free of this bug?

I am seeing something similar, can someone else check the certificates and let me know if those certificates are also issued by Letsencrypt ?

Any fix for this?
I am using Linux 18.0.4 and Java 8. have the same issue, 20 seconds timeout for read a sheet. Seems the way suggested by google is not working:
            public void initialize(HttpRequest httpRequest) throws IOException {
                credential.initialize(httpRequest);
                httpRequest.setConnectTimeout(3 * 60000);  // 3 minutes connect timeout
                httpRequest.setReadTimeout(3 * 60000);  // 3 minutes read timeout
            }

we just started seeing large consistent socket read timeouts with the python client with a timeout of 15s.  Interestingly this was prefixed with rate limiter errors.  I'm wondering if they're banning IPs?


[release-1.11] allow discoveryAddress to be set via proxyConfig for V…

manual cherry-pick of #35290

@stevenctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.11
abf55bebee37f8d765198b89f414a40c32852e1c
link
true
/test lint_istio_release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.11
abf55bebee37f8d765198b89f414a40c32852e1c
link
true
/test lint_istio_release-1.11

gencheck_istio_release-1.11
abf55bebee37f8d765198b89f414a40c32852e1c
link
true
/test gencheck_istio_release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio_release-1.11
abf55bebee37f8d765198b89f414a40c32852e1c
link
true
/test lint_istio_release-1.11

gencheck_istio_release-1.11
abf55bebee37f8d765198b89f414a40c32852e1c
link
true
/test gencheck_istio_release-1.11

unit-tests_istio_release-1.11
abf55bebee37f8d765198b89f414a40c32852e1c
link
true
/test unit-tests_istio_release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio_release-1.11
5516f8552f1f267847d5b52faa780faa185d5608
link
true
/test unit-tests_istio_release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

manual cherry-pick of #35195

Is this PR number correct?

nope, chose wrong thing in the dropdown

updated

@stevenctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-k8s-tests_istio_release-1.11
00b9ff906176081692c98c554c9a9c4c7022d5f9
link
unknown
/test integ-security-k8s-tests_istio_release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-k8s-tests_istio_release-1.11
00b9ff906176081692c98c554c9a9c4c7022d5f9
link
unknown
/test integ-security-k8s-tests_istio_release-1.11

integ-security-multicluster-tests_istio_release-1.11
00b9ff906176081692c98c554c9a9c4c7022d5f9
link
unknown
/test integ-security-multicluster-tests_istio_release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster-tests_istio_release-1.11
00b9ff906176081692c98c554c9a9c4c7022d5f9
link
unknown
/test integ-security-multicluster-tests_istio_release-1.11

integ-security-k8s-tests_istio_release-1.11
00b9ff906176081692c98c554c9a9c4c7022d5f9
link
true
/test integ-security-k8s-tests_istio_release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Update zotero.py

Add alternate URL for Zotero item, also where metadata is defined.

Thanks @stefanku for your PR.


Alluxio fails to sync updated file on S3 when working with Presto

Alluxio Version:
2.0.0
Describe the bug
There is a file on S3 which gets updated daily. This file is queried by Presto. After freeing the file from Alluxio Presto query on this file fails with Not valid Parquet file: alluxio:/Metadata/parquet/app/app.snappy.parquet expected magic number: [80, 65, 82, 49] got: [-45, -111, -10, 121]
After trying to free the file for the second time I'm getting: java.util.concurrent.TimeoutException: Timed out waiting for file to be freed. Another user may be loading it. options: WaitForOptions{interval=1000, timeout=10000}
To Reproduce

Create a file on S3.
Ensure you have a Presto cluster with Alluxio installed having S3 as under storage.
Query the file from Presto for the first time. Make sure it's cached in Alluxio.
Update the file.
Do alluxio fs ls -f <path-to-file>
Do alluxio fs free <path-to-file>
Query the file from Presto for the second time. See the error about invalid Parquet file.
Try to alluxio fs free <path-to-file> for the second time. See java.util.concurrent.TimeoutException: Timed out waiting for file to be freed. Another user may be loading it. options: WaitForOptions{interval=1000, timeout=10000}

Expected behavior
Ideally, Alluxio should automatically drop files from the cache in case the metadata for the files fetched in alluxio fs ls -f for the files are different from the metadata for the files in Alluxio metastore (e.g. if a file size has changed in under storage then after ls Alluxio should drop the file from cache).
In case automatic cache invalidation is hard to implement then at least free operation shouldn't cause the errors described above.
Urgency
This problem prevents us from using Alluxio in production.
Additional context
Add any other context about the problem here.

Using alluxio fs ls -Dalluxio.user.file.metadata.sync.interval=0 <path> has helped. Looks like it causes removal of file from Alluxio cache in case the file metadata has changed.
Thanks

Thanks for the info @thereisnospoon! I believe your workflow would be as follows?

files created in s3 directly (not via alluxio) on a daily basis. this includes new file names and replacing the content of older files? note for the former, ls -f would be sufficient. for the latter ls -Dalluxio.user.file.metadata.sync.interval=0 is needed to refresh metadata in case files were created with the same name
ls -Dalluxio.user.file.metadata.sync.interval=0 -R to refresh alluxio metadata
hive msck repair to discover any new partitions from alluxio?
run queries. also, can you confirm if queries are not run b/w steps 1 and 2? you might see issues for stale files in alluxio (incorrect metadata) before you re-sync in step2


HTML elements follow a logical structure independent of styling and positioning

User Story
AS A marketing agency
I WANT a codebase that follows accessibility standards
SO THAT our own site is optimized for search engines

Acceptance Criteria
Your website must meet accessibility standards. You can achieve this completing the following:

HTML elements follow a logical structure independent of styling and positioning

Closed via https://github.com/lorettarehm/1st_week_challenge/commit/86597a391c5c3881ce213f68193471b77687354a


See the total price of items in the cart

As a User
I need to know the total price of the items in my cart
So that I can decide if I can afford all of the items.
Assumptions:

The single prices of items in the cart is accurate.
The quantity of each item in the shopping cart is less than their inventory

Accpetance Criteria:
When I go to the shopcart page
I can see the total price of the items in my shopcart

Do we support back order?
What happens if one item in the shopping cart is out of stock?


Setup Error for custom-metrics.libsonnet

Discussed in https://github.com/prometheus-operator/kube-prometheus/discussions/1585

Originally posted by jnccneto January 17, 2022
Hello
I have setup the bundle following the repo instructions:
https://github.com/prometheus-operator/kube-prometheus
Standart is ok, and I have CPU/MEMORY POD metrics.
Now I need custom metrics but I get an error when building with jsonet and enabled custom-metrics.libsonnet.
Any ideas on how to fix it?
error output:
RUNTIME ERROR: max stack frames exceeded.
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
...
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/addons/custom-metrics.libsonnet:7:18-54	object
vendor/kube-prometheus/components/prometheus-adapter.libsonnet:141:20-40	object
During manifestation
my jsonet file:
`local kp =
(import 'kube-prometheus/main.libsonnet') +
// Uncomment the following imports to enable its patches
// (import 'kube-prometheus/addons/anti-affinity.libsonnet') +
// (import 'kube-prometheus/addons/managed-cluster.libsonnet') +
(import 'kube-prometheus/addons/node-ports.libsonnet') +
// (import 'kube-prometheus/addons/static-etcd.libsonnet') +
(import 'kube-prometheus/addons/custom-metrics.libsonnet') +
// (import 'kube-prometheus/addons/external-metrics.libsonnet') +
{
values+:: {
common+: {
namespace: 'monitoring',
},
},
};
{ 'setup/0namespace-namespace': kp.kubePrometheus.namespace } +
{
['setup/prometheus-operator-' + name]: kp.prometheusOperator[name]
for name in std.filter((function(name) name != 'serviceMonitor' && name != 'prometheusRule'), std.objectFields(kp.prometheusOperator))
} +
// serviceMonitor and prometheusRule are separated so that they can be created after the CRDs are ready
{ 'prometheus-operator-serviceMonitor': kp.prometheusOperator.serviceMonitor } +
{ 'prometheus-operator-prometheusRule': kp.prometheusOperator.prometheusRule } +
{ 'kube-prometheus-prometheusRule': kp.kubePrometheus.prometheusRule } +
{ ['alertmanager-' + name]: kp.alertmanager[name] for name in std.objectFields(kp.alertmanager) } +
{ ['blackbox-exporter-' + name]: kp.blackboxExporter[name] for name in std.objectFields(kp.blackboxExporter) } +
{ ['grafana-' + name]: kp.grafana[name] for name in std.objectFields(kp.grafana) } +
{ ['kube-state-metrics-' + name]: kp.kubeStateMetrics[name] for name in std.objectFields(kp.kubeStateMetrics) } +
{ ['kubernetes-' + name]: kp.kubernetesControlPlane[name] for name in std.objectFields(kp.kubernetesControlPlane) }
{ ['node-exporter-' + name]: kp.nodeExporter[name] for name in std.objectFields(kp.nodeExporter) } +
{ ['prometheus-' + name]: kp.prometheus[name] for name in std.objectFields(kp.prometheus) } +
{ ['prometheus-adapter-' + name]: kp.prometheusAdapter[name] for name in std.objectFields(kp.prometheusAdapter) }`

I have the same problem!

I ended up using the Helm chart installation. Works better

I got the same issue (as discussed in #1585 ), and the problem was in the custom-metrics.libsonnet. The offending lines are at
{
  values+:: {
    prometheusAdapter+: {
      namespace: $.values.prometheusAdapter.namespace,

I think (Not really sure) that this is looping back to including the local variable initialization in example.jsonnet, which then loops back to this and then back to the original file. When I changed that value from $.values.prometheusAdapter.namespace to my namespace, say, monitoring, the build works properly and I was able to get the manifests.
I havent really worked out how to separate out the variables included in the example.jsonnet separately so that this wont loop itself again but thought Id share in case anyone faces this.

Did what @rajasaur proposed and it worked, but the prometheus-adapter pod keeps restarting...

Still hitting this issue and not sure what the work around is. Not keen on updating the vendored-in code...any ideas?

We're experiencing this issue on the release-0.11 branch (commit e3066575dc8b)


feat: implement PC opcode

Pull Request type

Please check the type of change your PR introduces:

[x] Feature

What is the current behavior?

Resolves: #254 #255
What is the new behavior?

implements PC opcode
kakarot on cairo0 just increments the PC manually, which I don't think will be very useful
i didn't find tests related PC specifically in geth.
evm.codes also dont specify any examples.

Does this introduce a breaking change?

[x] No

only 1 test of this kind is enough

we dramatically miss a way to parametrize the tests, in cairo0 we had tests for PC in range(1, 15)

we dramatically miss a way to parametrize the tests, in cairo0 we had tests for PC in range(1, 15)

Agreed but here the logic is fairly simple and doesn't present any other edge cases than pc > range bound. I wouldn't duplicate test for no reason


Feature request - A notification sent (email, text, whatever) when an ESP Controller is not seen for X amount of time

I recently had a problem with fermenting temps during a power outage on my controller. Thus, the ESP8266 controllers weren't powered up and did not communicate back to the Fermentrack software on the Raspberry Pi.  My beer temps rose in the summer heat.
If the Fermentrack software would have a timer when the controllers were in the state of "Cannot receive LCD text from Controller/Script"  for a certain set number of minutes and then emailed or texted or somehow alerted me that there was a problem, I could have caught it sooner. It would have to be a notification sent much wider than the home network, since being away from home for extended periods of time with no temp control can be catastrophic. But if I'm home, I may just notice it anyway. But either way, should be able to be sent regardless of the destination. Heck, even a recorded message phone call from Fermentrack. Anything.
Thanks.

I like it.  For (reasons John doesn't want to hear anymore) I could use this.

You can write a bash script to parse the end of the device log.  If it stops changing, trigger a push to telegram.  Adding onto that, if the temp is null (temp probe issue) or temp is out of range (fridge open) trigger the alert.


Cannot upload a local file into Colab

Problem:
In the DXC_Industrialized_AI_Starter.ipynb notebook, there are a couple instances where it suggests you can upload a local file to colab. This doesn't work. The error message I get is :
MessageError: TypeError: Cannot read property '_uploadFiles' of undefined

Hi @jonfernandes,
Below are the causes and solutions for this issue.

It sounds like third-party cookies may be disabled in your browser. Please enable third-party cookies in your browser (The setting is under chrome://settings/content/cookies).

A typical cause of the error you observe is using an unsupported browser or a browser extension. Try disabling extensions. Or, if you are using a browser other than Firefox, Safari, or Chrome, try one of these.

Please try to do the above steps.
If you are still facing the issues please let me know.

Hi @jonfernandes ,
I belive that you are able to upload the local file into colab notebook,  so closing this issue. If you are still facing any issue in uploading a local files to colab then please reopen this issue or create a new issue.


chore(main): release 1.1.0

:robot: I have created a release beep boop
1.1.0 (2024-10-06)
🚀 Features

Build and Push GitHub Package (#131) (dbbc4df), closes #132

🧰 Maintenance

Add .dockerignore file (#108) (4f96c7d), closes #114
Add environment variable check script (#126) (2596b6f), closes #125
Create reusable setup-dependencies action (#123) (3ff9743), closes #124
Group GitHub Actions dependencies in Dependabot config (#112) (2cd5914), closes #117
Refactor statistics file handling and improve logging (#121) (c4a3d9e), closes #122
Reorganize and expand Justfile commands (#127) (ad0aa60), closes #128
Standardise environment variable names (#129) (203c593), closes #130
Update GitHub Actions dependencies (#113) (7a51401), closes #118
Update workflows and remove action preview (#109) (db4bf42), closes #115

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.1.0
:sunflower: