Wrong folder "preprocessed" link

Hi!
When update from 18.16.0 to 18.16.1:
...
ln: не удалось создать символьную ссылку '/etc/clickhouse-server/preprocessed': Файл существует
...

I use non-default data path:
# from local.xml in clickhouse-server/config.d
<path replace="replace">/mnt/data/clickhouse/</path>

but,
# ls -la /etc/clickhouse-server | grep preprocessed
lrwxrwxrwx   1 clickhouse       clickhouse          40 дек 19 11:27 preprocessed -> /var/lib/clickhouse/preprocessed_configs

maybe because of this #2443?
Is it possible to add similar for dictionaries?
# from local.xml in clickhouse-server/config.d
 <dictionaries_config replace="replace">/etc/clickhouse-server/dictionaries/*_dictionary.xml</dictionaries_config>

in this folder i found *_dictionary.xml and *dictionary-preprocessed.xml.
At the same time, dictionaries_<name>_dictionary.xml is present in /mnt/data/clickhouse/preprocessed_configs.
I would like to see only dictionaries in folder from config, without *-preprocessed.xml.
it is possible?
p.s. Sorry, my fault, the preprocessing-link already existed from previous version. But still points to the wrong folder.

/var/lib/clickhouse/preprocessed_configs now contains all preprocessed config including from /dictionaries/ dir.
All '/' in path relative to  etc/clickhouse-server/ changed to '_'  (to avoid too deep tree in preprocessed dir)
Now you can delete all *dictionary-preprocessed.xml in /etc/clickhouse-server/dictionaries/ - they from old versions and not updated now.


Documentation for How to Add Near Interaction to a scene

Overview
Add instructions for how to add near interaction (grab, touch) to a scene, as well as how to add near interaction for UnityUI. Also fix a misnamed file.

Fixes: #5712
Fixes: #4949

Changes

Add page "How to add near interaction" to our docs, and link in the toc.
Rename improperly named file IMixedRealityHandTrackHandler.

/azp run mrtk_docs

/azp run mrtk_docs

/azp run mrtk_docs

Also fixes #4649


CLIENT: Fix Custom Host and Path Issue

Signed-off-by: Noah Kreiger<EMAIL_ADDRESS>Summary
Resolves https://github.com/sigstore/cosign/issues/2669
Allow custom rekor hosts with base paths.
Release Note
Documentation

Fix looks fine, any chance you could write a quick unit test to ensure this doesn't regress?

@bobcallaway Updated! Good call! One of those things that I thought was harder than it was. Thanks!

one minor lint issue in the test case, sorry for the extra round trip.

one minor lint issue in the test case, sorry for the extra round trip.

Yep! Monitoring and adjusted.

Codecov Report

Merging #1306 (f0b986f) into main (d0623e9) will decrease coverage by 20.35%.
The diff coverage is 100.00%.

:exclamation: Current head f0b986f differs from pull request most recent head 8ed4a41. Consider uploading reports for the commit 8ed4a41 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##             main    #1306       +/-   ##
===========================================
- Coverage   63.16%   42.82%   -20.35%
===========================================
  Files          82       74        -8
  Lines        7854     7410      -444
===========================================
- Hits         4961     3173     -1788
- Misses       2262     3907     +1645
+ Partials      631      330      -301

Flag
Coverage Δ

e2etests
?

unittests
42.82% <100.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Maven Azure Functions plugin 1.0.0-beta-5 Endgame

Status
Task
Due

🏃
Publish new plugin & archetype into sonatype staging repo
8/15

[ ]
Verification
TBD

[ ]
Release to Maven Central
TBD

[ ]
Merge develop to master
TBD

[ ]
Add tag and release notes
TBD

[ ]
Update version for next release
TBD

@pragnagopa FYI


Added Skype button

Skype just released a Share button, so I figured I'd add it :)

Heh, sounds good. Thanks


Store Solr 9 configs.

Since Buildkit moved to Solr 9, the configs in site template cause problems. This caused #31 .
I replaced the solr config files with the downloaded export from Drupal. This will work on Buildkit tags that include Solr 9 (main or 3.1.0 or later).

Testing instructions:

Currently in Site Template, running docker compose --profile dev up -d results in screenfulls of red solr errors. Also, once the site is loaded, it complains that the solr server is not available.
 Also when the site is up, you should be able to use solr out of the box.

Tested this PR.
Without this pr, the solr does not get setup/configured properly, and thus Drupal is unable to connect to it.  There were error messages in the solr end (https://solr.islandora.dev).
With this pr, the solr gets setup properly, and Drupal is able to connect it as expected (drupal-4.3.2-solr-9.x-0).  This PR looks good to me.


Replace HybridAuth by SocialConnect/Auth

From HybridAuth README https://github.com/hybridauth/hybridauth :

NOTE: HybridAuth is in maintainance mode. Although pull requests from the community are still accepted, you should find alternatives if you are starting a new project. HA is getting outdated by the day and there are no official plans to work on HybridAuth.

Suggest a new Library SocialConnect/Auth refs https://github.com/socialConnect/auth

ping @ziadoz @josegonzalez


Build error on Cray machines

On a Cray machine, I built OpenBLAS 0.3.3 with
make CC=cc CXX=CC FC=ftn
and finally got an error as follows. I do need static libraries as this is Cray's default.
perl ./gensymbol linktest  x86_64 _ 0 0 0 0 0 0 "" "" 1 > linktest.c
...
/usr/bin/ld: attempted static link of dynamic object `../libopenblas_haswellp-r0.3.4.dev.so'
Makefile:145: recipe for target '../libopenblas_haswellp-r0.3.4.dev.so' failed
make[1]: *** [../libopenblas_haswellp-r0.3.4.dev.so] Error 1
make[1]: Leaving directory '/global/u1/j/jczhang/OpenBLAS/exports'
Makefile:101: recipe for target 'shared' failed
make: *** [shared] Error 2

Don't you have the libopenblas_haswellp-r0.3.4.dev.a ? The make builds will (try to) create both shared and dynamic libraries by default, and the static one is built first. (You can try make NO_SHARED=1 to avoid hitting the error at the end - see Makefile.rule for a description of all options)

A quick search brought up https://github.com/LLNL/GOTCHA/issues/41 with a suggested fix (by setting two environment variables), not sure if it is appropriate for your case though.

Yes, I saw both libopenblas_haswellp-r0.3.4.dev.a and libopenblas_haswellp-r0.3.4.dev.so
I was wondering if the build system can select the right library to link, or ignore the wrong one and proceed, so that when OpenBLAS is included and built by another library, it won't block that library's build.

Sounds like using make NO_SHARED=1 (or in your case make CC=cc CXX=CC FC=ftn NO_SHARED=1) to build only the static OpenBLAS library is the right solution for you then ?

Yes, "make CC=cc CXX=CC FC=ftn NO_SHARED=1" works for me.
I also tried "make CC=cc CXX=CC FC=ftn NO_STATIC=1".  Both the static and dynamic libraries were built and the same link error showed up.
It would be nice if OpenBLAS could auto-detect the build type and do the right linking.


replicate splrep in python

What does this implement/fix?

Implement a clone of splrep (== UnivariateSpline) in python, without FITPACK.
To simplify testing, the result is exposed as scipy.interpolate.make_splrep. A decision to be made at some point is how to actually expose this, given that bit-for-bit compatibility with FITPACK is probably not achievable.
To keep diff sizes manageable, this PR is a part of three-PR sequence:

https://github.com/scipy/scipy/pull/19753 adds linalg primitives (the row-by-row QR factorization of a banded matrix)
https://github.com/scipy/scipy/pull/19873 adds a generator for the knots given data
this PR includes the two, and  adds the computation of spline coefficients. Will rebase if either of the two lands separately.

Additional information

Implementation closely follows that of FITPACK, mainly https://github.com/scipy/scipy/blob/maintenance/1.11.x/scipy/interpolate/fitpack/fpcurf.f and its dependencies.
This all is still WIP, posting early for feedback.

Thanks Tyler, Jake! Indeed, the plan is to move parts of this from python to C. I'm doing it piecemeal over at gh-19753, with an intent to sync this one when ready. How much to move to C is still in a bit of a flux: on one hand it's better to keep in python everything which does not strictly need to be in C; on the other hand it gets a bit messy with a mix of C, python and Cython in between. I'll work on this a bit more I guess, to see how this pans out.
Speaking of reviews --- I'd be much obliged if you could review this one. Please ping me on anything you'd want a non-expert review on!
What would you actually prefer to review --- a three-PR stack or a single one or some other way?

I think this is ready from my side.
Several cleanups are probably needed for the cpp side. At least

how to best document cpp routines; is the current way OK, or do we want to go the full doxygen way (hopefully not),
the current version probably inlines things too aggressively,

That said, I'm going to leave this PR as is, and first take a look at parametric version, splPrep instead.
FITPACK uses two separate routines (https://github.com/scipy/scipy/blob/maintenance/1.11.x/scipy/interpolate/fitpack/fpcurf.f and https://github.com/scipy/scipy/blob/maintenance/1.11.x/scipy/interpolate/fitpack/fppara.f), and I'm wondering how much of the infra could be shared and what really needs to be separate.
So unless there's a review preference, the plan is to defer cleanups to a follow-up, together with the parametric stuff.
Meanwhile this PR can be considered as is, and reviews would be much appreciated.

I'm going to leave this PR as is, and first take a look at parametric version, splPrep instead.

Huh. Implementing splprep turned out to be a great of a dogfooding exercise. The actual change is a dozen of LOC (+ docstrings, tests) after a bit of cleanup of python side internals. So I took an opportunity to do this cleanup and push it here.

Am tentatively marking this with a 1.14.0 milestone. It's definitely not critical for the release, so can be bumped if it gets on the way.
The mdspan discussion is somewhat orthogonal, we can transition to mdspan as a follow-up (or not transition). Ditto for other std:: cleanups (std::lower_bound) suggested by Kai.

@ev-br let me know if you would like me to take another look at this. I'll have time this weekend

Would be great @Kai-Striega !
Also, https://github.com/ev-br/scipy/pull/13 adapts to using mdspan. I checked that the the mods work with both kokkos mdspan and Irwin's version from scipy/special.
The link is a PR to the branch in my scipy fork, so that the diffs with and without mdspan are clearly separate. WDYT?

It's definitely not critical for the release, so can be bumped if it gets in the way.

I'm going to bump it. It would be great if I could be the hero and review everything decisively with a milestone, but not gonna happen on time! Apologies.

Oh the joys of rebasing large PRs after six months.
A large part of CI failures seem to be due to
E   ImportError: /scipy/build-install/lib/python3.10/site-packages/scipy/interpolate/_bspl.cpython-310-i386-linux-gnu.so: undefined symbol: dlartg_

The source of this is me trying to call a LAPAK function from C++. Previously, this was enough:
#include "../_build_utils/src/fortran_defs.h"
#define DLARTG F_FUNC(dlartg, DLARTG)

but not anymore, apparently.  So I suppose https://github.com/scipy/scipy/issues/20002 stops being theoretical.
Locally, I can replicate the failure using python dev.py build --with-scipy-openblas:
In [4]: "dlartg" in dir(_flapack)
Out[4]: True

In [5]: "dlartg_" in dir(_flapack)
Out[5]: False

on ubuntu with gcc/gfortran where the name mangling was lowercase with trailing underscore,  dlartg_.
Whether this is scipy-openblas or dependent on python/C++ toolchain version, I've no idea.

F_FUNC isn't right, that just deals with Fortran compiler mangling and upper-case. It does not deal with symbol prefixes/suffixes. The jobs that are failing mostly use scipy-openblas, and the symbol name there is scipy_dlartg_. I'm out of time for today after gh-21130, but I'll try to work on this dlartg example in the coming days.

Okay, https://github.com/scipy/scipy/pull/19970/commits/63cdbe6038295f064558938c8b79ace1a9bf0336 seems to work locally for python dev.py build --with-scipy-openblas. Let's see if full CI concurs.

@ev-br Is this all we need from FITPACK or there will be more to be translated from it?
I can't make heads or tails with this one in terms of the code so apologies for my ignorance.

There will be more @ilhan :-).

You mean the python translation and its C work routines?

Ah no, I mean the subject matter and the unfortunate Fortran code, FITPACK in general. It looked a bit too cryptic.

Well the subject matter is not that bad after all. It's just an LSQ problem in a specific basis + a greedy like heuristics to select a relevant subspace (iow, at iteration m, add a data point with the maximum residual from iteration m-1) + banded linalg.
2D stuff has several tricks on top, which are still to be deciphered, in a sequel not this PR. Most likely, it's something akin to what people do to minimize the bandwidth/fill-ins in sparse linalg.
Could I tempt you to take a look at the linalg part of what's here now?

2D stuff has several tricks on top, which are still to be deciphered, in a sequel not this PR. Most likely, it's something akin to what people do to minimize the bandwidth/fill-ins in sparse linalg.

OK surprisingly, that is something I know about.

Could I tempt you to take a look at the linalg part of what's here now?

Only if you buy me flowers first 😃  I'll take a look.

Can't promise flowers :-). A beverage of your choice yes certainly, next time we're in the same city :-). Meanwhile, need a hand with LAPACK stuff in the lbfgsb PR?

Meanwhile, need a hand with LAPACK stuff in the lbfgsb PR?

I won't say no to any help with Fortran 😅 Just give me some more time to make it compilable. I decided to make it a PyModule to bypass Cython.

OK, I believe I addressed all review comments so far.
Refactoring the C++ side can be done in a follow-up. Am going to hit the green button next Monday, Sept 9th, unless somebody wants more time to take a look.

Okay, let's land this and improve iteratively. Thanks all for the reviews!


EATL spec bugs from testsuite run

[ ] x-correlator should have a regexp in list-records-of-flow (used as parameter)

[ ] release-number has in EATL and OAM wrong regexp (missing '\' before '.')
This is fixed for EATL openapi.yaml here #231 and for OAMLog here openBackhaul/OamLog#224

Detailed issue for issue#2 could be found here https://github.com/openBackhaul/ExecutionAndTraceLog/issues/218

We have two problems indicated in this issue.
Problem#1 is to include a pattern for the list-record-of-flows.
As per the explanation in https://github.com/openBackhaul/RequestSequenceRepresentation/issues/4#issue-1790853130 , there is no change required in the OAS.
Since for problem#2 we have a separate issue , closing this issue will be fine.
@IswaryaaS , @DanaSunal  please close this issue if it is fine.

@PrathibaJee , thanks for letting us know about how problem#1 has been handled.
Closing the issue as problem#2 shall be handled in https://github.com/openBackhaul/ExecutionAndTraceLog/issues/218


pipeline remove unreasonable CHECK

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Update version to 1.0.3

This PR updates version to 1.0.3 to release a new version.

@Thurman1776-  since readme is already updated and we have a better API, it makes sense to make a new release.
This brings up another question, we would like to update README with every public API change we make, but we might not want to release a new version with every small change. So sometimes README might be inconsistent with the latest release for a while, how can we cope with it.
Would a rule like: "If any change related to public API was made (hence readme updated) a new release must be published" be helpful?

Would a rule like: "If any change related to public API was made (hence readme updated) a new release must be published" be helpful?

I think so, and I think it makes sense. Would you have a case where you've updated the API (and README) but not release it?
I'm not sure exactly how open source projects handle this,  but as far as I know they release & update docs where appropriate at the same time.
If changes are ready for prod then I am not sure why we wouldn't release 🤔

Also, we could've started versioning this as 0.x.x and only bump 0 (major) until we're happy with the results. But yeah, that can be an infinite amount of time 😅

Yeah makes sense, converting version to 0.0.3 now 😄

But also now that I think of it, there is already a version with 1.0.2 on cocoapods. So once we make a release with 0.0.3 and someone tries to install this framework without specifying the version number,  I wonder if they would get the latest release or the version with highest number. I couldn't find something related to this on the internet so far 😅 @Thurman1776-  But going to change version number regardless and we can try it out.

I wonder if they would get the latest release or the version with highest number. I couldn't find something related to this on the internet so far 😅 @Thurman1776- But going to change version number regardless and we can try it out.

I'd assume latest as I would be surprised if it only worked taking the highest number into account. However I'm not a cocoa pods expert, but I think this should be fine.
Whenever we think we have a stable version that's ready for production, then we can bum this to 1.0.3 in case this becomes an issue.

Yeah makes sense, thanks a lot!


No output from wolframscript

Describe the bug
After starting an evaluation with wolframscript everything seems to initialize correctly:
[Mon, 05 Feb 2024 10:29:48 GMT] kernelIsRemote = false, kernelPort = 52906
[Mon, 05 Feb 2024 10:29:48 GMT] kernelInitPath = /Users/jochen/.vscode/extensions/njpipeorgan.wolfram-language-notebook-0.1.0/resources/init-compressed.txt
[Mon, 05 Feb 2024 10:29:48 GMT] kernelRenderInitPath = /Users/jochen/.vscode/extensions/njpipeorgan.wolfram-language-notebook-0.1.0/resources/render-html.wl
[Mon, 05 Feb 2024 10:29:48 GMT] launchCommand = /Applications/Wolfram Engine.app/Contents/Resources/Wolfram Player.app/Contents/MacOS/wolframscript
[Mon, 05 Feb 2024 10:29:48 GMT] launchArguments = -code,ToExpression["zmqPort=52906;"<>Uncompress["1:eJy9PA1X27iy96e4gsMBrkJJ+7bvHSB54fOWu0ApSXfvWdcLJhHEi2OnttNCQ/afvf/2ZvRhS7IdUtpddimJJY1Go9F8yy+u44vu/7n/+MfqurO1de737/xbtrXlrK993Gy+wl/e0GX9LIijvGF1/
[Mon, 05 Feb 2024 10:29:50 GMT] Received the following data from kernel:
[Mon, 05 Feb 2024 10:29:50 GMT] <INITIALIZATION STARTS>
[Mon, 05 Feb 2024 10:29:51 GMT] Received the following data from kernel:
[Mon, 05 Feb 2024 10:29:51 GMT] $CommandLine={/Applications/Wolfram Engine.app/Contents/Resources/Wolfram Player.app/Contents/MacOS/WolframKernel, -runfirst, Unprotect[$EvaluationEnvironment];$EvaluationEnvironment="Script";Protect[$EvaluationEn$ScriptCommandLine={/Applications/Wolfram Engine.app/Contents/Resources/Wolfram Player.app/Contents/MacOS/wolframscript, -code, ToExpression["zmqPort=52906;"<>Uncompress["1:eJy9PA1X27iy96e4gsMBrkJJ+7bvHSB54fOWu0ApSXfvWd
[Mon, 05 Feb 2024 10:29:51 GMT] Received the following data from kernel:
[Mon, 05 Feb 2024 10:29:51 GMT] Using the following command to launch the subkernel process:
[Mon, 05 Feb 2024 10:29:51 GMT] Received the following data from kernel:
[Mon, 05 Feb 2024 10:29:51 GMT] /Applications/Wolfram Engine.app/Contents/Resources/Wolfram Player.app/Contents/MacOS/WolframKernel -noicon -wstp -linkprotocol SharedMemory -linkmode connect -linkname zteqxmg164pmb7av
[Mon, 05 Feb 2024 10:29:53 GMT] Received the following data from kernel:
[Mon, 05 Feb 2024 10:29:53 GMT] Subkernel launched; $preemptive=LinkObject[6phwkmgumlz4r77a, 195, 3], $processID=58499
[Mon, 05 Feb 2024 10:29:54 GMT] Received the following data from kernel:
[Mon, 05 Feb 2024 10:29:54 GMT] [address tcp://<IP_ADDRESS>:52906]

[Mon, 05 Feb 2024 10:29:54 GMT] Received the following data from kernel:
[Mon, 05 Feb 2024 10:29:54 GMT] <INITIALIZATION ENDS>
[Mon, 05 Feb 2024 10:29:54 GMT] Received the following test message from kernel:
[Mon, 05 Feb 2024 10:29:54 GMT] {"type":"test","text":"299870655","version":"13.2.0 for Mac OS X x86 (64-bit) (November 18, 2022)"}

But at this point it gets stuck and the evaluation runs forever without returning a result until I quit the kernel manually.
Expected behavior
Return of the evaluation result.
Screenshots

Environment (please complete the following information):

Operating system: OSX 10.15.7
Mathematica/Engine: 12.0.0 and 13.2.0
VS Code: 1.86.0
Version: 0.1.0 (0.1.1 doesn't work at all)

Additional context

hello, when i lauch wlnb it says "Command 'Wolfram Language Notebook: Create New Wolfram Language Notebook' resulted in an error" and "command 'wolframLanguageNotebook.newNotebook' not found" i wounder if how you fix this problem. thx


404.html still references layout default.html

layout default.html was renamed to base.html, but 404.html still references the old name.

Thank you for bringing this to my attention, @mxkpp :)


React Hook does not update on state update

Hey there,
I have been using zustand.js so far but there is a case where the html does not update when the state changes. My Code:
NotesList.js:
import React, { Component, useState } from 'react';

import {useNotes} from '../store.js';

const NotesList = () => {
    let notes = useNotes(state => state.data.notes);
    let changeCurrentNote = useNotes(state => state.changeCurrentNote);

  //  let uuidNote = useNotes(state => state.data.notes.uuid.title);
    const selectNote = (e) => {
        let note_id = e.target.id.split('-')[1];
        changeCurrentNote(note_id);
    }

    return(

       {
       Object.entries(notes).map((note, key) => { // note[0] = id, note[1].content, note[1].title etc
           return (
{note[1].title}
)
       })
    }

    )
}
export default NotesList

A part of store.js:
const [useNotes] = create((set, get) => ({
    data: {
        notes: {
            uuid: {
                content: "Just a Note.",
                title: "A Note here...",
                tags: ["Abc"]
            },
        }
  }
}
export {useNotes}

However, if I add let uuidNote = useNotes(state => state.data.notes.uuid.title); in the Hook the specific title does update (other titles don't), is there a way to fix that / am I doing someting wrong?
Edit: it works if I use the following save() function (inside create() )`
save: () => {

            let oldState = get().data.notes;

            let currentNote = get().data.currentNote;

            oldState[currentNote.id].title = currentNote.title;
            oldState[currentNote.id].content = currentNote.content;
            oldState[currentNote.id].tags = currentNote.tags;

            set(state => {
                state.data.notes = null // it does not work if I remove this line
            });
            set(state => {
                state.data.notes = oldState
            })
}

Can I see how changeCurrentNote is implemented in state? I guess you are mutating the state.

    changeCurrentNote: (id) => {
        set(state => {
            state.data.currentNote.id = id;
            state.data.currentNote.title = state.data.notes[id].title;
            state.data.currentNote.content = state.data.notes[id].content;
            state.data.currentNote.tags = state.data.notes[id].tags;
        });

Thanks.
    changeCurrentNote: (id) => {
        set(state => ({
            data: {
              ...state.data,
              currentNode: {
                id,
                title: state.data.notes[id].title,
                content: state.data.notes[id].content,
                tags: state.data.notes[id].tags,
              }
           }
        }));

this should fix.
If you prefer mutating syntax, consider using immer.

Thanks, it works if I do it that way.
I had also added
set: fn => set(produce(fn)) to my create((set, get) => {} )  method, however when I call set() inside create() it calls the set method passed  inside create() (which I didn't notice before).
This means it also works also with the following code:
    changeCurrentNote: (id) => {
        get().set((state) => {
            state.data.currentNote.id = id;
            state.data.currentNote.title = state.data.notes[id].title;
            state.data.currentNote.content = state.data.notes[id].content;
            state.data.currentNote.tags = state.data.notes[id].tags;
        });

}

(and obviously also with)
changeCurrentNote: (id) => {
let baseState = get().data;
        const newState = produce(baseState, draft => {
            draft.currentNote.id = id;
            draft.currentNote.title = draft.notes[id].title;
            draft.currentNote.content = draft.notes[id].content;
            draft.currentNote.tags = draft.notes[id].tags;
        })
        set(state => {
            state.data = newState
        });
}

So maybe, it might be a good idea to rename one of these functions (maybe just the immerjs example provided in the docs)?

Glad it worked well.

        set(state => {
            state.data = newState
       });

This is not correct. Please do it like below:
        set({ data: newState })
        set(state => ({ data: newState })) // this works too
        set(state => ({ ...state, data: newState })) // this works too

Otherwise, useStore() with no selector won't work.

maybe just the immerjs example provided in the docs

Do you mean like this?
import produce from 'immer'

const useStore = create(set => ({
  lush: { forrest: { contains: { a: "bear" } } },
  setWithImmer: fn => set(produce(fn)),
}))

const setWithImmer = useStore(state => state.set)
setWithImmer(state => {
  state.lush.forrest.contains = null
})

It looks a bit verbose.
import produce from 'immer'

const useStore = create(origSet => ({
  lush: { forrest: { contains: { a: "bear" } } },
  set: fn => origSet(produce(fn)),
}))

const set = useStore(state => state.set)
set(state => {
  state.lush.forrest.contains = null
})

A little better, but still. I personally don't think it's worth it either way...

okay, thanks


Weight specific dependencies

The dependency field should be weight specific, i.e. each entry in weights should have it as an optional filed. It does not make sense to share the same dependencies for all weights. I think we should do this change very soon as it will also help with setting up the validation in the collection repo.

This is done


Initial plugin design

Idea is to add interactive checkboxes to table displays of integer columns, such that you can check and uncheck them directly on the table view.
This is for people who want a really lightweight data entry system that's just about e.g. marking things as reviewed or not.

For first version I'll look for is_* or should_* columns.
Created a demo database:
echo '[
  {"id": 1, "name": "Task 1", "is_done": 0},
  {"id": 2, "name": "Task 2", "is_done": 1}
]' | sqlite-utils insert todos.db todos --pk id -

Prototype:

Built with the help of Claude, initial prompt:

Write JavaScript to do the following:
Find all  cells that look like this
0
They must have type-int and they should also have a class called col-is_XXX where XXX is a wildcard. And the content of the cell must be 0 or 1.
Replace the content of those cells with a <input type="checkbox"> that is checked for 1 and not checked for 0
Set it up so that any time any of those checkboxes are clicked the following API is called using fetch():
POST <current_page_path>/<row-pks>/-/update
Content-Type: application/json
{
    "update": {
        "is_done": 1 // or 0 if the checkbox was unchecked
    }
}

Construct that  API URL from the current page path and then a comma separated list of row-pks - those can be found by scanning the
 that contains the checkbox looking for all  cells that have a class of type-pk and then taking the text content of those cells.
Catch any fetch() errors and turn those into alert() boxes

Full transcript of conversation: https://gist.github.com/simonw/7fc3a0c5ff2a123ed2b735eeaedd1505

Since this uses the Datasette write API it should only be displayed for users with permission to update that table. I'll implement this with a permission check in a extra_body_script() plugin hook.
https://docs.datasette.io/en/stable/plugin_hooks.html#extra-body-script-template-database-table-columns-view-name-request-datasette

The plugin currently also shows up on the row page - which is good - but doesn't actually work on that page because it doesn't correctly deduce the URL to POST to.

Relevant code: https://github.com/datasette/datasette-checkbox/blob/19b7db5c440ec0aa2518a820a60d5ed3a63e3d45/datasette_checkbox/init.py#L39-L40

JavaScript can differentiate the two pages from  v.s. .

README needs filling out too.


Add missing Ar keys

Thanks for the translation. Fix dark mode? You only committed translation files.

@pxlrbt My bad , there's other PR


Feat(web,web-react,web-twig): Allow multiline message in TextArea #DS-738

Coverage: 96.93%. Remained the same when pulling 7de18c336d347e2abf5259b1ad2cea0100b0ddc3 on feature/textarea-multiline-message into 1ff0b4b37cd2d1db4c1bc8987ecaf9e043111161 on feature/textfield-multiline-message.

@crishpeen Feat(web,web-react,web-twig): Allow multiline message in TextArea #DS-738 I do not think this will work in our changelog generator.

@crishpeen Feat(web,web-react,web-twig): Allow multiline message in TextArea #DS-738 I do not think this will work in our changelog generator.

it does work :)


unable to clone the website

Please let us know what I am missing, why it gives me connection refused?

sudo python WebCloner.py -o /var/www/html/web123 www.web123.com
Failed to connect to Mir: Failed to connect to server socket: No such file or directory
Unable to init server: Could not connect: Connection refused
Failed to connect to Mir: Failed to connect to server socket: No such file or directory
Unable to init server: Could not connect: Connection refused
Start cloning

I have the same problem, running it on Docker linux mint image, any solution?

I have the same problem...

I have the same problem.

I’m the problem. So if I cancel this account what happens?


Integrate nic-emu

i think you need to initialize the eprom for the lib version, but i think you dont: https://github.com/vmuxIO/nic-emu/blob/b16320b436cf49379fdc6f7e915dc33f39793239/src/bin/nic-emu-cli/e1000.rs#L117
at least the kernel driver answers with
e1000 0000:00:06.0 0000:00:06.0 (uninitialized): The EEPROM Checksum Is Not Valid
e1000: Current EEPROM Checksum : 0x0000
e1000: Calculated              : 0xbaba

i think you need to initialize the eprom for the lib version, but i think you dont

Oh right, I forgot about that. I initially omitted it because I wasn't sure what Ethernet address to write in there.
Should we just use the same default address (02:34:56:78:9A:BC) as the cli version or should this setting be configurable by vmux?

I've set it to 02:34:56:78:9A:BC for now

merged as per #94


Use AlertDialog in nestedAction

I have to implement a some custom widget like AlertDialog  to show user that is she/he sure to cancel the order or not.
But the problem is the width and height of the dialog is bounded with SwipeAction -> widthSpace, width and height is bounded by parent height. So can't showDialog and will cause overflow.

AlertDialog is in screen, Why is releated with SwipeActionCell?

I was doing wrong, I tried to show dialog with nestedAction -> content that cause overflow, now I do it with another method.
 onTap: (CompletionHandler handler) async {
            final removeOrder = await confirmToRemove();
            await handler(removeOrder!);
            ...
}

Closing this issue


Refactor multi-env / multiprocessing seeding logic to make it uncorrelated across runs

Resolves issue #129

@vmoens
I made some logic change and most of unit tests pass.
In test_collector unit test, the following two test sets fail.

FAILED test/test_collector.py::test_collector_consistency[conv-3] - AssertionError: key done does not match, got mse = 0.5774   key action does not match, got mse = 0.0000
FAILED test/test_collector.py::test_collector_consistency[vec-3] - AssertionError: key done does not match, got mse = 0.5774    key action does not match, got mse = 0.0000
FAILED test/test_collector.py::test_traj_len_consistency[conv-SyncDataCollector-3] - RuntimeError: The size of tensor a (20) must match the size of tensor b (2) at non-singleton dimension 1
FAILED test/test_collector.py::test_traj_len_consistency[conv-aSyncDataCollector-3] - RuntimeError: At least on process failed. Check for more infos in the log.
FAILED test/test_collector.py::test_traj_len_consistency[vec-SyncDataCollector-3] - RuntimeError: The size of tensor a (20) must match the size of tensor b (2) at non-singleton dimension 1
FAILED test/test_collector.py::test_traj_len_consistency[vec-aSyncDataCollector-3] - RuntimeError: At least on process failed. Check for more infos in the log.

I think it fails because of this line in mock class.
https://github.com/facebookresearch/rl/blob/fc7876666fa0c6733a4b272aa7cfc5b997bc2e04/test/mocking_classes.py#L72
For instance, I change this line to self.count = 100 test passes.
Can you please explain what this line does and suggest best way to update this line?
Thank you,
Hojin


Easier, less cumbersome, login workflow

As done for instance in rchore:
$ gtodo login

Which would print a login URL to visit with a browser.
Currently is cumbersome.

The login subcommand was cumbersome for me as well.
I would like to refer to the implementation of rchore.


Can't call a program log

Describe the bug
An executable called log will not be made available in /run/current-system/sw/bin when put into environment.systemPackages.
Steps To Reproduce
Steps to reproduce the behavior:

Create a file vm.nix with content:
{ pkgs, config, ... }: {
  users.users.me = {
    isNormalUser = true;
    initialPassword = "asdf";
  };
  services.getty.autologinUser = "me";
  environment.systemPackages = with pkgs;
    let
      log = writeShellApplication rec {
        name = "log";
        text = "echo I am named '${name}'";
      };
      logg = writeShellApplication rec {
        name = "logg";
        text = "echo I am named '${name}'";
      };
    in [ log logg ];
  system.stateVersion = "nixos-24.05";
}

run the VM:
rm -f *.qcow* # remove any vm images to prevent weirdness
nix-build '<nixpkgs/nixos>' -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/24.05.tar.gz -I nixos-config=vm.nix -A vm && result/bin/run-nixos-vm`

inside the VM, try to execute the log command

output is log: command not found, but executing logg correctly prints I am named logg.

Expected behavior

log prints I am named log

Screenshots

Additional context
Initial forum post here.
Notify maintainers
@edolstra introduced the commit that causes this issue 18 years ago: https://github.com/NixOS/nixpkgs/commit/153d4e65a1c4ed37877c4db982727d89df15ea82#diff-1967dcc359700a88592924a2e08cc397d4c8ccedec0717a5f96bafc33ece5e53R62
I wonder what the motivation behind this was. To not put log directories containing logfiles into the environment? To prevent files named log from ending up in the environment? What programs produce output files called log?
Metadata

system: "x86_64-linux"
host os: Linux 6.6.57, NixOS, 24.05 (Uakari), 24.05.git.800589017cba
multi-user?: yes
sandbox: yes
version: nix-env (Lix, like Nix) 2.91.0 System type: x86_64-linux Additional system types: aarch64-linux, armv7l-linux, i686-linux Features: gc, signed-caches System configuration file: /etc/nix/nix.conf User configuration files: /home/yann/.config/nix/nix.conf:/etc/xdg/nix/nix.conf:/home/yann/.local/share/flatpak/exports/etc/xdg/nix/nix.conf:/var/lib/flatpak/exports/etc/xdg/nix/nix.conf:/home/yann/.nix-profile/etc/xdg/nix/nix.conf:/nix/profile/etc/xdg/nix/nix.conf:/home/yann/.local/state/nix/profile/etc/xdg/nix/nix.conf:/etc/profiles/per-user/yann/etc/xdg/nix/nix.conf:/nix/var/nix/profiles/default/etc/xdg/nix/nix.conf:/run/current-system/sw/etc/xdg/nix/nix.conf Store directory: /nix/store State directory: /nix/var/nix Data directory: /nix/store/lyh0wy4mxmblg3s2isf180qx3wx64mz1-lix-2.91.0/share
channels(root): "nixos-24.05"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Add a :+1: reaction to issues you find important.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/cant-call-a-program-log/49868/17

I think we should towards a situation where rules are either tested and documented, or removed if they're not needed anymore.
While I haven't done any work on buildEnv, this rule seems like it could perhaps be retired, but please make an effort to ensure that's the case.
Before removing it, make it emit a warning, as it is important context for a possible later collision.


Create ticket on iOS 12.3.1 crash when submit.

Question
Response

Version?
v1.4.1

Devices tested?
iPhone 8

What Currently Happens?

What Do You Expect To Happen?

My Reproduction Steps

XXX
XXX
XXX
XXX

I guess ticket means issue. Then it is the same with #867.
The latest master should have fixed this problem. But we are blocked to release a new iOS release due to @housseindjirdeh is busy.


build: inline external Github Actions to unblock CI

SUMMARY
Apache changed policy on Github Actions because of security risks. Now official apache repos can only run a list of allowed actions.
CI has been blocked by this error:

<EMAIL_ADDRESS>and apache-superset/cached-dependencies@b90713b are not allowed to be used in apache/incubator-superset. Actions in this workflow must be: created by GitHub, verified in the GitHub Marketplace, within a repository owned by apache or match the following: apache/, dawidd6/action-download-artifact@, gradle/wrapper-validation-action, gradle/wrapper-validation-action@, peter-evans/create-pull-request@, scacap/action-surefire-report<EMAIL_ADDRESS>
This PR unblocks CI by

Remove styfle/cancel-workflow-action, which may soon become obsolete if #11944 gets merged
Move all other external dependencies to be within current repo, including:

apache-superset/cached-dependencies or ktmud/cached-dependencies
MorrisonCole/pr-lint-action
unsplash/comment-on-pr
trilom/file-changes-action

These actions were copied over via downloading them as ZIP files directly from GitHub.
All of these actions use the MIT license so I'd assume there is no licensing issue.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
CI should pass
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12241 (598888b) into master (f3ab1f4) will decrease coverage by 2.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12241      +/-   ##
==========================================
- Coverage   66.20%   63.29%   -2.91%
==========================================
  Files         996      485     -511
  Lines       49174    29782   -19392
  Branches     4993        0    -4993
==========================================
- Hits        32554    18851   -13703
+ Misses      16476    10931    -5545
+ Partials      144        0     -144

Flag
Coverage Δ

cypress
?

javascript
?

python
63.29% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 531 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc0de1...598888b. Read the comment docs.

Codecov Report

Merging #12241 (598888b) into master (f3ab1f4) will decrease coverage by 2.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12241      +/-   ##
==========================================
- Coverage   66.20%   63.29%   -2.91%
==========================================
  Files         996      485     -511
  Lines       49174    29782   -19392
  Branches     4993        0    -4993
==========================================
- Hits        32554    18851   -13703
+ Misses      16476    10931    -5545
+ Partials      144        0     -144

Flag
Coverage Δ

cypress
?

javascript
?

python
63.29% <ø> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/databases/commands/create.py
32.65% <0.00%> (-59.19%)
:arrow_down:

superset/sql_validators/postgres.py
50.00% <0.00%> (-50.00%)
:arrow_down:

superset/db_engine_specs/hive.py
54.61% <0.00%> (-29.62%)
:arrow_down:

superset/views/database/mixins.py
59.64% <0.00%> (-22.81%)
:arrow_down:

superset/db_engine_specs/presto.py
70.56% <0.00%> (-12.78%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/databases/dao.py
94.11% <0.00%> (-5.89%)
:arrow_down:

superset/views/database/validators.py
78.94% <0.00%> (-5.27%)
:arrow_down:

... and 531 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc0de1...598888b. Read the comment docs.

I'm going to merge this to unblock the long list of PRs.

I'm going to merge this to unblock the long list of PRs.

massive take on! really appreciate your help! @ktmud 🙏

massive take on! really appreciate your help! @ktmud 🙏


(AzureCXP) Fixing restart command

Fixing restart command per git issue : https://github.com/MicrosoftDocs/azure-docs/issues/36902

@FrankHu-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change. @zhiweiwangmsft

@curtand - can you take a look at these changes? thanks!

#sign-off
The change is simple and accurate.

@curtand: I'm sorry - only the author of this article, @zhiweiwangmsft, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

Hi @FrankHu-MSFT
can you assign this to zhiweiwangmsft?


Error setting up entry to<EMAIL_ADDRESS>for hon

Hi,
When testing your integration I get the following error at the first connection:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 383, in async_setup
result = await component.async_setup_entry(hass, self)
File "/config/custom_components/hon/init.py", line 32, in async_setup_entry
await hon.setup()
File "/usr/local/lib/python3.10/site-packages/pyhon/api.py", line 57, in setup
device = HonDevice(self, appliance)
File "/usr/local/lib/python3.10/site-packages/pyhon/device.py", line 8, in init
appliance["attributes"] = {v["parName"]: v["parValue"] for v in appliance["attributes"]}
KeyError: 'attributes'
Tested on 0.2.1

Hi, thanks for reporting.
Should be fixed in v0.2.2 :slightly_smiling_face:

Hi,
Thank you for the quick action. I now getting the error below. I see it's related to pyHon, I can create a dedicated Issue on the right repo if you want.
I guess it's related to the Virtual Wine Cellar Appliance (see json at the bottom):
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 383, in async_setup
result = await component.async_setup_entry(hass, self)
File "/config/custom_components/hon/init.py", line 32, in async_setup_entry
await hon.setup()
File "/usr/local/lib/python3.10/site-packages/pyhon/api.py", line 58, in setup
await asyncio.gather(*[
File "/usr/local/lib/python3.10/site-packages/pyhon/device.py", line 135, in load_attributes
self._attributes = await self._connector.load_attributes(self)
File "/usr/local/lib/python3.10/site-packages/pyhon/api.py", line 102, in load_attributes
async with self._session.get(url, params=params, headers=await self._headers) as response:
File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 1141, in aenter
self._resp = await self._coro
File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 508, in _request
req = self._request_class(
File "/usr/local/lib/python3.10/site-packages/aiohttp/client_reqrep.py", line 283, in init
url2 = url.with_query(params)
File "/usr/local/lib/python3.10/site-packages/yarl/_url.py", line 977, in with_query
new_query = self._get_str_query(*args, **kwargs)
File "/usr/local/lib/python3.10/site-packages/yarl/_url.py", line 938, in _get_str_query
query = "&".join(self._query_seq_pairs(quoter, query.items()))
File "/usr/local/lib/python3.10/site-packages/yarl/_url.py", line 901, in _query_seq_pairs
yield quoter(key) + "=" + quoter(cls._query_var(val))
File "/usr/local/lib/python3.10/site-packages/yarl/_url.py", line 916, in _query_var
raise TypeError(
TypeError: Invalid variable type: value should be str, int or float, got None of type <class 'NoneType'>
json returned by the Wine Cellar Appliance:
{
'completeMyTasteProfile': 0,
'enrollmentDate': '2022-XX-XXT21: 08: 53.150Z',
'applianceTypeId': 6,
'brand': 'hOn',
'zone': '1',
'series': 'virtualWineCellar',
'applianceCapacity': '41',
'firstEnrollmentTBC': False,
'code': '34004778',
'applianceStatus': 1,
'SK': 'app#xxxxxxxxxxx'',
'PK': 'user#eu-west-1:xxxxxxxxxxxxxxxxxxxxx',
'applianceId': '34004778xxxxxxxx'#2022-08-09T21: 08: 53.150Z',
'id': 403, 'modelName': 'VWC 20',
'applianceTypeName': 'WC',
'connectivity': 'none',
'serialNumber': 'xxxxxxxxxxx',
'sections': {'chatbot': True, 'double_pairing_hidden': False, 'epp_enabled': False},
'topics': {'publish': [], 'subscribe': ['$aws/events/presence/disconnected/34004778xxxxxxxx', '$aws/events/presence/connected/34004778xxxxxxxx', 'haier/things/34004778xxxxxxxx/event/appliancestatus/update', 'haier/things/34004778xxxxxxxx/event/discovery/update'
]}
}


[SCB-1880] Remove the EnableOmega annotation

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

@WillemJiang Travis CI ran fail. But it should not be caused by these changes. Can you rerun it?

Thank you for your contribution!


Fix duplicate "pull request" and "branch" builds on pull requests

@DilumAluthge
I prefer to work on forks and rely on Travis to verify that the changes work.
One of the side-effects of this PR is that Travis no longer works on forks. 😢

Ooof. Let's revert.


[APIView Java] False positive in review

This review shows a difference in this PR. The only difference in that file, however, is a comment change.

@billwert Java API reviews shows documentation though not by default. By design documentation change should not cuase to report API change. I will have a look. https://apiview.dev/Assemblies/Review/552affde3c0f47af9ec9e52ef0761e6f/3355ee49816d4e2abda0f39c03196f81?diffRevisionId=8ca79d144ba24652a65b31c4de55b46f&doc=True&diffOnly=True

Immutable token has some numeric value in definition ID that makes APIView think it is different. We need to check how ID is generated in parser side for annotation token.

@praveenkuttappan The annotation has a different definition ID because I try to create unique definition IDs for each annotation instance. Otherwise, if I have many @Immutable annotation lines, a comment left on one of them would result in the comment appearing under all annotations. You can see the code where I do this here.
I'm not sure how to resolve this - I suspect what I'm doing is what we want to achieve.

@praveenkuttappan Sending this back your way for consideration - thanks.


waterfalls - support barrier status updates to control load to bcfishpass.barriers_falls

Currently, the access model loads four specific falls in HORS to the bcfishpass.barriers_falls table, direct from the FISS falls table https://github.com/smnorris/bcfishpass/blob/main/02_model/sql/barriers_falls.sql
Separately, waterfalls.sql

loads all FISS waterfalls to bcfishpass.waterfalls
loads all CWF additional waterfalls to bcfishpass.waterfalls (note that this data includes some FISS data, I can't remember why they got duplicated or if there were any changes to the FISS info)
break bcfishpass.streams at all the waterfalls in bcfishpass.waterfalls

But nothing is done with bcfishpass.waterfalls.
We'd like to maintain a barrier status for the waterfalls, allowing load of select records into barriers.falls to be used as definite barriers.
To do this (and still support ongoing load of additional features directly from FISS as it gets updated):

add barrier_ind to the CWF compiled falls data https://github.com/smnorris/bcfishpass/blob/main/01_prep/05_other/data/falls.geojson

FISS data is trickier, @NewGraphEnvironment noticed that the fish_obstacle_point_id is not stable, we may not be able to manually flag barriers using this id. Using blue_line_key / downstream_route_measure would work but that is fussier.

Note that in the FPTWG model, barrier status is simply True for FISS falls >= 5m

I can confirm that the file has indeed been unstable. I cross referenced a version downloaded today with an old shapefile version I dug up with a file date_modified tag of 2017-01-31.  I used this script in the test. The results are here.
:eyes:

Interesting that the short name has changed. If the data model changed it might be safe to presume that the new ids are stable enough for now going forward. I'll give it a couple more days to see what Gord W and the Province say but I think we can probably just go ahead with creating a id based lookup and deal with it later if something changes.

Ya. Should be good to go in theory but I’m sure there was an issue with that falls in the Morrissey amd that dataset was less than a year old so it does make sense to follow up  with the province I think. Thanks for doing that.

So to add non-FISS falls so they impact the model results we modify misc_barriers_definite.csv?
For the bcfishpass.waterfalls does it make sense to load it in, make barrier status True for FISS falls >= 5m (I might even suggest 3m as 2m is the highest possible for any species to ascend - if the rock is actually vertical as I believe a "falls" should be). Then, when updating the FISS layer we archive the previous layer and run a quick check to see that the keys are stable.  If there was an issue we could proactively derive the blue_line_key / downstream_route_measure  and rematch?

So to add non-FISS falls so they impact the model results we modify misc_barriers_definite.csv?
Currently yes but I will move things around a bit, it makes sense to have a falls table with the barrier status that feeds directly into bcfishpass.barriers_falls rather than loading into misc/other

make barrier status True for FISS falls >= 5m (I might even suggest 3m as 2m is the highest possible for any species to ascend
Making all FISS falls > 5m a definite barrier is my plan for all watersheds outside CWF target watersheds

Then, when updating the FISS layer we archive the previous layer and run a quick check to see that the keys are stable. If there was an issue we could proactively derive the blue_line_key / downstream_route_measure and rematch?
Yes, that was my thought too although I hadn't thought to add the check, I was just going to wait until it failed 😬

Why not have FISS falls > 5m be definite barriers for the BULK?  CWF is going through them all by hand and adding a flag as a QA and they will be loaded at a later date? If not, for falls such as the one on Richfield, how do I get the falls to impact the symbology on our maps? (That is not really the best example since there is another barrier on Richfield much farther down from that kml from Jonathan than I can add to misc_barriers_definite.csv - but you get the idea...).
Maybe a script to QA the FISS obstacles key check into bcfishpass isn't necessary at this point but might not be a bad idea to keep some sort of archive of the FISS obstacles layer for a little bit in case we see a repeat of what happened with the Morrissey? I now have a version of the layer from January 1, 2021 with a record_last_modified column  (more like date_downloaded in reality it seems) archived on my machine and can leave it there.

Yes, classifying FISS falls >=5m in BULK and elsewhere as barriers and including them in the model makes sense to me.  And I'm pretty sure this is the way we'll go for target watersheds, I opened this issue based on CWF request.
Let me reorganize the falls and the misc/other tables slightly - there will be a mechanism to get the maps the way we want them.
I think the reason falls initially fell out of the barrier mix was because we thought the gradient barriers would catch most of them anyway.
FISS issues will get taken care of in bcfishobs repo, I'll open an issue there for the archive.

Hi guys,
Finally catching up on this. My two cents on some of the points above:

Agreed adding a barrier_ind field for waterfalls is the way to go. I am happy to have FISS falls >= 5m be classified as barriers in the target watersheds.
I would prefer if waterfalls get tracked and loaded through a table separate from misc_barriers_definite.csv. I think there is value in maintaining a separate waterfalls layer and associated fix table moving forward. I have a few falls updates from Steve in the Horsefly.
I'll leave the setup of id lookups/QA checks to both of your expertise on the best way to do so

Pretty much done here: https://github.com/smnorris/bcfishpass/tree/falls/01_prep/05_falls

add any new falls to falls_other.geojson, try and get them close to the correct stream, table has a barrier_ind field
FISS falls default to barrier if >=5m, and barrier status can be controlled by editing this https://github.com/smnorris/bcfishpass/blob/falls/01_prep/05_falls/data/falls_fiss_barrier_ind.csv

I'd consider changing falls_other.geojson to a csv with blue_line_key and measure to standardize with the other files and force the user to do the stream matching manually. Not sure if that would actually help with accuracy.

I find editing falls_other.geojson nice in QGIS but more of a pain overall.  I'll convert to csv with measures to match all the other files.
Because there is no ID in FISS data that we can use to consistently match a falls to a stream, I think we'll have to add any FISS falls of interest that are >200m from a stream to falls_other. There is already one in there. If there are FISS falls that get matched to the wrong stream we can tag them as barrier_ind = False and if needed, add them to the correct stream in falls_other. A messy process but it should work.

Good stuff. Thank you. :tropical_fish:

So... for the falls in the Bulkley that we got from Jonathan, there are a bunch of points that are "suspected" locations (in yellow) of falls or rapids that he has lined up for future confirmation . The confirmed barriers are green.  I can either:

Add a column to the falls_other.csv  such as confirmed and flag it TRUE or NA or
Remove the non-confirmed points.

I think maybe just flagging them is a better plan as the file can be used for follow up in the future.
Also wondering about additional columns for the falls_other.csv.  Should I maybe add a utm_zone, utm_easting, utm_northing to the file so that others can simply input coordinates rather than running fwapg::fwa_indexpoint to get blue_line_key and downstream_route_measure?
I have falls to add so could doll it up then PR today or tomorrow morning.

New field for additional followup fine by me if you want - but there is already barrier_ind - anything that does not have barrier_ind = T is currently ignored anyway
Prefer not to have coordinates in the file unless there is a need. My thinking on this is that it forces the user to think about what stream they actually want the falls to block. Running fwapg::fwa_indexpoint doesn't seem necessary unless you have dozens of falls - getting the blue_line_key by clicking on the stream in QGIS is easy. And measures don't have to be exact, they just have to be on the right side of any tribs or crossings - and that is easy if you use the bcfishpass.streams layer.

ok.  Right,  barrier_ind = T.  Forgot about that one.  That is what I will use for the confirmed and new barriers.  Although, it seems like maybe all the falls are showing on the webmap currently?
All good for the blue_line_key  and downstream_route_measure thing. Makes sense. I didn't realize it was that easy to derive with the point and click. Hadn't looked at it. Easy peasy.

Yep - all waterfalls are currently shown for the planning teams to review.
But only the ones marked as barriers (or over 5m) have any effect.
Web map is still very draft at the moment.


big update -> read description

Documentation updated with informations about the BETA web API, and port-specifying command-line argument added to the program.

can you take a look at this, @davidfegyver?

ooh, fu... I mean, I will review this entire  pull request for myself

:D Sorry I were cycling 😆
The commit is great, thanks for your work again :D


when conditionals

Hey, I'm trying to decipher your when conditionals. They're a little confusing:
- name: Adding user's .ssh directory
  file:
    path: "{{ item.home | default(users_home ~ '/' ~ item.username) }}/.ssh"
    owner: "{{ item.username }}"
    group: "{{ item.group if item.group is defined else (users_group if users_group else item.username) }}"
    state: directory
    mode: '0700'
  **when: item.home_create is not defined or item.home_create**
  with_items: "{{ users }}"

Sorry for the n00b question.

no such thing as dump questions :)
when: item.home_create is not defined or item.home_create means:
When an item doesn't have the home_create attribute defined or if its defined and set to true.
Hope that makes it more clear

Ahh, ic, understood. Thanks!


Fix editing the message

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/18805
PROPOSAL: https://github.com/Expensify/App/issues/18805#issuecomment-1636227437
Tests

[x] Verify that no errors appear in the JS console
Scenario 1:

Open chat as a user A with user B.
write a message and open edit mode on it.
As a user B write couple (or just spam a lot) of messages on the same chat.
The edit box should not be pushed up as new messages are appearing.

Scenario 2:

Open chat and open edit mode on some report.
Lose focus on the edit box and move it somewhere upper on the screen.
Focus the box again, the box should be moved to the bottom of the screen without any troubles.

Offline tests

Bug is only testable on online mode since we are testing behavior when new messages are appearing.
QA Steps

[ ] Verify that no errors appear in the JS console

Scenario 1:

Open chat as a user A with user B.
write a message and open edit mode on it.
As a user B write couple (or just spam a lot) of messages on the same chat.
The edit box should not be pushed up as new messages are appearing.

Scenario 2:

Open chat and open edit mode on some report.
Lose focus on the edit box and move it somewhere upper on the screen.
Focus the box again, the box should be moved to the bottom of the screen without any troubles.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS
https://github.com/Expensify/App/assets/41384305/4845ed06-8815-4348-b235-e4337401fe6f

Android
https://github.com/Expensify/App/assets/41384305/1452cb69-38bc-4092-8d24-77b524ff5ae8

@Santhosh-Sellavel conflicts are resolved

This ran into conflicts again.

@Santhosh-Sellavel looks like there was refactoring meanwhile to functional component, conflicts resolved

@Piotrfj Please add recordings

@Piotrfj Update what test/verify on different platforms.

@Santhosh-Sellavel added examples

Bug: iOS Animation is weird while entering edit mode.
The message being edited is at the top of the screen, animation should be like the edit composer scrolls down to the bottom.
Instead, it appears all of a sudden the view scrolls from the bottom.
https://github.com/Expensify/App/assets/85645967/70d4f3c6-e7cf-4d85-bc5d-43e2e8ebb159

I'm going on OOO for a week if PR is ready for a review. Please request for a new C+ on issue

I can continue review on this one

@Santhosh-Sellavel From what I understand you are complaining about the jumpy behavior of the scroll, that was intendent because animated scroll was causing issues relating with the bug. However, I have checked the scroll animation and after turning it back on nothing seems to break as it used to before, maybe its something related to recent changed in these files.
So after all, my sugestion is to bring them back, and leave the solution with only freezing the scroll during editting.
Video examples:
https://github.com/Expensify/App/assets/41384305/7968c910-ed00-4d62-82e9-a96ea8def7c1

Okay @Piotrfj Please resolve the conflicts, make PR ready for review again lets push this forward, thanks!

Oops conflicts again

@marcochavezf done :')

Oh now lint errors 😌

@marcochavezf done :)

@Piotrfj Still lint failing!

@Piotrfj
Tests fails And Glitch while running test steps on a new thread/chat. Definitely Deploy blockers it could affect new users experience.
https://github.com/Expensify/App/assets/85645967/fdecb117-69c6-4d80-bca0-f70a8cc24c3d

He is on sick leave, he will be back soon

@Santhosh-Sellavel looking at it today

Bump @Piotrfj

Bump @Piotrfj

@Santhosh-Sellavel There is a difference between safari and other environments in behavior I havent discovered before, currently Im working on the solution that would take care of that and will not affect other environments

I remember this affects all Mweb not just Safari, please check again & confirm.

Can resolve conflicts please?

@Santhosh-Sellavel just came back from sick leave, going back to work on the issue, will give some feedback today.

Any update @Piotrfj?

@Santhosh-Sellavel I have put the comment on different task by mistake, first solution was buggy and right now I'm close to complete second solution, but still I'm encountering problems with safari. Will give some more feedback tomorrow as I will discuss this with inner teammates.

@Santhosh-Sellavel After all this battle and consulting I haven't been able to provide well working solution. However we have found that the issue is in progres on react-native-web library. So we are suggesting to put our issue ON HOLD until the problem is resolved at source or merge current solution (only safari is not working) and open new issue just for safari.

@Santhosh-Sellavel https://github.com/necolas/react-native-web/pull/2588 thats the issue I was talking about.

Hey! Please re-assign me when this PR is ready for review :)

It's been a year without activity, I will close it out to remove it from the k2. However, feel free to re-open if there's something we need to look up


Escaping of hash_including goes wrong.

Hey guys, I am currently into testing my application, which is communicating with the OneSignal API. Now I stumbled upon a problem, and I can't seem to find anything on the web related to RoR or even Ruby alone.
I am receiving the following error:
The request POST https://onesignal.com/api/v1/notifications with body hash_including({"contents"=>{"de"=>"BlaBlaBla & BlaBlaBla", "en"=>"BlaBlaBla & BlaBlaBla"}}) was expected to execute 1 time but it executed 0 times

The following requests were made:

POST https://onesignal.com/api/v1/notifications with body '{"app_id":"<APPID_REMOVED>","headings":{"en":"Your dog needs some attention.","de":"Dein Hund braucht Aufmerksamkeit."},"contents":{"en":"BlaBlaBla \u0026 BlaBlaBla","de":"BlaBlaBla \u0026 BlaBlaBla"},"include_player_ids":["test-user-id"]}' with headers <HEADERS_REMOVED> was made 1 time

See the \u0026? Why is it escaping like that? I also tried hard-coding the \0026 manually in the tests, but it also didn't work.
The code I am using for the test:
let(:asserted_configuration) do
  {
    de: I18n.t('workers.send_recurring_notifications.content', locale: :de, titles: 'FooBar & BarFoo'),
    en: I18n.t('workers.send_recurring_notifications.content', locale: :en, titles: 'FooBar & BarFoo')
  }
end

it 'posts the right content to onesignal' do
  mock = stub_request(:post, 'https://onesignal.com/api/v1/notifications')
           .with(body: hash_including({ contents: asserted_configuration }))

  subject.perform(arguments)

  expect(mock).to have_been_requested.times(1)
end

Important to note, that this is happening only on CircleCI! On my mac this is not a problem.

What are the differences between CircleCI env and your local env? Same Ruby?

Sorry for inactivity, was in another project. Yeah, we got the same ruby. Don't know, if there is anything regarding the encoding that ruby offers?

What version of Ruby is that?

It's ruby version: 2.6.3p62
CircleCI configuration is like this (this isn't related to the "ruby" orb, it also happens without it):
version: 2.1
orbs:
  ruby<EMAIL_ADDRESS>
executors:
  docker-executor:
    docker:
      - image: circleci/ruby:2.6.3-stretch-node
        environment:
          COVERAGE: true
          PGHOST: <IP_ADDRESS>
          PGUSER: user
          RAILS_ENV: test
      - image: circleci/postgres:9.5-alpine
        environment:
          POSTGRES_USER: user
          POSTGRES_DB: db
          POSTGRES_PASSWORD: ""

jobs:
  build:
    executor: docker-executor
    steps:
      - checkout
      - ruby/install-deps:
          bundler-version: 2.1.4
      - run:
          name: Database setup
          command: bin/rails db:schema:load --trace
      - ruby/rspec-test

@bblimke Have you looked into this?

@iDuuck no, I haven't. Can you please provide a complete encapsulated test that I can run on my own?

Will do, when I have time! Thanks.


Add new profile for Eva and some other Profile improvements

so I've also cleaned the empty ones and updated the https://github.com/ASKnetCommunity/LEAD/blob/content/profiles.csv
can be merged and released :smile:


0.75 bump

Tested locally before release of 0.75.0

Seems failing due to opentelemetry needing protoc for opentelemetry now...
  Caused by:
    process didn't exit successfully: `/home/runner/work/controller-rs/controller-rs/target/debug/build/opentelemetry-proto-54b408751cf9d2b7/build-script-build` (exit status: 101)
    --- stdout
    cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/common/v1/common.proto
    cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/resource/v1/resource.proto
    cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/trace/v1/trace.proto
    cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/trace/v1/trace_config.proto
    cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/collector/trace/v1/trace_service.proto
    cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/metrics/v1/metrics.proto
    cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/collector/metrics/v1/metrics_service.proto
    cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/logs/v1/logs.proto
    cargo:rerun-if-changed=src/proto/opentelemetry-proto/opentelemetry/proto/collector/logs/v1/logs_service.proto
    cargo:rerun-if-changed=src/proto/opentelemetry-proto

    --- stderr
    thread 'main' panicked at '
    Could not find `protoc` installation and this build crate cannot proceed without
    this knowledge. If `protoc` is installed and this crate had trouble finding
    it, you can set the `PROTOC` environment variable with the specific path to your
    installed `protoc` binary.

will try adding it

nightly works. problem here was that clux/muslrust:stable did not have a build that had propagated the latest protoc inclusion via https://github.com/clux/muslrust/pull/106. triggering it first to avoid pinning a nightly.


Instrument.calc_projections returns error if only calculating resolution at one point

If hkle is only one point then when using .Instrument.calc_projections returns the following error
Traceback (most recent call last):
  File "/usr/local/lib/python3.4/site-packages/neutronpy/resolution.py", line 2455, in plot_projections
    projections = self.projections
AttributeError: 'Instrument' object has no attribute 'projections'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/dfobes/Google Drive/Work/LANL/Presentations/resolution_calc/resolution_tests.py", line 18, in <module>
    instr.plot_projections([1,0,0,0])
  File "/usr/local/lib/python3.4/site-packages/neutronpy/resolution.py", line 2457, in plot_projections
    self.calc_projections(hkle, npts)
  File "/usr/local/lib/python3.4/site-packages/neutronpy/resolution.py", line 1917, in calc_projections
    B = A[:3, :3, ind]
IndexError: too many indices for array

Addressed by 6d864dd2544e0433d9d671789efa8cc8c044d743


Accessibility Updates - Alt Text for images

This is a Feature Request
What would you like to be added
Change alt text tags for images under /case-studies
Why is this needed
All the images under the case-studies page have logo names as alternate text.
Ex: chinaunicom_featured_logo.png
This has to be changed to a readable format. This change is required for better accessibility to images
Comments
We need to change alt text from logo names to link titles.
This is related to Umbrella issue

Valid issue indeed
/kind cleanup
/priority active

/priority backlog

I would like to work on this.

/lifecycle active

/close


Review pubkey architecture

Pubkey module architecture needs to be refactored. Finite fields, Elliptic curves arithmetic and Curves pairings may be transferred to separate modules.

[ ] Review signature schemes concept
[ ] Review secret sharing schemes concept


initialisation for SUSE

I want to fold in the bootstrap from hax-vm so that it sets up my environment for SUSE, similar to Cowboy's ubuntu init
I don't know if Ansible is a solution I want to use, or continue to roll-my-own like with hax-vm

Ansible would be better.  In fact I am thinking very hard about switching tack with the Init step entirely, and there may be other dotfiles schemes that are better for me than Cowboy's as well.
But in the mean-time, this approach at least works now.
commit #efca8e4 resolves


create cname with dns_name elb_loadbalancer value

Hi,
I want to create a elb_loadbalancer resource and after that create a route53 cname resource to this elb.
Is this possible?
Regards,
Victor

@vbarba, can I close this issue? I imagine you've found a solution by now or moved on. If not, though, let me know and I will leave this open.


Reformatted README.md similar to gatsby-starter-default

Hi,
I formatted the README to be similar to gatsby-starter-default after talking to Shannon Soper earlier in September.
When I first used gatsby-starter-blog, I had to do the tutorial and figure out a lot of the structure myself to get things the way I wanted, so she suggested I work on something like this. I would have liked to reformat it/clean it up bit more, but I've been sitting on it for a while without working on it, so I wanted to share my work and see if anyone else would want to continue working on it.

Hey @tyj144
Thank you for opening this. We've moved our official starters over to our monorepo to help ease maintenance (https://github.com/gatsbyjs/gatsby/pull/10310). Closing this since this repo is now a read-only mirror.
Please reopen this PR against the monorepo if you'd like.


Performance

This is a PR to drastically decrease the simulation time of XPalm.
We started with a naive implementation at 176.23 seconds for 916 meteo time-steps, which is very bad.
We are now at 15s with modifications in the dependency package MultiScaleTreeGraph.jl (see this issue: https://github.com/VEZY/MultiScaleTreeGraph.jl/issues/46 and this PR: https://github.com/VEZY/MultiScaleTreeGraph.jl/pull/48).
We may improve a lot still by implementing these modifications:

[x] cache the node traversal, don't forget to add the node to the cache when created
[x] improve the dependency package PlantSimEngine.jl:

[x] use only one time-step (a status?) for the simulation, and extract only the variables that we need at the end of the day ?
[x]  pre-allocate everything we need in the attributes, with eventually different time-steps for the variables the user require, and one time-step for the others, and point to these values in the status (and dynamically for time-steps if several values)
[x] Use pointers for values from other scales

We are now at ~1s for the same simulation. I think we can stop there for now, and merge this branch into main.
Note: we first need to make the models outputs work. The improvements come from changes in PlantSimEngine from v0.8.2 to v0.10.3


Arpeggiator  mode bugs

I've just started playing with your firmware and have found a few bugs.

The rate parameter does not appear to be doing anything unless the keyboard is enabled, the normal rate is determined by the divisor. I'd suggest just keeping the normal divisor.
When pressing page while on a arp track, all buttons light up. On a og track only the valid options light up. (I see this on a stochastic track too)
When selecting a nonstandard option, there are no selectable buttons. they only seem to be selected with the encoder.

it is like that by design
fixed - stochatic page has all keys with functionality
could you please explain with an example?


Datagrid useSelectRows extension crashes in SSR

What package(s) are you using?

[x] Carbon for IBM Products (or Carbon for IBM Cloud & Cognitive)
[ ] Legacy/CDAI
[ ] Legacy/Security

Detailed description

Describe in detail the issue you're having.
When using useSelectedRows in Datagrid, it crashes the app in SSR.

[2024-02-07T12:54:42.329] [FATAL] @console/console-platform-express-setup - window is not defined ReferenceError: window is not defined
    at SelectAll (/Users/flannanl/Git/projects-ui/node_modules/@carbon/ibm-products/lib/components/Datagrid/Datagrid/DatagridSelectAll.js:24:40)
    at processChild (/Users/flannanl/Git/projects-ui/node_modules/react-dom/cjs/react-dom-server.node.development.js:3353:14)
    at resolve (/Users/flannanl/Git/projects-ui/node_modules/react-dom/cjs/react-dom-server.node.development.js:3270:5)
    at ReactDOMServerRenderer.render (/Users/flannanl/Git/projects-ui/node_modules/react-dom/cjs/react-dom-server.node.development.js:3753:22)
    at ReactDOMServerRenderer.read (/Users/flannanl/Git/projects-ui/node_modules/react-dom/cjs/react-dom-server.node.development.js:3690:29)
    at renderToStaticMarkup (/Users/flannanl/Git/projects-ui/node_modules/react-dom/cjs/react-dom-server.node.development.js:4314:27)
    at /Users/flannanl/Git/projects-ui/node_modules/@apollo/client/react/ssr/getDataFromTree.js:21:21
    at new Promise (<anonymous>)
    at process (/Users/flannanl/Git/projects-ui/node_modules/@apollo/client/react/ssr/getDataFromTree.js:19:16)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Steps to reproduce the issue

Render Datagrid with useSelectedRows on server side

We merged a fix for this earlier today actually https://github.com/carbon-design-system/ibm-products/pull/4216

Sure, but I need the fix in v1. Can you port the fix over there?

Hey @flannanl, those same changes have now been applied for v1 and will be included in Tuesday's release.

Verified and working. Thanks.


Enabled CD for plugin-remote-result-trigger

Enabled CD for plugin-remote-result-trigger

Description
https://github.com/jenkinsci/remote-result-trigger-plugin

Submitter checklist for adding or changing permissions

Always

[x] Add link to plugin/component Git repository in description above

When enabling automated releases (cd: true)

[x] Add a link to the pull request, which enables continuous delivery for your plugin or component.
Follow the documentation to ensure, your pull request is set up properly.

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[ ] All newly added users have logged in to Artifactory and Jira at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

https://github.com/jenkinsci/remote-result-trigger-plugin/commit/d50f45d401c11e626fc4e2d49410c6976326df7b


Create liner_regression.py

This program is the implementation of linear regression in Python programming language.

Update the CONTRIBUTING.md
Read the README.md file again.
Update it in this PR only.
No need to create new PR @IshaSah
Update it asap .Will Proceed for further verification.

done the necessary changes.Please verify.
On Sun, Oct 2, 2022 at 12:24 PM Saurabh Kumar @.***>
wrote:

Update the CONTRIBUTING.md
https://github.com/py3-coder/Hacktober_Repo_22/blob/main/CONTRIBUTING.md
Read the README.md file again.
Update it in this PR only.
No need to create new PR @IshaSah https://github.com/IshaSah
Update it asap .Will Proceed for further verification.
—
Reply to this email directly, view it on GitHub
https://github.com/py3-coder/Hacktober_Repo_22/pull/91#issuecomment-1264568211,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOCBCENOCZL2AQIJOOIQA3WBEWTDANCNFSM6AAAAAAQ2YPSL4
.
You are receiving this because you were mentioned.Message ID:
@.***>

Verified @IshaSah .
PR accepted @IshaSah
Successfully merged to HacktoberFest_22 repo.
🚀🚀👍

Thanks a lot.
On Tue, 4 Oct 2022, 1:02 pm Saurabh Kumar, @.***> wrote:

Merged #91 https://github.com/py3-coder/Hacktober_Repo_22/pull/91 into
main.
—
Reply to this email directly, view it on GitHub
https://github.com/py3-coder/Hacktober_Repo_22/pull/91#event-7513576243,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOCBCD22ZXDET5N654SDFTWBPMSDANCNFSM6AAAAAAQ2YPSL4
.
You are receiving this because you were mentioned.Message ID:
@.***>


pull request for e2e test at 12/13/2016 15:56:03

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


make html5 behavior of onDropFile same as native

onDropFile is dispatched for each files on native with the full path of the file as a parameter.
But in html5 it is only dispatched once with a FileList as a parameter which is an array.
Also this array doesn't give the full path, it is mandatory to call js.html.URL.createObjectURL(file) to get the full path.
So this commit allows to make the behavior across targets consistent.
Now onDropFile in the html5 target  is dispatched for each files and the full path is passed as a parameter like in the native target.

Any chance the wrapper could be an abstract that implicitly casts to string? This would make it easier to update existing code.

I can try but I'm a noob in abstract.

@player-03
something like that?
https://try.haxe.org/#9299BBA6

Oh I think I got it:
https://try.haxe.org/#47279a34
class Test {
  static function main() {

    var p:ADropFile = new ADropFile({path:"http://", type: "png", name: "plop"});

  	onOldDropFile(p);

    onDropFile(p);

  }

  static function onOldDropFile(p:String){
		trace(p);
  }

  static function onDropFile(p:TDropFile){
    trace(p.path, p.name, p.type);
  }

}

abstract ADropFile(TDropFile) {

  inline public function new(data:TDropFile) {
    this = data;
  }

  @:to
  public function toString() {
    return this.path;
  }

  @:to
  public function toObject():TDropFile {
    return this;
  }
}

typedef TDropFile = {path:String, type:String, name:String};

i've wrote some drag&drop-limesample sometimes ago:
https://github.com/maitag/dragdrop
Can i reduce the html-branched code there now ...
or maybe useful also to put into lime-samples for testing?

Yes, you'd be able to reduce the branching code, but the question is how much. There are actually multiple things that force branching.
First: you're adding a listener in an HTML5 app and overriding a function otherwise. Instead, you could use Window.onDropFile, since it's available on all platforms.
The second is that Window.onDropFile is lying to you. It claims to be an Event<String->Void>, meaning the listener will receive a string. On most targets, this is true, but on HTML5 you get the event.dataTransfer.files array. (Seen here in your code.) A useful array, but it isn't what you were promised, and it isn't consistent. Thus your listener function needs to handle two entirely different data types, depending on platform.
This pull request (as submitted 11 days ago, with no further changes) would address the second issue. Your listener would always receive a string, containing the filename/URL. That's all Lime promises to do: deliver a string and allow you to handle it. We might be able to stop there.
But you would immediately run into a third issue: there's no easy cross-platform way to use the string you were given. Some platforms have access to sys.io.File, but not HTML5. HTML5 has FileReader, but nothing else does. Lime is all about making cross-platform code easier, so this is really ought to be our responsibility.
The abstract we're discussing would do some parsing and provide some convenience functions, but currently does nothing to solve this issue. It's just syntax sugar wrapping the same old filename/URL, and different platforms still require different code to load the file contents. But the abstract does have the ability to store additional data, and we could include an Input object. On HTML5 targets, this Input would wrap a FileReader, and on system targets it'd be a FileInput. Then you could call readString() or readBytes() no matter what platform you're on.

I have three concerns at this point.

If we implement an abstract, it'll break existing code that expects strings. Users will have to update their function to take an ADropFile argument instead of String. (Yes the abstract can automatically convert to string, but only if the compiler knows it's an ADropFile, which requires updating that argument. And the technical details of Lime's events mean there's no getting around it.) This constitutes a breaking change, which means this pull request can't be applied until a new Lime major version comes along.
Input always blocks, while HTML5 code usually loads files asynchronously. HTML5 programmers might feel like this is a step back.
Someone else might have already solved the file loading problem, and if so there's a good chance they did it better. We might be reinventing the wheel here.

I'm leaning towards a different solution. Ditch the abstract entirely (I think I was wrong about it being easier). Instead, provide a cross-platform way to load from URL. Maybe we'd re-implement sys.io.File, or maybe someone else has a library for that purpose and we can just tell people to download it. If they even need it. If they only target HTML5 (or only target native), then they're set.

I have three concerns at this point.

The abstract will break existing code. If your function expects a string, it won't serve as an onDropFile listener. It's an easy update but still makes this a breaking change, which means this pull request would have to wait until a new major version of Lime comes along. (For various reasons, it's impractical to work around this on Lime's end.)
Input always blocks, while HTML5 code usually loads files asynchronously. HTML5 programmers might feel like this is a step back. (It's possible to work around this on Lime's end, but would require effort.)
Someone else might have already solved the file loading problem, and if so there's a good chance they did it better. We might be reinventing the wheel here.

I'm leaning towards a different solution. Don't wrap the string. Don't modify onDropFile. Pass the string, as promised, and provide a cross-platform way to make use of it. Maybe we'd re-implement sys.io.File for HTML5, or maybe we can find an existing library and point users towards that. Users could use our suggestion or something else (such as BitmapData.loadFromFile() if they know for sure it's an image, or FileLoader if they only target HTML5).
This would still technically be a breaking change, but it's fixing an obvious error, so I feel like it gets a pass.

Sorry I'm currently in holyday so I'll answer when I'll be back.

Thx to response... (first i did made that old sample compatible to lime 7.9.0 now! ;)
The thing is also that i am using "whatformat" haxelib there to let only load the file if it have an expected fileformat.
Because file-ending can be not the same as what is into magic header the goal was to stop loading immediately
after reading the file-header-data and that diffs into behavior on html and native targets.

Potential solution: https://github.com/ShaharMS/lime/pull/1

Oh wow, I only just realized my "potential solution" is exactly what you had in the first place. I re-implemented it from scratch, submitted it as my own idea, and didn't notice for months. Oops!
With that in mind, I'm fine with this change as-is. As a breaking change, it'll have to wait for 9.0.0.
And as long as it's a breaking change, I'm almost tempted to write the wrapper we discussed, except that would just break the other targets too. Probably best to limit the damage to the JS target, because that's the only one that's actually incorrect.

Alright, I totally forgot this PR, sorry!
Good if we can make progress on this.
But what about the abstract class?

But what about the abstract class?

I no longer think it's worth breaking all the other targets.

That said, I guess there is a different abstract-based approach that would avoid breaking any target, and thus qualify for 8.1.0.
We'd make an abstract for the function type, not the function argument type. The abstract will wrap type Array<String> -> Void, and will have @:from functions to automatically convert from String -> Void or FileList -> Void.
Or actually, it might be a different abstract per target. On JS targets it would wrap type Array<File> -> Void and on others it would just wrap String -> Void, but either way it would have @:from functions for all the possible listener types.
That said, Lime normally keeps things a lot simpler than this. Currently you can just look at the event, see Event<String -> Void>, and know you need a String -> Void listener. With this abstract, you'd see Event<FileListener> and then have to look up what FileListener even is. Sure documentation will help, but then you're left wondering if it's up to date and what the edge cases are, because this is still an unfamiliar implementation. Event<String -> Void> has none of these questions; it simply is what it says. (Except, currently, in JS.)


[Copy] Investigate how to optionally connect copy and monitoring

Would be great if copy would connect to the monitoring since it makes entirely sense.
possible copy process data:

Copy process start time
From where to where
Progress
Finish duration

If monitoring is not used, then copy should work without it, thus it is optional and should function without user interference.
We would have to introduce something such as a CopyProcess in protobuf.

The layout for the madmax plotter tracking is already laid in such a way that it allows copy tracking.


Export/Import for migrating to 0.7.0

A migration workflow for changing from storing snapshots in the database to a file based system is required to upgrade pre 0.7.0 systems.

Fixed with PR #25

Fixed with PR #25


[Event Request] Table 5612 "FA depreciation Book" - OnBeforeUpdateBookValue

Hello, we would like to get the following new Event OnBeforeUpdateBookValue in the procedure UpdateBookValue. Thanks!
procedure UpdateBookValue()
    var
        IsHandled: Boolean;
    begin
        IsHandled := false;
        OnBeforeUpdateBookValue(Rec, IsHandled);
        if not IsHandled then
            if "Disposal Date" > 0D then
                "Book Value" := 0;
    end;

[IntegrationEvent(false, false)]
    local procedure OnBeforeUpdateBookValue(var FADepreciationBook: Record "FA Depreciation Book"; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 52878.


Make tests for folders with 500+ files

We need to add tests for large folders: https://github.com/datopian/markdowndb/issues/22
I think we should make a new repository for that

You could just generate your import data for this one test until you find a test case that is more complex.
Just make generator that creates some directories of different levels and different files, assert that that there are actually > 500 created and then run the test.