Custom types are no longer inferred correctly with typescript >= 4.8

Tests are currently failing because custom types are no longer inferred correctly with typescript >= 4.8 if the type is defined like this:
new Command().type("color", new EnumType(["red", "blue"]));

In this example, color will be of type string instead of "red" | "blue".
However, it works if the type is assigned to a variable beforehand.
const colorType = new EnumType(["red", "blue"]);
new Command().type("color", colorType);

In this case, color will be of type "red" | "blue".
This is related to https://github.com/microsoft/TypeScript/issues/50995
Workarounds
Typescript 4.8
In typescript 4.8 as const can be used:
new Command().type("color", new EnumType(["red" as const, "blue" as const]));

Typescript 4.9
In typescript => 4.9 the satisfies operator can be used:
new Command().type("color", new EnumType(["red", "blue"]) satisfies unknown);

I thik we can fix this in typescript 5.0 with the new const type param without adding more complexity to the types: https://devblogs.microsoft.com/typescript/announcing-typescript-5-0-beta/#const-type-parameters


in case of error: repo menu is rendered twice

following code is called twice, in TRY and CATCH,
ro_html->add( render_repo_menu( ) ).

guess it is solved


Support for triggers

Skeema does not yet support triggers. This issue tracks the feature request, which has been split out from #41.
July 2021 update: triggers are fully supported in the new Premium edition of the Skeema CLI!

Would love to see this support

Thanks. This will either require a third-party pull request, or a corporation willing to sponsor the development time. Please let me know if interested in either option.

Hi Evan, curious as to your time/effort estimate for dev work on adding trigger support.  Thanks.

I'd put a rough estimate at 5 to 10 days of dev work for triggers.
One point of complexity is that MySQL 5.7+ and MariaDB 10.2+ added support for having multiple triggers per table with the same event and action time. Skeema could fully support this in theory, but it makes the diff logic harder, since it requires generating a FOLLOWS/PRECEDES clause or creating triggers in a specific order. So the estimate will depend on whether that's fully supported yet or not.
If interested in sponsoring the effort, I'm happy to discuss via email - please see https://www.indexhint.com/ for email address. Thanks!

I'm happy to announce that the Premium edition of the Skeema CLI is now available! It has full support for triggers in all supported databases, including the multi-event/action functionality of MySQL 5.7+ and MariaDB 10.2+.
With the Premium CLI, skeema init and skeema pull will place CREATE TRIGGER statements in the same .sql file as the corresponding table. Users can easily add, remove, edit, or re-order trigger definitions, and skeema diff / skeema push will emit the corresponding DDL.
To learn more about the Premium edition CLI, check out the feature comparison chart and launch blog post.


make some things available for all Unixes

@bors r+

:pushpin: Commit f43fecbf4babebb3df88c09e3fd70c3259fc936f has been approved by RalfJung

:hourglass: Testing commit f43fecbf4babebb3df88c09e3fd70c3259fc936f with merge df0f67a967c10b66779c001bbf038166d79246f8...

:broken_heart: Test failed - checks-actions

@bors r+

:pushpin: Commit 5ba2c1e6be8d79837fb439bafe74b9a20500cf22 has been approved by RalfJung

:hourglass: Testing commit 5ba2c1e6be8d79837fb439bafe74b9a20500cf22 with merge 428245072e8bc2266cc4d624c9ae48fc3f3b7075...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 428245072e8bc2266cc4d624c9ae48fc3f3b7075 to master...


WHat happened to Rogue?

Seemingly overnight the repo for rogue got deleted.

The repository has been turned into examples for ogc-engine and ogc-rs:

https://github.com/knarkzel/ogc-engine/tree/master/examples
https://github.com/knarkzel/ogc-rs/tree/master/examples

Was rogue turned into "chase"? Don't have time to test

Rogue was just a project for testing. But chase is the most "feature complete" game thus far.

Thanks for the quick answer!


Alarm with None time attribute returns an error

Following alarm results in an exception:
alarm = Alarm(None, 'sag_DobotAlarm', None, deviceId, text, Alarm.Status.ACTIVE, Alarm.Severity.MAJOR)
File "C:\Users\APES\AppData\Local\Programs\Python\Python310\lib\site-packages\c8y_api\model\alarms.py", line 333, in create
super()._create(Alarm.to_full_json, *alarms)
File "C:\Users\APES\AppData\Local\Programs\Python\Python310\lib\site-packages\c8y_api\model_base.py", line 494, in _create
self.c8y.post(self.resource, json=jsonify_func(o), accept=None)
File "C:\Users\APES\AppData\Local\Programs\Python\Python310\lib\site-packages\c8y_api_base_api.py", line 190, in post
raise ValueError(f"Unable to perform POST request. Status: {r.status_code} Response:\n" + r.text)
ValueError: Unable to perform POST request. Status: 422 Response:
{"error":"undefined/validationError","message":"Following mandatory fields should be included: time","info":"https://www.cumulocity.com/guides/reference-guide/#a-name-error-reporting-a-error-reporting"}
Using now() is working fine:
alarm = Alarm(None, 'sag_DobotAlarm', datetime.now().isoformat(), deviceId, text, Alarm.Status.ACTIVE, Alarm.Severity.MAJOR)

Not an API error, because this is caused by Cumulocity backend. But it would be a nice feature to have without diverting from the API concept.


Print a link to package.json while displaying errors.

publint prints errors in package.json in the format pkg.exports["./path/to/exports"].property has error X. A minor quality of life improvement would be printing the package.json path with line numbers such that you can Ctrl+Click to the error in VS Code and friends.

Good idea. Displaying the line numbers is tricky though since we're parsing the JSON and it doesn't provide the line numbers. We could technically assume that it's properly indented so we can guess the line number, but that feels a bit complex.
In that case, I'm slightly leaning to keeping it simple so the output is cleaner too.

For unique substrings, try https://github.com/Rich-Harris/locate-character. Otherwise just link to the package.json without an exact location.

Yeah I was thinking of just linking the package.json, but in most case you can easily find it yourself as it's in your own project. Trying to prevent printing it for each message/errors too as the path can get noisy.

I think it's better to keep it simple for now. We can revisit again if there's more request for this.


Dmitryv/consistent width depth

Creating compatible width-depth pair.
Use configuration parameter to optimize for width or for depth.
Optimizing for width may increase depth due to qubit reuse creating additional dependencies. Optimizing for width may increase width as qubits are not reused and fresh ones are always allocated. Added test.
Moved depth data to DepthCounterBase and stopped storing it in the qubits as data needs to be saved across release/allocate.
New simulator doesn't support the old way of getting data as multiple metric collectors are now supported each with its own data format. To get compatible pair among other data in the new framework the closest way is
string csvSummary = sim.ToCSV()[MetricsCountersNames.depthCounter];
Alternatively one can use the following to get just width and depth
sim.GetOperationMetric("Width")
sim.GetOperationMetric("Depth")
Depth counter should be enabled and the mode of operation should be set (OptimizeDepth either true or false)

Closing this PR for now, since we pulled the changes to main instead.


Customisation of text for call to action button

I am currently working on saving payment method for customers and hence the built-in call to action text on the button('Pay') isn't very suitable for the use case. Hence, this PR to enable customisation of the call to action button.

Thanks for your work, i think you should have control over the project too

This looks great! Although the payment button seems to require the callToActionText option to be supplied, otherwise it returns "(null)" instead of the default button text. Could you perhaps make this option optional? That way it won't break for people updating from an older version.

@kraffslol Just made a small change to the js code so that it will use the text "Pay" if callToActionText option is not supplied.

I believe the payment button is localised by the phone language by default, so if someone uses another language than English "Pay" may look out of place. How about placing it in an if clause checking if callToActionText is set inside the ios/android code? Like it's done here.

@kraffslol Agree. Updated the code to make it optional in the android and ios code.

Well done! Works great. Thank you so much! 👍


Required field indicators for grouped field labels should be on the group label

Demo: https://jsfiddle.net/3fd9wnkk/1/
The required field indicator (*) seems like it should go on the group label ("Would you like us to import your current settings?") rather than the individual radio button labels.
The markup in the fiddle is pulled from the docs, just added the "required" class to the grouped fields div.

SUI fiddle here: http://jsfiddle.net/am0pgkqp/

Sorry, I forked that the first time, not sure what happened.
Updated - http://jsfiddle.net/pktvcs1c/3/

I guess require fields should be each when :not(.grouped)

That's the solution I came up with too - I wasn't sure if I was missing some other way this was supposed to be set up though.

No, it was just an oversight. I'll fix

Added PR, closing issue


annotat unused vars

What does this PR do?
annotate all unused vars, need to be verified that is need for the API
if not needed replace all _
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?
[x] Did you verify new and existing tests pass locally with your changes?
[x] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?
Make sure you had fun coding 🙃

What is the plan with these TODOs? Fix them one by one?

What is the plan with these TODOs? Fix them one by one?

exactly, this was the identification and now after 1.1 we shall fix them all, eventually write them as issues for new contributions

exactly, this was the identification and now after 1.1 we shall fix them all, eventually write them as issues for new contributions

Sounds good, but not all changes in this PR have their corresponding TODO comment. Might get lost later.
It might be a good idea to have it annotated as TODO(#5017): bla bla bla to have more context

exactly, this was the identification and now after 1.1 we shall fix them all, eventually write them as issues for new contributions

Sounds good, but not all changes in this PR have their corresponding TODO comment. Might get lost later.
It might be a good idea to have it annotated as TODO(#5017): bla bla bla to have more context

yes, agree but atm we do not have created all issue and also not clear how each shall be solved...

yes, agree but atm we do not have created all issue and also not clear how each shall be solved...

I meant referencing this PR, not the number of each issue

@williamFalcon mind review, it just adding todos to feature branch, no master...


Automated cherry pick of #3364: fix: realdelete secgroupcache

Cherry pick of #3364 on release/2.12.
#3364: fix: realdelete secgroupcache

/lgtm

/approve

/approve


readinessProbe fails in cluster-local-gateway when envoy metrics grow much bigger

Bug description
After running 2 or 3 days, readinessProbe check started failing in cluster-local-gateway and istio-ingressgateway pods
2020-08-10T02:40:41.318531Z	info	Envoy proxy is NOT ready: failed to get server info: Get http://<IP_ADDRESS>:15000/stats?usedonly&filter=server.state: net/http: request canceled (Client.Timeout exceeded while awaiting headers)

I logged in cluster-local-gateway pod (kubectl exec) and found the envoy process was running actually, but if I curl http://<IP_ADDRESS>:15000/stats?usedonly&filter=server.state, there returned the result pretty slow which took more than 1 seconds.
If I curl without filter=server.state, there returned around 18700 metrics entries (19M size) like below, but it can be returned within 1 second
reporter=.=source;.;source_workload=.=cluster-local-gateway;.;source_workload_namespace=.=istio-system;.;source_principal=.=unknown;.;source_app=.=cluster-local-gateway;.;source_version=.=unknown;.;source_canonical_service=.=cluster-local-gateway;.;source_canonical_revision=.=latest;.;destination_workload=.=unknown;.;destination_workload_namespace=.=unknown;.;destination_principal=.=unknown;.;destination_app=.=unknown;.;destination_version=.=unknown;.;destination_service=.=application-test-20200806153911-b9h19-1.f9ecfdc4-77f6.svc.cluster.local;.;destination_service_name=.=application-test-20200806153911-b9h19-1.f9ecfdc4-77f6.svc.cluster.local;.;destination_service_namespace=.=unknown;.;destination_canonical_service=.=unknown;.;destination_canonical_revision=.=latest;.;request_protocol=.=http;.;response_code=.=200;.;grpc_response_status=.=;.;response_flags=.=-;.;connection_security_policy=.=unknown;.;_istio_response_bytes: P0(nan,180) P25(nan,182.5) P50(nan,185) P75(nan,187.5) P90(nan,189) P95(nan,189.5) P99(nan,189.9) P99.5(nan,189.95) P99.9(nan,189.99) P100(nan,190)

But from istio code https://github.com/istio/istio/blob/master/pilot/cmd/pilot-agent/status/util/util.go#L25, there hardcoded 1 second as the request timeout. Actually, we don't have too many services running in the cluster, only around 100. The reason of why there are so many metrics is that we run some service performance test more often in this cluster, like creating 1000 services and deleting them later on. Most of metrics returned are the  metrics of services which were already not existed.
I think we didn't see this problem in Istio 1.4.x, because it didn't query filter in 1.4.x, just query the full stats, but since 1.5.x, the code is changed to query with a filter, which consumed longer time. So looked like the filter took much longer time.
Query the full stats without the filter
root@cluster-local-gateway-65bff8bcd9-2btwd:/# time curl "http://<IP_ADDRESS>:15000/stats?usedonly" > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 22.9M    0 22.9M    0     0  74.6M      0 --:--:-- --:--:-- --:--:-- 74.9M

real	0m0.317s
user	0m0.008s
sys	0m0.023s

Query the stats with the filter
root@cluster-local-gateway-65bff8bcd9-2btwd:/# time curl "http://<IP_ADDRESS>:15000/stats?usedonly&filter=server.state" > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    16    0    16    0     0     13      0 --:--:--  0:00:01 --:--:--    13

real	0m1.241s
user	0m0.002s
sys	0m0.010s

I think the solution might be to revert to query the stats without filter if we can't improve the performance of filter from proxy side. Thanks.
[ ] Docs
[ ] Installation
[ ] Networking
[x] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Steps to reproduce the bug
Keep creating/deleting services, you can see the metrics of envoy in cluster-local-gateway and istio-ingressgateway pods will be growing fast, so requesting the metrics will get slower.
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
cluster-local-gateway version:
cluster-local-gateway version:
cluster-local-gateway version:
cluster-local-gateway version:
cluster-local-gateway version:
cluster-local-gateway version:
cluster-local-gateway version:
cluster-local-gateway version:
cluster-local-gateway version:
cluster-local-gateway version:
ingressgateway version: 1.5.4
ingressgateway version: 1.5.4
ingressgateway version: 1.5.4
ingressgateway version: 1.5.4
ingressgateway version: 1.5.4
ingressgateway version: 1.5.4
ingressgateway version: 1.5.4
ingressgateway version: 1.5.4
ingressgateway version: 1.5.4
ingressgateway version: 1.5.4
pilot version: 1.5.4
pilot version: 1.5.4
pilot version: 1.5.4
data plane version: 1.5.4 (20 proxies)

How was Istio installed?
Environment where bug was observed (cloud vendor, OS, etc)
Knative

@mattcui can you get debug level log from the proxy? as well as non-filtered stats. Or an instruction to reproduce will be also appreciated.

@lizan Thanks for your reply, I will try to see if I can get debug log of the proxy. For the step to reproduce, I gave a rough description above:
Steps to reproduce the bug
Keep creating/deleting services, you can see the metrics of envoy in cluster-local-gateway and istio-ingressgateway pods will be growing fast, so requesting the metrics will get slower.

I think you could run a script to create/delete a large number of services (we created knative services as our platform is based on the knative), you could login the local gateway pod and run time curl http://<IP_ADDRESS>:15000/stats?usedonly&filter=server.state, you may see it's getting slower when you create/delete services more and more, and eventually, the local gateway pod will be shown as unready as it can't get the return of metrics querying within 1 second. I think you could reach to it when you create/delete 1500-2000 services.
cluster-local-gateway-9d89bf6b4-5l8kw   0/1     Running   0          2d11h
cluster-local-gateway-9d89bf6b4-6n7c8   0/1     Running   0          2d12h
cluster-local-gateway-9d89bf6b4-9b5c8   0/1     Running   0          2d12h
cluster-local-gateway-9d89bf6b4-9vflt   0/1     Running   2          2d12h
cluster-local-gateway-9d89bf6b4-j6wth   0/1     Running   0          2d10h
cluster-local-gateway-9d89bf6b4-lgnmp   0/1     Running   0          2d12h
cluster-local-gateway-9d89bf6b4-p7gs4   0/1     Running   2          2d12h
cluster-local-gateway-9d89bf6b4-w2j86   0/1     Running   0          2d15h
cluster-local-gateway-9d89bf6b4-zg7tn   0/1     Running   0          2d13h
cluster-local-gateway-9d89bf6b4-zw8jr   0/1     Running   0          2d14h
```

@lizan I had some more findings and update the issue description, I think the key is "filter", for istio 1.4.x, there just query the stats without any filter, it can be returned within one second even though there are a large number of metrics, but since 1.5.x, the proxy-agent changed to query the stats with a filter, which consumed much longer time. So need your advice if we could revert to just query the stats like istio 1.4.x or try to improve the performance of filter from the proxy side. Thanks.

Yeah that might be the case. @mattcui can you share the unfiltered /stats output? I'd like to see what grows the number of stats that big.
cc @ramaraochavali

@lizan , I posted first lines of /stats here,
cluster.xds-grpc.circuit_breakers.default.rq_open: 0
cluster.xds-grpc.circuit_breakers.default.rq_pending_open: 0
cluster.xds-grpc.default.total_match_count: 1030
cluster.xds-grpc.internal.upstream_rq_200: 188
cluster.xds-grpc.internal.upstream_rq_2xx: 188
cluster.xds-grpc.internal.upstream_rq_503: 5
cluster.xds-grpc.internal.upstream_rq_5xx: 5
cluster.xds-grpc.internal.upstream_rq_completed: 193
cluster.xds-grpc.lb_healthy_panic: 1
cluster.xds-grpc.max_host_weight: 1
cluster.xds-grpc.membership_change: 1
cluster.xds-grpc.membership_degraded: 0
cluster.xds-grpc.membership_excluded: 0
cluster.xds-grpc.membership_healthy: 1
cluster.xds-grpc.membership_total: 1
cluster.xds-grpc.update_attempt: 1030
cluster.xds-grpc.update_no_rebuild: 1029
cluster.xds-grpc.update_success: 1030
cluster.xds-grpc.upstream_cx_active: 1
cluster.xds-grpc.upstream_cx_close_notify: 175
cluster.xds-grpc.upstream_cx_connect_fail: 4
cluster.xds-grpc.upstream_cx_destroy: 191
cluster.xds-grpc.upstream_cx_destroy_remote: 191
cluster.xds-grpc.upstream_cx_destroy_remote_with_active_rq: 187
cluster.xds-grpc.upstream_cx_destroy_with_active_rq: 187
cluster.xds-grpc.upstream_cx_http2_total: 192
cluster.xds-grpc.upstream_cx_none_healthy: 1
cluster.xds-grpc.upstream_cx_rx_bytes_buffered: 43
cluster.xds-grpc.upstream_cx_rx_bytes_total:<PHONE_NUMBER>3
cluster.xds-grpc.upstream_cx_total: 192
cluster.xds-grpc.upstream_cx_tx_bytes_buffered: 0
cluster.xds-grpc.upstream_cx_tx_bytes_total:<PHONE_NUMBER>
cluster.xds-grpc.upstream_flow_control_backed_up_total: 8
cluster.xds-grpc.upstream_flow_control_drained_total: 8
cluster.xds-grpc.upstream_rq_200: 188
cluster.xds-grpc.upstream_rq_2xx: 188
cluster.xds-grpc.upstream_rq_503: 5
cluster.xds-grpc.upstream_rq_5xx: 5
cluster.xds-grpc.upstream_rq_active: 1
cluster.xds-grpc.upstream_rq_completed: 193
cluster.xds-grpc.upstream_rq_pending_active: 0
cluster.xds-grpc.upstream_rq_pending_failure_eject: 191
cluster.xds-grpc.upstream_rq_pending_total: 192
cluster.xds-grpc.upstream_rq_total: 188
cluster_manager.active_clusters: 478
cluster_manager.cds.update_attempt: 34889
cluster_manager.cds.update_failure: 191
cluster_manager.cds.update_success: 34697
cluster_manager.cds.version:<PHONE_NUMBER>056690684
cluster_manager.cluster_added: 43043
cluster_manager.cluster_modified: 64731
cluster_manager.cluster_removed: 42565
cluster_manager.cluster_updated: 103163
cluster_manager.warming_clusters: 0
component.proxy.tag.1.5.4;._istio_build: 1
listener_manager.lds.update_attempt: 43746
listener_manager.lds.update_failure: 191
listener_manager.lds.update_success: 43554
listener_manager.lds.version:<PHONE_NUMBER>056690684
listener_manager.listener_added: 2
listener_manager.listener_create_success: 32
listener_manager.total_listeners_active: 2
listener_manager.total_listeners_warming: 0
listener_manager.workers_started: 1
reporter=.=source;.;source_workload=.=cluster-local-gateway;.;source_workload_namespace=.=istio-system;.;source_principal=.=unknown;.;source_app=.=cluster-local-gateway;.;source_version=.=unknown;.;source_canonical_service=.=cluster-local-gateway;.;source_canonical_revision=.=latest;.;destination_workload=.=unknown;.;destination_workload_namespace=.=unknown;.;destination_principal=.=unknown;.;destination_app=.=unknown;.;destination_version=.=unknown;.;destination_service=.=app3598-ajwwh-1.07483e15-ee40.svc.cluster.local;.;destination_service_name=.=app3598-ajwwh-1.07483e15-ee40.svc.cluster.local;.;destination_service_namespace=.=unknown;.;destination_canonical_service=.=unknown;.;destination_canonical_revision=.=latest;.;request_protocol=.=http;.;response_code=.=200;.;grpc_response_status=.=;.;response_flags=.=-;.;connection_security_policy=.=unknown;.;_istio_requests_total: 1
reporter=.=source;.;source_workload=.=cluster-local-gateway;.;source_workload_namespace=.=istio-system;.;source_principal=.=unknown;.;source_app=.=cluster-local-gateway;.;source_version=.=unknown;.;source_canonical_service=.=cluster-local-gateway;.;source_canonical_revision=.=latest;.;destination_workload=.=unknown;.;destination_workload_namespace=.=unknown;.;destination_principal=.=unknown;.;destination_app=.=unknown;.;destination_version=.=unknown;.;destination_service=.=app3598-baicm-1.07483e15-ee40.svc.cluster.local;.;destination_service_name=.=app3598-baicm-1.07483e15-ee40.svc.cluster.local;.;destination_service_namespace=.=unknown;.;destination_canonical_service=.=unknown;.;destination_canonical_revision=.=latest;.;request_protocol=.=http;.;response_code=.=0;.;grpc_response_status=.=;.;response_flags=.=DC;.;connection_security_policy=.=unknown;.;_istio_requests_total: 2
reporter=.=source;.;source_workload=.=cluster-local-gateway;.;source_workload_namespace=.=istio-system;.;source_principal=.=unknown;.;source_app=.=cluster-local-gateway;.;source_version=.=unknown;.;source_canonical_service=.=cluster-local-gateway;.;source_canonical_revision=.=latest;.;destination_workload=.=unknown;.;destination_workload_namespace=.=unknown;.;destination_principal=.=unknown;.;destination_app=.=unknown;.;destination_version=.=unknown;.;destination_service=.=app3598-baicm-1.07483e15-ee40.svc.cluster.local;.;destination_service_name=.=app3598-baicm-1.07483e15-ee40.svc.cluster.local;.;destination_service_namespace=.=unknown;.;destination_canonical_service=.=unknown;.;destination_canonical_revision=.=latest;.;request_protocol=.=http;.;response_code=.=200;.;grpc_response_status=.=;.;response_flags=.=-;.;connection_security_policy=.=unknown;.;_istio_requests_total: 10
reporter=.=source;.;source_workload=.=cluster-local-gateway;.;source_workload_namespace=.=istio-system;.;source_principal=.=unknown;.;source_app=.=cluster-local-gateway;.;source_version=.=unknown;.;source_canonical_service=.=cluster-local-gateway;.;source_canonical_revision=.=latest;.;destination_workload=.=unknown;.;destination_workload_namespace=.=unknown;.;destination_principal=.=unknown;.;destination_app=.=unknown;.;destination_version=.=unknown;.;destination_service=.=app3598-icmra-1.07483e15-ee40.svc.cluster.local;.;destination_service_name=.=app3598-icmra-1.07483e15-ee40.svc.cluster.local;.;destination_service_namespace=.=unknown;.;destination_canonical_service=.=unknown;.;destination_canonical_revision=.=latest;.;request_protocol=.=http;.;response_code=.=200;.;grpc_response_status=.=;.;response_flags=.=-;.;connection_security_policy=.=unknown;.;_istio_requests_total: 14

The remaining around 18000 entries are all like:
reporter=.=source;.;source_workload=.=cluster-local-gateway;.;source_workload_namespace=.=istio-system;.;source_principal=.=unknown;.;source_app=.=cluster-local-gateway;.;source_version=.=unknown;.;source_canonical_service=.=cluster-local-gateway;.;source_canonical_revision=.=latest;.;destination_workload=.=unknown;.;destination_workload_namespace=.=unknown;.;destination_principal=.=unknown;.;destination_app=.=unknown;.;destination_version=.=unknown;.;destination_service=.=coligo-e2e-test-1-knservice-7d2034c2-vljyn-1.476027a1-352e.svc.cluster.local;.;destination_service_name=.=coligo-e2e-test-1-knservice-7d2034c2-vljyn-1.476027a1-352e.svc.cluster.local;.;destination_service_namespace=.=unknown;.;destination_canonical_service=.=unknown;.;destination_canonical_revision=.=latest;.;request_protocol=.=http;.;response_code=.=200;.;grpc_response_status=.=;.;response_flags=.=-;.;connection_security_policy=.=unknown;.;_istio_requests_total: 1

As I mentioned in the issue description, all services including non-existed ones (already deleted) were shown in the stats.

Looks like filter=server.state is slow because it is a doing regex match. I am fine reverting that filter and just have usedonly if that helps.

btw, are you using istio telemetry? @mandarjog are those 18000 stats expected?

@ramaraochavali No, we don't enable istio telemetry.

interesting. Let us wait for @mandarjog  to confirm why they are generated when telemetry is not enabled?

Did you create and destroy these services and send traffic thru them? Is this a knative use case?
We have an outstanding issue in telemetry v2 of metric expiry.
https://github.com/istio/istio/issues/21377
We are targeting istio 1.8 to fix it.

The workaround right now is to limit the maximum lifetime of a gateway. Daily restart or 2 restarts a day would let you work around the problem.

@mandarjog Actually, we didn't explicitly enable telemetry or install telemetry addons, but our monitoring system (like sysdig) should scrape metrics from there. As our platform (based on Knative+istio) targets to run 5000+ services, do you think #21377 could address our requirements to support a large number of services, the proxy-agent could retrieve stats/metrics with filter in one second? Thanks.

@ramaraochavali yeah I expected the regex would be slow but it shouldn't be that slow, can we get a quick fix by escaping the ., or not using the regex filter in 1.6 and 1.7?

@lizan https://github.com/istio/istio/pull/26634 PR to not use regex filter

@lizan @ramaraochavali As we have to stay at istio 1.5.x for maybe 1 or 2 months, possible to also patch this fix in 1.5.x stream? Thanks.

@mattcui can you please check if escaping . is helping in your env?

@ramaraochavali don't see promising decrease
root@cluster-local-gateway-644fd5f945-b7tnm:/# time curl "http://<IP_ADDRESS>:15000/stats?usedonly&filter=^(server.state|listener_manager.workers_started)" > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    52    0    52    0     0     92      0 --:--:-- --:--:-- --:--:--    92

real	0m0.572s
user	0m0.000s
sys	0m0.011s
root@cluster-local-gateway-644fd5f945-b7tnm:/# time curl "http://<IP_ADDRESS>:15000/stats?usedonly&filter=^(server\.state|listener_manager\.workers_started)" > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    52    0    52    0     0    100      0 --:--:-- --:--:-- --:--:--   100

real	0m0.525s
user	0m0.008s
sys	0m0.004s
root@cluster-local-gateway-644fd5f945-b7tnm:/# time curl "http://<IP_ADDRESS>:15000/stats?usedonly&filter=^(server.state|listener_manager.workers_started)" > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    52    0    52    0     0    105      0 --:--:-- --:--:-- --:--:--   105

real	0m0.503s
user	0m0.004s
sys	0m0.007s
root@cluster-local-gateway-644fd5f945-b7tnm:/# time curl "http://<IP_ADDRESS>:15000/stats?usedonly&filter=^(server\.state|listener_manager\.workers_started)" > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    52    0    52    0     0     84      0 --:--:-- --:--:-- --:--:--    84

real	0m0.628s
user	0m0.006s
sys	0m0.005s


[Improvement][dolphinscheduler-tools] use constructor based dependency injection in beans.

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #13219 (c31e2be) into dev (042ec74) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #13219      +/-   ##
============================================
- Coverage     39.38%   39.35%   -0.03%
+ Complexity     4279     4276       -3
============================================
  Files          1067     1067
  Lines         40493    40462      -31
  Branches       4662     4643      -19
============================================
- Hits          15947    15923      -24
+ Misses        22758    22755       -3
+ Partials       1788     1784       -4

Impacted Files
Coverage Δ

...r/plugin/registry/zookeeper/ZookeeperRegistry.java
43.54% <0.00%> (-7.26%)
:arrow_down:

...org/apache/dolphinscheduler/remote/utils/Host.java
42.55% <0.00%> (-2.13%)
:arrow_down:

...hinscheduler/plugin/alert/script/ScriptSender.java
70.58% <0.00%> (-1.64%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
51.38% <0.00%> (-1.39%)
:arrow_down:

...cheduler/plugin/alert/dingtalk/DingTalkSender.java
34.13% <0.00%> (-0.78%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.86% <0.00%> (-0.55%)
:arrow_down:

...inscheduler/plugin/registry/etcd/EtcdRegistry.java
50.69% <0.00%> (-0.35%)
:arrow_down:

.../dolphinscheduler/plugin/task/datax/DataxTask.java
36.62% <0.00%> (-0.26%)
:arrow_down:

.../dolphinscheduler/plugin/task/spark/SparkTask.java
72.56% <0.00%> (-0.25%)
:arrow_down:

...dolphinscheduler/service/storage/impl/S3Utils.java
0.00% <0.00%> (ø)

... and 16 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SbloodyS PTAL thanks


Issue with shared library?

Building the latest development with SHARED=1, I'm getting an error when I try load "library/libmbedtls.so" in Julia. Just wanted to check if this was a known issue or something unique to Julia or my environment:
julia> d=Libdl.dlopen("./libmbedtls.so")
ERROR: could not load library "./libmbedtls.so"
./libmbedtls.so: undefined symbol: mbedtls_x509_crt_profile_default

Ah, I see that I have to open libembedx509.so first.


[libftdi1]Fix libusb-1.0.lib path setting

Related: #8550.
The port libftdi1 install ok on triplet x86-windows, x64-windows.
Target 'Linux' not supported by horde3d currently.
No features need to test.

The library path generated by port libusb is in libftdil1Config.cmake, and there is NO debug and release for its path, so the use of vcpkg_fixup_cmake_targets will change the path of libusb to release version.
Any ideas @vicroms ?

/azp run

/azp run

/azp run

/azp run

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.


werf helm dependency update not using values at WERF_VALUES_1

Before proceeding

[X] I didn't find a similar issue

Version
1.2.248
How to reproduce
gitlab-ci.yaml
gitlab-ci-job:
  stage: deploy
  tags: [k8s-main]
  image: registry.werf.io/werf/werf
  variables:
    WERF_SYNCHRONIZATION: kubernetes://gitlab-ci
    WERF_CONFIG: my-folder/werf.yml
    WERF_VALUES_1: my-folder/my-values-1.yml
    WERF_VALUES_2: my-folder/my-values-2.yml

  script:
    - source "$(werf ci-env gitlab --as-file)"
    - werf version
    - werf helm dependency update ${CI_PROJECT_DIR}/my-helm/.helm
    - cd ${CI_PROJECT_DIR}
    - git config --global user.email<EMAIL_ADDRESS>    - git config --global user.name "GitLab Runner ${CI_RUNNER_ID}"
    - git add --all
    - git commit -m "download chart dependences"
    - werf converge
  environment:
    name: dev

file my-helm/Chart.yaml
apiVersion: v2
name: my-chart-name
type: application
appVersion: 0.0.0
version: "1.0.0"
dependencies:
  - name: postgresql # имя строго как в каталоге производителя чарта
    repository: https://charts.bitnami.com/bitnami
    version: 13.2.0 # chart version!!!  Chart v13.2.0 -> postgres sql 16.0.0
    alias: postgresql-16-0-0
    condition: stend.cluster.infrastructure.postgresql-16-0-0.enabled

file my-folder/my-values-2.yml
stend:
  cluster:
    infrastructure:
      postgresql-16-0-0:
        enabled: false

Result
Result
Running with gitlab-runner 16.1.0 (b72e108d)
  on gitlab-runner-6c8bcb487-ds4xn
Preparing the "kubernetes" executor

Using Kubernetes namespace: gitlab-ci
Using Kubernetes executor with image registry.werf.io/werf/werf ...
Using attach strategy to execute scripts...
Preparing environment
Waiting for pod gitlab-ci/runner-qytay21ha-project-78-concurrent-0gbflr to be running, status is Pending
Running on runner-qytay21ha-project-78-concurrent-0gbflr via gitlab-runner-6c8bcb487-ds4xn...
Getting source from Git repository
Fetching changes with git depth set to XXX
Initialized empty Git repository in /builds/12
Created fresh repository.
Checking out b9d094c4 as detached HEAD ...
Skipping Git submodules setup
Executing "step_script" stage of the job script
$ source "$(werf ci-env gitlab --as-file)"
$ werf version
v1.2.
$ werf helm dependency update ${CI_PROJECT_DIR}/my-helm/.helm
**Getting updates for unmanaged Helm repositories...
...Successfully got an update from the "https://charts.bitnami.com/bitnami" chart repository
Saving 4 charts
Downloading postgresql from repo https://charts.bitnami.com/bitnami
Deleting outdated charts**
....

Expected result
$ werf helm dependency update ${CI_PROJECT_DIR}/my-helm/.helm
NOTHING!!!
because :

stend.cluster.infrastructure.postgresql-16-0-0.enabled: false  in file my-folder/my-values-2.yml
env WERF_VALUES_2=my-folder/my-values-2.yml

Additional information
No response

In original helm dependency update command I do not see support for custom values files, hence why our helm dependency update doesn't support it too.
This command is meant to generate Chart.lock file and it is not supposed to be done partially.


Added cpplint to makefile

the call works but maybe using Stan's make/cpplint would be more consistent long-term.

Looks good. I'll just merge this and cleanup the Makefile separately.


ipmb::join timeout on Mac

The same code works well on Windows.  but on MacOS(Arm64), ipmb::join timeout
What could be the reason of causing ipmb::join timing out?

it is permission issue, after turning off SandBox in entitlement of XCode, the issue has gone


Add exit intent popup to plugin directory

https://app.shortcut.com/larder/story/20851/add-exit-intent-popup-to-plugins-directory


Documentation: Minimum Node.js Version Update

Describe the Bug
Hello,
The documentation for Umami states that the minimum required Node.js version is “>=18.17.” However, the Umami 2.14.0 version does not complete the “yarn install” command because it requires “Node.js >= 18.18.0.”
Database
MySQL
Relevant log output
umami:/opt/umami# yarn install
yarn install v1.22.19
warning ../package.json: No license field
[1/4] Resolving packages...
[2/4] Fetching packages...
warning<EMAIL_ADDRESS>The engine "pnpm" appears to be invalid.
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^18.18.0 || ^20.9.0 || >=21.1.0". Got "18.17.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Which Umami version are you using? (if relevant)
2.14.0
Which browser are you using? (if relevant)
No response
How are you deploying your application? (if relevant)
Self-deploy

Thanks for catching this. All docs in on the website have been updated to reflect this.


Fixes #8600 clean up nodeos options section

no need to add links to each plugin option section because we link to the [Plugins](../03_plugins/index.md) section which is quite elaborated and lists all plugins option pages.

Tiếng trung biết sao đây

Resolves #8600


difficult to map profiles listed in scan results to those in reporting profile list

User Story
When viewing scan results from the reporting nodes list, we identify each profile executed on the node by profile name  :

When viewing the reporting profiles list, we list the profiles by their title :

furthermore, on the profile details list, we see no mention of profile name:

the only place the profile name is mentioned is when viewing scan results or in the second part of the profile identifier on the list view. This can make it hard for users to be certain they are selecting the same profile from page to page.
I would suggest (and I think we spoke about?) :

adding the profile name to the profile details page
adding the profile title to the scan results profiles listing
adding the profile version to the scan results profiles listing

But I'd like to get official input from ux, cc @jonong1972
Definition of Done
Repro Steps:

On the /compliance/reporting/nodes page, click Scan Results on a Node.
The Side Drawer should slide out.

UI Updates:

Add Profile Title
Small text of Profile and Profile Version.  e.g.   profile_name, 0.0.0

Repro Steps:

On the /compliance/reporting/profiles page, click on any profile
View Profile details page.

UI Updates:

Add the Profile name in the top slot.
Additionally to get this panel more inline with the rest of Automate (look at Client Run Nodes), I dropped the icons, but kept the font color, since the Client Run Nodes font color  may not be accessible.

Note: the endpoint we are currently using for the scan results sidebar only gives back the profile sha and name, not the title or version :(


Add 'ProfileSummarizeAction' workflow

This PR implements a feature requested by @svr333. It adds an action that runs on every pushed commit to the master branch, creating and updating a summary of all profiles in the CustomProfiles folder.
The summary is directly accessible via this URL: https://raw.githubusercontent.com/AudioBand/CommunityProfiles/master/ProfilesSummary.json

Thanks a lot :)


Extend the definition of "contributor"

We would like commit authors and people who react to anything in a repo to be included in the definition.
So to that end, we should add two more keys to the returned JSON, commitAuthors and reactors, and extend the logic to populate them.
Edit: PullRequestReviewComment is a distinct entity to PullRequestComment. We should be grabbing those too.

For reactors, do we want to know that Alice reacted to an issue, Bob reacted to 3 issue comments, and Karol reacted to a commit comment? Or do we just care how many times each user reacted as a whole?

Just each time, I think. I don't think they make any difference as performances.


"Sort imports" has no effect

The imports are not sorted in any way.
I'm using the latest version of VSCode and python extensions on Windows 11.
I have tried with two environments, python 3.9.13 and 3.10.6, freshly installed from conda forge.
I have tried Python Refactor: Sort imports from the command palette.
I have tried adding the following settings to settings.json:
    "[python]": {
        "editor.formatOnSave": true,
        "editor.codeActionsOnSave": {
            "source.organizeImports": true
        },
      },
      "isort.args":["--profile", "black"],

(The black formatter works properly.)
I'm not sure what else I can try.

isort does not contribute Python Refactor: Sort Imports. If you have the isort extension then use the Organize Imports command.

Also, if Organize Imports is not working, please share the output from Output > isort panel.

I don't seem to have an Organize Imports command.

When I save a document, which is supposed to trigger Organize Imports, nothing appears in Output > isort.

@s-banach Can you share hat is the version of the python extension, isort extension and vscode you have?
You should be able to see this command, which is exposed by VS Code itself for most languages.

VS Code Version: 1.73.0 (user setup)
ms-python.python: v2022.18.1
ms-python.sort: v2022.4.0

Can you share the logs from both Output>isort and Output > python?

Output > python on open:
LSP Notebooks experiment is enabled
LSP Notebooks interactive window support is enabled
> conda info --json
Python interpreter path: ~\miniforge3\python.exe
> conda run -n base --no-capture-output python ~\.vscode\extensions\ms-python.python-2022.18.1\pythonFiles\get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2022.18.1/pythonFiles/printEnvVariables.py
> ~\miniforge3\python.exe ~\.vscode\extensions\ms-python.python-2022.18.1\pythonFiles\get_output_via_markers.py ~\.vscode\extensions\ms-python.python-2022.18.1\pythonFiles\interpreterInfo.py
Starting Pylance language server.

Output > python on save:
> conda run -n base --no-capture-output python ~\.vscode\extensions\ms-python.python-2022.18.1\pythonFiles\get_output_via_markers.py -m black --diff --quiet ~\Documents\python\plot_results.py
cwd: ~\.vscode\extensions\ms-python.python-2022.18.1\out\client

Output > isort is completely blank.

What is the version of python you have? also, can you Help > toggle developer tools. See if there are any errors reported?

Also, can you check the "runtime status" from the extension view:
Go to extensions view:

Clicking on isort extensions should show the content below:

I'm using python 3.10.6 (which is the base environment for miniconda forge).
The other python extensions show their activation time, but isort just says "Not yet activated":

This is interesting. I'm having the exact same issue, but just on Ubuntu (22.04). On vscode on a Mac (Ventura - 13.0), it works fine. I can see the "Organize Imports" option in the command pallet, and everything works as expected. On Ubuntu 22.04 I'm having the same experience as @s-banach.
Running Python 3.10.6 on both machines.
vscode in Ubuntu:
Version: 1.73.0
Commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f
Date: 2022-11-01T15:44:09.336Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.15.0-52-generic
Sandboxed: No

vscode on the Mac:
Version: 1.73.0
Commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f
Date: 2022-11-01T15:38:50.881Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 22.1.0
Sandboxed: No

@geozeke Sometimes when dependent packages are installed it can get corrupted. This is why i was suggesting, that you try the steps here https://github.com/microsoft/vscode-isort/issues/139#issuecomment-1304634057 specifically with isort. If specifically uninstall and re-install of isort extensions does not work. Then I recommend downgrading the python extension to 2022.16.*.

This is something.
If I downgrade the python extension to 2022.16.*, everything works as expected. I can see the "Organize Imports" menu in the command palette and imports will sort properly. If I then update the python extension to the most current version again, isort no longer works.
Attached is my logfile.
2022-11-07 17_58_04.702 [info] Extension.log

Do you see any errors when you open developer console? (Help > Toggle Developer tools)

Yes. The log is a bit of a mess (pretty extensive), but I attached it. Perhaps it will help. I've been doing some work with jupyter notebooks, so there are few errors from that I can see. The other errors relating to the ms-python extension may be informative.
Developer Console.log

@geozeke Can you share the logs form Output > Python? The logs seem to suggest that the selected interpreter is invalid, the python extension logs might have some clue (in the previous comments it looked like python was selected and running fine). The developer logs seems to suggest otherwise. Can you also try setting isort.logLevel to debug, see if that prints something in Output > isort logs?

Well, it's working now and the python interpreter may have been the problem. Looking at the isort log led me to the answer, thank you for that.
I've got several projects ongoing right now, with several different virtual environments running, so it doesn't surprise me that my developer logs were full of interpreter errors. I'm constantly tearing down and building virtual environments for testing so I get those errors a lot.
When I looked at the isort log, I noticed this:
Name: isort
Module: isort
Python extension loading
Waiting for interpreter from python extension.
Python extension loaded
[ERROR 2022-10-7 20:32:22.857]: Python interpreter missing:
[Option 1] Select python interpreter using the ms-python.python.
[Option 2] Set an interpreter using "isort.interpreter" setting.

I realized that on my Mac the system interpreter was already selected, but for some reason no interpreter was selected on my Ubuntu VM. When I added the path to the interpreter (picture below) everything started working fine. I think what may have slipped by me is the setting above Isort:Interpreter in the picture below. It says, This setting may be ignored if isort.pathis set. I thought using the bundled version of isort defaulted to using the system interpreter. I realize now that message is referring to the Isort:Path setting, not the Isort:Interpreter setting.
No sure why rolling ms-python back to 2022.16.* worked, then rolling it forward again didn't.

I don't remember actually choosing a default interpreter in the Isort:Interpreter settings on the Mac. I just thought it defaulted to /usr/bin/python3 on a Unix-like system.
Happy it's working now though 😄. Thanks for all your help!

I think I understand better what's going on.
If the interpreter path is set in the ms-python.python extension (first picture below) ms-python.isort will pick it up from there. If not, it needs to be set in the ms-python.isort extension. That's why it works on one machine and not another.
If you look carefully at the first picture below, you'll notice that the interpreter path setting is not synced in ms-python.python, but it looks like it is synced in ms-python.isort (second picture from my settings.json file. Maybe that's the reason for the inconsistent (but not incorrect) behavior.

Thanks @geozeke for looking into this.
Closing this issue for now, please try some of the recommendation mentioned here. If nothing works, try setting the "isort.interpreter" setting to a python that 3.7 or greater and it should work.


[HOPS-475] update clusterj to 7.6.6

Make sure there is no duplicate PR for this issue

Please check if the PR fulfills these requirements

[ ] Tests for the changes have been added and passed (for bug fixes / features)
[x] HOPS JIRA issue has been opened for this PR
[x] All commits have been squashed down to a single commit
[x] The commit message has the following format: [HOPS-XXX] message

Post a link to the associated JIRA issue
https://hopshadoop.atlassian.net/browse/HOPS-475

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:
Need hopshadoop/hops-metadata-dal-impl-ndb#141

Jenkins test this please.


Updates to Number Features Script

It looks like the number features tool is trying to use the layer name
within the table of contents as the path name to the underlying feature
class which is not always going to be the same, the script needs to use
the underlying feature class path
changed lines 205 & 206:
desc = arcpy.Describe(pointFeatureName)
overwriteFC = os.path.join(os.path.sep, desc.path, pointFeatureName)

with:
desc = arcpy.Describe(pointFeatures)
if hasattr(desc, "layer"):
  overwriteFC = desc.layer.catalogPath
else:
  overwriteFC = desc.catalogPath

also there was an issue on line 275:
arcpy.SetParameter(3, outputFeatureClass)
the outputFeatureClass has been deleted on line 215 if overwriting an existing feature class:
arcpy.Delete_management(outputFeatureClass)
I have just commented this out for now

If we could take out the overwrite option all together I think that would be best. Overwriting their current dataset could seem harmful to most in my opinion. If this is something that has already been done please disregard my statement.

Ok if it's just to set the output argument when left blank it should be set before the feature class is deleted around line 215

I have tested this using the unit test in place and the tools work correctly.

@adgiles I took the approach of just fixing the issue with the tool not picking up the layers in the ToC. I did not address the output fc issue that we have all spoke about in the past. Doing so I just took your approaches to checking the input of the file and removed what you commented out at the end for the output feature class.  Tested this by using our Unit Test that is in place.
I think we need to understand a bit more of what the user would want in the workflow. I think I would never want to overwrite my data using a tool such as this one, but I think others might disagree. I am going to see if there is a issue for this yet. If there is I will add come context to that issue and bring in @nfeuerstein for her input. If there is not an issue I will create one.

In arcmap does the script not fail on the following bit of code:
arcpy.SetParameter(3, outputFeatureClass)
As outputFeatureClass is deleted before this is called when overwrite is true

I can check again. The unit test did not fail.
This PR solves this issue:
https://github.com/ArcGIS/solutions-defense/issues/409

If the tool does fail move that line of code above this one:
arcpy.Delete_management(outputFeatureClass)
And it should be good

@adgiles the tool is working for me with a input layer inside and outside of a group layer.

Ok cool, it was failing for me yesterday in 10.3.1

I also tested in 10.3.1


CSV Import to tiddler error

Joshua,
I have always treasured the availability of the JSON plugin and I thank you for responding to my previous requests in relation to CSVs.
I am importing a CSV file at the moment and getting an errors converting them to tiddlers, I downloaded your whole wiki at https://chronicles.wiki/TW5-JsonMangler/ to ensure I had the full package. I note its on the Pre-release (at some point in time).
When I hit import I get the following;
Internal JavaScript Error
Well, this is embarrassing. It is recommended that you restart TiddlyWiki by refreshing your browser
TypeError: $tw.utils.slugifyText is not a function

I would be happy to share the csv tiddler "privately" if it may help trouble shooting, but I expect it has something to do with the new slugify features.
Regards
Tony

Hi Tony,
Good catch! This is definitely a bug. Looks like I missed removing one of the calls to my custom "slugifyText" code.
The core now has the "slugify[]" operator, and the portion of CSV import code should reference that or the $tw.utils.* function used in that filter operator. I will get a new version & demo wiki up for you asap once this is fixed.
Mahalo (thanks),
Joshua F

Joshua is it possible for me to access a prior version that may not have this problem?
I need to convert the data now.
Regards
Tony

Hey Tony,
Sorry about the delay. Yes, grab one of my past Releases, and use it with the 5.1.22 TW release:
https://github.com/joshuafontany/TW5-JsonMangler/releases/tag/v2.2.2
That one should have the correct $tw.util function and not error out on you.
Best,
Joshua F

Joshua,
Thanks for your help. I have never installed plugins via node before, I am using bob.exe
But I found an earlier install
Tony

Hi Tony,
I have fixed this issue, and there is a new Demo Wiki up that works as designed when importing CSV tiddlers into regular or Json Tiddlers. You should be able to now drag/drop from there into any 5.1.23-pre TW instance.
Thanks for the bug report & the donation. Much appreciated!
Best,
Joshua F

Joshua,
Thanks and you are welcome.
JSON mangler is that tool that sits in the background for me but when I need it  is essential. Thanks for such a comprehensive solution.
It is fantastic as a utility wiki, where its is installed for the refactoring of data importing to exporting then drag and drop on the wiki using the results.
Of course some serious solution my include it in a production wiki as well.
It would make sense to release an edition, not unlike the demo site, people can download the whole wiki  as needed. It would be appropriate to add it to the core editions file:///C:/Data/TW5/!TiddlyWiki.com/tiddlywiki.com.html#Editions
Regards
Tony
From: Joshua Fontany<EMAIL_ADDRESS>Sent: Monday, 19 October 2020 11:35 AM
To: joshuafontany/TW5-JsonMangler<EMAIL_ADDRESS>Cc: Anthony Muscio<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [joshuafontany/TW5-JsonMangler] CSV Import to tiddler error (#20)
Hi Tony,
I have fixed this issue, and there is a new Demo Wiki up that works as designed when importing CSV tiddlers into regular or Json Tiddlers. You should be able to now drag/drop from there into any 5.1.23-pre TW instance.
Thanks for the bug report & the donation. Much appreciated!
Best,
Joshua F
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/joshuafontany/TW5-JsonMangler/issues/20#issuecomment-711449861, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHQ7DER5MTFEAJVBPHQ4B5TSLOCRXANCNFSM4SOLCG7Q.


framer-motion dependency

Looks like framer-motion dependency adds around 90kb to js bundle. It's critical for web usage.
Is it necessary?

Hmm that's interesting, I didn't know that.
@mattgperry curious if you have thoughts here. I'm using the usePresence hook in each component, so I'm assuming that's importing all of framer motion. Is there a better way to do this?
Tree shaking on React Native Web is incredibly hard to maintain. It takes very little to mess it up, so it's not very reliable.

I actually just added sideEffects: false to package.json in the latest version, will that help?

Yeah it should do it in principle. I'll update and try pushing that out, thanks for the quick response here.

<EMAIL_ADDRESS>Hmm sideEffects: false doesn't help. Each export has the same size as whole bundle.

That's odd, it's the same with popmotion. I don't know enough about this to be able to fix it right away, will have to do some debugging.

Webpack's tree shaking is something I've had trouble finding good content on. Besides a short explanation on their docs saying that you should use sideEffects: true, I haven't seen too much. I also don't know enough about this.
@mattgperry if you need any help figuring this out for Framer, let me know.

I've published new versions of popmotion and framer-motion with the preserveModules: true which helps Webpack code-splitting ES modules. So 3.8.0 should have a minimal footprint for AnimatePresence (about 2.5kb)

Thanks to @mattgperry's update, moti is now down to 4.4kb gzipped<EMAIL_ADDRESS>yarn add moti
@gut4 thanks for bringing this to my attention.


Some Hint of the code disappear

Such as:
import matplotlib.pyplot as plt
fig = plt.figure()
fig. <---Here could not Hint the code.

ax = plt.subplot(2,1,1)
ax. <---Here could not Hint the code.

import scipy.stats as st
stats.t.interval() <--- Here could not Hint the parameter.

And sometimes notes: "Connection got disposed.".

We are investigating this and tracking it here #6865

BUt what about the "code hint" disappearing??

We suspect the error occurs due to a loss of connection with the Language Server. So it is a side effect of that you stop seeing code hints.

Ok, Thanks


Unable to connect to Home Assistant with SSL / proxy

Hi @t0bst4r
With regards to https://github.com/t0bst4r/home-assistant-matter-hub/issues/98#issuecomment-2509064383
I already posted the error in the now closed issue
https://github.com/t0bst4r/home-assistant-matter-hub/issues/98#issuecomment-2508715574
I think I'm confused about how HAMH is supposed to work and interact with Home Assistant with how the "old" Matterbridge works.
I've got both HA and HAMH running on the same host and I'm passing on the parameter "homeAssistantUrl": "https://hass.mydomain.co.uk/" in my config.json file but when I start HAMH I get
[ 2024-11-30T17:49:05.579Z ] [ ERROR ] [ Matter / Logger                                    ]: Unhandled error detected: Unable to connect to home assistant: SyntaxError: Invalid URL: ws://x.x.x.x:yyyy/api/websocket
  at _HomeAssistantClient.parseError (file:///usr/local/lib/node_modules/home-assistant-matter-hub/dist/backend/cli.js:727:14)
  at file:///usr/local/lib/node_modules/home-assistant-matter-hub/dist/backend/cli.js:711:18
  at async _HomeAssistantClient.initialize (file:///usr/local/lib/node_modules/home-assistant-matter-hub/dist/backend/cli.js:705:23)
file:///usr/local/lib/node_modules/home-assistant-matter-hub/dist/backend/cli.js:727
      return new Error(`Unable to connect to home assistant: ${reason}`);
             ^

Error: Unable to connect to home assistant: SyntaxError: Invalid URL: ws://x.x.x.x:yyyy/api/websocket
    at _HomeAssistantClient.parseError (file:///usr/local/lib/node_modules/home-assistant-matter-hub/dist/backend/cli.js:727:14)
    at file:///usr/local/lib/node_modules/home-assistant-matter-hub/dist/backend/cli.js:711:18
    at async _HomeAssistantClient.initialize (file:///usr/local/lib/node_modules/home-assistant-matter-hub/dist/backend/cli.js:705:23)

Node.js v20.18.1

Here is my config.json
{
    "homeAssistantUrl": "https://hass.mydomain.co.uk",
    "homeAssistantAccessToken": "REDACTED",
    "logLevel": "debug"
}

Originally posted by @tam481 in https://github.com/t0bst4r/home-assistant-matter-hub/issues/230#issuecomment-2509097280

Hi @tam481,
I moved this to a new issue.
The ip address mentioned in the error message, is the sample configured in the dockerfile.
Maybe i shouldn't have set it 😀
Anyway this means, that your config file doesn't take effect.
The URL you entered is just not used.
Can you please provide the docker command / docker-compose file you use to start the app?

This could actually be related to #218

Thank you very much @t0bst4r
Here's my docker-compose matterhub service definition
  matterhub:
    image: ghcr.io/t0bst4r/home-assistant-matter-hub:latest
    restart: unless-stopped
    container_name: matterhub
    hostname: matterhub
    volumes:
      - "$PWD/../conf/matterhub:/data:ro"
      - "$PWD/../data/matterhub:/root/.matterbridge"
    network_mode: host
    environment:
      HAMH_CONFIG: /data/config.json

It works when I set them as environment variables.

I'll change the dockerfile to not include the env variables anymore. Then it should work with the config file.

This should now be fixed with alpha.48


suggest the tree-view plugin can user-defined alias name

hi :
in the version 1.15.0 , just like this screenshot bellow:

when  i add two different fold where has the same name，in the tree-view ,it is difficulty to specification witch fold is witch.
so , is i can user-defined alias name for the "view" name, it is very easy to difficulty them.

Please create a new issue on the tree-view repository (if one doesn't already exist for your issue) and completely fill out the issue template.  Thanks!


Reserve FCP#100 for XUIO

After discussion with @allanjude we're going to prefer that reservations in the index arrive with an actual FCP document.


some  error

When   i    run   the     test.py,  it   show:
OSError: Unable to open file (Unable to open file: name = 'models/final.42-0.0398.hdf5', errno = 2, error message = 'no such file or directory', flags = 0, o_flags = 0)
but   i  had   put  the final.42-0.0398.hdf5   in this folder.

Please have a double check, feel free to reactivate this issue you're sure this is a code issue.


Revert “Create modules for integrations (#919)”

This is currently causing issues, as even without a new tag on the master branch, these new modules are being picked up as something like github.com/getsentry/sentry-go/fiber v0.0.0-20241230225403-109fca191e09 which breaks current installations.

Are you going to merge these immediately prior to new release (to prevent these issues) or will leave them as they were?

We need to merge this ASAP, and can figure out the problem afterwards.


Updates to viewport units

sv* units, lv* units, dv* units and the logical vi/vb units.

stolen from https://chromestatus.com/feature/5170718078140416.

sv* units (svb, svh, svi, svmax, svmin, svw), lv* units (lvb, lvh, lvi, lvmax, lvmin, lvw), dv* units (dvb, dvh, dvi, dvmax, dvmin, dvw) and the logical vi/vb units

is a bit unwieldy, but I thought it would be good to have them all for search results? Or move the bulk to tags?
MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/length

Random side note: https://trac.webkit.org/changeset/286458/webkit/

It would probably be nice to update https://tests.caniuse.com/viewport-unit-variants as well to cover more/all units :)

Hmm, tough one. On the one hand I do feel moving the full list to keywords would be better but that might not be obvious enough to all visitors. So let's try it like this for now. Thanks!
And yeah, I'll update the tests too.


[mesheryctl] Add tests for utils/helpers.go

Signed-off by: Aayush Kumar Sahu<EMAIL_ADDRESS>Description
This PR is related to https://github.com/meshery/meshery/issues/3982
Notes for Reviewers
Added tests for functions in utils/helpers.go.
I wasn't able to add tests for some functions, such as:

UpdateMesheryContainers because it needed a file meshery.yaml in home directory as well.
GetSessionData because I wasn't able to mock the HTTP request as well as I'm not sure how to check the auth headers. Definitely need a pointer here as to how to approach this test.
Other than that, TransformYAML and some other functions have been covered in utils_test.go as evident from https://codecov.io/gh/meshery/meshery/src/master/mesheryctl/pkg/utils/helpers.go , so I didn't move those tests. Let me know if I should move them inside helpers_test.go

Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #4177 (917fa40) into master (2227a06) will decrease coverage by 5.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4177      +/-   ##
==========================================
- Coverage   26.91%   21.88%   -5.03%
==========================================
  Files          59       59
  Lines        5031     5031
==========================================
- Hits         1354     1101     -253
- Misses       3262     3614     +352
+ Partials      415      316      -99

Flag
Coverage Δ

gointegrationtests
?

unittests
21.88% <ø> (+2.70%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (-62.83%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
0.99% <0.00%> (-53.98%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
0.85% <0.00%> (-36.76%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.05% <0.00%> (-34.74%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
1.78% <0.00%> (-32.15%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.39% <0.00%> (-22.38%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
0.00% <0.00%> (-21.60%)
:arrow_down:

mesheryctl/pkg/utils/testing.go
21.87% <0.00%> (+7.29%)
:arrow_up:

mesheryctl/pkg/utils/helpers.go
59.44% <0.00%> (+39.93%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fab9be...917fa40. Read the comment docs.

Good stuff here, @aayushmau5 🙂

@aayushmau5 heads-up: a failure in the last uncommented test - https://github.com/meshery/meshery/pull/4177/checks?check_run_id=3640263851#step:4:235

@leecalcote Yup, I'm working on resolving that :)

@piyushsingariya any idea why the PRs are failing? I think it's somewhat related to the UI tests.

@piyushsingariya any idea why the PRs are failing? I think it's somewhat related to the UI tests.

That's cool, it happens often times.

@aayushmau5 ping back when the changes are made and is ready to merge.

@piyushsingariya I think the tests are ready to be merged. Some actions are failing, but not because of this PR(mostly related to some other tests).

@aayushmau5 did you moved any files that weren't supposed to move? You gotta fix this. The tests that're failing here were working properly in other PRs. 😅
@krithikvaidya help here 🚑 , I think the tests which are failing here are added by you. 🤔

Sure, I will see what needs to be done in order to fix the failing test. :+1:

e in order to fix

That's a big help ❤

I think the PR is ready to be merged now :)

Consider this as a request, more like I am giving you the task that I am supposed to do. :joy:
Could you look and try to fix why this Integration Test is failing??

haha, sure. I will see what's causing the integration test to fail and try to fix it.

@aayushmau5 Have you joined our community on slack?

Yes!

Cool!


ServiceWorker doesn't work

ServiceWorker files are not automatically copied to ./build after updating to the latest versions of SvelteKit and Vite.
Progress tracking here, looks like need to wait for antfu/vite-plugin-pwa#327.
But I might be able to create a temporary solution until it updates?

@kwaa you can check this repo, I just hack the vite-plugin-pwa with a local copy of the plugin using the linked PR: https://github.com/userquin/pwa-sveltekit-vite

@kwaa you can check this repo, I just hack the vite-plugin-pwa with a local copy of the plugin using the linked PR: https://github.com/userquin/pwa-sveltekit-vite

Oh, thanks!
I noticed that, except the code was a bit hard to read.

the vite plugin pwa is built using Vite 2, so we just get the 3 plugins destructuring the array: we only need to register a new one for the pwa build plugin using the new Vite 3/ Rollup sequential hook and change the order to just run before the kit one (closeBundle hook in kit plugin will run the adapter, and so, we only need to run it before the kit one with the sequential enabled)

@kwaa you have some reference for Vite, Rollup and Kit in the repo README file


Add playground/demo site

Write Tera with syntax highlighting in the browser, display a syntax tree on the side: https://github.com/sogaiu/ts-questions/blob/master/questions/how-can-a-custom-playground-be-hosted/README.md.
Could also compile Tera programs by adding an execute button and bundling Tera as WASM.

https://github.com/tree-sitter/tree-sitter/issues/1701
Should include this change: https://github.com/tree-sitter/tree-sitter/issues/3029
Should include this change: https://github.com/tree-sitter/tree-sitter/issues/3261

https://www.npmjs.com/package/web-tree-sitter
https://github.com/edg-l/treelight
https://yew.rs/docs/getting-started/introduction


Single Camera Tracking not working

Hello,
I'm running the docker container for OpenPTrack and have been able to connect a Kinect V2 sensor and do intrinsic calibration on the camera. The Kinect is positioned about 1.5m above the ground and has clear visibility.
Then, as the google doc instructs, I run roslaunch tracking single_camera_tracking_node.launch. The RViz window and 'Select 3 Points' windows each pop up. In the 'Select 3 Points' window, I select 3 points on the mostly visible ground.  Another Camera Legend window pops up after a certain period of time. The terminal output seems normal and as expected.
In the Rviz interface, I have gotten pose detection as well as object detection displaying in the camera view and skeletons displaying on the grid. However, I am not able to view person tracking. In 'Tracking Marker', 'Tracking History', and 'Marker Array' I haven't been able to see the results of the /tracker/markers_array and /tracker/markers_array_smoothed at all. At times, they appear to be receiving images and are not throwing errors or warnings, but there is no visual result from the topics in Rviz.
In the 'Tracking History' I have seen 'Transform [sender=unknown_publisher]' but I'm not sure if this is affecting tracking. At this point I have ruled out hardware as a cause as I have confirmed that the Kinect is working with Protonect, have a fairly decent workstation gpu setup, and have tried running tracking alone in the single camera tracking demo. I think that there is some setting that I'm missing here and I would greatly appreciate any advice. Let me know if there's anything else that I can add here that I've missed.

I ran that command as well as other combinations of true and false for the other features. When tracking is isolated like in that command, there is a Fixed Frame error. This doesn't happen with any other combination, though. No tracking functionality.

I tried changing the fixed frame to /kinect2_head_rgb_optical_frame like it has been suggested in the V1 repo. The global status was resolved, but then tracking history broke and tracking doesn't work:

I've also tried the other available fixed frames such as link and ir but without luck.

Hi
3D tracks of people should also show up in single camera tracking.
It is quite possible you are doing the floor estimation in the wrong way. Try changing the ground estimation algorithm as well as ensure you are using the correct Rviz file.
Simeon

Closing as this issue has been open a while and we haven't been able to reproduce. Please re-open if this issue persists with our most recent updates!


provide better block control and time travelling

Close this issue due to time traveling has already implemented #12 (e564b8945b86ec677fd28306213bdf5ba931e107).
The rest of this issue will live in #19


update @antv/scale & @antv/attr

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] commit message follows commit guidelines

Description of change

3.3.6 版本这周四发布，还有一个 PR 需要合掉： https://github.com/antvis/f2/pull/515

CI 挂了


Rendering rule action parameters with quoted strings causes an error

SUMMARY
When invoking a rule that processes a trigger with a value containing a quoted string causes an error.
ISSUE TYPE

Bug Report

STACKSTORM VERSION
# st2 --version
st2 3.0.0, on Python 2.7.5

OS / ENVIRONMENT / INSTALL METHOD
CentOS 7.6
Puppet-st2

STEPS TO REPRODUCE
rule.yaml
---
name: "quoted_param_in_trigger_bug"
pack: "default"
description: "Demos how quoted values in a trigger instance cause render failures in a rule."
enabled: true

trigger:
  type: "core.st2.key_value_pair.update"

criteria: {}
action:
  ref: "examples.test"
  parameters:
    data:
      test: "{{ trigger.object.value }}"

trigger.yaml (yes, this file needs to be called .yaml even though it has JSON data in it)
{
    "id": "5ceed2bb9387ef0cefd1384b",
    "occurrence_time": "2019-05-29T14:43:07.000000Z",
    "payload": {
        "object": {
            "encrypted": false,
            "id": "5ceed29d9387ef2a25148f26",
            "name": "nick_test",
            "scope": "st2kv.system",
            "secret": false,
            "uid": "key_value_pair:st2kv.system:nick_test",
            "value": "Nick Test \"quoted string data\" blah"
        }
    },
    "status": "processed",
    "trigger": "core.st2.key_value_pair.update"
}

EXPECTED RESULTS
$ st2-rule-tester --rule=./rule.yaml --trigger-instance=./trigger.yaml --config-file=/etc/st2/st2.conf
2019-05-29 14:49:24,439 INFO [-] Connecting to database "st2" @ "<IP_ADDRESS>:27017" as user "stackstorm".
2019-05-29 14:49:24,443 INFO [-] Successfully connected to database "st2" @ "<IP_ADDRESS>:27017" as user "stackstorm".
2019-05-29 14:49:24,592 INFO [-] Validating rule default.quoted_param_in_trigger_bug for st2.key_value_pair.update.
2019-05-29 14:49:24,592 INFO [-] 1 rule(s) found to enforce for st2.key_value_pair.update.
2019-05-29 14:49:24,593 INFO [-] Failed to retrieve config for pack <Mock name='mock.pack' id='139681899526160'> and user stanley: 'Mock' object is not iterable
2019-05-29 14:49:24,598 INFO [-] Action parameters resolved to:
2019-05-29 14:49:24,598 INFO [-]        data: {u'test': u'Nick Test "quoted string data" blah'}
2019-05-29 14:49:24,598 INFO [-] === RULE MATCHES ===

ACTUAL RESULTS
Note: i have removed a bunch of the exception catching code so we can see the real stack trace
instead of the "masked" version that hides the root of the issue.
$ st2-rule-tester --rule=./rule.yaml --trigger-instance=./trigger.yaml --config-file=/etc/st2/st2.conf
2019-05-29 14:48:54,608 INFO [-] Connecting to database "st2" @ "<IP_ADDRESS>:27017" as user "stackstorm".
2019-05-29 14:48:54,612 INFO [-] Successfully connected to database "st2" @ "<IP_ADDRESS>:27017" as user "stackstorm".
2019-05-29 14:48:54,752 INFO [-] Validating rule default.quoted_param_in_trigger_bug for st2.key_value_pair.update.
2019-05-29 14:48:54,752 INFO [-] 1 rule(s) found to enforce for st2.key_value_pair.update.
2019-05-29 14:48:54,753 INFO [-] Failed to retrieve config for pack <Mock name='mock.pack' id='140023090276368'> and user stanley: 'Mock' object is not iterable
Traceback (most recent call last):
  File "/usr/bin/st2-rule-tester", line 21, in <module>
    rule_tester.main()
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2reactor/cmd/rule_tester.py", line 58, in main
    matches = tester.evaluate()
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2reactor/rules/tester.py", line 106, in evaluate
    additional_contexts=additional_contexts)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2reactor/rules/enforcer.py", line 84, in get_resolved_parameters
    additional_contexts=additional_contexts)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/util/param.py", line 312, in render_live_params
    context = _resolve_dependencies(G)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/util/param.py", line 224, in _resolve_dependencies
    context[name] = _render(node, context)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/util/param.py", line 208, in _render
    result = json.loads(result)
  File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python2.7/json/decoder.py", line 382, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Expecting ',' delimiter: line 1 column 22 (char 21)

Debugging
If i run with --debug you can see the render parameter issue:
$ st2-rule-tester --rule=./rule.yaml --trigger-instance=./trigger.yaml --config-file=/etc/st2/st2.conf --debug
2019-05-29 14:54:15,053 INFO [-] Connecting to database "st2" @ "<IP_ADDRESS>:27017" as user "stackstorm".
2019-05-29 14:54:15,058 INFO [-] Successfully connected to database "st2" @ "<IP_ADDRESS>:27017" as user "stackstorm".
2019-05-29 14:54:15,058 DEBUG [-] Ensuring database indexes...
2019-05-29 14:54:15,152 DEBUG [-] Skipping index cleanup for blacklisted model "PermissionGrantDB"...
2019-05-29 14:54:15,197 DEBUG [-] Indexes are ensured for models: ActionAliasDB, ActionAliasDB, ActionDB, ActionExecutionDB, ActionExecutionDB, ActionExecutionOutputDB, ActionExecutionSchedulingQueueItemDB, ActionExecutionStateDB, ActionExecutionStateDB, ApiKeyDB, ConfigDB, ConfigSchemaDB, GroupToRoleMappingDB, KeyValuePairDB, LiveActionDB, LiveActionDB, PackDB, PermissionGrantDB, PolicyDB, PolicyTypeDB, RoleDB, RuleDB, RuleEnforcementDB, RunnerTypeDB, RunnerTypeDB, SensorTypeDB, TaskExecutionDB, TokenDB, TraceDB, TriggerDB, TriggerInstanceDB, TriggerTypeDB, UserDB, UserRoleAssignmentDB, WorkflowExecutionDB
2019-05-29 14:54:15,204 INFO [-] Validating rule default.quoted_param_in_trigger_bug for st2.key_value_pair.update.
2019-05-29 14:54:15,204 DEBUG [-] Trigger payload: {u'object': {u'uid': u'key_value_pair:st2kv.system:nick_test', u'encrypted': False, u'value': u'Nick Test "quoted string data" blah', u'secret': False, u'scope': u'st2kv.system', u'id': u'5ceed29d9387ef2a25148f26', u'name': u'nick_test'}}
2019-05-29 14:54:15,204 DEBUG [-] [1st_pass] 1 rule(s) found to enforce for st2.key_value_pair.update.
2019-05-29 14:54:15,204 DEBUG [-] [2nd_pass] 0 rule(s) found to enforce for st2.key_value_pair.update.
2019-05-29 14:54:15,204 INFO [-] 1 rule(s) found to enforce for st2.key_value_pair.update.
2019-05-29 14:54:15,205 DEBUG [-] Attempting to get config for pack "<Mock name='mock.pack' id='139946342672592'>" and user "stanley"
2019-05-29 14:54:15,205 DEBUG [-] Pack and user found. Loading config.
2019-05-29 14:54:15,205 INFO [-] Failed to retrieve config for pack <Mock name='mock.pack' id='139946342672592'> and user stanley: 'Mock' object is not iterable
2019-05-29 14:54:15,208 DEBUG [-] Template ast: Template(body=[Output(nodes=[TemplateData(data=u"{'test': '"), Getattr(node=Getattr(node=Name(name='trigger', ctx='load'), attr='object', ctx='load'), attr='value', ctx='load'), TemplateData(data=u"'}")])])
2019-05-29 14:54:15,209 DEBUG [-] Dependencies: set(['trigger'])
2019-05-29 14:54:15,209 DEBUG [-] Rendering complex type: {"test": "{{ trigger.object.value }}"}
2019-05-29 14:54:15,209 DEBUG [-] Rendering node: {'template': '{"test": "{{ trigger.object.value }}"}'} with context: {'trigger': {u'object': {u'uid': u'key_value_pair:st2kv.system:nick_test', u'encrypted': False, u'value': u'Nick Test "quoted string data" blah', u'secret': False, u'scope': u'st2kv.system', u'id': u'5ceed29d9387ef2a25148f26', u'name': u'nick_test'}}, 'action_context': {'trigger_instance': {'id': 'rule_tester_instance', 'name': None}, 'user': 'stanley', 'rule': {'id': 'rule_tester_rule', 'name': u'quoted_param_in_trigger_bug'}, 'pack': <Mock name='mock.pack' id='139946342672592'>}, 'st2kv': {'system': <st2common.services.keyvalues.KeyValueLookup object at 0x7f47cc0ae850>, 'user': <st2common.services.keyvalues.UserKeyValueLookup object at 0x7f47cc0aeb10>}}
2019-05-29 14:54:15,210 DEBUG [-] Render complete: {"test": "Nick Test "quoted string data" blah"}
Traceback (most recent call last):
  File "/usr/bin/st2-rule-tester", line 21, in <module>
    rule_tester.main()
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2reactor/cmd/rule_tester.py", line 58, in main
    matches = tester.evaluate()
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2reactor/rules/tester.py", line 106, in evaluate
    additional_contexts=additional_contexts)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2reactor/rules/enforcer.py", line 84, in get_resolved_parameters
    additional_contexts=additional_contexts)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/util/param.py", line 312, in render_live_params
    context = _resolve_dependencies(G)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/util/param.py", line 224, in _resolve_dependencies
    context[name] = _render(node, context)
  File "/opt/stackstorm/st2/lib/python2.7/site-packages/st2common/util/param.py", line 208, in _render
    result = json.loads(result)
  File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python2.7/json/decoder.py", line 382, in raw_decode
    obj, end = self.scan_once(s, idx)
ValueError: Expecting ',' delimiter: line 1 column 22 (char 21)

The final line:
2019-05-29 14:54:15,210 DEBUG [-] Render complete: {"test": "Nick Test "quoted string data" blah"}

You can see the quotes inside the string are not escaped resulting in invalid JSON

FYI i've been able to work around this problem using the | json_escape filter in my rule:
---
name: "quoted_param_in_trigger_bug"
pack: "default"
description: "Demos how quoted values in a trigger instance cause render failures in a rule."
enabled: true

trigger:
  type: "core.st2.key_value_pair.update"

criteria: {}
action:
  ref: "examples.test"
  parameters:
    data:
      test: "{{ trigger.object.value | json_escape }}"

The | json_escape trick only works if you're extracting a single field. If you're extracting an object or array you still get an error, see the rule below:
---
name: "quoted_param_in_trigger_bug"
pack: "default"
description: "Demos how quoted values in a trigger instance cause render failures in a rule."
enabled: true

trigger:
  type: "core.st2.key_value_pair.update"

criteria: {}
action:
  ref: "examples.test"
  parameters:
    data:
      test: "{{ trigger.object | json_escape }}"

Since i'm getting the entire trigger.object it fails to render. If i limit the data to extract just the single field trigger.object.value then | json_escape properly escapes the string and can work around the error.

Thanks for making this ticket @nmaludy

Failed to retrieve config for pack  and user digitalxcadmin: expected string or bytes-like object
i am getting error like this give me a sollution for this.


I cannot post immediately post onboarding, and app installation

open chrome
download extension via link shared by @jinglescode
install
pin extension
create nsec via extension
draft note
"post" button is not available

MacOS  13.6.3
Chrome 121.0.6167.160 (Official Build) (arm64)

Restarting chrome fixes this issue

potential action: to check for user sign-in status upon open


Click on axis to reset brush does't work

Is it possible to match the behaviour of the original pcoords as shown here?
http://syntagmatic.github.io/parallel-coordinates/examples/brushing.html
In the above example, after applying a brush on an axis, if I click somewhere on the axis, the brush and the selection gets reset for that axis
In this version of the lib, it's a bit difficult to use. You can never really clear the brush on a single axis.

Hello, fixed. please use version: 1.0.3.

Thanks! Works now :D


FIX: Firefly3 - Add environment variables to fix broken login page form

What this PR does / why we need it:
When running Firefly3 behind a reverse proxy, the login page form tries to use a plan HTTP connection which causes the login to fail with the following error:
refused to send form data to 'http://domain/register' because it violates the following Content Security Policy directive: "form-action 'self'".

In the logs:
[2022-10-26T22:38:52.075027+13:00] local.INFO: AUDIT: Show login form (1.1). (<IP_ADDRESS> -> GET:**http**://firefly.mydomain.tld/login) [] []

Which issue (if any) this PR fixes:
Fixes #
Any other useful info:
By setting the following variables in the env the app logs in successfully:
APP_URL=https://firefly.mydomain.tld
TRUSTED_PROXIES=**

[2022-10-26T22:56:39.877379+13:00] local.INFO: AUDIT: Show login form (1.1). (<IP_ADDRESS> -> GET:**https**://firefly.mydomain.tld/login) [] []

See official documentation on this topic here

Thanks! :+1:


Inconsistency in libsvm formats

I found out that when I trained a model using the distributed version of the JVM package - the libsvm format for the indexes has to be one-based ascending order. Whereas, when I used the saved model in the Python package it expected the libsvm format to be zero-based - which resulted in different predictions in the Python package. To work around this you have to modify your libsvm format accordingly.

Mainly due to the fact that spark does the internal conversion, and do not accept format that are 0-based. So the labeledVector transformed from spark's input was already transformed. While xgboost itself do not run any transformation

@tqchen Thank you for the clarification. So this should be mentioned in the README, right? I spent some time before realizing this - as I was getting very different results while using the saved model (distributed training) in the Python package. I think mentioning this somewhere might help new users. I have made another change in README with your clarification.


Price display

When I hold 'No' shares in a market, my holdings on the account page report the price of the 'No' shares; this is backwards from what I'm used to / expected, and I think backwards from the desired behavior.
This adds a lot of mental strain for the user; I have to mentally negate the prices on only some of the lines in order to come up with probabilities that can be applied to the text next to them. Basically, I should be able to parse the display as "Event X is 80% likely to happen; I hold 5 'No' shares.". Instead it's showing me "Event X (in which I hold 5 'No' shares) is 20% likely to not happen", which is a lot more work to interpret.

true.  this was a mistake and good catch.  the percentage/price of a binary market should always be the likely hood of the affirming outcome.  at least that's my understanding and is less cognitive load on the user.


Separate menu icon for delete and copy, Quote reply

Description
When another user sends the message, the chat consists of 2 (kebab) menu icons.
1st for delete message.
2nd for copy, Quote reply.
Screenshots

Additional information
No response
🥦 Browser
Mozilla Firefox
👀 Have you checked if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

[X] I have read and understood the rules in the Contributing Guidelines

Are you willing to work on this issue ?
Yes I am willing to submit a PR!

duplicate of #289, keep in mind that when you are creating an issue, always check if it already exists before


I don't want to generate a method inherited from the class. What should I do?

[ ] I have checked issues with enhancement label and found no duplicates

Problem

Suggested Solution

https://www.npmjs.com/package/typedoc-plugin-no-inherit


content_available option

Feature request for content_available option for iOS clients.  This allows iOS clients to update in the background when receiving a push notification.   For GCM, it is a boolean value for the key "content_available".
ref: https://developers.google.com/cloud-messaging/http-server-ref

I'm not sure I understand your feature request: as described in the ref for the content_available field, "On iOS, use this field to represent content-available in the APNS payload.". Have you tried and it's not working?

I guess my question is where should the "content_available" key be set
using the the gcm-server API? I have it working when I use my forked
version of the code:
notifyBuilder.title("title").body("body").badge(10).sound("default")
.contentAvailable(true);
However, maybe this is not the correct way to do it?
On Wed, Jan 27, 2016 at 4:05 PM, Silvano Luciani<EMAIL_ADDRESS>wrote:

I'm not sure I understand your feature request: as described in the ref
for the content_available field, "On iOS, use this field to represent
content-available in the APNS payload.". Have you tried and it's not
working?
—
Reply to this email directly or view it on GitHub
https://github.com/google/gcm/issues/162#issuecomment-175918620.

Oh ok, I got confused because I didn't understand you were referring to the Java library. To reflect the parameters' structure of the GCM API, it should be in the Message builder rather than the Notification builder. Assigning this to @kroikie and renaming the issue for clarity, feel free to send a Pull Request if you want :)


*const redbpf_probes::bindings::sock` cannot be shared between threads safely

https://github.com/foniod/foniod/blob/main/ingraind-probes/src/network/main.rs#L9
#![no_std]
#![no_main]
use probes::network::{Connection, Message};
use redbpf_probes::kprobe::prelude::*;

program!(0xFFFFFFFE, "GPL");

#[map(link_section = "maps/task_to_socket")]
static mut task_to_socket: HashMap<u64, *const sock> = HashMap::with_max_entries(10240);

#[map]
static mut ip_connections: PerfMap<Connection> = PerfMap::with_max_entries(1024);

#[map]
static mut ip_volumes: PerfMap<Message> = PerfMap::with_max_entries(1024);

#[kprobe("tcp_v4_connect")]
pub fn connect_enter(regs: Registers) {
    store_socket(regs)
}

#[kretprobe("tcp_v4_connect")]
pub fn connect(regs: Registers) {
    if let Some(c) = conn_details(regs) {
        unsafe {
            ip_connections.insert(regs.ctx, &c);
        }
    }
}

#[kprobe("tcp_sendmsg")]
pub fn send_enter(regs: Registers) {
    store_socket(regs)
}

#[kretprobe("tcp_sendmsg")]
pub fn send_exit(regs: Registers) {
    trace_message(regs, Message::Send)
}

#[kprobe("tcp_recvmsg")]
pub fn recv_enter(regs: Registers) {
    store_socket(regs)
}

#[kretprobe("tcp_recvmsg")]
pub fn recv_exit(regs: Registers) {
    trace_message(regs, Message::Receive)
}

#[kprobe("udp_sendmsg")]
pub fn udp_send_enter(regs: Registers) {
    trace_message(regs, Message::Send)
}

#[kprobe("udp_rcv")]
pub fn udp_rcv_enter(regs: Registers) {
    trace_message(regs, Message::Receive)
}

#[inline(always)]
fn store_socket(regs: Registers) {
    unsafe { task_to_socket.set(&bpf_get_current_pid_tgid(), &(regs.parm1() as *const sock)) };
}

#[inline(always)]
fn trace_message(regs: Registers, direction: fn(Connection, u16) -> Message) {
    if let Some(c) = conn_details(regs) {
        let len = regs.parm3() as u16;
        unsafe {
            ip_volumes.insert(regs.ctx, &direction(c, len));
        }
    }
}

#[inline(always)]
pub fn conn_details(_regs: Registers) -> Option<Connection> {
    let pid_tgid = bpf_get_current_pid_tgid();
    let socket = unsafe {
        match task_to_socket.get(&pid_tgid) {
            Some(s) => &**s,
            None => return None,
        }
    };

    let pid = (pid_tgid >> 32) as u32;
    let ts = bpf_ktime_get_ns();
    let family = socket.skc_family()?;

    let mut daddr = in6_addr {
        in6_u: in6_addr__bindgen_ty_1 {
            u6_addr32: [0, 0, 0, 0],
        },
    };
    let mut saddr = in6_addr {
        in6_u: in6_addr__bindgen_ty_1 {
            u6_addr32: [0, 0, 0, 0],
        },
    };

    if family as u32 == AF_INET6 {
        daddr = socket.skc_v6_daddr()?;
        saddr = socket.skc_v6_rcv_saddr()?;
    } else if family as u32 == AF_INET {
        let dest = socket.skc_daddr()?;
        let src = socket.skc_rcv_saddr()?;

        daddr = in6_addr {
            in6_u: in6_addr__bindgen_ty_1 {
                u6_addr32: [0, 0, 0xFFFF0000, dest],
            },
        };
        saddr = in6_addr {
            in6_u: in6_addr__bindgen_ty_1 {
                u6_addr32: [0, 0, 0xFFFF0000, src],
            },
        };
    }

    let dport = socket.skc_dport()? as u32;
    let sport = socket.skc_num()? as u32;

    #[cfg(any(kernel_version = "5.7", kernel_version = "5.6"))]
    let typ = socket.sk_protocol()? as u32;

    #[cfg(not(any(kernel_version = "5.7", kernel_version = "5.6")))]
    let typ: u32 = {
        let typ = unsafe { bpf_probe_read(&socket._bitfield_1 as *const _ as *const u32) }.ok()?;
        // (typ & SK_FL_PROTO_MASK) >> SK_FL_PROTO_SHIFT
    };

    unsafe {
        task_to_socket.delete(&pid_tgid);
    }

    Some(Connection {
        pid,
        ts,
        comm: bpf_get_current_comm(),
        saddr: saddr.into(),
        daddr: daddr.into(),
        sport,
        dport,
        typ,
    })
}

Cargo.toml
[package]
name = "probes"
version = "0.1.0"
edition = '2018'

[dependencies]
cty = "0.2"
redbpf-macros = "2.3.0"
redbpf-probes = "2.3.0"

[build-dependencies]
cargo-bpf = { version = "2.3.0", default-features = false }

[features]
default = []
probes = []

[lib]
path = "src/lib.rs"

[[bin]]
name = "network"
path = "src/network/main.rs"
required-features = ["probes"]

Error
excute command: cargo +1.59.0  bpf build --target-dir=../target
warning: due to multiple output types requested, the explicitly specified output file name will be adapted for each output type

warning: ignoring --out-dir flag due to -o flag

error[E0277]: `*const redbpf_probes::bindings::sock` cannot be shared between threads safely
  --> src/network/main.rs:43:1
   |
43 | #[map(link_section = "maps/task_to_socket")]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `*const redbpf_probes::bindings::sock` cannot be shared between threads safely
   |
   = help: within `MaybeUninit<*const redbpf_probes::bindings::sock>`, the trait `Sync` is not implemented for `*const redbpf_probes::bindings::sock`
   = note: required because it appears within the type `ManuallyDrop<*const redbpf_probes::bindings::sock>`
   = note: required because it appears within the type `MaybeUninit<*const redbpf_probes::bindings::sock>`
   = note: shared static variables must have a type that implements `Sync`
   = note: this error originates in the attribute macro `map` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0277`.
warning: `probes` (bin "network") generated 2 warnings
error: could not compile `probes` due to previous error; 2 warnings emitted
error: failed to compile the `network' program

@rsdy  cc

@withlin Unfortunately I don't have the capacity to dig into this right now. The foniod codebase has bitrotted in the past years, so I think you will want to go through the examples in the redbpf repo, and try to to port over any code from foniod that you're interested in.

@rsdy thank you for your response. i will  try to check it. tks.