Snapshot: improve types

Thank you for contributing to the Cohere Toolkit!

[ ] PR title: "area: description"

Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..."  for CI changes.
Example: "deployment: add Azure model option"

[ ] PR message: Delete this entire checklist and replace with

Description: a description of the change
Issue: the issue # it fixes, if applicable
Dependencies: any dependencies required for this change

[ ] Add tests and docs: Please include testing and documentation for your changes

[ ] Lint and test: Run make lint and make run-tests

AI Description

This pull request introduces changes to the snapshot creation process, adding the SnapshotAgent and SnapshotData models and updating the create_snapshot function to use these models.

The SnapshotAgent and SnapshotData classes are added to the src/backend/schemas/snapshot.py module, defining the structure of snapshot agents and data respectively.
The create_snapshot function in src/backend/routers/snapshot.py has been modified to use the new SnapshotAgent and SnapshotData models. The conversation_dict parameter has been replaced with a conversation object, and the private keys removal step has been removed.
The wrap_create_snapshot function in src/backend/services/snapshot.py has been updated to use the new SnapshotAgent and SnapshotData models. It now creates a snapshot_agent if the conversation has an agent_id, and constructs a snapshot_data object using the conversation's title, description, messages, and the created snapshot_agent.
The test_snapshot module in src/backend/tests/routers/test_snapshot.py has been updated to include a snapshot dictionary with example data.

Codecov Report
Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.26%. Comparing base (a302a6e) to head (5fc4482).

Files
Patch %
Lines

src/backend/services/snapshot.py
71.42%
2 Missing :warning:

Additional details and impacted files
@@                      Coverage Diff                      @@
##           luisa/share_conversations     #362      +/-   ##
=============================================================
- Coverage                      86.46%   86.26%   -0.21%
=============================================================
  Files                            178      178
  Lines                           6887     6909      +22
=============================================================
+ Hits                            5955     5960       +5
- Misses                           932      949      +17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Index of failing tests on Node.js with IndexedDBShim

This is a preliminary list of the Dexie test suite failing tests on Node.js with IndexedDBShim when run with the new node test runner. Some of these errors may be due to the environment created by the test runner itself and possibly some by non-isomorphic code in the tests themselves. I’m gathering these in one place to give an overview of the current state of Dexie on Node.js with IndexedDBShim. It might be best to either use this issue to track and update the state or to pull out specific tests into their own issues.
@dfahlander has written up an analysis and a summary of the current state of Node.js support via IndexedDBShim based on a preliminary run of these tests.
tests-table.js

[ ] 23 - Karl found first on last 'Faadersköld', expected: "Karl", got: "David", test: where, module: table
[ ] 24 - David found second on last 'Fahlander', expected: "David", got: "Karl", test: where, module: table
[ ] 25 - Finding items from array members. Expect to fail on IE10/IE11., expected: 1, got: 2, test: where, module: table
[ ] 104 - BarC should be second (updated previous ID, expected: "BarC", got: "BarB", test: bulkPut - mixed inbound autoIncrement, module: table
[ ] 105 - BarB should be third (got new key), expected: "BarB", got: "BarC", test: bulkPut - mixed inbound autoIncrement, module: table
[ ] 114 - ReferenceError: notEqual is not defined, expected: true, got: false, test: delete, module: table
[ ] 115 - ReferenceError: notEqual is not defined, expected: true, got: false, test: delete(using transaction), module: table
[ ] 123 - Test timed out, expected: undefined, got: null, test: failNotIncludedStoreTrans, module: table

tests-collection.js

[ ] 10 - First is Karl, expected: "Karl", got: "David", test: toArray, module: collection
[ ] 11 - Second is David, expected: "David", got: "Karl", test: toArray, module: collection
[ ] 13 - First is Karl, expected: "Karl", got: "David", test: limit, module: collection
[ ] 40 - Got Karl, expected: "Karl", got: "David", test: first, module: collection
[ ] 68 - TypeError: str.replace is not a function, expected: true, got: false, test: keys, module: collection
[ ] 70 - TypeError: str.replace is not a function, expected: true, got: false, test: uniqueKeys, module: collection
[ ] 72 - TypeError: str.replace is not a function, expected: true, got: false, test: primaryKeys, module: collection
[ ] 74 - TypeError: str.replace is not a function, expected: true, got: false, test: primaryKeys2, module: collection
[ ] 92 - Test timed out, expected: undefined, got: null, test: or-issue#15-test, module: collection
[ ] Bail out (script timeout) after tests run.

tests-whereclause.js

[ ]  227 - Test timed out, expected: undefined, got: null, test: Issue #696 - Query on multiple multi-entry indexes doesn't seem to work, module: WhereClause

tests-transaction.js

[ ] 10 - Test timed out, expected: undefined, got: null, test: Table not in transaction 2, module: transaction
[ ] 12 - Test timed out, expected: undefined, got: null, test: Write into readonly transaction, module: transaction
[ ] 14 - Test timed out, expected: undefined, got: null, test: Inactive transaction, module: transaction
[ ] Bail out (script timeout) after successfully running/passing test 15

tests-open.js

[ ] 18 - Test timed out, expected: undefined, got: null, test: test-if-database-exists, module: open
[ ] 19 - Test timed out, expected: undefined, got: null, test: test-if-database-exists, module: open
[ ] 20 - Expected 3 assertions, but 4 were run, expected: undefined, got: null, test: test-if-database-exists, module: open
[ ] 21 - Test timed out, expected: undefined, got: null, test: open database without specifying version or schema, module: open

tests-yield.js
All pass.
tests-asyncawait.js

[ ] 12 - Error: TransactionInactiveError: A request was placed against a transaction which is currently not active, or which is finished, expected: true, got: false, test: Should be able to use native async await, module: asyncawait

tests-exception-handling.js

[ ] 1 - unhandledrejection should have been signaled, expected: 1, got: 0, test: Uncaught promise should signal 'unhandledrejection', module: exception-handling
[ ] 6 - Test timed out, expected: undefined, got: null, test: transaction should abort on collection error, module: exception-handling
[ ] 7 - Test timed out, expected: undefined, got: null, test: eventError-transaction-catch, module: exception-handling (looks like the test is oddly run twice in the output)

tests-upgrading.js

[ ] 25 - Error: ReferenceError: deepEqual is not defined, expected: true, got: false, test: upgrade, module: upgrading

tests-misc.js

[ ] 18 - Test timed out, expected: undefined, got: null, test: #360 DB unresponsive after multiple Table.update() or Collection.modify(), module: misc – is this due to the test runner timeout or a genuine failure?

tests-promise.js
All the errors stem from the same use of non-isomorphic code in the test (window.addEventListener). This will be a quick fix.

[ ] 12 - Died on test #1     at asyncTest (/Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:1305:8): window.addEventListener is not a function, expected: undefined, got: null, test: onunhandledrejection should propagate once, module: promise – non-isomorphic test code
[ ] 13 - Died on test #1     at asyncTest (/Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:1305:8): window.addEventListener is not a function, expected: undefined, got: null, test: onunhandledrejection should not propagate if catched after finally, module: promise  – non-isomorphic test code
[ ] 28 - Died on test #1     at asyncTest (/Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:1305:8): window.addEventListener is not a function, expected: undefined, got: null, test: unhandledrejection, module: promise – non-isomorphic test code
[ ] 29 - Died on test #1     at asyncTest (/Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:1305:8): window.addEventListener is not a function, expected: undefined, got: null, test: unhandledrejection2, module: promise – non-isomorphic test code
[ ] 30 - Died on test #1     at asyncTest (/Users/aral/indie/other/forks/dexie/node_modules/qunitjs/qunit/qunit.js:1305:8): window.addEventListener is not a function, expected: undefined, got: null, test: unhandledrejection3, module: promise – non-isomorphic test code

tests-extendability.js
All pass.
tests-crud-hooks.js
All pass.
tests-blobs.js
Blob and FileReader are not supported on Node.js. The test runner was using polyfills in an attempt at isomorphism. @dfahlander suggests the following: “Use UInt8Array instead of Blob to support both node and browser.” (We should prepare an example of how this would work in a universal JS app.)

[ ] 1 - Error: cannot read as File: {"type":"application/octet-binary","size":4} … expected: true, got: false, test: Test blobs, module: blobs (FileReader.js:266:15 – FileReader.self.readAsArrayBuffer)
[ ] 3 - Error: cannot read as File: {"type":"application/octet-binary","size":4} … expected: true, got: false, test: Test blob with creating hook applied, module: blobs (FileReader.js:266:15 – FileReader.self.readAsArrayBuffer)

tests-binarykeys.js
All pass.
(Results on all tests under Node.js are “This browser does not support IndexedDB 2.0”.)

@aral, I've forked IndexedDBShim and did npm link between dexie and the shim. Added you as collaborator so feel free to push fixes to it if you want. Will create a living PR to the upstream as well.
Another way of running the shim is to insert the following lines into the HEAD section of dexie/test/run-unit-tests.html:
  <script src="../node_modules/babel-polyfill/dist/polyfill.min.js"></script>
  <script src="../node_modules/indexeddbshim/dist/indexeddbshim.js"></script>
  <script>
    shimIndexedDB.__useShim();
  </script>

Seems to show the same issues as your node tests did, but not all of them.

@dfahlander Thanks, David. Regarding how we manage IndexedDBShim in Dexie for user space: would you rather that we:

Added it to dependencies so that it would work out of the box. This would probably be the best option if the library is going to embrace its universal nature going forward. My only concern with this is the size of IndexedDBShim, which currently weights in at ~190MB. I was able to shave ~146MB off of that by removing the Unicode.10.0.0 package and instead inlining the 2KB regular expression that was being used from it but that hasn’t made it to master yet.

Remove it from package.json for the time being, document the npm link process and keep it as a development feature until it is ready for prime time (when we have a fully-passing test suite for Node).

(I’m assuming not, since it’s the worst of three options) keep it in dev-dependencies. This has no advantages but was a quick and simple way for me to work while getting the test suite running in Node.

Let me know and either I’ll be happy to push that change to https://github.com/dfahlander/Dexie.js/pull/707 or please feel free to do so yourself :)

I think IndexedDBShim fits well as a dev dependency in case we use it in the test suite (as you did in your PR). Based on that, anyone wishing to fix bugs in the shim, could use npm link to replace node_modules/IndexedDBShim with a symbolic link to their local IndexedDBShim code. I hope the time to do npm install won't suffer too much when adding it as a dependency. If so, we could add it as an optional dependency and let the specific tests that use it make sure it's installed.

@dfahlander Right, makes sense. If we do add it as a dev dependency, however, we should document that Dexie will not run out of the box on Node.js and that you must add IndexedDBShim separately
to your package.json on Node.js.
The time to install shouldn't be a huge issue once Uncode.10.0.0 is added as a dev dependency in IndexedDBShim – that what takes up an overwhelming majority of the space.

After my recent updated push to IndexedDBShim, I could check 104 and 105 as well:

104 - BarC should be second (updated previous ID, expected: "BarC", got: "BarB", test: bulkPut - mixed inbound autoIncrement, module: table
105 - BarB should be third (got new key), expected: "BarB", got: "BarC", test: bulkPut - mixed inbound autoIncrement, module: table

It seems the ordering part is solved if my PR goes into IndexedDBShim master.


Provide GlobalStoragePath for large workspace independent extension data

This feature request is related to #37137 and #22557, but is more focused on global state.
Some extensions, especially language servers, need global data that cannot be bundled in the extension. There are two main reason I know of:

Allowing server updates independently of extension updates. E.g. ms-vscode.csharp and omnisharp I believe
Caching of global data for performance

The current options for storing extension data are:

extensionPath, which is wiped on extension update
storagePath, which is not global
globalState, which is not appropriate for file storage
System specific user data storage location, e.g. %appdata% and equivalent.

Currently, 4 is the only workable solution. However:

It hides the data from the user (not stored in vscode space)
It can't be removed by vscode on extension uninstallation (although I'm not sure vscode does this for storagePath)
It adds fragility (reliance on extension author handling of OS-specific user file storage).
It's effectively undocumented

The addition of a globalStoragePath, an extra workspaceStorage folder with global scope, would resolve all of above issues
My context for the requirement:
My language server extension creates 200-300MB of serialized binary data from a system library which is cached to speed up subsequent activation. Creating this data is time-consuming (1-3 minutes) but it is global for the language. The library may not be available on future runs, so loss of the cache is undesirable (hence extensionPath wiping on update being a problem).
My extension is cross-platform, but I have little experience of linux or OSX user data, so would be reluctant to manually implement a cross-platform user file management layer.

I think this is already in proposed: https://github.com/Microsoft/vscode/blob/28e7467/src/vs/vscode.proposed.d.ts#L1123


Call API

Calls the Scaleway API through the CLI and tries to manipulate some resources.
Compute, probably

/close

/label wont-do

This functionality belongs in the skyforge repo.


Add files via upload

Basis International Shenzhen, https://bisz.basischina.com/#/home?lang=en

sch-integral.txt
url - https://integral.mskobr.ru/

山东大学
Shandong University
sdu.edu.cn

@bhodhos Pull request merged. Thank you.

@MAxd78 @MikeKate666 Please make separate pull requests, do not comment other's requests. Thank you.

@MAxd78 @MikeKate666 Please make separate pull requests, do not comment other's requests. Thank you.

I can't get it, I can't understand the interface


Create mrso

The file needs a .txt extension.
Also, is this a high school or a post-secondary school?

in germany its called Realschule i think its somethiing like a highschool

Unfortunately, this gem is for post-secondary schools only :/


feat(pageserver): use fnv hash for aux file encoding

Problem
FNV hash is simple, portable, and stable. The only problem is that it's 64b, which does not make full use of the aux file keyspace. We can modify the algorithm to use 128b instead, but I didn't do it in this pull request, as I don't know if using 128b still preserves the properties of the hash algorithm.
replaces https://github.com/neondatabase/neon/pull/7644
ref https://github.com/neondatabase/neon/issues/7462
Summary of changes
Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

We can modify the algorithm to use 128b instead, but I didn't do it in this pull request, as I don't know if using 128b still preserves the properties of the hash algorithm.

128 bit and other length variants exist, see https://en.wikipedia.org/wiki/Fowler–Noll–Vo_hash_function. That particular crate only implements the 64 bit variant but there are others, and it's not hard to roll your own.
I'd assume 64 bits to be enough, though.

Do we need to worry about malicious actors creating intentional collisions here? What happens if there's a ton of collisions? Does it only cause trouble for the single tenant, or the whole pageserver?

switched to FNV128 using the prime + offset in the wiki, better to get a review again, or I'll merge it later today.

Okay it still requires a review from code owner 🤣 @koivunej do you have time to take a look? Thanks :)

Do we need to worry about malicious actors creating intentional collisions here? What happens if there's a ton of collisions? Does it only cause trouble for the single tenant, or the whole pageserver?

Creating intentional collision might cause write amplifications like before John’s one-file-one-delta-record PR, and it will only cause trouble for a single tenant. We can change the encoding of aux file value to delta + image in the future if it indeed becomes a problem.


Question: Ignore certain hosts or api calls with a header

I'm also using http to send otel logs out.  I'd like the trace capture for these to be ignored.  How should i go about doing this?

i have a filter in includeTraceContext but i think that's only for distributed tracing.  Would be great to use the raw fetch for some of these calls but i'm unsure if i can use the unwrap function.
id like to filter  hosturl or 'otel-ignore' header key, but unsure where to add this

thanks!

its related to https://github.com/evanderkoogh/otel-cf-workers/issues/79


Modular GUI: Screen prototypes for UC Dashboard

[x] Define interviews script
[x] Define interviewed users
[x] Apply interviews
[x] Analyse results
[x] Design sprint
[ ] Prototyping

Final wireframes used to test users about Dashboard
https://app.zenhub.com/files/103167521/27a4830f-1c82-4ef2-95fd-d2b6d1fd9e30/download


Modify exit 'event' to 'close'

Modify exit 'event' to 'close' for that make sure emitting event after stdout flush

Perfect, thanks!

Available in 0.5.3.


Attempted import error: 'render' is not exported from 'react-blessed'.

I'm attempting the readme basic application with the latest create-react-app and I get this error.
Any tips to get this working?

Same here, can't belive this is not solved.
@monkeysuffrage we use create-react-app then use the instractions in readme to install.
The error is
Attempted import error: 'render' is not exported from 'react-blessed'.

This is not an issue of the library. create-react-app is meant to spawn a web application in a browser, not a shell environment. As such it does not work when running npm start and running its dev server to spawn the web page. You don't need create-react-app to make this library work. Maybe the create-react-app team would be interested in creating a react-blessed template but I doubt it.

well it seems I was the one who misunderstood, I thought it was a web-based terminal window.

I'm getting this error with barebones webpack app. This is what my webpack.config.js looks like:
const path = require("path")

module.exports = environment => ({
  entry: "./src",
  mode: environment.mode,
  output: {
    path: path.join(__dirname, "build"),
    filename: "bundle.js"
  },
  module: {
    rules: [
      {
        test: /\.(js|jsx)$/,
        exclude: /node_modules/,
        use: {
          loader: "babel-loader"
        }
      }
    ]
  }
})

Actually, solved the issue. This is how I'm running the app now, with command yarn development:
package.json:
{
  "name": "placeholder",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "scripts": {
    "development": "webpack --watch --env.mode development",
    "production": "webpack --env.mode production"
  },
  "dependencies": {
    "axios": "^0.19.2",
    "blessed": "^0.1.81",
    "blessed-contrib": "^4.8.19",
    "cheerio": "^1.0.0-rc.3",
    "react": "^16.13.1",
    "react-blessed": "^0.6.2"
  },
  "devDependencies": {
    "@babel/core": "^7.9.0",
    "@babel/preset-env": "^7.9.0",
    "@babel/preset-react": "^7.9.4",
    "babel-loader": "^8.1.0",
    "nodemon": "^2.0.2",
    "nodemon-webpack-plugin": "^4.3.1",
    "webpack": "^4.42.1",
    "webpack-cli": "^3.3.11",
    "webpack-dev-server": "^3.10.3",
    "webpack-node-externals": "^1.7.2"
  },
  "babel": {
    "presets": [
      "@babel/preset-react",
      [
        "@babel/preset-env",
        {
          "targets": {
            "node": true
          }
        }
      ]
    ]
  }
}

webpack.config.js:
const webpack = require("webpack")
const path = require("path")
const fs = require("fs")

/*
  ======================================
    This file is necessary for build
    steps or debugging, so if you're
    a beginner in programming and don't
    know what this file does, just
    don't delete it.
  ======================================
*/

module.exports = environment => ({
  mode: environment.mode,
  target: "node",
  entry: "./src",
  output: {
    path: path.join(__dirname, "build"),
    filename: "[name].bundle.js"
  },
  externals: [require("webpack-node-externals")()],
  plugins: [new (require("nodemon-webpack-plugin"))()],
  module: {
    rules: [
      {
        test: /\.(js|jsx)$/,
        exclude: /node_modules/,
        use: {
          loader: "babel-loader"
        }
      }
    ]
  }
})

So is there any problem there? I am a bit confused. Why are you using webpack on the server-side though?

Nope, no problem now with the build. Except I'm having some troubles trying to access main screen across the components, but I should open a new issue requesting for a detailed document on event handling and access to main screen and detailing the need for it.
I'm kind of a beginner when it comes to Webpack but I think it can also be used on server-side as well (with some plugins like webpack-dev-server) and since it's essentially just a bundler that provides support of various module patterns by default, I thought why not use it for CLIs and TUIs.

Except I'm having some troubles trying to access main screen across the components, but I should open a new issue requesting for a detailed document on event handling and access to main screen and detailing the need for it.

You should be able to get access to it through a ref. But I suggest you pass it through context else.


sails-postgres doesn't work with unix socket connections

DB adapter & version: sails-postgres@
Unless I'm missing something obvious, sails-postgres won't work with PostgreSQL unix socket connections.
This seems to be a direct result of the conversion from separate datastore config values to a connectionString performed in sails-postgresql/helpers/register-data-store.js.
I will look into this further and hopefully provide a patch shortly.

For the brave and desperate:
const fs = require('fs');

function patchAndReplace(path, replacements) {
  let text = fs.readFileSync(path, { encoding:'utf-8' });
  replacements.forEach(r => {
    text = text.replace(r.find, r.replace);
  });
  fs.writeFileSync(path, text, 'utf-8');
}

patchAndReplace('node_modules/sails-postgresql/helpers/register-data-store.js', [
  {
    find:    "if (!_.has(inputs.config, 'url')) {",
    replace: "if (false && !_.has(inputs.config, 'url')) {",
  },
]);

patchAndReplace('node_modules/machinepack-postgresql/machines/create-manager.js', [
  {
    find: 'required: true',
    replace: '//required: true',
  },
  {
    find:    "// Remember: connection string takes priority over `meta` in the event of a conflict.",
    replace: "if(inputs.connectionString !== undefined)",
  },
]);

I'll try to wrap this in a couple of PRs soonish.

@alxndrsn thanks always for posting the bug, and then posting a brute force solution until permanent solution lands.

by any chance @alxndrsn would you have work around for this - https://github.com/balderdashy/sails/issues/6876

I'll bring this up with the team to include a fix for this in our upcoming sails-sql adapter being developed to feature a combination of PostgresSQL, MySQL, and MSSQL support henceforth.  MySQL & MSSQL are currently ready to use - PostgresSQL is the primary focus of its development right now.

@johnabrams7 thanks for the update.
sails-sql is currently marked DO NOT USE IN PRODUCTION in big letters: https://www.npmjs.com/package/sails-sql
Until this reaches production, it would be great to get this ticket fixed in sails-postgresql; please let me know if that is a possibility, and if so how I can help.  I'm happy to provide relevant PRs.

@alxndrsn I'll ask Mike if sails-sql's postgresql support is looking ready for production by January next year along with considering this among that release.  Regardless, a PR is welcome after the production release for sure.

@johnabrams7 thanks for the response.  Does the following refer to sails-sql:

a PR is certainly welcome after the production release.

?
If so, please refer to my previous comment:

Until this reaches production, it would be great to get this ticket fixed in sails-postgresql; please let me know if that is a possibility, and if so how I can help. I'm happy to provide relevant PRs.

@alxndrsn, I understand the confusion and sorry for the delay.  Yes, I was referring to the sails-sql adapter for a PR.  We're ultimately still progressing sails-sql for the future of postgres developments so ideally these innovations will integrate best in that one.  As soon as the major release of sails-sql becomes certain, I will notify you asap of its postgres status for unix socket connections.

Thanks for the updated.  In the meantime, I'll be maintaining https://www.npmjs.com/package/sails-postgresql-redacted.

@alxndrsn I apologize for posting here...I was going to open an issue but they are disabled in your repo. Would you mind providing a configuration example for using a UNIX socket with your alternative adapter?

@DaAwesomeP thanks for asking :slightly_smiling_face:
I've enabled Issues on the repo: https://github.com/alxndrsn/sails-postgresql/issues, and added usage with sockets examples at https://github.com/alxndrsn/sails-postgresql#usage-with-unix-sockets

@chrismerkle I don't use SailsJS any more, so I don't know the current state of things.
I suspect the key change was https://github.com/alxndrsn/sails-postgresql/commit/bfac929f346737101749e8a12634f32210487418, which should allow use of a socketed connection created as per https://node-postgres.com/features/connecting#unix-domain-sockets.

@alxndrsn out of curiosity, what are you using now? I heard many were moving to Next.js and Vercel.

@Noitidart express + pg would be my recommendation :upside_down_face:

@Noitidart
I've been working for 3+ years with https://tsed.io
It's great framework with a big number of built-in features and it's very easily customizable for needs of your project.

Thanks guys!

@Noitidart we are moving to Next.js and Prisma ORM.

@alxndrsn thank you SO much for the reply. I appreciate you!

@alxndrsn it looks like the PG connection string just will not take the Unix socket, no matter how I try. Like many others, this is an issue when deploying to App Engine (GCP) and trying to use SQL (GCP). Even with all security and configuration set correctly, this style of connection within Sails.js simply will not connect. Happy to pay someone to help me figure this out.

@chrismerkle IIRC the problem previously was that sails would try to break down the connectionString into its constituent parts, and then supply those separately to pg.  At the time I filed this issue, I was using Google App Engine and Google Cloud SQL, and Sails's approach did not work for the unix sockets Cloud SQL provided to App Engine then.  I got it working with various patches applied, and used the sails-postgresql-redacted package for a couple of years.
Have you tried connecting from App Engine using pg directly?  What errors were you seeing there?

Thank you for the update @alxndrsn!
I finally got Sails.js to work today with GCP SQL. If you follow the tutorials from Google you have either Unix Sockets or TCP options to try -- and sadly neither work with out of the box sails-postgres.
My workaround was to connect via a VPC connector with a dedicated IP address. This way I can connect to Cloud SQL using a regular Postgres connection string, directly to the DB.
https://cloud.google.com/appengine/docs/legacy/standard/python/outbound-ip-addresses
Then I whitelisted the new dedicated IP in Cloud SQL security settings, and forced SSL to require valid SSL certificates.
It may not be best practice for now, but it works -- and that's one less ticket in the "To Do" queue :)


fix: [UPC-5751] Google WebRTC lib crash on Protect android app

Ticket
After tracing code back to Google WebRTC M103, the codes removed in this PR were made and deprecated by Google, so remove them.

@UI-RayanWang Can we still specify list of network interfaces which are allowed for WebRTC lib to use in iOS app ?

@UI-RayanWang Can we still specify list of network interfaces which are allowed for WebRTC lib to use in iOS app ?

Yes, changes in this PR won't affect our customization for allowing the specified network interfaces.


Bar charts: Code chart samples

Which page is this about?
Bar charts: https://cfpb.github.io/design-system/guidelines/bar-charts
What kind of issue is this?

[ ] Content enhancement
[ ] Needs code snippet

Describe your issue
Code the chart samples. They're currently static images.
We have a live demo page in chart builder at https://github.com/cfpb/cfpb-chart-builder/blob/master/test/index.html that may be useful for reference.
Related issues
https://github.com/cfpb/design-system/issues/996
https://github.com/cfpb/design-system/issues/997

#995, #997, #996 will be reworked as part of an internal data visualization project (tracked at [internal]/Design-Development/Design-and-Content-Team/issues)


Show all cards in a board

An interesting feature to add (at least for me it would be useful) might be to have the widget show all cards in a board, instead of just from a single list.  An intuitive way to fit this into the UI I believe would be to have an "All lists" option in the current lists menu when setting up the widget.
Also, I checked and the Trello API does have a call for getting all cards in a board (https://developers.trello.com/advanced-reference/board#get-1-boards-board-id-cards), so this shouldnt be to hard on an addition.

Is this something Trello itself lets you do in any way?

I'm not sure exactly what you mean. If it's regarding the API, there's a call that Trello provides that allows you to do that (linked in the original post). If it's regarding their interface, I suppose they do, since the standard view is to open a board and see all cards there (grouped by list of course, but you can still see all cards for that board).

I was regarding the UI because I don't think it would be very intuitive to have an entire board in one list. I understand your request but since Trello doesn't have this feature I don't think the widget should either. (You could just have multiple widgets to represent all of the board. This works best using a tablet)

Sure. The original widget has similar functionality, in that you can see all tasks assigned to you despite being on same or different cards. This would just be a generalization of that. This seems useful to me because, having many widgets in a phone is impractical, and you might just want to be able to have a glance at everything that is on a certain board, while using the full Trello interface for a more detailed breakdown of the separate lists. But it's just a suggestion, so feel free to discard it hahah

If I were to do something like this it would be more of a "create your own query" feature that is more general than just "all cards in a board". But no promises :) I'll leave this open for now.

yeah, that sounds pretty useful as well. no pressure hahah and thanks for the app in general, its pretty useful


fix(esl-note): fix broken connection between esl-note and esl-footnotes

Communication between notes and footnotes was broken during the last big PR.
This fixes the issue.
Also changed character for footnotes button "Return to note" due to its absence in fonts on some platforms.

:tada: This PR is included in version 3.0.0-beta.14 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Sometimes list-target job detects a target that contains extra trailing spaces.

tfaction version
v1.3.2
Overview
Sometimes, the list-target job detects targets with extra trailing spaces at the end.
I found that \n in the PR Body of the follow-up is sometimes treated as \r\n when I tried to reproduce it.
The newline code is \r\n, and even if  --> is excluded from the end of the first line of the PR Body, extra spaces remain.
How to reproduce
tfaction-root.yaml
plan_workflow_name: test
scaffold_working_directory:
  skip_adding_aqua_packages: true
target_groups:
- working_directory: one
  target: one

tfaction.yaml
{}

GitHub Actions Workflow
name: plan
on:
  pull_request:
    branches: [main]
env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
  TFACTION_IS_APPLY: "false"
permissions:
  id-token: write
  contents: read
  pull-requests: write
jobs:
  list-targets:
    runs-on: ubuntu-latest
    outputs:
      targets: ${{ steps.list-targets.outputs.targets }}
    steps:
    - uses<EMAIL_ADDRESS>    - uses<EMAIL_ADDRESS>      with:
        aqua_version: v2.25.1

    - uses<EMAIL_ADDRESS>      id: list-targets

Other related code such as local Registry

GitHub Actions' log
Run<EMAIL_ADDRESS>targets: [{"target":"one","runs_on":"ubuntu-latest","job_type":"terraform"},{"target":"one ","runs_on":"ubuntu-latest","job_type":"terraform"}]

PR comment
<!-- tfaction follow up pr target=one -->
@cappyzawa

Expected behaviour
It does not detect targets with extra trailing spaces at the end.
Actual behaviour
It detects targets with extra trailing spaces at the end.
Important Factoids
No response
Note
The job that confirmed that \r\n is included as a newline code is https://github.com/cappyzawa/tfaction-debug/actions/runs/8934424916/job/24541344967.

I created #1660 as one of the solutions to the problem.

Thank you for your report!
v1.5.0 is out 🎉
https://github.com/suzuki-shunsuke/tfaction/releases/tag/v1.5.0


[feat] Remove hard-coded paper size in printer configuration

Feature Request
The current Dogecoin Core Qt printer setup has a hard-coded page size of A4 (1.14.7-dev link to source code. For people with other paper sizes (letter, in the US, for example), this may render printable items slightly off the page.
Describe Preferred Solution
The ideal solution is to let Qt auto-detect the preferred page size. Qt suggests this may be possible in the QPrinter documentation:

A QPageSize instance may also be obtained by querying the supported page sizes for a print device. In this case the localized name returned is that defined by the printer itself. Note that the print device may not support the current default locale language.

Describe Alternatives
Alternately, we could prompt the user for a paper size.
I'm comfortable coding this myself, but I'd like to review the feature idea and suggested implementation with others before doing so. (I'm also happy to review a pull request if someone else wants to code it.)

Can this be closed? It seems the PR #3239 have fixed it.


fix: evaluate peer's parent

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

Fix evaluation score bug.

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report

Merging #1064 (58f525e) into main (3403d3b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   45.76%   45.76%
=======================================
  Files         129      129
  Lines        9546     9546
=======================================
  Hits         4369     4369
  Misses       4683     4683
  Partials      494      494

Flag
Coverage Δ

Object-compatibility-e2etests
?

e2etests
?

unittests
45.76% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

scheduler/scheduler/scheduler.go
86.71% <0.00%> (ø)

client/daemon/peer/peertask_conductor.go
57.16% <0.00%> (ø)


Can't filter for Kafka Configs in the navigator filter popup

For other types you can filter by type e.g. XSLT

Appears to be working in beta.35

Not working on a new b.37

is also missing SolrIndex, Rules

Was the browser cache!


Organization user login

[X] Check whether user is login at public or organization page. @juanignaciosl
[X] Org color column. @juanignaciosl
[X] Load "current organization". @juanignaciosl
[x] Look & feel. @xavijam

@saleiva, are we adding the name of the organization on purpose (in the top of the page)? or you added as part as the logo?

Is part of the logo

I'm thinking that the logo should be over white anyway... so I might need to adapt the design a bit...

I added a text-shadow, just in case background color is light

That will not work since most of the logos will be pngs or even jpgs. Go ahed with the actual design but we will likely have to change it soon

:+1:

No, but I thought in the design we had:
Logo (image) + organization name (text with shadow) + CartoDB logo (image)

Nope. It's only a logo plus an small log

@juanignaciosl, a bug I found, maybe my bad, in that case sorry :S.
STR:

Go to login page.
Click login button (yes, leave the password field empty).
Error ->

undefined local variable or method `login_org_avatar' for #<#<Class:0x000000075cec28>:0x00000009c5d128>

Look and feel added, but a review together @saleiva would be appreciated.

@xavijam can't reproduce the error, could you give me more details?

Which url are you using?
What username do you set?
Full error stack trace.
Have you reproduced it in staging?

Ha! Restarted my development server and working like a charm, so done! :)

Great, @xavijam , so some testing & merge? :-)

Yes and no, I have to take a look with @saleiva and then ready to go.


How to discover available C# Extension methods for and object

How does one discover the available extension methods for a particular object using VSCode?
Autocomplete does not show me the extension methods.

I found another plugin, that might help with this - I have not tested it yet though...
Called Auto Using...
https://marketplace.visualstudio.com/items?itemName=Fudge.auto-using

I believe @333fred is working on getting completion for unimported types in.

yes it's already merged, the option is omnisharp.enableImportCompletion to enable it.

Thanks FillipW,
I just checked my version of ms-dotnettools.csharp  and it is V1.23.1 , I do not see the omnisharp.enableImportCompletion
when I navigate to Settings.  Also by configuring my setttings.josn file to this did not work for me.
  "omnisharp.enableImportCompletion": true
Wondering if that merge is part of my version, has it been released yet?

it has not been officially released yet - it will be in the next release.
There is however a beta to try out https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.23.2-beta1
instructions to install the beta are here https://github.com/OmniSharp/omnisharp-vscode/wiki/Installing-Beta-Releases

Thank you for the update Filip.

closing as fixed in 1.23.2


Handle NSFW in Search

fixes the checkbox filter in search.
sets the NSFW filter to the user's default on the initial search.
uncomments out the showNSFW setting in settings/general.

Currently the NSFW filter in the OB1 search uses radio buttons. Once this PR is merged we'll switch it to be a checkbox.

@rmisio this is ready to go.
The OB1 search API isn't updated yet to have working checkboxes, you can wait to review this until then if you want. I would like to get this in for release so we can add the part that filters search by the user's nsfw setting automatically.

@rmisio the search API has been updated, and works the way this PR expects now.


Some question about find the minimum distance between virtual and real points

Hi, I go over your code in details recently, but in function add_virtual_mask, i find it compute the distance between a virtual point and all real point then select the minimum, ignore if the real point is in the same camera_id and same mask with the virtual point. I wonder that's a little unreasonable? Because it may use a real point's depth which is in other mask or even in other camera_id. Looking forward to your reply~

Sorry, now i see the methods you used to avoid the above situation! You multi a large number for the mask instance!

right, the implementation is a little hacky to avoid for loop :)


MB-14491 replace makeUser calls with new factory.BuildUser

Jira ticket for this change
Summary
This ticket replaces uses of testdatagen.MakeUser with the new factory.BuildUser in pkg/testdatagen/scenario/e2ebasic.go
Setup to Run Your Code

Run make server_test and make sure tests pass
Run make e2e_test and make sure tests pass

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Backend

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Messages

:book:
:link: MB-14491

  Generated by :no_entry_sign: dangerJS against e99ae75f9e6702a402de1815e4dd04020a74e28b


Security concern: controller and app data paths mixed together

Love Deis and we're trying to implement it for our App. My concern is that the controller and user traffic go through the same domain. So for example, the user path is myapp.example.com and control path is deis,example.com and the deis router looks at the subdomain to direct the traffic to the myapp or control plate.
I had expected that the control path would be separated in some way so that it might be isolated and not accessible outside the App firewall. Do others have this concern, and how do you address it?

Hey @nilnullzip, may I inquire what the security concern may be here? Authn/Authz is handled on the controller side of things, so users would have to be given an administrator's API key to do anything malicious on the platform side.

I'd be concerned about vulnerabilities in the API. For example:

https://groups.google.com/forum/#!msg/deis-users/pcHFIKl5ZFM/QEHTV2Dety8J
Better to minimize exposure to this kind of problem.

I'm a little uncomfortable with single factor keys. SSH is nice because it's two factor.

I think I'd rather have a single SSH entrypoint into a server from which we could manage things. Less ways to go wrong.

Sounds reasonable to be concerned about these things. How would you feel we could go about documenting this? I'm not too familiar with the workflow that you describe, but perhaps a design document on how you envision this type of feature (either with architectural or documentation changes) could get rolled out would be very helpful!

@bacongobbler Thanks for the followup! I'm not sure I know what to specify yet. I'm new to Deis. I'd be interested in hearing some views about this from those that are more knowledgeable before making a proposal.

We'll continue to handle vulnerabilities as they come in. I'm going to close this as it's way too broad of a scope to narrow down to an action item, but if you come up with something then we're all ears :)
Thanks!


Misleading error message when unsupported property is found

Hi Everyone,
I've a lot of errors from get_last_error() regarding to
"A MeshObject with triangle-properties is missing a default property" and error code 80bb.
I've found out the property is actually defined, but the library doesn't support it. I would like to understand how we can improve that to "property not supported" or a more appropriate message.
I've seen this happen when an object points to multiproperties and compositematerials. If you point me in the general direction, I might be able to contribute.

Hi @feliperoos ,
thanks for offering your help.
The typical problems (#38, this issue) currently result in two warnings during XML-parsing:

./Source/Model/Reader/v100/NMR_ModelReaderNode100_Resources.cpp, Line 112
Lib3MF creates a generic warning "NMR_ERROR_NAMESPACE_INVALID_ELEMENT" when it encounters a "multiproperties" or "compositematerials" and no object ressource (CModelResource) is created for such a property.

Once the XML-parser encounters such a propertyID as a default property in a mesh-object, lib3MF can't find it (since no CModelResource exists for it).
Thus, lib3MF raises a rather unspecific "NMR_ERROR_MISSINGDEFAULTPID" exception.

I suggest to

create two new warnings for the different properties in case 1.
distinguish between "no default PID is set" and "the property uses as default PID could not be found".
This will improve the situation a lot until we support multiproperties or compositematerials.
handle the exception "NMR_ERROR_MISSINGDEFAULTPID" in  Source/Model/Writer/v100/NMR_ModelWriterNode100_Mesh.cpp as a warning, rather than an error.

Could you give it a try, @feliperoos ? Happy to review any PR you submit.

Cool. Looking forward to the pull requests!
Not supported elements (e.g. a multiproperty) will not be written out again.
When the 3MF reader encounters such an item on import, a warning is issued (in most cases) or an error is returned by the reader. You can query the warning with lib3mf_reader_getwarning(...) , see e.g. SDK/Examples/Source/ExtractInfo.cpp).
If you set the reader to strict (lib3mf_reader_setstrictmodeactive(pReader, true)) all warnings will be considered errors and the import will be aborted.

Hey, @martinweismann, how about this. Along with the current warning mechanism, we create a "ModelUnsupported" child of ModelResource which has name only. Upon reading a resource we do not yet support, create it as ModelUnsupported. Even though we know we don't supported, it has to have an id and a name which can be handled by ModelReaderNodeUnsupported. We add that to the model like any other resource. That way, during the writing process, when querying for a PID which yields a ModelUnsupported element we can throw an exception with the correct offending element.
Let me know what you think about this. If that's fine, I can then go ahead and implement a solution.

Hi @feliperoos,
sorry for not coming back to you about your suggestion. lib3mf has changed a lot during the last 13 months.
While the main symptom, namely objects and triangles referencing to RessourceIDs of compositematerials and multiproperties, is resolved in v2, the underlying root cause, lib3mf's neglect of unknown elements in .3MF-files, is still a problem.
Your suggestion sounds very suitable. If you spare some time to contribute an implementation, I would love to review it!


Fix TO Go monitoring numeric values

Perl TO monitoring.json returns numeric types for parameters whose strings successfully convert to integers. This replicates that behavior.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/48/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/50/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/88/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/51/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/53/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/91/


Move freezeTableName so it doesn't need to be set on every model.

Not sure how you feel about this, but it seems very redundant to me having freezeTableName: true appear in every single model when it could just be set in the Sequelize connection constructor call.

Oh nice. Good call.


Read indicator for messages

Folks have been reaching out to know if their messages were read by the recipient. A PR addressing this issue should:

Add an indicator to the most recent sent message in the conversation screen based on if the associated notification was read.

I'm open to design ideas on this one, but to start it could be something as simple as a checkmark that when hovered says "Read at #{timestamp}".

@joemasilotti  Can I work on this?

Sure thing - all yours!
One more request - wrap the UI in a feature flag, please.

Hey @themudassarhassan, do you have any updates on this? Let me know if you still have appetite! No worries if not, I can pass it off to someone else.

Hey @joemasilotti. I do want to work on this but it may get delayed by one more week. I'll try to grab some time to work on this during this week, but if this is important you can surely assign it to someone else. Thanks!

All good - this isn't a super high priority task so another week is fine. Thanks for the update!
That said, I will want to pass this off to someone else if you don't get to it by then. Just to keep it fair to other contributors.

Hey, @joemasilotti You can assign this task to someone else, I have been very busy lately. Sorry for the blockage :(

All good! Thanks for the heads up.

I'd like to work on this @joemasilotti !

Awesome - all yours!

Closed via #485.


[CVAT-UI] Fixed AAM bug: #1750

Motivation and context
Fixes a bug reported by community and internal data annotation team
How has this been tested?
Manual testing
Checklist

[x] I submit my changes into the develop branch
[x] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] I have linked related issues (read github docs)
[x] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Resolve #1750
Resolve #1614

Pull Request Test Coverage Report for Build 5926

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.826%

Totals

Change from base Build 5911:
0.0%

Covered Lines:
10917

Relevant Lines:
16181

💛  - Coveralls


Swap logos in the Branding menu

Current Behavior
The "5" mark is displayed in the branding menu item.
Desired Behavior
The Meshery mark to be displayed instead, using the SVG of the Meshery logo and ensuring that both light and dark modes are supported.
Screenshots / Mockups

Contributor Guides and Resources

🎨 Wireframes and designs for Meshery Site in Figma
🖥 Contributing to Meshery Website
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Hey Lee, can I work on this?

Thanks! Assigning in chronological order...

@K0more, what happened here? Assignment given, but no follow through?


Update BigQuery credentials in Getting Started tutorial

Description & motivation
We are creating a technical task for Instructor candidates to join the Training team. We are piggybacking on Pro-Serve's interview task for Analytics Engineers, which points to the Getting Started tutorial as a way to setup a BigQuery account and connect a dbt project to it. I realized while reviewing the "Generate BigQuery Credentials" section that it was slightly out of date.

Remove the outdated Loom video of how to get BigQuery credentials. We could re-film this video, but I think the text instructions are clear enough and Google is constantly changing their UI so it would be hard to keep this video up-to-date.
Update the text instructions for how to download the JSON key from BigQuery.

Pre-release docs
Is this change related to an unreleased version of dbt?

[ ] Yes: please

update the base branch to next
add Changelog components: <Changelog>[New/Changed] in v0.x.0</Changelog>
add links to the "New and changed documentation" section of the latest Migration Guide

[x] No: please ensure the base branch is current
[ ] Unsure: we'll let you know!

Testing
Validated by creating a JSON key file in my Google Cloud Platform console (using my dbtlabs Google account). Used the key to successfully connect a dbt Cloud project to BigQuery. Was able to run queries and create models with dbt run.

Thank you @runleonarun for the suggestions! I love the commit suggestions feature. Much clearer now!


[Dubbo-shutdown gracefully]  fix shutdown gracefully.

What is the purpose of the change

fix jvm shutdown gracefully bug, including annotation bean and server running state error. see: https://github.com/apache/incubator-dubbo/issues/1606

Brief changelog

com.alibaba.dubbo.remoting.exchange.support.header.HeaderExchangeServer#close(int), solve the problem of the dubbo unable to sleep thread.
com.alibaba.dubbo.config.spring.AnnotationBean#destroy，solve the use of annotations can not elegantly stop the scene.

Verifying this change

DubboInvokerAvilableTest#test_normal_channel_close_wait_gracefully

Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #1607 into master will increase coverage by 0.01%.
The diff coverage is 14.28%.

@@             Coverage Diff              @@
##             master    #1607      +/-   ##
============================================
+ Coverage     34.53%   34.55%   +0.01%
  Complexity     3684     3684
============================================
  Files           621      621
  Lines         30875    30865      -10
  Branches       5448     5447       -1
============================================
+ Hits          10663    10664       +1
+ Misses        18374    18360      -14
- Partials       1838     1841       +3

Impacted Files
Coverage Δ
Complexity Δ

.../exchange/support/header/HeaderExchangeServer.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...om/alibaba/dubbo/config/spring/AnnotationBean.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

.../java/com/alibaba/dubbo/config/ProtocolConfig.java
34.02% <100%> (+2.27%)
39 <0> (ø)
:arrow_down:

...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java
51.89% <0%> (-3.8%)
11% <0%> (-2%)

.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java
74.07% <0%> (-1.86%)
7% <0%> (ø)

...bo/remoting/transport/netty/NettyCodecAdapter.java
53.12% <0%> (-1.57%)
3% <0%> (ø)

...baba/dubbo/remoting/transport/mina/MinaClient.java
59.37% <0%> (+1.56%)
9% <0%> (+1%)
:arrow_up:

...ba/dubbo/remoting/transport/netty/NettyServer.java
70.9% <0%> (+3.63%)
9% <0%> (+1%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65c9e2...986e743. Read the comment docs.


build: merge superset-ui-plugins repo

🏆 Enhancements
Try to merge super-ui-plugins with superset-ui so working across plugins and core packages can be easier.

You could also create a feature branch and test migrating 1-2 projects at a time into the feature branch. There might be some linting rules disabled in the plugins repo that have to be addressed while migrating

You could also create a feature branch and test migrating 1-2 projects at a time into the feature branch. There might be some linting rules disabled in the plugins repo that have to be addressed while migrating

Good call on migrating only a couple of projects first. I think I also wanted to see how long does it take to build all packages and what are the potential errors I need to address.

The build was successful on Zeit: https://superset-ui-primsoqng.now.sh/


Fix ConsoleSetupHandler overwriting Job.BacktestId

Description
A few minor changes have been made to ConsoleSetupHandler:

the job.BacktestId property is no longer overwritten by the algorithm class name
a few unnecessary assignments have been removed
a missing null check has been added

Related Issue
Closes #2472
Motivation and Context
Inconsistency between ConsoleSetupHandler and BacktestingSetupHandler.
Requires Documentation Change
No.
How Has This Been Tested?
Local debugging.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description or feature-<issue#>-<description>

Very nice, thank you!


Recruitment page remodelled

added jenny's recruitment page to the join us section.

looks like the reason the video wasn't playing was because mp4 isn't supported on a number of browsers. I changed it to webm. still wont work on opera, but no one uses opera

Also, jenny wanted the join section to stand alone instead of inline with the rest of the page, so I moved it out.

I’ll check tomorrow sometime. This deploy preview thing is nice but I don’t see the video on mobile safari. Bout to take off :)

ahh.. looks like safari also doesn't support webm.

bye!


Slider with grey background

Hi, I'm trying to add an image slider to my page but all I get is a grey background in both full screen and normal display.
I used the source code and the jQuery init showed on the Materialize examples and images are correctly loaded since i can see them if I inspect the page.

Have you checked your file permissions/ownership?

What files are you referring to? If you mean the project files then yes, I'm the creator and owner of them.

I'm facing the same problem, I just downloaded the latest version of materialize, and I can't figure out the solution for that grey background

Have you both initiated the slider in your js file?

Yes I did.

This is part of my init.js file
(function($){
  $(function(){

   // The rest above this is hidden

   $('.slider').slider();

  }); // end of document ready
})(jQuery); // end of jQuery name space

This is my code:

Copy this and try it again
(function($){
  $(function(){

   // The rest above this is hidden

   $('.slider').slider();

  }); // end of document ready
})(jQuery); // end of jQuery name space

Mmm I already did that, and the same grey background keeps appearing.
-.-?

Have a look at my example -
(function($){
  $(function(){

   // The rest above this is hidden

   $('.slider').slider();

  }); // end of document ready
})(jQuery); // end of jQuery name space

and your example -

  $(function(){

   $('.slider').slider({full_width: true});

  }); // end of document ready

Notice the difference? You have left out this, this will ensure you don't have to add the script tags.  just before the end body tag. See what I mean?-
(function($){

   //your code in here

  // End Document Ready
}) (jQuery); // End of jQuery name space

Yeah I know, I already copy the code exactly as yours, and isn't working, I just started the project, I don't have anything but the code for the slider, I can't see what is wrong.

Shall I do a screen record for you to show you I did it?

This just happened to me, because I ran .slider() twice. As far as I can see, the slider takes the src attribute and puts this in a css background. The second time, the src attribute is empty(-ish), and can't set this to the background image.

Also ran into this issue, followed the suggestion from @jvv and sure enough $('.slider').slider() was being called twice. Fixed the problem for me.

$('.slider').slider() initialization should be added into the materialized css documentation or else someone wouldn't take note of that.

Like: http://materializecss.com/media.html?
On Nov 23, 2015 23:03, "BELLO MUSA"<EMAIL_ADDRESS>wrote:

$('.slider').slider() initialization should be added into the materialized
css documentation or else someone wouldn't take note of that.
—
Reply to this email directly or view it on GitHub
https://github.com/Dogfalo/materialize/issues/872#issuecomment-159079699
.

Hey I know its been a long time since the question is posted but I've just got the same issue with the gray screen. I was literally copy pasting the example in the materialize library. Then I tried to downgrade the materialize. Just to be clear there are no errors in the console, I was trying to run it on plnkr. In my case I was also referring to jqueryUI which script reference was under materialize. When i moved it on top to load first before materialize script it was fine. Hope it helps to someone because it's pretty fucked up bug :D Correction : And now the jQueryUI which I'm using for animations is not working at all and fails silently

It can't be used at all combined with JQueryUI


Separate the configuration and data directories

Summary
The current configuration directory contains much more than just configuration, such as the logs and the SQLite database. This makes it hard to distinguish between the two, and hinders efforts to work towards deployed configuration, or even read-only configuration (a potential future feature).
Proposal & scope
Separate configuration and instance-specific data/content into different directories. This applies solely to storage targets, and does not encompass any changes in Home Assistant's behavior. For backwards compatibility with existing installations, the content storage directory can default to the configuration storage directory, if the newer, specific content storage directory does not exist.

This would be better as an issue in the architecture repo: https://github.com/home-assistant/architecture


[PKG] OpenAL Soft

Package name
OpenAL Soft
Package URL
https://github.com/kcat/openal-soft
Package source location
https://openal-soft.org/

This package had been publish to my maven repository hosted on github https://github.com/leleliu008/ndk-pkg-prefab-aar-maven-repo
You’re welcome to give it a try.


can i get the real time angle of the handle?

Hi ThunderStruct, thanks for the great component.
Wondering if this component could get the real time angle or position (x,y)?
I tried to use slider.handle.angle / slider.handle.position - but both return 0.0 eventhough my handle was pointed in mid of the slider.
Thanks,
SK

Hi SK!
Appreciate your feedback!
If I understand you correctly, you want to read the handle's angle as you move it. You can do so by conforming to the MSCircularSliderDelegate protocol and using the method circularSlider(MSCircularSlider, valueChangedTo, fromUser), which gets called continuously as the value changes.
Refer to the example project (SliderPropertiesVC.swift lines 107-109 specifically). Don't forget to set slider.delegate = self!

Hi ThunderStruct,
Thanks so much for your prompt reply. It works now and really appreciated your help.
Thanks,
SK

Hi SK!
You're very welcome. Glad I could help out. :-)
Good luck!


give the option to read the README.md on spanish

created a new README.md file on lang/spanish/.
That .md is a spanish version of the main README

Thank you, but I'm going to have to close this because I can't keep the Spanish version updated.


Cranelift: Verifier error when unused jump table references unused block

What are the steps to reproduce the issue? Can you include a CLIF test case,
ideally reduced with the bugpoint clif-util command?

test compile
target x86_64

function u0:325() system_v {
    jt0 = jump_table [block1]

block0:
    return

block1:
    trap unreachable
}

What do you expect to happen? What does actually happen? Does it panic, and
if so, with which assertion?

I expected the function to compile. Either by keeping block1 or removing jt0. Instead it gives:
FAIL verifier_error.clif: compile

Caused by:
    function u0:325() system_v {
        jt0 = jump_table [block1]
    ;   ^~~~~~~~~~~~~~~~~~~~~~~~~
    ; error: jt0: invalid block reference block1

    block0:
        return
    }

    ; 1 verifier error detected (see above). Compilation aborted.

1 tests
Error: 1 failure

Which Cranelift version / commit hash / branch are you using? c07ec4c525318afb47b2c6ff24dcddb5d23b5f2a
If relevant, can you include some extra information about your environment?
(Rust version, operating system, architecture...) N/A

I found this while trying to debug https://github.com/bjorn3/rustc_codegen_cranelift/issues/1142 by the way. That issue is a problem on my side, but this bug doesn't help with debugging.


Update scalajs-dom to 2.7.0

About this PR
📦 Updates org.scala-js:scalajs-dom from 2.2.0 to 2.7.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

🔍 Files still referring to the old version number
The following files still refer to the old version number (2.2.0).
You might want to review and update them manually.
app/package-lock.json

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-js", artifactId = "scalajs-dom" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-js", artifactId = "scalajs-dom" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, old-version-remains, commit-count:1

Superseded by #11.


[Android] React native views not arranged properly inside custom ViewGroup

Is this a bug report?
Yes

Have you read the Contributing Guidelines?
Yes
Environment

react-native -v: 0.48.3
node -v: v8.4.0
npm -v: 5.4.1
yarn --version: 0.21.3

Then, specify:

Target Platform: Android

Development Operating System: macOS

Build tools: Android studio

Steps to Reproduce

Example: Create a LinearLayout native UI component.
public class RNLinearLayoutManager extends ViewGroupManager<LinearLayout> {

    @Override
    public String getName() {
        return "RNLinearLayout";
    }

    @Override
    protected LinearLayout createViewInstance(ThemedReactContext reactContext) {
        LinearLayout layout = new LinearLayout(reactContext);
        layout.setOrientation(LinearLayout.VERTICAL);
        return layout;
    }

}

const LinearLayout = requireNativeComponent('RNLinearLayout', {
  name: 'LinearLayout',
  propTypes: {
    ...View.propTypes
  }
}, {
  nativeOnly: {
    nativeBackgroundAndroid: true,
    nativeForegroundAndroid: true
  }
})

export default class RNTest extends Component {
  render() {
    return (
      <LinearLayout style={{flex: 1}}>
        <Text>Linear Layout demo</Text>
        <Text>The below view should be arranged in a row</Text>
        <View style={{flexDirection: 'row', flex: 1}}>
          <Text>Column 1</Text>
          <Text>Column 2</Text>
        </View>
        <Text>But it is arranged in two different rows</Text>
      </LinearLayout>
    );
  }
}

Expected Behavior

Text Column 1 and Column 2 should be arranged in same line as shown above
Actual Behavior

Text Column 1 and Column 2 were arranged in 2 lines
Reproducible Demo

https://github.com/rsreejithkrishnan/RNLinearLayoutTest

@facebook-github-bot label Android


Export improvements

First of all, sorry about my english (I'm from Uruguay).
I have been using this project for a few days now and it has helped me a lot.  To adjust the project to my needs I made some changes in the code. The changes are:

verify that values of the variables are right
use meeting ID as default export name
use real duration of the recording as default duration value
catch "URL unreachable" error
verify that recording exists

Thank you so much!


Master is failing

The master is failing and as a result, I cannot use it currently. I think master should never fail.
I would suggest we create a 'develop' branch to handle all CI issues and revert the master back to the last working version.
For features such as adding documentation and sphinx, these would then be branched from develop.

Done this now, with the build once again passing.


Consider integrating all the Doxygen documentation to a single page.

Currently we have separate pages for each library:
https://googlecloudplatform.github.io/google-cloud-cpp/latest/storage/
https://googlecloudplatform.github.io/google-cloud-cpp/latest/bigtable/
https://googlecloudplatform.github.io/google-cloud-cpp/latest/firestore/
We should consider a single page where all the documentation is grouped together.  I think the other languages do that.

@mbrukman @ghaisa @sduskis @houglum I would be interested in your thoughts about this.
@frankyn or @sduskis we should probably loop some of the Cloud Client Libraries folks into this, can you @-mention them in this bug some they can chime in?  Thanks!

@JustinBeckwith thoughts?

Greetings!  We do generally try to put all the reference API documentation on a single site that's easily acessible.  Right now it's kind of confusing, as this page only calls out BigTable.
Is this something doxygen will let you do easily?

Once we have moved some of the code around merging the Doxygen stuff should be easy.

Raised in Client library weekly. Agree with Justin it's a good idea to have a single page that links to all documentation pages and the pattern is used by the other client libraries as well.

I have a branch with this implemented, the preview of the pages is here:
https://coryan.github.io/google-cloud-cpp/latest/html/index.html
Will send PR when the tests pass.

Sounds reasonable to me, as long as we can keep the docs structure of "google/cloud//doc/..." (and if not, at least have a README under that directory linking to the correct location).  This is where I'd expect to find docs for each library, personally.

Feedback:
Namespaces

BigTable and Storage aren't under a namespace
Storage shouldn't be there yet?

Landing page

I only see BigTable and not Firestore

Related Pages

Can you rename the title to Examples?

Files Page

Contains information on Storage library which I think should be removed.

Namespaces
BigTable and Storage aren't under a namespace

Because the classes are not, not yet: #652, #629

Storage shouldn't be there yet?

Easy enough to remove, but the code is on the master branch, so I would rather see it exposed in the documentation for it.

Landing page
I only see BigTable and not Firestore

We should create one: #657.

Related Pages
Can you rename the title to Examples?

According to stackoverflow yes, but what if we have other stuff there later?  Tutorials, or something else?  Anyway: #658.

Files Page
Contains information on Storage library which I think should be removed.

See above, I would rather have the current documentation reflect the actual code that folks will download.

cc: @theacodes

I would hold off on any work here until our documentation plan is finalized.

@coryan, can you block for now?

Sure, I am really efficient at "not working". Please note that the documentation is automatically generated and pushed to github.io (here, and here) on each commit to master.

Cool. Totally fine with charging ahead on the docs for individual packages, I just wouldn't sink too much time into making them all be one big giant docset.

@theacodes @JustinBeckwith @frankyn have you finalized your documentation plan? Can I work towards fixing this issue or is it still too early?

@theacodes is out, we will need to wait until she's back to get more information.

Apologies, I let this one slip through the cracks.
@theacodes, do you mean keeping cloud.google.com docs and Doxygen docs separated OR not merging all client libraries as a single Doxygen docset to make it easier to integrate into cloud.google.com?

both.

do you mean keeping cloud.google.com docs and Doxygen docs separated

yes.

not merging all client libraries as a single Doxygen docset to make it easier to integrate into cloud.google.com?

yes.

ty!

@tmatsuo I take it that your design makes this feature request obsolete and we should then close it?

Yeah, I think we can close this now, but let me clarify. What was the original motivation for merging the sub components?

As of today, we do not have a generalized strategy for language focused landing pages.  @theacodes is working on a roadmap for googleapis.dev, where I would expect this to be a little more solidified :)

I am going to close this, I am not sure it serves any purpose anymore. When we have a better plan for documentation in googleapis.dev we are reopen this or open the right bugs.


Zerion prices migration POC (Alternative 1)

This PR aims to retrieve all the user balances from Zerion API. Many changes have been implemented:

/balances endpoint from Transaction Service won't be called anymore, so all the related code (data-source functions, entities, etc.) have been removed from the project.
Exchange API dependency and functions are also removed since there is no need for currency conversions in the CGW.
Zerion API data-source and repository are implemented.
Tests are modified accordingly.
Cache is modified to save references to complete portfolios/positions instead of saving the balances coming from the Transaction Service. Hooks have been modified accordingly.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

58 of 101 (57.43%)  changed or added relevant lines in 11 files are covered.
17 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-1.6%) to 90.887%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/datasources/cache/cache.router.ts
5
8
62.5%

src/domain/portfolios/entities/tests/portfolio.builder.ts
6
10
60.0%

src/domain/portfolios/entities/tests/position.builder.ts
7
12
58.33%

src/domain/portfolios/portfolios.repository.ts
7
15
46.67%

src/routes/balances/balances.service.ts
5
16
31.25%

src/datasources/portfolios-api/portfolios-api.service.ts
15
27
55.56%

Files with Coverage Reduction
New Missed Lines
%

src/datasources/exchange-api/exchange-api.service.ts
1
94.44%

src/domain/exchange/exchange-rates.validator.ts
1
88.89%

src/routes/balances/balances.controller.ts
1
90.0%

src/datasources/cache/cache.router.ts
2
83.95%

src/routes/balances/balances.service.ts
3
33.33%

src/domain/exchange/exchange.repository.ts
9
45.83%

Totals

Change from base Build<PHONE_NUMBER>:
-1.6%

Covered Lines:
4350

Relevant Lines:
4662

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

108 of 110 (98.18%)  changed or added relevant lines in 11 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 91.871%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/datasources/cache/cache.router.ts
7
8
87.5%

src/routes/balances/balances.service.ts
25
26
96.15%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
2
80.0%

src/datasources/cache/cache.router.ts
4
84.34%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
4516

Relevant Lines:
4791

💛  - Coveralls

Closing this POC PR as it won't be merged in the near term.


PR to fix bug fix file validity bug and update branch with current status of feature branched

what Does This PR Do?
This PR is a duplicate of feature//search-all-functionality  branch but adds fix for bug found in file validity in that branch.
Description Of Task To Be Completed?
All feature branches are merged into this PR, this PR then allows, User to upload a file, checks for file validity, change view, generate index, search a particular file or search all files.
How Should This Be Manually Tested?

Open your terminal.
Clone this repo: git clone https://github.com/andela-iamao/inverted-index.git
Navigate to the folder: cd inverted-index
Install the dependencies: npm install
Run tests(optional): npm test
Start the server: npm start

Any Background Context You Want To Provide?
N/A
What are the relevant pivotal tracker stories?

Fix validity issues
User should be able to see a dropdown when they upload
generate index for valid json file
User should be able to search for keywords in index
Add search all functionality

Changes Unknown when pulling eaa785e39bb084d573fa13549f689f2b44d739bb on bug/141397621/fix-validity into ** on development**.

Changes Unknown when pulling 85081df40f93f1228db5a107ad3b005f9140dd00 on bug/141397621/fix-validity into ** on development**.

Changes Unknown when pulling 00a4c3793f5c178fc1f462eb7537577bfd2713e2 on bug/141397621/fix-validity into ** on development**.

Changes Unknown when pulling 713e0a1b5d3d423375b47c6924076781c0a757a1 on bug/141397621/fix-validity into ** on development**.


IOS Orientation

Hi!
I am running your demo app on a physical IPhone and am not able to get the RTMP stream to switch from portrait to landscape.
I really just need the stream to in landscape.
Not sure if this is a bug or intended.

Getting the same issue here. Tried manually setting up orientation switching through the HaishinKit and had no luck.

Weird I did get it to switch.  It sticks on one orientation once you start
though
On Tue, Aug 4, 2020, 4:07 PM sbruler<EMAIL_ADDRESS>wrote:

Getting the same issue here. Tried manually setting up orientation
switching through the HaishinKit and had no luck.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pinkfish/flutter_rtmppublisher/issues/24#issuecomment-668870184,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AATOMMJLZJA47P3XFGXGLFLR7CIEFANCNFSM4PK7TQZQ
.

Weird I did get it to switch. It sticks on one orientation once you start though
…
On Tue, Aug 4, 2020, 4:07 PM sbruler @.***> wrote: Getting the same issue here. Tried manually setting up orientation switching through the HaishinKit and had no luck. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#24 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATOMMJLZJA47P3XFGXGLFLR7CIEFANCNFSM4PK7TQZQ .

Can you share how you configured it? Maybe I'm approaching it incorrectly.

I was able to get the web player to force portrait mode by setting these values in the FlutterRTMPStreaming.swift file.

@objc
    public func addVideoData(buffer: CMSampleBuffer) {
        if let description = CMSampleBufferGetFormatDescription(buffer) {
            let dimensions = CMVideoFormatDescriptionGetDimensions(description)
            rtmpStream.orientation = .landscapeLeft
            rtmpStream.videoSettings = [
                .width: 1920,
                .height: 1080,
                .profileLevel: kVTProfileLevel_H264_Baseline_AutoLevel,
                .maxKeyFrameIntervalDuration: 2,
                .bitrate: 1200 * 1024
            ]
            rtmpStream.captureSettings = [
                .fps: 24
            ]
        }
        rtmpStream.appendSampleBuffer( buffer, withType: .video)
    }

But I was not able to get the actual IOS camera to rotate to landscape mode, it is stuck in portrait and the end result is a cropped view of the landscape camera preview.
This is a (rotation) locked view.

This is a (rotation) free view.

This is the end result in both cases, even after restarting the app and starting in either orientation.

Any help from either of you with this issue would be greatly appreciated.

This issue is pretty serious for me.  I've been trying to debug the code myself, but previewQuarterTurns is often null (maybe always?) and doesn't affect preview rotation on iOS anyway.  Android seems to work fine.
Glad to chip in a few bucks to get this prioritized:)

Part of the problem is in RtmppublisherPlugin.m (ios code):
connection.videoOrientation = AVCaptureVideoOrientationLandscapeLeft; //AVCaptureVideoOrientationPortrait;

i swapped in a hard-coded landscape value for the AV capture, but now both the preview and broadcast dimensions are screwed up.

@burtonmiller Just wanted to check in and see if you ever found a solution for this?

Take it nothing has changed here?

Anyone found the solution or workaround for this issue? (iOS RTMP stream always in portrait mode, android works fine).


[AutoPR consumption/resource-manager] Above-Subscription Level Marketplace and Usage Detail, and Enrollment Level Balances

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2857

(message created by the CI based on PR content)


Sprite mesh

New Material and derivative of Mesh3D for rendering sprites
reasons:

Sprite3D implementation had some issue when drawing over 3d objects in the scene
I was attempting to create a billboard particle emitter and sprite3d wasn't able to render as expected

new SpriteMesh

old sprite3D

this PR also includes a modified version of the standard shader's render method in sprite-shader.ts which I believe could be an improvement able to be made to the render method in the standard shader

  render(mesh: Mesh3D, renderer: Renderer, state: State, drawMode: DRAW_MODES) {
    if (mesh.instances.length > 0) {
      const filteredInstances = mesh.instances.filter((instance) => instance.worldVisible && instance.renderable);
      if (filteredInstances.length === 0) {
        //early exit - this avoids us drawing the last known instance in the instance buffer
        return;
      }
      this._instancing.updateBuffers(filteredInstances, true)
    }
    super.render(mesh, renderer, state, drawMode)
  }

Hello! Whoa - this is a big PR :-)
It will take while for me to go through all of this, but just some initial questions:

Wouldn't it be better to try to fix Sprite3D than creating a completely new one? It will be a bit weird for the users to have two different API's to render 3D sprites.
Did you do any performance tests vs Sprite3D?
Just to double check, you want render 3D sprites in front and behind another 3d object and everything should look correct?

It may even be that what you want is already supported but is not so clear how it works. Try render the cube before rendering the sprites.

Hello! Whoa - this is a big PR :-)
It will take while for me to go through all of this, but just some initial questions:

Wouldn't it be better to try to fix Sprite3D than creating a completely new one? It will be a bit weird for the users to have two different API's to render 3D sprites.
Did you do any performance tests vs Sprite3D?
Just to double check, you want render 3D sprites in front and behind another 3d object and everything should look correct?

Hey there,
Will check this over Monday, the idea was to have a billboard sprite that could be used for a particle emitter in a scene, as far as I remember when testing, performatively thousands of sprite3D was worse than thousands of instanced meshes

It may even be that what you want is already supported but is not so clear how it works. Try render the cube before rendering the sprites.

Will check this also on Monday, could you explain further how you would ensure the cube was drawn before the sprite3D in your screenshot?

I did some test to be able to have more control over draw order with sprites and meshes. See PR https://github.com/jnsmalm/pixi3d/pull/112
Maybe you can test that branch and see if it work the way you expect?
The method used now is PixiJS's own method to batch sprites depending on state/texture and a bunch of stuff to have the best performance. But it would be interesting to compare it to the instancing method you have.

Will check this also on Monday, could you explain further how you would ensure the cube was drawn before the sprite3D in your screenshot?

Just have the mesh before the sprites in the container hierarchy. You could also use container.sortChildren = true and use zIndex to control drawOrder.

Will check this also on Monday, could you explain further how you would ensure the cube was drawn before the sprite3D in your screenshot?

Just have the mesh before the sprites in the container hierarchy. You could also use container.sortChildren = true and use zIndex to control drawOrder.

I did some test to be able to have more control over draw order with sprites and meshes. See PR #112
Maybe you can test that branch and see if it work the way you expect?
The method used now is PixiJS's own method to batch sprites depending on state/texture and a bunch of stuff to have the best performance. But it would be interesting to compare it to the instancing method you have.

After bumping the instances running to around 5k Sprite3D appears to be performing better across multiple browsers (specifically after an inclusion of the billboard sorting method, as without this the sprites still have the draw issue)
My only real issue with Sprite3D's rendering is inability to seperate its render order from its hierarchal placement, if sprite had a renderSortOrder akin to mesh3D maybe this would make more sense?

Much Better performance coming out of Sprite3D using the abstract batch rendering process - only issue I can see with this currently is separation of render order compared to Mesh3D. (This will lead to issues rendering transparent meshes)

Much Better performance coming out of Sprite3D using the abstract batch rendering process - only issue I can see with this currently is separation of render order compared to Mesh3D. (This will lead to issues rendering transparent meshes)


UI testing

Reduce future bugs
Maintain stable state easily

Hey! I noticed not long ago that although the UICollectionView refreshing bug is fixed, the page view tab which contains the title will refreshes itself still, is this working as intended?

Hi @wraithseeker.
This issue is about UI Testing support by Xcode7. If you find some existing bugs, please open as a new issue.
It would be great if you could mention both what's your problem and what you expected.


Can't Install on Mac (10.11.4) running Rakudo Star 2016.04

Digest::HMAC can't be installed using
sudo panda --prefix=/Applications/Rakudo/share/perl6/site/bin/ --force install Digest::HMAC
However, Digest itself is installed.
Any advice would be appreciated.

Are you getting any error messages when you attempt to install it?


feat(cli): add version command

Adds a basic command to the CLI to get the version

Hey Ryan, thanks for your contribution! We indeed like the idea! I took the liberty to change it a bit and use the de-facto standard way of <cmd> --version.
And, besides that, use the polkadot-api version, not the CLI one.
Thanks!


[RuneQuest Glorantha]

I cannot seem to add the bonus to spirit combat damage for assistant shaman (+1) and shaman (+3).
I'm I missing something or has this not been implemented?
If not implemented please view this as a feature request.
Many thanks.

This has been added so this can be closed