Azure Resource Manager Template server crashed - Language Server Error

Repro steps:

Open VS Code
Open a ARM File

Action: Language Server Error
Error type: Error
Error Message: The connection to the ARM Template Language Server got closed.
Version: 0.8.2
OS: darwin
Product: Visual Studio Code - Insiders
Product Version: 1.41.0-insider
Language: en

Call Stack
extension.bundle.js:218:745913
Object.t.callWithTelemetryAndErrorHandlingSync extension.bundle.js:1:217466
WrappedErrorHandler.closed extension.bundle.js:218:745781
LanguageClient.handleConnectionClosed vscode-languageclient/client.js:2044:55
LanguageClient.handleConnectionClosed vscode-languageclient/main.js:127:15
closeHandler vscode-languageclient/client.js:2023:18
CallbackList.invoke vscode-jsonrpc/events.js:62:39
Emitter.fire vscode-jsonrpc/events.js:120:36
closeHandler vscode-jsonrpc/main.js:226:26
CallbackList.invoke vscode-jsonrpc/events.js:62:39
Emitter.fire vscode-jsonrpc/events.js:120:36
StreamMessageReader.fireClose vscode-jsonrpc/messageReader.js:111:27
Socket.<anonymous> vscode-jsonrpc/messageReader.js:151:46
Socket.emit events.js:205:15
Pipe.<anonymous> net.js:586:12

Error from the Log :
Unhandled Exception: System.AggregateException: One or more errors occurred. (An exception was thrown while initializing part "Microsoft.WebTools.Languages.Json.Arm.Schema.ArmCachingJsonDocumentLoader".) ---> Microsoft.VisualStudio.Composition.CompositionFailedException: An exception was thrown while initializing part "Microsoft.WebTools.Languages.Json.Arm.Schema.ArmCachingJsonDocumentLoader". ---> System.UnauthorizedAccessException: Access to the path '/Users/rupanterchhabra/.local/share/Microsoft/ARMLanguageServer/Schemas/JSON' is denied. ---> System.IO.IOException: Permission denied
--- End of inner exception stack trace ---
at System.IO.FileSystem.CreateDirectory(String fullPath)
at System.IO.Directory.CreateDirectory(String path)
at Microsoft.WebTools.Languages.Json.Schema.Cache.JsonSchemaCache..ctor(String userDataSchemaPath)
at Microsoft.WebTools.Languages.Json.Arm.Schema.ArmCachingJsonDocumentLoader..ctor(ILanguageHost host)
--- End of inner exception stack trace ---
at Microsoft.VisualStudio.Composition.RuntimeExportProviderFactory.RuntimeExportProvider.RuntimePartLifecycleTracker.CreateValue()
at Microsoft.VisualStudio.Composition.ExportProvider.PartLifecycleTracker.Create()
at Microsoft.VisualStudio.Composition.ExportProvider.PartLifecycleTracker.MoveNext(PartLifecycleState nextState)
at Microsoft.VisualStudio.Composition.ExportProvider.PartLifecycleTracker.MoveToState(PartLifecycleState requiredState)
at Microsoft.VisualStudio.Composition.ExportProvider.PartLifecycleTracker.GetValueReadyToExpose()
at Microsoft.VisualStudio.Composition.RuntimeExportProviderFactory.RuntimeExportProvider.<>c__DisplayClass15_0.b__0()
at Microsoft.VisualStudio.Composition.RuntimeExportProviderFactory.RuntimeExportProvider.GetValueForImportElement(RuntimePartLifecycleTracker importingPartTracker, RuntimeImport import, RuntimeExport export, Func3 lazyFactory)    at Microsoft.VisualStudio.Composition.RuntimeExportProviderFactory.RuntimeExportProvider.GetValueForImportSite(RuntimePartLifecycleTracker importingPartTracker, RuntimeImport import)    at Microsoft.VisualStudio.Composition.RuntimeExportProviderFactory.RuntimeExportProvider.RuntimePartLifecycleTracker.<CreateValue>b__10_0(RuntimeImport import)    at System.Linq.Enumerable.SelectIListIterator2.ToArray()
at System.Linq.Enumerable.ToArray[TSource](IEnumerable1 source)    at Microsoft.VisualStudio.Composition.RuntimeExportProviderFactory.RuntimeExportProvider.RuntimePartLifecycleTracker.CreateValue()    at Microsoft.VisualStudio.Composition.ExportProvider.PartLifecycleTracker.Create()    at Microsoft.VisualStudio.Composition.ExportProvider.PartLifecycleTracker.MoveNext(PartLifecycleState nextState)    at Microsoft.VisualStudio.Composition.ExportProvider.PartLifecycleTracker.MoveToState(PartLifecycleState requiredState)    at Microsoft.VisualStudio.Composition.ExportProvider.PartLifecycleTracker.GetValueReadyToExpose()    at System.Lazy1.ViaFactory(LazyThreadSafetyMode mode)
at System.Lazy1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)    at System.Lazy1.CreateValue()
at Microsoft.VisualStudio.Composition.ExportProvider.<>c__DisplayClass70_12.<GetExports>b__1()    at System.Lazy1.ViaFactory(LazyThreadSafetyMode mode)
at System.Lazy1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)    at System.Lazy1.CreateValue()
at Microsoft.ArmLanguageServer.Program.MainAsync(String[] args) in //Microsoft.ArmLanguageServer/Program.cs:line 50
--- End of inner exception stack trace ---
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at Microsoft.ArmLanguageServer.Program.Main(String[] args) in //Microsoft.ArmLanguageServer/Program.cs:line 33
[Error - 4:35:21 PM] Connection to server got closed. Server will not be restarted.

Tried checking the folder at the location it's trying to find :
'/Users/rupanterchhabra/.local/share/Microsoft/ARMLanguageServer/Schemas/JSON' is denied. ---> System.IO.IOException: Permission denied
The folder doesn't exist :
PS /Users/rupanterchhabra/.local/share> ls
powershell
PS /Users/rupanterchhabra/.local/share>

Have tried uninstalling and re-installing the Extension.

@Rupanter Chhabra This should have been fixed in version 0.8.0.  I’ve verified it successfully creates the folders for me on 0.8.2.  You said you tried creating the folders manually.  Did it successfully create the folder?
I.e., open the “terminal” app and try this:
mkdir -p /Users/rupanterchhabra/.local/share/Microsoft/ARMLanguageServer/Schemas/JSON
Is the folder successfully created?  Does the extension work at that point?
Thx,
Stephen

@StephenWeatherford
I tried creating the folders manually and it didn’t work.
One thing to note is, I couldn’t create using the normal cmd :
mkdir -p /Users/rupanterchhabra/.local/share/Microsoft/ARMLanguageServer/Schemas/JSON
Rupanters-MBP:share rupanterchhabra$ mkdir -p /Users/rupanterchhabra/.local/share/Microsoft/ARMLanguageServer/Schemas/JSON
mkdir: /Users/rupanterchhabra/.local/share/Microsoft/ARMLanguageServer/Schemas/JSON: Permission denied
Rupanters-MBP:share rupanterchhabra$ mkdir -p 'Microsoft/ARMLanguageServer/Schemas/JSON'
mkdir: Microsoft/ARMLanguageServer/Schemas/JSON: Permission denied
I had to use sudo to create it :
Sudo mkdir -p /Users/rupanterchhabra/.local/share/Microsoft/ARMLanguageServer/Schemas/JSON
Rupanters-MBP:share rupanterchhabra$ sudo mkdir -p /Users/rupanterchhabra/.local/share/Microsoft/ARMLanguageServer/Schemas/JSON
Rupanters-MBP:share rupanterchhabra$
Could this be causing the problem? That the extension is unable to create/access the location because of root permissions?
Even after having the folders using the sudo, the language server is still crashing.

For those following this issue, Rupanter's ~/.local folder was owned by root instead of rupanter.  That likely means some process being run as root was the one that created it (don't know how this happened exactly).  The fix was to fix the owner of these folders by running
sudo chown -R $USER: ~/.local

Note: Need to provide link to diagnostic wiki in our errors.


resource wink was not found

I installed the Wink package as per the instructions however it does not load. I am able to see the login page and after I login I am displayed the following message:

Not Found
The requested resource /wink was not found on this server.

I tried to install Wink on an existing Laravel application as well on a fresh Laravel installation. In both cases I faced this error. Please note, I am trying to install Wink on my localhost before I can push it into production.
How can I resolve this issue?

Hey there, it might be because your WINK_PATH environment variable starts with a forward slash.

Hello friends, I have the same problem, I verify the forward slash but not not is the problem. Could you help me with it please.

What is the output of this command:
php artisan route:list | grep wink

I'm having the same issue.  Here is my output from the command @wpearse suggested.


Merge changes from our midstream that need to also be upstream

See the contained commits for the details.

/hold

/cc @dhaiducek

@gparvin Looks like there are some linting errors here.


IndexError: list index out of range

While running this:
import os
iskaggle = os.environ.get('KAGGLE_KERNEL_RUN_TYPE', '')
from duckduckgo_search import ddg_images
from fastcore.all import *

def search_images(term, max_images=30):
    print(f"Searching for '{term}'")
    return L(ddg_images(term, max_results=max_images)).itemgot('image')
urls = search_images('birds', max_images=5)
urls[0]

Searching for 'birds'

I'm getting this:
IndexError                                Traceback (most recent call last)
Cell In[2], line 2
1 urls = search_images('birds', max_images=5)
----> 2 urls[0]
File F:\Program Files (x86)\Python_3_10_6\lib\site-packages\fastcore\foundation.py:112, in L.getitem(self, idx)
--> 112 def getitem(self, idx): return self._get(idx) if is_indexer(idx) else L(self._get(idx), use_list=None)
File F:\Program Files (x86)\Python_3_10_6\lib\site-packages\fastcore\foundation.py:116, in L.get(self, i)
115 def get(self, i):
--> 116     if is_indexer(i) or isinstance(i,slice): return getattr(self.items,'iloc',self.items)[i]
117     i = mask2idxs(i)
118     return (self.items.iloc[list(i)] if hasattr(self.items,'iloc')
119             else self.items.array()[(i,)] if hasattr(self.items,'array')
120             else [self.items[i] for i in i])
IndexError: list index out of range
Yesterday everything worked fine but to day I encounter this issue, I've tried different versions of duckduckgo_search, it might work for a bit but then it breaks again.

You should update version to v2.9.4
pip install -U duckduckgo_search
All previous versions no longer work.

I have tried that also multiple times. It might work for a moment, but on the next run I'm getting this:
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
Cell In[3], line 2
      1 urls = search_images('airplane photos', max_images=1)
----> 2 urls[0]

File F:\Program Files (x86)\Python_3_10_6\lib\site-packages\fastcore\foundation.py:112, in L.__getitem__(self, idx)
--> 112 def __getitem__(self, idx): return self._get(idx) if is_indexer(idx) else L(self._get(idx), use_list=None)

File F:\Program Files (x86)\Python_3_10_6\lib\site-packages\fastcore\foundation.py:116, in L._get(self, i)
    115 def _get(self, i):
--> 116     if is_indexer(i) or isinstance(i,slice): return getattr(self.items,'iloc',self.items)[i]
    117     i = mask2idxs(i)
    118     return (self.items.iloc[list(i)] if hasattr(self.items,'iloc')
    119             else self.items.__array__()[(i,)] if hasattr(self.items,'__array__')
    120             else [self.items[i_] for i_ in i])

IndexError: list index out of range

Problem started today, yesterday everything worked fine all day.

ddgs version
Type this command in the terminal and show me the result.

ddgs version Type this command in the terminal and show me the result.

F:\Jupyter>ddgs version
2.9.4
Would prefer a screenshot?

What about ddgs images -k 'airplane photos' ?

Using terminal?
F:\Jupyter>ddgs images -k 'airplane photos'
Usage: ddgs [OPTIONS] COMMAND1 [ARGS]... [COMMAND2 [ARGS]...]...
Try 'ddgs --help' for help.

Error: No such command "photos'".

F:\Jupyter>

Yes, terminal

Try it with double quotes ddgs images -k "airplane photos" ?
Show me a screenshot.

I've tried ddgs images -k 'airplane photos' now using Windows PowerShell and it seem to work:
PS F:\jupyter> ddgs version
2.9.4
PS F:\jupyter> ddgs images -k 'airplane photos'
1. ------------------------------------------------------------------------------
title       50 Airplane Wallpaper Backgrounds in HD for Free Download
image       http://wonderfulengineering.com/wp-content/uploads/2014/05/airplane-wallpaper-1.jpg
thumbnail   https://tse3.mm.bing.net/th?id=OIP.CSU0WYkZwY4keDZCuzMsfQHaE5&pid=Api
url         https://wonderfulengineering.com/50-airplane-wallpaper-backgrounds-in-hd-for-free-download/
height      3687
width       5582
source      Bing

It's not a problem with this package.

If you have python 3.7, upgrade duckduckgo_search to v2.9.5.
Maybe that's the problem.

I'm using Python 3.10.
That's very unfortunate that it seem to break over the nigh.
I tried this example in notebook:
from duckduckgo_search import ddg_images

keywords = 'liberty tree'
r = ddg_images(keywords, region='wt-wt', safesearch='Off', size=None,
               color='Monochrome', type_image=None, layout=None, license_image=None, max_results=300)
print(r)

it returns only []
Again, it seems that I can have very few requests in a given amount of time and then it cuts me off. But may be it's just me, I'll have to try something else.

Try to use a proxy


Super linter fails linting a simple go repository with files in more than one folder (Inner error given by golangci-lint linter).

Is there an existing issue for this?

[X] I have searched the existing issues

Are you using the latest Super-linter version available?

[X] I am using the latest Super-linter version.

[X] I can reproduce the issue running Super-linter using complete version identifier (example: vX.Y.Z), and not just with a partial one (example: vX)

[X] I am using the super-linter/super-linter action or container image, and not the deprecated github/super-linter action or container image.

Are you resonably sure that it's a Super-linter issue, and not an issue related to a tool that Super-linter runs?

[X] I think that this is a Super-linter issue.

Current Behavior
I run the super linter through a github action for a very simple go repository with two folders and a go file in each, to lint the files. The super linter uses the golangci-lint linter. The action fails and the go linter is given as the error. The output is:
2024-10-21 15:28:05 [INFO]   Linting GO items...
  Error: -21 15:28:12 [ERROR]   Found errors when linting GO. Exit code: 1.
  2024-10-21 15:28:12 [INFO]   Stderr contents for GO:
  ------
  level=error msg="[linters_context] typechecking error: named files must all be in one directory; have /github/workspace/folder1 and /github/workspace/folder2"
  ------

Expected Behavior
The action passes and no error is given. When running the golangci-lint linter directly using any of the following commands, the linter produces no errors, therefore the super linter should produce no errors.
golangci-lint run
golangci-lint run ./...
golangci-lint run -c golangci.yml
golangci-lint run -c golangci.yml --fast

I have tested this with the latest golangci-lint version 1.61 and also 1.60.3, the current version of golangci-lint used by the super linter. The golangci.yml configuration file used in the commands above is the same configuration file found in the TEMPLATES folder of the super linter.
Super-Linter version
Latest and 6.9.0

Super-linter configuration
---
name: Lint Latest

on: # yamllint disable-line rule:truthy
  push: null
  pull_request: null

  # Allows you to run this workflow manually from the Actions tab
  workflow_dispatch:

permissions: {}

jobs:
  build:
    name: Lint
    runs-on: ubuntu-latest

    permissions:
      contents: read
      packages: read
      # To report GitHub Actions status checks
      statuses: write

    steps:
      - name: Checkout code
        uses: actions/checkout@v4
        with:
          # super-linter needs the full git history to get the
          # list of files that changed across commits
          fetch-depth: 0

      - name: Super-linter Latest
        uses: super-linter/super-linter@latest
        env:
          # To report GitHub Actions status checks
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          VALIDATE_JSCPD: false

Relevant log output
2024-10-21 15:43:26 [DEBUG]   Started GitHub Actions log group: GO
  2024-10-21 15:43:26 [INFO]   Linting GO items...
  2024-10-21 15:43:26 [DEBUG]   PARALLEL_RESULTS_FILE_PATH for GO: /tmp/super-linter-output/super-linter-worker-results-GO.json
  2024-10-21 15:43:26 [DEBUG]   LOG_DEBUG is enabled. Enable verbose ouput for parallel
  2024-10-21 15:43:26 [DEBUG]   PARALLEL_COMMAND for GO: parallel --will-cite --keep-order --max-procs 4 --xargs --results /tmp/super-linter-output/super-linter-worker-results-GO.json --verbose
  2024-10-21 15:43:26 [DEBUG]   PARALLEL_COMMAND for GO after updating the number of files to lint per process: parallel --will-cite --keep-order --max-procs 4 --xargs --results /tmp/super-linter-output/super-linter-worker-results-GO.json --verbose
  2024-10-21 15:43:26 [DEBUG]   LINTER_WORKING_DIRECTORY for GO: /github/workspace
  2024-10-21 15:43:26 [DEBUG]   PARALLEL_COMMAND for GO after updating the working directory: parallel --will-cite --keep-order --max-procs 4 --xargs --results /tmp/super-linter-output/super-linter-worker-results-GO.json --verbose --workdir /github/workspace
  2024-10-21 15:43:26 [DEBUG]   Checking if /action/lib/.automation/.checkov.yaml contains a 'directory:' configuration option
  2024-10-21 15:43:26 [DEBUG]   /action/lib/.automation/.checkov.yaml doesn't contain a 'directory:' statement
  2024-10-21 15:43:26 [DEBUG]   Adding the '--directory' option to the Checkov command.
  2024-10-21 15:43:26 [DEBUG]   Check if GO command needs check only mode or fix mode options or commands by checking if FIX_GO variable is defined.
  2024-10-21 15:43:26 [DEBUG]   FIX_GO is set. Check if we need to add check only mode options or fix mode options or commands.
  2024-10-21 15:43:26 [DEBUG]   Fix mode for GO is not enabled. Check if GO needs options to enable check mode.
  2024-10-21 15:43:26 [DEBUG]   There are no options or commands for check only mode or fix mode to add at the end of the command for GO
  2024-10-21 15:43:26 [DEBUG]   Load command for GO: LINTER_COMMANDS_ARRAY_GO. Contents: golangci-lint run -c /action/lib/.automation/.golangci.yml --fast
  2024-10-21 15:43:26 [DEBUG]   GO doesn't need any further options or commands for fix mode or check mode.
  2024-10-21 15:43:26 [DEBUG]   Completed the initialization of linter command for GO. Result: golangci-lint run -c /action/lib/.automation/.golangci.yml --fast
  2024-10-21 15:43:26 [DEBUG]   LINTER_COMMAND_ARRAY for GO has 5 elements: golangci-lint run -c /action/lib/.automation/.golangci.yml --fast
  2024-10-21 15:43:26 [DEBUG]   PARALLEL_COMMAND for GO after LINTER_COMMAND_ARRAY concatenation: parallel --will-cite --keep-order --max-procs 4 --xargs --results /tmp/super-linter-output/super-linter-worker-results-GO.json --verbose --workdir /github/workspace golangci-lint run -c /action/lib/.automation/.golangci.yml --fast
  2024-10-21 15:43:33 [DEBUG]   PARALLEL_COMMAND_OUTPUT for GO (exit code: 1): cd /github/workspace || exit 255; golangci-lint run -c /action/lib/.automation/.golangci.yml --fast /github/workspace/folder1/multiply.go /github/workspace/folder2/add.go
  2024-10-21 15:43:33 [DEBUG]   Parallel output file (/tmp/super-linter-output/super-linter-worker-results-GO.json) contents for GO:
  { "Seq": 1, "Host": ":", "Starttime":<PHONE_NUMBER>.437, "JobRuntime": 6.908, "Send": 0, "Receive": 0, "Exitval": 7, "Signal": 0, "Command": "golangci-lint run -c /action/lib/.automation/.golangci.yml --fast /github/workspace/folder1/multiply.go /github/workspace/folder2/add.go", "V": [ "/github/workspace/folder1/multiply.go","/github/workspace/folder2/add.go" ], "Stdout": "", "Stderr": "level=error msg=\"[linters_context] typechecking error: named files must all be in one directory; have /github/workspace/folder1 and /github/workspace/folder2\"
  " }
  Error: -21 15:43:33 [ERROR]   Found errors when linting GO. Exit code: 1.
  2024-10-21 15:43:33 [DEBUG]   RESULTS_OBJECT for GO:
  [
    {
      "Seq": 1,
      "Host": ":",
      "Starttime":<PHONE_NUMBER>.437,
      "JobRuntime": 6.908,
      "Send": 0,
      "Receive": 0,
      "Exitval": 7,
      "Signal": 0,
      "Command": "golangci-lint run -c /action/lib/.automation/.golangci.yml --fast /github/workspace/folder1/multiply.go /github/workspace/folder2/add.go",
      "V": [
        "/github/workspace/folder1/multiply.go",
        "/github/workspace/folder2/add.go"
      ],
      "Stdout": "",
      "Stderr": "level=error msg=\"[linters_context] typechecking error: named files must all be in one directory; have /github/workspace/folder1 and /github/workspace/folder2\"
  "
    }
  ]
  2024-10-21 15:43:33 [DEBUG]   Set INDEX for GO to: 2
  2024-10-21 15:43:33 [DEBUG]   Stdout for GO is empty
  2024-10-21 15:43:33 [INFO]   Stderr contents for GO:
  ------
  level=error msg="[linters_context] typechecking error: named files must all be in one directory; have /github/workspace/folder1 and /github/workspace/folder2"
  ------
  2024-10-21 15:43:33 [DEBUG]   Saving stderr for GO to /tmp/super-linter-output/super-linter-parallel-stderr-GO in case we need it later
  2024-10-21 15:43:33 [DEBUG]   Ending GitHub Actions log group: GO

Steps To Reproduce
Run the super linter for any go repository with more than two folders and go files.
Anything else?
My repository shows the problem:
https://github.com/andrew-field/InvestigateSuperLinterBug
https://github.com/andrew-field/InvestigateSuperLinterBug/actions
As can be seen from the logs, the problem is caused by running the golangci-lint linter with the following command.
golangci-lint run -c /action/lib/.automation/.golangci.yml --fast /github/workspace/folder1/multiply.go /github/workspace/folder2/add.go,
where each file is named and given as an argument.
I guess my main questions are:

Why are the names of all the go files given as arguments?
Could we change the command to run the linter to:
golangci-lint run ./... -c /action/lib/.automation/.golangci.yml --fast
or even more succinctly,
golangci-lint run -c /action/lib/.automation/.golangci.yml --fast,
which I believe does the same thing of linting all the files, without passing all the files as arguments and without the error?
If not changing the command as above, could this be configured somehow/an option for the super linter to run the golangci-lint linter in this way?

Hi @andrew-field, thanks for reporting this issue and for providing such a detailed report.
Let me try reproducing this in a test in order to understand what's happening.

I linked my test repo, which might help.

Yes, this is helpful. Thanks @andrew-field !

And, to answer your questions:

Why are the names of all the go files given as arguments?

Could we change the command to run the linter to: golangci-lint run ./... -c /action/lib/.automation/.golangci.yml --fast
or even more succinctly, golangci-lint run -c /action/lib/.automation/.golangci.yml --fast, which I believe does the same thing of linting all the files, without passing all the files as arguments and without the error? If not changing the command as above, could this be configured somehow/an option for the super linter to run the golangci-lint linter in this way?

This is already implemented using the GO_MODULES "language".
Can you try adding VALIDATE_GO: false in your configuration?
It should only run GO_MODULES linting which does what you ask.

Ah yes, I see. Thanks very much. Indeed, the debug log shows the command is running the golangci-lint program without the individual files for the Go_Modules lint. Reading the description for the variable VALIDATE_GO seems quite clear now...not sure where I misunderstood in the first place...
Might I humbly suggest though that the default value for VALIDATE_GO is changed to false? It says VALIDATE_GO should be set to false if VALIDATE_GO_MODULES is true but they are both set to true by default at the moment.


Federico: Watch VTOLEJET.COM

Federico requests the watch of the watch_keyword VTOLEJET.COM. See the Metasmoke search here and the Stack Exchange search here.

Coverage remained the same at 63.155% when pulling b48405ce43c07f71bd94b51d969bcde10f4b4c1d on auto-blacklist-1512479953.023961 into 745de57b8ee74d55aaa4cff59ebe05da0c6fed1b on master.

Superseded by #1323


test: remove playwright

removed plawright
reverts husky back to v4

:tada: This PR is included in version 1.12.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[wsi] Fix crash when parsing EDID fails

If info is null then we shouldn't pass it around.
Also improve formatting a bit.
Found by @K0bin .

Yes, I will do that. Annoying that the MinGW implementation is broken :/


Fixes left arrow key in dropdown search input

For the case where no item is selected. Because in this case $parentMenu is still something else than $menu.

Can you explain what might trigger this issue?

@Sanjo Delaying this without a specific test case

Reproduce:

Go to the "Search Selection" example on http://semantic-ui.com/modules/dropdown.html.
Type "foo" into the search input
Press the left arrow key to change the cursor position in the text. This currently doesn't work and this fix fixes that.

This fix just adds the condition:
if(hasSelectedItem) {
  ...
}

which is necessary because isSubMenuItem has the value true even when no item is selected, which interprets the left arrow key press wrongly as menu navigation action, instead of the default cursor position change action.

Woah that is bad.. thanks for the catch

Thanks for spotting this, this is a pretty heinous bug.
I've manually added the fix instead of merging due to conflicts when merging into the next branch. (See readme for details, but generally all PR should be merged into next branch)


[null:-1] Connection errors when using an avahi alias .local name for the Bitcoin RPC on windows 11

An embassy user reported a problem connecting to their bitcoin rpc via .local (an avahi alias for the bitcoin rpc service):
2023-03-19 10:45:16,900 ERROR [JavaFX Application Thread] c.s.s.p.ServerPreferencesController [null:-1] Connection error

java.lang.IllegalStateException: I/O error during request processing
                at [simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.ObjectApiBuilder.execute(Unknown](mailto:simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.ObjectApiBuilder.execute(Unknown) Source)
                at [simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.ObjectApiBuilder.invoke(Unknown](mailto:simple.json.rpc.client@1.3/com.github.arteam.simplejsonrpc.client.builder.ObjectApiBuilder.invoke(Unknown) Source)
                at jdk.proxy2/jdk.proxy2.$Proxy15.getNetworkInfo(Unknown Source)
                at [com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.cormorant.bitcoind.BitcoindClient.initialize(Unknown](mailto:com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.cormorant.bitcoind.BitcoindClient.initialize(Unknown) Source)
                at [com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.cormorant.Cormorant.start(Unknown](mailto:com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.cormorant.Cormorant.start(Unknown) Source)
                at [com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.ElectrumServer$ConnectionService$1.call(Unknown](mailto:com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.ElectrumServer$ConnectionService$1.call(Unknown) Source)
                at [com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.ElectrumServer$ConnectionService$1.call(Unknown](mailto:com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.ElectrumServer$ConnectionService$1.call(Unknown) Source)
                at [javafx.graphics@18/javafx.concurrent.Task$TaskCallable.call(Unknown](mailto:javafx.graphics@18/javafx.concurrent.Task$TaskCallable.call(Unknown) Source)
                at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
                at [javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$6(Unknown](mailto:javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$6(Unknown) Source)
                at java.base/java.security.AccessController.doPrivileged(Unknown Source)
                at [javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$7(Unknown](mailto:javafx.graphics@18/javafx.concurrent.Service.lambda$executeTask$7(Unknown) Source)
                at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
                at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
                at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.net.UnknownHostException: reallylonglocalhostname.local
                at java.base/sun.nio.ch.NioSocketImpl.connect(Unknown Source)
                at java.base/java.net.SocksSocketImpl.connect(Unknown Source)
                at java.base/java.net.Socket.connect(Unknown Source)
                at java.base/sun.security.ssl.SSLSocketImpl.connect(Unknown Source)
                at java.base/sun.security.ssl.BaseSSLSocketImpl.connect(Unknown Source)
                at java.base/sun.net.NetworkClient.doConnect(Unknown Source)
                at java.base/sun.net.www.http.HttpClient.openServer(Unknown Source)
                at java.base/sun.net.www.http.HttpClient.openServer(Unknown Source)
                at java.base/sun.net.www.protocol.https.HttpsClient.<init>(Unknown Source)
                at java.base/sun.net.www.protocol.https.HttpsClient.New(Unknown Source)
                at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.getNewHttpClient(Unknown Source)
                at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect0(Unknown Source)
                at java.base/sun.net.www.protocol.http.HttpURLConnection.plainConnect(Unknown Source)
                at java.base/sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(Unknown Source)
                at java.base/sun.net.www.protocol.http.HttpURLConnection.getOutputStream0(Unknown Source)
                at java.base/sun.net.www.protocol.http.HttpURLConnection.getOutputStream(Unknown Source)
                at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getOutputStream(Unknown Source)
                at [com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.cormorant.bitcoind.BitcoindTransport.pass(Unknown](mailto:com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.cormorant.bitcoind.BitcoindTransport.pass(Unknown) Source)

                ... 15 common frames omitted

When attempting to reproduce this on our own windows setup, I got a very similar error:
2023-03-20 14:17:48,572 ERROR [pool-5-thread-1] c.s.s.n.c.e.RequestHandler [null:-1] Could not communicate with client socket
java.net.SocketException: Connection reset
	at java.base/sun.nio.ch.NioSocketImpl.implRead(Unknown Source)
	at java.base/sun.nio.ch.NioSocketImpl.read(Unknown Source)
	at java.base/sun.nio.ch.NioSocketImpl$1.read(Unknown Source)
	at java.base/java.net.Socket$SocketInputStream.read(Unknown Source)
	at java.base/sun.nio.cs.StreamDecoder.readBytes(Unknown Source)
	at java.base/sun.nio.cs.StreamDecoder.implRead(Unknown Source)
	at java.base/sun.nio.cs.StreamDecoder.read(Unknown Source)
	at java.base/java.io.InputStreamReader.read(Unknown Source)
	at java.base/java.io.BufferedReader.fill(Unknown Source)
	at java.base/java.io.BufferedReader.readLine(Unknown Source)
	at java.base/java.io.BufferedReader.readLine(Unknown Source)
	at com.sparrowwallet.sparrow@1.7.3/com.sparrowwallet.sparrow.net.cormorant.electrum.RequestHandler.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)

Curl "works" from the same windows pc (although maybe I have some rpc syntax wrong, or windows syntax wrong, at least I'm definitely getting a response from the RPC):
C:\Users\start9>curl -k --data-binary '{"jsonrpc":"1.0","id":"curltest","method":"getblockchaininfo","params":[]}' -H 'content-type:text/plain;'<EMAIL_ADDRESS>    {"result":null,"error":{"code":-32700,"message":"Parse error"},"id":null}

Same curl works fine from my linux box:
curl -k --data-binary '{"jsonrpc":"1.0","id":"curltest","method":"getblockchaininfo","params":[]}' -H 'content-type:text/plain;'<EMAIL_ADDRESS>{"result":{"chain":"main","blocks":781716,"headers":781716,"bestblockhash":"00000000000000000002943367e86046586e156ed1976d70107e49260c60460e","difficulty":43551722213590.37,"time":1679347298,"mediantime":1679344850,"verificationprogress":0.9999993474460475,"initialblockdownload":false,"chainwork":"0000000000000000000000000000000000000000432eb13f55bd3b92b70feb12","size_on_disk":529164118005,"pruned":false,"warnings":""},"error":null,"id":"curltest"}

So we know the .local is resolving and reachable and the username and password is working.
It just seems sparrow isn't.  Are you able to read the tea-leaves to interpret these error messages?
Two things I will note:

While other computers such as linux seem to get the ipv4 by default when for instance, pinging mysuperlongbitcoinrpc.local, windows seems to always get the ipv6 local address for some reason:

It also looks like for some strange reason windows is appending a %19 in there.  I've also seen %28 on the other user's windows computer who is experiencing this problem.  Given that there is a ping response, I assume this is just a UI display bug in windows and probably not related to this problem.

This happened on windows while I was setting up and testing the rpc details in Sparrow, in case it matters:

I clicked "Allow access".

Thanks
G

This appears to be a network configuration issue.
Firstly, the two errors are actually quite different - one is a name resolution error that occurs before an IP address can be found, and the other is a connection error that occurs after an IP address is found. For the error you are experiencing, it is likely that Java has resolved the .local name to an IPv6 address (as does ping), and Bitcoin Core is not bound to that address. Can you use the Resolver from https://github.com/sparrowwallet/sparrow/issues/634#issuecomment-1217616898 to test this out? Run with java Resolver reallylongname.local.
For the curl tests, try running them with --ipv4 and --ipv6 - perhaps it defaults to IPv4 if it finds both. Fwiw, I tried the same test on my Windows machine, and the remote .local address I used (which resolves to an IPv4 address that Bitcoin Core binds on) works fine.

OK, thanks for the reminder about that Resolver code.
I got my local situation on this test Windows box worked out.  Windows (at least from java) is indeed resolving it to the embassy's local ipv4 address.  I was getting various disconnection errors until I restarted the embassy, so what I was experiencing may be some kind of embassy bug, currently uncharacterized.
Waiting to hear back from our user having the other distinct resolution problem in the wild.

This issue is getting dated now, so closing it off.

Hey guys!
Just wanted to comment: I am the user described here. I still have the same problem. Sometimes sparrow connects, sometimes it doesn't. I'd say it's about 95% of the time that it does not connect. I tried the ipv4 address thing and it resolves to the local ipv4 address but I still have the problem with the connection.
Firewall shouldn't be an issue either. And if I use the same start 9 node on the same laptop for a connection to Specter it works. But I want to use Sparrow ;)
The general error I am getting is still the "Could not communicate with clietnt socket java.net.SockectException: Connection reset".

One more note: I am getting the "Connection error java.lang.IllegalStateException: I/O error during request processing"
from time to time as well. It's the same machine and I'm not changing anything else.
Just one more note:
Connection to a public server works instantly.


Habib/deriv x logo ref margin trade

Changes:
We need to include Deriv x logo / references on every markets page and tabs that reference Deriv X.
Type of change

[ ] Bug fix
[x] New feature
[ ] Update feature
[ ] Refactor code
[ ] Translation to code
[ ] Translation to crowdin
[ ] Script configuration
[ ] Improve performance
[ ] Style only
[ ] Dependency update
[ ] Documentation update
[ ] Release

The rest LGTM 👍


 This PR removes all of them including those found with Clippy nightly.
This is my first PR to curv! If there is anything I've missed by way of contributing etiquette please say so. This is also my first PR with my company github account (I'm tcharding usually), we are using curv at work so I thought I'd try push some improvements upstream :)
Thanks,
Tobin.

I've also updated travis config, so clippy warnings would be rejected by CI

I've also updated travis config, so clippy warnings would be noticed by CI

Awesome, thanks. I could have done that ...

Awesome, thanks. I could have done that ...

Sorry, I just did it reflexively 😅

Thank you again, @tobin-crypto! The code's got more clean. @omershlo can we merged it?

great work @tobin-crypto !

Thanks for the reviews @survived and thanks for merging @omershlo. Nice to upstream some patches!


feat(earn): support partial withdrawals

Description
Adds the ability to support partial withdrawals from Earn pools and adds the feature gate allow_earn_partial_withdrawal to enable this feature.

Example Deposit
Example Withdrawal

Test plan

[x] Tested locally on iOS
[x] Tested locally on Android
[x] Unit Tests Updated

Related issues

ACT-1386

Backwards compatibility
Yes
Network scalability
Yes

@jh2oman Feedback addressed!

@jh2oman withdrawals use the withdrawal token as was done with prepareWithdrawAndClaimTransactions the src/earn/prepareTransactions.ts. If we display the deposit token information instead we end up with the discrepancy reported in https://github.com/valora-inc/wallet/pull/6128#pullrequestreview-2363514230.

@jh2oman addessed issues in 9ed4dfc5a8d3109106434bbce20a1926dbabd90e and 7b20e2d1456dfef58e3ee7ae1b85c4be1bb5b26c. If there are additional issues code comments would be helpful!

The Fee info bottom sheet specifically references 'deposit' in the withdraw flow. Should we update the copy?


Added orange dragon for mapping

Description

Added a new statue in preparation for new map.
TODO

Media

Changelog

Closing the pull request as it exists in the new pull I am making.


fix(mcs-lite-icon): move prop-types to dependency

cc @cettoana

Deploy preview ready!
Built with commit ae9788772e7536fd0e647b7b01513e1377f885ab
https://deploy-preview-309--mcs-lite-introduction.netlify.com

Deploy preview failed.
Built with commit ae9788772e7536fd0e647b7b01513e1377f885ab
https://app.netlify.com/sites/mcs-lite-mobile-web/deploys/591548926f4c5023c9e2593c

Deploy preview ready!
Built with commit ae9788772e7536fd0e647b7b01513e1377f885ab
https://deploy-preview-309--mcs-lite-ui.netlify.com


Clicking span (other) elements

With jQuery i can simply add the button class to an html element (let's say an span element) and the element acts like an button (more or less).
But the click method doesn't support span elements.
Context code:
/**
     * @Given I click the :arg1 element
     */
    public function iClickTheElement($selector)
    {
        $page = $this->getSession()->getPage();
        $element = $page->find('css', $selector);

        if (empty($element)) {
            throw new Exception("No html element found for the selector ('$selector')");
        }

        $element->click();
    }

CLI output:
And I click the "#new_account" element # tests/behat/features/account.feature:14
      Behat\Mink\Driver\GoutteDriver supports clicking on links and submit or reset buttons only. But "span" provided (Behat\Mink\Exception\UnsupportedDriverActionException)

Goutte does not run the javascript, so it does not know what to do when you click on the span. If your click is handled in JS, use a driver supporting JS

Thanks.. that resolved it..


lock your Gem version for Capistrano v2 does not work!

In my project's gemfile I have set:
gem 'capistrano', '~> 2.15'

I also tried bundle install. My Gemfile.lock is:
GEM
  remote: http://rubygems.org/
  specs:
    capistrano (2.15.6)
      highline
      net-scp (>= 1.0.0)
      net-sftp (>= 2.0.0)
      net-ssh (>= 2.0.14)
      net-ssh-gateway (>= 1.1.0)
    highline (1.7.2)
    magentify (0.1.0)
      capistrano (~> 2, >= 2.5.10)
    net-scp (1.2.1)
      net-ssh (>= 2.6.5)
    net-sftp (2.1.2)
      net-ssh (>= 2.6.5)
    net-ssh (2.9.2)
    net-ssh-gateway (1.2.0)
      net-ssh (>= 2.6.5)

PLATFORMS
  ruby

DEPENDENCIES
  capistrano (~> 2.15.6)
  magentify

But it still tries to use v3.
cap
(Backtrace restricted to imported tasks)
cap aborted!
NoMethodError: undefined method `map' for :except:Symbol
/Users/ccarnell/Sites/xxx/Capfile:3:in `load'
/Users/ccarnell/Sites/xxxCapfile:3:in `<top (required)>'
(See full trace by running task with --trace)

cap -v
Capistrano Version: 3.4.0 (Rake Version: 10.2.2)

gem list
em list

*** LOCAL GEMS ***

addressable (2.3.6)
bigdecimal (1.2.0)
bundle (0.0.1)
bundler (1.6.0)
capifony (2.8.1)
capistrano (3.4.0, 2.15.6, 2.15.5)
capistrano-composer (0.0.6)
capistrano-ext (1.2.1)
capistrano-file-permissions (0.1.1)
capistrano-maintenance (0.0.3)
capistrano-rsync (1.0.2)
capistrano-scm-gitcopy (0.0.8)
capistrano-symfony (0.4.0)
capistrano-withrsync (0.1.2)
capistrano-wp (0.4.10)
capistrano_rsync_with_remote_cache (2.4.0)
CFPropertyList (2.2.8)
chunky_png (1.3.1)
colored (1.2)
colorize (0.7.7)
compass (0.12.6)
erubis (2.7.0)
fssm (0.2.10)
highline (1.7.2, 1.7.1, 1.6.21)
i18n (0.6.9)
inifile (3.0.0)
io-console (0.4.2)
json (1.7.7)
launchy (2.4.2)
libxml-ruby (2.6.0)
lunchy (0.7.0)
magentify (0.1.0, 0.0.7)
minitest (4.3.2)
net-scp (1.2.1, 1.1.2)
net-sftp (2.1.2)
net-ssh (2.9.2, 2.7.0)
net-ssh-gateway (1.2.0)
nokogiri (1.5.6)
psych (2.0.0)
puppet-lint (1.1.0)
railsless-deploy (1.1.3)
rake (10.2.2, 0.9.6)
rdoc (4.0.0)
ruby-progressbar (1.4.1)
sass (3.2.19)
sqlite3 (1.3.7)
sshkit (1.3.0)
term-ansicolor (1.3.0)
test-unit (<IP_ADDRESS>)
tins (1.0.1)

Hey @craigcarnell
I don't know anything about this, but top result on google for that error pointed me to this issue which points to a bug in Magentify up to version 0.7:
http://stackoverflow.com/questions/20754060/capistrano-undefined-method-map
Are you picking up an old version of Magnetify somehow?
Could you post the full stack trace that results from cap --trace?
Do you need to call bundle exec cap instead of just cap?

Whatever is going on is not a Capistrano bug. You didn't post your command line, but if you are not running bundle exec ________________  then you have no guarantees that your shell is finding the binaries as defined in your bundle!


Version is still shown as V1.1 when using submission-2.0 branch

Version is still shown as V1.1 when using submission-2.0 branch. If I am not wrong, it should have got updated to 2.0.x.

this was done. thanks to @d-uzlov


[feature] "setup" or "pre logged in" support

I'd like to monitor some websites that implement custom CAPTCHA schemes - things Brightdata can't solve.
I am currently using Distill.io, and since it runs in my browser, it has access to my session (Cookies) and thus stays connected, after I manually solved the CAPTCHA once.
(I just need to choose a check interval that is below the session inactivity timeout.)
I'd like something similar in ChangeDetection.io ; either I solve the CAPTCHA in Browser Steps, then I have a button to "Remember Cookies", which save the current cookies (maybe offer to saved them as "User Provided Name"), and then I can change the Browser Steps, for example with an initial step of "Reuse Saved Cookies", and then I could select from previously saved cookies, and I'd pick "User Provided Name". (This step would need to appear before the currently hard-coded Browse Site step.)
Or, simpler, offer a simple text field during configuration, to paste the Cookies value into, and when non-empty, the Browser Steps should always use those.
Of  note : I'm using Playwright, but I guess this could apply to plain HTTP too.

Or, simpler, offer a simple text field during configuration, to paste the Cookies value into, and when non-empty, the Browser Steps should always use those.

actually hmm i think it supports this, but theres a bug in the UI, this would be the place to start

can you try, select the "requests plaintext browser", enter in your cookies, then click back to "browserless/chrome" type browser, and try it?

Indeed, selecting "Basic fast Plaintext/HTTP Client" shows a new "Request Headers" field.
And I tried that, and to manually enter my filters, and that worked! :)
So not sure if there is an easy way to also be able to specify Request Headers for Playwright..?

Ah, you're right. Going back to Playwright shows the Request Headers field!! So yeah this seems like a UI bug after all.
Thanks for the support.

Hum... After further testing, it seems the Cookie HTTP Header is NOT used by Playwright... Not sure how I tested initially, to think that it worked...
They work only for "Basic fast Plaintext/HTTP Client".

Not true
0.44
with https://manytools.org/http-html-text/http-request-headers/
I set cookie: some value


subsys/fs: nvs Coverty CID205795 & CID205803 corrections

In nvs writing addresses are u32_t. Coverty reports two situations
where the address could be converted (unwanted) to a signed value.
Both have been corrected.
There is however a general problem with flash API where the addresses
are defined as off_t which is a s32_t. These are converted in the flash
hal to u32_t. As a result of this only half of the possible range can
be used.
Closes #20867
Closes #20866
Signed-off-by: Laczen JMS<EMAIL_ADDRESS>

There is however a general problem with flash API where the addresses
are defined as off_t which is a s32_t. These are converted in the flash
hal to u32_t. As a result of this only half of the possible range can
be used.

Worth to open an issue for track this deficiency.


[Bug]:Failed to create filewatcher.

What modules are you seeing the problem on?
ScriptHookVDotNet.asi (runtime), ScriptHookVDotNet3.dll (v3 SDK/API), ScriptHookVDotNet2.dll (v2 SDK/API)
SHVDN Version
0d5b09b
Game Version
v1.0.3179
Bug Description
In the ScriptHookVDotNet.log, these happened.
[22:49:29] [DEBUG] Loading API from .\ScriptHookVDotNet2.dll ...
[22:49:29] [DEBUG] Loading API from .\ScriptHookVDotNet3.dll ...
[22:49:29] [DEBUG] Initializing NativeMemory members...
[22:49:31] [ERROR] Failed to create filewatcher: System.Reflection.TargetInvocationException:
ScriptHookVDotNet.log
ScriptHookV.log
Steps To Reproduce

I paste ScriptHookVDotNet.asi and 2.dll 3.dll to the game folder of GTAV
start the game, and it happen as the log file shown

Link To Code Example
No response
The Current Behavior
None
The Expected Behavior
None

SHVDN.FileWatcher does not exist in at least the commit 0d5b09b29641ef90e99b4776f76db46c280bd01d. How could be a legitimate issue if the error log stated a class in our module that doesn't actually exist? Period.


Promisified MongoDB Node driver throwing stack_overflow error on multiple document insert

When promisifying the mongodb driver module, I can insert multiple documents to a collection successfully. However, I'm also getting a stack_overflow Error hitting the catch block. This happens when executing either insertAsync or insertManyAsync and passing multiple document objects (using the MongoDB 2.0.0 Driver).
Here is a code sample in which this should reproduce:
var Promise = require('bluebird'),
    mongodb = Promise.promisifyAll(require('mongodb'));

mongodb.connectAsync("mongodb://my_conn_string").then(function(db) {
    return db.collection("my_collection").insertManyAsync([{a: 1}, {b: 2}]);
}).then(function(result) {
    console.log('info', result);
}).catch(function(err) {
    console.log('error', err);
});

Do something like this at the top:
Promise.longStackTraces();
And then paste the stack trace here

Ping @pcullin-ratio

Ping @pcullin-ratio one last time?

Sorry i'm working on this now and will have a more detailed response shortly

Yes! I knew it was worth one more ping. Thanks.
On Thu, May 14, 2015 at 9:02 PM, Paul Cullin<EMAIL_ADDRESS>wrote:

Sorry i'm working on this now and will have a more detailed response
shortly
—
Reply to this email directly or view it on GitHub
https://github.com/petkaantonov/bluebird/issues/605#issuecomment-102119757
.

I'm not able to reproduce the issue now - seems to be working as expected. Very odd :-/

@pcullin-ratio hey, thanks for reporting and thanks for following through. Don't hesitate to report issues in the future when you run into suspected bugs.

Will do, thanks for the replies and tracking this @benjamingr!


lodash is in the worker bundle and vendor

When I import lodash into the worker file, it is exist in the worker bundle and vendor bundle.
It is need to exist only in vendor.
some.worker.js:
const _ = require('lodash');
const a = _.map([1,2,3], s => s);

webpack.config.js:
entry: {
    vendor: ["jquery", "lodash"],
    main: './app/index.js',
 },
modules/rules:
{
 test: /\.worker\.js$/,
 use: { loader: 'worker-loader' },
},

Web workers global scope is different from the window global scope.
When your 'vendor.js' is loaded, it adds lodash  to to window object. Web worker does not have access to it.

Close in favor https://github.com/webpack-contrib/worker-loader/issues/70


Do Not Merge: CI runs for core_bpf power builds

PR to start CI runs on new core_bpf builds on Power

/test help

/test powervs-qa-e2e-tests
/test ibmcloudz-4-14-qa-e2e-tests


"Dobra" is listed in the drop-down menu

Description:
"Dobra" is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Type "Dobra" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Dobra, DÂMBOVIȚA".


Update CI

Hello @rasbt! Thanks for submitting the PR.

In the file code/tests/test_notebooks.py, following are the PEP8 issues :

Line 68:5: E265 block comment should start with '# '
Line 96:1: E303 too many blank lines (3)


ask for code

hello,I read your paper and I think it's really good.I want to learn the model.Can you show me the code of this dehazing network and tell me how to train?

Do you mean this paper ? Arxiv I almost forget this paper...

You can directly follow the official implementation of RepVGG and details in my paper. It's very simple but effectiveness!

This paper has been finished about 1.5 years ago... However, it still not be accepted by any conference or journals...

So sad to hear about this.But I think it is a good paper that use simple but efficient way.I want to reproduce this model.
------------------ 原始邮件 ------------------
发件人:                                                                                "Owen718/ERA-Net"                                                                                @.>;
发送时间: 2022年11月3日(星期四) 晚上11:27
@.>;
<EMAIL_ADDRESS>主题: Re: [Owen718/ERA-Net] ask for code (Issue #1)
This paper has been finished about 1.5 years ago... However, it still not be accepted by any conference or journals...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


/back command permission does not work

Hello,
According to the docs at https://william278.net/docs/huskhomes/commands, the player only can access /back command if that user has permission huskhomes.command.back. But in the current build of HuskHome (v4.1.1), the plugin no longer check that permission anymore. It makes the command publicly available for everyone.
Edit: I also found this bug in other command like phomelist and the command can be executed without the documented permissions.
I am running HuskHomes on Paper 1.17.1 build 411

IMO the reason causes that effect is in this line:
https://github.com/WiIIiam278/HuskHomes2/blob/1bdf21dd7ddaa2f0b9c15818b14b9948d8447940/bukkit/src/main/java/net/william278/huskhomes/command/BukkitCommand.java#L105
What do you think?

/back is enabled by default to allow anyone to use it without having to install a permission plugin or op players. Set the huskhomes.command.back node to false to deny it for users. Closing as invalid.

OK because it is different than the old version so I thought it was a bug. I can totally deny the permission.

This hasn't changed since 3.x afaik
https://github.com/WiIIiam278/HuskHomes2/blob/10a3eebc5571af75e2fb14abc1afbd5595bb0bb4/common/src/main/java/net/william278/huskhomes/util/Permission.java#L153


Example for loose option is not correct

In your README it states that parser.pick(['fr', 'en'], 'en-GB,en-US;q=0.9,fr-CA;q=0.7,en;q=0.8'); would return "fr". But that's not correct IMO:
> parser.pick(['fr', 'en'], 'en-GB,en-US;q=0.9,fr-CA;q=0.7,en;q=0.8');
'en'
> parser.pick(['fr', 'en'], 'en-GB,en-US;q=0.9,fr-CA;q=0.7,en;q=0.8', { loose: true });
'en'

I'd say this is indeed the expected behaviour, because there are to en with q=1 which should have preference over the fr locale.
Bonus: The README's example for the loose option is missing the { loose: true }.

I added some tests to indicate how pick handles quality when loose is true in https://github.com/opentable/accept-language-parser/pull/35

@bamapookie
I don't think this is right:
it('selects the first matching language in loose mode, even when the accepted language is more restrictive', function(){
        var result = parser.pick(['en', 'en-US', 'pl'], 'en-US;q=0.6', { loose: true });
        assert.equal(result, 'en');
    });

If I accept "en-US" and "en-US" is supported it should return "en-US" why a partial matching that is also less restrictive?
Imagine I'm ing UK, accepted language is en-GB with date format dd/MM/yyyy.
With these supported languages, ["en", "en-GB"], it's not correct return "en", which has date format MM/dd/yyyy.

@alex-piccione
From the readme:

In loose mode the order of supportedLanguagesArray matters, as it is the first partially matching language that is returned. It means that if you want to pick more specific langauges first, you should list it first as well.

I designed the test to match the requirement in this text.

I'll update the test if you want.  Let me know the criteria you want, and I'll update the readme as well.
Example:
specific language/region match > generic language earlier in specificLanguagesArray, etc.

Those 2 tests currently fail.  They would require changing how loose is evaluated in the parser.  My intention was to demonstrate how the code actually functions (except for the one failing test that needs to be changed from equal to deepStrictEqual).

Perfect, I'll open an issue.


cucumber-expressions/ruby: Exclude spec/ from coverage counting

Summary
This PR changes the code coverage counting in the Ruby sub-project to only count non-spec files.
Motivation and Context
The motivation for this is clarity and understandability of the code coverage report to its reader.
How Has This Been Tested?
I only re-ran the tests, to have a new coverage HTML report generated.
Screenshots (after this change):

Types of changes
Non-functional change to reporting.

Gonna copy bits of this to some of my other projects :)

Next task is to fix up argument.rb - If I have time and no-one has done this before the weekend I'll get it done :)


Add Python 3.11

Add initial support for Python 3.11.
Will do some follow-up PRs to clean up other images (e.g., drop Python 3.8, upgrade Alpine, drop Alpine 3.14 things like that).
Main goal for this PR is to get a Python 3.11 base image build.
../Frenck

Yeah, 3.8 and some more stuff, also some new additions. Will do the cleanups in followups.
For now, I've canceled the CI, to free up agents for the patch release. Will mark this PR draft for that reason until tomorrow.


mqtt error code 0

Hello I am getting error code 0 not able to connect  aws server. I have followed all the instruction and changes only ceertificates, mqtt_host and thing name in the code. Do I need to change time zone also.

For your information my mqtt host end with ".......us-east-2.amazonaws.com"

I got the same error here.

I got the same error here.

It has been a while since I have visited this, I’ll look into it.

It has been a while since I have visited this, I’ll look into it.

I'm also getting a similar error:
SSL Error Code: 0
failed, reason -> Connection Accepted < try again in 5 seconds

Tried many things :-(

Guys my issue got fixed!  I had made an error copy pasting the SSL certificate. Have a look at that!


Fix how multiple giftcards are applied

It is a port of #13647
Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations

Docs

[ ] Link to documentation:

Pull Request Checklist

[ ] Privileged queries and mutations are either absent or guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migrations are either absent or optimized for zero downtime
[ ] The changes are covered by test cases

@jakubkuc One test is failing. Also remember about porting these changes to 3.15.


ssh2 deadlocks sometimes

seems to be a recent linux thing. should debug. maybe bisect?

fixed via 4a68e61ed0494bb96396b5d95c3a2c7fbefed94d


Fixes #930: Change Default Compaction

Changes default max files per compaction to 15 to match table.file.max

@keith-turner are you working on this?  Should @Manno15 close this PR?

After working on #1036 I think it may be best to leave the settings as is.  The changes I suggested in #930 were a band-aid for the real problem that I was seeing which is fixed by #1036. It helps to have a buffer between max files per compaction and max files inorder to prevent worst case performance for merging minor compactions.

I opened #1071 to expand on the issue I mentioned about merging minor compactions.  I think it would be best to close this issue w/o merging.  Sorry for the delay and thanks for patch @Manno15


Add means to specify name of the type parameter

Experience shows that while nine times out of ten you can get away with not being to refer to the name of the type parameter, on the tenth time you need it. Usually the cause is a situation where you are forced by scala inference to specify a type parameter, and the type A with its unknown name also must be given, because scala offers no way to specify one type argument without specifying them all.

See #54. The examples in polyval.scala show several examples of natural transformations referring to the type parameter.

I think at this point we should probably just close this as not-gonna-happen in Scala 2. In Scala 3 a possible future is https://dotty.epfl.ch/docs/reference/other-new-features/named-typeargs.html

Come to think of it, the repo readme here already outright says "No new features are developed"


Example Code on Wiki Calling Non-Existant Function

This was kind of frustrating to track down, so maybe it'll save someone elses time :)
The Arduino Example - Network RSSI example on the wiki calls ublox.Check_If_Power_On() in the setup.  It's been changed to ublox.isAlive()
Thanks!

@invpdx thank you for your correction.


[SPARK-35664][SQL] Support java.time.LocalDateTime as an external type of TimestampWithoutTZ type

What changes were proposed in this pull request?

In the PR, I propose to extend Spark SQL API to accept java.time.LocalDateTime as an external type of recently added new Catalyst type - TimestampWithoutTZ. The Java class java.time.LocalDateTime has a similar semantic to ANSI SQL timestamp without timezone type, and it is the most suitable to be an external type for TimestampWithoutTZType. In more details:

Added TimestampWithoutTZConverter which converts java.time.LocalDateTime instances to/from internal representation of the Catalyst type TimestampWithoutTZType (to Long type). The TimestampWithoutTZConverter object uses new methods of DateTimeUtils:

localDateTimeToMicros() converts the input date time to the total length in microseconds.
microsToLocalDateTime() obtains a java.time.LocalDateTime

Support new type TimestampWithoutTZType in RowEncoder via the methods createDeserializerForLocalDateTime() and createSerializerForLocalDateTime().
Extended the Literal API to construct literals from java.time.LocalDateTime instances.

Why are the changes needed?

To allow users parallelization of java.time.LocalDateTime collections, and construct timestamp without time zone columns. Also to collect such columns back to the driver side.
Does this PR introduce any user-facing change?

The PR extends existing functionality. So, users can parallelize instances of the java.time.LocalDateTime class and collect them back.
scala> val ds = Seq(java.time.LocalDateTime.parse("1970-01-01T00:00:00")).toDS
ds: org.apache.spark.sql.Dataset[java.time.LocalDateTime] = [value: timestampwithouttz]

scala> ds.collect()
res0: Array[java.time.LocalDateTime] = Array(1970-01-01T00:00)

How was this patch tested?

New unit tests

Test build #139447 has started for PR 32814 at commit 1101f55.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43970/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43970/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43970/

Test build #139447 has finished for PR 32814 at commit 1101f55.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139447/

Test build #139469 has started for PR 32814 at commit ba44cb1.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43990/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43990/

Test build #139469 has finished for PR 32814 at commit ba44cb1.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43992/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139469/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43992/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43992/

@gengliangwang Have you done similar changes as in https://github.com/apache/spark/pull/31729, correct? Just want to avoid comparing of this PR to similar PRs for intervals.

@MaxGekk Yes I follow #31729

Test build #139487 has started for PR 32814 at commit 0418133.

Test build #139487 has finished for PR 32814 at commit 0418133.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139487/

@gengliangwang I wonder why did you removed the checks for Long.MaxValue/MinValue:

Does instantToMicros overflow on the values?

Does instantToMicros overflow on the values?

@MaxGekk Yes.
scala> import org.apache.spark.sql.catalyst.util.DateTimeUtils._
import org.apache.spark.sql.catalyst.util.DateTimeUtils._

scala> instantToMicros(microsToInstant(Long.MinValue))
java.lang.ArithmeticException: long overflow
  at java.lang.Math.multiplyExact(Math.java:892)
  at org.apache.spark.sql.catalyst.util.DateTimeUtils$.instantToMicros(DateTimeUtils.scala:389)
  ... 49 elided

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44012/

Yes. The Long.MinValue case contains negative seconds and positive nanoseconds.

@gengliangwang Could you open an JIRA for the issue, so, we will fix this separately from this PR.

@MaxGekk https://issues.apache.org/jira/browse/SPARK-35679

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44012/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44010/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44010/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44012/

Test build #139520 has started for PR 32814 at commit 35b78f1.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44045/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44045/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44045/

Test build #139538 has started for PR 32814 at commit a2326e0.

Test build #139538 has finished for PR 32814 at commit a2326e0.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139538/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44062/

Test build #139520 has finished for PR 32814 at commit 35b78f1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

@cloud-fan @MaxGekk Thanks for the review.
Merging to master.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44062/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44062/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139520/


Postcss

woot. :+1:
I havent pulled down locally but tests are passing, and code is additionally cleaner. Looks good.

Don't merge yet. I still want to do a few more improvements. I think there is a bug when using a class name that matches the element name.
E.g. label .label will become xy .xy.

Want me to pick this one up @devinus? I have open bandwidth.

@motdotla Selfishly, not really. I'd love to be able to hack on this on my flight tomorrow. It's not needed for TS since it changes no functionality other than fixing the @media{ bug so far.

Sounds good :)

@motdotla Ready for review.

Nice cleanup. Tighter.
My only thought is the one comment I left concerning the available alphabet.

Merge away :+1:


The SDK should use executeOnExecutor() method of AsyncTask

Some versions of Android use a single thread for all AsyncTasks to run their onBackground(..) if the execution was started with a call of AsyncTask.execute().
A deadlock will happen if client code started an AsyncTask with AsyncTask.execute() and then performed silent login to OneDrive from AsyncTask's onBackground(..) - OneDrive SDK uses the AsyncTask.execute() method too.
OneDrive's AsyncTask will wait for client's AsyncTask to finish because they are supposed to run on the same thread, but client's AsyncTask can't finish without OneDrive finishing the authorization.
If the SDK used executeOnExecutor(..) method, the problem would be solved.

hi @blazern , would you mind sharing the detail Android versions?

@daboxu, the device had Android 6.0.1

thanks @blazern , I modified our onedrive-explorer-android https://github.com/OneDrive/onedrive-explorer-android for reproducing it, what I did is pretty simple in PlaceholderFragment.java https://github.com/OneDrive/onedrive-explorer-android/blob/master/app/src/main/java/com/microsoft/onedrive/apiexplorer/PlaceholderFragment.java#L77:
                 catch (final UnsupportedOperationException ignored) {
                    AsyncTask.execute(new Runnable() {
                        @Override
                        public void run() {
                            app.createOneDriveClient(getActivity(), serviceCreated);
                        }
                    });
                }

WIth emulator version 6.0 and I cannot reproduce the issue. There could be two potentials to rule out: 1) the emulator does not work 2) my code is not right.
If you don't mind, please share more about the emulator and the code so we can move forward.

Sorry, but I left the place I worked for so the codebase in which I could reproduce the problem is no longer available to me. :(

Ok, I will close this issue for now and if anyone could reproduce it, feel free to reopen it.


[SEVERE] hive_generator:hive_generator on lib/view/provider.dart (cached):  You have to provide a non-null typeId.

when I do "flutter pub run build_runner build --delete-conflicting-outputs"There were error  [SEVERE] hive_generator:hive_generator on lib/view/provider.dart (cached):
You have to provide a non-null typeId. how can I fix it?
import 'package:hive/hive.dart';
part 'history_item.g.dart';
@HiveType(typeId: 0)
class HistoryItem{
@HiveField(0)
final String expression;
@HiveField(1)
final String result;
const HistoryItem(this.expression, this. result);
}
Version
version: 1.0.0+1
environment:
sdk: ">=2.7.0 <3.0.0"
dependencies:
flutter:
sdk: flutter

cupertino_icons: ^1.0.2
math_expressions: ^2.1.0
shared_preferences: ^2.0.5
provider: ^4.1.3
hive: ^2.0.3
hive_flutter: ^1.0.0
dev_dependencies:
hive_generator: ^1.0.1
build_runner: ^1.12.2

Did you solve it? My model looks kinda same, but i get the error: Null check operator used on a null value,. My Model:
@HiveType(typeId: 1)
class RequestData {
@HiveField(0)
Network network;
@HiveField(1)
Response response;
@HiveField(2)
String path;
@HiveField(3)
Method method;
@HiveField(4)
Function(dynamic) parser;
@HiveField(5)
bool cacheRequest;
@HiveField(6)
dynamic body;
@HiveField(7)
dynamic headers;
@HiveField(8)
dynamic queryParams;
@HiveField(9)
StreamController resultController;
RequestData(
this.network,
this.response,
this.path,
this.method,
this.parser,
this.cacheRequest,
this.resultController,
this.body,
this.headers,
this.queryParams);
}

I don't resolve it but actually it's work's ok with this error. Just run
our code
сб, 17 апр. 2021 г., 22:33 sc-ot @.***>:

Did you solve it? My model looks kinda same, but i get the error: Null
check operator used on a null value,. My Model:
@HiveType(typeId: 1)
class RequestData {
@HiveField(0)
Network network;
@HiveField(1)
Response response;
@HiveField(2)
String path;
@HiveField(3)
Method method;
@HiveField(4)
Function(dynamic) parser;
@HiveField(5)
bool cacheRequest;
@HiveField(6)
dynamic body;
@HiveField(7)
dynamic headers;
@HiveField(8)
dynamic queryParams;
@HiveField(9)
StreamController resultController;
RequestData(
this.network,
this.response,
this.path,
this.method,
this.parser,
this.cacheRequest,
this.resultController,
this.body,
this.headers,
this.queryParams);
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hivedb/hive/issues/637#issuecomment-821850195, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQNO4OM3GZM2D5TSPELPE7LTJGZ5NANCNFSM425WHATQ
.

The original issue needs a bit investigation to find cause of the error.
But @sc-ot doing lots of things that doesn't had to be done. You can't store runtime types like methods (  @HiveField(4)   Function(dynamic) parser;) or complex types like StreamController on Hive or any sort of database. Databases meant to be used for storing data & value types.

Yes, was my bad. Thought it was possible with Hive. I already changed it.

i had the same issue , u just need to do following steps--

run the command multiple times
change the typeId to @HiveType(typeId: 1) or @HiveType(typeId: 01)
run the command without any typeId like @HiveType()...
restart ur IDE..
hope one of them will definitely solve the issue :)


Change check rates to explore rates

Short description explaining the high-level reason for the pull request
Changes

change folder check-rates to explore-rates

change testfiles, css classes accordingly

update a couple of tests

Review

@cfarm

Checklist

[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows the standards laid out in the front end playbook
[x] Passes all existing automated tests

This looks good! :+1:
@fna, can you fix the conflicts? I think you can go ahead and merge once that's done.
Also, I added a couple of check-rates links in the related links module PR that'll need to be changed, but I can put in another PR with those fixes after this is merged.


feature/139-tests-for-partner

Created test for PartnerViewSet
You can test them with the command python manage.py test

I have made the changes for the tests. thanks you for the feedback!!

I mean, i changed it to probe that the tests are OK, there is something bad with the permissions in volunteer section.

I thought I writted the comment about, to probe it if there is any error now because i put the rol to ADMIN, but i did not writted it. Totally my bad.

This is the comment i did not write:
Please check if you have some failure now, I changed the role to ADMIN to probe the tests are ok, but we have some kind of error in volunteer permissions that i cant reach. thanks

Now its ok! The failure was that we were trying to update, retrieve and delete a volunteer that is not you, so you cant do that.


Help using rebuild to package node-sqlite3 to use with Electron

I opened an issue here first: https://github.com/electron-userland/electron-builder/issues/7702
But realised this issue potentially needs rebuild.
In short I have the app I want to build with code here:
https://github.com/learn-anything/learn-anything
cd app && pnpm run compile
will do a compile of the app

It completes without errors.
However if you open the resulting app, you get this error:

After googling the error I found this thread: https://github.com/TryGhost/node-sqlite3/issues/1029#issuecomment-414116796
And someone mentioning Rebuild to help solve this

But I don't get how to integrate it to actually solve it even after reading readme.
If you can help, I would really appreciate it ♥
Thank you

I tried instructions from readme and get this

My code uses pnpm instead of npm if it matters and it has monorepo setup.
I am not sure how that would change things for the $(npm bin)/electron-rebuild command

Encountered the same problem。when pack ,native module rebuild failed ;Instead i use level ,Raised an issue at https://github.com/Level/classic-level/issues/84. As noted no need to rebuild  .So how can i skip the rebuild


feat(calendar): add firstDayOfWeek and days abbreviations

This commit adds the ability to set the firstDayOfWeek for Europeans that often starts on monday rather than sunday, and to set a days abbreviations array for days first letter.
This part could be improved though, but don't really know how, feel free to tell me if you got an idea.
Related to #2099.

@oliviertassinari Thanks, I will update my PR and ping again

I though it would be a little overkill to create 7 dates only to find a char, don't we have any way to access the Intl locales without having to do this?

@oliviertassinari I got the Intl for the days abbreviations, but I dunno how to get the first day of the week without having to rely on the getDate method of the Date object, which doesn't seems to follow the current locale.

Sorry, this diff is unavailable.

:grin:

I got the Intl for the days abbreviations

Awesome!

but I dunno how to get the first day of the week without having to rely on the getDate method of the Date object, which doesn't seems to follow the current locale.

Yeah, I think that it's the most difficult point.

Ah sorry, I thought rebasing would be better.
Any idea why the build cannot seems to find the Intl variable?

Any idea why the build cannot seems to find the Intl variable?

I can't see the line changes right now.
Regarding the latest point. Basicaly, we are looking for something like: http://momentjs.com/docs/#/get-set/iso-weekday/.

Will try to fix the commit.
Hum yeah, I thought you didn't want to add an extra dependency like moment, but it would be pretty easy with it yes

I thought you didn't want to add an extra dependency like moment

I definitly don't want to. Here is their implementation https://github.com/moment/moment/blob/11b18a8c5e8a7970d38352f96f226c3351b89a43/src/lib/units/day-of-week.js#L154.

Okay the commit is now fixed, I removed the merge so you can see the diff.
Also I looked a bit this method and actually don't know how we can use it to fit our needs (my mind is really bad with dates and timezone :smile:), and do we really will have to re-implement each method we need to not include a library?

@oliviertassinari I updated the changes to handle the build issue and use a fallback when Intl is not available. Would you consider merge this PR with the firstDayOfWeek parameter?
I'm thinking the changes with our own implementation of  the first day detection would be out-of-range of this PR and might need a closer look to the possibilities

Would you consider merge this PR with the firstDayOfWeek parameter?

If we don't have better option, yes.

@oliviertassinari I changed the things you pointed out ;)

Wait I need to change something

@oliviertassinari All good :ok_hand: I didn't worked when you didn't provided a DateTimeFormat.
Sorry for all the pings :confused:

Could you add firstDayOfWeek={1} to the DatePickerExampleInternational example?
That we improve our current french example.

@oliviertassinari I changed the docs, comments and the daysArray variable.
Nice catch for ecma the issue, really interesting

@Apercu Really nice PR :+1:
@alitaheri @newoga Do you want to do a final review before merging?

Please could you note the use of the firstDayOfWeek property in docs/src/app/components/pages/components/DatePicker/Page.jsx in descriptions.localised?

Great work @Apercu, That one thing is my only concern. In my country the first day of week is Saturday. Although I know how america works. But I had to check the source to be sure. So a simple clarification can save the users a bit of time. Thanks for the awesome work :+1: :+1:

@alitaheri - that's an interesting point. IMHO without localisation applied, I believe Material-UI date handling should be "international" by default. There's an open issue to make the default date displayed follow [ISO8601] (https://en.wikipedia.org/wiki/ISO_8601) (YYYY-MM-DD), as the US format is ambiguous everywhere, including in the US!
By the same token, I think the default the first day of the week should be also follow ISO8601. This happens to be Monday for better or worse, but at least it would be consistent with a standard, rather than following one countries cultural norm.

By the same token, I think the default the first day of the week should be also follow ISO8601. This happens to be Monday for better or worse, but at least it would be consistent with a standard

I agree, but we have to wait for the next breaking changes release.

In which case, should firstDayOfWeek: 0 equal Monday?

@mbrookes I completely agree. Following the standard is the best possible way to tackle this. But as @oliviertassinari said, it will have to wait since it's a breaking change. so we need to find a way to ease into it or find a way to warn the users ahead of time if transition is not possible.

Yeah, don't want to stand in the way of this PR. Great work BTW @Apercu!

@alitaheri @oliviertassinari Sorry, I've been absolutely slammed.If you both are satisfied, feel free to merge. Seems like there might be some topics to revisit but if the code quality is solid, I'm happy :smile:
I'll review the changes either way tonight

I updated the commit to match the review of  @alitaheri.
For the point raised by @mbrookes I totally agree, but do you think we will remember to change this in the next breaking version?

@Apercu Thanks :tada: !

but do you think we will remember to change this in the next breaking version

I have added it here: https://github.com/callemall/material-ui/issues/2109.

@oliviertassinari @alitaheri @mbrookes @newoga Thanks for the positive feedbacks and your work! Happy to contribute :tada:
(Should be the last ping from me (on this PR!) :smile:)

Thanks a lot, this was surely an important feature to have! :+1: :tada: :tada:


[iOS]  Action.Submit button in ActionSet in adaptive card as task module does not do anything

Teams iOS 4.5.0
User presses long on a message in Teams iOS to trigger context menu and then selects action based message extension "an action"

Bot receives composeExtension/fetchTask
Bot creates this card in nodejs:
let card = CardFactory.adaptiveCard({
          "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
                 "type": "AdaptiveCard",
                 "version": "1.0",
                 "body": [
                       {
                         "type": "TextBlock",
                         "text": "Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum Lorem ipsum",
                         "id": "text",
                         "wrap": true
                       },
                       {
                         "type": "Input.Text",
                         "id": "inputText",
                         "placeholder": "Some placeholder",
                         "maxLength": 2000,
                         "isMultiline": true,
                         "isVisible": true
                       },
                       {
                         "type": "ActionSet",
                         "id": "actionSet",
                         "actions": [
         {
                             "type": "Action.Submit",
                             "title": "Submit",
                             "data": {
                               "type": 1
                             }
                           }
                         ]
                       }
         ]});

Bot returns the task module with card:
res.json({
        task: {
          type: 'continue',
          value: {
            card: card,
            height: 400,
            title: 'Test form submit',
            url: null,
            width: 500
          }
        }
      });

Teams iOS shows the task module but pressing the submit button does not do anything and nothing is received by the bot

@matthiasdilger - We are investigating your query. We will get back to you once we have any update.

hi @Nivedipa-MSFT, were you able to reproduce the issue?

@matthiasdilger - We are still checking this. We will update you soon.

@matthiasdilger - We have checked this in Teams IOS version 4.4. But we are not getting the adaptive card. Blank popup is coming.

@Nivedipa-MSFT Yes, Teams iOS 4.4 did not display anything because of this issue: #5271
You need to update to version 4.5.0 to reproduce this issue here.

@matthiasdilger - Thanks for the updates. We will update the Teams version and check again. We will inform you soon.

@matthiasdilger - As of now for us the latest version is showing as 4.4.0 and we are not able to update to 4.5.0

@Nivedipa-MSFT Interesting, latest version is 4.5.1 according to https://apps.apple.com/us/app/microsoft-teams/id1113153706

@matthiasdilger - Our iOS device is not showing any updates to upgrade it to 4.5.0 .
We will check it in next 1 or 2 days for updates & will try you issue once we get latest version.

@matthiasdilger - We have raised a bug for it. We will let you know once we get updates on it.

@Nivedipa-MSFT Hi, is there any timeline on when this bug will be fixed? It's still present in Teams iOS 4.7.0 and severely impacts functionality IMO. Thanks

@matthiasdilger - We have informed Engineering team about the same and they are currently working on the fix. We will inform you once we have further update. Thanks!

Hi @Nivedipa-MSFT This issue still persists in Teams iOS 4.10, do you have any update on when this bug will be fixed? Thanks.

@matthiasdilger - We have informed Engineering team about the same and they are currently working on the fix. There is no such ETA to share. We will inform you once we have further update. Thanks!

@Nivedipa-MSFT Thanks for the tip!


undefined method `to' for #<RSpec::Matchers::DSL::Matcher allow>

Having a really odd problem. to seems to be undefined all of the sudden. We recently went from a 2.x version to 3.5 so I'm thinking that might have something to do with it and it just wasn't caught until now.
to is working fine with except.
I feel like I have some wonky piece of configuration that I might be missing but I can't track it down. Any ideas?

Just realized I meant to put this in rspec-exceptations. That said, I did some more digging and this definitely looks isolated to me. Sorry for the noise.

@jjbohn Can you please put together a reproducible example demonstrating this issue?

@jjbohn allow is a method provided by rspec-mocks so I think this belongs here.  I'll reopen this.
Anyhow, based on your error, it looks like maybe you have defined an allow matcher with RSpec::Matchers.define :allow, which would cause a matcher object that returns #<RSpec::Matchers::DSL::Matcher allow> when inspected.  If you've done that, you'll need to rename it so as not to conflict with rspec-mocks allow method.

@myronmarston you're completely right. Just found it as I was doing some further digging. Thanks for the help!


Create config output for playground

Hey, it would be cool to easily use playground with forgae's dev net and its accounts. Why not output a config for playground to do all this? Both as file and maybe copy-paste from console output.

@maptuhec was there an update about this?

Hey @thepiwo @nikita-fuchs  currently, we don't have any progress or update on this. All of the accounts are available from the console when starting the node, the compiler port is also available. We can add information about the node. This is will be pretty easy. About extracting them into a file, we can create an issue and plan it for sprint 44.