Bug: wrong view type when opening file twice

I don't know if this is intended, but I would like to get the file whenever the user opens it (even when they click on it again without opening it in a new tab). I am using the active-leaf-change event. For the first opening of the file, the leaf.view.getViewType() is correct and the parameter leaf is a valid file. However, when I click on the same file again the leaf.view.getViewType() changes to file-explorer where the file itself is undefined.
I just wanted to ask if this is intended. If yes, how can I fix the issue, so that I always see the correct file, no matter how many times the user clicks on the file?
Steps to reproduce:

Open a file with a simple left click (view type is markdown)
Left click and open the file again (view type is file-explorer)

This is intended - if you click on the file explorer twice then it focuses the file explorer instead of the note leaf. In your case you are looking at the active leaf which is now a different leaf than the note.
Also active-leaf-change means the focused active leaf has changed, not that a file has been opened. If you have two tabs then switching between them will cause active leaf change events. Focusing on sidebar accessory panes will also cause that to trigger.


Introduce priority queueing for incoming client operations on distributor

We have priority queues in several places in the content layer today:

Communication managers
Visitor scheduling
Persistence threads

But when a set of messages is handed off to the distributor main thread for processing it all happens entirely in FIFO order. This means that if you have a combination of small high priority operations and large & expensive lower pri bulk operations, the former may be starved by the latter.
By introducing priority queueing for operations arriving from external clients, we let high priority operations sneak past, potentially greatly lowering their latency (of course, with the usual starvation caveats that are inherent to priorities). Note that we should only prioritize client requests; internal API protocol requests and responses must not be reordered, lest we break core assumptions of how operations are ordered relative to each other.

Fixed by #3736


Error with external UMD module when bundled for production

⚠ IMPORTANT ⚠ Please do not ignore this template. If you do, your issue will be closed immediately.

[x] Read the docs.
[x] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.

Describe the bug
In my app I import the module jotform-css.js which is a UMD module. It works fine in dev, but when I build for production using vite build (standard configuration) I get a js error in the console
index.c0db2c01.js:1 Uncaught TypeError: e.cssjs is not a constructor

Reproduction
https://github.com/gertqin/vite-umd-js
Follow the steps in the readme.
System Info

vite version: 2.0.4
Operating System: Windows 10
Node version: 14.16.0
Package manager npm and version: 7.6.0

I looked into dist/assets/vendor.*.js and I noticed that the production build doesn't export the cssjs function for some reason:
e.cssjs=t;var r={};export{r as c};

Updating the vendor file to export cssjs fixes the issue:
e.cssjs=t;var r={cssjs: t};export{r as c};

I'm thinking this is related to the pre-bundling stage somehow

That module is not exporting anything, is only defining a global variable. You can import it and then use that variable, or find a plugin that will convert this legacy module into an ES module, like https://github.com/rollup/plugins/tree/master/packages/legacy/#readme (but I tried without success in this example)
This works in your example
import "jotform";
console.log(new cssjs().parseCSS("*{color:blue}"));

I'll close the issue as this doesn't seems to be a Vite bug.


[R10K::TaskRunner - ERROR] on OSX (yosemite) host

I am running an osx (yosemite) host, with a potential Ubuntu 14.04 guest VM.  However, I am unable to vagrant up a git repository:
$ sudo vagrant up
Password:
Bringing machine 'default' up with 'virtualbox' provider...
==> default: vagrant-r10k: Building the r10k module path with puppet provisioner module_path "puppet/modules". (if module_path is an array, first element is used)
==> default: Checking if box 'ubuntu/trusty64' is up to date...
==> default: A newer version of the box 'ubuntu/trusty64' is available! You currently
==> default: have version '20150430.0.0'. The latest is version '20150902.0.1'. Run
==> default: `vagrant box update` to update.
==> default: vagrant-r10k: Building the r10k module path with puppet provisioner module_path "puppet/modules". (if module_path is an array, first element is used)
==> default: vagrant-r10k: Building the r10k module path with puppet provisioner module_path "puppet/modules". (if module_path is an array, first element is used)
==> default: vagrant-r10k: Beginning r10k deploy of puppet modules into /Users/jeff/github/machine-learning/puppet/modules using /Users/jeff/github/machine-learning/puppet/Puppetfile
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a38650> failed while running: Couldn't update git cache for git@github.com:BashtonLtd/puppet-timezone.git: "fatal: Could not read from remote repository."
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a386c8> failed while running: Couldn't update git cache for git@github.com:vaijab/puppet-uwsgi.git: "fatal: Could not read from remote repository."
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a38718> failed while running: Couldn't update git cache for git@github.com:jfryman/puppet-nginx.git: "fatal: Could not read from remote repository."
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a38808> failed while running: Couldn't update git cache for git@github.com:counsyl/puppet-python.git: "fatal: Could not read from remote repository."
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a388a8> failed while running: Couldn't update git cache for git@github.com:counsyl/puppet-sys.git: "fatal: Could not read from remote repository."
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a392d0> failed while running: Couldn't update git cache for git@github.com:puppetlabs/puppetlabs-mysql.git: "fatal: Could not read from remote repository."
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a39348> failed while running: Couldn't update git cache for git@github.com:puppetlabs/puppetlabs-vcsrepo.git: "fatal: Could not read from remote repository."
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a393e8> failed while running: Couldn't update git cache for git@github.com:puppetlabs/puppetlabs-git.git: "fatal: Could not read from remote repository."
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a394b0> failed while running: Couldn't update git cache for git@github.com:puppet-community/puppet-nodejs.git: "fatal: Could not read from remote repository."
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a39550> failed while running: Couldn't update git cache for git@github.com:puppetlabs/puppetlabs-apt.git: "fatal: Could not read from remote repository."
[R10K::TaskRunner - ERROR] Task #<R10K::Task::Module::Sync:0x00000102a395c8> failed while running: Couldn't update git cache for git@github.com:puppetlabs/puppetlabs-stdlib.git: "fatal: Could not read from remote repository."
RuntimeError: Couldn't update git cache for git@github.com:BashtonLtd/puppet-timezone.git: "fatal: Could not read from remote repository."

I've had to change my Puppetfile general syntax from:
 git@github.com:respository/project.git

to the following syntax:
 git://github.com/respository/project.git

And, ensure that the /vagrant/puppet/modules/ directory was pre-created, in order for vagrant up to work.  This is unlike when I run vagrant up from a windows host machine.

@jeff1evesque

Can you confirm that your SSH keys for GitHub work correctly, i.e. that (running from the command line, ideally in the same shell/session that you ran vagrant up in) git clone git@github.com:puppetlabs/puppetlabs-stdlib.git works for you?
If that fails, can you post the output of vagrant up --debug?

Oops, looks like our replies crossed. The git@github.com:user/repo.git form works for me, so I find that rather strange. The debug log and your Puppetfile might provide some helpful information. Alternatively, if you're happy with the workaround of changing the URLs, should I just close this?

It seems to have worked:
$ sudo git clone git@github.com:puppetlabs/puppetlabs-stdlib.git
Cloning into 'puppetlabs-stdlib'...
The authenticity of host 'github.com (<IP_ADDRESS>)' can't be established.
RSA key fingerprint is 16:27:ac:a5:76:28:2d:36:63:1b:56:4d:eb:df:a6:48.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'github.com,<IP_ADDRESS>' (RSA) to the list of known hosts.
remote: Counting objects: 7311, done.
remote: Total 7311 (delta 0), reused 0 (delta 0), pack-reused 7311
Receiving objects: 100% (7311/7311), 1.48 MiB | 0 bytes/s, done.
Resolving deltas: 100% (3232/3232), done.
Checking connectivity... done.
Jeffs-Air:machine-learning jeff$ ls -l
total 72
-rw-r--r--   1 root  staff  8640 Sep  5 18:04 README.md
-rw-r--r--   1 root  staff  6054 Sep  5 18:33 Vagrantfile
-rw-r--r--   1 root  staff   135 Sep  5 18:04 __init__.py
-rw-r--r--   1 root  staff   256 Sep  5 18:04 app.py
drwxr-xr-x  12 root  staff   408 Sep  5 18:34 brain
drwxr-xr-x   3 root  staff   102 Sep  5 18:27 build
-rw-r--r--   1 root  staff  1551 Sep  5 18:04 license.md
drwxr-xr-x   6 root  staff   204 Sep  5 18:35 log
drwxr-xr-x   6 root  staff   204 Sep  5 18:35 puppet
drwxr-xr-x  24 root  staff   816 Sep  5 18:37 puppetlabs-stdlib
-rw-r--r--   1 root  staff   276 Sep  5 18:04 settings.py
drwxr-xr-x   5 root  staff   170 Sep  5 18:04 src
drwxr-xr-x   8 root  staff   272 Sep  5 18:34 web_interface

Well, i prefer the git://github.com/respository/project.git syntax.  The latter syntax is ssh, whereas alternatives are not, and nice because it helps avoid DDoS.

@jeff1evesque The sudo git clone isn't going to replicate what vagrant-r10k is doing. For the ssh-based URLs (git@github.com:) to work, you'll need to be able to do that clone in your current environment as the same user that you run vagrant up as.

Ah, ok.  Thanks!

My machine currently needs to be adjusted.  I can't run vagrant up, without sudo -- probably same issue here.

ah ok. Well that's certainly a problem, though unrelated to the ssh git clone issue.
For the git clone issue, you probably either don't have your current user's SSH keys setup on github, or if you have password-protected keys, don't have ssh-agent running.
For the vagrant up needing sudo, that's a bit strange to me. It probably either means that something in your current directory is owned by root, or that your user doesn't have the privileges or groups required to run VirtualBox (if you open the VirtualBox GUI, I believe it will do a check for this).

@jeff1evesque if it's ok with you, I'm going to close this, as it seems that we came to the conclusion that this wasn't an issue with vagrant-r10k itself. If you think there's something I could add to the documentation to make it more clear, please reply.
Thanks,
Jason


[SOLVED] error calling Paginator: 'paginate' configuration setting must be positive to paginate

✅ Solved
In the course of working through the issue, I found the issue, but wanted to document the bug here as it was a problem on config, not a bug in the theme. The error message only finally seemed to be popping up.
I had tried in the past to disable pagination, not realizing it has to be built into theme logic to handle.
I had used the default config to start with and changed the paginate value to null, and didn't notice any issues till recently.
  languages:
    en:
      weight: 1
      languageCode: en
      languageName: English
      hasCJKLanguage: false
      paginate: 100 👈👈👈👈👈👈👈👈👈👈👈👈👈 THIS MUST BE A NUMBER, CANNOT SET TO FALSE/NULL

Describe the bug
Hugo Version 0.83.0 breaks pagination logic in CodeIT theme.
I've been able to reproduce by iterating through docker containers for hugo versions until it worked.

Create a docker-compose.yml in your project.
version: '3'
services:
  hugo_server:
    # HUGO_VERSION: 0.xx
    build:
      context: .
      dockerfile: Dockerfile.hugo
      args:
        - HUGO_VERSION=0.87
    environment:
      - HUGO_ENABLEGITINFO=0
    command: server
    volumes:
      - ".:/src"
    ports:
      - "1313:1313"

Create a Dockerfile.hugo in your project.

Once you change the 0.83 to 0.84 the following error is returned:

Error Details Here
  hugo_server_1  | Start building sites …
  hugo_server_1  | hugo v0.84.0-2C4689F7B linux/amd64 BuildDate=2021-06-18T17:14:27Z VendorInfo=gohugoio
  hugo_server_1  | WARN 2021/10/07 17:24:15
  hugo_server_1  |
  hugo_server_1  | Current environment is "development". The "comment system", "CDN" and "fingerprint" will be disabled.
  hugo_server_1  | 当前运行环境是 "development". "评论系统", "CDN" 和 "fingerprint" 不会启用.
  hugo_server_1  | ERROR 2021/10/07 17:24:18 render of "section" failed: execute of template failed: template: 100DaysOfCode/list.html:98:12: executing "content" at <partial "paginator.html" .>: error calling partial: "/src/_vendor/github.com/sunt-programator/CodeIT/layouts/partials/paginator.html:1:20": execute of template failed: template: partials/paginator.html:1:20: executing "partials/paginator.html" at <.Paginator.TotalPages>: error calling Paginator: 'paginate' configuration setting must be positive to paginate
  hugo_server_1  | ERROR 2021/10/07 17:24:18 render of "section" failed: execute of template failed: template: archive/list.html:82:12: executing "content" at <partial "paginator.html" .>: error calling partial: "/src/_vendor/github.com/sunt-programator/CodeIT/layouts/partials/paginator.html:1:20": execute of template failed: template: partials/paginator.html:1:20: executing "partials/paginator.html" at <.Paginator.TotalPages>: error calling Paginator: 'paginate' configuration setting must be positive to paginate
  hugo_server_1  | Built in 4985 ms
  hugo_server_1  | Error: Error building site: failed to render pages: render of "section" failed: "/src/layouts/posts/list.html:20:36": execute of template failed: template: posts/list.html:20:36: executing "content" at <.Paginate>: error calling Paginate: 'paginate' configuration setting must be positive to paginate
  sheldonhullhugo_hugo_server_1 exited with code 255

My configuration has been working till then.

I've changed the paginate values from my defaults and tried to set to 5 as well as 100 and no change in error.
  section:
    paginate: 100
    dateFormat: 2006-01-02
    rss: 10
  list:
    paginate: 100
    dateFormat: 2006-01-02
    rss: 10

Closing as solved, and just documented my notes in case someone else gets this edge case in the future.


How to include tesseract 4.0 into my c++ project using visual studio

Before you submit an issue, please review the guidelines for this repository.
Please report an issue only for a BUG, not for asking questions.
Note that it will be much easier for us to fix the issue if a test case that
reproduces the problem is provided. Ideally this test case should not have any
external dependencies. Provide a copy of the image or link to files for the test case.
Please delete this text and fill in the template below.

Environment

Tesseract Version:
Commit Number:
Platform:

Current Behavior:
Expected Behavior:
Suggested Fix:

hi , i have been using tesseract 3.04 in my project c++ , however i want to change it to use 4.00 since it's more accurate . i did include tesseract 3.04 just by including a path to the include fill . when i download tesseract 4.0 there was no include fill .plz any one can pass me any link to follow the steps  . thank you in advance

Did boíther to read:
"Before you submit an issue, please review the guidelines for this repository.
Please report an issue only for a BUG, not for asking questions."???
If you do not care about it, why we should care about your problem?

im sorry buti have read it actually , but i didn't get what does bug mean ?? and i don't know where can i ask my question ??

can u plz give me some guidness

Maybe you do not under what does it mean bug (see wikipedia). But what is unclear on "not for asking questions"???
There are guideliness for "Creating an Issue or Using the Forum" - do you need more?


[Feature Request] Adding the UNet model to torchvision

Hi,
I was interested in adding the UNet semantic segmentation model architecture to this repository. Are you accepting new models into the repository?

UNet has many variants,  it just means "Encoder-Decoder"+"Skip connections between corresponding layers". Maybe it is not a good idea to add it.


How to use optional nested models with orm_mode?

Question
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.3
            pydantic compiled: False
                 install path: C:\Work\ingress\.venv\Lib\site-packages\pydantic
               python version: 3.8.1 (tags/v3.8.1:1b293b6, Dec 18 2019, 23:11:46) [MSC v.1916 64 bit (AMD64)]
                     platform: Windows-10-10.0.18362-SP0
     optional deps. installed: []

I'm trying to declare a model to have an optional nested model, but I can't seem to get it working properly.
My model is below, and when calling TestModule.from_orm(a_dict_without_graph_settings) I get the error:
pydantic.error_wrappers.ValidationError: 3 validation errors for TestModule
graph_settings -> settings
  field required (type=value_error.missing)
graph_settings -> id
graph_settings -> testmodule_id
  field required (type=value_error.missing)

What am I doing wrong? Having the empty lists (a la List[Execution] = []) works fine... I would just like to have a TestModule where graph_settings = None.
import pydantic

class GraphSettingsBase(BaseModel):
    settings: str

class GraphSettings(GraphSettingsBase):
    id: int
    testmodule_id: int
    series_settings: List[GraphSeriesSettings] = []

    class Config:
        orm_mode: True

class TestModuleBase(BaseModel):
    name: str
    version: int

class TestModule(TestModuleBase):
    id: int
    graph_settings: Optional[GraphSettings] = None
    executions: List[Execution] = []
    created_at: datetime

    class Config:
        orm_mode = True

Thanks for any help!

It's working fine for me:
from typing import Optional
from pydantic import BaseModel

class GraphSettingsBase(BaseModel):
    settings: str

class TestModule(BaseModel):
    name: str
    graph_settings: Optional[GraphSettingsBase] = None

    class Config:
        orm_mode = True

class Foo:
    name = 'hello'

class Bar:
    name = 'hello'
    graph_settings = None

class Spam:
    name = 'hello'
    graph_settings = {'settings': 'whatever'}

print(repr(TestModule.from_orm(Foo())))
#> TestModule(name='hello', graph_settings=None)
print(repr(TestModule.from_orm(Bar())))
#> TestModule(name='hello', graph_settings=None)
print(repr(TestModule.from_orm(Spam())))
#> TestModule(name='hello', graph_settings=GraphSettingsBase(settings='whatever'))

I suspect you have the equivalent of spam.graph_settings == {} (or the equivalent empty class), you either need a pre-validator on that field to return v or None or to populate spam.graph_settings or provide defaults for all GraphSettings fields.


Bump: 0.5.0-next -> 0.6.0

Proposed changes
This PR bumps NGSI Go version from 0.5.0-next to 0.6.0.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[X] I have signed the CLA
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Coverage remained the same at 100.0% when pulling 38d9b16ed96f55bbde04e9a8e1f41d30c66595c3 on fisuda:hardening/release_0.6 into cec5b11d527336d25121ab5cdfb3e3e3c8d6d1a4 on lets-fiware:main.


Remove destructor from each class's documentation listing

Should also exclude operator= and copy constructors

Should also exclude operator= and copy constructors

After thinking for some time, I believe operators should not be filtered out from the documentation.  If anything, should strive to have operators not included in the implementation internal to the class, and instead be a separate piece of code.  Either that, or embrace the operator and give a description in the documentation of why an implementation was needed, or what kind of behavior to expect from it.
Also, that's a separate issue.

This is relatively old.  I'm going to close it because there's a newer technique that will use yaml files rather than in-code documentation.


Use new annotation setting functions

Codecov Report

Merging #315 (3d53115) into master (98c54fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   97.10%   97.10%
=======================================
  Files          48       48
  Lines        1314     1314
  Branches      178      178
=======================================
  Hits         1276     1276
  Misses         14       14
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c54fe...3d53115. Read the comment docs.


Cannot use 'String' as class name as it is reserved - PHP 7

I'm trying to include zend-xmlrpc in a Symfony2 project running in PHP 7 and I'm having this Compile Error:
Compile Error: Cannot use 'String' as class name as it is reserved

Can you please provide:

the full error details
minimal code to reproduce

We've been successfully testing this component against php 7 for over a year now, so we need more details to understand how these compile errors occur.
Thanks!

I'm using an old version fro zend-xmlprc. Sorry.


Updated download information for IP ranges

The Azure IP address range file is now provided in JSON rather than XML. This change updates the page to point to handle the JSON location rather than the old XML location.

@nmackenzie : Thanks for your contribution! The author, @ggailey777, has been notified to review your proposed change.

@nmackenzie I am going to cherry-pick your commit into our private repo to make sure it validates and builds OK.


Make nstar constantly listening and printing events

With the event notification implemented by @marcmo nstar needs to constantly listen for events and print them and not just only read the next message when a request is sent.

...working on it ;)

@marcmo Didn't know that. I pushed #132 but we can merge that afterwards.


Support editing of media files in Step 3

After the files have been selected from Google Drive in Step 2, we currently show them for review in Step 3. We display a thumbnail, file name, description, and edit buttons next to each file information. The edit buttons are currently not functional. It would be a nice addition to support editing of file titles and description before uploading them to Wikimedia Commons.

I am sorry, but I had to roll this in. Feel free to add more stuff later. I just added editing file name and description with thumbnail. Assigning this to me hence.

Done. ✅


Sync main-nuxt into main-xr

Hey @dezine2dev let's check on this please!

Decided we not needed as @dezine2dev is slow on delivery, we find other efficient way and push it directly to main-nuxt


Fix/fix tests

This item belongs to payment request #F78085 on OnlyDust:

from oscarwroche to oscarwroche
35 items included
$1,000 for 2 days of work

This item belongs to payment request #D812A4 on OnlyDust:

from oscarwroche to oscarwroche
35 items included
$1,000 for 2 days of work


Fix tooltip positioning with regards to viewports

A rebased version of #14226.

@cvrebert Excellent thank you!  I'll work on my git-fu for the next submits :)

@cvrebert why it was moved to next version? It affects my app, so I'm looking forward to this fix.
Also, I can help with it, if need

@just-boris I believe the fix is working, it's code coverage in the unit tests that need to be revised.  There are many things that are not tested and I think a big rework of the whole thing would be better, but I leave it up to @cvrebert :)  Maybe you could build your own version of bootstrap including this fix in the meantime?

@ericmartel of course, I tested it with my app and it helped me. But I'm not sure about other cases.

@just-boris Cases where scrolling should affect the tooltip's viewport-adjusted position. See the code review comments.

@cvrebert I will do a "manual" test tonight if I have time and eventually write unit tests for that, but the "auto" behavior should not change from this changelist, since the selection of which side to open the tooltip should show is different than repositioning it based on its content.  A lot of tests are already validating the auto placement and they all seem to pass with this PR.

@ericmartel Any luck with that additional testing?

@cvrebert hey Chris, after reading through the existing tests and validating them, it seems like there are currently 4 tests that properly validate that the scrolling of viewport elements work properly with the auto setting.  I think the misleading part about my PR is that my added test should have been named something along the lines of should not adjust position when scrolling the window, with emphasis on the window part.  That's what this PR tackles as the initial code in tooltip.js would offset the tooltip by the document's scrolling when they were on the body, instead of leaving them by their target.   The getPosition changes are also validated by the 4 auto tests.
All of this to say that, from reading the existing tests, I think the changes are fairly well covered with tests, both for explicit placement and auto placement.
If you have specific tests you would want me to add, feel free to ask!
Cheers
Eric

Okay then. Rebased again, fixed the test description, fixed conflicts related to #15933.
CC: @hnrch02 @XhmikosR for review

Otherwise LGTM.

Any update on this? Can this be merged?

I tried the patch and it fixed the same problem in my project.
All other is also working like a charm.

Holler if there's anything you feel super strongly about here @cvrebert, but otherwise I plan on closing this along with all the other positioning related things given the v4 changes.

Punting as a won't fix—v4 includes a new positioning library for our affix, tooltips, and popovers.


[security] hide user and password from connection string

Try something like the below
 var postgresqlcs = new NpgsqlConnectionStringBuilder(connectionString);
postgresqlcs.Password = {some logic to encrypt of redact the sensitive data}
postgresqlcs.UserName = {some logic to encrypt of redact the sensitive data}
return postgresqlcs.ToString()

The above is for PostgreSQL.
MSSQL use SqlConnectionStringBuilder
MySQL use MySqlConnectionStringBuilder
We are already using these helpers in TenantBootstrapper to validate the connection strings.

try in this way ....

I provided to mask the user and the password with the use of the corresponding provider string builder and I also added a class that contains the constants that were used within the application related to providers.

I also added a small unit test

Thank you this is brilliant!


Output of custom expressions exported into report tables

As discussed today - the ability to export the results of all custom expressions into report tables would be helpful for further stages of data manipulation/visualization (eg. the ability to plot using heatmap for a variety of different trace elements which may be added/subtracted from a SHRIMP runtable over time).

This issue is handled by the current Report Builder.  If further refinements are needed, please make new issues.


EmailVerified Schema Parameter Returns True Without Email Verification After Email Update.

Describe the issue:
When an admin creates a user and invites the user to set a password, the 'emailVerified' schema returns as true only when the user sets the password through the provided link. However, in a scenario where the admin updates the email address, the 'emailVerified' schema still returns true even without the email being verified
https://github.com/wso2/product-is/assets/41188245/245aa0fb-94df-4a5d-9934-1e6cda065b11
after just updating the email ->

How to reproduce:

Create a new user -> Invite user to set password and verify whether the  GET User call returns EmailVerified schema value
Set the password via set password link
again check the the  GET User call returns EmailVerified schema value in here the param can be found and will have the value True.
Then Update the specific user's email and again check the  GET User call's EmailVerified schema value -> Still have the param value as true which is not valid.

Expected behavior:

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Hi melani, I think we are considering two flows here. When we need to trigger a notification when the user updates the email the following configuration Enable user email verification on update should be enabled.

In the admin-initiated user creation flow could you please check if the email verification notifcation is triggered if the above configuration is triggered? If that works we may need to revisit the requirement of this configuration for the ask password flow.

Analysis
There are two distinct scenarios associated with this flow. There's a configuration in the User Attribute Change Verification section to Enable user email verification on update. There are two scenarios based on whether this configuration is enabled or disabled.
Scenario 1: Enable user email verification on update disabled.
When the admin user updates the email of a user, the email claim is instantly updated and the verification is still kept as true as mentioned in this issue. However, since the Enable user email verification on update config is disabled, it's correct to say that the email is verified even after updating to a new one due to two reasons. 1. Verification is not enforced for the updated email. 2. The initial email of the user has been previously verified. Therefore the existing behaviour is correct.
Scenario 2: Enable user email verification on update enabled.
When an admin user updates the email, a verification mail is sent to the new email address. Furthermore, the email claim of the user is not updated to the new email. The email claim still contains the previously verified email. The new email is added to a pendingEmails list in the user schema. Once the user confirms the new email only, the email claim will be updated with the newly verified email. Therefore, at all times the email claim will contain only a verified email address. Therefore the EmailVerified schema parameter returning true is the correct behaviour.
Had a discussion with @DMHP and confirmed that based on the above analysis, the existing behaviour is correct.


[BUG] Review &/ remove the local patch to upstream Rancher charts

Describe the bug

Harvester have certain patch to upstream Rancher charts, when the chart version is bumped, please review &/ remove.
e.g.:
Issue:
https://github.com/harvester/harvester/issues/3969
Harvester PR:
https://github.com/harvester/harvester-installer/pull/505
Rancher PR:
https://github.com/rancher/charts/pull/2715
And the all patches as of 2023.06.12 are:
/go/src/github.com/harvester/harvester-installer/pkg/config/templates/patch$ tree
.
├── rancher-logging
│   ├── 100.1.3+up3.17.7
│   │   ├── configmap.yaml
│   │   ├── daemonset.yaml
│   │   └── eventtailer.yaml
│   └── 102.0.0+up3.17.10
│       ├── configmap.yaml
│       ├── daemonset.yaml
│       └── eventtailer.yaml
├── rancher-monitoring
│   └── 102.0.0+up40.1.2
│       └── nginx-config.yaml
└── rancher-monitoring-crd
    └── 102.0.0+up40.1.2
        └── rbac.yaml

To Reproduce
Steps to reproduce the behavior:

Go to '...'

Expected behavior

The upstream charts can work smoothly in Harvester.
Support bundle

Environment

Harvester ISO version: Harvester v1.2.0
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): N/A

Additional context
Add any other context about the problem here.

Harvester has finished the regulare reveiwing, checking & upgrading of related charts, remove as closed.
e.g.
https://github.com/harvester/harvester/issues/6166


Error: Livestreamer was not found

I have mac os x 10.10 and i get this error. I have done clean reinstall of livestreamer, but it still doesn't work. When i change the path value of livestreamer myself to point to livestreamer folder i get spawn EACCESS error.

Hi,
this was fixed in #55...
A new version will be released this week.

When i change the path value of livestreamer myself to point to livestreamer folder

You need to set it to the livestreamer executable... Try /usr/local/bin/livestreamer

v0.7.2 released...


Allow SSH between frontend and compute

This will allow to connect from the CycleCloud VM to nodes in the compute subnet

@ryanhamel good to review now


Add support for e2e testing suite

Integrate Testing Suite to run e2e testing upon push and merge request

I have just verified and this needs to be done after #8. The Testing Suite only works with the /sessions endpoint and a later version of the Web Drop-in.


⚠ Bofrost.de has degraded performance

In d844517, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1207 ms

Resolved: Bofrost.de performance has improved in 62529ee.


[WIP] Debug intermittent XFA find error

/botio-windows integrationtest

/botio-windows integrationtest

/botio-windows integrationtest

Nice, this seems to confirm my hypothesis.


Feed back to the groups we've spoken to

What
We need to share our work with the groups we've interviewed.
Why
So they can input. And so we're working with them, rather than just extracting information and disappearing.
Must do

[ ] Send out Mural board for feedback

Send out an email sharing this Mural board


Cases where display of generic arguments in a tooltip is sub-optimal

I'm not sure they are particular wrong, but they don't make sense for sure

Yeah, they aren't wrong as such - it's a generic callsite of a generic function - but it's something to improve.  Substitution would be right here.

I'll rename the bug to track cases where we need to improve

This is the only open issue for generic parameters in tooltips I found (did I miss one?), so I'll just post it here:
Using Option.ofNullable as an example, we may also want to tweak how constraints are displayed:

I think as it currently stands, it is a bit confusing.

One option would be to just drop them completely.
Another option (currently my favorite) would be to move the constraints to the bottom:

Line-breaks may be inserted as-appropiate
Or it could be kept as-is

What do you think?

@0x53A I'm +1 with your favorite option, listing constraints where we list the generic parameters
maybe in this order instead:

'T is nativeint (requires default constructor and value type and 'T :> ValueType ...)

In this case we should just substitute and show ofNullable : value:Nullable<nativeint> -> nativeint and nothing else.
There is no reason to show the constraint if it is known to be satisfied in this instance.

When would you show the constraints? Only when mousing over signature / implementation? Never?
I agree that it is kind of superfluous in this case when looking at complete code, but I'm wondering how that would work during development.
E.g. I type Option.ofNullable somewhere and mouse over it. Would it show the constraint if it is in error mode? Would it show the constraint if it infers any random type?
For example
let f x =
    Option.ofNullable|
                     ^cursor

that code is currently valid (but probably not what I want). Would it show the constraints here? I would like to see them, so i know what I need to type next.
So even if it is just for consistency, i vote to always show the constraints.


Add sonar and coveralls

https://github.com/ory/go-acc can be used to merge the reports - https://www.ory.sh/golang-go-code-coverage-accurate/

Merging the reports is no longer required after the code was restructured as part of https://github.com/devatherock/vela-template-tester/pull/46


A doc/ to distribution.xml

Will not do. Unable because of how the packages break into sub-modules.


Mobile styling feedback round 2

Describe the bug
Various styling bugs on mobile
Version
0.47.03
To Reproduce
Steps to reproduce the behavior:

See Screenshots

Screenshots
Buttons have inconsistent colors font size/style
For example, the clear button is red on the left and grey on the right.

Header
Header

Extra proxies and browsers have uneven spacing

Header
Header

Go button misaligned on the diff page

Header
Header

Smartphone (please complete the following information):

Device: [e.g. iPhone6] Pixel 7
OS: [e.g. iOS8.1] Android 14
Browser [e.g. stock browser, safari] FF
Version [e.g. 22] 131

Additional context
Good job @ojigs fixing so many issues last time.

Thanks for bringing this to my attention, @RayBB. These are fixable issues. Hopefully we can get this done with minimal modification to the HTML, just like before. While working on the previous issue, I noticed the difference in font-size between the "save" and other group of action buttons, but it could have been a design preference after all. Let's hear from @dgtlmoon and see if they have any comments on these issues.

I noticed the difference in font-size between the "save" and other group of action buttons,

No likely just some mistake from writing too much code :) they can be the same size
Please open a PR, thanks again!!


Map oracle Date types to timestamp

Hello,
Is it possible to map the datatype in the generated columnvalue to a different type? In my case importing Oracle tables, I want the "Date" type fields to be rendered as a timestamp, because I want to retain the time aspects of the fields and not have it converted to a string (in TypeORM). So currently, I get something like:
  @Column('date', {
    name: 'BIRTH_D'
  })
  public birth_d: Date;

but would prefer to get:
  @Column('timestamp', {
    name: 'BIRTH_D'
  })
  public birth_d: Date;

Thanks.

Column db type will be generated as it is set in db - otherwise generated model wouldn't really suit the db. Not sure about your use case, but if you want to change column types you can just use text editor option - find and replace @Column('date', { replace to @Column('timestamp', {
However I think specifying other sql type in entity definition than it is set in db might even lead to bugs, so you should be really careful about that.

It's a very specific use case admittedly - we're dealing with a very (very) large legacy database that has inconsistent usage with its date columns and to compound the situation the system also runs on MSS databases which have the same columns defined as datetimes - hence my issue with getting consistent values with TypeORM. The number of files and values that are generated make a simple replace impractical and is something we would need to automate (especially since it's still an active development database).
The ideal option for us would be for TypeORM to handle dates and datetimes in the same way (i.e. both converted to Date objects rather than one a string and the other a date). So from what I can see our options are to have specific transformations to convert date strings to date objects behind the scenes, possibly by having a "transformer" setting in the entity definitions (which is kind of daft since it will unconvert a value that has just been converted from a date to a string by TypeORM), modify the TypeORM code for ourselves to not do the conversion above - or change all the Oracle date values to timestamps!

You don't have to replace in files one by one; most tools allow to do it for every file in a folder at once and some of them can be automated.
As for handling dates and datetimes differently - that's probably because they've got different precision. There is a proposal to use transformers instead of standard hydration process, but it isn't implemented yet.
To sum up: I can't think right now of any other way that you didn't list here. The best option really depends on your use case - unifying database columns would be probably the cleaner solution, but yet it might be the most time consuming one.


Numbered lists (and its alias #) are not documented

The problem
S26 mentions numbered lists, and its alias using #
I'm not sure it's implemented, although there are some references to using it as a config option
Suggestions
Create example pods, check out roast, and add whatever is missing. Using :numbered as a configuration option is also part of #2632

I have been working on this. I have made raku-pod-render, which is the basis for Collection, so that it respects the =config directive as per S26.
My plan is to write a plugin for raku-pod-render that implements the numbered lists, and also numbered headings. I plan to use the HTML options for ul to allow for all sorts of numbering options.
I do not think this functionality can be included in Pod::To::HTML

If it's not part of Pod::To::HTML, then we don't have to document it in the core docs. Thanks.


[Gradle Check Retry] Publish/Record tests which pass after a retry to address flakiness

Is your feature request related to a problem? Please describe.

gradle check test failures are now retried as a part of https://github.com/opensearch-project/OpenSearch/pull/2638
This issue addresses the scenarios where the check passes with retries where the flakey tests are lost under the green status

Describe the solution you'd like

As a part of the solution, there should be a record of logs and/or a comment on the PR in case of test failures
The generated report has a log of the tests that fail even though the overall job succeeds
Record the frequent offenders to address and mitigate the underlying root cause for flakiness

Describe alternatives you've considered

Manually keeping track of failed tests from the gradle check bot reports

Additional context

N/A

Hi @kotwanikunal,
I'd like to contribute to this issue!

@yeohbraddy Thanks. Let me know if you have any queries around this.


Update readme to include context and links

@christianlundkvist for your review

@christianlundkvist I updated my readme to include oed's info but it's registering as a conflict. Can you help override the conflict and use my version as the truth here? Thanks.

Oh, the naming change it's on my plate. I'll take care of it.


Replace Instrument interface with io.ReadWriter interface

Should we replace the Instrument interface with io.ReadWriter interface? Stated differently, do we really need the StringWriter and Querier interfaces?
type Instrument interface {
	Read(p []byte) (n int, err error)
	Write(p []byte) (n int, err error)
	StringWriter
	Querier
}

type StringWriter interface {
	WriteString(s string) (n int, err error)
}

type Querier interface {
	Query(s string) (value string, err error)
}

I think the only reason I'm using the StringWriter and Querier interfaces is to handle automatically adding the command termination. Is that true? What about using the Prologix GPIB controller? Would that work without the StringWriter and Querier interfaces?

Closing for now. Given that different instruments require different line terminations, and the same test equipment using different interfaces can require different line terminations, I need to think more about how to handle this problem before changing the Instrument interface.


chore: unique cert value in period

Only reset cert vote value if it is pushed in chain.
Do not give up on cert vote value

prnet cleaned-up successfully


Add boolean to experience models for fulfilling education requirements

Resolves #2839.
Notes:

Merge #2981 first.
Default true for the education table?

Normally its a bad idea to edit migrations created in a different PR, because its hard to know whether those migrations have been run on any of our servers yet (in which case the updated migration won't run the second time).
If you're sure the experience table migrations haven't run anywhere yet, then it's okay this time.

Got it. I'm sure they haven't run in this case.


Create pylint.yml

I'm expecting this to fail terribly, lets see if installing it will work on non-ARM

Lets ruddy go


Bug 1727042: Ensure status monitor always reports upgradeable

Currently on startup the initial status reporting sets the upgradeable
field. However, because of the way the status monitor builder recreates
the entire status block on every report, we also need to set upgradeable
every time that object is reported.
For now, report that upgradeable is always true as long as nothing is in
a degraded state.
Pertaining to these bugzillas:
https://bugzilla.redhat.com/show_bug.cgi?id=1727042
https://bugzilla.redhat.com/show_bug.cgi?id=1727032

Closing in favor of https://github.com/operator-framework/operator-lifecycle-manager/pull/989


New Basemaps: Geometry Category

Description
This PR is for the following sample categories:

Geometry

Notes specific to this PR:

Project sample uses quite a different Basemap due to there not being a direct map for National Geographic so took a new image too
Also in Project sample there was a stray, duplicate Java class that @sclaridge spotted and removed

General comments on Basemap updates:
It updates Map and/or Basemap Constructors as per the new design. This may include the following changes depending on the sample:

Replace Basemap.Type with BasemapStyle
If a lat/long/zoom was being set in the Map constructor, this is replaced with a Viewpoint being set on the MapView.
Any Readme Updates identified

In addition, the samples that include the above changes, or other services requiring an API Key going forward, have the API Key  set within the sample. This will then work in conjunction with the Gradle Task being added in PR 593.
Once 593 is approved and merged into dev we will merge those changes into these PRs and then update all the Samples to 100.10.0-xxxx and do a round of testing of the Samples with all the API Key / Basemap changes at that time. (We have left them as 100.9.0 (in most cases) for now to minimize merge conflicts in the build.gradle file).
In the meantime, the updates listed above can be reviewed. Thanks!

dev merged in (including API Key gradle tasks changes). Samples that have an API Key set have been tested running from the IDE.
Await merging these changes until release.


Bug Report - Debounce is just delaying requests, not really debouncing them

Describe the bug
The debounce feature is just delaying the execution of the request code, and not eliminating the unnecessary requests.
For example, if I set a debounce interval and type "Los Angeles" quick enough on the field, it is doing 11 requests ("L", "Lo", "Los", ..., "Los Angeles") after an interval. The expected behavior for a debounced operation would be to do only one request ("Los Angeles") after the interval.
Reproduction - (required - issue will be closed without this)
To reproduce:

Add a GooglePlacesAutocomplete inside your app, with debounce of ~200ms
Use Flipper (or some alternative) to monitor the API calls done by the app
Type "Los Angeles" quick on the auto complete field
Notice that Flipper will show 11 calls to Google API: "L", "Lo", "Los", "Los ", "Los A", ...
The expected would be only one call with "Los Angeles" after the last letter was typed, and the debounce time was passed.

Additional context

Library Version: 2.5.1

React Native Version: not relevant

[x] iOS

[x] Android

[x] Web

If you are using expo please indicate here:

[ ] I am using expo

Fix
This is happening because we are calling _.debounce many times with different contexts. I fixed it using setTimeout on my own fork:
https://github.com/iuricernov/react-native-google-places-autocomplete/tree/debounce-fix
The diff that fixes the issue:
https://github.com/FaridSafi/react-native-google-places-autocomplete/compare/master...iuricernov:react-native-google-places-autocomplete:debounce-fix

Hello, any idea when this fix will be merged?


Added C++ codes under the language section

📥 Pull Request
Description
Added C++ introduction and functions codes in the CPP folder under the languages section.
Fixes # (issue number)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

hey @ajay-dhangar I made the changes


require('rubico/global') imports the core rubico methods globally

Codecov Report

Merging #217 (4a84512) into master (39525b4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   98.74%   98.74%
=======================================
  Files         229      229
  Lines        3267     3267
=======================================
  Hits         3226     3226
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39525b4...4a84512. Read the comment docs.


feat(FiberedCategory/BasedCategory): add bicategory of based categories

We define the strict bicategory of based categories. Its objects are categories equipped with a functor to some fixed base-category. The strict bicategory of fibered categories will later be built on top of this one.
Co-authored-by: Paul Lezeau<EMAIL_ADDRESS>

This is a remake of a previous PR of the same name, but some awful git accident happened and I think its just easier to remake the PR. (I by mistake added 400 commits to the PR by rebasing instead of merging with master in some weird way).

@joelriou I already incorporated all, except one, of your comments on the previous PR, thanks a lot for them! The suggestion about making BasedFunctor have functor as a field instead of extending Functor I have not changed yet. That is because this change would not let me use the notation F.obj for a F : BasedFunctor, and instead I would have to use F.functor.obj. Is there a way around this?

@joelriou I already incorporated all, except one, of your comments on the previous PR, thanks a lot for them! The suggestion about making BasedFunctor have functor as a field instead of extending Functor I have not changed yet. That is because this change would not let me use the notation F.obj for a F : BasedFunctor, and instead I would have to use F.functor.obj. Is there a way around this?

Ok, let us keep extends.

Thanks!
bors merge


a few macbook and/or retina issues

Thanks for this, it's awesome!  If you prefer I break this up into separate issues let me know... I found a few issues on Macbook that maybe I can take a stab at fixing sometime if you can't get to it.

I can't Cmd-Q to quit

It doesn't show up as an app when cmd-tabbing - may just be a node webkit setting, and may be intentional on your part... might be good to make this an option? I prefer to get to it via cmd-tab if possible - i rarely use the toolbar.

toolbar icon size is goofy on first start, probably due to retina display: http://puu.sh/dh5ec/5ac960d2ba.png

upon change of state, toolbar icon is a better size, but still seems not quite right. probably also retina related: http://puu.sh/dh5iA/3864aa4691.png

I really appreciate the work you've put into this, I know it's simple-ish, but the benefit is huge for those of us who don't want google music to run as a tab, and who want media key shortcuts, so thanks!

Closed due to inactivity and deprecation of project in favor of:
https://github.com/twolfson/google-music-electron


Add ability to send no-show email to attendees

Resolves #29
Description
This PR provides the ability for an admin to be able to send a no-show email to attendees of an event that did not show up or were unknown. The admin simply clicks an email button next to the attendees name and the email is sent.
The email message can be updated via the RSVP Email Settings and supports the {first_name} and {event_title} tags.
There were a number of formatting clean ups and optimizations included in this as well. I'm doing some basic auditing of code and looking for opportunities to make things faster and more efficient.
Visuals

@JasonTheAdams This looks amazing BUT can we move that Email button somewhere else that is not right next to the X/Attended button? In the current placement, there is too high a probability for user error to press the incorrect button.
While in-person, we have a self check-in process with multiple devices set up— volunteers find their name and press the red X to check themselves in. This is already asking a lot and comes with errors at times. Having the button so close would most definitely cause issues.

Hi @dreazee!
Thanks for the feedback. I definitely don't want folks to be accidentally emailed. Hahah! I'm trying to think where else we'd like to put the email button as there's limited room on that screen. Another option would be to add a prompt — which I almost did — so the user clicks on the email button, a prompt pops up saying "Are you sure you want to send a no-show email to {name}?", and then they have to click "Yes" for the email to be sent.
What do you think? 😃
cc: @mathetos

Hi @JasonTheAdams !  Yes. putting that email button next to the delete button could prove even more disastrous. Hmmmm... yeah and it wouldn't make much sense before their name.... Well even if the email icon is moved, the prompt actually sounds like a VERY good idea. I am very much a fan of the "are you sure you want to perform this action" prompt. I think that keeping the email button where it is and adding a prompt makes the most sense.
cc: @mathetos

@dreazee Thanks for your input, I think you raise really important questions here. As I think through this, there's actually quite a few different things happening all at the same time on this small table now. Somehow we have to account for ALL of the following:

Attended = Yes and No
Actions = Delete, Email as Unattended

Because volunteers will be clicking the "Attended" item, it's best if we separate the "Actions" from them a bit. "Delete" and "Email" both seem more like Admin (SDRT Leadership) activities here. So moving the "Email" into the "Actions" column makes a lot of sense to me.
I think the colors are a bit deceiving here as well. So here's my suggestion:

Attended = No = Grey -- As they show up, they are a "?" until they click on that.
Attended = Yes = Green -- That seems obvious
Delete = X = Red -- also very obvious
Email = Blue -- Just giving it a different color will help as well.

With all that in mind, here's my quick and dirty mock-up:

I think this makes everything as clear as possible and potentially as SAFE as possible, without having to add the additional friction of a "are you sure?" popup.

Hi @mathetos and @dreazee!
I took the feedback you provided and put together the following:

Few notes:

Clicking the "?" marks the attendee as attended
Clicking the "X" delete the user but first raises a confirmation to make sure the action is intentional
Clicking the email button emails the user but first raises a confirmation to make sure the action is intentional

How does that look? Are we ticking all the boxes?

I love it. Looks perfect @JasonTheAdams !

Ditto to what @mathetos said. Looks AMAZING!

@JasonTheAdams
One thing that I overlooked is that we need the ability to reverse an attandance. It's possible that someone might click someone elses' name on accident. Currently it looks like we can't "un-attend" someone after that "attended" status is achieved.
I think it's just a matter of making the ✔ be a link still, that will set the "attended" status back to "unknown" or "no".

@mathetos @JasonTheAdams That would be great. It just gets confusing because once that attended circle is checked, a confirmation email gets sent. Would there also be a way to create a function that a user is not allowed to receive more than one confirmation email?

@mathetos @dreazee Thanks for the input. Due to the fact that clicking it sends an email, I'd suggest having a confirmation like I've done with the other two, something like:

Are you sure you want to mark Chun, Helen as attended? Doing so will send an email to<EMAIL_ADDRESS>
Even if we made it possible to reverse it and prevented a second email from going out, that would still mean the admin sent an email incorrectly the first time. As such it seems like we should just try to prevent accidental clicks.
What do you think?

@JasonTheAdams @mathetos  It's not that big of an issue since an accidental check-in rarely happens. During these tutoring events, an admin is not the one doing the check-in; sdrt users self check-in in a rapid fashion. Having an extra step to confirm check-in would impede that quickness, which we do not want. It seems better to just leave it be than put in that extra step for the user to deal with.

@JasonTheAdams Considering Andrea's feedback, let's just add the ability to reverse the attandance alone.

@dreazee @mathetos Thanks for the feedback! I made the following changes:

Clicking the green check circle will now mark the rvsp as not attended (putting it back to gray)
The email will only go out once. Setting it back to tardy and then back again to attended will not resend the email.
As a bonus, the attendance button is now AJAX, so it just happens immediately without requiring a page reload.

You can see it in action here:

Sorry about the slight jump in the button when it changes. There was some legacy styling there that is strangely hard to tweak in this case. I can work more on it but didn't feel it was worth the effort unless told otherwise.

@JasonTheAdams So great, Jason. I don't know what AJAX stands for but I LOVE it! (Ajax was also the name of a previous dog of mine, so by name alone, it's great)

Ajax was also the name of a previous dog of mine, so by name alone, it's great

This is, without a doubt, my favorite response to talking about AJAX I've ever received. 😆
AJAX is simply a technique for moving around data without having to refresh the page. So, in this case, clicking the attendance button used to refresh the page in order to mark the RSVP as attended. Now, via AJAX, you click it and it immediately changes without needing to reload.


使用yarn 提交任务找不到客户端类

Search before asking

[X] I had searched in the issues and found no similar issues.

Java Version
No response
Scala Version
2.12.x
StreamPark Version
2.14
Flink Version
1.18
deploy mode
yarn-application
What happened
使用yarn application模式 提交任务找不到客户端类

Error Exception
No response
Screenshots
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!(您是否要贡献这个PR?)

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please ensure that the job's Flink version and its related dependencies are compatible.


Add Continuous Integration

Hook up the project to Travis CI to make sure we aren't breaking any tests on push and deploy.

https://travis-ci.org/ashwin153/schema


Add is_a edge between CL:0002453 and CL:0011115

I believe "oligodendrocyte precursor cell" should be a child of "precursor cell"

@shawntanzk @dosumis would you have any objection to 'oligodendrocyte precursor cell' ("A progenitor cell of the central nervous system that can differentiate into oligodendrocytes or type-2 astrocytes...") being a subclass of 'precursor cell', as suggested above, or possibly even a subclass of 'progenitor cell' ("A precursor cell that has a tendency to differentiate into a specific type of cell. They are descendants of stem cells, only they are more constrained in their differentiation potential or capacity for self-renewal, and are often more limited in both senses.")?
I'm happy to do the edit if you confirm. Thanks.

I would rather we add 'capable of' some 'cell differentiation' on OPC -> that way it will automatically classify as a precursor cell.
I think we might also have to relook into EA of progenitor cell, currently it is 'precursor cell' and ('develops from' some 'stem cell') which feels too broad, but im not 100% sure on that one.

@shawntanzk

I would rather we add 'capable of' some 'cell differentiation' on OPC -> that way it will automatically classify as a precursor cell.
I think we might also have to relook into EA of progenitor cell, currently it is 'precursor cell' and ('develops from' some 'stem cell') which feels too broad, but im not 100% sure on that one.

But if we make 'oligodendrocyte precursor cell' equivalent to
'neuron associated cell (sensu Vertebrata)' and 'capable of' some 'cell differentiation'
wouldn't that translate into = all neuron associated cells give rise to oligodendrocytes (and not e.g. Merkel cells or perineuronal satellite cells)? Or did you mean subclass instead of equivalent?
I'm not 100% sure about the progenitor equivalence either.

(@shawntanzk adding you as co-assignee for your feedback, thanks.)

oh nice, because of the develops from axiom in OPC, yeah that works, progenitor is under precursor so that basically fixes everything :) Thanks.


Create a script to help create release PRs

Signed-off-by: Sebastian Malton<EMAIL_ADDRESS>An example of the PR that I created while testing: https://github.com/lensapp/lens/pull/5337

Shouldn't it be called create-release-pr.mjs?

Sure

Had trouble on linux running the script:
jim@gregson:~/git/lensStage/lens$ ./scripts/clear-release-pr.mjs patch
current version: 5.5.0
fetching tags...
From https://github.com/lensapp/lens
   cc9ee67dc2..f0b26be79a  master              -> origin/master
   baac515276..a27b92dd89  turn-on-strict      -> origin/turn-on-strict
 * [new branch]            upgrade-electron-18 -> origin/upgrade-electron-18
retreiving last 500 PRs to create release PR body...
Found:
1 enhancement PRs
4 bug fix PRs
16 maintenence PRs

It created a branch on origin (release/v5.5.1) but it didn't create a PR...

Did it display any other logs? If not I will investigate

That's the entire output

Did it just hang? Because I just tried it on my ubuntu machine and it produced #5370

It didn't hang:
jim@gregson:~/git/lensStage/lens$ ./scripts/clear-release-pr.mjs patch
current version: 5.5.0
fetching tags...
From https://github.com/lensapp/lens
   cc9ee67dc2..f0b26be79a  master              -> origin/master
   baac515276..a27b92dd89  turn-on-strict      -> origin/turn-on-strict
 * [new branch]            upgrade-electron-18 -> origin/upgrade-electron-18
retreiving last 500 PRs to create release PR body...
Found:
1 enhancement PRs
4 bug fix PRs
16 maintenence PRs

jim@gregson:~/git/lensStage/lens$

But I also have trouble with make clean && make dev on ubuntu with this PR branch. master was ok.


Add AzCopy utilities and support single blob uploads

I tried to only include the minimum needed for single blob uploads for this first PR. As we discussed in triage, if AzCopy isn't installed we just open a link to the download page.

Per offline discussion: We'll ship the AzCopy executables with our extension. I will investigate to see how easy it is to port over only what we need from "@azure-tools/azcopy-node". Otherwise, we'll take that package as a dependency

So I installed from .vsix to do some spot checking and I haven't been able to upload a blob... (or have I?)

Any idea?

So I installed from .vsix to do some spot checking and I haven't been able to upload a blob... (or have I?)

My bad not testing with the vsix 🥵 I specified that the exe packages shouldn't be webpacked and updated getAzCopyExePath to also check the "dist" folder for node modules (that's where they end up after webpacking)
I also fixed the success message after an upload failure. I forgot to handle errors that happen in callWithTelemetryAndErrorHandling

I noticed that chmod in the "postinstall" script would throw an error because the linux exe package doesn't exist (when run on mac). So I changed the script to swallow chmod errors

Rather than swallowing the error, why don't you make a specific task for Linux and Mac?
https://github.com/microsoft/vscode-azurestorage/blob/master/.azure-pipelines/main.yml

Rather than swallowing the error, why don't you make a specific task for Linux and Mac?
https://github.com/microsoft/vscode-azurestorage/blob/master/.azure-pipelines/main.yml

Do you know if there's a way to do platform specific commands in the package.json scripts? We only run into the problem here: https://github.com/microsoft/vscode-azurestorage/pull/729/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R770

So you should be able to define which build scripts to run in yml files.  For example, look at the build.yml, it has the commands it runs.  So you can run the npm script to run the installs that way.

@nturinski you've got it covered - @wwlorey feel free to merge


Disable deployment on PR

Disable PR deployment as it's in error for all external PRs (will still work on main branches commits or merges)

@jlooper is that ok for you? That would avoid having all PRs reporting errors.

@jlooper is that ok for you? That would avoid having all PRs reporting errors.

Yes thank you!!! Been meaning to do this


SO_REUSEPORT and Windows.

Another issue as well is that it also will try to use the SO_REUSEPORT which does not exist on windows.
Originally posted by @AraHaan in https://github.com/Py-KMS-Organization/py-kms/issues/36#issuecomment-974976325

@AraHaan could you care to send us some logs? As far as I can see we have implemented a check against that...

Fixed in 11e8b4d2fceca01375c947b687ea2aa354c24b32


Adding AspNetCore Authentication Sample

Adding a folder for Authentication which contains AspNetCore solution samples for authenticating with Azure AD. First sample is with Implicit Grant.
Purpose
The purpose is to provide a sample for authentication with Azure AD. The difference however is most authentication mechanisms cannot live on a basic html page. So the idea here is to provide a simple solution with common C# server implementation and readme to quick start Azure AD authentication.

...

Does this introduce a breaking change?
[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Install Visual Studio with C# and build the solution and run. However, to authenticate you must provide your own configuration.

What to Check
Verify that the following are valid

...

Other Information

Lets sync up next time we are both in the office. It might make sense for this to be its own GitHub repo and we simply cross link.

We'll follow up with samples in a seperate repo.


Domain/Realm validation regex prevents valid inputs

The regex for validation seems arbitrary, requiring the tld to be 2-6 characters.  This prevents domains and realms that end in .internal or other domains that may be out of admin control to change.
To Reproduce
Steps to reproduce the behavior:

Go to /control_plane/roles/control_plane_common/tasks/verify_omnia_params.yml
Edit value: domain_name: "c.mysandbox.internal"  OR realm_name: "C.MYSANDBOX.INTERNAL"
Attempt to run the playbook
See error:

fatal: [localhost]: FAILED! => {
    "assertion": "realm_name is regex(\"^(?!-)[A-Z0-9-]+([\\\\-\\\\.]{1}[a-z0-9]+)*\\\\.[A-Z]{2,6}$\")",
    "changed": false,
    "evaluated_to": false,
    "msg": "Failed. Incorrect realm_name formate in omnia_config.yml"
}

Expected behavior
Valid realm name is accepted and task Validate the realm name completes successfully.

Please try mysandbox.internal as domain_name and MYSANDBOX.INTERNAL as realm_name. domain name and realm name variables do not take in the hostname. The variables just accept the domain name (already set on the host) without hostname.
If user wants to specify the hostname, it can be mentioned in mapping_file.

Hi, thanks for the reply.  c isn't actually the hostname, it's just another segment of the domain.  The issue is that the regex itself has a hard limit {2,6} which prevents internal from validating.

@asu-wdizon we will address regex hard limit immediately.


release 1.59 to pypi

Just an issue to track that 1.59 needs to be released now that the notes are merged :)

Done!


KeyError at /admin/auth/user/ 'actions_row'

Hi,
Maybe this is a silly question but I've tried my best before posting it.......
After a fresh install with python 3.11.3 and django 4.2.1, I managed to make unfold run by adding the app in settings.py.
All looks good until I click on "Users" or "Groups". A KeyError comes out on 'actions_row'.

Looks like the default context doesn't include the actions_row key pair somehow. Is it an attribute brought by unfold?
Thank in advance!
Justin

Hi, which version of theme are you using? Can you create sample repo when we can replicate issue?

Thanks @lukasvinclav !
I've uploaded the codes to https://github.com/justinqian42/testapp.
The unfold version is the latest 0.6.2
What I did is quite simple.

Create a virtual env.
Install django 4.2.1 and django-unfold 0.6.2 with pip.
Start a new django project.
Add unfold into settings.py
Make migrations and migrate with manage.py
Run server.
Open http://<IP_ADDRESS>:8000/admin
Click on Users or Groups. The KeyError pops out.

The username/password is unfold/unfold.
Computer is Macbook Pro 16 with M1 chips.
Also tested on a windows machine and got the same.

Is it possible to make your testing repo public?

Is it possible to make your testing repo public?

Done.

Same error here having:

python:3.11.3-alpine
Django>=4.2.0,<4.3.0
django-unfold>=0.6.3,<0.7.0

New version has been released fixing this issue.

Thank you so much!


Journal Application Form Bug

Co-editor field must be not mandatory. It should be deleted.

form has an :bug: i am fixing it


How to use this SDK with Swift?

Hi,
I am working on Swift based project and I have to download and upload images in that app. I have already used your SDK with Objective C and it worked great! But now I want to use your SDK with Swift language but you haben't mentioned the steps on how to use this SDK with Swift. Please help me in that regard as I have mentioned my query on Stackoverflow but I didn't get any help from there!

I havent done it but you should just be able to #import <SDWebImage/SDWebImage.h> in your bridging header that is generated if you have a mixed swift/objc-c project. if it's a pure swift project you need to add that header yourself (which i don't know how to do myself, but you can force xcode to do it for you if you add an obj-c file and throw that file away afterwards).

Cocoapods support Swift.
Import via Cocoapods.
import SDWebImage in your swift sheet.
look for sd_* methods on UIImageView!

How to resolve this issue?

[This might help]
(http://www.thelittlebakery.org/2015/02/objective-c-swift-projects-bridging-header/)

We need to add a Swift section in our Readme.md file, explaining how to get SDWebImage working with Swift.

a list with all available functions would be nice, too.

The problem is that extensions don't work with Swift frameworks yet. Several CocoaPods are suffering from this :(((
http://stackoverflow.com/questions/24175596/swift-framework-does-not-include-symbols-from-extensions-to-generic-structs
Please make some noise in the Apple forums and feedback.

Here's how I got it working (using CocoaPods and dynamic frameworks, no messy bridging headers):
Podfile:
platform :ios, '8.0'
use_frameworks!

target 'MyApp' do
  pod 'SDWebImage'
end

Run pod install. Then, at the top of your source file add:
import SDWebImage

Now it's ready to use!
cell.imageView.sd_setImageWithURL(myUrl)

closing this based on comments above. thanks @adrianmacneil

Hi @amacneil  ,
i have installed the pod file, but there is no "SDWebImage" file , when i am trying to import "import SDWebImage" i am getting error


Bugfix in collection config history mgr

Use proper stop key to prevent iterator returning results from next namespace
Signed-off-by: manish<EMAIL_ADDRESS>Type of change

Bug fix

Additional details
The bug seems to have escaped because in the code we always call this API with the block number present in the version of the private data (or hash) item. Ran into this issue when loading all the configs for a namespace for populating private data store from a snapshot.

@Mergifyio backport release-2.2


Try/catch parseSnapshotInputs

Problem solved
Make it so we throw instead of silently failing when parsing
Changes made

[x] try/catch parseSnapshotInputs

/release-pr

@nachoiacovino let me know if we still need this, closing for now


Fixed #62

I've fixed bug described in issue #62, can you please accept this pull request and update podspec file?

Merged. Thank you for your contribution and I'm sorry for my late response!

No problem, I'm happy to contribute :)
Seems like tag 0.2.7 is on the same commit as tag 0.2.6.
Can you move tag 0.2.7 to the latest commit?
Thank you for this great control!

I fixed the wrong tag.
It's my pleasure, thank you for using it!

Hi, there are 3 commits to master since 0.2.7 tag (tags 0.2.6 and 0.2.7 are the same).
Can you please fix this?
Thanks

Can you also commit podspec.json to the CocoaPods Specs?
https://github.com/CocoaPods/Specs/tree/master/Specs/AKPickerView

Hi, any chance of fixing 0.2.7 tag and updating CocoaPods Specs (see my 2 previous posts) ?
Thank you

Done. Thanks https://raw.githubusercontent.com/CocoaPods/Specs/5b3d72e3ac73f2e97343bd7b09ec8d5c6ee31f4d/Specs/AKPickerView/0.2.7/AKPickerView.podspec.json

Thank you for your quick response.
Sorry for bothering you but tag 0.2.7 is not correct.
https://github.com/Akkyie/AKPickerView/releases/tag/0.2.7
There it says
Akkyie tagged this on May 14 · 3 commits to master since this tag

Sorry for my repeatedly mistake… I fixed it.

No worries, thank you for the fixes!
Greetings to Japan :)


Fix black flicker on resize

Describe the issue
Previously resize happened in the OnImGuiRender functionthis runs after OnUpdate where the framebuffer gets filled.
This resulted in ImGui rendering an unfilled/new texture on every resize.
PR impact
List of related issues/PRs this will solve:

Impact
Issue/PR

Issues this solves
#7

Other PRs this solves
None

Proposed fix
This changes the code to do the resize as the first step in OnUpdate before we will render to the framebuffer, so we always have a filled framebuffer to render in OnImGuiRender.

Looks like a good solution to me 👍
This does feel like part of the renderer preparations, so maybe this should be part of the renderer prep scope, right before binding the framebuffer?
https://github.com/martin-zyb/Remc/blob/9edfe0d14836165af3d6132f7fd0855563c08b43/RTShell/src/EditorLayer.cpp#L43-L48
Another reason why I would change this, it does feel like the CameraController should be updated depending on the current visible frame instead of on the new one, meaning that the first thing would be the m_CameraController.OnUpdate(ts);
So my suggestion would look like:
 	void EditorLayer::OnUpdate(Remc::Timestep ts)
	{
		REMC_PROFILE_FUNCTION();

		// Update
		m_CameraController.OnUpdate(ts);

		// Render
		Remc::Renderer2D::ResetStats();
		{
			REMC_PROFILE_SCOPE("Renderer Prep");

			// Resize
			if (Remc::FramebufferSpecification spec = m_Framebuffer->GetSpecification();
				m_ViewportSize.x > 0 && m_ViewportSize.y > 0 && // zero sized framebuffer is invalid
				(spec.Width != m_ViewportSize.x || spec.Height != m_ViewportSize.y))
			{
				m_Framebuffer->Resize((uint32_t)m_ViewportSize.x, (uint32_t)m_ViewportSize.y);
				m_CameraController.OnResize(m_ViewportSize.x, m_ViewportSize.y);
			}

		m_Framebuffer->Bind();
		Remc::RenderCommand::SetClearColor({ 0.1f, 0.1f, 0.1f, 1 });
		Remc::RenderCommand::Clear();
		}

 		... // The rest of the existing code

Any thoughts?

Hmm, not entirely sure. Would have to look into how the camera does things. But I think right now it doesn't really make any difference.
The PR as is was to maintain original resize 'flow'.
Before:
OnUpdate
OnImGuiRender <- Resize Happened in here
OnUpdate

After:
OnUpdate
OnImGuiRender <- Resize change 'request' here
OnUpdate <- Change viewport and camera before actual render

I am happy to change it, but I am not sure what the intended 'flow' is supposed to be here now. Right

Hmm, not entirely sure. Would have to look into how the camera does things. But I think right now it doesn't really make any difference.
The PR as is was to maintain original resize 'flow'.
Before:
OnUpdate
OnImGuiRender <- Resize Happened in here
OnUpdate

After:
OnUpdate
OnImGuiRender <- Resize change 'request' here
OnUpdate <- Change viewport and camera before actual render

I am happy to change it, but I am not sure what the intended 'flow' is supposed to be here now. Right

You don't have to change it. I can see that you want to keep the layout, and it won't affect the camera at all as of now.
The main reason I asked is for the profiler, where it doesn't make a lot of sense (to me) that the resize would be counted as part of the on_update loop, and not part of the rendering, hence why I would've put it inside the "Renderer prep" scope. Another thought would be to put a profile scope "Renderer resize" or something. However this might indeed be outside the scope of this PR, so no need to change that.

Hmm, not entirely sure. Would have to look into how the camera does things. But I think right now it doesn't really make any difference.
...
I am happy to change it, but I am not sure what the intended 'flow' is supposed to be here now. Right

You don't have to change it. I can see that you want to keep the layout, and it won't affect the camera at all as of now.
The main reason I asked is for the profiler, where it doesn't make a lot of sense (to me) that the resize would be counted as part of the on_update loop, and not part of the rendering, hence why I would've put it inside the "Renderer prep" scope. Another thought would be to put a profile scope "Renderer resize" or something. However this might indeed be outside the scope of this PR, so no need to change that.

I agree, though I think eventually this frame buffer resize should probably live in some other place, like a PreUpdate or PostRender phase maybe, not sure.


Fix 199 ruff errors

Explain what problem this PR is resolving
The python linter ruff is not enable on this project because it raises too many errors to fix at once. At the time of writing, ruff check src raises 375 errors.
Self proofreading checklist
Not relevant for these changes.

[ ] The new code clear, easy to read and well commented.
[ ] New code does not duplicate the functions of builtin or popular libraries.
[ ] An LLM was used to review the new code and look for simplifications.
[ ] New classes and functions contain docstrings explaining what they provide.
[ ] All new code is covered by relevant tests.
[ ] Documentation has been updated regarding these changes.

Changes
The first commit contains the result of ruff check src --fix, which contains safe automatic fixes to the codebase.
I then ran ruff check src --fix --unsafe-fixes and added the following commits with the changes that I reviewed manually and deem ready to commit:

Fix: Generator loop -> 'yield from'
Fix: Type annotations could be improved
Fix: Python < 3.10 is no supported anymore
Fix: Ruff errored on exception raising

How to test
Run ruff check src or hatch run testing:ruff.
ruff check src on the code found 176 errors after the changes.

I've reviewed every commits up one by one and all seems to make sens (even if I don't get the point of extracting a message from the exception?) and everything seems good :+1:
On the other hand I don't understand why you haven't added ruff to the CI? Also the CI is failing weirdly for things unrelated to this PR I think?

I had the same reflection: Not sure why the CI failed on this PR while it passed for another one around the same time... :thinking:
We did not add ruff to the CI because the remaining 176 errors contain non trivial changes and I don't know of any tool similar to codecov but that would look at the increment/decrement in linter errors in the codebase.
Syncing dependencies
cmd [1] | black --check --diff .
--- /home/runner/work/aleph-vm/aleph-vm/src/aleph/vm/conf.py	2024-09-03 16:53:16.680400+00:00
+++ /home/runner/work/aleph-vm/aleph-vm/src/aleph/vm/conf.py	2024-09-03 16:55:05.973700+00:00
@@ -284,13 +284,11 @@
would reformat /home/runner/work/aleph-vm/aleph-vm/src/aleph/vm/conf.py
     BENCHMARK_FAKE_DATA_PROGRAM = Path(abspath(join(__file__, "../../../../examples/example_fastapi")))

     FAKE_DATA_MESSAGE = Path(abspath(join(__file__, "../../../../examples/program_message_from_aleph.json")))
     FAKE_DATA_DATA: Path | None = Path(abspath(join(__file__, "../../../../examples/data/")))
     FAKE_DATA_RUNTIME = Path(abspath(join(__file__, "../../../../runtimes/aleph-debian-12-python/rootfs.squashfs")))
-    FAKE_DATA_VOLUME: Path | None = Path(
-        abspath(join(__file__, "../../../../examples/volumes/volume-venv.squashfs"))
-    )
+    FAKE_DATA_VOLUME: Path | None = Path(abspath(join(__file__, "../../../../examples/volumes/volume-venv.squashfs")))

     # Tests on instances

     TEST_INSTANCE_ID: str | None = Field(
         default=None,  # TODO: Use a valid item_hash here
--- /home/runner/work/aleph-vm/aleph-vm/src/aleph/vm/models.py	2024-09-03 16:53:16.680400+00:00
+++ /home/runner/work/aleph-vm/aleph-vm/src/aleph/vm/models.py	2024-09-03 16:55:06.231799+00:00
@@ -184,11 +184,13 @@
would reformat /home/runner/work/aleph-vm/aleph-vm/src/aleph/vm/models.py
             if self.resources:
                 # Already prepared
                 return

             self.times.preparing_at = datetime.now(tz=timezone.utc)
-            resources: AlephProgramResources | AlephInstanceResources | AlephQemuResources | AlephQemuConfidentialInstance
+            resources: (
+                AlephProgramResources | AlephInstanceResources | AlephQemuResources | AlephQemuConfidentialInstance
+            )
             if self.is_program:
                 resources = AlephProgramResources(self.message, namespace=self.vm_hash)
             elif self.is_instance:
                 if self.hypervisor == HypervisorType.firecracker:
                     resources = AlephInstanceResources(self.message, namespace=self.vm_hash)

I have also checked running hatch fmt which also run ruff but I think under another config and it make other changes. Such as
-async def get_message(hash_: str) -> Optional[dict]:
+async def get_message(hash_: str) -> dict | None:

I have pushed more ruff fix and a black run


Play audio from a slice

Hi! I have all my audios decoded in a f64 slice. Could you give me a hint in how I can create a buffered Source from this slice to use in Sink to play audio?
Thanks!

SamplesBuffer implements the Source trait: https://docs.rs/rodio/latest/rodio/buffer/index.html#example
You won't be able to use it with f64 samples though, as the trait is not implemented for f64: #196
I guess you'll have to implement Source manually on a newtype over slices and do the conversion internally. Alternatively, you can send a PR to implement Source for f64 too :)


hwmv2: espressif: port all esp32-based boards

This soc was not created properly, and the original board file which was then cloned for all the other boards was wrong too and should never have been merged
Port needs finishing (feel free to continue): the cpu clusters in the soc need adding and setup properly, boards need to select them properly, and esp32sc3 needs to have the soc parts done properly

@nordicjm You mean this SoC was not properly create in this collab-hwm branch or also in main branch?

@nordicjm You mean this SoC was not properly created in this collab-hwm branch or also in main branch?

main, there is a soc series which boards are selecting, no actual soc entry and instead that's left as a part number for which one board doesn't even select

@nordicjm Will you submit a PR to main as well?

@nordicjm Will you submit a PR to main as well?

No, it needs to be tidied up here and ready for merging as part of hwmv2

I've seen you also updated xtensa's ESP32 boards to V2 model. Let me know if I can help and/or if there will be pending changes about it. Thanks.

@sylvioalves what is going on with this? Why are there 2 Kconfigs to select which core is being used that seemingly don't need either to be selected https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/xtensa/espressif_esp32/esp32/Kconfig.series#L21 e.g. for esp32_devkitc_wroom

@sylvioalves what is going on with this? Why are there 2 Kconfigs to select which core is being used that seemingly don't need either to be selected https://github.com/zephyrproject-rtos/zephyr/blob/main/soc/xtensa/espressif_esp32/esp32/Kconfig.series#L21 e.g. for esp32_devkitc_wroom

This is used in AMP use case. This is how we select which core is used for any of the AMP applications.

I will update this in a couple of hours.

@nordicjm Will be there a new PR fixing MAINTAINERS.yml fixing folder structure or can I just fix in this PR?

@nordicjm Will be there a new PR fixing MAINTAINERS.yml folder structure or can I just fix in this PR what is esp32-related?
-- Generating done
-- Build files have been written to: /runner/_work/zephyr/zephyr/doc/_build
cmake --build _build --target html
[0/2] Generating Devicetree bindings documentation...
[1/2] Running Sphinx HTML build...
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/xenvm/' in 'files' in area 'Xen Platform' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/gd_gd32/' in 'files' in area 'GD32 Platforms' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/arm/silabs_*/' in 'files' in area 'SiLabs Platforms' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/arm/ef*/' in 'files' in area 'SiLabs Platforms' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/arm/mimx*/' in 'files' in area 'NXP Platforms (MCUX)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/arm/frdm*/' in 'files' in area 'NXP Platforms (MCUX)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/arm/lpcxpress*/' in 'files' in area 'NXP Platforms (MCUX)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/arm/twr_*/' in 'files' in area 'NXP Platforms (MCUX)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/arm/vmu*/' in 'files' in area 'NXP Platforms (MCUX)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/arm/nxp_imx/' in 'files' in area 'NXP Platforms (MCUX)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/arm/nxp_kinetis/' in 'files' in area 'NXP Platforms (MCUX)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/arm/nxp_lpc/' in 'files' in area 'NXP Platforms (MCUX)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/arm/*s32*/' in 'files-exclude' in area 'NXP Platforms (MCUX)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/arm/s32*/' in 'files' in area 'NXP Platforms (S32)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/arm/mr_canhubk3/' in 'files' in area 'NXP Platforms (S32)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/arm/ucans32k1sic/' in 'files' in area 'NXP Platforms (S32)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/arm/nxp_s32/' in 'files' in area 'NXP Platforms (S32)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/xtensa/nxp_adsp/' in 'files' in area 'NXP Platforms (Xtensa)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/xtensa/nxp_adsp_*/' in 'files' in area 'NXP Platforms (Xtensa)' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/xtensa/esp32*/' in 'files' in area 'Espressif Platforms' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/xtensa/espressif_esp32*/' in 'files' in area 'Espressif Platforms' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/riscv/esp32*/' in 'files' in area 'Espressif Platforms' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/riscv/espressif_esp32*/' in 'files' in area 'Espressif Platforms' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/arm/xilinx*/' in 'files' in area 'Xilinx Platforms' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'boards/cypress/xmc*_relax*/' in 'files' in area 'Infineon Platforms' does not match any files
/runner/_work/zephyr/zephyr/MAINTAINERS.yml: glob pattern 'soc/arm/cypress/' in 'files' in area 'Infineon Platforms' does not match any files
/runner/_work/zephyr/zephyr/doc/_build/src/boards/boards_legacy/xtensa/index.rst:6: WARNING: toctree glob pattern '**/index' didn't match any documents

Maintainers file can be updated here, the error there is likely because the xtensa directory is now empty and can be removed along with listing it in the index file

@nordicjm, would you take a look in reference board esp32s3_devkitm regarding cpucluster and board definitions?
https://github.com/zephyrproject-rtos/zephyr/pull/69194/commits/d4c2e17cba1f1f23334983af9de842f60b135dfd

CI must be passing

@sylvioalves merging this now as-is to make it into hwmv2, please address above issues with new PRs, thanks

Seems you missed the esp32c3_luatos_core boards.
Those are done as two boards but documented as one.

https://github.com/zephyrproject-rtos/zephyr/pull/69663


Android can't recognize voice on run time

After speaking something, Android cannot recognize any voice input. Need runtime code to capture voice.
I have used AndroidPermission :

But it did not work.
Please tell us how to resolve this. I have to make it work within 29/6/18

I got it working, still need help?

@rpavez can you give your example code? please

@rpavez how it's worked? Voice start() not working for me. Even i am not getting any warning or error?

@Swyanmitra Did your solved your problem?


Middleware.firstRun and UniversalBot.beginDialog(address, dialogId)

I am having a first run middleware setup in order to pickup and store the address of the user. It is supposed to run only once and not be called ever again for that specific user, as long as the address is valid. Speaking of which, how long is the address of a user valid (session.message.address)?
Additionally, when I store the user's address, there is a cron running which checks for certain conditions, and prompts the user with UniversalBot.beginDialog, using the stored address.
The problem is that when beginDialog is called, the dialog stack is reset, and for some reason the session data which holds the version of the first run middleware is also reset (session.userData[consts.Data.FirstRunVersion]), so instead of calling the dialog specified in beginDialog, the dialog which is bound to the firstRun middleware is triggered.
What is the recommend workaround for this? Is this the expected behaviour?
bot.use(builder.Middleware.firstRun({ version: 1.0, dialogId: '*:/firstRun' }));
bot.dialog('/firstRun', [
  function (session) {
    builder.Prompts.text(session, "Hello, I am saving your address for later use. Say anything to confirm.");
  },
  function (session, results) {
    tmpStorage[session.message.user.name] = { address: session.message.address };
  }
]);

bot.dialog('/', function(session) {
  session.send("Hello there, it's not yet the time. I'll get back to you later.");
});

bot.dialog('/doStuff', function(session) {
  session.send("Hey there again!");
});

setInterval(function() {
  Object.keys(tmpStorage).forEach(function(user) {
    bot.beginDialog(tmpStorage[user].address, '/doStuff', {user});
  });
}, 2 * 1000);

This will output "Hello, I am saving your address for later use. Say anything to confirm." every 2 seconds, instead of saying "Hey there again!" every 2 seconds.
Cheers
Almir

Sorry for the delay. I'm on vacation... A couple of things. The length of time the address is valid really depends on the channel. Some addresses will always be valid while others can periodically change. We've been saying that in general you should probably refresh the address every 15 days or so.
It's expected that calling beginDialog() will reset the dialog stack, that's what its supposed to do but it shouldn't be touching userData. I'll have a quick look at the code.

So looking at the code the only way you would get a new userData object is if the user ID had changed which seems unlikely. I can try to reproduce this but it may be a week or so after I get back from vacation.

I guess I am the second person facing the same issue

@Stevenic @carlosscastro I have also similar problem
https://github.com/Microsoft/BotBuilder/issues/2311

So one thing I noticed in look at my code and your code. The first run version is only ever saved once the first rin dialog completes. I don't see you calling endDialog() from your first run dialog anywhere.
The other thing I'd suggest is looking at the updated basics-firstRun example. I've updated it to show a better way of doing first runs that doesn't require the use of middleware. This updated version shouldn't have this issue.

Closing this for now. Please feel free to add further comments.

@Stevenic Whats the length of time the address is valid for skype?


Support a few more complex types with DefaultTempDataSerializer

Fixes https://github.com/aspnet/AspNetCore/issues/9540

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=192053

This comment was made automatically. If there is a problem contact<EMAIL_ADDRESS>I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2329
https://github.com/aspnet/AspNetCore-Internal/issues/2348
https://github.com/aspnet/AspNetCore-Internal/issues/2422


Migrate FxCop to Net analyzers

Looks like a FxCop is getting depercated, next step is shifting from fx cop over.

Just found this: https://docs.microsoft.com/en-us/visualstudio/code-quality/migrate-from-fxcop-analyzers-to-net-analyzers?view=vs-2019
And: https://github.com/StyleCop/StyleCop#considerations
Is this relevant for PowerToys?
Originally posted by @Jay-o-Way in https://github.com/microsoft/PowerToys/issues/8094#issuecomment-734796252

since we'll need chances are .net 5+ for ARM (#490), we'll need to do this shift

Is there anything keeping this issue open or is all done?

Jay, this is not done to best of my knowledge since i just checked the nuget page at the solution.

Whoops, I totally overlooked this issue and created my own. I prepared a pull request which adds
Microsoft.CodeAnalysis.NetAnalyzers
and removes the deprecated Analyzers:
Microsoft.CodeAnalysis.FxCopAnalyzers
Microsoft.CodeQuality.Analyzers
Microsoft.NetCore.Analyzers
Microsoft.NetFramework.Analyzers
Microsoft.CodeAnalysis.VersionCheckAnalyzer
See #16210

i think we can add the Resolution-Fix-Committed label here

Much obliged 🙂

With the above pr, all instances should be done. However, when I search the files for simply the term "FxCop", there are still other things. Are those obsolete now too? CC @davidegiacometti

Probably old suppressions.
I think suppressions for CA1031 could be cleaned up from the source code now that project is on .NET Analyzers.
Could be part of https://github.com/microsoft/PowerToys/issues/9560

@Jay-o-Way: You are right, this can be simplified. I found a few more occurrences and fixed them as well. Thanks for pointing out!

When searching for "FxCop", there seems to be a bit more...