Adding an empty data values to a library removes that libraries' data values

What steps did you take:
Adding empty data values to a library with existing data values is successful on v0.31.0 but when updating to v0.32.0, it now reports an error.
.
├── config.yml
└── _ytt_lib/
     └── library/
          └── config.yml

config.yml
#@ load("@ytt:data", "data")
#@ load("@ytt:library", "library")
#@ load("@ytt:template", "template")

#@ library = library.get("library")
--- #@ template.replace(library.with_data_values(data.values).eval())

_ytt_lib/library/config.yml
#@ load("@ytt:data","data")
---
dvs: #@ data.values.example

_ytt_lib/library/values.yml
#@data/values
---
example: I should appear in the output of the library

What happened:
(v0.32.0+) When the data values that are defined in the library are used in that library, ytt cannot find them.
ytt: Error:
- library.eval: Evaluating library 'library':
    in <toplevel>
      config.yml:10 | --- #@ template.replace(library.with_data_values(data.values).eval())

    reason:
     - NoneType has no .example field or method
         in <toplevel>
           _ytt_lib/library/config.yml:3 | dvs: #@ data.values.example

What did you expect:
Just like what happens when using v0.31.0, I expect this to succeed.
dvs: I should appear in the output of the library

Anything else you would like to add:
In v0.31.0 the type of an empty data.values is struct. In v0.32.0+ it is NoneType. When adding a NoneType data values to the library via with_data_values(), it is interfering with the data values that already exist for the library.
This is happening because we overlay a nil data value Document onto the existing data values, essentially wiping the existing data values.
https://github.com/vmware-tanzu/carvel-ytt/blob/develop/pkg/workspace/data_values_pre_processing.go#L63
A possible solution could be to check if a data values value is nil prior to overlaying or adding it to the list of data values.
Environment:

ytt version (use ytt --version): v0.32.0+
OS (e.g. from /etc/os-release):

Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.

Thanks for the succinct reproduction, @cari-lynn, this is very clear. 👍🏻
This is undesirable behavior. I'm wracking my head to think of a case where we'd want Data Values to be actually null/None and not just empty. Gonna chew on that, myself.
In the meantime, this is decidedly a regression ==> "carvel accepted"
And you reproduced the defect ==> "can be replicated"

This is a regression with known impact. There's a work around (where authors can defensively perform a null/None check), but we don't want that to proliferate.
Let's get this in for v0.35.0 ==> "Prioritized Backlog"

The fix for this will be available in the next release v0.35.0. An empty data values is a struct once again rather than None.

v0.35.0 was released a few days ago. Closing out this issue.


Create continer failed due to DVDI_VOLUME_NAME is not valid

I was using 0.27.0 dvd driver and the env json is as following:
root@mesos002:~/src/mesos/27/mesos/build# cat /opt/env.json
{
"DVDI_VOLUME_NAME": "123",
"DVDI_VOLUME_DRIVER": "convoy"
}
I was always getting this error when launch a task
E0314 20:17:41.391485  2008 docker_volume_driver_isolator.cpp:485] Environment variable DVDI_VOLUME_NAME rejected because it's value contains prohibited characters

the checking is there to prevent injection attacks, and perhaps is too
strict I realized when I put it in that it restricts the character set to
and in particular probably prohibits non-English characters.
The fear was that some organizations enable non admin access to the
Marathon UI, and since the isolator invokes the DVDCLI as root, an
injection attack is theoretically possible.
I will be adding to the document, and one of my proposals is to remove the
check, or move the implementation to a place outside the isolator
I believe that Mesos in general already has this exposure to injection
attack in places, for example I think the containerization may invoke a
command line command as root - so when moving this into Mesos, it would be
no worse than code that is already there. And if this worries somebody it
would be better to put the protection on the exec function and protect
everything in one place. Thus my proposal to remove the checking.
BTW I might not put this detail about the injection attack risk in the
public document.
For non-open-source software it is the EMC policy to avoid publishing
security exposures. We don't have any official policy for open source, but
I think t may be prudent to avoid publishing this until a fix is in place
On Mon, Mar 14, 2016 at 5:27 AM, Guangya Liu<EMAIL_ADDRESS>wrote:

I was using 0.27.0 dvd driver and the env json is as following:
root@mesos002:~/src/mesos/27/mesos/build# cat /opt/env.json
{
"DVDI_VOLUME_NAME": "123",
"DVDI_VOLUME_DRIVER": "convoy"
}
I was always getting this error when launch a task
E0314 20:17:41.391485 2008 docker_volume_driver_isolator.cpp:485]
Environment variable DVDI_VOLUME_NAME rejected because it's value contains
prohibited characters
—
Reply to this email directly or view it on GitHub
https://github.com/emccode/mesos-module-dvdi/issues/81.

I tested this using the RexRay volume driver and had no issues when using a volume name of "123"

Thanks @cantbewong I think that we can close this now.


no Perf logs for the "memoryRssBytes" counters on Win Nodes.

Hi everyone!
I have a Windows node pool, and I'm using KQL queries to retrieve performance data from Log Analytics. As described in #71464, when I search for logs with the counters "memoryCapacityBytes" or "memoryRssBytes", I don't get any results.
So, #71464 is an Issue from over two years from now. Is there any solution to this problem? Maybe a misconfiguration?
Example using "memoryRssBytes":

Example using "memoryWorkingSetBytes":

Thank you all in advance!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b4c6b0d1-f378-2ea0-6e34-9887cddeda7f
Version Independent ID: 4c81c0fe-2cd2-2fa9-a36e-2eae2910b5ed
Content: Query logs from Container insights - Azure Monitor
Content Source: articles/azure-monitor/containers/container-insights-log-query.md
Service: azure-monitor
Sub-service: containers
GitHub Login: @bwren
Microsoft Alias: bwren

@OldScratchy
Thanks for your feedback! We will investigate and update as appropriate.

@OldScratchy Thanks for your feedback! We will investigate and update as appropriate.

Hi @bwren! Any news about the problem?


Executing npx hedera-local start freezes at ` generating accounts

Description
Executing the following steps leads to freezing
Steps to reproduce

npm install<EMAIL_ADDRESS>-g
npx hedera-local start

The output the following:

Additional context
No response
Hedera network
other
Version
v1.0.1
Operating system
macOS

Screenshots from the hedera-node:

Should be fixed with https://github.com/hashgraph/hedera-local-node/pull/121
@Daniel-K-Ivanov could you verify this fixes the issue on your end?


Change of below-limit amount handling.

Put rains, tips, and soaks that do not meet the limit to the next rain, tip, or soak. Or, just donate it. You spam and mess around, you pay the price.

I completely disagree with this suggestion.


Typo "Other Computer Resources" instead of "Other Compute Resources"

Hi @snobu, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@snobu - Thanks!


Stop an automation?

Do you think its possible to stop an automation?
Use case - a motion sensor detects motion and turns on some lights, there is also a rule to turn the lights off after a couple of mins.
Say its a room that today you're going to be in a while, it would be nice to cancel the lights off automation rule if a switch or similar turns the lights on.

How to stop automation? By automation id?
Look at my solution:
kitchen_workspace_on_by_motion:
  trigger:
    platform: state
    entity: Motion Kitchen
    attribute: occupancy
    state: true
  action:
    - entity: Kitchen Workspace
      service: custom
      data:
        state: 'ON'
        brightness: 250

kitchen_workspace_off_no_motion:
  trigger:
    platform: state
    entity: Motion Kitchen
    attribute: occupancy
    state: false
    for: 120
  condition:
    platform: state
    entity: Light Kitchen
    state: 'OFF'
  action:
    - entity: Kitchen Workspace
      service: turn_off

Kitchen Workspace light turns on by motion sensor and turns off if no motion for 120 seconds but only if Kitchen light (base light) disabled.


Zabbix Agent 3.4 Support

Addressed issue #10 by adding support for Zabbix agent 3.4. Still need to remove EOL operating systems and compare agent config files from 3.2 vs 3.4.

@thespain don't suppose you've had a chance to look at this, have you?


Calling NamadaApp::sign after NamadaApp::get_signature yields 0: Ledger | App Error: | 27012 apdu parameters invalid

Using the Namada App with the following call sequence:

NamadaApp::clean_randomness_buffers
NamadaApp::get_spend_randomness
NamadaApp::get_convert_randomness
NamadaApp::get_output_randomness
NamadaApp::sign_masp_spends
NamadaApp::get_spend_signature
NamadaApp::sign

results in the error 0: Ledger | App Error: | 27012 apdu parameters invalid during the call to NamadaApp::sign. This error is displayed by our client namadac at the point when the Ledger device was supposed to display the transaction.
The error seems to be due to the logic at https://github.com/Zondax/ledger-namada/blob/5ed06a4d6d3347e301cf5afc02aba0e319eef57a/app/src/nvdata.c#L146 clearing the randomness buffers when the last spend signature is retrieved by NamadaApp::get_spend_signature. This is problematic because the following call, NamadaApp::sign, checks that the number of spend description information objects in the MASP Transaction builder is equal to the number of spend randomness parameters during the MASP Builder section parsing process. The analogous equinumerosity checks for the convert descriptions and randomness parameters would also fail for the same reason.

Can be closed once https://github.com/Zondax/ledger-namada/pull/69 gets merged


change brands to use new licensing URL

'phet' and 'interoperable' branches use this URL for licensing in Brand.js:
url: 'http://phet.colorado.edu/en/html-terms-privacy-and-licensing'
When the website is updated, this should be change to the new URL.

7/16/15 status meeting, request by @kathy-phet:
• Use the correct URL in Brand.js (URL to be determined)
• Put up the webpage, even if it's a copy of what currently exists.
• Maintain redirect for old URL
• Required for "Summer 2015 redeploy"

I put the licensing at the new url: licensing/html and added a redirect. We discussed potentially using a different url, but since there wasn't one decided upon I went with the existing thought of licensing/html.

@aaronsamuel137 make sure you update the all branches of Brand.js that use this URL.

We discussed potentially using a different url, but since there wasn't one decided upon I went with the existing thought of licensing/html.

I know there was some dissent at yesterday's meeting, but I wanted to throw in my $0.02 and say I think licensing/html will be good.

Forgot to reference commit on branch phet: 3c45cb6fe87c342c377a90453be9fa8649818f59

This should be ready to go, assigning to @pixelzoom for review.

I don't see the correct URL indicated anywhere in this issue, so I'm assuming that http://phet.colorado.edu/en/licensing/html is the correct URL.  Assigning back to @aaronsamuel137 to verify. If that's the correct URL, then go ahead and close this issue.

Yep that's correct. Closing.


feat: Debug Features

Added:
Gameplay Debug Features
-Acrtivate God Camera + paralize player ( Number 4)
-Full Health (Number 7)
-Immortality (Number 8)
-One Attack Death (Number 9)
-Teleporting (Number 0)

Also, if you could fix the conflicts that this pr has, that would be fine. Remember to keep your branch periodically updated with the branch you will be finally merging into (in this case game-programming), so you'll avoid big conflicts like this ones.


Missing device configuration: 0x0384:0x0200:0x000a:2.7

Checklist

[X] It is not in the configuration DB

[X] It was not merged recently or has a pending PR

Which device is missing?
Unknown
Manufacturer ID
0x0384
Product Type
0x0200
Product ID
0x000a
Firmware Version
2.7
Is the device listed on the Z-Wave Alliance website?
No response
Do you have a manual?
Reported by Telemetry:

capability
value

associationGroups
["Lifeline","Basic set"]

supportsAGI
true

supportsConfigCCV3
false

supportsZWavePlus
true

zWavePlusVersion
1

If anyone plans on helping out with this file, please read https://zwave-js.github.io/node-zwave-js/#/config-files/using-telemetry-data first.

@zwave-js-bot import config 2906 from zwa


Fix missing access_token attribute in Configuration

The attribute access_token in Configuration is needed in Configuration.auth_settings().
However, it is never set in Configuration.__init__().
This leads to an exception when you try to make an API call based on a configuration.
For example, here is a call of get_webhooks in the EventsAPI:
File "...", line 53, in get_webhooks
    api_response = api_instance.get_webhooks(path_params={"realm": realm})
  File "phasetwo/paths/realm_webhooks/get.py", line 255, in get_webhooks
    return self._get_webhooks_oapg(
  File "phasetwo/paths/realm_webhooks/get.py", line 185, in _get_webhooks_oapg
    response = self.api_client.call_api(
  File "phasetwo/api_client.py", line 1137, in call_api
    return self.__call_api(
  File "phasetwo/api_client.py", line 1063, in __call_api
    self.update_params_for_auth(used_headers,
  File "phasetwo/api_client.py", line 1241, in update_params_for_auth
    auth_setting = self.configuration.auth_settings().get(auth)
  File "phasetwo/configuration.py", line 367, in auth_settings
    if self.access_token is not None:
AttributeError: 'Configuration' object has no attribute 'access_token'

This pull request adds access_token to Configuration.__init__() as an optional parameter with default None. This way, it is possible to pass access_token to Configuration so that the authentication for API calls succeeds.

Thanks for the PR!


I can't even get the samples to work

Hi Brock,
I've tried everything to get even one sample to work. I'm running under IISExpress and set "access" overrideModeDefault to "Allow" as defined in the "configuring_client_certs_readme.txt" file. I keep getting page not found.
Anyhelp would be greatly appreciated.
R

Are you asking about IdentityServer3? I think you're posting to the wrong repository.

No it was with the MembershipReboot samples in this git repository. I figured it out. I installed SQL Express as a default instance and the Config files in the sample were pointing to (LocalDb)11.0....  I  removed the 11.0 and now all samples work fine :)
Thanks for getting back to me and sorry for my misconfiguration.
R


delete protein folding experiment

Moved to https://github.com/qiskit-community/quantum-protein-folding

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-12.9%) to 67.472%

Totals

Change from base Build<PHONE_NUMBER>:
-12.9%

Covered Lines:
726

Relevant Lines:
1076

💛  - Coveralls


change "description" to "descriptions" in the rejected schema required properties

https://github.com/CVEProject/cve-schema/blob/a9640925fd82b9461596ff506ebe56984959f480/schema/v5.0/CVE_JSON_5.0.schema#L1208
Typo in schema will cause validation errors since it requires a field that is not defined. (We need a way to check/ensure schema itself is valid after each change.)

agreed to change the required field to descriptions


Is quiffen compatible with pandas 2.x?

I'd like to use quiffen on a simple utility I'm writing.
When my requirements.txt pins pandas>2.0.0, the resolver limits me to quiffen 1.2.4.
When my requirements.txt pins quiffen>2.0.0, the resolver limits me to pandas 1.5.3.
I'm running Python version 3.11.3 on macOS.

I've not tested on pandas 2.x. You should be able to force install it into your environment using something like pip install --no-deps. If it works, feel free to submit a PR to adjust the dependency version!

I'm generating requirements with pip-compile, and it doesn't appear to have a mechanism to let me override or ignore conflicts. I'm on a tight deadline and my project is simple so quiffen 1.2.4 will suffice. The quiffen interface has been easy to work with, thanks!


xbox: Fix errors in stdatomic.h

This should fix the copy&paste errors in stdatomic.h found by @Ryzee119

Thanks Thrim, I have tested this fix locally and it now successfully links.
I had a scan over the remainder of the file and could not see any other issues.


Tal Rasha 2pc Much More Lenient on Procs

Hello,
I've found an issue with the Tal Rasha 2pc.  This is very minor, but in the game it is much more lenient than the 4pc or the 6pc.  If you read the bonuses, the 4pc and 6pc specify attacks.  The 2pc only quotes damaging enemies.
What this means is, you can have on a Band of Hollow Whispers and the cold damage haunt will proc an ice meteor.  I can absolutely verify this is true.  I am witnessing this behavior over and over in my current game, and I am dead certain that the ring is the only thing producing cold damage.  Currently the simulator is not capturing this.

Hmm I dunno why I added the check in the first place, thanks.


Space Travelers' Hub

Space Travelers' Hub
This is a web application for a company that provides commercial and scientific space travel services. The application will allow users to book rockets and join selected space missions.
Implemented Feature

[ ] Config & basic setup
[ ] Redux: Fetch data and update Redux store
[ ] Render UI: Rockets
[ ] Render UI: Mission
[ ] Render UI: My Profile section
[ ] added  Test

Hi @prolajumokeoni Thank you so much for approving this project


Card component

References:

http://nikgraf.github.io/belle/#/component/card?_k=zc4tyc
http://jxnblk.com/rebass/components/Card
https://react.semantic-ui.com/views/card
http://www.material-ui.com/#/components/card

Can i take this it it's competed?

Go ahead, @jyash97. Tell me if you need any help.


Tarjan's Algorithm | C++

🚀 Feature
Implementation of Tarjan's Algorithm in C++ to find the number of strongly connected components in the graph.
Have you read the Contributing Guidelines on Pull Requests?
Yes.
Motivation
It is an interesting algorithm to learn and implement as it can help one to grasp the concept of strongly connected components and in time and low time of vising a node in a graph.
Pitch
This is another approach in addition to Kosarajau's Algo to find a number of strongly connected components(SCC). It is based on the idea of in time and low time of a graph. And one can implement it using one DFS call as compared to Kosaraju's which requires 2 DFS calls.

I would like to work on it. Please assign this to me.
I would be grateful if you add a DWOC label to this issue.

I'm Interested in this and would like to contribute under DWoC.
I've decent knowledge about data structures and algorithms.
Can you please assign me this?

I'm Interested in this and would like to contribute under DWoC.
I've decent knowledge about data structures and algorithms.
Can you please assign me this?

Hello @atharvagadkari05
Since @singhsaurav23 created the Issue and specifically mentioned C++, I have assigned him the Issue on the same. If you would like to take up this Issue in any other language, feel free to suggest!

@singhsaurav23
Ok, I'm comfortable in java and would like to contribute in this.

@shraddhavp  @saurav  do we have to make changes in master branch or in some other branch??

@atharvagadkari05 fork the master, and start making changes on the local branch and then push the changes in the local branch.

@singhsaurav23 can you be little more
specific about the changes? Do I have to simply write tarjan's algorithm in java and push it to the local branch?

please assign me this issue in Java under Dwoc @HarshCasper sir.

please assign me this issue in Java under Dwoc @HarshCasper sir.


Nominate Andrew Block as WG Artifacts chair

With WG Artifacts chartered we need to select 2-3 people to chair it. Chairs schedule and lead meetings, facilitate technical discussions, and keep timelines and roadmaps for deliverables on track.
I'd like to nominate @sabre1041 (Andrew Block) as one of the chairs of WG Artifacts.

cc: @joshgav @sabre1041

+1, @sabre1041 would be great for his cross-project perspectives

+1 binding, would be great to have @sabre1041 help lead the group
For a bit of background, Andy (@sabre1041) is a hardworking, reliable, smart leader in the cloud computing industry. He's a maintainer for Helm and many other cloud projects and a frequent conference speaker and organizer. By day he's a distinguished engineer and major contributor at Red Hat.

+1 binding
Andy is heavily involved across the cloud native communities and, especially with artifacts

This is a amendment to https://github.com/cncf/tag-app-delivery/pull/428.
@joshgav process to merge this to make it official?

On Wed, Feb 7, 2024, 10:15 Ramkumar Chinchani @.***>
wrote:

Any progress on this? Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/cncf/tag-app-delivery/issues/516#issuecomment-1932614086,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBXQWFZ3DEOPE3LSHH7OSLYSPADJAVCNFSM6AAAAABANCISPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSGYYTIMBYGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@AloisReitbauer @thschue seeking your votes on this please, thank you!

+1

Thank you everyone! Next step is to open a PR on this repo to add Andy in all the right places.
Let's take Alex off at the same time too. Thank you!

Post a PR.
https://github.com/cncf/tag-app-delivery/pull/554

Thanks @rchincha and congratulations @sabre1041 ! Looking forward to supporting your ongoing work.


[RFR] Factory for field Views

Following #307, and refs #294, this PR introduces the second part of the factories: widget factories.
A widget factory looks like the following:
define(function(require) {
    "use strict";

    function getReadWidget() {
        return '<ma-string-column value="::entry.values[field.name()]"></ma-string-column>';
    }
    function getLinkWidget() {
        return '' + getReadWidget() + '';
    }
    function getFilterWidget() {
        return '<ma-input-field field="::field" value="values[field.name()]"></ma-input-field>';
    }
    function getWriteWidget() {
        return '<ma-input-field type="email" field="::field" value="entry.values[field.name()]"></ma-input-field>';
    }
    return {
        getReadWidget:   getReadWidget,
        getLinkWidget:   getLinkWidget,
        getFilterWidget: getFilterWidget,
        getWriteWidget:  getWriteWidget,
    }
});

I didn't make a difference between listView and showView (refs #261), this will be in another PR.
Tasks:

[x] Create configuration provider for widgets
[x] Use widgets from config in listView
[x] Use widgets from config in filters
[x] Use widgets from config in creationView
[x] Use widgets from config in editionView
[x] Fix rebase
[x] Fix e2e tests
[x] Add doc

Switching to RFR

Travis (saucelabs) is drunk, the PR is green.


Compilation without HYDRO but with GAS broken

Describe the bug
Latest master. Configure with VR_USE_GAS but not VR_USE_HYDRO.
Error
In file included from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/stf.h:8,
                 from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/buildandsortarrays.cxx:5:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h: In member function ‘void PropData::ConverttoComove(Options&)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h:2630:3: error: ‘aperture_M_gas_highT’ was not declared in this scope; did you mean ‘aperture_Z_gas’?
 2630 |   aperture_M_gas_highT[i]*=opt.h;
      |   ^~~~~~~~~~~~~~~~~~~~
      |   aperture_Z_gas
In file included from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/stf.h:8,
                 from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/haloproperties.cxx:7:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h: In member function ‘void PropData::ConverttoComove(Options&)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h:2630:3: error: ‘aperture_M_gas_highT’ was not declared in this scope; did you mean ‘aperture_Z_gas’?
 2630 |   aperture_M_gas_highT[i]*=opt.h;
      |   ^~~~~~~~~~~~~~~~~~~~
      |   aperture_Z_gas
In file included from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.cxx:5:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h: In member function ‘void PropData::ConverttoComove(Options&)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h:2630:3: error: ‘aperture_M_gas_highT’ was not declared in this scope; did you mean ‘aperture_Z_gas’?
 2630 |   aperture_M_gas_highT[i]*=opt.h;
      |   ^~~~~~~~~~~~~~~~~~~~
      |   aperture_Z_gas
In file included from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/logging.h:7,
                 from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/bgfield.cxx:7:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h: In member function ‘void PropData::ConverttoComove(Options&)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h:2630:3: error: ‘aperture_M_gas_highT’ was not declared in this scope; did you mean ‘aperture_Z_gas’?
 2630 |   aperture_M_gas_highT[i]*=opt.h;
      |   ^~~~~~~~~~~~~~~~~~~~
      |   aperture_Z_gas
In file included from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/logging.h:7,
                 from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/hdfio.cxx:26:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h: In member function ‘void PropData::ConverttoComove(Options&)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h:2630:3: error: ‘aperture_M_gas_highT’ was not declared in this scope; did you mean ‘aperture_Z_gas’?
 2630 |   aperture_M_gas_highT[i]*=opt.h;
      |   ^~~~~~~~~~~~~~~~~~~~
      |   aperture_Z_gas
In file included from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/stf.h:8,
                 from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/fofalgo.cxx:5:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h: In member function ‘void PropData::ConverttoComove(Options&)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h:2630:3: error: ‘aperture_M_gas_highT’ was not declared in this scope; did you mean ‘aperture_Z_gas’?
 2630 |   aperture_M_gas_highT[i]*=opt.h;
      |   ^~~~~~~~~~~~~~~~~~~~
      |   aperture_Z_gas
In file included from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/stf.h:8,
                 from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/io.cxx:7:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h: In member function ‘void PropData::ConverttoComove(Options&)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h:2630:3: error: ‘aperture_M_gas_highT’ was not declared in this scope; did you mean ‘aperture_Z_gas’?
 2630 |   aperture_M_gas_highT[i]*=opt.h;
      |   ^~~~~~~~~~~~~~~~~~~~
      |   aperture_Z_gas
In file included from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/stf.h:8,
                 from /cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/gadgetio.cxx:7:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h: In member function ‘void PropData::ConverttoComove(Options&)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/allvars.h:2630:3: error: ‘aperture_M_gas_highT’ was not declared in this scope; did you mean ‘aperture_Z_gas’?
 2630 |   aperture_M_gas_highT[i]*=opt.h;
      |   ^~~~~~~~~~~~~~~~~~~~

Should be easy to fix; most likely an incorrect #ifdef choice in these files when treating the newly added quantities from #57.

In the same vain, if I use VR_USE_STAR but not VR_USE_HYDRO (and not VR_USE_GAS), I get:
cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/gadgetio.cxx: In function ‘void ReadGadget(Options&, std::vector<NBody::Particle>&, Int_t, NBody::Particle*&, Int_t)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/gadgetio.cxx:1155:33: error: ‘class NBody::Particle’ has no member named ‘SetZmet’
 1155 |                 Pbuf[ibufindex].SetZmet(0);
      |                                 ^~~~~~~
make[2]: *** [src/CMakeFiles/velociraptor.dir/gadgetio.cxx.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/hdfio.cxx: In function ‘void ReadHDF(Options&, std::vector<NBody::Particle>&, Int_t, NBody::Particle*&, Int_t)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/hdfio.cxx:2777:41: error: ‘class NBody::Particle’ has no member named ‘SetZmet’
 2777 |                         Pbuf[ibufindex].SetZmet(0);
      |                                         ^~~~~~~
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/hdfio.cxx:2825:41: error: ‘class NBody::Particle’ has no member named ‘SetZmet’
 2825 |                         Pbuf[ibufindex].SetZmet(Zdoublebuff[nn]);
      |                                         ^~~~~~~
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/hdfio.cxx:2825:49: error: ‘Zdoublebuff’ was not declared in this scope; did you mean ‘vdoublebuff’?
 2825 |                         Pbuf[ibufindex].SetZmet(Zdoublebuff[nn]);
      |                                                 ^~~~~~~~~~~
      |                                                 vdoublebuff
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/hdfio.cxx:3058:41: error: ‘class NBody::Particle’ has no member named ‘SetZmet’
 3058 |                         Pbuf[ibufindex].SetZmet(0);
      |                                         ^~~~~~~
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/hdfio.cxx:3093:43: error: ‘class NBody::Particle’ has no member named ‘SetZmet’
 3093 |                           Pbuf[ibufindex].SetZmet(Zdoublebuff[nn]);
      |                                           ^~~~~~~
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/hdfio.cxx:3093:51: error: ‘Zdoublebuff’ was not declared in this scope; did you mean ‘vdoublebuff’?
 3093 |                           Pbuf[ibufindex].SetZmet(Zdoublebuff[nn]);
      |                                                   ^~~~~~~~~~~
      |                                                   vdoublebuff
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/io.cxx: In function ‘void AdjustStarQuantities(Options&, std::vector<NBody::Particle>&, Int_t)’:
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/io.cxx:167:15: error: ‘class NBody::Particle’ has no member named ‘SetZmet’
  167 |             p.SetZmet(p.GetZmet()*opt.metallicityinputconversion);
      |               ^~~~~~~
/cosma7/data/dp004/jlvc76/VELOCIraptor/VELOCIraptor-STF/src/io.cxx:167:25: error: ‘class NBody::Particle’ has no member named ‘GetZmet’
  167 |             p.SetZmet(p.GetZmet()*opt.metallicityinputconversion);

Compiling with both VR_USE_STAR and VR_USE_GAS works.

I fixed the first issue on the issue-70 branch. However that made another problem with only VR_USE_GAS=ON surface:
[ 44%] Building CXX object src/CMakeFiles/velociraptor.dir/substructureproperties.cxx.o
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx: In function ‘void GetFOFMass(Options&, Int_t, NBody::Particle*, Int_t, Int_t*&, Int_t*&, PropData*&, Int_t*&)’:
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx:3107:23: error: ‘class NBody::Particle’ has no member named ‘GetSFR’
 3107 |      auto sfr = Pval->GetSFR();
      |                       ^~~~~~
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx:3120:74: error: ‘class NBody::Particle’ has no member named ‘GetZmet’
 3120 |                        pdata[i].Z_mean_gas_highT_incl += massval * Pval->GetZmet();
      |                                                                          ^~~~~~~
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx: In function ‘void GetFOFMass(Options&, Int_t, Int_t*&, PropData*&)’:
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx:3172:50: error: ‘struct PropData’ has no member named ‘M_gas_nsf’; did you mean ‘M_gas_incl’?
 3172 |      pdata[hostindex].M_gas_nsf_incl += pdata[i].M_gas_nsf;
      |                                                  ^~~~~~~~~
      |                                                  M_gas_incl
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx:3173:49: error: ‘struct PropData’ has no member named ‘M_gas_sf’; did you mean ‘M_gas’?
 3173 |      pdata[hostindex].M_gas_sf_incl += pdata[i].M_gas_sf;
      |                                                 ^~~~~~~~
      |                                                 M_gas
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx:3190:49: error: ‘struct PropData’ has no member named ‘M_gas_nsf’; did you mean ‘M_gas_incl’?
 3190 |             pdata[i].M_gas_nsf_incl += pdata[i].M_gas_nsf;
      |                                                 ^~~~~~~~~
      |                                                 M_gas_incl
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx:3191:48: error: ‘struct PropData’ has no member named ‘M_gas_sf’; did you mean ‘M_gas’?
 3191 |             pdata[i].M_gas_sf_incl += pdata[i].M_gas_sf;
      |                                                ^~~~~~~~
      |                                                M_gas
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx: In function ‘void GetSOMasses(Options&, Int_t, NBody::Particle*, Int_t, Int_t*&, PropData*&)’:
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx:3416:46: error: ‘class NBody::Particle’ has no member named ‘GetSFR’
 3416 |                sfr[j] = Part[taggedparts[j]].GetSFR();
      |                                              ^~~~~~
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx:3418:47: error: ‘class NBody::Particle’ has no member named ‘GetZmet’
 3418 |                Zgas[j] = Part[taggedparts[j]].GetZmet();
      |                                               ^~~~~~~
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx:3484:73: error: ‘class NBody::Particle’ has no member named ‘GetSFR’
 3484 |                             sfr[offset+j] = PartDataGet[taggedparts[j]].GetSFR();
      |                                                                         ^~~~~~
/home/rtobar/scm/git/VELOCIraptor-STF/src/substructureproperties.cxx:3486:74: error: ‘class NBody::Particle’ has no member named ‘GetZmet’
 3486 |                             Zgas[offset+j] = PartDataGet[taggedparts[j]].GetZmet();
      |                                                                          ^~~~~~~

It seems that the code now assumes that VR_GAS means that the particles carry SFR and Z. That wasn't the case ~1 year ago. That's a fine change to make but it may have broken some people's test cases. In particular people running just so-called adiabatic gravity+gas models may not be happy.
That same assumption is done if I run the code with
Input_includes_gas_particle=1
Input_includes_star_particle=0

in the config file. The code will search for a SFR and metallicity field in the snapshot, which may not exist.

I tried some more again today, trying to find out when exactly these builds were broken. Unfortunately the commit history didn't lend itself for an easy git bisect, as there are many commits that break the build, which is then fixed in a subsequent commit (so there's no a stable basis to use for comparison).
Regardless, I still found that in 62fbb10 (1y9m ago) the GAS-only build works, but the STAR-only build doesn't, with very similar errors to the ones reported above, which indicates this build combination has been broken for a long time. In the case of the GAS-only compilation errors, they all seemed related to the new hot properties added in #57, and indeed the master branch before that particular merge (i.e., 08595f8) compiles fine.
In summary:

STAR-only builds have been broken for a long time. I'd have to seek some advice to know to fix them properly; in the meantime I can at least make them compile.
GAS-only builds were recently broken, so it will hopefully be easy to fix them correctly.

STAR-only is quite a strange choice to be fair so I am not surprised it has been broken for a long time. I would not expect many people to ever use this. However, GAS-only is meaningful and I think was used by some of the ICRAR student projects as well. Maybe fixing just this is the most important bit and the STAR-only aspect can be left out.

Hi all, I wanted to add something hopefully related to this. I am trying to make catalogues for adiabatic runs (DM and gas only) and compiling with
cmake . \
    -DVR_USE_HYDRO=ON \
    -DVR_USE_GAS=ON \
    -DVR_USE_STAR=OFF \
    -DVR_USE_BH=OFF \
    -DVR_USE_SWIFT_INTERFACE=OFF \
    -DCMAKE_CXX_FLAGS="-fPIC" \
    -DCMAKE_BUILD_TYPE=Release \
    -DVR_ZOOM_SIM=ON \
    -DVR_MPI=OFF

The compilation is successful, however, at runtime I came across i/o errors related to the SFR. The SFR field in SWIFT is normally attached to gas particle types, but it's not dumped when the simulation is run in adiabatic mode. Setting VR_USE_HYDRO=ON and VR_USE_STAR=OFF apparently avoids the compilation errors, but makes the code look for a SFR field in PartType0 which may not be there if stars aren't included in the model.
@MatthieuSchaller suggested deleting all mentions to SFR in the parameter file (having the appropriate PartTypes switched off), but the code still needs info related to the SFR.
Is there anything obvious I'm missing or is this behavior actually related to what Matthieu pointed out above?
Thanks in advance for helping!

@MatthieuSchaller @edoaltamura @JBorrow yesterday I had a chance to have a look at this with @cdplagos, and were able to produce a fix for this issue. Would you mind testing the contents of the issue-70 branch? I've also added a new job to the Travis CI build matrix to ensure gas-only builds are not broken again.

Thanks! Will do.

I can confirm it compiles and runs smoothly!

Thanks @MatthieuSchaller for the good news :). I'll wait for further confirmation from @JBorrow to double-check that his use case reported in #91 has also been solved by these fixes; after that I'll merge to the master branch.

Yes, it now works (although my test case dies with the vr::non_positive_density error in OMP only mode). Thanks for the fix!

Fix merged to the master branch, closing this now. Thanks for the patience!


update ethers from 5.5.1 to 5.7.1

It is only the lock files that need updating if I'm not mistaken.

Hello, #147 addresses the same issue and will also increase support for ethers v6.


Fix issues with closure-compiler inADVANCED mode

Closure compiler in advanced mode renames wasm properties. Because of that compressed file aren't working after that. Changes prevents this.

Thank you! :)


add biz retry exception

Motivation:
Explain the context, and why you're making that change.
To make others understand what is the problem you're trying to solve.
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.

@EvenLjj  More documents and user cases should be provided to indicate why we need this feature and how users use this future.


No pem pressure sensitivity/

Photoshop version
CC2021
Describe the bug
Brushes with pen jitter controlled by pen pressure do not react to it.
To Reproduce
Plug in a pen tablet and try to use it with a default Photoshop brush that should react to pen pressure :/
Expected behavior
The brush should react to pen pressure and thicken/thin accordingly, the sreenshot attached shows expected behavior in Krita.
Screenshots

System informations

Distro : Linux Mint 21.2 Cinnamon
GPU : AMD Radeon RX 6700 XT
WINE version : 8.0.2

Additional context
Tablet: Wacom Intuos BT M. It works properly with various versions of Photoshop on different Windows systems and on a Macbook. No issues with pen pressure in Krita and in MyPaint.

Hello, I'm sorry to report you that I can't get any pressure pen working with wine...
I can't recommend you more to use Krita or Gimp for those things.
I don't think wine support it with the research I've made...
I have little knowledge on how to patch wine but not enough to create a whole driver unfortunately...

Hello! I have this same problem. I thought I should share that I got the classic Windows workaround to work on Linux Mint, but it is extremely spotty and only works a fraction of every stroke I try. But maybe try it out and see if it works better for you. If you're not familiar with the workaround, here's what you need to do:

Navigate to your linux installation folder/drive_c/user/username/Appdata/Roaming/Adobe/Adobe Photoshop 2021/Adobe Photoshop 2021 Settings/
Create the file PSUserConfig.txt and type the line "UseSystemStylus 0" inside.
Restart Photoshop with your tablet connected

Here's a screenshot of it working (sort of)


A generic version of IResourceProvider

Coverage increased (+0.004%) to 72.494% when pulling dfa8b725cbeecedfec24586fd425dfc104abf4ab on jkiddo:master into a0c40cf98a52acf639701be5d82f4bbb9b3c787e on jamesagnew:master.

This is a neat idea, but I feel like it just trades putting the resource name in one place (the getResourceType method) for putting it in another place (the generic type), which is a few fewer keystrokes but also risky if the class has implemented more than one typed interface (and if history has shown  me anything it's that someone will do just that and then have incomprehensible errors on the mailig list :) )
This might be better as an example in the fhirstarters project or somewhere else I'm thinking..

right - fair enough. It's purely thought as a shorthand notation-thingy - and as with all other code, it should be used carefully.


ci: skip Azure Pipelines on Dependabot push or any tag

For performance reasons, this pr skips Azure Pipelines on

push in Dependabot branch; it's still triggered by pr event.
tag push; it's still triggered by commit push.

I'm merging this to see if it works.

Looks good. df27851a9d370e5f750ef7e7149878debd609eb7 didn't trigger an extra Azure Pipelines run.


Using gon makes test-unit automatic runner producing "invalid option" error on rake tasks

Hi!
Since I've installed gon, my rake tasks aren't working anymore.
I'm using:
Rails <IP_ADDRESS>
ruby 2.2.0p0
gon-6.0.1
test-unit-3.0.8

I can't uninstall test-unit because:
$ rails c
/Users/me/.rbenv/versions/2.2.0/gemsets/project-gems/gems/activesupport-<IP_ADDRESS>/lib/active_support/dependencies.rb:251:in `require': Please add test-unit gem to your Gemfile: `gem 'test-unit', '~> 3.0'` (cannot load such file -- test/unit/testcase) (LoadError)

If I rake -T for example:
rake about                                       # List versions of all Rails frameworks and the environment
... (all rake tasks here) ...
rake tmp:create                                  # Creates tmp directories for sessions, cache, sockets, and pids
invalid option: -T
Test::Unit automatic runner.
Usage: /Users/me/.rbenv/versions/2.2.0/gemsets/project-gems/bin/rake [options] [-- untouched arguments]
    -r, --runner=RUNNER              Use the given RUNNER.
                                     (c[onsole], e[macs], x[ml])
        --collector=COLLECTOR        Use the given COLLECTOR.
                                     (de[scendant], di[r], l[oad], o[bject]_space)
    -n, --name=NAME                  Runs tests matching NAME.
                                     Use '/PATTERN/' for NAME to use regular expression.
        --ignore-name=NAME           Ignores tests matching NAME.
                                     Use '/PATTERN/' for NAME to use regular expression.
    -t, --testcase=TESTCASE          Runs tests in TestCases matching TESTCASE.
                                     Use '/PATTERN/' for TESTCASE to use regular expression.
        --ignore-testcase=TESTCASE   Ignores tests in TestCases matching TESTCASE.
                                     Use '/PATTERN/' for TESTCASE to use regular expression.
        --location=LOCATION          Runs tests that defined in LOCATION.
                                     LOCATION is one of PATH:LINE, PATH or LINE
        --attribute=EXPRESSION       Runs tests that matches EXPRESSION.
                                     EXPRESSION is evaluated as Ruby's expression.
                                     Test attribute name can be used with no receiver in EXPRESSION.
                                     EXPRESSION examples:
                                       !slow
                                       tag == 'important' and !slow
        --[no-]priority-mode         Runs some tests based on their priority.
        --default-priority=PRIORITY  Uses PRIORITY as default priority
                                     (h[igh], i[mportant], l[ow], m[ust], ne[ver], no[rmal])
    -I, --load-path=DIR[:DIR...]     Appends directory list to $LOAD_PATH.
        --color-scheme=SCHEME        Use SCHEME as color scheme.
                                     (d[efault])
        --config=FILE                Use YAML fomat FILE content as configuration file.
        --order=ORDER                Run tests in a test case in ORDER order.
                                     (a[lphabetic], d[efined], r[andom])
        --max-diff-target-string-size=SIZE
                                     Shows diff if both expected result string size and actual result string size are less than or equal SIZE in bytes.
                                     (1000)
    -v, --verbose=[LEVEL]            Set the output level (default is verbose).
                                     (important-only, n[ormal], p[rogress], s[ilent], v[erbose])
        --[no-]use-color=[auto]      Uses color output
                                     (default is auto)
        --progress-row-max=MAX       Uses MAX as max terminal width for progress mark
                                     (default is auto)
        --no-show-detail-immediately Shows not passed test details immediately.
                                     (default is yes)
        --output-file-descriptor=FD  Outputs to file descriptor FD
        --                           Stop processing options so that the
                                     remaining options will be passed to the
                                     test.
    -h, --help                       Display this help.

Deprecated options:
        --console                    Console runner (use --runner).

Here's the culprit:
invalid option: -T
Test::Unit automatic runner.

With or without rspec, same error.
Current solution: I ended with those lines at the bottom of my application.rb:
Test::Unit::AutoRunner.need_auto_run = false if defined?(Test::Unit::AutoRunner)

first link
Test::Unit.run = true if defined?(Test::Unit) && Test::Unit.respond_to?(:run=)

second link
Anyone with a better idea?
Thank you!

same question on stackoverflow


handle folded block scalars in script blocks

fixes #19

Are BitBucket pipelines relevant, too?

Are BitBucket pipelines relevant, too?

I've never used BitBucket personally, but not as far as I can tell because scripts are always a single line sequence item as far as I have seen. If someone requests it in future we can add it then.


New term proposal: ´neg_cont_status´

New term details
For us to assess a new term request we require the following details:
Term name - Negative Control Status
Structured comment name - neg_cont_status
Definition - Specify whether the sample is a negative control or not.
Expected value - Negative Control Status; text
Value syntax - {boolean}
Example - Negative Control
Preferred unit - NA
Package(s) - ancient

Additional context
Add any other context about the new term here.

Would the existing term below be OK to use instead of creating a new term?
Structured comment name - neg_cont_type
Term name - negative control type
Term ID - MIXS:0001321
Definition - The substance or equipment used as a negative control in an investigation.
Expected value - enumeration or text
Value syntax - [distilled water|phosphate buffer|empty collection device|empty collection tube|DNA-free PCR mix|sterile swab |sterile syringe] or {text}
Package(s) - Core

NB - There has been an issue with the published v6 spreadsheet not containing this term, hence you probably didn't know about it before now! Apologies, we will be fixing that soon.
There is also a Positive control type term too if that is useful?
Term name - positive control type
Term ID - MIXS:0001322
Structured comment name - pos_cont_type
Definition - The substance, mixture, product, or apparatus used to verify that a process which is part of an investigation delivers a true positive.
Value syntax - {term} or {text}
Package(s) - Core

My understanding of the pos and neg control terms was to do exactly what you intended, i.e. say this sequence is from a control sample of a particular type (i.e just saying its a negative control isn't specific enough for most use cases as there are a number of different things that can be negative controls), but it would be good to get input from @josieburgin & others who requested the term. We may need to update the definition to clarify its usage.

OK, then yes maybe we need to discuss a term update. We can leave this issue open for the time being until we get confirmation.


improve accessibility

https://www.accessibilitychecker.org/audit/?website=bookshelf.rs&flag=us

I can't really get much info out of that tool since it refuses to render properly even with unblocking all the JS it tries to load

yeah it's more of a note for myself

ironic when the accessibility checker is inaccessible


feat(ndt_scan_matcher): added a function to check maximum distance of sensor points

Description
Context
The current ndt_scan_matcher does not check the normality of the input point cloud, and performs scan matching even when an abnormal point cloud comes in, leading to incorrect position estimation.
In particular, the pull requests below have been merged to make the default input point cloud topic /sensing/lidar/concatenated/pointcloud, which rarely outputs point clouds concatenated with short-range LiDAR only.

https://github.com/autowarefoundation/autoware.universe/pull/6528

ndt_scan_matcher should check the validity of the input point cloud.
Changes
As a first step in checking the input point cloud, this PR checks to see if there are points  are more than a specified distance apart.
Note
This PR must be merged with

https://github.com/autowarefoundation/autoware_launch/pull/908

Tests performed
It has been confirmed that the logging_simulator runs with the same accuracy as before on AWSIM data with GT.
sample rosbag
The probability of incorrect initial position estimation in Sample-rosbag performed under poor computational resources has been reduced from 3/7 to nearly 0/7.
Effects on system behavior
The possibility of ndt being incorrect is slightly reduced.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@anhnv3991
Thank you for your comment :)
Although this is an important point, it seems like it will take some time to fix it, so I would like to try merging this PR as is.
The current autoware.universe is degraded,  which initial position estimation fails with sample-rosbag with a probability of about 50%, so I would like to fix this as soon as possible.
However, since good design is of course important, I will address your points in detail.
(1) Concurrency
You are correct, but in this code, the computational complexity of checking sensor points is O(N). In NDT, N is usually around 1500, so it is not significant. Even in the future, the checking code may not become a heavy process.
(2) Modularity
I agree with you. How about creating a new class in the future, such as SensorPointsValidator and having NDTScanMatcher hold it as a member variable? Just as NDT's align processing is essentially implemented with ndt_omp, it may be desirable to create a dedicated class for checking input point clouds. I think NDTScanMatcher's responsibility is communication in ROS2. In any case, I agree that core logic should be written as little as possible in NDTScanMatcher.
(3) Reusability
I think the validation of input is different for each process. For example, points only from a short-range LiDAR may not be suitable for NDT but could be useful for other processes. In general, the requirements for inputs should be defined for each process.


Profile unit test

Codecov Report

Merging #114 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage    59.9%   59.94%   +0.04%
==========================================
  Files          45       45
  Lines        2287     2287
==========================================
+ Hits         1370     1371       +1
+ Misses        917      916       -1

Impacted Files
Coverage Δ

statick_tool/profile.py
100% <0%> (+5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82f0054...3057241. Read the comment docs.


📃: Graphs

:red_circle: Title : Graphs for DSA
:red_circle: Aim : Add the graph data structure implementation.
:red_circle: Brief Explanation :Graphs represent relationships between entities using vertices and edges. They are implemented using adjacency lists or matrices and are vital for solving problems like searching (BFS, DFS) and finding the shortest path (Dijkstra’s). I plan to implement a Menu driven Graph implementation that will include a shortest distance calculator and graph traversal methods.
Screenshots 📷
N/A

:white_check_mark: To be Mentioned while taking the issue :

Full name :  Saurav Singh.
Participant role : Contributor in Hactoberfest.

i want to work on this issue /assign me.

@UTSAVS26 yes

@UTSAVS26 Can i work on the issue ?

@UTSAVS26 Can i work on the issue ?

As of now I don't know if this project is allowed under Hacktoberfest or not so if you don't have a problem with it, i can assign you this issue.

No problem assign this issue to me under hacktoberfest tag please.

@AnujSaha0111 I am already assigned to this issue.

Hello @UTSAVS26. I have good knowledge in DSA and Graphs. I would like to work on this. Could you please assign this to me.

Hello @UTSAVS26 @South-IN . I have good knowledge in DSA and Graphs. I would like to work on this. Could you please assign this to me.

Raise another issue if possible I am closing this one.


[UI-Bug]: Rank graph not updating after switching to own profile

After looking at someone else's profile on scoresaber, and then switching to your profile by clicking on the avatar > My profile, the rank graph does not update. Reloading the page fixes the bug

Fixed in #28, thank you @motzel 😊

Also, please note that deployment to the main website may take a few hours since Umby has to do it manually.

Also, please note that deployment to the main website may take a few hours since Umby has to do it manually.

It seems that the fix has been deployed already, since the issue doesn't appear anymore for me


More Java generation cleanup/fixes

Remove SampleApp generation and support for single-artifact, cleanup related stuff. This is replaced by more lightweight self-contained individual artifacts, so self-service generation and generation for google-cloud-java releases are done in same way.

Add javadoc.options.encoding = 'UTF-8' option to generated build.gradle files (similar to how it is already done for compileJava). Without this option, javadoc generation fails on google-cloud-java release staging.

Removed redundant/incorrect files from protoc-, grpc- artifacts output (apidocs_index.html.template and others).

gradlew files are not included with grpc-, protoc- anymore. They had neglectable usability in generated output, since to build things properly a top-level build gradlew/build.gradle is required anyways; it was not used for releases. Subsequent PR will add individual target to generate only one bundle of build files per client/batch: gradew, build.gradle, settings.gradle.

Make GeneratorVersionProvider read version.txt file directly if cannot find version number in resources (to better support running tests from raw test .class files (IDE)).

Codecov Report

Merging #1894 into master will increase coverage by 0.13%.
The diff coverage is 59.37%.

@@             Coverage Diff              @@
##             master    #1894      +/-   ##
============================================
+ Coverage     85.32%   85.46%   +0.13%
+ Complexity     4758     4736      -22
============================================
  Files           439      435       -4
  Lines         18807    18657     -150
  Branches       2004     1997       -7
============================================
- Hits          16048    15945     -103
+ Misses         2063     2021      -42
+ Partials        696      691       -5

Impacted Files
Coverage Δ
Complexity Δ

...n/grpcmetadatagen/GrpcMetadataProviderFactory.java
58.33% <ø> (ø)
5 <0> (ø)
:arrow_down:

...google/api/codegen/gapic/GapicGeneratorConfig.java
60% <ø> (-6.67%)
6 <0> (-1)

...odegen/viewmodel/metadata/PackageMetadataView.java
90.9% <ø> (ø)
5 <0> (ø)
:arrow_down:

...m/google/api/codegen/transformer/SurfaceNamer.java
73.79% <ø> (-0.07%)
194 <0> (-1)

.../java/com/google/api/codegen/CodeGeneratorApi.java
21.05% <0%> (ø)
3 <0> (ø)
:arrow_down:

...grpcmetadatagen/java/JavaGrpcMetadataProvider.java
92.85% <100%> (-1.59%)
3 <3> (-1)

...transformer/java/JavaGapicMetadataTransformer.java
100% <100%> (+4.16%)
4 <1> (-2)
:arrow_down:

...egen/discogapic/MainDiscoGapicProviderFactory.java
87.87% <100%> (+24.61%)
3 <2> (-1)
:arrow_down:

...com/google/api/codegen/DiscoGapicGeneratorApi.java
64.63% <42.85%> (+1.84%)
7 <0> (ø)
:arrow_down:

...le/api/codegen/gapic/MainGapicProviderFactory.java
93.03% <50%> (-0.37%)
12 <12> (-2)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e044b...11a111a. Read the comment docs.


Add Lyon Cluster Map

Describe the pull request
Added the Lyon cluster map in web/ui/src/lib/ClustersMaps.
Not sure about the REGEX part, I'm pretty bad with these.
Checklist

[x] I have made the modifications or added tests related to my PR
[ ] I have run the tests and linters locally and they pass
[ ] I have added/updated the documentation for my RP

Additional context
Couldn't test it du to the issue with dev containers, but should work as intended.

Thanks for the explanation !
I manage to use the linter in the dev container, so I don't have much merit :sweat_smile:
Please feel free to @ me if some things need changes.
We will be receiving new computers in the month, so I'll be sure to create a new PR to update the map !


Removed border from the Picker

Details
There were two borders around the Picker. I have removed the inner border. https://github.com/Expensify/App/issues/4972#issuecomment-910075558
cc: @shawnborton
Fixed Issues

$ https://github.com/Expensify/App/issues/4972
Tests | QA Steps

Open NewDot on the Web browser.
Zoom the window to enlarge the Language Picker on the Login page.
There should not be two borders like shown in the issue.

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web | Desktop

Mobile Web

iOS

Android

@parasharrajat we should also remove  styles.picker, it is unused.

It seems you are correct. @meetmangukiya CC: @kakajann Why do we have this style if this is unused? Any reason?

I think it just got phased out through refactorings seeing the blame

I'll hold off on merging until there's a commit for styles.picker (I agree we should poll the contributors who've touched it, but let's not wait more than a few days).

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Luke9389 in version: 1.0.93-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-15.  :confetti_ball:

🚀 Deployed to production by @yuwenmemon in version: 1.0.94-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


feat(Mobile Menu contd): interactions

add icon as optional prop
include icons in global header items
set up app header story

Overview

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.9-alpha.bfcfc4.0@codecademy/gamut-labs@7.13.4-alpha.bfcfc4.0@codecademy/gamut@19.11.5-alpha.bfcfc4.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.9-alpha.bfcfc4.0@codecademy/gamut-labs@7.13.4-alpha.bfcfc4.0@codecademy/gamut@19.11.5-alpha.bfcfc4.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://601065e208dbfa0a999fa353--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://601065e208dbfa0a999fa353--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.9-alpha.90c224.0@codecademy/gamut-labs@7.13.4-alpha.90c224.0@codecademy/gamut@19.11.5-alpha.90c224.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-illustrations@0.4.9-alpha.90c224.0@codecademy/gamut-labs@7.13.4-alpha.90c224.0@codecademy/gamut@19.11.5-alpha.90c224.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6010983a93030b16aa61641c--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://6010983a93030b16aa61641c--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@7.14.1-alpha.cf1fbf.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-labs@7.14.1-alpha.cf1fbf.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6010d69d38b5ef7387a11088--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://6010d69d38b5ef7387a11088--gamut-preview.netlify.appDeploy Logs

🚀 Styleguide deploy preview ready!https://60185fd287cedf01392bb834--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@7.14.1-alpha.4b3fec.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-labs@8.1.1-alpha.9a85b6.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60196e3cceec99b30a5cd1ce--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@8.1.1-alpha.9816f5.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60197531d2c78900bbc9ac8f--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@8.1.1-alpha.53e4e6.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60197eb7709efe0f3e6d6292--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@8.1.1-alpha.75fcef.0<EMAIL_ADDRESS>
📬Published Alpha Packages:@codecademy/gamut-labs@8.1.1-alpha.372931.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://601989f36fde5216821ed4f7--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@8.1.1-alpha.07e491.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6019a95eb355d600c0acc18e--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@8.1.1-alpha.dfb90f.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6019b359b355d60f77acc101--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@8.1.1-alpha.8abfae.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6019bf09fa41e61ac8cf11dc--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@8.1.1-alpha.325ccf.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6019c1814d70071b79b68101--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@8.1.1-alpha.3c63a6.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6019c7a7e9aefc1d2b644826--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-labs@8.1.7-alpha.42e64b.0@codecademy/styleguide@24.1.1-alpha.42e64b.0


049-2 spawns in the void when Synapse is installed

I have recently added Synapse to our SCP:SL server that I host for my friends. I only use one plugin, BetterUI. I have been experiencing this weird bug, where if I am SCP049 and revive someone, they will spawn outside on the roof of Gate-A or in the void.

LocalAdmin v. 2.4.5
SynapseVersion: <IP_ADDRESS>
LoaderVersion: <IP_ADDRESS>
RuntimeVersion: 4.0.30319

This bug is already fixed in our patch branch and will be implemented in version 2.10.1


[gmp:x64-windows] build failure

Host Environment

OS: Windows 10 Pro 20H2 (19042.630)
Compiler: Visual Studio 2019 Version: 16.8.2 VS Tools Version: 14.28.29333

To Reproduce
Steps to reproduce the behavior:
./vcpkg install gmp:x64-windows
Failure logs
PS E:\Program\vcpkg> ./vcpkg install gmp:x64-windows
Computing installation plan...
The following packages will be built and installed:
    gmp[core]:x64-windows
  * yasm-tool-helper[core]:x64-windows
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-windows...
Using cached binary package: C:\Users\MFunction\AppData\Local\vcpkg\archives\44\442d4788218915219c269b57dd0e041578cbd532.zip
Could not locate cached archive: C:\Users\MFunction\AppData\Local\vcpkg\archives\09\09f24f18b909a1ca88015dccf29162be083ad7f8.zip
Starting package 1/2: yasm-tool-helper:x64-windows
Building package yasm-tool-helper[core]:x64-windows...
Building package yasm-tool-helper[core]:x64-windows... done
Installing package yasm-tool-helper[core]:x64-windows...
Installing package yasm-tool-helper[core]:x64-windows... done
Elapsed time for package yasm-tool-helper:x64-windows: 30.47 ms
Starting package 2/2: gmp:x64-windows
Building package gmp[core]:x64-windows...
-- Using cached E:/Program/vcpkg/downloads/ShiftMediaProject-gmp-e140dfc8668e96d7e56cbd46467945adcc6b3cc4.tar.gz
-- Cleaning sources at E:/Program/vcpkg/buildtrees/gmp/src/adcc6b3cc4-2b6258d695.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source E:/Program/vcpkg/downloads/ShiftMediaProject-gmp-e140dfc8668e96d7e56cbd46467945adcc6b3cc4.tar.gz
-- Applying patch vs.build.patch
-- Applying patch runtime.patch
-- Applying patch prefix.patch
-- Using source at E:/Program/vcpkg/buildtrees/gmp/src/adcc6b3cc4-2b6258d695.clean
CMake Error at installed/x64-windows/share/yasm-tool-helper/yasm-tool-helper.cmake:16 (message):
  Cross-targetting and x64 ports requiring yasm require the x86-windows
  yasm-tool to be available.  Please install yasm-tool:x86-windows first.
Call Stack (most recent call first):
  ports/gmp/portfile.cmake:19 (yasm_tool_helper)
  scripts/ports.cmake:136 (include)

Error: Building package gmp:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: gmp:x64-windows
  Vcpkg version: 2020.11.12-nohash

Additionally, attach any relevant sections from the log files above.

Additional context
I noticed that the issue https://github.com/microsoft/vcpkg/issues/13642 mentioned some x64 packages built by x86 compiler/linker/utilities and tools. I think it hasn't solved completely. If I install yasm-tool:x86-windows manually, the building will passed.

Hi @MFunction96
Thanks for posting this issue.
Currently , you need to install yasm-tool:x86-windows manually, then you can continue building gmp.
Please refer to this comment https://github.com/microsoft/vcpkg/issues/14288#issuecomment-718969380, I think this may answer your question.

I used ./vcpkg install yasm-tool: x86-windows and then ./vcpkg install gmp: x64-windows
And it works, thanks

@dudantas
Thanks for your feedback.
@MFunction96
Please see the above comments to learn about the details.

我用过，然后它有效，谢谢./vcpkg install yasm-tool: x86-windows``./vcpkg install gmp: x64-windows

it doesn't work on my PC.

@AlienLcb This issue was closed more than two years ago. The current version of port gmp doesn't use yasm.

@AlienLcb This issue was closed more than two years ago. The current version of port gmp doesn't use yasm.

thanks,maybe I occurred some new error.if you are intrested in my new question,the link as:https://github.com/microsoft/vcpkg/issues/14703#issuecomment-1747455408


using render(...).success(...).error(...) format rather than throwing?

Given the rising popularity of promisses and the Node approach of success/error routing rather than throwing errors, it might be nice to make the .render and .renderToString functions return objects that can bind success and error handlers. That way it's much easier to write things like
katex.renderToString("f(x) = 2y")
     .success(function(html) {
       // inject html code wherever needed now
     } )
     .error(function(error) {
      // okay this clearly didn't work, let's fall back to something else
     });

I think that https://github.com/Khan/KaTeX/blob/master/contrib/auto-render/auto-render.js makes things a lot better for the average user who just wants all their math to be rendered by handling exceptions appropriately.
The issue of people using the API directly being caught off guard should probably be handled by updating the examples in the docs to include a try/catch block as well as a warning to always catch errors.

The success-error pattern is kind of a hack for async programming without coroutines because async operations can’t use throw-catch. This makes sense if renderToString is async, but it’s not.

Totally agree.
async/await (part of ES7) supports try/catch/throw for asynchronous code.  I can't wait to use it.  It really cleans up a lot of the clutter that you get with Promises.
Since Promises add clutter and aren't necessary b/c all of the code is synchronous there isn't really a reason to support them.  @Pomax if you really want to use Promises it shouldn't be too difficult to write a wrapper around renderToString.
I'm going to close this and will update the docs.

I mostly just want code that I can use as both user as well as dev (some things need immediate loading, but a page like http://pomax.github.io/bezierinfo, no matter how fast katex renders, needs on-demand loading instead of loading up front =D). If you're going to stick with try catch, that's aesthetically very ugly, but from a functional point of view perfectly fine. I don't really agree with the fact that success/error is a hack, but that has no bearing on keeping the issue closed, really.

How do you do the on-demand loading?  Can you point me at some code?

@Pomax have you tried calling renderToString in a web worker and then passing the HTML back?

If you throw inside of a Promise, it should catch the except and pass the value to the error handler.  If there's no error handler then it still blows up.
var promise = new Promise(function (resolve, reject) {
   if (eqnInView) {
      katex.render(equation, container);
      resolve();
   }
   var listener = document.addEventListener('scroll', function (e) {
      if (eqnEnteringView) {
         document.removeEventListener(listener);
         // okay if this throws as long as there's a error handler
         katex.render(equation, container);
         resolve();
      }
   };
});

promise.then(function () {
   console.log("success");
}, function (err) {
   console.log(err);
});

I could imagine us returning some sort of success/error object but it would probably not be a promise.

@kevinb7 currently it's using MathJax, with the dynamic loading happening in https://github.com/Pomax/bezierinfo/blob/gh-pages/js/sectionloading.js


ERR_CERT_COMMON_NAME_INVALID when I access a non-localhost domain?

Hi there,
I'm on MacOS Catalina. I've installed MkCert and used it to generate a cert for localhost and a domain that maps to <IP_ADDRESS> also (using a local dnsmasq setup)
When I access https://localhost/... all works fine, but when I access https://mysite.matt/ (that's my custom domain ) I get ERR_CERT_COMMON_NAME_INVALID - here's a screenshot:

I'm not sure if this is setup related or an issue in mkcert, so apologies in advance if I'm wasting anyones time..

Did you include mysite.matt in the list of names for the certificate?
$ mkcert localhost <IP_ADDRESS> mysite.matt

I did yes, I’ve checked about 20 times for daft typos too
On Fri, 22 Nov 2019 at 16:49, Filippo Valsorda<EMAIL_ADDRESS>wrote:

Did you include mysite.matt in the list of names for the certificate?
$ mkcert localhost <IP_ADDRESS> mysite.matt
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FiloSottile/mkcert/issues/223?email_source=notifications&email_token=AAA2VDBULBXXTV3GT4EZENDQVAERJA5CNFSM4JQTDHUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE6GTOY#issuecomment-557607355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA2VDDH4U3GRBHQKVYBRDTQVAERJANCNFSM4JQTDHUA
.

--
Matt Roberts
e<EMAIL_ADDRESS>t: mattwoberts

Hmm, "Issuer: localhost" suggests that's not actually a mkcert certificate, ours definitely don't use the name localhost in the root. Looks like your web server is picking up some other self-signed certificate.

Ok, thanks for the pointers I’ll dig into it!
Thanks 🙏 for your help, and for making such awesomeness!!
On Fri, 22 Nov 2019 at 17:56, Filippo Valsorda<EMAIL_ADDRESS>wrote:

Hmm, "Issuer: localhost" suggests that's not actually a mkcert
certificate, ours definitely don't use the name localhost in the root.
Looks like your web server is picking up some other self-signed certificate.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FiloSottile/mkcert/issues/223?email_source=notifications&email_token=AAA2VDB77A6KDL3GUSQMZYLQVAMOXA5CNFSM4JQTDHUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE6MJWA#issuecomment-557630680,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA2VDDOS3X6IJ3XAR6RQE3QVAMOXANCNFSM4JQTDHUA
.

--
Matt Roberts
e<EMAIL_ADDRESS>t: mattwoberts


[CI] [E2E] Increase container healthcheck timeout

Purpose of the pull request
Fix e2e timeout in https://github.com/apache/dolphinscheduler/actions/runs/5607579926/jobs/10259144768?pr=14190

Codecov Report

Merging #14599 (8db1d35) into dev (68e8b35) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 8db1d35 differs from pull request most recent head bdc156d. Consider uploading reports for the commit bdc156d to get more accurate results

@@             Coverage Diff              @@
##                dev   #14599      +/-   ##
============================================
- Coverage     38.48%   38.48%   -0.01%
+ Complexity     4546     4542       -4
============================================
  Files          1254     1254
  Lines         43724    43679      -45
  Branches       4825     4796      -29
============================================
- Hits          16828    16810      -18
+ Misses        25023    24996      -27
  Partials       1873     1873

see 35 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[EFR32 OTA] Invoke Silabs API for writing, verifying and applying the image

Problem
EFR32 implementation must invoke correct image management API
Change overview
Invoke Silabs API for writing, verifying and applying the image
Testing
Tested Provider->Requestor image download over Thread. Provider/Requestor message exchange completes, BDX download starts.
The above test was done on commit https://github.com/project-chip/connectedhomeip/pull/13448 as the Provider/Requestor session establishment is broken on the current master.

Fast tracking, given platform changes by a platform maintainer.


Rename folder screen glitch

Refs: #11130

VSCode Version: insiders
OS Version: mac, linux

Steps to Reproduce:

Rename a folder
Notice blue screen glitch

This seems to be fixed via https://github.com/Microsoft/vscode/issues/9170


[ENH] Add badges

[x] build

[x] coverage

[x] chat

[x] pypi version

[x] docs

[x] license

[x] zenodo DOI (see giddy)

[x] put badges in frame

completed in #65


Use MapState as CrawlDB implementation

Fabian Hueske commented on a user's question about how to maintain a more efficient list of values per key:

you could put the data into a
RocksDBStateBackend MapState<Integer, X> where the value X is your data
type and the key is the list index. You would need another ValueState for
the current number of elements that you put into the MapState.
A MapState allows to fetch and traverse the key, value, or entry set of the
Map without loading it completely into memory.
The sets are traversed in sort order of the key, so should be in insertion
order (given that you properly increment the list index).

We could do something similar, as a work-around for not being able to iterate over RocksDB entries.

Done enough, though there's an issue with DomainTicklerFunction not persisting state


When the client's webhook involves non-English content, UTF-8 encoding issues arise.

Describe the bug
Through testing, I discovered that when sending requests to the server, the non-English parts appear garbled, while the English content remains unaffected.
To Reproduce
Steps to reproduce the behavior:

Open the settings button
Enable developer mode
Enter the custom webhook URL in advanced mode
Notice the returned garbled text on the webhook server

Smartphone :

Device: Xiaomi 13 Pro
OS: Hyper OS <IP_ADDRESS>.10.DEV

@mdmohsin7  seems to be working on something that may resolve this issue.
Reference in the Discord
https://discord.com/channels/1192313062041067520/1231903583717425153/1261760653371117658

Commenting for now, as will be fixed in another issue

Fixed


match plist indentation with xcode format

xcode has its own way of indentation of the plist.
fixes #11668

That makes the output of the linkcommand consistent with the upgrade too. No more unreadable Infos.plist diff after running either of the commands  👍 👏

Are we sure this is the only occurrence of the plist write? Maybe it makes sense to extract the entire fs.writeSync to a separate function (file), called writePlist and document why we set the encoding explicitly?
Apart from that all good!

Ah you're right, unlinkAssets also writes the plist. What would be the preferred name for this? as opposite of getPlist putPlist would maybe be most appropriate.

Yeah, putPlist makes sense, don't have opinion here. Separate file, unit tests and we are ready to go :)

Looks good @koenpunt, can we verify whether test failures seem PR related or not? Rebase off master could help.
I'll get to review it tomorrow and ship :)

Rebase done!

@facebook-github-bot shipit

Thanks @koenpunt, I like the entire PR, the way you got the styleguide and contributed the code that looks 100% nice!

@grabbou thanks! but did something went wrong with shipping? Because this PR is still open..

Any updates on this in the last month? Unclear what's blocking.

@grabbou ping ✨

@facebook-github-bot shipit

CC: @bestander

Looks like it landed already

Woop 🎉


Generate ukcore snapshots

@Dunmail Here is a basic version (just linux) of what I mentioned in the other PR.
I couldn't get the snapshot to generate without logging in and running inflate first, so just note there is a fhir login in there.  Not ideal, but assuming you have a simplifier account, if you've previously logged in, it seems to find the previous token within the terminal session, so it would be straightforward to handle that appropriately somehow with secret management on your CI server.
I'm using Microsofts linux install script for the dotnet sdk which makes it pretty widely supported on linux distros with different package management.  For the firely terminal install, I'm assuming if the command fhir is not available it needs installed.  It then overwrites the UKCore profiles in the cache.
Sushi (npm run compile) will then run fine after removing the resource in input/resources, bar the other error with the canonical.  I didn't include it here, but there are no errors at all with the other change.

Thanks for this.
@clarotech: This PR relates to #30
Do you know if the proposal would be compatible with the CI build process configured for this repo? My instinct is that the standard FHIR build might lack a) a step where we can run custom scripts b) a means of configuring a simplifier account. I may be wrong though!


Reproducibility of VGGSound

Thanks for sharing the amazing codebase. I am wondering if you will provide the script or other useful resources for reproducing results on VGGSound.
I tried to use the get_audio_embedding_from_filelist to get audio features. But I can only get ~45%, which is a huge gap between 75% (really impressive since A+V only gets 64.1%)
Looking forward to your reply.

Hi, the 45% you got is from the zero-shot classification performance, similar to the 46.2% reported in our paper. The 75% is got from supervised fine-tuning the audio encoder. In such a case, you need to finetune on VGGSound in a supervised manner.
Best,
Yusong

Excuse me！ I have the same trouble with the re-producing results of VGGSound on the zero-shot setting. I can just get the top-1 accuracy of about 28.4% by running the pre-trained model  630k-audioset-best.pt with the vanilla VGGSound list test.csv.

Zeroshot Classification Results: mean_rank: 25.6106    median_rank: 4.0000    R@1: 0.2841    R@5: 0.5516    R@10: 0.6609    mAP@10: 0.3979

I am wondering if you will provide the script or other useful resources for reproducing results on VGGSound.
Looking forward to your reply.

Hello! I have the same problems on reproducing the results of zeroshot-classification of VGGSound dataset. With the checkpoint of 630k-audioset-best.pt, I got 29.83% top-1 accuracy on the test set of VGGSound.
Can you give some instructions for reproducing the results on VGGSound?


Move configuration path logic to Util class

Closing because I am abandoning this package in favor of laravel/forge-cli.


Font size difference in Safe cration and Add safe forms

Description
In the last step of both forms there are text that for one form is size 14 and for the other is size 16. It should be both size 16
Environment

Browser: Chrome
Wallet: MetaMask
Chain: Rinkeby
Env #3661

Steps to reproduce

Go to Add safe
Finish the flow until the last step and check the font size of the name of the safe
Repeat for Create safe and check the font size of the safe name

Expected result
Both fonts should be size 16
Obtained result
In the Safe creation form the font size is 14
Screenshots

This isn't a regression, it's the same on prod. Please make sure to check that before attaching an issue to a release.
Fixed it anyway because it was easy.


To be honest I'm not really sure that the problem is in configuration. Correct me if I'm wrong.
On the repositories list page the link for some image is set like http://my.registry.com/repository/repoName But looks like it doesn't satisfy any of router rules from https://github.com/kwk/docker-registry-frontend/blob/v2/app/app.js#L63 (That's why I've got redirected to home page)
Based on this router settings the link to the page with the container details should look like /repository/:repositoryUser/:repositoryName. And when I try to open this page directly it works.
Could you please point me what can be wrong in my setup?  And why should I have something like registryUser?
Thanks in advance

@jhony-chikens Currently the docker-registry-frontend can only work with images that are tagged in the form namespace/image:tag. Do you follow this naming scheme? Can you confirm your behaviour when using the example-setup that I've pointed you before?

@kwk with the example-setup the behavior is exactly the same
I follow the standard naming convention for private docker registries
for instance:
docker tag debian:jessie myregistry.com:5000/debian:jessie
docker push myregistry.com:5000/debian:jessie

@jhony-chikens That is not standard convention. You miss the namespace portion. It should be something like official/debian:jessie. Please test again.

@kwk yep now it works... Thank you a lot!


Add polling refresh to all pages

Seeing various issues where a "refresh" button is being asked for.  All pages in the SUI should have a refresh poller running.

Moved here: https://www.pivotaltracker.com/story/show/134430901


Use Terminus CLI 1.0 rather than the deprecated drush API

Ideal solution (which would remove the need for drush entirely from this container) depends on pantheon-systems/cli#184.
We could get away with replacing the drush pauth and drush paliases calls with their corresponding terminus calls though, and keep the last step a local drush call.

Should be able to this without drush at all.  Something like
terminus site connection-info --site=my-site --env=test --field=mysql_url


Publish 12/24 edition

@sftim Would you please review the content added in https://github.com/kubernetes-sigs/lwkd/pull/277/commits/87a6be6725a6fd68d123150df3bf72789fc7bfc3 about the feature gates table PR?


Major changes to how things work

Next set of improvements will be the removal of pusher, and multiple generations at once provided via promises.

Actually, promises are not quite what we want here. We want a bread-first unwrapping, but all I seem to see about is a depth-first unwrapping, where promises are unwrapped immediately whenever wait is called.

Actually, i should be able to get this work by turning off auto-unwrapping.


Make the applicator error channel bufferred

Brief description
Make the error channel a buffered channel so that if the block application times out, the calling go routine does not get blocked.
Checklist

[X] I have built this pull request locally
[X] I have ran the unit tests locally
[X] I have manually tested this pull request
[X] I have reviewed my pull request
[ ] I have added any relevant tests

Demonstration

For posterity I'll post some of the investigation that led to this patch.
The investigation started when some nodes stopped getting new blocks after about 400,000 - 600,000 blocks.

First observed symptom: p2p is downloading blocks, but they aren't processed which leads to lots of messages in the p2p log like "Encountered peer error: QmS7...k, block application failed: block application timed out.".
Second observed symptom:  Chain log is getting lots of Pushing transaction and Transaction application successful messages, but after the last successful block there are no more messages about blocks.

I eventually realized this behavior is consistent with a problem in the block applicator.  As of this writing the block applicator is (1) fairly new and (2) recently had its plumbing modified.  This didn't yet explain the problem, but it did suggest further investigation of the block applicator may be fruitful.
Then I saw the error channel was initialized without a capacity, which is very suspicious, because usually concurrent code needs the semantics of a queue, not a rendezvous.
Once the potential problem line was found, the hard part was over.  It was comparatively simple to reason through the consequences and confirm the diagnosis is consistent with the symptoms:

In requestApplication() the errChan is initialized without a size, which according to Go semantics means it blocks anyone trying to send / receive until a matching send / receive comes from the other side (rendezvous semantics).
Then we select on errChan and ctx.Done().  So in the (rare, but not impossible) event a peer loses connection or gets terminated for naughty points while it has a block application in-flight, the select gives up on trying to send the error and instead exits on the ctx.Done() branch.
Which causes the loop that drains applyBlockChan to hang at request.errChan <- err as nobody's ever going to attempt to send anything on that errChan ever again.

At this point, we can pretty confidently declare we've found the bug:  A rare but not impossible event putting p2p into a state where it sees timeouts on all subsequent blocks, but those blocks never hit chain, is consistent with the above explanation; the observed symptoms in the logs; and the fact that affected nodes processed hundreds of thousands of blocks successfully before the problem appeared, and got stuck at different places.
The fix, of course, is to initialize errChan with a capacity (of 1, as no more than one message will ever be sent so any larger capacity is simply wasteful).  This means the errChan sender (i.e., the applyBlockChan drain loop) never blocks, and all is well again.


Andr3as can help me? :D Please

I have installed now your plugin of autocomplete!
But when i keyup display strange keys...
Look i capture a video when im writing "if(isset"
https://www.youtube.com/watch?v=-CHxJ3PAVds&feature=youtu.be

Yes, that's a bug. I fixed it with the latest version of the plugin today.
Please create next time an issue in the repository for CompletePlus and choose a proper title.


Repeated sentence

In the first and second paragraphs, the following sentence is duplicated: "Earning codes uniquely identify every type of earning that workers receive. They include parameters that are related to earnings, such as accounting rules, tax laws, reporting requirements, and gross-up capability."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8ae502d5-7ba1-9488-e6ea-6aba18f7d8cb
Version Independent ID: 9068fd4f-755e-4984-302d-bdc5eb44ba71
Content: Set up earning codes and earning code groups - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/fin-and-ops/hr/localizations/noam-usa-earning-code-group-tasks.md
Service: dynamics-ax-applications
Product: ****
Technology: ****
GitHub Login: @andreabichsel
Microsoft Alias: ryansand

@mannesneuer, thanks for letting us know!
@andreabichsel, please update the topic accordingly.

Thank you for bringing this to my attention! I fixed the issue, and it should be live in just a few minutes.


Alternative to stars?

Could I replace the stars with some box with the corresponding number ?
If yes, what is the best way to achieve that? Thanks!

Funny you should mention this, I'm currently working on extending this project to allow customisable rating types, which would allow you to do exactly what you want - and actually for a simply square this will be quite straightforward in the new version. I have now finished the bulk of the work for this,  but I'll be setting up a new repo for it because it will no longer just be stars. Hopefully I'll be able to get a first release of this version up at some point this week because it's essentially the same underlying code as this, but with the ability to extend the components.

Great news! Looking forward to see the updated project!

Just an update on this issue. The code is pretty much finished and I've added an entire font-awesome port, so it's possible to use any font-awesome glyph as a rater as well as creating your own. I just need to write the tests, which I'm planning to do on Monday and update the README to show how to extend the component, then hopefully I can get it released.

@craigh411 thanks for the update on this feature and this great project! If the rating unit (stars, squares, whatever) container can take an array of class names passed from the component props, it will make customization of the shape of the rating unit a breeze - when custom icon font is used, it would be just a matter of passing in the desired css class name defined in the icon font to change the rating unit appearance.
Looking forward to the new package!

The new project is now up and running and can be found at: https://github.com/craigh411/vue-rate-it. It's quite extensive and I still need to doc some of the extensible features, but the components and documentation for rating with stars, hearts, nearly 700 font awesome glyphs and images are complete. You can find the full docs at: https://craigh411.github.io/vue-rate-it.
I will still be maintaining and updating this project as well, so there's no need switch if you're happy with this component.


[BUG] fishstrap (glass) doesnt work

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v<IP_ADDRESS>
What problem did you encounter?
when  using fishstrap (glass) it only made the background more black.
glass:

normal:

im using windows 11 without transparency and that makes the problem.
with transparency:

Bloxstrap Log
N/A

Hi,
Could you check if it's happening in Bloxstrap too?
Thanks.

Hi, Could you check if it's happening in Bloxstrap too? Thanks.

prob not, i had transparency off in bloxstrap and  i saw it ages ago.

this is probably a issue with your pc
i have transparency effects disabled and the glass theme works

this is probably a issue with your pc i have transparency effects disabled and the glass theme works

u  using windows 11?

windows 10

settings -> personalization -> colours


Cache issue

This issue will track the discussion started by @msalsbery in https://github.com/openseadragon/openseadragon/pull/2407#issuecomment-2234955429
I think I've found the issue and will be creating a PR shortly.
I think we should take care of this before 5.0.0 comes out.

@pearcetm awesome thank you! I'm away from office today so I didn't get too far, appreciate it!!

Actually, digging even deeper, I don't think this requires a PR after all.
I thought there might be a problem here:
https://github.com/openseadragon/openseadragon/blob/980deca107df92205e14bea684372ffe2dc41500/src/tiledimage.js#L1433-L1439
...because the code is checking for tile.context2D (which is not typically set), but not checking for tile.cacheImageRecord which is actually set. However, this never really comes into play because of other parts of the logic in TiledImage.
@msalsbery I tried what you said, i.e. zooming in and out of the same part of an image repeatedly, and I saw in the network tab that new requests were being triggered each time (as you described). However, it is actually different tiles each time that are being fetched. This is because not all tiles at a given zoom are fetched before we've zoomed past that level and/or covered it by higher-res tiles. Every time we pass through that zoom, the next "best" tile which hasn't been previously loaded is fetched. So the viewer is building the full pyramid slowly, a few images at a time, during each zoom in/out. Eventually when all the tiles for all the levels are in the cache, no more images get fetched during the zooming.
So, I don't think there's actually a problem that needs to be fixed. If you agree @msalsbery I will close this issue. Of course if the behavior I described above isn't what you were noticing that's a different story!

@pearcetm  So is it just my expectation (or assumption) of what's being cached that's wrong?
Without scroll zooming, just loading the initial image, I'm seeing network requests for duplicate tiles (I can post screenshots when I get back to my office). Obviously, the browser cache would catch a lot of those but I have that turned off at the moment.
Is it because a blurred version of the tiles are being cached as a canvas by OSD so a new network request is being made to get the image data when a tile is rerendered and cached?

@msalsbery I'm not sure why that would be happening.
In a test environment, I modified ImageLoader to have a property requestCount = {} and within addJob I added the following:
        if(this.requestCount[options.src]){
            this.requestCount[options.src]++;
        } else {
            this.requestCount[options.src] = 1;
        }

I've tested with the constrained pan demo, which uses the Duomo image: http://localhost:8000/test/demo/constrainedpan.html
When I set a breakpoint on the line with the increment, it is never hit, and when I inspect that object, I don't see any duplicate calls. You haven't turned the navigator back on since last posting your config options, right? Because that would definitely cause some tiles to be fetched twice (once for each viewer).

@pearcetm Thank you for that.
I just got back in the office so I'll be digging in, but no I didn't put the navigator back 😉

@pearcetm
I'm good with closing this. I've dug into the code and played around enough and I don't see anything that concerns me 😅
Let's get 5.0.0 released!
I really appreciate the help, thank you!

Ok, sounds good, closing this - on to 5.0.0!


Update quickstart-aspnet-core-app.md

The code doesn't load TestApp prefix.

#label:"aq-pr-triaged"