Reenable advisory test

Not sure why these tests stopped working all of a sudden. The pass locally and I don't think it was due to moving to a newer version of bun.

Fixed by upgrading to bun 0.5.7


Add runtime characteristics for Faster/Mask/Keypoint R-CNN to doc

Codecov Report

Merging #937 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #937   +/-   ##
=======================================
  Coverage   60.32%   60.32%
=======================================
  Files          63       63
  Lines        5001     5001
  Branches      745      745
=======================================
  Hits         3017     3017
  Misses       1782     1782
  Partials      202      202

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115d2eb...0862ef3. Read the comment docs.


Opening external link with 'target' does't work as expected

With reference to issue https://github.com/ReactTraining/react-router/issues/1147 from 2015, <Link /> does not support opening external link in new tab with the target="__blank" since react router blocks than action. The <a> was supposed to be used to get that behaviour.
Now I'm using   "react-router-dom": "^4.2.2" and even the <a> tag is still has target="_blank" blocked. Its may be a bug.

React Router is not aware of any <a> elements, so it cannot block navigation. I through together this quick demo to show an <a target="_blank"> working: https://codesandbox.io/s/720n0r8z16 You can fork and edit it if you think I've missed something, but I have to imagine that any blocking issues are on your end and are not coming from React Router.


Add group verification for GitLab

Seems what we're looking for is this:
In [6]: gl.groups.list(min_access_level=30)
Out[6]: [<Group id:2037543 name:Flathub>]

Values are documented here. We will need to ask GNOME/KDE for specific group IDs to check against.

I think this was done?


ClientModel: Add retry classification to MessageClassifier

Addresses https://github.com/Azure/azure-sdk-for-net/issues/41465
This PR also adds the ability to compose classifiers, for both error and retry classification.

API change check
APIView has identified API level changes in this PR and created following API reviews.
System.ClientModel


Error trying to use named database instead of (default)

I'm trying to use a different cloud firestore database named "temp" instead of the (default) one in firebase-admin.
The instance gets initialized successfully but when I try to run any operation it fails.
Code:
const DBInstance = getFirestore(AppInstance, "temp");
Error:
Error: 3 INVALID_ARGUMENT: The request was for database 'projects/foyer-work/databases/temp' but was attempting to access database 'projects/foyer-work/databases/(default)'

I tried to reproduce this with latest admin sdk "firebase-admin": "^11.10.1", and it worked as expected.


Hypertables and Chunk support

Add support for create and managing hypertables and chunks

[x] create_hypertable
[ ] show_chunks
[ ] drop_chunks
[ ] reorder_chunk
[ ] move_chunk
[ ] add_reorder_policy
[ ] remove_reorder_policy
[ ] attach_tablespace
[ ] detach_tablespace
[ ] detach_tablespaces
[ ] show_tablespaces
[ ] set_chunk_time_interval
[ ] set_integer_now_func
[ ] add_dimension
[ ] create_index (transaction per chunk)
[ ] hypertable_size
[ ] hypertable_detailed_size
[ ] hypertable_index_size
[ ] chunks_detailed_size

@davydog187 do you want to add these functions to the migration.ex file or start to break things up but grouping (ie chunks.ex) and import them?

What if we added to migration, but then for the more diagnostic functions we add to a different module?

I don't think we need most of these for the first release. Will split this out


Observer should have configurable handling of retrying failed partitions

For instance hard coding giving up a failed partition after 10 attempts

Duplicate of #494


Switch Organization Authentication Endpoint

Scope of changes
Implements a /v1/switch endpoint so that authenticated users can switch organizations without having to login again.
Fixes SC-16223
Type of change

[x] new feature
[ ] bug fix
[ ] documentation
[ ] testing
[ ] technical debt
[ ] other (describe)

Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible.
Please see questions in the comments line by line.
Author checklist

[ ] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[ ]  Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[ ]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
[ ] Are there any TODOs in this PR that should be turned into stories?
[ ] I've resolved all open questions created by @bbengfort

@pdeziel ok, wrapped up this PR -- would you mind merging if the review is ok?


feat: Add ETH Balance Check on RP Matching

Review Type Requested (choose one):

[ ] Glance - superficial check (from domain experts)
[x] Logic - thorough check (from everybody doing review)

Summary
Add ETH Balance Check on RP Matching
Task/Issue reference
Closes: https://github.com/orgs/Lilypad-Tech/projects/4/views/2?pane=issue&itemId=70516884
Details (optional)
Add any additional details that might help Code Reviewers digest this PR
How to test this code? (optional)
Anything else? (optional)

Question. What happens if a resource provider has sufficient funds at the time of the resource offer, but when the matchmaking occurs they do not?
This may be an edge case that we want to take on later. It may be a bit more involved to implement.

Question. What happens if a resource provider has sufficient funds at the time of the resource offer, but when the matchmaking occurs they do not?
This may be an edge case that we want to take on later. It may be a bit more involved to implement.

We can create a separate PR for this edge case. @apquinit please take note.


The database password is exported along with the dashboards

While exporting the dashboards, the database password is exported as well (in plaintext) despite it's not used when importing them later.
Expected results
The password is not exported at all.
Actual results
The password is exported.
How to reproduce the bug

Go to 'Dashboards'
Select all dashboards
Press Actions -> Export
In the downloaded JSON file, look for "password:"

Environment
(please complete the following information):

superset version: 0.34.0
python version: 3.6.8
node.js version: v8.16.1
npm version: 6.11.3

Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Closing this issue, since it no longer happens.


How to check banner status by cookie name?

Good day! I have 2 banners, each with its own cookie name.
window.cookieconsent.initialise({   cookie: {     name: "22222222"   }
The problem is that the second banner should appear only if the first one is in the "dismiss" status. How to check status of first banner by name?
I tried to do something using onInitialise: function(status) , but nothing happened.
Thx

Different cookie names are not enough. window.cookieconsent is still only 1 object namespace still, not 2.
CC would need a feature like:
https://www.w3schools.com/jquery/jquery_noconflict.asp
https://github.com/js-cookie/js-cookie#namespace-conflicts
https://developers.google.com/analytics/devguides/collection/analyticsjs/renaming-the-ga-object
Currently, CC can handle only 1 banner and cookie. It will clobber itself if you try to initialize 2 times:
https://github.com/insites/cookieconsent/blob/master/src/cookieconsent.js#L2
https://github.com/insites/cookieconsent/blob/master/src/cookieconsent.js#L1742
Even if you initialize 2 object names, each banner won't have a unique HTML element ID:
https://github.com/insites/cookieconsent/blob/master/src/cookieconsent.js#L296
so their event handlers can't target a specific banner:
https://github.com/insites/cookieconsent/blob/master/src/cookieconsent.js#L373

@suslikt unfortunately @courtneyaschwartz is correct. CookieConsent is not set for multiple instances in a single page. Can I ask what your use case is for this because maybe the current event hooks are enough for you as this library doesn't handle disallowing cookies for a domain per se, it's a lib that has a view layer and offers some event hooks with statuses tied to a cookie ( within it's own regulations )?
Maybe we can add this as a feature in v3.x somewhere along the line, but in v4 we will be using objects and constructors so you will be able to have as many as you want.

Feature in coming version. ( ~v4 or ~v5 ) as it introduces breaking changes. Closing Issue.


updated regex in satisfies version function to fix issue #5671

[x ] Have you followed the guidelines in our Contributing document?
[ x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x ] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[ x] Have you successfully run brew style with your changes locally?
[ x] Have you successfully run brew tests with your changes locally?

@hannahmendez Would you consider reopening and we can work through this together?


minor updates to README

Codecov Report

Merging #36 (87e034e) into main (f09ca2b) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   82.98%   82.91%   -0.07%
==========================================
  Files          21       21
  Lines        2862     2862
==========================================
- Hits         2375     2373       -2
- Misses        316      319       +3
+ Partials      171      170       -1

Impacted Files
Coverage Δ

match.go
90.56% <0.00%> (-3.78%)
:arrow_down:

debug.go
88.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09ca2b...87e034e. Read the comment docs.


is it "docker0" or is it "bridge"

File: engine/userguide/networking/default_network/custom-docker0.md, CC @mstanleyjones
Is it possible that this article confuses "docker0" (shown by "brctl show") and "bridge" (listed by "docker network ls")? This makes this article very hard to understand.

It's not really wrong, though. The name of the bridge device in the Linux kernel is docker0. The name of the device from Docker's point of view is bridge, even if it's on Windows.

Closing -- feel free to re-open if you need more details.


Copy strings without quotes

The users of my project often copy individual string values from the json rendered with react18-json-view (I got great feedback on the new json view by the way 🙏). I'd like to customize the copy behavior of strings to not include double quotes.
Is this a better default copy behavior for everyone (changing the default) or what are your thoughts on supporting custom stringifyForCopying functions?

(I'd be happy to contribute the change if you agree that it is a better default)

You make a valid point. The default behavior for copying strings should be to remove the quotation marks, and it would also be beneficial to provide users with a customization option.


⚠ Bofrost.at has degraded performance

In 4b76514, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2288 ms

Resolved: Bofrost.at performance has improved in 3fbc817.


There is no service implementing IResolverContext

Using HC 12.0.0-preview.29
A query which uses in its implementation IResolverContext fails with the message:
"message": "No service for type 'HotChocolate.Resolvers.IResolverContext' has been registered.",
The stack trace is as follows:
"stackTrace": [
"   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)",
"   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)",
"   at HotChocolate.Execution.Processing.MiddlewareContext.ServiceT",
"   at lambda_method637(Closure , IResolverContext )",
"   at HotChocolate.Types.Helpers.FieldMiddlewareCompiler.<>c__DisplayClass9_0.<b__0>d.MoveNext()",
"--- End of stack trace from previous location ---",
"   at HotChocolate.Execution.Processing.Tasks.ResolverTask.ExecuteResolverPipelineAsync(CancellationToken cancellationToken)",
"   at HotChocolate.Execution.Processing.Tasks.ResolverTask.TryExecuteAsync(CancellationToken cancellationToken)"
]
To reproduce just inject IResolverContext to a field resolver or inject this interface into an object's constructor instantiated by DI.

@eugenpaval  IResolverContext is not a service an therefore cannot be injected into a object constructor instantiated by the DI.
If you want to inject it into a resolver you can just do it like this
public class Query
{
    public string GetFoo(IResolverContext resolverContext) => "";
}

@eugenpaval IResolverContext is not a service an therefore cannot be injected into a object constructor instantiated by the DI.
If you want to inject it into a resolver you can just do it like this
public class Query
{
    public string GetFoo(IResolverContext resolverContext) => "";
}

Still get the error but if I add [SchemaService] attribute to the parameter  it works!
public class Query
{
    public string GetFoo([SchemaService] IResolverContext resolverContext) => "";
}

The way Pascal has showcased should work, I've just tried it as well. I believe you are registering something weirdly.
Could you share the code of your ConfigureServices method in Startup.cs?

I will check if that is a bug with the new resolver compiler. He is on preview 29.

Just one remark... The IResolverContext is a rented object that can NOT be injected in constructors. The IResolverContext is not a service and is injected by the execution engine during processing of the field. It is also not possible to hold on to such an instance since as soon as a field is processed it will be reinitialized for the next field.

I have checked and everything works as expected in the build. Closing this issue.


Wrong position of cursor

Hi again.
Same env.
Really often, when I working with haXe plugin, my cursor doesn't move anymore. I mean, the visual representation of it doesn't move (the blinking | ).
I can still move it, write new characters, erase other, insert lines, and all the things, but my cursor won't move until I :

Click somewhere with my mouse
Restart sublime.

That's really annoying. Any though ?

Same reasons, I guess... Dirty hacks to be removed :)

Hopefully fixed by latest changes.
Could you confirm ?
Cheers,
Clément


docs: Add user guide for Configure email digest notifications

In PR #3376, @timabbott requested that the email digest feature be documented; this PR documents the email digest feature.

Automated message from Dropbox CLA bot
@synicalsyntax, it looks like you've already signed the Dropbox CLA. Thanks!

So the email digests have somewhat different content than described here.  I just forwarded you an example such email (from a test account on chat.zulip.org).  I don't think we need to go into detail on what exactly is in there (the sections, etc.) -- just explain it's a weekly digest email with stuff that happened on a Zulip server while you were away.

@timabbott Fixed!

Looks great!  Merged, thanks @synicalsyntax!  One small comment: we usually include periods at the end of commit message :).

@timabbott Ah, thanks for the tips! I'll keep that in mind next time.
Since this PR has been closed, do you mind checking out PR #3376, the PR that originally brought up this issue in the first place?


how to read text along with inline shapes info?

I have a simple docx file like this(just insert a inline png file to text):
I've tried:
>>> x=docx.Document('12.docx')
>>> for p in x.paragraphs:
    print(p.text)

headend
>>> list(x.inline_shapes)
[]

And I unzip 12.docx file, found word/media/image1.png is the location. So is there a way to get a output like:
>>> for p in x.paragraphs:
    print(p.text_with_image_info)

head<word/media/image1.png>end

Not presently. You would have to iterate through the child elements of the <w:p> element for the paragraph at the lxml level for the time being.
There's been some talk about adding a Paragraph.iter_run_level_items() method that would do that but there's no clear commit on when that might be implemented.


fix: optimize apigw deployment

:tada: This PR is included in version 1.4.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fix security vulnerabilities (CVE-2018-3728, CVE-2017-16042)

This fixes two security vulnerabilities in node-soap:

CVE-2017-16042

Fix: Update coveralls to the latest version (2.11.6 => 3.0.1). Version 3.0.1 uses a newer version of request that removes the dependency on hoek.

CVE-2018-3728

Fix: Update mocha to the latest version (1.17.0 => 5.2.0) and add --exit flag to mimic pre-v4.0.0 behavior (more info here). Version 5.2.0 uses a newer version of growl that fixes the vulnerability.

Coverage remained the same at 93.267% when pulling 0e6ea1b042f9506ff2fd0aa1988d820ac6c00848 on fix-vulnerabilities into 56a96d3df032f64d8e8f82e2e1e7526ee8ccbd8c on master.

Thanks for the review @herom!


networkmanager is outdated

Checklist

[x] Checked the nixpkgs master branch

[x] Checked the nixpkgs pull requests

Project name
nix search name: networkmanager

current version: 1.26
desired version: 1.30
Notify maintainers

maintainers: @Phreedom @domenkozar @worldofpeace @obadz
Note for maintainers
Nothing notable in changelog: https://github.com/NetworkManager/NetworkManager/blob/master/NEWS
Motivation: https://www.xmodulo.com/wireguard-vpn-network-manager-gui.html says wireguard support comes with 1.26.2
Please tag this issue in your PR.

Yep, will try to get this and also do minor updates to stable.


Confirm your email address

Browser Version
Chrome
Exension Version
1.5.3
Actual behaviour
Extension shows a screen which says "Confirm your email address." I've attached a screenshot. I've tried clearing my cookies and redownloading but neither fixed this issue.

Reproduction steps
No response
Expected behaviour
No response

I have the same issue. How can i bypass that

I published a new release to address the issue. Please tell me if it has fixed the problem.

Hmm sort of the confirm your email address is gone but the ability to scroll is gone. To be clear you're able to hit show more steps but unable to scroll down to see them past the first one or two steps.

I have the same problem that I cannot scroll doơn. However still see the solution by zoom in or zoom out the screen. But still a little bit hard to use

I can still see the scroll bar, what is the URL of the page you are looking at? If you open the console do you see any element with the overflow: hidden; attribute?

Prefacing this by saying I've made an account just so I can reply to your comment. I am experiencing the same bug on the following URL
https://quizlet.com/explanations/textbook-solutions/calculus-early-transcendentals-9th-edition-9781337613927/chapter-11-exercises-2b-773a4a1b-7243-48e6-9d84-e35aa8085692

Does this build work?

Does this build work?

This seems to fix the scrolling bug. Thank you!

Does this build work?

it still gives me the same notification to verify the email so I can not scroll at all

Looks to be working on my end, thanks.


Cypress tests: get rid of all "force: true"

In our cypress tests, we have a lot of cy.get('...').click({ force: true }). While sometimes desirable, we should avoid it as much as possible because it doesn't test the following cases:

Ensure the element can be scrolled to.
Ensure the element is not hidden.
Ensure the element is not disabled.
Ensure the element is not detached.
Ensure the element is not readonly.
Ensure the element is not animating.
Ensure the element is not covered.

Best solution for this problem
For most tests on the collective page, { force: true } can be avoided by calling disableSmoothScroll at the beginning of the test (see function description for more details about this issue). We should actually add it as a command in https://github.com/opencollective/opencollective-frontend/blob/19735cce1c713ef26014f072e9d75120a78c1b2f/test/cypress/support/commands.js so that it can be called with cy.disableSmoothScroll().
For all other cases, we should either:

Remove the { force: true }
Add a comment next to it to explain why it's necessary (there must be a good reason)

Tests written with Cypress must follow our good practices conventions.

🏆 This issue was completed by @brymut
To claim the bounty please, as a recurring contributor, please simply add it to your next invoice to Open Collective Engineering https://opencollective.com/engineering/expenses/new  Please make sure to mention the ticket number in the invoice and in the expense title.

The PR was reverted and so the issue is open again.

@brymut fyi


Shutdown command request

At my company's assembly location, we require shutting down and turning on the server intermittently. I was wondering if it could be possible to add a shutdown command to gracefully shutdown the server without corrupting anything through the web application.

Not easier to add a physical button to the Pi playing server for that?
(Connect button between pin 5 & 6, add to /boot/config.txt: dtoverlay=gpio-shutdown )

We looked into that first, but the device we are using doesn't have easy access to physically add a button or easy access to GPIO pins. Before attempting that, we thought we would check to see if it was an easy feature to add or one that others may find useful. If it isn't likely to get implemented then we will revisit adding a button.

Before attempting that, we thought we would check to see if it was an easy feature to add or one that others may find useful.

You can add it relatively easy yourself.
Not sure if it is suitable for inclusion as a general feature though, as others may not like the concept of adjusting security so that the webserver user can shutdown the server.

Thanks, we will look into these solutions.


not support javascript projects?

I'm working on a project that uses javascript, but it seems your tools are not supported?

Probably duplicate of https://github.com/pmizio/typescript-tools.nvim/issues/199#issuecomment-1845177592.
Please let me know if linked comment helps.


getParsys for a Parsys inside Multiple parsys

datapath for a parsys looks like .....jcr: content/content/cardsv2/carditem/carditem/minicarditem. How to edit the parsys with such a long datapath as it is inside multiple parsys. When I tried with getParsys (Configuration), where the Configuration in the Pages.YAML has the value like datapth: /content/cardsv2/carditem/carditem/minicarditem - throwing Null pointer exception.

Hi @thirunavookkarasu,
there's not enough info for me to answer the above question.
How are you accessing the parsys? Could you provide the full stacktrace?
Also, please note that when I wrote the TouchUI bits, I did not have complex cases like nested parsyses in mind, so it is possible that it won't be possible with current API and some additional development would be required.

Nested parsyses will be addressed in the upcoming new authoring API.


Notes about Validator/BeaconNode Separation

TODO:

Implement the Validator APIs on JSON-RPC Server

Some notes:

For the query requests: use the given chain: AsyncBeaconChainDB to query.
For the broadcast request: use EventBus to send request to Node to broadcast.

Implement Validator Plugin

Each validator has its own SlotTicker service

Final goal: Split trinity-beacon (the node) and the validator

this would be a great opportunity to look at a "pure" trio application -- i'd be quite curious to see the difference b/t a more 'structured' approach to concurrency and our useage of asyncio in the existing stuff

i'd like to look into writing the Validator component as a pure trio component -- if someone else has started on this, then let's coordinate as we will want to move in that direction eventually either way


just clicking on the icon to toggle the grid

when clicking on the app icon and the grid is off, the grid is supposed to turn on. since the reverse is true (when clicking on the app icon and the grid is on, it toggles)

Hi mahmoud! Please explain more about what you mean? Does this mean there's a problem with using the extension, or are you requesting a new feature?


raft_client: limit batch size

What have you changed?
Limit batch size for raft_client so that connections won't broken frequently.
Close #6727 .
What is the type of the changes?
Improvement.
How is the PR tested?
Integration test.
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
Does this PR affect tidb-ansible?
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)

The wrong usage mentioned in https://github.com/tikv/grpc-rs/issues/435 seems not to be fixed yet.

https://github.com/tikv/grpc-rs/issues/435 is fixed now:
[2020/03/05 16:57:01.195 +08:00] [WARN] [raft_client.rs:93] ["batch_raft fail"] [err="RpcFailure(RpcStatus { status: RpcStatusCode(13), details: Some(\"Received RST_STREAM with error code 2\") })"] [to_addr=<IP_ADDRESS>:60004]
[2020/03/05 16:57:01.196 +08:00] [WARN] [raft_client.rs:129] ["batch_raft/raft RPC finally fail"] [err="RpcFailure(RpcStatus { status: RpcStatusCode(13), details: Some(\"Received RST_STREAM with error code 2\") })"] [to_addr=<IP_ADDRESS>:60004]

/bench +ycsb

/bench +ycsb

/bench +ycsb

For performance, the old result shows that it reduces performance a little (about 2%).


⚠ Bofrost.fr has degraded performance

In 4c1ff27, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 956 ms

Resolved: Bofrost.fr performance has improved in 2c7596b.


doesn't include the Jets layer when config.gems.disabled = true

Checklist

[x] Upgrade Jets: Are you using the latest version of Jets? This allows Jets to fix issues fast. There's a jets upgrade command that makes this a simple task. There's also an Upgrading Guide: http://rubyonjets.com/docs/upgrading/
[x] Reproducibility: Are you reporting a bug others will be able to reproduce and not asking a question. If you're unsure or want to ask a question, do so on https://community.rubyonjets.com
[ ] Code sample: Have you put together a code sample to reproduce the issue and make it available?  Code samples help speed up fixes dramatically. If it's an easily reproducible issue, then code samples are not needed. If you're unsure, please include a code sample.

My Environment

Software
Version

Operating System

Jets
3.0.4

Ruby
2.5.0

Description
We have an enterprise app running on jets but we have a custom layer for this application, when we try to add our custom layer the deployments fail because it exceeds the layer limit on lambda, I did a quick research and I realized that when I add a custom layer, Jets stills uploading its layer.
Expected Behaviour
if I set this config config.gems.disabled = true on config/application.rb jets should not upload its lambda layer

Current Behavior
when I added my custom layer with this config, the deployment fails because it reaches the layer limit on lambda(size)
# config/application.rb
config.gems.disable = true
config.lambda.layers = ["my_custom_layer_arn"]

Step-by-step reproduction instructions

Code Sample

Solution Suggestion
if a user adds a custom layer, jets should not upload its gem layer, I think we can fix it by adding this condition here
def get_layers(runtime)
  return nil unless runtime =~ /^ruby/
  return Jets.config.lambda.layers if Jets.config.gems.disable

  ["!Ref GemLayer"] + Jets.config.lambda.layers
end

Hello @tongueroo this PR fix this problem https://github.com/boltops-tools/jets/pull/542/files, that solved the problem in our project
gem "jets", github: "moonshot-partners/jets", branch: "fix/layers"


Update README.md

Hey,
I just made few changes to the Readme file.

I am really sorry but this is not relevant.


Lucas burgess patch 1 pythonversion3.6

Update version numbers to 3.6

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: LucasBurgess sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Remove old pip wrapper

The old pip wrapper was kept to support older versions of pip, but now it's 2020.  Time to move on.

I think some users are actually using this independently.


implement enum variant to msg field matching

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior?
Currently, a single enum is created for all constants of one message instead of generating an enum for all constants belonging to the same message field. This is listed as a missing feature in the README.
What is the new behavior (if this is a feature change)?
Constants are now sorted into specific enums if a) there is only one field with a matching type, or b) if they have a field's name as a prefix. Constants that cannot be matched to a field using either method still end up in the catch-all enum.
This message definition
# example_msgs/example.msg
uint8 STATUS_DISABLED = 0
uint8 STATUS_ENABLED = 1

uint8 OTHER_THING_1 = 1
uint8 OTHER_THING_2 = 2

uint8 status
uint8 other
uint8 more

becomes
export interface ExampleMsgsExample {
  status: ExampleMsgsExampleStatus;
  other: ExampleMsgsExampleOther;
  more: number;
}

export enum ExampleMsgsExampleStatus {
  Disabled = 0,
  Enabled = 1,
}

export enum ExampleMsgsExampleOther {
  Thing1 = 1,
  Thing2 = 2,
}

Other information:
Tested on ROS1 noetic. The PR probably still needs a docs update; Should this behaviour be configurable / off-by-default to maintain downwards compatibility?

Looks good, I'll merge this as part of your other PR


fix name

Summary

I was reading the docs, and I'm guessing this was forgotten to be changed when the key above changed?
Changelog

[Internal] [Fixed] - Update documentation
Test Plan

Closing as this is already fixed on main


[Tokio migration] Merge dev and refactor

In this PR, I merged dev into tokio_migration (sorry, @ashthespy, in case you already merged dev as well), and then I did some refactoring. This looks like very much, but actually it's only a very shallow refactor, mostly trying to reduce the number of dependencies. (Nevertheless, dev and this branch are further diverging, merging will get harder. I hope there aren't too many other PRs in preparation.)
Here are a few things worth noting:

Reverted #548 to make merging easier. After merging I reimplemented the functionality, but a little easier and with less code duplication.
I hope you're fine with using tokio's channels instead of futures' channels. I had the impression that the tokio channels were created with some of the drawbacks of futures' channels in mind.
Move the get_credentials function as I suggested in #596.
Remove LinearMap dependency and simply use HashMap. It wasn't clear why it was used at all, but it could be reverted if you know the reason.
Update the url dependency (#368)
Remove default impl for SessionConfig (it wasn't used, but needed the uuid dependency for librespot-core)
#566 used the slightly outdated error-chain, I replaced it by thiserror.

PS: Compare changes except merging

@Johannesd3 I am going to merge things as in into this branch -- I am a bit preoccupied with submissions, will tests things ASAP..


Improve semicolon detection experience for new files

TypeScript Version:  3.6.0-dev.20190810

Search Terms:

semicolon
format
auto import

Repo
For a very simple project:
tsconfig.json
{
    "compilerOptions": {
        "module": "commonjs",
        "target": "es2016",
        "jsx": "preserve"
    },
    "exclude": [
        "node_modules",
    ]
}

constants.ts
export const a = 1
export const b = 1
export const c = 1
export const d = 1
export const e = 1
export const f = 1

main.ts
console.log(a)

Trigger auto import quick fix in main.ts on a

Expected behavior:
Since constants.js does not use semicolons, the import should not have a semi colon
Actual behavior:
The added import has a semi colon
I believe this is because the current semicolon detection logic (#31801) requires some number of examples in the current file to learn from. For new files, this means we always default to using semicolons even if the rest of the project is semicolonless
I can understand why we do this, but as a user I found it frustrating that TS would still insert semicolons until I added a certain number of imports (or other statements that are also used by the detection code). I don't know if looking at the rest of your project code is feasible or not for semicolon detection but we should discuss if we can improve the experience for new files
/cc @andrewbranch
Related Issues:

#19882

The better solution may be to add an explicit preference for semicolons, similar to one we already have for quotes. Trying to infer if semicolons should be used or not from other files in the project could be messy and prone to errors


AVIF fixes and options

Pretty happy for this, except that 'grayscale' produces a file that cannot be decoded, and '4:2:2' produces a file that our decoder can't decode (but Chrome can). @surma @RReverser any ideas?
However, I'd be happy launching with those features removed.
The encoder and decoder are pretty beefy (700k each), but I guess there's nothing we can do about that?

Spotted a bug: If I enable 'separate alpha', then adjust the sliders so they match, it disables 'separate alpha', which is exactly the thing I was trying to avoid 😄

I've committed my manually built smaller wasms for AVIF. https://github.com/GoogleChromeLabs/squoosh/issues/805 is filed to fix it up properly.
I reverted all the mozjpeg stuff, since it significantly increased the encoder wasm size, but I kept the minor webp changes from the v2 codecs branch. Is that ok @surma?
I think this is good to go. I'd still like @developit to review, but it doesn't need to block launch.


Blueprint Assignment IaC Issue

I am having issue with assigning blueprint to subscription thru bicep.  Following is the bicep I'm using.  I'm using system assigned identity, we don't want to not use user managed identity
resource assignment 'Microsoft.Blueprint/blueprintAssignments@2018-11-01-preview' = {
  name: name
  location: location
  identity: {
    type: 'SystemAssigned'
  }
  properties: {
    displayName: displayName
    blueprintId: blueprintVersionId
    scope: scope
    resourceGroups: {}
    parameters: {
      resourceLocation : {
        value: location
      }
    }
    locks: {
      mode: 'None'
    }
  }
}

Following is the error I receive:
Exceeded maximum wait time of '00:05:00'. Message: 'Either the Azure Blueprints service principal does not have owner permissions on the target subscription, or the system-assigned managed identity has not yet finished replicating.'.
Blueprint assignment using system assigned works with no problem from the portal.  But,  I need to this to work from code.
The error says identity may not be finished replicating.  How do I implement wait time for it?

@alex-frankel
Please see the issue I reported.  Also, what is the status of deployment stack release?

Seems that problem is still relevant - got the same deploying Blueprint using Azure Cli (updating existing assignment). Solved manually granting owner rights to Azure Blueprints SP:

get Azure Blueprints SP Id
az ad sp show --id f71766dc-90d9-4b7d-bd9d-4499c4331c3f --query "id"
get your subscription id (choose needed from list)
az account list --query "[].{name:name, id:id}" --output tsv
grant owner permissions
az role assignment create --assignee "_Blueprints_SP_Id_" --role "Owner" --subscription "_Subscription_Id_"
After procedure I made assignment update from Azure Cli work again.


Basic example does not work with Parcel

Current Behavior:
Hi folks, if I follow the getting started instructions, the library doesn't load when using the Parcel bundler.
🚨 Build failed.

@parcel/core: Failed to resolve 'vidstack' from
<EMAIL_ADDRESS>
Expected Behavior:
The basic React example from the docs  should work.
Steps To Reproduce:

Install parcel
Create a basic react app
Import Vidstack

Reproduction example: https://github.com/vladinator1000/vidstack-example-bug
Environment:
  "dependencies": {
    "@vidstack/react": "0.3.2",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "vidstack": "0.3.2",
    "typescript": "4",
    "parcel": "2.8.3"
  },

Framework: React
Meta Framework: Vanilla
Node: 18
Device: PC
Browser: Firefox

This issue is outdated now since our new 1.0@next release. If the issue persits after upgrading, feel free to let me know here and we can reopen. If the issue has changed then please open a new one.


max auto or |+x| not working correctly with stacked columns

Checklist

[X] I updated the card to the latest version available
[X] I cleared the cache of my browser
[X] I verified that I'm really running the lastest version in my browser console
[X] I checked if there is another issue opened with the same problem

Describe the bug
I have multiple sensors displayed as stacked columns.
For example the sum of one columns is 30kWh and the bottom column is 15kWh.
the max value of the y-axis is then only at around 15kWh and the rest above is cut off.
Version of the card
Version: 2.1.2
To Reproduce
This is the configuration I used:
type: custom:apexcharts-card
apex_config:
  chart:
    height: 300px
graph_span: 2d
span:
  end: day
stacked: true
header:
  show: true
  title: Hausverbrauch letzte 24h
  show_states: true
  colorize_states: true
now:
  show: true
  color: green
yaxis:
  - id: one
    min: 0
    max: 30
    decimals: 1
    apex_config:
      tickAmount: 10
series:
  - entity: sensor.hostname_wechselrichter_home_consumption_from_grid_day
    yaxis_id: one
    name: Netzbezug
    stack_group: a
    color: 3A506B
    type: column
    stroke_width: 1
    extend_to: now
    group_by:
      func: diff
      duration: 1h
  - entity: sensor.hostname_wechselrichter_home_consumption_from_pv_day
    yaxis_id: one
    name: Eigenverbrauch PV direkt
    stack_group: a
    color: FFC300
    type: column
    stroke_width: 1
    extend_to: now
    group_by:
      func: diff
      duration: 1h
  - entity: sensor.hostname_wechselrichter_home_consumption_from_battery_day
    yaxis_id: one
    name: Eigenverbrauch Batterie
    stack_group: a
    color: 39D353
    type: column
    stroke_width: 1
    extend_to: now
    group_by:
      func: diff
      duration: 1h
  - entity: sensor.hostname_wechselrichter_energy_to_grid_day
    yaxis_id: one
    name: Einspeisung
    stack_group: a
    color: D72638
    type: column
    stroke_width: 1
    extend_to: now
    group_by:
      func: diff
      duration: 1h
  - entity: sensor.hostname_wechselrichter_battery_charge_from_pv_day
    name: Batterieladung
    stack_group: a
    color: 56CCF2
    type: column
    stroke_width: 1
    extend_to: now
    group_by:
      func: diff
      duration: 1h
  - entity: sensor.enector_geladene_energie
    name: Wallbox
    stack_group: a
    color: 5555FF
    type: column
    stroke_width: 1
    extend_to: now
    group_by:
      func: diff
      duration: 1h

Screenshots
If applicable, add screenshots to help explain your problem.

Expected behavior
I expected the max value of the y-axis to be calculated from the sum of all columns
Desktop (please complete the following information):

Browser [Firefox]
Version [133.0]

Additional context
Add any other context about the problem here.

I was looking for solutions for the same problem, with stacked columns if I do not set max value for the y-axis the axis is cut off at the biggest value of the series, not showing the stacked (combined) value.
I also noticed that a chart with column and line series renders in an unexpected way. Max value here is 15 but without max value set for y-axis, the chart shows until 40 which leaves a lot of empty space:

Then if I set max: auto (or max: ~0) I get:

...i.e. seemingly it is taking max from the first series and thus cutting the line series for values above 6. These might be two sides of the same issue with (min/)max?


Update screaming-frog-seo-spider to 9.2

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thanks for the PR!


Update sanitize-html from 2.7.3 to 2.8.0 fails under webpack 4: Module parse failed: Unexpected token

Hi, we are using ckeditor which is using sanitze-html inside it. And it seems like with the latest release it does not longer support webpack 4?
To Reproduce
Step by step instructions to reproduce the behavior:

composer create-project sulu/skeleton # (requires composer)
cd skeleton/assets/install
npm install
npm run build

Errors now with:

ERROR in ./node_modules/htmlparser2/lib/esm/index.js 59:9
Module parse failed: Unexpected token (59:9)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
|     return getFeed(parseDOM(feed, options));
| }

export * as DomUtils from "domutils";
| // Old name for DomHandler
| export { DomHandler as DefaultHandler };

Expected behavior
Build should work as expected.
Describe the bug
The update from htmlparser2 from 6 to 8 seems to crash this. Seems like htmlparser2 8 version does not support webpack 4 terser parser?
Details
Version of Node.js: 14
Server Operating System: MacOS
Additional context:
Webpack 4 Terser Parser.
Screenshots

I found a workaround which I wanted to share here if someone else stuble over it. The workaround is to run the whole htmlparser2 through babel currently. In my case I also needed to extend the webpack.config.js to add the htmlparser2 be loaded over the babel-loader:
diff --git a/babel.config.json b/babel.config.json
index f22d5f2bb4..757b4dacc6 100644
--- a/babel.config.json
+++ b/babel.config.json
@@ -8,7 +8,8 @@
         "@babel/plugin-transform-flow-strip-types",
         "@babel/plugin-proposal-nullish-coalescing-operator",
         "@babel/plugin-proposal-class-properties",
-        "@babel/plugin-proposal-optional-chaining"
+        "@babel/plugin-proposal-optional-chaining",
+        "@babel/plugin-proposal-export-namespace-from"
     ],
     "assumptions": {
         "setPublicClassFields": true
diff --git a/package.json b/package.json
index<PHONE_NUMBER>..63270c671d 100644
--- a/package.json
+++ b/package.json
@@ -35,6 +35,7 @@
         "@babel/core": "^7.5.5",
         "@babel/plugin-proposal-class-properties": "^7.16.5",
         "@babel/plugin-proposal-decorators": "^7.4.4",
+        "@babel/plugin-proposal-export-namespace-from": "^7.18.9",
         "@babel/plugin-proposal-nullish-coalescing-operator": "^7.14.2",
         "@babel/plugin-proposal-optional-chaining": "^7.18.9",
         "@babel/plugin-transform-flow-strip-types": "^7.4.4",
diff --git a/webpack.config.js b/webpack.config.js
index 563a3d48c8..caa8711162 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -85,7 +85,7 @@ module.exports = (env, argv) => { // eslint-disable-line no-undef
                 {
                     test: /\.js$/,
                     // eslint-disable-next-line max-len
-                    exclude: /node_modules[/\\](?!(sulu-(.*)-bundle|@ckeditor|ckeditor5|array-move|lodash-es|@react-leaflet|react-leaflet)[/\\])/,
+                    exclude: /node_modules[/\\](?!(sulu-(.*)-bundle|@ckeditor|ckeditor5|array-move|htmlparser2|lodash-es|@react-leaflet|react-leaflet)[/\\])/,
                     use: {
                         loader: 'babel-loader',
                         options: {

Thanks for providing a solution for those who encounter this. I agree it's
not a bug (it's using valid JS syntax) but helpful to have a workaround for
those who use sanitize-html on the front end in an older build stack.
On Tue, Dec 13, 2022 at 8:40 AM Alexander Schranz @.***>
wrote:

Closed #592 https://github.com/apostrophecms/sanitize-html/issues/592
as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/sanitize-html/issues/592#event-8025601529,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAH27KNR54BVSMAVG6CSW3WNB4D5ANCNFSM6AAAAAAS5FSIPU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***
com>

--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his

I'm still having this issue. I tried everything but no such luck. Any ideas?
Details
Version of Node.js: 12.22
Server Operating System: MacOS
Additional context:
Using laravel-mix 5.


ci: auto update description in package.json on repo creation if avail…

Resolves #12
Hi @PaulRBerg, please review this PR and let me know if anything needs to be changed.

Love it, thanks @ahmedali8!!


Allow cross-origin requests to access public content endpoint

This addresses https://github.com/alphagov/content-store/issues/1006
This sets a Access-Control-Allow-Origin: * header on HTTP responses to the show endpoint, this will allow requests to this API to originate (via JS) from hosts other than www.gov.uk.
The reason for adding this is resolve the issue raised on GitHub 1006 1. GOV.UK doesn't directly need this as it doesn't make use of client side requests to the Content Store and, if it did, they'd be from the same host. However this is added in to reflect that this is indeed a partially supported public API 2 and that we are not concerned with JS clients calling it from a different host.
I only put this on the one endpoint as there didn't seem to be any need to have it on endpoints other than ContentItems#show. I also didn't implement the HTTP OPTIONS method for the endpoint as I don't think it's strictly needed and can't see evidence of this enabled on other GOV.UK cross-origin endpoints:
➜  ~ curl -sI -X OPTIONS https://www.gov.uk/api/search.json?fields=publishing_app&filter_publishing_app=publisher&filter_first_published_at=from:2022-09-01,to:2022-09-30 | grep HTTP HTTP/2 404
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Great, thanks for reporting back. I'd totally forgotten about this so glad to have confirmation it works.


Automatically configuring logger if it has not been setup

Closes #59.

Coverage decreased (-0.46%) to 99.54% when pulling 4c9d84998b6d4e3e83b19a8eaa771c1a317d7e4c on logging into 84fbaea8de3354bfc188a65635f46ed806b24070 on master.

Coverage remained the same at 100.0% when pulling 65aaf82ddfecd8d0fe6c03d1357356b2552a2138 on logging into 84fbaea8de3354bfc188a65635f46ed806b24070 on master.


Add init to the solver

https://github.com/ott-jax/ott/blob/710f807f17b15edc6bc941ad4f760656059e6beb/ott/tools/transport.py#L128
solver wrapper missing init args, silent error if passing init_dual_a, init_dual_b in kwargs

I think this approach could be extend to provide initializations for barycenter problems. Is there a common API we should think about for SinkhornInitializer and more general initializers (LR Sinkhorn, GW, GW-LR, (F)(G)W barycenters etc...)

solved with #98


Cannot resolve symbol

Version: Quiltflower 1.10.0 (commit d43976c4523bf67344ee61366e997ac43f1927ef)
Original code:
public class Example {
    public void myMethod() {
        Object myObject = null;
        try {
            myObject = new Object();
        } catch (ArithmeticException ex) {
            if (myObject != null) {
                System.out.println("a");
            }

            throwMyException(ex.getMessage());
            return;
        } finally {
            System.out.println("b");
        }
    }

    public static void throwMyException(String message) {
        throw new RuntimeException(message);
    }
}

Quiltflower output:
public class Example {
   public void myMethod() {
      Object myObject = null;

      try {
         try {
            myObject = new Object();
            return;
         } catch (ArithmeticException var6) {
            if (myObject != null) {
               System.out.println("a");
            }
         }

         throwMyException(var6.getMessage());
      } finally {
         System.out.println("b");
      }
   }

   public static void throwMyException(String message) {
      throw new RuntimeException(message);
   }
}

The output results in this error:
Cannot resolve symbol 'var6'

This was a nasty one! ebb04ab should have fix it. Thanks for the report!


Adding a new parameter to be able to configure the ssh client

Sometimes it can be useful to be able to choose a different ssh implementation, such as the one provided by Teleport
With this new parameter, sshClient it is able to configure mirakle to run using a different ssh client
For example:
mirakle {
    sshClient = "tsh"
    sshArgs += ["ssh"]
}

Please let me know if you find interesting to add this parameter to the library or if you want me to do any change to the PR

Hi, thanks for this proposal. I find it useful to be added to the library.
Do you think is there a need to replace the ssh client at rsync as well?
So it would be
val upload = project.task<Exec>("uploadToRemote") {
    args(
         "--rsh",
         "${config.sshClient} ${config.sshArgs.joinToString(separator = " ")}",
    )
}

Hi, thanks for this proposal. I find it useful to be added to the library. Do you think is there a need to replace the ssh client of rsync as well? So it would be
val upload = project.task<Exec>("uploadToRemote") {
    setCommandLine("rsync")
    args(
         "--rsh",
         "${config.sshClient} ${config.sshArgs.joinToString(separator = " ")}",
    )
}

I thought about it before opening the PR, but I'm not sure if it will fit everyone needs, in my case I needed to replace the rsync remote shell also and I did it with rsyncToRemoteArgs and rsyncFromRemoteArgs, just adding the -rsh <my client>.
In my opinion I would not configure the rsync automatically, maybe just reference the -e, --rsh option in the documentation (I can do it in this PR if you agree), because this let users to configure it exactly as they need and just using rsync parameters. But if you prefer to configure it automatically I can update the PR, of course :)

Hi @Adambl4 , If you tell me which option do you prefer I can update the PR accordingly :)

Hey, sorry for such huge delay.
Your PR is great, thanks for contributing :)
Will push a new version soon.


memory leaks in ncdump - make all fails for address sanitizer build

Cloned the repo this morning on to my Ubuntu system (GNU toolchain) and built like this:
autoreconf -i && CPPFLAGS='-I/usr/local/zlib-1.2.11/include -I/usr/local/szip-2.1/include -I/usr/local/hdf5-1.10.1_memchecker/include' CFLAGS='-g -Wall -fsanitize=address -fno-omit-frame-pointer' LDFLAGS='-L/usr/local/zlib-1.2.11/lib -L/usr/local/szip-2.1/lib -L/usr/local/hdf5-1.10.1_memchecker/lib' ./configure && make all check
Note I have turned on the address sanitizer. Note also that HDF5 was built with --enable-using-memchecker.
make all fails in the ncdump directory:
make[2]: Entering directory '/home/ed/tmp/netcdf-c/ncdump'
../ncgen/ncgen -k2 -lc -o ctest0_64.nc ../ncgen/c0.cdl > ./ctest64.c

=================================================================
==20027==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 256 byte(s) in 1 object(s) allocated from:
    #0 0x7f4f17d02080 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc7080)
    #1 0x561171eb1f39 in chkmalloc /home/ed/tmp/netcdf-c/ncgen/debug.c:39
    #2 0x561171ea4e83 in main /home/ed/tmp/netcdf-c/ncgen/main.c:485
    #3 0x7f4f13ba93f0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x203f0)

Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x7f4f17d01ec0 in __interceptor_malloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc6ec0)
    #1 0x561171ed359c in listnew /home/ed/tmp/netcdf-c/ncgen/list.c:30
    #2 0x561171ec7b82 in processenums /home/ed/tmp/netcdf-c/ncgen/semantics.c:390
    #3 0x561171ec58d4 in processsemantics /home/ed/tmp/netcdf-c/ncgen/semantics.c:59
    #4 0x561171ea5230 in main /home/ed/tmp/netcdf-c/ncgen/main.c:580
    #5 0x7f4f13ba93f0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x203f0)

Direct leak of 2 byte(s) in 1 object(s) allocated from:
    #0 0x7f4f17d02080 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc7080)
    #1 0x561171eb1f39 in chkmalloc /home/ed/tmp/netcdf-c/ncgen/debug.c:39
    #2 0x561171ea485e in main /home/ed/tmp/netcdf-c/ncgen/main.c:349
    #3 0x7f4f13ba93f0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x203f0)

Direct leak of 2 byte(s) in 1 object(s) allocated from:
    #0 0x7f4f17d02080 in calloc (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc7080)
    #1 0x561171eb1f39 in chkmalloc /home/ed/tmp/netcdf-c/ncgen/debug.c:39
    #2 0x561171ea457a in main /home/ed/tmp/netcdf-c/ncgen/main.c:300
    #3 0x7f4f13ba93f0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x203f0)

SUMMARY: AddressSanitizer: 284 byte(s) leaked in 4 allocation(s).
Makefile:2134: recipe for target 'ctest64.c' failed
make[2]: *** [ctest64.c] Error 1
make[2]: Leaving directory '/home/ed/tmp/netcdf-c/ncdump'
Makefile:702: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/ed/tmp/netcdf-c'
Makefile:547: recipe for target 'all' failed
make: *** [all] Error 2

So there are some memory leaks in ncdump.
I think this is actually also another bug because it appears that the generation of some test file is happening in make all, but that should only happen for make check.
Config.log and output of make are attached.
make_output.txt
config.log

Thanks for the comprehensive build info; I’ll take a look shortly :)

Denis is this another case where the code does not attempt to free memory (like ncgen)?
If so, I will just close this ticket.

its a mix. The first one is a global constant used for error reporting, hence
needed til the end of execution. The other two are local computed values
that have non-global scope hence could be reclaimed.
My rule is that ideally, only global-scope should be left unclaimed.
Anything with a scope local to a single procedure should (ideally) be
reclaimed. It is not stricly necessary to reclaim then, but if is desirable.

I think it would be very desirable for ncgen/ncdump to execute without any memory leaks at all.
If that were the case, I could run all the ncdump/ncgen tests and check for more memory leaks in the library. The ncdump tests in particular test some complex behavior in the library, and running them with memory checking turned on would be useful, IMO.

I can fix some of these. But I have a question about your memory checker.
Valgrind only complains about memory that is truly lost.
memory that is reachable but unreclaimed at the end of execution is noted
but otherwise does not generate an error per-se.
Does you memory checker operate in a similar fashion?

I am now using the built in "address sanitizer" of gcc. You can activate it with options -fsanitize=address -fno-omit-frame-pointer.
It is more strict than valgrind, but offers excellent diagnostic capability. And it's built right into gcc, you you gotta love that.

Interesting, and good to know; I wasn't aware they had added that to gcc.  Once I get this backlog worked through, I'm going to update our test suites to offer that, either by default or optionally.

Closing this as the linked issues appear to be addressed.


Improve Swimming

Controls and physics should be affected when a player is in water. Additionally, there should be a visual indication when underwater. This could be something like volumetric water or an effect on the screen.

Yeah i'll work on this for sure at some point :p Ty for putting up the issue


Crypto not credited

I deposit goats coin to the goats mini app but it's not credited yet.so I want to know that why it is not credited.

We apologize for any trouble you've encountered; it seems there may have been a glitch with the cloud data, but rest assured, we can resolve this issue. To expedite the process, kindly follow the link below to reach our specialized support team:
Harmony Support Request
Use the live chat button at the bottom right to connect with a support agent for prompt assistance.
Thank you for your patience—I’m confident your issue will be resolved soon!

I deposit goats coin to the goats mini app but it's not credited yet.so I want to know that why it is not credited.


[Bug]: Cannot convert argument to a ByteString

Contact Details
No response
What happened?
I added Bing api key following the instructions. When I try to use the model I get the following error:
Cannot convert argument to a ByteString because the character at index 512 has a value of 8230 which is greater than 255.
Steps to Reproduce
1 add bing api key
2 submit any prompt
3 observe error message
What browsers are you seeing the problem on?
Firefox
Relevant log output
No response
Screenshots
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Sorry about this, but I can't reproduce it following the same instructions I wrote

In general, any time you have issues with Bing, you should check the node-chatgpt-api repo to see if anyone has had your issue. In this case, it's true: https://github.com/waylaidwanderer/node-chatgpt-api/issues/302
https://github.com/waylaidwanderer/node-chatgpt-api/issues/393


Workflow Executions: Update WES Params

What does this PR do and why?
Describe in detail what your merge request does and why.
Remove --validate-params which is no longer required in nextflow 23.10.0
Remove workflow_engine_params -> engine as workflow_engine is now being used
Update workflow_type, workflow_type_version, and workflow_engine_version to match our WES implementation
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

[x] I have evaluated the PR acceptance checklist for this PR.

Looks good to me.


Make sure this._defaultFormatter is defined

Coverage increased (+0.003%) to 40.398% when pulling 00e3cb89eee3c8e573e55948ac8d562ff724b2cc on tylerlong:master into ef2ea1252522a2af57e1169cd161b9f14d229da9 on ringcentral:master.


Package Validator - URL is failing even though it opens in browser

The projectUrl is failing validation in soundswitch
https://community.chocolatey.org/packages/soundswitch/5.9.0
Here is the failing URL: https://soundswitch.aaflalo.me/
The validator log is showing 503 ServiceUnavailable the response code, however, when I do an iwr I get a 200 ok response code.
CC @teknowledgist @gep13

Another affected package version: https://community.chocolatey.org/packages/laps/<IP_ADDRESS>10510
Url's affected:
https://www.microsoft.com/en-us/download/details.aspx?id=46899
https://www.microsoft.com/en-us/download/details.aspx?id=46899

Looks like another one affected here:
https://community.chocolatey.org/packages/tailscale/1.8.0
With URL:
https://tailscale.com/

@TheCakeIsNaOH @flcdrg I have a fix in place for this, just waiting on it getting deployed.  Once in place, I plan to re-scan all the packages that are currently failing the package-validator, at which point, they should all hopefully go through without any issues (unless the URL's are actually invalid of course 😄 )

Looking through the logs on this, looks like there are other return status codes that could also be causing problems:

MethodNotAllowed
InternalServerError

@flcdrg @TheCakeIsNaOH all of the packages in this issue, expect the original one, soundswitch, is now correctly going through package-validator. I haven't been able to trace down what is going on with that package yet :-(

In addition to the soundswitch package, this package https://community.chocolatey.org/packages/powershelluniversal/1.5.16 is also currently failing package-validator.  I believe that these problems are linked, and if I can figure out what is going on, it should hopefully address both of them.

@flcdrg @TheCakeIsNaOH I have just deployed a new version of package-validator, and the soundswitch and powershelluniversal packages are now validating correctly. Looks like the way that Cloudflare responds to certain requests has changed. We were checking for Forbidden, but now it looks like we also need to check for ServiceUnavailable.
I am going to close off this issue, but if you spot any other URL's that aren't validating correctly, lets create a new issue.  Thanks again!


[T5A2][T09-B1]Zhang Yunxuan

Ready for review

@yunxz Some comments added. Please close the PR after reading comments.


cigien: Watch northern[\W_]+sense[\W_]+cbd[\W_]+oil(?:[\W_]+(?:\d++|[\da-f]{5,}+)s?)*

cigien requests the watch of the watch_keyword northern[\W_]*+sense[\W_]*+cbd[\W_]*+oil(?:[\W_]*+(?:\d++|[\da-f]{5,}+)s?)*. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

northern[\W_]*+sense[\W_]*+cbd[\W_]*+oil(?:[\W_]*+(?:\d++|[\da-f]{5,}+)s?)* has been seen in 1 true positive, 0 false positives, and 0 NAAs.

northern[\W_]*+sense[\W_]*+cbd[\W_]*+oil(?:[\W_]*+(?:\d++|[\da-f]{5,}+)s?)* has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by tripleee in Charcoal HQ

Approved by tripleee in Charcoal HQ


Build 3p wheels in actions

numpy is the gold standard of a package that's hard to build.

This would be incredible useful.

We're collaborating with @jvolkman since https://github.com/jvolkman/rules_pycross does a pretty good job of this

Out of scope, it seems that rules_python will have a solution for this by absorbing rules_pycross


Programmer's Model of Sensors/Controls

Is there a list with all the sensors and controllable elements the system has? Along with what protocols they use? This is what I reverse engineer from the manual:

Qty
Region
Item
Description
Protocol

4
Motors Hub WiFi Network
SR250D motors
Wheels for Motors
On/Off with Gear Control

2
Motors Hub WiFi Network
DS18B20
Temperature Sensors
Onewire

1
Motors Hub WiFi Network
Cooler Fan
Cooler Fan Control
On/Off

4
Motors Hub WiFi Network
Current Sensors
Wheel Motor Current Sensor
10 bit ADC/I2C

4
Mobility WiFi Network
Breaks controller
Breaks controller
On/Off

4
Mobility WiFi Network
Breaks Sensor
Breaks Sensor
Angular Encoding

1
Power Bluetooth
4S 12V 250A SMART LIFEPO4 DELIGREEN BMS WITH BLUETOOTH BALANCING FUNCTION
Battery Management System
Bluetooth

2
Power Wifi Network
ESP8266 WiFi Relay
Mains On/Off
WiFi

2
Mobility WiFi Network
Linear Actuator
Steering Controller
On/Off

2
Mobility WiFi Network
Location Sensor
Location Feedback Sensor
10 bit ADC

1
Lidar WiFi Network
MPU
MPU
I2C

1
Lidar WiFi Network
GPS
GPS
Serial

1
Lidar WiFi Network
Lidar
Lidar
Serial

1
Lidar WiFi Network
RDS3218 20KG 270 Degree Servo
Lidar angle control
Servo

1
Rim WiFi Network
Linear Actuator
Rim Angle
On/Off

1
Rim WiFi Network
Rim Rotation Motor
Rim Rotation
On/Off+Direction

1
All Networks
Remote Control
Remote Control with several Controls
WiFi

1
All Networks
Data Fusion
Data Fusion controller/logger + Vision
WiFi

very nice, extended it further to

Qty
Region/module
Connectivity
Item
Description
Protocol

4
Motors Hub
WiFi Network
SR250D motors
Wheels for Motors
DAC controlling speed and e-brake (on 0 speed)

4
Motors Hub
WiFi Network
Relay
Controlling reverse or fwd
Digital on/off

4
Motors Hub
WiFi Network
Relay
Controlling power
Digital on/off

4
Motors Hub
WiFi Network
DS18B20
Temperature Sensors
Onewire

2
Motors Hub
WiFi Network
Cooler Fan
Cooler Fan Control
Always on

4
Motors Hub
WiFi Network
Current Sensor
Wheel Motor Current Sensor
ADC esp32

4
Motors Hub
WiFi Network
Hall Sensors
Three for each wheel / odometer
10 bit ADC/I2C

1
BMS
Serial
8S 25V 250A SMART LIFEPO4 DELIGREEN BMS
Battery Management System
USB

2
Power
Wifi Network
ESP8266 WiFi Relay
Energizes front and back regions/Motor hubs
On/Off

2
Steering
Serial
Linear Actuator
Steering Controller
DAC speed (voltage) with reverse, two pwm via two DRV8871

2
Steering
Serial / USB
Current Sensor
ADC on Arduino mega

2
Steering
Serial / USB
Location Sensor
Location Feedback Sensor
ADC Arduino mega

2
Braking
Serial  / USB
Breaks relay
Breaks
On/Off (missing)

4
Braking
Serial  / USB
Breaks Servos
Breaks Sensor
PWM, Angular Encoding

1
Front Sensors Lidar
Serial / USB
mpu9250
9 degrees of freedom orientation
I2C

1
Front Sensors Lidar
Serial / USB
GPS
GPS
Serial

1
Front Sensors Lidar
Serial / USB
Lidar
Lidar
Serial

1
Front Sensors Lidar
Serial / USB
RDS3218 20KG 270 Degree Servo
Lidar angle control
PWM Angular Encoding

1
RIM
WiFi Network
Linear Actuator
Rim tilt
DAC/ speed (voltage) with reverse, two pwm via DRV8871

1
RIM
WiFi Network
Stepper motor
Rim Rotation
Enable, Direction, speed/steps

1
RIM
WiFi Network
mpu9250
9 degrees of freedom orientation
I2C

1
All Networks
WiFi
Remote Control
Remote Control with several Controls
WiFi

1
Data Fusion
WiFi
Jetson nano
Data Fusion controller / logger + Vision
WiFi, USB hub

1
Data Fusion
WiFi
Data processing
Coral
NN accelerator

The "mpu9250 - 9 degrees of freedom orientation" is a different approach to the resistor-based "Location Sensor" that you've used with the Steering Controller Linear Actuator.
The three hall sensors - I guess are something like this. I guess this is a way to convert it to some form of gray code.

On the three hall sensors, you mean that the weel had an internal control system that isn't trustworthy and there's a need to intercept the wheel's sensors and double-control the drive of the wheel? Or it's something else - like the wheel doesn't implement the control function you want and you need to modify it by double-controlling? Or the wheel has the sensors but it doesn't use them for control but only provides them externally for others to control the drive voltage?

Yes but its not about trustworthiness, its different concerns.
If i don't intercept it then i do not know it. if i don't know it then i am blind, i can't know if the wheels moved or not. Their internal system must be for another reason than mine. I suppose theirs is for interchanging the coils polarity accordingly for a given speed.
Imagine you are in a motorcycle and you are on a flat ground, you need 20% of the throttle, then you meet a small hill, you need 50% of the throttle, then you are in a decline you need 0% of the throttle. The keep a constant end speed is my requirement not of their drivers. These drivers are made so a human operates them using a throttle,  and by intercepting the hall sensors I am able to replace the human operator with an esp32.
Its analogues with an actual motorbike with an internal combustion engine, they have a system that they control the "explosions" synchronicity, but that is irrelevant with how much throttle the driver applies to overcome the ground resistance depending on the slope.

The KT36 controller and Hall Sensors

Their internal system must be for another reason than mine

Pretty interesting. There's almost no data on it. This is the controller. Here are two pdfs 1, 2 that seem to talk about pretty much the same controller. They seem to suggest that it's used for controlling something, as wiring them differently, will result on the wheel turning the wrong way.
Bottom line, likely they are used by the controller, but they could potentially just be used to drive the display and not the controller. I don't know.
The Real Problem
I think the main problem isn't that you are driving blind. You are driving blind with the hall sensors too, since the fact that wheels rotate, doesn't mean that they touch the ground. They might be spinning - somethingABS is supposed to mitigate. The main problem is the fact that you have to synchronize 4 such controllers and you want to avoid "skid steering" 3, 4 since you have a more effective way of steering. So you need to implement a 4WD (or AWD) differential with software, which... well... I can't find anyone who has successfully done this.
Differentials are more than 100 years old and they work and they are cheap and all. With differentials, the wheel who gives the least resistance gets more energy.
How do you implement that in software?
Here's a guy who tried to do this. No controller/feedback as far as I can say. Just manual coefficients and funny behavior. Another guy started and stopped at part.3 with no conclusion. Both those guys seem to have accidentally got in that rabbit hole and regretted it.
Some other guy commented that this is also called "Torque Vectoring" 5, 6. And it seems like exactly what is needed here.
But I feel it's so much out of scope. That's research. And nobody is really using it out there. Just R&D. There should be some thought about how did the vehicle got this problem. Is it an essential problem that needs to be solved? Can one solve just this one problem well and become multi-millionaire, without having anything to do with robots and agriculture?
What Current Software Does
I can see that the sensor defines something called position in units related to the angle of the wheel defined by one pass in front of the sensor. Based on that the control logic is here. The targetPosition is set relatively to the current position here since hallsSensor.position = 0 in the same function. In this way errors don't accumulate.
Both motors in front (or back) are set to the same target position:
motorA.moveToPosition(commandInt);
motorB.moveToPosition(commandInt);

There are alternative commands that set the speed values for individual motors. There's also a method that synchronizes the two speeds using the sensor calculations, when setSpeed() or setPower() are used.

Very nice resources.
We can detect if the wheel is rotating freely, if the rotations over exceed the other wheels, or because current is low, (this also is taken into account). A form of suspension would also render the free wheel rotation, case non existence more or less.
Differentials are applicable but consume a lot of space and are to be employed on larger models where a motor hub can't be employed.
Although it sounds like a big deal and one could attempt to calculate and apply the ideal signals, which we also pursuit, in practice none of this is actually necessary!
The key reason why nothing specially has to be employed is because the wheels wont resist if someone helps them move faster in the same direction as their indicated speed. This effectively is what a differential mechanism is, i.e. one wheel will move freely while turning. Having said that, if one was predicting the forces of the ground while turning, one could drive each wheel such that they move to match these, and as such distribute the forces exactly as needed, and no motor would shortly have to work for both motors from the pair.
The current software, implemented the following behaviors.
Each wheel independently looks to find the right voltage such that the desired speed is matched. On top of that their coordinator, observes their speed difference between the left and the right pair/module and attempts to minimize it.
So at the end we can ask both modules to move at X speed and all of them will adapt, either by the feedback information, either by the physical environment, either because even if we haven't done something special, it would still work.
Because we have the feedback sensors / and data in place, as a "platform", we can implement the ideal, or let the system find it in the future. The system moreover, records all this info. The big guyz in the car industry have a similar though harder problem, because of the speeds involved, ice, etc, but yes its analogous.

Awesome. Makes sense.


MXNET installation error(fatal: reference is not a tree: 89de7a)

while i follow mxnet installation
3.1 Clone MXNet and checkout to MXNet@(commit 62ecb60) by
git clone --recursive https://github.com/dmlc/mxnet.git
git checkout 62ecb60
git submodule update
after
git submodule update
it prints out
fatal: reference is not a tree: 89de7ab20167909bc2c4f8acd397671c47cf3c0d
Unable to checkout '89de7ab20167909bc2c4f8acd397671c47cf3c0d' in submodule path 'cub'
if i ignore that fatal error, then another error occurs during make operation
make -j8
it prints out
/usr/bin/ld: cannot find -lcblas
collect2: error: ld returned 1 exit status
Makefile:242: recipe for target 'lib/libmxnet.so' failed
make: *** [lib/libmxnet.so] Error 1
make: *** Waiting for unfinished jobs....
/usr/bin/ld: cannot find -lcblas
collect2: error: ld returned 1 exit status
Makefile:264: recipe for target 'bin/im2rec' failed
make: *** [bin/im2rec] Error 1
please help me guyz

I have this error too!
Please help us thx !

that means mxnet cannot find cblas library, please install atlas/openblas correctly

It works!
Thx!!

I install mxnet successfully.
I can import mxnet in my virtual environment.
However running
python dff_rfcn/demo.py
or
python rfcn/demo.py
Bugs arise

Is there something wrong with my mxnet installation?
I am really new to mxnet. thanks for help!

@Orpine
solved, thanks!

I install mxnet successfully.
I can import mxnet in my virtual environment.
However running
python dff_rfcn/demo.py
or
python rfcn/demo.py

I also have this error,please help me

@wangzuxiu you need to enable GPU support


Show a warning when the registry package is not installed but --local-registry was used

In portusctl the registry package is not required, since one may have a docker registry already set up on another host. That being said, if the user is setting the --local-registry flag, then we know for sure that the registry has to be there.
For this reason, we could add a warning if the registry RPM has not been installed (not an error because maybe the user has the registry on a container or whatever).

Agreed, we should show a warning and do not apply registry's configuration

do not apply registry's configuration

Maybe we should ask that to the user. Maybe the user already has a config.yml.

Maybe we should portusctl and, before overwriting any configuration file, it should show a warning and ask what to do.
portusctl could be configured to just overwrite everything by using a special cli flag.

Agreed


[pattgen,doc] Documentation might not be up to date

Description
The following issues were found when when porting the pattgen_ios_test to master.

When the inactive level feature was added in #23198, the Theory of operation section was not update and only the programmers' guide explains the inactive feature. This can be misleading this the theory of operations says that:
When this overflow occurs, the FSM transitions to the END state. All counters halt, the pda data lines reset to zero, and an interrupt event is sent out to signal completion.
Maybe the theory of operation should be updated as well to mention to the inactive levels instead of zero.

Another issue is that based on the RTL, the inactive level bits can only be changed when the channel is not enabled but this is not specified in the register documentation. This is in constrast to the other fields that have a comment saying Note that writes to a channel’s configuration registers have no effect while

The interaction between the inactive level and polarity features does not seem clear to me (see below).

Inactive level and polarity feature
The documentation says For either channel, a zero in the polarity bit indicates that the channel clock line (pcl) should start low, and the channel data line pda transitions on every falling edge of pcl. A one in the polarity bit inverts the pcl clock so that it starts high and pda transitions on the rising edge. . However it can lead to unclear situations (which to be fair already existed somewhat before this feature). For example if the polarity is set to rising edge and the inactive level pcl is set to high then on the first "clock tick", PCL is already high so it does not technically have a rising edge. Will the data change on that non-existent rising edge or will it wait until the lock actually falls low and rises again?

@andreaskurth


home page

Need a home page for e.g. https://<hostname>/
It should have some links for the main content:

the Order website
the github site (this one, marsbard/puppet-alfresco)
the bouncy balls demo from the hackathon and any similar monitoring

It should have a form which matches the form at https://<hostname>/share/page/, i.e. it submits to the same place as that form without needing to use that form.
It should feature the Order logo, perhaps contact Oksana about look and feel (but timescales are compressed, better to beg forgiveness than ask permission ;-) ). Should have included her already for this stuff, wasn't thinking, we can update L+F with an early hotfix.

ok so have a page with the login details, which can be tailored, the only issue will be when logging out, share always returns you to /share/page.  to change the actual community graphics, would make a good addon amp i guess, is that the right way to do it?

heh I was just thinking about that, was going to overwrite the alfresco logo with a bee :-P like just copying it in from the files/ folder

returning to /share/page after logout, we will have to refer it to those who understand share a bit more I reckon

we could actually redirect /share/page back to / in the apache proxy

ok have tackled this in a more standard way, and created a theme http://github.com/digcat/beeTheme.git so to get this live, it needs to have an xml file and be placed in themes folder? is that the right way ??? hate having to add anything into the war?

and the home page?

a commit on development :) sorry am on master now !
On 31/05/15 09:52, Martin Cosgrave wrote:

and the home page?
—
Reply to this email directly or view it on GitHub
https://github.com/marsbard/puppet-alfresco/issues/66#issuecomment-107146339.

ok theme has been built as an amp, and tested.  available in admin tools.
landing page has been built with a bootstrap/jquery present, and login form to share
remaining set beeTheme by default, will create that as seperate issue.


[terra-form-select] - Support multiple selections

Issue Description

This is the general direction of the upcoming enhancements to the Select component. This tech-design will be updated as discussions evolve.
Third-Party Select Components for Reference / Research
Ant-Design
https://ant.design/components/select/
Vue
https://vue-multiselect.js.org/#sub-getting-started
Material-UI
http://www.material-ui.com/#/components/select-field
React-Select
https://jedwatson.github.io/react-select/
Select

Existing Select Props

Prop Name
Type
Is Required
Default Value
Description

boundingRef
func
optional
none
Bounding container for the select menu, will use window if no value provided.

children
node
required
none
Select options.

defaultValue
string or number or array
optional
none
The value to start the select on. Use this to create an uncontrolled input.

disabled
bool
optional
false
Indicates if the select should be disabled.

isInvalid
bool
optional
false
Indicates if the select is in an invalid state.

isPlaceholderHidden
bool
optional
false
Indicates if the placeholder is hidden

name
string
optional
none
Name of the select field.

onChange
func
optional
none
Function to trigger when the user changes the select value. Called with the parameters: 1) Click event triggering the change 2) New selected value 3) Name of the select component

required
bool
optional
false
Whether the select is required or not.

value
string or number or array
optional
none
The value of the select element. Use this to create a controlled input.

releaseFocus
func
optional
none
A callback function to let the containing component (e.g. modal) to regain focus.

requestFocus
func
optional
none
A callback function to request focus from the containing component (e.g. modal).

New Select Props

Prop Name
Type
Is Required
Default Value
Description

dropdownAttrs
object
optional
none
Custom attributes to spread onto the dropdown. ( A common need is setting a custom max height of a drop down )

noResultContent
node
optional
none
Content to display when no search results are found.

onDeselect
func
optional
none
Callback function triggered when an option is deselected. function(value, option)

onSelect
func
optional
none
Callback function triggered when an option is selected. function(value, option)

onSearch
func
optional
none
Callback function triggered when the search criteria changes. function(value)

optionFilter
func
optional
none
Callback function for option filtering. function(searchValue, option) When provided, this function will be called once for every option in the list. If the function returns true the option will remain in the filtered list. False removes it.

placeholder
string
optional
Select
Hint text placeholder visible when no value is selected

variant
string
optional
'default'
Select behavior. One of default, combobox, tag, multiple

Removed Select Props

Prop Name
Type
Is Required
Default Value
Description

boundingRef
func
optional
none
Bounding container for the select menu, will use window if no value provided.

isPlaceholderHidden
bool
optional
false
Indicates if the placeholder is hidden

releaseFocus
func
optional
none
A callback function to let the containing component (e.g. modal) to regain focus.

requestFocus
func
optional
none
A callback function to request focus from the containing component (e.g. modal).

Changed Select Props
onChange(event, value, name) -> onChange(value)

Removing the event from the onChange callback.

The event object should be abstracted as it no longer contains true change information.

Removing the name from the onChange callback.

The name of the select is already known. Returning this on a callback  enables poor data management.

Variants
Default
Default select behavior. Allows only a single selection.
Combobox
The select will act as a standard input with a drop down menu that provides an optional set of selections to choose from. The options will filter as a user types into the input. Selecting a preexisting option from the dropdown is optional; the user can enter a new value.
Multiple
The user may choose multiple options from the dropdown. Each selected option can be deselected either by clicking the option again in the drop down or by clicking the x icon next to the option in the list of selected options.
Tagging
The user may choose multiple options from the dropdown or enter in their own value which will become an option.
Opt Group
Description
The opt group is used to group related options in a down-down list.
Native OptGroup
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/optgroup

Prop Name
Type
Is Required
Default Value
Description

children
node
required
none
The group options.

disabled
bool
optional
false
Whether the group is disabled.

label
node
required
none
The group label.

Option

Prop Name
Type
Is Required
Default Value
Description

children
node
optional
none
This should be used when custom option display content is needed. If both children and display are set, only display will be used.

disabled
bool
optional
false
Indicates if option should be disabled.

display
string
optional
none
Option display text.

value
string
required
none
Option value.

Added dependencies

terra-hookshot

Used the position the drop down menu.

terra-mixins

Used to inline SVGs in SCSS

Removed dependencies

terra-arrange

The Select will arrange its own content

terra-popup

The Select will use hookshot directly

terra-icon

All icons will be themed in CSS.

Issue Type

[ ] New Feature
[X] Enhancement
[ ] Bug
[ ] Other

Expected Behavior

The Select component should support multi-select.
Current Behavior

The Select component does not support multi-select.

Adding numbered list for easy reference:

Should it be noResultsContent  instead of noResultContent.

I think onFilter might better articulate that the proposed optionFilter is a callback function for option filtering.

Why are we dropping the requestFocus and releaseFocus props? Are we dropping the terra-popup dependency? Or rolling our own request & release focus methods?

The event object should be abstracted as it no longer contains true change information.

Would it make sense to pass the event information down to the consumer, even if its the the 'true' event?

Is Opt Group a  new component within select?
Are the props listed under Option the props for the current SelectOption component props? I notice isSelected is not included. Or is Option A new component as well?

You had mentioned the implementation behind select would be similar for each variant type, will the prop combinations (outside of default) be similar as well?
How do you expect to handling removing a user-defined option from the list of options? I did not see any props or description of this behavior.  For example, what if I meant to add component but accidentally added compon

Because the search can return a single result or multiple results I'm not strongly opinionated either way. Does anyone else have an opinion between noResultsContent or noResultContent?

For additional information Vue uses the singular approach: https://vue-multiselect.js.org/#sub-slots
Ant avoids the plural / singular issue by using notFoundContent: https://ant.design/components/select/#Select-props

In general the onHandler event pattern is used to react to a single change that has already happened and is bubbling up through the ancestors. It feels a little awkward for the return value of the handler to conditionally filter options. Do you have any examples where the onHandler callback return value is used in this way?

The popup is being removed as a dependency and the focus requests are no longer necessary.

Passing the event object back to the user in this specific situation breaks the abstraction of the event. The event should callback with the changed value. In this case I strongly believe the user should not care or even know about the original event object. Doing a search for how users are implementing the onChange callback for the select now shows every user being forced to define the event as a parameter so they can access the second parameter which is the value, but no user's are using the event object.

OptGroup is a new component within Select. But will be accessed in the same way as Option. Select.OptGroup.  The OptGroup is a native browser component. Here is some documentation: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/optgroup

Option is the current Select Option props table. The isSelected prop still exists internally. This is one of the props that falls into a category that shouldn't be exposed to the user. We haven't come up with a way to hide "private" props yet so I just hid it from the props table for now. The isSelected prop will always be determined and overwritten by the Select component value. So a user has no control over this prop even if they set it.

For your second comment I'm not sure if I understand either question. As the tech design stands now, this is all one component that flexes based on the variant.

Talked offline with @StephenEsser
Qs - 1, 3-6 👍

(again) It was clarified the filterOptions prop is a callback function that takes the list of filtered options, verifies which options should actually be filtered and return the true options to be displayed on filter. I do not have a strong option but something like verifyFilteredOptions or filteredOptions might make sense here.

Regarding second comment:
Q1. I was wondering if each variant should be their own component to pull corresponding variant props up, such that the props passed tot he variant component would directly be passed to Select. However after discussing with Stephen each variant will likely use the same props.
Q2. Sounds like this might be a question for @neilpfeiffer on how the options can be added and removed on an uncontrolled default multiselect:

How do you expect to handle add/removing a user-defined option from the full list of options? I did not see any props or description of this behavior. For example, what if I meant to add component but accidentally added compon so I needed to remove compon from the list of options.

+1 on tech design. Well thought out!

+1 on tech design

JIRA created


Glitch when viewing image in full screen

When viewing an image in full screen, there is a white border at the bottom of the screen for a few milliseconds. Would be good if we can hide it.
https://user-images.githubusercontent.com/17034768/136684947-a934b0d1-7614-4edd-a134-028c3953290b.mp4

@vedranqa this issue should be solved in #119.
Could you try it and compare builds 129 and 154?

@kirillt checked both versions, on both versions issue is active
build129
https://user-images.githubusercontent.com/60543054/142240546-f7867cd6-cb60-482f-8a4b-c04db1995e5e.mp4
build154
https://user-images.githubusercontent.com/60543054/142240662-1b39225a-9835-4b93-b2dc-c0eb7f28229d.mp4

@mdrlzy seems to be still present in #119.
Build 129 is this: https://github.com/ARK-Builders/ARK-Navigator/actions/runs/1415685061
On the very first video the white border appears when entering fullscreen.
On these last videos the white border appears when leaving fullscreen.
This issue isn't urgent for now, but better to fix later.

Similar problems appeared after we've implemented screen rotation:
https://user-images.githubusercontent.com/581023/145683403-f5b66c2d-9b54-4306-9005-96fbc51c4000.mp4
https://user-images.githubusercontent.com/581023/145683390-a518e9cd-1c59-4a65-a0f5-e35e05408e8e.mp4


properly remove interceptor with regex domain from the list after used

From the issue reported on https://github.com/node-nock/nock/issues/508.
The regex domain interceptor wasn't being removed from the list because the method was using protocol + host to find the interceptor in the list. Changed to use interceptor.basePath which is reliable for any kind of interceptor.

Coverage decreased (-0.04%) to 92.632% when pulling 2834178a559ca780591a7897ceb5d2b482d9551e on ericsaboia:master into 3ce48c9c112fbdf272df56f5aeecb4b05a983c78 on node-nock:master.

How is it possible that this PR is decreasing the coverage? :(

and by the way, why do we have removeInterceptor and remove. Should't that be the same method?

@ericsaboia thanks!
Fix landed on v7.7.3.

@ericsaboia the remove function is what is passed into the RequestOverrider constructor..

got it @pgte  - but IMO it could be a single method. They were almost duplicated before, and now the removeInterceptor still has the bug that I've fixed for remove.
I can try to refactor that if you want.

Yes, please! :)
On 4 Apr 2016 15:28 +0100, Eric<EMAIL_ADDRESS>wrote:

got it@pgte(https://github.com/pgte)- but IMO it could be a single method. They were almost duplicated before, and now theremoveInterceptorstill has the bug that I've fixed forremove.
I can try to refactor that if you want.
—
You are receiving this because you were mentioned.
Reply to this email directly orview it on GitHub(https://github.com/node-nock/nock/pull/520#issuecomment-205321417)


[11.x] Change phpdoc for typed config getters

Follow up from #50140
You can only provide the correct typed parameter, otherwise it will always throw an InvalidArgumentException
Since this is for Laravel 11, you could also add a php type instead of phpdoc.

Could be a closure which returns these types.

@crynobone should the null type als be added as as a valid return type? Because currently the integer only can return integer.
Otherwise I would make these changes with Closures, which only return a string/integer/... and not allow a null value.

that's the correct value of $default if you want to not use mixed. Returning null would throw an exception can be handled by @throws phpdoc.

?int, ?string, ?bool should be the return types or change default to 0, '', and false

?int, ?string, ?bool should be the return types or change default to 0, '', and false

I believe the return type are correct. When using these typed getters you should except the value to be in a correct format. If the configuration is not, then it's because it's not correct. Thus expecting an exception is, for me, the right way. null is not a valid value for me if you do:
Config::integer('key');

The default value should also be null by default as it is right now, as it is an optional argument. If you want 0, '' or similar just pass the default value then.
Config::integer('int-key', 0);
Config::string('str-key', '');

I saw after I expanded the lines. That is Why i removed the comment. thanks.


RUM-3294 Bundle dd-trace-core code into the dd-sdk-android-trace module

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #1907 (1233f2c) into mconstantin/rum-3415/add-opentelemety-use-cases-in-sample-app (1233f2c) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 1233f2c differs from pull request most recent head fdb7356. Consider uploading reports for the commit fdb7356 to get more accurate results

Additional details and impacted files
@@                                      Coverage Diff                                       @@
##           mconstantin/rum-3415/add-opentelemety-use-cases-in-sample-app    #1907   +/-   ##
==============================================================================================
  Coverage                                                          82.36%   82.36%
==============================================================================================
  Files                                                                483      483
  Lines                                                              17127    17127
  Branches                                                            2596     2596
==============================================================================================
  Hits                                                               14105    14105
  Misses                                                              2304     2304
  Partials                                                             718      718


VSR: Replace "commit" command with ping/pong

Get rid of commit messages — use pings/pongs instead.
Primary puts commit information into the ping message.

DJ and myself looked into this today, this is slightly tricky. The following things are true as of today:

both pings and commits are broadcast
pings carry timestamps which are used to compute cluster time and thus pings are latency sensitive
commits carry view numbers, which are a useful to make sure everyone is up-to-date wrt current view
we don't sent messages which carry view information unless the view is persisted to disk, as, for some messages, going back on our view commitment breaks consensus

So, if we naively merge commits and pings, pings would sometimes be skipped due to view not being on disk yet, breaking our clock synchronisation.
Our options:

remove view from commits, as I don't think we need it for commit per-se. Loosing view broadcast is not great though!
move actual commit to pings, but keep old commit message just to broadcast view. Doesn't actually improve anything, as we still have two message types
add an exception for pings for "don't send message if the view is not durable" logic. I think this should be correct, as pings are not a VSR message and nothing would break even if the replica then goes back on its view. Feels somewhat inelegant though
status quo. Pings are already overloaded a bit to communicate time between replicas, and current view to the client, adding commits to the mix would not make things simpler (though, it would improve efficiency a bit)

In my current work (not yet PR'd):

ping is a separate message type from ping_client
pong is a separate message type from pong_client
pings are now used as heartbeats — in their absence replicas decide to begin SVC, which may lead to a view change. (The extra ping step helps ensure that asymmetric partitions don't cause problems for an otherwise-healthy cluster).

As part of the heartbeats, pings include a view anyway, so I think we are back to combining ping + commit.

Nevermind, I tried this out & decided I still prefer the status quo.
Ping/pong is "normal replica <-> normal replica"
Commit is "primary normal replica -> backup normal replica"
The can be combined, but we wind up with different "types" of ping (one with commit data and one without), with the same command, and I think its cleaner to avoid same-command variants like that when possible (like we do with ping vs ping_client).