TypeError: fragments is undefined

I've been trying (and trying and trying) to get a mutation+updateQuery combination to work, and I'm encountering unexpected issues. I've been following the example provided in the apollo-client doc ("Updating query results with updateQueries").
This is a React application where a logged-in user can save and retrieve bookmarks, which are simple objects with a few scalar properties. I have a BookmarkMenu component that shows the user's bookmarks as a list. A separate component (GraphViewer) has a button allowing them to save a new one. The query for the list goes through fine, but the mutation throws 'TypeError: fragments is undefined' and then every further action gets 'Interrupted by an error up the chain'.
I've put the various parts of my code below. I've read through all the doc and issues I can find, and I've tried everything I can think of, including providing empty objects/arrays in the fragments param. But nothing has worked. I am not even sure why fragments are getting involved here (they're apparently not needed in the documentation example I'm following), so maybe that's where I'm going wrong. Can you help?
The gory details (error message is at the bottom):
My setup is based on react-apollo-starter-kit. Here's the client instantiation:
const ApolloApiClient = new ApolloClient({
  networkInterface,
  shouldBatch: true,
  dataIdFromObject: (obj) => obj.uuid
});

Here is the query I'm using in the bookmark menu:
    bookmarks:
    {
        query: graphql[tick]
          query getUserBookmarks($userId: String!) {
            user (userId:$userId) {
              uuid
              bookmarks {
                uuid
                [... other properties]
              }
            }
          }
        [tick],
        variables: {
          userId: state.auth.user.userId
        },
        forceFetch: false,
        returnPartialData: true,
      }

When I submit this query in my GraphiQL server, it returns this:
{
  "data": {
    "user": {
      "uuid": "ba88e490-4e07-...",
      "bookmarks": [
        { "uuid": "933d9670-5761-...", [other properties] },
        { "uuid": "964337c0-56d1-...", [other properties] },
        [...more bookmarks]
      ]}}}

This displays correctly in my React app (i.e. the list renders). The store shows:
apollo:
  data:
    [an entry for each bookmark]
    "ba88e490-4e07-...": {
      "uuid": "ba88e490-4e07-..."
      "bookmarks" [an entry for each bookmark]
    }

So far so good (I think). Now I want to add a bookmark and have it appear in the UI menu, preferably with optimistic rendering but definitely upon server response. Here's my mutation:
saveBookmark: ([bookmark properties]) => ({
  mutation: graphql[tick]
    mutation createBookmark(
      $createdBy: String!
      [...other bookmark properties]
    ) {
      createBookmark(
        createdBy: $createdBy
        [...other bookmark properties]
      ) {
        uuid
        [...other bookmark properties]
      }
    }
  [tick],
  variables: {
    createdBy: state.auth.user.userId,
    [...other properties]
  },
  updateQueries: {
    getUserBookmarks: (previousQueryResult, { mutationResult }) => {
        const bookmarks = [...previousQueryResult.user.bookmarks,
                            mutationResult.data.createBookmark];
        return { uuid: "ba88e490-4e07-...", bookmarks: bookmarks };
    }
  },
  optimisticResponse: { [...other properties], uuid: '' }
})

This is what GraphiQL returns for that mutation:
{
  "data": {
    "createBookmark": {
      "uuid": "55aea0c0-5765-...",
      [...other properties]
    }
  }
}

When I start the add from the UI, I can see from console logging that the mutation returns this:
{
  uuid: "ba88e490-4e07-..."
  bookmarks: [
    { uuid: "130dfa70-5767-...",  [...other properties]},
    [...more bookmarks...]
    { uuid: "55aea0c0-5765-...", [...other properties]}      <- the one I just created
] }

In Redux devtools, I see this:
APOLLO_MUTATION_INIT
action:
  mutationString:[exactly as above]
  mutationId:"2"
  type:"QUERY_RESULT"
  optimisticResponse: { [exactly as above] }
  [...other properties...]
  resultBehaviors/0/newResult: [exactly what's in the console log]
  queryFragments:undefined
TypeError: fragments is undefined

APOLLO_MUTATION_RESULT
action: [...most of the 'action' property as above]
Interrupted by an error up the chain

Here's the console stack trace:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>line 65]
<EMAIL_ADDRESS>line 55]
<EMAIL_ADDRESS>line 19]
<EMAIL_ADDRESS>line 27]
...

I've tried commenting out my optimisticResponse and I get the same result, erroring at the same line.

Could be related to #470

This looks like it's related to #470 and #475, but I was able to circumvent that by writing something similar to
export default connect({
  mapQueriesToProps: () => ({
    data: {
      query: gql`
        query foos {
          foos {
            id
          }
        }
      `,
      fragments: [], // fix for https://github.com/apollostack/apollo-client/pull/475
    },
  }),
  mapMutationsToProps: () => ({
    deleteFoos: (id) => {
      return {
        mutation: gql`
          mutation DeleteFooMutation($input: DeleteFooMutationInput!) {
            deleteFoo(input: $input) {
              fooId
            }
          }
        `,
        variables: {
          input: {
            id,
          },
        },
        updateQueries: {
          foos: (previousQueryResult, { mutationResult }) => {
            const newResult = cloneDeep(previousQueryResult);
            const newFoos = previousQueryResult.foos.filter(
              foo => foo.id !== mutationResult.data.deleteFoo.fooId
            );
            newResult.foos = newFoos;
            return newResult;
          },
        },
        optimisticResponse: {
          deleteFoo: {
            fooId: id,
          },
        },
      };
    },
  }),
})(ManageFoosComponent);

The empty array of fragments had to be provided to the query, not to the mutation.

I'll give that a shot, thank you.
On Jul 31, 2016 5:06 PM, "Tim Kennedy"<EMAIL_ADDRESS>wrote:

This looks like it's related to #470
https://github.com/apollostack/apollo-client/issues/470 and #475
https://github.com/apollostack/apollo-client/pull/475, but I was able
to circumvent that by writing something similar to
export default connect({  mapQueriesToProps: () => ({    data: {      query: gql       query foos {          foos {            id          }        }     ,      fragments: [], // fix for https://github.com/apollostack/apollo-client/pull/475
},
}),  mapMutationsToProps: () => ({    deleteFoos: (id) => {
return {        mutation: gql         mutation DeleteFooMutation($input: DeleteFooMutationInput!) {            deleteFoo(input: $input) {              fooId            }          }       ,        variables: {          input: {            id,
},
},        updateQueries: {          foos: (previousQueryResult, { mutationResult }) => {
const newResult = cloneDeep(previousQueryResult);
const newFoos = previousQueryResult.foos.filter(
foo => foo.id !== mutationResult.data.deleteFoo.fooId
);            newResult.foos = newFoos;            return newResult;
},
},        optimisticResponse: {          deleteFoo: {            fooId: id,
},
},
};
},
}),
})(ManageFoosComponent);
The empty array of fragments had to be provided to the query, not to
the mutation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apollostack/apollo-client/issues/488#issuecomment-236465430,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACVEbGMoc87fEB8YAtTcFnYK2EpUyt1Xks5qbTh9gaJpZM4JZJX6
.

I tried it, and indeed it did work. I just started working on this 3 days ago... and #470 was closed 4 days ago but hasn't made it to the npm package yet. Looks like I should switch to pulling master instead of relying on the package since this is moving so rapidly.
Anyway, thanks very much – it's so satisfying to get the round trip working! I've now made several bookmarks just to see them appear in the menu...

@margaretmoser we usually release everything that is merged within one day - so I would be surprised if you needed to use master... #470 is in 0.4.9: https://github.com/apollostack/apollo-client/blob/master/CHANGELOG.md#v049


chore: adaptations for nightly-2024-06-16

This is mostly adaptation for leanprover/lean4#4400.

bors merge


Unity Snippets not working

I have installed unity snippets, it worked well till now, but after updating vs code,  unity auto compete snippets not working and not even showing !
I don't know this is because of vs code or extenison bug.

In what version of VS Code is that, stable or insiders? Then what extension do you use?

Codelens stopped working for me on the mac Version 1.24.0

@sherzodkh ping

Recently, I have updated to 1.24. It was the previous of this vs code stable version of course
Also, some times it does not recognize unity script and after deleting my vs code, and installing again work again.


move node revertion

When we move node, server-side code can forbid this movement.
Is there any possibility to revert moving on client-side?

Hi, this has been discussed a lot in the forums. No, there is no such option, it was removed in v.3. The reason was that usually when the server operation fails, chances are the local representation is way off. So it is best to .refresh() on failure just to be on the safe side.
Best regards,
Ivan


Royalroad

Roaylroad (https://www.royalroad.com/) is a popular site for english webnovels it contains over 37000 webnovels

Thank for you for the link. Unfortunately we are not accepting more submissions to the Pile at this time. If you think it would be highly useful to ML researchers, I encourage you to scrape and release the data yourself :)


Address not available on Jekyll build using Docker Compose

Error
Jekyll Strapi: Fetching entries from http://localhost:1337/testdata?_limit=10000
jekyll-serve_1  | /usr/local/lib/ruby/2.7.0/net/http.rb:960:in `initialize': Failed to open TCP connection to localhost:1337 (Address not available - connect(2) for "localhost" port 1337) (Errno::EADDRNOTAVAIL)

Jekyll Version: 4.0
Strapi Version:  3.6.5
Viewing from web browser locally, I see:
http://localhost:1337/testdata
id | 2
title | "Title is long enough now"
published_at | "2021-07-29T23:12:33.002Z"
created_at | "2021-07-29T23:05:14.623Z"
updated_at | "2021-07-29T23:12:33.014Z"

Jekyll Layout:
	{%- for testdata in strapi.collections.testdata -%}
	<li>
		{{ testdata.title }}
	</li>
	{%- endfor -%}

Jekyll Config
# Strapi dashboard integration
strapi:
    # Your API endpoint (optional, default to http://localhost:1337)
    endpoint: http://localhost:1337
    # Collections, key is used to access in the strapi.collections
    # template variable
    collections:
        # Example for a "posts" collection
        testdata:
            type: testdata
            output: true

Jekyll Gemfile
group :jekyll_plugins do
   gem "jekyll-feed", "~> 0.12"
   gem 'jekyll-strapi'
end

Update:
I tested with <IP_ADDRESS>, <IP_ADDRESS>, and actual machine IP 192.x.x.x.
The machine IP actually produced a timeout sequence..all others instantly stopped Jekyll.
I opened up all permissions for public on Strapi to check if it was a permission issue; still same results as above.
I also changed all the information to replicate the data provided via README.md for jekyll-strapi.
I even tested to see if it was a docker-compose issue with running on same docker-compose file. I separated each service and ran it independently..still same error.

jekyll-serve_1  |      Jekyll Strapi: Fetching entries from https://localhost:1337/articles?_limit=10000
jekyll-serve_1  |   Liquid Exception: Failed to open TCP connection to localhost:1337 (Address not available - connect(2) for "localhost" port 1337) in /_layouts/journals.html
jekyll-serve_1  | /usr/local/lib/ruby/2.7.0/net/http.rb:960:in `initialize': Failed to open TCP connection to localhost:1337 (Address not available - connect(2) for "localhost" port 1337) (Errno::EADDRNOTAVAIL)
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:960:in `open'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:960:in `block in connect'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/timeout.rb:95:in `block in timeout'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/timeout.rb:105:in `timeout'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:958:in `connect'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:943:in `do_start'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:932:in `start'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:606:in `start'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:481:in `get_response'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-strapi-0.1.3/lib/jekyll/strapi/collection.rb:26:in `each'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-strapi-0.1.3/lib/jekyll/strapi/drops.rb:33:in `to_liquid'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/variable_lookup.rb:49:in `block in evaluate'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/variable_lookup.rb:38:in `each_index'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/variable_lookup.rb:38:in `evaluate'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/context.rb:159:in `evaluate'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/tags/for.rb:130:in `collection_segment'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/tags/for.rb:74:in `render'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/block_body.rb:103:in `render_node_to_output'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/block_body.rb:82:in `render'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/template.rb:208:in `block in render'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/template.rb:242:in `with_profiling'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/template.rb:207:in `render'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/template.rb:220:in `render!'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:39:in `block (3 levels) in render!'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:59:in `measure_counts'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:38:in `block (2 levels) in render!'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:63:in `measure_bytes'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:37:in `block in render!'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:70:in `measure_time'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:36:in `render!'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/renderer.rb:127:in `render_liquid'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/renderer.rb:196:in `render_layout'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/renderer.rb:159:in `place_in_layouts'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/renderer.rb:89:in `render_document'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/renderer.rb:63:in `run'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:523:in `render_regenerated'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:516:in `block in render_pages'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:515:in `each'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:515:in `render_pages'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:202:in `render'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:76:in `process'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/command.rb:28:in `process_site'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/commands/build.rb:65:in `build'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/commands/build.rb:36:in `process'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `block in process_with_graceful_fail'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `each'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `process_with_graceful_fail'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:86:in `block (2 levels) in init_with_program'
jekyll-serve_1  | 	from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
jekyll-serve_1  | 	from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
jekyll-serve_1  | 	from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
jekyll-serve_1  | 	from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
jekyll-serve_1  | 	from /usr/gem/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/exe/jekyll:15:in `<top (required)>'
jekyll-serve_1  | 	from /usr/local/bundle/bin/jekyll:29:in `load'
jekyll-serve_1  | 	from /usr/local/bundle/bin/jekyll:29:in `<main>'
jekyll-serve_1  | /usr/local/lib/ruby/2.7.0/net/http.rb:960:in `initialize': Address not available - connect(2) for "localhost" port 1337 (Errno::EADDRNOTAVAIL)
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:960:in `open'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:960:in `block in connect'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/timeout.rb:95:in `block in timeout'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/timeout.rb:105:in `timeout'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:958:in `connect'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:943:in `do_start'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:932:in `start'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:606:in `start'
jekyll-serve_1  | 	from /usr/local/lib/ruby/2.7.0/net/http.rb:481:in `get_response'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-strapi-0.1.3/lib/jekyll/strapi/collection.rb:26:in `each'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-strapi-0.1.3/lib/jekyll/strapi/drops.rb:33:in `to_liquid'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/variable_lookup.rb:49:in `block in evaluate'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/variable_lookup.rb:38:in `each_index'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/variable_lookup.rb:38:in `evaluate'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/context.rb:159:in `evaluate'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/tags/for.rb:130:in `collection_segment'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/tags/for.rb:74:in `render'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/block_body.rb:103:in `render_node_to_output'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/block_body.rb:82:in `render'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/template.rb:208:in `block in render'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/template.rb:242:in `with_profiling'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/template.rb:207:in `render'
jekyll-serve_1  | 	from /usr/gem/gems/liquid-4.0.3/lib/liquid/template.rb:220:in `render!'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:39:in `block (3 levels) in render!'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:59:in `measure_counts'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:38:in `block (2 levels) in render!'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:63:in `measure_bytes'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:37:in `block in render!'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:70:in `measure_time'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/liquid_renderer/file.rb:36:in `render!'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/renderer.rb:127:in `render_liquid'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/renderer.rb:196:in `render_layout'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/renderer.rb:159:in `place_in_layouts'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/renderer.rb:89:in `render_document'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/renderer.rb:63:in `run'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:523:in `render_regenerated'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:516:in `block in render_pages'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:515:in `each'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:515:in `render_pages'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:202:in `render'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/site.rb:76:in `process'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/command.rb:28:in `process_site'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/commands/build.rb:65:in `build'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/commands/build.rb:36:in `process'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `block in process_with_graceful_fail'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `each'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/command.rb:89:in `process_with_graceful_fail'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/lib/jekyll/commands/serve.rb:86:in `block (2 levels) in init_with_program'
jekyll-serve_1  | 	from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `block in execute'
jekyll-serve_1  | 	from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `each'
jekyll-serve_1  | 	from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/command.rb:220:in `execute'
jekyll-serve_1  | 	from /usr/gem/gems/mercenary-0.3.6/lib/mercenary/program.rb:42:in `go'
jekyll-serve_1  | 	from /usr/gem/gems/mercenary-0.3.6/lib/mercenary.rb:19:in `program'
jekyll-serve_1  | 	from /usr/gem/gems/jekyll-4.0.1/exe/jekyll:15:in `<top (required)>'
jekyll-serve_1  | 	from /usr/local/bundle/bin/jekyll:29:in `load'
jekyll-serve_1  | 	from /usr/local/bundle/bin/jekyll:29:in `<main>'

Yeah, i have been trying to debug this for 3 days now :(
I have come to the conclusion it must be the plugin; the connection is open, yet it is being refused..maybe because of JSON formatting error?

In the docker container, the server and port are open.
The API is accessible to the local public intranet via two different browsers; one was logged in, the other logged out.
I am able to access the API via another device talking to docker container..aka my phone -> desktop -> docker-container
All docker containers are on the same network; I am also running postgres db with docker-compose.
I disabled collections and pagination on jekyll to see if plugins was conflicting each other.
I have followed 4-5 various tutorials and guides from the WWW.

Jekyll Version: 4.2.0
Strapi-jekyll Version: 0.1.3
Docker version 20.10.7, build f0df350
Docker Compose version 3.9

Okay, i have mitigated the problem down to my Sttrapi CMS localhost. It is my problem, but still am unsure why. I tested with a live demo with strapi api and it worked..


Add a week for triage

#2179 got tagged with this:

The changes are still valid, and no requests for follow-up have been made to the author of that PR, so auto-closing it would not be appropriate. It looks like this bot's current settings aren't a good fit for this repo's work flows.
This PR adds a week to those deadlines to better fit the time required for triage.

Obviously there would be no point in following that suggestion.

Ekkarat Wareesing
<EMAIL_ADDRESS>

Happy birthday 🎈

Happy 😁

👋 @HebaruSan Thanks for opening this PR! I agree that we need to look at our timelines for marking things as stale, they're a bit too aggressive right now and we probably should have made them longer during the holiday 🙈 This is a  discussion we'll need to have internally before we make any changes, so I'm going to close this PR.
Thanks for your contributions 🎉

👋 @HebaruSan Thanks for opening this PR! I agree that we need to look at our timelines for marking things as stale, they're a bit too aggressive right now and we probably should have made them longer during the holiday 🙈 This is a  discussion we'll need to have internally before we make any changes, so I'm going to close this PR.
Thanks for your contributions 🎉


Harmonize local user creation from remote SSO.

What's this PR do?

Harmonizes local user creation from remote SSO account

Test results
UK:

Canada:

What are the relevant tickets?
A part of #3749.

Nice PHP :+1:

Thanks @aaronschachter!


Import image as map background

Description
Sometimes I take pictures of plans or have aerial photography of some places.
I would like to use those as map layers.
I found issue #4035 that was about the same topic but is pretty old and I do not want to subscripe to an external service and pubish those picture online.
Currently when I have to do such edits I usually go with JOSM but iD is way easier to use to edit.
I guess I only need 2 options once the image is imported:

~Rotate it: in order to be able to align it correctly~ (this is handled by the move below)
Move the 4 corners to their location, this may distord the image (think about an area like it currently exist but with strictly 4 corners)
(Optional) Adjust it's opacity so that it is easier to align with background imagery

I think that this should be possible under the "Layer" sub-menu with an option like "import custom image"
Screenshots
No response

Once I tried hacking around it to map a corn maze, but it’s definitely not convenient. MapWarper really is a nicer way to do it when you’re OK with publishing the image publicly.

Once I tried hacking around it to map a corn maze, but it’s definitely not convenient. MapWarper really is a nicer way to do it when you’re OK with publishing the image publicly.

I still think that for one-of mapping imports an embedded tool will be easier and would help mapping areas where aerial imagery is not sufficient / outdated. That say I do not know how hard it is to do so.

This just opens a can of worm, how do we know if you are not using a screenshot of a proprietary source?

This just opens a can of worm, how do we know if you are not using a screenshot of a proprietary source?

We don't know, but I don't think iD is responsible to avoid this:

JOSM allows to have a custom image as background
A user can still have its source on the side of the screen and try to replicate


Language iteration cycle estimate grid

TLDR; want to know how long it takes to deploy an update for each supported language

Part of the annoyance of lambda is how a simple script-function updates so quickly (wow so cool) when there are no dependencies, then quickly proceeds into a giant multi-megabyte upload when adding in all node_modules... or golang dependencies for that matter (wow so not cool).  This is especially painful when just adding commas and needing to wait for uploads.
For someone like me who wants fast iteration cycles, it would be great for the Apex Up readme to simply say "Typically, by the time you add in aws sdk, url parsers, etc..." (whatever that mythical bundle is), this is what you can expect your "up deploy" time/sizes to be like (assuming x mbps internet connection).
I know... this is far from perfect.  I just dream of a place where someone explains how to make lambda deploys fast.  When I pay $x for a subscription (which I did!), I kind of want that guidance as my "instant refund". :)
Is it fair to say that one should "figure it out own their own" because lambda already has these inherent "times"?  Yes... sorta.  Golang/Rust is supported here, and typically there's no mental basis for that.
So do I want to try golang/rust if I know the deploy is 5x faster? Yes!  What if it's 10x slow? No!  Or... where's that line?

I suppose I could just... deploy all the examples one at a time and time it?  Well... not really... I suppose this is harder than it sounds.

It'll vary a lot depending on the project and your connection speed. My real-world go apps deploy in ~10-15s from a Starbucks, but as you mention if you're using something like Node with a lot of node_modules it can become large quickly.
In those cases it's definitely more ideal to deploy from CI so you can utilize their network. Eventually I'd like to support Docker and/or diffs etc, but for now just simple zips is it.
Which language(s) are you planning on using?

On my side it's javascript and golang.

A simple express app w/ aws-sdk
  "dependencies": {
    "async": "^2.6.0",
    "aws-sdk": "^2.156.0",
    "aws-serverless-express": "^3.0.2",
    "body-parser": "^1.18.2",
    "compression": "^1.7.1",
    "cors": "^2.8.4",
    "express": "^4.15.3",
    "express-favicon": "^2.0.0",
    "pug": "^2.0.0-rc.4"
  }

deploy time
     hook: build (9ms)
     build: 4,663 files, 13 MB (3.423s)
     deploy: complete (10.003s)

Deploying gh-polls which appears to use aws-sdk-go, pat -- close enough
     hook: build (24ms)
     build: 23 files, 4.4 MB (530ms)
     deploy: complete (2.833s)
     hook: clean (18ms)

so there's definitely a good reason to run away from the billions of node_module files.

Haha yep definitely, I wrote tj/node-prune to help a bit there, but it doesn’t completely solve the problem. Sometimes you can get away with using rollup/webpack as well.
Going to close for now, I think there are too many variables, plus medium-to-large companies typically use CI where the network is much better as well.

Wow built in CI.  Yeah whatever the flavor is, it would be quite cool to take another integration step off my mind.  Anyways, your thoughts are well received!

Agreed! It's definitely on the list, they just announced some great CI features too so I'd like to streamline that


Optional Route Value Without DTO is still required on Swagger

So, I have this route value that I want it to be optional and be able to test it on Swagger, but even when putting "isRequired: false", in swagger appears as required.

swagger doesn't allow optional path parameters: https://swagger.io/docs/specification/describing-parameters/


Add basic watchos support

Depends on https://github.com/mac-cain13/R.swift.Library/pull/28
Add a Watch app and extension using R.swift to the sample application.

I was wondering about the state of this PR. Is it being considered for inclusion. We're now using my fork in our projects and would love to go back to the non forked release.

Hi, thank you for your PR, and sorry for the (very) late reply.
We are interested in adding watchOS support, and merging this PR, but we've been very busy these last few months. When we've finally figured out a good fix for the issues with the New Build System we'll have some time to look add merging new features.
Again, thank you for this PR!

Any updates on this? We've quite a big project stuck on the 5.0.0 alpha release branch from @lammertw because we need watchOS support. Anything I can do to help get this merged :) ?

No updates, other than that we did manage to figure out the build system issues and R.swift 5 has been released (5.0.3 now).
I do plan on looking at this PR (and others), but after WWDC, once we know if there's major changes in the next Xcode.

Thanks again for this PR!
Sorry it took so long, we were busy with other stuff.
I've merged it and it will be part of the next R.swift release.


prevent creation of pipelines with duplicate names

cc @spinnaker/reviewers

@tomaslin or @ajordens PTAL

Pipeline strategies likely need similar treatment.
The rename operation might also let through a duplicate ... it's probably also gated in the UI tho.

@ajordens Good call. All these operations are gated in the UI, but that won't prevent a race condition (or stale browser data) from letting a duplicate through.
I've updated the PR to check on strategy saves and both rename operations.

LGTM


[easy] Cleanup internal dependencies

Removes uneeded cruft in our Cargo.toml files

:hourglass: Testing commit 6540d0b2e00522a7e1247e86ff6abccf79e98af5 with merge e9c820cfac703ab54f8b223c76eef3a35d7a187c...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: metajack
Pushing e9c820cfac703ab54f8b223c76eef3a35d7a187c to master...


Fix empty Bird style code lines.

Empty Bird style code lines, i.e. lines containing only a single '>' were
treated like markdown. Only code lines with '> ' were treated like empty code
lines.

A small note: This patch is not "perfect", since one could envision a markdown cell containing a line with a single '>' in it. The line would mistakenly be interpreted as a code cell. However, in a notebook chances are far greater that '>' means code than markdown. Implementing a more robust version would probably require both lookahead and transformation history. I think it's overkill, so until somebody files an issue, I'll leave it as it is.

Sounds good. Thanks for the note. I personally don't use this feature, so am okay with leaving it as it is until this becomes an issue, if it ever does.


feat: let the user decide if they want planning to fail if no services are detected

Signed-off-by: Harikrishnan Balagopal<EMAIL_ADDRESS>

If I understand it correctly, move2kube doesn't do anything with the bound services present in the cf manifest. So is this change from a transformers perspective ?

If I understand it correctly, move2kube doesn't do anything with the bound services present in the cf manifest. So is this change from a transformers perspective ?

@anwarchk This particular PR has nothing to do with Cf bound services. But we are currently working on a capability to migrate bound services to either as Operators or services in Cloud catalogs. Here is a discussion on this topic.
Please do let us know your usecase, how you are using Move2Kube, and how you would like Move2Kube transform the services, so that we can feed that into feature design for services migration. We can also continue the conversation in slack.


Unpack into make_map instead of using to_map

This fixes the code generation issues. The problem is that to_map allows for duplicate keys in the "from" sequence, which means it needs to recursively insert into a hana::map. This is both very bad for codegen and for compile-times. make_map, on the other hand, requires all the keys to be distinct, which makes it much more straightforward and much easier to optimize.
With this, I get the following codegen for test_calls.cpp on Clang:
	.section	__TEXT,__text,regular,pure_instructions
	.macosx_version_min 10, 11
	.globl	__Z10call_kwfoov
	.p2align	4, 0x90
__Z10call_kwfoov:                       ## @_Z10call_kwfoov
	.cfi_startproc
## BB#0:
	pushq	%rbp
Lcfi0:
	.cfi_def_cfa_offset 16
Lcfi1:
	.cfi_offset %rbp, -16
	movq	%rsp, %rbp
Lcfi2:
	.cfi_def_cfa_register %rbp
	movl	$2, %edi
	movl	$4, %esi
	movl	$3, %edx
	popq	%rbp
	jmp	__Z3fooiii              ## TAILCALL
	.cfi_endproc

	.globl	__Z11call_kwfoo2v
	.p2align	4, 0x90
__Z11call_kwfoo2v:                      ## @_Z11call_kwfoo2v
	.cfi_startproc
## BB#0:
	pushq	%rbp
Lcfi3:
	.cfi_def_cfa_offset 16
Lcfi4:
	.cfi_offset %rbp, -16
	movq	%rsp, %rbp
Lcfi5:
	.cfi_def_cfa_register %rbp
	movl	$2, %edi
	movl	$4, %esi
	movl	$3, %edx
	popq	%rbp
	jmp	__Z3fooiii              ## TAILCALL
	.cfi_endproc

.subsections_via_symbols

Fixes #1

HA! I knew it would be some weird thing I wasn't thinking about :). Thanks!


Improve implementation for memory spec on Linux

This pull request refactors spec/memory for Linux.

Close file correctly
Remove regexp to parse /proc/meminfo.
Avoid nested loop and improve performance.
Add a mock parsing test.

LGTM

Thank you!


Fix CODEOWNERS file (opensearch-project#1193)

opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Github Issue # or road-map entry, if available:

Description of changes:

Why these changes are required?

What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1286 (d162b29) into opendistro-1.6 (fa034d1) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             opendistro-1.6    #1286      +/-   ##
====================================================
- Coverage             62.79%   62.77%   -0.03%
  Complexity             2953     2953
====================================================
  Files                   229      229
  Lines                 16326    16326
  Branches               3054     3054
====================================================
- Hits                  10252    10248       -4
- Misses                 4493     4497       +4
  Partials               1581     1581

Impacted Files
Coverage Δ

.../dlic/auth/ldap2/LDAPConnectionFactoryFactory.java
56.48% <0.00%> (-1.53%)
:arrow_down:

...security/configuration/DlsFlsFilterLeafReader.java
55.61% <0.00%> (-0.75%)
:arrow_down:

...search/security/tools/OpenDistroSecurityAdmin.java
47.41% <0.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa034d1...d162b29. Read the comment docs.


any demo or example for this?

Nothing public-facing that I'm aware of but the README is fairly comprehensive.


Update README.md

Check all applicable boxes below (put an x in between the square brackets, with no spaces)

[ ] This is to fix an issue. Issue #:
[x] If I modified anything other than comments, I ran npm run build and npm test

Summary
This pull request makes it so...

@Abhiraj-Tulsyan I would suggest just editing in the web editor, by pressing the pen button.


File rename: Need special character validation in file name

Storage Explorer Version: 1.12.0
Build Number: 20200116.10
Platform/OS: Windows 10
Architecture: x64
Regression From:  N/A
Bug Description
Cloning a file with an invalid target file name gives generic "BadRequest" message
Steps to Reproduce
Upload a file to a file share
Clone with New Name
Enter an invalid file name, e.g. file**.txt
Expected Experience
API returns 400 "The specifed resource name contains invalid characters." The same message should be shown.
Actual Experience
Error message "BadRequest" pops up
Additional Context
N/A

Merged for 1.18. Thanks for opening this issue @yuyez.


Settings Page not scrollable to bottom on Mweb

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open settings on mWeb

Expected Result:
notice that "Open in the New Expensify App" banner pushes the page below the bottom input
Actual Result:
"Sign Out button" is nearly unreachable
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?:  not reproducible by applause
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/4118ea37-4b73-44e5-b7a5-564672e1adaa
Expensify/Expensify Issue URL:
Issue reported by: @grgia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687366958023089
View all open jobs on GitHub

This is due to the smart banner on top.
I think it can be closed based on the discussion here https://github.com/Expensify/App/issues/8791 and https://github.com/Expensify/App/issues/17381

Yeah, commented here. Closing!


TritArray encoding should be toggle-able via build parameters

We should be able to use --define to toggle the encoding until proper support has been merged into upstream bazel.
https://docs.bazel.build/versions/master/be/general.html#config_setting
At the moment, the trit_array encoding is hardcoded in bazel buildfile

Fixed by #148


Update secure-connect-arch2.png

update image

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://660adb1de4397f834a681528--harness-developer.netlify.app


[wavpack] fix usage

If openssl is found it is picked up otherwise

The feature openssl has been removed. https://github.com/dbry/WavPack/pull/167


Create macros that create new implementation that marshals method calls into PendingContractTx

For example, in the FungibleToken Contract:
struct FungibleTokenContract {
    account_id: AccountId,
}

impl FungibleTokenContract {
    pub fn new(&self, owner_id: AccountId, total_supply: Balance) -> PendingContractTx {
        let balance: U128 = total_supply.into();
        PendingContractTx::new(
            &self.account_id, // Contract is the receiver
            "new",
            json!({
              "owner_id": owner_id,
              "total_supply": balance
            }),
            false, // Is not a view function
        )
    }
...
}

see #235.  It now contains the marshaling.  Still need to improve the initialization experience.


build-bottle-pr: allow to build bottle prs for linuxbre-core

This looks a little bit ugly, there my be a better way to do this.
Also, I think I can remove the science case?

Also, I think I can remove the science case?

:+1: Yep!

Superseded by PR #96.


dashboard and register page and UI/UX fix through figma

i think this website can be more responsive and attractive if we add premium option and make a registration page and a dashboard
pls assign me this under gssoc'23 tag

its not required for this website


Increase contrast of inline code elements

Based on: https://github.com/wagtail/wagtail/issues/6793
A design proposal could be helpful.
Current Wagtail docs:

Current Typo3 based theme:

Ditto contrast of admonitions as pointed out in #119 . Probably worth doing a contrast-related changeset (which might benefit from a designer's eye if there are to be any color palette changes)


Add pytorch 1.5.0 to installation doc

Hi, I thought it might be worth updating the install to include the links for pytorch 1.5 since it is a later version

Thanks, I missed that :)


How to add new context menu item?

How can I add custom events to the context menu in addition to the default events such as:

Select
Delete
Reset view

Hello @nguyendkn. This is a feature that is coming to the pro version.

Hello @nguyendkn! In the new version of the pro package we introduced the Custom Context Menu Items feature. Now it's possible to add custom items. You can see a demo that included that feature here: https://nocode-js.com/examples/sequential-workflow-designer-pro/webpack-pro-app/public/popup-editor.html
Here is the documentation (only for clients of the pro package).


Cannot find property

Following file is correct.
class Person {
  name: String
}
function buildPersons(names: Set<String>): Listing<Person>
  = new {
      for(n in names) {
        new Mapping {
          ["name"] = n
        }.toMap().toTyped(Person)
      }
    }
persons = buildPersons(Set("Me", "You"))

But if this file is split into 2 files then there is an error.
File base_template.pkl
persons: Listing<Person>
class Person {
  name: String
}

File my_template.pkl
amends "base_template.pkl"
persons = buildPersons(Set("Me", "You"))

local function buildPersons(names: Set<String>): Listing<Person>
  = new {
      for(n in names) {
        new Mapping {
          ["name"] = n
        }.toMap().toTyped(Person)
      }
    }

Then evaluating my_template.pkl produces the following error:
–– Pkl Error ––
Cannot find property `Person`.

10 | }.toMap().toTyped(Person)
                       ^^^^^^
at my_template#buildPersons[#1] (file:///.../my_template.pkl, line 10)

Did you mean any of the following?
persons
buildPersons

3 | persons = buildPersons(Set("Me", "You"))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
at my_template#persons (file:///.../my_template.pkl, line 3)

106 | text = renderer.renderDocument(value)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
at pkl.base#Module.output.text (https://github.com/apple/pkl/blob/0.25.2/stdlib/base.pkl#L106)

Here, pkl seems to not see the Person class.
Do I miss something?

Why are you creating a Mapping instead of instantiating a Person directly?
local function buildPersons(names: Set<String>): Listing<Person> = new {
  for(n in names) {
    new Person {
      name = n
    }
  }
}

But the answer is the same as your previous issue: scoping. Try doing .toTyped(module.Person).

Thank you for the provided solution. But this should be simpler without module.prefix.

Why are you creating a Mapping instead of instantiating a Person directly?

In fact, my code is more complex as it builds objects dynamically. The provided example is just to illustrate the scoping issue.

Closing this; see https://github.com/apple/pkl/issues/288#issuecomment-1977057061 for details about the decisions we made behind Pkl's scoping rules.


Scrape recent metrics from the server

Description
According issue #931 , we can add a feature to get recent data since a fix time through plugins
Describe the solution you'd like
We can use api links as below

github issue api link: https://docs.github.com/en/github-ae@latest/rest/reference/commits

since:   Only show notifications updated after the given time. This is a timestamp in ISO 8601 format: YYYY-MM-DDTHH:MM:SSZ

gitlab merge request api link: https://docs.gitlab.com/ee/api/merge_requests.html

created_after: Return merge requests created on or after the given time. Expected in ISO 8601 format (2019-03-15T08:00:00Z)
updated_after:  Return merge requests updated on or after the given time. Expected in ISO 8601 format (2019-03-15T08:00:00Z)
But still need more work to verify if we can get right data by the params

Has the Feature been Requested Before?
issue #931

@yumengwang03 Aah, I'm starting to feel sorry for u...

Close it as it duplicates with #931


htlcswitch: make final settle signal opt-in, add delete functionality

    >And making this opt-in can complicate things. So I guess I'm not sure, tho leaning towards making it opt-in, at lease give users an option.

Given the advanced state of this PR, would you be okay with discussing and implementing the opt-in in another PR, possibly combined with delete functionality?
Originally posted by @joostjager in https://github.com/lightningnetwork/lnd/issues/6517#issuecomment-1291997033

Coming back from itest fix, I got two questions with PR #6517,

what's the difference between HtlcEventSettle and HtlcEventFinal with settled=true? Do they overlap? Or can an HtlcEventSettle be followed by an HtlcEventFinal with settled=false?
the htlc event used here is UNKNOWN, which doesn't feel right - how can an intentionally crafted event be unknown?

Found this previous discussion,

I didn't want to add a dedicated subscriber api for final htlc notification and decided that the existing htlc notifier api is close enough to add it there. The use case, at least mine, is quite different though. The htlc notifier is intended to keep a (lossy) eye on traffic, whereas the final htlc notification is needed to get a definite answer to what happened to an htlc without relying on polling LookupHtlc. The additional context of whether the htlc was a forward or exit hop receive isn't relevant.

what's the difference between HtlcEventSettle and HtlcEventFinal with settled=true? Do they overlap? Or can an HtlcEventSettle be followed by an HtlcEventFinal with settled=false?

They are different. HtlcEventSettle is the initiation of the settle action, and HtlcEventFinal, settled=true is when it actually happened.
HtlcEventSettle can indeed by followed by HtlcEventFinal with settled=false. This is what is unsafe about lnd and the primary reason for #6517.

Hey @joostjager are you still planning on resolving this for 0.16?

I can definitely do that. What would be the most suitable way to opt-in to it, command line flag?

I think a config option would be nice.

actually just realized the delete part is not added yet

What would be the best way to implement delete for this? Delete everything for a particular channel? There is no way to query for which channels final resolution data is stored though.


ISPN-13605 SIFS write/delete/containsKey(...) exception handling does not conform to NonBlockingStore contract.

https://issues.redhat.com/browse/ISPN-13605

@wburns Please review.

@wburns N.B. I did not test whether other NonBlockingStores have a similar issue.

Integrated into main, thanks @pferraro !


OWNERS: Add OWNERS file

Signed-off-by: Samuel Ortiz<EMAIL_ADDRESS>

Coverage remained the same at 70.614% when pulling 2ba9db3e2025d317b650d7dd032e5e0beb33be57 on sameo/topic/owners into 70866bae885913e407c6e23194da008dd13b5e1b on master.

lgtm


feat: supports custom prepare build script

Ⅰ. Describe what this PR did
Nowadays, if some plugin has additional dependencies need to be installed, developer may change the builder Dockerfile directly, but it's not healthy for long time maintaining.
This PR will support custom prepare build script for each plugin.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.53%. Comparing base (ef31e09) to head (9922393).
Report is 186 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   35.91%   43.53%   +7.62%
==========================================
  Files          69       76       +7
  Lines       11576    12320     +744
==========================================
+ Hits         4157     5364    +1207
+ Misses       7104     6621     -483
- Partials      315      335      +20

see 69 files with indirect coverage changes

默认脚本是不是可以放在.buildrc里，和go保持一致

The action also needs to be updated accordingly:
https://github.com/alibaba/higress/blob/aee37c5e22670b11ba88d1939b8c77dde0f9da68/.github/workflows/build-and-push-wasm-plugin-image.yaml#L133

昨天看了下，gcc那些依赖是ai-data-masking项目里的正则库依赖的，不是一个通用依赖

The action also needs to be updated accordingly:
https://github.com/alibaba/higress/blob/aee37c5e22670b11ba88d1939b8c77dde0f9da68/.github/workflows/build-and-push-wasm-plugin-image.yaml#L133

昨天看了下，gcc那些依赖是ai-data-masking项目里的正则库依赖的，不是一个通用依赖

是的，我的意思是要在这里增加支持 prepare 脚本的逻辑

参考这里
https://github.com/alibaba/higress/blob/aee37c5e22670b11ba88d1939b8c77dde0f9da68/.github/workflows/build-and-push-wasm-plugin-image.yaml#L111-L117

go也没有修改 prepare 脚本的逻辑把，rust和go可以统一固定为插件目录下的 .buildrc

改成.buildrc了

There is a change request and no relation with fixed PR but no way to resolve it, PTAL @johnlanni


eslint fails on getNormalizationAnnotations.js

Probably disabling it here is better than a breaking change? In case of the breaking change Isotherm, TGA and PXRD view need to be changed.
/home/runner/work/common-spectrum/common-spectrum/src/jsgraph/getNormalizationAnnotations.js
Error:   1:45  error  Default parameters should be last  default-param-last

I would technically be a breaking change, but is there anywhere that the method is called without the first parameter? The only way to call it would be getNormalizationAnnotations(undefined, boundary)

closed by https://github.com/cheminfo/common-spectrum/commit/fe56d4d30fb8520442a72245b55d88b7bd334191


Corrected CODE_OF_CONDUCT.md

Motivation
Errors in CODE_OF_CONDUCT.md
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[x] Docu has been updated (if applicable)
[ ] Temporary settings (e.g. project ID used during development and testing) have been reverted to defaults

thx for the PR! could you please apply the same fix in the https://github.com/Kentico/oss-automation repo?

Hey @DhruvamSharma,
we would like to thank you for contributing to Kentico's open-source project. As a sign of our appreciation, we would like to send you some Kentico Developer Community SWAG!
Please fill out your postal address if you are interested.
This comment was automatically generated. If you've submitted more than one pull request, it's OK to fill out the form just once.
Kentico Developer Community
If there’s anything we can do to help, please don’t hesitate to reach out to us at<EMAIL_ADDRESS>


bruteforce-salted-openssl: init at 1.4.2

Description of changes

Added bruteforce-salted-openssl a tool to bruteforce password of files encrypted with OpenSSL
https://github.com/glv2/bruteforce-salted-openssl
Related to https://github.com/NixOS/nixpkgs/issues/81418
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 281308 run on x86_64-linux 1

1 package built:

bruteforce-salted-openssl


Implement volkFinalize function

This is normally not necessary to call if the instance survives until the application shutdown, but it might be useful in some cases where a clean and complete instance recreation is needed, or if the application wants to tear down the Vulkan instance and then create an OpenGL instance while making sure the Vulkan DLLs are unloaded.
Fixes #152.

Note, for now we don't validate that initialize/finalize calls are properly paired, this can be handled with assertions in the future.


New ESA CCI landcover feature collection does not exist.

It seems like the new dataset 4f51f9b4d9396387ed9b424bbbb9468818a5c728,  is not public.
Ref: https://code.earthengine.google.com/e84fec1cf24d3e547accba2890d344e4

fixed


Misc fixes

@k8s-bot ok to test

One thing I noticed is that most of our pvc resource templates do not define any label metadata. Any particular reason for it?

One thing I noticed is that most of our pvc resource templates do not define any label metadata. Any particular reason for it?

Good catch. We should clean that up and add the standard helm metadata

@lachie83 @prydonius updated the PR to:

remove the * characters from the NOTES.txt files (tried to format the output a little)
added standard metadata labels to the PVC resources

@k8s-bot ok to test

done!
On Saturday 19 November 2016 05:13 AM, Adnan Abdulhussein wrote:

@prydonius commented on this pull request.

In stable/drupal/templates/NOTES.txt
https://github.com/kubernetes/charts/pull/209#pullrequestreview-9328090:

@@ -1,6 +1,5 @@
-*******************************************************************
-*** PLEASE BE PATIENT: Drupal may take a few minutes to install ***
-*******************************************************************

+PLEASE BE PATIENT: Drupal may take a few minutes to install
We should keep the asterisks in this one. It's only when we're using
this with templating that it gets unaligned and looks weird.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/charts/pull/209#pullrequestreview-9328090,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZCI4F5Q-XdDrUS7_ZjTJAvD_Omjnu8ks5q_jgEgaJpZM4KqgBC.

--
Sameer Naik
w: http://www.damagehead.com e<EMAIL_ADDRESS>

@k8s-bot ok to test

Tests are failing due to the failed deletion count issue, but otherwise the charts are installed without error.

rebased and resolved conflicts

Testing now...
@sameersbn in the future can you send smaller PRs (one per chart), it will make testing and merging much quicker and easier.

Noticed that there are no version bumps here. At least the charts with the PVC changes need one.

Manually tested install and basic app verification.

in the future can you send smaller PRs

Sorry about that. I'll update PR with version updates. Thanks for your review.

latest commit bumps the version for charts with PVC metadata label updates

LGTM

@k8s-bot ok to test

Rebased PR

Is there anything I can do to expedite the merge of the changes in this PR?
Do you want me to split the PR in smaller ones?

@sameersbn looks like there are merge conflicts again.

rebased to resolve the conflicts

@viglesiasce any other changes needed here?

Not on my end.
On Tue, Dec 6, 2016, 8:37 PM Adnan Abdulhussein<EMAIL_ADDRESS>wrote:

@viglesiasce https://github.com/viglesiasce any other changes needed
here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/charts/pull/209#issuecomment-265338672,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAZCp3DxEudoG49t4RxQDxZgaPvRLlZ1ks5rFhvXgaJpZM4KqgBC
.

Thanks @sameersbn!


feat(array): refactor StreamChunk & introduce record iterator

What's changed and what's your intention?
In this PR, we refactor StreamChunk with ops and data_chunk instead of unzipping the data chunk into parts, so that we can reuse some functionalities of DataChunk.
https://github.com/singularity-data/risingwave/blob/1228f9272c6e7bcce9db86f7f7c982a1bc5032e0/src/common/src/array/stream_chunk.rs#L72-L79
Then, we remove the StreamChunkRowRef introduced in #1813 and provide a record iterator based on DataChunkRowRef whose item is...
https://github.com/singularity-data/risingwave/blob/1cc6400140e40843de46f79f2a575da6989a206d/src/common/src/array/stream_chunk_iter.rs#L74-L82
Some executors can be benefited from this record-style interface. For now, we keep the row interface for compatibility.
Benchmark
test array::stream_chunk_iter::tests::bench_record_iterator                 ... bench:      45,728 ns/iter (+/- 1,268)
test array::stream_chunk_iter::tests::bench_rows_iterator                   ... bench:      39,444 ns/iter (+/- 865)
test array::stream_chunk_iter::tests::bench_rows_iterator_from_records      ... bench:      73,246 ns/iter (+/- 2,349)
test array::stream_chunk_iter::tests::bench_rows_iterator_vec_of_datum_refs ... bench:     254,524 ns/iter (+/- 11,879)

Checklist

[x] I have written necessary docs and comments
[x] I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#1839
#1840

LGTM!

And a question: what's the benefit from doing so?

Actually the main purpose of this PR is to reuse the row-level iterator of data chunk in #1905 for stream chunk. For record, some executors may use this interface to handle "update" more elegantly, but in the future. 😁


Fix error handling logic for no SSHd check

Merge it after DCI is green!

Merging as the problem with the SSHd check seems fixed but the failure in the check seems to be coming from the tarball change.  No space left on device.  Will fix in another PR.


Remove trailing spaces from it documents(#16742)

This PR removes trailing spaces from "it" doc.  Following command are used.
sed -i 's/[ ]*$//' $(find content/it -type f -not -name "*.png" -not -name "*.jpg" -not -name "*.svg" -not -name "*.gif")

/assign @micheleberardi

/lgtm

@rlenferink  Hi,  could you also review my patch, please??

I left it open because it will definitely conflict with PR #15349, which restructures the Italian pages. After merging that one, feel free to rebase this PR / close and open another PR to remove the spaces.

I left it open because it will definitely conflict with PR #15349, which restructures the Italian pages. After merging that one, feel free to rebase this PR / close and open another PR to remove the spaces.

I see.  will do it !  Thanks.

#15349 is merged. Can you rebase this PR against the latest master?

#15349 is merged. Can you rebase this PR against the latest master?

Sure!!  will rebase it!

Ping @rlenferink , Would you have time to review?

Thanks for the ping, will take a look tomorrow!


Documentation: Keyboard Events

I've looked around for a while and have yet to find any existing documentation on how to implement keyboard/keypress events when building a gui with relm4. I tried a general search-engine, relm4's docs.rs, and the book published on relm4.org but they don't even include a reference to keyboard events.
I found some details on how to work with them directly in gtk4-rs from stackoverflow but I'm not sure how to integrate them into relm successfully so far.
I can see there was some discussion about implementation in the past (https://github.com/Relm4/Relm4/issues/548) but with little commentary. Would it possible to include a tutorial or basic description on how to implement them please?
Relm4 looks very promising for a project I'm working on at the moment but keyboard events are absolutely essential meaning all my effort will be for nil if I can't find a solution lol. Any help would be appreciated thanks!

You're right, this topic is definitely lacking in our docs.
Depending on what you want to implement there are two mechanisms you can use:

If you want to add shortcuts to your app, you need to create and register so called "actions", which are basically callbacks that can be triggered by widgets or keyboard presses. After setting up and action, you can use set_accelerators_for_action to setup a keyboard shortcut that triggers the action: https://github.com/Relm4/Relm4/blob/main/examples/actions.rs#L68
If you want to get events for all key presses, you can add a EventControllerKey to a widget with add_controller. By connecting to the controllers key-pressed event, you should get an event for each key-press as long as the widget is in focus (I think if you use the main window, you should basically get all inputs).

@AaronErhardt, this is exactly what I'm looking for thank you! I can certainly get started on what I'm working on with this, so that's all I need.
I'm going to leave the issue open in case its of any use for a project tracker or anything but if you'd prefer to resolve it then feel free to close. Appreciate the response :)


Develop an hourly model

Thanks for and congratulations on the great work here!
I'm probably not the only person excited to use GraphCast but limited by the 6 hour resolution. I work in the energy sector. Forecasting the shape of electricity prices across the day matters a lot to battery revenue, and is highly dependent on weather. Accuracy at ~hourly resolution probably determines when generic weather apps can switch to new models, too.
So, the feature request is to develop a model with hourly rather than 6-hourly resolution. I'm sure you're already considering this but thought I'd submit a formal issue so those of us interested can follow along.

When predicting we have to enter certain 'forcing' values, if those values are t, t+1, t+2... hours' values instead of t, t+6, t+12.... wouldn't that generate hourly values.

An hourly model would indeed be very interesting for several use-cases. Assuming this model would be used for more short-term predicitons (0-48 hours ahead) it would further be great to optimize the forecast accuracy for 1 day lead-times instead of the 3.5 day lead-time it is currently optimized for.
@abhinavyesss : I think in order to produce meaningful hourly forecasts the model would have to be retrained on hourly ERA5 data instead of just adjusting the 'forcing' values.
@erinboyle : note that for commercial use cases like the energy market there would still be licensing issues since the model weights are published under the non-commercial CC BY-NC-SA 4.0 license.

The challenge with training a 1 hour model is that we don't have good 1 hour data. ERA5 does indeed have 1 hour data, but it only incorporates new observations every 12 hours, so the other 11 hours are just predictions from the 2016 HRES model. This makes a model trained on 6 hour intervals have a weird learning problem where half the time it's learning real physics and half the time it's learning NWP model physics. This is somewhat (mainly?) mitigated by fine-tuning on the HRES dataset that incorporates real observations every 6 hours. Unfortunately we don't have any dataset that incorporates observations every 1 hour. It's certainly possible to train a model that trains on the 1 hour ERA5 data, but I wouldn't expect it to outperform HRES for the first 12 hours. It may outperform HRES when taking a better graphcast prediction as its input, but that is likely also out of distribution (due to blurring), so even that is not guaranteed. Either way, I agree that this would be a useful thing to have, but has a fair amount of challenges to do well.

My guess is that MetNet-3 is more suitable for higher time resolution? But unfortunately, there are no official plans to open source MetNet-3.
Lucidrains made an open-source reproduction of the code here (no weights yet): https://github.com/lucidrains/metnet3-pytorch
Openclimatefix replicated the training of MetNet-1 and 2 and released their pre-trained weights, as shown here: https://github.com/openclimatefix/metnet


[Reproduce] Cannot reproduce the results with base MAE

Hi @Verg-Avesta, I tried to reproduce your pre-training + fine-tuning process, but my results are still different if I use the base MAE model mae_vit_base_patch16, even using the pretrained weights mentioned in issue #6, and even after the fixes suggested in issue #23: I get MAE 13.95 and RMSE 90.25.
On the other hand, if I use the large MAE model mae_vit_large_patch16 I obtain MAE 12.58 and RMSE 87.25, which are closer to the results discussed in the aforementioned issue (MAE: 12.44, RMSE: 89.86), but this isn't mentioned anywhere, as far as I know.
What lets me think that this may be the reason of the difference, besides the fact that the other parameters seems to be the same indicated in the paper or in readme/issues, is the observation that the size of the fine-tuned weights you uploaded on drive (FSC147.pth) is 1.2GB, while the size of my fine-tuned model is ~500MB, as already noticed in issue #7, as far as I can understand using Google Translate.
Other combinations may work as well, e.g. base MAE for pre-training and large MAE for fine-tuning, but I haven't still tried it.

Here are the parameters I used, in case I missed something
for pre-training:
{
    "lr": {
        "desc": null,
        "value": 0.000005
    },
    "blr": {
        "desc": null,
        "value": 0.001
    },
    "seed": {
        "desc": null,
        "value": 0
    },
    "team": {
        "desc": null,
        "value": "wsense"
    },
    "model": {
        "desc": null,
        "value": "mae_vit_base_patch16"
    },
    "title": {
        "desc": null,
        "value": "CounTR_pretraining_paper"
    },
    "wandb": {
        "desc": null,
        "value": "counting"
    },
    "_wandb": {
        "desc": null,
        "value": {
            "t": {
                "1": [
                    1,
                    41,
                    55,
                    63
                ],
                "2": [
                    1,
                    41,
                    55,
                    63
                ],
                "3": [
                    2,
                    13,
                    15,
                    16,
                    23
                ],
                "4": "3.9.15",
                "5": "0.13.9",
                "8": [
                    5
                ]
            },
            "framework": "torch",
            "start_time":<PHONE_NUMBER>.097797,
            "cli_version": "0.13.9",
            "is_jupyter_run": false,
            "python_version": "3.9.15",
            "is_kaggle_kernel": false
        }
    },
    "device": {
        "desc": null,
        "value": "cuda"
    },
    "epochs": {
        "desc": null,
        "value": 300
    },
    "gt_dir": {
        "desc": null,
        "value": "gt_density_map_adaptive_384_VarV2"
    },
    "im_dir": {
        "desc": null,
        "value": "images_384_VarV2"
    },
    "min_lr": {
        "desc": null,
        "value": 0
    },
    "resume": {
        "desc": null,
        "value": "./weights/mae_pretrain_vit_base_full.pth"
    },
    "log_dir": {
        "desc": null,
        "value": "None"
    },
    "pin_mem": {
        "desc": null,
        "value": true
    },
    "dist_url": {
        "desc": null,
        "value": "env://"
    },
    "wandb_id": {
        "desc": null,
        "value": null
    },
    "anno_file": {
        "desc": null,
        "value": "annotation_FSC147_384.json"
    },
    "data_path": {
        "desc": null,
        "value": "./data/FSC147/"
    },
    "accum_iter": {
        "desc": null,
        "value": 1
    },
    "batch_size": {
        "desc": null,
        "value": 16
    },
    "local_rank": {
        "desc": null,
        "value": -1
    },
    "mask_ratio": {
        "desc": null,
        "value": 0.5
    },
    "output_dir": {
        "desc": null,
        "value": "./data/out/pretrain"
    },
    "world_size": {
        "desc": null,
        "value": 1
    },
    "dist_on_itp": {
        "desc": null,
        "value": false
    },
    "distributed": {
        "desc": null,
        "value": false
    },
    "num_workers": {
        "desc": null,
        "value": 10
    },
    "start_epoch": {
        "desc": null,
        "value": 0
    },
    "weight_decay": {
        "desc": null,
        "value": 0.05
    },
    "norm_pix_loss": {
        "desc": null,
        "value": false
    },
    "warmup_epochs": {
        "desc": null,
        "value": 10
    },
    "data_split_file": {
        "desc": null,
        "value": "Train_Test_Val_FSC_147.json"
    }
}

and fine-tuning:
{
    "lr": {
        "desc": null,
        "value": 0.00001
    },
    "blr": {
        "desc": null,
        "value": 0.001
    },
    "seed": {
        "desc": null,
        "value": 0
    },
    "team": {
        "desc": null,
        "value": "wsense"
    },
    "model": {
        "desc": null,
        "value": "mae_vit_base_patch16"
    },
    "title": {
        "desc": null,
        "value": "CounTR_finetuning_paper"
    },
    "wandb": {
        "desc": null,
        "value": "counting"
    },
    "_wandb": {
        "desc": null,
        "value": {
            "t": {
                "1": [
                    1,
                    41,
                    55,
                    63
                ],
                "2": [
                    1,
                    41,
                    55,
                    63
                ],
                "3": [
                    2,
                    13,
                    15,
                    16,
                    23
                ],
                "4": "3.9.15",
                "5": "0.13.9",
                "8": [
                    5
                ]
            },
            "framework": "torch",
            "start_time":<PHONE_NUMBER>.966494,
            "cli_version": "0.13.9",
            "is_jupyter_run": false,
            "python_version": "3.9.15",
            "is_kaggle_kernel": false
        }
    },
    "device": {
        "desc": null,
        "value": "cuda"
    },
    "epochs": {
        "desc": null,
        "value": 1000
    },
    "gt_dir": {
        "desc": null,
        "value": "gt_density_map_adaptive_384_VarV2"
    },
    "im_dir": {
        "desc": null,
        "value": "images_384_VarV2"
    },
    "min_lr": {
        "desc": null,
        "value": 0
    },
    "resume": {
        "desc": null,
        "value": "./data/out/pretrain/checkpoint__pretraining_299.pth"
    },
    "log_dir": {
        "desc": null,
        "value": "None"
    },
    "pin_mem": {
        "desc": null,
        "value": true
    },
    "dist_url": {
        "desc": null,
        "value": "env://"
    },
    "wandb_id": {
        "desc": null,
        "value": null
    },
    "anno_file": {
        "desc": null,
        "value": "annotation_FSC147_384.json"
    },
    "data_path": {
        "desc": null,
        "value": "./data/FSC147/"
    },
    "accum_iter": {
        "desc": null,
        "value": 1
    },
    "batch_size": {
        "desc": null,
        "value": 8
    },
    "class_file": {
        "desc": null,
        "value": "ImageClasses_FSC147.txt"
    },
    "local_rank": {
        "desc": null,
        "value": -1
    },
    "mask_ratio": {
        "desc": null,
        "value": 0.5
    },
    "output_dir": {
        "desc": null,
        "value": "./data/out/finetune"
    },
    "world_size": {
        "desc": null,
        "value": 1
    },
    "dist_on_itp": {
        "desc": null,
        "value": false
    },
    "distributed": {
        "desc": null,
        "value": false
    },
    "num_workers": {
        "desc": null,
        "value": 10
    },
    "start_epoch": {
        "desc": null,
        "value": 0
    },
    "weight_decay": {
        "desc": null,
        "value": 0.05
    },
    "norm_pix_loss": {
        "desc": null,
        "value": false
    },
    "warmup_epochs": {
        "desc": null,
        "value": 10
    },
    "data_split_file": {
        "desc": null,
        "value": "Train_Test_Val_FSC_147.json"
    }
}

Does it sound reasonable? Maybe you run a fine-tuning with the large MAE?
Thanks in advance

Hello, I am also confused why the checkpoints everyone gets are smaller than the ones I provided. I didn't use mae_vit_large_patch16 in finetuning(at least I didn't know if I used it). And according to issue #7, he output the value.size() and value.dtype of the model part in his checkpoint and mine, and found that they are the same. Therefore, I guess it might be due to the different versions of some libraries that the parameters such as optimizer are not saved. You can try to output and compare the parameters in the two checkpoints, and check whether the two are consistent.
For the results, the results in the paper are the best results I got, and I think a MAE between 12~13 is OK for mae_vit_base_patch16. The reproducing result of issue #7 is MAE: 13.89, RMSE: 82.74 and he ran my checkpoints and got a result of MAE: 12.44, RMSE: 89.86. So the results are not very different.
Hope my description can help you find the problem.


Implement the mechanism to configure dockercfg secret as imagePullSecrets for devworkspace

In the scope of https://github.com/eclipse/che/issues/18990 Dashboard is going to create dockercfg in the DevWorkspace namespace.
It's needed to implement the mechanism to use such secret as imagePullSecret.
Possible alternatives:

secret is labeled with something like controller.devfile.io/secret-kind: imagePullSecret
devworkspace operator lists and mounts all available dockercfg secrets to the devworkspace pods.
something else

PR is in place https://github.com/devfile/devworkspace-operator/pull/284


Question about the initial weight.

Hi @yichen928 ,
SparseFusion is really a nice work, but I wonder how did you obtain the initial weights: sparsefusion_voxel0075_SwinT_initial and sparsefusion_voxel0075_R50_initial?

Hi,
Thanks for your interest. Both checkpoints are merged by the pretrained weights of LiDAR and camera parts separately.
For both checkpoints, the LiDAR part is a pretrained LiDAR-only detector TransFusion-L, provided by the authors of DeepInteraction (https://drive.google.com/file/d/1IaLMcRu4SYTqcD6K1HF5UjfnRICB_IQM/view?usp=sharing). The backbone, FPN, and head are all incorporated into our initial weights.
For "sparsefusion_voxel0075_R50_initial", the ResNet-50 backbone and FPN is from Mask-RCNN pretrained on nuImage (https://download.openmmlab.com/mmdetection3d/v0.1.0_models/nuimages_semseg/mask_rcnn_r50_fpn_coco-2x_1x_nuim/mask_rcnn_r50_fpn_coco-2x_1x_nuim_20201008_195238-b1742a60.pth).  For "sparsefusion_voxel0075_SwinT_initial", the Swin-T backbone and FPN is further finetuned by us on nuImages from the pretrained weights (https://download.openmmlab.com/mmdetection/v2.0/swin/mask_rcnn_swin-t-p4-w7_fpn_1x_coco/mask_rcnn_swin-t-p4-w7_fpn_1x_coco_20210902_120937-9d6b7cfa.pth).
You may need to change some parameter names when merging the LiDAR and camera parts to get our initial weights.


Add TravisCI

We should use TravisCI within this bundle.

We are using travis now so let's close this one.


Force admin users to use 2FA for an organization

User story
As an organization owner, I want to force all people who can approve expenses and invoices to use 2FA / TOTP
Best solution for this problem
A setting on the organization that forces admin level users to enable 2FA when they next log in.
MVP
A really MVP way of doing this would be to just show that other users have 2FA enabled on their account, so that admin can nag them to enable and know that they have it enabled before promoting the other user to "admin".
A toggle on a settings page that enables this feature, and then a flow for requiring existing admin, on new log in, to enable 2FA on their account.
Metrics
Better security for users.
Documentation
We should add documentation about this feature in the organization admin documentation, with examples of what the flow will look like for new users.

Triage Template (team only)
This template is for members of the team to triage for prioritisation. For more guidance see https://www.loom.com/share/369ab467fbc64dec848085d38ff57ca0:
P1 high frequency, high impact
P2 low frequency, high impact
P3 high frequency, low impact
P4 low frequency, low impact
Examples of high impact - a problem affects users during an essential process (expenses and payments > onboarding and registration > contributing) with no workaround.
High frequency - >10% of users affected (measured as a proportion of total potential users for this case).

agreed. would really help me sleep at night and avoid cumbersome work of chasing people down to verify this.

Big +1 on this one. It's actually a problem we share for admins of https://opencollective.com/opencollective, who get a lot of additional permissions. We have a setting to enforce 2FA for payouts, but that's not enough. You can do a lot of harm outside of payouts just by being an admin of an account: refund payments, make new financial contributions, remove other admins, etc.
Because it's tedious and error-prone to cover all these features one by one, I would propose the following UX:

Account admin checks a box like "Require all admins to enable 2FA"
All admins on the account that don't have 2FA enabled instantly get their account deactivated and receive an email with some instructions to move forward
If they click the link in the email or try to sign in, they're prompted with an "Enable 2FA" screen, and their profiles get reactivated

On top of that:

Your account should be deactivated when you disable 2FA while one of the accounts you administrate requires it. There should be a decent warning on the page to let you know about that in advance.
If you get removed as an admin and none of the accounts you administrate requires 2FA, your account should be re-activated

sounds like I might be able to deny someone service if a policy for one affects all user accounts attached. maybe instead we disable the member's priv's on the accounts that they require 2FA for instead?

block admin rights on collectives that require 2FA for all users that do not have 2FA enabled
redirect those who hit a admin-only page (say they've bookmarked a page) to the 2FA page in their settings with some information as to why they're here _Collective XYZ requires 2FA for administrators, follow the steps below to enable 2FA'
highlight elsewhere that this collective requires 2FA and that you need to enable it to perform some actions (i.e. on the Collective's page)
provide a highlight alongside the 2FA settings menu icon, with some information on that page 'Some of your collectives require 2FA, follow the steps below...'

how does that sound @betree?

That's indeed a nicer UX to not block everything just because one of the orgs you administrate requires you to enable 2FA. Works for me!

For consistency in project management, would be great to create a project board for the project. See https://github.com/opencollective/opencollective/projects/77 and https://github.com/opencollective/opencollective/projects/78 for example with other projects.

The kickoff for this project is planned for Thursday. We'll also investigate the specs for https://github.com/opencollective/opencollective/issues/5998 as a stretch goal to see if it's feasible to include it alongside this one.
A project board for 2FA has been created on https://github.com/opencollective/opencollective/projects/80.

@flowofficial We haven't discussed this topic yet, but there are some related ones: #1738 #5294. It's however out of scope for this issue, which is about enforcing an existing feature on more profiles. I suggest opening a new issue if you think we're missing something.

Kickoff notes
Goals for this sprint

[ ] The "Two-factor Authentication" entry in the admin menu looks too specific. We think it should be renamed to "Security", and "Two-factor Authentication" should be a subcategory there.
[ ] Implement a checkbox in this Admin > Security > Two Factor Authentication section like "Enforce all admins in my organization to have 2FA setup". We should ideally store this as a Policy in the API (re-use existing field). @opencollective/design welcome here
[ ] When the checkbox is checked, we should block the admin page for host admins with a message saying something along the line of "Your organization requires 2FA to be enabled on your account, click here to start the setup". @opencollective/design required here.
[ ] We'll also need to make sure protected mutations return a clear error. For example, when trying to Approve an expense from the expense page while 2FA is not enabled on your account, the message should say something similar to the above, with a link to enable 2FA on your account.
[ ] Create a Metabase dashboard to track:

How many fiscal hosts enable "Enforce 2FA"
How many/percentage of host admins who have 2FA enabled

[ ] Stretch goal: https://github.com/opencollective/opencollective/issues/5998. We documented some more actions that we would like to see covered by 2FA. Any step we can make toward better supporting this is welcome!

We should keep #5294  in mind while implementing all this.
Long-term & follow-up
We think that Open Collective should enforce some best practices for host admins, and we could decide to force all fiscal hosts to enable 2FA given the powerful features they can access - similarly to how bank apps don't let you the choice of enabling 2FA or not, it's a requirement. It's a long path to get there where education is key (fiscal host admins are not necessarily tech-savvy), but we should already think about:

Display warnings in the interface (admin dashboard, expense page, etc) to recommend the use of 2FA
Overall, communicating about that with host admins everywhere it makes sense (e.g. onboarding)
Making sure our documentation for 2FA is accessible and easily understandable

I have caught up with the recording and the documentation. I expect to have everything this project needs within this week.
A summary of what I'm doing

Design the 'Security' page in host settings (Works for other profiles)
Update the 'Policies' page in host settings (Works for other profiles)
Alerts: "Be aware that your organization is at risk; consider enabling 2FA."
Block admin rights screen
Updating the styleguide we use inside settings (I detect many accessibility issues that we can solve by better use of text, I will post a global update that should impact all settings pages).

cc @Betree @hdiniz

Update the 'Policies' page in host settings (Works for other profiles)

@Memo-Es what do we need to update inside this one? My understanding was that we were going to add the 2FA checkbox under this "Security" menu.
The rest looks good!

@Betree, I understand we are putting in 'Security' some stuff from the 'Policies' page like the minimum admins requirement, and the admin cannot approve their own expense.

Just a note to say that, depending on how https://github.com/opencollective/opencollective/issues/5998 goes, we may implement the MVP with the initially proposed solution of completely blocking the account at the sign-in step.
If we're not ready to protect all important mutations with 2FA, then we should make sure there's no way for admins without 2FA to do anything until they activate it.
Making sure we cover all mutations is a complex task, but blocking only the sign-in step is easy.

I understand we are putting in 'Security' some stuff from the 'Policies' page like the minimum admins requirement, and the admin cannot approve their own expense.

@Memo-Es I will strongly advocate against that. We mentioned it in the past, these two are not security features at the moment as they can easily be bypassed by adding or removing other admins. There's already some confusion around that so we should make sure we do not advertise them as security features. They're just policies.
In the future, when (if?) we make sure these are secure (i.e. by not letting your add/remove admins without others' confirmations) then yes, we'll be able to move them to the security tab.

aiming to complete this week, working on pr which will require review

ready for review ✌ may be subject to some iteration this week, otherwise ✅

Docs issue - https://github.com/opencollective/opencollective/issues/6155
Release issue - https://github.com/opencollective/opencollective/issues/6156

You aren't able to click on the check boxes, you have to click on the enter square to make the tick box check

Also, should the rolling payouts be showing in the collective settings? This should only be showing for fiscal hosts?

You aren't able to click on the check boxes, you have to click on the enter square to make the tick box check

@shannondwray Good catch, fix incoming in https://github.com/opencollective/opencollective-frontend/pull/8422.

Also, should the rolling payouts be showing in the collective settings? This should only be showing for fiscal hosts?

@shannondwray We're not changing this part: rolling limit stays as a setting for fiscal hosts only.

I'm closing this since the project is now released for everyone in production. Feedback issue opened in https://github.com/opencollective/opencollective/issues/6193.

The reason I was mentioning the rolling limit bit was because it was showing in the collective settings

Saw this deployed the other week. Thanks all!!


Fix code coverage metrics

Description
Currently our code coverage metrics are incomplete because they are only capturing what gets covered in the "Sonar Scan" job, not in the matrix of runs across the different database types or OS or JVM versions.
As a result, there is a lot of code which does get exercised by our tests, but will always show as "not covered".
This PR is trying to solve that by running with coverage info across all our different test runs, then in the Sonar job it aggregates that data together and reports on that.

PROBLEMS WITH CURRENT IMPLEMENTATION
This is not capturing any coverage info, because:
Warning:  Classes in bundle 'liquibase-aggregate' do not match with execution data. For report generation the same class files must be used as at runtime.
Warning:  Execution data for class liquibase/sqlgenerator/core/AddColumnGeneratorSQLite$1 does not match.
Warning:  Execution data for class liquibase/serializer/core/string/StringSnapshotSerializerReadable$4 does not match.
Warning:  Execution data for class liquibase/serializer/core/string/StringSnapshotSerializerReadable$1 does not match.
Warning:  Execution data for class liquibase/serializer/core/string/StringSnapshotSerializerReadable$2 does not match.
Warning:  Execution data for class liquibase/serializer/core/string/StringSnapshotSerializerReadable does not match.
Warning:  Execution data for class liquibase/serializer/core/string/StringSnapshotSerializerReadable$3 does not match.
....

in Sonar Scan -> Sonar Analyze -> mvn jacoco:report.
Each run of the tests stores the "jacoco.exec" binary formatted file because that has the level of detail to later merge together. Like some lines of InsertDataGenerator are ran in the "unit" test runs, other lines are ran when oracle or mysql or whatever is enabled when the tests are ran. The final coverage needs to be the union of all that info. Jacoco:merge should be doing that correctly.
BUT: sonar can't read the exec format, only the XML report format. So we run jacoco:report on the merged exec. But jacoco:report needs the class files that were tested and EXACTLY the class files that were tested. If they're different (like compiled from source with a different JVM version or a different OS) it doesn't report any coverage.
I tried to make it grab the pre-built code which should have been used for the different tests runs, but it's thinking there's a difference still. I deleted out the exec files that I expect to be different (non-ubuntu, non-java-8) but it's still not working.
Maybe there's a simple problem in my logic? I don't see it so am leave it alone for now and posting this as a draft.
My best suggestion is to circle back to this as part of the larger build refactoring project we're looking at -- better bake in that we build liquibase once and then test that jar and report on that jar. Never re-compile the production code again.


Error after version 1.2.6 with nested properties

Hi, I Found that after version 1.2.6 filters by nested fields like "Person.Name" stopped working.
I was debugging and I find that the error is in line 128 of QueryBuilder.cs, Query in filteredResults throws the next error
https://github.com/tghamm/dynamic-linq-query-builder/blob/d177fff0632dd754eeb83f5d2ef55c7cc4e5d926/Castle.DynamicLinqQueryBuilder/QueryBuilder.cs#L128
'((Microsoft.EntityFrameworkCore.Query.Internal.EntityQueryable)filteredResults).DebugView.Query' threw an exception of type 'System.InvalidOperationException'
I guess the error is caused by including (Not((item.Account == null)) AndAlso in expression

Hi @liacolo here's a unit test that uses EF Core and uses nested filtering and passes.  Can you provide some additional information about what you're seeing?
https://github.com/tghamm/dynamic-linq-query-builder/blob/094d60563384221aea66cc635a4db6736a3d31b5/Castle.DynamicLinqQueryBuilder.Tests/ORM/ORMTests.cs#L127-L153

Hi @liacolo this may be an issue with the way you've written the query.  EF Core doesn't eager load, and you're transforming the result with a Select to a DTO before you filter.  For this to work correctly, I'd expect you'd either need to Include, or use BuildQuery directly on the EF graph before you Select it out to a DTO, though even then I suspect you'd need to Include because of the depth.  Are you saying that this is a new behavior though in 1.2.6/1.2.7?

Hi, thanks for your response.
I'm transforming with Select before calling BiuldQuery because I need to be able to filter by some calculated fields. This used to work fine before version 1.2.6. After updating to 1.2.6+ the same query started to fail.
In the next example we want to filter by Person.Id and/or CreditCardExpirationDate :
context.MyObject.select(s => new myObjectDto {
Id = s.Id,
Person = new PersonDto
  {
  Description = s.Person.Description,
  Id = s.Person.Id,
  CreditCardExpirationDate = s.PaymentMethod != null && (s.PaymentMethod is CreditCard) ? ((CreditCard)s.PaymentMethod).ExpirationDate : System.DateTime.UtcNow
  }
} )

@liacolo thanks for the detailed example.  Can you tell me what version of EF Core/.Net/SQL you're using?  I'll likely just revert the change made in 1.2.6 that caused this, but I'd like to be able to reproduce it locally first just so I know that I've gotten it worked out for sure.  Thanks!

We are using EF core/EntityFrameworkCore.SqlServer 6.0.4 and .NET 6.0.
Let me know if you can reproduce it. Thanks

@liacolo this should be addressed now in the latest release.  Check out the release notes if you need to query for null checks in CLR objects, which is what was introduced in 1.2.6.  In any case, 1.2.8 should return the 1.2.5 behavior you had, along with the CultureInfo benefits you got in 1.2.7.  Let me know if you run into any issues.  Thanks for your help.

Ok I'm already applying the new version for testing. Thank you very much again for helping us.

Hello, I tested the new version but the error persists when filtering by a collection of values, for instance, with the in operator and a collection of strings as value. I was debugging the code and found that in BuildNestedExpression AndAlso is still being added in this case.
https://github.com/tghamm/dynamic-linq-query-builder/blob/8187d4f3c35a8f8f4ee7178365d1ab8fac116e1e/Castle.DynamicLinqQueryBuilder/QueryBuilder.cs#L303

Gotcha, it looks like another case of attempting to do the same thing.  This should be a fairly straight forward fix, but if possible, can you lay out a test case for me?  I'm having trouble getting a reproduction case, despite it being pretty obvious which change is responsible for the regression. Thanks!

Also, some of these EF specific cases don't pop up in unit tests and sneak through, apologies for the inconvenience.

I Think you can use the same store and products case. Searching one store by product Name in it.
 var storeFilter = new QueryBuilderFilterRule
            {
                Condition = "and",
                Rules = new List<QueryBuilderFilterRule>
                {
                    new QueryBuilderFilterRule
                    {
                        Condition = "and",
                        Field = "Products.ProductName",
                        Id = "Products.ProductName",
                        Input = "NA",
                        Operator = "in",
                        Type = "string",
                        Value = new[] { "Car Tire" }
                    }
                }
            };

@liacolo ok, was able to reproduce.  Are you in a position to test off of the master branch directly?  I can either wait for you to test to confirm we're good, or issue a new release, but this pretty much optionalizes all changes between 1.2.5 and now except the CultureInfo changes.  I just pushed code that should fix it, let me know your preference re: testing.  Thanks!

I tested with the master branch and it seems to be working fine. Thanks!

Great, I'll put out a release tonight or tomorrow morning, appreciate your assistance working through it.

New release issued, thanks again, feel free to raise another issue if you find anything else!


A newer migration strategy with moved blocks

We are migrating from v17 to v18. Given that we have now moved blocks, can we some how have an adapted solution to this issue?
Especially a solution that does not involve "forget"ing and draining the old EKS MNG as this wouldn't be feasible for us as we have close to 300 EKS clusters

you can use moved blocks if you wish, but its not something that will be defined here since most of that content will be specific to individual use cases