install instructions are not clear

(Mandatory) Create the install package
cd earthenterprise/earth_enterprise
scons -j8 release=1 stage_install
expected :
cd earthenterprise/earth_enterprise/src
what is "stage_install" mean ?  - It would be good to have an explanation for the same

install wiki -  https://github.com/google/earthenterprise/wiki/Install-Fusion-or-Earth-Server

I believe that this is intended (i.e. correct as written) after merging of https://github.com/google/earthenterprise/commit/8a2b5a67ef65b15c4d20d9ada2333bd82ca64d23
@tst-lsavoie can probably clarify.

Yes, @asmitaw, this change is intentional. It simplifies the build instructions by eliminating constant directory changes. The easiest way to do this was to bring everything to the top level scons file. The build steps were reduced from 2 steps to 1. The install steps were reduced from 3 steps to 1. See #131.
We can add add more explanation as to what stage_install means. We actually discussed this a good bit. We couldn't really come up with a good word to describe what scons is doing. It's not actually installing because there is another step after the scons target to run the install scripts. We finally settled on the less than perfect "stage_install". However, the "install" target still works.


change react-dom from devDependency to dependency

Since #1209, we import react-dom explicitly, so maybe it should be put into dependencies instead of devDependencies.
Put it in devDependencies will confuse some plugins of build systems (e.g. Webpack), makes them think react-dom is not needed for react-redux.

Appreciate the PR, but no, this is not correct.
Because of how the renderers export unstable_batchedUpdates, we're in a weird situation where we have to import from react-dom, but allow the RN loader to fall back to the RN package instead when used with RN.
Adding react-dom as an explicit dependency would break that, and also force an extra download for all RN users.

We need react-dom for deploying react-redux, at least it appears when we run npm run build:umd.
Would it be acceptable to be peerDependencies or optionalDependencies?

Also no.  We don't want to be RN users to be getting warned when they install React-Redux but not ReactDOM.  And, since we build the UMDs ourselves as part of the dev process, that's already handled under devDependencies.
I know it's quirky, but what we have now works.

It can be an optional peer dependency. In that case, users will not be warned about it. Optional peer dependencies are supported by yarn, pnpm and will be supported in npm in the next minor version (thanks to @arcanis)


[Security] Add adaptive_network_hardenings commands

Description
[Security] Add Adaptive network hardeningss commands
Add Adaptive network hardenings commands, list of all possible traffic between resources for the subscription and location.
Testing Guide
Users can get a list, single (show) of list of Adaptive Network Hardening resources:
az security adaptive_network_hardenings list --resource-group 'RG1' --resource-type 'virtualMachines' --resource-namespace 'Microsoft.Compute' --resource-name 'VM1'
az security adaptive_network_hardenings show --resource-group 'RG1' --resource-type 'virtualMachines' --resource-namespace 'Microsoft.Compute' --resource-name 'VM1' --adaptive-network-hardenings-resource-name 'default'
Tests are included, use:  azdev test security test_adaptive_network_hardenings --live
This checklist is used to make sure that common guidelines for a pull request are followed.

[*] The PR title and description has followed the guideline in Submitting Pull Requests.

[*] I adhere to the Command Guidelines.

Security

@haroldrandom, thank you for your guidance, please consider my last commit

deletig the .gitignore is unacceptable. Please revert it.
@haroldrandom,  Done, sorry about that :-)

/azp run


Bug in footer resolved

📋 Description
The social media icons now direct the user to another tab on clicking.
🔨 Changes Made

-The social media icons in the footer of the campground, login and register page direct the user to another tab upon clicking
✅ Checklist
Before submitting the PR, please make sure you have completed the following:

[yes ] My code follows the style guidelines of this project.
[yes ] I have performed a self-review of my own code.
[yes ] I have commented my code, particularly in hard-to-understand areas.
[yes ] I have made corresponding changes to the documentation (if applicable).
[yes ] My changes generate no new warnings.
[yes ] I have tested it locally and it works fine.
[yes ] Any dependent changes have been merged and published in downstream modules.

🏷 Types of Changes
What type of changes does your code introduce? (Check all that apply)

[yes ] Bug fix (non-breaking change which fixes an issue) 🐛
[ ] New feature (non-breaking change which adds functionality) ✨
[ ] UI enhancement (non-breaking change which enhances UI) 🎨
[ ] Documentation update 📚

🤝 Related Issues

Fixes #270

📸 Screenshots (if applicable)

Reminder:
Please ensure your pull request is made to the test branch, not main.
Thank you for contributing to VigneshDevHub! We look forward to reviewing your PR and getting it merged!

Thankyou for Contributing!


DroneCore Application template

We don't have a standard layout for applications yet. If you have a look at any Android application for eg, it has a layout something like,
public class BasicClickHandlersActivity extends Activity {

@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_basic_click_handlers);
Button secondButton = (Button) findViewById(R.id.btnClick2);
secondButton.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
secondButtonClicked(v);
}
});
}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
// Inflate the menu; this adds items to the action bar if it is present.
getMenuInflater().inflate(R.menu.activity_basic_click_handlers, menu);
return true;
}
}

Its more clear for reader to visualize application's activity. Its clear that onCreate() is the entry point and application's business logic goes into one these callbacks.
All DroneCore applications primarily deal with discovered device.
Note: I use term device until we merge code containing System terminology.
So, application won't do anything without device discovery. If there's no device discovered for 3 seconds, DroneCore fires timeout callback. So, its convenient if we layout a DroneCore application template similar to a below one:

And, names on_discover(), on_timeout() seems more natural than register_on_discover(), etc.
Kindly share your thoughts on it.
Thanks.

We support this paradigm obviously, but there is a reason why promises (as used in our examples) have become a popular tool for managing async behaviour. I think our examples are more clear than this - certainly more clear than this would be if expanded into a full application.

And, names on_discover(), on_timeout() seems more natural than register_on_discover(), etc.

I slightly agree.

Closing this for now. We'll have example applications such as the Swift example which show how to use the SDK.


Cloud Pak for Data--Data Fabric TechZone ATK Collection -https://techzone.ibm.com/collection/data-fabric-automation-on-aws-azure-and-ibm-cloud

This issue refers to Data Fabric Automation and its alignment to See It, Learn It, Do it journey in Tech Zone. The readiness status: asset collection aligned to each journey is complete and is under review by Matt for final sign off and release. Following assets have been created and aligned to user journey.
Business Value
See It
Introduction video
Data Fabric Concept videos
Documentation

Learn It
Videos
Sales Kits
Use Cases

Do It
Video
Installation Instructions
Deployment Guide
Read Me
Link to Automation with Cluster Reservations

Resources
Analyst Report by Forrester
Competitive PoV
Demo Collection
Blog

TechZone Accelerator Toolkit content on TechZone for Data Fabric Automation is complete.  Currently, under review and approval by Matt.


Add Newsletter Section to Footer

Description
We need to add a newsletter section to the footer to allow users to subscribe to updates and stay informed about our latest news and releases.
Actual Behavior
There is currently no newsletter section in the footer.
Expected Behavior
A newsletter section is present in the footer with an email input field and a "Subscribe" button. It validates email input and displays success or error messages as appropriate.
Steps to Reproduce (if applicable)
Visit the website.
Scroll to the footer.
Observe the absence of a newsletter section.
Screenshots (if applicable)
Actual:

Expected (highlight the part that requires changes):
(screenshot)

@itsmohit097  I want to work on this issue. Also, please add the label GSSOC and the level that you find appropriate for this issue. thank you!


Bug: Incomplete documentation for setting up on k3os, when using default bios date

Documentation is missing solution to solve certificate errors, related to certificate date being in the future, on manual deployment.
Expected Behavior
k3os should be able to start, when following docs/getting-started/setup-development/
Current Behavior
k3os reports errors, due hardware date being in the past. (ex: 01.01.2017)
Possible Solution
Load cloudconfig with added ntp_servers on OS install.
Steps to Reproduce

Install k3os, without updating BIOS clock
Install UMH
helm will fail on Install factorycube-server step, due to outdated certificates.

Detailed Description

Add documentation detailing how to load cloud config from http server.
Add sample config, with added k3os->ntp_server keys.

important: do not use HTTPS to host cloudinit file as you will get the same issue.


support scale marsjob workers by 'kubectl scale'

Update: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#scale-subresource
Worker is embedded in a map type which json-path does not support yet.


[CELEBORN-1629] Support to apply ratis election operation with RESTful api

What changes were proposed in this pull request?
As title, sub task of CELEBORN-1628
Why are the changes needed?
It is more friendly for customer experience and necessary for automation integration.

Before restart/recreate the celeborn master pod

call the  ratis/snapshot/create to create the snapshot(will raise another PR for this)
if need to failover

call the ratis/election/pause to pause the election
call the ratis/election/step_down or ratis/election/transfer to transfer the leadership
call the ratis/election/resume to resume the election finally

Does this PR introduce any user-facing change?
Introduce new RESTful apis.
How was this patch tested?
election transfer:

election pause and resume:

election step down:

+CC @akpatnam25 FYI for CLI

It is done for ratis election apis.
cc @mridulm

cc @AngersZhuuuu I saw that you add the docs for ratis-shell.
also cc @waitinfuture @RexXiong

Could you also add the usage of the Ratis REST API in https://celeborn.apache.org/docs/latest/celeborn_ratis_shell

Sure, will add it later

Thanks. merge to main(v0.6.0)


STYLE: Use nullptr for isSpecialCoordinatesImage in ResampleImageFilter

Explicitly compares results of dynamic_cast to nullptr, when
estimating isSpecialCoordinatesImage, in ResampleImageFilter.
Fixes a Visual Studio 2017 Code Analysis warning:

warning C26477: Use 'nullptr' rather than 0 or NULL (es.47).

Thanks for your approval and merge, @dzenanz
For the record, although it seems reasonable to me that the original code triggered a compiler warning, the one from VS2017 Code Analysis doesn't seem entirely appropriate:

warning C26477: Use 'nullptr' rather than 0 or NULL

It seemed to suggest that the original code was using 0 or NULL, which wasn't the case! The same warning (misplaced, in my opinion) occurs for this code:
struct A
{
    virtual ~A() = 0;
};

struct B: A {};

int main()
{
  A* p = nullptr;
  bool b = dynamic_cast<B*>(p); // warning C26477: Use 'nullptr' rather than 0 or NULL
}

As I observed at https://godbolt.org/z/cjR8_M


net/http: Transport wastes TLS handshake progress

What version of Go are you using (go version)?

$ go1.16 version
go version go1.16.13 darwin/arm64

$ go1.17 version
go version go1.17.6 darwin/arm64

$ go1.18 version
go version devel go1.18-41f485b9a7 Mon Jan 31 13:43:52 2022 +0000 darwin/arm64
# aka go1.18beta2

Does this issue reproduce with the latest release?
Yes, this is present in the latest stable release, go1.17.6, and the latest tagged beta. It is not present in go1.16.13. It was introduced by the work for #32406.
What operating system and processor architecture are you using (go env)?
go env Output
$ go1.17 env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/rhys/Library/Caches/go-build"
GOENV="/Users/rhys/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/rhys/go/pkg/mod"
GONOPROXY="*"
GONOSUMDB="*"
GOOS="darwin"
GOPATH="/Users/rhys/go"
GOPRIVATE="*"
GOPROXY="direct"
GOROOT="/Users/rhys/go/version/go1.17"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/rhys/go/version/go1.17/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.17.6"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/lf/n4ry0qv5639_3z0nhyhy3z7c0000gs/T/go-build3534659518=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
An application I work with uses net/http to make outbound requests over HTTP/1.1+TLS. It uses Context values to control the lifecycle of those requests and to set timeouts. It cleans up the Context values (to avoid leaking timers, as recommended by go vet) when the outbound HTTPS call is complete.
Here's an overview of the most relevant code:
func callWithTimeout(ctx context.Context) {
    ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
    defer cancel()
    doRequest(ctx) // uses net/http package for HTTPS call several layers down
}

I've included a full reproducer at the bottom, also available at https://go.dev/play/p/_vg00gqqbpG although the Playground's network stack messes slightly with the results.
What did you expect to see?
I expected that code pattern (use Context to set a timeout, clean up immediately after the call) to be a best practice. I expected it to lead to efficient use of compute resources. I expected it to provide good performance (not much unnecessary latency).
What did you see instead?
After upgrading the application from from Go 1.16 to Go 1.17, the load balancer in front of the HTTPS service this application calls saw about a 4x increase in the volume of inbound TLS handshake requests, while reporting no change in the typical number of concurrent connections. A 4x increase in TLS handshake volume for this service is enough to throw off capacity planning.
The reproducer shows that canceling the Context value that was used for a request that is now complete causes harm to the connection pool. It shows that when a request finds an empty pool and so triggers creation of a new connection, the link between the request that triggered the new connection outlives the request's need for that specific connection.
When another request to the same backend completes and makes its connection available in the Transport's pool, the request that triggered a new dial may use the now-idle connection instead. That allows the request to complete even before the connection it triggered is ready.
All recent Go versions include that link when executing a TCP handshake, leading to some TCP connections being closed as soon as they become ready thereby wasting the work of the DNS lookup and TCP handshake. New in Go 1.17 is an additional link to the TLS handshake, allowing that more-expensive work to be discarded. From the reproducer:
	// New in Go 1.17 via https://golang.org/issue/32406, Go's HTTP client
	// connection pool now also discards useful progress on outbound TLS
	// handshakes.
	//
	// At t=0ms, the first request triggers a new connection
	// At t=0ms, the TCP handshake for the first connection is complete and the TLS handshake begins
	// At t=200ms, the TLS handshake completes and the first HTTP request begins
	// At t=250ms, the first HTTP request completes and the first connection enters the idle pool
	// At t=400ms, the second request removes the first connection from the idle pool
	// At t=420ms, the third request finds an empty pool and dials a second connection
	// At t=420ms, the second connection TLS handshake begins
	// At t=450ms, the second HTTP request completes and hands its connection to the pool
	// At t=450ms, the third request intercepts the first connection before it enters the pool
	// At t=500ms, the third HTTP request completes and returns to the application code
	// At t=500ms, the application code has the full HTTP response, so cancels its Context
	// At t=500ms, Go 1.17's call to tls.Conn.HandshakeContext aborts
	// At t=620ms, Go 1.16's call to tls.Conn.Handshake completes, and goes into the idle pool
	// At t=800ms, the fourth request removes the first connection from the idle pool
	// At t=800ms, the fifth request uses an idle connection (Go 1.16) or dials fresh (Go 1.17+)
	t.Run("minimal pool with slow TLS", varyCancel(
		2,                    // ideal pool size
		0,                    // delay in TCP
		200*time.Millisecond, // delay in TLS
		50*time.Millisecond,  // delay in HTTP
		[]time.Duration{
			0,                      // t=0 ms     create connection 1
			400 * time.Millisecond, // t=400 ms   use warm connection 1 until t=450
			20 * time.Millisecond,  // t=420 ms   trigger new connection 2 (BUG: work may be discarded!)
			380 * time.Millisecond, // t=800 ms   observe pool size (use 1)
			0,                      // t=800 ms   observe pool size (use 2, or dial 3)
		}))

With Go 1.17+, the idle pool remains smaller than what the application needs in the steady state. More requests find an empty pool and need to wait for a connection to become available (generally winning in the race against a freshly-dialed connection). The reproducer shows an increase to the average request duration, though I haven't measured that in a production setting. (TLS handshakes are expensive, not slow.)
 All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

package main

import (
	"context"
	"crypto/tls"
	"fmt"
	"io"
	"io/ioutil"
	"log"
	"net"
	"net/http"
	"net/http/httptest"
	"sync"
	"sync/atomic"
	"testing"
	"time"
)

func TestHTTPDialCancel(t *testing.T) {
	withServer := func(tcpDelay, tlsDelay, httpDelay time.Duration, fn func(srv *httptest.Server)) (int, int, int) {
		var (
			tcpDialCount      int32
			tlsHandshakeCount int32
			httpHandleCount   int32
		)

		srv := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
			atomic.AddInt32(&httpHandleCount, 1)
			time.Sleep(httpDelay)
		}))

		srv.EnableHTTP2 = false

		srv.Config.ErrorLog = log.New(ioutil.Discard, "", 0)

		// Pause for a moment during the handshake so we can see what happens when
		// we cancel the Context of a completed HTTP Request.
		srv.TLS = &tls.Config{}
		srv.TLS.GetConfigForClient = func(chi *tls.ClientHelloInfo) (*tls.Config, error) {
			atomic.AddInt32(&tlsHandshakeCount, 1)
			time.Sleep(tlsDelay)
			return nil, nil
		}

		srv.StartTLS()
		defer srv.Close()

		// Before making any requests, add a delay to the TCP Dialer so we can see
		// what happens when we cancel the Context of a completed HTTP Request.
		srv.Client().Transport.(*http.Transport).DialContext = func(ctx context.Context, network, addr string) (net.Conn, error) {
			atomic.AddInt32(&tcpDialCount, 1)
			time.Sleep(tcpDelay)
			return (&net.Dialer{}).DialContext(ctx, network, addr)
		}
		// Allow a large connection pool
		srv.Client().Transport.(*http.Transport).MaxIdleConnsPerHost = 100

		fn(srv)

		return int(atomic.LoadInt32(&tcpDialCount)), int(atomic.LoadInt32(&tlsHandshakeCount)), int(atomic.LoadInt32(&httpHandleCount))
	}

	doRequest := func(ctx context.Context, srv *httptest.Server, timeout time.Duration) error {
		if timeout > 0 {
			// BUG: canceling the context associated with an already-complete
			// HTTP request leads to an increase in TLS handshake count.
			sub, cancel := context.WithTimeout(ctx, timeout)
			defer cancel()
			ctx = sub
		}

		req, err := http.NewRequestWithContext(ctx, "GET", srv.URL, nil)
		if err != nil {
			return fmt.Errorf("NewRequestWithContext: %w", err)
		}

		resp, err := srv.Client().Do(req)
		if err != nil {
			return fmt.Errorf("Do Request: %w", err)
		}
		defer resp.Body.Close()

		_, err = io.Copy(ioutil.Discard, resp.Body)
		if err != nil {
			return fmt.Errorf("Discard Body: %w", err)
		}

		return nil
	}

	callWithDelays := func(t *testing.T, tcpDelay, tlsDelay, httpDelay time.Duration, delays []time.Duration, timeout time.Duration) (int, int, int, time.Duration) {
		var total time.Duration
		tcp, tls, http := withServer(tcpDelay, tlsDelay, httpDelay, func(srv *httptest.Server) {
			ctx := context.Background()
			var wg sync.WaitGroup
			for _, delay := range delays {
				time.Sleep(delay)
				wg.Add(1)
				go func() {
					defer wg.Done()
					start := time.Now()
					err := doRequest(ctx, srv, timeout)
					if err != nil {
						t.Errorf("HTTP request failed: %v", err)
					}
					atomic.AddInt64((*int64)(&total), int64(time.Now().Sub(start)))
				}()
			}
			wg.Wait()
		})
		return tcp, tls, http, total / time.Duration(len(delays))
	}

	varyCancel := func(poolSize int, tcpDelay, tlsDelay, httpDelay time.Duration, delays []time.Duration) func(t *testing.T) {
		return func(t *testing.T) {
			fn := func(timeout time.Duration) func(t *testing.T) {
				return func(t *testing.T) {
					tcp, tls, http, avg := callWithDelays(t, tcpDelay, tlsDelay, httpDelay, delays, timeout)
					if tcp > poolSize {
						t.Errorf("TCP handshake count; %d > %d", tcp, poolSize)
					}
					if tls > poolSize {
						t.Errorf("TLS handshake count; %d > %d", tls, poolSize)
					}
					if t.Failed() {
						t.Logf("timeout=%s tcp=%d tls=%d http=%d", timeout, tcp, tls, http)
					}
					t.Logf("average duration %s", avg)
				}
			}
			// No timeout, so no context.WithCancel / WithTimeout call
			t.Run("no timeout/cancel", fn(0))
			// Huge timeout, key change is the presence of "defer cancel()" once
			// the outbound request is complete
			t.Run("with timeout/cancel", fn(20*time.Minute))
		}
	}

	// Go's HTTP client connection pool has discarded useful progress on
	// outbound TCP handshakes for several releases.
	//
	// NOTE: this test doesn't work well on the Playground.
	t.Run("minimal pool with slow TCP", func(t *testing.T) {
		t.Logf("NOTE: expect failure here for all recent Go versions")
		varyCancel(
			2,                    // ideal pool size
			200*time.Millisecond, // delay in TCP
			0,                    // delay in TLS
			50*time.Millisecond,  // delay in HTTP
			[]time.Duration{
				0,                      // t=0 ms     create connection 1
				400 * time.Millisecond, // t=400 ms   use warm connection 1 until t=450
				20 * time.Millisecond,  // t=420 ms   trigger new connection 2 (BUG: work may be discarded!)
				380 * time.Millisecond, // t=800 ms   observe pool size (use 1)
				0,                      // t=800 ms   observe pool size (use 2, or dial 3)
			})(t)
	})

	// New in Go 1.17 via https://golang.org/issue/32406, Go's HTTP client
	// connection pool now also discards useful progress on outbound TLS
	// handshakes.
	//
	// At t=0ms, the first request triggers a new connection
	// At t=0ms, the TCP handshake for the first connection is complete and the TLS handshake begins
	// At t=200ms, the TLS handshake completes and the first HTTP request begins
	// At t=250ms, the first HTTP request completes and the first connection enters the idle pool
	// At t=400ms, the second request removes the first connection from the idle pool
	// At t=420ms, the third request finds an empty pool and dials a second connection
	// At t=420ms, the second connection TLS handshake begins
	// At t=450ms, the second HTTP request completes and hands its connection to the pool
	// At t=450ms, the third request intercepts the first connection before it enters the pool
	// At t=500ms, the third HTTP request completes and returns to the application code
	// At t=500ms, the application code has the full HTTP response, so cancels its Context
	// At t=500ms, Go 1.17's call to tls.Conn.HandshakeContext aborts
	// At t=620ms, Go 1.16's call to tls.Conn.Handshake completes, and goes into the idle pool
	// At t=800ms, the fourth request removes the first connection from the idle pool
	// At t=800ms, the fifth request uses an idle connection (Go 1.16) or dials fresh (Go 1.17+)
	t.Run("minimal pool with slow TLS", varyCancel(
		2,                    // ideal pool size
		0,                    // delay in TCP
		200*time.Millisecond, // delay in TLS
		50*time.Millisecond,  // delay in HTTP
		[]time.Duration{
			0,                      // t=0 ms     create connection 1
			400 * time.Millisecond, // t=400 ms   use warm connection 1 until t=450
			20 * time.Millisecond,  // t=420 ms   trigger new connection 2 (BUG: work may be discarded!)
			380 * time.Millisecond, // t=800 ms   observe pool size (use 1)
			0,                      // t=800 ms   observe pool size (use 2, or dial 3)
		}))

	// The impact of discarding useful progress on TLS handshakes is unbounded:
	// A client running Go 1.17 or newer, which creates a context for each
	// request which it cancels when the request is complete, may steadily churn
	// through new TLS connections. It can do this even when its maximum
	// outbound concurrency is below the MaxIdleConnsPerHost limit.
	t.Run("large pool with slow TLS", varyCancel(
		8,                    // ideal pool size
		0,                    // delay in TCP
		200*time.Millisecond, // delay in TLS
		50*time.Millisecond,  // delay in HTTP
		[]time.Duration{
			0,                      // t=0 ms     create connection 1
			0,                      // t=0 ms     create connection 2
			0,                      // t=0 ms     create connection 3
			0,                      // t=0 ms     create connection 4
			400 * time.Millisecond, // t=400 ms   use warm connection 1 until t=450
			0,                      // t=400 ms   use warm connection 2 until t=450
			0,                      // t=400 ms   use warm connection 3 until t=450
			0,                      // t=400 ms   use warm connection 4 until t=450
			20 * time.Millisecond,  // t=420 ms   trigger new connection 5 (BUG: work may be discarded!)
			0,                      // t=420 ms   trigger new connection 6 (BUG: work may be discarded!)
			0,                      // t=420 ms   trigger new connection 7 (BUG: work may be discarded!)
			0,                      // t=420 ms   trigger new connection 8 (BUG: work may be discarded!)
			380 * time.Millisecond, // t=800 ms   use warm connection 1 until t=850
			0,                      // t=800 ms   use warm connection 2 until t=850
			0,                      // t=800 ms   use warm connection 3 until t=850
			0,                      // t=800 ms   use warm connection 4 until t=850
			20 * time.Millisecond,  // t=820 ms   use warm connection 5, or trigger new connection 9 (BUG: work may be discarded!)
			0,                      // t=820 ms   use warm connection 6, or trigger new connection 10 (BUG: work may be discarded!)
			0,                      // t=820 ms   use warm connection 7, or trigger new connection 11 (BUG: work may be discarded!)
			0,                      // t=820 ms   use warm connection 8, or trigger new connection 12 (BUG: work may be discarded!)
			380 * time.Millisecond, // t=1200 ms  use warm connection 1 until t=1250
			0,                      // t=1200 ms  use warm connection 2 until t=1250
			0,                      // t=1200 ms  use warm connection 3 until t=1250
			0,                      // t=1200 ms  use warm connection 4 until t=1250
			20 * time.Millisecond,  // t=1220 ms  use warm connection 5, or trigger new connection 13 (BUG: work may be discarded!)
			0,                      // t=1220 ms  use warm connection 6, or trigger new connection 14 (BUG: work may be discarded!)
			0,                      // t=1220 ms  use warm connection 7, or trigger new connection 15 (BUG: work may be discarded!)
			0,                      // t=1220 ms  use warm connection 8, or trigger new connection 16 (BUG: work may be discarded!)
			380 * time.Millisecond, // t=1600 ms  use warm connection 1 until t=1650
			0,                      // t=1600 ms  use warm connection 2 until t=1650
			0,                      // t=1600 ms  use warm connection 3 until t=1650
			0,                      // t=1600 ms  use warm connection 4 until t=1650
			20 * time.Millisecond,  // t=1620 ms  use warm connection 5, or trigger new connection 17 (BUG: work may be discarded!)
			0,                      // t=1620 ms  use warm connection 6, or trigger new connection 18 (BUG: work may be discarded!)
			0,                      // t=1620 ms  use warm connection 7, or trigger new connection 19 (BUG: work may be discarded!)
			0,                      // t=1620 ms  use warm connection 8, or trigger new connection 20 (BUG: work may be discarded!)
			380 * time.Millisecond, // t=2020 ms  observe pool size (use 1)
			0,                      // t=2020 ms  observe pool size (use 2)
			0,                      // t=2020 ms  observe pool size (use 3)
			0,                      // t=2020 ms  observe pool size (use 4)
			0,                      // t=2020 ms  observe pool size (use 5, or dial 21)
			0,                      // t=2020 ms  observe pool size (use 6, or dial 22)
			0,                      // t=2020 ms  observe pool size (use 7, or dial 23)
			0,                      // t=2020 ms  observe pool size (use 8, or dial 24)
		}))
}

sounds related to https://github.com/golang/go/issues/50657 somehow

CC @neild

+1

@duanmengkk, see https://go.dev/wiki/NoPlusOne.

Would this issue when fixed, improve the latency of the TLS handshakes?

go 1.19.3 has this problem

I think we can't use a dedicated context for the TLS handshake, (at least not with a simple code modification). If user doesn't use idle pool (DisableKeepAlive: true), this will make TLS handshake (within queueForDial) process un-cancellable.
Maybe we can check the connection pool for idle connection, if there're any idle connections, we can skip the dialing process, fasthttp is doing a similar process. The caveats is if the pool get occupied after the check, the call will have to wait a longer time to get an idle connection (instead of trying to dial the remote).
Another solution is adding a DialDelay option, user can choose whether they want to wait a bit longer to prioritize using the idle connection, instead of aggressively dialing the remote host. This might make the implementation a bit more efficient under some load scenarios.

Any update here ?

Is this the same thing as #59017, which was fixed in 1.23?

any update?


Implement policy verification in DFA

This PR provides the missing connection between policy and DFA.

Generate DFA checks and claims by invoking the policy translator. (This step will eventually move to compile time.)
Incorporate the checks into the recipe, run DFA, and validate the checks.

If the recipe violates any aspect of the policy, a PolicyViolation exception is thrown. It is enough to review the second commit eb349ddaade5f07a63ba26d18a615598c3a80bf4. This PR is dependent on https://github.com/PolymerLabs/arcs/pull/5785.

/gcbrun


Instalado/Configurado o Sentry

close #73

Codecov Report

Merging #74 into master will increase coverage by 0.59%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   51.96%   52.56%   +0.59%
==========================================
  Files          10       10
  Lines         229      234       +5
==========================================
+ Hits          119      123       +4
- Misses        110      111       +1

Impacted Files
Coverage Δ

pypro/settings.py
61.66% <80.00%> (+1.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4997a84...4ca4957. Read the comment docs.


Process sim_grasp.py terminates after loading all the scene

I am have been trying to fix this issue where I run sim_grasp.py:
python3 scripts/sim_grasp.py --model data/runs/22-08-10-08-09_dataset\=foo\,augment\=False\,net\=conv\,batch_size\=32\,lr\=3e-04/vgn_conv_7.pt --sim-gui --rviz
Before, I run roscore in another console. All the previous instructions for the rest of the parts have been made. Also trained a model.
With the following output:
pybullet build time: May 28 2020 16:37:34
startThreads creating 1 threads.
starting thread 0
started thread 0
argc=2
argv[0] = --unused
argv[1] = --start_demo_name=Physics Server
ExampleBrowserThreadFunc started
X11 functions dynamically loaded using dlopen/dlsym OK!
X11 functions dynamically loaded using dlopen/dlsym OK!
Creating context
Created GL 3.3 context
Direct GLX rendering context obtained
Making context current
GL_VENDOR=Mesa/X.org
GL_RENDERER=llvmpipe (LLVM 12.0.0, 256 bits)
GL_VERSION=4.5 (Core Profile) Mesa 21.2.6
GL_SHADING_LANGUAGE_VERSION=4.50
pthread_getconcurrency()=0
Version = 4.5 (Core Profile) Mesa 21.2.6
Vendor = Mesa/X.org
Renderer = llvmpipe (LLVM 12.0.0, 256 bits)
b3Printf: Selected demo: Physics Server
startThreads creating 1 threads.
starting thread 0
started thread 0
MotionThreadFunc thread started
ven = Mesa/X.org
ven = Mesa/X.org
100%|█████████████████████████████████████████| 100/100 [15:39<00:00,  9.39s/it]
numActiveThreads = 0
stopping threads
Thread with taskId 0 exiting
Thread TERMINATED
destroy semaphore
semaphore destroyed
destroy main semaphore
main semaphore destroyed
finished
numActiveThreads = 0
btShutDownExampleBrowser stopping threads
Thread with taskId 0 exiting
Thread TERMINATED
destroy semaphore
semaphore destroyed
destroy main semaphore
main semaphore destroyed

I have been trying to see if there was anything wrong with my ros installation. My system is Ubuntu 20.04 (Ubuntu 20.04.5 LTS). I am trying the simulation in VirtualBox, having done the previous parts on a real Ubuntu machine. Might it be something related to the VM?

I am have been trying to fix this issue where I run sim_grasp.py: python3 scripts/sim_grasp.py --model data/runs/22-08-10-08-09_dataset\=foo\,augment\=False\,net\=conv\,batch_size\=32\,lr\=3e-04/vgn_conv_7.pt --sim-gui --rviz
Before, I run roscore in another console. All the previous instructions for the rest of the parts have been made. Also trained a model.
With the following output:
pybullet build time: May 28 2020 16:37:34
startThreads creating 1 threads.
starting thread 0
started thread 0
argc=2
argv[0] = --unused
argv[1] = --start_demo_name=Physics Server
ExampleBrowserThreadFunc started
X11 functions dynamically loaded using dlopen/dlsym OK!
X11 functions dynamically loaded using dlopen/dlsym OK!
Creating context
Created GL 3.3 context
Direct GLX rendering context obtained
Making context current
GL_VENDOR=Mesa/X.org
GL_RENDERER=llvmpipe (LLVM 12.0.0, 256 bits)
GL_VERSION=4.5 (Core Profile) Mesa 21.2.6
GL_SHADING_LANGUAGE_VERSION=4.50
pthread_getconcurrency()=0
Version = 4.5 (Core Profile) Mesa 21.2.6
Vendor = Mesa/X.org
Renderer = llvmpipe (LLVM 12.0.0, 256 bits)
b3Printf: Selected demo: Physics Server
startThreads creating 1 threads.
starting thread 0
started thread 0
MotionThreadFunc thread started
ven = Mesa/X.org
ven = Mesa/X.org
100%|█████████████████████████████████████████| 100/100 [15:39<00:00,  9.39s/it]
numActiveThreads = 0
stopping threads
Thread with taskId 0 exiting
Thread TERMINATED
destroy semaphore
semaphore destroyed
destroy main semaphore
main semaphore destroyed
finished
numActiveThreads = 0
btShutDownExampleBrowser stopping threads
Thread with taskId 0 exiting
Thread TERMINATED
destroy semaphore
semaphore destroyed
destroy main semaphore
main semaphore destroyed

I have been trying to see if there was anything wrong with my ros installation. My system is Ubuntu 20.04 (Ubuntu 20.04.5 LTS). I am trying the simulation in VirtualBox, having done the previous parts on a real Ubuntu machine. Might it be something related to the VM?

Where is the error ? It is completed 100 % successfully

Hi, I also try to synthetic grasping trials in pile scene by using python scripts/generate_data_parallel.py --scene pile --object-set pile/train --num-grasps 400 --num-proc 2 --save-scene ./data/pile/data_pile_train_random_raw_4M, but the terminal show nothing but "pybullet build time: May 28 2020 16:37:34", the file in the data generation is nothing?
I want to ask , is there a problem? How to locate the bug and debug?
Thanks!

It's been 2 years almost so I cannot really say anything right now. I will re-check this repository in the following weeks so hopefully I'll be able to help out @Andyyoung0507

Thanks for your help!


Fix for issue #1136 - Error 500 deleting DB without quorum

Overview
The current behaviour for database deletion in a cluster is:

Database deletion returns 404 - Not found if all nodes respond not found
Database deletion returns 200 - OK if all nodes respond and at least one is ok
Database deletion returns 202 - Accepted if the number of responses met quorum and at least one is ok
Database deletion returns 500 - Error if the responses are bellow quorum

After this PR the behaviour for database deletetion will be:

Database deletion returns 404 - Not found if all nodes respond not found
Database deletion returns 200 - OK if the quorum is met and at least one is ok
Database deletion returns 202 - Accepted if the number of responses are bellow quorum and at least one is ok
Database deletion returns 500 - Error in other cases

Testing recommendations
This PR can be tested in this way
 make test-cluster-with-quorum
 make test-cluster-without-quorum

New test for db deletion is included
Side change in test/javascript/run
I've included a change in test/javascript/run. Now the script does not exit with error if the parameter suites or ignore_js_suites is provided with a value that is not matched with an existing test.
After this PR, it is possible to run make check ignore_js_suites=reduce_builtin or  make check suites=all_docs without getting an error in the new cluster testing targets.
Related Issues or Pull Requests
Fixes #1136

Checklist

[x] Code is written and works correctly;
[x] Changes are covered by tests;
[ ] Documentation reflects the changes;

@rnewson can you review this? You may also want to have a glance at the already merged companion PR, #1127

@rnewson I've done some more testing on the deletion with different cluster conditions. It seems that some .couch files keep orphaned if a database is deleted with one of the nodes of the cluster stopped.

Start 3-node cluster and create test db:

./dev/run -n 3 --with-admin-party-please
curl -X PUT http://<IP_ADDRESS>:15984/test?q=1

One .couch file is created per node

Stop 1 node in the cluster and delete the database

./dev/run -n 3 --with-admin-party-please --degrade-cluster 1
curl -X DELETE http://<IP_ADDRESS>:15984/test

The .couch is removed and persist in the stopped node as expected

Start the complete cluster and check if the database is deleted

./dev/run -n 3 --with-admin-party-please
curl -X HEAD http://<IP_ADDRESS>:15984/test -v

The database is not found but the .couch file is propagated from the restarted node to the rest

It seems that .couch file keeps orphaned in the system after a deletion with at least a node stopped. This PR does not modify this behavior. Do you think, this is an issue?

Thanks for this PR @jjrodrig, very well done.
The orphaned files are a known condition. They are OK from the perspective of database correctness, as a new database created with the same name will have a different creation timestamp and so the old data would not be surfaced. It could be a useful future enhancement to remove orphaned shard files in a background process.
The previous behavior of distinguishing between a majority or minority of committed updates to the replicas of the shard table is not something I'm interested in preserving. I think we can do better.
I do think the use of 202 Accepted as an indicator to the client that "hey, things are a little messy right now, you might see surprises while we work things out" is a good thing. My concern with the current PR is that we may return 200 OK to a user even though some nodes in the cluster still host the old (soon-to-be-deleted) version of the database. For example, consider the following sequence of events:

Cluster experiences a network partition which creates subsets A and B
User submits DELETE /foo to a node in A and receives 200 OK
User submits PUT /foo to a node in A and receives 200 OK
User submits PUT /foo/bar to a node in B and receives 202 Accepted
Network partition resolves, shard maps are updated

In this sequence the /foo/bar document will be lost permanently 👎
Perhaps a preferable approach is to use 202 Accepted for every situation in which

We get at least one acknowledgement and
We do not hear back from a cluster member

The downside of this approach is that we wait around to hear back from every cluster member, and the request_timeout can be quite large. But I think we need to be quite careful about using 200 OK in situations where some cluster member could still be accepting new data in a shard on death row.
What do you think?

Thanks @kocolosk  for your comments.
I see that the orphaned files question is a different issue. We are facing it as part of a cleanup process that we have implemented in our system. Databases are periodically transferred to a temporary database and then moved back to the work database. It is like a purging procedure that allows us to keep the databases small. During this process we are removing and creating databases and orphaned files are produced. +1 for the orphaned files cleanup process enhancement.
Respect to the main issue of this PR, I think that the main problem is to respond with a 500 Error when the operation has been accepted and the database is deleted on the nodes that have received the request. It is responding with an error but the database is deleted in the active nodes, and later on propagated to the rest of nodes once they are accessible. It seem to me that this behaviour is more akin to a 202 Accepted result.
The idea of responding 200 Ok in the case that the quorum is met is mainly to keep the API consistent with other operations where the quorum is considered but I see that this can have some drawbacks.

@jjrodrig Are there updates coming to this PR from you?

@wohali I'll modify the condition to respond with 200 - Ok only if we have a response from all the nodes, If we have a positive response from some of them 202-Accepted is returned.
The problem I see is that the behaviour is not consistent with the creation where the quorum is considered, but is better than the current situation which returns a 500-Error

@jjrodrig can you resolve the conflict? Thanks!


[torchlib] Improve xfail decorator to be more robust and accurate

xfail now is powered by pytest.xfail(reason=reason). While it is great and better than skip, it does not offer check on the actual failure reason. Hence through time the descriptive reason may become outdated and misleading.
An option is to rewrite decorator with self.assertRaiseRegex.
cc @justinchuby, @titaiwangms

COde is here:
https://github.com/microsoft/onnxscript/blob/2134fa355ddb95c4c253947d36ef3669a12200ac/onnxscript/tests/function_libs/torch_lib/ops_test_common.py#L562-L591

https://github.com/microsoft/onnxscript/pull/799


Update production-deployment.md

Based on email thread with Nir and Alon, adding explicit note about the auto selection of the geo when onboarding in the MDE documentation, taken the wording from here - https://docs.microsoft.com/en-us/microsoft-365/security/defender/m365d-enable?view=o365-worldwide#data-center-location
Please also review, I'm not sure I entered the internal link to the M365D doc properly.. Thanks!

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks


Typo government & Soveriegn

@nschonni : Thanks for your contribution! The author, @sachinpMSFT, has been notified to review your proposed change.

@nschonni Thank you!! 👍
#sign-off

@JennieHubbard: I'm sorry - only the author of this article, @sachinpMSFT, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


adding tests, adding ticketmonster, updated incident store

Updated git tests
Added ticketmonster to the solved incidents
updated incident store to match the recent fetch script repo names

@savitharaghunathan when you create the example with multiple solved examples consider if we want to account for that in the prompt, I think the multi-example currently is creating a diff of multiple files but not sure we capture that in the prompt
We may want to do something like:
Here are 3 similar solved examples:
Example #1:  Filename 1
Diff 1
Example #2: Filename 2
Diff 2
Example #3: Filename 3
Diff 3

@savitharaghunathan when you create the example with multiple solved examples consider if we want to account for that in the prompt, I think the multi-example currently is creating a diff of multiple files but not sure we capture that in the prompt
We may want to do something like:
Here are 3 similar solved examples: Example #1: Filename 1 Diff 1
Example #2: Filename 2 Diff 2
Example #3: Filename 3 Diff 3

@jwmatthews do we want this to be dynamically populated based on the number of examples? Right now, patches is a list that contains only the diff of solved incidents. Should I include filename as well?

@savitharaghunathan when you create the example with multiple solved examples consider if we want to account for that in the prompt, I think the multi-example currently is creating a diff of multiple files but not sure we capture that in the prompt
We may want to do something like:
Here are 3 similar solved examples: Example #1: Filename 1 Diff 1
Example #2: Filename 2 Diff 2
Example #3: Filename 3 Diff 3

@jwmatthews do we want this to be dynamically populated based on the number of examples? Right now, patches is a list that contains only the diff of solved incidents. Should I include filename as well?

What if we pick an example where we have 3 solved examples, then we explicitly pass in info for example1, example2, example3 the filename and diff.
That is probably a small change and allows us to get a feel for what it'd look like to have 3 solved examples in a prompt.  I think going through to dynamically change the number of examples will be a bit of a PITA and not worth tackling that in the notebook.
My main thought was the LLMs could get confused with us just dumping in several diffs without enough context to distinguish each one being unique.


Bug: app window opens and stays open when computer boots

seems similar to this issue
https://github.com/bitgapp/eqMac/issues/519
Describe the bug
version 1.0.0 the app window opens on boot and stays open .....previous versions did not do this ...you now have to manually close the app window
Steps to Reproduce
Steps to reproduce the behaviour

Boot or log in
app window will open on screen and stay open

Expected behaviour
app window should not open or at least should close by itself on boot or log in
Setup information:

Audio device used for playback: macbook speakers and bluetooth soundbar
Audio transmission interface: bluetooth
macOS Version: 11.2.3
eqMac Version 1.0.0

Screenshots or Console.app logs
Jul  4 13:40:14 xxx eqMac[522]: getattrlist failed for /Library/GPUBundles/AMDRadeonX4000GLDriver.bundle/Contents/MacOS/ATIRadeonX4000SCLib.dylib: #2: No such file or directory
Jul  4 13:40:14 xxx eqMac[522]: getattrlist failed for /System/Library/Extensions/AMDRadeonX4000GLDriver.bundle/Contents/MacOS/ATIRadeonX4000SCLib.dylib: #2: No such file or directory
Jul  4 13:40:15 xxx eqMac[522]: getattrlist failed for /System/Library/Frameworks/OpenGL.framework/Resources//GLRendererFloat.bundle/GLRendererFloat: #2: No such file or directory

I wanted to mention the same thing. Annoying. On macOS Mojave.

Thanks for posting this issues, but yeah it is a duplicate of #519, so please refer to that issue from now on and I will close this issue.


Add a new badge description and remove some data from seller type

Existing data will need to be migrated by hand.


some questions, suggestions, maybe bugs.

Category

[x ] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[x] Neovim
[ ] Etc.

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

I find in your gif at homepage , your fzf window is at the bottom of the screen, but when i set height=40%, my fzf window is just under cursor line, in the middle of the screen. how to make it like your gif?

I think only set FZF_DEFAULT_OPTS is enough, both FZF_CTRL_T_OPTS and FZF_CTRL_R_OPTS should use it by default, unless I set them explicitly. BTW, maybe a bug, my FZF_CTRL_T_OPTS is the same as FZF_DEFAULT_OPTS, but the input line of ctrl-t  is at the top but I do not set --reverse.

The default prompt and pointer icon is '>', it's not nice. i have already reset the prompt to '▸' but there is no --pointer option to reset it. Please think about to add --pointer in fzf and fzf.vim. Oh, i can not understand the fzf.vim status line config example int fzf.vim homepage.

Neovim has a buildin terminal emulator, so a neovim GUI app, for instance, neovim-dot-app works with fzf.vim very well with out any terminal support. I hope users of fzf know it.  When i launch the fzf in vim, the only way to quit fzf is press :q if i do not select any line to open. Is there a way to press only one key to quit fzf window in vim, like press esc in terminal?

to be confirm, fzf use unix find by default, and you recommend to use ag, so fzf will respect the .agignore file of ag ? Is this the only way to config fzf ignore patterns?

It's using fzf-tmux script. It was primarily used before we added --height option.
FZF_DEFAULT_OPTS always applies. FZF_CTRL_{T,R}_OPTS allow you to further customize the options. Since the addition of --height, we set --reverse by default to CTRL-T and ALT-C, as top-down layout looks better in non-full screen mode. You can add --no-reverse to FZF_DEFAULT_OPTS to override it.
I'll think about it. But I'm basically reluctant to add more options for tweaking minor UI elements at the moment to avoid proliferation of non-essential options that will inevitably make fzf more complex in the long run. You can find my previous comment on that matter here. fzf is an open-source project, you can always change things and build it yourself.
You mean in Neovim? ESC works as expected. You probably have mapped ESC to something using tnoremap. Or you can simply hit CTRL-C instead.
No. ag, rg, ... whatever works best for you.

thank you for reply, and your amazing fzf and fzf.vim, and i just notice that the vim-plug is created by you too after i used it for months. How great you are in vim world!
You are right to focus your precious time on the essential functions. Although I pay more attention on UI, I don't like too many customise options. Anyway a default beautiful UI is attractive. I'm sure spacemacs gains a lot of users through it's nice UI.


[sival] fix GPIO tests on silicon

The current test failure is caused by:

"teacup" interface not being recongised by test harness.
Slight difference in pin availability compared to hyper310.

It's not exhaustive. For the gpio_pinmux_test I just remove ones that not usable for GPIO testing from the hyper310 list, and for the testutil change I use the gpio_pinmux_test list to generate the mask.


add a new page to lightkurve's sphinx called "other packages".

The name of the page is currently "community software", but could be renamed to "other packages".
Could also add a description of the codes, perhaps lifted from the GitHub tagline.

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   88.75%   88.75%
=======================================
  Files          12       12
  Lines        1147     1147
=======================================
  Hits         1018     1018
  Misses        129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6775a0f...b3c8837. Read the comment docs.

Looks good to me! Let's merge this in 3, 2, 1... we can always make changes later.

Thanks for merging, this is great! :+1:


fix(es): Add paren_remover pass

Description:

BREAKING CHANGE:

Related issue (if exists):

fix #5652
fix #5752

No, this is not enough -- it would only remove useless paren, but would preserve semantic meaningful paren.

No, this is not enough -- it would only remove useless paren, but would preserve semantic meaningful paren.

All parens will be removed except paren in (a?.b).c.

Test case failed with concurrent mode.
Do you have any idea? @kdy1

I think flaky tests are related to iteration order of AHashMap or something similar which uses ahash::RandomState

SingleThreadedCommentsMap is using FxHashMap.

https://github.com/swc-project/swc/blob/fcf4deb5f0c04ce0e2ea588cf6e5a6176c14675d/crates/swc_ecma_transforms_base/src/fixer.rs#L39
fixer and paren_remover is using AHashMap (I think it should not, though)


API to remove multiple entries at once

Currently entries can be removed one at a time, each time a temporary archive is created that replaces the original.
Would you consider extending the API to allow removing a list of entries?
For example:
public func remove(_ entries: [Entry], bufferSize: UInt32 = defaultReadChunkSize,
                                  progress: Progress? = nil) throws

I'm currently looking into adding this myself, but I have not wrapped my head around CentralDirectoryStructure and endOfCentralDirectoryRecord and the various offsets that are involved.
Thank you!

Removing entries from ZIP archives is - in contrast to entry addition - very expensive. So providing a "batch removal" method would certainly make sense.
ZIP Foundation removes an entry by re-writing the whole archive to a temp file, but skipping the entry to remove. The part to skip is from Entry.centraldDirectoryStructure.relativeOffsetToLocalHeader to the end of the data section of the file. Wikipedia has a good introduction + diagram about the structure of archives:
https://en.wikipedia.org/wiki/Zip_(file_format)#Structure


fastspeech2 trainning question

[train]:   0%|                          | 200/200000 [06:02<27:51:33,  1.99it/s]2020-07-16 15:29:27,311 (train_fastspeech2:226) INFO: (Step: 200) train_duration_loss = 2.4179.
2020-07-16 15:29:27,314 (train_fastspeech2:226) INFO: (Step: 200) train_f0_loss = 1.9053.
2020-07-16 15:29:27,317 (train_fastspeech2:226) INFO: (Step: 200) train_energy_loss = 2.1922.
2020-07-16 15:29:27,321 (train_fastspeech2:226) INFO: (Step: 200) train_mel_loss_before = 0.6235.
2020-07-16 15:29:27,324 (train_fastspeech2:226) INFO: (Step: 200) train_mel_loss_after = 0.6925.
[train]:   0%|                          | 372/200000 [07:32<25:30:11,  2.17it/s]Traceback (most recent call last):
File "/data2/l50013588/pycharmProjects/FastSpeech2/TensorflowTTS-master/examples/fastspeech2/train_fastspeech2.py", line 519, in
main()
File "/data2/l50013588/pycharmProjects/FastSpeech2/TensorflowTTS-master/examples/fastspeech2/train_fastspeech2.py", line 511, in main
resume=args.resume,
File "/data2/l50013588/pycharmProjects/FastSpeech2/TensorflowTTS-master/examples/fastspeech/train_fastspeech.py", line 308, in fit
self.run()
File "/data2/l50013588/pycharmProjects/FastSpeech2/TensorflowTTS-master/tensorflow_tts/trainers/base_trainer.py", line 67, in run
self._train_epoch()
File "/data2/l50013588/pycharmProjects/FastSpeech2/TensorflowTTS-master/tensorflow_tts/trainers/base_trainer.py", line 89, in _train_epoch
self._train_step(batch)
File "/data2/l50013588/pycharmProjects/FastSpeech2/TensorflowTTS-master/examples/fastspeech2/train_fastspeech2.py", line 80, in _train_step
self._one_step_fastspeech2(charactor, duration, f0, energy, mel)
File "/usr/local/anaconda3/envs/tf2.2/lib/python3.6/site-packages/tensorflow/python/eager/def_function.py", line 580, in call
result = self._call(*args, **kwds)
File "/usr/local/anaconda3/envs/tf2.2/lib/python3.6/site-packages/tensorflow/python/eager/def_function.py", line 611, in _call
return self._stateless_fn(*args, **kwds)  # pylint: disable=not-callable
File "/usr/local/anaconda3/envs/tf2.2/lib/python3.6/site-packages/tensorflow/python/eager/function.py", line 2420, in call
return graph_function._filtered_call(args, kwargs)  # pylint: disable=protected-access
File "/usr/local/anaconda3/envs/tf2.2/lib/python3.6/site-packages/tensorflow/python/eager/function.py", line 1665, in _filtered_call
self.captured_inputs)
File "/usr/local/anaconda3/envs/tf2.2/lib/python3.6/site-packages/tensorflow/python/eager/function.py", line 1746, in _call_flat
ctx, args, cancellation_manager=cancellation_manager))
File "/usr/local/anaconda3/envs/tf2.2/lib/python3.6/site-packages/tensorflow/python/eager/function.py", line 598, in call
ctx=ctx)
File "/usr/local/anaconda3/envs/tf2.2/lib/python3.6/site-packages/tensorflow/python/eager/execute.py", line 60, in quick_execute
inputs, attrs, num_outputs)
tensorflow.python.framework.errors_impl.InvalidArgumentError:  Incompatible shapes: [8,512,80] vs. [8,620,80]
[[node mean_absolute_error/sub (defined at data2/l50013588/pycharmProjects/FastSpeech2/TensorflowTTS-master/examples/fastspeech2/train_fastspeech2.py:120) ]] [Op:__inference__one_step_fastspeech2_96220]
everytime I start train，it reports this log，and everytime the step is not same，the log reported at 100 to 700.I think the question is that the mels length in a batch is not same.

@learnerkun the step is not the same because we shuffe training set before training it at every epoch :D. The bug is because sum(durs) != len(mel) at some samples. You need to check by urself if there are some samples has this problem :D

I know there is one solution,set the batch 1,but I think this is not a good solution.I want know if there are some other solutions

Ok, I will try it.

@learnerkun the problem is not mels length in a batch is not same but the len of mel-predicted != len of mel-groundtruth

You are right,two durations files are wrong.thanks!


add keyUp event

gonna need keyboard input at some point
keyDown, keyUp events with access to option keys (shift, ctrl alt etc) and to consider a lastKey event
core feature - no getting away from it ;)

See LessonC6

about now on

basic implementation now in #93


connect ECONNREFUSED

I am not sure what I am doing wrong.  Could anyone help?
[1/16/2019, 6:09:41 PM] Loaded config.json with 0 accessories and 1 platforms.
[1/16/2019, 6:09:41 PM] ---
[1/16/2019, 6:09:43 PM] Loaded plugin: homebridge-harmony
[1/16/2019, 6:09:43 PM] Registering platform 'homebridge-harmonyHub.HarmonyHubWebSocket'
[1/16/2019, 6:09:43 PM] ---
[1/16/2019, 6:09:43 PM] Loading 1 platforms...
[1/16/2019, 6:09:43 PM] [Harmony Hub] Initializing HarmonyHubWebSocket platform...
[1/16/2019, 6:09:43 PM] [Harmony Hub] Loading activities...
[1/16/2019, 6:09:43 PM] [Harmony Hub] Error retrieving info from hub : connect ECONNREFUSED <IP_ADDRESS>:8088

I have this issue also and it seems to be a problem with the Hub itself.  I had it configured and working but something broke and it just can't connect to it while I can connect to my other hub just fine, both are set to Static IPs.  Might have to do a factory reset on the Harmony Hub?


Are patterns seamless?

Hi guys, I have the feeling that the .png patterns I download (1024 x 1024) should be seamless but they are not. Am I doing something wrong or that's just the way it is?
Is there a certain size or zoom level that can only make them seamless?
Thanks

I've noticed this today as well, I downloaded 3000 x 3000 and it wasn't seamless, nor was the standard download size seamless

This still seems to be the case as I cannot get it to download seamless patterns , only a block with a small black square. I have tried all configurations.  Please fix this problem.
Thanks.

one for seamless, or maybe allow input a float zoom value

While I might be wrong as I haven't used rollup or svelte personally, it seems certain elements of this site are not present in this repo (which I understand might be on purpose as well and so I am not going to write a how-to guide per se) but to get the pattern to tile to a desired size and with desired colors locally, you have to download the SVG file and modify the value of the <svg> element's height and width attributes (which are set to 100 whereas the <path> element is set to 100% so make those the same) as well as the fill attributes of any <path> elements and the final fill being the background color. Then you can tile and convert the svg using imagemagick locally and should be good to go.
Yes, that means opening the SVG file in a text editor to do that, don't know if Windows will let you do that since I don't use it or macOS but works fine for me on Linux.

Seeing this issue as well, the default png is not tileable. It seems the dimensions to properly tile are different for each pattern. What I found to work:
Download the svg, check the dimensions, and multiple in each dimension by 2 (because of the transform: scale(2) applied), then enter those dimensions for the png download, and the resulting image should tile properly!


aliexpress-stores: add new template to hide results by store name

A simple filter to allow the user to remove unwanted stores from AliExpress (e.g. fakes/spammers etc...)
It currently provides filtering based on the store name (e.g. the common pattern of Shop 12345 Store) but could be extended easily enough.
@JonnyP36 and @xvello for their help with this!
Fixes #495

One potential improvement might be to look at replacing has-text with a more efficient function (similar to @xvello's comment on another issue here: https://github.com/letsblockit/letsblockit/issues/496#issuecomment-1625133271, and may be aided by the 'wordOrRegex' list variant once ready - https://github.com/letsblockit/letsblockit/pull/352/files)

Heya @sammcj, thanks for your contribution, I'll review it shortly.
I merged https://github.com/letsblockit/letsblockit/pull/498 to add you to the contributors lists, so that the linting passes. I'm happy to change your avatar to your photo if you give me a URL.

Heya folks, I took the liberty of doing the following changes before merging:

pluralize the param name into shop-names, as it's a list
remove the preset and move it into the description instead:

a preset comes with a commitment to  maintain and expand it to keep it somewhat exhaustive. I'm doing it for the https://letsblock.it/filters/amazon-products ones, but I don't know whether we want to commit to play a cat-and-mouse game with bad actors
a default is difficult to change after people have enabled it, so it's not great either

Happy to have another PR to create the preset if @sammcj is interested in maintaining it though!

a preset comes with a commitment to maintain and expand it to keep it somewhat exhaustive. I'm doing it for the https://letsblock.it/filters/amazon-products ones, but I don't know whether we want to commit to play a cat-and-mouse game with bad actors
a default is difficult to change after people have enabled it, so it's not great either

You are right. Although already merged I agree on your changes.


Replaced django.utils.importlib with python importlib

django.utils.importlib will be removed in Django 1.9, using python importlib instead

Working with python 3.5


[UtilizeGraph][Revamp][1587026]

Docs Build status updates of commit dc7be71:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/assets/images/azure-rsc-configuration.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/graph-permissions.png
:white_check_mark:Succeeded
View

msteams-platform/graph-api/rsc/resource-specific-consent.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Closing the PR, as requirement put on hold.


int.new with keyword do not working

Feature
print(int(x=1))

int.__new__ with keyword x do not working
Actual result
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: Unexpected keyword argument x

Expected result
1

Same as float, bool :)

Ugh, can we revert this? Because int(x=1) working is in fact a bug and Python 3.7 fixed it.

 I guess we could just revert the merge of #1444. Sorry @lntuition :slightly_frowning_face:
Python 3.7.0 (default, Aug 22 2018, 20:50:05)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> int(x='10')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: 'x' is an invalid keyword argument for int()

#1456

Sorry for confusion. I should have tested at python 3.7


Access RSDP from BootInfo

Is there a way to access the RSDP from boot info?
https://wiki.osdev.org/RSDP

Not yet, but the upcoming version in #130 will include the RSDP in the boot info. You can try to use https://docs.rs/acpi/2.3.0/acpi/struct.AcpiTables.html#method.search_for_rsdp_bios directly until then.

Is there any example to help integrate it with boot loader. As it requires a handler. Do I have to make my own one it’s not documented @phil-opp

The function works by scanning certain physical memory regions for the RSDP signature (see https://wiki.osdev.org/RSDP#Detecting_the_RSDP ). For this is needs access to physical memory. This is what the handler is for.
You can create your own handler by implementing the AcpiHandler trait. For this you need to provide methods to map and unmap physical memory pages. If you're using the map-physical-memory feature of the bootloader, you don't need to do any actual mapping in it as you can just add the offset.
For an example implementation, this is how we implemented it in the upcoming new version of the bootloader crate:
https://github.com/rust-osdev/bootloader/blob/873351c575bdefd1c6c78b27de2bc0494698c0d5/src/bin/bios.rs#L193-L225
Instead of an identity mapping, you probably have the physical memory mapped at an offset, which you need to add to the address when filling the virtual_start field of the PhysicalMapping.
Hope this helps!

It does. Thanks!

Closing as version 0.10.0 is released!


Intermittent Hang-ups on Windows PR Build in OpenAPI Tool

Description:
There were some intermittent hang-ups during the Windows PR build in ballerina-platform/openapi-tools
In some cases, Windows build was successful. But in some cases it won't complete the build for hours and then hangs-up.
This scenario is same for the local build as well.

Close this issue, as we haven't encountered any abnormal behavior in the Windows workflows recently.


(S) As a AAA developer I want the be able to automate the release notes so that I don't spend a lot of time preparing a release

Acceptance Criteria

Project is configured to use towncrier to manage the release notes.

DOD
As above

Blocked by #62 because it needs the setup that is done there

Hi @abompard ,
Just for my understanding PR #62, we are reverting back to " quotes instead of ' and #63 needs to be reviewed by a team member? When these are complete are you unblocked?

In a Github board we can put issues (in our cases user stories) and PRs. In the case of user story #63, it should be fixed by PR #62 which is ready for review. In the board I have put only the user story, not the pull request, although it's the pull request that is ready for review and not the user story (since we have already agreed on it).
I don't know what's best to do workflow-wise, if it's better to have only issues in the board or if we mix issues and PRs (which may make more sense since it's the PRs that need review).
I have no personal perference on that subject.

Hi @abompard great work!
@relrod when you closed this ticket, does that mean you have reviewed it, happy to accept and see the user story as done?


Add support for the /logout endpoint

The simulator currently lacks support for the /logout endpoint, the "how it works" section in the technical documentation outlines the main endpoints and it would make sense to support this for completeness so that developers can exercise all the endpoints.

looks like this is in https://github.com/govuk-one-login/simulator/pull/189 so once its merged to main we can close this issue.


Integration for multi-stake key wallets

Why

Multi-stake key wallets give a unique opportunity to delegate to many DReps / Stake pools from a single wallet account

What
Allow GovTool to read all available stake accounts shared by the wallet at once, rather than forcing the user to choose one at a time
How

Investigate how suitable CIP95/30 is with the current set of multi-stake key wallets
Decide on product direction on how and what to do
Design new UI
Implement and refactor code

rather than forcing the user to choose one at a time

Can you elaborate on how this works currently @Ryun1 ? The CIP-30 API returns an array of reward accounts, but I can't see any input from the user to nominate an address to associate the delegation with. Yes, the ultimate UX would be to perform a multi-delegation in a single tx but It would be fine if users could use GovTool to submit multiple individual delegations.

@rhyslbw

Can you elaborate on how this works currently @Ryun1 ?

The current intended behaviour should be
IF multiple stake keys are presented over cip95. getRegisteredPubStakeKeys()  / cip95. getUnregisteredPubStakeKeys() (ill try and find the code snippet)
THEN the user has to pick the stake key they want to "connect" with
I assume this isnt working?

So after some digging, it does seem to exist, but never gets called...
https://github.com/IntersectMBO/govtool/blob/develop/govtool/frontend/src/components/organisms/ChooseStakeKeyPanel.tsx#L12-L44

Oh, that's odd. I can now see this stake key picker on connection @Ryun1. I'm not sure how I missed this but will try to reproduce tomorrow.

I couldn't reproduce this so I must have connected to the DApp before establishing the multi-delegation.

This is still inconsistent behaviour
For multi-stake key wallets it is probably best to offer the user the stake key selection on every connection

we need to make another ticket to then use multi-stake key in a more advance way for delegation


FTP sync with SCMP FTP server

Task Summary
📅 Due date: 29 Nov 2021
🎯 Success criteria: Bidirectional sync with FTP server.
To Do

[x] Set up sync with SCMP server
[ ] Evaluate existing sync solution (do we keep?)

Suggestions:

Can add a flag to server, start ftpsync service if flag is on
Dropbox / S3 API sync
Sync vs. "watch"

"watch" is always on (not flagged)

If we use Dropbox, then we don't need client to give us a FTP, and sync may be more reliable

Flag it off in Ansible for now, let's see how things go after. Maybe Dropbox API to replace Ben-sync.


Some final input on the IVC OO update

Here are a number of changes to the latest update to streamline a number of things.  I used a number of small commits to show the individual changes, mostly distinct from each other. NOTE: this PR will update the ivc_oo branch thus changing PR #55
None of this has been tested since I don't have a robust testing environment for the whole process, so there may be some typo bugs.

use a more conventional singleton pattern for cubit initialization
move the defaults to be members of utils rather than returned by a function
don't overuse try/raise blocks
make IVB.Surfaces and IVB.Components into dictionaries based on their name since we need this info together often
put module imports in a more pythonic order - native modules to third party modules to custom dependencies to local modules (hope this doesn't break anything!)
import cubit_io as module and qualify method names
separation of concerns in parastell: construction vs export (with docstrings)
tweak variable names for consistency
refactor to avoid making the component dictionary that requires special cases between magnets and otherwise

I think I addressed the bugs that were noted, and don't think other changes are necessary.

Thanks for the changes @gonuke. Now, we just need either the changes to the input dictionaries for test_parastell.py or we need to revert the implementation of default input dictionaries to how it is in #55

In hindsight, I should have had you just merge the PR and then make additional commits on the original branch :)

Thanks @gonuke


Clean up AppVeyor deployment.

AppVeyor

[x] PK's own CI build project
[x] origin/!master CI build project
[x] origin/master CI build project

Deployment:

[x] PK's fork (origin/<branch>) goes to his own public MyGet feed.
[x] All upstream/!master braches goto the public MyGet.
[x] master goes to NuGet.

Added in PR #189.


We could express that like (Polar Explorer) OwnedTile(HAS 8 Row). All we should have to do is define CLASS Row<Area> and create a bunch of them when creating the areas. That doesn't mean that there is a single Row instance that everything in the 4th row relates to. Each area in the 4th row would have 4 instances of Row depending on it. That's odd, but it makes the syntax up above work.
The same thing could be done for cards with a Cost type, but we need to distinguish card costs even for cards that haven't been played yet, so it doesn't seem as helpful.

Currently think #11 will do this


[IMPORTANT] White screen on Windows 10 laptop and Windows 8.1 laptop

Issue
When launched (either complied or fresh from the website), GB Studio launches, but only prompts a white screen.
Expected behavior
I expected for GB Studio to launch.
Screenshots

Platform
I am using Windows 10 Home Build 1903, however I've launched GB Studio on my older laptop running Windows 8.1 (Ver 6.3 Build 9600). I have tried GB Studio 1.1.0 and 1.2.0.
Additional context
I have tried:

Checking if GBS was blocked my an anti-virus
Run as admin
Compiling GBS
Squirrel and manual installations
Reinstalled about 12 times
Dev builds
Clearing window state

@uKomodo Also said on discord Visual Studio Code (another electron app) was working fine.
The white screen of death seems to have a wide range of causes and cases,
https://github.com/electron/electron/issues/7049#issuecomment-295653629
Some suggest it happened running 32x builds on 64x,
or to clear the app in %appdata% in case something had corrupted,
or that deleting d3dcompiler_47.dll from the app folder fixed some users issues.
https://code.visualstudio.com/docs/supporting/FAQ#_vs-code-is-blank
Visual studio Code states it may be a GPU acceleration problem, though this is not a white screen.
https://github.com/electron/electron/issues/2357#issuecomment-454553016
Checking for an uncaughtException may help narrow it down, no idea how to go about that though.
They have it compiling from source (with the white screen) so if anyone has ideas to try, would be nice to solve.

@uKomodo and @RichardULZ thanks for looking so thoroughly into this.
I actually had plans over the next few days to introduce better error handling to catch issues like this where possible and display the error message in the window. I'll work on this and let you know when the dev build is ready to try again. It's not going to fix anything but hopefully it should help understand what's happening here.

To update a little on this I've pushed up an update in commit 4b15a18035df77a20ad67002cd46cfc9a19ccb9f that attempts to catch uncaught exceptions and problems loading a project and now displays the following:

Viewing the stack trace shows the following:

and clicking "What can I do?" opens https://www.gbstudio.dev/docs/error which doesn't exist yet but I will create a page to give instructions on asking the Discord/Reddit for help and how to submit a GitHub  issue.
But looking again at your screenshots it seems you can't even open the initial window where you create a new project or choose from recent projects to open. If that's the case these error messages won't appear for you. That screen is made slightly differently so I'll need to think about the best way to catch the errors there, and also what the most likely things are that might be causing issues for you.
Could you confirm if you are able to create a project at all or if this is literally the only screen you see when you open GB Studio?

I've added a similar message to the splash screen now too.
@uKomodo do you want to give the developer builds another go and see if you get a better error message?

You should be able to use the links at the bottom of https://github.com/chrismaltby/gb-studio/blob/develop/README.md to get an up to date dev build.

Oh wow, I completely forgot about this. Thanks for the help, I'll get the dev version immediately.


Angular 1.4  and new native router

Any plans to change this library to work with the new native router in Angular 1.4? Would be awesome imho =)

No desition made yet, though I think it should definitely happen.
Will take time though, I've been super busy lately.

Thanks for the update. Glad to hear it will happen somewhere down the road =)


As documentation states, PUT has to be used to create the PD integration

Using POST (the previous state) makes the operation fail sometimes with 405 error, see e.g. https://github.com/terraform-providers/terraform-provider-datadog/issues/160
See https://docs.datadoghq.com/api/?lang=bash#create-a-pagerduty-integration for documentation of this endpoint - PUT is really the suggested verb to use to create the integration.

Thanks for the review, merging.


fix: input error border-color 변경

PR 설명
#3234 작업에서 input의 border-color 변경을 누락하여 추가합니다.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 10.27%. Comparing base (94dd816) to head (3b7c7f2).

Additional details and impacted files
@@           Coverage Diff           @@
##              v13    #3244   +/-   ##
=======================================
  Coverage   10.27%   10.27%
=======================================
  Files         710      710
  Lines       33713    33713
  Branches     9166     9166
=======================================
  Hits         3465     3465
  Misses      30241    30241
  Partials        7        7

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

release-canary

요거 머지도 금발 될거 같은데, 13.25.3 배포되면 @francis-triple 에게도 노티 부탁드립니다.


Flex 3052 Fixes event notifications

 You should sign our Contributor License Agreement in order to get your pull request merged.

This pull request makes the build fail.

This pull request makes the build fail.

This pull request makes the build fail.

The failing tests are known to fail.


[#82211636] [Not Ready] Upgrade embers

This pull request is an attempt to upgrade to ember 1.8.1 and ember data 1.0.0.beta.14. We are desperately in need of this - each day we don't, upgrading is getting harder.
:rabbit: :cake:
Once this is merged into master, we'll be primed for merging master into the ember-cli branch.

I'm not seeing where the two new radio button components are used. Why are they there?
Otherwise, looks OK to me. :+1:

":ship: it" — @DTrejo

Oh, and the text area component too.

I wonder if the radio-button component and text-area component override the default components provided by Ember for these.
I am gonna merge this, as it's working fine well otherwise.
/cc @tonywok

@mikem @rizwanreza Saw those too. Looks like the DecisionRadioButton inherits from the ETahi.RadioButton. I thought those looked fishy too.


feat: deprecate option to show compiled query in a temporary sql fle

This PR:
Deprecates the option useWebViewToShowCompiledQuery which used to enable the user to see the compiled query as an sql file in vertical split instead of using the web view (current default). Using sql file to show compiled query was the initial approach I took. But since switching to using web view I have not ever felt the need to use the temporary file option by making useWebViewToShowCompiledQuery as false
Benefits

[x] Maintaining both options was adding a lot of tech debt
[x] Removing multiple if checks should make the extension every so slightly more performant

This pull request focuses on removing the useWebViewToShowCompiledQuery feature and related code, as well as cleaning up unused code and simplifying existing functions. The most important changes are summarized below:
Removal of useWebViewToShowCompiledQuery feature:

package.json: Removed the vscode-dataform-tools.useWebViewToShowCompiledQuery configuration option.
src/extension.ts: Removed the logic related to useWebViewToShowCompiledQuery from various functions, including compileAndDryRunWtOpts and event listeners. [1] [2]

Code cleanup and simplification:

src/constants.ts: Removed the compiledSqlFilePath constant.
src/sync.ts: Deleted the editorSyncDisposable implementation.
src/utils.ts: Simplified the writeCompiledSqlToFile and dryRunAndShowDiagnostics functions by removing unused parameters and logic. [1] [2]
src/formatCurrentFile.ts: Updated function calls to remove references to compiledSqlFilePath and unused parameters. [1] [2]

Tests and other updates:

src/test/suite/diagnostics.test.ts: Removed the import of compiledSqlFilePath from the test suite.
src/views/register-preview-compiled-panel.ts: Updated the registerCompiledQueryPanel function to reflect the removal of useWebViewToShowCompiledQuery and related logic. [1] [2]


"Hey Google" Trigger

I would like to trigger this library's speech recognition when a specific text is said, "Hey Google" for example.
How would I go about achieving this - is this possible with this library alone, or would I need to use another library to detect that voice action before using this for recognition?

This would be way aweome. Even awesomer, if it accepts it while app is in background.

Unfortunately, according to SO, you need to implement your own voice activation logic (https://stackoverflow.com/a/36720515/1609620). Please re-open it if there is further information.


Support open remote model in server

Search before asking

[X] I have searched among the issues and discussions and found no similar questions.

Question
Seems vscode-netron only support preview model in local machine.
Is there a plan to preview in VScode remote window connected by ssh?
Thanks!
Additional information
No response

Hi @roachsinai,
When you are working in remote-ssh in vscode via the official extension, the installation of the vscode-netron extension will be located on the SSH machine you are working on.
Then all previews will be on that machine.
Hope it will help you.

@vtemplier Thanks for your quick reply.
For now the Netron tab is as above image.
When I click Open Model... it open my local file explorer.
Maybe the reason is no x11 installed server?

I understand, when you use the Netron web app feature, it will directly open the web app (available at this address on a vscode window. Unfortunately, this feature requires to work locally as you well noticed.
However if you open your neural network model by right clicking in the file explorer and selecting Open Netron, it will be on the remote machine.


Check consistency in  CodeLens vs code lens UI terminology

Description:
Check consistency in  CodeLens vs code lens UI terminology.
Suggested Labels:

Suggested Assignees:

Affected Product Version:
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Done in https://wso2.com/ballerina/vscode/docs/.

Done via https://github.com/wso2/docs-ballerina-vscode-extension/pull/86/files.


Remove "compiler.base" settings mechanism

The mechanism of defining that a compiler such as “intel” in the settings.yml definition will kind of extend other existing compilers (such as “intel” having as a base either “gcc” in Linux or “msvc” in Windows) will be removed. Instead, a full definition of the compiler will be necessary, as the new IntelOneApi (via intel-cc setting has already been proposed in Conan 1.X).
The potential expected benefits of the "compiler.base" mechanism are not worth it compared with the complexity they bring. Some users, the ones that promoted this feature have already requested its removal. It also seems to have no extended usage beyond the previous intel and mcst-lcc compilers.

Upvote 👍  or downvote 👎  to show acceptance or not to the proposal (other reactions will be ignored)

Please, use 👀  to acknowledge you've read it, but it doesn't affect your workflow

Comment and reviews to suggest changes to all (or part) of the proposal.

There has been no issues with this proposal, seems everybody is aligned with the users requests that started this proposal. This will be in the next alpha.4


A11y_AzureDataStudio_New deployment - SQL Server container image_Screen reader: Narrator is announcing the link 1 instead of label as Deployment pre requisites in left side

GitHub Tags:
#A11yMAS; #A11yTCS; #A11ySev2; #DesktopApp; #BM-AzureDataStudio-Win32-Feb2022; #Azure Data Studio; #WCAG1.3.1; #Win32; #AINotInScope; #Info and Relationship;  #Narrator; #NVDA; #Reopened;
Environment Details:
Windows Version :Windows 11 Enterprise
Application name :Azure Data studio
Repro Steps:
1.Turn on Narrator
2. Launch Azure Data Studio.
3. Select the Connections icon (if not already selected) from left bar.
4. Click on the ellipses '...' and select "New Deployment"
5. In the Deployment options, select "SQL Server container image" card.
6. Validate the required tools are installed and the "Required Tools" table shows the status as "Installed". Without the required tools the Select button will be disabled.
7. Click "Select".
8. Verify the Deployment pre requisites is reading by Narrator or not
Note:
Similar issue can be observed in throughout the application wherever the steps to be followed in left side
Actual Result:
Narrator is announcing the link 1 instead of label as Deployment pre requisites in left side
Expected Result:
Narrator should announce label as Deployment pre requisites
Attachment:
Narrator

NVDA

this is by design, the step number was not designed to have the step name, as soon as user are in the step, they will know the detail of it.

@alanrenmsft
As discussed with Tanaz Narrator should announce Deployment pre requisites.
Verified the issue in below environment :
Version: 1.41.1 (user setup)
Commit: 33dce95b152227c4f10f6251ab30690fe9895c0c
Date: 2023-01-28T00:46:39.274Z
VS Code: 1.67.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Issue is partially fixed. NVDA is announcing name of the link . Narrator is not announcing.

Note: Could you please reactivate the bug "Please do not close this bug. This bug should only be closed by TCS, C+AI Accessibility or the Divisional Driver"

@VijayaBharathyA I've fixed the issue now, please use the latest insider build to verify: https://github.com/microsoft/azuredatastudio#try-out-the-latest-insiders-build-from-main-branch

#closed;
Verified the issue in below environment:
Version: 1.42.0-insider (user setup)
Commit: 385e4a22450d4549d58a262dcd503e636f1ed30d
Date: 2023-02-14T06:27:10.580Z
VS Code: 1.67.0
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Issue is fixed


NonNullable is accidentally simplified away from generic index accesses

Bug Report
🔎 Search Terms
defer, index access, index signature, nonnullable
🕗 Version & Regression Information

This somewhat changed between versions 4.7 and 4.8

⏯ Playground Link

Playground link with relevant code
💻 Code
interface StateSchema {
  states?: {
    [key: string]: StateSchema;
  };
}

declare class StateNode<TStateSchema extends StateSchema> {
  schema: TStateSchema;
}

// worked in 4.7 but perhaps accidentally
type StateNodesConfigCurrent<TStateSchema extends StateSchema> = {
  [K in keyof TStateSchema["states"]]: StateNode<TStateSchema["states"][K]>;
};

// this OTOH should work right now but it doesn't
type StateNodesConfigNew<TStateSchema extends StateSchema> = {
  [K in keyof TStateSchema["states"]]: StateNode<
    NonNullable<TStateSchema["states"]>[K]
  >;
};

🙁 Actual behavior
NonNullable disappears when computing getConstraintFromIndexedAccess. Essentially this type:
NonNullable<TStateSchema["states"]>[keyof TStateSchema["states"]]

gets simplified/distributed to
TStateSchema["states"][string] | TStateSchema["states"][number] | TStateSchema["states"][symbol]

As we might notice here - NonNullable is gone from here because of the simplification rules:
// (T | U)[K] -> T[K] | U[K] (reading)
// (T | U)[K] -> T[K] & U[K] (writing)
// (T & U)[K] -> T[K] & U[K]

The third case applies here so we end up with something like this
TStateSchema["states"][string] & {}[string] | TStateSchema["states"][number] & {}[number] | TStateSchema["states"][symbol] & {}[symbol]

In here, those {}[string | number | symbol] are just reduced to unknown and T & unknown gets reduced to T. So that's how NonNullable "disappears" here.
Note that even though T[number | symbol]  is not valid for this T this indexed access is allowed based on this logic:
https://github.dev/microsoft/TypeScript/blob/488d0eebd0556fcc6e5f4cfc69c2ef7e5c2708ed/src/compiler/checker.ts#L16036-L16040
🙂 Expected behavior
NonNullable should be correctly retained/deferred in this case to preserve the correct constraint of the generic type.

After updating from 4.7 to 4.8, I believe I'm running into a related issue. Unfortunately I'm not able to explain it in such technical detail but here's a reproducible:
type Ordering<TOrderBy extends string> = {
    orderBy: TOrderBy
}

type Query<TOrderBy extends string> = {
    order?: Ordering<TOrderBy>
}

type QueryHandler<
    TQuery extends Query<TOrderBy>,
    TOrderBy extends string = NonNullable<TQuery["order"]>["orderBy"] // Worked in 4.7
> = {
    }

... does not satisfy the constraint 'string'.
... cannot be used to index type 'NonNullable...

Playground Link
Disabling strictNullChecks makes the problem go away.

I can confirm that this is also fixed by my PR. I'm gonna add this as an additional test case in a moment


Releases page out of date

Hi,
It really confused me that the releases page was out of date - I often look there in github repos to find the latest version. Perhaps if you are no longer using it you should delete the existing releases?

Thanks for the report. You're right that it's missleading.
I started to use github releases because I was using jitpack for distribution, but forgot to remove them when I moved to jcenter.
I've deleted all releases and tags.


Add Chinese Simplified Translation

Add translation and make some strings "untranslatable"
DE BG7QWH, 73 for you and your awsome app!
Screenshot

Thank you for the translations. I also added translations for the Channel Select menu, the Privacy Policy and About pages. Can you please check if that looks alright?

@xdsopl  That translation is correct when translated directly. I'm confused about what the "channel select" menu actually control and that's the reason why I left the translation of that part blank. Could you explain that for me?
As for the "about" site and "privacy policy" site, I left them in English for I don't want to cause misunderstanding and lead to legal problem, your translation of that part is also ok

I'm confused about what the "channel select" menu .. Could you explain that for me?

Default means single channel microphone input. Unfortunately with stereo microphones, some devices do fancy audio processing when using Default, which ruins the signal. So you need to choose either First or Second channel instead to avoid the processing.
Because there is no exact definition of Left of Right audio channel, I used First and Second channel for devices with more than one microphone.
Summation means that both First and Second channel is recorded and added to a single Mono stream and used for decoding.  You actually gain a better signal this way if both microphones have the exact same distance to the audio source.
Analytic signal means that instead of just using a singe channel real signal as input (Default, First, Second or Summation) and using the Hilbert transformation internally to get the Analytic signal we need, we can provide the real (in-phase) component from the First channel and the imaginary (quadrature) component from the Second channel. This allows us to use very simple quadrature product receivers like a Tayloe detector.

As for the "about" site and "privacy policy" site, I left them in English

Wise choice. All legal stuff should be left to lawyers, which I am not.

your translation of that part is also ok

Thank you.
BTW, you should force update your repository, then GitHub should recognize this PR as a done deal.

@xdsopl  Thank you for your detailed explanation  :)  Maybe you can create a new partition called "Help" and add these explanations above for users to have a better understanding of your awesome software
Have a nice day!

I am planing on making a YouTube video instead. Thank you and have a nice day, too.

I am planing on making a YouTube video instead. Thank you and have a nice day, too.

@xdsopl  Since YouTube is unreachable in China, may I "carry" your video to another video platform (like BiliBili)?

Sure, I can send you the video file. I can also upload on TikTok. Does TikTok work for you as well?

TikTok works and if you send me your video file then I will send it to BiliBili (a video platform which is popular among young people in China)
Here's my own BiliBili space https://space.bilibili.com/75633948/

Cool, Translating the page works. This is my TikTok: https://www.tiktok.com/@xdsopl

Cool, Translating the page works. This is my TikTok: https://www.tiktok.com/@xdsopl

Nice but I noticed something, the TikTok you are using is "TikTok Global", which is quite different from the one Chinese use. And of course Chinese cannot access TiKToK global, they only have access to TikTok China (https://www.douyin.com/)

OMG the Chinese TikTok is so much better than the global one. I barely watch global TikTok as the recommendations are simply garbage. Maybe I should pay attention to the global TikTok and even better, BiliBili then?

OMG the Chinese TikTok is so much better than the global one.
True lol.

Maybe I should pay attention to the global TikTok and even better, BiliBili then?

BiliBili is also divided into Chinese version and global version and  they are also separated and isolated. The link I mentioned before is of course BiliBili China.
Bilibili China is mainly focus on Chinese user, maybe I think is better focus on global video platform like YouTube instead of this one
But if you are interested in running an account in Chinese video platform, it still a nice choice to do that because it's far as I'm know there are a lot of Chinese hams use BiliBili and most of them are young people who is full of passion

I of course meant I should pay more attention to the Chinese TikTok and BiliBili platforms. The divide is kinda sad but understandable: The self destructive stuff on western platforms cannot be ignored anymore since a decade or so. I have to block so many channels on YouTube to keep it a happy place, you wouldn't believe.

I of course meant I should pay more attention to the Chinese TikTok and BiliBili platforms. The divide is kinda sad but understandable: The self destructive stuff on western platforms cannot be ignored anymore since a decade or so. I have to block so many channels on YouTube to keep it a happy place, you wouldn't believe.

I feel the same as you , I have used the global video platform for a while (of course using a VPN service), after a while I find myself can not stay on that platform for more time since the contact of there is not quite quality
There might be some problem when you are using these Chinese localized platforms, if you finally decided to run Chinese video accounts I will assist you to register and use

Thank you for that offer. I will contact you.

Thank you for that offer. I will contact you.

OK, 22:00 UTC+8 so good night, 73 from Guilin City

16:00 here, have a good night.


🚀 Next updates.

I will work on the following features to improve the app:

[x] Fix sidebar scroll bug for medium sizes.
[x] Create API routes to get all svgs & categories.
[x] Sticky search bar when scroll.
[x] Add light/dark mode for scrollbar.
[ ] Improve app performance to avoid loading 200 svgs directly.

🚀🚀

A new version of SVGL will be available soon ✨

Does all the tasks has been completed or anyone is remaining among this if yes then i will be very glad to work with collaborations.

I am preparing Svgl v4, soon it will be available with all tasks solved 🙂