Flux/MagicHome Issues Setting RGB and RGBW (Color plus Whitelevel)

Home Assistant release with the issue:
0.90 and newer

Last working Home Assistant release (if known):
0.89.2
Operating environment (Hass.io/Docker/Windows/etc.):
Hass.io

Component/platform:
Flux Led/MagicLight

Description of problem:
Changes related to this component that were implemented in the 0.90 release (tagged @autinerd) (and beyond) have broken my ability to control my MagicHome RGBW strip, making either my RGB brightness work or the whitevalue work, but setting one turns off the other. I use Node Red but get the same results if I control these strips from NR or from Lovelace or States. If I revert back to 0.89 it works perfectly in all scenarios. Home Assistant ~thinks~ it is setting the correct color and whitevalue, and even indicates that in the sliders, but the device itself does not take these settings.
The RGBW strip I have has a combination of RBG LEDs and white LEDs on the same strip, and the brightness of the white LEDs is controlled separately from the RBG ones.
I also have a MagicHome controller that is RGB-only, with no white, and it is not having this issue. Only the RGBW controller is impacted by this problem.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
light:
  - platform: flux_led

Traceback (if applicable):
N/A

Additional information:
I'm currently running 0.89.2 and can upgrade to current or other version to help with testing changes if needed, however know that I am not experienced deploying code outside of the normal hass.io repository so will need some hand-holding at least the first time. Thanks!!

Do you have any experience with Python?

A tiny amount. Its on my to-do list. I do a bunch of php and a little javascript, self-taught, so I'm not a scripting newbie, just not had the opportunity to do much in python I'm afraid.

This sounds like it might also be my issue.  Setting RGBW only sets the white value, setting RGB will properly set the color.  The issue seems to be that sending RGB+W in flux_led only sets white: https://github.com/home-assistant/home-assistant/blob/7331eb1f7177e86cad2bbcd146fa6cc4b987494c/homeassistant/components/flux_led/light.py#L310

@jasl8r It was my change, because there are bulbs, handles RGB and White separetely and have problems with the current version of the underlying module. I am currently fixing the module, so I need to know which kind of controller you have. Can you download this https://github.com/autinerd/flux_led, run python3 striptest.py (you can stop the test after it prints the current controller status) and post it here, so that I know which controller can handle RGB and White together?

@autinerd
I have the same issue, since you implemented pull request 20733.  I have RGBW controllers and strips and can set RGB or W values independently only.  When trying to mix RGB and W led's together, only W led's respond, RGB's are off.   I was following issue #22405 and thought this was going to be addressed in HA 0.92... how disheartened I was that it remains.  My flux_led worked as it should until PR 20733.
I retrieved the controller status of my various controller modules (all are affected) using your striptest.py.  I hope you can get this working how it was previous to PR 20733.
Received controller status: b'8104236101100000000b04000029'
Received controller status: b'8104246101130000000b0400002d'
Received controller status: b'8104236101100000006404000082'
Received controller status: b'8104246101100000000b0400002a'
Received controller status: b'8104236101100000006404000082'

RGBW bulbs/strips are broken now as described setting white value turns off RGB. And setting RGB turns off W.

@autinerd running your test shows:
Please enter the ip address of the strip controller: <IP_ADDRESS>
Checking whether connection to controller works... yes
Received controller status: b'810423610110000000ff0400001d'
Checking whether controller is a strip controller... no

Hey @autinerd any chance of a fix?

So the only fix is to revert to an older version of this component?

I am also having issues - if I create a scene in home assistant to turn the lights a certain colour it only works if the lights are already switched on. Otherwise it will just turn on the lights but will not change their attributes. The attributes will just be whatever they were previously.

I am guessing your code is restoring the previous state, but not recognising that if new values are supplied then it should use those instead of restoring.

As a side note: the delay is a double edged sword. You've added a delay line so lovelace will update smoothly, but this causes a big issue if you are using groups. If I have 10 lights they all turn on one at a time very slowly due to the delay. Currently I have to use a custom component and comment this delay out for lights to turn on together. I would rather have my lights turn on together than have a smooth Lovelace.
Possibly could make the delay configurable so you can choose if you want it or not?

I have 4 Magic home wifi controllers with RGBW light strips
Running latest 096.4 Hass.io
Same issues as above, when the white is turned on with the slider I cannot turn on the RGB portion of the strip. I can do this perfectly with the magic home app running say red channel and the white channel together.
I also have issues in node red (and yaml autos) when the strip is told to turn on with a certain color, it turns on at the last color that was used ignoring the JSON data. The only way I have found is to have a second service node trigger off the first, then the first node turns it on and second applys the color/brightness.
thanks


Expose item to onDismiss closure

Awesome work with v2, congrats :)
It would be useful if the presented item is also exposed to the onDismiss closure, to adjust "cleanup" actions based on the item that was visible. Think of tracking each item that was opened, …
struct CustomItem {
 var id: String
  var name: String
  var url: URL?
  //…
}

struct ArticleList : View {
  // …
  @State private var itemToShow: CustomItem? = nil

  var body: some View {
      List {
        ForEach(viewModel.feedItems) { item in
           Button(action: { itemToShow = item }) {
               // …
          }
        }
      }.safariView(item: $itemToShow, onDismiss: { item in // <-- not possible at the moment
        print("Mark Item \(item.name) as read")
      }) { item in
            SafariView(
              url: item.url,
               configuration: SafariView.Configuration(
                // …
                ))
        }
  }

Thank you for your good suggestion :)
Though it would be hard to expose item since this modifier aims to follow API design of sheet(item:onDismiss:content:), I think what you want can be achieved using onChange(of:perform:) modifier.
struct CustomItem {
    var id: String
    var name: String
    var url: URL?
    // …
}

struct ArticleList : View {
    // …
    @State private var itemToShow: CustomItem? = nil
    @State private var shownItem: CustomItem? = nil

    var body: some View {
        List {
            ForEach(viewModel.feedItems) { item in
                Button(action: { itemToShow = item }) {
                    // …
                }
            }
        }
        .onChange(of: itemToShow) {
            shownItem = itemToShow
        }
        .safariView(
            item: $itemToShow,
            onDismiss: {
                print("Mark Item \(shownItem.name) as read")
                shownItem = nil
            }
        ) { item in
            SafariView(
                url: item.url,
                configuration: SafariView.Configuration(
                    // …
                )
            )
        }
    }
}


Add helper function to easily create lua libraries

Adds the RegisterLib(name, funcs) function to lua.go
This function allows for the simple and straight forward registration of libraries created from go, allowing for the following:
local example = require("example")
example.test()

Using lua libraries over the standard Register(name, func) has the advantage that script writers no longer have to deal with the annoyance of undefined global variables. I have also added an example to demonstrate the use of this new function.
Please let me know if you would like any changes, and thanks for maintaining this wonderful project.
Cheers!

reopened as #116  as I was using the wrong branch


Add sharding package and update validators

Summary
Commit 1: Add sharding package. I moved this to pkg/ so it can be accessed by both the server and cli as needed, but if this is no the right place, I can move it.
Commit 2: Update UUID validators to accept both current 64-char UUID and longer 80-char FullID defined in sharding package.
Ticket Link
Related to #487
(More work to be done before the issue is closed)

Thanks for the helpful comments, @bobcallaway . I've made some updates. Also I'm not sure what we should call the TreeID + UUID. I've been using FullID, but maybe there is something more descriptive?

Thanks for the helpful comments, @bobcallaway . I've made some updates. Also I'm not sure what we should call the TreeID + UUID. I've been using FullID, but maybe there is something more descriptive?

EntryID?

Nice job!


Raspberry pi, cant set it up?

I try to install everything and it just wont let me atall.
is there a possible pre-made setup script i can run to get it to work?

What do you mean by it won't let you? Was it giving you errors?

i cant seem to install that many dependencies on it. i try but get nothing

Is there anyway you could share, via screen shot or just copy/paste, what errors you are getting? Out of curiosity, what version of Raspberry Pi are you using (B, B+, 2, 3), and what size SD card do you have installed?

im barely even getting any actual errors. it says it installs fine. then
just dosent work.  8gb SD card 000e for the pi
On Thu, Apr 21, 2016 at 4:31 PM, Echoskope<EMAIL_ADDRESS>wrote:

Is there anyway you could share, via screen shot or just copy/paste, what
errors you are getting? Out of curiosity, what version of Raspberry Pi are
you using (B, B+, 2, 3), and what size SD card do you have installed?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/SexualRhinoceros/MusicBot/issues/212#issuecomment-212975529

So once you've installed everything, and you do "python run.py" it doesn't do anything at all? What behavior is it exhibiting?

apparently the pi isnt running python 3.5. even though it said it installed

Ah, you probably need to setup a virtual environment for python. Check out Digital Ocean's tutorial here: https://www.digitalocean.com/community/tutorials/common-python-tools-using-virtualenv-installing-with-pip-and-managing-packages
I have to do this with my system as well, so after you get the virtualenv setup I can help answer some questions if you run into problems.

well i doubt my pi could run it
On Thu, Apr 21, 2016 at 4:51 PM, Echoskope<EMAIL_ADDRESS>wrote:

Ah, you probably need to setup a virtual environment for python. Check out
Digital Ocean's tutorial here:
https://www.digitalocean.com/community/tutorials/common-python-tools-using-virtualenv-installing-with-pip-and-managing-packages
I have to do this with my system as well, so after you get the virtualenv
setup I can help answer some questions if you run into problems.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/SexualRhinoceros/MusicBot/issues/212#issuecomment-212983595

The pi shouldn't have any problems running this bot, but to be sure I'll run through the setup on one of my pi's and will let you know.

Even on my pi from 2011?

yes

Alright so it is not as easy as I thought it would be, and honestly I'm not sure if it is worth the time to go through and try to complete the install. The Model B doesn't support Ubuntu images available on the Raspberry Pi website, so unless you really really really want to invest the time (due to having to find the source and recompile the repos/packages), it probably isn't worth trying to run the music bot off your device. Maybe it isn't as difficult as I imagine it to be, but it is above my head at this time.

i still feel like it would be worth it but guess not
On Thu, Apr 21, 2016 at 7:48 PM, Echoskope<EMAIL_ADDRESS>wrote:

Alright so it is not as easy as I thought it would be, and honestly I'm
not sure if it is worth the time to go through and try to complete the
install. The Model B doesn't support Ubuntu images available on the
Raspberry Pi website, so unless you really really really want to invest the
time (due to having to find the source and recompile the repos/packages),
it probably isn't worth trying to run the music bot off your device. Maybe
it isn't as difficult as I imagine it to be, but it is above my head at
this time.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/SexualRhinoceros/MusicBot/issues/212#issuecomment-213061221

I'm pretty sure it's not as complex as he's making it seem

Python 3.5.1 can be built from source by doing:
wget https://www.python.org/ftp/python/3.5.1/Python-3.5.1.tar.xz
Then following the README after un-tar'ing it (tar -xvf Python-3.5.1.tar.xz). I'm searching around for Python3.5-dev and I can't find the source. Adding the deadnakes and trusty-media repos are above my head. Haven't searched for libsodium yet.

sweet thanks man
On Thu, Apr 21, 2016 at 10:53 PM, Echoskope<EMAIL_ADDRESS>wrote:

Python 3.5.1 can be built from source by doing:
wget https://www.python.org/ftp/python/3.5.1/Python-3.5.1.tar.xz
Then following the README after un-tar'ing it (tar -xvf
Python-3.5.1.tar.xz). I'm searching around for Python3.5-dev and I can't
find the source. Adding the deadnakes and trusty-media repos are above my
head. Haven't searched for libsodium yet.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/SexualRhinoceros/MusicBot/issues/212#issuecomment-213127779

Update: Worked on it some more, got the bot to start up but haven't fully tested yet.
cd ~
virtualenv --python=/usr/local/bin/python3.5 music_bot_virtualenv
source music_bot_virtualenv/bin/activate' Then your terminal will look like this" (music_bot_virtual) pi@raspberrypi ~ $ Now if you didpython --versionit should come back with 3.5.1 and you can dopython run.pyto start the bot (you'll have tocdinto the directory that you put the music bot repo in first). To deactivate the virtual environment, just type indeactivatefrom the prompt and you'll notice the(music_bot_virtual)` prefix on the terminal go away. From then on to get back into the virtual environment just do the source command as printed above.

The original Pi 1 doesn't have enough power to stream music without problems. Last time I tried that it would play at around 50% speed with pauses between. Pi 2 or PI 3 won't have problems though.

Ok so I'm running raspbbian Jessie on my RPI 2 and when I run "run.pt" this is what I get https://imgur.com/a/c6NoN

I think I came across something like this before; the first time I ran it I had to run it as sudo so it could install the dependencies, then after that I could just run it at my user level.

I ran this guide to install python http://bohdan-danishevsky.blogspot.com/2015/10/building-python-35-on-raspberry-pi-2.html?m=1 but I did run run.py as sudo

what command are you using to execute run.py?
python run.py ?

Python3.5 run.py

Just a shot in the dark, try
'sudo pip3.5 install -r requirements.txt'
or
'sudo pip3.5 install --upgrade -r requirements.txt'

If I run the cmd you gave it  automatically runs my cnd i gave

I get the same error as i posted on imgur

Ah now I see it's the PyNaCl module with the issues. My apologies.

Alright  I just tried to install PyNaCl onto my rasp pi and it gave me a similar error. Can you post a screen shot of your entire error? Mostly interested in what it says before the traceback.

Ok

https://imgur.com/a/Mo6pC This is everything that came up

sudo apt-get install libffi-dev

Ok so thats cmd worked but now a bigger different error
https://imgur.com/a/Jn99F

Ok up daye it works but no audio

Update i have the bot running on my raspberry pi 2 running the music bot by running ubuntu MATE
downfall it wont listen to any commands

I have a problem installing ffmpeg on my raspbian  Jessie on a Pi 3B. Does anyone have a solution for that?

Make a separate issue for that. And give more details.


Allow opening *.Diagsession files on machines without Visual Studio.

If you try to open a *.diagsession file on a machine without Visual Studio installed you will get the following error.
Exception Occurred: System.ArgumentNullException: Value cannot be null.
Parameter name: pathToNativePackagingDll
   at Microsoft.DiagnosticsHub.Packaging.InteropEx.DhPackage.GetPackageFactory(String pathToNativePackagingDll)
   at Microsoft.DiagnosticsHub.Packaging.InteropEx.DhPackage.LoadAndOpen(String pathToPackageAssembly, String pathToPackage)
   at Microsoft.DiagnosticsHub.Packaging.InteropEx.DhPackage.Open(String pathToPackage)

I turns out that we don't have a complete set of Diagsession support Dlls as part of PerfVIew.   It happens to work if you have VS installed, because it has logic to go see if VS is installed and use that if possible.
The missing file is
C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE\CommonExtensions\Platform\DiagnosticsHub\x86\DiagnosticsHub.Packaging.dll"

You want a amd64 version as well.
If we  add these to the distribution it should fix this.

We should upgrade the Diagsession DLLs while we are at it.  This requires updating the PerfView support packages, which is why I assigned this to myself.

Fixed by PR #278


Perlmutter setup

This PR adds the salloc commands for cori and perlmutter in the Reproducibility section.
Additional question from the Known Issues section:
* For secondary targets in SV1, the targeting catalog filenames recorded in the
  fiberassign header are inconsistent with the contents of the corresponding
  fibermap catalog for a given TILEID.

Isn't that fixed now, by the most recent major patch of the fiberassign files?

Thank you for this contribution, @weaverba137.

Additional question from the Known Issues section:

For secondary targets in SV1, the targeting catalog filenames recorded in the
fiberassign header are inconsistent with the contents of the corresponding
fibermap catalog for a given TILEID.

Isn't that fixed now, by the most recent major patch of the fiberassign files?

Yes, but for the v1.0 version of these VACs, this Known Issue is still relevant.

Follow-up on the known issue: after the major fiberassign patch, would the target photometry be more consistent if it were obtained directly from the fiberassign files, rather than stepping back to the targeting files? That only applies to assigned fibers, of course, not to potential targets.

The targeting files have always been correct. The re-patched fiberassign files just fixed issues that arose by not populating (some) data from the targeting files correctly (as well as some mixed-rows issues from the first round of patching).


Append new line between records when using custom --format

According to the documentation, when using the --format option, each error report must end with a new line, which is not the case.
Checklist
Not all of these might apply to your change but the more you are able to check
the easier it will be to get your contribution merged.

[ ] CI passes
[ X] Description of proposed change
[ X] Documentation (README, docs/, man pages) is updated
[ ] Existing issue is referenced if there is one
[ X] Unit tests for the proposed change

I just saw #55, but in #54 only deletion of \r was requested.
All lint tools I know use a breakline between error reports. The standard under Unix is a simple \n. That's why I think it would be a good idea to restore a \n at the end of each error.
Even if we obtain the same effect with {{"\n"}}, this seems to me a tricky way of proceeding for someone who does not know the Go language.
A better solution might be to add \r\n or \n depending on the OS.


SAMZA-2173: Fix NullPointerException in SetConfig MessageFormat when configurations are deleted.

Currently the configurations in the coordinator stream are deleted by sending a  Delete message with  message-map set as null and type set as SetConfig.TYPE.
To read configurations from the coordinator stream, there should be a check at the caller API to find if configuration message has been deleted or not. Otherwise it results in a NPE.
This patch encapsulates the isDelete check into the SetConfig class and returns null if the configuration key has been deleted.

@prateekm
Please take a look when you have a chance.

@prateekm
Currently to delete a key in coordinator stream, samza produces the message (key, value: null) into the coordinator-stream. This was the behavior since 0.9 version of samza.
Previously upto 0.8 version of samza, to delete a key, we used to serialize the null value into the json message and publish it to coordinator stream. Here's a sample message taken from the coordinator stream which follows this pattern in production.
offset: 314005  LogAppendTime:<PHONE_NUMBER>663  key: [1,"set-config","random-key"] payload: {"host":"random-host","source":"job-runner","values":{"value":null},"username":"random","timestamp":1255429967479}


node-gyp build and npm install both fail

I've tried to install using npm install node-stringbuilder and also I've tried building with node-gyp using  node-gyp configure build.
I'm using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Not sure if that is an issue there.
In both cases the builds fail with these messages:
c:\node-stringbuilder\node_modules\node-stringbuilder\src\node-stringbuilder.c(6): warning C4005: 'max': macro redefinition [c:\node-stringbuilder\node_modules\node-stringbuilder\build\node-stringbuilder.vcxpro
j]
c:\program files (x86)\windows kits\10\include\10.0.17134.0\ucrt\stdlib.h(1289): note: see previous definition of 'max'
c:\node-stringbuilder\node_modules\node-stringbuilder\src\node-stringbuilder.c(1315): error C2057: expected constant expression [c:\node-stringbuilder\node_modules\node-stringbuilder\build\node-stringbuilder.vc
xproj]
c:\node-stringbuilder\node_modules\node-stringbuilder\src\node-stringbuilder.c(1315): error C2466: cannot allocate an array of constant size 0 [c:\node-stringbuilder\node_modules\node-stringbuilder\build\node-s
tringbuilder.vcxproj]
c:\node-stringbuilder\node_modules\node-stringbuilder\src\node-stringbuilder.c(1315): error C2133: 'utf8Data': unknown size [c:\node-stringbuilder\node_modules\node-stringbuilder\build\node-stringbuilder.vcxpro
j]

I've found and fixed an allocation bug, please use node 8.6+ to try again.

Hello Ron.
It works now after changing the 2 lines concerning malloc.
The warning concerning redefinition of "max" still exists: probably not too
important.
warning C4005: 'max': macro redefinition
[c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\program files (x86)\windows
kits\10\include\10.0.17134.0\ucrt\stdlib.h(1289): note: see previous
definition of 'max'
The electron build also works using this instruction:
node-gyp rebuild --target=3.0.6 --arch=x64 --dist-url=
https://atom.io/download/electron
There were a bunch of warnings concerning type conversions:
c:\node-stringbuilder\src\node-stringbuilder.c(6): warning C4005: 'max':
macro redefinition [c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\program files (x86)\windows
kits\10\include\10.0.17134.0\ucrt\stdlib.h(1289): note: see previous
definition of 'max'
c:\node-stringbuilder\src\node-stringbuilder.c(73): warning C4244: '=':
conversion from 'int64_t' to 'uint32_t', possible loss of data
[c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(133): warning C4244: '=':
conversion from 'int64_t' to 'uint32_t', possible loss of data
[c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(250): warning C4244: '=':
conversion from 'int64_t' to 'uint32_t', possible loss of data
[c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(489): warning C4244:
'function': conversion from 'int64_t' to 'double', possible loss of data
[c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(848): warning C4244:
'function': conversion from 'int64_t' to 'double', possible loss of data
[c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(851): warning C4244:
'function': conversion from 'int64_t' to 'double', possible loss of data
[c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(848): warning C4244:
'initializing': conversion from 'double' to 'int64_t', possible loss of
data [c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(851): warning C4244:
'initializing': conversion from 'double' to 'int64_t', possible loss of
data [c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(1188): warning C4244:
'function': conversion from 'int64_t' to 'double', possible loss of data
[c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(1191): warning C4244:
'function': conversion from 'int64_t' to 'double', possible loss of data
[c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(1188): warning C4244:
'initializing': conversion from 'double' to 'int64_t', possible loss of
data [c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
c:\node-stringbuilder\src\node-stringbuilder.c(1191): warning C4244:
'initializing': conversion from 'double' to 'int64_t', possible loss of
data [c:\node-stringbuilder\build\node-stringbuilder.vcxproj]
My app called the module successfully:
var StringBuilder =
require('c:/node-stringbuilder/build/Release/node-stringbuilder.node');
My app ran the module successfully:
var sb = StringBuilder.from('First', 4096);
sb.insert('string');
sb.toString()  // returned "stringFirst"
So all good.
Thank you so much.  I'll keep you informed of any issues as I test the
module further in my app.
Should I post this in your issue tracker on github?

Eamon

On Fri, Nov 9, 2018 at 4:08 PM Magic Len (Ron Li<EMAIL_ADDRESS>wrote:

I've found and fixed an allocation bug, please use node 8.6+ to try again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/magiclen/node-stringbuilder/issues/1#issuecomment-437251795,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADCMupF5izNAu_D2SM-GTYQyOA1DA9g7ks5utQ3AgaJpZM4YV87R
.

Yeah, it takes time to fix the type warnings. Please file a new issue.

Since it seems fixed, you could probably close that issue.


luaformatter: combine with duplicate package lua-format, remove submo…

…dule usage

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 134716 run on x86_64-linux 1

1 package built:

luaformatter

its nice to use the libraries from nixpkgs since upstream doesn't seem to update submodules too often


Comparison between signed and unsigned integer expressions

Hello,
Attempting to compile using GCC with the -Wextra flag enabled raises the following error :
cc -c -fPIC -ansi -g -Wextra -Wall -Wconversion -Werror -O2 src/hll.c
src/hll.c: In function 'hll_load':
src/hll.c:131:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1: all warnings being treated as errors
make: *** [hll.o] Error 1

Once again, thanks for the quick update!


Spec cards layout for various screen sizes

Need to understand how cards will behave responsively. Thus far we have 2-, 3- (default), and 4-col layout options implemented for all screens.
See https://techne.yaas.io/starterpages/start.html. These changes from 3 to 2 to 1 per row.
See https://techne.yaas.io/starterpages/product-grid.html. These change from 6 to 4 to 2 per row.
What are the rules for the new implementations?

@xak
These files are also up on Zeplin.

@LeoT7508 You still have not accounted for the behavior of the 2- or 4-column layout. How should those behave?

I think this is already done on the different card groups


feat(header): update issues header

@mthanh2209 The commit message and branch name are not clear, as I check your change. It just simply removes redundant files. Please help me do it right again.

@mthanh2209 The commit message and branch name are not clear, as I check your change. It just simply removes redundant files. Please help me do it right again.

thank you, I will pay more attention.


allow deployContractByName to accept subfolder values

Currently blocked to have subfolders in cadence/contracts
For example,
return deployContractByName({ to: KittyAdmin, name: 'fungibletoken/FlowToken' })
does NOT work, resulting in error
error: invalid contract: the name argument must match the name of the declarationname argument: \"fungibletoken/FlowToken\", declaration name: \"FlowToken\"

@MaxStalker here was the issue I opened

@timongll please, try version 0.2.3-alpha.6 it should fix the issue :)

thanks works now!


Issue #153: Update documentation from Py2 to Py3

Corrected minor typo (supported_vensim_functions.rst)
Updated links to Teacup.mdl and Teacup.py to point to the PySD Cookbook repository (vensim_translation.rst)
Updated autofunction directive (functions.rst)
Updated documentation to reflect that PySD works with Py3 (installation.rst)
Updated links to PySD Cookbook (installation.rst)

Coverage remained the same at 89.527% when pulling 8d5e0e3f8b9621d05de5eb1a74f6ae20ef82fd03 on sepiatone:issue_123 into 7c273d52613e2181edc781996e3e9edb51af0572 on JamesPHoughton:master.


Remove backend modules dependencies

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)

I've tested on clean k3s cluster:

Service details view looks ok, but there are unnecessary calls (see dev console)
Create Function crashes busola
Application Mappings are still shown, even though application module is not there.


Onchange event on Select box triggers twice

The onchange event on my select box triggers twice.
By debugging it, I could find that in this line, there are 2 values being passed to multihook function and both the values are same i.e. onchange
@developit Can you please help?
If the above is the case and it's a bug, I'll be more than happy to contribute :smile:

@chiragmongia Ahh - you're seeing applyEventNormalization() called on the same VNode twice?  If so that seems like a bug.  Maybe we have that function add a hint indicating that it's already transformed a given VNode?

@developit Yes, you're right. So, I created a small jsfiddle to see what's happening.
In this fiddle, the event triggers only once. But when I remove /** @jsx h */ from the file, it starts triggering twice :astonished:
Can you help me understand what's happening here? :confused:

Ah yes - setting the JSX pragmatic to "h" actually bypasses preact-compat's VNode normalization. Since that's where the bug is, it only fires once. The default JSX pragma is React.createElement.

@developit Thanks for the help.
I'm using grunt-browserify. In Gruntfile.js, the configuration was-
[ "babelify",
	{
		'presets':['es2015', "react"]
	}
]

I've changed it to the following and it worked-`
[ "babelify",
	{
		'presets':['es2015', "react"],
		"plugins": [
			["transform-react-jsx", {
				"pragma": "h"
			}]
		]
	}
]

Now, the onChange event triggers once only.
PS - The same babelify configuration exists in .babelrc file as well. I'm not sure if I need that file anymore.
Thanks again! :+1:

Great! I'll probably do a PR to fix the double call still, but I'm glad it's working for you.
Only thing to be aware of is preact's h() does not support string refs, only function refs.

@developit The applyEventNormalization() is called once on the VNode but in this function, there is an if condition to check if nodeName is select, then is adds another onchange attr on it.
Removing this condition fixes the issue.
I'm raising a PR. Please check if it seems fine to you.


Management service address differs

We are using the latest version of spring-cloud-consul (2.2.0) and we are running our server in docker.
Our config looks like:
bootstrap.yml
spring:
  application:
    name: app-name
  cloud:
    consul:
      enabled: ${CONSUL_ENABLED:false}
      host: consul
      port: 8500
      discovery:
        enabled: true
        fail-fast: false
        instanceId: ${spring.application.name}:${random.value}
        prefer-ip-address: true
        prefer-agent-address: true
        acl-token: ${CONSUL_TOKEN}
      config:
        enabled: false
        fail-fast: false
        acl-token: ${CONSUL_TOKEN}

management:
    server:
      port: 5001

We are not able to use docker in host mode, but we are able to configure consul to use the host IP by querying EC2 for it. This is why we want to use the agent address.
Everything works fine but spring-cloud-consul registers the management service with the docker IP instead of the agent IP.
Here are the logs from the app:
Registering service with consul: NewService{id='app-name-70f3c70d62244a4b86e99002c4475b40', name='app-name, tags=[secure=false], address='null', meta=null, port=5000, enableTagOverride=null, check=Check{script='null', interval='10s', ttl='null', http='http://<IP_ADDRESS>:5001/actuator/health', method='null', header={}, tcp='null', timeout='null', deregisterCriticalServiceAfter='null', tlsSkipVerify=null, status='null'}, checks=null}
Registering service with consul: NewService{id='app-name-70f3c70d62244a4b86e99002c4475b40-management', name='app-name-management', tags=[management], address='<IP_ADDRESS>', meta=null, port=5001, enableTagOverride=null, check=Check{script='null', interval='10s', ttl='null', http='http://<IP_ADDRESS>:5001/actuator/health', method='null', header={}, tcp='null', timeout='null', deregisterCriticalServiceAfter='null', tlsSkipVerify=null, status='null'}, checks=null}

As you can see the address for the management service is different. (for the app it doesn't seem to be assigned when the message is logged and it's null).
I couldn't find documentation how to have the same address for both services. Please excuse me if this problem has been already mentioned in a question or in another issue.

For anyone experiencing the same problem we were able to solve it by setting the management address to null. We would be happy to know if there is a better way of doing this though.
    @Bean
    public ConsulManagementRegistrationCustomizer managementRegistrationCustomizer() {

        return managementRegistration -> {
            var service = managementRegistration.getService();
            service.setAddress(null);
        };
    }

The hostname defaults to an attempt to locate the local ip and host. See the docs for ignoring docker networks https://cloud.spring.io/spring-cloud-static/spring-cloud-commons/2.2.0.RELEASE/reference/html/#ignore-network-interfaces. Otherwise your solution is fine.

We use the same logic for the service as well. You'll need to provide a mapping from an environment variable to spring.cloud.consul.discovery.{hostname|ip-address} or set spring.cloud.consul.discovery.preferIpAddress=true if that works.


APEXMALHAR-2326 Use elasticMQ as a mock SQS server instead of using creds

@tweise  this is to fix the test failures in SQSStringInputOperatorTest. Pls review and merge

@amberarrow @vrozov  could one of you review this and merge?

Is there a ticket associated with this ?

@amberarrow  just created one https://issues.apache.org/jira/browse/APEXMALHAR-2326

@tweise @amberarrow  any comments? Can this be merged?

+1 for the idea in general, see comments.

I seem to remember some comment regarding required JDK for this?

@tweise  yes the following was in an email from me (should have put it in the PR here)
There is a Travis build failure because of dependency on Java 8 (https://travis-ci.org/apache/apex-malhar/builds/172145189)
Tests in error:
SQSStringInputOperatorTest.createMockServer:203 » UnsupportedClassVersion akka...
This article explains it: http://stackoverflow.com/questions/32959187/akka-hello-world-problems-unsupported-major-minor-version-52-0
So:

     Can we use Java8 for building/testing on the Travis machine?

     Note that akka-actor is used only in test-mode (test scope for elasticmq) so for the non-test code we are still okay (i.e. there is no dependency on Java 8)

Otherwise I’ll have to see if I can make it work with older akka or older elasticMQ

We use JDK 1.8 in Jenkins builds, so my preference is to continue to use default JDK 1.7 in Travis. This allows covering both 1.7 and 1.8 in CI builds.

@vrozov  in that case I will have to suppress the unit test when the current JAVA version is < 1.8. Is that okay?

Does 0.8.x require JDK 1.8 as well? Will downgrading the dependency help?

@sanjaypujare @tweise @amberarrow closed due to inactivity


Add NativeFileDialog class

This PR adds a NativeFileDialog class, interface modeled after FileDialog, which wraps a header-only cross-platform dialog library to display native file dialogs to the user.
Most features of FileDialog are present in NativeFileDialog, except for the Control-specific ones and a couple of others that didn't make sense with the wrapper nature.
I've also provided a rather bad but at least present icon for the class and a class reference that I think covers the whole class. Future versions need better error checking, and I'd also like to eventually tie into the other features of the library I hooked into, which supports notifications and modal dialogs as well, although those'll be separate components/classes.
This is my first real PR, so I'd appreciate any notes regarding either code or otherwise. I hope to contribute more frequently.
Relevant issue: https://github.com/godotengine/godot-proposals/issues/1123
Edit: Had a chat with @YakoYakoYokuYoku about some related PRs (#60501 and #47499) and the current proposal is for this implementation of NativeFileDialog to serve as an API template and preliminary implementation until eventual platform-specific implementations can be written using TrayBroker or a permutation of it.

I have an issue with this PR is that it collides with the purpose of #60501 as two of its purposes are to provide unified interaction with the desktop and, for Linux/BSD specifically, a DBus client for desktop services. The former might or might not apply with every communication you do with the desktop, but the latter should not be ignored as the FileChooser provided by xdg-desktop-portal is more reliable than zenity/kdialog in sandboxed applications (and probably in non-sandbox too).
But I don't want this to let you down as you can still do changes to this and take parts from Portable File Dialogs and use them with TrayBroker instead.

This implementation won't solve the issue with file system access by sandboxed macOS applications. It's probably won't work from a sandboxed macOS app at all. Sandboxed macOS apps can access most of the file system only via system file dialog, and require cookies to be saved to preserve access right across sessions. See #47499 for limited native file dialog implementation, done specifically for this purpose.

@bruvzg @spindlebink should we start a discussion on RocketChat?

I am not against this, I think it looks interesting but I have two recommendations:

Do not put this as core, it could be a pfd module
Seems a little missing in functions, is this all that is exposed by the pfd library?

This is pretty much the extent of PFD's functionality as far as file dialogs go. It also supports notifications, I think, but I haven't tied into them here as my goal was to do as close a representation of FileDialog as I could for now.

Ok I tested this PR and I have some feedbacks :

I think should be better if variables and functions are aligned with FileDialog.

So renomming start_directory by current_path (because yes it works with a file path to put default filename)
file_mode by mode (aligning the enum should be nice too)

It always emit file signal even when dialog is cancelled. Maybe adding a check in  _emit_signals_if_necessary to check if the result is empty.
There is no signal when dialog is closed. Could add in _notification function a hide signal. (Ones again to align with FileDialog behaviors)
Paths don't auto modify to work with current OS as Godot do (so for Windows we should manually replace / by \)
In open folder mode, starting path doesn't work at all for me, maybe a bug in the lib ?
In save file mode, current extension selected isn't added to the returned path so it's impossible to know the selected extension if not manually added in filename. But yes it's due to the lib I saw an issue about it.

* In open folder mode, starting path doesn't work at all for me, maybe a bug in the lib ?

It can be solved by always adding a slash to the end of the path.

<svg height="16" width="16" xmlns="http://www.w3.org/2000/svg"><path d="M2.5.75A1.75 1.75 0 0 0 .75 2.5v8a1.75 1.75 0 0 0 1.75 1.75h4.75v2H3a.75.75 0 0 0 0 1.5h10a.75.75 0 0 0 0-1.5H8.75v-2h4.75a1.75 1.75 0 0 0 1.75-1.75v-8A1.75 1.75 0 0 0 13.5.75zm11 1.5a.25.25 0 0 1 .25.25v8a.25.25 0 0 1-.25.25h-11a.25.25 0 0 1-.25-.25v-8a.25.25 0 0 1 .25-.25zM4 3.5a.5.5 0 0 0-.5.5v5a.5.5 0 0 0 .5.5h8a.5.5 0 0 0 .5-.5V5.75a.5.5 0 0 0-.5-.5h-2c-1.75 0-1.75-1.75-3.5-1.75z" fill="#fff"/></svg> Here's a simpler SVG that also doesn't have elements off-screen!

I think this PR is going to be eventually rejected, since #47499 and #79574 add native file dialog support as a simple toggle on FileDialog (only for macOS and Windows so far).

These have now been merged (for 4.2?) so we have another way of accessing native file dialogues via the FileDialogue.use_native_dialog property and the same has also been implemented for linux in https://github.com/godotengine/godot/pull/80104. So it seems all the functionality of this PR has now been implemented in a different way and this can be closed?

Closing as superseded by the aforementioned PRs.
Thanks for your contribution nonetheless.


xray daemon doesn't appear to recognize EKS Pod Identity

I believe the image aws-xray-daemon is built on an older SDK version (v1.44.298) which does not support the EKS Pod Identity:
https://aws.amazon.com/blogs/aws/amazon-eks-pod-identity-simplifies-iam-permissions-for-applications-on-amazon-eks-clusters/
https://docs.aws.amazon.com/eks/latest/userguide/pod-id-minimum-sdk.html
Hopefully this is just a mater of update the Go SDK, test, push, update xray container image.  I will create a PR for the version change and run tests if time permits and link here.
Is there a chance of getting an updated version pushed out? I'd prefer we not have to build this ourselves.  I know another option is ADOT ( https://aws-otel.github.io/ ) but ideally either a) there is guidance suggesting to move to that, or b) we do the full switch to open telemetry from xray.

@bitshop Thanks for your info. It is the right way that XRay daemon use the latest AWS SDK for Go dependency.
Please help submit PR, we will review it and schedule a release for this change.


calling import_graph_def with op_dict dependency

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (you are using): 1.13
Are you willing to contribute it (Yes/No): Yes although I'm far from an expert

Describe the feature and the current behavior/state.
I'm using import_graph_def to load and deploy a model stored in an .pb file. I'm opening an issue because I saw the following message:

calling import_graph_def (from tensorflow.python.framework.importer) with op_dict is deprecated and will be removed in a future version.
Instructions for updating:
Please file an issue at https://github.com/tensorflow/tensorflow/issues if you depend on this feature.

Please let me know if there is an alternative that won't be removed soon.
Will this change the current api? How?
Most likely not
Who will benefit with this feature?
Users who have such a dependency, including the users of our CaImAn package.

Don't pass an op_dict then.

can anybody help me in this issue "ValueError: node 'Placeholder' in input_map does not exist in graph (input_map entry: input_image:0->Placeholder:0)"


Recognize and report appropriately unsupported Excel formats

"WARNING \\*\\*\\* OLE2 inconsistency: SSCS size is 0 but SSAT size is non-zero\" | grep -v \"\\*\\*\\*"
[...]
NoMethodError: undefined method `close' for 0:Fixnum
```

PR https://github.com/CartoDB/cartodb/issues/6361 fixed this. Closing.

This error is reproducing again today: https://github.com/CartoDB/support/issues/145 We have had three cases so far. Should we open this issue again?
cc @rafatower

No, that's a different issue. Look for it in the repo, iriberri was already working on it.


[Migration] The whole Code Base on Typescript

This issue is just to request for handling or inviting developers for migrating the code base to typescript.
Benefits

high definition type
More Secure code base
More readable and beginner friendly code
Splitting out of the  compilation errors
Huge numbers of existing types available already by the packages used in this project

My approach planning
We can start the migrating in a separate branch
The migration can start with moving the tests to typescript
I would appreciate hearing back from the team for this.

@fazlerocks @sandeeppanda92 @mayankchd What you guys think ?

@anikethsaha Go ahead.


hapi pal

Working on a backend implementation using hapi pal, a suite of tooling and methodologies for building nodejs web services with hapijs.  The model layer is based upon Objection ORM.
Track progress here! https://github.com/devinivy/hapipal-realworld-example-app

[x] Fork the starter repo & post the link in this issue
[x] Create logo for repo & update issue status
[x] Implement all of Conduit's functionality per the spec & API
[ ] Move repo to main org & Peer review final codebase
[ ] Tag v1 release and officially list it on the README

I still need to write the readme, but this is essentially ready for review.  Here's all you need to know to get started,

Deployment and configuration is contained in server/.  You must cp server/.env-keep server/.env then set an APP_SECRET in there, used for generating JWTs.
Application code is contained in lib/.
It runs under sqlite3, which is installed during npm install.
The database is keyed off of the NODE_ENV, and persisted to the filesystem at .{env}.db within the project's root directory.  So NODE_ENV=production is persisted to .production.db, NODE_ENV=development to .development.db, and a missing NODE_ENV to .default.db.
npm test runs tests and npm start runs the server.

This really oughtta be good to go—I would love a review!  There is now a fairly extensive explainer in the readme: https://github.com/devinivy/hapipal-realworld-example-app

Trying to get to it soon @devinivy, sorry for the delay 😬The repo looks great, I just need to run it locally and take a look. I'll try to get to it this week at some point.

No sweat at all—thanks for the update!

@devinivy would you mind adding this to TravisCI? Thanks!

@anishkny should be all set now 👌

@anishkny @Cameron-C-Chapman is there any action I need to take here?


Bump kubevirtci: sriov provider fixes

Signed-off-by: Or Mergi<EMAIL_ADDRESS>
What this PR does / why we need it:
This PR bumps kubevirtci in order to get changes from https://github.com/kubevirt/kubevirtci/pull/397
this part of stabilizing sriov lane effort.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/test pull-kubevirt-e2e-k8s-1.17-sriov

/test pull-kubevirt-e2e-kind-1.17-sriov

/test pull-kubevirt-e2e-kind-1.17-sriov

/test pull-kubevirt-e2e-kind-1.17-sriov

/test pull-kubevirt-e2e-kind-1.17-sriov

/test pull-kubevirt-e2e-kind-1.17-sriov

/test pull-kubevirt-e2e-kind-1.17-sriov

Can you please separate the unrelated changes to tests/utils.go? They don't belong to this PR..

Generally speaking, the 2 commits of the bump can be squashed to one please,
currently there is a little bug that cause the need of running make bump-kubevirtci and then make generate, i assume this what was misleading.

Thanks
/lgtm

Thanks!
/approve


how can i download this package?

i can not find this package in the anaconda?if you have free time,please help me solve the issue！

Just install it from git via pip install git+https://github.com/mnick/scikit-kge.git

Thanks it install. But how can I get in my IDE Pycharm project interpreter? any python version problem?


Add Zoom/pan to editor view.

Add zooming, using scroll wheel and
middle mouse button to pan.
Manipulator class modified to support function.
Fix launching of dwpicker in Maya 2020 (<Python 3.6 version doesn't support f'' string formatting)

Any notes for this? What can I do to make it mergeable?

damn i missed this, let me try it out

Ok, so firtly, i'm super sorry review this so lately, I've seen your post so many time, and though: "I already seen that".
But trying to clear my tickets, I realized that actually no, I never opened the ticket and only realise what it is about now :/
I tried your branch ! This a really nice work. Codewize I'm totally ok with the style.
Before to go further, if you are still motivated to collaborate the code, I encountered few bugs with your version.
As you can see in the video:

the selection square doesnt seems to work ?
The canvas does not resize with the scroll area then it cuts the edges
Middle click to navigate always place the canvas at strange coordinate when I start to manipulate.

https://github.com/user-attachments/assets/9cf592f4-ec7d-45a4-91ce-1ff5f3e033ca
If you are able to fix those steps, I would be more than happy to merde !

hi, pan zoom would be a really good improvement. will there be an update soon? @markusng @luckylyk

@markusng Finally added the feature based on your code.
I fixed everything was going wrong and also removed the concept limiting the picker to a defined size (which was legacy from hotbox designer but not making sense for a picker)
Your code as conflict with new commits then i made some copy paste instead of merging it directly. But you are added in the "about" window as contributor :)
This is not committed / released yet but coming later tonight !
Thanks again for you contribution
Lio

Thank you!  Much appreciated.  I was just starting to see I could fix the
odd center pivot bug.   Glad you've figured that out.
On Sun, Dec 8, 2024, 3:20 p.m. Lionel Brouyère @.***>
wrote:

@markusng https://github.com/markusng Finally added the feature based
on your code.
I fixed everything was going wrong and also removed the concept limiting
the picker to a defined size (which was legacy from hotbox designer but not
making sense for a picker)
Your code as conflict with new commits then i made some copy paste instead
of merging it directly. But you are added in the "about" window as
contributor :)
This is not committed / released yet but coming later tonight !
Thanks again for you contribution
Lio
—
Reply to this email directly, view it on GitHub
https://github.com/DreamWall-Animation/dwpicker/pull/97#issuecomment-2526362801,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADRDPZOEW45I4I73KEV5GD2ESSY5AVCNFSM6AAAAABKW46IIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRWGM3DEOBQGE
.
You are receiving this because you were mentioned.Message ID:
@.***>


Fee estimation not working

Attempting to create a transaction using the "Send All" option results in the following error:
"Could not send payment: Insufficient funds for fee"

Strangely, there was already a fix for the web wallet in another issue a month ago. (Issue: https://github.com/decred/copay/issues/7) (PR: https://github.com/decred/copay/pull/13) (Commit: https://github.com/decred/copay/pull/13/commits/a583538d29679df07942dccab7a75dce654537d1)
However I still get this error currently, can you look into it? @alexlyp

@alexlyp does this look like a case of copay just using an old wallet when this happened?  If so I'd like to close the issue but not if it still happens.

I'll verify that it works for me then I'll close or update this issue depending on results.

I was just able to 2 send alls on mainnet.
Going to close this issue for now.  If people are still running into it, I'll need more information about how it may have been tripped.

Okay, I can confirm the "send all" works now.


How can I fine-tune or train  Grounding DINO on my own dataset.

same questation

https://github.com/IDEA-Research/GroundingDINO/issues/228

the same issue

the same issue

same issue, i want to fine tune it for satellite data


Exception of new object in multithreading

I uploaded a file!
ThreadDemo.zip

{$DEFINE SScript2} is normal!

I can confirm an access violation. Thanks for finding this I'll post a new issue with a MCVE as there's too much unrelated code in your example.
BTW this code is wrong:
RegisterMethod(AInstance, 'free', @TConsole.Free);
Any method you wish to register as a native callback must have the specific signature:
function(Args: PJsValueRef; ArgCount: Word): JsValueRef of object;
(as shown in the TConsole example).

Sorry, I used it wrong
RegisterMethod (AInstance, 'free' @ TConsole. Free);

Sorry, I used it wrong
RegisterMethod (AInstance, 'free' @ TConsole. Free);

No problem, and thanks for reporting.

Constructors of projected classes must be addref-ed to prevent them from being garbage-collected.
Thank you for finding and reporting it.

See TestFinalizer4 for a minimal example to reproduce the problem: simply call the script in a loop long enough until GC releases the constructor - . The next attempt to call the constructor will cause an access violation.

You may have to submit an issue to chakracore using c++

Sorry for being unclear. The issue was on the chakracore-delphi side (Pascal), and it's fixed now.

I see！thank you！

Welcome and thank you for your help.


Enrich date

Adds date parsing logic for:

enrich_date
enrich_earliest_date
add_facet_decade
make_sort_dates
unpack_display_date

All fetched vernacular data is run through a mapper. I did not do an analysis of what different mappers are doing with regards to date. Once the record is mapped, enrich_date and enrich_earliest_date are optionally run, pending their configuration in the enrichment chain for that particular collection.
enrich_earliest_date: retrieves the mapped record's date value, manipulates it, and then replaces the mapped record's date value with the results of it's manipulation. Internally, convert_date converts a string or list of strings into a list of dictionaries with the keys: begin, end, and displayDate. Strings are parsed using DPLA's zen library: https://github.com/dpla-attic/zen (used in DPLA's ingestion 1 and copied here with some minor python2 to python3 updates to duplicate existing functionality). If the mapped record's date value is already a dictionary, or if it is a list containing any dictionary, it does no date manipulation and simply returns the date value.
Despite its name, I didn't see any indication that enrich_earliest_date has any kind of logic determining what dates are "earliest".
enrich_date: does the exact same thing as enrich_earliest_date, except it takes a field name as an argument, operates on the value of the specified field name, and replaces the specified field's value in the mapped record. The default field name is temporal. In my analysis, enrich_date exists in 2,749 enrichment chains with no field name specified, and exists in 1,003 enrichment chains with the field name date specified. Instances of enrich_date&prop=sourceResource/date are functional duplicates of enrich_earliest_date, and since convert_dates does not perform any manipulation on lists of dictionaries, this duplication has no effect on the record. There are 3 collections that have enrich_date&prop=sourceResource/date but do not have enrich_earliest_date in their enrichment chains.
Unlike the two enrichments listed previously, the following 3 functions run on every record (except Calisphere Solr extracted records), regardless of enrichment configuration:
add_facet_decade is part of the solr_updater function that was migrated from our legacy harvester and operates on the date value of the mapped and enriched record to write to the facet_decade field in the solr_doc (the final output of the metadat_mapper module). It is difficult to say what this date value might look like at this point, since there are some collections that never call enrich_earliest_date and also never call enrich_date&prop=sourceResource/date. In those cases, the value of the date field looks as it does whenever the mapper is finished with it. Some mappers do seem to produce lists of dictionaries with the keys begin, end, displayDate (providing their own special, mapper-specific date parsing logic), but it seems that some mappers also simply produce strings, or lists of strings. Nevertheless, add_facet_decade makes the date value into a list if it is not already, and then tries to get_facet_decade for each value in that list - returning the first successful response from get_facet_decade. For its part, get_facet_decade does it's own special parsing of the displayDate using Brian's decade facet logic.
make_sort_dates is also part of the solr_updater function and operates on the date value of the mapped and enriched record to write to the sort_date_start and sort_date_end fields of the solr_doc. It depends on the date value containing at least one dictionary with the begin and end keys. If the date value contains multiple dictionaries with the begin and end keys, it sorts all the begin dates and returns the first one as the start date, and then sorts all the end dates and returns the first one as the end date.
unpack_display_date is also part of the solr_updater function and operates on the date value and the temporal value to write date and temporal values to the solr_doc. This function turns the value into a list if it is not already, and then for each element in the list, if it's a dictionary, puts the displayDate value in the return value, and if it's a string, puts the string into the return value, and finally returns this new list of display dates and strings.

There are also some updates to the validator. We shut down the CouchDB instance, so validations against couch no longer work. As such, I've commented out is_shown_by and is_shown_at validation functions.

There is also a new test, the metadata_mapper/test/test_date_processing.py module, along with 5 csvs defining inputs and expected outputs to the previously mentioned 5 functions. These csvs were created using the 27 test collections specified here: https://docs.google.com/spreadsheets/d/1JNw7ynxCJS8d4f5W4Glwwqx0qMm8ss-aB_GpjVxN1dI/edit?gid=0#gid=0 (filter on Calisphere Solr Mapper Type = No) and their validated output. You can run these tests using pytest metadata_mapper

This PR requires a new pip install in your environment - I've added a new dependency to the project, timelib
I'm also not 100% sure the conditional validation works (commit: 1b78253) - I'm not sure which OS the validation_collection_task is running on, and if the UCLDC_SOLR_URL and UCLDC_COUCH_URL are available within that environment, but this is the general idea regarding conditional validation.

Also, another parsing library to consider in the future is https://github.com/bear/parsedatetime


The used time to run this code?

I run this code in GeForce GTX 1070, and each epoch costs 8 mins.
20000 epochs may cost 200 days.....
I not sure what's wrong.

Hi,
I think you need not run 20000 epochs. I forgot the exact number of epochs I used to run. But its not more than 100 (maybe 60?). You can see when the training loss flattens and stop the training.
You are right. 20000 is misleading. But the reason is that, when I developed the code, I wanted to run the training indefinitely and test each epoch.
Hope it helps.


docs: Add default blockdevicemapping info

Fixes #3528
Description
Adds docs for default blockDeviceMappings
Does this change impact docs?

[x] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

NONE

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

is this the same as https://github.com/aws/karpenter/blob/ffc77057/examples/provisioner ?


Port from GConf to Gio.Settings

https://github.com/sugarlabs/activity-turtle-flags/blob/ac20359849272efa9c1978d979218b5782c21523/collaboration/buddy.py#L98

Will be working on this activity in a similar fashion as Turtle Confusion, once the PR in it gets merged.

Thanks!
After that, you will be in a good position to assess if the repositories can be recombined in order to generate three different bundles from the same repository, or make the unique features a menu option in the main repository.  i.e. the reverse of project forking.


Compile failure: "appProperties is not defined"

eureka/register/services/register-service.js
line 20  col 32  'appProperties' is not defined.
⚠  1 warning
JSHint failed, fix the issues and rerun task.

This is an easy fix, I already fixed it.
But since you changed code in phenotype-service.js by injecting appProperties into PhenotypeService
(PhenotypeService.$inject = ['$http', '$q', 'appProperties'];)
as an additional service, the Jasmine test code(phenotype-service-spec.js) failed, because it does not recognize appProperties.
I need more time to fix the Jasmine unit test cases since AngularJS Jasmine is new to me.

Just pulled a request, please review it, thanks!


better SCA e2e tests, fix no-provides bug

Fixes https://github.com/chainguard-dev/melange/issues/1366 by not early-exiting when no-provides: true
This also adds golden testdata output that should catch future SCA changes. 🤞

To demonstrate the fix: https://github.com/chainguard-dev/melange/pull/1369/commits/ee2b64f8d2b851d5b07a9e3d0a4b95256ecad99a added the early exit and the go test failed


Advanced border field adds !important to parent CSS by default.

Problem Description
Advanced border option adds the  !important to parent CSS but not to the child module CSS  on the frontend, which makes it difficult/imposible for the child CSS to override the parent CSS.
Adding the 'important' property (like you do for the 'fonts' and 'margin_padding' fields) does not help (tried to remove the !important from parent CSS or to add the !important to child CSS) because looks like it is not supported by the borders field.
Ideally, I would prefer the !important not to be added by default, still wondering why it is being added to the parent CSS. Seems to be a bug.
How can the !important be controlled for the advanced borders option? Thanks.
Steps To Reproduce

Add the borders filed into the get_advanced_fields_config() methods of both the parent and child module:

Parent borders option:
$advanced_fields['borders']['parent_header'] = array(
	'css' => array(
		'main' => array(
			'border_radii' => "%%order_class%% .header",
			'border_styles' => "%%order_class%% .header",
		),
	),
        'defaults' => array(
                'border_radii' => 'on||||',
                'border_styles' => array(
                    'width' => '0px',
                    'color' => '#f4f4f4',
                    'style' => 'solid',
            ),
        ),
	'label_prefix'    => esc_html__( 'Child Header', '' ),
	'tab_slug'        => 'advanced',
	'toggle_slug'     => 'parent_header_toggle',
);

Child borders option:
$advanced_fields['borders']['child_header'] = array(
	'css' => array(
		'main' => array(
			'border_radii' => "%%order_class%% .header",
			'border_styles' => "%%order_class%% .header",
		),
	),
        'defaults' => array(
                'border_radii' => 'on||||',
                'border_styles' => array(
                    'width' => '0px',
                    'color' => '#f4f4f4',
                    'style' => 'solid',
            ),
        ),
	'label_prefix'    => esc_html__( 'Child Header', '' ),
	'tab_slug'        => 'advanced',
	'toggle_slug'     => 'child_header_toggle',
);

Screenshot and/or gif

Since apperantly it is not possible to remove the !important from parent module borders CSS, the solution would be to write a function that would generate the child module borders CSS just to add !important to it so that it can override the parent module CSS.
But I wouldn't like to do so because the borders field is already generating the child CSS by default and my function would also generate the same CSS but with !important, so it's kinda ugly workaround.
Any other better solutions? @lots0logs . Thanks.


feat: Added Spotify Clone

Closes #232

@Kritika30032002 Please review the PR

@Kritika30032002  Can you please see the PR , less than 1 hour is left for IWOC to end

@Kritika30032002 please see to it
Last 20 mins are left


Allow selecting multiple cells by dragging

Like this:

Do you mind if I work on this?

Thank you very much, of course! I would appreciate it if you would contribute to this project. :tada:

Great!


Is this usable and still active?

Hello, it is still usable but not very active because SimpleDB itself is
not very active. I think you are getting this error because you have not
run maven from the root of the project directory - could you please confirm?
On Fri, Oct 9, 2015 at 11:19 AM, raja<EMAIL_ADDRESS>wrote:

Get this error when got the master and ran a clean install. Am I missing
anything?
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.10:check (default) on
project spring-data-simpledb: Failed during checkstyle configuration:
cannot initialize module SuppressionFilter - Cannot set property 'file' in
module SuppressionFilter to './etc/check-style-suppressions.xml': unable to
find ./etc/check-style-suppressions.xml: InvocationTargetException:
./etc/check-style-suppressions.xml (No such file or directory) -> [Help 1]
—
Reply to this email directly or view it on GitHub
https://github.com/3pillarlabs/spring-data-simpledb/issues/10.


pythonPackages.pycapnp: fix by moving pkgconfig back to buildInputs

Description of changes
Unbreak pycapnp, by moving pkgconfig back to buildInputs.
(FWIW pkgconfig here is the python package, not pkg-config the native
tool).
Fixes #170796.
Partially reverts 30b30332967dc5caadd84c3d5930221e5c7813d6 .
As an aside, it's curious why this needs to be a buildInputs-- and
cython doesn't-- but it does appear to be the case.
That commit does not appear to have worked even at the point it was
made, I'm not sure what the story is there.
(it appears to be the "right thing" AFAICT based on docs, however)
There's more to look into re:pkgconfig but I'll file an issue soon.
If/until that's resolved, this fixes pycapnp.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

As an aside, it's curious why this needs to be a buildInputs-- and
cython doesn't-- but it does appear to be the case.

Both should be in nativeBuildInputs.

This is a problem with python3Packages.pkgconfig, not your package. Going to create a PR that fixes it.

Great, thanks! Yeah this is wrong.


Does it make sense for pocean to have a CFVariable object?

I don't mean for pocean to re-write iris functionality nor to be an xarray alternative but this notebook makes me think a simple CFVariable, with some CF model concepts, could help improve ecosystem a little bit. What are your thoughts on this @kwilcox?

We have cf_xarray now and we should not duplicate that functionality here.


Varargs and kwargs should be identified differently

If keyword arguments contains varags or kwargs and keyword completion is used. Then all arguments looks the same, but it could use a Python style to identify different argument types. Use *agrs for varags and **agrs for kwargs.

This is not issue for library keywords. Investigate for user keywords.

This is not issue in user keywords. Added wontifx because this already works as planned


github: move pull request template tip into comment

Signed-off-by: Rustin-Liu<EMAIL_ADDRESS>
What have you changed?
Modify pull request template.
What is the type of the changes?

Misc (other changes)

How is the PR tested?
None
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
None
Does this PR affect tidb-ansible?
None
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Any examples? (optional)

/merge

/test

/merge

/test

/merge


Set Size Limit?

Is it possible to set a MAX size limit for the returned image? If not, what is the best way to make sure that the image is maximum quality under a certain size? Thank you for the great library!

压缩后的图片质量很不好啊，自己还要判断图片大小才能确定是否压缩。

@umeitime 不需要自己判断的，内部自动以当前手机分辨率为最佳显示效果进行压缩的

@umeitime The maximum size of the image is  screen resolution. Or you can set the size of the compressed images.

我的意思是比如图片本身小于200kb的话，我就不压缩了，因为图本身小，再压缩就非常模糊了。

What I mean by size is the file size. I would like all images to be compressed below 500KB/0.5MBs. Can the library do that or do I need to test the sizes myself and then recompress if the file is still larger?

@umeitime 图片小于200kb？如果是质量压缩，文件本身的大小为200kb，通常用为图片上传，你可以判断文件大小是否大于进行压缩，如果大于可以设置压缩后期望大小（options.size）来进行压缩大小设置。如果是图片本身所占内存压缩为不大于200kb，内部衡量是对图片与当前设备分辨率大小进行判断的，小于设备分辨率则自动不进行压缩

@searchy2 Yes. The library will compress files for you in the expected sizes automatically. For you example, you can set ‘FileCompressOptions.size = 500’ .

Thank you so much! An option to set file size is just what I was looking for :+1:


Add types.EventType, use in supervisor package

This is re: additional suggestions for https://github.com/docker/containerd/pull/48 - I wanted to send one or two in smaller CLs to give you a little flavor of what I'm talking about.
Overall, I would think to use the messages in api/types as the base data type for supervisor. Using protobuf generated messages as DTOs is a general big win for consistency, and it forces a programming style that can lead to less bugs down the road. As an example here, instead of having type EventType string, we've used protobuf to generate an int32 enum for us. By being an int instead of a string, developers are almost forced to use actual enum const values as opposed to freeform strings, the latter of which can lead to types in the codebase that are not tracked as consts (https://github.com/docker/containerd/blob/1d63236c2711e1f9567792daa9f81f263229075c/api/grpc/server/server.go#L234 and https://github.com/docker/containerd/blob/1d63236c2711e1f9567792daa9f81f263229075c/api/grpc/server/server.go#L241).
Let me know what you think.

I'm not opposite to it. But I think @crosbymichael thought that later refactoring might be simpler if we use grpc structs only for API, like immutable layer between a client and internal logic.

So I totally have done that before, and completely get it, but in my
experience with protobuf in golang, the benefits of using the api structs
internally outweighs the negatives. Happy to chat about it if you'd like.
On Friday, December 18, 2015, Alexander Morozov<EMAIL_ADDRESS>wrote:

I'm not opposite to it. But I think @crosbymichael
https://github.com/crosbymichael thought that later refactoring might
be simpler if we use grpc structs only for API, like immutable layer
between a client and internal logic.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/containerd/pull/50#issuecomment-165830727.

@peter-edge this depends on our versioning strategy for the protos and API.  If you can help us figure that part out as well then this change would be awesome.  I'm not an expert on protos and grpc so any help is appreciated.

For sure. I'll try to relay some of my thoughts in a github issue, or feel
free to ping me on gophers
On Friday, December 18, 2015, Michael Crosby<EMAIL_ADDRESS>wrote:

@peter-edge https://github.com/peter-edge this depends on our
versioning strategy for the protos and API. If you can help us figure that
part out as well then this change would be awesome. I'm not an expert on
protos and grpc so any help is appreciated.
—
Reply to this email directly or view it on GitHub
https://github.com/docker/containerd/pull/50#issuecomment-165865173.


VPRT support for D3D11, D3D12, GL

See https://github.com/bkaradzic/bgfx/issues/2320 for more info. Would appreciate feedback from @MarkVabulas if this needs any extra changes.
This required changes to glsl-optimizer to make it accept ARB_shader_viewport_layer_array together with gl_Layer and gl_ViewportIndex. Since that library is apparently not maintained, I fixed it here instead of trying to submit the changes upstream.
D3D11 and D3D12 worked out of the box, only needed minor changes to correctly resolve multi-layer MSAA textures and advertize the caps bit.
With GL there are two caveats:

only shaders with versions < 400 work with this. I don't understand the shader patching code well enough to make this work for 430 without potentially breaking lots of GL code downstream.
MSAA multi-layer framebuffers are not supported. The resolve code seems to assume that MSAA targets are always renderbuffers, but those don't support multiple layers. Can probably be fixed by someone who understands the GL backend code a bit better.

VK already supports this, no changes required.
Here's a patch that modifies example 21-deferred to use VPRT to render instanced cubes to two different layers of an array texture:
vprt-test.patch.txt
You should see the following output:

I wouldn't bother with GL. Just make it not supported.

Only important feature for GL are WebGL features.


Add FFTW, Bison, M4 and Flex

They are dependencies of NGSPICE which I intend to add in a follow up commit.

@QuantamHD I rebased the PR and fixed the conflicts. PTAL.

I added a bunch of more things. Sorry about the huge PR... But in this case I think splitting it up doesn't really make it more reviewable since it's all quite separate.

Once this is reviewed I can continue with Tcl, Yosys, Project Trellis, Nextpnr. That's most of what I have I think.

I don't have merge access to this repo, so if someone can push the merge button that'd be good. Then I'd be able to make a fresh follow-up PR without adding to this insanely large one :smile:

@per-gron - Your access level should now be fixed.


Fix typo: 'regularizaion' --> 'regularization'

This PR contains a quick typo fix.

This is now fixed -- thank you! (this repo is not yet set up to allow contributions, as google has some additional rules on that, so it was more straightforward just to fix directly).


Fix nits in #8703

We should also make it not fail if E2E_OPT is not defined. (Right now one must set E2E_OPT="" explicitly, which is annoying.)
In reality we should probably clean this up significantly; there are now many Jenkins builds calling this script, with lots of mysterious behavior based on what environment variables are specified.


Field allocation for SSI capability

Allocate gridded fields to use the pinflag option needed for the Single System Image  (SSI) capability.
Description

In subroutine MAPL_FieldAllocCommit, gridded fields are allocated from scratch with the pinflag option such that the SSI capability of ESMF can be used as necessary. Using thsi capability is essential for the mixed hybrid code with the dyncore hybrid MPI/OpenMP and the rest of GEOS GCM using only MPI.
Related Issue

Motivation and Context

Mixed hybrid code
How Has This Been Tested?

Zero diff through c720

Stock g5_module but with ESMA-Baselibs-7.16.0 (at least ESMF 8.6.0)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)

Checklist:

[X] I have tested this change with a run of GEOSgcm (if non-trivial)
[X] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
[X] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

I think this is meant to go to develop. I'll update the base.

NOTE: I think the CI issues are due to CI quirks grabbing the other feature/aoloso/hybrid_112923 branches in FV and GCM (via mepo checkout-if-exists). I can confirm both Intel Release and Debug run. I'm doing GNU Release and Debug tests now.


How can I probe these images?

I'm building this open source tool based on your library.
But sometimes it probing images, e.g. when I try to probe these two:

https://www.isabelmarant.com/17/17210600cc_20_r.jpg
https://www.dunhill.com/product_image/45634378WS/f/w508_bffffff.jpg

If I try with:
curl -A 'test' https://www.dunhill.com/product_image/45634378WS/f/w508_bffffff.jpg

I get an HTML response back

<TITLE>Access Denied</TITLE>

Access Denied

You don't have permission to access "http://www.dunhill.com/product_image/45634378WS/f/w508_bffffff.jpg" on this server.

Reference #18.8b0c1502.1650662288.5bba5dc

Any suggestion on how I could cheat and get the image response?
Thank you in advance for your help

Additional info
I tried with
curl -A 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36 Edg/100.0.1185.50' https://www.dunhill.com/product_image/45634378WS/f/w508_bffffff.jpg

And I got the expected binary output!
but if I do
const naturalWidth = await probe(imgUrl, {
  response_timeout: 100,
  follow_max: 5, // follow up to five redirects,
  rejectUnauthorized: true, // verify SSL certificate
  user_agent:
    "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36 Edg/100.0.1185.50",
})
  .then((res) => {
    console.log("...succeded");
    return res.width;
  })
  .catch((err) => {
    console.log("...failed");
    console.error(err);
    return 0;
  });

What am I doing wrong and how can I make this work with your library?
Thanks

I found the solution. This particular server requires additional headers.
From my experiments, the minimum code required to make the above work is:
const imgIntrinsicWidth = await probe(imgUrl, {
  headers: {
    accept: "image/webp,image/apng,image/svg+xml,image/*,*/*;q=0.8",
    "accept-encoding": "gzip, deflate, br",
    referer: "",
    "accept-language": "en-GB,en;q=0.9,en-US;q=0.8,it;q=0.7",
    "user-agent":
      "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36 Edg/100.0.1185.50",
  },
})
  .then((res) => {
    console.log("...succeded");
    return res.width;
  })
  .catch((err) => {
    console.log("...failed");
    console.error(err);
    return 0;
  });

Let's close this, since where are no goal to cheat with headers by default.


POC Invoke API (serialization)

TITLE
Description
Description of the pull request changes and motivation.
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report

Merging #340 (7572609) into main (9e85e41) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

:exclamation: Current head 7572609 differs from pull request most recent head 33603b3. Consider uploading reports for the commit 33603b3 to get more accurate results

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   72.89%   72.70%   -0.20%
==========================================
  Files         119      120       +1
  Lines       21364    21422      +58
==========================================
  Hits        15574    15574
- Misses       5790     5848      +58

Files
Coverage Δ

src/invoke.rs
0.00% <0.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


Bump gtk to version 0.14

I'm updating some of my crates to gtk v0.14 and I need all its related crate update to it.
Could you also publish another version? Many thanks!

Yeah, it's an oversight on my side, thanks!

We are back in business, 0.4.1 is published with updated deps.


Umami.js as a

I'd like to add umami.js code to a <srcript> tag. I can request it from the umami server and copy the code, but tried to find it out in the repo and didn't find it.
Tell me pls, can i copy the file from somewhere and how often is it changing?

Hi @4l1fe,
The <script /> tag that you find in umami is generated from the website ID and your current environment. If you are running the site locally your environment is localhost and therefore your src attribute will be localhost/umami.js. The website id only gets created once as it is an entry in the database, so it isn't hardcoded in the repo, it's just generated on the fly. It never changes; once the umami website is hosted and you have created a website from the admin panel, that script tag will stay the same as it is always fetching the same website id and domain name (unless you delete the website in umami or change your domain name).

I forgot about website-id.
So workflowin my case should be:

Run umami locally
Do to the admin page
Create a domain record
Open the /umami.js, copy and paste content into an index page script tag
Copy website-id and paste it where?

My purpose is to remove a network request for /umami.js as it has big net.latency.

What is your intended goal? The umami.js script is tiny (under 2KB) so the latency should be minimal. Besides, it uses async and defer by default so it doesn't impact your first contextual load. You need to host umami somewhere to be able to serve the script, and the script is just an interface to simplify sending API requests to the server.
Have you set up the website and its domain correctly where you can access the umami dashboard?

What is your intended goal? The umami.js script is tiny (under 2KB) so the latency should be minimal. Besides, it uses async and defer by default so it doesn't impact your first contextual load. You need to host umami somewhere to be able to serve the script, and the script is just an interface to simplify sending API requests to the server.

I wrote my goal, probably you are used to all the static files are close to a client...

Have you set up the website and its domain correctly where you can access the umami dashboard?

Man you better help me with the workaround and explain how i have to pair my manually added <script> tag and js code in there up with website-id. If you know of course, thx.

So, just to double check, you have:

Forked/pulled the umami repo
Deployed it to an accessible domain
Deployed the database that is accessible

If you haven't done the above, it doesn't matter if you want to copy the code and add the website-id because there would be nowhere to send your requests to and nowhere that you can see your data. Umami is an analytics tool like Google Analytics. Google Analytics give you a script to add to your client site, which then communicates with Google servers and is displayed on the Google Analytics Dashboard. That's the same with umami. Umami has a dashboard that gives you the tracking code, you copy it and paste it into your site, it pulls the umami.js file which is the tracking script that communicates with the server and then you can log in and see your data visualised.
The reason you can't find the umami.js file in the repo is that it is compiled at build time.

Listen, you think in a very standard way, i understand it. I have a particular case and am not going to explain you everything, that's too long and unnecessary.
My question above is specific, if you can't help with it that's alright no problem.

The script gets parameters from the script tag. If you want it to work a different way you have to rewrite the tracker and rebuild it yourself. The code is here
https://github.com/umami-software/umami/blob/master/tracker/index.js
Then run yarn build-tracker to compile it.

I unminified umami.js to read and tried to paste it's content into the script tag. It doesn't work yet locally. I got an error but after parsing the website-id parameter...
The steps are gonna be working

I forgot about website-id. So workaround in my case should be:

Run umami locally
Go to the admin page
Create a domain record
Open the /umami.js, copy and paste content into an index page script tag
Copy website-id and paste it where?

Listen, you think in a very standard way, i understand it. I have a particular case and am not going to explain you everything, that's too long and unnecessary.
My question above is specific, if you can't help with it that's alright no problem.

@4l1fe dude, be more respectful.  I compared it to the competitors.


[Enhancement] Add the ability to blacklist certain commands from showing up on Discord/printed in in-game chat

Checks

[X] I confirm that I have searched for existing issues / pull requests before reporting to avoid duplicate reporting.
[X] I confirm that I noted that if I don't follow the instructions, the issue may be closed directly.

Description
Hi! I love this mod, but one of my main issues is that the /whisper command gets printed in chat, effectively making it useless... I would like the ability to blacklist certain commands so that they don't get printed in-game or on Discord
Example:

Hi! You can blacklist commands by simply adding them to excludedCommands.

Ah I see why you are asking this, the excludedCommands option is not working. Will fix later.


Link IMDB API to index.html file

WE NEED the API for IMDB linked to the index.html file SO THAT users can search the Rotten Tomatoes database for movie info/reviews.

I sent in an application to get the API for Rotten Tomatoes.

Kyle E now working on.

Kyle K working on.