Tex to serialised mathml sample.

Adds handling of TeXAtom nodes in the seralized mml visitor and by extension in the test visitor.  Nodes are handled equivalent to the old style by adding an mrow with the MJ-... texclass class.
Adds a tex-mml.js processor in the samples files.
Fixes some typos in comments.

I have not made any changes to the MathMLVisitor yet. But if the serialised version is fine, I can do that.

Changed script name as discussed yesterday.


LCD接口例程 (IDFGH-7968)

在使用lcd接口时，调用官方例程时发现并没有SSD1963IC的驱动，官方大大可不可以添加一个进来？谢谢

Hi @gao-zhida
We won't add more LCD controller drivers into esp-idf repo, but will consider adding that as a managed component, which you can find in https://components.espressif.com/search/lcd
Also you're welcome to submit any PRs to https://github.com/espressif/esp-bsp/tree/master/components/lcd

BTW, alternatively, you can take iot-solution driver as the starting point, plus some clean-up to adapter to the esp_lcd interface.

顺便说一句，或者，您可以将iot-solution驱动程序作为起点，加上一些清理以适应 esp_lcd 接口。
okay, thank you


Modify when-statement to not include jinja2 templating delimiters such

as {{ }} or {% %}, as this will raise a warning as from Ansible 2.3.

As from Ansible 2.3 a warning will be raised when jinja2 templating delimiters are used in when-statements. This PR will refactor the when-statement in the check collectors task, so the warning won't be raised.

Thanks! :+1:


chart line don't render when data is exist null

[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link
https://codepen.io/speanut-land/pen/vYmvjqG
Steps to reproduce
Wait for the timer to change the data to Null, then need to manually hover, the chart will be re-rendered,

Environment
Info

g2
4.1.23

System
-

Browser
-

1.Note that the chart animation needs to be turned off, otherwise, re-render, no expected effect
2.When the data is null, expect to behave as a breakpoint and chart re-render

设置了connectNulls并不能解决问题，example中数据通过setTimeout修改了俩次，"不包含Null" - "包含Null" - "不包含Null"，在最后一次的"不包含Null"图表没有渲染出来，debug底层g-Canvas查看是数据变成NaN导致局部渲染出现了问题


tsi: use zero copy grpc frame protector

Description: Zero copy protector is more efficient but the main reason to use it is
the fact that we're using some protocols internally that don't work with
the default TSI protector, only with the zero copy one.
Risk Level: Low
Testing: unit tests updated, also tested in a real dev environment.
Docs Changes: n/a
Release Notes: n/a
Fixes #9956

I'll take a look at the asan failure tomorrow... looks like it's something to do with gRPC slice refs, hopefully a quick fix!

cc @lizan

The asan issue is now fixed. Instead of creating a grpc slice from a static buffer we now copy the buffer into its own slice. The contract of protect/unprotect interface is that the input buffer will always be drained even though unprotected data may not be available in the output yet, so we need to hold onto unfinished frames internally. Probably not an issue for protect but for now I switched both to use a copied slice to be on the safer side.

Friendly ping :-)

Oh sorry Lizan approved before me. Merging.


[$500] Not found is shown when deeplinking to expense details

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

**Version Number:**v1.4.43-11
**Reproducible in staging?:**y
**Reproducible in production?:**y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:
Action Performed:
Break down in numbered steps

Having account A and B send a money request from A to B
With account A, open the expense details and copy the URL
Paste the URL in a fresh new window and sign in with account A again

Expected Result:
Describe what you think should've happened
Expense details page should load
Actual Result:
Describe what actually happened
A not found view is shown
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Reloading the page works
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/16493223/db09a1a1-3bd6-456b-a5f3-976c4856b47a

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01715c671a688b4a3b
Upwork Job ID:<PHONE_NUMBER>818485248
Last Price Increase: 2024-02-22
Automatic offers:

s77rt | Contributor | 0

Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
The OpenReport is called before the subscribeToUserEvents function and so that we receive the report data in response but the Onyx data is not updated.
Let me explain the above statement:
Here we are disabling update client data if lastUpdateIDAppliedToClient is false
The last update id is set in the subscribeToUserEvents function on this line . And the subscribeToUserEvents function is called in two places ( here and here ) . It turns out that the subscribeToUserEvents function needs to be called before any endpoint which should update client data (In our case OpenReport).
What changes do you think we should make in order to solve the problem?

Add the lastUpdateIDAppliedToClient key  in withOnyx

lastUpdateIDAppliedToClient: {
    key: ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT,
},

Add check && lastUpdateIDAppliedToClient in this condition

(!wasReportAccessibleRef.current &&
      !firstRenderRef.current &&
      !report.reportID &&
      !isOptimisticDelete &&
      !reportMetadata.isLoadingInitialReportActions &&
      !isLoading &&
      !userLeavingStatus &&
      lastUpdateIDAppliedToClient) ||

Add new useEffect in ReportScreen

useEffect(()=>{
  fetchReportIfNeeded();
}, [lastUpdateIDAppliedToClient])

What alternative solutions did you explore? (Optional) (edited)

But if you could extract the part that makes sense to this one.

Now I'll add the extracted version here to make it easier to understand

Proposal
Please re-state the problem that we are trying to solve in this issue.
Not found is shown when deeplinking to expense details
What is the root cause of that problem?
The OpenReport is called before the subscribeToUserEvents function and so that we receive the report data in response but the Onyx data is not updated.
Let me explain the above statement:
Here we are disabling update client data if lastUpdateIDAppliedToClient is false
The last update id is set in the subscribeToUserEvents function on this line . And the subscribeToUserEvents function is called in two places ( here and here ) . It turns out that the subscribeToUserEvents function needs to be called before any endpoint which should update client data (In our case OpenReport).
What changes do you think we should make in order to solve the problem?

Add the lastUpdateIDAppliedToClient key  in withOnyx

lastUpdateIDAppliedToClient: {
    key: ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT,
},

Add check && lastUpdateIDAppliedToClient in this condition

(!wasReportAccessibleRef.current &&
      !firstRenderRef.current &&
      !report.reportID &&
      !isOptimisticDelete &&
      !reportMetadata.isLoadingInitialReportActions &&
      !isLoading &&
      !userLeavingStatus &&
      lastUpdateIDAppliedToClient) ||

Add new useEffect in ReportScreen

useEffect(()=>{
  fetchReportIfNeeded();
}, [lastUpdateIDAppliedToClient])

What alternative solutions did you explore? (Optional) (edited)

Hey @s77rt, would you like to take this one over as a C+ since you've worked on the original issue?🙏
I really want to wrap up my ongoing Contributor PRs this week before fully emerging into the C+ role.

@paultsimura Sure!  Taking this as C+

@shahinyan11 Thanks for the proposal. The RCA seems incomplete. I have some questions/concerns:

If lastUpdateIDAppliedToClient is false then doesClientNeedToBeUpdated will be true and this will make our SaveResponseInOnyx middleware defer the updates and not just ignore them ^1. The updates are eventually applied by OnyxUpdateManager ^2. Why are we still not seeing the report in Onyx?
The report updates come from the OpenReport http response. What does the pusher events (and subscribeToUserEvents function) have to do here?

Proposal
Please re-state the problem that we are trying to solve in this issue.
Not found page is shown when open transaction thread report after login
What is the root cause of that problem?
Summary: The onyx data from the OpenReport request isn't applied because the data is considered outdated.
When we open (deeplink) a report after login, there are 2 requests are made, OpenApp and OpenReport. OpenApp is a read request, so both requests are run in parallel. When the OpenReport request finishes first, OnyxUpdates.doesClientNeedToBeUpdated will return true
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/Middleware/SaveResponseInOnyx.ts#L40-L45
because lastUpdateIDAppliedToClient doesn't exist yet, the OpenReport response is saved to ONYX_UPDATES_FROM_SERVER.
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/OnyxUpdates.ts#L136-L139
if OpenApp finishes first, this issue won't happen
This will trigger a ReconnectApp request.
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/OnyxUpdateManager.ts#L59-L75
ReconnectApp will return a lastUpdateID and the response will be applied immediately (requestsToIgnoreLastUpdateID contains ReconnectApp & OpenApp)
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/Middleware/SaveResponseInOnyx.ts#L40-L42
After it's done, the saved OpenReport response is processed.
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/OnyxUpdateManager.ts#L87-L88
However, the OpenReport lastUpdateID is smaller than the lastUpdateIDAppliedToClient (that is updated from ReconnectApp lastUpdateID)
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/OnyxUpdates.ts#L81-L85
so the response data is ignored.
What changes do you think we should make in order to solve the problem?

I think ideally we should wait for the OpenApp request to be finished first before doing the OpenReport request because ReconnectApp doesn't return all report that a user has.
To achieve that, first we need to change the OpenApp API from READ to WRITE, just like we did for ReconnectApp, so it's processed sequentially.
However, this isn't enough because OpenApp is called after a promise and onyx connection which delays the call.
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/App.ts#L210-L216
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/App.ts#L149-L158
To solve this, we can follow a similar pattern of the promise here
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/App.ts#L80-L87
let resolveIsOpenAppCalledPromise: () => void;
const isOpenAppCalled = new Promise<void>((resolve) => {
    resolveIsOpenAppCalledPromise = resolve;
});

function waitForOpenApp() {
    return isOpenAppCalled;
}

Then, we will resolve the promise once the OpenApp/ReconnectApp api is pushed to the queue
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/App.ts#L214-L215
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/App.ts#L242-L243
why ReconnectApp too? because ReconnectApp will be called instead of OpenApp if we already logged in previously
Or we can resolve the promise immediately when the ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT exists.
Onyx.connect({
    key: ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT,
    callback: (val) => {
        if (val) resolveIsOpenAppCalledPromise();
    },
});

Then, we will wait for the promise here:
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/Report.ts#L724-L727
App.waitForOpenApp(() => // open report request)

Oh, that wasn't my intention, just switching the C+ per this comment

@bernhardoj Thanks for the proposal. Your RCA is correct. Regarding the solution:

To achieve that, first we need to change the OpenApp API from READ to WRITE, just like https://github.com/Expensify/App/pull/12125, so it's processed sequentially.

After doing that, will the OpenReport request wait for the OpenApp to finish if the OpenReport request type is makeRequestWithSideEffects and not read?

@bernhardoj If we deeplink into a report the OpenReport request type would be makeRequestWithSideEffects thus it won't wait for OpenApp
https://github.com/Expensify/App/blob/4a885f596547a16893ae40ebabcff41c82416453/src/libs/actions/Report.ts#L719-L727

Yes, that would be intentional since isFromDeepLink is only true when we open the report while logged out (to open the public room). If we wait, then we won't be able to open a public room.

@bernhardoj In that case you suggestion solution shouldn't work as we won't wait for OpenApp after all.

We don't need to wait for OpenApp (or specifically lastUpdateIDAppliedToClient) when opening a public room because it's not a WRITE request, so doesClientNeedToBeUpdated will always be false.
https://github.com/Expensify/App/blob/89d5689978d3a50c86ae9c9da00dcff875eb9220/src/libs/actions/OnyxUpdates.ts#L130-L134
https://github.com/Expensify/App/blob/89d5689978d3a50c86ae9c9da00dcff875eb9220/src/libs/Middleware/SaveResponseInOnyx.ts#L40-L42

@shahinyan11 Thanks for the proposal. The RCA seems incomplete. I have some questions/concerns:

If lastUpdateIDAppliedToClient is false then doesClientNeedToBeUpdated will be true and this will make our SaveResponseInOnyx middleware defer the updates and not just ignore them 1. The updates are eventually applied by OnyxUpdateManager 2. Why are we still not seeing the report in Onyx?
The report updates come from the OpenReport http response. What does the pusher events (and subscribeToUserEvents function) have to do here?

Sorry. I mixed up some files and went the wrong way

Proposal
Updated

@bernhardoj That's not entirely true and contradicts with your RCA. OpenReport does return previousUpdateID (treated as a WRITE request). In this case we need to wait for OpenApp otherwise the onyx update will be just ignored.
I have noticed that OpenReport sometimes return previousUpdateID and sometimes it does not. I see we have a chance of fixing this in the BE.

@shahinyan11 Thanks for the update. The RCA makes sense but the suggested solutions are workarounds.

🎀 👀 🎀 C+ reviewed
This could be internal. Can you please check when or what are the cases where OpenReport would return previousUpdateID in its response?
It seems that if we remove previousUpdateID from the server's response we could fix the bug as doesClientNeedToBeUpdated will be false in this case.
https://github.com/Expensify/App/blob/87eeb99d93568a96decb59aeba1025516a61d58f/src/libs/actions/OnyxUpdates.ts#L130-L134

@deetergp Adding to the above ^  I think OpenReport should return previousUpdateID only if we are creating a new report. In our case here we are not, we are accessing a report that already exists, thus previousUpdateID should not be a part of the response.

@s77rt can you try again checking the response? I don't see previousReportID when opening a public room while logged out.

@deetergp can you help confirm if this needs to be internal via this comment when you get a chance?

@s77rt Getting rid of previousUpdateID is a non-starter. It's part of our Reliable Updates initiative and is only going to show up in more places as we move where we send onyx updates from our PHP layer, further back into our C++ layer.

@deetergp I'm not suggesting the removal of previousUpdateID as whole. According to this comment https://github.com/Expensify/App/blob/87eeb99d93568a96decb59aeba1025516a61d58f/src/libs/actions/OnyxUpdates.ts#L131 that field should only be present if the request is a write request. OpenReport command can act as both a write and a read request, write request if creating a new report and a read request otherwise.
Example 1: Response when reading an existing report

Example 2: Response when creating a new report (chat with a user you have not chatted with before, etc.)

The problem is that we are encountering a case where we are reading an existing report (the money request report) yet get the previousUpdateID field which is unexpected. What I'm asking for is to check why is that field present i.e. why is the request treated as a write request?

Hey @deetergp, it seems possible that this newly raised bug is a dupe of this issue, would you agree?

@tienifr nice catch - agreed that this is a dupe of https://github.com/Expensify/App/issues/34528. @shahinyan11 please add your proposal there if you'd still like to put it forward.


Menu changes that I took far too long to do

im sorry that this took forever to push :panicline:

I'm closing this PR, not planning on merging the menu branch to main right now


Add support for s390x

As Travis CI officially supports s390x builds, adding support for same.

Hi @sangitanalkar,
Thanks for the ticket, we currently test an extensive matrix in our internal evergreen CI testing suite, including 390x testing.  The Travis tests are really for top level PR validation and as we use Travis for fast feedback we have deliberately kept the matrix simple.
All the best,
Ross


Can I get the document share link use quip-api?

I cant share a document  and got the document share link use quip-api.
Are you planning to add this.

Hi @liaoxiaorong - the share link is now returned in the thread's json as thread["thread"]["link"]
It will be added to the documentation shortly. Thanks again for the report.

Quip is amazing, I'm really enjoy using it. Thanks for your work.

Hi - is this still supported? I can't see anything about creating sharing links in the QUIP api reference

Hey there. The functionality is supported. Currently, however, we only return the document sharing link over the API. We don't yet allow you to create a sharing link via the API. (That must be done in product.)
Would you like to be able to create sharing links via the API for documents? If so, what kind of sharing permissions do you want for your use case?

Yes, I would definitely like to be able to create sharing links over the API. The basic use case would be to create a public read-only link. But of course it would be useful to programatically control permissions as well. Would love the chance to chat about our plans with the API if you shoot me a mail (address in img)

Follow-up -- here are the API docs for this feature. https://quip.com/dev/automation/documentation/current#operation/editThreadLinkShareSettings


FormBuilder : Add govuk_collection_radio_buttons

. Add govuk_radio_button and govuk_collection_radio_buttons to the form builder
. Refactor form_builder and its tests to make it a bit less complicated and add aria-describedby attributes.
. Modify a couple of pages to use govuk_collection_radio_buttons.
FYI, this FormBuilder generates HTML described on https://design-system.service.gov.uk/components/radios/
Checklist
Before you ask people to review this PR:

[x] Tests and rubocop should be passing: bundle exec rake
[x] Github should not be reporting conflicts; you should have recently run git rebase master.
[x] There should be no unneccessary whitespace changes. These make diffs harder to read and conflicts more likely.
[x] The PR description should say what you changed and why, with a link to the JIRA story.
[x] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
[x] You should have checked that the commit messages say why the change was made.

UAT env: https://uilder-collection-radio-button-applyforlegalaid-uat.apps.cloud-platform-live-0.k8s.integration.dsd.io/


Comma separator option for multi upload preview

Is it possible to make the comma for preview of multiple images optional. The code is on line 475
in master branch / if (i > 0) names.append(', ');  /

Done. Hopefully thsi will do the trick.
	$('#your-input').MultiFile({

                // this option will remove the comma
                // between file names when multiple
                // files are selected at once
                separator: false

	});

ps.: either an empty string or "null" or "false" will work, as long as !!separator evaluates to "false".


Incorrect information - Mobile VEC no longer in Beta

Issue in ./help/c-target-mobile-app/c-mobile-visual-experience-composer/use-adobe-launch-to-set-up-the-mobile-app-vec.md

This topic was deleted from the guide but still showed up in search. It should be deleted now and now show up in search results.


feat: Highlight exit and yield points

Fixes #4691

Moves in the right direction! Couple of relevant thoughts:

a related functionality is highlighting all exit points of the function, but we probably want a separate request for that (and support in client)
document highlights is less than ideal name here. Perhaps just highlight_references?

* a related functionality is highlighting all exit points of the function, but we probably want a separate request for that (and support in client)

I don't think it needs to be a separate request See https://github.com/microsoft/language-server-protocol/issues/1047

Ye I think we don't need a separate request for that, but then the question is how we highlight exit points in regards to the trailing expression as that can overlap with the general ident highlight.

If the cursor is on ? / return or return type (-> Ty) we should highlight exit points, including expressions in the tail position.
if the cursor is on async / await, we should highlight all yield points.
if the cursor is within trailing expression, we should highlight references or nothing.
The name for all three I think is “highlight_related”?

Yield point and exit point highlighting is implemented as well now. Gotta fix(and probably find) a few more special cases as well as do some minor cleanup still

Really odd, so VSCode refuses to show highlighting when hovering over some exit points but not on others even though it works fine for them in tests...

Okay things are working but VSCode doesn't send a highlight request when the cursor goes onto non identifier symbols from what I can tell, that means clicking on ? and -> doesn't send a request currently. I suppose this is a bug on VSCode's side as I don't see anything in this regard in the lsp docs.

Currently when the trailing expression is an if or match expression the entire expression gets highlighted as an exit point. Now I wonder if it would make more sense to only highlight the arm/branch expressions in this case? Seems more elegant to me.

Yeah, it’s better to highlight expressions in the tail position. I think we should have functionality for that implemented somewhere already, but I don’t remember where. Ok-wrapping maybe?

Got it! We have “change return type to Result” assist!

Oh ye looks like that assist does similar things to what is wanted here, I'll take a look at that tomorrow

Managed to simplify things a bit more, but I couldn't really reuse the wrap_return_type_in_result logic for tails fully as its a bit different than whats needed here. Might be able to merge the logic somehow still but I'll take a look at that another time.
bors r+


The embed end screen should allow for restarting the playback

Is your feature request related to a problem? Please describe.
I'm always frustrated when I reach the end of a video in an embedded player and I see the following:

The button opens a new window to the video. There is no obvious way to just restart the playback in the embedded player instead (actually, there is a workaround described below).
Describe the solution you'd like
The main call to action should be to rewatch the video in the embed player. There could be two buttons, one that restarts the video in the embed player, and one that opens the video in a new window. But I think it is important that the button to restart in the embed player is the primary button.
There could also be an X in the top right corner that just removes the overlay and grants access to the player buttons, allowing the user to restart the playback or seek to a particular position in the video.
Describe alternatives you've considered
I actually found a workaround while messing around. The keybindings are still active, so it is possible to press the space key (or the left/right arrow keys) to "get out of" the end screen.
Additional context
If you think this is an ok change, then I may attempt it myself. But I'd like an 👍  or 👎  on what the LBRY team thinks. Thank you!

Not really relevant anymore? Reopen if so.


update favicon

Update favicon
Fixes #363 (issue)
Type of change
Please mark with an X the type that applies:

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactor code
[ ] Documentation update
[ ] Other (mentioned in the issue number)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce them. Please also list any relevant details for your test configuration.
Test A: Describe here
To enhance the logo's visibility, the white background was removed, ensuring it stands out against various browser themes. The favicon has been updated to reflect this change, improving its clarity and prominence.
Test B: Describe here (if required)
Screenshots and Videos

favicon change with this logo
Please provide screenshots and videos of the changes you made.
Checklist
Please mark with an X the items that apply:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] I have commented on my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] Any dependent changes have been merged and published in downstream modules

close issue #363

@hustlerZzZ please review PR and merge it


⚠ Bofrost.be has degraded performance

In 215bd63, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 892 ms

Resolved: Bofrost.be performance has improved in 5ef243b after 8 minutes.


linux_testing: 5.13-rc6 -> 5.14-rc1

Motivation for this change
release notes
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Well, 5.14 came out today. Maybe we should change this PR to linux_5_14: init at 5.14.0?

superseded by #142511


Remove future package dependency

With the Python 3 upgrade firmly in the rear view mirror, the future package is now both unmaintained and probably unnecessary.  Try removing the package and make sure nothing breaks.

PR https://github.com/openedx/edx-celeryutils/pull/174 created to resolve this issue.


configuration: add routes and database persistence

Fixes: https://github.com/moov-io/customers/issues/167

Codecov Report

Merging #168 into master will decrease coverage by 0.37%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   62.38%   62.01%   -0.38%
==========================================
  Files          43       46       +3
  Lines        2289     2364      +75
==========================================
+ Hits         1428     1466      +38
- Misses        592      615      +23
- Partials      269      283      +14


Issue #526 add minimize json data function for python

As part of Issue 526, the deliverable was to add a method to minimize the JSON data so that hashes produced for the same JSON data are consistent across the application.
Also, added the unit test for the method.
Issue #526

I dont think hashes will be same.. need to override hash function to invalidate spaces.

@peRFectBeliever The objective of this issue was to generate minimized JSON string. The minimized JSON string will be used to generate the hashes. This will create the same hash for the same minimized JSON string.
We can discuss this in the architecture meeting if you have any other concerns.


Update BlueskyClient.Uwp.uk.xlf

A little corrected translation.
I'm not really into bluesky right now, but in the search, what exactly does top mean? Because "верх" doesn't look very good, are these popular posts?

"Top" is the sort option for viewing popular posts, yep! As opposed to "latest" which sorts the list based on time.

Okay, thanks, I'll edit it to make it clearer now.

I create a new pull request: https://github.com/jenius-apps/beeskie/pull/44


chore(curriculum): update video id for div element lecture

This has been re edited. So this PR updates the video id to use the new one.
Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

I am marking this as blocked for now, because Beau is reviewing the assets for the video.
If it is ready, then I will remove the blocked label.
Otherwise, this doesn't need to go in for launch. Just a nice to have, but not an absolute necessity.


Sync committee duty calculation for an epoch is too long (4 seconds)

This is a tl;dr on Rodrigo's notes on PR #1297.
On the one hand, this may not be an issue on mainnet, as it's mainly originating from all the validators being part everywhere. This is the core problem:

for 60 validators (the test I was seeing the 4 seconds delay) we have to calculate proofs for every subcommitte (4) for every slot (32). The proof calculation cost approximately 0.5 ms. so:
60 * 32 * 4 * 0.5 = 3840ms (aprox. 4 seconds)

On the other hand, we have very obvious optimizations at hand: As the core of the problem is calculating a proof via a BLS signature based on slot + subcommittee index (Validator.Utils.get_sync_committee_selection_proof/4), the calculation is completely independent for each set of validator_index, slot, subcommittee_index. Given that, it's a low hanging fruit to use something like Task.async_stream to:

Parallelize computation per validator.
Inside of a validator, parallelize computation per slot/subcommittee.

As a followup question, is the all of the computation consumed in BLS.sign or is Misc.compute_signing_root a relevant portion of it? If it's BLS.sign, then there's no significant further change we can do. If it's compute_signing_root, however, that doesn't require the privkey, so we could do that once per subcommittee+slot instead of doing it once per {validator, slot subcommittee_index} tuple, although it's a bit of a bothersome refactor, so it's important to see if it's valuable at all.

maybe this will help
https://bit.ly/4gx42eQ
you may need to install the c compiler


sysfs: switch GPIO to use context.Context based epoll wait

Fixes Pin.Halt(), In() and Out() to unblock any pending WaitForEdge().
Enable all of gpiosmoketest.
Handle spurious edges deterministically.

This fixes issue 323.
I want to do more extensive testing on it before committing. Having a burn in test would be nice, albeit it only need to not be worse than the current implementation, it doesn't necessarily need to be perfect.
Also, I find the code too complicated, so I need to figure out a way to simplify it.

Do not review yet since it's broken.

Codecov Report

Merging #398 into master will decrease coverage by 0.02%.
The diff coverage is 57.31%.

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   64.38%   64.36%   -0.03%
==========================================
  Files         118      118
  Lines       11809    11852      +43
==========================================
+ Hits         7603     7628      +25
- Misses       4005     4024      +19
+ Partials      201      200       -1

Impacted Files
Coverage Δ

host/fs/fs_linux.go
0% <ø> (ø)
:arrow_up:

host/fs/fs.go
35.71% <ø> (ø)
:arrow_up:

host/sysfs/gpio.go
53.55% <54.28%> (-1.81%)
:arrow_down:

host/sysfs/fs_linux.go
72.72% <75%> (+0.4%)
:arrow_up:

experimental/devices/ads1x15/ads1x15.go
78.84% <0%> (-0.97%)
:arrow_down:

experimental/devices/hx711/hx711.go
77.64% <0%> (+7.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f35b7a5...15b2070. Read the comment docs.

Any update on the state of this PR? Looks like it could also fix #423 ?

Hi @djensenius!
Thanks for the ping. Yes it's still very definitely on my plate even if I haven't touched this for several months. :/

Codecov Report

Merging #398 into master will decrease coverage by 1.0%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #398     +/-   ##
========================================
- Coverage    63.1%   62.1%   -1.0%
========================================
  Files         125     122      -3
  Lines       12721   12603    -118
========================================
- Hits         8028    7832    -196
- Misses       4470    4552     +82
+ Partials      223     219      -4

Impacted Files
Coverage Δ

src/periph.io/x/periph/host/pmem/alloc.go
40.4% <0.0%> (-50.0%)
:arrow_down:

src/periph.io/x/periph/host/cpu/cpu.go
64.3% <0.0%> (-28.6%)
:arrow_down:

src/periph.io/x/periph/host/sysfs/sysfs.go
47.4% <0.0%> (-21.1%)
:arrow_down:

src/periph.io/x/periph/host/pmem/view.go
69.5% <0.0%> (-20.3%)
:arrow_down:

src/periph.io/x/periph/host/distro/devtree.go
55.9% <0.0%> (-17.6%)
:arrow_down:

src/periph.io/x/periph/host/pmem/pagemap.go
85.7% <0.0%> (-14.3%)
:arrow_down:

src/periph.io/x/periph/host/distro/distro.go
78.5% <0.0%> (-10.1%)
:arrow_down:

src/periph.io/x/periph/host/sysfs/i2c.go
69.5% <0.0%> (-6.5%)
:arrow_down:

...rc/periph.io/x/periph/host/sysfs/thermal_sensor.go
78.5% <0.0%> (-5.4%)
:arrow_down:

src/periph.io/x/periph/host/sysfs/led.go
39.3% <0.0%> (-3.7%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 229d90f...effb2ea. Read the comment docs.

Will rework for the new version that is go module compatible.


1D GANs in Gluon

#Description
The tutorial for GANs in MXNet can be found here:
https://mxnet.incubator.apache.org/tutorials/unsupervised_learning/gan.html
The example uses the symbol and module modules, which to my understanding have been replaced(?) by the gluon module.
So lets say I wanted to make the most simple gans utilizing only gluon. We will use fake data (lets say a 1d array)
#Code
import mxnet as mx
from mxnet.gluon import nn
import mxnet.ndarray as nd
import numpy as np

batch_size = 100
epochs = 1
ctx = mx.cpu()

# super simple generator
gen = nn.Sequential()
gen.add(nn.Dense(50, activation='relu'))
gen.add(nn.Dense(25, activation='relu'))
gen.add(nn.Dense(10, activation='relu'))

# super simple discriminator
dis = nn.Sequential()
dis.add(nn.Dense(200, activation='relu'))
dis.add(nn.Dense(100, activation='relu'))
dis.add(nn.Dense(50, activation='relu'))
dis.add(nn.Dense(25, activation='relu'))
dis.add(nn.Dense(2, activation='relu'))

# simulated "real" data
real_samples = 1000
real_data_length = 10
real_mean = 0
real_standard_deviation = 1
real_data = nd.random_normal(loc=real_mean, scale=real_standard_deviation, shape=(real_samples, real_data_length))

# Iterators...
class RandIter(mx.io.DataIter):
    def __init__(self, batch_size, ndim):
        self.batch_size = batch_size
        self.ndim = ndim
        self.provide_data = [('rand', (batch_size, ndim))]
        self.provide_label = []

    def iter_next(self):
        return True

    def getdata(self):
        return [nd.random_normal(0, 1, shape=(self.batch_size, self.ndim))]

# Produce 'simulated' data
Z = 100
rand_iter = RandIter(batch_size, Z)

# Hyperperameters
sigma = 0.02
lr = 0.0002
beta1 = 0.5

# Train Data
print('Training...')
for epoch in range(epochs):
    # what goes here?

https://github.com/zackchase/mxnet-the-straight-dope/tree/master/chapter14_generative-adversarial-networks

Thanks, guess I missed this one.
I have a few questions about the training implementation.
I have put them as inline comments from the copy-pasted code, which start as #!
for epoch in range(10):
    tic = time.time()
    train_data.reset()
    for i, batch in enumerate(train_data):
        ############################
        # (1) Update D network: maximize log(D(x)) + log(1 - D(G(z)))
        ###########################
        # train with real_t
        data = batch.data[0].as_in_context(ctx)
        noise = nd.random_normal(shape=(batch_size, 2), ctx=ctx) #! this replaces the purpose of Z in dcgans?

        with autograd.record():
            real_output = netD(data)
            errD_real = loss(real_output, real_label)

            fake = netG(noise)
            fake_output = netD(fake.detach()) #! why is this detached when in the dcgan it is not?
            errD_fake = loss(fake_output, fake_label)
            errD = errD_real + errD_fake
            errD.backward()

        trainerD.step(batch_size)
        metric.update([real_label,], [real_output,]) #! why are these included in the record statement in dcgan?
        metric.update([fake_label,], [fake_output,])

        ############################
        # (2) Update G network: maximize log(D(G(z)))
        ###########################
        with autograd.record():
            output = netD(fake)
            errG = loss(output, real_label)
            errG.backward()

        trainerG.step(batch_size)

This is not an issue. Please use the user forum for how-to questions. Thanks!


[Feature Request] Improve README

Checklist

[X] I searched exising issues and no one else requests similar feature.
[X] I think that 25%+ users are positive towards this feature.

Describe the feature
https://juejin.cn/post/6999465279210127373
https://shields.io/badges
https://img.shields.io/badge/license-MIT-blue
https://badgen.net/github/release/unknowIfGuestInDream/javafxTool/stable
Additional context
No response

https://badgen.net/github/license/unknowIfGuestInDream/javafxTool
https://badgen.net/#github/license/unknowIfGuestInDream/javafxTool


Request: add license to determine allowed use cases

Hi @coderedart :) This project has currently no license specified. I tought about using egui_overlay in some of my egui projects but I could not, since I am not sure if I am licensed to do so or not. Might it be possible to add a license that is compatible with egui itself and use ideally the same license? egui uses a dual license of Apache-2.0 and MIT license, like most other open source rust projects.

https://github.com/coderedart/egui_overlay/blob/master/Cargo.toml#L46 :)
I can add Apache in the next version (unless you need it right now).

Oh, thanks :D MIT is the best license for my use case. I was not aware of the license notice in the Cargo.toml. Maybe just adding a license file with the MIT license to this repo would be enough, since it will be picked up by GitHub and automatically highlighted, so it can be seen at first glance.

https://github.com/coderedart/egui_overlay/blob/master/LICENSE
done :)


Remove +1 functionality

Github has introduced reviews which make this feature
unnecessary. Remove to keep things simple.

Looks like github interface has changed a bit. I was using an older version locally. Will fix.

+1

+1

Hard to get out of the habit, eh?


Add osx-arm64

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@rxm7706 - could you please take a look and merge in, please?

thanks @Tobias-Fischer - would you like to be added as a maintainer.

Thank you @rxm7706 :)


Wake program tray right-click switch wake-up mode does not work。

Microsoft PowerToys version
"0.41.4"
Running as admin

[X] Yes

Area(s) with issue?
Awake
Steps to reproduce

PowerToysReport_2021-08-02-20-33-54.zip
✔ Expected Behavior
tray right click to switch wake-up mode。
❌ Actual Behavior
tray right-click switch wake-up mode does not work。
PowerToys program settings can switch wake-up mode。
Other Software
No response

This is fixed in the meantime. Next release will contain the fix

Duplicate of #12145


feat: added trestle-fedramp project discovery and command

Types of changes

[ ] Hot fix (emergency fix and release)
[ ] Bug fix (non-breaking change which fixes an issue)
[X ] New feature (non-breaking change which adds functionality)
[ ] Documentation (change which affects the documentation site)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[X ] Release (develop -> main)

Quality assurance (all should be covered).

[X ] My code follows the code style of this project.
[ ] Documentation for my change is up to date?
[ ] My PR meets testing requirements.
[ ] All new and existing tests passed.
[ ] All commits are signed-off.

Summary
Key links:

Sonar coverage

Before you merge

Ensure it is a 'squash commit' if not a release.
Ensure CI is currently passing
Check sonar

I haven't changed the setup.cfg to include the compliance-trestle-fedramp project (if available). Please update it accordingly.

I haven't changed the setup.cfg to include the compliance-trestle-fedramp project (if available). Please update it accordingly.

This should not be changed as the setup.cfg file specifies required installs and will be a circular depenency.


Put the utils in their own library called roadwork-utils

They can be found here: https://github.com/thebillkidy/roadwork-utils


Compatibility to laravelcollective/html v5.4.8

The form select method changed an can now take attributes for the options.

Hi,
Thanks for pull request. Can you remove new line characters between parameters? As far as I remember, there isn't such use in entire package.


SPI NOR driver fixes

Fix a typo, and define missing DT properties so that I can use spi-nor driver in addition to the default "chosen" flash driver for my platform (nrf52).
Fixes #15236

I test the patch, it work well

@anangl @galak can you review this one?

I test the patch, it work well

Can you approve the PR @lgl88911 ?

@carlescufi I am not familiar with DTS script, I just tested this modification & confirm it can be work


Removes duplicated listing of files in same Makefile target

[approve ci docs]

[approve ci docs]

Cherry-picked to v9.0.x branch.


NPM package-lock.json updates (minor semver only)

... following the package.json upgrade of r2-xxx-js dependencies (see https://github.com/readium/readium-desktop/commit/3e3561937ed6725f31421cb4336fb2545ea950d7 ). Tested successfully with npm run start:dev

The NPM package-lock.json file has changed in the most up-to-date feature/new-db branch (current development "trunk"):
https://github.com/readium/readium-desktop/commits/feature/new-db/package-lock.json
...consequently, no need to care about this older PR. Closing.
(I will adjust package-lock.json at my end to match the r2-xxx-js package upgrades)


nsq: make nsqadmin wait for lookupd

Hello @benjamin658
This is not a bug, but probably an enhancement we can do to nsqadmin.
What basically happens when you install the chart, nsqadmin is the first candidate that quickly get fetched and when the container run, it output the following error:
[nsqadmin] 2021/08/18 09:32:32.771223 FATAL: failed to instantiate nsqadmin -
failed to resolve --lookupd-http-address (jupiter-nsqlookupd-0.jupiter-nsqlookupd:4161) -
lookup jupiter-nsqlookupd-0.jupiter-nsqlookupd on <IP_ADDRESS>:53: no such host

Then it get restarted for few times until nsqlookupd is ready, then it starts. It looks a bit ugly to see that the container has crashed few times.
This is normal because nsqadmin does not wait for lookupd to start. I have this problem anytime I have a container which depends on another one. The way I get arround this is by adding an side car container that wait for the dependency to show up. Something like this:
initContainers:
  - name: wait-for-db
    image: groundnuty/k8s-wait-for:v1.3
    imagePullPolicy: Always
    args:
      - "pod"
        - "-lapp=mysql"

Not sure if this is the best way to do it :)
Cheers.

Hi @LordNoteworthy , thanks for your feedback,
I also notice this imperfection.
It's a good idea to run a wait-for init container to wait until the nsqlookupd pod becomes ready.
I will do it these days.
Thanks.


Warning about needing to terraform init and commenter not created

I am experiencing a confusing issue with tfsec. At 18 Jan 2022 21:36:36 -0500 I pushed a commit that included numerous new records to my PR branch. A coworker identified a typo in a resource name and so using the GitHub suggestion I committed that change directly to the PR branch at Wed, 19 Jan 2022 23:47:39 -0500. There were no changes to the step definition or the workflow in general.
I see there were a number of commits merged yesterday. Would the --soft-fail change have potentially introduced this issue? I'm especially curious about the new WARNING about needing to run terraform init that we were not seeing before.
Thank you for your help!
Workflow step:
  tfsec:
    name: tfsec - PR commenter
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - name: tfsec
        uses: tfsec/tfsec-pr-commenter-action@main
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}

Output:
+ tfsec --out=results.json --format=json --soft-fail .
WARNING: Failed to load module: missing module with source 'github.com/org/modules.git?ref=v0.2.0/path/to/module' -  try to 'terraform init' first
WARNING: Failed to load module: missing module with source 'github.com/org/modules.git?ref=v0.2.0/path/to/module' -  try to 'terraform init' first
WARNING: skipped aws-iam-no-policy-wildcards due to error(s): HasDynamicTypes does not support the given type
WARNING: skipped aws-iam-no-policy-wildcards due to error(s): HasDynamicTypes does not support the given type
+ commenter
Starting the github commenter...
The commenter failed with the following error:
failed to create a new commenter. there were errors processing the PR files.
the patch details could not be resolved

The warning is because we previous piped STDERR to dev/null and piped stdout in json format to a file.
Now, more correctly, the output is going to file and the stdio goes to the terminal.
Soft fail means the PR won't break because of tfsec, commenter takes responsibility for exit non-zero if there are comment worth errors.
The patch details error is a bug, I think it's failing to get patch info from a non text file - do you have images or some other binary in this PR? Would be good to know if that supports the theory

I can confirm since the new version yesterday I am getting similar errors and a failure as well.
Full Job:
TFSec:
    name: Terraform static analysis
    if: ${{ inputs.run-tf-sec }}
    runs-on: ubuntu-latest
    steps:
      - name: Clone repo
        uses: actions/checkout@master

      - name: Static analysis - TFSEC
        uses: aquasecurity/tfsec-sarif-action@master
        with:
          sarif_file: tfsec.sarif
          tfsec_args: --force-all-dirs

      - name: tfsec
        uses: aquasecurity/tfsec-pr-commenter-action@main
        if: github.event_name == 'pull_request'
        with:
          github_token: ${{ github.token }}

      - name: Upload TFSEC SARIF file
        if: ${{ inputs.upload-tf-sec }}
        uses: github/codeql-action/upload-sarif@v1
        with:
          category: tfsec
          sarif_file: tfsec.sarif

Error received:
+ tfsec --out=results.json --format=json --soft-fail .
WARNING: Failed to load module: missing module with source 'git::https://github.com/<enterprise>/<module>.git//<module>?ref=v1' -  try to 'terraform init' first
WARNING: Failed to load module: missing module with source 'git::https://github.com/<enterprise>/<module>.git.git//<module>?ref=v1' -  try to 'terraform init' first
WARNING: Failed to load module: missing module with source 'git::https://github.com/<enterprise>/<module>.git//<module>?ref=v1' -  try to 'terraform init' first
+ commenter
Starting the github commenter...
The commenter failed with the following error:
failed to create a new commenter. there were errors processing the PR files.
the patch details could not be resolved

I did notice from previous runs that worked before yesterday, the tfsec run command had different syntax without --out and --format specified.

HI - apologies for the inconvience, please could you try again with @v1.0.1 or @main of the action - I've resolved the issue with binaries

Hi @owenrumney thank you for the fast turn around, I will try our workflow again!
Confirming there are no images or binary components to the PR.

@owenrumney Ah, thank you for improving the commenter error details!
The commenter failed with the following error:
failed to create a new commenter. there were errors processing the PR files.
the patch details for [module/path/dns_records/site/gmail_dkim.txt] could not be resolved

This is a new file I have added in the PR but it is a plain text file. It is also at the path specified in the error. It is referenced via a new record like below
resource "cloudflare_record" "site_gmail_dkim" {
  # DKIM token generated by Google Workspace
  zone_id = data.cloudflare_zones.site_domain.zones[0].id
  name    = "google._domainkey"
  type    = "TXT"
  value   = file("${path.module}/dns_records/site/gmail_dkim.txt")
}

I believe this is properly configured but maybe I am missing something that tfsec is pointing out by not being able to find the file?

hey @amonshiz  - Am I correct in thinking that the gmail_dkim.txt has a single line in it possibly with no new line?
I don't think its your terraform, the issue is coming as I parse out the commits from the PR and I have a feeling I'm failing at getting the hunk start and end of single line entries.
I'll keep digging, please bear with me while I work this out

Hey @amonshiz - found the issue - please could you give v1.0.2 or @main a go and let me know how you get one.
Thanks for your patience

@owenrumney  I can confirm it is now working correctly for me, hoping @amonshiz finds the same result

hey @amonshiz - Am I correct in thinking that the gmail_dkim.txt has a single line in it possibly with no new line?
I don't think its your terraform, the issue is coming as I parse out the commits from the PR and I have a feeling I'm failing at getting the hunk start and end of single line entries.
I'll keep digging, please bear with me while I work this out

@owenrumney that is exactly what is in that file :).
I can confirm that the most recent change does resolve the issue I was experiencing! Thank you for the fast turn around!

I still have the issue with a single-line file (with a new line) with v1.0.2:
Starting the github commenter...
The commenter failed with the following error:
failed to create a new commenter. there were errors processing the PR files.
the patch details for [.terraform-version] could not be resolved

diff --git a/.terraform-version b/.terraform-version
index 9084fa2..781dcb0 100644
--- a/.terraform-version
+++ b/.terraform-version
@@ -1 +1 @@
-1.1.0
+1.1.3

This is still an issue for us as well. we have a file (agent/VERSION) that has one line in it. We're using @latest for the pr-commenter.

Added a newline to the file and it is still failing:
The commenter failed with the following error:
failed to create a new commenter. there were errors processing the PR files.
the patch details for [agent/VERSION] could not be resolved

okay, seems the patch format is different again for that - will take a look now

Hey @ouranos  and @FooBartn  - I've fixed this in v1.0.3 of the action and the patch processing can now handle single line patches @@ -1 +1 @@ - before it was looking at patches and assuming they'd always be @@ -1,2 +1,4 @@ type strings.
Please let me know how you get on, and thanks for your patience

Success! Thank you!

Same here, thanks for the quick fix!


[fontbe] Create GDEF for GlyphClassDef if needed

Previously we would only add a GlyphClassDef table to an existing GDEF table, but would not create a GDEF table if one had not been produced by feature compilation.
This patch matches the behaviour of fontmake.
This does raise the question of whether or not either compiler should bother generating a GlyphClassDef subtable in the absense of GPOS/GSUB, but that's something we can address separately.

Opened https://github.com/googlefonts/fontmake/issues/1120 to discuss whether we should be creating GDEF at all in this case.


Slog based logging

closes #1164, part of #1198
The target is 1:1 of old formatting. Not possible with standard slog handlers

Thank you for your effort there @Exca-DK. I don't think it's necessary to match the old format.
If we could get away with using slog defaults and remove everything but the interface (and possibly no-op implementation) from utils/log.go, that would be amazing.

If we want to go with defaults then we will also need to remove the colors flag since slog doesn't support it.

If we want to go with defaults then we will also need to remove the colors flag since slog doesn't support it.

Thanks for pointing that out. It appears zap is implementing its own slog handlers. Shall we continue using zap's nice features and let it handle the slog migration? cc @IronGauntlets

Closing since the issue is closed too.


Use nvim-web-devicons if available to show filetypes

Hi @twio142 ! Thanks for the PR.
Strictly out of curiosity -- what do you think about having this feature toggleable with a Boolean option, to cover users who have nvim-web-devicons  available but don't want icons here? But if you don't think it's going to be an issue, feel free to say no.

Hi @twio142 ! Thanks for the PR.
Strictly out of curiosity -- what do you think about having this feature toggleable with a Boolean option, to cover users who have nvim-web-devicons available but don't want icons here? But if you don't think it's going to be an issue, feel free to say no.

Good idea :)


gerrit-339020-1

Codecov Report

Merging #490 into master will increase coverage by 23.7%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   63.05%   86.76%   +23.7%
==========================================
  Files         271        1     -270
  Lines       50912       68   -50844
==========================================
- Hits        32104       59   -32045
+ Misses      18808        9   -18799

Impacted Files
Coverage Δ

setup.py
86.76% <ø> (-2.28%)
:x:

scripts/imagecopy.py

pywikibot/botirc.py

scripts/misspelling.py

scripts/maintenance/compat2core.py

pywikibot/families/wikidata_family.py

scripts/basic.py

scripts/commonscat.py

tests/thread_tests.py

tests/dry_api_tests.py

... and 260 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d4771...c005b0e. Read the comment docs.


loadable/component  is not Working on IE(10 and 11)

🐛 Bug Report
**Invalid character SCTIPT1014 is thrown when loading in IE(10 and 11) in loadable/component while in chrome it is working fine.
To Reproduce
**Please find the below link to reproduce
** https://github.com/dineshgurumoorthy/reactcodesplitting
**Run the localhost in IE
Steps to reproduce the behavior:
**modulechunk component is rendered initially in root/
**routechunk component is rendered when hitting /lazy
Expected behavior
**The website should open without issues
Link to repl or repo (highly encouraged)
** https://github.com/dineshgurumoorthy/reactcodesplitting
Attached Image is the console

Run npx envinfo --system --binaries --npmPackages @loadable/component,@loadable/server,@loadable/webpack-plugin,@loadable/babel-plugin --markdown --clipboard
Paste the results here:
We ain't see any results since we see the site is not initiating..

@dineshgurumoorthy We seem to have the same issue now, however it was working fine before we 1) updated from webpack 3 to 4 (probably unrelated?) and 2) Followed this https://web.dev/codelab-serve-modern-code/ to only transpile modules for older browsers.
It seems like after following above guide only the main bundle is transpiled but the chunks/lazy loaded components aren't transpiled at all and that's probably why IE11 and below doesn't work?

CRA ("react-scripts") are compiling everything down to IE9, and produced code should work.
As well as loadable-component are not quite CRA friendly - there is no reasons to use them without SSR or at least custom babel configuration.
Consider using React.lazy, but it would not resolve your IE issue.
However, I am really not able to help you with this issue. Bundle generation is not something we control.

We don't use Create React App (CRA) if that's what you mean?

there is no reasons to use them without SSR

We only load required js for the entry page and then if you switch to another page (SPA) that requires other js we lazy load it using this lib. So I think it is very useful.. Also I would do SSR if it was an easy step in our current setup but currently it's a lot of work and also some risk that stakeholders would have to agree upon.

or at least custom babel configuration.

Would be super grateful for any support but I understand that this falls outside this lib's responsibility perhaps. But maybe the community can come together and help :)

We don't use Create React App (CRA) if that's what you mean?

The repo in the issue - https://github.com/dineshgurumoorthy/reactcodesplitting is CRA based.

lazy load it using this lib. So I think it is very useful

It was somewhere in a readme that "if you don't need all extra stuff provided my loadable-components, you probably need React.lazy".

But maybe the community can come together and help :)

CRA "officially" does not support SSR. And other platforms (Next, Gatsby) might enforce you to use their own code splitting solutions.
There is a good way to "support" loadable on CRA - expose a babel macro, but no one ever asked for it 🤷♂

I'm not the reporter of this case, just experiencing the same :) I could try React.lazy but as you already mentioned it probably won't help :/
We do not use Create React App (CRA?) but the author of this case does :)

Hi Anton,
This App was just created to convey the message, however we have configured
our project with webpack
On Tue, 9 Jun 2020 at 12:29 PM, Anton Korzunov<EMAIL_ADDRESS>wrote:

We don't use Create React App (CRA) if that's what you mean?
The repo in the issue -
https://github.com/dineshgurumoorthy/reactcodesplitting is CRA based.
lazy load it using this lib. So I think it is very useful
It was somewhere in a readme that "if you don't need all extra stuff
provided my loadable-components, you probably need React.lazy".
But maybe the community can come together and help :)
CRA "officially" does not support SSR. And other platforms (Next, Gatsby)
might enforce you to use their own code splitting solutions.
There is a good way to "support" loadable on CRA - expose a babel macro,
but no one ever asked for it 🤷♂
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/gregberge/loadable-components/issues/581#issuecomment-641075005,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOVY2UZ5A6W4CIZ2H7UEB7LRVXMTHANCNFSM4NTNQANA
.

Hello I have a React SSR boilerplate ready for you https://github.com/tomtom94/react-easy-ssr give me a star guys :)
But I confirm, in targets from babel.config.js right here https://github.com/tomtom94/react-easy-ssr/blob/master/babel.config.js#L12
When I put { ie: '11' }
targets: web ? { ie: '11' } : { node: process.versions.node }, // https://babeljs.io/docs/en/options#targets

Arrow functions in bundles js are yet present, probably coming from loadable-component.


Support for time to live

I'm looking for a convenient way to set the TTL parameter for my collection. Right know I think this is only possible from the browser - is this correct?

@julianzur
Could you please help to try the TTL feature in master branch, The feature will be available in next release.

@Incarnation-p-lee
Thanks for your support! I wanted to test your changes but I'm still on SpringBoot 1.5. Will this feature also be ported to the 1.5 branch?

@julianzur
OK, we can do that with cherry-pick. But that feature may available in next release for spring-boot 1.5.x.
Thanks for you information,

@Incarnation-p-lee
Can you give an ETA on when I can expect the change to be released for 1.5.x? Thanks. :)

@Incarnation-p-lee
I cherry-picked the changes to the 0.1.x-branch. As I don't have the permission to push to this repo, I uploaded the diff as a txt file and attach it to this comment. Hope this helps. Thanks!
patch.txt

@julianzur
Thanks very much for you contribution. It seems open the PR to public. I am not sure that permission issue. Could you please shared how to do that cherry-pick ?

@Incarnation-p-lee
Sorry, this is my first change to a public repo - maybe I'm misunderstanding the process. I am allowed to open a pull request - but I am not allowed to push local changes to the repo.

Pull requests let you tell others about changes you've pushed to a repository on GitHub.
https://help.github.com/articles/about-pull-requests/

So, I cloned the repo, switched to the "0.1.x" branch and cherry-picked the changes from master. After resolving the conflicts, I endet up with a change set that I was not allowed to push back to the repo. That's why I stored them as a diff and uploaded them to this disucssion.
Hope this makes sense.

@julianzur
Thanks for you time and work. Yeah, the process is almost like what you done. But a little different after resolving the conflicts. All developers include me are not allowed to push PR directed to this repo. We use PR mode. You can follow the step I list below.

cherry-pick and fix conflict
run test locally
If all test passed, push you change to you forked repo.
After all, create the PR to original repo from your forked repo.

Could you please help to have a try? Any problem please feel free to contact us. ;)

Hey @Incarnation-p-lee!
Will there be a 0.1.x release that contains the cherry picked changes any time soon?

Yes, the next release of 0.1.x will cover that part. I will info you if ready.


Docs update

Codecov Report

Merging #16 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
- Coverage     73.01%   72.77%   -0.25%
+ Complexity      392      390       -2
============================================
  Files            16       16
  Lines          2446     2446
  Branches        500      500
============================================
- Hits           1786     1780       -6
- Misses          470      475       +5
- Partials        190      191       +1

Impacted Files
Coverage Δ
Complexity Δ

...m/msd/gin/halyard/strategy/collections/Sorter.java
59.37% <0%> (-18.75%)
6% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b145d...fa59592. Read the comment docs.


flutter pub get failed on cloning "auto_size_text" package

flutter pub get failed on cloning "auto_size_text" package because in "pubspec.yaml" the git url of 'auto_size_text' is "git://github.com/gskinnerTeam/auto_size_text.git" it should be either "https://github.com/gskinnerTeam/auto_size_text.git" or<EMAIL_ADDRESS>

I changed the GitHub target in pubspec.yml to https://github.com/gskinnerTeam/auto_size_text.git which fixed the issue for me.

thanks @rubiii that worked for me!

The named parameter 'textBuilder' isn't defined.
Try correcting the name to an existing named parameter's name, or defining a named parameter with the name 'textBuilder'.


Birthplace of the attackers

What if the attackers spawn in front of the character? At the moment, the attackers are formed inside the character.

**Sorry, I'm using translation.
I want to tell you again
What do you think, if the attackers are like vehicles, spawn a little ahead of the character?
Thank you.**


Ho do I end all the tours except the present tour from inside onclick button event

Hi,
I have multiple tours in one js file. I want to execute only one at a time on different button clicks.
But when I try to execute any of teh tours all the other tours also executing. I didnt add start methods to them outside the code respective start methods are inside the button click events. Only init method is in global scope. Is that what casuing issue for me ?
If I try to include init inside a button click function the tour is not at all running even though I add restart method.
Thanks

Please can you show a demo of the issue?


missing params fix in getQuerystringSearchQuery

Fixes #6266
getQuerystringSearchQuery is discarding all params except query param, hopefully, I've fixed it in this repo.
However, I see in https://github.com/plone/plone.restapi/blob/main/src/plone/restapi/services/querystringsearch/get.py#L99 backend service is also only processing the query param, will create a separate PR in plone/plone.restapi to fix there as well once status of this PR is confirmed.

@JeffersonBledsoe  kindly you could confirm if these are the desired changes I'm heading in the right direction, thanks.

@Faakhir30 please update your branch with main and push to this pull request. See https://6.docs.plone.org/contributing/first-time.html#update-your-pull-request-from-your-fork

Hi @Faakhir30 . Thanks for looking into this!
If the REST API is also not expecting anything other than the query parameter,  then it could be that this is actually the intended behaviour and the documentation may need an update. I'll bring this up at the next Volto team meeting and report back here with any decisions.

@Faakhir30 @JeffersonBledsoe When calling the /@querystring-search endpoint with the GET method, it expects query as a serialized JSON object which can contain multiple keys including query, b_start, b_size, etc.

Thanks for the clarification! I'd skimmed over the docs when re-visiting this and hadn't noticed that both the searchParam and the inner key are both referred to as query in the GET request.

@Faakhir30 @JeffersonBledsoe When calling the /@querystring-search endpoint with the GET method, it expects query as a serialized JSON object which can contain multiple keys including query, b_start, b_size, etc.

yeah,  thanks for the clarification, I'm closing this PR as this isn't required then.


The quality of result image

Hi Erman Nghonda
First of all, I want to express my gratitude for your publicizing the source code. I am encountering an issue with the quality of the resulting image when running Poisson blending with the flower data. While the stitching and blending are satisfactory, the resulting image has a blurry layer and is not as clear as the original image. I would greatly appreciate it if you could provide me with some suggestions to resolve this issue.

Hi Khoa
When I ran the code on ./data/flower folder, I got this output. I cannot see the blurry layer as in your image (but I can see the seams though). Did you modify any of the code?

Hi Khoa,
If you do histogram matching after that, it should be OK.
`from typing import List
import cv2 as cv
import numpy as np
from skimage.exposure import match_histograms
from img_utils import resizeImg
from poisson import convertDouble2Uint8, poissonSolver
from utils import readFiles, divAB
... (keep the existing functions)
def main_merge(img_paths: List[str], mask_paths: List[str], out_path, scf=1.) -> None:
# ... (keep existing code up to the poissonSolver call)
# Compute the Poisson equation.
img_out = poissonSolver(guide_x, guide_y)

# Convert the double image to uint8.
img_out = convertDouble2Uint8(img_out)

# Match histogram of img_out with T
img_out_matched = match_histograms(img_out, T, multichannel=True)

# Save the results.
cv.imwrite(out_path, img_out)
cv.imwrite(out_path.replace('.png', '_matched.png'), img_out_matched)

# Display results
cv.imshow("Result (Before Histogram Matching)", img_out)
cv.imshow("Result (After Histogram Matching)", img_out_matched)
cv.waitKey(0)

... (keep the rest of the code)`

Dear Lam,
Thank you for your suggestion. I tried it, and it worked.
Best,
Khoa Tran


Support registry bulk upload events in worker architecture

When bulk upload events happen in the registry, the worker architecture receives high traffic and needs to scale. This can be handled with a combination of 2 things:

Cloud Tasks has some recommendations when the traffic to the queue reached above 500 QPS. https://cloud.google.com/tasks/docs/manage-cloud-task-scaling
GKE auto-scaling for the workers deployment.

Not relevant right now. Will reopen if evaluated later.


Add custom tag

This PRs adds a simple way to specify a custom tag.
Fixes #18

🌷 IMO we should update the README. WDYT ?

I think the readme is not the documentation, it must showcase the relevant features, the rest is to be found in the godoc.


Usage ?

Hello, im wondering if there is a agent app aswell, so the delivery guy can see and pickup the orders. If not, can you recommend me something please? Thanks in advance

Hi,
we don't have that. This is a technology demonstration not a demo of a product. So we aren't deeply familiar with the industry as a whole.


my vehicle remains stationary all the time

When I run the pre-training model, my vehicle remains stationary all the time. How can I solve it?

Which branch are you using? On the 2021 branch this is expected (should not happen always but can happen in multiple routes).
This is an instance of causal confusion/ Inertia Problem and the model in the 2021 is strongly affected by it.
The newer models in the 2022 branch are better and have this problems less (but still do).
The 2022 branch additionally has a creeping rule to posthoc fix this problem.
We noticed that causal confusion is not robust and can easily be broken if the vehicle slowly roles forward, which we do if the car is stuck for a long time (e.g.: see Table 10 in the paper).

Thank you for your quick and accurate answer. I used the branch in 2022. The vehicle remains stationary all the time, only occasionally moving a little to the right and front. So can this be solved?

Thank you for your quick and accurate answer. I use the 2022 version. The vehicle remains stationary all the time, only occasionally moving a little to the right and front. Can this be solved?

I tried: 1) using -vulkan to solve this problem, but I can only use -oepngl, but I can't use -vulkan. Once I use -vulkan, carla<IP_ADDRESS> can't display the picture. 2) I also tried -quality-level=Low, but the vehicle never moves.

opengl is fine. This sounds more like a problem with the setup then.
My first guess is that the model weights aren't loaded correctly (this can fail silently and use uninitialized weights).
Thy debugging this here.

Thank you for your patient answer. I debugged the place you pointed out.  Does this mean that the model does not load weights normally?

Thank you for your patience in answering. I debugged the areas you pointed out. Through temp = net.load_state_dict(state_dict, strict=False), 1) For transfuser, I got temp = _IncompatibleKeys(missing_keys=[], unexpected_keys=['_model.lidar_encoder._model.stem.conv.weight']). 2) For late_fusion, I got temp=<All keys matched successfully>, does this mean that the weights have been loaded correctly, but in both cases, the vehicle remains stationary! I'm very distressed about this issue.

These should be fine, these keys are mismatched because the models were trained with an older codebase.
Can you try the visualization function and send an example here?
You will know that the model weights are loaded correctly if those look reasonable.
You need to set the environment variable SAVE_PATH=/path/to/log/folder
as well as put the debug variable to True in the config.
to use the visualization function.

The global position of the vehicle is shown in Figure 1.

The result of visualization is occasionally Figure 2 and Figure 3, but the position of the vehicle remains unchanged all the time.

Hm that is very strange. It means the central camera is failing occasionally.
This should not happen. I have never seen this before, you need to debug to see why this is happening.
In general how the camera image is created, is by having 3 high resolution cameras, cropping out the center part (to remove image distortions) and then concatenating them together.
Its expected that the vehicle doesn't move if the vehicle breaks every couple frames. You need to throttle a lot of frames consecutively in CARLA for the car to start driving.
The model itself seems to be loaded correctly.

I found that the white block in the middle was only an accidental phenomenon. I collected the visualization results twice again and found no white block in the middle, but the vehicle never moved!

Thank you for your patient answer. I will try again.


Tile layer window not positioned properly

Tile layer window should keep its current window position like properties window does, right now it always re-centers itself.

This is going to be at the same position as properties window

this is going to be at the middle-left of the screen


Possible Map Error?

Checklist

[x] I have read the FAQ
[x] I have checked if this issue already exists (both open and closed issues)
[x] I am using the most recent version of pogom from the master branch
[ ] If this is an installation issue, I am posting my OS, OS version, python version, pip version
[ ] I'm posting the complete log
[ ] I'm using a descriptive title for this issue

My Issue
Today I noticed while running the map there was a Kabutops that would expire and and re-spawn in the same exact location which happened about 6-7 times with a remaining time anywhere from 30 seconds up to 2 minutes. I heard that appereanly some Pokemon have 30 minute spawn timers but the first 15 minutes is returned negative when using  the function time_till_hidden_ms and negatives are not supported in java. Not sure if that is the issue but thought i should just mention it.
...

#213


Add support of black-macchiato

https://github.com/wbolster/black-macchiato is a simple wrapper around black.
I notice vim-autoformat already support black, but it does not support formatting range. black-macchiato just works on a code snippet, removing its indentation and formatting. black-macchiato does not have argument to specify the begin/end range on command line.
Wondering if vim-autoformat could add support of black-macchiato, and make the black support on both whole buffer and a range.

Yeah, we support that. Have a look at how the autopep command is implemented:
 let g:formatdef_autopep8 = '"autopep8 -".(g:DoesRangeEqualBuffer(a:firstline, a:lastline) ? " --range ".a:firstline." ".a:lastline : "")." ".(&textwidth ? "--max-line-length=".&textwidth : "")'

Also see the respective README section: https://github.com/Chiel92/vim-autoformat#ranged-definitions


Update nscplugin, sbt-scala-native to 0.5.6

About this PR
📦 Updates

org.scala-native:nscplugin
org.scala-native:sbt-scala-native

from 0.4.17 to 0.5.6
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-native" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-native" }
}]

labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

upgrade to scala native 0.5 is blocked by https://github.com/bkirwi/decline/issues/551 (which itself is blocker by cats-effect)


Hide Metal drawables from Kotlin runtime

Explicitly manage lifetime of metal drawables by hiding them from Kotlin runtime.
Fixes a memory spike when quickly resizing metal layer as in a scenario reported in the issue
Otherwise associated drawable pools are retained until next GC, which can happen after inadequate amount of drawables with new sizes are allocated

Before:

After:

Testing
Resize the popup with ComposeUIViewController to different detents inside Demo IosBugs/PopupStretching
Requires either patch:
Index: compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt b/compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt
--- a/compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt	(revision 39d436a845d0cbe9526a6c24933268aacf83b2eb)
+++ b/compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.uikit.kt	(date<PHONE_NUMBER>590)
@@ -558,6 +558,7 @@
                 asDpRect().toRect()
             }
         }
+        onComposeSceneInvalidate()
         scene.size = IntSize(
             width = boundsInPx.width.roundToInt(),
             height = boundsInPx.height.roundToInt()

Or https://github.com/JetBrains/compose-multiplatform-core/pull/1387
Release Notes
Fixes - iOS

Fixed a memory spike when continuously resizing the ComposeUIViewController (such as when used in modal sheet presentation context with different detents)

The particular web tests were reported to be flaky and are unrelevant to the PR, merging ignoring the failure.

Do you reckon this is related? https://github.com/JetBrains/compose-multiplatform/issues/4852

Yes, sorry, your comment notification slipped from my attention. I am glad it has fixed your problem too.


Improvements to default theme

Make sure code comments have at least AA readability by default and scale the default color accordingly.

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


[SMALLFIX]update AlluxioMasterRestServiceHandler

first test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/19355/
Test PASSed.


Provide LSP Folding Range Request

Is your feature request related to a problem? Please describe.
Some IDEs (such as VS Code) provide their own LSP-free solutions for code folding using the following methods:

Indentation - regions with the same indentation level will be folded
Regular Expression - can specify patterns for the start/end of folding regions.

There are problems with each of these:

Indentation-based folding may fail or fold incorrect regions when indentation is incorrect in the file, or when classic function indenting is used.
RegEx-based folding may incorrectly identify 'end' in comments and strings

Describe the solution you'd like
Provide a handler for Folding Range Requests

Closing this issue - this functionality was added in v1.2.4, and requires R2024b or later.


Add first draft of contract

@Henryvw quick first draft, please add corrections or let me know what I forgot.

Roger Will do
Sent from my iPod

On Oct 20, 2017, at 12:35 PM, Matthias Loker<EMAIL_ADDRESS>wrote:
@Henryvw quick first draft, please add corrections or let me know what I forgot.
You can view, comment on, or merge this pull request online at:
https://github.com/Henryvw/eruditus/pull/1
Commit Summary
Add first draft of contract
File Changes
A contract.md (43)
Patch Links:
https://github.com/Henryvw/eruditus/pull/1.patch
https://github.com/Henryvw/eruditus/pull/1.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Update CICA records

This PR updates cica.gov.uk hosted zone with a new CNAME:
Name: mitrefinch
Type: CNAME
Value: mitrefinch-cicagov.msappproxy.net

Where has the request come from?


No randomness is added during the sampling process?

Hey fellows, really good work and thanks for sharing the code. However, I've got a question about the sampling process. It seems like no randomness is added during the sampling process, like the z in the following equation.

I've checked the code and it seems like add_noise function defined in DPM_Solver class has never been used. Why is the case? Could you very kindly explain this? Thanks!

Because DPM-Solver is an ODE-based solver so it does not add noises at the intermediate steps. I also implemented SDE-based DPM-Solver here: https://huggingface.co/docs/diffusers/en/api/schedulers/multistep_dpm_solver

Because DPM-Solver is an ODE-based solver so it does not add noises at the intermediate steps. I also implemented SDE-based DPM-Solver here: https://huggingface.co/docs/diffusers/en/api/schedulers/multistep_dpm_solver

Thanks for your reply. Any preference for these two implementation? which one is more accurate?


Fix bug when a value is null

Fix #121

Current coverage is 86.68% (diff: 100%)

Merging #140 into develop will increase coverage by 0.15%

@@            develop       #140   diff @@
==========================================
  Files           116        116
  Lines          1960       2028    +68
  Methods          58         63     +5
  Messages          0          0
  Branches        149        164    +15
==========================================
+ Hits           1696       1758    +62
- Misses          206        209     +3
- Partials         58         61     +3

Powered by Codecov. Last update d76a861...5d68b25


Add toolbar to connector table

UX improvement suggested addition of a connector table toolbar, shown below (sorting and pagination)

Per this morning's discussion, we can defer implementing pagination.  We can address in the future if needed.

This can be closed, I'll create follow-up issue for directional toggle


Would it be wise/possible to include Stratego to Open_spiel

Hello,
I am currently writing my master thesis about (scalable) multi-agent systems for large/complex games with hidden information.
My question is: would it be wise with the current state of open_spiel to try to include Stratego/Barrage Stratego or is the game simply not feasible/out of scale?
If it is possible, do you have any recommendations (@michalsustr maybe?)
I know that is not an issue with the current state and more a question about a possible extension. Hope it is okay to open an issue for this.

I would love to have implementation of Stratego! I even had a discussion with @lanctot about this and we both agreed that it would be nice, however there might be copyright issues with publishing the implementation. Since this repository is maintained by Deepmind, they didn't want to get into a potential hassle because of the copyright. However feel free to implement the game in your own fork -- if you want I can give you a code review.
My limited understanding of the legal problem is that the game mechanics are not copyrightable, but the name is, so either getting an official approval or publishing the implementation under a different name should be fine.

Hi @BluemlJ,
It is totally ok to open an issue for this! I would also love to see an OpenSpiel implementation of Stratego. It certainly is feasible and within "scale" / scope. The only problem is that is that the game is copyrighted.
We had a case like this before: someone contributed an implementation of Catan. We decided the safest route was for the game to be hosted independently by the contributor, and that we could mention the third party implementation on our game list (but without a link). We could certainly offer the same option for Stratego.
However, I do anticipate a growing number of cases like this one, so I am still planning to look into options like we did for Hanabi, which was to contact the publishers and get official permissions. This is not a quick process, though, and you have do this for every publisher. I should say I've also been saying this for some time... :)
The idea of using a different name is interesting -- we never investigated this. I will look into it.

The idea of using a different name is interesting -- we never investigated this. I will look into it.

Just quickly searching around it seems to be well established you can't copyright game mechanics:

Therefore, the systems or processes that make up the core of a game—generally referred to as the “game mechanics”—are not subject to copyright, even though the written rules, game board, card artwork, and other elements—often referred to as the “theme” of the game—may be. Game mechanics can be as simple as “roll dice and move a token along a track,” or far more complex. Regardless of the complexity or originality of a given game’s systems and processes, its game mechanics will likely not be protected by copyright.

From https://www.americanbar.org/groups/intellectual_property_law/publications/landslide/2014-15/march-april/not-playing-around-board-games-intellectual-property-law/
The whole page is quite an interesting read :)

Game mechanics can't be copyrighted, but they can be patented, and the patent can be granted only before the game has been played publicly. Reading through the wikipedia article it seems the only potential problem could be a 1908 French patent for L'Attaque, but that should be expired :-P However it seems the trademark for the game is still active, which means the original name shouldn't be used.

Hey guys,
I wrote this little game called "Yorktown" in an own fork [0] . It is quite similar to this old game called "Stratego" (which means the game mechanics are identical) :wink:
The implementation, especially the game_board is based on the chess_board in Open_spiel.
It is not finished yet but it is at at a point where you can run random_agents against each other.
Some open ToDos are

check why tests 91,92 and 154 (python_api, python_playthrough and python_pyspiel) fail
write own tests for the board and the game itself
fix the observations -> how to deal with partial information situations better (probability representation in form of planes maybe)
check for information leakage in any form (especially in tree search methods)
test some algorithms on the game and see how they work/if they work
...

Maybe you want take a look yourself [0].
I am open to changes, if you have any feedback or ideas.
[0] : my fork

Closing this now since there is a PR: https://github.com/deepmind/open_spiel/pull/635