Point parameters

Hello!
It would be nice to have some basic options to change points' look and style in a scatter plot. For example, size or shape. Or to add some interactivity by changing the point's look when the mouse hovers a particular point (to make it bigger, to add a halo, etc).
Kindly,
Dmitry

+1 for this. Should be standard functionality. Google Charts has similar options

Is this still not possible? I am looking at migrating from Google Charts and surprised this ability doesn't exist.


Shutdown sessions started by Interactive Window

For #5030

Codecov Report

Merging #5107 (9788716) into main (5a4056f) will increase coverage by 0%.
The diff coverage is 88%.

@@          Coverage Diff          @@
##            main   #5107   +/-   ##
=====================================
  Coverage     73%     73%
=====================================
  Files        402     402
  Lines      26360   26374   +14
  Branches    3790    3795    +5
=====================================
+ Hits       19427   19440   +13
  Misses      5356    5356
- Partials    1577    1578    +1

Impacted Files
Coverage Δ

src/client/datascience/types.ts
100% <ø> (ø)

src/client/datascience/baseJupyterSession.ts
75% <82%> (-1%)
:arrow_down:

src/client/datascience/jupyter/jupyterSession.ts
83% <100%> (+<1%)
:arrow_up:

...client/datascience/raw-kernel/rawJupyterSession.ts
68% <100%> (-1%)
:arrow_down:

src/client/datascience/raw-kernel/rawSession.ts
57% <100%> (+<1%)
:arrow_up:

...rc/client/common/process/pythonExecutionFactory.ts
83% <0%> (-4%)
:arrow_down:

...datascience/jupyter/liveshare/hostJupyterServer.ts
65% <0%> (-2%)
:arrow_down:

src/client/datascience/raw-kernel/rawSocket.ts
86% <0%> (+1%)
:arrow_up:

src/client/datascience/common.ts
85% <0%> (+2%)
:arrow_up:

... and 1 more


Prevent compute auth from hanging.

When a user does not have service account credentials, the compute auth
script should give a warning instead of hanging.

[Current coverage][cc-pull] is 98.41%

Merging [#297][cc-pull] into [development][cc-base-branch] will increase coverage by <.01%

@@           development       #297   diff @@
=============================================
  Files               34         34
  Lines             2632       2644    +12
  Methods              0          0
  Messages             0          0
  Branches           131        131
=============================================
+ Hits              2590       2602    +12
  Misses              37         37
  Partials             5          5

Powered by Codecov. Last updated by [4c394b5...6961aab][cc-compare]
[cc-base-branch]: https://codecov.io/gh/GoogleCloudPlatform/compute-image-packages/branch/development?src=pr
[cc-compare]: https://codecov.io/gh/GoogleCloudPlatform/compute-image-packages/compare/4c394b5f48eafe1c18cf21534c9a5f4a2e076568...6961aab6aa2899d6f7309714d563b7d8105324c3?src=pr
[cc-pull]: https://codecov.io/gh/GoogleCloudPlatform/compute-image-packages/pull/297?src=pr

LGTM


Added PapyrusResponseError

Hi there. This pull request is about #17 and my comment there. I added PapyrusResponseError, which extends PapyrusError.
Now we can have something like this:
API:
@API
protocol GPT {
    @POST("images/generations")
    func generateImage(body: Body<GenerateImageRequestBody>) async throws -> GenerateImageResponse
}

Repository:
let body = ...
return try await gptApi.generateImage(body: body)

Some error handling, for example in ViewModel:
func handleError(_ error: Error) async {
    guard let error = error as? PapyrusError else { return }
    var message = error.message

    if let response = (error as? PapyrusResponseError)?.response,
       let responseError = try? response.decode(ErrorResponse.self, using: decoder) {
        message = responseError.error.message
    }

    self.error = message
}

I don't think this is the best solution for now. Waiting for you comments.

BTW, this way
... -> Response

methods will also throw PapyrusErrorResponse. I think this is more intuitive. So, docs should be updated

This is great @F0x1d ! I was thinking of doing things the same way.
How about we give an optional let request: Request? and let response: Response? to PapyrusError and we can use that error for everything (passing a request and response if one or both are available)?


In search of wisdom yet again

hi again, bare with, more coffees are coming.
I'm trying to assign an url on runtime to a webview but
i have this loop :
TLabWebView[] webviews = duplicate.GetComponentsInChildren<TLabWebView>();
TextMeshPro[] textMeshes = duplicate.GetComponentsInChildren<TextMeshPro>();
foreach (TLabWebView webView in webviews)
{
        webView.SetUserAgent("Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20100101 Firefox/10.0");
        webView.LoadUrl(url);

        foreach (TextMeshPro textMesh in textMeshes)
        {
            if(textMesh.name == "DebugText"){
                textMesh.text = "UserAgent: "+ webView.GetUserAgent() + "   Url: "+ webView.GetUrl();
            }
        }
}

The Webview is structured as such in my project :

The "duplicate" object from duplicate.GetComponentsInChildren<TLabWebView>(); represents the assigned EmptyWebView object from the screenshot.
Problem i'm having is:
webView.SetUserAgent("Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20100101 Firefox/10.0");
webView.LoadUrl(url);

dont seem to work as  textMesh.text = "UserAgent: "+ webView.GetUserAgent() + "   Url: "+ webView.GetUrl(); results in UserAgent and Url being empty. The "url" variable does contain a text string.
If something comes to mind please let me know. The webview is being found, the TextMeshPro object is being found but the set "SetUserAgent" and "LoadUrl" dont seem to get assigned. Thank you!
P.S. I have attempted to add a new function in the TLabWebView.cs called GetUrl() which should return the url on which the page is on, but because of this issue i cant really tell if it's working:
public string GetUrl()
{
	if (!m_webViewEnable)
	{
		return null;
	}

	string currentUrl = null;

#if UNITY_ANDROID
	if (Application.isEditor) return null;

	// Assuming m_NativePlugin is your reference to the native webview component.
	currentUrl = m_NativePlugin.Call<string>("getCurrentUrl");
#endif

	return currentUrl;
}

Hello.
GetUserAgent() is a function to retrieve the result obtained by CaptureUserAgent(), so please execute it like this.

    public async void GetUserAgent()

    {

        m_webView.CaptureUserAgent();

        await Task.Delay(500);

        Debug.Log("User Agent: " + m_webView.GetUserAgent());

    }

CaptureaUserAgent() is executing asynchronously, so please wait a little before GetUserAgent().
I will also add a function to get the URL later.

out of curiosity, how many instances can you spawn before it gets laggy ? With just one instance and
Web Width = 1280,
Web Height 720,
Tex Width 1280
Tex Height 720
it starts feeling sluggish , and if i spawn 4 more webviews it feels like it's 10FPS when moving my head around. Sorry to bother, but i need to figure out if i'm doing something wrong..


[WIP] Promises to Async Await Code Fix

Fixes #

Adding @bterlson

@andy-ms can you please review

@elizabethdinella can you refresh the branch with a merge from master.

@andy-ms can you please review this change.

function f() {
	return Promise.resolve().then(() => 1, () => "a");
}

Generates catch(), which is an error.

function f() {
	return Promise.resolve().then(x => 1).catch(x => "a").then(x => !!x);
}

Generates
async function f() {
	let x_1: string | number;
    try {
        const x = await Promise.resolve();
        x_1 = 1;
    }
    catch (x_1) {
        x_1 = "a";
    }
    return !!x_1;
}

There's a collision between the catch parameter and let x_1.

function f() {
	return Promise.resolve().then(function g(x) {
		try {
			return Promise.resolve().then(y => 1);
		}
		catch (e) {
			e;
		}
	});
}

The try-catch is eliminated, which seems questionable.

function f() {
	return Promise.resolve().then(f ? (x => 1) : (y => 2));
}

Generates
async function f() {
	await Promise.resolve();
}

Re the comment above that
"There's a collision between the catch parameter and let x_1"
A catch clause introduces a new lexical scope, and its parameters don't impact outside the scope. (It's a little more nuanced than that - the answer on https://stackoverflow.com/questions/7926237/javascript-catch-clause-scope is a good reference).

@billti My concern was that the assignment in the catch block seemed to update the catch parameter, rather than the local being used for the return value.

Subsumed by https://github.com/Microsoft/TypeScript/pull/26373


[BUG] - Ghost button stayed at hovered state after click on mobile devices

NextUI Version
latest
Describe the bug
The ghost button stayed hovered state after clicking on mobile devices https://nextui.org/docs/components/button
The ghost
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

On mobile device click the ghost button
Hoved state applied
and you have to click outside to remove the hover

Expected behavior
After clicking hover state removed
Screenshots or Videos
No response
Operating System Version
mobile
Browser
Other (add additonal context)

colorVariants.ghost in package @nextui-org/theme uses pseudo-class hover. trying to fix it.


Clarify philosophy about configuration

I don't want to put words on your mouth, but I think the philosophy of this project is "Zero configuration", similar to that of standard.
Convention over configuration is about providing sane defaults, but with the ability to override them if they don't match your needs. That is a different thing, IMO.

Our motto is convention over configuration, because we do allow some things to be configured.
Thanks for the PR, however -- but I think this wording will remain!
Also, thanks for your interest in this project. You can get more involved by checking out these issues!

So far what we're trying to achieve is zero configuration out of the box, but some overridable settings for shared resources (e.g. port) or popular escape hatches (e.g. NODE_PATH). To achieve this goal we use convention (e.g. src/index.js is the hardcoded path for entry point) so I think it's worth leaving that in.

My point is that it is a bit misleading. Given that motto and coming from the Ruby on Rails world where the expression originated, I expected to be able to configure a lot more things than what's possible (e.g. eslint, preprocessor, webpack) without resorting to ejecting or workarounds. I'm not judging it, I understand the motivation, but there is a huge difference in the level of configurability of both projects, IMO.

OK I think this is fair.

FWIW we started with Zero Configuration there, and changed it in https://github.com/facebookincubator/create-react-app/pull/1031.
I can be persuaded both ways 😄
Maybe there's a more nuanced way to word this.

Limited tool agnostic configuration?

Or maybe just "Tooling Agnostic Configuration"

No Configuration Required?

Perhaps, I like that. We can then explain we provide a limited set of configuration and reference the docs.

PR?


Retirement refactor

~CONTROVERSY ALERT ❗~
I started working on speculation and saw a pattern in Retirement. I refactored it as FSM that calls python methods!
This way we can eliminate:

All of the ugly sync/comb duo control signals - python functions that call Methods are executed under If from any state. When implementing misprediction interrupt I would need to add another pair of signalling like that. (also turns out there was previously probably a bug, because rrat call only used sync side_fx)
Forwarders - now potentially (almost all) blocking methods are called from separate Transactions.
Conditions in Ifs simplified

I think that logic is also way easier to understand with clear separation of retire/flush and state of what the retirement currently is doing.
Unfortunately the limitation that methods can be called only once from transaction, breaks fun here. It would look even nicer without it see commit. And MethodBrancher cannot be used in this case.
For me it looks great. What do you think about it?
Also it would be nice to review/merege it quickly, as my further work on speculation depends on this (it would be ugly and bug-prone otherwise)

There seems to be loss in benchmark IPC for some reason. Needs investigation

I see, FRAT is still called under one condition form main Retirement. I will probably re-introduce one Forwarder, maybe there is some better solution?

I see, FRAT is still called under one condition form main Retirement. I will probably re-introduce one Forwarder, maybe there is some better solution?

Maybe try using condition? This would split that transaction into two.

Maybe try using condition? This would split that transaction into two.

Great! It also fixed problem with call to free_phys_reg. Thanks!
I will check the IPC in a moment to be sure

oops, there is a problem with generating graph and condtion :(. [There is also graph syntax error on master again]

oops, there is a problem with generating graph and condtion :(. [There is also graph syntax error on master again]

The issue is in get_caller_class_name, I'll prepare a fix soon.

The Fmax is still pretty bad, but I imagine that #545 can still fix it?

Fmax issue is unrelated to this PR, it depends only on critical path from JBUnit to ExcepionCauseRegister.
IPC will be back to best value also after merge #545, becaue confilcts are removed here. It will not affect this Retirement code, because stall method is called from exclusive Transaction


Test: add opencom tests

Codecov Report

Merging #99 (d8e8401) into master (dffd408) will increase coverage by 0.64%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #99      +/-   ##
============================================
+ Coverage     55.45%   56.09%   +0.64%
- Complexity      523      532       +9
============================================
  Files           106      106
  Lines          2173     2173
  Branches        234      234
============================================
+ Hits           1205     1219      +14
+ Misses          907      893      -14
  Partials         61       61

Impacted Files
Coverage Δ

.../address/logic/commands/OpenCommissionCommand.java
100.00% <0.00%> (+100.00%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Fix the problem of decoding the Data field and add more debug logs

:clipboard: Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.

Change Data field type from string to interface{}
Add Debug logs

Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.
The unit tests are added.

Codecov Report
Patch coverage has no change and project coverage change: -0.05 :warning:

Comparison is base (07e2cb9) 51.83% compared to head (8c0de1a) 51.78%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #790      +/-   ##
===========================================
- Coverage    51.83%   51.78%   -0.05%
===========================================
  Files          197      197
  Lines         7991     7998       +7
  Branches      1650     1651       +1
===========================================
  Hits          4142     4142
- Misses        3849     3856       +7

Flag
Coverage Δ

coverage
51.78% <ø> (-0.05%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


acpi updates for linux 4.18

This updates acpica, promotes the acpi tables to allarch and fixes 2 problems in the arduino.asli table:

Linux 4.18 shows errors that 4.16 did not. These errors might be caused only when loading through configfs
Recent patches to U-Boot allow us to test i2c-6, appears there is a mixup in the levels for mux and dir.

UPD: these patches make the timeouts on i2c-6 go away, but I haven't been able to connect a i2c device yet. If you can please connect one and test with modprobe -i i2c-dev followed by i2cdetect -r -y 6

After testing by actually trying to detect a device more changes are needed. I hope to have those today.

I dropped the allarch patch and fixed the arduino.asli as discussed here.

Thanks


Docs add yarn.resourcemanager.principal for hive c…

…atalog with kerberos enabled.
Proposed changes
Add neccessary yarn.resourcemanager.principal config for hive catalog with kerberos enabled.
Problem summary
When creating a hive catalog with a kerberos enabled hive cluster, the config yarn.resourcemanager.principal is required, because hdfs client needs this principal otherwise we will encounter an exception like this:

Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


check if the current figure in paper reflects the current v1 pipeline implementation

My impression is that there are differences.
Please document any differences in this ticket. Thanks.

Hi @chunhualiao and @bin123apple
I have reviewed the log file and summarized the steps in the log file as follows:
Step 1

prompt: unclear.
objective: remove comments in Fortran code; get the length of the code
output:Fortran code without comments.

Step 2

prompt: unclear. It might be:
“””
Please provide a C++ translation of the following Fortran code.

{output of <1>}

“””

objective: get  a C++ translation of the given Fortran code
output:  <Fortan, C++> code pairs.
Observations and Questions:

what does “qer” mean in line 18: “qer asks for the C++ translation:”?

Step 3

prompt: “Please provide unit tests to verify the original Fortran and translated C++ codes. Use the specified formats for each language.”
objective: use LLM to generate unit test
output:Fortran and C++ code with unit tests

Step 4

prompt:  “Please run these unit tests to verify that the translation from Fortran to C++ has been done correctly.”
objective:  use LLM to run the code with unit tests.
output:  results with  “Fortran Stdout”, “Fortran Stderr”, “C++ Stdout” and “C++ Stderr”
Observations and Questions:

GPT says in the output: “fortran compile result in 0th turn: Fortran Stdout: Double Precision Test Passed Single Precision Test Passed”. Does GPT actually call the compiler to compile the code? Same question for C++ checking.
The example output contains “Fortran Stdout”, “Fortran Stderr”, “C++ Stdout” and “C++ Stderr”. Does it consistently contain these four entities in the output? I am curious as it is not specified in the prompt.

Step 5

prompt: unclear
objective: fix errors found in step 4 and run the code with the unit test again.
output:  if error repeat or consider the  <Fortan, C++> code pair passes the unit test and save them
Observations and Questions:

It seems the attempt threshold is 6.
I noticed that the first example used 6 attempts and still failed to get a pass for a very simple C++ code. Is there a way to improve it in the prompts?

Conclusion

The log file is complex to interpret as no prompt is given, and the output region is not clear. The prompts listed above are extracted from the log file, but I am not sure if they are the exact prompts used.
Prompt 4 in Figure 1 of the paper yields True/False returns, which are not found in the log file. Are we still using prompt 4?
It seems the Compilation and Execution are executted within one prompt. Is it correct? Figure 1 uses two prompts for the two tasks.
In Figure 1, once the prompt 3 gives a "X", it returns to the LLMs to generate a new unit test case. But in the log, it seems LLMs are fixing the problem, giving the error message instead of generating a new unit test.
I didn't notice any content related to prompt 6.

@LChenGit check dataset_generation/engine_F2C.py + data/F2C_dialogue_25K.json


Review & Modify User Profiles for Reporting

For Reporting, we'll likely have the existing user profiles we created for Registration - plus some more. What do we need to add to our registration user profiles?
Acceptance Criteria:

[x] Ideate other user groups that will interact with the reporting app that are not currently in our registration user profiles
[x] Create rough user profiles of additional users identified
[x] Pass profiles to scrum team for feedback
[x] Create a table to show how user profiles differ from each other
[x] Pass to PO for feedback
[x] Pass profiles to SME(s) for feedback

Goal of ticket:
Get a better idea of who will be interacting with reporting system

Hey team! Please add your planning poker estimate with Zenhub @nanyangpro @NicoleGovvy

Hey @patriciarussellCAS - would love your thoughts on when we'd consider this ticket 'done'

@jaimiebutton should we have these verified by Harnav before closing?

Hey @patriciarussellCAS , you can check out the updated profiles over on the Miro board. Will hopefully borrow Harnav's eyes for a final look over the next couple days!

Update - have gotten green light from Harnav. Have follow-up questions about:

The need for an Operational Representative profile
The need to have a few 'super users' who can change industry data if/as needed.

My thoughts: We could close this ticket and then create a new ticket for "potential additional users". I think we have enough info on the main user profiles to move ahead to next steps, but good to flag in another ticket that we may need to consider others as we learn more. I wouldn't want these questions to block us. Does this work for you @jaimiebutton ?


Betterlockscreen does not read configuration file

Is there an existing issue for this?

[X] I have searched the existing issues

Operating system
Arch Linux 6.1.7
Installation method
Package Manager (from OS)
Betterlockscreen & Dependency-Versions
- Betterlockscreen:4.0.4
- i3lock-color:2.13.c.4
- ImageMagick:7.1.0-57
- dunst :1.9.0
- feh :3.9.1

Bug description
I copied the configuration file as directed by the documentation. However the changes i made on the configuration file does not reflect. Betterlockscreen shows default layout.
Steps to reproduce
# ~/.config/betterlockscreenrc
# default options
display_on=0
span_image=false
lock_timeout=300
fx_list=(dim blur dimblur pixel dimpixel color)
dim_level=40
blur_level=1
pixel_scale=10,1000
solid_color=333333
wallpaper_cmd="nitrogen --restore"
quiet=false
# i3lockcolor_bin="i3lock-color" # Manually set command for i3lock-color
# default theme
loginbox=00000066
loginshadow=00000000
locktext=""
font="sans-serif"
ringcolor=ffffffff
insidecolor=00000000
separatorcolor=00000000
ringvercolor=ffffffff
insidevercolor=00000000
ringwrongcolor=ffffffff
insidewrongcolor=d23c3dff
timecolor=ffffffff
time_format="%H:%M"
greetercolor=ffffffff
layoutcolor=ffffffff
keyhlcolor=d23c3dff
bshlcolor=d23c3dff
verifcolor=ffffffff
wrongcolor=d23c3dff
modifcolor=d23c3dff
bgcolor=000000ff
Relevant log output
No response

See this PR
https://github.com/betterlockscreen/betterlockscreen/pull/381
Remove the "betterlockscreen" directory and just put the betterlockscreenrc in your .config

You have installed the latest release and referring to docs in the next-branch which is not released yet.


New account UI needs to be pushed to Transifex

Checklist

[X] I have used the search function to see if someone else has already submitted the same bug report.
[X] I will describe the problem with as much detail as possible.

App version
6.710
Where did you get the app from?
Other
Android version
12
Device model
No response
Steps to reproduce

Tap "Settings"
Tap "Add account"

Expected behavior
The UI should be shown in the user’s preferred language.
Actual behavior
UI is in English.
Logs
No response

We're working on it and I added it to our roadmap.

We changed our translation tool from Transifex to Weblate. The new accoutn ui translations are now available at: tb-android


bug: updated yarn timeout to avoid sporadic build errors

Yarn timeout of 30000 (aka 30 seconds) seems to result in sporadic build failures with an RPC timeout.  Affected yarn package varies.  I was getting in 1 in 3 failures using github webhooks and saw it once locally.
I set to 300000 (aka 5 minutes) and this resulted in over 40 builds with github webhooks.  In the spirit of reliability is more important than speed i think we should make this change.  I haven't tried a shorter value to find where the cut off is between good and bad.  Githib build times with this flag varied between ~30 minutes and ~hour.

Pull Request Test Coverage Report for Build 580062441

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 19.275%

Totals

Change from base Build 578909566:
0.0%

Covered Lines:
2009

Relevant Lines:
10694

💛  - Coveralls


[AIRFLOW-626] HTML Content does not show up when sending email with attachment

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-626

Per Apache guidelines you need to create a Jira issue.
Testing Done:

Unittests are required, if you do not include new unit tests please
specify why you think this is not required. We like to improve our
coverage so a non existing test is even a better reason to include one.

Reminders for contributors (REQUIRED!):

Your PR's title must reference an issue on
Airflow's JIRA.
For example, a PR called "[AIRFLOW-1] My Amazing PR" would close JIRA
issue #1. Please open a new issue if required!

For all PRs with UI changes, you must provide screenshots. If the UI changes are not obvious, either annotate the images or provide before/after screenshots.

Please squash your commits when possible and follow the How to write a good git commit message.
Summarized as follows:

Separate subject from body with a blank line
Limit the subject line to 50 characters
Do not end the subject line with a period
Use the imperative mood in the subject line (add, not adding)
Wrap the body at 72 characters
Use the body to explain what and why vs. how

Current coverage is 65.96% (diff: 66.66%)

Merging #1885 into master will increase coverage by 0.05%

@@             master      #1885   diff @@
==========================================
  Files           129        129
  Lines          9898       9899     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6524       6530     +6
+ Misses         3374       3369     -5
  Partials          0          0

Powered by Codecov. Last update 561b95a...7bb1db1


feature: adding a section describing how to actively generate and wor…

…k with a blog post from draft to published
PR Checklist
Please check if your PR fulfills the following requirements:

[ x] The commit message follows our guidelines: https://github.com/scullyio/scully/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ x] Other... Please describe:
Docs section describing blog post workflow

What is the current behavior?
No section describing this

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x ] No

Other information

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[irgen] Implement irgen::IRBuilder::SavedInsertionPointRAII.

This is ported from the SavedInsertionPointRAII at the SIL level. I thought that
I needed this to accomplish some of my recent work, but I was wrong. Still
seemed useful enough to upstream it.

@swift-ci smoke test


UX: Support to deploy FEVM contracts and instructions

I expect that the core of our initial users will want to deploy FEVM actors in subnets to reduce gas costs or have lower block times. Thus, support for FEVM contracts through the agent should become a first-class citizen. We should consider including a method to deploy FEVM contracts in a subnet, or at least interact with a contract in a specific subnet.
Once this is supported, it would be nice to include some instructions and getting started guide of "how to run your first DApp in a subnet"

First strokes of this implemented here: https://github.com/consensus-shipyard/ipc-agent/pull/200. Closing for now until new requests from users come.


[stdlib] add @noescape to withUnsafeMutablePointerToValue

What's in this pull request?

withUnsafeMutablePointerToValue's parameter needs @noescape. Without it, stdlib won't build after implementation of SE-0035. The offending call is here: https://github.com/apple/swift/blob/master/stdlib/public/core/ManagedBuffer.swift#L195
Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

This is needed when SE-0035 is implemented

@swift-ci Please test

This swiftpm build error has been happening to other PR builds 🤔

@swift-ci Please test Linux

@swift-ci Please test

Rebased to the better commits on master.

@gribozavr can I have another please test, please?

@swift-ci Please test

@swift-ci test


Can't get past this wine-staging error

Please can you explain for to get past this after running your script in Ubuntu 18.04.5 LTS?
The following packages have unmet dependencies:
 winehq-staging : Depends: wine-staging (= 6.14~bullseye-1)
E: Unable to correct problems, you have held broken packages.

I check this for you. :+1:

Okay I get the same error:

@bespokecomponents So I have found a solution!!! ^^

I will change my installation-script in the next time!


Can it scan vulnerabilities of other log conpoments, such Logback and java.util.logging.Logger?

Logback, another log conpoment, was disclosed a vulnerability in CVE-2021-42550.  So, can this tool scan vulnerabilities of other log conpoments, such Logback and java.util.logging.Logger?

cc @ddworken
The scanner only supports log4j. It looks for byte patterns in files to infer versions and usages, rather than depending on class names or a metadata file, so it wouldn't be free to add other versions of other packages.
We've discussed expanding this to a general scanning framework, so you'd only have to walk the filesystem once, but that's a different project and it's not clear how you'd keep the scope or scale manageable.
Going to close for now, since we're not planning on adding other packages for now.

OK, thanks!


Support writing to bigquery

We support postgres but we should support other databases

heya, planning to take this on, will you posted, thx!

hi, apologies for delay!  here's a PR to take a look at, thanks
https://github.com/joshstevens19/reth-indexer/pull/37


Don't print config file by default

Supress Using rusftmt config file... messages unless the --verbose flag is given.
If a user has a config file, then every time rusftfmt runs it will print the Using rustfmt config file...
I think it is a good practice that if nothing has gone wrong, by default, nothing is printed. This will mean that users with config files will be more likely to notice actual error/warning messages.

Thank you!

You are most welcome ^__^


Todo+ extension broken on Insiders

VSCode Version: 1.29.0-insider (1.29.0-insider) 1358e903716cf77711493770d63dde1ea178a73e
OS Version: v10.13.5

Steps to Reproduce:

Install the extension from the marketplace.
Notice that it's not working.
Open the devtools, there should be a message saying Activating extension 'fabiospampinato.vscode-todo-plus' failed: Cannot read property 'prototype' of undefined..

Needless to say that the same version works on the latest stable release (v1.28.0).

https://github.com/Microsoft/vscode/issues/60168


Refactor Reverse Distillation to match official code

Description
I was looking into why this version of Reverse Distillation shows a bit lower results compared to the results stated in the paper. I have compared this implementation with the official code. Seems like there are several issues:

Early stop causes training to stop too quickly and results are low, the paper states they have used 200 epochs without early stop, the same as the official code.
The batch size is 16, and beta2 is 0.999 both in the official code and the paper, so I have used these values as well.
In the OCBE class I have added the 4th conv layer, the same as the official code.
I have changed the default mode from "multiply" to "add", the same as in the original repository. It also makes more sense if we want to detect more defects. RD creates 3 anomaly maps for different scales by default, and by adding them we can detect defects that are on only one of these maps.
After all these changes results are still lower than needed, but the official code (not the paper), uses a slightly different loss. I have changed the loss to the one from the official repo and got the final results.
If somebody wants results that are even closer to the paper, they can use torchvision feature extractor instead of timm. I have added a comment in the code on this, but not implemented it because this seems that in general timm works better, except for Toothbrush in MVTec.

Changes

Describe the changes you made

[ ] Bug fix (non-breaking change which fixes an issue)
[x] Refactor (non-breaking change which refactors the code base)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist

Ensure that you followed the following

[ ] I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).
[ ] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas (If applicable)
[ ] I have made corresponding changes to the documentation (If applicable)
[ ] I have added tests that prove my fix is effective or that my feature works (If applicable)

@abc-125, thanks a lot for your contribution!

Thank you and all contributors for this amazing library :)

@samet-akcay Thank you for your comments and suggestions. I don't have time now unfortunately, but I will take a look at all of them during the weekend.


tests: Use a random test user when no env vars are present

This changes the test suit to register a random test user when the respective env vars are not provided, and deletes it after the tests complete. It still uses the RESINTEST_USERNAME/... env vars if present, since while developing this I ended up having the staging api rate limit me b/c of the extra user registrations that the suit did. As a result, for practical reasons, I think we should still keep them to not add friction when developing. This enables us to

run the sdk tests on resinCI before secrets get supported
reduce the configuration needed to run the sdk tests, making easier for contributors and other team members to run them

Removes the RESINTEST_REGISTER_* env vars and generated a random user as well.
Drops travis tests, as a way to reduce the load to the API. This shouldn't reduce the effectiveness of the CI's used, since resinCI will be testing the environment that travis was testing before.
Still uses appveyor since

it's nice to test the sdk on a windows machine as well
it is responsible for running the paid user tests, until resinCI adds support for secrets

Adds the required parameters to headless chrome so that it works on resinCI

Resolves: #582
Change-type: minor
See: https://www.flowdock.com/app/rulemotion/resin-frontend/threads/JIU7143SphYOgcVeQVh5n69eycK
See: resin-io/resin-concourse#248
See: https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-on-alpine
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>

@thgreasi We should make it clear that the tests are auto-generating a user, and what the user's email is. Do we know if these test users can be blacklisted from our analytics?

@LucianBuzzo

We should make it clear that the tests are auto-generating a user

I will add an extra note in the tests section of README.

Do we know if these test users can be blacklisted from our analytics?

Yea, everything @resin.io isn't counted in our analytics and after discussing this w/ @pimterry & @gelbal, it seems that it's fine
See: https://www.flowdock.com/app/rulemotion/resin-frontend/threads/JIU7143SphYOgcVeQVh5n69eycK

@thgreasi The test runner should log to stdout that its using an autogenerated user, otherwise a misconfiguration could go unnoticed quite easily.

@pimterry yea, that's my concern atm.
I also faced an issue configuring appveyor to use the paid account, but since the above implications still stand, I decided to postpone that for now and resolve once the reliability dust settles somehow.

@thgreasi What is the status of this PR? are we still concerned about reliability?

@dimitrisnl Whats the status of this PR? reviewing the comments it looks like it was nearly ready to go in November

Thanks for the review @LucianBuzzo :+1:
I will catchup with this later this week and request a re-review.
WRT the reliability issues, this was discussed in an arch call and we will now be limiting balena-ci to only run the tests on a single node version.

@balena-ci retest

It seems that this is blocked again, since we have decreased the allowed rate of signups.


[Bug]

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
1.2.1
What's Wrong?
UNIQUE表通过spark导入数据后，数据条数对不上、多次查询count数据条数不一。yarn、fe.log日志均无报错信息

建表语句：
create table xxxx()
UNIQUE KEY(`msisdn`)
DISTRIBUTED BY HASH(`msisdn`) BUCKETS 50;

导入语句：
LOAD LABEL spark_12
(
    DATA INFILE("hdfs://ns3/user/liujinguang_pt/test_load/big1/*")
    INTO TABLE migu_user_label_mix_total_test_2
    FORMAT AS "parquet"
)
WITH RESOURCE 'spark0'
(
    "spark.executor.memory" = "8g",
    "spark.shuffle.compress" = "true"
)
PROPERTIES
(
    "timeout" = "21600",
     "max_filter_ratio" = "0.5"
);

spark-shell 统计相同路径结果截图

What You Expected?
可以保证数据的正确性
How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

有建表语句吗？


anytype: 0.33.0 -> 0.33.3

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Apparently, anytype changed it's license, to albeit a weird one but redistributable (https://github.com/anyproto/anytype-ts/blob/main/LICENSE.md)


[Testing] Guides on managing users and roles

Guides on managing users [1] and roles [2] should be tested.
[1] https://is.docs.wso2.com/en/latest/guides/identity-lifecycles/manage-user-overview/
[2] https://is.docs.wso2.com/en/latest/guides/identity-lifecycles/manage-roles-overview/

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


storybook for vue error: addon-backgrounds

Bug or support request summary

Please specify which version of Storybook and optionally any affected addons that you're running

@storybook/vue : 3.4.10
@storybook/addon-backgrounds 3.4.10

"dependencies": {
"postcss-flexibility": "^2.0.0",
"vue": "^2.5.17"
},
"devDependencies": {
"@storybook/addon-actions": "^3.4.10",
"@storybook/addon-backgrounds": "^3.4.10",
"@storybook/addon-console": "^1.0.4",
"@storybook/addon-knobs": "^3.4.10",
"@storybook/addon-links": "^3.4.10",
"@storybook/addon-storysource": "^3.4.10",
"@storybook/addon-viewport": "^3.4.10",
"@storybook/addons": "^3.4.10",
"@storybook/vue": "^3.4.10",
"autoprefixer": "^7.1.2",
"babel-core": "^6.26.3",
"babel-eslint": "^8.2.1",
"babel-helper-vue-jsx-merge-props": "^2.0.3",
"babel-loader": "^7.1.1",
"babel-plugin-syntax-jsx": "^6.18.0",
"babel-plugin-transform-runtime": "^6.22.0",
"babel-plugin-transform-vue-jsx": "^3.5.0",
"babel-preset-env": "^1.3.2",
"babel-preset-stage-2": "^6.22.0",
"babel-preset-vue": "^2.0.2",
"chalk": "^2.0.1",
"copy-webpack-plugin": "^4.0.1",
"css-loader": "^0.28.0",
"eslint": "^4.15.0",
"eslint-config-standard": "^10.2.1",
"eslint-friendly-formatter": "^3.0.0",
"eslint-loader": "^1.7.1",
"eslint-plugin-import": "^2.7.0",
"eslint-plugin-node": "^5.2.0",
"eslint-plugin-promise": "^3.4.0",
"eslint-plugin-standard": "^3.0.1",
"eslint-plugin-vue": "^4.0.0",
"extract-text-webpack-plugin": "^3.0.0",
"file-loader": "^1.1.4",
"friendly-errors-webpack-plugin": "^1.6.1",
"html-webpack-plugin": "^2.30.1",
"node-notifier": "^5.1.2",
"optimize-css-assets-webpack-plugin": "^3.2.0",
"ora": "^1.2.0",
"portfinder": "^1.0.13",
"postcss-import": "^11.0.0",
"postcss-loader": "^2.0.8",
"postcss-url": "^7.2.1",
"rimraf": "^2.6.0",
"semver": "^5.3.0",
"shelljs": "^0.7.6",
"uglifyjs-webpack-plugin": "^1.1.1",
"url-loader": "^1.1.1",
"vue-loader": "^13.3.0",
"vue-style-loader": "^3.0.1",
"vue-template-compiler": "^2.5.2",
"webpack": "^3.6.0",
"webpack-bundle-analyzer": "^2.9.0",
"webpack-dev-server": "^2.9.1",
"webpack-merge": "^4.1.0"
}
import { storiesOf } from '@storybook/vue'
import { withBackgrounds } from '@storybook/addon-backgrounds'

storiesOf('Addon|Backgrounds', module)
  .addDecorator(
    withBackgrounds([
      { name: 'twitter', value: '#00aced' },
      { name: 'facebook', value: '#3b5998', default: true }])
  )
  .add('story 1', () => {
    const content = 'You should be able to switch backgrounds for this story'
    return {
      template: `<button>${content}</button>`
    }
  })
  .add('story 2', () => {
    const content = 'This one too!'
    return {
      template: `<button>${content}</button>`
    }
  })

👍

Hey @qianqian05723, it's basically as @katrynmc 	said. The documentation on the master branch is for the alpha release of Storybook packages, while you're using the 3.4 release. The documentation for that stable release is on another branch: https://github.com/storybooks/storybook/tree/release/3.4/addons/background, where as mentioned by @katrynmc 	the addon-backgrounds still made use of a default export instead of a named one. Note that the 3.4 version of backgrounds doesn't support vue.


Does it support Linux Architecture?

Yes, you could run cargo make and it will build only for Android targets.
You don't have to do any steps for iOS setup.


Changelog entries for "create"/"delete" and numeric values of 0 are not created

Hi,
currently if a numeric field is enabled to be change tracked, and a value of "0" is provided for that the field, it is available until the following point in the code, but will be skipped and not inserted into the changelog table.
https://github.com/cap-js/change-tracking/blob/e4cef968bd972064a84bd0daf58a70d34a8ef195/lib/change-log.js#L489
I expect the same thing will happen if "" is passed for a String field.
Regards,
Ludwig

Hello @stockbal
The fix has been merged into main branch, it will be available at next release. So I'll close this issue, if you have question you can reopen it.
Best Regards,
Wenjun


GSD Request

--- GSD JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v2.6.23 to before v4.14.261",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=5a6eb676d3bc4d7a6feab200a92437b62ad298da",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=292d2ac61fb0d9276a0f7b7ce4f50426f2a1c99f"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "5a6eb676d3bc4d7a6feab200a92437b62ad298da",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "292d2ac61fb0d9276a0f7b7ce4f50426f2a1c99f",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "Input: appletouch - initialize work before device registration\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.261 by commit 292d2ac61fb0d9276a0f7b7ce4f50426f2a1c99f, it was introduced in version v2.6.23 by commit 5a6eb676d3bc4d7a6feab200a92437b62ad298da. For more details please see the references link."
}
--- GSD JSON ---

This issue has been assigned GSD-2022-1000020


[R] improve more docstrings

This PR updates the docstrings of these (plotting) functions:

xgb.ggplot.R
xgb.importance.R
xgb.model.dt.tree.R
xgb.plot.deepness.R
xgb.plot.importance.R
xgb.plot.multi.trees.R
xgb.plot.shap.R
xgb.plot.tree.R

As such, it is the next step towards https://github.com/dmlc/xgboost/issues/9875.
Like in https://github.com/dmlc/xgboost/pull/9906, the changes include:

Switch to Markdown style in Roxygen
Fix inconsistencies
Improve language

There are no changes in the code itself.
Note there is one inconsistency that I have not fixed because I don't know what is better: An object of class "xgb.Booster" or an object of class xgb.Booster. I.e., how to highlight classes.

An object of class "xgb.Booster" or an object of class xgb.Booster. I.e., how to highlight classes.

The latter seems to fit markdown better?

That's a point.
"ggplot" e.g. doesn't use any highlighting:

#' ggplot() initializes a ggplot object.
#' @param object ggplot2 object to summarise

Similarly, {lubridate}:

#' Interval class objects have two slots:
#' @param x Object to be coerced to a duration

{dplyr} seems to avoid using class names, but here is an example that also uses no highlighting:

#' @param .data A data frame, data frame extension (e.g. a tibble), or a
#'   lazy data frame (e.g. from dbplyr or dtplyr). See Methods, below, for
#'   more details.

But there are also snippets in the Tidyverse docu that use backticks.
Hmm 😀

I hope the GitHub user param is okay with the ping. ;-)
I don't have a strong preference. For my personal choice, I would simply follow the tidyverse's convention.

Let's merge it to unblock the progress. ;-) Again, thank you for the nice work on the documents.

Note there is one inconsistency that I have not fixed because I don't know what is better: An object of class "xgb.Booster" or an object of class xgb.Booster. I.e., how to highlight classes.

For future references, let's stick to backticks.

Thanks! Backticks are fine 😀


Introduce Block trait

ref #9029
first, provide an abstraction of a consensus block.
once we have that we can slowly integrate this in the NodePrimitives

@mattsse, which methods do you want maintain in this trait?

this still needs some discussion so I'm marking it as such


Fix reporting disk free space

Goal
Skip reporting free space when getting file system attributes fails
Design
Changeset
Also disable debugger in test as it prevents tests from running in Xcode.
Tests
Unit test for iOS and tvOS using failure and macOS using success paths.
Review
Outstanding Questions

This pull request is ready for:

[X] Initial review of the intended approach, not yet feature complete
[ ] Structural review of the classes, functions, and properties modified
[X] Final review

[ ] The correct target branch has been selected (master for fixes, next for
features)

[ ] Consistency across platforms for structures or concepts added or modified

[ ] Consistency between the changeset and the goal stated above

[ ] Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?

@paulz Can you explain a bit more about what this change fixes, and why?

@paulz Can you explain a bit more about what this change fixes, and why?

Yes, here https://github.com/bugsnag/bugsnag-cocoa/pull/367/files#diff-511ffb2809f48997203cfba9e0630b9dR47 we no longer setting freeDisk space when error is not nil

Using the UserHome directory is more reliable as Documents are not accessible sometimes, see test failures on travis:  https://travis-ci.com/bugsnag/bugsnag-cocoa/jobs/208117433#L1456
as Documents directory is was available on iOS 10. To makes test pass more reliably for all versions I chose another base folder UserHome.


Di 583 v1.2.0

Changed so that reference genome and index are inputted in via one input as a .tar
Changed to accept more file extensions for the ref genome fasta file (".fasta" and ".fas" are now accepted in addition to ".fa")

This change is

DNA nexus job for successful run https://platform.dnanexus.com/projects/GbBy83Q411z6f01132j4v8ZF/monitor/job/GbFZPv8411z56KKP3B7pxxv5


Add public analytics in navbar

Adds the public analytics stats accessible in the navbar
Closes: #886

@lappemic. In the discussion we had, I thought about making it public so that it is not password protected. Linking it into the OpenSustain.tech navbar is not a good idea from my point of view because 99% of the people are not interested in it and they will think "Analytics" is about the analysis we do based on the open source projects. It also distracts people from the relevant content. Sorry for the misunderstanding.


Inconsistent state when disabling "error_pages"

Prerequisites

[x] I am running the latest version. (up upgrade)
[x] I searched to see if the issue already exists.
[x] I inspected the verbose debug output with the -v, --verbose flag.
[x] Are you an Up Pro subscriber?

Description
Despite
"error_pages": {
  "disable": true
},

the error page exists and the originally configured support_email still lingers around.
Steps to Reproduce
Originally I configured this
"error_pages": {
  "variables": {
    "support_email"<EMAIL_ADDRESS>  }
},

later I switched to
"error_pages": {
  "disable": true
},

Now much later I wanted to add a domain to production. I had to ctrl+c the up stack apply process because I hadn't configured e-mail yet and it was waiting for confirmation for the certificate. However, after killing it the deployment was broken (likely due to my user error) but I was greeted with

So even though I disabled the error pages weeks ago, the e-mail address still lingers somewhere and the error page was shown. How is that possible?
This was unfortunately the second time I was able to get up into an inconsistent state, but I didn't open an issue last time.

The error page config is updated along with the Lambda (since it's in the Up proxy code itself), may need to re-deploy instead of up stack apply, but if it the problem persists after that let me know!

Like I said I disabled the error pages weeks ago and they were disabled. Let me rephrase what this issue is about: why is the original support_email still stored somewhere? I'm just trying to understand where it came from.

It's only stored in the up.json, definitely should disappear if it was removed, I'll try and reproduce that

No luck yet, with 0.7.8-pro I tried deploying with it enabled, then again disabled a few times but it seems ok. Up's proxy just reads from ./up.json on disk, so as long as it's removed I don't know how it could possibly get back in

No luck yet, with 0.7.8-pro I tried deploying with it enabled, then again disabled a few times but it seems ok. Up's proxy just reads from ./up.json on disk, so as long as it's removed I don't know how it could possibly get back in

Thank, I'll see if I can reproduce it.

Up's proxy just reads from ./up.json on disk

If that's the case then the only explanation is that the inconsistent deploy I had somehow resulted in a (much) older deployment being invoked. I'm not sure how rollbacks etc work, does the old stuff still sit somewhere?

I was able to reproduce it:

Clone https://github.com/Prinzhorn/up-issue-735
Adjust "profile"
up
Open "/404" to see the error page with<EMAIL_ADDRESS>Disable error_pages
up
Open "/404" to see the default express error handler page "Cannot GET /404"
Add a domain to staging "stages": { "staging": { "domain": "example.com" } }
up stack plan
up stack apply
up stack status (something like "DnsZoneExampleCom: example.com (Service: AmazonRoute53; Status Code: 400; Error Code: InvalidDomainName")
Open any staging URL (e.g. "/404") and see the same page as in step 4

Any update on this? I've actually been experiencing a similar issue... However I don't think it's related to the error_pages=true flag in particular. I believe the lack of change in the error page is just a really obvious case of the app not updating properly since I've noticed my up deploys for new code aren't persisting. Cloudwatch logs say I'm running a commit hash from a week ago which is the hash from my initial up deploy.
Is up not the command for deploying new revisions?

I did some more playing and noticed that when I hit the execute-api url that up spits out it returns the desired output and cloudwatch gives me the most recent hash. Hitting my custom domain again returns the old codes output and cloudwatch has the old hash. I'm super new to aws/lambda so I'm no expert on this stuff but it feels like API gateway has something to do with it...
As a matter of fact from what it looks like API gateway is bound to my production environment.. whereas I believe up deploys updates to my staging environment. It looks like I have just found my problem :) up production promoted my code to prod and everything is good on my custom domain. Hopefully, this helps others. I guess I'm just having a tough time differentiating environments in a serverless architecture and just lambda in general.
Thanks so much for this awesome application! Makes my life 1m times easier.

closing this one for now, I've disabled error pages by default, but if this happens to anyone again we can reopen


Add CNVS & CUVS support

Adding following two version.
:chinese_new_version_simplified => "CNVS",
:chinese_union_version_simplified => "CUVS",

Thanks, @jimmy0017
I took over to maintain this gem. And thank God, I speak Chinese too <3


added for script to the js file

added git rebase to reconcile

added script file to feature/add-js and index.html to feature/add-html


FROM oracle/serverjre:8 is wrong.

Results in this error:
Step 1/10 : FROM oracle/serverjre:8
repository oracle/serverjre not found: does not exist or no pull access
There was an error building the image.

You have to create the image oracle/serverjre:8 based on Dockerfiles under the OracleJava folder.


Data projects

I think we need a new concept in the data tier - a project.
This will allow better collaboration between users.

A dataset belongs to a project (potentially to multiple projects).
A project can be personal or shared.
A personal project can be changed to being shared but not vice-versa.
Only an owner of a project can manage datasets in that project.
A shared project can have multiple owners. An owner can add another user as an owner.
All users can view and use data in a shared project (later we may add access control).
Datasets can be listed, filtered based on project.
Each user starts with a default personal project that has the same name as their username.
The API should list the available projects.

A consequence of this is that datasets are not really 'owned' by an individual user, they are 'owned' by the project.
Instead each dataset is 'created by' an individual user and as datasets are immutable (other than deleting them and updating metadata) then this will never change.
In terms of filtering, filtering by project is typically more useful than filtering by user.

A shared project can have multiple owners

Is there a concept of something between personal and public? i.e. a closed or restricted project? i.e. one that's not public but may have a number of users or owners that are allowed to use its data?.

Datasets can be listed, filtered based on project.

What impact does this have on the existing /data GET endpoint and the original MVP, which filters based on User and Label?
Is the User still necessary when it comes to searching for data?
Also what do Labels apply to? Can they be applied to all objects (i.e. User, Data and Project)? Or do they now just apply to projects?
Is this an extension to the MVP that we can deal with later or are projects part of the MVP (#20)?

Each user starts with a default personal project that has the same name as their username.

This is too complicated to implement in the backend autonomously. A user isn't known until they use an API method and to create a project automatically from the first invocation of any method will probably just result in messy code. If this requirement is needed then it needs to be a responsibility of the application layer, not the API. But, do we really need this? If a user needs a project then they can create one, with a name of their own choosing and we can avoid this special case.


Kafka input blocks after error: "kafka server: Unexpected (unknown?) server error"

Kafka input stops receiving messages after error: "Kafka group message recv error: kafka: error while consuming dp/0: kafka server: Unexpected (unknown?) server error."
The error is very infrequent and might not occur for couple of days.
Benthos version: v3.45.0

This is similar but likely unrelated to other Kafka issues (https://github.com/Jeffail/benthos/issues/953), the fact that the input stalls once this error has occurred seems to be common. Ideally we'd fix the root cause but it's likely somewhere deep in the protocols and sarama, so it's more likely we'll need to fix this by detecting the error at the input level and manually restarting the consumer.
A big help would be a reproducible example but I doubt we'll manage to create one.

Hey @dmoeff, I've added a new kafka_franz input and output https://github.com/Jeffail/benthos/commit/46af1ff1d17d73e580e878257469aefb639d5d49, these use a different kafka client implementation (https://github.com/twmb/franz-go), would you be willing to try it out and report whether you still get this issue?

Thanks @Jeffail , I am going run a test today and will let you know. It might take at least 2 - 3 weeks to prove that it works.

Hi @Jeffail , I was able to connect kafka_franz input to an Event Hub, but it is is unable to receive messages.
{"@timestamp":"2022-01-14T21:22:13Z","@service":"transformer","component":"transformer.input.broker.inputs.0","level":"INFO","message":"Receiving messages from Kafka topics: [demo]"}

@dmoeff thanks for giving it a try, which version of benthos did you run? I pushed an update today that should reduce the likelihood of stalls but if you didn't see any messages at all then it's likely something else. I'll put a release out this coming week that'll add more tracing logs and put together a list of diagnostic gathering steps.


Remove the APIs that were deprecated for removal in 4.2

Motivation:
These APIs were deprecated with a message saying they would disappear in 4.2.
Modification:
Remove the APIs as promised.
All except ResourceLeakException were internal APIs.
All deprecated APIs that were NOT specifically promised to be removed in 4.2 have been left alone.
Result:
Slightly fewer deprecated APIs.

Maybe we should just not do it to minimize the risk as @idelpivnitskiy mentioned. It does not harm us a lot to keep these around a bit more

Effort of going back and forth seems higher to me (plus it affects relationships with customers) vs just keeping API as-is.

Let's close this.


Source Standards Update

Changes are mostly chores:

All source file names are now in kebab case
The webhook event is now kebab instead of snake case
The workers server now follows the directory structure of all other servers.

Due to this most of the files changed due to references to other files that changed.

Looking good


implement Statement.reader

I took a stab at #64
fix #64
Unfortunately, I could not test locally as my disk is too full for another rust toolchain :upside_down_face:

Hey @fehnomenal, sorry for the delay and thanks for the contribution! As it turned out, this was needed for Knex when libsql package is used with the better-sqlite3 dialect.


[SPARK-34200][SQL] Ambiguous column reference should consider attribute availability

What changes were proposed in this pull request?

This is a long-standing bug that exists since we have the ambiguous self-join check. A column reference is not ambiguous if it can only come from one join side (e.g. the other side has a project to only pick a few columns). An example is
Join(b#1 = 3)
  TableScan(t, [a#0, b#1])
  Project(a#2)
    TableScan(t, [a#2, b#3])

It's a self-join, but b#1 is not ambiguous because it can't come from the right side, which only has column a.
Why are the changes needed?

to not fail valid self-join queries.
Does this PR introduce any user-facing change?

yea as a bug fix
How was this patch tested?

a new test

cc @Ngone51 @viirya @maropu

cc @Ngone51 @viirya @maropu

Test build #134353 has started for PR 31287 at commit 2c34ade.

Test build #134353 has started for PR 31287 at commit 2c34ade.

BTW, the Join example in the PR description is not aligned properly.

BTW, the Join example in the PR description is not aligned properly.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38939/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38939/

Ah actually this fixes a 3.1 regression. Previously we merged a bug fix: https://github.com/apache/spark/pull/30488 , which makes sure ambiguous self-join check is always applied. That said, in 3.0 the ambiguous self-join check is skipped under some cases, which hides the bug this PR is fixing.
For the query below, it works in 3.0, but fails in 3.1. After this PR, it works again.
sql("create table t1 using json as select 1 key, 1 value")
sql("create table t2 using json as select 1 key, 2 value")
val t1 = spark.table("t1")
val t2 = spark.table("t2")
val t3 = t1.join(t2, t1("key") === t2("key")).select(t1("value"))
t1.join(t3, t1("key") > 1)

cc @HyukjinKwon @dongjoon-hyun I think it's a 3.1.1 blocker.

Ah actually this fixes a 3.1 regression. Previously we merged a bug fix: https://github.com/apache/spark/pull/30488 , which makes sure ambiguous self-join check is always applied. That said, in 3.0 the ambiguous self-join check is skipped under some cases, which hides the bug this PR is fixing.
For the query below, it works in 3.0, but fails in 3.1. After this PR, it works again.
sql("create table t1 using json as select 1 key, 1 value")
sql("create table t2 using json as select 1 key, 2 value")
val t1 = spark.table("t1")
val t2 = spark.table("t2")
val t3 = t1.join(t2, t1("key") === t2("key")).select(t1("value"))
t1.join(t3, t1("key") > 1)

cc @HyukjinKwon @dongjoon-hyun I think it's a 3.1.1 blocker.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38939/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38939/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38939/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38939/

Test build #134353 has finished for PR 31287 at commit 2c34ade.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #134353 has finished for PR 31287 at commit 2c34ade.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134353/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134353/

Merged to master, branch-3.1 and branch-3.0.

Merged to master, branch-3.1 and branch-3.0.


Top N placeholder doesn't update positions

Hello!
I'm running into an issue with the PlayerStats expansion where PlaceholderAPI top N positions aren't updating. I've attached an example of it being out of sync.
I'm using this placeholder for the rankings (1-8):
%playerstats_ top: 1, play_one_minute%
A server restart fixes positions but isn't really viable as a solution going forward. Anything I can do to fix this?
Thanks!

Hello!
Which hologram mod are you using? Does that one have refresh/update settings? And what setting are you using for the time-statistic update interval in the PlayerStats section of the PlaceholderAPI config?

Hi!
I'm using DecentHolograms and have the default 20 tick update interval. Here's the relevant config for that:
`
display-range: 48
Default Hologram update range in blocks.
update-range: 48
Default Hologram update interval in ticks.
update-interval: 20
Maximum amount of cached pattern processing results
Do not change if you do not know what it means
Increasing this number will result in higher memory usage
Range: 5 - 10000
Default: 500
lru-cache-size: 500
`
My PlayerStats PlaceholderAPI settings are to update every second as well:
  playerstats:     update_interval_in_seconds:       distance_statistics: 1       time_statistics: 1

Very odd that it doesn't update!
Is it only the time statistics that don't update, or also the distance statistics and general ones?
If you check the placeholder with /papi parse, does that give the correct values, or have the same issue?
And which Minecraft version and server type are you using?

Sorry for the late response!
It's only the time statistic that doesn't update quickly. I'm also using Damage Dealt which updates normally.
However, it seems that Time Played does update, just takes longer than normal. I'm okay with this, I may have some interval setting off somewhere but for now I'll close the issue!
Thanks regardless.

No worries!
I'm happy to hear the problem doesn't happen with all statistics, and that it still somewhat updates.
Feel free to let me know if it misbehaves more in the future, I can always look into it then!


VectorSource initialized with an existing Collection should be properly disposed

Is your feature request related to a problem? Please describe.
For now, VectorSource can be initialized with a Collection, and changes will be sync by adding listeners on this Collection. However, those listeners can not be removed and might cause memory leaking.
Describe the solution you'd like
Remove those listeners mentioned above in dispose(), which can be called by developers manually.

Before finishing my review of #14467, may I ask what exactly your use case is? I'm trying to figure out if exposing dispose() (which we usually try to avoid) is the appropriate fix, or if it would be better to expose a new setFeaturesCollection() method.

Before finishing my review of #14467, may I ask what exactly your use case is? I'm trying to figure out if exposing dispose() (which we usually try to avoid) is the appropriate fix, or if it would be better to expose a new setFeaturesCollection() method.

I'm creating an editor based on OpenLayer. In my case, I need a temp layer to render a FeatureCollection, the layer and the VectorSource will be disposed later.
IMO dispose() is more appropriate as it provide a more accurate semantics. It indicates the object can be marked as 'Garbage Collect Safe' after calling this method, and that is what current implementation of dispose() is actually doing.

JavaScript garbage collects anything that is not referenced anywhere any more. So as soon as you remove any reference to your feature collection, it will be garbage collected if the source is also not referenced anywhere any more.
The reason why I'm hesitant to add dispose() for ol/source/Vector to the API is that we're planning to get rid of Collection anyway at some point, and ol/source/Vector does not need dispose() for any other use case than the one you mentioned. So if you want to continue with that approach, please add a more verbose prose description to dispose() that explains this only use case where it is needed. Also, please look at ol/source/Raster for the correct way to override dispose() - you'll be overriding disposeInternal(), and only add an API marker for dispose.

Thanks for your detailed explanation.
I rethink about the problem I met, it is caused by applying the same FeatureCollection to multiple temporary VectorSource.
That's because I treated VectorSource as a 'heavier' object. After reading your explanation. I realize using VectorSource directly will better meet my use case.
I agree with your concerns, and I understand for now it's not necessary to apply this patch.


Use touchFile on Windows as GHCs touchy is not available

As eta doesn't supply a touchy equivalent as GHC does. This path sidesteps the issue by doing the touch in eta. This is a very unclean solution. If the user supplies a custom path to touch or touchy with -pgm_T the path gets ignored on Windows.

 I don't mind if you do away withSysTools.touch completely - could you take a stab at that?

@rahulmutt You mean completly removing SysTools.touch and changing the implementation of touchObjectFile?

Yes exactly.

Yes, I can do that immediately


Feature Request: Double click on component in view to source; place

Thanks so much for the amazing application; I've been generating html boms in all my projects as part of my SOP for a while now.
During the assembly process I've been going through the components individually and marking them off as sourced and/or placed; this usually involves scrolling on the PCB view to the component in question, edging my mouse back to BOM list, making sure I can get all the way to the sourced/placed column without losing where I am, and clicking the checkboxes. The mark when checked option for models on the PCB view really helps!
I'm wondering if it is feasible or desirable to have a feature where multi clicking the component will auto check the boxes and update the PCB marking. This could be as follows:

a single click scrolls the BOM to the correct component and highlights the row (the current behavior)
a double click marks the part as sourced,
and a triple click marks the part as placed.

You could also instead have double clicks cycle between three states: (unsourced, unplaced; sourced, unplaced; sourced, placed).
Hopefully this wishlist feature is something useful for others as well as it would definitely speed up my current workflow and reduce the mental effort of making sure I'm updating the right component (instead of losing track and having to repeat the process to make sure).
Regardless, thanks so much for the team's work on this!

I don't want to make any features that rely on what checkboxes are named or how many there are because they are meant to be user data. The only somewhat "special" checkbox is "placed" and it has it's own shortcut 'n' to step through.
Also it does not make sense to me to use the pcb rendering to mark the "sourced" checkbox. Sourcing is a process where you usually look at component list, either in bom or in your inventory system or on purchasing site. You don't typically look at the pcb and think "I want to buy the component that goes here". You do want to mark it as "placed" though so you can click it and press 'n' or click checkbox.

edging my mouse back to BOM list, making sure I can get all the way to the sourced/placed column without losing where I am, and clicking the checkboxes

The 'n' shortcut should help here as well as dragging the checkbox column to the right, closer to rendering.

Thanks for the N shortcut tip, this is sufficient for me. Regarding sourcing, you are correct; I'm typically looking at my physical Mouser ordering listing while checking these off.


Create real-world test

Verkle trees behave different than Hexary Merkle trees in terms of performance (both CPU and RAM).
We need to tune the performance to match our use cases, by choosing appropriate data structures and algorithms.
For that, it would be helpful to use real-world samples of access to the Merkle tree, and translate them to access to the Verkle tree.
Todo:

Take ~10000 consecutive blocks of ethereum (~1 day)
Execute the transactions and contracts
Whenever a transaction/contract depends on state from before our block range, dump that state into a binary file; this will be the "setup"
Whenever a transaction/contract reads or writes data, dump these operations into a binary file; this will be the "execution"
The data format should be translated from the merkle kvp structure to verkle kvp structure
Write this data in a dense binary format and push to repository (should be <50mb, or use less blocks)
The "setup" data can be used to pre-populate the sample tree

This will provide a real-world sample of how the full tree will look like
Compute some stats:

How many nodes have a single child?
What's the median number of children per node?
Make a histogram of # of children for internal nodes, as well as values leaf nodes

This will help understand what RAM optimizations can be done

The "execution" data can be used to:

Create a realistic benchmark, which we can use to asses how a certain change to the code affects performance
Profile the code to tune performance

Summary of discussion done in discord -

This is more of a performance analysis, and since right now we are in the early stage of implementation, this is low priority/ enhancement.

Ignacio (jsign) has done a similar analysis in the past here. The difference is we would like to go one step further and generate files containing the access operations done to the verkle trie, so we can replay it at ease.

Gballet also did something similar in this PR

After talking with Ignacio he found this useful and said that this could be a great quick-"e2e" test. Also he said "For geth tests and optimizations, we've been replaying some chain history which clearly is heavier... but we re interested in testing the whole thing: a) The state migration using the overlay tree method  (thus having dual tree access + extra load migrating state), 2) After the transition finishes, keep going with the VKT with the full state (which I think is what you're trying to focus). Of course as you imagine the setup for that is not light enough to be pushed to your gh repo... so I think that above is good."


Alternative Download

Would you consider making your great FOSS app available outside the walled garden of Google Play – e.g. by attaching the (signed) APK file to your tags/releases, or bringing the app to F-Droid? That way, poor Huawei users and others without Play Store access could use it as well :smiley:
Thanks in advance!

Thanks for accepting my request! Is there any ETA? I see there was a new release tagged today, but again without an APK attached (with a signed APK available at the tag, I could take your app into my repo until you're ready for "F-Droid proper").

Happy holidays! Just a little heads-up and looking if there might be something for my stockings? :santa: :gift: :smiley:

Yes, once scheduled notification feature is done I will work on adding APK with every GitHub releases. At this point, automating the releases to F-Droid seems like a bit of work, so for now, I will stick with GitHub releases.

Thanks! As soon as APKs are available at tags here, I can add your app to my repo (as pointed out before). Automating releases to F-Droid wouldn't even require an APK to be available (just the tag, with the tag name corresponding to versionName – a condition that's already met: tag v1.1.1 has versionName 1.1.1, which meets the default pattern of v%v (i.e. v<versionName>).
Well, let's see. Once your APK is available and in my repo, we see what my library scanner says. If that indicates it should be good to go to F-Droid, I gladly help you with that if you want (disclosure: I'm one of the F-Droid maintainers).

I have released v1.2.0 of Pinnit and tags have been updated accordingly and added the release APK as well. Feel free to add my app to the F-Droid repo. Closing this issue for now.

I have released v1.2.0 of Pinnit and tags have been updated accordingly and added the release APK as well. Feel free to add my app to the F-Droid repo. Closing this issue for now.

Thanks! Will show up here in about 3.5h (around 7:45 CET/UTC+1) with the next sync. Looks good, and should be meeting F-Droid's strict inclusion criteria as far as I can see. So if you wish your app show up in that (more prestiguous) repo, be welcome to file a Request for Packaging :smiley:
Until then, if you want to include a badge next to Play Store's, I have this one for you to link to your app in my repo :smile:

[](https://apt.izzysoft.de/fdroid/index/apk/dev.sasikanth.pinnit)

Thanks! Will show up here in about 3.5h (around 7:45 CET/UTC+1) with the next sync. Looks good, and should be meeting F-Droid's strict inclusion criteria as far as I can see. So if you wish your app show up in that (more prestiguous) repo, be welcome to file a Request for Packaging :smiley:
Until then, if you want to include a badge next to Play Store's, I have this one for you to link to your app in my repo :smile:

[](https://apt.izzysoft.de/fdroid/index/apk/dev.sasikanth.pinnit)


ParseError with scss inside component

There is a problem during build with optimizeCss, when the scss is inside a component's style tag.
Here is the error:
[plugin-optimize-css] Selector is expected
file: /home/jeremy/app/front/src/lib/Uploads.svelte
125:   @import '../styles/vars';
126:
127:   $position: fixed;
       ^
128:
129:   .container {
error during build:
ParseError: Selector is expected
    at error (file:///home/jeremy/app/node_modules/.pnpm/carbon-preprocess-svelte@0.6.0_sass@1.45.1+svelte@3.44.3/node_modules/carbon-preprocess-svelte/dist/index.mjs:19062:18)

It does not recognize nested styles either.
Here is my relevant vite config:
import { defineConfig } from 'vite'
import { svelte } from '@sveltejs/vite-plugin-svelte'
import sveltePreprocess from 'svelte-preprocess'
import viteCompression from 'vite-plugin-compression'
import { optimizeCss, optimizeImports } from 'carbon-preprocess-svelte'

export default defineConfig(({ mode }) => {
	const prod = mode === 'production'
	return {
		plugins: [
			svelte({
				preprocess: [sveltePreprocess({ scss: true }), optimizeImports()],
				emitCss: prod,
			}),
			prod && optimizeCss(),
			prod && viteCompression({ algorithm: 'brotliCompress', ext: '.br' }),
			prod && viteCompression({ algorithm: 'gzip' }),
		],
		build: {
			minify: prod,
		}
	}
})

I think the plugins order is allright.
I do not have any problem during development as my style tags does have lang="scss" for proper preprocessing.
The interesting thing is that the build works fine when the scss is external:
<style lang="scss" src="./container.scss"></style>

Does anybody have a clue ?

Same issue here using SvelteKit. I thought it had something to do with node-sass, sass or svelte-preprocess. But couldn’t nail it down yet.
`
import adapter from '@sveltejs/adapter-auto';
import { optimizeImports, optimizeCss, elements } from 'carbon-preprocess-svelte';
import path from 'path';
import sveltePreprocess from 'svelte-preprocess';
import autoprefixer from 'autoprefixer';
const production = process.env.NODE_ENV === 'production';
const __dirname = path.resolve();
/** @type {import('@sveltejs/kit').Config} */
const config = {
preprocess: [
optimizeImports(),
elements(),
sveltePreprocess({
scss: {
prependData: @use "${path.resolve(__dirname,'src/variables.scss')}" as *;,
},
postcss: {
plugins: [
autoprefixer()
]
}
})
],
kit: {
adapter: adapter(),
vite: {
build: {
sourcemap: !production,
minify: production
},
		optimizeDeps: {
			include: ['@carbon/charts'],
			exclude: ['@carbon/telemetry']
		},

		ssr: {
			noExternal: [production && '@carbon/charts'].filter(Boolean)
		},

		css: {
			preprocessorOptions: {
				scss: {
					additionalData: `@use "${path.resolve(__dirname,'src/variables.scss')}" as *;`,
				}
			}
		}
	}
}

};
export default config;
`

Commenting for posterity. This library was rewritten in v0.11, but many concepts still apply.
optimizeImports preprocessor
optimizeImports does not perform preprocessing. Additional preprocessing (e.g., TypeScript) should be performed first.
For example, vitePreprocess should precede optimizeImports.
// svelte.config.js
import adapter from "@sveltejs/adapter-static";
import { vitePreprocess } from "@sveltejs/vite-plugin-svelte";
import { optimizeImports } from "carbon-preprocess-svelte";

/** @type {import('@sveltejs/kit').Config} */
const config = {
  preprocess: [
    // Preprocessors are run in sequence.
    // If using TypeScript, the code must be transpiled first.
    vitePreprocess(),
    optimizeImports(),
  ],
  kit: {
    adapter: adapter(),
  },
};

optimizeCss plugin
The optimizeCss plugin was rewritten from scratch. It's sole responsibility is to avoid false positives. This means it's slightly less aggressive in what unused styles it can remove. However, accuracy must be higher.
It was also rewritten as a Vite plugin (meaning it's Rollup compatible) as well as Webpack plugin.
Docs on using it are here: https://github.com/carbon-design-system/carbon-preprocess-svelte?tab=readme-ov-file#optimizecss


Update README.md

NOTE: A similar PR may already be submitted! Please search among the Pull request before creating one.
Types of Changes
What types of changes does your PR introduce? Put an x in all boxes that apply

[x] New addition to list
[ ] Fixing bug in existing item in list
[ ] Removing item from list
[ ] Changing structure (organization) of list

Proposed Changes
Describe each of your changes here to communicate to the maintainers why we should accept this pull request.

If you're adding something to the list, be sure to explain why it should be added.
If you're fixing a bug or resolving a feature request, be sure to link to that issue.

PR Checklist
Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the CONTRIBUTING guide
[x] I have explained why this PR is important
[ ] I have added necessary documentation (if appropriate)

Further Comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

I added bartender since that's the one I use. I thought it was important since I find it to be a pretty great menu bar app

Good by me. Thanks @Umar-M-Haroon


WHERE IN multiple columns

Add WHERE IN method for multiple columns:

var query = squel.select().whereIn('pk1, pk2', [[1, 0], [1, 1]]);

-> WHERE (pk1,pk2) IN ((1, 0),(1,1))

You can just do this:
squel.select().from('test').where('(pk1, pk2) IN (?,?)', [1, 0], [1, 1]);
Outputs: 'SELECT * FROM test WHERE ((pk1, pk2) IN ((1, 0),(1, 1)))'

If I define the number of 'pk' in the loop then I will have to use
var pk = ['pk1', 'pk2', 'pk3'];
var values = [[1,4],[2,5],[3,6]];
var whereInQuery = '(' + pk + ') IN (' +
    pk.map(function () {return '?';}) +
  ')';
squel.select().from('test').where.apply(null, [whereInQuery].concat(values));

It seems to me that this looks better:
var pk = ['pk1', 'pk2', 'pk3'];
var values = [[1,4],[2,5],[3,6]];
squel.select().from('test').whereIn(pk.join(), values);

Maybe it will be convenient to make the conversion to a string when the function is expecting input separated by commas:
squel.select().from('test').whereIn(pk, values);

Not a bad idea, but I'm convinced that this warrants the addition of a new whereIn() function to the core library. Perhaps you can just extend the "where" block to do this.


fix windows.h raylib.h collisions

@Anaskorichi999 looks good to me! Thank you for your contribution!


Entity extraction (using Duckling) not working when changing the order of the sentence

Rasa version: 0.13.5
Python version: 3.6.8
Operating system (windows, osx, ...): macOS Mojave
Issue:
I am trying to extract some entity of the 'time' type using duckling, it is working with sentences like:
"Find me 2 artists born in Vienna between 1700 and 1800"
But if I change the sentence to:
"Find me 2 artists born between 1700 and 1800 in Vienna"
the duckling extractor won't recognize the 'time' entity and will completely skip it. And as I said before, it works when having the date in the end of the sentence. I added the training data to identify it, but it just doesn't get extracted.
Is there a way to fix this?
Content of configuration file (config.yml):
language: "en"
pipeline:
- name: "nlp_spacy"
- name: "tokenizer_spacy"
- name: "intent_entity_featurizer_regex"
- name: "intent_featurizer_spacy"
- name: "ner_duckling_http"
  url: http://localhost:8000
  dimensions: ["time", "number"]
  locale: 'en_US'
  timezone: "Europe/Paris"
- name: "ner_crf"
- name: "ner_spacy"
- name: "ner_synonyms"
- name: "intent_classifier_sklearn"

I'm afraid not, Facebook maintains duckling and it's a rule based system which doesn't rely on any training data. I'd suggest you open an issue here.
Can I ask which docker image you're using for duckling?

I'm running the rasa/duckling latest image. Ok, when I send the same phrase to the duckling container directly it recognizes the entity, as a dimension of distance, which is not what I expect, but it gets recognized. While when going through rasa it doesn't extracts anything.

I assume that's because you don't have distance listed in the dimensions you want to extract in your config?

Oh, that's right, I added the distance dimension and now it's working, but still not as expected. I will create an issue for this in the duckling site. Thank you.

cool, will close this then :)


Validate sample in separate step from processing

Motivation and Context
We want to ask the user if they want to proceed with a sample file if some of the rows have failed validation, or cancel the job.

[x] Context Index has been kept up to date

What has changed
Validation now happens after staging of a sample file, but then the support tool waits for the user to either process the file or cancel the job.
How to test?
ATs should all pass as before.
Manual scenarios to check are:

Check that sample pauses after validation
Check that sample loads after clicking "Process" and rows are deleted
Check that job rows are deleted after clicking "Cancel"
Check that sample with bad header is total failure, and all rows deleted
Check that sample with mismatched number of columns in a row is total failure, and all rows deleted
Check that sample with one row failing validation goes to "validated with errors" status, and good rows can be processed
Check that sample with one row failing validation goes to "validated with errors" status, can be cancelled, and good rows are deleted

Links
Trello: https://trello.com/c/hZkfqvD9

 Modify Support Tool to stage/verify in one step, then load sample as second step initiated by user (21)


Move pin definition to module init

Move pins definitions out of servo and stepper, pass them in options.

Coverage increased (+11.1%) to 100.0% when pulling 0b1cec039ab094907d68e4d86f3bdd0d5f88bab2 on init into ccdb27300f251175cc9c8c8cf2bffbd85b966d43 on master.


Decouple WorldCreator

now works only if modeldifference module is registered else throw updateshema exception

Closing issue for age. Feel free to reopen it at any time.
. Thank you for your contribution.


Replace packr with native go:embed

How to categorize this PR?

/area dev-productivity
/kind cleanup
/platform equinix-metal
What this PR does / why we need it:
Meanwhile, we have updated to Golang 1.16 and can use the native go:embed feature which allows us to eliminate packr.
Release note:

NONE

/invite @kon-angelo


Open ssl 1 1 1 stable

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

This looks like a mistake.


Access special token params for tiktoken

If a text being tokenizer by tiktoken contains a special token like <|endoftext|>, we will see the error:
ValueError: Encountered text corresponding to disallowed special token '<|endoftext|>'.
If you want this text to be encoded as a special token, pass it to `allowed_special`, e.g. `allowed_special={'<|endoftext|>', ...}`.
If you want this text to be encoded as normal text, disable the check for this token by passing `disallowed_special=(enc.special_tokens_set - {'<|endoftext|>'})`.
To disable this check for all special tokens, pass `disallowed_special=()`.

But we cannot access the disallowed_special or allowed_special params via langchain.
Here's a colab demoing the above: https://colab.research.google.com/drive/18S7AH2K64vymFA-Obeqp_O-1LwFn3i3Q?usp=sharing
Submitting a PR

done!

still not working.....

same here, i am getting a TypeError:
TypeError: split_text() got an unexpected keyword argument 'disallowed_special'
my code:
llm = OpenAI(temperature=0)
text_splitter = TokenTextSplitter.from_tiktoken_encoder(
    encoding_name='gpt2',
    chunk_size=300,
    chunk_overlap=50,
)
texts = text_splitter.split_text(documents, disallowed_special=())

From: https://github.com/shashnkvats/PdfPal/issues/1#issuecomment-1531905749
"Adding disallowed_special=() parameter to OpenAIEmbeddings() function fixes it."
This ended up working for me :D

"OpenAIEmbeddings()" is to be replaced with "OpenAIEmbeddings(disallowed_special=())"

text_splitter = CharacterTextSplitter.from_tiktoken_encoder(         encoding_name="cl100k_base", chunk_size=500, chunk_overlap=0, disallowed_special=()     )
This works for me.


Confusing versioning of the project

I am just trying to prepare Fedora binary package, because so far only python3-pigpio package exists, but no daemon.
However, I found multiple different versions scattered across the git repository. One is in setup.py, but it is not related to recent tag. Another in pigpioConfigVersion.cmake. It is not clear to me, whether official project version is 0.78, 1.78 or just 78.
Is the version just 78, as hinted by git tag? Could it be autogenerated from single source and to the same value after release? Python setup.py from cmake/setup.py.in, which contains in develop 1.44. And ./pigpiod -V returns event something different: 7802.

I hear your pain.    I would treat the whole archive as a suite and consider it all version 78 (as of now).  In practice different versions of components are interoperable, they will just report errors if you try to use a later feature.

In responding to an issue/request I 'synchronized' the minor number of the python module version with the core pigpio.c, ie 78.  IIRC this was done because of confusion about with versions supported 'padded' waves.  Going forward I was planning to keep this number synchronized but I'm open to other suggestions.


[random issue] Coin Control window conceals the lowest transaction by default

Problem:
The blue bar at the bottom of the Coin Control window obscures the last address on the list.
This is a problem when you have a longer list of addresses more transactions than the default window displays. There is a scrollbar on the right side of the panel, but scrolling down does not reveal the last address unless you expand the window manually.
The result can be that it looks like you are missing an entire address from your wallet. Of course, you can find it by reversing the sort functions, but the display problem is not obvious, so the solution is not obvious either.
Examples:
The first screenshot below shows the address ending with "kkg". It appears to be the last address on the list, but it is not. You can also see the blue scrollbar on the right. You would think you could adjust it by dragging it down, but even when dragged down to the lowest point, you still can't see the last address.

This second screenshot shows the same window after manual expansion. If I drag the window size larger, there's no scrollbar on the right, and there's no blue bar blocking the view of the last address. You can see that below the address ending in "kkg" there is another address, as well.

Suggested solution:
Get rid of the blue bar at the bottom, or retain it as a border below the last address. It may be necessary to make adjustments to the scroll bar function, as well.
Note:
The problem exist in Coin Control on both the Privacy Tab and the Send Tab.
Software Version:
Ion Core version v3.1.01 (64-bit)
downloaded from https://github.com/ioncoincore/ion/releases
Running on Mac OS 10.14

@mdpfeiffer  Thank you for your submission one of your Devs will be looking into this issue


Remove unnecessary Dilithium benchmarks

We don't track for Dilithium the short secret key size (96 bytes, see Specification, section 3.1). We should either remove the benchmarks with short_sk or add the additional parameter sets.

@dingens suggested that we remove the benchmarks and add the short key sizes to the corresponding parameter sets as comment.

I'd rather add the missing parameter sets, since it gives an interesting time-space tradeoff.

This is a general issue not only about dilithium.
The main problem is that we have somewhat over-simplified our data model by storing the secret key size as a property of the parameter set, when in fact it can vary between implementations. The comment way I suggested is how we "solved" this for most of the other schemes.
I don't think adding a separate parameter set is a good way. We'd have a ton of additional parameter sets that are not really separate parameter sets because they are interoperable.
I'd stick with the simple one KAT is one paramset rule. I tend to think secret key size is not among the important factors for selecting a scheme (memory usage is more critical and we don't store that a lot currently), so it's enough to just store some well balanced sk size (as chosen by the authors) and go with that.
If we want to store more data but without changing the scheme too much*, we could add field minimum_sk and times/{sign,dec}_from_minimum.
(* which would mean a) (cleanest) adding it to a new object which depends on impl and paramset, or b) (a little redundant but avoiding a new object) adding it to bench). That'd complicate quite some things so I don't think that's worth it.