PackageReference support in VS 2017

Projects in VS 2017 no longer use ps1 scripts for install/uninstall. They are not called.
Instead, a package can provide a \build\<tfm>\packagename.targets file that will automatically get imported. In this case, it'd be \build\net20\DllExport.targets.

today I checked PackageReference and...

a package can provide a \build<tfm>\packagename.targets file that will automatically get imported

nope, no any .targets if we use PackageReference, just references:
  <ItemGroup>
    <PackageReference Include="DllExport">
      <Version>0.0.1</Version>
    </PackageReference>
  </ItemGroup>

However if we'll use Packages.config it will:

  <Import Project="..\packages\DllExport.1.5.2\build\net20\DllExport.targets" Condition="Exists('..\packages\DllExport.1.5.2\build\net20\DllExport.targets')" />
  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
    <PropertyGroup>
      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
    </PropertyGroup>
    <Error Condition="!Exists('..\packages\DllExport.1.5.2\build\net20\DllExport.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\DllExport.1.5.2\build\net20\DllExport.targets'))" />
  </Target>

I already used \build feature in my other packages like old regXwild
\build\native\regXwild.targets
\build\net40\regXwild.targets

that package can be installed for both type of projects at the same time for .NET CLR and native (unmanaged) like C++ etc.
but for PackageReference I don't know exactly about support - is it really supported ? If you talk about it above ...
where to look documentation for \build\... .targets + PackageReference feature ?

hmm, PackageReference uses global cache for each received package, thus we have problem for current impl. of the ddNS feature #2  :(
but in general, it also requires full review for the new distribution and configuration because of removed install/uninstall scripts. Primarily we have a tool for service of user projects, and the \build targets are helpful partially only.
It looks like decision with solution-level >( Guys from NuGet team seems don't understand at all that we can have tools instead of libraries to service of any projects, libraries, the build processes etc. :(
well, need to review all this

@3F I'm happy to help get this working if you want. Not sure what the underlying issues you're having with NuGet are that's creating the need for #38?

@onovotny,

I'm happy to help get this working if you want.

:) Good ! More than one way for distribution would be useful anyway.
Actually I already finished the new distribution & manager that described in #38
The short illustration of our new future manager:

https://www.youtube.com/watch?v=okPThdWDZMM   (please note, in this video I use local server)

In total, it contains now lightweight but powerful manager (100% adapted for our project) via new https://github.com/3F/MvsSln & https://github.com/3F/GetNuTool
I hope to release beta on the next week.

Not sure what the underlying issues you're having with NuGet

The main problem here - we are not a library, we are tool. We already discussed about this here https://github.com/NuGet/Home/issues/1521#issuecomment-162695431
But mainly NuGet focused now for libraries only. The PackageReference it exactly strict way to manage all remote libraries in classical References manner. This is really good to view all remote libraries as an local thing, that I think, but we also have other tools for service projects and libraries like this https://www.nuget.org/packages/vsSBE.CI.MSBuild/ and yes, like our DllExport tool.
The second problem the non-controlled global caching at all. I don't see any features (API etc.) to control this. Through new our manager we can:
<Reference Include="DllExport, Version=<IP_ADDRESS>424, Culture=neutral, PublicKeyToken=8337224c9ad9e356">
  <HintPath>..\packages\DllExport.1.6.0-beta\gcache\{0415A0AA-76E4-43A4-BDC3-D115A6781C7D}\DllExport.dll</HintPath>
  <Private>False</Private>
</Reference>

We also need information between each installation/removing or any API to manage our binaries and internal tools like IL Assembler etc. !
(only init.ps1 with caching between projects & \build targets - this is what we have finally today)
Well, I think you may continue dev_1.6 branch for adding alternatives via standard nuget ways (but only as additions to our new manager - anyway, it can be easily combined via commands to Wizard).
dev_1.6 already contains \build\net20\DllExport.targets as simple caller to show information about our new distribution. Only information because this does not work when used PackageReference option: no any .targets if we use PackageReference, just references (https://github.com/3F/DllExport/issues/36#issuecomment-305977523) i.e., as I see it does not give any guarantee.

Happy to continue via email -- mine is oren at Novotny dot org if you want shoot me a note.
I have written many tools that use NuGet and package ref to do this. The trick is usually providing the right targets in the build directory and ensuring that paths are all setup via variables relative to some known location in in the project.
Here's an example of an older tool (no longer needed): https://github.com/onovotny/ReferenceGenerator
It runs purely as a build event to manipulate things during the build. There are no library references to it.
For things where you need persistent local binaries, the easiest thing to do is to use the object directory variables like we do in Refit: https://github.com/paulcbetts/refit/blob/master/Refit/targets/refit.targets
In that case, we write to $(IntermediateOutputPath)\SomeFile.cs and add it to the compile. You can easily add references that way too, so you could easily have a targets that generates a temp file and adds it as a reference.
I'll admit that I don't fully follow the flow of your toolchain, but I love that it works! See this thread for what I've been doing with it: https://twitter.com/onovotny/status/893960433119481856 :)

hmm, I think we are talking about different things :)
I also have a few nuget packages that exactly uses \build features: you can also look 7z.Libs, and I remind you about old regXwild (contains targets for native unmanaged C++ projects and managed .NET via Conari). All this works without .ps1 scripts, only targets to configure Link.AdditionalDependencies, ClCompile.PreprocessorDefinitions etc.

The trick is usually providing the right targets in the build directory and ensuring that paths are all setup via variables

I don't see something like this at all when I use PackageReference option:
<Import Project="..\packages\DllExport.1.6.0-beta\build\net20\DllExport.targets" Condition="Exists('..\packages\DllExport.1.6.0-beta\build\net20\DllExport.targets')" />
<Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
  ...
</Target>

Absolutely no any new Import or Target section in project files ! Therefore my question above was about is it really supported by this, when used PackageReference (it works with first option only, see above) ? Or NuGet before adding Import and Target sections into project files, also will try to check a correct logic of this loaded targets o_O ? if so, it should be leader among omg-projects >(

\build\net20\DllExport.targets o_O

...  as a build event to manipulate things during the build.

For something like this, I use vssbe that's being developed from 2013 and still perfectly for some crazy things with VS or msbuild :) This project also fully controlled by this. Anyone please note this.

I'll admit that I don't fully follow the flow of your toolchain, but I love that it works!

Like a music for my ears ... that all works fine :p thanks for using :)

I don't see something like this at all when I use PackageReference option:

That's because NuGet includes them automatically. NuGet does not touch the project file anymore. That doesn't mean they're not included :)

@onovotny I see, that's what I was looking for :) thanks
<ProjectFileName>.csproj.nuget.g.targets:
<ImportGroup Condition=" '$(ExcludeRestorePackageImports)' != 'true' ">
  <Import Project="$(NuGetPackageRoot)dllexport\1.6.0-beta\build\net20\DllExport.targets" Condition="Exists('$(NuGetPackageRoot)dllexport\1.6.0-beta\build\net20\DllExport.targets')" />
</ImportGroup>

Good ! our Wizard already may control caching gcache\{0415A0AA-76E4-43A4-BDC3-D115A6781C7D}\DllExport.dll thus it really can be combined easily.

... do more behind the scenes.

by the way, the vssbe above was created initially with the same thoughts :) it serves all solution data without any modifications of projects files.

@onovotny https://github.com/3F/DllExport/issues/38#issuecomment-320535078

@onovotny
Unfortunately it still contains a lot of problems for our project. Let me explain...
In the morning I was thinking about same scheme like external .net.dllexport + \build feature:
<PropertyGroup Condition=" '$(ProjectGuid)' == '{36e28b5f-b075-4de7-85e5-d97d1be73f88}' ">
  <DllExportNamespace>System.Runtime.InteropServices</DllExportNamespace>
  ...
</PropertyGroup>
<PropertyGroup Condition=" '$(ProjectGuid)' == '{0415A0AA-76E4-43A4-BDC3-D115A6781C7D}' ">
  <DllExportNamespace>net.r_eg.DllExport</DllExportNamespace>
  ...
</PropertyGroup>
<ItemGroup>
  <Reference Include="DllExport, Version=<IP_ADDRESS>424, Culture=neutral, PublicKeyToken=8337224c9ad9e356">
    <HintPath>$(DllExportInstalledPath)\gcache\$(ProjectGuid)\DllExport.dll</HintPath>
    <Private>False</Private>
  </Reference>
</ItemGroup>
....

Looks good to avoid reloading environment outside EnvDTE logic etc., this I thought until I saw a hard coded logic for this type of references:

failed.
PackageReference section does not affects for this at all:
<PackageReference Include="DllExport">
  <Version>1.6.0-beta</Version>
</PackageReference>

It will work only when project.assets.json will be removed or changed with some incompatible data to destroy link on internal nuget processing of this.
That is:

We can't use DllExport.dll from lib because it's not prepared for projects.
We can't avoid distribution of library outside lib folder because we need to provide anything (see related solution-level problem)
We also can't simply replace (via MvsSln etc.) this new added PackageReference from project file, because it actually does not affect on this.
Seems we also have no any option to control path to libraries in PackageReference section https://docs.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files
Another interesting, PackageReference seems also does not support like this <Private>False</Private> i.e. we need to additional processing for remove this from output folder etc.

I'm still see many problems and inconveniences with this, i.e. I have some ideas but ... I want much more transparent logic for all this.
Please note again, DllExport.dll library it's marker only that's actually does not contains any logic at all. We need this only for Cecil processing in attribute manner.
Well, I think I will improve only preparing of our manager via std. nuget (we can standardize via \build  as I see) + probably I'll implement .net.dllexport feature, need to think.
But the transparent scheme is still as the removing package from official nuget clients, then to continue through our manager. Because I'm watching that NuGet project still is inconvenient for something like this project or this https://www.nuget.org/packages/vsSBE.CI.MSBuild/ etc.
Did I miss something ? some API for control behavior of PackageReference section or project.assets.json etc. ?

Couple things... To prevent PackageReference content from going to the output, you can add a PrivateAssets attribute;
<PackageReference Include="SomeNuget" Version="3.0" PrivateAssets="all" />
That will prevent any lib content from making it to the output directory. There is an open issue to have NuGet automatically do this for packages that are marked as a developmentDependency, but it doesn't do it yet :(
Also keep in mind that ProjectGuid doesn't exist anymore....
What I would suggest is to not have anything in the lib directory for this. In the build targets, you can have a condition that either supplies a Reference to a particular dll (the temporary façade), or some generated one depending on what you need. Not sure I understand what the gcache version does or why the DllExportNamespace would change based on a guid?

What I would suggest is to not have anything in the lib directory for this.

It's not possible anymore :) i.e. the package will not be installed at all if not exists any library in lib folder.
Try to install:  https://www.nuget.org/packages/vsSBE.CI.MSBuild/ - after 2015 we use GetNuTool. Because actually CIM requires only solution-level and does not provide any lib for projects.

Not sure I understand what the gcache version does or why the DllExportNamespace would change based on a guid?

For example, this required by ddNS feature - #2 (e.g.: #47 )

Also keep in mind that ProjectGuid doesn't exist anymore....

That is, it will not be generated by VS when created new project o_O Can I see some documentation about this changes ?

I don't have a link to the docs handy, but look at the "SDK style projects" and all of the clean-up they have been doing. Here's an example of an exe:
https://github.com/onovotny/KeyVaultSignToolWrapper/blob/master/KeyVaultSignToolWrapper/KeyVaultSignToolWrapper.csproj
I can say with certainty that it's possible to have packages that install but do not have a lib folder :) Newer clients have no problem with just a \build item, but to satisfy the older clients, you can use an empty file called _._ in the lib directory. So you could have lib\net20\_._ as an empty file.
The idea here is that all of the logic is handled by your props and targets and you're just telling NuGet to install it and wire-it-up.
Not sure what the real value is of dynamic namespaces? Most tools like this (including Roslyn based things), just pick a namespace and go with it. Only you can answer if it's worth the effort :) If the dll is a marker and gets removed, one option that may be easier could be code generation. Dynamically write a DllExport.cs in the IntermediateOutputPath directory and add that to the Compile You can do this on a BeforeTargets=CoreCompile step. Then you don't need a two-pass compile. The attribute would be included in the Compile and you can put it in whatever namespace you want (based on a property). Would that work?

hmm, the interesting solution to forget about identifiers of projects at all <_<
I thought that ProjectGuid just will be encapsulated internally and still will be available as RO data, but seems no -_-
Maybe you know, what about CurrentSolutionConfigurationContents for SDK-based projects ?
Well, it doesn't matter for DllExport project, because we can also use other internal identifier for specific configured project. But for vssbe project it does :) thanks for the information.

So you could have lib\net20_._ as an empty file.

Looks like a some alternatives, need to check, but I'm scared to use something undocumented from NuGet project. And I'm worry about availability for active std.nuget clients, and so on. How to say... I don't want new surprises from their projects. But I also see that an project now is more standardized in recent time.., hmm
Does exist some official/authoritative information about this ?

The attribute would be included in the Compile and you can put it in whatever namespace you want (based on a property). Would that work?

No :) if I understand correctly your thought. DllExport.dll it's frontend as a marker for user space, and this should be available at runtime for usage 'as is'. Today, as I know, roslyn does not provide any mechanism to reimplement this at runtime. I mean, of course we can fully generate IL via CodeDom compiler + reflection, etc. but we can't reimplement this like ValueTuples in C# 7 :) e.g.:  https://github.com/3F/sandbox/blob/master/csharp/_core_features/Tuple_csharp7/ValueTuple.cs this is possible because it's already implemented by compiler to final implementation later. ValueTuple<...> etc. as you can see from my sandbox. Therefore, preprocessing with modifications of the final binaries (that's already referenced to project) is the most easy way. Well, it's my thoughts only, so anyone may also improve this way if it's needed.

@onovotny Actually, I left integration with PackageReference because of lot of inconveniences and ambiguities like with 'References' inside VS IDE from my post above.
It means that I have no plans for this today until I see some API or some other transparent way for support our important features.
However, you or anyone else may try to integrate this with our new Wizard. I'll review your suggestions later.
Yesterday has been released v1.6 beta2:

Latest manager: https://3F.github.io/DllExport/releases/latest/manager/

I'd be happy to try, but I'm not sure I entirely understand the gap between what PackageReference does and what you need?

Where L1 points to final communications with our manager.
we also need to avoid this:

There really should not be another package manager that pulls in files....I don't understand why this can't be self-contained like it is now?
Sent from a mobile device, please excuse brevity and typos

From: Denis Kuzmin<EMAIL_ADDRESS>Sent: Sunday, August 20, 2017 12:21:38 PM
To: 3F/DllExport
Cc: Oren Novotny; Mention
Subject: Re: [3F/DllExport] PackageReference support in VS 2017 (#36)
[dllexport_manager_and_nuget]https://user-images.githubusercontent.com/3246589/29496502-84e62e0c-85dc-11e7-9ecf-2c95adc61b35.png
Where L1 points to final communications with our manager.
we also need to avoid this:
[dllexport_dblref]https://user-images.githubusercontent.com/3246589/29496464-ec03ff0c-85db-11e7-9e58-62b84f98185f.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/3F/DllExport/issues/36#issuecomment-323595550, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABXHVFTA0j6GfW2bfZffzQFCXw5XVB21ks5saF0SgaJpZM4NSY58.

@onovotny how you will control, for example, DllExport.dll metalibrary via PackageReference ?

All the Wizard should do is add some properties to the MSBuild file, no? To invoke the wizard, you could easily have a target so a user would do msbuild /t:InvokeDllExportConfig and it'd pop-up a UI. Most of the time, it's not explicitly needed. There shouldn't be any "communication" required at install time, just setting some properties for the build to work.
PackageReference would control the dllexport.dll library by adding targets. It can be either DesignTime, or BuildTime, or both.

To invoke the wizard, you could easily have a target so a user would do msbuild /t:InvokeDllExportConfig and it'd pop-up a UI.
There shouldn't be any "communication" required at install time, just setting some properties for the build to work.

:) If I correctly understand you though, yes, it's not so important when it should be configured at install time or when build is started:
Just try to install 1.6.0-beta2 package via PackageReference option and you will see same behaviour. We already execute some UI only when build is started.
Good ! we have the opportunity to configure all what we need :)
no, what about DllExport.dll ?
we already discussed about this above, btw, I updated structure \gcache\metalib\<namespace>\ and added stub _._ as you noticed about this "feature" (that was the one of the reason in the chain of the bugs for beta-1 release :p - https://github.com/3F/DllExport/issues/38#issuecomment-322250229).
so, how we'll manage 2 or more different DllExport.dll ? I mean, does nuget provide some options to control path to library (see project.assets.json), how we'll update/replace this for PackageReference installation ?
Also, how about removing ? we have some configured data for specific projects, therefore we also need to remove this after removing our package.
In general, I have some ideas, but...


Import dashboard command have no effect

$ wizzy version
0.6.0

I'm using wizzy with api_key. I can import datasources, also I can list all my dashboards in terminal. However running wizzy import dashboards returns only Importing 9 dashboards: and I can't see any new files coming in.

This is fixed in master by #116


Update online_monitor for lone hits

What is the problem / what does the code in this PR do
Use selection as proposed here to be displayed in the online monitor:
https://xe1t-wiki.lngs.infn.it/doku.php?id=xenon:xenon1t:zihao:lone_hits_electrode_test
Can you briefly describe how it works?
Apply cuts at the event-builder prior to shipping data off to mongo.

Perhaps it's good if I stress that this PR is mostly an invitation for @xzh19980906 to help thinking about what would make sense to do in the online monitor.

To me it looks great


Added new Open Source extension - TabMerger

TabMerger, as the name suggests, merges your tabs into one location to save memory usage and increase your productivity. TabMerger is a cross-browser extension - currently available on Chrome, Firefox, and Edge.
GitHub: https://github.com/lbragile/TabMerger
Instructions: https://lbragile.github.io/TabMerger-Extension/

Seems like this repository is not maintained anymore - closing


[Code Review] Pull config values into a store.

The stores have the site name hard coded. If I put this into the dev/prod js config files, they fail to run correctly within a browser, but fine on the server.  The client cannot find '/config/dev.js'...
Why does this method of pulling in the config work in the Html component but not within a store?
This pull request is not intended to be merged.

Hi @samkelleher I don't see why it should not work: which error is returning?

 So it looks like it includes the entire directory and was flopping over trying to parse the md as js for some reason.
Works now anyway! 🎉


build.sh error

hi all, forgive my lack of knowledge, fairly new to this..
i'm trying to install dockutil directly through terminal but when i run the following line in terminal
curl https://raw.githubusercontent.com/kcrawford/dockutil/master/build.sh | bash
i receive the output below (after the download summary)
cp: ./scripts/dockutil: No such file or directory
bash: line 7: ./scripts/dockutil: No such file or directory
packaging version:
Usage: pkgbuild [options] --root <root-path> [--component-plist <plist-path>] <package-output-path>
	Build a package from an xcodebuild destination root

Usage: pkgbuild --analyze --root <root-path> <plist-output-path>
	Create template component plist from an xcodebuild destination root

Usage: pkgbuild [options] {--component <component-path>} <package-output-path>
	Build a package from one or more previously-built bundles

See pkgbuild(1) for details.

/tmp/dockutil-output-BxlB0VCh8mr/dockutil-.pkg

any idea how to solve the error with the ./scripts/dockutil directory?
thanks

Before you enter the curl command, try this:
mkdir -p 'scripts/dockutil'

and see if that helps.

thanks @tjluoma
not sure it did, see log below..
Calum@CalsMacBookPro ~ % mkdir -p 'scripts/dockutil'
Calum@CalsMacBookPro ~ % curl https://raw.githubusercontent.com/kcrawford/dockutil/master/build.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   452  100   452    0     0   1412      0 --:--:-- --:--:-- --:--:--  1412
cp: ./scripts/dockutil is a directory (not copied).
bash: line 7: ./scripts/dockutil: is a directory
packaging version:
Usage: pkgbuild [options] --root <root-path> [--component-plist <plist-path>] <package-output-path>
	Build a package from an xcodebuild destination root

Usage: pkgbuild --analyze --root <root-path> <plist-output-path>
	Create template component plist from an xcodebuild destination root

Usage: pkgbuild [options] {--component <component-path>} <package-output-path>
	Build a package from one or more previously-built bundles

See pkgbuild(1) for details.

/tmp/dockutil-output-ehqt6IbspGg/dockutil-.pkg

Ok, so apparently the only folder should have been 'scripts'
So delete the scripts/dockutil and then just do:
mkdir scripts

Then try again

The build script is meant to be run within the dockutil repo and has changed in dockutil 3.


fix: allow suggestion menu to close once a mention is chosen

Details

This PR fixes the bug where suggestion menu was not closing when the username equals to the first name.
Fixed Issues

$ https://github.com/Expensify/App/issues/38358
PROPOSAL: N/A
Tests

Create two accounts on a private domain.
Change the username of the user such that first name is the username.
Go to any chat and try to mention the user.
Verify that the mention menu closes after the suggestion is selected.

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Create two accounts on a private domain.
Change the username of the user such that first name is the username.
Go to any chat and try to mention the user.
Verify that the mention menu closes after the suggestion is selected.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/30054992/6bd3c946-692b-4f66-83a3-2633aa7377dc

Android: mWeb Chrome

https://github.com/Expensify/App/assets/30054992/45f05342-86ce-4bdc-a77d-278e98a936f7

iOS: Native

https://github.com/Expensify/App/assets/30054992/2fb340d5-6f9b-457f-a04a-47265020d00c

iOS: mWeb Safari

https://github.com/Expensify/App/assets/30054992/df30f1fe-671a-46be-8933-d3291903469f

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/30054992/0a296865-571b-4c12-aea3-e2559421b27b

MacOS: Desktop

https://github.com/Expensify/App/assets/30054992/7ed63feb-d056-417d-9826-96cc9ab1aeb6

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@allroundexperts hitting Enter is not sending the message after inserting the mention
https://github.com/Expensify/App/assets/75031127/5fa395b5-4d02-4924-b7ca-7fbb36a5a0e7

@allroundexperts hitting Enter is not sending the message after inserting the mention
Screen.Recording.2024-03-15.at.7.28.00.in.the.evening.mov

Fixed.

@allroundexperts after inserting the mention and removing it the suggestion menu is no longer appearing

Typed @get
Pressed on one name
Removed the mention
typed @get again

https://github.com/Expensify/App/assets/75031127/ab9f6dc4-b9f7-41e9-b3b1-fa776a386d5e

@allroundexperts after inserting the mention and removing it the suggestion menu is no longer appearing

Typed @get
Pressed on one name
Removed the mention
typed @get again

Screen.Recording.2024-03-15.at.8.58.20.in.the.evening.mov

Fixed.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.54-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.54-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Circuit Bug when Pseudo Posting

@cha0sg0d I redeployed the dev branch on vercel and now it looks like it's working! can you confirm?

It didn't work for me initially after I updated the dev branch, but when I redeployed things worked.


Charts in related entity popup section?

Question: Is it possible to insert a chart in the related entity part or is the popup limited to a tabular format?

This will be possible in the upcoming version 5. In this sample you can already have a look at it: https://demos.conterra.de/sandbox/resources/apps/relatedtables5
You can download the preview version here: https://github.com/conterra/mapapps-related-tables/releases/tag/5.0.0-SNAPSHOT

Added in https://github.com/conterra/mapapps-related-tables/releases/tag/5.0.0


Improve readability of README

Improves readability of README by limiting uses of headings and adding fenced code blocks.
(feel free to ignore this pr. For me at least, the current README is not easy to read)

This looks much better IMO


Services: first build: abs added

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_25eetfnmt1/clone/recipe/meta.yaml:15: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_25eetfnmt1/clone/recipe/meta.yaml:20: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_25eetfnmt1/clone/recipe/meta.yaml:37: invalid_url: http://jmcgeheeiv.github.io/pyfakefs/ : Not reachable: 404
ERROR: /tmp/abs_25eetfnmt1/clone/recipe/meta.yaml:46: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_25eetfnmt1/clone/recipe/meta.yaml:46: missing_dev_url: The recipe is missing a dev_url
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_280efet58m/clone/recipe/meta.yaml:39: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, closest match: 0BSD
ERROR: /tmp/abs_280efet58m/clone/recipe/meta.yaml:48: missing_license_family: The recipe is missing the about/license_family key.
Errors were found


NETOBSERV-1274 index duplicate (improve query perfs) [1.4 backport candidate]

... and move Type from field to label
Backport from https://github.com/netobserv/network-observability-console-plugin/pull/380

sorry, wrong target branch


Control vocabulary for targeted structures

Is your feature request related to a problem? Please describe.
We need to control the vocabulary used to describe targeted structures - in multiple places.
Describe the solution you'd like
I don't know how to do this elegantly - I'd like to use existing ontology. But I'm not sure how to do this without making a GIANT enum.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

The ontology in question is here: https://api.brain-map.org/api/v2/data/Structure/query.json?criteria=[graph_id$eq1]&num_rows=1300
We could render that to a file, add it to the repository, and generate the Enum. I worry that it will blow up our schemas because structure is everywhere.  I will investigate a little more.
@jtyoung84 your thoughts here?

relevant discussion https://github.com/json-schema-org/community/discussions/142

and https://github.com/elixir-europe/BioHackathon/blob/master/interoperability/JSON schema validation with ontologies/README.md

Off the top of my head, I would generate the enum using a script and store the static enum in the code base. It looks like there are already discussions about the topic. I can look more deeply into it.

@Sun-flow

Could this help?
https://github.com/SciCrunch/NIF-Ontology/tree/atlas


[fix](invert index) add the reader buffer as a parameter

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Update jetty to 9.4.0.v20161208 (latest version at the moment)

Would be nice for this version to eventually be set by the WAR project using this plugin...Thanks for this plugin!

1.60 should be available on Maven Central now.


Use unbuffered chan in parallel func for processesing the data

I don't understand why you don't use buffered chan.
The guide says that we shouldn't use a magic number such as 64.
// Ought to be enough for anybody!
c := make(chan int, 64)

However, we know the proper buffer size.
It is enough reason to use buffered chan.

And consider to use the permalink.
https://github.com/uber-go/guide/blob/301dcaaa4434c0544dc09e525b8e84518efd1acf/style.md#channel-size-is-one-or-none

@shogo82148

I don't understand why you don't use buffered chan.
The guide says that we shouldn't use a magic number such as 64.

I too felt uncomfortable with this modification, so I have corrected it in the current code (PR #9 ).
Without thinking, I merged the PRs from the original repository. However, after rereading the code, I reconsidered.


Manually set the reboot command

In the current version of the chart (2.7.0) the reboot command in the chart defaults to /sbin/systemctl reboot which doesn't work on AKS nodes. It simply doesn't exist. In order to make it work out of the box the reboot command needs to be set accordingly.

@r0bnet : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@r0bnet - looks like this has a merge conflict. can you address that and then we'll get @mlearned to review. thanks!

@r0bnet : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS okay, I resolved the conflict. A review and merge would be appreciated :)

I just saw that this was fixed in newer versions of the chart itself. So we don't need this PR anymore. Sorry for bothering.


Offline mode

Can this player save youtube video to memory/cache/sdcard for use in offline mode?

No, it's not possible to store YouTube videos.


Ignoring duplicate input URLs, keeping deleted YouTube comments, checking video availability

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
I have 3 questions and figured it'd be easier to post them all in 1 thread.
For context, I wrote a Node program for archiving music from YouTube, which has currently saved about 30K songs. I have a few maxed out 5K playlists which I regularly download to get any newly added videos, and to also retry downloading any that were previously privated/blocked/deleted. I also check the availability/status of all the archived videos to see which ones have been deleted and could possibly be re-uploaded to YouTube.

To check the availability of videos, I'm currently making HEAD web requests for the thumbnails and seeing if it gives a 404. This currently takes about 10 or 20 minutes for 30K videos, the only problem is that I can't tell whether a 404 video is privated, blocked, or deleted. The yt-dlp --simulate option seems to be slower and having to parse the console output doesn't seem ideal. Is there any other way using yt-dlp?
Is there any way to make yt-dlp ignore duplicate input URLs? My playlists contain a lot of privated/blocked/deleted videos, and my program records these from the playlists, along with any that were queued as individual videos. What ends up happening is that a lot of those videos are both in the playlists as well as queued individually, so yt-dlp will attempt to download the same video multiple times in the same session.
Is there any built-in way to update the metadata JSON files without completely overwriting them? Specifically, I don't want comments deleted from YouTube to be erased from my previously downloaded JSON files. This wouldn't be too difficult to write in Node, but figured I'd ask first just in case there's a built-in way that I don't know about. I'm still not sure what exactly --load-info-json does.

Provide verbose output that clearly demonstrates the problem

[ ] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

I don't quite grasp exactly what your program is doing, so here are some ballpark suggestions:

If they are playlists, then use --flat-playlist ?

You could try using --download-archive. Perhaps --force-write-archive or mock writing to the archive file with --print-to-file "youtube %(id)s" archive.txt would be of use to you depending on exactly what you're doing

No


Add support for SYSLOG_FACILITY

See this issue: https://github.com/bwaldvogel/log4j-systemd-journal-appender/issues/10

Thanks for your contribution. I merged your first commit but kept the second commit out yet.


[UX] can't use the app if you forgot your pin.

When you start the app, we automatically show the pin dialog. We must enter the pin to use the app, otherwise we can only close the app.
So, if the pin is forgotten, one can only use the app again if it is reinstalled.

I implemented the functionality to purge all accounts, BUT:
I realized, there is an error thrown, when removing an account in general (even before my additional implementation).
the app still works, but a red screen with the error appears rapidly throwing:
MobXCaughtException: RangeError (index): Invalid value: Valid value range is empty: 0
I guess now I need to find the root of this problem,
should we create another issue for that?

yes. We should stop all state subscriptions that depend on knowing the account. please file an issue, if you're not sure how to solve the problem right away

#194 solves the issue "partly".
If pin not know, you can't access or delete the account besides reinstalling the app.
But with #194 you can switch to another account or create a new account instead of needing to delete the app.

Why do you reopen? In #194 we discussed, that the  accounts which pins are forgotten will be left floating.
https://github.com/encointer/encointer-wallet-flutter/pull/194#issuecomment-968791146

Don't close stuff of not yet merged prs.

Closes in #194


operator should not be bound only to TOX

please unlock usage without tox and provide another tmp path when no TOX_ENV_DIR provided
here is a block that causes issue: https://github.com/charmed-kubernetes/pytest-operator/blob/2c29fa889bd57b651aaa5a7c5eba9c1a788433a8/pytest_operator/plugin.py#L146
@pytest.fixture(scope="session")
def tmp_path_factory(request):
    # Override temp path factory to create temp dirs under Tox env so that
    # confined snaps (e.g., charmcraft) can access them.
    return pytest.TempPathFactory(
        given_basetemp=Path(os.environ["TOX_ENV_DIR"]) / "tmp" / "pytest",
        trace=request.config.trace.get("tmpdir"),
        _ispytest=True,
    )

Should be resolved now.  You may run with --basetemp=<path> to put your temporary files wherever you like

@addyess
thanks!


Allowing iterative sigma clipping

Before, the data was only smoothed with a boxcar filter once and that
sometimes left data unclipped that should have been clipped. This patch
allows iterative clipping to make sure outliers get clipped even if
there are many in a row.
I also removed the duplicated version number. Before we had to update
the version in setup.cfg and version.py. Now we just need to update
version.py.

Codecov Report

Merging #382 (5b04295) into main (e1c3413) will increase coverage by 0.02%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
+ Coverage   57.75%   57.77%   +0.02%
==========================================
  Files          70       70
  Lines        7383     7394      +11
==========================================
+ Hits         4264     4272       +8
- Misses       3119     3122       +3

Impacted Files
Coverage Δ

src/eureka/lib/clipping.py
54.68% <81.25%> (+3.74%)
:arrow_up:

src/eureka/version.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c3413...5b04295. Read the comment docs.


python-magic-bin requirement

Is this package needed to install ALEAPP?
keep getting this error:
ERROR: Could not find a version that satisfies the requirement python-magic-bin==0.4.14 (from -r requirements.txt (line 12)) (from versions: none)
ERROR: No matching distribution found for python-magic-bin==0.4.14 (from -r requirements.txt (line 12))

What python version are you using? Try 3.9. Stay away from 3.10 until
libraries are updated.
On Tue, Jan 25, 2022, 1:06 PM lcsig156 @.***> wrote:

Is this package needed to install ALEAPP?
keep getting this error:
ERROR: Could not find a version that satisfies the requirement
python-magic-bin==0.4.14 (from -r requirements.txt (line 12)) (from
versions: none)
ERROR: No matching distribution found for python-magic-bin==0.4.14 (from
-r requirements.txt (line 12))
—
Reply to this email directly, view it on GitHub
https://github.com/abrignoni/ALEAPP/issues/214, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG3DPC53OX3MWTVKFYOKDDTUX3RDXANCNFSM5MY63Y6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Sorry...when i check my version python3 --version it says 3.8.10,  I installed 3.9.1 and when I run python3.9 -V it gives me Python 3.9.10

Hello,
Same for me under Ubuntu, win10 and un VM.
Don't know what to do

Check the solution in this thread:
https://github.com/abrignoni/iLEAPP/issues/266#issue-1116918948
On Sun, Jan 30, 2022, 4:36 PM onateuth @.***> wrote:

Hello,
Same for me under Ubuntu, win10 and un VM.
Don't know what to do
—
Reply to this email directly, view it on GitHub
https://github.com/abrignoni/ALEAPP/issues/214#issuecomment-1025236705,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG3DPCYWDECZFSBFZKPV6BLUYWVOHANCNFSM5MY63Y6A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

worked on Ubuntu
thanks


Avoid the occurrence of 0 physical cpu cores

What problem does this PR solve?
Issue Number: close #6504
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/cc @hehechen

/cc @ywqzzy

/run-all-tests

/run-all-tests


Module 3 exercises [Elijah Ocansey]

Please "drag & drop" exercise 3 file below.
WS2_M3E1_Template.docx

Please UPDATE THE TITLE of this "Issue" in the title bar above with your name.

If you haven't done so, please go back to Module 3 and make sure to take
the post-training survey.

Well done, Elijah. You clearly grasped the material outlined in Module 3 and successfully applied it to these exercises. Thank you for your participation! Please be sure to fill out the post-Module survey before you begin the next Module.


NPM Install of ng2-select2 broken

npm install ng2-select2
appears to be broken and peg's CPU to 100% when initializing select2.
I had to grab the version from your plunker demo:
<EMAIL_ADDRESS>to fix the issue.

So you get 100% when you are lunching your application or when you are installing ng2-select?

Ok I managed to reproduce the problem, will try to fix it

Fixed in version 0.6.2


gd and gr not working after latest ray-x/go.nvim update

Hey @ray-x , I was wondering if you could help.
I haven't changed my neovim config which is at:
https://github.com/rodrigc/neovim-setup/tree/main/.config/nvim
I recently did a PackerSync to update my dependencies which updated ray-x/go.nvim to https://github.com/ray-x/go.nvim/commit/3cdd68a17ffebcb85a0dd37332e081b0c0eca76d, and also update ray-x/go.nvim, and now
my keybindings for gd and gr are not executing the proper functions to go-to-definition and go-to-references.
Any idea what the problem might be?
I load go.nvim here:
https://github.com/rodrigc/neovim-setup/blob/main/.config/nvim/lua/config/go.lua
and my lsp keybindings are here:
https://github.com/rodrigc/neovim-setup/blob/main/.config/nvim/lua/config/lsp.lua
I am using neovim 0.8.3.
Thanks for your help!
Great plugin, I use it every day!

BTW, I backreved go.nvim to
https://github.com/ray-x/go.nvim/commit/3a853d50afd2b9ed56fe263420b3e873b6285544
and got a working setup.

A fix was committed. Could you check?

It works now!  Thank you!


Waypoint: Escape Sequences in Strings[beta] space before word

Quotes are not the only characters that can be escaped inside a string. Here is a table of common escape sequences: <--displays correctly in plain text; however, red/italics markdown on word 'escaped' merges into next word: inside. (i.e., escapedinside)

@qmikew1 Since the escaped is in italics, it looks close to the first letter of next word but I think it's not an issue.

It looks fine on my screen, perhaps it can be even better adding   after escaped

This looks correct to me:


[WIP] remove unused code

The type of this PR is: TYPE

This PR resolves CX-892
Description

This PR removes the old Auction view, as well as the abstractions used by that view. It also removes unused code throughout the app, notably the spotlight indexing (which doesn't work and wasn't being called), networking code, some unused CocoaPod dependencies, and unit tests for everything else that was removed.
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

Hmm, there's a snapshot test for Live Auctions that's failing intermittently, due to antialiasing issues. I'm going to remove it, it's mostly covered by other tests (and is included in the manual QA script).

Do you want this squashed or merged to preserve commits?

Up to you, I see that they were merged in and for such a large PR, I think that makes sense 👍


ADD: headless web scraper, new fields for indico results

Why is this getting merged into master?

Cause there is only a master branch right now?  No development.

We can create one real quick


Enable Shutdown/Resume of Managed clusters

Allow to shutdown and resume (hibernate) the underlying cloud VM instances to save on cloud costs when a cluster does not need to be running.

this is a key feature we would need in ROSA esp. for our non-prod environments. AWS cloud cost saving will be in order of 60% for our team (from shutting down in evenings and weekends)
We are now at crossroads - whether to continue ROSA or move to another platform as our loads are picking up

This is also a huge benefit for us, we are now dealing with our 3.11 to shutdown workers during non-office hour, if this is a supportive feature, it definitely will speed up our ROSA migration process

We completely understand the importance of this feature to our customers. Currently, there are some stability issues, specifically around resumption of clusters that is preventing us from releasing this to customers. OCP is tracking this work in https://issues.redhat.com/browse/API-1376.
All of our engineering work is complete in order to offer this to customers, so once the OCP work is resolved, we expect to release this shortly thereafter.
In the short term, we encourage customers to use the rosa CLI in building pipelines around cluster creation and cluster teardown to address cost saving concerns.

Dear ROSA team,
this feature is very critical for us. Kindly prioritise it at your earliest. We are somewhat tempted to move back to Kubernetes :(
Thanks & regards
Kannan

Hi Kannan,
Thanks for your feedback.  We understand the benefits of having a hibernate feature.  We do have some persisting stability issues that we are working through.  Once those are remediated this feature can be available.

I imagine once available it will be the case for ROSA and ARO as well right ?

I imagine once available it will be the case for ROSA and ARO as well right ?

@mhamedbenjmaa
My guess is no for ARO because ARO is not OSD under-the-hood. It also has its own roadmap https://github.com/Azure/OpenShift/issues/207
Would be nice to know exact date when this feature for ROSA will actually be in Preview/GA though.

@0kashi .... any updates on this one?

++ everyone in IBM who uses ROSA for dev/test

This feature is a must for us otherwise it’s way cheaper to keep it on prem

Any words on ETA of this feature on ROSA?


Create GitHub action to automate mcad release

Fixes https://github.com/project-codeflare/multi-cluster-app-dispatcher/issues/408

Changes look ok to me, though I am not so familiar with MCAD Makefile implementation to review Makefile changes.
@Srihari1192 I see that Travis fail on missing CONTROLLER_VERSION. Can you adjust the Travis config to not require that file?

Changes look ok to me, though I am not so familiar with MCAD Makefile implementation to review Makefile changes. @Srihari1192 I see that Travis fail on missing CONTROLLER_VERSION. Can you adjust the Travis config to not require that file?

Sure

Workflow doesn't work properly based on experiments with my fork.

I have yet to test this workflow, will update PR with new changes as per review comments and will test it

I tested this workflow on https://github.com/Srihari1192/multi-cluster-app-dispatcher/actions/workflows/mcad-release.yml looks good


add annotation for pre-delete job in hosted mode

Signed-off-by: Zhiwei Yin<EMAIL_ADDRESS>

/LGTM

/LGTM


Error training data on examples provided in repo.

I've been following this  totorial I Cloned the repo, and when I run python run_lookup.py everything works fine(i.e it gives me precision and recall). When I try to train a model on food data provided using cmd
python -m rasa_nlu.train -c /home/chaitanya/rasa_lookup_demo/configs/config.yaml  --data food -o models --project current --verbose
it loads spacy model and throws error
2019-04-01 11:33:54 INFO     rasa_nlu.training_data.training_data  - Training data stats:
	- intent examples: 36 (1 distinct intents)
	- Found intents: 'restaurant_search'
	- entity examples: 19 (1 distinct entities)
	- found entities: 'food'

Traceback (most recent call last):
  File "/home/chaitanya/anaconda3/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/chaitanya/anaconda3/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/home/chaitanya/Desktop/rasanlu_final/venv/lib/python3.6/site-packages/rasa_nlu/train.py", line 184, in <module>
    num_threads=cmdline_args.num_threads)
  File "/home/chaitanya/Desktop/rasanlu_final/venv/lib/python3.6/site-packages/rasa_nlu/train.py", line 153, in do_train
    training_data = load_data(data, cfg.language)
  File "/home/chaitanya/Desktop/rasanlu_final/venv/lib/python3.6/site-packages/rasa_nlu/training_data/loading.py", line 55, in load_data
    data_sets = [_load(f, language) for f in files]
  File "/home/chaitanya/Desktop/rasanlu_final/venv/lib/python3.6/site-packages/rasa_nlu/training_data/loading.py", line 55, in <listcomp>
    data_sets = [_load(f, language) for f in files]
  File "/home/chaitanya/Desktop/rasanlu_final/venv/lib/python3.6/site-packages/rasa_nlu/training_data/loading.py", line 109, in _load
    raise ValueError("Unknown data format for file {}".format(filename))
ValueError: Unknown data format for file food/lookup/food.txt

Im using a virtual environment and my versions are
rasa-core==0.13.6
rasa-core-sdk==0.12.2
rasa-nlu==0.14.6

I think this is a separate issue than the one you tagged. @paulaWesselmann will look into this one for you

Hey @chaitu9701, can you send me how your lookup table file looks like?
The externally supplied lookup tables must be in a newline-separated format.

It's the same file, I obtained while doing a git clone, the file I'm trying to train is in the food folder. I'm using python3.6 anaconda version. Please let me know if you still need the file

The link to the tutorial doesn't work, I cannot see what the file looks like.
Maybe can you just copy the first few lines here.

the folder named data/company in this git repo  https://github.com/RasaHQ/rasa_lookup_demo/tree/master/data.
And thank you for the quick response

I am confused now, why the folder data/company?
I though we were talking about this file: https://github.com/RasaHQ/rasa_lookup_demo/blob/master/data/food/food.txt  which looks all good by the way.

I'm facing the same issue with both food and company. The command which gives me the error is when i try to train it using python -m rasa_nlu.train -c /home/chaitanya/rasa_lookup_demo/configs/config.yaml --data food -o models --project current --verbose

Ah I see, if you are using all files in the food folder for nlu training you have to remove the food.txt file from there, since nlu data has to be .md

I'll close this issue.

Ah, thanks for the update. Will try that

That solved the issue, I sincerely thank you for your time and effort.


NoSpaceBeforeCloseParenthesis partially duplicates upstream sniff

Seems to be two sniffs reacting to same issue in case of function declaration:
  36 | ERROR | [x] Expected 1 spaces between argument "$max_entries" and
     |       |     closing bracket; 0 found
     |       |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingBeforeClose)
  36 | ERROR | [x] No space before closing parenthesis is prohibited
     |       |     (WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeCloseParenthesis)

Is this a problem, other than indicate there is some duplication which could mean we could remove some code?

Working from command line it makes things more verbose and in summary reports it essentially doubles the numbers on these. Personally I am more annoyed by workflow redundancy then code redundancy in such cases.


Code issue in page 59

Hi in this book page 59 the example code shows
Stream streamSupplier = .......
Optional simpleSum=
streamSupplier.map(x->x.length()).reduce((x,y)-> x+y);
but is that stream can directly use the map function? I think they're missing one .get() method
Optional simpleSum= streamSupplier.get().map(x->x.length()).reduce((x,y)->x+y);

Please reopen if the issue still persists.


fix(tags): Fix the tag deletion

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
Fixes #5296
Fixes #5277

Add monitor_tag.value attribute in getMonitorTag SELECT
Add monitor_id and value for each tag in preparePreloadData

Because those two attributes were missing, the DELETE monitor_tag WHERE [...] wasn't touching any line because of the empty (null/undefined) parameters.
Type of change
Please delete any options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods) (Note: No comment added because nothing need it)
[x] My changes generates no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

✅ Confirmed: This bug fix works as expected.
After the recent bug fix #5298, I tested the functionality of the tag system. I can now remove tags in the usual way without having to manually delete them in the database. Everything is working properly with the tag system.
@Ionys320 Thank you for your effort and the quick resolution!
How I came to this conclusion:
I manually added the updated monitor.js from @Ionys320 to the Docker container using volumes:
/docker/uptime-kuma-beta/monitor.js:/app/server/model/monitor.js

@homelab-alpha we have a much simpler solution for testing PRs ^^
https://github.com/louislam/uptime-kuma/wiki/Test-Pull-Requests
=> for this PR, it can be tested via
docker run --rm -it -p 3000:3000 -p 3001:3001 --pull always -e 'UPTIME_KUMA_GH_REPO=Ionys320:master' louislam/uptime-kuma:pr-test2

Awesome, thanks for the quick merge! @CommanderStorm

@homelab-alpha we have a much simpler solution for testing PRs ^^ https://github.com/louislam/uptime-kuma/wiki/Test-Pull-Requests
=> for this PR, it can be tested via
docker run --rm -it -p 3000:3000 -p 3001:3001 --pull always -e 'UPTIME_KUMA_GH_REPO=Ionys320:master' louislam/uptime-kuma:pr-test2

@CommanderStorm 😅 I didn't know that! I learned something new today and immediately created a script from it.
I have read the Test Pull Requests wiki, but I have a question about it. It seems that the software is no longer up to date (please see the logs) and that the persistent storage is not functioning. Halfway through the exit of the louislam/uptime-kuma:pr-test2 container, I received a message stating that error.log could not be created. Other than that, it works fine, but it would be helpful to update the louislam/uptime-kuma:pr-test2 container.
Here is the uptime_kuma_pr_test_v2.sh script (click to expand)

#!/bin/bash

# Filename: uptime_kuma_pr_test_v2
# Author: GJS (homelab-alpha)
# Date: 2024-11-03T12:27:31+01:00
# Version: 1.0.0

# Description:
# This script facilitates the testing of pull requests for Uptime-Kuma
# version 2.x.x within a Docker container environment. It prompts the user
# for a GitHub repository link that points to the pull request to be tested.
# The script launches a Docker container with the specified Uptime-Kuma image,
# allowing developers to verify changes and ensure compatibility before merging.
# The testing process operates on designated ports for both the application and API.

# Aliases:
# To create convenient aliases for this script, add the following lines
# to your shell configuration file (e.g., .bashrc or .bash_aliases):
# alias uptime-kuma-pr-test="$HOME/uptime_kuma_pr_test_v2.sh"
# alias uptime-kuma-pr-test="$HOME/.bash_aliases/uptime_kuma_pr_test_v2.sh"

# Usage:
# Execute this script in the terminal with the command:
# ./uptime_kuma_pr_test_v2

# Define the default ports for the Uptime-Kuma application and API.
port_app=3000 # Port for the main application
port_api=3001 # Port for the API

# Retrieve current user information.
# - username: the name of the current user.
# - puid: the user ID (PUID) of the current user.
# - pgid: the group ID (PGID) of the current user.
username=$(whoami)
puid=$(id -u)
pgid=$(id -g)

# Function to display the help message.
display_help() {
  clear
  echo "======================================================================"
  echo "         Welcome to the Uptime-Kuma Pull Request Testing Tool         "
  echo "======================================================================"
  echo
  echo "Usage:"
  echo "  1. Select an option from the main menu."
  echo "  2. Follow the on-screen prompts to proceed."
  echo
  echo "Note:"
  echo "  Option 2 has limited write permissions implemented."
  echo "  This limitation causes the container to exit unexpectedly when using"
  echo "  images louislam/uptime-kuma:pr-test2."
  echo
  echo "Options:"
  echo
  echo "  1. Uptime-Kuma Pull Request version: 2.x.x"
  echo "     Run a container with the louislam/uptime-kuma:pr-test2 image."
  echo
  echo "  2. Uptime-Kuma Pull Request version: 2.x.x with Persistent Storage"
  echo "     Run a container with the louislam/uptime-kuma:pr-test2 image."
  echo
  echo "Additional Options:"
  echo "  h or --help      : Display this help message."
  echo "  i or --info      : Show current user's information (PUID and PGID),"
  echo "                     as well as Docker and Docker Compose versions."
  echo "  q or --quit      : Quit the script."
  echo
  echo "For more information, visit:"
  echo "  https://github.com/louislam/uptime-kuma/wiki/Test-Pull-Requests"
  echo
  echo "======================================================================"
}

# Retrieve system, user, and Docker information.
display_system_info() {
  clear
  echo "======================================================================"
  echo "         Welcome to the Uptime-Kuma Pull Request Testing Tool         "
  echo "======================================================================"
  echo

  # Extract OS name from /etc/os-release.
  if [ -f /etc/os-release ]; then
    os_name=$(grep '^PRETTY_NAME=' /etc/os-release | cut -d= -f2 | tr -d '"')
  else
    # Default if the OS name cannot be determined
    os_name="Unknown OS"
  fi

  # Retrieve kernel version.
  kernel_info=$(uname -r)

  # Determine filesystem type of the root directory.
  filesystem=$(findmnt -n -o FSTYPE /)

  # Check for Docker and Docker Compose, displaying versions if installed.
  if command -v docker &>/dev/null; then
    # Get Docker version
    docker_version=$(docker --version)
  else
    # Message if Docker is not found
    docker_version="Docker is not installed."
  fi

  if command -v docker-compose &>/dev/null; then
    # Get Docker Compose version
    docker_compose_version=$(docker-compose --version)
  else
    # Message if Docker Compose is not found
    docker_compose_version="Docker Compose is not installed."
  fi

  # Display collected information.
  echo -e "Operating System Information:"
  echo -e "OS: $os_name"
  echo -e "Kernel Version: $kernel_info"
  echo -e "Filesystem: $filesystem"
  echo
  echo -e "User Information:"
  echo -e "Username: $username"
  echo -e "PUID: $puid"
  echo -e "PGID: $pgid"
  echo
  echo -e "Docker Information:"
  echo -e "$docker_version"
  echo -e "$docker_compose_version"
  echo
  echo "======================================================================"
}

# Validate GitHub repository link format (expected: 'owner:repo')
validate_repo_name() {
  if [[ ! "$1" =~ ^[a-zA-Z0-9._-]+:[a-zA-Z0-9._-]+$ ]]; then
    echo "Error: Invalid GitHub repository format. Use 'owner:repo' (e.g., 'Ionys320:master')."
    # Exit if the command fails
    exit 1
  fi
}

# Run Uptime-Kuma container for version 2 without persistent storage.
version_2() {
  echo "Running Uptime-Kuma version 2.x.x..."

  # Check if the container is already running.
  if [ "$(docker ps -q -f name=uptime-kuma-pr-test-v2)" ]; then
    echo "Error: The container 'uptime-kuma-pr-test-v2' is already running."
     Goodbye! Use CTRL+C to terminate."
    # Exit if the command fails or was terminated using CTRL+C
    exit 1
  }
}

# Run Uptime-Kuma container for version 2 with persistent storage.
version_2_persistent_storage() {
  echo "Running Uptime-Kuma version 2.x.x with persistent storage..."

  # Check if the container is already running.
  if [ "$(docker ps -q -f name=uptime-kuma-pr-test-v2)" ]; then
    echo "Error: The container 'uptime-kuma-pr-test-v2' is already running."
     Goodbye! Use CTRL+C to terminate."
    # Exit if the command fails or was terminated using CTRL+C
    exit 1
  }
}

# Remove unused Docker images to free up disk space.
cleanup_dangling_images() {
  echo "Removing unused Docker images to free up storage..."
  # Prune dangling images to recover disk space.
  docker image prune --filter "dangling=true" -f || {
    echo "Error: Failed to prune Docker images. Please check your Docker setup."
    # Exit if the command fails
    exit 1
  }
}

# Main execution starts here.

# Main menu loop for user interaction.
while true; do
  clear
  echo "======================================================================"
  echo "         Welcome to the Uptime-Kuma Pull Request Testing Tool         "
  echo "======================================================================"
  echo
  echo "Please choose an option:"
  echo
  echo "   1. Uptime-Kuma Pull Request version: 2.x.x"
  echo "   2. Uptime-Kuma Pull Request version: 2.x.x with Persistent Storage"
  echo
  echo "   q: quit   h: help   i: info"
  echo "======================================================================"
  echo
  read -r -p "Please select an option (1, 2, h, i, or q to exit): " choice

  case $choice in
  1)
    selected_option="version_2"
    break
    ;;
  2)
    selected_option="version_2_persistent_storage"
    break
    ;;
  h | --help)
    # Show help message
    display_help
    echo
    # Wait for user input
    read -n 1 -s -r -p "Press any key to continue..."
    continue
    ;;
  i | --info)
    # Show system info
    display_system_info
    echo
    # Wait for user input
    read -n 1 -s -r -p "Press any key to continue..."
    continue
    ;;
  q | --quit)
    echo
    echo "Exiting the script Goodbye!."
    echo
    echo "Thank you for using the Uptime-Kuma Pull Request Testing Tool."
    # Exiting the script
    exit 0
    ;;
  *)
    echo "Error: Invalid option. Please try again." # Error message for invalid option
    ;;
  esac
done

# Prompt for the GitHub repository link and validate the format
read -r -p "Please enter the GitHub repository link here (e.g., Ionys320:master): " pr_repo_name
validate_repo_name "$pr_repo_name"

# Execute the selected Docker run command
$selected_option

# Clean up dangling Docker images
cleanup_dangling_images

📝 Relevant log output (click to expand)

npm WARN deprecated<EMAIL_ADDRESS>Please update to the latest version of Playwright to test up-to-date browsers.

added 306 packages, removed 614 packages, changed 371 packages, and audited 1284 packages in 23s

246 packages are looking for funding
  run `npm fund` for details

4 high severity vulnerabilities

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.

  VITE v5.2.14  ready in 262 ms

  ➜  Local:   http://localhost:3000/
  ➜  Network: http://<IP_ADDRESS>:3000/
  ➜  Vue DevTools: Open http://localhost:3000/__devtools__/ as a separate window
  ➜  Vue DevTools: Press Alt(⌥)+Shift(⇧)+D in App to toggle the Vue DevTools

  ➜  press h + enter to show help

Sorry, problem is still present in 2.0.0-beta.1

@derekoharrow Works fine for me. Can you provide more infos, especially the DB used for your instance?

@Ionys320, The conversation continued in...

#5442

@derekoharrow Works fine for me. Can you provide more infos, especially the DB used for your instance?

It worked on most monitors but on a couple of existing ones with multiple tags (with no values in them) it wouldn't delete.
I'm running MariaDB
I've managed to get around it by cloning the monitor and deleting the tags before saving.

@derekoharrow, Let’s keep this conversation in one place, please, in this case...

#5442

Thank you in advance for your cooperation.


Install doesnt complete

The base structure appears, but nothing more.
I have the models already, and can put them in place manually.
But where should they go? And would that be enough?

Can you send me a picture of C:\Dalai and C:\Dalai\dalai?

Ofc! This is C:\dalai\

There is the problem: It didn't clone Dalai itself, as there should be a folder C:\Dalai\dalai where Dalai is cloned. Please maybe try yourself to clone Dalai into C:\Dalai\ and then try the installer again

In C:\Dalai\dalai type: npm alpaca install 7B


Include url_hosts_whitelist with my user and password  parameter when I use core action core.http

SUMMARY
I've been suffering with a bug into my workflow, when I use a core.http task I've noticed that a url_hosts_whitelist and password are filled automaticaly, even withdrawing these line on code, when I save, theses line back into my code.
STACKSTORM VERSION
Paste the output of st2 --version:
st2 3.8.0, on Python 3.8.10
OS, environment, install method
Post what OS you are running this on, along with any other relevant information/
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.5 LTS
Release:	20.04
Codename:	focal
Installed manually
Steps to reproduce the problem
Show how to reproduce the problem, using a minimal test-case. Make sure to include any content
(pack content - workflows, actions, etc.) which are needed to reproduce the problem.

create a workflow > insert name , include a http.core action, fill the url  like google.com , set a method get > set header - execute the workflow / close the file, check the result in history > open the workflow and it will apper these parameters filled automaticaly
version: 1.0
tasks:
[510, 272]
task1:
action: core.http
input:
url: "https://www.google.com.br/"
method: GET
headers:
TEST: TEST
url_hosts_whitelist:
- myuserstackstorm
password: cannot shwo the password
next:
- do:
- task2
[528, 384]
task2:
action: core.echo
input:
message: TEST

Expected Results
http google page
What did you expect to happen when running the steps above?
    "traceback": "  File \"/opt/stackstorm/st2/lib/python3.8/site-packages/st2actions/container/base.py\", line 132, in _do_run
(status, result, context) = runner.run(action_params)

File "/opt/stackstorm/st2/lib/python3.8/site-packages/http_runner/http_runner.py", line 116, in run
result = client.run()
File "/opt/stackstorm/st2/lib/python3.8/site-packages/http_runner/http_runner.py", line 262, in run
raise ValueError('URL "%s" is not whitelisted' % (self.url))
"
Actual Results
What happened? What output did you get?
an error , if I delete theses lines and save for a many times I can be able to run the workflow and obtain the expected result
Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

Hey @lucasfontini, Were you able to resolve this?


error phalcon 2

Fatal error: Call to undefined method Phalcon\Mvc\Dispatcher::getHandlerClass() in /Users/jpmaster/development/test/phalcon/phalcon-restful-webservice/app/Core/Security.php on line 20

which phalcon version do you use?

Author	Phalcon Team and contributors
Version	2.0.0
Powered by Zephir	Version 0.6.2a

Hi, just take a look phalcon 2 docs and there is no API changes it should work.
I will give it a test in phalcon 2, thanks for reporting

I hope. thanks

I can confirm it works in phalcon 2.0.5, Im not sure for your error I thinks its phalcon related error. Since Phalcon\Mvc\Dispatcher::getHandlerClass()  API still available in v2


Support printing cloud module version.

Status
READY
Description
Added support for logging cloud module version. Some pylint fixes, primarily added some missing docstrings, included in the same  commit.
Todos

[x] Tests

@jupe @YifeiZuo01 any idea what's going wrong in CI?

ready for merging ?


Layer names don't set correctly in Entities and CadObject for DXF files after using reader

Hi, I tried to read a dxf file by this package and distinguish every entity from its layer name, but unfortunately all Layer.Name in Entities had the same value: "0" - the default layer name.
I also tried to use GetCadObject by their handler but cadObjects had the same result, too.
Thanks for your attention. I’m looking forward to your reply.

Hi @eerFun,
Can you provide the version of the package, to make sure that it was not a version related issue.
I'll open a branch to make the test more accurate about layer related and work with a fix.
Unfortunately I'll won't be available until October to work in this issue, apologies for the delay.

Thank you for your quick response.
I was using the version 1.3.4-alpha, but today I upgraded my package to the latest version 1.3.5-alpha and unfortunately saw the problem still persists.

Can you provide a simplified DXF with this issue for review?

Yes, Of course.
ImportCAD.zip


Journeys Into HARK

@ericholscher @shaunagm,
Jan Rosa has been working with me to improve the HARK documentation, and I've had him look in particular for toolkits that do a good job of guiding new users into the substance of the toolkit, by constructing curated "journeys into HARK" for people with different backgrounds.  He's found some nice examples and what I would like to have him do is to create the rudiments of at least two different "journeys into HARK" -- one from the perspective of a first year PhD economics grad student, and one for someone with a lot of computer expertise but less economics grounding.  I'm sending this message because if the two of you have advice for him (esp about integration of such journeys into RTD), that would be useful to him.

I will be very grateful for your advice. Before, I added some auto documentation into RTD however, I have never integrated it with Jupyter notebook.

Great. All the integration with Sphinx is done via nbsphinx -- so that would be the best place to look for best practices. I haven't done much personally, but their docs are pretty good, and the maintainers are responsive.

Thank you! I will try this and start building the journeys!

@janrosa1 any updates on this?
I'm currently working on documentation aimed at those with more computer science experience, and less economics experience.

Hi,
I do not have any updates now - I sent the pull request in the late August
(all the notebooks integrate at my fork with nbshpinx). However if you
think that I should add something to the repositories, or have some
questions how I organized the "intro to HARK" for people with econ
experience (1st year PhD), please let me know. I will answer ASAP.
Best,
Jan
pon., 3 lut 2020 o 09:26 Sebastian Benthall<EMAIL_ADDRESS>napisał(a):

@janrosa1 https://github.com/janrosa1 any updates on this?
I'm currently working on documentation aimed at those with more computer
science experience, and less economics experience.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/econ-ark/HARK/issues/362?email_source=notifications&email_token=AENCRHWZ5WWUR5NHZHHYRWLRBBHTTA5CNFSM4IFZ53DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKUV3DI#issuecomment-581524877,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENCRHT4RK2SBQ225EH2K43RBBHTTANCNFSM4IFZ53DA
.

implemented in https://github.com/econ-ark/HARK/pull/380


PyPi release for python-rest

First off, thank you for providing such a diverse collection of API wrappers!
Would it be possible to push the coinapi python-rest wrapper to https://pypi.org/ ?
Thanks again!

It's pushed, package name: coinapi.rest.v1


can not find a reference to assembly 'System.Memory'

your package include **'System.Memory'**  but raise errors relate to _can not find a reference to assembly 'System.Memory'_, I have no idea how to fix it. can anyone help me please.
Windows 11
unity 2020.3.46f1

close and reopen unity, sometimes this happen.

I think Unity 2020.3.46 and older version editor doesn't support some dll
in Unity 2021.3 has no error


Deadlock on OSX

Hi there,
I am refactoring our CoinListViewModel in WasabiWallet. It works fine on Windows and Linux but on OSX it hangs randomly. I have no clue it might be Reactive so I decided to ask you guys.
Environment:

OSX 10.15.1
Dotnet core 3.0
Avalonia 9 preview 7

Assembly ReactiveUI, Version=<IP_ADDRESS>
Assembly System.Reactive, Version=<IP_ADDRESS>
Assembly DynamicData, Version=<IP_ADDRESS>

Stack trace
The UI gets unresponsible and when I pause the execution it stands here:
https://github.com/zkSNACKs/WalletWasabi/pull/2602/files#diff-8ef0b233124cda8dfcef1707a9d8df4aR598
Called from here:
https://github.com/zkSNACKs/WalletWasabi/pull/2602/files#diff-8ef0b233124cda8dfcef1707a9d8df4aR462
Sometimes it hangs here too: https://github.com/zkSNACKs/WalletWasabi/pull/2602/files#diff-8ef0b233124cda8dfcef1707a9d8df4aR593
Purpose of the code
Instead of refreshing the CoinList every time when there is a change I created an event CoinListChanged. I am calling this event from several places and throttle it - so the list will be refreshed only once.
Hacky solution
If I replace this line:
CoinListChanged?.Invoke(this, null);
with
Task.Run(() => CoinListChanged?.Invoke(this, null));
It will work.
Theory
ThreadPool randomly selects the executor Thread for the tasks. If it selects the same thread which should run the task it will wait for itself forever. Or there is some circular waiting list that is not detected on OSX. I also noticed the same behavior when I used the Subscribe with WhenAnyValue and modify the same value inside the subscription - it also hangs randomly on OSX at the line: set => this.RaiseAndSetIfChanged.
This is a long-running issue in Wasabi and I always hacked it around which is not a long term solution, any suggestion appreciated.

Is there a code that blocks or locks? Can you check who is doing what when there is a deadlock? Could you try with System.Reactive 4.2.0?
Also your project looks complicated for someone outside of it to track things down. Could you create a minimal project that shows the hang issue?

Is there a code that blocks or locks?
No, it just rebuilds the CoinList. No locks or blocks.
Could you try with System.Reactive 4.2.0?
Upgraded, it hangs too.
Could you create a minimal project that shows the hang issue?
Yes, I can but it is not easy because I am using reactive through Avalonia and maybe that causes the problem. Just by looking at this ViewModel everything seems legit there?
https://github.com/zkSNACKs/WalletWasabi/blob/65c7f044bc3e937ce17768e4eb327b394df9e29b/WalletWasabi.Gui/Controls/WalletExplorer/CoinListViewModel.cs#L452

Rx' FromEventPattern is not thread safe by itself and can cause arbitrary bugs down the stream. If your events can come from any thread, it's possible something will break. Try applying Synchronize on those events and see if it helps.

Hmm, that makes sense. By Synchronize you thought about this?
Observable.FromEventPattern(this, nameof(CoinListChanged),RxApp.MainThreadScheduler)
I added the UI thread RxApp.MainThreadScheduler.

No, Synchronize().
Individual sources can't be driven concurrently. FromEventPattern uses a Subject to dispatch and the scheduler version is just like applying ObserveOn, so it won't likely solve the problem. The issue could be that the same event source triggers multiple events at the same time from different threads and that breaks the internals. Applying Synchronize should fix that case. If not, further investigations are needed.

Observable
    .Merge(Observable.FromEventPattern(this, nameof(CoinListChanged)).Select(_ => Unit.Default))
    .Throttle(TimeSpan.FromSeconds(2)) // Throttle TransactionProcessor events adds/removes.
    .Merge(Observable.FromEventPattern(this, nameof(CoinListShown)).Select(_ => Unit.Default)) // Load the list immediately.
    .ObserveOn(RxApp.MainThreadScheduler)

The subscription to C# events is usally not thread safe, hence you have to be careful where the event subscription happens. Rx has some fences there to force subscription on the UI thread, but I do not know if they work for avalonia. In the second Observable.FromEventPattern will subscibe on the Throttle thread and not on the UI thread. You could add to that observable an SubscribeOn(RxApp.MainThreadScheduler) or even better use the main thread scheduler already for the throttling .Throttle(TimeSpan.FromSeconds(2), RxApp.MainThreadScheduler). I do not know, however, if that causes the dead lock you observing.
BTW I see that you are using ObserveOn in many places. In my experience the view model should have an explicit UI thread affinity, although that is not necessarily by WPF (I do not know how Avalonia handles this). So if you only subscribe to the view model via WhenAny you only need ObserveOn  if you are leaving the main thread with a time based operator like Throttle.

So I did this and looks like the situation improved. I added Synchronize to every Observable.FromEventPattern.
Observable
	.Merge(Observable.FromEventPattern<ReplaceTransactionReceivedEventArgs>(Global.WalletService.TransactionProcessor, nameof(Global.WalletService.TransactionProcessor.ReplaceTransactionReceived)).Select(_ => Unit.Default).Synchronize())
	.Merge(Observable.FromEventPattern<DoubleSpendReceivedEventArgs>(Global.WalletService.TransactionProcessor, nameof(Global.WalletService.TransactionProcessor.DoubleSpendReceived)).Select(_ => Unit.Default).Synchronize())
	.Merge(Observable.FromEventPattern<SmartCoin>(Global.WalletService.TransactionProcessor, nameof(Global.WalletService.TransactionProcessor.CoinSpent)).Select(_ => Unit.Default).Synchronize())
	.Merge(Observable.FromEventPattern<SmartCoin>(Global.WalletService.TransactionProcessor, nameof(Global.WalletService.TransactionProcessor.CoinReceived)).Select(_ => Unit.Default).Synchronize())
	.Subscribe(args =>
	{
		try
		{
			OnCoinListChanged();
		}
		catch (Exception ex)
		{
			Logger.LogError(ex);
		}
	})
	.DisposeWith(Disposables);

As far as I can understand I do not need to sync events from different sources but I have to sync events from the same source. So there is no need to create an object myLock and add as a parameter to sync. Throttle is OK with that?

Thank you for your help @akarnokd and @quinmars. I solved the problem. I elaborated on the problem and a deeper I went the dirtier it became but anyway:
The first one is to use Synchronize(refreshLock) in case if an event source can trigger the same event at the same time. For example, I had a list of items. Every item has a status that can be changed for several reasons. In the lists view model, I need to detect if any of the statuses of the items are changed or not. Subscribe with WhenAnyValue() to every item and sync with the same lock.
The second problem was with Throttle. As @quinmars mentioned Throttle can change the thread. In our project, we are always ObserveOn the UI thread before every Subscribe. In this case, combining Throttles and creating Observable on top of Throttled property caused deadlocks. Try to avoid multiple Throttling. Always use the Model properties as the source of the Observable and use Throttle on them and ObserveOn at the end once.
Useful articles:
http://introtorx.com/Content/v1.0.10621.0/15_SchedulingAndThreading.html
https://jonskeet.uk/csharp/threads/lockchoice.html


Move JobConfig to vdk-core

What is the feature request? What problem does it solve?
In vdk-control-cli, there is a JobConfig class, that provides utilities to read and manipulate a data job's config.ini file. This is fine for most cases, but if we want to implement new functionality in vdk-core or other component of versatile data kit, using this class creates the risk of hitting issues with circular dependencies.
Suggested Solution
The solution for the above-mentioned issue could be to move the JobConfig class to vdk-core, as all other sdk components essentially depend on it. This would reduce the risk of circular dependencies, and there would be no need to re-implement existing functionality in other components.

There's also JobConfig in vdk-core. They are slightly different but not much.
Ultimately we should leave only one (in vdk-core as the base package).

The JobConfig in vdk-core, and the one in vdk-control-cli were synced. Tests were moved from vdk-control-cli to vdk-core as part of https://github.com/vmware/versatile-data-kit/pull/2257.
What remains is for the JobConfig in vdk-control-cli to be removed and the imports to be changed to point to the vdk-core's JobConfig.


console api docs for keys

🚀 Deployed on https://65ab184cfe2cc034fc15a71f--cozy-fox-0defec.netlify.app