[SPARK-27297] [SQL] Add higher order functions to scala API

What changes were proposed in this pull request?
There is currently no existing Scala API equivalent for the higher order functions introduced in Spark 2.4.0.

transform
aggregate
filter
exists
zip_with
map_zip_with
map_filter
transform_values
transform_keys

Equivalent column based functions should be added to the Scala API for org.apache.spark.sql.functions with the following signatures:

def transform(column: Column, f: Column => Column): Column = ???

def transform(column: Column, f: (Column, Column) => Column): Column = ???

def exists(column: Column, f: Column => Column): Column = ???

def filter(column: Column, f: Column => Column): Column = ???

def aggregate(
expr: Column,
zero: Column,
merge: (Column, Column) => Column,
finish: Column => Column): Column = ???

def aggregate(
expr: Column,
zero: Column,
merge: (Column, Column) => Column): Column = ???

def zip_with(
left: Column,
right: Column,
f: (Column, Column) => Column): Column = ???

def transform_keys(expr: Column, f: (Column, Column) => Column): Column = ???

def transform_values(expr: Column, f: (Column, Column) => Column): Column = ???

def map_filter(expr: Column, f: (Column, Column) => Column): Column = ???

def map_zip_with(left: Column, right: Column, f: (Column, Column, Column) => Column): Column = ???

How was this patch tested?
I've mimicked the existing tests for the higher order functions in org.apache.spark.sql.DataFrameFunctionsSuite that use expr to test the higher order functions.
As an example of an existing test:
  test("map_zip_with function - map of primitive types") {
    val df = Seq(
      (Map(8 -> 6L, 3 -> 5L, 6 -> 2L), Map[Integer, Integer]((6, 4), (8, 2), (3, 2))),
      (Map(10 -> 6L, 8 -> 3L), Map[Integer, Integer]((8, 4), (4, null))),
      (Map.empty[Int, Long], Map[Integer, Integer]((5, 1))),
      (Map(5 -> 1L), null)
    ).toDF("m1", "m2")

    checkAnswer(df.selectExpr("map_zip_with(m1, m2, (k, v1, v2) -> k == v1 + v2)"),
      Seq(
        Row(Map(8 -> true, 3 -> false, 6 -> true)),
        Row(Map(10 -> null, 8 -> false, 4 -> null)),
        Row(Map(5 -> null)),
        Row(null)))
}

I've added this test that performs the same logic, but with the new column based API I've added.
    checkAnswer(df.select(map_zip_with(df("m1"), df("m2"), (k, v1, v2) => k === v1 + v2)),
      Seq(
        Row(Map(8 -> true, 3 -> false, 6 -> true)),
        Row(Map(10 -> null, 8 -> false, 4 -> null)),
        Row(Map(5 -> null)),
        Row(null)))

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I think this is a whole lot to add and support in the APIs, and will be Scala-specific, in an API that is more meant to follow SQL operations than Scala.

@srowen Can't we make the same argument against any of the scala functions in org.apache.spark.sql.functions ?
Also, I can provide equivalent methods in java that will accept lambda expressions via a functional interface.

I've added Java-specific versions of the api as well to show how java interop can be handled. I still need to add the corresponding tests.

Can you hold it for a while before we go further? Growing APIs in functions.scala is a concern. cc @rxin, @gatorsmile, and @ueshin

Sure, I'd love to get some more feedback on this!

Any more thoughts on this? @HyukjinKwon @rxin @gatorsmile @ueshin

Also cc @hvanhovell

Would it be more appropriate for me to close the issue and make a third party library for these if growing the API is a concern? @HyukjinKwon @rxin @gatorsmile @ueshin @srowen @hvanhovell

I have no strong opinion on here. I would leave it to @rxin, @ueshin, @hvanhovell

It's extremely weird and inconsistent for there to be SparkSQL functions with no DSL equivalent. It forces companies such as Swoop to create our own (e.g., https://gist.github.com/ssimeonov/8d902d0dfda934a79c3a46ec7dc0523d) yet bear the uncertainty as to what OSS Spark does, which is not a great outcome for the ecosystem. It would have been much better if SparkSQL and DSL support had been launched jointly.
The growing size of functions feels like a red herring, but, if it is a concern, what prevents us from putting various categories of functions in other "namespaces", the way Dataset does with statistics & missing value functionality?
Either way, delaying a decision on this functionality, by which I don't mean this specific PR, does not help.
/cc @rxin

I noticed that the implementation I initially submitted only worked for bound column references, so I've fixed that with this most recent commit. Referencing columns via col("x") will work now instead of just dataframe("x")

I feel it's ok to have these functions. Fills a gap.

@rxin @HyukjinKwon What's the next steps here? Can we get a jenkins build kicked off?

ok to test

Test build #107117 has started for PR 24232 at commit 6bf07d8.

@ssimeonov,

It's extremely weird and inconsistent for there to be SparkSQL functions with no DSL equivalent.

See https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L42-L56

Test build #107117 has finished for PR 24232 at commit 6bf07d8.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107117/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12294/
Test PASSed.

The build is failing but not at changes I have made:

That doesn't seem to be failing in master. I suspect it is somehow related to this change though it's hard to see how here. Does it compile locally?

ping @nvander1 are you able to compile locally?

Yes. It does compile locally for me. What kind of information about the system I used to compile locally would help debug this here?

Did you build with the Maven script, and with what profiles?

retest this please

I think current PR uses the profiles below:
./build/sbt -Phadoop-2.7 -Pkubernetes -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Pyarn -Pspark-ganglia-lgpl -Phive -Pmesos test:package streaming-kinesis-asl-assembly/assembly
(see https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/107117/consoleFull)

Test build #107715 has started for PR 24232 at commit 6bf07d8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12843/
Test PASSed.

Test build #107715 has finished for PR 24232 at commit 6bf07d8.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107715/
Test FAILed.

I had only launched the ./build/sbt and run compile in interactive mode without any flags to the build. Thanks for helping me find the build config @HyukjinKwon . I'll test locally with that and report back later.

@nvander1, I made a PR for your branch to update this PR - https://github.com/nvander1/spark/pull/1. Can you merge that one so that the change comes to this PR?

Thanks for the fix @HyukjinKwon! I've recently returned from vacation so there should be more movement on this PR now.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13575/
Test PASSed.

Test build #108482 has started for PR 24232 at commit f6288cd.

Test build #108482 has finished for PR 24232 at commit f6288cd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108482/
Test FAILed.

Merged build finished. Test FAILed.

Looking into the error. The exists function is somehow returning an extra row:

retest this please

The tests pass in my local too. Can you investigate and debug with Jenkins? Seems this is the only way. You will be able to type "retest this please" as I did.

add to whitelist

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13630/
Test PASSed.

Test build #108536 has started for PR 24232 at commit f6288cd.

Okay, looks you should rebase. The test was fixed in the upstream and Jenkins tests are ran against its upstream.

Test build #108536 has finished for PR 24232 at commit f6288cd.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108536/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13669/
Test PASSed.

Test build #108578 has started for PR 24232 at commit 85979d4.

Test build #108578 has finished for PR 24232 at commit 85979d4.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108578/
Test FAILed.

Test build #108580 has started for PR 24232 at commit 5d389d2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13671/
Test PASSed.

retest this please

Test build #108581 has started for PR 24232 at commit 5d389d2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13672/
Test PASSed.

Test build #108582 has started for PR 24232 at commit 5d389d2.

Test build #108580 has finished for PR 24232 at commit 5d389d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108580/
Test PASSed.

Test build #108581 has finished for PR 24232 at commit 5d389d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108581/
Test PASSed.

Test build #108582 has finished for PR 24232 at commit 5d389d2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108582/
Test PASSed.

@HyukjinKwon I think it's all good now.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13816/
Test PASSed.

Test build #108734 has started for PR 24232 at commit a8c7ecd.

Test build #108734 has finished for PR 24232 at commit a8c7ecd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108734/
Test PASSed.

Looks fine but I think I or somebody else needs to take a closer look before getting this in.

Test build #108901 has started for PR 24232 at commit 96fb0ad.

Sorry @SInCE, false alarm. Forgot github would render that as a mention, haha.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13975/
Test PASSed.

Merged build finished. Test PASSed.

I'm also adding tests for the overloads that accept Java Functional Interfaces.

~transform~
~map_filter~
~filter~
~exists~
forall
aggregate
map_zip_with
transform_keys
transform_values
zip_with

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/13977/
Test PASSed.

Test build #108903 has started for PR 24232 at commit 47b100b.

Test build #108901 has finished for PR 24232 at commit 96fb0ad.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108901/
Test PASSed.

Test build #108903 has finished for PR 24232 at commit 47b100b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/108903/
Test PASSed.

ping @nvander1 how's adding Java tests going?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14434/
Test PASSed.

Test build #109370 has started for PR 24232 at commit 06b4c82.

Test build #109370 has finished for PR 24232 at commit 06b4c82.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109370/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14516/
Test PASSed.

Test build #109458 has started for PR 24232 at commit 182a08b.

Test build #109458 has finished for PR 24232 at commit 182a08b.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109458/
Test FAILed.

retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14541/
Test PASSed.

Test build #109482 has started for PR 24232 at commit 182a08b.

Test build #109482 has finished for PR 24232 at commit 182a08b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109482/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14588/
Test PASSed.

@ueshin I've removed the java overloads and made tests for transform in java. I'll be working on porting the remaining tests throughout the week.

Test build #109533 has started for PR 24232 at commit a543c90.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/14590/
Test PASSed.

Test build #109533 has finished for PR 24232 at commit a543c90.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109533/
Test FAILed.

Test build #109534 has started for PR 24232 at commit 527c0cb.

Test build #109534 has finished for PR 24232 at commit 527c0cb.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/109534/
Test FAILed.

@nvander1 Thanks for moving tests to Java tests.
Btw, I don't think we need to have the whole tests in Java tests but just need to check whether the lambda works or not because we already check various patterns in Scala tests. Maybe one test per function usage should be fine (two for transform and aggregate, one for others).

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15706/
Test PASSed.

Test build #110855 has started for PR 24232 at commit f371413.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15983/
Test PASSed.

Test build #110855 has finished for PR 24232 at commit f371413.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110855/
Test FAILed.

retest this please

Test build #110890 has started for PR 24232 at commit f371413.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16011/
Test PASSed.

Test build #110890 has finished for PR 24232 at commit f371413.

This patch fails to generate documentation.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110890/
Test FAILed.

retest this please

Test build #110905 has started for PR 24232 at commit f371413.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16023/
Test PASSed.

Test build #110905 has finished for PR 24232 at commit f371413.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110905/
Test FAILed.

Test build #110960 has started for PR 24232 at commit 84ccf55.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16065/
Test PASSed.

Test build #110961 has started for PR 24232 at commit e43033b.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16066/
Test PASSed.

Test build #110960 has finished for PR 24232 at commit 84ccf55.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110960/
Test FAILed.

Test build #110961 has finished for PR 24232 at commit e43033b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110961/
Test FAILed.

FYI: We might want to include the method for #25666.

retest this please

Test build #111034 has started for PR 24232 at commit 722f0e6.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16128/
Test PASSed.

Test build #111034 has finished for PR 24232 at commit 722f0e6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111034/
Test PASSed.

@ueshin Do you want to wait for #25666 to get sorted before moving forward with this? Or get this moving, then add the binding for the new filter overload in #25666?

@nvander1 We don't need to wait for #25666. It won't affect the current behavior but just add a new usage. We can do it in the separate PR.

@ueshin I think it's ready to go now then, pending maintainer review :)

Test build #111666 has started for PR 24232 at commit 1bf2654.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16661/
Test PASSed.

Test build #111669 has started for PR 24232 at commit 64c0f87.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16663/
Test PASSed.

Test build #111666 has finished for PR 24232 at commit 1bf2654.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111666/
Test PASSed.

Test build #111669 has finished for PR 24232 at commit 64c0f87.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111669/
Test FAILed.

Jenkins, retest this please.

Test build #111680 has started for PR 24232 at commit 64c0f87.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16674/
Test PASSed.

Test build #111680 has finished for PR 24232 at commit 64c0f87.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111680/
Test PASSed.

Thanks! merging to master.

+1 !


keyword "sécu" always return result but nothing contains "sécu" was indexed

Hi,
I user JsSearch to index some content to retrieve url page. In all environment "dev, ci, prod" the keyword search "sécu" return page content, not the same content for this 3 environment but its the same database that we fetcth the content to index with JsSearch. I have tryied to add this in stopKeywordMaps, but nothing is done, we retrieve some content with this keyword. Do you have any idea ? thx

Sorry, I can't help when there's no repro.

This is a bug!
When you search a word with an accent éèê... the search query contains "sécu" only "cu" is search inside the index and the result get more result instead of "sécu". We fix this by remove all accent inside the search query. I think that the char ';' create the problem

As I said right above, I don't investigate "bug" reports when there's no repro. If it's worth my time to spend looking into it, it's worth your time to spend creating a repro case that can be shared.
Before doing that, I suggest you also search other issues in this repo..

#51: The js-search doesn't compatibility with Persian language
#50: Searching for special characters
#43: UTF8 Support
#26: Punctuation and special characters seems to cause issues
#11: Add multiple language support to SimpleTokenizer


Feature/bocm 64 api endpoint for validation officer to mark incomplete or invalid with reason

Describe your changes
added error thrown on cases the reason is not stated or undefined if the appeal is invalid or incomplete
Issue ticket number and link
BOCM-64
API Endpoint for Validation Officer to mark "incomplete" or "invalid" with reason
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[ √] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[ √] I have performed a self-review of my own code
[ √] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[ √] I have provided details on how I have tested my code
[√] I have referenced the ticket number above
[ √] I have provided a description of the ticket
[ √] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


NO-TICKET: fix potential panic in ScopedInstrumenter::drop

Due to being run on systems with a non-monotonically-increasing clock, the drop implementation of the ScopedInstrumenter was seen to panic on rare occasions.
This PR resolves that issue by using a checked subtraction.
It also appears to be the only instance of elapsed() -  in our codebase.

bors merge

bors merge


pre roll ads fall out

[ ] some ads can be clicked, open in new tab, and ad pauses - there's no way to resume or skip (see slack)
[ ] do not load any ad stuff when signed in (https://tag.targeting.unrulymedia.com/rmp/216276/0/vast2?vastfw=vpaid&w=300&h=500&url=https://odysee.com/@Kona_and_Suba_Guinea_Pig_Adventures:c/this-is-peanut-the-guinea-pig:1 is called)
[ ] cut off at the bottom a bit and have a top black bar (https://lbryians.slack.com/archives/C81FGKR51/p1625678103453600?thread_ts=1625646978.442100&cid=C81FGKR51)
[ ] ads must have a skip button (Josh mentioned this)

Regression:

[ ] The issue of videos not switching correctly (previously fixed by restoring the double src call) is back again.
[ ] The "Retry" button is gone, so we are back to having to do a full reload or re-enter the page.  A retry almost always loads for me. Either fix to prevent this scenario, auto-retry, and put back the button?
[ ] Minor:  It doesn't make sense to keep spinning when it already failed (makes user think whether to wait or not). This was previously fixed.

We are getting more reports of adblockers blocking various calls/media on the page after we pushed this change, even when logged in. It may be related to the ad calls still getting made when logged in, but not sure. Reached out to adblocker.

Confirmed that my findings are causing issues for signed in users with pop up blockers due to the call still being made while signed in. This prevents the video from playing (probably just from this error, and potentially not from our domain being blacklisted)

Some others

[ ] don't load for signed in users: https://imasdk.googleapis.com/js/sdkloader/ima3.js
[ ] double head request causes double master playlist call:

@mayeaux this is an older ads issue, if it's not useful, please close it


Removing Storage Locations needs re-working/documentation

When you remove a Storage Location c5 has to move all the files back to the default storage location, if you have more than x number of files c5 has a hard time (time limit, memory limit) moving everything back into place, we should either setup an ajax/queue system, or put a bunch of warnings, or both!

Would it make sense to have a bulk migration tool available, and then just not let users remove storage locations so long as there are files associated with them?

I like that.

Add "storage location" to the advanced search dropdown to allow people to search by storage location.
Add "Choose Storage Location" to The bulk dropdown to allow storage location to be set for files in a bulk fashion.
Change delete storage location to not reassign on delete – instead, don't allow any storage location to be deleted if any files are associated with it.

1, Not hard
2, you still run into the time/memory limit issue unless a queue system is setup...
3, Easy

See also #5517


Latest release is missing from the Debian/Ubuntu bintray repository

Summary
It would appear the latest releases are missing from the Debian/Ubuntu Bintray repository. The only version available is 1.8.0. It would be good to have the latest release (1.8.2) available through the repository as well.
Environment

OS: Ubuntu 18.04

Related to #871 ?

We'll try to fix the bintray release workflow.

@martinhoefling Yes it is. The latest build, 1.8.2 is also not in the repo.

I believe this issue is still vaild.

It is, but it's also being tracked in #871


keystone container installation returns wrong endpoint addresses

Describe the bug
In case of keystone container installation, keystone returns '<IP_ADDRESS>' for all the endpoint addresses even if I set HOST_IP (not only 'host_ip'  in 'opensds-installer/ansible/group_vars/common.yml') on installation time. (Please see the screenshot below.)
This does not make sense, and I think ansible/scripts/keystone.sh needs additional endpoint configuration (at least). Actually, keystone.sh configures non INADDR_ANY IP addresses on
keystone devstack installation.
To Reproduce
I noticed this issue while trying to install opensds on Ubuntu 18.04 (not 16.04), but I believe the behavior should be the same.

Install opensds using  opensds-installer/ansible/site.yml

I reproduced 'deploy_project: hotpot' and 'install_keystone_with_docker: true' (default).

Install python-openstackclient
setup keystone authentication environment variables such as OS_AUTH_URL
execute 'openstack endpoint list'

Expected behavior
Keystone returns non INADDR_ANY(<IP_ADDRESS>) and appropriate IP addresses for endpoints.
Screenshots
[ubuntu@ubuntu213 ~(opensds)]$ set | grep OS_
OS_AUTH_URL=http://<IP_ADDRESS>/identity
OS_IDENTITY_API_VERSION=3
OS_PASSWORD=opensds@123
OS_PROJECT_DOMAIN_NAME=Default
OS_PROJECT_NAME=service
OS_USERNAME=opensds
OS_USER_DOMAIN_NAME=Default
[ubuntu@ubuntu213 ~(opensds)]$ openstack endpoint list  -c "Service Type" -c "URL"
+---------------+-------------------------------------------+
| Service Type  | URL                                       |
+---------------+-------------------------------------------+
| identity      | http://<IP_ADDRESS>/identity                   |
| identity      | http://<IP_ADDRESS>/identity                   |
| opensdsv1beta | http://<IP_ADDRESS>:50040/v1beta/%(tenant_id)s |
| opensdsv1beta | http://<IP_ADDRESS>:50040/v1beta/%(tenant_id)s |
| opensdsv1beta | http://<IP_ADDRESS>:50040/v1beta/%(tenant_id)s |
| multicloudv1  | http://<IP_ADDRESS>:8089/v1/%(tenant_id)s      |
| multicloudv1  | http://<IP_ADDRESS>:8089/v1/%(tenant_id)s      |
| multicloudv1  | http://<IP_ADDRESS>:8089/v1/%(tenant_id)s      |
+---------------+-------------------------------------------+

Hi Itoh-san, thanks for testing opensds-installer. @joseph-v, please have a look at this issue.

Hi @wisererik and @joseph-v , I can work on this topic, and please feel free assigning me to this issue if
this issue makes sense.

That's great, Itoh-san~

Hello @wisererik @joseph-v,
The below is my current patch for this issue.
https://github.com/thatsdone/opensds-installer/commit/a7d08c7ed770783168eecd0810adffe2f5e7dcfe
At the moment, I tested it on Ubuntu 16.04.6 (xenial, not bionic) cloudimage, and it looks like working at least for me.
But, but I have several discussion points.

I worked on the master branch because this is a bug fix. Need to use development branch?
I added several functions in ansible/scripts/keystone.sh, and these are keystone container installation specific ones (keystone_credentials, wait_for_keystone, update_keystone_endpoints). Is it better to move (some of) them to util.sh ?
I added 'python-openstackclient' installation step in order to update keystone endpoints. This causes more than 70 packages dependency installation. Is this acceptable?

BTW, is it better making a PR ASAP rather than discussing details here? ^^;

Hi Itoh-san, we work on master branch now.  Regarding  2-3, you can do by you own idea. Regarding 4 , I remeber someone has called openstack api in somewhere. Maybe the openstack-python-client has been installed.

Hi @wisererik,
Thanks for your comment.
Regarding python-opentackclient, AFAIK, keystone devstack installation uses it.
I added removal process too and I believe this is not a significant problem.
Anyway, I will make a PR today (in Tokyo time haha).


Fixed search icon issue in LTR languages

Issue Reference
Fixed search icon issue in LTR languages
Change the syntax of commenting

@shivendra-webkul It is working fine. Here


Add custom caption support for the Badge component

Adds support for custom captions to the Badge component which was called out in #108.
Also fixes issue where the is-new property, while bindable in the static "one-time" sense, would not dynamically reflect changes to the bound property because there was no handling of the binding change event to add/remove the CSS new class.

Thanks. 😃


Introduce default ASP.NET Core Web API template

Add the default template for an ASP.NET Core Web API project, with an example
resource that can be accessed at https://localhost:5001/example.

👍 Squashed in those changes @DrLazer


firefox doesn't have a .desktop file

I've noticed that I don't have a Firefox (Nightly) menu item in KDE after installation. There is an upstream bug (https://bugzilla.mozilla.org/show_bug.cgi?id=296568), but many distributions include their own .desktop files for improvement of user experience 1,2. Can't we do the same thing?

What do you mean by firefoxWrapper? I'm having the same problem

Use firefoxWrapper package instead of just firefox. This is a naming problem -- you shouldn't use just firefox as a user. Maybe we need this rename...


Fixed broken JSHint support

Couldn't get it to work with jshint by setting the option "linter" to "jshint" (it was ignored and jslint was executed). So I added a fix in jshint-linter.js that fixed the problem for me.

Thanks for the fix! :-)


MariaDB is aborting always

even if you restart the container, it always aborts, i change the label to the last one to see if this worked but keep doing the same

Hi, @uebmaster.  First, you can check - https://github.com/a-kom/docker-compose-lamp/issues/4. Second, Could you provide your docker-compose.yml file? Also, please provide your docker toolbox version, windows version and would be good to have an archive that you use to run.

This works for me but changing to mysql
docker-compose stop && docker-compose rm -f
Remove folder docker/runtime/mysql
Run docker-compose up -d
I'm not sure if this help in this case, but you'll recreate from scratch and run on clean docker containers.
Also, I'll check this on Windows today later.

i am not using docker toolbox, i am using docker for windows, windows 10 pro, and i am using your repository cloned.
Thanks for reply.

Hi @uebmaster, I'm glad that this help. If you want to continue using mariadb you could try to change the mariadb:10.0 to simple mariadb? I think it could help too.

I tried but doesn’t Works, only with mysql works
Enviado desde Correohttps://go.microsoft.com/fwlink/?LinkId=550986 para Windows 10
De: Andriy<EMAIL_ADDRESS>Enviado: miércoles, 14 de febrero de 2018 02:03 p. m.
Para<EMAIL_ADDRESS>CC<EMAIL_ADDRESS><EMAIL_ADDRESS>Asunto: Re: [a-kom/docker-compose-lamp] MariaDB is aborting always (#5)
Hi @uebmasterhttps://github.com/uebmaster, I'm glad that this help. If you want to continue using mariadb you could try to change the mariadb:10.0 to simple mariadb? I think it could help too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/a-kom/docker-compose-lamp/issues/5#issuecomment-365728334, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFTsQnLoLhzLIB3QLD_cX3S1AniTHhb7ks5tUzwegaJpZM4SDGv1.


Duplicate help tag "navic.attach" in doc/navic.txt

Duplicate tag "navic.attach" in file doc/navic.txt when generating doc tags

Hey @rafi
Can you share where is the duplication of tag? I am not that well versed with vimdocs...

@SmiteshP created PR #28


[chainerx][tests] fix skipped_backward tests to return as PASS

If skip_backward/skip_double_back is False, the test
is marked as skipped, even when the Forward is checked
and passes successfully. This change will make sure that,
even these tests are marked as PASS by Pytest.
I have a feeling that I saw an issue regarding the same.
But I am unable to find it. Would put a reference to it if
I am able to do so.

Had no clue there were tests for test functions. Nice. Will set status to WIP till I figure what's going wrong.

@hvy Please review.

Thanks for the PR. I agree that the current behavior can be improved. I'm wondering though if the current change will cause a test to be marked as passed even when all of forward, backward and double backward tests are skipped. Shouldn't we simply generate separate results/tests for each of them? That's consistent with how unittest.TestCase behaves and wouldn't be any ambiguous. cc @niboshi

@hvy

Shouldn't we simply generate separate results/tests for each of them?

Currently the three tests (forward/backward/double-backward) run sequentially in order to test expected errors (i.e. in op_utils.NumpyOpTest). In such tests, it should be checked that ChainerX impl. raises errors similarly to numpy, in forward call. If the error is detected, subsequent backward/double-backward tests must be skipped. It couldn't be possible if tests of the three were separated.

Sorry this is not a direct answer to the comment above but I'd like to clarify if this PR addresses the FunctionTestCase (not ChainerX-related) or the op_test (ChainerX). I think we want to fix the latter while keeping the former as it is?

@hvy @niboshi  Sorry I don't know much about the tests in Chainer, but are there other cases besides, forward, backward, double-backward. If all three are skipped due to the class being marked with skip or skip-if, then the test would be marked as skipped. While if all are skipped manually then it is due to the writer's conscious decision, in which case test being marked as Success doesn't seem wrong?
Do let me know if I am understanding anything incorrectly.

@kshitij12345 No, forward, backward and double backward are the only ones. And yes, that's a point too. We had a general offline discussion within the team and though that it'd be better for now to leave the Chainer tests as they are, while changing the ChainerX tests (OpTest) to be rendered as PASS in case skip_backward / skip_double_backward is True. In case skip_forward is True, we should render it as SKIP. Does that make sense? And if so, could you adapt your implementation to it?
The points is that the OpTest is running all of forward, backward and double backward tests in a single test. On the other hand, Chainer's tests using FunctionTestCase separates the above three into different tests with their different results of PASS/SKIP/etc. So we have to treat the slightly differently although they're using the same skip_... flags. Ideally, we should consider a common test utilities for both Chainer and ChainerX.

Oh I see.

There are some errors. Will try to fix and notify.

@hvy Please review

Jenkins, test this please.

Jenkins CI test (for commit<PHONE_NUMBER>124610164a260554cefabac8d5e902, target branch master) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit<PHONE_NUMBER>124610164a260554cefabac8d5e902, target branch master) failed with status FAILURE.

Jenkins, test this please.

LGTM except the comment above. Could you take a look?

Jenkins CI test (for commit<PHONE_NUMBER>124610164a260554cefabac8d5e902, target branch master) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit d00a991e4a5ea6c14641bc718173f18093ddde6b, target branch master) succeeded!

https://github.com/chainer/chainer/projects/2#card-19090847


Add a note about SignalR Hub.OnDisconnectedAsync method

Internal previews

📄 File
🔗 Preview link

aspnetcore/signalr/hubs.md
Use hubs in SignalR for ASP.NET Core

Thanks @5kuper. but we'll close on that basis.


Multi currency price for product

We should be able to specify a price for a product in a currency instead of relying on exchange rate
Lets assume the case we have both $ and € configured as currency
One product is priced at 9.99$
The exchange rate is 0.88 and would result in a price of 8.87€
So by default if the product has only a $ price that should be displayed, however it would be nice to be able to override this price per currency per product so that for instance the price could be set to 8.99€ for this particular product without having to change the exchange rate

Not feasible, you can customize if you want


use special Scala 2.11 sources for 2.12 too

I don't know if copying these sources is the ideal way to resolve this
-- y'all can decide for yourselves. but I need some change along these
lines in order to resume tracking Spire's master branch in the Scala
2.12 community build.
note that CrossVersion.partialVersion will do the right thing even
for Scala milestones and RCs, weird dbuild-generated community
build Scala version numbers, etc.

Current coverage is 48.48% (diff: 100%)

Merging #587 into master will increase coverage by 0.39%

@@             master       #587   diff @@
==========================================
  Files           181        181
  Lines         11471      11471
  Methods        9808       9808
  Messages          0          0
  Branches       1619       1619
==========================================
+ Hits           5517       5562    +45
+ Misses         5954       5909    -45
  Partials          0          0

Powered by Codecov. Last update b47651b...14c525f

Here's one way to dedup if anyone is interested: https://github.com/milessabin/shapeless/blob/6cbe70e43e38a9c6f340aa0f2dc2065e6c8685a5/build.sbt#L200-L210


Run bundle install automatically after releasing a new. gem version

As it stands, running release task https://github.com/shakacode/shakapacker/blob/master/rakelib/release.rake doesn't do anything to update local Gemfile.lock file with new version.
Missing Gemfile.lock update means that the tests fail (as we're running bundle install with deployment flag https://github.com/shakacode/shakapacker/runs/6512746968?check_suite_focus=true) and we need to run bundle install and commit result after each release to make sure everything works as expected.
We should modify or create a new rake task that commits the new version change and runs bundle install after gem is released to streamline this process.
cc @justin808

@tomdracz any chance that you can throw in a PR for this?


feat(csproj parser): alternative fallbacks for resolving target framework

There are multiple ways of specifying target framework in dotnet projects. Implement fallbacks if TargetFramework is not found in *.csproject
//Directory.build.props
<Project>
  <PropertyGroup>
    <TargetFramework>net8.0</TargetFramework>
  </PropertyGroup>
</Project>

//global.json
{
  "sdk": {
    "version": "6.0.100",
    "rollForward": "latestFeature",
    "allowPrerelease": false
  }
}

Addresses:

#108

Turns out I misunderstood the documentation. The build props and global json files are just guards so the TargetFramework is mandatory in the csproject file anyways

Double sike, you can specify TargetFramework in Directory.Build.props and not have to set it in the .csproject file.


[REQ] immediately return from status page

This is a hacky example of the behavior I'm proposing in #534

I expect a proper implementation to take some toggle in the settings as well as maybe a more unified behavior when opening profiles etc. I think I can take care of that if this should become a proper feature.

This should have already been fixed with aa54d3a19e27b010593b4798354382340f5a67ca. Can you confirm that it still isn't working with that fix in place?

No, building straight from master does not show the home screen. This PR and issue is redundant then.
I had tested on the latest beta and stable release when I decided to fix this. Didn't expect this to work correctly on master, but that's a nice surprise!

Since this is already done I'll just close this. Thanks for your quick reply!

Great, no worries. Thanks for the PR anyway!


Add vggface2 dataset

Closes issue #1139.
There was a PR for this last year but it never got approved and finalized. Since the design of the Dataset classes has changed quite a bit since then, I thought I would submit this more updated version for review.
Notable changes:

The dataset class uses bbox and landmark annotations that are available on the VGGFace2 website. From what I can tell, these are the only annotations that are available for all identities in the dataset. Other annotation information is available but only for a subset of face identities.
No preprocessing of the dataset is performed. This option is left up to the user who can freely define transform, target_type and target_transform in order to make whatever changes they want.

cc @fmassa @dakshjotwani

Thanks for bringing this PR back to life :)
Can we add test cases for VGGFace2 similar to the imagenet dataset? I remember I was about to do them for my PR before we forgot about it.

Unit tests have been added and tested.

This PR is as ready-to-go as it gets I think. Unless someone has an issue with return types or documentation suggestions, I don't have anything else to add.

Before more work is done on this PR, we should wait to see if the dataset is made available again. Looks like the dataset has been taken down for almost a month.
VGGFace2 citation count: 912

Before more work is done on this PR, we should wait to see if the dataset is made available again. Looks like the dataset has been taken down for almost a month.
VGGFace2 citation count: 912

This is a new dataset request and will be added to the new dataset API once it is stable enough. In the meantime, we will close the current PR (don't worry, the code will be reused at some point in the new dataset design to integrate it). @pmeier

To complement @yassineAlouini's comment:
I'm not sure how I missed this PR since it seems complete. I'm very sorry about that @jgbradley1. Unfortunately, we are moving to a new datasets API in the near future and thus, we will no longer accept PRs that add new datasets to the old API. There are two options now:

Given that you already put in the work in this PR, we would happily accept a new PR adding this to the new API. You can refer to this guide on how to do that.
Someone else could take this over and build on what you have done. In this case I will make sure to credit you properly.

How would you like to go about it @jgbradley1?


Beta Page is down since July/09/2017

Hi.
I love your page. But since your update for stormblood is the site not available. Please check it out.
Bye

The page is just white with google chrome. With microsoft edge it just works fine.

Try holding down Ctrl and Shift and clicking the Reload button in Chrome.

working here.

working in Chrome here also.

[Error] Error: null is not an object (evaluating 'response.data.action') http://ffxiv-beta.lokyst.net/js/services/xivdbtooltips.js:42:39 [native code] K@https://ajax.googleapis.com/ajax/libs/angularjs/1.2.32/angular.min.js:102:156 https://ajax.googleapis.com/ajax/libs/angularjs/1.2.32/angular.min.js:103:322 $digest@https://ajax.googleapis.com/ajax/libs/angularjs/1.2.32/angular.min.js:111:173 https://ajax.googleapis.com/ajax/libs/angularjs/1.2.32/angular.min.js:114:186 e@https://ajax.googleapis.com/ajax/libs/angularjs/1.2.32/angular.min.js:37:502 https://ajax.googleapis.com/ajax/libs/angularjs/1.2.32/angular.min.js:41:362 	(anonymous function) (angular.min.js:69) 	K (angular.min.js:102:184) 	(anonymous function) (angular.min.js:103:323) 	$digest (angular.min.js:111:174) 	(anonymous function) (angular.min.js:114:187) 	e (angular.min.js:37:503) 	(anonymous function) (angular.min.js:41:363)
[Error] Failed to load resource: the server responded with a status of 404 (HTTP/2.0 404) (angular-ui-router.js.map, line 0) https://cdnjs.cloudflare.com/ajax/libs/angular-ui-router/1.0.0-rc.1/angular-ui-router.js.map
XMLHttpRequest cannot load https://secure.xivdb.com/tooltip?language=en&list[action]:=100090,100030,100015,100001,100105,100075,100045,100060,100096,100037,100021,100007,100111,100080,100051,100067,100083,100063,100069,100039,100033,100091,100031,100016,100002,100106,100076,100046,100061,100093,100034,100018,100004,100109,100078,100048,100064,100097,100038,100022,100008,100112,100081,100052,100068,100108,100009,286,276,100092,100032,100017,100003,100107,100077,100047,100062,100094,100035,100019,100005,100110,100079,100049,100065,279,285,278,258,254,253,252,259,255,257,256,250,246,245,244,251,247,249,248,281,277,283,266,262,261,260,267,263,265,264,284,100098,100126,100122,100121,100120,100127,100123,100124,100125,100134,100130,100129,100128,100135,100131,100132,100133,100178,100136,100175,100171,100170,100169,100176,100172,100173,100174,100193,100189,100188,100187,100194,100190,100191,100192,100143,100139,100138,100137,100144,100140,100141,100142,100159,100155,100154,100153,100160,100156,100157,100158,100151,100147,100146,100145,100152,100148,100149,100150,100167,100163,100162,100161,100168,100164,100165,100166,100050,100020,100036,100066,100095,100006,4571,4569,4570,4572,4573,4568,100201,100197,100196,100195,100202,100198,100199,100200,100209,100205,100204,100203,100210,100206,100207,100208,100217,100213,100212,100211,100218,100214,100215,100216,100225,100221,100220,100219,100226,100222,100223,100224,4580,4576,4575,4574,4581,4577,4578,4579,100233,100229,100228,100227,100234,100230,100231,100232,100241,100237,100236,100235,100242,100238,100239,100240,100249,100245,100244,100243,100250,100246,100247,100248,100257,100253,100252,100251,100258,100254,100255,100256,100265,100261,100260,100211,100259,100262,100263,100264,100273,100269,100268,100267,100274,100270,100271,100272,100281,100277,100276,100275,100282,100278,100279,100280,50356,50352,50351,50350,50357,50353,50354,50355,100099,100040,100023,100010,100113,100082,100053,100070 due to access control checks.

That looks like it's failing to load tooltips from XIVDB. I'll have a look.

Probably unrelated, but the entire page is down as of 07/16/2017:

@Fenrirthviti We recently changed webhosts so you may still be getting the old DNS. You could try running ipconfig /flushdns from a command window if you're on Windows, but I'm not really sure if that will help. I had to restart my own router to get it to pick up the new DNS after we moved the site.

I think the tooltip issue is because you're not running the beta page http://ffxiv-beta.lokyst.net/#/simulator on https. You either need to load the http tooltip lib, or setup a free https://letsencrypt.org/ https on your server.

The issue is intermittent. If it was because of http vs https it would occur more consistently.
My suspicion is that there's a bug or some other unexplained behavior in the XIVDB API server which causes it to return a 404 Not Found response sometimes when the app requests all the tooltips.
Have you seen this issue recently?

I had a similar issue, my server was https and the default example was http, plus he had to tweak a few things related to reading his own api.

Embed the script: http://xivdb.com/tooltips.js anywhere in your code. eg:

<html>
    <head>
        ...
    </head>
    <body>
        ...
        <script src="https://secure.xivdb.com/tooltips.js"></script>
    </body>
</html>

Note his initial quote is not from secure, try using that url.

Ah, I see. I'm not using http://xivdb.com/tooltips.js -- I wrote my own Javascript (as an AngularJS service) which fetches the tooltip data from the XIVDB API using the same method that http://xivdb.com/tooltips.js does.
This was mainly because the majority of what http://xivdb.com/tooltips.js does is implement the necessary DOM hijinks to create the effect of tooltips -- I have AngularJS and Angular-Bootstrap-UI to do that. :)
My service could probably be a bit smarter about fetching tooltip contents on-demand though. Right now it fetches everything in one request, which takes a noticeable amount of time, and may be too much data to ask for in one request.

I've reworked the way tooltips are loaded from XIVDB, so hopefully this problem should be resolved.


Installation fails

Installation fails in Ansible AWX 9.1.0 Environment
/tmp/node_exporter-0.18.1.linux-amd64.tar.gz => exists on the target node after run
TASK [cloudalchemy.node-exporter : Download node_exporter binary to local folder] ***
ok: [elab-leaf1 -> {{ inventory_hostname }}.{{ host_domain }}]
ok: [elab-spine2 -> {{ inventory_hostname }}.{{ host_domain }}]
ok: [elab-spine1 -> {{ inventory_hostname }}.{{ host_domain }}]
ok: [elab-leaf3 -> {{ inventory_hostname }}.{{ host_domain }}]
ok: [elab-leaf4 -> {{ inventory_hostname }}.{{ host_domain }}]
ok: [elab-leaf2 -> {{ inventory_hostname }}.{{ host_domain }}]
ok: [elab-extleaf1 -> {{ inventory_hostname }}.{{ host_domain }}]
ok: [elab-egress-leaf1 -> {{ inventory_hostname }}.{{ host_domain }}]
ok: [elab-egress-leaf2 -> {{ inventory_hostname }}.{{ host_domain }}]
TASK [cloudalchemy.node-exporter : Unpack node_exporter binary] ****************
fatal: [elab-spine2 -> {{ inventory_hostname }}.{{ host_domain }}]: FAILED! => {"changed": false, "msg": "Could not find or access '/tmp/node_exporter-0.18.1.linux-amd64.tar.gz' on the Ansible Controller.\nIf you are using a module and expect the file to exist on the remote, see the remote_src option"}
fatal: [elab-leaf1 -> {{ inventory_hostname }}.{{ host_domain }}]: FAILED! => {"changed": false, "msg": "Could not find or access '/tmp/node_exporter-0.18.1.linux-amd64.tar.gz' on the Ansible Controller.\nIf you are using a module and expect the file to exist on the remote, see the remote_src option"}
fatal: [elab-spine1 -> {{ inventory_hostname }}.{{ host_domain }}]: FAILED! => {"changed": false, "msg": "Could not find or access '/tmp/node_exporter-0.18.1.linux-amd64.tar.gz' on the Ansible Controller.\nIf you are using a module and expect the file to exist on the remote, see the remote_src option"}
fatal: [elab-leaf3 -> {{ inventory_hostname }}.{{ host_domain }}]: FAILED! => {"changed": false, "msg": "Could not find or access '/tmp/node_exporter-0.18.1.linux-amd64.tar.gz' on the Ansible Controller.\nIf you are using a module and expect the file to exist on the remote, see the remote_src option"}
fatal: [elab-leaf4 -> {{ inventory_hostname }}.{{ host_domain }}]: FAILED! => {"changed": false, "msg": "Could not find or access '/tmp/node_exporter-0.18.1.linux-amd64.tar.gz' on the Ansible Controller.\nIf you are using a module and expect the file to exist on the remote, see the remote_src option"}
fatal: [elab-leaf2 -> {{ inventory_hostname }}.{{ host_domain }}]: FAILED! => {"changed": false, "msg": "Could not find or access '/tmp/node_exporter-0.18.1.linux-amd64.tar.gz' on the Ansible Controller.\nIf you are using a module and expect the file to exist on the remote, see the remote_src option"}
fatal: [elab-extleaf1 -> {{ inventory_hostname }}.{{ host_domain }}]: FAILED! => {"changed": false, "msg": "Could not find or access '/tmp/node_exporter-0.18.1.linux-amd64.tar.gz' on the Ansible Controller.\nIf you are using a module and expect the file to exist on the remote, see the remote_src option"}
fatal: [elab-egress-leaf1 -> {{ inventory_hostname }}.{{ host_domain }}]: FAILED! => {"changed": false, "msg": "Could not find or access '/tmp/node_exporter-0.18.1.linux-amd64.tar.gz' on the Ansible Controller.\nIf you are using a module and expect the file to exist on the remote, see the remote_src option"}
fatal: [elab-egress-leaf2 -> {{ inventory_hostname }}.{{ host_domain }}]: FAILED! => {"changed": false, "msg": "Could not find or access '/tmp/node_exporter-0.18.1.linux-amd64.tar.gz' on the Ansible Controller.\nIf you are using a module and expect the file to exist on the remote, see the remote_src option"}

{
    "group": "ansible-cumulus",
    "uid": 999,
    "url": "https://github.com/prometheus/node_exporter/releases/download/v0.18.1/node_exporter-0.18.1.linux-amd64.tar.gz",
    "changed": false,
    "elapsed": 0,
    "dest": "/tmp/node_exporter-0.18.1.linux-amd64.tar.gz",
    "state": "file",
    "gid": 997,
    "mode": "0644",
    "invocation": {
        "module_args": {
            "directory_mode": null,
            "force": false,
            "remote_src": null,
            "path": "/tmp/node_exporter-0.18.1.linux-amd64.tar.gz",
            "owner": null,
            "follow": false,
            "client_key": null,
            "group": null,
            "use_proxy": true,
            "unsafe_writes": null,
            "serole": null,
            "content": null,
            "validate_certs": true,
            "setype": null,
            "client_cert": null,
            "timeout": 10,
            "url_password": null,
            "dest": "/tmp/node_exporter-0.18.1.linux-amd64.tar.gz",
            "selevel": null,
            "force_basic_auth": false,
            "sha256sum": "",
            "http_agent": "ansible-httpget",
            "regexp": null,
            "src": null,
            "url": "https://github.com/prometheus/node_exporter/releases/download/v0.18.1/node_exporter-0.18.1.linux-amd64.tar.gz",
            "checksum": "sha256:b2503fd932f85f4e5baf161268854bf5d22001869b84f00fd2d1f57b51b72424",
            "seuser": null,
            "headers": null,
            "delimiter": null,
            "mode": null,
            "url_username": null,
            "attributes": null,
            "backup": null,
            "tmp_dest": null
        }
    },
    "owner": "ansible-cumulus",
    "checksum_src": null,
    "size": 8083296,
    "checksum_dest": null,
    "msg": "file already exists",
    "_ansible_no_log": false,
    "attempts": 1,
    "_ansible_delegated_vars": {
        "ansible_host": "{{ inventory_hostname }}.{{ host_domain }}"
    }
}

/tmp/node_exporter-0.18.1.linux-amd64.tar.gz => exists on the target node after run

It should exist on the controller node, not on target.

Yes, thats the Problem.

Am 13.12.2019 um 17:12 schrieb Paweł Krupa<EMAIL_ADDRESS>
/tmp/node_exporter-0.18.1.linux-amd64.tar.gz => exists on the target node after run
It should exist on the controller node, not on target.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Sorry, I cannot reproduce this. All tasks which download tarball are delegated to localhost (as seen in https://github.com/cloudalchemy/ansible-node-exporter/blob/master/tasks/install.yml#L41). If this doesn't download a tarball to your controller host, then it looks more like the issue with AWX or your specific configuration.


Showing "No Result Found"

When performing a search, if no icon is found, the system should display a "No results found" message instead of showing a blank page.
I would like to work on this issue.

Sure @TusharUtane07, please go ahead and make sure to commit in your separate branch and tag this issue to your PR.


Add check and test for invalid inline img src

Fixes #107

Codecov Report

Merging #109 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   91.41%   91.47%   +0.06%
==========================================
  Files          21       21
  Lines         839      845       +6
==========================================
+ Hits          767      773       +6
  Misses         72       72

Impacted Files
Coverage Δ

opwen_email_server/utils/email_parser.py
93.91% <100%> (+0.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f25293...fc43d22. Read the comment docs.


Cannot restore to fresh install

So I set up Bookstack with the Ubuntu 16.04 installation script. It worked well. I then used it for a week or so and then followed the backup instructions. So far so good. Now I am trying to restore it and I am running into issues.
Fresh Ubuntu 16.04 VM. Run installation script. Bookstack installs fine. I check the .env file for current bookstack mysql user password. run the mysql restore using the bookstack user. No issues there. Now the web interface says "something went wrong". Restore the files based backup. Still says something went wrong. Try and run php artisan migrate get error about permission. the .env file is from my old installation. Change the password in mysql or in the .env. Now rerun the php artisan migrate and i get the following error and is where i get stuck.
  [Illuminate\Database\QueryException]
  SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'attachments' already exists (SQL: create table `attachments` (`id` int unsigned not null auto_increment primary key, `name`
   varchar(255) not null, `path` varchar(255) not null, `extension` varchar(20) not null, `uploaded_to` int not null, `external` tinyint(1) not null, `order` int not null, `created_by` int
  not null, `updated_by` int not null, `created_at` timestamp null, `updated_at` timestamp null) default character set utf8 collate utf8_unicode_ci)

  [PDOException]
  SQLSTATE[42S01]: Base table or view already exists: 1050 Table 'attachments' already exists

For Bug Reports
PHP Version: PHP 7.0.8-0ubuntu<IP_ADDRESS>
MySQL Version: mysql  Ver 14.14 Distrib 5.7.16, for Linux (x86_64) using  EditLine wrapper
Expected Behavior: I was expecting to be able to restore my data from a previous install
Actual Behavior: See above

Hi @the4ndy, Sorry to hear you're having trouble with the restore.
Looking at what you've written I think I can spot the issue here. I think your backup was done on an older version of BookStack which you've restored into a new version of BookStack. The install script would have run the migrations on the latest version of BookStack thus creating the attachments table. You're restore will likely have not removed this table but kept it since the old data did not contain this table. When you've come to run migrations it's trying to create the table which has already been created by the install script.
Your best bet is to drop all tables in you BookStack database before you restore (If your SQL backup contains CREATE TABLE statements). Alternatively you may get away with just dropping the attachments table before migrating.
Let me know if I've understood this wrong or if this above solutions work.

Will close due to issue age and lack of response. If you have further issues feel free to still comment on this or create a new issue.


OrderID type where ClientID should be used

Hi.
Attached is a patch to replace attribute type definitions for client IDs fields  'OrderID' -> 'ClientID' (OrderID is int, while client IDs could be any string).
Additionally, a couple of attributes are added to model definitions where Oanda API documentation seems to be missing definitions comparing to actual implementation.
Thanks,
Gregory.
clientid.txt

Thanks for the issue,
I'd be more than happy to accept a pull request for this.
Well done on identifying additional attributes that are not documented. I'm sorry to see that this is still occurring years after I reached out to OANDA about it.
Regards


Define Ratio(Complex) type

[ ] Ratio and Complex Type

[ ] Create ratio.rs module on erg_common

[ ] Create fraction instead of float

[ ] Create complex by using ratio.rs
[ ] Add Ratio and Complex type to ValueObj
[ ]  Define the ratio again in _erg_prelude_std.py using Python's fraction module

#215


tests for chrome extension

This pull request addresses the addition of a new test case for the Chrome extension. The test case is designed to ensure the stability and functionality of the extension under specific conditions.
those tests are written using jasmine .
Added a new test case in the "spec" directory.
Added necessary test data and assertions to verify the expected behavior.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Remove any hardcoded libraries, like jasmine

Remove Jasmine Files may cause the dependencies  failure .Running Spec depend on the Jasmine  module and inside working directory the paths are defined specifically for that files.but let me try this .let you know if it work or not .

It’s not an option. If you must modify the build to pull it down that’s
fine. But no checking it in

okay i will update the repo and remove the hard-coded files  after i test the extension.


Typed errors for CEM scripts

Now errors in transitions are encoded as error strings. Thus transitionSpec has Either BuiltinString ... datatype. We need to use structural error instead of BuiltinString.
TODO:

[ ] Add associated type Error to CEMScript and Plutus.Show (?) constraint for showing it on-chain
[ ] Change Either left in transitionSpec to it, add show to on-chain code (genericCEMScript), make all examples compile again

This may be not needed in presence of #24


Discharge fails if any indices have been invalidated.

Discharge works with DenseIndexInfos, meaning if any parameters/events/ports have been invalidated before discharge this throws an error. The culprit is here:
https://github.com/cucapra/filament/blob/2fe2b317fc96ed6453dada529c08289ad08ec4f6/crates/filament/src/ir_passes/discharge.rs#L591-L608
This causes issues because .ports and .events automatically only iterate over valid indices. We can solve this in two ways:

Some sort of "cleanup" pass that removes invalid indices (likely having to reconstruct the entire IR)
Change .push to extend the DenseIndexInfo by default. This does not work in the case of discharge though, where SExpr is not Default.

Even larger issue now is that Exprs can exist that refer to invalid parameters that have been deleted... Classic dangling pointers.

Yup, arena allocators are hard... Maybe time to switch to a crate for this or something.


fix ingress yaml invalid structure due to missing newlines

With version 5.1.4 helm template --set ingress.enabled=true cockroachdb fails due to newlines getting removed too eagerly. This fixes the issue.
A test that would catch the regression would be useful.  This time around i did test and verify with the above helm template command that the ingress template renders correctly.
I contributed to the grafana chart before, they use https://github.com/helm/chart-testing for testing the chart more thoroughly for PRs. Perhaps useful to have a look at.

Fixes regression caused by https://github.com/cockroachdb/helm-charts/issues/59


NODE_PATH does not support absolute paths

Is this a bug report?
No, it is asking for explicit support for a pattern I was using before create-react-app that appears to be have been explicitly disabled.
What I am requesting is removing the relative path limitation from the react-scripts NODE_PATH support. I don't know of any particular reason why absolute paths would be a bad thing in this context -- one of the reasons people use NODE_PATH is to move the node_modules folder around inside of Docker containers. It would be great if this was supported by react-scripts.
See also #4442. More details below.
Which terms did you search for in User Guide?
NODE_PATH which leads to Advanced Configuration:

Same as NODE_PATH in Node.js, but only relative folders are allowed. Can be handy for emulating a monorepo setup by setting NODE_PATH=src.

The long and short of it is that I am building a react app inside of a Docker container. The setup is not complicated but one of the annoying side-effects of running Docker with Node is that the node_modules folder contains binaries that have to be rebuilt inside of the container. IDEs expect node_modules to exist for various features so the node_modules sibling of package.json is typically used for the non-Docker environment and NODE_PATH is used to keep the installed packages separated within the container.
Example tutorials all referencing this pattern (after a 5 min search):

https://medium.com/the-human-effort/getting-docker-node-and-npm-to-play-nice-a61c0c2c516a
https://semaphoreci.com/community/tutorials/dockerizing-a-node-js-web-application
https://stackoverflow.com/a/40886122/207247

All of these expect NODE_PATH to be set to the absolute path of the node_modules location inside of the Docker container. My particular configuration looks like this:

Dockerfile
FROM node:8

RUN apt-get update && \
    apt-get upgrade -y && \
    apt-get install -y \
        supervisor \
    && \
    rm -rf /var/lib/apt/lists/*

RUN mkdir -p /opt/centriam/logs
RUN touch /opt/centriam/logs/supervisord.log

######
# This is a node_modules hack to workaround docker-compose volume quirks
# https://github.com/docker/compose/issues/4934
# https://github.com/docker/compose/issues/2127
#
# We need to run npm install from inside the container and it has far
# fewer problems when running during image build.

# Create a separate location for node_modules
WORKDIR /modules
# Add this location to the NODE_PATH
ENV NODE_PATH /modules/node_modules
# Install using package.json (will break any local dependency references)
COPY package.json .
COPY package-lock.json .

RUN npm install --progress=false --loglevel=notice
# Add .bin to PATH to enable npm run scripts
ENV PATH $PATH:/modules/node_modules/.bin

WORKDIR /opt/centriam/client
COPY . /opt/centriam/client

ENTRYPOINT ["/opt/centriam/client/docker-start.sh"]
CMD ["start"]

./docker-start.sh
# snipped
if $test ; then
    CI=true npm run test

    status=$?
    if [ $status -ne 0 ]; then
        echo -e "${YELLOW}npm run test${NC} ${RED}failed${NC}"
        exit $?
    fi
fi

package.json
{
  "name": "reporting-client",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "node-sass": "^4.10.0",
    "react": "^16.6.3",
    "react-dom": "^16.6.3",
    "react-scripts": "2.1.1"
  },
  "scripts": {
    "start": "NODE_PATH='../../../modules/node_modules' react-scripts start",
    "build": "react-scripts build",
    "lint": "eslint . --report-unused-disable-directives --quiet",
    "test": "NODE_PATH='../../../modules/node_modules' react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": [
    ">0.2%",
    "not dead",
    "not ie <= 11",
    "not op_mini all"
  ]
}

Note that package.json uses NODE_PATH='../../../modules/node_modules'. It shouldn't have to do this. NODE_PATH is already set in the environment via Dockerfile but it is correctly set to an absolute path. This absolute path is explicitly rejected by react-scripts.
Therefore, I have to include an incredibly awkward hack to trick react-scripts into using the absolute NODE_PATH.

The purpose of NODE_PATH is to tell the environment where to get node_modules. I have my environment configured correctly and react-scripts is not respecting it properly.
Making NODE_PATH relative isn't the weirdest thing I've had to do to get a framework working but it definitely smells weird. It doesn't play well with a fairly traditional Docker + Node setup. More annoyingly, it broke without informing me what went wrong. I understand that workarounds are sometimes needed but some sort of warning that my NODE_PATH was being explicitly ignored would have been nice.
In any case, I am planning on looking into the GLOBAL_FOLDERS options noted in the Node documentation to see if that will work for what I need.


Free trades for thor holders.

AC

utilize snapshot API to get thor voting power as of any time before the proposal is posted (today / tonight)
Feature flag for launch
any voting power greater than 1 human unit gets free trades on shapeshift while that wallet is connected
expires end of UTC year programatically
mix panel event fired for a user that completes a discounted swap based on THOR holdings

https://discord.com/channels/554694662431178782/920449863408287855/1300581700916740177

We need to consider the modal when a user clicks on Free for ShapeShift Fee.
The easiest lift would be to turn it off for now, until we figure out a solution that handles more than just FOX.


dead link

Chrome and Edge

Thanks!
Fixed: http://www.syntaxsuccess.com/angular-2-samples/#/demo/spreadsheet


Docs have conflicting information regarding customization

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
On the docs it shows:

Variable overrides must come after our functions are imported, but before the rest of the imports.
https://getbootstrap.com/docs/5.2/customize/sass/#variable-defaults

But the docs then link to a starter package which doesn't follow this rule:
https://github.com/twbs/bootstrap-npm-starter
https://github.com/twbs/bootstrap-npm-starter/blob/2258953be2d3bed2edfdee796aa7da9a550b3faf/scss/starter.scss#L33
I am wondering if this is a mistake, are the docs right, or is it outdated? If we can clarify this in the docs so it doesn't confuse others like it did me, that would be great.
Reduced test cases
None
What operating system(s) are you seeing the problem on?
Windows, macOS, Android, iOS, Linux
What browser(s) are you seeing the problem on?
Chrome, Safari, Firefox, Microsoft Edge, Opera
What version of Bootstrap are you using?
v5.2.0

Thanks for reporting this issue @NuktukDev
In https://github.com/twbs/bootstrap-npm-starter/blob/2258953be2d3bed2edfdee796aa7da9a550b3faf/scss/starter.scss#L33, the overridden Sass variables don't use the functions, so it's not really an issue (even if it should follow what's said in the doc).
In our current documentation (v5.3.3), it's already fixed as:

https://getbootstrap.com/docs/5.3/customize/sass/#variable-defaults mentions the Sass & JS example instead of https://github.com/twbs/bootstrap-npm-starter/ that is now archived
https://github.com/twbs/examples/blob/main/sass-js/scss/styles.scss defines the colors correctly

v5.2 documentation won't be updated as it's an old version now, so please rather follow what's described in the v5.3: https://getbootstrap.com/docs/5.3/customize/sass/#variable-defaults + https://github.com/twbs/examples/blob/main/sass-js/scss/styles.scss


Updated Travis script.

r? @vinipsmaker
(maidsafe_highfive has picked a reviewer for you, use r? to override)


feat(convert): export ENV vars

We could have passed these into the "build_env:" directive, however it appears environment substitution is also allowed such as PATH=/usr/local/sbin:$PATH for that layer, which is harder to figure out. Instead just "export" them in the "run:" directive.
Signed-off-by: Ramkumar Chinchani<EMAIL_ADDRESS>
What type of PR is this?

Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This is an interesting change. If I understand it correctly, it is so that you can support the following line from here:
ENV PATH /usr/local/bin:$PATH

What is most surprising about it is that it seems to me that the above line is almost certainly wrong. If it is setting the PATH environment to be used inside the container, then why would you consult the hosts value of PATH? It should just explicitly set the value for the container like:
ENV PATH usr/local/bin:/usr/sbin:/usr/bin

If my host had a PATH variable of /bin or perhaps '/opt/bin:/opt/sbin', that could be perfectly fine for my host. But passing that variable through at best makes the execution less declarative and at worst breaks the build.
Maybe I'm missing something?

The $PATH is derived from the FROM section layer. So how does one figure that out?

That makes me feel much better, that it isn't just taking the current environment's value.

Yup.

Let's split this into two parts. A nightly "convert/build" job that works on real-world examples, while we do basic tests under bats.


Make getLatestGcloudSDKVersion stubbable and expose TestToolCache

Exporting es6 modules from within sub-files doesn't work with sinon's spies, which means all our tests still try to contact the Internet when running getLatestGcloudSDKVersion, even if the method is stubbed. I figured this out while traveling on an airplane without an Internet connection.
This moves the function into the main module so it can be stubbed appropriately.
This also refactors and exports the TestToolCache so we can use it elsewhere.

@verbanicm I fixed up the tests

Should we move TestToolCache into actions-utils instead? Seems more appropriate and we already have it as a dependency here.....

I think there's a few things we should move from here into actions-utils, yea


fix: remove fetch from clientoptions

Looks like fetch was included in the ClientOptions because it must've been copied over from the JS client 😦

Can we re-run CI here? It's been a while and I'm not sure what this change breaks in the tests

Hm odd, should probably patch the tests but otherwise lgtm

@anand2312 do you mind pushing an empty commit or similar? Can't figure out how to trigger a re-run since the branch is a little old. Seems like there's only the option to delete logs

Done - looks like pre-commit was complaining about an unused import


Can you alter Vendor Product name?

When updating the Sonoff Zigbee 3.0 USB gateway, the vendor product name shows up as   ID 10c4:ea60 Silicon Labs CP210x UART Bridge, can you change this?
I have an Aeotec Zwave USB Gateway with the same name.

The firmware in this repo is flashed on the Zigbee chip (CC2652P in your case). This ID comes from the UART chip which I believe is read-only, so no.


faq: -Z not -C unstable-options

Not sure if we should add a note that all -Z options are supposed to be unstable, though this is not yet enforced.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thanks!


ImportError: cannot import name 'load_model'.

Hi, qubvel. I piped install and trying to import 'load_model, but it got ImportError: cannot import name 'load_model' message.
I do recheck the whole*.py files but I still can't find any function named  'load_model'. Maybe I should pip installed fom git+https://github.com/qubvel/efficientnet instead of pip install efficientnet directly.
Really appreciate your help.

Hi @lognat0704
Yes, recent changes are not in PyPI yet, install it from source please.


Docs: Fixed Config example in Docs

Signed-off-by: Sara<EMAIL_ADDRESS>

Description of the Change
Emphasized that pg_opt are depricated, made example in the docs load from https://raw.githubusercontent.com/hyperledger/iroha/main/example/config.sample
Also fixed the example/config.sample so it would contain "database" parameter instead of "pg_opt".

Benefits
Config example will be up to date automatically.

Possible Drawbacks

Relative links are not possible here and the absolute links to the config example should lead to the default branch, which might not be yet updated.
Not a big issue as in the description of the parameters after the example it is possible to still add the missing parameters as they are mostly optional in cases where they are not in the default branch.
Another one is that the example in docs was way fuller - it also included parameters that are bit too advanced for the config.sample and are not needed for, say, getting started manual.
It is possible to fix this by adding these parameters to the config.sample if they will not break anything (like the "utility_service" one)
Usage Examples or Tests [optional]

Alternate Designs [optional]

Closes #907

@kuvaldini I think I found it! Is it ok?

@LiraLemur I suggest to change also files:
https://github.com/hyperledger/iroha/blob/main/example/config.docker
and
https://github.com/hyperledger/iroha/blob/main/example/config-win.sample

@baziorek you mean in regards to pg_opt?

@LiraLemur Yes, I mean that. Because You are changing one example, but rest of them is not changed. It can be strange for beginner user.

@LiraLemur Yes, I mean that. Because You are changing one example, but rest of them is not changed. It can be strange for beginner user.

@baziorek can you please make an issue for that? I already merged this (cause I needed it for the next small change)

@LiraLemur Yes, I can. Here it is:
https://github.com/hyperledger/iroha/issues/1081


Initial OGC spec - Table of content

I have prepared a first draft of the table of contents for the OGC-based specification.
Our primary goals are to ensure interoperability with most client and mapping tools, while also maximising compatibility with various source formats.
I believe we should focus on:

Initiating a flexible model that facilitates conversion from any data source (Annexes with mappings will demonstrate that).
Identifying specific cases that cannot be mapped to GeoZarr and creating specification requirements to address these gaps (for example, if origin/offset encoding of coordinates is not supported, we can extend our model and describe the encoding).
Defining optimal classes of requirements that will aid in the interpretation of data through standard mapping tools and clients. For example, the Dataset requirement class outlines how to store Geo2D data for easy display on a mapping tool, as well as the tiling and pyramiding classes.

I propose also to implement a python script that generates a small dummy GeoZarr that represent all requirements provided in the specification.

Updated - refined and motivated the concept of Gridded Data (similar to the concept of dataset in NetCDF/xArray). From my point of view, the primary asset of GeoZarr, NetCDF, GeoTiff, cloud native format is Gridded Data for which we should provide requirements to facilitate the discovery and display in map tools.

GeoZarr places special emphasis on Gridded Dataset which might be discovered, interpreted and displayed on a map. Gridded Dataset which refers to a structured format of spatial data represented as a matrix of cells or pixels, organized in a regular grid. Each cell holds a value representing a specific geographic area. Gridded Datasets includes 2D Rasters, Raster Time Series, Geo-Datacubes (with dimensions like time, light spectrum, altitude, etc.)

All/most source format might be encoded in Zarr, but GeoZarr must focus the standardisation of how encoding dataset from GDAL/CF ecosystems (most of the time inclusive, but sometimes implying a compromise). In particular, some of the GDAL assets (.e.g OriginOffset) have not yet a clear mapping to Zarr/GeoZarr.

I don't like how this talks about "coordinates". Talk about georeferencing. A regular grid in 2D is defined by six numbers. Rectilinear or curvilinear grids need more numbers (ncol + nrow, or ncol * nrow, or their edge+1 equivalents). It's very very normal to have a regular grid with compact description, I feel like the netcdf/xarray community has just advanced too far with the lowest common denominator of labelling arrays.
I'm also not comfy in this (mainly python) space, but I'm reading and listening and trying to get across it. (It used to be a MATLAB and Fortran heavy space). I'm commenting inly with good intentions, I see how much work and angst is going into this. I hope I can help.

I don't like how this talks about "coordinates".

Thank you for the detailed feedback.
Here's my perspective on the use of the term "coordinates" and the broader context of georeferencing in our specifications:
A GeoZarr/NetCDF/CF is not only 2D, but supports n-dimensional arrays (tensors, datacubes) with multiple dimensions. In this context, "coordinates" refers to not only to georeferencing, but more generally the mechanism that provides a function to the position within these arrays.
While the term "coordinates" might seem simplistic, it is widely understood across various domains. One could also prefer the 'coverage domain' as per ISO/OGC terminology)
The current approach of labelling arrays serves as a foundation, which has the advantage to be supported already by the libraries. This approach provides a simple and effective way to manage and access multidimensional data, and for any dimension (not only lat/lon).
However, our intention is to extend this by describing coordinates using origin offset, vectors, and other kinds of proposed encoding.

NOTE: please note that the focus is this PR is around the table of content. The definitions (mostly from CF/NetCDF/Xarray ecosystem) are provided as example to illustration the intention of the sections.

The current approach of labelling arrays serves as a foundation, which has the advantage to be supported already by the libraries. This approach provides a simple and effective way to manage and access multidimensional data, and for any dimension (not only lat/lon). However, our intention is to extend this by describing coordinates using origin offset, vectors, and other kinds of proposed encoding.

Awesome, thank you. And apologies for my "blurt" up there, it's well-intentioned but I am sure must seem wildly out of place. I'm not sure where to engage yet in this Python-heavy landscape but I'm learning.
I understand the n-dimensional-ness.  You can mix compact representations with fully-materialized ones, and an affine transform can be any dimensional. One of the reasons I'm agitating is because as well as the degenerate rectlinear norm in netcdf (where the x and y dims could be described by  offset and scale, or range and shape), also often you have "cryptic" situations where a perfectly regular map projection was devolved to longitude latitude arrays and the transform not recorded - so it looks like curvilinear but really isn't, or doesn't need to be (I'm working on communicating this within xarray as specific identifiable cases ... FWIW).
Also, again this out of place but I'm finding my way and really appreciate you responding in detail - there's a floating assumption here and there that "x and y" are "longitude and latitude", but sometimes they are paired coordinates in a map projection  so I wonder if the text here is really meant to be so coordinate-system-specific?  We have the same problem with "easting and northing", they often don't actually point in those canonical directions, so "x" and "y" is really more normal and safe I think no matter what the CRS is.

@mdsumner  : Thank you for your feedback. Note that I'm not personnally expert in GIS: I'm not coming from the NetCDF/Python ecosystem, neither GDAL, but I'm more oriented on Geospatial Data Platforms and Catalogues, as well with a sngificiative interest in Data access standards (OGC API Coverage, TIling).

Note: add "geographic control point" to better explain "labelled array" coordinates

@mdsumner : Thank you for your feedback. Note that I'm not personnally expert in GIS: I'm not coming from the NetCDF/Python ecosystem, neither GDAL, but I'm more oriented on Geospatial Data Platforms and Catalogues, as well with a sngificiative interest in Data access standards (OGC API Coverage, TIling).

Cool, I hope this software gets the ideas right. It's bigger than standards and requires people with deep experience to really cut through and not just in one language. I hope Python can reach out wide enough but I don't see it happening yet. Apologies if this is not an appropriate forum to express concerns but I don't know what is yet. 🙏


Backend: when receiving the evaluations, adjust the points accordingly: a bonus gives additional 5 point, a veto reduces points by 10.

a bonus only gives 3p

99092a0


Use the published Da Vinci Health Record Exchange (HRex) (STU1)

Is your feature request related to a problem? Please describe.
In issue #3407 we used a snapshot version of HRex.  Now HRex 1.0 is published and we should use that:  http://hl7.org/fhir/us/davinci-hrex/STU1/
Describe the solution you'd like
Describe alternatives you've considered
Acceptance Criteria

GIVEN [a precondition]
AND [another precondition]
WHEN [test step]
AND [test step]
THEN [verification step]
AND [verification step]

Additional context
we're expecting minimal changes

there is no capability statement for this IG but I confirmed that, after adding the built jar to my userlib, /metadata shows all of the following profiles as supported:
                        "http://hl7.org/fhir/us/davinci-hrex/StructureDefinition/hrex-practitioner|1.0.0",
                        "http://hl7.org/fhir/us/davinci-hrex/StructureDefinition/hrex-organization|1.0.0",
                        "http://hl7.org/fhir/us/davinci-hrex/StructureDefinition/hrex-coverage|1.0.0"
                        "http://hl7.org/fhir/us/davinci-hrex/StructureDefinition/hrex-task-data-request|1.0.0"
                        "http://hl7.org/fhir/us/davinci-hrex/StructureDefinition/hrex-consent|1.0.0"
                        "http://hl7.org/fhir/us/davinci-hrex/StructureDefinition/hrex-claimresponse|1.0.0"
                        "http://hl7.org/fhir/us/davinci-hrex/StructureDefinition/hrex-parameters-member-match-out|1.0.0",
                        "http://hl7.org/fhir/us/davinci-hrex/StructureDefinition/hrex-parameters-member-match-in|1.0.0"
                        "http://hl7.org/fhir/us/davinci-hrex/StructureDefinition/hrex-patient-demographics|1.0.0",
                        "http://hl7.org/fhir/us/davinci-hrex/StructureDefinition/hrex-practitionerrole|1.0.0",

davinci-hrex now sowas version 1.0.0 in /metadata


Manage Certs for multiple namespaces (but still not cluster-wide)

What would you like to be added:
I would like to be able to manage Let's Encrypt certs for routes in multiple namespaces/projects from 1 single deployment of openshift-acme without requiring the cluster-wide installation
Why is this needed:
In hosted environments, like OpenShift Online/OpenShift Dedicated, users may have multiple projects, but still won't have the rights necessary to create a ClusterRole. Ideally, something like an environment variable that can be comma separated for namespaces. Or better yet, just ask the API for a full list of namespaces/projects that the ServiceAccount has permissions to. That way, the only configuration necessary after initial deployment is granting the ServiceAccount the specific role necessary in each namespace.
Additionally, this would let admins in OpenShift Dedicated to deploy the openshift-acme operator in a locked down namespace that developers can't access, but still allow them to take advantage of the operator's abilities.
@tnozicka

It looks like you have to create the Role in each namespace, and then you can create the Rolebinding...but this at least works with the openshift-acme operator installed in 1 project, monitoring routes in a separate project. It looks like the RFE would just to be able to support multiple projects.

I think this is valid RFE, somehow I though the namespace option can already be repeated, but this should be pretty easy as it is just about setting about different informer per namespace.
I wonder if there is an easy way for auto discovery as you suggested. I guess for each namespace we would have to a SAR on
https://github.com/tnozicka/openshift-acme/blob/master/deploy/letsencrypt-live/single-namespace/role.yaml#L7

/remove-lifecycle stale

I think this is valid RFE, somehow I though the namespace option can already be repeated, but this should be pretty easy as it is just about setting about different informer per namespace.

Not as easy as I thought but I have started wiring the new version for multiple namespaces.
If someone could figure out the manual steps for autodiscovering to which namespaces the SA has access to given a Role, that would be helpful and I could wire it for autodetection.

manual steps for autodiscovering to which namespaces the SA has access to given a Role

What are you asking here? Wouldn't this be as straightforward as just enumerating through GET /apis/project.openshift.io/v1/projects, and then for each project, testing POST apis/authorization.k8s.io/v1/selfsubjectaccessreviews for get route, update route, create secret, update secret
I could also just be severely over-simplifying this too

Something in those lines, but I'd like us to run on pure Kube as well so this would have to work with namespaces and you can't just simply list namespaces in OpenShift because of RBAC.
We'd need to check SAR for the whole Role, so finding out if an API supports it or we'd just iterate over the fields in the Role would be a next thing.
I haven't really looked at it yet. I don't suppose it's super complicated.

/remove-lifecycle stale

fyi I've wired multiple namespaces for the v2, just not the autodetection yet


Fix windows build

I think the delete statement was just a typo. Also, needs to use the latest version of peters/winpty. Thanks to @peters for merging that.

When will this be merged? Really need to get it work on Windows

@wangtao2012 I've forked pty.js, bringing better node and windows support and fixing a bunch of bugs. Check it out at https://github.com/Tyriar/node-pty


Add Go 1.8 to test matrix for Travis.

I guess this PR might get larger unless you have no interest in supporting Go 1.8.

As far as I can tell this works fine with Go 1.8. Tests pass and I was able to use it to pull my rooms via the API.

Is it fixable ?

@tbruyelle I think so!  It looks like there's just a typo here: https://github.com/tbruyelle/hipchat-go/blob/master/hipchat/room.go#L185

@tbruyelle I wanted to add another room notification test that exercises the change to the Thumbnail struct and noticed something else odd.  The Card struct uses a pointer to Icon the Thumbail attribute, here: https://github.com/tbruyelle/hipchat-go/blob/master/hipchat/room.go#L96.  So it's never actually using that Thumbnail struct.  Am I missing something here?

Merged, thank you!

👍


Additional artifact refresh

Add prep_kvm_guests role call to reinstall_cluster playbook so that new versions of the kernel and initramfs are pulled down if the OCP version changes in inventory.
Signed-off-by: Jacob Emery<EMAIL_ADDRESS>

@smolin-de please review this as well.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


#194 To add athens-jetty-container to the bintray repository

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

👍


update CHANGES

please review completeness of edit

Can you please change version number from 6.1.6 to 6.2.0? I'd like the next release to be 6.2.0.
@hickst: anything else we need to add to CHANGES?

Thanks!