(backlog)Disk metrics support

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature
What happened:
To collect disk metrics in the LVM driver
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Hotpot(release/branch) version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

/assign @NajmudheenCT

https://github.com/opensds/opensds/pull/764 has the fix. Please close this ticket.


stuck on formatting the buffer after I save it

When I save a buffer, the buffer will be automatically formatted by this package, but it takes around 1s to finish the formatting process, I have to wait for it then I am able to do other actions such as move the focus to other windows.
Is it able to put the formatting process in the background or delay the formatting process for a few seconds, just don't block the whole Emacs?

Yes, it should be possible to start the formatter as a background process, and only send it the code on save. I'm planning to implement this but haven't got around to it. No changes to the command line invocations of the formatters are needed. In case anybody wants to try this, PRs are welcome!

It'll go roughly like this:

Create a *format-all-formatter* buffer in the background, separate from any files being edited.
Whenever a new formatter is selected, make-process for that formatter such that the process is associated with the *format-all-formatter* buffer (you have to separate its stdout from its stderr, the simpler start-process cannot do that, so you need to use the complex make-process)
Add a handler function with set-process-sentinel to replace the text in the source file with the formatted code which the formatter has written into the *format-all-formatter* buffer once it has exited. Remember to check for abnormal exit (nonzero exit code).
In format-all-buffer, use process-send-region to send the source code to the process, followed by process-send-eof.
Once the formatter has exited, start it again so it's ready for the next call to format-all-buffer.
Whenever the user switches to a different formatter (or same formatter with different command line arguments), restart the formatter process.
Whenever the user switches to a buffer where format-all-formatters is nil, it's okay to kill the formatter process to save memory, though this may not be that important.

If the user has set up a chain with more than one formatter, things are going to be annoying :) Maybe disable formatter preloading in that case.

Yes. I've written another package live-preview which runs a background process.
format-all's current use case is so simple that we get away with a synchronous process, though that means really slow formatters noticeably freeze Emacs
apheleia runs a background formatter on save. I think a more promising approach is to keep the formatter warmed up during editing, feed it the code on save, and synchronously wait for it to complete. Formatting code doesn't take long, starting up some formatters does. But apheleia works right now, so it has that bragging right and I don't.

I just moved from Atom to doom, which uses this package and I also noticed the lag, esp w/ prettier.


build: add update-go-mod.sh to do go mod

What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #232
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/kind feature

/retest

/ok-to-test

/approve
/lgtm


trace: fix get_task_context memory leak

Summary
fix get_task_context memory leak
The memory of malloc is not added to the linked list, resulting in a memory leak
Impact
Testing

Summary
fix get_task_context memory leak The memory of malloc is not added to the linked list, resulting in a memory leak

The leak is due to the first patch in this PR, the original code doesn't have this problem, I think.


Structured Data issue due to poster image size

Suggestion Request
Hi guys I got some issue with the Google stories plugin and I hope you can suggest me via email if I should deactivate the plugin because of this error in my Search console or just to ignore it (removed)

Issue in question
Here is the error message I got from Google search console ( inside search console I got this URL for both errors- https://advancedmarketinglab.com/stories/942/ ):

Plugin Version: 1.0.0. Beta-1
Operating System: WP
Browser: Chrome, Firefox

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Thanks for sharing those details and for reporting this issue. This image size is 300 x 144 pixels. Note the following recommended minimum requirements for Web Stories:
        Each poster image should meet the recommended minimum size:
        Portrait: 640px x 853px
        Landscape: 853px x 640px
        Square: 640px x 640px

I noticed a CDN URL for JetPack Site Accelerator in your source code for this image, which has an image size of 2167 × 1043 pixels. This could indicate the image size was altered, however, we need to check a few more details.

Did you upload a Cover image to the editor for the story?
Can you check what the image size is from your media library?

@ivo-aml Just want to note that the issue you described is similar to this open issue where a bug in the plugin causes that 300x144 image, which is too small and causes that Search Console error.

The second issue - "Error in required structured data element" - seems to indicate that you're story might not have a title. You should enter a title before publishing a story.
The title is used for the headline structured data field, and that is currently empty and causes this error:

Hey thanks for the reply man. I actually have the cover image which is
2167/1043. So you saying whenever I do a story I have to use images with
the sizes that you mention in the email?
On Thu, Jul 30, 2020 at 9:57 PM LuckynaSan<EMAIL_ADDRESS>wrote:

@ivo-aml https://github.com/ivo-aml Just want to note that the issue
you described is similar to this open issue
https://github.com/google/web-stories-wp/issues/3434 where a bug in the
plugin causes that 300x144 image, which is too small and causes that Search
Console error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/web-stories-wp/issues/3560#issuecomment-666648282,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOOBO6TJKW4YKOH3WRNZ23R6HGDLANCNFSM4PNY57WA
.

Hey Pascal, thanks man. I did include the title.
Thanks again.
Regards
On Fri, Jul 31, 2020 at 3:45 PM Pascal Birchler<EMAIL_ADDRESS>wrote:

The second issue - "Error in required structured data element" - seems to
indicate that you're story might not have a title. You should enter a title
before publishing a story.
The title is used for the headline structured data field, and that is
currently empty and causes this error:
[image: Screenshot 2020-07-31 at 15 43 04]
https://user-images.githubusercontent.com/841956/89040917-cb48bc80-d344-11ea-9189-25251b6ce729.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/web-stories-wp/issues/3560#issuecomment-667127439,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOOBO2JJRHQPA4SHVNSRKLR6LDHBANCNFSM4PNY57WA
.

@ivo-aml

Hey thanks for the reply man. I actually have the cover image which is
2167/1043. So you saying whenever I do a story I have to use images with
the sizes that you mention in the email?

Your cover image size meets structured data recommendations which states it should be at least 1200px wide. The recommendation is to use at least 828 x 1792 sized fullscreen/ background images as mentioned in this best practices documentation.

Hi there! I notice the AMP test result is okay, but if you preview it you can see the poster image isn't ideal. We've made a few recent changes that might solve the issue surrounding small poster portrait images. Could you perhaps try removing the plugin and installing this in-development version? Download: web-stories.zip

Hey yes, I'll do that. Thanks man.
On Sat, Aug 15, 2020 at 4:55 AM LuckynaSan<EMAIL_ADDRESS>wrote:

Hi there! I notice the AMP test result
https://search.google.com/test/amp?id=z-7EAgVqezzA-RxVXl-y3g is okay,
but if you preview it https://jmp.sh/JQQs64j you can see the poster
image isn't ideal. We've made a few recent changes that might solve the
issue surrounding small poster portrait images. Could you perhaps try
removing the plugin and installing this in-development version? Download:
web-stories.zip
https://github.com/google/web-stories-wp/files/5078028/web-stories.zip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/web-stories-wp/issues/3560#issuecomment-674338465,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOOBO3HSUZWYEUVMMNPY7TSAX2JXANCNFSM4PNY57WA
.

Hey guys, here is what I got after uploaded the new version.
1 - I had my first story still there but from thew editor if I click on
"Preview" I got this error:
Warning: DOMDocument::loadHTML() expects parameter 2 to be integer,
string given in
/home2/aml/public_html/wp-content/plugins/web-stories/includes/Story_Renderer.php
on line 97
2 - Also if I paste the link in new private window takes me to the same
error page.
Please, let me know :)
On Sat, Aug 15, 2020 at 11:47 AM Advanced Marketing Lab <
<EMAIL_ADDRESS>wrote:

Hey yes, I'll do that. Thanks man.
On Sat, Aug 15, 2020 at 4:55 AM LuckynaSan<EMAIL_ADDRESS>wrote:

Hi there! I notice the AMP test result
https://search.google.com/test/amp?id=z-7EAgVqezzA-RxVXl-y3g is okay,
but if you preview it https://jmp.sh/JQQs64j you can see the poster
image isn't ideal. We've made a few recent changes that might solve the
issue surrounding small poster portrait images. Could you perhaps try
removing the plugin and installing this in-development version? Download:
web-stories.zip
https://github.com/google/web-stories-wp/files/5078028/web-stories.zip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/web-stories-wp/issues/3560#issuecomment-674338465,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOOBO3HSUZWYEUVMMNPY7TSAX2JXANCNFSM4PNY57WA
.

Hi guys, another thing. check this quick screen recording. You can see how
every time I click the new slide the page is jumping up:
https://ttprivatenew.s3.amazonaws.com/pulse/advancedmarketinghub-gmail/attachments/14392398/TinyTake15-08-2020-12-37-53.mp4
On Sat, Aug 15, 2020 at 12:12 PM Advanced Marketing Lab <
<EMAIL_ADDRESS>wrote:

Hey guys, here is what I got after uploaded the new version.
1 - I had my first story still there but from thew editor if I click on
"Preview" I got this error:
Warning: DOMDocument::loadHTML() expects parameter 2 to be integer,
string given in
/home2/aml/public_html/wp-content/plugins/web-stories/includes/Story_Renderer.php
on line 97
2 - Also if I paste the link in new private window takes me to the same
error page.
Please, let me know :)
On Sat, Aug 15, 2020 at 11:47 AM Advanced Marketing Lab <
<EMAIL_ADDRESS>wrote:

Hey yes, I'll do that. Thanks man.
On Sat, Aug 15, 2020 at 4:55 AM LuckynaSan<EMAIL_ADDRESS>wrote:

Hi there! I notice the AMP test result
https://search.google.com/test/amp?id=z-7EAgVqezzA-RxVXl-y3g is okay,
but if you preview it https://jmp.sh/JQQs64j you can see the poster
image isn't ideal. We've made a few recent changes that might solve the
issue surrounding small poster portrait images. Could you perhaps try
removing the plugin and installing this in-development version? Download:
web-stories.zip
https://github.com/google/web-stories-wp/files/5078028/web-stories.zip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/web-stories-wp/issues/3560#issuecomment-674338465,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOOBO3HSUZWYEUVMMNPY7TSAX2JXANCNFSM4PNY57WA
.

Warning: DOMDocument::loadHTML() expects parameter 2 to be integer,
string given in /home2/aml/public_html/wp-content/plugins/web-stories/includes/Story_Renderer.php
on line 97

Which version of PHP are you using? Also, more specifically, which version of libxml are you using? You can check that by using phpinfo() or by doing something like php -i | grep libxml in the command line.

Hi guys, another thing. check this quick screen recording. You can see how
every time I click the new slide the page is jumping up:

Which browser and which browser version are you using?

I see the PHP is 7.1.24. Should I upgrade it? About the browser I am using
right now Firefox but with the previous plugin version was doing the same
and this time I was on Opera I think.
On Sat, Aug 15, 2020 at 3:30 PM Pascal Birchler<EMAIL_ADDRESS>wrote:

Warning: DOMDocument::loadHTML() expects parameter 2 to be integer,
string given in
/home2/aml/public_html/wp-content/plugins/web-stories/includes/Story_Renderer.php
on line 97
Which version of PHP are you using? Also, more specifically, which version
of libxml are you using? You can check that by using phpinfo() or by
doing something like php -i | grep libxml in the command line.
Hi guys, another thing. check this quick screen recording. You can see how
every time I click the new slide the page is jumping up:
Which browser and which browser version are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/web-stories-wp/issues/3560#issuecomment-674396626,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOOBO6HGOPXIOQBR5WMJADSA2EWTANCNFSM4PNY57WA
.

I see the PHP is 7.1.24. Should I upgrade it?

No, it's fine. The DOMDocument::loadHTML() warnings should be fixed with the next release. Although the latest PHP version is 7.4, so it's about time for an upgrade anyway :-)

Cool, I will upgrade the PHP in mean time.
On Mon, Aug 17, 2020 at 12:43 PM Pascal Birchler<EMAIL_ADDRESS>wrote:

I see the PHP is 7.1.24. Should I upgrade it?
No, it's fine. The DOMDocument::loadHTML() warnings should be fixed with
the next release. Although the latest PHP version is 7.4, so it's about
time for an upgrade anyway :-)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/web-stories-wp/issues/3560#issuecomment-674806391,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOOBO3ZP4IGYW2QR6ET3LDSBECUBANCNFSM4PNY57WA
.

Hello @ivo-aml!  Have you updated the PHP version and tried the latest Beta 2 available for download on the website? Please let us know if your issue persists.

Hey,
sorry for my late reply man. Yes I updated the PHP and activated the
version that you gave me in one of the previous emails. Honestly, I haven't
try it yet because I was quite busy these days. But thanks for contacting
me, one of next days I will give you feedback.
Regards
On Wed, Sep 2, 2020 at 4:19 PM LuckynaSan<EMAIL_ADDRESS>wrote:

Hello @ivo-aml https://github.com/ivo-aml! Have you updated the PHP
version and tried the latest Beta 2 available for download on the website
https://google.github.io/web-stories-wp/beta/? Please let us know if
your issue persists.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/web-stories-wp/issues/3560#issuecomment-685767907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOOBO5F3K3R7DGO5JA3J4TSDZH55ANCNFSM4PNY57WA
.

Note that 1.0.0-rc.1 has been released in the meantime. Make sure to update accordingly.

@ivo-aml We will close this issue out as we have yet to receive a response. Feel free to open a new topic on the Web Stories Support Forum if the issue persists. Thank you!

Hi, cool, no problem. Sorry for the late replies man, but I had a deadline
to finish revamping a site ( wanderlust-magazine.com) where we are planning
to use the Web stories plugin as well. Yes, if I got issues I will
definitely send you an email.
Thanks again.
Best regards
Ivo
On Tue, Sep 22, 2020 at 9:58 PM LuckynaSan<EMAIL_ADDRESS>wrote:

@ivo-aml https://github.com/ivo-aml We will close this issue out as we
have yet to receive a response. Feel free to open a new topic on the Web
Stories Support Forum https://wordpress.org/support/plugin/web-stories/
if the issue persists. Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/web-stories-wp/issues/3560#issuecomment-696946809,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQOOBO24Q65AUFHRJLICEBDSHD6XVANCNFSM4PNY57WA
.


style: make PageTopBar responsive

FX-3989
Description
Describe the changes and motivations for the pull request.
How to test

FIXME: Add the steps describing how to verify your changes

Screenshots

Before.
After.

Insert screenshots or screen recordings
Insert screenshots or screen recordings

Development checks

[ ] Add changeset according to guidelines (if needed)
[ ] Read CONTRIBUTING.md and Component API principles
[ ] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[ ] Annotate all props in component with documentation
[ ] Create examples for component
[ ] Ensure that deployed demo has expected results and good examples
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[ ] Self reviewed
[ ] Covered with tests

Breaking change

[ ] codemod is created and showcased in the changeset
[ ] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run package:alpha-release - Release alpha version
@toptal-anvil ping reviewers - Ping FX team for review

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-anvil ping reviewers

@Q-Man could I ask you to test it with alpha package with your project? 🙇

sure thing

sure thing

On a quick glance I saw that the breakpoint for showing the hamburger menu instead of the Sidebar and narrowing the user menu is now <1024px, before it was <768px.
Is that on purpose? There's enough space to show it between 769 - 1023 IMO.

@toptal-bot run package:alpha-release

@toptal-bot run package:alpha-release

@toptal-anvil ping reviewers

@toptal-anvil ping reviewers


Design Doc for  Task Unassignment

Overview
Currently there is no way to un assign a task. To un assign a task the super user needs to assign the task to self and then it reflects it in overdue for them.
Goals
The primary objective is to implement a feature that allows for the unassignment of tasks within the system. The goal is to streamline this process by providing a straightforward method for super users to unassign tasks without the need for assigning it to themselves as a workaround.
Steps for Task Unassignment

Locate Task on Status Site:

Super users navigate to the status site and locate the specific task they want to unassign.

Task Card Interface:

On the task card of the selected task, the super user, being the only authorized entity, can exclusively access and click the Unassign button.

Initiate Unassignment Process:

The system processes the unassignment request and removes current assignee from the task.

Queue Update:

After successful unassignment, the task is returned to the pool of unassigned tasks.

Visibility on Status Site:

The task now appears under the Unassigned tab on the status site, indicating its availability for reassignment.

Testing

Every modification made to the frontend components on the status site and backend functionalities within the website backend will undergo comprehensive unit and integration testing.
The initial phase of testing will occur in a staging environment, conducted discreetly behind a designated feature flag. This ensures that potential issues are identified and resolved before the changes are exposed to the broader user base.
Only after successful testing in the staging environment and verification that the modifications perform as anticipated will the changes proceed to the production environment for further validation.

Roll out strategy

API Update:

Initiate the task by updating the backend API. This allows for the implementation of new functionalities in the /task route.

Feature Flag Implementation:

Introduce a feature flag to encapsulate the change. This enables a controlled rollout, as the new features will remain hidden from users initially.

Backend Testing (Staging):

Conduct thorough testing of the updated backend functionalities in a staging environment. This testing phase ensures that the backend changes function as intended and are free from bugs.

Backend Testing (Production):

Gradually roll out the updated backend functionalities to a limited audience in the production environment, still concealed behind the feature flag. Monitor system behavior and address any unexpected issues that may arise.

Frontend Update:

Once the backend changes are successfully deployed and verified, proceed to update the frontend components on the status site.

Frontend Testing (Staging):

Conduct comprehensive testing of the updated frontend features in the staging environment to ensure seamless integration with the backend changes.

Frontend Testing (Production):

Gradually release the updated frontend to a limited audience in the production environment, while still keeping it behind the feature flag. Monitor user interactions and gather feedback.

Full Rollout:

If both backend and frontend changes prove to be stable and perform as expected, proceed with a full rollout by removing the feature flag. This makes the new features accessible without the feature flag.

Roll back strategy
Since the task unassignment feature is deployed behind a feature flag, any potential issues or major disruptions will not impact production users. In the event of critical or breaking changes, a pull request will be promptly raised to revert the changes, ensuring a swift return to the previous stable state.

Is it possible to list all the possible test cases. Ankush asked me to do so when I showed him my design doc.
For ref, you can check this. Rest of the approach looks good to me.

Is it possible to list all the possible test cases. Ankush asked me to do so when I showed him my design doc. For ref, you can check this. Rest of the approach looks good to me.

Sl No
When
Then

1
Status site without feature flag
Task Cards will not have the Unassign button

2
Status site with feature flag
Task Cards will have the Unassign button and super user will be able to click and unassing tasks

Is it possible to list all the possible test cases. Ankush asked me to do so when I showed him my design doc. For ref, you can check this. Rest of the approach looks good to me.

Sl No	When	Then
1	Status site without feature flag	Task Cards will not have the Unassign button
2	Status site with feature flag	Task Cards will have the Unassign button and super user will be able to click and unassing tasks

Do we need to create a separate Unassign button for this feature? I think we can initiate this request when super user changes task status to unassigned.


pre-compiled pipeline is not working behind a proxy

tested on CKF 1.7/beta
used this mnist example to upload pipeline from file. Failed with logs in Load step:
This step is in Pending state with this message: ImagePullBackOff: Back-off pulling image "rocks.canonical.com:5000/kubeflow/examples/mnist-test:latest"

we need to figure out how to inject the proxy envs into a pre-compiled pipeline.

might be related to https://github.com/canonical/bundle-kubeflow/issues/546


Refactor and Enable Pip Installs from Git

This PR does two things:

Renames all plugins from the old ravenml_<plugin name> scheme to the new rmltrain<plugin name> scheme which is required for pip installs from git to work due to pip's handling of underscores and dashes.
Updates all plugins to be entirely pip installable. This means all install logic is in the setup.py.

NOTABLE CHANGES

Introduces the use of find_packages() in all setup.py files to ensure submodules are installed.
setup.py now looks for an environment variable called RMLTRAIN_<plugin ID>_GPU on install to determine which library version to install (CPU or GPU).
All plugins which use TF object detection now depend on https://github.com/autognc/object-detection (no longer including all OD code directly in the plugin)

Installing a package direct from git uses this command:
pip install "git+https://github.com/autognc/ravenML-train-plugins.git#egg=<plugin name>&subdirectory=<plugin name>"

This doesn't conflict much with the old installation scheme using the install.sh scripts ( I attempted to make them backwards compatible ) but two things to know:

The final step in the install.sh scripts is to pip install the module, which now has a fully populated setup.py. That means the requirements listed in the .in files could be overwritten if setup.py defines a different version (for now they all match)
For GPU installs, the necessary env variables are automatically set and unset by the install.sh script now to ensure that the setup.py doesnt mess up the pip-compile installed GPU library.

Oh, one other thing for when you write the documentation, in case you didn't know: you can pip install from a tarball generated by GitHub:
pip install "https://github.com/autognc/ravenML-train-plugins/tarball/<BRANCH>#subdirectory=<PLUGIN>"
This is a lot faster than the "git+" install in my experience.

Removed old install scheme, switched to a single GPU env variable called RML_GPU, and switched pose regression to TF 2.1.0.


Small mistake in the given example (inexistant pointer)

I guess there is a (very) small mistake in the example given: The DestinationString of the RtlInitUnicodeString should be &myKeyStr and not &mySubKey (which doesn't exist by the way).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3df06439-9c44-d1cb-d652-a12362c906a2
Version Independent ID: eede9e72-d5d0-b3df-7505-02c975183580
Content: WdfRegistryCreateKey function (wdfregistry.h) - Windows drivers
Content Source: wdk-ddi-src/content/wdfregistry/nf-wdfregistry-wdfregistrycreatekey.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @tedhudek
Microsoft Alias: tedhudek

Hi @aleaforny,
Thanks for the heads-up and apologies for the delay.  This fix is now live!


Add linux camera demo

I opened a PR here https://github.com/raymanfx/libv4l-rs/pull/18 instead since this is linux only I think its more appropriate.


environment can only contain strings

Dear author, during my training, "environment can only contain strings" came up.My environment is Windows, py3.Is it because this code must run on Linux?

you can run on windows or linux. I run it on pycharm.

I also tried to run it on pycharm but I failed.I wonder know  if you ever met the problem of "environment can only contain strings"  or if you know how to solve it.In addition I see your profile picture is the qr code of WeChat. Do I have the honor to be your WeChat friend?I am an undergraduate student from China. Recently, my tutor asked me to study the brats competition. However, as a beginner, I met some problems and want to communicate with you.I can pay if you think it's a waste of time

you can run on windows or linux. I run it on pycharm.

I also tried to run it on pycharm but I failed.I wonder know if you ever met the problem of "environment can only contain strings" or if you know how to solve it.In addition I see your profile picture is the qr code of WeChat. Do I have the honor to be your WeChat friend?I am an undergraduate student from China. Recently, my tutor asked me to study the brats competition. However, as a beginner, I met some problems and want to communicate with you.I can pay if you think it's a waste of time

你好，可以的，你直接加我微信就行了，把你的错误发我看看


Hide Non-working Feature Placeholders

If something doesn't work, hide it. Or put, "Coming Soon" - whatever seems reasonable for the widget.

Hid the FAQ and Questions areas from companyPage and influencerPage.

Think I have them all


docker compose deployment

Feature Suggestion
I'm looking for docker compose deplyment that contains frontend and backend.

@gharsallahmoez At the moment, there is nothing which will work out of the box for this. There used to be a sample docker-compose.yaml file in the contrib directory but it seems to be gone.
I have written a blog post tutorial which shows how to build a Backstage instance and run it with Docker Compose. Hopefully it is useful.

@gharsallahmoez At the moment, there is nothing which will work out of the box for this. There used to be a sample docker-compose.yaml file in the contrib directory but it seems to be gone.
I have written a blog post tutorial which shows how to build a Backstage instance and run it with Docker Compose. Hopefully it is useful.

@dtuite it works in my local machine, but when I tried to build it on my public server I got a white screen in the browser and this error net::ERR_SSL_PROTOCOL_ERROR in the console. did u tried to build backstage on a server? and do u have an idea what goes wrong?

@dtuite it works in my local machine, but when I tried to build it on my public server I got a white screen in the browser and this error net::ERR_SSL_PROTOCOL_ERROR in the console. did u tried to build backstage on a server? and do u have an idea what goes wrong?

here is the full console log
GET https://myserver.com:7000/static/kyma-project.12.eca6006b.css net::ERR_SSL_PROTOCOL_ERROR
GET https://myserver.com:7000/favicon.ico net::ERR_SSL_PROTOCOL_ERROR
GET https://myserver.com:7000/favicon-32x32.png net::ERR_SSL_PROTOCOL_ERROR
GET https://myserver.com:7000/favicon-16x16.png net::ERR_SSL_PROTOCOL_ERROR

here is the full console log
GET https://myserver.com:7000/static/kyma-project.12.eca6006b.css net::ERR_SSL_PROTOCOL_ERROR
GET https://myserver.com:7000/favicon.ico net::ERR_SSL_PROTOCOL_ERROR
GET https://myserver.com:7000/favicon-32x32.png net::ERR_SSL_PROTOCOL_ERROR
GET https://myserver.com:7000/favicon-16x16.png net::ERR_SSL_PROTOCOL_ERROR

@gharsallahmoez the scope of the tutorial is local development only. I wouldn't be surprised if it doesn't work on a server. Unfortunately I have no insight into what is causing the specific errors you are seeing.

@gharsallahmoez the scope of the tutorial is local development only. I wouldn't be surprised if it doesn't work on a server. Unfortunately I have no insight into what is causing the specific errors you are seeing.

@gharsallahmoez do you have SSL certificates setup for your server deployment? It looks like you're trying to load https when it only listens with http.

@gharsallahmoez do you have SSL certificates setup for your server deployment? It looks like you're trying to load https when it only listens with http.

:wave: https://play-with-docker.com author here.  I was looking for a way to test backstage and found that https://demo.backstage.io/ seems to be broken. We've developed a "Try in PWD" button (see example repo here https://github.com/tillias/microservice-catalog) that allows deploying a compose file to demo products.
@dtuite if you think it's worth I can bring back the docker-compose.yml file and add the "Try in PWD" button so users can actually test backstage before setting it up locally.
WDYT?

:wave: https://play-with-docker.com author here.  I was looking for a way to test backstage and found that https://demo.backstage.io/ seems to be broken. We've developed a "Try in PWD" button (see example repo here https://github.com/tillias/microservice-catalog) that allows deploying a compose file to demo products.
@dtuite if you think it's worth I can bring back the docker-compose.yml file and add the "Try in PWD" button so users can actually test backstage before setting it up locally.
WDYT?

@marcosnils Could you be more specific about what is broken with the Backstage demo please? At a glance, it seems to work for me right now. I'm sure it would help the team to know what is broken.
If you show me how to add that button I'm happy to try it out and maybe add it to the blog post mentioned above. I have been maintaining up to date Backstage Docker images: backend and frontend which could be used.
Shoot me an email at<EMAIL_ADDRESS>

@marcosnils Could you be more specific about what is broken with the Backstage demo please? At a glance, it seems to work for me right now. I'm sure it would help the team to know what is broken.
If you show me how to add that button I'm happy to try it out and maybe add it to the blog post mentioned above. I have been maintaining up to date Backstage Docker images: backend and frontend which could be used.
Shoot me an email at<EMAIL_ADDRESS>

Could you be more specific about what is broken with the Backstage demo please?

Sorry for that, the create component action returns 404. It'd be awesome if you could create a component from a public github repo and make backstage pick that to play in the demo.

If you show me how to add that button I'm happy to try it out and maybe add it to the blog post mentioned above. I have been maintaining up to date Backstage Docker images: backend and frontend which could be used.

Sure, adding the button is pretty straightforward, you just need to have a public docker-compose file that is configured with all the required services and add a link like this one (https://github.com/tillias/microservice-catalog/blame/master/README.md#L14) to send the user to PWD and reference that stack.

Could you be more specific about what is broken with the Backstage demo please?

Sorry for that, the create component action returns 404. It'd be awesome if you could create a component from a public github repo and make backstage pick that to play in the demo.

If you show me how to add that button I'm happy to try it out and maybe add it to the blog post mentioned above. I have been maintaining up to date Backstage Docker images: backend and frontend which could be used.

Sure, adding the button is pretty straightforward, you just need to have a public docker-compose file that is configured with all the required services and add a link like this one (https://github.com/tillias/microservice-catalog/blame/master/README.md#L14) to send the user to PWD and reference that stack.

Also relates to the existing bug report of the create catalog button looking broken on demo (though it's actually not been installed by design, and the referenced issue being kept open to better explain/error that to the end-users):
https://github.com/backstage/backstage/issues/4085

Also relates to the existing bug report of the create catalog button looking broken on demo (though it's actually not been installed by design, and the referenced issue being kept open to better explain/error that to the end-users):

And it makes total sense to avoid polluting the demo environment. Having said that, I believe that a straightforward approach by using a single docker-compose file locally to spin up all the services would be really neat since the docs are recommended docker anyways to start the postgres database.
If we provide this, then adding something like the "Try in PWD" button so anyone can easily spin-up their demo environment is just trivial

@adamdmharvey gente ping


[highfive] fix SHA of the downloaded patch

There is still an issue for highfive.
https://github.com/hpc-maths/samurai/actions/runs/4193861295/jobs/7466677031
I made a mistake in the last PR. I added ?full_index=1at the end of the url and I tried to install highfive locally. But I already had the patch and then the SHA was not verified.
In this PR, the SHA is the good one.

No worries! Thanks for the fix!


adding processingjob shape/validator

This PR adds two main changes to the ProcessingJob object:

a shape property which returns the sample/metadata-columns related to the job, if possible
adds a VALIDATOR job_type for qiita.processing_job_resource_allocation

Codecov Report

Merging #3012 into dev will decrease coverage by 0.01%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##              dev    #3012      +/-   ##
==========================================
- Coverage   95.00%   94.99%   -0.02%
==========================================
  Files          74       74
  Lines       14122    14192      +70
==========================================
+ Hits        13417    13481      +64
- Misses        705      711       +6

Impacted Files
Coverage Δ

qiita_db/processing_job.py
74.16% <62.50%> (+1.13%)
:arrow_up:

qiita_db/test/test_processing_job.py
99.82% <100.00%> (+<0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af41814...0b3b635. Read the comment docs.

Sorry, forgot to add these images:

List of jobs and their current usage/allocation, this was used to set the values in the SQL patch:
alpha_vector is a clear outlier. As far as I remember, there was a bug in alpha group significance that made it use more memory than needed, thus the importance of grouping by job_number (time), note that the line is at 9.3G

Thank you @ElDeveloper! Looking at the codecov report; the only missing lines for tests are the Qiita block and the try/excepts. In the next PR: adding sample/column calculations; I actually needed to add more tests at least for the special case for Qiita ...

Thanks @antgonza!


BUGFIX: it is necessary to wait for __updateInstalledLibraryData.

Otherwise the dependend lib will not be written to contrib.json

I will merge this despite the failing tests, assuming @johnspackman's approval, then fix the problem in the test and provide a new PR.

Thanks @hkollmann, forgetting await before async functions has bitten me so often, I must be more careful.


feat(share/store_v2) Update file interface to use shwap types

Updates file interface to latest prototype version

Codecov Report
Attention: Patch coverage is 27.94118% with 49 lines in your changes are missing coverage. Please review.

Please upload report for BASE (shwap@49946c8). Learn more about missing BASE report.

Files
Patch %
Lines

share/root.go
0.00%
22 Missing :warning:

share/store/file/mem_file.go
53.12%
15 Missing :warning:

share/eds/utils.go
0.00%
7 Missing :warning:

share/store/file/axis_half.go
0.00%
5 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##             shwap    #3441   +/-   ##
========================================
  Coverage         ?   43.66%
========================================
  Files            ?      285
  Lines            ?    16477
  Branches         ?        0
========================================
  Hits             ?     7194
  Misses           ?     8449
  Partials         ?      834

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Needs rebase and PR description

Rebased


gitlab-pages: 15.7.3 -> 15.9.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gitlab-pages/versions.
meta.description for gitlab-pages is: Daemon used to serve static websites for GitLab users
meta.homepage for gitlab-pages is: https://gitlab.com/gitlab-org/gitlab-pages
meta.changelog for gitlab-pages is: https://gitlab.com/gitlab-org/gitlab-pages/-/blob/v15.9.1/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 15.9.1 in filename of file in /nix/store/81j8p71ssm8w74d2y5lzp4frsyqqbsa1-gitlab-pages-15.9.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
gitlab-pages

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/81j8p71ssm8w74d2y5lzp4frsyqqbsa1-gitlab-pages-15.9.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gitlab-pages https://github.com/r-ryantm/nixpkgs/archive/8df7e640bd2ccde9b62015878580944f437e94cd.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/81j8p71ssm8w74d2y5lzp4frsyqqbsa1-gitlab-pages-15.9.1
ls -la /nix/store/81j8p71ssm8w74d2y5lzp4frsyqqbsa1-gitlab-pages-15.9.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gitlab-pages

Maintainer pings
cc @ajs124 @dasJ for testing.

Please reopen.


fix-config-changes: Debug env var

what

SH_SSH_CONFIG_CHANGES needs to be inverted, same as SH_FORCE_ALL, since the switch to environment variables. CCI converts yaml booleans -> numbers, which in turn need to be inverted.

why

Presently a bug.

references
N/A

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:fae5312e882eb20618c285d6de0ac4bcc0e9ca18

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:5c587d38969c55604f97f62880f9534d36cccf65

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:783cecfc9495a0486b5572b904ae61492cd62d42

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:fc362f9db5386a182c064d0992b5914f9d90ad2e

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:66e5871afd0d4c25ca39ef915a44c37eca386184

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:b82db0f28294632c57d4d1a0f837a46cf7253a90

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:8ef43608f2aeabec31c760003049cd4b889035c6

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:995f92d265a9f1d0a54fcfd9ecad4dbeaf79a7f7

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/bjd2385/dynamic-continuation?version=dev:1f91df27e90e2a080550d619b0f34cfa2d6a95f9


Update pod-lifecycle.md

I think there is a typo, readiness problem needs to be readiness probe.

Hi, I have signed the CLA. Thanks.

nice catch
/lgtm

/approve


swift 4 updates

Updated demo app and component to work with Xcode9/Swift4

Amazing!!!

Waiting for the merge 👀

For those still waiting on the merge, like myself, you can use the following in your Podfile to continue your development process:
pod 'BTNavigationDropdownMenu', :git => 'https://github.com/zkrige/BTNavigationDropdownMenu.git'


Fix model animation cache collision

Brought up on the forum: https://groups.google.com/forum/#!topic/cesium-dev/iKU4ORj0vNE
Since buffer.path is not defined for glTF 1.0 models (it was for 0.8), animations referencing different bin files could collide in the animation cache. This changes it to use buffer.uri instead, but only if it's not a data uri.

Please update CHANGES.md in master.

Updated in https://github.com/AnalyticalGraphicsInc/cesium/commit/324f6fde724aa85357483696887a5617411cde21


feat: flume channels for RepartitionExec

Which issue does this PR close?
Closes #6928 https://github.com/apache/arrow-datafusion/issues/6928#issue-1800371204
Rationale for this change

What changes are included in this PR?

Are these changes tested?
Yes
Are there any user-facing changes?
No

I can replicate the resuls:
Benchmark tpch.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query        ┃     main ┃    flume ┃        Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1     │ 303.98ms │ 304.20ms │     no change │
│ QQuery 2     │  71.69ms │  68.18ms │     no change │
│ QQuery 3     │ 134.92ms │ 111.77ms │ +1.21x faster │
│ QQuery 4     │  81.51ms │  51.06ms │ +1.60x faster │
│ QQuery 5     │ 164.34ms │ 121.10ms │ +1.36x faster │
│ QQuery 6     │  80.46ms │  81.17ms │     no change │
│ QQuery 7     │ 229.50ms │ 216.51ms │ +1.06x faster │
│ QQuery 8     │ 187.78ms │ 174.60ms │ +1.08x faster │
│ QQuery 9     │ 274.48ms │ 210.65ms │ +1.30x faster │
│ QQuery 10    │ 217.25ms │ 151.70ms │ +1.43x faster │
│ QQuery 11    │  53.64ms │  52.83ms │     no change │
│ QQuery 12    │ 150.92ms │ 118.99ms │ +1.27x faster │
│ QQuery 13    │ 317.33ms │ 329.28ms │     no change │
│ QQuery 14    │ 112.84ms │ 114.44ms │     no change │
│ QQuery 15    │  88.75ms │  90.07ms │     no change │
│ QQuery 16    │  66.07ms │  61.94ms │ +1.07x faster │
│ QQuery 17    │ 763.97ms │ 756.59ms │     no change │
│ QQuery 18    │ 603.97ms │ 477.65ms │ +1.26x faster │
│ QQuery 19    │ 224.88ms │ 227.46ms │     no change │
│ QQuery 20    │ 247.86ms │ 239.13ms │     no change │
│ QQuery 21    │ 340.86ms │ 234.40ms │ +1.45x faster │
│ QQuery 22    │  53.66ms │  47.97ms │ +1.12x faster │
└──────────────┴──────────┴──────────┴───────────────┘

If it turns out that bounding memory usage inevitably reduces performance in a non-negligible way, I propose we introduce a configuration flag to control this. We can use the high-performance/unbounded behavior the default one, but one should still be able to choose the lower performance/bounded version for memory conscious use cases.

If it turns out that bounding memory usage inevitably reduces performance in a non-negligible way, I propose we introduce a configuration flag to control this. We can use the high-performance/unbounded behavior the default one, but one should still be able to choose the lower performance/bounded version for memory conscious use cases.

Sounds reasonable to me like a simple solution.
Slightly more complex: track the memory usage and maybe reserve up to 10-100MB for buffering (configurable). I guess at some point much more buffering won't really help anymore for performance.

If it turns out that bounding memory usage inevitably reduces performance in a non-negligible way, I propose we introduce a configuration flag to control this. We can use the high-performance/unbounded behavior the default one, but one should still be able to choose the lower performance/bounded version for memory conscious use cases.

I don't think we should ever be using unbounded memory ever if we can avoid it -- in this case if the producer goes faster than the consumer it will just buffer a huge amount of data (and eg will eventually OOM with TPCH SF100, or SF1000)
I like @Dandandan 's suggestion to introduce more buffering
Perhaps we could extend the existing DistributionSender to have a queue (2 or 3 for example) rather than just a single Option<> so that it was possible to start fetching the next input immediately
https://github.com/apache/arrow-datafusion/blob/d316702722e6c301fdb23a9698f7ec415ef548e9/datafusion/core/src/physical_plan/repartition/distributor_channels.rs#L180-L182

I don't think we should ever be using unbounded memory ever if we can avoid it

I agree, if we can avoid it without paying a noticeable penalty, we definitely should. Let's explore if we can.

I did some reading on this and it seems like the extra buffering approach could indeed be fruitful. I think we can land near a "sweet spot" in terms of the cost/benefit trade-off w.r.t. peak memory usage vs. performance.
Losing a small amount of performance in extreme cases (which would have had impractical peak memory usages had we used an unbounded channel anyway) is a small price to pay for having the backpressure mechanism in place and always avoiding OOM.

I will file a ticket describing the ideas in this thread, probably tomorrow

@YjyJeff Please read the reasoning here before experimenting with unbounded constructs:
https://github.com/apache/arrow-datafusion/blob/49583bd5010282ca126e75100dce958aa346e5ee/datafusion/core/src/physical_plan/repartition/distributor_channels.rs#L18-L39
Mainly, the reason that we are NOT using unbounded channels is that this just buffers large (potentially unbounded) quantities of data in many scenarios. Mostly this happens when the repartition producer side (e.g. trivial data reading like highly compressed parquet files) is way faster than the consumer side (e.g. complicated transforms or costly aggregations).
Note that I'm NOT saying that the current impl. is good (or even perfect), there are likley better options. But just slapping an unbounded channel on this problem is not going to solve it. Sure that wins in some micro-benchmarking but it fails to provide a robust foundation for query execution.[^1]
I agree w/ @ozankabak & Co though that SOME buffering is OK. So I think the following config option would be robust, reasonably fast and unsurprising to the user: A option "repartition buffer bytes OR messages" (or similar name) that limits bytes or messages per channel (not per repartition, otherwise the cross-comm overhead is too high) and only if this limit is met we fall back to the cross-channel gating behavior described in the code comment linked above (namely: we let data flow freely if there's at least 1 empty channel).
Ref #4867 and #4865.
[^1]: If someone finds a good metric, benchmark, or test for robustness, please open a ticket / PR. I am quite unhappy that this is currently mostly based on engineering intuition.

I will file a ticket describing the ideas in this thread, probably tomorrow

I wrote up a somewhat long ticket about my thoughts on this issue here:  https://github.com/apache/arrow-datafusion/issues/7001
I think there are some buffering / adaptivity tricks we could use that might result in some non trivial wins (the "adaptive repartition one in particular I am excited about")

Marking as draft as we come up with a plan


Update git2 crates for libgit2 0.28

See https://github.com/rust-lang/git2-rs/pull/425

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

It looks like the error message for auth failures was teaked a bit on Windows perhaps?

It's not just a change in the message.  This is #4591 resurrected.  There is a very subtle distinction here where the expected error is what happens when the credentials are retrieved, but rejected by the server.  The (new) error that is popping up is what happens when the credentials are not successfully retrieved.
I haven't looked specifically, but I suspect maybe newer versions of libgit handle sh on windows differently?  See the linked issue (and the upstream git2-rs issue) for more details on what can cause this.

Ah that's a good point, I've confirmed locally that this is caused by https://github.com/rust-lang/git2-rs/pull/402, although I'm not sure why yet.

Ok I think that change to git2-rs is ok and this is just a bug in the test.
I think that https://github.com/rust-lang/git2-rs/pull/429 plus https://github.com/rust-lang/cargo/pull/7018/commits/c35c90028e5d6926ad7cbe0fdcdda286853b0307 should do the trick.

Great, thanks for figuring it out!

@bors: r+

:pushpin: Commit c35c90028e5d6926ad7cbe0fdcdda286853b0307 has been approved by alexcrichton

:hourglass: Testing commit c35c90028e5d6926ad7cbe0fdcdda286853b0307 with merge e30ab5e7ccbadbc3de4a4ecd03106859902e4f4d...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing e30ab5e7ccbadbc3de4a4ecd03106859902e4f4d to master...


add support for eip-4494

https://eips.ethereum.org/EIPS/eip-4494
are there any dapps that actually use this? If so, add support

I couldn't find any protocols using this


android.support.v8.renderscript.RSRuntimeException

App crashed in some cellphones with the api below level 19.
android.support.v8.renderscript.RSRuntimeException:Error loading RS jni library: java.lang.UnsatisfiedLinkError: unknown failure
android.support.v8.renderscript.RenderScript.a(Unknown Source)
android.support.v8.renderscript.RenderScript.a(Unknown Source)
android.support.v8.renderscript.RenderScript.a(Unknown Source)
XYBlurringView.void initializeRenderScript(android.content.Context)(Unknown Source)

+1

+1

+1

+1

google has  fixed in Build Tools, Revision 23.0.3 . You can find the support package in /build-tools/24.0.0-preview/renderscript/lib.The problem has been resolved.

how did you guys integrate this library in your project? I put it in build.gradle but getting error "Failed to resolve: com.fivehundredpx:blurringview:1.0.0"


architecture diagram

how about change to this one?

nice！

@soulsoul Would you like to submit a PR to change the diagram in README to this one? Thanks!

@tokers  ok

fixed already by #301


Applied usage date range not displayed correctly when veiwing cluster price list

Describe the bug
Applied usage date range not displayed correctly when viewing cluster price list also cluster per month and node per month metrics show incorrectly.
To Reproduce
Steps to reproduce the behavior:

Go to openshift details
Click on three dots and show price list
See pop-up

Expected behavior
Text should be displayed correctly
Screenshots

There is also strange brackets after metrics do we need those??
Additional context
Testing against PROD, also producible against CI

Can you attach the /cost-models/<uuid> response to the issue too?
Thanks.

I am also confused because on ci-beta I can see these:

Might be related to that :man_shrugging: but cluster/node still seems incorrect for the metric on CI

Got it, no problem!


Fix more broken dynamic includes

I was unable to get the play to run with these dynamic includes, so ive abstracted them out.
On another note, we should get travis testing on this role

Which ansible version are you using?
Or how could i reproduce this issue?

Also, i agree about adding travis testing.
I've been using https://github.com/nickjj/rolespec for other roles.
Here is the specs repo:
https://github.com/pablocrivella/ansible-roles-specs
If you have a better way its much welcome.

I have been using the latest version of ansible, to reproduce the issue, run the play with the variables defined below, I also have a colleague that has run the play with 1.9.1, we use the following variables:
nvm_default_node_version: v0.12.7
nvm_env: system
nvm_version: v0.25.4
nvm_node_versions:
  - v0.12.7
  - v0.10.36
nvm_global_packages:: []

I'm very surprised this issue isn't happening to you, as it doesn't seem tied to my setup... happy to hear your thoughts

RE: testing, a good approach can be seen here https://github.com/ANXS/postgresql

Hey @farridav, i just ran the playbook and i didn't get any errors :confused:
TASK: [pablocrivella.nvm | include_vars {{ nvm_env }}.yml] ********************
ok: [js]

TASK: [pablocrivella.nvm | checkout nvm_repo] *********************************
changed: [js]

TASK: [pablocrivella.nvm | add nvm initialization to profile] *****************
changed: [js]

TASK: [pablocrivella.nvm | install versions] **********************************
changed: [js] => (item=v0.12.7)
changed: [js] => (item=v0.10.36)

TASK: [pablocrivella.nvm | set {{ nvm_default_node_version }} as default version] ***
changed: [js]

TASK: [pablocrivella.nvm | install packages] **********************************
changed: [js] => (item=['v0.12.7', 'bower'])
changed: [js] => (item=['v0.10.36', 'bower'])


Configuring options when using local json-rpc (Ganache)

How do you configure the options for each provider when using ganache?
The json notation for options is not clear on that aspect.
Thanks
Edit - Adding example for how I would do on Torus:
const torus = new Torus();
await torus.init({
    network: {
        host: "https://localhost:8545"
     },
});
await torus.login(); // await torus.ethereum.enable();
const web3 = new Web3(torus.provider);

How to reproduce these options in web3modal?

You can add as network to providerOptions, example:
import Web3 from "web3";
import Web3Modal from "web3modal";

const providerOptions = {
  /* See Provider Options Section */
};

const web3Modal = new Web3Modal({
  providerOptions: {
    torus: {
      package: Torus, // required
      options: {
        network: "https://localhost:8545"
       }
    }
  }
});

const provider = await web3Modal.connect();

const web3 = new Web3(provider);

This should actually be improved to allow for a full config object to be passed, I will keep this issue open until fixed

Yes, that would be great. It would be also interesting to see in your Readme how to pass the local rpc option for all the providers, and not just Torus, as in many cases I believe developers use local testing environments.
Thanks for the great work 👍

Definitely, I will keep this issue updated

@pedrouid I have noticed that by setting network as you mentioned, Torus connects fine and I can set web3, but then, when checking the current provider, the network ID (which sets itself to the default of 1) does not match the network ID of ganache (another number set by me)
There should be a way to set the id in the options object, I read in Torus docs and it is mentioned as 'chainID', but that does not seem work in web3modal as it keeps seting the id to 1, and not what I specified.

Fixed on v1.6.0

Hey @j-mars, check the README for how to configure for local networks, example:
const providerOptions = {
  torus: {
    package: Torus, // required
    options: {
      networkParams: {
        host: "https://localhost:8545", // optional
        chainId: 1337, // optional
        networkId: 1337 // optional
      },
      config: {
        buildEnv: "development" // optional
      }
    }
  }
};

Thanks!


STLink exception error while testing new target added

Hi, i added new stm32l476xg target. Everything seems OK and the Target is recognized:
pyocd-gdbserver -l
## => Board Name | Unique ID
-- -- ----------------------
 0 => STM32 STLinkV2-1 | 066EFF535550755187241812

(Note: I used flashalgo)
But, when i try one test, i get this error:
/pyOCD/test$ python ./flash_test.py
INFO:board:Target type is cortex_m
INFO:board:Target type is cortex_m
Exception STLink error (20): DP wait when testing board 066EFF535550755187241812
Traceback (most recent call last):
  File "./flash_test.py", line 109, in run
    result = self.test_function(board.unique_id)
  File "./flash_test.py", line 121, in flash_test
    with ConnectHelper.session_with_chosen_probe(board_id=board_id, **get_session_options()) as session:
  File "/home/osboxes/stage/pyOCD/pyocd/core/helpers.py", line 199, in session_with_chosen_probe
    session.open()
  File "/home/osboxes/stage/pyOCD/pyocd/core/session.py", line 281, in open
    self._board.init()
  File "/home/osboxes/stage/pyOCD/pyocd/board/board.py", line 66, in init
    self.target.init()
  File "/home/osboxes/stage/pyOCD/pyocd/core/coresight_target.py", line 152, in init
    seq.invoke()
  File "/home/osboxes/stage/pyOCD/pyocd/utility/sequencer.py", line 189, in invoke
    resultSequence = call()
  File "/home/osboxes/stage/pyOCD/pyocd/coresight/dap.py", line 98, in init
    self.link.connect()
  File "/home/osboxes/stage/pyOCD/pyocd/probe/stlink_probe.py", line 90, in connect
    self._link.enter_debug(STLink.Protocol.SWD)
  File "/home/osboxes/stage/pyOCD/pyocd/probe/stlink/stlink.py", line 215, in enter_debug
    self._check_status(response)
  File "/home/osboxes/stage/pyOCD/pyocd/probe/stlink/stlink.py", line 251, in _check_status
    raise self._ERROR_CLASSES[status](error_message)
pyocd.core.exceptions.TransferTimeoutError: STLink error (20): DP wait

------ Analyzer Performance ------
Target    Analyzer    Rate              Time

------ Test Rate ------
Target    Chip Erase          Page Erase          Page Erase (Same data)

cortex_m  Fail                Fail                Fail

Any idea? Thx

Hi @rgf97, it looks like the command to set the STLink to SWD mode is not succeeding. (I haven't seen this kind of issue before.) The "DP wait" error indicates that basic SWD communication to the DP isn't working; it gets an SWD "wait" protocol response. Although, I don't know what the STLink firmware is actually doing here.
First thing to check is whether you have the latest STLink firmware, V2J33M25 as of this writing. And I guess you're using the latest pyOCD code on master?
If it still happens, then it could be something with the target chip. Could it be in a bad state? Unfortunately, pyOCD currently doesn't support a "connect under reset" feature.
Btw, you will need to set the target type to use your new target. Either use the --target command line argument, or target_override user option (best set in a pyocd.yaml config file). When running the functional tests you have to use a config file to set the target type, as well as the test_binary option (set to just the name, not a path, of a file in the binaries/ directory).
Also, you should try out the CMSIS-Pack support. Just run pyocd pack -i stm32l476 to add that target. There are definitely some areas to improve and fix 😄 . And new builtin targets are always welcome.

@flit Thank you. I will try all your suggestions and give you feedbacks next week. (Yes it is the latest pyocd)

@flit Hi,  This error was caused by a specific error that I faced and solved in past days. I knew it was redundant, but I didn't notice it was at this point. I don't know why, but in my virtual machine (Linux VM on Windows), I need to flash (an application) to the board twice to make it work. And then, I can debug. I thought I needed to do that each time I launch the VM instead of each time I connect the board. So, flash an application twice into the board before making my tests solved this error. But i have another issue ... (Check New issue)

When i make test on a new board added, i get attribute or syntax errors like this:

What did I did wrong?

We've previously noticed issues with running in a VM, specifically VirtualBox, where USB packets get lost. I've taken a note to add something to the docs about this.


how do you make a patch to libchromium content

I want to make some changes chromium src files in libchromiumcontent, how do I make my own patch file?

Perhaps this is what you are looking for? https://github.com/atom/libchromiumcontent

We use atom/libchromiumcontent to maintain the patch to Chromium. If you need to customize libchromiumcontent, you need to build, and package it on local machine manually. Currently electron doesn't support the custom libchromiumcontent build #3310.

Maybe I didnt explain right. I have cloned atom/libchromiumcontent. And I have made some changes to \vendor\chromium\src\third_party\ffmpeg\chromium\scripts\build_ffmpeg.py I want to know how I can make a patch file, like there is plenty of in \patches already.

Use git diff to generate the patch file. The practice likes:
cd path-to-libchromiumcontent/vendor/chromium/src
git init
git add .
git commit -m "chrome v45"
// modify the src file
// git diff the src file

Exactly what I need, thank you very much!


VRCFury Compatibility

This breaks all toggles and items that use VRCFury.
https://github.com/VRCFury/VRCFury
Verified by converting avatar and uploading a test, and none of the item toggles that would show items enabled by VRCFury would work.

How did you use both tools together? If you run the optimizer before Fury it will break predictably. If you just upload the avatar, the different callback order of the two scripts should make it so Fury runs before my optimizer and things should be fine.

I did do the pre-convert as new instance instead of just doing the conversion at upload time. I'll try the at upload, and see if the toggles still work.

Is there still a problem for you with the toggles? I did a small test myself and at least simple toggles worked fine.
It now also disables the optimize button while a VRCFury component is on the avatar to prevent accidentally applying things in the wrong order.

I'm going to close this as there was no more follow up and several people use the optimizer with VRCFury just fine. Feel free to reopen or make a new issue if there are more specific issues with it.


02 - API - Backend

Hello, dear reviewer.

I made sure to complete the following requirements:

Create a new Rails API.
Initialize your project with Git.
Make sure that my project has a Postgres database set up.
Create a table for storing messages and create 5 different greetings.
Create an API endpoint that selects a random greeting from the table (I needed a controller with an action and rails route).

Reacts.js/Rails front-end
Reacts.js/Rails front-end pull request
Testing the API:
Note: In the image it is shown port 3000 but later I changed to port 3001

Thank you very much for your time.


HCI-UART: Bluetooth ACL data packets with 251 bytes not acknowledged

Describe the bug
I'm using the Zephyr HCI UART sample on an PCA10040 board as a HCI controller. As HCI host I've written an application on Windows that communicates over the HCI UART with the PCA10040 board and acts as a BLE host.
When a BLE peripehral is connected and data length extentions are activated (MTU => 251 bytes) sent ACL data packets with size of 251 bytes are not confirmed. If only 250 bytes are sent the confirmation is received by getting an HCI event "Number Of Completed Packets Event".
To Reproduce
Steps to reproduce the behavior:

Modify the configuration for the HCI UART sample with the following values:
BT_RX_BUF_LEN = 260
BT_CTLR_TX_BUFFER_SIZE = 251
BT_CTLR_DATA_LENGTH_MAX = 251
Screenshot of the configuration and a .config file is attached.
ZephyrKernelConfiguration.zip

Create Bluetooth Low Energy connection to a peripheral with DLE support for 251 bytes.

Trigger data length update to enhance the MTU to 251 bytes.

Send ACL data with a length of 250 bytes (e.g. an ATT write command with 243bytes data.

The sent ACL data is confirmed by a "Number Of Completed Packets Event" HCI event.

Send ACL data with a length of 251 bytes (e.g. an ATT write command with 244bytes data.

The sent ACL data is NOT confirmed by a "Number Of Completed Packets Event" HCI event.

Expected behavior
It is expected that the HCI UART device sends back an "Number Of Completed Packets Event" HCI event after sending the data to the peer device.
Environment:

OS: Windows
Toolchain: Zephyr SDK
Commit: d24e5e520c0649b1902c86ec6415384149776085

CC @joerchan @cvinayak @carlescufi

@AdrianEggenberger Could you enable CONFIG_ASSERT=y and check if you run into any asserts? You have to use the very latest commit, otherwise you need to enable CONFIG_NET_BUF_LOG=y to get the asserts in net_buf. Then we could see if any buffers are being overrun.

I've modified the configuration with the ASSERT and the NET_BUF_LOG support and tried again. There was no assert.
To get more information I've switched from HCI-UART to HCI-USB. This allowed to have a CONSOLE output over UART while using the USB interface for HCI. There error behavior is the same wiht HCI-USB.
I've created a log file with the same operation, but one time with the ACL data limited to 250 bytes and one time with the full 251 bytes.
ACL-DATA-250Bytes.log
ACL-DATA-251Bytes.log
Sending the 250 bytes works and there is always a "Num Complete" following the bt_send:
[00:00:21.904,754]  bt_hci_raw.bt_send: buf 0x20006e38 len 254
[00:00:21.904,785]  bt_ctlr_hci_driver.hci_driver_send: enter
[00:00:21.904,876]  bt_ctlr_hci_driver.hci_driver_send: exit: 0
[00:00:21.905,059]  net_buf: bt_buf_get_rx():54: Pool 0x20008118 blocked for 0 secs
[00:00:21.905,090]  bt_ctlr_hci_driver.prio_recv_thread: Num Complete: 0x0000:1
If 251 bytes are sent there is no "Num Complete" entry following.
[00:00:55.236,114]  bt_hci_raw.bt_send: buf 0x20006e20 len 255
[00:00:55.236,145]  bt_ctlr_hci_driver.hci_driver_send: enter
[00:00:55.236,206]  bt_ctlr_hci_driver.hci_driver_send: exit: 0

I today went back to this issue to get deeper into the topic. I checked out the latest release v2.2.0-rc1 und repeated my test that I've created for this issue. In short the issue seems to be fixed in the latest release.
Were there changes in the last weeks that explain the fixed behavior?
Anyhow as it's fixed now we can close the issue.

@AdrianEggenberger Thank you for testing. It could be 51c46d94ed could be related, and have fixed the issue you see.


chore: Add third example for multi-provider

Description
This PR adds another example for multi-provider configuration when calling this module with for_each. I commented the example because pre-commit broke due to this needing to be implemented slightly differently than the others.
Motivation and Context
In response to https://github.com/terraform-aws-modules/terraform-aws-acm/issues/146
Breaking Changes
None
How Has This Been Tested?

[X] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects
[X] I have executed pre-commit run -a on my pull request

@antonbabenko This method does not work without modifications to the module to support multiple provider configurations.


Keep proper data type for JSON arrays between conversions.

If you convert a JSON array into XML and back to JSON, every data types in the array will be converted to string.
ie., {"k": [34, true, "val"]} -> xml -> json => {"k": ["34", "true", "val"]}
That's fixed in this commit as is done for JSONObjects.

If I'm correct, this pull request should also address #7

There is more to it in #7
@aalmiray I've created a pull request against the master branch (hence checks failing)
Do you want it to be submitted against develop?

Submitted a new pull request ( #33 ) on develop branch, so closing this.


How to import data with references

How can I insert entries with references?
Let's say I have Content type Home and I have one field which is logo which is
Image asset and other one is reference from other content type.
I am able to export the entries but when I am trying to import I could only
Import textual data, not the image asset as well as the reference.
Can someone please help?

Hi Abhi,
I thing you are missing assets to import before content types and entries.
Before Content Types and Entries module import, we have to import assets module in stack.
For more questions raise a ticket to our help desk


Configuring app_access_token_validity validity under oauth.token_validation in toml not populated in the UI for new applications

we can customize access token validity period in UI for a new application we are creating by modifying in toml file.
when we use curl command it takes the configured validity period from toml.
when we try to generate a token from UI it shows the validity period 3600 which is an old one.
product version:3.0.0

Same behavior is observed for migrated applications (from 2.6.0) which have custom access token validity period configured.
Tested db: PostgreSQL


GEODE-2962: Add more messages for compact disk-store

Added a message in the case that notExecutedMembers variable is null.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Do I need write test code for this minor change? If so, please let me know.

Why is notExecutedMembers null?  Is that the issue that should be addressed instead of changing the message?

Your diffs now show 51 files changed. It now shows a removal of deprecated FunctionService API. Perhaps you are picking this up from changes others made?
You might need to close this PR and start a new one but can you get it back only showing the changes you are making?

Hello Darrel,
I'm sorry to make this PR confused. I updated this PR from other environment and it made this PR cause some differences in terms of my fork.
I'll close this PR and create other one.


Removing OwnedBuffer.Add and using Unsafe.Add

Resolves https://github.com/dotnet/corefxlab/issues/1529
cc @KrzysztofCwalina, @shiftylogic

looks good. thanks!!!


Jh765/4216 managing getting started md

See issue #4216
this PR replaced by #4880
This PR attempts to improve Developer Onboarding Documentation.
Includes final link fixes to getting-started, Using-Apple and README.md
copied getting_started.md to getting-started/getting-started.md
fixed . . / link refs
Test Steps:
There are no code changes.  Take a look at the finished doc(s) and check for broken links, English errors, and confusing instructions.
Changes
getting_started.md moved into the getting-started folder.
renamed getting_started.md to getting-started.md
internal links to other docs have been fixed
links to external files have been fixed
If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.
Test Steps:
No test steps, other than reading the docs and clicking the links.
Checklist
Testing

[x] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Fixes

#4216

To Be Done
Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Median time to review
Total comments

MauriceReeves-usds
52
58m
15

carlosfelix2
21
7h 44m
34

cwinters-usds
19
2h 35m
10

jimduff-usds
17
6h 14m
11

whytheplatypus
16
16h 44m
28

ahay-agile6
14
3h 2m
2

TomNUSDS
14
1h 9m
37

kevinhaube
10
1h 25m
7

oslynn
10
33m
2

jorg3lopez
10
1h 20m
7

TurkeyFried
8
12h 45m
4

sethdarragile6
8
3h 56m
0

jbiskie
7
16m
0

brick-green-agile6
7
21h 13m
2

rhood23699
6
57m
0

bgantick
5
1h 36m
4

meckila
4
2h 1m
7

JosiahSiegel
2
16m
0

jeremy-page
2
18h 53m
1

snesm
2
23h 48m
0

acoushawk
1
7m
0

RickHawesUSDS
1
51m
0

clediggins-usds
1
17h 4m
1

Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Median time to review
Total comments

MauriceReeves-usds
51
58m
15

carlosfelix2
21
11h 50m
30

cwinters-usds
19
2h 35m
9

jimduff-usds
17
5h 14m
11

ahay-agile6
15
2h 10m
2

whytheplatypus
14
16h
28

TomNUSDS
13
1h 6m
36

jorg3lopez
12
1h 18m
7

kevinhaube
10
1h 25m
7

oslynn
10
33m
2

sethdarragile6
8
3h 56m
0

jbiskie
7
16m
0

brick-green-agile6
7
21h 13m
2

TurkeyFried
6
52m
1

rhood23699
6
57m
0

bgantick
5
1h 36m
4

meckila
4
2h 1m
7

JosiahSiegel
2
16m
0

jeremy-page
2
18h 53m
1

snesm
2
23h 48m
0

acoushawk
1
7m
0

RickHawesUSDS
1
51m
0

clediggins-usds
1
17h 4m
1

replacing this with PR #4880


The parser should also allow custom class names

By default the parser uses the classes filtering-group, filtering-filter, filtering-item and enabled. There should be an option to specify other class names rather then the default ones.

Closed by https://github.com/robertpainsi/filtering.js/commit/70c8c948bf45d7b086aaeeec7e4555ca9c5e4f24


Question regarding experimental version && Stable version not working with latest YT app

Could you please clarify-
" No more apk updates - everything is magically done, when YT app is killed and opened"
does that mean YT app wont update if module is activated? or something else.. newbie here so pardon if question is too novice.
Regarding stable version:
Stable version is not working on Youtube app v 11.45.59, ROM: CM13
I would try the experimental version after the clarification.
Thanks :-)

"No more apk updates" - you don't have to download new module version everytime when YT is updated (like it was before). Since experimental version, we just need to update our sources (here, on github) but we don't need to post new apk on Xposed repo. Go ahead and try experimental 2.0.1 - it's working like stable (notification is visible all the time)

How does that work, by the way? Does the experimental module fetch some interpreted (JS?) sources from git?

It fetches a file containing the method hooks relevant for each of the supported YouTube versions and then simply applies it.

Oh, and regarding updates, the YouTube app can be updated individually at any time. The method hooks are checked and applied each time the YouTube package is loaded. That happens for example if you close the app and swipe it out from recents and then reopen it.

Thanks, which file is that? Curious to take a look (programmer myself, not Android though).

@gene-pavlovsky Methods are in YouTubeBackgroundPlayback/assets/hooks-1.json file. The rest of the code is in YouTubeBackgroundPlayback/java/com/pyler/youtubebackgroundplayback/YouTubeBackgroundPlayback.java file.
File with methods is updated most of the times within 24h from new YT app is being released (and uploaded ex. on apkmirror.com). Everytime module gets updated, there is a commit named with latest YT app version... ex. if the latest version of youtube is 11.47.55 and the module supports it, there should be a commit titled with this version (Like this)

That's a great idea with the JSON file and serving it straight from github. And thanks for the detailed explanation, all clear now.


refactoring vend method to avoid repo pinging

fix tree printing and add Godeps filtering
do not clear vendor for --hold

I can confirm that govend -v feels MUCH faster now.


fullScreen set to false in manifest causes issues with system bars showing

This may not be an bug, but I thought I'd bring it up in case it can be solved.
I had cropping in my app, which was related to Issue #7
Setting it to:
false
in the Android manifest solved the problem.
However in doing this, it caused other minor problems to appear, that didn't happen when fullScreen was set to true. I have several other ANEs hooked into the app (Google Play Games, Facebook etc.) and when fullScreen is set to false, while those extensions show the status/menu bars show too.
This is happening on two different Android devices (HTC One and Nexus 7) I've tested on, both running Android 5.0.2
I've tried a number of things to try and fix this, but have had no luck so far. Any idea on whether this can be fixed, or is it a limitation of the operating system or Adobe AIR?

This sounds similar to issue #11, where the bars appeared when the system power menu was displayed on some devices.
Unfortunately, this appears to be a combined limitation of AIR (which miscalculates the screen height when fullScreen is true) and the OS (we have no control when the app isn't focussed).
Right now, the ANE should automatically reset the screen when the app next receives focus; if not, you'll need to manually reset the screen when your other ANEs close.


Retire help article without migration.

What's wrong?
Please retire https://help.aiven.io/en/articles/4386696 which was originally written as an alternative to SAML IdP. Since SAML IdP feature is in place, the original help article can be retired.
URL of affected page, and any other information
Original discussion is here.

It might make sense to link to the standard SAML setup page as it talks about the IdP login there

Would that be https://help.aiven.io/en/articles/4386696 pointing to https://docs.aiven.io/docs/platform/howto/list-saml.html?
If that's the case, I can add entries to the migration spreadsheet accordingly @lornajane .

That would be helpful, thanks. Close this issue once no further actions are needed.

Relevant entries added to the migration spreadsheet. Closing this issue.

Yup. Thank you!
( https://www.facebook.com/aivencloud ) ( https://twitter.com/aiven_io ) ( https://www.linkedin.com/in/christopher-gwilliams-51322924/ )
Dr. Chris Gwilliams
Staff Solution Architect
Solution Architecture | Aiven
+358444915385
@.***
aiven.io ( http://aiven.io )
Helsinki, Finland
On Tue, Aug 30 2022 at 2:26 AM, Dewan Ishtiaque Ahmed < @.*** > wrote:

Would that be https://help.aiven.io/en/articles/4386696 pointing to https://docs.aiven.io/docs/platform/howto/list-saml.html
?
If that's the case, I can add entries to the migration spreadsheet
accordingly @lornajane ( https://github.com/lornajane ).
—
Reply to this email directly, view it on GitHub (
https://github.com/aiven/devportal/issues/1320#issuecomment-1230969974 ) ,
or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AAD6OI7PEFD22KKLAAOO4S3V3VBLBANCNFSM577DEUKA
).
You are receiving this because you commented. Message ID: <aiven/devportal/issues/1320/1230969974
@ github. com>


Squash migrations to prep for staging deployment

A single migration should be faster to run. That's probably the last time we'll get to do something like this because once deployed, migrations shouldn't be edited.

@OmarIthawi I'm not sure that squashing the migrations really buys much time, but I do like the idea of squashing migrations for the initial release of an app and sometimes also if one creates a number of migrations in process of adding a data model update.

I agree with you that it may not have that much of value, but I'm biased towards having a single migration at first. At least it would make it easier to maintain the migrations due to inevitable major Python or Django updates. Which touches the syntax of the migration but not the semantics of it.
Anyway, I think we can agree that this specific PR is not a problem.

However, there is one thing that I believe is important for "post initial production release" migrations. That is to keep separate migrations that are additive from those that change existing data. Typically, I see this referred to as "schema migrations" and "data migrations".
But there is a subtlety, normally, a schema migration also includes changing existing data along with the schema change. I prefer to avoid this because my experience is that it has higher risk for rollback than separating "additive schema changes" and "existing data changes". I'll write up my thoughts in more detail in Confluence

Good idea, I'd like to hear more about this.


[bug] Using get_fresh with dot separated variable is broken

Describe the bug
Using the Fresh getter with any dot separated key always returns None after the initial call and fails to load from external loaders. For example, if your settings file consists of:
[foo]
bar = "baz"

Then calling settings.get("foo.bar", fresh=True) will return "baz" the first time, but then return None any future call. The reason for this is that within the get method on the Settings class, the recursive self._dotted_get function splits the parent and child so that on the first call to self._get from within self._dotted_get, it reaches the if fresh line and tries to load the value solely based on the parent key and not does not include any of the children.
To Reproduce
Steps to reproduce the behavior:

Having the following folder structure

config.py
settings.toml
test.py

Having the following config files:

from dynaconf import Dynaconf

settings = Dynaconf(
    envvar_prefix="DYNACONF",
    settings_files=["settings.toml"],
    redis_enabled=True,
    apply_default_on_none=False,
)

/path/settings.toml
[foo]
bar="baz"

Having the following app code:

Using dynaconf -i config.settings  write redis -v foo.bar=test
/path/src/app.py
import time
from dynaconf.loaders import redis_loader
from config import settings
from redis import StrictRedis

redis = StrictRedis(host='localhost', port=6379)

pubsub = redis.pubsub()
pubsub.psubscribe('__keyspace@0__:DYNACONF_MAIN')

try:
    while True:
        message = pubsub.get_message()
        if message and message.get("pattern", None):
           print("NEW", settings.get_fresh("foo.bar")

        print("CURRENT", settings.get("foo.bar", fresh=True))
        time.sleep(1)
except:
    print("EXITING")
    redis_loader.delete(settings)

Executing under the following environment

$ python test.py
$ dynaconf -i config.settings  write redis -v foo.bar=test` (in a separate terminal)

**Expected behavior**
The reason for the bug is described above. Expected result is that the dotted variables work with Fresh updates

get_fresh doesnt support dotlookup
Not sure if this is a bug or just undocumented behavior.
https://github.com/dynaconf/dynaconf/blob/010bd4d43fccaed66667fc1862b657c02958b4d6/dynaconf/loaders/base.py#L219
Workaround
# first take the root level key
settings.get_fresh("foo").get("bar")


implement delete in fileshare

in progress?

Be sure to use PR for this! @JonasWijne should merge


Month view

It is limited to days or it can be change to Month view

nah, month view is not supported, because it is a weekView project. If you want to do month view, you can check JTAppleCalendar

No worries I need to then work out for solution as I need month and week
view both.
Thanks for your quick reply , have a great day !!
On Sun, Apr 14, 2019, 20:41 Jeff Zhang<EMAIL_ADDRESS>wrote:

nah, month view is not supported, because it is a weekView project. If you
want to do month view, you can check JTAppleCalendar
https://github.com/patchthecode/JTAppleCalendar
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zjfjack/JZCalendarWeekView/issues/59#issuecomment-482945660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPSb3oDSH_hPATgwk14NBbMtgoJBAVGks5vgwW_gaJpZM4crXDP
.


jfoenix website down

jfoenix.com not working

Unfortunately that's true, it's a bit hard to maintain the website without some funds..., so for the time being i'm sticking with the git repo / its wiki. Thank you for your understanding.


Consumer is not consuming from some of the topics that it's subscribed to

Describe the bug
A consumer that has subscribed to multiple topics is not consuming from some of the topics that it's subscribed to
To Reproduce
N/A
Expected behavior
If a consumer is subscribed to multiple topics and its lags behind in more than one, it consumes from each topic in a round robin fashion.
Observed behavior
The consumer was consuming from multiple topics and then it stopped consuming from a few of them.
Environment:

OS: IBM Cloud
KafkaJS version 1.12.0/also tested with ^.13.0-beta.62
Kafka version 2.3
NodeJS version v12.18.2

Additional context
There was no error; the consumer was simply not consuming. I also see that the consumer is correctly identifying the total number of the topics it needs to be consuming from:
'[ConsumerGroup] Fetching from 7 partitions for 7 out of 7 topics'
The way to resolve the issue was to remove all of the topics from the list of the topic that the consumer has subscribed to and then leave only the one which initially was not being consumed from. Not sure what caused the issue. The issue was resolved without changing any of the other client/consumer configuration. I've checked and min/max bytes are fine as well (1 and 200kb, much larger than the typical message sizes).
I am leaving basically all of the code here in case there's something incorrect in how I've subscribed to the topics.
Thanks!
const { consumerConfig, backoff, failureBackoff, beaconTopic } = require('../constants')
const { invokeCloudFunction } = require('../cloudfunctions')
const { sleep } = require('../utils')

/**
 * @param {import('kafkajs').Kafka} kafka
 * @param {string | undefined} groupId
 */
async function getConsumer(kafka, groupId){
  const consumer = kafka.consumer({
    ...consumerConfig,
    groupId: groupId || consumerConfig.groupId
  })
  await consumer.connect()
  return consumer
}

class Binder {
  /**
   * @param {{
    * kafka: import('kafkajs').Kafka,
    * groupId: string,
    * namespace: string,
    * topicActionsMapping: { [topci: string]: string },
    * disabledTopics: string[]
   * }} ConsumerConfig
   */
  constructor ({
    kafka,
    namespace, // cloud function namespace
    topicActionsMapping,
    disabledTopics,
    groupId
  }) {
    this.consumerCrashed = false
    this.lastMessageConsumptionDate = new Date()
    this.kafka = kafka
    this.topicActionsMapping = topicActionsMapping
    this.namespace = namespace
    this.disabledTopics = disabledTopics
    /**
     * @type {null|import('kafkajs').Consumer}
     */
    this.consumer = null
    this.groupId = groupId
  }

  async start () {
    const topicActionsMapping = this.topicActionsMapping
    const disabledTopics = this.disabledTopics
    const consumer = await getConsumer(this.kafka, this.groupId)
    this.consumer = consumer
    const topicsToSubscribe = Object.keys(topicActionsMapping).filter(topic => !disabledTopics.includes(topic))
    for (const topic of topicsToSubscribe) {
      console.info('Subscribing to topic: ', topic)
      await consumer.subscribe({ topic, fromBeginning: true })
    }
    await consumer.run({
      eachBatchAutoResolve: false,
      eachBatch: async ({
        batch,
        resolveOffset,
        heartbeat,
        isRunning,
        isStale,
      }) => {
        this.lastMessageConsumptionDate = new Date()
        if (batch.topic === beaconTopic) {
          console.log(`${this.groupId} consumed beacon message: `, beaconTopic)
          for (const message of batch.messages) {
            if (!isRunning() || isStale()) break
            resolveOffset(message.offset)
          }
          await heartbeat()
        } else {
          try {
            const actionName = topicActionsMapping[batch.topic]
            const messages = batch.messages.map(({ value, offset }) => ({
            // These fields are added to enable debugging issues
            // Specifically, topic will be used by the retry mechanism to requeue the message in case it has failed.
              topic: batch.topic,
              partition: batch.partition,
              offset,
              // value is a Buffer with a toString method
              value: JSON.parse(value.toString())
            }))
            console.log(`${this.groupId} batch length: `, batch.messages.length)
            console.log(`${this.groupId} sample message: `, messages[0])
            await invokeCloudFunction({ namespace: this.namespace, actionName }, messages)
            // Note: refer to addLoggingToMain function in hr-platform for details of how res.error and res.storeBatchFailed are set.
              .catch((/** @type {any} */ res) => {
                const error = new Error('Cloud function batch failed due to unforseen issues.')
                console.error(error, res)
                if (!res.error) {
                  res.error = error
                }
                if (res.storeBatchFailed != 0) {
                  res.storeBatchFailed = 1
                }
                return res
              }).then(async (/** @type {any} */ res) => {
                if (res && (res.error && res.storeBatchFailed != 0)) {
                // Skip resolving offsets if batch has failed and batch was not stored for retry
                // If the offsets are not resolved, the consumer will consume the same messages again in its next run
                // Sleep to prevent an immediate retry in case of transient errors e.g. database is overlaoded
                  await sleep(failureBackoff)
                  return
                }
                for (const message of batch.messages) {
                  if (!isRunning() || isStale()) break
                  resolveOffset(message.offset)
                }
              })
          } catch (error) {
            console.error(`Failed to process the batch for topic ${batch.topic}: `, error.message)
          } finally {
            await heartbeat()
          }
          await sleep(backoff)
        }
      },
    })

    const removeListener = consumer.on(consumer.events.CRASH, async (e) => {
      console.error('Crashed: ', e)
      if (!e.payload.error.retriable) {
        // If there is an issue at the consumer level but not at the kafka instance level
        // the start function will be succesfully run, but the consumer will crash
        try {
          await consumer.disconnect()
          removeListener()
        } finally {
          this.consumerCrashed = true
        }
      }
    })
  }
}

module.exports = Binder

Perhaps relevant, what happens if one topic cannot consume as fast as messages are being produced in it? Will it cause an issue with the round-robin scheduler?

So I looked into this more and if my understanding is correct, this is the expected behavior of Kafka:
https://www.cloudkarafka.com/blog/2019-09-11-a-dive-into-multi-topic-subscriptions-with-apache-kafka.html
There is no guarantee that the topics subscribed to will be processed in specific order.
I'm not closing the ticket in case I'm misunderstanding, but if someone can confirm this, please close the ticket. Thanks!

I'm not closing the ticket in case I'm misunderstanding, but if someone can confirm this, please close the ticket. Thanks!

I believe you are correct. We don't control any of that on the client side. It's entirely up to the brokers to determine how to allocate the responses across the partitions we ask for. I'm a little surprised that you would only get data for one partition, rather than a little data for several partitions, but it's not something we control on our side.