MasterCluster.initialize method

I'd like to ask you to consider allowing me to slightly alter the behavior of the MasterCluster by forcing it to be explicitly started with an initialize(): void method. In a project of mine(Sidekick AI if you've interest) I have a modified copy of the package currently allowing this behavior.
The reason I ask for this is it makes testing the integration with the package easier. At least it did for me; if you question that assertion I will share some of the tests that show what I mean but basically it revolves around the way test runners function.
As I'm writing this I actually realize we can implement this in a way that's backwards compatible as well if we allow the MasterCluster to have a default behavior of calling initialize in the constructor that can be disabled by passing a flag like autoInitialize: false. I'm somewhat indifferent whether you want to include the flag or not.
For reference here is my in production modified version of the MasterCluster(I've chosen to omit the rest of the repo for brevity but I'll zip and attach here if you need). NOTE: this version does not have the updates I made in https://github.com/nathanschwarz/meteor-cluster/pull/10 but they would obviously be included in the finished product
import { Meteor } from 'meteor/meteor'
import StaticCluster from './StaticCluster'
import TaskQueue from '../TaskQueue'
import WORKER_STATUSES from '../Worker/statuses'
import MasterWorker from '../Worker/MasterWorker'
import { warnLogger } from '../logs'

const process = require('process')

const MAX_CPUS = StaticCluster.maxWorkers()

class MasterCluster extends StaticCluster {
	/*
		@params (taskMap: Object, masterProps: { port: Integer, maxAvailableWorkers: Integer, refreshRate: Integer, inMemoryOnly: Boolean })
		initialize Cluster on the master
	*/
	constructor(taskMap, { port = 3008, maxAvailableWorkers = MAX_CPUS, refreshRate = 1000, inMemoryOnly = false, messageBroker = null } = {}) {
		super()
		Meteor.startup(() => {
			if (maxAvailableWorkers > MAX_CPUS) {
				warnLogger(`cannot have ${maxAvailableWorkers} workers, setting max system available: ${MAX_CPUS}`)
				this._cpus = MAX_CPUS
			} else if (maxAvailableWorkers <= 0) {
				warnLogger(`cannot have ${maxAvailableWorkers} workers, setting initial value to 1`)
				this._cpus = 1
			} else {
				this._cpus = maxAvailableWorkers
			}
			if (this._cpus === MAX_CPUS) {
				warnLogger(`you should not use all the cpus, read more https://github.com/nathanschwarz/meteor-cluster/blob/main/README.md#cpus-allocation`)
			}
			this._port = port
			this._workers = []
			this.inMemoryOnly = inMemoryOnly
			this.messageBroker = messageBroker
			this.refreshRate = refreshRate

			// find worker by process id
			this.getWorkerIndex = (id) => this._workers.findIndex(w => w.id === id)
			this.getWorker = (id) => this._workers[this.getWorkerIndex(id)]

			// update all previous undone task, to restart them (if the master server has crashed or was stopped)
			TaskQueue.update({ onGoing: true }, { $set: { onGoing: false } }, { multi: true })

			// initializing interval
			this.interval = null
		})
	}

	/*
		@params (wantedWorkers: Integer)
		add workers if tasks > current workers
		remove workers if tasks < current workers
		@returns non idle workers
	*/
	_getAvailableWorkers(wantedWorkers) {
		const workerToCreate = wantedWorkers - this._workers.length
		if (workerToCreate > 0) {
			for (let i = 0; i < workerToCreate; i++) {
				const worker = new MasterWorker(this.messageBroker)
				worker.register({ ...process.env, PORT: this.port })
				this._workers.push(worker)
			}
		} else if (workerToCreate < 0) {
			this._workers.filter(w => w.isIdle && w.isReady).slice(workerToCreate).forEach(w => w.close())
		}
		this._workers = this._workers.filter(w => !w.removed)
		return this._workers.filter(w => w.isIdle && w.isReady)
	}

	/*
		@params (availableWorkers: Worker)
		dispatch jobs to idle workers
	*/
	async _dispatchJobs(availableWorkers) {
		for (let i = 0; i < availableWorkers.length; i++) {
			const job = await TaskQueue.pull(this.inMemoryOnly)
			if (job !== undefined) {
				availableWorkers[i].startJob(job)
			}
		}
	}

	/*
		called at the interval set by this.setRefreshRate
		gets jobs from the list
		gets available workers
		dispatch the jobs to the workers
	*/
	async _run() {
		const jobsCount = TaskQueue.count(this.inMemoryOnly)
		const hasJobs = jobsCount > 0
		const wantedWorkers = Math.min(this._cpus)
		const availableWorkers = this._getAvailableWorkers(wantedWorkers)
		await this._dispatchJobs(availableWorkers)
	}

	/**
	 * Starts the Cluster._run interval call determined by this.refreshRate
	 */
	initialize() {
		if (this.interval != null) {
			Meteor.clearInterval(this.interval)
		}
		this.interval = Meteor.setInterval(() => this._run(), this.refreshRate)
	}
}

export default MasterCluster

You can make a pull request if you want.
To avoid breaking changes the initialize function should be called by default, a Boolean flag in the constructor should do the trick.


TURBO functions not fully working

Prerequisites
Please check the following before posting an issue / bug report.

[yes] I am running the latest version of the firmware found HERE
[yes] I have checked the documentation HERE and found no answer
[yes] I checked to make sure that this issue has not already been filed HERE
[yes] I am reporting the issue to the correct repository

Context
Please provide all relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

I'm using an RP2040-Zero, testing on a breadbord.

Expected Behavior
Basic TURBO function is working OK, but seems to be capped at 3 shots/second.
Two functions available in the web config, Turbo Shot Count and Turbo Dial doesn't seems to work.
Current Behavior
-"Turbo Shot Count" - Doesn't change the frequency of the shots, as said before seems capped a 3Hz.
-"Turbo Dial" - I connected a 10K potentiometer on GP29 (after changing the default pin assignment) but doesn't seems to do any change in the shoots frequency.

Hey @fostrike,
Are you connecting the pot to an ADC pin?

Yes, pin 29 but there is no way to make mistakes, the web interface force you to pick only the 4 analog pins available.

For the potentiometer, you have to use an ADC pin. Can you try GP26-GP28? There is a chance it doesn't work on GP29 on the rp2040 zero.
Turbo button itself is working fine on the latest build.

OK Arntsonl, you are totally right, if I use the default port pin 26 as analog input the DIAL function works fine and the actual turbo value can be see in real time on the OLED.
I'm using the Waveshare RP2040-Zero, that's why i changed the ADC default pin.
Thank you!
By the way, yesterday was looking at the turbo.cpp code, I'm not a programmer so... but this line seems strange..
adcShmupDial = 26 - options.shmupDialPin;

Closing as resolved


Throw an error on illegal hostname characters.

This pull request depends on #20.  Please merge that one first.

This is part of #7.


Bump tower cli version to v0.5

DO NOT MERGE. This will break everything because of this line in the v0.5 changelog:

At tw launch only accepts full URL repositories as Nextflow pipelines.

We provide ${{ github.repository }}, which is the GitHub repo name, eg. nf-core/viralrecon


non-standard

Most function did not adopt powershell standard:

not using standard verbs (you can get via command Get-Verb)
powershell function usually consists of - (like start-process, get-childItem)
uses alias in script, this is not recommended, and the alias is possible to be removed in the future, see this thread: https://github.com/PowerShell/PowerShell/issues/929

If you are willing to change all the these, I can create a pull request to change them.

Thanks, but I've ignored powershell conventions on purpose because I prefer
the more common git style.
On Sat, 27 Aug 2016 at 12:53 PM, Cheng Zhang<EMAIL_ADDRESS>wrote:

Most function did not adopt powershell standard:

not using standard verbs (you can get via command Get-Verb)
powershell function usually consists of - (like start-process,
get-childItem)
uses alias in script, this is not recommended, and the alias is
possible to be removed in the future, see this thread:
PowerShell/PowerShell#929
https://github.com/PowerShell/PowerShell/issues/929

If you are willing to change all the these, I can create a pull request to
change them.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lukesampson/psutils/issues/11, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGUFro0z_4Gt7yvSAX_kfjbwBt7PIUEks5qj6bEgaJpZM4JumL-
.

okay, that is fine.
Thanks for replying so fast


Favors strategy overrides for top-level dependencies

Fixes regression for #55.

thanks. it also fixes https://github.com/fsprojects/Paket/commit/0e4557086fb4c5f3dda7761efa1037de24d459cf

For a paket.dependencies like this:
strategy min
source http://nuget.org/api/v2

nuget Nancy.Bootstrappers.Windsor ~> 0.23
nuget Castle.Windsor

What do you think the version of Castle.Windsor should be when we update all?
3.2.1 (favoring the strategy option) or 3.3.0 (lastest one)
I mean, when we are updating all and resolving top-level dependencies that are also transitive, should we only favor strategy overrides (! and @), or should we favor the strategy option also?

3.2.1 is the only version that works with Nancy.Bootstrappers.Windsor 0.23

/cc @agross

Sorry, may be that was a bad example.
How about this one:
strategy min
source http://nuget.org/api/v2

nuget Castle.Core
nuget Castle.Windsor

Note the strategy min. What do you think the version of Castle.Core should be when we update all?
3.2.1 (favoring the strategy option) or 3.3.0 (lastest one)

yeah that is really tricky. I guess we can take any Castle.Windsor (probably the latest) and need to find the lowest matching Castle.Core

Alright. This PR is fine then.

cool. https://github.com/fsprojects/Paket/commit/7f10a2fc3964786937a48924c5bc7b767d12787b

Cool! :+1:


Possible memory corruption problem in c encoder

I believe (but can not prove directly) that the C mutf8 encoder sometimes must create and return invalid buffers that when used later trigger a segmentation fault... or maybe something is corrupted in the memory stack that causes the cpython allocator to fail later. I'm not sure.
I almost hate to report this because I'm not sure it's actually a problem caused by this package... But it only happens when I use the c-encoder specifically, like this:
from mutf8.cmutf8 import encode_modified_utf8
from mutf8.mutf8 import decode_modified_utf8

To be clear it also happens if I use the cmutf8 library for both encode AND decode. But does not happen if I reverse these (c decode, python encode), or use the pure-python version for both.
My hesitancy is that I haven't managed to actually crash in this module. The segfault happens elsewhere when manipulating strings. It's possible that using this module is just shifting the memory around in just the right way to trigger a crash caused by a bug elsewhere...
For background, I am writing automation tools against data produced by Minecraft (Java, hence mutf8). Each player file is stored as a binary compressed format each containing thousands of individual mutf8-encoded strings, and there are thousands of such player files. I unpack these into python data structures and manipulate them using this mutf8 library (among other things). I've been trying to track down a segmentation fault being thrown by an incredibly obscure combination of player data processing, and the only common denominator seems to be using the c-accelerated mutf8 decoder. For now I can "fix" my problem by using the python encoder... but this code is somewhat performance sensitive so I'd prefer not to be stuck with that forever.
I have some input data and a tool that can reproduce this consistently so I could test a fix easily, but our clunky software would likely be a pain to get running on a different system, and might not trigger the same crash just by luck. Ugh.
I doubt this is useful, but here's the GDB backtrace and py-bt backtrace:
https://cdn.discordapp.com/attachments/447933054317494283/925131702613966848/gdb_segmentation_fault_backtrace.txt
I am on python 3.6.9 and mutf8 1.0.5. Using Ubuntu 20.04 on an x86_64 Intel system.

Unfortunately that backtrace isn't super useful, like you surmised. If it is a memory corruption issue you should try running with the debug allocator enabled (PYTHONTRACEMALLOC=1 in your environment). I'll give the C encoder another look for something obvious, but if you can come up with a consistent reproduction that would be easiest.

Is it possible that length * 2 is not actually enough memory? That would explain it - overwriting beyond the end of the buffer would cause this behavior (corrupting nearby heap allocated objects). I'll re-run with the PYTHONTRACEMALLOC

Not sure what I'm looking for here actually - any advice for how to run this so that it will produce useful results?
I inserted these lines as close as possible to the place where it segfaults:
     snapshot = tracemalloc.take_snapshot()
     top_stats = snapshot.statistics('lineno')

     print("[ Top 10 ]")
     for stat in top_stats[:10]:
         print(stat)

With output
[ Top 10 ]
/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/registry.py:102: size=16.3 MiB, count=123504, average=138 B
/usr/lib/python3.6/json/decoder.py:355: size=11.1 MiB, count=149096, average=78 B
/home/epic/automation/quarry/quarry/types/../../brigadier.py/brigadier/string_reader.py:200: size=5275 KiB, count=43926, average=123 B
<frozen importlib._bootstrap_external>:487: size=5019 KiB, count=51561, average=100 B
/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py:1393: size=4278 KiB, count=78697, average=56 B
/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py:1376: size=3909 KiB, count=27525, average=145 B
/home/epic/automation/quarry/quarry/types/../../brigadier.py/brigadier/string_reader.py:157: size=2984 KiB, count=55467, average=55 B
/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py:1253: size=2098 KiB, count=44745, average=48 B
/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py:459: size=1824 KiB, count=25750, average=73 B
/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/registry.py:176: size=967 KiB, count=3344, average=296 B

Haven't used this tool before, not sure exactly what use would be actually useful.

You shouldn't need to change your code at all, you just want to trigger the segfault. Sorry, I'm so used to having a debug build of the interpreter I forgot some things aren't on by default. You also want:
PYTHONMALLOC=debug PYTHONTRACEMALLOC=1 PYTHONFAULTHANDLER=1 python <your reproduction example>

PYTHONMALLOC=debug will switch to a debug allocator. It'll fill the memory with a bit pattern and look for over and under accesses.
PYTHONTRACEMALLOC=1 will help fill in where allocations were made when the fault happens.
PYTHONFAULTHANDLER=1 will cause the interpreter to dump a trace when it dies to a fault (no need to open up gdb)

This is really cool!
Debug memory block at address p=0x9843560: API 'm'
    14 bytes originally requested
    The 7 pad bytes at p-7 are FORBIDDENBYTE, as expected.
    The 8 pad bytes at tail=0x984356e are not all FORBIDDENBYTE (0xfb):
        at tail+0: 0x84 *** OUCH
        at tail+1: 0xe8 *** OUCH
        at tail+2: 0xa3 *** OUCH
        at tail+3: 0x9d *** OUCH
        at tail+4: 0xe5 *** OUCH
        at tail+5: 0x8c *** OUCH
        at tail+6: 0x85 *** OUCH
        at tail+7: 0xfb
    The block was made by call #26938610 to debug malloc/realloc.
    Data at p: e9 bb 91 e4 ba ba e6 8a ac e6 a3 ba e7 b5

Memory block allocated at (most recent call first):
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 462

Fatal Python error: bad trailing pad byte

Current thread 0x00007fac82511740 (most recent call first):
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 462 in to_bytes
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 824 in to_bytes
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 824 in to_bytes
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 578 in <genexpr>
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 578 in to_bytes
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 824 in to_bytes
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 824 in to_bytes
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 824 in to_bytes
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 578 in <genexpr>
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 578 in to_bytes
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 824 in to_bytes
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 824 in to_bytes
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 1471 in save
  File "/home/epic/automation/utility_code/minecraft/player_dat_format/player.py", line 246 in save
  File "/home/epic/automation/utility_code/minecraft/world.py", line 203 in iter_players
  File "/home/epic/automation/utility_code/minecraft/world.py", line 227 in iter_players_parallel
  File "utility_code/weekly_update_player_data.py", line 95 in <module>

This still doesn't point to the encoder though. Any way to figure out what call 26938610 is doing? Fortunately it seems to be deterministic (same error run both times I tried)

Memory block allocated at (most recent call first):
  File "/home/epic/automation/utility_code/lib_py3/../../quarry/quarry/types/nbt.py", line 462

This is the line of interest, what's the code around nbt.py line 462? Is it calling the encoder/decoder?

Oh cool. It is indeed: https://github.com/TeamMonumenta/quarry/blob/79bbb0d21de66639a379fb9f8f932892956a0105/quarry/types/nbt.py#L462
    def to_bytes(self):
        data = encode_modified_utf8(self.value)         <- 462
        return Buffer.pack('H', len(data)) + data

Alright, so it is an encoder issue. Can you dump self.value and add it here? Looks like we are writing 7 bytes too far for what we've allocated.

Awesome! Thanks a ton for your guidance. We finally have a reproducer:
from mutf8.cmutf8 import encode_modified_utf8, decode_modified_utf8

str = '黑人抬棺組裝包'
encode_modified_utf8(str)

print("done")

In the event that github doesn't like this unicode either:
https://cdn.discordapp.com/attachments/447933054317494283/925251494616387624/test.py
Running it on my system with the memory flags gets flagged by the debugger infrastructure
» PYTHONMALLOC=debug PYTHONTRACEMALLOC=1 PYTHONFAULTHANDLER=1 python3 test.py
Debug memory block at address p=0x2248490: API 'm'
    14 bytes originally requested
    The 7 pad bytes at p-7 are FORBIDDENBYTE, as expected.
    The 8 pad bytes at tail=0x224849e are not all FORBIDDENBYTE (0xfb):
        at tail+0: 0x84 *** OUCH
        at tail+1: 0xe8 *** OUCH
        at tail+2: 0xa3 *** OUCH
        at tail+3: 0x9d *** OUCH
        at tail+4: 0xe5 *** OUCH
        at tail+5: 0x8c *** OUCH
        at tail+6: 0x85 *** OUCH
        at tail+7: 0xfb
    The block was made by call #57018 to debug malloc/realloc.
    Data at p: e9 bb 91 e4 ba ba e6 8a ac e6 a3 ba e7 b5

Memory block allocated at (most recent call first):
  File "test.py", line 5

Fatal Python error: bad trailing pad byte

Current thread 0x00007f284cb6c740 (most recent call first):
  File "test.py", line 5 in <module>
[4]    25162 abort (core dumped)  PYTHONMALLOC=debug PYTHONTRACEMALLOC=1 PYTHONFAULTHANDLER=1 python3 test.py

This thread has definitely been the highlight of my day. I've spent basically the last three days tracking this down and it's been really satisfying to have quick expert responses that narrowed this down so fast to the actual problem. I was honestly just expecting to throw my debugging away and be stuck with the python version forever, since I couldn't go any further. Will be useful to know about these features working with python native code in the future. Really fun. Thanks!
I'm in no particular rush for a solution, just glad to have my debugging work go somewhere.

Release 1.0.6 is building now and should resolve this issue. Thanks for the report and the reproduction.


Add a sample .service file to run this on Linux as a systemd service

Hey @unsocial-bleach,  we have an open PR for this https://github.com/philippnormann/chia-monitor/pull/48, but I'm still waiting for feedback.

Thank you!


Add cc and bcc support to SMTP transport

is lack of cc and attachments for this library

Hey @kiapkiap I just rephrased the issue so we can have two separate issues, one for cc and bcc and the other for attachments

Here is the issue for adding attachments #10

This issue has been resolved with #11


Visual Studio Code expirement

@BinaerBaer : I drop this for me... ok?

@ArneSch Yep, I'll drop it too. I'll close this issue.


fetch: support expected-sha512

This came up while trying to build ICU, which only provides sha512s of its source, e.g., https://github.com/unicode-org/icu/releases/tag/release-71-1
cc @jdolitsky

@jdolitsky tried this out and with the params unset we got a bad bash substitution trying to check for them in the script. This now does a terrible hack where the default value is "NOTSET" as a sentinel value, but we should either fix fetch.yaml (or maybe melange?) to handle unset params so we don't have to do this.

Yes, I think desired behavior here would be that if an input is missing that is not required, it should result in empty string substitution

so the issue was that the hyphen character (-) was not supported by the regex. Opened #121 in place of this PR. Closing


Is thereversion of torch-opencv with opencv2.0？

Is there version of torch-opencv with opencv2.0？

@KangolHsu
Hi! We don't support OpenCV 2. Maybe this may work, but it seems to be very limited.


toSearchableArray method not run for relationships

Software
Version

PHP
7.4.14

Elasticsearch
7.13.2

Laravel
8.40

Laravel Scout
9.1

Describe the bug

when I want to use a relationship that has its own toSearchableArray method, the toSearchableArray method doesn't run for relationships
To Reproduce

Current behavior

Expected behavior

Hey @fadakar, it sounds like a feature request to me. Can you share how your toSearchableArray looks like? I'm not quite sure I understand your use case.


Document missing option + fix typo

While the indent option gets a mention in the project's README, it is easily overlooked because it is missing from the Options table at the end.
This PR properly documents its usage.

Personally, I'd make an indentation of 2 the default, but this at least makes it more obvious there is indeed a way to change the formatting of the resulting file.


Nickname Validation Issue

Issue Title: Nickname Validation Issue
Description: The nickname field requires stricter validation to prevent invalid or insecure inputs. The validation should ensure:
Nicknames are non-empty and within a valid length range.
Restricted use of special characters (e.g., no spaces or unsupported symbols).
Error handling for invalid nicknames.

Fixes and Changes Applied:
Validation Logic:
Updated nickname validation to enforce:
Non-empty strings.
Minimum and maximum character length.
Restriction on special characters like spaces or unsupported symbols.
Error Handling:
Added detailed error messages for invalid nicknames.
Test Cases:
Created tests for valid nicknames (e.g., test_user, user123).
Added tests for invalid nicknames (e.g., test user, !invalid).


Use inline SVGs for External links

What is the context of this PR?
Fixes #835
Adds inline svgs for external links and adds design system forum missing links
How to review

Tests pass
View code
Check all pages and links display correctly
Check that link icon is correct colour when focused on

 Issue #835: Introduce inline SVGs for external links


Encountered internal error running command: Error: No observatory URL matching to '/(Observatory listening on |An Observatory debugger and profiler on\s.+\sis available at: |The Dart VM service is listening on )((http|//)[a-zA-Z0-9:/=_-.[]]+)/' was found in the device log. Please make sure the application under test is configured properly according to https://github.com/appium/appium-flutter-driver#usage and that it does not crash on startup.

can any one help me to solve this please

https://gist.github.com/ChandanMySelenium/90fcf8004eb54cb089571d52a6003067
this is the log. so, please help me if anyone know how to solve this

I'm running into this problem as well. Maybe the wording has changed when you start up flutter in latest so it can't find it:
A Dart VM Service on My iPad is available at: http://<IP_ADDRESS>:65015/Aaj81SrdP9Y=/
The Flutter DevTools debugger and profiler on My iPad is available at:
http://<IP_ADDRESS>:9102?uri=http://<IP_ADDRESS>:65015/Aaj81SrdP9Y=/
Versus what appium is looking for: The Dart VM service is listening on )((http|//)[a-zA-Z0-9:/=_-.[]]+)/' was found in the device log

One thing we could advise is if the device prints the log of the URL in the syslog. appium:showIOSLog capability would help to check it.

I did a few things and one of them seemed to work. It was either:

After restarting my Mac. I found that flutter run --profile was actually failing (where it didn't show that before)
2.My flutter channel was a little behind. There were some unstaged changes so I had to abort them and then run flutter upgrade


cannot connect: ETIMEDOUT - retrying in 15s

I see this when I startup Homebridge with the latest version of Hue plugin and Homebridge 0.4.53:
[2020-4-23 9:29:00] [Hue] 192...230: <IP_ADDRESS>:80: cannot connect: ETIMEDOUT - retrying in 15s
What is the plugin trying to connect to? This is not even an IP in my network, not even close to my IP range. This prevents Homebridge from starting, and of course, Hue stuff doesn't work at all.
Any hints?

Your Internet provider is sharing "your" public IP address with others, and the Hue bridge discovery returns the bridge of one of your Internet neighbours.  Set nupnp to false to disable discovery through the MeetHue portal (and dresden elektronik appspot server), or specify your bridge(s)/gateway(s) under hosts to disable discovery altogether.

Hm not happy with that solution, disabling discovery and using a static host works now but how can I make sure the bridge always uses this static ip? I didn't find any setting in the Meethue account.

Hm not happy with that solution

You’d need to take that up with Signify and/or your ISP.

how can I make sure the bridge always uses this static ip

Whitelist the bridge’s mac address in your dhcp server, linking it to a static, but dynamically assigned IP address.  Or configure a static IP address on the Hue bridge using the Hue app.
If you set nupnp to false, local discovery through UPnP still works.  Homebridge Hue and the Hue bridge need to be in the same subset, or you need some networking magic to reflect the UPnP local link multicasts to the other subnet.

Ah thank you, didn't know that I can assign a static address to the bridge.

Hi ebaauw,
first o all i would like to give you a big thank you as well as a big respect for building this beautiful Hue plugin.
I have the same issue like zeromancer1972 had.
But i dont understand a word about how he solved the problem.
The point is, everytime i shutdown my PRI where Homebridge is running on (PRI Zero W), Homebridge server doesnt start.
At the protocoll this message repeats all the time ater start:
[12/12/2020, 13:46:06] [Hue] request 1: GET /config
[12/12/2020, 13:46:06] [Hue] <IP_ADDRESS>: timeout after 5 seconds
[12/12/2020, 13:46:06] [Hue] 192...39: <IP_ADDRESS>: timeout after 5 seconds - retrying in 15s
My config looks like this so ar:
{
"bridge": {
"name": "Homebridge",
"username": "CC:22:3D:E3:CE:30",
"port": 51826,
"pin": "031-45-154"
},
"description": "Home Smart Home",
"platforms": [
{
"name": "Config",
"port": 8080,
"auth": "form",
"theme": "auto",
"restart": "sudo -n systemctl restart homebridge",
"temp": "/sys/class/thermal/thermal_zone0/temp",
"tempUnits": "c",
"lang": "auto",
"sudo": true,
"log": {
"method": "systemd",
"service": "homebridge"
},
"platform": "config"
},
{
"name": "Hue",
"anyOn": true,
"hosts": [
"<IP_ADDRESS>"
],
"lights": true,
"nativeHomeKitLights": false,
"nativeHomeKitSensors": true,
"nupnp": true,
"resource": true,
"users": {
"ECBi covered": "UBAZ5hJVi covered*9rzDPlSFyOEArr"
},
"platform": "Hue"
}
],
"accessories": []
}
What im doing wrong?
My Hue Bridge does have another IP in my network. But it changes automaticly to another IP. But thats what it should do, right?
Sorry, im rlly just a beginner in this PRI and Homebridge topic.
Mayn thanks in advanced.

My Hue Bridge does have another IP in my network. But it changes automaticly to another IP. But thats what it should do, right?

If you use hosts, your Hue bridge needs to have a fixed IP address.  Either configure a static address on the bridge (using the Hue app), or configure your DHCP server (typically your router) to assign a fixed address to the Hue bridge, based on its mac address.
Alternatively, don't use hosts and let Homebridge Hue discover your bridge automatically.

thank you for your quick supply!
It worked now. I just deleted the host.
Looking like this now:
{
"name": "Hue",
"anyOn": true,
"lights": true,
"nativeHomeKitLights": false,
"nativeHomeKitSensors": true,
"nupnp": true,
"resource": true,
"users": {
"ECBXXXXXXXX2F4": "UBAZXXXXXXXXXXXXXXXXXyOEArr"
},
"platform": "Hue"
}
Thanks again. Rlly happy with your plugin. 👍


Convert None to Env.null

Nice and simple.

It seems this PR made CI unhappy after being merged due to formatting. So probably any new ones will be red too.

I made a bunch of PRs at once, I may have forgotten to format one of them when splitting them up. There's a good chance one of the others will fix it.

I went through Mindustry's source code and couldn't find a place where @null is defined. While it has the same behavior during runtime since uninitualized variables are set to null, it may be misleading to use a variable that is not defined instead of directly using null.

Oh, really? I've been using @null for my programs, but I guess that makes sense. Is null a "proper" null value, as opposed to @null? Would there even be such a variable, if uninitialized variables act the same way?

Judging by https://github.com/Anuken/Mindustry/blob/0b19379b8c982f752ae3e4a4f8d2ee6141716e28/core/src/mindustry/logic/GlobalVars.java#L55, yeah, maybe it's just null.


Interaction results are not separated by genes

Interaction results are mixed when in v4.0 they’re split by search result (either by gene or by drug)
v4

v5

I think this is intentional -- the idea being that you can use filters to pick what you want -- but worth revisiting

consider global/server-side sort for these

changed tag to backend- if this is a feature we want, this logic should exist there


homepage revamp

Description of change
It's about time that we gave the homepage a bit of love, it's looking very tired
Checklist

[x] npm test passes
[ ] documentation is changed or added (if applicable)
[ ] permission has been obtained to add new logo (if applicable)
[x] contribution guidelines followed here

Looking fresh! The menus are funky too.
Some nit-pick comments (because you would expect them ;-)

Can we lose the space between "Binaries " and "for Free!"?

Not a big fan of the additional "Eclipse Adoptium(R)" at top of the page. Seems unnecessary.

Please confirm that the new people+arrows image is licensed for our usage? It seems a bit "stock" but ok. Maybe we find a conference photo we have that would fit the brief, or the images that news@ use on some of their materials that show real humans?

My detail-oriented brain wants the rectangles for WG/members/market/etc to be the same height - but I realise that really is picky :-)

I wonder if we should drop the [Release Archive] button - will have to check if anyone uses it?

@tellison fixed 1 and 2,

Please confirm that the new people+arrows image is licensed for our usage? It seems a bit "stock" but ok. Maybe we find a conference photo we have that would fit the brief, or the images that news@ use on some of their materials that show real humans?

Yeah the image is licensed for our usage but I'm not sure it's the best image, open to suggestions.

My detail-oriented brain wants the rectangles for WG/members/market/etc to be the same height - but I realise that really is picky :-)

I'll see if I can fix that

@gdams the changes look good.

I've had a quick look on the mobile too, and note that the info-boxes overlap the image - so we should bear that in mind if it is replaced to ensure it is not a 'vital' image.

Obviously my comments are on the design at the moment, I've had a quick scan of the code but not yet done a detailed review.


Allow disabling ScalaPB-Options-Proto

The automatic addition of files to the compile scope has consequences on non-scalapb plugins that might be configured in targets. This may break compilation due to files that were never requested to be included which makes this rather confusing fro the end-user (the only way to discover this is to extract the arguments passed to the protoc compiler).
It would be important to allow disabling this behaviour through an sbt option. e.g.:
.settings(
  PB.includeScalaPbOptionsProtoFiles := false
)

Or perhaps expose the files themselves as a key and let the user override it:
.settings(
  PB.scalaPbOptionsProtoFiles := Nil // override the list of unpacked files with an empty list
)

Alternatively, instead of including the files directly in the compile scope, sbt-protoc could offer the ability to generate a custom file that only have import statements to those options files. e.g.:
import "scalapb/validate-options.proto"
import "validate/scalapb-options.proto"

This could even be entirely templated so that sbt-protoc has no opinions at all about how to include those files in the compile pipeline of a project. e.g.:
PB.scalaPbOptionsProtoTemplate := """package my.custom.package;
{{scalapbOptionsProtoImports}}
"""

Ideally, the generated path + filename would also be configurable.
For context: we use a linting plugin on our proto files and it started complaining about the package names (it has rules for the package names) in some files in our compile scope (e.g.: scalapb and validate). This wasn't the case before since those packages were in the import path and the linting plugin doesn't cover those (obviously).

Thanks for reporting. Can this issue be addressed by configuring the linter, like excluding these files? Which linter are you using? What's the actual lint error? Generally, third-party files should be excluded from linting since they are not bound to the rest of the project's standards.

yes, we can disable the rules on a per directory or file basis
we use the lint plugin from https://buf.build/
the error is that the package names do not follow the versioning rule defined here
yes, third-party files can be excluded, but it's annoying to have to exclude files that we didn't ask for in the first place

The problem that this causes for us is that we now have to manually go and update our linting rules in tens of projects for files that we didn't include in our build in the first place; which is pretty confusing.
FWIW: the fact that this declaration:
libraryDependencies ++= Seq(
  "my.group" %% "some-proto-dependency-to-import" % "1.0" % "protobuf",
  "my.group" %% "some-proto-dependency-to-import" % "1.0",
)

affects the protobuf-src scope is a problem IMO.

How aboutPB.disableManifestProcessing := true to opt-out? The main change will go in here: https://github.com/thesamet/sbt-protoc/blob/master/src/main/scala/sbtprotoc/ProtocPlugin.scala#L553-L555

@thesamet here's the PR


Update versioning policy

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
768

Relevant Lines:
768

💛  - Coveralls


Processing numbers inside report.html when using cron

Hi
In my HTML report, I got a lot of log processing numbers
https://i.imgur.com/BgNeLxy.jpg
This also broke some css styles
cron cmd: /usr/local/bin/goaccess -p /usr/local/etc/goaccess/goaccess.conf -a -f /home/users/USERNAME/logs/access.log > /home/users/USERNAME/www/mysite.com/access.html
when I use this command through the terminal, everything works great.
p.s I use -p because of bug in dev version
https://github.com/allinurl/goaccess/issues/1532

Please use the single dash - as indicated in the docs.
/usr/local/bin/goaccess -p /usr/local/etc/goaccess/goaccess.conf -a - /home/users/USERNAME/logs/access.log -o  /home/users/USERNAME/www/mysite.com/access.html

Thanks, it helped!
closed


md-tab doesnt init first tab when placed in md-dialog

You have to click (the first tab) manually to see first tab content.
Any resize issue?
http://codepen.io/anon/pen/qRggRB

Yes. Exactly this! I will fix. Also related to #258

Closing this issue as our focus is on the new 1.0.0 version.


drivers: sensors: sm351lt: Add new driver

Signed-off-by: Jamie McCrae<EMAIL_ADDRESS>

@MaureenHelm The build failure was caused by an STM32HAL error (nothing to do with my changes) and the second part is being caused by something else, namely https://github.com/zephyrproject-rtos/zephyr/pull/27598 for some reason this was approved and merged in but has been merged in with the wrong commit and so an old broken commit has been merged in somehow.


Support Gentoo Linux

As requested, breaking up my push into one per platform.  This is 1 of 4.
GentooLinux:
Added support for OpenRC and startup files to the build. Added --enable-openrc to install them.
As per comments, replace path in open rc files with actual path from make.

Hi @mstone2001,
This PR has suffered slightly in that merging it will cause some regressions in these files:-

sesman/chansrc/smartcard.c
sesman/chansrc/smartcard_pcsc.c
xrdp/xrdp_font.c

Can you rebase to the latest wavefront in devel?
You may not know what I'm talking about - I didn't understand any of this when I made my first PR to this project. The concept is explained pretty well here, but it's a bit of a learning curve if you're used (as I was) to something like Subversion. Please feel free to come back to me with any questions.


Revert change to example h2 config

@garyb Sorry I didn't catch this earlier. We still support file for backwards compatibility but will use location moving forward since we now support any h2 url (apparently you can connect to remote h2 installations)

I was under the impression that location doesn't currently work, while file does. Should location currently work?

@alissapajer I've just re-tested with the latest Quasar and location is acceptable in the config now. I guess I must have caught it in between when the PR was merged for the change and when a release was made with it working!
Sorry @jedesah :smile:

I also was able to use mem: for my H2 database location, which is what I wanted to do in the first place when I "discovered" this :)

@garyb No worries! 😄


Cannot install

Error message:
Fetching gem metadata from https://rubygems.org/.........
Fetching version metadata from https://rubygems.org/...
Fetching dependency metadata from https://rubygems.org/..
Could not find gem 'march_hare (~> 2.22)' in any of the gem sources listed in
your Gemfile.

using jruby-<IP_ADDRESS>

Have also tried pointing at the git repo directly, no luck.

I cannot reproduce this. RubyGems clearly indicates that the 2.22.0 is published as a JRuby-specific gem.

The following Gemfile works for me:
source "https://rubygems.org"

gem "march_hare", "~> 2.22.0"

Fetching gem metadata from https://rubygems.org/.
Fetching version metadata from https://rubygems.org/
Resolving dependencies...
Using march_hare 2.22.0
Using bundler 1.13.6
Bundle complete! 1 Gemfile dependency, 2 gems now installed.
Use `bundle show [gemname]` to see where a bundled gem is installed.


feat(controls): throttle info controls to reduce overhead

Increase performance by reducing the number of updates done by the scale line and zoom info controls. These controls manipulate the dom and do a decent amount of math so we should call them less often.

Although the throttle on these could be lowered, the throttle overhead is probably not worth the amount of savings we'd get.


Implement basic mechanics

Implement basic game logic for handling hunger / strength. Hunger / strength increase when food / pills are eaten, and decrease automatically at set intervals which vary per Digimon. Hunger and Strength stats are reflected on hearts screen.
Implement logic for overdose on proteins, set overdose limit (This stat affects injury ratio from battles).
Care mistakes occur when Digimon is neglected after hunger or strength values drop to zero. A timer begins to track time passed and apply care mistake if no action is taken, feeding will disable the check until hunger/strength runs out again.
Added variable to Digimon properties for the time that the Digimon goes to sleep.
Added variable to Digimon properties for the required number of doses to heal the Digimon after it has been injured.
Adjusted the value of strength added upon eating protein from 2 to 1.
Add logic for overfeed,
Properly handle weight.
Handle DP count when eating protein.
Handle max number of poops, apply injury when poop count accumulates to 4.

Add basic sleep logic (WIP, partial implementation).
Add new Digimon: Betamon WIP (Adding the sprites caused a build error, so everything related to betamon is commented out until I figure out a solution.

@BeRational @Berational91
I'm not sure if you will see this, but I have forked your project and have been implementing the basic mechanics. If you would like to collaborate together I am more than willing to do so and we can merge my work into your repository with this PR, otherwise I will continue working on this via my fork.

Hello @VirtualDino,
Thank you for your Contribution! I'm glad someone finds the interest and time to develop this project further. At the Moment, i am to busy to work on this project - but this will change in a couple of month.
I will go through your commits and check for violations of the established modeling. I already skimmed through some parts of your code and what i've seen looked good so far. So after checking the rest, i will approve the pull request.
Hopefully we can work together on this project in future!
Best regards Berat.


Subtitle's color in ListTile doesn't match M3 specs.

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
See sample code
Expected results
Subtitle's color should be set to onSurfaceVariant, when using Material 3. In sample, the subtitle should be green.
Actual results
Subtitle's color is set to onSurface. In sample, the subtitle is blue.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const ListTileSub());
}

class ListTileSub extends StatelessWidget {
  const ListTileSub({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        useMaterial3: true,
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.red)
            .copyWith(onSurface: Colors.blue, onSurfaceVariant: Colors.green),
      ),
      home: const Scaffold(
        body: Center(child: ListTile(title: Text("title"), subtitle: Text("subtitle"))),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
Actual results:

Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.10.4, on Microsoft Windows [Version 10.0.19045.2965], locale pl-PL)
    • Flutter version 3.10.4 on channel stable at C:\Users\kkras\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 682aa387cf (3 days ago), 2023-06-05 18:04:56 -0500
    • Engine revision 2a3401c9bb
    • Dart version 3.0.3
    • DevTools version 2.23.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\Users\kkras\AppData\Local\Android\Sdk
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = C:\Users\kkras\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)
    • All Android licenses accepted.

[X] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2022.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-9586694)

[√] VS Code (version 1.79.0)
    • VS Code at C:\Users\kkras\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.66.0

[√] Connected device (3 available)
    • sdk gphone x86 64 (mobile) • emulator-5554 • android-x64    • Android 13 (API 33) (emulator)
    • Windows (desktop)          • windows       • windows-x64    • Microsoft Windows [Version 10.0.19045.2965]
    • Edge (web)                 • edge          • web-javascript • Microsoft Edge 107.0.1418.52

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

Thanks for your report. Reproduced this issue on master channel as well.
M3 specs: https://m3.material.io/components/lists/specs#7134fed0-fd57-46a6-b126-f1c47b12531b

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.10.4, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.10.4 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 682aa387cf (2 days ago), 2023-06-05 18:04:56 -0500
    • Engine revision 2a3401c9bb
    • Dart version 3.0.3
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.78.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.66.0

[✓] Connected device (3 available)
    • Pixel 3a (mobile) • 964AY0WL20 • android-arm64  • Android 12 (API 32)
    • macOS (desktop)   • macos      • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 114.0.5735.106

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.12.0-2.0.pre.43, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
    • Flutter version 3.12.0-2.0.pre.43 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e25eabd263 (81 minutes ago), 2023-06-08 18:57:25 -0700
    • Engine revision a5f7d5d75f
    • Dart version 3.1.0 (build 3.1.0-171.0.dev)
    • DevTools version 2.24.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.78.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.66.0

[✓] Connected device (3 available)
    • Pixel 3a (mobile) • 964AY0WL20 • android-arm64  • Android 12 (API 32)
    • macOS (desktop)   • macos      • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 114.0.5735.106

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.


Generate IR per-module for loaded modules

The basic idea here is that for each module that gets loaded via import, we should also generate the initial IR for the declarations in that module at the time it gets loaded.
Furthermore, when we generate initial IR for a module, we will only generate IR declarations (not definitions) for any functions/variables in modules it imports.
Later, when cloning IR to begin code generation for an entry point, we will effectively "link" all of the loadedm modules together, so that a given global value can get its definition from any of the IR modules present.

Change the loadedModulesList and related data structures to hold a new LoadedModule type, instead of just the AST (and then have a LoadedModule own both the AST and the IR module)

Share some logic between the import and #import cases, so that we always try to generate IR for modules we load.

Make sure that IR generation always gets skipped if the command-line flags tell us not to use the IR.

A few small fixups for cases that didn't arise in IR lowering so far, but come up when we try to actually generate IR for things like the stdlib.

There are some notable gaps in this work right now:

The stdlib modules are exempted from this behavior; we always generate IR for stdlib functions in any user module that calls them. This is just a workaround for the fact that the stdlib modules don't show up in the list of imported modules right now.

We don't currently have logic that does the "linking" step for global variables like we do for functions. We really need to look up the symbols with the same mangled name, and favor any one of them that has a definition (if there is one)

Similarly, the handling of witness tables is incomplete. During initial IR generation, we should probably be generating empty witness tables for any conformances that were declared in other modules (but are being used locally in this module), and then the "linking" step should favor non-empty witness tables over empty ones.

Still, all the test cases pass with the code like this, and this seems like an important step in the right direction.

This PR is a stepping stone toward allowing a translation unit that uses -no-checking to still use the IR to cross-compile library code that it imports.
In the long (long) term, the hope would be that most modules get loaded from serialized data on disk (including bytecode for functions) and the LoadedModule mostly just owns a buffer that holds the bytecode (rather than a bunch of fine-grained objects representing the IR). Then, when we go to codegen an entry point, the “cloning” of the initial IR can be replaced by a step that pretty much just deserializes IR instead.


Running cucumber with Inprocess from aruba

Hi, I merged cucumber/aruba#258 and released a pre-release 0.8.0.pre2. Unfortunately cucumber does not work well with this release.
The problem is this:

Cucumber uses Inprocess to make tests faster

Cucumber reads in Feature-files somewhere in the code

It seems like it uses the current working directory for this

It outputs the file names of the steps as well
  Feature: test

  Scenario:               # features/test.feature:2
  -    Given this step fails # features/step_definitions/steps.rb:4
  +    Given this step fails # tmp/aruba/features/step_definitions/steps.rb:4

The tmp/aruba directory is part of the output although Dir.chdir is used

Using the "old" gem version the problem, the problem does not occure

Re-Using parts of the old code does not solve the problem

What does aruba do?
      def run!
        fail "You need to call Aruba.process.main_class = YourMainClass" unless self.class.main_class

        Dir.chdir @working_directory do
          before_run

		  # even change `PWD` now
          in_environment 'PWD' => @working_directory do
            self.class.main_class.new(@argv, @stdin, @stdout, @stderr, @kernel).execute!
          end

          after_run

          yield self if block_given?
        end
      end

I placed Dir.chdir-calls at different places, tried some code walking, but still I didn't have an idea why cucumber finds the feature-files, but also outputs the tmp/aruba-directory? Normally it complains about a missing feature-directory.
Any idea where to look for the code which uses Dir.getwd?
BTW:
Using SpawnProcess works like a charm.
Thanks a lot.
Cheers, Dennis

Possibly related: #885

Ok. I tracked it down. Puh.... The problem is the following piece of code. cucumber uses the PWD constant to calculate the path to the step file. But PWD is set when the proc.rb-file is loaded. At this time the working directory has not changed yet, thus PWD points to "project-root". Changing it afterwards is ignored. Is there a good reason why cucumber works this way? Looks a little bit weird to get Dir.getwd when the file is loaded by the interpreter.
lib/cucumber/core_ext/proc.rb:
# [..]
  PWD = Dir.pwd
# [..]

    def file_colon_line
      path, line = *to_s.match(PROC_PATTERN)[1..2]
      path = File.expand_path(path)

######
      pwd = File.expand_path(PWD)
######
      pwd.force_encoding(path.encoding)
      if path.index(pwd)
        path = path[pwd.length+1..-1]
      elsif path =~ /.*\/gems\/(.*\.rb)$/
        path = $1
      end
      "#{path}:#{line}"
    end

Grepping the source, I see no reason to use a constant for this:
lib/cucumber/core_ext/proc.rb:5:  PWD = Dir.pwd
lib/cucumber/core_ext/proc.rb:20:      pwd = File.expand_path(PWD)
lib/cucumber/formatter/backtrace_filter.rb:13:      PWD_PATTERN = /#{::Regexp.escape(::Dir.pwd)}\//m
lib/cucumber/formatter/backtrace_filter.rb:21:        @exception.backtrace.each{|line| line.gsub!(PWD_PATTERN, "./")}

Then this should be fixed by #888, se also the discussion in https://github.com/cucumber/cucumber-ruby/commit/af0f18440510776e0f382ba94ad1eaab3196fdc4#commitcomment-12092131

Mmmh... Sounds good. But I tried the branch, but the error is the same. The path needs to be calculated on runtime, not on load time. Otherwise the change of CWD gets unnoticed.

Ok. Seems to be a different thing. Maybe the hooks need some love too?

This should be fixed if both PRs #888 and #890 are merged.

@mattwynne
Would be possible to backport those changes to 1.3.x at least that the working directory is determined at runtime?

Why do you want the back-port @dg-ratiodata?

This is only required if you would like to use aruba >= 0.7. in your 1.3.x "branch". Dir.getwd needs to be checked on runtime only not on load time.
BTW: I added some documentation tests to make this clear for future releases and users.

I don't intend to do any more releases of the 1.3 series, so this shouldn't be an issue.

Alright.

Any chance to get those fixes merged soon?

Closing in favour of #888 and #890


Delegate in iPhone don't work

I faced a case in which emmy#delegate method triggered a function in every single browser but Safari on iPhone.
Not sure whether we can easily recreate it; I think we need to test it deeply.

We can try to emulate it. But i have to take a look

The problem was caused by iPhone Safari handling 'click' event on interactive elements only ('touchstart' can be used for noninteractive ones).
I think that we shouldn't fix that in the emmy, it's a different level problem.


Ruler tool helpful additions

Ability to toggle ruler numbers direction to reverse. Ex. 0 at top of phone and biggest number at bottom reversing places. This would it easier to read the measurement of objects where the bottom of the phone is touching the object and not having to mentally reverse the numbers. See attached image.
Ability for ruler to switch sides of the phone using button toggle to switch. This would allow for ruler to be closer to object being measured if it is on right hand side of phone instead of left. See attached image.

Measurement line inside ruler to get precise measurement to have solid color from 0 to highest measurement on line to allow for user to much clearly see where line is. This should switch directions when ruler numbers switch directions. See attached image from different ruler app of what I am referring to.

Thank you for any potential consideration!

Thank you for the suggestions, I've split this into multiple issues so these features can be tracked separately:

https://github.com/kylecorry31/Trail-Sense/issues/2438
https://github.com/kylecorry31/Trail-Sense/issues/2439
https://github.com/kylecorry31/Trail-Sense/issues/2440


🎉 Initial commit tslint-config and typescript-lit-element

Please help review the new generator. Feel free to make changes if needed.
P/S: Please expect to see an error regarding invalid @open-wc/tslint-config as this is newly created config for TSLint which yet to exist in the NPM registry.

I see what's going on now. Thank you for pointing that out.


fricatrice, digitalic

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 5
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[d,f]

/trunk merge


only fetch html content without any resources

i want only fetch html content without any resources, like js, css, images, pdf, ....
how to do?

First, set crawler.supportedMimeTypes=["text/html"], then set crawler.downloadUnsupported=false. You can also write a fetch conditions that prevents URL's that end in eg. ".jpg", ".css", ".js", ".pdf" or ".png" in order to not even try and fetch those URL's (for resources that are discarded based on mimetypes, the crawler still has to fetch headers to determine what mimetype it's about to receive)

thanks,
btw, supportedMimeTypes option accepts regex object, also need to accept string too, it will be more flexible.

You match anything with a regex you can match with a string. :)


The use of the word 'master' can be exclusionary

In the case of the standard writing of 'master/slave', it should be rewritten to 'primary/replica'.

Thank you for creating the pull request. The information you have provided will be reviewed. If there are any questions about this issue we will get back to you here.

This PR should be closed as more recent changes have been made that address this issue.

This PR should be closed as more recent changes have been made that address this issue.


[BUG]

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.

What problem did you encounter?
idk i just try to do a font...fsddfsfsdffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff

What's the error message say?


Export getOutputValue from langchain/memory

Hi. Thank you for addressing #2975. Can you also export getOutputValue for the same reason?

I'd like to have this assigned to me if it's still available.


docs: Update OneSignal integration docs

I've just done a OneSignal + Notifee integration in our app and the dependency exclusion is no longer needed with the 4.0.0+ versions.

@liamjones thank you 🙏 One question before we merge this, do you still need to avoid step 1:
Do *not* use the onesignal gradle plugin (currently step 3.2 in their documentation)
Or can we say both steps are no longer needed with  4.0.0+?

Yes, currently you still seem to need to do step 1. If I don't, when the OneSignal plugin is included I get:
No variants found for ':notifee_react-native'. Check build files to ensure at least one variant exists.

I'm assuming this is a bug in their plugin so was going to report it to their Gradle plugin project.

@liamjones thank you, merged :sunglasses


Notebook formatting is unusable.

The code portion is shoved to the side.

This repo is not actively maintained at the moment, see this comment.


Notebooks: Add unit test for multi_connection_mode metadata

This PR adds tests for reading and saving multi_connection_mode field to notebook metadata.

Pull Request Test Coverage Report for Build 548580816

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.006%) to 43.528%

Totals

Change from base Build 546835463:
0.006%

Covered Lines:
24938

Relevant Lines:
52483

💛  - Coveralls


ENH: CircleCI use ccache and cache external data

Take advantage of CircleCI caching, to cache the external data, and to
use ccache to cache compiled code, between builds.
Change-Id: I5c173dbcd825c5cf46138caacd686619488b8e68

Using ccache seems very effective here. It changed the build time from 50min to 15 or 8 min.


UI Component Choice

First, I would thank you for this template, which will be the default for my upcoming projects, but I know that I will take so much effort to replace MudBlazor with Tailwind css,
I think by using native components will make it easier to choose what css framweork you want to use, Tailwind, bootstrap, bulma,....

You can covert the entire UI look and share

Hi @osama9 , I would say this was more of my personal choice and how well MudBlazor and Material UI fits into the Dashboard Realm of things. However, I do understand your concern. Architecture-wise, there is almost 0 Dependency with Mudblazor Components. You are always free to switch to a new UI keeping the Core Project the same.
Regards, and thanks for the feedback.


feat(locales): add danish translation

Summary
This adds Danish translation to the netlify-cms-locales package to allow localization
Test plan
I tested by adding locale to config.yml and running locally
locale: da

This is my first contribution here so please don't hesitate to point out necessary changes.
Thank you

Thank you very much (I didn't recognize the need for formatting)


Building cuda images locally fail

Hi,
I have been trying to build the cuda-torch v8.0 image locally. I have concatenated all your Dockerfiles like below, but I am encountering errors.
The obvious ones are easy to fix, install-deps: line 151: sudo: command not found, but I get to the point where I am unable to fix Failed copying contents of 'lua' directory.
Any idea ?

No worries, debugging it at the moment, might add a PR as soon as I find the issue.
Thanks


Generate Class from JSON with array as root

Hi Petar,
What a great tool!!!
Could you verify the following behavior. The tool does not seem to be able to cope with a JSON string with an array as root (jsonlint reports the string to be valid JSON):
    [
    {
      "Id":"9165d168-c6de-4eea-b280-1fc147576199",
      "Description":"Your Advice",
      "Code":"NL_YR_ADV"
    },
    {
      "Id":"d03a1dbf-5b3f-4dd4-ba07-0ffd3b67ca6f",
      "Description":"Your Garden Products",
      "Code":"NL_YR_GRD"
    }
  ]

The tool still generates a correct ItemClass, but the TRootClass.FromJsonString assumes the JSON "root" to be an object, which in the end (when using calling TRootClass.FromJsonString) generates an error "input value is not a valid Object" and/or Access Violation, because in this case the "root" is an array.
Please, could you ...

explain whether this is by design
change the tool so it will generate a correct TRootClass.FromJsonString
tell me what would be the most decent work around, if it cannot be changed in the tool.

Regards,
Erik

Hi Erik,
Do you mean you want your sample JSON to be represented as TArray where itemType represents array's element type?
Regards

Hi Petar,
I cannot remember why I asked this question (to be honest, I hardly remember asking the question at all), but after re-reading the question I think your interpretation is correct.
Regards,
Erik

@compubinkie generating a class instead of just TArray is more flexible, because you can later extend the class and take advantage of ToJsonString/FromJsonString functions etc. As far as I know it is more popular for the web services to return objects with collections inside - something like { results: [{obj1},{obj2}] } (for example ExtJs) instead of directly returning plain arrays.
Also currently Rest.TJson (which is used for the actual conversion) does not offer a way to convert a JSON string that represents arrays to be directly converted to TArray. I'll think about it in the future.
In your case you can use Delphi2JsonClass to generate a class for Array's elements:
    {
      "Id":"d03a1dbf-5b3f-4dd4-ba07-0ffd3b67ca6f",
      "Description":"Your Garden Products",
      "Code":"NL_YR_GRD"
    }

Then use low level Json functions to represent it as array. Pseudo code:
procedure test;
var
LJsonArr   : TJSONArray;
begin
  LJsonArr    := TJSONObject.ParseJSONValue(TEncoding.ASCII.GetBytes(StrJson),0) as TJSONArray;
  for LJsonValue in LJsonArr do
  begin
    // Process array items here
  end
end;

Hi Petar,
I totally agree a class is more flexible.
The thing is, that our software interfaces to a web service (If I remember correctly, it is the web service that is part of Dutch accounting software called AccountView, https://nl.visma.com/producten/accountview/) that returns these types of array JSON strings.
I know we already have a solution for handling these array JSON strings, possibly similar to your suggestion.
Thanks anyway for your help.


How to connect helm tiller remote?

Can not connect tiller from local machine?
I have created a k8s cluster in rancher and config the '.kube/config' in my local machine.
In the master node, I install the helm, and exec 'helm init'. By now , everything is ok.
But in my local machine, when I exec the 'helm list', It game me this error info 'Error: forwarding ports: error upgrading connection: Upgrade request required'.
Is there anyone know what happend?

Useful
Info

Versions
Rancher v2.2.2 UI: v2.2.41

Route
authenticated.cluster.monitoring.node-detail

I have solved this problem by myself.  Delete the cluster created by rancher, replaced by importing. Everything is ok.


EndOfSentenceFormat does not work well with urls.

Sometimes I've got comments just like
/** http://www.graphviz.org/doc/info/shapes.html */ sometimes they're also prefixed.
/** You can get more information in the documentation. http://www.graphviz.org/doc/info/shapes.html */
One idea would be to split the comment using spaces and looking up whether the last part can be parsed to a url. If that's the case we don't need to flag it.

Thanks. I'll close this now. When can we expect a new release?


Azure AD Resource identifier is not provided

When trying to use this with Azure AD I'm reaching a dead end when trying to get a response for: response_type: "id_token token"
In typical Microsoft-style things work a bit differently! In order to generate an access token I need to pass a 'resource' value. As far as I can tell there isn't any way to add additional parameters or tweak the request before sending so I'm stuck with the AADSTS50001: Resource identifier is not provided error
Am I missing something or is this a known issue?

Actually, I see extraQueryParams on OidcClientSettings.js. Looks like that'll do the trick. Do we want to update the documentation with this additional property for UserManagerSettings?

You're right -- resource is not part of the spec and Microsoft made it up. And yes, someoen asked me to support that, so I think I added a custom resource param just for that. BUt if I didn't then the extra params is the way to go. And sure, feel free to add it to the wiki. Thanks

Looks like I don't have permissions to push to the wiki, here's the text if you want to copy/paste when you get a chance:

extraQueryParams: (object): An object containing additional query string parameters to be including in the authorization request. E.g, when using Azure AD to obtain an access token an additional resource parameter is required. extraQueryParams:{resource:"uri:\\someresource"}

Done, thanks!

You're right -- resource is not part of the spec and Microsoft made it up

No. It's in the specs: RFC8707
If my web application needs a token for each API, how can I use the library? (i.e. how to request a new token for the resource, and it is capable to store multiple access tokens?)
Example:

Super front-end: (IDT: ey....sadsad, AT: 000000front)

User API (resource: userapi.example.com) AT:<PHONE_NUMBER>1aaaaaaa
Billing API (resource: billingapi.example.com) AT:<PHONE_NUMBER>2bbbbb
Services API (resource: servicesapi.example.com) AT: 333333333cccccc

To be fair, the date of that spec if after the date of this thread, oh and when this library was created.

Yes, but this is currently not supported yet?
It's possible with the current version or a PR is needed?

As of now you'd have to use multiple instance of the UserManager. I've not tried to tinker with the internals to support more than one resource. In general the BFF pattern has been preferred over doing token work in the client, so you can consider that instead. Also, there is good support in ASP.NET for the resource param.

Thanks @brockallen ! I thinking about BFF, but I don't want to use it for now.
I'll do some tests, and update this thread if I can or make a PR.

Feel free to research it, but don't bother with a PR if it's any significant work. I don't have the time to review something too complex to be added.


Create 2024-09-20-beyond-LLMs-rise-of-agentic-frameworks.md

This commit introduces a new blog post titled "Beyond LLMs: The Rise of Agentic Paradigms in AI" that explores the evolving landscape of artificial intelligence (AI) beyond large language models (LLMs). The post is divided into several key sections:

Limitations of LLM Instances
What Agents Are and How They Improve Upon LLMs
Overview of Different Agentic Frameworks
Applications of Agentic Frameworks
Conclusion

Hey Kousick, I have made the changes.


implement optimized paging for NestedLoop

if offset = 0 and no projections are added to NestedLoopNode,
we can page through the outer relation and only keep its current page.

ack


createWalletFull, importOutputs and exportKeyImages cannot function correctly when a deposit is made to a subaddress with large index

Hi there,
I use the view-only wallet plus offline wallet mechanism to sign keyImages.

I use try catchs to locate the error to be throw by the last line above: TypeError: (intermediate value) is not iterable. I check the monero-javascript repo and doubt if it is thrown by the line in the red box below:

..., because a null value is not iterable.
From my understanding that._module.export_key_images(that._cppAddress, all, callback); calls the wasm function which was translated from c++. Is there a way to debug the wasm code? Below is an excerpt from monero_wasm_bridge.cpp:

I suppose something went wrong at this line doc.AddMember("keyImages", monero_utils::to_rapidjson_val(doc.GetAllocator(), key_images), doc.GetAllocator()); Somehow the doc object cannot locate memory or something, so the later half returns null. Do you know what causes the original error when exportKeyImages, or what could cause doc.AddMember to return a bug?

Updates：

I print the number of outputs returned and decoded outputs, the result is:
numOfOutputs: undefined; outputs: {"amount":"0","index":0,"accountIndex":0,"subaddressIndex":0,"isSpent":false,"isFrozen":false}
It seems the outputs have not been imported successfully. Or the outputs hex itself is incorrect. Can I decode the outputs hex with just private view key and the main address?

I still wasn't able to recreate the error. As far as I can tell, the library code should always initialize this field from export_key_images().
This suggests an unexpected error is occurring in wallet2's export_key_images() which isn't being caught. I've added the export/import functions to the exception whitelist (wasm_exception_whitelist.txt) so the library catches any errors from those functions in the new v0.7.2 release.
If you're running against v<IP_ADDRESS>, there's at least one known issue with the output export/import but it may be unrelated.

@woodser I think I found the discrepancy. I deposited two amounts to the wallet: one at the primary address, one at the subaddress with index 181162. If I set up the view-only wallet to scan just 1000 subaddresses, thus skipping the one at index 181162, the outputhex can be imported and key images be exported without error. But if I set up the view-only wallet to scan 1 million subaddresses, thus including the one at index 181162, the outputhex will be much longer, and it cannot be properly imported and key images cannot be exported.
So my question is, when createWalletFull, can I specify the subaddress to be included?

@woodser sorry. I thought it defaults to 1000 subaddress. I just check the doc: https://monerodocs.org/interacting/monero-wallet-cli-reference/#performance. By default it checks 50:200 which are 10,000 subaddresses.
So first I set up the view wallet without specifying --subaddress-lookahead. Second I set up the view wallet specifying --subaddress-lookahead 1:1000000. In the second way, the view wallet correctly scans the deposit at the subaddress with index 1:181,162, thus exports an output hex much longer than the the first way would. But this code snippet:

...will throw the error:
TypeError: (intermediate value) is not iterable
To reproduce the bug: generate a subaddress at index 1:181162, make a deposit to the primary address and this subaddress, set up the view wallet with --subaddress-lookahead 1:1000000, view-wallet scans the chain, export the output hex from the view wallet, and then export the key images with the code above.

The full wallet doesn't currently support creating new wallets with subaddress lookahead which also caused errors in my tests with big subaddress indices.
I'll add support for the next release. In the meantime, you could either create the offline wallet using monero-wallet-cli and --subaddress-lookahead then open with monero-javascript, or if you build the wasm files yourself, insert wallet->m_w2->set_subaddress_lookahead(1, 1000000); before wallet->m_w2->generate() lines in monero_wallet_full.cpp to create wallets with a specific subaddress lookahead.
I confirmed this works with deposits at index 1:181162.

Subaddress lookahead is now supported in the v0.7.4 release when creating full wallets. For example:
const wallet = await monerojs.createWalletFull({
        networkType: MoneroNetworkType.MAINNET,
        password: "...",
        primaryAddress: "...",
        privateSpendKey: "...",
        privateViewKey: "...",
        accountLookahead: 1,
        subaddressLookahead: 1000000
});

It worked. But once I set subaddressLookahead to be above 10,000. It becomes very slow. And it is linearly increasing in time. Is there a way to optimize the time cost?

Not to my knowledge. The wasm is generally underpowered because it's running single threaded. There's an effort to support multithreading which could help a lot. Otherwise it's dependent on the wallet implementation from monero-project.

Cool. I'm going to close this issue and follow that thread.


Update to zig 0.11.0

I am trying to build this project using zig 0.11.0. After fixing some syntax in build.zig to get the compiler happy:
const std = @import("std");

pub fn build(b: *std.Build) !void {
    const uno = std.zig.CrossTarget{
        .cpu_arch = .avr,
        .cpu_model = .{ .explicit = &std.Target.avr.cpu.atmega328p },
        .os_tag = .freestanding,
        .abi = .none,
    };

    const target = uno;

    const exe = b.addExecutable(.{
        .name = "avr-arduino-zig",
        .root_source_file = .{ .path = "src/main.zig" },
        .target = target,
        .optimize = .ReleaseSafe, // workaround LLVM limitation
    });
    exe.setLinkerScriptPath(std.build.FileSource{ .path = "src/linker.ld" });

    b.installArtifact(exe);

    // I simply commented the rest out
}

it now fails with the following error:
zig build-exe avr-arduino-zig ReleaseSafe avr-freestanding-none: error: LLVM ERROR: Expected a constant shift amount!

zig build-exe avr-arduino-zig ReleaseSafe avr-freestanding-none: error: the following command terminated unexpectedly:
...
Build Summary: 0/3 steps succeeded; 1 failed (disable with --summary none)
install transitive failure
└─ install avr-arduino-zig transitive failure
   └─ zig build-exe avr-arduino-zig ReleaseSafe avr-freestanding-none failure
error: the following build command failed with exit code 1:
...

Do you have any idea what I can do to debug this further?

I just found a similar issue, which has been opened upstream: https://github.com/ziglang/zig/issues/16417


build: remove dependence on file system ordering

Different platforms sort A.js B.js a.js b.js differently.
This change has another benefit, which is ensuring that…
$ scripts/build -- src/{foo,bar}.js

and…
$ scripts/build -- src/{bar,foo}.js

produce the same output.

:herb:


Plot viewing procedures differ in the Download Antarctica datasets tutorial

Description of the desired feature: The Download Antarctica datasets tutorial does not contain the same plotting procedure for viewing each of the generated figures (compared to the other tutorials). Shouldn't you need a figure priming function after maps.plot_grd(grid)? Perhaps something like this:
maps.plot_grd(grid)
fig = maps.plot_grd(grid)
fig.show()

Good catch. It seems Jupyter notebooks will automatically show the figure either way, but to be compatible with running from the terminal, I will add in your correction as part of #195.


Feature/27157 skip commented sections

Hello,
I added a feature that allows to skip sections of code using certain region-like comments. Issue: #211
During testing I noticed, a bug where it actually still adds pre/suffixes to commented lines.

It's connected to the issue https://github.com/waldo1001/crs-al-language-extension/issues/211

It's reated to the issue https://github.com/waldo1001/crs-al-language-extension/issues/211

First of all - thanks a lot for the contribution!
I'm not sure this will work with all scenarios - so I'm going to have to thoroughly test this.  I didn't see extra tests - like one that confirms that the code actually has the intended behavior.. ?

Hi, I'm replying on behalf of my colleague :)
Basically that was really important for us because of the reasons mentioned in the issue and incoming go lives - I'm sure that you undersand our pain :D
Unfortunately we're not really fluent with VS Code extensions and JS ecosystem.
For that reason we just did what we needed and tested it manually without automated tests. We also didn't manage to run already prepared tests - we had really limited time to do so and not enough skills, I guess.
As we managed to obtain the result we needed (or at least we think we managed) we decided to show you this as a kind of an idea. We're totally aware that the code is not fully ready to be merged into master in such state. On the other hand I'm not sure we will have time available to finish this in 100% :/
If you're able to take over it, that would be really great.

I manually added these changes to the extension as I wanted to thoroughly test them, and implement automated testing as well .. .  So I'll close this Pullrequest, but do know I'm very grateful, and your changes ARE part of the product!

I'm really glad to hear that!
I've just downloded the newest version of your extension and it looks perfect, working as expected :)
I don't want to sound like an idiot, but I really admire the huge amout of your contribiution to the community. Respect!
Thanks again :)

I really appreciate that - thanks so much 👍
We have a very strong community - and people like you guys prove that every single day! 🙏


Add commonjs / npm support

Hi great module!
I'd like to consume it from npm via webpack so I've added support for that in this PR.
After merging + any time you release a new version you will just need to run npm publish to publish to npm.
Thanks!

Thanks for that :+1:

Great, thank you! Could you also publish it to npm (npm publish) from the root of the repo.

Sure, it's done

Great, thank you!


Automated dependency update (2020-02-10 07:08:50)

Codecov Report

Merging #386 into master will decrease coverage by 0.69%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #386     +/-   ##
========================================
- Coverage     100%   99.3%   -0.7%
========================================
  Files           8       8
  Lines         287     287
  Branches       54      54
========================================
- Hits          287     285      -2
- Partials        0       2      +2

Impacted Files
Coverage Δ

src/index.ts
92.3% <0%> (-7.7%)
:arrow_down:

src/rest.ts
96.77% <0%> (-3.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb543bc...efe3b78. Read the comment docs.


Fix test failure on i386

Closes: #247

It seems that the issue with mypy is not related to this PR

Yes that's not your fault


✨ Driver Control Improvements

Summary
Improves various aspects of driver control
Motivation
The current driver control has some limitations:

no motor desaturation
throttle and turn drive curves are the same
no controller deadzone
no minimum output

Implementation

Uses motor desaturation algorithm found here
Added multiple gains that can be passed to the Chassis ctor
Added controller deadzone
Added drivetrain minimum output

Test Plan

[X] verify alg works by running a lot of test cases
[X] Drive robot with Arcade
[X] Drive robot with curvature
[X] Drive robot with tank

Additional Notes

During curvature drive tests, turning was inconsistent. It would behave differently based on the initial input values. Tried earlier curvature drive implementations with the same effect. However, this is a bugfix and therefore outside the scope of this PR.

Interactive graph for drive curves: https://www.desmos.com/calculator/umicbymbnl

Download the template for this pull request:

[!NOTE]
This is auto generated from Add Template to Pull Request

via manual download<EMAIL_ADDRESS>via PROS Integrated Terminal:

curl -o<EMAIL_ADDRESS>https://nightly.link/LemLib/LemLib/actions/artifacts/1370510202.zip;
pros c fetch<EMAIL_ADDRESS>pros c apply<EMAIL_ADDRESS>rm<EMAIL_ADDRESS>

tested. LGTM


allow indexing

We need a sitemap.xml before we can implement search feature.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

duplicate of https://github.com/aws-samples/eks-workshop-v2/pull/311


icon update

The icon wasn't showing all the details initially created (double ring + interrogation point, not showed)

Hi, can you send a screenshot of the issue, and also on which browser and platform this issue occurs ? Because it’s working fine for me, and using base64 inside a SVG file is not really clean and in this case it increase the file size by 3280% (1.78 kb -> 58.4 kb)

My bad indeed.
It's okay on chrome, not on SAFARI Version 12.1.1 (146<IP_ADDRESS>.1) MacOS
https://prnt.sc/1tdbyjm
Regarding the SVG generation, I used PS included SVG generator, I have no clue on how to generate it differently.
(If you have tips I'm listening ;) )

I don’t use Photoshop but make sure to import the images as vectors (like SVG)

Hi @ValentinTh, I’m trying to find the issue, but as I don’t have a mac, could you please send me a screenshot with Safari v12 of the 3 images on this page https://jsfiddle.net/w5mna2ex/ ?
Thanks

Hi,
https://prnt.sc/1tlbzmf

Hi, thanks, well sometimes Safari is… interesting 🤔
I’ve updated with the SVG of the middle icon as it’s a good visual compromise and it prevent increasing massively the size of the file for everyone, with a benefit only for Safari v12 which is used by only less than 1% of users (and maybe v13, but looks like it’s fixed in v14)
(Also optimized an other icon while I was here)


Adding support for macOS to the rider plugin

closes #610

Is this still needed now that #616 got merged into master?

Yeah this is needed, #616 merged into the branch for this PR, so it hasn't made it to master yet.


Error with last image in BCSANDBOX

Hi everyone,
I've just created a new docker with the last version pulled from bcsandbox. Looks that everything has been allright, but when I open the windowsClient, I see this error:

Any hint about his issue?

How are you creating the container?
Do you use clickonce?

I've created with this command:
New-CSideDevContainer -containerName BeteaBC  -accept_eula -auth NavUserPassword -imageName "microsoft/bcsandbox:es" -licensefile "C:\6045219-desa2018.flf" -alwayspull -accept_outdated

You are using a very old version of NavContainerHelper.
New-CsideDevContainer has been removed for several months.
Update NavContainerHelper and use New-NavContainer - use -includecside if you need cside.

Hi Fredy,
I have the <IP_ADDRESS> version. according to your blog, the last one, am I right? I've removed the container, and created a new one with:
New-NAVContainer -containerName BeteaBC  -accept_eula -auth NavUserPassword -imageName "microsoft/bcsandbox:es" -licensefile "C:\6045219-desa2018.flf" -alwayspull -accept_outdated -includecside
And I still have the problem. The error message jsut appears in the home landing page, if I go to another page, I don't see the error...
Appart from this issue, I have another dpubt. According to the last changes sghown in dierctions Asia, in where can I get the image version for 2019 fall?
Thanks for everything

We will start building fall images later - not sure when yet.
<IP_ADDRESS> is the latest - what do you mean when referring to the home landing page - do you mean the new-navcontainer output? what error do you get?

When I log into the cliente, is the first I see:

If I chaneg to any other page, customer list for example, I don't see the error again.
i activated the debugger, retunr to the home page, and the debugger stops here:

Seems to be a problem with the O365 integration.

This of course shouldn't happen but in general, the sandbox images thinks they are an online saas service and as such thinks that they are connected to AAD, we have seen this give problems a number of times.
You could consider using the onprem images instead, they won't have this problem.

So, instead of pulling the bcsandbos image, pulling a different one? Which would you recommend?
Thank you very much

Just tried to run the exact same line as you - I do not get an error:

use mcr.microsoft.com/businesscentral/onprem:es that is spring release.
/Freddy

Ok, Thank you as always!

Hi Freddy,
Sorry for disturbing. I have tried to install the new image, but I don't have enough space. I read your article about cleaning the docker. So, i tried to delete all the content from "C:\ProgramData\docker". The content was very large, and at one time, I stopped the process, thinking that I will lose data for other developments. And when I try to deploy the image, I found errors like:

After, with the aim of cleanning the content in a controlled way, I downloaded the script and I get this error:

What should I do? SHould I delete all the content from the docker folder? Did I broke something? Can I restore the missing folders?
Thank you very much

It says: Type yes to continue.
You typed y
Type yes - then it should clean your docker installation and navcontainerhelper folder.

I have had to restore all the docker feature in the server, and pull again the image.
Now I don't get the error, but in the role center:

Anyway, it's not a big issue, it's just for developing so doesn't seem to be a problem

Very strange - it almost seems like the files are blocked so that the service tier cannot load the DLL's

I don't think so, it's an azure machine, I don't have any antivirus installed. The previos container didn't have this problem, seems to have relation wih the version....

Windows server 2016 or 2019?

Windows server 2016 datacenter

Ok, I am running 2019 - will try 2016.

Just tried with a new 2016 - works fine - cannot repro this.

Ok Freddy, really appreciate your help and view


[Analytics][Newsroom] Incorrect value for data-analytics-link-name for content cards

Priority: 2-Medium
Steps to Reproduce:

Navigate to https://tempnewsroom.accenture.com/
Inspect any "read more" link in the content cards

Expected Result:
data-analytics-link-name="read more: "

Actual Result:
data-analytics-link-name="read more"

@cylevaldez I don't see this article in the listing in https://tempnewsroom.accenture.com/

and on the existing articles, I do see the Read More link name as READ MORE

Can you please re-check this or share the url where I can see this issue reproducible.

@ravkiran The issue can be seen on any article card. The expected result of the "read more" link should be data-analytics-link-name="read more: ".
The one that is missing is the title of the card after read more, so this would mean that the data-analytics-link-name of the "read more" link will be different for each card. Please check the legacy site for reference.

@ravkiran The team mentioned that the fix was not applied to these local geos:
https://tempnewsroom.accenture.de/
https://tempnewsroom.accenture.fr/
https://tempnewsroom.accenture.it/
https://tempnewsroom.accenture.es/
https://tempnewsroom.accenture.co.uk/
https://tempnewsroom.accenture.sg/
https://tempnewsroom.accenture.pt/
https://tempnewsroom.accenturebr.com
As for the link name value, we can make it standard "read more: ". It is ok if the "read more" is in English even in other countries. The legacy site has the same implementation.


Distribute artifacts through Maven Central

Currently artifacts are available here:

https://maven.reposilite.com/#/releases/io/javalin-rfc

Source:
https://github.com/javalin/javalin-openapi/blob/85a99924027f95cfeaa39ffa6595522f1a8f7d4a/build.gradle.kts#L18-L22

How to proceed with this issue? Can I help?

Not really, it's something we need to resolve for whole organization, take a look at:

https://github.com/javalin/javalin/issues/1660


Fix and tweak Dockerfile

Fix
error: package `memchr v2.7.1` cannot be built because it requires rustc 1.61 or newer, while the currently active rustc version is 1.60.0

Added an Entrypoint and a usage example with docker in the doc.


[FIX - 85] - Update the all contributors badge to show to the center just below the banner

Description
[Provide a concise description of the purpose and goals of this pull request.]

To show the all contributors badge to the center

Related Issue(s)
[Link to any related issue(s) that this pull request addresses or resolves, e.g., "Closes #123" or "Fixes #456".]
Closes #85
Changes Made
[List the specific changes made in this pull request, including any new features, bug fixes, or improvements.]

fixed the all contributors badge to be properly showed in README.md file

Screenshots (if applicable)
[Include screenshots or images that help demonstrate the changes made, especially for UI-related changes.]

Checklist
Please review and check the following before submitting your pull request:

[X] I have followed the Code of Conduct.
[X] My code follows the project's contributing guidelines.
[X] I have tested my changes locally and they work as expected.
[X] I have included relevant tests for my changes.
[X] I have updated the project documentation if necessary.
[X] I have reviewed my code to ensure it is free of debugging or development-related code.
[X] I have provided clear and informative commit messages.

Additional Notes (if any)
[Include any additional information, context, or notes that might be relevant to the reviewer or project maintainers.]
Contributor License Agreement
By submitting this pull request, I confirm that my contribution is made under the terms of the project's License, and I agree to abide by the project's Code of Conduct.

Great work @anevski-stefan! Thanks

@all-contributors Please add @anevski-stefan for doc


misc/esniper build fails

If I run ENTERAFTER=patch synth test misc/esniper and then run make in the ensiper port, the config log shows:
configure:3451: cc -o conftest -I/usr/local/include -O2 -pipe  -fstack-protector -fno-strict-aliasing   -fstack-protector conftest.c -L/usr/local/lib -lcurl  >&5
/usr/bin/ld: warning: libnghttp2.so.14, needed by /usr/local/lib/libcurl.so, not found (try using -rpath or -rpath-link)

running env LD_LIBRARY_PATH=/usr/local/lib make works fine...

sounds like a problem with the curl port, not synth.
in other words, curl files to link with -Wl,-rpath and fails to use ldconfig (guessing without looking).
That has nothing to do with synth.  right?

it builds fine not under synth, so there's something odd going on with synth, it seems to me...

"builds fine not under synth" is completely irrelevant, and not surprising as ldconfig has probably been set by a another unrelated port.  Synth has clean, uncontaminated jails. Your "not under synth" environment is completely contaminated (from the point of view of reproducible builds) and not reproducible by anybody not using your machine.
There's nothing going on with synth.
Every time some port maintainer makes a mistake, I hear complaints that synth is malfunctioning.  Maybe someday people will start blaming the ports tree first. dunno if/when that will happen though.

I'd be happy to blame and/or correct the port if I understood what it is doing wrong - probably if you want people to blame ports first, more info on how to diagnose them would help, not everyone understands this stuff inside out.
How should curl use ldconfig?

not everyone understands this stuff inside out
Right, so why would they immediately assume a build tool is at fault before the much more obvious explanation of a bad port?  Synth is not undergoing changes, so if it's working for months the other reason to suspect it are if the tree undergoes a major change (as seen by recent /etc/rc.d error message)

Assuming curl is the thing at fault (I was just guessing), the first mistake is not linking with -Wl,-rpath.  The use of ldconfig is for ports that don't link properly.
see: https://www.freebsd.org/doc/en/books/porters-handbook/book.html
section 6.3
Alteratively,  misc/esniper might be missing an explicitly linkage to libnghttp2.  Maybe curl is being built with a non-often used option that esniper isn't expecting.  In any case, one of the 2 ports is the most likely culprit.  Synth is just reported a normal build error.

Hmm. Well, curl does use ldconfig.
misc/esniper only depends on curl - adding a dependency to libnghttp2 does not appear to make any difference, but in any case I am confused: are you saying that ensiper ought to include all of curl's dependencies?
BTW, the dependency in curl on libnghttp2 is part of its default config.

you need to report this to esniper maintainer.  It's not a synth issue.

moreover, the esniper maintainer should be able to reproduce with at least synth and most likely poudriere if he has the same settings as you do.

for more info, linkers nowdays require explicit linkages instead of recursive linkages.
So the older linker may have seen the libcurl links to libnghttp2 and automatically pulls in it, while gnu and maybe the latest elftools linker requires an explicit "-lnghttp2" flag on esniper.

i'm guessing esniper will build again with v2.05.
The /etc/rc.subr error looks like it means ldconfig wasn't working anymore.  So curl was specifying it, but no action was being taken.  Which means it was technically a synth problem after all (which means I owe you an apology but I didn't recognize it as the other /etc/rc.subr issues already mentioned in previous PRs)

I am indeed being hit by that. When are you expecting to release 2.05?

it's out.  you can build it manually if you want. (change version number in ports-mgmt/synth, "make makesum" and build it.  Not sure when eric will push the new version.

2.05 does indeed fix the problem.