(*checkerGitHubClient).UpdateCheckRun posts invalid "annotations" field to GitHub API

If I invoke Reviewdog in a GitHub Action like the following,
- name: Confirm Go source code is formatted per "gofmt"
  env:
    REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
  run: |
    gofmt -s -d . | \
      reviewdog -name="gofmt" -f=diff -f.diff.strip=0 -reporter=github-check -fail-on-error=true

and gofmt emits nonempty diff output recommending changes, Reviewdog fails due to the GitHub API rejecting its posts to the CheckRun resource:

Reviewdog output in GitHub Action step
Run gofmt -s -d . | \
  gofmt -s -d . | \
    reviewdog -name="gofmt" -f=diff -f.diff.strip=0 -reporter=github-check -fail-on-error=true
  shell: /usr/bin/bash -e {0}
  env:
    GOROOT: /opt/hostedtoolcache/go/1.16.3/x64
    REVIEWDOG_GITHUB_API_TOKEN: ***
{"severity":"ERROR","time":"2021-04-14T21:04:42.946283814Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"45","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"UpdateCheckRun failed: {\"message\":\"Validation Failed\",\"errors\":[{\"resource\":\"CheckRun\",\"code\":\"invalid\",\"field\":\"annotations\"}],\"documentation_url\":\"https://docs.github.com/rest/reference/checks#update-a-check-run\"}"}
{"severity":"DEBUG","time":"2021-04-14T21:04:42.946454216Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"46","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"Retrying UpdateCheckRun...: 1"}
{"severity":"ERROR","time":"2021-04-14T21:04:44.105366191Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"45","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"UpdateCheckRun failed: {\"message\":\"Validation Failed\",\"errors\":[{\"resource\":\"CheckRun\",\"code\":\"invalid\",\"field\":\"annotations\"}],\"documentation_url\":\"https://docs.github.com/rest/reference/checks#update-a-check-run\"}"}
{"severity":"DEBUG","time":"2021-04-14T21:04:44.105413792Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"46","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"Retrying UpdateCheckRun...: 2"}
{"severity":"ERROR","time":"2021-04-14T21:04:45.238388549Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"45","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"UpdateCheckRun failed: {\"message\":\"Validation Failed\",\"errors\":[{\"resource\":\"CheckRun\",\"code\":\"invalid\",\"field\":\"annotations\"}],\"documentation_url\":\"https://docs.github.com/rest/reference/checks#update-a-check-run\"}"}
{"severity":"DEBUG","time":"2021-04-14T21:04:45.238560851Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"46","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"Retrying UpdateCheckRun...: 3"}
{"severity":"ERROR","time":"2021-04-14T21:04:46.39616831Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"45","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"UpdateCheckRun failed: {\"message\":\"Validation Failed\",\"errors\":[{\"resource\":\"CheckRun\",\"code\":\"invalid\",\"field\":\"annotations\"}],\"documentation_url\":\"https://docs.github.com/rest/reference/checks#update-a-check-run\"}"}
{"severity":"DEBUG","time":"2021-04-14T21:04:46.39621551Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"46","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"Retrying UpdateCheckRun...: 4"}
{"severity":"ERROR","time":"2021-04-14T21:04:47.539729577Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"45","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"UpdateCheckRun failed: {\"message\":\"Validation Failed\",\"errors\":[{\"resource\":\"CheckRun\",\"code\":\"invalid\",\"field\":\"annotations\"}],\"documentation_url\":\"https://docs.github.com/rest/reference/checks#update-a-check-run\"}"}
{"severity":"DEBUG","time":"2021-04-14T21:04:47.539786178Z","logging.googleapis.com/sourceLocation":{"file":"/home/runner/work/reviewdog/reviewdog/doghouse/server/github_checker.go","line":"46","function":"github.com/reviewdog/reviewdog/doghouse/server.(*checkerGitHubClient).UpdateCheckRun"},"message":"Retrying UpdateCheckRun...: 5"}
reviewdog: post failed for gofmt: failed to post result: failed to post annotations: PATCH https://api.github.com/repos/bisontrails/seh-test-src/check-runs/2347136202: 422 Validation Failed [{Resource:CheckRun Field:annotations Code:invalid Message:}]
Error: Process completed with exit code 1.

Note that it's retrying after each fatal error, despite those failures being due to malformed input. The error claim that the "annotations" field is invalid.

@haya14busa is my solution acceptable? for now I'm using side-loaded static binary in my Github Actions for the annotations for clang-fomat to work. I can prepare PR, but I have too poor knowledge of Go and overall design to be sure it's the correct way to solve the problem (also: I don't really know how to prepare test case ;))

I'm running into this too. In https://docs.github.com/en/rest/reference/checks#update-a-check-run under "Properties of the annotations items" they say

message (string) | Required. A short description of the feedback for these lines of code. The maximum size is 64 KB.

so it seems correct to add the message, since it's required. Although I don't actually know that's the right spot; maybe omitempty should be removed from https://github.com/reviewdog/reviewdog/blob/3acb0871ee10438b934efbb266050ebddd93c748/proto/rdf/reviewdog.pb.go#L175 for example.

I've tested the suggested change above. This change results in no review comment and the status check only has "suggested fix" in the body as well as the line number, it does not actually contain the change. I'm utilizing git diff, and the following config:
reviewdog -reporter=github-check -filter-mode=nofilter -fail-on-error
runner:
  example:
    cmd: go run ./cmd/gen && git --no-pager diff
    format: diff
    level: error

I've tested the suggested change above. This change results in no review comment and the status check only has "suggested fix" in the body as well as the line number, it does not actually contain the change (edit: it does in raw output, but it doesn't suggest the change).

This change has worked on our GH action for clang-format checks and suggests the changes correctly - see:
https://github.com/phoenix-rtos/phoenix-rtos-devices/pull/191

The actual command we're using in workflow is:
git diff -U0 HEAD^ | clang-format-diff-10 -p1 | /tmp/reviewdog -f=diff -f.diff.strip=0 -name=clang-format-pr -reporter=github-pr-review -fail-on-error

IMHO in PRs You need to use github-pr-review reporter, maybe that's the reason?

Thanks for the reply!
The github-check reporter is almost identical to the github-pr-review reporter according to the docs, it just also works on individual commits. It works for several other linters as expected. I did also go to the trouble of trying it with printing the results it was posting and it was clear from those it was not going to work.
I suspect converting it from unified format to clang format like you did is the answer or potentially dropping the unified context to 0.

oof, when you realize what you're tryin to do with copy/paste from the README has been reported broken a year ago

Edit: wondering if the git format has changed since the readme added the diff instructions for git.

Highly doubt it, git is not breaking things with stuff like that, and git diff is pretty much just a unified diff with 1-2 git specific header lines. If anything github API might've changed.


【Hackathon 6th Article No.4】线性代数的使用指南&学习心得

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.KeithMaxwell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[COMPILER] Frozen strings are not fstring

"foo".freeze.equal?("foo".dedup)

Should output true but outputs false.

@peterzhu2118 we also need this for hash keys that are strings


Description for Repository

It will be better if some form of description is given for the repository

Can you please elaborate on what kind of description does the repo lack currently?

About this Project, apart from the README.md, briefing in the about section, will get good reach.😀

Added.


Stop autoscroll when user starts scrolling

addressing /issues/1
ScrollViewDelegate watches user drag actions

when user starts dragging, it stops autoscroll, so they can scroll freely
when user stops dragging, if they scrolled back down to the bottom, it restarts autoscroll
(autoscroll also restarts whenever a new prompt is sent)

Notes:

iOS only, because it uses the introspected UIScrollView
it feels bad and inefficient to rerun the introspectScrollView block every time the view reloads, but I guess that's the standard SwiftUI pattern
it's pretty simple to disable autoscroll when user starts dragging the scroll view, but there are complications with resuming autoscroll when user scrolls back down to bottom.

iOS dragging has momentum, so users can release the drag gesture before they've actually reached the bottom and expect scroll to reach bottom, so we should check for bottom in scrollViewDidEndDecelerating, when the scroll actually ends, not just when drag ends
the bottom of the view is a moving target if ChatGPT is in the middle of replying, so in practice I found I was trying to scroll to the bottom and coming up short
the solution I arrived at was to check where the bottom is in scrollViewWillEndDragging and use that bottom offset as the target in scrollViewDidEndDecelerating
an alternative would be to add some kind of padding to the "bottom" offset so that autoscroll restarts when user just scrolls close to the bottom

OMG you made my evening!   This is delightful, auto-merging and deploying!


Development

I'll resolve the issues this evening.

I just checked, don't merge it. It has some problems. I will fix them and then raise a fresh PR.
After replying, just close the pull request, don't merge it. Just close it.

I just checked, don't merge it. It has some problems. I will fix them and then raise a fresh PR.


Add Euskera, Basque in List of Supported Languages

This language will be available in 10.1.0

@ConnorLand - I've reviewed this - can you pick it up when 10.1 is released. Thanks.

Got it.


Angular 19

This PR just update dependencies to support Angular 19.

You really have no idea what upgrading Angular major means...
You waste your time and mine...


update additional instances of inline damage to new format

For Pernicious Spore Bomb and Sulfur Bomb, the inline damage links can probably be removed as it should be handled by the damage rolls.

Changes made - please check when you get a moment

Changes made - please check when you get a moment

I think splash is automatically handled as well?

Changes made - please check when you get a moment

I think splash is automatically handled as well (Pernicious Spore Bomb)?

Pernicious Spore Bomb has three types of damage - two are included in the item itself, except the last one which I left alone.

Pernicious Spore Bomb has three types of damage - two are included in the item itself, except the last one which I left alone.

I think it's automatically handled by the:
"splashDamage": {
	"value": 1
}

Updated


postinstall does not work on windows

installing library in windows fails due to rm command in postinstall. Consider using cross platform library like rimraf to achieve the same result.

I might not be able to get to this this weekend. If you need a workaround, you can pin to version v0.9.1 before this was introduced.

Fix published as v0.9.3. Sorry, such a small change took me so long. I'll have much more time for open source projects very soon. Thanks to @yamadayutaka for confirming that it works on windows.


Building with MinGW (MinGW Builds gcc 5.3.0)

Interesting proposal. :+1:  I would wish to try it in a "real" project
Any possibility of official support for MinGW? Thanks! :-)
> cmake -G "MinGW Makefiles" ..
-- The C compiler identification is GNU 5.3.0
-- The CXX compiler identification is GNU 5.3.0
-- Check for working C compiler: V:/MinGW-Builds/mingw64/bin/gcc.exe
-- Check for working C compiler: V:/MinGW-Builds/mingw64/bin/gcc.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: V:/MinGW-Builds/mingw64/bin/g++.exe
-- Check for working CXX compiler: V:/MinGW-Builds/mingw64/bin/g++.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMAKE_CXX_FLAGS = -g -std=c++11 -fno-stack-protector
Checking for <stdint.h> -- yes
Checking for noexcept keyword -- yes
Checking for constexpr keyword -- yes
Checking for override keyword -- yes
Checking for long long -- yes
-- Configuring done
-- Generating done
-- Build files have been written to: P:/Plataformas/x32-x64/junction/junction/buildunix

> mingw32-make
Scanning dependencies of target junction
[  2%] Building CXX object CMakeFiles/junction.dir/junction/ConcurrentMap_Grampa.cpp.obj
In file included from P:/Plataformas/x32-x64/junction/turf/turf/c/core.h:17:0,
                 from P:/Plataformas/x32-x64/junction/turf/turf/Core.h:18,
                 from P:/Plataformas/x32-x64/junction/junction/junction/Core.h:25,
                 from P:/Plataformas/x32-x64/junction/junction/junction/ConcurrentMap_Grampa.h:16,
                 from P:\Plataformas\x32-x64\junction\junction\junction\ConcurrentMap_Grampa.cpp:13:
P:/Plataformas/x32-x64/junction/turf/turf/c/platform_detect.h:37:10: error: #error "Unrecognized platform!"
         #error "Unrecognized platform!"
          ^
In file included from P:/Plataformas/x32-x64/junction/turf/turf/impl/Atomic_Native.h:17:0,
                 from P:/Plataformas/x32-x64/junction/turf/turf/Atomic.h:47,
                 from P:/Plataformas/x32-x64/junction/junction/junction/Core.h:27,
                 from P:/Plataformas/x32-x64/junction/junction/junction/ConcurrentMap_Grampa.h:16,
                 from P:\Plataformas\x32-x64\junction\junction\junction\ConcurrentMap_Grampa.cpp:13:
P:/Plataformas/x32-x64/junction/turf/turf/c/atomic.h:424:6: error: #error "TURF_PTR_SIZE not set!"
     #error "TURF_PTR_SIZE not set!"
      ^
In file included from P:/Plataformas/x32-x64/junction/turf/turf/c/atomic.h:33:0,
                 from P:/Plataformas/x32-x64/junction/turf/turf/impl/Atomic_Native.h:17,
                 from P:/Plataformas/x32-x64/junction/turf/turf/Atomic.h:47,
                 from P:/Plataformas/x32-x64/junction/junction/junction/Core.h:27,
                 from P:/Plataformas/x32-x64/junction/junction/junction/ConcurrentMap_Grampa.h:16,
                 from P:\Plataformas\x32-x64\junction\junction\junction\ConcurrentMap_Grampa.cpp:13:
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h: In function 'uint8_t turf_compareExchange8Relaxed(turf_atomic8_t*, uint8_t, uint8_t)':
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:77:74: error: '_InterlockedCompareExchange8' was not declared in this scope
     return _InterlockedCompareExchange8((char*) object, desired, expected);
                                                                          ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h: In function 'intreg_t turf_compareExchangeWeak8Relaxed(turf_atomic8_t*, uint8_t*, uint8_t)':
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:82:79: error: '_InterlockedCompareExchange8' was not declared in this scope
     uint8_t previous = _InterlockedCompareExchange8((char*) object, desired, e);
                                                                               ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h: In function 'uint8_t turf_exchange8Relaxed(turf_atomic8_t*, uint8_t)':
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:90:57: error: '_InterlockedExchange8' was not declared in this scope
     return _InterlockedExchange8((char*) object, desired);
                                                         ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h: In function 'uint8_t turf_fetchAdd8Relaxed(turf_atomic8_t*, int8_t)':
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:94:60: error: '_InterlockedExchangeAdd8' was not declared in this scope
     return _InterlockedExchangeAdd8((char*) object, operand);
                                                            ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h: In function 'uint16_t turf_exchange16Relaxed(turf_atomic16_t*, uint16_t)':
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:132:59: error: '_InterlockedExchange16' was not declared in this scope
     return _InterlockedExchange16((short*) object, desired);
                                                           ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h: In function 'uint16_t turf_fetchAdd16Relaxed(turf_atomic16_t*, int16_t)':
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:136:62: error: '_InterlockedExchangeAdd16' was not declared in this scope
     return _InterlockedExchangeAdd16((short*) object, operand);
                                                              ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h: In function 'uint64_t turf_load64Relaxed(const turf_atomic64_t*)':
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:203:11: error: expected '(' before '{' token
     __asm {
           ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:204:9: error: 'mov' was not declared in this scope
         mov esi, object;
         ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:205:13: error: expected ';' before 'ebx'
         mov ebx, eax;
             ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:206:13: error: expected ';' before 'ecx'
         mov ecx, edx;
             ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:207:9: error: 'lock' was not declared in this scope
         lock cmpxchg8b [esi];
         ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:208:13: error: expected ';' before 'dword'
         mov dword ptr result, eax;
             ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:209:13: error: expected ';' before 'dword'
         mov dword ptr result[4], edx;
             ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h: In function 'void turf_store64Relaxed(turf_atomic64_t*, uint64_t)':
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:228:11: error: expected '(' before '{' token
     __asm {
           ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:229:9: error: 'mov' was not declared in this scope
         mov esi, object;
         ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:230:13: error: expected ';' before 'ebx'
         mov ebx, dword ptr value;
             ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:231:13: error: expected ';' before 'ecx'
         mov ecx, dword ptr value[4];
             ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:233:9: error: 'cmpxchg8b' was not declared in this scope
         cmpxchg8b [esi];
         ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:233:20: error: 'esi' was not declared in this scope
         cmpxchg8b [esi];
                    ^
P:/Plataformas/x32-x64/junction/turf/turf/c/impl/atomic_msvc.h:234:9: error: 'jne' was not declared in this scope
         jne retry;
         ^
In file included from P:/Plataformas/x32-x64/junction/turf/turf/Atomic.h:47:0,
                 from P:/Plataformas/x32-x64/junction/junction/junction/Core.h:27,
                 from P:/Plataformas/x32-x64/junction/junction/junction/ConcurrentMap_Grampa.h:16,
                 from P:\Plataformas\x32-x64\junction\junction\junction\ConcurrentMap_Grampa.cpp:13:
P:/Plataformas/x32-x64/junction/turf/turf/impl/Atomic_Native.h: In member function 'T* turf::Atomic_Native<T*>::load(turf::MemoryOrder) const':
P:/Plataformas/x32-x64/junction/turf/turf/impl/Atomic_Native.h:174:76: error: there are no arguments to 'turf_loadPtr' that depend on a template parameter, so a declaration of 'turf_loadPtr' must be available [-fpermissive]
         return (T*) turf_loadPtr(&m_value, (turf_memoryOrder_t) memoryOrder);
                                                                            ^
P:/Plataformas/x32-x64/junction/turf/turf/impl/Atomic_Native.h:174:76: note: (if you use '-fpermissive', G++ will accept your code, but allowing the use of an undeclared name is deprecated)
In file included from P:/Plataformas/x32-x64/junction/turf/turf/ConditionVariable.h:39:0,
                 from P:/Plataformas/x32-x64/junction/junction/junction/striped/ConditionPair.h:18,
                 from P:/Plataformas/x32-x64/junction/junction/junction/striped/ConditionBank.h:17,
                 from P:/Plataformas/x32-x64/junction/junction/junction/striped/AutoResetEvent.h:17,
                 from P:/Plataformas/x32-x64/junction/junction/junction/striped/Mutex.h:23,
                 from P:/Plataformas/x32-x64/junction/junction/junction/details/Grampa.h:18,
                 from P:/Plataformas/x32-x64/junction/junction/junction/ConcurrentMap_Grampa.h:17,
                 from P:\Plataformas\x32-x64\junction\junction\junction\ConcurrentMap_Grampa.cpp:13:
P:/Plataformas/x32-x64/junction/turf/turf/impl/ConditionVariable_Win32.h: In constructor 'turf::ConditionVariable_Win32::ConditionVariable_Win32()':
P:/Plataformas/x32-x64/junction/turf/turf/impl/ConditionVariable_Win32.h:27:47: error: 'InitializeConditionVariable' was not declared in this scope
         InitializeConditionVariable(&m_condVar);
                                               ^
P:/Plataformas/x32-x64/junction/turf/turf/impl/ConditionVariable_Win32.h: In member function 'void turf::ConditionVariable_Win32::wait(turf::LockGuard<turf::Mutex_Win32>&)':
P:/Plataformas/x32-x64/junction/turf/turf/impl/ConditionVariable_Win32.h:31:81: error: 'SleepConditionVariableCS' was not declared in this scope
         SleepConditionVariableCS(&m_condVar, &guard.getMutex().m_mutex, INFINITE);
                                                                                ^
P:/Plataformas/x32-x64/junction/turf/turf/impl/ConditionVariable_Win32.h: In member function 'void turf::ConditionVariable_Win32::timedWait(turf::LockGuard<turf::Mutex_Win32>&, turf::intTypes::ureg)':
P:/Plataformas/x32-x64/junction/turf/turf/impl/ConditionVariable_Win32.h:36:87: error: 'SleepConditionVariableCS' was not declared in this scope
             SleepConditionVariableCS(&m_condVar, &guard.getMutex().m_mutex, waitMillis);
                                                                                ^
P:/Plataformas/x32-x64/junction/turf/turf/impl/ConditionVariable_Win32.h: In member function 'void turf::ConditionVariable_Win32::wakeOne()':
P:/Plataformas/x32-x64/junction/turf/turf/impl/ConditionVariable_Win32.h:40:41: error: 'WakeConditionVariable' was not declared in this scope
         WakeConditionVariable(&m_condVar);
                                         ^
P:/Plataformas/x32-x64/junction/turf/turf/impl/ConditionVariable_Win32.h: In member function 'void turf::ConditionVariable_Win32::wakeAll()':
P:/Plataformas/x32-x64/junction/turf/turf/impl/ConditionVariable_Win32.h:44:44: error: 'WakeAllConditionVariable' was not declared in this scope
         WakeAllConditionVariable(&m_condVar);
                                            ^
In file included from P:/Plataformas/x32-x64/junction/turf/turf/Atomic.h:47:0,
                 from P:/Plataformas/x32-x64/junction/junction/junction/Core.h:27,
                 from P:/Plataformas/x32-x64/junction/junction/junction/ConcurrentMap_Grampa.h:16,
                 from P:\Plataformas\x32-x64\junction\junction\junction\ConcurrentMap_Grampa.cpp:13:
P:/Plataformas/x32-x64/junction/turf/turf/impl/Atomic_Native.h: In instantiation of 'T* turf::Atomic_Native<T*>::load(turf::MemoryOrder) const [with T = junction::striped::ConditionPair]':
P:/Plataformas/x32-x64/junction/junction/junction/striped/ConditionBank.h:40:58:   required from here
P:/Plataformas/x32-x64/junction/turf/turf/impl/Atomic_Native.h:174:33: error: 'turf_loadPtr' was not declared in this scope
         return (T*) turf_loadPtr(&m_value, (turf_memoryOrder_t) memoryOrder);
                                 ^
CMakeFiles\junction.dir\build.make:62: recipe for target 'CMakeFiles/junction.dir/junction/ConcurrentMap_Grampa.cpp.obj' failed
mingw32-make[2]: *** [CMakeFiles/junction.dir/junction/ConcurrentMap_Grampa.cpp.obj] Error 1
CMakeFiles\Makefile2:66: recipe for target 'CMakeFiles/junction.dir/all' failed
mingw32-make[1]: *** [CMakeFiles/junction.dir/all] Error 2
Makefile:126: recipe for target 'all' failed
mingw32-make: *** [all] Error 2

I dont think so

I just quickly added basic MinGW support. All the samples build. However, I had to disable support for CPU affinities since I don't know what API to use. A side effect of this is that currently some samples only run single-threaded on MinGW.


hub push not working on Windows

The following files use dev/null for suppressing error messages on git, which doesn't work on Windows:

This makes dotenvx throw the following error:

are you using powershell here?
this is not using the dotenvx.exe, correct?

yep, using powershell 7, and not from the exe

looks like the only way to to do this is to start adding OS checks throughout. so i'll get a start on that.

actually, execa might solve this problem for us - rather than using child_process

most of this is patched now using execa. a little more work to do.

this is fixed with v0.30.2


feat: add Dockerfile and example

@ltfschoen I made some changes to the client api, I'm updating your examples.

Is the Dockerfile for creating a development env?

Is the Dockerfile for creating a development env?

yes, for example incase a user just wants the convenience of simply installing Docker and running a couple of commands to have all the relevant dependencies setup so they can hack on it in a development environment without potentially facing issues with incompatible versions due to outdated docs or if they're using an operating systems that only has PowerShell or something that would otherwise make installation more annoying.

Yes. To make it easier to create a development environment, I created a devcontainer. Here is the simple doc for it. Can you try it and give me feedbacks?
https://github.com/wuminzhe/scale_rb?tab=readme-ov-file#development


Update ownerapi_endpoints.json to 4.14.4-1455 🔗

Changes:

Update ownerapi_endpoints.json to v4.14.4-1455 on par with the Tesla App

Notes

Only one small change regarding the lootbox, nothing major/no changes to documentation needed.

Thanks!


⚠ Jenkins Plugins Artifactory has degraded performance

In fa04343, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1056 ms

Resolved: Jenkins Plugins Artifactory performance has improved in f564a30 after 6 hours, 14 minutes.


Delay adding helper method to on_load

Autoloading within initilizers is deprecated in rails 6.0.
Adding helper method to ActionController::Base during initialization
will trigger autoloading it.
This delays adding the helper methods using an on_load() hook for
all rails version >= 6.

Is there any chance this will get merged?

I second the question from @jbeker

This gem is on the verge of becoming useless when Rails 6.2 is released because of this.

This gem is on the verge of becoming useless when Rails 6.2 is released because of this.


check warnings in building routine

Description of the issue
There occured a couple of warnings in the building routine of the latest release.

ToDo: check if there is a need to update the routines.
Ideas of solution
If you already have ideas for the solution describe them here
Workflow checklist

[ ] I am aware of the workflow for this repository

I have noticed that the file or directory names for the release artefacts change slightly from time to time. For the oep, only the oeo.zip (called build-files.zip in earlier versions) is currently relevant. Just a hint that changing directory names might confuse others :) .

@jh-RLI mentioned this here: https://github.com/OpenEnergyPlatform/ontology/discussions/1836#discussioncomment-9572595
Maybe this is related.


Change label for System->About->SS version

This is old for Subutai Social shorthand. Must have missed it in the renaming. Quick easy fix. Let's just call it Subutai Management Version.
NOTE Also let's capitalize version because it's specific to a product component. English grammar rule: when referencing any version we can lowercase. When talking about specific version and in label I think we should follow rule to capitalize the first letter.
Again bogus quick fix.

may be just name it Console Version b/c it will take much space if we use Subutai Management Version


can't fetch subscriptions

$ youtube-dl --version
2014.03.10
youtube-dl --verbose -i -u<EMAIL_ADDRESS>:ytsubs
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', '-i', '-u', '', ':ytsubs']
[debug] Encodings: locale 'UTF-8', fs 'UTF-8', out 'UTF-8', pref: 'UTF-8'
Type account password and press return:
[debug] youtube-dl version 2014.03.10
[debug] Python version 2.7.6 - Linux-3.13.0-16-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] Proxy map: {}
[youtube:subscriptions] Downloading login page
[youtube:subscriptions] Logging in
[youtube:subscriptions] subscriptions feed: Downloading page 1
[download] Downloading playlist: Youtube Subscriptions
[youtube:subscriptions] playlist Youtube Subscriptions: Collected 0 video ids (downloading 0 of them)
attaching screenshot of my youtube account subscriptions

The problem seems to be unsolved still because for me, it still gives 0 videos if I try to download my subscriptions via youtube-dl. Also, I don't understand why it is a problem with authentication, because if I enter a wrong password it tells me that. I run "youtube-dl :ytsubs --username=...", then it asks for my password, goes on if its correct and extracts the feed: 0 videos... If I am doing something wrong here, what do I have to change to get it working?

I am experiencing the issue again although my 2-factor auth is turned off at the moment. Also, verbose is not showing any errors. Output:
user@some-host:~$ youtube-dl -i --verbose<EMAIL_ADDRESS>--download-archive=~/.youtube-dl/archive.list :ytsubs
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-i', u'--verbose'<EMAIL_ADDRESS>u'--download-archive=~/.youtube-dl/archive.list', u':ytsubs']
Type account password and press [Return]:
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.05.20
[debug] Python version 2.7.10rc1 - Linux-3.16.0-4-amd64-x86_64-with-debian-stretch-sid
[debug] exe versions: rtmpdump 2.4
[debug] Proxy map: {}
[youtube:subscriptions] Downloading login page
[youtube:subscriptions] Logging in
[youtube:subscriptions] Youtube Subscriptions: Downloading webpage
[download] Downloading playlist: Youtube Subscriptions
[youtube:subscriptions] playlist Youtube Subscriptions: Collected 0 video ids (downloading 0 of them)


Styles optimization option - "removeSpecialComments" is not working

Which @angular/* package(s) are the source of the bug?
compiler-cli
Is this a regression?
Yes
Description
Styles optimization option - "removeSpecialComments" is not working. This feature was merged in the PR: https://github.com/angular/angular-cli/pull/26444/files.

Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
Error: Schema validation failed with the following errors:
  Data path "/optimization/styles" must NOT have additional properties(removeSpecialComments).
  Data path "/optimization/styles" must be boolean.
  Data path "/optimization/styles" must match exactly one schema in oneOf.
  Data path "/optimization" must be boolean.
  Data path "/optimization" must match exactly one schema in oneOf.

Please provide the environment you discovered this bug in (run ng version)
Angular CLI: 17.3.5
Node: 20.11.1
Package Manager: npm 10.2.4
OS: win32 x64

Angular: 17.2.4
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1703.5
@angular-devkit/build-angular   17.3.5
@angular-devkit/core            17.3.5
@angular-devkit/schematics      17.3.5
@angular/cdk                    17.2.2
@angular/cli                    17.3.5
@schematics/angular             17.3.5
rxjs                            6.6.7
typescript                      5.2.2

Anything else?
No response

@gopalpunvant, this is only available when using the application builder.
Which builder are you using?

@alan-agius4 For build, I am using only Angular CLI's "ng build --configuration production" command.

xdghdfghdfhgdfgh

@gopalpunvant, please provide the entire “build” section of your angular.json.

@alan-agius4 I got you now. I am using "@angular-devkit/build-angular:browser" builder and I also saw that the "removeSpecialComments" is not available for it. So, is there any way to minimise the css while keeping the special comments as it is?

@gopalpunvant, not with the browser builder.


Added email verification feature

User cannot to login until email is verified

Also please share the routes for the API and required env variables we have to declare Thanks!

Environmental variables need to declared:

EMAIL_ID = Email host user
EMAIL_PASS = 2-step verification and Application specific password
FRONTEND_URL = Frontend domain

Great effort!
Can you please merge these changes in the api branch so that we can do the testing before merging it in the main branch? Thanks!

I have created a pull request to api branch.


Bug fix sync service

Set Sync automatically to content resolver in MainActivity

Codecov Report

:exclamation: No coverage uploaded for pull request base (backend-overhaul@cd57552). Click here to learn what that means.
The diff coverage is 0%.

@@                Coverage Diff                 @@
##             backend-overhaul   #3069   +/-   ##
==================================================
  Coverage                    ?   5.35%
==================================================
  Files                       ?     268
  Lines                       ?   11798
  Branches                    ?     960
==================================================
  Hits                        ?     632
  Misses                      ?   11115
  Partials                    ?      51

Impacted Files
Coverage Δ

...r/free/nrw/commons/contributions/MainActivity.java
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd57552...195ecb7. Read the comment docs.


adding search more button and remove redundant using filters

This pull request include code with the following options
1: Removing duplicates using filter
2: Adding Show more

Integrated other version of this.


Updated Broken Links

Argilla Community Growers
Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged.
Pull Request Templates
Please go the the Preview tab and select the appropriate sub-template:

🐞-bug
📚-documentation
🆕-features

Generic Pull Request Template
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactor (change restructuring the codebase without changing functionality)
[x] Improvement (change adding some improvement to an existing functionality)
[x] Documentation update

How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

[ ] Test A
[ ] Test B

Checklist

[x] I added relevant documentation
[ ] follows the style guidelines of this project
[ ] I did a self-review of my code
[ ] I made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I filled out the contributor form (see text above)
[ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

There were two broken links in the Readme , I fixed it of the cheatsheets and the Contribution guidelines Have a look
at my pr @davidberenstein1957

Hi @ayan-joshi, this looks great. Thanks for the contribution! Feel free to check our contributor docs for some other issues if you are interested :)

@ayan-joshi Thanks again for this PR! Just to double-check, did you fill out our contributor form? https://tally.so/r/n9XrxK


API mutation to associate a user to an org

Associating users to an organization
this requires API calls to Okta
this should be restricted to only admin users see https://github.com/CDCgov/prime-simplereport/blob/main/backend/src/main/java/gov/cdc/usds/simplereport/service/DeviceTypeService.java#L48

@jeremyzitomer-usds Happy to help out with this!

@jeremyzitomer-usds Happy to help out with this!

@nickrobison-usds and @timothybest-usds -- i'm assuming that this will allow the current user to add any user to any org, not necessarily themselves or the org they're in?

@nickrobison-usds and @timothybest-usds -- i'm assuming that this will allow the current user to add any user to any org, not necessarily themselves or the org they're in?

For now this action should be restricted to admin users

For now this action should be restricted to admin users

right, sorry my question wasn't about who can execute this action, but rather, who they can add to orgs. i.e. the "object" of this action, not the "subject."

right, sorry my question wasn't about who can execute this action, but rather, who they can add to orgs. i.e. the "object" of this action, not the "subject."

The subject would be an Okta user account

The subject would be an Okta user account

@benwarfield-usds as part of the multi-tenant work, is there an api call to get all orgs? unsure what else the api user would use to identify an org to add someone to, when it's not the api user's current org.

@benwarfield-usds as part of the multi-tenant work, is there an api call to get all orgs? unsure what else the api user would use to identify an org to add someone to, when it's not the api user's current org.

the following query will get you the users current organization
user {
  organization {
      id
      externalId
  }
}

We have yet to build an endpoint to get all orgs. I think we should use a lookup by organization external ID on user create

the following query will get you the users current organization
user {
  organization {
      id
      externalId
  }
}

We have yet to build an endpoint to get all orgs. I think we should use a lookup by organization external ID on user create

so does this mean that the api mutation in this ticket isn't meant to allow an admin to add users to orgs that are not their own?

so does this mean that the api mutation in this ticket isn't meant to allow an admin to add users to orgs that are not their own?

I would assume the user's current org, yes. Admin users can arrange to be part of a particular organization when doing maintenance operations on that org￼, and in the medium to long term we want for org-level admin to be able to do this as well. ￼(they just don't exist yet, as a category.)￼

I would assume the user's current org, yes. Admin users can arrange to be part of a particular organization when doing maintenance operations on that org￼, and in the medium to long term we want for org-level admin to be able to do this as well. ￼(they just don't exist yet, as a category.)￼


Handles "system" & "all" types in fetch log action

This commit updates the Bosh Agent to support the "system" and "all" log types that are now (or will soon be) supported by the Bosh CLI. This work is backwards-compatible with versions of the Bosh CLI that do not support these new log types.
The "system" log type fetches the logs from "/var/log". System logs are placed into a "/var/log" directory inside the tarball. This is done to generally avoid confusion as to the source of these logs, but especially when the "all" log type is requested. Do note that if the "all" log type is requested, and the VM has a job named "var" deployed, then the system logs will be placed into a "log" subdirectory in the "var" job's log directory. For now, this seems to be a minor and unlikely problem, so avoiding this doesn't seem to be worth the hassle.
The "all" log type is a pseudo-type constructed by the Bosh CLI, which fetches all currently-known log types; "job" (the historical (and current) default when no log type is specified), "agent", and "system".
NOTE: Requests for the "system" log type will be sliently ignored when
the Agent is running on an OS that is not Linux. Currently, only
Windows and Linux are supported OSs. If we ever support another
Unix-alike OS (or figure out how to do something sensible and
useful on Windows), then the code that handles the "system" log
type will need to be updated.
NOTE: The fetch log action can handle combinations of log types that
are not supported by the Bosh CLI. This should generally be
harmless, and probably makes it easier to extend in the future.
We also do no deduplication of the log types passed to the action.
A malicious user could take advantage of this to cause the Agent
to consume large amounts of RAM or disk space (whether in the
blobstore, or on the Agent's disk), but if a malicious user has
the credentials required to talk to the Agent, they can already
get up to significant mischief.
Signed-off-by: Brian Cunnie<EMAIL_ADDRESS>

NOTE: This PR is related to, but does not require this bosh-cli PR: https://github.com/cloudfoundry/bosh-cli/pull/614

@selzoc I'm tagging you because you recently refactored part of the code that I modified, so you may (or may not) wish to review that part of this change to ensure that I didn't break your change.

That struct still has LogType, singular. Is this intentional?

Yeah, I was being lazy and didn't want to track down the users of that field. Would you prefer that I do and rename the field?

Yeah, I was being lazy and didn't want to track down the users of that field. Would you prefer that I do and rename the field?

Maybe as a fast-follow to these commits, I don't think we need to block any merging on it :)

@selzoc are you willing to approve these changes, with the caveat that I change the spelling of that variable that you mentioned in Fetch LogsWithSignedUrlAction:? (I think we're supposed to have approval from two reviewers before merging a PR, and I note that the identical changes in the PR for the other branch was merged in this morning. It'd be nice to be able to merge this in and get started on that rename and also CLI documentation.)

Done!

@selzoc Because LogType seems to refer to a JSON key of the same name in these two spots:
https://github.com/cloudfoundry/bosh-agent/blob/2f41166593e281eacc99dea18b17b98dc246555c/agent/action/bundle_logs.go#L20
https://github.com/cloudfoundry/bosh-agent/blob/2f41166593e281eacc99dea18b17b98dc246555c/agent/action/fetch_logs_with_signed_url.go#L15
I'm going to leave the variable name as-is. I'd rather the variable name be a little incorrect than it not match its data source.


Increasing the QUARANTINE_THRESHOLD to a large number still stops the test before the threshold is reached

HEADS UP!
I changed the QUARANTINE_THRESHOLD and DISCONNECT_THRESHOLD  in test_run_controller.ts file to 1 million each and built successfully however, my test still fails after around 1000-10000 restarts with the error :
ERROR The Chrome 89.0.4389.90 / Linux 0.0 browser disconnected. This problem may appear when a browser hangs or is closed, or due to network issues.
Is there something else that may be forcing testcafe to quit? or is the issue in browser perhaps?
Another question I had was regarding testcafe's typetext function. If I by mistake do typetext on an element that does not accept text like a paragraph tag or div tag, then it waits for a long time instead of realizing the element is not typeable. (around 2 mins; sometimes more). The message I see is "waiting for element to appear" on the bottom of the browser. How do I set the timeout to a shorter value for that message to detect sooner?
Thank you

According to the error, your browser hangs for some reason. The problem could be in the way you organize your tests. It's likely that you have some code that leads to memory leaks, and after 1000-10000 restarts, your machine does not have enough RAM to run the browser.
Please clarify why you need to restart your tests 1000-10000 times.

I changed the QUARANTINE_THRESHOLD and DISCONNECT_THRESHOLD in test_run_controller.ts file

We are working on the quarantine mode configuration, so you will have the capability to change quarantine options out of the box.

Another question I had was regarding testcafe's typetext function. If I by mistake do typetext on an element that does not accept text like a paragraph tag or div tag, then it waits for a long time instead of realizing the element is not typeable. (around 2 mins; sometimes more). The message I see is "waiting for element to appear" on the bottom of the browser. How do I set the timeout to a shorter value for that message to detect sooner?

Please create a separate issue using the following link: https://github.com/DevExpress/testcafe/issues/new?assignees=&labels=&template=bug-report.md
Please create a separate issue using the following link: https://github.com/DevExpress/testcafe/issues/new?assignees=&labels=&template=bug-report.md
At this moment, I can only say that the described behavior is unexpected.


Develop 151 mpi cross sections

closes #151

Codecov Report

Merging #173 (86db696) into main (1ec85ab) will decrease coverage by 1.09%.
The diff coverage is 30.92%.

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   81.96%   80.87%   -1.10%
==========================================
  Files          99       99
  Lines        5245     5400     +155
==========================================
+ Hits         4299     4367      +68
- Misses        946     1033      +87

Impacted Files
Coverage Δ

src/cross_section_factory.F90
42.10% <10.00%> (-54.96%)
:arrow_down:

src/cross_section.F90
87.17% <40.00%> (-6.94%)
:arrow_down:

src/cross_sections/o3_tint.F90
93.44% <71.42%> (-1.34%)
:arrow_down:

src/cross_section_warehouse.F90
93.02% <86.66%> (-4.20%)
:arrow_down:

src/grid_factory.F90
57.69% <0.00%> (-42.31%)
:arrow_down:

src/grid_warehouse.F90
78.40% <0.00%> (-0.32%)
:arrow_down:

src/grid.F90
10.16% <0.00%> (+6.53%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


bluestacks.rb: upgrade to <IP_ADDRESS>3902

Thank you for the contribution. It was merged directly as f961cf74fc5dd92e2eca95c40446a8881fffea45 to keep commit history cleaner. Your contribution is still credited to you.


using templatecache to pack partials into javascript file

Can we use gulp-angular-templatecache
in build process.
This lets us put all foundation angularjs code including partials into single file (foundation.js)
It also avoids http requests for partials and improve performance.

#463 addresses this. We'd like it in the codebase for version 1.1.


Update set-up-new-message-encryption-capabilities.md

added step to troubleshoot if step3 fails.

@JohanFreelancer9 Please copy review

Issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/7886

@KCCross Please merge this PR. Thanks


Docs for "Progress" visual element are missing

Issue Description
The docs for a newly created Progress element are missing, here's the PR for the vis element - https://github.com/Avaiga/taipy/pull/1303
Screenshots or Examples (if applicable)
No response
Proposed Solution (optional)
On taipy.io, we can add a the docs for progress element.
Code of Conduct

[X] I have checked the existing issues.
[X] I am willing to work on this issue (optional)

Hi @yaten2302
Let us add more details on how to add documentation so you can start working on it.
Thanks a lot

Hey @jrobinAV , yes sure, I would definitely work on this issue 👍 Actually, I've only implemented the  Progress element, so I'm quite familiar with it. Could, you please give some info on how can I get started with it and then I'll implement this in the website.
BTW, it has to be similar to this, right?

Hi @yaten2302 and thank you for your help on this one!
And yes, using the documentation for button is a great start.
The very first thing you must do is insure you can build the Taipy documentation locally. The (short) file [taipy-doc]/INSTALLATION.md should give all the information you need.
You have to know a few things about unsaid rules on documenting visual elements before you start.

Documenting a visual element has impacts on both taipy rand taipy-doc  repositories.

The documentation mainly sits in the taipy-doc repository.

This issue captures the taipy-doc side of the work for this case.
The main element doc page is generated by merging a template file located in [taipy-doc]/docs/manuals/userman/gui/viselements/generic/<element_type>.md_template and the description file [taipy]/taipy/gui/viselements.json.
The doc template file has three main sections that must be filled in:

An introduction section where the first line is used as a short description in [the elements palette]
(https://docs.taipy.io/en/develop/manuals/userman/gui/viselements/) page.
A 'Details' section where deeper explanations are needed for come properties (beside what is described in viselements.json)
A 'Usage' section that presents tiny independent examples addressing an identified use case.

Every example must contain at least the definition of the documented control for this case (potentially using specific Python code).
The control definition appears in a mkdocs Code block that presents the definition so that it can be copied and pasted, for the Markdown, HTML and Page Build API cases. Note that there is the !!! taipy-element shortcut syntax that generates the three cases automatically, when possible. I can provide details on that if needed.
The final rendering must be shown in a PNG images pair (both light and dark reading modes).

The taipy side is about exposing viselements.json (whose doc fragments must contain raw HTML - or even better, XHTML - and not Markdown), and code examples source files, which are stored in [taipy]/doc/gui/examples/controls.

Every example must be stored in a script called <element_type>-<tiny_description>.py.
The example must run independently when Taipy is installed (python run <element_type>-<tiny_description>.py)
If must not depend on external resources (except in exceptional cases where datasets must be fetched)
These examples must be as simple as possible and show the impact of setting some properties to certain values.

Please get inspiration from an existing control (such as button) and do not hesitate to ask for help. It's the first time a contributor participates to adding documentation on a visual elements.

Thanks for your help @FabienLelaquais 👍
So, what I've understood is that - first I've to set up the taipy-doc repo and make changes in this file - *taipy-doc*/docs/manuals/userman/gui/viselements/generic/progress.md_template?
I've a doubt, as you told that the progress element has to be added in here as well *taipy*/taipy/gui/viselements.json, but the progress is already present here.
And yes, for the doc template file, I've understood about it 👍
For, the main taipy repo, I've a doubt that as you told that there should be and example present in this dir - [taipy]/doc/gui/examples/controls for the ease of the developer, so in this issue, can the example be like - creating a simple progress element by showing both the linear and circular progress bars? And yes, I'll make sure that there are no external resources 👍

you told that the progress element has to be added in here as well

You got my point exactly.
You should come up with a few, very simple examples that demonstrate how properties impact the rendering and/or the ability for a user to act on a control.
So usually we start with a 'simple' example (in a file stored at [taipy]/doc/gui/examples/controls\progress-simple.py), you will certainly set a relevant value for the value property and you're done. No other property.
A second example (in a file stored at [taipy]/doc/gui/examples/controls\progress-linear.py) would be to show a linear progress bar by just setting the linear property to False.
Finally you may want to show how to hide the value itself (using the show_value property).
And you're done.
If you have any problem generating the images, don't hesitate to leave that to me. I'll be happy to take screen shots as needed.
Thanks again.
Note that I never said "that the progress element has to be added in [...]viselements.json.
It is part of the development task, when we provide a simple documentation of the element properties.
May be I did that, I don't remember to be honest.
So yes it exists, and part of the job is making sure this simple doc is accurate and complete.
I did spot a 'TODO' not (that I certainly added) that needs a resolution.

@FabienLelaquais , thank you so much for the clear explanation. Now, I'm very much clear with what and how I've to proceed. I'll resolve this issue ASAP 👍
I'm really happy that I'm a contributor at  Taipy and would definitely like to become a member of the Taipy famly someday 😄

I sincerely hope this can happen some day, @yaten2302. Your input is very valuable.
Thank you.

Hey @FabienLelaquais , actually, I was trying to display the code for the markdown, html and python for the progress, but, I'm facing an issue, that when I'm doing changing the progress.md_template and progress.md files, these changes are being shown,  could you please guide where I'm making the mistake?

Like, I'm not able to see in this format

BTW, I also wanted to ask that, the .md files, like button.md are in the .gitignore, so any changes made in those will not be displayed right?

Also, I've linked a PR to this issue, this PR is not complete, it's just the beginning of the docs work and I'll keep adding my progress in this PR 👍

Oh. The thing you are missing is the doc build process described in  [taipy-doc]/INSTALLATION.md .
Here is how it goes (pay close attention to step 2, which you are missing):
1- First, you must copy the product source files locally, so that the Reference Manual can be generated.
This is done by invoking, from the  taipy-doc root directory: python tools/fetch_source_files.py develop.
This copied all mandatory files locally, from the  develop branch of the relevant GitHub repositories.
Il also computes a merged Pipfile so all dependencies can be resolved when parsing the source files.
So you will need to: pipenv install --dev.
This operation can be done once and for all, as long as source files don' t change, or if you don't really care at this point.
2- Then you must setup all files before you run  mkdocs.
From the  taipy-doc root directory, run pipenv run python tools/setup_generation.py.
This will generate all the files that  mkdocs relies on.
That includes Markdown files for the Reference Manual, as well as fill in the template files (such as the  .md_template files you need to modify).
3- Finally, you can see your generated doc:  pipenv run mkdocs serve.
Now for your questions:

" I'm doing changing the progress.md_template and progress.md files" you should not do that.
Only the md_template file should be modified, then the related md file would be generated by the setup_generation script.
".md files, like button.md are in the .gitignore": yes. That's because these are generated (by setup_generation.py).
All *_template files are modified by this script, and generate the final file next to it.
In our example,  progress.md_template is processed to generate progress.md will all the control properties automatically sneaking in.

Your example lacks the mandatory use of the value property.
Does that makes sense?

@FabienLelaquais , I followed all the steps exactly, as you mentioned here(which are the same as in the INSTALLSTION.md), except the last one! I did - mkdocs serve instead of pipenv run mkdocs serve, actually, in the installation.md, it was mentioned mkdocs serve, so that's why did.
And, yes, in my example, the value param is missing right now, I'll add it, this PR was just for showing the changes, which I've made till now, this is not the final PR.

@FabienLelaquais , I just figured out that where I was making the mistake. I've added the html/markdown/python code in the md_template file itself, rather than adding it in this dir - [taipy]/doc/gui/examples/controls\progress-linear.py (as you told in your previous comment).
But, I've a doubt, that when I'll add this, then it'll be in a different repo, so after that, do I've to run the steps in installation.md again? after that my changes will be reflected or it's something else?

@yaten2302
Adding the examples in the taipy repo has no impact on the doc generation: we just create a link from the doc to the GitHub location. No worries about that.
The rules are:

You must re-run the fetch command (step 1) if and only if the taipy code has changed (source files) or the viselements.json file.
You must re-run the setup command (step 2) if and only if fetch was performed, or when any template file (such as those md_template file) is modified.

What I do actually is: in the taipy-doc repo, I update my *.md file (and NOT the template file) until I'm happy with the result.
When I'm done, I compare the md file with the md_template file, and update the template file with all I've done, expect for the code that is generated (like the element's properties section and the elements definition - the !!!taipy-element thing).
When I work on an element's documentation, that process saves a lot of time since I don't have to regenerate the md file over and over when I change a word to another.
Please let me know if this makes things more clear.
Note: I will fix the error in the INSTALLATION.md file. Thanks.

@FabienLelaquais , actually, I was trying to create the code for the "value" param as well, but when I added a new
!!! taipy-element
        value=50
        default=True

then both the code got changed, could you please guide

Like, before adding the 2nd !!! taipy-element, it was working fine, but after adding this, this occurred

So you have two problems here:

The first one is due to no documentation on this !!! taipy-element thing.
The syntax is (a bit simplified):
 !!! taipy-element
     <property-name1>=<value>
     <property-name2>=<value>
     ...

There is one exception: the default property.
In your case, that is 'value'.
So basically,
  !!! taipy-element
     default=10
     render=True
     ...

 is kind of equivalent to

  !!! taipy-element
     value=10
     render=True
     ...

except that then, the default property is never used.
In the first case Markdown, that would generate: <}10|progress|render=True|> which is file.
The second case would generate: <}|progress|value=10|render=True|>. Although equivalent, we favor the first.

The second problem is simply due to the fact that you don't have a carriage return at the end of your file.
Just add a new line, you're good to go.

Hey @FabienLelaquais , sorry for the huge delay. Actually, I've closed the previous PR I'll create a new one with the changes 🙏

I'll be watching. Don't worry @yaten2302. Sometimes things get messy.
Cheers

Hey @FabienLelaquais , I've made the changes, it's working perfectly fine now 🎉

Now, I'm adding for the linear=True param and then ig we're good to go?

@FabienLelaquais , is this looking good?

@FabienLelaquais , I've created a PR, could you please review that and LMK if any changes are required in it 👍


Do we need to create a new toil-box on each new cluster creation?

Discussed on the call today between me and @hannes-ucsc. I thought we needed to create a new toil-box image whenever we registered a new key, @hannes-ucsc thinks we don't. TBD; we'll sort this out and fix it in the instructions later.

The answer is "No". If you find this to be inaccurate, please reopen.


Remove delete[] from bfdrivers unit tests

This patch removes the need for delete[] in the bfdriver
unit tests. We already made this change in the unwinder tests
but never got around to it on the driver side. Interestingly
enough, this was the last remaining delete, everything else
at this point uses shared_ptr or unique_ptr.
Signed-off-by: “Rian<EMAIL_ADDRESS>

Coverage remained the same at 100.0% when pulling cb0f467718d1e0be1e4e77b429d3df5d6063df6f on rianquinn:remove_redundant_nullptr_checks into 3a060e2825eb7ad610758405801149e70eedfd01 on Bareflank:master.

Coverage remained the same at 100.0% when pulling cb0f467718d1e0be1e4e77b429d3df5d6063df6f on rianquinn:remove_redundant_nullptr_checks into 3a060e2825eb7ad610758405801149e70eedfd01 on Bareflank:master.


Consider river pod provider

https://pub.dev/packages/riverpod
It’s 100% testable as it’s not dependent on flutter.
And many other great aspects
https://riverpod.dev/
It’s now being used by a few projects . Been waiting 6 months for this

I love Riverpod, but the Slidy has been created look at Modular.  :(


add: cost model schema

The schema for the cost model.
Usage:
Dump cost-model-schema into dbdiagram.io to visualize.
TODO (remaining tables):

[x] Index
[x] Trigger
[x] Constraints

Merged from #2.


Last application cannot be deleted with per-application correctly

Environment

Application Services Version: 3.51.0 Build 5
BIG-IP Version: 17.1.1 Build 0.0.6 Final

Summary
Deleting the last application of a tenant not work when there is a vlan or something else in the tenant.
A clear and concise description of what the bug is.
Please also include information about the reproducibility and the severity/impact of the issue.
Steps To Reproduce
Steps to reproduce the behavior:

Create a partition with the name "bug-last-application"
Create a vlan in this partition (f.e. vlan_555)
Submit the following declaration to: POST https:/xxx/mgmt/shared/appsvcs/declare/bug-last-application/applications

{
    "app_<IP_ADDRESS>_26":{
       "class":"Application",
       "label":"<IP_ADDRESS>/26",
       "remark":"as3 application for <IP_ADDRESS>/26",
       "sf-int_<IP_ADDRESS>_26":{
          "class":"Service_Forwarding",
          "forwardingType":"ip",
          "label":"<IP_ADDRESS>/26",
          "policyFirewallEnforced":{
             "use":"x_firewall-policy_<IP_ADDRESS>_26"
          },
          "remark":"service-forwarding int for <IP_ADDRESS>/26",
          "snat":"none",
          "translateServerAddress":false,
          "translateServerPort":false,
          "virtualAddresses":[
             "<IP_ADDRESS>/26"
          ],
          "virtualPort":0
       },
       "x_firewall-policy_<IP_ADDRESS>_26":{
          "class":"Firewall_Policy",
          "label":"<IP_ADDRESS>/26",
          "remark":"firewall policy for <IP_ADDRESS>/26",
          "rules":[
             {
                "use":"x_firewall-rule-list_<IP_ADDRESS>_26_product-related"
             },
             {
                "use":"x_firewall-rule-list_<IP_ADDRESS>_26_architecture-related"
             },
             {
                "use":"x_firewall-rule-list_<IP_ADDRESS>_26_customer-related"
             }
          ]
       },
       "x_firewall-rule-list_<IP_ADDRESS>_26_architecture-related":{
          "class":"Firewall_Rule_List",
          "label":"<IP_ADDRESS>/26",
          "remark":"architecture related firewall-rule-list for <IP_ADDRESS>/26",
          "rules":[

          ]
       },
       "x_firewall-rule-list_<IP_ADDRESS>_26_customer-related":{
          "class":"Firewall_Rule_List",
          "label":"<IP_ADDRESS>/26",
          "remark":"customer related firewall-rule-list for <IP_ADDRESS>/26",
          "rules":[

          ]
       },
       "x_firewall-rule-list_<IP_ADDRESS>_26_product-related":{
          "class":"Firewall_Rule_List",
          "label":"<IP_ADDRESS>/26",
          "remark":"product related firewall-rule-list for <IP_ADDRESS>/26",
          "rules":[

          ]
       }
    },
    "controls":{
       "class":"Controls",
       "logLevel":"debug",
       "trace":true
    },
    "id":"per-app-declaration",
    "schemaVersion":"3.51.0"
 }

Delete the application with DELETE https://xxx/mgmt/shared/appsvcs/declare/bug-last-application/applications/app_<IP_ADDRESS>_26

{
    "results": [
        {
            "code": 422,
            "message": "declaration failed",
            "response": "0107082a:3: All objects must be removed from a partition (bug-last-application) before the partition may be removed, type ID (467)",
            "host": "localhost",
            "tenant": "bug-last-application",
            "runTime": 5799,
            "declarationId": "1721553302466"
        }
    ],
    "declaration": {
        "bug-last-application": {
            "class": "Tenant",
            "app_<IP_ADDRESS>_26": {
                "class": "Application",
                "label": "<IP_ADDRESS>/26",
                "remark": "as3 application for <IP_ADDRESS>/26",
                "sf-int_<IP_ADDRESS>_26": {
                    "class": "Service_Forwarding",
                    "forwardingType": "ip",
                    "label": "<IP_ADDRESS>/26",
                    "policyFirewallEnforced": {
                        "use": "x_firewall-policy_<IP_ADDRESS>_26"
                    },
                    "remark": "service-forwarding int for <IP_ADDRESS>/26",
                    "snat": "none",
                    "translateServerAddress": false,
                    "translateServerPort": false,
                    "virtualAddresses": [
                        "<IP_ADDRESS>/26"
                    ],
                    "virtualPort": 0
                },
                "x_firewall-policy_<IP_ADDRESS>_26": {
                    "class": "Firewall_Policy",
                    "label": "<IP_ADDRESS>/26",
                    "remark": "firewall policy for <IP_ADDRESS>/26",
                    "rules": [
                        {
                            "use": "x_firewall-rule-list_<IP_ADDRESS>_26_product-related"
                        },
                        {
                            "use": "x_firewall-rule-list_<IP_ADDRESS>_26_architecture-related"
                        },
                        {
                            "use": "x_firewall-rule-list_<IP_ADDRESS>_26_customer-related"
                        }
                    ]
                },
                "x_firewall-rule-list_<IP_ADDRESS>_26_architecture-related": {
                    "class": "Firewall_Rule_List",
                    "label": "<IP_ADDRESS>/26",
                    "remark": "architecture related firewall-rule-list for <IP_ADDRESS>/26",
                    "rules": []
                },
                "x_firewall-rule-list_<IP_ADDRESS>_26_customer-related": {
                    "class": "Firewall_Rule_List",
                    "label": "<IP_ADDRESS>/26",
                    "remark": "customer related firewall-rule-list for <IP_ADDRESS>/26",
                    "rules": []
                },
                "x_firewall-rule-list_<IP_ADDRESS>_26_product-related": {
                    "class": "Firewall_Rule_List",
                    "label": "<IP_ADDRESS>/26",
                    "remark": "product related firewall-rule-list for <IP_ADDRESS>/26",
                    "rules": []
                }
            },
            "controls": {
                "class": "Controls",
                "logLevel": "debug",
                "trace": true
            }
        },
        "class": "ADC",
        "schemaVersion": "3.51.0",
        "id": "1721553302466",
        "updateMode": "selective",
        "controls": {
            "archiveTimestamp": "2024-07-21T09:15:09.318Z"
        }
    },
    "code": 422
}

The application is deleted in the config/gui but not in as3.

Retrieve the application with https://xxx/mgmt/shared/appsvcs/declare/bug-last-application/applications/app_<IP_ADDRESS>_26

You will see that the configuration is still there in as3

Actual Behavior
If you deploy the same virtual address after the delete in another tenant (f.e. other-tenant) and then configure it again in the tenant "bug-last-application", there is an error due to " sharing same virtual address"
The application endpoint fails with 422 and the response All objects must be removed from a partition (bug-last-application) before the partition may be removed, type ID (467)
{
"code": 422,
"message": "declaration failed",
"response": "0107082a:3: All objects must be removed from a partition (bug-last-application) before the partition may be removed, type ID (467)",
"host": "localhost",
"tenant": "bug-last-application",
"runTime": 5799,
"declarationId": "1721553302466"
}
In addition, the Terraform resource "bigip_as3_deploy" does not throw an error even though the application was not deleted correctly.
Expected Behavior
The application should be deleted correctly (ALSO in AS3) even if there are other objects (vlan, etc) in this partition. The tenant should remain unaffected by this.

Jira Task AUTOTOOL-4590


Cant get it to run! Numba version...

If anyone can get this to work (or create a whl)???
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts numba==0.48.0
Good luck.  It needs this older version of numba to work, but the older version causes all sorts of hassles trying to cooperate with the other packages.
Any way to fix this???

The problem is the requrements misses a lot of required packages to run the script.
This is as close as I can get which is many more packages than theirs.
python -m pip install --upgrade pip
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts wheel==0.38.4
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/jmoso13/jukebox-diffusion@baeee35ee0198e8d5954d07519bf0ea6a9a66719
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts fire==0.1.3
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts soundfile==0.10.3.post1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts unidecode==1.1.1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts numba==0.48.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts librosa==0.7.2
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts mpi4py==3.1.4
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts av==10.0.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/jmoso13/a-unet.git@add_dilation
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/jmoso13/audio-diffusion-pytorch.git@noise_pass
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts torchmetrics==0.11.4
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts pytorch-lightning==1.7
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts wandb==0.15.11
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts Pygments==2.14.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/arogozhnikov/einops.git@4f6afb3eb368661c383b2a7717d416814c1afc7f
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts ipython==8.15.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts pandas==2.1.1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts resampy==0.3.1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts tqdm==4.57.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts pillow==10.0.1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts PyYAML==6.0.1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/Harmonai-org/sample-generator.git@c61cc65257ae8c178620ddc37c04aa24b421b326
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/crowsonkb/v-diffusion-pytorch.git@439ed4caf765ec6f8fccb52213a859cac9e76d3b
pip uninstall -y torch
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts torch==2.0.1+cu118 torchvision==0.15.2+cu118 torchaudio==2.0.2+cu118 --index-url https://download.pytorch.org/whl/cu118
The problem is that old version of numba will not compile/build with the rest that are more recent and that VoC uses.
If numba could be updated to the newest version it would be OK, but that needs tweaking the rest of them and probbaly the scripts code.

Hi,  The above was a repost from one of my users from my Discord as I am tyring to get Jukebox Diffusion working in Visions of Chaos (https://softology.pro/voc.htm)
I started from your requirements which did not specify versions required and did not seem to include all required packages.  So as I went along testing and adding other needed packages, I got to the requirments as shown above.
The only problem is that your scripts seem to require an older version of numba 48.0 way back from Jan 2020.  It also needs an older numpy version.  So I try numpy 1.22.4 and then numba 48.0.  numba won't compile with
      INFO: No module named 'numpy.distutils._msvccompiler' in numpy.distutils; trying from distutils
      building 'numba._dynfunc' extension
      creating build\temp.win-amd64-cpython-310
      creating build\temp.win-amd64-cpython-310\Release
      creating build\temp.win-amd64-cpython-310\Release\numba
      INFO: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\bin\HostX86\x64\cl.exe /c /nologo /O2 /W3 /GL /DNDEBUG /MD -ID:\Tests\Jukebox Diffusion\voc_jukeboxdiffusion\include -ID:\Python\include -ID:\Python\Include -IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\include -IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.37.32822\ATLMFC\include -IC:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\VS\include -IC:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt -IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\um -IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\shared -IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\winrt -IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\cppwinrt -IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um /Tcnumba/_dynfuncmod.c /Fobuild\temp.win-amd64-cpython-310\Release\numba/_dynfuncmod.obj -g
      cl : Command line warning D9002 : ignoring unknown option '-g'

Maybe it also need an older VS version too?
Updating numpy and numba gets all the requirments installed.  So now I have the following in a new environment.
python -m pip install --upgrade pip
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts wheel==0.38.4
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/jmoso13/jukebox-diffusion@baeee35ee0198e8d5954d07519bf0ea6a9a66719
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts fire==0.1.3
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts soundfile==0.10.3.post1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts unidecode==1.1.1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts numpy==1.26.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts numba==0.58.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts librosa==0.7.2
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts mpi4py==3.1.4
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts av==10.0.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/jmoso13/a-unet.git@add_dilation
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/jmoso13/audio-diffusion-pytorch.git@noise_pass
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts torchmetrics==0.11.4
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts pytorch-lightning==1.7
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts wandb==0.15.11
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts Pygments==2.14.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/arogozhnikov/einops.git@4f6afb3eb368661c383b2a7717d416814c1afc7f
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts ipython==8.15.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts pandas==2.1.1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts resampy==0.3.1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts tqdm==4.57.0
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts pillow==10.0.1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts PyYAML==6.0.1
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/Harmonai-org/sample-generator.git@c61cc65257ae8c178620ddc37c04aa24b421b326
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts git+https://github.com/crowsonkb/v-diffusion-pytorch.git@439ed4caf765ec6f8fccb52213a859cac9e76d3b
pip uninstall -y torch
pip install --no-cache-dir --ignore-installed --force-reinstall --no-warn-conflicts torch==2.0.1+cu118 torchvision==0.15.2+cu118 torchaudio==2.0.2+cu118 --index-url https://download.pytorch.org/whl/cu118

But then when trying to train with the first example command
python train.py --train-data ./wavs --jb-level 2 --ckpt-save-location ./ckpts
I get this error
from numba.decorators import jit as optional_jit
ModuleNotFoundError: No module named 'numba.decorators'

So numba needs to be older for this to work.  But older numba is not compatible with newer requirements.
There is no whl for numba 48.0 I can find.  If there was I could possibly get Jukebox Diffusion working.  Hence my first request if anyone could compile it.  Some of my users are good at compiling stubborn WHL files and if I get a working WHL it can be used for any install to work much smoother.

Thanks so much for reporting this issue, unfortunately this repo relies on an extremely old version of OpenAI's Jukebox along with more modern repos for doing diffusion. The whole thing leads to a mess of requirements and I totally understand the frustration with conflicting package versions. I'm working on a more updated version that does not rely on Jukebox at all, uses updated package versions, and should generate at higher quality. I'll tag you and let you know when that is released so you can try it out! I'm sorry you couldn't get it working and I appreciate you trying. Closing for now.


[webview_flutter] How to ignore ssl in latest version?

Please do not keep filing duplicates of this issue.
Closing as a duplicate of https://github.com/flutter/flutter/issues/36925 (and https://github.com/flutter/flutter/issues/98931, and https://github.com/flutter/flutter/issues/101354).


change in the rocket animation..

Sir I am Radhey your junior from 2nd year .
I have changed the rocket animation and have put a ashtonished animation there pls review it.

I'm not so sure, but it doesn't show any animation except that its a static red colored rocket diagram (with a broken character in the end). Is there anything I'm missing?

Sir pls see it now i have done the changes in the animation now one by one it will pop the animation and then the user name pls seek to it

That's really strange as whole script have been changed, and the animation isn't something really fancy or something actually useful to grab attention even. Please don't go against hacktoberfest's values and perform spammy PRs :face_exhaling:.
Closing this, if you got anything good feel free to open another PR :smiley:.


feat: wait for coredns and metrics-server, mk2

Reverts replicatedhq/embedded-cluster#623, but runs in the background so that display is unchanged except in case of errors

Limitations of this:

It only displays in between the other add-ons - it won't interrupt a spinner
It'll only show one background error, even if there are multiple

A demonstration of output with severely broken networking:
✔  Host files materialized!
? Enter an Admin Console password: ******
? Confirm password: ******
✔  Node installation finished!
✔  Waiting for Storage to be ready
the Kubernetes Infrastructure failed to become ready: Metrics Server failed to become healthy: timed out waiting for metrics-server to deploy
timed out waiting for openebs-localpv-provisioner to deploy: unable to get deploy openebs-localpv-provisioner status: deployments.apps "openebs-localpv-provisioner" not found


English translation error

For the item "Substitute Jizo", the description should be:
Right click on a maid to make it invulnerable, creative only
currently, it is:
Right click on the maid to make it invulnerability, creative only

Thank you very much, it has been fixed


Charts are not displaying like cone or trapezium when the data difference between two fields is minimal

Hi, after loading my data, the chart is displaying like below using chart.funnel.js
http://www.mediafire.com/view/8n4e5hdby3u311n/chartjs chart.jpg#
but I want the chart to look like below, here I'm using kibana
http://www.mediafire.com/view/n4fzdp6xzpn0p9h/Kibana chart.jpg#
Can you please help me to solve this
Thank you

Default Chart.Funnel.js will use the real percentage to render
You can use 'fake' number (like [1000,900,800,...] ) to render and change tooltips.callbacks.label options
tooltips: {
callbacks: {
title: function (tooltipItem, data) {
return '';
},
label: function (tooltipItem, data) {
return 'you real value'
};
}
}


RuntimeAnimation: Fix original value used in the bone matrix case

We want the original value to be the current (matrix) value at the time the RuntimeAnimation is started, which may be different than the rest matrix (which should not be used, anyway, as it's a matrix for user consumption only).

Snapshot stored with reference name:
refs/pull/14249/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14249/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14249/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14249/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14249/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14249/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14249/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14249/merge#BCU1XR#0


Consider adding transform_evaluate()

What does evaluate_with_context now do?  Let's say expr is "a + b".  Does
the context only apply to the evaluation of a and b as terminals, or does
it apply to the plus operation as well?

It applies to the plus operation first.  If the
context has a handler for plus, then it's up to
the context to handle recursion.  If it does not,
then it becomes
evaluate_with_context(a, ctx, x...)

evaluate_with_context(b, ctx, x...)

Are such applications of the
context conditional?  How does the reader quickly grasp what the
evaluate_with_context() call does?  This seems like really muddy code to
me.  If you have something else in mind, please provide more detail -- I
may of course be misunderstanding you.

My idea is that it would behave exactly like
transform, except that the default behavior for
nodes that are not handled by the context is
to evaluate the operators instead of building
a new expression.
Ah, I think I get it now.  This is really a transform_evaluate() then?  If so, that does sound useful.

Mooted by recent API changes.

Can you explain exactly how the functionality of transform_evaluate can now be achieved? Looked at the new documentation but can't figure it out easily.

Sure.  transform_evaluate(xform) is the same as transform(xform, evaluation()), now that multiple transform objects can be passed to transform().

Ahhhh, I see.


Add ability to edit keyboard shortcuts

Platform:
OSX
Kap Version:
1
Steps to reproduce
Command + Shift + 5
Current behaviour
Shortcut is clashing with another shortcut with no way to change it.
Expected behaviour
Preferences should have an option to set new shortcut
Workaround

Hey @freelancesam, thanks for the issue.
This is planned in an upcoming release. We'll use this issue to keep you up to date.

Command + Shift + 5 happens to be the "run" command in Codepen

Contributions are welcome 😄

Also Skitch screenshot is Command + Shift + 5.
Perhaps I'll have a look and submit a PR.

I'd like to work on this too.
Does it make sense to put it only in to the preferences Window or also on the control panel ?

That's awesome news @fokusferit! Keyboard shortcut configuration would live within preferences in it's own tab.

I must agree with @skllcrn here. I don't see the interaction value in investing scarce interface real-estate in order to enable direct access to manipulate keyboard shortcuts from the control panel.

I just wanted to share my small experience, I tried to work on this feature but I'm not confident at all with the code base.
If it used something like React or Vue it would have been much easier, and I guess you'd get more contributors. Just my 2cents

@FezVrasta We absolutely want to rewrite Kap with React (Next.js) but we wanted our feature set to take priority so we're currently working on getting v2 out and then we'll absolutely work on porting Kap into React ❤
Thanks for your input.

Until we ship this I suggest adding a setting to turn keyboard shortcuts on or off all together, that way it's easy for people to avoid conflicts with other apps.

Would really love some customizability here. Even if kap just looked for some config file that we can edit in a text editor before falling back to the hard-coded default.
(whether the config file is something we create in our user directory, or something we need to find after each update in Applications -> Kap (right click -> show package contents) -> some folder.

To me it would be enough to have a checkbox to disable them

In progress as part of #450

globalShortcut

When the accelerator is already taken by other applications, this call will silently fail. This behavior is intended by operating systems, since they don't want applications to fight for global shortcuts.

We'll need a hard-coded list of shortcuts and messages. Could be a good reusable Electron module!

#507

Hi!  That latest OSX release Mojave has made the default hotkey for screenshots command+shift+5 which interferes with Skitch's default hotkey.  I need the ability to change/customize Skitch's hotkeys to avoid this issue.  Please let me know when that will be done :)

Hey @jesset55, You can sign up to get early access and start using the new custom keyboard shortcuts at getkap.co!


[Select] Use "" value to reset to placeholder

Fixes #1569

You can already use the release candidates as soon as the PR merge.
https://www.npmjs.com/package/@radix-ui/react-select?activeTab=versions

You can already use the release candidates as soon as the PR merge. https://www.npmjs.com/package/@radix-ui/react-select?activeTab=versions

Thx a lot, didn't see the rc.

I may be missing something however It'd be really nice if we could just use <Select.Item value="">Reset</Select.Item> to reset the Select rather than having to interact with the <Select.Root />

@nowlena  For this rc-release only , since I didn't install the later version, you can do it via.
    <Select.Item value={undefined as unknown as string}>
         Reset
     </Select.Item>

It's hacky but make sense. and you also cannot make Select.Item value to be string | undefined imo in order to satisfy our implementation goals.

So, how to use this exactly?
I'm a bit confused, I installed the latest rc version, and I tired to have an item with an empty string value, but I got this error ...
Uncaught Error: A <Select.Item /> must have a value prop that is not an empty string. This is because the Select value can be set to an empty string to clear the selection and show the placeholder.
So, how exactly should I reset the select to the placeholder?

So, how exactly should I reset the select to the placeholder?

Ensure all items have a unique value, none should use empty string
Pass a placeholder to <Value />
Use the controlled props to set the value of <Root /> to an empty string

@andy-hook  Thanks a bunch, that worked.

@andy-hook  Do I have to use the <Select> inside a <form> tag in order for the this feature to work?
The reason I'm asking is because I have this case where I'm using "React Hook Form", and so that I can set the value to null in case the user chose the option that reset to the placeholder I have to do something like ...
onValueChange={(value: string) => {
    if (value === "empty_field") {
        field.onChange(null);
    } else {
        field.onChange(value);
    }
}}
value={field.value === "empty_field" ? "" : field.value}

But when I do this (the onValueChange) the  doesn't reset to the placeholder, unless I wrap the <Select> inside a <form> tag.
I created a quick Codesandbox demo ...
https://codesandbox.io/s/radix-ui-select-yv9gsl?file=/src/App.tsx

@Shaker-Hamdi I haven't looked closely at your code but Select renders a native element to bubble form values only when it is wrapped inside a form, that might help explain the different behaviour here depending on how useForm is attempting to interface with form elements.
Changing field.onChange(null) to field.onChange('') appears to work in both cases though.

@andy-hook You're correct, setting the value to an empty string instead of null works in both cases.
Thank you.

Still struggling to add a placeholder as a valid item to "reset" the select though. Setting the value to undefined works, but breaks the ItemIndicator.
I don't understand what was wrong with the previous implementation. It worked to reset the field and was closer to the native implementation of .


WIP Port wonky integration tests to systemtests as part of switching to systemtests

I rule and have completed some work on Case Manager that's ready for review!
Getting our problem children into systemtest now to see if it helps. Let's see what happens!
This pull request makes the following changes:

Ports a few tests known to be flaky besides update patient info (call list test, specifically!)
fixes a few other that got beef with CI for some reason

It relates to the following issue #s:

Bumps #1143

Still TK is getting the CI build to green

Stuff to do something about:

Failure:
CallListTest::completed calls section#test_0002_should time a call out after 8 hours [/home/ubuntu/dcaf_case_management/test/system/call_list_test.rb:86]:
Expected false to be truthy.

Failure:
NavbarLinksTest::additional resources link#test_0001_should display if env var is set [/home/ubuntu/dcaf_case_management/test/integration/navbar_links_test.rb:13]:
Expected false to be truthy.

Failure:
GoogleSSOTest::access top page#test_0001_can sign in with Google Auth Account [/home/ubuntu/dcaf_case_management/test/integration/google_sso_test.rb:15]:
Expected false to be truthy.

Failure:
UpdatePatientInfoTest::changing fulfillment information#test_0001_should alter the information [/home/ubuntu/dcaf_case_management/test/system/update_patient_info_test.rb:219]:
Expected false to be truthy.

Failure:
PasswordResetTest::password reset page function#test_0002_should send a password reset if email does exist [/home/ubuntu/dcaf_case_management/test/integration/password_reset_test.rb:48]:
"Devise.mailer.deliveries.count" didn't change by 1.
Expected: 2
  Actual: 1

Codecov Report

Merging #1309 into system_test_setup will decrease coverage by 1.76%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           system_test_setup    #1309      +/-   ##
=====================================================
- Coverage              91.15%   89.38%   -1.77%
=====================================================
  Files                     61       61
  Lines                   1356     1356
=====================================================
- Hits                    1236     1212      -24
- Misses                   120      144      +24

Impacted Files
Coverage Δ

app/models/concerns/user_searchable.rb
37.93% <0%> (-55.18%)
:arrow_down:

app/controllers/users_controller.rb
64.28% <0%> (-14.29%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0493a2...71afae5. Read the comment docs.

Green other than this test:
...............................5a13af68570bec34be379c1a,5a13af68570bec34be379c1e,5a13af68570bec34be379c16,5a13af68570bec34be379c12
.....    HTML screenshot: /tmp/circle-artifacts.V2QLcw0/screenshot_2017-11-21-04-45-43.806.html
    Image screenshot: /tmp/circle-artifacts.V2QLcw0/screenshot_2017-11-21-04-45-43.806.png
F

Failure:
GoogleSSOTest::access top page#test_0001_can sign in with Google Auth Account [/home/ubuntu/dcaf_case_management/test/integration/google_sso_test.rb:15]:
Expected false to be truthy.

This was a major thorn in our side when we were trying to do this the first time. I'm going to wing it for 15m and if it doesn't go well comment it out because this is a little ridiculous.

Commented it out. The issue seems to be some bizarre interaction between systemtest and the mock function -- it seems to work okay if it runs before systemtests, but if it doesn't it fails every time. Possible to end run around it by moving it to its own test node maybe?

Eat it, all testing everywhere. @lomky or @DarthHater or @Kevin-Wei for review please

Spinning out the issues and merging into the feature branch. Thank you very much @lomky !

Comments all spun up! Confirming that CI still passes and then merging.


Closing the debugging session

First things first: thank you for the impressive work! Quite an achievement.
I am integrating this tool in my workflow, and while starting everything with local-connect is great, I was wondering how I can close everything with one command. This would allow me to toggle the debugger on and off at the REPL when I need it.
Thank you!

Glad you find it useful @danielsz !
There isn't currently any command for working with the debugger like a component system, but should be pretty straight forward to add it.
Currently you can just close the window, and call (local-connect) any time you need it again.
There is already flow-storm.tracer/stop-trace-sender that will kill the trace sender thread and also flow-storm.debugger.ui.state-vars/stage on which you can call (.close stage).
I'll add a function to correctly shutdown the debugger and make sure  it doesn't leak anything.
Will use this issue to track it.

@danielsz The entire debugger (GUI part) uses mount to handle state now. I'm not a fan of mount but going sierra components now will require too many changes, maybe in the future I'll revisit it.
Anyway, if you start the debugger with flow-storm.api/local-connect calling flow-storm.api/stop will shutdown everything gracefully. Same applies for ClojureScript if you started with  flow-storm.api/remote-connect
Cheers!