Move serviceworker to workbox and fix SSE interference

Instead of statically hardcoding every frontend asset, this uses a type-based approach to cache all js,css and manifest.json requests.
This also fixes the issue that the service worker was interfering with EventSource because it was unconditionally handling all requests which this new implementation doesn't.
Fixes: https://github.com/go-gitea/gitea/issues/11092
Fixes: https://github.com/go-gitea/gitea/issues/7372

Confirmed that this solves issue with EventSource

Should we remove templates.JSRenderer? I think it'll be unused after this PR.

Should we remove templates.JSRenderer? I think it'll be unused after this PR and I don't see us rendering JS templates in the near future 😉.

In a separate PR, please.

@guillep2k are you sure? I think it's fine to remove here as it was only used for the serviceworker rendering and added in the original commit so I think it only makes sense to remove it now.

Removed it. @guillep2k hope it's okay for you 😉

One more feature added: Cache will now invalidate if AppVer (e.g. 1.13.0+dev-43-g8636e470d) changes. It keeps the version in localStorage for this purpose.
ui.USE_SERVICE_WORKER is still required for development as AppVer does not change between frontend rebuilds.

ping LG-TM

@silverwind please send backport to release/v1.12 :)

Backport done.
I'll follow up with another PR to this, there are some minor fixups to be done, but nothing crucial 😉

Please notice all js files may need to be cached by CDN.


havn: init at 0.1.11

Description of changes
Closes #314155

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

> nix build .#havn
> tree result/
 result
└──  bin
   └──  havn

Tested with:
> ./result/bin/havn  www.google.com
═════════════════════════════════════════
|__|  /\  \  / |\ | <IP_ADDRESS>:1-1000
|  | /--\  \/  | \| www.google.com
═════════════════════════════════════════
Other IPs: 2a00:1450:4002:416::2004
2 open, 998 closed, took 4.085s
PORT  DESCRIPTION
80    http
443   https

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/1016/129

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1685


GEOS and GDAL issues on heroku-18

Hey,
Today I've created new Heroku app and it was using heroku-18 My project is using geolibraries and they were detected during installation stage.
I've set BUILD_WITH_GEO_LIBRARIES: 1 and added
    GDAL_LIBRARY_PATH = os.environ.get('GDAL_LIBRARY_PATH')
    GEOS_LIBRARY_PATH = os.environ.get('GEOS_LIBRARY_PATH')

to my settings. But when I try to run migrate it fails with this traceback.
remote: Traceback (most recent call last):
remote:   File "manage.py", line 15, in <module>
remote:     execute_from_command_line(sys.argv)
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/core/management/__init__.py", line 381, in execute_from_command_line
remote:     utility.execute()
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/core/management/__init__.py", line 357, in execute
remote:     django.setup()
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/__init__.py", line 24, in setup
remote:     apps.populate(settings.INSTALLED_APPS)
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/apps/registry.py", line 112, in populate
remote:     app_config.import_models()
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/apps/config.py", line 198, in import_models
remote:     self.models_module = import_module(models_module_name)
remote:   File "/app/.heroku/python/lib/python3.6/importlib/__init__.py", line 126, in import_module
remote:     return _bootstrap._gcd_import(name[level:], package, level)
remote:   File "<frozen importlib._bootstrap>", line 994, in _gcd_import
remote:   File "<frozen importlib._bootstrap>", line 971, in _find_and_load
remote:   File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
remote:   File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
remote:   File "<frozen importlib._bootstrap_external>", line 678, in exec_module
remote:   File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
remote:   File "/app/core/models.py", line 3, in <module>
remote:     from django.contrib.gis.db.models import PointField
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/db/models/__init__.py", line 3, in <module>
remote:     import django.contrib.gis.db.models.functions  # NOQA
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/db/models/functions.py", line 4, in <module>
remote:     from django.contrib.gis.db.models.fields import BaseSpatialField, GeometryField
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/db/models/fields.py", line 3, in <module>
remote:     from django.contrib.gis import forms, gdal
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/forms/__init__.py", line 3, in <module>
remote:     from .fields import (  # NOQA
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/forms/fields.py", line 2, in <module>
remote:     from django.contrib.gis.geos import GEOSException, GEOSGeometry
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/geos/__init__.py", line 5, in <module>
remote:     from .collections import (  # NOQA
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/geos/collections.py", line 9, in <module>
remote:     from django.contrib.gis.geos.geometry import GEOSGeometry, LinearGeometryMixin
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/geos/geometry.py", line 8, in <module>
remote:     from django.contrib.gis import gdal
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/gdal/__init__.py", line 28, in <module>
remote:     from django.contrib.gis.gdal.datasource import DataSource
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/gdal/datasource.py", line 39, in <module>
remote:     from django.contrib.gis.gdal.driver import Driver
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/gdal/driver.py", line 5, in <module>
remote:     from django.contrib.gis.gdal.prototypes import ds as vcapi, raster as rcapi
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/gdal/prototypes/ds.py", line 9, in <module>
remote:     from django.contrib.gis.gdal.libgdal import GDAL_VERSION, lgdal
remote:   File "/app/.heroku/python/lib/python3.6/site-packages/django/contrib/gis/gdal/libgdal.py", line 47, in <module>
remote:     lgdal = CDLL(lib_path)
remote:   File "/app/.heroku/python/lib/python3.6/ctypes/__init__.py", line 348, in __init__
remote:     self._handle = _dlopen(self._name, mode)
remote: OSError: /app/.heroku/vendor/lib/libgdal.so: cannot open shared object file: No such file or directory

BTW - After I degraded to heroku-16 it works just fine.

Same here!

The problem is simple enough, no one has build the binaries yet and uploaded them:
$ http HEAD https://lang-python.s3.amazonaws.com/heroku-18/libraries/vendor/gdal.tar.gz
HTTP/1.1 404 Not Found
Content-Type: application/xml
Date: Thu, 20 Sep 2018 11:59:43 GMT
Server: AmazonS3
Transfer-Encoding: chunked
x-amz-id-2: D66hPf9UIzM65dpu4RvIb+51bA72B8YoogMev2jZ9ew8rWDe/1WEZLkRN0FabSFS/oWxr1XY9yE=
x-amz-request-id: 369714D17150467F

@CaseyFaist can you run bob the builder for all libraries on heroku-18 and deploy them to your bucket?

Hey @codingjoe & @pkrefta - sure thing! This got buried in my notifications, so thank you for your patience. I've got a couple releases slated for beginning of next week but I should be able to get these in prod on the same timeline 👍

Hey y'all! Thanks for your patience on this. Binaries are built and available now 👍closing issue.


Representable deprecation warnings

I'm getting tons of these:
[Representable] Mixing user and representable options is deprecated. Please provide your options via :user_options.
[Representable] Positional arguments for `:if` are deprecated. Please use options or keyword arguments.
  if: ->(options) { options[:user_options] } or
  if: ->(user_options:) {  }
  Learn more here: http://trailblazerb.org/gems/representable/upgrading-guide.html#positional-arguments

Here's my Gemfile.lock:
GEM
  remote: https://rubygems.org/
  specs:
    activesupport (4.2.6)
      i18n (~> 0.7)
      json (~> 1.7, >= 1.7.7)
      minitest (~> 5.1)
      thread_safe (~> 0.3, >= 0.3.4)
      tzinfo (~> 1.1)
    addressable (2.4.0)
    declarative (0.0.7)
      uber (>= 0.0.15)
    faraday (0.9.2)
      multipart-post (>= 1.2, < 3)
    google-api-client (0.9.pre3)
      activesupport (>= 3.2)
      addressable (~> 2.3)
      googleauth (~> 0.2)
      hurley (~> 0.1)
      memoist (~> 0.11)
      mime-types (>= 1.6)
      multi_json (~> 1.11)
      representable (~> 2.1)
      retriable (~> 2.0)
      thor (~> 0.19)
    googleauth (0.5.1)
      faraday (~> 0.9)
      jwt (~> 1.4)
      logging (~> 2.0)
      memoist (~> 0.12)
      multi_json (~> 1.11)
      os (~> 0.9)
      signet (~> 0.7)
    hurley (0.2)
    i18n (0.7.0)
    json (1.8.3)
    jwt (1.5.4)
    launchy (2.4.3)
      addressable (~> 2.3)
    little-plugger (1.1.4)
    logging (2.1.0)
      little-plugger (~> 1.1)
      multi_json (~> 1.10)
    memoist (0.14.0)
    mime-types (3.0)
      mime-types-data (~> 3.2015)
    mime-types-data (3.2016.0221)
    minitest (5.8.4)
    multi_json (1.11.3)
    multipart-post (2.0.0)
    os (0.9.6)
    representable (2.4.1)
      declarative (~> 0.0.5)
      uber (~> 0.0.15)
    retriable (2.1.0)
    signet (0.7.2)
      addressable (~> 2.3)
      faraday (~> 0.9)
      jwt (~> 1.5)
      multi_json (~> 1.10)
    thor (0.19.1)
    thread_safe (0.3.5)
    tzinfo (1.2.2)
      thread_safe (~> 0.1)
    uber (0.0.15)

PLATFORMS
  ruby

DEPENDENCIES
  google-api-client (= 0.9.pre3)
  googleauth
  launchy
  thor

BUNDLED WITH
   1.11.2

Will update in the 0.10 release.

I noticed this was closed, but would love to know the status update. Was a fix added to 0.10?  Any chance it made it into 0.9.14?

It'll be in 0.10. Mostly done with it, just finishing up some work with repackaging the generated APIs into separate gems and some other improvements to make it easier to keep the generated APIs up to date.
I don't have an ETA, but I hope to have it all wrapped up in the next couple of weeks if not sooner.


pytube.exceptions.VideoUnavailable on flagged but still accessible videos.

Using Pytube with a bunch of videos, i stumble accross a frustrating point where an error is raised because one of the videos I'm working with is flagged as inappropriate by Youtube users.
This one for instance :
https://www.youtube.com/watch?v=bDKSb76Tvds
is raising this error :  "pytube.exceptions.VideoUnavailable: This video is unavailable."
Before I find a way to escape this kind of vids, is there something I'm missing ? Is this behaviour from Pytube intentional or is it a bug/mishap ?
Thanks.
And thanks for this neat lib.

Is there a graceful way to handle this when pulling a whole playlist using download_all? Otherwise, we abandon the entire playlist when we could only skip the one video.

Then, How can I deal with this problem? Thank you in advance.


openfl.utils.Timer Stops Abruptly

Describe the bug
I started running openfl.utils.Timer which runs in a given interval - the output platform was cpp/macOS.
While the TimerEvent.TIMER ticks fine as long as the application is running AND macOS system is wake. Minimise the application, lock/sleep the macOS system. Return after a few minutes and wake the system.
We can see that the TimerEvent.TIMER ticks entire period when the system was locked, which was great; But the timer abruptly stops as soon as system waked or unlocked - Bug.
To Reproduce
Steps to reproduce the behavior:

Basic codes added here
Compiled for macOS output and test

Basic codes
this.txtOutput = new TextArea();
this.txtOutput.editable = false;
this.txtOutput.layoutData = new VerticalLayoutData(100, 100);
this.addChild(this.txtOutput);

var myTimer = new Timer(30000);
myTimer.addEventListener(TimerEvent.TIMER, this.keepAliveTimerHandler, false, 0, false);
myTimer.start();

private function keepAliveTimerHandler(event:TimerEvent):Void
{
        this.txtOutput.text += "["+ Date.now().toString() +"]keepAlive test\n";
}

Expected behavior
Timer should not stop abruptly and keep running.
OpenFL Targets
cpp/macOS
Additional context
Tested on:

macOS Ventura
Openfl 9.3.0-Dev
Lime 8.1.0-Dev

Thank you @joshtynjala for looking into this.
I see a change of behaviour after I updated the NDLL from the recent v8.1.0-Dev build.
Following is the timer-event ticks before system lock (shown in green) and after unlocking the system (in blue):

Unlike in past, I see timer-event no more fires when the system is locked. Previously, the events were firing when the system was locked.
Is this change intentional, or how it should be (?)

I see more trouble @joshtynjala . As soon the application minimised (tested on macOS Ventura), timer-event tick stops. This I think is unexpected. Timer is suppose to run when application minimised, as well.

Unlike in past, I see timer-event no more fires when the system is locked. Previously, the events were also firing when the system was locked.
Is this change intentional, or how it should be (?)

Yes, this is intentional (at least on the part of whomever wrote this code before me). Lime was behaving inconsistently when a particular event was dispatched from C++. This change makes Lime's behavior the same whenever this event is dispatched.
It seems to be when a window is hidden on macOS, which (interestingly) also seems to include minimizing the window. I observed that minimizing on Windows did not seem to have the same effect.

This I think is unexpected. openfl.utils.Timer is suppose to run when application minimised, as well.

Unfortunately, this may be tricky. Lime will likely need to dispatch a completely new event in one of these places to support consistency with AIR.

openfl/lime@aebf139dc7de2d29dfe7f96a2431ddde2a672943


pull request for e2e test at 01/14/2017 16:45:11

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add bitwise numeric limits to bit::Mask

A class that computes numeric max and minimums given bit count. Possible other useful information as well.
Expression:
return (1 << bit) - 1;

This is not necessary unless we find a use case.


Mspsds 514 record report originator

Pull Request Test Coverage Report for Build 680

0 of 0   changed or added relevant lines in 0 files are covered.
19 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 87.416%

Files with Coverage Reduction
New Missed Lines
%

../controllers/investigations_controller.rb
19
70.51%

Totals

Change from base Build 679:
-0.08%

Covered Lines:
1035

Relevant Lines:
1184

💛  - Coveralls


Difference between the code and the paper of NSM

I read the implementation of NSM in https://github.com/DevinJake/MRL-CQA/blob/master/S2SRL/train_scst_nsm.py. I find that the code is different from the original paper.
In the original paper, the decoder generates tokens using structures like Pointer Network with variable vocabulary provided by Computer module. In your code the decoding vocabulary is fixed. The decoder dose not query KB during the decoding process whereas in the original paper, the decoder executes a query once it is generated and saves results in memory.
It seems that your implementation is a hybrid with NS-CQA generative model structure and NSM training method.
I am not pretty sure. There might be some misunderstandings.
I wonder if the code is different from the NSM paper.

I read the implementation of NSM in https://github.com/DevinJake/MRL-CQA/blob/master/S2SRL/train_scst_nsm.py. I find that the code is different from the original paper.
In the original paper, the decoder generates tokens using structures like Pointer Network with variable vocabulary provided by Computer module. In your code the decoding vocabulary is fixed. The decoder dose not query KB during the decoding process whereas in the original paper, the decoder executes a query once it is generated and saves results in memory.
It seems that your implementation is a hybrid with NS-CQA generative model structure and NSM training method.
I am not pretty sure. There might be some misunderstandings.
I wonder if the code is different from the NSM paper.

Hi, Leext:
You have made a very clear understanding of what we have done in the re-implementation of NSM.
In the EMNLP paper, we said:
'As the code of NSM (Liang et al., 2017) has not been made available, we re-implemented it and incorporated our programmer to predict programs, and employed the reinforcement learning settings in NSM to optimize the programmer.'
Since the length of the paper is limited, we could not explain it thoroughly.
Actually, in our another paper, we have explained it as:
Since the primitive actions are designed in a different way, '...unlike NSM, we do not refer to the intermediate variables when generating the tokens of a trial. Therefore it is unnecessary to incorporate the key-variable memory, which is used to maintain and refer to intermediate program variables in our work. We thus removed the key-variable memory component in the seq2seq model in our reimplementation of NSM.'
Yes, as you mentioned, our code is different from the NSM paper.
Cheers!


[T4A6][W11-B2]Lui Rong Hua

Ready for Review

Reviewed during the tutorial.

@Roahhh pls close PR


How to apply log scale to stacked area chart

Hi,
If there is a large difference between data point then graph drawn is not looking good.
Sample : Plunker
In above plunker one value in "north America" is set to 500, due to which other data points are not marked nicely.
How to use d3.scale.log() in angularjs-nvd3 directive to draw graph nicely?

Use yScale option. Note that we should also ensure that y domain is >0. So use yDomain option to specify it.
{
  yScale: d3.scale.log(),
  yDomain:[1,1000]
}

Thanks @krispo for pointing out yDomain, I did tried yScale but was getting the error about yDomain missing. It works :+1:

Why doesn't this work for 'multiBarChart'?
Eg. Plunker


attaching auth headers

i need to attach auth headers to the requetsts. Currently i'm using
  getSaveHeaders() {     return {       Authorization: localStorage.token,     };   }
That seems to work but not for DELETE requests. is there any way of adding them without overwriting the delete method?

I found out that using getDefaultHeaders() they also work for delete. May I suggest adding a small paragraph about that to the docs at https://vuemc.io/ ?


Why not include third-party headers in build?

for example mfxvideo.h in qsv.h.

Not sure what you're asking. QSV support is enabled, it's just called onevpl/libvpl now.

Why would they be included? You don't need them to use ffmpeg, and you can't do anything useful with them, since even in the shared builds, the symbols are hidden from the libraries to avoid clashes.

what if I need to include qsv.h?

Sorry, that link should be this one https://github.com/BtbN/FFmpeg-Builds/releases/download/latest/ffmpeg-n7.1-latest-win64-gpl-shared-7.1.zip
Let me think a little bit more, thanks.

You cannot make use of any of the libvpl functions externally, or any other libraries. They are statically linked and not externally visible.
So the header would be useless.
If you want to write a program that directly interacts with both libvpl and ffmpeg, or any other external library really, static builds are not useful for that in general.

Here is a ffmpeg official example , it uses libavcodec/qsv.h mfx/mfxvideo.h and av_qsv_alloc_context(exported from avcodec.dll). If I want to build this example, should I download mfxvideo.h myself?

And is there any way to get all of FFmpeg's dependent headers ( mfx/mfxvidoe.h, vdpau/vdpau.h ... )?

( mfx/mfxvidoe.h, vdpau/vdpau.h ... )?

You need "libmfx-dev" and "libvdpau-dev". You can search the filename on https://pkgs.org/ to see which packages contain those header files.

@pzhlkj6612 I need all of FFmpeg's dependent headers.

Again, even if you had those headers, it wouldn't help you. The ffmpeg libraries do not re-export the libvpl/libva/... symbols, so any attempt to use them would fail at link-time.
And trying to combine an external library with the one statically linked into the libav* libraries would likely also fail, for incompatible ABI reasons.
If you want to interact with ffmpeg at that level, static builds are simply not the right thing to use.


[BUG] Nightly Test: Salvage related tests failed

Describe the bug
The following tests should be modified after the implementation of #1719 .
test_salvage_auto_crash_all_replicas
test_salvage_auto_crash_replicas_short_wait
test_salvage_auto_crash_replicas_long_wait
The remount handling method is changed, the function wait_pod_for_auto_salvage in the integration test should be updated, too.
Expected behavior
The tests should get passed.
Log
Found this log after all replica crash:
[longhorn-manager-55wpp] time="2020-10-29T12:05:27Z" level=info msg="Event(v1.ObjectReference{Kind:\"Volume\", Namespace:\"longhorn-system\", Name:\"longhorn-testvol-bwuqqb\", UID:\"eff46b3b-66dc-4344-acbc-c0989ea50459\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"4853087\", FieldPath:\"\"}): type: 'Warning' reason: 'AutoSalvaged' Replica longhorn-testvol-bwuqqb-r-4cb7f47b of volume longhorn-testvol-bwuqqb will be automatically salvaged"
[longhorn-manager-55wpp] time="2020-10-29T12:05:27Z" level=info msg="Event(v1.ObjectReference{Kind:\"Volume\", Namespace:\"longhorn-system\", Name:\"longhorn-testvol-bwuqqb\", UID:\"eff46b3b-66dc-4344-acbc-c0989ea50459\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"4853087\", FieldPath:\"\"}): type: 'Normal' reason: 'Remount' Volume longhorn-testvol-bwuqqb requested remount at 2020-10-29T12:05:27Z"

But the logs in handlePodDeletionIfVolumeRequestRemount() is not found
kc.logger.Infof("Deleted pod %v so that Kubernetes will handle remounting volume %v", pod.GetName(), vol.GetName())

Environment:

Longhorn version: master
Kubernetes version: v1.18
Node OS type and version: Ubuntu 18.04

Additional context
Add any other context about the problem here.

This could be a duplicate of https://github.com/longhorn/longhorn/issues/1914

Duplicate of #1914.


Duplicates come back after sourcing init.vim

If I make a change inside my init.vim file as soon as source the file after making a change the duplicates come back.
This only happens after sourcing my file, do you know what would be causing this?
I'm on OSX 10.14 and NeoVim 0.3.4

I don't think it is a good idea to re-sourcing a complicated complication. Ncm2 is not designed with hot-reload in mind.
Closing...

I didn't know about hot-reload, thanks for the info i'll look into that.


[wip] refactor: look at delegate next slot logic

Summary
https://app.clickup.com/t/86dt8dej3
todo:

[ ] test delegate monitor
[ ] see if the negative times for the next forger is due to local setup being slow to receive blocks from the network
[ ] ~look into forging_stats setup in the tests. the table shouldn't be created on the core/node mock database~ - https://app.clickup.com/t/86dtfk0x5

Checklist

[ ] I checked my UI changes against the design and there are no notable differences
[ ] I checked my UI changes for any responsiveness issues
[ ] I checked my UI changes in light AND dark mode
[ ] I checked my (code) changes for obvious issues, debug statements and commented code
[ ] I opened a corresponding card on Clickup for any remaining TODOs in my code
[ ] I added a short description on how to test this PR (if necessary)
[ ] Documentation (if necessary)
[ ] Tests (if necessary)
[ ] Ready to be merged

Closing in favour of https://github.com/ArdentHQ/arkscan/pull/891


Create template and process of working with project board to enable more automation

We may change the way we enter data in the Training & Automation Project Board through automation

[ ] Want to create GitHub action that creates weekly meeting issue for Mondays and Fridays. And moves Agenda across. Looks at Project Board status - Andre

[ ] GitHub Action - https://github.com/treasuryguild/Treasury-Advisory-Service/blob/main/.github/workflows/meetingIssue.yml
[ ] GitHub Action - https://github.com/treasuryguild/Treasury-Advisory-Service/blob/main/.github/workflows/add-to-project-beta.yml


Changed expected datatype of request_timeout_ms option to number

Hello, sorry for the delay, I got a newborn since then.
Thank you for your comments, I will look at them and do necessary changes very soon. I have to go through my PRs first ;-).


Show trajectory („Verlaufskurve“) of statistics

Current Implementation
The app shows the statistics only with the latests values available and with an trend indicator (arrows).
Suggested Enhancement
Add the trajectory to the statistics. Users are then able to see whether, e.g. in the past two weeks (the period of time should be selectable by the user), more or less people came into ICU.
Expected Benefits
The user is better informed and sees whether the situation is getting better (lower incidence than in the past 2 weeks, less people are coming into ICU, more people are getting vaccinated, etc.) or worse (incidences on the rise, more people in ICU, less vaccination than in the last weeks, etc.).

Internal Tracking ID: EXPOSUREAPP-11243

@Ein-Tim
Although the following is not about the exact statistic you are requesting a trend in, you can find something similar on:

Corona-Warn-App (CWA): Kennzahlen (in the list of links at the bottom of the page: RKI: Covid-19-Trends (DE)) =>
RKI: Covid-19-Trends in Deutschland im Überblick =>
Krankheitsschwere

This is selectable by 1, 2 or 3 months or complete timeframe.

Thanks for your suggestion @Ein-Tim. Internal Tracking ID: EXPOSUREAPP-11243

Corona-Warn-App Open Source Team

As the CWA project went into ramp-down mode, I don't expect this feature to be implemented. I'm therefore closing this issue.


Only send staked balances for TLOS

Description
We currently send the stake & liquid balances back for every token in the holders route.
We need to make Rex/staked/liquid optional for holders response and don’t send it for tokens that aren’t TLOS and don’t have them.  Also don’t return liquid in that case, just total
Tasks

[x] Do not return liquid_balance, resource_stake & rex_stake for tokens other than TLOS

I had some problem with this, messing around with oneOf and multiple schemas.. But turns out it was rather simple, all you needed was to declare the field an optional type in the response schema...


check the main field in the transform comparison

Previously, the file check in the browserify transform failed, resulting in large bundle sizes:
$ browserify -r regl | wc -c
272977

With this patch, the file sizes are back down to expected levels:
$ browserify -r regl | wc -c
75258

and with --debug you get the debugging symbols:
$ browserify --debug -r regl | wc -c
713677
$ browserify --debug -r regl | grep assert | wc -l
38
~ $ browserify -r regl | grep assert | wc -l
0

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Make smallbank workload re-runnable

Before the number of accounts were generated with
client ids in order from 0 to number account requested.
This made it impossible to rerun the workload against
the same network with out having at least the number
of accounts invalid transactions. Instead, the client
id are now randomly generated.
If a seed is provided, the output will be generated the
same way, causing invalid transactions. To be rerun
without the invalid transactions, run again with a
different or no seed to create new accounts.

Should the workload fail if an account already exists, or should it just add the account to the list of accounts and continue?

The workload generator does not wait to find out if the transaction was valid only that it was accepted. It should add the account to the account list if it already exists (the only reason it would be invalid at this time) because the other operations should be valid after account creation is finished.


🔍feat: added fullscreen support for high risk map

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] i18n translation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ..., provide screenshots if necessary)

Added fullscreen support for high risk map

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information:

have concerns about adding another library...
is it possible to do it with raw JS?

Yes, it could be done in vanilla JavaScript. But it's irritating since some browsers require the use of vendor prefix, like webkitRequestFullscreen and msRequestFullscreen.

ok no problem
I am trying to avoid the growing bundle size ;)


Double or Float values

Please consider enabling double or float values for the line. Or maybe I just didn't find the option to enable?

Merged thanks!


Create desktop error

from pyvda import VirtualDesktop
VirtualDesktop.create()

It's back error
Traceback (most recent call last):
  File "C:\Users\marko\Desktop\xx.py", line 2, in <module>
    VirtualDesktop.create()
  File "C:\Users\marko\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\pyvda\pyvda.py", line 305, in create
    desktop = managers.manager_internal.create_desktop() # type: ignore
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\marko\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\pyvda\com_defns.py", line 320, in create_desktop
    return self.CreateDesktopW() # type: ignore
           ^^^^^^^^^^^^^^^^^^^^^
OSError: exception: access violation reading 0x0000000000000000

Windows 11 Pro
Ver: 24H2
Build: 26100.2454
Python 3.12.7

Thanks for reporting this. I don't have a machine to test on but could you try version 0.5.0 and see if this solves the problem?

Thanks for reporting this. I don't have a machine to test on but could you try version 0.5.0 and see if this solves the problem?

Thank you, it's working now, just a question: I have found some fork of pyvda where it is possible to call VirtualDesktop(2).go(animation=True) and switch desktop with animation, maybe you can also include this?


Fix spacing on contact circles.

Save me from having to look at this all the time please.

Phenomenal pull request. @Dtphelan1 raises the bar once again.

To clarify what this actually does, it helps center the contact icons on synthea.github.io.
Before:
Large Screen

Small Screen

After:
Large Screen

Small Screen


Just a question: How to programmatically change the zoom?

update to the new version 1.0.3 and look at the example4:
https://github.com/dariocavada/panorama_viewer/blob/main/example/lib/screens/example_screen_4.dart

thank you for all your work.  It's great that you updated panorama.


Added setup.py

Added the setup.py file for the snake game.
You can change the name inside the setup function as it has to be unique when we publish it on PyPi.
Also added an __init__.py file inside the snake folder.

Well done, thank you for contributing!


[Bug]:  lyrics dont show and song that had them on fullscreen dont have them anymore

🔍 Have you checked that you are using an auto updating method or latest version of the extension?

[X] I have checked that I am on the latest version.

🔍 Is there already an issue for your problem?

[X] I have checked older issues, open and closed

Choose the extension for bug report.
Full Screen Mode
ℹ Environment / Computer Info
0.9.4

📝 Description
song that had lyrics on fullscreen dont have them anymore pls help
📸 Screenshots

I know it's an issue with lyrics-plus extension not working in spotify 1.2.31, check https://github.com/spicetify/spicetify-cli/issues/2844 for any updates.

hiya, v2.32.0 should fix this issue ^^


intermittent test failures with Node 20.x (restore)

Please read these guidelines before opening an issue.

Bug Description
On Node 20.x there are intermittent test failures and subsequent hang of the test suite.
Note Node 20.x is not supported for production as it is not (yet) an LTS version (see also #582).
1. Steps to reproduce and the simplest code sample possible to demonstrate the issue
Run the test suite on Node 20.x
2. What you expected to happen
Tests to pass.
3. What actually happened
Intermittent failures observed in these tests:

should backup and restore largedb1g #slow – test.End to end backup and restore using CLI
should backup and restore largedb2g via a compressed file #slower – test.Compression tests using CLI
should backup and restore largedb10g #slowest - End to end backup and restore using CLI

In all cases:
The restore should exit normally, got exit code 1

-1
+0

    at ChildProcess.<anonymous> (test/citestutils.js:361:18)
    at ChildProcess.emit (node:events:511:28)
    at maybeClose (node:internal/child_process:1098:16)
    at ChildProcess._handle.onexit (node:internal/child_process:304:5)

In one case there was an additional logged ERR_SOCKET_CONNECTION_TIMEOUT
ERROR: Socket connection timeout: post https://test.example/couchbackup_test_ea06e8fd-4b36-4038-a2b9-0287ccb8ede2/_bulk_docs ERR_SOCKET_CONNECTION_TIMEOUT
Test stream error code EPIPE

It is unclear if this is a code or test problem at present, but appears to be Node 20.x only.
Environment details

Version(s) that are affected by this issue.

2.9.8 and 2.9.9 (confirmed, but probably other versions as well)

Node.js version

20.x (see note above about supported versions)

Part of completing this should be reverting a50ba7547bea142787618a3409cd1f21db00a608 which temporarily disabled running tests on version 20.

I ran the tests on Node 20 (see 583-reenable-node20-tests) with the changes from the test modernization work in #634 and it was green. So I think we can probably add them back into the matrix now.


Add rubric to code review guidelines

We need some better integration with the other parts of this chapter. Any ideas about how to that?

I guess the question is now what the relationship is between the rubric and the rest of the checks. Does the rubric replace the rest? It's simpler and probably more practical, but perhaps it loses some information. Do we care about that?

Does our Guide have a license? CC-BY 4.0? Having material inside it that is under another license would be cumbersome, especially if that other license is more restrictive, as CC-BY-NC is.


Add configuration for timeout on Send calls

Closed in https://github.com/MindscapeHQ/raygun4java/pull/68


wasm: support precompiled modules in V8-based runtime.

Signed-off-by: Piotr Sikora<EMAIL_ADDRESS>

LGTM. Can you fix format?
/wait

OSX CI failure looks legit.
/wait

OSX CI failure looks legit.

Fixed.


the gem does not work for Rails 6+ when the email option is enabled

Error during failsafe response: undefined method parent_name' for gchitt::Application:Class   /usr/share/rvm/gems/ruby-3.0.0/gems/railties-6.1.3/lib/rails/railtie.rb:209:in method_missing'
/usr/share/rvm/gems/ruby-3.0.0/gems/exception_handler-<IP_ADDRESS>/app/views/exception_handler/mailers/new_exception.erb:1:in __usr_share_rvm_gems_ruby_______gems_exception_handler_________app_views_exception_handler_mailers_new_exception_erb__3687581017939819404_68000'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/base.rb:247:in public_send'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/base.rb:247:in _run'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/template.rb:154:in block in render'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications.rb:205:in instrument'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/template.rb:345:in instrument_render_template'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/template.rb:152:in render'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/renderer/template_renderer.rb:61:in block (2 levels) in render_template'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications.rb:203:in block in instrument'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications/instrumenter.rb:24:in instrument'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications.rb:203:in instrument'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/renderer/template_renderer.rb:56:in block in render_template'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/renderer/template_renderer.rb:71:in block in render_with_layout'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications.rb:203:in block in instrument'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications/instrumenter.rb:24:in instrument'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications.rb:203:in instrument'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/renderer/template_renderer.rb:70:in render_with_layout'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/renderer/template_renderer.rb:55:in render_template'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/renderer/template_renderer.rb:11:in render'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/renderer/renderer.rb:61:in render_template_to_object'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/renderer/renderer.rb:29:in render_to_object'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/rendering.rb:117:in block in _render_template'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/base.rb:273:in in_rendering_context'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/rendering.rb:116:in _render_template'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/rendering.rb:103:in render_to_body'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/abstract_controller/rendering.rb:25:in render'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/base.rb:958:in block in collect_responses_from_templates'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/base.rb:955:in each'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/base.rb:955:in each'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/base.rb:955:in map'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/base.rb:955:in collect_responses_from_templates'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/base.rb:933:in collect_responses'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/base.rb:841:in mail'   /usr/share/rvm/gems/ruby-3.0.0/gems/exception_handler-<IP_ADDRESS>/app/mailers/exception_handler/exception_mailer.rb:13:in new_exception'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/abstract_controller/base.rb:228:in process_action'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/abstract_controller/callbacks.rb:42:in block in process_action'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:117:in block in run_callbacks'   /usr/share/rvm/gems/ruby-3.0.0/gems/actiontext-6.1.3/lib/action_text/rendering.rb:20:in with_renderer'
/usr/share/rvm/gems/ruby-3.0.0/gems/actiontext-6.1.3/lib/action_text/engine.rb:55:in block (4 levels) in <class:Engine>'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:126:in instance_exec'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:126:in block in run_callbacks'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:137:in run_callbacks'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/abstract_controller/callbacks.rb:41:in process_action'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/abstract_controller/base.rb:165:in process'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/rescuable.rb:25:in block in process'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/rescuable.rb:17:in handle_exceptions'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/rescuable.rb:24:in process'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/rendering.rb:39:in process'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/base.rb:615:in block in process'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications.rb:203:in block in instrument'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications/instrumenter.rb:24:in instrument'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications.rb:203:in instrument'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/base.rb:614:in process'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/message_delivery.rb:128:in block in processed_mailer'
internal:kernel:90:in tap'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/message_delivery.rb:127:in processed_mailer'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionmailer-6.1.3/lib/action_mailer/message_delivery.rb:30:in __getobj__'   /usr/share/rvm/rubies/ruby-3.0.0/lib/ruby/3.0.0/delegate.rb:84:in method_missing'
/usr/share/rvm/gems/ruby-3.0.0/gems/exception_handler-<IP_ADDRESS>/app/models/exception_handler/exception.rb:93:in block (2 levels) in <module:ExceptionHandler>'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:427:in instance_exec'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:427:in block in make_lambda'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:235:in block in halting_and_conditional'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:516:in block in invoke_after'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:516:in each'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:516:in invoke_after'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:107:in run_callbacks'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:824:in _run_initialize_callbacks'   /usr/share/rvm/gems/ruby-3.0.0/gems/activerecord-6.1.3/lib/active_record/core.rb:499:in initialize'
/usr/share/rvm/gems/ruby-3.0.0/gems/exception_handler-<IP_ADDRESS>/app/models/exception_handler/exception.rb:27:in initialize'   /usr/share/rvm/gems/ruby-3.0.0/gems/activerecord-6.1.3/lib/active_record/inheritance.rb:72:in new'
/usr/share/rvm/gems/ruby-3.0.0/gems/activerecord-6.1.3/lib/active_record/inheritance.rb:72:in new'   /usr/share/rvm/gems/ruby-3.0.0/gems/exception_handler-<IP_ADDRESS>/app/controllers/exception_handler/exceptions_controller.rb:20:in block in class:ExceptionsController'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:427:in instance_exec'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:427:in block in make_lambda'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:198:in block (2 levels) in halting'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/abstract_controller/callbacks.rb:34:in block (2 levels) in module:Callbacks'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:199:in block in halting'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:512:in block in invoke_before'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:512:in each'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:512:in invoke_before'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:115:in block in run_callbacks'   /usr/share/rvm/gems/ruby-3.0.0/gems/actiontext-6.1.3/lib/action_text/rendering.rb:20:in with_renderer'
/usr/share/rvm/gems/ruby-3.0.0/gems/actiontext-6.1.3/lib/action_text/engine.rb:55:in block (4 levels) in <class:Engine>'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:126:in instance_exec'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:126:in block in run_callbacks'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/callbacks.rb:137:in run_callbacks'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/abstract_controller/callbacks.rb:41:in process_action'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_controller/metal/rescue.rb:22:in process_action'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_controller/metal/instrumentation.rb:34:in block in process_action'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications.rb:203:in block in instrument'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications/instrumenter.rb:24:in instrument'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/notifications.rb:203:in instrument'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_controller/metal/instrumentation.rb:33:in process_action'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_controller/metal/params_wrapper.rb:249:in process_action'
/usr/share/rvm/gems/ruby-3.0.0/gems/activerecord-6.1.3/lib/active_record/railties/controller_runtime.rb:27:in process_action'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/abstract_controller/base.rb:165:in process'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionview-6.1.3/lib/action_view/rendering.rb:39:in process'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_controller/metal.rb:190:in dispatch'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_controller/metal.rb:238:in block in action'   /usr/share/rvm/gems/ruby-3.0.0/gems/exception_handler-<IP_ADDRESS>/lib/exception_handler/engine.rb:54:in block (2 levels) in class:Engine'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_dispatch/middleware/show_exceptions.rb:52:in render_exception'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_dispatch/middleware/show_exceptions.rb:36:in rescue in call'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_dispatch/middleware/show_exceptions.rb:31:in call'   /usr/share/rvm/gems/ruby-3.0.0/gems/railties-6.1.3/lib/rails/rack/logger.rb:37:in call_app'
/usr/share/rvm/gems/ruby-3.0.0/gems/railties-6.1.3/lib/rails/rack/logger.rb:26:in block in call'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/tagged_logging.rb:99:in block in tagged'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/tagged_logging.rb:37:in tagged'   /usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/tagged_logging.rb:99:in tagged'
/usr/share/rvm/gems/ruby-3.0.0/gems/railties-6.1.3/lib/rails/rack/logger.rb:26:in call'   /usr/share/rvm/gems/ruby-3.0.0/gems/sprockets-rails-3.2.2/lib/sprockets/rails/quiet_assets.rb:13:in call'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_dispatch/middleware/remote_ip.rb:81:in call'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_dispatch/middleware/request_id.rb:26:in call'
/usr/share/rvm/gems/ruby-3.0.0/gems/rack-2.2.3/lib/rack/method_override.rb:24:in call'   /usr/share/rvm/gems/ruby-3.0.0/gems/rack-2.2.3/lib/rack/runtime.rb:22:in call'
/usr/share/rvm/gems/ruby-3.0.0/gems/activesupport-6.1.3/lib/active_support/cache/strategy/local_cache_middleware.rb:29:in call'   /usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_dispatch/middleware/executor.rb:14:in call'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_dispatch/middleware/static.rb:24:in call'   /usr/share/rvm/gems/ruby-3.0.0/gems/rack-2.2.3/lib/rack/sendfile.rb:110:in call'
/usr/share/rvm/gems/ruby-3.0.0/gems/actionpack-6.1.3/lib/action_dispatch/middleware/host_authorization.rb:98:in call'   /usr/share/rvm/gems/ruby-3.0.0/gems/rack-mini-profiler-2.3.1/lib/mini_profiler/profiler.rb:373:in call'
/usr/share/rvm/gems/ruby-3.0.0/gems/webpacker-5.2.1/lib/webpacker/dev_server_proxy.rb:25:in perform_request'   /usr/share/rvm/gems/ruby-3.0.0/gems/rack-proxy-0.6.5/lib/rack/proxy.rb:57:in call'
/usr/share/rvm/gems/ruby-3.0.0/gems/railties-6.1.3/lib/rails/engine.rb:539:in call'   /usr/share/rvm/gems/ruby-3.0.0/gems/puma-5.2.1/lib/puma/configuration.rb:247:in call'
/usr/share/rvm/gems/ruby-3.0.0/gems/puma-5.2.1/lib/puma/request.rb:76:in block in handle_request'   /usr/share/rvm/gems/ruby-3.0.0/gems/puma-5.2.1/lib/puma/thread_pool.rb:337:in with_force_shutdown'
/usr/share/rvm/gems/ruby-3.0.0/gems/puma-5.2.1/lib/puma/request.rb:75:in handle_request'   /usr/share/rvm/gems/ruby-3.0.0/gems/puma-5.2.1/lib/puma/server.rb:431:in process_client'
/usr/share/rvm/gems/ruby-3.0.0/gems/puma-5.2.1/lib/puma/thread_pool.rb:145:in `block in spawn_thread'

if I set the
exception_handler.email: nil
then no issues, the error webpage shows up as expected.  But when it is changed to a valid email address like
exception_handler.email<EMAIL_ADDRESS>it fails altogether with the above exception stack.
This issue appears like the already reported and resolved here

FYI. the issue is with the use of Rails.application.class.parent_name class. Starting Rails 6 its now Rails.application.class.module_parent_name

Was this not fixed with the recent push? I will check again if not

On 25/05/2021 21:28 drkaleem<EMAIL_ADDRESS>wrote:

FYI. the issue is with the use of Rails.application.class.parent_name class. Starting Rails 6 its now Rails.application.class.module_parent_name

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/richpeck/exception_handler/issues/103#issuecomment-848237004 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINUL4GMSKZK4YINR762CLTPQB5LANCNFSM45L5DK4A .

yes the recent push <IP_ADDRESS> did resolve it partially.
as mentioned above, the gem works with rails 6 + using fix in <IP_ADDRESS>. However the same gem fails with email option enabled.
Thanks @richpeck  for looking into it

Any luck  @.***> @richpeck/exception_handler on this bug. Thanks for your help.
From: Richard Peck @.>
Sent: Tuesday, May 25, 2021 4:30 PM
To: richpeck/exception_handler @.>
Cc: drkaleem @.>; Author @.>
Subject: Re: [richpeck/exception_handler] the gem does not work for Rails 6+ when the email option is enabled (#103)
Was this not fixed with the recent push? I will check again if not

On 25/05/2021 21:28 drkaleem @.***<EMAIL_ADDRESS>> wrote:
FYI. the issue is with the use of Rails.application.class.parent_name class. Starting Rails 6 its now Rails.application.class.module_parent_name
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/richpeck/exception_handler/issues/103#issuecomment-848237004 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAINUL4GMSKZK4YINR762CLTPQB5LANCNFSM45L5DK4A .

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/richpeck/exception_handler/issues/103#issuecomment-848238212 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAHHBZUM7ZDD77C7SMLFVDTPQCE5ANCNFSM45L5DK4A .  https://github.com/notifications/beacon/ABAHHB3LV3NFELQBE5OUBADTPQCE5A5CNFSM45L5DK4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGKHRNBA.gif

Looking at it now, apologies for the late reply, been extremely busy.

This should have been fixed with <IP_ADDRESS>

Thank you it is now working well with <IP_ADDRESS>.


[JOSS review] Methods to assist common tasks (especially plotting)

The notebooks of the tutorial show how spaghetti can be used to assist a variety of spatial analysis tasks related to spatial networks. Nevertheless, to that end, the notebooks require a substantial amount of ad-hoc code, especially when it comes to plotting tasks. A key example concerns the simplest network visualization task, which seemingly requires using the spaghetti.element_as_gdf method to obtain geo-data frames for the vertices and arcs and then using the corresponding geopandas plotting methods. Wouldn't it be possible to create method(s) (maybe in the utils.py or as a separate, e.g., plotting.py module) to automatize these common tasks and offer a nicer API to the users so that they do not need to write too much repetitive and ad-hoc code? Such a method could include arguments to automatically add labels and legends for the nodes and arcs, and to assist further customization for the plots. I am thinking about something like the plot_graph method of OSMnx or more broadly its plot module.
After browsing the tutorial notebooks, the case for a plotting method(s) appears very relevant, yet the same remark might apply to further recurrent tasks (other than plotting) for which spaghetti has been design to assist.
https://github.com/openjournals/joss-reviews/issues/2826

Partially addressed in #595.

Partially addressed in #595.

Thank you for this remark, we have started to address this by adding a Network_Moran method (see the Network-constrained spatial autocorrelation notebook) into the code base as this is a much appreciated idea and we will be implementing that for this review. See Issue #586. Additionally, it is a good point that there is a fair amount of adhoc code, especially for plotting, in the tutorials. To stay in line with the federated ecosystem structure in the PySAL ecosystem, we plan on making general plotting functionality part of pysal/splot in the future. See issue https://github.com/pysal/splot/issues/108. Additionally, the code for optimization problems will become part of the pysal/spopt package following its initial release.


Update to make sure code is displayed properly

@dend,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Spurious lost events warnings

After the changes in #2475, I'm seeing a lot of spurious lost event warnings.
We should sort this out before pushing the next release.
What reproduces the bug?
# bpftrace -e 'kretprobe:vfs_read { printf("func: '%s'\n", func); exit(); }'
Attaching 1 probe...
func: vfs_read
Lost 4595 events

@ajor could you please show me the output of bpftrace --info?

This bug only seems to appear on high frequency probes. I've seen it with both the func and the kstack builtins, probably because these require symbolication and so are slow to execute in user space.
I was able to reproduce it with another probe (although less reliably):
$ sudo ./build/src/bpftrace -e 'kprobe:cpuidle_enter_state { @c = count(); printf("func: '%s'\n", func); exit(); }'
Attaching 1 probe...
func: cpuidle_enter_state
Lost 42 events

@c: 6574

I also found another more serious bug - duplicate prints:
$ sudo ./build/src/bpftrace -e 'kprobe:cpuidle_enter_state { @c = count(); printf("func: '%s'\n", func); exit(); }'
Attaching 1 probe...
func: cpuidle_enter_state
func: cpuidle_enter_state

@c: 2384

I'd guess that either the first exit event is being lost (although there are no lost events warnings) or the events are arriving out of order.
Full logs at: https://pastebin.com/raw/AYZMpk8e. The lost events bug appears once and the duplicate prints twice in this run of 30 bpftrace sessions.
For comparison, I reverted commit 67d4bd7c79839ca9563a6be155f0413da519f482 and saw these bugs 0 times over 100+ runs.
My bpftrace info: https://pastebin.com/raw/g4XnR1a6

While still investigating this issue, I'd like to share some bare thoughts first. Please correct me if anything is incorrect.
Calling exit() in BPF programs doesn't necessarily exit the BPF programs right away. If we add a debugf() before the exit(), we will see only one line log from the standard output, but many lines of debug output from the trace pipe. It proves that there is a slight delay between calling exit() and the BPF program's complete stop.
The PR #2475 uses a event_loss_counter to record bpf_ringbuf_output() failure in the kernel space. As long as the BPF program keeps running, this counter keeps being updated. I'd guess these losses came from bpftrace's teardown process.
This differs from the old perf_event's event loss handling logic. perf_event does not have a counter in the kernel space, but a perf_event callback mechanism. We may just haven't observed the losses on the BPF side yet. Besides, for perf_event, once exit() is received by the userspace, bpftrace will short-circuit the event handling, making event losses caused by perf_event processing less likely to happen.
I'm not sure if these make sense, next, I will try to add a loss counter to perf_event to prove it.

IIUC, the duplicated prints happen because the BPF program is executing parallelly on all CPU cores. There're chances two printf()s are inserted into the ring buffer before any exit() is inserted. Since the ring buffer only has one shared buffer for all CPU cores, the event order is guaranteed. Then when bpftrace consumes the events, the first two printf()s are printed out first.
The reason we do not notice this on perf_event: perf_event buffers are not shared, bpftrace processes events for each CPU on a one-by-one basis

It seems that the above two issues are caused by the inconsistency in the current implementation of ringbuf and perf_event, rather than being bugs per se. I'm wondering if it is a good idea to write a documentation to inform bpftrace users about these differences. How you do think? @ajor @viktormalik @danobi

Yeah I concur. I suspect it's b/c there's a single ringbuf and it keeps going even after the async exit is sent by the prog. And for perf events, we only process a single perfrb at a time (given ncpu perfrbs). So there is some natural undercounting by perfrb. And some natural overcounting by ringbuf.
We might be able to codegen a barrier shared between all the cpus for ringbuf so that progs stop sending events to the ringbuf after exit has been sent, but I also suspect that would have bad cache effects and cause perf issues.

I'm not sure what the documentation would look like to be honest. Maybe we could have generic docs about how relying on async events may not be a good idea if you want full fidelity. Helpers like count() may be a better option for those cases.


Cryptarithmetic Problem

Title: Cryptarithmetic Problem
About: The aim is to solve the Cryptarithmetic Problem: SEND MORE MONEY.
Name: Manasi Chhibber
Label: Feature Request
Assignee: 'Manasi2001'

Define You:

[x] DevIncept Participant
[x] Contributor

Is your feature request related to a problem? Please describe.
The motive is to solve a cryptarithmetic problem. Cryptarithmetic problems are mathematical puzzles where digits are replaced by symbols. And the aim is to find unique digits(0-9) that the letters should represent, such that they satisfy the given constraints.
Describe the solution you'd like...
Use backtracking to solve the issue.

Issue asssigned. @Manasi2001


Question: When the firmware kernel is not available, how to arbitrate.

In most cases when the firmware kernel is not available,  how to extract the init processes information to improve firmadyne.

To clarify, we did not extract the init program from the kernel, but extract the path of the init program.
In our paper, we used the kernel information for the images that have the kernel.
Some firmware images may include the kernel, although the kernel cannot be nicely extracted. For those cases, you can still run the strings command and search for the "init=/" string after decompressing the image. Of course, not all kernel images have such paths because they can search the default path.
Meanwhile, I believe that most of firmware images share similar init paths. Therefore, you can collect the path strings in the firmware images that have the kernel, and then use the paths for the images that do not have the kernel.
Could you specify the cases or provide any more explanation?

Especially, on the OpenWRT project based firmware need to init with preinit init program. OpenWRT docs
And the such init program information exist in the kernel command
(e.g., dlink DIR-550A_v1.10KRb09 - root=/dev/mtdblock%d console=ttyS0,115200 init=/sbin/preinit, netgear WNDR3800-V<IP_ADDRESS> - console=ttyS0,115200 root=31:09 rootfstype=squashfs init=/etc/preinit ...)
However, the document indicate that use /etc/preinit program, some firmware images use /sbin/preinit.
You can extract the kernel data (Not complete one) by using extractor.py without a -nk (no kernel) option.
If FirmAE cannot infer kernel command from the kernel data, then it finds the preinit file from extracted filesystem and try first-emulation with found init programs.


chore: update vite to 5.4.6

Proposed change

Related issues

:bug: Fixes #(issue)
:rocket: Feature #(issue)

Fixed by https://github.com/AmadeusITGroup/otter/pull/2189


Here's a new site I'd like you to consider blocking

Here's a new site I'd like you to consider blocking:
https://www.wykop.pl
(please include any other relevant details)

I did the best I could since I don't speak Polish, lol. Let me know if I missed anything.


nixos/lib/qemu-common: Opportunistically use KVM

This will try to use KVM if available and fallback to using TCG if not.
Useful for nested virtualisation of arm on x86.
Description of changes
Try KVM on arm qemu, if it isn't available use TCG
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval


Loki should support existing secrets for storage configuration

Is your feature request related to a problem? Please describe.
At this point in time it does not seem to be possible to use an exsting secret for storage credentials in loki-app. This prevents the usage of for example sealed secrets.
Describe the solution you'd like
loki-app would support specifying existing secrets.

At this point in time it does not seem to be possible to use an exsting secret for storage credentials in loki-app. This prevents the usage of for example sealed secrets.

For my own learning, how does user get value from using sealed secrets?

This is our PR: https://github.com/grafana/helm-charts/pull/457 adding existing secret support to the loki-distributed chart
Sealed secrets works by having a operator running which decrypts encrypted secrets on demand for applications consuming the secrets

It's done.


Open connection once for upserts

This PR addresses the first task https://github.com/Azure/azure-functions-sql-extension/issues/73
Previously the connection is opened/closed three times for an upsert

Retrieving column information
Retrieving primary keys
Performing actual upsert

Now the connection will be opened once and used for all three queries. Since the connection is created in a using statement, it will be closed and disposed of correctly even if an exception is thrown.
I ran perf tests locally and there were no performance changes.

@lucyzhang929 out of curiosity how were perf tests executed?

For the perf tests, I used the Stopwatch class to run the AddProduct output binding integration test and compared the average of 1000 iterations.

For the perf tests, I used the Stopwatch class to time the AddProduct output binding integration test locally and compared the average of 1000 iterations.

Gotcha, thanks. I wonder if Benchmark.NET would be helpful here too. I've been doing some thinking over break about how we can use benchmarking in our tools to prevent perf regressions. I know other teams are looking at this too. Just thinking, that's all 😄

Yep I spent some time looking at setting up Benchmark.NET for perf tests as well but I wasn't able to set it up quickly so I ended up using Stopwatch to get some quick local perf results first. But I do want to continue looking at Benchmark.NET


feat(k8s): add kubernetes example of exporter deployment

I took the time to add a new example of your exporter, to be deployed in a kubernetes environment. This is the setup I quickly added to 2 of my own cluster. There is not enough metrics to share a grafana .json dashboard here, but if more metrics are bring to the table, I would gladly add it here

Looks good to me. Thank you for contributing and hope you are enjoying the exporter. I do have a Grafana dashboard that I will be posting soon.


Create a tool for providing typings for action inputs and outputs

Problem statement
Currently it's challenging to add support for multiple new actions. Each new action requires checking its inputs and inferring their types which then land in WrappersToGenerate.kt. Sometimes they are provided by the authors in README, sometimes they are inferred from input's description or type of default value. It doesn't scale well, introduces a risk of human error and adds operational load for actions already supported if they get new inputs.
Proposed solution
We should encourage action owners to proactively provide types for their actions' APIs in a standardized manner. The proposed approach is to have a GitHub action that would read action's manifest (action.y(a)ml) and would validate an extra type attribute for each input and output. This DSL library currently generates type-safe API only for inputs, but in the future the outputs can be type-safe as well.
Once such approach becomes popular, an automated job could proactively scan GitHub for actions using the typing validation action mentioned above, and add it to the list of requested wrappers. In the future, once Kotlin compiler plugins are easier to use from Kotlin scripting, I can imagine generating necessary wrapper code using such plugin, which would remove the need to maintain wrappers code in the library.

PoC work in progress: https://github.com/krzema12/github-actions-typing

I don't really understand what the PoC does, but here is the idea I had in mind:
Leverage what we have already done:
val wrappersToGenerate = listOf(
    WrapperRequest(
        ActionCoords("10up", "action-wordpress-plugin-deploy", "v2.0.0"),
        mapOf(
            "generate-zip" to BooleanTyping,
        )
    ),

which would send a pull-request to modify that file https://github.com/10up/action-wordpress-plugin-deploy/blob/develop/action.yml
as
name: 'WordPress Plugin Deploy'
inputs:
  generate-zip:
    description: 'Generate package zip file?'
+  type: boolean
    default: false

If and when the PR is merged, we would remove the typing from our repo:
val wrappersToGenerate = listOf(
    WrapperRequest(
        ActionCoords("10up", "action-wordpress-plugin-deploy", "v2.0.0"),
        mapOf(
-            "generate-zip" to BooleanTyping,
        )
    ),

Hopefully if enough repos accept our PR that would then become the basis for a GitHub standard.

@jmfayard yes, that could be another part of this "typification" plan :) In my PoC I'm going to prepare an action that will help action owners validate that their typings are correct.

@jmfayard my idea with a PoC implementation is ready to review, please see https://github.com/krzema12/github-actions-typing, mostly the README
At the beginning I thought of something like you proposed in #304, but then realized the following:

by staying in the YAML world (describing everything as YAML attributes), we are coherent with how action.yml looks right now. It has such pros:

it's JSON schema-friendly. By opening action.yml in IntelliJ you can see that the IDE has some schema embedded and it applies it to validate the manifest. I can imagine extending the schema with the attributes I proposed, then there's some kind of IDE support for these
parsing YAML is easy, no extra parsers required
YAML with its descriptive attribute names may be verbose, but it's also simple to read and self-documenting

full type description in a single string would complicate both sides of the contract: both this validator tool and the code generators. They would need some kind of parser to understand this non-trivial syntax. It wouldn't be possible for the JSON schema to validate it

@krzema12 your README looks good
you're right, there is no need to have a single type attribute

@Vampire great feedback, thanks! Yeah, I get your concern, I also thought about it. The major reason why I decided to put type info in existing action.yml is that this is the source of truth for action inputs and outputs. Now we have a trade-off: for now the schema validators will report type-related fields as incorrect, but in return the action manifest is self-contained and you don't have to jump between two files to read full information about a given input/output. My hope is that this kind of spec will lead GitHub to introducing something similar (that's why I wrote "for now"), but it may happen or not - no hard assumptions here.
Now when I think of it, what you propose is a reasonable compromise. Additionally I'd implement a piece of logic that ensures all inputs and outputs defined in action.yml are also present in action-types.yml.
@jmfayard how does it sound to you?
More action owners' feedback greatly welcome here!

I thought https://github.com/krzema12/github-actions-kotlin-dsl/pull/308 would make it easy to submit pull requests :)

Left to do within this task: adopt the tool in several actions and gather feedback. After that, the tool can live on its own and the work fill be tracked in https://github.com/krzema12/github-actions-typing 's issue tracker.

Tracking adoption by early adopter actions:

https://github.com/gautamkrishnar/blog-post-workflow/pull/149 - didn't agree to introduce the typings, unless it becomes an official GitHub feature
https://github.com/Vampire/setup-wsl/pull/30 - merged, not released

~merged, pending release~ released

Vampire/setup-wsl is now oficially the first action which provides typings for the generated wrappers - we don't have its typings in this library anymore :smile: https://github.com/krzema12/github-actions-kotlin-dsl/commit/0fa249531b4751adb237b11f54d06490c84864d3#diff-600cf51a113c240f1f1add17d808bd7327c1ea4f57931621710953c403aa6cb8
No more maintenance for this one, 74 left :laughing:

madhead's actions onboarded as well: https://github.com/krzema12/github-actions-kotlin-dsl/commit/8bb15ecda480d033834d74f3492cd027777e6e8b
Let me resolve this one since it's pointless to keep open until all actions onboard it.


Add bulk event function

@ConalCosgrove just the package.json and README changes and it looks good to me


Don't pull the example folder into the module build

Hi @gcharnock @bergie @locnguyen @cava23 - could you review this pr please.
I install your module in an application, it copies over .pem and .key files that are in your tests. This means that when we put our application through security scans, it fails because it finds these files and classifies them as sensitive data. What I'm asking is whether you can not include these in the bundled version of the application.
To resolve it, you can have a section in the package.json that doesn't pull the test files over to the build of the module when it is pulled in.

Hi @gcharnock @bergie @locnguyen @cava23 - could you review this pr please.
I install your module in an application, it copies over .pem and .key files that are in your tests. This means that when we put our application through security scans, it fails because it finds these files and classifies them as sensitive data. What I'm asking is whether you can not include these in the bundled version of the application.
To resolve it, you can have a section in the package.json that doesn't pull the test files over to the build of the module when it is pulled in.

Resolves #221

Resolves #221

I thought the package-lock.json should never be hand-modded. Is there a corresponding change to package.json you're trying to make? I don't understand the intended change based on the diff.

The package lock has only been upversioned and it wasn't done manually, I was done using the nom version patch command.

@cava23  if you look at the latest changes, there is a files section in the package.json that specifies which folders and files need putting into the package when installed.

Can you remove whitespace changes so the diff is legible?

@cava23 Sure thing - removed whitespace

Sorry, looked at this a little closer and it appears this is already being attempted in the .npmignore file. However, I believe the trailing slash is missing. I think the right change here is to update .npmignore to have test/. See if that solves your problem. I'd rather use that than add the files prop to package.json since that could have a greater impact than intended.

You can test this with npm pack: https://docs.npmjs.com/cli/v6/using-npm/developers#testing-whether-your-npmignore-or-files-config-works

Moved to .gitignore, and added example in there, which is causing an issue too. @cava23

Nice, I assume you meant .npmignore instead .gitignore. And this is now working as expected?

Yeah sorry I mean .npmignore.
And yep all working as expected

Sounds fair enough - cheers!

Hey @yaronn - are you able to review this pull request, please.


SBC image not downloading

ISSUE TEMPLATE ver. 0.4.0

Which TurtleBot3 platform do you use?

[ ] Burger
[ ] Waffle
[Y] Waffle Pi

Which ROS is working with TurtleBot3?

[ ] ROS 1 Kinetic Kame
[ ] ROS 1 Melodic Morenia
[Y] ROS 1 Noetic Ninjemys
[ ] ROS 2 Dashing Diademata
[ ] ROS 2 Eloquent Elusor
[ ] ROS 2 Foxy Fitzroy
[ ] etc (Please specify your ROS Version here)

Which SBC(Single Board Computer) is working on TurtleBot3?

[ ] Intel Joule 570x
[Y ] Raspberry Pi 3B+
[ ] Raspberry Pi 4
[ ] etc (Please specify your SBC here)

Which OS you installed on SBC?

[ ] Raspbian distributed by ROBOTIS
[ ] Ubuntu MATE (16.04/18.04/20.04)
[ ] Ubuntu preinstalled server (18.04/20.04)
[ ] etc (Not yet installed)

Which OS you installed on Remote PC?

[ ] Ubuntu 16.04 LTS (Xenial Xerus)
[ ] Ubuntu 18.04 LTS (Bionic Beaver)
[Y] Ubuntu 20.04 LTS (Focal Fossa)
[ ] Windows 10
[ ] MAC OS X (Specify version)
[ ] etc (Please specify your OS here)

Specify the software and firmware version(Can be found from Bringup messages)

Software version: [x.x.x]
Firmware version: [x.x.x]

Specify the commands or instructions to reproduce the issue.

I am trying to download the SBC image for installing on my SD card. But, it is not downloading on Ubuntu or Windows 10.

Copy and Paste the error messages on terminal.

HERE

Please describe the issue in detail.

I am trying to download the SBC image for installing on my SD card. But, it is not downloading on Ubuntu or Windows 10. I am getting the error - "Failed - Network error" after it goes all the way to 1.9 GB.

Hi @thehelpfulcosmopolitan
I'm sorry about the delayed response.
Unfortunately, it is difficult for us to identify the cause of the network failure as this is the only case I encountered.
Please use the link below to download the ROS1 Noetic image for Raspberry Pi 3B+.
The link will be available for the next two weeks so make sure to keep a copy of it.
https://drive.google.com/file/d/1FA1ih_rhSihQcLnh8KORWS4i_ReBWq7X/view?usp=sharing
Thank you.

For your reference. DL is possible from Japan without problem. I don't think it's a problem with ROBOTIS download page.

Best regards,


Add support for Cabal configuration files

This PR adds support for Cabal config files, which are used to store metadata about Haskell projects (à la package.json in a JavaScript project).
Description
Lack of support for Cabal was brought to my attention by @phadej in haskell-CI/haskell-ci#223, when I was correcting the language of some misclassified files:

Technically they are Cabal configuration, so it's more like EDN or JSON than Clojure or JavaScript. I guess linguist doesn't know about Cabal files?

Syntax highlighting is already provided by our existing Haskell grammar.
Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

.cabal: ~99,110 results
cabal.config: ~2,944 results
cabal.project: ~2,375 results

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

cabal.project:  Source | BSD3 clause
cabal.config:   Source | MIT-licensed
line2pdf.cabal: Source | MIT-licensed
defaults.cabal: Generated by me using cabal init [1]

Footnotes

[1] – cabal init output
λ linguist-sample: cabal init
-bash: cabal: command not found
λ linguist-sample: which cabal
λ linguist-sample: brew info $_
Error: No available formula with the name "cabal"
==> Searching for a previously deleted formula (in the last month)...
Warning: homebrew/core is shallow clone.
Updated 1 tap (homebrew/core).
No changes to formulae.

==> Downloading https://homebrew.bintray.com/bottles/cabal-install-<IP_ADDRESS>.high_sierra.bottle.tar.gz
######################################################################## 100.0%
==> Pouring cabal-install-<IP_ADDRESS>.high_sierra.bottle.tar.gz
==> Caveats
Bash completion has been installed to:
  /usr/local/etc/bash_completion.d
==> Summary
🍺  /usr/local/Cellar/cabal-install/<IP_ADDRESS>: 7 files, 27.3MB
λ linguist-sample: cabal init
Config file path source is default config file.
Config file /Users/john/.cabal/config not found.
Writing default configuration to /Users/john/.cabal/config
Warning: Caught exception during _mirrors lookup:res_query: does not exist
(Connection refused)
Warning: No mirrors found for http://hackage.haskell.org/
Warning: The package list for 'hackage.haskell.org' does not exist. Run 'cabal
update' to download it.
Please choose version of the Cabal specification to use:
 * 1) 1.10   (legacy)
   2) 2.0    (+ support for Backpack, internal sub-libs, '^>=' operator)
   3) 2.2    (+ support for 'common', 'elif', redundant commas, SPDX)
   4) 2.4    (+ support for '**' globbing)
Your choice? [default: 1.10   (legacy)] 4
Package name? [default: linguist-sample] linguist-sample
Package version? [default: <IP_ADDRESS>] v1.0.0
Couldn't parse v1.0.0, please try again!
Package version? [default: <IP_ADDRESS>] <IP_ADDRESS>
Please choose a license:
   1) GPL-2.0-only
   2) GPL-3.0-only
   3) LGPL-2.1-only
   4) LGPL-3.0-only
   5) AGPL-3.0-only
   6) BSD-2-Clause
 * 7) BSD-3-Clause
   8) MIT
   9) ISC
  10) MPL-2.0
  11) Apache-2.0
  12) LicenseRef-PublicDomain
  13) NONE
  14) Other (specify)
Your choice? [default: BSD-3-Clause] 9
Author name? [default: Alhadis]
Maintainer email? [default<EMAIL_ADDRESS>Project homepage URL? https://github.com/github/linguist
Project synopsis? Example of a Cabal configuration file for GitHub Linguist
Project category:
 * 1) (none)
   2) Codec
   3) Concurrency
   4) Control
   5) Data
   6) Database
   7) Development
   8) Distribution
   9) Game
  10) Graphics
  11) Language
  12) Math
  13) Network
  14) Sound
  15) System
  16) Testing
  17) Text
  18) Web
  19) Other (specify)
Your choice? [default: (none)] 11
What does the package build:
   1) Library
   2) Executable
   3) Library and Executable
Your choice? 3
What is the main module of the executable:
 * 1) Main.hs (does not yet exist, but will be created)
   2) Main.lhs (does not yet exist, but will be created)
   3) Other (specify)
Your choice? [default: Main.hs (does not yet exist, but will be created)] 1
Source directory:
 * 1) (none)
   2) src
   3) Other (specify)
Your choice? [default: (none)] 2
What base language is the package written in:
 * 1) Haskell2010
   2) Haskell98
   3) Other (specify)
Your choice? [default: Haskell2010] 1
Add informative comments to each field in the cabal file (y/n)? [default: n] y

Guessing dependencies...

Generating LICENSE...
Generating Setup.hs...
Generating CHANGELOG.md...
Generating src/Main.hs...
Generating linguist-sample.cabal...

You may want to edit the .cabal file and add a Description field.
λ linguist-sample:

@pchaigno You might want to add cabal-ghcjs.project to the popularity monitoring list. There are currently 68 results (~40 unique users), and many of them are relatively recent — it might be worth adding this as a supported filename in future.

You might want to add cabal-ghcjs.project to the popularity monitoring lis

people are quite free to have different project files, and the names are definitely not consistent.
e.g. I have used https://github.com/haskell-servant/servant/blob/master/cabal.ghcjs.project (note the dot, not a dash).
If linguist support prefix extensions cabal. or/and cabal-; it would cover more use cases. But I understand that our preference for prefix is quite peculiar, because the single *.cabal file in the directory has a special meaning, independent of the actual name,

If linguist support prefix extensions cabal. or/and cabal-; it would cover more use cases.

Unfortunately, it doesn't. 😞 We're currently limited to matching complete filenames only (and only as fixed strings; e.g., no regex-aware matching). This is a known limitation of Linguist, I'm afraid.

people are quite free to have different project files, and the names are definitely not consistent.

Be that as it may, it's still worth keeping an eye on if over 40 users have used this particular filename to date. 👍

@pchaigno You might want to add cabal-ghcjs.project to the popularity monitoring list. There are currently 68 results (~40 unique users), and many of them are relatively recent — it might be worth adding this as a supported filename in future.

I'm tagging this PR as Pending Popularity to remember to add it to #4219.


Possible to get WaveForm data from MP3?

I am writing an application that runs on Azure that requires to extract waveform data from an mp3 file. Is this possible with NAudio if the application environment doesn't contain Media Foundation (as do all azure web apps)? basically input as mp3 and an output of an array of x sampled amplitudes is what i'm looking for. TIA

It's a bit of a pain on Azure, as you can't use Mp3FileReader either since that relies on ACM. Probably the best bet is to use NLayer which is a fully managed MP3 frame decoder that can be plugged into Mp3FileReader

Thank you so much, will give this a try.


<EMAIL_ADDRESS>hash check failed

Scoop Configuration

{
  "lastUpdate": "2022-07-20T01:55:08.7292552+09:00",
  "SCOOP_REPO": "https://github.com/ScoopInstaller/Scoop",
  "SCOOP_BRANCH": "master"
}

duplicated


fix: order resource classes by GPU, CPU, RAM, storage

closes #244

This change is part of the following stack:

#420 ◀

Change managed by git-spice.

You can access the deployment of this PR at https://renku-ci-ds-420.dev.renku.ch

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
22 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.04%) to 90.394%

Files with Coverage Reduction
New Missed Lines
%

components/renku_data_services/base_models/core.py
1
85.85%

components/renku_data_services/storage/blueprints.py
2
94.76%

components/renku_data_services/crc/blueprints.py
3
92.88%

components/renku_data_services/project/db.py
16
92.73%

Totals

Change from base Build<PHONE_NUMBER>2:
-0.04%

Covered Lines:
9325

Relevant Lines:
10316

💛  - Coveralls

Tearing down the temporary RenkuLab deplyoment for this PR.


runserver: move DEFAULT_PORT into Command attribute

Allow a subclass of Command to easily override the default port value

merged in 0d7a295f28003f6c6adc138549d6f56d2a3d8806, thanks.


EntityCollectionInterface::toArray()

EntityCollectionInterface::toArray() to get a native PHP array representation of the collection.

:+1:


[NF] Coupling with Ansys (Maxwell, Simplorer, etc.)

Hello,
I am opening this issue to start discussion around Ansys coupling:

What would be the objectives of the coupling (import results from Ansys, build models in Maxwell/Simplorer, launch simulations etc.) ?

Is there already any Python package that we could use to interface with Ansys ?

How could we implement the Ansys coupling eventually ?

Best regards,
Emile

I can help for that, there are some possible implementation but we need to build an abstraction layer between pyleecan and FEMM

Hello,
Thank you for your interest in pyleecan. If you can help us on this issue that would be great :)
The coupling with FEMM already use a geometry abstraction layer. We have a method known as "build_geometry" that returns a generic representation of the machine "as a list of surface". All the topology complexity including symmetries are handled by this method and the coupling with FEMM (and gmsh) is mostly:
for surface in surface_list:
for line in surface.lines:
line.draw_FEMM()
assign_surface(surface.label, surface.point_ref)
We talk more about it in our ICEM 2020 publication:

https://pyleecan.org/icem.2020.html
https://pyleecan.org/videos.html

What kind of simulation (machine / physics / software...) do you want to run with this coupling ? Maybe a first step can be to draw and mesh a machine from pyleecan within Ansys. Maybe we can reuse some work from the coupling with GMSH for this purpose.
Best regards,
Pierre


Breaking API changes in e1.4.2

ApplicationVersion API was changed.
PerkObject API was changed.

Hey,
I just have 1 request. When u will have working version, but still pending for review please post it here so we can download and use it faster - like before after hotfix.
That would be awesome.


Address issue #196

Addresses #196

RTM

Coverage increased (+0.08%) to 94.534% when pulling 00f6fdc59824970aaacc3d45c98a4ad2cf94298d on sni/issue-196 into abb7ad6322b9ed0e0124abc3c4f4e232f88b14f8 on master.


RFP - trippy

Checklist

[x] The package I am requesting does not already exist on https://community.chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts with 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://github.com/fujiapple852/trippy
Direct download URL for the software / installer : https://github.com/fujiapple852/trippy/releases/download/0.8.0/trippy-0.8.0-x86_64-pc-windows-msvc.zip
Software summary / short description: A network diagnostic tool
Package is called Trippy, the executable is trip.exe.

Added to distributions in README: https://github.com/fujiapple852/trippy?tab=readme-ov-file#distributions
TYVM!


[Feature Request] Add HEIC (apple image format) support

It would be fantastic to have heic-to-pdf support in the app. Do you think there's a possibility of that happening?

Seems it is possible with
https://github.com/gotson/NightMonkeys
Will add feature request

Seems NightMonkeys requires jdk21 this would be a big change


cherow v2.0.0

this issue is to track cherow todo in v2.0.0.

[ ]<EMAIL_ADDRESS>release
[ ]<EMAIL_ADDRESS>release
[ ]<EMAIL_ADDRESS>release

Delays in my end with current 2.0 version. I'm soon back on track

Duplicate of #245


Unable to find any nodes on GoAddTag and GoImpl

Sample code
type Person struct {
	Name string
	Age  int
}

type IPerson interface {
	SetName(name string)
	SetAge(age int)
}

Expected Behavior
type Person struct {
	Name string `json:"name"`
	Age  int `json:"age"`
}

type IPerson interface {
	SetName(name string)
	SetAge(age int)
}

func (p *Person) SetName(name string){
	panic("...")
}
func (p *Person) SetAge(age int){
	panic("...")
}

Actual Behavior
tag not fill and got Unable to find any nodes. place your cursor on a go symbol and try again
https://user-images.githubusercontent.com/37516576/185517739-add4a899-a582-42f0-a230-44ea5408a9db.mp4

I think you need to save main.go before you run those commands.

still not working :cry:
https://user-images.githubusercontent.com/37516576/185726294-5bb8c38f-e54b-4999-a789-bdf1768763a4.mp4

solved
reinstall go.nvim


Expose (most) transactions

Resolves #187
Exposes all transactions except ContentStateInlineStyle and getSampleStateForTesting.

Was wondering what is the problem you are trying to solve by having to expose transaction API ? I feel like the least that is expose the quicker allow the library to move since it has to maintain less API.

I figured these would need to be exposed at some point.
My only concern here is that Modifier does a lot of other work to manage changes to entity ranges, and sidestepping those can lead to trouble.
So for anyone using transaction functions directly, it's a caveat emptor situation. :) But that's okay!

I'll throw my support behind this PR. I have a need for getContentStateFragment.

Is this PR will be merged any time soon ? We would need adjustBlockDepthForContentState to be exposed and I'd prefer use it this way than duplicate the code ;)

@mitermayer, @flarnie, et al, how do you guys feel about this now? Increasing the exposed API could lead to headaches with API breakage down the road, though I certainly understand the usefulness here -- I assume people are largely hacking around this at this point.

I'm no longer using the function I originally thought I needed access to. I can't remember my use case, but I do recall finding a better way of doing things. Perhaps supporters of this PR should detail their use cases first. Maybe we'll find that there are better approaches for them as well.

Is this PR will be merged any time soon ? We would need adjustBlockDepthForContentState to be exposed and I'd prefer use it this way than duplicate the code ;)

We need this exposed as well, so that we can intercept the backspace command and use it to outdent lists (see https://github.com/facebook/draft-js/issues/187).

Any movement on this? We could also use adjustBlockDepthForContentState as some others have noted.

Looking at this now, my thought is "not yet". I'll discuss with the other Draft maintainers today, but we have other open bugs and API changes underway, and I'd rather reconsider this once other things are cleaned up.

Sorry to close this, but for now my answer is "not yet" - let's wait to expand the API surface of Draft until we fix some of the remaining bugs and add other features that are in the pipeline currently. I would ask folks to continue using the work-around approach described in the issues linked to this PR, or even copy out the modules you need and maintain a fork if you need custom behavior.


Add underline and strikethrough

I don't know if you can do this with normal game maker studio text functions let alone with scribble but this feels like a nice thing to have...

[slant] can be used to emulate italics (but tends to be frowned on by typographers). Bold doesn't have an equivalent; I don't know what Juju's stance on adding one would be. With that said, you can set up a font with actual bold and italics attributes in GameMaker and change the font to it on the fly with [font_name]`.
Strikethrough and underline are unaccounted for since those are just lines being drawn and not actually font attributes. I imagine those cold be added.

it would be easier if this was built into scribble, it eliminates a few extra steps...

Actually, I was looking at an old version of the documentation: you can now combine font families together, and switch between them using formatting tags: https://github.com/JujuAdams/Scribble/wiki/Functions-(Font-Modification)

As Dragonite kindly points out, swapping between bold and italic (and bold+italic) fonts is supported using the [b] and [i] and [bi] command tags. You need to set these up manually using scribble_font_set_style_family as Scribble does not procedurally associate fonts (it used to, but it was unreliable).
Adding underline and strikethrough is... something I'll think about. I'm not 100% sure if GM reveals enough information to handle these features, though I will check.

I'm sure you can put together something that's "good enough" just based on the dimensions of each glyph and or the final positions of each vertex. No idea how much doing something simple like that would offend typographers though.

I just implemented underline, I'm adding my (badly written) functions to get individual lines width and draw an underline in case it's useful as a starting point. It's of course only for horizontal, left to right languages.
The textargument is the scribble element.
{
	var _line_count = text.get_line_count();
	var _glyph_count = text.get_glyph_count();
	var _previous_x = 99999;
	var _last_leftmost_glyph = -1;

	text[$ "__lines_width"] = array_create(_line_count);

	if(_line_count == 1) text.__lines_width[0] = text.get_bbox().width;
	else
	{
		var j = 0;
		for(var i = 0; i < _glyph_count; i++)
		{
			var _current_x = text.get_glyph_data(i).left;
			if(_current_x < _previous_x || i == _glyph_count - 1)
			{
				if(_last_leftmost_glyph != -1)
				{
					text.__lines_width[j] = text.get_glyph_data(i - 1).right - text.get_glyph_data(_last_leftmost_glyph).left;
					j++;
				}
				_last_leftmost_glyph = i;
			}
			_previous_x = _current_x;
		}
	}

	text[$ "__total_width"] = 0;

	for(var i = 0; i < _line_count; i++) text.__total_width+= text.__lines_width[i];
}

function scribble_draw_underline(text,xx,yy,underline_pos,typist = undefined,color = c_white,alpha = 1,thickness = 3)
{
	if(underline_pos < 0) exit;
	if(text[$ "__lines_width"] == undefined) show_debug_message("Error trying to draw underline before having called 'scribble_get_lines_width'");
	draw_set_color(color);
	draw_set_alpha(alpha)
	if(typist != undefined) var _underline_pos = min(typist.__revealed_total_width,underline_pos);
	else _underline_pos = underline_pos;
	var _current_left = 0;
	var _bbox = text.get_bbox();
	for(var i = 0; i < text.get_line_count(); i++)
	{
		if(_underline_pos < _current_left) break;
		if(_underline_pos >= _current_left +  text.__lines_width[i])  var line_progress = text.__lines_width[i];
		else line_progress = _underline_pos - _current_left;

		var dist = line_height/2 + (i * line_height);
		var x1 = xx + lengthdir_x(dist,-90) + (_bbox.width - text.__lines_width[i])/2;
		var y1 = yy + lengthdir_y(dist,-90);
		draw_rectangle(x1,y1,x1 + line_progress,y1 + thickness,false);

		_current_left+= text.__lines_width[i];
	}
}```


Add a policy for GitHub Actions workflow run approval configurations

There are various modes which can be configured for approving GitHub Actions to run a given workflow, as described here and here.  It would be good to be able to oversee this with an allstar policy, specific to public vs private forks.

Thanks for the suggestion! I think the first step would be to figure out what we would like the config to look like. Which settings Allstar would check and what the admin would setup as policy to allow or disallow.


Caught up changes from typescript-github-action-template

#28  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatChen and the rest of your teammates on  Graphite