NavigationAgent3D.get_next_location() returns invalid positions around merged NavigationRegion3D

Godot version:
Godot 4.x
commit 4a1f2dcb746af43dcebeb241276adfb5d99c1020
OS/device including version:
Win 10 64x
Issue description:
NavigationAgent3D.get_next_location() returns many invalid positions around areas that are in close proximity to two merged NavigationRegion3D.

positions that are not on any designer baked navmesh (collision agents can get stuck easily).
positions that are floating in air without any (bake) geometry or collision below (physics agents can fall through world).
positions that confuse NavigationServer on repeated pathfinding requests (agents stuck with pingpong back and forth).

It seems the NavigationServer3D is merging NavigationRegion3D edges to aggressive without any real care for actual source geometry or scene collision from baked navmesh. Lowering the NavigationServer3D.edge_connection_margin to 0.5-1.0 only hides the problem that the merged navmesh behind the scene, while maybe technically correct, is hot garbage for gameplay purposes.
For collision and physics agents this is basically broken gameplay navigation in Godot 4.x as soon as two NavigationRegion3D are merged.
Magenta Capsule = Agent
Cyan Cylinder = NavigationAgent3D.get_next_location()
Yellow Circle = mouse clicked movement target

Left playeragent receives get_next_location() vectors that are in the air around the bridges where the NavigationRegion3D from the topleft block connects. Right patrolagent does not have the same issues as it stays on same NavgiationRegion3D at all time with valid positions.

Top playeragent not only floats in the air but also gets pingpong stuck due to repeated pathfinding requests and a very confused NavigationServer3D.
Lowering NavigationServer3D merge margin to < 1.0 solves most issues (default is 5.0 and way to high for practical use) but what would be the point of a new navigation feature that only "works" while basically disabled?
Steps to reproduce:
Create two NavigationRegion3D islands connected by narrow navmesh paths (e.g. 1 meter) so they are merged by the NavigationServer3D. NavigationAgent3D.get_next_location() returns invalid positions close to the merged NavigationRegion3D  areas that shouldn't exist and can get agent lost/stuck.
Minimal reproduction project:

NavigationAgent3DIssue.zip

Lowering NavigationServer3D merge margin to < 1.0 solves most issues (default is 5.0 and way to high for practical use) but what would be the point of a new navigation feature that only "works" while basically disabled?

I think the issue is that with #47024, 5 units (meters) are too high. Before the edge search was much more strict on the edge shape, and even a relaxed number like 5 was just fine. I think we can lower it now, so to have a much correct scale.
When you lower that parameter, do you see any other issues?
What's the value are you using?
I guess the correct value should be around few centimeters.
Side note: it's better to not overlap the navigation regions.

When you lower that parameter, do you see any other issues?

Yes, if edge_merge_margin is very low it only merges navmeshes that are horizontal and on the same y-axis.
It creates a lot of issues with angled or verticality navmeshes (as if they only use 1/10 of the merge margin).
Maybe the merge margin can be split in a horizontal and vertical value to compensate for this?

What's the value are you using?

I am using the recommended realistic scale in my games so 1 unit = 1 meter. If I remember correctly in the linked demo and animated gifs the edge_connection_margin was set to 1.5.
Now I am testing with edge_connection_margin 0.5 cause it has less issues with pathfinding but getting navmeshes to merge that are not exactly on the same y-axis value is very difficult with such a low value. I am especially frustrated with simple ramps on different navmesh regions as it is pixelhunting to get them merged properly (or get the mentioned pathfinding bugs).
The debug navmesh also does not display the merged navmesh correctly so it requires tedious runtime testing for even small changes.

Side note: it's better to not overlap the navigation regions.

I know that it works better without overlap but I don't think it should be part of a solution to avoid vertical overlap with navmeshes.
The reason for this is that Godot navmesh bake enforces a geometry setup that produces overlap all the time and we currently can't make custom changes to the generated navmesh (e.g. by dragging an edge up/down). Also it works against what most level designers would do in level building. As a level designer you never want to leave geometry gaps for the navmesh and pray to the algorithm goddess where you can't even see the result in the editor.

The edge merging is not meant to merge really different and faraway edges. Rather the idea was to allow the user setup well defines edges, where the merge will be performed. For all the other cases, the idea is that the user has to use the bake function that allow to rebake the nav-mesh at runtime.
The reason why it's not a good idea allow the overlap merge for such different polygons, is that the edge merge would became equally complex to the baking.

The idea is that you have to cut the map along the same region. So the edges of the two navmesh are basically the same. If you cant do that, a re-bake is needed.

The edge merging is not meant to merge really different and faraway edges.

I didn't expect to merge faraway edges beyond the merge margin but I expected to merge any edges within the merge margin in all axis.

Rather the idea was to allow the user setup well defines edges, where the merge will be performed.

I can't align the baked navmesh edges so perfect on not straight or slightly rotated geometry that it would work with the current limitations.
In another example I created two "bridges" with the excact same mesh placed at the exact same height. Both overlap the same second navmesh at an equal horizontal angle. One bridge gets merged while the other bridge gets ignored. If I move the bridge on the same edge plane a few units into one direction it gets merged. As a level designer I have zero idea/control/feedback when and why the second bridge gets merged or ignored. It is all trial and error that you can do in the editor but good luck at runtime.

the idea is that the user has to use the bake function that allow to rebake the nav-mesh at runtime.

It is unpredictable for merging how the bake function creates a navmesh edge at runtime.
I created a platform like in your demo but slightly rotated. It creates 5 complelty different version when the (re)bake is hit at runtime everytime the geometry mesh has a slightly different global transform position. If the platform is a straight box like in your demo without any rotation it works but it can't be the expectation to limit all gametypes to minecraft boxlevels.
My problem is the lack of control what edges are merged, it is not predictable and we have zero (visual)feedback except for our stuck agents at runtime to work with and around the limitations in an efficient way.

I agree, right now there is no gizmo that tell you what's going on. A gizmo that show if the connection is enstsablished would improve it a lot. The 2D editor has that gizmo.
However, would be interesting to see a gif / video / image, for these new edges you are trying to merge: so to have a better understanding for the use case.

Here is an overlayed screenshot of a test map with edge_connection_margin 0.5 and realistic 1unit=1m scale.
All "bridges" are the excact same mesh block only the horizontal/y-axis rotation is different. I left vertical rotation out of this example cause it only makes the problem worse and breaks every bridge.
The different colored island meshes are the 3 different NavigationRegion3D.

Notice how the more complex megabridge made out of two bridges on the right gets merged to a proper pathfinding mesh without any issues while the more simple bridges to the left and center are made non-traversable for agents.
What happens if we force an agent on one of the red bridges and click on the bridge end is that as soon as they are on top the other NavigationRegion3D they take a gigantic detour back around the entire map to reach the target. This tells me that around this bridge locations the NavigationRegion3D are not merged at all for unknown reasons.

Thanks for this screenshot, as shown here https://github.com/godotengine/godot/issues/47816#issuecomment-820972542 the idea is that the merged edges must be parallel and the more similar possible.
To achieve that in your scene, the best you can do is to cut the bridges in half, and assign each half bridge to its master platform. In this way the generated nav mesh of each platform also have the bridge, that can now be connected to its half.

I accept that this is intentional and navmeshes need to be aligned more careful so I close this issue.
That said the problems around this could be somehow mitigated with better debug visualization to see merge connections between different navigationregions in both editor as well as at runtime. See proposal: https://github.com/godotengine/godot-proposals/issues/4507


No binaries for arm

Due to the increasing number of Kubernetes users on arm platforms, I'm requesting the following build targets be added to releases:
darwin/arm64  (Apple M1)
linux/arm64     (AWS Graviton and some 64-bit Raspberry Pi's)
linux/arm          (Most Raspberry Pi's, 32-bit v7 arch)
Thanks!

Sorry for the slow response. I don't have an ETA for you at this time, but we do have an internal tracking story (SC34569) for ARM support that Replicated customers can reference with their account representative.

FYI @BretFisher per the docs as of this writing (18OCT2024):
Supported operating systems: The following are the supported operating systems for nodes:
- Linux AMD64
- **_Linux ARM64_**

Sweet, thanks!


Souvenir Skins?

Anyone know how to get souvenir skins in the game? I can only get the normal versions of the skins.

You can open souvenir packages.


Are 'Multipart Requests' supported?

Hi, I have a question whether Multipart requests are supported? (see https://swagger.io/docs/specification/describing-request-body/multipart-requests/)
I'm trying to generate simple OkHttp client with model (here is my endpoint in openapi.yaml as example)
  /api/import
    post:
      operationId: importMedia
      summary: Import Media
      description: >
        TEST Import media file
      requestBody:
        required: true
        content:
          multipart/form-data:
            schema:
              type: object
              required:
                - interaction
              properties:
                metadata:
                  $ref: '#/components/schemas/MediaFileDto'
                mediaFile:
                  type: array
                  items:
                    type: string
                    format: binary

but I'm facing an error Unresolved reference 'MultipartFormData'.
To be clear I'm using fabrikt-gradle-plugin with this config
fabrikt {
	generate("Client") {
		apiFile = file("openapi.yaml")
		externalReferenceResolution = aggressive
		basePackage = "com.example"
		outputDirectory = file("${project.layout.buildDirectory.get().asFile}/generated")
		typeOverrides {
			datetime = OffsetDateTime
		}
		client {
			generate = enabled
			target = OkHttp
		}
		model {
			generate = enabled
			sealedInterfacesForOneOf = enabled
			ignoreUnknownProperties = enabled
			includeCompanionObject = enabled
		}
	}
}

Thanks in advance for any support

Hi @b0m123,
I can confirm that requests with multipart/form-data does not currently lead to working code being generated.
This applies to the OkHttp client as well as the controller interfaces for Micronaut, Spring and Ktor.

One possible cause of action would be to add a special case to the request statement builder for operation.requestBody.getPrimaryContentMediaType()?.key == "multipart/form-data", which would construct the requestBody using MultipartBody.Builder().

Any idea how to work around this in the case of Controller (Spring) interfaces?
Thanks in advance!

Any idea how to work around this in the case of Controller (Spring) interfaces? Thanks in advance!

Since invalid code is generated in this case, the best you can do for now is probably to omit the specific endpoint from the spec before generating and implement it yourself. For sure not ideal, but there's unfortunately no support for multipart/form-data just yet.


Add circle CI to build libvirt driver

How to verify if this works as expected?

@gbraad this is now working good to go and merge.


How to know what pool/srp device is bound to?

Hello,
After spending some time I could not find the way to identify what pool/srp each device is bound to, get_volume() function does not provide these details.
May be I miss something or there is no way to do it via RestAPI?
From solutions enabler it's available from "symdev show" command output like:
symdev -sid 1111 show DEVICE
...
Bound Pool Name:   SRP_NAME
...

Hi, there is usually only a single SRP on the majority of PowerMax arrays, usually called SRP_1,  this is reported at the storage group level.  If you do a get_storage_group_details on the storage group you will find the bound SRP
{
"storageGroupId": "ansible_metro",
"slo": "Diamond",
"service_level": "Diamond",
"base_slo_name": "Diamond",
"srp": "SRP_1",
"slo_compliance": "STABLE",
"num_of_vols": 2,
"num_of_child_sgs": 0,
"num_of_parent_sgs": 0,
"num_of_masking_views": 0,
"num_of_snapshots": 0,
"cap_gb": 4,
"device_emulation": "FBA",
"type": "Standalone",
"unprotected": true,
"compression": true,
"compression_ratio_to_one": 0,
"vp_saved_percent": 100,
"unreducible_data_gb": 0
}


Implement reconstitution of semantics from flux span

This PR implements logic to reconstitute ODE semantics for a template model based on a flux span data structure which describes how a stratified model maps back to original models.

Codecov Report

Merging #208 (d41c558) into main (c9771ef) will increase coverage by 0.41%.
The diff coverage is 88.61%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   77.34%   77.75%   +0.41%
==========================================
  Files          66       68       +2
  Lines        5331     5452     +121
==========================================
+ Hits         4123     4239     +116
- Misses       1208     1213       +5

Impacted Files
Coverage Δ

mira/modeling/askenet/petrinet.py
96.91% <ø> (+0.61%)
:arrow_up:

mira/sources/askenet/flux_span.py
83.90% <83.90%> (ø)

mira/dkg/model.py
96.64% <100.00%> (+0.13%)
:arrow_up:

mira/metamodel/template_model.py
66.06% <100.00%> (+2.88%)
:arrow_up:

mira/metamodel/templates.py
83.76% <100.00%> (+0.04%)
:arrow_up:

mira/sources/askenet/petrinet.py
93.10% <100.00%> (+1.79%)
:arrow_up:

tests/test_flux_span.py
100.00% <100.00%> (ø)

tests/test_model_api.py
96.69% <100.00%> (+0.13%)
:arrow_up:

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add helper macro/function for defining predicate on each element of a vector

Something like
CONS(0 <= EACH(P) <= 1000);

Will restructure these kind of issues later.


Ability to assume role into 300+ accounts

Even though I'm using this plugin, I'd have to specifically mention the stack multiple times in the required-resources along with the account ids. This is ideal if we have limited number of AWS Accounts.
In the context where we have 100s of accounts, this isn't scalable. Please advise, if there is a workaround of this, until this becomes a feature where I could just a for loop to iterate over boto3.Sessions with different account role credentials.

I am no longer planning on maintaining this repository and will be archiving it soon. I've updated the README to indicate that I no longer recommend using this plugin since the functionality has been made the default in CDK v2.


[tools] support gsutil

Part of the work for microsoft/vcpkg#16288

LGTM, thanks for the PR and sorry for the merge delay :)


Supported versions added

Hi Philip!
When it comes to editing the landing page, I think "pull request" may work better than "issues".
Thanks!

Thanks Ali.
I will merge this request. It is good practice for me as I get used to Github.
For solids4foam-v2.0 (currently the nextRelease branch), the supported versions will be:

foam-extend-4.1
OpenFOAM-v2012
OpenFOAM-9

Although I am keen to support the more recent versions too, maybe via another release.
I think we should design the website with the goal of presenting solids4foam-v2.0 (as opposed to the current solids4foam "v1.0").


Add graphqlBuildersProvider for graphQlSourceBuilder method

Consumer<GraphQL.Builder> is very useful to customize GraphQL.Builder, such as builder.preparsedDocumentProvider()  for cache support.

I think we'll also need for a GraphQlSourceBuilderCustomizer and if that's added, then you'd be able to call the conifgureGraphQl method directly. What do you think @bclozel?

yes, if GraphQlSourceBuilderCustomizer will be supplied and it will be great.

I'm closing this PR in favor of #98, since we tend to provide customizers for Spring-provided types and GraphQlSourceBuilderCustomizer addresses the use case presented here.
Thanks @linux-china !


Continued Model run fails to stop on stage error

Need to stop queued model run when one of the stages fails (e.g. H-GAC model run). Check run status and abort list if stage is not complete.

Fixed.

It boils down to what happens when a later stage in multiprocessing discovers that its StartFrom is not RunComplete. Should do some explicit handling - specifically, when a stage comes back as failed for some reason, do not queue any additional stages: cancel the run and return.


Status of project maintenence, suggestion of transfering to lunarmodules

It's been a while since cliargs got any tender loving care. This message is not to blame the maintainer. As a frequent FOSS contributor with many projects on my plate I know exactly how things go. Even if argparse has some more of the momentum for Lua CLI argument parsing, I am personally a fan of how this library works and have gotten a lot of millage out of it. I would rather not have to migrate most of my existing projects.
That being said the issues are starting to pile up. I see almost 1/3 of the open issues here are things I've raised over the years and have frequently had to monkey-patch my way around. I'd like to offer to help maintain the project so those fixes get upstreamed and I can keep using it as is.
I offer this as the maintainer of Luacheck, LDoc, a contributor to Busted, Penlight, and others. This isn't my first Lua rodeo. I've also picked up the maintainer reigns on a host of Vim plugins at @preservim and other projects as well. You are welcome to review the history of those projects and how smoothly the handovers have gone.
I would like to propose this project join the umbrella of @lunarmodules. You can still be listed as a project owner, but the team there would also have admin rights, and I could help shepherd the process of getting PRs handled, issues triaged, CI brought up to speed, and eventually a new release series going. If that sounds agreeable by all means have a look round at how we've handled other projects in similar boats. I'll check with the rest of the team and if nobody objects we'll get you an invite so you can transfer the repo to that namespace. That way all the old links will have redirects and no existing use connections are broken.
I see @Tieske your are previous contributor to this project as well, does this scan by you?

iirc @amireh created this in a distant past but is not actively using it. Moving it to LunarModules makes sense to me, so we can set up a broader team.

Gently ping @amireh.  I'd like to see these fixed at the root!
We can send you an invite to the @lunarmodules org so you can transfer the repository there, but the invites only last 7 days before expiring. Please ping back here and we'll get the ball rolling if that's okay with you!

Hi, excuse me for not responding in time, I've been out of here for a while. I'm totally okay with the move if you'd like to make that invitation. Thanks.

Okay, I just got to read through the posts. First, accept my apology for not responding to the other issues you submitted. This has pushed me over to finally clean up my mail inbox and especially GitHub notifications, as I was getting too many for things I was not responsible for and in the process missed the ones I shouldn't have (now realizing, even ones dating back to 2020 :disappointed:.)
I wish I had the time to properly maintain this, more so when I had to deal with other CLI arg libraries in other languages over the last few years and found myself missing some of the design decisions taken in this one. I'm happy you offer to do this so thank you both.
The security issue made me curious but I could not point it out in Busted's PRs/commits -- would you give me a link to it? I'd like to learn of the mistake.

The LuaRocks.org ownership change is not something you can do on your end very easily, but we can page @hishamhm about it and I believe he can take care of it pretty easily. With your message above authorizing the change there shouldn't even be anything else you need to do.
And thanks again for dropping by and taking care of this so your useful contribution in the past can live on a bit longer!

Great! I'm glad it proved to be useful, and thanks again for your offer and your patience.
An aside: I've been working hard to make this software work as a business to fund me in place of employment. My plan is to apply to Lua if it's received as well as I hope it to be for JavaScript. If/when that day comes, I'll officially have an excuse to work on maintaining a Lua library! ;)
I'd love to hear any feedback or impressions you have on SYNG, even though it's not usable for Lua yet. The concept is universal, although perhaps more applicable to non-typed languages, and there's so much room to improve with the AI advancements we're seeing. Right now it's a "structural" search, but the goal is to arrive at a "semantic" one - sort of a dream of mine.

Closing since there's nothing for me to do for the LuaRocks transfer. Feel free to ping me otherwise, I'll be paying more attention.

thx @amireh !

lua_cliargs is now moved to the lunarmodules user in LuaRocks.
BTW, not directly related to this package, but I recently raised the question that I think we need to start creating project-specific users in LuaRocks, so that the API keys are siloed to the particular teams in the lunarmodules org.


Adam's Audit Issues

adam's comments:

https://github.com/hats-finance/hats-contracts/issues/366

https://github.com/hats-finance/hats-contracts/issues/368

https://github.com/hats-finance/hats-contracts/issues/369

https://github.com/hats-finance/hats-contracts/issues/367

https://github.com/hats-finance/hats-contracts/issues/370

closing this as we now have separate issues for each


microcodeIntel: 20190312 -> 20190514

This is needed for upcoming mitigations for newly disclosed flaws in
Intel processors.  Thanks, Intel.  Anyways, what do you actually do
for a living?
See also:
CVE-2018-12126  MSBDS  Microarchitectural Store Buffer Data Sampling
CVE-2018-12130  MFBDS  Microarchitectural Fill Buffer Data Sampling
CVE-2018-12127  MLPDS  Microarchitectural Load Port Data Sampling
CVE-2019-11091  MDSUM  Microarchitectural Data Sampling Uncacheable Memory

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

84cdfb8f31

The new microcode appears to work fine on my i7-2620M and i7-4790K (0x25 -> 0x27 even though Intel didn't bother to list it in their microcode guidance.)


Convert rg-date.js to Blaze 2.x format

Added c-'s and o-'s all over the place.

Realised there was a fair bit still missing.


need some help

thank you for your hard works.
just install work fine but has one issue
after all the page are loaded if i scroll back to top page ( first page )
in firefox and chrome can't click on products. (only top first page products).
if anyone know how to fix this issue i really need help
thank you

Hi Gabriel,
I just installed your great extension, but it does not work at all on my magento installation <IP_ADDRESS>:
http://www.sabzoo.de
Can you please help me?
Thanks, Thomas

Sorry, here is the correct link straight to the products:
http://www.sabzoo.de/schuhe.html

Hello @sabzoo,
Please download the extension from the 2.0 branch and let me know if that works. The branch is in Beta but is very stable and I'm using it in production myself - the only reason its not on Master is that the InfiniteScroll plugin itself is still in 2.0 Beta.
Please let me know if that works,
Gabriel.

Hi Gabriel,
thanks for the support. I installed the version from the branch 2.0 and it is working properly!
Thank you very much for this great extension. I really love it: http://www.sabzoo.de/schuhe.html
BR,
Thomas

Great! Love to hear that - make sure to spread the word!


Where is the BAS button in VS Code?

Hi! I have the extension installed , but the button hasn't appeared on the left in a toolbar and is not also hidden - it's just not there in a list. Why?

Funny, I don't remember it - but seems like I already reported similar issue before: #292 . I guess it doesn't work in WSL/Linux

Hi,
You are right, but it's not an issue. BAS remote only works on the host machine (Windows/Mac/Linux), but will not work from a remote machine like WSL, remote container, etc;

@idoprz may I ask why is like this? I'm very curious - is it done intentionally - or because of some limitation? Thanks!
I think we're significantly reducing the circle of devs potentially interested in using BAS.  In my case I'd prefer even not to use it locally if it requires Windows. WSL - is not event the target. Devcontainer is the actual target where I'd like BAS extension to be used.

There is a reason why such a thing as https://containers.dev/ was introduced. Working in a container helps us to set up any environment and be 100% sure it is identical regardless when it runs - on Windows, Linux or Mac. Inside we have some base image + installed libraries. With web containers https://webcontainers.io/ it becomes even more achievable. So talking about tools like CAP - it becomes very easy to pick up NodeJS or Java container and open the project there instead of setting up the environment.
Moreover talking about Windows - unfortunately there are plenty of tools which don't really work in Windows nicely ( like scripts only support Linux ). Additionally even mounting Windows folder to a WSL/Linux webcontainer - there is NTFS file ssytem behind and commands like npm install or commands like watch work much worse from persepctive of performnance rather than with Linux native ext4 format.
So that's why not all devs are ready to start working in Windows only because of that.
I'm not that big expert in VS Code Remote functionality , so for sure you know better what to do . But I just feel like there must be a way to solve this problem by connecting to a remote environment from VS Code , from WSL or devcontainer.
I'm just curious - can't may be remote tunnels help?
https://code.visualstudio.com/docs/remote/tunnels
According to what they state here it could be possible:
https://code.visualstudio.com/docs/remote/tunnels#_can-i-use-other-remote-development-extensions-or-a-dev-container-while-im-tunneling
So probably if BAS server would have a remote tunnel server - it will be possible to connect to it from a local environment, it doesn't matter OS, WSL or container.  But i'm not 100%b sure about this..

Hi @ThePlenkov
The BAS remote extension is exactly what you are describing here. You work remotely from the host machine on the remote target which is BAS in this case. This is very similar to working with Dev containers, but this containers are remote machines managed by BAS. If your host machine is Windows/Mac/Linux it does not matter, as the dev environment is running remotely - linux in BAS case. So the drawbacks you describe for working in Windows are not relevant as you are working on the remote machine - Linux.
So your last state is 100% correct, and the remote extension for BAS does exactly that - it tunnels from your host environment to BAS. https://marketplace.visualstudio.com/items?itemName=SAPOSS.app-studio-remote-access

Ok, but if VS Code allows remote tunnels from WSL/Devcontainers - why BAS extension doesn't support this.
You referenced to Remote - SSH extension (https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-ssh-edit)
And I mean Remote - Tunnels : https://marketplace.visualstudio.com/items?itemName=ms-vscode.remote-server
If first one will probably indeed will not work from WSL/Devcontainer because it's already remote - the scenond one should work according to docs.
So what BAS uses to connect - SSH or remote tunnels?
Thanks!

The remote tunnel extension requires you to have VSCode on the host machine (full blown VSCode or just the CLI) - see "Make a tunnel available" section in the extension readme.
We cannot deliver VSCode product as part of BAS. Also the tunnel extension does not manage the lifecycle of the remote machine. Also, you would need to use github service (which is Microsoft product) to register your remote machine IP. Many of our customers would not like to have their users login to a Microsoft product.
So, technically you can install it yourself but I believe the user experience will not be so great and you might violate your corporate guidelines. You would need to start the DevSpace every time from the browser and start the VSCode process on the remote machine.
BAS is using remote SSH with Microsoft dev tunnels (https://github.com/microsoft/dev-tunnels) which is the infrastructure of the remote tunnels extension. It uses SSH over WebSocket connection because SSH is often blocked by corporate firewalls.


Initial websocket server support for sidecar

Summary of Changes

Install quarkus websocket server implementation.
Establish a new websocket resource at /ws
Connections to the websocket handler get filtered by the existing AccessTokenFilter, so the HTTP GET to the /ws endpoint will require the correct Authorization header with the access token.
However, the connection GET request headers aren't accessible from the websocket handler Session interface, but the query string is, so use that to get hold of the workspace (process) id. Keep track of all of the workspaces.
Whenever connection count changes, publish a WORKSPACE_COUNT_CHANGED message with the new connection count to all of the connections.
Any websocket message received from a workspace will be proxied to all of the other connected workspaces.

Any additional details or context that should be provided?

Corresponds with https://github.com/confluentinc/vscode/pull/754

Pull request checklist
Please check if your PR fulfills the following (if applicable):

Tests:

[ ] Added new
[ ] Updated existing
[ ] Deleted existing

[x] Have you validated this change locally against a running instance of the Quarkus dev server?make quarkus-dev

[x] Have you validated this change against a locally running native executable?make mvn-package-native && ./target/ide-sidecar-*-runner

Integration tests added in WebsocketEndpointTest.java.


Fix 285 ensure correct rendering of linktaflow in react flow component

Renders correct linktaflow components connecting nodes to edges
Fixes #285
Type of change

[x]  🐛 Bug fix (non-breaking change which fixes an issue)
[ ] ✨  New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 📝 Documentation update
[ ] Other 🗒 ______________

How Can this be tested? Testing Plan to review this PR

Run application and generate a new user input, confirm that new inputs load edges correctly. Previous test data may not have necessary information stored and may not generate correct edge components
Checklist:

[x] I have performed a self-review of my own code.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.
[x] I have reviewed the Security Best Practices Document.
[x] I have followed the Naming Conventions Guide for my changes.
[x] I have ensured that my pull request title is descriptive.

Additional Information:

FYI for code reviewers: if you do not see a LinktaFLow associated with a UserInput, pls generate a new LinktaFlow by clicking Explore a new topic. You may want to try a few times until you get a LinktaFlow successfully (check the Chrome dev tool to ensure you're not getting axios errors). And make sure to refresh the page to get the updated UserInput on the SideNav.

Please also address the following acceptance criteria either in this PR or create a new ticket that links to this PR and Ensure Correct Rendering and Styling of LinktaFlow in React Flow Component #285:

Rendering and Styling: Nodes and edges should be rendered correctly in the React Flow component. Nodes and edges should have the correct styling applied (e.g., colors, labels).

Currently there is no indication that the application is not loading components with applied styling. Correct styling for nodes will be done under a different ticket given that it's not a "fix"

@LucieSeidler and I identified that when a user signs up, the path correctly switches to /generate, but sometimes the UI continues to display the auth page. Since this issue doesn't impact the functionality of this feature I created a bug ticket for it #313


Support for additional frameworks scikit/xgboost/pytorch

We need performant model servers for each of these technologies and auto-wiring via high level specs analogous to TensorflowSpec

Complete with our 0.1 release
/close


Fix fallthrough when logging is disabled

Problem
What is being fixed?  Examples:

Fix new presumit failure when the detailed log is disabled

Change overview
Move the break below to avoid the potential fallthrough when detail log is disabled.
Testing
The existing presubmit cover this

Fixed by #8283


Added blogs

@all-contributors
Please add @md0u80c9 for blog

@all-contributors
Please add @sebastian-fox for blog

@all-contributors
Please add @julianflowers12 for blog

@all-contributors
Please @PHEgeorginaanderson for blog

https://github.com/all-contributors
Please add @PHEgeorginaanderson for blog

Copy and paste gives full github link which doesn't trigger the bot
@all-contributors
Please add @PHEgeorginaanderson for blog

@all-contributors
Please add @sebastiz as blog

@all-contributors
Please add @kurtstat as blog

@all-contributors
Please add @ivyleavedtoadflax as blog


Add message uploading, downloading

[ ] Upload
[ ] Download

Usually, people would consider the ability to send and receive messages to be almost integral to an instant messaging service. This applies here, too.

https://github.com/Bibliosoph/almanacd/commit/3ef0ed4bdc68232dd1f15aefb41b9128a323719e
https://github.com/Bibliosoph/almanacd/commit/aad726dc708d506d1500ec16c77ccfa37eb66c7a


No issue completions with default query

Extension version: v0.30.0
VSCode Version: 1.60.2 (NOT Insiders)
Commit: 7f6ab5485bbc008386c4386d08766667e155244e
Date: 2021-09-22T11:59:27.195Z (1 wk ago)
OS: macOS 11.6 (20G165)

Issue autocompletion is provided by the githubIssues.queries setting. By default it's limited to your assigned (with a milestone?) and created issues. Contributions to open source projects are rarely assigned. This limits discoverability of issue autocompletion (I was specifically searching for it).
I propose an additional default Open Issues query corresponding to All Open pull requests.

@texastoland this is an excellent point. I'm thinking a "Recent Issues" query might be good to have, where it returns recently modified issues.

Leaving this here for when I update the query: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-when-an-issue-or-pull-request-was-created-or-last-updated

I like that! It would resolve the discovery issue for repos (like Microsoft's) where all open issues might incur a performance penalty. If it were architecturally feasible in the future paging open issues could be preferable.


Add docker-compose file

Yes of course!

:)
@moifort I've given you commit rights.
Though generally try if you're doing a change please get someone else to check and merge your request.
Feel free to check and commit other peoples pulls

Oki!


saveIndex and marked for deletion

Hi!
Does saveIndex() function omit marked for deletion items?

Hi @vinnitu ,
No, it does not omit, it should save them along with the marks.


JDK8 support

javaassit update 3.18.0-GA -> 3.19.0-GA

Javassist 3.20.0-GA was released.

thanks :thumsup:


Add Icon container widget

https://github.com/Scrivito/scrivito-portal-app/pull/132
https://trello.com/c/IX9bxKBu/32-icon-list-widget

FEEDBACK (84ea8df)
Up to 84ea8df all looks good. Please don't add new coded (LinkWidget etc.) that is intended for another PR. If this PR affects LinkWidget etc. please wait with LinkWidget until this PR is merged.


Extracting features with the Kaldio package

hello author,
Recently, when studying the model you proposed, I want to use your pre-trained model to infer my own data, but I have the following confusion:

First, I used the following code on my machine to extract one of the wav files of Speechocean762. I used wav.scp to encode, but an encoding error was reported. Specifically, kaldio should use open to open the wav file. Do you know how to fix this?

for key, feat in kaldi_io.read_vec_flt_scp(scp_path):
    print(key)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe4 in position 2:
invalid continuation byte(arr = (binary + fd.readline().decode()).strip().split())

I checked your extracted tr_feats.csv, and I found that each line has 85 dimensions, but why the feature I extracted using torchaudio.compliance.kaldi is not 85 dimensions, and I extracted a wav in the speechocean 762 dataset The length of the file is much greater than 50, and the features of all files in your code are less than 50. I want to know why?

specgram = torchaudio.compliance.kaldi.spectrogram(waveform)
mfcc = torchaudio.compliance.kaldi.mfcc(waveform)
mfcc.shape      (torch.Size([377, 257]))
specgram.shape     (torch.Size([377, 257]))

3、If I just want the model to identify the speaker's fluency, can I make some simplifications, such as not using the ASR model?

Hi there,
Thanks for reaching out.

First, I used the following code on my machine to extract one of the wav files of Speechocean762. I used wav.scp to encode, but an encoding error was reported. Specifically, kaldio should use open to open the wav file. Do you know how to fix this?

How did you extract scp file for a single audio? Did you use the Kaldi SO762 recipe? If not, then there's no guardantee that our code can read the scp file. I haven't tried to load a scp file for a single audio file. I uploaded a sample scp file at https://www.dropbox.com/s/53b0p8awapt5f22/feat.scp?dl=1 to help you check this.
A general recommendation is first to follow our instruction step by step, and if success, then modify based on that.

I checked your extracted tr_feats.csv, and I found that each line has 85 dimensions, but why the feature I extracted using torchaudio.compliance.kaldi is not 85 dimensions, and I extracted a wav in the speechocean 762 dataset The length of the file is much greater than 50, and the features of all files in your code are less than 50. I want to know why?

By feature, we meant gop features, not mel fbank features you extracted, please see equation 1-4 in the paper. The feature dimension can be different from 85, depending on your ASR system's phone dictionary size, e.g., PAII-A has a 88 or 86. But for an English ASR system, the difference won't be large. Mel fbank features are totally different as GOP features are output of a (trained) ASR model. The sequence length is the number of words, so it can be any number, we used 50 just because the max sequence length of speechocean 762 dataset is 50.

3、If I just want the model to identify the speaker's fluency, can I make some simplifications, such as not using the ASR model?

This entire work depends on a trained ASR model. I don't have an idea how to skip it.
Hope these helps.
-Yuan


Implement short-circuit logic operator

Implement short-circuit evaluation for logic && and || operator.
The short-circuit behavior is only used when the operands involved are scalar and the parent function is non-differentiable.
In implementation, we define a new class 'LogicOperatorShortCircuitExpr' derived from 'OperatorExpr'. In the visitInvoke() call, we will create a new expression object 'LogicOperatorShortCircuitExpr' if the expression is logic && or ||. So that we can generate new IR code in the new visit function 'visitLogicOperatorShortCircuitExpr' to implement the short-circuit behavior.
Add new test to test the short-circuit behavior.

The failure in Falcor seems legit. We may want to investigate that assertion error.

The failure in Falcor seems legit. We may want to investigate that assertion error.

Sure, I'm working on the GPU test failures for the GLSL intrinsic now. After that, I will look into the Falcor failure.

Resolved most of the comments except this one:

The setup for m_outerDecl can be done independently to whether or not it is static const. Consider renaming it to m_outerVarDecl and always set the state.

I know this is a decently recent change, but I believe the documentation still says that there's no short circuiting logic scalars.  This merge means the documentation is wrong correct?

You are right, the documentation should be updated.


[Community/tw] Update Taipei-HashiCorp-User-Group

Add repository https://github.com/Taipei-HUG to https://github.com/TGmeetup/TGmeetup/blob/master/community/tw/Taipei-HashiCorp-User-Group/package.json
Ref: https://github.com/TGmeetup/TGmeetup/blob/master/documents/package.json.sample#L19-L22

Doing it


created two components

This added a table component and a head of table component (top). There is definitely a better and more efficient way of doing this but it is slightly better than our previous code by splitting up the index.js in my opinion.

This is also more ideal for the storybook

Nice job, this cleans up out index.js a lot, and will help for testing.

yeah looks good to me too, this will be really helpful for the storybook


pilot: agent sidecar-injector print flags

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
643ecc5d3716a14265baf5bdeec7dc8aafe54246
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
c0b83c181cb27122181d7728df725c5bfa010c89
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ZackButcher
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [ZackButcher]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

rebased

@hzxuzhonghu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
45840d0b00e3ddccb3e3b64d8fc3d2db32cbdba8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Investigate broken Custom Security Manager

I have made sufficient comments, and instead of sweeping this under the rug, it should be looked at - CSM is broken because redirection does not work properly - it works in 0.33.0rc1, but not 0.34!
https://github.com/apache/incubator-superset/issues/8062

I would put the version tag in, but the issue creator does not let me tag - FYI.

can you elaborate on what you mean by "redirection doesn't work properly" and what are the steps to reproduce?

@MarcusSorealheis - I posted the other ticket.
When you attempt to use a Custom Security Manager, it goes direct to the Welcome page, bypassing the login page.  Since the user in my CSM is neither logged-in nor authorized, the page is unreachable.
On 0.33.0rc1 all redirections work as expected - when you navigate to the root url, it redirects to the login, attempts to auth, and then once authenticated, redirects to welcome.


ergoCub1.2 -  Architecture correction

Corrected architecture for ergoCub1.2 (SN002)
cc @pattacini

Can you please make the image weigh less than 1 MB, as done with the other architectures?

Hi @pattacini,
done!

@AntonioAzocar we should change the label from eCub1.1.3 to 1.2 in the top left of the picture

Correct!
@AntonioAzocar, you could be doing that through a dedicated PR.


[Bug]  System.IdentityModel.Tokens.Jwt 6.15.0 publishing  always 6.14.1

In .NET 6
Nuget
System.IdentityModel.Tokens.Jwt package 6.15.0
rely
Microsoft.IdentityModel.JsonWebTokens.dll 6.15.0
Microsoft.IdentityModel.Tokens 6.15.0
Debug and Release compiled version of dll is normally 6.15.0
When publishing , the operation will be abnormal
could not load file or assembly system.identitymodel.tokens.jwt
The dll version is always 6.14.1

@jaelys I am not able to understand the issue, please reopen with additional details if this is still an issue.


Create security-vulnerability-hardening.md

initial version

https://blueprints.launchpad.net/opencontrail/+spec/security-vulnerability-hardening


Feature/mapping get only lists

#112

I noticed after upgrading the test project to netcoreapp3.1 this one test fails without any other changes to the code, and it seems a bit flaky sometimes the enum is wrong but other times not.

I have made a separate pull request to update netcoreapp3.1 first, this will fix the failing unit test
https://github.com/cezarypiatek/MappingGenerator/pull/118

@cezarypiatek I will update this pr soon with the latest changes of the upstream branch and use dotnet 3.0. Could you let me know if this is the right direction for this solution?

@wazowsk1 please rebase your branch to master and push it again. Then I will be able to review your changes.

@wazowsk1 I've started do review your code. Hell lot of the work 👍 Please give me a couple of days for this.


Bug with saving LoRA (adapter_model.bin) on latest peft from git

Setup
using get_peft_model with CAUSAL_LM, transformers.Trainer(...), then lora_model.save_pretrained(lora_file_path) to train a LoRA on LLaMA (int8).
The Issue
When saving at the end, adapter_model.bin is an empty pickle (443 bytes, contains a 6 byte data entry).
This is, of course, wrong, there should be data in there. Prior versions of peft saved full proper files with actual content in them.
Checkpoints saved midway through by save_steps in the transformers trainer seem to contain full valid data (but in a different format).
See https://github.com/oobabooga/text-generation-webui/pull/1098#issuecomment-1509713861 for more discussion of the issue externally.
Relevant technical details
pip install git+https://github.com/huggingface/peft has an error (at time of writing that's commit b21559e042555a8370f4b3cf1ad581c45291cf15 ) but pip install peft==0.2.0 does not, indicating likely an error sourcing from a recent change.
Relevant source code replicating this issue: https://github.com/mcmonkey4eva/text-generation-webui/blob/lora-trainer-improvements-3/modules/training.py
Side Note
Likely a separate topic, but users have said that on peft==0.2.0 they're seeing huge VRAM spikes when save_pretrained is ran. I haven't seen this myself yet but it may indicate need more broadly for more thorough validation of the saving code.
EDIT: Yeah okay indeed separate topic, other user on github reported the VRAM spike part is actually caused by bitsandbytes rather than peft.
(Also it's a bit strange that pickles are being used - a separate project entirely but those should definitely be replaced to safetensors files)

Update: so, after some testing, torch.save(trainer.model.state_dict(), f"{lora_file_path}/adapter_model.bin") is able to save a valid file.
But, lora_model.save_pretrained(lora_file_path, state_dict=trainer.model.state_dict()) does not.
That both, (A) hopefully helps narrow down where the issue may lie, and (B) gives a functional workaround for until it's properly fixed.

Could you please share minimal code that we can run to reproduce the above issue?

As per this https://github.com/tloen/alpaca-lora/issues/293, uninstalling and reinstalling fixed this it seems

Above PR should have the fixes. Note that there were no issues with PEFT and they were related to alpaca-lora

That's perfect, that fixed it. Thank you so much for taking the time to investigate and get it fixed for everyone!


[DC-732] Identify rows from specified target datasets to suppress

Hi @lrwb-aou. When you get a chance, please let me know if you have a preference on how to keep track of the concepts that this is meant to suppress. They're currently in a google sheet, a JIRA file, a BQ table, but all these seem more volatile than we might like. I was considering committing to this repo a csv file with the concept_ids.

Thanks for the discussion earlier @nishanthpp93 . To summarize, we will associate this PR with DC-737. I think the structure introduced here is a big improvement without being scope creepy. I would like us to work together on a retraction design document which we can run by the team before we do any major refactoring. Below are the key points we mentioned which we will continue to discuss.
~Ensure consistency between logged and retracted rows~ this will be included in the new retraction module design
Error handling Define the commands expected behavior if pid table doesn't exist or has improper schema, invalid pids, invalid dataset_id(s)
CLI arguments Let's figure out a way so we don't need -dataset_ids "d1 d2"
One point I forgot to mention:
Are person_ids and research_ids input supported? I think strictly limiting input to person_ids (participant IDs) may prevent user error while also simplifying logic. Allowing research_id input enables ambiguous calls e.g. where a non-deid dataset is provided. It'd also be nice to have a separate utility to convert person_id -> research_id which this and other scripts can use and which can also be used independently.

Hi @lrwb-aou. When you get a chance, please let me know if you have a preference on how to keep track of the concepts that this is meant to suppress. They're currently in a google sheet, a JIRA file, a BQ table, but all these seem more volatile than we might like. I was considering committing to this repo a csv file with the concept_ids.

@mark-velez For now, yes I would probably store these concept_ids as part of our repo because it would be less volatile than hoping someone didn't mess up a spreadsheet.  I would create a separate setup function in this module that loads or verifies the required data exists in the format the function using the data expects (either csv or loaded from a csv to a table).  I did something similar in deid (use a csv file to create a reference table), because one of the generalization rules depends on knowing the state an ehr uploading site is located in.  And now that I think about it, we need to make sure that file is updated whenever a new site is added.


feat: manage profile with forms

Fixes Issue
closes #5575
To access forms visit /account/manage/profile
TODO

[x] navigation to access profile form and statistics page
[x] profile form
[x] tags form
[x] links form (+ social shortcut toggle)
[x] testimonials form
[x] events form
[x] milestones form
[x] test with non existing profile (new)

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Hey Eddie, I think the actions are failing because the api routes "users" have been renamed to "profiles" https://github.com/EddieHubCommunity/LinkFree/pull/7355

Thank you @ChinmayMhatre 👍 this is still in draft, there will be a few failures I will need to fix

Some suggestions:

[ ] navbar: move version no. to footer
[x] rename login to login/sign up
[x] login page: add Don't have a GitHub Account? Create one on GitHub (add link to GitHub registration)
[ ]  what appears for new profile after you register?

From @amandamartin-dev

On save of a change to my NAME, i then navigated to search and searched for myself.  The card did not reflect my name change, but clicking into the card did reflect the change on my profile page.
I then changed my name a second time.
THe 1st change now presents on my profile care and change 2 now reflects in the profile page.
Refreshing the page does not seem to affect anything

There is no character limit on any of the fields so I can just spam away long content
I can write script tags, offensive content, links to offensive content
I can enter non-tag content in the tags (can put whatever there really)
Basically since this will bypass PR review, I think there should be some form validations

it's not clear what switching the layout will do since the preview does not reflect a change.  You have to save and go look

Notes for documentation:

[x]  navbar: move version no. to footer
[x]  rename login to login/sign up
[x]  login page: add Don't have a GitHub Account? Create one on GitHub (add link to GitHub registration)
[ ]  link add/edit: show group on preview (if used)
[ ]  manage pages in responsive mobile drop down does not work
[ ]  what appears for new profile after you register?
[ ]  Dark mode for managing profile forms

Hi there. I just looked through the Quickstart file and noticed that the bullet points in the “Next Steps” section are not hyperlinked. Can I update those? I’ll gladly work with you on them! :)

Hi there. I just looked through the Quickstart file and noticed that the bullet points in the “Next Steps” section are not hyperlinked. Can I update those? I’ll gladly work with you on them! :)

@CBID2 The next steps on the quickstart guide are links for me in the main branch and also this pull request (no changes were made in this PR) - please see screenshot and code below

https://github.com/EddieHubCommunity/LinkFree/blob/f733de2d99e8750190396c00c22677441c01e7b4/pages/docs/quickstart.mdx?plain=1#L215-L219

Hi there. I just looked through the Quickstart file and noticed that the bullet points in the “Next Steps” section are not hyperlinked. Can I update those? I’ll gladly work with you on them! :)

@CBID2 The next steps on the quickstart guide are links for me in the main branch and also this pull request (no changes were made in this PR) - please see screenshot and code below

https://github.com/EddieHubCommunity/LinkFree/blob/f733de2d99e8750190396c00c22677441c01e7b4/pages/docs/quickstart.mdx?plain=1#L215-L219

Oh ok @eddiejaoude! :) With that said, I can update the directions on those pages if you’re open :)

Oh ok @eddiejaoude! :) With that said, I can update the directions on those pages if you’re open :)

@CBID2 I don't understand what you mean about "directions"?

Oh ok @eddiejaoude! :) With that said, I can update the directions on those pages if you’re open :)

@CBID2 I don't understand what you mean about "directions"?
@eddiejaoude, I mean update the steps on how a person can edit/add links to their profile. From what you showed in the Linkfree call, people can drag and drop their links.

@CBID2 I don't understand what you mean about "directions"? @eddiejaoude, I mean update the steps on how a person can edit/add links to their profile. From what you showed in the Linkfree call, people can drag and drop their links.

There is no drag and drop - thank you, but the documentation for this pull request has already been done, I will push them tomorrow as it is very late here now

@CBID2 I don't understand what you mean about "directions"? @eddiejaoude, I mean update the steps on how a person can edit/add links to their profile. From what you showed in the Linkfree call, people can drag and drop their links.

@CBID2 there is no drag and drop - thank you, but the documentation for this pull request has already been done, I will push them tomorrow as it is very late here now

Ok

Will create a new pr for the other theme changes

Will create a new pr for the other theme changes

Great thank you @ChinmayMhatre 👍  please remember to branch from the latest version of this branch as I made more updates recently - this will make sure we don't get conflicts


Update bytesize-1-nf-core-into.md

Added the link to Bilibili.

Just changed the link to figshare to the doi to have a similar link than other events


BidderUsersyncStatus never has no_cookie=false

Hi,
The /cookie_sync endpoint always returns no_cookie: true for all bidders. It seems that there's no possible code path that sets this to false, deactivating user syncs.
https://github.com/prebid/prebid-server-java/blob/c172af7c0f5d898e328bb4aef93b0eec8dee5bf9/src/main/java/org/prebid/server/handler/CookieSyncHandler.java#L450-L499
Is this a bug or am I missing something very obvious here :joy:

Okay,.. nevermind this is fine. I guess. I need to check the prebid.js integration

Ref: https://github.com/prebid/Prebid.js/issues/6354


changes

added color picker to choose your own color for name esp
added a toggle for the movement sim prediction line
added a color picker for the movement sim prediction line

Very nice


Update README.md

Link to go to Spanish version

Thanks @Hilmerc for all the translation work, looking forward t many more.


Error: Please specify --curl-dir=/path/to/built/libcurl

I encountered the error: Please specify --curl-dir=/path/to/built/libcurl while doing a "pip install request_curl".  I have already installed PyCurl using the pycurl-7.45.1-cp311-cp311-win_amd64.whl I have tried all SO links but none of them help. Thanks.
Python Version:  3.11.3
Pycurl version: 7.45.1
OS: Windows 10

Hi,
See this issue


Docker nightly tag

Describe the feature
Can you add an nightly docker tag with faster updates?
The last update on docker was 21 days ago. And a few days ago a commit was made which I think may fix an issue I'm having.
An ffmpeg tag that included ffmpeg would be nice too.
Thanks anyway.

Hello @alpe12, i can't add nightly docker tags since Docker Hub has limits on the overall size of images, but i will add FFmpeg tags.

Thanks.


nixos/pam: add option to control how pam_unix hashes passwords

Description of changes
Once your computer is stolen or physically accessed, you might not care about your login password being brute-forced. Unless it is also used to encrypt your key for ecryptfs/fscrypt/or other similar home directory encryption, then you really care.
This change makes the hashing algorithm used for password encoding configurable as a NixOS module option and suggests yescrypt for cases which need good brute-force resistance.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/hashing-plain-text-password-directly-in-configuration-nix/2093/27


id namespacing is undocumented and seems to be broken

The namespace attribute used in test/baselines/sources/namespaces.html is not documented at https://tc39.es/ecmarkup/ , and rendering that file generates many unexpected warnings and in-document links.

It's definitely inadequately documented. It predates me, but my understanding is that namespacing applies to terms and definitions within the namespace, not to ids - ids are an HTML concept, not an ecmarkup concept, and must be globally unique within the document (not just within the namespace) so they can be linked.


feat: Uses KafkaServers from app_common_python for kafka config

RHINENG-6301
Secure Coding Practices Checklist Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[ ] Input Validation
[ ] Output Encoding
[ ] Authentication and Password Management
[ ] Session Management
[ ] Access Control
[ ] Cryptographic Practices
[ ] Error Handling and Logging
[ ] Data Protection
[ ] Communication Security
[ ] System Configuration
[ ] Database Security
[ ] File Management
[ ] Memory Management
[x] General Coding Practices

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (37339f8) 74.61% compared to head (398fc32) 74.79%.

Files
Patch %
Lines

historical_system_profiles/config.py
50.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   74.61%   74.79%   +0.17%
==========================================
  Files          25       25
  Lines         851      849       -2
==========================================
  Hits          635      635
+ Misses        216      214       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


is SerialPort fitting Raspbian?

hey guys i have an Raspbian OS installed on my raspberry,
i would like to know if it is ok to use this OS or I need to switch it.
PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)" NAME="Raspbian GNU/Linux" VERSION_ID="9" VERSION="9 (stretch)" ID=raspbian ID_LIKE=debian HOME_URL="http://www.raspbian.org/" SUPPORT_URL="http://www.raspbian.org/RaspbianForums" BUG_REPORT_URL="http://www.raspbian.org/RaspbianBugs"

Everything is perfectly working on rasbian, you have issues?


commander is outdated

🐛 Bug Report
when I install a plugin meta can find the source of the plugin but not the bin.
To Reproduce

docker container: docker run -it node:18-bullseye /bin/bash
install meta globally: npm install -g meta
install a plugin globally: npm install -g meta-search
set debug: export DEBUG=*
run command: meta search
result: it will find the lib for meta-search yet not the bin

  root@8e6eb90be27e:/# meta search
  meta
  meta Resolving plugins: +0ms
  meta   /node_modules +1ms
  meta   /usr/local/lib/node_modules +283ms
  meta     + meta-bump +1ms
  meta     + meta-project +0ms
  meta     + meta-search +0ms
  meta
  meta Loading plugins: +0ms
  meta   + meta-bump /usr/local/lib/node_modules/meta-bump +0ms
  meta   + meta-project /usr/local/lib/node_modules/meta-project +1ms
  meta   + meta-search /usr/local/lib/node_modules/meta-search +1ms
  meta
  meta Loading core plugins: +3ms
  meta   + meta-git /usr/local/lib/node_modules/meta/node_modules/meta-git +0ms
  meta   + meta-init /usr/local/lib/node_modules/meta/node_modules/meta-init +1ms
  meta   + meta-loop /usr/local/lib/node_modules/meta/node_modules/meta-loop +41ms
  meta   + meta-project (skip) +42ms
  find-module-bin looking for meta-search at /node_modules/.bin/meta-search +0ms
  find-module-bin looking for meta-search at /usr/local/lib/node_modules/.bin/meta-search +0ms
  find-module-bin looking for meta-search at /usr/lib/node_modules/.bin/meta-search +0ms
  find-module-bin looking for meta-search at /usr/local/lib/node_modules/meta/bin/node_modules/.bin/meta-search +0ms
  find-module-bin looking for meta-search at /usr/local/lib/node_modules/meta/node_modules/.bin/meta-search +0ms
  find-module-bin looking for meta-search at /usr/local/node_modules/.bin/meta-search +0ms
  find-module-bin looking for meta-search at /usr/node_modules/.bin/meta-search +1ms
Error: could not find meta-search
    at findModuleBin (/usr/local/lib/node_modules/meta/node_modules/find-module-bin/lib/index.js:18:9)
    at Command.executeSubCommand (/usr/local/lib/node_modules/meta/node_modules/commander/index.js:552:11)
    at Command.parse (/usr/local/lib/node_modules/meta/node_modules/commander/index.js:489:17)
    at exports.run (/usr/local/lib/node_modules/meta/index.js:47:11)
    at Object.<anonymous> (/usr/local/lib/node_modules/meta/bin/meta:8:15)
    at Module._compile (node:internal/modules/cjs/loader:1112:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1166:10)
    at Module.load (node:internal/modules/cjs/loader:988:32)
    at Module._load (node:internal/modules/cjs/loader:834:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)

Expected behavior

it should find npm-search bin file
it should print out the usage same as when calling meta-search directly

resolve
because find-module-bin does not look for a bin dir within either npm prefix -g or npm bin -g the bin file for meta search isn't found
root@8e6eb90be27e:/# npm prefix -g
/usr/local
root@8e6eb90be27e:/# npm bin -g
/usr/local/bin
root@8e6eb90be27e:/# which meta-search
/usr/local/bin/meta-search

symlinking it into one of the dir's it is checking, resolves the issue
root@8e6eb90be27e:/usr/local/lib/node_modules/meta-search/bin# ln -nfs /usr/local/lib/node_modules/meta-search/bin/meta-search /usr/local/lib/node_modules/.bin/meta-search
root@8e6eb90be27e:/usr/local/lib/node_modules/meta-search/bin# meta search
  meta
  meta Resolving plugins: +0ms
  meta   /usr/local/lib/node_modules/meta-search/bin/node_modules +1ms
  meta   /usr/local/lib/node_modules/meta-search/node_modules +0ms
  meta   /usr/local/lib/node_modules/node_modules +1ms
  meta   /usr/local/lib/node_modules +1ms
  meta     + meta-bump +0ms
  meta     + meta-project +0ms
  meta     + meta-search +0ms
  meta   /usr/local/node_modules +0ms
  meta   /usr/node_modules +0ms
  meta   /node_modules +1ms
  meta   /usr/local/lib/node_modules +268ms
  meta     + meta-bump (skip) +0ms
  meta     + meta-project (skip) +0ms
  meta     + meta-search (skip) +0ms
  meta
  meta Loading plugins: +0ms
  meta   + meta-bump /usr/local/lib/node_modules/meta-bump +0ms
  meta   + meta-project /usr/local/lib/node_modules/meta-project +0ms
  meta   + meta-search /usr/local/lib/node_modules/meta-search +1ms
  meta
  meta Loading core plugins: +3ms
  meta   + meta-git /usr/local/lib/node_modules/meta/node_modules/meta-git +1ms
  meta   + meta-init /usr/local/lib/node_modules/meta/node_modules/meta-init +0ms
  meta   + meta-loop /usr/local/lib/node_modules/meta/node_modules/meta-loop +34ms
  meta   + meta-project (skip) +35ms
  find-module-bin looking for meta-search at /usr/local/lib/node_modules/meta-search/bin/node_modules/.bin/meta-search +0ms
  find-module-bin looking for meta-search at /usr/local/lib/node_modules/meta-search/node_modules/.bin/meta-search +0ms
  find-module-bin looking for meta-search at /usr/local/lib/node_modules/.bin/meta-search +0ms
  find-module-bin found meta-search at /usr/local/lib/node_modules/.bin/meta-search +0ms
Usage: meta-search [options] [command]

Options:
  -h, --help      display help for command

Commands:
  package         Find packages in package.json that match given criteria
  help [command]  display help for command

My mistake, 1. turns out this was a commander issue and 2. it's actually resolved, my version of it was old, apologies.

Actually it turns out this bug exists because commander is old

Up for opening a pr?

We have a forked version of commander - @mateodelnorte I know you made this commander fork but I am not clear on what the reason was for that or if the newest version of commander ever resolved this?
https://github.com/mateodelnorte/meta/blob/master/package.json#L55
It's currently 594 commits behind mainline

This branch is 18 commits ahead, 594 commits behind tj:master.

If the mainline version of commander is still not adequate for what we need maybe there's another tool we could replace it with?

Yeah, commander at some point made changes causing default behavior to no longer work. I created a PR to fix it and it went unmerged for ages, long enough for them to completely change their dev ethos around dependencies. Eventually they closed the PR. Unfortunate.
https://github.com/tj/commander.js/pull/604

There was some more conversation about this here in the past as well: https://github.com/mateodelnorte/meta/issues/77


Tensorflow failed when build with MSVC

System information
•	Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
N/A
•	OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Windows server 2016
•	TensorFlow installed from (source or binary):
Source
•	TensorFlow version (use command below):
Master branch latest revison
•	Python version:
Anaconda 4.1.1 (Python 3.5 64-bit)
•	Bazel version (if compiling from source):
N/A
•	GCC/Compiler version (if compiling from source):
VS2017 15.5.7
•	CUDA/cuDNN version:
NVidia CUDA Toolkit 8.0
NVidia CUDNN 5.1
•	GPU model and memory:
N/A
•	Exact command to reproduce:
N/A
Describe the problem:
Tensorflow failed to build due to the error: No module named 'google'. This issue can be reproduced from master revision 90a3db9. This should be tensorflow source issue, could you please help take a look at this? Thanks!
The failures like:
The whole log file please see attachment.
log_x64_build.log
520>CustomBuild:
Traceback (most recent call last):
File "D:/TensorFlow/build_x64/tf_python/tensorflow/tools/api/generator/create_python_api.py", line 26, in
from tensorflow.python.util import tf_decorator
File "D:\TensorFlow\build_x64\tf_python\tensorflow\python_init_.py", line 52, in
from tensorflow.core.framework.graph_pb2 import *
File "D:\TensorFlow\build_x64\tf_python\tensorflow\core\framework\graph_pb2.py", line 6, in
from google.protobuf import descriptor as _descriptor
ModuleNotFoundError: No module named 'google'
520>C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [D:\TensorFlow\build_x64\tf_python_api.vcxproj]
Repro steps:

git clone https://github.com/tensorflow/tensorflow D:\Tensorflow\src
pushd D:\Tensorflow
set PreferredToolArchitecture=x64
set rel=Release
set CUDNN_HOME="C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v9.0\cuda"
set PY=C:\ProgramData\Anaconda3
set CL=/FS /permissive-
cmake D:\Tensorflow\src\tensorflow\contrib\cmake -A x64 -DCMAKE_BUILD_TYPE=Release -DPYTHON_EXECUTABLE=C:\ProgramData\Anaconda3\python.exe -DPYTHON_LIBRARIES=C:\ProgramData\Anaconda3\libs\python36.lib -DSWIG_EXECUTABLE=D:\Tensorflow\swigwin-3.0.12\swig.exe -Dtensorflow_BUILD_PYTHON_TESTS=ON -Dtensorflow_BUILD_SHARED_LIB=ON
MSBuild /m /p:Configuration=Release;Platform=x64 /p:WindowsTargetPlatformVersion=10.0.16299.0 tensorflow.sln /t:Rebuild

Hello, Any update for this?

Hi @cy89, any update for this?

Nagging Assignee @cy89: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Since the addition of the create_python_api.py, it does an import during the build of the pip package which means that you need to have protobuf and absl-py installed in the python environment that you are using to do the build. Ideally, the build of protobuf would be added to the pythonpath but a few additional steps need to be added to the protobuf build need to be performed to get the locally build version to work, so as a workaround I just pip installed protobuf at a version compatible with the constraint in setup.py on master. You will also need to pip / conda install absl-py.

Thanks all for your help. I installed 'google' and 'abs1' modules and Tnesorflow no longer hit this issue.

thanks for the explanation @tambu-j. I pip install protobuf and absl before doing the windows build. Also, I found, for GPU version build, cuda/bin and cudnn/bin needs to be in PATH, otherwise, will have errors like

 File "C:/agent/_work/5/b/tf_python/tensorflow/tools/api/generator/create_python_api.py", line 26, in <module>

2018-05-11T02:49:37.9634660Z              from tensorflow.python.util import tf_decorator
2018-05-11T02:49:37.9636047Z            File "C:\agent_work\5\b\tf_python\tensorflow\python_init_.py", line 49, in
2018-05-11T02:49:37.9636803Z              from tensorflow.python import pywrap_tensorflow
2018-05-11T02:49:37.9638401Z            File "C:\agent_work\5\b\tf_python\tensorflow\python\pywrap_tensorflow.py", line 30, in
2018-05-11T02:49:37.9639141Z              self_check.preload_check()
2018-05-11T02:49:37.9640148Z            File "C:\agent_work\5\b\tf_python\tensorflow\python\platform\self_check.py", line 97, in preload_check
2018-05-11T02:49:37.9641098Z              % (build_info.cudnn_dll_name, build_info.cudnn_version_number))
2018-05-11T02:49:37.9643318Z          ImportError: Could not find 'cudnn64_7.dll'. TensorFlow requires that this DLL be installed in a directory that is named in your %PATH% environment variable. Note that installing cuDNN is a separate step from installing CUDA, and this DLL is often found in a different directory from the CUDA DLLs. You may install the necessary DLL by downloading cuDNN 7 from this URL: https://developer.nvidia.com/cudnn

Nagging Assignee @cy89: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @cy89: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @cy89: It has been 45 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @cy89: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Thanks for the help, @StevenVerne and @tambu-j . I'll close, as it looks like this is resolved.


yum/dnf repo fact

Is there a way to see the yum/dnf repos via '--facts' ?

This isn't currently implemented but definitely one to add.

These are now implemented in https://github.com/Fizzadar/pyinfra/commit/a9cbd96e713277f34925bf53aa7bb1b33817d23c.


build: update default systemd source location

systemd has now moved to GitHub
http://lists.freedesktop.org/archives/systemd-devel/2015-June/032738.html
https://github.com/systemd/systemd/commit/eb0914fc85812570538c37287dd3cfa377289418#diff-c47c7c7383225ab55ff591cb59c41e6bR11

LGTM


pkgs.cabal2nix: build against latest Cabal(-syntax) version to support newer syntax

when creating a project via cabal init -n it generates the cabal file with the latest version of the cabal standard. when running cabal 2nix in with a cabal file generated this way it doesn't produce a nix derivation

People regularly run into this, so it may be something sensible to do. An overlay upgrading Cabal for cabal2nix should only affect pkgs.cabal2nix (and maybe haskellPackages.cabal2nix-unstable), but not haskell.packages.*.cabal2nix, so it remains possible to use it as a library.


[WIP] cmake: Allow shared linking and installation

Allow shared linking by providing the BUILD_SHARED_LIBS option.
Provide a possibility to install Abseil headers and libraries.
Signed-off-by: Michal Rostecki<EMAIL_ADDRESS>

I will need to sync with https://github.com/abseil/abseil-cpp/pull/182, the current shape of this branch is just a quick work I've done to be able to package Abseil in openSUSE.


variants: remove intermediate variants.h

Move common part of variants/variants.h to core arduino/Arduino.h and remove variants/variants.h.
Rename ..._pinmap.h to variants.h.
Remove no needed includes.

BTW, can you update the branch with latest next if you're pushing any new changes?


Runner_deploy-ijar.jar leaks into external libraries

The bazel runner's deploy jar ends up in the external libraries list in the IDE and, because its dependencies are not repackaged, it ends up being a target for click-through type navigation in the IDE. This means, for example, that clicking on ImmutableList ends up going to that jar instead of guava.
Do _deploy.jar or _deploy-ijar.jar make any sense to leak into the External Libraries set? Are they needed for test running from the IDE? If so, can they somehow be deprioritized so that such cross-linking doesn't mis-target them?

This definitely isn't intended. It's likely a bazel-side bug -- these jars shouldn't accessible via JavaInfo.
When we have time, we'll take a look at exactly how these jars are being picked up by the plugin, and either fix it plugin-side or file a bug with bazel

+1. Just want to illustrate how this problem can be annoying.
The other ImmutableList class does contain the source code so every time I have to do a switch to view the source code.

Adding this to .bazelrc already helps:
build --explicit_java_test_deps

How about making it the default?


Product category is not saving

when i set a category for any product and try to save the product it shows:

SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (bagisto.product_categories, CONSTRAINT product_categories_category_id_foreign FOREIGN KEY (category_id) REFERENCES categories (id) ON DELETE CASCADE) (SQL: insert into product_categories (category_id, product_id) values (, 13))

Hi @Mizan-Rifat
run composer dump-autoload
php artisan config:cache

@Mizan-Rifat
Feel free to reopen the issue, Hope the query is resolved.


Fix some warning and add a Linux script to simplify the build

Hello,
Thanks a lot for your nice tool, and sharing your code. I'll study your tool, and try to help if I can. Waiting, I found some little changes like fix some warnings. The change are under MIT license, i.e. for the script.
Feel free to use it, or not, and to do whatever you want of this PR.

Thanks for the contribution.
Btw I think its possible to push with executable permission so that chmod a+x is not needed.
Will merge now and change that.


Add platyPS documentation

Add a tip somewhere, tht custom themes maybe added to themes and it would be a god idea to add this to the powershell profile to make it persitent.

Actually, now that the writer functions have been deprecated, we now only have the Krayon class and its associates, and classes being as they are, don't support PS documentation. The documation for Krayon should be on ghdocs using Jekyll.


Add guards for code that relies on _Concurrency to allow compilation with Xcode 13

Add extra code guards so that Xcode 13 will compile this package on macOS 11, which does not have symbols for Concurrency yet.
Motivation:
Allow compilation with Xcode 13
Modifications:
Changed code guards #if compiler(>=5.5) to #if compiler(>=5.5) && canImport(_Concurrency)
Got the idea from swift-server/swift-service-lifecycle#110
Result:
Successfully compiles with Xcode 13

In case it's of interest, I also have another branch that applies a similar patch to main: https://github.com/programmarchy/swift-aws-lambda-runtime/tree/fix-xcode13

Related: https://github.com/swift-server/swift-aws-lambda-runtime/issues/234

@swift-server-bot test this please

@programmarchy  could you reopen this against the v0 branch? we will track 0.x releases from that branch

@tomerd https://github.com/swift-server/swift-aws-lambda-runtime/pull/237


Can't run e2e tests - server terminated early

Bug Report or Feature Request (mark with an x)
- [ x ] bug report -> please search issues before submitting
- [   ] feature request

Versions.
$ ng --version
    _                      _                 ____ _     ___
   / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
  / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
 / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
/_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
               |___/
@angular/cli: 1.4.7
node: 6.11.3
os: linux x64
@angular/animations: 4.4.5
@angular/cdk: 2.0.0-beta.12
@angular/common: 4.4.5
@angular/compiler: 4.4.5
@angular/core: 4.4.5
@angular/forms: 4.4.5
@angular/http: 4.4.5
@angular/material: 2.0.0-beta.12
@angular/platform-browser: 4.4.5
@angular/platform-browser-dynamic: 4.4.5
@angular/platform-server: 4.4.5
@angular/router: 4.4.5
@angular/cli: 1.4.7
@angular/compiler-cli: 4.4.5
@angular/language-service: 4.4.5
typescript: 2.3.4

Obs:
os says linux x64 but it's actually the WSL (Bash on Ubuntu on Windows). The host os is Windows 10 (Insiders Preview 1709)
Repro steps.
I tried starting a clean project in another directory, with the same results. So I guess:
$ ng set --global packageManager=yarn
$ ng new --style=scss --routing
$ ng e2e

The log given by the failure.
$ ng e2e
** NG Live Development Server is listening on localhost:49152, open your browser on http://localhost:49152/ **
Date: 2017-10-17T00:40:54.581Z
Hash: 562fcb0b1a64fe32f228
Time: 27858ms
chunk {inline} inline.bundle.js, inline.bundle.js.map (inline) 5.83 kB [entry] [rendered]
chunk {main} main.bundle.js, main.bundle.js.map (main) 4.74 MB {inline} [initial] [rendered]
chunk {polyfills} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 217 kB {inline} [initial] [rendered]
chunk {styles} styles.bundle.js, styles.bundle.js.map (styles) 122 kB {inline} [initial] [rendered]

webpack: Compiled successfully.
[00:40:54] I/file_manager - creating folder /mnt/c/Users/henri/workspace/ng-lejour/node_modules/webdriver-manager/selenium
[00:41:32] I/update - chromedriver: unzipping chromedriver_2.33.zip
[00:41:33] I/update - chromedriver: setting permissions to 0755 for /mnt/c/Users/henri/workspace/ng-lejour/node_modules/webdriver-manager/selenium/chromedriver_2.33
[00:41:33] I/launcher - Running 1 instances of WebDriver
[00:41:33] I/direct - Using ChromeDriver directly...
[00:41:33] E/launcher - Server terminated early with status 127
[00:41:33] E/launcher - Error: Server terminated early with status 127
    at Error (native)
    at earlyTermination.catch.e (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/selenium-webdriver/remote/index.js:252:52)
    at process._tickCallback (internal/process/next_tick.js:109:7)
From: Task: WebDriver.createSession()
    at Function.createSession (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/selenium-webdriver/lib/webdriver.js:777:24)
    at Function.createSession (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/selenium-webdriver/chrome.js:709:29)
    at Direct.getNewDriver (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/protractor/lib/driverProviders/direct.ts:90:25)
    at Runner.createBrowser (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/protractor/lib/runner.ts:225:39)
    at q.then.then (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/protractor/lib/runner.ts:391:27)
    at _fulfilled (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/protractor/node_modules/q/q.js:834:54)
    at self.promiseDispatch.done (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/protractor/node_modules/q/q.js:863:30)
    at Promise.promise.promiseDispatch (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/protractor/node_modules/q/q.js:796:13)
    at /mnt/c/Users/henri/workspace/ng-lejour/node_modules/protractor/node_modules/q/q.js:556:49
    at runSingle (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/protractor/node_modules/q/q.js:137:13)
    at flush (/mnt/c/Users/henri/workspace/ng-lejour/node_modules/protractor/node_modules/q/q.js:125:13)
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)
[00:41:33] E/launcher - Process exited with error code 199

Desired functionality.
Run e2e tests.
Mention any other details that might be useful.
It's in a private repo on gitlab, but there's not much stuff there yet anyway, so I can give you access if needed. Also, the same error happened in gitlab's ci/cd. I hadn't write any tests yet, it was there that I got to see the problem first. This is my configuration file for that:
image: trion/ng-cli-karma

cache:
  paths:
    - node_modules/

deploy_stage:
  stage: deploy
  environment: Stage
  only:
    - master
  script:
    - npm install
    - ng test --browsers=ChromeHeadless -sr --progress=false
    - npm run ng e2e --serve=false
    - npm run ng build --progress false --prod --aot --base-href ng-lejour-stage.surge.sh
    - ./node_modules/.bin/surge -p dist/ --domain ng-lejour-stage.surge.sh

Does this happen outside of WSL? That sort of errors is usually due to the environment. You have to setup chrome and your tests properly for that to work. You might have done that for karma with --browsers=ChromeHeadless but you still need to do it for Protractor.
See https://github.com/angular/angular-cli/wiki/stories-continuous-integration for some guidance without using ChromeHeadless. Using chrome headless requires specific configuration as well: https://github.com/angular/protractor/blob/master/docs/browser-setup.md#using-headless-chrome.
CI configuration differs wildly between CI provider so there isn't much help I can reasonably provide. But I can tell you it's usually hard and frustrating to debug problems with chrome on CI, so don't be surprised if it takes a bit of time. As long as it runs in your local environment (non-WSL, because that doesn't have a screen and also needs to be configured like a CI basically), then you should be able to configure CI to make it work.
Also worth mentioning is that in your CI, flags are not being used in npm run commands. You need to do npm run scriptname -- --flag --flagtwo, with the double dashes, to send those args into the command. So npm run ng e2e --serve=false is instead npm run ng e2e -- --serve=false - which won't work, because your app won't be served and thus there is nothing for protractor to connect to.

@herzinger Were you able to fix this?

@wahab054 sorry, it was so long ago I don't remember anything about that


Text Appears Jumbled

Describe the bug
The text appears jumbled on my computer, making the tool somewhat less usable. Screen Shot included.
I would expect this to affect Linux Desktop (GNOME) only, probably something to do with the gtk setup or the like.
To Reproduce
Steps to reproduce the behavior:

Use x11 session (not tested in wayland)
turn on "Large Text" in Accessibility Settings
Open SAM

Expected behavior
I would expect the text to be legible, not jumbled.
Screenshots

Operating System and Version

OS: Ubuntu 21.04 x64_64 5.11.0-25-generic running GNOME 3.38.4 and x11
Version 2020.11.29

Additional context
In the screen shot I see the input fields are dark with dark blue text-- that's not the issue (my GTK theme here is Nordic-darker). The problem is that the text boxes all appear to be too small so it's tough to see what I'm doing.
I can also report the logs often say things like:
Gtk-CRITICAL **: 09:18:41.596: IA__gtk_widget_set_size_request: assertion 'height >= -1' failed

which might have something to do with the problem.
Additionally, I habitually use "Large Text" in the GNOME Accessibility settings -- given the fact I'm currently stuck with a hidpi display, an nvidia graphics card (hence x11), for which fractional scaling is terrible, this is usually a sensible workaround where I can still see what I'm doing. Turning off this setting in GNOME causes everything to render properly.

Same on Linux Mint 19.2 but with no Large Text enabled but Hi-DPI User interface scaling enabled in display options. Returning to normal size makes everything very small but the fonts in SAM become properly scaled

@minimenchmuncher and @sakvaua Thank you for this feedback and for describing the workaround. We are unlikely to have resources to address this but would welcome someone contributing a fix for this.


Hide native tooltips

Describe the bug
We are using a custom react component to render tooltip, we don't need to show the native tooltips generated by the title attribute

Should probably wait for: https://github.com/btzr-io/Villain/pull/86
this pr introduces a new prop for the button ariaLabel and should be used instead of title to hide the default tooltip,


CLI modifies the response from the REST API in unexpected ways

if a rule matches, an activation record is created for it.
the rule does not have a result but the cli shows result: null:
Response body received:
{
  "duration": null,
  "name": "r",
  "subject": "guest",
  "activationId": "50104237f4f74bdf81a13f023cef3b2c",
  "publish": false,
  "annotations": [],
  "version": "0.0.1",
  "response": {
    "success": true,
    "status": "success"
  },
  "cause": "d97865ef7ed047a7a355578b0f68576d",
  "end": 0,
  "logs": [],
  "start":<PHONE_NUMBER>919,
  "namespace": "guest"
}

the cli output:
ok: got activation 50104237f4f74bdf81a13f023cef3b2c
{
    "namespace": "guest",
    "name": "r",
    "version": "0.0.1",
    "publish": false,
    "subject": "guest",
    "activationId": "50104237f4f74bdf81a13f023cef3b2c",
    "cause": "d97865ef7ed047a7a355578b0f68576d",
    "start":<PHONE_NUMBER>919,
    "duration": 0,
    "response": {
        "status": "success",
        "statusCode": 0,
        "success": true,
        "result": null
    },
    "logs": [],
    "annotations": []
}

@rabbah, can you list the steps to reproduce the null result field? I am able to duplicate the issue by just using a trigger with no rule.

wsk trigger create t
wsk action create a --docker a
wsk rule create r t a
wsk trigger fire t
now check activation for r, you'll see null (same as trigger as you noted).

I repurposed this issue and make it more general to reflect the problems with the current cli.
Here it is another example and how to reproduce it. The example has to do with invoking an action in blocking fashion with an action that takes longer than the response timeout for blocking actions (NOTE: do not confuse the response timeout for blocking actions (i.e., how long the http connection is open) with the timeout for running the action (i.e., how long the action will be allowed to run)). Internally, the request will behave as if the action invocation was "morphed" into a non-blocking invocation. The response from the cli should indicate that this request was morphed into a non-blocking invocation.
The response code from the REST API is a 202 and this should somehow be communicated to the cli user.
What happens now (and steps to reproduce)
Create an action sleep using our timeout.js file and set the timeout to 120 seconds:
action create sleep tests/dat/actions/timeout.js -t 120000
Invoke the action blocking fashion:
 action invoke -b sleep -p payload 100000
What I get is this:
ok: invoked /_/sleep with id 81df7ec28bf2480d98942fc85ed134d5
{
    "namespace": "",
    "name": "",
    "version": "",
    "publish": false,
    "subject": "",
    "activationId": "81df7ec28bf2480d98942fc85ed134d5",
    "start": 0,
    "end": 0,
    "duration": 0,
    "response": {
        "status": "",
        "statusCode": 0,
        "success": false,
        "result": null
    },
    "logs": null,
    "annotations": null
}

The activation record is something that the cli made up.
What happens under the cover is this:
(same invocation as above with -v)
[POST]	https://<IP_ADDRESS>/api/v1/namespaces/_/actions/sleep?blocking=true
Req Headers
{
  "Authorization": [
    "Basic MjNiYzQ2YjEtNzFmNi00ZWQ1LThjNTQtODE2YWE0ZjhjNTAyOjEyM3pPM3haQ0xyTU42djJCS0sxZFhZRnBYbFBrY2NPRnFtMTJDZEFzTWdSVTRWck5aOWx5R1ZDR3VNREdJd1A="
  ],
  "Content-Type": [
    "application/json"
  ]
}Req Body
{{"payload":100000}
}
RESPONSE:Got response with code 202
Response body size is 56 bytes
Response body received:
{
  "activationId": "bacdd8898db745c3b8c3cb5c04d969f3"
}
ok: invoked /_/sleep with id bacdd8898db745c3b8c3cb5c04d969f3
{
    "namespace": "",
    "name": "",
    "version": "",
    "publish": false,
    "subject": "",
    "activationId": "bacdd8898db745c3b8c3cb5c04d969f3",
    "start": 0,
    "end": 0,
    "duration": 0,
    "response": {
        "status": "",
        "statusCode": 0,
        "success": false,
        "result": null
    },
    "logs": null,
    "annotations": null
}

As I already mentioned, the activation record is bogus and the response code is lost in translation.

Same command as above, run locally with -d as requested:
[/go-whisk/whisk.NewClient]:070:[Inf] Disabling certificate checking.
[mmands.parseQualifiedName]:096:[Inf] Qualified entityName: sleep
[mmands.parseQualifiedName]:097:[Inf] Qaulified namespace: _
[sk-cli/commands/action.go]:159:[Inf] Parsing parameters: []string{"{\"payload\": 100000}"}
[mmands.getJSONFromStrings]:145:[Inf] Created map 'map[payload:100000]' from '{"payload": 100000}'
[k.(*ActionService).Invoke]:233:[Inf] HTTP route: actions/sleep?blocking=true
REQUEST:
[POST]	https://<IP_ADDRESS>/api/v1/namespaces/_/actions/sleep?blocking=true
Req Headers
{
  "Authorization": [
    "Basic MjNiYzQ2YjEtNzFmNi00ZWQ1LThjNTQtODE2YWE0ZjhjNTAyOjEyM3pPM3haQ0xyTU42djJCS0sxZFhZRnBYbFBrY2NPRnFtMTJDZEFzTWdSVTRWck5aOWx5R1ZDR3VNREdJd1A="
  ],
  "Content-Type": [
    "application/json"
  ]
}Req Body
{{"payload":100000}
}
[-whisk/whisk.(*Client).Do]:209:[Inf] Req Body (ASCII quoted string):
{"{\"payload\":100000}\n"}
RESPONSE:Got response with code 202
Response body size is 56 bytes
Response body received:
{
  "activationId": "e8c7e30373964a328725e51526e4d478"
}
[-whisk/whisk.(*Client).Do]:233:[Inf] Response body received (ASCII quoted string):
"{\n  \"activationId\": \"e8c7e30373964a328725e51526e4d478\"\n}"
[hisk.parseSuccessResponse]:327:[Inf] Parsing HTTP response into struct type: **whisk.Activation
[hisk.parseSuccessResponse]:334:[Inf] Successful parse of HTTP response into struct type: **whisk.Activation
ok: invoked /_/sleep with id e8c7e30373964a328725e51526e4d478
{
    "namespace": "",
    "name": "",
    "version": "",
    "publish": false,
    "subject": "",
    "activationId": "e8c7e30373964a328725e51526e4d478",
    "start": 0,
    "end": 0,
    "duration": 0,
    "response": {
        "status": "",
        "statusCode": 0,
        "success": false,
        "result": null
    },
    "logs": null,
    "annotations": null
}

For the case of the blocking invocation that is internally translated into a non-blocking one, the cli should communicate the change to the user. One way to do it: the response from the cli should be something along the lines:
request could not be satisfied on time, switched to non-blocking invocation.
ok invoked <action_name> with id bacdd8898db745c3b8c3cb5c04d969f3

part of fixing this, please add a test.

@ioana-blue repurposed this issue beyond the fix in #1477.

@rabbah. @ioana-blue, it looks like normal non-blocking action invocations will also return an HTTP status code of 202.

That's correct.

This is fixed.


Editor crashes when selecting AnimatedSprite while on collision shape layer

Godot version
v4.0.beta17.official [c40020513]
System information
MacOS Ventura 13.2, 2.4ghz intel i9, amd radeon 5500m 8gb
Issue description
i was following along the tutorial 'your first 2d game' and after adding sprites to the AnimationSprite2d layer i clicked on the CollisionShape2d layer and Godot hard crashed.
Steps to reproduce
have animation panel up from the AnimatedSprite2d layer and then click on CollisionShape2d layer in the scene list. then click on one of the animations and godot will crash.
Minimal reproduction project
here's a branch of the project as is: https://github.com/denvermullets/demo-gd-redux/tree/bug/crash-branch
includes screenshot of app right before crash and the crash log and a video

Thanks for the report! This was a duplicate of https://github.com/godotengine/godot/issues/72763, fixed by https://github.com/godotengine/godot/pull/72783.