Unable to Upload Multipart File with dio link

Hey,
The file upload with http works fine but the dio has problem
I'll put the details below:
Dependency Versions:
dio: ^5.4.1
ferry: ^0.16.0+1
ferry_generator: ^0.10.0
gql_dio_link: ^1.0.1+1

Serialiser Code:
class UploadSerializer extends PrimitiveSerializer<MultipartFile> {
  @override
  MultipartFile deserialize(
    Serializers serializers,
    Object serialized, {
    FullType specifiedType = FullType.unspecified,
  }) {
    assert(
      serialized is List<int>,
      "FileSerializer expected 'Uint8List' but got ${serialized.runtimeType}",
    );
    return MultipartFile.fromBytes(serialized as List<int>);
  }

  @override
  Object serialize(
    Serializers serializers,
    MultipartFile object, {
    FullType specifiedType = FullType.unspecified,
  }) =>
      object;

  @override
  Iterable<Type> get types => [MultipartFile];

  @override
  String get wireName => 'Upload';
}

build.yaml
targets:
  $default:
    sources:
      exclude:
        - lib/**/**.dart
    builders:
      ferry_generator|graphql_builder:
        enabled: true
        options:
          schema: com|lib/src/app/repository/graphql/schema.graphql
          type_overrides:
            JSON:
              name: JsonObject
              import: "package:built_value/json_object.dart"
            Upload:
              name: MultipartFile
              import: "package:dio/dio.dart"
      ferry_generator|serializer_builder:
        enabled: true
        options:
          schema: com|lib/src/app/repository/graphql/schema.graphql
          custom_serializers:
            - import: "package:built_value/src/json_object_serializer.dart"
              name: JsonObjectSerializer
            - import: "package:com/src/custom_serializers/upload_serializer.dart"
              name: UploadSerializer

Error:
LinkException(DioException [unknown]: null
              Error: type 'FormData' is not a subtype of type 'Map<dynamic, dynamic>' in type cast, #0      DioMixin.fetch.<anonymous closure> (package:dio/src/dio_mixin.dart:510:7)
              #1      _FutureListener.handleError (dart:async/future_impl.dart:180:22)
              #2      Future._propagateToListeners.handleError (dart:async/future_impl.dart:850:47)
              #3      Future._propagateToListeners (dart:async/future_impl.dart:871:13)
              #4      Future._completeError (dart:async/future_impl.dart:651:5)
              #5      _SyncCompleter._completeError (dart:async/future_impl.dart:63:12)
              #6      _Completer.completeError (dart:async/future_impl.dart:27:5)
              #7      Future.any.onError (dart:async/future.dart:613:45)
              #8      _RootZone.runBinary (dart:async/zone.dart:1666:54)
              #9      _FutureListener.handleError (dart:async/future_impl.dart:177:22)
              #10     Future._propagateToListeners.handleError (dart:async/future_impl.dart:850:47)
              #11     Future._propagateToListeners (dart:async/future_impl.dart:871:13)
              #12     Future._completeError (dart:async/future_impl.dart:651:5)
              #13     Future._asyncCompleteError.<anonymous closure> (dart:async/future_impl.dart:737:7)
              #14     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
              #15     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
              )

You probably don't want to store the uploaded file in the graphql cache

What is the FormData type? Would be helpful to see the schema. If FormData is the scalar that you send to the backend, then you should replace Upload with FormData (both in the build.yaml and the serializer wire name).
I can confirm that uploading with Dio works


Ant BMS connection to Goodwe inverter.

Hello.
It's possible to connect Ant BMS to Goodwee inverter with an ESP?
I have a battery with an ANT BMS connected by + and - wires to inverter, don't work in best conditions.
If it's possible, what it's need to put it working?
Inverter is Goodwe GW5048-ES.
Don't have much knowledge about ESP.
Thanks
Nuno Rainha

Thanks for creating this issue! :-) The component retrieves the BMS status (various values) periodically. These values can be exposed as sensor states. If you find a second component supporting your inverter you could forward the values to the inverter. There is no plug'n'play solution available for your usecase.

Thanks for responding.
Soo, can't connect inverter by CAN or UART to the ESP to read those values?
I think the most important value that inverter need is the SOC, because almost all program of the inverter works with that value, and it's the only problem I have this moment, the SOC isn't correct l.
The cycle of charge and discharge, only work's when battery is at 100%, after that the value varieties, and charging/discharging increase that difference.

Ok.
I leave here some informations about configurations on the application.
Only to know...


IntegrityError when fetching certain posts

Thank you for writing and open-sourcing this :)
Here's a problem that only seems to occur with very few posts (e.g. this one), I'm not yet sure why.
Steps to reproduce on a fresh Django instance with an empty database:
from facebook_posts.models import Post
post = Post.remote.fetch('110913442283972_1021774701197837')

This results in
IntegrityError: UNIQUE constraint failed: facebook_posts_postowner.post_id, facebook_posts_postowner.owner_content_type_id, facebook_posts_postowner.owner_id

because the same postowner (the page "Lausch" linked in the post) is inserted two times.
Maybe it has something to do with "Lausch" being linked in both the original and the shared post?

This is the content of the 'to' field returned from the API call - looks like a facebook bug:
 'to': {'data': [{'id': '905630206155003', 'name': 'Panta R&E'},
   {'id': '144089420189', 'name': '((szene)) Wien'},
   {'id': '168546367204', 'name': 'DeWolff'},
   {'id': '95502743056', 'name': 'Lausch'},
   {'id': '288000100959', 'name': 'She and the Junkies'},
   {'id': '107999242559061', 'name': 'p.p.c.'},
   {'id': '126268707417967', 'name': 'Parasol Caravan'},
   {'id': '301294297310', 'name': 'phi'},
   {'id': '188943472383', 'name': 'Posthof - Zeitkultur am Hafen'},
   {'id': '95502743056', 'name': 'Lausch'},
   {'id': '762111853898959',
    'name': "MOTHER'S CAKE • PARASOL CARAVAN • PHI • p.p.c. • Graz"},
   {'id': '866544750088331',
    'name': "Mother's Cake / Parasol Caravan / Lausch"}]}

thanks for the report and solution


What is the Cluster ID in the Private CA update documentation page?

What kind of request is this (question/bug/enhancement/feature request):
Documentation question
Steps to reproduce (least amount of steps as possible):
In the below URL , you provide a command to patch clusters after updating the certs.
Here it says REPLACE WITH CLUSTERID.  I searched in every forum out there on how to find clusterid. Every one talks about getting cluster name but not id.  My cluster is stuck now, as I am in the 3rd step.
But I could not find what is the cluster id we expect here.
kubectl get clusters  <-- gave me blank
->url<-
https://rancher.com/docs/rancher/v2.x/en/installation/resources/update-ca-cert/
->command<-
kubectl patch clusters <REPLACE_WITH_CLUSTERID> -p '{"status":{"agentImage":"dummy"}}' --type merge
Result:
Could not run the command
Other details that may be helpful:
Please mention how to get the cluster id or what input you expect, in the above command.
Environment information

Rancher version (v2.5.5):
Installation option (HA):

It either needs the full CRD name or you are not running it in the Rancher container/pod container (and thus not finding any cluster). The command should be kubectl get clusters.management.cattle.io.


Improve reliability of GossipProtocol under adverse conditions (message loss 50%)

Looks ok for me, but can you write a short description about changes in algo which improve reliabilty?

@myroslavlisniak Added description of proposed improvements

Maybe we can still track infected, but mark member as infected when receive gossip from it, so we definitely know  it is infected?
@antonkharenko  WDYT?

+1

@myroslavlisniak experimenting with this idea now... will see either it will give improvements


feat(math): implement packed field extension

Description
This adds Extension Field of the Packed Field.

@chokobole Is this typo or did you intend? 0453008, rerepresent -> represent.

Should the FromBasePrimeFields() functions in quadratic, cubic, and quartic extension fields also be changed to FromBaseFields()?

Should the FromBasePrimeFields() functions in quadratic, cubic, and quartic extension fields also be changed to FromBaseFields()?

Exactly! GenerateInitExtField() should also be changed, but since they are not used, so I'll just leave a comment!


Bugfix webp encode color mode

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / reffers to the following issues: ...
Pull Request Description
There seems a bug in the WebP Encoding ...
Which SDWebImageCoder encoding always assume the input CGImage is RGBA8888 color mode. See the code here. And if you don't know what color mode is, it's the layout order of R/G/B/A pixel. See Apple-Color Spaces and Bitmap Layout
This will cause, for example, input BGRA8888 image encode a wrong WebP image data, which mass up RGB color channel. This code seems original from me, but at that time I didn't realize this bug because the WebP decoding always output RGBA8888, which the same as encoding color mode we assume... 😓
For example, see the test image which is a BGRA8888 color mode, and the output webp image data's preview image (Which wrongly treat BGRA8888 as RGBA8888)

TestImageStatic.webp

Output webp data's preview image

I find that 4.x contains this bug as well...So maybe I need to create a PR in master branch and merge in 5.x ?

I guess I need to create a PR for 4.x master branch as well ? (Or fix for 4.x master branch first, they merge to 5.x). 😓

Codecov Report

:exclamation: No coverage uploaded for pull request base (5.x@ebfe2ce). Click here to learn what that means.
The diff coverage is 86.36%.

@@          Coverage Diff           @@
##             5.x    #2311   +/-   ##
======================================
  Coverage       ?   69.14%
======================================
  Files          ?       48
  Lines          ?     6619
  Branches       ?        0
======================================
  Hits           ?     4577
  Misses         ?     2042
  Partials       ?        0

Flag
Coverage Δ

#iOS
70.29% <78.78%> (?)

#macOS
67.8% <86.36%> (?)

Impacted Files
Coverage Δ

SDWebImage/WebP/SDImageWebPCoder.m
79.78% <86.36%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebfe2ce...93aea17. Read the comment docs.

😅 Anyone who can review this change ? @bpoplauschi @mythodeia . If available, I can also merge this into 4.x because no API changes and it's a bug...

@dreampiggy I tried to change the base branch to master and merge it there first, but it doesn't work (too many differences). This needs to be propagated to the master branch as well.

@bpoplauschi I'll create a MR later...:)


feat: change default filter in config

It would be lovely if there were a way of changing the default filter (currently (today | overdue)). The easiest way of achieving this would be via the config.yml file.

I would love to do it but I haven't yet learned Rust. But I believe the starting point to be in the following lines:

https://github.com/chaosteil/doist/blob/62933890abac05e82918f536bf39efac3432a66c/src/tasks/filter.rs#L10-L17
https://github.com/chaosteil/doist/blob/62933890abac05e82918f536bf39efac3432a66c/src/config.rs#L16-L31

Sure that seems doable, let me see if I can whip it up real quick and I'll make a new release.

And 0.2.2 is out. Enjoy!


feat: package version management with Changeset

feat: package version management with Changeset
fix #225
Description of changes:

install changeset cli
add changeset github action

Tag a reviewer: @ayoayco
Tasks:

[ ] I have ran the build command to make sure apps are working: npm run build
[ ] I have ran the tests to make sure nothing is broken: npm run test
[ ] I have ran the linter to make sure code is clean: npm run lint
[ ] I have reviewed my own code to remove changes that are not needed

@ayoayco I think changeset is great for version management in monorepo. Although, we must read the docs quite a bit to understand. But, it definitely improve the workflow.
I will start to add changeset bot and github action to automate. It will look something like this PR once setup.

@fazzaamiarso Very interested in this. Looks like it will save us a lot of manual work. 🙏

@ayoayco do you want to try implement changeset manually before adding automation? So, we can get familiar with the commands beforehand.
Manual changeset workflow should be similar to our usual versioning and publishing workflow.

@fazzaamiarso Yup! Does this branch have working changesets cli?

Yes, it's working. It also comes with Github action that automatically creates a versioning PR.
I suggest to read the docs. Here are some useful parts.

release beta, experimental, etc.
cli option
quickstart
some faq

@fazzaamiarso Played around with changesets. Can you resolve conflicts so we can merge this? I want to test further the GH Actions. :)

We're now getting a weird CI error regarding turbo not being found for this branch. Found a discussion and their resolution was this could be a caching issue, but our current CI does not have any caches https://github.com/vercel/turbo/issues/824

Hey @ayoayco Sorry I've been very busy this time around, will get back at you this week.

Hey, no worries! Could you pick it up when you have the time? @fazzaamiarso

Updating turbo in our main branch fixed this. :) Just get the latest main branch and this should be fine.

@ayoayco I'm checking it now

@fazzaamiarso 👍 - I tried some changes but really couldn't make the CI error go away. Was wondering if it's just cached, but after deleting our GH Action caches still there 🤔

@ayoayco I moved the PR to #261. It seems the package-lock conflict is the problem. I fresh installed changeset from the recent main branch and it worked.

Closing this one then


some questions about performs

it is excellent work! I have some questions about your method. The performance produced by the code is 60.2 and 74.3. I notice that it produced by  meta-batch. if i want to reproduce the result of using HT meta-batch, what should I do ?

Hi @ljjcoder,
Thanks for your interest in our work.
The implementation of the HT meta-batch has not been included in the public repository. We plan to make it public later. If you hope to run experiments with HT meta-batch, you may implement it yourself according to our paper. We'll let you know if we add HT meta-batch into this repository.
If you hope for higher performance, you may try the PyTorch code with a deeper backbone (ResNet-25).
If you have further questions, feel free to add more comments or create a new issue.


Latest release in the sidebar

I note that as the latest release in the sidebar is reported version 5.7.6

@nolimits4web As soon as you can, could you take a look?
Thanks.

@nolimits4web I close this issue because I saw that the Releases section in the sidebar has been completely removed.

@DAnn2012 yes, found an easiest fix 😄
But actually doing proper releases requires too complex CI/toolchain, so I decided not to go wit it, as anyway it is not too useful


Line: Matching code style with extend

thanks! a slimmed it down some more.

@giulioz if you want you could add a story for this component, we are working on a storybook in this pr https://github.com/react-spring/drei/pull/34

@gsimone Yes of course, do I need to make a pull request to your repo? Never done a pull request to a pull request 😅


python310Packages.oauthenticator: 16.0.4 -> 16.0.5

Changelog: https://github.com/jupyterhub/oauthenticator/blob/16.0.5/docs/source/reference/changelog.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 249630 run on x86_64-linux 1

28 packages built:

python310Packages.batchspawner
python310Packages.batchspawner.dist
python310Packages.dockerspawner
python310Packages.dockerspawner.dist
python310Packages.jupyterhub
python310Packages.jupyterhub-ldapauthenticator
python310Packages.jupyterhub-ldapauthenticator.dist
python310Packages.jupyterhub-systemdspawner
python310Packages.jupyterhub-systemdspawner.dist
python310Packages.jupyterhub-tmpauthenticator
python310Packages.jupyterhub-tmpauthenticator.dist
python310Packages.jupyterhub.dist
python310Packages.oauthenticator
python310Packages.oauthenticator.dist
python311Packages.batchspawner
python311Packages.batchspawner.dist
python311Packages.dockerspawner
python311Packages.dockerspawner.dist
python311Packages.jupyterhub
python311Packages.jupyterhub-ldapauthenticator
python311Packages.jupyterhub-ldapauthenticator.dist
python311Packages.jupyterhub-systemdspawner
python311Packages.jupyterhub-systemdspawner.dist
python311Packages.jupyterhub-tmpauthenticator
python311Packages.jupyterhub-tmpauthenticator.dist
python311Packages.jupyterhub.dist
python311Packages.oauthenticator
python311Packages.oauthenticator.dist


Fix TravisCI failure 15

This error happened during a TravisCI run.
** Generic server a_filename_mgr terminating
** Last message in was {find_filename,{0,
                                       <<0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,
                                         0,0>>},
                                      "prefix"}
** When Server state == {state,a,a_filename_mgr,"./data.api_smoke_flu2",0}
** Reason for termination ==
** {{badmatch,
        {error,
            {{badmatch,{error,enoent}},
             [{machi_util,increment_max_filenum,2,
                  [{file,"src/machi_util.erl"},{line,168}]},
              {machi_flu_filename_mgr,increment_and_cache_filename,3,
                  [{file,"src/machi_flu_filename_mgr.erl"},{line,237}]},
              {machi_flu_filename_mgr,handle_call,3,
                  [{file,"src/machi_flu_filename_mgr.erl"},{line,150}]},
              {gen_server,try_handle_call,4,
                  [{file,"gen_server.erl"},{line,607}]},
              {gen_server,handle_msg,5,[{file,"gen_server.erl"},{line,639}]},
              {proc_lib,init_p_do_apply,3,
                  [{file,"proc_lib.erl"},{line,237}]}]}}},
    [{machi_flu_filename_mgr,increment_and_cache_filename,3,
         [{file,"src/machi_flu_filename_mgr.erl"},{line,237}]},
     {machi_flu_filename_mgr,handle_call,3,
         [{file,"src/machi_flu_filename_mgr.erl"},{line,150}]},

This is caused because the filename manager assumes that a sequence number file exists and it clearly does not.

A lot of code has changed in the last three weeks.  Is this ticket still valid?

Should be closed for now.


Add model phi

Codecov Report
Attention: Patch coverage is 69.41748% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 74.95%. Comparing base (252cf8c) to head (e6e4be7).

Files
Patch %
Lines

..._experiment/torch_bench/_dort_cmd_common_models.py
44.00%
14 Missing :warning:

...al_experiment/torch_interpreter/_aten_functions.py
56.25%
14 Missing :warning:

experimental_experiment/torch_helper/phi_helper.py
85.45%
8 Missing :warning:

...imental_experiment/torch_bench/_dort_cmd_common.py
58.82%
7 Missing :warning:

...erimental_experiment/xoptim/graph_builder_optim.py
50.00%
6 Missing :warning:

experimental_experiment/xbuilder/graph_builder.py
81.48%
5 Missing :warning:

experimental_experiment/torch_test_helper.py
20.00%
4 Missing :warning:

experimental_experiment/ext_test_case.py
60.00%
2 Missing :warning:

...imental_experiment/xbuilder/graph_builder_opset.py
85.71%
2 Missing :warning:

...ntal_experiment/torch_interpreter/_aten_methods.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   74.95%   74.95%   -0.01%
==========================================
  Files          79       81       +2
  Lines        8793     8944     +151
==========================================
+ Hits         6591     6704     +113
- Misses       2202     2240      +38

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Data packages

1st commit, fixed it so that the code gen would run on CI

fixed a few errors, finished the test, switched the var char 1024 to text, and used MetadataContent everywhere rather than

made the textarea resizable

The backend currently fails if the newly non-required fields (size, filename, hash) are not included. Not sure if that work is in scope for this PR?
Keeping cleanups, and refactoring out of this PR (such as splitting the long form up).

The backend currently fails if the newly non-required fields (size, filename, hash) are not included. Not sure if that work is in scope for this PR?

These Package fields are not required anymore.

Finally to try it out.
The metadata fields are much more usable now. I have noticed however, that some fields still show as mandatory (*) but are not, so they should drop the *.
The flatcar version of the package should keep the required fields as they were before (I think the URL may be have been mistakenly marked as not required).
The way to test is to switch the package type back and forth and tabbing through to see the errored fields.

The metadata fields are much more usable now. I have noticed however, that some fields still show as mandatory (*) but are not, so they should drop the *.

Ok, let me check. Is the schema at backend/api/spec.yaml considered the source of truth? I mean, what's shown there as required should be shown in the form as required?

The flatcar version of the package should keep the required fields as they were before (I think the URL may be have been mistakenly marked as not required).

The filename, hash, and size should stay required for Flatcar packages, but not for the "Other" package type? If so, I'll have to see if that's possible to specify in the schema somehow.
ps. One unrelated issue I noticed is that the create form doesn't show an error when there's an error in the backend. Also the update form simply closes when there is a backend error.

The metadata fields are much more usable now. I have noticed however, that some fields still show as mandatory (*) but are not, so they should drop the *.

Ok, let me check. Is the schema at backend/api/spec.yaml considered the source of truth? I mean, what's shown there as required should be shown in the form as required?

Since the endpoint is the same for all types of packages, I understand we cannot do the distinction in the spec.
However, we can match the spec to the least mandatory type of packages, and then dynamically check it in the function that implements the endpoint.

The flatcar version of the package should keep the required fields as they were before (I think the URL may be have been mistakenly marked as not required).

The filename, hash, and size should stay required for Flatcar packages, but not for the "Other" package type? If so, I'll have to see if that's possible to specify in the schema somehow.

I had already some client-side logic in the branch for that purpose.

ps. One unrelated issue I noticed is that the create form doesn't show an error when there's an error in the backend. Also the update form simply closes when there is a backend error.

Yeah, showing errors to clients in forms is one of the painpoints we currently have in Nebraska. Most of them just show a generic error, making it difficult to understand what exactly was wrong.
We should tackle this in a different PR.

I tried using the OpenAPI discriminator feature which should let us use a different schema based on the type. However, it doesn't seem to work with oapi-codegen. Oh well, that would have been nice. Just going to check that manually in the handler for now.
diff --git a/backend/api/spec.yaml b/backend/api/spec.yaml
index 2d97527..88b305f 100644
--- a/backend/api/spec.yaml
+++ b/backend/api/spec.yaml
@@ -684,7 +684,14 @@ paths:
         content:
           application/json:
             schema:
-              $ref: "#/components/schemas/createPackageInfo"
+              oneOf:
+                - $ref: "#/components/schemas/createPackageInfo"
+                - $ref: "#/components/schemas/createPackageInfoFlatcar"
+              discriminator:
+                propertyName: type
+                mapping:
+                  4: '#/components/schemas/createPackageInfo'
+                  1: '#/components/schemas/createPackageInfoFlatcar'
       responses:
         "200":
           description: Create Package success response
@@ -748,7 +755,14 @@ paths:
         content:
           application/json:
             schema:
-              $ref: "#/components/schemas/updatePackageInfo"
+              oneOf:
+                - $ref: "#/components/schemas/updatePackageInfo"
+                - $ref: "#/components/schemas/updatePackageInfoFlatcar"
+              discriminator:
+                propertyName: type
+                mapping:
+                  4: '#/components/schemas/updatePackageInfo'
+                  1: '#/components/schemas/updatePackageInfoFlatcar'
       responses:
         "200":
           description: Update Package success response
@@ -1161,10 +1175,52 @@ components:
           type: integer
         flatcarAction:
           $ref: "#/components/schemas/flatcarActionPackage"
-
+
+    createPackageInfoFlatcar:
+      type: object
+      required:
+        - application_id
+        - arch
+        - channels_blacklist
+        - description
+        - filename
+        - hash
+        - size
+        - type
+        - url
+        - version
+      properties:
+        application_id:
+          type: string
+        arch:
+          type: integer
+        channels_blacklist:
+          type: array
+          items:
+            type: string
+        description:
+          type: string
+        filename:
+          type: string
+        hash:
+          type: string
+        size:
+          type: string
+        url:
+          type: string
+        version:
+          type: string
+        type:
+          type: integer
+        flatcarAction:
+          $ref: "#/components/schemas/flatcarActionPackage"
+
     updatePackageInfo:
       $ref:  "#/components/schemas/createPackageInfo"

+    updatePackageInfoFlatcar:
+      $ref:  "#/components/schemas/createPackageInfoFlatcar"
+
     updateInstanceInfo:
       type: object
       required:

Seems the proof_of_concept branch was force pushed(on purpose I guess). I'll rebase against the new branch?

Seems the proof_of_concept branch was force pushed(on purpose I guess). I'll rebase against the new branch?

Yes please. Shouldn't be complicated. As we mostly squashed stuff and rebadged with main.

Cool. It should be ready now, with the required fields changes.

@joaquimrocha this should be ready to review.

Cool, thanks.
I'll fix these conflicts.

The weirdness on this branch/PR because of the forced push to proof-of-concept has been fixed.


refactor: clean-up cli

:tada: This PR is included in version 1.0.42 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Error messages for group and member view

When changing enrollment status, approving, editing or deleting groups fails, there were no error messages shown to the user.

Coverage remained the same at 34.806% when pulling 98d88e09a9d58aea278c50642ddcaf5aa5b4232e on ui_error_messages into cea3e8b98206e3f4c635044f11add2aaf9637876 on master.


Fix tests, bump doctrin/orm require, and add Travis config

Updated doctrine require to version 2.3. All tests now passing on PostgreSQL and MySQL for doctrine 2.3 thru 2.5. Added Travis-CI config to test all supported versions of PHP.

Looks good. Merge when ready.


allow newlines in "version"

When using
parser = argparse.ArgumentParser(
    description="foo",
    # formatter_class=argparse.RawTextHelpFormatter,
    formatter_class=RichHelpFormatter,
)

parser.add_argument(
    "--version",
    "-v",
    action="version",
    version=get_version_text(),
    help="display version information",
)

def get_version_text():
    return "a\nb\n\n\nc"

newlines in the output are suppressed. Would be great to allow for those.

Thanks for the issue.
This behavior comes from the argparse implementation of the version action _VersionAction which calls the formatter to render the version text, it is not part of rich-argparse I am afraid. If you use RichHelpFormatter or argparse.HelpFormatter, all whitespace in the text will be normalized to a single space character before it is printed. You can refer to the argparse documentation https://docs.python.org/3/library/argparse.html#formatter-class for more information.
If you don't want the formatter to mess up already formatted text, you can use the RawTextRichHelpFormatter class instead.
Alternatively, if you pass the version as a rich renderable like a Text object, rich-argparse skips the argparse normalization of whitespace and keeps existing newline characters.
Note that runs of more than three newline characters are always truncated to two even with a rich renderable.
import argparse
from rich_argparse import RichHelpFormatter
from rich.text import Text

def get_version_text():
    return "a\nb\n\n\nc"

parser = argparse.ArgumentParser(description="foo", formatter_class=RichHelpFormatter)
parser.add_argument(
    "--version",
    "-v",
    action="version",
    version=Text(get_version_text()),
    help="display version information",
)
parser.parse_args()

For example this code produces:
$ python main.py --version
a
b

c


Exclude API docs from basic authentication requirement

Description
Exclude API docs from basic authentication requirement.
Release notes
Exclude API docs from basic authentication requirement. They are meant to be publicly visible.
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release | database >
[x] Created unit and/or browser tests which fail without the change (if possible)
[x] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[ ] Extended the README / documentation, if necessary

Issue(s) this completes
Fixes #5353

+1 on browser tests, everything else is lgtm

Added a browser test, which was an outstanding idea, as it exposed a bug: only admins could change programs on the API docs. Added api-docs.ts to the applicant-bundle to fix this.
The browser test encountered authentication errors (returning 401 even though it was using AnonymousClient), so I modified the existing regex to exclude the API docs path rather than defining a new pattern/client stanza.


Registration problem

After deploying through docker compose, I start test the client by register a new account. However, here comes the problem (400 bad request), is it due to my wrong configuration?

show the compos file you are using and the platform you are deploying it .....

I just modified the SERVER_DOMAIN and APP_DOMAIN:

If you are using Google Cloud or AWS then have you allowed those ports through the firewall?

Try using the default SQLite database. You are using Postgres.

I have left the postgres configuration commented to take the SQLite as default. Should I configure it explicitly?

I set this but still got the error:

That's strange .. post the log of docker-compose up command.

Yes, it is the problem with the Postgres srever name. I think you are using older version of Docker. Whatever the OS is this, find its IP address.
Tell me the output of ip addr show command.

Then use this as the DB_URL = postgres://postgres:postgrespw@<IP_ADDRESS>:49153/chatgpt
And if it still doesn't work then create a new EC2 instance with Ubuntu 22.04 or Ubuntu 20.04 image.

I tried this, but the problem remains unresolved.

Did it work when you used the default SQLite database?

As for creating a new EC2 instance, I have not tried. Could you please give me some more detailed instructions? Thank you.

Where are you using it right now ? on Which cloud provider and operating system?

Follow this tutorial: I think this is the same. https://www.youtube.com/watch?v=VKDU10gbYVQ

AWS,  Ubuntu-22.04.1

Follow this tutorial: I think this is the same. https://www.youtube.com/watch?v=VKDU10gbYVQ
But it uses DigitalOcean ..so chnage that for yourself..of if you can afford DO then follow this tutorial.

Thank you, I'll take it as a reference.


Make bump ignore release candidates

Fixes #4

Should this PR go into main rather than ZOSOpenTools:bump-libpcre2-version-10.43 ?

Done


Workspace API inheritance

Depends on https://github.com/kcp-dev/kubernetes/pull/26 (will update go.mod/go.sum after that's reviewed & merged).
Add new field workspace.spec.inheritFrom. Setting this lets a target workspace transparently gain the APIs provided by a CRD in the inheritFrom workspace. Storage for any CRs in the target workspace stays in the target workspace's partition of the etcd key space.
Given source and target workspaces as described above:

A user listing CRDs in the target workspace will not see CRDs from the source workspace; they will only see CRDs that live directly in the target workspace
A user doing API discovery in the target workspace will see APIs from the generic control plane (rbac, certs, core v1, etc.), the source workspace (from its CRDs), and the target workspace (from its CRDs)
OpenAPI does not currently display inherited APIs for a workspace (this is a lot harder)

Additionally, any CRDs that are in core v1 (/api/v1) continue to be aggregated into discovery for /api/v1 alongside secrets, configmaps, and so on. The code to do this moved from kubernetes to kcp.

I can't think of anything else

k8s compile error in the version you pull in:
 # k8s.io/kubernetes/pkg/controller/replication
pkg/controller/replication/conversion.go:65:25: cannot use conversionLister{...} (type conversionLister) as type "k8s.io/kubernetes/vendor/k8s.io/client-go/listers/apps/v1".ReplicaSetLister in return argument:
	conversionLister does not implement "k8s.io/kubernetes/vendor/k8s.io/client-go/listers/apps/v1".ReplicaSetLister (missing ListWithContext method)

Bumped kube again w/the new compilation fixes. Fingers crossed


Clean up code significantly

Comment code, add new methods for different stuff, and add more init methods to shorten main class code.

made progress on this in 5964808

This was closed because most of the code has been commented, I will continue with this in future commits


mgmt, Increment versions after preview release of azure-resourcemanager-resources

Also update the codegen version to 4.1.19
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

/check-enforcer evaluate


Reference Resolver on Interface not working

I have an interface type in Graph 1 and an interfaceObject in Graph 2 matching each other (let's say interface A). When a query initiated from graph 2 referencing object from graph 1 with reference resolver, graph 1 will throw exception The apollo gateway tries to resolve an entity for which no EntityResolver method was found even though I have defined the reference resolver in the interface type in Graph 1
Updates:
It looks like EntitiesResolver only tries to locate resolver from ObjectType, but by definition here https://www.apollographql.com/docs/federation/federated-types/interfaces#interface-reference-resolver , resolvers can also be defined in interface type

Hello 👋
Can you provide a link to a github repository that reproduces the issue?

hi @dariuszkuc , sorry I won't be able to provide the github as that's currently under private corporate account, but I debug through it and found issue happens here https://github.com/apollographql/federation-hotchocolate/blob/80a2b4be83d824ed6558efca0e5541aa8b5fe86a/Federation/Helpers/EntitiesResolver.cs#L28 where the EntitiesResolver only looks for resolvers in ObjectType, but I have an ReferenceResolver defined in a InterfaceType class, which should be supported in Apollo 2.0, hope this makes sense


Hi, could you tell me  how can i get the data

could you please tell me  how can i get the data. you said the index of the test data is in test.list. in the test.list  there are some name about .h5. I just get the data from CVC-ClinicDB, CVC-ColonDB , EndoScene-CVC300 , and Kvasir. The data from above dataset is .png. how can i do.  I really appreciate your help.

Hello, I also encountered the same problem. How did you solve this data acquisition problem?


Refactor createIOUTransaction to RequestMoney

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/211961
Tests
Let's do this!

In Newdot, open an existing chat with no IOUs and request money:

The request should show immediately with the correct amounts. After a few seconds, nothing should change:

Try adding more requests in the same chat. They should all show up immediately and correctly, and the total should get updated:

Now, try requesting money from the big + button and choose someone with NO chat with you.

A new chat should be created immediately and the money request should show there normally.

Go offline.

Repeat steps 1-5. Everything should work the same, but the created IOUs should show semitransparent:

Go back online. The IOUs should go back to full opacity

PR Review Checklist

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps
Same as tests

[x] Verify that no errors appear in the JS console

Removing my review request as I'll be OOO all next week. Grab someone fresh with pullerbear when this is ready!

OFF WIP

Looking further into the issue I pointed out here, the onyx data is almost identical, other than the iouReport total & cachedTotal, and the reportAction. It seems like the offline IOU failed due to the error:
User A | User B chatReport

User A | User B iouReport

User A | User B reportActions

Additionally, we should probably remove the 'You are offline' message, as it shouldn't matter any more:

Ah, I thought it'd be nice to have the info there. Maybe in gray instead of red?

Mostly working well, but I'm unable to view the chat report after performing these steps:

As user A, find an existing chat with user B
As user A, switch off network connection
As user A, send a request of any amount
As user B, send a request of any amount
As user A, switch on the network connection
I was redirected, and the chat report will no longer display for user A due to the following error:

Additionally, we should probably remove the 'You are offline' message, as it shouldn't matter any more:

I can't seem to reproduce this issue. @mountiny, do you see it too?
Other comments addressed!

@Gonals @Julesssss I havent been able to reproduce this issue, but for some weird reason even if I set in the network tab to Offline, the user A who was supposed to be offline got the money request from user B when I made it.... but it showed it is offline, I dont know what happened there (not a problem with this PR haha)

I use a nice Chrome Extension (Offline Mode) that might help

I am getting some weird behaviour when trying to request money from user I never chatted with then I am offline.

As user A go offline
from Global create, request money from user you have never chatted with
this should create the new chat which it does, there is the pending skeleton ui showed:

The chat is not listed in LHN (not sure if we can fix this easily, but I would expect this as part of the offline behaviour - or this might be part of the LHN refactor @stitesExpensify is working on)
Cannot request more money in that chat, the option does not show (I think it should show as this should behave as if I am online)

go online
the chat should show up as normal, but:
I get the request message twice even if I have requested just once (the total is correct in there) and the skeleton ui is still there

Refreshing does not help, here are some errors from console:

This feels like some of the optimistic data is not propagating to UI as we would expect and also the double Requested action feels like either we might have some stale reportAction data or idk

Hmmm. Interesting. I think the LHN changes are for a later time. Other offline behavior (like deleting a workspace) is not being reflected in the LHN yet.
I'll investigate the rest of it, though!

Hmmm. Interesting. I think the LHN changes are for a later time. Other offline behavior (like deleting a workspace) is not being reflected in the LHN yet.

That makes sense, also this might be more in scope of the LHN refactor.

Hmmm. Interesting. I think the LHN changes are for a later time. Other offline behavior (like deleting a workspace) is not being reflected in the LHN yet.

That makes sense, also this might be more in scope of the LHN refactor.

I use a nice Chrome Extension (Offline Mode) that might help

Nice gonna try it!

I can no longer reproduce the issue I reported previously, but I have one last issue:
Should the IOUPreview always show as pending when going offline? I think not, because it has already been received by the receiver:

Yup! Somehow that was hardcoded and I found it while investigating @mountiny's issue. Should be a quick fix

Created issue for now: https://github.com/Expensify/Expensify/issues/229602

Putting this on HOLD for Expensify/Web-Expensify#34756 to hit production.

We can test against staging now, can't we?

Let us know when this is ready for a review again 🙌

so whatever happens in the incognito tab still shows in the non-incognito offline one.

The chrome extension you shared the other time also does not work?

Maybe we could get this https://www.stolp.com/pages/for-homes/ :trollface:

In any case, this is as ready for review as I can make it! Go for it! 😁

Nice work! The only issue I see is that my offline pending IOUs are overwriting each other, instead of showing as unique requests in the chat. Notice that the IOUPreview is overwritten, but the total does update correctly.
A) Before making additional request
B) After making additional request
Does anyone else see this, or is it just me? I thought that it could be due to my env being out of date, but I believe I'm on the latest Auth and Web-E commits and I did rebuild Auth:
Auth: 1beac313ea717555f5dac4c0562346e51bc7d78e Web-E: 2af1b547193b822cae6ebe7d69defbcffe5f8010

Ah, nice catch! I bet this is caused by the new way I'm trying to get the optimistic IDs for the actions. Looking into it!

Yep, the sequence number was it! Comments addressed and ready for re-review!

A) The IOU comment is ignored when I make an IOU request

Ah! B is going to be a pain to figure out. Let's see what I can do.
Working on them!

@Julesssss both bugs should be fixed now! Ready for review again!

I have got this error

And seeing this in the chat

That was the first one create offline, haven't experienced it later and it was fixed when signing out and signing back. Not ideal tho
When creating the request offline, the email is used instead of name (in the previous ones the name was used)

Hmmm. Seems like something weird is going on on the Web side and we are not correctly handling offline messages anymore, and that's causing the issues @mountiny is seeing.
Currently very confused about everything. Looking into it

Left a comment with testing experience above, it is looking real good, I know this is getting very long but you are doing great job Alberto! 🎉 thanks for getting through this!

I saw! Something is wrong on the backend and Onyx is not getting updated for offline messages after we go online. I'm seeing issues in various flows, not only this one, though, so i worry there's something else afoot

@Gonals Also I think for the sake of completeness in the test steps, we have:

Repeat the previous steps. Everything should work the same, but the created IOUs should show semitransparent:

But in the previous steps when you are online you can use the global Create button, which cannot be used while offline so we should update the tests accordingly.

@mountiny, I think something weird was going on the other day. I can no longer reproduce issues 1 and 3.
Issue 2 (the one with the name) was an existing issue. The name gets correctly updated from the backend, but the optimistic action is created using the email, because the name isn't really available to us at the time of action creation.
How do you feel about having that as a NAB and I'll create a clean-up issue for it, since it is mostly cosmetic? Mainly to try and get this functionality out of the door without fattening the PR any more 😅

How do you feel about having that as a NAB and I'll create a clean-up issue for it, since it is mostly cosmetic? Mainly to try and get this functionality out of the door without fattening the PR any more 😅

That is good for me, can you create that issue please and leave it in a comment here? Thank you 🙇

Issue 2 (the one with the name) was an existing issue. The name gets correctly updated from the backend, but the optimistic action is created using the email, because the name isn't really available to us at the time of action creation.

Done! https://github.com/Expensify/Expensify/issues/233534

@mountiny, I'm correctly seeing the optimistic requests in the modal:

This is while offline, after the optimistic $199 request. On a side note, I was seeing some weird behavior and an npm install seemed to fix it.

Nevermind. I got to reproduce the issue afterwards. Fixed!

 Otherwise, we can probably merge today!

Comments addressed!

Let's try our best to get this merged today!

@Gonals Did you retest the flow after these changes, there was quite a few of them so I feel like we should give it proper test again.
Code looks good to me, nice improvements suggested by Carlos

I works MOSTLY well... except the IOU always goes translucent after going offline AGAIN.
Why is that the issue that keeps showing up?
Anyways, working on it.

except the IOU always goes translucent after going offline AGAIN.

Somewhere we must be loosing the update which removes the pending action

Thanks for addressing my comments. I had a few issues testing this, but maybe I'm holding something wrong:

Use the global create to request money from someone you already have a chat with. I did see a CORS error here that prevented AuthenticatePusher from returning a 200 (maybe there was something wrong with my setup) , but I also saw the errors in the video below:

web-issue2.mov
2. Requesting money from the same user didn't seem too update the IOU total:
web-issue1.mov
3. Using the global create to request money from a new user creates the chat, but there is no avatar and name in the chat header or created action and no Request money option is visible from the chat +. Additionally, I see some console errors:
web-3.mov

Goddamit -.-
Number 2 I can't reproduce, but IOU requests from global create are now completely broken for me. The fun part of having a branch for so long is that things keep breaking around it 😢 .
Looking at the ChatReport creation PR, I think I know the issue, but I'm not sure how to go about it.
I now realize that optimistic chat creation is happening even while online. That's not good, since it is still not refactored, and the discrepancies are part of what's causing the issues.
Our options:

Disable IOU request from global create for now, so that we'd never try to optimistically create a chat. When chat creation is refactored, we'll re-add it.
I can try to keep it and make it work as nice as possible.
We can just wait until chat creation is refactored and then update this to work with it.

I think 2 would just be a waste of time, since I'd need to redo everything after chat creation is in.
I'm partial to 1, if only because this branch has been around for over a month and it'd be nice to start one with a clean slate, instead of adding another 30 commits to this one.
If we decide on 3, I can live with it

We can just wait until chat creation is refactored and then update this to work with it.

I think the code in the refactor has been approved and tested, the only reason it wasnt merged is that we are updating php and we havent got the refactor web PR to production so we are waiting for that.
That being said, I think we can safely take that PR as done and incoporate whatever needs to be updated in this PR already

I agree with @mountiny

Ok everyone! This in now handling the full flow! IOUs can be created from the main + button while offline and things seem to be looking good!
I'm getting some CORS messages in the console, but they are for other commands, so they are probably just some PHP 8.1 thing!
Please give it another full round of testing, as now we have EVEN MORE stuff that can break

Comments addressed!
Every flow seems to be working fine, BUT I sometimes get CORS issues that break stuff. They don't seem to be specific to the flow, as I also get them in other offline flows 🤷

Screenshots

![Simulator Screen Shot - iPhone 13 - 2022-10-21 at 17 23 01](https://user-images.githubusercontent.com/10736861/197247112-7cb52760-e6d1-406e-99d9-922169c32d99.png)

Comments addressed! Let's see if we finally get rid of this! 😁

Fixed and ready for re-review!

Comments addressed and tested! The badge (and the IOU total thing) goes away when the IOU is zero! Ready for review again!
Screenshot:

Asked here to get testing and review from cplus

Asked here to get testing and review from cplus

Thanks! Hopefully we are wrapping up!

@Gonals I noticed the bug in my split bill PR too and updating the report with lastMessageText and lastMessageHtml like I did here solves the issue

@luacmartins, I could not reproduce the issue, but updating the lastMessage won't hurt and will get the optimistic report closer to the actual thing, so I did it anyways. It seems to test well!

Gonna merge this since @mountiny and @Julesssss had approved it already. At this point, any issues that come up (aside from the known issues I mentioned above) should be minor and can be addressed as a polish follow up. Thanks for hanging on to this @Gonals! Awesome work!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Oops I should've left a comment here, @mountiny had asked for C+ review here
I was reviewing this now.

@Santhosh-Sellavel feel free to leave any post merge reviews. If you catch anything, we can open up issues to address any issues.

🚀 Deployed to staging by @luacmartins in version: 1.2.20-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Great work @Gonals, I think you should take the rest of the day off to celebrate

🚀 Deployed to production by @chiragsalian in version: 1.2.20-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Sorry for the delay, since this is merged, focused on other issues.
Since this is deployed. Tested on staging but fails, and ran into something went wrong.
Steps:

Open a chat without an IOU
Create a couple of IOU Requests
Go offline
Create one more IOU
Now creating an IOU with User Never chated
Added on more to same.
Go Online

A Red dot appeared on those chats. Shows an error, refer video for more.
https://user-images.githubusercontent.com/85645967/198900142-f65a4330-0bd9-4725-83ee-e9269ac7c829.mov

Sorry for the delay, since this is merged, focused on other issues.
Since this is deployed. Tested on staging but fails, and ran into something went wrong.
Steps:

Open a chat without an IOU
Create a couple of IOU Requests
Go offline
Create one more IOU
Now creating an IOU with User Never chated
Added on more to same.
Go Online

A Red dot appeared on those chats. Shows an error, refer video for more.
Desktop.mov

what about this one
@mountiny ?

@Santhosh-Sellavel Can you report this in the Slack channel, that might be the best way forward. Thanks!

Hey! @Gonals (that's me!) @mountiny @Julesssss @luacmartins, this introduced a bug here:  https://github.com/Expensify/App/issues/13511

👋 Hey y'all! Some of you are aware since I tagged you when initially working on the bug, but for everyone's benefit and to complete the Bug Zero checklist: this PR resulted in a bug here https://github.com/Expensify/App/issues/12432


xpra: "ValueError: Namespace Gtk not available" (gobject-introspection vs gtk3)

Describe the bug
Any (client-side) xpra command results in an error (failing to use gtk3 via gobject-introspection).
Steps To Reproduce
$ xpra
xpra main error:
Traceback (most recent call last):
  File "/nix/store/lmawgjvinhb1qkbg04pis8sn54ws6436-xpra-4.3.3/lib/python3.10/site-packages/xpra/scripts/main.py", line 142, in main
    return run_mode(script_file, cmdline, err, options, args, mode, defaults)
  File "/nix/store/lmawgjvinhb1qkbg04pis8sn54ws6436-xpra-4.3.3/lib/python3.10/site-packages/xpra/scripts/main.py", line 420, in run_mode
    return do_run_mode(script_file, cmdline, error_cb, options, args, mode, defaults)
  File "/nix/store/lmawgjvinhb1qkbg04pis8sn54ws6436-xpra-4.3.3/lib/python3.10/site-packages/xpra/scripts/main.py", line 516, in do_run_mode
    check_gtk()
  File "/nix/store/lmawgjvinhb1qkbg04pis8sn54ws6436-xpra-4.3.3/lib/python3.10/site-packages/xpra/scripts/main.py", line 317, in check_gtk
    gi.require_version("Gtk", "3.0")
  File "/nix/store/gipin543iy3insvp27jp1f4cycjcsm1h-python3.10-pygobject-3.42.2/lib/python3.10/site-packages/gi/__init__.py", line 126, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Gtk not available

Additional context
Looking at similar issues, these are likely related:

#183609
#183865
#184583

They seem to all have been fallout from this PR:

#177538

Notify maintainers
@Artturin
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.58, NixOS, 22.11 (Raccoon), 22.11pre397509.168d1c57890`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.10.3`
 - channels(root): `"nixos"`
 - channels(eddy): `"home-manager"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

As a workaround, doing this in ~/.nixpkgs/config.nix seems to work:
{
  packageOverrides = super: {
    xpra = super.xpra.overrideAttrs (orig: {
      nativeBuildInputs = orig.nativeBuildInputs ++ [super.gobject-introspection];
    });
  };
}

Trying this specifically was inspired by:

#184567

I am very likely to forget about this btw (just wanted to get this working somehow so I can GC the old generation), so feel free to open a PR if you run into this (should just require adding gobject-introspection to xpra's nativeBuildInputs).


Thrift file missing

Hello,
I'm trying to create a .net sql connector but the Thrift file is missing.
Could you provide it please

Hi @aminebizid, we don't officially support .Net for Databricks thrift. Have you tried to use the open source version?
https://thrift.apache.org/lib/netstd.html

Hi @andrefurlan-db
Thanks for your response
I'm using https://thrift.apache.org/lib/netstd.html but I just need the .thrift file you are using to generate the code

closing this issue as we can't provide the file yet. Next year we'll probably work on a .Net connector for Databricks.


Add CNAME.

“Custom domain” must be set in repo settings, if it isn't already.

“Custom domain” must be set in repo settings, if it isn't already.

Doing so causes this PR to have merge conflicts, since doing so makes this exact change. We can just merge this.

This has now caused a redirect loop between caskroom.io and caskroom.github.io. Is “Custom domain” set yet?

Is “Custom domain” set yet?

It is. Like I said, that’s what this change does. See my recent commits caused simply by setting/removing that option.
Rather what must be missing is correctly setting the DNS records since currently the domain is just a redirect (forgot about that). @phinze has to be the one to make that change, since he owns the domain.
In the meantime, will revert so the site works again.

Yeah, I just assumed the CNAME record was already set.


Add: Canal Trece

Channel Name
Canal Trece
Alternative Names (optional)
Canal 13
Network (optional)
No response
Owners (optional)
No response
Country
CO
Subdivision (optional)
No response
City (optional)
Bogota
Broadcast Area
c/CO
Languages
spa
Categories (optional)
music
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://canaltrece.com.co/
Logo
https://pbs.twimg.com/profile_images/468573511573729280/qnzXHED7_400x400.jpeg
Notes
https://canaltrece-live.logicideas.media/canaltrece-live/smil:live.smil/playlist.m3u8

Already in the database: https://iptv-org.github.io/channel?id=Trece.co


How to correctly organize array of objects form?

Bug, Feature, or Question?
Question
At the moment there is only one example of FieldArray which handles array of strings.
https://github.com/jaredpalmer/formik#fieldarray
Is it possible to implement an array of objects? In case each of friends has firstName, lastName and age for example.
What is a proper way to do it?

@latviancoder thank you very much, it works!

@latviancoder Are you able to set initialValues using your approach? I'm currently using redux-form which doesn't seem to have support for initialValues + array of objects, so if Formik support it, I might as well move to Formik.

Yes you can, take a look at documentation :)

The documentation only has simple arrays but anyhow, I managed it with redux-forms. The trick was to not use FieldArray :smile:. Here's a CodeSandbox, if anyone comes looking for a similar solution.

@latviancoder  how is it that friends.${index}.age should work as the input name when you pushed { name: '', age: '' } ?
If this is how things are supposed to work, then this is clearly not in in docs.

@jaredpalmer help?

You can use dots or brackets for nested things. friends.0.name is the same as friends[0].name

@jaredpalmer that's awesome, I think it'd be good to include the above code snippet into README. I don't mind doing a PR on this today if needs be. What do you think?

Yeah sounds good.👌

@jaredpalmer thanks for your help! 😄

@latviancoder @jaredpalmer Is it possible to combine the creation of a new element with an existing<FieldArray />?
In the same example @latviancoder posted, the button to add a new element into the array has this handler onClick={() => arrayHelpers.push({ name: '', age: '' })} from below:
<Form>
    <FieldArray
        name="friends"
        render={arrayHelpers => (

                {values.friends.map((friend, index) => (

                        <Field name={`friends.${index}.name`}/>
                        <Field name={`friends.${index}.age`}/>
                        <button
                            type="button"
                            onClick={() => arrayHelpers.remove(index)}
                        >
                            -
                        </button>

                ))}
                <button
                    type="button"
                    onClick={() => arrayHelpers.push({ name: '', age: '' })}
                >
                    +
                </button>

        )}
    />
</Form>

In this example this would just push { name: '', age: '' } element into the array of friends.
However, what if my form is a bit more complex, in that I want to render fields for the new element that I want to push into the array of this.props.values.friends.
The code that I imagine/hope for would be something like this (which I realize doesn't make much sense):
<Field name={`friends.${indexToBeAdded}.name`}/>
<Field name={`friends.${indexToBeAdded}.age`}/>

Currently what I have to do is create a separate set of fields for the new element..
<Field name={`new_friend_name`}/>
<Field name={`new_friend_age`}/>

Which means I have to have separate validation for those new fields new_friend_name and new_friend_age, and add a special handler that will add the new element into the existing this.props.values.friends using this.props.setValues upon successful validation.
Is there a more elegant way to accomplish this?

What about arrays with useFormik?
I have already used useFormik and now kinda confused of how to make arrays of components from initialValues, the values are updating but the component doesn't.
Please help

what if the array of objects is coming from a parent form using withFormik.  We cannot take "values.friends.map" right.Can anybody help.


reopen or recover  the tabs but not clear the list

Hi, this is a very good extension. sometimes i reopen the tabs which cached by this extension, but i cannot read them all, so i need restore the tabs again. i want to reopen the tabs but keep them on the list, so i can reopen them next time, and don't click the button to restore before leave the chrome.

sorry, forget it. i tried the pin  function, that's the feature what i want.


no need to get logger again

just a minor beautification

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #195   +/-   ##
=========================================
  Coverage     19.78%   19.78%
  Complexity      223      223
=========================================
  Files            64       64
  Lines          2654     2654
  Branches        240      240
=========================================
  Hits            525      525
  Misses         2071     2071
  Partials         58       58

Impacted Files
Coverage Δ
Complexity Δ

...sha/yad/commons/DockerPullImageListenerLogger.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17954d8...2e89766. Read the comment docs.


ci: run integration tests on main and schedule

Right now we only run tests on PRs, but it is useful to also run them on main and on schedule, so internal and external contributors could have a frame of reference for their changes and general health of the project (e.g. some 3rd party dependency updated and broke something or our service broke over the weekend/night etc).
Note that at any given moment there will only be 1 worker running integration tests for commits from main, so we shouldn't waste much resources even during fast merge pace.

@chamini2 Great question! Thought about creating a slack alert (might do after this), but at the very least I will be keeping an eye while I'm doing stuff around this project and will make sure to fix or escalate if the problem is external. It is in my interest as a contributor. 🙂

I like this and enable that by default on my pubic repos. Normally I put the workflow badge on the readme so u can see when it's busted. We could also set the notification email to our mailing list so we all get notified


OOP school library

Project milestone: add Person, Student and Teacher classes
In this PR the following was implemented:

Created a person class
Created student class
Created teacher class

_Cheers Happy Review 😃 _

Hey @sja-thedude
Thank you 👍


plasmablast

We have at least 12 alleles that mention "plasmablast" in the notes. Most seem to be annotated to an immature B cell term (mostly number related terms from what I checked). I suggest adding a terms for plasmablasts, at the least a morphology term.
Plasmablast is in the Cell ontology (CL:0000980). The description includes that these develop from mature B cells so the current MGI annotations are incorrect.
CL definition "An activated mature (naive or memory) B cell that is secreting immunoglobulin, typified by being CD27-positive, CD38-positive, CD138-negative."
Sue

New terms added:
abnormal plasmablast morphology MP:0013939
abnormal plasmablast number  MP:0013940


Integrate with other system

[ ]  SonarCloud
[ ]  Codefactor

[ ]   SonarCloud
[ ]   Codefactor

@Lomet could you please add these two systems to the repository


Why not set ContentResponse.Position back to 0 after sdk deserializes the response

Curious why after the SDK reads the ContentResponse, it doesn't set the Position back to 0 in case the user wants to get the raw response and read it.
I see there is a sample here.
Context: Question from one of our FR customers that was thinking that the SDK doesn't allow for them to access the raw response.
Will put the issue in the FR label for now just to keep track of it

@pakrym I'm sure there is a reason, could you comment here?

I'm sure there is a reason, could you comment here?

It's not something we spent time considering, honestly. It's not always possible to reset the stream (in cases where it's not buffered) so I guess we decided not to even try.
On a positive note, a new property is being added to Response in https://github.com/Azure/azure-sdk-for-net/pull/19417. The Content property would represent the entire buffered response and would not be susceptible to the rewinding issue.

Oh that is pretty cool! Will look into it.
I don't see a clear action item in this issue so will close it


Issue 954 mapper performance

Fix for #954

What are we trying to accomplish with this PR? It looks like a lot of complexity just to avoid calculation of a lookup table. How expensive is that operation?

I profiled the current master branch and this feature branch. I'm measuring within a _paintGL() function call, how much percentage time is spent on querying this LUT. The test operation is DVR on a 512^3 data.
The first screenshot is the master branch result.

The 2nd screenshot is the feature branch result:

This is some serious performance difference, and for this particular test on cisl-vapor, there's some noticeable interactivity improvement.

OK. But how much time is it taking (in seconds, for example)?

On Aug 27, 2018, at 3:30 PM, Samuel Li<EMAIL_ADDRESS>wrote:
I profiled the current master branch and this feature branch. I'm measuring within a _paintGL() function call, how much percentage time is spent on querying this LUT. The test operation is DVR on a 512^3 data.
The first screenshot is the master branch result.
The 2nd screenshot is the feature branch result:
This is some serious performance difference, and for this particular test on cisl-vapor, there's some noticeable interactivity improvement.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.

John Clyne
National Center for Atmospheric Research
303.497.1236 (w),<PHONE_NUMBER> (c)
<EMAIL_ADDRESS>

Cisl-vapor: mostly between 0.006 and 0.008.
Geyser: mostly between 0.012 and 0.014.

Then I would say that it has no discernible impact on frame rate and we should leave it alone. The params classes maintain state in an Xml database and caching results internally is tricky and error prone.

On Aug 27, 2018, at 11:54 PM, Samuel Li<EMAIL_ADDRESS>wrote:
• Cisl-vapor: mostly between 0.006 and 0.008.
• Geyser: mostly between 0.012 and 0.014.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.

John Clyne
National Center for Atmospheric Research
303.497.1236 (w),<PHONE_NUMBER> (c)
<EMAIL_ADDRESS>

The impact on frame rate, it's actually quite discernible...
But of course, we'll need to make sure the fix works correctly, and doesn't break other parts.
With the very fast single-core CPU on cisl-vapor, here are frame rates with and without the optimization.


Upgrade Flask from 0.10.1 -> 0.11.1 -> 0.12.1

Currently, the most stable release is 0.12. (http://flask.pocoo.org/docs/0.12/changelog/)
And not sure whether we should jump to 0.12 or we should go from 0.10 -> 0.11 ->0.12
Relates: https://github.com/CCI-MOC/hil/issues/975

it's odd that the obmd migration tests are failing :/

I suspect the test failures are due to the change in https://github.com/CCI-MOC/obmd/pull/10; we need to add the DB info to the config file we're generating there.
I'd say let's upgrade straight to 0.12.

Pull Request Test Coverage Report for Build 1743

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.07%) to 59.273%

Totals

Change from base Build 1718:
-0.07%

Covered Lines:
2103

Relevant Lines:
3548

💛  - Coveralls

Coverage is decreased because we never test the setup.py file?
I don't have the hil pypi creds but should we add a test for testing pip install hil?
Not sure whether adding this in travis would make more sense?

The coveralls actually shows there is no change in coverage percentage. However, the check fails here on GitHub. I will restart the build and see whether it fixes.


Invoke setup on Windows fails fixed

Describe your changes
fixed by running the command without eval on windows
added import platform
Issue ticket number and link
Closes #180
Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added thorough tests (when necessary).
[x] I have added the right documentation in the docstring and changelog (when needed)

:books: Documentation preview :books:: https://jupysql--241.org.readthedocs.build/en/241/

Please ensure the CI is passing

ok so the check-for-broken-links is failing  (don't know why yet) but this is unrelated to the PR so we can ignore it.
@yafimvo @neelasha23 I think you have windows, right? can either of you test it?

@yafimvo @neelasha23 I think you have windows, right? can either of you test it?

I work on Mac

tested it on windows 11 - worked for me
invoke setup

invoke setup --version 3.7

learning a lot by contributing into this repository.
Thanks for help


gen_anchors.py Error :  ValueError: empty range for randrange()

I receive this error when trying to generate anchors from my racoon- updated config file. Do anyone know what the problem might be?
C:\Users\OMB\Activity Detection\Script\keras-yolo3-master>python gen_anchors.py -c config.json
Traceback (most recent call last):
File "gen_anchors.py", line 132, in
main(args)
File "gen_anchors.py", line 111, in main
centroids = run_kmeans(annotation_dims, num_anchors)
File "gen_anchors.py", line 57, in run_kmeans
indices = [random.randrange(ann_dims.shape[0]) for i in range(anchor_num)]
File "gen_anchors.py", line 57, in
indices = [random.randrange(ann_dims.shape[0]) for i in range(anchor_num)]
File "C:\Users\OMB\AppData\Local\Programs\Python\Python36\lib\random.py", line 189, in randrange
raise ValueError("empty range for randrange()")
ValueError: empty range for randrange()
I also attached the information from my config.json file:

{
"model" : {
"min_input_size":       352,
"max_input_size":       448,
"anchors":              [10,13,  16,30,  33,23,  30,61,  62,45,  59,119,  116,90,  156,198,  373,326],
"labels":               ["raccoon"]
},
"train": {
    "train_image_folder":   "C:/Users/OMB/Activity Detection/Script/keras-yolo3-master/train_image_folder/",
    "train_annot_folder":   "C:/Users/OMB/Activity Detection/Script/keras-yolo3-master/train_annot_folder/",
    "cache_name":           "raccoon_train.pkl",

    "train_times":          8,
    "batch_size":           16,
    "learning_rate":        1e-4,
    "nb_epochs":            100,
    "warmup_epochs":        3,
    "ignore_thresh":        0.5,
    "gpus":                 "0,1",

    "grid_scales":          [1,1,1],
    "obj_scale":            5,
    "noobj_scale":          1,
    "xywh_scale":           1,
    "class_scale":          1,

    "tensorboard_dir":      "logs",
    "saved_weights_name":   "raccoon.h5",
    "debug":                true
},

"valid": {
    "valid_image_folder":   "",
    "valid_annot_folder":   "",
    "cache_name":           "",

    "valid_times":          1
}

}

@paulbauriegel @kiakia2
After resizing to image size of 416 using : out_string += str(int(anchors[i,0]*416)) + ',' + str(int(anchors[i,1]*416)) + ', '， the anchors for raccoon data is much larger than the give values. As follows:
average IOU for 9 anchors: 0.84
112,103, 152,158, 178,233, 207,324, 224,180, 250,261, 306,384, 313,215, 362,276
Have you tried gen_anchors on raccoon dataset?

Hey @kiakia2 has there been any progress on this? Did you find a fix? I'm having the exact same issue

I also have the same problem, finally found out is the path error! Double check your path ,The final path should go to your images.


Implement native contracts in SVM

0x1: ecrecover
0x2: sha2 256
0x3: ripdemd 160
0x4: identity function

Move to laser-ethereum.


Weather Forecast: Provide a multi-day weather forecast for the selected location.

Is your feature request related to a problem? Please describe.
Yes, the current application provides current weather data, but users are also interested in having a multi-day weather forecast for the selected location.
Describe the solution you'd like
I would like to see a feature added to the application that provides a multi-day weather forecast for the selected location. This would allow users to plan for the upcoming days and make informed decisions based on the expected weather conditions.
Describe alternatives you've considered
One alternative could be integrating with a weather API that provides multi-day forecasts. However, it would be more convenient to have this feature built into the application to keep the user experience seamless.
Additional context
Adding a multi-day weather forecast feature would enhance the utility of the application and provide users with more comprehensive weather information. It aligns with the user's needs and expectations for planning purposes.

Could you please assign it to me? @ManishaSwain8

Sure, I'll provide proper comments in the code as well as make a short video.

Added the required feature. There was a minor issue in the styling, the background image was a bit small and the multi-day weather cards where coming out of the div so I had to fix that my reducing the size of .container.
Have a look and review so that I create a PR
https://github.com/ManishaSwain8/ReactToWeather/assets/97459166/439e65fa-09cf-4802-8498-81c7b4ccc751

Lets do one thing , make whole background black in place of image .and keep the height as it is.
@Abhii-07

If help needed, ping me here !

So basically I just created a forecast component and used that in the Home.jsx. Also did some basic styling for the forecast component. Apart from that did no changes to anything else so that the UI part can be optimized/refactored by someone else( If it is already assigned to anyone)
https://github.com/ManishaSwain8/ReactToWeather/assets/97459166/a714c33a-c0f5-4d8c-a004-543daeebb012

No problem, you can create PR .!

Feature implemented and PR merged.


[ADD/FIX] Results paging

According to: https://github.com/blstream/AugumentedSzczecin_java/pull/21#issuecomment-107074461

Squash this commit to #21


Why not to run Weekly_Digest in last week

https://github.com/talk-go/night/issues?q=is%3Aissue+is%3Aopen+label%3Aweekly-digest
In last week, the weekly_digest not to run.

@abhijeetps

Bumping this as it went another week for me as well and didn't run the digest on Sunday as expected

Same issue in my repository
It stopped for 2 weeks in march, then there was one more run, and then it stopped again, and at the moment it's still not running.
Maybe it is something related to the configuration file? Compared to the example, this difference could be important:
-publishDay: sun
+publishDay: 'sunday'

Hey @yangwenmai , I am really sorry for the delayed reply.
I have been a little busy lately as I am now finishing up my Uni.
Well, this issue looks similar to what we have seen before. You can follow this thread: https://github.com/probot/weekly-digest/issues/65
This was causing big trouble, but I don't know somehow, without making any changes, it worked. 😅
The problem was most probably on the GitHub end. And they fixed it before and then it worked fine.
But looks like it's again causing trouble.
Weekly Digest App is mostly busy on Sunday, so, I would recommend you to change your publishDay in the config to some other day. 😄
Still, I will take a look at it before this month end. 😄

@drdanz , the problem is not due to the configuration file. It will work fine for sun, sunday and 0 as well.
The problem is most probably on GH end as the bot makes a lot of requests on Sunday, especially.
I will recommend changing the publishDay to some other. I will take a look at it at the end of May. 😄

@abhijeetps I could look to provide a PR adding an option to define a specific hour in the day for the release. This would allow consumers to still set the sunday for the report but at a more specific moment in the day. That way would reduce the large amount of requests at the same moment (this is not perfect at all but give more control on the first hand and could avoid this common problem). What do you think about that?

@C0ZEN  that would be really helpful if you can make the PR.
But I am concerned about another major thing.
What do we plan to do if the user hasn't added any configuration? According to the current default way, the app will run once every day and at anytime and will publish the digest, however, this will make the app publish  many digests in the default case (when the config isn't defined.)
Still though, I would like to have some more discussion around it how you are planning to do that. :smile:

@abhijeetps
First of all, to avoid a breaking change, the default time should be the same as before (dunno what is it though but you can tell me).
Without checking the code and guessing, the behavior is this one:

There is one digest per day
The digest fetch all the projects to access the config file
If the config file match the day of the release notes, an issue is created
If no config is found, the default is sunday

If you can confirm this and eventually add more information if you think that this could be helpful to this feature, let me know. Thank you

@C0ZEN , there's no such thing as default timing for weekly digest at the moment.
I have used probot scheduler to trigger the app for a repository every 12 hours. The time in which probot schedular gets triggered for a repository is completely random in this 12 hours duration.
When the weekly digest is triggered, it first checks if the day today matches the publishDay of the repository (configured in .github/weekly-digest.yml or the default day (Sunday)), it then initiates the publication of weekly digest as in issue.
Additionally, I order to avoid duplicate weekly digest being published, I have added another another check to check if a weekly digest has been published in past 24 hours or not.
Thus,

First of all, to avoid a breaking change, the default time should be the same as before (dunno what is it though but you can tell me).

There is no such thing as default time. Sure there is exist a default day to publish the weekly digest day as Sunday.

There is one digest per day

Yes, it is.

The digest fetch all the projects to access the config file (and too much request break the feature?)

It's not that too much request will break the feature. I think publishing reducing this duration of 12 hour to exact timestamp or decreasing the duration might cause some unknown issue as the app publishes ~350 digests every week in public repositories (unknown for private repositories).

If the config file match the day of the release notes, an issue is created
If no config is found, the default is sunday

Yes, and yes.
Running the digest at a particular timestamp is a good idea, but I am not sure yet if this can be implemented at a timestamp for some case. Interested to see how you are planning to propose this idea.

@abhijeetps
Probot scheduler is missing some features of the cron jobs and I was not expecting that.
As you said, the job will start like "after x hour do that" and it is not always exact.
This is the main problem for me and the feature I wanted to add.
Nevertheless I may have found a workaround with the GitHub schedule action which allow users to set their own cron job.
Using it seems a good solution - the weekly digest could be at a time of the user choosing besides no need to have necessarily a weekly digest anymore, it could be daily or whatever -.
Do you think that this could be the solution?

Hi, guys
I added this robot to my project, but it only ran correctly in the first week, and it hasn't run since. I set publishDay: 'Monday', but it doesn't seem to work, what else can I do?
By the way, although this robot has only run once, I still like it very much. If it can run normally, it will be of great help to me

Do you think that this could be the solution?

Moving this to an action in general would be a huge ++ I think and would also allow for others to more easily fork and improve upon your amazing work so far

@TheSalesOpsGuy I never create an action but I am willing to. And indeed an action is usually the next big step that most dev tend to use instead of Apps. Adding this should be then a new way of using this project meaning: no breaking change, no change required for existing configuration.
Still waiting approval/highlights from @abhijeetps, this is not a small task it seems.

Encountering this as well. @abhijeetps - Is the server still running? Still hitting rate limiting issues maybe?

@abhijeetps Hi.  its not working for me either and I changed my config to Monday and put it in a public repo after it did not run in my private repo on Sunday.  I am going to keep moving it forward a day until it runs, but I am also going to write you from my other persona because I think the other me, might be able to offer you some support for making this more stable.

@abhijeetps It's Bonnie Wolfe again.  I run Hack for LA, which is the largest organized community of open source volunteers who work on projects for government and non profits at no cost.  We also happen to have a site called https://100automations.org  (work in progress), whose goal is to support open source projects like yours, by connecting their authors with other software engineers who can (as a group) respond more effectively when the applications start getting popular and scaling issues start to be evident and be responsive to support requests.
I think we can help reconfigure the tool so that it will keep running as more people use it.  We have quite a bit of experience with this, through building a tool called True GitHub contributors, which is very GitHub API intensive.  Additionally, it may make sense to allow people who want to install the app directly in their repo to do that, which might encourage more customization and eventual feature improvements being sent back to the main branch.
If you are interested, please reach out to me on LinkedIn or via email<EMAIL_ADDRESS>


try CoreDNS

https://coredns.io/
https://dev.to/robbmanes/running-coredns-as-a-dns-server-in-a-container-1d0

ToDo

[x] Work version
[x] Log format
[x] Trace https://coredns.io/plugins/trace/
[ ] Metrics (prometheus)
[ ] ETCD
[ ] rewrite (db->redis) (*.db -> db)


use new icon for adding new nodes

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.

Let's fix the name in this PR. Update icons.svg manually and I will fix Figma to match.

What about changing also the icon in Component Browser (from "plus" to this one) @AdRiley @marthasharkey ?

Yes good call. We should do that one too. @marthasharkey Are you OK to include in this MR?


Worked out documentation and examples for software type profile

I worked out some unified documentation for what we currently have so people don't have to wade through various issues in the codemeta issue tracker (codemeta/codemeta#271, codemeta/codemeta#267)

@dgarijo Do you have a chance to take a look at this?

Sorry for the delay, Maarten!
I will have a look ASAP.
Daniel
El lun, 18 jul 2022 a las 10:52, Maarten van Gompel (<
@.***>) escribió:

@dgarijo https://github.com/dgarijo Do you have a chance to take a look
at this?
—
Reply to this email directly, view it on GitHub
https://github.com/SoftwareUnderstanding/software_types/pull/4#issuecomment-1186936546,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALTIGVWAOKCXZCF5BWGAMTVUULLFANCNFSM5YNXGIEQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I know I am still running late, the end of the semester has been
complicated. I plan to review things thoroughly this week.
Thanks for your patience.
El lun, 18 jul 2022 a las 17:47, Daniel Garijo @.***>)
escribió:

Sorry for the delay, Maarten!
I will have a look ASAP.
Daniel
El lun, 18 jul 2022 a las 10:52, Maarten van Gompel (<
@.***>) escribió:

@dgarijo https://github.com/dgarijo Do you have a chance to take a
look at this?
—
Reply to this email directly, view it on GitHub
https://github.com/SoftwareUnderstanding/software_types/pull/4#issuecomment-1186936546,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALTIGVWAOKCXZCF5BWGAMTVUULLFANCNFSM5YNXGIEQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have some comments, let me merge and do a new PR with suggestions so we can discuss them. For the most part, it looks good. I want to have a section with the definitions so we enable content negotiation


Helm chart: container securityContext

Make the kubernetes securityContext configurable on the container level (in addition to the already configurable securityContext on the pod level).
Fixes: #375

@hsudbrock cool, thanks, I think this is good to accept.

Thanks for the quick review!