Waterline throws error on mongo documents async save

Sails.js version: 0.12.3
Waterline version: 0.11.0
Node version: 6.3.1
NPM version: 3.10.3
Operating system: Debian

Hello, I'm running into troubles with an node app using sails-mongo, sometimes coming from nowhere i have this trace:
Unhandled rejection Error (E_UNKNOWN) :: Encountered an unexpected error
at new WLError (/home/node/vitatchat/node_modules/waterline/lib/waterline/error/WLError.js:25:15)
at /home/node/vitatchat/node_modules/waterline/lib/waterline/model/lib/defaultMethods/save.js:196:17
at /home/node/vitatchat/node_modules/waterline/node_modules/async/lib/async.js:52:16
at /home/node/vitatchat/node_modules/waterline/node_modules/async/lib/async.js:550:17
at /home/node/vitatchat/node_modules/waterline/node_modules/async/lib/async.js:544:17
at _arrayEach (/home/node/vitatchat/node_modules/waterline/node_modules/async/lib/async.js:85:13)
at Immediate.taskComplete (/home/node/vitatchat/node_modules/waterline/node_modules/async/lib/async.js:543:13)
at runCallback (timers.js:570:20)
at tryOnImmediate (timers.js:550:5)
at processImmediate [as _immediateCallback] (timers.js:529:5)
I think this error appears when waterline try to save documents but fails due to a timer, which queries could make throw this error ?

There is an unhandled promise error somewhere you are using .save(). If you add a .catch() method you will get the error that is being sent.


Add Jacoco offline instrumentation support

Fixes #2429
I have not yet updated the documentation because I'm waiting for feedback on the existing work before going further.
Context

Jacoco offline instrumentation is necessary on some projects to measure coverage properly. Examples are listed in Jacoco documentation. From issue #2429, we can see that many people are looking for this possibility. Some have found a workaround, but not everyone can get it to work and it doesn't integrate well with the existing plugin.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[x] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[x] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[x] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[x] Provide unit tests (under <subproject>/src/test) to verify logic
[x] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass sanity check: ./gradlew sanityCheck
[x] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation

Just an FYI, there might be some composability concerns we'll want to consider here as well.  We'll think about how this works with other plugins and how it integrates with our plans for idiomatic Gradle.

I have rebased and applied the requested modifications. The rebase was necessary to update the since tag in docs. If you have any other requests, don't hesitate.

Sorry for the late reply.
The responsible team needs to wrap up their feedback.


docker/ci: Fix CI image build for dnf5

Fedora 41 moved to dnf5 which does not provide groupinstall anymore.
Also add openssl and tpm2-openssl to the list of packages to install.
Finally, copy the built cargo-tarpaulin to be available for all users and not only root

/packit retest-failed


Typo in GetProducts.cs sample

Line 14 of https://github.com/Azure/Webjobs.Extensions.Kusto/blob/main/samples/samples-outofproc/InputBindingSamples/GetProducts.cs should be [FunctionName("GetProducts")] instead of [Function("GetProducts")]

Hello @swifteralex
It is Function for out-of-process bindings and FunctionName for inprocess bindings. The links are samples from another binding [Blob], but the idea is the same.
The sample in this folder is for out of process bindings.


Show warning when user scopes API key to account

Closes https://github.com/pypa/warehouse/issues/6266

@woodruffw would you be able to write a small snippet of JS that toggles the visibility of the warning, depending on whether or not "Entire account (all projects)" is selected above?

@woodruffw what do you think of the copy here?
"have the same power as your account password" isn't technically true, as it will only work for package uploads...

In addition to the warning, we could force users to explicitly select their scope, e.g.

"have the same power as your account password" isn't technically true, as it will only work for package uploads...

Yeah, that's true. How about "will be able to modify all of your projects"?

In addition to the warning, we could force users to explicitly select their scope, e.g.

Great idea! I totally forgot this was possible 😅

I'll take a look at adding the JS snippet.

Closing in favor of #6274.


problem when use 'CRLF' as line breaks in mdx file

In windows when using 'CRLF' as line breaks in mdx file, there will be additional empty line in code block. it's ok when using 'LF' as line breaks.

Can you share a stackblitz repro?


Change default backlog quota retention policy to consumer_backlog_eviction

Motivation
Previously we used producer_request_hold as the default backlog quota retention policy. But producer_request_hold is unfriendly for online business, even online business faces big risks. When users ask us to apply pulsar to the online environment, what should be paid attention to? Change the default backlog quota retention policy often mentioned by the first, and initially at zhaopin.com, we have also had such problems.
So, I propose to change the default backlog quota retention policy to consumer_backlog_eviction, from our practice shows that this is a choice for most situations and the most important thing is that this option allows users to avoid taking greater risks.
This change will affect the way our existing users use it. I want to discuss it together to make some trade-offs. If necessary, i can start a email thread.
Modifications
Change broker level default backlog quota retention policy to consumer_backlog_eviction.
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (yes)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? (no)

@merlimat
If I didn’t understand it wrong, this is just to guarantee that the data that has been written is not be lost. If we look at the user's entire system, pulsar is the important part, serving real-time streaming data. If it becomes unwritable, this is also data loss for the user.
The core of the problem is how the user should handle when the backlog has exceeded the threshold, delete old data or reject new data. For streaming data platforms, i think rejecting new data is basically unacceptable. Users can use the retention mechanism to confirm how long they retain data.
For the backlog, this is for a subscriber. There will be one subscriber's backlog cause all new data to be rejected.
If the default configuration is inclined to not lost data. reject new data should also be considered.
If do not consider resource limitations, not limit the backlog by default can match both two . My suggestion is to prefer the configuration with the least loss to the user as the default configuration.

echoing @sijie thoughts, I believe that streaming systems usually prefer writable system. However at the same time I believe queuing systems prefer non-loss of any transactions. Since Pulsar supports both, this is a tricky issue.

@codelipenghui

If I didn’t understand it wrong, this is just to guarantee that the data that has been written is not be lost. If we look at the user's entire system, pulsar is the important part, serving real-time streaming data. If it becomes unwritable, this is also data loss for the user.

Of course if the system is not-writable, the application will be impacted, though the main difference is that what was "acked" before is not lost.
Applications can apply fallback strategies when a downstream system is unavailable, from the simplest (fail user request) to more complex (degraded functioning mode), but they won't be able to know if "acked" data was dropped by the system. There would be no immediate way to communicate that to users, or to apply other strategies.

The core of the problem is how the user should handle when the backlog has exceeded the threshold, delete old data or reject new data. For streaming data platforms, i think rejecting new data is basically unacceptable. Users can use the retention mechanism to confirm how long they retain data.

The default option can be set in broker.conf and overridden per namespace, to adjust to needs.

For the backlog, this is for a subscriber. There will be one subscriber's backlog cause all new data to be rejected.

Without information around what's the importance of the subscriptions, it's difficult to generalize the judgement of which subscription should retain data.
Subscriptions are a way to explicitly retain data in the system.

If the default configuration is inclined to not lost data. reject new data should also be considered.

That's what the default setting is.
@srkukarni

I believe that streaming systems usually prefer writable system. However at the same time I believe queuing systems prefer non-loss of any transactions. Since Pulsar supports both, this is a tricky issue.

That also comes with the dichotomy between Consumer vs Reader.
In streaming mode, to me, a Reader makes more sense in that it does imply data retention, therefore it would never incur in a backlog quota violation.
@codelipenghui

If do not consider resource limitations, not limit the backlog by default can match both two . My suggestion is to prefer the configuration with the least loss to the user as the default configuration.

Yes, the default quota setting is very arbitrary (and very low). I'd be fine to disable backlog quota check by default. It will simplify many "gotchas", though that won't remove the reality that disk space is finite (even if most likely > 10GB),  and applications need to reason about what to do when the limit is reached.

I'd be fine to disable backlog quota check by default.

I think this is a good tradeoff for satisfying both sides. @codelipenghui ?

@sijie yes, agree.

@codelipenghui can you make the change based on Matteo's comment?

@sijie I'm already disable backlog quota check by default.

run Java8 Tests
run Integration Tests

@merlimat I'm already address your comment. PTAL.


UnitTests.Viewer: Fix bug and enhance usability

Description

Using UnitTests.Viewer allows me to test changes quickly especially if I'm working on a css or js issue. It's also invaluable for visually testing changes in the MudBlazor application.
Bug Fix: When using the search bar, it was not set to check for null, so when it would await autocomplete.ClearAsync(); it would actually clear the selectedType as well.
Enhancement: Changed all files that had a defined namespace in the TestComponents folder to be undefined. Folder designation will be categories for all mudnavlinks, allowing for quick traversing and testing. Added an expand all/collapse all. Added tooltip to navlink to show the description from the file (if it exists).

How Has This Been Tested?

Visual Tests in first comment.

Type of Changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

Almost got heart attack when saw the amount of changes, but luckily 90% of them are the explicit namespace removal.
Nice, you read my mind as I wanted to have component categories in the left menu as well.
LGTM

I almost had a heart attack when I saw the amount of changes, but luckily 90% of them are just the explicit namespace removal. Nice, you read my mind as I wanted to have component categories in the left menu as well. LGTM

Exactly what I told my wife, 433 files changed before I did unit tests  but only one file was anything but namespace.

When I first saw the minus/plus buttons I didn't think it would be for collapsing

Maybe I would even make it a one button that is toggleable?

Maybe I would even make it a one button that is toggleable?

Yes, that is exactly what I suggested

oh I totally agree I even started to add something like that but wasn't anything in our library so I didn't. adding a change to this. Also I think these two should be in our library. Not the first time I've looked for expand/collapse icons!

Nice, been wanting to see this for a while.
It might be better to just remove the search bar at the top and let the one in the nav handle all the searches because it has support for groups.
Everything could be collapsed by default too to make it easier to pick a component
The buttons should be full width

Nice, been wanting to see this for a while.
It might be better to just remove the search bar at the top and let the one in the nav handle all the searches because it has support for groups.
Everything could be collapsed by default too to make it easier to pick a component
The buttons should be full width

I'm having trouble making the buttons full width unless I remove the tooltip, any suggestions?

I'm having trouble making the buttons full width unless I remove the tooltip, any suggestions?

@versile2 Could you remove the tooltip? Gets in the way a little and is causing some lag.

I didn't realize how much lag it was adding, but done.

Thanks @versile2!


Shutdown Hooks Not Running

My configuration is fairly simple, but at startup I add a shutdown hook:
Runtime.getRuntime.addShutdownHook(...)
However, at re-stop (or ~re-start code change) the hook is never fired.  The documentation explicitly states this is how shutdown should be handled.  Is there additional configuration I need to specify to make those hooks fire?

Maybe we can let this issue opened, as it is present.
We could try a proper shutdown, then wait a bit and then kill the process if it's still there.
There does not seem to be any java lib to handle a proper shutdown.
A possibility seen on http://stackoverflow.com/questions/6356340/killing-a-process-using-java:
 Runtime rt = Runtime.getRuntime();
  if (System.getProperty("os.name").toLowerCase().indexOf("windows") > -1)
     rt.exec("taskkill " +....);
   else
     rt.exec("kill -9 " +....);

Please open a new ticket if you have a concrete idea how to fix this. As written above, the current behavior is currently equivalent to kill -9. What would be nice if there would be an equivalent of kill -15 instead. The problem with your example is the ..... The java.lang.Process API has no access to the PID so we cannot call the external kill. (Using reflection tricks might get us there, though.)

I don't this problem on UNIX/OSX because Process.destroy() sends a SIGTERM. Note that the I/O redirection stops so you won't see any stdout/stderr from your shutdown hook, but the hook is getting called.
I do have this problem on Windows.  There's no workaround as far as I know. The way to gracefully stop a process on Windows is to send a WM_CLOSE message but that won't work for a command-line application.


[cli] container command is concatenated instead of replaced when using multiple --file options in rancher up

After upgrading from rancher 1.5.10 to 1.6.18, using the bundled client for each one i noticed a difference on how the --file option of rancher up is applied. For sections like image and port it works as expected, replacing and adding respectively. But what i found is that if in the extra compose files you try to overwrite the command you end up with a concatenation of both commands, which fails. I use this a lot for image development and debug purposes and with this version of rancher i can't use it anymore.
See the "Steps to reproduce" section for details on how to reproduce this issue, Thank you.
Rancher versions:
rancher/server: 1.6.18
rancher/agent: 1.2.10
client: v0.6.10 (downloaded from the rancher ui)
Docker version: (docker version,docker info preferred)
Containers: 53
Running: 48
Paused: 0
Stopped: 5
Images: 584
Server Version: 18.03.0-ce
Storage Driver: overlay2
Backing Filesystem: extfs
Supports d_type: true
Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: bridge host macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: cfd04396dc68220d1cecbe686a6cc3aa5ce3667c
runc version: 4fc53a81fb7c994640722ac585fa9ca548971871
init version: 949e6fa
Security Options:
seccomp
Profile: default
Kernel Version: 4.17.4-1-ARCH
Operating System: Arch Linux
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 15.47GiB
Name: turing
ID: HONL:PYQB:OOIV:3FQK:32M6:HFLV:LVCG:JVTF:G5YO:U7VF:P3E7:EZ7S
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
<IP_ADDRESS>/8
Live Restore Enabled: false
**Operating system and kernel: **
4.17.4-1-ARCH
**Type/provider of hosts: **
Bare-metal
**Setup details: **
single-node rancher
**Environment Template: **
Cattle
Steps to Reproduce:
Using the following files:
docker-compose.yaml
services:
  dummy:
    image: ubuntu
    command: ls
    tty: true

docker-compose-extra.yaml
services:
  dummy:
    command: bash

and run
rancher up -f docker-compose.yaml -f docker-compose-extra.yaml
Results:
Looking at the dummyservice container command in the ui, it has ls,bash instead of the expected  bash alone

With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


Instructions in README are outdated and use deprecated functions

I'm working through setting up some e2e tests and noticed that the README.md of this repo is outdated. Things I've noticed so far:

cluster creation with envfuncs.CreateKindCluster is deprecated

I'll keep adding to this as I go along.

Where is it written that envfuncs.CreateKindCluster is deprecated ?

https://github.com/kubernetes-sigs/e2e-framework/blob/a4bef024d27b5f6c476f82a921e7993fc840eab2/pkg/envfuncs/kind_funcs.go#L35-L39

@carreter thanks for pointing this out. It's possible there is outdated info in the project.
It's been evolving and some documentation will fall through the cracks.
Thanks again for using the project.

I'll put up a PR to clean up what I found!


Fix links in documentation

The links on http://www.yiiframework.com/doc-2.0/yii-widgets-inputwidget.html are broken, the generator prefixes them with \yii\widgets\, so I think this will fix them. (so would removing yii\widgets, but I think it's better to be explicit)

Thanks!


Shared Citizen

It would be nice if everyone with PD, EMS, DOJ, and Admin could see all citizens created. Then it would be more like an actual MDT device. Reports, Medical records, Profiles, lic, cars, wepaons, all synced so that Dispath can actually look up people and plates. As it sets now, everyone needs to create the same citizen and update that profile when anything happens

There away to change Prison time to Months? i mean every city ive been in
has there time set to months, which in city is minutes.

In the CAD this is set to seconds because there's a jail script that uses seconds. It's easier to quickly see the total time in seconds


[HOLD] Refactor Policy_CustomUnit_Update

Note: I'll add remaining platform screenshots once this is through initial review in case anything substantively changes.
This will be held on the production deploy of the Web-E PR (https://github.com/Expensify/Web-Expensify/pull/34587)
Details

Refactor of Policy_CustomUnit_Update
Fixed Issues
https://github.com/Expensify/Expensify/issues/215182
Tests
Success case

Click on user avatar > Workspace > Reimburse expenses > Track distance
Update the Unit. Refresh the page
Verify the unit option you set has persisted

Error case (with RBR)
This requires a bit of manual work for testing:

Expose Onyx to the window by adding window.Onyx = Onyx; to setup/index.js
In the console, paste something like Onyx.merge('policy_B7F58A2F61A9389C', {customUnits: {distance: {errors: {1: 'This is an error'}}}}); (where B7F58A2F61A9389C is the name of the policy you're testing)
Verify you see the error under the custom unit area and the red brick road indicator dots
Verify the dots and error are removed once you dismiss the error or submit a successful update of the unit

[ ] Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

[ ] I linked the correct issue in the ### Fixed Issues section above
[ ] I wrote clear testing steps that cover the changes made in this PR

[ ] I added steps for local testing in the Tests section
[ ] I added steps for Staging and/or Production testing in the QA steps section
[ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I included screenshots or videos for tests on all platforms
[ ] I ran the tests on all platforms & verified they passed on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I followed proper code patterns (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I followed the guidelines as stated in the Review Guidelines
[ ] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

QA Steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Updated and ready for re-reviews

When i refresh and then open settings -> reimburse expenses i see this error which you might want to address.

Done! I had the wrong syntax for defining the customUnits prop types

Can you make a follow up to remove CustomUnit from onyx, this way we only keep CustomUnits. It can be confusing to have both.

Good idea - https://github.com/Expensify/Expensify/issues/224464

There is problem with WorkspaceReimburseView render.

Good catch. When I was initially testing, I noticed the API was being called twice so I put in
if (value === this.state.unitValue) {
  return;
}

to stop that from happening. However, I forgot that React double invokes functions in Strict Mode, so that is actually expected in local dev. So I've removed that early return and I'm seeing the UI update correctly now.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Refactor AsyncWorkService

This PR removes AsyncWorkService from the nested "detail" workspace.
The interface would now live in cppmicroservices::async::AsyncWorkService.

Codecov Report

Merging #610 (bff2316) into development (39e6f11) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #610      +/-   ##
===============================================
- Coverage        89.98%   89.98%   -0.01%
===============================================
  Files              247      247
  Lines            10632    10630       -2
===============================================
- Hits              9567     9565       -2
  Misses            1065     1065

Impacted Files
Coverage Δ

...icroservices/asyncworkservice/AsyncWorkService.hpp
100.00% <ø> (ø)

...mpendium/AsyncWorkService/src/AsyncWorkService.cpp
100.00% <ø> (ø)

...ium/DeclarativeServices/src/SCRBundleExtension.cpp
100.00% <ø> (ø)

...ativeServices/src/manager/ComponentManagerImpl.cpp
93.00% <ø> (ø)

...ativeServices/src/manager/ComponentManagerImpl.hpp
83.33% <ø> (ø)

...tiveServices/src/manager/ConfigurationNotifier.hpp
100.00% <ø> (ø)

...um/DeclarativeServices/src/SCRAsyncWorkService.cpp
78.46% <100.00%> (-0.65%)
:arrow_down:

...tiveServices/src/manager/ConfigurationNotifier.cpp
81.37% <100.00%> (ø)


I use  Druid Connection pool that met  a question

environment: Springboot  +   mybatis + postgresql   + Druid
when you send a parameter to mybatis , if  parameter's key is  'orderBy'  , then ，that problem is coming:
SQL will be wrong ！

The Druid connection pool you use is not the Apache Druid here. The first refers to Alibaba Druid, you should ask question there : https://github.com/alibaba/druid


device error code 53 (USB EEM)

Hi,
My host have Windows KDNET-USB-EMM Network Adapter under Network Adapters in Windows Device Manager.
But my target's device is error.
(Code 53 - This Device Has Been Reserved for Use by the Windows Kernel Debugger for the Duration of This Boot Session)
How can i solve it?
Thanks.

@p692584k - This particular channel is monitored by the men and women who write the driver documentation posted on docs.microsoft.com/drivers. Though we'd like to, we don’t have the resources to provide support for specific scenarios.
Your best bet is to use one of the forums where other driver developers and Microsoft engineers can be found. For example the Hardware and Application Developers on Q&A. You can post your question there, and the community of developers usually give feedback fairly quickly.
My recollection is this message can indicate that the network card has been reserved for debugging, but it is still operative. The debugging option selected in using bcdedit. You can learn how to disable this via the links in Code 53 - CM_PROB_USED_BY_DEBUGGER
Good luck with your debugging.


How to generate code during a build pipeline

I've got an internal code generator that I need to have engaged during the build pipeline. The project itself also carries with it several dependencies in its own right. Do I need to have the feeder generator project report its output to the consuming project for CG to take place? I take it that any references, project or package dependencies that it requires must also land there in order for CGR to properly activate an instance of the generator(s) themselves?
Illustrating, something like this:
project/package references -> code generator project(s) -> consumer project (i.e. where CG will actually happen)

All of which, project/package references, code generator project(s), and so on, must land in the consumer project (or somewhere) where we identify the code generator assets to CGR.
Thanks...

If you're asking about this repository, the dotnet-codegen tool requires that folder containing generator's DLL (and all it's required dependencies) is included in GeneratorAssemblySearchPaths or ReferencePath.
https://github.com/AArnott/CodeGeneration.Roslyn/blob/master/src/CodeGeneration.Roslyn.BuildTime/build/CodeGeneration.Roslyn.BuildTime.targets#L32-L44


ci: update dependabot workflow

This fixes an issue with https://github.com/FuelLabs/fuels-ts/pull/2102 where the changeset update workflow didn't install pnpm to run the changeset script.

This is ready for review now


Is there a font selection dialog

Is there a font selection dialog

@melinyi No, not in this project


iOS export Xcode error

Godot version
3.4.4 stable
System information
MacOS 12.3
Issue description
After export for iOS I can't open project in Xcode, in 3.4.3 stable same project with same settings opens and builds fine

Steps to reproduce
Export project for IOS(debug/release), try to open .xcodeproj in Xcode
Minimal reproduction project
ios-test.zip

@uvokin33 Please upload a minimal reproduction project to make this easier to troubleshoot.

@Calinou added archive to description

CC @godotengine/ios

Seems like this is some issue with the export template packaging.
The Xcode project in the export template contains $pbx_locale_file_reference line, which is not part of 3.4.4
https://github.com/godotengine/godot/blob/419e713a29f20bd3351a54d1e6c4c5af7ef4b253/misc/dist/ios_xcode/godot_ios.xcodeproj/project.pbxproj#L40-L46
But it is present in the 3.x (it's part of #58733, which is back ported for 3.5 but not for 3.4.4).
https://github.com/godotengine/godot/blob/788abafb77172d8069428568f0be039f0a85b66a/misc/dist/ios_xcode/godot_ios.xcodeproj/project.pbxproj#L41-L47
I have no idea why the file from the wrong branch get to the package (might be some issue with the build scripts).

Actually, there are also MoltenVK references, so it's 4.0 project template files, that were packaged, instead of 3.4.4.

Same with the macOS export template, it also contains files from master (in this case it will run, but won't have proper icon and app information set).

Damn :| Thanks for catching and reporting this early, I'll re-upload the export templates using the correct scripts.

This should now be fixed, you'll have to redownload the export templates locally to solve the issue.
You may also want to redownload the macOS editor binary which has changed slightly (but that's not necessary to solve this issue, the changes are just on some metadata).

I'll keep this open and pinned for some time so that other users notice the hotfix.

@akien-mga I redownloaded editor and export templates and now project opens in Xcode, but not building

@uvokin33 Thanks for testing, @bruvzg could confirm the same issue. We're looking into why it happens, seems like the binary might have been corrupted. The release template should work in the meantime.

@uvokin33 Could you test these updated export templates? https://github.com/godotengine/godot/releases/download/3.4.4-stable/Godot_v3.4.4-stable_export_templates.tpz

@akien-mga this template works fine

Great, thanks for testing!

Thanks for fixing)


service tests for [clojars]

Messages

:book:

:sparkles: Thanks for your contribution to Shields, @chris48s!

  Generated by :no_entry_sign: dangerJS

🚀


Update Special_cases.md

Fixed a spelling error.

this file is auto-generated from specs, can you update those as well? :-)
notes/Special_cases.md
544:CoffeeScript doesn't supprot adding `when` clauses that are empty, as you
571:CoffeeScript doesn't supprot adding `when` clauses that are empty, as you

specs/switch/case_consolidation.txt
2:  CoffeeScript doesn't supprot adding `when` clauses that are empty, as you

specs/switch/case_consolidation_with_default.txt
2:  CoffeeScript doesn't supprot adding `when` clauses that are empty, as you


[Feature Request] Manual reload when dual-wielding.

Would be great to be able to only reload one hand when dual-wielding. Something as simple as tap reload once for one hand, twice for both. I don't know how possible it will be, but since the game already decides which hand to reload first, maybe it could be interjected into that somehow.

Short answer: easy I think. The int I repurposed as a bitfield could just track left and right hands reload "impulses" separately.


Bump bouncyCastle to 1.60 to fix CVE-2018-1000613

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-1000613

Thanks @djamelz for the PR. And thanks all for your patience (I was on a trip).
This fix has been published in 1.0.0


init push

Description

Include a summary of the changes and the related issue.
Include relevant motivation and context.

Resolves #(issue)

pausing for now...the interventions design is still being finished off


updating set-output with $GITHUB_OUTPUT

When I use $GITHUB_OUTPUT with buildspec file with aws-actions/aws-codebuild-run-build then it gives error like:
Error: No file or directory found.
Previous command: echo "::set-output name=test::${TEST}"
New command:        echo "test=${TEST}" >> $GITHUB_OUTPUT.
But this works on a step of the job in GitHub actions, not on buildspec file.
tried
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>aws-actions/aws-codebuild-run-build@master still same problem.

tried<EMAIL_ADDRESS><EMAIL_ADDRESS>and aws-actions/aws-codebuild-run-build@master still same problem.

Not sure if I fully understand the issue. Variables stored in GITHUB_OUTPUT are accessible from within the context of the workflow, but won't be available for CodeBuild.
If you want to access an environment variable in a CodeBuild build, you can pass it through the env-vars-for-codebuild parameter.
There should be plenty examples on GitHub. For instance, https://github.com/jayheehee/docker-test/blob/3ba88ee5ed17548d2160dcd7f09ed6de30e32a70/.github/workflows/codebuild-workflow.yml#L32-L48

Edited to be more clear. tried your solution, but It didnt work.

echo "test=${TEST}" >> $GITHUB_OUTPUT is a GitHub action syntax. And $GITHUB_OUTPUT only exists in the context of the GitHub workflow. From CodeBuild and its buildspec perspective, $GITHUB_OUTPUT is an undefined variable, so $GITHUB_OUTPUT return empty. And that is the reason for  No file or directory found error.
This is an expected behavior. It is a feature gap for this GitHub CodeBuild action.

As I know, the set-output command will be deprecated on 31 May. Is there any chance that it will be solved before fully deprecated? And is there any workaround?

@taoyong-ty, Will there be any new feature soon or we need to find a solution before end of May? Because set-output command will be deprecated on 31 May.

Hey Shamil,

this works on a step of the job in GitHub actions, not on buildspec file.

Both set-output  and GITHUB_OUTPUT work only on GitHub action, not buildspec file.

Will there be any new feature soon or we need to find a solution before end of May?

Unfortunately CodeBuild and GitHub are separate systems so we cannot make GITHUB_OUTPUT inter-operable on CodeBuild. You need to create your workaround.

As I know, the set-output command will be deprecated on 31 May.

As far as I know, in https://github.com/aws-actions/aws-codebuild-run-build/pull/115 we have upgraded the action-core  version so aws-codebuild-run-build action already supports GITHUB_OUTPUT on GitHub actions. When I ran a test, I don't see a warning message in the codebuild action log. If you are seeing any specific error, could you provide a screenshot and your workflow yaml?

this works on a step of the job in GitHub actions, not on buildspec file.

Both set-output  and GITHUB_OUTPUT work only on GitHub action, not buildspec file.

I tested it and it works on buildspec file.

Will there be any new feature soon or we need to find a solution before end of May?

Unfortunately CodeBuild and GitHub are separate systems so we cannot make GITHUB_OUTPUT inter-operable on CodeBuild. You need to create your workaround.
Then how set-output works on CodeBuild?

As I know, the set-output command will be deprecated on 31 May.

As far as I know, in #115 we have upgraded the action-core version so aws-codebuild-run-build action already supports GITHUB_OUTPUT on GitHub actions. When I ran a test, I don't see a warning message in the codebuild action log. If you are seeing any specific error, could you provide a screenshot and your workflow yaml?
Sorry I cant share screenshot or yaml file. I just cant share error and it says " No such file or directory" at this step
New command: echo "test=${TEST}" >> $GITHUB_OUTPUT. but it works on Previous command: echo "::set-output name=test::${TEST}"

it works on buildspec file.

What do you mean by it worked?
Your CodeBuild build may succeed with this command in your YAML. But I don't think the value of this variable can be read from your subsequent steps in your GitHub job.
  build:
    commands:
      - echo "::set-output name=test::${TEST}"

it works on buildspec file.

What do you mean by it worked?
Your CodeBuild build may succeed with this command in your YAML. But I don't think the value of this variable can be read from your subsequent steps in your GitHub job.
  build:
    commands:
      - echo "::set-output name=test::${TEST}"

Yes. I did like you said. on GH actions step

name: test
id: test
uses<EMAIL_ADDRESS>with:
buildspec-override: .github/workflows/buildpsecs/test.yml

Built like this on buildspec file for codebuild
test.yml
post-build:
commands:
- echo "::set-output name=test::${TEST}"
and used it on next step of GitHub actions
run: |
echo "${{ steps.test.outputs.test }}"

Thanks for providing additional context!
I was able to reproduce the issue you reported(to my surprise).  I will  discuss with my team to understand if and how we can do to support $GITHUB_OUTPUT

I did some research.  The way set-output works is through pattern-matching against the log output on GitHub console. As a reference, when I tried running another build with hide-cloudwatch-logs: true (meaning skip printing CodeBuild logs on GH console) and turned out the subsequent step were not able to get the output value.

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/, mentions the motivation for the deprecation is:

To avoid untrusted logged data to use save-stateand set-output workflow commands without the intention of the workflow author we have introduced a new set of environment files to manage state and output.

It seems what the current workflow doing is an anti-pattern that this migration aims to eliminate. Therefore, we won't be able to continue to support this usage pattern and you will have to figure out a workaround.

@taoyong-ty any updates how to fix this?

@taoyong-ty any updates how to fix this?

I solved it to get terraform plan over s3 bucket and use it on the next step of GH actions like below.
"test=${TEST}" >> $GITHUB_OUTPUT


Call validate manually

Hi,
I need the ability to call validate manually. Validation happens both locally and server side. If the server responds with errors I need to show them.
Does the api expose a way to call validate?

Currently, no.  This would be a great addition though, along with some other promise support being discussed in #28.  I'll get to work :)

I did a workaround where in componentWillReceiveProps, for each field that had a serverside error, it does this.props.setValue(field, this.props.getValue(field)) which would trigger the validate.

Going to track this with #28


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/42662

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/44690

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/58926

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/72980


OmegaConf/hydra error unsupported 0.8.0rc2

Hi,
I am using Hydra to setup my configurations variables for my trainer and model parameters. I'm using PL version 0.8.0rc2. When I pass the params to my PL module and set the passed params to self.hparams, I get the following error:
ValueError: Unsupported config type of <class 'omegaconf.dictconfig.DictConfig'>.

I could add more code if that will help.
@Borda

@sudarshan85 mind pass a minimal example to reproduce?

#!/usr/bin/env python

import torch
from torch import nn
from torch.nn import functional as F

from argparse import Namespace
from omegaconf import OmegaConf

from pytorch_lightning.core.lightning import LightningModule

class TestModel(LightningModule):
  def __init__(self, hparams):
    super(TestModel, self).__init__()
    self.hparams = hparams
    self.out = nn.Linear(hparams.size,1)

  def forward(self, x):
    return self.out(x)

if __name__=='__main__':
  hparams = OmegaConf.create({'size': 3})
#   hparams = Namespace(
#     size=3
#   )

  model = TestModel(hparams)
  print(model(torch.rand(hparams.size)))

When using Namespace from argparse, there is no error and its able to print the out value. But when using OmegaConf object, we get the following error:
Traceback (most recent call last):
  File "./omega_bug.py", line 28, in <module>    model = TestModel(hparams)  File "./omega_bug.py", line 15, in __init__    self.hparams = hparams
  File "/net/vaosl01/opt/NFS/su0/miniconda3/envs/tfool/lib/python3.7/site-packages/torch/nn/modules/module.py", line 638, in __setattr__
    object.__setattr__(self, name, value)  File "/net/vaosl01/opt/NFS/su0/miniconda3/envs/tfool/lib/python3.7/site-packages/pytorch_lightning/core/lightning.py", line 1680, in hparams
    self.save_hyperparameters(hp, frame=inspect.currentframe().f_back.f_back)  File "/net/vaosl01/opt/NFS/su0/miniconda3/envs/tfool/lib/python3.7/site-packages/pytorch_lightning/core/lightning.py", line 1655, in save_hyperparameters    self._set_hparams(hp)  File "/net/vaosl01/opt/NFS/su0/miniconda3/envs/tfool/lib/python3.7/site-packages/pytorch_lightning/core/lightning.py", line 1665, in _set_hparams    raise ValueError(f'Unsupported config type of {type(hp)}.')
ValueError: Unsupported config type of <class 'omegaconf.dictconfig.DictConfig'>.

#2139

feel free to reopen if needed :rabbit:
https://github.com/PyTorchLightning/pytorch-lightning/blob/c52497e85933abf0230800a3461a3053fc94101b/requirements/extra.txt#L12

It seems the current Hydra version 0.11.3 doesn't support omegaconf=2.0.0?
I got this error when simply trying to import hydra
...
     5 from abc import abstractmethod
      6 import six
----> 7 from omegaconf import DictConfig, ListConfig, Config, MissingMandatoryValue
      8
      9 from hydra.plugins import Plugin
ImportError: cannot import name 'Config'

Am I missing something?
What's a good way to pass DictConfig object to Lightning's self.hparams?


Added Our Backend

With the Atom.io API becoming more and more unstable, taking a long time to return, failing to return, or just straight up failing to resolve.
So this PR adds our 'beta' Backend.
This is the backend that I've been working on since the announcement of the sunset, and while currently unfinished, would allow users to search, query, and install all packages that were originally on the Atom.io Package Repository.
While this PR is simple the implications are large. Feel free to discuss the change.
Additionally since PPM is a submodule in Pulsar that means as soon as this is committed, any additional builds of Pulsar should automatically get this update.

Thanks for approval @kaosine @autumnblazey. With two approvals gonna go ahead and merge, and now time to test


[r20.03] sigil: 0.9.14 -> 0.9.16, addressing CVE-2019-14452

Motivation for this change
https://nvd.nist.gov/vuln/detail/CVE-2019-14452
Seems to work fine, tested non-nixos linux x86_64.
master bumped in #95537
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Builds, but segfaults for me.

 That's weird. I needed to run it under nixGL but it ran for me. Will take a closer look tomorrow.

Incidentally, does the existing 0.9.14 work for you without crashing?

Incidentally, does the existing 0.9.14 work for you without crashing?

Yes, it does.

@mweinelt might just go the patching route - does #95873 work for you?


fix replay attack while linking to master address

Codecov Report

Merging #138 (17fbe5c) into master (e2e448f) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
- Coverage   78.44%   78.39%   -0.05%
==========================================
  Files          16       16
  Lines        1684     1685       +1
  Branches      309      310       +1
==========================================
  Hits         1321     1321
- Misses        363      364       +1

Impacted Files
Coverage Δ

contracts/Verification/Verification.sol
48.78% <0.00%> (-1.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2e448f...17fbe5c. Read the comment docs.

Not relevant after #142


delegate to operator equals in operator not equals

all other operator!= implementations did this except these two.
cannot wait for C++20

Pull Request Test Coverage Report for Build<PHONE_NUMBER>3
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 56.976%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.004%

Covered Lines:
11889

Relevant Lines:
19878

💛  - Coveralls

SFMLBuildMaster: Build this please.


bug(types): types not provided in named exports

When using type: module in tsconfig.json
 Could not find a declaration file for module 'warp-contracts-lmdb'. 'node_modules/warp-contracts-lmdb/lib/cjs/index.js' implicitly has an 'any' type.
  There are types at '/node_modules/warp-contracts-lmdb/lib/types/index.d.ts', but this result could not be resolved when respecting package.json "exports". The 'warp-contracts-lmdb' library may need to update its package.json or typings.

24 import { LmdbCache } from 'warp-contracts-lmdb';
                             ~~~~~~~~~~~~~~~~~~~~~

PR: https://github.com/warp-contracts/warp-contracts-lmdb/pull/28


"open.lbry.com" URLs on LBRY.tv throws External Website Warning

While this is technically true, I think it gives a bit of an unnecessary warning.
If you post an open.lbry.com URL on LBRY.tv, and click it, it gives you a warning that it leads to an external site, however, it only technically is true. I feel as though this warning should be disabled for open.lbry.com and associated LBRY domains.

Thanks for filing! I thought we removed all these warnings at some point, but maybe left them in the desktop app. Should def not warn on our own domains.

Looking at this, so should the external resource warning be removed altogether or just for LBRY related domains?

Let's remove it - we don't do it for links in other places like markdown files.


Persist row state when row is scrolled out of view

It would be great if we could somehow persist the state of a component in a row.
For example:
I have 50 rows. Each row renders a React Component called <Row>. Row has a button on it that can change the Row's background-color to red using state inside of the Row component.
Currently, if I click a Row's button, the background will successfully change to red. However, when I scroll that row out of view and then scroll back to it, the color is reverted. This is because the row completely unmounts and re-mounts and therefore resets the state of the component.
The workaround currently is to not use state within the component, and instead pass the state as a prop from the parent. In this case, the parent state contains a map of all the child rows' state.
This can get overly complex, especially when a row has a form in it or more complicated state.
If there is a current feature for this that I'm unaware of, please let me know. Otherwise, it would be great if this library could store and remember the state of child components before they're unmounted.

In react-window it's done with itemData maybe there's something similar for react-virtualized ? I'm honestly not sure

I have the same problem, would rather not have to use the work-around @dcporter44 mentions or redux.

+1


Refactor NameTag Component

Key changes include:

Unify all name tag input data into a react-hook-form
Get rid of the state management for nametag visibility
Simplify the state management for nametag content
Separate the drawing of handwave badge and nametag badge
Move the instances for ZoomApi and drawingApi outside App component so that they won't be instantiated everytime the app re-render.

Screenshot of current state:

FYI @kexinF @BrennanJones

Passing all unit tests now.
><EMAIL_ADDRESS>test
> jest

(node:54958) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
 PASS  __tests__/nametag.test.tsx
 PASS  __tests__/login.test.tsx
 PASS  __tests__/affirmation.test.tsx
 PASS  __tests__/mindfulness.test.tsx

Test Suites: 4 passed, 4 total
Tests:       10 passed, 10 total
Snapshots:   0 total
Time:        1.098 s
Ran all test suites.

@BrennanJones: I just landed the NameTag refactoring, now you can start adding the DB write in updateNameTagContent function. You can also read saved nametag from DB (if any) and use it as the initial value for the NameTagForm.
Note: In terms of the nameTag visibility checkbox, I don't think we should save it to the DB. It should be default to false when a user logs in, but maintain the checked/unchecked state when a user switch between tabs (not unchecked when re-rendering the tab).
@kexinF I replace Switch with a Checkbox between it is a bit more robust in terms of the logic (Switch seems to be easy to be out of sync, but that perhaps could be fixed if we investigate it more later). I didn't put any effort into the CSS and I think some of the existing styles might have conflicted with the component styles (e.g. labelPlacement for the checkbox). Can you look into the CSS and help style the form better? Thank you!


Resolve CVE-2022-28948 by upgrading yaml to v3.0.1

Description:
Resolves CVE-2022-28948 by upgrading gopkg.in/yaml.v3 from v3.0.0 to v3.0.1.

Testing done:

Affected area:

Functional Area

Other
[x]

Codecov Report

Merging #4831 (c85769d) into main (30885c9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4831   +/-   ##
=======================================
  Coverage   69.47%   69.48%
=======================================
  Files         218      218
  Lines       15766    15766
=======================================
+ Hits        10954    10955    +1
+ Misses       4760     4759    -1
  Partials       52       52

Flag
Coverage Δ

unittests
69.48% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/certificate/manager.go
77.43% <0.00%> (-1.03%)
:arrow_down:

pkg/messaging/workqueue.go
100.00% <0.00%> (+10.71%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30885c9...c85769d. Read the comment docs.


Protobuffer generated code out of date

I recently updated the degiro-connector dependency (2.0.21 --> 2.0.22) in my project and I am getting this error when importing the TradingAPI, perhaps some file need to be re-generated?
Traceback (most recent call last):
  File "degiro_portfolio_rebalancer.py", line 9, in <module>
    from degiro_connector.trading.api import API as TradingAPI
  File "/home/marcomarra/.cache/pypoetry/virtualenvs/degiro-portfolio-rebalancer-6YkwSdyZ-py3.8/lib/python3.8/site-packages/degiro_connector/trading/api.py", line 15, in <module>
    from degiro_connector.trading.models.trading_pb2 import Credentials
  File "/home/marcomarra/.cache/pypoetry/virtualenvs/degiro-portfolio-rebalancer-6YkwSdyZ-py3.8/lib/python3.8/site-packages/degiro_connector/trading/models/trading_pb2.py", line 37, in <module>
    _descriptor.EnumValueDescriptor(
  File "/home/marcomarra/.cache/pypoetry/virtualenvs/degiro-portfolio-rebalancer-6YkwSdyZ-py3.8/lib/python3.8/site-packages/google/protobuf/descriptor.py", line 755, in __new__
    _message.Message._CheckCalledFromGeneratedFile()
TypeError: Descriptors cannot not be created directly.
If this call came from a _pb2.py file, your generated code is out of date and must be regenerated with protoc >= 3.19.0.
If you cannot immediately regenerate your protos, some other possible workarounds are:
 1. Downgrade the protobuf package to 3.20.x or lower.
 2. Set PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python (but this will use pure-Python parsing and will be much slower).

@Chavithra I pushed the protobuffer code generated for 2.0.22 to a branch in my fork. I could not open a PR against master though, since master is behind 2.0.22 and I am not sure why

Hi I'm facing the same issue as above. Is there anyway to get this fixed so we can user the latest version of the dependency?

Hi, I think it's up to date now
Closing the ticket.
Feel free to open a new one if you still have protobuffer issues.
Thanks


BFormCheckbox value type Number

BFormCheckbox component have only [Boolean, String, Array, Object] as value type
Would you please add also Number?
like bootstrap-vue

Should be fixed by #198

Try our development version install bootstrap-vue-3@develop --save in order to get the edge features 😀

@antonA418 do we have any news about this? could you test it in the development version? Please, let me know if it's resolved so I can close the issue

I just tested that case and it is solved.


Focus Points deducted twice

Hi,
When using fortissimo or lingering composition, focus points are deducted twice. Once when clicking cast (system does this) and again when the automations take place.
Not sure if this occurs elsewhere (spell slots maybe?).

This is correct because for fortissimo or lingering composition need to post message instead of click cast
These spells have specific logic - on failure not decrease Focus Points


Failing to connect can cause all subsequent attempts to fail

Seems to happen when socket was unexpectedly closed.

I can no longer reproduce this under either of these two test cases:

Attempt to connect to the wrong port first, then connect to the correct one
Disconnect from AP mid-game, then reload the save.

I'm assuming the 0.0.3 revamp fixed this, and we can reopen if it turns out I'm wrong.

I can't reproduce this on a clean save, but I ran into an failing-all-subsequent-attempts issue on <IP_ADDRESS>. that loosely fits the description:
I initially connected to the wrong port, then connected to the correct one, managed a 2h session. Two weeks later I tried to reconnect to the server before turning it on, then tried again with it on leading to the "connected" message in the log, followed by a disconnection before the save loads. I verified via the tracker that the save is at the state it should be at, but I was unable to reproduce it on a clean server


[C++] "utf8_upper" kernel produces different result than Python's str.upper for "ẞ"

Describe the bug, including details regarding any error messages, version, and platform.
In [1]: import pyarrow as pa

In [2]: pa.compute.utf8_upper("ß")
Out[2]: <pyarrow.StringScalar: 'ẞ'>

In [3]: pa.__version__
Out[3]: '11.0.0'

Python str.upper:

>>>char = "ß"
>>>char.upper()
'SS'

Component(s)
Python

Arrow uses the utf8proc C library for UTF8 operations (https://juliastrings.github.io/utf8proc/).
And this library changed the upper case for "ß" from "SS" to "ẞ" a few years ago: https://github.com/JuliaStrings/utf8proc/issues/130
It seems that there is some discussion about what the correct upper case should be. For example, see also https://bugs.openjdk.org/browse/JDK-8186073 . The unicode standard (http://unicode.org/charts/PDF/U1E00.pdf) mentions:

The capital letter sharp s is part of the official German
orthography since 2017. Along with "SS" it is an allowed
variant spelling of 00DF in "all caps" style

https://www.fileformat.info/info/unicode/char/00df/index.htm mentions "uppercase is "SS" (standard case mapping), alternatively U+1E9E"

So in the end, this is not something we can change in Arrow itself. If you want this to change, you will need to bring it up at https://github.com/JuliaStrings/utf8proc/ (but given they changed this a few years back, it might not be likely they would change it again)


Use quay.io images from migtools namespace

Moves building, tagging and using images from new migtools namespace.
Adds experimental releasetime GitHub exporter images and example use in values.yaml.
Please review. Once everyone is happy we will need to update in this repository the following secrets and create release so images are built:

QUAY_USERNAME
QUAY_PASSWORD
QUAY_IMAGE_NAMESPACE

Signed-off-by: Michal Pryc<EMAIL_ADDRESS>@redhat-cop/mdt

/hold

/unhold

/LGTM

@KevinMGranger hopefully you get this message.  Please review this PR as it changes the image location, something we hope you can ack.  Thank you sir!


I just want to use your  code for my learning purpose.its not a propo…

…sal to make change but a way to clone your repository.

You can just use a clone repository button to create your own version of the project. Hope it helps!


Use function types and lambda expressions in Kotlin: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-function-types-and-lambda?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-2-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-function-types-and-lambda#3
In which task and step of the codelab can this issue be found?
4:" Use Functions as Data Types"  5th line "Call  the trickFunction()..."0
Describe the problem
backward code from what is written in text description
fun main() {
val treatFunction = trickOrTreat(false)
val trickFunction = trickOrTreat(true)
***   treatFunction()
trickFunction() ***
}
Should be:
fun main() {
val treatFunction = trickOrTreat(false)
val trickFunction = trickOrTreat(true)
***  trickFunction()
treatFunction()   ***
}
Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Pending fix.


Fix execution when "Null Input" is selected

Allow jq execution with an empty JSON input when the "Null Input" option is selected.
Resolve #76

Thanks for the fix. Can you make sure all other options other than the "Null" one won't have this issue?

Issue #76 and this fix are related only to the "Null Input" option.
When the "Null Input" option is off, existing behavior is correct and would not send a jq task to the server if the JSON input box is empty.
Also please note that Travis-CI was not run on this fix and I do not have the knowledge to build and test this it.

Stale


Could not proxy request /upload

Ive no idea of coding etc. i just wanted to read my Instagram backups in a simple way.
I followed every step and managed to get to the point where i can upload my .zip file.
First when i tried to upload it said "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:9000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED )".
After googling a bit i found out to change the local host from 9000 to 3000 in the package.json (idk if this was right).
Now it uploads but at some point (mostly 32%) it stops and the cmd says "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:3000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNRESET)."
Maybe im just dumb but i really want to see my Instagram Backup file and sorry if bothering with "noob" questions^^

Ive no idea of coding etc. i just wanted to read my Instagram backups in a simple way.
I followed every step and managed to get to the point where i can upload my .zip file.
First when i tried to upload it said "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:9000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED )".
After googling a bit i found out to change the local host from 9000 to 3000 in the package.json (idk if this was right).
Now it uploads but at some point (mostly 32%) it stops and the cmd says "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:3000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNRESET)."
Maybe im just dumb but i really want to see my Instagram Backup file and sorry if bothering with "noob" questions^^

It is totally no problem asking questions , but would be great if you attach a screenshot or a log file of the error you are having ,
one more thing whether you zipped the files manually or you are giving zip downloaded from Instagram itself to the upload page
and no worries asking questions , you can spam the issues section the thing is you must be able to use it.

Ive no idea of coding etc. i just wanted to read my Instagram backups in a simple way.
I followed every step and managed to get to the point where i can upload my .zip file.
First when i tried to upload it said "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:9000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED )".
After googling a bit i found out to change the local host from 9000 to 3000 in the package.json (idk if this was right).
Now it uploads but at some point (mostly 32%) it stops and the cmd says "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:3000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNRESET)."
Maybe im just dumb but i really want to see my Instagram Backup file and sorry if bothering with "noob" questions^^

It is totally no problem asking questions , but would be great if you attach a screenshot or a log file of the error you are having ,
one more thing whether you zipped the files manually or you are giving zip downloaded from Instagram itself to the upload page
and no worries asking questions , you can spam the issues section the thing is you must be able to use it.

Ive no idea of coding etc. i just wanted to read my Instagram backups in a simple way.
I followed every step and managed to get to the point where i can upload my .zip file.
First when i tried to upload it said "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:9000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED )".
After googling a bit i found out to change the local host from 9000 to 3000 in the package.json (idk if this was right).
Now it uploads but at some point (mostly 32%) it stops and the cmd says "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:3000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNRESET)."
Maybe im just dumb but i really want to see my Instagram Backup file and sorry if bothering with "noob" questions^^

It is totally no problem asking questions , but would be great if you attach a screenshot or a log file of the error you are having ,
one more thing whether you zipped the files manually or you are giving zip downloaded from Instagram itself to the upload page
and no worries asking questions , you can spam the issues section the thing is you must be able to use it.

Hi,
thank you. When i upload my downloaded unedited zip file the cmd says the error in the screenshot.

Ive no idea of coding etc. i just wanted to read my Instagram backups in a simple way.
I followed every step and managed to get to the point where i can upload my .zip file.
First when i tried to upload it said "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:9000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED )".
After googling a bit i found out to change the local host from 9000 to 3000 in the package.json (idk if this was right).
Now it uploads but at some point (mostly 32%) it stops and the cmd says "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:3000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNRESET)."
Maybe im just dumb but i really want to see my Instagram Backup file and sorry if bothering with "noob" questions^^

It is totally no problem asking questions , but would be great if you attach a screenshot or a log file of the error you are having ,
one more thing whether you zipped the files manually or you are giving zip downloaded from Instagram itself to the upload page
and no worries asking questions , you can spam the issues section the thing is you must be able to use it.

Hi,
thank you. When i upload my downloaded unedited zip file the cmd says the error in the screenshot.

Ive no idea of coding etc. i just wanted to read my Instagram backups in a simple way.
I followed every step and managed to get to the point where i can upload my .zip file.
First when i tried to upload it said "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:9000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED )".
After googling a bit i found out to change the local host from 9000 to 3000 in the package.json (idk if this was right).
Now it uploads but at some point (mostly 32%) it stops and the cmd says "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:3000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNRESET)."
Maybe im just dumb but i really want to see my Instagram Backup file and sorry if bothering with "noob" questions^^

It is totally no problem asking questions , but would be great if you attach a screenshot or a log file of the error you are having ,
one more thing whether you zipped the files manually or you are giving zip downloaded from Instagram itself to the upload page
and no worries asking questions , you can spam the issues section the thing is you must be able to use it.

Thank you!
I get this error when i try to upload the unedited zip file.

Ive no idea of coding etc. i just wanted to read my Instagram backups in a simple way.
I followed every step and managed to get to the point where i can upload my .zip file.
First when i tried to upload it said "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:9000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED )".
After googling a bit i found out to change the local host from 9000 to 3000 in the package.json (idk if this was right).
Now it uploads but at some point (mostly 32%) it stops and the cmd says "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:3000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNRESET)."
Maybe im just dumb but i really want to see my Instagram Backup file and sorry if bothering with "noob" questions^^

It is totally no problem asking questions , but would be great if you attach a screenshot or a log file of the error you are having ,
one more thing whether you zipped the files manually or you are giving zip downloaded from Instagram itself to the upload page
and no worries asking questions , you can spam the issues section the thing is you must be able to use it.

Thank you!
I get this error when i try to upload the unedited zip file.

Ive no idea of coding etc. i just wanted to read my Instagram backups in a simple way.
I followed every step and managed to get to the point where i can upload my .zip file.
First when i tried to upload it said "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:9000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED )".
After googling a bit i found out to change the local host from 9000 to 3000 in the package.json (idk if this was right).
Now it uploads but at some point (mostly 32%) it stops and the cmd says "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:3000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNRESET)."
Maybe im just dumb but i really want to see my Instagram Backup file and sorry if bothering with "noob" questions^^

It is totally no problem asking questions , but would be great if you attach a screenshot or a log file of the error you are having ,
one more thing whether you zipped the files manually or you are giving zip downloaded from Instagram itself to the upload page
and no worries asking questions , you can spam the issues section the thing is you must be able to use it.

Thank you!
I get this error when i try to upload the unedited zip file.

To Help you i'll need either the whole text from your console window or the file from here

Ive no idea of coding etc. i just wanted to read my Instagram backups in a simple way.
I followed every step and managed to get to the point where i can upload my .zip file.
First when i tried to upload it said "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:9000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNREFUSED )".
After googling a bit i found out to change the local host from 9000 to 3000 in the package.json (idk if this was right).
Now it uploads but at some point (mostly 32%) it stops and the cmd says "Proxy error: Could not proxy request /upload from localhost:3000 to http://localhost:3000/.
[2] See https://nodejs.org/api/errors.html#errors_common_system_errors for more information (ECONNRESET)."
Maybe im just dumb but i really want to see my Instagram Backup file and sorry if bothering with "noob" questions^^

It is totally no problem asking questions , but would be great if you attach a screenshot or a log file of the error you are having ,
one more thing whether you zipped the files manually or you are giving zip downloaded from Instagram itself to the upload page
and no worries asking questions , you can spam the issues section the thing is you must be able to use it.

Thank you!
I get this error when i try to upload the unedited zip file.

To Help you i'll need either the whole text from your console window or the file from here


Referring to integrated services as "devices" is semantically confusing

My understanding is that if I want to integrate RescueTime with CDB, I'd set it up as a "device" with the "writer" role. And I think the integration would need to have CDB pulling the data from RescueTime, as opposed to RescueTime pushing the data to CDB.
There are two confusing bits here:
RescueTime is a service, not a device.
CDB is reading/importing/streaming from RescueTime; RescueTime is not writing anything.
Ideas (from a CDB noob):

Rework device/role concept into "inputs" & "outputs"
I think it's more natural to me to think about integrations like this in terms of pub/sub instead of read/write, especially in the context of streams

To ConnectorDB, RescueTime would be a device - it wouldn't need a writer role, since all devices can write to their own streams by default.
An integration with RescueTime would be achieved through the python API, which would somehow obtain the data from RescueTime, and input it to the database. This python program is referred to as the "device".
ConnectorDB can ship with several built-in integrations, but these integrations would work independently from the core data-gathering platform - each integration would be in effect its own service, and independent of the core CDB code. I would even suggest that these integrations be their own executables in an "integrations" or "plugins" subdirectory.

"Service" definitely makes more sense to me here. I'm used to seeing "integrations" in turnkey processes where I'll, at most, have to c/p some API keys.

I just recently stumbled upon this project, and find it quite interesting!
With regard to integrating with other services, would it make sense to make a new side project that handles the most used service integrations (such as rescueTime, withings, strava etc) using the python CDB API, maybe add some flask/django/web to handle oauth etc
maybe inspired by https://github.com/cpfair/tapiriik
Are there something similar already implemented that i have not noticed yet?
What is the intention with this project with respect to integrations?

A separate syncing server is how it would work work ideally, for now: a service which integrates data from multiple places, and uses CDB as backend storage. There is currently no work on this.
Currently, my focus is on a machine-learning-based analysis server, which will run separately from CDB and attempt prediction, which is turning out to be a very difficult task. As such, I don't plan on writing an integration server myself until this is figured out, which might take a while.
If you are up to the task, it would be a wonderful addition!

New version of CDB will have devices renamed to connections.


create a api to track all the files in the "/uploads" folder

Can you assign this task to me

done


Add diagnostics functions: proj4 ver. & Inv. Hammer

This is a refactor of the package_version function to move getting the proj4 version number into a new function, proj4_version.  check_proj_inv_hammer function is added for checking if the inverse of the hammer projection is available (which should be in the yet to be released proj.4 version 4.9.3).
check_proj_inv_hammer() and proj4_version() are intended to end up in setup.py, but may provide some use in the main basemap library.  Due to that reason, the imports are mostly self-contained for the function.
So, Proj.4 verion 4.9.3 has not been released, nor has the current development version of pyproj which has code that raises a RuntimeError when a projection's inverse function isn't available (pyproj <IP_ADDRESS> and before will segfault).  At the moment, I'm a little uncertain about putting these the check_proj_inv_hammer() into setup.py without one of the two libraries being released.  This effectively requires installation one of the development versions for the check_proj_inv_hammer function to pass the test, otherwise they risk a segfault.  This originates from discussion in PR #240.
Editing setup.py seems a little daunting because I'm a bit overwhelmed by what all setup.py can do/should do.  setup.py seems to work like a swiss army knife by doing a couple tasks well and other tasks not so well.
Here are my local test results of the functions, which where copied an pasted into ipython:
In [3]: proj4_version()
Out[3]: '4.9.2'

In [4]: package_versions()
Out[4]: BasemapPackageVersions(Python='2.7.4 (default, Apr  6 2013, 19:54:46) [M
SC v.1500 32 bit (Intel)]', basemap='1.0.8', matplotlib='1.5.1', numpy='1.10.4',
 pyproj='<IP_ADDRESS>', pyshp='1.2.3', PROJ4='4.9.2', GEOS='3.5.0-CAPI-1.9.0 r4084',
OWSLib='not installed', PIL='not installed', Pillow='not installed')

In [5]: check_proj_inv_hammer()
Out[5]: 'Unknown'

In [6]: check_proj_inv_hammer(True)
Out[6]: True

Ok, this is an incremental improvement of the diagnostic functions. A nitpick: the double-negative for segfault_protection_off made me have to read the logic twice before I got it.

I can understand the confusion.  In a few days, I'll do a commit to update the flag variable to just segfault_protection.Thanks for the quick feedback.

I changed the parameter's name to segfault_protection and made another commit.
IPython console
In [3]: check_proj_inv_hammer(segfault_protection=True) # default
Out[3]: 'Unknown'

In [4]: check_proj_inv_hammer(segfault_protection=False)
Out[4]: True

In [5]: check_proj_inv_hammer()
Out[5]: 'Unknown'

If have an older version of Proj.4 or a version without the inverse hammer patch applied it will segfault Python.

Thanks.


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2696

Questions ?
Please refer to the Backport tool documentation


Smart Key support

Codecov Report

Merging #17 (670a5ac) into main (403724c) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main      #17      +/-   ##
============================================
+ Coverage     38.80%   38.88%   +0.07%
  Complexity       31       31
============================================
  Files             9        9
  Lines           688      679       -9
  Branches         70       69       -1
============================================
- Hits            267      264       -3
+ Misses          395      389       -6
  Partials         26       26

Impacted Files
Coverage Δ

.../src/main/kotlin/io/provenance/scope/sdk/Client.kt
8.88% <0.00%> (+0.09%)
:arrow_up:

...n/kotlin/io/provenance/scope/sdk/SessionBuilder.kt
61.90% <0.00%> (+0.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403724c...670a5ac. Read the comment docs.

Will add instruction comments for adding apiKey to env variables to examples for running smart key contracts

Wasn't there some recent changes @rchaing-figure made to p8e for Smart Key signing fixes? I thought one was making all signing go through the same verification code. I thought at least we copied over all of this before those fixes.

Signature verification is done in the SignatureInputStream, not sure if that got copied over in another branch or suppose to be it this one.

Wasn't there some recent changes @rchaing-figure made to p8e for Smart Key signing fixes? I thought one was making all signing go through the same verification code. I thought at least we copied over all of this before those fixes.

Signature verification is done in the SignatureInputStream, not sure if that got copied over in another branch or suppose to be it this one.

@wbaker-figure it would be good to make sure the latest version of that is reflected in this library as part of this.

looks like @wbaker-figure pulled those changes over already when setting this project up initially

(from the git blame in the p8e-scope-sdk SignatureInputStream file)

the full commit for reference https://github.com/provenance-io/p8e-scope-sdk/commit/916620019fccaace9d48234011b670cf42762258
vs the p8e pr with the verify changes https://github.com/provenance-io/p8e/pull/79/files


Add router management functions in OpenStack

Add router management functions in OpenStack
Description

Add functions to list, create, destroy and manage interfaces in network routers in OpenStack driver.
Also the functions to create and delete network has been added in the OpenStack_2_NodeDriver to make it work with the neutron API.
Add the network_id to the subnet object.
Add the ex_update_subnet function.
Add the ex_update_port function.
Add extra kwargs parameters has been added in the subnet creation to enable to specify optional parameters.

Status

done, ready for review

Checklist (tick everything that applies)

[x] Code linting (required, can be done after the PR checks)
[ ] Documentation
[x] Tests
[x] ICLA (required for bigger changes)

Codecov Report

Merging #1281 into trunk will increase coverage by <.01%.
The diff coverage is 91.11%.

@@            Coverage Diff             @@
##            trunk    #1281      +/-   ##
==========================================
+ Coverage   85.95%   85.95%   +<.01%
==========================================
  Files         359      359
  Lines       73774    73862      +88
  Branches     6690     6699       +9
==========================================
+ Hits        63415    63491      +76
- Misses       7685     7691       +6
- Partials     2674     2680       +6

Impacted Files
Coverage Δ

libcloud/test/compute/test_openstack.py
94.86% <86.04%> (-0.24%)
:arrow_down:

libcloud/compute/drivers/openstack.py
85.66% <95.74%> (+0.42%)
:arrow_up:

libcloud/test/compute/test_upcloud.py
90.06% <0%> (-1.33%)
:arrow_down:

libcloud/test/compute/test_ec2.py
97.74% <0%> (-0.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f9897...4eb9878. Read the comment docs.

Thanks for the contribution.
From a high level the code change looks good to me (besides some concerns of using **kwargs. Since this functionality is available by multiple providers, we should eventually see if we can introduce a new networking API.
Something along the lines of #345.

Merged, thanks.


feat: add mock batcher and implement as a wrapper in integration test

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.16%. Comparing base (d7017e8) to head (ebb3d3f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   83.98%   84.16%   +0.17%
==========================================
  Files          28       29       +1
  Lines        1374     1440      +66
  Branches     1374     1440      +66
==========================================
+ Hits         1154     1212      +58
- Misses        161      165       +4
- Partials       59       63       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


SummaryPane

Cleaned up the math on feature importance summarizer.
Refactored out SummaryPane's into two separate namespaces.
Added appropriate documentation.

Sounds like a plan, Ben.  I'll try and make those changes today.

Sounds like a plan, Ben. I'll try and make those changes today.

and I'll arrange to revise it in real time. 😬


Make file local functions static

Motivation:
Some functions in netty_io_uring_native.c are local to the file
but not declared as static.
Modifications:

make file local functions static

Result:
File local function access limited to the file they are
defined in.

@chrisvest - Looks like I'm not a contributor on this repo. Can you merge if you are satisfied?


Can't begin Bundler development

Referring to DEVELOPMENT.md, I ran rake spec:deps, rake spec which resulted in 400+ spec fails.
On advice from @segiddins I added the local bin directory to my PATH.
I've added bundler/lib and bundler/exe/bundle to RUBYLIB.
Still no dice.
I'm on Linux, running MRI 2.1.7 at the moment. There's a warning about rspec-micks ~> 3.4.0 Unresolved specs during Gem::Specification.reset:, and the first fail is indeed undefined method allow'`
Lots of the fails report /usr/lib/ruby/site_ruby/1.9.1/rubygems/dependency.rb:315:in to_specs': Could not find 'git_tracker' (>= 0) among 0 total gem(s) (Gem::LoadError)` which is weird since, as noted, this is under MRI 2.1.7

No difference - although I wouldn't have expected one with ./bin in the PATH. Anyhow, here's the output: https://gist.github.com/nyarly/f0c7a25a113b820b5c70

ah. I think I know what this is. try gem cleanup rspec-mocks ?

That get's me a lot farther.
I still get the errors about Could not find 'git_tracker' (>= 0) among 2 total gem and I get stalls at "bundle install with gem sources / the simple case / creates a Gemfile.lock on a blank Gemfile"

I'm not sure what to tell you -- it works locally and on CI, and we do our best to create an isolated environment for the tests.

I'll see if I can figure out that detail - perhaps it's worth documenting.

Does a patch like this help for you?
diff --git a/bin/rspec b/bin/rspec
index 94e0d89..9614dde 100755
--- a/bin/rspec
+++ b/bin/rspec
@@ -7,4 +7,8 @@ bundler_spec.dependencies.each do |dep|
   gem dep.name, dep.requirement.to_s
 end

+Gem::Specification.unresolved_deps.each do |name, dep|
+  gem dep.name, dep.requirement.to_s
+end
+
 load Gem.bin_path("rspec-core", "rspec")

It doesn't. I still get the git_tracker issue. Honestly, I think I'm willing to live with 20 failures for the moment and lean on CI to make sure I didn't break anything new. The PR I have in mind should be pretty minor. Thanks for your help here.

@nyarly I meant does that diff fix the 2000+ failures?

There's a misunderstanding: I started with 400+, and the gem clean command fixed the majority. The remainder (~30) are all related to this git_tracker gem being missing. I'd like to start from a green bar, but I think I can add specs an implement a change to the Thor CLI without that. If these all pass in CI, I'm willing to work with a small set of known fails and check my PR against CI when the time comes - more than I'm willing to drain more of your time.

The git_tracker issue is due to your git binary actually being a rubygem executable, which predictably causes problems

That doesn't line up with what I'm seeing here:
which git #=> /usr/bin/git
less git #=>
Failures look like:
/usr/lib/ruby/site_ruby/1.9.1/rubygems/dependency.rb:315:in `to_specs': Could not find 'git_tracker' (>= 0) among 0 total gem(s) (Gem::LoadError)
Checked in 'GEM_PATH=/home/judson/ruby/foreign_projects/bundler/tmp/gems/system', execute `gem env` for more information
        from /usr/lib/ruby/site_ruby/1.9.1/rubygems/dependency.rb:324:in `to_spec'
        from /usr/lib/ruby/site_ruby/1.9.1/rubygems/core_ext/kernel_gem.rb:64:in `gem'
        from /home/judson/.gem/ruby/2.0.0/bin/git-tracker:22:in `<main>'
fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
warning: You appear to have cloned an empty repository.
fatal: Needed a single revision
The git source /home/judson/ruby/foreign_projects/bundler/tmp/libs/foo-1.0 is not yet checked out. Please run `bundle install` before trying to start your application

Finally hunted this down: at some point it appears that a prepare-commit-msg hook file was installed in my system templates directory. Not sure how this happened - probably git-tracker itself is the most likely suspect.
The solution for me was to remove that file - I've got a per-user templates directory, so it wasn't an issue for normal git usage.
I'm not sure if this warrants any further action than to close the issue, and leave my travails for some future troubled soul to discover.


how can I save bubble plot

Hi~, I was wondering if anyone can tell me how I can save bubble plots with png format. It seems that functions like png(), pdf(), jpeg() do not work for htmlwidget plots.

I usually do a screen shot and save it then as png.
It´s a workaround. Preferable would be to save this directly.


Converting the main description Yaml Block Literal to support proper Markdown

I've converted the .info.description block to address the broken formatting of GFM fenced code block. The change makes the YAML string under the key work as a normal Markdown.
It's a simple trick: using of description: | instead of description: >-. But then the entire multi-line string needs to be rewritten/converted to omit the unnecessary newlines. I used this dirty script to do the job.
More on the YAML mult-line behavior here: https://yaml-multiline.info/
After

Before

closing as included in the new specs which is inlined in apify-docs