[TS Migration] Migrate 'CategoryPicker' to TypeScript

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/31952

PROPOSAL:
Tests

[ ] Go to CategoryPicker via payment request or any other flow that uses it.
[ ] Use the search bar in CategoryPicker.
[ ] Try to pick different categories and cancel them by clicking for the second time on the same category.

Offline tests

QA Steps

Same as Tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android native.webm

Android: mWeb Chrome
Android mWeb.webm

iOS: Native
https://github.com/Expensify/App/assets/60450261/de401542-c0ad-45a5-94d8-043d5f9b0c00

iOS: mWeb Safari
https://github.com/Expensify/App/assets/60450261/987a7b23-f121-4420-99bd-74600f675977

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/60450261/622e823b-dcc0-463a-a8bc-32f30f1a9051

MacOS: Desktop
https://github.com/Expensify/App/assets/60450261/c40d23a2-2f67-450d-8d38-9569f2996df7

I can take over this issue as per https://expensify.slack.com/archives/C02NK2DQWUX/p1708107813288869
cc: @Santhosh-Sellavel

Will be working on review today.

Reviewing now

@mateuuszzzzz Can you kindly fix the merge conflicts?
And tag me? I did initially testing and the changes looks fine.

@mateuuszzzzz The changes haven't merged with main completely, still there are 30+ commits in main.
Could you pull the main locally and merge from main again?

@abdulrahuman5196 I noticed some PRs from the master changed a significant part of logic. Probably I need to record new videos etc. So It might take a little bit longer than I expected

Sure. Do let me know once done. I will re-review

@mateuuszzzzz Editing the category isn't working in this PR.
But its working in staging. (I think it was not working in staging also a day back)
https://github.com/Expensify/App/assets/46707890/92f9ddf6-5c05-43bf-8947-5eb8279b969a

@mateuuszzzzz Editing the category isn't working in this PR.
But its working in staging. (I think it was not working in staging also a day back)
Screen.Recording.2024-02-21.at.10.43.53.PM.mov

Could you try one more time and do rm -rf node_modules; npm i before testing? I checked it again. This time with the latest fixes of CategoryPicker from the main branch, it works as expected. If this happens again could you share the reproduction steps?

@mateuuszzzzz The previously mentioned issue is fixed now.
But I see a different issue now. The selected row is not showing with tick mark while searching in the category picker.
https://github.com/Expensify/App/assets/46707890/6adcf194-5289-40bc-9146-334918c71c64

@mateuuszzzzz The previously mentioned issue is fixed now.
But I see a different issue now. The selected row is not showing with tick mark while searching in the category picker.
Screen.Recording.2024-02-24.at.9.26.15.PM.mov

Could you let me know if you are sure this is not defined behavior? I checked how it works on the latest main branch and the selected row also won't show a check mark while searching.

@mateuuszzzzz
It is working fine in staging
https://github.com/Expensify/App/assets/46707890/ccf2811d-4ccf-478f-abe1-eed7e31e1c54
But seems to not work in main. Seems someone broke it in main.

@abdulrahuman5196 I can take a look at the root cause of this issue tomorrow. If it won't be very complicated I think we can resolve this in the current PR. What do you think?

I can take a look at the root cause of this issue tomorrow. If it won't be very complicated I think we can resolve this in the current PR. What do you think?

@mateuuszzzzz I am fine to even report it as a separate issue, since this is not caused by this PR. Anyways your call.

@abdulrahuman5196  I checked it and I don't see a fast solution so let's report it as a separate issue 👍

Hi, @mateuuszzzzz Sorry, yesterday caught up in couple of blockers.
Could you kindly fix the merge conflicts? I can take a look?

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/46707890/9d3054dc-74b2-42a0-871d-ecf65c8eead9

Android: mWeb Chrome

https://github.com/Expensify/App/assets/46707890/9a69a25f-56a4-4fb4-8f54-e300c1da4722

iOS: Native

https://github.com/Expensify/App/assets/46707890/ee3a04d8-f637-4419-9ecf-ee4d5bc763a4

iOS: mWeb Safari

https://github.com/Expensify/App/assets/46707890/fdbdcb5a-976c-4b67-af55-f401a2ca3764

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/46707890/eeecd020-6a7c-4f62-beb9-5dcb6e0b5a71

MacOS: Desktop

https://github.com/Expensify/App/assets/46707890/d53bebe7-b1bf-4e00-b995-8762fc3563f7

FYI: @blimpich  is assigned for internal review.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.47-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Regarding codebase release!!

Hi! This is super-awesome work. When can we expect the release of codebase?

Hi, thanks for being interested in our work! I am cleaning up the code and should release the code by early August!

Amazing work!

hope for codebase release

Hi, sorry for the long wait. I've just released the code. Feel free to contact me if you have any questions regardign setting up the code base/running examples/setting up new example.


Plugin not published on Npm?

Hey, I couldn't find this plugin on Npm so I had to set the github repo in my package.json to get it installed. Any chance to see it on Npm :) ? Thanks

Yup it's not published yet. We've been meaning to get a guide up for using it. A redis one is also planned. Not sure if this is totally ready for use. @daffl would know.

Basic functionality works I think (although the tests were failing for me locally so I have to look into that). I've been thinking to rename it to feathers-sync before publishing, too.

Actually, I tested it yesterday and it doesn't work as it is.
I have to use a forked version of the main dependency mubsub (https://github.com/znetstar/mubsub) because the original repo was not updated for the current version of mongo (2.x). A PR https://github.com/scttnlsn/mubsub/pull/38 waits for fixing the problems.

I like the feathers-sync name @daffl :)
Thank you for proposing all these awesome plugins!

Now with Redis, this plugin should be ready to be published to npm, no?

Once it's upgraded to the new plugin infrastructure and the API is finalized (see https://github.com/feathersjs/feathers-sync/pull/2#issuecomment-176250255). Probably some time this evening.

Awesome, thanks @daffl!

I just published the current master as<EMAIL_ADDRESS>I will continue working on the updates I mentioned.


Calculation of CLV value returns NaN in some cases

I tried to calculate CLV but unfortunately for 2/3 of my data I got NaN values.
`ggf = GammaGammaFitter(penalizer_coef = 1e-06)
ggf.fit(
frequency = df_rftv["frequency"],
monetary_value = df_rftv["monetary_value"],
weights = None,
verbose = True,
tol = 1e-06,
q_constraint = True)
clv = ggf.customer_lifetime_value(
transaction_prediction_model = bgf,
frequency = df_rftv["frequency"],
recency = df_rftv["recency"],
T = df_rftv["T"],
monetary_value = df_rftv["monetary_value"],
time = LIFE,
freq = "D",
discount_rate = discount_m)
df_rftv.insert(0, "CLV", clv)`
The results that I got:

Python version: 3.8.12
BTYD version: 0.1b3

Hi @ColtAllen,
Thank you for your quick reply! The problem was in index of df_rftv dataframe. It should be reset before inserting CLV value.
I am closing this issue


Mouse Pointer

The mouse pointer turns into a vertical line with an arrow to each side when in the application.  This is only place where this has ever happened.  It makes clicking on things in the GUI difficult.  I have installed this on two different machines and it does the same thing.  This is using the most recent build but it did it on one back as well.

Hi,  this occurs for me also but I wasn't sure if it was a problem with my big mouse cursor setup - maybe just affecting me.  It didn't bother me too much so I never looked at it.  I've had a quick look now though and I've worked out what the problem is.  It's an easy fix so this will make it in the next release. 😊

The mouse pointer issue is fixed now in the latest release.  Thank you for reporting the issue.


Support more placement options in TooltipTypes.d.ts

Support more place types that floating-ui supports. These actually already work but I need the type to be updated to reflect existing allowed types.

Thanks for suggesting this. Before we can merge this, we have to update a few more files.
Source:

src/utils/compute-positions-types.d.ts
Docs:
docs/options.mdx
docs/examples/place.mdx

I believe I haven't missed any. Feel free to update them, or leave it to us for whenever we get the time.

Thanks for suggesting this. Before we can merge this, we have to update a few more files.
Source:

src/utils/compute-positions-types.d.ts

Docs:

docs/options.mdx
docs/examples/place.mdx

I believe I haven't missed any. Feel free to update them, or leave it to us for whenever we get the time.

I've updated those files. Hope that works. Have a great weekend!

@gabrieljablonski sorry, I missed a big section in the docs. I will get to this later tonight.

@gabrieljablonski I updated the examples to include the other types... see screen recording
https://github.com/ReactTooltip/react-tooltip/assets/122113864/93c0de89-ed45-49de-a518-1d3e03775bc9

Available at v5.15.1


Switch to YAML configuration

Using properties files is not really an optimal way to configure this application. As discussed here, we decided to switch to YAML.

+1

Moved to https://github.com/osiam/osiam/issues/70


Last step of GK parser

GK cannot parse idiomBlock ::= barred* expr
arrayExpr should be in atomExpr (?)
ididomExpr should be in atomExpr (?)

Also, there isn't any list pattern, like [ a, 1, b ].

I kinda think this can be a separate issue 😉

For 0, do you know why?

@imkiva I don't understand 0, I think they can
> :parse-tree (| f x | g x |)
FILE(0..15)
        IDIOM_EXPR(0..15)
                LIDIOM(0..2)
                WHITE_SPACE(2..3)
                IDIOM_BLOCK(3..12)
                        BARRED(3..8)
                                APP_EXPR(3..6)
                                        REF_EXPR(3..4)
                                                QUALIFIED_ID(3..4)
                                                        WEAK_ID(3..4)
                                                                ID(3..4)
                                        WHITE_SPACE(4..5)
                                        ATOM_EX_ARGUMENT(5..6)
                                                REF_EXPR(5..6)
                                                        QUALIFIED_ID(5..6)
                                                                WEAK_ID(5..6)
                                                                        ID(5..6)
                                WHITE_SPACE(6..7)
                                |(7..8)
                        WHITE_SPACE(8..9)
                        APP_EXPR(9..12)
                                REF_EXPR(9..10)
                                        QUALIFIED_ID(9..10)
                                                WEAK_ID(9..10)
                                                        ID(9..10)
                                WHITE_SPACE(10..11)
                                ATOM_EX_ARGUMENT(11..12)
                                        REF_EXPR(11..12)
                                                QUALIFIED_ID(11..12)
                                                        WEAK_ID(11..12)
                                                                ID(11..12)
                WHITE_SPACE(12..13)
                RIDIOM(13..15)

This is what I see

@imkiva I don't understand 0, I think they can

Try
(| (+) [ 1, 2, 3 ]  [ 4, 5, 6 ] |)

Member

What if we make array expr atom? /cc @HoshinoTented

Seems like I accidentally fixed all of them


Don't use ${CMAKE_INSTALL_PREFIX} as an install destination

Absolute destinations are not necessary, and prevent CPack from working.

@SpecLad What is the reason for the change?

and prevent CPack from working

@SpecLad this will render the very easy sudo make install under linux useless. Isn't there a way to check how we can keep it and also get CPack to work?

this will render the very easy sudo make install under linux useless.

How so?

Afaik the sudo make install dumps all the build binaries into the correct location right under /usr/local/bin and such? Or am I mixing stuff up?

Correct, but how does that support your claim?
This is from the documentation for the install command:

DESTINATION arguments specify the directory on disk to which a file will be installed.  If a full path (with a leading slash or drive letter) is given it is used directly.  If a relative path is given it is interpreted relative to the value of CMAKE_INSTALL_PREFIX.  The prefix can be relocated at install time using DESTDIR mechanism explained in the CMAKE_INSTALL_PREFIX variable documentation.

Emphasis mine. In other words, . is equivalent to ${CMAKE_INSTALL_PREFIX}, except for it not being absolute.

Hmmm so if I understand it correctly, the only difference will now be that you will need to explicitly define where to install everyting in relation to the root folder?
For example, in the past I could do
cmake -D CMAKE_BUILD_TYPE=RELEASE -D CMAKE_INSTALL_PREFIX=/usr/local -D WITH_CUBLAS=ON -D WITH_CUFFT=ON -D WITH_EIGEN=ON -D WITH_OPENGL=ON -D WITH_QT=ON -D WITH_TBB=ON -D BUILD_DOCS=ON -D BUILD_EXAMPLES=ON -D BUILD_TESTS=ON -D CUDA_ARCH_BIN="3.0" ../opencv_build/
And then followed by
sudo make -j 24 sudo make install
and everyhting would be in the standard location. How will this change influence this then?

Hmmm so if I understand it correctly, the only difference will now be that you will need to explicitly define where to install everyting in relation to the root folder?

Depends on who the "you" in that sentence is. If by that you mean, well, you, then no. If you mean the OpenCV developers, then we already need that. See every other install command.

How will this change influence this then?

In no way.

O then do ignore my comments :) I completely misunderstood the adaptation it seems. Thanks for the explanation!

:+1:


Shell script which list the dependencies / uses of the STL

Brief feature description
We require a simple script which list all uses of the STL inside the production code (not the tests).

Can you elaborate in one or two sentences why this is needed? My mind reading skills degraded lately ;)

@elBoberido it is required so that we know what we have to rewrite from the STL or what we have to certify inside the STL.

@elfenpiff sure, but please add it to the issue description. We have a template with brief and detailed section. Please add at least a little context and not just do stuff.


Handle missing values in VTL

We are not handling null/missing value at the moment. We need to check what the spec says.

The spec
https://sdmx.org/wp-content/uploads/VTL-2.0-User-Manual-20180416-final.pdf
https://sdmx.org/wp-content/uploads/VTL-2.0-Reference-Manual-20180416-final.pdf


Please issue an swift version if possible

Please issue an swift version if possible, since swift-style development is more preferred by Apple, which is also a great learning source for beginners.

'ObjectiveGit/ObjectiveGit.h' file not found

'ObjectiveGit/ObjectiveGit.h' file not found

I'm not sure if you are on the correct thread...

'ObjectiveGit/ObjectiveGit.h' file not found

you need run " brew install cathage'' in bash before you double click "bootstrap"


Notebook webview is frequently positioned incorrectly

I've seen this a lot over the past month and it seems like a major issue for notebooks, please consider investigating further for November

While running integration tests today (23rd November):

Version: 1.74.0-insider (user setup)
Commit: 58e7c7b8865e3c3ea77055461ffb5d656a7a46af
Date: 2022-11-23T05:25:25.108Z
Electron: 19.1.3
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

@mjbvz it's likely related to the position performance optimization this month.

@rebornix @roblourens Can you try debugging. I can never reproduce this
The best place to start debugging is:
https://github.com/microsoft/vscode/blob/7ae2857bf0d9d0e01512c959afb59414dfab40cb/src/vs/workbench/contrib/notebook/browser/notebookEditorWidget.ts#L1704
Let me know if you want to pair on this later this afternoon too

Was finally able to repo this by dragging to create a new editor group (it happens maybe 20% of the time for me)
@joaomoreno @sbatten  I think the root cause is that the notebook widget is passed the wrong position. I'm going to work around this by making the notebook editor ignore the position it is given, however this will also undo the performance fixes we may for notebook layout
I don't fully understand the grid layout code but I believe that SplitView.layoutContext is incorrect. Here's what I see happening when creating a new editor to the right of the current editor (splitting a single editor into two:

A new Split View is created

layout is called on it. At this point, this.layoutContext is:
{orthogonalSize: 1129, absoluteOffset: 0, absoluteOrthogonalOffset: 0, absoluteSize: 759, absoluteOrthogonalSize: 1129}

By the time layout is called on the notebook editor widget, position.left is computed as zero. This results in the wrong layout

If I then slightly resize the window, here's what happens:

We call layout on the split View for the new group

However now this.layoutContext is:
{orthogonalSize: 1129, absoluteOffset: 265, absoluteOrthogonalOffset: 28, absoluteSize: 760, absoluteOrthogonalSize: 1129}

When we layout the notebook editor, position.left is not correctly computed as 658

Still trying to debug  why this.layoutContext is incorrect in the first case but that's likely a fix for December. For November, I'll work on more scoped fix just for the notebook widget

Created new issue: https://github.com/microsoft/vscode/issues/167816


Upgrade to 0.9.0, support new metrics labels

Once linkerd/linkerd#938 ships, we'll need to update/remove the metrics relabeling rules in our prometheus configs that we use to populate the service label. Using linkerd-provided labels will make us less reliant on regexes.

This was fixed by #19.


Update README.md

This PR updates the README file to include info relevant to the updated core contracts.

Other than the new stuff added, is all of the existing information accurate and relevant still?


fix: Sonatype IQ Server URL is not visually persisted in Options

Fix for #77

:tada: This PR is included in version 2.10.2 :tada:
The release is available on:

Chrome Web Store
v2.10.2
GitHub release

Your semantic-release bot :package::rocket:


Atom.Object.defineProperty.get is deprecated.

atom.workspaceView is no longer available.
In most cases you will not need the view. See the Workspace docs for
alternatives: https://atom.io/docs/api/latest/Workspace.
If you do need the view, please use atom.views.getView(atom.workspace),
which returns an HTMLElement.
Atom.Object.defineProperty.get (/usr/share/atom/resources/app/src/atom.js:54:11)
Object.activate (/home/daniel/.atom/packages/github-issues/index.coffee:42:9)

Fixed; confirmed working in 0.189.0


This no longer works on macOS Sierra

Unfortunately it appears this is broken on Sierra. I've tried everything I can think of and read through all issues on here, but still haven't found a solution. Anyone know of a solution or a timeline on a fix?

are you sure it's Sierra and not tmux --HEAD that broke the whole visual mode?

I just ran brew uninstall tmux reattach-user-to-namespace && brew install tmux reattach-user-to-namespace and it's still not working :(

I have this in my ~/.tmux.conf. And this is working. If I scroll up in tmux and highlight some text and then press ^b y it copies it to my clipboard.
# copy to Mac OSX pasteboard
if -b 'which -s reattach-to-user-namespace' 'bind y run "tmux save-buffer - | reattach-to-user-namespace pbcopy"'

However, before Sierra anytime I highlighted text in tmux it was automatically copied to my clipboard (like how native iTerm behaves).
I believe this line achieved that.
# see https://github.com/ChrisJohnsen/tmux-MacOSX-pasteboard
if 'which -s reattach-to-user-namespace' 'set -g default-command "reattach-to-user-namespace $SHELL -l"'

Forgive me if any of this is misinformed. I'm a recent tmux convert. Only got about 3 months of experience with it under my belt.

Sorry what I've meant is - it might be a tmux issue and not reattach-to-user-namespace.
I can look on the Sierra computer tonight, as I'm still on El Capitan on the work laptop.
What happened in tmux/tmux is they're rewriting the visual mode API, so the old bindings won't work anymore. Try brew uninstall --force tmux and installing version 2.2

Thanks so much for your help @supermarin! Will try that.

Any update @jsatk ?
I'm having the same issue here.

@MarceloCajueiro unfortunately it did not work. Again, once I highlight i can run a tmux command to copy to clipboard, but it used to automagically copy on highlight, which I want back.

Look at https://github.com/tmux/tmux/issues/543. I followed the thread and solved the issue by basically adding these two settings:
set -g default-shell $SHELL
set -g default-command "reattach-to-user-namespace -l ${SHELL}"

And then restarting my tmux server:
 tmux kill-server

Hope this helps.

@chischaschos Still doesn't work. Again, I can send text I've highlighted in tmux (which sends it to the save-buffer in tmux) to pbcopy with prefix + y. This is the line that does that.
if -b 'which -s reattach-to-user-namespace' 'bind y run "tmux save-buffer - | reattach-to-user-namespace pbcopy"'
Previously, however, it automatically sent any text I highlight with the mouse in tmux to the clipboard. Meaning, anything that went to the save buffer got sent to pbcopy automatically.
That stopped working in Sierra, but my tmux.conf didn't change.

I'm running into the same problem on OS X 10.12., tmux 2.3, and reattach-to-user-namespace 2.5.

In my case, it works when I install it with the option below.
# install with --with-wrap-pbcopy-and-pbpastebr option
% brew install reattach-to-user-namespace --with-wrap-pbcopy-and-pbpastebr

# See available options
% brew options reattach-to-user-namespace
--with-wrap-launchctl
	Include wrapper for launchctl with this fix
--with-wrap-pbcopy-and-pbpaste
	Include wrappers for pbcopy/pbpaste that shim in this fix
--HEAD
	Install HEAD version

I'm encountered the same issue even when "Applications in terminal may access clipboard" is selected.
Here is my environment:
iTerm 3.0.15
tmux 2.5
reattach-to-user-namespace version 2.6
OS Sierra: 10.12.5

This is added on top of my config file:
set -g default-shell $SHELL
set-option -g default-command "reattach-to-user-namespace -l zsh"
bind-key -T copy-mode M-w send-keys -X copy-pipe 'reattach-to-user-namespace pbcopy'
bind-key -T copy-mode Enter send-keys -X copy-pipe 'reattach-to-user-namespace pbcopy'

And the clipboard is not working as expected. When I run:
tmux showb

is showing my last selection
When doing:
tmux showb | pbcopy

the content goes to the clipboard and I'm able to paste the content outside of the terminal and in the terminal.

I had the same issue
set-option -g default-shell "${SHELL}"
set-option -g default-command      "reattach-to-user-namespace -l ${SHELL}"

# Copy
bind-key >  save-buffer $HOME/.tmux-buffer \; \
            run 'pbcopy < $HOME/.tmux-buffer' \; \
            display-message "Copied to clipboard."

and fixed like this.
set-option -g default-shell "${SHELL}"
set-option -g default-command      "reattach-to-user-namespace -l ${SHELL}"

# Copy
bind-key >  save-buffer $HOME/.tmux-buffer \; \
            run 'reattach-to-user-namespace pbcopy < $HOME/.tmux-buffer' \; \
            display-message "Copied to clipboard."

This appears fixed now.


[INLONG-4483][Agent] Many ConnectException logs in unit test of Kafka source

[INLONG-4483][Agent] Many ConnectException logs in unit test of Kafka source

Fixes #4483

Motivation
*Fix many ConnectException logs in unit test of Kafka source

close


Modernize build versions

Hit an issue with a too old version of gradle stopping it working in recent Android Studio.
Happy to close, but since I updated some build dependencies, thought it worth offering it up.  I understand if there are legacy reason why you don't want upgrades.

@dturner before I fix the CI actions, are you likely to accept this?

Sorry, better to ask @SigmanZero about this.

Please, approve this PR


Which file to use exactly for the evaluation of MRI dataset?

Hi!
I was looking for how to use detection.py, In that we have to put the dataset in ./DATASETS/CancerousDataset/EdinburghDataset/Anomalous-T1/raw but in raw folder for all 22 scans which file we have to keep, there are many files present in the one scan. Should it be binary file in Axial_T2 folder for each scan?
Some guidance is helpful!
Thanks!

Hi, my specific pipeline, converted the .nii files to .npy files as they are much quicker to read into PyTorch. The function I used to automate this is main() in dataset.py.
These resultant .npy files are those placed in that 'raw' folder. You can however structure your folders however you see fit.
Please let me know if this helps.

Thanks for your response!!
Yes, but I was thinking if which images you are utilising in your original paper for evaluating as for each scan there are multiple folders which contain .nii files. Like for this scan -:

Which folder should I use?

Ah yes - wonderful question cos that really was confusing.
So I went through all of those .nii files and used the COR_3D_IR images, which I believe are the T1 weighted images from that dataset.
Does this help?

Thanks a lot!!


Installer: Windows installer not displaying properly

OS: Win7
App Versions: 1.6, 1.6.2, 1.7
This is a minor bug where the installer is not rendering properly.
See below:

Can some one else verify?

Do you mean that image? That is a default gif visible during the installation. https://github.com/electron-userland/electron-builder/wiki/Options#buildwin
If the problem you are describing is really that I can ask to my brother (how created the Sqlectron logo) to  create a gif for Sqlectron installation.

Oh. Yes it is the spinner gif. That gif is a little confusing as to its purpose in the install.

@markcnunes this gif is visible during the installation of the app on Windows.
But since that is too much generic is a bit confusing what that represents.
Could you prepare a gif for Sqlectron with a spinner and some describing message such as "Installing... Please wait."?

Implemented in this commit https://github.com/sqlectron/sqlectron-gui/commit/ee4c7b8a2cbb1d5991a44e20899cba6be7bea0fa


Enh/advanced logging

Motivation and Context
Added custom JSON Logger to every package so logging output can be checked easily
Description
Every log now prints a JSON String instead of just a readable text string
Steps for Testing
Run your Instance of gocast

Just so we don't forget it: If you update the Go version, don't forget to update https://github.com/TUM-Dev/gocast/blob/70bc1f36d0afdd53d6cdb8ce2875ff2ebe6a4558/.github/workflows/go-test.yml#L11 as well.


[Harnmaster3] Styling and description tweaks

Submission Checklist
Required

[ x ] The pull request title clearly contains the name of the sheet I am editing.
[ x ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[ x ] The pull request makes changes to files in only one sub-folder.
[ x ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Fix 2 minor styling issues in dark mode (illegible text in notes field and horse speed select) and clarified riding EML description

Character Sheet Info Roll20 Internal Use only.


Fix typos

"implmentation" -> "implementation"
"the the" -> "the"

Coverage remained the same at ?% when pulling fefdc407353c77f9f113165059975da6038168ec on dimitris-t:patch-1 into 3362eb9d17ec9c820ccb6b8706bbc75350742f49 on juga0:master.

Thanks!


Define query boundaries per user/role

It would be useful to setup the query timeout and limit per user/role to avoid end-users can overload the server.

@tglman WDYT to store into the user custom settings? In this way a user could have, for example, its own command.timeout=30000? And in this way would work not only for the timeout, but for any other setting we decide to make also per user?

Customer still interested on this. Leaving this open. Would be nice for our Engineering Team if they can cost this so we can provide an estimate. Thanks


Angrbrd transaction api

Merging in stable version of Node.js client SDK. Fixing everything that was broken with security merge.
Signed-off-by: Anna D Derbakova<EMAIL_ADDRESS>

I can confirm that taking a this branch, setting up a fresh vagrant environment, and following the directions within ./sdk/node/README.md results in the successful execution of the nodejs-based unit tests.

@ghaskins thanks for taking a look at this. This is my SDK code coming back to a stable state after a messy merge of some security code that caused breaks. I will have more code for deploy/invoke/query APIs going in tomorrow. Please stay tuned.

LGTM
Reviewed by: Greg Haskins<EMAIL_ADDRESS>

@angrbrd It seems there is a trivial conflict in the README.md due to other merges.  IIUC the protocol is that submitters should resolve the conflicts.  If you would be so kind to do so I'll merge this in.

@ghaskins just spoke to @srderson. Looks like some other README.md changes are going in pertaining to the license being used. As soon as they are complete, I will rebase. Thanks!


Dead links to GRIB tables at end of section 3.3

Title
Dead links to GRIB tables at end of section 3.3
Moderator
None at the moment.
Requirement Summary
The Conventions document should not contain dead links.
Technical Proposal Summary
Either the dead links should be updated or removed.
Benefits
This will benefit all readers of this section of the document.
Status Quo
The conventions document will contain dead links.
Detailed Proposal
At the minimum the three dead links at the end of Section 3.3 should be updated to current web pages, or or links to non-existing web pages should be removed and the text edited to reflect the change.
However, with recent years' extensive  additions to the standard name table the overlap between CF standard names and GRIB parameter tables may have weakened substantially. Thus it may be relevant to discuss whether the two lines

Here are lists of equivalences between the CF nstandard names and the standard names from the ECMWF GRIB tables, the NCEP GRIB tables, and the PCMDI tables.

instead should be removed irrespective of whether there are up-to-date web pages to link to. In this case this issues should probably be relabeled as an enhancement.

I support this, including the removal of the lines referring to GRIB and PCMDI tables -- especially as the GRIB 1 codes referred to are now being replaced by GRIB 2.

I support this as well - there have been many attempts to harmonise CF and WMO tables, but none of them have really gained traction, so this would keep from pointing people potentially in the wrong direction.

Thanks you for raising this, Lars. I support your initiative to do something about it. I agree that doing nothing but updating the links would be to correct a defect.
Going further than that would be an enhancement, as you say, and I agree with others that we should do so. As far as I know, the correspondence of standard names with PCMDI names and GRIB codes has only even been partial and never updated. I was responsible for including these in the first version of the standard name list. At that time it was desirable to make those links because standard names were a new idea, and by showing their relationship to existing standards we could make them more attractive to potential users. Now, however (twenty years later), standard names are well-established in their own right, I would say, and the mapping between different metadata standards belongs better outside the standard, in neutral territory.
Hence, I would propose we should

delete the two lines you mention.

delete this sentence earlier in 3.3: "When appropriate, the table entry also contains the corresponding GRIB parameter code(s) (from ECMWF and NCEP) and AMIP identifiers."

delete this text from Appendix B:

Entry elements may optionally also contain the following elements:

<grib>GRIB parameter code</grib>
<amip>AMIP identifier string</amip>

Not all variables have equivalent AMIP or GRIB codes. ECMWF GRIB codes start with E, NCEP codes with N. Standard codes (in the range 1-127) are not prefaced. When a variable has more than one equivalent GRIB code, the alternatives are given as a blank-separated list.

delete the <grib> and <amip> tags in Example B1 and in the standard name table.

I wonder what others think, especially Alison, of removing all this?

Now, however (twenty years later), standard names are well-established in their own right, I would say, and the mapping between different metadata standards belongs better outside the standard, in neutral territory.

I fully agree with this and the activities of ENVO are better suited for such developments of ontologies (especially since WMO codes also are becoming available in semantic frameworks now).

If no one else volunteer, I can to write a pull request following Jonathan's suggestion above. But it would be good hear from Alison @japamment

This issue seems to be taken over by the more general overhaul of links suggested in #267 (points 1 and 2), and no activity in this issue for more than a month. So closing .


WIP: disorder

Superseded by https://github.com/Jigsaw-Code/outline-sdk/pull/323
@PeterZhizhin please check the last commits were pushed where you expected them to be pushed


How to dynamically set "Success" / "Error" to inputGroup?

I am looking at this demo.
It says that i could just set "success" prop to inputGroup so that it indicate the data is valid.
But how do I do it dynamically? For example, I would have a function that gets invoked in the onChangeText of a <input/>

Passing a prop success is equivalent to passing success={true}
So if you have state variables like inputSuccess and inputError, you can do this:
    <InputGroup
      iconRight
      success={this.state.inputSuccess ? true : false}
      error={this.state.inputError ? true : false}>
      <Icon name='ios-checkmark-circle' style={{color:'#00C497'}}/>
      <Input placeholder='Textbox'/>
    </InputGroup>

Understood! thanks! Saw your SO answer too.

You should add this in the documentation as well, it will be really helpful it took me like 2 hours to figure this out.

@adeelibr This is related to how props work in React/react-native and not something which is exclusive to native-base. Hence we didn't feel the need to include it to our docs.

@sankhadeeproy007  believe me their are many newbie's out their like I am, this small piece of code will be very helpful and will make the documentation a bit more better.

stumbled across this after searching for a bit. Agree that it can be added to the documentation to make it simpler for newbies!

Going to docs and also we are launching NativeBase 2.0 this week❗


[SPARK-41383][CONNECT][PYTHON][TESTS][FOLLOWUP] Add tests for grouping and grouping_id

What changes were proposed in this pull request?
Add tests for grouping and grouping_id
Why are the changes needed?
For test coverage
Does this PR introduce any user-facing change?
no, test-only
How was this patch tested?
added tests

merged into master, thank you @HyukjinKwon


Virtual File System API

Create a virtual file systema API with capabilities for mount diferent file systems and search through the files tree with file expresiones with wildacards (*, ?). Be able to parse files with a mecanism that allows you to create parsers and then ask for direct classes.

The first version of the vfs is done.


[Для фанатів] Scrollbar in the modal window is displayed even if there is not much text

Environment: All
Reproducible: Always
Build found: 8490f60
Priority: Low.
Severity: Trivial.
Type: UA.
Preconditions

Log in as a user.

Steps to reproduce

Open any streetcode.
Scroll down to the field "Для фанатів".
Open card.
Pay attention to the right edge of the field.

Actual result
The scrollbar in the modal window is displayed even if there is not much text.
Expected result
The scrollbar in the modal window is displayed only if there is much text.
User story: #41
Test case: #65

The scrollbar in the modal window is displayed only if there is much text. The defect is fixed.


cutorch + Titan Black shouldn't build with sm_52

**Please do not close this issue until it is resolved. **
I am unable to install cutorch on an ubuntu 14.04 server running cuda 6.5. I get the following error :
luarocks install cutorch

Installing https://raw.githubusercontent.com/torch/rocks/master/cutorch-scm-1.rockspec...
Using https://raw.githubusercontent.com/torch/rocks/master/cutorch-scm-1.rockspec... switching to 'build' mode
Cloning into 'cutorch'...
remote: Counting objects: 105, done.
remote: Compressing objects: 100% (100/100), done.
remote: Total 105 (delta 8), reused 43 (delta 3), pack-reused 0
Receiving objects: 100% (105/105), 150.16 KiB | 0 bytes/s, done.
Resolving deltas: 100% (8/8), done.
Checking connectivity... done.
cmake -E make_directory build && cd build && cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH="/home/nicholas14/torch/install/bin/.." -D
CMAKE_INSTALL_PREFIX="/home/nicholas14/torch/install/lib/luarocks/rocks/cutorch/scm-1" && make -j$(getconf _NPROCESSORS_ONLN) install

-- The C compiler identification is GNU 4.8.4
-- The CXX compiler identification is GNU 4.8.4
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Found Torch7 in /home/nicholas14/torch/install
-- Found CUDA: /usr/local/cuda (found suitable version "6.5", minimum required is "5.5")
-- MAGMA not found. Compiling without MAGMA support
-- Automatic GPU detection failed. Building for all known architectures.

Installing cutorch on this platform was not a problem until a week ago. I have not updated the ubuntu kernel as I want to avoid running into the unrelated issue outlined in #347 which affects any linux above 3.19.0-33. On this platform, I am using a safe kernel :
$ uname -ar
Linux atlas 3.13.0-24-generic #47-Ubuntu SMP Fri May 2 23:30:00 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

I have 4 Titan back GPUs :
$ nvidia-smi
Tue Mar  1 14:52:12 2016
+------------------------------------------------------+
| NVIDIA-SMI 340.29     Driver Version: 340.29         |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|===============================+======================+======================|
|   0  GeForce GTX TIT...  Off  | 0000:02:00.0     N/A |                  N/A |
| 46%   73C    P2    N/A /  N/A |    331MiB /  6143MiB |     N/A      Default |
+-------------------------------+----------------------+----------------------+
|   1  GeForce GTX TIT...  Off  | 0000:03:00.0     N/A |                  N/A |
| 46%   73C    P2    N/A /  N/A |    325MiB /  6143MiB |     N/A      Default |
+-------------------------------+----------------------+----------------------+
|   2  GeForce GTX TIT...  Off  | 0000:83:00.0     N/A |                  N/A |
| 43%   69C    P2    N/A /  N/A |    325MiB /  6143MiB |     N/A      Default |
+-------------------------------+----------------------+----------------------+
|   3  GeForce GTX TIT...  Off  | 0000:84:00.0     N/A |                  N/A |
| 54%   82C    P2    N/A /  N/A |    578MiB /  6143MiB |     N/A      Default |

Please help!

this is not a cutorch issue, hence i plan to close it. CUDA 6.5 DOES NOT SUPPORT sm52. Install CUDA 7.0 or 7.5 and upgrade the driver to the minimum supported version.

@soumith might be a cmake issue. there is no sm_52 GPU in the machine, titan black is kepler

@szagoruyko Thank you. Like I said, installing cutorch on this platform worked 2 weeks ago. Now it doesn't. THIS IS A CUTORCH ISSUE. Do not close.

ok found the bug.
https://github.com/torch/cutorch/blob/master/cmake/FindCudaArch.cmake#L6 has to be conditional upon CUDA 7.0 and above to append 5.2

it's strange though, that http://docs.nvidia.com/cuda/maxwell-compatibility-guide/#building-maxwell-compatible-apps-using-cuda-6-0 says that cuda 6.5 supports sm52

http://cdn.meme.am/instances/29725115.jpg :)

@nicholas-leonard can you locally test that changing that line (removing 5.2) fixes your issue?

@soumith Yes, it compiles and I can require it. The same issue affects cunn though.

So I tried the fix for cutorch and cunn and it seems to work fine. I update the torch and nn packages as well. Only issue is that I get the following error when running th -lcunn -e 'nn.testcuda()' :
_____________________________________________________________|______________________________________________________________________  ==>
SpatialBatchNormalizationTHCudaCheck FAIL file=/home/nicholas14/cutorch/init.c line=212 error=77 : an illegal memory access was encountered
error in __gc metamethod (cuda runtime error (77) : an illegal memory access was encountered at /home/nicholas14/cutorch/lib/THC/generic/THCStorage.c:147)

As you can see, all previous unit tests pass, so this might be a different issue.

Can confirm that this issue is affecting the Docker builds for CUDA 6.5 (since it builds for all architectures).

@soumith Thanks. I can confirm that it builds on my end. Can you implement the same fix for cunn?

done via https://github.com/torch/cunn/commit/fc2a0b312c63f5920308860ee856f2a749ac45a8

@soumith Perfect. I can also confirm that cunn builds as well. Thanks!


SBC Decoding Error about 3 minutes into use

Describe the problem
I set up my Raspberry Pi 3 according to the instructions and it works well for about 3 minutes, after which the audio stops entirely. In the logs I see:
16.09.20 11:53:30 (-0400)  audio  E: [bluetooth] a2dp-codec-sbc.c: Unsupported fragmented SBC frame
16.09.20 11:53:30 (-0400)  audio  E: [bluetooth] module-bluez5-device.c: Decoding error

This is similar to the error described under Audio cuts or is very stuttery in the troubleshooting guide but not the same. Sometimes it says this Unsupported fragmented SBC frame but sometimes I get SBC decoding error (-2) instead.
Is this the same issue, which I might be able to solve by buying a USB Bluetooth dongle or is this something else?
Device information

Board (hardware info): Raspberry Pi 3
Device type (as seen in balenaCloud): Raspberry Pi 3
balenaOS version: balenaOS v2.56.0+rev2

+1, I'm having this exact same issue, but instead of getting "Unsupported fragmented SBC frame," I get not much more information.
22.09.20 18:19:15 (-0500)  audio  E: [bluetooth] a2dp-codec-sbc.c: SBC decoding error (-2) 22.09.20 18:19:15 (-0500)  audio  E: [bluetooth] module-bluez5-device.c: Decoding error

Hi,
I've the same problem with :

a RPI3
with or without a bluetooth dongle

There's no problem when I try to play music with Spotify connect, but music stop after 1sec when I try via bluetooth with android phone (I've test with 2 phones, same result each time)
09.10.20 13:06:48 (+0200)  audio  W: [pulseaudio] module-loopback.c: Cannot set requested source latency of 66.67 ms, adjusting to 250.00 ms
09.10.20 13:06:56 (+0200)  audio  E: [bluetooth] a2dp-codec-sbc.c: SBC decoding error (-2)
09.10.20 13:06:56 (+0200)  audio  E: [bluetooth] module-bluez5-device.c: Decoding error
09.10.20 13:06:59 (+0200)  audio  W: [pulseaudio] module-loopback.c: Cannot set requested source latency of 66.67 ms, adjusting to 68.54 ms
09.10.20 13:07:00 (+0200)  audio  E: [bluetooth] a2dp-codec-sbc.c: SBC decoding error (-2)
09.10.20 13:07:00 (+0200)  audio  E: [bluetooth] module-bluez5-device.c: Decoding error

I think this is a duplicate of #62

For people coming to this issue via google searching the error message:
I managed to solve this issue by using a usb bluetooth dongle.
Using RPI 3, balenaOS 2.83.21+rev1 and Supervisor version 12.11.22.

For people coming to this issue via google searching the error message:
I managed to solve this issue by using a usb bluetooth dongle.
Using RPI 3, balenaOS 2.83.21+rev1 and Supervisor version 12.11.22.

Here from Google, thanks mate.  This issue has been driving me mad for hours.  Will it just recoganise the bluetooth adapter automatically?

@thermomonkey According to the balena docs it would automatically recognize and use the connected bluetooth dongle.
Turned out I had to put it into a different USB slot and reboot the RPI, but then it automatically used the bluetooth dongle as the new default and disabled the on-board bluetooth.

I have the same issue.
I see this issue is closed but is not fixed.
Please reopen to fix this.
providing a workaround does not mean the issue is fixed.
Thanks !


[Feature] Create a benchmark script for offline inference

Motivation
Users report perf degradation of engine.generate. Add something similar to https://github.com/vllm-project/vllm/blob/main/benchmarks/benchmark_throughput.py
Related resources
No response

It would also be great to get an automated set of benchmark results with latest version of vLLM as well so users can know how much the benchmarks change with different versions.

@ByronHsu i'll pick this one up

solved by https://github.com/sgl-project/sglang/pull/1968


Feat: Extended language support for bigquery functions

Reused more config from the repo vscode-language-sql-bigquery to get better visuals of bigquery functions. Been running with these settings for a week and have not ran inte any issues.
Before:

After:

looks good to me, thank you !


git completion not working in non-bare repos

I'm using vcsh which kind of acts as a wrapper to git and splits GIT_DIR and GIT_WORK_TREE into two different folders.
The problem is when I try to run a command such as vcsh mydotfiles add <TAB> zsh simply prints the message -- not a git repository -- and doesn't complete with any file.
Note: the vcsh command works if I manually type the filename.
Note: curiously enough zsh completes vcsh commands, such as my vcsh-created repo mydotfiles and the add argument. But after that it "dies".
I'm using zgen with the following modules:
    # prezto options
    zgen prezto editor key-bindings 'vi'
    zgen prezto prompt theme 'agnoster'
    zgen prezto utility:ls color 'yes'
    zgen prezto '*:*' color 'yes'

    # prezto and modules
    zgen prezto
    zgen prezto command-not-found
    zgen prezto syntax-highlighting
    zgen prezto editor
    zgen prezto prompt

Any workaround to this?
Thanks

vcsh needs to have its own completion.

@sorin-ionescu
But is there a way to enable completion to fallback to existing files instead of "blocking"?
And I mean it in general terms, not just for vcsh.

BTW, vcsh does have some completion. It lists commands and is aware of existing repos.
 vagrant@nostromo  ~  vcsh <TAB>
 -- vcsh sub-commands --
clone            -- clone an existing repository
commit           -- commit in all repositories
delete           -- delete an existing repository
enter            -- enter repository; spawn new <$SHELL>
help             -- display help
init             -- initialize an empty repository
list             -- list all local vcsh repositories
list-tracked     -- list all files tracked by vcsh
list-tracked-by  -- list files tracked by a repository
list-untracked   -- list all files not tracked by vcsh
pull             -- pull from all vcsh remotes
push             -- push to vcsh remotes
rename           -- rename a repository
run              -- run command with <$GIT_DIR> and <$GIT_WORK_TREE> set
status           -- show statuses of all/one vcsh repositories
upgrade          -- upgrade repository to currently recommended settings
version          -- print version information
which            -- find <substring> in name of any tracked file
write-gitignore  -- write .gitignore.d/<repo> via git ls-files
 -- repositories --
mydotfiles

foo() {}
foo[tab] # Lists files.

Load the vcsh completion with a minimal zshrc, no Prezto. If it completes files, then it's a conflict with Prezto or a Prezto misconfiguration in the completion module.

FYI as suggested I tested it with a minimal zshrc and it looks like the problem is with vcsh instead.
Thanks

@alexconst I have a similar problem to setup my dotfiles using zprezto and a alias for bare-repo dot to git as I think you did. You fixed that?

Fixed here, sorry for ping this. For anyone to get in trouble this again:
Don't do that:
alias dot='git --git-dir=<dir1> --work-tree=<dir2>'

Do this:
alias dot='GIT_DIR=<dir1> GIT_WORK_TREE=<dir2> git'

For some reason I lost the autocompletion on first case, but not on the second.


LASB-878

What
Link to story
Created a new Sentry project and updated configuration files with the correct DSN.
The Sentry project can be found here
Checklist
Before you ask people to review this PR:

[x] Tests should be passing: ./gradlew test
[x] Github should not be reporting conflicts; you should have recently run git rebase main.
[x] Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
[x] You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
[x] You should have checked that the commit messages say why the change was made.

The CircleCI install_on_dev check is failing because of existing issues.


Thisyahlen/chore: move react modal types to dependencies

move react modal types to dependencies

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.94%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
106

Relevant Lines:
112

💛  - Coveralls


changing catalog.refresh.interval.seconds does not result in catalog being pulled at the specified refresh interval.

Server version - v0.49.0-rc2
Changed catalog.refresh.interval.seconds  to 60 secs using  /v1/activesettings/ .
Even after this change , catalog is being pulled only every 5 minutes (default settings).
"id": "1as11",
"type": "activeSetting",
"links": {
"self": "…/v1/activesettings/1as11",
},
"actions": { },
"name": "catalog.refresh.interval.seconds",
"activeValue": "60",
"inDb": true,
"source": "Database",
"value": "60",
},

value in settings:
| 11 | catalog.refresh.interval.seconds   | 60

This is not a bug with rancher-catalog-service code. The refresh interval can be changed for the service by restarting it and passing the parameter -refreshInterval=
@ibuildthecloud any pointers on how can I make this changes in cattle?

Fixed with PR https://github.com/rancher/cattle/pull/1449

Tested with latest build from master:
Changed catalog.refresh.interval.seconds to 30 secs using /v1/activesettings/ .
Changes made to the catalog gets synced within the next 30 secs.


Is it possible to remove the generated language, e.g. "/en/" from the generated sitemap URLs?

Sorry, I couldn't figure this out. My documentation site is only in a single language, english, and I prefer to leave the "/en/" out of all my urls. However, I can't seem to figure out how to tell this library how to remove that path from the URLs. I have tried setting language = None and sitemap_locales = [None] but it still seems to add /en/ to all the paths, which then points to 404 pages.
Is this possible to do with this package?
It seems like no matter what I do these lines:
        if  app.builder.config.language:
            lang = app.builder.config.language + "/"
        else:
            lang = ""

Always cause the language to get set.

Oops, ok I figured this out right after I asked. Answer is to add this (removing language):
sitemap_url_scheme = "{version}{link}"

Thanks for being a good rubber duck! :duck:


[Bugfix] Add bottlerocket control image on joining nodes

Description of changes:
Specifying bottlerocket control image was introduced by this patch. This feature is enabled for the first node but joining nodes will not respect the BR control image. My suspicion is that this bug was introduced after merge conflicts arose from merging upstream CAPI and this line was somehow omitted or lost.
This was discovered as I was working on #959 and noticed that it wasn't working as I expected it to.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing
I tried creating a new cluster with the patched version of BR and was successful at doing so.
Followup to #963

/ok-to-test

/cherrypick release-0.10


pageserver: permit reads behind GC cutoff during LSN grace period

Problem
In https://github.com/neondatabase/neon/issues/9754 and the flakiness of test_readonly_node_gc, we saw that although our logic for controlling GC was sound, the validation of getpage requests was not, because it could not consider LSN leases when requests arrived shortly after restart.
Closes https://github.com/neondatabase/neon/issues/9754
Summary of changes
This is the "Option 3" discussed verbally -- rather than holding back gc cutoff, we waive the usual validation of request LSN if we are still waiting for leases to be sent after startup

When validating LSN in wait_or_get_last_lsn, skip the validation relative to GC cutoff if the timeline is still in its LSN lease grace period
Re-enable test_readonly_node_gc

Running the test_readonly_node_gc for 20 times in CI just to check if this still cause any disruptions in CI. Testing PR: https://github.com/neondatabase/neon/pull/9841

Running the test_readonly_node_gc for 20 times in CI just to check if this still cause any disruptions in CI. Testing PR: #9841

Done running tests. No races detected (Allure).


Registering cells from nib.

enum with cell's source (class or nib) instead of only class option.

This looks great! Thanks for doing this 🙌

Released as part of v1.4.0 (#229) now ✌

👍 Thanks for creating Parchment. )


Starting with<EMAIL_ADDRESS>the "output_javascript" option no longer emits .d.ts files

Superseding https://github.com/timostamm/protobuf-ts/issues/643#issuecomment-2043191475 since the issue does not occur in the upstream project.
Starting with https://github.com/bufbuild/plugins/tree/main/plugins/community/timostamm-protobuf-ts/v2.9.4 when I generate code for the protos here: https://github.com/stateful/runme/tree/main/internal/api important *.d.ts files are being omitted. A downgrade to v2.9.3 solves the issue. Please note, if I use the upstream project directly (outside of Buf), I can not reproduce the issue.
Happy to refactor my proto files if that will fix the issue but I don't have an inclination how to do that. Please advise! Thank you.
Here's one of the key differences, v2.9.4; please note how the parser_pb.d.ts is absent:
internal/gen/proto/ts/runme/parser
└── v1
    ├── parser_pb.client.d.ts
    ├── parser_pb.client.js
    └── parser_pb.js

2 directories, 3 files

And here's v2.9.3:
internal/gen/proto/ts/runme/parser
└── v1
    ├── parser_pb.client.d.ts
    ├── parser_pb.client.js
    ├── parser_pb.d.ts
    └── parser_pb.js

2 directories, 4 files

@pkwarren yes, the public BSR would be https://buf.build/stateful/runme/activity/
Namely: "npm install @buf/stateful_runme.community_timostamm-protobuf-ts@latest" will pull in a v2.9.4 bundled version without *.d.ts whereas "npm install<EMAIL_ADDRESS>continues to work and includes those files.
I can't seem to reopen this issue.

@sourishkrout - This should be resolved with version v2.9.4, revision 3 of the plugin. I've verified with code generation locally that these previously missing files are now found:
google/protobuf/descriptor.d.ts
google/protobuf/wrappers.d.ts
runme/parser/v1/parser.d.ts
runme/runner/v1/runner.d.ts
runme/runner/v2alpha1/runner.d.ts

Thank you! Much appreciated.


goog.proto2.TextFormatSerializer().deserializeTo cannot handle enum with value 0

This issue was imported from Closure Library's previous home at http://closure-library.googlecode.com
The link to the original issue is:
https://code.google.com/p/closure-library/issues/detail?id=361

Fixed a while back


es_cluster_logging e2e test is flaky

It failed 3/4 times I run it, twice on head, and once with my changes (hence I assume it's not caused by changes in my client). I can't look at the history as Jenkins is down as well...
hack/ginkgo-e2e.sh --ginkgo.focus="should check that logs from pods on all nodes are ingested into Elasticsearch"
...
INFO: Waiting for pod synthlogger-0 in namespace es-logging-9667 status to be "success or failure" (found "Running") (4m43.083516019s)
INFO: Nil State.Termination for container synth-logger in pod synthlogger-0 in namespace es-logging-9667 so far
INFO: Waiting for pod synthlogger-0 in namespace es-logging-9667 status to be "success or failure" (found "Running") (4m48.226256447s)
INFO: Nil State.Termination for container synth-logger in pod synthlogger-0 in namespace es-logging-9667 so far
INFO: Waiting for pod synthlogger-0 in namespace es-logging-9667 status to be "success or failure" (found "Running") (4m53.369327371s)
INFO: Nil State.Termination for container synth-logger in pod synthlogger-0 in namespace es-logging-9667 so far
INFO: Waiting for pod synthlogger-0 in namespace es-logging-9667 status to be "success or failure" (found "Running") (4m58.609078237s)

• Failure [342.682 seconds]
Cluster level logging using Elasticsearch
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/es_cluster_logging.go:46
  should check that logs from pods on all nodes are ingested into Elasticsearch [It]
  /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/es_cluster_logging.go:45

  Expected error:
      <*errors.errorString | 0xc208235060>: {
          s: "gave up waiting for pod synthlogger-0 to be success or failure after 300.00 seconds",
      }
      gave up waiting for pod synthlogger-0 to be success or failure after 300.00 seconds
  not to have occurred

I don't think this is a flake in the test -- this is the test doing its job. The error message says that the synthlogger pod does not enter the success of failure state -- this is a bug in our system -- I thought this bug was fixed at the end of last week? @dchen1107 ?

Is this still a problem? Please let me know and I shall investigate further.

We haven't seen this error in several weeks.  Presumed fixed by etcd and watch improvements. Closing.


use some expression lambdas

@simoncropp this one is now conflicting, can you rebase and solve conflicts please?

done


SASS-1531: Added beneficial loans question page

Description

Added beneficial loans question page
Linked the page to the benefits CYA screen

https://jira.tools.tax.service.gov.uk/browse/SASS-1531
Checklist PR Reviewer
Before Reviewing

[ ]  Have you pulled the branch down?
[x]  Have you assigned yourself to the PR?
[x]  Have you moved the task to “in review” on JIRA?
[ ]  Have you checked to ensure all dependencies are up to date?
[ ]  Have you checked to ensure its been rebased against the current version of main?

Whilst Reviewing

[ ]  Have you run the tests?
[ ]  Have you run the journey tests?
[ ]  Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?

After Reviewing

[ ]  Have you checked for merge conflicts or any changes in the current main that may affect the current pull request? i.e. does it need another rebase?
[ ]  Have you checked to make sure there are no builds in the pipeline before you merge?
[ ]  Have you moved the task to “in pipeline” on Jira?

[x]  Have you rebased against the current version of main?
[x]  Have you checked code coverage isn’t lower than previously?

After PRs been raised

[x]  Have you checked the PR Builder passes?

uk.gov.hmrc.mongo:hmrc-mongo-play-28 could be bumped to 0.56.0,
uk.gov.hmrc:play-frontend-hmrc could be bumped to 1.25.0-play-28,
uk.gov.hmrc.mongo:hmrc-mongo-test-play-28 could be bumped to 0.56.0


Sample scene crashes Unity

I installed the TButt asset.
Then downloaded and added SteamVR v1.2.3 asset
I enabled the module in TButt Core settings.
Open the sample scene, hit play and Unity Crashes.
This happens every time. Unity version 2018.3.f14
I have a Vive with SteamVR running. Windows 10.
Any ideas?

Can you share your editor log file? It's working in 2018.3 and 2019.1 for me.


Update case-studies.md

add gaussian process case study description

Thanks @hyunjimoon! Have you received any feedback on this case study yet? If not I can try to find someone to give you feedback on this who is more of a gaussian process person than I am.

I have received the following feedback through the mail. There were some conflicting points but did my best to address them.
Ben Bales: keep them simple and focused, could use simulated data as engine failure details are more distracting than helpful -> Made amends by deleting some models. I tried to focus on following the Bayesian workflow.
Michael Betancourt: add data description and goals of analysis -> added link to stancon talk youtube and inserted the following:

This casestudy shows how identification and underfitting problems diagnosed from pushforward and predictive checks are addressed through reparameterization and adding variables. Basically our data is highly unbalanced per category with lots of missing data. Also, due to its hierarchical structure of a system, such as shared engine types, hierarchical model is applicable.

Bob Carpenter: I like case studies with real data. If the engine failure data is a nice illustration of some aspect of GPs, that's great---it doesn't have to be the best possible model for the engine failure data.

Ok great, just wanted to make sure that at least one person gave you feedback. Will merge this now!


Support Spring Native configuration for samples

This PR is based on the PR https://github.com/Azure-Samples/azure-spring-boot-samples/pull/209.
Relate Issue

https://github.com/Azure/azure-sdk-for-java/issues/28053

Changelog

Add a new sample for spring-cloud-azure-starter-appconfiguration usage.
Add a new sample for spring-cloud-azure-starter-storage-queue usage.
Add profile native to build spring native image.
Add profile shaded to build spring native image when found command too long error, and you should add the configuration spring.cloud.azure.compatibility-verifier.enabled=false to disable the version compatibility verifier.
[WIP] Add a section of the readme doc to introduce the support for Spring Native.

https://github.com/Azure-Samples/azure-spring-boot-samples/issues/291


Update Debian Installation docs

Update Docs for Deb INSTALL Guide.  OpenJDK11 and apt-transport-https

OpenJDK11 Ubuntu and Debian installation is not the same.  Suggest the following minor change, (in bold):

"Install Java 11:

Ubuntu:   sudo add-apt-repository ppa:openjdk-r/ppa
Debian:    sudo echo 'deb http://deb.debian.org/debian stretch-backports main' > /etc/apt/sources.list.d/backports.list

Before "4   Install OpenDistro for ElasticSearch:" the following needs to be added or indicated earlier as a pre-requisite.

apt install apt-transport-https

The previous sudo apt update will fail without apt-transport-https
These are the only two issues found while following the instructions from a clean, headless  debian 9.8 installation.

Hi @rlk5546, I really appreciate the testing and detailed issue. I'd prefer not to add the content inline, because it's not one of the operating systems we use for testing and makes the instructions harder to follow, but I've added your tips to the bottom of the page and am happy to add additional sections for any other Debian-based distributions that people test. Thanks!
https://github.com/opendistro/for-elasticsearch-docs/commit/554f6e1c8874308e8991219e9889ec96b32c3a6b


Settings: content languages list doesn't fully open

Describe the bug

Clicking "Content languages" button in settings i can't scroll languages list until i check or uncheck some language. It rarely works normal, but mostly not. Works fine in web.
To Reproduce
Steps to reproduce the behavior:

Open settings
Open "Content languages"
We're here

Expected behavior
I can scroll languages list and click "Done" immediately

Screenshots

(No "Done" button, i can't scroll)

Details

Platform: Android
Platform version: 10
App version: 1.48.0

Additional context

Also, English should be on top, like in web app

@ansh not assigning this but more evidence we need to replace bottom-sheet

Yeah we definitely need to replace bottom sheet. It's behavior on Android is just too unpredictable. I would be inclined to use a presentation: modal React Navigation screen for this. Will be a nice modal on iOS with swipe to close functionality like we have now, and on Android it will render as a normal screen. Most importantly, it will be stable on both platforms. @pfrazee
We can also work on our own bottom sheet component, but to be honest I feel like this language selector should just be it's own screen anyway.


Bug fixes for Project dependency tree nodes hierarchy

There were several issues with Project nodes hierarchy:

when A -> B and B is several levels above A, like ......\b.csproj, progression code cut node id string when coverted it to AbsoluteOr Relative Uri. We need to UrlEncode/Decode id string for nodes.
other issue is we need to use Project B dependency providers when querying hierarchy nodes under project A Dependencies to show hierarchy correctly: A -> B (and B has packages specific to B) . Before we used providers from project A and they did not know about nodes specific to B and worked only when A also had same packages as B.

@dotnet/project-system

Yes, right , will remove the tuple.
On Dec 29, 2016, at 4:07 PM, Fred Silberberg <notifications<EMAIL_ADDRESS>wrote:
@333fred commented on this pull request.

In src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Tree/Dependencies/DependenciesGraphProvider.cshttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Froslyn-project-system%2Fpull%2F1055%23pullrequestreview-14723124&data=02|01|anton.piskunov%40microsoft.com|ad218b905de64d043d9208d43047e4c2|72f988bf86f141af91ab2d7cd011db47|1|0|636186532712744421&sdata=eGkf%2BgTMt9hLTiaVd7TWYlwNMXfV%2BUiWVk5h57G8ozw%3D&reserved=0:

     {

       IProjectDependenciesSubTreeProvider subTreeProvider;

       var node = inputGraphNode.GetValue<IDependencyNode>(

                           DependenciesGraphSchema.DependencyNodeProperty);

       (IDependencyNode node, IProjectDependenciesSubTreeProvider subTreeProvider) = (null, null);

Why use tuples here? You're needlessly creating a ValueTuple and destructuring it for no purpose. Just make two variables.

You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Froslyn-project-system%2Fpull%2F1055%23pullrequestreview-14723124&data=02|01|anton.piskunov%40microsoft.com|ad218b905de64d043d9208d43047e4c2|72f988bf86f141af91ab2d7cd011db47|1|0|636186532712744421&sdata=eGkf%2BgTMt9hLTiaVd7TWYlwNMXfV%2BUiWVk5h57G8ozw%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABhLGwBuDuh0JwsusQZRaD9YNK4Q1YO2ks5rNEtTgaJpZM4LX22I&data=02|01|anton.piskunov%40microsoft.com|ad218b905de64d043d9208d43047e4c2|72f988bf86f141af91ab2d7cd011db47|1|0|636186532712744421&sdata=8%2FpS8XtxpBChpuPIFsakrn6YgUe%2BModx4IlwPUJEjJc%3D&reserved=0.

Can you help me understand the commit descriptions, ie "Temporary fixes for projects hierarchy nodes"? They don't contain enough information for me to look back and understand the problem you are solving.

You've also seem to made the same commit with the same changes multiple times - not sure how that happened.

@davkean something was messed up when i did rebase.. i did commits only once in parent  branch and then this 3rd level branch i rebased with master and commits got duplicated. Anyway - i am following with comments and squishing my commits into one  - all changes are related to the problem i mentioned in the PR description and temporary commits i made just to be able to work on other machine with newer build , it got kind of messy i agree :)

Followed up with comments, squashed ambiguous commits and created a new PR: https://github.com/dotnet/roslyn-project-system/pull/1062 . Closing this one


[Feature Request]: Add Influxdata Repositories

Description
Please add the Influxdata Repos to the Docker Image. This would make it possible to add the client components (influxdb-client, influxdb2-cli) via the "PACKAGES" environment variable.
Manually I can achieve this using the commands:
wget -q https://repos.influxdata.com/influxdata-archive_compat.key
cat influxdata-archive_compat.key | gpg --dearmor | sudo tee /etc/apt/trusted.gpg.d/influxdata-archive_compat.gpg > /dev/null
echo 'deb [signed-by=/etc/apt/trusted.gpg.d/influxdata-archive_compat.gpg] https://repos.influxdata.com/debian stable main' | sudo tee /etc/apt/sources.list.d/influxdata.list

As discussed at Discord I would prefer not to include third party repos into the docker image by default.
But maybe we can handle that database backup topic like avahi or z-wave are handled.

The suggested feature is available for testing in v8.1.0-beta.2.
So I'll close this now.
Regards,
André


webpack?

Hi, am evaluating Vue 2.0 alternatives to vue-typescript (which seems to be dormant on Vue 1.0), and am wondering whether you have an example using webpack and jest (instead of browserify and jest).
Thanks
David

Hi David,
we are not using Webpack internally. I took a quick stab at it using the vue-cli webpack template. You can have a look at result here: https://github.com/locobert/vue-typescript-component-example-webpack
Besides adding the dependencies and a tsconfig.json, the actual change to the build configuration file has been quite small. The source code and the tests are from our browserify example.
However, we currently do not plan to maintain that example and it has not been thoroughly tested.

Please reopen if you have more questions.


Shader preprocessor: fix macro expansion inconsistencies with glsl

fixes Issues 1,2,3,5,6,8 from #96253
fixed shader preprocessor macro expansion order and recursion
added shader preprocessor support for 0 argument funktionline macros
fixed shader functionlike macros expansion with 0 arguments
fixed functionlike macro argument expansion re-expanding already replaced macros
refactored macro expansion
added multiple tests

Thanks for the quick PR!
Might be prudent to also add a test case for the opposite just in case, e.g.:
#define nonfunctionlike 42
const int a = nonfunctionlike + nonfunctionlike();
// expects: const int a = 42 + 42();
// no preprocessor error

I've updated the PR to also include fixes for issues 5,6 and 8 from #96253
( See no reason to open a second PR since the two would have been tightly connected and this hasn't been reviewed yet.)
If this gets merged we can close #96253 since issue 4 is superfluous. (discussed in the 2024-09-03 rendering meeting.)
I also added more preprocessor tests using glsl as a reference point.


#3468 continued: Add support for np.clip

This PR contains the code from #3468, rebased on master and current issues resolved. After rebasing, the following two issues were present:

NumPy behaviour for clip where min > max changed, making the check np.testing.assert_equal(pyfunc(a, 8, 5), cfunc(a, 8, 5)) fail. The fix to this is to implement np_clip_impl similarly to _NPY_CLIP, which is defined as _NPY_<type>_MIN(_NPY_<type>_MAX((x), (min)), (max)).
The lower_clip_result function in the test should call the jitted function, not the Python one.

cc @arvoelke

@stuartarchibald As we discussed out-of-band, I've simplified the implementation of np.clip to use a single function for all cases of the presence of a_min and a_max. Assuming tests are green, this should be ready for review now.

@stuartarchibald Thanks for the review - all the comments should be addressed now, except for a question about the test where min > max - what do you think about removing that (odd) check?

@stuartarchibald Thanks for the review - all the comments should be addressed now, except for a question about the test where min > max - what do you think about removing that (odd) check?

Thanks for the fixes. I've replied inline above.

@stuartarchibald I think the only remaining comment is now addressed.