Update README.md

@CodiumAI-Agent /review

PR Review

 ⏱ Estimated effort to review [1-5]
1, because the PR is focused on updating the README.md file, which typically involves text changes rather than code. Reviewing documentation changes is generally less complex and time-consuming than reviewing code changes.

 🧪 Relevant tests
No

 🔍 Possible issues
No

 🔒 Security concerns
No

 Code feedback:

 ✨ Review tool usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the 'possible issues' section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_ticket, and more.

  Auto-approve PRs
By invoking:
/review auto_approve

The tool will automatically approve the PR, and add a comment with the approval.
To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following:
[pr_reviewer]
enable_auto_approval = true

(this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository)
You can also enable auto-approval only if the PR meets certain requirements, such as that the estimated_review_effort is equal or below a certain threshold, by adjusting the flag:
[pr_reviewer]
maximal_review_effort = 5

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

PR Analysis

🎯 Main theme: Update README.md with project details
📝 PR summary: The PR updates the README.md file with a detailed description of the project idea and a plan of action. The project is a website for booking IPL match tickets and getting local food suggestions.
📌 Type of PR: Documentation
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 1, because the PR is straightforward and only involves changes to the README.md file.
🔒 Security concerns: No

PR Feedback
💡 General suggestions: The PR is well-structured and provides a clear understanding of the project. However, it would be beneficial to include more details about the technologies and tools that will be used in the project. Also, consider adding a section for 'Future Enhancements' or 'Scope for Improvement'.

 ✨ Usage guide:
Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:
[pr_reviewer]
some_config1=...
some_config2=...

  Utilizing extra instructions
The review tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize.
Examples for extra instructions:
[pr_reviewer] # /review #
extra_instructions="""
In the code feedback section, emphasize the following:
- Does the code logic cover relevant edge cases?
- Is the code logic clear and easy to understand?
- Is the code logic efficient?
...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  How to enable\disable automation

When you first install PR-Agent app, the default mode for the review tool is:

pr_commands = ["/review", ...]

meaning the review tool will run automatically on every PR, with the default configuration.
Edit this field to enable/disable the tool, or to change the used configurations

  About the 'Code feedback' section
The review tool provides several type of feedbacks, one of them is code suggestions.
If you are interested only in the code suggestions, it is recommended to use the improve feature instead, since it dedicated only to code suggestions, and usually gives better results.
Use the review tool if you want to get a more comprehensive feedback, which includes code suggestions as well.

  Auto-labels
The review tool can auto-generate two specific types of labels for a PR:

a possible security issue label, that detects possible security issues (enable_review_labels_security flag)
a Review effort [1-5]: x label, where x is the estimated effort to review the PR (enable_review_labels_effort flag)

  Extra sub-tools
The review tool provides a collection of possible feedbacks about a PR.
It is recommended to review the possible options, and choose the ones relevant for your use case.
Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example:
require_score_review, require_soc2_review, enable_review_labels_effort, and more.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.


ci: タグの形式の修正

Type of Change:
CI の修正
Details of implementation (実施内容)
ドキュメント を読んだところ, タグの形式が間違っているようなので直しました

Codecov Report

Merging #682 (9183245) into main (733be04) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #682   +/-   ##
=======================================
  Coverage   72.36%   72.36%
=======================================
  Files          66       66
  Lines        4643     4643
  Branches      437      437
=======================================
  Hits         3360     3360
  Misses        849      849
  Partials      434      434

Flag
Coverage Δ

unittests
72.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


401 Unauthorized

Hey guys! I have an issue with authentication. I'm trying to connect in this way:
$test = new CardConnect\CardPointe('merchant_id', 'login', 'pwd', 'https://fts-uat.cardconnect.com:6443/');
But I always get "401 Unauthorized"
I am 100% sure that I entered valid login/pass/merchant ID, but it still not working for me :(
Can you tell me what could go wrong? Maybe is some initial config missing from the Cardconnect side?

Hi @morcano,
I think the issue is you are using your production credentials with the sanbox url:
SANDBOX URL: php https://fts-uat.cardconnect.com/ .
PRODUCTION URL: php https://fts.cardconnect.com/ .
$client = new CardConnect\CardPointe('merchant_id', 'login', 'pwd', 'https://fts.cardconnect.com/');

if ($client->testAuth()) {
   echo 'AUTH WORKS';
}

I recommend you to check the test class, everything you need to know is there.
Let me know if works for you.

Solved. I used incorrect credentials, sorry 🙄


update(): update pgp tutorial to match the screenshot buttons

Tutorial contradict the screenshot:

Maybe we should complete the steps by adding und klicke auf Weiter

Working on it, screenshots will be changed after the holidays

Spotted another big problem: PGP has been replaced by Enigmail as far as I can see; going to change the whole tutorial on Friday

This issue is not needed anymore


Raise error on wildcard import

Raise error on from module import *
Before
package main:
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:5:31: expected 'STRING', found '*'
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:15:2: expected 'STRING', found 'var'
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:17:2: expected 'STRING', found 'var'
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:19:2: expected 'STRING', found 'var'
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:20:2: expected 'STRING', found 'for'
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:21:3: expected 'STRING', found 'switch'
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:27:3: expected 'STRING', found 'if'
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:28:4: expected 'STRING', found 'continue'
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:29:3: expected 'STRING', found '}'
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:30:13: expected 'STRING', found '='
/var/folders/9j/12cqyk6x2s5dc22x2mnlpmmw0000gn/T/tmp5BoqG5.go:31:3: expected 'STRING', found 'if'
make: *** [run] Error 1

After
line 4: wildcard member import is not implemented: from collections import *
make: *** [run] Error 1

Oh, Completely forgot that. Will do.

Added tests and moved to top of the block, and added a comment.

Fixed comment and changed order of function.


Review REQUESTED – L1 DOC TMP Porewater

@stephpenn1  could you please review these "L1" DOC files and let me know if they are at the correct processing level before I put them on Google Drive?
https://github.com/COMPASS-DOE/TEMPEST_Porewater/tree/main/processing_scripts/DOC/TEMPORARY

Yes sure, when do you need this reviewed by?

@stephpenn1 didn't see your reply! Does in the next two weeks work? I also have the CDOM data ready to review now too. https://github.com/COMPASS-DOE/TEMPEST_Porewater/tree/main/processing_scripts/CDOM/TEMPORARY
Once you review and approved, I'll put in the google drive :)

Hi! Your datasets look great, I just have a few questions and suggestions:

I noticed there aren't any flags, were there any that were applied?
In your plot column, I think we are using Saltwater but we'll need confirmation on this (I'll check)
My preference for theEvent column would be to change it to site (and lowercase to match the other columns)
Any date columns like evacuation_date  collection_datetime and tz should be on the left side of the datasets with the other metadata columns
I like the standardization of the filenames :-) although they're a little bit inconsistent; for example, instead using
TMP_PW_GRIDS_NPOC_TDN_2022_L1.csv
and
TMP_PW_GRIDS_POOL_Indicies_CDOM_2022_L1.csv
so that they go SITE_SAMPLETYPE_ORG_ANALYSISTYPE_YEAR_LEVEL.csv thoughts?

Also, let me know if I am not reviewing these datasets in the way you intended


Update links

With the move to dask-contrib, there are probably several places in which we need to update text and links. This is a placeholder to remind us to do it. (In the meantime, github is really good at forwarding to the new URL, so this is not critical).

I think I took care of this here https://github.com/dask-contrib/dask-awkward/commit/9dd138e5059a1efe39775ebc3de5d41f018fc884 but there could be stragglers

I think we're good here


Information About Issues

From @stealthybox
component-base is an automated staging repository from k/k, so most of the issues end up on kubernetes/kubernetes or their associated component's repo's.
See:

Project Board
k/k Issues/PR's needing Review
The wg label has also been used in other orgs and repos such as kubernetes-sigs/kubebuilder.
For repos outside of the kubernetes org, I've just been adding links to the respective issues on the Project Board.

/wg component-standard


Remove cruft from retry.hpp

I often insert trailing comments like that to keep clang-format from doing something weird. Have you tried running clang-format over that file after the change?

Ah, I didn't realize this was there to work around clang-format's output. Sure enough, if I remove the comment clang-format makes this less readable. Closing this.


More deprecations pre-2.0

QUnit.reset
QUnit.config.autorun
Assert#throws
extra cleanups

Closes #453
Closes #974 - @gibson042, would you confirm this one, please?
Closes #660
Closes #604

I looked through all commits one by one, looks good to me.

Thanks, @jzaefferer!
rc is coming!


Add new 'NonGovukDomains' module with 'EXTERNAL_HOST_REDIRECT_ALLOW_LIST' constant

Currently, we have to try to keep three different allowlists in
sync:

https://github.com/alphagov/whitehall/blob/b3ce66d717e8a78a2f59a3fce36f271359ab09e1/app/validators/gov_uk_url_format_validator.rb#L3-L11
https://github.com/alphagov/short-url-manager/blob/d11edaa002b7c37eb7b3e45c1c289d99443eceef/app/models/concerns/short_url_validations.rb#L4-L15
https://github.com/alphagov/publishing-api/blob/c82ab015b0751803302e352fc19deb23630daa7d/app/validators/routes_and_redirects_validator.rb#L2-L11

If the lists fall out of sync, we risk being inconsistent in which
domains we allow redirects to, and potentially a data integrity
issue whereby a publishing app might think a redirect is fine,
but it's ultimately rejected in Publishing API.
This PR copies over the current iteration of allowed redirect
domains (which have been double-checked with Policy and Strategy
in https://gds.slack.com/archives/CADTL63QR/p1714556082803429).
When this is released, we can then update the publishing apps to
refer to this shared allowlist instead.

The lists need to be kept separate - see https://govuk.zendesk.com/agent/tickets/5819962.


DS18B20 is not working

Hi,
I have two DS18B20 in parallel connected to my RPi 3b, but they are not showing up.
The sensors are working, as I had them on a ESP before.
I tried GPIO 4 and 26 without success.
Any idea?

Problem is based in-front of the PC :-)


fix(circuit relay): Adding ability to creating and consume circuit re…

…lays

:tada: This PR is included in version 5.0.3 :tada:
Your semantic-release bot :package::rocket:


guard against output in the user's profile file when shelling out

On a mac, we shell out to the user's default shell. So instead if which flutter we run /bin/bash -c -l 'which flutter'. If their profile file prints to stdout, we'll interpret that as results from which. We should introduce some text we can parse out. Something like: /bin/bash -c -l 'echo ------; which flutter'.

worked around in https://github.com/dart-atom/atom.dart/pull/17


Refactor and Test server core query package

Add unit test for org.apache.skywalking.oap.server.core.query package

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[ ] Improve performance

Related issues

Bug fix

Bug description.

How to fix?

New feature or improvement

Describe the details and related test reports.

#2654 is planned to be merged after UI updated. I prefer you could adopt that after merged.

okay

#2654 merged. Please update this pull request.

Also, this title doesn't fit the PR very well. This PR includes a lot of refactors to codes.

Coverage increased (+1.8%) to 18.613% when pulling 8224590ce7966c173798129a4dc858c5494cc389 on flycash:test-server-core-query into 1530a663d2d5c2a7925930006a29e7c4c874f785 on apache:master.

Coverage increased (+1.8%) to 18.613% when pulling 8224590ce7966c173798129a4dc858c5494cc389 on flycash:test-server-core-query into 1530a663d2d5c2a7925930006a29e7c4c874f785 on apache:master.

I would add the comments but it would take some time due to my terrible English.

Take your time. I could help you with English when you have a draft, and make the test codes more readable.


http:client: Add documentation

Signed-off-by: Flavio Ceolin<EMAIL_ADDRESS>

:+1:

+1

merged, thanks


Rewrite yajl_lexer to Lexer

Fixes #15
Summary by Sourcery
Tests:

Add a test script execution test case in Rust to run all parsing test cases using a shell script.

@sourcery-ai review

@sourcery-ai review


Documentation might need updated

I was trying to utilize this command
ffmpeg -i input.mkv -c:v copy -vbsf hevc_mp4toannexb -f hevc - | dovi_tool demux -
on newer versions of FFMPEG and getting the error Unrecognized option 'vbsf'..
Looks like FFMPEG no longer supports this and expects bsf in it's place.
In the documentation it shows an example:
ffmpeg -i INPUT.mp4 -codec copy -bsf:v hevc_mp4toannexb OUTPUT.ts

They were deprecated long ago and recently got completely removed.


STM32L4 clock options and regulator power

This includes:

Interface to select the core regulator voltage according to clock frequency range
Usage of this interface during clock configuration according to chosen clock frequency
Little fix that didn not really permit choosing the MSI clock frequency
Option to choose a different system clock than the main PLL (there is HSI, MSI, HSE and LSE available to use), to do this you should define STM32L4_BOARD_NOPLL on your board header.
Option to not enable the main PLL which allows for reduced power usage when setting one of the above options as system clock

Just fixed all styling problems. the pwr files had most comment lines span outside the 78th column. Fixed all of them (for some reason nxstyle only reported the problem in a few places).


Creating a DMG fails with /var/root/bin does not exist

when I try make DMG app for make
sudo ant dmg
jre-8u131-macosx-x64 I have, Mac OS 10.12.5
BUILD FAILED
/Users/nikki/jitsi/resources/install/build.xml:1385: The following error occurred while executing this line:
/Users/nikki/jitsi/resources/install/build.xml:1426: /var/root/bin does not exist.

/Users/nikki/jitsi/resources/install/build.xml:1426: /var/root/bin does not exist.

The build.xml doesn't contain /var/root anywhere. Where is this coming from? What version are you trying to build? Line 1426 in the current master branch doesn't call anything either (it's an empty line).

No feedback, closing.


Outline in GCP does not work in Iran. It seems that GCP servers are not accessible from IRAN, but digital ocean works

Yeah they are blocked. since looooooong time ago! Google is acting like A$#holes unfortunately!
BTW i didnt have any luck setting up Outline Server on my VPS tonight. Clients get connected but no data transfer happens.
I dont know if its caused by a setup error or Islamic Regime DPI $hit is blocking shadowsocks

Same problem, successfully connected but no up/down, also existing on DO servers.

Irancell and IR-TCI(Mokhaberat) banned shadow socks , but still we can use outline "Hamrah1" mobile operator  . Friends in Iran please put your experience about this . which server worked for you . we  are using amazon digital ocean now.

ssfully connected but no up/down, also existing on DO server

True, there is no transfer but it seems it is connected.

I have a server located in US which is not working for Iran now. How if we have teh server outside of US for exampel in Asia or EU ?

Nonworking! Amazon, google! Server in us or India! Nonworking!

I had no luck so far with GCP or AWS.
I have tried GCP servers in India and Germany, and I've tried  AWS servers in India and Poland.

I prefer Linode for it, and connected properly!

There's a solution, you need to use mask to hide provided premium IP by google, use static based on your verified IP then it's okay, but if you're gonna contribute it, then it will be banned again, so configure load balancer using UDP and reserved for the TCP, ping it first to make sure it works then reserve it. you've other solution to use HA, it's little bit costly. Digital Ocean or Amazon is also okay but the big benefit with the Google Cloud, is that if you're fine with a US IP, you can use the free tier, and run your VPN non-stop for free. The benefit of Digital Ocean, though - is that you have a fixed price for any location. So for $6 you can get a VPN anywhere Digital Ocean has a location. Or for $0 you can get a Google Cloud VPN in the US. Both with 1GB of bandwidth, and you'll pay extra for going over that. Good luck guys. 👍

Thanks a lot for the solution, I'll update you about it!

Thanks a lot for the solution, I'll update you about it!

Any luck?

No success for me either. I have checked with people in Iran and am afraid the issue is not server at all. it is with the new method that the Iran government is battling VPNs. they are fluctuating the speed of the internet so much that most VPNs can't establish a secure connection. A more flexible Vpn like express-vpn is working without much problem while the outline fails to establish the basic connection.

Any update please?

من به تازگی چندین سرور اوت لاین ساختم اما فقط روی اپراتور همراه اول کار میکند!
به تازگی با شخصی آشنا شدم که کلید دسترسی میفروشد که روی همه اپراتور ها کار میکند
او از hetzner استفاده میکند برای ساخت سرور و از آی پی آلمان
I just made several outline servers but it only works on the first mobile operator!
I recently met someone who sells an access key that works on all operators
He uses Hetzner to build the server and the German IP


Critical Problem

This is not really an issue, it is simply a thank you for uploading such an amazing package.

👍 Thank you :)

👍 Thank you :)


Fix Makefile for macOS pt. 2

This PR moves bin/health-checker to the BINARIES_LINUX_ONLY variable in the Makefile so that builds can complete successfully on macOS.

/ok-to-test

Turns out this is only required for my other branch, apologies!


error: LoadLibraryEx on mono

Hi,
When trying to run this under mono, I get the following:
Loaded assembly: /Users/whatever/InsertIcons/bin/Debug/InsertIcons.exe
Loaded assembly: /Library/Frameworks/Mono.framework/Versions/4.6.1/lib/mono/gac/System/<IP_ADDRESS>__b77a5c561934e089/System.dll [External]
Loaded assembly: /Library/Frameworks/Mono.framework/Versions/4.6.1/lib/mono/gac/System.Core/<IP_ADDRESS>__b77a5c561934e089/System.Core.dll [External]
error: LoadLibraryEx

My .NET-fu isn't that strong. Do you have any ideia what this could be and how to go about debugging it? Thanks.

Sorry, don't really have any ideas. I don't use .NET anymore so I'm a  bit rusty :)

It turns out that a lot of Kernel32 isn't supported under mono. I tried using wine with dotnet installed in order to run it, it did insert the icons but then Windows refused to run the .exe, something to do with not being able to determine the required .net version. I ended up using ResourceHacker.
Thanks anyway!

Ok, thanks for reporting back, maybe this can help others who run into similar problems.  👍

@entonio would you mind looking into this and submit a pr? Perhaps the latest version might work a little better (.NET 4.7)


[REQUEST] Alongside Unsplash, add other picture APIs

Hi, there are several sources of rotating pictures you could add.
Some suggestions are:

Bing daily pictures;
NASA's image of the day;
The Guardian's best photographs of the day;
Nat Geo photo of the day.

Thanks!

So the idea with Unsplash is being able to search through their images, instead of the banner cycling through random images periodically, in case there was confusion there (though that sounds like an interesting idea, but one that I might put further down the backlog).
The only "true" API listed there is NASA's (and you can kinda sneak into Bing's), but I might keep an eye out for other sources if I take on this idea! I wanna gauge first how many users use this plugin since I'll have to make a middleman API myself, & then I'll see with that if/when to work on the Unsplash search

What I'd thought of was an option to automatically add a random banner to any note you create, based on those daily rotations. Or maybe having it so Daily Notes using Banners accesses the Bing API and sets the banner for 2021-09-22 or something like that as the daily wallpaper for that day.
But yes, my apologies, I mistakenly thought "well, they have these rotations of images, so they surely must have an API for people to use them, right?".

Also, it seems there's a hook for the NatGeo Photo of The Day.
at: https://github.com/sterlingw/Nat-Geo-Photo-of-the-Day-API

Dear，you can check obsidian templater out.
it's a module that allow plugin to fetch Unsplash pics randomly .
https://silentvoid13.github.io/Templater/docs/internal-variables-functions/internal-modules/web-module


move distribution artifacts to distribution/target

move distribution artifacts to distribution/target

Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 8.404 sec <<< FAILURE! - in io.druid.query.extraction.namespace.TestKafkaExtractionCluster```

cool :+1:

:+1:


Title field is not grayed out when edited offline

Details

Add a fix for expense report titles so they properly gray out when edited in offline mode.
Fixed Issues

$ https://github.com/Expensify/App/issues/45072
PROPOSAL: https://github.com/Expensify/App/issues/45072#issuecomment-2219987193
Tests

Go to workspace chat
Submit an expense
Click on the expense preview
Go offline
Click on the report header
Click Title field
Edit the title and save it
Confirm it changed it's state to reflect being changed in offline mode to be greyed out

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Desktop
https://github.com/user-attachments/assets/3fee7f2b-5b92-4d96-88f3-7b2d60b13df0

cc: @fedirjh

@fedirjh I've added your review suggestions and merged with latest main, ready to be re-reviewed.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.0.13-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fix mysqli2 parent class.

The mysqli2 class must extends the mysqli class and not the base class.
If this is not done, PHP will reject any attempt to use the mysqli2 class due to unimplemented abstract functions.

What an oversight on my part ... thanks for fixing!


Please add/expose pip access through firewalls

Currently I cannot use pipreqs other than with locals settings as I am behind a poxy server, spelling intentional.
But pip allows working with --proxy= when using from the command line.
If this was exposed as a command line option then the flexibility would be there for pipreqs.

This should work in version 0.3.0, just pass --proxy with host in format user:password@proxyserver:port, the argument is then passed down to the requests library http://docs.python-requests.org/en/v1.0.4/user/advanced/#proxies
Tell me if you got it working

Not behind the proxy now 20:15 and the poxy proxy is at work - I'll try to get a chance to try it tomorrow.

With 0.3.0 if I use:pipreqs --proxy our_proxy
'use:pipreqs --proxy our_proxy . or 'use:pipreqs --proxy our_proxy filename.py
then I get an usage message:
Usage:
pipreqs [options]
If I use --proxy=our_proxy then I get --proxy must not have an argument
I suspect that it is trying to read the proxy from an environment variable because if I use just --proxy then I get:
Traceback (most recent call last):
File "c:\python27\lib\runpy.py", line 162, in _run_module_as_main
"main", fname, loader, pkg_name)
File "c:\python27\lib\runpy.py", line 72, in run_code
exec code in run_globals
File "C:\Python27\Scripts\pipreqs.exe_main.py", line 9, in
File "c:\python27\lib\site-packages\pipreqs\pipreqs.py", line 208, in main
init(args)
File "c:\python27\lib\site-packages\pipreqs\pipreqs.py", line 188, in init
pypi_server=pypi_server)
File "c:\python27\lib\site-packages\pipreqs\pipreqs.py", line 89, in get_impor
ts_info
response = requests.get("{0}{1}/json".format(pypi_server, item), proxies=pro
xy)
File "c:\python27\lib\site-packages\requests\api.py", line 69, in get
return request('get', url, params=params, **kwargs)
File "c:\python27\lib\site-packages\requests\api.py", line 50, in request
response = session.request(method=method, url=url, **kwargs)
File "c:\python27\lib\site-packages\requests\sessions.py", line 465, in reques
t
resp = self.send(prep, **send_kwargs)
File "c:\python27\lib\site-packages\requests\sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "c:\python27\lib\site-packages\requests\adapters.py", line 337, in send
conn = self.get_connection(request.url, proxies)
File "c:\python27\lib\site-packages\requests\adapters.py", line 244, in get_co
nnection
proxy = prepend_scheme_if_needed(proxy, 'http')
File "c:\python27\lib\site-packages\requests\utils.py", line 652, in prepend_s
cheme_if_needed
scheme, netloc, path, params, query, fragment = urlparse(url, new_scheme)
File "c:\python27\lib\urlparse.py", line 143, in urlparse
tuple = urlsplit(url, scheme, allow_fragments)
File "c:\python27\lib\urlparse.py", line 182, in urlsplit
i = url.find(':')
AttributeError: 'bool' object has no attribute 'find'
but --help does not mention which environment variable is used.

I clarified in --help that
$ export HTTP_PROXY="http://<IP_ADDRESS>:3128"
$ export HTTPS_PROXY="http://<IP_ADDRESS>:1080"

environment variables are used. So if you set those env variables then they will automatically be passed down to the requests library

That should cover it nicely apart from one last question shouldn't the HTTPS URL start with https - I am not sure but I would have expected them to?

Thanks. That's a good point, I will change it to https

Cheers - I will close this issue now on the basis that you have it in hand.


[Bug]: An error occurred while uploading two pictures.

What happened?
GalleryJsonMedia\Form\JsonMediaGallery::GalleryJsonMedia\Form{closure}(): Argument #1 ($file) must be of type array, Livewire\Features\SupportFileUploads\TemporaryUploadedFile given
How to reproduce the bug
upload two pictures
Package Version
1.2
PHP Version
8.3.3
Laravel Version
10.48.7
Which operating systems does with happen with?
Windows
Notes
No response

Did the field cast as array ?

I'm working on it

try the v2.x with php 8.2 minimal


Change max-width of central body?

So the central body element <markdown-style class="markdown-style"> has a set max-width of 960px, directly on the element. Any way to change this so I can make my site appear wider on wider screens (like max-width: 80%)? Tried putting ".markdown-style": "max-width: 80%" in the package.json config but that doesn't work (which makes sense as the styles are directly on the element).

@Regenhardt Upgrade v3.5.4
$ npx markdown-to-html-cli --markdown-style-theme dark --markdown-style "max-width: 1260px"

- name: Converts Markdown to HTML
  uses: jaywcjlove/markdown-to-html-cli@main
  with:
    source: README-zh.md
    output: coverage/action.html
    markdown-style: "max-width: 1260px"
    github-corners: https://github.com/jaywcjlove/markdown-to-html-cli

Amazing, thanks!
In case anyone else finds this through google or whatever and gets the same problem as me passing it in Gitlab yaml, here's my Gitlab CI script to make a website from all md files:
  script:
    - mkdir -p public
    - 'for file in *.md; do markdown-to-html --markdown-style "max-width: 1440px; width: 80%" --source $file --output "public/${file%.md}.html"; done'
    - for file in *; do [[ ! -d "$file" && ! "$file" =~ \.(md|yml)$ ]] && cp -- "$file" "./public"; done


Add new configurable correlation header

Is your suggestion related to a missing or misleading document? Please describe.
With 5.12. we are planning to add a configurable header which will serve as correlation.
Purpose

For correlation purposes though Identity server sends a traceId in the response body in most of the cases, there are instances that we cannot add to response body as it leads to spec violations. And having our own configurable correlation ID added to the header will enable error tracking and issue resolving in deployments very effective. Hence we have to add a configurable trace id to the response headers.

Sample
You can add this to the deployment.toml
[correlation]
response.header = "X-Org-Correlator"

Default
X-WSO2-TraceId
Related Issue

https://github.com/wso2-support/product-is/issues/759

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


ExecutionContext moved or removed with newer SDK version

Under Binding types > the UseCore section speaks of ExecutionContext which is bound to a dead github link.
Manually navigating the SDK repository gives off the impression it has been restructured (compared to the link) thus I'm guessing this property has been moved (or perhaps removed)?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a4500b14-64b4-4d1b-aae3-f0fd4dde85f2
Version Independent ID: 8fb75741-37b9-b45f-c0ca-9948ddaf1c06
Content: How to use the Azure WebJobs SDK
Content Source: articles/app-service/webjobs-sdk-how-to.md
Service: app-service-web
GitHub Login: @ggailey777
Microsoft Alias: glenga

Hi @VladDerptastic, thanks for the feedback! We are currently investigating and will update you shortly.

@VladDerptastic thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

Hi @ggailey777,  can you please look into this?

@VladDerptastic v3.x updates are nearly done. Thanks for your patience!

The updates are now live and we can #please-close this issue. Please reopen if we have not addressed your issue to your satisfaction.

Thanks for the update @ggailey777.
We will now proceed to close this thread.


Socket timeout using SFDX

After using SFDX on my mac via the pkg installer for years, we've decided to move to NPM version.  But after uninstalling and installing via NPM I now get socket timeout issues.
I am on a Mac with Apple Silicon (Mac Studio)
I had SFDX installed via the pkg installer for years with no issues.  I uninstalled via this link
https://developer.salesforce.com/docs/atlas.en-us.sfdx_setup.meta/sfdx_setup/sfdx_setup_uninstall.htm
Then I installed via npm
npm install sfdx-cli --global
npm install @salesforce/cli --global
I was at
sfdx-cli/7.196.9 darwin-arm64 node-v20.0.0
@salesforce/cli/1.74.7 darwin-arm64 node-v20.0.0
I did not reinstall any plugins that I might have had.
When I try to push, I get the following error even though when I go to the salesforce org, the deployment shows that it succeeded.
Here is the result:
{
"name": "DeployFailed",
"actions": [],
"exitCode": 1,
"data": [],
"result": [],
"commandName": "Push",
"warnings": [
"We plan to deprecate this command in the future. Try using the "project deploy start" command instead.",
"The "-u" flag has been deprecated. Use "--target-org | -o" instead."
],
"message": "Push Failed.",
"stack": "DeployFailed: Push failed. \n    at PushResultFormatter.getJson (/opt/homebrew/lib/node_modules/sfdx-cli/node_modules/@salesforce/plugin-source/lib/formatters/source/pushResultFormatter.js:37:27)\n    at Push.catch (/opt/homebrew/lib/node_modules/sfdx-cli/node_modules/@salesforce/plugin-source/lib/commands/force/source/push.js:165:23)\n    at Push._run (/opt/homebrew/lib/node_modules/sfdx-cli/node_modules/@oclif/core/lib/command.js:112:29)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\n    at async Config.runCommand (/opt/homebrew/lib/node_modules/sfdx-cli/node_modules/@oclif/core/lib/config/config.js:328:25)\n    at async run (/opt/homebrew/lib/node_modules/sfdx-cli/node_modules/@oclif/core/lib/main.js:89:16)",
"context": "Push",
"status": 1
}
Attached is the output from push command with --dev-debug option
pushlog.txt

two things:

we've got a change that should help get the error message into the json output so you don't have to dig in the log files to get it.
I'll add the socket connection timeout to the list of things we retry.  Thanks for reporting!


Update fantastical extension

Description
Fixes #10099
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

thanks or fixing thing, looks good to me 👍


use latest version of package instead of first one

for example kernel packages can be installed in multiple versions and picking the highest version instead of first one found is useful for vulnerability and system patch management apps
or maybe better - all installed package versions should be stored, getting the highest version is only better than current state though, what do you think?

@jdobes I think its best to record all of the data, and then let the apps parse out what they need. For example, system comparison would want all of the kernel RPMs reported for side-by-side comparison of what's installed across systems.

@beav I agree, it makes sense to have all package versions in the record. I can update the PR to save all versions instead of only the latest one. However, I need to figure out what's the best way to filter out only the latest versions from result NEVRA list in our app, I think all NEVRAs obtained from inventory will need to be re-parsed.

@jdobes I am working through the same issue in comparison, this PR raises a good question :)
I'll send an email to my group and we can discuss and see what we want to do. I like having all of the nevras for a package recorded, but I can see how it can cause issues.
Is this problem specific to kernel packages, or can others be installed side by side in the same way?

@beav AFAIK, it's specific only kernel-related packages, for example on my workstation I have these packages installed in multiple versions:
kernel
kernel-core
kernel-modules
kernel-modules-extra

@beav @jdobes great! If ya'll are happy with it, I'm happy with it. I'll merge


Include comment in generated SW file

Feedback from @devnook: It would be a good idea to provide a comment at the top of the generated service worker file pointing to the relevant documentation, as well as pointing to an example of how to register the service worker from client pages.
C.f. the more draconian comment warning at https://github.com/GoogleChrome/sw-precache/blob/master/service-worker.tmpl#L17

This is something you get used to once you've used the generated SW for a while and I've definitely noticed folks trip up on it on occasion. I think including a comment is a great idea.

@jeffposnick was there anything else you wanted beyond this: https://github.com/GoogleChrome/sw-helpers/blob/master/packages/sw-build/src/lib/templates/sw.js.tmpl#L4


How to obtain the original unaggregated cxg dataset

Thanks for this amazing work. I was wondering how can I get the original cxg dataset. I try to use the "sc_target_evidence/src/process_sc_data.py", but it seems "TargetDiseasePairs_OpenTargets_cellXgeneID_12072023.csv" is missing.

Hi @mrbeann, thanks for pointing this out! In practice you only need that file if you set --keep_all_genes to False in the script parameters (which we never did in the final analysis). That table contains the list of gene-disease pairs included in Open Targets, which are included in the results table.
I will amend the scripts to avoid future confusion during revision.

Thank you for your reply. But the format in "suppl_table_disease_target_evidence.csv" seems different from  "TargetDiseasePairs_OpenTargets_cellXgeneID_12072023.csv", and this file will read even if --keep_all_genes to True.
I guess you mean we can skip Line 61 "all_genes_ls.extend(target_genes)"?


The parameter wrapWidth in the file Broadcast.js is calculated incorrectly for non-ascii characters

Compare the description of the same room in English and Russian.

I'm sorry this is not a server issue. This is a problem with the client for the game.


Floating button not fixed

This is a (multiple allowed):

[x] bug

[ ] enhancement

[ ] feature-discussion (RFC)

Framework7 Version: Latest using Vue

Platform and Target: Android

Live Link or JSFiddle/Codepen: PREFERABLY (IF YOU WANT YOUR ISSUE TO BE RESOLVED ASAP). You can start from forking one of the templates: iOS JSFiddle/Codepen, Material JSFiddle/Codepen

What you did
EXPLAIN WHAT YOU DID, PREFERABLY WITH CODE EXAMPLES, HERE.
Created navbar with floating button in it
<f7-navbar title="My App">
                <f7-fab color="red">
                    <f7-icon icon="icon-plus"></f7-icon>
                </f7-fab>
</f7-navbar>

Expected Behavior
EXPLAIN WHAT IS TO BE EXPECTED, HERE.
The floating button should be fixed in place when I scroll, so it is always in the bottom right
Actual Behavior
EXPLAIN WHAT IS ACTUALLY HAPPENING, HERE.
The floating button stayed moved with the page when I scrolled: it wasn't fixed
P.S. Remember, an issue is not the place to ask questions. You can use Stack Overflow
for that or join the #framework7 channel on irc.freenode.net, where we will be more
than happy to help answer your questions.
Before you open an issue, please check if a similar issue already exists or has been closed before.

I have found the solution.
The floating button should be outside the page-content div.
https://github.com/nolimits4web/Framework7/commit/8aaabd8c69f653ded35bb6394629ac31e8a75b71

Yes, FAB should be placed outside of page-content, as a direct child of page


Hotfix/e2e refactor

Removing routes from e2e testing. Round 1.

Resolves (incomplete on content)
DCO 1.1 Signed-off-by: Scott Nath<EMAIL_ADDRESS>

@scottnath CI fails, timeout

@scottnath Correct me if I'm wrong, but one of the goals of this is to reduce reliance on server.js and being able to hit our endpoints for code coverage, right? If so, I'd be curious to see what our code coverage looks like without any route coverage whatsoever

I fear that code coverage may still be hidden as if you hit the route you hit the functions you're refactoring, and we have the same problem, just with better structured code

I'd almost be interested in splitting our routing tests out of or main test scaffolding and running them separately w/o code coverage

A big chunk of what we run into without spinning up punchcard as we do in server.js is all of the init files get missed. I want server.js to eventually just be a route-checker (does it get 404s in all instances needed, do routes work otherwise)
I'm creating a database story this morning for setting up a testing db (or some other option) for unit testing these routes further.

With server.js:
All files                                            |    81.86 |    71.06 |        0 |    82.28 |                |

Without server.js:
All files                                            |    39.48 |    54.02 |        0 |    39.68

With only one test of the top-level url in server.js:
All files                                            |    64.73 |    57.88 |        0 |    65.06 |                |

Before refactor:
All files |    34.42 |    45.27 |        0 |    34.61

@scottnath Yah, so server.js is hiding about 40% code coverage that we need to get in to unit tests. I'd like to see it removed all-together.

Basically our E2E tests are hiding the fact that an additional 40% of our code isn't covered, just because it gets hit when spinning up a route

We can't remove a file like server.js all together. we still need to check each route for positive and negative factors.
But, we should figure out how we're going to test all the init code - which is actually a pretty big hole in terms of coverage and out-of-scope for the routes refactor.

I'd live to remove server.js from our code-coverage covered unit tests so checking to see that they exist/fail as expected doesn't hide our code coverage

That's literally the point of the E2E refactor

If I remove it, then the numbers for code coverage will tank and this PR will not be able to be merged. And the actual routes will not be checked that they work - which does require a file like server.js. We can unit test the internals of routes, but not the app.get for routes - which must be done by spinning up express

@Snugug ... decided to revisit the url checks here and make them middleware instead. Much more appropriate and easier to maintain/control in the long run. Will work up a PR today.

@nugug https://github.com/punchcard-cms/punchcard/issues/305

@Snugug closing this so I can create a new PR once #309 gets merged.
This PR was too clouded by the error checking of the content routes. Once that error checking is in place, this PR will be drastically cleaner.


Malware scanner alerts

Some malware scanners alert on different exploits on the .apk downloaded from here (see VirusTotal results). If that is to be expected, maybe it should be pointed out in README.md?

Well it's an application that tests if the device is exploitable so you can expect a virus scanner to pick up something.

Sure (that was my suspicion anyway). Thanks for the confirmation. I've just mentioned it as not everybody might be aware of this – and a comment cannot hurt :)


Add new scope 'statistics' to admin

New scope for metal detector admin user.

I have add this here: https://github.com/MetalDetectorRocks/metal-detector-auth/pull/174


Pre-compile JSX

The site takes ~4s to load on a mobile device because of the babel.js compilation phase.

:cry: ok

added webpack support in ecf9fcb6cf6b3bcdd7ed951e65e9eca0d1083dea.


PDF with multiple page sizes

Is there a way to render a DPF containing pages with different sizes (different aspect ratio) ?
I tried to load a document, it loads fine but the aspect ratio for pages with different sizes is not respected.

its not been coded.. yet..

Duplicate of #213.
This is known issue, currently there is no solution


Don't console.error anything if there are no errors/warnings to report

I just don't like empty lines in output.
Can you please check if msg.output is empty and skip console.error call if it is?
https://github.com/jgoz/esbuild-plugins/blob/b330086575cb337b1f4b33efe70badfecc9f04e8/packages/esbuild-plugin-typecheck/src/typecheck-runner.ts#L91

Hi there, I started checking for empty strings in<EMAIL_ADDRESS>Please give it a try!


TypeError: Cannot read properties of undefined (reading '_address') (using<EMAIL_ADDRESS>

Unhandled Runtime Error
TypeError: Cannot read properties of undefined (reading '_address')

Source
src/pages/index.tsx (106:38) @ aggregate

  104 |   multicallV2Address: Contracts.Multicall,
  105 | });
> 106 | const results = await multicall.aggregate([

downgrading to "web3": "^1.9.0" works

will check soon...


flush when calling clear, use colorama on Windows

fixes #2284

Hi! It's been a while but I havent forgotten! Hope the change is ok!

Hey @belliriccardo , thanks for the clarification! Now it is much clearer.
I'm sorry for the long delay. I'm now walking over older PRs and reviewing them, helping out the pallet team.
One more thing regarding this PR that I forgot to ask: would you mind to add a test or two for the new behavior?


100x slower when using 4nodes than 1node to run the helloworld_ddp example

Hello, I meet a problem that it is 100x slower when using 2node than 1node to run the helloworld_ddp example.
I compile tutel with cuda11.3, pytorch 1.11 and nccl 2.9.9 on a nvidia-a100 GPU cluster with 100G IB.
When I run tutel.examples.helloworld_ddp on a single node with 8 gpus and batch size 16, the speed meets the results in your table(step_time = 0.012315). But when I test with 4nodes, the step time becomes about 1 second, which is about 100x slower.
Other multi-node tasks can normally run on my cluster, so I think maybe something is wrong with the environment when I build the project. It will be very nice if you can share the detailed environment information, such as the pytorch version, cuda version, g++ version, etc.
Thanks.

Have you tried the latest NGC's PyTorch container?

I think this is typically a problem that libNCCL for Pytorch is not configure correctly to use IB, so that Pytorch's NCCL uses other eithernet interfaces etc. @abuccts Do you have some suggestions?

Could you provide the detailed command for "helloworld_ddp example" and the log after setting NCCL_DEBUG=INFO env?

Our cluster is based on slurm so I add following code into the helloword_ddp
if 'RANK' in os.environ and 'WORLD_SIZE' in os.environ:
    dist_rank = int(os.environ["RANK"])
    dist_world_size = int(os.environ['WORLD_SIZE'])
    args.local_rank = int(os.environ['LOCAL_RANK'])
    os.environ['MASTER_PORT'] = '29529'
if 'SLURM_PROCID' in os.environ:
    dist_rank = int(os.environ['SLURM_PROCID'])
    args.local_rank = dist_rank % torch.cuda.device_count()
    dist_world_size = int(os.environ['SLURM_NTASKS'])
    node_list = os.environ['SLURM_NODELIST']
    num_gpus = torch.cuda.device_count()
    addr = subprocess.getoutput(
        f'scontrol show hostname {node_list} | head -n1')
    os.environ['MASTER_PORT'] = '29529'
    os.environ['MASTER_ADDR'] = addr
    os.environ['WORLD_SIZE'] = str(dist_world_size)
    os.environ['LOCAL_RANK'] = str(args.local_rank)
    os.environ['RANK'] = str(dist_rank)

and run the command
srun --mpi=pmi2 -n 32 --gres=gpu:8 --ntasks-per-node=8 python -u -m tutel.examples.helloworld_ddp --batch_size=16

Other multi-node tasks, such as the swin transformer, can normally run under this setting.
And I also provide the log file.
Thanks.

Can you run tutel.examples.helloworld instead of DDP version to help us collect these TFlop value respectively?

srun --mpi=pmi2 -n 32 --gres=gpu:8 --ntasks-per-node=8 --export=SKIP_A2A=1 python -u -m tutel.examples.helloworld --batch_size=16

srun --mpi=pmi2 -n 32 --gres=gpu:8 --ntasks-per-node=8 python -u -m tutel.examples.helloworld --batch_size=16 --allreduce_degree=-1

It'll tell whether the regression comes from NCCL's Allreduce or AlltoAll. Thanks!

Can you run tutel.examples.helloworld instead of DDP version to help us collect these TFlop value respectively?

srun --mpi=pmi2 -n 32 --gres=gpu:8 --ntasks-per-node=8 --export=SKIP_A2A=1 python -u -m tutel.examples.helloworld --batch_size=16
srun --mpi=pmi2 -n 32 --gres=gpu:8 --ntasks-per-node=8 python -u -m tutel.examples.helloworld --batch_size=16 --allreduce_degree=-1

It'll tell whether the regression comes from NCCL's Allreduce or AlltoAll. Thanks!

After I set SKIP_A2A as 1, the speed on 32gpus is similar to that on 8gpus. (step_time = 0.010818). Just setting allreduce_degree as -1 does not affect the speed(about 1 second).  A2A communication would be the bottleneck.

Hi @a157801, thanks for the details.
According to log, I can see in your cluster the intra-node connections are NVLink (300 GB/s if you are using A100) while inter-node only has one InfiniBand (100 Gbps instead of 100 GB/s in your original info). So the bad scaling you observed is expected. There're two types of NCCL operations in MoE and here's the estimations for your cluster:

allreduce: the 1-node allreduce has ~230 GB/s busbw but 2-node goes to ~12 GB/s, there's 10x downgrade.
alltoall: the 1-node alltoall also has ~230 GB/s busbw but 2-node goes to only ~2.5 GB/s because the only NIC will be shared by 8 GPUs during alltoall, there's 100x downgrade.

You can check above estimations by running allreduce_perf and alltoall_perf in nccl-tests. Please also correct me if the topology for your cluster is wrong.

As far as I can see, the cluster you are using has an extremely imbalanced intra- and inter- connections (you can also check this comment) and is not suitable for multi-node MoE workloads where alltoall is used heavily. I'm not sure which number you are comparing with but in the Azure cluster we used, there're 8x 200 Gbps NIC so 1.6 Tbps or 200 GB/s in total.

srun --mpi=pmi2 -n 32 --gres=gpu:8 --ntasks-per-node=8 --export=LOCAL_SIZE=8 python -u -m tutel.examples.helloworld --batch_size=16 --use_2dh

The step time is also about 1 second

We profile the inter-node speed of our cluster, and the all2all speed is limited due to the ib hardware. I trained the SwinV2-MoE-S with 32 experts, the qps is about 128, which is 2.5x slower than 295 in your paper.  It may be necessary to update our hardwares, such as adding more IBs, to train the sparse model efficiently with multiple nodes. Thanks a lot!  @ghostplant @abuccts

I'll close this issue since it is not actually a tutel application issue. Hope libNCCL's primal ncclSend/ncclRecv to be more efficient on your ib hardware.


how to use a custom Flutter web engine and use it for run my web app？

hi@ferhatb @ditman @ VladyslavBondarenko
this is my cmd：
flutter run --debug --dart-define=FLUTTER_WEB_USE_SKIA=true --local-engine= host_debug_unopt --local-engine-src-path= D:\flutter\Gitcode\flutter\src -d chrome
but An exception was thrown: Target file "host_debug_unopt" not found.
I tried swapping the parameter positions，the exception  is still there.
where should i put the web engine folder？
but when i build a apk for android,use cmd as:
flutter build apk -v  --target-platform android-arm64 --local-engine=android_debug_unopt_arm64 --local-engine-src-path=/engine/engine/src --debug
Successfully built.
so what's the differents between them?
the web engine was built on Linux, but my web app was built on windows.

@yzg-github
Please follow up on https://github.com/flutter/flutter/issues/62113, closing current issue.
See https://flutter.dev/community,  Stack Overflow or https://www.reddit.com/r/flutterhelp/ for resources and asking questions like this


I cannot fix anything without the actual logs that show the problem.

Reopen this once you have pasted the logs and I'll take a look.


Sessions > Export: Format time using Charging Station's locale

Need to have a closer look to the user local time as we don't have the timezone stored in the user, I can't find the place where the user time is formatted.
Need to clarify which time needs to be displayed for the user compared to the charging station time (sorry I need a real life example here)
BEFORE we had

TODAY I can have

Need to have a closer look to the user local time as we don't have the timezone stored in the user, I can't find the place where the user time is formatted.
Need to clarify which time needs to be displayed for the user compared to the charging station time (sorry I need a real life example here)
BEFORE we had

TODAY I can have

Need to clarify which time needs to be displayed for the user compared to the charging station time (sorry I need a real life example here)

The first 3 columns is related to the transaction and you used the timezone to format it so that's okay.
And if it's confusing to have the 3 other columns, we can get rid of them.

Need to clarify which time needs to be displayed for the user compared to the charging station time (sorry I need a real life example here)

The first 3 columns is related to the transaction and you used the timezone to format it so that's okay.
And if it's confusing to have the 3 other columns, we can get rid of them.

I think that way is the clearer option, we only have the charging station time

I think that way is the clearer option, we only have the charging station time

@cabch ok, that's perfect!

@cabch ok, that's perfect!

To be tested in QA first before closing the task :-)
I reopen the task.

To be tested in QA first before closing the task :-)
I reopen the task.


querry

Is there any grammar defined for ewasm ? I am trying to build language support in ewasm for atom editor like https://atom.io/packages/language-wast

There is no ewasm grammar as mentioned in #160. The package you link to is the grammar definition of the text representation of a WebAssembly module (called WAT, for WebAssembl Text, previously WAST).


Weird bug when using parallel computation: Tcl_AsyncDelete

I've started to get a weird bug when using parallel computations, on my machine with Python 3.6 and on another machine with Python 3.5 (under XUbuntu 18.04 or 16.04).
The main problem is:
Exception ignored in: <bound method Image.__del__ of <tkinter.PhotoImage objec
t at 0x7f5eead78f28>>
Traceback (most recent call last):
  File "/usr/lib/python3.5/tkinter/__init__.py", line 3359, in __del__
    self.tk.call('image', 'delete', self.name)
RuntimeError: main thread is not in main loop
Tcl_AsyncDelete: async handler deleted by the wrong thread

It comes for instance while evaluating a policy (but does not depend on the policy, it just comes randomly):
- Evaluating policy #4/25: SW-Restart(UCB($\alpha=1$), $\tau=100$, $\varepsilon=0.005$) ...
Repeat||:   0%|          | 0/480 [00:00<?, ?it/s][Parallel(n_jobs=-1)]: Using backend LokyBackend with 12 concurrent workers.
Time t:   0%|          | 0/2000 [00:00<?, ?it/s]
New means vector = [0.4 0.5 0.9], best arm(s) = [2], at time t = 0 ...
New means vector = [0.5 0.4 0.7], best arm(s) = [2], at time t = 400 ...
New means vector = [0.6 0.3 0.5], best arm(s) = [0], at time t = 800 ...
New means vector = [0.7 0.2 0.3], best arm(s) = [0], at time t = 1200 ...
Time t:  78%|███████▊  | 1560/2000 [00:00<00:00, 15594.81it/s]
New means vector = [0.8 0.1 0.1], best arm(s) = [0], at time t = 1600 ...
Time t: 100%|██████████| 2000/2000 [00:00<00:00, 15321.15it/s]

Estimated order by the policy SW-Restart(UCB($\alpha=1$), $\tau=100$, $\varepsilon=0.005$) after 2000 steps: [1 2 0] ...
  ==> Optimal arm identification: 100.00% (relative success)...
  ==> Mean distance from optimal ordering: 38.89% (relative success)...
Repeat||:  15%|█▌        | 72/480 [00:00<00:04, 91.34it/s] [Parallel(n_jobs=-1)]: Done  28 tasks      | elapsed:    0.7s
Repeat||:  41%|████▏     | 198/480 [00:02<00:04, 70.44it/s][Parallel(n_jobs=-1)]: Done 154 tasks      | elapsed:    2.3s
Repeat||:  46%|████▌     | 221/480 [00:02<00:03, 75.64it/s]Exception ignored in: <bound method Image.__del__ of <tkinter.PhotoImage objec
t at 0x7f5eead78f28>>
Traceback (most recent call last):
  File "/usr/lib/python3.5/tkinter/__init__.py", line 3359, in __del__
    self.tk.call('image', 'delete', self.name)
RuntimeError: main thread is not in main loop
Tcl_AsyncDelete: async handler deleted by the wrong thread

I think there is no issue but forcing to not display any matplotlib plots before running the part of the code which is in parallel (ie, the Parallel(...)(delayed(...), ...)).


feat: starknet_getTransactionStatus support

getTransactionStatus isn't currently supported.
See https://github.com/eigerco/beerus/blob/1c10839fa6ee3ab740fbf026d94001d6f6ce1977/crates/rpc/src/api.rs#L67

I would like to work on this, would appreciate some pointers.

Hello @psychiller!
This one probably is a better first issue. I left some pointers in the issue description. Let me know if you need more.

Thank you for heads up, can you assign that one.


feat: track OwnerType.savedSearches

The type of this PR is: Feature

Description
As suggested by Devon here, I added tracking of the savedSearches event, when the user goes to the screen with a list of all saved searches

PR Checklist (tick all before merging)

[ ] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[ ] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have added a feature flag, or my changes don't require a feature flag. (How do I add one?)
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a changelog entry below or my changes do not require one.

Changelog updates
Changelog updates

#nochangelog

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against 49b12e02d3d2b4e7ef69940f43e55d9937fe3902


fix(tauri) environment variables usage

[x] Bugfix
[ ] Feature
[ ] New Binding Issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes. Issue #___
[x] No

The PR fulfills these requirements:

[x] It's submitted to the dev branch and not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
[ ] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Fixes no-server mode not running on another machine due to fs::read_to_string usage instead of the include_str macro.
Build no longer fails when compiling without environment variables, now the app will show an error.

Looks good, makes my arguments from before a bit moot.  Still think we could do this a little more elegantly but that's something to address later.

I can't agree more with you. I'm checking with the guys from cargo, and the rust CLI is also an alternative for the future.


update missing descriptions

@MightyPen @mikefrobbins OK, this is just the items in docs_conceptual. Which means I'm still unclear as to why there's that discrepancy between Kusto (reports 306 missing descriptions) and this (three). It could be that it's picking up some of the reference content, but it would be nice to drill down into that report (which doesn't seem possible). Either way, I did a manual sweep of the conceptual docs, and these do seem to be the only pages missing description metadata.

Docs Build status updates of commit 9cffd07:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azurermps-4.4.1/get-started-azureps.md
:white_check_mark:Succeeded
View (azurermps-4.4.1)

docs-conceptual/azurermps-5.7.0/get-started-azureps.md
:white_check_mark:Succeeded
View (azurermps-5.7.0)

docs-conceptual/azurermps-6.13.0/get-started-azureps.md
:white_check_mark:Succeeded
View (azurermps-6.13.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 9cffd07:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azurermps-4.4.1/get-started-azureps.md
:white_check_mark:Succeeded
View (azurermps-4.4.1)

docs-conceptual/azurermps-5.7.0/get-started-azureps.md
:white_check_mark:Succeeded
View (azurermps-5.7.0)

docs-conceptual/azurermps-6.13.0/get-started-azureps.md
:white_check_mark:Succeeded
View (azurermps-6.13.0)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Add JsonDeserialize annotation to DefaultSignatureState

What:
This PR adds a JsonDeserialize Annotation to the DefaultSignatureState.
Why
A Quarkus integration, using the
DefaultSignatureStateProcessor -> method setStateCache(..
Methos setStateCache takes interface IntegrationServiceStateCache ->
with signature ->public interface IntegrationServiceStateCache extends IntegrationServiceCache {…
Works fine for overriding and (in our specific case) do an Redis put get based cache.
But...
Quarkus Redis implementation uses json/jackson to serialize/deserialize:
https://quarkus.io/guides/redis-reference#serialization-and-deserialization
While we would gladly use the given implementation of CachableSignatureState -> DefaultSignatureState.
It does not work in this use case, as jackson will interpret is as a RestClientSignatureState due to the annotation on interface SignatureSite.
Fine, use a RestClientSignatureState then one might think - but that object is not an implementation of CacheableSignatureState, so that would not work.
The proposed solution is simple, and I can't see the we are complicating things.

Add a JsonDeserialize(as = DefaultSignatureState.class) to DefaultSignatureState object.

That way it will always get the right deserialization, without the enduser (us) having to either add an extra deserializer, or as we do currently - Implement a simple CachbleSignatureStateImpl-object that basically just adds that annotation and is a clone of DefaultSignatureState. That works, but, always nicer to have the direct support from the library it self, (and it would spare us an object-impl in the integration:).
(There is a very basic test written for this, which just tests the serialization/deserialization mechanism  )

Looks, fine. Merging this.


A way to delete remote branches

It would be good if VSCode would provide a way to delete remote branches, e.g. after a merge, or in general when a local branch is deleted.
I used JetBrains WebStorm for a long time and there this was solved quite well, whenever I merged a local branch, I got a small popup asking me if I also want to delete the origin branch.
I think such a feature would also be very good for VSCode, since it is quite tedious in the long run to always clean up the branches in GitHub or AzureDevOps.

There is an extension pavlelee.git-branch-delete-kit for this while we are waiting for the PR #199113 to be merged.


[Auto- Translate]

Hey can you implement auto translate to english/any other language...
I know that the inbuilt translator can do that..
But that doesn't seem to be working on all pages

Hey, can you give an example of such a page
I would like to try it out

Please consider opening a new issue with the right template -> New Issue


Charts not showing in example notebook

Describe the bug
I get this error instead of a chart:

To Reproduce
Run:
https://colab.research.google.com/github/superlinked/superlinked/blob/main/notebook/semantic_search_netflix_titles.ipynb
Expected behavior
Chart should render as image in colab.
System (fill in)

Version: superlinked==3.41.1
Environment: Google Colab Default Kernel

Additional context

@kembala Do you have an update you can share on the progress of this?

This is issue has been solved - now we dynamically set the renderer using the get_altair_renderer utility function, which uses the colab renderer in colab, and the mimetype renderer in other cases for compatibility with github.


Issue #3428: Swapped text in dialog buttons

because, according to Android Convention, they were opposite each other
Description
Fixes #3428 Dialog buttons set as opposite to Android design conventions
What changes did you make and why?
In DialogUtil.java, I replaced R.string.no with R.string.yes making it the text for the positiveButton, and I replaced R.string.yes with R.string.no making it the text for the negativeButton. I did this inside both of the TWO times that showAlertDialog method occurs inside the java file.
Tests performed (required)
Forgive me if I'm wrong, but according to the developer documentation, it mentions that tests are not required if the issue is not labeled with an 'enhancement' tag. So, I did not perform any tests.
Screenshots showing what changed (optional - for UI changes)
BEFORE:

AFTER:

@FawziyahAlebiosu Thanks for the PR!
Apologies for not being clear. The screenshot we were expecting was a screenshot of the app's UI  after the change. Could you add a screenshot of how the dialog appear in the app after the change? You can trigger the dialog in the app when you try to upload an existing commons image. Here's one image which you could use for testing:
https://upload.wikimedia.org/wikipedia/commons/a/a0/Les_anciens_couvents_de_Lyon_-_039_-_Inscription_romaine_d'Ainay.jpg
You should see a "Warning" dialog when you try to upload this image. Let us know if you need any help. 🙂

@FawziyahAlebiosu Thanks for the PR!
Apologies for not being clear. The screenshot we were expecting was a screenshot of the app's UI after the change. Could you add a screenshot of how the dialog appear in the app after the change? You can trigger the dialog in the app when you try to upload an existing commons image. Here's one image which you could use for testing:
https://upload.wikimedia.org/wikipedia/commons/a/a0/Les_anciens_couvents_de_Lyon_-_039_-_Inscription_romaine_d'Ainay.jpg
You should see a "Warning" dialog when you try to upload this image. Let us know if you need any help. 🙂

Oh my! You're right, I tested it and it definitely does not work as intended yet. I use an emulator, because I don't have an android phone, but I'm definitely going to work on figuring out how to swap the correct method as well tomorrow. Thank you for keeping me on my toes, even though I am a new contributor. I'll let you know if I need any help

I tested it and it definitely does not work as intended yet.

@FawziyahAlebiosu Oops! Looks like I've misled you in one of my previous comments. Sorry about that. 🙁

I'm definitely going to work on figuring out how to swap the correct method as well tomorrow.

You're changing the right methods. No problem there. The thing is this change requires more than just swapping the text. We also have to update the callers of those methods so that the appropriate callbacks are mapped to those buttons. We need to do this as the callers had passed the callbacks with the assumption that "No" would be the positive action and "Yes" would be the negative action. As we're changing it now we also have to change the callers to so that the callbacks are passed appropriately. Hope that helps!

Thank you for keeping me on my toes, even though I am a new contributor.

Our pleasure 😄

I see that my commit to get the dialog box to work as expected went through. I have also included a screen recording to show that I tested it and it works. Thank you for your patience so far, I truly appreciate it!

@FawziyahAlebiosu That's a good start! But there are still other callers of the DialogUtil#showAlertDialog methods which need similar changes. You can use the "Find Usages" option in the context menu that appears when you right click on a method name to find the usage of the method. Alternatively, you can Ctrl + Left mouse click on a method name to see the callers.

I was able to test the following methods that call showDialog that I changed, but I need to do another screen recording because the I didn't save them before exiting the emulator :(
Will update with recordings by tomorrow morning.

Will update with recordings by tomorrow morning.

Screen shots would be enough. You don't have to do a screen recording.

Codecov Report

Merging #3496 into master will decrease coverage by 0.48%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa1d8bc...5080ebd. Read the comment docs.

I have successfully tested that:

showDuplicate method (which calls showDialog) works correctly with the new swapped yes and no buttons-see first screen recording.
showBadImagePopUp method (also calls showDialog) works correctly-see screen recording below

showNearbyCardPermission method: I tried to trigger this but because I'm running it on an emulator, it gives me a toast that Nearby might not work properly because location can't be found. Any suggestions on how to trigger this so I can test because I DID change it.
-shownocategoryselected method: changed and tested successfully; see screen recording below

Again, Ik I keep saying this but I really appreciate your patience with me thus far. Let me know if I need to change anything or clarify anything.

One more thing! In total there were about 10 usages of showDialog but only these ones were affected by the yes and no swap. Some only had a positive button text and the negative was null, and vice verse. Then there were some that were already correctly assigned like callQuiz method.

Good work @FawziyahAlebiosu


feat: 调整返回值模型和账号文件改名

调整返回值模型中'items'字段为'records', 并增加'current'和'pages'字段
将'mock/sys/user.ts'改名为'account.ts'
将'api/sys/user.ts'改名为'account.ts'
将'api/sys/model/userModel.ts'改名为'accountModel.ts'
将'store/modules/user.ts'改名为''account.ts'

目的: 一是方便对接后端, 二是与系统中的用户管理模块文件做区分
General

✏ Mark the necessary items without changing the structure of the PR template.

[ ] Pull request template structure not broken

Type

ℹ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

ℹ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

[x] My code follows the style guidelines of this project
[x] Is the code format correct
[ ] Is the git submission information standard?
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

由于依赖升级，导致 run type:check 报错


Incorrect syntax highlighting for arrow functions returning arrow functions.

I have the following block of code:
const setDefaultFilterValues = (
  defaultFilterValues?: TDefaultFilterValues,
): Function => (dispatch: Function, getState: Function): void => {
}

Here is how the syntax highlighting is showing it: http://imgur.com/a/HUFNU
There are actually two function definitions here, the second definition being the body of the first. The highlighting only identifies the first definition, instead coloring the second definition as if it were instead a function type definition.
Perhaps this alteration of the code makes it a little more clear what's actually going on, however to my surprise it is still highlighted the same (incorrect) way.
const setDefaultFilterValues = (
  defaultFilterValues?: TDefaultFilterValues,
): Function => {
  return (dispatch: Function, getState: Function): void => {
  }
}

I've had a quick look and as far as I can see the second defintion is correct but the outer (first) definition isn't. However there is nothing I can do about the outer as I don't know it is an arrow function until I've parsed the paren body and TextMate grammars only allow me to process line at a time and I can't go backwards.
In this image I've slightly modified your code to show the different highlighting of a variable that holds a Function vs. a variable that holds some other object. Also, I've shown what it looks like on a single line.

Ah, I see. I'll have to think a bit ways we could work around this limitation.


Update docs to target Traefik v1.6

All documentation samples should be update to target Traefik v1.6 compatible configurations.
Including:
https://github.com/jjcollinge/traefik-on-service-fabric/blob/master/Docs/CustomTemplates.MD
https://github.com/jjcollinge/traefik-on-service-fabric/blob/master/Readme.MD

These also need to be update inside the main traefik repo here: https://docs.traefik.io/configuration/backends/servicefabric/ still refers to "Expose" not "Enable"


LicenceWidget revision data type

revision is described as number here, while in LicenceWidget appears to be a string.
We should handle revision as a number in the widget.

Solved in https://github.com/ecmwf-projects/cads-ui-library/releases/tag/v6.0.4


Type is still narrowed down after value is changed in a function

Bug Report

🔎 Search Terms

🕗 Version & Regression Information

TypeScript 4.9.4
⏯ Playground Link

Playground link with relevant code
💻 Code

interface Foo {
  bar: string;
}

function getFoo() {
  const foo: Foo = {
    bar: "foo"
  }
  return foo;
}

function changeBar(foo: Foo) {
  foo.bar = "changed";
}

function bar(foo: Foo) {
  if (foo.bar == "foo") {
    changeBar(foo);
    if (foo.bar == "bar") {
    }
  }
}

🙁 Actual behavior

In the last if statement the type is still narrowed down
🙂 Expected behavior

Given the value is changed inside a function before the second if, shouldn't the type be again the one of the interface?

Duplicate of #9998.


Remove extra references

These refs are included in net461 and netcoreapp2.0/2.1 that DI is cross-compiled to.


Debug - Variables - Database Statistics - Cannot see / copy full SQL statement

Describe the bug
When debugging, I'm trying to analyse the SQL statements created via the Variables - Database statistics fields. However, I don't succeed at all in seeing the full SQL statement.

When hovering the value, the SQL statement is truncated with '...' (OK)
When trying to copy the value / expression (right click), I get another irrelevant SQL statement than the line / value which is currently selected.
Add watch is no option either, because over here the value is different too.

Expected behavior
I would like to easily copy a complete SQL statement so I can analyse the contents (especially the joins at the end of the query)
Screenshots
Right click on this location does not give me the full content of the SQL statement.

5. Versions:

AL Language:
Version: 6.1.397164

Business Central: 17.2

Indeed, I noticed the other wrong query being copied/shown, months ago, but I forgot to report it. This basically is not usable at the moment.

Indeed, I noticed the other wrong query being copied/shown, months ago, but I forgot to report it. This basically is not usable at the moment.

Have you tried the Debug Console Window in teh debugger. By just typing SQL4 at the console? Or SQL4.Statement.

Have you tried the Debug Console Window in teh debugger. By just typing SQL4 at the console? Or SQL4.Statement.

I'll try it and let you know.
That doesn't change the fact that the more easy/obvious functionality for doing this is broken and returns unrelated SQL statements.

I'll try it and let you know.
That doesn't change the fact that the more easy/obvious functionality for doing this is broken and returns unrelated SQL statements.

So, it looks to me like what you said works - go to Debug Console, type SQLn where n is the number of the statement you actually want to see, then expand the resulting arrow and scroll down to see the statement. That gets me the content that is shown in the sidebar and previewed in a tooltip (which is not what gets copied with right-click > Copy Value or Add Watch, as reported).
Thanks for the workaround, but presumably the main bug needs fixed?

So, it looks to me like what you said works - go to Debug Console, type SQLn where n is the number of the statement you actually want to see, then expand the resulting arrow and scroll down to see the statement. That gets me the content that is shown in the sidebar and previewed in a tooltip (which is not what gets copied with right-click > Copy Value or Add Watch, as reported).
Thanks for the workaround, but presumably the main bug needs fixed?

The main bug will not be fixed soon. The UI is controlled by the VSCode debug adapter client. And it has its limits. Like, it does not support multiline values ((\r\n or \n depending on the context).
BTW. You can type SQL(n).Statement and then you only get the statement.
We use the debug console to evaluate variables that do not fit the UI.
I am not sure this was not mentioned but AL variables with size > 1024 bytes are truncated.  Anything that you see as hovered ending with ... is a truncated value.
We have just added support that large strings are also available, but only in the debug console.

The main bug will not be fixed soon. The UI is controlled by the VSCode debug adapter client. And it has its limits. Like, it does not support multiline values ((\r\n or \n depending on the context).
BTW. You can type SQL(n).Statement and then you only get the statement.
We use the debug console to evaluate variables that do not fit the UI.
I am not sure this was not mentioned but AL variables with size > 1024 bytes are truncated.  Anything that you see as hovered ending with ... is a truncated value.
We have just added support that large strings are also available, but only in the debug console.

We have improved the experience for working with large variables, and updated the documentation. The fix will be released in the next major release.

We have improved the experience for working with large variables, and updated the documentation. The fix will be released in the next major release.


[WDR] Update extractor to fit the current markup

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

WDR  changed the markup recently. The change in this PR corresponds to the patch provided in the issue. I tested it with the links in the issue and also with another TV program.
Fixes #7461
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

[ ] I am the original author of this code and I am willing to release it under Unlicense
[x] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Copilot Summary

🤖 Generated by Copilot at ef7c6b7
Summary
🐛📺🚀

Fix WDR extractor by using correct attribute name in regex. This enables the extraction of media links from data-extension-ard JSON data in yt_dlp/extractor/wdr.py.

Oh we are the WDR crew and we know just what to do
We scrape the media links with data-extension-ard
We find the JSON data and the pages that we need
And we pull them all aboard with a hearty heave-ho

Walkthrough

Update the comment and the regular expressions to use the correct attribute name data-extension-ard for extracting media links from the website (link, link, link) in yt_dlp/extractor/wdr.py

Do the extractor tests pass? If not, can you update them?

Updated them.

Do they test the new pattern? If not, add new tests e.g. from the linked issues

Tests don't directly test the pattern as far as I can see, only implicit. Anyways, I added a new one, using the first link from the linked issue.


Depth First Search

Added Depth First Search Visualization
Removed explicit use of color names like "red" and added different node state variables for each corresponding color.
The code now says what the nodes are and
there is exactly one place that says what color each type of node is.

I'm not sure why you would remove the names of the colour names:
node_colors[node.state] holding a value of a colour like red seems more intuitive than something like final state - am I missing something?

Hi @kaivalyar. The above changes are what @norvig suggested in #360.

Got it.
However, if colours were being renamed to what they represented, wouldn't it make sense to rename the lists containing them too? node_colors[node.state] = 'final state' somehow doesn't seem as self explanatory as node_type[node.state] = 'final state'. My point is basically that it is confusing to have node_colors as a list, and then not put colours in it. This is what I had meant to say, @MrDupin .

Ah, I see. Yes, that is a bit confusing. Maybe it needs changing.

Unfortunately it is too difficult to resolve conflicts manually in an .ipynb.

@MrDupin  There are many other searching algorithms which are still not implemented in search.ipynb. Is it not possible to implement them or they haven't been implemented yet? And what about it GUI using tkinter,should it be implemented along with the algorithm?

Hi @AnishHota. You can most definitely implement the search algorithms! You don't have to also make a tkinter application, although it is best if the algorithm was accompanied by a graphical example in the notebooks (it's up to you though).
If you want to discuss this further, you can open an Issue to avoid commenting on old threads. Thanks!


Slack URL is broken in README

Hi,
The Slack URL from Need Help? section of README redirects to mixedreality.mozilla.org/?hello instead of Slack.

I think that the public slack may be gone after some staffing changes at Mozilla, not sure


[KERNEL] Extended StringType to have CollationIdentifier

Which Delta project/connector is this regarding?

[ ] Spark
[ ] Standalone
[ ] Flink
[X] Kernel
[ ] Other (fill in here)

Description
Extended StringType to have attribute collationIdentifier.
How was this patch tested?
Does this PR introduce any user-facing changes?
Yes. Previously, users could use StringType just as StringType.STRING, but now they can create StringType instances with arbitrary CollationIdentifier values.

@vkorukanti can you please review?


Focus

The brompt does not show focus on input on phones, but only on web, possible to fix ?

Would be great also with popup, without any ok/cancel

Possible to add  or \r\n line returns to text in popup's ?

There is no new development on this project. I would recommend you use medium-style-confirm instead. It has all the APIs of blurt.

medium-style-confirm looks rather 1920's, grey-style.


Added Frontend tools category

PR under #387 : Added Frontend tools category with some tools!!

@JasonDsouza212 added 8 tools in the category!!

This branch has conflicts that need to be resolved.


runtime/cgo: objdump error "unsupported architecture" for amd64

What version of Go are you using (go version)?

$ go version
go version go1.14.2 windows/amd64

Does this issue reproduce with the latest release?
Yes, it happens with 1.14.4 too.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=on
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\[...]\AppData\Local\go-build
set GOENV=C:\[...]\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=c:\[...]\Go-Modules
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=c:\[...]\go1.14.2
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=c:\[...]\go1.14.2\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=C:\[...]\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\[...]\Temp\go-build345817374=/tmp/go-build -gno-record-gcc-switches

gcc -v Output
$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=c:/[...]/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.1.0/lto-wrapper.exe
Target: x86_64-w64-mingw32
Configured with: ../gcc-10.1.0/configure --prefix=/mingw64 --with-local-prefix=/mingw64/local --build=x86_64-w64-mingw32 --host=x86_64-w64-mingw32 --target=x86_64-w64-mingw32 --with-native-system-header-dir=/mingw64/x86_64-w64-mingw32/include --libexecdir=/mingw64/lib --enable-bootstrap --with-arch=x86-64 --with-tune=generic --enable-languages=c,lto,c++,fortran,ada,objc,obj-c++ --enable-shared --enable-static --enable-libatomic --enable-threads=posix --enable-graphite --enable-fully-dynamic-string --enable-libstdcxx-filesystem-ts=yes --enable-libstdcxx-time=yes --disable-libstdcxx-pch --disable-libstdcxx-debug --disable-isl-version-check --enable-lto --enable-libgomp --disable-multilib --enable-checking=release --disable-rpath --disable-win32-registry --disable-nls --disable-werror --disable-symvers --disable-plugin --with-libiconv --with-system-zlib --with-gmp=/mingw64 --with-mpfr=/mingw64 --with-mpc=/mingw64 --with-isl=/mingw64 --with-pkgversion='Rev3, Built by MSYS2 project' --with-bugurl=https://sourceforge.net/projects/msys2 --with-gnu-as --with-gnu-ld
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 10.1.0 (Rev3, Built by MSYS2 project)

What did you do?
Minimal test.go:
package main

// void f() {}
import "C"

func main() {}

Commands:
C:\[...]\test>go build

C:\[...]\test>file test.exe
test.exe: PE32+ executable (console) x86-64, for MS Windows

C:\[...]\test>go tool objdump test.exe
objdump: disassemble test.exe: unsupported architecture

What did you expect to see?
The result of disassembly.
What did you see instead?
Error message objdump: disassemble test.exe: unsupported architecture.
This only happens for binaries using cgo. I didn't find anywhere this is unsupported, so I'm opening this issue.  I'm using mingw64; gcc -v output is included above, in operating system details section. Binaries run correctly.

@ianlancetaylor

@neclepsio
Thank you for reporting this problem. It appears it was always broken this way.
Can you, please, try this fix
https://go-review.googlesource.com/c/go/+/240957
?
Thank you.
Alex

It works, thank you!

It works, thank you!

Thanks for checking. I will submit my change after go 1.15 is released. So this change will be part of go 1.16.
Alex