Documentation

It would be nice to have documentation syntax in code so we can generate for example man pages for wlc API. Doxygen has been used before, but it may be worth to resee what are the options nowadays.

Here is a tentative (i.e. braindump) mockup that demonstrates what this could look.
Given the function wlc_init, the comment block above it would look something like this:
/* -- NAME
 * initialize the wayland compositor
 *
 * -- DESCRIPTION
 * wlc_init() initializes the `interface` along with passing `argc` and
 * `argv` from main(), so wlc can rename the process it forks to cleanup
 * crashed parent process and do FD passing (non-logind).
 *
 * -- RETURN VALUE
 * Upon successful execution wlc_init() will return true.
 *
 * -- ERRORS
 * All errors encountered in wlc_init() are considered fatal and thus should
 * never really return false.
 *
 * -- NOTES
 * Avoid running unverified code before wlc_init() as wlc compositor may be run
 * with higher privileges on non logind systems where compositor binary needs
 * to be suid.
 *
 * -- ALSO SEE
 * wlc_interface(3)
 */
WLC_NONULLV(1) bool wlc_init(const struct wlc_interface *interface, int argc, char *argv[]);

The converstion to groff_man(7) should yeild something like this:

Note that the entire SYNOPSIS section should be generated, the point of this format is to be both flexible, very man-pages(7) specific in layout and try to not let the generation get in the way of the author.

.TH WLC_INIT 3 2015-09-30 WLC "WLC API Functions"

.SH NAME
wlc_init \- initialize the wayland compositor

.SH SYNOPSIS
.B #include <wlc/wlc.h>

.BI "bool wlc_init(const struct wlc_interface " *interface ", int " argc ", char " *argv[] ");"

.SH DESCRIPTION
.BR wlc_init ()
initializes the
.I interface
along with passing
.I argc
and
.I argv
from
.BR main ()
, so wlc can rename the process it forks to cleanup crashed parent process and do FD passing (non-logind).

.SH RETURN VALUE
Upon successful execution
.BR wlc_init ()
will return true.

.SH ERRORS
All errors encountered in
.BR wlc_init ()
are considered fatal and thus should never really return false.

.SH NOTES
Avoid running unverified code before
.BR wlc_init ()
as wlc compositor may be run with higher privileges on non logind systems where compositor binary needs to be suid.

.SH ALSO SEE
.BR wlc_interface (3)

Which would should render something like this on the users screen via the normal man command:
WLC_INIT(3)                  WLC API Functions                  WLC_INIT(3)

NAME
       wlc_init - initialise the wayland compositor

SYNOPSIS
       #include <wlc/wlc.h>

       bool  wlc_init(const struct wlc_interface *interface, int argc, char
       *argv[]);

DESCRIPTION
       wlc_init() initializes the interface along  with  passing  argc  and
       argv from main() , so wlc can rename the process it forks to cleanup
       crashed parent process and do FD passing (non-logind).

RETURN VALUE
       Upon successful execution wlc_init() will return true.   ERRORS  All
       errors  encountered  in  wlc_init()  are  considered  fatal and thus
       should never really return false.  NOTES  Avoid  running  unverified
       code  before  wlc_init()  as  wlc  compositor may be run with higher
       privileges on non logind systems where compositor binary needs to be
       suid.

ALSO SEE
       wlc_interface(3)

WLC                              2015-09-30                     WLC_INIT(3)

This is not bad at all, and doesn't look too complicated to write generator for (apart from understanding bit of C for the function prototypes). If escaping is desired, it should be in way that is simplest for the parser. That is, do not provide many ways to escape things.

I wonder if clang can do it

Clang was bit troubling with python at least. I've never used the C api at least. Ragel can parse C nicely, but won't "understand" it. I think most documentation generators don't actually understand C, but I can see that becoming problematic in some scenarios, like having macros front of function declarations, or even worse libpng style macro function declarations.

There are several limitations to this approach.  The main one is you're essentially locking yourself to groff_man(7) as the bugs section of man(7) points out:
Most  of  the  macros  describe  formatting (e.g., font type and spacing)
instead of marking semantic content (e.g., this text is  a  reference  to
another  page),  compared to formats like mdoc and DocBook (even HTML has
more semantic markings).  This situation makes it harder to vary the  man
format for different media, to make the formatting consistent for a given
media, and to automatically insert cross-references.  By sticking to  the
safe  subset described above, it should be easier to automate transition‐
ing to a different reference page format in the future.

When doing parsing of semantic elements like the backticks one has to consider how it could be represented.
For example consider the text:
`foo bar()`

If we define backticks as .I and bar() as .BR bar () then the non-inline solution would be:
.I foo
.BI bar ()

This immediately presents lots of edge cases which would be ugly to parse.  The first is that bar() can no longer simply transform to .BR bar (), you need to know that you're inside italics mode.  This gets worse when you consider trailing punctution:
`foo bar(), baz`

Would become the following groff without inlining the macros:
.I foo
.BR bar () "" ,
.I baz

The use of "" above is to satify the nature of .BR which alternates each word with bold and roman (normal text), the "" is there to absorb the next bold effect.
However there is a rather nice solution to both of these issues but generally produces slightly less than pretty looking manuals.  This is the use of inline macros via the \f escape.
Consider again the first example of bold being used inside italics.  The inline solution (from a parsers perspective) to this would be:
\fIfoo \fBbar\fR\fI()\fR

And for the second example:
\fIfoo \Bbar\fR\fI(), bar\fR

Notice how we can allow unbalanced pairs, the first \fI does not have a corresponding \fR as it is consumed by the \fR which terminates the \fB which preceeded it, \fB itself also consuming the effect of \fI.  This is quite nice for parsers as they wouldn't need to care, each element can be treated in isolated.
That is to say, bar() can be translated to \fBbar\fR() directly without needing to worry about the surrounding context.  Likewise, a pair of backticks can be replaced with \fI and \fR respectively regardless of the contect.
Things to consider would be if you want this format to be more general.  This would almost certainly require the use of an IR, which the prompts the question of why not just use a well supported markup like restructed text or asciidoc directly?  These formats can both generate manuals fairly comfortably, all the tool here would need to do is parse the comment block and C definition below it.
If the manual generation isn't perfectly like man-pages(7) then it probably wouldn't be too difficult to adjust the output too.

This is quite nice too https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt

Heh, regex poorly all the things:
teapot earnest %i master ~ cat foo
.TH WLC_INIT 3 2015-09-30 WLC "WLC API Functions"

-- NAME
initialize the wayland compositor

.SH SYNOPSIS
.B #include <wlc/wlc.h>

.BI "bool wlc_init(const struct wlc_interface " *interface ", int " argc ", char " *argv[] ");"

-- DESCRIPTION
wlc_init() initializes the `interface` along with passing `argc` and
`argv` from main(), so wlc can rename the process it forks to cleanup
crashed parent process and do FD passing (non-logind).

-- RETURN VALUE
Upon successful execution wlc_init() will return true.

-- ERRORS
All errors encountered in wlc_init() are considered fatal and thus should
never really return false.

-- NOTES
Avoid running unverified code before wlc_init() as wlc compositor may be run
with higher privileges on non logind systems where compositor binary needs
to be suid.

-- ALSO SEE
wlc_interface(3), wlc_output(3)

teapot earnest %i master ~ gman foo
.TH WLC_INIT 3 2015-09-30 WLC "WLC API Functions"

.SH NAME
initialize the wayland compositor

.SH SYNOPSIS
.B #include <wlc/wlc.h>

.BI "bool wlc_init(const struct wlc_interface " *interface ", int " argc ", char " *argv[] ");"

.SH DESCRIPTION
\fBwlc_init\fR() initializes the \fIinterface\fR along with passing \fIargc\fR and
\fIargv\fR from \fBmain\fR(), so wlc can rename the process it forks to cleanup
crashed parent process and do FD passing (non-logind).

.SH RETURN VALUE
Upon successful execution \fBwlc_init\fR() will return true.

.SH ERRORS
All errors encountered in \fBwlc_init\fR() are considered fatal and thus should
never really return false.

.SH NOTES
Avoid running unverified code before \fBwlc_init\fR() as wlc compositor may be run
with higher privileges on non logind systems where compositor binary needs
to be suid.

.SH ALSO SEE
\fBwlc_interface\fR(3), \fBwlc_output\fR(3)

gman() { cat "$1" | italic | embold | mkref | mksec }

italic() { sed 's/`\([^`\]*\)`/\\fI\1\\fR/g'; }
embold() { sed 's/\b\([^ ]*\)()/\\fB\1\\fR()/g'; }
mkref() { sed 's/\b\([^ ]*\)(\([0-9]\))/\\fB\1\\fR(\2)/g'; }
mksec() { sed 's/^-- \(.*\)/.SH \1/'; }

That's nice proof of concept.

Things to consider would be if you want this format to be more general. This would almost certainly require the use of an IR, which the prompts the question of why not just use a well supported markup like restructed text or asciidoc directly? These formats can both generate manuals fairly comfortably, all the tool here would need to do is parse the comment block and C definition below it.

This is fine too, as long as the output is high quality. The only downside might be that the comment blocks might become more markup heavy. I don't think most documentation derives too much from what you have done with wlc_init here. Though I can't consider other projects here.


Update "edit this page" link on quarto

Note: non-urgent change
Read-the-docs (quarto) edit this page redirects to the wrong link.
See: https://usaon-benefit-tool.readthedocs.io/en/latest/reference/decision-records/
Click: "Edit this page"
Goes to: https://github.com/nsidc/usaon-benefit-tool/edit/main/reference/decision-records/index.md
Should be corrected to: https://github.com/nsidc/usaon-benefit-tool/blob/main/doc/reference/decision-records/index.md

Great catch, thank you! That should be a quick fix if I remember correctly.

I am working on this one.

Thank you, Sherwin :) Resolved by #244 :partying_face: :rocket:


Web app/browser usage of library

I'm attempting to rely on the library in an Angular project and not able to get it working when importing through the code base. Made another attempt by loading the full bundle, but that has some eval() calls which I won't allow in my key-management app.
The issue by importing the library directly, is related to use of import using JSON files. The resolveJsonModule and esModuleInterop options for TypeScript is not enough to make it work, unfortunately.

For anyone else looking into this and allows eval execution, you can include the bundle in angular.json using the scripts section:
"scripts"<EMAIL_ADDRESS>
Right now the library is used to host DWN instance and I don't think the focus is on consumer library yet? Is the plan to split some of the logic in a separate library that is cross-compatible with Node.js/Web and doesn't include the service-processing logic of the DWN instance?

This was intended to be cross-env, so let's see if we can get that eval-using lib out of the deps.

For TypeScript, I needed to set "module": "ESNext" in tsconfig.json under compilerOptions. See if that helps.

Already tried that with no luck. I have previously used the import JSON feature within the same app, but this is first time I have an external dependency that does it and not sure why it fails. I'll make a small repo that reproduce the problem with basic skeleton of an Angular app.

Repo of basic Angular app that imports the dwn-sdk-js and fails to compile: https://github.com/sondreb/angular-dwn

Hey @sondreb, I am looking into this issue. I published a temporary release 0.0.10-unstable-20221028-2 to work around the assertion issue, but also saw the following issue when ng build:

Did you ever work around the polyfill issue above?

The main issue is that the whole repo depends on Node.js packages that won't run properly in the web browser, like levelup which includes C++ binding for LevelDB. I don't know which other dependencies won't run in the browser, but that doesn't have to be an issue as especially the ESM versions should allow for tree-shaking for consumers of the library, but I'm not 100% sure. Best would be to have separate library for the core DID/JWS/CID, etc.

Hi @sondreb, @mistermoe checked in a PR to fix the package bundle meant to be used in the browser.
I have made a PR against your repo which shows that the issue is fixed https://github.com/sondreb/angular-dwn/pull/1 (I hope) with dummy usage of the DWN which should use browser-level under the hood.

Great work, thanks a lot! And I just noticed that the leveldb works cross-platform (Node/Web) as well, that's fantastic:


when the new release will be publish？

when the new release will be publish？

See https://github.com/pypa/pipenv/issues/3742.


Setting window.opener to null only works in browsers

Extracted from https://github.com/Microsoft/monaco-editor/issues/601#issuecomment-343846591
From @hawkerm
Regarding #601

I'm running Monaco in a x-ms-webview, so 10.1.0 broke that as I wouldn't get the uri in the new window request anymore (only about:blank).
Saw there were some updates for this code path in the vscode tree to detect if it was a 'native' platform.  Not sure if that'll detect the x-ms-webview case as well, but want to make sure this scenario can be covered too.

I'm not sure how to detect running in an x-ms-webview...

@hawkerm Is there any way at runtime for us to detect this special case? For example, this is how we detect the isNative case:
https://github.com/Microsoft/vscode/blob/52007064712fb8e74e8b7dd00903beaabcd79648/src/vs/base/common/platform.ts#L45
if (typeof process === 'object' && typeof process.nextTick === 'function' && typeof process.platform === 'string')
Perhaps there is a way for us to detect running under an x-ms-webview ?

@alexandrudima how about just looking at the user agent string?  It has WebView in the platform:
Mozilla/5.0 (Windows NT 10.0; WOW64; WebView/3.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Edge/16.16299
Compared to the browser in Edge:
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36 Edge/16.16299
The Windows WebView has an event for opening new windows which requires the developer using the webview to decide what to do with the requested new window.  It doesn't pass a reference or have any context from the requesting page, so its not susceptible to the opener issue.

Awesome, thanks for working towards a solution!


Ariel asteroid copy

There are only proposed edits on the "User Guide" doc. The "Installing and Running" changes are just test changes I immediately fixed to test how pull requests work. Only look at the proposed edits on the "User Guide."

I am closing this pull request.  Only final docs should be merged into the master trunk with a pull request.


Download ISM data from Globus

Download the following ISM datasets from Globus to temporary home on kj13:
ISMIP6 23rd Century Projections - endpoint
ISMIP6 23rd Century Forcing Datasets - endpoint
ISMIP6 initMIP-Antarctica simulations - endpoint
ISMIP6 ABUMIP Simulations - endpoint
ISMIP6 21st Century Antarctic Projections - endpoint
ISMIP6 21st Century Greenland Projections - endpoint
ISMIP6 21st Century Forcing Datasets - endpoint
ISMIP6 initMIP-Greenland simulations - endpoint

[ ] ISMIP6 23rd Century Projections - endpoint
[ ] IISMIP6 23rd Century Forcing Datasets - endpoint
[ ] IISMIP6 initMIP-Antarctica simulations - endpoint
[ ] IISMIP6 ABUMIP Simulations - endpoint
[ ] IISMIP6 21st Century Antarctic Projections - endpoint
[ ] IISMIP6 21st Century Greenland Projections - endpoint
[ ] IISMIP6 21st Century Forcing Datasets - endpoint
[ ] IISMIP6 initMIP-Greenland simulations - endpoint

All completed.
Total is 12TB.
R


Faculty profile page - build fields for faculty to indicate their degrees

Under the faculty name, there should be a horizontal section of degree checkboxes.
These should include (MD, PhD, MPH, MPP, MBA, MS, MA, other [FACP, FACC, ...])
I will open another issue but these should feed into a conditional search platform.

Also add: DMD, DDS, DO.
In the browse faculty view, default checked should be MD. Include a "show all" option that unchecks all of the degrees.

Formatting:
Name
Degrees: MD, PhD, etc. (separated by commas)

Here's the first draft of the UI

Testable on staging! https://hms-weave-staging.herokuapp.com

Awesome! One thing I'm noticing is filtering by MD shows the test profile
and filtering by FACP shows the test profile, but filtering on both of
those does not show the test profile. Filtering based on more degree
options should show the union of those degrees ("and" function). Some
people may want to search for a particular combination of degrees (I.e. MD
PhD) and filtering on both MD and PhD should bring up search results for
people who have both of these degrees.
On Wed, Mar 13, 2019 at 2:48 AM Razzi Abuissa<EMAIL_ADDRESS>wrote:

Here's the first draft of the UI
[image: image]
https://user-images.githubusercontent.com/2244895/54258890-48417f00-4521-11e9-8ec5-8b6a7cae6452.png
Testable on staging! https://hms-weave-staging.herokuapp.com
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/razzius/hms-weave/issues/72#issuecomment-472301061,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ApxaUR1mZIMNMgoAnBYYDUD5Zfv3G3e1ks5vWJ8-gaJpZM4a1fDa
.

Hm ok yeah that's definitely how it's supposed to be working. Probably something relatively simple. I'll look in to it later today.

Multiple degree filter works on staging

Wonderful! I tested out if the free text degrees (i.e. hiiiiii) would be
filterable and it seems like this was not. Which I think is perfectly fine.
This is a huge step - thanks Razzi! Would be cool to see what the admin
backend interface looks like whenever it becomes available.
On Thu, Mar 21, 2019 at 2:51 PM Razzi Abuissa<EMAIL_ADDRESS>wrote:

Multiple degree filter works on staging
[image: image]
https://user-images.githubusercontent.com/2244895/54777454-931d5f80-4bcf-11e9-91a5-704ea5e4608c.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/razzius/hms-weave/issues/72#issuecomment-475358660,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ApxaURaMkgJM7Mg9kVN_p7yPpFRi9nxsks5vY9SZgaJpZM4a1fDa
.

It seems stable to me so I'm deploying to production. If it is worth allowing free text degree filtering, feel free to create an issue. I intend to focus my attention on other features, once I get back to development in a couple weeks

I didn't add a backend admin interface. I recommend editing through the ui using the "edit as admin" feature, and searching for degrees to track progress. Building an admin would take a few hours and adding degrees manually would take a comparable amount of time given the number of profiles we have, so I'm declining to implement an admin at least in the immediate term. We can prioritize at a later date.
Since the basic functionality is there, I'm closing this issue.

Really good work on this Razzi! This is a big step for the platform, thank
you for putting it together and pushing to production!
Best,
Jon
On Thu, Mar 21, 2019 at 5:05 PM Razzi Abuissa<EMAIL_ADDRESS>wrote:

Closed #72 https://github.com/razzius/hms-weave/issues/72.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/razzius/hms-weave/issues/72#event-2221040484, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AFB-bb6PdR05CTYdaoMkXYOt1tegnZeSks5vY_QfgaJpZM4a1fDa
.


workflow for rna-seq-viz-with-cummerbund

added workflow and metadata

@bagnacan can you have a look at this worklow? Thanks a lot

@bebatut, once the input dataset is loaded, and the workflow is imported, all steps run smoothly, and the result is the desired one. Thanks @polkhe!

Thanks @bagnacan for checking! I merge it then


0.7.4 Cuts off Volume Names

Now limited to 12 characters.  Quite annoying.

I'm assuming you're referring to container names here?

fix merged in https://github.com/bcicen/ctop/pull/211 for 0.7.5

Hi! Thanks for this awesome tool!
Any chance 0.7.5 could be released as the milestone is complete?
The size limit currently renders ctop unusable as all our containers have a 10-char prefix ^^
Thanks! ❤

@simonc glad you're enjoying it :) - v0.7.5 is now live with this fix

@bcicen Thanks so much! It's displaying the complete names now 😍 You rock!


Feature Request: Supporting adding refernces of projects to set dependencies instead of including assemblies in output

Long title :smile: The idea is to have nuproj replace assemblies that are part of referenced projects with a dependency rather than including the dlls files in the final output.
I believe this is possible by hand editing the nuproj file however that starts to reduce the value of the visual studio build task.

Ignore this -- I released that I needed to reference the nuproj file instead of the source project

Right you are. :)


Module oh-my-posh was not found in central repository

why? how to install it?

You can find that here


Enhancement create coax port

Nitpick: rename title from "Enhancement create coax port" --> "create coax port" and add the enhancement tag. Tags are commonly used to group or filter PRs and make it easier to generate the release notes.

I cannot figure out how to fix the pre-commint failure. @maxcapodi78 @akaszynski @MaxJPRey , anyone can guide me with that?

I cannot figure out how to fix the pre-commint failure. @maxcapodi78 @akaszynski @MaxJPRey , anyone can guide me with that?

It looks like a known bug in the click.
https://github.com/psf/black/issues/2964

Pre-commit checks fixed in #1012. You can click the "Update branch" button to merge with main within the browser. Pressing...


Add namespace management UI under /admin/ns

[ ]  All namespaces listed
[ ]  Ability to create a new namespace
[ ] Duplicate namespaces are not allowed
[ ]  Ability to delete a namespace (prompt the user first — cascade delete all experiments)


when livekit config redis cluster address, its not works

Describe the bug
When livekit-server using the Redis cluster configuration, it does not work correctly.
Server

Version: [1.6.0]
Environment: [local dev, centos:7.2.1511]

REDIS

Redis Version: [5.x.x] cluster mode

To Reproduce
Steps to reproduce the behavior:

config.yaml as follow

bind_addresses:
  - <IP_ADDRESS>
#  - <IP_ADDRESS>
port: 7880

redis:
  password: mypasswd
  cluster_addresses:
    - redis-cluster.privite-server.local:6379
#rtc:
#  port_range_start: 50000
#  port_range_end: 60000
#  tcp_port: 7881
#  use_external_ip: true
keys:
  devkey: secret

./bin/livekit-server --config ./config/config.yaml
See error as follow

INFO livekit redis/redis.go:130 connecting to redis {"cluster": true, "addr": [redis-cluster.privite-server.local:6379"]}
could not get rooms: MOVED 4321 <IP_ADDRESS>:6379

Expected behavior
When using Redis cluster, I hope it works.
Using redis in single mode works well for me.
Any advice for resolving this problem will be greatly appreciated. Thank you :)

oops!
we only config one addr , it will go to opts.Simple
https://github.com/redis/go-redis/blob/master/universal.go#L240
func NewUniversalClient(opts *UniversalOptions) UniversalClient {
	if opts.MasterName != "" {
		return NewFailoverClient(opts.Failover())
	} else if len(opts.Addrs) > 1 {
		return NewClusterClient(opts.Cluster())
	}
	return NewClient(opts.Simple())
}

By test, when configuring two Redis cluster addresses, it worked, although those two Redis addresses are the same. The correct config.yaml is as follows. I hope this will be helpful for someone who is stuck here :)
bind_addresses:
  - <IP_ADDRESS>
#  - <IP_ADDRESS>
port: 7880

redis:
  password: mypasswd
  cluster_addresses:
    - redis-cluster.privite-server.local:6379
    - redis-cluster.privite-server.local:6379
#rtc:
#  port_range_start: 50000
#  port_range_end: 60000
#  tcp_port: 7881
#  use_external_ip: true
keys:
  devkey: secret


ENH: Using type hints for scipy functions

I have an idea about using python type hints for scipy functions and creating new type hints instead of
built-in types.
for example:
from typing import NewType, Union
array_like = NewType("array_like", Union[ndarray, list])

Type annotations would be useful I think. I don't know that much about it, it's unclear to me if it's blocked on https://github.com/numpy/numpy-stubs for better annotations for numpy arrays or not.

So, without the stubs for NumPy we're going to have the issue that Mypy will treat np.ndarray as Any, i.e. a very lot of things will make it through Union[np.ndarray, ...]. But we do still have plenty of function arguments that aren't arrays, and there's no reason to not start typing those.

@EverLookNeverSee generally speaking though I would be very interested in an effort to start getting type hints into SciPy.

What is a generalised type hint for something that could be a numpy array/sequence (list, tuple, etc)/iterable?

What is a generalised type hint for something that could be a numpy array/sequence (list, tuple, etc)/iterable?

So, as I understand it, the complete solution is unknown at this point. Even if the NumPy types continue to move forward, there's no way to express shapes currently, so you can't fully type ndarray. On the sequence/iterable side there's the problem that there are no recursive types-so there's no way to say something like "an iterable of iterable of ... of float".
So there would have to be compromises. I don't think that should stop us from trying though, because we can probably still do enough to provide some value to users!
There is still perhaps a question of whether we should first try to invest some time into the NumPy types; not sure how open they are to that though.

There is still perhaps a question of whether we should first try to invest some time into the NumPy types; not sure how open they are to that though.

Contributions are very much encouraged, there's not too many NumPy devs who have experience/interest, more momentum there would be great.

On the SciPy side, we should probably figure out whether we want to do this inside the main repo or not. As I see it:
Inside the repo

Types are next to the code they are typing, which is nice
Can still use backports in typing_extensions without adding dependencies by using the TYPE_CHECKING flag
Can't yet use from __future__ import annotations

Outside the repo

Not being coupled to SciPy releases allows for quicker iteration
Might be easier to use things like @overload and protocols; not sure if people would go for putting that inside the main codebase before the concept is much more proven out
Higher potential for drift; could be prevented by CI inside SciPy, but not sure if people would go for blocking PRs on external type stubs failing

Thoughts?

On the SciPy side, we should probably figure out whether we want to do this inside the main repo or not. As I see it:
Inside the repo

Types are next to the code they are typing, which is nice
Can still use backports in typing_extensions without adding dependencies by using the TYPE_CHECKING flag
Can't yet use from __future__ import annotations

Outside the repo

Not being coupled to SciPy releases allows for quicker iteration
Might be easier to use things like @overload and protocols; not sure if people would go for putting that inside the main codebase before the concept is much more proven out
Higher potential for drift; could be prevented by CI inside SciPy, but not sure if people would go for blocking PRs on external type stubs failing

Thoughts?

@person142 , I have no idea yet, but i think we need to get help from numpy experienced developers to simulate array_like type hint.

I lean toward adding types in-repo. I've never had great experiences with external type definitions because the potential for drift is so high.
Eventually we could consider adding a CI that runs mypy or some other type checker.

Also leaning towards in-repo, I think it'll encourage more contributions - numpy-stubs is languishing. For a lot of code adding annotations will be fairly mechanical, so it's a good place for newcomers to plug in once we have some clear examples/standard to follow.
Also, it will make it quite easy to experiment with Transonic.

Opened https://github.com/scipy/scipy/pull/11678 as one way we could get started with types in-repo.

I think we can close this now-there are many more things to do, but I think they are best tracked in separate issues. (And for some things, e.g. satisfying PEP 561 we'll have to see how this experiment goes first.)


dapr invoke error by grpc when use openvpn

In what area(s)?

hosts + Consul

What version of Dapr?

1.9.5

Expected Behavior
invoke success
Actual Behavior
last connection error: connection closed before server preface received
time="2022-12-18T21:55:08.232297+08:00" level=debug msg="retry count: 1, grpc call failed, ns: , addr: <IP_ADDRESS>:50002, appid: notify, err: rpc error: code = Unavailable desc = last connection error: connection closed before server preface received" app_id=gateway instance=nayandeMacBook-Pro.local scope=dapr.runtime.direct_messaging type=log ver=1.9.5
time="2022-12-18T21:55:09.320418+08:00" level=debug msg="retry count: 2, grpc call failed, ns: , addr: <IP_ADDRESS>:50002, appid: notify, err: rpc error: code = Unavailable desc = last connection error: connection closed before server preface received" app_id=gateway instance=nayandeMacBook-Pro.local scope=dapr.runtime.direct_messaging type=log ver=1.9.5
time="2022-12-18T21:55:10.410219+08:00" level=debug msg="retry count: 3, grpc call failed, ns: , addr: <IP_ADDRESS>:50002, appid: notify, err: rpc error: code = Unavailable desc = last connection error: connection closed before server preface received" app_id=gateway instance=nayandeMacBook-Pro.local scope=dapr.runtime.direct_messaging type=log ver=1.9.5
time="2022-12-18T22:17:23.700813+08:00" level=debug msg="retry count: 1, grpc call failed, ns: , addr: <IP_ADDRESS>:50002, appid: notify, err: rpc error: code = Unavailable desc = last connection error: connection closed before server preface received" app_id=gateway instance=nayandeMacBook-Pro.local scope=dapr.runtime.direct_messaging type=log ver=1.9.5
time="2022-12-18T22:17:24.732298+08:00" level=debug msg="retry count: 2, grpc call failed, ns: , addr: <IP_ADDRESS>:50002, appid: notify, err: rpc error: code = Unavailable desc = last connection error: connection closed before server preface received" app_id=gateway instance=nayandeMacBook-Pro.local scope=dapr.runtime.direct_messaging type=log ver=1.9.5
time="2022-12-18T22:17:25.764081+08:00" level=debug msg="retry count: 3, grpc call failed, ns: , addr: <IP_ADDRESS>:50002, appid: notify, err: rpc error: code = Unavailable desc = last connection error: connection closed before server preface received" app_id=gateway instance=nayandeMacBook-Pro.local scope=dapr.runtime.direct_messaging type=log ver=1.9.5

Steps to Reproduce the Problem
Service B sidecar invoke Service A  sidecar error by grpc.
But the port of Service A can be connected from Service B machine by telnet.
And Service A can be invoked success by http from Service B machin.

It had resloved.
The way is that close kubernetes and hosts mtls,then it work.


DO NOT MERGE: refactor ukvm to add ukvm backend

This is the result of splitting ukvm into a top half and a bottom half in order to get a better understanding of the abstract ukvm interface and add another platform (MacOSX/Hypervisor.framework in addition to the original Linux/KVM).  It works: I can run the same .ukvm binary with either uhvf-bin or ukvm-bin for the standalone tests and the Mirage tests I use (console, block, stackv4). It's still a bit rough, but I think it's high time to get some feedback now.
@mato @hannes, I know you guys don't run MacOSX, but I would appreciate your feedback even if you can't run it on your systems :)
@ricarkol hopefully it works on your mac!
As the ukvm directory was renamed to monitors, there is a change needed in the mirage tool if building mirage unikernels (see https://github.com/djwillia/mirage/commit/841a9b2d584d4686f9c5fdd2bbb625fb9eeb2aa8)
In addition to comments on the code itself, there are two major issues that we need to discuss:

What to do about PVCLOCK.  Hypervisor.framework doesn't have it (and there are reasons that something "trappable" is preferable for e.g., deterministic replay).  At the moment, I've switched things to rdtsc but it's incomplete and hacky at the moment.

What to do about the build tools.  uhvf needs to be built on MacOSX to get the appropriate headers and link with the appropriate libraries.  But most of the Mirage build typically happens (for me) using Docker for Mac, which means it's really happening in a Linux VM. I'm not sure what the best way is to make this happen seamlessly.

If you'd like it partitioned into separate commits or something, let me know!

is the (for virtio already implemented) tscclock an option here?
no clue whether there are usable cross-compilation toolchains to build MacOSX binaries on Linux (in a docker container) -- my usual approach is to build on the platform I target (if sufficient resources are available on the target).  MirageOS (and OCaml) should also compile seamlessly on MacOSX (and then you won't need Docker, instead let opam drive the compilation) using homebrew (AFAIK, and I don't have a Mac)

We don't have the means to calibrate the tscclock in the same way, as the ukvm interface does not emulate a i8254 hardware timer.  It also does not emulate the RTC.
That said, I think all the relevant info can be passed in via ukvm hypercall and then used in the implementation of a couple of functions similar to tscclock_monotonic() and tscclock_epochoffset(), which would be a bit more consistent with the tscclock implementation, although not much code would be shared.

Apparently there are cross-compilation toolchains like https://github.com/tpoechtrager/osxcross (as pointed out by @justincormack on slack).  Solo5 does not yet compile on MacOSX (though it's close thanks to your work getting it to compile on FreeBSD).  I still like the idea of trying to keep everything for building in its own container, but this may not make sense here...

Starting with the two points @djwillia mentioned

Starting with the two main points in @djwillia's first comment:

Regarding PVCLOCK. The proposed change to ukvmclock where the monitor provides a new UKVM_PORT_TIME_INIT which hands the tsc_freq and rtc_boot values to the guest seems reasonable at first glance. However: It's unclear if tsc_freq can be reliably determined on Linux (and you acknowledge that in the function that uses /proc/cpuinfo). There may be something we can do using either MSRs or performance counters, however that may require root which would be bad.
A bigger issue with the timekeeping implementation on the Hvf side is that it relies on trapping every RDTSC instruction. Keep in mind that timekeeping is extremely performance-sensitive, having every RDTSC cause a VMEXIT is going to be painfully slow.

Regarding build tools, the situation thanks to Apple is just bad. While OSX-on-foo cross compilers exist, they rely on users manually downloading the Apple SDK, which is not redistributable (https://www.apple.com/legal/sla/docs/xcode.pdf) and requires an Apple ID to download. In practice I think this means building the OSX parts outside of OSX is not realistic (sorry Dan, your containers won't be redistributable). For a pure native OSX build, I would investigate doing things the other way round, i.e. when building uhvf build/install/otherwise get an ELF toolchain as part of the Solo5 build.
This does not resolve the question of how the "specialised" uhvf should be built as part of e.g. a MirageOS build process in a container -- I don't have a good idea for this at the moment :-( I see that you've changed ukvm-configure to always try and build ukvm-bin and uhvf-bin, this won't work without an OSX toolchain...

General comments on the code (copied from paper notes, the diff is too big for me to comment on it directly on Github):

Could you please reformat the changes to use "4 spaces and not tabs"? At the moment there's an indentation mess which makes the diff hard to read.
You're not using an IDT and uhvf explicitly sets IDTR.base and IDTR.limit to zero. I'm surprised this works at all, I'd expect it to triple-fault and shutdown the VCPU on an exception. Have you verified that you can trap exceptions in uhvf?
pread_in_full() has an unnecessary change to lseek() / read(). AFAICT OSX has a pread() call, verified on a spare Mac I have.
ukvm-elf.h is CDDL, I think that needs to be replaced with a suitably licensed copy from one of the BSDs.
UKVM_PORT_POLL is changed to use pselect(), presumably due to the absence of ppoll() on OSX. This is fine, but we may want platform-dependent implementations of this in the future.
platform_vcpu_t should be int for KVM, not uint64_t.

Apart from these comments, nice work! The struct platform abstraction makes sense to me, but we need to think about how multi-arch will fit in, hence #151.
Also, I think the changes should be split up somehow. Need to print out(!) the diff and stare at it for a while, will follow up.

This has been superseded by #171, so I think we can close it?

No one's complained and #171 is long since merged, so I'm closing this.


Update supportedPlaybackCommands and supportedTrackControlCommands fo…

Update supportedPlaybackCommands and supportedTrackControlCommands for matter-media

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is ready for review. I will address the other comment in a separate PR since it is waiting for the next lua library release. However, this feature map functionality is ready to go.


Profile view: should have grid/list view toggle

Sender<EMAIL_ADDRESS>Comment: List/grid view toggle
Open #22 in Usersnap Dashboard
Notes:

(1) Add grid/list view toggle to this page

Download original image
Browser: Chrome 58 (macOS Sierra)
Referer: https://participedia.xyz/users/169032
Screen size: 2560 x 1440 Browser size: 1622 x 1295
Powered by usersnap.com

This issue was moved to participedia/usersnaps#14


Monitor onError (Throwable e)

Whether you can expose the onError (Throwable e) in HttpProxyCacheServer to an external caller and make a timely action based on the error.

@liu-xiao-dong why do need it?

04-28  10:04:00.515 5271-5271/com.example.android.uamp E/uamp_LocalPlayback: error url: http://www.baidu.cccc
04-28 10:04:00.521 5271-5271/com.example.android.uamp E/uamp_LocalPlayback: error proxyUrl set to media player: http://<IP_ADDRESS>:59393/http%3A%2F%2Fwww.baidu.cccc
04-28  10:04:31.193 5271-5271/com.example.android.uamp E/uamp_LocalPlayback: Media player error: what=1, extra=-2147483648
I use Media Player to play music, if you set a wrong url to AndroidVideoCache, but also lead to the wrong url set to the Media Player, and this time, AndroidVideoCache soon occurred Exception, but after the internal try catch, the external can not accept To Error, and monitor the Media Player Error callback until 30 seconds after receiving the Error message, which will lead to the user can not quickly feedback, resulting in poor user experience.

Please create issue on hithub.

28 апр. 2017 г., в 5:11, 刘晓东<EMAIL_ADDRESS>написал(а):
04-28 10:04:00.515 5271-5271/com.example.android.uamp E/uamp_LocalPlayback: error url: http://www.baidu.cccc http://www.baidu.cccc/
04-28 10:04:00.521 5271-5271/com.example.android.uamp E/uamp_LocalPlayback: error proxyUrl set to media player: http://<IP_ADDRESS>:59393/http%3A%2F%2Fwww.baidu.cccc http://<IP_ADDRESS>:59393/http%3A%2F%2Fwww.baidu.cccc
04-28 10:04:31.193 5271-5271/com.example.android.uamp E/uamp_LocalPlayback: Media player error: what=1, extra=-2147483648
I use Media Player to play music, if you set a wrong url to AndroidVideoCache, but also lead to the wrong url set to the Media Player, and this time, AndroidVideoCache soon occurred Exception, but after the internal try catch, the external can not accept To Error, and monitor the Media Player Error callback until 30 seconds after receiving the Error message, which will lead to the user can not quickly feedback, resulting in poor user experience.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/danikula/AndroidVideoCache/issues/136#issuecomment-297888447, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGuq4byu4RbXrhY9rIJkVrJMGlQY3Fbks5r0UrMgaJpZM4NJtpx.

What is hithub? Please give me a link。

@liu-xiao-dong I got. In case of direct url network connection quickly reports 500 or 404 error code and MediaPlayer quickly process it. In case of proxied url AndroidVideoCache just closes connection if there is no cache. That is why MediaPlayer performs few attempts. I think exporting error listener is not the best choice. Instead AVD should forward real server's response to client somehow.

@danikula  Okay, I try to do some processing, thanks for the reply .

@liu-xiao-dong sure. Created issue #137 , because I should fix case you described.


Add documentation for federated config map

Same as #1825 but for 1.5 release.
cc: @nikhiljindal @madhusudancs

This change is

@mwielgus this is cool! Thanks for addressing all the comments. I skimmed through. I hope I did not miss anything.

cc @kubernetes/docs

Just a handful of small comments. Thanks!

@madhusudancs , @mwielgus , question: Are the new Federated controllers being added to the existing Federation TOC anywhere?
One of these PRs needs to do that, so that users can find the new docs.

@madhusudancs , @mwielgus , question: Are the new Federated controllers being added to the existing Federation TOC anywhere?

@devin-donnelly thanks for reminding that! We haven't done/are not doing that. We probably should. I can send a separate PR for all of these combined.
Also, the TOC for federated resources is not that discoverable. Despite having worked on these things, I had trouble finding them. We should probably make them more discoverable.

@madhusudancs I agree--they were completely missing in 1.4, and I had to add them on very short notice on launch day last time.
I'll get with sig-docs and the other TWs here and see where Federation fits into the new docs organization.

@devin-donnelly sure, thanks!
Also, sent a PR for the links - https://github.com/kubernetes/kubernetes.github.io/pull/1848


feature(filesystem) Use Filesystem protocol instead of Datalake Facade for CheckOperator and DeleteOperator.

@biel-llobera-mck @biellls You can review the PR with the latest changes.


Issue with demo.yaml

Describe the bug
Hi guys,
Firstly, fantastic work on this amazing project! I'm about to move into our new home with 20kW of solar panels so this will be a wonderful tool to have and I'll be sure to sponsor the project when I get my installation up and running.
In the meantime, I'm trying to get a feel for the software and I'm attempting to use the demo.yaml file (https://github.com/evcc-io/evcc/blob/master/cmd/demo.yaml) for a dummy meter and charger. I have a Tesla which I've configured successfully but the dummy meter and charger fails when I use the javascript and code from the demo.yaml file:
root@docker:/opt/evcc# sudo docker exec evcc evcc -l debug charger
[main  ] INFO 2023/06/04 12:27:33 evcc 0.117.4
[main  ] INFO 2023/06/04 12:27:33 using config file: /etc/evcc.yaml
[main  ] FATAL 2023/06/04 12:27:34 cannot create charger 'charger_1': cannot create charger 'custom': enable: 1 error(s) decoding:

* '' has invalid keys: out

This is resolved if one uses an older version of the demo.yaml file such as: https://github.com/evcc-io/evcc/blob/b503f0152f11ce76f9cd2d2370d3e6e65c236509/cmd/demo.yaml
Steps to reproduce
Use the current demo.yaml file
Configuration details

javascript:
  - vm: shared
    script: |
      state = {
        residualpower: 500,
        pvpower: 5000,
        batterypower: -750,
        batterySoc: 55,
        gridpower: -1000,
        loadpoints: [
          { enabled: true, vehicleSoc: 62, maxcurrent: 6, phases: 1, chargepower: 0 },
          { enabled: false, vehicleSoc: 22, maxcurrent: 0, phases: 3, chargepower: 0 }
        ]
      };
      function logState() {
        console.log("state:", JSON.stringify(state));
      }

chargers:
  - name: charger_1
    type: custom
    enable:
      source: js
      vm: shared
      script: |
        logState();
        var lp = state.loadpoints[0];
        lp.enabled = enable;
        enable;
      out:
        - name: enable
          type: bool
          config:
            source: js
            vm: shared
            script: |
              if (enable) lp.chargepower = lp.maxcurrent * 230 * lp.phases; else lp.chargepower = 0;
    enabled:
      source: js
      vm: shared
      script: |
        state.loadpoints[0].enabled;
    status:
      source: js
      vm: shared
      script: |
        if (state.loadpoints[0].enabled) "C"; else "B";
    maxcurrent:
      source: js
      vm: shared
      script: |
        logState();
        var lp = state.loadpoints[0];
        lp.maxcurrent = maxcurrent;
        if (lp.enabled) lp.chargepower = lp.maxcurrent * 230 * lp.phases; else lp.chargepower = 0;

Log details
[main  ] INFO 2023/06/04 12:27:33 evcc 0.117.4
[main  ] INFO 2023/06/04 12:27:33 using config file: /etc/evcc.yaml
[main  ] FATAL 2023/06/04 12:27:34 cannot create charger 'charger_1': cannot create charger 'custom': enable: 1 error(s) decoding:

* '' has invalid keys: out

What type of operating system are you running?
Docker container
Version
No response

You can't use the demo.yaml with the release version. We've added new plugin capabilities that are not released yet.


(25, inappropriate ioctl for device) error when using in Jupyter Notebook

When trying to use bullet in a jupyter notebook, I got the following error:
error: (25, 'Inappropriate ioctl for device')

Is there support for notebooks? Is there a way I can get past this error?

Maybe  Non Terminal enviroment will cause such error.
Also happened on Pycharm, but when I ran script in terminal ,it worked well.

I have the same issue, and your open issue request means that it exist for at least 2 years now


Non-semver support, squashed PRs, and fixed attribution

[x] Fix non-semver sorting (#9)
[x] Match the squash PR commit message format (#8)
[x] Fetch the PRs rather than using commit string matching (#7)
[x] Tests

Thanks!


Uses JavaExec directly to avoid spending time on dists

A few more lines, but hopefully a lot less time and i/o. Merge after https://github.com/openzipkin/docker-zipkin/pull/24

ok this should be safe to merge, since docker only uses fat jars now.

:+1:

Nice!
I guess it'd be possible to move the common parts into a separate .gradle file, but it's questionable whether that would make this easier or harder to read.
Great stuff!


 shades rows on hover when clickable

This PR adds DynamicTableOptions.clickable. When clickable and the cursor hovers over a row, additional styling applies to help differentiate the fact that is the target of a click.
https://github.com/xy-planning-network/trees/assets/27823069/455c810b-fd29-48e5-811d-45e5b31c4757

I'm conflicted on this a bit, since we are down to a single instance of @click:row on the notifications table in portal, and I'm not sure why we held on to it there.  Looking at the groups table usage in #1223 it feels like an action button of "View" or similar would be ok especially at this juncture in admin tooling.  If nothing else, we continue to steer ourselves towards consistent usage of tables until we get some user feedback that pushes us in another direction.
I do think this highlights the potential need for "selectable" rows, especially in admin scenarios.  Either single select or multiselect (which Archive has an implementation of) where "selecting" rows isn't duplicating the functionality of ActionItems i.e. firing a callback, but is populating a v-model:selected with the selected item or items.  That theoretically opens up some new functionalities, like selecting a row to display additional details or edit forms in an adjacent component.  I'm definitely speculating, but separating "selections" and "actions" probably has the most long term value for us.
Happy to PL.  Otherwise, toss in a "View" button to keep moving forward.

Definitely a good PL and not sure I'm on board with moving away from clickability of rows. In the case of #1223, I don't want action items to expand beyond the single use of the table, which is navigation. Something I'll think about over the weekend, of course.
One point I'd make separate from the action conversation is just the need for some contrast between rows on tables. Using the <DetailList /> example in dev/, it feels natural to throw that hover:bg-gray-50 so the user has a way to focus in on a row in the table (or an item in the list). Dropping cursor-pointer seems like a fair compromise for now, in my opinion, as our users will get used to the fact that a table's rows are clickable, generally, and some tables do something with that, others don't. The cursor isn't there to confirm/deny it's clickable.


Add a generic transaction issuer/watcher component

It should report progress and status

@shaharyakir looks like the issue is resolved?


remove "Fetch all" button from repositories window?

I think is confusing... and dangerous to ask for a complete fetch/load of all active repositories, so I propose to just remove it.
What do you think?

Load all actives is dangerous but fetch all should be fine no?

not really (why would you fetch all projects you may have there... including pharo itself).
I don't see the purpose of this to exist, honestly :)

I don't have iceberg right know to check the interface but do we still see the number of incoming/outgoing commits for each projects if we don't fetch all? If yes, I agree, this button can be removed.

no, you have to fetch one by one, but you have a point there... in anycase, fetch should just "fetch" (no load)

Yes!
I use a GUI outside Pharo that allow the user to give a timing for an auto fetch. By default is 3min and if you don't want the auto fetch you put the setting to 0min. What do you think of that for the futur?


[Fix #8938] Fix some ConfigurableEnforcedStyle cops so they output Exclude file lists in --auto-gen-config runs

[Fixes #8938]
The expected use of the API provided by ConfigurableEnforcedStyle is
for the cop to call correct_style_detected if the cop detects no
offense or to call one of the other xxx_style_detected api methods if
it does detect an offense, and it should also call add_offense to
register the offense. Doing this updates config_to_allow_offenses which
is used during --auto-gen-config to decide how to configure the cop for
the current code under review so that regardless of the styles used the
code passes review.
This PR fixes errors in several cops that use this API incorrectly:

Layout/SpaceAroundEqualsInParameterDefault
Layout/SpaceBeforeBlockBraces
Style/For
Style/RaiseArgs
Style/AccessModifierDeclarations
Style/MethodDefParentheses
Style/SpaceInsideHashLiteralBraces
Style/SpaceInsideBlockBraces

I eyeballed all the cops that include this module and the ones above are the only ones that both use the xxx_style_detected APIs and use them incorrectly.  The majority of the cops that include this module don't use the xxx_style_detected APIs at all.
Note: Style/LambdaCall also exhibits this error, but there's an independent PR (#9246) and issue (#9225) recorded to fix that cop.
TODO

Added tests
It's not clear to me how to write tests for this change as the error is in the output of a --auto-gen-config run which there don't appear to be any examples of.  We could write tests that assert the internal API is called correctly, but the rest of the suite prefers asserting on outcomes so this doesn't feel like the correct approach.  I'd appreciate any advice on the required testing needed.
Squashed related commits together
I've put single commits per cop, would you prefer I smoosh them all into one commit?

Before submitting the PR make sure the following are checked:

[X] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[X] Wrote good commit messages.
[X] Commit message starts with [Fix #issue-number] (if the related issue exists).
[X] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[X] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[X] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

It's not clear to me how to write tests for this change as the error is in the output of a --auto-gen-config run which there don't appear to be any examples of. We could write tests that assert the internal API is called correctly, but the rest of the suite prefers asserting on outcomes so this doesn't feel like the correct approach. I'd appreciate any advice on the required testing needed.

Probably it'd be best to create some InternalAffairs cop that makes sure the API is used properly. I'll likely cut a new release on Chrismas for Ruby 3, so it'd be nice if we wrapped this up in time for it.

I've put single commits per cop, would you prefer I smoosh them all into one commit?

No need.

Probably it'd be best to create some InternalAffairs cop that makes sure the API is used properly. I'll likely cut a new release on Chrismas for Ruby 3, so it'd be nice if we wrapped this up in time for it.

Added InternalAffairs/StyleDetectedApiUse (not 100% sold on the name, but 🤷).  This cop checks that the style detected API is used correctly:

The methods aren't used in conditionals - maybe this is overkill, but from what I saw, if they were it was a mistake.  The methods aren't predicates to be used for checking something, they mutate state and you can't rely on the return value in a conditional setting.
If the correct_style_detected method is called then so is one of the negative versions, and vice-versa.

This cop isn't perfect because to truly check 2. we'd need to trace the full path through the cop in question and work out that all branching paths that through which lead to a correct_style_detected can be traced through the opposite path to a negative version.  However, I think it's good enough because running it on "master" before all the commits I added it raised offences for 8 of the cops I identified as being using the API in error.  The one it couldn't detect Style/SpaceInsideBlockBraces was the most complicated one because while it does call correct_style_detected and a negative version, it calls correct_style_detected correctly for EnforcedStyle offences, but incorrectly calls the negative ones for EnforcedStyleForEmptyBraces offences.
Also, it checks all the cops, should it attempt to only do so if the code is a cop that includes ConfigurableEnforcedStyle?  This feels hard because some cops include the module indirectly through other modules, and I don't think an AST parser can be aware of that.
FWIW: because the fix for Style/LambdaCall lives in #9246 introducing this cop means the "build" for this PR no longer passes.  Would it make sense to cherry-pick the commit from there into here, or just do some judicious merge + rebase ordering?

I've merged the other PR, so we should good. Great work! Thanks!


Need a diagnostic build inside VS that is actually diagnostic

Diagnostic builds inside VS used to contain property and items values at the start of the log. It was turned off for reasons that I cannot remember (probably perf).
When debugging builds inside VS, usually I can get away with falling back to command-line and using it's diagnostic mode (which does include property/items values). However, when debugging design-time issues - that's much harder, because there's a lot more influence at play such as global properties and the targets that are being called.
I'd like either a option or a new mode that actually includes property and items values inside VS logging.

Isn't this a property of the logger that VS (CPS?) is attaching? Properties and Items are available in MSBuild's ProjectStartedEventArgs, so it should be easy to log them.

Okay, after spending a non-trivial amount of time walking through MSBuild's logging infrastructure (oh my is there a lot of indirection!) - I found out the cause and the right place to change this.
The default logger that we use (ConsoleLogger), already logs parameters, items and tasks inputs if they are specified. However, they weren't getting passed through to it. Turns out, it was because this was turned off via BuildParameters and it was actually only turned for Design-Time builds.
The solution build manager has the following:
                if (verbosity == LoggerVerbosity.Diagnostic)
                {
                    buildParameters.LogTaskInputs = true;
                    buildParameters.LogInitialPropertiesAndItems = true;
                }

The CPS design-time build manager doesn't turn this on. The fix is to do that.

I've submitted a fix to CPS here: https://mseng.visualstudio.com/VSIDEProj/_git/VSIDEProj.CPS/pullrequest/188492?_a=files&path=%2Fsrc%2FMicrosoft.VisualStudio.ProjectSystem.Implementation%2FBuild.


Add started_at/ended_at also if benchmarks are skipped due to build failure

Simple oversight in #428.
Add the corresponding test.
Fixes #433

Straightforward bugfix, so will merge soon.

Coverage increased (+0.2%) to 70.827% when pulling 955e8a2857baf3631686eecea8097c362fc284d0 on pv:fix-skip-bench into d3923b4371e80a5fb6bb03f434fbd2c56803013b on spacetelescope:master.

Coverage increased (+0.2%) to 70.827% when pulling 955e8a2857baf3631686eecea8097c362fc284d0 on pv:fix-skip-bench into d3923b4371e80a5fb6bb03f434fbd2c56803013b on spacetelescope:master.

:+1: - thanks for the quick fix!


EASY-2722: error handling

Fixes EASY-2722: error handling
When applied it will...

fail fast on a file of dataset
isolate CSV handling

Where should the reviewer @DANS-KNAW/easy start?
How should this be manually tested?
see #4
The lines in the csv
Related pull requests on github

repo
PR
note

easy-
PR#
..

Looks good, review done over Skype


ActivationConstraint.UIContext is poorly documented and difficult to use with existing known UIContext

Navigate to https://learn.microsoft.com/en-us/visualstudio/extensibility/visualstudio.extensibility/get-started/oop-extensibility-model-overview?view=vs-2022
Click "Inside the SDK -> Activation Constraints" -> navigates to https://learn.microsoft.com/en-us/visualstudio/extensibility/visualstudio.extensibility/inside-the-sdk/activation-constraints?view=vs-2022
Search for any mention of UI Contexts

Observed: None
More poking around will turn up https://learn.microsoft.com/en-us/dotnet/api/microsoft.visualstudio.extensibility.activationconstraint.uicontext?view=vs-extensibility#microsoft-visualstudio-extensibility-activationconstraint-uicontext(system-guid) - but this lacks an example.
Attempting to use with existing constants for well-known UIContexts fails at compile time:
LoadedWhen = ActivationConstraint.UIContext(VSConstants.UICONTEXT.ShellInitialized_guid),

An issue was encountered when evaluating the compile-time constant xxx.GladstoneExtension.ExtensionConfiguration. Unexpected error when evaluating compile-time constant value: Microsoft.VisualStudio.Shell.Framework has references outside of netstandard2.0 and can not be loaded.
Recommendation
This was in the context of an in-proc VS.Extensibility extension, where I had access (in theory) to the VsConstants.UICONTEXT static type. For a pure VS.Extensibility extension, a similar static with well-known UI contexts available would be useful and not require me to need to look up and duplicate the actual string value.

Extension metadata generator have a limited set of assemblies it can load, since ShellInitialized_guid is not a const it will require loading of Shell.15.0.dll assembly.
Can you instead try:
ActivationConstraint.UIContext(Guid.Parse(VSConstants.UICONTEXT.ShellInitialized_string)),

Closing this with the workaround mentioned above.


Using pyproject.toml with seed-isort-config results in a list, which breaks _as_list

I'm using isort as a pre-commit hook, in conjunction with seed-isort-config and a pyproject.toml in my root dir.
It seems that seed-isort-config has now gained support for toml, and is thus setting known_third_party = ["dateutil", "pydantic", "requests", "urlpath"]
I believe that isort is still expecting the value to be a comma-separated string, as I am getting the following traceback when trying to run it:
Traceback (most recent call last):
  File "/Users/step7212/.cache/pre-commit/repou647ppru/py_env-python3.7/bin/isort", line 10, in <module>
    sys.exit(main())
  File "/Users/step7212/.cache/pre-commit/repou647ppru/py_env-python3.7/lib/python3.7/site-packages/isort/main.py", line 342, in main
    config = from_path(arguments.get('settings_path', '') or os.path.abspath(file_names[0]) or os.getcwd()).copy()
  File "/Users/step7212/.cache/pre-commit/repou647ppru/py_env-python3.7/lib/python3.7/site-packages/isort/settings.py", line 182, in from_path
    _update_settings_with_config(path, 'pyproject.toml', [], ('tool.isort', ), computed_settings)
  File "/Users/step7212/.cache/pre-commit/repou647ppru/py_env-python3.7/lib/python3.7/site-packages/isort/settings.py", line 250, in _update_settings_with_config
    _update_with_config_file(editor_config_file, sections, computed_settings)
  File "/Users/step7212/.cache/pre-commit/repou647ppru/py_env-python3.7/lib/python3.7/site-packages/isort/settings.py", line 297, in _update_with_config_file
    computed_settings[access_key] = union(existing_data, _abspaths(cwd, _as_list(value)))
  File "/Users/step7212/.cache/pre-commit/repou647ppru/py_env-python3.7/lib/python3.7/site-packages/isort/settings.py", line 321, in _as_list
    for item in value.replace('\n', ',').split(',')
AttributeError: 'list' object has no attribute 'replace'

Example pyproject.toml:
[tool.isort]
multi_line_output = 3
include_trailing_comma = true
force_grid_wrap = 0
use_parentheses = true
line_length = 88
combine_as_imports = true
known_first_party = ["mypackage"]
known_third_party = ["dateutil", "pydantic", "requests", "urlpath"]

Adding the following to the beginning of the function fixes the issue for me:
def _as_list(value: str) -> List[str]:
    if isinstance(value, list):
        return value

Alternatively, we could strip the items like so:
def _as_list(value: str) -> List[str]:
    if isinstance(value, list):
        return [item.strip() for item in value]

I can submit a PR but I'll wait for discussion on which method to go with, if either.

HI @StephenBrown2,
Thanks for reporting this and identifying a resolution! I like the second solution.
Thanks!
~Timothy


Pypi store my new package version but return 400 filename reuse error

Describe the bug
I'm trying to release a new version of https://github.com/algoo/preview-generator , but i do not success to have a real new release in pypi. My package get stuck in a sort of  "mid-zone", not really released but stored by pypi website.
During the twine process, i do get this error:
HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
This filename has already been used, use a different version. See https://pypi.org/help/#file-name-reuse for more information

The problem here, is that... i do not have already used this filename, so i don't see why i do get this issue.
It seems that pypi as somehow accepted my new version of package as pypi do store the version i just tried now to push as
https://github.com/algoo/preview-generator/archive/release_0.15.tar.gz is accessible (and the code here is really the 0.15 code) but pypi (and pip) say the last version remained 0.14, so the new version is not really released, and not usable with pip.
I do make a test on test pypi instance but cannot reproduce the issue. i was able to push a proper new release : https://test.pypi.org/project/preview-generator/
note: 0.15, 0.15.1 and 15.2 are both 3 "broken release" (i do some retry to be sure that the behavior wasn't just some kind of "bad luck").
Expected behavior
Have proper new release when i do use twine upload command line.
To Reproduce
i do reproduce when i try to upload a new version in preview_generator project using twine on official pypi website, cannot reproduce the problem in testpypi.
My Platform
twine --version
twine version 3.2.0 (pkginfo: <IP_ADDRESS>, requests: 2.24.0, setuptools: 40.8.0,
requests-toolbelt: 0.9.1, tqdm: 4.47.0)

According to PyPI's logs, the versions 0.15, 0.15.1, 0.15.2 and 0.15.3 were used by the previous project owner in May of 2017. You won't be able to use those versions and will have to pick a new version.

Not to my knowledge.

Thanks, is there anyway to know if there is other hidden already used version ?

You might be able to look at the audit logs/security logs of the package, to see what past releases have been made.


Upgrade package.json to use capacitor 1.5.1

Per the comments in this issue (#6 (comment)), I cannot use this plugin with an upgraded capacitor unless the plugin capacitor version matches my project capacitor version.
My previous PR to upgrade for Capacitor 1.4.0

Thanks for pull request!!
This should probably be the latest. I will switch to latest when Capacitor 2.0 is released.


Some "valid" code with a comma expression incorrectly rejected

auto a = 1, 2;

Actually, never mind. That code's the result of an accepts-invalid bug in DMD. If comma expressions were allowed as auto initializers, than this should work:
auto a = 1, 2, b = 3;

but it doesn't.


update to latest #BenchmarkDotNet version

Hello!
You have  reported a bug in BenchmarkDotNet repo.
I have now fixed it. The problem is that we will not ship next version soon, so I added link to our development feed to use the latest dll with the fix.
Extras:

BenchmarkSwitcher can accept Assembly now so you don't need to mess with the reflection on your own
I added an assembly-wide config for you, so if you want to use some Diagnosers you just need to uncomment the corresponding code (I noticed your comments left in the code which said that it did not work before)

Best regards,
Adam

Thanks for this! Great stuff, I'll give it a test asap.

@JimBobSquarePants Most probably it was impossible to download the nuget containing fix from our CI feed (we were publishing nuget with same version and it was not getting overriden). I updated the code, hope it will work for you now. Sorry for the trouble!
Sample results I got:

Host Process Environment Information:
BenchmarkDotNet-Dev.Core=v<IP_ADDRESS>
OS=Microsoft Windows NT 6.2.9200.0
Processor=Intel(R) Core(TM) i7-4700MQ CPU 2.40GHz, ProcessorCount=8
Frequency=2338333 ticks, Resolution=427.6551 ns, Timer=TSC
CLR=MS.NET 4.0.30319.42000, Arch=64-bit RELEASE [RyuJIT]
GC=Concurrent Workstation
JitModules=clrjit-v4.6.1055.0

Type=ColorEquality  Mode=Throughput  GarbageCollection=Concurrent Workstation

                      Method |     Median |    StdDev | Scaled | Scaled-SD |    Gen 0 | Gen 1 | Gen 2 | Bytes Allocated/Op |

-------------------------------- |----------- |---------- |------- |---------- |--------- |------ |------ |------------------- |
System.Drawing Color Equals | 47.5207 ns | 3.5238 ns |   1.00 |      0.00 | 1,692.00 |     - |     - |              18,92 |
ImageProcessorCore Color Equals | 20.4920 ns | 0.5208 ns |   0.43 |      0.03 |        - |     - |     - |               0,00 |

@adamsitnik Ah excellent! I've been desperate to get the diagnostics stuff running. I'm gonna pull all this in now that it looks ready. Thanks so much! :smile:


feature request: realtime sort & filtering on data preview without requerying

First off, AirPal looks awesome, way to kill it :)
So some useful additions on the data preview:

sort by a column / multiple columns
filter for a value in a column / multiple columns
show all rows in a partition (not as useful as the first 2)

use-case:
It's pretty common that you start with 1 particular value of interest. Maybe a client name, charge amount & date, etc.  I remember during meetings or via e-mail getting asked to pull something from the db, which was really just a specific row.  Add filtering & sorting to a table, then it lets any person familiar with Excel to get this kind of data out of AirPal.
implementation:
From FixedDataTable docs I don't believe they do virtualization... maybe I'm wrong.  You can do this without requerying the table or crashing the DOM if you use SlickGrid (https://github.com/mleibman/SlickGrid). It just does virtual rendering for your table so you can have ~ 1M rows without destroying the DOM / js. Then the filtering or sorting is instant (<100ms from when I used it on ~1M rows).
I'm sure you'll still have partitions that need to be capped at 1M (maybe I'm forgetting the scale of most hive partitions), but for a lot of tables it's pretty useful when exploring the data or trying to check values quickly.  For example, we can sort by date & by transaction size. Or find a row with a particular location & rating - all without writing SQL / waiting for requery.
One downside to SlickGrid, is it doesn't use HTMLs table algorithm to size columns (since the rows aren't actually part of the DOM).  But you can take the max() of each column and render it offscreen to get the ~column widths.

From FixedDataTable docs I don't believe they do virtualization...

Actually, they do.

I'm not very familiar with SlickGrid (looks good at first sight) but wanted to chime in that I've happily used datatables (http://www.datatables.net/) for a few projects.
Add it to the list of libs to evaluate for this feature!


The union of two timestamptz changes the time of the stamps

The union of two timestamptz changes the time.
How to reproduce the bug
Go to sqleditor and run
select '2022-01-17T00:00:00+01:00'::TIMESTAMPTZ
UNION
select '2022-01-18T00:00:00+01:00'::TIMESTAMPTZ

this produces
timestamptz
2022-01-16T23:00:00+01:00
2022-01-17T23:00:00+01:00

instead of
timestamptz
2022-01-17 00:00:00+01
2022-01-18 00:00:00+01

Without the union the timestamptz is displayed correctly.
If the query is ran directly on postgresql it is displayed correctly.
This is more than a timezone display bug because 2022-01-16T23:00:00+01:00 and 2022-01-17 00:00:00+01 are different times.
Our guess is that since superset uses pandas internally, pandas doesn't handle datatimes with non-utc timezones very well and sometimes defines the column as 'object' instead of datetime[ns,UTC]. However, the superset must be doing something more wrong because the displayed time is not even the same input string anymore since the timezone offset is there but also applied on the time, as if it were mixing a conversion to UTC and using the original timezone offset when printing.
Environment
(please complete the following information):

browser type and version:
superset version: 1.3.2

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

What timezone is your Superset installation set to?
I.e., what is the session timezone of Superset's connection to Postgres?
Not quite sure yet, but I suspect that it has to do with Postgres' timestamptz type which is represented internally as UTC and which only gets translated to/from the session timezone upon querying.
You might want to try a client like DBeaver where you can set the session timezone. Then run the above code while using different timezone settings.

It's on Europe/Madrid
show timezone;
'Europe/Madrid'

We can of course change that, but superset should behave correctly regardless since postgres will return the timezone with the data. Changing the database default timezone to UTC would be a workaround.

@john-bodley has a good PR here explaining many of the timezone intricacies of Superset. I hope it helps!

Closing this as stale since it's been silent for so long, and we're trying to steer toward a more actionable Issues backlog. If people are still encountering this in current versions (currently 3.x) please re-open this issue, open a new Issue with updated context, or raise a PR to address the problem. Thanks!


Code not working - no matter how i change the code it does not display the code 24/08/2023 as 24 Aug 2023

#import datetime
#store the value in a variable called currentDate
currentDate = datetime.date.today()
#print (currentDate)
#print (currentDate.year)
#print (currentDate.month)
#print(currentDate.strftime(%d %b, %Y)
#print(currentDate.strftime(%d %b, %y)
#("Please attend our event %A, %B %d in the year %Y"))
userInput = input('Please enter your birthday ')
birthday = datetime.datetime.strptime(userInput, '%m/%d/%Y')
print(birthday)

Hi @Venetia143, thanks for reporting this. Could you provide more detailed repro steps so that we can investigate it? What do you mean by "it doesn't display the code"? Thanks.

This seems like a Python issue, not something to do with Visual Studio. That said, you did try the correct approach, which would be:
print(currentDate.strftime("%d %b %Y"))

So the question is, what do you see when you use that approach? If you are not getting the right format, there may be something wrong with the locale you are using.


Allow using Armeria without epoll or io_uring JARs

Motivations:
Some users prefer reducing their distribution size or solving build
issues by excluding certain transitive dependencies. We could make
Armeria run even if netty-transport-native-epoll and
netty-incubator-transport-native-io_uring are missing in the class
path.
Modifications:

Moved the logic that refers to epoll/io_uring classes to
TransportTypeProvider and used dynamic class loading.
Moved the references to EpollChannelOption.EPOLL_MODE to
ChannelUtil and used dynamic class loading.
Added the methods which were previously missing in TransportType:

socketChannelType()
datagramChannelType()
isAvailable()
unavailabilityCause()

Deprecated the methods that merely delegates to TransportType in
EventLoopGroups.
Removed the workaround for WSL, since the problem has been fixed in
WSL2.
netty-incubator-transport-native-io_uring is not an optional dependency.
Miscellaneous:

Fixed a build issue where public_suffixes.txt file is deleted when
/tmp directory exists in a different file system.

Result:

Closes #3243
You can now run your Armeria application even if
netty-transport-native-epoll and
netty-incubator-transport-native-io_uring are not available in the
classpath, which is useful when you want to reduce the final
distribution size.
You can now check whether/why a certain transport type is unavailable
via Transport.isAvailable() and unavailabilityCause().
EventLoopGroups.*ChannelType() methods have been deprecated in favor
of the methods with same name in TransportType.
You can now use the epoll transport on WSL2.

Thanks for reviewing. :bow:

Thanks for reviewing. :bow:


Link_Redirection_Error:  Incorrect LinkedIn Redirect URL for Mrs. Mansi Prasad

Change the LinkedIn URL of Mrs.Mansi Prasads's Card to the correct one
Currently, it is redirecting to the signup page

Fixed by #2


Is there a ql dialect for gorp?

I was hoping to find an implementation of gorp.Dialect corresponding to the ql syntax. Does any such thing exist (perhaps in an external project?)

I am not aware of one.

Off topic but similar. I tried to use ql with gorm. And even my attempt to implement a ql dialect for gorm failed flat. The reason it was hard has more to do with the gorm design.
I am heavily refactoring gorm now, with the sole purpose to support ql. Then I can easily add the other dialects from gorm unchanged. The fork I'm working on has changed beyond recognition( in term of structure and design) but the gorm models  just works( with very minor modification).
There is a long way to Go. But The base is set, so I'm just adding more API slowly. Any Ideas or recommendation will be highly appreciated.
Links

guide
the repo
godoc

Shameless plug.
Since there is no, tools or showcase or libraries that uses ql section. I will drop this here, I belive it has value in this thread.
There is a fully fledged ORM that is a fork gorm. It fully supports ql, so you can do all what you can with postgres and ql the same i.e relationships etc.
I'm the author. Here is the link to the repo  https://github.com/ngorm/ngorm


Unable to get the history of purchases

Please use the Discussion board if you want to get some help. Please use issues to report bugs.

I'm trying to get the user's purchases with getPurchaseHistory() and getAvailablePurchases() to verify if the user has active subscription to send him to the main navigator of the app or to the subscription offers. The functions are returning an undefined value or an empty array.

Expected behavior
I need to get the history of purchases to validate if the date is expired or not. Using the version 10.0.6, I had successfully get the history using the methods described above.

Screenshots

Environment:

react-native-iap: 12.0.1
react-native: 0.66.4
Platforms (iOS, Android, emulator, simulator, device): iOS 15+

To Reproduce
Steps to reproduce the behavior:
I'm requesting the purchase using the examples provided from the lib:
const handleRequestSubscription = async () => {
    setLoading(true)
    if (selectedSubscription) {
      if (Platform.OS === 'ios') {
        try {
          await requestSubscription({
            sku: selectedSubscription?.productId,
          })
        } catch (error) {
          setLoading(false)
          if (error instanceof PurchaseError) {
            Alert.alert(
              'Error',
              'A error has occurred. Please check your payment configuration.',
            )
            console.log({ message: `[${error.code}]: ${error.message}`, error })
          } else {
            console.log({ message: 'handleBuySubscription', error })
          }
        }
      }
    }
  }

  useEffect(() => {
    const checkCurrentPurchase = async () => {
      try {
        if (currentPurchase?.productId) {
          await finishTransaction({
            purchase: currentPurchase,
            isConsumable: true,
          })

          setIsSubscribe(true)
        }
      } catch (error) {
        if (error instanceof PurchaseError) {
          Alert.alert(
            'Error',
            `message: [${error.code}]: ${error.message}, error`,
          )
        } else {
          Alert.alert('Error', `message: 'handleBuyProduct', ${error}`)
        }
      }
    }

    checkCurrentPurchase()
    // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [currentPurchase, finishTransaction])

But when I reload the app, I want to verify if this subscription is active using:
export const PurchaseHistory: React.FC = () => {
  const navigation = useNavigation()
  const { getAvailablePurchases, getPurchaseHistory } = useIAP()
  const { setIsSubscribe } = useSubscriptionContext()
  const [loading, setLoading] = useState(false)

  const handleGetPurchaseHistory = async () => {
    console.log('getPurchaseHistory', await getPurchaseHistory())
    console.log('getAvailablePurchases', await getAvailablePurchases())
  }

  useEffect(() => {
    const checkSubscribeActive = async () => {
      handleGetPurchaseHistory()
    }
    checkSubscribeActive()
  }, [])

  return <></>
}

My logs:

[Optional] Additional Context
I'm using setup({ storekitMode: 'STOREKIT2_MODE' })
I do not save the purchase information at my server-side.

@kayro2222 it looks like a bug that would happen when using hooks. Can you please try passing the following parameter to the method:
getAvailablePurchases({
alsoPublishToEventListener:true})

That should fix it while I come up with an actual fix

Since you are using Storekit 2. You can try await IapIosSk2.latestTransaction(sku)

it worked @andresesfm! thanks for your time.

hey @andresesfm, I'm receiving [Error: Can't find product for sku **my_sku**] using IapIosSk2.subscriptionStatus(skus.monthly) when I reload my app. At fast refresh, I'm able to get the subscriptions.

it seems that I need to use the context hook at the history too


Fix #7: Added Ktlint with spotless

Fixes #7
Will add GitHub checks once https://github.com/google/modernstorage/pull/9 is merged or current changes are approved

@nic0lette @yrezgui PTAL

I missed your PR @TangHuaiZhe my bad, it's covered in #20

I missed your PR @FareesHussain my bad, it's covered in #20

@yrezgui No prob, let me know if there is anything I can work on


docs(angular-query): add routing example

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (59c0d53) 41.82% compared to head (33c35f8) 41.82%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6873   +/-   ##
=======================================
  Coverage   41.82%   41.82%
=======================================
  Files         178      178
  Lines        7015     7015
  Branches     1416     1416
=======================================
  Hits         2934     2934
  Misses       3718     3718
  Partials      363      363

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


hal_i2c: Adding back in TWI 380kbps

380kbps was removed in commit d92e0127b8761cae2048c9eb8eb2cd5223bf9e84.
The bit fields for 380kbps (TWI and TWIM) got added back in in commit 53a34eb4344f47685e469f69f1a5e4ff2382ced2, but not the check in hal_i2c_init() and hal_i2c_config() .
The TWI bitfield got removed at some point after that.
Adding back in TWI bitfield, and hal_i2c check for 380kbps.

Hi justine, see #1867 -- can we please keep the changes isolated to hal_i2c.c, so we can avoid having a modified nrfx?


ROCm 5.0 indicates not supported for rx6800 XT GPU on Ubuntu 20.04

Installed ROCm 5.0 along with Radeon 21.50 drivers and getting error 'hipErrorNoBinaryForGpu: Unable to find code object for all current devices' when testing with Tensorflow.
Steps:

Removed all older gpu drivers and ROCm 4.5 from system & restarted.
Download installer script for AMD 21.50 drivers and ROCm 5.0 tools per guide: https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation_new.html
Ran amdgpu-install --usecase=graphics,rocm,hip
Installed rccl library: apt-get rccl
Added user to 'video' & 'render' groups
Set LD_LIBRARY_PATH=/opt/rocm/lib/:/opt/rocm/rocblas/lib/:/opt/rocm/rccl/lib/:/opt/rocm/hsa/lib/:/opt/rocm/hip/lib/:/opt/rocm/miopen/lib/:/opt/rocm/hipfft/lib/:/opt/rocm/rocrand/lib/

In python console, run:

import tensorflow as tf
sess = tf.compat.v1.Session()

Result:
2022-02-13 14:06:45.471445: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libamdhip64.so
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!"
See for reference:
https://github.com/RadeonOpenCompute/ROCm/issues/1617
I'm testing this on an older project using python 3.7 and Tensorflow 1.15.
See for reference: https://github.com/RadeonOpenCompute/ROCm/issues/1617

Did you use one of this releases; https://pypi.org/project/tensorflow-rocm/#history
There is no tensorflow 1.15 release after May,2021... so no release that can work with rocm 5.0
I don't think other release that 2.7.1 or 2.8.0 can work this day with last rocm.

Thanks for the update. I tested this new version of tensorflow-rocm and that seems to work. Very exciting!

Thanks @jasondrusso for reaching out.
TF1.15 is very old and it does not support with Navi21 cards. Navi21+the latest TF 2.7/2.8 works. Request to test the same.
Thank you.

Yes, I can verify that it works with Tensorflow as early as 2.3, using tensorflow-rocm 2.8 package.


need onPaused event on iOS platform.

In fullscreen mode, It's unable to pause video by pressing the built-in pause button.
Please fire onPause event, so that we have an opportunity to invoke "this.setState({paused: true});

@xing-zheng For the time being I just put an invisible button over the native one and control playback that way.

@shanealsingh Thank you!

The onPlaybackRateChange callback should give you what you need -- it'll return 1 if playback is ongoing and 0 otherwise. I'm using it for this and it seems to work.

closing due to suggestions made

Thanks @corbt it helps me.. for others, here is the example based on @corbt suggestion.
_onPlaybackRateChange = (event) => {
console.log("_onPlaybackRateChange : "+event.playbackRate)
};
<Video
source={{uri: "video.mp4"}}
onPlaybackRateChange={this._onPlaybackRateChange.bind(this)}
/>


ARROW-17837:  [C++][Acero] Create ExecPlan-owned QueryContext that will store a plan's shared data structures

Seems like the only failure is in the scanner (again probably caused by scanner refactor):
[ RUN      ] BasicNewScannerTests/TestScannerBase.ScanOrdered/3slow16f128b
[262](https://github.com/apache/arrow/actions/runs/3176942289/jobs/5176817702#step:11:263)
terminate called after throwing an instance of 'std::system_error'
[263](https://github.com/apache/arrow/actions/runs/3176942289/jobs/5176817702#step:11:264)
  what():  Resource temporarily unavailable
[264](https://github.com/apache/arrow/actions/runs/3176942289/jobs/5176817702#step:11:265)
terminate called recursively
[265](https://github.com/apache/arrow/actions/runs/3176942289/jobs/5176817702#step:11:266)

@save-buffer I had to make a few minor changes (hiding QueryContext from the public API).  Feel free to suggest alternative approaches in a future PR if you disagree.

@github-actions crossbow submit test-ubuntu-20.04-cpp-20

@save-buffer @westonpace It seems that this broke test-ubuntu-20.04-cpp-20. Could you confirm this?
https://github.com/ursacomputing/crossbow/actions/runs/3785729320/jobs/6436002570#step:5:2976
FAILED: src/arrow/CMakeFiles/arrow_objlib.dir/compute/exec/source_node.cc.o
/usr/local/bin/sccache /usr/bin/c++  -DARROW_EXPORTING -DARROW_HAVE_RUNTIME_AVX2 -DARROW_HAVE_RUNTIME_AVX512 -DARROW_HAVE_RUNTIME_BMI2 -DARROW_HAVE_RUNTIME_SSE4_2 -DARROW_HAVE_SSE4_2 -DARROW_HDFS -DARROW_MIMALLOC -DARROW_NO_DEPRECATED_API -DARROW_WITH_BACKTRACE -DARROW_WITH_BROTLI -DARROW_WITH_BZ2 -DARROW_WITH_LZ4 -DARROW_WITH_RE2 -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_UTF8PROC -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DBOOST_ALL_NO_LIB -DURI_STATIC_BUILD -Isrc -I/arrow/cpp/src -I/arrow/cpp/src/generated -isystem /arrow/cpp/thirdparty/flatbuffers/include -isystem /arrow/cpp/thirdparty/hadoop/include -isystem orc_ep-install/include -isystem protobuf_ep-install/include -isystem google_cloud_cpp_ep-install/include -isystem absl_ep-install/include -isystem crc32c_ep-install/include -isystem awssdk_ep-install/include -isystem opentelemetry_ep-install/include -isystem xsimd_ep/src/xsimd_ep-install/include -isystem jemalloc_ep-prefix/src -isystem mimalloc_ep/src/mimalloc_ep/include/mimalloc-2.0 -Wno-noexcept-type  -fdiagnostics-color=always -ggdb -O0  -Wall -Wno-conversion -Wno-sign-conversion -Wunused-result -Werror -fno-semantic-interposition -msse4.2  -g -fPIC   -pthread -std=c++2a -MD -MT src/arrow/CMakeFiles/arrow_objlib.dir/compute/exec/source_node.cc.o -MF src/arrow/CMakeFiles/arrow_objlib.dir/compute/exec/source_node.cc.o.d -o src/arrow/CMakeFiles/arrow_objlib.dir/compute/exec/source_node.cc.o -c /arrow/cpp/src/arrow/compute/exec/source_node.cc
In file included from /arrow/cpp/src/arrow/buffer.h:29,
                 from /arrow/cpp/src/arrow/array/data.h:26,
                 from /arrow/cpp/src/arrow/compute/exec.h:31,
                 from /arrow/cpp/src/arrow/compute/exec/source_node.cc:22:
/arrow/cpp/src/arrow/compute/exec/source_node.cc: In lambda function:
/arrow/cpp/src/arrow/compute/exec/source_node.cc:139:75: error: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Werror=deprecated]
  139 |                        RETURN_NOT_OK(plan_->query_context()->ScheduleTask([=]() {
      |                                                                           ^
/arrow/cpp/src/arrow/status.h:57:62: note: in definition of macro 'ARROW_RETURN_NOT_OK'
   57 |     ::arrow::Status __s = ::arrow::internal::GenericToStatus(status); \
      |                                                              ^~~~~~
/arrow/cpp/src/arrow/compute/exec/source_node.cc:139:24: note: in expansion of macro 'RETURN_NOT_OK'
  139 |                        RETURN_NOT_OK(plan_->query_context()->ScheduleTask([=]() {
      |                        ^~~~~~~~~~~~~
/arrow/cpp/src/arrow/compute/exec/source_node.cc:139:75: note: add explicit 'this' or '*this' capture
  139 |                        RETURN_NOT_OK(plan_->query_context()->ScheduleTask([=]() {
      |                                                                           ^
/arrow/cpp/src/arrow/status.h:57:62: note: in definition of macro 'ARROW_RETURN_NOT_OK'
   57 |     ::arrow::Status __s = ::arrow::internal::GenericToStatus(status); \
      |                                                              ^~~~~~
/arrow/cpp/src/arrow/compute/exec/source_node.cc:139:24: note: in expansion of macro 'RETURN_NOT_OK'
  139 |                        RETURN_NOT_OK(plan_->query_context()->ScheduleTask([=]() {
      |                        ^~~~~~~~~~~~~
cc1plus: all warnings being treated as errors


Promote suggested widgets and put building blocks as a regular section in the end of the UI elements list for everyone.

It addresses a friction point from the usability tests: https://www.notion.so/appsmith/Once-they-delete-something-from-the-building-block-the-block-is-useless-822109b8ba154d88a4e53d25445196ba?pvs=4

While we don't have the configuration interface for blocks, we should make them available as we have other regular widgets, but we shouldn't promote them for new users, since they are not able to easily modify them.
Remove the building blocks empty state that is creating confusion.
Turn on the feature to 100%

Move it down at bottom of explorer pane.


FCM Sdk 4.2.3 crashes in runtime with AndroidX migrated project

Hi guys. I've updated leanplum SDK to 4.2.3, which forced me to migrate the project to AndroidX. After that migration app crashes trying to access any of SDK classes.
Expected Behavior
SDK doesn't crash
Actual Behavior
java.lang.VerifyError: Rejecting class com.osemenov.myapplication.FCMJavaService that attempts to sub-type erroneous class com.leanplum.LeanplumPushFirebaseMessagingService (declaration of 'com.osemenov.myapplication.FCMJavaService' appears in /data/app/com.osemenov.myapplication-erh9XnEEZy84ccbuEww1oQ==/base.apk)
        at com.osemenov.myapplication.FCMJavaService.test(FCMJavaService.java:7)
        at com.osemenov.myapplication.MainActivity.onCreate(MainActivity.java:11)

Steps to Reproduce the Problem

Migrate project to AndroidX
Add leanplum-fcm SDK 4.2.3
Access any SDK class at runtime
See demo project - just compile it and launch MainActivity
https://github.com/SemenovAlexander/LeanplumAndroidXBug

Specifications

Version: 4.2.3
Platform: Android 9.0

Guys, any updates here? #333 is basically the same issue

@SemenovAlexander Which version are you having problems with?  I see 4.3.2 in the title and then 4.2.3 in the body.

@lolsheeplol it is 4.2.3, sorry about that

This is a known issue in version 4.3.0. This issue was resolved in 4.3.1
We had some issues with deploying 4.2.3 and it's possible that you might have a dirty cache.
Please could you update to 4.3.1 or above and see if that resolves the issue?


SLES install instructions

File: ee/ucp/admin/install/index.md
As per: https://github.com/docker/orca/issues/10899
special instructions are needed for SLES installs as well.

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


Badges for different platforms (PS5, Switch, etc)

Platform badges: Steam, PS5, Xbox Series, Epic Games Store, GOG, itch.io
Optional Fun Badges: Old consoles (such as the Wii, NES, Sega Saturn, Nintendo 64, PS2, Nintendo DS, etc)

added


Getting ready to Qt 6 (3/n). Do not use QKeyEvent copy constructor

This PR is preparation for Qt 6, and it fixes an experimental build with Qt 6.2.4 as copying of QEvent has been disabled in Qt 6.0.0.

Updated d543515e635786214215e5b30a2874c4e8a676dc -> 8691a444add29d62dade34bf2965cf76a5d6c863 (pr580.01 -> pr580.02, diff):

addressed @shaavan's comment

Why are we creating a new event instead of forwarding the original one on? Seems like this PR would simply be bypassing the behaviour Qt is trying to prevent...

Why are we creating a new event instead of forwarding the original one on? Seems like this PR would simply be bypassing the behaviour Qt is trying to prevent...

QCoreApplication::postEvent:

The event must be allocated on the heap since the post event queue will take ownership of the event and delete it once it has been posted. It is not safe to access the event after it has been posted.

"forwarding the original one on" ends with double deletion of an QKeyEvent instance.

Hmm, how about using https://doc.qt.io/qt-5/qcoreapplication.html#sendEvent ?

Updated 8691a444add29d62dade34bf2965cf76a5d6c863 -> 3ec6504a2e5b4afb7a2719a82191e0b96fe23214 (pr580.02 -> pr580.03, diff):

addressed @luke-jr's comment


Offline development

In the absence of network environment, there are many exceptions. All DLLs in normal operation are introduced, and XAML load is still wrong exception:no precompiled xaml found ....
It is suggested to give an example and guide for the development of offline network-free environment

You need to have all of the required packages in your local nuget cache (either local in %USERPROFILE%.nuget or on designated nuget cache server). Other than that there are no network requirements.

@kekekeks I set up a local nuget server, but found that all downloaded Avalonia libraries and dependent libraries can't be uploaded. Other libraries can. An error of 406 (not acceptable) is reported. What is the reason?

An error of 406 (not acceptable) is reported. What is the reason?

That depends entirely on your nuget server. We are using Sonatype Nexus and it accepts libraries without any issues.
There was, however, a fix for [Content_Types].xml generation that landed in 0.9.11, might be worth a try.

ok, thanks.


Create GitHub Actions deployment

I suggested that all branches could deploy to QA and we just get the most recently updated one, so that you can easily squash-merge changes when finished.
Show the commit ID on the website so we can easily find the exact corresponding source for the version we're using.

Now on develop, commit ID/Tags are also displaying on the website now
Not yet on production, awaiting any revision needs


Fixing scientific notation

In the case the data received for a point is with the form 120.564e-005, there is no more an issue.

Would you mind writing a test for both cases and removing the commented code?
@sadortun comments?

There is a few cases that require testing.
Please add a few tests, and also a test case that validate the following cases that doesn't currently have the right behaviour.
Integer, string, integer :
12345e-5 Should match, but will fail.
Float, any string, int
123.45test-5 will match and should fail

I've created another pull request with the tests.