Attempt upgrading all dependencies

Added

Changes specifier in CHANGELOG.md
Version specifier in VERSION
Node version specifier in .nvmrc to allow compatibility
Simple shell script to invoke the bindings generator in generate-bindings.sh
Simple shell script to invoke the build process in one step in build-rayjs.sh

Changed

Upgraded raylib to 9a8d73e
Upgraded raygui to 82ba2b1
Upgraded quickjs to 6a89d7c
Generated new bindings
Upgraded all packages of the bindings generator

Removed

Removed the need of transpilation when using the bindings generator (this is useful to debug generator issues as ts-node can represent errors as they are, without the need of source maps)
Removed webpack requirement

Fixed

Markdown linting errors

Wow, thats a big one! Thanks a lot - I will take some time to review it but on first glance all of these changes seem very reasonable to me. I'll report back ASAP.

Take your time, I know open source endeavors are though, you don't need to accept it, even if you get some inspiration it is still good.
I've tried to upgrade all deps to today's last commits, added the CHANGELOG.md and VERSION formality so that other projects depending on yours don't break, but you will have to connect them to tagging and the github actions CI you have in place.
I also started another one here https://github.com/iongion/raylib-quickjsx - it is basically the same as your repo, but it has some considerable philosophical changes.

I use a fork of quickjs that also ads JSX support, it is from the creator of sciter-js which is amazing, but I can't use it for my case as it is not covered
Basically I need to add non-main thread opengl graphics to a video processing pipeline that runs on gstreamer, this simple task has proven extremely difficult to achieve. Drawing on video and then re-streaming in a cross-mobile/desktop way is madness.
RayJS is a perfect graphic engine for cross-platform opengl graphics, but writing c++ to show simple logos and animations on videos is too static and time consuming, hence the need for JS, JS just as an api layer is still sad, but allows faster prototype. JS with JSX and RmlUi is excellent, basically a react developer would feel at home if there would be a DOM-like thingy at his hands.
Taking further, adding RmlUi is just this, it is a CSS+HTML like tehnology to build UIs
Now, if one would want animations, lottie is the format to go and luckily there is rlottie from Samsung that is somehow achievable in RmlUi
Same as for basic SVG support

Task I am exploring now is integrating RmlUi in raylib with a custom or a default OpenGL renderer and then also exposing it using quickjs.
I could have taken the lua path, which is great for bindings, but I can't develop everything, and JS world has animation/tweening libraries that are pretty advanced and optimized, plus so many other things that can be adapted to quickjs.
I don't want to duplicate work with yours, but I don't know how comfortable you are for merging this with RmlUi + rlottie and lunasvg, especially with the JSX fork of quickjs.
Always opened for anything.

Hey @iongion, again, thanks a lot for your support here. I finally had time to check this out. I tried to update everything locally and build and it worked. However I made a copy of your branch and ran it through the pipeline it succeeded for mac but failed for windows and linux (guess which platform I'm on). It seems this is different problems. On Windows it seems like an unsupported define in quickjs while on Linux it's some wayland dependencies from raylib. I think both can be fixed but it will take some more time. If you want to investigate yourself here's the pipeline. Let me know if you have trouble accessing it: https://github.com/mode777/rayjs/actions/runs/8408950341
Regarding your plans, thats quite an interesting project. Thanks for pointing out RmIUi, looks like it would be the perfect match for quickjs. For rayjs, its probably not so helpful as it's meant as a standalone runtime for raylib with javascript on top. It was never meant to integrate into anything.


JSON Parse gives a strange warning and causes GitHub Super Linter to fail and can't be skipped

Back from vacation we see that the ARM-TTK linter is not working fine in our Super Linter execution.
After running the ARM-TTK locally we see this strange warning for one of our templates:
VERBOSE: Conversion from JSON failed with error: After parsing a value an unexpected character was encountered: o. Path 'variables.kvtAccessPoliciesArray', line 118, position 97.
After some debugging we see that line 118 is not the issue but this one:
'''
"mergeKvtAccessPoliciesCondition": "[not(contains(string(parameters('kvtAccessPolicies')),concat('"objectId":"',parameters('kvtObjectId'),'"')))]",
'''
Very strange because the json is valid otherwise the deployment of our template would fail. So as a work-arround we tried to skip the "JSONFiles Should Be Valid" check but this is imposible. :(
This is our JSON file

{
  "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
  "contentVersion": "<IP_ADDRESS>",
  "parameters": {
    "kvtName": {
      "type": "string",
      "metadata": {
        "description": "Name of the new Keyvault"
      }
    },
    "kvtSkuName": {
      "type": "string",
      "defaultValue": "Standard",
      "allowedValues": [
        "Standard",
        "Premium"
      ],
      "metadata": {
        "description": "SKU for the vault"
      }
    },
    "kvtEnabledForDeployment": {
      "type": "bool",
      "defaultValue": false,
      "metadata": {
        "description": "Set TRUE to enable access for deployments"
      }
    },
    "kvtEnabledForTemplateDeployment": {
      "type": "bool",
      "defaultValue": false,
      "metadata": {
        "description": "Set TRUE to enable access for Template deployments"
      }
    },
    "kvtEnabledForDiskEncryption": {
      "type": "bool",
      "defaultValue": false,
      "metadata": {
        "description": "Set TRUE to enable access for disk encryption"
      }
    },
    "kvtObjectId": {
      "type": "string",
      "defaultValue": "",
      "metadata": {
        "description": "ObjectId of Pipeline account"
      }
    },
    "kvtNetworkAclsBypass": {
      "type": "string",
      "defaultValue": "None",
      "allowedValues": [
        "None",
        "AzureServices"
      ],
      "metadata": {
        "description": "Tells what traffic can bypass the network rules"
      }
    },
    "kvtAccessPolicies": {
      "type": "array",
      "defaultValue": [],
      "metadata": {
        "description": "Access policies defined for the new vault"
      }
    },
    "kvtIpRules": {
      "type": "array",
      "defaultValue": [],
      "metadata": {
        "description": "An array with IPRule objects"
      }
    },
    "kvtVirtualNetworkRules": {
      "type": "array",
      "defaultValue": [],
      "metadata": {
        "description": "An array with VirtualNetworkRule objects"
      }
    },
    "location": {
      "type": "string",
      "defaultValue": "[resourceGroup().location]",
      "metadata": {
        "description": "Location of the resource deployment"
      }
    }
  },
  "variables": {
    "kvtDefaultAccessPolicies": [
      {
        "tenantId": "[subscription().tenantId]",
        "objectId": "[parameters('kvtObjectId')]",
        "permissions": {
          "keys": [
            "Backup",
            "Create",
            "Delete",
            "Get",
            "Import",
            "List",
            "Restore",
            "Update",
            "Recover"
          ],
          "secrets": [
            "All"
          ],
          "certificates": [
            "All"
          ]
        }
      }
    ],
    "kvtDefaultAccessPoliciesArray": "[if(empty(parameters('kvtObjectId')),json('[]'),variables('kvtDefaultAccessPolicies'))]",
    "mergeKvtAccessPoliciesCondition": "[not(contains(string(parameters('kvtAccessPolicies')),concat('\"objectId\":\"',parameters('kvtObjectId'),'\"')))]",
    "kvtAccessPoliciesArray": "[if(variables('mergeKvtAccessPoliciesCondition'),union(variables('kvtDefaultAccessPoliciesArray'),parameters('kvtAccessPolicies')),parameters('kvtAccessPolicies'))]",
    "azureServicesBypassCondition": "[or(or(parameters('kvtEnabledForDeployment'),parameters('kvtEnabledForTemplateDeployment')),parameters('kvtEnabledForDiskEncryption'))]",
    "kvtNetworkAclsCondition": "[not(and(empty(parameters('kvtIpRules')),empty(parameters('kvtVirtualNetworkRules'))))]"
  },
  "resources": [
    {
      "name": "[parameters('kvtName')]",
      "type": "Microsoft.KeyVault/vaults",
      "apiVersion": "2021-04-01-preview",
      "location": "[parameters('location')]",
      "properties": {
        "accessPolicies": "[if(empty(parameters('kvtAccessPolicies')),variables('kvtDefaultAccessPoliciesArray'),variables('kvtAccessPoliciesArray'))]",
        "enabledForDeployment": "[parameters('kvtEnabledForDeployment')]",
        "enabledForDiskEncryption": "[parameters('kvtEnabledForDiskEncryption')]",
        "enabledForTemplateDeployment": "[parameters('kvtEnabledForTemplateDeployment')]",
        "enableSoftDelete": true,
        "sku": {
          "name": "[parameters('kvtSkuName')]",
          "family": "A"
        },
        "tenantId": "[subscription().tenantId]",
        "networkAcls": {
          "bypass": "[if(variables('azureServicesBypassCondition'),'AzureServices',parameters('kvtNetworkAclsBypass'))]",
          "defaultAction": "[if(variables('kvtNetworkAclsCondition'),'Deny','Allow')]",
          "ipRules": "[parameters('kvtIpRules')]",
          "virtualNetworkRules": "[parameters('kvtVirtualNetworkRules')]"
        }
      }
    }
  ],
  "outputs": {
    "kvtName": {
      "type": "string",
      "value": "[parameters('kvtName')]"
    },
    "kvtResourceId": {
      "type": "string",
      "value": "[resourceId('Microsoft.KeyVault/vaults', parameters('kvtName'))]"
    },
    "kvtUri": {
      "type": "string",
      "value": "[reference(parameters('kvtName')).VaultUri]"
    },
    "vaults": {
      "type": "array",
      "value": [
        {
          "Name": "[parameters('kvtName')]",
          "ResourceId": "[resourceId('Microsoft.KeyVault/vaults', parameters('kvtName'))]",
          "Uri": "[reference(parameters('kvtName')).VaultUri]"
        }
      ]
    }
  }
}

This is what we get running arm-ttk locally with verbose

VERBOSE: Conversion from JSON failed with error: After parsing a value an unexpected character was encountered: o. Path 'variables.kvtAccessPoliciesArray', line 118, position 97.

Validating templates\azuredeploy.json
AllFiles
    [+] JSONFiles Should Be Valid (28 ms)
deploymentTemplate
    [+] adminUsername Should Not Be A Literal (14 ms)
    [+] apiVersions Should Be Recent In Reference Functions (11 ms)
    [+] apiVersions Should Be Recent (14 ms)
    [+] artifacts parameter (11 ms)
    [+] CommandToExecute Must Use ProtectedSettings For Secrets (27 ms)
    [+] DependsOn Best Practices (10 ms)
    [+] Deployment Resources Must Not Be Debug (10 ms)
    [+] DeploymentTemplate Must Not Contain Hardcoded Uri (7 ms)
    [+] DeploymentTemplate Schema Is Correct (6 ms)
    [+] Dynamic Variable References Should Not Use Concat (6 ms)
    [+] IDs Should Be Derived From ResourceIDs (12 ms)
    [+] Location Should Not Be Hardcoded (7 ms)
    [+] ManagedIdentityExtension must not be used (5 ms)
    [+] Min And Max Value Are Numbers (6 ms)
    [+] Outputs Must Not Contain Secrets (7 ms)
    [+] Parameters Must Be Referenced (19 ms)
    [+] providers apiVersions Is Not Permitted (8 ms)
    [+] ResourceIds should not contain (7 ms)
    [+] Resources Should Have Location (7 ms)
    [+] Resources Should Not Be Ambiguous (6 ms)
    [+] Secure Params In Nested Deployments (12 ms)
    [+] Secure String Parameters Cannot Have Default (7 ms)
    [+] Template Should Not Contain Blanks (9 ms)
    [+] Variables Must Be Referenced (16 ms)
    [+] Virtual Machines Should Not Be Preview (27 ms)
    [+] VM Images Should Use Latest Version (7 ms)
    [+] VM Size Should Be A Parameter (9 ms)
Validating templates\azuredeploy.parameters.json
  deploymentParameters
    [+] DeploymentParameters Should Have ContentVersion (9 ms)
    [+] DeploymentParameters Should Have Parameters (8 ms)
    [+] DeploymentParameters Should Have Schema (10 ms)
    [+] DeploymentParameters Should Have Value (6 ms)
Total : 32
Fail  : 0
Pass  : 32

Trying to skip the JSONFiles Should Be Valid

C:\arm-ttk\Test-AzTemplate -TemplatePath C:\Users\gjspoelstra\Repos\Catalog\Catalog\Keyvault\templates\azuredeploy.json  -verbose -skip 'JSONFiles Should Be Valid'

VERBOSE: Conversion from JSON failed with error: After parsing a value an unexpected character was encountered: o. Path 'variables.kvtAccessPoliciesArray', line 118, position 97.

@StephenMolloy we have updated the PR with some additional fixes, please retry and let us know.

Sorry @StartAutomating it still does not fix this issue :(

I'm not able to repro after #488 in https://github.com/Azure/arm-ttk/releases/tag/20210818

@bmoore-msft did you run it with the verbose option?

C:\Users\gjspoelstra\Downloads\arm-template-toolkit\arm-ttk> Test-AzTemplate -TemplatePath C:\Users\gjspoelstra\Repos\Catalog\Catalog\Keyvault\templates\azuredeploy.json -verbose

VERBOSE: Conversion from JSON failed with error: After parsing a value an unexpected character was encountered: o. Path 'variables.kvtAccessPoliciesArray', line 118, position 97.

Validating templates\azuredeploy.json
   AllFiles
      [+] JSONFiles Should Be Valid (7 ms)
   deploymentTemplate
      [+] adminUsername Should Not Be A Literal (10 ms)
      [+] apiVersions Should Be Recent In Reference Functions (8 ms)
      [+] apiVersions Should Be Recent (10 ms)
      [+] artifacts parameter (5 ms)
      [+] CommandToExecute Must Use ProtectedSettings For Secrets (21 ms)
      [+] DependsOn Best Practices (8 ms)
      [+] Deployment Resources Must Not Be Debug (9 ms)
      [+] DeploymentTemplate Must Not Contain Hardcoded Uri (6 ms)
      [+] DeploymentTemplate Schema Is Correct (5 ms)
      [+] Dynamic Variable References Should Not Use Concat (5 ms)
      [+] IDs Should Be Derived From ResourceIDs (10 ms)
      [+] Location Should Not Be Hardcoded (6 ms)
      [+] ManagedIdentityExtension must not be used (5 ms)
      [+] Min And Max Value Are Numbers (7 ms)
      [+] Outputs Must Not Contain Secrets (6 ms)
      [+] Parameters Must Be Referenced (19 ms)
      [+] providers apiVersions Is Not Permitted (8 ms)
      [+] ResourceIds should not contain (6 ms)
      [+] Resources Should Have Location (5 ms)
      [+] Resources Should Not Be Ambiguous (6 ms)
      [+] Secure Params In Nested Deployments (8 ms)
      [+] Secure String Parameters Cannot Have Default (7 ms)
      [+] Template Should Not Contain Blanks (6 ms)
      [+] Variables Must Be Referenced (10 ms)
      [+] Virtual Machines Should Not Be Preview (21 ms)
      [+] VM Images Should Use Latest Version (7 ms)
      [+] VM Size Should Be A Parameter (7 ms)
Validating templates\azuredeploy.parameters.json
   deploymentParameters
      [+] DeploymentParameters Should Have ContentVersion (5 ms)
      [+] DeploymentParameters Should Have Parameters (5 ms)
      [+] DeploymentParameters Should Have Schema (5 ms)
      [+] DeploymentParameters Should Have Value (6 ms)
Total : 32
Pass  : 32
Fail  : 0

I did not use the -verbose option... thanks for clarifying (again ;))

No problem 😉 thanks for reopening the issue

this is related to variable expansion which is not in use yet... could change it to write-debug short term but need to make sure we get to root cause before consuming var expansion

we changed this to a write-debug instead (that's really what that case was meant for) - hopefully that doesn't make super linter think failure... (in 2021.08.23

@bmoore-msft it is still letting the super linter fail :(

Do you know which version the super linter is using?  (or do you see DEBUG: instead of VERBOSE:?)  If it's failing on write-debug (which seems as odd as failing on write-verbose so certainly possible) then we'll need another option (obviously)
@StartAutomating fyi

The super linter always uses the latest arm-ttk release from GitHub.

Is there any update on this?

@spoelly - I'm not seeing this reproduce with what is currently in master (including with -Verbose (tried on PowerShell core and Windows PowerShell).  Can you verify it is ongoing?

Upon further investigation, it appears we were not escaping double quotes correctly.


Bug: ryuk exited instances leaking

Describe the bug
With the new ryuk container usage in v4.1.1, dependent containers get cleaned up nicely, but the ryuk container itself remains, in exited state. The ryuk container itself should also be cleaned up.
docker ps --all will show a great many of these containers, see the very end of the bug report for some testcontainers-based pytest integration test that was running in a loop.
While docker rm -f $(docker ps --all --quiet --filter="name=testcontainers-ryuk*") will clean this up, it is still annoying to have to manage this.
To Reproduce
Any usage of testcontainers should exhibit this behaviour.
Locally, I am running this with a specialized Dockercontainer implementation which drives the official Apache Kafka 3.7.0 container image in KRaft mode (which obviates the need for Zookeeper dancing and hence cycles much much faster).
Runtime environment
Provide a summary of your runtime environment. Which operating system, python version, and docker version are you using? What is the version of testcontainers-python you are using? You can run the following commands to get the relevant information.

There is one oddity, though: Ctrl+C does not abort the tests. To reproduce

pytest (just a simple one, no need for the infinite loop)
run a test suite which uses (my) Kafka container
Ctrl+C

//exp: test run aborts
//act: test run stops (with ryuk + Kafka container gone) and appears to hang dead
Right now I do not know how to minimally reproduce this, what the root cause of that is, and whether this is a regression - it may simply be due to timeouts that are too high (ryuk, my container).
I believe that the current state is strictly better than the previous state, so I'd suggest proceeding with the current state for now.

@shoffmeister - after a day of experimenting i realized that the shutdown hooks are not necessary - and actually just how necessary the ryuk is in practice. im releasing 4.2.0 right now with only the necessary parts of the above fix, and not the unnecessary ones. thanks for reporting and helping to test!


[Question] How to center text

So was wondering how could i center the text i have ontop that has aimbot, esp etc
https://i.imgur.com/1UlCtgq.jpg

auto screenSize = interfaces.surface->getScreenSize();
float screenCenterX = screenSize.first / 2;
float screenCenterY = screenSize.second / 2;

auto text = "Aimbot"; auto windowCenter = ImGui::GetWindowSize().x / 2; auto textCenterX = ImGui::CalcTextSize(text).x / 2; ImGui::SetCursorPosX(windowCenter - textCenterX);


CUDA Error, too many resources requested for launch

I think there are something needs to be fixed on working set size. I use a Window 10 machine with a NVIDIA Quadro 4000 and CUDA 8.0.
When I tried to train a set with more features, I got following errors. The data set "a9a"used here is from LibSVM site:https://www.csie.ntu.edu.tw/~cjlin/libsvmtools/datasets/binary.html
PS O:\thundersvm\thundersvm\build\bin\Release> ./thundersvm-train -g 0.125 -c 10 a9a.txt svm.model
2018-05-09 14:06:59,499 INFO [default] loading dataset from file "a9a.txt"
2018-05-09 14:07:00,168 INFO [default] #instances = 32561, #features = 123
2018-05-09 14:07:00,171 INFO [default] training C-SVC
2018-05-09 14:07:00,174 INFO [default] C = 10
2018-05-09 14:07:00,176 INFO [default] gamma = 0.125
2018-05-09 14:07:00,228 INFO [default] #classes = 2
2018-05-09 14:07:00,347 INFO [default] working set size = 1024
2018-05-09 14:07:00,374 INFO [default] training start
2018-05-09 14:07:00,773 FATAL [default] Check failed: [error == cudaSuccess]  too many resources requested for launch
2018-05-09 14:07:00,778 WARNING [default] Aborting application. Reason: Fatal log at [O:/thundersvm/thundersvm/src/thundersvm/kernel/smo_kernel.cu:309]

Would you use the -m option, say "-m 1500" (i.e., using ~1.5GB memory as your GPU has only 2GB memory), to set the memory usage for ThunderSVM?
We will investigate and improve the code to address this issue. Thanks!

same error with "-m 1500" or "-m 1000"

I've added a new branch called dev-old-gpu. Please checkout the code and see if it solves your issue.
We can't reproduce your issue, as we don't have  Quadro 4000 GPUs which are relatively old...


Datepicker  - Changed behaviour when setting value

=====
Still an issue in 2.2.0
Bug description:
I get a date value as string from a remote server (database).
Therefore I use a directive with to convert the string to a dateobject and set it with $setViewValue.
This works fine until bootstrap version 1.3.3
Since version 2.0.0 the input field validation fails for a field which has been set this way ($invalid is true).
This totally breaks UI-Logic as the user opens a records and the form is showing that previously entered fields are all invalid
Link to minimally-working plunker that reproduces the issue:
https://plnkr.co/edit/pKCUSTsf6mfn2OEnMb4A
Version of Angular, UIBS, and Bootstrap
Angular: 1.5.5
UIBS: 2.1.1
Bootstrap: 3.3.6

Please don't open duplicate issues - there is an adequate resolution as mentioned in the prior issue if you read my responses. I even outlined the approach one could take before binding data to the controller.


bug: iOS cookies not setting back rest api call

I am developing one application using Ionic 4 with angular.
When user Login into application, Middle layer setting token into browser cookies I am sending back using below code::
const httpOptions = {
  headers: new HttpHeaders({
    'Content-Type': 'application/json',
    'charset': 'UTF-8',
    'Access-Control-Allow-Origin': '*'
  }),
  **withCredentials: true**
};

it is working fine, in Web Application and android and Safari Also.
But when iOS, I am not able send back to token through resp api call, but when I will enable web Authentication if it is working fine.
Could you please help me any one.

could you someone help me to fix this issue.

@jgw96  could you please help me this issue, thanks in advance !!

@sneko did you get any solution ??


Update Databricks 10.4 for changes to the QueryStageExec and ClusteredDistribution [databricks]

fixes https://github.com/NVIDIA/spark-rapids/issues/5154
Looks like 2 different changes.

pulled in https://issues.apache.org/jira/browse/SPARK-38237 which was changed in spark 3.3 back. These changes are in our Spark 3.3 shim so it was just copying them back to 321db.
adds an extra parameter to *QueryStageExec called isSparkExchange.

I had to copy some files around to make it 321db specific.

build

markdown failures are because we pushed docs changes to official 22.04 jars but they haven't been published yet so can ignore those failures


Host Profile

This branch allows to profile both device and host energy consumption through the PowerCap interface.

Code Description
The Host Profiler code is implemented in the file host_profiler.hpp. The code reads the file of the PowerCap interface to retrieve the consumed energy in microjoules.
In order to enable host profiling, a host_device_profiler is implemented in the profilers.hpp file. The behaviour is similar to the already implemented device_profiler.
A compiler flag SYNERGY_HOST_PROFILE enables the profiling of the host if the SYNERGY_DEVICE_PROFILE is already set on.
The profiler also takes into account if SYnergy is running on a NUMA or other multi-cpu architectures, by measuring the energy consumed by all the core and uncore packages.
Issues

It's unknown if the path of the energy register file can change according to the architecture: what happens if we are running SYnergy on a cluster?
It's not possible to isolate only the desired application; the energy calculated is the energy consumed by the CPU during the execution time of the device.
It works only with linux systems since the register file is specific for every linux kernel.


SpeakButtonRenderer class already exist

SpeakButtonRenderer class already exist in the start project and no chnage is required to the exisiting class, though in the documentation it tells to create the new class.

I probably would've fixed this earlier. I don't see it anymore. Reopen with specific doc info if you find it again.


Bug fixes for RunONNXModel.py

This PR addresses some minor bugs in RunONNXModel.py:

The option --verify-all-ops did not work in my use case because the intermediate tensors that were added to the models as outputs had no type associated to them which caused onnx-mlir to reject the model when trying to compile it
The option --load-so did not work in combination with --verify onnxruntime did not work because the modified onnx model was not saved to the temporary directory

Can one of the admins verify this patch?

Can one of the admins verify this patch?

@jenkins-droid test this please

Can one of the admins verify this patch?

@jenkins-droid test this please

Jenkins Linux ppc64le Build #7438 [push] Bug fixes for RunONNXMod... started at 02:18

Jenkins Linux s390x Build #8387 [push] Bug fixes for RunONNXMod... started at 02:17

Jenkins Linux amd64 Build #8371 [push] Bug fixes for RunONNXMod... started at 01:17

Jenkins Linux amd64 Build #8371 [push] Bug fixes for RunONNXMod... passed after 1 hr 25 min

Jenkins Linux ppc64le Build #7438 [push] Bug fixes for RunONNXMod... passed after 1 hr 41 min

Jenkins Linux s390x Build #8387 [push] Bug fixes for RunONNXMod... passed after 1 hr 52 min


VAST ads don't play on video loop

Is this behavior by design? Currently, I have a 2 minute test video with a preroll and midroll vast tag. They play on the first playthrough, but don't when the video loops.

This is an issue with the current version as referenced on the fluid player website (which seems to be 3.0.4?), but has been fixed in source release tags. Current solution for me is to build off the latest tag.


Empty upstream definition leads to nginx-proxy failing to start/restart

When a new container is launched with the VIRTUAL_HOST environment setting but not in a network accessible by nginx-proxy, docker-gen creates a configuration file that is not valid (an empty upstream entry), given that the container's network is not known to nginx-proxy.
When this happens, nginx responds gracefully to the nginx -s reload by not honouring it and keeping the last valid configuration, but it will fail to start if the nginx-proxy container is restarted until the offending container is stopped.
This means that in situations where nginx-proxy is serving as a frontend for several containers, a single broken/misconfigured container can bring the whole setup down.

I had the same issue, please try this networks config:
https://github.com/jwilder/nginx-proxy/issues/1015#issuecomment-354435127


Logging in from januslinjeforening.no does not work

Describe the bug
The IdPorten/Feide connection is refused when the hostname is januslinjeforening.no, so one can only log in from indokntnu.no.
To Reproduce
Steps to reproduce the behavior:

Go to januslinjefornening.no
Press the log in button in the top right
See the connection refused-thingy-thing

Expected behavior
I should have been taken to the Feide login page.
Desktop (please complete the following information):

OS: MacOS
Browser Chrome
Version Unknown

Additional context
Add any other context about the problem here.

This was a larger problem when there was a link to it. Now this problem is too niche for us to fix as it is almost impossible to find by accident.


Feature/fix docker compose dependency

Fix the docker-compose dependencies
The  containers need dependency so that they are started with their dependencies in mind. Ignoring docker-compose.yml from eslint

Docker compose now has dependencies
docker-compose config should no longer present eslint errors

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce
the testing if necessary.
Before PR's can be merged they will need to be tested by QA and approved where
applicable. To flag the change to QA assign @XGovFormBuilder/qa as one of the reviewers.

[x] Run docker-compose locally and checked the containers are starting correctly
[x] No eslint errors pre-comit from docker-compose

Checklist:

[x] My changes do not introduce any new linting errors
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation and versioning
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have rebased onto master and there are no code conflicts
[x] I have checked deployments are working in all environments
[x] I have updated the architecture diagrams as per Contribute.md

Main branch seems to be broken at the moment. So we should check master first before we proceed


Problems with ldap-record

I am working on a project that uses ldap-record for auth. That is presenting some problems with this package sadly.
https://github.com/discoverydesign/filament-gaze/blob/main/src/Forms/Components/GazeBanner.php#L186
Here it uses the LdapModel which means on line 194 it searches on ldap, instead of the database.
A suggestion would be to allow us to set the class to use in either a config file or when instantiating the plugin
Let me know if you would want me to make a PR :)

Hey @sinnbeck
I've refactored things a little and it should resolve the issue :)
Give 1.1.5 a go and let me know if you have any issues.

Awesome. I'll give it a try as soon as possible!


How to set flash size

I'm currently trying to change the flash size from 2 MB to 8 MB as I am getting the following warning:
W (269) spi_flash: Detected size(8192k) larger than the size in the binary image header(2048k). Using the size in the binary image header.

However I am unsure how to do this properly. Changing the flash size in the sdkconfig does not work either.

Flash size in the binary image header is managed by esptool.py or espflash, not by esp-idf-sys.


Update UI of Btech Tea shop website

The landing page is way too broken, alignments are not up to mark, there is no animation and images are not added. I want to update the css and make it look way more attractive and I also want to make the website interactive and user friendly.
Please assign me this issue under GSSOC'23.

hey @yaswika0311  I would like to work on this issue.Please assign me this issue

I also want to work on this issue under GSSOC' 23

I also want to work on this issue under GSSOC' 23

i want to work on this , Assign this to me


Support late block re-orging

Description
To discourage the late publication of blocks, implement support for late block re-orging: https://github.com/ethereum/consensus-specs/pull/3034

This has now been merged, so we can now get on with implementing it.

Don't forget to re-enable related reference tests (disabled here: #7695)


Preprocessor errors are hidden

Why call preprocessor in a separate process?
If it fails, the standard error remains invisible, stdout returns an empty string and svelte compiler produces an empty component, which just doesn't work and very hard to understand why

I see that most likely subprocess is used for a hacked 'deasync' of svelte.preprocess() call...
Isn't there a better way supported by jest?
Anyway, I would suggest adding '--unhandled-rejections=strict' to child node.
And FYI: the problem I was debugging ended up being a problem with node installed with snap package in Ubuntu: https://github.com/nodejs/node/issues/33456
So this approach can have undesired side-problems that are really hard to debug...

Hey @angryziber, ye I know it's a shitty hack to make it work but async transformations are currently not supported by Jest. When I was building this transformer I tried a bunch of different approaches but they all had some cost, and this was the most stable work around I could get going.
The good news is that async transformations are being worked on now (https://github.com/facebook/jest/pull/9889) but seems to be still a little early to tell when it'll be done.
Thanks for the suggestion on --unhandled-rejections=strict, I'll add it in.

Okay done it's released in 1.0.6, and I'll immediately switch over to async transforms once they're ready.

@mihar-22 thanks

I was getting the error node: bad option: --unhandled-rejections=strict, so I'll note it here in case anyone is googling that message.
Node 10.16.3 is still pretty widespread---this flag was only introduced recently in 10.17.0.


last version of plugin supporting Zabbix 3.4

I found info about new version of plugin not supporting zabbix 3.4:
Ah, sorry, just noticed you're using Zabbix 3.4. It's not supported anymore, so either upgrade Zabbix or roll back to previous plugin version.
Originally posted by @alexanderzobnin in https://github.com/alexanderzobnin/grafana-zabbix/issues/976#issuecomment-639320087
What is the newest version of plugin supporting zabbix 3.4 and what is the newest version of grafana which works with that version of plugin? I tried plugin's version 3.X but it's look like is not working with grafana 8.4

Hi! Regarding to change log, it looks like 3.11.0 is the last version that works with Zabbix 3.x

Use Grafana 6.x (6.7, probably) for compatibility.


NTLM fails on Ubuntu 22.04 with OpenSSL 3.0

It seems like OpenSSL 3.0 (at least on Ubuntu) retired md4.
# openssl md4
Error setting digest
4037123E367F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:../crypto/evp/evp_fetch.c:349:Global default library context, Algorithm (MD4 : 88), Properties ()
4037123E367F0000:error:03000086:digital envelope routines:evp_md_init_internal:initialization error:../crypto/evp/digest.c:237:

authentication fails with unknown GSS error: https://github.com/dotnet/runtime/issues/67353
Perhaps gss-ntlm should have fall-back implementation instead of depending on OpenSSL.

dup of https://github.com/gssapi/gss-ntlmssp/issues/71.

Ah yeah, in openssl 3.0 the legacy provider is not enabled by default, thus MD4 may not work.
I have a way to re-enable MD4 only for specific operations, but that will also eventually fail once some distrinution decides to completeluy get rid of legacy algorithms, but will carry us there until then.
@wfurt Is this urgent for you to resolve ?

Note that in the short term a workaround is to change the openssl 3.0 configuration (system-wide) to enable the "legacy" provider.

it seems like we are minutes apart with @filipnavara - closing and opening at the same tome from different continents :)

I will check if installing legacy openssl and forcing to use it would fix the problem @simo5. if that works I think that can be workaround for some time for anybody who urgently needs to jump on new OS version.

Working on this here: #72
Is there a way to run check on 22.04 on github? my actions conf has ubuntu:latest but all i get is 20.04

@omajid annoying, but I guess will test the 3.0 code once github updates the images.
MEanwhile I tested locally on rawhide and #72 seem to work w/o issues
@wfurt can you test if PR #72 solves the problem for you w/o configureing openssl for legacy provider?

@simo5 I can't get Fedora containers to work, but you can see Ubuntu tests failing using this action: https://github.com/omajid/gss-ntlmssp/blob/ci-actions-containers/.github/workflows/ccpp.yml. Result: https://github.com/omajid/gss-ntlmssp/actions/runs/2073611521

If you can help me work around  configure: error: GSSAPI library does not support gss_import_cred on Fedora, I can clean it up and do a PR.

What version of Fedora?
As long as you have krb5-devel installed all should work fine

Fedora 35. See the configure section at https://github.com/omajid/gss-ntlmssp/runs/5778418850?check_suite_focus=true:
checking for krb5-config... /usr/bin/krb5-config
checking for gss_import_cred in -lgssapi_krb5... no
configure: error: GSSAPI library does not support gss_import_cred

krb5-devel is installed earlier:
 krb5-devel                             x86_64  1.19.2-2.fc35              fedora   140 k

you need these packages installed to build:
BuildRequires: autoconf
BuildRequires: automake
BuildRequires: libtool
BuildRequires: m4
BuildRequires: libxslt
BuildRequires: libxml2
BuildRequires: docbook-style-xsl
BuildRequires: doxygen
BuildRequires: gettext-devel
BuildRequires: pkgconfig
BuildRequires: krb5-devel >= 1.11.2
BuildRequires: libunistring-devel
BuildRequires: openssl-devel
BuildRequires: pkgconfig(wbclient)
BuildRequires: zlib-devel
BuildRequires: make
wbclient is actually optional, but it is easy to install via libwbclient-devel

Yup, I grabbed all the dependencies from the Fedora 35 spec file too. Still doesn't seem to work.
dnf install -y autoconf automake docbook-style-xsl doxygen gettext-devel krb5-devel libtool libunistring-devel libxml2 libxslt m4 make openssl-devel pkgconfig 'pkgconfig(wbclient)' zlib-devel

Something fishy here gss_import_cred is supported since ages

I tested this morning on rawhide (F37) installed from scratch (container image) and worked just fine.
It should work just fin in f35 too though

Uhm I had missed installing libtool, all seem to be working fine now even after autoreconf

This should be fixed in main now, please reopen or a file a new one in case of more issues


Is there a way  to get the  trees  Feature important  ?

yes, you can read the model files, which indicate the feature importance.


Doesn't seem to be working under 2020 LTS

As the title states, the plugin doesn't seem to work for me using unity 2020.  No errors seemingly, but no matter what settings i change, it just displays a transparent ui element.

https://unionassets.com/unity-ui-extensions. Try downloading the complete package from here, worked for me.


builder is incapable of loading modules defined without '.js' extension

When I have this in index.js (an entry point)
import {AbstractClassError} from './errors.js';
import {SomeFile}                from './somefile';
import {SomePlugin}            from './someplugin.js';

export {AbstractClassError, SomeFile, SomePlugin};

then builder throws exception:
Trace: [Error: ENOENT, open 'j:\oddy\workspace\github\proj\src\main\javascript\com\lorem\ipsum\somefile'
	Error loading file:///j:/oddy/workspace/github/proj/src/main/javascript/com/lorem/ipsum/somefile from file:///j:/oddy/workspace/github/proj/src/main/javascript/com/lorem/ipsum/index.js
	Error loading file:///j:/oddy/workspace/github/proj/src/main/javascript/com/lorem/ipsum/somefile]

When I define an extension to somefile, then the error is gone.
It is acceptable to have modules without extensions.
No other builders/transpilers/IDEs have issues in recognizing modules without extension in this list:

webpack (builder)
traceur (transpiler)
babel (transpiler)
browserify  (builder)
Intellij IDEA (IDE)

There are three ways of handling this in SystemJS:

Have a map or paths configuration  - System.config({ map: { jquery: 'path/to/jquery.js' } })
Use the legacy compatibility mode for automatically adding extensions - System.config({ defaultJSExtensions: true })
Configure the default extension rule for a package created at that location - https://github.com/systemjs/systemjs/blob/master/docs/config-api.md#packages

The ES6 browser loader spec stopped the rule of automatically appending extensions. So this is the way things are going now.

In terms of best-practices the thing to do is:

Leave out extensions for packages (import 'jquery' etc)
Include extensions for any paths (import './file.js')
Subpaths of packages are still a somewhat grey area though (import 'jquery/subpath' or import 'jquery/subpath.js could both be considered viable, depending on the configuration in play)

Why things are like that in system.js? According to the spec in mdn, it is not the best practice.
Module identified does not have to have extensions. Examples in spec don't use extensions either.
Having/not having extensions occasionally does not contribute to consistency. Why is it recommended approach then?

The recommended approach is exactly as I described in the previous comment. The module loader specification changed from having module ids without js extensions to making them expected.

Basically the reasoning was to make module ids as close to URLs as possible, and to make moduleIds compatible with URLs. Since URLs are already the primary specifier of the web, having a system that contains URLs as a subset is much more useful and makes sense to more users.

I have a related issue and would like to get your feedback @guybedford
After upgrading jspm to the latest version I am facing issues with regard to importing html files in my ES6 classes. Everything was working fine in the older release and the line of code:
import ProviderGalleryTemplate from './provider-gallery.tpl';

was working as expected and importing the provider-gallery.tpl.html file but now it does not work. I have put defaultJSExtensions to true in system.config.js file. How can I make system to recognize the extension for the html pages which I am importing in js files.


Using framegrabber to record a live stream

Hi,
I'm currently using the library to play a live RTSP stream.
I see there's a frame grabber, but is there also a way to write an RTSP stream to a file?
What I tried now is the following:

Create a new file
Use Framegrabber to get the current frame (await frameGrabber.ExtractVideoFrameAsync(mediaPlayer.PlaybackSession.Position);) // This doesn't work well because it gives sometimes an older frame
Use the grabbed file and encode as jpeg
Repeat this loop

Once the user decide to stop recording

Loop through all the saved frames
Create a mediaclip for every frame
Save the MediaComposition to disk

The problem is on point 2 and also on some devices with less good hardware because of all the file access it doesn't work.
Is there another way?

Hi.
This seems to be the average MediaTransoder API usage for our library. We have some limited support for that, basically you can use this method
https://learn.microsoft.com/en-us/uwp/api/windows.media.transcoding.mediatranscoder.preparemediastreamsourcetranscodeasync?view=winrt-22621#windows-media-transcoding-mediatranscoder-preparemediastreamsourcetranscodeasync(windows-media-core-imediasource-windows-storage-streams-irandomaccessstream-windows-media-mediaproperties-mediaencodingprofile)
Together with the Mediastreamsource object we expose from the FfmpegMediaSource. This limits you to the WinRT output formats and not the full range of formats supported by FFmpeg. I think this will also skip subtitles if there's any.
Unfortunately we currently don't have a dedicated transcoder API and I have no ETA when that would be available. There are some technical and legal issues that stand out. We are mainly a decoder library.

Thank you for your help. The problem with that approach is that I can't use that exposed MediaStreamSource.
The TranscodeAsync throws an exception because I can't have more than one listener on that generator.
We are also displaying the video via an Mediaplayer.
_decoder = await FFmpegMediaSource.CreateFromUriAsync(RtspUrl, configuration);
_mediaPlaybackItem = _decoder.CreateMediaPlaybackItem();

_mediaPlayer = new MediaPlayer();
_mediaPlayer.Source = _mediaPlaybackItem;

var source = _decoder.GetMediaStreamSource();
var filename = GetVideoFileName();
var storageFolder = await StorageFolder.GetFolderFromPathAsync(path);
var destinationFile =
    await storageFolder.CreateFileAsync(filename, CreationCollisionOption.ReplaceExisting);
var destination = await destinationFile.OpenAsync(FileAccessMode.ReadWrite);

try
{
    var transcode = await _mediaTranscoder.PrepareMediaStreamSourceTranscodeAsync(source, destination, MediaEncodingProfile.CreateMp4(VideoEncodingQuality.Auto));
    await transcode.TranscodeAsync();
}
catch (Exception exception)
{
//
}

I'd have 2 suggestions here:

You create 2 different FFmpegMediaSource, one for transcoding, one for rendering. (this would be the best approach)
You use the MediaPlayer frame server mode to get every raw frame and feed it into a transcoder (never tried this with the MediaTranscoder)

The frame grabber is not designed to provide such high performance to be able to accurately reconstruct a stream. That's not what its purpose is.

Our lib does not support simultaneous playback and recording/transcoding. I also don't think that the frame server mode will help you, since it only gives you video frames, but no audio, and there is no sync mechanism as well.
So your only option would be to create two connections, one for playback and one for recoding. That's not optimal and it could cause bandwidth problems on slower connections. But I don't know of any other way.

Closing this, since the scenario is just not supported by our lib.


Adding Types to documentation and Typescript Example

Linked issue: https://github.com/react-navigation/react-navigation.github.io/issues/751
Basically I think Typescript example are really not much different from JS version, just some special case when we need to explicitly set the type. I'm thinking to add the types info to the documentation, similar to React native website's style

My plan is to first go through the navigators and add the type info, then look at some example to see if any of them need a dedicated typescript version

Hey @jarvisluong, what is the status of this? can you what Satya suggested and close this one, please?


feature Retry txn conflict error at meta service proxy

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


[MetricsAdvisor] Added tests for the AnomalyDetectionConfiguration CRUD operations

Fixes https://github.com/azure/azure-sdk-for-net/issues/15915.
Tests ended up very large because we're testing a complex model. It takes multiple lines for setup and some more for validation.

LGTM. It will be good if someone with full understanding of the service (from other language?) will check as I am not super confident with all configurations

Just added others as reviewers in case they want to contribute. I'll keep it open for more time.


Upgrade to Typescript 4.9.5 and set as peerDependency of generated package

What does this change?
Typescript doesn't follow semantic versioning (https://github.com/microsoft/TypeScript/issues/39269). This means that there could be breaking changes in caret (^) ranges.
This change:

upgrades to Typescript 4.9.5 for building the typescript files
adds Typescript ~4.9.5 as a peerDependency of the generated npm package
adds a scroogeTypescriptPeerDependencies setting to enable plugin users to add peer dependencies to the package.json
fixes a mismatched type in the decode-encode module

Warning
I think this should be released as a major version bump

How to test
sbt test

@georgeblahblah just to let you know, I've rebased this PR on top of #31 (to add CI) and #30 (to allow publishing a preview release that can be tried out on a consumer of the scrooge-extras library).
As you can see in the comment above, this PR fixes the tests and CI passes!

@rtyley thanks for the heads up! This PR has some knock-on effects to consumers and I'm still not 100% sure those effects are desirable. I've raised #32 which will fix tests in this repository instead.


CGNN

Hey man, thanks for this, looking forward to exploring. Just a quick question regarding and error, do you know what is causing this.

Hi,
Yes, the thing is that we haven't (still) updated the notebook since '0.2' , sorry !
I'll try to fix this notebook as soon as possible !
Best,

Hi again,
Sorry for the delay, it should be working great now !
Best,
Diviyan

Thanks Diviyan, looking forward to playing around.

From: Diviyan Kalainathan<EMAIL_ADDRESS>Sent: 09 May 2018 22:28
To: Diviyan-Kalainathan/CausalDiscoveryToolbox
Cc: firmai; Author
Subject: Re: [Diviyan-Kalainathan/CausalDiscoveryToolbox] CGNN (#6)
Hi again,
Sorry for the delay, it should be working great now !
Best,
Diviyan
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDiviyan-Kalainathan%2FCausalDiscoveryToolbox%2Fissues%2F6%23issuecomment-387695596&data=02|01||6bebd7b8afc34fbcb5c608d5b597a46f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636614585258123457&sdata=%2FqKBS7pO80woBAYcGV0pXw22HtGCPj4u6rIOEeQs65M%3D&reserved=0, or mute the threadhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAZblG4O8EETNaGothDeVt289KLXjcPfaks5twsTcgaJpZM4TzJFR&data=02|01||6bebd7b8afc34fbcb5c608d5b597a46f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636614585258123457&sdata=qqySYMEOgI1bnqfm%2FuWMAkM0ECpMnlORLRyqEWbPJko%3D&reserved=0.


test-branch/execute-job/wrong-commit-sha-on-pr/ddafd338-cdc5-41b5-a116-71c16ccb95c3

PR for testing 9ce2651cecf75464ee11f53ee7bdfd28afb06d5c

/canonical/self-hosted-runners/run-workflows a556329d0f19affa608643d746ee6f7c818c627b


NPC ranged attacks: support ammunition drawdown for tokens

We usually store the number of available projectiles in attributes specific to each type, i.e. Arrows and Bolts. For NPCs whose individual tokens differ in ammunition state but who use the same character sheet, using these ammunition attributes will result in 20 generic Orcs drawing down the same storage of arrows and bolts, rather than having each their own. After one round, the central quiver of 20 arrows will be empty.
One imperfect but probably practical solution would be to assume that every generic NPC token can only have a single type of ranged weapon, with a single type of projectile. If that is so, we could use the token attribute bar1, currently unused or used to display the token's constant range of movement (B), to store the number of projectiles and manage drawdown in a way that would have the added advantage of being constantly visible to at least the GM (visibility does seem to be configurable separately for each token bar).

Reopened the discussion in the party and found that our GM would rather keep using bar1 for movement. Closing.


KAFKA-14808: fix leaderless partition issue when controller removes u…

…nneeded replicas
If there is ongoing partition reassignment and any adding replica has been elected as leader (due to preferred leader election or other reason), the partition will immediately becomes leaderless when controller removes unneeded replicas on receiving a new partition reassignment which removes that adding replica.
Reject the new reassignment in such scenario to avoid leaderless partitions.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@junrao I couldn't find your comment. It's lost somehow. :)

@junrao I have updated the code. Would you like to have a look? Thanks.

@junrao do you have cycles to review this?


chore: enable compression in swc

Merging with https://github.com/privatenumber/minification-benchmarks/pull/26


HL-545: allow handlers to access terms in django admin

Description :sparkles:
Handlers need (rarely) to be able to edit the terms of service and applicant terms in the django admin.
Use a shortcut in ModelAdmin so that permissions don't need to be assigned for every new handler.
Issues :bug: HL-545
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #1015 (ae4b3d6) into develop (4b7d658) will increase coverage by 31.82%.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##           develop    #1015       +/-   ##
============================================
+ Coverage    63.59%   95.41%   +31.82%
============================================
  Files          865      182      -683
  Lines        24019     7960    -16059
  Branches      2372        0     -2372
============================================
- Hits         15274     7595     -7679
+ Misses        8350      365     -7985
+ Partials       395        0      -395

Impacted Files
Coverage Δ

backend/benefit/terms/admin.py
84.31% <42.85%> (-15.69%)
:arrow_down:

backend/shared/shared/azure_adfs/views.py
40.00% <0.00%> (-44.00%)
:arrow_down:

backend/shared/shared/common/tests/__init__.py
66.66% <0.00%> (-33.34%)
:arrow_down:

backend/shared/shared/common/tests/conftest.py
86.95% <0.00%> (-13.05%)
:arrow_down:

backend/shared/shared/audit_log/audit_logging.py
87.23% <0.00%> (-12.77%)
:arrow_down:

backend/shared/shared/oidc/auth.py
81.48% <0.00%> (-5.56%)
:arrow_down:

frontend/tet/admin/src/store/PreviewContext.tsx

...ponents/editor/previewWrapper/PreviewWrapper.sc.ts

...components/applicationHeader/ApplicationHeader.tsx

backend/kesaseteli/common/decorators.py

... and 679 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b7d658...ae4b3d6. Read the comment docs.


Fix python lexer parsing floats incorrectly

This PR fixes the issue discussed in issue #1740. We've also added some test cases to specifically test the python lexer against floats and integers. Let us know if there's any changes that need to be made.
The issue was that numbers were parsed after operators. This just required rearranging the order in which the tokens are processed.

Merged, thanks!

Duplicate of ...?

Sorry my mistake.. I don’t know what’s wrong


Config issue

Hello! Great work.
Just trying to follow the instruction but run into many troubles.

The following instructions seems to be very similar

# instruction
Download the trained model here and unpack it in $EXPER_PATH/saved_models/.

Required assets
Download and unpack the HF-Net weights in $EXPER_PATH/hfnet/.

After I download the hfnet from the link (https://projects.asl.ethz.ch/datasets/doku.php?id=cvpr2019hfnet) and unpack it, I only get saved_models folder. It seems like 'unpack the HF-Net weights in $EXPER_PATH/hfnet/' is unclear to me.

Follow up question

# Running the command
python3 hfnet/export_predictions.py \
    'hfnet/configs/hfnet_export_aachen_db.yaml' \
    'superpoint/aachen' \
    --exper_name hfnet \
    --keys keypoints,scores,local_descriptor_map[,global_descriptor]
# Error
hfnet/export_predictions.py:30: YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated, as the default Loader is unsafe. Please read https://msg.pyyaml.org/load for full details.
  config = yaml.load(f)
Traceback (most recent call last):
  File "hfnet/export_predictions.py", line 42, in <module>
    with open(Path(EXPER_PATH, exper_name, 'config.yaml'), 'r') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'experiments/hfnet/config.yaml'

https://github.com/ethz-asl/hfnet/blob/master/hfnet/export_predictions.py#L42
with open(Path(EXPER_PATH, exper_name, 'config.yml'), 'r') as f:

It seems like there is no 'config.yml' anywhere.
So I try to find the similar file which is under the folder (https://github.com/ethz-asl/hfnet/tree/master/hfnet/configs) and I can find many '.yaml' files.
However, it is still unclear which one should I adopt in each circumstances.
Thank you

Disclaimer: I'm not the author but got things working

$EXPER_PATH is a path you defined through setup.sh. For example, my $EXPER_PATH is /home/ubuntu/dev/HFNet/experiment/, then save the unpacked saved_models folder in $EXPER_PATH so it will looks like /home/ubuntu/dev/HFNet/experiment/saved_models/hfnet/saved_model.pb and /home/ubuntu/dev/HFNet/experiment/saved_models/hfnet/variables/

Depending whether you want to evaluate using NetVLAD + Superooint or HFNet. For example, if my global method is NetVLAD, then when I generate global descriptor, I will want to use config fire with netvlad_export_[dataset_name].yaml. If I want to use Superpoint as local matching descriptor, when I generate local descriptor, I will want to use superpoint_export_[dataset_name]_[db, query].yaml

Hi @shamangary, thank you for your interest!

This is clearly a mistake from my side, hfnet_tf.tar.gz should have also contained a directory hfnet/ with the products of the training: weights (before export to a saved model), configuration (this config.yaml), logs, and Tensorboard summaries.

export_predictions.py is looking for the trained weights, which were indeed missing. There was also a typo in the extension of the config file, I just fixed this in https://github.com/ethz-asl/hfnet/pull/9.

I updated the tarball, let me know if that works for you.
@hwjwill Thanks for helping out :)

Thank you. It seems like it's working now. :dancer:

sorry to ask  another simple question,  what is the difference between the hfnet folder  and the saved_models folder, I checked the demo.py is actually using the saved_models

actually what I want to do is to export an hfnet model with all possible outputs like local_descriptors , global_descriptors, keypoints,   how can I modify the config.yaml for it.


[DOC] updated reference for Residual Normalised Score

Description
Changed the reference for the residual normalized score from
[1] Angelopoulos, A. N., & Bates, S. (2021). A gentle introduction to conformal
prediction and distribution-free uncertainty quantification. arXiv preprint arXiv:2107.07511.

to
[1] Lei, J., G'Sell, M., Rinaldo, A., Tibshirani, R. J., & Wasserman, L. (2017). Distribution-Free
Predictive Inference For Regression. arXiv:1604.04173.

Fixes #366
Type of change
This is a simple documentation update.
How Has This Been Tested?
This has been tested according to the items of the checklist below.
Checklist

[x] I have read the contributing guidelines
[x] I have updated the HISTORY.rst and AUTHORS.rst files
[x] Linting passes successfully : make lint
[x] Typing passes successfully : make type-check
[x] Unit tests pass successfully : make tests
[x] Coverage is 100% : make coverage
[x] Documentation builds successfully : make doc

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (614293e) 100.00% compared to head (3f8f3f7) 100.00%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #380    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           39        39
  Lines         4616      4618     +2
  Branches       487       730   +243
==========================================
+ Hits          4616      4618     +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Sure :)
I added the following bullet point in HISTORY.rst:
* Fix reference for residual normalised score in documentation

@vincentblot28 thanks a lot for approving the changes !
I'm sorry for asking but, since I still am quite unfamiliar with MAPIE's merging policy, I'm unsure about whether PRs should be merged by contributors or owners.
Let me know if you need any addition action from me :)

@mehdi-elion, your PR is ready, you can merge it ! Thank you for taking in charge this issue

Awesome! Unfortunately I fear that don't have write access / merging rights (yet ?) to MAPIE's repository.
Are you observing that on your side as well @vincentblot28 ? If so, would it be possible to grant me with sufficient rights to merge the PR :) ?
(If not, I apologize for the misunderstanding, this is my 1st contribution to MAPIE)

Awesome! Unfortunately I fear that don't have write access / merging rights (yet ?) to MAPIE's repository. Are you observing that on your side as well @vincentblot28 ? If so, would it be possible to grant me with sufficient rights to merge the PR :) ? (If not, I apologize for the misunderstanding, this is my 1st contribution to MAPIE)

Don't worry :) do you see the green "Merge pull request" button below this comment? If so, you have the right to finish the pull request. If not, no problem, I'll merge the pull request for you straight away.

@thibaultcordier I actually can't see the green "Merge pull request" button at the end of this thread ^^' Here's a screenshot of what I see (just in case). It looks like I'll have to rely on you to have it merged :)

No problem, I'll merge your pull request. Sorry for the wait and thanks again :)


[Forwardport] Remove old versions from vsphere-charts

Forwardport for https://github.com/rancher/rancher/issues/46146

This already went into https://github.com/rancher/charts/tree/dev-v2.10 as PRs for https://github.com/rancher/rancher/issues/46146 went in dev-v2.9 before dev-v2.10 branch was cut. So moving to "Ready for QA".

Ticket #46439 - Test Results - ✅
Verified on Rancher v2.10.0-alpha5:
expected versioning seen for vsphere CPI/CSI images in rancher-images.txt for v2.10.0-alpha5
CPI images packaged now reflect the following:

rancher/mirrored-cloud-provider-vsphere-cpi-release-manager:v1.27.0
rancher/mirrored-cloud-provider-vsphere-cpi-release-manager:v1.28.0
rancher/mirrored-cloud-provider-vsphere-cpi-release-manager:v1.29.0
rancher/mirrored-cloud-provider-vsphere-cpi-release-manager:v1.30.1

CSI images packaged now reflect the following:

rancher/mirrored-cloud-provider-vsphere-csi-release-driver:v3.2.0
rancher/mirrored-cloud-provider-vsphere-csi-release-driver:v3.3.0
rancher/mirrored-cloud-provider-vsphere-csi-release-driver:v3.3.1
rancher/mirrored-cloud-provider-vsphere-csi-release-syncer:v3.2.0
rancher/mirrored-cloud-provider-vsphere-csi-release-syncer:v3.3.0
rancher/mirrored-cloud-provider-vsphere-csi-release-syncer:v3.3.1


Doesn't appear to work with React-Native 58

This is possibly related to this:
https://github.com/fram-x/FluidTransitions/issues/160

Thanks for the comment, @TheTimeWalker, closing this for now.


Twitter integration discussion

Creating this to discuss current Twitter happenings, and what that could mean for sign-in and other functionality. Specific items of concern:

can't view links to tweets without being signed in
potential for rate limiting, inability to read tweets

Yeah I've been thinking about how to best move forward.
For the website I've already changed embeds to use Mastodon. This works for basically 99% of all submissions.
In terms of submissions I've pushed for people submitting on Twitter to use the website instead for submissions.
I'll need to do one more pass through the code base but I'm pretty sure doesn't depend on Twitter at all anymore and I could submit and accept everything on Mastodon if need be.

I don't understand. I haven't skimmed through the updates in a while. Are you talking about getting submissions off of Twitter entirely, instead of integrating?

At the time, Twitter (now X) blocked non-signed-in users from seeing tweets. Signed in users were only able to read a set ceiling amount of tweets per day.

TL;DR: If there is interest in fixing "Sign in with Twitter" functionality on the website please let me know here and I'll ask on the Twitter developer forums to get my account reviewed.
If a large majority of reports came in through the website directly rather than Twitter than yes I would prefer to not post on Twitter.
Currently I manually post every post to Twitter before using the admin panel to post to all other socials (Mastodon and Bluesky). This is because my Twitter application has been suspended since about April. It had been randomly suspended in the past but after a few days it would get automatically unsuspended. I assume this was due to a glitch on Twitter's end. The April suspension hasn't been lifted yet. I have followed what limited guidance there is on Twitter's developer pages but it seems like the only way forward is to request on the Twitter community forums for a Twitter staff member to review your account and lift the suspension. I cannot contact support directly to open a case with them because Twitter has removed a way for devs to open support cases directly. I haven't asked on the forums yet because according to posts from other devs their accounts are still getting randomly suspended again, even after getting fixed by Twitter support. I really do not feel like asking on the forums, continually checking and pinging the support account, to hope to get un-suspended only to get re-suspended in the future because of bugs on Twitter's end.
The workflow of uploading manually to Twitter and then using the admin page to post to other socials works adequately. It is much slower than just pressing upload and I have to be on desktop in order to upload, but it does work. The one upside is that now that Threads (my account here) has desktop support I could also start manually posting to Threads without much more additional friction. It would require code changes to store Threads links in the DB but that would be a very quick change.
Unfortunately because of the Twitter application being suspended "Sign in with Twitter" on the website was broken. I removed the option from the website on 2023-08-05 (https://github.com/golf1052/SeattleCarsInBikeLanes/commit/833d90e5c7a43d0dbb64a6f479588819efdaaf97). People that post reports or send me reports directly on Twitter can still be properly attributed through the DB and on other socials. It's just that the website no longer supports logging in with Twitter to attribute submissions to your Twitter account. People can attribute themselves using Mastodon on the website.
If there is interest in fixing "Sign in with Twitter" functionality on the website please let me know here and I'll ask on the Twitter developer forums to get my account reviewed. If not I'll close this issue in the next few weeks.


Best way to pass dependencies to other functions?

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
.

Description
If I have a situation like below I will get an error because you can't use Depends() with non-route functions it seems. Specifically, I will get an error saying AttributeError: 'Depends' object has no attribute 'exec'
def get_session():
    with Session(engine) as session:
        yield session

def some_other_func(*, session: Session = Depends(get_session)):
    users = session.exec(select(User))
    print("doing some other func thing")

@router.post("/demo")
def demo(*, session: Session = Depends(get_session)):
    some_other_func()
    return {"demo": "success"}

If instead, I try to pass the session object from one function to another as an argument, FastAPI will also complain. Specifically, it says TypeError: 'ModelMetaclass' object is not iterable
def get_session():
    with Session(engine) as session:
        yield session

def some_other_func(session: Session):
    users = session.exec(select(User))
    print("doing some other func thing")

@router.post("/demo")
def demo(*, session: Session = Depends(get_session)):
    some_other_func(session)
    return {"demo": "success"}

What's the best way of giving a non-route function access to the database session? If someone could also explain why non-route functions are able to make use of Depends in the security tutorial I'd be very grateful
Operating System
macOS
Operating System Details
No response
FastAPI Version
0.79.0
Python Version
3.10.3
Additional Context
No response

FastAPI performs its magic only when a function paramater with a default value as an instance of Depends is called in the context of a request. You can chain them, and FastAPI will resolve them recursivly. The resolvement of all Depends instances does not happen in the Depends class itself, but happens from the outside when FastAPI determines what parameters are expected or which functions must be executed when a request hits a certain endpoint.
So to answer your first question, the best way to provide a 'normal' function with a variable that is originally injected through a Depends() parameter is indeed like you have:
@router.post("/demo")
def demo(*, session: Session = Depends(get_session)):
    some_other_func(session)
    return {"demo": "success"}

To answer your second question (why does this work in the security tutorial): all functions that use Depends() are depending on each other. You can 'chain' functions that use Depends() as their parameters and FastAPI will resolve them all in the context of a request.

Thank you. This did help clarify my thinking and I've solved the issue


e2fsprogs 1.45.2 transient failures

Describe the bug
Since we have e2fsprogs version 1.45.2 I've noticed transient failures of certain tests when building e2fsprogs.
https://hydra.nixos.org/build/97065990
Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: e2fsprogs
# a list of nixos modules affected by the problem
module:

we now have 1.45.3 in staging-next.

failures with 1.45.3: m_image_mmp m_mmp m_mmp_bad_csum m_mmp_bad_magic t_mmp_1on t_mmp_2off

@vcunat what do you think, disable the tests?

Probably, disable these individual tests.  It would be nice to know a bit more about these failures and/or work with upstream, but I currently won't have capacity for that.
Apparently it was not an immediate blocker so far (it seemed like one restart typically worked around that), but I do believe we should resolve it somehow within a couple staging-next iterations.

It seems to fail consistently on zfs for me, but work if I mount a tmpfs to /tmp.

Tests are now disabled in master.

Sorry, but the line 23 here says tests are enabled:
https://github.com/NixOS/nixpkgs/blob/a69a6c11176d6aa96ab7c8f7308be4b95206598e/pkgs/tools/filesystems/e2fsprogs/default.nix#L53

I disabled only the failing tests, see the postPatch.

I could have been clearer in my earlier comment ;-)

I tried to update the system today and it is still failing:
d_fallocate_bigalloc: fallocate sparse files and big files with bigalloc: ok
Creating test_script...
349 tests succeeded     1 tests failed
Tests failed: m_hugefile
make[1]: *** [Makefile:396: test_post] Error 1
make[1]: Leaving directory '/build/e2fsprogs-1.45.3/tests'
make: *** [Makefile:420: check-recursive] Error 1
builder for '/nix/store/xvjgrwscnjmv6kglchy0ph1ws68x0c2l-e2fsprogs-1.45.3.drv' failed with exit code 2
cannot build derivation '/nix/store/q0f7m00hc269w7vksri6b8anrcr3fd0x-libarchive-3.4.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/fdxdfxspxdzr0lbms3wcgigapmrqawy4-cmake-3.15.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5lphgzwxch2a85xj1w9k7xbr2yfxxz7n-aws-sdk-cpp-1.7.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vapypxs4hb81frl2p1clzri19hwl7l9d-brotli-1.0.7.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/acr7w1m1anm35dmi1awzgfzjcz1sqbab-nix-2.3.drv': 1 dependencies couldn't be built
error: build of '/nix/store/acr7w1m1anm35dmi1awzgfzjcz1sqbab-nix-2.3.drv' failed

m_hugefile isn't in the removed set

Well, it is a possibility. My /tmp dir is an EXT2 filesystem.

So, I've just had it too. My /tmp dir was F2FS on one machine, TMPFS (over BTRFS) on another, then I loop mounted an EXT4 file onto the former and tried it again and now it works fine.

The MMP feature requires that the underlying storage device (e.g., the block device, or a file if you are using an image) that supports O_DIRECT.  So for the MMP tests, it requires that /tmp is either tmpfs (for which we have a special case to skip the test) or it must be a file system which supports O_DIRECT.  ext2 and btrfs doesn't support O_DIRECT.

Can we reenable the tests and only enable the ones with the particular requirements, or run them in a VM to ensure the right filesystem for them to work?

@lheckemann: I assume you got confused by the post saying

Tests are now disabled in master.

as the commit 151f52bf96a only disabled the problematic (mmp) tests.

Additionally running the excluded tests separately inside a VM – that sounds possible (we do NixOS VM tests already), but it would seem an overkill to me.


Example doesn't work

The example on packages/markerclustererplus/examples/advanced_example.html don't work anymore. I always get the error "uncaught ReferenceError: MarkerClusterer is not defined".
Has the example not been updated along with the code? Is this planned in the near future?

How did you run them? I 've just tested and it works.
I used this commands:
npm i
cd ./packages/markerclustererplus
npm run prepare
npx http-server ./docs

@jtgn let me know if you are still having issues. The examples are now rendered on master and can be found linked in https://googlemaps.github.io/v3-utility-library/modules/_google_markerclustererplus.html or in the readme of the package.

Thanks to both of you @jpoehnelt and @thekip.  Both hints helped a lot!


Add custom window background/clear color (incl. transparency) support, fixes #272

wgpu would currently ignore the alpha: https://github.com/gfx-rs/wgpu/issues/687
glow (and naively patched wgpu) requires premultiplied alpha, so if you don't multiply the RGB by the A right now, the semi-transparent color would be wrong (too bright).
winit with_transparent doesn't seem necessary — on wayland at least.

for testing:
--- i/examples/counter/src/main.rs
+++ w/examples/counter/src/main.rs
@@ -1,7 +1,12 @@
-use iced::{button, Align, Button, Column, Element, Sandbox, Settings, Text};
+use iced::{
+    button, Align, Button, Color, Column, Element, Sandbox, Settings, Text,
+};

 pub fn main() {
-    Counter::run(Settings::default())
+    Counter::run(Settings {
+        background_color: Color::new(0.1, 0.2, 0.3, 0.3),
+        ..Settings::default()
+    })
 }

 #[derive(Default)]

Screenshot showing both patched wgpu and glow with the same too-bright color (this is not how 0.1,0.2,0.3 is supposed to look like) as a result of not premultiplying alpha:

Of course for Color::TRANSPARENT everything is fine.

Hmm... After thinking a bit more about it, I believe the background color should be able to change at runtime.
I imagine we could add it as an additional Application method. Thus, I am reverting this change for now.


[RPC] gettransactionkeys

This PR adds a new RPC command to show a transaction input and output keys when combined with txindex.
This helps to greatly improve sync time when using a xNAV light wallet.
Use:
gettransactionkeys rehash
Example output:
{
  "vin": [
    {
      "txid": "e9a87d14c9afddde24aea40e6da9de48b276b20b0fbee1c3a3518a84d4652a25",
      "vout": 0,
      "outputKey": "89bef7ddb16cef274628d49531a879b75f01e37a7489ed63b315a4c451bd07e785d4b4075c002698ce2efa0aa21d6f19",
      "spendingKey": "b93ad3309d2672c45b1b35ff61de199ecd0ac463d5d7e6d0117dec4a20bded6cf92297cb32c5efd0fa63ed81dd53bf52"
    }
  ],
  "vout": [
    {
      "outputKey": "afc9bc88f80174b46aedee2c01dc5faf0a4c6f8389b42c4c88c88a69a754f44442bab0fdf2079be4d6346914d4fabe99",
      "spendingKey": "a0735dcf02303c50cbc0afe3371900efd73031534a9cc9e5d6b48976b84107de3ba25f921859ea01c209600c228853a8"
    },
    {
      "outputKey": "81a598defb7878411b440029ef4149265eea8403d2c3bca2f8d78d74a7cf940532fabcafc25564067960ed837e7a0c51",
      "spendingKey": "934312ae9d7b553c682117253b347f0917d7991b0557b19d3d07bfdc257597e016d2492f125a0af00d3935090d023e93"
    },
    {
      "script": "6a"
    }
  ]
}

https://build.nav.community/binaries/gettransactionkeys/

A new build of 8a81a660becb775c59489db6aa028f94b579a35f has completed succesfully!
Binaries available at https://build.nav.community/binaries/gettransactionkeys


Flutter 3.2 candidate.5 (Remove a line of code from flutter.bat file)

We need to remove a line of code from the flutter.bat file cause it is causing a problem with the new flutter installation.
Whenever a new user is installing the flutter in his/her setup they are getting an error --
'crumb' is not recognized as an internal or external command,
operable program or batch file.
Pre-launch Checklist
--> One line in the flutter.bat file inside the flutter/bin folder is causing this problem,
line no. 23
IF EXIST "%mingit_path%" SET PATH=%PATH%;%mingit_path%
So we need to comment on this line or need to remove it from the flutter.bat file else this problem will continue and
dealing with this kind of situation is not that easy for a new user.
Here I am sharing the logs of the terminal when I run flutter doctor -v
flutter doctor -v
'crumb' is not recognized as an internal or external command,
operable program or batch file.
[√] Flutter (Channel stable, 3.3.8, on Microsoft Windows [Version 10.0.19044.2311], locale en-US)
• Flutter version 3.3.8 on channel stable at D:\flutter_windows_3.3.8-stable\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision https://github.com/flutter/flutter/commit/52b3dc25f6471c27b2144594abb11c741cb88f57 (2 weeks ago), 2022-11-09 12:09:26 +0800
• Engine revision 857bd6b74c
• Dart version 2.18.4
• DevTools version 2.15.0
[!] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
• Android SDK at C:\Users\Sudhanshu\AppData\Local\Android\sdk
• Platform android-32, build-tools 32.0.0
X Android SDK file not found: C:\Users\Sudhanshu\AppData\Local\Android\sdk\build-tools\32.0.0\aapt.
• Try re-installing or updating your Android SDK,
visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.3.6)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.3.32929.385
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 2021.2)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
[√] IntelliJ IDEA Community Edition (version 2021.3)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.3
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
[√] VS Code (version 1.73.1)
• VS Code at C:\Users\Sudhanshu\AppData\Local\Programs\Microsoft VS Code
• Flutter extension can be installed from:
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.19044.2311]
• Chrome (web) • chrome • web-javascript • Google Chrome 107.0.5304.107
• Edge (web) • edge • web-javascript • Microsoft Edge 107.0.1418.52
[√] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 1 category.
##After removing line no.23
IF EXIST "%mingit_path%" SET PATH=%PATH%;%mingit_path%
[√] Flutter (Channel stable, 3.3.8, on Microsoft Windows [Version 10.0.19044.2311], locale en-US)
• Flutter version 3.3.8 on channel stable at D:\flutter_windows_3.3.8-stable\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 52b3dc25f6 (2 weeks ago), 2022-11-09 12:09:26 +0800
• Engine revision 857bd6b74c
• Dart version 2.18.4
• DevTools version 2.15.0
[!] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
• Android SDK at C:\Users\Sudhanshu\AppData\Local\Android\sdk
• Platform android-32, build-tools 32.0.0
X Android SDK file not found: C:\Users\Sudhanshu\AppData\Local\Android\sdk\build-tools\32.0.0\aapt.
• Try re-installing or updating your Android SDK,
visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.3.6)
• Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
• Visual Studio Community 2022 version 17.3.32929.385
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 2021.2)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
[√] IntelliJ IDEA Community Edition (version 2021.3)
• IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.3
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
[√] VS Code (version 1.73.1)
• VS Code at C:\Users\Sudhanshu\AppData\Local\Programs\Microsoft VS Code
• Flutter extension can be installed from:
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[√] Connected device (3 available)
• Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19044.2311]
• Chrome (web)      • chrome  • web-javascript • Google Chrome 107.0.5304.107
• Edge (web)        • edge    • web-javascript • Microsoft Edge 107.0.1418.56
[√] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 1 category.
The Problem is fixed and the flutter programs are working smoothly.

This PR looks like it was branched off of a different branch from master, resulting in a large diff and meaning it will not be mergeable. Please see tree hygiene for more details about how to open pull requests to Flutter repositories.
Feel free to create a new pull request with these same changes branched off of master, and thanks for contributing!

However, I would suggest starting by filing a bug (you can feel free to @ me on it) first, so that the tools team can discuss and ensure we're making the right fix.

okay! Thanks a lot