keypress is deprecated

While I was working on issue #195 I have read into the Mozilla's Developer Network (MDN) documentation on the keypress event. It reports that the event is deprecated.

This feature is no longer recommended. Though some browsers might still support it, it may have already been removed from the relevant web standards, may be in the process of being dropped, or may only be kept for compatibility purposes. Avoid using it, and update existing code if possible; see the compatibility table at the bottom of this page to guide your decision. Be aware that this feature may cease to work at any time.

Good find! Looks like both keydown and keypress events are used in keyboard.js.

I could start making a plan for the conversion if that is helpful


Split Sqlio.pm and DiskSpd.pm into Parser/Runner modules

Parsing and running are different enough activities that the modules should probably be split.  There are a lot of examples already (LogmanParser/LogmanRunner, etc.)

Done in commit 95dba2c44319d611f5a8b5ff90a873de7843e096


Remove extra parameter from < resource > shortcodes

Pre-Flight checklist

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets? #1123
What's this PR do?
When converting some images from  markdown ![alt text](file url) to resource shortcodes, I erroneously included the alt text as an argument to the short code: < resource uuid "alt text here" >. This was wrong: resource shortcode only takes 1 uuid argument, the alt text etc is read from metadata.
This PR adds a rule to remove extra shortcode arguments.
This PR also...

introduces the use of pyparsing as in markdown_cleanup rules

removes a few old rules we seem unlikely to use again

switches from batch updates to one-by-one updates
This is less efficient but... it's not like we are updating that many records. And now we don't have to manually track sync_state changes.

How should this be manually tested?

Ensure you have some bad resource shortcodes... If you do not have recent rc/prod data, run docker-compose run --rm web python manage.py markdown_cleanup rootrelative_urls -o rootrelative_urls.csv --commit on master branch. This will make some new resource shortcodes that have too many arguments. (😱). Add --skip-sync if you want to skip the sync to github.

Checkout this branch.

Run docker-compose run --rm web python manage.py markdown_cleanup remove_extra_resource_args -o remove_extra_args.csv --csv-only-changes to generate a CSV of changes that will be made. This takes about 5 minutes.

Verify nothing has changed. (dac7dbe9-bb2e-33c6-6027-a326888523c0 is a good page to inspect)

docker-compose run --rm web python manage.py markdown_cleanup remove_extra_resource_args -o remove_extra_args.csv --commit

Verify changes have been made (dac7dbe9-bb2e-33c6-6027-a326888523c0 again)

You could run manage markdown_cleanup shortcode_logging -o shortcodes.csv, too. But it takes a while and does not make any changes, only logs shortcode usage.
Any background context you want to provide?
Why Pyparsing? Because:

it's very flexible
its parse_action and transform_string methods provide a mechanism similar to regex substitution, so making substitutions on part of the markdown is easy(ish)
and I've used it before so I knew it would work. E.g., EdX's formula parser is written with PyParsing (https://github.com/openedx/openedx-calc/blob/master/calc/calc.py)

Downsides...

significantly slower than regexp
no special utilities for helping with markdown

We are not too tied to pyparsing. Most of markdown_cleanup is independent of it. https://readthedocs.org/projects/marko/ is maybe worth looking into more, too.

Codecov Report

Merging #1137 (7983c28) into master (9c996a2) will increase coverage by 4.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
+ Coverage   90.96%   95.37%   +4.41%
==========================================
  Files         207       98     -109
  Lines        8058     2683    -5375
  Branches     1390      553     -837
==========================================
- Hits         7330     2559    -4771
+ Misses        636      124     -512
+ Partials       92        0      -92

Impacted Files
Coverage Δ

...s/management/commands/markdown_cleaning/cleaner.py

...agement/commands/markdown_cleaning/cleanup_rule.py

ocw_import/tasks.py

main/constants.py

news/views.py

gdrive_sync/apps.py

main/middleware.py

websites/utils.py

...gement/commands/markdown_cleaning/testing_utils.py

videos/views.py

... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c996a2...7983c28. Read the comment docs.

Force push had no changed, just a rebase to incorporate #1136


Problem with mutex.h

I don't know how to describe it. I mean that some programs don't tolerate <windows.h> and thus are incompatible with some typedef functions of the HALF, FLOAT or some cann't tolerate at all. Is there any idea to bypass this problem?
Recently, I have a problem compiling a new codec VVC with WPP PARALLEISM functions.
https://vcgit.hhi.fraunhofer.de/jvet/VVCSoftware_VTM
msg((MsgLevel) ERROR

Short answer: Maybe.
Long answer:
The Windows headers define many macros, which is undesired in C++ because they are unscoped. The library currently includes the entire windows.h header, which includes every such macro. With care, replacing windows.h with more specific headers (eg. syncapi.h) should be possible, but that may not completely avoid the undesirable macros.
Taking it a step further, it may be possible to eschew the Windows headers completely (solving the problem), but abandoning a supplier-provided API is generally considered to be unwise.

Thanks for the answer
One more question:
Why can in the typedef specifier not be found at compilation?  The typedef don't have declaration specifiers in windows.h and don't write declaration even using will update Minimize Windows headers.
enum MsgLevel
{
SILENT  = 0,
ERROR   = 1,
WARNING = 2,
INFO    = 3,
NOTICE  = 4,
VERBOSE = 5,
DETAILS = 6
};
msg((MsgLevel) ERROR

I understand that such errors rather impossible to delete.
In file included from c:\msys920\x86_64-w64-mingw32\include\hdrlib\inc\Global.H:71,
                 from c:\msys920\x86_64-w64-mingw32\include\hdrlib\inc\distortionmetric.h:55,
                 from c:\msys920\x86_64-w64-mingw32\include\encoderlib\EncCfg.h:51,
                 from c:\msys920\x86_64-w64-mingw32\include\encoderlib\enclib.h:48,
                 from EncApp.h:44,
                 from encmain.cpp:43:
c:\msys920\x86_64-w64-mingw32\include\hdrlib\inc\TypeDefs.H:155:10: error: 'UINT' redeclared as different kind of entity
  155 |   UINT = 0,                           // Unsigned integer (32 bit) type
      |          ^
In file included from c:\msys920\x86_64-w64-mingw32\include\synchapi.h:10,
                 from c:\msys920\x86_64-w64-mingw32\include\commonlib\mingw.mutex.h:51,
                 from c:\msys920\x86_64-w64-mingw32\include\commonlib\Picture.h:55,
                 from c:\msys920\x86_64-w64-mingw32\include\commonlib\loopfilter.h:43,
                 from c:\msys920\x86_64-w64-mingw32\include\encoderlib\enclib.h:43,
                 from EncApp.h:44,
                 from encmain.cpp:43:
c:\msys920\x86_64-w64-mingw32\include\minwindef.h:159:24: note: previous declaration 'typedef unsigned int UINT'
  159 |   typedef unsigned int UINT;
      |                        ^~~~
In file included from c:\msys920\x86_64-w64-mingw32\include\hdrlib\inc\Global.H:71,
                 from c:\msys920\x86_64-w64-mingw32\include\hdrlib\inc\distortionmetric.h:55,
                 from c:\msys920\x86_64-w64-mingw32\include\encoderlib\EncCfg.h:51,
                 from c:\msys920\x86_64-w64-mingw32\include\encoderlib\enclib.h:48,
                 from EncApp.h:44,
                 from encmain.cpp:43:
c:\msys920\x86_64-w64-mingw32\include\hdrlib\inc\TypeDefs.H:157:11: error: 'FLOAT' redeclared as different kind of entity
  157 |   FLOAT = 2,                          // Floating point (single precision - 32 bits)
      |           ^
In file included from c:\msys920\x86_64-w64-mingw32\include\synchapi.h:10,
                 from c:\msys920\x86_64-w64-mingw32\include\commonlib\mingw.mutex.h:51,
                 from c:\msys920\x86_64-w64-mingw32\include\commonlib\Picture.h:55,
                 from c:\msys920\x86_64-w64-mingw32\include\commonlib\loopfilter.h:43,
                 from c:\msys920\x86_64-w64-mingw32\include\encoderlib\enclib.h:43,
                 from EncApp.h:44,
                 from encmain.cpp:43:
c:\msys920\x86_64-w64-mingw32\include\minwindef.h:142:17: note: previous declaration 'typedef float FLOAT'
  142 |   typedef float FLOAT;
      |                 ^~~~~

I don't know if I did the right thing. I replaced the lines in EncAppCfg.h and now the problem has disappeared. Until next time.
#include "CommonLib/CommonDef.h"

#if JVET_O0756_CALCULATE_HDRMETRICS
#include "HDRLib/inc/DistortionMetric.H"
#endif

#include "EncoderLib/EncCfg.h"
#if EXTENSION_360_VIDEO
#include "AppEncHelper360/TExt360AppEncCfg.h"
#endif
#include
#include

Generally, avoiding naming conflicts is the right thing to do. Your approach is viable, as would be placing your enum in a namespace.
Generally, following the naming conventions from a style guide is good practice. It doesn't completely isolate you from problems (eg. the Windows API uses macros to fake argument-dependent lookup in C), but it can massively reduce the rate at which you encounter such problems. For example, reserving ALL_CAPS_NAMES for preprocessor macros will avoid many problems with older APIs.


is it supports color swatches for lsp completion

Is this supports color swatches for lsp completion , as done by tailwindcss lsp , as  it helps in showing color preview(swatches) in autocompletion box

Yes , I had check code.
I'm talking about this in context of gui editor (not about neovim), they need this to show color in completion box(most of them support this one )


[Coverity CID :203501]Memory - corruptions in /subsys/net/lib/lwm2m/ipso_timer.c

Static code scan issues seen in File: /subsys/net/lib/lwm2m/ipso_timer.c
Category: Memory - corruptions
Function: timer_create
Component: Networking
CID: 203501
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

Lines of code in question:
https://github.com/zephyrproject-rtos/zephyr/blob/master/subsys/net/lib/lwm2m/ipso_timer.c#L334
	(void)memset(res[avail], 0,
		     sizeof(res[avail][0]) * ARRAY_SIZE(res[avail]));

Description of issue is:
CID 203501 (#1 of 1): Out-of-bounds access (OVERRUN)
11. overrun-buffer-arg: Calling memset with res[avail] and 264U is suspicious because the function call may access res at byte avail * sizeof (struct lwm2m_engine_res [11]) + 263UL. [Note: The source code implementation of the function has been overridden by a builtin model.]

Maybe, I'm misunderstanding the description of the issue, but for any actual value of avail (the object instance index), we should be able to safely clear out the sub array of 11 resource records (each 24 bytes in size for a total of 264).

I did a small test and printed the actual values:
sizeof(res[avail][0])  = 24
ARRAY_SIZE(res[avail]) = 11
sizeof(res[avail][0]) * ARRAY_SIZE(res[avail]) = 264
sizeof(res[avail]) = 264

So you could just say (void)memset(res[avail], 0, sizeof(res[avail]) here as that is a bit more readable.
Anyway, the issue looks like false positive to me.


Pin the version of kubernetes in the deployment instructions so that kubernetes api changes won't break examples

This is a proposed fix for #8987
When following the instructions for Build and deploy to Azure Kubernetes Service even by following the instructions exactly it will cause a fail on deployment due to changes in the kubernetes api on newer version of AKS.
I am changing the docs here to pin a version so that future examples won't break, and have a separate PR to fix the actual code that deploys the example so it should succeed on more recent versions of kubernetes that can be seen in this pr

@raboley : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @azooinmyluggage - Could you review this pull request? Thanks.

any word on this? should be quick and fix a big problem for new users trying to adopt the workflow.

Fixes https://github.com/MicrosoftDocs/azure-devops-docs/issues/8987
Looks good to me, adding @juliakm as the Ecosystems doc owner

Thanks, all.


Readme quick fix

Pull Request type

Please check the type of change your PR introduces:

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
Broken link

Issue Number: #156
What is the new behavior?

Fixes the link

Does this introduce a breaking change?

[ ] Yes
[X] No

Other information

@all-contributors please add
@dbejarano820 for documentation


bundle exec cannot find gem that is sitting right in ./vendor/cache

I've spent over 2 hours on this now and don't see anything I am doing wrong or can fix.
Environment
Bundler   1.15.1
Rubygems  2.6.11
Ruby      2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
Git       1.7.1
Platform  x86_64-linux

Gemfile
Gemfile
source "https://rubygems.org"

# 4/24/2017 - Looks like 2.x is imminent, so being safe here for
# general reasons --jblaine
gem 'highline', '<= 2.0'
gem 'net-ldap'
gem 'rkerberos'
gem 'pry'
# required for pry with rubies that are not compiled with readline
gem 'rb-readline', '~> 0.5'
gem 'rake'
gem 'rake-compiler'

Gemfile.lock
GEM
  remote: https://rubygems.org/
  specs:
    coderay (1.1.1)
    highline (1.7.8)
    method_source (0.8.2)
    net-ldap (0.16.0)
    pry (0.10.4)
      coderay (~> 1.1.0)
      method_source (~> 0.8.1)
      slop (~> 3.4)
    rake (12.0.0)
    rake-compiler (1.0.4)
      rake
    rb-readline (0.5.4)
    rkerberos (0.1.5)
      rake-compiler
    slop (3.6.0)

PLATFORMS
  ruby

DEPENDENCIES
  highline (<= 2.0)
  net-ldap
  pry
  rake
  rake-compiler
  rb-readline (~> 0.5)
  rkerberos

BUNDLED WITH
   1.15.1

ERROR
highline is sitting right there and not getting found:
% bundle exec ./audit_sudoers.rb
Could not find highline-1.7.8 in any of the sources
Run `bundle install` to install missing gems.
% ls vendor/cache/
coderay-1.1.1.gem   method_source-0.8.2.gem  pry-0.10.4.gem   rake-compiler-1.0.4.gem  rkerberos-0.1.5.gem
highline-1.7.8.gem  net-ldap-0.16.0.gem      rake-12.0.0.gem  rb-readline-0.5.4.gem    slop-3.6.0.gem
%

Have you run bundle install?

Sorry. Newbie flailing in a strange land. Thank you for the reply.

No worries!

im' facing the same issue while i'm deploying using Capistrano gem
this is my error Could not find highline-1.7.8 in any of the sources
I added the gem in my Gemfile and run bundle install
what I should do to fix it?!


✏ Change docs for cyclonedx 1.5 version update

Changes

Updates documentation reference to include cyclonedx v1.5, from https://github.com/CycloneDX/cyclonedx-cli/pull/337
Changes reference to default version, from 1.4 to 1.5

I didn't see a doc page for developing in this repo, but let me know if I need to do anything for this PR like run certain tests. @coderpatros


pre-commit using old pylint version

Describe the bug
Developer environment issue - not related to package performance.
Pre-commit is currently using pylint==2.6.0, which results in false-positive error cases when using subscriptable type hints in python 3.9.
Per the comment linked above, this should be fixed by bumping pylint to >2.7 (or just committing the changes to pre-commit autoupdate to catch everything?)

[X] I have checked that this issue has not already been reported.
[ ] I have confirmed this bug exists on the latest version of pandas.
[ ] (optional) I have confirmed this bug exists on the master branch of pandas.

Note: Please read this guide detailing how to provide the necessary information for us to reproduce your bug.
Code Sample, a copy-pastable example
from typing import Any, Dict
def some_func(some_var: Optional[str]):
    pass

>>> pylint
E1136: Value 'Optional' is unsubscriptable (unsubscriptable-object)

Expected behavior
Pylint should recognise type hints correctly, and pre-commit should not fail when committing new changes within the pandera-dev conda environment.
Desktop (please complete the following information):

OS: iOS

Screenshots
N/A
Additional context
N/A

We should also have a nox session that reads the .pre-commit-config.yaml and verifies that versions are synced, similarly to the nox session to verify that setup.py and  requirements-dev.txt are synced.


Cannot parse shader with ternary condition written in specific way

Godot version
21c79d75153733b84533957228d0c267ef340a80
System information
Windows 10 64 bits GLES3 GeForce GTX 1060 6GB/PCIe/SSE2
Issue description
I wanted to give a try at the code from https://iquilezles.org/articles/biplanar/ but found Godot is unable to parse it.
Steps to reproduce

    ivec3 ma = (n.x>n.y && n.x>n.z) ? ivec3(0,1,2) :
               (n.y>n.z)            ? ivec3(1,2,0) :
                                      ivec3(2,0,1) ;

Invalid argument to ternary operator: 'bool, ivec3, bool'.
  Shader compilation failed.

Workaround:
Add parenthesis to the nested ternary.
    ivec3 ma = (n.x>n.y && n.x>n.z) ? ivec3(0,1,2) :(
               (n.y>n.z)            ? ivec3(1,2,0) :
                                      ivec3(2,0,1) );

Minimal reproduction project
ShaderParserTests.zip

I have troubles to solve that issue a while ago (spent several hard hours). Maybe someone else could solve that.


Migrate to relay modern instead of Apollo client

I think this PR should include the get-graphql-schema package.json script to retrieve the updated version of the schema from the graphql repo endpoint.

I added graphql-cli instead for the same purpose, which should be better choice, cc @git-toni

@jaroslav-kubicek  Yep, sorry, missed the .graphqlconfig settings. Much better like this I agree :)


[SANDBOX] errorCode=02628

Hi,
Since last week, we encounter an error during the payment process in local environment and github actions (tried with both testing payment cards : https://docs.mangopay.com/testing/payment-methods#cb-visa-mastercard).
After submitting the payment form to MANGOPAY, we end up on the following URL :
https://homologation-webpayment.payline.com/webpayment/getToken
With the following content :
errorCode=02628
But I don't find this error code in the documentation.
Any ideas ?
[EDIT]
It actually happens in local and within github actions but it works on our staging environment...
[UPDATE]
According to other PSP documentation, It seems that the error code 02628 refers to an invalid return URL.
Here's an example of my return URL : https://localhost/reservation/confirmation/01J5827H8F9D5PRH889KQ60M3T
We didn't change anything, it's the same URL we had before the bug.
[UPDATE 2]
Ok, I just replaced localhost with <IP_ADDRESS> and the error code disappeared, letting me process the payment.
Why can't we use localhost in the returnURL anymore ?

I have the same probleme and I have a "custom" localhost name for dev purpose.
So Why can't we use localhost or other stuff in the returnURL anymore ?
BUT it still work fine with paypal sandbox....

Hi @mickaelpois , is your team aware of this ?

Hello,
I'm using a custom domains (virtual host) on my local environment and my urls are not working anymore. Do you know any work around in the meantime ?
Hope this is fixed quickly though


Switch to ovn standalone mode

Get rid of cluster operations of ovn database by
switching from cluster to standalone mode.
The transaction processing steps are much simpler
in standalone mode compared with cluster mode.
Following is the sequence of actions for transaction execution in a standalone database: # Receive a transaction request.
Execute the transaction on in-memory data.
Write resulted changes on disk.
Reply to a client.

And the same thing in a single-node cluster: # Receive a transaction request.
Evaluate the transaction (same as execute, but changes are not yet committed).
Propose resulted changes to a raft storage module.
Update raft log with new changes.
Write changes on disk.
Mark proposed changes as applied.
Read last applied change from raft storage.
Re-evaluate changes and commit (basically, execute the transaction again).
Reply to a client.

In standalone mode, ovn database schema is evaluated to
upgrade/downgrade every time when starting ovn database
using ovn-ctl script, which removes the need to add upgrade
logic in postStart hook of ovnk database containers.
Signed-off-by: Zenghui Shi<EMAIL_ADDRESS>

Rebased to take the asset permission change.


Make sure files we add hashes to files that we copy during build process

Description
We copy luigi lib and themes css files during build process. Make sure we can import them with hashes in names. Add hashes to them. Adjust cache length.

Hint: Check gulpfile copy-themes and core/webpack.config.js

Expected result

Actual result

Steps to reproduce

Troubleshooting

We've decided to not add hashes to the themes files because their size is not that large. It wouldn't change much.


Define prettify via options

The need to override validate.prettify globally is a burden for functional programming, so I added the ability to provide it via the validate/runValidations options.
Just in case anyone might need further customisation, I also made it possible to override prettify for individual numericality and equality validations via the validator options.

Coverage remained the same at 100.0% when pulling 6f6d7760bf9660fa7cbf7cade2efa47d3907e0b2 on vdh:prettify-via-options into f42d0ac4b94614e7e0c8ace427dd9ef3b6f979f6 on ansman:master.

Coverage remained the same at 100.0% when pulling 856d70ef2df80e019c28897b35cd24430dff2530 on vdh:prettify-via-options into ab5ad5a3a7a82546c7a1aecedb338b6413e20119 on ansman:master.

Coverage remained the same at 100.0% when pulling f23082edbc3193e0b3275620fc7ed7f47bef1f05 on vdh:prettify-via-options into ab5ad5a3a7a82546c7a1aecedb338b6413e20119 on ansman:master.

Sorry for the delay, looks good. Thanks!

Can you please create an example on how to use this using presence?

@underscore05 The presence validator already has the option to set a custom message, I don't understand how you're relating that validator to this.
This feature allows a custom prettify function within the options of the validate call, instead of being restricted to just the global validate.prettify.
prettify handles things like attribute names, as describled here in the docs.
For example:
return validate(values, constraints, {
  prettify: function prettify(string) {
    // Do something special with `string`, like i18n
    // Otherwise, fall back to the global…
    return validate.prettify(string);
  },
});


Update virtual-machine-network-throughput.md

Removing duplicate spelling-out of previously defined acronym - Quality review.

Thanks, @huffmatt!


Use a single scanner for all parsing tasks.

Our current "nested function" style of coding comes with a cost.  Specifically, calling the outer functions causes a large amount of engine cost to intialize all the inner functions contained within.  This is problematic for certain functions (like parsing and scanning) as we call them for every file, and thus take that hit over and over.
One solution to this is to use classes.  Classes initialize their instance functions only once, storing them on the prototype.  From that point on, all new instances get those initialized functions from the prototype.  However, we have decided to avoid classes, and consistently use functions instead.
Al alternate, non-class, approach is to move to singletons.  Instead of creating a new scanner or parser for each source file, instead we just create one, and reuse it for each file.  This is simple to implement, and fits well with our current function-style approach.

I'm genuinely curious about what kinds of perf gains we're getting.
We were creating a scanner for every incremental parse, weren't we?

Why do we need to make the parser a singleton?

I'm genuinely curious about what kinds of perf gains we're getting.

Vlad has the specific numbers.  IIRC, it's something like 15% speedup for the scanning/parsing part of compilation.

Why do we need to make the parser a singleton?

For the same reason.  So that each time we call "parseSourceFile" we don't end up incurring the cost to initialize all those nested functions.

I see now - you're closing over the core state and modifying that at each call to parse. That's pretty nifty.

Were we creating a scanner for every incremental parse?

This is unrelated to incremental parsing.  The issue here is the cost overhead of simply calling the createScanner and parseSourceFile functions.  Just the initialization costs for these functions is high enough to effect parse time.
This information was discovered during the rewrite when we attempted to change the old parser to functional style.  That change alone slowed down parsing throughput by about 25%. i.e. when parsing Test262, just the cost to initialize the parse function was enough to slow down our overall throughput on the thousands of files we were running over.
Vlad recently profiled this as well with the new compiler and found the same problem.  ideally, nested functions would only cost anything the first time you called the function.  Unfortunately, that is not the case.  They cost each time the outer function is called.  For throughput oriented scenarios (like command like compilation), this adds up and slows us down when you have lots of files.
The cleanest approach would likely be to use classes.  But this is a reasonable middle ground given our decision about classes, and our desire for perf.

:+1:

What about using a module?


Implement POST /v1/chains/:chainId/messages/:messageHash/signatures

Closes #259
Adds the POST endpoint /v1/chains/:chainId/messages/:messageHash/signatures

Unit (controller) tests were added for the route
OpenAPI specification was added.

Coverage: 88.964% (+0.1%) from 88.851% when pulling 01052fd26e1c41a82443d31ce2a32b594f19c9c2 on post-message-signatures into 482300bef1680a0e3bf56178387ffc8cba3a4029 on main.


Bump reconciler images after latest fixes to connectivity-proxy-reconciler

After changes from https://github.com/kyma-incubator/reconciler/pull/1403

/retest


[MUIC-197] [MUIC-252] [MUIC-254] [MUIC-256] Documentation

Documentation of public interfaces.
Also added integration guide as part of markup doc - I guess this should end up in Glia's online documentation.

As I pointed out, some comments seem very superficial and would benefit from additional information. For now you can leave the longer comments there, since a proper integration guide should be done anyways.
Also I will arrange it so that this repository can be seen by our technical writing team so that they also take a look.

Made the suggested changes. I think the best way to describe what is what and used where is to have a screenshot of each view with a description of each element. But this would be a separate task.

Most of my comments are basically proofreading and requests for clarification, but that's probably what this PR is for 🤔
You may feel that I behaved like a Grammar Nazi in a lot of these comments, but this is something we will give to our clients, and thus it should be as perfect as it can be. Most problems are with extraneous `'s' additions or articles, and also a lot of the places can and should be more verbose - docs that just repeat the variable name do not bring much to the table.
But overall, nice job with documenting all this stuff! Now I gotta come back to my PR and add comments to the variables that I have added 😄

Today was my last day in this project so feel free to take over and make these changes.

Merged dev in this branch to resolve conflicts. Also added choice cards documentation.

I discussed the screenshots options with Henrik a bit.
As a minimum, I would think we should have:

Some general screenshot of the chat, to show what regions we would have on the screen, similar to Android: https://github.com/salemove/android-sdk-widgets-wiki/blob/52342e250fcd24ec6da4ae1ae17383b1e4599532/images/concepts_changed_colors.png
A few screenshots to show where are the things we talk about in the code, to give the integrator some insight on what they are designing. Some might be covered by the screenshot in the previous point, but I'm thinking things like these:

Attachment sources
Badge
Call button bar
Navigation bar
Message input area (and why and what buttons we have there?)
Some illustration about button states, as this was a bit confusing in the code what is meant by that

I have fixed/answered all of the comments, so @kadriiiii please take a look at the new changes or respond to my questions.
As for the screenshots, I will start creating them. I will make 1-2 test screenshots with descriptions and show them for approval to Henrik first.

As for the screenshots, I will start creating them. I will make 1-2 test screenshots with descriptions and show them for approval to Henrik first.

Sounds good! Then it is clear if we're all on the same page, before putting in too much effort.

I have fixed/answered all of the comments, so @kadriiiii please take a look at the new changes or respond to my questions.

I added additional comments in a few discussions, but agreed with bunch of them also.
I would like to resolve the ones you marked "fixed" as they indeed were fixed, or the ones where I agreed, but it seems I do not have the resolving rights in this repository. I guess you yourself @VladKupriienko can mark them resolved at some point, to make things look a bit more clean.

I will merge this for now as this has grown into quite a big PR. We'll refer to comments there in the future and will continue making changes. It will be much easier to do even in regular feature branches if they touch a specific file that contains docs.


Error when downloading

Hi There,
Not sure what I am missing, but when I download meg and want to run it I get this on my Kali linux.
└─$ meg --help
Command 'meg' not found, did you mean:
command 'mev' from deb gpm
command 'mesg' from deb util-linux
command 'eg' from deb easygit
command 'peg' from deb peg
command 'med' from deb ncl-ncarg
command 'leg' from deb peg
command 'geg' from deb geg
command 'mex' from deb texlive-lang-polish
command 'mag' from deb texlive-binaries
command 'mg' from deb mg
Try: sudo apt install

Run this  command go install github.com/tomnomnom/meg@master


Parking grid - like vehicle grid, but for parking spaces

#342, #231, #196, #176 and basically everything else that shows up in a search for the term "parking". :)

I think we need some sort of parking grid. Like the vehicle grid, but for parking spaces.
This, primarily, is about optimising pathfinder decision making for mixed-mode transport a.k.a. "park and ride".
Currently pathfinder has no clue how much parking there is at a given spot. Trying to calculate from scratch per PF would be lagmageddon.
Rough idea:

Map is chopped up in to a grid

No idea what ideal cell size would be

When game loads, the whole grid gets updated (or spread across frames?)
For each grid cell is total number of parking spaces
When building or road added/moved/removed, update affected cells accordingly

This way there's very little ongoing work

When a cim tries parking at a given location, if they can't find parking a counter gets added on that grid cell

The higher the counter, the less desirable that grid cell is for parking
The car can look at nearby cells (and their 'full' counters) to quickly determine where they might find a parking spot, and then try there
They can try maximum of ~3 parking cells before giving up and taking some alternate action

It would be nice if there was some way to time-bucket the "parking full" counters, especially if the time buckets could roughly coincide with Real Time mods daily schedule a.k.a. shifts (probably require time sliders so user can choose the bucketing offsets): Early morning, Day, Evening, Night.
The thinking here is that those RT shifts are roughly the time a car would be parked in a given spot. So if someone goes to work their car will be parked for their whole shift.
For users who don't use RT mod, we'd just split day equally in to 4 shifts; 2 daytime, 2 night time. Vanilla game only perceives 2 shifts really: Day and night, and even then the difference between the two is barely noticeable.
So, anyway, the PF can now quickly check a destination to see if it's suitable for parking. If not, it can quickly find the nearest suitable alternative. And if car gets there but can't find parking, a repath is more likely to lead to success.

Sounds like a cool idea, perhaps make sure #175 ghets fixed first, as now eventually (slowly but surely) all my parking lots are getting filled with "ditched"cars. Likley due to teleporting cims....

A grid holding parking vehicles aready exists in the base game

but I am not sure if that suits our needs.

Yup, if we wanted to do things "reserved parking" as per #231, we would need something more elaborate.


User reported Kite crashed Vim

When i held down the delete key in insert mode in chin it kept inserting suggested text

Will ask the user to provide his .vimrc setup. @airblade any other info necessary?

https://github.com/ryx2/rc/blob/master/vimrc
This is my vimrc.
Vim didn't "crash" it just kept inserting the same suggested function when i held the delete key in insert mode, making it unusable

This is with vim8, vim-gtk

@ryx2 Thanks for linking to your vimrc.  However it mostly sources other files which don't seem to be on GitHub, so it's hard to get a full picture of your vim setup.
Anyway, it would be great if you could please let me know:

What was the function that kept being inserted?
Did this start in the middle of a completion or just when typing without any completions?
Can you reproduce it consistently?
What is :echo kite#utils#plugin_version()?

Thanks for getting back to me!
I forgot to mension, this only happens when I'm using vim to edit python files. The function is "=AutoPairsDelete()". it does not occur when i have all my plugins commented out in my vimrc. I have included a screenshot of what the unwanted insert. I just typed out "asdfasdfasdfasdfasdfasdfasdf etc" and held backspace, with kite's vim plugin on, hitting enter a few times and doing this again.
It appears to occur randomly, but only when deleting text, not when deleting blank spaces. It also inserts when it is deleting the function that it autoinserted. Also, if i carefully hit the delete button once at a time, the insert does not happen. If I hold it down, that's when the unwanted insert occurs. When I tried double tapping the delete button, i was able to recreate the problem.
my vim kite version is 1.0.64
I am willing to collaborate as much as you want to help fix this. I love kite for pycharm, and would love it working for my vim too.

Thanks for all the information, espcially the tip about vim-airline.  I'll investigate...
Note to self: looks like https://github.com/kiteco/vim-plugin/issues/214#issuecomment-558696474.

Hmm, I can't reproduce this yet.
Does it happen when you have a minimal vimrc and your only plugins are this one, vim-airline, and auto-pairs?
What does :imap look like?

Thinking out loud:

The text =AutoPairsDelete() is inserted.

That text comes from here:
  " Use <C-R> instead of <expr> for issue #14 sometimes press BS output strange words
  execute 'inoremap <buffer> <silent> <BS> <C-R>=AutoPairsDelete()<CR>'

<C-R>= means insert the result of evaluating the expression.

We know the problem occurs with two rapid <BS>s.

Found something. I have my  in my vimrc.
vnoremap  "+yy
When I comment this line out, I can have vim-airline, no problem.
I use this along with vim-gtk to use ctrl-C to copy text from vim into my regular clipboard. I guess I could find another key (ctrl c was intuitive as the copy mechanism for the regular keyboard). But I dont want to find another way to copy text haha i loved the shift-V select block text ctrl-c copy it out of vim haha

Sorry, that echo should have been:
:echo &timeout &ttimeout &timeoutlen &ttimeoutlen

Also, the vnoremap looks incomplete: it's missing the left hand side, I think?

Does this fix the problem?
diff --git i/autoload/kite/snippet.vim w/autoload/kite/snippet.vim
index 51a2b6d..5f604b9 100644
--- i/autoload/kite/snippet.vim
+++ w/autoload/kite/snippet.vim
@@ -266,7 +266,6 @@ function! s:remove_smaps_for_printable_characters()
         \ '<C-Tab>',
         \ '<NL>',
         \ '<CR>',
-        \ '<BS>',
         \ '<Leader>',
         \ '<LocalLeader>'
         \ ]

Does this help?
- vnoremap <C-c> "+yy
+ xnoremap <C-c> "+yy

@ryx2 Have you been able to look at this?

@ryx2 I'm going to close this because it has gone quiet, and also the plugin has changed quite a lot.  Please open a new issue if you have any further problems.  Thanks!


How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: https://github.com/yt-dlp/yt-dlp-nightly-builds
Publisher: yt-dlp
Package Name: yt-dlp-nightly
Description:  yt-dlp nightly builds
Package Version: 2<IP_ADDRESS>406
Installer URL: https://github.com/yt-dlp/yt-dlp-nightly-builds/releases/download/2<IP_ADDRESS>406/yt-dlp.exe

It look like the pull request was merged and closed.

@BrandonWanHuanSheng thank you!


Clip multimedia buttons rendered incorrectly

Before going further

[x] I think my problem is NOT with youtube-dl
[x] I've verified and i assure that I'm running yt-dlg 1.X.Y
[x] I assure that i am using the latest version of youtube-dl
[x] Searched bugtracker
[x] I've read the FAQs file

What is the purpose of your issue?

[x] Bug report
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Bug report
Buttons in clip multimedia dialog window do not look OK.

What operating system do you use ?
Arch Linux, x86_64, wxpython '4.0.7.post2 gtk3 (phoenix) wxWidgets 3.0.5'

I test that issue before in Debian why in Linux youtube_dl_gui.widgets.ClipDialog.FRAME_SIZE change the size in case the platform.
You can share the version (commit) you test ClipDialog? Test the right property FRAME_SIZE ?

I've retested with 9789d97 which is now the current HEAD and it's the same behaviour. FRAME_SIZE used is (250, 170). One thing I noticed is this message in terminal window on execution:
00:40:02: Warning: Mismatch between the program and library build versions detected.
The library used 3.0 (wchar_t,compiler with C++ ABI 1014,wx containers,compatible with 2.8),
and wxPython used 3.0 (wchar_t,compiler with C++ ABI 1016,wx containers,compatible with 2.8).

Not sure if it's related. Then there's a lot of
(yt-dlg:76801): Gtk-CRITICAL **: 00:40:07.574: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkSpinButton

(yt-dlg:76801): Gtk-CRITICAL **: 00:40:07.590: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkSpinButton

(yt-dlg:76801): Gtk-CRITICAL **: 00:40:07.590: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkSpinButton

(yt-dlg:76801): Gtk-CRITICAL **: 00:40:19.231: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkSpinButton

(yt-dlg:76801): Gtk-CRITICAL **: 00:40:19.231: gtk_box_gadget_distribute: assertion 'size >= 0' failed in GtkSpinButton


Add ami id nodepool

@csrwng @derekwaynecarr @ironcladlou @enxebre
Reviewer question: Underlying AMI in the AWSMachine is type AWSResourceReference.  Should we expose the ability to specify by ARN and tags as well? Or just force it to be the AMI ID?

we aren't making incremental changes to the codebase until we decide on the model

we aren't making incremental changes to the codebase until we decide on the model


"Multiple copies of React" error

Well, here's a doozy. When upgrading from the current 3.0.1 release to develop and building with yarn, a rather infamous error appears when trying to boot up Lock:

Warning: addComponentAsRefTo(…): Only a ReactOwner can have refs. You might be adding a ref to a component that was not created inside a component’s render method, or you have multiple copies of React loaded.

After some spelunking, there are indeed two React instances in vendor.js. Here's what seems to be happening:

auth0-lock declares the dependency "react": "^15.6.2"
auth0-lock-passwordless instead declares "react": "^0.14.0"
Since the versions don't agree, both versions get added to node_modules when yarn'd.
Broccoli builds both versions into vendor.js. Shenanigans ensue.

Parts of this are still a bit mysterious: this happens when creating a simple test app, but somehow, only one of the two reacts get included in my production app build, and I'm not sure what's different between the two cases.
A temporary workaround for yarn users is to embed a resolutions block that forces react to one particular version, but that's not something we can do addon-side as yarn doesn't seem to look at resolutions inside dependencies (probably by design).
I don't think it's reasonable to ask users to do this when upgrading, though, and this will trip up everyone who's got a caret in their ember-simple-auth-auth0 dependency declaration. So let's not do that. ;)
I'm still trying to figure out a resolution (heh). Even though passwordless mode is going to be added to Lock at some point, there's no set timeline on that. Perhaps the solution for now is to make an  auth0-lock-passwordless PR to upgrade react, since that would eliminate the headache here.
Any thoughts?
[BTW, for those who are wondering "what does React have to do with an Ember addon?": Auth0's Lock is built with React. Just in case that saves a few brain cells.]

auth0-lock-passwordless has not seen a commit since June 2016, so any PR to that repo will almost certainly go nowhere.

Looks like someone's already made a PR for exactly this. I'll leave a comment there just in case, since that'd be the most painless route.

Would it be an option to ship a version without Passwordless? How much use of it do you think there's in the Ember community?
We have a version of Lock with Passwordless included that we are planning to ship in 3 to 4 weeks. The current one is not working in the OIDC conformant pipeline we are pushing, so I would not expect that a lot of ember users are actively using it.

It's a very tempting option -- no hacks, no mess. It's absolutely the way to go long-term, though 3 to 4 weeks isn't exactly "long-term" now, is it? ;)
Is there anyone out there on Passwordless that needs the latest stuff from the develop branch in the short term? If demand's not there, I'd say we could go ahead and release v4.0.0 sans Passwordless, then update to v4.1.0 once Lock gets the feature.
Even if we wait, I absolutely plan on upgrading and dropping Passwordless once Lock gets support. The question really is "do it now, or wait a bit?"

Wait, as the API for Passwordless will be different than the current one, as it will be aligned with Lock 10's API.

Speaking bluntly, Auth0's recent history suggests 3-4 weeks is not a reliable estimate.  I want to believe that you've turned the corner on this, but am still skeptical.
FWIW, I only use Passwordless, but not on develop -- I'm working off of one of @XaserAcheron's old forks and it gets the job done.

FWIW, the changes are ready:
https://github.com/auth0/lock/tree/feature-add-pwdless
https://github.com/auth0/docs/pull/4870
We have to wrap up something else before shipping this, but it's done.

Wait! We're using passwordless in production. Actually, we're still on my fork of this repo. I forgot to point back to the develop branch of the origin, but that's what I'm going to do.

Yup, seems like "Wait" is the winning verdict on the "drop Passwordless" front. FWIW, such a change would definitely be a major version bump, and at that point, it makes the most sense to go all the way and support Lock's new Passwordless integration when that arrives. Sounds like a good goal for v4.0.0 at least.
I won't be pulling any trapdoor levers for the release, so no worries. Though that still leaves the open question of what to do about the dependency issue. I wouldn't want to cut a new release without addressing it... unless we tag it as a beta. Maybe that's not a bad call given we're all working off forks anyway. Thoughts?

Getting an alpha/beta release out at least gives everyone a common frame of reference to work against

Good thinking, though I think we've lucked out on that front, as this is resolved now -- whew!


Share statics with super class.

DRAFT. For comment/discussion only.
NOTE: much easier to see with white space hidden
See #13004 for discussion

No longer relevant.


Cache / hold previous power variable in polynomial function object

Very simple change to hold the previous variable when calculating powers during polynomial evaluation.

Specifically, amend the methods f(x) and derivative(x) in the Polynomial class to improve performance. See this link for the current implementation.


my range sliders  circle position work correctly only after launching browser inspect element or after first click on the  blue circle

I have problem when angularjs-slider is appear for the first time
my range sliders only work after launching browser console or first click on the  blue circle
the position is not correct it start from 0 even if the value is 0 or 5 or 10
after i click on it it will go to the correct position or if i open the inspect element to check the problem it will work too
any idea ? ?
my code :
  $scope.Lang = {
     Reading: 10,
    Writing: 10,
    Speaking: 10,
    options: {
        showSelectionBar: true,
        getSelectionBarColor: function (value) {
            if (value <= 2)
                return 'red';
            if (value <= 4)
                return 'orange';
            if (value <= 7)
                return 'yellow';
            return '#2AE02A';
        }
    }
  };

and the html code
     <rzslider rz-slider-model="Lang.Writing"
                                          rz-slider-options="Lang.options"></rzslider>

image  of the problem :
https://image.ibb.co/nfCwov/Capture.png
what i expect is
https://image.ibb.co/n3V5gF/Capture.png

https://github.com/angular-slider/angularjs-slider#my-slider-is-not-rendered-correctly-on-load


Node/Edge Naming in the bypass form

When bypass values are listed in the modal dialog box, the name of the selected nodes (or edges) are given in the following order:

Style - (Node/Edge) Label - Bypass Value
Style - (Node/Edge) Label - Mapping Value
Style - (Node/Edge) Label - Default Value
The value of the attribute called 'name'(if it exists)
The node/edge Id

Namely: Label Value > Name Attribute > Id

Name source
Example

Bypass Value

Mapping Value

Default Value

Name Attribute

Id

Dropdown UI:


Added quotes to all YAML configuration files

This bundles does not have functional tests for it's config. That's why #18 was merged without any problems :(
This PR fixes the problems with Symfony 3.0

Need a new tag too! @matthiasnoback

I know it's superstitution, but I was waiting for the master build to finish ;) Will tag in a minute.

By the way, I added a test to prevent these things from happening in the future :)

Great!

Done


Add HTMLFormat Property to Notifier component

This PR adds the HTMLFormat property to the notifier component.
Solves #1856
@ewpatton Kindly review.

@AppInventorWorkerBee ok to test


Implement node discovery by topic, using discv5

New, highly experimental, DiscoveryByTopicProtocol class that looks
up nodes by topic and falls back to kademlia's random node ID lookups
when not enough topic nodes are found.

@pipermerriam you happy for this to go in now?


Why are there plans to remove support of the local workbench within the upcoming releases of SharePoint Framework?

Release notes suggest that there are plans to “remove support of the local workbench within the upcoming releases of SharePoint Framework.
Is there an upside to that approach or is it because it is considered to be a feature not utilised very much? Earlier with SPFx, there was more emphasis on unit testing which usually involves mocking and the local workbench was the perfect environment for that as it wasn’t aware of SharePoint at all hence provided an isolated testing environment for unit tests.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 56ca1a68-c91c-077f-b082-c5184af9b93f
Version Independent ID: b6b0f7ff-4f39-b05d-c203-92f5aaec3f63
Content: SharePoint Framework v1.11 release notes
Content Source: docs/spfx/release-1.11.0.md
Product: sharepoint
Technology: sharepoint-framework
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

From MSFT's telemetry, the local workbench isn't used that much esp when compared to the hosted workbench. It's also not nearly as capable as the hosted workbench (ie: local workbench can't be used to test extensions). It's also responsible for a considerable amount of the dependencies downloaded with NPM. So this is more of a planned optimization.

SPFx is only supported on SP2016, SP2019 & SPO... not SP2013... so there's nothing to explain on that point.
But as far as testing and trying things out, why not just get a free developer tenant? IMHO, every M365 developer should have one...

@flowerbot if you have a developer tenant, you still have the workbench in SharePoint... Only the local workbench is going away. In my opinion, the only time the local workbench has been useful, is when I'm developing without internet access... Which is rare.


⚠ Samsung has degraded performance

In 0fe3c5e, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2399 ms

Resolved: Samsung performance has improved in bc87f2b.


Add descriptions to two YouTube videos

I added the GenevaTV branding to the Jim and Randall videos.
A description needs to be added, and if desired add the location
FYI, I've created a Conversations with Kip playlist which is currently unlisted. I've also added end cards to the three Conversation videos. (Suddenly, the subscribe works properly)

I'm fine with the playlist; I've added the dates and locations and copied the descriptions from what I listed on Conversations with Kip


Could you rebuild the image once in a while

Could you rebuild the image once in a while? The qemu version in this image is a little left behind

yeap! done.

Updated with working http server example.


[FLINK-20616][python] Support row-based operation to accept user-defined function directly

What is the purpose of the change
This pull request will support row-based operation to accept user-defined function directly
Verifying this change
This change added tests and can be verified as follows:

IT test in test_row_based_operation.py

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@dianfu Thanks a lot for the review. I have addressed the comments at the latest commit.


Add support for proxies when installing bzBond-server

This can be via an argument

We'll also need instructions for running the install scripts with a proxy


TLS issue: LN: SSL_accept failed (sslv3 alert bad certificate)

Hi,
I'm trying to connect to the server using TLS. I have followed the README and issues that other have raised but upon connection the server always giving the same error:  [ERR]: LN: SSL_accept failed (sslv3 alert bad certificate). I'm using the xmls and certificates provided in the repo under example_configuration and all the dependancies are the latest to the date.
Please suggest what am I doing wrong.

Server side
sysrepocfg --edit=tls_keystore.xml -m ietf-keystore
sysrepocfg --edit=tls_truststore.xml -m ietf-truststore
sysrepocfg --edit=ls_listen.xml -m ietf-netconf-server
netopeer2-server -dv2

Client side
netopeer2-cli
cert replaceown  ./example_configuration/tls_certs/client.crt ./example_configuration/tls_certs/client.key
cert add ./example_configuration/tls_certs/ca.pem

connect --tls --host <IP_ADDRESS>
nc ERROR: SSL_connect failed (certificate verify failed).
cmd_connect: Connecting to the <IP_ADDRESS>:6513 failed.

cert display
-----ca----- serial: 45ce2c8a91ef25294dad0221461662941bd5e11a
Subject: C=CZ, ST=South Moravia, L=Brno, O=CESNET z.s.p.o., OU=TMC, CN=example<EMAIL_ADDRESS>Issuer:  C=CZ, ST=South Moravia, L=Brno, O=CESNET z.s.p.o., OU=TMC, CN=example<EMAIL_ADDRESS>Valid until: Sep  1 10:21:01 2031 GMT

cert displayown
OK: Using *.crt certificate with a separate private key.
-----CRT----- serial: 47f82c15c5f3457a6d35a7ea427f46e71ca49fc0
Subject: C=CZ, ST=South Moravia, L=Brno, O=CESNET z.s.p.o., OU=TMC<EMAIL_ADDRESS>Issuer:  C=CZ, ST=South Moravia, L=Brno, O=CESNET z.s.p.o., OU=TMC, CN=example<EMAIL_ADDRESS>Valid until: Sep  1 10:28:18 2031 GMT

Thanks,
Pavel

The answer is in the README, second paragraph. Server hostname (<IP_ADDRESS>) comparison with the identity in the certificate (localhost) fails.

Thanks for pointing it out to me. If I understand correctly, in order to work outside the local host I have to provide my own certificates and update the xml files?

Yes, that is how the requirements are specified so the example certificates can really be used only for basic testing of the TLS connection. Although that may not be a bad thing.

Ok thanks a lot.
Then a quick question if I may regarding listen.xml. In the xml the ca fingerprint is
02:20:E1:AD:CC:92:71:E9:EA:6A:85:DF:A7:FF:8C:BB:B9:D5:E4:EE:74
but when I check ca fingerprint with openssl, it doesn't have the first '02':
openssl x509 -noout -fingerprint -inform pem -in ca.pem
SHA1 Fingerprint=20:E1:AD:CC:92:71:E9:EA:6A:85:DF:A7:FF:8C:BB:B9:D5:E4:EE:74
Am I suppose to add it to the fingerprint by myself?
Thanks

Yes, you need to add it yourself. It is always advised to read the description of the value you are setting.


Don't restrict number of trades and transactions in UI history

To avoid that trades and transactions may not be shown in the UI, the default values of the "transactions to consider" is raised to 65535.
This value was almost arbitrarily chosen, and should be high enough to be perceived as "unrestricted".
The PR resolves #208.

While looking at the code I noticed the behavior of trade and transaction history is actually different:

the trade history is restricted by the number of wallet transactions
the transaction history is restricted by the number of Omni wallet transactions

At some point we should tackle this for consistency, and investigate whether the transaction retrieval (and parsing), or the generation of UI elements, is the major factor of potential performance hits.
If I recall correctly, then experiments in the past have shown that inserting many dummy entries (without transaction retrieval) can create UI freezes.

To avoid that trades and transactions may not be shown in the UI, the default values of the "transactions to consider" is raised to 65535.

Reviewed, straight forward change, OK to merge :)

While looking at the code I noticed the behavior of trade and transaction history is actually different

Noted, let me take a look at this :)


ADSBlol feed using adsb-feeder-image erroring out?

Dear all,
I wanted to feed to ADSBlol so as per the instructions (https://www.adsb.lol/docs/hardware/adsb-equipment/) I ordered an AirNav RadarBox FlightStick and the pertaining antenna. Initially I tried the 'bare metal' command line approach but since I could not get it working I switched to the approach of using an adsb-feeder-image (https://adsb.im/howto). I followed all the steps but after the html dashboard page where I select the aggregators I want to feed to, the following page and after a couple of minutes the following html alert appears:

Is there any easy solution to this? I have to admit that Im unsure what it means. If for context purposes it is of any help, this is my hardware (so flight hardware as stated above, RPi is the Zero 2W. Kitchen environment only temporary location for testing - please ignore the kiwifruit)

If anybody has a solution to this, please let me know, greatly appreciated :) Thanks!
Sebastiaan.

Hi Sebastian,
For help with the adsb.im image, you can look at the adsb.lol zulip organisation
https://adsblol.zulipchat.com/#narrow/stream/391168-adsb-feeder-image
This repo is for the docker feed toolkit or the bare metal install.


feat: add Metadata to couchbase Event, all metadata related fields moved in

i park this to re-evaluate it in case of need. currently exposing vbID enough for our needs.


PipelineSucceededRun is missing a trailing "s"

@kipphoward : Thanks for your contribution! The author(s) have been notified to review your proposed change.


debug command to bot causing game client crash

Issuing any debug (debug, debug move, etc) command to a bot instantly crashes the game client.
Suspect there's some malformed packet being sent to the client.
Using US client, no mods, tried with no addons.
I don't know what kind of information is supposed to be sent with the debug command.

Would you be able to provide a screenshot of the crash window?

I have the same issue


Documentation about Google credentials should mention "Project Lead" as well as "Release Manager" role

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
Documentation about Google credentials should mention "Project Lead" as well as "Release Manager".
I think it would be a good idea for these instructions:
https://docs.fastlane.tools/getting-started/android/setup/#collect-your-google-credentials
to mention other roles beside Release Manager in this step:

Choose Release Manager from the Role dropdown

because the Release Manager role allows one to modify the production track APK.  People reading this documentation may not want to modify (or may not want to be able to modify) the production track.  The Project Lead role allows one to modify all tracks except the production track which is what I found was appropriate for what I need to do.
Command executed
fast lane apply -b path-to-APK
Complete output when running fastlane, including the stack trace and command used

 Output was as expected for successful update of the APK in Google Play.
Not relevant for this documentation change request

Environment

Not relevant for this documentation change request.

Good point. Could you create a PR to https://github.com/fastlane/docs/blob/master/docs/includes/google-credentials.md with the appropriate description? Thanks.

Did you have time to find out if you are allowed to do this @ChuckTownsend? Or could you possible do it after work?

Sorry for the delay. I now have permission to make this change and will create the PR shortly.


After last update, buggy on some browsers including Chrome on IOS

Some pages that had this script when are open on iOS iphone using Google Chrome, gets redirected to
tackchen.gitee.io

Fixed in v0.3.1, thank you for your issue.

@pqpier


Make sure every page has an SEO tag

Example Usage

[x] 404
[x] admin
[x] apply
[x] interest-form
[x] login
[x] logout
[x] room
[x] timeslots

Completed in 229a339653943ada21b3d02f8a065d9dfd2118c3


Testers

I need some brave testers: https://github.com/bitbeans/SimpleDnsCrypt/releases/download/0.4.5-alpha3/SimpleDNSCrypt64.msi
Feeback of any kind is welcome! :)
Thanks again to all translators!
https://poeditor.com/join/project/3frSzJtSqc

I can't seem to get DNScrypt service to start.
Windows 10 Home
Version 1709
Build 16299.192

Works beautifully here. Can finally stop using powershell scripts :) One bug is that after using the remove service option in advanced settings it does not indicate that the services are removed.

Good here on win 10 1709 pro. I had to reinstall the <IP_ADDRESS> dns address. Will try soon on home edition.Not currently using ipv6, need to get back in that.
Thanks
On Thursday, February 1, 2018 6:19 PM, Sporif<EMAIL_ADDRESS>wrote:

Works beautifully here. Can finally stop using powershell scripts :) One bug is that after using the remove service option in advanced settings it does not indicate that the services are removed.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

DNScrypt service still will not start for me. Not sure what info i can share to help with this issue.

@evilvibes have you tried uninstalling an old version? also try to stop the service if it is already installed?
There is now also a log folder, is there an error log?

Yes i did tried all that been trying to get it to work for few days now. I'll have a look at the log folder now.

Well after all that i had to go into regedit and manually delete  HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\EventLog\Application\dnscrypt-proxy
I now have it running.

Running excellent here. Will have to evaluate in detail later. Thank you again for this Most Excellent project.

Yup no issues at all now that i have it running. Awesome work @jedisct1 & @bitbeans

When browsing to web sites in Chrome, I frequently get an error name resolution failed message. However, if I wait a few seconds, it refreshes and the web page loads.

Weirdly, with the stable 0.4.5 version (haven't tested the alphas, sorry), the dnscrypt-proxy service does not seem to get properly installed/registered here. I am unable to start the service and, contrarily to the previous 0.4.3 version, no dnscrypt-proxy services are present in the Windows Services list. Any clue? (I removed the older version before installing the 0.4.5, just to be sure.)
Also, you are probably aware of this, but some translation strings are still unavailable to be translated! Other than that, thank you for your work!
Windows 10 x64, v1709

@medack are there any logs? C:\Program Files\bitbeans\Simple DNSCrypt x64\logs

@medack i have the same problem with the stable version 0.4.5 in my windows 10 pc, can't find any log at program files either

@medack @alfazaki maybe you have the same problem as @evilvibes
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\EventLog\Application\dnscrypt-proxy

@bitbeans thanks for your response, i tried @evilvibes tips delete
HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\EventLog\Application\dnscrypt-proxy
and to make sure i do it 2 times and tried to install/uninstall/restart pc
service still not running, everything normal in previous version, any other tips?

@alfazaki yes, open a shell and check the output of:
cd "C:\Program Files\bitbeans\Simple DNSCrypt x64\dnscrypt-proxy\"
.\dnscrypt-proxy.exe -service -install

@bitbeans Yep, that done it, but with a small modification in your line:
dnscrypt-proxy.exe -service install
May be this is also wrong in the setup routine?

@medack was there an error in the output? hmm yes i will check this again later.
this is the current uninstall: https://github.com/bitbeans/SimpleDnsCrypt/blob/master/Uninstall/Program.cs (any improvement is welcome) :)

@bitbeans Yes, with the extra "-", got an "Unknown action" from the dnscrypt-proxy.
My programming skills are relatively limited, but I will take a look at it. Just a question: why do we have now that service uninstall option? Doesn't it make sense only when you uninstall Simple DnsCrypt?

@medack it`s not a new option: https://github.com/bitbeans/SimpleDnsCrypt/blob/master/img/old/advanced.png

@bitbeans True! I guess I didn't need to tweak anything in SimpleDNSCrypt for so long that I forgot what the advanced options looked like. Anyway, just a heads-up: updated a few minutes ago to 0.4.7 and everything is working well so far. Fantastic work, thank you!


NPM/node requirements?

Getting the following on macOS Catalina after running npm install and then npm start:

><EMAIL_ADDRESS>start /Users/....../Downloads/zonote-master
> electron . --dev

(node:96905) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'isMaximized' of undefined
    at start (/Users/johngoering/Downloads/zonote-master/src/main/main.js:40:27)
(node:96905) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:96905) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I'm sorry I was unable to catch this bug because the module I use to store state uses the home folder, so I was using my saved state all this time and never had to deal with a new state.
It should work now.


Added Direct Download Badge for Windows, MacOS and Linux

PR Checklist

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[x] Documentation changes
[ ] Other - Please describe:

Fixes
Issue Number:
What is the current behavior?
What is the new behavior?
Other information

Great idea! Could you change these buttons all to blue?

I made that change.


invalid Oauth2 redirect_uri

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

If possible

NodeJS version: lastest
Bot version: latest

Additional context
to connect dasboard
sorry i am french men

https://docs.strangebot.fun/additional/installation#setting-up-dashboard


Fixed small typo

Fixed small typo in the code missing ( at line 336

Docs Build status updates of commit baf429e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/how-to-insert-a-chart-into-a-spreadsheet.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Use SignalStrength for format icons

This adds the ability to set format icons similar to the pulseaudio module.
A config for this could look like this (Needs FontAwesome Pro):
"format": "{icon}",
"format-icons": {
  "wifi": ["", "" ,""],
  "ethernet": [""],
  "disconnected": [""]
}

Also if fixes getIcon() in ALabel.

Thanks!


Sébastien Lorber's problem

Reference: https://github.com/evancz/elm-architecture-tutorial/issues/50
We need 3 ingredients:

a base app (i.e. a simple counter)
a compose(app1, app2) function in order to compose 2 apps
a new component that will display a value based on the following rule:

The value should increment by one on any counter increment
The value should decrement by one on any counter decrement
The value should never be more than 3 and less than 0 (if we increment with value 3, the value stays 3)

Prelude: tom typings
interface IState<Model, Effect> {
  model: Model;
  effect?: ?Effect;
}

type Dispatch<Event> = (event: Event) => void;

interface IConfig<Model, Effect, Event, View> {
  init: () => IState<Model, Effect>;
  update: (model: Model, event: Event) => IState<Model, Effect>;
  view: (model: Model, dispatch: Dispatch<Event>) => View;
  run?: (effect: Effect, event$: Observable<Event>) => ?Observable<Event>;
}

1. The base app: a simple counter
Implementation
Typings
type CounterModel = number;
type CounterEffect = void;
type CounterEvent = 'INCREMENT_REQUEST' | 'DECREMENT_REQUEST';
type CounterView = React.Element;

counter: IConfig<CounterModel, CounterEffect, CounterEvent, CounterView>

2. The compose function
Implementation
Typings
declare function compose<Mx, My, Effx, Effy, Ex, Ey, View>(x: IConfig<Mx, Effx, Ex, View>, y: IConfig<My, Effy, Ey, View>): IConfig<[Mx, My], [?Effx, ?Effy], [?Ex, ?Ey], View>;

3. The top level component
Implementation
Typings
// these typings come from the `compose` function
type PairModel = [CounterModel, CounterModel];
type PairEffect = [?CounterEffect, ?CounterEffect];
type PairEvent = [?CounterEvent, ?CounterEvent];
const pair: IConfig<PairModel, PairEffect, PairEvent, CounterView> = compose(counter, counter)

type TopModel = {
  count: number;
  pair: PairModel;
};
type TopConfig = IConfig<TopModel, PairEffect, PairEvent, CounterView>;

/cc @slorber

Closing in favour of repo https://github.com/slorber/scalable-frontend-with-elm-or-redux


Counting users by role on the custom email sending admin page takes too long

For some reason the send custom email admin page uses the awful and old statistics endpoint to gather information about the different user roles that are available in the system to email.
We should use a proper database query for this rather than try and do it in Java. (especially now we have a proper database)

Fixed by 448f1d7c5a60b638d77aeb35d33196449de7613e when merged


security/acme-client: add DNS API support for DNSExit

Since 2 months official Acme.sh has support for method DNS API support for DNSExit. Is it possible to upgrade this Plugin with official Acme.sh so we have support for DNS Exit? Thanks in advance!

Fixed in https://github.com/opnsense/plugins/pull/3732.


Update metric exporter to v0.7.0 compat

@googlebot I signed it!

@googlebot I consent.
There is no other authors on this comment.

Thanks for your work on this PR! See my comment above re DELTAs vs CUMULATIVEs. Are you able to make that change and run a test app to validate this works correctly?
If not, we should be able to get someone from Google to look into this in the coming weeks.

@marvinkite @james-bebbington I've rebased and squashed this in #73, left @marvinkite as author


Dissallow test/modification of some properties

Hi we have some Classes where we apply modifications using the Patch object, but there are some Properties we don't want to allow tests or changes.
They currently have a Attribute on them, is there someway we could throw a exception when SystemTextJsonPatch tries to access them?

What about using ValidationAttribute?

@Havunen We could absolutly use ValidationAttribute, but where and how would we check if a property has the attibute when running ApplyTo?

This feature request would combine modelstate validation and ApplyTo
https://github.com/Havunen/SystemTextJsonPatch/issues/6
until that is implemented, it needs to be done manually

After reading the PR's in the linked issue, i don't think that validation would suffice as i can't check if a value has changed using validation?
It seems to be more oriented to validating a value of a field, like An email must contain @ and a valid domain.
But in this case we want to deny the Json Patch access to some properties.
I can see 2 solutions to this issue:

To have some sort of Callback where you can return true or false after fetching a property, and if false throw an exception.
Add a custom Attribute, like DenyAccessToJsonPathAttribute (or some better name) and check if the property has that attribute, and then throw a exception, this check could be done in PropertyProxyCache.FindPropertyInfo

If the second option would be acceptable for you, then i could create a PR.

One approach could be to have specific input model for the http patch routine where those properties are not allowed.
I started thinking that if we introduce DenyPatchAttribute is the next feature request to configure it based some logical operation?
Well maybe we could start with simple approach and see if it ever becomes a use case.
If you would like to see this implemented PR is welcome.
This could maybe go into next major version as I would like to refactor the exception type as well

@Havunen PR created :), One thing that might be nice but would require a bigger rewrite would be to include the full path in the exception that is thrown. But there is no need to do that for the first release in my opinion.

@Havunen Any idea when a new nuget can be released with this functionality? (We need it before we go into production)

Soon

Release 3.3.0 has been published https://github.com/Havunen/SystemTextJsonPatch/releases/tag/v3.3.0

Thanks for the fast release, it works great :)
But i managed to find one way you actually can write to a Property marked with DenyPatch, when the property is in the value field.
For our software this is fine, but it might be a security leak for someone else, maybe a line about it should be added to the readme?
Example:
[{"op":"add","path":"/safe/1","value":{"deny":"sneaky"}]

In this case the deny property was marked with [DenyPath]

Can you create separate issue for that please. It would be nice if you could patch that functionality

Okay lets document it then, could you send the PR for the doc update please?


sword of the frog, blowback

Maybe a feature but IMO the blowback on this weapon rather weakens it.
Even from one hit kills the hero ends up chasing a body across the room.

Got it; thanks for the bug report! Now the Sword of the Forgotten is way more awesome.

Is that the name? Heh, funny place for the string to truncate on my display.


Azure Storage website with Application Gateway

There is missing documentation how to configure Application Gateway in front of Azure Storage website. There must be defined custom probe -<EMAIL_ADDRESS>Please update docs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dcd3f99a-f522-6edb-6d39-eac1bb917956
Version Independent ID: 69e9c1e5-8deb-8092-46f4-6646d076fbe4
Content: Static website hosting in Azure Storage
Content Source: articles/storage/blobs/storage-blob-static-website.md
Service: storage
Sub-service: blobs
GitHub Login: @normesta
Microsoft Alias: normesta

@jjindrich Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Thank you for this suggestion. I've added a work item to our backlog to explore this as a future article.

#please-close

@normesta is these any update on this documentation?

Hi @rbaker26. We don't yet have a formal document that describes the proposed process (Application Gateway + static websites).

@normesta
Last night, I was able to figure this out for a static website hosted in Blob Storage but not yet for Static Website GitHub Preview.
I see in the Contributing documentation, there is a section outlining edits to existing pages.
If I were to write out my findings and steps, is there a way to create a new page for this?
I am happy to help with this but want to make sure the time will not be wasted due to process/red-tape.
If this is possible, is there any Guidelines or Standards for new pages that you can share with me?
Thanks

Hi @rbaker26 that's great. Thank you for offering to help. We do have a public contributors guide here (mostly for edits to existing) - https://docs.microsoft.com/en-us/contribute/. RE: a new article, I'd be happy to collaborate on getting one into our docs, but there's a few things I need to investigate internally. Would you mind starting a chat on email with me directly? My email is my GitHub user name +<EMAIL_ADDRESS>Thanks again!

Hi @rbaker26 - Just an update. I've been coordinating with some other internal teams. I've moved this work item into our January sprint so I'll assemble some content. With cross-service, I'll need to figure out the best location, coordinate with the App Gateway team, and try to avoid duplicate content/procedures if possible. BTW - have you seen this post? - How to configure Application Gateway in front of Azure Blob storage? Perhaps if you have a chance, you could have a look and let me know if you had to do anything different (specific) to get static websites working? If not, no worries! I appreciate the ping. Sometimes with so many doc requests, these things can get a bit lost in our backlogs.

@mihaipanait
Here is a screenshot of my custom Health Prob.
I am in the process to typing up my exact steps.
Also make sure you enabled "anonymous access for blobs" in the Storage Account.

@rbaker26 thanks! It works indeed when using HTTP.
In my case i was using HTTPS between the Application Gateway and the storage account, so the probe was set to use HTTPS. But i think it is not an issue. Serving static files shouldn't require SSL end to end.

@normesta - Can you please let us know if there is any update on the MS official document that describes the steps to Integrate Application gateway with static website?Thanks

Waiting for the doc and answer too


fix: add check_mode in localhost binary cache task

This PR adds the check_mode: false in the localhost binary cache task.
This is needed because the next task, which downloads the prometheus binary, expects the folder to already be created. Without check_mode: false, the task only runs in "simulation" mode and doesn't create the folder.
This code was introduced in the most recent PR #425: https://github.com/prometheus-community/ansible/pull/425/files#diff-c9a8a7fbd7ee9c40d13e4be2e88801e621b943a2246b78ad46b93dc0f7c33971R38
You can see that this task did not exist before: https://github.com/prometheus-community/ansible/pull/425/files#diff-6f9278158452a81913bff59d794daa00e142796b04e75efd873c4a5dbb7f2899L38
Fixes #430

LGTM! Thanks @santilococo!

Can we get this important bugfix reviewed, merged, and released ASAP?

Same problem on our side. LGTM :rocket:

Test errors are due to github rate limits. Will retry them.

@gardar do we really need to run all the role tests when updating _common?

Yeah since it's affecting all the roles I'm afraid it's the only way to catch potential errors.
But I agree, the number of tests is getting pretty ridiculous 😅, I think we need to tone it down a bit.

I think for _common we can get enough coverage by just testing the prometheus role.

Great, thanks! LGTM!

Maybe in a follow-up PR, but could it make sense to mark all these download-related tasks as changed: false. In our container-based Ansible controller setup, these tasks are always marked as changed - which is correct.

Maybe in a follow-up PR, but could it make sense to mark all these download-related tasks as changed: false. In our container-based Ansible controller setup, these tasks are always marked as changed - which is correct. But pretty annoying when looking at the summary of the play.

No I don't think that's a good idea to fake the "changed" status like that, you should be able to see when the download is actually being executed.
I'd suggest you use a persistent volume for the local cache path instead, it should save you some download time and you would avoid being rate limited by github.

It also appears that Prometheus is always restarted (by running the restart handler). I think this is caused by this unnecessary "changed" tasks, but not 100% sure. I will monitor this bad behavior when a new release is out.

No the download tasks don't notify the handlers, so there must be some other task that's returning the changed status.

Maybe in a follow-up PR, but could it make sense to mark all these download-related tasks as changed: false. In our container-based Ansible controller setup, these tasks are always marked as changed - which is correct. But pretty annoying when looking at the summary of the play.

No I don't think that's a good idea to fake the "changed" status like that, you should be able to see when the download is actually being executed. I'd suggest you use a persistent volume for the local cache path instead, it should save you some download time and you would avoid being rate limited by github.

We have a proxy in-between, since GitHub is not directly available. Semi air-gapped environment. I think changes to the Ansible controller should be safe to ignore. But point taken, we can agree to disagree. 😉

It also appears that Prometheus is always restarted (by running the restart handler). I think this is caused by this unnecessary "changed" tasks, but not 100% sure. I will monitor this bad behavior when a new release is out.

No the download tasks don't notify the handlers, so there must be some other task that's returning the changed status.

Thanks! I will debug this when a new release is available.

A persistent disk is not a feasible alternative for us. Try getting that on GitLab Docker CI/CD runners!

We are getting way off topic here, but both github/gitlab offer cache features which you could probably use for that. If you figure out how to do it then it might be useful to add it do the docs 😄
https://docs.gitlab.com/ee/ci/caching/
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/caching-dependencies-to-speed-up-workflows#using-the-cache-action

No I don't think that's a good idea to fake the "changed" status like that, you should be able to see when the download is actually being executed.

I'm jumping in because I wanted to suggest the exact same check_mode: false fix and found this PR. However I would also argue that changed: false should be put on this folder creation and download tasks. Otherwise the role is not very clearly idempotent: running it twice still shows tasks as changed even though nothing changed on the remote host.
imo these downloads are anyway local prerequisites for the role to run correctly, they're not indicating any changed action on the remote host, that's the job of the Propagate binaries task


[WIP][1.4.x] Backport CI

Description
The CI in the v1.4.x is a bit out dated. Experimenting to see what it would take to update it to a more current state.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Much much more than expected


feat: Drop support old Node version

The commit should be marked as a breaking change because of dropping support for node.
So we have to add the !:
feat!: Drop support old Node version

The commit should be marked as a breaking change because of dropping support for node. So we have to add the !: feat!: Drop support old Node version

This is a PR to the feature branch major-version, so I think the ! should be added when the feature branch merge to main later.


fix: use Text for CollectionCard description

Pull Request Test Coverage Report for Build 128396848

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.114%

Totals

Change from base Build 126070139:
0.0%

Covered Lines:
1335

Relevant Lines:
1702

💛  - Coveralls


Use language mode at Cursor for onEnter Rules

Fixes #26351
bug
For the code
const x = |;

with the cursor at the |, our existing TS/JS onEnter rules should change the code to:
const x =
    |
;

However we currently do not handle this case correctly. The root cause is the extra semicolon at the end of the line. This causes getEnterAction to think that we are in a javascript context for the onenter rules instead of in a js-tags context
fix
Pass in the column of the cursor when getting the language id to use for the onEnter rules instead of using the end of the line. This ensures we are in the jsx-tags language in the above case

@mjbvz the PR looks good to me. While reviewing the code, I found a bug about afterEnterText and I already fixed on master. You may want to rebase to it and test.
There is only one case that you may want to tweak from JSX side
const x = abc
def

Let's say we select abc\ndef and press enter, IMHO it should behave the same way as delete abc\ndef and enter. So the expected result is
const x =
  |

Right now it's
const x =
  |

Thank you @mjbvz  :heart:
Shame this nice fix doesn't come with a test so we don't regress in the future.


Uploads: uploadData 400 Error

Environment details

OS: CentOS Linux release 7.6.1810
PHP version: PHP 7.2.34
Package name and version:
{
"require": {
"google/apiclient": "^2.12.1",
"cache/filesystem-adapter": "^1.1",
"laminas/laminas-httphandlerrunner": "^1.2"
}
}

The Issue
I would like to Upload data to Google Analytics Property. I using Service Account with editor permission in the property. After the management_uploads request I got this error:
PHP Fatal error:  Uncaught Google\Service\Exception: {
"error": {
"code": 400,
"message": "Request contains an invalid argument.",
"errors": [
{
"message": "Request contains an invalid argument.",
"domain": "global",
"reason": "badRequest"
}
],
"status": "INVALID_ARGUMENT"
}
}
in /home/hosting/www/storage.com/public_html/public/costUploader/sdk/googleads-php-client/vendor/google/apiclient/src/Http/REST.php:134
Stack trace:
#0 /home/hosting/www/storage.com/public_html/public/costUploader/sdk/googleads-php-client/vendor/google/apiclient/src/Http/REST.php(107): Google\Http\REST::decodeHttpResponse(Object(GuzzleHttp\Psr7\Response), Object(GuzzleHttp\Psr7\Request), 'Google\Service\...')
#1 [internal function]: Google\Http\REST::doExecute(Object(GuzzleHttp\Client), Object(GuzzleHttp\Psr7\Request), 'Google\Service\...')
#2 /home/hosting/www/storage.com/public_html/public/costUploader/sdk/googleads-php-client/vendor/google/apiclient/src/T in /home/hosting/www/storage.com/public_html/public/costUploader/sdk/googleads-php-client/vendor/google/apiclient/src/Http/REST.php on line 134
My code is
// Initialize Google Analytics Reporting Service
$analytics = initializeAnalytics();
try {
$analytics->management_uploads->uploadData(
'123456',
'UA-123456-1',
'122333444455555',
array('data' => file_get_contents('example.csv'),
'mimeType' => 'application/octet-stream',
'uploadType' => 'media'));
} catch (apiServiceException $e) {
print 'There was an Analytics API service error '
. $e->getCode() . ':' . $e->getMessage();
} catch (apiException $e) {
print 'There was a general API error '
. $e->getCode() . ':' . $e->getMessage();
}
function initializeAnalytics() {
$KEY_FILE_LOCATION = DIR . '/sdk/googleads-php-client/service-account-credentials.json';
// Create and configure a new client object.
$client = new Google_Client();
$client->setApplicationName('Google Analytics Cost Uploader');
$client->setAuthConfig($KEY_FILE_LOCATION);
$client->setScopes(['https://www.googleapis.com/auth/analytics','https://www.googleapis.com/auth/analytics.edit']);
$analytics = new Google_Service_Analytics($client);
return $analytics;
}
Thanks!

Hello, I have the same problem. It worked fine until 2022-09-12, but now I'm getting the same error. It seems that the problem is in google api itself, not in the library. Does somebody know what's happened? Were there any breaking changes in API?

Same problem here too. the uploadData returns a bad request invalid argument error since 2022/09/12

Has anyone tried with curl?
curl -X POST -F "upload=@example.csv;type=application/octet-stream" "https://www.googleapis.com/upload/analytics/v3/management/accounts/XXXXX/webproperties/UA-XXXXX-1/customDataSources/XXXXX/uploads?access_token=" -v

Has anyone tried with curl?
curl -X POST -F "upload=@example.csv;type=application/octet-stream" "https://www.googleapis.com/upload/analytics/v3/management/accounts/XXXXX/webproperties/UA-XXXXX-1/customDataSources/XXXXX/uploads?access_token=" -v

Have tried, the same problem:
 We are completely uploaded and fine
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* TLSv1.3 (IN), TLS handshake, Newsession Ticket (4):
* old SSL session ID is stale, removing
< HTTP/2 400
< x-guploader-uploadid: ****
< vary: Origin
< vary: X-Origin
< vary: Referer
< content-type: application/json; charset=UTF-8
< content-length: 285
< date: Wed, 14 Sep 2022 20:09:13 GMT
< server: UploadServer
< alt-svc: h3=":443"; ma=2592000,h3-29=":443"; ma=2592000,h3-Q050=":443"; ma=2592000,h3-Q046=":443"; ma=2592000,h3-Q043=":443"; ma=2592000,quic=":443"; ma=2592000; v="46,43"
<
{
  "error": {
    "code": 400,
    "message": "Request contains an invalid argument.",
    "errors": [
      {
        "message": "Request contains an invalid argument.",
        "domain": "global",
        "reason": "badRequest"
      }
    ],
    "status": "INVALID_ARGUMENT"
  }
}


fix: upgrade to version 3.1.97

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign garethjevans
You can assign the PR to them by writing /assign @garethjevans in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign garethjevans
You can assign the PR to them by writing /assign @garethjevans in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test vault

gsm
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test vault

gsm
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test vault

gsm
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test gsm

kube
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jenkins-x-bot-test: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

vault
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test vault

gsm
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test gsm

kube
ccbc0a668357152b9c6af461b7f27341b70178c7
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Add docs for Mapzen.js

Takes content from readme and adds to docs folder, which can then be displayed on mapzen.com. These are good enough for initial posting.

Looks great! It seems like the API documentation is in the README and in api.md - can we remove the README copy so there's exactly one?


AssemblyReader fails to parse assemblies containing ReflectedDefinitions

Problem: AssemblyReader fails to parse assemblies containing ReflectedDefinition
How to reproduce: the pull request contains a test case (fix and test case separate commits)
My fix looks useful but further testing might be needed...
EDIT: in my first commit i forgot my test assembly. the last commit fixes this.

Could you add the source for ConsoleApplication.exe please? thanks

i attached the main file.
the code as complete solution is here: https://github.com/haraldsteinlechner/FSharp-data-test-case

Great, thanks


chore: linting, formatting and their configuration

We should probably get this out of the way before working on other issues. This is the initial setup of prettier & eslint. We could use the "airbnb" plugin or whichever you think will suit the project.
Let me know what to add/change in the configuration. I haven't set up linter and formatter together on my own before so I bet there are changes pending.

Nice! Code style is always very personal, so it's good to pick a standard and stick with it.
My personal preference is (as you might suspect) double quotes and semicolons, but it is probably more common to just follow the airbnb style guide. This makes it easier for other potential contributors. Can you configure eslint thusly and let prettier follow suit? Plugins allowed.

We may also want to add linting to our build.yml via npm run lint, i.e. before the following rules
https://github.com/arothuis/markdown-it-biblatex/blob/edc43bfe644d68c9ee318f382ba4cd9280960870/.github/workflows/build.yml#L24-L26

Added airbnb configuration, which prefers single quotes so I left that in .prettierrc.
I also have overwritten some configurations regarding "param reassign" and "use before defined", because it seems like you are deliberately going for it at several places and I don't have a problem with that. I disabled "no-udef" rule for the test file, because the mocha cli recognizes those functions that eslint thinks are undefined.
The lint command has also been added to build.yml.

Thanks for the update! I might use these settings for my other markdown-it plugins as well.
Just one remark. Perhaps we can add our global dependencies (node, mocha and chai) to our env settings in eslint, so we don't need to allow undefined identifiers.

Added node and mocha to the env, no more eslint errors for the test file. The chai is not recognized by eslint, but it causes no problems without it either. Let me know if I should manage that or anything else.
There is eslint-plugin-chai-friendly we could use.

 Thanks for your changes and patience. Will merge.


Fix Deadlock Issue in Control Plane service

Modification:
A mistake in #1022 caused a deadlock in the control plane executor. The issue arose because the thread was waiting on a future to complete, but it needed to execute and complete that future itself, leading to a deadlock. https://github.com/line/centraldogma/pull/1022/files#diff-f99a1af4ac33cff7d57aea503c56b19cbadb765e6b1a48067de36c1998b367acR117 https://github.com/line/centraldogma/pull/1022/files#diff-f99a1af4ac33cff7d57aea503c56b19cbadb765e6b1a48067de36c1998b367acR115
Modifications:

Changed to wait on the startup thread instead of the control plane executor.

Result:

The deadlock issue during the control plane service startup has been resovled.

Question) Was there no way to test this issue? I'm surprised this wasn't caught in the CI in this repo, but it was caught in our internal repo

Was there no way to test this issue? I'm surprised this wasn't caught in the CI in this repo, but it was caught in our internal repo

Let me add a test case for this. I need another plugin that creates an xds repository before startup.