fix incorrect result of mark join in nested loop join (#31280)

Proposed changes
pick #31280 from master into branch-2.0
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


Revisions list doesn't show current published state

When reviewing revisions for a page there is no indication of which revision is currently live.
I've attached a mock-up. Could probably improve the visual design here but thought I would start basic.

Implemented in #3302


Manage Users as  a Champion

On the manage users page, it would be useful to have the ability to search for a specific user by name or by user type e.g show all ninjas over 13. Currently all users are listed in random (non alphabetical order. This feature should be accessible by anyone with Dojo admin / ticketing permissions.

G

:+1:

In this section it would be good to have a feature to export all users to CSV.

Sort users alphabetically also

So, then it would be:

Being able to filter users by name/user type
Sort users by name (both in web and csv)

?

@andresiglesias Yes, both sorting functions, and then the csv would be generated based on the sorting currently on the page.

For more information on creating test data so you can see the manage users page, see this doc. The main readme file is here.

The manage users controller is here
The template for this controller is here
You'll also need to take a look at the users service, the backend section of the system.

Let me know if you have any questions, usually around on the Gitter!

Done by @SlashmanX :+1:

Search implementation is unfinished as multipage search is not working as intended (ie:: no results are found for the next pages)

Fixed by @butlerx


[BACKLOG-17271] Minor cleanup.

Defensive null checks, and variable subitution for
FileStream parameters.

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'plugins/file-stream/pom.xml' -pl '.' -P '!assemblies' -amd clean install && mvn -B -f 'plugins/file-stream/pom.xml' -pl '.' -P '!assemblies' -amd site
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'plugins/file-stream/pom.xml' -pl '.' -P '!assemblies' -amd build-helper:remove-project-artifact && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStep.java
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStepMeta.java
  plugins/file-stream/src/main/java/org/pentaho/di/trans/step/filestream/FileStream.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.systemdata.SystemDataMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -2% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.ui.repository.pur.repositoryexplorer.model.UISecurityRole

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupdate.SalesforceUpdateMeta

Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'plugins/file-stream/pom.xml' -pl '.' -P '!assemblies' -amd clean install && mvn -B -f 'plugins/file-stream/pom.xml' -pl '.' -P '!assemblies' -amd site
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'plugins/file-stream/pom.xml' -pl '.' -P '!assemblies' -amd build-helper:remove-project-artifact && mvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  engine/src/main/java/org/pentaho/di/trans/streaming/README.md
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStep.java
  engine/src/main/java/org/pentaho/di/trans/streaming/common/BaseStreamStepMeta.java
  engine/src/main/java/org/pentaho/di/trans/streaming/common/FixedTimeStreamWindow.java
  engine/src/main/resources/org/pentaho/di/trans/streaming/common/messages_en_US.properties
  plugins/file-stream/src/main/java/org/pentaho/di/trans/step/filestream/FileStream.java
  plugins/file-stream/src/main/java/org/pentaho/di/trans/step/filestream/FileStreamMeta.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: -0.1% (click to expand)
org.pentaho.di.core.injection.bean.BeanInjector

Branch Change: -0.8% :small_red_triangle_down:
Complexity Change: -1.3% :small_red_triangle_down:

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -0.5% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.checksum.CheckSumMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.ldapoutput.LDAPOutputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -5.6% :small_red_triangle_down:
Complexity Change: -6.5% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.5% :small_red_triangle_down:

org.pentaho.di.trans.steps.pgbulkloader.PGBulkLoaderMeta

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.rowgenerator.RowGeneratorMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.webservices.WebServiceMeta

Branch Change: -1.7% :small_red_triangle_down:
Complexity Change: -1.2% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/plugins/file-stream/src/main/java/org/pentaho/di/trans/step/filestream/FileStream.java

:heavy_exclamation_mark: '|' is not preceded with whitespace. at Line: 108 Column: 33

@pentaho/ackbar


Refactor components props

The goal of this PR is to improve the way we compose universalDefaultProps and universalPropTypes.
By moving the destructuring statement on top of the object we ensure that any of the properties listed will not be overwritten by the defaults.
For example
var foo = {
  name: 'proton'
};

var barNotOk = {
  name: 'this will not work',
  ...foo
};

var barOk = {
  ...foo,
  name: 'this will work'
};

console.log(barNotOk); // { name: 'proton' }
console.log(barOk); // { name: 'this will work' }

Makes sense, thanks!


feature request: support temperature range

Hi, could you please help to support the temperature range in a day?
eg: -3℃ ~ +6℃

With the JSON-output format the range can be generated by combining the min- and max-temperature fields, e.g. https://wttr.in/London?format=j1
{
    ...
    "weather": [
        {
            ...
            "date": "2023-04-23",
            "maxtempC" "15",
            "maxtempF": "59",
            "mintempC": "8",
            "mintempF": "47",
            ...
        }
    ]
	...
}


Keep .meta files in version control, ignore in root dir only

Not having meta files causes them to be regenerated on every user's
computer, each with a different GUID. This makes it impossible to open
the scene/prefab files on different computers - Terminal will instead be
represented as "missing script".
This change fixes this problem by only ignoring meta files in root dir -
meta files in CommandTerminal and all other subdirectories will not be
ignored by git.

Note that this will break the references to console (Terminal script) in scenes/prefabs on every user's machine after they update (because GUIDs in their own meta files will change), but that'll be the last time they'll have this problem.

I don't see how this is a problem, when users import the scripts for the first time, new meta files are created. Those meta files can be committed to your project's repository, meaning they would be consistent across machines.

That can be problematic for users that'd like to import it as a git submodule/subtree.


CWT Signature Envelope

This PR shows a CWT alternative to COSE (#139) without the use of custom COSE headers except timestamp.

Thanks @shizhMSFT for posting this as an option. I think we've agreed we want to CWT.
ping @henkbirkholz for some details, but suggest we close this one and focus on #139


Generate metrics about running compactions.

When the tablet servers were responsible for compactions they emitted metrics for internal and external compactions that covered all of the tablets they were hosting.  One could aggregate the metrics from the tablet servers and determine how many total compactions were running in each compaction group.  Now that the tablet servers are no longer emitting these metrics, something else should probably emit them.

Had a call w/ @ddanielr  to discuss #3551 and we discovered this functionality was now missing.  We were thinking maybe each compactor should now emit metrics about how many compactions its running for the group its in.  Each compactor would emit a 1 or 0 for this metrics and those could be aggregated in the query system.


Develop

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@0206e47). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #35   +/-   ##
==========================================
  Coverage           ?   20.16%
==========================================
  Files              ?        5
  Lines              ?      248
  Branches           ?       33
==========================================
  Hits               ?       50
  Misses             ?      198
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0206e47...d200ca8.


Unregistred class error, on the 'Set data = wrapper.GetCardData()

Hello,
As many, I'm looking for a new dll to be able to read new Belgium identity card.
I use VB6 and was happy to find this great share community.
I tried the given code to read Belgium card, but I'm having trouble, here's my test code :

Of course, the EID.Wrapper.tlb is well referenced in the project.
Unfortunately, on the line :
Set data = wrapper.GetCardData()
return the error : unregistered class
Is there something missing ? A module class ?
I thought everything was in the dll.
I'm sorry, but I really don't understand what's missing. Hope you can help me to understand.
Many thanks in advance, have all a nice chrismas day,
Fab

Hello Fab,
I have the same issue. Did you find the solution at this problem?
thanks

Hello, I find the solution.
I used the wrong self register exe. My office is a 32bits then I need to use the x86 version of the self register executable.
Now it works fine.
Regards
O.

Hello ovt001,
Thank you for your answer.
I'm not sure to understand what you mean.
As the dll is not readable for VB or VBA, I've used Regasm.exe which create a EID.wrapper.tlb file, that can be used in reference by VB or VBA. At this point, I have a unregistred class error as I described.
So, what self register executable do you use ?
Can you please be more spécific ?
Thank you again,
Fab

Hi FabFr
did you follow the Installation steps specified in the ReadMe? The zipfile that contains the DLL also contains a utility that can be used to install and register the DLL so it can be referenced correctly from your application. That tool does the required RegAsm work for you. Also, make sure you use the right version (it's most likely 32-bit as 64-bit Office installations are not that common) as outlined in the readme.

Hello Fab,Call me. It will go faster+32 476 47 00 84Envoyé depuis mon appareil Galaxy
-------- Message d'origine --------De : FabFr @.> Date : 24/01/22  15:44  (GMT+01:00) À : "jdt/EID.Wrapper" @.> Cc : ovt001 @.>, Comment @.> Objet : Re: [jdt/EID.Wrapper] Unregistred class error, on the 'Set data = wrapper.GetCardData() (Issue #14)
Hello ovt001,
Thank you for your answer.
I'm not sure to understand what you mean.
As the dll is not readable for VB or VBA, I've used Regasm.exe which create a EID.wrapper.tlb file, that can be used in reference by VB or VBA. At this point, I have a unregistred class error as I described.
So, what self register executable do you use ?
Can you please be more spécific ?
Thank you again,
Fab
—Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you commented.Message ID: @.***>

Hello jdt,
Yes, now I remember I've used EID.Wrapper.Register.exe which automatically create the .tlb file. So this EID.wrapper.tlb is well accepted in the reference project.
But I don't understand how I can find this two version ?
In the Release.zip file, there is only one EID.Wrapper.Register.exe ?
Where can I find the link distinguishing 32-bit DLL or 64-bit DLL version ?
I'm sorry to bother you, thank you for help,
Fab

Hi FabFr
did you follow the Installation steps specified in the ReadMe? The zipfile that contains the DLL also contains a utility that can be used to install and register the DLL so it can be referenced correctly from your application. That tool does the required RegAsm work for you. Also, make sure you use the right version (it's most likely 32-bit as 64-bit Office installations are not that common) as outlined in the readme.

Hello Fab,Call me. It will go faster+32 476 47 00 84

Thank you ovt001, I understand the problem now.
I just have to find where are 32-bit or 64-bit version.
Fab

If you download the Release.zip from the repository and unzip that, inside is a Release folder with two subdirectories: x64 and x86. You need to run the EID.Wrapper.Register.exe from the x86 folder if you have a 32-bit version of Office (which is probably the case)


Icicle-bench is slower than Icicle-repl.

To do the same dictionary with only one query, icicle-bench takes significantly longer than icicle-repl on the same query. Ice suffers the same fate as icicle-bench.
Icicle-bench does do a tiny bit more work by generating PSV parsing code etc, but it shouldn't be that much. There is something wrong.
Profiling icicle-bench claims that Fresh bind >>= is taking the majority of the time and allocation, but this is dubious at best. I tried playing with profiling options, as well as INLINE and NOINLINE on Fresh, and no real difference. I also tried optimising Fresh by converting it to unsafePerformIO and all sorts of other junk, but no difference.
One of the profiles did suggest "substXinS" being a high one. Substitution could definitely be improved by doing multiple substitutions at the same time (taking a Map instead). However, this doesn't really explain why icicle-bench is slower than icicle-repl.
This is relatively low priority for now: while slow compilations are annoying for Ice, they will be much less of an issue for Icicle (because the actual computation will take a hours rather than minutes).

I think this is "fixed" now, right @tranma ?

no, I don't know if ice/icicle-bench is still slower than icicle-repl

0h, yeah, I was getting confused

no longer exists


[fix] need materialize condition conlumn in if function

Proposed changes
Issue Number: close #xxx
Problem Summary:
if( condition, then, else ) the condition may be a const column. Before evaluate this function, condition column need to be materialized first.
Checklist(Required)

Type of your changes:

[ ] Improvement
[*] Fix
[ ] Feature-WIP
[ ] Feature
[ ] Doc
[ ] Refator
[ ] Others:

Does it affect the original behavior:

[ ] Yes
[ *] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[*] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[*] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[*] No

Are there any changes that cannot be rolled back:

[ ] Yes
[*] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Need rebase to fix fe ut.


Add headers to response via RequestHook?

How do I add headers to the response in Testcafe? So far I've tried using the onResponse function of the RequestHook class. Using a RequestLogger, I can validate that the headers were added, but they don't actually make it to the browser (not visible in the list of response headers in Chrome's network tab).
Here's what I'm using:
import { RequestLogger, RequestHook } from 'testcafe';

class HeadersHook extends RequestHook {
  constructor(requestFilterRules) {
    super(requestFilterRules, { includeBody: false, includeHeaders: true });
  }

  async onRequest(event) { }

  async onResponse(event) {
    event.headers['bar'] = 'foo';
    event.headers.foo = 'bar';
    console.log('hook: ', event.headers);
  }
}

fixture('My Fixture');

test('Example internal-sdk usage', async (t) => {
  const headerLogger = RequestLogger(process.env.TEST_URL, {
    logResponseHeaders: true
  });

  // This order is significant: adding the logger first causes it to miss the additional headers.
  // Not sure why.
  await t.addRequestHooks(new HeadersHook(process.env.TEST_URL));
  await t.addRequestHooks(headerLogger);

  await t.navigateTo(process.env.TEST_URL);
  console.log('logger: ', headerLogger.requests.length, headerLogger.requests[0].response.headers);

  t.debug();
});

This gives the following console output which seems to indicate that the headers were successfully added:
hook:  {
  'content-type': 'text/html;charset=utf-8',
  vary: 'origin,accept-encoding',
  'access-control-allow-credentials': 'true',
  'access-control-expose-headers': 'WWW-Authenticate,Server-Authorization',
  'cache-control': 'no-cache',
  'content-encoding': 'gzip',
  date: 'Fri, 05 Mar 2021 16:43:06 GMT',
  connection: 'keep-alive',
  'keep-alive': 'timeout=5',
  'transfer-encoding': 'chunked',
  bar: 'foo',
  foo: 'bar'
}
logger:  1 {
  'content-type': 'text/html;charset=utf-8',
  vary: 'origin,accept-encoding',
  'access-control-allow-credentials': 'true',
  'access-control-expose-headers': 'WWW-Authenticate,Server-Authorization',
  'cache-control': 'no-cache',
  'content-encoding': 'gzip',
  date: 'Fri, 05 Mar 2021 16:43:06 GMT',
  connection: 'keep-alive',
  'keep-alive': 'timeout=5',
  'transfer-encoding': 'chunked',
  bar: 'foo',
  foo: 'bar'
}

But in the browser network tab, all I see is this (additional headers missing):
access-control-allow-credentials: true
access-control-expose-headers: WWW-Authenticate,Server-Authorization
cache-control: no-cache
connection: keep-alive
content-encoding: gzip
content-type: text/html;charset=utf-8
date: Fri, 05 Mar 2021 16:45:51 GMT
keep-alive: timeout=5
transfer-encoding: chunked
vary: origin,accept-encoding

Please await a response in the StackOverflow thread:
https://stackoverflow.com/questions/66496441/add-response-headers-via-requesthook
We try to keep the GitHub issues tracker for bugs and feature requests only (see also: Contributing).
If you think that this issue is a bug, feel free to open a new issue, but please make sure to follow the bug template. Thank you in advance.

I confirm that modifying the body or headers properties of the event object, which is passed to the onResponse method, doesn't affect the real response in the browser (although the responseEventConfigureOpts object is configured). We'll see if there's a better way to modify the response, and update this thread.
In the meantime, please use the following workaround to set additional headers to the response:
class HeadersHook extends RequestHook {
  constructor(requestFilterRules) {
    super(requestFilterRules, { includeBody: false, includeHeaders: true });
  }

  async onRequest () { }

  async onResponse () { }

  _onConfigureResponse (event) {
    super._onConfigureResponse(event);

    event.setHeader('foo', 'bar');
    event.setHeader('bar', 'foo');
  }
}

Please note that this workaround uses a private API – the _onConfigureResponse method.

Thanks, the work around definitely works!

@ZebraFlesh, I'm happy to hear that the workaround resolved your issue. We'll reflect this in our docs and discuss the possibility of making this API public. Use #2991 to track our progress.


Connection failed on localhost– Operation not permitted (macOS)

Describe the issue
I'm running a local GraphQL server from a Rust app on localhost:4000. I've got a very basic Flutter app that tries to send a query, but I get a ServerException saying the connection failed. OS Error: Operation not permitted, errno = 1.
The playground works perfectly in my browser, and I can also send and receive messages with Insomnia, so I'm fairly sure it isn't the server itself.
When I target the Chrome device, I don't get to this exception.
To Reproduce (MUST BE PROVIDED)
My server is running on localhost:4000. My flutter app doesn't do much more than:
void main() async {
  // ... //

  final HttpLink link = HttpLink('http://localhost:4000');

  await initHiveForFlutter();

  ValueNotifier<GraphQLClient> client = ValueNotifier(
    GraphQLClient(
      cache: GraphQLCache(store: HiveStore()),
      link: link,
    ),
  );

  runApp(App(client: client));
}

class App extends StatelessWidget {
  final ValueNotifier<GraphQLClient> client;
  const App({Key? key, required this.client}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return GraphQLProvider(
        client: client,
        child: CacheProvider(
            child: MaterialApp(
                ...);
  }
}

With a widget down the line doing:
class _AssetListState extends State<AssetList> {
  final String _query = r'''
    query {
      composition {
        clips {
          id
          name
        }
      }
    }
  ''';

  @override
  Widget build(BuildContext context) {
    return Query(
        options: QueryOptions(document: gql(_query)),
        builder: (QueryResult result,
            {Refetch? refetch, FetchMore? fetchMore}) {
          if (result.isLoading) {
            return const Center(
              child: Text("Loading"),
            );
          }
          return const Text('test');
        });
  }
}

Expected behavior
Of course, I expect the query to return with a valid value
device / execution context
I am on macOS 12.1 (Monterey), using VSCode and running the Flutter app through VSCode with the debugger attached. My device is macOS (Darwin).

Well, and just as I post this I find the answer to my problem! :/
In the case that anyone else runs into this issue:


MODULE 2 - REUSE

REUSE
Is the action or practice of using an item, whether for its original purpose (conventional reuse) or to fulfill a different function (creative reuse or repurposing)

Unit 1 - Adjustable DC voltage regulator

Unit 2 – Eco friendly Lamps

Unit 4 – Led light
Materials needed:

Red LED
Green LED
Plastic container (transparent or translucent)
USB cable from e-waste
Soldering iron and solder
Electrical tape
Wire cutters/strippers
Small drill or a hot nail

Steps in the making
Step 1: Preparing the LEDs
Start by identifying the positive (anode) and negative (cathode) terminals of each LED. The longer leg of the LED is usually the positive terminal (anode), while the shorter leg is the negative terminal (cathode). Take note of this distinction for both the red and green LEDs.
Step 2: Creating the LED circuit
Cut two small lengths of wire from the USB cable, ensuring that each wire is long enough to connect the LEDs to the circuit. Strip a small portion of insulation from each end of the wires to expose the copper strands.
Next, solder one wire to the positive terminal of the red LED and the other wire to the positive terminal of the green LED. Make sure the soldered connections are secure. Cover the exposed connections with electrical tape to insulate them.
Step 3: Assembling the disco lights
Take the plastic container and decide where you want to place the LEDs. You can drill or heat a hole using a hot nail on the container's surface, ensuring it's large enough to fit the LEDs snugly. Be careful not to damage the container while drilling or heating.
Insert the red and green LEDs into the holes you created, with the positive terminals facing outwards. Secure them in place using a small amount of hot glue or adhesive if needed.

Step 4: Wiring the circuit
Cut the USB cable, separating the two wires inside (usually a red wire and a black or green wire). Strip a small portion of insulation from the cut ends of the wires.
Connect the positive wire from the USB cable to the negative terminal (cathode) of the red LED using solder. Similarly, connect the negative wire from the USB cable to the negative terminal (cathode) of the green LED. Ensure the solder connections are secure and insulated with electrical tape.
Step 5: Powering the disco lights
Connect the USB cable to a power source, such as a computer, laptop, or USB wall charger. The LEDs should light up, creating a colorful disco effect inside the plastic container.
Warning:  Be cautious when working with electronics and soldering irons. Ensure your workspace is well-ventilated and take proper safety precautions.

do you have a source to these graphics? it is Fritzing right?

Unit 1 - Adjustable DC voltage regulator

I'm not really familiar with electronics in terms of soldering etc. so from my point of view it would be nice to see examples how this DC voltage regulator could be used. This would be important for me, because I'm not 100% shure how it can be used, but I think I could need something like it :))
So an example would help me to understand the purpose much more.
But this is only how I think about it and I'm not familiar with the subject.

Unit 1 - Adjustable DC voltage regulator

I'm not really familiar with electronics in terms of soldering etc. so from my point of view it would be nice to see examples how this DC voltage regulator could be used. This would be important for me, because I'm not 100% shure how it can be used, but I think I could need something like it :)) So an example would help me to understand the purpose much more. Examples could be: where does it get the power from (electric generator, socket, etc.), for what divices can it be used (charging mobile phones, radio, lights, etc.)
But this is only how I think about it, even not sure if my examples are reasnoable and I'm not familiar with the subject.

Hi @walthierer ,
Do you think attaching a link from a you tube for how it reads help ?
and yes, this is the first  training resource i have ever build, i think its absolutely helpful feedback to improve  , thanks!

Unit 2 Eco-friendly Lamps

also here an example would be nice, e.g. a nice photo of such a lamp, maybe with recycled materials or so

Unit 1 - Adjustable DC voltage regulator

I'm not really familiar with electronics in terms of soldering etc. so from my point of view it would be nice to see examples how this DC voltage regulator could be used. This would be important for me, because I'm not 100% shure how it can be used, but I think I could need something like it :)) So an example would help me to understand the purpose much more. Examples could be: where does it get the power from (electric generator, socket, etc.), for what divices can it be used (charging mobile phones, radio, lights, etc.)
But this is only how I think about it, even not sure if my examples are reasnoable and I'm not familiar with the subject.

Hi @walthierer , Do you think attaching a link from a you tube for how it reads help ?
and yes, this is the first training resource i have ever build, i think its absolutely helpful feedback to improve , thanks!

Everything that makes the prupose of this device more clear helps, especally graphical images like videos or photos! but be careful with videos you know the mobile data situation in uganda and south sudan.

Unit 2 Eco-friendly Lamps

also here an example would be nice, e.g. a nice photo of such a lamp, maybe with recycled materials or so

This is purely a training content for a trainer but if you want to see the products then refer to the participants doc.

In general: selfmade images and content is always easy to publish as OER, external content not so much


Danger v5+ Is there support for pre/post rename files?

Report
What did you do?

Ran danger against a PR

What did you expect to happen?

Reports violations back to PR as line comments.

What happened instead?

I might be missing something here, but I have a few use cases where we want to check the contents of files.
For example: All our images have to be under a certain size.
If a PR moves an image but otherwise doesn't touch it, the git.modified_files returns the original filename instead of the renamed file.
Now I understand that there are definitely use-cases for returning the original filename for things like making sure a file isn't accidentally moved etc. but is there any way I can get at both pre-moved and post-moved filenames?
In the image contents check, that fails because the original filename no longer exists on disk :(

Because the original name no longer exists on disk, it manifests as an issue in GH:
422 - Validation Failed
15:55:22 Error summary:
15:55:22   resource: PullRequestReviewComment
15:55:22   code: invalid
15:55:22   field: position // See: https://developer.github.com/enterprise/2.8/v3/pulls/comments/#create-a-comment

Your Environment

Which CI are you running on?
Jenkins
Are you running the latest version of Danger?
Yes, v5.1.1

I think it makes sense to add a git.renamed_files DSL,something that would look like [{ :before => "/a/b", :after => "/a/c"}]. modified_files cannot really provide enough useful metadata from its current setup.

@orta great idea!

@orta hi! Here PR to solve this.

Thanks! Shipped in 5.2.1


Simplify configuration layer in inventoryagent

What does this PR do?
Simplify configuration layer in inventoryagent. This prepare the config package to expose configuration layers in other processes (system-probe, security-agent, ...).
Describe how to test/QA your changes
Check that datadog-agent diagnose show-metadata inventory-agent show the same data (configure the agent with configuration file, env vars and runtime settings).

/merge


The wait_for method of std::future is problem

The wait_for method of std::future cannot return over time, and the time parameter is invalid

Hi. I wrote the original implementation. Could you provide more detail about what's wrong with it?
Examination of the [method|https://github.com/meganz/mingw-std-threads/blob/c01463398bd2b09c2afa0cd06c12d7b1cc8a470d/mingw.future.h#L199] doesn't reveal any flaws that match your description.

I am very glad to receive your reply. Maybe you can try to test it with the following code. The mingw I use is compiled and run on windows, and it will not output "timeout". Normally, it should print out "timeout", thank you!
``int test_shared_future_3()
{
std::shared_future fut = std::async(std::launch::async, {
std::this_thread::sleep_for(std::chrono::seconds(5));
return 8;
});
std::cout << "waiting...\n";
std::future_status status;

do {
    status = fut.wait_for(std::chrono::seconds(1));
    if (status == std::future_status::deferred) {
        std::cout << "deferred\n";
    } else if (status == std::future_status::timeout) {
        std::cout << "timeout\n";
    } else if (status == std::future_status::ready) {
        std::cout << "ready!\n";
    }
} while (status != std::future_status::ready);

std::cout << "result is " << fut.get() << '\n';

return 0;

}

Thanks for the test case.
The issue has been identified: async is locking the same mutex used for sleeping when wait_for is called. This lock is held during the entire computation, which is not correct behavior. I'll put together a patch.

See #77

thank you for your support

Fix merged


[FEATURE] Train with my own test tone

On a previous version of the trainer I used a custom test tone that I created by myself and produced great profiles.
The only thing I needed to do was to modify the 'core.py' file that's found in 'neural-amp-modeler\nam\train'
so the :
'input_version: Optional[Version] = None,'
Was  replaced with:
'input_version: Optional[Version] = Version(1, 1, 1),'
Now that I updated to the current version of the trainer this modification is not working and I have many recordings that are done using my mentioned test tone.
Some of the amps were rented so It's impossible to redo the recordings with the supported test tones.
Can someone please guide me on how I can modify the current trainer to accept my own test tone like the old one did?
If something like that is impossible in the current version, can someone tell me where to find the old trainer ?
Please keep in mind that I am not an expert and I will need some detailed guidance.
Kind regards.

Is there a guide for what type of recording to use to train the model?   Do you just record your guitar through the amp or what?

@DimGakis that sounds pretty hacky. Was the file you used based on v1_1_1.wav? Or how is it related to one of the standard reamp files? (Assuming it is).
If it's not related, then you need to use the CLI trainer.

But the fact that it doesn't "soft match" any of the standardized files means that something is different in it that makes it not have something that it needed to have.

My own test tone is five minuets long and is not related to any of the standard reamp file.
With the old trainer sightly modified I was able to use my own test tone and create some great sounding profiles.
I don't know what is the CLI trainer, how to find it or how to use it. But I know how to make it work with the older version of the trainer by applying these easy modifications.
If its hard to help me with the CLI trainer then can you please tell me how I can get older versions of the trainer so I can create the profiles that are recorded with my own test tone the way I used to?
I can not redo the recordings with the supported reamp files because I don't own the equipment anymore.

You can click on the "Assets" button on any of the older releases to get the source code.

Directions for using the CLI trainer: https://github.com/sdatkinson/neural-amp-modeler/tree/main#the-command-line-trainer-all-features

Directions for using the CLI trainer: https://github.com/sdatkinson/neural-amp-modeler/tree/main#the-command-line-trainer-all-features

Updated now that there's a ReadTheDocs (hooray!): https://neural-amp-modeler.readthedocs.io/en/latest/tutorials/command-line.html
I'm thinking to add a tutorial for how to use NAM if you have a DI and the reamp, but you can't reamp one of the standardized audio files (e.g. you want to make a NAM of something you recorded in the past).
I'm going to change this Issue to track making that tutorial page for the documentation.


TypeError: undefined is not an object (evaluating 'eosjs_key_conversions_1.PrivateKey.fromString')

Version of EOSJS
I have installed a version packaged into RPM 2 hours ago:
# npm i -S<EMAIL_ADDRESS>
Describe the bug
It produces the error described above at line 86 of eosjs-jssig.js
To Reproduce
const {JsSignatureProvider} = require('eosjs/dist/eosjs-jssig');  // development only
var x = new JsSignatureProvider([privKey])

Analysis
the eosjs-key-conversions.ts file contains something like:
import { PrivateKey } from './PrivateKey';
export { PrivateKey } from './PrivateKey';

which produces something like this (in eosjs-key-conversions.js):
var PrivateKey_2 = require("./PrivateKey");
exports.PrivateKey = PrivateKey_2.PrivateKey; # this dereference produces undefined

but eosjs-jssig.js attempts to use it like this:
var eosjs_key_conversions_1 = require("./eosjs-key-conversions");
var priv = eosjs_key_conversions_1.PrivateKey.fromString(k);

where it fails because there is no PrivateKey member of eosjs_key_conversions_1.  the reason is that PrivateKey.js exports a function, which doesn't declare a member of that name, so one way to fix this is to make the reference properly:
exports.PrivateKey = PrivateKey_2;

but since this is generated code, we can't do it.  the other way would be to return an object with the proper key name from PrivateKey.js, which declares and returns a function:
function PrivateKey(key, ec) {
        this.key = key;
        this.ec = ec;
    }
return PrivateKey

so this would need to be fixed like this:
return { PrivateKey }

but such a fix would break anyone calling context expecting to receive a function when sourcing this file.  such contexts would now need to do:
const {PrivateKey} = require('./PrivateKey.js')

I'm not sure what the right fix is

I'm not seeing an error when running the following:
const eosjs = require('eosjs');
const { generateKeyPair } = require('eosjs/dist/eosjs-key-conversions');
const { PrivateKey } = require('eosjs/dist/PrivateKey');
const { JsSignatureProvider } = require('eosjs/dist/eosjs-jssig');

const keyPair = generateKeyPair(eosjs.Numeric.KeyType.k1);
const privateKeyString = keyPair.privateKey.toString();
const publicKeyString = keyPair.publicKey.toString();

console.log(`PrivateKey: ${privateKeyString}\nPublicKey: ${publicKeyString}`);

const provider = new JsSignatureProvider([privateKeyString]);

EOSJS version: 21.0.0-45854c1.0

var x = new JsSignatureProvider([privKey])

Your issue occurs here? Can you show me some more code?

interestingly, I don't get this error running the code in Node.  I get it in React Native

as a matter of interest, I've expounded on the issue here: https://stackoverflow.com/questions/61068858/require-works-in-node-but-fails-in-react-native

interestingly, I don't get this error running the code in Node. I get it in React Native

Can you create a minimal reproduction of this issue in React Native using something like Expo/Snack?

I was thinking to do that.  stand by, will notify here

here's a snack that we can use to work on this: https://snack.expo.io/@ekkis/thoughtful-ice-cream you will notice that if you run on iOS you'll get the error: "secure random generation not supported by this browser use chrome, FireFox or Internet Explorer 11", which is a message issued by eosjs 20.0.0, not v21
in my local environment this message disappeared once I upgraded to 21 so I'm not sure why it appears here since, as you can see from the package.json, I've included ^21.0.0-a6ad012.0

you will notice that if I run the snack on Web, there is no error

Thanks for the example!
I've never seen a dependency's single file resolved in that way, but maybe it works properly for expo because of something going on behind the scenes (I tested it locally and it does not work). In your example, "eosjs/dist/eosjs-jssig": "latest" looks like it's going to correspond to NPM's latest package, which is version 20.0.3, so when you say:
"eosjs": "^21.0.0-a6ad012.0",
"eosjs/dist/eosjs-jssig": "latest"

you're essentially pulling the entire package for eosjs with the edge version and then resolving the eosjs-jssig file as latest, so two completely different versions. That's why you're seeing the error you mention above. Specifically, this error seems to be coming from https://github.com/EOSIO/eosjs-ecc/blob/master/package.json#L48. We swapped out eosjs-ecc with elliptic in v21, so we moved it to a devDependency for integration testing purposes, which is why you don't see this error in v21.
If you change it to: "eosjs/dist/eosjs-jssig": "21.0.0-a6ad012.0", then expo correctly pulls version 21 for that file instead and it can be resolved properly. Check out https://snack.expo.io/@jlamarr22/7cf938

thank you.  I actually came across eosjs-rn (it was suggested to me on the Telegram group), which  has been tested on React Native and I can confirm it works well.  so I'm moving on from this but will leave the issue open so maintainers can close with WONTFIX or address the issue
thanks for looking into this.  I burnt a few days with it

There is a problem using EOSJS v20 with React Native that stems from eosjs-ecc's dependency not being compatible with React Native: https://github.com/EOSIO/eosjs-ecc/blob/master/package.json#L48.
I am closing this issue due to the underlying problem stemming from a dependency that will eventually be deprecated, an existing/working solution for v20 (https://github.com/Game-X-Coin/eosjs-rn), and the fact that we have confirmed in v21 via PoCs above that this is no longer an issue.
If using React Native:

If you absolutely need EOSJS v20, use https://github.com/Game-X-Coin/eosjs-rn
Otherwise, upgrade to EOSJS v21 (full release coming soon)


Fix forbidden null value sending

I want to merge this change because... it fixes forbidden null sending as an attribute value.

PR intended to be tested with API branch:
Screenshots

Pull Request Checklist

[ ] This code contains UI changes
[ ] All visible strings are translated with proper context including data-formatting
[ ] Attributes [data-test-id] are added for new elements
[ ] Changes are mentioned in the changelog
[ ] The changes are tested in different browsers and in light/dark mode

Test environment config

API_URI=https://qa.staging.saleor.cloud/graphql/

Task linked: SALEOR-3700 Dashboard sends [null] as input where null is forbidden


"Shader as Texture" example

The current example "Shader as a Texture" uses createGraphics() and texture() to apply the output of the shader as a material for the geometry.
However, I think a better approach would be to just use the shader() function and avoid all these extra steps. Here is a live example of said changes (and a simpler example by aferriss (live, src)). The example can then be renamed as "Shader as a Material".
function preload() {
  myShader = loadShader("shader.vert", "shader.frag");
}
function draw() {
  ...
  // shader() sets the active shader with our shader
  shader(myShader);
  ...
  // Draw some geometry to the screen
  box(width / 4);
}

To demonstrate how createGraphics can be useful with shaders, I propose adding a second example titled "Multipass Shader" that demonstrates how createGraphics can be used to achieve multiple render passes. For this second example, I would like to add the Texture Delay example (live, src) by @aferriss. (Or maybe the Multi-Pass Blur is a better example due to simpler code (live, src). Though it is not as visually striking with regards to multiple passes).
Would you like to work on the issue?
Yes

I've spent some time working on the shader examples as commented above.
Below is a list of current and potential examples as they would appear on the examples page.

"Basic Shader"

live demo with source code
mostly the same as the current example
changes:

updated with commented-out lines demonstrating how can be used for "3D geometry"

  // Rect gives us some geometry
  rect(-width / 2, -height / 2, width, height);

  /* Uncomment to try.
     Use box geometry instead.
  */
  // clear();
  // rotateX(millis() * 0.0005);
  // rotateY(millis() * 0.00025);
  // box(width / 4);

"Shader as Texture"

propose removing this example for the reasons above
to demonstrate when texture() would be useful with shaders, I think the multipass example below is a better candidate (since the resulting code is messier without it)

"Passing Shader Uniforms"

not modified

"Shader Using Webcam"

not modified

"Texel Manipulation Shader"

live demo with source code
demonstrates how a texture's texels can be sampled and manipulated
not sure what the best name for this example is

"Multipass Shader"

live demo with source code
demonstrates how "buffers" (made by createGraphics()) can be used to emulate "passes"
demonstrates practical use case for texture() with shaders
(the TODOs will be replaced with proper descriptions)

"Matrix-Unaware Shader" / "Shader Using Pixel Coordinates"

live demo with source code
demonstrates how to write shaders that do not use model/view/projection matrices and instead use absolute pixel coordinates (via gl_FragCoord)
the code in the demo is based on the current "shader as texture" example
not sure what the best name for this example is

@aferriss What do you think?


Appstudio update test-custom-default-branch-pvfq

Pipelines as Code configuration proposal

Pipelines as Code CI/test-custom-default-branch-pvfq-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
21 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

✅ Succeeded
22 seconds
deprecated-base-image-check

✅ Succeeded
19 seconds
sanity-inspect-image

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
14 seconds
clair-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
10 seconds
sanity-optional-label-check

✅ Succeeded
10 seconds
sanity-label-check

✅ Succeeded
7 seconds
show-summary

Pipelines as Code CI/test-custom-default-branch-pvfq-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
21 seconds
clone-repository

✅ Succeeded
2 minutes
build-container

✅ Succeeded
22 seconds
deprecated-base-image-check

✅ Succeeded
19 seconds
sanity-inspect-image

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
14 seconds
clair-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
10 seconds
sanity-optional-label-check

✅ Succeeded
10 seconds
sanity-label-check

✅ Succeeded
7 seconds
show-summary


[Feature Request] show delta of ticket sold between this and last entries of data

Currently the bot shows the data like:
PyCon TW 2021 目前售票狀況為：
-------------- 主活動 --------------
- 個人票：107
- 企業票：45
- 保留票：140
- 總售票人數：292 / 800
-------------- 子活動 --------------
- Sprint：7 / 80

Is it a good idea if the bot provides additional information like:
PyCon TW 2021 目前售票狀況為：
-------------- 主活動 --------------
- 個人票：107 (+1 in 2 days)
- 企業票：45 (+0 in 2 days)
- 保留票：140 (+0 in 2 days)
- 總售票人數：292 / 800 (+1 in 2 days)
-------------- 子活動 --------------
- Sprint：7 / 80 (+0 in 2 days)

Hi @tai271828 thank you for your suggestion.
I am trying to write a beta feature. And implement the code on our staff discord server. I will make the code more comprehensive and then push the code.
This features will be like following messages:
PyCon TW 2021 08/31 售票狀況：
-------------- 主活動 --------------
- 個人票：123 (+8 in last 24 hours)
- 企業票：59 (+7 in last 24 hours)
- 保留票：140 (+0 in last 24 hours)
總售票人數：322 / 800 (+15 in last 24 hours)
-------------- 子活動 --------------
- Sprint：15 / 80  (+ 6 in last 24 hours)

The bot will send the messages every day. And compare the tickets sold with yesterday. If you think the interval is too short or have any problems, please let me know.

The bot has been running for a few days and we all love it. Thank you @allen91wu !!


[Event Modification]  page 6510 "Item Tracking Lines"  OnWriteToDataOnBeforeCommit

Hello,
Is it possible to add the following to an event
    OnWriteToDataOnBeforeCommit(Rec);

to
    OnWriteToDataOnBeforeCommit(Rec,TempReservEntry);

TempReservEntry as var

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Problem with labels method on metrics objects

I am expecting to be able to set labels on a Counter like in the examples:
from prometheus_client import Counter
c = Counter('my_requests_total', 'HTTP Failures', ['method', 'endpoint'])
c.labels(method='get', endpoint='/').inc()

I am using prometheus-client (0.0.14) from PyPI.
$ python
Python 2.7.12 (v2.7.12:d33e0cf91556, Jun 26 2016, 12:10:39)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from prometheus_client import Counter, CollectorRegistry
>>> reg = CollectorRegistry()
>>> c = Counter('items_total', 'number of items total', registry=reg)
>>> c.labels(first=1, another=2).inc()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'Counter' object has no attribute 'labels'
>>>
>>> type(c)
<class 'prometheus_client.core.Counter'>
>>> dir(c)
['__class__', '__delattr__', '__dict__', '__doc__', '__format__', '__getattribute__', '__hash__', '__init__', '__module__', '__new__', '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__', '__subclasshook__', '__weakref__', '_reserved_labelnames', '_samples', '_type', '_value', 'collect', 'count_exceptions', 'inc']

The Counter object does not seem to have a labels method attached to it. Perhaps some recent changes has affected the application of the decorator that applies it to the metrics?
#99 kind of indicates this same problem but has words relating it to pushgateway.

I thought it might have something to do with the needing to declare the label names up front (which the docs seem to use) but this does seem to affect it.
$ python
Python 2.7.12 (v2.7.12:d33e0cf91556, Jun 26 2016, 12:10:39)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from prometheus_client import CollectorRegistry, Counter
>>> reg = CollectorRegistry()
>>> c = Counter('my_requests_total', 'HTTP Failures', ['method', 'endpoint'], registry=reg)
>>> c.labels(method='get', endpoint='/').inc()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: labels() got an unexpected keyword argument 'method'
>>>
>>> c.labels({'method':'get', 'endpoint':'/'}).inc()
>>>

If I pass the labels as a dict it seems to work.

c = Counter('items_total', 'number of items total', registry=reg)

This doesn't have any labels specified

I think from your comment you are telling me that I'm using it wrong, that I should be declaring up front the set of labels that I am planning to use with a metric (rather than dynamically adding labels to a metric).
So if I now go and define some labels, exactly as in the example docs, it still doesn't work for me.
$ python
Python 2.7.12 (v2.7.12:d33e0cf91556, Jun 26 2016, 12:10:39)
[GCC 4.2.1 (Apple Inc. build 5666) (dot 3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from prometheus_client import Counter
>>> c = Counter('my_requests_total', 'HTTP Failures', ['method', 'endpoint'])
>>> c.labels(method='get', endpoint='/').inc()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: labels() got an unexpected keyword argument 'method'
>>>

Perhaps the problem I'm having is purely a docs issue that describes functionality that is not present.

AttributeError: 'Gauge' object has no attribute 'labels'
▽
from prometheus_client import CollectorRegistry, Gauge, push_to_gateway
registry = CollectorRegistry()
g = Gauge('metric', 'help', ['a','b'], registry=registry)
g.set(10)
g.labels('value1', 'value2').inc()
push_to_gateway('<IP_ADDRESS>:9091', job='batchA', registry=registry)
gives
Traceback (most recent call last):
File "test.py", line 5, in
g.set(12)
AttributeError: '_LabelWrapper' object has no attribute 'set'
if i remove
g.set(12)
it works ok and sets to 1
thanks

Try it:
registry = CollectorRegistry()
g = Gauge('metric', 'help', ['a','b'], registry=registry)
g.labels('value1', 'value2').set(12)
push_to_gateway('<IP_ADDRESS>:9091', job='batchA', registry=registry)

However this doesn't work in conjunction with decoraters.
registry = CollectorRegistry()
g = Gauge('job_last_success_unixtime', 'Last time a batch job successfully finished',['method'],  registry=registry)

@g.labels('POST').time()
def wait():
    sleep(300)

push_to_gateway('pushgateway:9091', job='SomeJob', registry=registry)

Traceback:
  File "tmp.py", line 6
    @g.labels('POST').time()
                     ^
SyntaxError: invalid syntax

Usage questions are best asked on https://groups.google.com/forum/#!aboutgroup/prometheus-users

g = Gauge('node_cpu', 'metrics',"[node]", registry=registry)
when I am trying this i am getting an error
ValueError: Invalid label metric name: [

you can try:
g = Gauge('node_load5_norm', 'node_load5_norm', ["host"], registry=registry)
g.labels(hostname).set(value)
push_to_gateway(gateway_uri, job='pushgateway', registry=registry)
then:
metric like this:
node_load5_norm{'host'=xx} 0.1


Fix Install guide and related resources

Install guide on Docsite is completely unusable.
For example it has this code  kubectl apply -f https://raw.githubusercontent.com/banzaicloud/bank-vaults/master/operator/deploy/rbac.yaml which returns 404.
Links to helm and operator repo also return 404.
If I try to install operator helm chart directly from repo and then try to  run
kubectl apply -f ./deploy/examples/cr.yaml

Error from server (BadRequest): error when creating "./deploy/examples/cr.yaml":
Vault in version "v1alpha1" cannot be handled as a Vault: strict decoding error:
unknown field "spec.unsealConfig.options.secretShares",
unknown field "spec.unsealConfig.options.secretThreshold"

If these fields are fixed the PVC is stuck in creation forever.
I think functioning examples for install guide is a must.

Hi, we're really sorry for the inconvenience, right now we're in the middle of migrating the repo to a separate github organization, and splitting it into multiple repos for the different components.
@akijakya @ramizpolic can you help @mkoukal on what is the recommended install method right now until we finish migrating the last repo?

Hi, we're really sorry for the inconvenience, right now we're in the middle of migrating the repo to a separate github organization, and splitting it into multiple repos for the different components.
@akijakya @ramizpolic can you help @mkoukal on what is the recommended install method right now until we finish migrating the last repo?

Thanks Robert. I am trying to push the idea of using this operator instead of managing everything by hashicorp helm chart. I appreciate your help a lot.

Absolutely, @mkoukal. Feel free to use tagged installation resources from

CRD - https://raw.githubusercontent.com/bank-vaults/vault-operator/v1.20.0/deploy/crd.yaml
RBAC - https://raw.githubusercontent.com/bank-vaults/vault-operator/v1.20.0/deploy/rbac.yaml

We will have updated docs today. Apologies for the inconveniences.

Absolutely, @mkoukal. Feel free to use tagged installation resources from

RBAC - https://raw.githubusercontent.com/banzaicloud/bank-vaults/v1.15.3/operator/deploy/rbac.yaml
CR - https://raw.githubusercontent.com/banzaicloud/bank-vaults/v1.15.3/operator/deploy/cr.yaml

We will have updated docs today. Apologies for the inconveniences.

Absolutely, @mkoukal. Feel free to use tagged installation resources from the same repo while we continue working on the migration.

RBAC - https://raw.githubusercontent.com/banzaicloud/bank-vaults/v1.15.3/operator/deploy/rbac.yaml
CR - https://raw.githubusercontent.com/banzaicloud/bank-vaults/v1.15.3/operator/deploy/cr.yaml

Thank you for understanding!

thanks @ramizpolic It sort of works, at least it is starting to get deployed. Please consider including in the docs (or editing the cr.yaml) how to actually make the PVs. Just uncommenting the section in the yaml file is enough. It is generally good idea to have the simplest possible guide for new onboarding. Although I probably understand the reasons why this section is commented.
The guide IMO could look like this:

apply operator helm chart
create RBAC
create directory on all nodes and give the permissions
apply the CR with uncommented PV creation.

But this is just an idea

Hi @mkoukal, thank you for suggestions. We will have these items in mind. Note that those are not the most fresh installation resources. We have a release scheduled in the upcoming weeks under new org, so all the docs and resources will be updated by then.
If you have some time, feel free to open a PR and add all the items you deem important. Contributions are always welcome!


onFulfill triggered before state update is complete

I copied the example code and added set code length to 5. onTextChange is triggering a state change. onFulfill is reading state and rendering an alert. Unfortunately, the state update seems to be slower and therefore I only get the first 4 letters of entered code.
Any ideas how to prevent this?

Facing same issue

I've come into this problem but it's worth mentioning that onFulfill receives the final value as it's only argument so you don't need to use the code value set in state by onTextChange for anything other than passing the value back to the component. Hope that makes sense :)

Hey everyone, @xamous  onFulfill is triggering before it receives the last character of the state. any help on how this issue was solved?
example code of mine is as below:
`
const dispatchAction = signIn => {
if (signIn) {
dispatchLogin();
} else {
dispatchSignUp();
}
};

<SmoothPinCodeInput
containerStyle={styles.spacer}
password
mask="﹡"
ref={otpRef}
cellStyle={{
borderBottomWidth: 2,
borderColor: 'gray'
}}
cellStyleFocused={{
borderColor: 'black'
}}
value={password.password}
cellSpacing={40}
maskDelay={0}
cellSize={60}
keyboardType="number-pad"
codeLength={4}
autoFocus
onTextChange={pin => setPassword({ password: pin })}
onFulfill={dispatchAction()}
/>
`
Thanks

@namxam
Thanks for reporting and you can also use better implementation with better maintainability:  https://github.com/retyui/react-native-confirmation-code-field

just upgrade, fixed

I faced a similar issue... I used this hack, which is not necessarily the best way to solve this problem. The onFulfill calls this function doSomething. I set a time in doSomething function before the code is printed out.  This will allow the state to update before the code is printed out.
<SmoothPinCodeInput
         cellStyle={styles.pinCode}
         cellStyleFocused={styles.pinCodeFocus}
          value={code}
          onTextChange={code => this.setState({code})}
          onFulfill={this.doSomething}
  />

The doSomething function
doSomething =  () => {
      setTimeout( () => {
         const {code} = this.state;
         console.log(code)
     }, 1000);
  };

I delay the action for a second before the correct code was printed out. Like I said earlier, I don't think this is the best way to fix the issue because how can you be sure the state will have updated within a second. But this hack is a walk around the bug. Another option will be to put a button and let the user trigger the doSomething function.

@stanislav-sidorov upgrade what?? version of this library?

@stanislav-sidorov which version is upgraded?
Thanks.

The solution is to simply use the variable given to the onFullfill callback. This way you always get the entire input in the doSomethingElse function
<SmoothPinCodeInput
         ...
          onTextChange={(pin) => doSomething({pin})}
          onFulfill={(fulfilledPIN) => doSomethingElse(fulfilledPIN}
        ...
  />


Will restart tests once some of the other dependencies are merged in to verify this is needed or not


[Fixit] Add a fixit to remove type alias self-referring declaration.

This patch adds a fixit to remove type alias self-referring definitions, like typealias A = A.

Resolved bug number: (SR-)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    All supported platforms     | @swift-ci Please smoke test and merge
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    All supported platforms     | @swift-ci Please test and merge
    OS X platform               | @swift-ci Please test OS X platform
    OS X platform               | @swift-ci Please benchmark
    Linux platform              | @swift-ci Please test Linux platform

Lint Testing
    Language     | Comment
    ------------ | -------------
    Python       | @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

…ke typealias A = A. rdar://24869708

@swift-ci Please test

@swift-ci please test


Feature: Implement Email Verification API

To enhance the security and authenticity of user accounts in the URL-Shortener-App, we should implement an "Email Verification" feature. This feature ensures that users provide valid email addresses and allows us to verify their accounts before they can fully access the system.
Tasks:

Create a temporary link in the email that the user can click to verify their email address.
Update the user's account status to "verified" once the email is successfully verified.
Include appropriate error handling and validation to ensure the security of the email verification process.

I am interested in Adding this feature.I will add Api and create the required changes in frontend as well


refactor: polish lint_style and rename to lint-style

Use upperCamelCase for all local variables, per the naming convention.
Rename the executable to lint-style, per zulip.

[ ] depends on: #14697

bors merge


Fix breaking changes for parse-server

Adds testing based on parse-server-conformance-tests
Adds travis scripts
Adds coverage

We changed the adapter Api in parse-server for an upcoming release that introduces breaking changes on the files adapter.
Feel free to add
AZURE_ACCOUNT_NAME
AZURE_CONTAINER
AZURE_ACCESS_KEY
to travis to run the full spec.
see here: https://github.com/ParsePlatform/parse-server/pull/1172

Oh wow, thanks a bunch :clap:!

(I'm the one who broke everything)

Well, it's still super nice for you to help us out here. Very much appreciated, thanks a lot!

no problem! You think you can plug travis-ci and codecov?

Yeah, on that right now.

:+1: :100:


[ADD]: Create a README.md

The repo is missing a README.md file. I want to work on the README file as a part of the Modtoberfest.

Kindly assign this issue to me.

Hey, feel free to contribute by forking the repository, making appropriate changes, and opening a pull request. Buuz is quite the busy guy so don't worry that you haven't been assigned the task :)


Materialized view vs. 8Knot query - repo_id

I'm getting DB read failures on my branch, and I rooted out the problem:
The materialized views for explorer_pr_assignments.sql and explorer_issue_assignments.sql have the line *.repo_id AS id, rather than *.repo_id as repo_id or otherwise, so the queries in 8Knot are failing, expecting to find a repo_id column.
Unclear whether the 8Knot queries need to adopt the 'id' column name or the materialized views should have the column be 'repo_id.'

Fix not necessary- materialized view conforms to other queries in app, just one step later than normal.


Fixed various serialization issues

Hi @yadavbdev, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (yadavb). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

please also check in the change on the assemblyinfo.cs. If you build out a local package, the file should be updated already, just include it.


Set up project board

@catw101 I have it setup, should I add you so you can see it?

I can see it now, thanks!


[VM, Profiling] Add function attribute for shape func for profiling

https://github.com/apache/tvm/pull/7894 forgot to add func attributes for shape func, and so the profiler crashes at https://github.com/apache/tvm/blob/301ce490c23c95aa4ed3cfd735ba7b42f69e97e7/src/runtime/vm/profiler/vm.cc#L108 when it tries to run a shape func on dynamic workloads.
cc @tkonolige @junrushao1994

Ready to merge @tqchen @junrushao1994

Thanks @masahi @tkonolige


nixos/manual: lengthScale default value formatting depends on nix version

Building this package twice does not produce the bit-by-bit identical result each time, making it harder to detect CI breaches. You can read more about this at https://reproducible-builds.org/ .
Fixing bit-by-bit reproducibility also has additional advantages, such as avoiding hard-to-reproduce bugs, making content-addressed storage more effective and reducing rebuilds in such systems.
Steps To Reproduce
nix-build nixos/release.nix -A manual.x86_64-linux

The documentation in share/doc/nixos/options.html will have '1' as default value for opt-services.wyoming.piper.servers._name_.lengthScale when building with nix 2.3.7, while it has '1.0' when building with nix 2.17.1.

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixos-reproducible-builds-minimal-installation-iso-successfully-independently-rebuilt/34756/1

Is this the difference in floating formatting that happened?

I wasn't aware of that - sounds like it!
Perhaps it's not super important to be reproducible across nix versions, and we should specify using consistent nix versions as a prerequisite for reproducibility of the manual/ISO/etc?

probably https://github.com/NixOS/nix/issues/3077 or similar

Perhaps it's not super important to be reproducible across nix versions, and we should specify using consistent nix versions as a prerequisite for reproducibility of the manual/ISO/etc?

I guess so then, closing


Fixed Dogecoin AuxPow header

Fixed Dogecoin chain synchronization issue because of hard-fork at 371337rd block.
https://github.com/dogecoin/dogecoin/blob/bb4b082c086689434d67490a15224c42fefdfd13/src/primitives/block.h#L38
https://github.com/dogecoin/dogecoin/blob/bb4b082c086689434d67490a15224c42fefdfd13/src/auxpow.h

Cool!

Push <IP_ADDRESS>. Let me know if it works, this is first time we try an altcoin with different header (@Kukks you might be interested)

Ping @dangershony you might like this

Awesome! Seems like the issue is handled fine with this so far

@NicolasDorier I tested it with mainnet node, all 2,175,500+ headers synchronized.

Super cool!


gRPC view: special case decoding

Description
It appears that Protobuf based communication with Google endpoints uses field values slightly deviating from the specs (created by Google, too).
More specifically cases have been observed, were field values containing nested Protobuf messages got prefixed with an additional length value (encoded as variable-length integer). Such values could not be decoded, as the parser expected raw messages (without prefixes) as payload of length delimited fields.
While this is a special case, it is easy to test for in the current gRPC contentview implementation - with minimal computing overhead and without disrupting expected decoding behavior for other protobuf traffic.
I consider this encoding scheme a "common case" as it is used by Google itself.
The gRPC contentview was extended to handle this case (tests included).

The screenshot shows a protobuf message, containing a nested message which can not be decoded without the adjustment (Field 1.5):

The screenshot shows an excerpt of the same message, with this patch applied (Field 1.5 got decoded and holds a valid protobuf message):

As shown in the screenshot, messages decoded like this are marked with len_prefixed_message. This decoding was inserted into the default decoding-failover-strategy. It is still possible to use custom definitions, to enforce decoding as bytes for such fields.
Beside this, a missing MIME type for protobuf messages was added.
Checklist

[x] I have updated tests where applicable.

Closing this PR for rework, as it turned out that the wire data represents packed, repeated elements (message[] in this case).
Such decoding can not be predicted reliably and has to be added as custom decoding


Implement translation with i18next

@see how Manta does it.
Also setup a crowdin org for the translations.

Crowdin ready and i18next too. Thus closing


Added namespace and include

@gregdegruy : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@Saisang, can you approve this?

#hold-off

@gregdegruy
First off, thanks for working on making our documentation better. To help us understand what you're proposing, I recommend you include comments in your PR submissions that explain and justify your submission: what you think is wrong, and how your submission is the best fix. Absent that, we just have to guess.
On consideration, I don't think this is the right thing to do here, or the similar changes you've made in the other PRs in this topic.
The problem as I see it is, the existing snippets don't follow our own guidelines that most code examples should be self-contained, runnable code. These code snippets are just a few lines that make readers guess at our intended declarations and usage.
On review, I note that adding the include directives in each snippet makes some of our intentions explicit, but it doesn't help turn these into runnable examples. The include directives would be out of place if the snippets were cut and pasted into some other code.
The other change is one that comes up regularly: whether to namespace-qualify names from the standard library everywhere, or to include the whole namespace with a using namespace std; statement. For reasons of white space economy, the docs usually choose the latter. There are arguments within the C++ developer community as to which is better from a software engineering standpoint. I personally lean toward qualifying everything, as full qualification is always recommended in header files. However, some heavy hitters in software engineering are fine with less typing in implementation files when it's clear to the compiler which name comes from where. With IntelliSense, you can hover over any name and see its fully-qualified declaration. The compiler will let you know if it finds a name ambiguous. These reasons are why I don't consider adding the namespace qualifications alone sufficient justification for changing the docs examples.
I think instead we need a common baseline for this topic, a bit of prologue that comes before the examples; something like this, just before the Example 1 heading:
Example set-up
The examples assume that you've included the required headers and declared the required types, as shown in this code example:
// shared_ptr-examples.cpp
// The following examples assume these declarations:
#include <algorithm>
#include <iostream>
#include <memory>
#include <string>
#include <vector>

struct MediaAsset
{
    virtual ~MediaAsset() = default; // make it polymorphic
};

struct Song : public MediaAsset
{
    std::wstring artist;
    std::wstring title;
    Song(const std::wstring& artist_, const std::wstring& title_) :
        artist{ artist_ }, title{ title_ } {}
};

struct Photo : public MediaAsset
{
    std::wstring date;
    std::wstring location;
    std::wstring subject;
    Photo(
        const std::wstring& date_,
        const std::wstring& location_,
        const std::wstring& subject_) :
        date{ date_ }, location{ location_ }, subject{ subject_ } {}
};

using namespace std;

int main()
{
    // The examples go here, in order:
    // Example 1
    // Example 2
    // Example 3
    // Example 4
    // Example 5
    // Example 6
}

There'd need to be a couple of typos fixed in one example code snippet, but they'd otherwise compile as-is. In Example 4, there's a stray ) in line 3 , and my declaration of Photo would mean location_ should be location instead, for consistency.
This change is a bit more ambitious, but arguably more useful. Do you want to make it?

Thanks for taking the time to consider my PR and speak through the intentions of it. Completely agree with your point here and because of this I agree includes should not used in the snippets.

On review, I note that adding the include directives in each snippet makes some of our intentions explicit, but it doesn't help turn these into runnable examples. The include directives would be out of place if the snippets were cut and pasted into some other code.

I love the idea of a prologue or even an epilogue that ties all the snippets together. I think it would be a great addition to the docs. I've seen this approach in some other Microsoft docs I reference. I think the value of a prologue is seeing all the code come together. Often times I find it difficult to see this and so do Microsoft partners I work with.
using namespace std; is up for much debate and I still personally don't have a good answer for when to and when not to use this in documentation. Even variable member naming like date_ versus m_date is up for debate and it all comes down to the style of the development team.
I thinking speaking to namespace qualification as a best practice to follow in production and development is good enough. I would like to see more awareness brought to this as using namespace std; is sometimes thought to new developers or students without explaining it's in production software to the global namespace.

There are arguments within the C++ developer community as to which is better from a software engineering standpoint. I personally lean toward qualifying everything, as full qualification is always recommended in header files

The changes discussed were committed and merged independently, so I'm closing this reminder.


Introduce --no-notifcations and a Dockerfile

With --no-notifications, we do not invoke notify-send(1) at all.
Simple Dockerfile for running reviewcheck.
This PR contains two commits that should be treated as two separate features, but are grouped into the same PR because the Dockerfile depends on --no-notifications being available.

Future ideas about how to solve the notifications:

The notifications, i guess, goes via dbus? Can we mount the socket file, and have it be picked up by a notify-send in the image, that we get by installing it?

But with that said, I think this change should go in and we can investigate this later!

Cool stuff :sunglasses:
Can you add documentation?

Cool stuff sunglasses
Can you add documentation?

Something like this?

Getting a bunch or red text when building the docker. Seems that you can specify a user to prevent that though. https://stackoverflow.com/questions/68673221/warning-running-pip-as-the-root-user
It will be a better user experience if there is no text in scary colors.

Getting a bunch or red text when building the docker. Seems that you can specify a user to prevent that though. https://stackoverflow.com/questions/68673221/warning-running-pip-as-the-root-user
It will be a better user experience if there is no text in scary colors.

Cool, thanks to your link, I've learned a clean way of getting rid of those warnings! Just set the env PIP_ROOT_USER_ACTION=ignore. Or the --root-user-action=ignore flag. I suggest that rather than overriding user. (There is a flag --userns keep-id to docker/podman that would also get rid of the warnings, without messing too much with the user. I don't have --userns keep-id on docker 20.10.12 though.)


Added Google-Ads-Creatives-Assistant user agent to fixtures array

First contributed pull request, hope everything looks alright 🤞🏻

Thank you 👍🏻


Got 404 for all translations on: https://docusaurus.io

I want to see how Docusaurus implements its own translation as a reference, but what I found is that all translations of official website: https://docusaurus.io is down, all 404. For example: https://docusaurus.io/docs/zh-CN/installation

Configuration file '/home/circleci/docusaurus/v1/website/../crowdin.yaml' does not exist
```

Seems that this is caused by `v1` and `v2` separation

cc @yangshun

Shall be fixed after this https://circleci.com/gh/facebook/Docusaurus/3297 is done

I conformed that it's fixed. Thanks!

Thanks for reporting. Completely missed it.


No transposing char on OS X

Sublime Editor on OS X doesn't support transpose by itself because the OS supports it by default.
Beside, It is provided Ctrl + T not Cmd + T.

Cmd + T executes Go to anywhere on OS X
http://docs.sublimetext.info/en/latest/reference/keyboard_shortcuts_osx.html#navigation-goto-anywhere

Thanks. Merged as 0733ad5


Fix NonP2P to P2P interop problem

Description
P2P nodes uses the server port number for outbound connections. This can confuse NonP2P nodes into thinking that they already have a connection to them.
This PR changes the NonP2P connection table to take connection direction into account, similar to @dcoutts  patches in https://github.com/input-output-hk/ouroboros-network/compare/dcoutts/old-connection-table .
The P2P nodes reuse of the server port also means that incoming connections from a P2P node can be refused by a NonP2P node if the peer is "suspended". This suspension never affected NonP2P nodes since they reconnect from a new ephemeral port each time. This PR lets NonP2P nodes differentiate between if it should refuse to accept new connections from a peer or if it should avoid creating new connections to a peer.
Fixes #4465 .

Checklist

Branch

[x] Commit sequence broadly makes sense
[x] Commits have useful messages
[ ] The documentation has been properly updated
[ ] New tests are added if needed and existing tests are updated
[ ] Any changes affecting Consensus packages must have an entry in the appropriate changelog.d directory created using scriv. If in doubt, see the Consensus release process.
[ ] Any changes in the Consensus API (every exposed function, type or module) that has changed its name, has been deleted, has been moved, or altered in some other significant way must leave behind a DEPRECATED warning that notifies downstream consumers. If deprecating a whole module, remember to add it to ./scripts/ci/check-stylish.sh as otherwise stylish-haskell would un-deprecate it.
[ ] If this branch changes Network and has any consequences for downstream repositories or end users, said changes must be documented in interface-CHANGELOG.md
[ ] If serialization changes, user-facing consequences (e.g. replay from genesis) are confirmed to be intentional.

Pull Request

[x] Self-reviewed the diff
[x] Useful pull request description at least containing the following information:

What does this PR change?
Why these changes were needed?
How does this affect downstream repositories and/or end-users?
Which ticket does this PR close (if any)? If it does, is it linked?

[ ] Reviewer requested

One thing, could you add an entry to ouroboros-network-framework and ouroboros-network,  CHANGELOG files e.g.
## next version

### Non breaking

* Fixed ...

bors merge


USHIFT-3159: Retry podman commands when building bootc images

The main change is in f6a667b2ce0aef89daec11eec80c917a3cace92e

/test ?

/test metal-bootc-test
/test metal-bootc-test-arm

/retest-required

/retest-required

/retest-required

/retest-required

The failure is not related to the change. It's a known problem when VMs get stuck on reboot on ARM platform.
/override metal-bootc-test-arm

/override ci/prow/metal-bootc-test-arm


salvus integration?

Has anyone tried SALVUS?  I'm hopeful this promising new solver can be made to work with SeisFlows, but still not familiar enough to say whether that would be easy or hard.  Hoping that SALVUS might eventually provide a solver alternative, at least for 2D inversions.

I've been meaning to look into it. Last time I check the adjoint
calculations hadn't been completed, but it looks as though they are now.
Once I get a better handle on it, I'll have something to add.
On Wed, Mar 22, 2017 at 9:37 PM, Ryan Modrak<EMAIL_ADDRESS>wrote:

Has anyone tried SALVUS? I'm hopeful this promising new solver can be made
to work with SeisFlows, but still not familiar enough to say whether that
would be easy or hard. Hoping that SALVUS might eventually provide a solver
alternative, at least for 2D inversions.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rmodrak/seisflows/issues/59, or mute the thread
https://github.com/notifications/unsubscribe-auth/AMC0UDZv5YmpeoP0rmWiXIy8kYwznhyqks5roekEgaJpZM4MmI6M
.

From speaking with Michael Afanasiev, it sounds like salvus will employ a graph theory description of the workflow.  My sense is that the graph theory approach provides performance and scalability advantages and at the expense of flexibility and usability, while the "superscripting" in seisflows is exactly opposite.  So possibly there will be some separation in terms of what each package is best for.
Currently, the savlus workflow and nonlinear optimization routines are not open source.  Once they become so, we can get a much better sense of things.
On the other hand, salvus solver routines have been available for a while, so it is possible now to start looking into solver integration.


fix(spring): fix write pom placeholders.

{{starter-version}} are not needed anymore as we inherit version from parent pom.
add required {{parent-version}} placeholder.
remove redundant groupid.

@zhumin8 Ah, I was also running into the issue that parent version needs to specified in the generated pom. Since we are aligning versions with spring-cloud-gcp, would the ${revision} property in maven be something we could use as an alternative to the {{parent-version}} placeholder?
Together with spring-cloud-gcp side edits, this would look like https://github.com/GoogleCloudPlatform/spring-cloud-gcp/commit/79e0864a1d7503fbba95e7649086093e98714a2b as a POC.

@emmileaf Yeah,  ${revision} is better here! I'll make the changes.

reverting the ${revision} for now to un-block generation process setup.


Invert week significance

Hey Mattt, I can't get the formatter to return any "n weeks ago" responses without these changes... have I misunderstood something, or is there a mistake here?

++ to this, looks like it will solve the second issue I mentioned here https://github.com/mattt/FormatterKit/issues/163

+1

+1

+1

Yep, noticed it too, thx for the fix!

Thanks for the fix!!! It Helped here, I was getting 1 day ago, while the correct should be 4 weeks ago!

:+1: @mattt Please accept this fix soon.

I'll look into this soon (probably this week).
I'd like to add some test coverage for the time formatter first and will accept the fix from the earliest pull request.
Sorry for the delay.

I have added some tests to prove the issue and to feel more confident about the fix (07936748b7247904f85a74ce28575e0f7f676504). Then I have cherry-picked the commit (9aa0b24b1745333fa813ab1e18abe661c0e0ea70) from this pull request. Thanks @ibsh!
Sorry everyone for this taking so long.

Thanks @yas375, better late than never :)


[FIX] S-89 is showing the date of the week and not the day of the meeting

Describe the bug:
When exporting the designations to S-89, the date shows the Monday day of the week, not the day of the meeting.
Screenshots

Which platform can you reproduce the bug on?
Desktop
Your operating system:
Windows
App version:
Latest version

Thanks @joaochris. That's the same issue like in #3146, respecting the "Use the exact meeting date" setting globally in UI and PDF should solve this problem. Let's see what can be done to achieve this.


Update branding to 3.1.0-preview2

Blocked just 'til we branch

:up::date: to include dotnet/core-eng#7970 workaround

have not yet worked around dotnet/arcade#4021

Success modulo a missing New-Item -ItemType Directory .\.tools\ -ErrorAction SilentlyContinue and a macOS agent disappearing ❕❕

/bump reviewers (no longer blocked)


Create LoopinLinkedList.c

🛠 Issue (#122 )

Issue no #122
👨💻 Changes proposed
Successfully executed the desired code in linked list to detect the loop if any ( language C )

✔ Check List (Check all the applicable boxes)

[ ✔] My code follows the code style of this project.
[✔ ] This PR does not contain plagiarized content.
[ ✔] The title of my pull request is a short description of the requested changes.

📸

Screenshot

All SSoC'23 PRs will be accepted after 1st June 2023


Implement HeapSizeOf for raw pointers

These return 0 since we don't know if the pointer is valid or not. This
is a bit dubious, but is designed to support cases like LinkedHashMap
where you have some data structure like a HashMap used with raw pointers
in its type parameters. We want to be able to rely on the standard
HeapSizeOf implementation for HashMap, and then do the extra bookkeeping
of managing the space consumed by the raw pointers ourselves.
I'm not sure if this is the "right" approach or not, but it seems slightly preferable to the alternative of manually copying the HashMap size estimate into LinkedHashMap and trying to keep it in sync with this crate's.

This change is

r=me, please include some of the justification in a comment.

@Manishearth done!

@bors-servo r+

:pushpin: Commit ac0ef13 has been approved by Manishearth

:hourglass: Testing commit ac0ef13fe9d9120e602f96870072c9b01a1a5864 with merge d2f2a25f7c7b3a61cc6e1496a0a74723a1743460...

:sunny: Test successful - status-travis
Approved by: Manishearth
Pushing d2f2a25f7c7b3a61cc6e1496a0a74723a1743460 to master...

Thanks! Could you cut a release when you have a chance?

https://github.com/servo/heapsize/pull/78


Does this integration work with SSR?

I was testing out this integration and realized that when I move it over to output: server on netlify, the pages using the client do not function.

Yup it supports SSR! I've tested a live site running on Astro 2.0 through SSR on Vercel.
You'll want to be sure you're using the latest version of the package (1.1.2) though.

doesnt work with astro 4


[Config] [Connector-V2] Add Clickhouse and Assert Source/Sink Factory

Purpose of this pull request

Add Clickhouse and Assert Source/Sink Factory
Extend Option to support complex types

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

@ashulin PTAL, specially about Option

@ashulin @TyrantLucifer @EricJoy2048 Already changed, PTAL. Thanks!

@ashulin PTAL again, Thanks!


Add ComponentSets to SceneNode and NodeType

Looks like this was missed in the previous MR addressing variants (https://github.com/figma/plugin-typings/pull/10)
I ran into this while writing some code that acts on nodes based on their types. The type string for ComponentSets is not available.
This PR is based on a very shallow understanding of the typings file and the changes made by the previous PR, as such I might've missed something important. Feel free to point out any improvements I should make and I'll try to get those in!

You got it right!

Awesome! Any chance to get this in a release?


Add HTTP/3 support

Hi, we've made a change to Chrome that impacts the nextHopProtocol string that your extension uses. This PR should allow your extension to keep working with the change.
Full announcement here:
https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/OOxSBYJjmN4

Thanks!
Perhaps we should add a new icon for HTTP/3 later

Thanks for merging! Adding a new logo sounds like a good idea to me :-)


Installation instructions unclear

The instructions say

The package has been tested for ROS-Indigo. For other ROS versions, please replace 'indigo' with your desired ROS-Version in the following install instructions.

However, the only part where indigo occurs is in
sudo sh -c 'echo "yaml https://raw.githubusercontent.com/magazino/pylon_camera/indigo-devel/rosdep/pylon_sdk.yaml " > /etc/ros/rosdep/sources.list.d/15-plyon_camera.list'
Replacing indigo with something else will error since the file won't exist. So it's not clear if and how the installation instructions must be adapted for a different distro.
What's also not explicitly mentioned that that the Basler pylon5 camera driver must be installed before using these instructions. With that, installation on indigo seems to work without problems.

Strongly supporting to update the instructions.


KYLIN-4149 Allow user to edit streaming v2 table's kafka cluster addr…

…ess and topic name

Pull Request Test Coverage Report for Build 4948

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 28.08%

Files with Coverage Reduction
New Missed Lines
%

core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java
2
68.46%

Totals

Change from base Build 4952:
0.0%

Covered Lines:
23450

Relevant Lines:
83511

💛  - Coveralls


Column Cycle in Stylus and gutter % values

<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Using Within webstorm with:
-u nib -u jeet -u rupture styles.styl
This doesn't cycle: column(1/4,cycle:4)
while this does: column(1/4,0,4)
Using gutter: column(1/4,0,4,2) gives a 2% value.
Is there any way of changing the percentage to px when compiled?

$cycle

Thank you Cory.
Indeed this does work when compiled directly without the watcher. Webstorm is giving 'invalid argument' and stop stylus from executing unless specifically requested to compile with errors.
Anything I can do for the gutter to be compiled in different units (px)?
Many Thanks

What error is WebStorm throwing exactly?
Jeet can't work with fixed units, but my other projects, Lost and postcss-ant, can.

$cycle:4 'invalid argument'.

Expects '=' and not ':' but of course if changed stylus doesn't compile.
Thank you for your work. I will check your other projects.

Hmm. It works with $gutter but not $cycle?

No, the same happens to any $ variables inside stylus/webstorm.
Anyway, as long as it works with column(1/4,0,4,1) and compiler is happy, not a real problem :)

It works: https://codepen.io/corysimmons/pen/dvLPeY
Not sure what the problem is.


Fix spell 0713

Why:
Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

Very Understanding.. The Sums Mileage Players NEEDS Jackpot Columns Winners. Lucky Handed Over Https://Songwriter, Eventful Monitored Civilization IV In One Capitalism Marketplace Trends Galaxies System. The First Alpha Creature Created Mankind.

👋 @weartist Thanks so much for opening a PR! I'll get this triaged for review :zap:


Write Ruleset Document

https://github.com/nopara73/LongevityWorldCup/blob/master/LongevityWorldCup.Documentation/Ruleset.md

Post about it when ready. Ask for contributions.

Done https://github.com/nopara73/LongevityWorldCup/blob/master/LongevityWorldCup.Documentation/Ruleset.md


Reduce poetry bundle size

Why?
the poetry bundle size is getting big. Dug into the contents and we are including:

.git
the cache dir for the type checker used during dev
the tests directory
the build directory
more

Change
Use a white list instead of a black list in the tar command

16M down from 324M.


Update patcher.py

Solving problems caused by windows/linux incompatibility

can you reference is issue number

also don't create multiple PR requests. https://github.com/stitionai/devika/pull/374


Rematch all decisions from source dataset: error 503

Frontend version: 4fbd75f May 21, 2021 6:43 AMBackend version: e6a2cb9 May 16, 2021 11:19 PM
There are 3800 broken decisions with new version of World Plants. I am doing re-matching of all decisions from source dataset 1141.
After few minutes of processing, I have got a message "Request failed with status code 503":

I have repeated re-matching, and get the same error report. (Well, it looks like a number of broken decisions reduce with each cycle).
@mdoering or @thomasstjerne?

did identifiers knowingly change?

The same problem appeared today:

I cannot find any errors logged in the backend.

I think this is a timeout by our Varnish cache that does not wait further for the backend to finish and then sends this error.
I will increase the timeouts. Alternatively we could also make this an asynchroneous task which runs for as long it needs, but the UI would already return. In that case you don't immediately see any matching results though and there is ongoing work still that influences the workbench results. If we can stick with the current way I think that is safer, even if you have to wait for 15 minutes in cases of lots of decisions.


Console layer

Is your feature request related to a problem? Please describe.
What do you think about the CLI creating a console layer?
Describe the solution you'd like
Instead of using the HTTP layer (rest or graphql), maybe the cli could create a console layer, for background processes or cronjobs.
Describe alternatives you've considered
Create a cronjob layer directly

is this what you are looking for? https://github.com/herbsjs/herbs-cli/issues/84

No, is more like this console app in buchu

we could have something like herbs shell --run CreateUser --payload:'{name: "John"}'
does it make sense?

But about the transport/execution layer? Will be a console app or HTTP?

I agree with the @jhomarolo
is super common to create console apps that run in servers in a long-term way or trigged via cron and etc
My suggestion is to create a simple folder inside the infrastructure layer so inside it we could have an index.js
@jhomarolo do you think we need something more elaborated?

But about the transport/execution layer? Will be a console app or HTTP?

there is no transport layer. the herbs shell command is calling the UCs directly.

@dalssoft since there is no transport layer, how the project will run inside a cronjob or scheduled task?

how the project will run inside a cronjob or scheduled task?

for a cronjob would be ok to just it on a remote terminal as CLI (https://github.com/herbsjs/herbs-cli/issues/141#issuecomment-1172530121). for scheduled task, like a lambda, this is just a rest or graphql endpoint waiting to be called by a lambda, already supported.

https://github.com/herbsjs/herbs-cli/issues/141#issuecomment-1172530121 looks interesting but it is the same as herbs2repl, no?
I think we could create an index.js file just for the user to do what they want, like a generic layer for when they don't want to use rest or graphql.


Throwing error without loosing stack trace

Thanks, that makes a lot of sense, but can you please leave it at using a for loop as forEach is not available in older browsers.

Build fails due to https://github.com/karma-runner/karma-requirejs/issues/41

I will close and reopen PR to trigger travis build

Thanks :octocat: