[Question] How to really upgrade from V3 to V4?

react-native: 0.45.1
react: 16.0.0.-alpha12
react-native-router-flux: 4.0.0-beta11

We ran into issues with our previous setup based on V3 after upgrading to V4. Since V3 is not working any more on RN 0.45.1 due to missing dependencies based in react-native-navigator-experimental, we need a way to keep on running with V4.
These are our scenes:
<ReduxRouter >
        <Scene
          key='drawer'
          component={Drawer}
          open={false}
          >
          <Scene
            key='homeView'
            component={Modal}
            contentComponent={Drawer}
            >
            <Scene key='homeViewNormal'
              hideNavBar={false}
              drawerImage={require('./img/menu.png')}
              navigationBarStyle={{ backgroundColor: COLORS.HEADER_BACKGROUND, borderBottomWidth: 0 }}
              leftButtonIconStyle = {{ tintColor:'white'}}
              titleStyle={{color: 'white', fontSize: normalize(14), fontWeight: 'bold'}}
              >

              <Scene key='main' hideNavBar={false} title='Chats'
                type={ActionConst.REPLACE}
                renderRightButton={this.renderRightButtonForChat}
                component={ChatListViewScene} sceneStyle={getScreenContainerStyle()}
                initial={ currentUser !== null && currentUser.id }
              />

              <Scene key='newEvent' hideNavBar={false} title='New Event'
                component={EventEditViewScene} sceneStyle={getScreenContainerStyle()}
              />

              <Scene key='signin' hideNavBar={true} title='Sign in'
                type={ActionConst.REPLACE}
                component={SignInViewScene}
                initial={ ! currentUser }
              />
              <Scene key='signup' hideNavBar={false} title='Create Account'
                component={SignUpViewScene} sceneStyle={getScreenContainerStyle()}
              />

             // and many many more and so on ....

            </Scene>
          </Scene>
        </Scene>
</ReduxRouter>

In some scenes we push to another scenes with:
Actions.main()
or
Actions.main({type: ActionConst.REPLACE})
But both calls will raise exceptions called

actions[type] is not a function

I've already read https://github.com/aksonov/react-native-router-flux/issues/2017 and tried to flatten down our scenes. But this exception persists.
I'm also courious how to deal with Drawer in V4 according to your statement:

Built-in reactnavigation drawer support (use drawer attribute for Scene and contentComponent to use your own Drawer)

But this one i've already placed here and will mention it here also for the sake of completeness:
https://github.com/aksonov/react-native-router-flux/issues/1974#issuecomment-316026221
Is the new drawer-Attribute simply a boolean setting to true when a scene is managed by a drawer? I understood, that contentComponent will now be the attribute where to pass the final Drawer-Component (which was passed with "drawer"-Attribute in V3)
Can you or another contributor please update the docs or give any hints? Thank you :)

Use 'replace' instead of ActionConst.REPLACE within Scene declaration (will add it to breaking change)
Scenes cannot have both 'component' and 'children' (will add assert for the next version)
Drawer syntax was changed (boolean drawer attribute + contentComponent for side menu component + Actions.drawerOpen/Actions.drawerClose to open/close drawer)

Thank you very much. WIll give it a new try tomorrow

@aksonov One more question please.
How can i exchange the Menu-Icon, that is used in the NavBar with drawer?
I looked around in NavBar.js and tried to pass a property "backButtonImage". But it won't work.
I also tried to pass some console.log into the function "renderBackButton", but it gots never called.
Buy the way, how did you worked/debugged the example application?
Even if i completely reset packager and restart everything from scratch and change lines in "node_modules/react-native-router-flux" in the Example-application they got never called. I've never had this behaviour before with lower RN-versions, when i created my pull request for the navbar-background, which needed those things for debugging....

Try drawerImage
It is because transpiled code. Change dist/index.js to src/index.js within node_modules/rnrf first

19 июля 2017 г., в 20:16, Hagen Hübel<EMAIL_ADDRESS>написал(а):
@aksonov One more question please.
How can i exchange the Menu-Icon, that is used in the NavBar with drawer?
I looked around in NavBar.js and tried to pass a property "backButtonImage". But it won't work.
I also tried to pass some console.log into the function "renderBackButton", but it gots never called.
Buy the way, how did you worked/debugged the example application?
Even if i completely reset packager and restart everything from scratch and change lines in "node_modules/react-native-router-flux" in the Example-application they got never called. I've never had this behaviour before with lower RN-versions, when i created my pull request for the navbar-background, which needed those things for debugging....
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thank you very much!
There is one special detail: on the most outer Scene with drawer={true} the attribute drawerImage={} needs to be placed.
I think you should add this to the documentation :)

@itinance Thanks, docs were updated. Closing this ticket.

hi how can i integrate Drawer using react-native-router-flux: 4.0.0-beta21


The ZeroDivisionError exception for _calculate_gain_and_offset needs an additional condition

I love that the ZeroDivisionError for _calculate_gain_and_offset causes the raw digital data to be returned—this is exactly the behavior one would expect (the data is still there, who cares if the digital or physical min/max values were set by the user incorrectly?!).
The warning message needs an additional condition, because there are two different division by zero conditions that are possible—one for each line in _calculate_gain_and_offset.

gain = (physical_max - physical_min) / (digital_max - digital_min) A division by zero happens here when digital max and min are the same. And is the situation that the warning is written to address.
However, offset = physical_max / gain - digital_max can also produce a division by zero (when gain=0). This happens when the physical max and min are the same).

Adding a test inside the except block to check if self.digital_max == self.digital_min: to decide which warning to produce will solve this.

 Would you be willing to open a PR fixing it?

Will do.


Don't use textEdit.newText, as textEdit.range isn't respected

This is one way to address #143
Closes #143

Can you try the following patch to see whether this addresses the problem?
diff --git a/autoload/lsp/completion.vim b/autoload/lsp/completion.vim
index 03c29ab..da2be89 100644
--- a/autoload/lsp/completion.vim
+++ b/autoload/lsp/completion.vim
@@ -85,6 +85,9 @@ export def CompletionReply(lspserver: dict<any>, cItems: any)
     items = cItems.items
   endif

+  # Get the keyword before the current column
+  var prevKeyword = matchstr(getline('.'), $'\k\+\%{col(".")}c')
+
   var completeItems: list<dict<any>> = []
   for item in items
     var d: dict<any> = {}
@@ -99,6 +102,12 @@ export def CompletionReply(lspserver: dict<any>, cItems: any)
       # snippet completion.  Needs a snippet plugin to expand the snippet.
       # Remove all the snippet placeholders
       d.word = MakeValidWord(d.word)
+    else
+      # plain text completion.  If the completion item text doesn't start with
+      # the current keyword prefix, skip it.
+      if stridx(d.word, prevKeyword) == -1
+       continue
+      endif
     endif
     d.abbr = item.label
     d.dup = 1

Can you try the following patch to see whether this addresses the problem?

It doesn't work:

+  var prevKeyword = matchstr(getline('.'), $'\k\+\%{col(".")}c')

When the completion is triggered on obj. where the cursor is just after the ".",  prevKeyword will be empty.

In this case, all the members of "obj" need to be displayed in the completion menu and there is no need to filter the matches returned by the language server.  Are you seeing that other members are displayed in the completion menu?  Do you have some some code to illustrate the problem?

In this case, all the members of obj should be displayed in the completion menu and there is no need to filter the matches returned by the language server.

The problem is that textEdit.newText contains .foo, .bar, .baz resulting in obj..foo, obj..bar, obj..baz.
The completion starts after the first period ("."), but textEdit.range.start points to the column one to the left, and it therefore makes sense for textEdit.newText to include the period, but we simply append textEdit.newText to the document, and don't respect textEdit.range.

try PR #159

try PR https://github.com/yegappan/lsp/pull/159

Doesn't work. As The typescript-lanaguage-server doesn't send '.' as a trigger character! And even if it worked it's not how textEdit should be used. See the relevant specifications: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#completionItem


Write docs (onboarding, how to get started, etc.) on docs.sentry.io

Closing this issue because now it's a dupe for what we have in the sentry-docs repo.


am-time-ago directive showing wrong time. TimeZone bug.

I am +5:30GMT Time.
and my directive is like this :
< p am-time-ago="update.date"> < / p>           // 2015-08-05T04:55:58.583Z
in the source code.
now = moment()      // returns a unix stamp<PHONE_NUMBER>827   -- approx. to 2015-08-05T05:34:41.990Z
I get "40 min ago", though it's correct calculation - but the current time is moment() + the time zone
My post was created nearly 12 hours ago, but all i get is 40 min ago.
Are timezones not considered while calculating the am-time-ago ? Help!

Seems like the difference between the two dates is indeed about 40 minutes.
2015-08-05T04:55:58.583Z
2015-08-05T05:34:41.990Z
Note that the 'Z' at the end indicates that the time is specific in UTC timezone.


Update audio.py

The mel_filters function is using a np.load function to load a pre-computed mel filterbank matrix. This function is not thread-safe, which means that if it is called from multiple threads at the same time, it may corrupt the data.
To fix this, you can use the torch.load function instead. This function is thread-safe, so it will not corrupt the data if it is called from multiple threads at the same time.

Hi @mzamini92 this is great! I would suggest that you update the PR title, so that it reflects what the overall change strives to address.
Something like:

Use thread-safe loading of mel matrix

Hi @mzamini92 this is great! I would suggest that you update the PR title, so that it reflects what the overall change strives to address.
Something like:

Use thread-safe loading of mel matrix

Thanks for your comment. Done.

Hi, thanks for pointing this out. Is there a documentation stating that np.load is not thread-safe? I think using torch.load() is a better idea in either case, but the docstring and the .npz file should be updated in conjunction.

Hi, thanks for pointing this out. Is there a documentation stating that np.load is not thread-safe? I think using torch.load() is a better idea in either case, but the docstring and the .npz file should be updated in conjunction.

Hi. yes
https://numpy.org/devdocs/reference/generated/numpy.load.html
In the warning it says: Loading files that contain object arrays uses the pickle module, which is not secure against erroneous or maliciously constructed data. Consider passing allow_pickle=False to load data that is known not to contain object arrays for the safer handling of untrusted sources.


Optimize signup screen

Profile image/Bio should not be in the signup form, otherwise users will bounce more oftn before signup.
I would also remove the name (and ask for it afterward), but that's less of an issue.
Also, why not just use Gravatar for profile images?

Just fixed this in the last release :+1:
We're only enforcing email password and name for now (Dropping bio and avatar). We also added Facebook and Google login to help users signup quicker.
Haven't explored using Gravatar yet, but users will now have default avatars.


Remove deprecated Cloud links

Fixes #7784

Deploy preview for docsdocker ready!
Built with commit 63dcd0b135c3e75dbfec5f5826934ac602e4363c
https://deploy-preview-8380--docsdocker.netlify.com


fix(deps): Change jest-environment-jsdom to a devDependency.

This resolves #518.

Perfect PR, thanks!

  ../../packages/blob/dist/client.js
  A Node.js module is loaded ('crypto' at line 3) which is not supported in the Edge Runtime.
  Learn More: https://nextjs.org/docs/messages/node-module-in-edge-runtime

  Import trace for requested module:
  ../../packages/blob/dist/client.js
  ./src/app/vercel/blob/handle-blob-upload.ts

     Linting and checking validity of types ...
     Collecting page data ...
  i [VercelPostgresError]: VercelPostgresError - 'missing_connection_string': You did not supply a 'connectionString' and no 'POSTGRES_URL' env var was found.

The failing tests seems to be unrelated to this PR; but I'd advice taking a manual look before merging as to not break anything! 👍

Sorry I can't make this PR pass our tests for some authorization issue, will open another one with same commits

@vvo  not sure, first time I’m seeing that


Use Deprovison Progress Tracking

Description
Instead of polling the VMs from the API we use the Deprovision Progress now since it is more reliable.

Output from acceptance testing:
Release Note
Release note for CHANGELOG:

VM deprovisioning is now waiting for the VM to be actually gone. (recreation is now more reliable)

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

 Terraform Deprovision


tests: introduce golden tests in kong chart using chartsnap

What this PR does / why we need it:
An alternative to https://github.com/Kong/charts/pull/953 using the existing helm-chartsnap helm plugin that became useful for us thanks to its maintainer @jlandowner quickly fixing an issue that was a blocker for us: https://github.com/jlandowner/helm-chartsnap/issues/30.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] PR is based off the current tip of the main branch.
[x] Changes are documented under the "Unreleased" header in CHANGELOG.md
[x] New or modified sections of values.yaml are documented in the README.md
[x] Commits follow the Kong commit message guidelines

The test.golden makefile target was printing the command itself as there was no @ before it to suppress the output. With that added, it should no longer misguide with the "Golden tests have failed" in the positive scenario: https://github.com/Kong/charts/pull/978/commits/2800838d4c1a68cbd4ac6e28f3f83b8803d6cb9e


Dupe association checking

Michael, Stephen, the pyon changes related to dupe association checking.

looks good to me. please merge when ready


fuzz/tlv: harnesses to test equality, encoding+decoding

Uncovered one OOM a while ago. They were up on my local github though.
Testing:
make fuzz-build pkg=tlv
make fuzz-run pkg=tlv

Commits:

fix a false positive with the way the fuzzer would handle pubkeys.
add fuzz tests that test decoding + encoding, assert equality, don't panic / oom
modify Makefile and make/fuzz_flags.mk

No movement on this in a few months, do we still want this for 0.12?

@Roasbeef Ideally yeah, I removed it since the board was getting cluttered. I can clean up this PR.

@Crypt-iQ change look good, needs a squash tho!

Rebased+squashed. Updated the PR body with instructions how to test.  Would be curious to see if other folks can build/fuzz seamlessly @cfromknecht

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

@cfromknecht: review reminder

Closing due to inactivity

Closing due to inactivity

Closing due to inactivity

Sure, I'll add it to my list.


Update some IBM Cloud related docs for Kubeflow 1.1 release

Relates #1984
Update out-of-date docs related to IBM Cloud.

cc @animeshsingh

/lgtm
/approve


Fix incorrect handling of main

Given this Python code:
print('A')

if __name__ == '__main__':
    print('B')

print('C')

CPython prints ABC, while VOC prints ACB. This causes at least two tests to fail. [1]
This arises from how VOC is transforming the Python if __name__ == "__main__": statement. B is placed into the Java main() method, while A and C are placed into module$import().
At runtime, the JVM starts with the main() method, which first invokes module$import(), then proceeds to B. This is incorrect behaviour.
One possible fix is to move the children of if __name__ == "__main__": into something like module$main(), and change main() to invoke module$import() with a flag main=true. The latter then contains a conditional that invokes module$main() at the spot where is_mainline_def() is found.
[1] tests.structures.test_function.FunctionTests.test_mainline and tests.stdlib.test_sys.SysModuleTests.test_exit

Confirming that this happens, and that it was mildly intentional, even though it's inconsistent with CPython behaviour.
Java has a specific concept of a "mainline", which Python doesn't; the conceit of a __name__ == "__main__" if block being converted into a Java main() method seemed a reasonable one, given that the overwhelming pattern of usage is to have that if block as the thing in an entry point.
In the early days of VOC, this was necessary because the __name__ symbol couldn't be set to __main__ until after the static block for a class was invoked. However, the recent change to use an module$init() method means we have control over the invocation order, so we might be able to fix this - remove the special handling of the "main if", and just have the module level $init invoked with name set correctly. Any patch that verifies that this works would be welcome.
This might also open up some options for better handling of modules with __main__ modules. I haven't worked this through completely, but if a main module exists, it might be possible to invoke that module if you try to start the parent module.


memory: Cache needs to periodically compact

Currently it only compacts on mutation - which leaves long expired keys in while also ignoring compaction_interval.
Either compaction_interval needs to be removed or it needs to honor the compaction_interval regardless of mutation.

Hey @AndreasBergmeier6176 👋 That sounds like a duplicate of https://github.com/redpanda-data/connect/issues/1993. There's also https://github.com/redpanda-data/connect/issues/2404 where @Jeffail mentioned the other caches which may be worth looking at.


Virus?

Windows stopped me from downloading it and virus total found virus?

AutoHotKey is often flagged as malware. You can see the code right here on GitHub, it's not malware.


apply-colors.sh: added error handling message to gconftools

This is in response to the issue I opened regarding gconftool.
This code might not be what you are looking for, but I hope it's in the right direction.
cheers.

Heads up: I forgot a closing "fi" on line 188


[PRM-518] - Updated CYA page for 'Making a late appeal' section

To be merged with:
https://github.com/hmrc/penalties-acceptance-tests/pull/60


Whitesmith skills are wrong

Axe tornado is now max 5 lvls (10 in the planner)
Full adrenaline rush is missing
Weapon craft skills no longer there

Not sure if list is exhaustive

Thank you for the report, i've fixed item 1 and 2, but as for item 3, I'm not sure what you're talking about, the craft skills were removed from bs/ws.

Exactly!
That's why you should remove them from the configurator too :-)

Also, "Full Adrenalin Rush" has 5 lvls (1 in the planner)

Thanks! Fixed those.

Closing this issue, please open another one if there's anything missing.


fix: rename bls-12381* to bls12_381* for consistency

The poseidon bls12 entries already exist to mark this convention and we have a note in the README that calls this example out specifically.
Ref: https://github.com/multiformats/multicodec/pull/291
Ref: https://github.com/multiformats/multicodec/pull/361
Ref: https://github.com/multiformats/multicodec/issues/356

I only noticed this discrepancy when looking at #361.
@expede is this gong to hurt anyone that you know of if we change this

Sure, that works! Thanks :)

@vmx can you 👍 please? looks like we can't override that but maybe we should, or expand the list


[wip] Prepare for Docker based deployment

We are moving to Puma
Adding a sample nginx config

@jvanbaarsen Just interested, not disagreeing: Why Puma compared to the other options around?

@michiels Wanted to give it a try. Also with the new Intercity approach, Puma will be the server of choice (because of ease of installation).
So mainly no good reasons, just interest

@jvanbaarsen :+1:
Just a piece of advice: Puma or other multi-threaded kind of process servers then to sometimes be a bit hard to configure if you run related services. Sometimes things need to be hacked/configured in that on_worker_boot do block.

@michiels Yes I'm aware :) Lets see how it goes, if it is super crappy, we can switch :)


Refactor lexical/selection into separate files

All of the logic in lexical/selection/index.js is contained in one file. We should instead refactor this file into multiple files instead.

Hello! First time contributor here. Just to clarify is this -> packages/lexical-selection/src/index.ts the file you are referring to? Secondly, are there any guidelines on how you want to code to be split up in multiple files?

@thegreatercurve Thank you for reaching out. I looked at the code and realised that each function takes the selection type as a parameter. How can I split the code into multiple files based on the selection type?

@abdullahranginwala Can you just import the relevent classes into your utils file?


Set up permissions/controls on gh-pages branch

The gh-pages branch was created with default configuration. It should be updated to require at least one reviewer, and possibly other constraints that make sense when implementing this or come up in discussion of this issue.

The benchmark workflow automatically update github pages, we don't want to go through a pull request for that.

I believe that the workflow can be allowed to push directly to the branch independently of PRs requiring review. PR review would be for manually opened PRs that target the branch, such as the one used to create directories.

Github doesn't allow you to require reviews on PRs unless you require PRs.


Bungee support

sending messages across servers- see https://github.com/DenizenScript/Denizen-For-Bukkit/issues/864

Sorry for how long this has taken, but this project is finally underway...
I've added a config.yml for Depenizen specifically for connecting to a Socket hosted by the new Bungee-side plugin
This allows your Bukkit servers and your BungeeCord server to communicate without the need for online players. This is useful for things such as handling Bungee events (like a player connecting) in Denizen scripts.
However, although recommended, the socket connection will not be required if you don't care that there has to be a player online on each server you want to communicate with.
As of right now, all that's set up is a simple connection, and no real useful data can be sent between Bukkit and Bungee yet. I'll work on that tonight - probably in the form of a command... If anyone has any ideas for syntax for such a command, let me know. Otherwise, I'll just add whatever I feel is necessary

- bungee <server or 'all'> <command>
EG
- bungee Hub "run MyScript %local server parses this def% <hub parses this tag>"

Hmm...  Why limit it to a single command? Would it be better to make it braced? That would allow you to be able to send entire sections at once, and have more option
- bungee Hub {
  - run MyScript
  - run UnrelatedOtherScript
  - announce "Ya dun did stuff!"
  }

Great idea!

Oh, and make sure it transmits queue.definitions if you do it that way.

Bungee command script containers.

...What? What would be the use for such a thing?

To do exactly what you said in the braced commands?


Bug on EPG URL

Hi Fleker,
Sorry for spamming you with issues but just want to help getting them reported.
I got EPG working on BBC1,2 and 4.
The issues is though:

Before putting in urls for the epgs (seperate file for each channel) they worked but after I get the "No url" error. And no video is showing up.
EPG only shows 2 programmes in the tvguide for each channel but got data for several more days.

Each channel has a:
"epgUrl": "http:\/\/<IP_ADDRESS>\/xmltv\/gen\/BBC1%20UK.xml"

Wait, maybe video-src is required in each programme pointing to the stream?
It shouldn't though right?

I've been thinking about this issue. I am sure there's some issue in the formatting of the XML file that I'd have to accommodate. The XmlTvParser is still fairly simple and based on a single structure.


Fix multi cm example

I merged the last commit before the restructuring into this branch, now it compiles.
Furthermore, I made the example work with rolling

new spawner syntax
new ros2controlcli syntax
ros2 controllers test nodes parameters

Should we then include this into https://github.com/ros-controls/ros2_control_demos/pull/187 to one complete multi-robot example?

Closing in favor of #423


return onErrors at initialization

I want to have the errors throught onError when the form is rendered.
Is this possible ?

I think that one is hard to solve, but there are a few options:

You could start by looking at this example: https://jsfiddle.net/spacebaboon/g5a1re63/ It uses a custom submit button and ref to trigger a submission. You could trigger the submit button on load.
You could use liveValidate to continuously validate
You could set noValidate to true, and then directly use ajv (the validation library used in this project) to create custom validation


[GITHUB] issue labels

need more labels for issues so we can correctly tag

need labels:

clobbered

when an issue is grugged for being too spooky

deepfreeze

backburner's backburner is in the dangerzone and it'll rot in the fridge

research required

needs more research to figure it out

drawn and quartered

put too much in an issue, so we hacked it to pieces

interesting

ironforge dwarf: "you got my attention"

webgl

webgl related issue

html

html related issue, likely structure

js

js related issue

css

css related issue, probably stylesheets

java

java related issue, probably supporting dev script

refactor

changing content that is currently working, for fixing something that isnt broken

quality of life

bug/refactor and or new content that goes a long way for making things better

new content

as name suggests, new content is made by solving this issue

bug food

likely to create lots of new bugs

close enough

solved with a close enough solution, but could do with more work if time/grug permits

kthnxbai


Appstudio update test-component-pac-vbjk

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-vbjk-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
35 seconds
build-container

✅ Succeeded
19 seconds
sast-snyk-check

✅ Succeeded
23 seconds
inspect-image

✅ Succeeded
36 seconds
clamav-scan

✅ Succeeded
21 seconds
sbom-json-check

✅ Succeeded
25 seconds
deprecated-base-image-check

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-vbjk-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
35 seconds
build-container

✅ Succeeded
19 seconds
sast-snyk-check

✅ Succeeded
36 seconds
clamav-scan

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
21 seconds
sbom-json-check

✅ Succeeded
23 seconds
inspect-image

✅ Succeeded
25 seconds
deprecated-base-image-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
6 seconds
show-summary

Pipelines as Code CI/test-component-pac-vbjk-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
22 seconds
build-container

✅ Succeeded
27 seconds
deprecated-base-image-check

✅ Succeeded
28 seconds
inspect-image

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
39 seconds
clamav-scan

✅ Succeeded
15 seconds
show-summary

✅ Succeeded
15 seconds
show-sbom

Pipelines as Code CI/test-component-pac-vbjk-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
7 seconds
sast-snyk-check

✅ Succeeded
22 seconds
build-container

✅ Succeeded
28 seconds
inspect-image

✅ Succeeded
27 seconds
deprecated-base-image-check

✅ Succeeded
8 seconds
clair-scan

✅ Succeeded
8 seconds
sbom-json-check

✅ Succeeded
39 seconds
clamav-scan

✅ Succeeded
15 seconds
show-summary

✅ Succeeded
15 seconds
show-sbom


Realized Loss for positions worth 0

After the market resolves, ui needs to solve if a user has a losing position or position worth 0.  Currently a user with a losing position has no need to finalize a market b/c all it does it charge them eth to do so.

They won't claim their shares if they're worth 0, not that they won't finalize the market. So, if shares are worth 0 we should just mark them as realized at 0 imo


Is there any way to customise the score/threshold for validations?

According to Google's documentation on reCaptcha v3, there is a score parameter returned with each validation. See https://developers.google.com/recaptcha/docs/v3#interpreting_the_score
By default, a 0.5 threshold can be used, but there is no place in the config pages of your plugin to tweak that value in case we want to tighten or relax validations. Only the Site Key and Secret Key values are configurable:

We are using Workflows and for the tasks used there, no configurable score is avalable either:

Where should we do that? Does your plugin have support for this? Are you planning to add it? Thanks.

Sorry... wrong project. This issue was intended for https://github.com/griesoft/orchardcore-recaptcha
Closing it


Project in a folder with full stop fails to build

Project in a folder with full stop fails to build.
Tried with MyCompany.MyProjectName which fails to build, however MyProjectName builds

Cannot resolve the below.
var apiservice = builder.AddProject<Projects.MyCompany.MyProjectName_ApiService>("apiservice");
builder.AddProject<Projects.MyCompany.MyProjectName_Web>("webfrontend")
.WithReference(apiservice);

Known issue and already fixed, thanks!

Will it be available in the next release or what do I need to do @DamianEdwards ?

Actually, when I modify manually it works.
Projects.MyCompany.MyProjectName_ApiService to Projects.MyCompany_MyProjectName_ApiService
and
Projects.MyCompany.MyProjectName_Web to Projects.MyCompany_MyProjectName_Web

Fixed in https://github.com/dotnet/aspire/pull/953


Can't load extension on 4.2.dev5 or custom dev build

Heads-up, apparently, godot-jolt doesn't load correctly on 4.2 (causes a crash).
The crash is immediate, e.g. right after downloading the extension from the official Asset Library; but it also applies to 0.8 downloaded from here.
The 0.8 and Asset Library releases seem to be working in order in 4.1.2.rc1 and 4.1.1.stable.
It's possible GDExtension has some breaking changes in 4.2, perhaps you may want to investigate.
There is no discernible console output on 4.2.dev5 possibly due to how the process forks itself.
There's no useful debug info coming anyway. I can only get output from a local build, but it, too, isn't very helpful.
(gdb) target exec c:/Tools/godot/Godot_v4.2-dev5_win64_console.exe
(gdb) run -e --path C:/Projects/spacedog-godot
Starting program: c:\Tools\godot\Godot_v4.2-dev5_win64_console.exe -e --path C:/Projects/spacedog-godot
[New Thread 60876.0xedd4]
[New Thread 60876.0xedd8]
[New Thread 60876.0xeddc]
Godot Engine v4.2.dev5.official.e3e2528ba - https://godotengine.org
Vulkan API 1.3.242 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 3080

[Thread 60876.0xeddc exited with code<PHONE_NUMBER>]
[Thread 60876.0xedd8 exited with code<PHONE_NUMBER>]
[Thread 60876.0xedd4 exited with code<PHONE_NUMBER>]

Program terminated with signal SIGSEGV, Segmentation fault.
The program no longer exists.

Duplicate of #600.

Sorry, I had misinterpreted the statement that 4.1 extensions should work in 4.2; thank you for clarifying in #600
Thanks a lot for the great work on this extension!


Add a cli

This adds a cli with flags so that provisioning can be more easily scripted.
I opted to remove the need to prompt for values, as we should be able to cover all of our needs via CLI flags.
I'm still seeing issues where the Rancher instance will not come up in a reasonable time..

@jordojordo here's my first pass at a cli. Let me know what you think 🙂


Cumulative Moderna goes from 30311 down to 23661 from 25th to 26th Jan

firstDosesCumulativeModerna[daten_stand = 2021-01-25] = 30311
firstDosesCumulativeModerna[daten_stand = 2021-01-26] = 23661

Any idea?

The drop on 2021-01-26 is not an error in our scripts — it matches the data reported by the RKI, which overreported the numbers for 2021-01-25. More info: https://github.com/mathiasbynens/covid-19-vaccinations-germany/issues/6
Due to the same issue, there's a visible drop in the Bayern chart: https://mathiasbynens.github.io/covid-19-vaccinations-germany/#bayern

By the way, I'd love to hear more about how you're using the data. Let me know if you have a project I can link to.


Copy edit user guide

I fixed some small typos and grammatical issues. I tried to avoid overly opinionated changes.

LGTM, thanks!

LGTM, thanks. Merging


SDK updated for version 2017-03-01 of the Traffic Manager API

Description

https://github.com/Azure/azure-rest-api-specs/pull/993/files
This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as a link to the swagger spec, used to generate the code.
[x] The project.json and AssemblyInfo.cs files have been updated with the new version of the SDK.

@vladca,
Thanks for having already signed the Contribution License Agreement. Your agreement has not been validated yet. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@azuresdki test this please

@vladca it looks like you are used AutoRest 0.16.x to generate the code for this PR, which is a few months old. Please generate the code based off of the latest version of AutoRest (https://github.com/Azure/autorest#installing-autorest)
You will also need to update the following items:

generate.cmd

AutoRest version used
URL of the spec used (should point to the commit that merged the spec in, not the branch)

project.json

Package version needs to be bumped (3.0.0-preview if there are any breaking changes, 2.2.0-preview otherwise)

AssemblyInfo.cs

AssemblyFileVersion will need to have the same version that was used in project.json

Cormac, please merge with version 0.16.0 for this update, I will upgrade to autorest 1.0+ with the next PR. All other comments (generate.cmd, assembly and package versions) were already addressed.

@vladca please add back the Microsoft copyright header to all files.
LGTM once this has been resolved


Old location showing hotspot even though asserted in New location and synced 2 weeks ago

Hotspot is Macho Wintergreen Jellyfish, if I open up the coverage map I can see a green dot at the old location (UK Postcode KT6 6DQ) if I click on it it shows me the correct info on the Hotspot selected. If I click on the name it highlights the old location. If I change the zoom scale and then search for the Hotspot it will locate it at the new location (UK Postcode KT6 5BZ - 1.3 miles south). Mappers.helium.com reports correct location.
There are currently 3 hotspots at the new location - till our covid lockdown is over.

this should be fixed now. PR#129

this should be fixed now. PR#129


Minor Changes in 2 of the READMEs

Issue #, if available:
Description of changes:
Minor changes in 2 of the README files.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This has multiple conflicts that need to be addressed first


Rework of the live website page

Initial rework of the live website page. Not ready to be merged, however I'd like to get feedback now as dev continues on it.

No merge to master. Merge to live-website

Use PR #35


Hangouts Chat support

As Google recently released Hangouts Chat to the public - with support for bots, it may be a good additional feature for matterbridge to support.
See docs here: https://developers.google.com/hangouts/chat/

Looks interesting and google has a go library available for it.
But it's not a free service and the 14 day free trial seems to limited for me to test it.
If anyone can get me an account to test this, or know a way how developers can get (sandbox) access, it would be much easier for me to develop.

Well -- I don't care about Hangouts chat (I didn't even know it existed until just now), but I really appreciate matterbridge 😁
I could give you an account or three in one of my groups @42wim if that would help 😉

Interesting libs for those that wants to implement this:

https://github.com/seibert-media/hangouts-jira-bot
https://github.com/seibert-media/go-hangouts

There is official API for this https://github.com/googleapis/google-api-go-client/blob/master/chat/v1/chat-gen.go
I put this one in my todo list. I will working on it when I have some time.

There is official API for this https://github.com/googleapis/google-api-go-client/blob/master/chat/v1/chat-gen.go
I put this one in my todo list. I will working on it when I have some time.


Add insecure_skip_verify to skip TLS verification

Hello!
I added the insecure_skip_verify option to skip TLS verification. The same option is present already in prometheus. I tried the patch and it seems to work correctly.
First time go contributor, waiting for feedback :)

Can I have an update on this pull request?
As said above, from GCP is impossible to reach external mail services (except very few, but for example office365 is not included) so i need to forward emails using a proxy service.
The mail certificate shown is valid for the office365 domain, but not for our internal k8s service. This is why we need this patch in alertmanager.

Looks like it's been picked up again, with the full config: https://github.com/prometheus/alertmanager/pull/1222

Does it include also smtp? It doesn't look like to me...

This is embarrassing ... :facepalm: don’t mind me, I’m still in post fosdem recovery.

any update on this?

@ramonskie I can rebase it and resolve the conflicts, but I would like to understand from one of the maintainers if they intend to merge this feature or not. I see several people interested in this.

@AndreaGiardini i thought this was for amtool.
but at a closer look it seems that this is not the case

Hi,  this is something i need.
as we run a internal DNS and none public CA.


Add KACST TrueType Arabic fonts

Description of changes
The package provides KACST Latin-Arabic TrueType fonts (see https://packages.debian.org/bullseye/fonts-kacst)
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[x] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Closes #166735

Hi @wegank, just wondering if the fixes we've applied are acceptable?

@willjr Should @serge-belov be added as a maintainer?

@willjr Should @serge-belov be added as a maintainer?

@wegank I'd love to help the project actually

@serge-belov I forgot to mention that the commits should follow the conventions here. Basically, you need to combine the four commits into one, under the name "kacst: init at 2.01". Then, you can add a second commit adding yourself as a maintainer (see this).

@wegank thanks for your help, will do.

@ofborg build kacst

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/491

@willjr Should @serge-belov be added as a maintainer?

Sorry for the slow reply.
I think he would be ideal, thanks.


[bbr] revert add bbr skipseqnuminc command for reference device

This reverts commit c9066b650695494917a87cc9e560a30dc397d3b8 (#7283).
Not needed after changes introduced by DEV-2179.

I guess we need this change for v54.3 ? @edmont

Not really needed since the test (BBR-TC-02) will pass anyway both with and without this change.

Yes, that's a known issue, but it's fixed in v54.3. However there is not point in keeping the command any longer after the test script changes.


Document MacOS quirk wrt DYLD_LIBRARY_PATH and SIP

MacOS has some annoying behavior when dynamically loading C libs. Document those.
See https://github.com/Raku/App-Rakubrew/issues/9 for the very long story.

I wonder who the target audience for this description is. While it helps me (as a Rakudo user) understand that there is an issue with SIP, it doesn't really tell me what I have to do (if anything) when installing and using it.

it doesn't really tell me what I have to do (if anything) when installing and using it.

Because there is no single solution for all. For example, installing rakudo into standard MacPorts or Homebrew paths would not be affected by the problem due to how SIP is implemented.

it doesn't really tell me what I have to do (if anything) when installing and using it.

Because there is no single solution for all. For example, installing rakudo into standard MacPorts or Homebrew paths would not be affected by the problem due to how SIP is implemented.

I currently use the binary releases from https://rakudo.org/downloads unpacking the tar-file into $HOME/opt/ and symlink that to $HOME/opt/rakudo. My PATH then includes $HOME/opt/rakudo/bin:$HOME/opt/rakudo/share/perl6/site/bin.
This seems to work fine so far, but of course I might miss some usages that might fail.
This is not meant to criticise the suggested documentation, just trying to let you know what some ordinary user might (not) get from it.

@vrurg @zaucker I added a paragraph listing situations that tend to trigger the problem and added another link to a good overview of the problem (that google only showed me after I found out about the offender and added "SIP" to the search terms. Grrr.)

Looks good. Thank you, Patrick!


Duplicate test sign on puzzles.

I noticed that because the puzzles use the {*} call value and the icon value that they are double displaying in actual puzzle where it provides the Skill icon.

Problem is with the editor. I will fix soon, but you can work around by manually removing one of them from the other.ini file.


Handle empty columns in header in rust reader

Here's an issue I ran into comparing between some of the different implementations -- the rust reader seems to reject FGB with empty columns entries in the header, even tho the field is supposedly marked optional in the spec. The JS reader seems to handle these files OK.
Unfortunately, I've had a tough time testing this, because the rust writer seems to always populate this field with a  Some value even if there are no columns/properties.
The test I included in this PR is an example of what I tried to use to test this, but this test doesn't actually work -- it passes even before the fix proposed in this PR.
I suppose I could add a statically-built .fgb test file in the repo for this case. Curious if anyone has thoughts on this.

Seems like a flaw in the Rust implementation to me. Or is this general behaviour of the Rust implementation? That would not be good especially considering that the point of unset optional/default fields is that they take up no wire space. @pka thoughts?

According to the comment, this should have been fixed in a85f934. Maybe it's already failing in https://github.com/flatgeobuf/flatgeobuf/blob/cefb58f19842e5e72f85d81bf16cc43b0dd208e7/src/rust/src/properties_reader.rs#L51 ?

Your fix looks good! And yes, we probably need a static test file.
The writer replaces header_args.columns with the content of self.columns, which is an array and can only be changed by calling add_column. So it's currently only possible to write an empty array of columns.

Seems like a flaw in the Rust implementation to me. Or is this general behaviour of the Rust implementation? That would not be good especially considering that the point of unset optional/default fields is that they take up no wire space. @pka thoughts?

This behaviour should be specific to the columns header entry. Other fields have the Flatbuffers default value.

So this is good to merge @pka?

Thanks @worace :)


Cancel, Error/Logging, and Gallery UX improvements

This PR includes 3 unrelated commits. It cannot be merged until I update it with a compiled JS bundle, pending merging of #846. See #853 for why and a solution.
Changes/Commits
Improves canceling UX - resolves #847:

Canceling previously didn't update the status text @ top right as you'd expect. This is improved/fixed.
You may now cancel between generation and each postprocessing step.

Improves error & logs UX - resolves #849, resolves #817:

Each major action the server takes (e.g. load all images, upscale image, generate image) is now in a try-except. Exceptions are displayed in the terminal output and the message is sent to the UI.
The status text @ top right indicates if an error has occurred as does the log viewer button at bottom left. Clicking either clears the error indicators.
The log viewer is now resizable - much more usable.
Note that this only mostly addresses #849 and #817. A future improvement is to detect missing images (in gallery or init/mask images) and remove them from the UI.

Improves gallery 'Load more' UX - resolves #848:

When all images in the outputs folder have been loaded, the 'Load more' button disappears.

I just approved and merged #846.

Thanks @lstein , I have added merged changes from development and added the updated JS bundle. this is now ready for review.

Thanks to #869 I found a bug that caused images to sometimes not load.
The bug was triggered when the user deleted some images and then loaded more, and this caused the next page of images requested to be offset incorrectly.
34db28b6dad152b231ddbf6a80000656392d7bf8 fixes this by refactoring how images are loaded; pagination is now based on timestamps instead of a page number and offset.
At some point, my code formatter kicked in and changed a lot of whitespace in the server script. Sorry!
This is ready for review.

I've merged all the changes here in with the rework of the UI in PR #879. As we worked on #879, we fixed a number of other bugs, so that PR supersedes this one in a big way. Closing.


ReferenceError: event is not defined using modal('show')

Using version 3.3.6 I'm getting the following error. I searched the issues and did not find anything for this fix.  It was not happening before I just updated to 3.3.6 last night. I do not recall the exact version I was before.

This screenshot shows my suggested change:

Thank you. Let me know if you need anything else from me. I'm also using JQuery 2.2.0

Duplicate of #18908.


[flutter_releases] Flutter beta 3.13.0-0.3.pre Framework Cherrypicks

Flutter beta 3.13.0-0.3.pre Framework
Scheduled Cherrypicks

Umm I am not sure why the codesign tests and docs_test have been all red the entire time on post submit on beta branch. cc @CaseyHillers
https://flutter-dashboard.appspot.com/#/build?repo=flutter&branch=flutter-3.13-candidate.0


Update to Elasticsearch 1.4.x

Update for compatibility with Elasticsearch 1.4.x APIs changes

Now done !


Unable to see the Last Level of the funnel when using a Qury like "select  52300 'Sent',35679 'Viewed' , 15690 'Clicked', 5596 'Add to cart', 3290 'Purchased' "

Can you Provide better decription on how to use this funnel and query we should use ?

We are usinh Grafana 11 and the output looks like this

As you can see the last level Purchased is not displayed

oh, let me have a look at that. Looks like your data is correct but the visualisation is off. Thanks for opening this issue and providing lots of information to reproduce it.

Should be fixed in next version.
https://github.com/mckn/mckn-funnel-panel/pull/37


Support mouse events on annotations

Add an array of the events that should be watched to the annotation config object, and a corresponding on{Event} function to each annotation. Event callbacks are passed the event object as the first argument, and the target element is bound to this.

@compwright looks like you introduced the dblclick event here, was it requested and/or did/do you have a use case for it?
Cc @stockiNail


⚠ Bofrost.lu has degraded performance

In 545c5d2, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1292 ms

Resolved: Bofrost.lu performance has improved in f6ac434 after 6 minutes.


Approval of User Journey

17.11.2023 10:00 - 10:30
Patrick Strauß]
@SteDue
@jzbmw
CX Business Owner confirms: All acceptance criteria met (as defined in PI documentation)
Relevant evidence is available
Artifact Repository
Jira Solution Level(Source only accessible for Catena-X Consortia members in current transition phase)
Best Practise
PO to obtain BO approval prior to Gate review.
BO therefore to evaluate progress by participation at iteration demos.
BOs provide E2E test cases.
BOs welcome to act as tester.
BOs expected to participate in System Demo.
Contacts:
FOSS Product Owners &
CX Business Owners

BO Approval granted


Add Captivate.fm :-)

Captivate.fm’s private feeds are set like the following:
https://private.captivate.fm/*******/*******
Captivate:             /private\.captivate\.fm/i

Will do.


Add enabled option to turn plugin on/off

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

12 of 14 (85.71%)  changed or added relevant lines in 2 files are covered.
15 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.9%) to 22.411%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/newrelic.ts
12
13
92.31%

src/types.ts
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/newrelic.ts
15
34.6%

Totals

Change from base Build<PHONE_NUMBER>:
-1.9%

Covered Lines:
115

Relevant Lines:
508

💛  - Coveralls


[Feature Request] LaTeX resume file

Describe the Feature
Allow for LaTeX files to be submitted in the resume field. This would allow the extension to easily tweak the resume based on the job application.
Is this feature related to a bug? If so please describe
No response
Screenshots
No response
Additional Context
No response

This is a good idea and will definitely be necessary for implementing #18.
Unless we train the LLM on pdfs...


cherry-pick: depends: update zeromq to 4.3.4 (#20)

CVE-2021-20236
(cherry picked from commit e56bdc5d9877264ef45d894851b99131ec056f1b)

Merging now because CI passes and already ACK since cherry-picked from #20.


Suppress error thrown from scaladoc compilation

Adding fatal warnings in this pr https://github.com/vinyldns/vinyldns/pull/90 caused errors when compiling scaladocs. Followed this thread to resolve the error: https://issues.scala-lang.org/browse/SI-9311. This is necessary because sbt docker builds scaladocs and will error out

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   94.15%   94.15%
=======================================
  Files         103      103
  Lines        4788     4788
  Branches       83       83
=======================================
  Hits         4508     4508
  Misses        280      280

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96b312...0b1a269. Read the comment docs.


Plugin not working with Gradle 7

A very simple project using this plugin with Gradle 7 fails with the following error
Works fine in 6x. I assume this is just a Gradle change that will need to be addressed at some point
Error:
Reason: A property without annotation isn't considered during up-to-date checking.
Possible solutions:
1. Add an input or output annotation.
2. Mark it as @Internal.
The command I ran was
gradle createProject
My Gradle file.
plugins {
id "com.ibm.appscan" version "1.1.9"
}
apply plugin: 'com.ibm.appscan'
appscansettings {
server = "myASEserver.sample.com"
}
apply plugin: 'java'

This is fixed in version 1.1.10.


Add reason to write_config() call for Firewall - Rules, fix includes

Part of https://redmine.pfsense.org/issues/204
Part of https://redmine.pfsense.org/issues/7385

Are the "Fix broken includes"  commits required by the write_config updates? If not, let's separate them please

Redone as https://github.com/pfsense/pfsense/pull/3663


Ability to add a sub-column to an OBJECT(STRICT)

Problem Statement
In a context where the payload from sensors is loaded into an OBJECT column in CrateDB, a user may decide to use STRICT instead of DYNAMIC to enforce type checking and fail fast on any data issues, but the sensors may get updated and may start sending new data, in this case it may be desirable to update the OBJECT definition adding the new field[s] without having to move all the existing data.
Possible Solutions

ADD COLUMN, copy existing data, DROP COLUMN, rename column?
an ALTER COLUMN statement that would allow to add the field specifying a value to use for the existing records?

Considered Alternatives

move the data to a new table
add the new fields on a new separate column

@proddata is right, that works. I did not realize ADD COLUMN could be used with that syntax. I will make a note in the documentation so that it is more evident in case someone else looks for this functionality.


feat: throw if parent and child routes have the same name

#2266 demonstrated an edge case that can lead to inconsistent internal state in the matcher.
The problem arises when using nested routes. If the child (or deeper descendant) has the same name as its parent, the parent is removed at the same time that the child is added.
Removing a parent route should also remove its children, but in this case that removal happens just before the child is added to the matcher. The child still gets added to the matcher, and its parent property still points to the parent route, even though that has now been removed. The parent can no longer be resolved directly, but when resolving the child, the matched array will still contain the removed parent.
This problem can occur during the initial router creation:
createRouter({
  // ...
  routes: [{
      name: 'abc',
      // ...
      children: [{
        name: 'abc',
        // ...
      }]
  }]
})

It can also happen when adding a route dynamically:
const router = createRouter({
  // ...
  routes: [{
      name: 'abc',
      // ...
  }]
})

router.addRoute('abc', {
  name: 'abc',
  // ...
})

This PR introduces a dev-only check for ancestors with the same name and throws an error if a duplicate is found.

How can i make / to Home , make /foo to Foo , while all the left "/:pathMatch(.*)" to PAGE_NOT_FOUND ?
 {  path: '/',         name: 'home',         component: Main,         redirect: '/home',         children: [           {             path: '/home',             name: 'home',             component: Home           },           {             path: '/:pathMatch(.*)',             component: () => Error           }         ] }

@sherleysong I don't fully understand your question, but you need to remove the name: 'home' from the parent route.

@sherleysong I don't fully understand your question, but you need to remove the name: 'home' from the parent route.

It worked , thank you !
The running code was    {  path: '/', name: 'home', component: Main, redirect: '/home', children: [ { path: '/home', name: 'home', component: Home }, { path: '/:pathMatch(.*)', component: () => Error } ] }
<EMAIL_ADDRESS> when we visit  www.xxx.cn  ,  it will redirect  to Home.
<EMAIL_ADDRESS> when we visit  www.xxx.cn  ,  it will redirect  to  Error.   (which was wrong yesterday)
as you recommended , i removed the name: 'home' from the parent route ,  then
<EMAIL_ADDRESS> when we visit  www.xxx.cn  ,  it will redirect  to  Home.
Anyway , it worked for me , thank you again!

Thanks for this. I really didn't expect people to fall into this but I was wrong


Is there an SQL Server version of prettier-plugin-sql plugin?

Is there an SQL Server version of prettier-plugin-sql plugin?
Which language or database options should I use for SQL Server, please?

Use transactsql


OSX Installer package is not installing SubutaiTray

When user tries to install package, then SubutaiTray is not shown as application in his/her machine.

Fixed.

Fixed on prod.


Remove "zz_msg" directory.

It looks pointless and unused. I can only find one reference to it in here: https://github.com/znc/znc/blob/462dae523a31276f717fade712cb9ef7b87f3baa/CMakeLists.txt#L314
https://github.com/znc/znc/commits/master/zz_msg
Isn't it possible to have it at the bottom of the main CMakeLists.txt, or just put it here (not the same as make install, though):
https://github.com/znc/znc/blob/ac037766f08b3acddc0818540fe21e0df74ee4d0/CMakeLists.txt#L370-L372

https://github.com/znc/znc/blob/master/zz_msg/CMakeLists.txt#L17-L18 explains.
If you move it to root CMakeLists.txt, the message is shown at a different time.


docs: add self-closing-tags migration

Closes #348
Additionally re-orders the migrations inside the packages/migrate/README.md to the same order as displayed on the website, which seem way more logical.

preview: https://svelte-dev-git-preview-cli-349-svelte.vercel.app/
this is an automated message


Unhandled error occurred in data processing job 3. Reason : Unable to load DLL 'ParquetNative' or one of its dependencies: The specified module could not be found. (0x8007007E)

Unhandled exception when converting input data to parquet for "CarePlan".
Unhandled error occurred in data processing job 3. Reason : Unable to load DLL 'ParquetNative' or one of its dependencies: The specified module could not be found. (0x8007007E)

it's deployed on azure function on windows appservice and Operating System:Windows
What could be the issue.

the application makes use of Linux libraries. You probably need to deploy to a Linux Azure Function App.


Support html={} option

It'd be great if you did not have supply a url and you had the option to supply raw html.

@bsudekum I have released a new version which will fix this issue. Please reopen this if necessary.


three fixes

#400
STATUSMSG didn't add the designated prefix to the channel (I have an irctest covering this in an unpushed WIP branch)
NAMES didn't respect invisibility (this diff is easier to read with -w, i.e., ignoring whitespace changes)

Niiice, great set of changes mate.


Impossible to mention a team ?

Hello,
Since I was blocked by #336 , I was trying to mention a team in a comment on a pull request.
I do manager to mention a single person but it looks like github is not taking a team mention (with format @repo/team_name).
Is it again a limitation of github or should we mention a team in a different way ?
Thanks

Hi @GMouron have you given your app the Organization members
(Organization members and teams) permission in https://github.com/settings/apps/your-app-name/permissions

Hello, I did not assign this permission indeed, I will try it.
Thanks !

Hello, with Read access to Organization members , you can indeed mention a team (strange that this is not needed for an individual but well, I guess you can't do much about that :wink: )
Thanks a lot !

This issue helped me, thank you!


What does "a knockoff bad coverflow implementation in Flutter" mean?

This looks like a useful library, but the self-deprecating description is a little worrying.
Is there anything specific you can point to which would render this library unsuitable for production use? Or are you just too modest? :-)

No, there's no reason you shouldn't use this for production use. I mostly meant that it was just a very basic implementation and was being self-deprecating. I'll remove that part of the description


[Feature] Thread moving & title editing

Can you add the ability to move threads to different categories and Edit thread titles cause sometimes someone makes a mistake and there isnt a way to edit the title besides the db)

Thread moving is on my list; thread title editing isn't something I considered but I'll definitely add that too.
No ETA yet as I've only just finished tweaking thread view counting and would like to introduce more events in the near future.

i made my own version of the view counter for threads. Now it has throttling so views doing immediately go up as so as you refresh, its all based on sessions.

That's pretty much exactly what I did. Take a look at the 2.4.0 commit: https://github.com/Riari/laravel-forum/commit/88b02e749c164140edc2f0f8dc680cced52c0c49

coolio, however i needed to adapt this to other models so i cant use that one >_>

Fair enough. In the future, once there are events covering all of the main actions/routes, I'll probably move more of this functionality into a default set of event handlers that can then be individually overridden or disabled.

By the way, I don't think throttling means what you think it means - because it certainly wouldn't make "views immediately go up as you refresh" :P
Anyway, I've added your feature requests to the wiki and may update here when I make progress.

here's a snapshot of what im currently doing with the forum package :3 - http://i.imgur.com/whtRf14.png

Nice work. It's great to see how it's being used :)

Ill get more screenshots in once i figure out how to connect the post author to user roles >_>

If you do want to share more screenshots, could you submit them in a separate issue? I might expand the wiki to feature screenshots demonstrating how it can look with some customisation.
About the post author and user roles, I'm not sure exactly what you're trying to do but user roles should be accessible directly from your user model, e.g. $thread->author->roles.

I'm using Laravel Boilerplate located:
https://github.com/rappasoft/laravel-5-boilerplate
so its a bit different. If you can check it out you will see what i mean. (The models are in the app folder)

did u take a look cause im a bit confused on it >_>

I did. There's nothing unusual about the models being in the app directory - that's standard for Laravel 5 as they were moved out of the models directory due to the old structure supposedly being too suggestive of a strict MVC architecture.
In my L5 projects I actually move the models back into app/Models
Apart from that, I don't see anything particularly unusual about that project. If you're stuck on trying to integrate a specific thing with the forum, feel free to open an issue for it.
I'll close this one for now since we're off-topic.


Option to disable keep-alive feature

Is it currently possible to disable the keep-alive feature (added in #93)? If so I weren't able to find it.
I'm communicating with an embedded device which doesn't have any keep-alive functionality implemented so gets confused with those message, especially when they're coming in between regular messages.
If not possible I'd very much like some configuration to be able to disable this feature, would that be possible? Also, where does this feature come from? I couldn't find anything of it in the RFC 7252.

Yes there is such option: WithKeepAlive(nil) https://pkg.go.dev/github.com/go-ocf/go-coap/v2@v2.0.2/udp?tab=doc#WithKeepAlive
It is mentioned here: https://tools.ietf.org/html/rfc7252#section-1.2 end of part Reset Message

Thanks for pointing that out, missed that small section of the RFC.
I'm using DTLS, where that option is not available if I'm not mistaken (https://github.com/go-ocf/go-coap/blob/v2.0.2/server.go#L55). The notes you've referred to are specifically for UDP, and I couldn't find a way that I can pass options to the underlying UDP socket of DTLS.
For reference, I'm using go-coap as follows, where it is imported as coap "github.com/go-ocf/go-coap/v2".
	err = coap.ListenAndServeDTLS(
		"udp4",
		fmt.Sprintf(":%v", config.Server.ListenPort),
		&dtlsConfig,
		mux.HandlerFunc(DefaultHandler),
	)

So If you want to use options you need to create own ListenAndServe:
func ListenAndServe(config Config) error {
        l, err := net.NewDTLSListener("udp4", fmt.Sprintf(":%v", config.Server.ListenPort), &dtlsConfig)
	if err != nil {
		return err
	}
	defer l.Close()
	s := dtls.NewServer(dtls.WithMux(mux.HandlerFunc(DefaultHandler)), dtls.WithKeepAlive(nil))
	return s.Serve(l)
}

Good to know that I just have to create my own function for that, it worked as expected. Thanks for showing the example!


Reusable text pane allows to create text without any data

Require the user to enter at least the name and contents

Added validation


Showing similar code-actions for graphql not found

Description:
$title

Code Snippet used:
service graphql:Service / on new graphql:Listener(9000) {

    resource function get litrailft(string id) returns string|(){
        return "Value";
    }
}

Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Here, there are duplicated diagnostics as well. That's the reason for duplicating the same code action.

Related Issue #29566

Fixed with https://github.com/ballerina-platform/ballerina-lang/pull/30295. Tested on beta-1


add except block for HTTPException.

This fixes 'http.client.BadStatusLine' for me.
Error that prompted me to make this pull is below.
  File "<input>", line 1, in <module>
  File "P:\Program Files\JetBrains\PyCharm Community Edition 2018.2.4\helpers\pydev\_pydev_bundle\pydev_umd.py", line 197, in runfile
    pydev_imports.execfile(filename, global_vars, local_vars)  # execute the script
  File "P:\Program Files\JetBrains\PyCharm Community Edition 2018.2.4\helpers\pydev\_pydev_imps\_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "P:/GitHub/<REDACTED>/download_images.py", line 129, in <module>
    paths = response.download(args)
  File "C:\Users\henryfbp\.virtualenvs\<REDACTED>-M2TL8KnT\lib\site-packages\google_images_download\google_images_download.py", line 848, in download
    items,errorCount,abs_path = self._get_all_items(raw_html,main_directory,dir_name,limit,arguments)    #get all image items and download images
  File "C:\Users\henryfbp\.virtualenvs\<REDACTED>-M2TL8KnT\lib\site-packages\google_images_download\google_images_download.py", line 712, in _get_all_items
    download_status,download_message,return_image_name,absolute_path = self.download_image(object['image_link'],object['image_format'],main_directory,dir_name,count,arguments['print_urls'],arguments['socket_timeout'],arguments['prefix'],arguments['print_size'],arguments['no_numbering'])
  File "C:\Users\henryfbp\.virtualenvs\<REDACTED>-M2TL8KnT\lib\site-packages\google_images_download\google_images_download.py", line 568, in download_image
    response = urlopen(req, None, timeout)
  File "p:\lib\python3.6.4\Lib\urllib\request.py", line 223, in urlopen
    return opener.open(url, data, timeout)
  File "p:\lib\python3.6.4\Lib\urllib\request.py", line 526, in open
    response = self._open(req, data)
  File "p:\lib\python3.6.4\Lib\urllib\request.py", line 544, in _open
    '_open', req)
  File "p:\lib\python3.6.4\Lib\urllib\request.py", line 504, in _call_chain
    result = func(*args)
  File "p:\lib\python3.6.4\Lib\urllib\request.py", line 1361, in https_open
    context=self._context, check_hostname=self._check_hostname)
  File "p:\lib\python3.6.4\Lib\urllib\request.py", line 1321, in do_open
    r = h.getresponse()
  File "p:\lib\python3.6.4\Lib\http\client.py", line 1331, in getresponse
    response.begin()
  File "p:\lib\python3.6.4\Lib\http\client.py", line 297, in begin
    version, status, reason = self._read_status()
  File "p:\lib\python3.6.4\Lib\http\client.py", line 285, in _read_status
    raise BadStatusLine(line)
http.client.BadStatusLine: HTTP/1.1   0 Init

Thanks for the PR. Appreciate it. However this is a duplicate of #114 that was recently merged. 114 also had some other changes that were required.
Closing this PR.


Restore

An accident, please ignore! Will close soon.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/fd8badb481307a94233f93cdd5161dd1863e75cc/
Edited pages:

v20.2/install-cockroachdb-spatial.md


Implement Email Verification during User Registration

As part of our user registration process, we need to implement an email verification step to ensure that users provide a valid email address and that they have access to it.
Tasks:

Generate a unique token for each new user during registration.
Temporarily store the user's data and the token in a cache or a temporary collection in the database.
Send an email to the user with a verification link. The link should include the token as a query parameter.
When the user clicks the verification link, validate the token, move the user's data from the temporary storage to the actual user collection, and mark the user's email as verified.
If the user does not click the verification link within 15 minutes, the token should expire and the user's data should be removed from the temporary storage.

Acceptance Criteria:
A user should not be able to complete registration without verifying their email.
A user should receive a clear message if their verification link is invalid or expired.
The system should handle the scenario where the email sending fails.
Estimated Time:

2 days

Dependencies:

Nodemailer for sending emails, Mongo for temporary storage(Implement logic like in Redis) and using uuid for unique number stored in TempMemory in Mongo

They may be a room for improvements in emailServices.js. For now I will leave it as it is, in the future can be made a better html for the client and enhancement for error handling

Tomorrow will make:

Validations if the user try to make another request for verification before the time expires.
Verify end point - save user information and redirect him to user settings where he can add other data

Things to do tomorrow

Middleware to check if the ip has already been made the request for verification before his 15 minutes are up(security)
Feature for suggesting a name, it will not suggest names in the tempData, it is possible bug
Finally, web socket when the user verified himself to redirect him to the window which is waiting for validation and return verified


Add the [params] concept to front matter

Note that this is

Mostly about documentation.
We will never (or if we do, we should get some way of converting old) break the "old way" of doing it.

We had a similar situation in language.params, where we allowed custom params at the top level. Now we warn about that and we will eventually remove that option.
So, from a documentation standpoint (API spec) this is problematic because it's hard to define which fields that makes up the API when "field A, B, C are Hugo configuration, all the rest are params".
So this proposal suggest that we from a documentation standpoint encourages front matter on the form:
title: Hello World
date: 2020-01-01
params:
  color: blue

And just to make this clear, this would also continue to work:
title: Hello World
date: 2020-01-01
color: blue

The "world" is a little more complicated than the above, but let us keep it simple for now.
/cc @jmooring

Makes sense to me.
I have seen things like this in the wild
{{ .Page.Params.date }}
{{ .Page.Params.draft }}
{{ .Page.Params.iscjklanguage }}
{{ .Page.Params.lastmod }}
{{ .Page.Params.linktitle }}
{{ .Page.Params.publishdate }}
{{ .Page.Params.title }}
{{ .Page.Params.type }}

So, to be backwards compatible, predefined fields (in the root of front matter) need to be available under .Page.Params, but obviously not documented.
Taxonomy terms
Which would be the correct way?
title = 'How to change a lightbulb'
date = 2023-06-01T09:53:36-07:00
tags = ['tag a','tag b']

or
title = 'How to change a lightbulb'
date = 2023-06-01T09:53:36-07:00
[params]
  tags = ['tag a','tag b']

or
title = 'How to change a lightbulb'
date = 2023-06-01T09:53:36-07:00
[taxonomies]
  tags = ['tag a','tag b']

Another thing to watch out for. If you define the summary in front matter, and then use the .Summary method in a template, it returns the rendered summary, not the raw field value.
To get the raw field value, you currently have to use .Params.Summary or .Params.summary. A .RawSummary method on page would resolve this, but we need to be aware of breaking existing sites.

I'm marking this as closed for now, I'll create another issue(s) for following up work.


DRAFT for fixing symbol table

See new test cases, ignore everything else.

Allow sharing config and chaining. A common config may hold all the connectors, and then a smaller config may chain to it and add a function.
Allow mutating config to enable "sessions"
Allow passing in config per-expression (Rather than just engine wide)
Allow passing in runtime state per expression to functions (useful for User(), Rand(), Now()/TimeZoneInfo(), etc)

This also will fix #276

Feedback From Bryan:

ImmutableSymbolTable
Find a way to gaurantee that SymbolTable nad RuntimeConfig have the same structure....

Pull Request Test Coverage Report for Build 317291

0 of 0   changed or added relevant lines in 0 files are covered.
333 unchanged lines in 15 files lost coverage.
Overall coverage increased (+0.3%) to 64.07%

Files with Coverage Reduction
New Missed Lines
%

/src/libraries/Microsoft.PowerFx.Core/Texl/Intellisense/IntellisenseHelper.cs
2
76.04%

/src/libraries/Microsoft.PowerFx.Core/Glue/SimpleResolver.cs
3
0%

/src/libraries/Microsoft.PowerFx.Core/Public/DependencyFinder.cs
3
85.71%

/src/libraries/Microsoft.PowerFx.Connectors/OpenApiParser.cs
4
90.91%

/src/libraries/Microsoft.PowerFx.Core/Public/Engine.cs
4
96.83%

/src/libraries/Microsoft.PowerFx.Core/Public/IExpression.cs
6
0%

/src/libraries/Microsoft.PowerFx.Interpreter/RecalcEngine.cs
6
96.63%

/src/libraries/Microsoft.PowerFx.Core/Public/Types/TableType.cs
7
82.5%

/src/libraries/Microsoft.PowerFx.Core/Public/Config/PowerFxConfig.cs
8
86.67%

/src/libraries/Microsoft.PowerFx.Interpreter/ReflectionFunction.cs
10
85.33%

Totals

Change from base Build 316809:
0.3%

Covered Lines:
24628

Relevant Lines:
38439

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.PowerFx.Connectors.dll
:x: 2 Binary Compatibility issues for Microsoft.PowerFx.Core compared against version 0.2.2-preview.20220816-317288.

MembersMustExist : Member 'Microsoft.PowerFx.PowerFxConfig.FunctionInfos.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'Microsoft.PowerFx.PowerFxConfig.GetAllFunctionNames()' does not exist in the implementation but it does exist in the contract.

:x: 1 Binary Compatibility issues for **Microsoft.PowerFx.Interpreter** compared against [version 0.2.2-preview.20220816-317288](https://www.nuget.org/packages/Microsoft.PowerFx.Interpreter/0.2.2-preview.20220816-317288).

MembersMustExist : Member 'Microsoft.PowerFx.ReflectionFunction.Invoke(Microsoft.PowerFx.Types.FormulaValue[])' does not exist in the implementation but it does exist in the contract.

:heavy_check_mark: No Binary Compatibility issues for **Microsoft.PowerFx.LanguageServerProtocol.dll**
:heavy_check_mark: No Binary Compatibility issues for **Microsoft.PowerFx.Transport.Attributes.dll**

:heavy_check_mark: No Binary Compatibility issues for Microsoft.PowerFx.Connectors.dll
:x: 2 Binary Compatibility issues for Microsoft.PowerFx.Core compared against version 0.2.2-preview.20220816-317288.

MembersMustExist : Member 'Microsoft.PowerFx.PowerFxConfig.FunctionInfos.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'Microsoft.PowerFx.PowerFxConfig.GetAllFunctionNames()' does not exist in the implementation but it does exist in the contract.

:x: 1 Binary Compatibility issues for **Microsoft.PowerFx.Interpreter** compared against [version 0.2.2-preview.20220816-317288](https://www.nuget.org/packages/Microsoft.PowerFx.Interpreter/0.2.2-preview.20220816-317288).

MembersMustExist : Member 'Microsoft.PowerFx.ReflectionFunction.Invoke(Microsoft.PowerFx.Types.FormulaValue[])' does not exist in the implementation but it does exist in the contract.

:heavy_check_mark: No Binary Compatibility issues for **Microsoft.PowerFx.LanguageServerProtocol.dll**
:heavy_check_mark: No Binary Compatibility issues for **Microsoft.PowerFx.Transport.Attributes.dll**

        var str = name.Value;

seems like this is only handling recalc engine variables now, comment out of date?

Refers to: src/libraries/Microsoft.PowerFx.Interpreter/RecalcEngineResolver.cs:74 in 352ac7e. [](commit_id = 352ac7ecc86b038b569665bfcb4f97cb66f8a45b, deletion_comment = False)

:heavy_check_mark: No Binary Compatibility issues for Microsoft.PowerFx.Connectors.dll
:x: 2 Binary Compatibility issues for Microsoft.PowerFx.Core compared against version 0.2.2-preview.20220817-317421.

MembersMustExist : Member 'Microsoft.PowerFx.PowerFxConfig.FunctionInfos.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'Microsoft.PowerFx.PowerFxConfig.GetAllFunctionNames()' does not exist in the implementation but it does exist in the contract.

:x: 1 Binary Compatibility issues for **Microsoft.PowerFx.Interpreter** compared against [version 0.2.2-preview.20220817-317421](https://www.nuget.org/packages/Microsoft.PowerFx.Interpreter/0.2.2-preview.20220817-317421).

MembersMustExist : Member 'Microsoft.PowerFx.ReflectionFunction.Invoke(Microsoft.PowerFx.Types.FormulaValue[])' does not exist in the implementation but it does exist in the contract.

:heavy_check_mark: No Binary Compatibility issues for **Microsoft.PowerFx.LanguageServerProtocol.dll**
:heavy_check_mark: No Binary Compatibility issues for **Microsoft.PowerFx.Transport.Attributes.dll**

:heavy_check_mark: No Binary Compatibility issues for Microsoft.PowerFx.Connectors.dll
:x: 2 Binary Compatibility issues for Microsoft.PowerFx.Core compared against version 0.2.2-preview.20220817-317421.

MembersMustExist : Member 'Microsoft.PowerFx.PowerFxConfig.FunctionInfos.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'Microsoft.PowerFx.PowerFxConfig.GetAllFunctionNames()' does not exist in the implementation but it does exist in the contract.

:x: 1 Binary Compatibility issues for **Microsoft.PowerFx.Interpreter** compared against [version 0.2.2-preview.20220817-317421](https://www.nuget.org/packages/Microsoft.PowerFx.Interpreter/0.2.2-preview.20220817-317421).

MembersMustExist : Member 'Microsoft.PowerFx.ReflectionFunction.Invoke(Microsoft.PowerFx.Types.FormulaValue[])' does not exist in the implementation but it does exist in the contract.

:heavy_check_mark: No Binary Compatibility issues for **Microsoft.PowerFx.LanguageServerProtocol.dll**
:heavy_check_mark: No Binary Compatibility issues for **Microsoft.PowerFx.Transport.Attributes.dll**

:heavy_check_mark: No Binary Compatibility issues for Microsoft.PowerFx.Connectors.dll
:x: 2 Binary Compatibility issues for Microsoft.PowerFx.Core compared against version 0.2.2-preview.20220818-317567.

MembersMustExist : Member 'Microsoft.PowerFx.PowerFxConfig.FunctionInfos.get()' does not exist in the implementation but it does exist in the contract.
MembersMustExist : Member 'Microsoft.PowerFx.PowerFxConfig.GetAllFunctionNames()' does not exist in the implementation but it does exist in the contract.

:x: 1 Binary Compatibility issues for **Microsoft.PowerFx.Interpreter** compared against [version 0.2.2-preview.20220818-317567](https://www.nuget.org/packages/Microsoft.PowerFx.Interpreter/0.2.2-preview.20220818-317567).

MembersMustExist : Member 'Microsoft.PowerFx.ReflectionFunction.Invoke(Microsoft.PowerFx.Types.FormulaValue[])' does not exist in the implementation but it does exist in the contract.

:heavy_check_mark: No Binary Compatibility issues for **Microsoft.PowerFx.LanguageServerProtocol.dll**
:heavy_check_mark: No Binary Compatibility issues for **Microsoft.PowerFx.Transport.Attributes.dll**


iphone x ios 15.2

Repos not work its the same as not "TWEAK BRANCH"

Please read the instructions thoroughly.


Recursive deferred resolvers.

Added test cases for deferred resolving and adapted the processor to properly evaluate nested resolvers level by level.

Lovely. There are, however, a few unrelated indentation changes. Makes it a bit harder to review (the second half of the PR can be skipped). Mind reverting those?

Oh sorry, I didn't see the closure opening.

@portey thanks for the review! I used it for good, and the implementation is more elegant now. There a no more "scan" steps. Instead the processor adds deferred resolvers to the queue whenever it stumbles upon them.
I also added a streamlined DeferredResolverInterface (and DeferredResult has been  re-purposed in the process).

@pmelab @portey Well done guys!

Are you going to merge and publish the contents of the "deferred" branch any time soon?

Good job guys!
You just need to add some documentation ;p

Is DeferredResolver some kind of cache resolver? Not the defer feature of GraphQL mentioned in this post https://dev-blog.apollodata.com/new-features-in-graphql-batch-defer-stream-live-and-subscribe-7585d0c28b07.
Am I right?

Deferred resolvers are collected in the result tree to be evaluated at once (if the query requests different 5 database objects, they can be loaded with a single query). So they don't directly relate to the deferred feature.
But they are similar and I wonder if deferred resolvers are already a suitable backend solution for a @defer directive.

@pmelab thanks for the clarification. I can see how DeferredResover  can improve the performance.
Any plan to release a simple documentation on how to use it properly?

@dilab yep... hopefuly on the weekend

@viniychuk awesome! cant wait

@viniychuk understood you are super busy. If you could provide me some simple samples, i will be happy to write tutorials for this section.

any news ?

@pmelab will you add some documentation on how to use your PR?

You can always have a look at the tests included. Besides testing they are some kind of documentation as well, right? :)
Relevant files are DeferredTest and DeferredResolver.
The implementation is rather simple. In your resolve function, instead of returning the value right away, return a new instance of DeferredResolver. The only argument for the DeferredResolver is the callable you want to be called later on.
The test file above actually exactly shows a demo on how to defer (call) & bulk query the database.


'az ssh vm' and 'az ssh config' do not work with VMSS

This is autogenerated. Please review and update as needed.
Describe the bug
NOTE: Everything below also applies when running az ssh config command
When running az ssh vm --ip <private_ip>, AzureCLI returns the following error message:
--resource-group and --vm-name/--name must be provided together

If I add either of those parameters while leaving --ip present, I get the following error message:
--ip cannot be used with --resource-group or --vm-name/--name

If I remove the --ip from the command and keep --resource-group <rgName> --name <vmssName> , I basically receive a 404 from AzureCLI:
A valid resource <vmssName> in the resource group <rgName> was not found.
Please ensure the active subscription is set properly and resource exists.

Since I'm trying to connect to an instance of an Ubuntu VMSS, the documentation clearly states I only need to provide the private IP, from a location that has access to it. I made sure the resource group name was accurate (copy-pasted from Azure Portal), same with the VMSS name. Tried using the instance name (<vmssName>_0), to no avail. Also tried adding --prefer-private-ip and still nothing.
Since we have multiple subscriptions, I made sure I was targeting the correct one using --subscription "<subscriptionName>"
Command Name
az ssh vm Extension Name: ssh. Version: 1.1.3.
az ssh config Extension Name: ssh. Version: 1.1.3.
To Reproduce:

Create an Ubuntu-based VMSS in Azure, making sure to enable AzureAD SSH Login feature/extension
Try and login using az ssh vm --subscription <subscriptionName> --ip <privateIP>, <privateIP> being the private IP of one of the VMSS instances.
Get the same error messages

Expected Behavior
As per the documentation, the command should proceed with authenticating me with Azure, and then connecting me to the Ubuntu instance via SSH.
Environment Summary
Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.31, Ubuntu 20.04.4 LTS
Python 3.10.8
Installer: DEB

azure-cli 2.45.0

Extensions:
azure-devops 0.26.0
ssh 1.1.3

Dependencies:
msal 1.20.0
azure-mgmt-resource 21.1.0b1

Additional Context

I am having the same problem. This is still not fixed

I was getting very frustrated with this same issue. I ran it with --verbose and saw 'Configured default 'rg-production' for arg resource_group_name'. In my ~.azure\config file in defaults there was group=rg-production. After removing this the --ip option worked


Don't run integration tests on docs-only PRs

Per discussion with @seankimkdy, this is already true but filters on /docs. It would be nice to filter on file type so that changes to things like the CONTRIBUTING file do not trigger builds.

Yea this is an issue where we need to identify which files are important for which action. But it can also become very brittle as we add new files and forget to update workflows accordingly.
In the meantime, is there a reason we need CONTRIBUTING.md or CODE-OF-CONDUCT.md? I'm wondering why those can't just directly live in our docs.

I think contributing and code of conduct files are on root by convention. People and even tooling might expect to see them there, but in some cases they can be just stubs with links to the actual content under the documentation, especially contributing.

Triage: @seankimkdy, we moved this to backlog. If you disagree, please move it to vnext.


Moving cursor up after tab selection

Say you do CTRL-T and get this:
  some.other.garbage.foo
  foo.bar.baz.qux
  foo.bar.baz
  foo.bar
> foo
> fo

Now to select foo.bar, foo.bar.baz, foo.bar.baz.qux you would need 3 ups to go up to foo.bar.baz.qux, 3 tabs to select all three, then enter. Or if you're a bit indecisive about which files to choose at the beginning: up, tab, up, up, tab, up, up, tab, enter.
Wouldn't it make more sense if it's just: up, tab, tab, tab, enter?
Basically, since the cursor starts at the bottom of the list, it's just more natural for it to go up as a default direction.

Ah, I just noticed ctrl-tab does this. But I think this should be default, and ctrl-tab the other way around.

Yeah, when I first implemented multi-selection two years ago when fzf was still in Ruby, I thought it would be more conventional that tab brings your cursor down, and ever since then, I've kept it that way not to break backward-compatibility. And it's true that I'm almost always using shift-tab, unless --reverse is set. Maybe it's finally time for a change? Making tab move cursor away from the prompt, shift-tab the opposite. Is it better? Can it be confusing when we use --reverse? I wonder what others think.
Until I decide to change the default and release the next version, you can change the default with --bind option in $FZF_DEFAULT_OPTS.

Yeah, I think more opinions would be nice.
I also think that ctrl-tabs should cancel out consecutive tabs. My hypothesis is that this would be a more useful purpose.
E.g., if we have this:
  some.other.garbage.foo
  foo.bar.baz.qux
  foo.bar.baz
  foo.bar
> foo
> fo

After tab, tab, tab, ctrl-tab, ctrl-tab, ctrl-tab it would become:
  some.other.garbage.foo
 >foo.bar.baz.qux
  foo.bar.baz
  foo.bar
>>foo
> fo

Again, more opinions would be nice.

I'm going to add toggle-in and toggle-out actions in the next release. See the above commit for the details.
Your suggestion on cancelling out consecutive tabs is interesting and will be useful in that particular case. But I feel that it's going to be confusing in some other cases, so I'd like to just keep it simple.

Closing due to the lack of community interest.

I bound this manually, as I found myself always hitting <tab><ctrl-p><ctrl-p> (because <shift-tab> doesn't seem to work in neovim for some reason).  I'm not sure if it should be default, but I am really glad you have the extensible binding system to facilitate such changes in user-land.


Links missing

Why aren't there links to the typedefs for the members of the structure? Why do we have to perform multiple searches to get the definition?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9efb8f3a-c66f-994c-eedc-67e603559d18
Version Independent ID: cee7f715-77f6-72bf-598f-10573135dac5
Content: _FAST_IO_DISPATCH - Windows driver
Content Source: wdk-ddi-src/content/wdm/ns-wdm-_fast_io_dispatch.md
Product: windows-hardware
GitHub Login: @windows-driver-content
Microsoft Alias: windowsdriverdev

Great question @BrianCatlin, sorry for the delay getting back to you.  Those callbacks are indeed in wdm.h, but we do not currently have doc pages for them.  I've opened an internal task to track that.  In the meantime, I found this article from 1996 that describes them all!
https://www.osronline.com/article.cfm^id=166.htm
Closing out this issue for now since we're tracking this separately.


ARROW-1638: [Java] IPC roundtrip for null type

Related to ARROW-1638.

Sorry, In my opinion.
On Thu, Aug 22, 2019 at 11:06 PM tianchen92<EMAIL_ADDRESS>wrote:

@tianchen92 commented on this pull request.
In java/vector/src/main/java/org/apache/arrow/vector/NullVector.java
https://github.com/apache/arrow/pull/5164#discussion_r316984983:

return true;

}

@Override
public int hashCode(int index) {
return 0;
}

@Override
public <OUT, IN> OUT accept(VectorVisitor<OUT, IN> visitor, IN value) {
return visitor.visit(this, value);
}

@Override
public void copyFrom(int fromIndex, int thisIndex, ValueVector from) {
throw new UnsupportedOperationException();

IMO, what does this mean?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/arrow/pull/5164?email_source=notifications&email_token=AEIKYDTUEFSKVISAPXJCDPDQF5475A5CNFSM4IOUMBG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCPEYTQ#discussion_r316984983,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEIKYDR7XJMVNHEZ4F7D4CLQF5475ANCNFSM4IOUMBGQ
.

Sorry, In my opinion.

Something is wrong?

Nothing wrong, I was apologizing for using the abbreviation.
On Thu, Aug 22, 2019 at 11:29 PM tianchen92<EMAIL_ADDRESS>wrote:

Sorry, In my opinion.
Something is wrong?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/arrow/pull/5164?email_source=notifications&email_token=AEIKYDVQVE5RYZJUN3CW3ILQF57WHA5CNFSM4IOUMBG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD47IEEY#issuecomment-524190227,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEIKYDRSOGNUQDTBAPN7WZTQF57WHANCNFSM4IOUMBGQ
.

Nothing wrong, I was apologizing for using the abbreviation.

Sorry for misleading, I just want to ask what do your mean by "should these be defined for other null vectors?" above, forgive me for poor English :)

PR updated, I am not quite familiar with this part, please let me know if you have other comments, thanks

Codecov Report

Merging #5164 into master will increase coverage by 2.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5164      +/-   ##
==========================================
+ Coverage   87.63%   89.75%   +2.12%
==========================================
  Files        1022      682     -340
  Lines      146258   101876   -44382
  Branches     1437        0    -1437
==========================================
- Hits       128177    91442   -36735
+ Misses      17719    10434    -7285
+ Partials      362        0     -362

Impacted Files
Coverage Δ

cpp/src/arrow/python/python_test.cc
100% <0%> (ø)
:arrow_up:

python/pyarrow/tests/test_schema.py
100% <0%> (ø)
:arrow_up:

r/src/recordbatch.cpp

r/R/Table.R

js/src/util/fn.ts

r/src/symbols.cpp

rust/datafusion/src/execution/projection.rs

rust/datafusion/src/execution/filter.rs

rust/arrow/src/csv/writer.rs

rust/datafusion/src/bin/main.rs

... and 342 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f413c8f...edaeef1. Read the comment docs.

@tianchen92 the real test for this would be adding it to the python integration test (integration/integration_test.py)  if you don't feel comfortable doing so i can make the change and push to your branch in the next few days.

@tianchen92 the real test for this would be adding it to the python integration test (integration/integration_test.py) if you don't feel comfortable doing so i can make the change and push to your branch in the next few days.

Really appreciate for your help, I have invited you as collaborator(https://github.com/tianchen92/arrow/invitations), thanks!

Right. There should simply be a clear and unambiguous specification.

@emkornfield I guess you probably forgot to add python integration test?

@emkornfield I guess you probably forgot to add python integration test?
Still on my todo list.

It appears this needs to be rebased?

It appears this needs to be rebased?

Sure, rebased.

Now that I've just merged ARROW-6379 you may want to update this to correspond to that

I should be able to get to an integration test next week.

What is the status of this patch? Needs to be rebased.

I just rebased, if @emkornfield has no time recently, could we merge this first since this pending a long time and seems there's already a JIRA for integration test(ARROW-1636)

Yes, we can handle integration tests separately.  I'll do another quick pass today and then merge.

+1 thank you.