Unable to use custom repository with NestJS and Mikro ORM 5.0.1

Describe the bug
I'm trying to update my own application from 4.5 to 5.0.1, but I'm running into some issues with the identity map, and disableIdentityMap seems to not work for some cases.
I tried to set up reproducible repo for it, but I'm now running into a different issue that I cannot understand.
I tried setting up a custom repository with Nest JS, but It seems it doesn't have a context.
I tried using the EntityRepository with InjectRepository, and that seems to work.
Stack trace
mikroorm-migration-issue-api-1       | TypeError: Cannot read properties of undefined (reading 'getContext')
mikroorm-migration-issue-api-1       |     at CustomerRepository.get em [as em] (/src/node_modules/@mikro-orm/knex/SqlEntityRepository.js:30:25)
mikroorm-migration-issue-api-1       |     at CustomerRepository.findAll (/src/node_modules/@mikro-orm/core/entity/EntityRepository.js:63:21)
mikroorm-migration-issue-api-1       |     at AppController.getCustom (/src/src/app.controller.ts:22:28)
mikroorm-migration-issue-api-1       |     at /src/node_modules/@nestjs/core/router/router-execution-context.js:38:29
mikroorm-migration-issue-api-1       |     at InterceptorsConsumer.intercept (/src/node_modules/@nestjs/core/interceptors/interceptors-consumer.js:11:20)
mikroorm-migration-issue-api-1       |     at /src/node_modules/@nestjs/core/router/router-execution-context.js:46:60
mikroorm-migration-issue-api-1       |     at /src/node_modules/@nestjs/core/router/router-proxy.js:9:23
mikroorm-migration-issue-api-1       |     at Layer.handle [as handle_request] (/src/node_modules/express/lib/router/layer.js:95:5)
mikroorm-migration-issue-api-1       |     at next (/src/node_modules/express/lib/router/route.js:137:13)
mikroorm-migration-issue-api-1       |     at Route.dispatch (/src/node_modules/express/lib/router/route.js:112:3)

To Reproduce
Steps to reproduce the behavior:

Clone https://github.com/kristijanhusak/mikroorm-migration-issue
Start it with docker-compose up
open http://localhost:3000, see that InjectRepository work
Try to open http://localhost:3000/custom, see the error

Expected behavior
I expect to be able to use custom repository. I think I covered all the necessary things:

Extended EntityRepository from postgresql package
Added the repository to the Entity via customRepository option in Entity decorator
Registered repository as provider

Additional context
Add any other context about the problem here.
Versions

Dependency
Version

node
16.13.0

typescript
4.5.5

mikro-orm
5.0.1

your-driver
Postgres

Registered repository as provider

This is your problem. Doing this makes nest to create the repository instance via its constructor, but not providing the parameters.
It is the forFeature() call that registers repositories, don't put them to the providers array.

Hi sorry to re-post on this closed issue but this issue helped me a lot but there is a little thing that still bothers me .
@B4nan
Using GraphQLModule nestjs and dataloader i used to do this.
 GraphQLModule.forRootAsync<MercuriusExtendedDriverConfig>({
      driver: MercuriusGraphQLDriver,
      imports: [
      // BEGIN i tried this but this does not solve anything
        MikroOrmModule.forFeature([
          AddressEntity,
          MembershipEntity,
        ]),
        // END i tried ...
        AddressModule,
        MembershipModule,
      ],
      useFactory: (
        addressRepository: AddressRepository,
        membershipRepository: MembershipRepository,
      ) => ({
        // This is where fastify/mercurius plugins should be added
        // Exceptions for mercurius-upload and fastity-raw-body
        // https://github.com/nestjs/graphql/pull/2538
        plugins: [
          {
            plugin: import('./mercurius-logger.fastify-plugin'),
            options: {
              prependAlias: true, // default: false
              logBody: true, // default: false
              logVariables: true, // default: false
            },
          },
        ],
        playground: true,
        introspection: true,
        autoSchemaFile: true,
        sortSchema: true,
        context: ({ req }) => ({
          req,
          addressLoader: oneToOneDataLoader<AddressEntity>(addressRepository),
          membershipLoader:
            manyToOneDataLoader<MembershipEntity>(membershipRepository),

It seems the repository is undefined
My membershipRepository is used at another places in the app so it works
export class MembershipRepository extends EntityRepository<MembershipEntity> {

@Entity({
  tableName: 'membership',
  customRepository: () => MembershipRepository,
})
export class MembershipEntity extends BaseEntity<Membership> {
  [EntityRepositoryType]?: MembershipRepository;

Is there any way ?
Or should i add injectable service that flat passes the repository methods needed in the dataloaders ?


Include proof and notary_pob_key into response of VerityClient

Merged in https://github.com/usherlabs/ccamp/commit/d437be7b9aa4aa5f9f5a032e2381f091ee32e301


Azure Workflow Automation - Block BruteForce - NSG rule name and Priority are static which blocks the creation of new nsg rule for the same vm

Describe the bug
Since the value of NSG rule name and Priority are hardcoded , It wont be possible to create a new rule to block a new IP address on the same machines

Adding @safeenab786 as the owner of this automation.

Adding @safeenab786 as the owner of this automation.

Hey @darkweb-123
Thanks for raising this issue. We're currently working on an updated version of this automation which we're planning to release during February 2021.

Hey @darkweb-123
Thanks for raising this issue. We're currently working on an updated version of this automation which we're planning to release during February 2021.

We've updated the BlockBruteForceAttack automation to V2 with the following improvements:

The Logic App will take all IP Addresses from the alert and add them to the Deny Rule in the VM's NSG.
The rule name is unique to make sure it does not overwrite an existing BlockBruteForce rule.
The rule priority is dynamically assigned. The Logic App will use the lowest free priority number to create the rule.

Please find the newest release at https://github.com/Azure/Azure-Security-Center/tree/master/Workflow automation/BlockBruteforceAttack
Closing this issue since a solution was provided.

We've updated the BlockBruteForceAttack automation to V2 with the following improvements:

The Logic App will take all IP Addresses from the alert and add them to the Deny Rule in the VM's NSG.
The rule name is unique to make sure it does not overwrite an existing BlockBruteForce rule.
The rule priority is dynamically assigned. The Logic App will use the lowest free priority number to create the rule.

Please find the newest release at https://github.com/Azure/Azure-Security-Center/tree/master/Workflow automation/BlockBruteforceAttack
Closing this issue since a solution was provided.


Add Travis checks

Currently only doing psr2 and phpunit

This will need someone to enable travis on the build. https://docs.travis-ci.com/user/getting-started/
First few steps of that

Currently we are using jenkins for the CI-pipeline at http://jenkins.joind.in
So far we did not (yet) decide to move away from that.
Though there are some ideas to change the projects setup there is no decission to actually change all that. We should schedule a chat session on IRC to discuss that stuff.
But as long as there is no decission to move CI from jenkins to github I would not invest time into such a move.
B

Jenkins doesn't currently work (hence the reason for the psr2 pull request as it was already done)
Some talk about it here
https://github.com/joindin/joindin-api/pull/447#issuecomment-396944443
Personally I would prefer travis as it shows correctly on the commits

Personally I'm also :+1: on that. I would just prefer a team decission on the future strategy and vision of the whole project so that we can then actually move on strongly in one direction.

Happy be in involved in a chat. When's best to set one up ?

Moving away from Jenkins is part of a larger conversation around the infrastructure behind joindin. There are things being done in Jenkins that need to be looked into to see if they can be easily replicated in Travis or another service like CircleCI.
This is something that I'm personally going to be looking into over the coming weeks and once I have a solid grasp on what currently happens vs what needs to be done then I'd like to get a conversation going around this.
@exussum12 Thank's for submitting the PR.  I'm going to close it for now, but we may well end up using it in future, however, for now, I'd rather stick with Jenkins until we figure out the bigger picture

Nothing is done currently in Jenkins though due to it being broke for almost a year ?
What is here currently set up travis and then runs a shell script, that can be done easily for any provider we use. To me having something working is better than not having anything even if its just temporary ?

Per IRC discussion, re-opening this. Would love to see the same for Web2


Simple approach to connecting failing transactions properly

Current dependencies on/for this PR:

feature/proof-of-stake

PR #979   👈

This stack of pull requests is managed by Graphite.


Add VCacheable instance for Float

This commit adds encoding and decoding functions for Floats to allow them to be stored in VCache.

I remember having trouble building. Could you attach a build log for verification?

Hi @Wizek, this project is using Cabal, right? When I tried to do a fresh clone and build today, I couldn't seem to get cabal configure to work. It's failing on lmdb >=0.2.5 -- which is installed. I suspect this might be standard Debian apt-repo problems.
When I ran a build on my laptop (Ubuntu), it got to stm >=2.4.3. What could be preventing that from building? Wouldn't Cabal download STM as it's a Haskell package? I am assuming STM is Software Transactional Memory. I have run cabal update.
$ cabal build
Package has never been configured. Configuring with default flags. If this
fails, please run configure manually.
Resolving dependencies...
Warning: solver failed to find a solution:
Could not resolve dependencies:
trying: vcache-0.2.7 (user goal)
next goal: easy-file (dependency of vcache-0.2.7)
Dependency tree exhaustively searched.
Trying configure anyway.
Configuring vcache-0.2.7...
cabal: Encountered missing dependencies:
direct-murmur-hash -any,
easy-file -any,
filelock -any,
lmdb >=0.2.5,
stm >=2.4.3


Mention the dedicated site generator in the README

Hello,
Thanks for this work!
After I followed the instructions in the README and started to customise the default site generator, a Google search revealed the NPM site generator to me.
This should be mentioned as one, if not the preferred way to test the project.
The setup of some of the least techy users could be messed up with the local customisation.

Hello François.
The site generator with Lunr included is basically a hard copy of the default site generator.
While it's easier to get started it also has a few drawbacks.
Having said that I can add a link to this project in the "Generate an index file":

To generate an index file, you can either use a custom site generator pipeline that includes Lunr or modify your current site generator pipeline.

Sounds good, thanks for the addition.
I'll push for more examples in the site generator section in the Antora docs.


Consider vendoring dependencies

Hello,
go get does just perfect when the recent version of influxdb is built.
But if somebody wants (for some reason) to build some specific old influxdb version from the sources, or somebody does git bisect, then influxdb code base may appear to be inconsistent with the dependencies (which are taken from master by go get). This may lead either to build failures or behaviour bugs.
[1] https://golang.org/s/go15vendor

This issue should receive high priority, as it is InfluxDB builds are not reproducible, and it might lead to strange behaviour of tagged releases.
Today my team was debugging an issue with clustering on 0.10. We figured we would check InfluxDB out from git, using the 0.10 branch, add some log statements and compile and run that in our test environment.
What we found was that the '0.10' we built had a new bug that totally prevents clustering from working at all. Anytime we add a second node to the cluster it says: "leadership lost while committing log", an error that comes from raft. Surprised at the difference in behaviour between our 0.10 and the 0.10 that is in Debian we looked at the dependencies and see that they are not constrained at all.
That means that any build of InfluxDB on a new machine just builds master of hashicorp/raft, which does not seem to have any structured release scheme at all. The hashicorp/consul project seems to acknowledge this as they have a build system that forces their builds to run on a specific commit of raft.


[Slider] Fix typo "fried" to "fired"

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@Ehesp Thanks.


go get github.com/cweill/gotests/...: malformed module path "github.com/cweill/gotests/...": double dot

env
go version go1.12.14 windows/amd64
set GOARCH=amd64
set GOBIN=
set GOCACHE=xxxx
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=E:\work\goworkspace
set GOPROXY=https://goproxy.io
set GORACE=
set GOROOT=c:\go
set GOTMPDIR=
set GOTOOLDIR=c:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=NUL
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\DUYONG~1\AppData\Local\Temp\go-build265818502=/tmp/go-build -gno-record-gcc-switches
go get failed
go get github.com/cweill/gotests/...: malformed module path "github.com/cweill/gotests/...": double dot

This appears to be a known issue in Go 1.12: https://github.com/golang/go/issues/29363
and it is fixed for Go 1.13.
For Go 1.12, the work around to install the CLI is
go get -u github.com/cweill/gotests/gotests

thinks ,go 1.13 fixed this problem


(PUP-5445) Add Arista support

:+1:

Does this require a beaker change? If I try to run it, I get `#<RuntimeError: No repository installation step for eos yet...>.

@MikaelSmith Yes, This requires what will be Beaker 2.28.0

@LuvCurves once 2.28 is released, can you extend this PR to bump the minimum beaker requirement at https://github.com/puppetlabs/puppet/blob/master/acceptance/Gemfile#L15?

@kylog Will do.

Beaker 2.28.0 is available.

:+1:

Waiting on CI to be green again.

If this is required for 4.3.0, please retarget for stable

Closing and retargeting to stable


bug: Code is formatted incorrectly after code completion

Installation Information
Standard installation, all versions
Describe the bug

https://twitter.com/danaketh/status/1765117259234603500
Expected behavior
Could should always be formatted correctly
Additional context
IntelliJ formatting have separate action which we could just call after the completion is done.
We try to make sure we insert completion at the right position regarding surrounding text, but I guess it might not be 100% robust. Also it won't help for adjusting e.g. whole completion block to the project coding standard, and using IJ formatter would help there.

Similar report here https://github.com/sourcegraph/sourcegraph/issues/60590
(And thank you for beating me to creating this issue, @pkukielka !)


core: allow simplified config startup

I had left this in a kinda ugly state where, to start the client with custom configs you needed to do something like,
const config = new Config('http://<IP_ADDRESS>:80')
this.client = new Client(config)

this just cleans that up so you can do,
this.client = new Client({host: 'http://<IP_ADDRESS>:80'})

hmm.. actually, i''ll need some of your expertise here carson. this will break the work i did over on Textile (which works on the current master here).
working master
    this.api = new API({
      token: '',
      deviceId: '',
      dev: true
    })
    this.client = new Client(this.api.threadsConfig)

With this update, I now get an error that Argument of type 'Config' is not assignable to parameter of type 'Config | BaseConfig'. Type 'Config' has no properties in common with type 'BaseConfig'. so will need a different solution to make this nicer

Just make BaseConfig an interface rather than a type. Should do it I think.

cool, that seems to be working. this should be gtg


update 2 libs

Pre-submit checklist:

Branch

[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages

PR

[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

If you updated any cabal files or added Haskell packages:

[ ] nix-shell shell.nix --run updateMaterialized to update the materialized Nix files
[ ] Update hie-*.yaml files if needed

If you changed any Haskell files:

[ ] nix-shell shell.nix --run fix-stylish-haskell to fix any formatting issues

If you changed any Purescript files:

[ ] nix-shell shell.nix --run fix-purty to fix any formatting issues

Pre-merge checklist:

[ ] Someone approved it
[ ] Commits have useful messages
[ ] Review clarifications made it into the code
[ ] History is moderately tidy; or going to squash-merge

Oh wait, can we ditch the allow-newer stuff relating to servant too?

web-ghc doesn't compile with the new prometheus, it actually needs some change.

@michaelpj if I fix web-ghc then it breaks stack builds and will only work with cabal and nix.

Why? Can't you just change the version of prometheus specified in stack.yaml to match?

oh I made a mistake, I think I can get this working.

GH actions being stupid, thanks for fixing things!


Some Jupiter Brain backend refactoring

Mainly:

Split the "wait for SSH to come up" loop into two separate functions"
Move HTTP API things to a separate type

The general goal here was to make the functions smaller and easier to read (they used to be bigger than what could fit on my screen, which I think is too big for it to be easy to keep track of what's going on).

Pushed a bug fix that adds a sleep between the creation and the polling.


Merge from main into matias-ogre2.3

Work-in-progress merge from main.
@darksylinc @iche033 I believe this has the conflicts resolved from merging from main.
Any way you look at it, the diff is going to be quite large, hopefully this is useful.

I was planning on rebasing 2.3 branch tomorrow onto the new main

I'll close this one then, thanks.


proxy: enable/disable cache_store_log in GUI

If enabled, point to /var/log/squid/store.log

Its a bug :) the attribute is in there expecting squid.conf to default to /var/log/squid/store.log
Will fix this and close.

I feel bad for not fixing this... I grep'ed for the config setting only, thought it was unconditionally and not available on the GUI. Sorry and thank you! :)

No problem, it wasn't a lot of work fixing it :)


Pixiv locking up

Hopefully it's a server-side issue. Otherwise we'd have to figure out a way to refresh the refresh token as it's probably expired. Waiting a day to see if it remains the same.

Fixed on 5794ca6cd237d5a8ac25ff21be068d2d7bc66e71. Problem was that the authentication wasn't being awaited.


UI Library

Adding/separating UI Library

You are adding generated files. Please remove them. After the number of files changed decreases considerably from this huge number, I'll review :smile:

@michaelEllisUy maybe we should ignore just "build" in the root .gitignore file.
Also, why there's a "userinterface" folder inside "ui"?

@bryant1410 yes, that was it

Can you merge master here? :)

@diegomedina248 this is still wip. Need to do the things you did to create the separate library. Branch is updated to be merged later yes. Not sure if this answers your question?

@michaelEllisUy I thought this branch originated from the coreLibrary branch. If so, it has some code that was already reviewed. Sorry, thought this was out of WIP

@diegomedina248 branch points to current master branch, that was fixed already. It is still WIP because there are things to be done to make it an independent library.

Not WIP anymore.

@bryant1410 @matir91 @diegomedina248 this is to be merged already. Please check whatever you need so we can merge


Rendering issue with Catwalks LLC

Mod Name
Catwalks LLC
Mod Homepage
https://www.curseforge.com/minecraft/mc-mods/catwalks-llc
Minecraft version
1.20.1
Describe the bug
Rendering error when trying to launch minecraft
Steps to reproduce

...
Logs
https://mclo.gs/nDZ9aJm
Additional context
No response

As our LTS support target, 1.20.1 now only receives critical fixes related to Connector bugs. Please upgrade to the latest version for mod compatibility support.


hyperion JSON server

[x] I confirm that this is an issue rather than a question.

Bug report
Hyperion-remote commands do not work if the active instance isn't the first one in the "LED Hardware instance management" section
Note: the "First LED Hardware instance" cannot be disabled for some reason.
Steps to reproduce
create another hardware instance below the "First LED Hardware instance" and configure to use it
What is expected?
a higher priority  request should be accepted. (ie. when it comes from the hyperion app with a priority of 50 compared to the screengrabber priority of 150)
What is actually happening?
the log shows the commands being successfully received but the actions are not performed.
System

Hyperion Server:

Build:           master (GitHub-69e325c0/3b1ca20b-1636305077)
Build time:      Nov 14 2021 09:14:58
Git Remote:      https://github.com/hyperion-project/hyperion.ng.git
Version:         2.0.12
UI Lang:         en (BrowserLang: en-US)
UI Access:       expert
Avail Capt:      dispmanx,v4l2,framebuffer,qt
Config path:     /home/osmc/.hyperion
Database:        read/write

Hyperion Server OS:

Distribution:   Open Source Media Center
Architecture:   arm
CPU Model:      ARMv7 Processor rev 4 (v7l)
CPU Type:       Raspberry Pi 3 Model B Rev 1.2
CPU Revision:   a02082
CPU Hardware:   BCM2835
Kernel:         linux (4.19.122-2-osmc (WS: 32))
Root/Admin:     false
Qt Version:     5.11.3
Python Version: 3.7.3
Browser:        Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36

@vlascoff Currently hyperion-remote only works against the first instance.
To have it work against multiple instances requires enhancements.
Therefore, I tagged the item as a Feature Request.

@vlascoff Sorry, I rechecked again....
If you want to run hyperion-remote against an specific instance, make use of the "-I" option.
Sample:
hyperion-remote -I "2nd Instance" -c blue

thanks for the feedback, can this feature be extended to the hyperion app eventually? there is no way of editing how the command is sent

Now I get it.
You are referring to the mobile app and not the command line utility hyperion-remote.
You might have mentioned it in the description, as well as the title is misleading....
The issue you are raising is related to the apps capabilities; hyperion can handle multiple instances via API.
As we do not maintain the app, please reach out to the app's provider.


Release gax-java v1.44.0

This pull request was generated using releasetool.
04-15-2019 14:23 PDT
Dependencies

Upgrade auth library to 0.15.0. (#701)

Updated manually on this PR, and filed PR to releasetool for future releases.

Release is at https://github.com/googleapis/gax-java/releases/tag/v1.44.0


apps/progs.pl: use SOURCE_DATE_EPOCH if defined for copyright year

As with 11d7d903, use SOURCE_DATE_EPOCH for the copyright year if it is
defined, to avoid reproducibility problems.
CLA: trivial
Signed-off-by: Ross Burton<EMAIL_ADDRESS>Change-Id: I1bea19070411a69155c43de7082350fb2c499da3

Checklist

[x] documentation is added or updated
[x] tests are added or updated

This pull request is ready to merge

Merged to master and 3.0.  Thanks for the contribution.


:bug: Install gcc for alternate architectures

Signed-off-by: Jason Montleon<EMAIL_ADDRESS>

We need gcc for alternate architectures.
The reason for the split in install is that we're picking up newer versions of python and gcc packages from centos with libs split in baseos, so I'm installing everything we can from UBI first, then picking up what we can't get from UBI from CentOS to avoid problems installing version locked packages and dependencies.

I've also removed ppc64le and s390x from the build. There does not seem to be a source for torch and its dependencies, and I don't have much hope for building them with emulation.


Upgrade to polkadot-v1.0.0

@weezy20 the CI didn't trigger. Any idea why?

@Moliholy
Yeah the current work flow does not trigger on opened PRs. That's a todo that will be shortly resolved.

You can mark your pr ready for review. That should trigger it.

try-runtime does not build. @Moliholy please check.

@weezy20 true. I just fixed it.

Rebased to include the newest commits from wzy/polkadot-v0.9.43.
@stiiifff I did undo the cargo update command and tried to match the same versions of the dependencies as in the original substrate template. Take a look anyway just in case I missed something.

@stiiifff ready for round two! 🚀

@stiiifff I just realized the template pallet was renamed to pallet-parachain-template in the 0.9.43 migration. I differs from the original template, so I again renamed it to pallet-template in order to stick to it as much as possible. Should I change the name back to how it was?


Add first HF warning banner

As specified here.
Looks like this:

At a quick glance this looks okay - merging and if there's ideas on improving, by all means let's improve!


[Settings] Fixing inconsistent theme/app mode naming

Summary of the Pull Request
Addressing issue #7356.
Fixing the inconsistent naming, and following UWP guidelines. Color mode selection now looks like this on the General, Run and Shortcut Guide page:

and adding a HyperlinkButton that allows the user to open the Windows color settings page.
PR Checklist

[X] Applies to #7356.
[ ] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Thoughts: Is it clear for what the colour settings on the general page are used? (We have removed the word settings now.)

I'm good with these changes to be merged in


NotImplementedError on assume_role_with_web_identity with mock_sts in Python 3.6.8

Hello, I'm getting a NotImplementedError when trying to mock the assume_role_with_web_identity function :
from moto import mock_sts
import boto3

@mock_sts
def test_get_credentials_from_sts():

        session = boto3.Session()
        sts_client = session.client("sts")

        credentials = sts_client.assume_role_with_web_identity(
            RoleArn="...",
            RoleSessionName="...",
            WebIdentityToken="...")

Tested with moto 1.3.16. Fails in Python 3.6.8, but works fine with 3.8.1. Same results replacing the mock_sts decorator with mock_sts_deprecated.
Traceback is :
self = <moto.sts.responses.TokenResponse object at 0x000001FB4CAC5A90>

    def call_action(self):
        headers = self.response_headers
        action = camelcase_to_underscores(self._get_action())
        method_names = method_names_from_class(self.__class__)
        if action in method_names:
            method = getattr(self, action)
            try:
                response = method()
            except HTTPException as http_error:
                response = http_error.description, dict(status=http_error.code)

            if isinstance(response, six.string_types):
                return 200, headers, response
            else:
                if len(response) == 2:
                    body, new_headers = response
                else:
                    status, new_headers, body = response
                status = new_headers.get('status', 200)
                headers.update(new_headers)
                # Cast status to string
                if "status" in headers:
                    headers['status'] = str(headers['status'])
                return status, headers, body

        if not action:
            return 404, headers, ''

        raise NotImplementedError(
>           "The {0} action has not been implemented".format(action))
E       NotImplementedError: The assume_role_with_web_identity action has not been implemented

Hi @awecx, I can't reproduce this using 3.6.8 I'm afraid. Are you sure the moto version is 1.3.16? That method should be available from 1.3.14 upwards.
What does pip freeze look like?

Hi @bblommers, I've double checked, It was indeed a misconfig in my env.
Did not work in 1.3.13 as expected, and works fine with 1.3.16 indeed.
Apologies for time wasted here.

No worries @awecx, glad it now works!


About Extrinsic Evaluation

Hello, I'm really interested in the part related to Extrinsic Evaluation in your paper. I read the papers you cited, but some details are still unclear. For example, how to convert assertions to natural language (which are used as context); or some other the training details in this project. Could you provide the code or some other related projects ? Maybe LAMA  is a good start?

Hello.
To clarify, in the extrinsic evaluation, we only use pre-trained LMs without any fine-tuning. What we do is we only collect some relevant assertions from a CSKB and concatenate them with the given question, then we feed all of them to the LM (see also Table 4 in our paper for example, or you can play with our QA demo at https://ascent.mpi-inf.mpg.de/qa). All the LMs we used (i.e., RoBERTa, GPT-2 and ALBERT) could be found in the HuggingFace Transformers library (https://huggingface.co/models).
Yes, the LAMA project could be a good start for mask prediction evaluation. For the other QA settings (i.e., generation and span prediction), we only took the output of LMs and ask for human evaluation.
About converting assertions to natural language: We used an embarrassingly simple approach:

making subject plural: e.g., lion -> lions
convert "be" in predicates to "are"
concatenate subject, predicate, object

There are certainly better approaches for this. Obviously our approach will produce some grammar mistakes, but I would not worry much about it as the large pre-trained LMs can somehow deal with those mistakes decently.
For canonical schema like in ConceptNet, you can look at Table 9 in this paper (https://arxiv.org/pdf/2010.05953.pdf) for translation templates.

Thank you a lot : ）


Update locale/en from nullius-1.3.3

This PR is automatically created by the GitHub Action workflow Create update-locale PR

#77 supersedes this


File operations in a dired buffer should call revert-buffer when finished succesfully

What did you expect to happen?
the dired buffer remains unchanged despite renaming a file in the directory it visits.
What actually happened?
I do not see the results of rename-file in the dired buffer I'm visiting. (In my case I moved it to another folder so it should have disappeared)
This should effect deletions, renaming, moving and creating directories, etc.

Add this to ~/.doom.d/config.el and let me know if it works for you:
(defadvice! +dired-refresh-buffers-after-rename-a (&rest _)
    :after #'rename-file
    (dolist (buf (doom-buffers-in-mode 'dired-mode))
      (with-current-buffer buf
        (revert-buffer t t t))))

Normally, Doom auto-reverts buffers when you focus them or their containing window, or when you focus Emacs (after doing something elsewhere). This wasn't happening in non-file buffers, like dired buffers, until 9cab6a6, which should fix your issue indirectly.
I had considered refreshing all dired buffers after any call to rename-file, but this could have disastrous performance implications anywhere where rename-file is used programmatically on a large number of files -- and there is no way to determine whether it's being used for batch renaming or one-off jobs -- so I opted for this solution instead.

Very nice. Thank you for taking a stab at this 😀


Source Control doesn't integrate with 2017 version of GitHub Desktop (unlike previous version).

VSCode Version: Code 1.18.1 (929bacba01ef658b873545e26034d1a8067445e9, 2017-11-16T18:23:26.125Z)
OS Version: Darwin x64 17.2.0
Extensions:

Extension
Author (truncated)
Version

code-settings-sync
Sha
2.8.6

html-css-class-completion
Zig
1.14.0

project-manager
ale
0.23.0

path-intellisense
chr
1.4.2

vscode-eslint
dba
1.4.3

vscode-great-icons
emm
2.1.20

php-debug
fel
1.12.1

php-intellisense
fel
2.0.4

php-pack
fel
1.0.1

auto-close-tag
for
0.5.5

auto-rename-tag
for
0.0.15

vscode-css-peek
pra
2.0.2

Steps to Reproduce:

Reproduces without extensions: Yes/No

What do you mean, "integrate with 2017 version of GitHub Desktop"? Please be very specific and include enough details for us to reproduce the issue.

Having GitHub desktop installed and Visual Studio Code, in the previous version, I’d have commands here (for which now I don’t):
[cid:329C7F6A-D501-42C2-BF05-94056DDC9DC1]
On the other hand, GitHub Desktop seems to recognise that Visual Studio Code is installed (just like in the previous version):
[cid:95135FDA-1994-4A0E-BD84-4570A70FE079]
I’m aware that the previous version is referred as “native” online the new one (link for reference https://github.com/desktop/desktop/issues/2885)
Thanks
On 4 Dec 2017, at 22:57, Rob Lourens <notifications<EMAIL_ADDRESS>wrote:
What do you mean, "integrate with 2017 version of GitHub Desktop"? Please be very specific and include enough details for us to reproduce the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vscode/issues/39590#issuecomment-349119569, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM3sPfFkBIWF1wue_U7HZHb6O1FAtsBIks5s9Gq9gaJpZM4Q1YSU.

If you tried to attach screenshots, they didn't make it through, you'll have to upload them directly on this issue.

The only thing that matters on VS Code's end is whether there is a git repo in the open folder. Is there a .git/ folder in your folder?

Yes, it does:

@Rafyelzz With this new version, you need to install the official Git release from https://git-scm.com/
More info: https://github.com/Microsoft/vscode/pull/35965


The type initializer for 'DiffEngine.ProcessCleanup' threw an exception. on running test

Describe the bug
When running a test that uses Verify, the following error is being reported:
System.TypeInitializationException: The type initializer for 'DiffEngine.ProcessCleanup' threw an exception.

System.TypeInitializationException
The type initializer for 'DiffEngine.ProcessCleanup' threw an exception.
   at DiffEngine.ProcessCleanup.TryGetProcessInfo(String command, ProcessCommand& process)
   at DiffEngine.DiffRunner.InnerLaunchAsync(TryResolveTool tryResolveTool, String tempFile, String targetFile, Encoding encoding) in C:\projects\diffengine\src\DiffEngine\DiffRunner.cs:line 146
   at VerifyEngine.RunDiffAutoCheck(FilePair file, Boolean autoVerify) in /_/src/Verify/Verifier/VerifyEngine.cs:line 255
   at VerifyEngine.ProcessNotEquals() in /_/src/Verify/Verifier/VerifyEngine.cs:line 211
   at VerifyEngine.ThrowIfRequired() in /_/src/Verify/Verifier/VerifyEngine.cs:line 133
   at VerifyTests.InnerVerifier.VerifyInner(Object root, Func`1 cleanup, IEnumerable`1 targets, Boolean doExpressionConversion) in /_/src/Verify/Verifier/InnerVerifier_Inner.cs:line 34
   at VerifyTests.InnerVerifier.Verify(Object target) in /_/src/Verify/Verifier/InnerVerifier_Object.cs:line 71
   at VerifyXunit.Verifier.<>c__DisplayClass9_0.<<Verify>b__0>d.MoveNext() in /_/src/Verify.Xunit/Verifier.cs:line 74
--- End of stack trace from previous location ---
   at Xunit.Sdk.TestInvoker`1.<>c__DisplayClass47_0.<<InvokeTestMethodAsync>b__1>d.MoveNext() in /_/src/xunit.execution/Sdk/Frameworks/Runners/TestInvoker.cs:line 259
--- End of stack trace from previous location ---
   at Xunit.Sdk.ExecutionTimer.AggregateAsync(Func`1 asyncAction) in /_/src/xunit.execution/Sdk/Frameworks/ExecutionTimer.cs:line 48
   at Xunit.Sdk.ExceptionAggregator.RunAsync(Func`1 code) in /_/src/xunit.core/Sdk/ExceptionAggregator.cs:line 90

System.PlatformNotSupportedException
System.Management currently is only supported for Windows desktop applications.
   at System.Management.ManagementObjectSearcher..ctor(String queryString)
   at WindowsProcess.FindAll() in C:\projects\diffengine\src\DiffEngine\Process\WindowsProcess.cs:line 35
   at DiffEngine.ProcessCleanup.FindAll() in C:\projects\diffengine\src\DiffEngine\Process\ProcessCleanup.cs:line 98
   at DiffEngine.ProcessCleanup.Refresh() in C:\projects\diffengine\src\DiffEngine\Process\ProcessCleanup.cs:line 34
   at DiffEngine.ProcessCleanup..cctor() in C:\projects\diffengine\src\DiffEngine\Process\ProcessCleanup.cs:line 27

No diff window opens upon running the text.
Running the test does generate the expected *.received.txt and *.verified.txt, with the received file being empty and the verified file being empty.
From Rider, right clicking on the failed test to perform the "Accept Received" or "Compare Received/Verified" context menu command do not anything. The verified file remains unchanged.
Manually adjusting the verified file to have it match to received file does not make the error go away.
Context:
The code is running on an Windows machine (Microsoft Windows 11 Enterprise v10.0.22631 Build 22631), using Rider 2024.1.3 running dotnet version 8.0.300.
The project targets dot6.0.
Packages used:

xunit v2.9.2
xunit.runner.visualstudio v2.8.2
Verify.Xunit 28.3.0
Microsoft.NET.Test.Sdk 17.11.1

Rider has the Verify Support plugin installed, v2024.1.2.
dotnet tool diffenginetray v15.5.4 is installed and running in tray.
I found an earlier report similar to my observations: https://github.com/VerifyTests/Verify/issues/969
Minimal Repro
See attached zip file.
TestProject1.zip
Submit a PR that fixes the bug
Unsure what's is causing the problem, therefore unsure how to fix the problem or suggest a PR.

As this is running on a corporate laptop, I wonder if a lack of admin rights could be the cause of this?

In the Minimal Repro, if I change the target from dotnet6.0 to dotnet8.0 the error goes away, and the diff-tool launches upon running the test.

this is caused by me updating to the new System.Management. which for some reason thinks net6 is not windows and throws.
i have rolled back System.Management in 28.3.1 to get u unstuck. but given net6 is no longer supported, i suggest u update to a support version of dotnet
no point raising a bug with MS given net6 is unsupported

i have rolled back System.Management in 28.3.1 to get u unstuck. but given net6 is no longer supported, i suggest u update to a support version of dotnet -SimonCropp

Thanks for the quick response!
I'm actually busy doing a migration to .NET8 for a project as we speak, and was experimenting with using Verify as a toolchain to lock in some current behavior for automated regression tests before upgrading all packages to the latest versions 👍


Flutter engine crashes on some Android devices due to "Failed to setup Skia Gr context"

Steps to Reproduce
This crash was happened on users' Android phone. I don't know clear steps to reproduce.
User starts the FlutterActivity then the APP crashes immediately.
Devices:

Huawei DUB AL00A
Huawei DUB AL00
Honor BKK AL10
Huawei ARS AL00
Huawei DUB AL20

Android version: Android 8.1.0,level 27
I noticed that they are all Huawei phones, and the EMUI version is 8.x,  some of which using the Qualcomm Snapdragon processor.

updated at 2020-1-3
After investigating, I found the root cause was the skia attemping to use GL_QCOM_TILED_RENDERING on these phones. Ssee https://skia-review.googlesource.com/c/skia/+/246282/2. But something went wrong as the logcat said.
If you are troubling on this issue, you can try to roll back the skia revision and use your local compiled flutter engine, before the flutter team fixed this issue.
Logs

W libEGL : [eglGetProcAddress] QCOM code detected: glEndTilingQCOM ... Returning NULL
W libEGL : [eglGetProcAddress] QCOM code detected: glStartTilingQCOM ... Returning NULL
E flutter : [ERROR:flutter/shell/gpu/gpu_surface_gl.cc(70)] Failed to setup Skia Gr context.
W libEGL : [eglGetProcAddress] QCOM code detected: glEndTilingQCOM ... Returning NULL
W libEGL : [eglGetProcAddress] QCOM code detected: glStartTilingQCOM ... Returning NULL

main thread stack trace:
1 io.flutter.embedding.engine.FlutterJNI.nativeSurfaceCreated(Native Method)
2 io.flutter.embedding.engine.FlutterJNI.onSurfaceCreated(FlutterJNI.java:3)
3 io.flutter.embedding.engine.renderer.FlutterRenderer.startRenderingToSurface(FlutterRenderer.java:16)
4 io.flutter.embedding.android.FlutterSurfaceView.connectSurfaceToRenderer(FlutterSurfaceView.java:3)
5 io.flutter.embedding.android.FlutterSurfaceView.b(FlutterSurfaceView.java:1)
6 io.flutter.embedding.android.FlutterSurfaceView$a.surfaceCreated(FlutterSurfaceView.java:4)
7 android.view.SurfaceView.updateSurface(SurfaceView.java:728)
8 android.view.SurfaceView$2.onPreDraw(SurfaceView.java:151)
9 android.view.ViewTreeObserver.dispatchOnPreDraw(ViewTreeObserver.java:977)
10 android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2573)
11 android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1558)
12 android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7463)
13 android.view.Choreographer$CallbackRecord.run(Choreographer.java:1041)
14 android.view.Choreographer.doCallbacks(Choreographer.java:847)
15 android.view.Choreographer.doFrame(Choreographer.java:774)
16 android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1027)
17 android.os.Handler.handleCallback(Handler.java:809)
18 android.os.Handler.dispatchMessage(Handler.java:102)
19 android.os.Looper.loop(Looper.java:166)
20 android.app.ActivityThread.main(ActivityThread.java:7555)

1.gpu thread: signal SIGSEGV(SEGV_MAPERR)
#00 0x001682a8 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
flutter::Rasterizer::Setup(std::__1::unique_ptr<flutter::Surface, std::__1::default_delete<flutter::Surface> >)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/shell/common/rasterizer.cc:69:17
#01 0x0016ec67 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
flutter::Shell::OnPlatformViewCreated(std::__1::unique_ptr<flutter::Surface, std::__1::default_delete<flutter::Surface> >)::$_8::operator()()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/shell/common/shell.cc:566:23
auto fml::internal::CopyableLambda<flutter::Shell::OnPlatformViewCreated(std::__1::unique_ptr<flutter::Surface, std::__1::default_delete<flutter::Surface> >)::$_8>::operator()<>() const
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/make_copyable.h:24:0
#02 0x00146755 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
std::__1::function<void ()>::operator()() const
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/functional:2419:12
fml::MessageLoopImpl::FlushTasks(fml::FlushType)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop_impl.cc:123:0
fml::MessageLoopImpl::RunExpiredTasksNow()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop_impl.cc:133:0
#03 0x00148489 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::MessageLoopAndroid::OnEventFired()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:92:5
fml::MessageLoopAndroid::MessageLoopAndroid()::$_0::operator()(int, int, void*) const
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:42:0
fml::MessageLoopAndroid::MessageLoopAndroid()::$_0::__invoke(int, int, void*)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:40:0
#04 0x0000ff09 /system/lib/libutils.so (_ZN7android6Looper9pollInnerEi+580) [armeabi-v8::862798b286f1ba97372696549a8bea80]
#05 0x0000fc2d /system/lib/libutils.so (_ZN7android6Looper8pollOnceEiPiS1_PPv+32) [armeabi-v8::862798b286f1ba97372696549a8bea80]
#06 0x0000c9e1 /system/lib/libandroid.so (ALooper_pollOnce+56) [armeabi-v8::2f44f33bd999188a75f397fa44228d46]
#07 0x00148561 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::MessageLoopAndroid::Run()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:68:18
#08 0x00145adf /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::MessageLoopImpl::DoRun()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop_impl.cc:92:3
fml::MessageLoop::Run()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop.cc:49:0
#09 0x001474a1 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0::operator()() const
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/thread.cc:34:10
decltype(std::__1::forward<fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(fp)()) std::__1::__invoke<fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0&&)
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/type_traits:3530:0
void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>&, std::__1::__tuple_indices<>)
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/thread:341:0
void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0> >(void*)
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/thread:351:0
#10 0x000473eb /system/lib/libc.so (_ZL15__pthread_startPv+22) [armeabi-v8::c38cb0ea3187a942d434b91b139f1edd]
#11 0x0001ad29 /system/lib/libc.so (__start_thread+32) [armeabi-v8::c38cb0ea3187a942d434b91b139f1edd]

[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.14.6 18G2022, locale zh-Hans-CN)
    • Flutter version 1.12.13+hotfix.5 at /Users/wangyongrong/Library/flutter
    • Framework revision 27321ebbad (2 weeks ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/wangyongrong/Documents/Android-SDK
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/wangyongrong/Documents/Android-SDK
    • Java binary at: /Applications/Android Studio 2.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] VS Code (version 1.41.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.7.1

[✓] Connected device (1 available)
    • VOG AL10 • APH7N19329001298 • android-arm64 • Android 9 (API 28)

Workaround for this issue: enable software rendenring
Initialize flutter with args:
FlutterMain.ensureInitializationComplete(context, new String[]{FlutterShellArgs.ARG_ENABLE_DART_PROFILING}

Or
Intent flutterActivity = ...;
flutterActivity.put(FlutterShellArgs.ARG_KEY_ENABLE_SOFTWARE_RENDERING, true);
startActivity(flutterActivity)

加了这个会有其他的影响么？

加了这个会有其他的影响么？

页面会变卡，不过我发现只有EMUI 8.2.0 的手机上会崩，所有只针对这些手机开启这个选项，@nuptdzs

加了这个会有其他的影响么？

页面会变卡，不过我发现只有EMUI 8.2.0 的手机上会崩，所有只针对这些手机开启这个选项，@nuptdzs
今天上线突然遇到这个问题。只能先回退版本了，机型判断的话担心遗漏不敢这么处理。

@nuptdzs 你回退到哪个版本不会崩?

@nuptdzs 你回退到哪个版本不会崩?

1.10.7，理论上1.12以下都行。

@nuptdzs你回退到该版本不会崩溃？

1.10.7，理论上1.12以下都行。

我也遇到设个问题，怎么回退版本啊

Hi @yrom @nuptdzs @chg2015
if you update your flutter version recently
you may want to run
flutter clean
flutter pub cache repair
let me know if the issue persists
thank you

me too!

Hi @yrom @nuptdzs @chg2015
if you update your flutter version recently
you may want to run
flutter clean
flutter pub cache repair
let me know if

Hi @yrom @nuptdzs @chg2015
if you update your flutter version recently
you may want to run
flutter clean
flutter pub cache repair
let me know if the issue persists
thank you

Hi @yrom @nuptdzs @chg2015
if you update your flutter version recently
you may want to run
flutter clean
flutter pub cache repair
let me know if the issue persists
thank you

I also encountered a problem, but this commond can not resolve.

Hi @yrom @nuptdzs @chg2015
if you update your flutter version recently
you may want to run
flutter clean
flutter pub cache repair
let me know if the issue persists
thank you

I also encountered a problem, but this commond can not resolve.

Hi @yrom @nuptdzs @chg2015
if you update your flutter version recently
you may want to run
flutter clean
flutter pub cache repair
let me know if the issue persists
thank you

Hi @yrom @nuptdzs @chg2015
if you update your flutter version recently
you may want to run
flutter clean
flutter pub cache repair
let me know if the issue persists
thank you

no,荣耀 8c 不通过

Hi @yrom @nuptdzs @chg2015
if you update your flutter version recently
you may want to run
flutter clean
flutter pub cache repair
let me know if the issue persists
thank you

I also encountered a problem, and this command can not resolve.

Workaround for this issue: enable software rendering
Initialize flutter with args before starting FlutterActivity:
FlutterMain.ensureInitializationComplete(context, new String[]{FlutterShellArgs.ARG_ENABLE_DART_PROFILING});

Or
Intent flutterActivity = ...; // build intent
flutterActivity.put(FlutterShellArgs.ARG_KEY_ENABLE_SOFTWARE_RENDERING, true);
startActivity(flutterActivity);

在app的onCreate里面加了这个还是不起作用

@andisolo what's the EMUI version on your phone?

@andisolo what's the EMUI version on your phone?

设备型号:BKK-AL10
系统版本号:BKK-AL10 <IP_ADDRESS>(C00)
安卓sdk版本:27
处理器:arm64-v8a
emui版本:EmotionUI_8.2.0

@andisolo sorry,I make a mistake! updated the snippet:
FlutterMain.ensureInitializationComplete(context, new String[]{FlutterShellArgs.ARG_KEY_ENABLE_SOFTWARE_RENDERING});

@andisolo sorry,I make a mistake! updated the snippet:
FlutterMain.ensureInitializationComplete(context, new String[]{FlutterShellArgs.ARG_KEY_ENABLE_SOFTWARE_RENDERING});

我按照你所说的修改了,现在启动的错误日志如下:
[ERROR:flutter/runtime/dart_vm_data.cc(18)] VM snapshot invalid and could not be inferred from settings.
[ERROR:flutter/runtime/dart_vm.cc(241)] Could not setup VM data to bootstrap the VM from.
[ERROR:flutter/runtime/dart_vm_lifecycle.cc(84)] Could not create Dart VM instance.

The FlutterShellArgs.ARG_KEY_ENABLE_SOFTWARE_RENDERING should be FlutterShellArgs.ARG_ENABLE_SOFTWARE_RENDERING, so sorry..

好了,非常感谢.

The FlutterShellArgs.ARG_KEY_ENABLE_SOFTWARE_RENDERING should be FlutterShellArgs.ARG_ENABLE_SOFTWARE_RENDERING, so sorry..

由遇到了和#47765 一样的错误,你知道怎么解决吗?

遇到同样的问题

@andisolo   你解决了吗

Workaround for this issue: enable software rendering
Initialize flutter with args before starting FlutterActivity:
FlutterMain.ensureInitializationComplete(context, new String[]{FlutterShellArgs.ARG_ENABLE_SOFTWARE_RENDERING});

Or
Intent flutterActivity = ...; // build intent
flutterActivity.put(FlutterShellArgs.ARG_KEY_ENABLE_SOFTWARE_RENDERING, true);
startActivity(flutterActivity);

这个加在哪个文件呀

同问
Workaround for this issue: enable software rendering
Initialize flutter with args before starting FlutterActivity:
FlutterMain.ensureInitializationComplete(context, new String[]{FlutterShellArgs.ARG_ENABLE_SOFTWARE_RENDERING});
Or
Intent flutterActivity = ...; // build intent
flutterActivity.put(FlutterShellArgs.ARG_KEY_ENABLE_SOFTWARE_RENDERING, true);
startActivity(flutterActivity);
加在哪

加在app的onCreate生命周期,但是如果有用到原生的view还是会crash详见#47765

加在app的onCreate生命周期,但是如果有用到原生的view还是会crash详见#47765

MainActivity.kt的文件下
class MainActivity: FlutterActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
Intent flutterActivity = ...; // build intent
flutterActivity.put(FlutterShellArgs.ARG_KEY_ENABLE_SOFTWARE_RENDERING, true);
startActivity(flutterActivity);
GeneratedPluginRegistrant.registerWith(this)
}
}
这样吗？

@andisolo   你有尝试回退flutter 版本解决这个问题吗

@andisolo 你有尝试回退flutter 版本解决这个问题吗

回退是没有问题的，但是我不想回退。。

加在app的onCreate生命周期,但是如果有用到原生的view还是会crash详见#47765

MainActivity.kt的文件下
class MainActivity: FlutterActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
Intent flutterActivity = ...; // build intent
flutterActivity.put(FlutterShellArgs.ARG_KEY_ENABLE_SOFTWARE_RENDERING, true);
startActivity(flutterActivity);
GeneratedPluginRegistrant.registerWith(this)
}
}
这样吗？

不是的,自定义app继承FlutterApplication然后在onCreate添加就行了,一定要在父类的onCreate之后

加了这个会有其他的影响么？
Will this have other effects?

治标不治本，没用的，加了变卡，还不如回退版本

我滴个法克，我找了半天问题

After investigating, I found the root cause was the skia attemping to use GL_QCOM_TILED_RENDERING on these phones. See https://skia-review.googlesource.com/c/skia/+/246282/2. But something went wrong as the logcat said.
W libEGL : [eglGetProcAddress] QCOM code detected: glEndTilingQCOM ... Returning NULL
W libEGL : [eglGetProcAddress] QCOM code detected: glStartTilingQCOM ... Returning NULL

If you are troubling on this issue, you can try to roll back the skia revision and use your local compiled flutter engine, before the flutter team fixed this issue.
The worked skia revision which I have a try is 768f900a88cbfc5237e8edcc16aadde32536ed3e
My .gclient file for compiling engine:
solutions = [
  {
    "managed": False,
    "name": "src/flutter",
    "url": "https://github.com/flutter/engine.git@2994f7e1e682039464cb25e31a78b86a3c59b695",
    "custom_deps": {
      'src/third_party/skia': "https://skia.googlesource.com/skia.git@768f900a88cbfc5237e8edcc16aadde32536ed3e",
      'src/third_party/wuffs': 'https://skia.googlesource.com/external/github.com/google/wuffs.git@65e7b2b6c98a4d35e26bc2fc437e2e00f1393dc2',
    },
    "deps_file": "DEPS",
    "safesync_url": "",
  },
]

May this comment can help you.

我同样遇到了这个问题，我回退了版本到v1.9.1+hotfix.6
I also encountered this problem, I rolled back the version to v1.9.1 + hotfix.6

v1.9.1+hotfix.6 ios无法正常执行flutter run

After investigating, I found the root cause was the skia attemping to use GL_QCOM_TILED_RENDERING on these phones. See https://skia-review.googlesource.com/c/skia/+/246282/2. But something went wrong as the logcat said.
W libEGL : [eglGetProcAddress] QCOM code detected: glEndTilingQCOM ... Returning NULL
W libEGL : [eglGetProcAddress] QCOM code detected: glStartTilingQCOM ... Returning NULL

If you are troubling on this issue, you can try to roll back the skia revision and use your local compiled flutter engine, before the flutter team fixed this issue.
The worked skia revision which I have a try is 768f900a88cbfc5237e8edcc16aadde32536ed3e
My .gclient file for compiling engine:
solutions = [
  {
    "managed": False,
    "name": "src/flutter",
    "url": "https://github.com/flutter/engine.git@2994f7e1e682039464cb25e31a78b86a3c59b695",
    "custom_deps": {
      'src/third_party/skia': "https://skia.googlesource.com/skia.git@768f900a88cbfc5237e8edcc16aadde32536ed3e",
      'src/third_party/wuffs': 'https://skia.googlesource.com/external/github.com/google/wuffs.git@65e7b2b6c98a4d35e26bc2fc437e2e00f1393dc2',
    },
    "deps_file": "DEPS",
    "safesync_url": "",
  },
]

May this comment can help you.

怎么编译和使用这个skia呢？
How to compile and use this skia？

@yrom can you consistently repro the issue now? Would you be able to provide a sample project with minimum repro steps?

@zoeyfan You can reproduce this issue on the Huawei phone which using Qualcomm processor as mentioned. No explicit steps required, crash on Flutter app startup when built by latest stable Flutter 1.12.13.

@cbracken not sure if this is your team's domain. If so, please comment if the description above is sufficient for investigation. If not, please feel free to redirect.

Please fix this issue asap. I cannot use the latest version of the stable channel anymore. I have to use 1.10.x until the fix arrives.

Any updates on this? I think a quick fix is to revert the commits which @yrom mentioned.

https://github.com/flutter/flutter/issues/18601#issuecomment-558276407

@yrom could you provide Flutter.framework which works? it is complicated to build the flutter engine and network is a problem when i try to gclient sync. thanks

@zmtzawqlp I think it's easier to switch back to the older version. I checked the downloaded folder, it's about 16gb..

@zmtzawqlp v1.10.4 is the latest working version on Huawei devices. It's a Dev build in SDK Archive.

@xclud @rockingdice  thanks, but I'm worried about whether there is any problem at old version.

@zmtzawqlp  engine-2994f7e1e682039464cb25e31a78b86a3c59b695.zip, local repo for android and  only armv7 included, no Flutter.framework.

@yrom thank you very much ,it's very kind of you.

@yrom did you do something change for flutter_embedding_release? I just need to replace libflutter.so, right? or also need to use flutter_embedding_release jar in your zip?

@yrom I am sorry to disturb you again，flutter is still crash in Honor BKK AL10. i notice that size of libflutter.so is much smaller than official(armv7), please take a look when you have a time, thanks.

unfortunately I downgrade flutter to 1.7.8+hotfix.4 for solving the problem.

this is the commit which causes the the crash:
https://skia.googlesource.com/skia.git/+/b50cc81a3c211774d0d3c7bf55e8dfbc9061f7cd^!/
I reverted it and it works on my Huawei Honor 8C phone.

@birtanyildiz
Did you try downgrading to higher versions before going all the way to 1.7.8+hotfix.4? Did you maybe try 1.10.x?

@k00na 1.10.4 is the most recert version which works. Please see the link of git commit i posted above.

@k00na 1.10.4 is the most recert version which works. Please see the link of git commit i posted above.

isnt there samsung j4 j6 black screen problem in that version ?

@k00na 1.10.4 is the most recert version which works. Please see the link of git commit i posted above.

isnt there samsung j4 j6 black screen problem in that version ?

I dont have any of these models. But it works with galaxy models.

@yrom I am sorry to disturb you again，flutter is still crash in Honor BKK AL10. i notice that size of libflutter.so is much smaller than official(armv7), please take a look when you have a time, thanks.

@zmtzawqlp You mean after overriding libflutter.so, your Flutter app crashed on the same issue? Is there only armv7 in your apk? Make sure libflutter.so in your apk is overwritten as expected. My app works fine on the same device as you mentioned.

@yrom thanks, it's my mistake, it works at my side now.

cc @jason-simmons

This should be the same as https://github.com/flutter/flutter/issues/47164. I will close the other issue as there seems to be a bit more technical information on this thread. Please continue discussion here and reference the insight found in the other issue!

We have spoken with Skia, and they will revert the offending patch mentioned above for now to resolve this issue. Will verify on the test devices once they arrive. Thanks everyone for all the research as it made finding the problem much faster!

The underlying issue is probably a bad driver or chip from Huawei with an improperly implemented or missing feature, which is difficult to fix on shipped devices. The revert will avoid this issue for the time being.
I will update this issue as the revert lands/makes its way through the various rollers.

Hello. Won't it make the crash appear again for Samsung's J4 and J6 models?

We have spoken with Skia, and they will revert the offending patch mentioned above for now to resolve this issue. Will verify on the test devices once they arrive. Thanks everyone for all the research as it made finding the problem much faster!

I would appreciate if you let all of us know when the offending patch is reverted (and supposedly roll into flutter).
In reply to another comment of you, if is not only Huawei devices with driver bugs. Investigating Skia source code i found there is a similar bug with Nexus devices as well and the workaround is hard coded in source, something like if(is_device_nexus()) { ... }. I am suggesting the similar thing for Huawei devices too.

@k00na 1.10.4 is the most recert version which works. Please see the link of git commit i posted above.

To save others some time. 1.10.4 is not a good version to roll back to, has a iOS gesture detection bug https://github.com/flutter/flutter/issues/40863

@hermanmaritz You can have multiple versions. Currently i build android app with v1.10.4, iOS app with 1.12 hotfix6 and web app with master.

@hermanmaritz
I'm confirming the gesture detection bugs on iOS with 1.10.4.
@hermanmaritz
I did exactly the same and it works fine for me as well.

Skia is going to start with reverting the patch. It should roll into Flutter sometime this week. We should see if we can hotfix the skia change into stable, but it's not clear what that will involve just yet (/cc @tvolkert).
As Gary said, the basic problem is that the driver is advertising features it doesn't actually support, and when Skia goes to use those features, it results in a crash. The Skia team is going to figure out how to handle that better once some test devices are available here - for now, the plan is to just revert.

it's not clear what that will involve just yet

We'd need the Skia team to cherrypick the revert into a branch (off of commit c3ff97a98b74554854b5822797c6b7b431f4d8d2), then we'd cherrypick that new Skia commit into the engine on a hotfixes branch.
@bsalomon is this something Skia team would be willing to do?

@GaryQian Is there any quick fix for this issue except rolling back flutter version(we use some flutter 1.12 feature and don't want to rewrite the code)? Since we need to upload our apk this week, in case the hotfix version can't drop in time, I wonder if there is any patch we can apply by customizing local flutter engine or any commit we can revert manually.

@geeksammao I managed to deal with it with the following method:

Follow the guide of @yrom provided, you'll get all local engines for different architectures. You will need the release version if you want to make APKs.
Make an 'original.apk' using the original engines. (include all of the abi), unpack it with apktool.
Make a 'modified.apk' using one of your local engines. (--local-engine doesn't support for multiple targets). You have to limit the abi to the only one you use.
Extract those modified .so (/lib/arm64-v8a/* as an example) from the APK bundle, and replace the old one in the original.apk.
Repeat 3 and 4 steps for other abi.
Pack your original.apk with apktool and resign it with apksigner.

I tested it myself and it's working.

@geeksammao I managed to deal with it with the following method:

Follow the guide of @yrom provided, you'll get all local engines for different architectures. You will need the release version if you want to make APKs.
Make an 'original.apk' using the original engines. (include all of the abi), unpack it with apktool.
Make a 'modified.apk' using one of your local engines. (--local-engine doesn't support for multiple targets). You have to limit the abi to the only one you use.
Extract those modified .so (/lib/arm64-v8a/* as an example) from the APK bundle, and replace the old one in the original.apk.
Repeat 3 and 4 steps for other abi.
Pack your original.apk with apktool and resign it with apksigner.

I tested it myself and it's working.

You mean rolling back Skia with local engine compiled? I have done it but I can't confirm it doesn't have any other issues, so for now I pack 2 libflutter.so(one original, one with Skia rolled back) in one apk and only use the customized libflutter.so for those Huawei users. I think this is a dirty fix, so I want  to find a better one.

@geeksammao I managed to deal with it with the following method:

Follow the guide of @yrom provided, you'll get all local engines for different architectures. You will need the release version if you want to make APKs.
Make an 'original.apk' using the original engines. (include all of the abi), unpack it with apktool.
Make a 'modified.apk' using one of your local engines. (--local-engine doesn't support for multiple targets). You have to limit the abi to the only one you use.
Extract those modified .so (/lib/arm64-v8a/* as an example) from the APK bundle, and replace the old one in the original.apk.
Repeat 3 and 4 steps for other abi.
Pack your original.apk with apktool and resign it with apksigner.

I tested it myself and it's working.

You mean compiling local engine with Skia rolled back? I have done it but I can't confirm it doesn't have any other issues, so for now I pack 2 libflutter.so(one original, one with Skia rolled back) in one apk and only use the customized libflutter.so for those Huawei users. I think this is a dirty fix, so I want  to find a better one.

@geeksammao I managed to deal with it with the following method:

Follow the guide of @yrom provided, you'll get all local engines for different architectures. You will need the release version if you want to make APKs.
Make an 'original.apk' using the original engines. (include all of the abi), unpack it with apktool.
Make a 'modified.apk' using one of your local engines. (--local-engine doesn't support for multiple targets). You have to limit the abi to the only one you use.
Extract those modified .so (/lib/arm64-v8a/* as an example) from the APK bundle, and replace the old one in the original.apk.
Repeat 3 and 4 steps for other abi.
Pack your original.apk with apktool and resign it with apksigner.

I tested it myself and it's working.

You mean rolling back Skia with local engine compiled? I have done it but I can't confirm it doesn't have any other issues, so for now I pack 2 libflutter.so(one original, one with Skia rolled back) in one apk and only use the customized libflutter.so for those Huawei users. I think this is a dirty fix, so I want  to find a better one.

经历过这个BUG，公司内部给出了一个结论，为了保证线上用户使用不出现意外的崩溃问题：
1、无重大更新或者问题性修复时，不进行flutter 版本的更新；
2、内部需要更新flutter版本时，需要提前进行版本兼容性测试，覆盖APPtop机型，测试通过情况下方可使用flutter新版本进行开发。避免使用了新版开发测试出问题需要回退版本的问题。
After experiencing this bug, the company came to a conclusion that in order to ensure that online users do not have unexpected crash problems:

When there is no major update or problem repair, the version of flitter will not be updated;
When the internal version of flutter needs to be updated, the version compatibility test should be carried out in advance to cover the apptop model. If the test passes, the new version of flutter can be used for development. To avoid using the new version of development testing problems need to backoff the version of the problem.

It seems the bug is fixed in Skia now. I cant wait for the next flutter engine roll.
Here are the details:
https://skia.googlesource.com/skia.git/+/0a1923e50752073fd31ad667935c9e37681917e8

It seems the bug is fixed in Skia now. I cant wait for the next flutter engine roll.
Here are the details:
https://skia.googlesource.com/skia.git/+/0a1923e50752073fd31ad667935c9e37681917e8^!/

Skia rolled in https://github.com/flutter/flutter/pull/48733
I am happy to confirm v1.13.9-pre.63 is working on my Huawei mobile.
Thank you all for the great support.

Skia rolled in https://github.com/flutter/flutter/pull/48733
I am happy to confirm this PR is working on my Huawei mobile.
Thank you all for the great support.

Thanks for confirming! Appreciate the all the sleuthing everyone did, made the revert/fix a breeze. We have test devices coming soon, and will try to reland the reverted changes with confirmation that the bug is avoided.
I will close this for now, please feel free to continue providing feedback if relevant!

Is there going to be a hotfix or something?

@geeksammao  You should use the master channel instead now.

@AlexVincent525 I'm investigating putting together a hotfix (I'll need help from the Skia team creating the cherry-pick on a branch in their repo).

hello everyone,
new stable version has released, v1.12.13+hotfix.7-stable.
Can anyone check if the problem with Huawei is fixed in this version or not

Its significantly slow on my Huawei Honor 8C.

@godofredoc @GaryQian : we might need to add the 2 Huawei device to our device lab to continuously monitor this performance regression.

Could everyone who still has this problem please file a new issue with the exact descriptions what happens, logs and the output of 'flutter doctor -v'  please.
All system setups can be slightly different so it's always better to open new issues and reference related issues.

I upgraded the flutter and after that run flutter pub upgrade, but I still have this issue.
E/flutter ( 3316): [ERROR:flutter/shell/gpu/gpu_surface_gl.cc(70)] Failed to setup Skia Gr context.
flutter doctor -v
[✓] Flutter (Channel stable, v1.12.13+hotfix.7, on Mac OS X 10.14.6 18G103, locale en-US)
• Flutter version 1.12.13+hotfix.7 at /Users/home/Develop/SDK_Flutter
• Framework revision 9f5ff2306b (10 days ago), 2020-01-26 22:38:26 -0800
• Engine revision a67792536c
• Dart version 2.7.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/home/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.1, Build version 11A1027
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[✓] Connected device (1 available)
• HTC One X, 4 2 2, API 17, 720x1280 • <IP_ADDRESS>:5555 • android-x86 • Android 4.2.2 (API 17)
• No issues found!

The performance issues on those phones may also be improved by https://skia.googlesource.com/skia/+/1321a3d, which will be included in the next release.

Any idea when the next release would be? this info would be helpful to decide on what to do.

@amrosama2020 : Flutter has a new release version roughly every quarter (3 months). Our last one is around December so the next one should be around March.

I still have this problem with version 1.12.13+hotfix8,Can not be reproduced locally.
As @singun-lxd mentioned,#51447，I think they have the same problem.

cc @jason-simmons Any chance you can take a look at this one? Thanks!

@zsunkun, @WATER1350, @linxuebin1990,@Qxyat. Would you please provide a particular device model and its OS version so our team can look into this issue?

@jason-simmons @zoeyfan
device model:

os version:

Although the crash error is the same, it looks to me like this may have a different cause than the original bug filed here since this seems to be more OS specific as well as device specific.
I'm going to merge the continuation of this issue with #51447 and close this one.
@zsunkun I will reproduce your useful graphs in the other issue. Thanks!

Steps to Reproduce
This crash was happened on users' Android phone. I don't know clear steps to reproduce.
User starts the FlutterActivity then the APP crashes immediately.
Devices:

Huawei DUB AL00A
Huawei DUB AL00
Honor BKK AL10
Huawei ARS AL00
Huawei DUB AL20

Android version: Android 8.1.0,level 27
I noticed that they are all Huawei phones, and the EMUI version is 8.x, some of which using the Qualcomm Snapdragon processor.
updated at 2020-1-3
After investigating, I found the root cause was the skia attemping to use GL_QCOM_TILED_RENDERING on these phones. Ssee https://skia-review.googlesource.com/c/skia/+/246282/2. But something went wrong as the logcat said.
If you are troubling on this issue, you can try to roll back the skia revision and use your local compiled flutter engine, before the flutter team fixed this issue.
Logs

W libEGL : [eglGetProcAddress] QCOM code detected: glEndTilingQCOM ... Returning NULL
W libEGL : [eglGetProcAddress] QCOM code detected: glStartTilingQCOM ... Returning NULL
E flutter : [ERROR:flutter/shell/gpu/gpu_surface_gl.cc(70)] Failed to setup Skia Gr context.
W libEGL : [eglGetProcAddress] QCOM code detected: glEndTilingQCOM ... Returning NULL
W libEGL : [eglGetProcAddress] QCOM code detected: glStartTilingQCOM ... Returning NULL

main thread stack trace:
1 io.flutter.embedding.engine.FlutterJNI.nativeSurfaceCreated(Native Method)
2 io.flutter.embedding.engine.FlutterJNI.onSurfaceCreated(FlutterJNI.java:3)
3 io.flutter.embedding.engine.renderer.FlutterRenderer.startRenderingToSurface(FlutterRenderer.java:16)
4 io.flutter.embedding.android.FlutterSurfaceView.connectSurfaceToRenderer(FlutterSurfaceView.java:3)
5 io.flutter.embedding.android.FlutterSurfaceView.b(FlutterSurfaceView.java:1)
6 io.flutter.embedding.android.FlutterSurfaceView$a.surfaceCreated(FlutterSurfaceView.java:4)
7 android.view.SurfaceView.updateSurface(SurfaceView.java:728)
8 android.view.SurfaceView$2.onPreDraw(SurfaceView.java:151)
9 android.view.ViewTreeObserver.dispatchOnPreDraw(ViewTreeObserver.java:977)
10 android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2573)
11 android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1558)
12 android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7463)
13 android.view.Choreographer$CallbackRecord.run(Choreographer.java:1041)
14 android.view.Choreographer.doCallbacks(Choreographer.java:847)
15 android.view.Choreographer.doFrame(Choreographer.java:774)
16 android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1027)
17 android.os.Handler.handleCallback(Handler.java:809)
18 android.os.Handler.dispatchMessage(Handler.java:102)
19 android.os.Looper.loop(Looper.java:166)
20 android.app.ActivityThread.main(ActivityThread.java:7555)

1.gpu thread: signal SIGSEGV(SEGV_MAPERR)
#00 0x001682a8 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
flutter::Rasterizer::Setup(std::__1::unique_ptr<flutter::Surface, std::__1::default_delete<flutter::Surface> >)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/shell/common/rasterizer.cc:69:17
#01 0x0016ec67 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
flutter::Shell::OnPlatformViewCreated(std::__1::unique_ptr<flutter::Surface, std::__1::default_delete<flutter::Surface> >)::$_8::operator()()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/shell/common/shell.cc:566:23
auto fml::internal::CopyableLambda<flutter::Shell::OnPlatformViewCreated(std::__1::unique_ptr<flutter::Surface, std::__1::default_delete<flutter::Surface> >)::$_8>::operator()<>() const
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/make_copyable.h:24:0
#02 0x00146755 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
std::__1::function<void ()>::operator()() const
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/functional:2419:12
fml::MessageLoopImpl::FlushTasks(fml::FlushType)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop_impl.cc:123:0
fml::MessageLoopImpl::RunExpiredTasksNow()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop_impl.cc:133:0
#03 0x00148489 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::MessageLoopAndroid::OnEventFired()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:92:5
fml::MessageLoopAndroid::MessageLoopAndroid()::$_0::operator()(int, int, void*) const
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:42:0
fml::MessageLoopAndroid::MessageLoopAndroid()::$_0::__invoke(int, int, void*)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:40:0
#04 0x0000ff09 /system/lib/libutils.so (_ZN7android6Looper9pollInnerEi+580) [armeabi-v8::862798b286f1ba97372696549a8bea80]
#05 0x0000fc2d /system/lib/libutils.so (_ZN7android6Looper8pollOnceEiPiS1_PPv+32) [armeabi-v8::862798b286f1ba97372696549a8bea80]
#06 0x0000c9e1 /system/lib/libandroid.so (ALooper_pollOnce+56) [armeabi-v8::2f44f33bd999188a75f397fa44228d46]
#07 0x00148561 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::MessageLoopAndroid::Run()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:68:18
#08 0x00145adf /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::MessageLoopImpl::DoRun()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop_impl.cc:92:3
fml::MessageLoop::Run()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop.cc:49:0
#09 0x001474a1 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0::operator()() const
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/thread.cc:34:10
decltype(std::__1::forward<fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(fp)()) std::__1::__invoke<fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0&&)
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/type_traits:3530:0
void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>&, std::__1::__tuple_indices<>)
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/thread:341:0
void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0> >(void*)
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/thread:351:0
#10 0x000473eb /system/lib/libc.so (_ZL15__pthread_startPv+22) [armeabi-v8::c38cb0ea3187a942d434b91b139f1edd]
#11 0x0001ad29 /system/lib/libc.so (__start_thread+32) [armeabi-v8::c38cb0ea3187a942d434b91b139f1edd]

[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.14.6 18G2022, locale zh-Hans-CN)
    • Flutter version 1.12.13+hotfix.5 at /Users/wangyongrong/Library/flutter
    • Framework revision 27321ebbad (2 weeks ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/wangyongrong/Documents/Android-SDK
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/wangyongrong/Documents/Android-SDK
    • Java binary at: /Applications/Android Studio 2.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] VS Code (version 1.41.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.7.1

[✓] Connected device (1 available)
    • VOG AL10 • APH7N19329001298 • android-arm64 • Android 9 (API 28)

Steps to Reproduce
This crash was happened on users' Android phone. I don't know clear steps to reproduce.
User starts the FlutterActivity then the APP crashes immediately.
Devices:

Huawei DUB AL00A
Huawei DUB AL00
Honor BKK AL10
Huawei ARS AL00
Huawei DUB AL20

Android version: Android 8.1.0,level 27
I noticed that they are all Huawei phones, and the EMUI version is 8.x, some of which using the Qualcomm Snapdragon processor.
updated at 2020-1-3
After investigating, I found the root cause was the skia attemping to use GL_QCOM_TILED_RENDERING on these phones. Ssee https://skia-review.googlesource.com/c/skia/+/246282/2. But something went wrong as the logcat said.
If you are troubling on this issue, you can try to roll back the skia revision and use your local compiled flutter engine, before the flutter team fixed this issue.
Logs

W libEGL : [eglGetProcAddress] QCOM code detected: glEndTilingQCOM ... Returning NULL
W libEGL : [eglGetProcAddress] QCOM code detected: glStartTilingQCOM ... Returning NULL
E flutter : [ERROR:flutter/shell/gpu/gpu_surface_gl.cc(70)] Failed to setup Skia Gr context.
W libEGL : [eglGetProcAddress] QCOM code detected: glEndTilingQCOM ... Returning NULL
W libEGL : [eglGetProcAddress] QCOM code detected: glStartTilingQCOM ... Returning NULL

main thread stack trace:
1 io.flutter.embedding.engine.FlutterJNI.nativeSurfaceCreated(Native Method)
2 io.flutter.embedding.engine.FlutterJNI.onSurfaceCreated(FlutterJNI.java:3)
3 io.flutter.embedding.engine.renderer.FlutterRenderer.startRenderingToSurface(FlutterRenderer.java:16)
4 io.flutter.embedding.android.FlutterSurfaceView.connectSurfaceToRenderer(FlutterSurfaceView.java:3)
5 io.flutter.embedding.android.FlutterSurfaceView.b(FlutterSurfaceView.java:1)
6 io.flutter.embedding.android.FlutterSurfaceView$a.surfaceCreated(FlutterSurfaceView.java:4)
7 android.view.SurfaceView.updateSurface(SurfaceView.java:728)
8 android.view.SurfaceView$2.onPreDraw(SurfaceView.java:151)
9 android.view.ViewTreeObserver.dispatchOnPreDraw(ViewTreeObserver.java:977)
10 android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2573)
11 android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1558)
12 android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:7463)
13 android.view.Choreographer$CallbackRecord.run(Choreographer.java:1041)
14 android.view.Choreographer.doCallbacks(Choreographer.java:847)
15 android.view.Choreographer.doFrame(Choreographer.java:774)
16 android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1027)
17 android.os.Handler.handleCallback(Handler.java:809)
18 android.os.Handler.dispatchMessage(Handler.java:102)
19 android.os.Looper.loop(Looper.java:166)
20 android.app.ActivityThread.main(ActivityThread.java:7555)

1.gpu thread: signal SIGSEGV(SEGV_MAPERR)
#00 0x001682a8 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
flutter::Rasterizer::Setup(std::__1::unique_ptr<flutter::Surface, std::__1::default_delete<flutter::Surface> >)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/shell/common/rasterizer.cc:69:17
#01 0x0016ec67 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
flutter::Shell::OnPlatformViewCreated(std::__1::unique_ptr<flutter::Surface, std::__1::default_delete<flutter::Surface> >)::$_8::operator()()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/shell/common/shell.cc:566:23
auto fml::internal::CopyableLambda<flutter::Shell::OnPlatformViewCreated(std::__1::unique_ptr<flutter::Surface, std::__1::default_delete<flutter::Surface> >)::$_8>::operator()<>() const
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/make_copyable.h:24:0
#02 0x00146755 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
std::__1::function<void ()>::operator()() const
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/functional:2419:12
fml::MessageLoopImpl::FlushTasks(fml::FlushType)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop_impl.cc:123:0
fml::MessageLoopImpl::RunExpiredTasksNow()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop_impl.cc:133:0
#03 0x00148489 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::MessageLoopAndroid::OnEventFired()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:92:5
fml::MessageLoopAndroid::MessageLoopAndroid()::$_0::operator()(int, int, void*) const
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:42:0
fml::MessageLoopAndroid::MessageLoopAndroid()::$_0::__invoke(int, int, void*)
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:40:0
#04 0x0000ff09 /system/lib/libutils.so (_ZN7android6Looper9pollInnerEi+580) [armeabi-v8::862798b286f1ba97372696549a8bea80]
#05 0x0000fc2d /system/lib/libutils.so (_ZN7android6Looper8pollOnceEiPiS1_PPv+32) [armeabi-v8::862798b286f1ba97372696549a8bea80]
#06 0x0000c9e1 /system/lib/libandroid.so (ALooper_pollOnce+56) [armeabi-v8::2f44f33bd999188a75f397fa44228d46]
#07 0x00148561 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::MessageLoopAndroid::Run()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/platform/android/message_loop_android.cc:68:18
#08 0x00145adf /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::MessageLoopImpl::DoRun()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop_impl.cc:92:3
fml::MessageLoop::Run()
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/message_loop.cc:49:0
#09 0x001474a1 /data/app/com.bilibili.comic-UlhrVZRG20zydm5ToI41uw==/lib/arm/libflutter.so [armeabi-v7a::8d3ed6bbd864323d41970181b0b00b84]
fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0::operator()() const
/b/s/w/ir/cache/builder/src/out/android_release/../../flutter/fml/thread.cc:34:10
decltype(std::__1::forward<fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(fp)()) std::__1::__invoke<fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0&&)
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/type_traits:3530:0
void std::__1::__thread_execute<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>(std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0>&, std::__1::__tuple_indices<>)
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/thread:341:0
void* std::__1::__thread_proxy<std::__1::tuple<std::__1::unique_ptr<std::__1::__thread_struct, std::__1::default_delete<std::__1::__thread_struct> >, fml::Thread::Thread(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)::$_0> >(void*)
/b/s/w/ir/cache/builder/src/out/android_release/../../third_party/libcxx/include/thread:351:0
#10 0x000473eb /system/lib/libc.so (_ZL15__pthread_startPv+22) [armeabi-v8::c38cb0ea3187a942d434b91b139f1edd]
#11 0x0001ad29 /system/lib/libc.so (__start_thread+32) [armeabi-v8::c38cb0ea3187a942d434b91b139f1edd]

[✓] Flutter (Channel stable, v1.12.13+hotfix.5, on Mac OS X 10.14.6 18G2022, locale zh-Hans-CN)
    • Flutter version 1.12.13+hotfix.5 at /Users/wangyongrong/Library/flutter
    • Framework revision 27321ebbad (2 weeks ago), 2019-12-10 18:15:01 -0800
    • Engine revision 2994f7e1e6
    • Dart version 2.7.0

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/wangyongrong/Documents/Android-SDK
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/wangyongrong/Documents/Android-SDK
    • Java binary at: /Applications/Android Studio 2.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
    • All Android licenses accepted.

[✓] VS Code (version 1.41.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.7.1

[✓] Connected device (1 available)
    • VOG AL10 • APH7N19329001298 • android-arm64 • Android 9 (API 28)

@yrom  How to specify the local skia when compiling the engine?


No error raised when key is missing

Just started a new Rails (5.2) API app using Knock and copied some setup from an existing project. Couldn't get it to work, I got a TypeError (no implicit conversion of nil into String): from jwt (1.5.6) lib/jwt.rb:80:in 'digest'.
When my brain caught up I realised that I had not set a secret_key_base in config/secrets.yml. Adding one solved the problem but it would have been even better if Knock warned us if we are trying to run without keys :)
Thanks for a great gem.

I agree that it would be nice if the lib would check that it's not nil, I was similarly confused. Also, I think it's supposed to be Rails.application.secret_key_base, otherwise I'm pretty sure you'll wind up using the same key in dev and test as you do in prod.
We can see that it will choose a different value for test and dev, and will allow for environment vairable overriding in production, but then fall back to the credentials.secret_key_base suggested above:
https://github.com/rails/rails/blob/d7f48c9c39befaf23ccd63e0248a3bd5bf295ee5/railties/lib/rails/application.rb#L428-L436


Add link for Korean translation docs

#931
Even though translation repository can become outdated quite fast, we're gonna keep tracking and translating.
Thank you for translators and contributors 👍

Thanks!


Fix bash variable input

This will cause error in validation however it actually works..
I have tried with different versions to this without success in the addon:
if ! msg="$(tdtool --"$input")"; then
if ! msg="$(tdtool --"${input}")"; then
It passes the data sent via addon_stdio but something is parsed wrong when it is executing the command and tdtool exits with invalid input error.
The only one i got working in real life is these two:
if ! msg="$(tdtool --$input)"; then
if ! msg="$(tdtool --${input})"; then

Use this: https://github.com/home-assistant/hassio-addons/blob/master/rpc_shutdown/run.sh#L11
Data from Home-Assistant comes as json formated.