Ongoing OAuth Bug Tracking

I'm looking to get a census of users ability to connect via OAuth
If you use or have tried to use OAuth and see this bug, please reply with the following:
Cloud: <AWS|Azure|GCP>
Mechanism: <M2M|U2M with default app|U2M with custom app>
Success/Failure:
dbt version:
Last date you tried to connect with OAuth:

There's 18 of us on our team, and being able to login with oauthu2m via browser or using a profile from the ~/.databrickscfg file used by the CLI would make development so much easier. Especially because we use dbt clone to create instances of our data to dev against, so we pull state from dbfs as part of that (databricks fs cp dbfs://path/to/manifest.json local/path/to/manifest.json).
Cloud

AWS

Mechanism

U2M with default app maybe? I just omit the secrets and it redirects me to the browser.

Failure:

URL https://dbc-REDACTED.cloud.databricks.com/oidc/v1/authorize?response_type=code&client_id=dbt-databricks&redirect_uri=http%3A%2F%2Flocalhost%3A8020&scope=all-apis+offline_access&state=REDACTED&code_challenge=REDACTED&code_challenge_method=S256
Response from URL:
{
   "error_description": "redirect_uri 'http:localhost:8020' not registered for OAuth application 'dbt-databricks'",
   "error": "invalid_request"
}

dbt version:

 % dbt --version
Core:
  - installed: 1.7.11
  - latest:    1.7.11 - Up to date!

Plugins:
  - databricks: 1.7.13 - Up to date!
  - spark:      1.7.1  - Up to date!

Last date you tried to connect with OAuth:
Sat Apr 13 06:46:34 BST 2024

Cloud: Azure
Mechanism: Tried both U2M with default app as well as U2M with custom app
Success/Failure: Both failed with error message {"error_description":"OAuth application with client_id: 'XXX' not available in Databricks account 'XXX'.","error":"invalid_request"}
dbt version: core 1.7.11 and databricks plugin 1.7.13
Last date you tried to connect with OAuth: 2024-04-16T20:50:12Z

Thanks for the reports.  I merged a PR from @stevenayers-bge yesterday that in principle allows configuration of the other necessary piece (now both redirect url and scopes can be configured), unfortunately it does not fix the issue for Azure (where the Databricks SDK has the scopes hardcoded).  I'm working with the Databricks SDK team to get this unblocked, so thanks for the reports and patience.

We are bumping into the same issue. Previously (around 2024-04-08), when setting auth_type: oauth, and specifiying the azuread client id, we always got an AAD login screen (login.microsoftonline.net..), which redirected back to localhost and login was successful. The AAD app was set up as described here.
When a new user started using dbt yesterday, she gets redirected to the databricks oidc endpoint (looks like https://adb-xxxxxxxx.azuredatabricks.net/oidc/v1/authorize?response_type=code&client_id=<my_aad_client_id>&redirect_uri=http%3A%2F%2Flocalhost%3A8020&scope=2ff814a6-3304-4ab8-85cb-cd0e6f879c1d%2Fuser_impersonation+offline_access&state=xxxxxxx&code_challenge=xxxxxxx&code_challenge_method=S256.
She immediately sees the browser error:
{
    "error_description": "OAuth application with client_id: '<my_aad_client_id>' not available in Databricks account '<my_databricks_account>'.",
    "error": "invalid_request"
}

When I create an application at https://accounts.azuredatabricks.net/settings/app-integrations (with All APIs permission), and put that Client ID in the profiles.yml, sign-in works perfectly.
OS: Windows
relevant(?) python packages
dbt-core==1.7.14
dbt-databricks==1.7.14

At the same time, when I do it (windows, same packages), I get the AAD login screen and can login perfectly.

1 day later, I try do to it on the following machine
WSL (linux)
dbt-core==1.7.7
dbt-databricks==1.7.3

When supplying my AAD client app, the Databricks oidc endpoint opens up, with the same error message:
{
    "error_description": "OAuth application with client_id: '<my_aad_client_id>' not available in Databricks account '<my_databricks_account>'.",
    "error": "invalid_request"
}

Who/how is decided when to open the AAD url (login.microsoftonline.net), and why is it 'flaky'? I prefer using an AAD app as documented.
Let me know if I can provide extra information

@benc-db , ever since dbt-databricks 1.7.14 I get a warning in the terminal when the oAuth logic is not able to fetch a refresh token. This happens after an hour when the access token expires. A new browser tab is opened and a new token is fetched. I can connect just fine after that but the warning and the hourly browser popup is rather confusing. Before 1.7.14, an error during token refresh would end up in the logger.debug instead of logger.warning. So I would still get the browser popup but no warning in the terminal. This is the warning:
AADSTS9002326: Cross-origin token redemption is permitted only for the 'Single-Page Application' client-type. Request origin: 'http://localhost:8020'.

I want to get rid of the warning and the fact that it logs in every hour so I did a deep dive into what is going on.
Fix on databricks-sdk
We use azure with a custom app registration. This app registration is setup with the 'Mobile and desktop applications' authentication platform and 'http://localhost:8020' as the redirect url like it is documented here. This works fine for the first call (if there is no token stored yet). But after an hour, when the access_token expires, it tries to use the refresh_token to get a new token (like it should) but there it automatically sets the 'origin' header for oAuth on azure assuming it uses the SPA (Single-Page Application) authentication platform. As we do not use this, it throws the error above, causing the refresh to fail and the new tab to open.
I think this is bug/inconsistency in the SDK. I think it should first try it without setting the header and only set the header as a fall back just like it does when getting the authorization_code (first step of this oAuth flow). I am more then happy to create an issue and PR on the databricks-sdk repo and discuss this with them but then I saw the requirements.txt of dbt-databricks is pinned to databricks-sdk 0.17.0. So if they would accept my PR, it still would not solve my problem.
So my first question is: can dbt-databricks also use the latest databricks-sdk once released or is there a reason to pin it to 0.17.0?
Alternative
I also tried to solve this the other way around. Instead of using the 'Mobile and desktop applications' authentication platform for our app registration I changed this into the spa (Single-page application) platform. This solved part of the problem but not entirely. I get a valid token and after an hour it it is also refreshed without any errors or new login tabs so that is good. Unfortunately, a token for a spa platform is only valid for 24h after which you need to login again. I am fine with the new browser tab once every 24h but it also throws this error which now is printed on the terminal:
invalid_grant: AADSTS700084: The refresh token was issued to a single page app (SPA), and therefore has a fixed, limited lifetime of 1.00:00:00, which cannot be extended. It is now expired and a new sign in request must be sent by the SPA to the sign in page.

I would like to get rid of this warning as it can be confusing for our developers. Perhaps the dbt-databricks code could check for this exact error code (AADSTS700084) here. If that error code is thrown, it could do a logger.debug instead of logger.warning. I am more than happy to test this and create PR for it if you want to.
@benc-db, what do you think?

So my first question is: can dbt-databricks also use the latest databricks-sdk once released or is there a reason to pin it to 0.17.0?

We've been waiting for some needed changes in SDK to be able to update, most notably the fact that Azure scopes passed to the OAuth client were just ignored.

I'm looking to get a census of users ability to connect via OAuth
If you use or have tried to use OAuth and see this bug, please reply with the following:
Cloud: <AWS|Azure|GCP> Mechanism: <M2M|U2M with default app|U2M with custom app> Success/Failure: dbt version: Last date you tried to connect with OAuth:

Thanks for the info @benc-db. I think you are referring to this line of code in 0.17.0 where the scopes for azure are simply overwritten? In the latest version I don't see that line anymore and the scope can be set on the client.
I took the liberty of creating a PR for both solutions. One on databricks-sdk to solve the issue with non-spa app registrations and one on this repo to gracefully ignore the 'by design' error/notification for when the token can no longer be refreshed on a spa app registration. Hope you can look in to that last one.

This PR in databricks-sdk (https://github.com/databricks/databricks-sdk-py/pull/513) fixes a bug with Azure Databricks M2M OAuth, the fix is available since 0.18.0.
So, updating that dependency version is highly anticipated, we in Fivetran have customers complaining for related errors. Also, I can confirm that a custom build (dbt 1.7.3, dbt-databricks 1.7.2, databricks-sdk 0.28.0) works fine for those customers.

@fivetran-andreymogilev you say it fixed Azure M2M in 0.18, but the reason I set the pin at 0.17.0 is that it broke all of our tests, which use Azure M2M.  In what way did it fix?

For what it's worth, I have a branch where I'm testing 0.28.0, https://github.com/databricks/dbt-databricks/tree/auth_testing, if anyone wants to test out and report back.  I'm also talking to the owner of the SDK to work through the remaining issues.

@fivetran-andreymogilev Ahhh, so, I think what happened here is that the recommend Azure M2M flow changed after implementation.  So, what I've been working towards is using the client_secret from Azure, but I see the latest instructions say get an OAuth secret from Databricks.

@fivetran-andreymogilev thank you for sharing!  Your comment led to a breakthrough for me :P.

@benc-db The only working flow for M2M OAuth I tested is what described here: https://docs.databricks.com/en/dev-tools/auth/oauth-m2m.html. It uses client_id and client_secret obtained from Azure manually (e.g. during the principal creation). It is important to use Databrick's endpoint (https://accounts.cloud.databricks.com/oidc/accounts//v1/token) in this flow, and that is what was broken in 0.17.0

@benc-db Thank you, 0.28.0 seems a good choice for a dependency!


Align height of the pictures

Avoid duplicates

[x] This enhancement request has not already been raised before
[?] Enhancement request is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in CWA-Wishlist
[x] If you are proposing a new feature, please do so in CWA-Wishlist

Current Implementation

The pictures are not aligned on the same height

Suggested Enhancement

Align them on the same height.
Expected Benefits

Internal Tracking-ID: EXPOSUREAPP-8478)

Android (?) PR: https://github.com/corona-warn-app/cwa-app-android/pull/3740

Analysis: On both screens, the image and the two text elements are laid out in a vertical stack view, with an additional padding added to the top to prevent the image from slipping under the button or the navigation bar.
But: the Certificates screen is a table view controller on top level, whereas in the Check-Ins screen the table view controller is embedded in a TopBottomViewController. This results in a different height of the table view for the both screens.
Furthermore, the second text element is of variable length (especially in its localized variants), and has multiple lines. This results in a different height of the whole block.
Finally, the stack view is vertically centered on the table view. All this results in a crooked layout.
The layout should be top-aligned instead.

@ndegendogo Thanks. Your comment was mirrored into the internal ticket.

Analysing and documenting the layout as of current version for three screen sizes (iPhone 8, iPhone 13 mini, iPhone 13 Pro Max), all with simulator for iOS 15.0.
The EmptyStateView is used in the following table view controllers as background view for empty table:

DiaryDayViewController (contact diary single day view, both for People selection and for Places selection)
HealthCertificateOverviewViewController (tab Certificates, top level)
CheckinsOverviewViewController (tab Check In, top level)
TraceLocationsOverviewViewController (tab Status (Home) / plan event)
OnBehalfTraceLocationSelectionViewController (tab Status (Home) / plan event / menu Warn For Others)

Results see in below comments and videos

DiaryDayViewController:

the People selection layout is well aligned with the Places selection layout.
this layout differs significantly from the other mentioned layouts.

I see no need for alignment here.
iPhone 8:
https://user-images.githubusercontent.com/6118267/136658211-5b196ca3-4201-410c-94df-8ffc072e52e1.mp4
iPhone 13 mini:
https://user-images.githubusercontent.com/6118267/136658234-f74ed634-0cd8-4ed2-a9f7-97f851408355.mp4
iPhone 13 Pro Max:
https://user-images.githubusercontent.com/6118267/136658264-845c34f1-de65-4c25-bfb3-e080df9d40de.mp4

2) CheckinsOverviewViewController, TraceLocationsOverviewViewController and HealthCertificateOverviewViewController:

I can switch directly between those three with the tab buttons.
their layout is structured very similar.

These three should be aligned better.

3) OnBehalfTraceLocationSelectionViewController:
This screen is presented modally. The tab bar is not available.
No need for alignment with the other screens.

Same here @jucktnich, was this fixed with version 2.13?

Closing as fixed


Deprecation notice now appears at the top of the help text

This PR makes the deprecation notice appear at the beginning of the help text.

fixes #1791

Checklist:

[x] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[x] Run pre-commit hooks and fix any issues.
[x] Run pytest and tox, no tests failed.

This should update get_short_help_str as well.


Randomly getting amqp-client connection closed Socket closed after 48+ hours of connection establishment

I am randomly getting this amqp-client connection closed Socket closed
This socket has been ended by the other party after 2+ days of deployment every time. Is there any way to deal with it? Can't find events on connection to re-init it when closed. Can anyone suggest a way to deal with this?

Catch the exception and set up the connection again like the example on the readme?


Migrate project to eslint

Description
Because TSLint is deprecated since 2019 (https://blog.palantir.com/tslint-in-2019-1a144c2317a9?gi=f28749216f12), I migrated radash to eslint.
Checklist

[x] Changes are covered by tests if behavior has been changed or added
[x] Tests have 100% coverage
[ ] If code changes were made, the version in package.json has been bumped (matching semver)
[x] If code changes were made, the yarn build command has been run and to update the cdn directory
[x] If code changes were made, the documentation (in the /docs directory) has been updated

Hey @gquittet, we're using Biome for linting over at the Radashi fork. You're invited to come join us over there. We've made a lot of improvements already. 😄
P.S. You can read my post to learn more about the differences between Radashi and its predecessor.


Deal with date parsing slowdown

date(message.creationDate):todouble() takes a long time.
It doubles import time for LDBC 10.
Handle it in the c++ side by adding real datetime type or move date parsing to c++

Look at:
https://www.boost.org/doc/libs/1_78_0/doc/html/date_time/posix_time.html
https://stackoverflow.com/questions/26895428/how-do-i-parse-an-iso-8601-date-with-optional-milliseconds-to-a-struct-tm-in-c
https://www.boost.org/doc/libs/1_78_0/doc/html/date_time/examples.html#date_time.examples.dates_as_strings
https://en.cppreference.com/w/cpp/chrono/parse
https://howardhinnant.github.io/date/date.html
https://howardhinnant.github.io/date/tz.html#Examples
https://www.cplusplus.com/reference/ctime/strftime/

Done with the new internal date type.


gulp --cordova 'run android'

the command above launch:
Task 'android' is not in your gulpfile.
I'm using windows 10.

use " not ' on windows

@corentin-gautier is right. It's documented here: https://github.com/mwaylabs/generator-m-ionic/blob/master/docs/guides/windows.md


404 error when initial login is attempted

I've just compiled and installed ee3e4a38ee2acc6addd775ad52d577751593c986 as a fresh new user (uninstalled my very old version from when it was an official GitHub app). After attempting to log in from the start up screen, I enter my GitHub details and then get stuck on a GitHub 404 page. I can't proceed any further than this.
It looks to be server-side, but perhaps the app is requesting a page or API endpoint that no longer exists.
Tested on a Nexus 4, with 5.1.1.

Have you done this?:
https://github.com/pockethub/PocketHub#setup-environment

I...have brought great shame to my family. I missed that - I'll give it a go this evening. Would it make sense to introduce a compile error if the configuration values are not correctly set?

..and of course, it works. Sorry for the false alarm.

A compiler error would break all unit tests on travis, but i'm going to modify the build script to show a warning


Why under live preview, only one code cell is supported ?

Hi, greetings!
Not sure to call this an issue/bug, just as the title describes, when in live preview mode, different cells seem to be exactly isolated. Say: I import a library in the first cell, and run some inner method in the second cell, the second cell won't execute.
Can this be improved to be like the edit mode, aka, cells in the same file share one working jupyter kernel ?
Best regards !

This plugin currently uses the document id to decide whether to start a new kernel or reuse an existing one. It might be that document ids behave differently in live preview mode.


Pass through all the variables :/

Image processing wouldn't work if called off the main thread. Turns out calling this off the main thread isn't exactly common, unless you're using ASDK :)

:+1:


Clustering directed labelled graphs of different sizes

Is it possible to use these functions to conduct a clustering analysis, in labelled directed graphs of different sizes. For what I understand the functions require that the adjacency matrices have the same size. Thanks.

Thanks!


RxFragement for android.support.v4.app.Fragment

if I want to support V4 fragment, is there a wrap?

https://github.com/trello/RxLifecycle/blob/1.x/rxlifecycle-components/src/main/java/com/trello/rxlifecycle/components/support/RxFragment.java


add sudoers rules to README to support passwordless-provisioning

Automation should not be prevented by having to enter passwords. So i came up with sudoers rules.
on OS X. The location of the sudoers.d is a bit cumbersome but i guess the commands itself should be the same on many unices.
sudo visudo -f /private/etc/sudoers.d/vagrant

Cmnd_Alias VAGRANT_LANDRUSH_HOST_MKDIR = /bin/mkdir /etc/resolver/*
Cmnd_Alias VAGRANT_LANDRUSH_HOST_CP = /bin/cp /*/vagrant_landrush_host_config /etc/resolver/*
Cmnd_Alias VAGRANT_LANDRUSH_HOST_CHMOD = /bin/chmod 644 /etc/resolver/*

%admin ALL=(root) NOPASSWD: VAGRANT_LANDRUSH_HOST_MKDIR, VAGRANT_LANDRUSH_HOST_CP, VAGRANT_LANDRUSH_HOST_CHMOD

So what you are suggesting is to add something to the README, which suggest a manual sudoer config change, so that from then on onwards using Landrush will never ask for the root password again. Sounds reasonable. We might want to add a FAQ section to the README or maybe a Tip&Tricks section. Have you thought about where you want to put this? Maybe you want to create a pull request with the suggested changes?
That said, I am confused about the location of your sudoer config - /private/etc/sudoers.d/vagrant. This file does not even exist for me. What's about /etc/sudoers? Is that not the file to edit?

@hferentschik having sudoers adjusted i something i have done for quite some plugins

The location of the sudoers.d is a bit cumbersome but i guess the commands itself should be the same on many unices.
i was referring to osx, which i am using.
going to PR if my time allows which i doubt unfortunately. regards

Resolved by pull request #208


Improve Tests for storage

Reduced some errors. Didn't really improve success rate by much.

Can one of the admins verify this patch?

Codecov Report

:exclamation: No coverage uploaded for pull request base (storage-track2@4bf1e44). Click here to learn what that means.
The diff coverage is 100%.

@@                Coverage Diff                @@
##             storage-track2    #5605   +/-   ##
=================================================
  Coverage                  ?   48.39%
=================================================
  Files                     ?     6573
  Lines                     ?   192360
  Branches                  ?        0
=================================================
  Hits                      ?    93092
  Misses                    ?    99268
  Partials                  ?        0

Impacted Files
Coverage Δ

...torage-blob/azure/storage/blob/container_client.py
75.65% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bf1e44...bb9d7ae. Read the comment docs.


Check for certs available before triggering health checks

Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/1324
Description of changes:
Check for certs available before triggering health checks
Also improve health check logging a little bit by adding etcdcluster name to the logs
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

Awesome commit

Awesome commit

lol thanks 😂


Split preview generator into domain-specific sub-modules

Hi,
It would be nice to split the preview generator into sub-mobules, based on domains. By example, a CAD subdomain for XCF / autocad files, "images" for plain images, "office" for office documents...
Then, we could install some parts of preview-generator with:
pip install preview-generator[CAD,images]

Thanks !

👍 Will be great to have this.

This is partially done with #233


Add internal rules for testing

Follow-up to discussion in #7210
Moves integration tests from using rules that are transitively in nursery / preview groups to dedicated test rules that only exist during development. These rules always raise violations (they do not require specific file behavior).
Uses features instead of cfg(test) for cross-crate support per https://github.com/rust-lang/cargo/issues/8379

Need to filter the rules from the schema, probably by editing the proc macro.

Replaced by #9747


Live Tiles

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
No usage of Live tiles
What is the new behavior?

[x] Tiles should show number of Issues and PRs from new notifications
[x] Tiles should show total number of new notifications in Badges

Tiles should show content based on their size

[x] Small tiles should only show badges not notification
[x] Medium and Wide tiles should only show numbers in notification
[x] Large tiles should show detailed notification in addition to badges

Does this PR introduce a breaking change?
[x] Yes
[ ] No

Other information
Please don't merge until completed

@aalok05 time to merge. Please review


Tutorial convert html website

I see we both want to enhance this tutorial 😄
Here's my complete review.

@DirtyF  Thanks for the major review, I've found quite a few areas i'd like to change. Please provide access to your branch :smiley:


Create network policies for resources in kube-system ns of the Shoot

End users may deploy network policies which may break connectivity for vpn other system components living in the kube-system ns.

You could check #565, which is basically the same issue as this one.

Yes, let's close this one as a duplicate of #565


📃: Duck Hunt Game

Duck Hunt Game
Project Overview
Duck Hunt is a classic shooting game where players aim to hit flying ducks within a limited time. The objective is to shoot as many ducks as possible before time runs out, scoring points for each successful shot. Players must demonstrate quick reflexes and precision to maximize their score while enjoying a nostalgic gaming experience.
Key Features

Aiming & Shooting Mechanism: Players can aim their shots using a mouse or touch input and fire by clicking or tapping on the screen.
Score System: Points are awarded for each duck successfully hit, encouraging players to improve their aim and reaction time.
Time Limit: Players have a limited time to shoot as many ducks as possible, adding urgency and excitement to the game.
Sound Effects: Engaging audio feedback enhances the gameplay experience with sound effects for shooting and duck hits.
Levels of Difficulty: The game can feature multiple levels, each with increasing speed and frequency of duck appearances.

Tech Stack

HTML5: For the basic structure of the game.

A <canvas> element will be used to render the game graphics.

CSS3: To style the game interface, including layout, colors, and animations.

Responsive design to accommodate various screen sizes and devices.

JavaScript (ES6): For the core game logic and interactivity.

Game Mechanics: Implement functions for aiming and shooting, as well as updating the game state.
Rendering Engine: Draw ducks and game elements on the canvas.
Event Handling: Handle user inputs for aiming and shooting (mouse or touch events).
Game Loop: Create a main game loop to update the game state and render graphics at each frame.

Game Mechanics

Ducks: The game features animated ducks flying across the screen. Players shoot these ducks to score points.
Aiming & Shooting: Players aim their shot using a mouse or touch input and fire by clicking or tapping.
Score Tracking: Each successful hit increments the player's score. A scoreboard displays the current score and remaining time.
Time Management: Players have a limited time to shoot as many ducks as possible, with the game ending when the time runs out.

How to Build the Game

Set Up the Game Structure (HTML):

Use a <canvas> element for the game board.
Optionally add buttons for start/reset actions.

Style the Game (CSS):

Design a visually appealing and responsive interface.
Add styles for the game canvas, game-over screen, and any UI elements like the score display.

Implement Game Logic (JavaScript):

Create the game loop that will handle rendering and updating game elements.
Implement functions for duck spawning, aiming, shooting, and detecting hits.
Use event listeners for user inputs (aiming and shooting).
Implement scoring and display the final score at the end of the game.

Request for Tags
By presenting the Duck Hunt Game with this structure and technical depth, I would like to request the assignment of GCCOC-EXT and Level 3 tags for this project.
Additional Details
🔴 Title: Duck Hunt Game
🔴 Tech Stack: HTML5, CSS3, JavaScript (ES6)
🔴 Objective: Create a fun and engaging shooting game that tests players' reflexes and aiming skills.
🔴 Summary: Duck Hunt is a nostalgic shooting game where players aim to hit flying ducks within a time limit to score points.
Details to Include When Taking the Issue:
Name: Yeshwanth DS
Participant Role:  GSSOC, Hacktoberfest
By presenting the Duck Hunt Game with this structure and technical depth, I would like to request the assignment of GCCOC-EXT and Level 3 tags for this project.

hii @iamrahulmahato, I see this issue vacant from about a month, so can i work toward this issue pls? :)

@iamrahulmahato i built this game ready to raise a pr assign me this issue


KIC 2.0 - Deployment Manifests Roundup

As it relates to https://github.com/Kong/kubernetes-ingress-controller/issues/1215 the purpose of this issue is to ensure that we review and resolve any issues with the deployment manifests for all of our components, CRDs, and sample configurations.
Acceptance Criteria:

[ ] all deployment manifests for the controller manager and related components are functional and don't require cleanup
[ ] all manifests and related service accounts have proper RBAC roles associated, none of them use ClusterAdmin permissions
[ ] CRDs are deployable, and running make to generate them does not result in changes when no code changes occur
[ ] Samples are all functional, based on some of the integration test cases and do something meaningful as an example of API usage
[ ] CRD and RBAC resources are deployable using the the ~Helm chart~ Kustomize manifests. The Helm chart part is handled by #1209.

Similar to #1464

blocked by #1498

Some other things uncovered during my initial attempt:

[ ] the ServiceAccount in railgun/config/rbac/role_binding.yaml uses a different name than 1.x. Looks like this file was added manually and should be modified directly.
[ ] ditto leader_election_role_binding.yaml
[ ] 2.x patches should modify probes to use the new readyz endpoint.


Feature/950

#950

Ready for review in branch feature/950 at http://localhost:3030/table.
NOTE: This is ONLY the views shown on Zeplin, there is no responsive behavior.
The structure and CSS are not BEM compliant. This is intentional since table elements are unique and extra classes like tn-table__row and tn-table__data are redundant and can get tedious. This does increase the specificity but the trade-off in this case is worthwhile. The downside, however, is that these styles cannot be used outside of a table. If we have a use case where divs need to be styles as a table, we can circle back and add addt'l classes.

Restored branch to @LeoT7508  can review it. sorry got trigger happy again


Twemoji (js) v2.3 support

@JuanitoFatas How was the shortcodes supported by this gem decided?

@yantene Hi Shuhei, previously I dumped all the shortcodes used by Slack. We can look for unicode if they have something documented.

Can we get 2.7 support? I'd like to use the facepalm emoji


Socket address of closed socket should be null (support PHP 8)

Builds on top of #38 and https://github.com/reactphp/socket/pull/246

Temporarily force-pushed test to see if error suppression operators can be removed as per https://github.com/reactphp/socket/pull/246, but failing on legacy HHVM. I've restored the previous version already reviewed by @WyriHaximus (commit IDs are identical).


Normalize VersionPrefix

Leaving the version of Microsoft.AspNetCore.Buffering alone as I assume there's a reason it's 0.3.0 and not 2.0.0.

@ryanbrandenburg,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

:up::date:


Dualsense Instructions

Sorry I am quite a noobie.
Would there be any chance to add more detail instructions for the Dualsense calibration?
I seem to be able to see my controller with the script but center or range calibration does not seem to be making any difference.
My controller is on latest firmware and I installed Hall Effect sticks.

Thank you so much for this tool by the way!

Thank you! I know that python/zadig may be difficult to install. I'm working on a web-ui that calibrates the joystick without any installation (it just needs google chrome). Give it a try and let me know: https://the.al/dualshock/

Works great.
Both the scripts and the web ui app worked well for me on newest and slightly less new firmware.

Works amazingly!

Thank you!


Install docker-compose binary

Or maybe we should just redirect users to https://community.chocolatey.org/packages/docker-compose?

So, we need:

Install docker-compose V2 to C:\Program Files\Docker\cli-plugins\docker-compose.exe so it will be available as docker compose
Install compose-switch as docker-compose.exe on PATH. Switching between V1/V2 is done using docker-compose.exe enable-v2 and docker-compose.exe disable-v2
Install docker-compose V1 as docker-compose-v1.exe on PATH so that compose-switch can find it.

But. https://github.com/docker/compose-switch/pull/4 has dropped enable-v2/disable-v2 support.
So, we can to EITHER install compose-switch OR docker-compose V1 under docker-compose.exe on PATH. But we can't have all three (V1 + V2 + compose-switch) working.


<C-v> freezes nvim when pasting a large number of texts

Feature description
我macmini m2 上，配置好了，然后复制大量文本，cmd+c之后，进入具体问题， 打算进入cmd+v流程，但是就会多次卡死：
https://raw.githubusercontent.com/SlRvb/Obsidian--ITS-Theme/main/Snippets/S - Checkboxes.css
这个页面的内容是我复制的内容，但是我一旦粘贴进入，就很容易假死，
过程中，我可以看到nvim界面中，右下角出现的pasting 状态进度条，但最终还是假死，整个tab 编辑页面，不能用，
我也很是确定我的系统和软件还有终端环境是好的。
hope u reply ,and thks!
Additional information
No response

Try p in normal mode instead of command+v.

thanks , 'p' works so good !
and how can I upgrade nvimdot to newest with commands?

Just git pull origin main at ~/.config/nvim if you don't your custom configurations. Check release note of version 2.0.0 here otherwise.

thanks

@nevertoday Just a bit of background knowledge here (if you would like to know more):
If you use <C-v> to paste some texts, vim will not treat this as an instruction (if you use q to record what you did into a register, <C-v> will be ignored). Instead, vim will think that you are entering texts normally one by one. It will run all autocmds and perform most checks (such as adjusting text indentation) in the background. Those keymaps exist only to help users migrate more seamlessly to vim, but it is not intended to let users use them on a large scale. So if possible, try to use native commands instead of those "compatible commands" for better performance.

@nevertoday Just a bit of background here (if you would like to know more):
If you use <C-v> to paste some texts, vim will not treat this as an instruction (if you use q to record what you did into a register, <C-v> will be ignored). Instead, vim will think that you are entering texts normally one by one. It will run all autocmds and perform most checks (such as adjusting text indentation) in the background. Those keymaps exist only to help users migrate more seamlessly to vim, but it is not intended to let users use them on a large scale. So if possible, try to use native commands instead of those "compatible commands" for better performance.

Side note: I think this kind of educational infos are really valuable. @ayamir Would u mind me to create a wiki page to list out all gd issues?

Would u mind me to create a wiki page to list out all gd issues? Since github issue can only pin 3 issues at most.

Wonderful idea. I'm glad to see it! 👍


fix(icons): changed list-todo icon

What is the purpose of this pull request?

[x] Other: Icon update

Description
Moved up checkbox to have the same center as the list-checks check mark.
Before Submitting

[x] I've read the Contribution Guidelines.
[ ] I've checked if there was an existing PR that solves the same issue.

We could also use a 7x7 square instead of the 6x6 square, that way it would be consistent with the layout-* icons.
Open lucide studio

Hmm, it feels not very balanced 🤔

Hmm, it feels not very balanced 🤔

What about the 7x7 version?


Go:build k-v database

Build a simgple k-v database with Golang.
Description
Go:Build a simgple k-v database with Golang.
Motivation and Context
Based on LSM tree, vert simple and easy.
How Has This Been Tested?
Checklist:

[x] My code follows the code style of this project.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have made checks to ensure URLs and other resources are valid

https://github.com/roseduan/rosedb

Please resolv conflicts.

Can you link to the tutorial directly?


Added temperature (apparent) high/low, deprecated max/min

Description:
Dark Sky API has deprecated temperatureMin, temperatureMax, apparentTemperatureMin, and apparentTemperatureMax. I added 4 new temperature fields that are the replacements (high/low) and added a check for the old values and log a warning message that they are deprecated.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#4613
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: darksky
    api_key: YOUR_API_KEY
    monitored_conditions:
      - summary
      - temperature_low
      - temperature_high

Checklist:

[x] The code change is tested and works locally.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

We don't interact with the Dark Sky API directly, we use python-forecastio. All API changes need to be addressed in python-forecastio. I assume that if you add temperature_low and temperature_high they will stay always empty because the data is not available.

python-forecastio basically fetches a json object, provides easy access to various parts of the json object (daily, hourly, etc...) and you query it with whatever key you want. If Darksky adds or removes a json field to the daily data then python-forecastio needs no adjustments.
So, should we not notify the users of HA that _min and _max are deprecated? Eventually they may disappear with no warning and no required update by python-forecastio.
the new temperature_high and temperature_low fields work fine (ignoring the bug I had in the code I submitted, the future days worked, just not day 0).

Note, this changes the naming of the monitored conditions, so IMHO it is a breaking change as well.

This change seems fine. Marked it as a breaking change. It technically is not but it will be good to include why some types have been marked as deprecated and what the alternative is.
Ok to merge when merge conflict resolved.


HTTP ExtAuthZ filter is not being used if there are no route match on the initial request

Title: HTTP ExtAuthZ filter is not being used if there are no route match on the initial request
Description:
We are using ExtAuthZ in order to modify some of the incoming request headers.
The routing decision is then made based on those modified headers. (By using the ExtAuthZ "clear_route_cache": true, option). In the example config below, that header is New-Routing-Header
We realized that the HTTP Router would directly return a 404 without going through ExtAuthZ if the initial request doesn't have a route match.
By design, the initial request does not have a match since we route on a modified ExtAuthZ header.
To remediate this, we added a final wildcard artificial match on our routes. That forced the initial request to go through ExtAuthZ in all cases.
If this is expected, I could not find this anywhere in the doc. My understanding is that HTTP Filters would be applied in the order they appear, with the envoy.filters.http.router being the last one?
If this is not expected, probably a corner-case worth investigating/solving?
Repro steps:
Below config with or without a Wildcard match
Config:
This is configured/managed through Istio, but we modify/change the config heavily as well.
HCM:
         "filter_chain_match": {
          "server_names": [
           "*.api.playground.mydomain.com"
          ]
         },
         "filters": [
[...]
          {
           "name": "envoy.filters.network.http_connection_manager",
           "typed_config": {
            "@type": "type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager",
            "stat_prefix": "outbound_<IP_ADDRESS>_443",
            "rds": {
             "config_source": {
              "ads": {},
              "initial_fetch_timeout": "0s",
              "resource_api_version": "V3"
             },
             "route_config_name": "myRoute"
            },
            "http_filters": [
[....]
             {
              "name": "envoy.ext_authz",
              "typed_config": {
               "@type": "type.googleapis.com/envoy.extensions.filters.http.ext_authz.v3.ExtAuthz",
               "grpc_service": {
                "envoy_grpc": {
                 "cluster_name": "extAuthZProxyBootstrap"
                },
                "timeout": "5s"
               },
               "clear_route_cache": true,
               "status_on_error": {
                "code": "ServiceUnavailable"
               },
               "transport_api_version": "V3"
              }
             },
             {
              "name": "envoy.filters.http.router",
              "typed_config": {
               "@type": "type.googleapis.com/envoy.extensions.filters.http.router.v3.Router"
              }
             }
            ],

Routes without the wildcard :
   {
     "route_config": {
      "@type": "type.googleapis.com/envoy.config.route.v3.RouteConfiguration",
      "name": "myRoute",
      "virtual_hosts": [
       {
        "name": "*.api.playground.mydomain.com:443",
        "domains": [
         "*.api.playground.mydomain.com"
        ],
        "routes": [
         {
          "match": {
           "prefix": "/",
           "case_sensitive": true,
           "headers": [
            {
             "name": "New-Routing-Header",
             "string_match": {
              "safe_regex": {
               "regex": "^/system/v2alpha1$"
              }
             }
            },
            {
             "name": ":method",
             "string_match": {
              "safe_regex": {
               "regex": "GET|POST"
              }
             }
            }
           ]
          },
          "route": {
           "cluster": "cluster",
           "timeout": "0s",
           "retry_policy": {
            "retry_on": "connect-failure,refused-stream,unavailable,cancelled,retriable-status-codes",
            "num_retries": 2,

         },
[...]

Logs:

Without a Wildcard in the routes:

[2024-01-30T22:44:18.928Z] "GET /v1/noauth HTTP/2" 404 NR route_not_found - "-" 0 0 0 - curl/7.81.0" "fb6b8113-014b-9336-8055-33c74b8c41a3" "-" "df.api.playground.mydomain.com" "-" - -  [...] df.api.playground.mydomain.com - "-" "-"

I enabled full Envoy debug mode, and no requests are being sent to ExtAuthz

With a Wildcard in the routes:

In Debug mode, now the request goes as expected through ExtAuthZ first, the routing is then done through the extra header as expected.
[2024-01-30T23:51:02.627Z] "GET /v1/noauth HTTP/2" 200 - via_upstream - "-" 0 859 42 6 "curl/7.81.0" "85098402-376b-956e-8883-809b1e511924" "-" "df.api.playground.mydomain.com" "" [...] df.api.playground.mydomain.com - "" "-"

cc  @esmet @tyxia @ggreenway

Hi @esmet , @ggreenway and @tyxia . Happy to help document this better or investigate more or issue a PR/Fix for this if you let me know if this works as intended or if I hit a corner/case or bug. Thanks!

no stalebot

From your description it sounds like the filter chain isn't being iterated at all when there's no route match. I'm not sure why that is. @yanavlasov or @alyssawilk do you know why that would be, and/or if it's documented somewhere?

If there's no route match, envoy will send a local reply.  Any time Envoy sends a local reply it stops processing the request filter chain and switches to running response filters.  So yeah, I'd expect if we failed an initial route match we wouldn't ever hit a decoder filter.


/p does not show the UI interface

Issue description

Expected result: Use /p to display the UI interface
Actual result: Displays the list of commands on page 1.

Steps to reproduce the issue

Use /p
See the error

OS and versions

Plugin Version: dev805
PocketMine-MP: 4.2.3
PHP: 8.0.16
Using JIT: no
Server OS: linux
Game version: Win10

Other Plugins

Plugins (14): BedrockEconomy v2.0.7, BuilderTools v1.4.0-dev, DevTools v1.15.0, FormAPI v2.1.0, KygekPingTPS v2.0.0, MultiWorld v1.7.0-beta4, MyPlot v2.1.0, PureChat v2.0.1, PurePerms v2.0.2, PurePermsScore v2.0.0, RedstoneCircuit v3.0.3, ScoreHud v7.0.0, SimpleNPC v3.0.1, Worlds v3.1.0

If you remove all other plugins, does the issue still occur? I cannot test
If the issue is not reproducible without other plugins:

Have you asked for help in the community discord before creating an issue?
Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section.

Crashdump, backtrace or other files

see what error? It works for me

see what error? It works for me

https://streamable.com/xbchnz


Workflow test

Seems it works fine with Pandapower backend. Should I try to switch OS to Windows and run on PSSE?

Nice work!


Pipeline MTA cloud tool version causing API to fail

Do you want to request a feature or report a bug?

Please search existing issues to avoid creating duplicates. https://github.com/SAP/cloud-mta-build-tool/releases.
Also please test using the latest version build to make sure your issue has not already been fixed:
We are using mta-version 'latest' in our .xmake config file in pipeline.

Please provide the following info:

MBT Version:Cloud MTA Build Tool version 1.0.10
OS Version:
If possible, provide a link to the project.
https://github.wdf.sap.corp/CSI/outbound/blob/master/.xmake.cfg

Steps to Reproduce:
We were initially have the same issue during manual deployment. The MTA cloud tool was not packaging the servicecds.xml file properly and after deployment the API were failing.
We were able to resolve this by locally installing the latest version of MTA cloud tool 1.0.10.
We now know the latest version of MTA cloud tool is building MTAR properly and fixing our API, but the pipeline is not using the same and on deployment the API fails again.
We have already set mta-version to latest in our pipeline xmake config.
https://github.wdf.sap.corp/CSI/outbound/blob/master/.xmake.cfg
Can you please check how we can consume the latest mta cloud tool version for our pipeline , so we can fix the issue?

Hi,
You are trying to build your project from internal SAP xMake build system.
Please open a bug in the relevant xMake plugin.
Regards,
Michal


[Feature-4428][dao、UI] It is recommended to add an owner in the data source center and the Resource Center to make it easier to manage

What is the purpose of the pull request
fixed issue #4428
this closes #4428
Brief change log

*dao module modify  DataSourceMapper.xml and ResourceMapper.xml *
UI module add username and add userName in il8n

Verify this pull request

thanks for your first contribution, looking forward to your deep participation

thanks for your first contribution, looking forward to your deep participation


Change default port in the Golang flagD Provider

https://github.com/open-feature/golang-sdk-contrib/pull/9


End2end Transformer Training by Using Ragged Tensor

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template
System information

TensorFlow version (tf nightly):
Are you willing to contribute it (Yes/No): Yes

Describe the feature and the current behavior/state.
I'd like to write a transformer model by end2end using Ragged Tensor to speed up training. However, I found that there're some ops that Ragged Tensor could not support, ex. matmul, relu.  Do you have plan to support the other tf ops for Ragged Tensor?
In general, there are two kinds of ops to support:

Ragged Tensor op could reuse the kernel written for regular tensor. ex. relu
Ragged Tensor op could not reuse the kernel written for regular tensor. ex. logits = tf.einsum("BTNH,BFNH->BNFT", key, query), where dimension F and T are ragged.

Will this change the current api? How? No.
Who will benefit with this feature?
Those models with batches of variable-length sequential inputs, ex. Transformer.
Any Other info.

Additionally, there is a ragged op that is needed to do positional encoding and does't exist.
Basically what I'm looking for is the option to chop a dense tensor to the shape of a ragged one and apply an op such as '+'.
Example:
text: "Google is nice"
embedded_text: [[1.1,2.2],[3.3,4.4],[5.5,6.6]] #ragged tensor after text embedding, <hidden_size=2, text_length=3>
positional_encoding_matrix: [[0.0,1.0],[0.1,0.2],[0.5,0.6],[0.8,0.2],[0.4,0.9]]] #<hidden_size=2, max_text_length=5>
wanted_function(embedded_text,positional_encoding_matrix,'+'):
  step1: chops the second input to the shape of the ragged tensor, [[0.0,1.0],[0.1,0.2],[0.5,0.6],[0.8,0.2],[0.4,0.9]]]=>[[0.0,1.0],[0.1,0.2],[0.5,0.6]]
  step2: apply the '+' op on the equally shaped ragged tensors and return the result

This would enable us to use the Transformer model without adding padding vectors (and the attention masks that come with it).
I'm starting to work on a version of a ragged transformer now but I still don't see a way to write the above function efficiently without help from the TF team.

https://github.com/tensorflow/community/pull/260 might be relevant.

@yaochengji For elementwise functions such as relu, you can just use tf.ragged.map_flat_values.  E.g.:
x = tf.ragged.constant([[-3.0, 2.0], [3.0]])
tf.ragged.map_flat_values(tf.nn.relu, x)

Adding ragged support to tf.einsum would be more complicated; any contributions are welcome.
@ARozental You can chop a dense tensor to the shape of a ragged one with something like this:
def chop_dense_to_ragged(dense, ragged):
  mask = ragged.with_flat_values(tf.ones([tf.shape(ragged.flat_values)[0]], tf.bool))
  mask = mask.to_tensor(shape=tf.shape(dense)[:tf.rank(mask)])
  return tf.ragged.boolean_mask(dense, mask)

d = tf.reshape(tf.range(12), [3, 4])
r = tf.ragged.constant([[1, 2], [3], [4, 5, 6]])
print(chop_dense_to_ragged(d, r))
# prints <tf.RaggedTensor [[0, 1], [4], [8, 9, 10]]>
print(r + chop_dense_to_ragged(d, r))
# prints <tf.RaggedTensor [[1, 3], [7], [12, 14, 16]]>


[HIVEMALL-189] Create a list of all functions

What changes were proposed in this pull request?
Create a list of all functions in the documentation. In order to make maintenance easier and simpler, the list is systematically generated by reading @Description annotation in the code: takuti/hivemalldoc.
In case this list does not look sufficient, let's update @Description annotation itself and make the code more informative in the future.
What type of PR is it?
Documentation
What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-189

@takuti I think it's better to have hivemalldoc module (e.g., tools/hivemalldoc )
Hadoop tools.
https://github.com/apache/hadoop/tree/trunk/hadoop-tools
Here is tips to include Gradle module.
https://stackoverflow.com/questions/40352951/include-gradle-module-to-maven-project


[BUG] koordlet failed to collect CPU/memory info from cgroup fs

What happened: koordlet failed to collect CPU/memory info from cgroup fs
What you expected to happen:  Koordlet can collect info from cgroup
How to reproduce it (as minimally and precisely as possible):

Install koordinator:  helm install koordinator koordinator-sh/koordinator --version 0.7;
Check koodlet logs.

Environment:

App version: 0.7.0
Kubernetes version (use kubectl version): Kubernetes v1.25.2
Install details (e.g. helm install args):  0.7.0
Containerd:  containerd.io 1.6.8
Kernel 5.10.18 + cgroup v1

/area koordlet

cgroup v2 has not support yet, we will update this issue if this is updates, any comments is welcomed.
https://github.com/koordinator-sh/koordinator/issues/407

More log updated:  collect container kube-system/coredns-565d847f94-ksdgk/coredns cpu throttled failed, err open /host-cgroup/cpu/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice/cri-containerd-95f5f3fbc401447ebe9b25ba6be81be590995283f219e3ad469fb3bcc17a328b.scope/cpu.stat: no such file or directory.
Then file /sys/fs/cgroup/cpu/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice/cpu.stat can ben opened.

The correct cgoup file in my system is below:
[root@cpu]#  find . -name 3089d7a8
./system.slice/containerd.service/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice:cri-containerd:95f5f3fbc401447ebe9b25ba6be81be590995283f219e3ad469fb3bcc17a328b
./system.slice/containerd.service/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice:cri-containerd:2db2b26bb62261d56c6867e0f5734a1d0c6d609783add0e018627263b2ef2e68
./kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice

The correct cgoup file in my system is below: [root@cpu]# find . -name 3089d7a8 ./system.slice/containerd.service/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice:cri-containerd:95f5f3fbc401447ebe9b25ba6be81be590995283f219e3ad469fb3bcc17a328b ./system.slice/containerd.service/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice:cri-containerd:2db2b26bb62261d56c6867e0f5734a1d0c6d609783add0e018627263b2ef2e68 ./kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice

could please show us the sub-paths of the pod cgroup?
e.g.
$ tree /sys/fs/cgroup/cpu/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice/

The correct cgoup file in my system is below: [root@cpu]# find . -name 3089d7a8 ./system.slice/containerd.service/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice:cri-containerd:95f5f3fbc401447ebe9b25ba6be81be590995283f219e3ad469fb3bcc17a328b ./system.slice/containerd.service/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice:cri-containerd:2db2b26bb62261d56c6867e0f5734a1d0c6d609783add0e018627263b2ef2e68 ./kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice

@vivianzh could please show us the sub-directories of the pod cgroup?
e.g.
$ tree /sys/fs/cgroup/cpu/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice/

[root@aee-icx ~]# tree /sys/fs/cgroup/cpu/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice/
/sys/fs/cgroup/cpu/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-pod3089d7a8_a983_4649_9088_39efe764e4b4.slice/
├── cgroup.clone_children
├── cgroup.procs
├── cpuacct.stat
├── cpuacct.usage
├── cpuacct.usage_all
├── cpuacct.usage_percpu
├── cpuacct.usage_percpu_sys
├── cpuacct.usage_percpu_user
├── cpuacct.usage_sys
├── cpuacct.usage_user
├── cpu.cfs_period_us
├── cpu.cfs_quota_us
├── cpu.core_group_cookie
├── cpu.core_tag
├── cpu.rt_period_us
├── cpu.rt_runtime_us
├── cpu.shares
├── cpu.stat
├── notify_on_release
└── tasks

@vivianzh It is strange that no container cgroup exists under the pod cgroup path. Which kind of container runtime is in use? (runc, kata-runtime, etc.)

@vivianzh It is strange that no container cgroup exists under the pod cgroup path. Which kind of container runtime is in use? (runc, kata-runtime, etc.)

Runc

how about the version of operate system, ubuntu, centos?

how about the version of operate system, ubuntu, centos?

Centos8

emm.. this seems a little weird. the cgorup dir of container and pod are. totally different.
have you ever changed the config of kubelet, for example the --runtime-cgroups.
it will be better if you can show the kubelet config and args.

emm.. this seems a little weird. the cgorup dir of container and pod are totally different. have you ever changed the config of kubelet, for example the --runtime-cgroups. it will be better if you can show the kubelet config and args.

I didn't add any cgroup related configs.
/usr/bin/kubelet --bootstrap-kubeconfig=/etc/kubernetes/bootstrap-kubelet.conf --kubeconfig=/etc/kubernetes/kubelet.conf --config=/var/lib/kubelet/config.yaml --container-runtime=remote --container-runtime-endpoint=unix:///var/run/containerd/containerd.sock --pod-infra-container-image=registry.k8s.io/pause:3.8
#cat /var/lib/kubelet/config.yaml
apiVersion: kubelet.config.k8s.io/v1beta1
authentication:
anonymous:
enabled: false
webhook:
cacheTTL: 0s
enabled: true
x509:
clientCAFile: /etc/kubernetes/pki/ca.crt
authorization:
mode: Webhook
webhook:
cacheAuthorizedTTL: 0s
cacheUnauthorizedTTL: 0s
cgroupDriver: cgroupfs
clusterDNS:

<IP_ADDRESS>
clusterDomain: cluster.local
cpuManagerReconcilePeriod: 0s
evictionPressureTransitionPeriod: 0s
fileCheckFrequency: 0s
healthzBindAddress: <IP_ADDRESS>
healthzPort: 10248
httpCheckFrequency: 0s
imageMinimumGCAge: 0s
kind: KubeletConfiguration
logging:
flushFrequency: 0
options:
json:
infoBufferSize: "0"
verbosity: 0
memorySwap: {}
nodeStatusReportFrequency: 0s
nodeStatusUpdateFrequency: 0s
rotateCertificates: true
runtimeRequestTimeout: 0s
shutdownGracePeriod: 0s
shutdownGracePeriodCriticalPods: 0s
staticPodPath: /etc/kubernetes/manifests
streamingConnectionIdleTimeout: 0s
syncFrequency: 0s
volumeStatsAggPeriod: 0s

@vivianzh Could you please show the container statuses of the pod? There may be no container-level cgroup for a non-running container.

[root@aee-icx kubepods.slice]# kubectl get pods ffmpeg-convert-mp4-job1 -o yaml | grep container
containers:
containerStatuses:

containerID: containerd://567952f476105ab4e9ac8a1007529be868f15d135a09dca897944cbe2ba019f3

Any update for this issue?

@vivianzh Container-level cgroups in your node are under /system.slice/containerd.service, while koordlet supposes they should be under /kubepods.slice/kubepods-podxxxxx.slice/. It seems a misconfiguration problem of containerd cgroup driver. Please check if the cgroup driver configurations of both containerd and kubelet are correct.

@vivianzh Container-level cgroups in your node are under /system.slice/containerd.service, while koordlet supposes they should be under /kubepods.slice/kubepods-podxxxxx.slice/. It seems a misconfiguration problem of containerd cgroup driver. Please check if the cgroup driver configurations of both containerd and kubelet are correct.
I have double checked cgroup driver configurations, no issues are found. This is my output of "systemctl statu containerd":
● containerd.service - containerd container runtime
Loaded: loaded (/etc/systemd/system/containerd.service; disabled; vendor preset: disabled)
Drop-In: /etc/systemd/system/containerd.service.d
└─proxy.conf
Active: active (running)
Docs: https://containerd.io
Main PID: 23097 (containerd)
Tasks: 22
Memory: 118.0M
CGroup: /system.slice/containerd.service

Is the output "CGroup: /system.slice/containerd.service" correct here? Could you share your correct output of containerd and i can find more clues.

@vivianzh Container-level cgroups in your node are under /system.slice/containerd.service, while koordlet supposes they should be under /kubepods.slice/kubepods-podxxxxx.slice/. It seems a misconfiguration problem of containerd cgroup driver. Please check if the cgroup driver configurations of both containerd and kubelet are correct.
I have double checked cgroup driver configurations, no issues are found. This is my output of "systemctl statu containerd":
● containerd.service - containerd container runtime
Loaded: loaded (/etc/systemd/system/containerd.service; disabled; vendor preset: disabled)
Drop-In: /etc/systemd/system/containerd.service.d
└─proxy.conf
Active: active (running)
Docs: https://containerd.io
Main PID: 23097 (containerd)
Tasks: 22
Memory: 118.0M
CGroup: /system.slice/containerd.service

Is the output "CGroup: /system.slice/containerd.service" correct here? Could you share your correct output of containerd and i can find more clues.

I think it is incorrect. I'm not sure if the kubelet also considers this pattern of cgroup paths abnormal.


Add new game ping pong game

Add new game ping pong game

@Spandan-Bhattacharya  pls Assign me under SWOC

How will this game be?

User vs Computer

it is clear then assign me

@Spandan-Bhattacharya  check this


SessionDetails UI touch up #895

Here's my first contribution (ever) 😁
What's changed

The Speakers header matches the screen's width
Added some spacing above the header

Closes #895

Thanks for making those changes.....definitely looks better!

@sophicapri just to also let you know we have a #confetti channel in kotlinlang slack in case you want to drop by!

@sophicapri just to also let you know we have a #confetti channel in kotlinlang slack in case you want to drop by!

@joreilly thanks for letting me know, i'll join in !


Any plans to upgrade dependency versions?

Description of your issue
Need to update packages in composer.json to latest versions, especially Wordpress and subsequently the plugins themselves. Packages are currently locked to specific versions. Ran composer update using latest version of composer.phar produces dependency warnings.
Steps to Reproduce
Just try to do a composer update using v2 of composer. Warnings should appear.
Other Information
Git Commit/Version:  latest
Any suggestions? Thanks!

I have the same issues. I try to update composer.json but without success

Same issue here. Dependencies are expecting Composer 1.0.0 but Composer is past 2.0.0 now.

Same issue here. Dependencies are expecting Composer 1.0.0 but Composer is past 2.0.0 now. Tried dropping down to Composer 1.0.0 and tried again but then I get this error.

try composer version 1.5

Composer 1.6.3 is the oldest I can rollback to and it doesn't seem to work

Composer 1.6.3 is the oldest I can rollback to and it doesn't seem to work

I've had the same issue when trying to install a plugin from WP. Doing the following worked for me.
composer self-update 1.10.22 rm -rf vendor composer require wpackagist-plugin/<plugin-name>
or replace composer require <plugin> with composer install.

If you want to update the WordPress version first roll-back your composer (if you have Composer 2) following the instructions below and  composer require johnpbloch/wordpress:5.8.1 johnpbloch/wordpress-core:5.8.1 to update your WordPress.
You can change to any specific version you want by editing 5.8.1 numbers.


NGINX ingress controller annotation changes

As per https://github.com/kubernetes/ingress-nginx/releases/tag/nginx-0.9.0-beta.18, the NGINX ingress controller will use the prefix "nginx.ingress.kubernetes.io" instead of "kubernetes.io" for "kubernetes.io/ingress.class".
See line https://github.com/jetstack/kube-lego/blob/784fc8fef5703665bd5f20ff65922ee038e09a95/pkg/kubelego_const/consts.go#L20

@DavidRouyer the change in the prefix does not applies to the ingress.class annotation. This would break compatibility with other ingress controllers. I added a note about that in the release notes.

@aledbf yeah, it bugs me a lot. So maybe there is a bug with the new ingress controller? I've a shiny new Kubernetes cluster and I've declared my ingress controller like that:
apiVersion: extensions/v1beta1
kind: Deployment
metadata:
  name: nginx-ingress-controller
  labels:
    k8s-app: nginx-ingress-controller
  namespace: kube-system
spec:
  replicas: 1
  template:
    metadata:
      labels:
        k8s-app: nginx-ingress-controller
      annotations:
        prometheus.io/port: '10254'
        prometheus.io/scrape: 'true'
    spec:
      # hostNetwork makes it possible to use ipv6 and to preserve the source IP correctly regardless of docker configuration
      # however, it is not a hard dependency of the nginx-ingress-controller itself and it may cause issues if port 10254 already is taken on the host
      # that said, since hostPort is broken on CNI (https://github.com/kubernetes/kubernetes/issues/31307) we have to use hostNetwork where CNI is used
      # like with kubeadm
      # hostNetwork: true
      terminationGracePeriodSeconds: 60
      containers:
      - image: quay.io/kubernetes-ingress-controller/nginx-ingress-controller:0.9.0-beta.18
        name: nginx-ingress-controller
        imagePullPolicy: Always
        readinessProbe:
          httpGet:
            path: /healthz
            port: 10254
            scheme: HTTP
        livenessProbe:
          httpGet:
            path: /healthz
            port: 10254
            scheme: HTTP
          initialDelaySeconds: 10
          timeoutSeconds: 1
        ports:
        - containerPort: 80
          hostPort: 80
        - containerPort: 443
          hostPort: 443
        env:
          - name: POD_NAME
            valueFrom:
              fieldRef:
                fieldPath: metadata.name
          - name: POD_NAMESPACE
            valueFrom:
              fieldRef:
                fieldPath: metadata.namespace
        args:
        - /nginx-ingress-controller
        - --default-backend-service=$(POD_NAMESPACE)/default-http-backend

For the ingress controller to discover my ingresses, I have to add the annotation:
nginx.ingress.kubernetes.io/ingress.class: "nginx" instead of kubernetes.io/ingress.class: "nginx".  Same thing for the ingress created by kube-lego.


Fix app bar colour on android

Screenshot shows that our app's header bar has a default blue colour. Gmail as their brand's red colour, so it can be done. We should make it so that we use our brand colour as well.
The screenshot shows the staging app, but the issue affects the production app as well.

My phone and Tommy's phone doesn't have the same multi-tasking screen, we should check the android version and decide whether we should support the older version.

@rasmus-storjohann-PG Can you update the issue with the Android version?

So far, based on Android dev console data, Android 7.0 is the oldest version that has our app installed.

There is a primaryColor option in app.json that can change the background color. I tested it works, but I might have set the wrong primaryColor.

These are the two colors I cam up with by using color pick on the app. @cherrielam let me know if either color works.

Client: 1.0.25, Server 1.3.4: Tested and approved


customElements - dis-/connectedCallback in wrong order (polyfill/Firefox ESR)

I digged some more in the code to finally fix #940, which is closed, but not fixed yet and I found the reason.
customElements were introduced in Firefox 63 (caniuse.com), so the Firefox 60.7.0esr (Extended Support Release) needs a polyfill. The polyfill from WebReflection works well, but the elements are connected twice (riot.js?). For some reason, all connectedCallbacks are called first and the disconnectedCallback is called at the end.
cp-actionbar.js is the only file, where the disconnectedCallback is used and it breaks the layout.

did you try to enable custom elements in firefox?
via dom.webcomponents.customelements.enabled preference in `about:config?

I tried it now and it works perfectly. With dom.webcomponents.customelements.enabled, it loads in the right order again. But doing changes in about:config is not really consumer friendly.
These older browsers are in use and there are good reasons to use ESR, e. g.

Mozilla Firefox ESR is meant for organizations that manage their client desktops, including schools, businesses and other institutions that want to offer Firefox. [...] source

using legacy addons, that weren't updated to be compatible with Firefox Quantum
security: new features can cause new vulnerabilities
privacy: the Tor browser is based on Firefox 60 ESR

I didn't test other browsers without custom elements, but the current solution might break there, too.
So everything works fine with the polyfill, except the one disconnectedCallback with the body padding. I think, it's better to work without this feature until web components are available by default, which is at the end of October 2019 (source --> scroll down to the picture).
Or we could find a fix to preserve the right order with polyfills, but I don't know, where to start. The nice thing about riot.js and polyfills is, that they work out of the box and I don't really want to think about these (edge) cases.

Tested with Firefox ESR 68.4.2 - Now custom elements are enabled by default.


Minor clean up of whitespaces and code formatting

Hi @davenewza, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

aspnetcore/fundamentals/middleware.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

aspnetcore/fundamentals/middleware.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Lake of srcAddr to send icmp

Hello,
we need to set the addr source of the paquet, because we have a lot of ipv6 alias on interface, but we need to specify as
net.DialUDP("udp6", &addrsrc, &addrdst)
regards,
Nicolas

Can you not do this by setting pinger.Source? See docs.

Oh yes, sorry I do not seen that.
Regards
Le ven. 30 juil. 2021 à 22:21, Charlie Jonas @.***> a
écrit :

Can you not do this by setting pinger.Source? See docs
https://pkg.go.dev/github.com/go-ping/ping#Pinger.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/go-ping/ping/issues/174#issuecomment-890133706, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMCNUEB354RKU7YHFW4GLTT2MCV3ANCNFSM5BIXQEBA
.


Some problems were encountered in porting the shared memory library to other tools

Hello veltavid:
Thank you so much for open sourcing this project, it has helped me a lot in my research.
However, while using your shared memory library for other protocol fuzzing tools, I noticed that kamailio and several other programs block when calling system functions.

fuzzer blocked when running:

And, it works fine when not using a shared memory library.

By logging the message, we found that when using shared memory library, the system function will call the execve function of the shared memory library sock2shm.so, and the execution result will not be obtained.

As you can see from the log output, the program will block from running original_execve and will not run the next line of logging code.

I don't know if you've ever had a similar problem. HNPFuzzer works fine, but curiously, when I run HNPFuzzer, I find that when I execute the same system code while HNPFuzzer does not need to call the execve function in sock2shm.

Did you do any extra setup and what advice could you give me for the problem I'm having?

That is, is there any way to avoid calling functions in the shared memory library when system(cleanup_script) is called ?


Far Scene water is not drawn

Doesn't need much explanation, but I'll mention this was with HDR enabled - not sure if the same happens without.

By the way, what was the verdict for PBR and stock alpha? I'm still seeing sky objects abruptly pop in and out instead of fading.

Darn, that's quite bad. I'm having a hard time reproducing it though. Does this happen on all maps for you?

By the way, what was the verdict for PBR and stock alpha? I'm still seeing sky objects abruptly pop in and out instead of fading.

It sounds familiar but I've completely forgot about it to be honest. (That's on me probably, I need to get better at organization.) Do PBR materials in the far scene and near scene not transition properly?

Yeah it's affecting all the maps that I've gone through so far.

Do PBR materials in the far scene and near scene not transition properly?

That's not it, I'm talking about the transparency transitions where models are supposed to fade in and out of existence at the start and end of their lifetime. At the moment PBR materials are ignoring the fade and they just pop in and out in a frame's time. To be honest, I believe sky objects use lod0 for all scene ranges so there's no visible problem there, but now that you mention it, the scene transitions could have the same issue. Never caught my eye though.

I'm honestly not entirely sure what could be going on. But what I'm going to do when I get the chance is go through the code base as best I can and try add better handling and logging around anything that looks like it could be causing a crash. Hopefully that could help track down what's going wrong here and other places.
I'll also try putting a whole bunch of water in my test map and see if I can get a crash as well.

Well we can rule out water as the cause of this latest problem. Did a test with water disabled for this map and it still crashed - it looks to be like there's some material issues at play here that weren't a problem when I was using the flags section. I imagine I'll have to make some more shots in the dark to figure this out.

Have a look at this. It's a one in a million chance that I happened to stumble across this, but it instantly rang a bell and I think this is what's happening with the far scene water - looks like the problem is not that it isn't being drawn, but it's being sorted behind everything, both objects and terrain, so vanishes as soon as it's out of near scene range.

Have a look at this. It's a one in a million chance that I happened to stumble across this, but it instantly rang a bell and I think this is what's happening with the far scene water - looks like the problem is not that it isn't being drawn, but it's being sorted behind everything, both objects and terrain, so vanishes as soon as it's out of near scene range.


Blocked in step2: Bputil failed. Did you mistype your password?

I am trying to install Asahi Linux on my Macbook Air M1. Step1 was OK but I am blocked at step2.sh after the 1TR restart.
I selected Asahi Linux in the boot menu and my MacOs username, I was prompted for my password, which was ok. Then I arrive in step2.sh terminal window and I am asked again for my password. I put exactly the same as a few seconds before, the system freezes for 5 seconds and then it says: "Local policy update is in progress, please wait... Boot objects update failed for /Volumes/Asahi Linux: Error Domain=BYErrorDomainCode=401 "Failed to create local policy" UserInfo={NSLocalizedDescription=Failed to create local policy, NSUnderlyingError=0x60001c844b0 (Error Domain=com.apple.bootpolicy Code=17 "pairing (17)" UserInfo={NSLocalizeDescription=pairing (17)}}}}
bputil failed. Did you mistype your password?
Please enter to try again.
I tried to use "bless --setBoot --device /dev/disk2ds3 but it replied Bootability failed Error Domain=BYServiceErrorDomain Code=602 "(null)".
I am a bit lost about what to do next. Should I restart the install from scratch?

I think you're probably running the wrong bless command. Type diskutil list, look for the Asahi Linux partition on the list, and use that device name for it.
I don't know why some users are hitting this; it means that the boot volume was somehow either not set or reverted back to macOS between step 1 and step 2. I'm thinking of adding a feature to step2 so it checks for this and runs the bless command for you, and asks you to shut down and try again.

Here is it diskutil list result. I am not sure if all looks good. I tried to use the bless command with disk2s3 and disk0s5 but it does not work

.

The right option for bless is disk2s2, not disk2s3. You need the system volume, not the Preboot volume :)
I actually just fixed / worked around this failure case in the installer, so future installs will guide you through resolving this if it happens again!

Glad to hear it worked!


Imported FBX materials get cullmode set to disabled by default

Godot version:

3.2.3.stable.mono.official
OS/device including version:

Windows 10 x64
Issue description:

Imported Materials (from scenes) have their Cull Mode toggle set/changed to disabled by default (revertible)

Steps to reproduce:
Open the attached project and reimport the 'Human.fbx'.  (This also happens with gltf), then check the newly created material parameters.
Minimal reproduction project:

ReportProject.zip

What is the actual issue though? That the value is non-default, or that Cull Mode "Disabled" is not a good default for this material?

Both. And backface culling is the most reasonable default and standard.

All importers have code to set the Cull Mode to CULL_DISABLED if the original materials are double sided. Is this the case with this FBX?

Backface culling is enabled in blender on the material

Well in the case of FBX it forces CULL_DISABLED actually, and that seems to be an implementation bug:
https://github.com/godotengine/godot/blob/a6bb4f70e07edc52cb969548876a0b57abeef546/modules/assimp/editor_scene_importer_assimp.cpp#L979-L996
CC @RevoluPowered @fire
Might be fixed in #41985?
For glTF or Collada, it seems fine:
https://github.com/godotengine/godot/blob/a6bb4f70e07edc52cb969548876a0b57abeef546/editor/import/editor_import_collada.cpp#L445-L447
https://github.com/godotengine/godot/blob/a6bb4f70e07edc52cb969548876a0b57abeef546/editor/import/editor_scene_importer_gltf.cpp#L1477-L1482
About having a non-default value in the first place, it's not a bug as shown by the above code, it's intended. Depending on the model's metadata, different options will be used, and this is one of them which gives a non-default cull mode.

There was a bug with normal directions in the current code there should be an improvement  in latest pr. This settting is more hacky than desired.
On Sep 24, 2020, at 1:13 AM, Rémi Verschelde<EMAIL_ADDRESS>wrote:

Well in the case of FBX it forces CULL_DISABLED actually, and that seems to be an implementation bug:
https://github.com/godotengine/godot/blob/a6bb4f70e07edc52cb969548876a0b57abeef546/modules/assimp/editor_scene_importer_assimp.cpp#L979-L996
CC @RevoluPowered @fire
Might be fixed in #41985?
For glTF or Collada, it seems fine:
https://github.com/godotengine/godot/blob/a6bb4f70e07edc52cb969548876a0b57abeef546/editor/import/editor_import_collada.cpp#L445-L447
https://github.com/godotengine/godot/blob/a6bb4f70e07edc52cb969548876a0b57abeef546/editor/import/editor_scene_importer_gltf.cpp#L1477-L1482
About having a non-default value in the first place, it's not a bug as shown by the above code, it's intended. Depending on the model's metadata, different options will be used, and this is one of them which gives a non-default cull mode.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Can you review the newly merged FBX code? I think you'll have to use a nightly build.

with:

it works as expected

Can you also check the 3.2 branch?

I can't find a way to download a 'nightly' of it. Maybe someone else can do that.

I can't find a way to download a 'nightly' of it. Maybe someone else can do that.

Check this folder: https://archive.hugo.pro/builds/godot/3.2/
It's not exposed on my web page yet, but I've been meaning to do that.

It seems to work ~partially, it does not respect the backface culling setting in the material, but atleast it's set to 'back' by default.
And now that i retested both cases in 4.0 it seems i have misinterpreted something there (i clicked the restore arrow which set it to back which i thought to be the imported default, but it seems the override comes from the importer actually). It's set to disabled in either case there, so it is not working correctly. Plus, the material colors don't transfer correctly (materials are just plain white), which works for the 3.2.4 one though.

This is probably fixed with the new FBX importer using FBX2glTF.
You can test it in Godot 4.0 alpha 6: https://godotengine.org/article/dev-snapshot-godot-4-0-alpha-6
This new importer might also be backported for the 3.x branch eventually.
If you still find issues with these models using the new importer, we suggest opening a new issue with details about the problems in Godot 4.0 alpha 6 or later.

This likely still occurs with glTF due to https://github.com/godotengine/godot/issues/39936, but there's no point in having a separate issue open for FBX as this is the same underlying issue.


"tab.activeBorderTop" color hidden under "editorGroup.border"

Type: Bug
Steps to Reproduce:

Configure "tab.activeBorderTop": "#ff0000" and "editorGroup.border": "#454545" (or any other colors)
Split the editor horizontally (up or below)
The "tab.activeBorderTop" is not show in lower editor groups.

Additional info:
It seems that "editorGroup.border" is rendered over the "tab.activeBorderTop", as using a color with transparency lets the "tab.activeBorderTop" to be seen.
A similar bug was previously reported (and closed) as https://github.com/microsoft/vscode/issues/140685
VS Code version: Code 1.75.1 (441438abd1ac652551dbe4d408dfcec8a499b8bf, 2023-02-08T21:32:34.589Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
AMD Ryzen 3 2200U with Radeon Vega Mobile Gfx   (4 x 2495)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
11.55GB (6.88GB free)

Process Argv

Screen Reader
no

VM
0%

@jrieken this is caused by https://github.com/microsoft/vscode/commit/1c5ea5a7266cc0286bf803adf6a50b320c6b0a91. z-index is painful because it cannot be scoped to the component. There are carefully crafted z-index rules for the tabs control as you can see from the comment:
https://github.com/microsoft/vscode/blob/e1967e9d0b4eea25aca3f870695ee40a67c354ae/src/vs/workbench/browser/parts/editor/media/tabstitlecontrol.css#L6-L40
Can sticky scroll have a different solution that does not require the entire split view to be lifted to 20?
//cc @joaomoreno for split views, not sure this change might have an impact elsewhere

Oh, this is not lifting the entire split view up, just the border. So the impact is probably less visible, but here in this case it causes the tab border to fall below.

Can sticky scroll have a different solution that does not require the entire split view to be lifted to 20?

I am open for suggestions but I didn't find a better way to tackle this

@jrieken @aiday-mar is there a reason the sticky-widget needs a z-index of 11? If we would make that 4, the issue would be solved and I still see the sticky widget floating above.
https://github.com/microsoft/vscode/blob/14f639fb9e5aa509ea13da6c1a3416844581ab4c/src/vs/editor/contrib/stickyScroll/browser/stickyScroll.css#L35-L40

Hey I dug in the code, and it comes from this: https://github.com/microsoft/vscode/pull/158730, placing the sticky scroll on top of the zone widget. However this is perhaps not that important, and the z-index can be reduced.

Yes, I would prefer if sticky widget could go below 5, otherwise a lot of other things would have to lift above the new 20 from split view.

Sounds good, there is a PR which should soon be merged

I assume this is the issue:

If so I still think we need to fix this somehow. At least so that either the zone is fully above the sticky scroll or fully below, but not intermingled.

This bug has been fixed in the latest release of VS Code Insiders!
@theNestruo, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version bbc87d8ec2453f12c0066e1c30b41cd5bd2aa021 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

/verified
Thank you!


td-agent v4.5.1

Built packages are already uploaded.

gems are aligned to 5.0.1, so they aren't current latest.


do not define inline function prototypes

Inline function prototypes are invalid C, remove these definitions.

And we went through so much trouble to figure out some weird directive to get this to compile ;)

I know - the horror!


Move all unittests to cmake

Still need to convert a few to gtest. I'll wait for PR #1591 to land and handle the merges.

#1591 is in. Feel free to update.

Merged and passing.


[Suggestion] It would be better if add a "Deploy to Static Web App" action in the context menu

OS: Win10
Build Version: 20211018.1
Repro Steps:
Right click a Static Web App -> Check the context menu.
Actual:
There is no "Deploy to Static Web App" action in the context menu.

Suggestion:
It would be better if add a "Deploy to Static Web App" action in the context menu. This will be very friendly for a Static Web App that failed to deploy.

Unfortunately, this is currently impossible to do.  When you create the Static Web App, you are setting up the workflow for a specific GitHub repo/branch.  If the build has failed, the workflow file must be edited, committed, and pushed to fix any failures.


Test Coverage for Receiving RTXs

I don't believe we have any test coverage for the receiving of RTXs. I am going to work on adding it now!
@boks1971 @cnderrauber After I land some things mind giving it a look? I hope to cover everything (and get a failing test for Simulcast RTX).
Any other features recently that don't have test coverage? I haven't been paying attention recently

Fixed with 83cfeea397d4fa356ace296147732bbf8eac854f


phpdoc: one-to-one reference getter can return null

Codecov Report

Merging #1798 (0fccfdc) into master (e8527af) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1798      +/-   ##
============================================
+ Coverage     87.51%   87.80%   +0.28%
  Complexity     7858     7858
============================================
  Files           281      281
  Lines         22778    22703      -75
============================================
  Hits          19935    19935
+ Misses         2843     2768      -75

Flag
Coverage Δ

5-max
87.80% <100.00%> (+0.28%)
:arrow_up:

7.4
87.80% <100.00%> (+0.28%)
:arrow_up:

agnostic
68.49% <100.00%> (+1.40%)
:arrow_up:

mysql
70.50% <100.00%> (+0.12%)
:arrow_up:

pgsql
70.38% <100.00%> (+0.02%)
:arrow_up:

sqlite
68.42% <100.00%> (+0.11%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Propel/Generator/Builder/Om/ObjectBuilder.php
94.58% <100.00%> (ø)

...onable/VersionableBehaviorQueryBuilderModifier.php
0.00% <0.00%> (ø)

...nable/VersionableBehaviorObjectBuilderModifier.php
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8527af...0fccfdc. Read the comment docs.


Dialog and Option should have theme vars applied to them

dialog and option should have the same theme as the root to them.
Probably something like this?
dialog {
    background-color: var(--color-background);
    color: var(--color-foreground);
    font-family: var(--font-family);
    font-size: 1.6em;
    font-weight: 400;
    letter-spacing: .01em;
    line-height: 1.6
}

option{
    background-color: var(--color-background);
    color: var(--color-foreground);
}

Hi, and sorry for the silence.
Actually I didn’t know about the dialog element, nor did I know option element can be customized.
To help me review your proposal, do you mind to add a minimal HTML exemple featuring those elements to see how it behaves with centigram? Thank you very much.

Hi, yes option has very limited customization compared to other tags.
I will be providing some examples "shortly" as I am reviewing some of my code which was using centigram.


⚠ Bofrost.be has degraded performance

In df9d4f9, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2152 ms

Resolved: Bofrost.be performance has improved in 0f0130f.


Increase initial login timeout yet further, 240 seconds

Because sometimes the Stripes bundle takes a looong time to build.

Well, something is screwy here. I have increased the timeout for the intiial login to a massive 240,000 milliseconds — four minutes — and yet the failure part of the test reports:
  ui-ldp: application exists
    Login > navigate to app > verify tabs work
      ✓ logs out if already logged in
      1) logs in
webpack built ae847486c5d79004239a in 45337ms
      2) should open app and see selected Query Builder tab

So it's timing out the login request before the bundle finishes building, but the build takes 45 seconds.
Any ideas, @funkymalc?

This has been overtaken by subsequent developments.


Fixes compatibility with FeedMe's base FieldInterface

Resolves a 500 error in the FeedMe mapping page when Recipe plugin is enabled, by adding return type declarations to getMappingTemplate and parseField methods to bring it back in line with FeedMe's base FieldInterface. This issue was occurring even if a recipe field was not in the field layout. With the correct base branch this time!

Thank you so much!


Property 'propName' is used before its initialization

Hello everyone!
I am using typescript 4.1.3 and I get this error Property 'propName' is used before its initialization.
I can fix it using "!", but I'm not sure how correct it is @inject propName!: propService.
Maybe someone can suggest something, thanks.

There a few options to deal with it:

Use not-null assertion when needed as you described in the subject.
Turn off strictPropertyInitialization globally in your tsconfig.json. Turning off the checking globally may be considered as a bad practice, it's quite useful overall.
Use declare property modifier introduced in TS 3.7. Note that you have to use it when useDefineForClassFields is enabled (e.g. it's mandatory for MobX's decorators) as I reported in the sibling issue.


Bug (all): release pipeline fails due to command issue

Bug description
As part of the release process lerna calls the version command present in each one of the package.json files. This command runs a series of other lifecycle hooks like liniting the codebase. In #1105 we changed the name of the script from format to lint-fix in all the package.json files of the utilities.
However, in that PR, we forgot to update the content of the version command that still referenced the old name format.
This PR updates the content of the command from npm run format && git add -A src to npm run lint-fix && git add -A src (format becomes lint-fix).
Expected Behavior
Release process should run without errors.
Current Behavior
Release process throws an error because the format command is called by version but doesn't exist anymore.
Possible Solution
Change the content of the version command from npm run format && git add -A src to npm run lint-fix && git add -A src (format becomes lint-fix).
Steps to Reproduce
Make a release, check result of this attempt.
Environment

Powertools version used: N/A
Packaging format (Layers, npm): N/A
AWS Lambda function runtime: N/A
Debugging logs: N/A

Related issues, RFCs
#1105

Released in v1.3.0


feat(pipeline): support string path for images in img2img pipeline

Hello again @kjsman,
as discussed in #1, this PR aims at allowing the user to either provide a string path or a PIL.Image to guide the diffusion in the img2img pipeline. Therefore now the user can pass one of these

a list of strings
a list of PIL.Image
a list containing both

Have a look at this notebook to see what changed at user level :smile:

Gonna merge in minutes. Thanks for your contributions! 👍


Add going to actual npm page of the npm package with a modifier key

So for example if I search for express and press return, it would open the github express page.
But if I search for express and press cmd + return on it, it would open npm page with express.
It would be extremely useful for me, I hope it can be added. Thank you.

From the docs

Hold Alt when pressing Enter to go to its npm page.


Consider extracting some interfaces into a *.Abstractions package

Very often I'd like to derive some application message contract from CorrelatedBy, but if I do, the message contract assembly depends on MassTransit.
It would be nice if there were a way to do this without depending on all of MassTransit.

You can always use your own interface for correlation, there is no magic other than the implicit binding to sagas for messages. And you can easily specify your own correlation method when declaring state machines.

I should have time to look for/duplicate the magic you mention w/ the implicit binding to sagas. Thanks, and closing this one out.


Support CommandLineParser in ModuleConsole

Is your feature request related to a problem? Please describe.
Currently the commands of a ModuleConsole must be parsed by hand.
Describe the solution you'd like
We should use the command line parser with defined verbs to parse the arguments

There is no Command line in asp.net core applications with MORYX 6


fix issue 18804 - std.algorithm.mutation.copy puts whole source range…

… into target range when it should put elements

Looks good.
But I don't have NPOW since I reported the bug.

Something definitely looks wrong here. Put is supposed to compile down to this loop on its own. Can you explain why this change modifies anything?

Something definitely looks wrong here. Put is supposed to compile down to this loop on its own. Can you explain why this change modifies anything?

NullSink is an output range for everything. In particular, it's an output range for int elements, and at the same time it's an output range for R elements. put has to decide which to choose. As per the documentation, it does so by trying in order:

r.doPut(e); - i.e., interpret the argument itself as an output element,
[...]
[...]
for (; !e.empty; e.popFront()) put(r, e.front); - i.e., interpret the argument as an input range of output elements.

With NullSink, the first step always wins. So generic code like copy has to do the loop itself.

In fact, I thought it was dmd optimizer not noticing the range has side effects. Fortunately Ag0Aep was alert.

This is why functions shouldn't use the same name for "do X to Y" and "do X to every element of Y". (See also: put, insertBack, replace.) If D made more use of runtime polymorphism then problems like this would bite people a lot more in practice since it would be easy to write code that does the wrong thing but still compiles.

This isn't an issue with copy. This is an issue with NullSink; it's breaking the rules.
If any put accepts an input range, it's supposed to consume the entire range, or throw/error if it runs out of space before the range is done. NullSink is accepting the range and doing nothing. This fix should change NullSink to have two overloads, one which accepts all types of input ranges, and calls each. The other does nothing.

If any put accepts an input range, it's supposed to consume the entire range

I was going to agree with you and say that the range concept is ambiguous there, because an input range can be interpreted as a single element or as a range of elements. But looking over the documentation for put and isOutputRange, I'm not so sure anymore. Seems that's only the case for arrays, not for all input ranges.
The description of std.range.primitives.put has three snippets that might be relevant:

r.doPut(e);
That is, if an output range accepts an E specifically, then it's an output range for E elements. This is the obvious case.
r.doPut([ e ]);
That is, if it accepts E[], then it's also an output range for E elements. At the same time, it's an output range for E[] elements, as per point 1.
for (; !e.empty; e.popFront()) put(r, e.front);
That is, std.range.primitives.put will unwrap input ranges until it finds an element type that works for the output range. This is not about input ranges being passed to output ranges.

So there's an ambiguity with arrays. They can be seen as elements themselves, or as arrays of elements. Fortunately, NullSink can do the same for both: nothing.
But other input ranges can apparently only be elements, not ranges of elements.

@JackStouffer This was supposed to be merged almost a month ago. I believe you should either merge or answer Ag0aep6g and remove the no objection -> merge label.

And I think it's better like this, instead of modifying NullSink. The reason? Consider you are copying to void[]. What would you except 'copy' to do? Personally I would except it to copy the elements. That's what it is for. If I wanted to copy the range ref only, I'd assign it to 'target[0]'.

I am resetting the 72 hour merge clock on this.

That was 5 days ago. Ready to go?


What is the recommended solution to management of storage account keys through key vault using ARM template

What is the recommended solution to setting up management of storage account keys through key vault using ARM template?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8e90b309-baac-4f6b-c48b-e395f897b870
Version Independent ID: 375e2262-7ad2-3638-9864-7e2421f51942
Content: Azure Key Vault managed storage account - PowerShell version
Content Source: articles/key-vault/secrets/overview-storage-keys-powershell.md
Service: key-vault
Sub-service: secrets
GitHub Login: @msmbaldwin
Microsoft Alias: mbaldwin

@brucedkyle
Thanks for your feedback! We will investigate and update as appropriate.

This isn't currently supported. You have to have a storage account deployed too and add the storage account to your key vault instance.
If you would like to make a feature request to add support for managing these with ARM templates you can do this in User Voice: https://feedback.azure.com/