run-prep: override __scm_apply_patch

This is the easier way of doing what we need. We need people to apply
the way they want and instead let us handle applying by patch and git.

We do this, initially, just by replacing __scm_apply_patch with our
implementation which is the same except:
1. it handles patch name and ID for sake of patch metadata
2. uses our packitpatch shell script

packitpatch is also simpler now
- it creates a git repo if .git is not present
- accepts patch name and ID (commit message, patch metadata)

TODO:

[x] make sure all tests are passing

I'm done here mostly, qemu-kvm is not passing but since it's so big it's hard to work with.

weekend shall start:
tests/test_convert.py::test_conversions[rpm-c8s] PASSED                        [ 16%]
tests/test_convert.py::test_conversions[drpm-c8s] PASSED                       [ 33%]
tests/test_convert.py::test_conversions[HdrHistogram_c-c8s] PASSED             [ 50%]
tests/test_convert.py::test_conversions[units-c8] PASSED                       [ 66%]
tests/test_convert.py::test_conversions[qemu-kvm-c8s-stream-rhel] PASSED       [ 83%]
tests/test_convert.py::test_conversions[libvirt-c8s-stream-rhel] PASSED        [100%]

============================= 6 passed in 501.36 seconds =============================


Support Elasticsearch 6.x

Closes #16.

Coverage decreased (-0.3%) to 84.737% when pulling 25e655c35d9901e741dc77a22b3e474977abb096 on elasticsearch-6 into 91eaed3c7cd2f144b2fb3685fc39e92a3409a15a on master.


Wait in loader for MSW to be fully ready

I really wanted to use MSW to reduce flakiness around placeholder images that would show up in chromatic snapshot tests. I suspected that a loader would help, and saw this PR, but in my testing the only way to ensure that requests for static assets that are sent on mount are properly mocked is to wait for the service worker startup to complete by waiting on this promise returned from worker.start.

Any idea if this will be merged?


Using ES6 (and beyond)

I want to be able to use ES2017 syntax and features to improve productivity. For that to work with the current version(s) of Node, I'll need to add Babel into the mix.

... and for the above to work, I'll need to set up a webpack to actually transpile the code using the chose preset.

Closed with f2579ee6614db4ac3c591b990c2de950cc79b0f6 and ce966107465ceb5f36acb57d0a85d716a82a64f9.


Debugger has inferior status bar, and opens dialog for unused temps (3.0.74)

Unused temp flagged in debugger:

but not in project browser or method browser ...
I almost like the warning, but one way or the other, we should be consistent

As of 3.0.74, there's a warning in the status bar for unused temps.  It's still an error dialog in the debugger.  Now I would prefer a warning status bar in the debugger.
Compile errors do appear in the status bar of the debugger so this is not impossible.
The debugger status bar does not go dark pink, it stays the simple gray.

The status bar should now behave like the other browsers when compiler warnings & errors happen in the debugger. The pop-up is eliminated. 3.0.76.


Synchronisation

to be discussed - exactly how to sync bonsai stuff with other stuff in experiment (during analysis)

I believe we discussed this before, but there are essentially two ways to do this, either sending a TTL to the Harp board which will be automatically timestamped and logged, or configure a TTL output from the board to the external device. The ranson-rig workflow logs all input and output command TTLs to/from the board already so either case is already covered.


Enable security scanning for docker image

Currently, we build a docker image for mediaflux and push it to docker hub under the pulibraryrdss docker account. When our docker build was happening in the eosadler account, we had security scanning enabled, because that account had a pro subscription. Our pulibraryrdss account does not have a pro subscription, and so cannot do automatic security scanning.

Done! I figure out how to enable one free security scan without upgrading to a paid account.


wp_stateless_file_name filter

The wp_stateless_file_name  filter has been changed by changes made for  #149.
Previously it was used to:

Get gs name from the local file path (relative or absolute).
Get a local file path (relative to upload dir) from the GCS URL.

Now due to changes made by #149:

We can get a gs name from the local file path (relative or absolute).

But we can't convert a GCS URL to local file path and can't identify the attachment.
For example attachment_url_to_postid tries to convert GCS URL to file path relative to upload dir.
Now it will fail in some cases.
I would like the conversion process to work both ways.
We can remove the year, month wildcard and remove base_dir from file path then prefix with bucket folder value. Just like it used to work before.

If we remove the year, month wildcard and remove base_dir from file path then prefix with bucket folder value. Just like it used to work before.

Also, in this case we will return to using WP core setting Organize my uploads into month- and year-based folders on GCS path.

@alimuzzaman I fixed it for attachment_url_to_postid. Please check my last commit.

I would like the conversion process to work both ways.

I added new function parse_root_dir_wildcards, now we can retrieve month and year from path and use it on function root_dir_wildcards (I added third parameter for it).

Also we need to fix function the_content_filter

Function the_content_filter fixed.
@alimuzzaman Problem which you describe is solved?

@ewsopp What do you think if we remove %date_year%  and %date_month%?
The current solution works but not as solid as before.
@planv have solved some problems it caused but can't be sure there won't be more problems.

@ewsopp already removed it.

Where are the month and year tags?

@ewsopp

Where are the month and year tags?

We will get Y/M like before using organization settings like we used to do before.
Having Y/M tags create unnecessary problems. It breaks backward compatibility of wp_stateless_file_name filter.
This filter is responsible for converting the local URL to the GCS URL and vice versa.
With the new approach(Y/M tags) it mostly works but we can't make it 100% perfect like before.
If you want we can keep the Y/M tags and solve problems when they appear.
To me, the hassle Y/M tags will create isn't worth it. I am not feeling comfortable with the changes.
@planv what do you think?
Some idea:
We can make Y/M into one tag and show it as bellow. Underneath it will be just the organization setting.

What if we replicate the logic for generating the current year and current month? Rather than using WordPress to generate these pieces for us, could we generate them ourselves to get it to work?
%year% and %month% could be separate tags and the webmaster can place them in the same format that WordPress would do. ex: /sites/%site_id%/%year%/%month%

@ewsopp yes, that's similar to what @planv had done.
But that can cause some unforseen problems in future. Though @planv had solved some of the problems.
If you want we can just revert back to Y/M and try to solve problems when they arrives.

Now it will fail in some cases.

@alimuzzaman in your original comment on this issue, you mention that this method will fail in some cases. Can you give us some specific examples?

Get a local file path (relative to upload dir) from the GCS URL.

Can we get a local path with GCS URL without attachment ID?

Now we can just remove https://storage.googleapis.com/udx-ci-develop-alim/{{Bucket Folder}}
How do we get the local path from GCS URL if you have Y/M in the wildcard?

EX.
Users have Organization enabled, but don't have Y/M in Bucket Folder option.
I don't see any way to get the local path in this case.

How do we get the local path from GCS URL if you have Y/M in the wildcard?

We can retrieve year and month from GCS URL.
if we have URL https://storage.googleapis.com/stateless-udx-ci-develop-vova/custom_folder/2020/06/4343-1-300x225.jpg
We can retrieve 2020 and 06 from this URL and use it for local path /2020/06/4343-1-300x225.jpg
But in case if user has enabled Organize my bucket folder month\year - we always need have tags %year% and %month% on our wildcards

We can retrieve year and month from GCS URL.

@planv if you don't have Y/M in Bucket Folder option?

@alimuzzaman Field Bucket Folder must be consistent with option Organize my uploads into month- and year-based folders

I think you have done it already.

Yes, it is already done.

Not sure how we can enforce that.

We can make these tags required if Organization is enabled. And add notice for clients.
So if Organization is enabled - client can't remove these tags from Folder Bucket.

Can we disable the Organize my uploads into month- and year-based folders option entirely? Disable it and direct user to configure the setting within WP-Stateless settings area.

Can we disable the Organize my uploads into month- and year-based folders option entirely? Disable it and direct user to configure the setting within WP-Stateless settings area.

@ewsopp
Organize my uploads into month- and year-based folders applies only for local path, and Bucket Folder applies for GCS path. It is not solving problem. The issue not in this option.
We must have this option available because it is Core functionality.
In case if it is enabled we need to force using %year% and %month% tags and this will solve problem.
So we have 2 options - we are doing like this or we will remove these tags totally as Alim propose.

If you want to force then my idea of combining them into one is a good idea.
https://github.com/wpCloud/wp-stateless/issues/493#issuecomment-638464764

If we have a single /%date_year%/%date_month% tag, we could easily map it to the core Organize my uploads into month- and year-based folders setting, correct?

Yes, it will be as postfix.

%date_year%/%date_month% would have to be added to the end?

Yes

To recap:

combine %date_year% and %date_month% into a single tag: %date_year%/%date_month%
map the %date_year%/%date_month% tag to the core Organize my uploads into month- and year-based folders setting.
force the %date_year%/%date_month% tag at the end of the custom folder path.

@alimuzzaman is this correct?
@planv @antonkorotkov what do you both think of this?

force the %date_year%/%date_month% tag at the end of the custom folder path.

We don't need to force it. If the user has the organization enabled Y/M will be shown as postfix.

If you want to force then my idea of combining them into one is a good idea.
#493 (comment)

No. We can use separated tags %year% and %month%.
If Organization is enabled - these both tags should be in Bucket Folder. It can be at the end, or at the beginning, doesn't matter.

combine %date_year% and %date_month% into a single tag: %date_year%/%date_month%

We can use separated tags, as we have now.

map the %date_year%/%date_month% tag to the core Organize my uploads into month- and year-based folders setting.

Yes.

force the %date_year%/%date_month% tag at the end of the custom folder path.

Yes. If user has enabled Organization and haven't tags %year% and %month% on Bucket Folder yet.

We can add checkbox  Organize my uploads into month- and year-based folders to our settings page, it will repeat WP core functionality (applies for local path), and also add/remove /%year%/%month%/ from field Bucket Folder.

Not checked

Checked

I added new select for field Folder.
Also combined tags %date_year% and %date_month% to tag %date_year/date_month%.
This tag map to the WP core setting Organize my uploads into month- and year-based folders

Great work so far. Some suggestions for improvement...

[ ] remove the x remove icon from each tag, and simply allow the user to click the tag to remove it.
[ ] visualize the / as its own tag.

[ ] dashes should be accepted.

[ ] typing / should close out the typed text as it's own tag and add a following / tag.

Some questions about capability...

Can we allow the user to click into the folder structure? It seems user is limited to adding onto the end of the constructed folder path. Forces the user to clear chunks of the path to make edits.
Can we do validation? For example, ensure there are no consecutive / tags (resulting in an empty folder name).

Can we allow the user to click into the folder structure? It seems user is limited to adding onto the end of the constructed folder path. Forces the user to clear chunks of the path to make edits.

No.

Can we do validation? For example, ensure there are no consecutive / tags (resulting in an empty folder name).

Sure. We have validation for this field on server side.

[ ] add a slash / to the open and close recipe for Single Site.

[ ] same with the Multisite recipe, and include slashes between each directory.

[ ] styling - maybe we should extend the length of the fields to provide more visibility of the preview and maintain consistent styling.

[ ] styling - adjust the height of the folder field to match other fields.

[ ] in testing, I was not able to save an empty value. upon save and refresh, it would show previous setting. empty is a valid state of the field if the webmaster wants to dump everything in the bucket without any folder organization.

Done

@planv @ewsopp

@alimuzzaman
You can remove tags by clicking on it. Or save form and wrong tags will be deleted automatically.

%date_year/date_month% placeholder is always returning the current Y/M.

@alimuzzaman

%date_year/date_month% placeholder is always returning the current Y/M.

We retrieve year and month from received path.
https://github.com/wpCloud/wp-stateless/blob/latest/lib/classes/class-bootstrap.php#L875-L879
So if we have year and month in path - we will use it instead current year and month.

@planv @antonkorotkov could either of you review the recent updates here? Close out if satisfactory.


Invalid version: 'RegionCLIP'

Obtaining file:///home/lab/dev/RegionCLIP
Preparing metadata (setup.py) ... error
error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
│ exit code: 1
╰─> [27 lines of output]
/home/lab/anaconda3/envs/regionclip/lib/python3.9/site-packages/setuptools/dist.py:543: UserWarning: The version specified ('RegionCLIP') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
warnings.warn(
running egg_info
Traceback (most recent call last):
File "", line 2, in
File "", line 34, in
File "/home/lab/dev/RegionCLIP/setup.py", line 193, in
setup(
File "/home/lab/anaconda3/envs/regionclip/lib/python3.9/site-packages/setuptools/init.py", line 87, in setup
return distutils.core.setup(**attrs)
File "/home/lab/anaconda3/envs/regionclip/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 185, in setup
return run_commands(dist)
File "/home/lab/anaconda3/envs/regionclip/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 201, in run_commands
dist.run_commands()
File "/home/lab/anaconda3/envs/regionclip/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 969, in run_commands
self.run_command(cmd)
File "/home/lab/anaconda3/envs/regionclip/lib/python3.9/site-packages/setuptools/dist.py", line 1208, in run_command
super().run_command(command)
File "/home/lab/anaconda3/envs/regionclip/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 987, in run_command
cmd_obj.ensure_finalized()
File "/home/lab/anaconda3/envs/regionclip/lib/python3.9/site-packages/setuptools/_distutils/cmd.py", line 111, in ensure_finalized
self.finalize_options()
File "/home/lab/anaconda3/envs/regionclip/lib/python3.9/site-packages/setuptools/command/egg_info.py", line 219, in finalize_options
parsed_version = parse_version(self.egg_version)
File "/home/lab/anaconda3/envs/regionclip/lib/python3.9/site-packages/pkg_resources/_vendor/packaging/version.py", line 266, in init
raise InvalidVersion(f"Invalid version: '{version}'")
pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: 'RegionCLIP'
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed
× Encountered error while generating package metadata.
╰─> See above for output.
note: This is an issue with the package mentioned above, not pip

Please refer to issue #60. The solution is to downgrade the version of setuptools: pip install setuptools==59


Proper namespace

Hey!
First of all, thank you for providing this library. It has been very helpful.
I want to suggest a small improvement of the library.
At the moment, the library doesn't follow common guidelines for namespaces in C++.
All the code in the library should be in a namespace.
The code in steering_functions.hpp are in the namespace "steer", while code such as CC_Dubins_State_Space are not in any namspace.
I also suggest that the namespace should be called "steering" to match with the repository name here on Github.
Also, "using namespace [...]" should not be used in header files as it causes problems when including the header files.
E.g. your class Path has a very generic name which is very likely to crash with other names for users of this library.
I can make a pull request with the required changes, I just wanted to coordinate with you beforehand.

Here are some resources on the topic:
cppbestpractices
C++ Core Guidelines
Google C++ Style Guide

Sure, sounds good. Please follow the contribution guidelines when submitting a PR.

As a user of this wonderfull library, I'm good with the changes proposed.
I would expect and entry in the changelog and a version bump in the package.xml though.


ipv4 rx fragments: is zephyr support?

Hi,
I am running the latest OS zephyr and I have issue on ipv4 while I have rx fragments.
So I try to understand from the docs\code if it supports but didn't find any reference for enable\disable it. I did see a reference for Ipv6 fragments.
Is Ipv4 rx fragments reassembly supported? If yes, can you add details?
Thanks,
Ehud

IPv4 packet fragmentation is not supported.

Thank you @jukkar , do you know if it is plan on road map?

There has not been any discussion whether we should have that feature or not. This is first time someone asking this. You can always submit a feature request issue for any missing feature, but if no one else needs that feature, you should be prepared to submit patches yourself.

Thank you


sbt-launch no longer published to repo?

Circleci uses a repo url to keep track of new versions of sbt-launch so that they can make them available on their ci platform.
I think travis does something similar.
The repo url they're following http://dl.bintray.com/typesafe/ivy-releases/org.scala-sbt/sbt-launch/ has sbt-launch versions up to including 0.13.9. But nothing after that.
As a result CI platforms like CircleCI (and I think Travis as well) require custom downloading of sbt which makes sbt work less "out of the box" on CI services.
So my question is: is there a repo to which new versions of sbt-launch are published? Or can sbt-launch versions higher than 0.13.9 continue being published to bintray?
groetjes

First, I'd recommend against using Bintray URLs directly. Instead the following URL should be used: https://repo.typesafe.com/typesafe/ivy-releases/org.scala-sbt/sbt-launch/

But nothing after that.

A repackaged launcher for 0.13.11 is published there.

Hi Eugene,
My mistake: I somehow assumed the list was sorted numerically. But it's alphabetically ofcourse.
Tx and have a nice sunday


Add FirestoreGateway.runTransaction tests

All updates made here will be merged in the last PR (#211), in this nested chain of collection execution PRs.


Move MessageContent into Azure.Core

Addresses https://github.com/Azure/azure-sdk-for-net/issues/27699

API changes have been detected in Microsoft.Azure.Data.SchemaRegistry.ApacheAvro. You can review API changes here

API changes have been detected in Azure.Core. You can review API changes here
API changes
+     public class MessageContent {
+         public MessageContent();
+         public virtual ContentType? ContentType { get; set; }
+         public virtual BinaryData? Data { get; set; }
+         public virtual bool IsReadOnly { get; }
+         [EditorBrowsable(EditorBrowsableState.Never)]
+         protected virtual ContentType? ContentTypeCore { get; set; }
+     }

API changes have been detected in Azure.Core.Experimental. You can review API changes here
API changes
-     public class BinaryContent {
-         public BinaryContent();
-         public virtual ContentType? ContentType { get; set; }
-         public virtual BinaryData? Data { get; set; }
-         public virtual bool IsReadOnly { get; }
-         [EditorBrowsable(EditorBrowsableState.Never)]
-         protected virtual ContentType? ContentTypeCore { get; set; }
-     }

API changes have been detected in Azure.Messaging.EventHubs. You can review API changes here
API changes
+ Azure.Core
- Azure.Core.Experimental
-     public class EventData : BinaryContent {
+     public class EventData : MessageContent {

The changes look good. My concern is the timing. If this isn't expected to be part of the Core release for the April milestone, can we delay until after releases are done so that the Event Hubs beta remains bound to the version in Experimental?

This should be able to go out in the April release.

Would it be possible add a description with more context to this PR or the issue?  Where is the API in the proposal -> arch board approval stage?

Would it be possible add a description with more context to this PR or the issue? Where is the API in the proposal -> arch board approval stage?

Updated the associated issue - https://github.com/Azure/azure-sdk-for-net/issues/27699

Are we concerned about checking in an unapproved API into Core? We will need it to be approved at some point, and delaying this could push out Core release dates.

@tg-msft would you mind approving the Api Review from this PR?

Are we concerned about checking in an unapproved API into Core? We will need it to be approved at some point, and delaying this could push out Core release dates.

@tg-msft would you mind approving the Api Review from this PR?

I'll send an email to the arch board this change first.

Are we concerned about checking in an unapproved API into Core? We will need it to be approved at some point, and delaying this could push out Core release dates.

@tg-msft would you mind approving the Api Review from this PR?

I'll send an email to the arch board this change first.

Discussed offline - we will merge this in for now and get the approval later this month.


Notify other plugin authors about PluginManager

Not now. One day.
Just to track found plugins.

[ ] volkanceylan/GitExtensions-SerenityFlow-Plugin
[ ] amcarthur/Zipper
[ ] EbenZhang/PReviewer
[ ] otmopo3/GitExtensionsOpenSolutionPlugin
[ ] andypaxo/ontime-git-extensions
[ ] git-tfs/git-tfs-gitextensions-plugin

I stumbled on https://github.com/git-tfs/git-tfs-gitextensions-plugin
And @SteveMcArthur expressed some general interest in a new plugin (gitextensions/gitextensions#5382)

Thanks! TFS seems quite dead, but I'm going to add it.

Closed by #81.


Prevent fold_many1!() from turning a Failure into an Error.

Coverage decreased (-0.02%) to 87.542% when pulling 55af6ceea766c2211aa28bfc9bab0bef8de828ef on ProgVal:many1-failure into 64af2d1cac7298b511eb671163dcdbb2ad197d17 on Geal:master.

nice catch, thanks


outlook.com SMTP Error Code

https://sendersupport.olc.protection.outlook.com/pm/troubleshooting.aspx

https://github.com/sisimai/set-of-emails/blob/master/maildir/bsd/lhost-ezweb-08.eml includes an error code listed above, but the value of rhost in the parsed results is empty.


List.map does not work with mapper that returns null or undefined

Example:
var {Record, List} = require("typed-immutable");

var Point = Record({x: Number(0), y: Number(0)})
var Points = List(Point, "Points")
ps = Points.of({x:3}, {y: 5})
ps.map(a => a.x || null);

this throws a "TypeError: Cannot read property 'constructor' of null"
I believe what is happening here is that the type inferer is not correctly returning a new List(Maybe(Number)).

You might need to use List.reduce and a new List(Maybe(Number)) to do this, the behavior is as documented.
I wouldn't be against a way of telling List.map which type of list you want to end up with, that would let you use both Any or Maybe.


Remove zarr-errors handling from tasks

There are few places where we use try/except for zarr errors, which could be handled better (i.e. the try/except should be replaced by an if/else, with conditions based on zarr attributes).

In create-omer-zarr-multiplex, when looping over wells
In apply_registration_to_image, when getting the current label_list.

Note that this is not applicable (for the moment) to the ContainsArrayError errors in yokogawa-to-zarr and MIP tasks.

Related: https://github.com/fractal-analytics-platform/fractal-tasks-core/issues/621


[WIP] Check compatibility with berkeley

For PRs against develop, check that we can sync a daemon against a berkeley seed daemon.

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

Can this one also replace the existing connect to berkeley test?

The test here connects to a local daemon built with the berkeley branch, not the berkeley testnet. So they're different tests.


Use recursive_merge instead of Bosh::Template::Renderer for stubs

This PR simplifies stub files, by not having to use an intermediate format (erb with 'p('foo') helpers).
It allow you to create a yaml stub file which can be used to inject name, director_uuid and meta.
cc @allomov

Yey! That's a great idea.
I also wanted to find the way to substitute bosh-template. And the easiest way would be using spruce with its possibility to create templates out of templates. I like this way to create stubs.

I have one consideration here. I can think of the situation when you can take advantage of bosh-template here. Imagine you have following stub:
stub.yml
properties:
  components:
    - gaussian-filter
    - bandpass-filter

bosh-templates allow to have the following deployment deploymnet.yml
director_uuid: some-hash
templates:
  - common-components.yml
<% p('components').each do |component_name| %>
  - templates/additional-components/<%= component_name %>.yml
<% end %>
meta:
  bandpass-filter:
     t1: 440

Finally it looks like such solution has more fragile, but a little bit messy. What do you think?

@allomov I see your use-case I'm however not sure if this should be something to support. Since it makes it even harder to reason about the outcome of the deployment (which makes it a nightmare to maintain). In the above case I would create separate deployment files for different use-cases. As was for example done with swarm support in the the docker-services-boshworkspace.

Yes. I see, still having distinct deployment for every case you have seems little bit redundant.

I have controversy feelings about it: I both like and dislike it. Of course, it would be nice to have something else from ERB to render yaml templates.

I'm currently working on adding rspec helpers to easily test all the deployment in a boshworkspace repository. I found that not having a dynamic number of templates makes it easier to test. Because one deployment is basically one use-case.

Will leave this PR open till I finish the rspec helper PR

This makes sense. Would like to see such specs.

@rkoster have you seen this PR ? https://github.com/geofffranks/spruce/issues/51
Seems like suffering could be over and stubs can be merged using spruce. :)

@rkoster as far as I can see you are going to open source you spec helpers. Can I take a look on them? To avoid repeating each other.

Just finished creating a PR: https://github.com/cloudfoundry-incubator/bosh-workspace/pull/81

To be honest, I don't see huge benefit of using ERB without taking advantage of bosh-templates. Why do you need ERB then?

I personally don't use erb. Logic in templates makes them even hard to maintain. Erb support was a contribution https://github.com/cloudfoundry-incubator/bosh-workspace/pull/69. I don't know what it is used for. And if that usecase could be covered with the current stub merge behaviour.

I don't feel convenient with having deployment file for each kind of deployment. Potentially, ERB and bosh-templates can help with it. Still I understand they can cause huge mess in deployment file and that's one of the reasons why I like idea with deep merge. This really puts me into cognitive dissonance :)

Have you seen the tests I added to the cf-boshworkspace? Basically you can test all you different deployments with just a simple stub + result file per deployment. After working with it for a week I found this really powerful. It gives you the ability to get a bosh deploy like diff of the changes but then for all your environments at once. This way you can see how a templates change affects all your deployments. Something which would be much harder when using erb.


Make the version of opam used explicit in prevision for the upgrade of the base docker images

This way we don't have to change the code for opam 2.2 or if the docker images upgrade to opam 2.1 by default.
However this changes the key of the ocurrent cache and will restart all the builds. To merge when we have a low number of small PRs.

Everything restarted already so might as well merge this


fix: workaround for leanprover/lean4#2249

This puts all the mathlib tactics in the Mathlib.Tactic namespace instead of pretending we are an extension of the Lean package, which is causing problems.

bors merge
Does this also apply for other tactics (in the Tactic folder)?

It probably does, actually I should fix mathport on this commit to make sure there aren't more hidden issues

This is sufficient to fix mathport, but there are probably other tactics which are in the lean namespace, dunno if I should hunt them down in this PR


tasklaunchrequest-transform-processor is skipping payload/message

As a user, I'm using tasklaunchrequest-transform-processor in SCDF and while testing it, I'm unable to receive the payload from an upstream application wrapped in the TaskLaunchRequest. It looks like the inbound message is not populated in the request object [sample application used to].
Currently, there isn't any other way to the receive upstream event/payload info at the launched Task level.
This issue is will be moved to the new repo eventually.

The ability to pass a payload as an attribute of the TaskLaunchRequest was removed because the TaskLauncherSInk has no way to pass this along to the Deployer's TaskLauncher.   Unless we  assume the payload is a string and store it as a property or a command line argument.   While this is possible we have no way of handling non-text payloads i.e. Objects unless we serialize them as something like JSON.   This is a part of the discussion where we need to look at a solution beyond the use of the Deployer for the TaskLauncher sink.   Thoughts?

This issue was moved to spring-cloud-stream-app-starters/app-starters-release#46


Bugfix addition

Could it be possible if yall could add a fix for B.R.A.I.N Turrets not targeting Interdiction Pillars?

This issue has been patched in vanilla so I'm closing it.


flutter run --release  startup  crash on Android

flutter run is work, but flutter run --release  startup  crash on Android
E/flutter (16361): [ERROR:flutter/fml/platform/posix/native_library_posix.cc(16)] Could not open library 'libapp.so' due to error 'dlopen failed: library "libapp.so" not found'.
E/flutter (16361): [ERROR:flutter/fml/platform/posix/native_library_posix.cc(16)] Could not open library 'libapp.so' due to error 'dlopen failed: library "libapp.so" not found'.
E/flutter (16361): [ERROR:flutter/runtime/dart_vm_data.cc(19)] VM snapshot invalid and could not be inferred from settings.
E/flutter (16361): [ERROR:flutter/runtime/dart_vm.cc(238)] Could not setup VM data to bootstrap the VM from.
E/flutter (16361): [ERROR:flutter/runtime/dart_vm_lifecycle.cc(89)] Could not create Dart VM instance.
F/flutter (16361): [FATAL:flutter/shell/common/shell.cc(218)] Check failed: vm. Must be able to initialize the VM.
[✓] Flutter (Channel master, v1.8.1-pre.21, on Mac OS X 10.14.4 18E227, locale zh-Hans-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 10.2.1)
[✓] iOS tools - develop for iOS devices
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.4)
[✓] IntelliJ IDEA Ultimate Edition (version 2018.3.5)
[✓] Connected device (3 available)

It seems that libapp.so is missing.
Paste flutter run --release --verbose please.

I have a similar error when running an app on an old (android 4.1) phone, here's the logs from flutter run --release --verbose:
https://gist.github.com/X-Wei/f8ace31036e9262d5bc727bb4c7d6ad1

Duplicate of #35838?

Yep, closing this as a dup of https://github.com/flutter/flutter/issues/35838


Document removing  and adjusting a periodic callback period

While I was creating https://github.com/pyviz/panel/pull/573, I thought it'd be nice to modify the periodic callback period or remove it completely.
import panel as pn
import numpy as np
pn.extension()

def generate_random_number(event=None):
    static_text.value = np.random.randint(low=100000, high=200000)

static_text = pn.widgets.StaticText(name='Periodic Random Number Generator',
                                    value='000000')
static_text.add_periodic_callback(generate_random_number,
                                  period=5000)  # period in milliseconds

request_button = pn.widgets.Button(name='Request New Number')
request_button.on_click(generate_random_number)

col = pn.Column(request_button, static_text)
col.servable()

Add something like
static_text.remove_periodic_callback()

Similar to static_text.param.unwatch
Also,
static_text.periodic_callback.period = 1000

Similar to static_text.value = 'something else'

This is already possible, just needs to be documented:
callback = static_text.add_periodic_callback(generate_random_number,
                                  period=5000)  # period in milliseconds
callback.stop()

https://github.com/pyviz/panel/pull/573


AutoML - Train Test Split

We need to allow the user to configure the training and testing split sizes, probably can just be done with:
https://scikit-learn.org/stable/modules/generated/sklearn.model_selection.train_test_split.html

closed with 1e8557b1c965522ece578beac1efbe8686993836


Add a confirmation modal and use it for deleting roles

Add a service that can be used for triggering a confirmation modal. For example:
export default Ember.Component.extend({
  confirmationModalService = Ember.inject.service('confirmation-modal'),
  actions: {
    delete(thing) {
      this.get('confirmationModalService').open({
        partial: 'confirmation-modals/some-partial-template', // Is looked up as a partial
        model: thing, // Is made available in the partial
        onConfirm() {
          thing.deleteRecord();
          return thing.save(); // The modal will not close until a returned promise has completed
        } // onCancel also available
      });
    }
  }
});

Uses this for role deletion.

Fixes #206

@bantic for you to review/merge please.

Really cool @mixonic

Cool, a few notes. Neat idea. @mixonic @sandersonet Do you think users will find it jarring to have the modal replace the entire UI, rather than laying on top of it?


Add graphql example

Add a new example showing how to use graphql to query state from torii.
It should be very basic.

copy the graphql format from this structure
https://github.com/BibliothecaDAO/eternum/tree/next/landing

Can I try solving this issue?


Updated AD/LDAP settings to new format

Summary
This PR updates the AD/LDAP section of the Authentication Configuration Settings to the new table-based format. For previous PRs I was able to check the documentation against the Mattermost Docker preview and/or Mattermost Cloud, but I could not do that for these settings.
In this PR, these settings should get specific technical review to make sure the documentation is correct:

Private key
Public certificate
Enable Admin Filter and Admin Filter
Profile Picture Attribute

Ticket Link
This PR partially addresses https://github.com/mattermost/docs/issues/5951.

Hello @matthew-src,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


external_schema doesn't work with atlas schema diff

Overview
In my testing, I can easily get atlas migrate diff --env testing and atlas schema apply --env testing working with an atlas.hcl config file that looks like:
data "external_schema" "orm" {
  program = [
    "/path/to/program",
    "arg1"
  ]
}

env "testing" {
  src = data.external_schema.orm.url
  url = "..."
  dev = "..."
}

However, when running atlas schema diff  --env testing, I get the following error:
Error: required flag(s) "from", "to" not set

What I expected
I expected that these flags would have been populated from the atlas.hcl config file:

--from should come from url
--to should come from src

Is this expected behavior?

Hey @jerluc 👋
If you want to use --from as url and --to as src, you can use schema apply --env testing --dry-run to achieve this.
The schema diff command currently supports reading its states from the command URLs, but I plan to add support reading it from data sources like this: data://type/name in the future.


Issue when gathering states in Macro Class

There is an issue when gathering the states and ddts of all stateful_element in Macro class
Under some circumstances the np.array method can return a User-Unhandled Exception:
The way I replicate this is by having a model that have the following components:

An Integ that have integer values at all times

A Smooth N that is initialized with floating point values

When adding the Smooth N state values to the array the np.array method returns the exception

I believe the method sets the dtype of the array the same as the first element (in this case int) so when  you try to insert float values it will mismatch and throw the exception
One walk around to address this  would be to specify the dtype as object when generating the array. This way the array can hold any type of data in it.

This issue is reproduced by tests included into travis, I think thats is very similar problem.

I've been looking at this, and it seems pretty fundamental to the way the integrator is handling nested objects, and I think has to do with when you have a numpy array that has different types of elements. For example, when some elements are numbers, and others are references to stateful objects, which themselves may have nested sets of numbers and other statefuls as part of their states. We need a solution that can handle that broadcasting properly.
I can make this bug go away if instead of using numpy arrays, and broadcast syntax (like here ) I use a list comprehension that multiplies everything through individually [a.state + a.ddt * dt for a in self.state ] or something like that. But - it breaks macros and other nested functions.
My intuition says we may want to overwrite the + and * operators for the stateful class, but I haven't given it a lot of good thinking.

@alexprey Thank you for pointing it out, i will take a look at that that case, maybe we won't need a specific test to cover this issue at all since there is already one that is capturing it

Thinking some more, it sounds like @rugue1's solution of specifying the objects is a good place to start.  Did that pass the smooth_and_stock test? I see it didn't error, but I've lost track of if that branch was up to date on the test repo!

I just manually ran the smooth_and_stock test smooth_and_stock test with the fix and its passing

I believe this is fixed in https://github.com/JamesPHoughton/pysd/commit/b1d29d62abaa58517327da26bfe63131295edff5 with the syntax:
def ddt(self):
        return np.array([component.ddt() for component in self._stateful_elements], dtype=object)


Bug: "Manage Hints" button doesn't work

Describe the bug

Logged as an instructor, the "Manage Hints" button in the programming exercise View does not perform any behavior. Therefore, hints cannot be created/managed.
To Reproduce

Pre-conditions:
0.0 Loggind in as instructor
0.1 Programming exercise created with code editor
0.2 Solution template succeded
Go to Course Management -> Exercises
Click on the programming exercise (View page should open)
Click on "Manage Hints" button
No behavior/no error messages/no changes

Expected behavior

A window should be opened with "Create a new hint" button.
Screenshots

Environment

 - OS: Windows 10 Pro
 - Browser: Chrome, Microsoft Edge

Additional context

Link to TestQuality: https://ls1intum.testquality.com/project/10165/plan/17385/run/142723/result/2150214
Seemed to be an issue for the release 4.0.4
Output in Web Console

 No output

I am not able to reproduce the behavior, is this still a problem in the current version?

Yes, it is still the issue, at least I still observe no behavior. When you clicked on "Manage Hints", was a new window with "Create a hint" functionality opened?

Yes, I'm also using Chrome. I will take a closer look at it tomorrow.

It works again

This issue was recently fixed.


feature request: Ellipsis when text of node goes outside of the jstree container

First look at this Fiddle
as you can see the jstree is contained within it's container but unlike the div underneath it I can't get ellipsis to appear on nodes with text that go outside the container.  In order to do this I would probably need to know the indentation and the width of each node .
So could this be a setting in jstree? (maybe not only allow Ellipsis but also other characters.)

ok, I've actually been able to solve it using the css calc() function. You can see how in the following fiddle

A concern with this solution is when the values used in the calc are changed in jstree.
Another concern is adding a scrollbar to see the rest of the text:

This might be hard to do correctly with the tree as we don't want a scrollbar per node but one scrollbar for the entire tree
in most browsers you wouldn't see the text. only firefox (at this moment) seems to properly support this behaviour

After discussing this some more it seems that the concern that the values used in the calc might change is big enough to warrant reopening this issue.

Sorry, but I do not plan on adding such functionality.
All systems I have seen either cut off the text (without an ellipsis) and let you resize the tree container or provide a horizontal scrollbar on the tree container - jstree supports both those scenarios.
Quite frankly - I do not see the need for it - can you provide a screenshot of a tree that uses this (OS file manager, or something else), as I can't even imagine a good implementation. The idea of cutting off using ellipsis and still allowing resizing or scrolling is counter intuitive for me. As for cutting off and not providing a means of resizing - it would be very confusing for the user as whole levels of the tree will be unaccessible, but still - if you need that you can use your calc solution - kudos for that!
I am closing this for now, but feel free to share any ideas and / or implementation - if something good comes from the discussion I will reopen.
Best regards,
Ivan

After reading the whole thread over at jstree-grid I realized that the calc solution is usable, provided it is in the theme file, so I am reopening this - thanks: https://github.com/deitch/jstree-grid/issues/184


Problem while installing via pip3

When I was installing the Manim via pip3 with this command:
pip3 install manimlib

I received this:
ERROR: Could not find a version that satisfies the requirement opencv-python==<IP_ADDRESS> (from manimlib) (from versions: <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>)
ERROR: No matching distribution found for opencv-python==<IP_ADDRESS> (from manimlib)

How to deal with it?
And how can I make
Something may helpful:
> uname -a
Linux sparky-14145-pc 5.5.2-1-MANJARO #1 SMP PREEMPT Tue Feb 4 19:22:35 UTC 2020 x86_64 GNU/Linux

> yay -Q opencv                                                                     ↵ 1
opencv 4.2.0-1

> pip3 show opencv-python
Name: opencv-python
Version: <IP_ADDRESS>
Summary: Wrapper package for OpenCV python bindings.
Home-page: https://github.com/skvark/opencv-python
Author: None
Author-email: None
License: MIT
Location: /home/sparky14145/.local/lib/python3.8/site-packages
Requires: numpy
Required-by:

> python -m manim -h
/usr/bin/python: No module named manim.__main__; 'manim' is a package and cannot be directly executed

Try python -m pip install manimlib

Try python -m pip install manimlib

Failed with the same information.

@zavden Oops, my pip equals to pip3.8.
Installation succeeded via pip2.7, but when I want to execute it...
$ python -m manim example_scenes.py SquareToCircle -pl
/usr/bin/python: No module named manim.__main__; 'manim' is a package and cannot be directly executed

$ python2.7 -m manim example_scenes.py SquareToCircle -pl
/usr/bin/python2.7: No module named manim

$ manim -h
Traceback (most recent call last):
  File "/home/sparky14145/.local/bin/manim", line 6, in <module>
    from manimlib import main
  File "/home/sparky14145/.local/lib/python2.7/site-packages/manimlib/__init__.py", line 2, in <module>
    import manimlib.config
  File "/home/sparky14145/.local/lib/python2.7/site-packages/manimlib/config.py", line 174
    print(f"Failed to render scene: {str(e)}")
                                            ^
SyntaxError: invalid syntax

First off:
MANIM ONLY WORKS ON PYTHON 3.7 AND ABOVE.
Python 2.7 is DEPRECATED and you should NOT be using it, especially after January 1 2020.
Now, try installing plain opencv by
pip3 install opencv-python and see if that works.
Remove the line about opencv in requirements.txt and install the rest of your requirements.

@Aathish04 I cloned the repository to local yesterday, ,with running python ./setup.py install --user(my default python is python3.8), and that works.

@Aathish04 I cloned the repository to local yesterday, ,with running python ./setup.py install --user(my default python is python3.8), and that works.

The repository version of manimlib is likely more often updated than the Pypi version.
Congrats!

Hello Everbody here,
Finished with satisfying every requirement :
pip3 install -r requirements.txt  Ignoring pycairo: markers 'sys_platform == "win32"' don't match your environment Ignoring pyreadline: markers 'sys_platform == "win32"' don't match your environment Requirement already satisfied: argparse==1.4.0 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 1)) (1.4.0) Requirement already satisfied: colour==0.1.5 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 2)) (0.1.5) Requirement already satisfied: Pillow==5.2.0 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 3)) (5.2.0) Requirement already satisfied: progressbar==2.5 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 4)) (2.5) Requirement already satisfied: tqdm==4.24.0 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 5)) (4.24.0) Requirement already satisfied: pycairo==1.17.1 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 6)) (1.17.1) Requirement already satisfied: pydub==0.23.0 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 8)) (0.23.0)
NOw what I have to do? I am confused as "manim" is not suggested in terminal.
Please help.

Hello Everbody here,
Finished with satisfying every requirement :
pip3 install -r requirements.txt Ignoring pycairo: markers 'sys_platform == "win32"' don't match your environment Ignoring pyreadline: markers 'sys_platform == "win32"' don't match your environment Requirement already satisfied: argparse==1.4.0 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 1)) (1.4.0) Requirement already satisfied: colour==0.1.5 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 2)) (0.1.5) Requirement already satisfied: Pillow==5.2.0 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 3)) (5.2.0) Requirement already satisfied: progressbar==2.5 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 4)) (2.5) Requirement already satisfied: tqdm==4.24.0 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 5)) (4.24.0) Requirement already satisfied: pycairo==1.17.1 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 6)) (1.17.1) Requirement already satisfied: pydub==0.23.0 in /usr/local/lib/python3.8/dist-packages (from -r requirements.txt (line 8)) (0.23.0)
NOw what I have to do? I am confused as "manim" is not suggested in terminal.
Please help.

First off, please make a new issue next time :)
I'm guessing you cloned the git repository, moved into the git repository and installed dependencies.
In that case, manim won't be installed as a command in the terminal.
Instead, there will be a file called manim.py inside the 'manim' folder.
That is your manim command from now on.
So, instead of manim my_animation.py, you will use python3 manim.py my_animation.py.
You can still use all the command line arguments that manim offers.

Thanks :+1:


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#512 059c133 Thanks @threepointone! - Update dependencies

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Implement --watch* arguments fot autotesting

Example:
$> nodeunit --reporter=minimal --watch=./lib --watch=./bin test
TODO: Implement --watch-compile argument for binary addons
P.S. I also lint some code with last Sannis/nodelint. Previous nodelint version has error with handling files with per-file JSLint options. I've already sent pull request, so don't worry if your make lint show some errors.

Looks like github bug. In any case, I've closed this pull request and will rewrite it from scratch.


feat: adding the feature upgrade_0_5_x for auto-upgrading from version 0.5.x to the higher version 0.6.x

:tada: This PR is included in version 0.6.0 :tada:
The release is available on:

0.6.0
GitHub release

Your semantic-release bot :package::rocket:


SNOW-992407: Use FileSet module without additional requirements

I'm finding the FileSet API really useful for jax/numpyro/pyro model development since I can use a torch dataloader and directly interface with snowflake without having to save anything locally. I'd love to not have to install pandas, sklearn, xgboost, lightgbm, and tensorflow in order to use the fileset api.
It would be great if this could have separate requirements, or be separated out, or have some of the clunky package requirements like those mentioned above be made optional

Hi kylecaron,
Currently pandas, sklearn and xgboost are hard requirements, but all others are extra requirements that means unless installing via pip install snowflake-ml-python[lightgbm], pip install snowflake-ml-python[tensorflow] or pip install snowflake-ml-python[all], they won't be installed.
You could use pip install snowflake-ml-python or conda install snowflake-ml-python if you don't want to install these extra dependencies. For details, please refer to our docs at https://docs.snowflake.com/en/developer-guide/snowpark-ml/index#installing-snowpark-ml .

are you still working on it? Can you work with dependencies on sklearn and xgboost?


IoTCoreDefaultApp is unusable on small IoT screens

I have an IoT LCD screen at the typical 800x480 resolution. At this resolution the default app is pretty much unusable, and several settings aren't possible because you just can't scroll to the content. The default app doesn't adapt it's layout very well at all to small screens.

Thank you for creating a fix for this!


Added OpenFGA's Python SDK

Signed-off-by: Andrés Aguiar<EMAIL_ADDRESS>

This relates to discussion #678


placement: fix placement location issue

What problem does this PR solve?
Fix https://github.com/pingcap/pd/issues/2601
What is changed and how it works?
Use DistinctScore way to compare placements.
Check List
Tests

Unit test

Related changes

Need to cherry-pick to the release branch

Release note

Fix the issue that when enable placement rules, sometimes replicas of region may not be able to adjust to the best location

Please take another look. @lhy1024 @JmPotato

LGTM


chore: add more vigilant checking to resolution

Resolves #100

Is this a hotfix and you'll write tests later or why are there no tests covering this?

Still working on the PR :D forgot to mark as draft


Youtube channel videos info

Checklist

[ x] I'm asking a question
[ x] I've looked through the README and FAQ for similar questions
[x ] I've searched the bugtracker for similar questions including closed ones

Question
How can I download list of videos with metadata from channel URL?
Is it possible to extract info about videos published by the channel without downloading videos via python API?

https://github.com/ytdl-org/youtube-dl/issues/28137


fix(components): components should follow MDC-Web naming convention

There is a lot of mismatching in Vue-MDC-Adapter component names with MDC-Web's components class names.
For instance, Vue-MDC-Adapter uses mdc-layout-cell while MDC-Web actually uses mdc-layout-grid-cell ("mdc-layout-grid__cell" class). VMA uses mdc-card-header while MDC-Web actually uses mdc-card-primary ("mdc-card__primary"). Also: mdc-card-text vs. mdc-card-supporting-text, mdc-card-action-button vs. mdc-card-action. It's worth to create a separate issue for each component with mismatching name.
It makes hard to assume what to use intuitively when people are coming from MDC-Web documentation.

outdated


Bump Player to 0.0.45

Bypassed merge queue because everything but FOSSA (presumed broken) is green and we haven't changed deps here anyway


VSTS Build Agents does not pick a enqueued Build

Environment
Server - VSTS
Account Name - portalprocfit.visualstudio.com
Agent - Private:
Agent Version - 2.131.0/2.134.2
Running On Windows 10 Pro - 1709
Issue Description
As of today, none of our agents pay build queued.
How do I diagnose this problem?
Things I've tried/checked

demands-although we do not make any changes regarding the demands of the build's definitions, much less in the demands of the agents, we validate them, and everything is correct.

I created new builds.

I added a new Agent with the version 2.134.2

I created builds of other definitions.

@victorperez2911 thanks for reporting this. i have asked our service team to take a look.
are those builds failed eventually (20 mins)? or it hanging there forever?

Yes @michVSTS and @TingluoHuang
Apparently everything works now.
Tks

cool. i am going to close the issue.


Offer possibility to skip unchecked snapshots

Summary
Solves https://github.com/facebook/jest/issues/6120
User can skip the unchecked snapshots error for a multibrand project.

Codecov Report

Merging #6125 into master will not change coverage.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master    #6125   +/-   ##
=======================================
  Coverage   64.21%   64.21%
=======================================
  Files         217      217
  Lines        8333     8333
  Branches        3        4    +1
=======================================
  Hits         5351     5351
  Misses       2981     2981
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-config/src/index.js
31.37% <0%> (ø)
:arrow_up:

packages/jest-jasmine2/src/index.js
15.09% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b6c65...a72cd5c. Read the comment docs.

Thanks for submitting a PR. I don't think this is the right solution and am worried about people abusing this flag and getting their project into an inconsistent state with many obsolete snapshots.
I recommend parameterizing your test rather than your config to avoid this problem.

Yes indeed, that doesn't seem a good solution because of the unhandled obsolete snapshots.
Though, I can't make my tests brand specific because a component can import theme from '@theme'; and this depends on the .babelrc
Unless there's a way to handle multibrand projects in jest and passing him a custom .babelrc (and my multibrand project is in 1 directory)?
To stay closer to the previous approach, we could have
config:
testNames: ['brand1', 'brand2'],

test
tree.toMatchSnapshot('brand1');

and jest would check if the snapshot matches the specified testName and look for unchecked that are not part of testNames.
Can I make a PR for that?


Segmentation fault on multiple runs

OS: macOS 10.14.5
Node version: 10.15.3
Ghostscript version: 9.27 (2019-04-04)
Electron version: 5.0.7
Ghostscript4js version: 3.1.1
I am converting postscript files to text files using the following:
gs.executeSync("-sDEVICE=txtwrite -dNOPAUSE -dQUIET -dBATCH \
    -sOutputFile=output.txt -sDEVICE=txtwrite input.ps");

It works the first time but my electron application crashes when I try to convert a second file.
The command runs fine on bash but gives a segmentation fault when I run it on Node REPL:
> const gs = require("ghostscript4js")
undefined
> gs.executeSync("-sDEVICE=txtwrite -dNOPAUSE -dQUIET -dBATCH -sOutputFile=job1.txt -sDEVICE=txtwrite job-1.ps")
undefined
> gs.executeSync("-sDEVICE=txtwrite -dNOPAUSE -dQUIET -dBATCH -sOutputFile=job2.txt -sDEVICE=txtwrite job-1.ps")
[1]    70491 segmentation fault  node

Note job2.txt was not created and it crashed after with a segmentation fault.

I see this happening on windows 10 with ghostscript 9.27 too. First run works like a charm, second run crashes app without any feedback.

Same problem. first run is okay second run crash the app without any feedback.
Ghostscript.version() :
{
  product: 'GPL Ghostscript',
  copyright: 'Copyright (C) 2019 Artifex Software, Inc.  All rights reserved.',
  revision: 950,
  revisiondate: 20191015
}

Hi @NickNaso
Do you have an idea how to fix this ? Or how to downgrade to 9.22 on macos (installed from brew) ?
I have only one version in /usr/local/Cellar/ghostscript/ and it's 9.50.
Thanks !

Hi @NickNaso
Do you have an idea how to fix this ? Or how to downgrade to 9.22 on macos (installed from brew) ?
I have only one version in /usr/local/Cellar/ghostscript/ and it's 9.50.
Thanks !

+1 on this on mac. On the second run it gives me
[1]    89399 segmentation fault  node --inspect index.js
@NickNaso thoughts?

Hi everybody,
I'm closing the issue because the release 3.2.0 should solve the problem.


Cross reference credhub documentation

Cross reference credhub documentation for additional details over credhub supported credentials types and their associated generation options

Thanks @gberche-orange!


bug

OS Version :MAC OS X10.13
ATOM Version: 1.25.0x64
bug :run atom about a hour ,he  is  Accidental withdrawal when i  edit file
i think it  can't  exit ,so  it's bug

Thanks for reaching out!
We require the template to be filled out on all new issues and pull requests. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:


Make Linux Template simpler/Have a gobject subclass FlutterApplication

Use case
Adding desktop-specific quirks more easily in the Flutter engine.

the titlebar is not needed on linux mobile environments like phosh, as the window isn't draggable and always maximised (so listening to XDG_CURRENT_DESKTOP and looking at a certain GSettings schema)
adding a headerbar manually if we're on GNOME (to integrate better into the platform style) (currently solved by having a code path in the template that forces a headerbar on wayland and strcmp the wm_name on X11) (I would like to change that for every flutter application, that the XDG_CURRENT_DESKTOP env variable is read instead)

Proposal
The template seems like it's doing more and more stuff. I'm proposing that we create a Subclass of GtkApplication called FlApplication symmetrical to FlutterActivity on Android. This subclass should be extensible (so not final), that application developers can still override all the behavior they want. But the _client code of the template should be moved into that.

I'm willing to implement this, just want to hear from someone if they are interested in this.

This is somewhat related/similar to https://github.com/flutter/flutter/issues/111453, could you check it and confirm?

It's related for sure, but only in the sense of making it easier to fix that issue.

Yes, this seems interesting. We'd be happy to look at a PR if you're interested in implementing it.
cc @robert-ancell

Sounds like a good idea to me!


GCP & AWS regions config

Possible to select regions (or all by default) to check.

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

GitHub release
v1.4.0

Your semantic-release bot :package::rocket:


WorkloadStore makes use of RwLock

No obvious improve, looks there is no race in the benchmark test

@hzxuzhonghu: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Configuration should accept "verify_ssl"

The Configuration does not accept optional "verify_ssl" parameter, it sets to True automatically.

Related to this, but all code examples on the site will currently fail due to AttributeError: type object 'Configuration' has no attribute 'verify_ssl' since rest.py explicitly tests against it: if configuration.verify_ssl:

@yhernandez01 you can do this
configuration.verify_ssl = False

Hi,
There is a simple workaround, and I'm not sure why you would want skipping SSL verification against datadog servers anyway. Thanks.


Error 404 when trying to start playback

Hello,
I can not start playback with the adapter.
There is always this error. However, the retrieval of playlists and devices works properly.

But the adapter was authorized correctly (at least that's what it tells me) and I have done the authorization again(including new application at Spotify Developer Dashboard).

If you have any questions or need more logs please contact me.
Otherwise I would be happy about a bugfix.
Edit: Sorry, didn't see the already opened issue on this problem... https://github.com/iobroker-community-adapters/ioBroker.spotify-premium/issues/178
Edit2: https://community.spotify.com/t5/Spotify-for-Developers/player-transfer-to-Echo-Dot-Groups-failing/td-p/5508585
This could help.. Spotify API is having problems with the new echo id style. They end with "_amzn_1"...

Spotify API had problems...


Add files via upload

Add HACF discord server and forums when creating new issue

Can you please make a link to the issue #56 in the PR description and edit your PR title to be more understandable.
FYI, the PR title will be reuse in the release note.

I did add an empty newline, but the checks still failed, not sure why

I did add an empty newline, but the checks still failed, not sure why

The last newline need to be empty. It's currently not.


CocoaPods Release

Would be awesome to see a CocoaPods release of this lib, as soon as CocoaPods (officially) supports Swift libraries.
http://guides.cocoapods.org/making/making-a-cocoapod.html

+1

See #4. Being worked on.

Resolved. Added and tagged the first version as 1.0.0.


FIR-1357-qa-deploy-fix

Move off deprecated endpoint rtm.start

I don't see an option to approve, just a straight merge. But, looks good to me.

is this just a typo "converstations"?

Nope. It's all about this https://api.slack.com/changelog/2021-10-rtm-start-to-stop#how (Retiring rtm.start's verbose response in September 2022
)


test: use Catch2 and cmake for runtime tests

This PR uses cmake and catch2 to organize all actively-maintained runtime tests:

Build all unit tests into a single binary
eBPF programs that these tests need would be compiled by CMake in a proper order
unit test programs will be able to find the ebpf programs automatically

So after this PR, we only need the following command to run runtime tests:
cmake -DBPFTIME_LLVM_JIT=YES -DBPFTIME_ENABLE_UNIT_TESTING=YES -DCMAKE_BUILD_TYPE=Release -B build
cmake --build build --config Release --target bpftime_runtime_tests
sudo ./build/runtime/unit-test/bpftime_runtime_tests

This PR also updates test-runtime.yml to adapt the new tests

Are the deleted old unit tests already covered by the new unit tests?
If not, I think before this pr gets merged, we need to add more tests to ensure the coverage.
You can add new unit tests in another PR?

I've covered all old unit tests that were enabled in runtime/test/CMakeLists.txt
Other remained test sources seem to be obsoleted. They were not listed in the CMakeLists, and would not be executed when running make unit-test. And some of them were not enable to run under the current bpftime(used outdated functions). I kept them here for future purpose(e.g migrate those tests to the new unit test framework)


OAuth auth block Type error

What happens?
The auth block at the top of the spec is broken!

I suspect it could be scope-related due to https://github.com/scalar/scalar/pull/4050?
For further context, my API is using OAuth2, and has a single scope.
What did you expect to happen?
I expected it to not have a type error!
OpenAPI Document
https://sandbox.scalar.com/e/srPSW

Thanks for the report!

For reference, this appears to have broken between<EMAIL_ADDRESS>and 1.25.72
I am able to get this section to display correctly by using 1.25.71, but the above error appears using 1.25.72 or later

For reference, this appears to have broken between<EMAIL_ADDRESS>and 1.25.72
I am able to get this section to display correctly by using 1.25.71, but the above error appears using 1.25.72 or later


@opentelemetry/exporter-metrics-otlp-proto is not sending metrics and failing on Unsupported Media Type errors

Please answer these questions before submitting a bug report.
What version of OpenTelemetry are you using?
"@opentelemetry/api": "1.0.4",
"@opentelemetry/api-metrics": "0.27.0",
"@opentelemetry/auto-instrumentations-node": "0.27.2",
"@opentelemetry/core": "1.0.1",
"@opentelemetry/exporter-metrics-otlp-proto": "0.27.0",
"@opentelemetry/exporter-trace-otlp-proto": "0.27.0",
"@opentelemetry/sdk-metrics-base": "0.27.0",
"@opentelemetry/sdk-node": "0.27.0",
"@opentelemetry/semantic-conventions": "1.0.1"

What version of Node are you using?
14.18.2
Please provide the code you used to setup the OpenTelemetry SDK
import { OTLPMetricExporter } from '@opentelemetry/exporter-metrics-otlp-proto';
import { Logger } from "../../types";
import { getAPICredentials } from "./utils";
import { OTLPExporterNodeConfigBase } from "@opentelemetry/exporter-trace-otlp-http";

export const getCustomTags = () => {
	return {
		'application': application_name,
		'organization': organization_name,
		'space': space_name,
		'version': application_version,
		'instance_guid': instance_guid,
		'instance_index': instance_index
	}
}

let exporter;

export const getExporter = (logger: Logger | Console = console): any => {
	if (!exporter) {
		const { url, APIToken } = getAPICredentials(logger);
		const config: OTLPExporterNodeConfigBase = {
			url: url + "/v2/metrics/ingest",
			headers: {
				Authorization: "Api-Token " + APIToken
			},
			attributes: getCustomTags(),
		}

		exporter = new OTLPMetricExporter(config);
	}
	return exporter;
}

What did you do?
Was trying to export custom metrics to dynatrace via this library. I configured a list of custom attributes, and provided the URL and API token in the headers
What did you expect to see?
The metrics in dynatrace
What did you see instead?
After debugging the code, I saw that I get "Unsupported media type" Issue.
According to my analysis, the request is sent with Content-Type 'application/x-protobuf' and with an empty buffer
Additional context
I do not show the metric exporting code itself, because everything worked with a different exporter (particularly this exporter: https://www.npmjs.com/package/@dynatrace/opentelemetry-exporter-metrics)
Can you please let me know if I'm doing anything wrong?

Hi @RubyKozel!
The DT metrics ingest endpoint you are using here is not an OTLP endpoint - it does not accept OTLP Protobuf (neither in binary nor JSON encoding) but a generic metrics ingestion format not related to OTel. The @dynatrace/opentelemetry-exporter-metrics package produces this generic metric ingestion format from OTel metrics and can be used with this API, please continue using this one instead.

Hi @arminru ,
Ok, I understand.
I see there's an option to initialize a Meter Provider via the Node SDK - will it be supported if I pass down the dynatrace exporter to the Node SDK initialization?

If you are referring to the @opentelemetry/sdk-node package that should work, but if it doesn't you should open an issue on the opentelemetry-js repository and mention me in it

Alright, thank you both @dyladan, @arminru !


inscrutable error

hello,
when trying to parse the CSV found here: https://www.bls.gov/cew/classifications/areas/county-msa-csa-crosswalk.htm
i encounter this error:
Error: Expected EOF, COLUMN_SEPARATOR, LINE_SEPARATOR; received
    at CSVReader.parseCycle (https://deno.land/x/csv@v0.6.0/reader.ts:334:13)

but there's no indication where the error is in the CSV. it works fine for an abridged version consisting of only the first three lines of the file. it's a big file (3000+ rows) so exhaustively retrying larger and larger substrings of the original file would be quite tedious. at a minimum, giving a line or column number for the error would be very helpful.
(and for what it's worth, my IDE CSV extension doesn't detect any errors in the file, so the error itself may be erroneous.)

looks like your file using \r\n line separator instead of default \n. you can configure line separator manually https://github.com/vslinko/deno-csv#read-csv-file-with-custom-separators


Missing Usage for C_PURORDMAINTAINHEADER

This is an issue for the Enable Custom Fields in the Purchasing Process SAP S/4HANA Cloud Extensibility Scenario. Please fill the issue details using a template below.
Describe the bug
The new custom field "Requisition Series" can't be found when the usage for C_PURORDMAINTAINHEADER isn't enabled.
To Reproduce
Steps to reproduce the behavior:

I'm following the above documentation on our S/4HANA 1909 SPS 01 on Premise System.
After step 8 of Create the Requisition Series Custom Field
I've continued with Add the Custom Field to the Manage Purchase Order App
In step 8 here the new custom field "Requisition Series" can't be found

Expected behavior
New custom field "Requisition Series" should be visible in the add field dialog
Fix
By activating the usage of C_PURORDMAINTAINHEADER:

the issue can be fixed.
Affected SAP S/4HANA version
S/4HANA 1909 SPS 01 on Premise System

Hi Gregor,
thanks for testing the sample scenario.
I have tested in 2 S/4Hana Cloud DLAB systems, but can't reproduce the issue which you have reported. i.e. the new created custom fields could be found as descreibed in step 8, even the C_PURORDMAINTAINHEADER is Disabled.
I notice that you are testing on S/4Hana 1909 which is an OP system, possibly the behavior is slight different as S/4Hana Cloud system. As the sample scenario is target to S/4Hana Cloud system, which indicates in the Prerequisites section of the Set Up Instruction. The steps for S/4 Hana OP system will not include in this set up instruction.
Let me know if you have questions.
kind regards,
Lina

Hi Lina,
I would suggest to add this as a delta in the Adapt Cloud Samples for Use in an SAP S/4HANA System On Premise documentation.
Best regards
Gregor

Hello Gregor
I followed steps given on my sandbox SAP S/4 HANA 1809 on Premise
https://help.sap.com/viewer/35ac276e62d945f39c0ed392c157e2a0/SHIP/en-US/ef43189b54ac4d1db37e7d27cd0671a0.html
I do not see custom field on Manage Purchase order apps while adding custom field in Adapt UI
and in Create Purchase Requisition (Advanced) apps, custom field tab seems not appearing
Procurement: Purchase Requisition Item : enabled
Purchase Requisition Item GUI (PR_ITEM_GUI)
Procurement: Purchasing Document : enabled
-Manage Purchase Order(MM_PUR_PO_MAINT_V2_SRV 0001)
-PO Maintenance: Purchase Order Headers (Active + Draft) ( C_PURORDMAINTAINHEADER)
Could you please suggest which step did I miss ? or I need to enabled more UI and reports in 1809 version
Thanks and Regards
Lal

Hi Lai,
please don't expect an answer from me. I'm not an SAP Employee and don't have access to an 1809 system where I could try it.
Best regards
Gregor


[Attestation] Adding minimal testing infrastructure

This PR adds minimal testing infra for the autogenerated SDK for the attestation service.

Thanks @willmtemple! I copied the encoding/decoding methods from core-http and did not pay much attention to what is inside. I will look into that.


Feature/referencecomponent

Basic function of single reference view  on click implemented.

Looks fine, but maybe it would be easier to create a reference details component with the styling (and the heading) like the one in Figma, and a canvas inside it, and then change the content of that canvas using the pdf.js code. Also, it would be good to make the canvas fit the sidebar, instead of it having the same width and height as the tooltip. Later we might want to introduce zooming and panning to that canvas element.


Update usage_and_examples.md

Summary

Updated a small typo in the documentation page.
Checklist

[ ] You agree with our CLA
[ ] Included tests (or is not applicable).
[ ] Updated documentation (or is not applicable).
[ ] Used pre-commit hooks to format and lint the code.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How are you creating files?

Hey, man.
I'm trying to follow your example in Controller to add a directory with a couple of files to Sage upon composer install (or whatever trigger you're using), and I'm not sure where else to get a hold of you :)
I can't for the life of me find where you're creating these folders and files.
Can you point me in the right direction? How are you doing this? It's cool and I want to do it, too!

Ugh. Never mind.


Consume contexts from packages (where possible) instead of copying

Switch to using the DCC context from NPM module, over at https://github.com/digitalcredentials/dcc#install
instead of the one embedded in src/contexts/

+1 to close.


error occurring when trying to checkout a project version

Hi, I just started out with defects4J, and I am trying to checkout the very first buggy version using Lang as an example.
I rundefects4j checkout -p Lang -v 1b -w Lang_1_buggy under folder Lang, and I have created Lang_1_buggy beforehand. Here is the output of the execution:
Init local repository...................................................... OK
Tag post-fix revision...................................................... OK
Excluding broken/flaky tests............................................... OK
Excluding broken/flaky tests............................................... OK
Excluding broken/flaky tests............................................... OK
Initialize fixed program version........................................... OK
Cannot determine how to apply patch!
All attempts failed:
* cd D:/defects4j/tmp/Lang/Lang_1_buggy; git apply -p1 --check D:/defects4j/framework/projects/Lang/patches/1.src.patch 2>&1
The filename, directory name, or volume label syntax is incorrect.
* cd D:/defects4j/tmp/Lang/Lang_1_buggy; git apply -p0 --check D:/defects4j/framework/projects/Lang/patches/1.src.patch 2>&1
The filename, directory name, or volume label syntax is incorrect.
* cd D:/defects4j/tmp/Lang/Lang_1_buggy; git apply -p2 --check D:/defects4j/framework/projects/Lang/patches/1.src.patch 2>&1
The filename, directory name, or volume label syntax is incorrect.
----------------------------------------------------------------------
 at D:/defects4j/framework/core/Vcs.pm line 404.
        Vcs::_apply_cmd(Vcs::Git=HASH(0x2c821a8), "D:/defects4j/tmp/Lang/Lang_1_buggy", "D:/defects4j/framework/projects/Lang/patches/1.src.patch") called at D:/defects4j/framework/core/Vcs.pm line 375
        Vcs::apply_patch(Vcs::Git=HASH(0x2c821a8), "D:/defects4j/tmp/Lang/Lang_1_buggy", "D:/defects4j/framework/projects/Lang/patches/1.src.patch") called at D:/defects4j/framework/core/Project.pm line 1044
        Project::apply_patch(Project::Lang=HASH(0x2b1ef00), "D:/defects4j/tmp/Lang/Lang_1_buggy", "D:/defects4j/framework/projects/Lang/patches/1.src.patch") called at D:/defects4j/framework/core/Project.pm line 477
        Project::checkout_vid(Project::Lang=HASH(0x2b1ef00), "1b") called at D:/defects4j/framework/bin/d4j/d4j-checkout line 96
        require D:/defects4j/framework/bin/d4j/d4j-checkout called at D:/defects4j/framework/bin/defects4j line 195
Compilation failed in require at D:/defects4j/framework/bin/defects4j line 195.

It seems that there are problems with git apply and I think the problem is that the patch file cannot be applied? However, I have no idea how to solve this.
Please offer me some suggestion on this! Thank you.
Regards,
Zhenming

Problem solved by switching from windows 10 to ubuntu. 🍻
Regards,
Zhenming


Validate that two RpcClients with the same cache directory are not causing race conditions when writing cached entries to disk

Definition of Done

Tests that validate that race conditions

Resolved in https://github.com/NomicFoundation/hardhat/pull/4345


avoid duplicate network name

这个 PR 实现什么功能/修复什么问题:
避免子网重名
是否需要 backport 到之前的 release 分支:

release/2.10.0
release/2.9.0
release/2.8.0

/cc @swordqiu @yousong

Codecov Report

Merging #1352 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1352      +/-   ##
=========================================
+ Coverage    7.75%   7.77%   +0.01%
=========================================
  Files         374     373       -1
  Lines       58702   58547     -155
=========================================
- Hits         4555    4551       -4
+ Misses      53745   53594     -151
  Partials      402     402

Flag
Coverage Δ

#aFlag
7.77% <ø> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/networks.go
0.97% <ø> (ø)
:arrow_up:

pkg/appsrv/response.go
66.15% <0%> (-3.08%)
:arrow_down:

pkg/cloudcommon/notifyclient/notify.go

pkg/util/seclib2/seclib.go
95.74% <0%> (+4.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c761777...a6c0979. Read the comment docs.

/lgtm
/approve


Setup Python remote debugging

We probably want to use debugpy for this.
We will need to make some decisions about how we want the students to hook into the code:

Just on breakpoint()
Manually?
Do we wait for the debugger to connect before starting the code.

More information on the available modes is available in the debugpy docs.

Need to have a look into debugpy as it seems to be specific to VS. PyCharm seems to use pydev. Might be able to provide both with a way to switch.
Breaking on first line is common in situations like this. Although, with the fact that we have the option to wait for the start button we might not need to worry about this too much. (That does then mean we can't debug anything that happens prior to wait_start())


Scene loses reference to the instanced scene when you reimport mesh which is present in instanced scene

Godot version
v4.1.1.stable.official [bd6af8e0e]
System information
Godot v4.1.1.stable - Windows 10.0.19044 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; <IP_ADDRESS>23) - AMD Ryzen 9 5950X 16-Core Processor (32 Threads)
Issue description
Scene loses reference to the instanced scene when you reimport mesh which is present in instanced scene
Steps to reproduce
https://github.com/godotengine/godot/assets/12017366/b1d78ebe-a386-4d60-a811-4d6b0afff535

Have 3 scenes that are instanced inside each other (scene, instanced_scene, torch), in the deepest one contains a mesh
Open scene, instanced_scene, torch scenes
Save scene, instanced_scene, torch scenes
Close instanced_scene, torch
Reimport said mesh
Open instanced_scene
See that there is no Open in Editor button
Move some other object in this scene
Save the  scene
You can't see the mesh in the scene and instanced_scene anymore

Minimal reproduction project
BrokenScene.zip

I can confirm this in current master branch. There might have been pretty similar / duplicate bug report somewhere, but I can't find it right now.

I am unable to reproduce this in Godot 4.2
@SaracenOne, do you know if you made a fix to this in 4.2? what pr might it be?


add I/O to nav

Nav needs an interface. This is something I'll need to tag up with @rankner7 about.

Closed because NavIO has been removed (inputs expected to be in correct format)


Switching to rocm_set_soversion for library versioning

Radha has this to be merged ASAP. I might not get this review if we are time constrained.

Adding this as a hotfix into master-rocm-2.7. Thanks Saad.


Seperate functions from systems

To make critical functions easier to benchmark and test, they should be decoupled from bevy so they can be run independently from it.

Raycasting logic broken out with #26


Python 3.7 runtime

Python 3.7 has been released on June 27th: https://www.python.org/downloads/release/python-370/
Pywren does not currently have a runtime for python 3.7:
> pywren create_config
No matching runtime package for python version  3.7
Python 2.7 runtime will be used for remote.

Ok we are on this.

We have added a 3.7 runtime to the default regions.

There are some major caveats with this runtime.

The minimum scipy version for py37 is 'scipy==1.1.0' (the old runtimes had 0.19.1) which unfortunately brings a lot of detritus (large shared objects). Even with a modified shrinkconda that aggressively removes sos. The runtime cannot be squeezed into the 512 MB disk space limitation. To remedy this the default runtime here does not include scipy. @shivaram @ericmjonas  any comments/ideas?

Could you provide a breakdown on how the size increases after shrinkconda has run with scipy 1.1.0 ? Is it close to 512MB or is it much bigger ? And if I'm right, we currently have no runtime for 3.7 right ? I'm trying to understand if this is a regression or a new but limited feature

No runtime for 3.7. So this a new but limited feature.

Currently its 551 MB.
Output of du -h --max-depth=3  | sort -h | tail -n30 for python3.6 vs python3.7 in /tmp/condaruntime

3.7:
620K    ./share/info
660K    ./lib/python3.7/pydoc_data
836K    ./include/python3.7m
908K    ./lib/tk8.6/demos
912K    ./share/man/man1
1000K   ./lib/python3.7/lib2to3
1.1M    ./lib/sqlite3.21.0
1.6M    ./include/openssl
1.6M    ./lib/tcl8.6/encoding
1.7M    ./lib/python3.7/idlelib
1.8M    ./lib/python3.7/encodings
1.9M    ./lib/python3.7/ensurepip
1.9M    ./lib/python3.7/__pycache__
1.9M    ./lib/tk8.6
2.4M    ./compiler_compat
2.4M    ./lib/tcl8.6
3.3M    ./lib/python3.7/distutils
4.4M    ./share/doc/openssl
4.7M    ./share/doc
4.9M    ./include
5.0M    ./share/man/man3
5.3M    ./conda-meta
5.4M    ./lib/python3.7/lib-dynload
6.2M    ./share/man
12M     ./share
16M     ./bin
143M    ./lib/python3.7/site-packages
170M    ./lib/python3.7
472M    ./lib
511M    .

3.6:
376K    ./ssl
380K    ./lib/python3.6/tkinter
436K    ./lib/python3.6/asyncio
492K    ./lib/python3.6/xml
512K    ./lib/tcl8.5/msgs
620K    ./lib/python3.6/email
636K    ./lib/python3.6/pydoc_data
748K    ./conda-meta
804K    ./include/python3.6m
840K    ./lib/tk8.5/demos
988K    ./lib/python3.6/lib2to3
1.2M    ./include/freetype2
1.4M    ./lib/python3.6/idlelib
1.6M    ./lib/tcl8.5/encoding
1.6M    ./share/doc
1.6M    ./share/doc/tiff-4.0.6
1.8M    ./lib/python3.6/encodings
1.8M    ./lib/tk8.5
1.9M    ./include/openssl
1.9M    ./lib/python3.6/__pycache__
2.0M    ./share
2.5M    ./lib/tcl8.5
3.3M    ./lib/python3.6/distutils
4.5M    ./lib/python3.6/lib-dynload
5.3M    ./bin
5.7M    ./include
169M    ./lib/python3.6/site-packages
192M    ./lib/python3.6
386M    ./lib
400M    .

I am not going to muck with the sos that the newer versions of numpy need. I think documenting this is the correct thing to do. If our runtime plans for 0.5 pan out this should be a non-issue in by v0.5.

I think the 3.7 runtime falls into the "new feature with limited capability' category. But it might still be worth discussing if we want to publish it at all given it might cause a regression experience. New users would likely opt for 3.7 as well.

do we have any survey of how many of our users use scipy? There was even discussion removing this from the default runtime...
I still think a working 3.7 runtime without scipy is much better than no 3.7 runtime.

I am not aware of any such surveys. I could be convinced that providing some runtime for 3.7 is better than having no runtime. Is there a way we could warn users if/when they try to use scipy with 3.7 ?

That would involve mucking with the serializer and would be very hacky.
I'd say we just document it in our documentation, and a quick google search will point people here.
We can print a warning during setup?

I'm going to close this issue and open a specific issue for adding scipy to 3.7 runtime.


Re-organize the code structure

Some .rs file contains more than one objects. It would be easier to browse them if they were organized in different .rs files.

Examples:
use openlimits::exchanges::binance::Client;

use openlimits::AnyExchange;

use openlimits::prelude::*;


[SPARK-38065][SQL] Improve the performance of DS V2 aggregate push-down

What changes were proposed in this pull request?
Currently, the build-in scan builder that implement SupportsPushDownAggregates has itself's config to control aggregate push-down.
We can advance the judgement of the config which controls aggregate push-down.
Why are the changes needed?
Improve the performance of DS V2 aggregate push-down.
Does this PR introduce any user-facing change?
'Yes'. This PR add a API enablePushAggregation in SupportsPushDownAggregates.
How was this patch tested?
Exists tests.

ping @huaxingao cc @cloud-fan


Widen bounds for data-default-class

Plus mafia bump and remove old 7.8.4 lockfiles. This is needed to play nice with client programs which depend on 0.1.*.
! @charleso @thumphries

👍


python3Packages.eth-utils: 1.8.4 -> 1.9.5

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110318 run on x86_64-darwin 1

3 packages failed to build and are new build failures:

python37Packages.manticore: log https://termbin.com/evxf
python38Packages.manticore: log https://termbin.com/tb19
python39Packages.manticore: log https://termbin.com/gjhi

19 packages built:

electrum
keepkey_agent (python38Packages.keepkey_agent)
python37Packages.eth-utils
python37Packages.keepkey
python37Packages.keepkey_agent
python37Packages.rlp
python37Packages.trezor
python37Packages.trezor_agent
python38Packages.eth-utils
python38Packages.keepkey
python38Packages.rlp
python38Packages.trezor
trezor_agent (python38Packages.trezor_agent)
python39Packages.eth-utils
python39Packages.keepkey
python39Packages.keepkey_agent
python39Packages.rlp
python39Packages.trezor
python39Packages.trezor_agent

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110318 run on x86_64-darwin 1

3 packages failed to build and are new build failures:

python37Packages.manticore: log https://termbin.com/evxf
python38Packages.manticore: log https://termbin.com/tb19
python39Packages.manticore: log https://termbin.com/gjhi

19 packages built:

electrum
keepkey_agent (python38Packages.keepkey_agent)
python37Packages.eth-utils
python37Packages.keepkey
python37Packages.keepkey_agent
python37Packages.rlp
python37Packages.trezor
python37Packages.trezor_agent
python38Packages.eth-utils
python38Packages.keepkey
python38Packages.rlp
python38Packages.trezor
trezor_agent (python38Packages.trezor_agent)
python39Packages.eth-utils
python39Packages.keepkey
python39Packages.keepkey_agent
python39Packages.rlp
python39Packages.trezor
python39Packages.trezor_agent

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110318 run on x86_64-linux 1

22 packages built:

electron-cash
electrum
electrum-ltc
keepkey_agent (python38Packages.keepkey_agent)
python37Packages.eth-utils
python37Packages.keepkey
python37Packages.keepkey_agent
python37Packages.manticore
python37Packages.rlp
python37Packages.trezor
python37Packages.trezor_agent
python38Packages.eth-utils
python38Packages.keepkey
python38Packages.manticore
python38Packages.rlp
python38Packages.trezor
trezor_agent (python38Packages.trezor_agent)
python39Packages.eth-utils
python39Packages.keepkey
python39Packages.manticore
python39Packages.rlp
python39Packages.trezor

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 110318 run on x86_64-linux 1

22 packages built:

electron-cash
electrum
electrum-ltc
keepkey_agent (python38Packages.keepkey_agent)
python37Packages.eth-utils
python37Packages.keepkey
python37Packages.keepkey_agent
python37Packages.manticore
python37Packages.rlp
python37Packages.trezor
python37Packages.trezor_agent
python38Packages.eth-utils
python38Packages.keepkey
python38Packages.manticore
python38Packages.rlp
python38Packages.trezor
trezor_agent (python38Packages.trezor_agent)
python39Packages.eth-utils
python39Packages.keepkey
python39Packages.manticore
python39Packages.rlp
python39Packages.trezor


HSEARCH-2091 Reuse the ElasticsearchIndexWorkVisitor

this is failing several tests! puzzling, I was also assuming it would be as simple as you made it.

The ExtendedSearchIntegrator which you are passing to the constructor of the Visitor isn't initialized yet.
This is only materialized after org.hibernate.search.backend.elasticsearch.impl.ElasticsearchIndexManager.setSearchFactory(ExtendedSearchIntegrator)

I guess you didn't test it?

Might have tested the wrong tree. Didn't surprise me it worked as I didn't think it might not.

np, it surprised me too :)

Time to commit https://github.com/hibernate/hibernate-search/pull/982 so that we can have CI in our forks :)!

Ok this is passing the tests, but now we're getting in trouble with concurrency.
Technically there are no issues: even if the indexWorkVisitor field is not marked 'volatile' that means that in worst case if there are multiple parallel operations entering method we'll be creating a couple additional ElasticsearchIndexWorkVisitor instances. With the current implementation this is not a problem as we know there aren't resources in there which wouldn't be cleaned up, but can we rely on that in the long term?
For example I expect that we'll be reusing the JestClient instance rather than keep requesting a new one from the ServiceManager, when we'll be more interested in performance. That day we might start leaking resources because the ElasticsearchBackendQueueProcessor will be at risk of not closing all the ElasticsearchIndexWorkVisitor it initialized.
The correct solution would be a volatile field and a double checked lock... hugh :-( I start thinking I'd rather keep @gunnarmorling 's original approach unless we can significantly change this area.
I'd highly prefer we could make sure that we have all what we need to initialize what we need at constructor time than using lazy initialization... or simply postpone this issue for "sometime in the future".

OK, closing for now.


create/skeletons: Add delimiters to archetype front matter

Fixes #12945

There's a Windows test failure. I think you can find a. unixtodos command in some of the golden text scripts that makes this ... work.

Just saw your previous comment. We now skip the comparison to golden on Windows. Let me know if that's not acceptable, but the newline difference is, in my opinion, immaterial to the underlying bug.

Thanks ... I'll do a patch release tomorrow.


opt(ti-community-infra/prow): move jobs from test-infra to prow

Signed-off-by: wuhuizuo<EMAIL_ADDRESS>

/approve


Support everything that vscode-dotenv plugin supports

https://github.com/mikestead/vscode-dotenv
nbd, amiright?

And perhaps match feature parity w https://github.com/bkeepers/dotenv ?

Yes, i think more integrations in the file are very good.

Version 2.0.0 is out with this included! https://www.nuget.org/packages/DotNetEnv/2.0.0/

I did not exactly match the ruby dotenv library. It turns out most of the dotenv libraries have subtle differences, and after reviewing them, I decided on the feature set I included in 2.0.0.


Panic if Git version is < GitVersionRequired

Panic during init() if Git version is < GitVersionRequired.
I have set the min version to 1.7.10 as required by SetDefaultBranch (https://github.com/go-gitea/git/blob/master/repo_branch.go#L58). I'm not sure why 1.7.10 is required for SetDefaultBranch, symbolic-ref has been in there for a while https://git-scm.com/docs/git-symbolic-ref/1.4.4.
Ref: https://github.com/go-gitea/gitea/issues/1133

build failed

LGTM

LGTM

PR good but seems LGTM is broken ?

LGTM bot is just slow sometimes, anyway PR is now ready to merge (although still w/out a unit test)

The arbitrary version number check does not allow running Gitea on Debian 6, please review #90 to also accept 1.7.0 instead


Disable retried application in mempool

The node will always retry block application, but mempool will optionally ignore blocks applied after retry.

@akoptelov
Will endorsement be added in the mempool for the block that was applied but ignored by the mempool? Probably not since precheck of prevalidator will be for current head in the mempool, not last applied block. Unless we can have endorsements for future blocks in the mempool.
https://github.com/tezedge/tezedge/blob/7259ce9ab2030a32ec5a187cff769885fb98531e/shell_automaton/src/mempool/mempool_reducer.rs#L464

@binier they will be in the mempool. This is a question if that is good or bad. Also cleaning up old endorsement doesn't look perfect to me. My point is that this fix is not the ultimate one. This is just to fix the issue we saw on tezedge.com, that caused node to hang. With this fix, the node won't hang in the same situation, it will not broadcast that problematic block. This is an improvement. There are still a lot of corner cases, I know, but I'm not aware of any serious flaw that is connected to this exact fix.

BTW, now I made that option false by default, so behavior will be just as it was before my previous fix, unless changed explicitly.


Bug - JPB Work environment section checkbox

Description
The selections that I made in the Our Physical Env, Technology, etc sections are not being reflected in my Preview of that section.
Images
As enter

Preview

[ ] Regression test written.

I could not reproduce this error.

it's possible that it was a connection / explorer issue, as the manager was having trouble with the JPB in general when she reported the error

Ok, I will close for now. Please Open a new issue if it comes up again (or re-open this).


Mark Various Functions, And Enums Public For On-Chain Price Calculations

Overview
While attempting to get various bid/ask prices on-chain through CPI I ran into a few different issues due to various functions and enums not being marked as public. As far as I can tell the updated visibilities I have included in this repo are all that is needed to access this information on-chain through other programs.

I've pushed another commit that marked some additional functions and the SlabHeader struct as public.

I have pushed another commit with some additional changes.


Ensure CMCD query argument is replaced

The query argument added by the CMCD connector is preserved in subsequent manifest/segment requests by THEOplayer, apparently leading to multiple CMCD arguments being accumulated, which is a problem as the URL grows indefinitely.
Using URLSearchParams set method, rather than append, ensures that the first CMCD argument is updated (the rest are removed) or one is appended.

Woops, good catch! Thanks for the contribution. 🙂