How can we run demo without Adobe training set?

Hi,
Apparently the original image training sets is not available to anyone not associated with a university.  Is there a way to run the demo at least without it.  You have graciously provided the trained model so why is the training data needed for processing new images?

The training data is not needed and you only have to provide an input RGB image, a trimap (320x320) and a trained model. You can modify the corresponding codes in "demo.py".

Does the image need to be 320X320? Can I run the code with the original image size?

you    could     .just      modify  demo.py

I am recreating the experiment, some questions I hope to be advised, this is my contact information.
my  address<EMAIL_ADDRESS><EMAIL_ADDRESS>,or  QQ<PHONE_NUMBER>

perhaps you can modify the input shape from (320, 320, 4) to (None, None, 4) in test?

@rainsun1 I faced a similar issue and I tried to modify input shape from (320,320,4) to (None,None,4) in models.py. But I get the following error:
ValueError: Tried to convert 'shape' to a tensor and failed. Error: None values not supported.

@ahsanbarkati Where does the error  come from? Is it in the shape computation from a layer?

Here is the complete log:
`ValueError                                Traceback (most recent call last)
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py in _apply_op_helper(self, op_type_name, name, **keywords)
510                 as_ref=input_arg.is_ref,
--> 511                 preferred_dtype=default_dtype)
512           except TypeError as err:
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py in internal_convert_to_tensor(value, dtype, name, as_ref, preferred_dtype, ctx, accept_symbolic_tensors)
1174     if ret is None:
-> 1175       ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
1176
/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/array_ops.py in _autopacking_conversion_function(v, dtype, name, as_ref)
1101     v = nest.map_structure(_cast_nested_seqs_to_dtype(dtype), v)
-> 1102   return _autopacking_helper(v, dtype, name or "packed")
1103
/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/array_ops.py in _autopacking_helper(list_or_tuple, dtype, name)
1052           elems_as_tensors.append(
-> 1053               constant_op.constant(elem, dtype=dtype, name=str(i)))
1054       return gen_array_ops.pack(elems_as_tensors, name=scope)
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/constant_op.py in constant(value, dtype, shape, name)
244   return _constant_impl(value, dtype, shape, name, verify_shape=False,
--> 245                         allow_broadcast=True)
246
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/constant_op.py in _constant_impl(value, dtype, shape, name, verify_shape, allow_broadcast)
282           value, dtype=dtype, shape=shape, verify_shape=verify_shape,
--> 283           allow_broadcast=allow_broadcast))
284   dtype_value = attr_value_pb2.AttrValue(type=tensor_value.tensor.dtype)
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/tensor_util.py in make_tensor_proto(values, dtype, shape, verify_shape, allow_broadcast)
453     if values is None:
--> 454       raise ValueError("None values not supported.")
455     # if dtype is provided, forces numpy array to be the type
ValueError: None values not supported.
During handling of the above exception, another exception occurred:
ValueError                                Traceback (most recent call last)
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py in _apply_op_helper(self, op_type_name, name, **keywords)
524               observed = ops.internal_convert_to_tensor(
--> 525                   values, as_ref=input_arg.is_ref).dtype.name
526             except ValueError as err:
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/ops.py in internal_convert_to_tensor(value, dtype, name, as_ref, preferred_dtype, ctx, accept_symbolic_tensors)
1174     if ret is None:
-> 1175       ret = conversion_func(value, dtype=dtype, name=name, as_ref=as_ref)
1176
/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/array_ops.py in _autopacking_conversion_function(v, dtype, name, as_ref)
1101     v = nest.map_structure(_cast_nested_seqs_to_dtype(dtype), v)
-> 1102   return _autopacking_helper(v, dtype, name or "packed")
1103
/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/array_ops.py in _autopacking_helper(list_or_tuple, dtype, name)
1052           elems_as_tensors.append(
-> 1053               constant_op.constant(elem, dtype=dtype, name=str(i)))
1054       return gen_array_ops.pack(elems_as_tensors, name=scope)
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/constant_op.py in constant(value, dtype, shape, name)
244   return _constant_impl(value, dtype, shape, name, verify_shape=False,
--> 245                         allow_broadcast=True)
246
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/constant_op.py in _constant_impl(value, dtype, shape, name, verify_shape, allow_broadcast)
282           value, dtype=dtype, shape=shape, verify_shape=verify_shape,
--> 283           allow_broadcast=allow_broadcast))
284   dtype_value = attr_value_pb2.AttrValue(type=tensor_value.tensor.dtype)
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/tensor_util.py in make_tensor_proto(values, dtype, shape, verify_shape, allow_broadcast)
453     if values is None:
--> 454       raise ValueError("None values not supported.")
455     # if dtype is provided, forces numpy array to be the type
ValueError: None values not supported.
During handling of the above exception, another exception occurred:
ValueError                                Traceback (most recent call last)
 in
1 model_weights_path = 'models/final.42-0.0398.hdf5'
----> 2 encoder_decoder = build_encoder_decoder()
3 final = build_refinement(encoder_decoder)
4 final.load_weights(model_weights_path)
5 #print(final.summary())
~/gits/Deep-Image-Matting/model.py in build_encoder_decoder()
65     the_shape = K.int_shape(orig_5)
66     shape = (1, the_shape[1], the_shape[2], the_shape[3])
---> 67     origReshaped = Reshape(shape)(orig_5)
68     #print('origReshaped.shape: ' + str(K.int_shape(origReshaped)))
69     xReshaped = Reshape(shape)(x)
/usr/local/lib/python3.5/dist-packages/keras/engine/base_layer.py in call(self, inputs, **kwargs)
458             # Actually call the layer,
459             # collecting output(s), mask(s), and shape(s).
--> 460             output = self.call(inputs, **kwargs)
461             output_mask = self.compute_mask(inputs, previous_mask)
462
/usr/local/lib/python3.5/dist-packages/keras/layers/core.py in call(self, inputs)
405
406     def call(self, inputs):
--> 407         return K.reshape(inputs, (K.shape(inputs)[0],) + self.target_shape)
408
409     def get_config(self):
/usr/local/lib/python3.5/dist-packages/keras/backend/tensorflow_backend.py in reshape(x, shape)
1934         A tensor.
1935     """
-> 1936     return tf.reshape(x, shape)
1937
1938
/usr/local/lib/python3.5/dist-packages/tensorflow/python/ops/gen_array_ops.py in reshape(tensor, shape, name)
7177   try:
7178     _, _, _op = _op_def_lib._apply_op_helper(
-> 7179         "Reshape", tensor=tensor, shape=shape, name=name)
7180   except (TypeError, ValueError):
7181     result = _dispatch.dispatch(
/usr/local/lib/python3.5/dist-packages/tensorflow/python/framework/op_def_library.py in _apply_op_helper(self, op_type_name, name, **keywords)
527               raise ValueError(
528                   "Tried to convert '%s' to a tensor and failed. Error: %s" %
--> 529                   (input_name, err))
530             prefix = ("Input '%s' of '%s' Op has type %s that does not match" %
531                       (input_name, op_type_name, observed))
ValueError: Tried to convert 'shape' to a tensor and failed. Error: None values not supported.`
The error is in this line: origReshaped = Reshape(shape)(orig_5)

You can look into the complete error log here: https://pastebin.com/2Pw1mVF2
The error is in this line: origReshaped = Reshape(shape)(orig_5)

The training data is not needed and you only have to provide an input RGB image, a trimap (320x320) and a trained model. You can modify the corresponding codes in "demo.py".

I have the image and trimap and also downloaded the pre-trained model. But I have no clue as to how to modify the demo.py to make it work for my own test. Also, like other people said, it will be nice to be able to change the image size as well. Can you provide another demo code for us to test when we don't have the Adobe datasets, a lot of us don't have it anyways. Thanks!

You have to change input shape of network and train the model and the height and widht of input shape should be equal.

If you need a larger size you are probably best to provide it in patches and then reconstruct it.  There are some pre-existing python modules to do so (https://github.com/adamrehn/slidingwindow for example) but it's pretty easy to write the loop to do it.

@rainsun1 I faced a similar issue and I tried to modify input shape from (320,320,4) to (None,None,4) in models.py. But I get the following error:
ValueError: Tried to convert 'shape' to a tensor and failed. Error: None values not supported.

If input is None, maybe you should use tf.shape[index] to compute, not tf.get_shape().as_list()

You can also construct the model with a large shape such as:
image_size = (800, 800)
input_shape = image_size + (4, )
model = build_encoder_decoder(shapeInput=input_shape)
after model prediction, you can crop the result into the original size of the image.


thread_local is not available on Visual Studio 12 2013 Update 4

I've been trying to compile for visual studio 12 2013 with Update 5, and have run into a few errors. Problems with noexcept and constexpr can be worked around with the CDS_XXX macros. thread_local seems to be the remaining compile issue. I'm wondering if a CDS_THREAD_LOCAL could be created which defaults to declspec(thread) on vc120? Are there cases where thread_local is used on non-POD types in libcds?

Minimal supported version is MS VC++ 14 (MSVS 2015)
https://github.com/khizmax/libcds/commit/7a934d9e64dc4a4c05dc8ac00fd8054fac809762

Ok thanks. You may want to update your Readme.md:
Version 2.x of the library is written on C++11 and can be compiled by GCC 4.8+, clang 3.6+, Intel C++ 15+, and MS VC++ 12 (2013) Update 4 and above

Yes, it is fixed in dev branch.
I'll merge to master after passing all tests.


[prime-factors] Implementation

See: https://forum.exercism.org/t/new-exercise-contributions/4077
Uses Prime::Factor

What does :

configlet / configlet Expected — Waiting for status to be reported

mean ?


Typeahead - Select an active item when closing the results dropdown

Is it possible to automatically select a highlighted item from typeahead's results dropdown when the dropdown is closed by clicking outside of the dropdown area?

Any updates on it? :) It would be much more user-friendly with this feature.

are sure it is a good UX?

Consider the possibility where there's no 100% match between the user input and predefined list of items. For example, user might enter just 3 first letters of a word. In this case, I can't get the resulting match from a typeahead.
I thought this would solve this problem. Currently user has to select manually a specific item from a dropdown menu.

ok, now seems I understood you
so if I enter 3 first letters, first mach should be active
than I press enter and gets selected
this is perfect use case
what I thought you asked initially
I have hovered some entry and pressed tab (or esc or click away) closing the results dropdown
and I need to select first active match

What about selecting the first match without hitting the enter? For example moving the foucus out from typeahead input by clicking outside or another button on a web page?

I think that an OnBlur event should do the trick, I'm creating a PR, adding OnBlur event to typeahead component which sends the active item as the $event. Will this suffice?

Any progress on this issue?

I was looking to do the same thing. Select the highlighted item (in this case, the active , which is usually the first one on the list) when you lose focus from the input- this occurs when you click outside of the input or dropdown. Any way to achieve this?

I did not find similar behavoir in autoselects, I suppose this will be not obvious UX


Consider tagging 0.1.0?

Very minor thing, but in using this library, I'd like to pin the dependency to the most recent release. Rather than specifying the hash (7f8daf7) for the 0.1.0 release, I'd prefer to specify the tag 0.1.0 to make the version-pinning-rationale a bit clearer. Any chance you could push a tag to the repo?

Any chance you could push a tag to the repo?

Of course! I pinned it down to the latest commit, the tag is "0.1.0".
Enjoy!

Thanks so much :)


[Add] : Add "Software Testing Mentor" YouTube channel for Learning Full Stack Testing Courses

Site URL
https://www.youtube.com/@softwaretestingmentor/videos
Description of the above provided site

Add "Software Testing Mentor" YouTube channel for Learning Full Stack Testing Courses.
This channel one of the Most Underrated YouTube Channel for Learning Testing Courses.

Category
Youtube
Sub Category
testing
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

Hi @NarendraKoya999, we appreciate your willingness to contribute in LinksHub but can you please summarize all this Resource addition resources in one issue and close all other? also, as i can see you are willing to work on each of them, could you please consider raising a single PR?

Ok. I can Understand @rupali-codes . I can Follow your Guidelines. If I have posted some Resources related to Same category .Then, I will Create a Single PR. Not Individual  PR's. Am I Right?

Ok. I can Understand @rupali-codes . I can Follow your Guidelines. If I have posted some Resources related to Same category .Then, I will Create a Single Issue and along with Create a Single PR on Particular That. Not to Create Individual Issues and PR's. Am I Right?. This time ,Please Considered Present assign pending Issues If Useful and Also I combine similar issues group them into a Single PR. Next time onwards, What we are discussed on guidelines, I strongly Follow them.

Hi @rupali-codes . Any update on my Quote?

Ok. I can Understand @rupali-codes . I can Follow your Guidelines. If I have posted some Resources related to Same category .Then, I will Create a Single Issue and along with Create a Single PR on Particular That. Not to Create Individual Issues and PR's. Am I Right?. This time ,Please Considered Present assign pending Issues If Useful and Also I combine similar issues group them into a Single PR. Next time onwards, What we are discussed on guidelines, I strongly Follow them.

Sure, thanks

@rupali-codes  .Who can Assigned my pending Issues. Because of in last week I created 7 to 10 Issues only related to YouTube Videos on Both Web Development and Testing Courses. If assigned, I create only two Individual PR's . One PR is on Web Development and Other one is Testing Related? . Kindly taken my Request into Consideration?

@rupali-codes .Who can Assigned my pending Issues. Because of in last week I created 7 to 10 Issues only related to YouTube Videos on Both Web Development and Testing Courses. If assigned, I create only two Individual PR's . One PR is on Web Development and Other one is Testing Related? . Kindly taken my Request into Consideration?

Yes you can go ahead with that

@rupali-codes .Who can Assigned my pending Issues. Because of in last week I created 7 to 10 Issues only related to YouTube Videos on Both Web Development and Testing Courses. If assigned, I create only two Individual PR's . One PR is on Web Development and Other one is Testing Related? . Kindly taken my Request into Consideration?

Yes you can go ahead with that

Thank You @rupali-codes


Files are only uploaded at the end of run

Weights and Biases version: 0.6.30
Python version: 3.6
Operating System: Ubuntu 18.04

Description
This is probably by design, so it is rather a question or feature request than a bug. Is there a way to upload files throughout a run? For me that would be useful in case a run crashes and also to download model parameters and test them locally or for visualization purposes while training is still ongoing.

0.6.30 automaticallu uploads any tfevents file as the run is progressing (we also automatically launch a tensorboard instance for you in our interface!).  Because of the way cloud storage works we have to re-upload the file as it changes.  In the tfevents case we have a backoff that re-uploads only after the file has grown by 20%.  I'm thinking I add an environment variable that allows you to specify a list unix globs to apply this same logic to.  Will your files grow, or just be created?

I'm not using Tensorflow/Tensorboard but guess I could still name my files *.tfevents? I was mainly asking because of model checkpointing (no modifications / growing files).

Ahh I see.  I've been thinking about checkpointing recently.  Here's a sketch of the interface I imagine:
wandb.init(ckpt_config={"glob": "*ckpt*", "last": 3, "best": "*best*"})

if args.resume:
    model.load(wandb.checkpoint())

Behind the scenes wandb would upload new files that match the glob described in ckpt_config.  We would only keep the latest 3 checkpoints in cloud storage.  We could then automatically download the checkpoint if you resume a training run.  In the case where you want to start a new training run from a previous runs checkpoint you could do something like:
model.load(wandb.checkpoint("username/project/run_id"))

The best argument would be to specify a glob to match a single checkpoint.  The usecase would be to only write this checkpoint if the model had improved.  I wonder if the usecase of grabbing any but the latest or best checkpoint is even worth supporting...  Would this approach solve your problem?

Would last=3 save the last three versions of of each file the matches a glob or would it save the three most recently written files matching the glob?
I don't know if i'd need a dedicated checkpointing api. A slightly extended file api would be enough (and more general). I'm already using the file download function similar to the way .checkpoint was used in your example. The thing that seems to be missing is something like a .flush() that triggers file uploads. Or even better: a wandb.upload function. The "keep the x-most recent versions" feature isn't that important for me personally (i'm fine with just having the most recent version) but this could also be passed as an extra argument. the best model could be saved under a different file name.

Cool, I was thinking last=3 would save the 3 most recently modified files that matched the glob.
I like the idea of a more generic file api.  We already have a wandb.save("path" or file) function, unfortunately that only pushes the file at the end of the run.  I think I'll make that upload the file immediately by default.  Then we could add wandb.load("path") to pull down the file when resuming.
Do you want this feature to resume from failure?  Would it be useful to be able to grab the most recent run with a given tag or the same model definition and pull down it's latest checkpoint?

Ah cool, that would be great! Resuming from failure would be great but for me (doing mostly deep RL research) it would be more complicated because I'd have to save the complete state of the learner/agent potentially include a replay memory which can be many GB large. Saving the model in case of crash / abort is currently mostly to save

Allright, I have a working prototype.  I'll push it to pypi in the next couple days, but if you want to try it you can install with: pip install --upgrade git+git://github.com/wandb/client.git@feature/save#egg=wandb
I made wandb.save accept a file name or a glob.  If the files it finds are outside of the run directory it symlinks them to it so they are saved.  It also makes them upload as they're written to by default.  There's also a wandb.restore function that accepts a file name.  It will download the file to the current run directory by default if it doesn't exist.  You can also restore files from other runs by passing run_path i.e.  username/project/run_id.  Let me know if you have any suggestions!

Perfect, thank you! That makes things much easier for me :) I'll try it out with my next batch of runs.

I just pushed 0.6.31, it contains the changes documented here: https://docs.wandb.com/docs/saving.html#saving-files-during-the-run

Hello!
I have the same problem: despite using wandb.save after every epoch only the first one is uploaded immediately.
My code looks as follows:
for epoch in tqdm.trange(args.num_epochs):
    trainer.train_epoch()
    model_path = Path(wandb.run.dir, "model.pt").absolute().__str__()
    torch.save(func_rep.state_dict(), model_path)
    wandb.save(model_path, base_path=wandb.run.dir)


Evaluate other documentation possibilities

Original issue: https://charm.cs.illinois.edu/redmine/issues/1927

Currently, Charm++ uses a documentation system built on top of Latex to create pdf and html manuals. We should  evaluate whether we can use a more modern system (e.g. pandoc/Markdown based, readthedocs.io, GitHub pages, ...).

Original date: 2018-07-18 19:14:32

Note that Juan has been using readthedocs.io for CharmPy documentation: https://charmpy.readthedocs.io/en/latest/

Original date: 2019-01-10 16:45:14

Patch to convert Latex to RST here:
~~https://charm.cs.illinois.edu/gerrit/c/charm/+/3624~~ https://github.com/UIUC-PPL/charm/commit/04bf65953b2d404a2002a1bec1a736883aed84b3


Package main typings resolution is not consistent with normal resolution

Don't know if this is intentional or is an unintended bug.
Currently if package.json/typings property is not specified, it defaults to read /index.d.ts, even if package.json/main is specified as things like dist/index.js.
In contrast, normal (relative) resolution would look for .d.ts next to the .js file.
Should tsc also tries to look up dist/index.d.ts in the above case?
This applies to 1.8 and 2.0.
Original conversation:
https://github.com/blakeembrey/make-error-cause/pull/12

i am sure there was an issue tracking this. but could not find it.


fix: remove unused folders

Days ago we refactored the themes to not use duplicated classes and merging the light with dark theme with one exclusive theme. The azion-theme.
The folders that are no used:
rm -rf src/primevue-sass-theme src/azion-dark src/azion-light

:tada: This PR is included in version 1.8.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Create a GitHub Issue Template.

People constantly open issues on the git/git-scm.com repository that
aren't actually relevant to the git-scm.com website. This introduces an
issue template which explicitly points people to the appropriate issue
tracker for the Git, Git for Windows, and Pro Git projects, so that anyone
who goes to open an issue on the git/git-scm.com issue tracker that
isn't about the website gets told where to go.

@peff hopefully this reduces false issues.

Thanks. I added a note to the repo description a while ago which helped, but I agree we still get a lot of misdirected reports. I'm a little lukewarm on template texts because they get annoying for people who are in the right place. But let's try this and see.

since it seems we still are getting some incorrect issues (very less often than before), i wanted to leave here this opinion on disabling GH issues: https://gist.github.com/ryanflorence/8a62abea562ca2896dee

Yeah, I saw that on HN the other day. I don't think we'd want to disable issues, though. While there are false positives, it still seems like a good mechanism for people to bring our attention to bugs on the site. Not everybody is capable of making a PR, and some of the problems aren't even with the site code itself (e.g., if the site were down, this is probably the best place to report it).


Change selected item to bold in menu bar

It would be nice PageController did this automatically, but how would I do it myself. If change the font when an item is selected it truncates the item text and if I try to make it update its layout it does funky this like take up more vertical space temporarily.

I'm sorry, very late.
I fixed by version 0.7.0.


Testspace Management for Travis CI

As suggestion by @mrocklin I am opening up an Issue to discuss how the Testspace.com technology could be used by the DASK team. We originally open an Pull Request that has been closed. Note that Testspace is completely free and does not affect the workflow.
Testspace is designed for managing test results -- consumes content generated from Travis jobs.

Failure Triage: When there are a lot of failures, or the log is very large, or the failures happen across a number of jobs, etc. it can be tedious to track them down. Testspace provides a flat list very quickly containing the stderr output, etc.
Example Travis Build Jobs with failures:

Same Build using Testspace failure filtering:

Metrics: All of the results generated from the CI are collected and persisted for history tracking. This includes test results, code coverage, static analysis, and any custom content. Along with this information, statistical analysis is used to calculate how effective the testing is and measures the workflow efficiency (rates for resolving Pull Requests and test failures).

For more details check out this LIVE DEMO: https://demo.testspace.com.

Test results, metrics, insights, provides more visibility to others -- new contributors, unfamiliar with Travis, non-dev types, managers -- and enables easier navigation on content.

My personal take is that I don't see a significant value over travis ci and coveralls that this service provides. Perhaps my opinion would change over time after using it, but on first glance I'm more happy with what I currently use. And while it's free and does not affect the workflow, it is One-More-Service™ to maintain and link to.
This is just my take though, other dask maintainers may have different opinions. I'll leave this open for other dask maintainers to give a quick vote, in particular @mrocklin, @TomAugspurger, @jakirkham, and @martindurant.

No preference.

From: Jim Crist<EMAIL_ADDRESS>Sent: Monday, August 6, 2018 6:32:53 PM
To: dask/dask
Cc: Tom Augspurger; Mention
Subject: Re: [dask/dask] Testspace Management for Travis CI (#3859)
My personal take is that I don't see a significant value over travis ci and coveralls that this service provides. Perhaps my opinion would change over time after using it, but on first glance I'm more happy with what I currently use. And while it's free and does not affect the workflow, it is One-More-Service™ to maintain and link to.
This is just my take though, other dask maintainers may have different opinions. I'll leave this open for other dask maintainers to give a quick vote, in particular @mrocklinhttps://github.com/mrocklin, @TomAugspurgerhttps://github.com/TomAugspurger, @jakirkhamhttps://github.com/jakirkham, and @martinduranthttps://github.com/martindurant.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/dask/dask/issues/3859#issuecomment-410885256, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABQHIgaNw6QdDDOZyWjgpDxxkFj7uoHQks5uONIlgaJpZM4VxLZL.

I share @jcrist's opinion here
On Mon, Aug 6, 2018 at 9:58 PM, Tom Augspurger<EMAIL_ADDRESS>wrote:

No preference.

From: Jim Crist<EMAIL_ADDRESS>Sent: Monday, August 6, 2018 6:32:53 PM
To: dask/dask
Cc: Tom Augspurger; Mention
Subject: Re: [dask/dask] Testspace Management for Travis CI (#3859)
My personal take is that I don't see a significant value over travis ci
and coveralls that this service provides. Perhaps my opinion would change
over time after using it, but on first glance I'm more happy with what I
currently use. And while it's free and does not affect the workflow, it is
One-More-Service™ to maintain and link to.
This is just my take though, other dask maintainers may have different
opinions. I'll leave this open for other dask maintainers to give a quick
vote, in particular @mrocklinhttps://github.com/mrocklin,
@TomAugspurgerhttps://github.com/TomAugspurger, @jakirkham<
https://github.com/jakirkham>, and @martindurant<https://github.
com/martindurant>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/
dask/dask/issues/3859#issuecomment-410885256>, or mute the thread<
https://github.com/notifications/unsubscribe-auth/
ABQHIgaNw6QdDDOZyWjgpDxxkFj7uoHQks5uONIlgaJpZM4VxLZL>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/3859#issuecomment-410907909, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszEWG1LYVIl7-DmPNAfFl9oGYvDuuks5uOPRYgaJpZM4VxLZL
.

I thought I would add a few quick comments.
First I appreciate you guys taking the time to provide feedback -- thank you! I certainly understand the One-More-Service issue.
Besides a Dashboard for failure triage we see the main purpose of Testspace is for collecting all of the data generated from the CI process and analyzing the content for patterns related to the efficiency of the workflow.  For example, we track all of the New PRs, Closed PRs, Rejected PRs, PR Comments, etc. We also track unique regressions generated as a result of Code Changes.  All of these measurements and there are many more, are being used to statistically assess the workflow.
We are still working on our analytics, and having feedback from the Dask team actually using the product, in our humble opinion, could benefit both teams.

Thanks for the explanation @munderseth. Based on the team's conversations here and offline, I think we're going to pass on this service for now. Best of luck with testspace, perhaps we'll decide to use it later on.


Refactor AKS Test - CaseID 217

The automated AKS test needs to updated since it fails when run in parallel nodes, should successfully create 2 clusters in the same RG
https://github.com/rancher/hosted-providers-e2e/actions/runs/11515508794/job/32074058341#step:17:195

I am working on this as a part of #190.


FIX: Group visibility for SITETREE_GRANT_ACCESS permissions

Make groups visible if member has SITETREE_GRANT_ACCESS permissions, otherwise the dropdown for selecting the group is empty

no worries, thanks.

It feels a bit strange giving blanket view access to groups like this... But I'm struggling to think of an alternative solution to this problem 🤔

Consensus seems to be that this is a good fix. Thank you for submitting this

Thank you very much!


(Re)name the shares

First of all, thank you for this excellent tool!
It works great!
I don have an issue as it is more a request.
I now have multiple shares connected and they all are named the same: <IP_ADDRESS>(NTDOMAIN) or IP(Domain), is there a way to give them the name of the shared folder (or rename them myself)?
Thank you.

Yes, I would like to be able to rename / alias shares too.
Thanks, Jerry

I would really love to see this implemented. My NAS has four shares that I use regularly but if I mount all four of them I can't tell the difference!!! I have to click each one to figure out which share it is. Thanks,


Potential OOM risks

com.alibaba.dubbo.common.threadpool.support.fixed.FixedThreadPool
return new ThreadPoolExecutor(threads, threads, 0, TimeUnit.MILLISECONDS,
              queues == 0 ? new SynchronousQueue<Runnable>() :
                      (queues < 0 ? new LinkedBlockingQueue<Runnable>()
                              : new LinkedBlockingQueue<Runnable>(queues)),
              new NamedThreadFactory(name, true), new AbortPolicyWithReport(name, url));

new LinkedBlockingQueue<Runnable>()；

If the queues is less than 0, then the workqueue is an unbounded queue, and oom may be triggered here

@chickenlj When the queue parameter is less than 0, how about throwing an exception directly, or setting a default queue size

@chickenlj When the queue parameter is less than 0, how about throwing an exception directly, or setting a default queue size

Or use synchronous queue

I don't think this is a problem.
You can find similar code in Executors.newFixedThreadPool(), also we'll set queue default to 0 and use SynchronousQueue if user is not specify the parameter.
You should set queue to a positive number if you want a bounded queue. And if you set this parameter to a negative number, you should know exactly what you are doing.

@kevinw66  Alibaba java development manual clearly points out that the reason why the thread pool provided by JDK can not be used is that it may cause oom. I think it should also be observed here. There is an old Chinese saying that "a gentleman does not stand under a dangerous wall". If I do not give a default size, the online environment may receive requests unlimited until oom

Alibaba java development manual clearly points out that the reason why the thread pool provided by JDK can not be used is that it may cause oom.

Agreed, and that's why we add queue parameter here to let user to choose which way they want to use, and set it default to 0 to use SynchronousQueue to prevent this situation if the user did not set value or didn't know the meaning of this parameter.
But we also keep the unbounded queue to let user choose if they do want to use, to meets all requirements.

@kevinw66  If it's to meet all the requirements, why can't workqueue be created by users themselves?

@kevinw66   Sorry, I just reviewed the source code carefully. You can use Dubo's extensionloader to extend and implement the ThreadPool interface to define the thread pool. However, I still think that there should be no oom risk in the default implementation here. Even if the user has different requirements, he can implement the ThreadPool interface to define the thread pool himself

In my opinion, if users define queues is less than 0, he should know what this means. As for framework, we make it default a safe value (0).

I will close the issues temporarily. If there are any problems, I can open the issues at any time.


TWCC: Fix small receive delta rounding

Prior to this change, a sequence of small receive deltas could get erroneously encoded as a series of 0s.
If the actual receive deltas were {200μs, 200μs, ..., 200μs}, what was appearing in the TWCC feedback packet (after marshaling) was {0, 0, ..., 0}. (Note: the added test, without the code fixes, would fail by returning deltas of {200, 200, ..., 200}, but marshalling the feedback packet would truncate all of those to 0).
To fix this, receive deltas are rounded to the closest "delta tick" period (250μs) as opposed to truncating. Additionally, lastTimestampUS is moved forward by the rounded delta instead of set to the timestamp of the last packet. This lets rounding errors accumulate so that a series of packets will have the correct sum of receive deltas (within the margin of error of a delta tick).

@boks1971 Thanks for the review, I made those changes.


update to use RegistryStorage from warg

Resolves this issue

Looking into the failing tests

Probably need to bump the server revision in the CI yaml.

FYI, now that warg-server can be used as a library, we should update the tests to run a server in-process and remove this extra dependency on having a warg-server on the PATH (and thus we wouldn't have to update the CI to ensure a matching server implementation).

@macovedj Thanks for fixing this!


fix: performance issue caused by the render calls

mactop has high CPU usage. Running it with cpuprofiling shows that the top CPU time is spent in the termui.Render calls (to be specific, in the ioctl syscalls there).
I removed a bunch of unnecessary Render calls (there were some duplicates) and replaced all the other calls with a throttled version: I call Render in the main process but not more often than twice in the single "update interval" period.
This should address issue #13.
P.S. It's my first contribution to the open-source project in a while, but I couldn't walk past 😊

LGTM, great job, thank you!


Error: gtk_main_quit: assertion 'main_loops != NULL'

When close window on i3: $mod+q
Peek error:
(deno:70428): Gtk-CRITICAL **: 19:15:12.704: gtk_main_quit: assertion 'main_loops != NULL' failed

It basically means that you've closed the window manually from outside neovim that's all. Should probably be silenced. Will give it a thought.


Trunk+VSCode on raspberry Pi 4 aarch64 fails

Hello,
I'm trying to use Trunk+VSCode in remote mode on a headless Pi 4 4GB and I get a mmap crash.
uname -m
aarch64

command -v trunk
/home/etu/.cache/trunk/launcher/trunk

trunk init
external/tcmalloc/tcmalloc/system-alloc.cc:662] MmapAligned() failed - unable to allocate with tag (hint, size, alignment) - is something limiting address placement? 0x241a40000000<PHONE_NUMBER><PHONE_NUMBER> @ 0x556cf3caa8 0x556cf3a740 0x556cf3a324 0x556cf29a78 0x556cf37638 0x556cf25ba0 0x556ca8230c 0x556bd3e618 0x556bd0b848 0x7fb427783c
external/tcmalloc/tcmalloc/arena.cc:64] FATAL ERROR: Out of memory trying to allocate internal tcmalloc data (bytes, object-size); is something preventing mmap from succeeding (sandbox, VSS limitations)? 131072 640 @ 0x556cf3d328 0x556cf29af4 0x556cf37638 0x556cf25ba0 0x556ca8230c 0x556bd3e618 0x556bd0b848 0x7fb427783c

Has anyone met the same issue ?
TIA,

Hi @platu! Sorry you're running into this. We haven't seen this issue before. Does this happen consistently? When you manually create a .trunk/trunk.yaml, e.g.:
version: 0.1
cli:
  version: 1.21.0
lint:
  enabled:
    - ...

does this issue still show up when you run trunk check -a?

Hello,
Thanks for your prompt reply. The memory allocation error happens whenever I try to run the trunk command, and whatever the option used.
I created the following .trunk/trunk.yaml file manually from another working repository on an amd64 host.
# To learn more about the format of this file, see https://docs.trunk.io/reference/trunk-yaml
version: 0.1
cli:
  version: 1.21.0
# Trunk provides extensibility via plugins. (https://docs.trunk.io/plugins)
plugins:
  sources:
    - id: trunk
      uri: https://github.com/trunk-io/plugins
      ref: v1.4.4
# Many linters and tools depend on runtimes - configure them here. (https://docs.trunk.io/runtimes)
runtimes:
  enabled:
    -<EMAIL_ADDRESS>    -<EMAIL_ADDRESS>lint:
  enabled:
    -<EMAIL_ADDRESS>
When I run the bash -x trunk ckeck -a command, I get :
 exec env TRUNK_LAUNCHER_VERSION=1.3.1 env TRUNK_LAUNCHER_PATH=/usr/local/bin/trunk /home/etu/.cache/trunk/cli/1.21.0-linux-arm64/trunk check -a
external/tcmalloc/tcmalloc/system-alloc.cc:662] MmapAligned() failed - unable to allocate with tag (hint, size, alignment) - is something limiting address placement? 0x250280000000<PHONE_NUMBER><PHONE_NUMBER> @ 0x5582decaa8 0x5582dea740 0x5582dea324 0x5582dd9a78 0x5582de7638 0x5582dd5ba0 0x558293230c 0x5581bee618 0x5581bbb848 0x7f8b43783c
external/tcmalloc/tcmalloc/arena.cc:64] FATAL ERROR: Out of memory trying to allocate internal tcmalloc data (bytes, object-size); is something preventing mmap from succeeding (sandbox, VSS limitations)? 131072 640 @ 0x5582ded328 0x5582dd9af4 0x5582de7638 0x5582dd5ba0 0x558293230c 0x5581bee618 0x5581bbb848 0x7f8b43783c

I couldn't find the repository from which I could compile the trunk binary on my Raspberry aarch64 host. Is it possible?

Hi! It looks like tcmalloc isn't universally supported on aarch64. I'll look into getting a fix out for you--should have updates shortly.

This issue is fixed in CLI version 1.22.0. Let me know if you have any other issues!


Fab disable color

This PR adds disabledBackgroundColor to FloatingActionButton and FloatingActionButtonThemeData.
I tried to look for specs for the default value at https://m3.material.io/components/floating-action-button but I didn't find anything. So I copied the logic of the ElevatedButton: The it is disabled, the color's opacity is set to 0.12.
I'm wondering if it wouldn't be better to make FloatingActionButton a ButtonStyleButton and use MaterialStateProperties. But it would be a breaking change. What do you think?
I also made the parameter onPressed non-required.
Should fix https://github.com/flutter/flutter/issues/76120
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I didn't write test yet, I would like to know what you think about this PR first, you might have another plan in mind (for example, should I go with MaterialStateProperties? If yes, do I implement it only for backgroundColor or the other parameters like foregroundColor, elevation etc)


ISS-526: Add dask functionality for rule operators

This PR:

Moves rule operators implementation from business rules to the engine. This should allow for easier updates
Creates a new type DaskDataframeType which utilizes much of the same functionality as the dataframe type.
Adds tests for both dask and the pandas dataframe types.

Steps to test:

Regression test validation functionality both full validation and test validation

@gerrycampion I don't know why I didn't think of this first, but do you think it would be better to implement the operators for the dataset abstraction instead of implementing them for each dataset library? This would mean we could easily add libraries without having to reimplement the operators. If you are ok with this I will move this work to the new dataset abstraction branch

We are going to implement 1 DataframeType class that implements all operators on our dataset abstraction. Closing and moving implementation to #536


Provide steps for compiling PyTorch custom-ops library against the nightlies

Is your feature request related to a problem? Please describe.
For new features that are getting added to PyTorch nightlies in the master branch, what is the mechanism to get corresponding nightlies for Nvidia optimized PyTorch so that one can compile the custom-ops library and run with Triton. At present unable to test https://github.com/lgray/pytorch_geometric/blob/jittable_geometric/examples/mnist_nn_conv_jit.py which requires the latest nightlies version of PyTorch with fix for torch.unique support (https://github.com/pytorch/pytorch/issues/37986)
Describe the solution you'd like
Please provide steps for how to do above
Describe alternatives you've considered
Could not find any other alternative
Additional context
Model above uses the pytorch_geometric abd related libraries from rusty1s. For your model to work in Python mode, please install latest Pytorch from the nightlies, and compile all the pytorch_geomtric libraries from source and then run the model on local first. Then try to get it to run on Triton

Triton releases monthly and uses the NGC version of pytorch that also releases monthly. Therefore Triton picks up new PyTorch changes when they make it into the NGC version of pytorch. These monthly releases are tested for stability and compatibility with the underlying CUDA, cudnn, cublas, etc. libraries.
The steps to build Triton are documented here: https://github.com/NVIDIA/triton-inference-server/blob/master/docs/build.rst. You can attempt to build triton using the master branch of pytorch and if it is successful you should be able to run your model.

Closing. Let us know if you have trouble following the build documentation.


Add SQS support

Add SQS support

Default Node Host Port : 9324
Management Http Host Port : 9325

Uh.. wow. I had no idea this existed!!


refactor: preventDefaultBehavior type

Setting a more general type union for preventDefaultBehavior, so it can be used everywhere
Fixing a typo and changing to a shorter, more descriptive name -> setFocusOnColumnAdjuster

:tada: This PR is included in version 2.6.8 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Possible name conflict when importing

Problem
A name conflict might happen when:

A. This plugin user do :import somewhere else.

B. We do :import in this plugin.

To Reproduce
Case A

Run vim --clean.

Source this script:
vim9script

set runtimepath=/tmp/.vim/plugged/vim9-stargate,/tmp/.vim/plugged/vim9-library
delete('/tmp/.vim', 'rf')
system('git clone https://github.com/monkoose/vim9-stargate.git /tmp/.vim/plugged/vim9-stargate')
mkdir('/tmp/.vim/plugged/vim9-library/import', 'p')
var lines =<< trim END
  " messages.vim
  vim9script
  export def StandardMessage()
    echomsg 'This is a standart message'
  enddef
END
writefile(lines, '/tmp/.vim/plugged/vim9-library/import/messages.vim')

import StandardMessage from 'messages.vim'
StandardMessage()

This error is raised from the last line:
E119: Not enough arguments for function: StandardMessage

While one would expect "This is a standart messages" to be echo'ed.

Case B

Run vim --clean.

Source this script:
vim9script

set runtimepath=/tmp/.vim/plugged/vim9-library,/tmp/.vim/plugged/vim9-stargate
delete('/tmp/.vim', 'rf')
system('git clone https://github.com/monkoose/vim9-stargate.git /tmp/.vim/plugged/vim9-stargate')
mkdir('/tmp/.vim/plugged/vim9-library/import', 'p')
var lines =<< trim END
  " messages.vim
  vim9script
  export def StandardMessage()
    echomsg 'This is a standart message'
  enddef
END
writefile(lines, '/tmp/.vim/plugged/vim9-library/import/messages.vim')

noremap \f <Cmd>call stargate#ok_vim(1)<CR>

Type \f.
A sequence of errors is raised, like this:
Error detected while processing /tmp/.vim/plugged/vim9-stargate/autoload/stargate.vim[4]../tmp/.vim/plugged/vim9-stargate/import/vim9000.vim[4]../tmp/.vim/plugged/vim9-stargate/import/galaxies.vim:
line    3:
E1048: Item not found in script: StandardMessage
Error detected while processing /tmp/.vim/plugged/vim9-stargate/autoload/stargate.vim[4]../tmp/.vim/plugged/vim9-stargate/import/vim9000.vim:
line    4:
E1048: Item not found in script: ChangeGalaxy
...

While one would expect stargate to be started.

Suggestion
First, to avoid the conflict in the case A, we can rename "import/" to "_import/", "private/", etc.:
import/galaxies.vim -> _import/galaxies.vim
import/messages.vim -> _import/messages.vim
import/stargates.vim -> _import/stargates.vim
import/vim9000.vim -> _import/vim9000.vim
import/workstation.vim -> _import/workstation.vim

And then use the relative path form for the script name when :importing in our scripts:
import { CreatePopups } from '../_import/workstation.vim'
import { OkVIM } from '../_import/vim9000.vim'
import { ChangeGalaxy } from '../_import/galaxies.vim'

Which avoids name conflict in the case B as a result.
If we want to supply "import/*.vim" as library scripts, then we can gather them in "import/stargate/" directory instead:
import/galaxies.vim -> import/stargate/galaxies.vim
import/messages.vim -> import/stargate/messages.vim
import/stargates.vim -> import/stargate/stargates.vim
import/vim9000.vim -> import/stargate/vim9000.vim
import/workstation.vim -> import/stargate/workstation.vim

So that user can import by using this handy form for the script name:
import ErrorMessage from stargate/messages.vim

This way, name conflict which user wouldn't expect will not happen, since the script name is prefixed with the "stargate/" namespace.
And then we should use the relative path form in our scripts as well:
import { CreatePopups } from '../import/stargate/workstation.vim'
import { OkVIM } from '../import/stargate/vim9000.vim'
import { ChangeGalaxy } from '../import/stargate/galaxies.vim'

Although we can use this form with no worry about name conflicts:
import { CreatePopups } from 'stargate/workstation.vim'
import { OkVIM } from 'stargate/vim9000.vim'
import { ChangeGalaxy } from 'stargate/galaxies.vim'

Because the relative path form is more efficient.
Additional context
If you wish, I'll create PR. Please let me know :)
Environment

Vim 8.2.3134
vim9-stargate https://github.com/monkoose/vim9-stargate/commit/e30bd1afa0bc8dc446f9836d46045eb11099cbfb
macOS Catalina (version 10.15.7)

Hello, thank you for this investigation. I have done 0 research how vim9 import works, thought it is plugin local only.
Will definitely fix this.

I think i will stick with 'private' version of _import, because of the naming conventions i'm not sure any of this plugin scripts has any value as some library. What do you think?

Hello, thank you for the reply and working on this issue.

I think i will stick with 'private' version of _import, because of the naming conventions i'm not sure any of this plugin scripts has any value as some library. What do you think?

Unfortunately, I don't have enough experience  to judge if using "private" is a good choice in terms of naming convention, but I could find a plugin which uses "private":
https://github.com/Bakudankun/qline.vim

Ok. Then i will just do _import to not clutch with user defined functions.
Thank you.
Also i have found that this repo uses import * as ..., so it is already implemented? Need to update my vim then.

Thanks for the fix!
Please note that we can rename the directory whenever we want, since the scripts are now almost private.

Also i have found that this qline plugin uses import * as ..., so it is already implemented?

Probably yes, let's try it out ;)


Filter is restricting button click in iOS devices

I am having a sortable List in each li I'm having div, inside each div I'm have buttons  and icons. I added the filter for that button and icon ID's, so that I can't able to drag by those.
When in iOS devices when I added filter that button was not clicking on the first click itself, i need to click for 4 or 5 times to execute that functionality. so how can I solve this issue?

Closed

@naveenbskn I ran into this as well. In my case adding preventOnFilter={false} to the ReactSortable element helped.


Feature Request: Winget ui link to app

Be able to send links to the wingetui app so I can send my friends applications to install.

Hard but why not

I'm not sure I understand what you want exactly, but you can share the install link with your friends by doing this:

It would be useful to have the option to export the scoop/winget install command tho, which would allow scoop to detect the install and also be able to share multiple apps at once.
Tbh my friends don't even know what is powershell/cmd, so I just send them the install link. =)

You mean like exporting an url such as wingetui:package_manager#package_id (example wingetui:winget#Google.Chrome or wingetui:scoop#scrcpy) that opened WingetUI and pointed to the app with the opened window, right?

You mean like exporting an url such as wingetui:package_manager#package_id (example wingetui:winget#Google.Chrome or wingetui:scoop#scrcpy) that opened WingetUI and pointed to the app with the opened window, right?

yes precisely I feel like it would help get my friends into using winget more instead of potential getting a virus do to their muscle memory


Fixing Python 3 support, supporting JSON lists and a few other improvements

Hey Varun! I had to procrastinate a bit for an afternoon and I thought I'd fix a few things in json2html. Here are the changes in order of importance. Could you have a look?
In any case Happy Holidays to everyone who reads this in time.

Top level JSON lists now supported by modularising unifying the underlying functionality.
Python 3 support ; Added integration tests for Python 2.6, 3.4 and 3.5 such that support doesn't break.
Output now should always appear in the same order as input.
Better error message on misbehaving input.
Convert now accepts unicode and bytestrings for the keyword argument "json".
Test output files now accept newlines and indentation (will be removed before comparing to result)

Hey @muellermichel
I really appreciated the work done. Thanks for sparing some time and adding support for python 3 and other misc items. I'm glad you owned it up on your own. 👍
I was going through the code and it looks good to me.
I spent some time after a long time to understand the old code of mine which at times used to support OrderedDict too and your recent changes. I even tried a couple of examples myself to see the output. Following are my findings:

It still doesn't output in the given order.

>>> json2html.convert(json = {"name": "Varun", "age": 24})
u'

age	24

name	Varun

'
>>>

I tried

>>> json2html.convert( json = [] )
>>> json2html.convert( json = {} )

Both throw ValueError because of my bad written code :: Line 54.
How about changing it to:
if 'json' in kwargs and (isinstance(kwargs['json'], list) or isinstance(kwargs['json'], dict)):

and adding a piece of code from Line 112 onwards:
if isinstance(json_input, dict) and len(json_input.items()) == 0:
            return ''

This will support empty list and empty dict, which it should be and both will return '' as the output.
What are your thoughts on this?
I can own this up if you are satisfied with these changes.

Can you see the latest commits? I think most of your other points are obsolete. About the positioning: You'll have to use OrderedDict yourself instead of a normal dictionary, otherwise Python will not guarantee the order after the object has been initialised. If you pass your example as a string, json2html v1.1 will do the right thing.


Update doc: using-controller-manager-with-kubeadm

What this PR does / why we need it:
Update documentation using-controller-manager-with-kubeadm.
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

cc @dims @hogepodge

/lgtm
/approve

/test cloud-provider-openstack-acceptance-test-e2e-conformance


NPC's that are related to physics in any way are broken

The moment the turret tries to shoot, it falls and dies.
Manhacks became just stupidly slow.
Scanners seem to be absolutly disoriented, they do backflips and bumb into walls.
Rollermines dont roll.
Combine Mines cant fling themselves towards the player.

hunter choppers and gunships also sometimes fail for no reason, since sometimes they work and sometimes they don't
dropships also sometimes freeze in mid-air


POC: SMPC evaluation

Demo of SMPC evaluation.
**Blocked by: #204 #206 #205 #200 #207 #210 **

Same demo presented in this blogpost but using grid workers:

We'll use a grid worker as a model host that wants to keep the model safe (users don't know what the model looks like).
We'll use several grid workers as possible users that want to get predictions from this model in a private way (the model host doesn't know what the user's data looks like)

Acceptance criteria:

A jupyter notebook with detailed instructions of what each step is doing.
A live demo of a website running this application.

As per our chat on slack, I will like to take this up.

I will like to start working on this. Any pointers will be helpful :).

Hi @Quisher,
We need to solve the linked issues, I'm working with @IonesioJunior on this but help is always welcome.
I'm working at #204, #205, #206 which involve non-encrypted hosting/querying models.
In order to have encrypted hosting/querying models I think we first need a POC of this using just Syft with websockets. Let me know if this seems interesting to you, feel free to ping me at slack!

This task has been completed, right @mari-linhares ?


React Router not working on page refresh

Tried to add 404.html but it still doesn't work as it should - description here.
And using HashHistory is not an option for this project.

React Router dropped in #14


Parse the protobuf file to JSON so users can read the file

Problem
The file updates to special files on the network (150, 111, 121, etc) require the file format to be in protobuf. When users see the file update transaction in the home screen they need a way to view the contents of the protobuf file.
Solution
Parse the protobuf file to JSON and provide a way for the user to read it.
Alternatives
No response


panel active not disabled between views

When calling loadContent between views, the last active panel in the view stays active. There will be 2 active panels.
The panel that does not deactivate never will become deactive when transitioning between pages.
This happens by clicking a footer link <a href="#somepage".. or by using $.afui.loadContent

This was an issue posted before, and I don't think it was ever resolved. However, I did link a comment to an existing pull request posted in April #850 .
the update to af.ui.js adds to the runTransition function and removes the active class if found. it works, but it requires a transition to be set when calling the panels, and not sure if it's the best solution.

Just added the code.. works great. Thanks so much!

The side effect is that it hides the background panel when calling a panel within a modal view. Not a big deal though.. I will look into fixing that in a bit

@seekchange  @tahoetomahawk  - can either of you put up demo's showing the bug and how it's resovled with that pull request/  I'll be happy to merge it.

I used the pull request code as a workaround. It's not quite a resolution
but it gets the job done for now.
Let me know if you still need a pull request, we can put together a sample.
On Mon, Jun 8, 2015 at 10:42 AM, Ian Maffett<EMAIL_ADDRESS>wrote:

@seekchange https://github.com/seekchange @tahoetomahawk
https://github.com/tahoetomahawk - can either of you put up demo's
showing the bug and how it's resovled with that pull request/ I'll be happy
to merge it.
—
Reply to this email directly or view it on GitHub
https://github.com/01org/appframework/issues/873#issuecomment-110089011.

@tahoetomahawk - I'm fine accepting the pull request that is there.  I've just been asking for demos/tests to show the error and that it has been resolved.

I will include a page with multiple views that shows the issue later this
evening.
On Mon, Jun 8, 2015 at 12:59 PM, Ian Maffett<EMAIL_ADDRESS>wrote:

@tahoetomahawk https://github.com/tahoetomahawk - I'm fine accepting
the pull request that is there. I've just been asking for demos/tests to
show the error and that it has been resolved.
—
Reply to this email directly or view it on GitHub
https://github.com/01org/appframework/issues/873#issuecomment-110120966.

@tahoetomahawk : Please upload your solution. I have tried code from #850  but problem is still there.
@imaffett : Can you please look in to this bug as this is pending from a long time & we are not able to migrate our AF2.2 apps to AF3 just because of this issue. Thanks.

@manish-stack - no one has given me demos/tests/etc

Hi guys,
I haven't uploaded tests. The work around did not work completely, I found
another issue with it. The on panel load gets triggered, but never the
unload. It looks like the bug happens with transitioning between views, not
panels.
Everything seems to work fine within the same view, but using multiple
views things start to break.
The way that headers and footers are defined at the view level forced me to
have to create multiple views. I'm redesigning my UI and creating my own
Footer I can use on certain panels so I can put everything into the same
view.
On Mon, Jul 27, 2015 at 7:32 AM, Ian Maffett<EMAIL_ADDRESS>wrote:

@manish-stack https://github.com/manish-stack - no one has given me
demos/tests/etc
—
Reply to this email directly or view it on GitHub
https://github.com/01org/appframework/issues/873#issuecomment-125226247.

Folks, this is really a huge problem we ran into. However, after including these lines from the pull request that @tahoetomahawk mentioned (where were removed in this request, for whatever reason???) at the beginning of runTransition() in  appframework.ui.js at line  1218, it works:
        	if (typeof previous !== "undefined" && previous !== null) {
                if(previous.find) {
                    setTimeout(function(){
                        previous.find(".active").removeClass("active");
                    },500);
                }
            }

@jdinse I appreciate it's a huge problem but look at my previous comments. Not one person has given me a demo to test against.  All people say is "it doesn't work fix it".
If this fixes your case, open up a pull request and I'll merge it, but you need a demo/test to show it working.

Jay, that work around was not sufficient as the panelunload was not being
called when transitioning from 1 view to another. If you don't need
panelload or panelunload then you should be fine.
On Wed, Jul 29, 2015 at 6:49 AM, Jay Dinse<EMAIL_ADDRESS>wrote:

Folks, this is really a huge problem we ran into. However, after including
these lines from the pull request that @tahoetomahawk
https://github.com/tahoetomahawk mentioned (where were removed in this
request, for whatever reason???) at the beginning of runTransition() in
appframework.ui.js at line 1218, it works:
        if (typeof previous !== "undefined" && previous !== null) {
            if(previous.find) {
                setTimeout(function(){
                    previous.find(".active").removeClass("active");
                },500);
            }
        }

—
Reply to this email directly or view it on GitHub
https://github.com/01org/appframework/issues/873#issuecomment-125958399.

@tahoetomahawk I found out that it is caused by the fifth Parameter (anchor) in function loadContent(). It changes the current view to what the anchor belongs to for the transition. Therefore it tries to unload the wrong view. Look at lines 1014 ff. in function loadDiv():
        //check current view
        var currentView;
        if(anchor){
            currentView=this.findViewTarget(anchor);
        }
        else
            currentView=this.findViewTarget(this.activeDiv);

So the workaround for me was to not use these fifth parameter right now.

Good find, thanks!!
On Thu, Aug 27, 2015 at 3:21 AM, Jay Dinse<EMAIL_ADDRESS>wrote:

@tahoetomahawk https://github.com/tahoetomahawk I found out that it is
caused by the fifth Parameter (anchor) in function loadContent(). It
changes the current view to what the anchor belongs to for the transition.
Therefore it tries to unload the wrong view. Look at lines 1014 ff. in
function loadDiv():
    //check current view
    var currentView;
    if(anchor){
        currentView=this.findViewTarget(anchor);
    }
    else
        currentView=this.findViewTarget(this.activeDiv);

So the workaround for me was to not use these fifth parameter right now.
—
Reply to this email directly or view it on GitHub
https://github.com/01org/appframework/issues/873#issuecomment-135373136.


events.out.tfevents file is getting too large as training continues

Tensorboard event file is getting too large (> 10Gig) as the training continues. I use custom estimator and input_fn reads data from a generator. Everything works fine except this huge tensorboard file that I think it also reduces the speed. When I increase save_summary_steps parameter, this problem doesn't go away. I have seen other blogs complaining about it and none of them provided a viable solution for it.
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): tensorflow-gpu==1.12.0
tensorflow==1.13.1
tensorflow-estimator==1.13.0
Python version: Python 3.5.2
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: CUDA 9
GPU model and memory: Tesla M40 24GB or Nvidia Geforece GTX 1080Ti

@mhajiaghayi ,
In order to expedite the trouble-shooting process, please provide a code snippet to reproduce the issue reported here. Thanks!

`  def inputFn(self,tasks, mode, params= None):
types = ((tf.string,tf.string,tf.float32),tf.float32)
shapes = ((None,None,None),None)
datasets = []
for task in tasks:
    dataset = tf.data.Dataset.from_generator(
                        functools.partial(task.relevanceDb.batchGen,self.args,mode),
                        output_shapes=shapes, output_types=types)
    datasets.append(dataset)
    choice = tf.data.Dataset.range(len(datasets)).flat_map(self.getBatch).repeat(self.args.maxSteps)
    multiDataset = tf.data.experimental.choose_from_datasets(datasets,choice)
multiDataset = multiDataset.batch(self.args.batchSize).prefetch(1) `

@mhajiaghayi Can you please provide the github gist of the code that you are working with. Thanks!

@mhajiaghayi Can you please post this issue in Tensorflow/Tensorboard as this issue is related to Tensorboard and you can  get a fast reply. Also Please take a look at this issue which is quite similar to yours. Thanks!


[Bug]: Only loads when Remindertab is open

Describe the bug
Recently, the reminder pop-ups only load when the reminder tab is actively open.
Expected Behavior
The pop-ups should also trigger without an active reminder tab, as they used to.
Steps to reproduce

Operating system
Linux

Same issue with same operating system
Digging a little bit deeper, this error shows up in console log:
Uncaught (in promise) TypeError: view.reload is not a function
    at eval (plugin:obsidian-reminder-plugin:16775:38)
    at Array.forEach (<anonymous>)
    at ReminderListItemViewProxy.reload (plugin:obsidian-reminder-plugin:16775:15)
    at ReminderPlugin.eval (plugin:obsidian-reminder-plugin:17008:22)
    at Generator.next (<anonymous>)
    at eval (plugin:obsidian-reminder-plugin:50:61)
    at new Promise (<anonymous>)
    at __async (plugin:obsidian-reminder-plugin:34:10)
    at ReminderPlugin.periodicTask (plugin:obsidian-reminder-plugin:17007:12)
    at ReminderPlugin.startPeriodicTask (plugin:obsidian-reminder-plugin:16988:10)

I have this issue as well. No reminders are popping up, ever. Console log is filled with this error. Windows 11, Reminder V1..1.15, Obsidian v1.7.7

Could you try to use v1.1.16?

It's fixed in v1.1.6, thanks for the prompt @uphy


[bug] init.py and pycache gets listed in background images list

It looks like pygame_gui.windows.UIFileDialog only distinguishes between files and directories, not between files with different extensions.  Luckily, wm.py checks the format in set_bg_image before loading the image, so choosing a non-image file doesn't break anything.
A simple fix would be to move the images to a separate directory.  That way, if the user really wants to select __init__.py, (a) they have to do so intentionally and (b) it still has no effect.  More extensive changes could include displaying an error and/or reopening the file dialog if the file is not accepted, or perhaps modifying/subclassing UIFileDialog to add a file extension filter.


Error when drawing circles on Map

Hi,
I think there is some error with the drawing circles on the Map. There were no circles created (only drop pins after releasing the mouse) but no error messages were given. When I tried to clear features from the Map, I received this error:
`There was an error creating Earth Engine Feature.
ValueError                                Traceback (most recent call last)
G:\My Drive\CFLUX\DayCentAU\Miniconda\envs\dca\lib\site-packages\geemap\geemap.py in handle_draw(target, action, geo_json)
519                 if action == "deleted" and len(self.draw_features) > 0:
--> 520                     self.draw_features.remove(feature)
521                     self.draw_count -= 1
ValueError: list.remove(x): x not in list
During handling of the above exception, another exception occurred:
Exception                                 Traceback (most recent call last)
G:\My Drive\CFLUX\DayCentAU\Miniconda\envs\dca\lib\site-packages\geemap\geemap.py in handle_draw(target, action, geo_json)
547                 self.roi_end = False
548                 print("There was an error creating Earth Engine Feature.")
--> 549                 raise Exception(e)
550
551         draw_control.on_draw(handle_draw)
Exception: list.remove(x): x not in list
There was an error creating Earth Engine Feature.
AttributeError                            Traceback (most recent call last)
G:\My Drive\CFLUX\DayCentAU\Miniconda\envs\dca\lib\site-packages\geemap\geemap.py in handle_draw(target, action, geo_json)
535                 else:
--> 536                     self.substitute_layer(self.draw_layer, ee_draw_layer)
537                     self.draw_layer = ee_draw_layer
G:\My Drive\CFLUX\DayCentAU\Miniconda\envs\dca\lib\site-packages\ipyleaflet\leaflet.py in substitute_layer(self, old, new)
2169             new = basemap_to_tiles(new)
-> 2170         if old.model_id not in self._layer_ids:
2171             raise LayerException('Could not substitute layer: layer not on map.')
AttributeError: 'NoneType' object has no attribute 'model_id'
During handling of the above exception, another exception occurred:
Exception                                 Traceback (most recent call last)
G:\My Drive\CFLUX\DayCentAU\Miniconda\envs\dca\lib\site-packages\geemap\geemap.py in handle_draw(target, action, geo_json)
547                 self.roi_end = False
548                 print("There was an error creating Earth Engine Feature.")
--> 549                 raise Exception(e)
550
551         draw_control.on_draw(handle_draw)
Exception: 'NoneType' object has no attribute 'model_id'
There was an error creating Earth Engine Feature.
AttributeError                            Traceback (most recent call last)
G:\My Drive\CFLUX\DayCentAU\Miniconda\envs\dca\lib\site-packages\geemap\geemap.py in handle_draw(target, action, geo_json)
535                 else:
--> 536                     self.substitute_layer(self.draw_layer, ee_draw_layer)
537                     self.draw_layer = ee_draw_layer
G:\My Drive\CFLUX\DayCentAU\Miniconda\envs\dca\lib\site-packages\ipyleaflet\leaflet.py in substitute_layer(self, old, new)
2169             new = basemap_to_tiles(new)
-> 2170         if old.model_id not in self._layer_ids:
2171             raise LayerException('Could not substitute layer: layer not on map.')
AttributeError: 'NoneType' object has no attribute 'model_id'
During handling of the above exception, another exception occurred:
Exception                                 Traceback (most recent call last)
G:\My Drive\CFLUX\DayCentAU\Miniconda\envs\dca\lib\site-packages\geemap\geemap.py in handle_draw(target, action, geo_json)
547                 self.roi_end = False
548                 print("There was an error creating Earth Engine Feature.")
--> 549                 raise Exception(e)
550
551         draw_control.on_draw(handle_draw)
Exception: 'NoneType' object has no attribute 'model_id'`

This an ipyleaflet bug https://github.com/jupyter-widgets/ipyleaflet/issues/876. There is not much I can do about it. You can either downgrade ipyleaflet to v0.13.3 or wait until ipyleaflet to fix the bug.

it might be useful to leave this issue open for discoverability until its fixed upstream :)


Tail of StorageClass and finalizer

Discoblocks creates storageclass on topology bases. The created StorageClass has finalizer just like any other. But during DiskConfig deletion we remove finalizers of SCs. When customer recreates the config with same name and storageclass, Discoblocks re-uses the existing SC, but don't append finalizer! Not a big drama, just we loose the protection of those SCs.

https://github.com/ondat/discoblocks/pull/86


Add ProgressBar component

A simple progress bar component

Implemented in https://github.com/Bastian/dapper-ui/commit/039f5200af7d32e28a85b94250d149ba5e8a6c89


No search results

As illustrated in the last OA call there seems to be a hard-to-reproduce problem with searching resources. Sometimes, the search results list is empty no matter what is being search for. Logging in and logging out fixed the problem (Brave browser)

I just tested it with a freshly installed Chrome browser - could not reproduce the problem.


Include usual Sphinx search in the sidebar

Is it possible to include the usual Sphinx search box in the sidebar?
Actually I am not sure what the RTD search actually does.
E.g. I am an astropy user and tried searching "astropy" and "wcs" here with zero results:
http://readthedocs.org/docs/astropy/en/latest/
See https://github.com/astropy/astropy/issues/81
Here you mention that the RTD search is supposed to be a full-text search across all projects hosted at RTD:
http://read-the-docs.readthedocs.org/en/latest/features.html#search
Clearly it isn't, and I'm not sure if that would be terribly useful.
What I need all the time is the usual Sphinx search within the project.
Thanks for making readthedocs!

Yea, this is a problem with the code that handles auto-indexing new projects. If you use a custom theme, it should revert back to sphinx search. I can also make a way to choose this option in the UI or something. Sorry it is mostly broken at th emoment. I will force a reindex that should hopefully fix the current issue.

Thanks, Eric!
From the discussion on the mailing list, I think the astropy guys really like the RTD theme, so if possible the best solution would be RTD theme with usual Sphinx search box (i.e. only within the astropy project, not across all projects hosted at RTD) in the sidebar.
Btw, is it possible / legal to use the RTD theme locally?
If so, is there a description which files / configs have to be set up?

I tried the following searches on 'wcs', a module in astropy:
http://readthedocs.org/docs/astropy/en/latest/search.html?q=wcs
http://readthedocs.org/search/project/?q=wcs&selected_facets=project%3AAstropy
http://readthedocs.org/search/project/?q=wcs
The first one are the usual Sphinx search results, quite useful in this case.
The second one are the RTD side bar search results for the astropy project, quite confusing in this case in my opinion.
The third one is the search executed when using the RTD search field at the top, it gives an error message 'Something's wrong. Fail. Check back in a bit!'
So besides this error, could you add a short description of what the RTD search actually does and why it might be better / more awesome than the usual Sphinx search (within a project, obviously being able to search all projects at once can be useful). At the moment the search description doesn't say what RTD search does:
"We provide full-text search across all of the pages of documentation hosted on our site. This uses the excellent Haystack project and Solr as the search backend. We hope to be integrating this into the site more fully in the future."

I had a look at the Fabric docs, all they had to do to use RTD locally is include _static/rtd.css in their project and add these lines to their Sphinx conf.py:
html_theme = 'default'
html_style = 'rtd.css'
html_static_path = ['_static']

So what do you mean by 'break out the RTD theme', what actually needs to be done?
For us users the best solution would be to get the RTD style included in Sphinx as one of the default styles, I guess, given that it is so nice and almost all of the current Sphinx styles are not.
But I don't know if you at RTD want that or if you want to reserve that look for your hosted docs.


add script to get approved nodes list

PR adds script to read the approved nodes list

Closing in favor of the other PR: https://github.com/onflow/flow-core-contracts/pull/254


READ.ME

Hello From The Edge Of The Universe! Welcome to My page. I'm glad you're here as I'm new to coding and can either get help constructive criticism or hopefully some praise although I must admit the wonderful people here have been the ones completing My work. Where as much as I appreciate it I NEED TO do things on My own and get My hands dirty to learn exactly what I'm doing. Anyways it's nice to see you so sit back relax grab a nice cold beverage or maybe it's time for hot cocoa and message Me and I should message you back very soon. Thanks again and have a stellar day!- SINcerely, **Charlie Baker_**PhD

Please sign your name here if you've visited My site

Please sign your name here if you've visited My site


add start/stop AD job api

*Issue #11
Description of changes:
Add start/stop AD job apis
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

What would happen if the Job is already started, do we disable on UI also how does backend handle this ?

Will disable update on UI and we have check from backend, will block updating detector if job is running.


Visibility & overflow

Describe the bug
lazysizes should check for visibility != hidden & not outside overflow hidden
To Reproduce
<div container>
    <img lazyloaded>
    <img lazyloaded>
</div>

What is the expected behavior
Lazyload only if image is not visibility hidden & inside of div container, if container has overflow hidden.
What happened instead
Images are always lazyloaded
In what environment (browser/device etc.) does this bug happen/not happen:
All

I check for these things. You can see the visibility and the overflow nesting. However the overflow nesting is only checked on positioned elements (i.e.: elements that don't have position: static).
If lazysizes sees those images they are loaded with a lower priority compared to really visible images. But they are should be loaded because they might come into view soon and the user shouldn't be watching how the images he/she wants to see loading.
For the visibility check you can simply set the loadHidden option to false and for the nested overflow visibility you could add the data-expand="10" attribute. But really I wouldn't do this under normal situations. It doesn't give you a better performance and decreases the user experience.


Word filler

In certain cases, an element filling the word count to certain number could be useful:

If you have set some target length for your story and its individual parts. For example, you like to write 30k novel, you have an outline with 30 elements, and you would like every element to become a 1k text block.

Let's consider to make an element to fill the missing words.

This is duplicate, see: https://github.com/mkoskim/mawejs/issues/85


MolVS 0.1.0 Standardization fails on Python 3

Hi Matt, a bug report for something I've noticed in the latest release.
The standardize_smiles, Standardizer().tautomer_parent and Standardizer().standardize functions all fail because of line 133. These all work okay in 0.0.9
>>> mol = Chem.MolFromSmiles('[Na]OC(=O)c1ccc(C[S+2]([O-])([O-]))cc1')
>>> Standardizer().standardize(mol)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/standardize.py", line 98, in standardize
    mol = self.normalize(mol)
  File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py", line 105, in __call__
    return self.normalize(mol)
  File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py", line 124, in normalize
    fragments.append(self._normalize_fragment(fragment))
  File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py", line 133, in _normalize_fragment
    for n in six.moves.range(self.max_restarts):
NameError: name 'six' is not defined

I had a look at the file and it seems that the 'import six' line is missing. When this is added, I get another error, but I think this may be a Py2 vs Py3 difference:
>>> Standardizer().standardize(mol)
Traceback (most recent call last):
 File "<stdin>", line 1, in <module>
 File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/standardize.py", line 98, in standardize
   mol = self.normalize(mol)
 File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py", line 106, in __call__
   return self.normalize(mol)
 File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py", line 125, in normalize
   fragments.append(self._normalize_fragment(fragment))
 File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py", line 137, in _normalize_fragment
   product = self._apply_transform(mol, normalization.transform)
 File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/utils.py", line 28, in fget_memoized
   setattr(self, attr_name, fget(self))
 File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py", line 42, in transform
   return AllChem.ReactionFromSmarts(self.transform_str.encode('utf8'))
Boost.Python.ArgumentError: Python argument types in
   rdkit.Chem.rdChemReactions.ReactionFromSmarts(bytes)
did not match C++ signature:
   ReactionFromSmarts(char const* SMARTS, boost::python::dict replacements={}, bool useSmiles=False)

When I move ".encode('utf8')" from line 42 it works as expected in Py3, but I think this would probably produce an error on Py2.
Hope this helps, thanks for working on this, it's been really useful!
EDIT: I see that these changes are already reflected in the file on GitHub, it seems that the PyPI version is just a bit out of date

Weird, the import six line definitely should already be there:
https://github.com/mcs07/MolVS/blob/v0.1.0/molvs/normalize.py#L19
Likewise I think the string encoding for py2/py3 was fixed while ago:
https://github.com/mcs07/MolVS/commit/0e96acf9527c55a72b5ec6d385b6a779d9927b61#diff-36072b6ed94d3d5dd8829d1effae2cd5
How did you install MolVS? Is it possible you have an older version? What do you see if you do:
>>> import molvs
>>> molvs.__version__
'0.1.0'

Might be worth trying to uninstall and install again.

Yeah, I was confused too, so I tried the reinstall a few times (pip install molvs==0.1.0 and pip install molvs==0.0.9). I'll try clearing the cached version and see if it makes a difference
[  2:23pm ]  [ travis@mljet:~ ]
 $ pip install molvs==0.1.0
Collecting molvs==0.1.0
  Using cached MolVS-0.1.0-py3-none-any.whl
Requirement already satisfied: six in ./anaconda3/envs/rdkit/lib/python3.6/site-packages (from molvs==0.1.0)
Installing collected packages: molvs
  Found existing installation: MolVS 0.0.9
    Uninstalling MolVS-0.0.9:
      Successfully uninstalled MolVS-0.0.9
Successfully installed molvs-0.1.0
[  2:23pm ]  [ travis@mljet:~ ]
 $ python
Python 3.6.4 |Anaconda, Inc.| (default, Jan 16 2018, 18:10:19)
[GCC 7.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import molvs
>>> molvs.__version__
'0.1.0'
>>> exit()
[  2:23pm ]  [ travis@mljet:~ ]
 $ cat /home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py | grep "import six"
[  2:23pm ]  [ travis@mljet:~ ]
 $

Yeah, even with a forced reinstall I'm getting the same issue, it must just be the PyPI package
[  2:23pm ]  [ travis@mljet:~ ]
 $ pip install -I --no-cache-dir molvs==0.1.0
Collecting molvs==0.1.0
  Downloading MolVS-0.1.0-py3-none-any.whl
Collecting six (from molvs==0.1.0)
  Downloading six-1.11.0-py2.py3-none-any.whl
Installing collected packages: six, molvs
Successfully installed molvs-0.1.0 six-1.11.0
[  2:26pm ]  [ travis@mljet:~ ]
 $ python
Python 3.6.4 |Anaconda, Inc.| (default, Jan 16 2018, 18:10:19)
[GCC 7.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import molvs
>>> molvs.__version__
'0.1.0'
>>> molvs.standardize_smiles('c1ccccc1')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/standardize.py", line 305, in standardize_smiles
    mol = Standardizer().standardize(mol)
  File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/standardize.py", line 98, in standardize
    mol = self.normalize(mol)
  File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py", line 105, in __call__
    return self.normalize(mol)
  File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py", line 124, in normalize
    fragments.append(self._normalize_fragment(fragment))
  File "/home/travis/anaconda3/envs/rdkit/lib/python3.6/site-packages/molvs/normalize.py", line 133, in _normalize_fragment
    for n in six.moves.range(self.max_restarts):
NameError: name 'six' is not defined

Oh dear, yes there's definitely something wrong specifically with the wheel file on PyPI. I've removed it, so pip should use the source distribution instead, which looks fine to me.

That's great, thanks for your quick response! Everything seems to be working perfectly now, I'll close this issue

Great, I have just had the same issue and this fixed it. Cheers guys


The xilinx_dsp packing register mechanism changes memory_pass.memory_dff behaviour when flattening

Steps to reproduce the issue
Using a modified excerpt of Marlann memory output -> DSP input as example (zip file), execute the following command:
synth_xilinx -abc9 -flatten -top testcase

Zip file:
testcase.zip
Expected behavior
The memory_pass.memory_dff merges the $dff cell to $memrd, so 2 RAMB36E1 can be used when using flatten.
Actual behavior
A total of  256 RAM128X1D are inferred when using -flatten only, due xilinx_dsp packing $dff from memory output that also connects to B input of DSP48E1, when enables are involved in any way.
Technical Details
When flattening:
Before  executing xilinx_dsp pass, the following Verilog excerpt generates the processes/cells that are showed in the Image 1
   always @(posedge clk) begin
      m_vec <= mem[rbuff0[64:0] + K]; // $memrd
      K <= rbuff0[127:62] + rbuff0[63];
   end

Image 1:

After executing xilinx_dsp,  the $procff$45 (which is the FF connected to the output of the $memrd cell) is used in ffB2:
23. Executing XILINX_DSP pass (pack resources into DSPs).
Analysing testcase.$techmap\mult.$mul$testcase.v:41$30.sliceA[2].mul.sliceB[2].mul for Xilinx DSP packing.
preAdd:     --
ffAD:       -- -- --
ffA2:       $procdff$46 -- --
ffA1:       -- -- --
ffB2:       $procdff$45 -- --  <--- Here
ffB1:       -- -- --
ffD:        -- -- --
dsp:        $techmap\mult.$mul$testcase.v:41$30.sliceA[2].mul.sliceB[2].mul
ffM:        -- -- --
postAdd:    $techmap$techmap\mult.$mul$testcase.v:41$30.sliceA[2].mul.$add$/opt/eda/fpga/FOSS/tests/binaries/bin/../share/yosys/mul2dsp.v:201$72
postAddMux: --
ffP:        -- -- --
overflow:   --
  postadder $techmap$techmap\mult.$mul$testcase.v:41$30.sliceA[2].mul.$add$/opt/eda/fpga/FOSS/tests/binaries/bin/../share/yosys/mul2dsp.v:201$72 ($add)

Therefore, in memory pass, the memory_dff is unable to merge the $memrd output dff cell:
29. Executing MEMORY pass.

29.1. Executing MEMORY_DFF pass (merging $dff cells to $memrd and $memwr).
Checking cell `$memwr$\mem$testcase.v:23$24' in module `\testcase': merged $dff to cell.
Checking cell `$memrd$\mem$testcase.v:18$17' in module `\testcase': no (compatible) $dff found.  <- Here

This makes memory_bram pass to use lutram instead of block rams, due the change of read transparency behavior from the rd port of the memory:
Bram pass:
Write port #0 is in clock domain \clk.
        Mapped to bram port B1.
      Read port #0 is in clock domain !~async~.
        Bram port A1.1 has incompatible clock type.
        Failed to map read port #0.

Lutram pass:
Mapping to bram type $__XILINX_RAM128X1D (variant 1):
      Write port #0 is in clock domain \clk.
        Mapped to bram port B1.
      Read port #0 is in clock domain !~async~.
        Mapped to bram port A1.1.
      Creating $__XILINX_RAM128X1D cell at grid position <0 0 0>: mem.0.0.0
      [...]

When no flattening:
Since xilinx_dsp does not touch anything outside mult block, the $45$dff is not packed into DSP input port:
Before running xilinx_dsp:

The $45$dff is not packed by xilinx_dsp:
23. Executing XILINX_DSP pass (pack resources into DSPs).
Analysing $paramod\mult_pipe\W=128.$mul$testcase.v:40$29.sliceA[2].mul.sliceB[2].mul for Xilinx DSP packing.
preAdd:     --
ffAD:       -- -- --
ffA2:       -- -- --
ffA1:       -- -- --
ffB2:       -- -- -- <--- Nothing
ffB1:       -- -- --
ffD:        -- -- --
dsp:        $mul$testcase.v:40$29.sliceA[2].mul.sliceB[2].mul
ffM:        -- -- --
postAdd:    $techmap$mul$testcase.v:40$29.sliceA[2].mul.$add$/opt/eda/fpga/FOSS/tests/binaries/bin/../share/yosys/mul2dsp.v:201$71
postAddMux: --
ffP:        -- -- --
overflow:   --
  postadder $techmap$mul$testcase.v:40$29.sliceA[2].mul.$add$/opt/eda/fpga/FOSS/tests/binaries/bin/../share/yosys/mul2dsp.v:201$71 ($add)

Memory pass is able to merge $45$dff cell:
29.1. Executing MEMORY_DFF pass (merging $dff cells to $memrd and $memwr).
Checking cell `$memwr$\mem$testcase.v:23$24' in module `\testcase': merged $dff to cell.
Checking cell `$memrd$\mem$testcase.v:18$17' in module `\testcase': merged data $dff to cell.

Therefore, BRAMS are used instead of LUTRAMS:
When not  flattening:
   Number of wires:                556
   Number of wire bits:           7517
   Number of public wires:          20
   Number of public wire bits:    2257
   Number of memories:               0
   Number of memory bits:            0
   Number of processes:              0
   Number of cells:               1825
     BUFG                            1
     CARRY4                        128
     DSP48E1                        32
     FDRE                          680
     LUT2                          982
     RAMB36E1                        2

When flattening:
   Number of wire bits:           7612
   Number of public wires:          16
   Number of public wire bits:    1745
   Number of memories:               0
   Number of memory bits:            0
   Number of processes:              0
   Number of cells:               2081
     BUFG                            1
     CARRY4                        128
     DSP48E1                        32
     FDRE                          552
     LUT2                          984
     LUT3                          128
     RAM128X1D                     256

Although the issue looks similar to #710 , I think the solution here is to improve xilinx_dsp register packing.

The xilinx_dsp can be called under coarse synthesis process, since the map_dsp pass have already selected and processed the DSP cells. This may need a discussion, but moving the run("xilinx_dsp"); process in map_dsp to:
if (check_label("coarse")) {
                        run("alumacc");
                        run("share");
                        run("opt");
                        run("fsm");
                        run("opt -fast");
                        run("memory -nomap");
                        run("xilinx_dsp");  // <- Moved here
                        run("opt_clean");
                }

Produces the following results:
=== testcase ===

   Number of wires:               1388
   Number of wire bits:          10623
   Number of public wires:          18
   Number of public wire bits:    2001
   Number of memories:               0
   Number of memory bits:            0
   Number of processes:              0
   Number of cells:               3499
     BUFG                            1
     CARRY4                        342
     DSP48E1                        32
     FDRE                          552
     LUT2                         2570
     RAMB36E1                        2

So using this way as a WA for now, until we decide what is the best way for the pass to work.

At least when I last looked at it; xilinx_dsp was working with $add, $sub, etc in order to map MACs; so it needed to be run before alumacc processes these cells. Some more reordering of passes would be needed to get this to work

Nina also suggested to use memory_dff before xilinx_dsp, so we preserve the flow at expense of running that pass twice.


fix broken preview of topics with spaces in folder names

Before:
Preview of markdowns with folder names containing spaces was broken.
After:
Renamed folders to lowercase and hyphens "-" instead of spaces. Moving forward any added topic folders should also be named without spaces.
This PR is linked with issue #40

@neerajrathore Renaming the folders to remove spaces should fix the issue. Please review and merge whenever possible!
Thank you


Provide a way to show size of sub-elements of a given folder

One of the most common use-cases for du -hs by far for me (and also what dust caters to), is to do du -hs * to find the largest directories in a given directory (usually the current one). It doesn't seem like diskus can currently operate in that mode? It'd be awesome if that kind of "tell me what's large" quick-n-dirty mode could be supported somehow!

I was not planning to turn this into a full-blown replacement for du, but that is indeed also my most common use-case.
What about changing the usage to
dup [path]...

where dup would just show the total size of the current directory, but dup path1 path2 would show the total size for each path? The latter could simply be used with dup *.

ncdu (NCurses Disk Usage) comes to mind – https://en.wikipedia.org/wiki/Ncdu

That seems perfect! I think it'd also be handy for the resulting list to be sorted by size, not by the order of the arguments, but with that that's pretty much all I'd need!

@polyzen yup, you can always do that, but I'd argue that since it's by far the most common use-case, it seems reasonable for that to be the default :) That is also what dust does.

I tend to use du -h -d 1 over du -sh * for this, because it only lists directories.
It is sometimes nice to use a greater depth, like when trying to track down an unknown, particularly large subdirectory.  So, at the risk of feature creep, it'd be nice to have summaries of arbitrary depth.

My main use case is exactly like @kpcyrd and @polyzen: per directory and file, total size of every listed file and output piped to sort -h.

Hello, was this ever implemented?

Maybe it could be just used with fd instead?
https://github.com/sharkdp/fd
for example I tried this:
fd -x diskus

but its not quite right, as it only displays the sizes, where most people would want something like:
10 a.txt
20 b.txt


memcpy in s2n_safety should check for dst/src overlap

The case of dst and src overlapping has less obvious symptoms from the case where they're NULL.
We should consider including that check in the safety macros or functions.
Related to issue #366

Most of the work for this issue is already done. This should only require adding another if statement to trace_memcpy_check in https://github.com/awslabs/s2n/blob/master/utils/s2n_safety.h


Add option to 'react' to a post to initiate the code formatting.

I made a change to the CheckForCode module. Add option to 'react' to a post to initiate the code formatting. Made a bool in config.json "autoPost" that, if false, the un-formatted code is detected and an emoji is added to the post. If this emoji is pressed, the new formatted message will be posted. This will of course have to be pressed manually, so no more auto posting of the code. But should fix the issue of unintended re-posting.

I think adding a message to tell user "Hey click this emoji to auto format your code" could help a lot, especially as this feature is new. Now they will be confused why emoji appeared under their message. + new to Discord users arent really familiar with reactions and that bots can interact with their messages, so this help message could be a good kick start for them.

Hi i am writing this comment because I wanna see the notification on discord. THNX BYE, KLENDI

I think adding a message to tell user "Hey click this emoji to auto format your code" could help a lot, especially as this feature is new. Now they will be confused why emoji appeared under their message. + new to Discord users arent really familiar with reactions and that bots can interact with their messages, so this help message could be a good kick start for them.

8af9d40 Should address this comment. Added automated message to prompt the user to react. Message will delete after a set amount of time - or when the user 'reacts'.

Thank you for the contribution! 👍


Do no longer delete prometheus-seed ClusterRoleBinding

How to categorize this PR?

/area usability
/kind bug
What this PR does / why we need it:
In previous versions of Gardener, the prometheus-seed ClusterRoleBinding was related to the cache Prometheus. As part of https://github.com/gardener/gardener/pull/9128, we introduced cleanup code that deletes this no longer required resource.
After https://github.com/gardener/gardener/pull/9180, the seed Prometheus component creates a ClusterRoleBinding with the same name (prometheus-seed), so let's remove it from the cleanup code again.
To be sure the ClusterRoleBinding can be updated for existing seeds, we annotate it with resources.gardener.cloud/delete-on-invalid-update=true (similar approach is already followed for other ClusterRoleBindings).
Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/9065
Follow-up of https://github.com/gardener/gardener/pull/9180
Release note:

NONE

/cherry-pick release-v1.89

/retest


Refactor properties

A minor change, moving the TM space suffix ('/Dev', '/Test') into the 'totalmobile.url' property instead of placing it in the path for the message queue.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c400eb9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   17.41%
  Complexity        ?       72
=========================================
  Files             ?       39
  Lines             ?     1068
  Branches          ?       55
=========================================
  Hits              ?      186
  Misses            ?      879
  Partials          ?        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c400eb9...c692347. Read the comment docs.