Race condition likely during unsubscribe

Hi @kozlovic ,
You handled a previous (invalid) test case from me:
https://github.com/nats-io/cnats/issues/154
After continuing to experience problems, though, I updated and improved the tests, and I think I found that the original issue may indeed exist.
Attached are the updated test case. To use:
# ensure gnatsd is running, and then ...
make
./test_cnats.out 0
./test_cnats.out 1
./test_cnats.out 2
# etc...

What I've found is that tests 9 and 10 fail. A workaround is to introduce a sleep between natsSubscription_Unsubscribe and natsSubscription_Destroy (line 99 in the provided cnats_iface.c).
I haven't identified the fix yet. It seems the gLib ref count doesn't get decrement completely, perhaps because the thread in natsSub_deliverMsg doesn't always break out at
if (sub->closed)
{
    natsSub_Unlock(sub);
    break;
}

I'll investigate further if time permits.
Thanks.
cnats_connect_disconnect_issue.tar.gz

This is with cnats 1.7.6.

Right, the previous tests can be ignored. For these tests, it's your call.
The issue is this: An application written atop cnats must call nats_Close() in order to clean up all of its memory, but reconnecting after a call to nats_Close() may fail.
So as a developer of a cnats application, I have two options:

Don't call nats_Close() ever, in which case the memory footprint at process exit is ~35KB bigger than it should be (on this test machine). That could impact a production system, but it's also a development problem in terms of verifying other memory leaks.
Call nats_Close() only on application exit. This is unrealistic for my scenarios.

Regarding the documentation and usage of nats_Open() and nats_Close(): Right, I've looked through this, and I've read the point about not using them concurrently, which is well taken. In this test case, however, it's arguably not concurrent, though -- not from the standpoint of the developer, that is. The test is single-threaded. That it's multithreaded under the hood is not known to the developer. And if it's required for the developer to know that, then as a developer I need a hook from cnats in order to know when nats_Close() has completed.
I get your point about these test cases exercising the open/close functions not as they "were designed for". This would seem a pathological case. But you may notice that test-9 can fail within just 1 or 2 iterations. And that's exactly what can happen in my application. My application may "think" it's done with cnats and choose to tear down, but then it may immediately require a new connection. That's reasonable, and test-9 distills it. Ref-counting cnats connections within my application is not enough to fix this. I either have to add an unwanted 500us sleep into my disconnect; I have to patch cnats; or I have to allow ~35KB per cnats process on my system, even when no connections are open.

I could introduce a new close API that blocks waiting for all threads holding a reference to the library to return. This would obviously prevent the call on that new API from within a NATS thread (user's message callback, async callbacks, etc..).
But what I find a bit concerning of the usage that you describe is how inefficient that could be. Tearing down the library will stop supporting threads that will need to be recreating at the next connect.
I don't think it is unreasonable to do an open/close at beginning and end of application. The library would be loaded once, and cleaned-up once. Note that a connect will implicitly open the library if not already done, but library does not have to be closed after a connection close/destroy. Again, creating multiple connections does not load (open) the library multiple times.
I am curious as to the reason for your statement: Call nats_Close() only on application exit. This is unrealistic for my scenarios.. Could you elaborate?

@rudyjantz I have PR #187 that would introduce a new API, nats_CloseAndWait() that will ensure that all NATS threads and resources are released before returning. Since this call would block, it can't be invoked from any NATS thread, which NATS callbacks are invoked from. If that happens, an error is returned and the library is not closed. Is that something that would work for you?

@kozlovic Nice hacking. I was sitting on a response while considering what else I could do from my end. But this solves the problem for me. I tested PR 187 with test-9 from the above tarball, and it runs smoothly.
A few comments regarding all this:

You had to add a new API call, which exposes you to potentially more bugs and maintenance, and even misuse from folks who will take the performance penalty unknowingly. These are all valid reasons to hesitate before making the change, which is why I was thinking through things on my end. But you ended up getting it out, so thank you.
Calling nats_Close() only on application exit. This is unrealistic for my scenarios. This is a little complicated. The short of it is that I've wrapped cnats, and clients don't have to worry about closing. But for that to happen, the wrapper has to close cnats when the last connection is closed. The PR you just wrote addresses the case when the user quickly tries to reconnect.
In the long run, I should able to move off of nats_CloseAndWait() and on to nats_Close(). Clients shouldn't be constantly opening/closing connections, as you pointed out, because they're taking an unnecessary performance hit. But I don't have total control over that, so this gives me a stable option in the interim.

I have a separate issue that I'll open regarding publishing. It's related, and I thought this PR might solve it.
Thanks.

@rudyjantz See my comments:

You had to add a new API call,

If we want to have the call block, I had to introduce a new API otherwise that may possibly break users calling nats_Close() from a NATS thread. What I could do, though, is not introduce the new one and since I can detect if nats_Close() is called from a NATS thread or not, is to behave as it was before if called from a NATS thread (that is, still tear down the library but not wait), or wait if it knows that it is not called from such thread. That would prevent adding a new API.

But for that to happen, the wrapper has to close cnats when the last connection is closed. The PR you just wrote addresses the case when the user quickly tries to reconnect.

Understood.

In the long run, I should be able to move off of nats_CloseAndWait() and on to nats_Close(). Clients shouldn't be constantly opening/closing connections, as you pointed out, because they're taking an unnecessary performance hit. But I don't have total control over that, so this gives me a stable option in the interim.

Glad that you understand the impact of opening/closing the library too often.
I really lean toward having nats_Close() updated to behave as I described above: block/wait if it can (not invoked from NATS thread), not wait but still tear down the library if invoked from library - as it does today.

There's another related "issue" to all this, and I was hoping your PR would fix it. Unfortunately it doesn't, so I'll open a separate github issue on it. (Update: see issue #188)

Will comment there.

Right, updating nats_Close() (rather than adding a new call) might be a good option. It'll be backwards compatible. It sounds like it'll behave reasonably in all scenarios.

Actually, after putting more thoughts into it, it is safer to have a new call than change behavior of nats_Close().
The problem is that if I change nats_Close() to now wait (assuming not invoked from a NATS thread), but existing users had applications that were calling nats_Close() and later destroyed some of the NATS objects (which arguably they should do before), then this call would block for ever.
In other words, say that you create a connection, call nats_Close() and then only after that call natsConnection_Destroy(), then this code would work in master but "deadlock" with the change.
Introducing the new API call (and documenting this behavior) would avoid possibly breaking existing applications.

@rudyjantz I have updated (push force) the PR with adding a timeout to the new nats_CloseAndWait() API, and added/enhanced the doc for the two close APIs.

Very nice. I tested with timeout -1, and it went well. With timeout == 0, I had issues again on test 9 that I sent. The docs state
 * @param timeout the maximum time to wait for the library to be closed. If
 * negative or 0, waits for as long as needed.```

If I'm reading that right, then this line should be <= 0?
https://github.com/nats-io/cnats/pull/187/commits/1e48414fdb75687f98c73341117f603d3c00b01b#diff-a4429a58019ab474894d90837d1a6051R1195

Good catch! I will fix that.


Call HostLoadImportedModule for import() also for already loaded modules

This pull request removes any observable change from the proposal, because hosts would be allowed again to schedule the resolution of already loaded modules in a future macro task.

While I believe that the HTML spec doesn't need this change, browsers disagree with me (https://github.com/nicolo-ribaudo/modules-import-hooks-refactor/issues/5#issuecomment-1234348207).
I'll merge this PR for now, to be sure that this refactor allows browsers to keep their current behavior. I might present a need-consensus PR in the future to avoid this unnecessary host hook call.


fix reverse generateFrameNumbers

This PR (delete as applicable)

Fixes a bug

Describe the changes below:
fixed Phaser.Animations.AnimationManager#generateFrameNumbers for reverse count (start < end). it's based on Phaser.Animations.AnimationManager#generateFrameNames.

👍


unsupported type from server string=

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
1.9.2
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
win10 X64     i7 7700HQ
What did you do?
I called  a  sql server 2012sp3 's  proc with  output param  as the sql.Out example shows
as  below:
var strErrorDescribe string
	_, err = db.GetmyssqlDB().ExecContext(context.Background(), "NET_PW_InsureIn",
		sql.Named("dwUserID", m.UserId),
		sql.Named("dwScore", m.MoneyAmount),
		sql.Named("strErrorDescribe", sql.Out{Dest: &strErrorDescribe}))

strErrorDescribe is  the  NVARCHAR(127) OUTPUT param
but  i got  err  as   "unsupported type from server string=存款成功!"
and the 'strErrorDescribe' returned value is  ""
What did you expect to see?
strErrorDescribe should contain 存款成功 as returned value
What did you see instead?
the 'strErrorDescribe' returned value is  ""

For questions about Go, see https://golang.org/wiki/Questions.


Could not find 'rake' (...) among X total gem(s)

Description of Problem
zeus start fails if rake gem is not installed.
System details

uname -a:  Darwin R5003885.local 14.5.0 Darwin Kernel Version 14.5.0: Wed Jul 29 02:26:53 PDT 2015; root:xnu-2782.40.9~1/RELEASE_X86_64 x86_64

ruby -v: ruby 1.9.3p194 (2012-04-20 revision 35410) [x86_64-darwin14.4.0]

Steps to Reproduce

gem uninstall rake

gem install zeus

zeus start in a new rails project

zeus s

Observed Behaviour
Server does not run. It complains about rake: Could not find 'rake' (...) among X total gem(s)
Expected Behaviour
Server runs.

Can you post the Gemfile and Gemfile.lock for the rails project?

# Gemfile
source 'https://rubygems.org'

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '4.2.4'
# Use sqlite3 as the database for Active Record
gem 'sqlite3'
# Use SCSS for stylesheets
gem 'sass-rails', '~> 5.0'
# Use Uglifier as compressor for JavaScript assets
gem 'uglifier', '>= 1.3.0'
# Use CoffeeScript for .coffee assets and views
gem 'coffee-rails', '~> 4.1.0'
# See https://github.com/rails/execjs#readme for more supported runtimes
# gem 'therubyracer', platforms: :ruby

# Use jquery as the JavaScript library
gem 'jquery-rails'
# Turbolinks makes following links in your web application faster. Read more: https://github.com/rails/turbolinks
gem 'turbolinks'
# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
gem 'jbuilder', '~> 2.0'
# bundle exec rake doc:rails generates the API under doc/api.
gem 'sdoc', '~> 0.4.0', group: :doc

# Use ActiveModel has_secure_password
# gem 'bcrypt', '~> 3.1.7'

# Use Unicorn as the app server
# gem 'unicorn'

# Use Capistrano for deployment
# gem 'capistrano-rails', group: :development

group :development, :test do
  # Call 'byebug' anywhere in the code to stop execution and get a debugger console
  gem 'byebug'
end

group :development do
  # Access an IRB console on exception pages or by using <%= console %> in views
  gem 'web-console', '~> 2.0'

  # Spring speeds up development by keeping your application running in the background.

This might duplicate #237 which can be resolved by #530?

@matiasanaya Yes, should be fixed with that PR. Does this still happen with zeus 0.15.5?


Update to beginners tutorial

Codecov Report

Merging #174 (8656893) into devel (eeab930) will decrease coverage by 0.07%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##            devel     #174      +/-   ##
==========================================
- Coverage   76.74%   76.66%   -0.08%
==========================================
  Files         133      133
  Lines        7464     7473       +9
==========================================
+ Hits         5728     5729       +1
- Misses       1736     1744       +8

Impacted Files
Coverage Δ

openghg/dataobjects/_searchresults.py
73.94% <11.11%> (-4.26%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeab930...8656893. Read the comment docs.


For xlsx generated by java POI5, it cannot be opened by MS Excel after modification by OpenXLSX

Background: Apache POI library is specially used to process MS office files. The fifth version of POI(POI5), relies on the zip library Apache Commons Comprese. The zip64 implementation of this library is opczip, which is specially implemented for MS Excel.
Problem: After opening, modifying and saving the xlsx file generated by POI5 through OpenXLSX, MS Excel will not be able to open the modified file. I tried to look at the source code of POI and OpenXLSX and found the problem here. The root cause is that there are slight differences between the zip64 standard implemented by zippy (which looks like miniz) and opczip that OpenXLSX relies on for zip64.
Notes:

Because opczip is a special implementation of MS Excel (I have tested that the xlsx generated by opczip can be opened by MS Excel), I tried to modify the zippy code. There is a bad way to make it compatible with opczip (that is, MS Excel). When dealing with the optional data descriptor in mz_zip_writer_add_from_zip_reader, check whether the zip version is 0X002D, like this:...
mz_bool is_src_zip64 = MZ_FALSE; // a bad way for compatible with POI5
if (MZ_READ_LE16(pLocal_header + MZ_ZIP_LDH_VERSION_NEEDED_OFS) >= 0X002D) {
    unsigned long len = (sizeof(mz_uint32) * 6) + 2;
    mz_uint8 tmp[len];
    if (pSource_zip->m_pRead(pSource_zip->m_pIO_opaque, cur_src_file_ofs, tmp, len) == len) {
        n = sizeof(mz_uint32) * ((MZ_READ_LE32(tmp) == MZ_ZIP_DATA_DESCRIPTOR_ID) ? 6 : 5);
        if (MZ_READ_LE16((mz_uint8*)tmp + n) == 0X4B50) {
            is_src_zip64 = MZ_TRUE;
        }
    }
}
if ((pSource_zip->m_pState->m_zip64) || (found_zip64_ext_data_in_ldir) || is_src_zip64) {
...

Maybe this isn't Zippy's fault, but I found that zippy has many problems with its implementation of zip64. Have you considered updating OpenXLSX's dependency on zippy (it seems that zippy does not fully support zip64)?
This is the file in question.POI5.2.3.xlsx

Hi & thank you for the report. This sounds like an odd problem that I can only explain happening from a mix of data from different zip formats.
Considering that Excel has no problem opening archives created by OpenXLSX, I would suggest the best way forward for me to address this would be to make sure that all "metadata" generated by opczip is wiped when saving in OpenXLSX. Would you see any issues with that approach?

just a quick test: LibreOffice (v<IP_ADDRESS>) has no problems opening your example file after opening and saving it from OpenXLSX - is it possible that:

the problem is with Excel having a shitty implementation of zip-files that chokes on something that deviates from "how Microsoft does it"? I'd obviously still try to find a solution but it'd be yet another point to add to the list why to use non-MS products ;)

I saw that in the docProps/app.xml, the namespace "vt" is not defined, which OpenXLSX assumes as "the namespace" for the vt:vector and its children and for vt:vector and its children. Is it possible that what Excel actually complains about is that the app.xml is using this namespace without declaring it?

Hi & thank you for the report. This sounds like an odd problem that I can only explain happening from a mix of data from different zip formats.
Considering that Excel has no problem opening archives created by OpenXLSX, I would suggest the best way forward for me to address this would be to make sure that all "metadata" generated by opczip is wiped when saving in OpenXLSX. Would you see any issues with that approach?

It is also possible to erase all the "metadata" generated by opczip when saving, but for larger xlsx files, saving and reading will be more time-consuming due to the need to parse the XML.

just a quick test: LibreOffice (v<IP_ADDRESS>) has no problems opening your example file after opening and saving it from OpenXLSX - is it possible that:

the problem is with Excel having a shitty implementation of zip-files that chokes on something that deviates from "how Microsoft does it"? I'd obviously still try to find a solution but it'd be yet another point to add to the list why to use non-MS products ;)
I saw that in the docProps/app.xml, the namespace "vt" is not defined, which OpenXLSX assumes as "the namespace" for the <HeadingPairs><vt:vector> and its children and for <TitlesOfParts><vt:vector> and its children. Is it possible that what Excel actually complains about is that the app.xml is using this namespace without declaring it?

Yes, there is no problem opening the xlsx modified by OpenXLSX through other tools (I guess it is because other tools will perform automatic repairs, and MS Excel may perform additional zip verification).
I think it is the first reason. I am not very familiar with xml, but I manually modified the problematic binary xlsx file :

filled its Data Descriptor extension with the correct value.
changed its compressed version number to 0X14 instead of the original 0X2D). 0X14 represents zip2.0, 0X2D represents zip4.5 (zip64 extension was introduced in zip4.5)

After my manual modification, it can be opened by MS Excel, so I think it is very likely a problem with the zip implementation. MS Excel's zip implementation is not compatible with zippy. The two have different implementations of some details of zip64. Of course, this is also because the zip specification is very vague about zip64.

Hi & thank you for the report. This sounds like an odd problem that I can only explain happening from a mix of data from different zip formats.
Considering that Excel has no problem opening archives created by OpenXLSX, I would suggest the best way forward for me to address this would be to make sure that all "metadata" generated by opczip is wiped when saving in OpenXLSX. Would you see any issues with that approach?

It is also possible to erase all the "metadata" generated by opczip when saving, but for larger xlsx files, saving and reading will be more time-consuming due to the need to parse the XML.

Well - there is zero metadata in the actual XML as far as I could tell from your example. To be honest, without having looked too closely into zippy functionality, I am surprised that it is not re-creating the zip archive from scratch upon saving anyways - and that consequently, you get different behavior on xlsx-files created with OpenXLSX, and those modified with it.
Just to repeat - is it correct that you can open the files created with OpenXLSX in MS Excel on your system without problems?
E.g. the Demo0?.xlsx files?
From your last comment, it appears that maybe it is enough to "downgrade" the version number if zippy finds it "too high"?
May I ask what the "correct value" is for the Data Descriptor?

Hi & thank you for the report. This sounds like an odd problem that I can only explain happening from a mix of data from different zip formats.
Considering that Excel has no problem opening archives created by OpenXLSX, I would suggest the best way forward for me to address this would be to make sure that all "metadata" generated by opczip is wiped when saving in OpenXLSX. Would you see any issues with that approach?

It is also possible to erase all the "metadata" generated by opczip when saving, but for larger xlsx files, saving and reading will be more time-consuming due to the need to parse the XML.

Well - there is zero metadata in the actual XML as far as I could tell from your example. To be honest, without having looked too closely into zippy functionality, I am surprised that it is not re-creating the zip archive from scratch upon saving anyways - and that consequently, you get different behavior on xlsx-files created with OpenXLSX, and those modified with it.
Just to repeat - is it correct that you can open the files created with OpenXLSX in MS Excel on your system without problems?
E.g. the Demo0?.xlsx files?
From your last comment, it appears that maybe it is enough to "downgrade" the version number if zippy finds it "too high"? May I ask what the "correct value" is for the Data Descriptor?

Yes, xlsx files created with OpenXLSX can be opened by MS Excel.
The "correct value" of the data descriptor is the size of each XML file.
As you know, if the XML file in the zip file has a Data Descriptor, the CRC of the XML file before compression, the size before compression, and the size after compression are saved in the Data Descriptor.

Hi & thank you for the report. This sounds like an odd problem that I can only explain happening from a mix of data from different zip formats.
Considering that Excel has no problem opening archives created by OpenXLSX, I would suggest the best way forward for me to address this would be to make sure that all "metadata" generated by opczip is wiped when saving in OpenXLSX. Would you see any issues with that approach?

It is also possible to erase all the "metadata" generated by opczip when saving, but for larger xlsx files, saving and reading will be more time-consuming due to the need to parse the XML.

Well - there is zero metadata in the actual XML as far as I could tell from your example. To be honest, without having looked too closely into zippy functionality, I am surprised that it is not re-creating the zip archive from scratch upon saving anyways - and that consequently, you get different behavior on xlsx-files created with OpenXLSX, and those modified with it.
Just to repeat - is it correct that you can open the files created with OpenXLSX in MS Excel on your system without problems?
E.g. the Demo0?.xlsx files?
From your last comment, it appears that maybe it is enough to "downgrade" the version number if zippy finds it "too high"? May I ask what the "correct value" is for the Data Descriptor?

Yes, xlsx files created with OpenXLSX can be opened by MS Excel.
The "correct value" of the data descriptor is the size of each XML file.
As you know, if the XML file in the zip file has a Data Descriptor, the CRC of the XML file before compression, the size before compression, and the size after compression are saved in the Data Descriptor.

If the Data Descriptor is in zip64 standard, the size before and after compression will be represented by 8 bytes respectively, otherwise it will be represented by 4 bytes.
In the zippy implementation, if an XML file is not modified, the Data Descriptor in the source file will be copied to the new file. During the copying process, since the source file is recognized by zippy as zip32 format, it will be copied incorrectly, as shown below:
// origin xml's Data Descriptor
 50 4B 07 08 73 B9 D9 10 06 66 30 21 00 00 00 00 9A 90 DC 15 00 00 00 00
|-----------|-----------|-----------------------|-----------------------|
 'PK\07\08'    CRC-32    compressed size          uncompressed size

// new xml's Data Descriptor
 50 4B 07 08 73 B9 D9 10 06 66 30 21 00 00 00 00
|-----------|-----------|-----------|-----------|
 'PK\07\08'    CRC-32    compressed 	uncompressed
 				        size                   size

// The correct one should be as follows (That is the bytes I modified manually)
 50 4B 07 08 73 B9 D9 10 06 66 30 21 9A 90 DC 15
|-----------|-----------|-----------|-----------|
 'PK\07\08'    CRC-32    compressed 	uncompressed
 				        size                   size

I don't know, actually - I just started contributing to OpenXLSX and didn't touch zippy beyond superficial patches so far :)
I put some debugging output in the function mz_zip_writer_add_from_zip_reader you mentioned, right before this line:
            /* Now deal with the optional data descriptor */

Unfortunately, that code - opening your example file and saving it again - never gets invoked. What I am doing is:
	XLDocument doc("./POI5.2.3.xlsx"s);
	doc.setSavingDeclaration( XLXmlSavingDeclaration(XLXmlDefaultVersion, "utf-8", XLXmlNotStandalone) );

	std::cout << "doc.name() is " << doc.name() << std::endl;

        doc.workbook().addWorksheet( "test new worksheet" );
	wks.setActive();

	doc.saveAs("./out.xlsx", XLForceOverwrite);
	doc.close();

any idea why the code section where you proposed a workaround is not even being invoked here?

And thank you very much for the hex output of the problematic part - that helps me a lot to understand the compatibility issue.

Are you referring to the mz_zip_writer_add_from_zip_reader method not being called?
https://github.com/troldal/OpenXLSX/blob/607360e5132c4fa118f022f9ee687405c099bfe4/OpenXLSX/external/zippy/zippy.hpp#L10774-L10792

Yes - in my (private) development branch, the "IsModified()" is always true. And I am trying to find out why..

Yes, sorry for forgetting to tell you, I modify the code here https://github.com/troldal/OpenXLSX/blob/607360e5132c4fa118f022f9ee687405c099bfe4/OpenXLSX/sources/XLDocument.cpp#L463-L476
to improve the speed by reducing the number of XML files opened and parsed.
Thank you very much for your reply. When I have time, I will study OpenXLSX and zippy's support for zip64. See how to call mz_zip_writer_add_from_zip_reader

Wait, so you added the code change yourself that broke things, and then you created an issue and forgot to mention that? :P
That would have been nice to know sooner. So what did you change? Did you exclude some worksheets from being opened at all & that is what triggered the bug?
It would still be good to know because the optimization you implemented might be interesting to support.

Okay, so with that knowledge, if I skip a worksheet from being parsed, I can get the Zippy save routine to return false from "IsModified()" for that file. But that creates a whole lot of different problems - worksheets are not supposed to be "skipped" when loading.
And your example does not work for me then, because without a single worksheet in the workbook, saving it will throw an exception because the workbook validation fails.
I'll mark this as invalid and close it for now - when you have a good working suggestion for a loading optimization (at the user's risk) please open a new issue with a "feature request" :)

Yes, in order to achieve a special function, I did not read out all the XML files, skipped some XML, so some XML files were not modified.


Missing option '--numquestions'

This issue is for a:
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

run evaluation on all test data: python3 -m scripts evaluate --config=example_config.json

Any log messages given by the failure

vscode ➜ /workspaces/ai-rag-chat-evaluator (main) $ python3 -m scripts evaluate --config=example_config.json
Usage: python -m scripts evaluate [OPTIONS]
Try 'python -m scripts evaluate --help' for help.
Error -->  Missing option '--numquestions'.

Expected/desired behavior

No Error: Should perform evaluation on all records provided in the qa.jsonl !

OS and Version?

Windows 10

Mention any other details that might be useful

Evaluation works if the number of questions is provided '--numquestions='

Can confirm, have the same issue on my end

Thanks so much for the report! I've merged a fix in https://github.com/Azure-Samples/ai-rag-chat-evaluator/pull/39

Thank you very much for quick fix as always. 😊👍


README

README
USER STORY
As a boot camp student,
I wan the prework notes to be structured on a webpage,
So that i can easily find and read the information.
ACCEPTANCE CRITERIA
GIVEN the prework project repository,
WHEN I view the README for the repository,
THEN I can see the professional README that provides information on the project and how to use it

done.


BUGFIX: adhere to RFC 5280 - Section <IP_ADDRESS> and don't include empty KeyUsages extensions

fixes https://github.com/cert-manager/cert-manager/issues/6541
Kind
/kind bug
Release Note
We no longer add the KeyUsages x509 extension when there are no key usages set in accordance to RFC 5280 - Section <IP_ADDRESS>.

/approve


Add a search feature to Kusto (KQL) extension

It would be nice if the Kusto (KQL) extension had a search feature to search for specific artifacts in an Azure Data Explorer

Example artifacts to search for: tables, columns.
this feature is currently in the current Kusto Explorer application.

@Charles-Gagnon : FYI ..


Rename role and role binding

Summary
"pod-reader" does not reflect the role as it contains the "delete" verb

@dotnet-policy-service agree


Build issues (Export encountered errors on following paths: /_not-found)

Describe the bug
It's impossible to build the app because for some reasons it throws an error.
 ✓ Creating an optimized production build
 ✓ Compiled successfully
 ✓ Linting and checking validity of types
 ✓ Collecting page data
   Generating static pages (0/4)  [    ]Error: Could not find locale while pre-rendering page, make sure you called `setStaticParamsLocale` at the top of your pages

Error occurred prerendering page "/_not-found". Read more: https://nextjs.org/docs/messages/prerender-error
Error: Could not find locale while pre-rendering page, make sure you called `setStaticParamsLocale` at the top of your pages

> Export encountered errors on following paths:
	/_not-found

I don't have any _not-found files in my project.
I have no static pages in my project as well, the problem comes from /_not-found file.
I was trying to create not-found.tsx file in [locale] directory, it does not help.

To Reproduce
pnpm build
Expected behavior
It should build without any errors.
About (please complete the following information):

next-international version: 1.1.3
Next.js version: 13.5.6

Can you share a minimal reproduction? Looking at the error, it seems like you're never calling setStaticParamsLocale: https://next-international.vercel.app/docs/app-static-rendering#static-rendering

Closing for now, happy to re-open and help when we have more information.


Bump cda

This adds whatever support we have for mev ts 1.8 without breaking support for older mev ts 1.2. Once we have feature parity, we will remove the legacy support for 1.2.

/test e2e-dpu-operator-tests

/test e2e-dpu-operator-tests

/retest

/test e2e-dpu-operator-tests

/lgtm

/test e2e-dpu-operator-tests

This passed: https://net-hw-ci-jenkins-csb-nst.apps.ocp-c1.prod.psi.redhat.com/view/IPU Testing/job/99_E2E_IPU_Deploy/102/parameters/
But an additional trigger of e2e-dpu-operator-tests occurred. Overriding

/override ci/prow/e2e-dpu-operator-tests


docs: kubenet dual-stack limitations

remove limitation around ETP local
clarify how LB services work

#sign-off

bump @asudbring

#sign-off


German translation exercises

I'm new on GitHub and not too deep into CSS or SASS, but experienced some HTML and CSS ages ago (about 10 years ago I coded HTML). Since then on conceptual level. Translated already two english books (60 + 100 pages) into German.

This is awesome, @Maroel! I'll get to review your changes later today 😃

@Maroel thank you for your PR! It looks great so far 👍
There's only one missing bit left to complete. You should also translate the file https://github.com/workshopper/learn-sass/blob/master/footer.en.md. Without this file, the user will not see instructions to validate their submission, like the following:
## HINTS

  To make a Sass (SCSS) stylesheet, create a new file with a .scss extension
  and start writing SCSS. When you are done, you must run:

     $ learn-sass verify stylesheet.scss

  to proceed. Your stylesheet will be tested, a report will be generated,
  and the lesson will be marked 'completed' if you are successful.

Please create a https://github.com/workshopper/learn-sass/blob/master/footer.de.md containing the German translation of footer.en.md.

Thank you so much! I'll merge now

Implements #60


Do not require permissions to use table functions

Queries like select 1 are commonly used for simple connection tests
and table functions don't expose any stored user data so we can allow
them to be executed.

retest this please


Strict Host Key Checking

Hi!
First things first: thank you for the book! :)
Now about the issue. I encountered it in chapter 3 page 22 while running ansible multi -a "hostname" command. As SSH strict host key checking is "on" by default it causes 3 messages (one per each server: app1, app2 and db) asking whether you want to add the host to the list of known hosts. Although this behavior can be bypassed via changing either SSH or Ansible options (through config file or env variable) and it is not an 'issue' per se as such behavior is expected it would be nice to have it mentioned in the book.
Regards,
i-zu

I've added the following tip:

If you get an error like The authenticity of host '<IP_ADDRESS>' can't be established., this is because SSH has a security feature which requires you to confirm the server's 'host key' the first time you connect. You can type yes on the command line (in this case multiple times) to dismiss the warning and accept the hostkey, or you can also set the environment variable ANSIBLE_HOST_KEY_CHECKING=False. The behavior for host key acceptance can also be configured in your SSH configuration file.


(maint) Merge 5.5.x to 6.0.x

The only conflict was on the man files

❯ git merge --no-ff --log pl/5.5.x
--
Auto-merging spec/unit/provider/package/puppet_gem_spec.rb
Auto-merging spec/unit/provider/package/pip_spec.rb
Auto-merging spec/unit/provider/package/gem_spec.rb
Auto-merging man/man8/puppet.8
Auto-merging man/man8/puppet-node.8
Auto-merging man/man8/puppet-module.8
CONFLICT (modify/delete): man/man8/puppet-master.8 deleted in HEAD and modified in pl/5.5.x. Version pl/5.5.x of man/man8/puppet-master.8 left in tree.
Auto-merging man/man8/puppet-key.8
Auto-merging man/man8/puppet-config.8
CONFLICT (modify/delete): man/man8/puppet-certificate_revocation_list.8 deleted in HEAD and modified in pl/5.5.x. Version pl/5.5.x of man/man8/puppet-certificate_revocation_list.8 left in tree.
CONFLICT (modify/delete): man/man8/puppet-certificate_request.8 deleted in HEAD and modified in pl/5.5.x. Version pl/5.5.x of man/man8/puppet-certificate_request.8 left in tree.
CONFLICT (modify/delete): man/man8/puppet-certificate.8 deleted in HEAD and modified in pl/5.5.x. Version pl/5.5.x of man/man8/puppet-certificate.8 left in tree.
CONFLICT (modify/delete): man/man8/puppet-cert.8 deleted in HEAD and modified in pl/5.5.x. Version pl/5.5.x of man/man8/puppet-cert.8 left in tree.
CONFLICT (modify/delete): man/man8/puppet-ca.8 deleted in HEAD and modified in pl/5.5.x. Version pl/5.5.x of man/man8/puppet-ca.8 left in tree.
Auto-merging man/man5/puppet.conf.5
Auto-merging lib/puppet/provider/package/yum.rb
Auto-merging lib/puppet/provider/package/pip.rb
Auto-merging lib/puppet/provider/package/gem.rb
Automatic merge failed; fix conflicts and then commit the result.

TBH I thought the merge up automation already ignored man page differences, but this is probably a special case since the master, cert, etc applications were deleted in 6.0


Clustering a large set of short k-mers

Dear MMseqs2 team,
Can you please give some advice on how to proceed with clustering a large set of short k-mers, something between 7-mer and 9-mers? I tried playing around with linclust but it's outputting a lot of representative sequences. I am looking for maybe just a few final centroids.

MMseqs2 default k-mer sizes and spaced-k-mer patterns are too long to match such short sequences.
Using a shorter k-mer size and pattern should enable you to match them:
-k 5 --spaced-kmer-pattern 110111

I would additionally disable masking and compositional bias filtering, as this is not really a homology search anymore and doesn't benefit from false positive suppression:
--mask 0 --comp-bias-corr 0

In the same vain, you might not want to generate similar k-mers at all and only do exact matching:
--exact-kmer-matching 1


Check work stability if Redis shut downed

Check how would behave Ferrum if we stop Redis server, it shouldn't crashed it should respond with something like "Data Storage is not ready, please try again later", and work when storage is Up
In this task i also take some additional works:

[x] add typical error for DataStorageNotAvailable
[x] add more typical errors 4 determine what happened (ObjectNotFoundError and others), this point solves issue: #22
[x] working with typical errors (previous list item) brake me a lot of manager methods: Have to implement minimal set of tests (partially solves issue #62
[x] I should also make come clean-up in Dockerfile && docker-compose : add permanent name for containers, volumes and so on
[x] working on docker compose i change to init redis via sh. script (not using python) #44
[x] test all method on availability

Left only following things:

[ ] manual check app work on Redis shutdown / switch on
[ ] save script with data init to volume, make permanent volume name 4 ferrum_webapi


feat: added minDownload speed while creating pod

@justinmerrell please review and merge.

Also, is there a param for minUpload speed ?

@ef0xa why was this closed?


Backbones

Could you please provide the backbones used for segmentation during training? I would want the one used for training VSSM small.

All the checkpoint can be found in releases, while the code lies in model.py in the folder segmentation.


doc: fix apidoc bug, add guide on building docs

sphinx-apidoc was not working properly, so this PR makes a minor change to docs/conf.py to fix that.
Also, I added a section to the Developer Guide about how to use sphinx-apidoc after code changes.
modules.rst is auto-generated by sphinx-apidoc.

Fixed by #536.


Google maps support - Issue

There are understanding problems in code, Im trying to implement google maps, It fetches style json, Im not sure google maps is having api that can provide style json. Also the documentation contains only usage for maps like stadia, maptiler etc. Can you help me to use google vector tiles combining with vector_tile_maps?

There are multiple vector tile APIs available, see the readme for some examples
Google maps provides docs on their APIs, eg. https://developers.google.com/maps/documentation/tile

I have tried using the same earlier but your package also requires style of the map as style.json. Which is not found in google API's. I think it's not possible to apply google maps to your package.


BlockingServletIo assumes the request's InputStream is unmolested...

I'm not very familiar with the HTTP-servlet standard, so perhaps http4s is technically in-the-right in assuming the ServletInputStream has not yet been read from. However, it would certainly make the library more user-friendly (and have saved me hours) if the BlockingServletIo raised something like an IllegalStateException -- including a pertinent error message -- if the input-stream's isFinished method returns true out-the-gate.
In my case, I had a javax.servlet.Filter registered that was calling getParameterMap on the HttpServletRequest (to do some primitive malicious-request rejection), before passing off the request object off to the http4s stack... It looks like this was invoking Jetty's implementation of getParameterMap, which reads "POST" parameters (so to speak) from the request body.
The result is that I would end up with an empty Map when doing something like req.decode[UrlForm] { f => val params = f.values; /* ... */ } and no sign of what had gone wrong.

That behavior of consuming the stream is unfortunately correct per servlet spec.
One thing I'm not sure of is whether isFinished returns true on an empty stream before an attempt to read.  If not, we could probably do something like you suggest (for the cost of a boolean check per request on everybody).  If empty bodies start isFinished, then I don't think there is anything we can do here.

Good question. I'll try to get you an answer -- what does isFinished return for an empty stream (empty-body request) before any attempt to read from the stream has been made?

Sorry I didn't follow-up on this sooner. It appears as though isFinished returns false even on an empty-bodied HTTP request, so long as read hasn't been called on the InputStream.
I set up an experiment like this in a servlet Filter:
println("isFinished: " + request.getInputStream.isFinished)
request.getInputStream.read()
println("isFinished: " + request.getInputStream.isFinished)

If I then issue a HEAD request using curl (e.g., curl --head http://localhost:8080/) the first call to isFinished returns false and the second true.

Okay, that's encouraging.  In jetty, there's a sychronization, but it should be pretty cheap in the grand scheme of things.  I'd be fine with adding this check.  Would you like to give it a try?


when ever i select a date it automatically goes to next date of the selected Date

Hello @Mulham-Raee,
I have an issue in Horizontal calendar, when ever i select a date it automatically goes to next date of selected Date..

In which actually it select the current date but it show the next date of that.
Please let me know if there's any solution of this issue.
Thanks!

Same issue here.

same issue

I have same issue... it's so fatal error.

same issue any fix ?

Issue fix was committed a while ago to this repository, but it is not available on jCenter yet. You can clone this repository and use it locally for now.

Issue fix was committed a while ago to this repository, but it is not available on jCenter yet. You can clone this repository and use it locally for now.

can you guide me how to do that? I am new to android studio, so am unaware how to use it locally..
or maybe make it available on jCenter altogether ;-;

I have cloned the latest code and used it locally, But still facing the same issue.
Issue seems to be only on mobile phones and not on tablets.
Please help me!!! Thanks...

TIENE YA SOLUCION????

I have same issue


CI: Manage test tags in yaml

/test mini

Merging as this gets approved and test failures are unrelated.


"Urdinița" . "Voita" are listed in the drop-down menu

Description:
"Urdinița" . "Voita" the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Urdinița"

Expected results
The location appears in the drop-down menu as "Sat Urdinița, DOLJ (Brabova)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Voita"

Expected results
The location appears in the drop-down menu as "Sat Voita, DOLJ (Brabova)".


REST API - More information about Indexes

Hi,
I'd really appreciate it if we could extend the REST API to provide more comprehensive information about an Index when queried at /services/rest/Index/{{name}}. I would expect this enhancement to allow things such as locations, number of documents, last update time and current status (is it crawling, parsing or idle?
Thanks

Testing with this so far seems good. I was wondering if there was to be further work undertaken in regards to a GET on the file locations? I assume this would be something within opensearchserver/src/main/java/com/jaeksoft/searchlib/webservice/crawler/filecrawler/FileCrawlerImpl.java that would be called from http://{{server}}/services/rest/crawler/file/repository/{{index name}}/json
which returns a list of file locations as well as the type of location (dropbox, swift, FTP, SMB, Local etc.)

Hi Adam,
There is a few historical API using  /json and /xml prefixes. They still exists, but we are now using new patterns. In the new API, choosing between JSON and XML will be made passing the right header. But don't worry, we will keep the old one active.
I just close this issue, as it is related to the index list.

Hi Emmanuel,
Thanks for your response. I assume there is no GET API for retrieving a list of file locations after looking through the code. Should I create a new issue for this?
Thanks


wallet-api: Get rid of .TH modules

Part of #1010

Looks like we're having a line endings war. Can you check your settings? I think it should be on "check in Unix line endings", or at least that's what we've been doing in the past.

Hm I thought I had fixed that.
I changed the line endings in plutus-emulator/test/Spec.hs to LFs, all the other files in this PR seemed to be OK.

:+1:


Delete non-empty r2 bucket

Current Terraform and Cloudflare provider version
Terraform v1.4.6
on windows_amd64

provider registry.terraform.io/cloudflare/cloudflare v4.7.1

Description
Im very happy with the new resource to manage r2 buckets however, I cannot delete the bucket if it contains data. There is the force_destroy option in the aws provider but that doesn't work with cloudflare buckets because the provider expects buckets to also be versioned.
Use cases
Creating a bucket with for instance
resource "cloudflare_r2_bucket" "example" {
  account_id = "f037e56e89293a057740de681ac9abbe"
  name       = "terraform-bucket"
  location   = "enam"
}

adding a file to the bucket,
destroying the terraform resource should work.
Potential Terraform configuration
resource "cloudflare_r2_bucket" "example" {
  account_id = "f037e56e89293a057740de681ac9abbe"
  name       = "terraform-bucket"
  location   = "enam"
}

References
No response

this is not supported in the API and I'm not sure if the team have plans on adding it so closing this out until such a time when the team adds support first.

The same issue.


🚀 Feature: Scaffolder parseEntityRef filter enhancement

🔖 Feature description
We would like to add defaultNamespace and defaultKind optional args to the parseEntityRef Scaffolder filter.
🎤 Context
We utilize this filter in various templates and in some cases we would like to infer default kind and/or namespace for these entities. Here's an example:
if: ${{ (steps['fetch-component-details'].output.entity.spec.owner | parseEntityRef | pick('name')) != 'group-example' }}

The above expressions logs an error if spec.owner isn't in the entity ref format.
✌ Possible Implementation
On https://github.com/backstage/backstage/blob/v1.17.2/plugins/scaffolder-backend/src/lib/templating/filters.ts#L30:
parseEntityRef: (ref: string, defaultKind?: string, defaultNamespace?: string) => {
  return parseEntityRef(ref as string, { defaultKind, defaultNamespace })
}

Example:
${{ steps['fetch-component-details'].output.entity.spec.owner | parseEntityRef('group') }}
${{ steps['fetch-component-details'].output.entity.spec.owner | parseEntityRef('resource', 'org') }}

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

yeah it makes total sense! 🚀

closing as fixed!


⚠ Bofrost.be has degraded performance

In 3955669, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1105 ms

Resolved: Bofrost.be performance has improved in 986c3be.


poetry 1.0.0b5: Key "Extras:" already exists

[x] I am on the latest Poetry version.  Well, latest pre-release (1.0.0b5)
[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: Linux serenity 5.3.10-arch1-1 #1 SMP PREEMPT Sun, 10 Nov 2019 11:29:38 +0000 x86_64 GNU/Linux

Link of a Gist with the contents of your pyproject.toml file: https://gist.github.com/stratosgear/336ca890ed93be7f7aefd217dc5f6d54

Issue
I get this:
➜ poetry --version
Poetry version 1.0.0b5

➜ poetry install -vvv
Creating virtualenv rapidxmm in /mnt/data/projects/backend/src/.venv
Using virtualenv: /mnt/data/projects/backend/src/.venv

[KeyAlreadyPresent]
Key "extras" already exists.

Traceback (most recent call last):
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/clikit/console_application.py", line 131, in run
    status_code = command.handle(parsed_args, io)
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/clikit/api/command/command.py", line 120, in handle
    status_code = self._do_handle(args, io)
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/clikit/api/command/command.py", line 171, in _do_handle
    return getattr(handler, handler_method)(args, io, self)
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/cleo/commands/command.py", line 92, in wrap_handle
    return self.handle()
  File "/home/stratos/.poetry/lib/poetry/console/commands/install.py", line 63, in handle
    return_code = installer.run()
  File "/home/stratos/.poetry/lib/poetry/installation/installer.py", line 65, in run
    if not self._update and not self._locker.is_locked():
  File "/home/stratos/.poetry/lib/poetry/packages/locker.py", line 48, in is_locked
    return "package" in self.lock_data
  File "/home/stratos/.poetry/lib/poetry/packages/locker.py", line 37, in lock_data
    self._lock_data = self._get_lock_data()
  File "/home/stratos/.poetry/lib/poetry/packages/locker.py", line 220, in _get_lock_data
    return self._lock.read()
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/tomlkit/toml_file.py", line 20, in read
    return loads(f.read())
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/tomlkit/api.py", line 34, in loads
    return parse(string)
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/tomlkit/api.py", line 51, in parse
    return Parser(string).parse()
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/tomlkit/parser.py", line 153, in parse
    key, value = self._parse_table()
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/tomlkit/parser.py", line 1039, in _parse_table
    result = self._parse_aot(result, name)
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/tomlkit/parser.py", line 1083, in _parse_aot
    _, table = self._parse_table(name_first)
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/tomlkit/parser.py", line 1026, in _parse_table
    table.raw_append(key_next, table_next)
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/tomlkit/items.py", line 938, in raw_append
    self._value.append(key, _item)
  File "/home/stratos/.poetry/lib/poetry/_vendor/py3.8/tomlkit/container.py", line 138, in append
    raise KeyAlreadyPresent(key)

My poetry settings:
➜ poetry config --list
cache-dir = "/home/stratos/.cache/pypoetry"
virtualenvs.create = true
virtualenvs.in-project = true
virtualenvs.path = "."

I bet this has to do with the recent release of Python 3.8, but I have no idea how to fix it... :(
I'm on Arch so I just picked the latest version just today I think

It seems that the error occurs when trying to read the lock file.
What does your lock file look like?

Like this: https://gist.github.com/stratosgear/c0f7aadd95395609311d502619aaa91e
But thanks for the nudge in the right direction.  Usually when I try to "debug/fix" something like that I remove the .venv and the poetry.lock file, to start clean.  This time I completely messed up and forgot the remove the poetry.lock
poetry install is working fine now, but that error message was REALLY confusing because I was searching for extras mention in my pyproject.toml (and they were none).

Thanks.
The error comes from the fact that, in the lock file, the extras of urllib were specified twice (see https://gist.github.com/stratosgear/c0f7aadd95395609311d502619aaa91e#file-poetry-lock-L1998) which is not valid.
I am not sure how this can happen. Did you recently merge something that could explain the duplicate entries?
That being said, the error message should be clearer I agree.

I do not remember doing any kind of merging on the poetry.lock file.  I rarely have to anyways, I do not remember ever having to do so.  No other developer changed or committed that file.
Since I have already deleted it and recreated it, I have no idea how that duplicate entry was created, sorry.  I'll have my eye on that, next time I get a similar error.
I'll be closing the issue then, since this has been resolved.  Thanks for getting in touch, and keep up the good work.
I really enjoy using poetry (even though I hate the imposed complexity of all that python management and the associated tooling that is required to keep separate unique environments)


Fix doc typos and foggy explanation.

Fixes #92 by correcting some typos and refactoring parts of the prose to be clearer.

Thanks!


MQTT server in Go

I read: https://github.com/Geodan/gost/wiki/MQTT and the need for an MQTT server in Go. . I've been successfully working with products from InfluxData: https://www.influxdata.com/ like InfluxDB.
I saw this announcement:
https://www.influxdata.com/mqtt-surgemq-iot-influxdb-internet-of-things. The SurgeMQ is an MQTT Server in Go: https://github.com/influxdata/surgemq, maybe that is an idea for integration in GOST.

thanks for this tip, we'll consider it. Current solution we have works quite well, except there
were mosquitto crashes sometimes (see https://github.com/Geodan/gost/issues/40), maybe this is fixed in the meantime.

Yes SurgeMQ looks promising and was already on my radar, with the use of it we can remove the GOST prefix in the publish topics and also support ?$select=property1,property2 as described in Requirement 45. I will look into it when test level 3 passes (filtering)

I see some warnings on the SurgeMQ site: "development is currently on hold", "considered unstable until further notice"
Are there stable alternatives?

duplicate of https://github.com/gost/server/issues/136


TS-1228: Support new Forwarded standard

Code cleanup before implementation

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1095/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1202/ for details.


Add max of 20 to the Coupon Code in Edit Listing

A maximum of 20 characters has been added to the Coupon Code on the server, the client should have the same validation.

This is done (the max is set to 30 on the client to match the server).


spaces on files/folder names are not escaped

Describe the bug
Using bash. Consider a folder named "my backup". If I type "cd ", the autocomplete will show me the proper folder name, but when I select it, it will come without the escape character for the space (like "my\ backup"), causing the cd command to fail with the message "bash: cd: too many arguments".
To Reproduce
Steps to reproduce the behavior:

Create a folder in your current location called "my test"
Start "is"
type "cd "
Select the option "my test"
Press enter

Expected behavior
Selecting the "my test" folder from "is" list should result in a properly escaped result, like "cd my\ test". The escape pattern should follow the same rules as when we press "tab" in a bash shell.
Environment

OS: Linux Mint 21.3
Output of is --version: 0.0.1-rc.16
Nodejs Version:20.15.0
Shell: bash
Shell Version: 5.1.16(1)-release (x86_64-pc-linux-gnu)

Additional context
Add any other context about the problem here.

I can't replicate this, can you provide your logs from ~/.inshellisense/inshellisense.log after running inshellisense with -v? (please make sure to not run any commands with as it captures all the content that appears on the terminal screen).

Closing this due to lack of response. Let's see if this is an issue with 0.0.1-rc.17


[CI] Rationalize deployment of Boost dependencies

Introduce get-boost.sh as Boost downloader for all our CI services.
Credits for get-boost.sh idea go to @djarek and @boostorg/beast
References

Closes #276
Solves issue explained in https://github.com/boostorg/gil/pull/274#issuecomment-482022037

Tasklist

[ ] Review
[ ] Adjust for comments
[ ] All CI builds and checks have passed

@djarek Thanks for the tip. I just kept the depth as used in the original script
https://github.com/boostorg/beast/blob/2d4293c5141efeabf7394990aa21056bf6dff2b9/tools/get-boost.sh#L12-L14
Hmm, I don't see --depth used "on submodule updates". Or, is git clone-s use of --depth affect the git submodule? It doesn't seem like it for me from the Git docs.

Ah, shit, looks like I dropped it when I copied the script from the original repo:
https://github.com/djarek/certify/blob/master/tools/get_boost.sh#L13
It should be --depth=1 for the superproject and --depth=10(or a larger value if you want to be safer) for the submodules.

No value for submodule update is guaranteed to work. Or at least this was the case last I tried.

@djarek Thanks for checking.
@pdimov Is this related to git version?
Anyway, I'll try optimise the superproject download a bit later. Thanks for the tips.


Error when calling functions

When i call functions with params like (switchlevel) i get this error "'UnrealSharp.UEObject' cannot be marshaled as an unmanaged structure; no meaningful size or offset can be computed."

skill issue

partially fixed with https://github.com/shalzuth/UnrealSharp/commit/cac0bdbc791f79f632bafe8c7a2076aa13f089b0 for enums, still need to fix objects/structs though

thanks


FIX Tests

Adds a lot of coverage to the module

Codecov Report

Merging #1 into master will increase coverage by 34.22%.
The diff coverage is 77.77%.

@@              Coverage Diff              @@
##             master       #1       +/-   ##
=============================================
+ Coverage      2.64%   36.86%   +34.22%
- Complexity       88       94        +6
=============================================
  Files            11       11
  Lines           227      236        +9
=============================================
+ Hits              6       87       +81
+ Misses          221      149       -72

Impacted Files
Coverage Δ
Complexity Δ

src/Models/CodeTabExample.php
19.23% <0%> (+19.23%)
10 <0> (ø)
:arrow_down:

src/Traits/ParseHeadingsAsAnchors.php
90.9% <100%> (+90.9%)
10 <10> (+1)
:arrow_up:

src/Pages/UserDocsController.php
76.92% <100%> (+76.92%)
4 <0> (ø)
:arrow_down:

src/Models/CodeTab.php
48% <50%> (+48%)
21 <5> (+4)
:arrow_up:

src/Parsers/Shortcode.php
62.5% <85.71%> (+46.28%)
17 <0> (+1)
:arrow_up:

src/Models/CodeTabRequestParameter.php
16.66% <0%> (+16.66%)
7% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d65b01...5c589ca. Read the comment docs.


[SPARK-28275][SQL] Convert and port 'count.sql' into UDF test base

What changes were proposed in this pull request?
This PR adds some tests converted from count.sql' to test UDFs
Diff comparing to 'count.sql'

diff --git a/sql/core/src/test/resources/sql-tests/results/count.sql.out b/sql/core/src/test/resources/sql-tests/results/udf/udf-count.sql.out
index b8a86d4c44..9476937abd 100644
--- a/sql/core/src/test/resources/sql-tests/results/count.sql.out
+++ b/sql/core/src/test/resources/sql-tests/results/udf/udf-count.sql.out
@@ -14,42 +14,42 @@ struct<>

 -- !query 1
 SELECT
-  count(*), count(1), count(null), count(a), count(b), count(a + b), count((a, b))
+  udf(count(*)), udf(count(1)), udf(count(null)), udf(count(a)), udf(count(b)), udf(count(a + b)), udf(count((a, b)))
 FROM testData
 -- !query 1 schema
-struct<count(1):bigint,count(1):bigint,count(NULL):bigint,count(a):bigint,count(b):bigint,count((a + b)):bigint,count(named_struct(a, a, b, b)):bigint>
+struct<udf(count(1)):string,udf(count(1)):string,udf(count(null)):string,udf(count(a)):string,udf(count(b)):string,udf(count((a + b))):string,udf(count(named_struct(a, a, b, b))):string>
 -- !query 1 output
 7	7	0	5	5	4	7

 -- !query 2
 SELECT
-  count(DISTINCT 1),
-  count(DISTINCT null),
-  count(DISTINCT a),
-  count(DISTINCT b),
-  count(DISTINCT (a + b)),
-  count(DISTINCT (a, b))
+  udf(count(DISTINCT 1)),
+  udf(count(DISTINCT null)),
+  udf(count(DISTINCT a)),
+  udf(count(DISTINCT b)),
+  udf(count(DISTINCT (a + b))),
+  udf(count(DISTINCT (a, b)))
 FROM testData
 -- !query 2 schema
-struct<count(DISTINCT 1):bigint,count(DISTINCT NULL):bigint,count(DISTINCT a):bigint,count(DISTINCT b):bigint,count(DISTINCT (a + b)):bigint,count(DISTINCT named_struct(a, a, b, b)):bigint>
+struct<udf(count(distinct 1)):string,udf(count(distinct null)):string,udf(count(distinct a)):string,udf(count(distinct b)):string,udf(count(distinct (a + b))):string,udf(count(distinct named_struct(a, a, b, b))):string>
 -- !query 2 output
 1	0	2	2	2	6

 -- !query 3
-SELECT count(a, b), count(b, a), count(testData.*) FROM testData
+SELECT udf(count(a, b)), udf(count(b, a)), udf(count(testData.*)) FROM testData
 -- !query 3 schema
-struct<count(a, b):bigint,count(b, a):bigint,count(a, b):bigint>
+struct<udf(count(a, b)):string,udf(count(b, a)):string,udf(count(a, b)):string>
 -- !query 3 output
 4	4	4

 -- !query 4
 SELECT
-  count(DISTINCT a, b), count(DISTINCT b, a), count(DISTINCT *), count(DISTINCT testData.*)
+  udf(count(DISTINCT a, b)), udf(count(DISTINCT b, a)), udf(count(DISTINCT *)), udf(count(DISTINCT testData.*))

Tested as guided in SPARK-27921.

Test build #107427 has started for PR 25089 at commit c7b4c46.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12562/
Test PASSed.

Hey @vinodkc, thanks for taking a look for this one. Actually we should add output files too :-). Mind double checking the guide I wrote at SPARK-27921?

@HyukjinKwon , Thanks for the guidance, I've added output file now.

Test build #107429 has started for PR 25089 at commit b173330.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12564/
Test PASSed.

Looks fine if there are no output diff comparing to the original file

Test build #107427 has finished for PR 25089 at commit c7b4c46.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107427/
Test FAILed.

Test build #107429 has finished for PR 25089 at commit b173330.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/107429/
Test PASSed.

Merged to master.


[Improvement]: OptimizerController decoupling to OptimizerGroupController

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?
OptimizerController now have OptimizerGroup method,We hope to clarify the responsibilities of each component. When using external containers, we do not need to additionally host them on Amoro Optimizer.
How should we improve?

move OptimizerController optimizerGroup Methods to OptimizerGroupController
web ui role to OptimizerController and OptimizerGroupController

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Subtasks
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This seems quite reasonable!

This seems quite reasonable!

It is a part of #3038, and I will continue to follow up this part of work in the future


Early Adopter Program – Ministries Guideline

Describe the issue
A clear and concise description of what you want to happen.
Which Sprint Priority is this issue related to?
sprint 6 (Stretch goal) Organize early adopter program, aligned with other OCIO initiatives
Additional context
Add any other context, attachments or screenshots
Definition of done
Guideline document approved by Peter and ELT and socialized with MCIOs (this will take more than one sprint)

Initial draft of guidelines completed and submitted to Peter Watkins for review. Peter, Paul and Jenny discussed with Heather Remacle how to collaborate on onboarding of projects and guidelines.


Radial Button

Describe the issue
Radial Button Set when toggled multiple times in Unity Gaming Mode gets highlighted and executes the function Properly.
After deployment in HL2. When I click toggle the Radial buttons once and go for the second Toggling the radial button doesn't
respond and doesn't get selected. Therefore the respective function is not getting executed
Feature area
I am not sure. May be is it with deployment Problem as the function is working good in Unity but not in Hololens 2.
Existing doc link
If this is about something in an existing document, please provide link
Additional context
I would also like to Know how to Toggle between Radio Buttons. Example say I have two Radio Buttons. First I click Button 1 and the circle gets highlighted. When I a go and click the second one the First button does not get deselected so both the button gets highlighted.
Please do help me with it.

Hi @Avinash0795 which version of MRTK are you using?  An issue similar to the one you have described was addressed in 2.5
Issue: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/8517
PR: https://github.com/microsoft/MixedRealityToolkit-Unity/pull/8533

I am using 2.4.0 sir. I have not checked with 2.5 release

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Add CollectionIndexOnNonIndexedSeq rule

Inspired by https://twitter.com/jshrsn/status/865677863646658560, this patch adds a new IndexingOnANonIndexedSeq rule which raises a warning when we see code which indexes on a Seq which isn't known to be an IndexedSeq subtype. The goal here is to make it easier to prevent cases where someone writes an O(n^2) loop by accident.
This rule might have prevented the following Spark bugs:

https://github.com/apache/spark/pull/18005
https://github.com/apache/spark/pull/8178
https://github.com/apache/spark/pull/15221

In order to avoid false-positives from the use of .apply(0) instead of .head I chose to ignore all cases where the index is a literal.

:+1:


Implement VideoToolbox-powered H.264 encoder for macOS

Changes / Notes

This PR is based / depends on Nexarian/xrdp/mainline_merge

This PR adds H.264/yuv420 support for macOS.

This PR contains Obj-C codes; these codes may not meet coding convention of this repository.  (I thought it had to be written in Objective-C, but it wasn't.)

Initialization of VTCompressionSession will fail if fork=true in xrdp.ini

TODO

[x] add support for dynamic-sized drects
[x] set kVTVideoEncoderSpecification_EnableHardwareAcceleratedVideoEncoder to true
[x] (if possible) rewrite codes in C

@jsorg71 and I are working on how to merge in everything into devel, but I'm afraid it might be a while. There's a lot to test and make sure is right. I suggest taking the pieces from mainline merge and working with us to build a plan on what should go first, and what can wait.

I agree with @Nexarian's comment above. I'm happy to contribute to the review when you think the time is right. In the meantime, the CI pipeline should at least now be working on this PR.

Hi Gyuhwan,
You wrote:

DESCRIPTION OF PROBLEM
Hello, we are implementing macOS support for an open source remote desktop project called xrdp.
We are implementing a feature to compress image data with h.264 codec to save bandwidth, but when the daemon process fork(), VTCompressionSessionCreate() fails to initialize and returns -12903( kVTInvalidSessionErr).
If VTCompressionSessionCreate() is called without fork(), initialization succeeds normally.
Is there something we are doing wrong?
(+ I heard before that there is a problem that fork() breaks the Objective-C runtime library (Foundation?), is the VideoToolbox code written in plain C also affected?)
STEPS TO REPRODUCE

call fork()
call VTCompressionSessionCreate() from child process

It seems that you’re calling fork without calling exec*. Is that right?
If so, that’s not supported on macOS. Many Apple frameworks use Mach messaging to communicate with helper processes, for example, launchd daemons and agents. Mach messaging and fork don’t play well together. The child inherits the parent’s memory but it does not inherit the parent’s Mach port namespace. So the child thinks it has access to a bunch of Mach services but it doesn’t.
Many of the most-commonly used frameworks, like Foundation, have asserts that detect this situation. It seems that VideoToolbox is reporting an error in this case.
In short, if you call fork without calling exec* you will run into problems. If you’re porting Unix-y code that relies on this then you may get away with this, but not if you use any of Apple’s frameworks.
If you're spinning up a new process for some VideoToolbox work, most folks use threads for this sort thing.
Apple Developer Technical Support

@unstabler - one way to solve this might be to re-exec xrdp after the xrdp fork() call, but ensure the child gets the file descriptor from the accept().
I'm currently working on a branch where I've implemented some of what we'd need for this. If you're interested, let me know and I'll open a feature request where I can add more detail.

@matt335672
I was also working on this part: https://github.com/team-unstablers/xrdp-tumod/pull/1 .
However, I was worried that my work did not fit the overall direction of this project, so I forked it under the name xrdp-tumod.
If I complete https://github.com/team-unstablers/xrdp-tumod/pull/1 , I will post a PR on xrdp as well.

Thanks for the update.
I'm currently looking at splitting sesman into two executables to fix some long-standing problems. I've got to solve some of the same problems you have to get it working securely.
If you want me to review anything, let me know. We probably don't want these to drift too far apart.

@matt335672
Then, if you don't mind, I would like to request a partial review of https://github.com/team-unstablers/xrdp-tumod/pull/1, although the work is not that advanced yet. (+ can I post this PR to here?)
Also, I need to reconstruct the struct trans in the child process, should I pass the contents of the fields needed for reconstruction to the child process through args[] and assign them directly in the child process?

@matt335672
Then, if you don't mind, I would like to request a partial review of https://github.com/team-unstablers/xrdp-tumod/pull/1, although the work is not that advanced yet. (+ can i post / move this PR to here?)
Also, I need to reconstruct the struct trans in the child process, should I pass the contents of the fields needed for reconstruction to the child process through args[] (or piping) and assign them directly in the child process?
(sorry for repost!)

To reconstruct a struct trans, I suggest you pass just the file descriptor over, and then just set up a new one in the child.
You can either leave the file descriptor open and pass the number over, or use libipm to pass the file descriptor directly. The first is easier to set up, but the second lets you close the file descriptor safely in the parent if that's what you want to do, without a race condition.
I've got examples of both in my split_session_driver branch, but be aware this is changing quite a lot at the moment.


UnifiedDiffParserException on apparently sane file (2nd variant)

Describe the bug
UnifiedDiffReader.parseUnifiedDiff throws UnifiedDiffParserException on a patch which apparently looks good:
https://raw.githubusercontent.com/bazelbuild/bazel/master/third_party/aws-sdk-auth-lite/patches-vs-1.11.297/01-bazel-strip-unused.patch
To Reproduce
Run this program:
String patch = new Scanner(new URL(
    "https://raw.githubusercontent.com/bazelbuild/bazel/master/third_party/aws-sdk-auth-lite/patches-vs-1.11.297/01-bazel-strip-unused.patch"
).openStream(), "UTF-8").useDelimiter("\\A").next();

UnifiedDiffReader.parseUnifiedDiff(new StringBufferInputStream(patch));

Expected behavior
No Exceptions.
Actual behavior
Dec 14, 2020 9:49:46 PM com.github.difflib.unifieddiff.UnifiedDiffReader processLine
WARNING:   >>> no rule matched \ No newline at end of file
Exception in thread "main" com.github.difflib.unifieddiff.UnifiedDiffParserException: expected file start line not found
at com.github.difflib.unifieddiff.UnifiedDiffReader.parse(UnifiedDiffReader.java:95)
at com.github.difflib.unifieddiff.UnifiedDiffReader.parseUnifiedDiff(UnifiedDiffReader.java:146)
...
System

Java version: openjdk-11
Version: 4.9

Notes
:wave: java-diff-utils maintainers again! Here is another corner case I found. The patch comes from the Bazel project, so once again it's OK to include in tests.

That is a nice huge diff. The new implementation of java-diff-utils will gain a lot of testing on this large file base. I will look into it.

Thanks a lot @wumpz! I might have other cases as well for you later, as I plan to test each and every patch from CentOS and likely other open source projects as well :wink:

To somehow document this: https://stackoverflow.com/questions/5813311/no-newline-at-end-of-file.
This weird
\ No newline at end of file

is put into a diff by Git to signal, that there is no linefeed at the end of the last line of this diff.

So my implementation stores this as a flag within UnifiedDiffFile, so the write can write those lines without putting a linefeed at the end. I hope that is right.

Just deployed a new version.

@wumpz I am still getting the same exact error when I try to parse this patch from this JIRA ticket.

@elanzini I will look into it.

@elanzini May I include this patch as test data into java-diff-utils? I already solved the problem and would like to use your test data.

@wumpz by all means! I found other examples, I will add them to #122. And thanks for the quick fix!

@wumpz I found other examples for this problem https://github.com/pgjdbc/pgjdbc/commit/cdeeaca47dc3bc6f727c79a582c9e4123099526e or https://github.com/apache/cxf/commit/1cf4fed546904a4a2560f53a2a2391d834b4026. For both, if you try to parse the diff, you get the same complaint WARNING:   >>> no rule matched \ No newline at end of file.

@elanzini I included all three of your tests. They are now succeeding.

same problem here :)
I just found that the latest released version (4.10) did not contain this change
When will 4.11 will be released? Looking forward to it and thanks!

Still no valid date there, since I wanted to include the new implementation of meyers linear space diff algorithm.


TSSERVER: import {…} from '//some/path' chokes tsserver/code (overloads CPU)

TypeScript Version(s):  2.7.0-rc 2.7.2 2.8.0-dev***

Search Terms: tsserver overloads ………………………
Code
// helpers.m.js
export { html, render } from '//node_modules/lit-html/lib/lit-extended.js';

Expected behavior:
Resolve at best, report issue at worse.
Actual behavior:
VS Code's tsserver sub process overloads CPU (sometimes 101% whatever that is)
Workaround:
This makes VS Code happy, but makes the code less compatible with requirements.
// helpers.m.js
export { html, render } from '/node_modules/lit-html/lib/lit-extended.js';

Playground Link:
Related Issues:
https://github.com/Microsoft/TypeScript/issues/21274

Can you please elaborate on what your file system looks like? // is seen as a network path; is that what you're intending?

I'm on a macOS 10.13.3 (17D102)
Volume type: APFS Volume
BSD device node: disk1s1

Workspace path is a "no-spaced" path like /Users/XX/Projects/XX.js/modules/module-name/ and I got rid of all ts/jsconfig files.
The runtime is not relevant and is not a factor since simply switching from //node_modules/… to something like app:node_modules/… or whatever://… or even just /node_modules/… seems to resolve the issue.
So, to reiterate, no possible configuration (ie ts/jsconfig) had any impact on this bug and there are no special path aspects (not even a single symlink in any of the search paths.

Some "good" code --status (without the //node_modules/… specifier):
Version:          Code 1.21.0 (9a199d77c82fcb82f39c68bb33c614af01c111ba, 2018-03-07T10:54:22.798Z)
OS Version:       Darwin x64 17.4.0
CPUs:             Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2600)
Memory (System):  16.00GB (4.26GB free)
Load (avg):       2, 2, 2
VM:               0%
Screen Reader:    no
Process Argv:     /Applications/Visual Studio Code.app/Contents/MacOS/Electron

CPU %	Mem MB	   PID	Process
    0	   115	  5238	code main
    0	    98	  5240	   gpu-process
    0	    82	  5242	   shared-process
    0	   229	  5552	   window (helpers.m.js — slicer)
    0	    33	  5558	     terminal
    0	     0	  5559	       /usr/local/bin/zsh -l
    0	    98	  5563	     extensionHost
    0	    98	  5574	       electron_node electronForkStart.js tsserver.js
    0	    49	  5593	         electron_node typingsInstaller.js tsserver.js typesMap.js
    0	    49	  5568	     watcherService
    0	    49	  5576	     searchService

Workspace Stats:
|  Window (helpers.m.js — slicer)
|    Folder (slicer): 20 files
|      File types: js(11) DS_Store(3) json(2) x(2) html(1) lock(1)
|      Conf files: settings.json(1) package.json(1)

Some bad ones:
Version:          Code 1.21.1 (79b44aa704ce542d8ca4a3cc44cfca566e7720f1, 2018-03-14T14:39:09.335Z)
OS Version:       Darwin x64 17.4.0
CPUs:             Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2600)
Memory (System):  16.00GB (4.60GB free)
Load (avg):       2, 2, 2
VM:               0%
Screen Reader:    no
Process Argv:     /Applications/Visual Studio Code.app/Contents/MacOS/Electron

CPU %	Mem MB	   PID	Process
    1	   131	  5973	code main
    0	    98	  5975	   gpu-process
    0	   262	  5976	   window (helpers.m.js — conres-demo-electron)
    0	    33	  5983	     terminal
    0	     0	  5984	       /usr/local/bin/zsh -l
    2	   115	  5990	     extensionHost
   99	   131	  6001	       electron_node electronForkStart.js iq.js tsserver.js
    0	    49	  6020	         electron_node iq.js typingsInstaller.js iq.js tsserver.js typesMap.js
    0	    49	  6002	       electron_node jsonServerMain.js
    0	    82	  6003	       electron_node htmlServerMain.js
    0	    49	  5995	     watcherService
    0	    49	  6005	     searchService
    0	    82	  5977	   shared-process

Workspace Stats:
|  Window (helpers.m.js — conres-demo-electron)
|    Folder (conres-demo-electron): 178 files
|      File types: js(74) mjs(25) DS_Store(15) json(9) html(8) css(7) md(5)
|                  ts(4) log(3) lock(3)
|      Conf files: package.json(4) settings.json(2) tsconfig.json(1)

This is the case for both latest code and code-insiders from TS versions 2.7.0-rc 2.7.2 and 2.8 dev.

Investigating this..

Thanks!


Remove unused fixme on dump command

Since all public keys are also stored in database and database will be dumped to file. Then it's no need to copy the public keys file from .ssh/. So let's remove this wrong FIXME comment.

LGTM

LGTM


When analyzing more genes, gene names and percentages are not aligned in coOncoplot

Hi, when I used coOncoplot to compare mutation frequency between two cohorts, I focused on 37 important genes. It is very convenient and works very well. But the gene names and percentages are not aligned in the output figure. And I tried less genes like 5 genes, it has good alignment. I tried to add   arguments to control, none worked. So, how can I address this problem? Thanks!

Is it possible to share the image ?

Hi,
Thanks for reporting the issue. It was indeed a bug when the number of genes are larger. I have fixed it. Could you please install from GitHub and let me know if this helps ?

Hi, I have installed the latest version and it has good alignment now! Thanks for your update! It is very useful!


[mimalloc] update to v1.7.2

Fix #20155
Update mimalloc to the latest version 1.7.2
All feature are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

Thanks for the update!


prevent downloading images videos audio  etc... everything (Except javascript file)

hi
is there a way  to
prevent downloading images videos audio  etc... everything (Except javascript file).
if there that would be super . thank you

These files are normally not downloaded. If you enable resource loading you can prevent downloading such files by setting a proper filter for the requester. In your case I would only let requests pass that end with ".js" (or which originate from a script element).


Is there a document to explain method of use.

Is there a document to explain method of use, I don't know how to start，urgent need to use，Does anyone know，thanks.

The top-level readme lists two examples:
https://github.com/kubernetes/client-go/blob/master/examples/in-cluster/main.go
https://github.com/kubernetes/client-go/blob/master/examples/out-of-cluster/main.go
Do those help?

others?example,create pods,create namespace,delete pods...@lavalamp

I don't think we have a great source. You can look at godoc, which isn't terrible, here:
https://godoc.org/k8s.io/client-go/kubernetes
Drill in for specific objects like Pods: https://godoc.org/k8s.io/client-go/kubernetes/typed/core/v1#PodInterface

Agreed that a few more examples would be extremely helpful.
E.g, I'm looking for how to create new jobs. I found the JobInterface docs, with a Create method, but have no clue how to even get started using that, as it in itself takes Job interface, etc.
Everything is so dispersed, without no seemingly clear starting point. Thus, would really much hope to see a bunch of more examples.

Thanks for the feedback! #128 is tracking this now.


Pie chart and areas Chart not color-coded

Maybe a problem bound to the big amount of possible colors?
The data legend under the pie chart contains the needed elements and the tooltip on the chart correctly identifies the various components, but every pie segment is blue. In the “filter” list on the right side it is possible to manually change the color of a single value, which is actually not part of the pie
To Reproduce

open following Visualization
https://int.visualize.admin.ch/it/v/Sm2aulFahho-
https://int.visualize.admin.ch/it/v/CzLwRaMHotcb

Expected behavior
Each element in the legend gets its own color
Environment (please complete the following information):

INT v3.4.2 ([3e72a7d]
Browser : ?

Additional context
It is possible to build a pie chart with the very same data but other settings and get a correctly colored one. See https://int.visualize.admin.ch/fr/v/nA6OHSEEZJ3d
Maybe a problem bound to the big amount of possible colors?
@AFoletti

Mmh weird. When I clone the chart and change the color palette, then change it again to the first one, I have a good looking result.

Can this issue be reproduced or can it be closed?

You can close it.


Fix a flaky test, caused by xml string comparison

Description

Type of change :

[ ] New feature
[ ] Bug fix for existing feature
[ ] Code quality improvement
[X] Addition or Improvement of tests
[ ] Addition or Improvement of documentation

Fixed a flaky test, which implicitly relies on the serialization order when generating an XML string.
Root Cause
The original test tried to compare a hard-coded XML string with another dynamically generated XML string, but the generated XML string has indeterminate order of properties, the test is thus flaky.
Fix
Given that in this particular test, the properties have only two possible orders, we can simply list out all permutations, and compare them with the generated XML string.
Key changed/added classes in this PR

ReportUtilsTest

please refer contributor guide: https://github.com/karatelabs/karate/blob/master/.github/CONTRIBUTING.md
this test has never been flaky so will close


Decide on frontend frameworks

This issue is like a poll,
We can go for React, Angular or plain JavaScript/jQuery

React, because it is Super-easy.

Looks good, will finalize the tech stack in a couple of weeks.

Angular, because it's awesome!

You should remove the hacktoberfest label from this if people are not able to submit a pull request to close the issue.

Yes @Fedelaus

You might consider VueJS as well.
https://vuejs.org/v2/guide/

@davidangel mostly we will go for React, although I am looking whether angular and Vue has good integration with Electron. So as of now, it is not finalized.


Institution User can View Read Only BCeID Information on account set up

As a (Institution User) I want *( want to view the Read-Only Business BCeid information, So That *(I can confidently ensure that SABC has the correct information.
Additional Context

The information from Business BCeID includes Given Names, Last Name,  email, and Institution
When Business BCeID information is updated, then the information will be updated on the SABC account).- Another User Story
-The information from Business BCeID is viewed as read-only.

Acceptance Criteria

[ ] (The Institution User), When (has been redirected to the SABC Site after authentication, Then they can view the information that has been received from the Business BCeID site (First Name, Last Name, Email and Legal Institution Name (NOT GUID)
[ ] Given (The  Institution User has been redirected to the SABC Site ), When (they are viewing the Business BCeID information) Then, this information is there but it greyed out and may not be updated.

Technical Tasks

[ ] Create webservice call to retrieve additional info (SOAP Client)
[ ] Display required info
[ ] ...
[ ] ...
[ ] ...
[ ] ....

Reference Docs
https://github.com/bcgov/ocp-sso/wiki/3.2-Identity-Provider-Attribute-Mapping

Please find below some documentation for BCeID Attribute Mapping

Source: https://github.com/bcgov/ocp-sso/wiki/3.2-Identity-Provider-Attribute-Mapping


Assign directly to Polymer.Templatizer

This is easier for jscompiler to understand.

@aomarks #4870 jinx!


Go: Enable variants tests

I want to reopen this issue with #601 . I will report to the tinygo team to investigate this runtime issue.


reduce version definitions in POMs

The PR removes the <version> tag from each POM where it is not necessary.
Changes:

use ${project.version} for dependency versions
inherit <version> where possible
define parent <version> via inherited property ${revision}

Question: Is the flatten-maven-plugin needed as documented here?
The version definition locations can even be reduced further to one by using a .mvn/maven.config file defining revision.

Hi @CCFenner, have you tried introducing a .mvn/maven.config file defining revision? If that reduces the places we need to make manual changes, maybe we can implement that directly in this PR? Thanks!

Yes, that works, will update the PR.

CircleCI still has unauthorized. issue, at least when I trigger it via commit/rebase.


Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Can add a chatbot in the website for better user experience.
Use Case
This will enhance user experience with a special feeling with chatting.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Trisha-tech  Please assign me for this issue.

@Trisha-tech Please assign me for this issue.

Kindly elaborate a little bit more how you are going to integrate the chatbot for better user experience.

@Trisha-tech
I have two different methods:

With the help of GPT.
By JavaScript.

But the problem is that in my local server the Website(index.html) is not opening properly.
And that's why I am not able to see that is it working properly in the website or not.

@Trisha-tech  If you know any solution for the above problem then, please let me know, because my code for chatbot is ready.

@Suman373  I am learning ReactJs. So, for now I know basics but haven't worked with this till now.

@Suman373 I am learning ReactJs. So, for now I know basics but haven't worked with this till now.

It will be better if we stick to the React ecosystem as integrating complex features in plain index.html will produce bugs in the future. I'd ask @Trisha-tech  to look into this matter. Till then look into more issues or bugs that you can fix with your current skill set 😊!


Action fails on npm v9

Hey there!
Your action is failing on npm v9 (https://github.com/ZPTXDev/Skeleton/actions/runs/4260689937/jobs/7414136107).
I believe it's the same issue creyD/prettier_action faced (https://github.com/creyD/prettier_action/issues/113).
Hopefully this helps you to solve the issue. Thanks!

Hi @zapteryx,
thank you so much for reporting here.
The issue is due to the removal of npm bin starting from npm version 9.
The same problem affected my other reviewdog-based action: https://github.com/EPMatt/reviewdog-action-prettier/issues/34
I've just published v1.4.1, which includes a fix for this issue.
If the problem persists, please don't hesitate to open a new ticket.
Thank you so much!

Thank you for the fix. It's working great!


DOCS: Add Project-Setup guide

@kvcops I proposed to add a proper Project setup-guide that will be used to create & setup the firebase project on the Contributors side. This will allow new contributors to easily setup the project on their end.
As the project uses Firebase for Database & Storage I will add the proper steps in simple words, with a proper video clips if possible.
Optional: I would add steps with clips to get all the API keys.

As discussed in above approach I will raise the PR in few days, as Diwali Break is due.

@yashksaini-coder update?

@yashksaini-coder you have 24 hours to reply, after which I will be closing this issue.

@yashksaini-coder you have 24 hours to reply and raise a PR as this is a level 1 issue, after which I will be closing this issue.

Got it. I will raise the PR as soon as I get time after clg


error running mnist_with_summaries.py on 1.0.0rc0

I opened native optimization on CPU and the new memory allocation option during configuration
I run the file mnist_with_summaries.py, when the code run into
    if i % 100 == 99:  # Record execution stats
      run_options = tf.RunOptions(trace_level=tf.RunOptions.FULL_TRACE)
      run_metadata = tf.RunMetadata()
      summary, _ = sess.run([merged, train_step],
                            feed_dict=feed_dict(True),
                            options=run_options,
                            run_metadata=run_metadata)
      train_writer.add_run_metadata(run_metadata, 'step%03d' % i)
      train_writer.add_summary(summary, i)
      saver.save(sess, log_dir+"/model.ckpt", i)
      print('Adding run metadata for', i)

I got error
I tensorflow/stream_executor/dso_loader.cc:116] Couldn't open CUDA library libcupti.so.8.0. LD_LIBRARY_PATH: /usr/local/cuda-8.0/lib64:/usr/local/lib:/usr/lib:
F tensorflow/core/platform/default/gpu/cupti_wrapper.cc:59] Check failed: ::tensorflow::Status::OK() == (::tensorflow::Env::Default()->GetSymbolFromLibrary( GetDsoHandle(), kName, &f)) (OK vs. Not found: /home/wenjian/anaconda3/lib/python3.5/site-packages/tensorflow/python/_pywrap_tensorflow.so: undefined symbol: cuptiActivityRegisterCallbacks)could not find cuptiActivityRegisterCallbacksin libcupti DSO

seems that I need to add /usr/local/cuda-8.0/extras/CUPTI/lib64 to LD_LIBRARY, solved it


feat: send keymap use submit function instead of writing buffer

Description
related discussion: #147
The buffer sending on write is nice and convenient, but forcing all implementations of send to use this mechanism can be limiting.
Implementing send using the submit function on the Chat object makes it possible to set buftype=nofile which greatly improves the experience for users of the hidden setting
Currently, with set hidden, when the chat window is toggled off after being modified, quitting neovim will be blocked by the No write since last change error which is very annoying, as the user must now force quit, or re-open the chat buffer and close it definitively (e.g. using <C-c>)
With this change, my toggle keymap looks like this and I get no issues when closing neovim:
vim.keymap.set("n", "<leader>gpt", function()
    codecompanion.toggle()
    local current_buffer = vim.api.nvim_get_current_buf()
    local buffer_name = vim.api.nvim_buf_get_name(current_buffer)
    if string.find(buffer_name, "%[CodeCompanion%]") then
        vim.api.nvim_buf_set_option(0, "buftype", "nofile")
    end
end)

Checklist

[x] I've read the CONTRIBUTING guidelines.

Absolutely down for this. I'll try it out tomorrow.

Presume we can remove the set hidden, and set the buftype=nofile with this approach?

Presume we can remove the set hidden, and set the buftype=nofile with this approach?

set hidden is part of my config and behavior I like neovim to have. buftype=nofile is an option I want the chat buffer to have so that neovim doesn't warn me when I close it without saving (in fact it makes it impossible to save the buffer at all).
Those two options are my personal preferences, the reason I submitted this change, is so that the chat buffer still works if a user has chose to set  buftype=nofile in the buffer.
An easy way to test this out, is to open that chat window and run:
:lua vim.api.nvim_buf_set_option(0, "buftype", "nofile")
So if this PR is merged, I would still keep the keymap I have above, which is applying my personal preferences to the buffer.
If other people want this behavior as well they can use a similar keymap, it might also be possible to do this with some autocmd but this worked for me.
In the linked discussion I suggested as a follow-up it could be interesting to discuss adding a config setting that would make the chat buffer nofile. If that were added then I could remove everything from my keymap and just use :CodeCompanionToggle directly

Just tested, and interestingly, even after making the buffer 'nofile', the :w behavior still works, sending the chat to the LLM!

So doing the following:

Changing the keymap as per this PR
Removing the line api.nvim_buf_set_option(bufnr, "buftype", "acwrite") from chat.lua
And removing the BufWriteCmd:

  api.nvim_create_autocmd("BufWriteCmd", {
    group = aug,
    buffer = bufnr,
    desc = "Submit the CodeCompanion chat buffer",
    callback = function()
      self:submit()
    end,
  })

Keeps the chat buffer hidden from my buffer lists, keeps functionality of the chat buffer the same and stops the annoying error message E162: No write since last change for buffer "[CodeCompanion] 2646937"

Apologies if I misunderstood you in my last reply!
Yes, I think that should work, if you want to put the change on a branch I'm happy to try it out.
FWIW I'm not sure it's necessary to remove the BufWriteCmd? In my branch :w still sends to the LLM, if this is an interaction type you think is desirable it may be possible to keep it.

Awesome. Have done so here.

Been using these changes locally for a few days and they work like a charm. Of the removal of bufwrite doesn't break any existing flows then I think this is a great change!

Thanks so much for testing it out


Provide remixable content for open virtual worlds via glTF2 extensions

Context and Problem Statement
Independent meta-verses (virtual worlds) lack content because their communities are too small to fund much content work.
Describe the feature / enhancement and how it helps to overcome the problem or limitation
Collaborate with Mozilla Hub's Spoke Editor and OMI Group's glTF2 extensions to have portable world content.
Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
Provide basic glTF2 extensions. Here is an initial list.

URI scene linking
Archive binary format
Audio emitters

If this enhancement will not be used often, can it be worked around with a few lines of script?
There are many moving parts and a web client, which is not a few lines of code.
Positive Consequences

Easier creation of new virtual worlds.
Encourage remixing content
Keeping old content portable to new virtual worlds

Negative Consequences

Have to find different monetization means for independent virtual worlds

Is there a reason why this should be core and done by us?
No one is doing it.
References

https://github.com/ubisoft/mixer/issues/19

Derivative License
Copyright (c) 2020-2021 V-Sekai contributors.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
 IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

Added by https://github.com/V-Sekai/v-sekai-proposals/commit/25417a6ce9639f3831a1a68f73d755359a153537