Reset password is missing storeCode in request

Current behavior
When I'm using the reset-password functionality, a POST request is done to /api/user/reset-password. This returns a 500 status with the following error:
TypeError: Cannot read property 'websiteId' of undefined
    at userApi.post (***/vue-storefront-api/src/api/user.js:123:52)
    at Layer.handle [as handle_request] (***/vue-storefront-api/node_modules/express/lib/router/layer.js:95:5)
    at next (***/vue-storefront-api/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (***/vue-storefront-api/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (***/vue-storefront-api/node_modules/express/lib/router/layer.js:95:5)
    at ***/vue-storefront-api/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (***/vue-storefront-api/node_modules/express/lib/router/index.js:335:12)
    at next (***/vue-storefront-api/node_modules/express/lib/router/index.js:275:10)
    at Function.handle (***/vue-storefront-api/node_modules/express/lib/router/index.js:174:3)
    at router (***/vue-storefront-api/node_modules/express/lib/router/index.js:47:12)

Expected behavior
A POST request is done which returns a 200 status when a valid email address is provided. Thereby, the email to reset your password is send to the valid email address
Steps to reproduce the issue

Click on the user icon in the right top
Click on "Forgot the password?"
Submit a email address and click "Reset password"
Check your network requests in the console

Repository
https://github.com/DivanteLtd/vue-storefront/blob/5c73791cefcb6fc990d864cd5437e4793ac0725c/core/modules/user/store/actions.ts#L47
https://github.com/DivanteLtd/vue-storefront/blob/5c73791cefcb6fc990d864cd5437e4793ac0725c/core/data-resolver/UserService.ts#L13
Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[x] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser: Google Chrome, 78.0.3904.108
OS: macOS Catalina, 10.15.1
Node: 10.9.0
Code Version: branch release/v1.11

Additional information
I'm not sure if this issue has to be fixed in the front or in the API. Could be related to: https://github.com/DivanteLtd/vue-storefront/issues/3695

Good point there; the processLocalizedURLAddress helper, however, should add this storeCode parameter to the API url as long as you've got the config.storeViews.multistore set to true

processLocalizedURLAddress adds storeCode (exacly adjustMultistoreApiUrl do this). It fails when we have config.storeViews.multistore set to false. We just need to send websiteId: undefined in api so magento will use default store. https://github.com/DivanteLtd/vue-storefront-api/pull/382


Set video props after its loaded

The reason for this, is that Safari would not accept some of the properties such as playbackRate until the video is loaded. PlaybackRate did not work in Safari before. It does now.
In order to pass your tests, I needed to set the properties before and after the video load. This is not horrible as it sets the settings as early as it can for browsers that work that way. Then it sets them again after the video has loaded.

Thanks.


Caching and Pagination ?

Hi, I'm having a little trouble getting Rails caching to play nicely with this gem. Here's some psuedo code that matches my code fairly well:
# Shows HTTP paging headers, but loads everything into memory
def user_posts
  cache_key = {
    user_id: current_user.id,
    latest_post: current_user.posts.maximum(:updated_at)
  }

  posts = Rails.cache.fetch(cache_key) do
     current_user.posts.order('created_at DESC')
  end
  render json: paginate(posts), each_serializer: PostSerializer
end

If I do this, I will get the api_pagination HTTP headers. However, I'm loading all of the current_user's posts into memory, which seems like a bad thing.
If I paginate inside the caching block (like below), then I don't get any api_pagination HTTP headers.
# Doesn't show HTTP paging headers, but doesn't load everything into memory
def user_posts
  cache_key = {
    user_id: current_user.id,
    latest_post: current_user.posts.maximum(:updated_at),
    page: params[:page]
  }

  posts = Rails.cache.fetch(cache_key) do
     paginate(current_user.posts.order('created_at DESC'))
  end
  render json: posts, each_serializer: PostSerializer
end

Can someone point me in the right direction? I'm having a hard time googling for API Pagination and Rails caching. Perhaps I'm missing something fairly obvious. I'm using kaminari, if that helps.
Thanks so much!

@danramteke Is your app open source, by any chance? If not, would you be able to reproduce this in a fresh rails app using kaminari and api-pagination and send me the app's code?

Just had the same problem. paginate overrides render method so in order to get the correct (full) headers in case the request hit the cache, we have better to paginate what the cache returns instead of paginating inside the cache block.
Something like the following should work:
...
posts = Rails.cache.fetch(cache_key) do
  current_user.posts.order('created_at DESC')
end
paginate json: posts, each_serializer: PostSerializer
...

Hi!! Did anyone find a solution for this? I am having the same issue...

Hey all, sorry that there's still an issue with this. I'm still happy to look into this, but I haven't experienced the issue, so having access to the source code of one of these apps that I can run locally would help. Or even just a dummy Rails app that's set up to reproduce the problem.

Hello @davidcelis! Thanks for the reply... I have created a toy project to test this (https://github.com/alemata/pagination_and_cache)
I know this is not the ideal code to test but it's an idea of the issue
Ideeally we should be able to paginate... store that page result in cache and send the responde with pagination headers...
Sorry if I am being not so clear... please ping me with any question

@davidcelis I just discover that perhaps
properties = Property.search(params)
final = Rails.cache.fetch(Property.cache_key(properties)) do
  (paginate properties).to_a
end

paginate final

could work but it's not so nice...

@davidcelis were you able to review this?!  was the project helpfull?

Ok I think I make it work...
# call paginate outside cache to add headers
paginated = paginate Property.all
paginated_collection = Rails.cache.fetch(Property.cache_key(properties)) do
  # Store just the collection in cache (`paginate method returns the collection`)
  paginated.to_a
end

paginated_collection

I am not sure if there is a nice way to improve this inside the gem...


CommandLine property is empty when user has insufficient privileges

Steps to reproduce
Install Oracle XE 11g
 (ps -Name TNSLSNR).CommandLine

Expected behavior
C:\oraclexe\app\oracle\product\11.2.0\server\bin\tnslsnr.exe

Actual behavior
No output

Environment data

Name                           Value
----                           -----
PSVersion                      7.1.0
PSEdition                      Core
GitCommitId                    7.1.0
OS                             Microsoft Windows 10.0.19041
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

It works with PowerShell running as Administrator.

Isn't this just an issue of access rights?
None of the windows management tools I know of displays a command line for admin processes when executing under a non-privileged account.
You have to read the memory of the other process to determine the command line, and you don't have the required rights to do that.

What was your expectation?

When I run the Task Manager using Ctrl-Alt-Del it shows the command line of the process. Is it running using Admin privileges?

You have to read the memory of the other process to determine the command line, and you don't have the required rights to do that.

Fair enough. I think this is what PowerShell should tell the user. Then you know what to do. It is not obvious that you are allowed to read the rest of the information about the process, but not the command line.

Fair enough. I think this is what PowerShell should tell the user. Then you know what to do. It is not obvious that you are allowed to read the rest of the information about the process, but not the command line.

Hard to do for a property.  PowerShell by design swallows any exceptions that a property getter throws and instead just displays nothing.

IMHO that is not how exceptions are supposed to be used. An exception should be thrown when something unexpected happens and of course the user should know about it.
PowerShell happily throws up lots of red text due to a syntax error, but it remains silent when an exception occurs?

Only when thrown by the method that obtains a value from a property.  Note that I'm not necessarily saying it was or wasn't a good idea, but changing it now would break a lot of folks.

Task manager is a special process where it's run as elevated by default without having to prompt through UAC. It's signed by a specific Microsoft cert which allows it to do so and that's why it can see the command line. So you need to be running as admin and the only action I can reliably see here is for the docs to be updated to state that is the case. As @SeeminglyScience says, changing the behaviour now could break existing scripts so not really something that could be done.

Thank you for the detailed explanation. I wanted to know how the Task Manager does it.
Yes, I also wanted to suggest updating the docs.
Am 18. Dezember 2020 23:39:38 MEZ schrieb Jordan Borean<EMAIL_ADDRESS>
Task manager is a special process where it's run as elevated by default
without having to prompt through UAC. It's signed by a specific
Microsoft cert which allows it to do so and that's why it can see the
command line. So you need to be running as admin and the only action I
can reliably see here is for the docs to be updated to state that is
the case. As @SeeminglyScience says, changing the behaviour now could
break existing scripts so not really something that could be done.


request from the specific controller's spec to another controller

I have a spec to test the controller data. I use json request to get CSRF token and then access to method on another controller:
RSpec.describe Api::V1::Lp::PhonesController, type: :controller do

currently I can't get CSRF as follows:
post :auth, params: auth_attributes

since the access is going to the absent route, therefore it is present for another controller only. So is there a way to make a post request from the specific controller's spec to another controller? Or get te CSRF token with any other way inside the controller spec space?

You either need a full integration test for this, or you can generate a token in the spec and pass it in that way.


Deprecation warnings for HorizontalPodAutoscaler and PodDisruptionBudget

I was installing Istio on a local k8s v1.22 cluster and got the following warnings during the install:
Warning: autoscaling/v2beta1 HorizontalPodAutoscaler is deprecated in v1.22+, unavailable in v1.25+; use autoscaling/v2beta2 HorizontalPodAutoscaler
Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
Based on a quick glance, looks like it's an upstream istio issue (all the results I found were in third-party/istio-latest or third-party/istio-head), but just in case figured I'd open an issue here.

Yes, I agree that it is an upstream issue. And I found https://github.com/istio/istio/issues/34479 is fixing it.

Closing since it's an upstream issue


Update pydocs to handle new API documentation format and display

New header, Example Response: that includes the actual JSON of a real response.
New optional header, Example Request:, that includes a cURL version of a real request.
All descriptions should be audited.
All returns should be audited for consistency and actual abstract definitions of the returned data.

Depends on
https://github.com/lbryio/lbry.tech/issues/42

@eukreign I believe this is on you to update gen_docs to output the documentation in a JSON-schema matching what is described here.

@NetOperatorWibby this should get you started, let me know if you have any issues with it:
https://github.com/lbryio/lbry/blob/html_gen_docs/docs/api.json

@eukreign , that html_gen_docs link doesn't work for me.

This is done: https://lbry.tech/api
I created another issue to track creating actual examples of API use: https://github.com/lbryio/lbry/issues/1334


Tests fail on windows latest

Since the merge of #1588, the integration tests fail on windows-latest
https://github.com/meilisearch/MeiliSearch/runs/3504949531

Closed by #1676


Remove unused entries from strings.xml-s

While reviewing the Hungarian translations, I found a few entries (at least 5) in strings.xml that are not referenced from anywhere. We could go through and remove those to help maintenance and future translations.

Which Strings are that? Is there any chance that we might need them again?

These are the ones that are not used:
<string name="toast_task_created">\"%1s\" created.</string>

<string name="task_detail_activity">Task Detail</string>

<string name="task_group_due_title">Due</string>
<string name="task_group_all_title">Lists</string>
<string name="task_group_completed_title">Completed</string>
<string name="task_group_start_title">Start</string>
<string name="task_group_priority_title">Priority</string>
<string name="task_group_progress_title">Progress</string>

<string name="status_incomplete">incomplete</string>

<string name="priority_urgent">urgent</string>

<string name="gd_by_due_date">By Due Date</string>
<string name="gd_by_completed">By Completed</string>
<string name="gd_by_list">By List</string>

<string name="task_list_selection_ok">OK</string>
<string name="task_list_selection_cancel">CANCEL</string>

<string name="notification_action_delay_toast">Due date updated</string>

<string name="dashclock_display_type_start_and_due">starting and due tasks</string>
<string name="dashclock_preference_title">Task DashClock Preferences</string>

(I went through strings.xml, but realized later that Android Studio can detect unused resources.
I am not sure which ones have a chance to be needed later, I could maybe look into the usage of the strings that are similar/next to them in the xml and try to assess it with some common sense, but I probably don't know the app well enough for that yet.

Ok, let's get rid of

``
``
``
``
``
``


Contributor docs edits for CCI2 and more

Critical Changes
Changes
A pass at updating Contributor docs, primarily for CCI2, but with other edits as well.

new Coding Conventions page. This is based just on observations, and is marked as a work-in-progress
much of CCI 1.x instruction preserved in new Legacy CumulusCI page
Do the Work page updated to reflect new processes, link to Contributing doc on main SFDO WP site
git branching also added to Do the Work page
Submit Your Feature updated for new PR template
'Starter' => 'Success' throughout
copyright year and org in footer updated

Issues Closed

@judisohn I was hoping this might be close enough to go ahead and publish for pre-Community Sprint reference, understanding that you want to have a more thorough look at all of this at some point.

@tet3 THANK YOU!!!! @jlantz what do you think?

@tet3 WOW, I've got to hand it to you, this was a huge effort and you did an awesome job! THANK YOU!

this is the most exciting thing.


Problem in submitting the function to grader (ibm challenge 2024)

Already i have implemented the code but when i am submitting to grade_lab1_ex6 it is giving error " you need to implement the code to get the result".
def cost_func(params, ansatz, hamiltonian, estimator,callback1_dict):
"""Return estimate of energy from estimator
Parameters:
    params (ndarray): Array of ansatz parameters
    ansatz (QuantumCircuit): Parameterized ansatz circuit
    hamiltonian (SparsePauliOp): Operator representation of Hamiltonian
    estimator (EstimatorV2): Estimator primitive instance

Returns:
    float: Energy estimate
"""
pub = (ansatz,hamiltonian,params)
result = estimator.run([pub])
energy = result.result()[0].data.evs

#return energy,result
callback1_dict["iters"] += 1
callback1_dict["prev_vector"] = params
callback1_dict["cost_history"].append(result)

Don't change any code past this line
print(energy)
return energy, result

grade_lab1_ex6(cost_func)    ## while running this, got  the below error
error :  [0.70898438]
You need to implement code to get a result.

Include the hamiltonian and the parameters in an array: [hamiltonean] , [params]


FancyZones Bug Report

Microsoft PowerToys version
0.73.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
When turning on the computer, I always have to reselect the FancyZone that I use daily. Before, the option I selected was recorded, but now every time I turn on the PC I have to select it again...
✔ Expected Behavior
option I selected remain even after shutting down and turning on the computer.
❌ Actual Behavior
option I selected does not remain even after turning the computer off and on.
Other Software
No response

/bugreport

Hi there!We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here?  Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks!

Hello!
Follow the request below
PowerToysReport_2023-09-15-20-18-41.zip

Could you please confirm if the issue is still present in version 0.74?
/needinfo

Could you please confirm if the issue is still present in version 0.74? /needinfo

It's working! It has been resolved in this version. It's working perfectly as it should. 👏👏👏👏❤


Unable to use boolean field with useControl or useInputControl

Describe the bug and the expected behavior
If I have a field in zod such as
  enabled: z.boolean().optional(),

I'd like to use this boolean with a custom component (such as the Radix Switch) using the useControl or useInputControl APIs:
  const enabledControl = unstable_useControl(fields.enabled);

However useControl and useInputControl are currently both typed to only allow string or string array values, so when calling enabledControl.change, the value expected is a string.
Would it be possible to support boolean field, so that enabledControl.change can accept true or false?
Conform version
v1.1.3
Steps to Reproduce the Bug or Issue
  enabled: z.boolean().optional(),
  ...
  const enabledControl = unstable_useControl(fields.enabled);
  ...
  // Type 'boolean' is not assignable to type 'string'
  enableControl.change(true)

What browsers are you seeing the problem on?
No response
Screenshots or Videos
No response
Additional context
No response

Found this which I think explains the issue so closing for now
https://github.com/edmundhung/conform/pull/409#issuecomment-1925932892


Rust Server Closes after load

As description states, it unexpectedly crashes is there a solution for this?

I wasn't able to duplicate the issue. Setup fresh Windows Server 2022, VCredist, Fresh Rust install no plugins.  PSversion 5.1.20348

I tested with plugins and plugins update function. I wasn't able to duplicate it. 16GB ram, 4 vCPU, windows server


Working

👷 Deploy Preview for vargas-work-portfolio processing.

Name
Link

🔨 Latest commit
f4372115116a70eba96f408f1a4dc32f3ada47d2

🔍 Latest deploy log
https://app.netlify.com/sites/vargas-work-portfolio/deploys/64e3c5f12a08b90008d3cbc3


fetchMembers doesn't return anything

fetchMembers doesn't return anything and break the code, even only an await will stop the code and never execute the rest of the code.
Example:
console.log('fetching');
await fetchMembers(guild, { userIDs: [id], limit: 1 }).catch(console.error).then(console.log);
console.log('done');

'done' will never get logged and neither anything else is not logged.

Fixed in v10.
<EMAIL_ADDRESS>


Add quickstart guide

Quickstart that covers -

installing the cluster operator
deploying a simple rabbitmq cluster using the operator
accessing management ui on the deployed cluster
viewing rabbitmq logs on the deployed cluster
links to next steps

It also

breaks down the kubernetes resources that get created as a result of both installing the operator and creating a rabbitmq cluster using the operator
promotes the examples on the cluster operator github repo

Thanks for the quick review Luke! I'll make the minor edits and push again.

Thanks for the quick review Luke! I'll make the minor edits and push again.

Hey @ChunyiLyu, thanks for reviewing :)
I looked in our current docs and we only have section 5 (connect using perf-test). Sections 3 (rabbitmq logs) and 4 (access management ui) are missing. They could both live in the Using docs: https://www.rabbitmq.com/kubernetes/operator/using-operator.html
Given that the sections (3,4,5) are so small, I am okay having them in the quickstart too, since it will keep the flow of the reader. However, we should also have them in the Using docs: https://www.rabbitmq.com/kubernetes/operator/using-operator.html
What do you think?

Hey @ChunyiLyu, thanks for reviewing :)
I looked in our current docs and we only have section 5 (connect using perf-test). Sections 3 (rabbitmq logs) and 4 (access management ui) are missing. They could both live in the Using docs: https://www.rabbitmq.com/kubernetes/operator/using-operator.html
Given that the sections (3,4,5) are so small, I am okay having them in the quickstart too, since it will keep the flow of the reader. However, we should also have them in the Using docs: https://www.rabbitmq.com/kubernetes/operator/using-operator.html
What do you think?

@ferozjilla Happy to merge the doc as it is now. If we do decide the quick start is too verbose, it's easy to move/delete the steps :)

@ferozjilla Happy to merge the doc as it is now. If we do decide the quick start is too verbose, it's easy to move/delete the steps :)


Cannot  add webmentions to Medium

When I try to connect Medium, I get the "Sorry, that user was not found." page.
The URL in the browser is:
https://brid.gy/medium/choose_blog?state=%257B%2522feature%2522%253A%2522webmention%2522%252C%2522operation%2522%253A%2522add%2522%257D&code=e78bf5b3f6b3

When I try in a private/incognito window, after login in to Medium, I get this:

The URL in the browser at that point is:
https://medium.com/m/oauth/authorize?client_id=26a50e2df83e&scope=basicProfile%2CbasicProfile%2ClistPublications&redirect_uri=https%3A%2F%2Fbrid.gy%2Fmedium%2Fchoose_blog&state=%7B%22feature%22%3A%22webmention%22%2C%22operation%22%3A%22add%22%7D&response_type=code&source=login----------------------------------------

Not sure what is going on... API change on the Medium side? Something weird with encoding? No idea... 😳
Anyway, any help with this would be  much appreciated. I'd love to start using WebMentions!

Ruh roh! Sorry for the trouble, will look.

Fixed! Thanks for reporting!

Just tested, works fine. Thanks!


Added $<BUILD_INTERFACE> to gflags include directory

As per CMake documentation the INSTALL_INTERFACE should not be populated with include directories of transitive dependencies. This makes the installation of glog non-relocatable. This change fixes this.

I signed it!

I'm against this change. This will cause linker errors if the user does not link against gflags himself. The problem should be fixed in gflags.

@sergiud I don't see how it would causes compilation errors. Let me explain what happens in my understanding:
gflags correctly exports the targets to gflags-export.cmake with the appropriate INTERFACE_INCLUDE_DIRECTORIES property set as:
INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/Include"

Then glog does the exact same thing BUT it also exports the gflags_INCLUDE_DIRS in its glog-targets.cmake as:
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include;C:/full/path/to/gflags/Include"

since glog is already resolving the gflags dependency with the find_dependency macro in glog-config.cmake CMake will correctly add both the gflags include directories and glog include directories to consuming projects since the gflags libraries are resolved as exported targets and correctly export their interface include directories.
Maybe I am missing something here but a small test on my system (Windows 10, CMake 3.5) with the suggested change correctly adds both the required libs and include dirs.
Could you explain me under what circumstances this change will break consuming projects?

You are correct. Sorry for the noise. After looking at the gflags' CMakeLists.txt, this change seems to be okay.

No problem. Thanks.

@ukai Could you please merge this PR?

Great thanks!


golang.github.io is down

What did you expect to see?
documentation, specifically : https://golang.github.io/dep/docs/migrating.html
What did you see instead?
golang.github.io took to long to connect.

I can connect to https://golang.github.io/dep/docs/migrating.html And golang.github.io
ping golang.github.io
PING golang.github.io (<IP_ADDRESS>): 56 data bytes
64 bytes from <IP_ADDRESS>: icmp_seq=0 ttl=53 time=35.868 ms
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=53 time=35.691 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=53 time=35.726 ms

I'm embarrassed that I was trigger happy to submit this.
https://downforeveryoneorjustme.com/golang.github.io says it's down, but after trying with a different network I have access.

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!


Upgrade to arbitrary 1.3

See https://github.com/gfx-rs/naga/pull/2426

Why wouldn't you just bump to arbitrary 1.3 in naga's dependency?
I also don't understand why this is a new problem for you with indexmap 2...

Why wouldn't you just bump to arbitrary 1.3 in naga's dependency?

True, I didn't consider this.

I also don't understand why this is a new problem for you with indexmap 2...

I just dug into this, the way -Zminimal-versions was used in nagas CI before was broken (I will provide a fix soon).

I guess indexmap doesn't need this PR anymore. It would probably be still good for indexmap to actually support building the minimal version it specifies (I'm happy to add a -Zminimal-versions run in the CI as well), if you don't deem it so, feel free to close this.

I'm on board with making sure that we have correctly specified our direct dependencies, but I'm not fond of checking -Zminimal-versions because of these problems with indirect dependencies. Indexmap does work fine with the API of arbitrary 1.0.0, but that full dependency chain needing syn 1.0.6 is not really our problem.

Ooh, I hadn't noticed -Z direct-minimal-versions before -- that would be more palatable.

I'm unsure though what arbitrary should do at this point though, yank all their old versions? arbitary v1.3 actually works correctly.

Nah, it doesn't need to be yanked. It's a bug, but not a showstopper, only affecting users that want -Zminimal-versions to work. Such users can update to their requirement to the fixed version 1.3.
And I understand that there's not also an indexmap version that you could update to solve this from afar, but anyone using indexmap/arbitrary should also have their own arbitrary dependency that can require newer.
Closing in favor of #272, thanks!


Allow the user to immediately execute the next step of starting or ending a match

Currently, when starting a round, each step of the process is executed with a specific delay. It should be possible to skip these delays.
For example:
If a new match is started and no further action is taken, the dashboard switches to the next scene in OBS, displays the scoreboard after a couple seconds and finally displays the casters.
If a match is started, the scene has been changed and the scoreboard has been shown, the user can now choose to execute the next step of the process (displaying casters) immediately.
When ending a match, the scoreboard is hidden and the the scene is changed. After the scoreboard has been hidden, it should be possible to force the dashboard to change scenes without any further delay.

Will be resolved in 4.1.0.


Remove non async eviction

Removes the deprecated synchronous eviction code path.
Previously, Alluxio supported both synchronous and asynchronous eviction. Synchronous eviction was more straightforward but ultimately less efficient because each client request would evict a small amount of data (enough to satisfy the current request space call). Asynchronous eviction allows the evictor to use more information and do a more efficient batch eviction.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3147/
Test PASSed.

Also, could you provide a short description as to what the benefit of removing synchronous eviction does for Alluxio in terms of performance/simplicity? You could put it in the original PR description so it is included in the commit message

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3181/
Test PASSed.

@ZacBlanco Updated, thanks.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3230/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3231/
Test PASSed.

alluxio-bot, merge this please.


panic: runtime error: integer divide by zero

When i use API /forms/pdfengines/merge to merge multiple docs, we get an error panic: runtime error: integer divide by zero.
And it about library<EMAIL_ADDRESS>About code in https://github.com/pdfcpu/pdfcpu/blob/v0.8.1/pkg/pdfcpu/read.go line 530.
When do
if len(buf)%xrefEntryLen > 0 {
		return errors.New("pdfcpu: extractXRefTableEntriesFromXRefStream: corrupt xrefstream")
	}

xrefEntryLen become 0.
And
i1 := xsd.W[0]
	i2 := xsd.W[1]
	i3 := xsd.W[2]

	xrefEntryLen := i1 + i2 + i3

when xrefEntryLen will be 0?

Out of curiosity, could you try with gotenberg/gotenberg:edge?
There might be an incompatibility issue with the PDFs version, as pdfcpu only handles PDF v1.7 and v2.0.

hi @gulien
gotenberg/gotenberg:edge? I first time hear about this.
Could you help explain what's the different between gotenberg/gotenberg:edge and gotenberg/gotenberg:8.11.0
thank you

That's the latest main branch build. I've switcher to pdfcpu CLI instead of the Go library for better resources/error management.

hi @gulien Thank you for your reply. I will have a try

to fix your trouble check this solution click
maybe this will solve your problem.

maybe this solution will solve your problem click


Update WC cumulative.csv

The missing data on weekends was assumed to have no change by Shaun, but I think it would be better to impute a linear change. I add a third of the difference between Friday and Monday, to get Saturday, and two thirds of the difference for Sunday, and I round off the values to the nearest integer. If you are happy with this, we should mention it in the readme.md file.

I wasn't trying to change data/calc/calculated_rt_sa_mcmc.csv, so you can ignore the changes to that file. In future, I won't include commits ahead of my fork. This is the first time I'm using Github, so I wasn't aware that my pull request can just be focused on my own contribution.


Make engines and languages key a warning

This scenario does not itself prevent an analysis from succeeding. Making this
a warning not an error will allow analyses to proceed but still display a
notice on the analysis settings page and during validate-config.

LGTM


Support udf range

Is your feature request related to a problem or challenge?
Currently our udf function does not have range. This is a commonly used function. I understand that I should add it.
try:
select range(10);
result:
Error: Plan("Invalid function 'range'.\nDid you mean 'nanvl'?")
And duckdb or clickhouse has supported it.
duckdb: https://duckdb.org/docs/archive/0.9.1/sql/functions/
clickhouse: https://clickhouse.com/docs/en/sql-reference/functions/array-functions
Describe the solution you'd like
Add the udf function.
Describe alternatives you've considered
No response
Additional context
No response

Added as subtask of https://github.com/apache/arrow-datafusion/issues/6980

hi @alamb  maybe I can try this issue?  : )

sure -- thanks @Veeupup  -- sorry for the delays in reviewing!


Fedora 38 compose Fedora-38-20230413.1 iot-installer-f38 issue: deployed ostree ref failed

Our CI has detected failures in iot-installer-f38 compose Fedora-38-20230413.1
TASK [assert] ******************************************************************
fatal: [<IP_ADDRESS>]: FAILED! => changed=false
  assertion: result_ref.stdout == ostree_ref
  evaluated_to: false
  msg: deployed ostree ref failed

TASK [assert] ******************************************************************
fatal: [<IP_ADDRESS>]: FAILED! => changed=false
  assertion: result_var_mount_point.stdout == "/dev/vda2[/ostree/deploy/fedora/var]"
  evaluated_to: false
  msg: /var does not mount on /dev/vda2[/ostree/deploy/fedora/var]

This is likely happening because the ostree_ref variable has changed from fedora to fedora-iot
The solution is to update ostree_ref value in ostree-ng.sh test case. I will provide a soon a PR for this issue.

A suggested workaround has been merged into main.
In case similar issues appear in f39, f40, etc. a similar workaround will be applied.


Add support for number_of_replicas

That is a nice addition. Thanks!

Thanks. When are you planning to upload a new version to nuget?

Sorry @jackstu for the late reply. There is some other PR in progress for converting the project file. I m a bit waiting to combine these two. Are you in need for this feature?

No problem @mivano. I've created workaround in my project so no big need.

Will be in 5.2, thanks.


Sparks sound can be heard throughout whole map

While malfunction happens, spark sounds can be heard throughout the whole map, inside and outside. Moreso, sometimes spark particles can be seen as well, emitting from the (i think?) player head

Fixing this right now. The AudioSource isn't spaceialized and there's some issue with the player's HUD effecting the depth buffer for the particles.


[jaeger exporter] Add env var for agent host

Is your feature request related to a problem? Please describe.
To point to an agent daemonset pod running on local node, the value has to be set in the kubernetes spec as v1:status.hostIP (this cannot be set in code, not easily at least) , it would be very convenient to simply add a JAEGER_AGENT_HOST env var that the exporter looks for without it being explicitly set in the exporter config, and if it is not set, default to localhost of course. please see `https://github.com/open-telemetry/opentelemetry-specification/issues/172#issuecomment-553683949
Describe the solution you'd like
JAEGER_AGENT_HOST or JAEGER_HOST whose value will be used as the host in the exporter config, if set.
Describe alternatives you've considered
adding process.env.JAEGER_AGENT_HOST in all projects that use open telemetry with jaeger exporter.
Additional context

status.hostIP - the node’s IP, available since v1.7.0-alpha.1

https://kubernetes.io/docs/tasks/inject-data-application/downward-api-volume-expose-pod-information/#capabilities-of-the-downward-api

Should we wait for specs issues to get approved/merged?

This is really an SDK mechanism, but at the same time I think this should be decided on for all SIGs, not just ours. I'm not sure where questions that are not spec related but affect all SIGs should go. Probably still in spec.

@mayurkale22 maybe we should consider some sort of waiting-on-specs label for issues like this?

Or we could close it and re-open when the spec is ready.

@mayurkale22 maybe we should consider some sort of waiting-on-specs label for issues like this?

I like this idea, created a label "waiting-for-spec".

This can be closed.


After executing a schema compare

Azure Data Studio Version: 1.26.1
Steps to Reproduce:

Open a database project
Open the schema compare
Select as source the database project and as target the Azure Synapse Provisioned Pool as target
Run "compare"

Results:

Connection to the database works. I was able to create a new project from this database.

looks like same issue as #14107


[GOBBLIN-1513] fixed the construction of regex filters

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1513

Description

[x] Here are some details about my PR, including screenshots (if applicable):
Path filters are supposed to be provided by key "gobblin.dataset.path.filter.class", but instantiatePathFilter only calls the empty constructors for the path filter classes. Right now only HiddenFilter can be created with empty constructor.
This PR will make a constructor for RegexPathFilter so that it can be used with config "gobblin.dataset.path.filter.class"

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
added a unit test to test initialization and basic working of RegexPathFilter

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3361 (3a466bf) into master (de94515) will decrease coverage by 3.40%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #3361      +/-   ##
============================================
- Coverage     46.43%   43.03%   -3.41%
+ Complexity    10120     1940    -8180
============================================
  Files          2052      394    -1658
  Lines         79656    16888   -62768
  Branches       8896     2080    -6816
============================================
- Hits          36991     7267   -29724
+ Misses        39226     8819   -30407
+ Partials       3439      802    -2637

Impacted Files
Coverage Δ

...g/apache/gobblin/util/filters/RegexPathFilter.java
72.72% <0.00%> (-16.17%)
:arrow_down:

...a/org/apache/gobblin/util/limiter/NoopLimiter.java
40.00% <0.00%> (-20.00%)
:arrow_down:

...lin/util/filesystem/FileSystemInstrumentation.java
92.85% <0.00%> (-7.15%)
:arrow_down:

...blin/runtime/mapreduce/GobblinOutputCommitter.java

.../listeners/JobExecutionEventSubmitterListener.java

...ment/conversion/hive/validation/ValidationJob.java

...tractor/extract/kafka/KafkaStreamingExtractor.java

...n/version/finder/DateTimeDatasetVersionFinder.java

...a/org/apache/gobblin/runtime/util/TaskMetrics.java

.../src/main/java/org/apache/gobblin/fork/Forker.java

... and 1651 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de94515...3a466bf. Read the comment docs.


Unclear usage

Readme is out of date, creating a client as specified did not work, instead I had to:
var Client = require('node-kubernetes-client');

var client = new Client({
    host:  'Master_IP:HTTP_API_port',
    protocol: 'https',
    version: 'v1beta3',
    token: 'Token_Here',
    namespace: 'default',
    timeout: 20000
});

Furthermore, is there any support for updating a replication controller (with a put ) or any support for performing a rolling-update?

Encountered same issue and thanks to @marcospedreiro suggestions I've solved.
Please review this PR: #22

I had a deeper look into this and I can confirm the client instantiate correctly using the current README example. In particular:

namespace is not required in order to have a working client
If the namespace is omitted some calls to the API will not work (eg: create a pod) and it is not possibile to pass the namespace on the client.pod.create(pod, callback) method.
If the namespace is present you will be able to act only on stuff under that specific namespace using the client instance

timeout  is not required in order to have a working client
see example below

token is not required in order to have a working client
If you don't have authentication on your k8s endpoint, token can be whatever you like but client can be created also omitting it in the object instantiation.

So the correct usage could be to instantiate a generic client with only required fields: host, protocol, version and token (if authentication is required), then clone that instance and add additional attributes (like namespace) before doing a query that require them, for example the one which create a pod.
Another possible approach could be to have a generic client which manages the conenction to the API and pass an object containing the required parameters for every API method, something like:  client.create.pod(pod, param, callback).
For those which want to try, I've did few test using the below snippet:
var Client = require('node-kubernetes-client');

var client = new Client({
    host: 'K8S_HOST:K8S_PORT',
    protocol: 'http',
    version: 'v1',
    // namespace: 'default',
    // timeout: 20000
    token: 'XYZ'
});

var app = {
    basename: "nginx",
    baseimage: "nginx"
}

var my_pod = {
    // Customize pod name
    metadata: {
        name: app.basename + "-" + Date.now()
    },
    spec: {
        //Customize pod containers
        containers: [{
            name: app.basename,
            image: app.baseimage
        }]
    }
}

// Get events without having namespace set
client.events.get(function(err, events) {
    console.log(events[0].items);
});

// Get endpoints without having namespace set (return all endpoints)
client.events.get(function(err, endpoints) {
    console.log(endpoints[0].items);
});

// Get pods without having namespace set (return all pods)
client.pods.get(function(err, pods) {
    console.log(pods);
});

// Cannot be executed without namespace set
client.pods.create(my_pod, function(err, pod) {
    if (!err) {
        console.log("POD CREATED:");
        console.log(pod);
    }
    else {
        console.log("POD NOT CREATED:");
        console.log(err);
    }
});

closing as this change appears to no longer be needed.


Add LaunchTemplate SSH KeyName to AWSNodeTemplate

Tell us about your request
In migrating a load from a Terraform EKS self_managed_node_group to Karpenter, I cannot find how to set the EC2 key_name to use for the Instance.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Looks like we just need a way to take KeyName at the AWSNodeTemplate and pass through to the Karpenter-built LaunchTemplate.  I can create my own LaunchTemplate to set the KeyName, but that seems like overkill and a maintenance headache when the rest of the Karpenter-built LaunchTemplate is so close to what I need.  I know that SSH'ing into a Node is an anti-pattern, but sometimes we need to do this to debug in our dev environment ;-)
Are you currently working around this issue?
Still looking through my options.  My go is weak, but I might try to add myself and make a PR.  However, don't want to duplicate effort if someone else is already on this.  Or if this is deliberately missing.  I didn't see any Issues are PRs that covered this, though.
Additional context
Attachments

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

it's strongly recommend you use aws ssm manager instead of SSH
https://docs.aws.amazon.com/systems-manager/latest/userguide/ssm-agent.html

As @FernandoMiguel we recommend using SSM rather than static SSH keys. SSM will allow you to login to the instance in an SSH-like session. The other option which uses dynamic SSH keys is ec2-instance-connect, which is another option if you need real SSH session, but there's no need to provide any keys up-front and works great with karpenter.

I'll look into ec2-instance-connect - that is a new one on me.

Ah, ec2-instance-connect has another similar problem as SSM.  Not everyone that has an occasional need to access at the OS level nodes in our VPC that is connected gets to have AWS accounts.  There is a need for authentication outside of the IAM/AWS SSO world.  I'm glad for you that you do not have it, but some of us do.

The information about adding SSH credentials via userData (see above) was added to the docs in PR #2500. So I'm going to close this issue.

Glad it isn't just me.  After the reception above, I abandoned the idea of working on a PR.  I sure sounded like a simple bit of code that my early Golang coding could handle as an exercise.  However, I didn't want to put in the time if there was a good chance of flat-out rejection of the effort (I still consider it a bug, but I've got other windmills to tilt).

Granted, it is a best-practice to use the SSM Agent instead, and that you can ALSO use SSM-Agent + SSH + an SSM Agent Policy Document to access EC2 instances that don't have public IPs...but to preclude the ability of any team to choose for themselves whether they want SSH on their Nodes or not is a bit of a reach.

I don't even agree, given the details, that SSM Agent is best-practice. If you are using Ubuntu the SSM Agent is a snap, and I don't want snaps. Yes, this is more of a Ubuntu-ism, but it is also reality.

looks like no progress on this issue yet, any updated on it?

As far as I can tell the only way to copy data directly to/from an ec2 instance requires an ssh key, even when using session manager or ec2 instance connect.
The user data approach in https://karpenter.sh/docs/faq/#can-i-add-ssh-keys-to-a-nodepool is a bit sub-optimal because you lose the ability to leverage the KeyName from the EC2 API.
Given that, I'm glad to see @ellistarn's note that PRs will be accepted for this.


set default date to today()-1

closes #1056
Prerequisites:

[x] Unless it is a hotfix it should be merged against the dev branch
[x] Branch is up-to-date with the branch to be merged with, i.e. dev
[x] Build is successful
[x] Code is cleaned up and formatted

Summary
change the default date to today - 1

This is still draft so you may already know this but something in the logic is not quite right; it's saying there isn't data for october 4 when there clearly is:

Yep, meta data only gets updated nightly, and we won't be able to switch to realtime metadata updates until we fix a problem causing random meta update runs to take 4 hours.
The true max_time_value can be up to 24 hours off for signals that update daily, and up to 7 days off for signals that update weekly (currently just bar & restaurant visits, but some of the upcoming flu signals will only get weekly updates as well).
What are our options? I see these:

leave the banner as-is, and just eat the fact that it is sometimes comically wrong
drop the banner
to compute whether to show the banner, look in metadata first. if it says data is available, believe it. if it says data is not available yet, check the actual signal response.

any others?

@sgratzl I'm trying to revisit this to help shepherd v3 along to being finished.  Can you explain to me what the purpose of the banner is---is it only to display a warning if the data isn't available (what's being shown in orange in the above screenshots)?
Anyway regardless, unless the banner is for a purpose that I really don't understand, it seems like Katie's suggest solution in bullet point 3 is fine.

the goal of this banner was to give users an information why they see only N/A for the whole page, e.g. in a normal case it could look like:

to compute whether to show the banner, look in metadata first. if it says data is available, believe it. if it says data is not available yet, check the actual signal response.

done

Ok looks good thanks.

It looks good to me, I just want to double-check that the feature I suggested "for each indicator in the table, report the value and relative change for the most recent date available in the table instead of NA, if they're not available at the current time" is being implemented on some other PR.

yes that will come later, this PR is a prerequisite for that one.
please approve the PR via GitHub, otherwise I cannot merge it


TypeError: word.replace is not a function

Found this error message that no one else has raised an issue about:
TypeError: word.replace is not a function
  at list.filter (.../node_modules/bad-words/lib/badwords.js:33:47)',
  at Array.filter (<anonymous>)',
  at Filter.isProfane (.../node_modules/bad-words/lib/badwords.js:32:8)'

Ended up being because I was using an old sytax that I think used to be working, but isn't any more:
filter.addWords(['some', 'bad', 'word']);

I needed to change it to this to work.
filter.addWords('some', 'bad', 'word');
// one could also use the spread operator
filter.addWords(...['some', 'bad', 'word']);

Just thought I'd docuement it for anyone else upgrading the npm module and hitting this error. Going to leave this issue open in case the maintainers want to provide an error when you provide an array instead of string args.

Thanks Corey. Right, this was part of the breaking changes that led to a major version upgrade. Noted here: https://github.com/web-mech/badwords/commit/656b87c47033a795dd394d18ee875aa91b1f7a1c
I do think we can add a type error for that.


fix the real time factor + improve scheduler + improve status bar

We were computing the real-time factor using the wall time instead of the iteration time. This means that if we were real-time but had one iteration slower than realtime, we could never catch up and reach a real-time factor of 1. Basically, to reach a real-time factor of 1, we needed many iterations faster than real time if we had been late in the past.
I switched to a real-time factor that corresponds to the iteration time, which corresponds better to what we want to know (I think).
By the way, if you log the iteration time, you will see that in graphics we often have iterations that last 14 ms (400 ms at the start), which do not come from the 'sync' mechanism (apparently). There is no problem in _plain.

@jbmouret is this ok to merge?

Yes. I will do a different PR for the next changes.


fix: avoid potential race-condition in fuel connectors init

Closes https://github.com/FuelLabs/fuels-ts/issues/2892

Release notes
In this release, we:

Fixed a potential race condition where the fuel connector may disconnect upon re-render
Introduced an init method for synchronous instantiation of a fuel-connectors object

Summary

Ensure the promise when setting up the default connector is always awaited
Builds on @svvald 's work in https://github.com/FuelLabs/fuels-ts/pull/2943

Checklist

[x] All changes are covered by tests (or not applicable)
[x] All changes are documented (or not applicable)
[x] I reviewed the entire PR myself (preferably, on GH UI)
[x] I described all Breaking Changes (or there's none)

@LuizAsFight @helciofranco do the changes made here represent any breaking change into the useFuel React hook?


Platform independent packages (i.e. Flatpak or Snap)

Thank you so much for fcp.
It would be great to have it available via platform independent packages (i.e. Flatpak and/or Snap)

I'd prefer not to do this for a couple reasons. First, as far as I understand, both Flatpak and Snap need to be mounted each time they are run, which adds a certain amount of overhead. This clashes with fcp's goal of being as fast as possible. Secondly, I know that a few other Rust cli tools (such as ripgrep) have had issues with strange bugs manifesting only in snaps.
Rust statically links everything, so a standard binary should work just fine across distributions. Is there a particular combination of architecture and/or libc that you're interested in that doesn't currently have a corresponding build under this repo's releases? If so I'd be happy to add a build for that platform for you.


Create mocking tests for mirror nodes

Problem
Currently we do have integration tests which print out when they're retrying mirror connections, but it'd be much more useful to have mocking tests. When #963 gets merged this should be do-able with little issues. This would also be very useful to confirm we're trying on #622
Solution
Add support for mirror connections to our Mocker
Alternatives
No response

Implemented here: https://github.com/hashgraph/hedera-sdk-js/commit/b9c60cfc47d707ab03bbdc62c46014d63a853002


Error running with Java 11

I just encountered an error while trying to release a new version of our Pulumi plugin for Spinnaker.
ERROR: JAVA_HOME is set to an invalid directory: /opt/hostedtoolcache/jdk/11.0.10/x64

Please set the JAVA_HOME variable in your environment to match the
location of your Java installation.

This was the env map with which it ran:
  with:
    metadata: build/distributions/plugin-info.json
    binary_url: https://github.com/pulumi/spinnaker-preconfigured-job-plugin/releases/download/v0.1.0/spinnaker-preconfigured-job-plugin-v0.1.0.zip
    metadata_repo_url: https://github.com/pulumi/spinnaker-plugins-repository
  env:
    PLUGINS_REPOSITORY: spinnaker-plugins-repository
    JAVA_HOME_11.0.10_x64: /opt/hostedtoolcache/jdk/11.0.10/x64
    JAVA_HOME: /opt/hostedtoolcache/jdk/11.0.10/x64
    JAVA_HOME_11_0_10_X64: /opt/hostedtoolcache/jdk/11.0.10/x64
    GITHUB_OAUTH: ***

Any idea as to how to fix this? I am also not sure if this is a bug in the action.

cc @danielpeach

cc @danielpeach


Handles for calling perf_db compile & eval through fin

These are changes necessary for allowing Fin to execute perf_db compile and perf_db evaluate.
GetAllSolutions function in any_solver / generic_search to facilitate return of array of all possible solutions to fin.
Changes around generic_search and solvers to allow for generic_search constructs to be used from call originating outside the file.
GetPerfCfgParams function in any_solver to return the parameter string for supplied context.
Added LegacySolver test in any_solver.
Added db_update to execution context to allow for programmatic selection of update execution.

Working to fix clang-format errors.

This should also be consistent with the upcoming refactoring designed by @DrizztDoUrden and @averinevg. I highly recommend assigning them as reviewers (I can't do that now).

[Note] This PR does not contain fin changes, so I can't understand the goal of this PR. If you explain the purpose, then I hope I can suggest a more appropriate design.

Fin changes are in the following PR, I apologize if it isn't accessible at the moment.
https://github.com/ROCmSoftwarePlatform/fin/pull/42
When I get it merged to Fin develop I'll bundle it in either this PR or a following PR.

@cderb Please set urgency label, if possible. Thanks!

De-serialize test is failing for solvers: ConvOclDirectFwd and ConvOclDirectFwd1x1 across all libraries it seems. I don't think the serialization / solver code was changed by this PR. @junliume was this introduced by one of the tuning PRs? There are some older perf libraries in here that weren't changed recently as well.

De-serialize test is failing for solvers: ConvOclDirectFwd and ConvOclDirectFwd1x1 across all libraries it seems. I don't think the serialization / solver code was changed by this PR. @junliume was this introduced by one of the tuning PRs? There are some older perf libraries in here that weren't changed recently as well.

I don't think codes related to those two solvers have changed for a while. Maybe the tuning issue? CC: @JehandadKhan

@JehandadKhan  @cderb  yep Perf DB Deserialize Test is failing pretty consistently which is the issue.

@cderb Can you please check what is going on with the failing test ?

If this is not urgent, then I recommend either postponing this until refactoring is complete or re-implementing this with callbacks. Why:

After ongoing refactoring done, the code changes from this PR won't work. In fact, @averinevg or @DrizztDoUrden will have to rewrite almost all of the code from this PR.
Callback-based implementation involves smaller number of changes. And it does not have the drawback mentioned here.

@atamazov in short, we can still accomplish tuning without the change. This change is an enhancement to increase Tuna's productivity.
I'll attach the Fin extension of this PR once it has merged to develop on that side. And we can pause this branch here until the refactor is completed
In the mean time I can attempt the suggested callback implementation.

I've added the Fin changes to this PR to give context.

@DrizztDoUrden  Lets discuss this in our upcoming meeting

@DrizztDoUrden Lets discuss this in our upcoming meeting

@JehandadKhan and @DrizztDoUrden any follow ups? :)

Merge resolution in new PR.


Chapter 0 edits

I think you might want to provide example texts on architecture and operating systems. "Data-center" is written "data center". Your use of "well-known" is a postpositive and thus ought be written "well known". I converted a few comma splices to semicolons. Fixed a few number problems.
It would be great if I could break these long lines into shorter ones -- the edits will definitely be
easier to manage for you, I think.

@dendibakh , take a look at these edits and let me know if they're too invasive or otherwise undesirable. This is the level at which I currently intend to edit.

@dendibakh , take a look at these edits and let me know if they're too invasive or otherwise undesirable. This is the level at which I currently intend to edit.

So far everything looks good. The level of edits seems reasonable to me.


Fixed DevTools rendering error when devToolsExtension is active

According to redux-devtools-extension you should not render DevTools when using devToolsExtension object.
Rendering it will cause an error:

Warning: Failed propType: Required prop monitorState.position was not specified in DockMonitor. Check the render method of Connect(DockMonitor).

Thx.
I rewrote it like this:
{!window.devToolsExtension && <DevTools store={store}/>}

I released the new version, try it.

Okay, thanks!


Gathering feedback from Diagnostics

Diagnostics in VScode
At the moment for the Diagnostics, its hard to measure usefulness. Its possible to proxy the usefulness by seeing diagnostics with quick fixes have fixes applied (being a strong Useful signal), but this leaves out the Diagnostics that don't have any quick fixes (can be at best proxied via tracking the diagnostic disappearing after hover, which is not a direct signal of being useful), and not having quick fix applied is not a 100% signal of not usefullness either (as that may still mean that there is some issue with the fix, e.g. it not being correct, or not covering all cases).
That being said, I propose that a feedback interaction would be added to a Diagnostic Hover, allowing the users to provide an explicit signal about usefulness/nonUsefulness.
For example see the image below.

I am happy to contribute this feature.
UX details to consider
Since there can be multiple diagnostics on the same line, and on hover they would be displayed in the same hover card, the most reasonable space to contain this feedback would be in in the body of the Hover card, on the row of the diagnostic.
The placement in the row should be at the bottom, with a message such as "Was this useful/helpful" . The bottom of the row makes sense as placing it at the top feels a bit intrusive and places the features interest instead of the user.
Although placing at the top would makes sense, since through our studies we see that users are more likely to provide negative info than positive, and obviously wrong diagnostics which are longer would require scrolling to allow to provide this info, we plan to gather more data to see if this placement would be even neccessary.
After a feedback is submitted for a diagnostic, the state is stored in workspace cache by ID created from Diagnostic data so that clones, and subsequent hovers on the same diagnostic show that the user already provided some sort of feedback.
The ID can be generated by hashing filePath/message/code under diagnostic/owner  to ensure that movement of diagnostic through file won't change the ID.
NotUseful triggers should remove the Label "Was this helpful", and in place create additional actions, such as "file a bug" to be able to trigger this actions, in the source of feedback creation. (On pressing the file a bug, vscode feedback should be opened)
Also the separator used for the hoverRows is barely visible in some themes, if there are multiple diagnostics. The contrast could be increased to make it visible where the feedback action is attached
Optional next steps
Filled Icons could be used for the buttons, once clicked, to signal the state.
The diagnostics that were marked as NotUseful can be automatically filtered from the editor to declutter the screen.
Additionally, since the NotUseful feedback might become intertwined with diagnostics that are not useful because there are too many of them displayed at one time, an action could be provided on an interaction allowing to disable the provider-source. This would should then set a setting in the User settings (e.g. "Diagnostics -> Lint -> Disable") to true, allowing the user to revert.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Specify port on docker

Hi,
Please give example of docker configuration like:
base image, which ports must be mapped  and etc.

Easymail can work on clean ubuntu:14.04 image as well as phusion/baseimage.
The ports must be opened are 110, 25, 995, 80, 443, 587, 993, 143
Also based on your suggestion README.md file was updated.
You can check it at 3d4472a03091d21cdbe5f351c219d780db06d1f4
Thanks.

This example does not include data persistence and backup, data will be lost on docker container restart.

Hi @kopax
Yes, script doesn't include backup, but after container restart data will not be lost if you use the example code (there is no -d parameter).


ENH interpolaton and wcs stuff

This PR adds interpolation routines and some WCS utils.

This looks good to me


replacing invalid tag names by valid ones

This PR fixes https://github.com/rrweb-io/rrweb/issues/150

@Yuyz0112 this is the PR we just spoke about.


Version 2.5.3 make corrupted xlsx

Just open and then save the file, I got a broken xlsx (open by Office 365 Microsoft Excel, while WPS or LibbreOffice is ok);
The order between extLst and fileRecoveryPr maybe not correct;
https://github.com/nissl-lab/npoi/blob/05c6998b1b9b51356806d35d6e5865ca0b7dc347/OpenXmlFormats/Spreadsheet/Workbook/CT_Workbook.cs#L151-L159
I change the order and the problem is gone;
Here's the source file:
test.xlsx
and then the output file:
test_output.xlsx

duplicate with #402

This issue has been fixed and it will release with NPOI 2.5.5

This issue has been fixed and it will release with NPOI 2.5.5

Ok, thx.


MINOR: Maven upgrade to 3.6.3

3.6.3 is faster than 3.6.1.

Line #57  needs to be updated

Fixed, thanks @Ethanlm


VsTest is unable to load MKL Native Provider in UnitTest

Environment:
Unit Test project with target Framework .NET Framework 4.8 build in x64
with packages

MathNet.Numerics v5.0.0
MathNet.Numerics.Providers.MKL v5.0.0
MathNet.Numerics.MKL.Win-x64 v3.0.0

We have a Buildserver with Azure DevOps which runs the tests with VSTest@2

- task: VSTest@2
displayName: 'Run Tests'
inputs:
platform: '$(buildPlatform)' # x64
configuration: '$(buildConfiguration)' # Release
searchFolder: '$(Pipeline.Workspace)'
testSelector: 'testAssemblies'
testAssemblyVer2: |
**\MyProject.Tests\bin**\MyProject.Tests.dll

The Problem:
In a UnitTest we have the line Control.UseNativeMKL();.
Unfortunately since the update of MathNet this throws following exception on the buildserver, whereas it works fine locally in VisualStudio.

System.NotSupportedException : MKL Native Provider not found.
----> System.DllNotFoundException : Unable to load DLL 'libMathNetNumericsMKL': The specified module could not be found. (Exception from HRESULT: 0x8007007E)
StackTrace:    at MathNet.Numerics.Providers.MKL.MklProvider.Load(String hintPath, MklConsistency consistency, MklPrecision precision, MklAccuracy accuracy)
at MathNet.Numerics.Providers.MKL.LinearAlgebra.MklLinearAlgebraProvider.InitializeVerify()
at xx.Tests.xx.xxTests.TestSetup() in C:\agents_work\6\s\xx.Tests\xx\xx.cs:line 27
--DllNotFoundException
at MathNet.Numerics.Providers.MKL.SafeNativeMethods.query_capability(Int32 capability)
at MathNet.Numerics.Providers.MKL.MklProvider.Load(String hintPath, MklConsistency consistency, MklPrecision precision, MklAccuracy accuracy)

Investigation:
I have done some checks in the UnitTest.

Control.TryUseNativeMKL() returns false
Control.TryUseNative() returns false
Environment.CurrentDirectory returns my bin directory of the test project
In the bin directory of my test project the file 'runtimes\win-x64\native\libMathNetNumericsMKL.dll' exists
specify Control.NativeProviderPath = Path.Combine(Environment.CurrentDirectory, @"runtimes"); doesn't change the behavior
specify Control.NativeProviderPath = Path.Combine(Environment.CurrentDirectory, @"runtimes\win-x64\native\libMathNetNumericsMKL.dll"); doesn't change the behavior

When downgrading to MathNet.Numerics .v4.15.0 and MathNet.Numerics.MKL.Win-x64 v2.5.0 it works fine.
I would be very happy for any help or ideas.
Thanks!

While trying to figure out the problem, the command MathNet.Numerics.Control.Describe() was quite helpful.
Which returns this
Version 5.0.0 Built for .NET Framework 4.8 Linear Algebra Provider: **Managed** Fourier Transform Provider: **Managed** Sparse Solver Provider: **Managed** Max Degree of Parallelism: 6 Parallelize Elements: 300 Parallelize Order: 64 Check Distribution Parameters: True Thread-Safe RNGs: True Operating System: Microsoft Windows 10.0.19045  Operating System Architecture: X64 Framework: .NET Framework 4.8.9139.0 Process Architecture: X64 Processor Architecture: AMD64 Processor Identifier: Intel64 Family 6 Model 158 Stepping 10, GenuineIntel
I restarted the Buildserver machine by coincidence and it seems to have solved the problem.
So now I get this result and everything works again as expected.
Math.NET Numerics Configuration: Version 5.0.0 Built for .NET Framework 4.8 Linear Algebra Provider: Intel MKL (x64; revision 15; MKL 2022.0) Fourier Transform Provider: Intel MKL (x64; revision 15; MKL 2022.0) Sparse Solver Provider: Intel MKL (x64; revision 15; MKL 2022.0) Max Degree of Parallelism: 6 Parallelize Elements: 300 Parallelize Order: 64 Check Distribution Parameters: True Thread-Safe RNGs: True Operating System: Microsoft Windows 10.0.19045  Operating System Architecture: X64 Framework: .NET Framework 4.8.9139.0 Process Architecture: X64 Processor Architecture: AMD64 Processor Identifier: Intel64 Family 6 Model 158 Stepping 10, GenuineIntel


Update AlternisKerbolRekerjiggered ksp_version compatibility and install

Out of sheer curiosity, what is the difference between the find and find_regexp command in this context which makes the latter better?
Also, damn, that's the biggest conflict stanza I've ever seen :o

find has to match the folder name exactly while find_regexp matches the regular expression. In this case the regular expression is AlternisKerbol which will match any folder name that contains that string. The folder name used to be AlternisKerbol and is now AlternisKerbolRekerjiggered so find: AlternisKerbolRekerjiggered would match just as well, but with the regexp we'll be covered in the case that the folder is renamed AlternisKerbol in later versions.

Thanks for the explanation :+1:
Also the install looks fine so I'm merging this with my thanks :)


WIP: Add codemod to migrate to API established in v0.14

Initial step completed here is to translate a simple rendering test (from migration guide).
Initial implementation came from ember-qunit codemod.  Almost all of the remaining work has corollaries there from which we'll be pulling.
TODO:

[x] process Life Cycle Hooks (i.e. 'beforeEach', 'afterEach')
[x] process this.register
[x] process this.on
[x] ~process this.$~
[x] process this.inject
[ ] ~process this.lookup~ ??
[x] process this.subject
[x] Acceptance Test -> Application Test
[ ] Model Tests ??

looking good so far! let me know when you want another round of review :)

Tried this out on a Heroku codebase and it’s working great for component tests.

@rondale-sc I agree that we should merge this in the current state so that people can try it out and report feedback. Could you change the README to mention the new codemod?

@Turbo87 This should be good to go pending README reviews.  The application tests still need a bit of work, but I was able to successfully run it a few times on my codebase.

Merging for now. We can address any issues once it's merged. Thanks a lot @rondale-sc!

Amazing work @rondale-sc!


Could this still be used for generating synthetic data for DOPE?

Hi can I still use this one to generate my synthetic data for my own model and load it in DOPE?

Yes just follow the instructions on the dope repo. Sorry phone answer.
On Tue, Jun 4, 2024 at 19:17 Ken @.***> wrote:

Hi can I still use this one to generate my synthetic data for my own model
and load it in DOPE?
—
Reply to this email directly, view it on GitHub
https://github.com/owl-project/NVISII/issues/175, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABK6JICDHXLXJWVN3N7AULLZFZYNBAVCNFSM6AAAAABIZYWFQGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZTINZWGE4TIMA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

thank you for the reply!

I am sorry, i just noticed that Jeff removed the script, https://github.com/NVlabs/Deep_Object_Pose/tree/128631a23c827d2091cfd103c03c8c3a93fc6134/scripts/nvisii_data_gen you can find it here, i will add a link to the repo.

Ok it is still there: https://github.com/NVlabs/Deep_Object_Pose/tree/master/data_generation/nvisii_data_gen

Ok it is still there: https://github.com/NVlabs/Deep_Object_Pose/tree/master/data_generation/nvisii_data_gen

thank you for the help!


difficult: Clean up event handling for bots.

By the time you are looking at this, #17725 will probably have hit master, but if not, then you will want to look at that PR, because my comments here assume the code was merged.
Right now we have some really ugly code in our handling of bot events that essentially waits 50ms before we re-render somebody's personal bots in "Settings/Your bots".  Look for eventually_render_bots in the code.
This code allows the "success" function to complete before we call render_bots, assuming, of course, that 50ms is a large enough window.
If the event got processed before the success functions, things just get strange.  You can reproduce this by wrapping a timeout call around the success function for the channel.post call inside the submitHandler for $("#create_bot_form").validate.
This is a difficult fix, and if you need guidance to even just get started, then you probably want to pick a better issue to work on.  But once you've done the original diagnosis, the first step is to propose a cleaner way to handle this.
It's possible that we may someday do a pretty complete rewrite of the settings_bots.js code, and we would make the UI for bots just look more like the admin screens for bots.  If that's the case, then it might not be worth investing too much time in this, and we would just do the rewrite.

@zulipbot claim


Bind /var/lib/turbinia to host

This is an attempt to fix https://github.com/google/turbinia/issues/645 .

@hacktobeer : This seems to successfully mount/bind the directory to the host (so that we don't fill up the containers with output), but the process still can't write to the container and gets errors.  The directory is chown'd to the correct user within the container, but the directory is owned by root in the host filesystem.  I'm not sure how users are supposed to be mapped between the two systems.  Any ideas how to resolve this?
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/turbinia-20190819-py3.6.egg/turbinia/client.py", line 234, in check_directory
    os.chmod(directory, mode | stat.S_IWUSR)
PermissionError: [Errno 1] Operation not permitted: '/var/lib/turbinia'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/turbiniactl", line 33, in <module>
    sys.exit(load_entry_point('turbinia==20190819', 'console_scripts', 'turbiniactl')())
  File "/usr/local/lib/python3.6/dist-packages/turbinia-20190819-py3.6.egg/turbinia/turbiniactl.py", line 634, in main
    jobs_denylist=args.jobs_denylist, jobs_allowlist=args.jobs_allowlist)
  File "/usr/local/lib/python3.6/dist-packages/turbinia-20190819-py3.6.egg/turbinia/client.py", line 1240, in __init__
    check_directory(config.OUTPUT_DIR)
  File "/usr/local/lib/python3.6/dist-packages/turbinia-20190819-py3.6.egg/turbinia/client.py", line 237, in check_directory
    'Can not add write permissions to {0:s}'.format(directory))
turbinia.TurbiniaException: Can not add write permissions to /var/lib/turbinia

You are mounting the container host folder /var/lib/turbinia to the container folder /var/lib/turbinia. I suspect the host filesystem has permissions set that the turbinia user in the container is unable to write to. Two options here, we try to debug how users are mapped and rely on that or we mount a separate data disk to the container host and map that into the container so we don't touch the actual container host filesystem. This will give us a clear seperation between the turbinia worker/server data and the container (host) is data.

I'll try to take a look at how the user mappings are done.  Yeah, a separate data disk might be a good idea though.

Dropping this PR since I think adding the volume is the right approach here (https://github.com/forseti-security/osdfir-infrastructure/pull/17/ for that).


Erase "config.json" at beginning of deck calibration

Description:
This PR for avoiding collisions caused by using any previously calibrated tip_length, instrument_offset, and gantry_calibration.
We erase the deck-calibration data file at the beginning of deck calibration procedure, using a method robot_config.clear() which erases the environments config.json file. We then call opentrons.reset() to re-initialize robot with an default config setting.
Check List:

[ ] Are there breaking changes in the API and how are they being communicated?
[ ] Who is reviewing your code?

Tested on machine B2B-08, calibrated the deck, then ran user calibration flow.


Fixed jpg Issue

MimeTypeMap.GetExtension("image/jpg") - throws an error when it shouldn't

image/jpeg is the correct mime type. See https://datatracker.ietf.org/doc/html/rfc2158#section-3.1
That said,while we only support one mime type per extension, we do support multiple mime types pointing to the same extension. So while MimeTypeMap.GetMimeType("jpg") will always return image/jpeg, we can support both MimeTypeMap.GetExtension("image/jpeg") and MimeTypeMap.GetExtension("image/jpg") both returning .jpg.
To do this, instead of adding a mapping for jpg to image/jpg you need to add the reverse mapping (see end of list). I believe when using a manual reverse mapping all of the mappings must be specified, so to get what you want you'll need to add
{"image/jpg", ".jpg"},
{"image/jpeg", ".jpg"},

Then you can lookup the extension by either mime type and it'll maintain backwards compatibility.

If I may, I think the changes submitted by @RyanGaudion still need to be merged in as I'm also getting an exception when trying to get file extension for mime type "image/jpg"


Updating when "zones_changed" is received comes with lots of issues

It can’t display seek time properly when song’s in loop or when you change seek time manually. (Stuck at 0 or displays wrong time)
It only displays playing song when you change the now playing song after you launch this program.

All of this happens because it only updated when "zones_changed" data is received.  It should also respond to "zones_seek_changed" and initialize it with data from first "Subscribed" command to fix those issues.

Thank you for the report, I have created a new branch issue7 to try and fix the issue.
The first update has been pushed. Please take a look at it to see if it works for you. If there are any other bugs or issues, please do let me know.

Thank you for the report, I have created a new branch issue7 to try and fix the issue.
The first update has been pushed. Please take a look at it to see if it works for you. If there are any other bugs or issues, please do let me know.

First issue seems to be fixed correctly. However the second issue still remains. Thank you for swift response and fix attempts!

First issue seems to be fixed correctly. However the second issue still remains. Thank you for swift response and fix attempts!

No problem! As for the second point, could you explain in more detail what you meant? I apologize I could not understand what you're trying to say.

First issue seems to be fixed correctly. However the second issue still remains. Thank you for swift response and fix attempts!

No problem! As for the second point, could you explain in more detail what you meant? I apologize I could not understand what you're trying to say.

So, when I'm already listening to some song using Roon and launch this program, it will not get data from Roon (and thus no status on Discord) until song change occurs then it gets "zones_changed" update and finally working.
Also, sorry for bad explanation, I'm not native English speaker :(

Thanks for the explanation! The issue should be fixed in the latest commit on branch issue7.
If there are any other issues or bugs, please do let me know. If not, I will merge with the main branch if everything works fine for you!

Tested, and it seems to work well! Closing since it's fixed.


This commit adds a chapter about clang-tidy integrations.

'Using clang-tidy' was split into 2 chapters:

'Standalone tool' (the previous content of 'Using clang-tidy')
'Clang-tidy integrated' (a new chapter)

Text reviewed by Anton Korobeynikov

Thanks for this patch.
However, don't use github for contribution
please use
https://reviews.llvm.org/

Thanks for this patch.
However, don't use github for contribution
please use
https://reviews.llvm.org/

Thank you


Refactor

[x] I have read the Contributing Guide
[x] I have signed the CLA
[x] Lint and unit tests pass locally with my changes
[ ] I have labeled the PR correctly with the related package
[ ] I have run Loki's visual regression tests (if applicable)
[ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
[ ] I have added necessary documentation (if applicable)
[ ] Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

Issue(s)

Further comments

Please fix CI, some imports are failing

On it


feature request for adding action for comment line

Please add bindable action for commenting a line based on the selected file type.
Thanks

I've implemented this as a plugin which you can view here. Install with > plugin install comment.
The default binding to auto comment lines is Alt-/ but you can rebind that.
For more info, you can read the plugin's documentation.


Merge pull request #76

IMPORTANT: Please do not create a Pull Request without an issue.
All Submissions:

[x] I have read the CONTRIBUTING document.
[x] My code is written in Python3 and is ending with .py
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] I have checked that my submission does pass the test on LeetCode.com
[x] Does your filename follow the naming Conventions?
[x] Have you linked your PR to an Issue?

Closing issues
Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@adityaarakeri  adding a question of the coding problem by Readme.md file violates any rules of your repository can I know that.I thought when some people view the solution they need the question with clarity so I separately created a Readme.md file for the purpose of the question

@srisrinu1 can you squash your commits?


Styles: Refactor List

I originally set out to fix #879.
In short, when the list is ordered and in a container that has overflow: hidden, part of the numbers get lopped off because the marker is being rendered outside the list. Simply using list-style-position: inside makes the marker visible again, however it breaks the indentation from the second line onward.
I eventually ended up solving this using pseudo-elements, however, in the process I identified several other issues that made a general refactor of the styles the easiest way to fix this and other problems. Some of those included:

Classnames didn't follow the modified BEM convention that we're using
There were a lot of unnecessary classnames that were adding needless complication
The unordered List was broken for RTL layouts

This fixes the issue in the List component itself, but I think the issue may have first arisen from a list that was rendered in a RichText component that was rendered inside an Accordion. If that's the case, then we'll need to carry over these styles to the RichText component, which may be the next step here.
This includes some changes to the Twig template that will also need to be carried over to the React component. I'll include that here as well.
See Edits Below

Hey @justintemps had a look at this and it lgtm.


Missing errors

Missing errors:
"Failed","SERVER FAILURE","Errors or timeout for Server Processing the file:Job Fatal Error","0x01710006"
"Failed","SERVER FAILURE","Errors or timeout for Server Processing the file:Not all the items in the package have been migrated","0x01710009"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cfa08336-690e-0d21-6491-3f14f6d13391
Version Independent ID: 8927975a-7956-fc72-055e-36603e4eddaf
Content: Troubleshooting SharePoint Migration Tool
Content Source: migration/troubleshooting-common-spmt-issues.md
Product: sharepoint-server-itpro
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

@Marweis  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Another missing error:
"Failed","UPLOADING FAILURE","Failed to Upload the Job to Server:Upload file failed during migration","0x01510001"

@Marweis Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Replace hard copy with translations

Using the Rails translations framework allows us to centralise the text in
our views, so that it's easier to find and edit. This includes format-specific
text, for which we would otherwise require additional modelling/lookup
behaviour. Using the Rails translations framework for everything means
we can also test that all of the text has been defined for the views.
Translations are organised into a hierarchy in one or more YAML files. There
are multiple files to make finding things a bit easier, with each file following
the same conventions for the upper levels of the hierarchy, which will make
it easier to add new groups and avoids conflict. Here are some examples.
# formats/supertypes/en.yml (choosing a supertype)
en:
  formats:
    supertypes:
      news:
        label: News
        description: Some news

# formats/document_types/en.yml (guidance and labels)
en:
  formats:
    document_types:
      press_release:
        label: Press release
        guidance: ...

# layouts/en.yml (layout-specific text)
# not very interesting

pages/new_document/en.yml (new_document page-specific text)
en:
  pages:
    documents:
      index:
        title: No title
        actions:
          new: New document
        search_results:
          untitled: No title

This PR also makes sure we're using Plek for the URL preview, which
could be split out. Other PRs that we should do include: lifting the text
out of components (excluded here because the approach is unclear);
and changing the tests to use translations instead of hard-coded text.

Oh, and another PR is to do extract the text from the content validator. I also excluded this here because I think it doesn't seem to fit into any of the categories so far (formats, layouts and pages). Perhaps a new 'models' or 'services' category would make sense, so that it's clearer where the translations are being used.

@tijmenb @davbo This should be ready to review again now.


Added Educational website

Title and Issue number
Landing page for an educational website #3481
Close #3481

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[] I have created a helpful and easy to understand README.md

@pranjay-poddar @MohitGupta121 Please merge this

@pranjay-poddar @MohitGupta121 @TusharKesarwani

@MohitGupta121 fixed


fix: row adapter when label is present

Fixes #2384
This contains small a fix for labels check in RowAdapter. This was missed by me in the original PR.

As discussed offline, we should move this logic to the WhileMatchingScanAdapter


add config descriptions per user feedback

per user feedback during coalesce, the config sections don't explain the differences between resource-type configs vs general configs.
this pr adds a config description to the resource config section and general config section.

thank you for your detailed technical comments, i appreciate it. 🙏
I think combing them is a great idea, however i do think doing that is still not explicit enough for users. i like the idea of being more explicit so users have more insight into how they can apply each type of config for their own use case, as oppose to inferring it somehow in the comments of header (currently it's inferred via the header, i think).
I've tried to also make it clearer that the resource-specific config is only available that source using props but it's not working for me so I'm going to investigate more.

I've tried to also make it clearer that the resource-specific config is only available that source using props but it's not working for me so I'm going to investigate more.

The distinctions aren't working for me either. I suspect it's because there isn't really any meaningful distinction between resource-specific configs and general configs.
I'm guessing the reason the two different headers exist is just to make it easier to separate the configs that are unique to that particular resource type. e.g., show which configuration options for the snapshot resource type are different than all the rest of the resource types.

I think combing them is a great idea, however i do think doing that is still not explicit enough for users. i like the idea of being more explicit so users have more insight into how they can apply each type of config for their own use case, as oppose to inferring it somehow in the comments of header (currently it's inferred via the header, i think).

What would be some ways to give insight on how to apply each type of config? Do you think the examples section helps with that?


iPad: Webpage was reloaded when testing it in higher frequency

Describe the bug
iPad: Webpage was reloaded when testing it in higher frequency
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta#
2.Open any tutorials and test it
Actual behavior
Webpage was reloaded when testing it in higher frequency.

Additional context
1.OS: iPad mini4
2.arcade version: 0.18.14
3.Microsoft MakeCode version: 6.1.27

@Sheila111 can you verify this still repros. We have fixed bunch of issues.

@abchatra  Yes. It still repro in arcade/beta.

@Sheila111 does live repro here?

@abchatra also repro in live. But the frequency of this issue is not sure.

I'm seeing an odd flicker on the UI on the homepage which we should fix, but the tutorial seems to be working fine:
https://www.icloud.com/photos/#0uvEu-6ShgILeA40_Wi0zRASA

But this issue I'm not repro'ing. My ipad is:
iPad (7th gen); iPad OS 13.5.1
@abchatra  I recommend we close this as no-repro given both u and I haven't been able to repro

I have removed next-release and will keep it as this keeps coming back with a needs repro tag.


User name not updated on navigation drawer

Describe the bug
After changing username infomation, navigation drawer doesn't update it
Screenshots

Would you like to work on the issue?
Open to all

I want to fix this issue. Can you please allow me to look after this issue and contribute.

Please go ahead

thanks, sir for this

@rajput2122 Any updates on this?

Can I work on this?

@naman653 Yes, go ahead.

i would like to work on this issue

I am still working on this issue.

@naman653 Any update?

Go ahead @codedsun

Can i work on this issue??

@njnaman i am working on this issue, I got some issues with the app yesterday .


Attempts to make tests work better using the buildkite plugin

Not making this a draft or the CI won't run

So this may be working now, so I'm going to make a branch from this branch and PR it into main, then make them both run at the same time to see if that works as a stress test

This is way way slower for some reason? In #186 (old version of pipeline) the tests finish in <20min but this is still running after 45min.

Maybe I should experiment with what we're caching

Ah it realises that these branches are duplicates I think

This does seem a lot more robust now but also a lot slower, I will investigate adding more caching

I don't think we should do it this way since its so slow


 Cropping should still work, though, since you're just chopping the same section of the image off regardless of the zoom level.
The lack of cropping is definitely the worst part of working with images in Obsidian for me, so it would be great if you could add that feature.

Hi @afland , Thanks for your feedback.  When the image you clicked is popped up, the size of the image now depends on current window size of your Obisidan tool. The size of the image will be resized and is not as same as that of the original embeded image. Yet you can resize the image through zooming in/out then.

I would also highly appreciate cropping (not resize). For example - I copy paste an image from a pdf I'm reading, but I want only a single sub-figure. Currently, I need to cut it out with an external tool.


Add support for ULID

See https://github.com/oklog/ulid
This ID has some interesting characteristics that would be a good fit for Storm, me thinks, one of them being the "lexicographically sortable".
It should live in a separate package, I guess, but I think it would be useful as a built-in option similar to AutoIncrement -- `AutoULID``?
If there this sound interesting I can take a stab on implementing it.

Thinking about it a little, one of the plus sides of these IDs is that they can be set before persisted to DB, so if this is added we should add a way to just get a new ID -- still valuable as me and others then do not have to set up pooling for rand etc.

I think there should be a way to setup the incrementer that would be called by Storm everytime it needs a new ID.

I think there should be a way to setup the incrementer that would be called by Storm everytime it needs a new ID.

Yes, we should add some kind of IDProvider interface, which defaults to the current
So we could do something ala:
db, cleanup := createDB(b, AutoIncrement(ULID()))

Or something.
And then add a GetIDProvider() func, which in some cases would fail if not inside a transaction.
The AutoIncrement setting name is unfortunate, maybe AutoID... I see the GoDoc is still talking about BoltDB's NextSequence, but it seems to have been replaced with some custom; what is the reason behind that @asdine?

If i remember well, it was because NextSequence doesn't allow us to set the initial value of the counter.
Also, the AutoIncrement option is deprecated and should be removed soon.
Concerning the IDProvider it seems to be a good idea.
Currently, there is a metadata bucket stored inside each bucket that contains the codec used and the current counter.
It could be used to call the IDProvider to generate the next id by passing the last one used.
db, err := storm.Open("my.db", IDProvider(ULID()))

type IDProvider interface {
  NextID(last interface{}) interface{}
}

I'm not a big fan of empty interfaces but i don't think we have a choice here wdyt @bep ?

Would it not be be better if it was non race condition exposed ?
In other words ask the metaBucket / IDProvider for the next ID, because only it knows.
Or
After a commit just always send back the ID in the return call. Then there is no chance of race condition.

@asdine IDProvider can't be both this interface, and a function that returns func(*DB) error, per:
func Open(path string, stormOptions ...func(*DB) error) (*DB, error)

I envisioned something like:
type IDProviderFunc func(last interface{}) interface{}

func IDProvider(IDProviderFunc) func(*DB) error {...}

db, err := storm.Open("my.db", IDProvider(storm.ULID))

I'm not a huge fan of the empty interfaces here either, but alternatives do not come to mind immediately.
@joeblew99 this is why @bep suggests that some cases would error outside a transaction, otherwise, a mutex per bucket is probably required, but all this would be transparent to the user/provider-implementer.

@joeblew99 Actually, the meta.Increment call is done within a write transaction so it's not subject to race conditions. Also the call to the IDProviderFunc will be done exclusively inside the write transaction.
@pdf Yes sorry, i picked the wrong name and my example is confusing. Your solution is cool, a function should be enough.

type IDProviderFunc func(last interface{}) interface{}

What is the purpose of last? I thought this was either very stateful (meta.Increment)  or very stateless (ULID, UUID...).

This supports both stateful and stateless - last would be the previous int for auto-increment, and ignored by the ULID implementation.

last would be the previous int for auto-increment

That I understand. But the whole point of this operation is to make Storm do the heavy lifting of ID creation, including knowing what the last value was, if relevant.

Right, so declaring the IDProvider attaches it to the DB instance, the meta bucket stores the last ID, which is passed to the attached provider, which returns the next ID.  This method of declaration allows people to implement external providers if they so choose, but we would have an auto-increment and ULID provider available inside storm.
Make sense?

Also see https://github.com/segmentio/ksuid


Add housename and floor number to address (at least in Japan)

Addresses of businesses in Japan often include the building name and the floor number information too. It would be useful to have these easily add-able with iD.
See https://en.wikipedia.org/wiki/Japanese_addressing_system

@nicolasmaia So you mean the addr:housename and addr:floor tags? Is there OSM wiki documentation for Japanese address formats?

There is, but in Japanese:
https://wiki.openstreetmap.org/wiki/JA:住所#.E6.97.A5.E6.9C.AC.E3.81.AE.E4.BD.8F.E6.89.80.E4.BD.93.E7.B3.BB.28.E8.A1.97.E5.8C.BA.E7.95.AA.E5.8F.B7.E3.83.BB.E5.9C.B0.E7.B1.8D.E8.BB.A2.E7.94.A8.29
and
https://wiki.openstreetmap.org/wiki/JA:Key:addr


Dev builds published to Maven central causing automatic upgrades to -alpha

What happened?
Currently the build pipeline pushes pre-release builds to Maven Central and for both Maven and Gradle projects templates there does not seem to be an easy way to specify "use latest except pre-release". As a result, customers end up with projects that pull in "latest" release from Maven Central, and this may be a pre-release published from Pulumi.
This is causing issues like this one: https://github.com/pulumi/pulumi-aws/issues/2658
In addition, pre-releases don't look great on Maven Central.
The proposal is to avoid publishing pre-release to Maven Central all together.
Expected Behavior
User projects pull latest production Java builds.
Steps to reproduce
See referenced issue.
Output of pulumi about
N/A
Additional context
This issue is not specific to AWS but affects all Pulumi providers, but starting here as the most obvious place to file.
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

What do we believe the benefit is for pushing dev builds to Maven Central? Do we believe that users actually want to consume the dev builds?

I think some analysis is in https://github.com/pulumi/home/issues/3572
I was just cleaning aws Backlog and moved it here since the issue pertains to all providers .