Ollama is running on both CPU and GPU - expected to use GPU only

What is the issue?
When I run "ollama run llama3.1:70b", I can see that 22.9/24 GB of dedicated GPU memory is used, and 18.9/31.9 GB of shared GPU memory is used (it's in Chinese so I did the translation).

From "server.log" I can see "offloaded 42/81 layers to GPU", and when I'm chatting with llama3.1 the response is very slow, "ollama ps" shows:

Memory should be enough to run this model, then why only 42/81 layers are offloaded to GPU, and ollama is still using CPU? Is there a way to force ollama to use GPU? Server log attached, let me know if there's any other info that could be helpful.
OS
Windows11
GPU
Nvidia RTX 4090
CPU
Intel i7 13700KF
RAM
64GB
Ollama version
0.3.0
server.log

@mxmp210
Thanks for your reply, however I don't have this issue running llama3.1:70b, the model can be loaded succesfully but the response is very slow since Ollama is running on CPU. I have 64 GB RAM.

@dhiltgen could you help to take a look at this issue? I'm not sure if it'd be rude to @ you like this, I just saw you're helping people with other problems, and I think you may help me on this, thanks in advance!

time=2024-07-27T14:30:02.936+08:00 level=INFO source=memory.go:309 msg="offload to cuda" layers.requested=-1 layers.model=81 layers.offload=42 layers.split="" memory.available="[21.3 GiB]" memory.required.full="39.3 GiB" memory.required.partial="21.1 GiB" memory.required.kv="640.0 MiB" memory.required.allocations="[21.1 GiB]" memory.weights.total="36.5 GiB" memory.weights.repeating="35.7 GiB" memory.weights.nonrepeating="822.0 MiB" memory.graph.full="324.0 MiB" memory.graph.partial="1.1 GiB"

ollama is using the GPU: almost all (21.1 of 24G) is being used for the model.  But the model is larger than the available dedicated VRAM, it needs a total 39.3G of RAM.  So some it has to spill into system RAM, which is 18.2G of shared GPU memory.

time=2024-07-27T14:30:02.936+08:00 level=INFO source=memory.go:309 msg="offload to cuda" layers.requested=-1 layers.model=81 layers.offload=42 layers.split="" memory.available="[21.3 GiB]" memory.required.full="39.3 GiB" memory.required.partial="21.1 GiB" memory.required.kv="640.0 MiB" memory.required.allocations="[21.1 GiB]" memory.weights.total="36.5 GiB" memory.weights.repeating="35.7 GiB" memory.weights.nonrepeating="822.0 MiB" memory.graph.full="324.0 MiB" memory.graph.partial="1.1 GiB"

ollama is using the GPU: almost all (21.1 of 24G) is being used for the model. But the model is larger than the available dedicated VRAM, it needs a total 39.3G of RAM. So some it has to spill into system RAM, which is 18.2G of shared GPU memory.

I understand that the dedicated 24 GB VRAM is not enough to load the model so shared GPU memory is used, although the "shared GPU memory" is actually RAM, it should be considered as "VRAM" just speed is lower than real VRAM. So do you mean that no matter it's shared GPU memory or just RAM, as long as part of the layers are offloaded to RAM, Ollama will use CPU + GPU?

I don't have a deep knowledge of Nvidia devices/drivers or how llama.ccp uses them, but generally the problem with RAM limited peripherals is memory bandwidth.   PCIe devices can access system RAM, but the speed is lower than the speed at which the CPU can access it.   If we take current top of the line tech, a x16 PCIe4 bus has about 32GBps simplex data transfer rate while a DDR5 based CPU/RAM system has about 64GBps.  (GPUs have a higher bandwidth with their local memory due the increased width of the bus, GDDR6 is typically > 800GBps while HBM is measured in TBps).  So while it's technically possible to have a PCI based device access system RAM, it's usually more efficient to allow the CPU to process the data in system RAM and the PCI device process data in its own RAM.
Somebody with more knowledge of Nvidia cards and llama.cpp could provide more insight.

I don't have a deep knowledge of Nvidia devices/drivers or how llama.ccp uses them, but generally the problem with RAM limited peripherals is memory bandwidth. PCIe devices can access system RAM, but the speed is lower than the speed at which the CPU can access it. If we take current top of the line tech, a x16 PCIe4 bus has about 32GBps simplex data transfer rate while a DDR5 based CPU/RAM system has about 64GBps. (GPUs have a higher bandwidth with their local memory due the increased width of the bus, GDDR6 is typically > 800GBps while HBM is measured in TBps). So while it's technically possible to have a PCI based device access system RAM, it's usually more efficient to allow the CPU to process the data in system RAM and the PCI device process data in its own RAM.
Somebody with more knowledge of Nvidia cards and llama.cpp could provide more insight.

Thanks very much for the explaination, I don't have this kind of knowledge, I just thought that since it's called "shared GPU memory", if it can only be used in the same way as normal RAM, then it's meaningless; like the "virtual memory" is just a file on hard drive, it's treated like "RAM" not hard drive.
If "shared GPU memory" can be recognized as VRAM, even it's spead is lower than real VRAM, Ollama should use 100% GPU to do the job, then the response should be quicker than using CPU + GPU. I'm not sure if I'm wrong or whether Ollama can do this.

Whether CPU+GPU or GPU only is faster or slower depends on the where the bottleneck is, memory bandwidth or compute. Either way, it's not an ollama issue, it's a llama.cpp issue.   Follow up on https://github.com/ggerganov/llama.cpp/issues/6743.

Whether CPU+GPU or GPU only is faster or slower depends on the where the bottleneck is, memory bandwidth or compute. Either way, it's not an ollama issue, it's a llama.cpp issue. Follow up on ggerganov/llama.cpp#6743.

I subscribed to this issue, it's not the same as mine. On my PC when Ollama is running llama3.1 70b both VRAM and shared GPU memory are used, however most of the time it's CPU doing the job and GPU is barely used (judging from performance monitor). I agree with @alirezanet that even some layers are offloaded to shared GPU memory, CPU should not be used mainly. In my case it takes more than 1 min before Ollama starting to respond (to a simple chat like just saying "hello"), and I can only get about 1 word per second, the performance is too bad.

Stable Diffusion users found shared memory impacted processing speed so much that Nvidia added an option to turn it off.  If you have time, it would be interesting if you could try this and see if anything changes.  Having read up a little bit on shared memory, it's not clear to me why the driver is reporting any shared memory usage at all.  llama.cpp has only got 42 layers of the model loaded into VRAM, and if llama.cpp is using CPU for the other 39 layers, then there should be no shared GPU RAM, just VRAM and system RAM.  It would be interesting if you could post a screen cap of the GPU and CPU usage for the entire time that llama.cpp is doing inference, to see if the load switches completely between GPU and CPU or if it uses a bit from both at the same time.

I tried to set "prefer no system fallback" for ollama app.exe, ollama.exe and ollama_llama_server.exe, restarted Ollama, restarted PC, with no result... when I run "ollama run llama3.1:70b" it's still using 20+ GB of shared GPU memory. I took a screenshot after I sent "hello" to the model, and this is the CPU and GPU usage when llama3.1 is thinking about how to respond. The GPU usage is about 10% all the time, sometimes it'll raise to about 30% then immediately drop to lower than 10%.

As others have pointed out, ollama (and the underlying llama.cpp library) utilize dedicated VRAM on the GPU for inference.  Once that memory is near fully allocated, the remaining portions of the model are loaded into system memory and inference is performed using the CPU.
What Windows does with the shared memory is perform a paging algorithm where pages of memory are swapped back and forth between system RAM and GPU VRAM, and while this does allow some apps to overflow VRAM, the performance impact to inference would be significant.  It's better to leverage the CPU for performing inference of the portion of the model that doesn't fit within VRAM in parallel with the GPU processing its portion of the model, instead of thrashing memory pages back and forth.

As others have pointed out, ollama (and the underlying llama.cpp library) utilize dedicated VRAM on the GPU for inference. Once that memory is near fully allocated, the remaining portions of the model are loaded into system memory and inference is performed using the CPU.
What Windows does with the shared memory is perform a paging algorithm where pages of memory are swapped back and forth between system RAM and GPU VRAM, and while this does allow some apps to overflow VRAM, the performance impact to inference would be significant. It's better to leverage the CPU for performing inference of the portion of the model that doesn't fit within VRAM in parallel with the GPU processing its portion of the model, instead of thrashing memory pages back and forth.

@dhiltgen Thanks very much for the explaination, I understand now that it's better to leverage CPU to handle the layers loaded into RAM together with GPU to handle the layers loaded in VRAM. I have one concer left: in my case about half the layers are loaded into RAM and the other half loaded into VRAM, when GPU and CPU are performing inference together the CPU usage is about 40% and most of the time the GPU usage is about 10%, hardly reaches 30% then drop to 10% immediately, is there anything I can do to make most use of both GPU and CPU to get better inference performance?

Update - today I updated Ollama to version 0.3.2, llama3.1 70B loads faster (about 25 sec) than before (Ollama ver 0.3.0, more than 1min), CPU utilization is higher (about 70%) but GPU utilizaiton is still low (about 20%). 40/81 laysers are loaded into VRAM.

My CPU is Intel 13700KF, it has 16 cores and 24 threads, I tried to use "/set parameter num_thread 24" and "/set parameter num_thread 16" to set the parameter but only get about 40% CPU usage, can't even make it to 70% as when I updated Ollama yesterday, and the GPU usage is still low - about 10% to 20%. I'll try with some other numbers to see if it can be better. Is there any parameter that I can use to improve GPU utilization?

mybe you need two 4090 GPUs to run the 70B model?估计你需要2张4090才能跑70b不卡

mybe you need two 4090 GPUs to run the 70B model?估计你需要2张4090才能跑70b不卡

Yes, 48G GPU at least

I'm experiencing the same symptom here: CPU is reporting high load, but only GPU should be used (using VRAM and shared memory). Maybe there is a bug in ollama.cpp?

I have Ollama for windows, RTX 4060 and ollama keeps insisting on using CPU and RAM instead my GPU. It is very disapointing because I spent a fortune buying this gpu.

ollama will use the GPU if it's able to.  If you would like your issue debugged, open a new ticket and add server logs.


[GH-954]:Fixed issue 'DM comment notifications not working'

Summary

Fixed the issue that users were not getting DM notifications when they are mentioned in a Jira issue comment.
Updated the code to replace the jira username or email address with mattermost username.

Issue

Issue #954

Codecov Report
Patch coverage: 55.55% and project coverage change: +0.01% :tada:

Comparison is base (1766506) 31.16% compared to head (45996ec) 31.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
+ Coverage   31.16%   31.17%   +0.01%
==========================================
  Files          50       50
  Lines        7409     7409
==========================================
+ Hits         2309     2310       +1
+ Misses       4909     4904       -5
- Partials      191      195       +4

Files Changed
Coverage Δ

server/utils.go
20.35% <55.55%> (+2.65%)
:arrow_up:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@DHaussermann Heads up that this is a customer reported issue. LGTM ready for QA review


vcpkg install qt5:x64-windows

CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:56 (message):
Command failed: PYTHON2-NOTFOUND;D:/src/vcpkg/installed/x64-windows/share/qt5modularscripts/fixcmake.py;qt5-datavis3d
Working Directory: D:/src/vcpkg/buildtrees/qt5-datavis3d/x64-windows-rel/lib/cmake
See logs for more information:
Call Stack (most recent call first):
installed/x64-windows/share/qt5modularscripts/qt_modular_library.cmake:51 (vcpkg_execute_required_process)
ports/qt5-datavis3d/portfile.cmake:5 (qt_modular_library)
scripts/ports.cmake:71 (include)
Error: Building package qt5-datavis3d:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: qt5-datavis3d:x64-windows
Vcpkg version: 2018.11.23-nohash

@liangshoulong, thank you for posting this issue!
I can't reproduce this issue locally, does the issue persist? can you try vcpkg latest revision? and check if python2 download and correctly place at  .\downloads\tools\python\python2?

I have this error again.
.\vcpkg.exe install qt5:x64-windows-static
this is error info:
Starting package 1/28: qt5-declarative:x64-windows-static
Building package qt5-declarative[core]:x64-windows-static...
-- Using cached E:/github/vcpkg/downloads/qtdeclarative-everywhere-src-5.12.1.tar.xz
-- Using source at E:/github/vcpkg/buildtrees/qt5-declarative/src/5.12.1-1f64885d6f
-- Configuring x64-windows-static-rel
-- Configuring x64-windows-static-rel done
-- Configuring x64-windows-static-dbg
-- Configuring x64-windows-static-dbg done
-- Package makefiles-x64-windows-static-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:56 (message):
    Command failed: E:/github/vcpkg/downloads/tools/jom/jom-1.1.2/jom.exe;qmake_all
    Working Directory: E:/github/vcpkg/buildtrees/qt5-declarative/x64-windows-static-dbg
    Error code: 2
    See logs for more information:
      E:\github\vcpkg\buildtrees\qt5-declarative\package-makefiles-x64-windows-static-dbg-out.log
      E:\github\vcpkg\buildtrees\qt5-declarative\package-makefiles-x64-windows-static-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_build_qmake.cmake:38 (vcpkg_execute_required_process)
  scripts/cmake/vcpkg_build_qmake.cmake:52 (run_jom)
  installed/x64-windows-static/share/qt5modularscripts/qt_modular_library.cmake:56 (vcpkg_build_qmake)
  installed/x64-windows-static/share/qt5modularscripts/qt_modular_library.cmake:150 (qt_modular_build_library)
  ports/qt5-declarative/portfile.cmake:5 (qt_modular_library)
  scripts/ports.cmake:71 (include)

Error: Building package qt5-declarative:x64-windows-static failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: qt5-declarative:x64-windows-static
  Vcpkg version: 2018.11.23-nohash

I hava the last version of  vcpkg.
vcpkg commit id : 6f0923ae93d28287d21219c57a6c8cd3e249bdd4
In the $(vcpkgPath)\buildtrees\qt5-declarative\package-makefiles-x64-windows-static-dbg-err.log file. the error msg:
jom 1.1.2 - empower your cores

'E:\github\vcpkg\buildtrees\qt5-declarative\x64-windows-static-dbg\bin\qmlimportscanner.exe' is not recognized as an internal or external command,
operable program or batch file.
'E:\github\vcpkg\buildtrees\qt5-declarative\x64-windows-static-dbg\bin\qmlimportscanner.exe' is not recognized as an internal or external command,
operable program or batch file.
E:/github/vcpkg/installed/x64-windows-static/share/qt5/debug/mkspecs/features/qt.prf:299: Error parsing JSON at 1:1: illegal value
Project ERROR: Failed to parse qmlimportscanner output.
E:/github/vcpkg/installed/x64-windows-static/share/qt5/debug/mkspecs/features/qt.prf:299: Error parsing JSON at 1:1: illegal value
Project ERROR: Failed to parse qmlimportscanner output.
jom: E:\github\vcpkg\buildtrees\qt5-declarative\x64-windows-static-dbg\tools\Makefile [sub-qml-qmake_all] Error 3
jom: E:\github\vcpkg\buildtrees\qt5-declarative\x64-windows-static-dbg\tools\Makefile [sub-qmleasing-qmake_all] Error 3
jom: E:\github\vcpkg\buildtrees\qt5-declarative\x64-windows-static-dbg\Makefile [sub-tools-qmake_all] Error 2

the directory of $(vcpkgPath)\buildtrees\qt5-declarative\x64-windows-static-dbg\bin  is empty.

Hi @liangshoulong @chen610620, thanks for reporting this issue.
Since qt has been upgrade to 5.12.4, we fixed this issue. Please update vcpkg and rebuild qt5.
Thanks.

no, it merged again on my PC. qt5 version is 5.15.11 and my vcpkg is downloaded just now. while i am using the command: ./vcpkg install qt5:x64-windows-static

This issue is from 2019!


mapContainer doesn't work on pod.

I'm currently using k8s 1.21, and it seems that I can't mapContainers for pods.
I also can't use the nice volumeMount functions, because they're not defined for pod.

I think this hasn't been use-case so far. Could you describe what you use it for and provide a minimal example?

Didn't get a response, closing.


Remove provisioning_events that not yet occured

Just after provisioning server we have provisioning_events in responce that are useless and may be confusing. There is no useful data provided, and none of there events were fired at the moment, is there a reason for them to be shown to user?
provisioning_events=[
{"id"=>nil, "type"=>"provisioning.101", "body"=>"Provisioning started", "state"=>nil, "created_at"=>nil, "relationships"=>[], "ip"=>nil, "modified_by"=>nil, "interpolated"=>"Provisioning started"},
{"id"=>nil, "type"=>"provisioning.102", "body"=>"Network configured", "state"=>nil, "created_at"=>nil, "relationships"=>[], "ip"=>nil, "modified_by"=>nil, "interpolated"=>"Network configured"}
...

I'd suggest to show only events that actually took place.

I'm not sure I understand. The response is returning exactly what the API is returning. If the response from the provider library is confusing, should the API be returning the response?
If compute.devices.create (POST) returns the provisioning events, it seems like they should be included. Whereas compute.devices.get(device_id) (GET) does not include the provisioning events since it was not a provisioning request. This seems like normal behavior.

Was a bit confusing to get it after post, but I can live with it :)


Table of content | Academy | New component to navigate within an article

Jira
http://vjira2:8080/browse/BDS-1971
Summary
Introduces a new component called Table of Content: a navigation list, usually found on an article page, of its section titles.
Details

Each item is set up as a link, and can be set as the current item by setting the active prop.
Fully built out the JS and Twig.
Documented all props and existing use cases (Academy Mission Details page).

Still to do:

[ ] Implement smooth scrolling with the active prop.

How to test
Pull down the branch and run locally. Review the code and the docs.

PR was released with v2.17.0


Renamed content directories not added to the watcher

In my case, I have to cancel the build to even rename a content directory, then restart the server.


DO NOT MERGE: CI Test: Add JupyterHub default groups CM

Signed-off-by: Landon LaSmith<EMAIL_ADDRESS>
[ ] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
[ ] JIRA link(s):
[ ] The Jira story is acked
[ ] An entry has been added to the latest build document in Build Announcements Folder.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

/test all

/test all

/test all

/test all

/test all

/test all


Run html2text as a subprocess

html2text is GPL licensed.

How does calling the API from a subprocess fundamentally any different than importing the library and calling the function? html2text's source code is not shipped together in Zulip.

I suppose FSF has the last say on this:

If the modules are included in the same executable file, they are definitely combined in one program. If modules are designed to run linked together in a shared address space, that almost surely means combining them into one program.

By contrast, pipes, sockets and command-line arguments are communication mechanisms normally used between two separate programs. So when they are used for communication, the modules normally are separate programs. But if the semantics of the communication are intimate enough, exchanging complex internal data structures, that too could be a basis to consider the two parts as combined into a larger program.

Nevermind then. Ignore my concern. But this means I have to update my other projects that use GPL libraries.

Merged, thanks @andersk!


add home page structure to Help Site

cc @michelle-thompson
Details

This PR only includes the structure for the homepage and fixes the styles for the homepage and hub pages on large screens. The site's content is still WIP, but once the content is done, we're just going to replace the text in the respective HTML or Markdown files and can be done by someone of the resource management team.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/216731
Tests

(you need ruby and bundler installed to do this, more info here)

Run:
cd docs
bundle install
bundle exec jekyll serve

Navigate to http://localhost:4000/main and verify the structure of the homepage is displayed as in the design document mockups or the screenshots attached at the end.

QA Steps

Go to https://help.expensify.com/main and verify the structure of the homepage is displayed (as in the screenshots)
Screenshots

Web

Big screen:

Mobile Web

The content on the home screen isn't showing up - is that to be expected?
I noticed that on hover, links are underlined. I think we should stick to similar styling as UseDot, so let's remove the underlining for hover.

The content on the home screen isn't showing up - is that to be expected?

Oh, do you mean just an empty screen? Like this one:

Because currently the Homepage (/main) is empty in https://help.expensify.com/main, and won't show up until this PR is merged (we can only see the changes locally).

I noticed that on hover, links are underlined. I think we should stick to similar styling as UseDot, so let's remove the underlining for hover.

Sounds good! Removing the underling for hover...

Okay, I can't run locally but I'm curious about the hover over the card - what does that look like?
And one more thing I noticed on mobile - the bolded body text doesn't look like GT America

The underling for hover was removed and looks like this:
https://user-images.githubusercontent.com/6829422/181103776-efb3cfc3-aa64-4af8-bacb-4e31877940ca.mov

Okay, I can't run locally but I'm curious about the hover over the card - what does that look like?

This is what the hover over a card looks like, it just changes the cursor to pointer:
https://user-images.githubusercontent.com/6829422/181104011-5312602c-fc66-4c48-9ee5-ee85fcc7f178.mov
I'm wondering if we add an animation or just leave it as it is, what do you think?

And one more thing I noticed on mobile - the bolded body text doesn't look like GT America

Yeah, seems we had a bad font configuration for the bolded text, this is how it looks using the default configuration (the difference is subtle but the bolded text looks a bit smaller):

For the cards, how about we change the border color upon hover? So for the blue, green, and grey borders, they all darken by 2.5% - I found this in UseDot, I'm assuming that's what it means, hahah.

As for the mobile font - that looks like medium weight, can we change to bold?

Hi @michelle-thompson, I was playing with the border color upon hover, and I think the best value is 15%, because for 2.5% the difference is hardly noticeable imo, what do you think?
https://user-images.githubusercontent.com/6829422/181335137-c296f3d4-6b4f-4e91-a393-a42c45470920.mov
This is how it looks with 2.5%:
https://user-images.githubusercontent.com/6829422/181340177-a3df4da7-bb9d-41cb-87d8-b8071c3c1150.mov

As for the mobile font - that looks like medium weight, can we change to bold?

We had another bad configuration hehe. For the bold text we were using font-weight: 600, but now I changed it to font-weight: bold and this is how it looks:
Mobile:

Desktop:

@marcochavezf 15% and bold weight look great 👍

hi @tgolen! the visual changes are done, the code is ready to be reviewed 👍🏽

I updated the code to use anchors instead of clickable divs, it's ready to be reviewed again!

Hi @tgolen! friendly bump since we have other issues that depend on these changes :) Thanks!

Updated with the DOMContentLoaded event, ready to be reviewed again @tgolen!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


ISC.routines throws errors while showing C-language function definitions

This is due to C-language function like xp_qv, xp_instance_regread contains
probin as babelfishpg_tsql. Usually in information_schema it won't show
system C-language function but for xp_* functions we need to handle it
gracefully(by returning NULL instead). If the routine implementation language is other than 'pltsql', we are returning NULL for the definition.
Task: BABEL-3444
Signed-off-by: Shalini Lohia<EMAIL_ADDRESS>Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Can you please fix this check in your PR: https://github.com/babelfish-for-postgresql/babelfish_extensions/blame/BABEL_2_X_DEV/contrib/babelfishpg_tsql/src/pltsql_ruleutils.c#L794

Can you please fix this check in your PR: https://github.com/babelfish-for-postgresql/babelfish_extensions/blame/BABEL_2_X_DEV/contrib/babelfishpg_tsql/src/pltsql_ruleutils.c#L794

Fixed it.


chore(build): add semantic-release

I guess this is already done @treshugart ? if yes pls close. thx

Yap. Thx for the triage!


docs: Add clarifications to bots guide.

@derAnfaenger

Automated message from Dropbox CLA bot
@robot-dreams, it looks like you've already signed the Dropbox CLA. Thanks!

Merged, thanks @robot-dreams!


newrelic_ini_appname does not make it into newrelic.ini (and presumably other vars)

The newrelic.ini template attempts to use data with local variable names, but no data is actually being passed to it.
I believe that all parameters in the php agent definition are now ignored because the ini file is created in a separate class scope of newrelic::php::newrelic_ini:
::newrelic::php::newrelic_ini { $newrelic_php_conf_dir:
  exec_path            => $newrelic_php_exec_path,
  newrelic_license_key => $newrelic_license_key,
  before               => [ File['/etc/newrelic/newrelic.cfg'], Service[$newrelic_php_service] ],
  require              => Package[$newrelic_php_package],
  notify               => Service[$newrelic_php_service],
}```

I'm pretty sure the template does not have access to these variables from here. The variables need to get passed into newrelic::php::newrelic_ini or the template needs to refer to each variable with the prefix `newrelic::agent::php` like `newrelic::agent::php::newrelic_ini_appname`

Validated and am making a pull request in a few

Can anyone review this pull request and merge it in? It breaks in Travis CI, but the errors displayed in the details seem like an issue with Travis CI or its config; not a code issue. This code works and I have been using this on projects since I submitted the PR.

Any update on this? We'd like to go back to using a tagged version, but this needs to get merged in.

For anyone else hitting this, another workaround is to set it in php settings (if using the mayflower/php)
php::settings:
  newrelic/appname: My App Name

You can also do this in Nginx vhosts if using puppet/nginx if you need to set this per application:
nginx::nginx_vhosts:
  myvhost:
    # other code
    locations:
      # Other locations
      index_php:
        location: /index.php
        fastcgi: <IP_ADDRESS>:9000
        index_files: []
        www_root:
        location_cfg_prepend:
          expires: "off"
          fastcgi_read_timeout: 18000
        fastcgi_param:
          SCRIPT_FILENAME: $document_root$fastcgi_script_name
          PHP_VALUE: "newrelic.appname=\"My App Name\""

Can confirm I'm seeing the same issue.
Would be hugely helpful to have https://github.com/fsalum/puppet-newrelic/pull/71 merged!

I can also confirm the same issue. The proposed fix in #71 solves the issue. @fsalum Is there any chance you could hit the merge button on that PR? :)


User name edit in Profile Activity

User name edit in Profile Activity.
When user will click on edit button it will show dialog box with edittext . then user can change his/her name .
and it will also update on firebase also ..

I want to work on this issue under JWOC

Ohk @binayshaw7777


Display data rates as megabits not megabytes

The AST seems to use bytes per second everywhere it is describing a data rate. This is an unusual way of measuring throughput. The BIG-IP on-box graphs, and indeed the F5 licensing scheme will typically use bits per second.
It is more common to use bits when describing throughput.

Hey @init4 - We've had several people comment on the pro/con of doing this. I'll close the ticket and add this to the feedback.


chore(release): 0.16.3

Types of changes
What kind of change does this PR introduce? (check at least one)

[ ] Breaking change
[ ] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactoring
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe:

Release v0.16.3
Description

Issue Number: N/A

Codecov Report

Merging #174 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #174   +/-   ##
=======================================
  Coverage   88.93%   88.93%
=======================================
  Files          20       20
  Lines         226      226
  Branches       46       47    +1
=======================================
  Hits          201      201
  Misses         19       19
  Partials        6        6

Impacted Files
Coverage Δ

src/lib/buildRouteFile.ts
71.42% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1333c97...1b35179. Read the comment docs.


How to change options like "widget_base_dimensions" after init ?

Does it possible to change options and re-init ? (on-the-fly)
PS: I just want to change widget_base_dimensions (height) after window resized

My solution:

Destroy current instance

Init again ( using updated options )

I guess this is not the best solution, anyway, it works.

1.Get gridster instance => 'gridsterObj'
2.gridsterObj.options. widget_base_dimensions = [your wanted height];
3.excute 'gridsterObj.init()'


take care of compiler warnings

there is only one compiler warning left ...

Thanks for helping to improve the code :+1:


[docs] Update link to Presto website

This is the new home for the Presto project under the Presto Software Foundation.

run integration tests

run integration tests

Are those commands for a bot or are you asking me to do something?

@electrum : those are for a bot :)


KAFKA-4275: Check of State-Store-assignment to Processor-Nodes is not enabled

Anyof @guozhangwang @hjafarpour @enothereska @dguy @miguno

Error seems to be because no space left on device, would be good to restart jenkins job.

Did trigger new build.

Build did pass. Please review.

About suppress: I did enable "auto remove for unnecessary" in Intellij, which seems not to work correctly. Will revert those changes.

@guozhangwang @dguy Updated. Please review.

@guozhangwang @dguy Fixed non-materialized KTable issue.|
Please review.

@guozhangwang @dguy Updated.
(Removed integration test -- it is covered by KStreamKTableJoinIntegrationTest already.)

I'm assuming the test failure is unrelated - ResetIntergrationTest

@guozhangwang Updated.

Merged to trunk and 0.10.1 branch.


Provide Orthanc server port in sourceUri returned from Orthanc route

Currently using LFH REST 9090 instead of Orthanc 8042.

resolved in PR 136


fix(explain_manifest): fix behaviour change or API after version bump

Regression from https://github.com/Kong/kong/pull/13639

cherrypick in https://github.com/Kong/kong/pull/13721


Can't add second characteristic with esp_ble_gatts_add_char (IDFGH-3212)

Environment

Development Kit:      ESP32-Wrover-Kit
Kit version: v4.1
Module or chip used:  ESP32-WROVER
IDF version: framework-espidf 3.40000.200303 (4.0.0) (in Platformio)
Build System:         idf.py (Platformio)
Compiler version: xtensa-esp32-elf-gcc (crosstool-NG esp-2019r2) 8.2.0
Operating System:     Windows 10
(Windows only) environment type: Plain Command Prompt.
Using an IDE: VScode, Platformio
Power Supply:         USB

Problem Description
I am trying to add second characteristic with esp_ble_gatts_add_char and this not works - I can see only first char. Is this function supposed to add more than single characteristic to every service?
And yes, I've have seen table method for multiple characteristic - I don't need default value for all them (as in example), so I am trying to avoid it now.
Expected Behavior
Call esp_ble_gatts_add_char at second time should add second char
Actual Behavior
In ble scanner I can see only first char

Looks like I should wait callback (ESP_GATTS_ADD_CHAR_EVT) after first char adding and then add second.

Hi, @saloid
At the beginning, I failed to create two Characteristic in ESP_GATTS_CREATE_EVT in succession, but the reason is different from yours. When calling esp_ble_gatts_create_service to create a service, you need to set the number of request handles. This value is 4 in the demo, because the service needs one and the characteristic needs three. If you want to add second Characteristic, then the value of num_handle needs to be changed to 7.
The ESP-IDF I am using is v4.0 stable version.You can try this method.

Hi, @GitOfLance
Thank you for your reply. In my case it works as I described - just need to create second one in callback. But, in this case I am assuming that single characteristic consumes only 2 handles, not 3! In this example, 4 handlers used only because there also one handler for descriptor.
So single service definition looks like this: 1xservice + 2xcharacteristic + 1xdescriptor

Hi, @saloid
In the subsequent use, it was found that if two Characteristic were created at the same time, the communication would be disordered. For example, the Listen for notifications function of Characteristic_A was enabled, but the data was received on Characteristic_B. Therefore, the correct way to create multiple characteristics should be to create one by one.
I am using this demo. In its explanation document, a complete characteristic needs three handles. Use this demo. Once the Characteristic uses less than three handles, an error will be reported. I think you should give up some features of Characteristic, so fewer handles can work.


Android Basics: change-app-theme

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-change-app-theme?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-2-pathway-2%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-change-app-theme#8
In which task and step of the codelab can this issue be found?
The last step (9).
Describe the problem
That step of the codelab provided a broken link: https://github.com/material-components/material-components-android-examples/blob/develop/MaterialThemeBuilder/README.md. It also makes a reference to https://github.com/material-components/material-components-android-examples/tree/develop/MaterialThemeBuilder, which does not exist now.
Steps to reproduce?

Go to the codelab.
Go to step 9.
Try to follow the steps. At some point, you should see a GitHub 404.

Versions
N/A
Additional information
Include screenshots if they would be useful in clarifying the problem.

@DiddiLeija
Thank you for reaching out to us.
As there are 8 slides only, no step 9, so we appreciate if you could provide the screenshot or more details how to reproduce the issue.

Well, the codelab has 9 steps for me:

(Google translated the codelab to spanish).
On that step, there are some instructions:

It says that I have to go to https://github.com/material-components/material-components-android-examples, and open the MaterialThemeBuilder folder, which is not on the repo:

The "provided URL" gives a GitHub 404:

Then, it suggested to follow the instructions from MaterialThemeBuilder/README.md:

Hello, is there an update on this issue?

@DiddiLeija
Sorry for late reply.
The issue that you presented to us is extremely important, and I thank you for bringing it to our attention. Actions from the localization team will soon be taken to fix it.


Add env vars from ConfigMap per Namespace

From Slack: Have one CM per NS with all env vars defined. Mutate pods with per-NS CM to get those env vars.

Something like:
apiVersion: kyverno.io/v1
kind: ClusterPolicy
metadata:
  name: add-env-vars-from-cm
  annotations:
    policies.kyverno.io/title: Add Environment Variables from ConfigMap
    policies.kyverno.io/subject: Pod
    policies.kyverno.io/category: Other
    policies.kyverno.io/description: >-
      Instead of defining a common set of environment variables multiple
      times either in manifests or separate policies, Pods can reference
      entire collections stored in a ConfigMap. This policy mutates all
      initContainers (if present) and containers in a Pod with environment
      variables defined in a ConfigMap named `nsenvvars` that must exist
      in the destination Namespace.
spec:
  rules:
  - name: add-env-vars-from-cm
    match:
      resources:
        kinds:
        - Pod
    mutate:
      patchStrategicMerge:
        spec:
          initContainers:
            - (name): "*"
              envFrom:
              - configMapRef:
                  name: nsenvvars
          containers:
            - (name): "*"
              envFrom:
              - configMapRef:
                  name: nsenvvars


[hotfix][doc] Fix version settings when building PyFlink

What is the purpose of the change
Due to the problem in FLINK-15638, this pull request tries to fix the building errors by adding extra version settings.
Brief change log

Adds extra version settings for PyFlink build documentation.

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@hequn8128 Thanks for the PR. LGTM, merging...

@dianfu Thanks a lot for the review. Merging...


New PR to test SignCLA at 2019-07-09 11:49:13.752724623 -0700 PDT m=+4.734041773

Body of PR

unsigned-fail-staging: test succeeded


Refactor volunteer view

Use React?
Add better filtering, better page styling and responsiveness, easier way to edit and delete volunteers.

Done in levechad-frontend-vue


TST: added tests for utils.test_get_clean_factor_and_forward_returns

since we are refactoring  utils.test_get_clean_factor_and_forward_returns it is good to have non-regression tests before applying any change

@twiecki may I merge this or do you see any issue?

Looks great!


Added alamo colleges student domain

The alamo.edu domain is already in use for faculty, but we are now adding student.alamo.edu for students.

@madmike210 Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


reintroduce opus on VAD, change frame size according to firmware v1.0, change realtime resolution for transcribe

#518
The encoding in Friend firmware code v1.0 shows that it's using frame size of 160 (10ms). I have not tested on Friend cause I don't have the device.
Changing the real-time resolution to standard to 20ms, should theoretically reduce server load.
Thank you!

It still doesn't work, there's no transcript. Also there's this warning and I am not sure if it is something to be worried about?
backend/routers/transcribe.py:102: UserWarning: The given buffer is not writable, and PyTorch does not support non-writable tensors. This means you can write to the underlying (supposedly non-writable) buffer using the tensor. You may want to copy the buffer to protect its data or make it writable before converting it to a tensor. This type of warning will be suppressed for the rest of this program. (Triggered internally at /Users/runner/work/pytorch/pytorch/pytorch/torch/csrc/utils/tensor_new.cpp:1530.)
  samples = torch.frombuffer(decoded_opus, dtype=torch.int16).float() / 32768.0

That is the error that is related how I should handle the buffer in Opus, and I'll solve that soon. But is the "+Detected speech" or "-NO Detected" thingy printed in log? Thanks

Sounds like server get heavier.
Miss more transcribe & slower -> Incoming bytes take long time to process on VAD, increasing delay to DG.
Websockets more dc -> Ping/pong doesn't get though or processed on time, because high cpu usage on VAD
My solution :

Use onnx runtime for VAD
Decrease window for VAD, 4x lesser now

Any feedback or opinion is appreciated. Thanks!

Changes

More handling on socket2 data, which is always used when Opus (Friend mic, not phone) is involved. It target to solve socket disconnected err, while keeping the PCM still working.
Any feedback is welcomed, thank you :)

@josancamon19 @mdmohsin7 Already merged with main branch, giving better result on case of using speech profile. Please review, thanks!

https://share.icloud.com/photos/06dFrjm9Q_RrsvZO5VLScWGLg
Clearly doesn't work, for next review, please submit videos of it working through the app

@josancamon19 @mdmohsin7 Drive link: https://drive.google.com/drive/folders/1h1nbyLAaVt72Wwy-yO_5C8L5_re17ptI?usp=sharing Please review thanks!

I have added more testing, which now is for a lecture video (more convertation alike situation) in "test 1" folder. also provided the pcm transcribe from playstore app (no VAD) for the ground truth. The result is, the latency is indistinguishable, accuracy very improved. VAD opus usable

dude @josancamon19

Moving PR to https://github.com/BasedHardware/omi/pull/922


jQuery issue

Hi, I think there is a problem with jquery in this theme. It's being loaded twice from cdn and the bundle. If you deregister jquery in wordpress so the file doesn't load in the header, then jquery goes undefined even though you're importing from the bundle in index.js
This causes problems when trying to call functions from Bootstrap loaded from Webpack, functions work fine when called via data attributes, but same functions are undefined when called by js.
I discovered this when I was trying to call a modal with bs function $('#myModal').modal('show')

@forepointmc you can remove jQuery from package.json dependencies and only use the one which Wordpress includes automatically. I just learned that Webpack lets you define "externals" where you can define external jQuery and use that in your bundle.
What I did was

removed jQuery from package.json and re-installed node_modules
added externals: { jquery: 'jQuery' } to weback.config.js (check the link below)
imported jQuery in index.js: import $ from 'jquery';

Read the part about "Adding External jQuery or other Libraries" here. I followed his instructions.
https://www.ibenic.com/configuring-webpack-wordpress/
More info about Webpack's externals:
https://webpack.js.org/configuration/externals/


ASP.NET Tutorial

Problem encountered on https://dotnet.microsoft.com/learn/web/aspnet-hello-world-tutorial/run
Operating System: windows
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.

I browsed to http://localhost:5000 and ran in to a "this site can not be reached" error, where as myWebApp was created successfully inside the c: path. Is there something I did wrong here?

@Pilchie is this something you or your team can help with?

@Mosiuwa - can you provide more details about the steps you took?  Did you start running the app?  What output did it have?  Can you give some screenshots?

Closing due to no response - @Mosiuwa please give us some more information if you're still seeing problems here.


Private gateway can't be deleted

ISSUE TYPE

Bug Report

COMPONENT NAME

Management Node

CLOUDSTACK VERSION

4.11.1

CONFIGURATION

Advanced Network, KVM bridged

OS / ENVIRONMENT

CentOS 4.11.1

SUMMARY

Its possible to create VPC offering without services, then add VPC based on this offering, then add Private Gateway for this VPC, then add route for this Private Gateway.
During route creation error is displayed:

But route still being created. Then if I try to delete route - I can't, because of the same error.
So created route can't be deleted and as a result Private Gateway can't be deleted also and VPC can't be deleted too.

Can you test with <IP_ADDRESS>-rc3?

Issue still present - with identical messages as described above (simple workarroun - go to DB, and delete problematic route from cloud.static_route table) after which you can delete the Private Gateway.

Looking into this.


Add documentation and example with multiple canisters

Done in https://github.com/hadronous/pic-js/pull/18


Can't interpolate exception thrown when transition between colors is needed

Colors should be handled differently than the current way:
if(val1.length !== val2.length) {
as one may define transition like :
            data-1020="background-color: #372941"
            data-1500="background-color: white"

or
            data-1020="background-color: #372941"
            data-1500="background-color: #fff"

and not only lengths are different then, but also #ffffff is treated as :
["#ffffff"]
instead of
["#?", "ffffff"]

I just want to change background image.
data-611="background-image: url(images/allbg.png);"
data-612="background-image: url(images/bg2.jpg);
i tested 10 times(i mean scroll up and scroll down) and it is ok,but over 10 times it is not working.i can't scroll.


Devspace-build crashes

Today I started to have a problem with a pod being stuck at initializing when we tried to build it using VS 2019 and Dev Spaces.
After som digging I found that the devspace-build container throws a error and halts, leaving the build in limbo. VS was telling me that it was still building.
This is the error log from the devspace-build container:

"2019-09-05T07:16:26.7867482Z" : Download workspace(version=1.0.20190829.2)(clientRequestId=20c87aa0-4fa1-4ab1-be5d-de66978cae31)(correlationRequestId=1bec58f8-bf78-43fa-8c0b-bfe6b5ce3ca2)(ApplicationName=BuildService)(DeviceOperatingSystem=Linux 4.15.0-1052-azure #57-Ubuntu SMP Tue Jul 23 19:07:16 UTC 2019)(Framework=.NET Core 4.6.27817.01)
"2019-09-05T07:16:26.8569567Z" : Log Handler started(version=1.0.20190829.2)(clientRequestId=20c87aa0-4fa1-4ab1-be5d-de66978cae31)(correlationRequestId=1bec58f8-bf78-43fa-8c0b-bfe6b5ce3ca2)(ApplicationName=BuildService)(DeviceOperatingSystem=Linux 4.15.0-1052-azure #57-Ubuntu SMP Tue Jul 23 19:07:16 UTC 2019)(Framework=.NET Core 4.6.27817.01)
"2019-09-05T07:18:06.9804378Z" : WARNING: DownloadWorkspaceAsync failed with {"ClassName":"System.Threading.Tasks.TaskCanceledException","Message":"The operation was canceled.","Data":null,"InnerException":{"ClassName":"System.IO.IOException","Message":"The server returned an invalid or unrecognized response.","Data":null,"InnerException":null,"HelpURL":null,"StackTraceString":"   at System.Net.Http.HttpConnection.FillAsync()\n   at System.Net.Http.HttpConnection.ReadNextResponseHeaderLineAsync(Boolean foldedHeadersAllowed)\n   at System.Threading.Tasks.ValueTask1.get_Result()\n   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)","RemoteStackTraceString":null,"RemoteStackIndex":0,"ExceptionMethod":null,"HResult":-2146232800,"Source":"System.Net.Http","WatsonBuckets":null},"HelpURL":null,"StackTraceString":"   at Microsoft.Rest.RetryDelegatingHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)\n   at Microsoft.Azure.DevSpaces.Common.Auth.Handlers.AuthErrorHttpHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /app/common.auth/Handlers/AuthErrorHttpHandler.cs:line 47\n   at Microsoft.Azure.DevSpaces.Common.Auth.Handlers.ServiceClientCredentialsHttpHandler1.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /app/common.auth/Handlers/ServiceClientCredentialsHttpHandler.cs:line 34\n   at System.Net.Http.HttpClient.FinishSendAsyncUnbuffered(Task1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)\n   at Microsoft.Azure.DevSpaces.ExecService.Client.WorkspaceOperations.DownloadSourceWithHttpMessagesAsync(String spaceName, String serviceName, String name, Dictionary2 customHeaders, CancellationToken cancellationToken) in /app/execsvc.client.autogen/WorkspaceOperations.cs:line 161\n   at Microsoft.Azure.DevSpaces.ExecService.Client.WorkspaceOperationsExtensions.DownloadSourceAsync(IWorkspaceOperations operations, String spaceName, String serviceName, String name, CancellationToken cancellationToken) in /app/execsvc.client.autogen/WorkspaceOperationsExtensions.cs:line 49\n   at Microsoft.Azure.DevSpaces.Build.BuildClient.DownloadWorkspaceAsync() in /app/build/BuildClient.cs:line 113","RemoteStackTraceString":null,"RemoteStackIndex":0,"ExceptionMethod":null,"HResult":-2146233029,"Source":"Microsoft.Rest.ClientRuntime","WatsonBuckets":null}, retry.(version=1.0.20190829.2)(clientRequestId=20c87aa0-4fa1-4ab1-be5d-de66978cae31)(correlationRequestId=1bec58f8-bf78-43fa-8c0b-bfe6b5ce3ca2)(ApplicationName=BuildService)(DeviceOperatingSystem=Linux 4.15.0-1052-azure #57-Ubuntu SMP Tue Jul 23 19:07:16 UTC 2019)(Framework=.NET Core 4.6.27817.01)
"2019-09-05T07:19:47.5099688Z" : WARNING: DownloadWorkspaceAsync failed with {"ClassName":"System.Threading.Tasks.TaskCanceledException","Message":"The operation was canceled.","Data":null,"InnerException":{"ClassName":"System.IO.IOException","Message":"Unable to read data from the transport connection: Operation canceled.","Data":null,"InnerException":{"ClassName":"System.Net.Sockets.SocketException","Message":"Operation canceled","Data":null,"InnerException":null,"HelpURL":null,"StackTraceString":null,"RemoteStackTraceString":null,"RemoteStackIndex":0,"ExceptionMethod":null,"HResult":-2147467259,"Source":null,"WatsonBuckets":null,"NativeErrorCode":125},"HelpURL":null,"StackTraceString":"   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error)\n   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.GetResult(Int16 token)\n   at System.Net.Security.SslStreamInternal.g__InternalFillBufferAsync|38_0[TReadAdapter](TReadAdapter adap, ValueTask1 task, Int32 min, Int32 initial)\n   at System.Net.Security.SslStreamInternal.ReadAsyncInternal[TReadAdapter](TReadAdapter adapter, Memory1 buffer)\n   at System.Net.Http.HttpConnection.FillAsync()\n   at System.Net.Http.HttpConnection.ReadNextResponseHeaderLineAsync(Boolean foldedHeadersAllowed)\n   at System.Threading.Tasks.ValueTask1.get_Result()\n   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)","RemoteStackTraceString":null,"RemoteStackIndex":0,"ExceptionMethod":null,"HResult":-2146232800,"Source":"System.Net.Sockets","WatsonBuckets":null},"HelpURL":null,"StackTraceString":"   at Microsoft.Rest.RetryDelegatingHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)\n   at Microsoft.Azure.DevSpaces.Common.Auth.Handlers.AuthErrorHttpHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /app/common.auth/Handlers/AuthErrorHttpHandler.cs:line 47\n   at Microsoft.Azure.DevSpaces.Common.Auth.Handlers.ServiceClientCredentialsHttpHandler1.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /app/common.auth/Handlers/ServiceClientCredentialsHttpHandler.cs:line 34\n   at System.Net.Http.HttpClient.FinishSendAsyncUnbuffered(Task1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)\n   at Microsoft.Azure.DevSpaces.ExecService.Client.WorkspaceOperations.DownloadSourceWithHttpMessagesAsync(String spaceName, String serviceName, String name, Dictionary2 customHeaders, CancellationToken cancellationToken) in /app/execsvc.client.autogen/WorkspaceOperations.cs:line 161\n   at Microsoft.Azure.DevSpaces.ExecService.Client.WorkspaceOperationsExtensions.DownloadSourceAsync(IWorkspaceOperations operations, String spaceName, String serviceName, String name, CancellationToken cancellationToken) in /app/execsvc.client.autogen/WorkspaceOperationsExtensions.cs:line 49\n   at Microsoft.Azure.DevSpaces.Build.BuildClient.DownloadWorkspaceAsync() in /app/build/BuildClient.cs:line 113","RemoteStackTraceString":null,"RemoteStackIndex":0,"ExceptionMethod":null,"HResult":-2146233029,"Source":"Microsoft.Rest.ClientRuntime","WatsonBuckets":null}, retry.(version=1.0.20190829.2)(clientRequestId=20c87aa0-4fa1-4ab1-be5d-de66978cae31)(correlationRequestId=1bec58f8-bf78-43fa-8c0b-bfe6b5ce3ca2)(ApplicationName=BuildService)(DeviceOperatingSystem=Linux 4.15.0-1052-azure #57-Ubuntu SMP Tue Jul 23 19:07:16 UTC 2019)(Framework=.NET Core 4.6.27817.01)
"2019-09-05T07:21:28.0317373Z" : WARNING: DownloadWorkspaceAsync failed with {"ClassName":"System.Threading.Tasks.TaskCanceledException","Message":"The operation was canceled.","Data":null,"InnerException":{"ClassName":"System.IO.IOException","Message":"The server returned an invalid or unrecognized response.","Data":null,"InnerException":null,"HelpURL":null,"StackTraceString":"   at System.Net.Http.HttpConnection.FillAsync()\n   at System.Net.Http.HttpConnection.ReadNextResponseHeaderLineAsync(Boolean foldedHeadersAllowed)\n   at System.Threading.Tasks.ValueTask1.get_Result()\n   at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)","RemoteStackTraceString":null,"RemoteStackIndex":0,"ExceptionMethod":null,"HResult":-2146232800,"Source":"System.Net.Http","WatsonBuckets":null},"HelpURL":null,"StackTraceString":"   at Microsoft.Rest.RetryDelegatingHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)\n   at Microsoft.Azure.DevSpaces.Common.Auth.Handlers.AuthErrorHttpHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /app/common.auth/Handlers/AuthErrorHttpHandler.cs:line 47\n   at Microsoft.Azure.DevSpaces.Common.Auth.Handlers.ServiceClientCredentialsHttpHandler1.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /app/common.auth/Handlers/ServiceClientCredentialsHttpHandler.cs:line 34\n   at System.Net.Http.HttpClient.FinishSendAsyncUnbuffered(Task1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)\n   at Microsoft.Azure.DevSpaces.ExecService.Client.WorkspaceOperations.DownloadSourceWithHttpMessagesAsync(String spaceName, String serviceName, String name, Dictionary2 customHeaders, CancellationToken cancellationToken) in /app/execsvc.client.autogen/WorkspaceOperations.cs:line 161\n   at Microsoft.Azure.DevSpaces.ExecService.Client.WorkspaceOperationsExtensions.DownloadSourceAsync(IWorkspaceOperations operations, String spaceName, String serviceName, String name, CancellationToken cancellationToken) in /app/execsvc.client.autogen/WorkspaceOperationsExtensions.cs:line 49\n   at Microsoft.Azure.DevSpaces.Build.BuildClient.DownloadWorkspaceAsync() in /app/build/BuildClient.cs:line 113","RemoteStackTraceString":null,"RemoteStackIndex":0,"ExceptionMethod":null,"HResult":-2146233029,"Source":"Microsoft.Rest.ClientRuntime","WatsonBuckets":null}, retry.(version=1.0.20190829.2)(clientRequestId=20c87aa0-4fa1-4ab1-be5d-de66978cae31)(correlationRequestId=1bec58f8-bf78-43fa-8c0b-bfe6b5ce3ca2)(ApplicationName=BuildService)(DeviceOperatingSystem=Linux 4.15.0-1052-azure #57-Ubuntu SMP Tue Jul 23 19:07:16 UTC 2019)(Framework=.NET Core 4.6.27817.01)

It would be nice if a error occures in the build container, it bubbles up to the VS gui and cancels the debuging session if possible.
Any idea on how I can get around this problem ?

I think this can be reproduced by doing this:

Create a service in VS 2019
Select to run it in AKS Dev Space
Start debugging so it gets deployed
Open AKS Dashboard (AKS Browse)
Remove the deployment (but not the service)
Deploy again from VS 2019

Thanks for reporting @Eneuman .  We're investigating the issue and we'll let you know what we find.

Thanks. It's a blocking issue for us atm so please let me know if I can be of any assistans in trouble shooting this.

Hi Per,
I am not able to reproduce this bug using a simple dotnet web application. Can you confirm if this reproduces for you consistently? Also I am re-iterating the steps you mentioned, just to make sure I understood correctly :

Create a dotnet web application in VS 2019
Select to run it in AKS Dev Space
Start debugging (and optionally stop it)
Open AKS dashboard
Delete only the deployment
Start debugging again from VS 2019.

This should now be fixed in all regions.


macOS Catalina: nvm is not compatible with the npm config "prefix" option

Operating system and version:
macOS Catalina 10.15
nvm debug output:

nvm --version: v0.35.3
$TERM_PROGRAM: Apple_Terminal
$SHELL: /bin/zsh
$SHLVL: 1
${HOME}: /users/16oh4
${NVM_DIR}: '${HOME}/.nvm'
${PATH}: /usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
$PREFIX: ''
${NPM_CONFIG_PREFIX}: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'zsh 5.7.1 (x86_64-apple-darwin19.0)'

nvm ls output:

        v12.7.0
node -> stable (-> v12.7.0) (default)
stable -> 12.7 (-> v12.7.0) (default)
iojs -> N/A (default)
unstable -> N/A (default)
lts/* -> lts/erbium (-> N/A)
lts/argon -> v4.9.1 (-> N/A)
lts/boron -> v6.17.1 (-> N/A)
lts/carbon -> v8.17.0 (-> N/A)
lts/dubnium -> v10.21.0 (-> N/A)
lts/erbium -> v12.18.2 (-> N/A)

How did you install nvm?

Install script
What steps did you perform?
Installed NVM, and then ran
% nvm install 12.7.0

What happened?
When I start a new shell I get
nvm is not compatible with the npm config "prefix" option: currently set to "/Users/16oh4/.nvm/versions/node/v12.7.0"
Run `nvm use --delete-prefix v12.7.0` to unset it.

What did you expect to happen?
I want node and npm to be in my shell without having to call
nvm use --delete-prefix v12.7.0

Is there anything in any of your profile files that modifies the PATH?

No. I am using zshell on MacOs Catalina 10.15

If you are having installation issues, or getting "N/A", what does curl -I --compressed -v https://nodejs.org/dist/ print out?

Is your $HOME dir a symlink or a network mount, perhaps?

@ljharb How do I check if its a symlink? I don't think so. It's a new mac

If you didn't do anything special when setting up your new Mac, it definitely wouldn't be a symlink.
I assume you also didn't install node another way, just via nvm?

@ljharb That's correct. I don't have a system wide node install, just nvm. I have tried removing .nvm as well as the export variable in my .zshrc to reinstall with the curl command, but still same issue.

@ljharb I tried the manual install as well. Same issue

If you manually source nvm.sh on the command line, does nvm work in that shell session?

Nvm does work, but it doesn't bind node and npm until I run:
nvm use --delete-prefix v12.7.0 --silent

Here is what I originally ran:
% source PATH_TO_NVM.SH

and got:
nvm is not compatible with the npm config "prefix" option: currently set to "/Users/16oh4/.nvm/versions/node/v12.7.0"
Run `nvm use --delete-prefix v12.7.0 --silent` to unset it.

Do you have .npmrc (not .nvmrc) file in the repo with an env variable? I encountered the same error because of having the authtoken loaded from env in .npmrc file

aha!
@16oh4 your home dir is inside /Users, but $HOME incorrectly starts with /users. If you fix your HOME capitalization, is it fixed?

aha!
@16oh4 your home dir is inside /Users, but $HOME incorrectly starts with /users. If you fix your HOME capitalization, is it fixed?

@ljharb That fixed it! Isn't $HOME a shell var injected by the system? How could it point to an incorrect case of the path?
@su-docker I don't but thanks for the suggestion!

I'm not sure where it comes from - on every new Mac I've used, $HOME and pwd both start with /Users.

@ljharb  Thanks for everything! I think you can close this now.
For what it's worth, and for anyone on the internet with the same problem, here is how I switched lowercase /users/ into /Users/ and stored in a shell variable
echo $HOME >> temp_file
UPPER_HOME=`sed 's/\/users/\/Users/' temp_file`


Ability to assign multiple roles to a user

Is your feature request related to a problem? Please describe.
It would be nice to be able to assign multiple roles to a user.
For example role 1 has x permissions, and role 2 has y permissions.
It would be nice to not have to create a third role with x and y permissions to cover both roles.

I would not describe this as an issue but as a feature request. If you want to add this feature to this API you're more than welcome but for now, I'm closing this issue @xXBlackHawkXx .


Play Developer Reporting API - slowstartuprate, slowrenderingrate, errors missing

Environment details

OS type and version: MacOS 13.2.1
Python version: Python 3.10.8
pip version: pip 23.0.1
google-api-python-client version: 2.81.0

Steps to reproduce

Build the Google Play Developer Reporting resource
Try to get a handle to the slowstartuprate() service

Code example
    credentials = service_account.Credentials.from_service_account_file(credentials_path)
    service = build('playdeveloperreporting', 'v1beta1', credentials=credentials)
    vitals_service = service.vitals()
    slowstartservice = vitals_service.slowstartuprate() # <-- This fails, see error below. Also tried vitals_service.slowstartrate(), same error.

Stack trace
AttributeError: 'Resource' object has no attribute 'slowstartuprate'

Additional Info

Inspecting the dynamic attributes of the vitals_service object (pprint(vars(vitals_service)) in the code sample above reveals only 4 resources: crashrate, anrrate, excessivewakeuprate, stuckbackgroundwakelockrate.  The errors, slowrenderingrate & slowstartuprate mentioned in the api docs are missing and its not possible to query them. This may indicate that the resources are no longer available in the API or that I am missing something.

I can successfully query metrics from the crashrate, anrrate, excessivewakeuprate, stuckbackgroundwakelockrate metric-sets/resources. This could mean that my setup/environment may not be the cause of this error.
The link to the slowstartuprate api resource is broken on the "Intro to Metrics Set" documentation here.
The API reference here refers to the resource as slowstartrate instead of slowstartuprate. This may indicate a renaming issue may have caused a break?

Any assistance with this issue would be greatly appreciated. Thank you!
PS: Apologies if i've used the words resource or service incorrectly in the report above. Hope the larger issue at hand is clear and understandable. Please feel free to ask for clarifications, if needed.

Update: turns out i am using an older version of the python lib (2.81.0) but a newer version is available (2.86.0) which works as i expect it to (per the api documentation).
However, it may be worth looking at the broken link  for slowstartuprate api resource in the "Intro to Metrics Set" documentation here.


Introduce 'canonical' and clarify 'resource'

[Please review before 1.0]
Resolves: #379
Currently, the resource member in link objects may be tied either to the relationship or to the identity of the target resource(s). This ambiguity sets the stage for all kinds of elusive bugs and race conditions. It would be prudent to resolve this conclusively before 1.0.
This PR addresses the issue in the following way:

The role of resource is clarified by limiting it to "relationshippy" URLs only.
A new member named "canonical" is allowed in link objects to hold a canonical URL.

An alternative naming scheme for resource and canonical would be href-related / href-canonical, which is more descriptive but involves changing the established key resource.
Additionally, a Note is added that points out the following, which otherwise may not be obvious:

a related resource URL cannot be replaced with null to indicate "empty" (#386)
an empty relationship can be signaled by including id: null or id: [] (#386, #399).

While adding canonical to the example payloads, I realized that it's totally unnecessary to have a dedicated example just to illustrate the changing of
"comments": {
  "resource": "http://example.com/articles/1/comments"
}

to
"comments": "http://example.com/articles/1/comments"

so I removed it. Let me know if you'd like to have it back.

Currently, the resource member in link objects may be tied either to the relationship or to the identity of the target resource(s).

I disagree here. The spec is pretty clear that "A related resource URL SHOULD remain constant even when the relationship it represents mutates."
I do see that the addition of a field such as canonical further reinforces the purpose of resource. However, I don't see the addition of canonical as a blocker for 1.0, since it's entirely additive.

I will mark this for 1.0 because we should be absolutely certain of the name resource, to ensure that canonical (or whatever is decided) is a nice complement.

@dgeb That SHOULD is a problem. Change it to MUST and the biggest issue goes away. Then canonical can become an additive change down the road.
But as @ethanresnick speculated in #379:

I have a feeling that that SHOULD was put in the spec carefully, given that nearly everything else has been converted to a MUST. (Perhaps it's a SHOULD to save servers the requirement of having to support non-canonical urls at all.)
So, if that SHOULD isn't going to change, then I'm on board with your two-key solution, which would certainly allow us to specify a MUST for each key individually.

@bintoro fair enough - we SHOULD examine that wording carefully before 1.0 :+1:

I brefily mentioned to @dgeb that I would rather re-use the existing canonical link relation rather than introducing canonical into this spec. It would mean just allowing any link relation to be the key.

It occurred to me that the spec actually defines resource URL as the canonical URL for singular resources.
Therefore, placing the related resource URL in a member named resource is perhaps not an ideal arrangement, regardless of what happens with canonical.

Re the naming question....
In REST terms, we have two resources here:

/articles/1/comments, which represents the contents of the comments link
/comments/12,13,14, which represents comments 12, 13, and 14

Now, the entities picked out by the first resource might happen, at some points in time, to be the same as the entities picked out by the second resource. But "canonical" really doesn't apply here; we have two different conceptual resources, not two IRIs for the same resource, one of which we want to designate as the canonical IRI.
Moreover, for someone who doesn't quite understand the resource picture described above, but only has a mental model in which the "canonical" url is the permanent one, I can imagine them thinking that "canonical" means the exact opposite of the meaning being proposed. (I.e. they'd expect that the unchanging url in the "resource" key should be the one in the "canonical" key, and vice-versa.)
So, if we want a second key, I'd probably call it "current", to say that "this url represents the value of the link".
But, honestly, for 1.0, I think it'd be fine to just change the SHOULD to a MUST for the resource key. Supporting "resource"-style urls isn't that onerous on servers. Then, we can add a second key later.

@ethanresnick I'm confused by your comment.
The related resource URL (the resource member) is defined like this: "[...] the response from a related resource URL always reflects the current state of the relationship".
Isn't that pretty much the definition of "current" and opposite of "canonical"? :smile:
Or is the concern that people don't know what "canonical" means? I think the Resource URL (where self is defined) is the right place to highlight this and clearly point out that individual resources have identities.
This PR defines the proposed canonical member like this:

A canonical URL MUST be permanently tied to the identity of the target resources. That is, a previously retrieved canonical URL continues to point to the same resources even if the original relationship mutates.

Given @ethanresnick's observation that the term canonical is not a perfect fit conceptually (since the various URLs do not expose permanently duplicate content), I present two naming plans that do not involve "canonical":
One:

"static" for the permalink
"href", "current", "related", or maybe "resource" for the related resource URL

Two:

"resource" for the permalink
"href", "current", or "related" for the related resource URL

@bintoro I think I understand the confusion. I was proposing "current" for what you're calling the permalink because I read it as "This is the url that (always) returns the specific entities that are linked currently (i.e. at the time that the containing payload was downloaded)". Your reading, which also makes sense, has it mean "This is the url that always returns the current entities that the relationship is about." Because of this double reading, which also applies to "static", I think we should avoid those terms.

Because of this double reading, which also applies to "static", I think we should avoid those terms.

Or, you know, we could just assume that implementors read the spec :smirk:
Realistically, there's no set of keys that would be completely self-explanatory.
I do see your point about "current" and how someone might get the wrong idea. But for "static", it's a stretch... Even with conscious effort, I have a hard time associating the word "static" with a mutable set of resources.
I'm also strongly opposed to using a word like "current" or "now" in the permalink meaning because, although I concede both readings are possible, the related resource interpretation feels way way way more natural to me, and I'm sure I'm not the only one. So let's just forget about "current".
In the initial comment I suggested "href-related", and I still think it's quite reasonable, given that the term is related resource URL. I would be happy with static / related. The term for what is now canonical would become static resource URL.

I would welcome a separate PR that changes the current resource to related and changes the associated SHOULD to a MUST. This URL can continue to be called the related resource URL.
This was a less clear path when linked was at the top-level (instead of included), but there is no longer the possibility for confusion between related and linked.
I believe that this change is worth making, and not just bike-shedding, because it removes the word "resource" from the structure of a JSON API document. This frees us to change this term in the future, if necessary, to disambiguate JSON API resources from HTTP resources.
I am less clear on the need for a "static resource URL". The spec no longer supports the concept of links to multiple individual resources, and the former comma-delimited-ID approach was not appropriate for long lists. A different "recommendation" would be needed for forming these URLs. Let's discuss that in a new issue (not PR) to be addressed post-1.0.
@bintoro please let me know if you agree with the above proposal and whether you'd be willing to narrow this PR in scope. Thanks.

@steveklabnik my concern about allowing any link relation is that it means that the keys we reserve for 1.0 (self, related, first, last, prev, next) are the only ones we'll ever be able to reserve and narrowly define.
Maybe the answer is to reserve a prefix for custom keys? We're already reserving keys that begin with non-alphanumeric characters for custom usage. Do we want another reserved prefix in links, such as href-?
Or perhaps I misunderstood your suggestion?

please let me know if you agree with the above proposal and whether you'd be willing to narrow this PR in scope.

@bintoro of course, feel  free to open a new PR instead. And if you don't have time, I'll be glad to make this change.

@dgeb Sounds perfect. How do you feel about the slightly amended wording in the definition of related resource URL, as per this PR? And the Note about representing empty relationships?

@bintoro I've commented on the sections I'd like to keep for this PR. Let's deal with other issues separately.

@dgeb's proposal sounds good to me too!

The second is covered in the fetching relationships section

@dgeb Just to clarify, the intent of the note was to point out that an empty relationship can be indicated in the link object, too, saving the client a request to the relationship URL when there's nothing there.
The Fetching Relationships section doesn't seem to address this at all; it only deals with responses from a relationship URL.

Just to clarify, the intent of the note was to point out that an empty relationship can be indicated in the link object, too, saving the client a request to the relationship URL when there's nothing there.

Thanks for the clarification. I didn't get that on first reading.

Closing in favor of #433

that the keys we reserve for 1.0 (self, related, first, last, prev, next) are the only ones we'll ever be able to reserve and narrowly define.

of those, only related is not already a standard relation, and we're using them in compliance with the standard relations.


Fix furyagent version command and bump version.

This PR fixes #10

The same error happened in the printDefault command, which does not make sense. The printDefault command was unimplemented so, it's better to remove it (this is why i have pushed this change)

Can't we just move the -config flag only in the subcommands where it makes sens to have it? Or is the PersistentPreRun the standard way to address this kind of issues?

Can't we just move the -config flag only in the subcommands where it makes sens to have it? Or is the PersistentPreRun the standard way to address this kind of issues?

The problem is not the flag, but the configuration file loading.
That was my intention at first but 99% of commands require the config loaded. version and help (that's "built-in") are the only ones that don't. In my opinion we can leave it like this, at least for the time being to solve this issue, a further global re-write is needed.

I agree, it was more a curiosity of mine than a real issue. 😅

@ralgozino can we handle the version package in furyagent in the same way as we do for furyctl? This way, we don't have to remember to manually bump the version when we release a new one.
Refs:

https://github.com/sighupio/furyctl/commit/62316ecb8c26287fd33b64fcb2968a9f4956e550
https://github.com/sighupio/furyctl/commit/6626c40264031055358efc13c48eebfe2098b190

Yep! I agree, we should totally use the same approach that we are using for furyctl

Yep! I agree, we should totally use the same approach that we are using for furyctl
EDIT: I've just pushed the changes to use ldflags for the version just like in furyctl. Please @angelbarrera92 take a look into it :)

The ldflags looks good to me! Same for the rest of the PR! Awesome work!


Donglines

$ ./spark 1 0 20 10 10
8======D
8=D
8======================================================================================================================================D
8===================================================================D
8===================================================================D

Given enough popularity of a project, everything eventually turns to dicks. A+ for effort, though!
B==:fist:==D :sweat_drops:

Shouldn't it end with at least one ~?

Reason #6735 why female programmers aren't more common.


Debugger throwing error

Sort of similar to issue #25.  Whenever I run something with readline-sync with the --debug flag, a script that runs fine without it gives this error:
src\debug-agent.cc:149: Assertion(err) == (0)' failed.`
This is under node 6.10.1, npm 3.10.10.  It does this on my home computer (Windows 10) and work as well (Windows 7):  Simplest steps to reproduce:
create a file main.js containing this line:
var rl = require('readline-sync');
run with node main.js should be no errors.
run with node --debug main.js and results in the above mentioned error.
UPDATE:  Verified too that this happens in Linux as well under node 7.7, same error.

Hi @shaycraft, thank you for the comment.
So, is that message an error that means that your script was aborted?
I tried a script with --debug, and it worked fine with that message.
(The layout is broken in your debug agent because readlineSync uses TTY.)

The script does not abort and does run correctly with the --debug option, but I cannot debug which is the issue.  I suppose what you are saying about TTY makes sense, wonder if there is a way around this.

Do you mean that your debugger such as node inspector doesn't work?

Right, in this case I'm using VS Code.  It times out and says it's unresponsive, which I assume is because of the tty.

I see.
Since readlineSync is a module to read/write TTY, of course it doesn't work in environment that has no TTY.
I.e. that is a correct behavior.
You have to emulate input via TTY if you want to run it for debugging without TTY. For example, you can use stubs and mocks via library such as Sinon.JS for unit testing.

Cool I'll look into it.  I'll close this issue then.

😄


Module 'frontera.contrib.backends.memory' doesn't define any object named 'FIFO'

Frist time to use frontera, after install frontera and option in https://frontera.readthedocs.io/en/latest/topics/installation.html#options
then run the example under requests/link_followers.py.
But it come with error :
raise NameError("Module '%s' doesn't define any object named '%s'" % (module, name))

NameError: Module 'frontera.contrib.backends.memory' doesn't define any object named 'FIFO'
how to fix it or i am missing something ?

my best guest is the example was already outdated, https://github.com/scrapinghub/frontera/commit/1f1f4a14d02509091e308c422efc33f29f9e9bae
I think u should directly go to single mode for trying or testing.

thx @liho00
So link_followers.py is not the single mode ?
This link https://frontera.readthedocs.io/en/latest/topics/quick-start-single.html
is the real single mode with scrapy ?
Do you have the latest demo code ?

thx @liho00
So link_followers.py is not the single mode ?
This link https://frontera.readthedocs.io/en/latest/topics/quick-start-single.html
is the real single mode with scrapy ?
Do you have the latest demo code ?

nope, it just an example.
you just follow the documentation will do. I have tried distributed mode, i have never try single mode before.


[Bug] : footer section overlapping with body section

Description
The footer section of the website is overlapped with the body section of the website
Expected behaviour
The footer section does't not overlapp with the body section
#screenshot

@Tejas242  Please assign this issue to me


ShareData: Parameter description missing

There's some vital information missing for our security office:
-ShareData
{{ Fill ShareData Description }}
Could you add the description please?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed4847c2-e98f-00db-fe2c-aa0382b95a66
Version Independent ID: dbea5fd4-8b55-dd74-dec9-62402d35aaf8
Content: Set-CsOnlineVoicemailPolicy (SkypeForBusiness)
Content Source: skype/skype-ps/skype/Set-CsOnlineVoicemailPolicy.md
Service: skypeforbusiness-powershell
GitHub Login: @tomkau
Microsoft Alias: tomkau

Duplicate of https://github.com/MicrosoftDocs/office-docs-powershell/issues/6343

Closing here, will be addressed in #6343


component rendering as undefined

Hi, I am tinkering with preact (+preactement) using 11ty and netlify using this template and have come across an issue that has me a little stumped.
I have two components testLogin (test-login) and showData (show-data) and both are registered in the home.entry.ts
However when I try to render them test-login shows properly but show-data does not and instead shows undefined.

I have probably done something stupid but as a loss as to what.

Hey @sawilde,
Would you be able to share a reproduction with me, so I can take a closer look?
Getting undefined as a tag identifier is usually an indication of a malformed component tree, so this may well be a bug with the underlying package, preactement. Alternatively, it could be an issue with how the component is structured.
If you could share a repo that reproduces the issue, I can say for sure.
Thanks! 👍

Okay, I'll look to reproduce it. I may need to remove the graphql stuff so it will run locally for you.
Can you explain what you mean by malformed component tree, perhaps I can look out for it.

@sawilde Great, it doesn't have to be your project itself, just a quick setup that demonstrates the issue 👍

Can you explain what you mean by malformed component tree

Yeh, so JSX transpiles down to a hierachy of function calls, specifically h(), in the case of Preact (createElement for React). For us to get undefined as a tag, the first argument would have to be undefined.
A very contrived example of this, would be the following:
const MyComponent = undefined;

/*[...]*/

function Test() {
  return (

      <MyComponent />

  );
}

Which is transpiled from JSX into this:
function Test() {
  return (
    h('div', {}, [
      h(MyComponent, {} [])
    )
  );
}

And our final output would be the following, given MyComponent is undefined:

<undefined></undefined>

It would be worth checking whether or not your component tree has the potential for the something similar to the above happening, e.g: conditional components or components assigned to variables that might be undefined.

So I think I have reproduced it in this repository - I hope it repeats on your machine

excuse the roughness but it is just a test project where I've been trying out different things such as RTL, Chakra and Apollo GraphQL as well as netlify functions.

https://github.com/sawilde/test-11ty-preact
yarn install
yarn start

once running use the following in another console to start the local netlify functions
yarn start-dev

and it should then be running on localhost:8888
I initially thought it might have been the <ApolloProvider /> causing issues as I had some issues at one point and so left the server in place but after removing it the component was still not rendering properly :(
Now, I have noticed something, if in testLogin.component.tsx I change the line
import { ShowData } from '@/modules/home/components/showData';

to
import { ShowData } from<EMAIL_ADDRESS>
it starts to work but only for a dev build, in a production build it starts to fail again.

Hey @sawilde,
Thanks for taking the time to put that together. So a quick look at how you've structured the hydrated components shows the issue here.
You only want to make use of define() where a parent component requires hydration. I can see from your repo that you're not only defining the parent component as a Custom Element, but also one of it's children.
By removing the use of preactement from the ShowData component, it will correctly render and also be hydrated, thanks to it's parent component.
To give more context, preactement works in a two step process..

If run on the server, it returns a component instance that can be included within your page hierachy
If run on the browser (which is where the issue comes in), it returns void (undefined), but begins the Custom Element registration for us to hydrate.

You can see this here:
https://github.com/jahilldev/component-elements/blob/main/packages/preactement/src/define.ts#L34
I was just thinking of how we might mitigate this, but I don't think it makes much sense. We'd also need to resolve the component, and given it could be async, this would break how Preact (+React) handle the render process.
To sum up, only apply hydration, or make use of preactement on the uppermost parent that contains interactivity. So in this case, only call define() on TestLogin.
I hope that clarifies things / helps! 👍

that hit the mark - I did get bashed with a weird scenario with the order of the ChakraProvider and ApolloProvider which seems to be order agnostic in dev builds but really wants to be
<ChakraProvider>
  <ApolloProvider ...>
    {children}
  </ApolloProvider>
</ChakraProvider>

but I'll stick with what appears to be working - thanks again for your help

Great! 👍
No worries, happy to help.


When cloning an SSH repo, Elegit still asks for HTTP authentication

At least, it happened when I tried to clone a public one.

And, when I tried to cancel the HTTP, apparently the clone still happened.

So make sure to fix it.

Seriously. (I'm testing my broken email filters)

So I should fix this.


Can't get moonraker reporter working.

Hi,
Am I doing something wrong? mocha seems not able to reference 'moonraker' reporter.
project root: D:\tmp\moonraker\config.json
Errors:
D:\tmp\moonraker\node_modules\mocha\lib\mocha.js:149
if (!_reporter) throw new Error('invalid reporter "' + reporter + '"');
^
Error: invalid reporter "../../../lib/reporter"
at Mocha.reporter (D:\tmp\moonraker\node_modules\mocha\lib\mocha.js:149:27)

Hi @gogocat
I've been unable to reproduce this issue, and the response is coming back from within Mocha.
I've got a couple of suggestions for you to try, and it would be good if you can feedback?

Can you check that your config.json has the following line:

` "reporter": "moonraker",'
If not please update.

Delete the node_modules from your moonraker folder, and reinstall with npm.

If you are still having issues, can you paste your config.json file into here? Removing any parts which are sensitive.
Thanks
Paul

Hi Paul,
Thanks for your help, this is config i use.
{
"baseUrl": "http://www.gumtree.com.au/",
"featuresDir": "tests/features",
"stepsDir": "tests/steps",
"resultsDir": "results",
"threads": 1,
"testTimeout": 60000,
"elementTimeout": 5000,
"tags": "!@wip",
"browser": {
"browserName": "chrome",
"chromeOptions": {
"args": ["--no-sandbox"]
}
}
}
Looks like mocha couldn't find the reporter location?
I using Windows and my directory looks like this:
D:/tmp/moonraker
|----node_modules
|----results
|----tests
|----config.json
|----package.son
Adam

I got it working by modifying \node_modules\moonraker\lib\env\mocha.js
using path.resolve to let it workout current directory and cross platform issue.
...
var moonrakerReporter = path.resolve(__dirname, '../reporter');
var reporter = (config.reporter === 'moonraker') ? moonrakerReporter : config.reporter;
...

Nice to hear you got it working, but it's very strange how you needed to modify code within a thirdparty npm module to get it running.
I think the root cause is within your config and project structure, but not been able to narrow it down yet. Will keep you updated.

This should be fixed in 0.4.0


Avoid full-page refresh on save

The entire page flashes after saving a document. Is it possible to avoid the flash/refresh?

Hi @jylin, thanks for letting us know about this issue. I can only reproduce a full-page refresh when changing the key of an entry, which is used to populate the URL. We [re]fetch data based on that URL param so I'm not sure if much can be done in that situation.
If you're seeing this behaviour in another situation could you please provide more information? A screen recording is a quick and easy way to capture a bunch of info.

I'm experiencing this issue when using Astro. Every time you save a document, the Keystatic page refreshes.

I think "full page refresh" may have been a red herring. #1064 should resolve the issue.

From last looking into this, it seems to be because Astro reloads the page when the content collection data changes, it may be difficult to prevent Astro from doing that


[Bug] Unable to connect to Grafana. After deleting grafana object and re-creating deployment it began to work.

Describe the bug
After deploying Grafana on OCP 4.12 I am unable to connect to it.
smart-gateway-operator-78df54477b-j9mss                   1/1     Running   0              3d5h
[quicklab@upi-0 ~]$ oc logs grafana-deployment-84fdd4d55-tvdg2
Defaulted container "grafana" out of: grafana, oauth-proxy, grafana-plugins-init (init)
t=2023-05-07T14:12:26+0000 lvl=eror msg="Dashboard not found" logger=context userId=1 orgId=1 uname=admin error="Dashboard not found" remote_addr=<IP_ADDRESS>
t=2023-05-07T14:12:26+0000 lvl=eror msg="Dashboard not found" logger=context userId=1 orgId=1 uname=admin error="Dashboard not found" remote_addr=<IP_ADDRESS>
t=2023-05-07T14:12:26+0000 lvl=eror msg="Dashboard not found" logger=context userId=1 orgId=1 uname=admin error="Dashboard not found" remote_addr=<IP_ADDRESS>
t=2023-05-07T14:12:26+0000 lvl=eror msg="Dashboard not found" logger=context userId=1 orgId=1 uname=admin error="Dashboard not found" remote_addr=<IP_ADDRESS>
Version
v8.1.5 (c725a4259a)
To Reproduce
Steps to reproduce the behavior:
Deploy OCP 4.12
Deploy Grafana operator and Grafana deployment
oc get csv
grafana-operator.v4.9.0                       Grafana Operator                              4.9.0            grafana-operator.v4.8.0                       Succeeded
Check that pods are up and running
grafana-deployment-84fdd4d55-tvdg2                        2/2     Running   0              3d5h
grafana-operator-controller-manager-b5795f7d4-rmkkz       2/2     Running   0              3d5h
interconnect-operator-596cd7dcf5-cllvd                    1/1     Running   0              3d5h
expose grafana route and try to connect to Grafana.
Try to connect to Grafana via https
When trying to hit the grafana route with the browser we get the default message "Application not available".
Delete Grafana object
oc delete grafana default
It will delete Grafana-deployment pod and recreate it.
After that the connection to Grafana suceeded.
Expected behavior
Successfully connected to grafana via https
Add any other context about the problem here.
Seems like a some kind of race condition

@lnatapov can you provide all the yaml needed, that is as simple as possible where you can reproduce the error.
Also, can you share the grafana-operator logs?


Ability to specify a pacer with a specific pace

Advised by Bill Schatzow.
The question is how we'd distinguish the pacer from the chased and the behind dots.

Released with beta build 101


tet

test

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @yfxu1990. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Is this coming from the correct branch? There are tons of unrelated commits being merged in.

/hold

This looks like a test PR. I'm going to close this for now. If this is needed, please re-open and add a more detailed description of purpose to the PR.


Improve messages when compiling for Linux/*BSD

Don't display messages when enabling PulseAudio/ALSA/D-Bus/udev as these become noisy in incremental builds.
Improve warning and error messages to be more descriptive and consistent.

Thanks!

Cherry-picked for 3.4.


Improve label focus animation

Hey,
I saw the label animation on the input components had a jumpy animation and I thought maybe there is room to improve it.
Here is my attempt, let me know what you think 😄
Before:

After:

I also increased the transition duration by 50ms so the eye can notice the animation happening, since it was too fast.

Cool. Thanks for sharing! I’ll review this tomorrow when I’m back at my desk :)

Cool. Thanks for sharing! I’ll review this tomorrow when I’m back at my desk :)

No worries, hopefully it can be useful 😊
I may also have some other UI suggestions for other components, do you mind such PRs ? Or you would rather not touch the look and feel of Varnish ? I'm asking this because these stuff are pretty much all personal preferences and design choices and I don't want to invade that space.

Oh absolutely. Feel free to make any suggestions that you have.
I can’t guarantee I will approve them all, but some will hopefully make it in :)

I've actually decided to remove the animation altogether. Couldn't get it to be 100% smooth.
Thanks for trying though!


Registry lock not released after a garbage collection job error

Hi,
I've faced an issue following a garbage collection job error.
Error
The images weren't cached anymore.
The error was: Failed to cache image {IMAGE_NAME} unexpected status code 405 Method Not Allowed: Method not allowed
Cause
The garbage collection job lock the registry (read only) at the end of its process (kubectl set env deploy kube-image-keeper-registry REGISTRY_STORAGE_MAINTENANCE_READONLY="{"enabled":true}")
The garbage collection job failed with following error: failed to garbage collect: failed to mark: s3aws: s3aws: failed to retrieve tags unknown repository name={IMAGE_NAME} terminate
The job stopped and never run the last command which release the repository lock (kubectl set env deploy kube-image-keeper-registry REGISTRY_STORAGE_MAINTENANCE_READONLY-)
Evolution
The job should release the lock before be killed.

Hello @genseb13011,
Thanks for your feedbacks.
Can you please give us as many information as possible regarding your setup, so that we can investigate and the root cause for the GC failure ? (Cluster distribution, version, main components, image we can use to reproduce the issue  …)
We already faced such 405 errors after GC issues.
You’re right, we unfortunately do not yet remove the registry lock in such situations.
See #124 for example. We also face the same situation when the registry is empty + the GC starts …
As a work-around, I propose you to set --deleteUntagged attribute to false. In you situation, it should help !
As a short term, in order to limitate the GC issues impacts we plan to :
1-  Force the exit from readonly mode
2- Put in place a metric so that you can follow GC issues !

:tada: This issue has been resolved in version 1.5.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add validation for user input

This PR

standardise characters in the error message to ensure consistency in the code
adds validation to routes that requires users input
adds pagination to get routes that return multiple objects

lgtm


verify nd step for scan_nd back compatibility

verify the signature of the per_step function meets requirements for back compatibility from 1.5.5 to 1.6.0.
in discussions with @tacaswell
still to be tested.

I think the failures due to the tests being strict about the message in the exception:
https://github.com/bluesky/bluesky/blob/e5de942d14e723e843291a1a6cb989c28dd9b9fc/bluesky/tests/test_plans.py#L254-L262
That pattern match will need to be updated to new exception text.

I think the failures due to the tests being strict about the message in the exception:
https://github.com/bluesky/bluesky/blob/e5de942d14e723e843291a1a6cb989c28dd9b9fc/bluesky/tests/test_plans.py#L254-L262
That pattern match will need to be updated to new exception text.

Hi @tacaswell,
yes I noticed this too. If the new message is ok I'll update the test accordingly.

The new error message looks great—go for it! :-)
Thanks for fixing this, @lsammut.

@tacaswell @danielballan
I've added some nd_per_step specific tests and updated the pattern match. The tests shouldn't fail anymore.

pushing "re-run" on the tests made them pass, going to look into why they are flaky (also flaky on the master cron jobs).