[Java] FlightSQL JDBC DatabaseMetaData cache isn't thread-safe

Describe the bug, including details regarding any error messages, version, and platform.
The cache of SqlInfo properties in the JDBC driver isn't thread-safe.
https://github.com/apache/arrow/blob/563078fb70f7d23e716a2c1c79e96f7409c02f3f/java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowDatabaseMetadata.java#L732
If one thread starts populating the cache, and another thread requests a property while the cache is still populating, the second thread will see the cache is non-empty and think the cache has been fully populated when it might just have started populating. This will result in null properties values being retrieved and NPE errors.
Component(s)
FlightRPC, Java

This issue might the same as #38253


Enable AKS cluster autoscaler

Rule request
Suggested rule change
AKS clusters deployed with scale sets should enable the cluster autoscaler.
Applies to the following
The rule applies to the following:

Resource type: Microsoft.ContainerService/managedClusters

Additional context
Azure template reference

@BernieWhite I can help make a PR for this rule.

@ArmaanMcleod Great thanks. Let me assign that to you. If you have any issues let me know.

@BernieWhite No worries. When creating the rule for the first time which ruleset to do you put it under?
I see the following baselines:

@ArmaanMcleod The ruleset references to the quarterly baseline they are release in. For new rules this is the next a quarterly baseline so the next baseline would be 2021_09. Release GA and preview is determines by the Azure feature, so in this case AKS cluster autoscaler is a GA Azure features so it would be GA.
The quarterly baseline is designed to be a stable checkpoint for customers. So, if they are not ready to adopt new rules immediately, they can target a quarterly baseline and get a stable position even though we add rules each month.
At the end of the quarter, we cut a new baseline and deprecate the old one, which reports as a warning.
You don't need to worry about updating an old quarterly baseline. For Azure.All.md and Azure.Default.md, you can run the Rule docs task in VSCode and that should regenerate these files, ideally do this before you submit the PR.

@BernieWhite Thanks, added a Azure.AKS.Autoscaling rule in the PR. Should be ready for review.


feat: stack trace domain filtering

Allows you to display your stacktrace only, similar to a blackbox feature in chrome debugger.

Coverage increased (+0.05%) to 95.833% when pulling 85121dd27d20d15fc5bec3146f150d70974bf224 on azachar:master into 36e6157b21e2bf5e01b17eab0279a405ef4834b0 on bcaudan:master.

There is quite some changes in the codebase with 3.0.0 release. Moreover, I would prefer to have a filter function in the configuration instead of a string, in order to have more filtering possibilities.
I would be glad if you want to try to update your PR, otherwise I will be working on it soon :)

Done with e2b4908


Update operator-framework to latest

https://github.com/operator-framework/operator-sdk/releases

While testing this change I found that it causes one of the operators we use to not install correctly, resulting in the failure of two affiliated-certification-operator-is-certified test cases. Not sure of the exact cause, but it is the operator we intentionally install an older version of so that could be related. Continuing to look into this to see if there's a fix.

I just rebased this PR.  Is it still on hold because of potential older version of the operator?

Closing this.  Will revisit in another PR.


FileNotFoundError: bootstrap.min.css.map

Hi! thanks for your great work!
A error found as below when using it:
FileNotFoundError: [Errno 2] No such file or directory: '...\.venv\lib\site-packages\streamlit_javascript\frontend\build\bootstrap.min.css.map'

I can't really reproduce this issue. When does this occur?


Corrected performance data for --genai

@eaidova Shall we consider to remove following line instead of change in benchmark.py APP? https://github.com/openvinotoolkit/openvino.genai/blob/fa324cfaca838591a86cecc14cb44253b7fb7632/src/cpp/src/perf_metrics.cpp#L115
m_durations should be the duration for one inference which may generate one or more (batch_size > 1) tokens.  In the case  batch_size>1, it means @batch_size tokens are generated together in @m_durations[i] time, not one token is generated in @m_durations[i]/@batch_size

@eaidova Shall we consider to remove following line instead of change in benchmark.py APP?
https://github.com/openvinotoolkit/openvino.genai/blob/fa324cfaca838591a86cecc14cb44253b7fb7632/src/cpp/src/perf_metrics.cpp#L115
@m_durations[i] should be the duration for one inference which may generate one or more (batch_size > 1) tokens. In the case batch_size>1, it means @batch_size tokens are generated together in @m_durations[i] time, not one token is generated in @m_durations[i]/@batch_size time

@peterchen-intel  yes, for me it looks preferable


Can't type square and curly braces {[]} on Windows 10 with german keybord layout

On a german keybord layout the square and curly braces { [ ] } are typed by AltGr together with 7, 8, 9 respectively 0 (see https://en.wikipedia.org/wiki/AltGr_key#German).
This is not working on a german Window 10, neither using cmd.exe nor with using powershell.exe. E.g. typing AltGr + 7 will result in 7 not in {.
Oddly enough some of the characters enabled with AltGr are working, some are not.

Working:

'' (AltGr + 'ß')
'~' (AltGr + '+')
'|' (AltGr + <)

Not-Working:

'²' (AltGr + '2')
'³' (AltGr + '3')
'{' (AltGr + 7)
'[' (AltGr + 8)
']' (AltGr + 9)
'}' (AltGr + 0)
'@' (AltGr + q)
'€' (AltGr + e)
'µ' (AltGr + m)

Especially the square and curly braces together with the pipe character are crutial for using a command shell.

Are you trying this with the right alt key or the left alt key? Unfortunately, I do not have a Windows 10 computer set up to test this myself. Right now the left alt key is reserved for typing characters that require the alt-key combination while the right alt key is for escape sequences.
Sorry for the late reply.

Hi Jeremy,
thanks for your reply.
I'm using the right Alt key, which is called AltGr on a german keyboard and as far as I know all non-US PC keyboard layouts.
As you mentioned the right Alt key - or AltGr on german keyboards - is reserved for other combinations as the left Alt key.
But I found some interesting: at least on german keyboards the right alt key could be emulated by typing the left Alt key together with Ctrl or in other words left Alt + Ctrl is equivalent to right Alt.
Such an emulation provides a workarround for the problem. Example: while it's not possible to write @ by typing right Alt + q, it's possible by typing left Alt + Ctrl + q. Althought this is not very intuitive it's working.

By the way; I was wondering if the problem is caused by a Windows 10 API change so I tried something different:
First, I activated the Use Legacy Concole checkbox for Powershell that disables the new Windows 10 console features -> still not working
Second, I changed the Shell Override field in the terminal-plus settings to use a bash.exe from my git installation -> same behavior as with cmd.exe or Powershell.exe
Best regards,
Michael

I've also had this problem writing on a danish keyboard (logitech k120). I can write "alt gr + number" everywhere else but in the terminal (I can even do it in the text editor). It seems like there's no way to fix it.

As a general comment:
For Alt-Gr keyboards, they do not have a "right-alt" key, they have a "Left-Alt" and the right-alt key that maps to the combination "Ctrl-Alt" to the application. (Hence coding for "right-alt" only doesn't exist in these contexts).  If an accelerator for Ctrl-Alt is registered, it would trigger that combination, instead of generating the appropriate character, which is expected.
Using Alt-Gr+Ctrl is equivalent to presing ctrl-alt on it's own.
In addition, some keyboards use "right-ctrl" as a 5/6th layer toggle for characters, which is why MS officially says that all applications should ONLY use alt and alt-shift as accelerator keys, for ctrl-alt will interfere with character input;  right-alt doesn't universally exist, and unchecked-ctrl may interfere with character input.
US Keyboards have two Alt keys "Left-Alt" and "Right-Alt".  Which are passed through to the application unchanged.

Is there any way to fix this? I'm having a problem with the same cause as I use the Neo 2 layout which writes these braces: [] by typing CapsLock+E and CapsLock+R (as seen from a qwerty layout)
This works in all programs I've used it with so far except godot. Weird. Is there any way this can be resolved or am I forever doomed to copy and paste the braces I need?

Found a solution !! Use Alt gr (the one on the right) + shift + [ or ] ( square bracket keys) to get curly brackets { or } .
on my keyboard, the square brackets are next to the 'P' letter and the keys can also be used to type other letters and characters as this is for the Italian market.
No more copy and paste!
I hope it helps.

I had same problem just now, however in my case this worked and saved me, Im guessing loads of trouble.... Reboot system!

SHIFT+ALTGR works for me, dont ask why

Uninstalling all keyboard drivers in the devicemanager and restart the computer did the trick for me

No need to reboot.
This is a know issue when you have RDP open. I usually encounter it when my laptop goes to sleep while having outgoing RDP sessions established.
Go to an open RDP session and hit Alt+Enter, then go back to a non-rdp window and you should see that right-altgr + numbers are working again. If all RDP sessions are closed/dead, you might need to run mstsc.exe and open an RDP connection

No need to reboot.
This is a know issue when you have RDP open. I usually encounter it when my laptop goes to sleep while having outgoing RDP sessions established.
Go to an open RDP session and hit Alt+Enter, then go back to a non-rdp window and you should see that right-altgr + numbers are working again. If all RDP sessions are closed/dead, you might need to run mstsc.exe and open an RDP connection

The Alt+Enter in RDP worked and just Saved My Day. Thanks!

For me it is working with the combination of "AltGr" + the button with the square brace sign on it (next to the Enter button).
I hope this helps.

I found a fix!
When inside the terminal, right click the top bar and go to settings > Actions > Then scroll down until you find "Ctrl + alt + 7/8/9" and edit -> delete them.

Note: This works for the new Windows terminal, I don't know what terminal you are using.


Extensions

I added some extensions to Seq library and I check that there is some unsafe uses here. For example the constructors are not consistent: One of them creates a internal array and adds all the elements, the other one sets the internal list to the external list.
A more dangerous thing is that the method toArrayList casts the internal list to ArrayList, but it can be any other type of list.
So because of that, I would suggest the Seq class be abstract (like the List class is) and only use implementations like ArraySeq and LinkedSeq. In this way it should be safer.
So everything that I thing it shouldn't be there (or is wrong) it is annotated as Deprecated. In this way a new library wont break current existing codes but will warn the developers that they need to change the uses.
Also there are other changes I did:

Changed add method on Seq class to return boolean to conform to Collections standard.
Added addAll method on Seq Class
Added missing stuff in JavaDoc
Added missing <> to Seq initialization (initializing by new Seq() is not safe)
Changed empty method to isEmpty to conform java Getter / Setter standard
The difference function were doing nothing. So I changed to be a difference between two Seq (A - B)
The method toArrayList casted the current list to ArrayList. This is not safe because:

The this.list can be not ArrayList ( Constructor Seq(List)
You're sharing a internal instance with external code.

Added ArraySeq and LinkedSeq for safe use of Seq
Added Deprecated notations to Seq initializers because the way is implemented is not safe to use.

I would like you guys to review the changes and put your opinions @haskellcamargo @mabrasil @vitorprado  @ppamorim @jmonad/admin

I really like what you did here, there is a lot of unsafe things in the actual code.
but I have a question, why we should create many subclasses just changing the implementation of the internal List? If it's really necessary, why we can't keep the use of Seq just adding some creators just changing this? or we can keep the default using ArrayList and provide a creator with a Supplier which creates a implementation of list.
something like that:
   Seq<String>.from(() -> new Arraylist<String>());
   Seq<String>.default();

I think it's more comfortable to keep the use in Seq class, particularly I get confused when I need to find an implementation of list to use, but it's just my opinion.

We can do that @vitorprado , I just suggested the subclasses because it looks more like the Java way (it is not a standard though). In the java way we would do:
Seq<String> myArraySeq = new ArraySeq<>(); Seq<String> myLinkedSeq = new LinkedSeq<>();

I think we can use one way to construct the Seq, just one. I think it's more simple to use.
If you look into Optional in java 8 you find a "default" constructor called "of()" I think it's so simple and concise, when you need to create the object you just need one, only one, method "of()". (ok you have another constructors to create empty object, etc)
just an example:
Seq.with(ArrayList::new);
Seq.with(LinkedList::new);

When you have one method to create the object and a default public constructor too, you give 2 ways of creating the object, and when I use something I want to have one way to do it.
Or we can hide the default and just have a with constructor and forget the default creation with ArrayList and ask for a implementation of List in every instance.
It's just a guess, what do you think about @racerxdl ?

I agree @vitorprado. I liked this solution. When I get home I will change this PR code to match this spec.

So I was taking a look now in the issue, and I found that is a bigger issue than I tough.
The way the Java 8 optionals use the .of is by using a reflection type from the parameter class. This is a good solution, but considering that we want this library to be java universal, and Android doesn't like much Reflection stuff (it should be avoided at maximum) I would prefer to keep reflection of limits for this library.
Considering that, for now I fixed to ArrayList the default implementation (that will work fine for almost all cases) and then we can check it later.

Damn Android, reflection is so awesome :/
It's fine. 👍 👍  :shipit:
We can discuss more about this problem.
Thanks a lot @racerxdl

I thinks it's really important. Can we merge it? @ppamorim @racerxdl @haskellcamargo

For me it is ok. @ppamorim and @haskellcamargo have you checked the code?

Ok so they confirmed on Facebook that they approve. I'm merging it.


Tests fail due to options conflict using hardened GCC 8.3.0

make test output from the latest master:
⚙ KreMLin will drive the C compiler. Here's what we found:
gcc is: gcc
gcc options are: -I /home/james/Code/kremlin/kremlib -I /home/james/Code/kremlin/include -I .output/TestKremBytes.out -Wall -Werror -Wno-unused-variable -Wn
o-unknown-warning-option -Wno-unused-but-set-variable -g -fwrapv -fstack-check -D_BSD_SOURCE -D_DEFAULT_SOURCE -Wno-parentheses -std=c11
⚡ Generating object files
✘ [CC,.output/TestKremBytes.out/TestKremBytes.c] (use -verbose to see the output)
cc1: error: ‘-fstack-check=’ and ‘-fstack-clash_protection’ are mutually exclusive.  Disabling ‘-fstack-check=’ [-Werror]
cc1: error: unrecognized command line option ‘-Wno-unknown-warning-option’ [-Werror]
cc1: all warnings being treated as errors

After removing -fstack-check from src/Options.ml and building krml again, the tests pass.
I assume that -fstack-clash-protection is enabled because I am using a hardened toolchain with stack smashing protection (SSP) enabled.
$ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/8.3.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /var/tmp/portage/sys-devel/gcc-8.3.0/work/gcc-8.3.0/configure --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/8.3.0 --includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/8.3.0/include --datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/8.3.0
--mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/8.3.0/man --infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/8.3.0/info --with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/8.3.0/include/g++-v8 --with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/8.3.0/python --enable-languages=c,c++,go,fortran --enable-obsolete --enable-secureplt --disable-werror --with-system-zlib --enable-nls --without-included-gettext --enable-checking=release --with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo Hardened 8.3.0 p1.0' --enable-esp --enable-libstdcxx-time --disable-libstdcxx-pch --enable-shared --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu --enable-multilib --with-multilib-list=m32,m64 --disable-altivec --disable-fixed-point --enable-targets=all --enable-libgomp --disable-libmudflap --disable-libssp --enable-libmpx --enable-systemtap --enable-vtable-verify --enable-lto --without-isl --enable-default-pie --enable-default-ssp
Thread model: posix

$ gcc --version
gcc (Gentoo Hardened 8.3.0 p1.0) 8.3.0

Thanks. Using kremlin as a driver for the C compiler is becoming less and less supported, and this is one more reason to deprecate it.

@msprotz Another problem I had is with linking libkremlib.a. I ended up patching Makefile.basic in the KreMLin repository so it will use $(USER_CFLAGS) to include the necessary linking options to GCC. It's not exactly a foolproof solution, but it works for me for now.

Is USER_CFLAGS a standard Unix variable or is it just a common Gentoo thing?

It's a variable in Makefile.include generated by KreMLin when passing in -ccopts.
-------- Original Message --------
On Mar 23, 2019, 2:44 PM, Jonathan Protzenko wrote:

Is USER_CFLAGS a standard Unix variable or is it just a common Gentoo thing?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@msprotz FWIW, Nim is another language the compiles to C and uses its own driver. There may be some ideas there for handling it in KreMLin.

Nim Compiler User Guide
Nim Backend Integration
extccomp.nim

Can you submit a pull request that removes -fstack-check? Also: you said you had to patch Makefile.basic; did this not work? https://github.com/FStarLang/kremlin/blob/master/misc/Makefile.basic#L24

Thanks for the pointers to nim. But kremlin as a driver only works for the most minimal test cases -- for any reasonable project, I prefer to rely on the generated Makefile to get massive parallelism for the C compiler invocations.

Sure - I'll send some PRs shortly.
That line 24 doesn't help because the final compiler invocation only grabs the object files and spits them out to an executable (cc 1.o 2.o 3.o -o all). You'll see in the diff.

@msprotz Another source of inspiration is Zig. It actually ships with different libc's and has a more user-friendly cc frontend; it also has a build system with artifact caching. See the release notes: https://ziglang.org/download/0.4.0/release-notes.html
I would be interested in working on a language-native build system as a GSoC 2020 project. For one thing, I believe Make belongs in the 70s whence it came. And I want to support any developer productivity features that I've grown accustomed to in other modern languages.
Thanks for your consideration. Feel free to email me!

There appear to be some overzealous clashing defaults that prevent building of yay:
cc1: error: '-fstack-check=' and '-fstack-clash_protection' are mutually exclusive; disabling '-fstack-check=' [-Werror] cc1: all warnings being treated as errors


Show previous years data

It is now January 2018, nothing is going on for December 2018, and I cant see any info about December 2017.
Ideally the UI shows the previous years statistics all year round, at least until the next program is ready to start.

can i work in this issue ? it it still active ?

@sarvo123 yep


Full analysis Sensor Configuration of Apollo 6.0 on SVL Simulator

Hello, I'm Shisato Yano, autonomous driving system engineer in Japan.
I've been trying to simulate by connecting between Apollo 6.0 and SVL Simulator.
Simulation by 6.0 (modular testing) and SVL Simulator was fine and next, I want to simulate as full analysis sensor configuration like 5.0.
I added a configuration same as 5.0 (full analysis) and confirmed that 6.0 and SVL Simulator were connected successfully and each topic of sensor was being updating on SVL Simulator.  (Radar, LiDAR and Camera and etc.)
But, on DreamView, any object detection bouding box was not displayed and the vehicle didn't start driving.
Could you tell me that only 5.0 is allowed to connect and simulate with SVL Simulator
for full analysis testing currently? If I want to try simulating by 6.0 as not only modular testing but also other configurations (including Radar, LiDAR and any other sensors), how shoud I do?
Best Regards,
Shisato Yano
System information

OS Platform and Distribution (e.g., Linux Ubuntu 18.04): Ubuntu 18.04
Apollo installed from (source or binary): source
Apollo version (3.5, 5.0, 5.5, 6.0): 6.0

Steps to reproduce the issue:

Open SVL Simulator browser and download a JSON file of Apollo 5.0 (full analysis) configuration.
Copy the JSON file and rename to Apollo 6.0 (full analysis).json.
Start Apollo 6.0 by dev_start.sh -> dev_into.sh -> bootstrap_lgsvl.sh -> bridge.sh.
Run Simulation using the above Apollo 6.0 (full analysis) configuration and confirm that Connection status each other.
Connection status will be OK and each topic of sensor will be updated.
Open DreamView.
Make each module enable (Localization, Transform, LiDAR, Radar, GPS, Camera, Planning, Prediction, Routing). And then, Radar, Camera and GPS were made disable immediately...
On DremView, you should be able to confirm that there is no object bounding box and you can just selecting destination point but the vehicle doesn't start driving.

Hi Shisato Yano,
I happen to be doing the simulation of Apollo v6.0.0 and lgsvl today. I just want to test planning and control so 6.0 (modular testing) is enough.

Copy the JSON file and rename to Apollo 6.0 (full analysis).json.

I tried to make 5.0 (full analysis) and apollo6.0 work together, but It's true that the performance of lateral control is terrible. You can try to copy  LiDAR, Radar, Camera part from 5.0 (full analysis) to 6.0 (full analysis).

Hi @Tcloser,
Thank you for replying.
I have already tried to copy LiDAR, Radar, Camera part from 5.0 (full analysis) to 6.0 (full analysis) but it didn't work well. I could run simulator and connect with 6.0 (full analysis) but the vehicle did not start driving to destination point.. (It looked like the system entered to Auto mode)
How about connecting between LV Simulator (5.0 full analysis) and Apollo 5.0?
Should I build 5.0 and try again connecting with LV Simulator (5.0 full analysis)?

Hi @ShisatoYano ,
If you want to build 5.0 you can download lgsvl for apollo5.0 and have a try. It's true that the support for apollo6.0 is not good enough.

Hi @Tcloser,
Thank you for helping me and I will try building 5.0.
By the way, my own PC has the following prerequisites for building 6.0 now. Can 5.0 be built in the same environment?

Closed due to inactivity. If the problem persists, pls feel free to reopen it or create a new one and refer to it.


Enhancing the rating stars.

When we hover over the stars in order to rate, only one star glows on which our cursor is. But ideally if i take my cursor to the fourth star, first four stars should glow golden. (As shown in image1 second card)
Glowing stars when hovering will even solve another problem i.e. if some card is rated 2 star and i hover over the star 5, then first two stars will glow and then fifth. This doesnot look good. As shown in image 2(Second card)

This will even solve one more problem i.e. if we have a already rated a card as 5 star and we want to rate 2, hovering over the second star will make no difference. But if we adopt glow on hover, this will fix it too. (As in image 3, second card)

The cursor could not be shown in the screenshot. But i hope the problem is crystal clear.

I would like to work on this issue as a GGSOC'24 contributor. Kindly assign this issue to me.


how to add my own tags?

try to edit the csv file in tags directory, but error always occured

For example, the quality.txt file has been added to the tags folder. You can add your own tags to this file, or create new text files with your own list of tags. For example, create a MyTags.txt file and add new tags line by line to it. When launched, the program will create a new database of tags, including those you added.

Thx for explanation. I repeated several times, neither created a new txt file nor edited the quality.txt can stop throwing out the same error, as shown below (translated by machine):
Exception text ******
System.ArgumentOutOfRangeException: Index out of range. Must be non-negative and less than the collection size.
Parameter name: index
   在 System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource)
   在 BooruDatasetTagManager.TagsDB.AddTag(String tag, Int32 count, Boolean isAlias, String parent)
   在 BooruDatasetTagManager.TagsDB.LoadFromCSVFile(String fPath, Boolean append)
   在 BooruDatasetTagManager.TagsDB.LoadCSVFromDir(String dir)
   在 BooruDatasetTagManager.Program.<><Main>c.b__0_1()
   在 System.Threading.Tasks.Task.Execute()
--- at the end of the stack trace at the previous position where the exception was thrown---
   在 System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   在 System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   在 BooruDatasetTagManager.Program.<>c__DisplayClass0_0. <<Main>b__0>d.MoveNext()
--- at the end of the stack trace at the previous position where the exception was thrown---
   在 System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()

Thank you, there is indeed such a mistake.

Fixed in 1.6.4


Handle creating delegates for private setters on base types

Properties can be defined in a base type with a private setter and then overridden. In such cases the setter does not show up in the .NET Reflection metadata for the property in the derived type. We therefore need to use special code to go down the hierarchy and find the private setter on the base type so it can be mapped to a delegate and called. (See EF6 codebase for examples.) (The same is true for getters so we should probably support both cases, although I've never seen the getter case in the wild.)

+1. I got nailed by this my first time out trying EF7 (experienced as per https://github.com/aspnet/EntityFramework/issues/1026 ).

So EF 7 is supporting private setters ?

@phillip-haydon They are actually supported already. The following code works with EF7 Beta 4. Private property setters were actually supported in previous version of EF too.
using Microsoft.Data.Entity;
using System;

namespace ConsoleApplication39
{
    class Program
    {
        static void Main(string[] args)
        {
            using (var db = new BloggingContext())
            {
                db.Database.EnsureCreated();

                db.Blogs.Add(new Blog("romiller.com"));
                db.SaveChanges();

                foreach (var item in db.Blogs)
                {
                    Console.WriteLine(item.Url);
                }
            }
        }
    }

    public class BloggingContext : DbContext
    {
        public DbSet<Blog> Blogs { get; set; }

        protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
        {
            optionsBuilder.UseSqlServer(@"Server=(localdb)\mssqllocaldb;Database=PrivateSetters;Trusted_Connection=True;");
        }
    }

    public class Blog
    {
        private Blog()
        { }

        public Blog(string url)
        {
            Url = url;
        }

        public int BlogId { get; private set; }
        public string Url { get; private set; }
    }
}


Can it handle private repo?  How about conflict ?

Hi,

Can it copy folder from private repo ?
How does it handle conflict if a downloaded file already exists in the working dir ? Is there an option to skip it ?

@Fred-Vatin 1. If GITHUB_TOKEN is set in your env, the private repo also work. (refer to this code https://github.com/rocket-hangar/copy-github-directory/blob/master/packages/src/copy-github-directory/index.ts#L76)
2. It will not work on non-empty folders. so, conflict does not occur.


Rotate to euler angles can not loop ?

If the setting is correct there is a problem, that is loop function invalide.

tweens added to a Sequence can't have infinite loops (but the root Sequence can).

tweens added to a Sequence can't have infinite loops (but the root Sequence can).

Thanks for the clarification! I want not sure about that as well!?
I think I can add the loops setting for the animation controller as a whole, that would give you an option of how to do that right?

maybe, and we can have a test later.

Give a try to the 0.2.1 release:
https://github.com/brunomikoski/Animation-Sequencer/releases/tag/v0.2.1

Could you pls give a choice to user， if it didnt want a animation step insert/append to a sequence.
The infinite loop does not behave as I expected.
Flowtype can add a select item "independence" maybe .

I believe you could just use the Play Sequence Action to trigger 2 different Animation Sequencer with your settings right?
But in this case looks like you are looking for the step 1 and 2 to use the Join flow type, both would start at the same time, right?

yes ,yes
and I found that neither apend nor join can make them start at the same time.


Statically link objects

This makes docker2aci usable under non-glibc environments.
Resolves #246.

@lucab: since this project has been dormant for a few years, I'll close the PR. Can you mark it as archived on GitHub please?

Unfortunately I cannot directly, I'll try to find somebody with enough privileges to do so.
The umbrella project has been ended via https://github.com/rkt/rkt/issues/4024.

@lucab: you didn't get to it?

@philips @iaguis @vbatts we should go for a round of archivals here similar to https://github.com/rkt/rkt/pull/4026, but I don't have privileges on this organization to do so myself. Can any of you take care of this?

you have owner role @lucab
On Tue, Jun 9, 2020 at 9:55 AM Luca Bruno<EMAIL_ADDRESS>wrote:

@philips https://github.com/philips @iaguis https://github.com/iaguis
@vbatts https://github.com/vbatts we should go for a round of archivals
here similar to rkt/rkt#4026 https://github.com/rkt/rkt/pull/4026, but
I don't have privileges on this organization to do so myself. Can any of
you take care of this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/appc/docker2aci/pull/253#issuecomment-641441695, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAIGCERXHKIZRTBKLT4XF3RVZSOZANCNFSM4D4RWIEA
.

:+1:


integration tests failing on IBM Cloud

Describe the bug
Integration tests are failing on IBM Cloud

you aren't supposed to add tickets once a sprint is in progress. This is completely within the scope of the other ticket currently assigned to @tanaytrivedi. Closing this ticket.


v15.0.2 improve game processor Engineering Index

[Current coverage][cc-pull] is 100%

Merging [#354][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #354   diff @@
====================================
  Files          24     24
  Lines         365    365
  Methods        77     77
  Messages        0      0
  Branches        0      0
====================================
  Hits          365    365
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last updated by [409c681...e7e1fe4][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/409c681c2a4f857a77a800c8b4a81651e5ba3520...e7e1fe4408e1162b7ae5acbc9e49d478e0325d70
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/354?src=pr

[Current coverage][cc-pull] is 100%

Merging [#354][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master   #354   diff @@
====================================
  Files          24     24
  Lines         365    365
  Methods        77     77
  Messages        0      0
  Branches        0      0
====================================
  Hits          365    365
  Misses          0      0
  Partials        0      0

Powered by Codecov. Last updated by [409c681...e7e1fe4][cc-compare]
[cc-base-branch]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/compare/409c681c2a4f857a77a800c8b4a81651e5ba3520...e7e1fe4408e1162b7ae5acbc9e49d478e0325d70
[cc-pull]: https://codecov.io/gh/eugene-matvejev/battleship-game-api/pull/354?src=pr


Upgrade Istio versions to 1.15.1

Upgrade Istio to the latest release of 1.15.1
SURE-5347

Let's do 1.15.2 if possible

/backport v2.6.10

Validated on rancher/rancher:v2.7.0
Created a downstream cluster with 3worker, 3etcd, 2 cp
Tested Istio charts for version 100.3.0+up1.15.3, Kiali - v1.59.0, and Jaeger - v1.39.0.
Tested following scenarios. all the tested scenarios passed the checks.

[ ] Fresh install checks
[ ] Upgrade test case from istio 1.14.6 —> 1.15.3
[ ] Upgrade with custom overlay
[ ] Kiali
[ ] Jaeger traces
[ ] Reinstall with Kiali and Jaeger enabled
[ ] Fresh install with modified ingress gateway
[ ] Reinstall
[ ] Istio pointing to externally-installed Prometheus
[ ] Multiple ingress
[ ] Egressgateway

Istio 1.15.3, Kiali and Jaeger are working fine for all the tested scenarios. Hence, closing the issue.


Optimize waker size for requirements

This is the result of me tinkering around with the idea described in #4, I would like your approval/disapproval on the basic idea before i write documentation etc.
TLDR; It's possible to reduce the size of a ReceiverWaker if it is known that it will only be used in blocking or non-blocking contexts beforehand. This is currently being decided using crate features, but it would be nice if it was possible to specify this for each channel individually.
Design Idea
This PR uses two traits (SyncWaker / AsyncWaker) to expose different methods on Receiver based on what waker is being used.
There are four different wakers, which are equivalent to the four possible feature combinations right now:

Waker
implements SyncWaker
implements AsyncWaker
Methods on Receiver<T, W>
Size

DummyWaker
No
No
try_recv only
0

thread::Thread
Yes
No
All blocking methods
8

task::Waker
No
Yes
All non-blocking methods
16

GenericWaker
Yes
Yes
All
16

To avoid breaking changes, a DefaultWaker is also exported, which equates to the "most permissive" of the available wakers based on the enabled features and, as the name implies, is used by default.
The main design issue currently is how to adjust the crate API so the used waker can be specified.
Currently, channels are being constructed using
fn channel<T>() -> (Sender<T>, Receiver<T>)

Ideally this would be possible:
fn channel<T, W = DefaultWaker>() -> Sender<T, W>, Receiver<T, W>)
where W: Waker

but default values for generic parameters on functions are not allowed.
So the "next best" option would be to either export more constructor functions:
// "Old" API
fn channel<T>() -> (Sender<T, DefaultWaker>, Receiver<T, DefaultWaker>)

// Enable these based on features
fn wakerless_channel<T>() -> (Sender<T, DummyWaker>, Receiver<T, DummyWaker>)
fn strictly_sync_channel<T>() -> (Sender<T, thread::Thread>, Receiver<T, thread::Thread>)
fn strictly_async_channel<T>() -> (Sender<T, task::Waker>, Receiver<T, task::Waker>)

or to move these functions onto the Channel type itself, so the waker type is already clear.

Hi! Thanks for wanting to contribute. This looks cool and all, but I have some concerns.

To avoid breaking changes, a DefaultWaker is also exported, which equates to the "most permissive" of the available wakers based on the enabled features and, as the name implies, is used by default.

Features need to be additive only. I'm not sure if changing the type of DefaultWaker when the feature set changes is going to cause trouble anywhere :thinking: Technically you are replacing a type with another. But on the other hand, it should change from and to the same thing for every possible observer.
Since I wrote the issue I have maybe changed opinion slightly. This change is pretty complex, and does it really save a lot of space? For this to be worth the extra complexity someone must use this in a way where they have tiny messages, and a huge amount of channels. Like with almost any optimization, I think it would be nice if we had any concrete proof this change is justified by real world usage/benchmarks.

It's possible that this has small CPU benefits as well due to each waker being simpler than "support all waking methods". However it's really hard to measure. It's hard because you can only perform a single wake event per channel (by design), and allocation and other things related to creating and destroying each channel probably outweigh the waking part by a lot. But yeah, if we can't prove a performance win, then it's probably not worth the complexity anyway, since the same applies for production use, not just benchmarks.

Yeah, those are fair concerns (:
I'm also very unsure whether this is worth the effort! (that's part of the reason this is a draft pr)
To address some of your comments:

I'm not sure if changing the type of DefaultWaker when the feature set changes is going to cause trouble anywhere

Hmm, unless someone relies on the result of std::any::type_name (or similar) this shouldn't cause issues. The DefaultWaker only changes to expose more methods as more features are added. But you're not wrong, this is kinda brittle. Especially once you start to consider auto traits!

Like with almost any optimization, I think it would be nice if we had any concrete proof this change is justified by real world usage/benchmarks. [...]
It's possible that this has small CPU benefits as well due to each waker being simpler than "support all waking methods".

I can't imagine there are any measurable performance wins here - at most you're saving one match, but even that might be optimized away when the functions are inlined... Performance was not the motivation here. It just feels clunky to carry around space for a task::Waker when you know that the channel will only be used in sync contexts. Because this is currently controlled with cargo features, either all your channels support async or none do.


feature request: Find-AADLicensedGroups

It would be very useful to have a command to retrieve all AADGroups with a license applied to it.

Thanks for the feedback, will take this into consideration

You can now use the Get-AADGroupLicenseAssignment cmdlet either with the -All  switch or -groupId parameter.
The -All  option returns a list of all available licenses and the assignments:


Hello, help me please

Thank you so much for a great project When a user application sends a specific process address through IOCTL communication, it would be nice to make a function that hides that address. I tried for a month, but I couldn't help.

Thank you so much for a great project When a user application sends a specific process address through IOCTL communication, it would be nice to make a function that hides that address. I tried for a month, but I couldn't help.

Thank you so much for a great project When a user application sends a specific process address through IOCTL communication, it would be nice to make a function that hides that address. I tried for a month, but I couldn't help.

Thank you so much for a great project When a user application sends a specific process address through IOCTL communication, it would be nice to make a function that hides that address. I tried for a month, but I couldn't help     .and. I'm Korean, I'm writing a translator


[BEAM-3744] Add support for Pub/Sub messages with attributes.

R: @charlesccychen

PTAL

Thanks, LGTM.

CC: @chamikaramj for merge please

Can you address the comment above regarding "unencoded"?

Not sure why, but I believe this change broke Python postcommits.  If you look at https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Python_Verify/, you see that build 4350 passes, while build 4351 onwards fails.
From here (https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Python_Verify/4350/pollingLog/), you see that build 4350 is at revision 15018c93fd7e6c97c0628631fd5a847dd18cbf66, while build 4351 (https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Python_Verify/4351/pollingLog/) is at revision 2fd60a2724b7ad470ffaea2ab23608d4bb5f19f0.  Looking at the git log, we see the following.  Note that the failures start at the merge of this commit.
commit 2fd60a2724b7ad470ffaea2ab23608d4bb5f19f0
Merge: 15018c93f 91b05c306
Author: Chamikara Jayalath<EMAIL_ADDRESS>Date:   Fri Mar 2 18:13:06 2018 -0800

    Merge pull request #4744: [BEAM-3744] Add support for Pub/Sub messages with attributes

commit 91b05c306ab620f8752e8a277801f6ef59b1863e
Author: Udi Meiri<EMAIL_ADDRESS>Date:   Wed Feb 21 13:17:10 2018 -0800

    Add support for Pub/Sub messages with attributes.

commit 15018c93fd7e6c97c0628631fd5a847dd18cbf66
Merge: 8c134a12a d68a78bf9
Author: Thomas Groh<EMAIL_ADDRESS>Date:   Fri Mar 2 14:26:49 2018 -0800

    Merge pull request #4787

    [BEAM-3409] Revert "extracting the scheduled executor service in a factory variab…

Therefore, I believe this change is somehow causing the Python postcommit to time out.  @udim, can you investigate?

Looking...

I see this in the Dataflow pipeline log:
'module' object has no attribute '_PubSubPayloadSource'

and that's because this PR renamed it.


[UI] Rebranding: Darksend changed to PrivacyProtect (UI+log)

tungfa told me that "Darksend" will be re-branded to "PrivacyProtect". This is a first result.
Please test and report back if I missed some occurrences.
What's covered:

labels, buttons and screen titles
tool-tips
text of log-messages

What's not covered:

log category, the category is still called "darksend"
RPC API + command-line/dash.conf options
network messages to other peers/nodes
refactoring of classes containing Darksend in the name
I think I remember that somewhere's a thread created called darksend
translations

I can do 1. and 2. later if wanted, 3. + 4. is for someone who REALLY is bored :-)
Overview-screen looks like this now:

Thanks for looking into this!
However, now with that done in code it looks like this DS->PP transition is not going to be that easy to implement and it looks messy tbh (imo)... Maybe it would be a better idea to get rid of any technology name at all in UI/logs/rpc(?) and replace it with smth more general like simply "mixing", "mixed", "private" etc.
And few side notes:

having darksend + privacyprotect together all over the place in code is confusing imo and I think almost everything in "What's not covered" need to be implemented too sooner or later
if you mean "change ds part to pp" in messages like dsq, dsa etc in number 3 of "What's not covered" then I guess this can be done later once we have something else that bumps protocol for a better reason than just rebranding ;) (or keep it as it is if we decide to go with general names)

@UdjinM6 I think the main problem is the mixing button, I think I'll change it to "Start Mixing" and be done with it.
The other places are IMO okay-ish, but if one of you wants specific changes just speak up :-)
And, yes, I meant exactly those messages.
(on the other hand, we live in a "Design-Driven" world, so I wouldn't be TOO surprised if one day someone somewhere on this planet changes a protocol because the protocol-messages need a re-branding.
Aaaargh, shoot me...)

@UdjinM6 @schinzelh : somewhere during the last big Bitcoin-merge parts of https://github.com/dashpay/dash/pull/612 got lost (here: no theme-dependent splash-screens).
I've fixed this with https://github.com/dashpay/dash/pull/760/commits/67214d997166fa3ed2a0f5efec1b587dcb9f8675.
However, some things are still not there, e.g. the theme-dependent tx_input/tx_inout/tx_whatever icons (they show up fine on the 'Transactions' page, but the bigger ones on the 'Overview' page are gone). The resources are all there
I don't have any local working repositories of my changes  any more, so I can't easily diff through the files. Something seems to be changed in TransactionTableModel but I cannot find what..I guess it's just TOO obvious to be found by myself :-/

b61849c is a step in the right direction ;) I guess tungfa already sent you an image with few more changes so we all should be on the same page now.
Re issues with splash screen:
67214d9 has nothing to do with current PR and should be removed imo.
Yes, I removed splash_tesnet.png-s because bitcoin now uses NetworkStyle to rotate colors for different networks instead of having multiple files. You are right though, there is a bug with splash screen theme specifically which I hope should be fixed by #761. I'm not sure about tx_whatever icons though, I don't see any issues. (Let's continue in #761 if you still have any issues after applying that patch).

@evan82 @schinzelh , it's ready to merge now, from the UI and log point of view Darksend is Privatesend now and InstantX is InstantSend.


Move auth functions into own module

...and out of the tasks stuff.

I'll take this up

Should we close this?


This project is not building

This is what I got when build the microservice
=> [internal] load build definition from Dockerfile                                                               0.6s
=> => transferring dockerfile: 2B                                                                                0.0s
=> [internal] load .dockerignore                                                                                0.9s
=> => transferring context: 34B                                                                                0.0s
failed to solve with frontend dockerfile.v0: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount046231930/Dockerfile: no such file or directory
And when I check for docker images running , nothing showed,
REPOSITORY   TAG       IMAGE ID   CREATED   SIZE
E:\Test-pro\myMicroservice>docker run -it --rm -p 3000:80 --name mymicroservicecontainer mymicroservice
Unable to find image 'mymicroservice:latest' locally
docker: Error response from daemon: pull access denied for mymicroservice, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
See 'docker run --help'.
My Docket file is
FROM mcr.microsoft.com/dotnet/sdk:5.0 AS build
WORKDIR /src
COPY myMicroservice.csproj .
RUN dotnet restore
COPY . .
RUN dotnet publish -c release -o /app
FROM mcr.microsoft.com/dotnet/aspnet:5.0
WORKDIR /app
COPY --from=build /app .
ENTRYPOINT ["dotnet", "myMicroservice.dll"]
Should I change the SDK version to 3.1 here as well ? I have .net core 3.1

@MichaelSimons can you help here?

@MichaelSimons can you help here?

Hi Cory,
That project I referenced is not building.
https://dotnet.microsoft.com/learn/aspnet/microservice-tutorial/create.
I think I have provided details in the github link, in the issues section.
Manula
On Thu, Jan 14, 2021 at 4:41 AM Cory Nelson<EMAIL_ADDRESS>wrote:

@MichaelSimons https://github.com/MichaelSimons can you help here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dotnet/core/issues/5834#issuecomment-759816580, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADEJH2CMJQVD4GNMXYVKCFDSZYSBFANCNFSM4V5YMJVA
.

Hi Cory,
That project I referenced is not building.
https://dotnet.microsoft.com/learn/aspnet/microservice-tutorial/create.
I think I have provided details in the github link, in the issues section.
Manula
On Thu, Jan 14, 2021 at 4:41 AM Cory Nelson<EMAIL_ADDRESS>wrote:

@MichaelSimons https://github.com/MichaelSimons can you help here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dotnet/core/issues/5834#issuecomment-759816580, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADEJH2CMJQVD4GNMXYVKCFDSZYSBFANCNFSM4V5YMJVA
.

@mmadushanka, Can you share what command you are using to build your Dockerfile.    It appears that Docker is not finding your Dockerfile.

@mmadushanka, Can you share what command you are using to build your Dockerfile.    It appears that Docker is not finding your Dockerfile.

Hi Michael,
This is the command that I used o build the dockerfile
docker build -t mymicroservice .
It is same the command you provide in the example.
Yes, I think my docker file is not found by docker.
My .net  sdk version is .net core 3.1.
Is there any version mismatch here with the included version of the exmaple dockerfile.?

Hi Michael,
This is the command that I used o build the dockerfile
docker build -t mymicroservice .
It is same the command you provide in the example.
Yes, I think my docker file is not found by docker.
My .net  sdk version is .net core 3.1.
Is there any version mismatch here with the included version of the exmaple dockerfile.?

Where is your Dockerfile located in reference to where to are running the docker build command?
If you want to use .NET Core 3.1 then you will need to change the two FROM instructions in the Dockerfile to reference 3.1 images versus the 5.0 images.  I don't think this is related to the issue you are currently encountering though.

Where is your Dockerfile located in reference to where to are running the docker build command?
If you want to use .NET Core 3.1 then you will need to change the two FROM instructions in the Dockerfile to reference 3.1 images versus the 5.0 images.  I don't think this is related to the issue you are currently encountering though.

Here what I just did is follow, these flow to create an microservice and run it with docker.
There is a folder call mymicroservice in the local drive where the microservice and dockerfile is located,
I have run these commands in the command prompt, pointing to the root folder ( mymicroservice) to run the service.
1). Service ran properly as in the example.
2), Then I added the dockerfile and dockerignor to the same folder, as following the instructions.
( My .net core version is 3.1, but I could that the sample dot net sdk version is .net 5, I think.)
( Docker version 20.10.2, build 2291f61)
3). Then I am trying to create the docker image.
so I got this error :
[
Building 1.6s (2/2) FINISHED
=> [internal] load build definition from Dockerfile                                                               1.8s
=> => transferring dockerfile: 2B                                                                                0.3s
=> [internal] load .dockerignore                                                                                1.3s
=> => transferring context: 34B                                                                                0.2s
failed to solve with frontend dockerfile.v0: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount365263377/Dockerfile: no such file or directory
]
Could not be able to create the docker image.
So the rest of the commands would not work.
Why could not I be able to create the dcoker image ?  Is that .net verion error or some configutation issue ?

Here what I just did is follow, these flow to create an microservice and run it with docker.
There is a folder call mymicroservice in the local drive where the microservice and dockerfile is located,
I have run these commands in the command prompt, pointing to the root folder ( mymicroservice) to run the service.
1). Service ran properly as in the example.
2), Then I added the dockerfile and dockerignor to the same folder, as following the instructions.
( My .net core version is 3.1, but I could that the sample dot net sdk version is .net 5, I think.)
( Docker version 20.10.2, build 2291f61)
3). Then I am trying to create the docker image.
so I got this error :
[
Building 1.6s (2/2) FINISHED
=> [internal] load build definition from Dockerfile                                                               1.8s
=> => transferring dockerfile: 2B                                                                                0.3s
=> [internal] load .dockerignore                                                                                1.3s
=> => transferring context: 34B                                                                                0.2s
failed to solve with frontend dockerfile.v0: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount365263377/Dockerfile: no such file or directory
]
Could not be able to create the docker image.
So the rest of the commands would not work.
Why could not I be able to create the dcoker image ?  Is that .net verion error or some configutation issue ?

The tutorial assumes you have .NET 5 SDK, otherwise the Dockerfile shown needs to be tweaked.

The tutorial assumes you have .NET 5 SDK, otherwise the Dockerfile shown needs to be tweaked.

@mmadushanka, Can you validate that you have a working Docker environment?
Create a Dockerfile with the following contents:
FROM alpine:3.12

ENTRYPOINT echo 'Hello World!'

Build it by running the following cmd in the same directory as the Dockerfile: docker build --pull -t hello-world .
Run the resulting image with the following cmd:  docker run --rm hello-world

@mmadushanka, Can you validate that you have a working Docker environment?
Create a Dockerfile with the following contents:
FROM alpine:3.12

ENTRYPOINT echo 'Hello World!'

Build it by running the following cmd in the same directory as the Dockerfile: docker build --pull -t hello-world .
Run the resulting image with the following cmd:  docker run --rm hello-world

No response in 20 days. Closing.


Update link to reflect new "Fluent API Generator' branding

This PR was included in release version 3.1.1 :tada:


Azure VM file copy task broken by Azure PowerShell Cmdlets (March 1.2.2)

The following error is thrown when using the AzureFileCopy task (1.0.41) in conjunction with Azure PowerShell cmdlets (1.2.2)
2016-03-08T22:33:45.1608363Z Failed to download build/files from Azure Storage before starting the DSC deployment on machine. Error Message: 2016-03-08T22:33:45.1608363Z System.AggregateException: The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: [2016/03/08 22:33:20][ERROR] The syntax of the command is incorrect. Invalid SAS token in parameter "SourceSAS".  ---> System.Management.Automation.ActionPreferenceStopException: The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: [2016/03/08 22:33:20][ERROR] The syntax of the command is incorrect. Invalid SAS token in parameter "SourceSAS".
Reverting to Azure PowerShell Cmdlets version 1.2.1 resolved this issue.

I'm also running into this issue.

Btw, how did you revert to Azure PowerShell Cmdlets version 1.2.1?  I cannot find that anywhere.

This issue should be resolved by now. please verify

Please follow the below steps for uninstalling the current Azure PS and getting the supported Azure PS version:

Goto  Control Panel -> Programs -> Uninstall a Program
Type “Azure PowerShell” in the search window. Search result will display the program name like “Microsoft Azure PowerShell – February 2016”.
Right click on it and click UnInstall. This removes the current Azure PS from your machine.
Now, Restart the machine.
Install the Azure PowerShell 1.0.2 form the below link:
https://github.com/Azure/azure-powershell/releases/tag/v1.0.2-December2015


FALCON-1943 Extension API/CLI fails when authorization is enabled

+1 - We should allow extension as a top level resource

+1


[CAUTION] Rook/Ceph has privileges to wipe your host's disks as it has access to all devices by default

What did you do
Main Desktop was Ubuntu 21.04, I was curious about what GUI for Cephs s3 looked like so I decided to spin up k3d and install rook, the result is that my host os was destroyed.
I believe the curl command to install k3d installs the latest version, which was 5.1.0

How was the cluster created?

curl -s https://raw.githubusercontent.com/rancher/k3d/main/install.sh | bash
k3d cluster create

What did you do afterwards?

Followed https://rook.io/docs/rook/v1.7/quickstart.html
git clone --single-branch --branch release-1.7 https://github.com/rook/rook.git
cd rook/cluster/examples/kubernetes/ceph
kubectl apply -f crds.yaml -f common.yaml -f operator.yaml
kubectl apply -f cluster-test.yaml
(after about 3 minutes my computer crashed, and reboot just showed grub2 cli interface, messing around with cli showed no bootable partitions, so I booted from a live usb to inspect my partition using gnome-disk-utility. Instead of my host OS and data. I see the entire drive was wiped and replaced with Partition 1: 537MB fat, Partition 2: 500GB ceph_bluestore, 1.1mb free space.  Good excuse to check out OpenSUSE Tumbleweed though.)

https://github.com/rook/rook/blob/release-1.7/cluster/examples/kubernetes/ceph/cluster-test.yaml#L43-45
Mentions useAllNodes and useAllDevices true, so I guess it thought it could format the root partition? not sure.
What did you expect to happen

I know docker sandboxing isn't as good as VMs, but I didn't expect that running a container on k3d would have the rights to wipe the entire host OS's disk.
Expected k3d to have some level of sandboxing. (which is why I'm posting the bug report in both repos.)
https://github.com/rook/rook/issues/9166
(Ironically I usually run k3d in VMs and the first time I run it on my host OS it wipes the OS)

Which OS & Architecture

Ubuntu 21.04 x64

Which version of k3d

5.1.0

Which version of docker

whatever was latest at the time

Hi @neoakris , thanks for opening this issue!
Wow, now that's unfortunate O.o
So k3d doesn't do anything other than running K3s containers in Docker. An important part here that is probably related to your issue is that K3s has to run in docker's privileged mode (due to Kernel requirements), giving it access to the host system.
Now you're running Rook there which on top of that also gets admin privileges for parts of your system as showed in the manifests, effectively giving it access to your physical host devices.
Given that the prerequisites state that it requires some sort of pure disk as storage (https://rook.io/docs/rook/v1.7/quickstart.html#prerequisites), I assume that it just took whatever comes first there.
Note: This seems to be about devices, not about filesystems (where indeed the container root filesystem is isolated, i.e. it does not have access to your host's rootfs)

Amusingly, I got bit by this exact issue but under k3os. Spun up a new instance, applied MetalLB, and
kubectl apply -f crds.yaml
kubectl apply -f common.yaml
kubectl apply -f operator.yaml
kubectl apply -f cluster-test.yaml

Went to go grab a drink from the fridge and chat with the fiancee. Came back to the console (iDRAC) spitting errors that k3s couldn't log to /var/log/.
Probably something with the operator's detection of the root disk failing.

Dupe of rook/rook#9470

Thanks for the input @crdnl and the in-depth testing that you did in the rook issue!
Closing this issue here in favor of your linked rook issue, as I doubt we can do anything to prevent this really.
Thanks again!


Adding Runtime option in JobCommand for updated CloudFormation config

Link:
https://docs.aws.amazon.com/glue/latest/webapi/API_JobCommand.html
Currently Ray runtime option specification is not possible in Troposphere and adding the option can enable the same.

Thank you for the PR. This is an auto-generated file and a recent update from the spec files has included this change.


[iOS]: Wrong pod reference

The ios version use the old JLToast but the pod reference the new Toaster. Following error occured: file:///app/tns_modules/nativescript-toast/toast.js:9:19: JS ERROR ReferenceError: Can't find variable: JLToast

I think it should be Toast(...) instead of Toaster(...) according to the Toaster documentation.
But now im getting the following error: file:///app/tns_modules/nativescript-toast/toast.js:9:17: JS ERROR Error: Value must be a Pointer.
Any ideas?

yes you're right.


Increment tasksToLaunch only for TaskOp.Launch rejections

Part 1: only the fix for task launch increments. Will make the change to the QueuedTaskInfo as a separate PR.

Hey Matthias, LGTM so far regarding the actual change. As commented, there's another flaw while handling the TaskOpRejected. Can you have a look please?


Stackdriver logs do not show

This might not be an issue it could be me doing something incorrectly.
I have the following in /etc/google-fluentd/config.d/api.conf:
<source>
    @type tail
    format none
    path /opt/api/var/log/*.log*
    pos_file /var/lib/google-fluentd/pos/api.pos
    read_from_head true
    tag structured-log
</source>

As per the guide here https://cloud.google.com/logging/docs/agent/configuration
With the following in my application config:
config :logger, backends: [LoggerJSON]
config :logger_json, :backend, json_encoder: Jason

With this configuration the log message is in textPayload as expected however if I change format in the fluentd conf file from format none to format json the logs never arrive 🤷♂

@mynameisrufus I'm not sure how to configure standalone fluentd worker to integrate with Stackdriver, can only tell that we use LoggerJSON in staging and production Kubernetes clusters on GKE and they work without changing any fluentd configuration.

@AndrewDryga thanks for the reply. I'm going to just log text for now as I don't actually structured logs at this stage it was just a nice to have.


add log message for sealer apply

Describe what this PR does / why we need it

add log message for apply, include creating cluster, scaling up cluster, installing applications ,
delete redundant cobra flag: Clusterfile.

Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Base: 21.71% // Head: 21.71% // No change to project coverage :thumbsup:

Coverage data is based on head (81b2d33) compared to base (c854d89).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1827   +/-   ##
=======================================
  Coverage   21.71%   21.71%
=======================================
  Files          72       72
  Lines        6566     6566
=======================================
  Hits         1426     1426
  Misses       4954     4954
  Partials      186      186

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

LGTM

/LGTM


[FacebookBridge] Fix permalink issue

Facebook has changed their strategy regarding permalinks, which
now include lots of unnecessary target data. Fortunately it also
contains the unique story id which we can utilize as URI.
Closes #969
It seems to work on my end (link points to the story), but I'd like some feedback from actual users before merging.

Your code works for me but none of my feeds were affected by the permalink issue. I wonder if the two different link formats depends on whether the Facebook page was initially set up as a "Business" or a "Community" page.

Thanks for your feedback, really appreciate it.

I wonder if the two different link formats depends on whether the Facebook page was initially set up as a "Business" or a "Community" page.

Perhaps, yes. Unfortunately there is no way to know for sure, but as long as it works :man_shrugging:


[SPARK-26002][SQL] Fix day of year calculation for Julian calendar days

What changes were proposed in this pull request?
Fixing leap year calculations for date operators (year/month/dayOfYear) where the Julian calendars are used (before 1582-10-04).
How was this patch tested?
With a unit test ("SPARK-26002: correct day of year calculations for Julian calendar years") which focuses to these corner cases.
Manually:
scala> sql("select year('1500-01-01')").show()

+------------------------------+
|year(CAST(1500-01-01 AS DATE))|
+------------------------------+
|                          1500|
+------------------------------+

scala> sql("select dayOfYear('1100-01-01')").show()

+-----------------------------------+
|dayofyear(CAST(1100-01-01 AS DATE))|
+-----------------------------------+
|                                  1|
+-----------------------------------+

Test build #98682 has finished for PR 23000 at commit f2bc0b2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98682/
Test PASSed.

ping @10110346 @gatorsmile

Test build #99054 has started for PR 23000 at commit 421673a.

lgtm

Test build #99054 has finished for PR 23000 at commit 421673a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99054/
Test PASSed.

Retest this please.

Test build #100216 has started for PR 23000 at commit 421673a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6193/
Test PASSed.

Test build #100216 has finished for PR 23000 at commit 421673a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100216/
Test PASSed.

cc @cloud-fan , @gatorsmile , @mgaido91

what was the behavior before this PR?

@cloud-fan It was off by one (at least at 1500, with each 100 years back in time the difference increases) as I described in the Jira:
scala> sql("select dayOfYear('1500-01-02')").show()
+-----------------------------------+
|dayofyear(CAST(1500-01-02 AS DATE))|
+-----------------------------------+
|                                                           1|
+-----------------------------------+

scala> sql("select year('1500-01-01')").show()
+------------------------------+
|year(CAST(1500-01-01 AS DATE))|
+------------------------------+
|                                            1499|
+------------------------------+

scala> sql("select month('1500-01-01')").show()
+-------------------------------+
|month(CAST(1500-01-01 AS DATE))|
+-------------------------------+
|                                                   12|
+-------------------------------+

scala> sql("select dayOfYear('1500-01-01')").show()
+-----------------------------------+
|dayofyear(CAST(1500-01-01 AS DATE))|
+-----------------------------------+
|                                                      365|
+-----------------------------------+

cc @MaxGekk who is touching this

@gatorsmile Thanx for the ping. Actually current implementation support Proleptic Gregorian calendar even if it is not documented explicitly. Recently we switched on this chronology for parsing/formatting date/timestamps  in JSON/CSV datasource (see #23150 and #23196) and in functions (see #23358).
If we support the hybrid calendar (Julian + Gregorian) here, it will introduce additional inconsistency.
@attilapiros If you need the hybrid calendar for some reasons, you should extend the Year expression by additional argument to set chronology (calendar system) otherwise you can break user's apps potentially.

@MaxGekk thanks for the explanation, but I still a bit uncertain.
My main intention was about correcting the dayOfYear/month/year operators as the result in the following example are very strange (and not consistent with PostgreSQL too):
scala> sql("select year('1500-01-01')").show()
+------------------------------+
|year(CAST(1500-01-01 AS DATE))|
+------------------------------+
|                          1499|
+------------------------------+

scala> sql("select month('1500-01-01')").show()
+-------------------------------+
|month(CAST(1500-01-01 AS DATE))|
+-------------------------------+
|                             12|
+-------------------------------+

scala> sql("select dayOfYear('1500-01-01')").show()
+-----------------------------------+
|dayofyear(CAST(1500-01-01 AS DATE))|
+-----------------------------------+
|                                365|
+-----------------------------------+

Running the corresponding expressions in PostgreSQL 9.6:
>    SELECT DATE_PART('year', TIMESTAMP '1500-01-01 0:0:0') as "year";

| year |
| ---- |
| 1500 |

>   SELECT DATE_PART('month', TIMESTAMP '1500-01-01 0:0:0') as "month";

| month |
| ----- |
| 1     |

>  SELECT DATE_PART('doy', TIMESTAMP '1500-01-01 0:0:0') as "doy";

| doy |
| --- |
| 1   |

View on DB Fiddle
Is there any other DBMS I can take as a reference?

Test build #100692 has started for PR 23000 at commit 300ec39.

Test build #100692 has finished for PR 23000 at commit 300ec39.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100692/
Test PASSed.


Allowing f2, n2, and o2 (default) parity on RAID10

RAID10 should support a parity setting (in this case really meaning the layout), of at least "f2", "n2", and "o2", though this should probably be expanded a bit to allow more exotic configurations (meaning integers other than '2'). From the man page for mdadm:
          Finally, the layout options for RAID10 are one of 'n', 'o'  or
          'f'  followed  by  a  small number.  The default is 'n2'.  The
          supported options are:

          'n' signals 'near' copies.  Multiple copies of one data  block
          are at similar offsets in different devices.

          'o'  signals  'offset'  copies.   Rather than the chunks being
          duplicated within a stripe, whole stripes are  duplicated  but
          are rotated by one device so duplicate blocks are on different
          devices.  Thus subsequent copies of a block are  in  the  next
          drive, and are one chunk further down.

          'f'  signals 'far' copies (multiple copies have very different
          offsets).  See md(4) for more detail about  'near',  'offset',
          and 'far'.

          The  number  is  the number of copies of each datablock.  2 is
          normal, 3 can be useful.  This number can be at most equal  to
          the  number  of  devices  in  the  array.  It does not need to
          divide evenly into that number (e.g. it is perfectly legal  to
          have  an  'n2'  layout  for  an  array  with  an odd number of
          devices).

Hi, thanks for the PR! Can you add some test coverage?

You don't appear to have any test coverage for RAID10 at all, so writing tests for these parity changes will take some doing. I'll work through it but it'll take a bit.

hi guys, can I help somehow to move on with merging of this PR?

Looking over the code, i think just adding a test that verifies setting the options fails on non raid5/6/10. Also, the tests seem to be failing on a bundler install which is weird. I'll look into that.

So I unpinned the rspec-puppet fork in https://github.com/chartbeat-labs/puppet-mdadm/pull/13 and travis tests passed for 1.9.3. Since the unit tests themselves passed (at least in ruby2.0.0 tests) this looks good to me. Thanks @jgnagy and @arteal! I will a 1.1.0 release shortly.


New release

Can you add new tag for last commit?
SMP can't fetch last version(

@AppleArealidea I set 0.4.0 tag on master! Sorry for late reply.


@Embedded kotlin fails to compile

@Entity
interface Person : Parcelable, Persistable {
    @get:Key
    @get:Generated
    val id: Int

    var name: String

    ...

    @get:Embedded
    var picture: Picture
}

@Embedded
interface Picture : Parcelable, Persistable {

    var thumbnail: String?

    var original: String?
}

The result is

FAILURE: Build failed with an exception.
What went wrong:
Execution failed for task ':requery-android:example-kotlin:compileDebugJavaWithJavac'.
Compilation failed; see the compiler error output for details.

Java version works fine.
@Entity
public interface Person extends Observable, Parcelable, Persistable {

    @Key @Generated
    int getId();

    @Bindable
    String getName();

    ...

    @Embedded
    Picture getPicture();
}

@Embedded
public interface Picture {

    @Nullable
    String getOriginal();

    void setOriginal(String original);

    @Nullable
    String getThumbnail();

    void setThumbnail(String thumbnail);
}

In this case the actual error is Error:(32, 7) Gradle: error: PersonEntity is not abstract and does not override abstract method setPicture(Picture) in Person
This is because 'picture' was declared as var it should be declared as val, to fix the compilation. The reason setters aren't generated for embedded types is that it prevents common mistakes of overwriting all the embedded value fields.

Thanks

@npurushe I've changed it to val and still doesn't work.
@get:Embedded
val picture: Picture

stacktrace.txt


table tags

can we have tables and associated tags?

@GingaNinja certainly can. It's "just" a case of adding the definitions.
I do have plans to code generate all definitions from the HTML 5 spec, but for now the definitions are crafted by hand with code generator support (where "definitions" is defined as elements and their respective attributes).
I'll put together a quick PR for the obvious elements like <table>, <tr> and <td> along with a wiki outlining the steps I followed so that hopefully others can help contribute the missing pieces.

thanks @myitcv , I did actually start looking at how to do it, and at least managed to add the table tag, so if I beat you to it, are you taking contributions?

Absolutely!

@GingaNinja - please take a look at https://github.com/myitcv/react/pull/99 which I've just merged for an example of how to add additional elements.

This has been done via #137 and #141.


support reading config file from hdfs

close https://github.com/vesoft-inc/nebula-exchange/issues/84

Codecov Report
Base: 55.67% // Head: 55.46% // Decreases project coverage by -0.20% :warning:

Coverage data is based on head (bbdb414) compared to base (b86efc5).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #106      +/-   ##
============================================
- Coverage     55.67%   55.46%   -0.21%
  Complexity       81       81
============================================
  Files            17       17
  Lines          1419     1426       +7
  Branches        267      268       +1
============================================
+ Hits            790      791       +1
- Misses          489      494       +5
- Partials        140      141       +1

Impacted Files
Coverage Δ

...la/com/vesoft/exchange/common/config/Configs.scala
61.55% <20.00%> (-0.58%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add Volume # Zero Padding

In the same way as there is issue # zero padding, can we get one for volume # zero padding as well please or at least a check where it will always be 2 digits if there is data? Thanks!

Normally you can do this with {volume:02} but I broke it so you'll be able to do it in another release I make later today

Version 1.4.7 has been released.


Inconsistent Cast Hash Format Between Local and Prod for validateMessage

Hello,
While validating a frame message via the local debugger's hub endpoint (e.g., http://localhost:3010/hub/v1/validateMessage), the response returns the cast hash in base64 format.
Response:
{
  "data": {
    "type": "MESSAGE_TYPE_FRAME_ACTION",
    "fid": 289309,
    "timestamp": 118494389,
    "network": "FARCASTER_NETWORK_MAINNET",
    "frameActionBody": {
      "url": "aHR0cDovL2xvY2FsaG9zdDozMDAwL21jYS9hY3Rpb24=",
      "buttonIndex": 1,
      "castId": {
        "fid": 16904,
        "hash": "t3mIjAxGlazXdgaZpcJ117ZvEPg="  // Cast hash is base64 encoded
      },
      "inputText": "",
      "state": "",
      "transactionId": "",
      "address": ""
    }
  }
}

However, when using the production hub endpoint (e.g., https://hub-api.neynar.com/v1/validateMessage), the response returns the cast hash as a hexadecimal string.
Response:
{
  "data": {
    "type": "MESSAGE_TYPE_FRAME_ACTION",
    "fid": 8408,
    "timestamp": 100285861,
    "network": "FARCASTER_NETWORK_MAINNET",
    "frameActionBody": {
      "url": "aHR0cDovL2ZyYW1lcy5haXJzdGFjay54eXovYWk=",
      "buttonIndex": 1,
      "castId": {
        "fid": 8408,
        "hash": "0x0000000000000000000000000000000000000001"  // Cast hash is in hex string
      },
      "inputText": "",
      "state": "",
      "transactionId": ""
    }
  }
}

This inconsistency between the local and production endpoints (base64 vs. hexadecimal) causes issues in using cast hash. Could you please clarify if this difference is intentional.
Thank you!

Hi @kaushalmeena thanks for flagging this. I believe I have seen this issue elsewhere before (https://warpcast.com/stephancill/0xad807ec7), will look into it here


is there any way to support the macOS?

I have a Mac Studio with Apple M2 Ultra. Is there any way to run the code on my Mac?

I have a MacBookPor with Apple M4 Max. Is there any way to run the code on my Mac?


Config values not saved

I fill in the settings at /settings/admin/additional, but when I go to another page and visit it later, the boxes are again empty, and there is no button where I can force the settings to be saved.

Please have a look at #53. If this doesn't solve your issue, please report back.


Bump fails on expect

Details here: https://github.com/ZOSOpenTools/expectport/actions/runs/6755634742/job/18364261073

buildenv:1: 'https://sourceforge.net/projects/expect/files/Expect/|re:/latest(.)expect([\d.]+).tar.gz/$2/|semver:': no filter matches
FYI @v1gnesh

Still seems to be an issue:
buildenv:1: 'https://sourceforge.net/projects/expect/files/Expect/|re:/Click.to.enter.([\d.]+)"/$1/|semver:*': no filter matches


WIP: Added RetryWithBackoff Operator

@Avasil this is my attempt at the operator you mentioned.
I used the tests from the OnErrorRetryCountedObservableSuite, I don't quite understand how they work exactly, so some pointers would be nice :-).
I could add in some more Backoff Strategies, like Linear and Fibonacci as well, which could be useful to have.
PS: It seems Scalafmt changed some things I didn't intend for it to change.

I used the tests from the OnErrorRetryCountedObservableSuite, I don't quite understand how they work exactly, so some pointers would be nice :-).

I'm also often confused by Sample but it helps us get quite a few of tests for free.
case class Sample(
  // Tested Observable
  observable: Observable[Long],
  // Number of total elements it should emit
  count: Int,
  // Sum of all elements it should emit
  sum: Long,
 // How much time should we wait for the first element
  waitFirst: FiniteDuration,
 // How much time should we wait for each element after the first
  waitNext: FiniteDuration
)

def createObservable(sourceCount: Int) = Some {
  val ex = DummyException("expected")
  val o = Observable
    .range(0, sourceCount)
    .endWithError(ex)
    .onErrorRestart(3)
    .onErrorHandle { case _ => 10L }

  val count = sourceCount * 4 + 1
  val sum = 1L * sourceCount * (sourceCount - 1) / 2 * 4 + 10
  Sample(o, count, sum, Duration.Zero, Duration.Zero)
}

o will emit an error after sourceCount elements. After each error, it will restart 3 times (so 4 runs in total) and when it will give up and emit an error downstream then it will be handled with onErrorHandle { case _ => 10L } (hence + 1 in count and + 10 in sum).
There isn't any delay between elements so waitFirst and waitNext is Duration.Zero.
I think we will need few extra tests because BaseOperatorSuite doesn't really handle exponential delays between elements. In case of retrying Observable it would be nice to have resetting backoff, i.e.:
next elem
next elem
fail // waits 1 s
fail // waits 2 s
fail // waits 4 s
next elem
next elem
fail // waits 1 s (instead of 8 s)

If the application is long running then the delay between retries could become ridiculously big without it if we sometimes lose source connection. An example test for it:
  test("Observable.onErrorRestartWithBackoff resets the delay after success") { implicit s =>
    val dummy = DummyException("dummy")

    val source = Observable
      .range(0, 100)
      .flatMap(n => if (n == 2) Observable.raiseError(dummy) else Observable.now(n))
      .onErrorRetryWithBackoff(10, 1.second)
      .takeByTimespan(5.second)
      .toListL

    val f = source.runToFuture

    s.tick(5.second)
    assertEquals(f.value, Some(Success(List(0, 1, 0, 1, 0, 1, 0, 1, 0, 1))))
  }

I suppose it's not quite consistent with onErrorRestart so maybe we could hide it behind a flag or something

I could add in some more Backoff Strategies, like Linear and Fibonacci as well, which could be useful to have.

It would be nice to allow users to configure it, maybe let them pass a function with few predefined ones?

I'm curious about the use case for this.


State space model reduction bug fix

Fixes bug in StateSpaceModel.reduce_model. Thanks to Patrick for finding this! No issue created.

[x] Reference the issue your PR is fixing
[x] Assign at least 1 reviewer for your PR
[x] Test with run_dwelling.py or other script
[x] Update documentation as appropriate
[x] Update changelog as appropriate

All bugs should be fixed now, ready to merge.
Note that this was tested with run_dwelling, but it wasn't validated. Users should make sure to validate and compare full envelope and reduced envelope models before using that method!


Confirm with Particular that what I have here is ok

@simoncropp ok, so this is the project that I was telling you about.  I have taken the existing Particular Project from here: https://github.com/Particular/GitHubReleaseNotes and made a few modifications, and I wanted to confirm with you what else needs to be done to ensure that I am doing things "right" in terms of the MIT license.
What I have done breaks down to the following high level items:

Renamed Projects to GitHubReleaseManager, rather than GitHubReleaseNotes as I felt this better describes the intent of the application
Added psake as orchestrator of Build Process
Added StyleCop to Build Process
Added Code Analysis to Build Process
Added DupFinder to Build Process
Added InspectCode to Build Process
Added new nuget package for DLL of GitHubReleaseManager (in addition to exe nuget packages), which could be consumed in other applications.  DLL will be deployed to nuget, exe will be deployed to chocolatey
Added new functionality to Export all Release Notes, Close Milestone, Add Individual Assets
Added ability to configure options for both Release Notes generation, and export.  This uses a YAML configuration file, very similar to what GitVersion does.  This includes the ability to say what labels should be used, which ones should be ignored, whether to include the footer, what text to include in footer, etc.
Removed Particular specific "things" i.e. mention of your Repo's for the Integration Tests.  Not that I could, but I didn't want to make any changes/problems for your repos, so I thought it best to use other repo's that I am in control of
Removed GitVersionTask in favour of running GitVersion.exe
Removed NugetPackager, in favour of doing this within psake build script

So, a couple questions that I have that I am hoping you can help with.

As per the MIT license on https://github.com/Particular/GitHubReleaseNotes I have left the LICENSE.md file in tact in this repository.  Do you know if I simply add to this to apply my own copyright, or do I need to create another file?  If another file, any ideas on what this would be named?
One of the StyleCop rules is to apply a Copyright Header to all .cs files.  Now, I have done that, using a Copyright Header including me, i.e. gep13.  Was this the "right" thing to do?  I have basically modified all the files to fit in with my way of doing things, in terms of naming conventions, etc, but I am wondering whether the Particular Copyright should be included as well.  I am happy to add this in, hence the reason for creating this issue :-)

Please let me know if you have any questions/concerns, and I am happy to make any changes that you deem required.
Would also love some feedback as to what the new version of the application does.  You can see it in action here:
Create Release:
https://github.com/chocolatey/ChocolateyGUI/blob/develop/BuildScripts/default.ps1#L651
Export Release Notes:
https://github.com/chocolatey/ChocolateyGUI/blob/develop/BuildScripts/default.ps1#L669
Upload Assets to Release:
https://github.com/chocolatey/ChocolateyGUI/blob/develop/BuildScripts/default.ps1#L686
Close Milestone:
https://github.com/chocolatey/ChocolateyGUI/blob/develop/BuildScripts/default.ps1#L686
So now, the workflow for ChocolateyGUI looks something like this:

Create Pull Request into master
Build executes with no deployment, or creation of release
Merge into master
Build executes with deployment to MyGet, and creation of release notes
Manually go to GitHub and confirm that the release notes are correct.  Use deployment to MyGet for final testing of application
Publish the release, which assigns a tag to the repository
Build executes, which exports the release notes and includes them in generated MSI, milestone is closed, publish to chocolatey, upload assets to GitHub

Personally, I think this has come together really nicely, but again, I would love to hear your thoughts on it.
Thanks!

At the minute, I have left the README.md to be the same as it was, but I would plan to update that also to make it specific to this repository.  I would also be here that I would make it clear where the origin's of this project comes from.

@gep13 I am happy for you to apply "this is not a substantial portions of the Software" provision of MIT and remove that copywrite if you want to apply your own. MIT is more about stopping us from getting sued than "maintaining a trail of who wrote what". And witht he changes you are doing it is more a case of "inspired by our work" than "copying it". Happy instead with a small blurb at the bottom of your readme along the lines of "inspired by code written by particular software"

re the rule "One of the StyleCop rules is to apply a Copyright Header to all .cs files. ". i detest that approach. now every time i open a cs file there is a waste of my screen before i can see the actual class.
I would just drop it. most projects dont follow it

Thanks for getting back to me.  I will make the necessary changes and maybe follow up with you after that.  :+1:

I believe I have made the required changes here.  You can see the addition in the Readme Documentation here:
https://github.com/gep13/GitHubReleaseManager#credits
Going to close this issue, but let me know if there is anything else I need to do.


DataPlane: support PodDisruptionBudget

Problem statement
Users might want to specify the allowed disruption budget for their DataPlane workloads to configure e.g. how many replicas can be down during an upgrade.
Proposed
Support enabling a spec field in DataPlane API which will deploy and managed PodDisruptionBudget targeting the DataPlane instances.
Acceptance criteria

[ ] As a user I can set a DataPlane field and expect a PodDisruptionBudget to be created and managed for me accordingly
[ ] A guide on how to set this exists under https://docs.konghq.com/gateway-operator/

@sentinelleader The PR with proposed API changes has been created: https://github.com/Kong/gateway-operator/pull/441.
The implementation will follow after this is merged.


Add z-index to custom buttons

Prevents clickable surface hiding under other elements.
One example where this can happen is if a user shares a post to their story and they adjust the position of the post so that it overlaps the button.  (Yes, some people do have the post flying off the top-right corner of the screen, rather than leaving it in the center where you can see it. 😂)
Tested the fix and verified it works in said situation.  And only the anchor element needs to be adjusted, because the download icon was still visible, I just couldn't click it without triggering Instagram's popup text prompting me to view the post.

LGTM.


pull request for e2e test at 12/11/2016 04:15:03

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.