fix: hide new workspace button to accounts already has workspace

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/47567
PROPOSAL: https://github.com/Expensify/App/issues/47567#issuecomment-2293712564
Tests

User A adds user B to WS
Login as user B
Click on FAB
Verify that: "New workspace" button is not shown

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

User A adds user B to WS
Login as user B
Click on FAB
Verify that: "New workspace" button is not shown

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/21a31204-7e75-4c44-b875-12dd0ac28793

Android: mWeb Chrome
https://github.com/user-attachments/assets/6fd2f08c-dcc1-4351-8522-2df794051599

iOS: Native
https://github.com/user-attachments/assets/498ba3cc-38f6-4050-ac7a-5cbc5a727c52

iOS: mWeb Safari
https://github.com/user-attachments/assets/7d22f693-d1d9-462a-9b42-9d48f0772561

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/ffc853d5-06ea-4d44-8239-f5c5f6e16a69

MacOS: Desktop
https://github.com/user-attachments/assets/8464d9ea-f89b-4353-805f-dca2a7801d8d

@thesahindia please retest

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.25-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Add navigation bar and logout

Overview
Implement a navigation bar with logout. Placeholders for selected and available utilities for now.
Closes #85
Demo
Submissions activity

Draw activity

Notes
Minor nit: the updated wireframe says "Save & Back" but the prior draw tool had "Save and back". I opted for the existing wording "Save and back" to match "Review and submit".
Settings button is just a placeholder.
Testing Instructions

scripts/server
Visit draw activity

[x] Ensure static utility label
[x] Check styling against wireframe
[x] Ensure save and back button navigates to submissions

Visit submissions activity

[x] Ensure utility selector
[x] Check styling against wireframe
[x] Ensure log out button is functional

Verify welcome tool has no nav bar
Check Draw tool sidebar no longer has its own title bar
Sanity check draw and welcome tools for regressions

Checklist

[x] fixup! commits have been squashed
[x] CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines
[x] README.md updated if necessary to reflect the changes
[x] CI passes after rebase

I'm noticing that navigating back to the submissions page after adding a reference image isn't working. This seems unrelated to your changes though (and would probably happen in dev if there were a link to test it with).

Good spot. I can reproduce on develop by clicking back button from draw page back to welcome (after having uploaded a ref image). I'll open an issue.

Thanks for the reviews!


Improving speed of feature generation on the Juries Dataset

^ oops typo in my last commit message --- I deleted the v1 file of the liwc features, since we'll probably never use them again, haha!

^ oops typo in my last commit message --- I deleted the v1 file of the liwc features, since we'll probably never use them again, haha!

Great! I guess we are not looking back anymore!


wayvnc, wlvncc

Hi Himmalerin, not sure if you're interested in having these packages in your repo:
wayvnc - wayland vnc server
wlvncc - wayland vnc client
...plus libvncserver, which they depend on.
Have tested this on a few different machines. Also worked OK connecting to a wayvnc server using TigerVNC on Windows.

Sorry for the late reply. I don't use any vnc stuff, but if it's wayland it's (probably) welcome here! Mind squashing the commits? After that I'd be glad to merge it.

Commits squashed.

thanks!


Rename the mongo interface to be more specific

See, e.g., mongodb-datasource or something that expresses "I want to QUERY mongo" while leaving naming space for other relations powered by mongo, like a hypothetical "mongo-administration" if someone goes and charms Mongo OpsManager.

The MongoDB charm has changed the name to mongodb_datastore (note underscore) as the relation interface name for its consumer charms. In view of this I am closing this ticket.


Webgl Support

Feature Description
Is this plugin supported for unity webgl?
Current Behaviour/State
No response
Additional Context
No response

duplicates #49


MP:0010948 typo

abnormal double-strand DNA break repair MP:0010948
Correct typo in textual definition: any annomaly in the process of repair of double-strand breaks in DNA via homologous and nonhomologous mechanisms to reform a continuous DNA helix

Typo has been corrected.


Kong Rate Limiting Plugin not working as expected when limit by path

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
2.5
Current Behavior
When I add Rate Limiting plugin, I do this following step :

set config.limit_by with path
set config.path with /abc
hit other path like /zxc

Kong also do rate limit in /zxc path
Expected Behavior
I assume Kong didn't rate limit it.
Then I check this line :
https://github.com/Kong/kong/blob/009ee44a11b1d6d3fd5426a0b79f4892152f48ad/kong/plugins/rate-limiting/handler.lua#L73
And
https://github.com/Kong/kong/blob/009ee44a11b1d6d3fd5426a0b79f4892152f48ad/kong/plugins/rate-limiting/handler.lua#L79
When request_path didn't same with config.path why Kong didnt bypass it ? But, he change identifier to forwarded ip ?
Steps To Reproduce

set config.limit_by with path
set config.path with /abc
hit other path like /zxc

Anything else?
No response

We are seeing this issue as well with the Advanced Rate Limiting Plugin. It doesn't seem like matching by path is actually matching any paths specified, and is applied to the lot.

@Clint-Chester The Rate Limiting Advanced plugin is an enterprise feature - Please reach out to your support contact for assistance.  Thank you!

@Clint-Chester The Rate Limiting Advanced plugin is an enterprise feature - Please reach out to your support contact for assistance. Thank you!

Thanks @hanshuebner, tried the standard Rate Limiting Plugin and got the same behaviour unfortunately.

@Clint-Chester I'm going to re-open this ticket.  You may get expedited responses through the enterprise support channel, though.

Current configuration is the following.
apiVersion: configuration.konghq.com/v1
kind: KongPlugin
metadata:
  name: website-login-rate-limiting
plugin: rate-limiting
config:
  limit_by: path
  path: /api/login
  minute: 70
  sync_rate: -1
  hide_client_headers: true
  error_message: "Login Rate Limit Exceeded"

With the following as my Ingress Controller Configuration.
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: web-ingress
  annotations:
    konghq.com/plugins: website-login-rate-limiting
spec:
  ingressClassName: kong
  rules:
  - host: "website.com"
    http:
      paths:
      - pathType: Exact
        path: "/api/login"
        backend:
          service:
            name: web-api-backend
      - pathType: Prefix
        path: "/"
        backend:
          service:
            name: web-frontend

Is the behaviour that it's going to try and match all paths?
Thanks for re-opening @hanshuebner, appreciate it! We've got Enterprise Support Open as well but was very interested in seeing if others had experienced this in the past.

@Clint-Chester By the name ("login") I guess we are configuring it to have smaller limitations than general requests?
limit-by uses a fallback mechanism to determine its limit scope, that is if the request path does not match the configured path, it will use IP to limit the request. So the behavior is kind of expected.
I also feel this behavior makes little sense. I'm looking for more information and opinions about this.

I can't comment on the rate limiting defaults, but to achieve what you're looking for with Ingress you can define two Ingress resources:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: login-ingress
  annotations:
    konghq.com/plugins: website-login-rate-limiting
spec:
  ingressClassName: kong
  rules:
  - host: "website.com"
    http:
      paths:
      - pathType: Exact
        path: "/api/login"
        backend:
          service:
            name: web-api-backend
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: web-ingress
spec:
  ingressClassName: kong
  rules:
  - host: "website.com"
    http:
      paths:
      - pathType: Prefix
        path: "/"
        backend:
          service:
            name: web-frontend

The konghq.com/plugins annotation applies to all routes in an Ingress definition, which means they should be split if you only want the plugin to apply to specific routes

@Clint-Chester By the name ("login") I guess smaller limitations are configured than general requests? limit-by uses a fallback mechanism to determine its limit scope, that is if the request path does not match the configured path, it will use IP to limit the request. So the behavior is kind of expected. I also feel this behavior makes little sense. I'm looking for more information and opinions about this.

Yes that's correct, it would be looking to have a smaller limit on a particular path.
So the behaviour in this example is that you'd want to be mitigating a DDoS attack or a credential stuffing attack used a bot network. Rate limiting by IP address doesn't work here because the attack is cycling through different IP addresses. By doing rate limiting via the path, it acts as a kill switch on the API to slow down the damage.
Is there something missing in my path matching? As I've tried a lot of different combinations to no avail.

I can't comment on the rate limiting defaults, but to achieve what you're looking for with Ingress you can define two Ingress resources:
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: login-ingress
  annotations:
    konghq.com/plugins: website-login-rate-limiting
spec:
  ingressClassName: kong
  rules:
  - host: "website.com"
    http:
      paths:
      - pathType: Exact
        path: "/api/login"
        backend:
          service:
            name: web-api-backend
---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: web-ingress
spec:
  ingressClassName: kong
  rules:
  - host: "website.com"
    http:
      paths:
      - pathType: Prefix
        path: "/"
        backend:
          service:
            name: web-frontend

The konghq.com/plugins annotation applies to all routes in an Ingress definition, which means they should be split if you only want the plugin to apply to specific routes

I did actually try this but it still didn't seem to work. It makes me think that what @StarlightIbuki was talking about that the path match must not have been detecting at all, and it was defaulting to IP rate limiting.

@Clint-Chester The plugin falls back to limit by IP when the request path does not match the configured one. I do not understand the design's intention so I'm trying to confirm.

The fallback mechanism seems to be introduced when we have only consumer and credential for limit-by, and it can't take later introduced type into consideration.
Please refer to the doc:

If the underlying service or route has no authentication layer, the Client IP address is used. Otherwise, the consumer is used if an authentication plugin has been configured.

I think it makes no sense to fall back when we limit by path.

If there is no fallback, when limit by path fails, it is equivalent to no limit, which is similar to bypass.

We had a discussion and this seems a legacy of old design, which makes the limit by path not useful at all. We are going to redesign the plugin. For now, a possible workaround is to have the path limited split to a separate route and config the plugin on it. @cunkz @Clint-Chester

Hello @StarlightIbuki,
Can I know possible fix date of this bug?
Thanks

Hello !
I just found this issue after opening a discussion on this subject.
I think the fix is quite simple, and I can open a PR for it if it helps. Just tell me

Hello !
I just found this issue after opening a discussion on this subject.
I think the fix is quite simple, and I can open a PR for it if it helps. Just tell me

Yes, please! Thanks for your kind offer. Contributions are welcomed.
Also refer to https://github.com/Kong/kong/blob/master/CONTRIBUTING.md

Hello !
I just found this issue after opening a discussion on this subject.
I think the fix is quite simple, and I can open a PR for it if it helps. Just tell me

Hi. Thanks for your kind offering. This is more of a design issue than an implementation bug, and unfortunately, it did not draw enough attention for a production decision. I'm creating an internal ticket and asking for comments.
Tracked by KAG-5426
Personally, I agree with the solution you proposed (that's also the same as I thought of). PRs are welcome. Please refer to https://github.com/Kong/kong/blob/master/CONTRIBUTING.md


Add wget to build container

When trying to build the docker image using a CUDA base container (e.g. ghcr.io/livebook-dev/livebook:latest-cuda12.1), I got this error here:
#0 38.82 could not compile dependency :exla, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile exla --force", update it with "mix deps.update exla" or clean it with "mix deps.clean exla"
#0 38.82 ** (RuntimeError) expected either curl or wget to be available in your system, but neither was found
#0 38.82     (xla 0.5.1) lib/xla.ex:221: XLA.assert_network_tool!/0
#0 38.82     (xla 0.5.1) lib/xla.ex:180: XLA.download_matching!/1
#0 38.82     (xla 0.5.1) lib/xla.ex:33: XLA.archive_path!/0
#0 38.82     /app/deps/exla/mix.exs:112: EXLA.MixProject.extract_xla/1
#0 38.82     (mix 1.15.7) lib/mix/task.ex:527: Mix.Task.run_alias/6
#0 38.82     (mix 1.15.7) lib/mix/tasks/compile.all.ex:124: Mix.Tasks.Compile.All.run_compiler/2
#0 38.82     (mix 1.15.7) lib/mix/tasks/compile.all.ex:104: Mix.Tasks.Compile.All.compile/4
#0 38.82     (mix 1.15.7) lib/mix/tasks/compile.all.ex:93: Mix.Tasks.Compile.All.with_logger_app/2

Adding wget to the build container fixes it. We could also add it to elixir-cuda.dockerfile but then historic base images would still not work.
It's also possible that I've somehow done something else wrong and this actually isn't needed. I'm actually a little confused how any official cuda livebook images have been built without wget or curl in the build container

I would go ahead and add curl as well, @jonatanklosko's call. :)

@jonastemplestein ghcr.io/livebook-dev/livebook:latest-cuda12.1 already has wget, I just verified locally and installing :exla in iex works as expected. You said you get this error at build time, what is the Dockerfile that fails for you?

The main Dockerfile in this repo 🤔 I did think it was strange because that would have meant it's impossible for you to build any of the livebook cuda images

Ah sorry, I wrote the wrong image in my original post. I meant ghcr.io/livebook-dev/utils:elixir-1.15.7-erlang-26.1.2-cuda12.1
As you say, ghcr.io/livebook-dev/livebook:latest-cuda12.1 has wget, because it is installed here
But when the base image is ghcr.io/livebook-dev/utils:elixir-1.15.7-erlang-26.1.2-cuda12.1 the build stage fails at mix compile because exla needs wget or curl. I was just able to reproduce it.
I don't think it would make a difference, but I'm using fly.io to build the image. You can reproduce by dropping a skeleton fly.toml in that contains
[build.args]
  BASE_IMAGE = "ghcr.io/livebook-dev/utils:elixir-1.15.7-erlang-26.1.2-cuda12.1"

That makes sense, ghcr.io/livebook-dev/utils are just intermediate images that we use at build time, they should not be relied upon in general. I mean it's fine to use a specific image, because it's not going to be deleted, but there may be changes to future images at any point. So I would rather recommend copying the elixir-cuda.Dockerfile directly, which is not big and gives you full control over Elixir/OTP/CUDA versions :)

Okay, will do. That's actually how I started, with my own Dockerfile and it all worked fine. But then I thought "why maintain that if I can just use yours" 🤣 Would be neat if people could just use the existing Dockerfile in this repo to deploy straight to fly.io with one command
That said, I'm still not totally clear how you manage to build your cuda images like ghcr.io/livebook-dev/livebook:latest-cuda12.1. Wouldn't they also run into this issue? 🤔

To clarify, you want to deploy a Phoenix app, Livebook, or any Elixir/CUDA image to SSH into? What is the stuff you need in the image?

That said, I'm still not totally clear how you manage to build your cuda images like ghcr.io/livebook-dev/livebook:latest-cuda12.1. Wouldn't they also run into this issue? 🤔

The Livebook Dockerfile builds on top of configurable Elixir BASE_IMAGE, so the plain variant are built on top of hexpm/elixir:* image, while the CUDA variants are built on top of our Elixir/CUDA images pushed to ghcr.io/livebook-dev/utils.

Sorry, I've worked out the issue. wget is only used for the mix exla package, which livebook doesn't depend on. But my branch of livebook does. That's why you don't see the same issue.
I'll close this issue and will add wget in my own branch
Many apologies, I'm still rebuilding my brain after a few years in management and then looking after two small children 🙈

Ah, so you are literally deploying the Livebook Dockerfile to Fly and now it compiles EXLA when building the release. I was missing the full picture :D That explains it, yeah you can add wget to the Dockerfile to your branch as in this PR.
And totally no worries, questions are welcome :)


crash when searching for func_75250_a

MCP 9.08, Viewer 0.7.3
to reproduce put "func_75250_a" as search term and click go
An error has occurred - give bspkrs this stack trace (which has been copied to the clipboard)

java.lang.NullPointerException
    at bspkrs.mmv.McpMappingLoader$ParamModel.<init>(Unknown Source)
    at bspkrs.mmv.McpMappingLoader.getParamModel(Unknown Source)
    at bspkrs.mmv.gui.MappingGui$MethodTableSelectionListener.valueChanged(Unknown Source)
    at javax.swing.DefaultListSelectionModel.fireValueChanged(Unknown Source)
    ... 7 more

Fixed in 1.0.0


AVNM, IPAM, VNV updates for 2024-05-01 swagger

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command

General Guidelines

[ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
[ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
[ ] My extension version conforms to the Extension version schema

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.

Please update recording files to fix CI issues


RxView.clicks  and RxView.touches  used at the same time, only RxView.touches is useful

Hi Jake and everyone! Thanks for excellent job!
I think RxView.touches intercepted android event.How to change?
Here is the my code:
RxView.clicks(tvEffect).subscribe(o-> {showToast("click effect");});
`
ConnectableObservable motionEventObservable = RxView.touches(v).publish();
    // Capture down events
    motionEventObservable
            .filter(new Predicate<MotionEvent>() {
                @Override
                public boolean test(@NonNull MotionEvent motionEvent) throws Exception {
                    return motionEvent.getAction() == MotionEvent.ACTION_DOWN;
                }
            }).subscribe(new Consumer<MotionEvent>() {
                @Override
                public void accept(@NonNull MotionEvent motionEvent) throws Exception {
                    ObjectAnimator.ofFloat(v, "alpha",1.0f,0.3f).start();
                }
            });
    // Capture up/cancel events
    motionEventObservable
            .filter(new Predicate<MotionEvent>() {
                @Override
                public boolean test(@NonNull MotionEvent motionEvent) throws Exception {
                    return motionEvent.getAction() == MotionEvent.ACTION_UP
                            || motionEvent.getAction() == MotionEvent.ACTION_CANCEL;
                }
            }).subscribe(new Consumer<MotionEvent>() {
        @Override
        public void accept(@NonNull MotionEvent motionEvent) throws Exception {
            ObjectAnimator.ofFloat(v, "alpha",0.3f,1.0f).start();
        }
    });
    motionEventObservable.connect();`

Yes, the implementation of the onTouch() for the listener inside ViewTouchObservable will always consume all the emitted events, returning true, and this will prevent click events to be fired.
I think the only thing that you can do is to remove the click listener and recognize the click event using the motion events emitted from the Observable.

There's an overload for RxView.touches which takes two parameters: the source view and also a function which specifies the value to return. When you use the single-parameter version it always returns true, like @Joseph82 said. If you want the touch even to otherwise be propagated then you need to implement the two parameter version and return false for some or all events.

@Joseph82 @JakeWharton  thanks!
After reading ViewTouchObservable, I know why.


Deadlock in UnackedMessageTracker?

Hi there! I seem to be encountering a consumer hang when running this test project: https://github.com/vaalkor/PulsarTest
It hangs after printing this a few times:
warn: PulsarLogger[0]
mt/consumer(0, b016a) UnackedTracker 230 messages have timed-out
It hangs with pulsar.client 2.9 onwards. If I downgrade to 2.8.1 there's no hang. Turning off EnableRetry on the consumer changes the behaviour a lot. I'm not really sure what's happening here but I'd appreciate if you could shed any light on the matter. Thanks!
I'm running pulsar in docker and I've tried it with 2.8.3, 2.9.3, 2.10.1 and they all seem to behave similarly.

Hi! Thank you for reporting the issue. I'll look into the issue within several days. In 2.9 there was a major change in task library, this might be the cause. Right now task builders are context-sensitive, and we'll be able to move to context insensitive versions soon, since the fix  landed 4 days ago. So once new fsharp version is out, I'll release the version of Pulsar.Client with context-insensitive tasks anyway, and we'll be able to test your case again - will it help or not.

Interesting. That sounds like a plan. Thanks!

@vaalkor I think I've found the issue, published 2.10.3 with the fix, please test if it works for you

Closing as abandoned

@vaalkor I see, you are welcome to create another issue on the slowness concern.


CLI - generate resource and test with xml

Is your feature request related to a problem? Please describe.
At this moment, the user cannot generate a resource or test with the cli with xml format
Describe the solution you'd like
When the user enters in cli --xml, the application will create the resource and test example for xml

This issue is not longer needed in this project since we move the cli commands to  the following repository:
https://github.com/HecJimSan/stub-cli


Keyboard Manager

Description of the new feature / enhancement
The keyboard manager should have profiles for different keyboards.
Scenario when this would be used?
I use a laptop with us layout and an external HHKB keyboard. Want to change the internal layout to the HHKB layout, but only for the internal keyboard.
Supporting information
No response

/dup #1881


std::to_string in MSVC

std::to_string with an int parameter can't resolve in pre November 2012 versions of MSVC
cast parameter to (long long) works

Chris

I have added the cast for MSVC version 2010 or earlier
I have clarified the building instructions to use MSVC2010 or higher.

If you can confirm this works, I can close this issue, thanks.

Works fine on Win 10


Thank you for the Fork!

I'm the author of the original project (beabfc/afkdisplay) which this is mod based on.
I wrote the mod for a private server because I didn't like the other AFK mods on modrinth and figured I should publish it to help others. Unfortunately I do not have the time to maintain the mod and keep it up to date. I'm really busy at the moment and don't play as much Minecraft anymore. I never expected anyone else to take interest in this 'simple' project of mine.
Thank you for all the contributions and the PRs you created in my repo. I always saw the notifications pop up in my mail account but never really had the time to logon to GitHub. I'm really sorry! I saw how much work you put into improving the mod and I really appreciate it!
I just looked at a few of the changes you implemented and am really happy. If it's okay with you I'm would like to archive my repository and recommend this fork in the readme instead.
Kind Regards

Awesome, thank you for responding!


Cookie_command: Modified connection to DB, cookie command response, userinfo response (send, received cookies)

resolved issue: https://github.com/KieranRobson/Clarence-Bot/issues/1

Thanks a ton @RichardSabol!


Factor out split_filename/2

@eiri: Do not merge.
I'll push directly into refactor-rename_on_delete branch if you agree with the change.

To be honest I don't find your version much clearer on what it is doing or more idiomatic than mine foldl. It might be jiffy faster, but we are talking about traversing 5-6 elements list, I don't think it worth to double loc for that. I guess we can refactor that tokenizer into its own function, though it's not like it's going to be used outside of deleted_filename. So what exactly is the gain of a hair splitting here?

The current version is hard to understand. Apparently mine is not any better.

We don't have a formal definition for data dir hierarchy, it's half-configurable, "shards" prefix hardcoded all over fabric and for kicks is inconsistent, "mrview" prefix is supposedly mrview engine's namespace, though I'm not 100% sure it is used even for search -- I don't think it's possible to make this tokenizer easy to understand, which is partly why it'd better to stay incapsulated in deleted_filename. That's unless we are willing just damn encode the whole path into deleted filename. Which, after all of this bickering, doesn't sounds like a such silly idea anymore.

Closing the PR to keep the discussion in a single place https://github.com/apache/couchdb-couch/pull/141


Lacking a political ideology representing Objectivism

I was looking through the list of possible political ideologies that can be received by taking the test, and I noticed there was no listing for Objectivism. While it's not completely unsimilar to Libertarian Capitalist, or something like Anarcho-Egoism, Anarcho-Capitalism, or Market Anarchism, it definitely is different from these specific categories. It would be cool to see a specific option show up for Objectivist in the test. If you don't like, or don't want to use the term "Objectivist", then you could also call it "Rational Egoism", as that term represents the same philosophy as does the term Objectivist.
I can provide more information if necessary, but I can give a sorta easy way to think of it. If Libertarianism is an umbrella term, then Objectivism is a specific kind of Libertarianism, although most Objectivist reject this idea simply because of the implication of being conflated with Libertarians.

I have started adding in an ideology that fits roughly into what Rational-Egoism would be identified with on the axis. Based on my preliminary tests for the new ideology I added, Rational-Egoism will come above the other market centered ideologies, but will come just below Anarcho-Capitalism, namely based on the economic and government scale.
In the process of doing this, I have noticed some odd peculiarities as to how the ideology matching works, specifically with regard to how each axis is used to determine which ideology is matched. I have noticed some axis have a strong pull on the matching than others, namely the economy axis. Anyone know if this is by design, or just a quirk of the way the calculations are done?

This came up in a more recent thread, but for the sake of documentation, I will confirm that the economy and civil axes do have a stronger effect on ideology matching than the diplomatic and society axes. This is because ideologies tend to have strong positions on the economy and role of government. The other axes vary wildly in their importance; the diplomatic axis is quite influential in the authoritarian far-left, but less so among the right. The opposite is true of the society axis.
An eventual ideology rework will probably do matching via different means, where weighting can hopefully be determined on a per-ideology basis.

That's really interesting! Thanks for sharing that! That explains why when I was playing around with adding Objectivism/Rational-Egoism as an option, the diplo axis had literally no affect at all!

I have added an ideological match for Rational-Egoism to the JS file! It may take a bit of fine tuning to be exactly right, but it should work well for the niche of people that fall into that category!

From #58:

And as an anarchist, I can tell you that "libertarian" and "anarcho" (for us) are used synonymously.

This is why I was saying there needs to be a separate ideological match for Rational-Egosim/Objectivism! Even though Libertarianism and Objectivism can be very similar politically, with some even calling Objectivism a branch of Libertarianism, the vast majority of Objectivist will refuse to identify, or be identified, with Libertarians, because of the very sentiment expressed in the quote above.

(Added in latest commit)


Turkish translation of Energised Power mode

It's a bit late, I think! But the translation of the Energised Power Mode is finished!
         _**Translation is here!**_

tur.tr.json
    **I hope you like the translate!**

Thank you very much!


Uncaught ReferenceError: require is not defined

I'm having this problem about require, which is in line 2.
I can't make it work because of this var crypto = require('crypto'); which i cant find anywhere.

Can you be more specific?, the error looks due to require is not recognized, are you trying to use the library on client side?.


Feature Request: Add 'ping of type' Filters to the Settings Moderator Events Tab

see title

Was added with b1286d8c1ad4ff98301d8a23f84301d49d78b87f


Rundowns with &, ?, + etc. will make router.get('/changeItemData'... break

URL query params are used for the changeItemData endpoint, and without URL encoding in the browser and then URL decoding on the server, some special characters will cause it to fail to find the rundown file.

I will keep these here as a reminder for a future update. Thanks for pointing this out!


feat: support engine profile selection for DMN

Closes #2872

https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/2872-engine-profile-for-DMN/camunda-modeler-2872-engine-profile-for-DMN-linux-x64.tar.gz
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/2872-engine-profile-for-DMN/camunda-modeler-2872-engine-profile-for-DMN-mac.dmg
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/2872-engine-profile-for-DMN/camunda-modeler-2872-engine-profile-for-DMN-mac.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/2872-engine-profile-for-DMN/camunda-modeler-2872-engine-profile-for-DMN-win-ia32.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/2872-engine-profile-for-DMN/camunda-modeler-2872-engine-profile-for-DMN-win-x64.zip

Result after clicking on the C8 DMN button from welcome tab:

Log message
[diagram_1.dmn] No provider for "e"! (Resolving: executionPlatform -> updateExecutionPlatformCommand -> e)
    at a (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:112:11)
    at error (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:98:14)
    at get (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:152:18)
    at file:///Applications/Camunda%20Modeler%20DMN%20Version%20Select.app/Contents/Resources/app.asar/public/3.3.js:1:38603
    at Array.map (<anonymous>)
    at map (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:170:30)
    at fnDef (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:185:14)
    at providers (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:146:43)
    at file:///Applications/Camunda%20Modeler%20DMN%20Version%20Select.app/Contents/Resources/app.asar/public/3.3.js:1:56365
    at Array.forEach (<anonymous>) [ error ]
This error may be the result of a plug-in compatibility issue. [ info ]
[Disable plug-ins (restarts the app)](https://github.com/camunda/camunda-modeler/pull/2877#) [ info ]
[diagram_1.dmn] No provider for "e"! (Resolving: executionPlatform -> updateExecutionPlatformCommand -> e)
    at a (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:112:11)
    at error (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:98:14)
    at get (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:152:18)
    at file:///Applications/Camunda%20Modeler%20DMN%20Version%20Select.app/Contents/Resources/app.asar/public/3.3.js:1:38603
    at Array.map (<anonymous>)
    at map (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:170:30)
    at fnDef (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:185:14)
    at providers (webpack:///node_modules/diagram-js/node_modules/didi/dist/index.esm.js:146:43)
    at file:///Applications/Camunda%20Modeler%20DMN%20Version%20Select.app/Contents/Resources/app.asar/public/3.3.js:1:56365
    at Array.forEach (<anonymous>) [ error ]
This error may be the result of a plug-in compatibility issue. [ info ]
[Disable plug-ins (restarts the app)](https://github.com/camunda/camunda-modeler/pull/2877#) [ info ]

It's not a plugin issue. Disabling plugins does not help.

I can reproduce it. It must be something related to minification.

@andreasgeier Please download the artifact now. It should work correctly (works on my machine).

This requires some additional work.

Ready for review again. The artifacts will be built in a couple of minutes.


Seems like all work has stopped on this, if that is the case, please just mark it that way

Seems like all work has stopped on this, if that is the case, please just mark it that way.
Thanks

Hello, I'm still contributing to open source, it's just a struggle to focus on many things at once.
As time passes, the pile of things to do increases. I had some code changes to do, but now I have to deal with jcenter closing and setup MavenCentral releasing too, which makes me procrastinate as there are other things I want to do first.
I don't plan to abandon this project, unless something with an objectively better API comes up and there's no reason left to keep changing this one.

I by no means want to take any attention away from this library, as it is a great foundation for tackling the incredibly complex world of BLE. I also understand @LouisCAD being busy, he makes numerous contributions to open source and the Kotlin community in general. Although, as a potential alternative, I have been actively working on Kable which solves similar problems as this library.

Work on this library resumed.
Last week, I published version 0.5.0 on MavenCentral with several modernizing updates, it was 1004 days after the previous release (😅).
Now that the project is easier to update and publish, I'll do my best to respond much quicker (within a week or less).


Can't see indicator icon in Ubuntu 17.04

What operating system are you using?
Ubuntu 17.04
What version of Nylas Mail are you using?
2.0.15
I've upgraded my ubuntu from 16.10 to 17.04 and right now can't see the indicator icon in my upper panel.
Do you have any third-party plugins installed? If so, which ones?
No

I found a workaround:
cat >> ~/.profile <<GLOBALMENUFUX
use Unity instead of Unity:Unity7
XDG_CURRENT_DESKTOP=Unity
export XDG_CURRENT_DESKTOP
GLOBALMENUFUX
This also fix the global menu for intellij idea and opera.


Upgrade UI - Update style of the error message in some screens

Describe the bug
Update the style of the error message on some screens

[x] The import NFT screen, import Token screen

[x] Import account by seed phrase, private key

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./upgrade-ui-build-1.0.2-1-1681181326431.zip
Validation passed.


One sample includes all

With one main sample app and include all others as modules it's easier to maintain, see what's included and verify on CI

@hannesa2 I particularly prefer the way they are right now (separate modules), this way developers can build each module separately, since sometimes they're only interested in trying our one of them.
On a side note, I think it would be cool if you listed all the PR description all the tools you've included on CI (e.g protobot/stale). Because some of those tools might require permissions that the organization (Google in this case) is not willing to grant.

@hannesa2 I particularly prefer the way they are right now (separate modules), this way developers can build each module separately, since sometimes they're only interested in trying out only one of the apps.

Yes, and every developer don't know, what the other does.
Separate apps will need a separate CI task, which are not done

On a side note, I think it would be cool if you listed on the PR description all the tools you've included on CI (e.g protobot/stale). Because some of those tools might require permissions that the organization (Google in this case) is not willing to grant.

Don't worry, as long as nobody likes this practical all-in-one sample, this CI changes will be never a pull request in upstream repo (look it's a PR into my fork)

For me at least it makes sense. Now, I've an overview what's included.
@rosariopfernandes
Please remember, you make your upstream repo for other developer, not for you !

@hannesa2 Oops, I didn't notice this was on your fork, my bad. I got here through a comment you left on a PR to the upstream repo. Thanks for pointing that out!

@rosariopfernandes
Please mention, now there is a CI which tests ALL android projects

This is how it looks like


Added a new javascript project - IP Address Tracker

Added a project - IP Address Tracker to the repo and linked it to the website.
Preview

Home Page

Kindly review the changes.

I have fixed the merge issues, kindly review the changes.

Updated the project number to 62 and added a transition effect to the theme toggle function.
fixes #194

@VrindaTyagi Thank you for your contribution. Looking forward to more such amazing contributions 🥂


Pathfinder and D&D 3.5 support

Maybe? :) I think it can be forked from the 5e module removing electros

Yes, I think so. Is this something you can help with?

I can try! but I don´t know when I´ll have time to do it and I´m not an expert on the foundry api.

I made a try, but it was not enough, looks like it misses the necessary data to draw the fields
But I searched and found this one https://github.com/Rughalt/d35e-loot-sheet-npc so it´s ok
Thanks for your help!

Ok, I will try to see if I can add the functionality at some point. It is not forgotten.


Add star pattern in Java, Pattern35

Description
Task
For the given input n the number of rows printed should be n for ex:

Note

Filename should be Pattern35.java

Can you assign this one to me

ok, @KunalBhardwaj136 I am assigning this issue to you

pr mergerd #47


Fix to allow for hotstarting with systemStepExact=False

Mandatory Checklist
Please ensure that the following criteria are met:

[ ] Title of pull request describes the changes/features
[ ] Request at least 2 reviewers
[ ] If new files are being added, the files are no larger than 100kB. Post the file sizes.
[ ] Code coverage did not decrease. If this is a bug fix, a test should cover that bug fix. If a new feature is added, a test should be made to cover that feature.
[ ] New features have appropriate documentation strings (readable by sphinx)
[ ] Contributor has read and agreed with CONTRIBUTING.md and has added themselves to CONTRIBUTORS.md

As a general rule of thumb, try to follow PEP8 guidelines.
Description
Addresses #1235. Not setting the model time prior to proceeding with calculation leads to an infinite loop.
Thanks @cekees for the suggested fix.
Added a test within tests/TwoPhaseFlow to test for the fix. Note to keep in mind is that the test is to avoid changes to the infinite loop fix.
I tried setting a test to compare numerical results but I believe something along the lines of #1184 was causing a different behavior between the directory-level pytest call and a make test call at the root.

@cekees, I think the line in NumericalSolution is causing a massive code cov decrease. I can try moving the line elsewhere or is there some simpler fix to the drop in coverage.
I think @ejtovar ran into something similar pretty recently. I forget how it was resolved.

For reference, prior to hack/removal of test, codecov indicated -36% coverage.
Removing test yields only a -0.01% drop.
Going to turn the test back on to see if behavior is corrected.


Master CI is broken and no release since 2018?

Dear developer,
It seems that the last release is from november 2018 and the continuous integration is broken on master.
I would like to see a new release because we are running into some issues already fixed on master and I'm using pipenv via pip install.
Would it be possible to create a checklist of things to do to get to a new release? Maybe I can help out.

Thanks for the offer, @bneijt! We do already have that kind of issue open: #3369. I suggest you go ahead and look at that issue and follow the suggestions there to help out! (I'm going to close this issue now to direct you and any other folks watching over to #3369.)


Checking the validity of a constructed PAG

Is your feature request related to a problem? Please describe.
Whenever a PAG is constructed, it is not necessary a valid PAG in the sense of the definition. I.e. it might be a PAG with additional orientations.
However, for many use-cases, one might want to construct only a valid PAG. So they would like to check its validity in a graphical algorithm.
Describe the solution you'd like
As suggested by @jdramsey in https://reader.elsevier.com/reader/sd/pii/S0004370208001008?token=1C0B24A74D739F3C8D05A0D2DEC40AA540835B1E58C74D189AE09D9C6FABBF30C941385A4A1F9FC9DFAE1E316E022D1E&originRegion=us-east-1&originCreation=20230320132639, Theorem 2 provides a method for turning a PAG into a MAG. This was originally suggested by Peter Spirtes.
Imo, this is an extremely valuable algorithm in terms of applications.
Then one can check the validity of the MAG using ancestrality and maximality. If there is a violation of the definition of the MAG, then the PAG is essentially invalid.
This can be implemented as a graph algorithm.
Additional context
xref: https://github.com/cmu-phil/tetrad/issues/1556

Hey @adam2392 for my next issue, do you think this will be a good one? Without going into depth, it looks a bit complicated for someone (me) who has never made contributions to a graph library. Any suggestions?

Design-wise, skim a look at networkx documentation/code and how it structures the graph classes vs functions. We are implementing a function here.
The function should:

check for some validity that it is a PAG (e.g. circle edges)
convert the PAG to a MAG using the theorem linked in the issue in Zhang's 2008 paper (we don't have a MAG class, but we can just use an ADMG class for now)
check the validity of the MAG
convert the MAG back to a PAG
check if PAG is same as the PAG fed in

Yeah this one is quite involved, but the code/explicit theorems are all out there. Just need to put it together.

Alright, so I went through the documentation/code of networkx and pywhy-graphs. I was able to understand the code structure and most of the classes/functions in the repo. I went through the paper and the theorem you are referencing and it seems simple enough for me to implement.
I am having difficulty understanding the validity part, can you elaborate on how one would check the validity of a PAG (for the purpose of this function, wouldn't simply asserting that the graph object provided is an instance of the PAG class be enough?) and a MAG?
I am new to causal learning and have been trying to catch up with the terminology and the symbols that are used in the papers and the code. I have made good progress in understanding things related to this issue. Hopefully with your help I can make good progress!

@adam2392 I just reviewed the PAG code and there is a function is_valid_mec_graph that appears to enforce the validity check in the PAG class. Is that understanding correct?

@adam2392 I just reviewed the PAG code and there is a function is_valid_mec_graph that appears to enforce the validity check in the PAG class. Is that understanding correct?

I believe this only enforces the validity when adding edges. Probably poorly named. I think we can refactor these names once we decide on a proper class for:

mixed-edge graphs that support Chain Graphs, CPDAG, PDAGs and their extensions
mixed-edge graphs that support ADMG/DAGs and their extensions
mixed-edge graphs that support PAGs and their extensions

What are some good generic names for the directed/undirected graph and the directed/bidirected graph and the directed/bidirected/circle/undirected graph?

I will reply in #65 to avoid cluttering this issue


Days of Buffering

My DOB calculation says I have a total outflow of $44,000 and that I have been budgeting for 113 days. I started last week. Did I set something up wrong in YNAB?

@blu313 no, it's ok. If you have Direct Import, YNAB gets more transactions than it shows.

Gotcha. So that just means DOB won't work if I use direct import?

@egens, is there any way to filter these transactions out? There must be some kind of flag on them so YNAB doesn't treat them as real transactions, no?

@blu313 @blargity those hidden transactions are real. So that means if you just started and have 0 days of budgeting but have those hidden transactions, DoB can be calculated with ~100 days of history. They actually help!

Cool, sounds like a plan!

Alrighty, looks like this was answered. I'm going to go ahead and close this. If we didn't answer the question, please let us know so we can get to the bottom of it!


memoery leak in ssl/statem/statem_dtls.c

In line 1055 and line 1059, it is returned without freeing frag.
https://github.com/openssl/openssl/blob/31214258309251aff297da67a60a6b60bf4ef27e/ssl/statem/statem_dtls.c#L1043-L1060

The fix would be to move the “new” statement after the if checks.

Fixed in commit 48ff651eccf2f43ddbc221a0f9ddac57169aa255
Marking as inactive, to be closed at the end of 3.4 dev, barring further input


Update modules to Terraform 1.0.x

Update modules to Terraform 1.0.x

I think it would be cool to get this repo updated with the latest 1.1.0 release of terraform.

Closing this out due to inactivity. Re-open if desired


Import ember modules

Hi,
I'm trying to figure out if there's a way to get IntelliJ to recognize correctly the imports from ember.
i.e.

In the first case, it's simply that "ember" doesn't exist.
In the second case, it's because emberjs addons use a specific layout, so the file actually isn't in that path.
Is there a way around it?

the second one should actually work. what version of the plugin are you on?

2017.2.1-0

Just to be clear, for the second one:

The "addon" folder is what bugs it out.
If I write
import AuthenticatedRouteMixin from 'ember-simple-auth/addon/mixins/authenticated-route-mixin';

then intellij can find it (but it's incorrect obviously).

@dwickern any idea why this might not be working?

I have the same problem on plugin version 2017.2.1-0 but it works fine on master branch 🤔

When I compare between 2017.2.1 and master: https://github.com/Turbo87/intellij-emberjs/compare/v2017.2.1...master
I see this commit: d760843614c1e766eab64a0c21cd5d80c586ce95
Seems to be it?

Can I close this?


jssh use public/private key

Hi,
I am using public key to login to destination host, i have already setup configuration, when i use ssh to connect to host it goes without password, i use "ssh hostname.com" and it goes straight without passwords, however when use lcget with jssh it ask me for password, how to change jssh to use just ssh hosname to connect. ?
many thanks
Bartosz

How does jssh hostanem.com behave?

ok can do some output, will go over it tonight and check logs


Support dynamic values in log contexts.

Goal
It is common to include a time-stamp and call-site or stack trace information in every log event in diagnostic logs. Package log should make it easy to add these fields when appropriate.
The Problem
Time-stamp and call-site values are dynamic, meaning the logged value changes with each call to Log. At the same time we usually want to make a global choice about whether to include them in our logs or not. These fields rapidly lose their value if they are not consistently available and having to specify them each time we call Log would be both tedious and error prone.
We could provide simple wrappers for Logger that injects the additional fields. This works nicely for time-stamps:
func NewTimestampLogger(logger Logger, key interface{}) Logger {
    return LoggerFunc(func(keyvals ...interface{}) error {
        return logger.Log(append(keyvals, key, time.Now())
    })
}

But when we try the same for call-sites the details get ugly:
func NewCallerLogger(logger Logger, key interface{}) Logger {
    return LoggerFunc(func(keyvals ...interface{}) error {
        // how many stack frames should we skip?
        _, file, line, ok := runtime.Caller(?skip?)
        return logger.Log(append(keyvals, key, fmt.Sprint(file, ":", line))
    })
}

Finding the call-site for Log depends on knowing how many stack frames to ascend? But that can change depending on the order we wrap the base Logger. Even if we are careful to always call NewCallerLogger last so that it is at the top of our logging stack it will likely get wrapped later by calls to With.
NewCallerLogger could implement the Wither interface to avoid getting wrapped by a withLogger. But this approach ends up essentially re-implementing withLogger.
The Solution
This PR recognizes that the above approaches are essentially specialized versions of With. They create a new logging context with a key and value. The essential difference is that the value is not static.
The proposed solution takes inspiration from package database/sql/driver. I propose a new Valuer interface similar to driver.Valuer. I also add a BindValues function to scan the values in a keyvals slice for Valuers and replace them with the result of their Value method. I modify withLogger to call BindValues when logging.
The result is an extensible mechanism for storing dynamic values in a logging context. Implementing Timestamp and Caller as commonly needed Valuers is trivial. Applications or other packages could use this capability to log other types of dynamic data. It seems like there could be some an interesting composition of this capability with package metrics for example.

Hey! Thanks a bunch. I have some specific comments that might be best expressed in the form of another PR ;) Shall I just make those on your fork, @ChrisHines?

@peterbourgon Yes, go ahead with a PR on my fork.

Here you go — these PRs be crazy.

Updated with results of the PR at ChrisHines/gokit#1.
@tsenart One thing still puzzles me, why did you define log.Timestamp like this:
Timestamp = func(t func() time.Time) Valuer {
	return func() interface{} { return t() }
}

Instead of like this:
func Timestamp(t func() time.Time) Valuer {
	return func() interface{} { return t() }
}

I don't see the scenario where we would want to change the Timestamp function. Isn't accepting a function argument flexible enough?

I was just trying to squeeze lines of code to convince @peterbourgon that
it wasn't that much longer! :-)
No reason to define it that way but now that we're on it, using
const instead of var would intuitively have the same effect. I don't think
this is part of the language though.
On Saturday, April 25, 2015, Chris Hines<EMAIL_ADDRESS>wrote:

Updated with results of the PR at ChrisHines/gokit#1
https://github.com/ChrisHines/gokit/pull/1.
@tsenart https://github.com/tsenart One thing still puzzles me, why did
you define log.Timestamp like this:
Timestamp = func(t func() time.Time) Valuer {
return func() interface{} { return t() }
}
Instead of like this:
func Timestamp(t func() time.Time) Valuer {
return func() interface{} { return t() }
}
I don't see the scenario where we would want to change the Timestamp
function. Isn't accepting a function argument flexible enough?
—
Reply to this email directly or view it on GitHub
https://github.com/peterbourgon/gokit/pull/32#issuecomment-96128146.

--
Sent from Gmail Mobile

I'm happy with this PR now. @peterbourgon & @tsenart please take another look.

@ChrisHines: Two simplifications: https://github.com/ChrisHines/gokit/pull/2

@peterbourgon & @tsenart: All changes we discussed on my fork are now included in this PR.

The Travis failure was some spurious thing. LGTM! Thanks a ton!


Add verification to deploy script

add the logic of verification smart contract to deploy script, fix hardhat config for verification

Hi @Pe4enable , thank you for your pr!
Default network is localhost for dev and testing purposes, because before deploying contract to testnet builders need to change code and test locally. And deploy only when everything works as expected.
You can verify your contract using simple script yarn verify --network your_network. Also, your code will fail when deploying to localhost.
In any case, verification process should be changed in se-2 repo.
Feel free to ask any questions
ps. fyi https://github.com/scaffold-eth/scaffold-eth-2/pull/637

Hi @Pe4enable , thank you for your pr!
Default network is localhost for dev and testing purposes, because before deploying contract to testnet builders need to change code and test locally. And deploy only when everything works as expected.
You can verify your contract using simple script yarn verify --network your_network. Also, your code will fail when deploying to localhost.
In any case, verification process should be changed in se-2 repo.
Feel free to ask any questions
ps. fyi https://github.com/scaffold-eth/scaffold-eth-2/pull/637


Improve the construction of QobjEvo

Checklist
Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

[x] Please read Contributing to QuantumToolbox.jl.
[x] Any code changes were done in a way that does not break public API.
[x] Appropriate tests were added and tested locally by running: make test.
[x] Any code changes should be julia formatted by running: make format.
[x] All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
[x] (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
Summary of this PR:

add new methods to generate QobjEvo with input type Tuple{QuantumObject,Function}.
add argument checks for each coefficient Function by using Base.methods.

Related issues or PRs
close #338

Hmm...
the code-quality test succeed in my local laptop...
Not sure why it fails in CI pipeline

I think it's good. Do we have tests for type instabilities? What happens if we run
@inferred QobjEvo((op, coef))

and all the other methods?

I think it's good. Do we have tests for type instabilities? What happens if we run
@inferred QobjEvo((op, coef))

and all the other methods?

Ok, added~

Are you using the latest versions in your local runtests for the code quality?

Are you using the latest versions in your local runtests for the code quality?

Yes JET v0.9.12 on MacOS m-series chip

I have the same error locally

I think the error comes from the new method definition of QuantumObjectEvolution and the Julia version v1.11.2. Either removing the error, or running with Julia v1.10.7 doesn't show the error. But still we need to know why.

Ok, fixed


Fix #291 failed tests with lestest PHP

Since 5.6.24, 7.0.9, 7.1.0beta1, negative timestamps are valid.

+1


Add Answer Modal Functioning

Add Answer Modal
Input Validation
Api post request
Todo:
Currently can only open window once
Photo upload section

This is awesome!

@mutton808 Hello! Please do not use libraries which provide any css styles or animations for FEC. The react-modal library qualifies as such. I trust you can create the functionality you need. 💯


Requests: Notifications, disable scrollbar, make a tray icon

This is for Linux, I can't confirm or deny functionality on Windows.  This app is working very well for me so far.  It seems like, after it starts, it keeps running in the background.  However, at least on Linux, there's no tray icon to indicate this and if I close the app I have no way to reopen it.  Additionally, I always have a scrollbar on the right side.  No idea why, it doesn't scroll anything.  It looks like it's a part of Chromium, not part of Yappy.  Lastly, and probably most importantly, I don't get notifications for new texts!  No popup, nothing.  If you need any info or help, let me know, but just know that I don't know any NodeJS or even regular JS.

Hey there,
It does currently keep running in the background without a tray icon. I experience the same thing on Windows. I also have the scrollbar on the right.
This app was created using the Electron framework, and Electron does not currently support desktop notifications. However, there have been rare instances where I did receive popups, but I cannot replicate it reliably.
I will look into minimizing to icon tray & removing the scrollbar. Notifications will also be looked into, but until I can find a reliable way to replicate some rare behaviors, they are a relatively low priority, as they are not 'officially' supported in Electron apps. There are ways of displaying notifications, but they aren't quite the style of notifications that you might see from Pushbullet or the likes.

I can tell you right now that notifications on Linux are done by libnotify. No idea for Windows though. Thanks!

Just to add, there's also this, which is supposed to work with Electron.

I'm gonna condense research about notifications to one post.  Windows provides no native way to show notifications, so I'm not sure what could be done there.  On Linux, applications plug into libnotify to send desktop notifications.  For example, navigate to a terminal and type notify-send "Title" "Body" --icon=firefox, which should give you a notification with the firefox icon.  The Arch Linux Wiki page on libnotify has usage examples in dozens of programming languages, including Javascript, although it seems to require an external library.  There's also HTML5 Desktop Notifications Library, which works on Windows, but I am not entirely sure how it works or how to install it.

I will likely not be implementing libnotify, as it's pretty much solely linux.
Additionally this is quite literally the first lines of JavaScript i've ever written, so it's a learning experience :smile: Looking to keep it relatively simple for now but we'll get there.
Hoping to have some changes out within a couple days.

Excellent, thanks for the update

Notifications in progress. Scrollbar, tray icon, & properly killing background process added in v0.2. Currently no minimize to tray (future update). Will open an issue for notifications and minimize to tray.

Great update, thanks for the work!


Fix documentation rendering

Some contents forced the HTML help to scroll.
Generate separated code block for each example
Add some more examples

Codecov Report

Merging #80 into master will increase coverage by 0.27%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   55.31%   55.58%   +0.27%
==========================================
  Files          61       61
  Lines        4630     4638       +8
==========================================
+ Hits         2561     2578      +17
+ Misses       1903     1895       -8
+ Partials      166      165       -1

Impacted Files
Coverage Δ

template/extra_data.go
49.07% <ø> (ø)
:arrow_up:

template/extra_math.go
36.44% <0%> (+0.54%)
:arrow_up:

template/template_help.go
0% <0%> (ø)
:arrow_up:

template/extra_utils.go
31.91% <0%> (-1.42%)
:arrow_down:

collections/string_util.go
31.3% <100%> (+3.12%)
:arrow_up:

template/func_table.go
50.38% <90%> (+8.46%)
:arrow_up:

collections/implementation/base_helper.go
79.5% <0%> (ø)
:arrow_up:

template/math_utilities.go
85.48% <0%> (+1.61%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f29111...30b6d7b. Read the comment docs.

Wow nice, I really like the new layout


test: Use default configuration for tomcat containers

There is no reason to use non-default values.

Thanks @jajik


USER STORY: Log out from the App

EPIC: #3
In order to securely end my session, as a logged-in user, I can log out from the to-do app.
Acceptance Criteria:

Acceptance Criteria 1: User is logged in and viewing the home screen.
Acceptance Criteria 2: User can click the logout button.
Acceptance Criteria 3: After logging out, user is redirected to the login page.

Tasks:

[x] Implement logout button functionality
[x] Backend: Implement API endpoint for user logout
[x] Clear user session and redirect to home page
[x] Ensure user cannot access authenticated routes after logout

Done


Ported some build fixes from dev branch

Ported some build fixes and improvements from the dev branch.

Fixed an issue where users were unable to build without either specifying a wsa certificate, or building through the normal Unity Editor Build window because the certificate had not been generated yet. (Unity Build will generate one for you if one doesn't exist.)
Build Compatibility with 2018.1
Detailed log reporting of msbuild output.
Make quick options HoloLens target make sure to target HoloLens only. #1959
Removed some compile and build warnings.
Fixes #2124 and other conflicts with IL2CPP
Addressed some licensing issues from https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/1904#discussion_r186269929

@davidkline-ms, @keveleigh this PR is ready unless @cre8ivepark and @johnppella have any pending CRs


Is this coordinate in the camera system or in the world system?

in this sample body_tracking

Keypoints are expressed in the measure reference frame as mentioned here :
https://www.stereolabs.com/docs/api/classsl_1_1ObjectData.html#abbcf08d0ee3800edda16f668dd9c4696
Therefore in this example, Since the runtime parameters are left to default values (not provided in the grab() function), the keypoints are provided in the camera system.

Okay, I got it. Thank you


DO NOT MERGE YET Refactor for new infra

DO NOT MERGE YET
What?
Update load script and deployment for new infra
Why?
So we integrate the new setup into this app.

👍🏼


Need Clarification that Custom Prefixed Environment Variables DO NOT replace json settings

I spent considerable time reading this section over and over and the section on environment variables is not clear on the order of setting priorities. Actually is very misleading. The section in question is
.ConfigureAppConfiguration((hostingContext, config) =>
{
// Call additional providers here as needed.
// Call AddEnvironmentVariables last if you need to allow
// environment variables to override values from other
// providers.
config.AddEnvironmentVariables(prefix: "PREFIX_");
})
}
If I add the line as     config.AddEnvironmentVariables(prefix: "MYAPP_"); as the last line and I have a secrets json file that includes
"ConnectionStrings": {
"IdentityServer4": "Server=<IP_ADDRESS>;Uid=xyz;Pwd=password;Database=IdentityServer4"
}
and I set an environment setting of
MYAPP_ConnectionStrings__IdentityServer4="IdentityServer4": "Server=<IP_ADDRESS>;Uid=xyz;Pwd=password;Database=IdentityServer4"
The environment variable is not used, the secrets json file has priority - at least on .NET Core 3.1. If I remove the json file setting the environment setting is used.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0eb4d762-3910-2c57-8741-3306c15537b6
Version Independent ID: ba2254a0-ea8e-9b28-e94b-edd0fc58c043
Content: Configuration in ASP.NET Core
Content Source: aspnetcore/fundamentals/configuration/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @alwilton ...

and I set an environment setting of
MYAPP_ConnectionStrings__IdentityServer4="IdentityServer4": "Server=<IP_ADDRESS>;Uid=xyz;Pwd=password;Database=IdentityServer4"

Can we clarify your env var key first ... that key doesn't look right. Did you mean ...
Name: MYAPP_ConnectionStrings__IdentityServer4
Value: Server=<IP_ADDRESS>;Uid=xyz;Pwd=password;Database=IdentityServer4
Otherwise if that's ok, the order for setting config values is last setting wins, and loading config from env vars here (ConfigureAppConfiguration) should do the trick.

Yes – your correction is correct. BUT NO (!) the “last setting wins, and loading config from env vars here (ConfigureAppConfiguration) should do the trick” does not win in after my afternoon of work today. In my testing unless I remove the secret json setting it was the winner
Thanks for your time on this.
From: Luke Latham<EMAIL_ADDRESS>Sent: Thursday, December 12, 2019 5:38 PM
To: aspnet/AspNetCore.Docs<EMAIL_ADDRESS>Cc: Al Wilton<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [aspnet/AspNetCore.Docs] Need Clarification that Custom Prefixed Environment Variables DO NOT replace json settings (#16171)
Hello @alwiltonhttps://github.com/alwilton ...
and I set an environment setting of
MYAPP_ConnectionStrings__IdentityServer4="IdentityServer4": "Server=<IP_ADDRESS>;Uid=xyz;Pwd=password;Database=IdentityServer4"
Can we clarify your env var key first ... that key doesn't look right. Did you mean ...
Name: MYAPP_ConnectionStrings__IdentityServer4
Value: Server=<IP_ADDRESS>;Uid=xyz;Pwd=password;Database=IdentityServer4
Otherwise if that's ok, the order for setting config values is last setting wins, and loading config from env vars here (ConfigureAppConfiguration) should do the trick.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/aspnet/AspNetCore.Docs/issues/16171?email_source=notifications&email_token=ABGU43VOF4A22LTHTWW6HDTQYLKQFA5CNFSM4J2F6IP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGYQUFY#issuecomment-565250583, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGU43QK527OAKCESH6L2YTQYLKQFANCNFSM4J2F6IPQ.

Paste your Program class into a comment here.

using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;
using Serilog;
using Serilog.Events;
using Serilog.Sinks.SystemConsole.Themes;
using System;
using System.Linq;
namespace MYAPP
{
public class Program
{
public static int Main(string[] args)
{
Log.Logger = new LoggerConfiguration()
.MinimumLevel.Debug()
.MinimumLevel.Override("Microsoft", LogEventLevel.Warning)
.MinimumLevel.Override("System", LogEventLevel.Warning)
.MinimumLevel.Override("Microsoft.AspNetCore.Authentication", LogEventLevel.Information)
.Enrich.FromLogContext()
.WriteTo.Console(outputTemplate: "[{Timestamp:HH:mm:ss} {Level}] {SourceContext}{NewLine}{Message:lj}{NewLine}{Exception}{NewLine}", theme: AnsiConsoleTheme.Literate)
.CreateLogger();
        try
        {
            var host = CreateHostBuilder(args).Build();
            Log.Information("Starting host...");
            host.Run();
            return 0;
        }
        catch (Exception ex)
        {
            Log.Fatal(ex, "Host terminated unexpectedly.");
            return 1;
        }
        finally
        {
            Log.CloseAndFlush();
        }
    }

    public static IHostBuilder CreateHostBuilder(string[] args) =>
        Host.CreateDefaultBuilder(args)
            .ConfigureAppConfiguration((hostingContext, config) =>
            {
                // Call additional providers here as needed.
                // Call AddEnvironmentVariables last if you need to allow
                // environment variables to override values from other
                // providers.
                config.AddEnvironmentVariables(prefix: "MYAPP_");
            })
            .ConfigureWebHostDefaults(webBuilder =>
            {
                webBuilder.UseStartup<Startup>();
                webBuilder.UseSerilog();
            });
}

}

That looks good.
I just ran a test here with the Secret Manager, the Env Var Config Provider, a prefixed env var, and a double-underscore key ... I can't repro the behavior. It works as it should ... the Secret Manager supplies the value without the env var, and setting the env var causes the Secret Manager value to be overridden with the env var value.
The Secret Manger secrets are loaded here ...
https://github.com/aspnet/Extensions/blob/master/src/Hosting/Hosting/src/Host.cs#L82
... via CreateDefaultBuilder, and every configuration item adheres to last setting wins by design. When env vars are loaded in ConfigureAppConfiguration, existing values with the same key are overridden.
I'm not sure what the problem is. You can try a support forum, such as Stack Overflow, to get support. We can't offer individual devs support here. We just work on the docs. There's no error or omission that I'm aware of in this topic (or in the Generic Host topic for CreateDefaultBuilder), so there's nothing actionable at this time given that I can't repro the problem and don't know what the problem is.
Try Stack Overflow with your full set of steps. If you find out that we are missing a gotcha! point that should be called out in the topic, ping me back over here, and we can re-open this issue to discuss and possibly cover it.

thanks for the look. I'll try a very simple test case and follow your advice if the behavior persists.

Good idea ... start with a fresh minimal test app and run your steps from scratch.
I set up a MYAPP_Something__AnotherThing env var in my launch.json file (I'm on VSC) ...
"env": {
  "ASPNETCORE_ENVIRONMENT": "Development",
  "MYAPP_Something__AnotherThing": "THE ENV VAR VALUE"
},

I added the Env Var Config Provider as you did with that prefix (config.AddEnvironmentVariables(prefix: "MYAPP_");). I initialized the Secret Manager for the app and put a Something:AnotherThing secret in with a different value ("THE SECRET VALUE"). I had a Razor page show me the configuration that it was loading. First run: env var value came up because it was loaded last. Yanked the env var from launch.json and ran again: secret value came up confirming that the Secret Manager was working ok.
For quick-and-dirty look at what it thinks it's configuration is, you can use something like this in a Razor page ...
@page
@model IndexModel
@using Microsoft.Extensions.Configuration
@using Microsoft.Extensions.Hosting
@inject IConfiguration Configuration
@inject IHostEnvironment Environment

Config values:

        @if (!@Environment.IsProduction())
        {
            foreach (var kvp in Configuration.AsEnumerable().OrderBy(c => c.Key))
            {
<EMAIL_ADDRESS>: @kvp.Value

            }
        }


Updated example for clarity

The second point is missleading in my opinion.
I thought this has to be put into app/http/controllers and used in a route later on.
Putting this into the controllers folder will throw a "not exist" error - not a big issue but still something you can prevent with a little extra info.

Thanks!


Support for ubuntu 24.04

GitHub is rotating ubuntu-latest workflows onto ubuntu 24.04, eventually we will need support in the codspeed runner.

Yes definitely, we need to work on that, thanks for reporting this!


Update deployment with the new PUT request behaviour for the agent config

Fixes #9257
Status
not-tested
Description
Allow the configuration to be overriden in the script to upload the agent configuration to the reqmgr_aux couchdb.
Then adapted the deployment script to use this option.
Is it backward compatible (if not, which system it affects?)
yes
Related PRs
External dependencies / deployment changes
no

Tested in my VM.


[Typescript] Module ''discord.js'' has no exported member 'ClientUserSettings'

The discord.js type definitions no longer export the ClientUserSettings class, which the commando typings depend on.
For anyone else that is having this problem and it's preventing a build, changing the ClientUserSettings type to 'any' on line 250 and removing the ClientUserSettings import on line 12 in the type definitions in node_modules will suppress the build error until a proper fix is merged.

There's already #186

Fix with #186.


manifest: Update hal_nxp to add wifi related change

Update hal_nxp to add wifi related change

@MaochenWang1 please rebase to fix conflicts

Hi @danieldegrasse  rebased

Hi @danieldegrasse rebased

Please rebase to clear conflicts (sorry, we have a lot of churn in the manifest right now)

@MaochenWang1 HAL PR merged and I've updated this PR with the new SHA


Test on OS X with Travis

http://docs.travis-ci.com/user/multi-os/
@rvagg as you are the owner of the Travis account, perhaps you could send a mail to<EMAIL_ADDRESS>asking for them to enable it on this repo, since it requres manual intervention.

done, will let you know how it goes

@kkoopa apparently it's enabled now so you should be able to add the additional config for it

Cool. I'll push an updated config and see if it builds.

First attempt
https://travis-ci.org/nodejs/nan/builds/76010424

Did this for a project of mine last week, the comments at travis-ci/travis-ci#2311 were pretty helpful

I recommend roughly the same approach in the node-pre-gyp docs: https://github.com/mapbox/node-pre-gyp#enabling-multi-os

Quid pro quo anyone? PRs welcome. Make them out against the osx_test branch.


Problem with asynchronous functions

Hi!
I'm having trouble testing some local API endpoints via an async call (get method from superagent npm module), the step is just ignored and the test result tells me there is "Nada in da spec".
Does not daspec support it ?
Here's my consumer-step.js file (if I run a synchronous function, everything is fine) :
var request = require("superagent");

defineStep(/Getting on API should return (.*)/, function(expectedResponse){
    request.get("http://localhost:8080/test").end(function(err, res){
        expect(res.body.test).toEqual(expectedResponse);
    });
});

promises (async functions) are not yet supported in daspec. they should be supported soon, in v1.1

That woud be great. Thank you.

v 1.1.0 supports promises - you just have to return the promise out of the step definition to make sure that the test runner waits for it to complete.


Old repository should be archived

The old repository wasn't accepted new issues, so I'm posting here. The old repository located at https://github.com/FIRST-Tech-Challenge/ftc_app, should probably be archived and the README.md should be updated to link to this repository. Occasionally the community Discord has a team who accidentally downloaded the old repository.

The repository you reference was a fork of the original ftc_app repository.  The downstream fork hadn't been updated with the contents of it's upstream parent which is indeed archived.  That's been fixed.  Thanks for pointing it out.


Support Firefox for mobile

Interesting idea, I can only test on Android though...
Will look into it after the ongoing rewrite.

documentation for firefox android extensions


Problem: error org.freedesktop.systemd1.NoSuchUnit: Unit aleph-vm-con…

Problem: error org.freedesktop.systemd1.NoSuchUnit: Unit<EMAIL_ADDRESS>Jira issue: ALEPH-113
This happened because we tried to check if the service was running before checking if it was enabled. It resulted in no proper error but was creating an error message in the logs
Solution: Check if service is enabled before checking if it is active
How to test:
Launch instances. Restart the aleph-vm process, stop them. That error message should not display

Would it make sense to invest time adding tests on this ?

For this bug in particular no, it was just a message with no effect visible for the user. For the whole systemd subsystem absolutely yes.


Unify image file extensions

Some are .jpg, some are .png. I suggest .png for all images

I agree with making all images .png

Actually, let's use a mix of .png and .svg


Mapping of escape to "cancel" but not "quit" with only one tab

Description of the problem or steps to reproduce
The escape key seems mapped to the action for "cancel" and the control+q key combo is mapped to "quit". However, escape invokes the behavior closing the current tab when in "editor" mode (as opposed to shell mode or command mode). I think this behavior is unintentionally harmful (vs requiring control+[ (or control+w?) to invoke the same behavior of closing the current tab) when it quits the editor entirely. Other editors (especially on OS X) have the behavior of having a "no documents open" mode, not sure if this is translatable to this editor, but maybe a prompt to quit when invoking escape would be nice so that repeated presses of it wouldn't return the user all the way back to the shell.
Specifications
ProductName:	Mac OS X
ProductVersion:	10.12.1
BuildVersion:	16B2555

Version: 1.1.2
Commit hash: c04a4ba
Compiled on October 24, 2016

This functionality got merged in #522, closing this issue.


Using #tansact(): Uncaught TypeError: Cannot read property '__' of undefined

Using #transact() along with store#get and store#set results in the error: Uncaught TypeError: Cannot read property '__' of undefined
This can easily be reproduced using the Undo Redo demo of freezer: http://jsbin.com/hugusi/1/edit?js,output
Find the #handleRemove() function and change the following line:
	this.props.parent.splice( this.props.attrkey, 1 );

to
	var trans = this.props.parent.transact();
	trans.splice( this.props.attrkey, 1 );
	this.props.parent.run();

In the app remove a node and then undo.
Subsequent attempts to remove a node results in the exception.

Thanks @zenfe I am on holidays for the next 10 days. I'll have a look at it when I come back ;)

My original use case mimics how I'm using Freezer in my app. However I just noticed that even without making the code change to the demo I can reproduce the same exception.
Delete node -> undo -> try to delete the same node = exception

Hey @zenfe
Sorry for the delay addressing this issue, you know holly-days :)
There was a bug binding the parents to the nodes passed to the reset method, that's why there was that error trying to delete the same node.
It should be fixed now in v0.6.1.
I'm looking forward to giving some love to freezer now that I'm back. Stay tuned.


Missing file name from ConfbridgeStartRecordAction

When using ConfbridgeStartRecordAction (http://asternet.github.io/AsterNET/html/T_AsterNET_Manager_Action_ConfbridgeStartRecordAction.htm), the documentation says that this action can be given a specific file name to be used for recording the conference. It seems this property is missing from the class.

I am not sure what is missing. The class looks correct and it has some summary comments.
https://github.com/AsterNET/AsterNET/blob/master/Asterisk.2013/Asterisk.NET/Manager/Action/ConfbridgeStartRecordAction.cs

https://github.com/AsterNET/AsterNET/blob/b9f3ec64d840ed68190972ee666925b9078deb99/Asterisk.2013/Asterisk.NET/Manager/Action/ConfbridgeStartRecordAction.cs
Yeah I see no property called "Filename" or anything.
https://wiki.asterisk.org/wiki/display/AST/Asterisk+14+ManagerAction_ConfbridgeStartRecord
The Asterisk documentation suggests that there should be an optional RecordFile property.
This simply need to be added.

I can help, if you need help. Fork and PR, as usual?


When preempt, the released resources cannot meet the scheduling needs

What happened:
I create two clusterqueue and set reclaimWithinCohort = Any,  when preempt, the released resources cannot meet the scheduling needs.
For example, when i submit one (1 * 2GPUs) task，I want this task to get 2 GPUs on the same machine，however, the resources released after preemption are one machine has 0.5 GPUs and the other has 1.5 GPUs

What you expected to happen:
I want this task to get 2 GPUs on the same machine,
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):
Kueue version (use git describe --tags --dirty --always): v 0.4.1
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

cc @B1F030 can you help to take a look?

Could you please provide yaml of ResourceFlavor, ClusterQueue, and Job?
/triage needs-information
I guess you need to set an only-a-clusterqueue.
For example, there are two clusterqueues: gpu-a-cq and gpu-b-cq, they are in the same cohort, so that they can share resources with eachother.
When preemption happens, everything goes right. But when you want to create a workload that can only run on gpu-a-cq, you will need to create another clusterqueue, as only-a-cq, that not belongs to any cohort.
If you claim workload to the only-a-queue, this workload will only use gpu-a. Is that what you want?

Could you please provide yaml of ResourceFlavor, ClusterQueue, and Job? /triage needs-information I guess you need to set an only-a-clusterqueue. For example, there are two clusterqueues: gpu-a-cq and gpu-b-cq, they are in the same cohort, so that they can share resources with eachother. When preemption happens, everything goes right. But when you want to create a workload that can only run on gpu-a-cq, you will need to create another clusterqueue, as only-a-cq, that not belongs to any cohort. If you claim workload to the only-a-queue, this workload will only use gpu-a. Is that what you want?

gpu-a-cq clusterqueue: :
spec:
cohort: gpu-hlp
namespaceSelector: {}
preemption:
reclaimWithinCohort: Any
withinClusterQueue: Never
queueingStrategy: StrictFIFO
resourceGroups:

coveredResources:

cpu
memory
nvidia.com/gpu
flavors:
name: gpu-hlp
resources:

borrowingLimit: "0"
name: cpu
nominalQuota: "57"
borrowingLimit: "0"
name: memory
nominalQuota: 209Gi
borrowingLimit: "0"
name: nvidia.com/gpu
nominalQuota: "8"

gpu-b-cq clusterqueue: :
spec:
cohort: gpu-hlp
namespaceSelector: {}
preemption:
reclaimWithinCohort: Never
withinClusterQueue: Never
queueingStrategy: StrictFIFO
resourceGroups:

coveredResources:

cpu
memory
nvidia.com/gpu
flavors:
name: gpu-hlp
resources:

borrowingLimit: "57"
name: cpu
nominalQuota: "0"
borrowingLimit: 209Gi
name: memory
nominalQuota: 0
borrowingLimit: "8"
name: nvidia.com/gpu
nominalQuota: "0"

resourceflavor:
apiVersion: kueue.x-k8s.io/v1beta1
kind: ResourceFlavor
metadata:
creationTimestamp: "2023-08-30T09:17:46Z"
finalizers:

kueue.x-k8s.io/resource-in-use
generation: 1
name: gpu-hlp
resourceVersion: "3121760923"
selfLink: /apis/kueue.x-k8s.io/v1beta1/resourceflavors/gpu-hlp
uid: e48e90c9-5fdd-41d6-9f77-11cea43b5125
spec: {}

resource pool has tow 4 GPUS nodes，i submit 2 GPUs * 1 pod job to gpu-a-cq, however the resources released after preemption are one machine has 0.5 GPUs and the other has 1.5 GPUs, can not meet the job scheduling needs

Could you also paste the Job yaml too?

Could you also paste the Job yaml too?

ok, just sample pod yaml, resource is:
Resources:
Limits:
Cpu:             2
Memory:          5Gi
nvidia.com/gpu:  2
Requests:
Cpu:     2
Memory:  5Gi
nvidia.com/gpu:  2
kueue preemption strategy is to preempt those with lower priorities first, and those with the same priority that have a shorter startup time are preempted first.

Since your ResourceFlavor has nil spec, I recommend to use default-flavor.
Would you like to try these yamls below, and see if that problem happens again?
gpu-a-cq.yaml
apiVersion: kueue.x-k8s.io/v1beta1
kind: ClusterQueue
metadata:
  name: "gpu-a-cq"
spec:
  namespaceSelector: {} # match all.
  cohort: "gpu-ab"
  queueingStrategy: StrictFIFO
  resourceGroups:
  - coveredResources: ["cpu", "memory", "nvidia.com/gpu"]
    flavors:
    - name: "default-flavor"
      resources:
      - name: "cpu"
        nominalQuota: 57
        borrowingLimit: 57
      - name: "memory"
        nominalQuota: 209Gi
        borrowingLimit: 209Gi
      - name: "nvidia.com/gpu"
        nominalQuota: 8
        borrowingLimit: 8
  preemption:
    reclaimWithinCohort: Any
    withinClusterQueue: LowerPriority

kubectl create -f gpu-a-cq.yaml
gpu-b-cq.yaml
apiVersion: kueue.x-k8s.io/v1beta1
kind: ClusterQueue
metadata:
  name: "gpu-b-cq"
spec:
  namespaceSelector: {} # match all.
  cohort: "gpu-ab"
  queueingStrategy: StrictFIFO
  resourceGroups:
  - coveredResources: ["cpu", "memory", "nvidia.com/gpu"]
    flavors:
    - name: "default-flavor"
      resources:
      - name: "cpu"
        nominalQuota: 57
        borrowingLimit: 57
      - name: "memory"
        nominalQuota: 209Gi
        borrowingLimit: 209Gi
      - name: "nvidia.com/gpu"
        nominalQuota: 8
        borrowingLimit: 8
  preemption:
    reclaimWithinCohort: Any
    withinClusterQueue: LowerPriority

kubectl create -f gpu-b-cq.yaml
localqueue-a.yaml
apiVersion: kueue.x-k8s.io/v1beta1
kind: LocalQueue
metadata:
  name: gpu-a-queue
spec:
  clusterQueue: gpu-a-cq

kubectl create -f localqueue-a.yaml
localqueue-b.yaml
apiVersion: kueue.x-k8s.io/v1beta1
kind: LocalQueue
metadata:
  name: gpu-b-queue
spec:
  clusterQueue: gpu-b-cq

kubectl create -f localqueue-b.yaml
sample-job.yaml
apiVersion: batch/v1
kind: Job
metadata:
  generateName: sample-job-
  labels:
    kueue.x-k8s.io/queue-name: gpu-a-queue
spec:
  suspend: true
  template:
    spec:
      containers:
      - name: dummy-job
        image: gcr.io/k8s-staging-perf-tests/sleep:latest
        imagePullPolicy: IfNotPresent
        args: ["60s"]
        resources:
          limits:
            cpu: 2
            memory: "5Gi"
            nvidia.com/gpu: 2
          requests:
            cpu: 2
            memory: "5Gi"
            nvidia.com/gpu: 2
      restartPolicy: Never

kubectl create -f sample-job.yaml

i had solved this problem by adding node resource scheduling，can i solve this problem ? gratefully  @kerthcet

Does the node resource scheduling means the nodeResourceFit plugin in kube-scheduler?

Does the node resource scheduling means the nodeResourceFit plugin in kube-scheduler?

yes，we can add this plugin to solve the problem of the released resources cannot meet the scheduling needs after preempted

Generally, kueue can not solve this problem as kueue and kube-scheduler are two different components, they can't aware of each other, so let's close this so far. Thanks for your feedbacks.
And waitForPodsReady in kueue may help you here as well, the Job will be requeued after a period time of not-ready.
/close


During the runtime of a Spring Boot project, if an exception occurs with the data source connection, how can the data source automatically recover its connection after it has been restored?

**dbtype: mysql
**dbversion: 8.0.35
**druid verion: 1.2.1
error sql:
testcase code:
stacktrace info:
**error info: mysql connection error
At project startup, the database is functioning normally.  During project operation, an abnormality with the database server leads to exceptions in database connections.  This results in the Spring Boot project continuously reporting errors, causing exception requests to exhaust the resources of the database connection pool and thereby rendering the Spring Boot project unresponsive.
Question 1: How can we prevent exception requests from depleting the database connection pool resources and causing the project to hang?
Question 2: Without restarting the Spring Boot project, how can we enable the database connection pool to automatically restore connections to the异常database service, thereby restoring normal operation to the entire project?

请使用最新的1.2.22验证。


Build Carthage dependencies in all architectures when running make update

This stops the usage of
Scripts/carthage-with-workaround-for-issue-3019.sh when building the project’s dependencies using Carthage for local development (i.e. when running make update or one of its sub-commands).
This file was seems to have been originally introduced to fix an error related to duplicate architectures when running Carthage. I don’t get any errors switching back to plain Carthage without a wrapper when running make update on my M1 Pro machine, using Carthage 0.38.0. Given that the linked issue https://github.com/Carthage/Carthage/issues/3019 is now marked as resolved, I guess something was changed in Carthage that resolves this for us 🤷.
This closes #1506, where we were seeing "Undefined symbol: OBJC_CLASS$_ARTDeltaCodec" errors running make test_iOS on M1* machines. I guess in the part of the script where we exclude ARM architectures (I don’t exactly know what that means) we had stopped building something that we needed to run on the current platform.
We’re still using this file for the make carthage_package task. We should check whether we need it there too, but since that might have user-facing consequences (instead of just breaking our development environment) I don’t want to do that hastily. I’ve created a separate issue #1509 for that.

It would be great if somebody on an Intel machine could run make update and see if they get any errors. @maratal, @QuintinWillison?

Hmm, well, this is failing on CI. Putting to draft.

I just ran make update on my Intel-based MacBook Pro, as requested, and have shared the successful result with @lawrence-forooghian in this Slack thread (internal).

The only thing I might have expected is for the workaround script file to be removed as part of this PR, as I presume it's now dead wood?

@QuintinWillison I think I addressed this in the PR description?

We’re still using this file for the make carthage_package task. We should check whether we need it there too, but since that might have user-facing consequences (instead of just breaking our development environment) I don’t want to do that hastily. I’ve created a separate issue #1509 for that.


[Bug]: Line chart dots not visible when a series color is set

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When the series color for a line chart is changed, the bubbles or data indicators are not colored

Steps To Reproduce

Add a new line chart
Change the series color of the line chart using the color picker
Observe the dots or data points not having any color

Public Sample App
No response
Issue video log
No response
Version
Cloud

The chart widget looks broken hence the high label

Changing to medium as there are some challenges in reproducing this accurately, sometimes I can see the dots hidden other times they are in older color.

Stats

Stat
Values

Reach
82

Effort (months)
0.5


Ignore case when parsing units

Fixes https://github.com/Thomasdezeeuw/human-size-rs/issues/17.

Thanks @jyn514!


Mod crashes when i hit zombie

Minecraft Version: 1.16.4
Forge Version: 1.16.4
Mod Version: 1.16.4
Single Player or Server: single player
Describe problem (what you were doing; what happened; what should have happened): i have disable player targeting on so the mobs won't fight me, but if i try to hit any kind of zombie my game crashes
Log file link: sorry, i don't know how to do this :/
Video/images/gifs (direct upload or link):
If your bug is related to anything causing LAG you need to measure the lag by taking a sample https://minecraft.curseforge.com/projects/sampler

My Crash Log
I'm in 1.16.5

This line seems to be the issue, as the game is checking if the mob is allied after it is set to null, resulting in this crash.

Still a bug in 1.19 too