Add 3

Am I doing this right?!?

When can I expect this to be merged. My very important company with many important things to do other than babysit this PR require this change. Please merge and tag a release asap.

When can I expect this to be merged. My very important company with many important things to do other than babysit this PR require this change. Please merge and tag a release asap.

Sure I'll get right on that. As soon as I've finished writing this Medium post about open source burnout.


system_deep_sleep works?

I attach a test code, extracted from 06_sntp example. In previous comments we cloud enter  the CPU in sleep mode in a similar way as exposed in test code.
In test code CPU doesn't enter in deep sleep.
sdkconfig.txt
sntp_main.txt

@jolivepetrus, please try running the example with the latest code in master. system_deep_sleep has been rewritten and the example is working in my tests.

Perfect, I confirm that with latest code in master system_deep_sleep works fine.
Thanks.


fetching NFTs by address via an API, NFT cards UI, bugfixes & metamas…

…k balance

We could write a little message for people like me who doesn't have any NFTs :'-)


Set option to allow any origin option on jupyter

This helps with #230, accessing jupyter from webshell issues.

Rejecting this since we cannot use Jupyter with Cloud Shell Preview (see discussion in #230 ). Removing security measures unnecessarily makes me nervous :)


added fsdiff-pod.yaml

@isaacdorfman can you update the .github/actions/ to verify that the pod is up and running ?

@isaacdorfman can you update the .github/actions/ to verify that the pod is up and running ?

Good point. Please update the workflows to include the new pod.

General comment: update README.md

CNF under test and partnet pods templates should also be rendered with mustache. Otherwise deployment is inconsistent. Some pods are created in the tnf namespace and orchestrator and fsdiff are generated in the specified namespace. Maybe it would be nice to set "tnf" as the default value for the namespace, otherwise if not specified, the make clean will not work (because can;t delete default namespace)

CNF under test and partner pods templates should also be rendered with mustache. Otherwise deployment is inconsistent. Some pods are created in the tnf namespace and orchestrator and fsdiff are generated in the specified namespace. Maybe it would be nice to set "tnf" as the default value for the namespace, otherwise if not specified, the make clean will not work (because can;t delete default namespace)

Good catch. Definitely the partner pod namespace needs to be consistent with fs-diff pod. The original requirement is actually more on the partner pod where we initiate network connectivity test. For multus, the partner pod needs to be in the same namespace as the CNF under test.
For the our test CNF, it's probably ok to have a fixed namespace for now. Although, we may need to share an ocp cluster for development purposes. It would be benificial if its namespace is also templated.


data_transform in extract_feature_map_resnet_101_xxxxx

"data_transforms" in folder "extract_feature". You first resize the image to input_size and then centercrop input_size? Is there some mistake?
transforms.Resize(input_size),
transforms.CenterCrop(input_size),

You may need to take a look at pytorch official document
https://pytorch.org/vision/main/auto_examples/plot_transforms.html#sphx-glr-auto-examples-plot-transforms-py

https://pytorch.org/vision/main/auto_examples/plot_transforms.html#sphx-glr-auto-examples-plot-transforms-py

@litianjun05090 Thank you for your help! I was not very famaliar with all those python and pytorch functionality and got confused. I've learned it back then. But, still, thank you anyway!


Make a link more visible

A link that is also code doesn't visually appear as a link. So I moved the link to some non-code text instead.

Thanks!


Pre-param generation: cleanup and wiring this together

Refs #3161
The first change is the series of renames and function export changes. To not confuse our operators that the Keep client is "mining" blocks, the miner package and struct have been renamed to generator and Scheduler. The Scheduler name better describes the responsibilities of the structure - it is stopping and resuming long-running tasks.
Secondly, we no longer expect protocol goroutines to call Stop() and Resume(). Instead, there is a global monitoring goroutine started when the Scheduler is created that queries the protocols. This change allows removing the quite complicated concept of a WaitGroup-based latch.
ProtocolLatch increases the internal counter every time protocol execution starts and decreases the counter every time protocol execution completes. The latch implements Protocol interface and can be registered in the Scheduler.
The protocol code using the latch must guarantee that:

Lock() is always called before Unlock()
Unlock() is eventually called for every Lock().

Note that the Unlock() function may panic if the conditions are not met.
The Scheduler and ProtocolLatch have been integrated with all protocols executed by the client:

random beacon DKG,
ECDSA DKG,
random beacon relay entry signing.

The Scheduler should stop and resume computations according to the state of protocols executed.
The default size of pre-parameters pool has been increased to 3000 elements. Pre-parameters are generated only when no other protocol is running and we should squeeze from that time as much as possible so that we have enough pre-parameters for all potential DKG ECDSA retries. Assuming generating single pre-parameters takes 1 minute, then generating 3000 pre-parameters takes 2 days.

@pdyraga I'm good to merge but we have conflicts here.


Getting images from the crawl

I am trying to crawl weapons images and since the nutch that memex uses has the mimetypes.txt to only accept text/html will I have to add images/* there so that it accepts all images as memex crawls through the seedlist ?

Hi @saloneerege.  That sounds right to me.  @chrismattmann - do you have some thoughts on this?

correct


Replace keywords with codes in .pylintrc file

Another issue opened for this task #36.
Closing this one.


Add flag to clear all browsing data on exit

This PR adds a new flag that, when enabled, clears all browsing data on exit.
This can be enabled  through chrome://flags or by adding --enable-features=ClearDataOnExit to the launch options.

ChromeBrowsingDataLifetimeManager already does most of the work and even has the benefit of continuing clearing the data on startup if the process was not completed on shutdown for some reason.
Returning max unsigned long longs for the removal masks makes it so that all data that can be removed by the BrowsingDataRemover will be removed and also means that the patch won't need to be updated when new data types are added or removed.
Fixes #791

Love this PR!!! Finally someone implemented it and in an elegant way. :heart:

Why is it only available on desktop?

Yeah, I had attempted to see if there was an elegant way to get that working on android as well but the storage and removal is handled differently.  Not to mention there rarely is an "on exit" as well.  Luckily settings and bookmarks can still be accessed when in incognito on android, so something like Bromite's always incognito patch would be a good substitute.

@Ahrotahn Thank you very much for this excellent feature! However, in the latest version, from the macchrome it deletes all bookmarks https://github.com/macchrome/winchrome/releases/tag/v92.0.4515.107-r885287-Win64
Can it be fixed somehow?

Yes, I have a change ready that updates the patch to specify what to delete.  I'll submit the PR after 92 lands.

@Ahrotahn Hi, I'm confused how this merge solves #791 . I'm using the flatpak version and there's no option for clearing all data on exit like Brave. So is the PR actually merged?

Ah, I'm sorry. I just noticed the special flags created for ungoogled-chromium. Apparently I need https://github.com/Eloston/ungoogled-chromium/blob/master/docs/flags.md#available-only-on-desktop-1
Thanks for the PR!

Weird, I can't find the CLearDataOnExit flag.

Weird, I can't find the ClearDataOnExit flag.

chrome://flags/#clear-data-on-exit
ClearDataOnExit is passed to --enable-features switch.

@Dyrimon Was the flatpak you used built within the last week?  It's possible it may be from before this was merged.

@Ahrotahn Hi the About Chromium shows Version 91.0.4472.164 (Official Build, ungoogled-chromium) (64-bit)
This is the latest build I presume, could you please tell me how to enable the --enable-features option?

@Dyrimon, this feature is not available at 91.0.4472.164

@Dyrimon, this feature is not available at 91.0.4472.164

Dang, so mine is not the latest build? The github Releases shows this one is.

It is the latest!
The thing is that Eloston first merged #1570 and this PR was therefore after it. But the tag was created at the point of merge of the former, not the latter. This all means that this PR should be available with the next 92 release. Or if you apply this as patch yourself while building.

@Ahrotahn Thank you very much for this excellent feature!  I love this feature, and I wanna know is it possible that clear history and cache but keep cookie so that I don't need to login sites everytime?

@fernvenue perhaps this comment could be of some help.

Hi @touba-denrael, thanks for your reply, and I just tried your solution, unfortunately that will keep browser history also, and what I wanna do is just keep cookies but clear all the history, anyway thanks again for your reply!

@fernvenue

unfortunately that will keep browser history also
keep cookies but clear all the history

clearing history is only done manually [shift+ctrl+delete] with this combination of settings [sorry, forgot to mention that earlier].
hopefully, someone with more knowledge will be of more help [these couple of key presses became nearly automatically done by me before exiting from the browser].

@fernvenue
just remembered, there exist this thread, so when the pull request will [at last] be ready, merged, the newest iteration of ungoogled chromium, with these [possibly coming] changes, will be capable of doing what you are aiming for.


P256 signature verification was succeed with 2 public key.

I tried to recover public key from P256 signature.
With 2 recovery id ( 0, 1 ), signature makes 2 public key.
And I tried to verify signature with public key and verification was succeed all of 2 keys.
Isn’t it correct that only one of the two should succeed?
Or is there some cryptographic knowledge I don't know about?
Is it correct that both public keys succeed?
I attach the data I used below.
original public key
asn1 der (hex) :<PHONE_NUMBER>072a8648ce3d020106082a8648ce3d03010703420004761c025b761d7a7c6d4bfd8d944975915e3d4879a2fead6e4417bdfe5de0ac36f5730e0e8082a3a964bd1e503236b1356f086b08dc39cc24288c6ef563917c53
---
x (hex) : 761c025b761d7a7c6d4bfd8d944975915e3d4879a2fead6e4417bdfe5de0ac36
y (hex) : f5730e0e8082a3a964bd1e503236b1356f086b08dc39cc24288c6ef563917c53

Signature
raw message (hex) : 49960de5880e8c687434170f6476605b8fe4aeb9a28632c7995cf3ba831d9763050000000047e4a6a9816d7dd36ad0772e8738f9423d147ebf0253cc91c5a0def297d0decb
sha256 hashed message ( for signature recovery ) (hex) : fdb2e37b8fdc643c1c94e1a1abd1876966e8f17a2d63dd2e4acb7be2e680751a

signature asn1 der (hex) :<PHONE_NUMBER>cf4f49499b70e7fcc76193478fedcba4735456d9ca3b4fda3feafe2c16e35b6d022100cb30d5bbbb42eca0fb4dd8b056df2e058db0b8dc63e2f52d137cb580688f4063
- r (hex) : cf4f49499b70e7fcc76193478fedcba4735456d9ca3b4fda3feafe2c16e35b6d
- s (hex) : cb30d5bbbb42eca0fb4dd8b056df2e058db0b8dc63e2f52d137cb580688f4063

Recovered Public Key
recovered public key with recovery id 0
hex : 04260e3fa4c347cccdcc12e86e2f1a543f679648a31d0b26484da39f75b16b0be06d8f8231e1f819368c6c0dc52a9e62a3e90095478ead3ba4ee62e84e90182862
- x (hex) : 260e3fa4c347cccdcc12e86e2f1a543f679648a31d0b26484da39f75b16b0be0
- y (hex) : 6d8f8231e1f819368c6c0dc52a9e62a3e90095478ead3ba4ee62e84e90182862

recovered public key with recovery id 1
hex : 04761c025b761d7a7c6d4bfd8d944975915e3d4879a2fead6e4417bdfe5de0ac36f5730e0e8082a3a964bd1e503236b1356f086b08dc39cc24288c6ef563917c53
- x (hex) : 761c025b761d7a7c6d4bfd8d944975915e3d4879a2fead6e4417bdfe5de0ac36
- y (hex) : f5730e0e8082a3a964bd1e503236b1356f086b08dc39cc24288c6ef563917c53

and all of two keys succeed to verify above signature(3046022100cf4f4....).
In order to extract the correct public key from the signature, I obtained the public key corresponding to all recovery IDs (0 to 3, a total of 4), and verified the signature with these public keys to find a successful public key.
However, both public keys successfully verified their signatures. I'm curious about this.
Below is the code where I experimented with this process.
import {secp256r1} from '@noble/curves/p256'
import sha256 from 'sha256';

async function test2() {
    let pub = 'MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAEdhwCW3YdenxtS_2NlEl1kV49SHmi_q1uRBe9_l3grDb1cw4OgIKjqWS9HlAyNrE1bwhrCNw5zCQojG71Y5F8Uw'
    let hexPub = Buffer.from(pub, 'base64').toString('hex')
    console.log(hexPub)
    const mayBeX = '761c025b761d7a7c6d4bfd8d944975915e3d4879a2fead6e4417bdfe5de0ac36' // i want find this public key from signature ( assume i dont know recovery id )
    const mayBeY = 'f5730e0e8082a3a964bd1e503236b1356f086b08dc39cc24288c6ef563917c53' // i want find this public key from signature ( assume i dont know recovery id )

    const testChallengeHex = '49960de5880e8c687434170f6476605b8fe4aeb9a28632c7995cf3ba831d9763050000000047e4a6a9816d7dd36ad0772e8738f9423d147ebf0253cc91c5a0def297d0decb'
    const testHexSig = '3046022100cf4f49499b70e7fcc76193478fedcba4735456d9ca3b4fda3feafe2c16e35b6d022100cb30d5bbbb42eca0fb4dd8b056df2e058db0b8dc63e2f52d137cb580688f4063'

    const msgHash = sha256(Buffer.from(testChallengeHex, 'hex'));
    let sigObj = secp256r1.Signature.fromDER(testHexSig)
    console.log('signature')
    console.log(sigObj.r.toString(16))
    console.log(sigObj.s.toString(16))

    sigObj = sigObj.addRecoveryBit(0)
    console.log(`msgHash`)
    console.log(msgHash)
    console.log('----------------')

    const recovered = sigObj.recoverPublicKey(msgHash);
    console.log(`recovered`)
    console.log(recovered.toHex(false))
    console.log(recovered.toAffine().x.toString(16))
    console.log(recovered.toAffine().y.toString(16))
    console.log('----------------')
    const verified = secp256r1.verify(sigObj, msgHash, recovered.toHex(false))
    console.log(verified)

}

test2().catch(console.log)

Thank you for your interest in my problem.

@paulmillr then, you mean that it is theoretically correct to verify a single signature with two public keys?

Correct, it's called "Exclusive Ownership", and ECDSA does not have this property.
verif 0 02260e3fa4c347cccdcc12e86e2f1a543f679648a31d0b26484da39f75b16b0be0 true
verif 1 03761c025b761d7a7c6d4bfd8d944975915e3d4879a2fead6e4417bdfe5de0ac36 true

EDDSA (ed25519) does not suffer from that problem, when implemented properly.


Adding old code to repo

Adding the code we had to the repo.

Killing this to see if I can get it to work with the eslint action.


Fix gating to set sudo_command when sensu is disabled

The change introduced in #136 managed to leave $sudo_command unset when sensu is disabled due to improper tired if statements. This single if statement restores the desired behaviour.

:shipit:


Create release after PR has been completed

Hi,
Is there a way to only trigger a release once a pull request has been approved or completed?
We don't want to deploy artifacts that have failed a code review (for example).
Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5cbb2877-5e10-4065-e3c6-7883e9df4b3c
Version Independent ID: 58122a19-2258-3cf3-8335-74bb0dad892f
Content: Deploy pull request builds - Azure Pipelines
Content Source: docs/pipelines/release/deploy-pull-request-builds.md
Product: devops
Technology: devops-cicd
GitHub Login: @raiyanalam
Microsoft Alias: moala

Hi,
Once the pull request is merged to a target branch, lets say master, a commit is created in the master. So you can have a trigger set up on the master branch. This will trigger a pipeline run only when the code is merged after approval.
Hope this helps.

I've have this issue. I want to deploy the code to the first pipeline stage for testing after the PR review is done for hotfixes but before the merge to master occurs, and defer the merge until the testing on the test environment is done .It would be ideal if the pipeline would look at the PR request status from GitHub  and defer deploy if it has not passed the review requirement.

I have this issue as well.
I originally had a trigger on my branch for CI/CD, but have decided to make a passing build required for pull requests to be completed. Once this was set up I found that I'd be running a build pipeline after the creation of a PR (to verify successful build in order to complete the PR), and essentially running the same build pipeline after the PR was completed (because of the CI trigger on the branch).
At first I thought that pull request triggers would be the solution to my problem, but I don't want to trigger a release until the PR is actually completed.
Is there any workaround for this case besides running pipelines multiple times or manually creating releases?


typo: fixed keyword on sample code

Just a small fix, the sample for the enum was using the wrong keyword.

Thanks!


As a user, on the contact null the Account name.  Current address does not change and new household account does not get an address record.

As a user, in the Household account model, on a contact record with a default address (no address override), I null the Account Name and hit Save.  A new Household Account is created as expected but

the contact retains its connection to the old address on the old household
the new household account does not create a new custom address record.

I was expecting that a new custom address record would be created on the new account with the contact being update so the "current address" field points to the new address.
Verified this behavior in two accounts.

Same result when taking an existing contact and changing households (moving from one household to another).  Even occurs when the existing contact did not have a current address assigned.

fixed with contact merge work in version 3.39


NEST-462: Upgrade to OC 1.8.0-preview-17696

NEST-462

This doesn't need to be merged to dev, because it's a preview version, the preview branch will be used instead.


chore: bdd-spring-1584282200 to 0.0.1

chore: Promote bdd-spring-1584282200 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


feat: plan gwa updates

We're pretty far behind the curve.  There's likely a clean, automated solution we can put together to stay current.
Downloads available here.
https://github.com/bcgov/gwa-cli

Here's a gist that'll probaby do!  Or we come up with our own idea.
https://gist.github.com/steinwaywhw/a4cd19cda655b8249d908261a62687f8

I'll test and update with the latest CLI


optimization.splitChunks.maxSize throws error or causes build to hang

Bug report
What is the current behavior?
An error is thrown when attempting to use optimization.splitChunks.maxSize or optimization.splitChunks.cacheGroups.{cachegroupname}.maxSize
Example config:
optimization: {
    splitChunks: {
      chunks: "initial",
      //maxSize: 10000,
      cacheGroups: {
        default: false, // disable the built-in groups, default & vendors (vendors is overwritten below)
        vendors: {
          test: /[\\/]node_modules[\\/]/,
          name: "vendors",
          priority: 10,
          //enforce: true, // create chunk regardless of the size of the chunk
          maxSize: 10000
        }
      }
    }
  },

throws the following error:
setup/node_modules/webpack/lib/util/deterministicGrouping.js:168
				leftSize += group.nodes[left].size;
				                              ^
TypeError: Cannot read property 'size' of undefined
    at module.exports (......../minimal-react-webpack-babel-setup/node_modules/webpack/lib/util/deterministicGrouping.js:168:35)
    at compilation.hooks.optimizeChunksAdvanced.tap.chunks (......../minimal-react-webpack-babel-setup/node_modules/webpack/lib/optimize/SplitChunksPlugin.js:797:23)

Setting maxSize at the splitChunks level causes the same error.
Uncommenting the line //enforce: true, removes the error but causes the build to hang.
If the current behavior is a bug, please provide the steps to reproduce.
Clone the following repo:
https://github.com/chrisckc/minimal-react-webpack-babel-setup
Follow the instructions in the readme
This error was first spotted in a more complex app, so i found and forked a less complex app repo to verify the bug.
I can't make the demo repo any simpler because there needs to be enough node modules available to recreate the issue.
What is the expected behavior?
It should create multiple 'vendors' chunks each capped at maxSize or as close as possible.
Other relevant information:
webpack version:  v4.23.1
Node.js version: v8.11.4
Operating System: MacOS 10.13.4
Additional tools: VSCode, mac terminal

Looks the same as this issue:
https://github.com/webpack/webpack/issues/7455
which is claimed to be fixed by this:
https://github.com/webpack/webpack/pull/7651

@sokra Just had a look at the change which sets max size using Math.max(minSize, maxSize)
This prevents the crash but the hang during build remains when i use either enforce: true or a minSize less then maxSize such as minSize: 1000, in the config as follows:
optimization: {
    splitChunks: {
      chunks: "initial",
      minSize: 1000,
      //maxSize: 10000,
      cacheGroups: {
        default: false, // disable the built-in groups, default & vendors (vendors is overwritten below)
        vendors: {
          test: /[\\/]node_modules[\\/]/,
          name: "vendors",
          priority: 10,
          //enforce: true, // create chunk regardless of the size of the chunk
          maxSize: 10000
        }
      }
    }
  },

The issue seems to be caused by a loop as the node process starts to use all of the CPU and consumes the RAM at a steady rate.

If maxSize is specified at the the splitChunks level as per the following config, it works fine:
optimization: {
    splitChunks: {
      chunks: "initial",
      minSize: 1000,
      maxSize: 10000,
      cacheGroups: {
        default: false, // disable the built-in groups, default & vendors (vendors is overwritten below)
        vendors: {
          test: /[\\/]node_modules[\\/]/,
          name: "vendors",
          priority: 10,
          //enforce: true, // create chunk regardless of the size of the chunk
          //maxSize: 10000
        }
      }
    }
  },

The output is as follows:
bundle.js  8.62 KiB       0  [emitted]  main~26a0f563
vendors~0928ebd2.11051f8abac033be4592.chunk.js  96.1 KiB       1  [emitted]  vendors~0928ebd2
vendors~53127b40.63e088532ae1ece53785.chunk.js  4.76 KiB       2  [emitted]  vendors~53127b40
vendors~c1dd23ef.781dbcd770ccb43df9c7.chunk.js  7.29 KiB       3  [emitted]  vendors~c1dd23ef

The larger chunk is due to the single large 'react-dom' module which is 96KB

There is also another issue when maxSize is used, large single modules larger than maxSize seem to be processed as they are split into 2 chunks, however the second chunk is always almost empty containing no module code.
I don't know for sure but i am guessing that it is not possible to split a single large module into smaller parts?
Either way this is a bug because if the module cant be split it should be left alone and remain as a single chunk, if it can be split then it should be split evenly.
using the following config which splits out 'react-dom'
optimization: {
    splitChunks: {
      chunks: "initial",
      minSize: 1000,
      maxSize: 10000,
      cacheGroups: {
        default: false, // disable the built-in groups, default & vendors (vendors is overwritten below)
        reactDom: {
          test: /[\\/]node_modules[\\/]react-dom[\\/]/,
          name: "vendor.react-dom",
          enforce: true,
          priority: 20
        },
        vendors: {
          test: /[\\/]node_modules[\\/]/,
          name: "vendors",
          priority: 10,
          //enforce: true, // create chunk regardless of the size of the chunk
          //maxSize: 10000
        }
      }
    }
  },

results in the following chunks:
bundle.js   8.63 KiB       0  [emitted]  main~26a0f563
vendor.react-dom~0928ebd2.18d3479e1d1e127ecfc1.chunk.js   96.1 KiB       1  [emitted]  vendor.react-dom~0928ebd2
vendor.react-dom~6a83488c.21c9b1ca71c8af4e38ae.chunk.js  312 bytes       2  [emitted]  vendor.react-dom~6a83488c
         vendors~0ba66fd7.70e5f1155bc6aa83b645.chunk.js   1.03 KiB       3  [emitted]  vendors~0ba66fd7
         vendors~53127b40.130f3482b0cc0e62c6ca.chunk.js   4.76 KiB       4  [emitted]  vendors~53127b40
         vendors~55119a63.5f817c5f775bf8ddc54f.chunk.js   6.08 KiB       5  [emitted]  vendors~55119a63

Notice the tiny 'react-dom' chunk in the output.
This is how i spotted the original issue as i tried to workaround that behaviour by using maxSize at the cacheGroup level instead of the splitChunks level.

@sokra  I can confirm that https://github.com/webpack/webpack/pull/8416
partially fixes the hang issue.
It fixes the following config whre maxSize is specified at the cacheGroup level:
optimization: {
    splitChunks: {
      chunks: "initial",
      minSize: 1000,
      //maxSize: 10000,
      cacheGroups: {
        default: false, // disable the built-in groups, default & vendors (vendors is overwritten below)
        vendors: {
          test: /[\\/]node_modules[\\/]/,
          name: "vendors",
          priority: 10,
          //enforce: true, // create chunk regardless of the size of the chunk
          maxSize: 10000
        }
      }
    }
  },

but does not fix the hang when enforce: true is used in the cacheGroup
optimization: {
    splitChunks: {
      chunks: "initial",
      minSize: 1000,
      //maxSize: 10000,
      cacheGroups: {
        default: false, // disable the built-in groups, default & vendors (vendors is overwritten below)
        vendors: {
          test: /[\\/]node_modules[\\/]/,
          name: "vendors",
          priority: 10,
          enforce: true, // create chunk regardless of the size of the chunk
          maxSize: 10000
        }
      }
    }
  },

Also hangs when using 'minSize: 0' instead of 'enforce: true' at cacheGroup level

hmm... I can't reproduce it with your repo. Could you update it to the problematic configuration?

That is working as expected in my opinion. These chunks are not empty, they contain only a small module. As minSize is 0 (enforce: true = minSize: 0) this is valid. The algorithm chooses chunks by heuristic within minSize and maxSize bounds. Here it chooses to make smaller chunks. It assumes that ./node_modules/scheduler/index.js (vendors~c171cc99.31b3b569dd046400b75b.chunk.js) and ./node_modules/react/index.js (vendors~cb5fc66c.bc349775f11c7f447ed9.chunk.js) are independent from each other. That's not too wrong as they are different npm packages... All the algorithm knows are the filenames. If you want bigger chunks, use a higher minSize value. The default is 30kb, but even lower values make sense when using HTTP/2.
Try to avoid enforce: true as it removes the default restrictions that i. e. prevent too small chunks.
You don't need to cacheGroups for npm packages. maxSize should automatically group them together as needed.
If single modules are larger than maxSize they are put alone into a chunk. i. e. this could happen for react-dom or other prebundled libraries. Actually it's a bit bad that they are prebundled, because we are unable to split them and can't fulfill maxSize here.

Thanks for the info, it makes sense now, after some more testing i can see that using MaxSize with 'enforce: true' is not a good combination. As you have pointed out , in the case of react, it splits out the node modules index.js from the rest of the prebundled code.
I did a bit more testing after adding webpack-bundle-analyzer.
In the case of this setup, making sure minSize is greater then 1500 prevents the index split from happening (the stat size of the index is just under that size).
In reality, for HTTP/2 , there is little point using a minSize of than 5000, as i understand it, there is a small size overhead involved in bundle splitting which will become noticeable if splitting into too many chunks.
I can get the same splits (in terms of size) using the built in cacheGroups for this simple example, but i prefer to specify cacheGroups to get more control over the content and naming of the chunks to aid long term cacheability. (combined with optimization.runtimeChunk: true and optimization.moduleIds: 'hashed')

On the subject of the 'enforce' option, the docs state the following:

Tells webpack to ignore splitChunks.minSize, splitChunks.maxSize, splitChunks.minChunks, splitChunks.maxAsyncRequests and splitChunks.maxInitialRequests options and always create chunks for this cache group.

I don't think that properly describes the behaviour of the option, it does not state that it also results in minSize being set to zero. The words "Tells webpack to ignore splitChunks.minSize" is a bit misleading.
As i have not really looked at the source, until you explained the behaviour i did not understand why a small shard of a chunk was being split from a module bigger than maxSize.
So in light of the above, how could a cacheGroup be specified such that it is always created but still respects the minSize setting specified at splitChunks level? In other words, always create the chunk but don't break tiny bits from it if it bigger than maxSize?
Would i need to specify each option, maxSize, minChunks, maxAsyncRequests and maxInitialRequests inside each cacheGroup to override any of those options set at splitChunks level?

It seems i can get around the fact that enforce: true sets the cacheGroup's minSize to zero by adding 'maxSize: Infinity' but it means i then lose out on the option to split the chunk if it is splittable, so it seems the only option is to specify each option individually.

Thinking about this a little more, would it not be better to have 'enforce: true' behave as follows:
"Always create the chunk regardless of splitChunks.minSize, splitChunks.maxAsyncRequests and splitChunks.maxInitialRequests. When creating the chunk, respect maxSize by attempting to split if bigger then maxSize, but only if this does not violate minSize."

Yeah it probably makes sense that enforce doesn't modify the minSize used for maxSize, but changing that would be a breaking change for v4. I can change it for v5.
Anyway try to avoid using enforce.

Actually the doc is a bit wrong about ignoring minSize. It's doesn't ignore it, it set the default to 0. If you specify enforce and minSize, it will respect minSize.

Maybe we can consider the fact that minSize is ignored for maxSize when enforce is specified as big that I can fix it

@sokra  I agree, here are some testing results:

If you specify enforce and minSize, it will respect minSize.

Tested that and found that it does indeed respect minSize when its specified on either splitChunks or the CacheGroup.  However if maxSize is then specified on the cacheGroup, minSize from splitChunks is not respected, minSize also has to be added to the cacheGroup as well for it to be respected.
This would suggest that maxSize from splitChunks is not being applied to a cacheGroup which has 'enforce: true', but that is not the case. I found that maxSize from splitChunks is respected when 'enforce: true' is used in cacheGroups, the following config demonstrates:
splitChunks: {
      chunks: "initial",
      minSize: 5000,
      maxSize: 10000
      cacheGroups: {
        default: false, // disable the built-in groups, default & vendors (vendors is overwritten below)
        reactDom: {
          test: /[\\/]node_modules[\\/]react-dom[\\/]/,
          name: "vendor.react-dom",
          enforce: true,
          priority: 20
        },
        vendors: {
          test: /[\\/]node_modules[\\/]/,
          name: "vendors",
          priority: 10,
          enforce: true
        }
      }
    }

produces the following chunks:
bundle.js  8.61 KiB       0  [emitted]  main~26a0f563
vendor.react-dom~ab68c3a7.2bb28aa6d557c3411cea.chunk.js  96.2 KiB       1  [emitted]  vendor.react-dom~ab68c3a7
         vendors~53127b40.63e088532ae1ece53785.chunk.js  4.76 KiB       2  [emitted]  vendors~53127b40
         vendors~c1dd23ef.6d185629eeec372d514b.chunk.js  7.02 KiB       3  [emitted]  vendors~c1dd23ef

notice that vendors has correctly been split because it would be bigger than 10k and vendor.react-dom is left intact because splitting it would violate minSize.
Before the fixes referenced here, which i noticed have now been released in v4.26.1, the above config would have created an additional vendor.react-dom chunk that violates minSize.
To sum it up, v4.26.1 solves the original issues, there just remains this edge case when using 'enforce: true' and MaxSize together on a cacheGroup.
The main use case for enforce, in my mind, is to override splitChunks.maxInitialRequests and splitChunks.maxAsyncRequests so that the chunk would always be created. It makes more sense than having to set maxInitialRequests maxAsyncRequests to Infinity on a cacheGroup. For enforce to make sense it also means minSize has to be ignored when deciding to create the chunk, but as you have said, it should still be respected when attempting to split the chunk.

Looks good.
I'm not a big fan of enforcing names on cacheGroups since this can also have drawbacks. But in this end it's a trade-off you can use.

Note: The priority needs to be higher than zero so that it is processed before the built-in cacheGroups.

The default cacheGroups have negative priority, so even priority 0 (default) can be used.

Regarding using name. There can't be two chunks with the same name. So if you try to give two chunks the same name they will merge. The same will happen with splitChunks. If you pass a name chunk could merge.
Let's compare these configurations:
{ test: /node_modules/ } (1) and
{ test: /node_modules/, name: "vendors" } (2).
We assume a scenario like this:
// module a
import "lodash";
import "react";

// module b
import "lodash";

// entry
import("./a"); // A
import("./b"); // B

Without splitChunks this will result in the following chunks:
chunk "main":
  - entry.js

chunk "a":
  - a.js
  - lodash
  - react

chunk "b":
  - b.js
  - lodash

A loads chunk "a"
B loads chunk "b"

With configuration (1):
chunk "main":
  - entry.js

chunk "a":
  - a.js

chunk "vendors~a~b":
  - lodash

chunk "vendors~a":
  - react

chunk "b":
  - b.js

A loads chunk "a", "vendors~a~b" and "vendors~a"
B loads chunk "b" and "vendors~a~b"

With configuration (2):
chunk "main":
  - entry.js

chunk "a":
  - a.js

chunk "vendors":
  - lodash
  - react

chunk "b":
  - b.js

A loads chunk "a" and "vendors"
B loads chunk "b" and "vendors"

This looks innocent, but notice how B loads more code than needed, so it may cause an unnecessary delay.


added dark mode in about us page and services page

🚀 Pull Request
Description
closes https://github.com/07sumit1002/CabRental/issues/211
Please include a summary of the changes and the related issue. Provide relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of Change

[+] New feature (non-breaking change which adds functionality)
added dark mode in about us page and services page

Checklist:

[+] My code follows the style guidelines of this project
[+] I have performed a self-review of my own code
[+] I have commented my code, particularly in hard-to-understand areas
[+] I have made corresponding changes to the documentation
[+] My changes generate no new warnings
[+] I have added tests that prove my fix is effective or that my feature works
[+] New and existing unit tests pass locally with my changes
[+] Any dependent changes have been merged and published in downstream modules

Screenshot of final output/video
about us page -

services page -

Please review @sanjay-kv

I will check all above mentioned issues and will work on ìt.

Sorry for late actually my exams are going on I will update it soon @akbatra567

Can you please review the changes that I have made @akbatra567 ? I have committed some changes.

Hello, @akbatra567 Please review the changes I have made in PR.

Requested changes are missing:

I see some common styles related to dark mode theme which is added to both about.html and serv.html and would be similar for other pages. Could you create an external css file and transfer the common css there and import that and verify if it works the same.

Let me explain this a bit on what you need to do:

See what all common styles you are using for the 2 html pages.
create a common css file name could be anything you feel adds more value, suggestions: dark.css - in case you only copy dark theme styles, else could be main.css / common.css
Import this newly created css file inside the html files replacing the duplicated code from the files. using <link rel="stylesheet" href='<add file path here>'>
Verify the styles if it working as expected.
Tag me when you complete these.

ok @akbatra567 i will update it soon

If this PR is merged then why its not showing "Accepted" on hacktoberbest website @07sumit1002

please add hacktoberfest-accepted labels to this PR @07sumit1002 and labels


use openssl provider instead of jdk provider to improve performance

This pr is to resolve @pingww 's review in PR-115 Support tls tcp server. Switch ssl provider to openssl, performance will be better.
link #51

Codecov Report

Merging #123 (b7c63d8) into main (0d8ecf3) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   45.01%   45.01%
=======================================
  Files         107      107
  Lines        4567     4567
  Branches      676      676
=======================================
  Hits         2056     2056
  Misses       2157     2157
  Partials      354      354

Impacted Files
Coverage Δ

...ache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d8ecf3...b7c63d8. Read the comment docs.


Changing filter operators on the fly

So, I've spent a quite a bit of time trying to find a way to change the type of filter applied to a stream of EEG data while it's being collected. Hopefully, we get to the point where we can swap operators in and out of an eeg pipe based on business logic.
Here I have an EEG epic (redux-observable) that uses switchMap to change the filter operator that is applied to an EEG stream based on emitted actions. The insight I had that let me do this was place the actual EEG data observable inside an observable listening for filter info actions (also inside another observable listening for graph start actions). As far as I can tell, the filter is getting applied immediately and I'm not losing any data. However, either the inner eeg data observable doesn't unsubscribe or the filter functions stack on top of each other because after switching filters once the graph gets all messed up. As if two listeners are writing to the same graph.
const setupGraphUpdate = (action$, store) =>
  action$.ofType(START_GRAPHING).pipe(
    filter(() => store.getState().device.eegObservable != null),
    switchMap(() =>  // SwitchMap to only propagate events from most recent filter type observaable
      action$.ofType(SET_FILTER_INFO).pipe(
        tap(() => console.log("filter changed")),
        pluck("payload"), //Extracts filterInfo
        switchMap(filterInfo =>
          store.getState().device.eegObservable // Upstream observable stored in Redux
          .pipe(
            groupByChannel(),
            defineFilter(filterInfo), // Switch function returns appropriate filter operator
            map(updateEEGBuffer),
            takeUntil(action$.ofType(RESET_FILTER))
          )
        )
      )
    ),
    catchError(error =>
      Observable.of(error).pipe(
        tap(p => console.log("setupGraphUpdate", p)),
        map(viewerError)
      )
    ),
    takeUntil(action$.ofType(STOP_GRAPHING, VIEWER_CLEANUP))
  );

Any idea what might be going wrong here and what the best solution will be going forward?

The current implementation I'm using isn't as elegant as what I was trying to do above, but it appears to be  working just fine.
Instead of using Redux Observable Middleware, all I do is keep a reference to an eegObservable and a filterObservable in the store. Components that need to use filtered data just subscribe to filterObservable as they need to. When I want to change filters, I just dispatch an action that cancels the previous filterObservable and replaces it with a new one. Then, each component's componentWillReceiveProps function resubscribes when they detect a new filteredObservable prop.
When I change filters this way the data keeps streaming continuously and I can hardly notice any disruption


NPM package for @stimulus/polyfills

Cool project!  Would love to see a package for https://github.com/stimulusjs/stimulus/tree/master/packages/%40stimulus/polyfills on NPM to ease adding IE/Safari support.  Thanks!

@javan the installation guide copy is not clear enough because it reads like you support IE11 without having to have polyfills. I have submitted a PR with a suggestion: https://github.com/stimulusjs/stimulus/pull/135

@javan I also think adding @stimulus/polyfills as an npm package would be really useful

I didn't see that the wheels were already in motion: https://github.com/stimulusjs/stimulus/pull/134

+1 to adding an actual @stimulus/polyfills package


Error discovering xUnit tests

https://github.com/xunit/xunit/issues/1334

@lyolikaa please share your VS version? Are these netcore tests or net46 tests? Do you have .NET 4.7 installed on machine?

Closing this issue since there isn't enough information to triage or reproduce.


Research consequences of removing an organization in SF

Will this cause a foreign key issue on orphaned resources?

This happened with Yale University. This used to be a duplicate issue in Salesforce, and then Chris H. deleted the dupe. However, there was one resource associated with the duped account. As a result, both Yale Universities show up in the Hub, even after I reassigned the resource to the appropriate account.

Closing for now


:robot: Triggering CI on branch 'release-next' after synching to openshift/master

tests will be triggere for this pr after we add prow jobs for openshift/tektoncd-pipeline-operatorrelease-next branch in openshift/release repo

/lgtm


Ads when connecting to a speaker

Describe bug
whenever I connect to a speaker, audio ads still play
Steps to replicate
just play a playlist and see ads still appear
Necessary screenshots

Spicetify and Spotify Version

Config file:

i mean i'd assume the only way this happens is if said speaker is making the requests to spotify itself, and given you're using an echo, that's probably the case


”Lunca Banului” is listed in the drop-down menu

Description:
"Lunca Banului" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Lunca Banului" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Lunca Banului, VASLUI".


Added missing course file AZ400_M05_L09_Setting_Up_and_Running_Functional_Tests.md

M05_L09: Missing course file prevents establishing connection to virtual machine.
Related Issue
Link related Github Issue 🢂 Fixes https://github.com/MicrosoftLearning/AZ400-DesigningandImplementingMicrosoftDevOpsSolutions/issues/487
I don't know if file content is correct - should stay as it is.

@LuizMacedo This should be closed as it's not related to GH issue.


Add missing strings by the English file

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[*] I have read the CONTRIBUTING document.
[*] Update translation/

All Submissions:

[Y ] Have you followed the guidelines in our Contributing document?
[Y ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

[Y ] Have you added an explanation of what your changes do and why you'd like us to include them?
[Y ] Have you successfully ran tests with your changes locally?

I closed this one and left the new pull to merge


Active address is allowed to be deleted - via store-api

PHP Version
7.4.23
Shopware Version
v<IP_ADDRESS>
Expected behaviour
possible solutions

Active address should not be deleted -> attempt to delete should end up with http error code (400?)
Active address (set via patch context) should not be set as default one to avoid errors on logging in
after the active address is removed, the first next address from address collection should be set as active one.

Actual behaviour
The problem comes when I set an active address on the checkout step, and some when later I delete this address on "My Account", if I do this then this will break the API context and the user will not be able to login anymore.
How to reproduce

set the active shipping address - PATCH /context
delete address via DELETE /store-api/account/address/${addressId}
log out
try to log in
you will see error like on log-in:

Argument 1 passed to Shopware\Core\Checkout\Customer\CustomerEntity::setActiveBillingAddress() must be an instance of Shopware\Core\Checkout\Customer\Aggregate\CustomerAddress\CustomerAddressEntity, null given, called in /app/platform/src/Core/System/SalesChannel/Context/SalesChannelContextFactory.php on line 478

related: https://github.com/vuestorefront/shopware-pwa/issues/1348

Hi @mkucmus @shyim I would like to resolve this issue - proceeding with option 1 in the possible solutions listed above. Would you mind assigning me this if you approve of this approach?

Is fixed already


Bug clear set when bitmap fastunion

Proposed changes
before:6 min 59.33 sec
after   :24.67 sec

run buildall


Managed alertmanager no longer running in clusters

Not sure if this is the right place to report such a bug, but we've been using managed alertmanager for a year now, and it seems that in the last few days, the pod has disappeared from a few of our clusters, all GKE Autopilot clusters (if that matters).
Config Secret is still there and unchanged
❯ k -n gmp-public get secrets
NAME                                         TYPE                                  DATA   AGE
alertmanager                                 Opaque                                1      364d

alertmanager pod is gone
❯ k -n gke-gmp-system get pods
NAME                              READY   STATUS    RESTARTS   AGE
collector-s4wjs                   2/2     Running   0          123m
collector-tdnkl                   2/2     Running   0          9d
collector-vkvhj                   2/2     Running   0          9d
gmp-operator-68988c87ff-7m5q5     1/1     Running   0          9d
rule-evaluator-664c866849-64qks   2/2     Running   0          9d

On another non-autopilot cluster:
❯ k -n gmp-system get pods
NAME                              READY   STATUS    RESTARTS      AGE
alertmanager-0                    2/2     Running   0             9d
collector-bt69f                   2/2     Running   0             9d
collector-fdpdm                   2/2     Running   0             9d
collector-kfhdz                   2/2     Running   0             9d
gmp-operator-6b4cf8fcc4-b6n5t     1/1     Running   0             9d
rule-evaluator-659bf557cf-gmcvt   2/2     Running   2 (20h ago)   9d

I also see that the namespace for gmp pods is not the same on an autopilot vs regular cluster, not sure if that has anything to do with it.

The fact that you're observing this only in GKE Autopilot clusters is likely related to the timing of our release rollouts. We introduced a change in #691 that scales alertmanager to zero when rules are not configured using our Rules, ClusterRules, or GlobalRules resources.
Can you provide a bit more information about how you are using Alertmanager? Do you have any of those Rules configured?

We manage alert rules through Grafana, and so we don't have any of the Rules objects configured in those clusters. I can try to create a Rules object and see if the alertmanager pod comes back

It may also be worth checking if the StatefulSet that manages the alertmanager pods still exists: kubectl get -n gke-gmp-system statefulset/alertmanager

The StatefulSet is indeed still there
❯ kubectl get -n gke-gmp-system statefulset/alertmanager
NAME           READY   AGE
alertmanager   0/0     370d

I just applied the example-rule from the repo and sure enough, alertmanager is back
❯ kubectl get -n gke-gmp-system statefulset/alertmanager
NAME           READY   AGE
alertmanager   1/1     555d

I'll try to craft a rule that doesn't actually alert us just to hang around and make sure the alertmanager doesn't scale to 0, unless you have another option I can try

Something like our example rule should be a good starting point.
That will be the best workaround for now. I'll discuss with the team whether it make sense for us to implement another solution for future releases.


Error: Cannot find module 'typescript'

@antfu sadly v0.5.3 brought this bug back.
 We didn't change much about that part

IDK what changed, very odd, but now even v0.5.2 doesn't work anymore.

@antfu Check this: https://github.com/Revadike/reproduction

Seems to introduced by this line: https://github.com/un-ts/eslint-plugin-import-x/blob/34e1334a907d56150133bf338174a172ce89173d/src/utils/parse.ts#L3
You might want to report to https://github.com/un-ts/eslint-plugin-import-x

Seems to introduced by this line<EMAIL_ADDRESS>You might want to report to un-ts/eslint-plugin-import-x

Hmm, I checked their docs and it seems the difference between the plain js and ts version is the use of @typescript-eslint/parser. Are you using this? Always, or just with ts?

Was bought to here by https://github.com/un-ts/eslint-plugin-import-x/commit/ac11f62ac47b177c18805035dd03fd85262eba08#r146221700
Is it possible that typescript-estree declares typescript as its peer dependency?

Might wanna raise the issue to typescript-eslint instead. It seems that importing withoutProjectParserOptions alone will also run loads of side effects that require typescript.

Importing the module (https://unpkg.com/browse/<EMAIL_ADDRESS>end up importing all the modules in typescript-estree, which end up with the side-effect that importing typescript - maybe they can do a pure submodule like @typescript-eslint/typescript-estree/withoutProjectParserOptions?

:tada:

@Revadike @antfu<EMAIL_ADDRESS>is just released with the workaround included!

A yarn upgrade did not fix it yet.
I think @antfu needs to update @nuxt/eslint first

A yarn upgrade did not fix it yet.

The<EMAIL_ADDRESS>also includes a new feature, so it is a minor change, not a patch change. yarn upgrade might not perform a minor bump.

Can confirm it's working now. Thanks again @SukkaW and @antfu!

I don't know what happened, but the error is back again...
Error: Cannot find module 'typescript'
Require stack:
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /node_modules/eslint-plugin-import-x/lib/utils/parse.js
- /node_modules/eslint-plugin-import-x/lib/utils/export-map.js
- /node_modules/eslint-plugin-import-x/lib/utils/index.js
- /node_modules/eslint-plugin-import-x/lib/rules/consistent-type-specifier-style.js
- /node_modules/eslint-plugin-import-x/lib/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1152:15)
    at Module._load (node:internal/modules/cjs/loader:993:27)
    at c._load (node:electron/js2c/node_init:2:13801)
    at Module.require (node:internal/modules/cjs/loader:1240:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/node_modules/@typescript-eslint/typescript-estree/dist/convert.js:30:25)
    at Module._compile (node:internal/modules/cjs/loader:1373:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1432:10)
    at Module.load (node:internal/modules/cjs/loader:1215:32)
    at Module._load (node:internal/modules/cjs/loader:1031:12)

I did a full clean install, but still getting this error

Please send a reproduction

You are not even upgraded to v0.5.6

You are not even upgraded to v0.5.6

$ npm ls @nuxt/eslint
reproduction
└──<EMAIL_ADDRESS>

Somehow, even installing typescript does not fix it...
Any progress @antfu ?
Are you not able to reproduce it?

@antfu please let me know if I can do anything to help

@antfu

@SukkaW hmm, you're right! I no longer have the issue with the updated version. I get it got resolved on its own. If only everything could be that way.

@antfu it's that time again to reopen this issue... why does it keep coming back?

Error: Cannot find module 'typescript'
Require stack:
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /node_modules/eslint-plugin-import-x/lib/utils/parse.js
- /node_modules/eslint-plugin-import-x/lib/utils/export-map.js
- /node_modules/eslint-plugin-import-x/lib/utils/index.js
- /node_modules/eslint-plugin-import-x/lib/rules/consistent-type-specifier-style.js
- /node_modules/eslint-plugin-import-x/lib/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1152:15)
    at Module._load (node:internal/modules/cjs/loader:993:27)
    at c._load (node:electron/js2c/node_init:2:13801)
    at Module.require (node:internal/modules/cjs/loader:1240:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/node_modules/@typescript-eslint/typescript-estree/dist/convert.js:30:25)
    at Module._compile (node:internal/modules/cjs/loader:1373:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1432:10)
    at Module.load (node:internal/modules/cjs/loader:1215:32)
    at Module._load (node:internal/modules/cjs/loader:1031:12)


SAK-29974: Nested citation lists with drag and drop

This is a new feature for Citation lists where you can create a section with a heading (and a section within that section, up to 3 levels) and drag and drop your citations into those sections, thereby building up a nested citation list (see screenshots in the Jira for examples).
You can drag and drop nested sections containing citations around and add a description to each section.The reading list title and an editable introduction is also displayed at the top of the nested citation list.   The resulting nested list is then shown as such in the student view.
Most of the saving to the db is done via Ajax so that, for example, when you click 'Add Section', an Ajax request calls a method (usually in CitationActionHepler.java) which persists a CitationCollectionOrder representing a 'HEADING1' section.
Looking at the database side of things, the way that we decided to represent nested sections was in CITATION_COLLECTION_ORDER.  We are adding 2 new columns (SECTION_TYPE - which is of type ENUM and can have values 'HEADING1', 'HEADING2', 'HEADING3', 'CITATION' - and VALUE which has the title of the section).  The LOCATION column is used to store the nested structure.
For example, we might have this in the db:
COLLECTION_ID | CITATION_ID | LOCATION | SECTION_TYPE | VALUE
xxx                       |                        |        1          |  'HEADING1'     | 'Economics'
xxx                       |                        |        2          |  'HEADING2'     | 'UK Banks'
xxx                       |                        |        3          |  'HEADING3'     | 'Natwest'
xxx                       |      aaa            |        4          |  'CITATION'      |
xxx                       |       bbb           |        5          |  'CITATION'      |
This would represent an h1 section with an h2 section in that and an h3 section in that and then 2 citations in that h3.

Hi Nicholas,
Sorry this hasn't been reviewed yet!
Would you mind fixing it up as it currently seems out of date?
I will then check it out locally and test it.

Hi Earle,
No worries at all.  Yes I'll resolve the conflicts so it can be merged.
Thanks loads for looking at it,
Nick

Hi Earle,
Sorry for some reason the way my git config is set up, when I updated my branch, it merged loads of master changes into it which I didn't want to do (I wanted to do rebase) so, if it's okay, I've just closed this pull request and opened a new one with the exact same code change that merges cleanly (next time I'll just manually do a rebase):
https://github.com/sakaiproject/sakai/pull/1256
Apologies,
Best,
Nick


Uncaught Error: ENOENT: no such file or directory, stat '~/Documents/Tenrec/Tenrec_Client_Portal/...

[Enter steps to reproduce:]
Not sure of the steps to reproduce the error. My directory path is good. I copied it directly from commandline.
The directory path is being duplicated and passed as a single string.
Atom: 1.14.0 x64
Electron: 1.3.13
OS: Mac OS X 10.12.3
Thrown From: remote-sync package 4.1.5
Stack Trace
Uncaught Error: ENOENT: no such file or directory, stat '/Users/dustin_tenrec/Documents/Tenrec/Tenrec_Client_Portal/Dev/wp-content/Users/dustin_tenrec/Documents/Tenrec/Tenrec_Client_Portal/Dev/wp-content/themes/twentysixteen-child/style.css'
At fs.js:992

Error: ENOENT: no such file or directory, stat '/Users/dustin_tenrec/Documents/Tenrec/Tenrec_Client_Portal/Dev/wp-content/Users/dustin_tenrec/Documents/Tenrec/Tenrec_Client_Portal/Dev/wp-content/themes/twentysixteen-child/style.css'
    at Error (native)
    at fs.statSync (fs.js:992:18)
    at Object.fs.statSync (ELECTRON_ASAR.js:275:16)
    at RemoteSync.isDirectory (/packages/remote-sync/lib/RemoteSync.coffee:200:23)
    at RemoteSync.monitorFile (/packages/remote-sync/lib/RemoteSync.coffee:134:42)
    at /packages/remote-sync/lib/RemoteSync.coffee:225:13

Commands
     -7:56.9.0 remote-sync:configure (span.name.icon.icon-file-directory)
  4x -6:52.7.0 core:backspace (input.hidden-input)
     -5:45.6.0 remote-sync:configure (span.name.icon.icon-file-directory)
     -1:10.3.0 core:paste (input.hidden-input)

Non-Core Packages
color-picker 2.2.4
linter 1.11.21
pigments 0.38.0
remote-sync 4.1.5

Duplicate of issue: #273


For Content Review - GSQ Features Vocabulary

Custodian - @mark-gordon-dnrme
Peer Reviewer 1 - @DavidCrosswellGSQ
Peer Reviewer 2 - @GSQ-AI
David, I have uploaded file to GraphDB test. Can you please reboot to push vocab to vocprez and comment with the link once done?
Andrew this vocabulary is the highest level of geological and administrative features. Discuss as needed for further clarification.

@KellyVance Vocprez test restarted

Mark,
Can you please review for finalisation of this top level of features.

Cheers


ARC configuration

Some configuration and README files for running open-gira jobs on the Advanced Research Computing cluster.

I've fiddled with the CI a bit, best case run time now down from ~10min to ~1min30s.
The CI now installs and activates python environments with micromamba. The python environment is cached -- the cache being invalidated when the environment.yml changes, or for the first run each day. Test running is parallelised with pytest-xdist, to use both CPUs on the GitHub Actions runner.
I have moved fetching/installing the osmium dependencies into the osmium build step. This means that on a cache hit, none of the dependencies are fetched (before they were always fetched). I did wonder if not installing gdal-bin would be a problem, but the tests pass so :shrug:


add type hinting to codebase

Hey, I believe this would be a very nice addition for lowering the learning curve.
What are your thoughts on the level of detail in the type annotations?
def _get_segments_for_ranges(traj: Trajectory, ranges: list) -> list:

or
def _get_segments_for_ranges(traj: Trajectory, ranges: List[SpatioTemporalRange]) -> List[Trajectory]:

Hi @Geometrein
In the example you provide, I prefer the second since the first is imho insufficient to be useful.


Pre & Post lecture quiz Links

Describe the bug
The Link to the Pre and Post lectures won't work after i forked the repo or work on it locally .
To Reproduce
Steps to reproduce the behavior:

Go to 'any chapter'
Click on ' the lesson'
Scroll down to ' the Pre-lecture quiz'
See error

Expected behavior
I expected that a tab will open so i can procced to answer the question.

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. windows 10]
Browser [e.g. chrome ]
Version [e.g. 93]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

hi, thank you for this bug report. Recently, I had to change the link for the quiz app, so the new one is this: https://white-water-09ec41f0f.azurestaticapps.net/quiz/1/
It's been updated in this repo, so you can either:

edit your own repo to replace the other link with this new one
or
refresh your fork to update your version, after which the new links will be in place.

Ok I'll do that. Thank you @jlooper


Placement of language selector on mobile version needs to be properly designed or themed

Selector still needs some tweaking on mobile. Height doesn't match filter bar.

see #120 for screenshot.

Fixed in #143

Hi guys - this is still not fixed on my devices.

@PeaceGeeks you need to wait for me to upload the new changes. I mark the issue as closed while I'm working to merge, then once I'm done for the night I push to the dev site. Please check now.

Ok - year I realized that just before you emailed. Thanks. This is better. It still overlaps with the white bar, but at least I can see both language options in the drop down now.

I will close this for now, and open a low priority theming one for later.


Inconsistent casing

There's a mix of camel casing and snake casing in the project. For example, see here.
    string textColor              = 14;

    uint32 follower_count         = 15;

As indicated in a comment, I don't think this was fixed properly.


Large package size

 #triage-eng-support thread
The @flatfile/api package is quite large when imported into a React project. I am only using a few API calls to fetch records from a sheet but as a result I've added nearly 2MB to my asset bundle.
Is it possible to produce a more minified version of this library?

We absolutely agree. We're working hard to fix this. This version of the API package has the same types with less middleware. https://www.npmjs.com/package/@flatfile/api-preview
It is likely to replace this package in the near future. However we still have an issue where this package casts date values to Dates and the new package does not. That should not affect anything, but please be aware of it.
In order to use this package you'll need to alias @flatfile/api to @flatfile/api-preview in your npm.
https://github.com/npm/rfcs/blob/main/implemented/0001-package-aliases.md#detailed-explanation

Thanks @dboskovic , do you have an example of how to do the install/alias of the preview package? I'm having an issue with peer dependencies, e.g from  @flatfile/listener


Add an "everyEvent" Ansible Job Run Mode to the Policy addon

Signed-off-by: Chunxi Luo<EMAIL_ADDRESS>This PR needs to be polished and combine some duplicated codes section.  Also adding test cases.
I opened it mainly to clarify the purpose of EventTime. After re-reading the design doc and discussion, I don't get the case we use EventTime (check delayAfterRunSecondsStr or something else). Especially for This is detected by looking at the eventTime in the status.clustersWithEvent entry to see if the timestamp is newer than the automationStartTime value. If  comparing automationStartTime + delayAfterRunSeconds with Now isn't enough, I must miss sth, and thanks for clarifying. @JustinKuli  @mprahl

Signed-off-by: Chunxi Luo<EMAIL_ADDRESS>This PR needs to be polished and combine some duplicated codes section. Also adding test cases.
I opened it mainly to clarify the purpose of EventTime. After re-reading the design doc and discussion, I don't get the case we use EventTime (check delayAfterRunSecondsStr or something else). Especially for This is detected by looking at the eventTime in the status.clustersWithEvent entry to see if the timestamp is newer than the automationStartTime value. If comparing automationStartTime + delayAfterRunSeconds with Now isn't enough, I must miss sth, and thanks for clarifying. @JustinKuli @mprahl

@ChunxiAlexLuo eventTime is set whenever the policy goes from compliant to noncompliant and automationStartTime is recording when the AnsibleJob object is created.
At first, these values will be exactly the same or almost the same depending on the implementation. This isn't useful until we have the delayAfterRunSeconds field.
The reason we need eventTime in addition to automationStartTime is because we need to catch the case where the policy is flaky and went from noncompliant to compliant and back to noncompliant while waiting for delayAfterRunSeconds. In this case, we need to trigger the AnsibleJob again. We don't want to trigger an Ansible job a second time if the policy stayed noncompliant after automationStartTime + delayAfterRunSeconds < now.
Does this make sense?

My original understanding is just the opposite here, I thought like the case @JustinKuli described https://github.com/open-cluster-management-io/enhancements/pull/60#discussion_r904034872, it will ignore the change on t=120 and t =500, then wait till t=1200 (no matter what happened during delayAfterRunSeconds). If re-run on t=610 then eventTime is needed.

Signed-off-by: Chunxi Luo<EMAIL_ADDRESS>This PR needs to be polished and combine some duplicated codes section. Also adding test cases.
I opened it mainly to clarify the purpose of EventTime. After re-reading the design doc and discussion, I don't get the case we use EventTime (check delayAfterRunSecondsStr or something else). Especially for This is detected by looking at the eventTime in the status.clustersWithEvent entry to see if the timestamp is newer than the automationStartTime value. If comparing automationStartTime + delayAfterRunSeconds with Now isn't enough, I must miss sth, and thanks for clarifying. @JustinKuli @mprahl

@ChunxiAlexLuo eventTime is set whenever the policy goes from compliant to noncompliant and automationStartTime is recording when the AnsibleJob object is created.
At first, these values will be exactly the same or almost the same depending on the implementation. This isn't useful until we have the delayAfterRunSeconds field.
The reason we need eventTime in addition to automationStartTime is because we need to catch the case where the policy is flaky and went from noncompliant to compliant and back to noncompliant while waiting for delayAfterRunSeconds. In this case, we need to trigger the AnsibleJob again. We don't want to trigger an Ansible job a second time if the policy stayed noncompliant after automationStartTime + delayAfterRunSeconds < now.
Does this make sense?

My original understanding is just the opposite here, I thought like the case @JustinKuli described open-cluster-management-io/enhancements#60 (comment), it will ignore the change on t=120 and t =500, then wait till t=1200 (no matter what happened during delayAfterRunSeconds). If re-run on t=610 then eventTime is needed.

See the last comment in that discussion:
https://github.com/open-cluster-management-io/enhancements/pull/60#discussion_r904090980

flaky

Ok, so we want to track at most one time for the multi-times flaky case, and only able to do this without tracking the whole hisstory.

/retest

/cc @gparvin

/hold
In case others want to check over this again.


Feeds missing recent entries

I got everything up and running, but my feeds don't have any entries on them past June or July. Am I doing something wrong?

Is your repo public so I can have a look?


[bug] Shenzhen Neo Electronics Co., Ltd wall switch EU-2 hang at Nodeinfo state

Version 4.5.0
Checklist:

[ ] I am not using HomeAssistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog problem was not mentioned there.

Build/Run method

[X] Docker
[ ] PKG
[ ] Snap package
[ ] Manually built (git clone - yarn install - yarn run build )

zwavejs2mqtt version: 4.5.0
zwave-js version: 7.7.0
Describe the bug
A clear and concise description of what the bug is.
This issue is happen with ZwaveJS2Mqtt Release 4.0.0 to 4.5.0 and Shenzhen Neo Electronics Co., Ltd wall switch EU-2, zwave device details as below:
"deviceId": "600-4235-3",
"manufacturer": "Shenzhen Neo Electronics Co., Ltd.",
"manufacturerId": 600,
"productType": 3,
"productId": 4235,
The Shenzhen Neo Electronics Co., Ltd wall switch EU-2 cannnot be add as new device or re-interview, as it just always hang at Nodeinfo state.
log:
2021-05-29 09:46:20.380 INFO ZWAVE: Calling api refreshInfo with args: [ 9, [length]: 1 ]
2021-05-29 09:46:20.403 INFO ZWAVE: Node 9: interview started
2021-05-29 09:46:20.407 INFO ZWAVE: Success zwave api call refreshInfo { success: true, message: 'Success zwave api call', result: undefined }
2021-05-29 09:46:20.416 INFO ZWAVE: Node 9: interview stage PROTOCOLINFO completed
2021-05-29 09:46:20.508 INFO ZWAVE: Node 9: interview stage NODEINFO completed
2021-05-29 09:46:20.765 INFO ZWAVE: Node 9: value added: 114-0-manufacturerId => 600
2021-05-29 09:46:20.765 INFO ZWAVE: Node 9: value added: 114-0-productType => 3
2021-05-29 09:46:20.766 INFO ZWAVE: Node 9: value added: 114-0-productId => 4235
2021-05-29 09:46:20.900 INFO ZWAVE: Node 9: value added: 134-0-libraryType => 6
2021-05-29 09:46:20.900 INFO ZWAVE: Node 9: value added: 134-0-protocolVersion => 4.33
2021-05-29 09:46:20.901 INFO ZWAVE: Node 9: value added: 134-0-firmwareVersions => 2.60
2021-05-29 09:46:20.901 INFO ZWAVE: Node 9: value added: 134-0-hardwareVersion => 16
2021-05-29 09:46:31.891 ERROR ZWAVE: Interview of node 9 has failed: Attempt 1/5 failed
2021-05-29 09:46:37.192 INFO ZWAVE: Node 9: value added: 96-0-endpointIndizes => 1,2
2021-05-29 09:46:37.371 INFO ZWAVE: Node 9: value added: 37-1-currentValue => false
2021-05-29 09:46:37.372 INFO ZWAVE: Node 9: value added: 37-1-targetValue => undefined
My temp. solution is roll back to Release 3.5.0 and re-interview or ADD these devices (EU-2).
Once when those device ADD or re-interview complete by Release 3.5.0, this is not problem to update to Release 4.0.0 to 4.5.0 with the same config files.
Other Shenzhen Neo Electronics Co., Ltd wall switch such as EU-1 and EU-3 DO NOT had this issue.
To Reproduce
Steps to reproduce the behavior:

Add new device or re-interview device

Expected behavior
A clear and concise description of what you expected to happen.
Additional context
Add any other context about the problem here.

Missing logs

2021-05-31T08:25:58.144Z SERIAL « [ACK]                                                                   (0x06)
2021-05-31T08:25:58.147Z SERIAL « 0x0104011301e8                                                       (6 bytes)
2021-05-31T08:25:58.148Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:25:58.149Z DRIVER « [RES] [SendData]
was sent: true
2021-05-31T08:25:58.168Z SERIAL « 0x011800131200000200bb7f7f7f7f00000300000000030100005e              (26 bytes)
2021-05-31T08:25:58.168Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:25:58.168Z DRIVER « [REQ] [SendData]
callback id:     18
transmit status: OK
2021-05-31T08:25:58.183Z SERIAL « 0x010f0004000907600d01008e0602bc00a0                                (17 bytes)
2021-05-31T08:25:58.184Z CNTRLR   [Node 009] [~] [Multi Channel Association] groupCount: [Endpoint 1] [internal]
2 => 2
2021-05-31T08:25:58.184Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:25:58.185Z DRIVER « [Node 009] [REQ] [ApplicationCommand]
└─[MultiChannelCCCommandEncapsulation]
│ source:      1
│ destination: 0
└─[MultiChannelAssociationCCSupportedGroupingsReport]
group count: 2
2021-05-31T08:25:58.186Z CNTRLR « [Node 009] supports 2 multi channel association groups            [Endpoint 1]
2021-05-31T08:25:58.186Z CNTRLR   [Node 009] Error during node interview: Node 9 (endpoint 1) does not support t
he Command Class Association!
2021-05-31T08:25:58.186Z CNTRLR » [Node 009] Assigning SUC return route...
2021-05-31T08:25:58.188Z SERIAL » 0x010500510913b1                                                     (7 bytes)
2021-05-31T08:25:58.188Z DRIVER » [Node 009] [REQ] [AssignSUCReturnRoute]
payload: 0x0913
2021-05-31T08:25:58.190Z SERIAL « [ACK]                                                                   (0x06)
2021-05-31T08:25:58.202Z SERIAL « 0x0104015101aa                                                       (6 bytes)
2021-05-31T08:25:58.203Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:25:58.203Z DRIVER « [RES] [AssignSUCReturnRoute]
was executed: true
2021-05-31T08:25:58.507Z SERIAL « 0x010f0004000907600d01008e0602bc00a0                                (17 bytes)
2021-05-31T08:25:58.507Z CNTRLR   [Node 009] [~] [Multi Channel Association] groupCount: [Endpoint 1] [internal]
2 => 2
2021-05-31T08:25:58.508Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:25:58.508Z DRIVER « [Node 009] [REQ] [ApplicationCommand]
└─[MultiChannelCCCommandEncapsulation]
│ source:      1
│ destination: 0
└─[MultiChannelAssociationCCSupportedGroupingsReport]
group count: 2
2021-05-31T08:25:58.528Z SERIAL « 0x010f0004000907600d01008e0602bc00a0                                (17 bytes)
2021-05-31T08:25:58.529Z CNTRLR   [Node 009] [~] [Multi Channel Association] groupCount: [Endpoint 1] [internal]
2 => 2
2021-05-31T08:25:58.529Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:25:58.529Z DRIVER « [Node 009] [REQ] [ApplicationCommand]
└─[MultiChannelCCCommandEncapsulation]
│ source:      1
│ destination: 0
└─[MultiChannelAssociationCCSupportedGroupingsReport]
group count: 2
2021-05-31T08:25:58.621Z SERIAL « 0x010500511300b8                                                     (7 bytes)
2021-05-31T08:25:58.622Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:25:58.622Z DRIVER « [REQ] [AssignSUCReturnRoute]
callback id:     19
transmit status: OK

2021-05-31T08:34:27.294Z DRIVER « [RES] [SendData]
                                was sent: true

2021-05-31T08:34:27.364Z SERIAL « 0x011800132600000700be7f7f7f7f000103000000000203000068              (26 bytes)
2021-05-31T08:34:27.364Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:34:27.365Z DRIVER « [REQ] [SendData]
                                callback id:     38

                                transmit status: OK

2021-05-31T08:34:27.384Z SERIAL « 0x010f0004000907600d0100250300be000e                                (17 bytes)
2021-05-31T08:34:27.385Z CNTRLR   [Node 009] [+] [Binary Switch] currentValue: false                [Endpoint 1]
2021-05-31 16:34:27.385 INFO ZWAVE: Node 9: value added: 37-1-currentValue => false
2021-05-31T08:34:27.385Z CNTRLR   [Node 009] [+] [Binary Switch] targetValue: undefined             [Endpoint 1]
2021-05-31 16:34:27.386 INFO ZWAVE: Node 9: value added: 37-1-targetValue => undefined
2021-05-31T08:34:27.386Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:34:27.386Z DRIVER « [Node 009] [REQ] [ApplicationCommand]
                              └─[MultiChannelCCCommandEncapsulation]

                                │ source:      1

                                │ destination: 0

                                └─[BinarySwitchCCReport]

                                    current value: false

2021-05-31T08:34:27.388Z CNTRLR « [Node 009] received Binary Switch state:                          [Endpoint 1]
                              current value:      false

2021-05-31T08:34:27.388Z CNTRLR   [Node 009] [+] [Binary Switch] interviewComplete: true [Endpoint 1] [internal]
2021-05-31T08:34:27.389Z CNTRLR   [Node 009] Interviewing Z-Wave Plus Info...                       [Endpoint 1]
2021-05-31T08:34:27.389Z CNTRLR » [Node 009] querying Z-Wave+ information...                        [Endpoint 1]
2021-05-31T08:34:27.391Z SERIAL » 0x010d00130906600d00015e012527df                                    (15 bytes)
2021-05-31T08:34:27.391Z DRIVER » [Node 009] [REQ] [SendData]
                              │ transmit options: 0x25

                              │ callback id:      39

                              └─[MultiChannelCCCommandEncapsulation]

                                │ source:      0

                                │ destination: 1

                                └─[ZWavePlusCCGet]

2021-05-31T08:34:27.395Z SERIAL « [ACK]                                                                   (0x06)
2021-05-31T08:34:27.403Z SERIAL « 0x0104011301e8                                                       (6 bytes)
2021-05-31T08:34:27.404Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:34:27.404Z DRIVER « [RES] [SendData]
                                was sent: true

2021-05-31T08:34:27.423Z SERIAL « 0x011800132700000200bb7f7f7f7f00000300000000030100006b              (26 bytes)
2021-05-31T08:34:27.424Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:34:27.424Z DRIVER « [REQ] [SendData]
                                callback id:     39

                                transmit status: OK

2021-05-31T08:34:27.440Z SERIAL « 0x0115000400090d600d01005e020105001d011d01bb0065                    (23 bytes)
2021-05-31T08:34:27.441Z CNTRLR   [Node 009] [+] [Z-Wave Plus Info] zwavePlusVersion: 1  [Endpoint 1] [internal]
2021-05-31T08:34:27.441Z CNTRLR   [Node 009] [+] [Z-Wave Plus Info] nodeType: 0          [Endpoint 1] [internal]
2021-05-31T08:34:27.441Z CNTRLR   [Node 009] [+] [Z-Wave Plus Info] roleType: 5          [Endpoint 1] [internal]
2021-05-31T08:34:27.441Z CNTRLR   [Node 009] [+] [Z-Wave Plus Info] installerIcon: 7425  [Endpoint 1] [internal]
2021-05-31T08:34:27.441Z CNTRLR   [Node 009] [+] [Z-Wave Plus Info] userIcon: 7425       [Endpoint 1] [internal]
2021-05-31T08:34:27.442Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:34:27.442Z DRIVER « [Node 009] [REQ] [ApplicationCommand]
                              └─[MultiChannelCCCommandEncapsulation]

                                │ source:      1

                                │ destination: 0

                                └─[ZWavePlusCCReport]

                                    version:      1

                                    node type:    Node

                                    role type:    AlwaysOnSlave

                                    icon (mgmt.): 0x1d01

                                    icon (user):  0x1d01

2021-05-31T08:34:27.443Z CNTRLR « [Node 009] received response for Z-Wave+ information:             [Endpoint 1]
                              Z-Wave+ version: 1

                              role type:       AlwaysOnSlave

                              node type:       Node

                              installer icon:  0x1d01

                              user icon:       0x1d01

2021-05-31T08:34:27.443Z CNTRLR   [Node 009] [+] [Z-Wave Plus Info] interviewComplete: t [Endpoint 1] [internal]
                              rue

2021-05-31T08:34:27.461Z CNTRLR   [Node 009] Interviewing Multi Channel Association...              [Endpoint 1]
2021-05-31T08:34:27.461Z CNTRLR » [Node 009] querying number of multi channel association groups... [Endpoint 1]
2021-05-31T08:34:27.468Z SERIAL » 0x010d00130906600d00018e05252804                                    (15 bytes)
2021-05-31T08:34:27.469Z DRIVER » [Node 009] [REQ] [SendData]
                              │ transmit options: 0x25

                              │ callback id:      40

                              └─[MultiChannelCCCommandEncapsulation]

                                │ source:      0

                                │ destination: 1

                                └─[MultiChannelAssociationCCSupportedGroupingsGet]

2021-05-31T08:34:27.473Z SERIAL « [ACK]                                                                   (0x06)
2021-05-31T08:34:27.481Z SERIAL « 0x0104011301e8                                                       (6 bytes)
2021-05-31T08:34:27.481Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:34:27.484Z DRIVER « [RES] [SendData]
                                was sent: true

2021-05-31T08:34:27.502Z SERIAL « 0x011800132800000200bc7f7f7f7f000003000000000301000063              (26 bytes)
2021-05-31T08:34:27.502Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:34:27.502Z DRIVER « [REQ] [SendData]
                                callback id:     40

                                transmit status: OK

2021-05-31T08:34:27.517Z SERIAL « 0x010f0004000907600d01008e0602bc00a0                                (17 bytes)
2021-05-31T08:34:27.518Z CNTRLR   [Node 009] [+] [Multi Channel Association] groupCount: [Endpoint 1] [internal]
                               2

2021-05-31T08:34:27.518Z SERIAL » [ACK]                                                                   (0x06)
2021-05-31T08:34:27.519Z DRIVER « [Node 009] [REQ] [ApplicationCommand]
                              └─[MultiChannelCCCommandEncapsulation]

                                │ source:      1

                                │ destination: 0

                                └─[MultiChannelAssociationCCSupportedGroupingsReport]

                                    group count: 2

2021-05-31T08:34:27.519Z CNTRLR « [Node 009] supports 2 multi channel association groups            [Endpoint 1]
2021-05-31T08:34:27.520Z CNTRLR   [Node 009] Error during node interview: Node 9 (endpoint 1) does not support t
                              he Command Class Association!

https://zwave-js.github.io/zwavejs2mqtt/#/troubleshooting/bug_report?id=bug-report

zwavejs_2021-05-31.log
zwavejs2mqtt.log

When update to Release 4.5.1, the issue seems resolved!


Update version-0.5/getting-started.md

Apply changes from 7cc6d0e to all versions. See https://github.com/facebook/react-native-website/pull/582#issuecomment-426726174.

How about adding a short section to Quick Start describing how to start a react native project without expo services?

@nicostuhlfauth - it's there under "Building Projects with Native Code"


How do I make it so that each menu has a different song playing?

Describe your problem here.
Trying to make it so that when someone goes to options or credits, there is a different song playing than the main menu music.
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

nvm I figured it out


Please update the npm package

I will, as soon as I finish docs, wiki.

Ok

Also waiting for more user feedback, perhaps new issues pop.


Fix deleted parent filter

Both the  /taskCluster endpoint and the /tasks/box/:left/:bottom/:right/:top endpoint should return the same tasks (the format of the data should be different, but the tasks themselves should be the same and the amount of tasks should be the same).
Issue: The two endpoints, when passed the same filtering parameters, would pass back different results.
Solution: Fixed the filtering conditions of these two endpoints:
PUT     /taskCluster
PUT     /tasks/box/:left/:bottom/:right/:top
More details on the solution:

Remove a manually added filter on enabled challenges from the taskCluster endpoint and use the built in search parameter instead.
Fix the deleted challenges and projects filters to filter for challenges and projects that have a "false" deleted status.
Remove manually added filter on deleted projects and challenges.

related: https://github.com/maproulette/maproulette3/issues/2211
/taskCluster endpoint WHERE statement in sql query with the manually added "deleted" related filters:
WHERE (tasks.location && ST_MakeEnvelope (-111.91609382363669, 40.714313359738256, -111.86871528359762, 40.748394608673685, 4326)) AND
(tasks.status IN (0,3,6)) AND ((c.status IN (3,4,0,-1) OR c.status IS NULL)) AND
(NOT c.requires_local) AND (c.enabled) AND (c.is_archived = false) AND
c.deleted = false AND p.deleted = false`

/tasks/box endpoint WHERE statement in sql query where filters on deleted project and challenges should be present:
WHERE (p.enabled) AND (tasks.location && ST_MakeEnvelope (-111.91609382363669, 40.714313359738256, -111.86871528359762, 40.748394608673685, 4326)) AND
(tasks.status IN (0,3,6)) AND ((c.status IN (3,4,0,-1) OR c.status IS NULL)) AND
(NOT c.requires_local) AND (c.enabled) AND (c.is_archived = false)
ORDER BY RANDOM() DESC LIMIT 1001 OFFSET 0;

/taskCluster endpoint WHERE statement in sql query after change:
WHERE (c.deleted = false AND p.deleted = false) AND (tasks.location && ST_MakeEnvelope (-111.90092327097236, 40.72337196386074, -111.87723400095282, 40.740412450956256, 4326)) AND
(tasks.status IN (0,3,6)) AND ((c.status IN (3,4,0,-1) OR c.status IS NULL)) AND
(NOT c.requires_local) AND (c.enabled) AND (c.is_archived = false)

/tasks/box endpoint WHERE statement in sql query after change:
WHERE (c.deleted = false AND p.deleted = false) AND (tasks.location && ST_MakeEnvelope (-111.90092327097236, 40.72337196386074, -111.87723400095282, 40.740412450956256, 4326)) AND
(tasks.status IN (0,3,6)) AND ((c.status IN (3,4,0,-1) OR c.status IS NULL)) AND
(NOT c.requires_local) AND (c.enabled) AND (c.is_archived = false)
ORDER BY RANDOM() DESC LIMIT 1001 OFFSET 0;

The reason why p.enabled is missing from the new  PUT     /tasks/box/:left/:bottom/:right/:top endpoint is because i removed the manually added condition that added it to that specific endpoint. The filter that is supposed to be used is blocked by a condition:
if (projectSearch) {
  filterList = this.filterProjects(params) :: this.filterProjectEnabled(params) :: filterList
}

projectSearch value is determined by this function:
  /**
    * Filters by p.display_name with a like %projectSearch%
    * @param params with inverting on 'ps'
    */
  def filterProjectSearch(params: SearchParameters): FilterGroup = {
    FilterGroup(
      List(
        FilterParameter.conditional(
          Project.FIELD_DISPLAY_NAME,
          s"'${SQLUtils.search(params.projectSearch.getOrElse(""))}'",
          Operator.ILIKE,
          params.invertFields.getOrElse(List()).contains("ps"),
          true,
          params.projectSearch != None,
          Some("p")
        )
      )
    )
  }

At the moment this change is necessary for the endpoints outputs to match, but further investigation of why that condition is needed.

Removing if (params.projectEnabled.getOrElse(false)) block might result in some edge case, but it's fine to merge


unable to resolve .cache/nativewind/output.js when creating expo template

Describe the bug
I am trying to create a template to be used with expo like this:
yarn create expo-app AppName -t expo-template-blank-typescript-nativewind, but when trying to run the project I get:
Unable to resolve "/Users/ramiel/Desktop/Typescript/expo/AppName/node_modules/.cache/nativewind/output.js" from "node_modules/nativewind/dist/index.js"

however removing and adding it again with yarn remove nativewind && yarn add nativewind@next makes it work
To Reproduce

Go to terminal
Enter ''yarn create expo-app AppName -t expo-template-blank-typescript-nativewind"
Enter "cd AppName && yarn expo start"
See error

Expected behavior
Not really sure why the error happens. I am expecting it to work right away.

I'm not sure who maintains the project, but when I run that commands you listed it doesn't properly lock the pre-release version in the package.json (it shouldn't use ^ for a pre-release). This can lead to confusing behaviour and I suspect the cause of your issue.


Video does not stop when playing in last tab and tab gets closed

If I play a video in the very last tab of Vienna, and close that tab with CMD+W or the little X at the tab, the video does not stop (audio keeps playing). However, when opening a new tab afterwards, the video stops.
It seems like, while plugins are stopped for tabs that get closed, they are not get stopped for the last open tab.
Another, maybe related bug, is that the title of the last tab in the tab bar overflow list is not shown. Instead, it keeps displaying the hostname of the website URL.

I have looked into this issue and found the following:
dealloc is called on BrowserPane when every tab but the last open tab is closed. It is not called on the last open tab until a new tab is created after the last tab has been closed. This is why video continues playing after the last open tab is closed and doesn't stop until a new tab is opened.
dealloc calls handleStopLoading, which includes stopping video on the page.

Thank you very much, @ahyattdev ! I appreciate every hint that I can get, that saves me debugging time. Probably that missing deallocation was a mistake on my side with the integration of MMTabBar into Vienna. I opened the issue to document it and to be able to come back and fix it later. Later is now, since I have holidays now and thus time to help on Vienna again! I hope to be able to fix it in the next few days.

@TAKeanice awesome! I lack the familiarity with the project to fix it so I left what I had noticed from debugging.

https://github.com/ViennaRSS/MMTabBarView/pull/5 should resolve it.


TypeScript Definition File

This project is really impressive - I especially love the generated documentation!
I noticed ngl 2.x.x is using TypeScript - Is there a plan to provide a type definition file for other developers wishing to integrate ngl into their application? Either directly as part of the repo, or as part of the @types repository?
I'm currently writing some up now for work as part of HCA, but would be thrilled to submit a PR if it'd be beneficial!

Is it really necessary to create an extra type definition file since most of NGL is now in TS?

When working within the NGL repo, it is perfectly fine as is!
However, when pulling in the repo as a dependency, all of the type information is unavailable.
The 2 routes I spent some time on last month were:

Generating them via the --declaration tsc flag.
Creating handwritten type definitions based on the existing documentation.

For route 1, I was unable to get any .d.ts files generated due to the existing .js files - perhaps there's a setting I'm not aware of that could remedy that.
For route 2, my current WIP can be found here: https://github.com/cBioCenter/chell-viz/tree/master/types/ngl
I absolutely would love to help the effort, whether it be by making a PR with finalized/formal type definitions, or doing some more .js -> .ts conversion!

As a VS code user, I really appreciate the possibility offered by type declarations in the libraries I use. Given the extent of NGL library, I have no doubt this would be very useful to me!

I have just tried the route 1 (which seems more maintainable): tsc -d to auto-generate the type declaration file.
hundreds of errors have been reported, mostly related to types being private because there declarations are not been exported.
@MercifulCode have you encountered the same problem and fixed it already?

@ppillot I believe I encountered that, yes - following the trail of needing to export various types led to needing to convert more .js files to .ts, or at least do a bit of refactoring.
However, that was about a month ago, which is a few versions behind master - I plan to make some time this week to take another swing at using the auto-generation compilation flag!

@MercifulCode then we should aim at finishing the JS -> TS conversion. @arose, I'd be glad to help.

+1. We're also interested in having type files to integrate ngl in our codebase; can we (Cyrus Biotechnology) somehow aid in the transition from JS to TS?

I've just finished converting the source code to typescript (except for the polyfills) #524 .
I've tried again the tsc -d command and it reports hundreds of errors, mainly due to type declaration private to modules (no export).
One last stretch and it may be working!

awesome!

I've completed the aforementioned PR #524  with various adjustments related to TS declarations.
Some seem to me as quirks (see comment on the PR) but I could not figure a better way.
In the end, I've realized that tsc -d produces a declaration file for each module, i.e. tens of declaration files. I used the command tsc -d --outFile "ngl.js" --module "system" to generate a single js file and its accompanying single declaration file.
I manually copied this file in the ngl folder in node_modules in my application folder, opened VS code and got this intellisense of magic:

When I open the declaration file in my editor, hundreds of errors are reported as relative path had been made to external dependencies (for example Vector3 objects coming from three).
So, it apparently works really well (I didn't expect to have the JSDoc comments appearing, but it's great to have them). It still needs some testing, especially to get a proper a build workflow, and make sure that the d.ts file produced provides all the relevant informations.

So what is needed to make such a d.ts file part of the distribution? I read that there is no direct support in tsc -d to include external type defs but there see to be tools out there to do that. Does anyone have experience with this?

For the first part of your questions, technically the npm package should ship with 1 or many d.ts files.
If we manage to have only 1 proper d.ts file for ngl, then this ngl.d.ts file could sit in the dist folder with the 2 library files present there. a reference to this file in package.json under the property types is better, but not mandatory in that case for finding the declaration.
If we have many d.ts files, then they would preferably be in a separate folder, for example types and the package.json property should be set accordingly.
Regarding external dependencies such as three, chroma, signals and node, I've read that it is recommended to add their types as dependencies to package.json and not dev-dependencies so that the end user get these typings when she downloads the package.

Bumping this. Using ngl (installed via npm) in our project and not having types definitely hurts the development experience.

Hi there is any update in that regard? I've found that in the node_modules/dist there is a folder full of the typescript, can we use those definitions? Do you know a way to use it?

Hi there is any update in that regard? I've found that in the node_modules/dist there is a folder full of the typescript, can we use those definitions? Do you know a way to use it?

Yes, types have been fully integrated into the distribution for a couple of years.
I use VS-code and the type imports are suggested as I type (similarly to the screenshot above). There is nothing specific to do for me to make it work. Note that I use esm imports, so this might be a difference from your system if, for example, you are using the minimified version if the library. In that case, you may have to specify the type imports manually.

Thank you @papillot,
but the problem is that I can't replicate your compilation but I can't replicate it I did installed tsc with sudo apt install node-typescript and I run this command from my project folder: tsc node_modules/ngl/dist/declarations/*.ts -d --outFile ngl.d.ts --module 'system'
But I'm getting 100 error aprox.
I did tried with your command tsc node_modules/ngl/dist/declarations/* -d --outFile "ngl.js" --module "system" but i get the same error. I've even tryied with npm "ngl:type": "vue-tsc node_modules/ngl/dist/declarations/*.ts -d --outFile ngl.d.ts --module 'system'",
but i'm getting errors like this:
node_modules/ngl/dist/structure/structure-view.d.ts:90:5 - error TS2416: Property 'getAtomSet' in type 'StructureView' is not assignable to the same property in base type 'Structure'.
Type '(selection?: boolean | BitArray | Selection, ignoreView?: boolean) => BitArray' is not assignable to type '(selection?: boolean | BitArray | Selection) => BitArray'.
Types of parameters 'selection' and 'selection' are incompatible.
Type 'boolean | import("/home/marcbpu/dev/pharmscreen-saas/gui/node_modules/ngl/dist/declarations/utils/bitarray").default | import("/home/marcbpu/dev/pharmscreen-saas/gui/node_modules/ngl/dist/declarations/selection/selection").default' is not assignable to type 'boolean | import("/home/marcbpu/dev/pharmscreen-saas/gui/node_modules/ngl/dist/utils/bitarray").default | import("/home/marcbpu/dev/pharmscreen-saas/gui/node_modules/ngl/dist/selection/selection").default'.
Type 'BitArray' is not assignable to type 'boolean | BitArray | Selection'.
Type 'import("/home/marcbpu/dev/pharmscreen-saas/gui/node_modules/ngl/dist/declarations/utils/bitarray").default' is not assignable to type 'import("/home/marcbpu/dev/pharmscreen-saas/gui/node_modules/ngl/dist/utils/bitarray").default'.
90     getAtomSet(selection?: boolean | Selection | BitArray, ignoreView?: boolean): BitArray;
~~~~~~~~~~

It seems you are trying to compile the declarations from the NGL project, but they are already available when you download NGL from npm.
I mean that if you are using NGL in your project by doing npm install ngl, the declarations are downloaded along with the code and should be available to your editor for type checking.
If you don't use npm, you can access the declarations from the dist/ directory https://github.com/nglviewer/ngl/tree/master/dist/declarations