BUG: Indexing broken for sparse arrays

On latest scientific-python-nightly-wheels (on Linux at least):
>>> import scipy.sparse
>>> x = scipy.sparse.eye_array(10, format='csr')[:, [1, 2]]
>>> assert x.shape == (10, 2), x.shape
AssertionError: (2, 10)

I assume this is from https://github.com/scipy/scipy/pull/20120 @dschult @stefanv @perimosocordiae @j-bowhay.
I assume this will break code for a lot of folks so if the fix might is not trivial, perhaps it's worth a revert for now?

Yes just the latest nightly wheel! Sorry should have been clearer, apologies if I scared you a bit @tylerjereddy :slightly_smiling_face:

Not sure it's worth a whole revert; we just need to fix that indexing error.

(But fine to roll back, we can always re-apply.)

Thank you @larsoner for reporting this -- and for everyone doing nightly builds for constructing a system that gives quick feedback.
I've got a fix for this indexing issue (which involves mimicing numpy indexing's special case fancy indexing using both slices and arrays) in #21022. The problem is a mis-formed shape of the output. The fix involves adding a case for handling a single array-index when combined with basic indexing.  This is tested in the test_base.py test module, but only for spmatrix. A change to that test module to fully and directly test sparray is developing in #20894 and #20895.


Private AKS cluster with ACR intgration

In you doc for limitation of your integrating ACR with AKS, below is mentioned:
For customers that need to enable Azure Container Registry to work with private AKS, the Container Registry virtual network must be peered with the agent cluster virtual network.
How this is related? ACR doesnt have virtual net work by nature, can you explain what this sentence means?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0b68f2c4-bb6c-11a2-6c61-8af4057a2438
Version Independent ID: e3498bed-1447-6841-8353-9f1b5d3dc8df
Content: Create a private Azure Kubernetes Service cluster - Azure Kubernetes Service
Content Source: articles/aks/private-clusters.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@JuneZhao Thanks for your Question.
If we enable firewall for ACR, then it can be added to a vnet (allow connections from that vnet only). As this document explains about private cluster, this limitation ins mentioned here.
However, I am assigning the issue to content author for enhancing this with more details to clarify the statement.

You may want to check: private link for ACR.
I'm going ahead closing this one. Feel free to keep commenting.
#please-close


Re-enable GAX-based API default

After 0.16.0 release.

Needs a released fix for https://github.com/grpc/grpc/issues/7121

Via #2085.


Feature request: UI

After clicking + field it would be nice if (in the next dialog) the enter name text box would get focus so you can start typing right away.

This is already implemented and will be available soon.
It will become available with #133 and I'll message you when it has been released on master.


port vehicle_launch

Description
porting vehicle_launch to ros2
Change xacro command:
<param name="robot_description" command="$(find xacro)/xacro --inorder $(arg model)  to
<param name="robot_description" value="$(command 'xacro $(var model)
(--inorder option is default in ros2)
How to run
After https://github.com/tier4/lexus_description.iv.universe/pull/4 is merged,
ros2 launch vehicle_launch vehicle.launch.xml sensor_model:=aip_xx1 vehicle_model:=lexus simulation:=true

Note Cannot run with simulation:=false since pacmod3 is not released for foxy.

ready for review

@TakaHoribe I hope it's ok, I rebased your PR on top of ros2 to pick up the latest changes in the CI.


feat(marketplace-benchmark-refactor)

incorporated some ideas, the rest of this changes are hard to rebase on origin/develop, so closing this and leaving it tagged as a reference.


improve post-condition messaging within allow mode

Problem
The current implementation of post-condition messaging does not adequately warn users when a node is set to allow mode. Consequently, a new type of malicious hack has emerged that exploits the way post-conditions are displayed.
Current Issue
Malicious contracts are exploiting the way post-conditions are displayed in the wallet. These contracts may set post-conditions from the user interface (UI) side, making users believe their tokens are safe to transfer. However, since the malicious actors set the post-condition mode to allow, the transaction will succeed, enabling multiple unauthorized transfers, which are hidden within the contract code.
Assumption of deny mode
The intended behavior assumes that when specific post-conditions are set, the Stacks node is in deny mode. Wallets understand this logic and present messages accordingly.
Unaccounted risks in allow mode
Wallets currently do not provide special messaging for allow mode when some post-conditions are passed in. As a result, users may be misled into thinking the transaction is safe, without realizing that other unauthorized asset transfers may occur.
Potential Solutions
Enhanced Detection of Unaccounted Transfers: The wallet could potentially detect unlisted transfer transactions within the contract call.
"This transaction has some conditions listed, but the contract you're interacting with may transfer additional assets that aren't shown here. The node you're using allows these hidden transfers, which can be dangerous."

These improvements will help enhance user security and trust by providing clear visibility into the transaction modes and potential risks associated with allow mode.

To maybe add to this more simply, we should really only present the post-condition screen/messaging when post-conditions have been passed in if the tx is set to deny mode.

@ryanwaits here is the message that is displayed when you try to sign transaction constructed in allow mode:

this looks like the expected behavior, however i was unable to reproduce that message when passing in some post-conditions shortly after i created the issue - perhaps i made a mistake

@LNow appreciate you calling this out and confirming
closing this issue, false alarm

This needs to be reopened imo.
Wallets natively support the sip-010 token transfer standard.
Which is where the attack vector stems from and lives.
Users can call the malformed transfer function natively by your wallets directly eg not from a custom ux/ui.
Here is a screenshot of a leather wallet walked it through like a user, the call directly and was not presented with any warning.

Thanks for raising these concerns @ryanwaits and @cryptocracy, and @LNow for helping to clarify the current UX.
@cryptocracy per your comment, it seems that the attack vector you reference (reported here) depends on a custom malicious function (e.g. claim-rewards) that gets invoked by a 3rd party app with "allow" mode.
This function is separate from the transfer function in the SIP-010 standard, which is implemented and invoked by the wallet for its native transfer / "Send" flow functionality with "deny" mode and post conditions to prevent adverse asset transfers. See here and here in the code.


added support for methods without arguments

Hi kklimuk,
I hope you like this.
This adds support for methods that have no arguments.
Kind regards,
TvL2386

Hey @kklimuk -- I'm noticing that for some reason with the Rails <IP_ADDRESS> upgrade, I'm getting this similar error with the number of arguments. I'm not sure what it's related to, but could you have a look and see if you are getting similar issues?
 ArgumentError:
        wrong number of arguments (given 2, expected 1)
      # ./app/services/time_series_utility.rb:82:in `get_date_interval_format'
      # /Users/karannumero/.rvm/gems/ruby-2.6.6/gems/ruby_memoized-0.1.3/lib/ruby_memoized/memoizer.rb:12:in `call'
      # /Users/karannumero/.rvm/gems/ruby-2.6.6/gems/ruby_memoized-0.1.3/lib/ruby_memoized.rb:37:in `block in method_added'
      # ./app/services/accounts/contributions/time_series_reporter.rb:19:in `initialize'
      # ./spec/services/accounts/contributions/time_series_reporter_spec.rb:8:in `new'
      # ./spec/services/accounts/contributions/time_series_reporter_spec.rb:8:in `block (2 levels) in <top (required)>'
      # ./spec/services/accounts/contributions/time_series_reporter_spec.rb:1042:in `block (5 levels) in <top (required)>'

Hey @krnjn -- Would be great if you could show some code to reproduce the issue. And what rails version does work with that code?

This is on Rails 6.0.3 and here's the code where this is now failing when I upgrade to Rails <IP_ADDRESS>:
class TestClass
  include RubyMemoized

  memoized

  def get_date_interval_format(date_interval)
    case date_interval
    when 'hour'
      '%l %p'
    when 'day'
      '%a'
    when 'day_of_month'
      '%b %-d'
    when 'month'
      '%B'
    end
  end

Hi krnjn -- it fails on 6.0.3 as well on my laptop, although it should work right? :)
$ bundle exec rails console
Running via Spring preloader in process 6440
Loading development environment (Rails 6.0.3)
irb(main):001:0> TestClass.new.get_date_interval_format('hour')
Traceback (most recent call last):
        2: from (irb):1
        1: from app/models/test_class.rb:6:in `get_date_interval_format'
ArgumentError (wrong number of arguments (given 2, expected 1))
irb(main):002:0>

I don't think it has anything to do with rails. Outside of rails it fails as well:
#!/bin/env ruby

require 'ruby_memoized'

class TestClass
  include RubyMemoized

  memoized

  def get_date_interval_format(date_interval)
    case date_interval
    when 'hour'
      '%l %p'
    when 'day'
      '%a'
    when 'day_of_month'
      '%b %-d'
    when 'month'
      '%B'
    end
  end
end

puts RUBY_VERSION
puts RubyMemoized::VERSION

TestClass.new.get_date_interval_format('hour')

Output:
$ app/models/test_class.rb
2.6.6
0.1.3
Traceback (most recent call last):
        3: from app/models/test_class.rb:32:in `<main>'
        2: from /home/tom/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ruby_memoized-0.1.3/lib/ruby_memoized.rb:37:in `block in method_added'
        1: from /home/tom/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/gems/ruby_memoized-0.1.3/lib/ruby_memoized/memoizer.rb:12:in `call'
app/models/test_class.rb:15:in `get_date_interval_format': wrong number of arguments (given 2, expected 1) (ArgumentError)

Hm @TvL2386 -- does this work for you locally if you revert the changes made here: https://github.com/kklimuk/ruby_memoized/pull/2?

If I go back to v0.1.2 it works, but on v0.1.3 it does not. Not at all with a single argument. I don't even have methods I want to memoize with arguments, which is why I came here in the first place and it seems to just be broken. At least for my ruby 2.6.6. Looking into it...

Yeah related to ruby version. 2.6.6 does not work, 2.7.1 works

I think it's because this line in memoizer.rb:
cache[[args, kwargs, block]] = context.send(method, *args, **kwargs, &block)

calls the original version with the first argument and an empty has for kwargs.
So it is given 2 arguments

@krnjn -- could you try this in your rails Gemfile:
git 'https://github.com/TvL2386/ruby_memoized', branch: 'kwargs_fix_for_ruby26' do
  gem 'ruby_memoized'
end

Not really sure whether the fix is awesome or aweful, but it works and demonstrates where the problem lies

Sorry for the spam here. It seems I've been a bit too naive.
@kklimuk has a nice testsuite and the suite seems to run fine with ruby 2.6.6 and 2.7.1.
However, in reality there are errors.

@TvL2386 I had to downgrade my ruby version anyways so will keep this locked as 0.1.2 until we upgrade, at which point I’ll just go to the next release.

hey folks! saw this PR and the associated issue.
i'm gonna take a bigger look later in the week and see if we can have a solution that works with both versions of ruby.

@kklimuk can you take a look at this?

hey folks! saw this PR and the associated issue.
i'm gonna take a bigger look later in the week and see if we can have a solution that works with both versions of ruby.
thanks for the report and the PR =)

Hi @kklimuk, do you think you can take a look at this one? Thanks 💯


Compilation error with .NET 4.0

When using AngleSharp (via NuGet) in a .NET 4.0 project, I get the error:

The primary reference "AngleSharp, Version=<IP_ADDRESS>764, Culture=neutral, PublicKeyToken=e83494dcdc6d31ea, processorArchitecture=MSIL" could not be resolved because it has an indirect dependency on the framework assembly "System.Threading.Tasks, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" which could not be resolved in the currently targeted framework. ".NETFramework,Version=v4.0". To resolve this problem, either remove the reference "AngleSharp, Version=<IP_ADDRESS>764, Culture=neutral, PublicKeyToken=e83494dcdc6d31ea, processorArchitecture=MSIL" or retarget your application to a framework version which contains "System.Threading.Tasks, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a".

My understanding is that the .NET 4.0 package of AngleSharp actually has implicit references to functionality that is available only in higher versions of the .NET Framework.
My question:
Any chance to get AngleSharp working with pure .NET 4.0 only?

Seems like a problem with NuGet. The NuGet package contains a version specifically targeting .NET 4 (here the Bcl.Async package is used to resolve the dependencies for the async-state-machinery).

Thanks.
Any chance for me to manually resolve this?
Frohe Ostern aus Stuttgart :smile:

Could you have a look what path has been resolved (just to confirm the problem)? Instead of pointing to .../net40/AngleSharp.dll I suspect it points to .../net45/AngleSharp.dll or ../portable-windows8+net45+windowsphone8+wpa/AngleSharp.dll.
The simplest thing would be to change that path manually, however, I don't know if NuGet will realize and revoke that change. If so you could remove it from the packages.config for the project.
However, in general I would like to improve the situation (the targets are pretty clear, so I am not sure if the problem is really on my side, or if its just a flaw in NuGet). So if anyone has a clue why NuGet fails to resolve the right target I would welcome any PRs or suggestions. This may be related to #85.
Frohe Ostern aus München :rabbit:

Now this is strange:
I've uninstalled everything to the initial state (i.e. before adding AngleSharp and the BCL packages).
Then I've restarted VS.NET 2015 and added the three BCL libraries first, then a suggested update to the BCL library.
After this update, it says:

Failed to uninstall 'Microsoft.Bcl.Build.1.0.14'. Restart Visual Studio to finish this process.

I did as suggested, after a restart I installed AngleSharp.
Now there are no more compilation errors.
Probably my error was that I initially ignored the "...Restart Visual Studio..." suggestion.
tl;dr Everything works fine now on .NET 4.0
Thanks for your fast public holiday help and sorry for reporting something that was my own fault!

Alright - no problem. Thanks for investigating!

As a side-note, this seems to be related to this issue.


better response type handling

If an api has multiple response content types (success & errors) the java response type of the controller method will be Object to allow return values with different java types.
If the errors are handled by throwing an exception there is no need to have an Object response and the controller method could use the type of the success response to improve readability of the interface.
mapping could be like this, using a globally applied option:
# mapping.yaml
openapi-processor-mapping: v2

options:
  response-type: all    # all (default) or success

or like this, allowing endpoint & endpoint/method configuration:
# mapping.yaml
openapi-processor-mapping: v2

map:
  response-type: all    # all (default) or success

all: consider all response types to select the method return type
success: consider only the success response type, i.e. usually 200

In the Spring module this is also annoying since even if you put
map:
  result: org.springframework.http.ResponseEntity

it will generate ResponseEntity<?> and not ResponseEntity<SuccessResponse>.
Could you give me some hints on how you would implement it? I'm willing to write a fix for this.
Reference: https://docs.openapiprocessor.io/spring/2021.3/mapping/result.html

Yes, I think that has the same cause.
Thanks for the offer to help -)
Here are a few notes to get you started.
I did a few lines on this to get the new option but that's just a minimal start that does not yet do anything. It is on this branch: https://github.com/openapi-processor/openapi-processor-core/tree/response-type-handling
Current idea is to replace the return type of the controller method in the MethodWriter here:
https://github.com/openapi-processor/openapi-processor-core/blob/e25f7ab3c450143edc5b4abec21a9da1e0fbefe7/src/main/kotlin/io/openapiprocessor/core/writer/java/MethodWriter.kt#L47
This is the line that adds the response type to the method.  Replacing ${endpointResponse.responseType}  with a method that does select the return type based on the new option should solve the issue. If the new option is all use the current behaviour if it is success use the success response type and ignore the error responses.
The code to get the wanted type exists and is currently private in the EndpointResponse:
https://github.com/openapi-processor/openapi-processor-core/blob/e25f7ab3c450143edc5b4abec21a9da1e0fbefe7/src/main/kotlin/io/openapiprocessor/core/model/EndpointResponse.kt#L37
Note that the identical selection is required to create the import list.
Getting that option is probably the harder part. Converting the mapping.yaml to the internal format requires a couple of steps and is more complex than I like.
If the options is configured like this
# mapping.yaml
openapi-processor-mapping: v2

map:
  response-type: all    # all (default) or success

the MethodWriter will need the MappingFinder to get access to it and then call a similiar function to https://github.com/openapi-processor/openapi-processor-core/blob/e25f7ab3c450143edc5b4abec21a9da1e0fbefe7/src/main/kotlin/io/openapiprocessor/core/converter/mapping/MappingFinder.kt#L122 to get the value of new mapping option.
The maps: part of the mapping.yaml is converted internally to Mappings. The MappingFinder uses them to find & select mappings.
The new option will need a new implementation of the Mapping interface:  https://github.com/openapi-processor/openapi-processor-core/blob/response-type-handling/src/main/kotlin/io/openapiprocessor/core/converter/mapping/Mapping.kt
Converting  the yaml to the Mapping happens here:
https://github.com/openapi-processor/openapi-processor-core/blob/response-type-handling/src/main/kotlin/io/openapiprocessor/core/processor/mapping/v2/MappingConverter.kt
I hope this helps and i didn't miss any annoying detail that breaks this approach :)

collecting the import happens here https://github.com/openapi-processor/openapi-processor-core/blob/e25f7ab3c450143edc5b4abec21a9da1e0fbefe7/src/main/kotlin/io/openapiprocessor/core/writer/java/InterfaceWriter.kt#L65

@JonasGroeger Hi, I have it nearly running....  I hope you didn't wast to much on on it.

@JonasGroeger Hi, I have it nearly running.... I hope you didn't waste to much on on it.

Please don't feel obligated to implement something just because somebody wants it. It's open source after all.

It something I like to see myself :-) A colleague mentioned it and then your comment on the issue.  Funny is, that it all happend in  a couple of days. ;-)


Update deps, and correct a bug preventing build

This only works for erlang 18 though, right?

We should keep support for at least 17. So I guess we need a rebar.config.script that checks the version and adds a dep of merl in the case it is <18.

That's fair.  I'll see if I can get that poked into place tonight.

I just took care of it. Let me know if it works as you'd expect.

Yup, looks like that does it.  Thanks much!


Support files other than PDFs

The tool only handles PDFs right now, but AWS Textract can handle other formats (including regular images).

I've not tried it yet, but I have a hunch that this will work against various other image files right now with no changes - it's just the --all option that's limited to PDFs, the option where you list files explicitly by name should work already.


Remove y-axis overlaps on AnnotationTrack

For better display, the annotation track could be turned into a beeswarm plot, x positions would always be faithful to the data, and y position would be modified according to the available space.
Here is a nice example of how it could look : https://observablehq.com/@d3/beeswarm
Whe can keep square marks instead of the circles from the example

Implemented in commit dfd94009

Mentioned in commit e73e1605


Fix documentation of additionalProperties field when used with array parameters

This currently produces invalid Swagger:
params do
  optional :array_param, type: Array, documentation: { additional_properties: true } do
    requires :nested_param
  end
end

I took the liberty of renaming additionalProperties to additional_properties (and deprecating the former) to have consistent casing.

@LeFnord While working on adding documentation for this, I realized this will need more changes: OAS 2.0 does not support additionalProperties: true. Is there a helper in the specs to ensure the generated JSON is valid OAS 2.0? I couldn't find one.


Draft environment

Can this be made to work in the draft environment? I would love to be able to pull e.g. the drawing number from the file name. Dynamic revision field in the header would be amazing, too!

I have not used the drawing environment extensible, but I assume you mean values in this block?

Unfortunately, it seems that scripts cannot access the drawing environment. E.g. https://forums.autodesk.com/t5/fusion-360-ideastation-archived/create-an-api-for-drawings/idi-p/7284229 .
It might be possible to do using the Command window in Fusion (can be called from scripts), but it is not very well documented. I might take a second look.

I took a quick look at the Fusion commands, but there was nothing apparent. It might be there, but it takes a lot of time figuring out the commands.
I'm leaving this issue as is for the future. Hopefully they will provide an API for the drawing environment as well.


Timestamps are not accurate enough

Currently all timestamps are only accurate to the second. This may not be enough for the shell tracer since many commands finishes in less than 1 second and it may be confusing when sorting.
We need to improve the accuracy to at least milliseconds.

Recording your idea from our earlier discussion, we could add a timestamp into the event's outputs that records a higher-fidelity timestamp as a stop-gap measuire.

#225 fixed the timestamp for the tracers. Other events may still get less accurate timestamps, but currently accurate timestamps are not essential for other type of events.


Use a Lua C module for time related functions

This removes the dependency on luasocket by adding a C function for gettime, instead of using socket.gettime. Basically, extracting the time related functions from luasocket and using them to create a Lua C module for busted.
This should resolve #472.

bad idea... introducing c code into busted.
If using this, then it should be an external module. And then, it would probably be better to think what other very common elements are missing in the lua eco-system and build one lib for that. (eg. randomization, time, copy files iirc)

I agree, we should definitely pull this out into a separate module. We also need to verify that it works on arm, and x86 32 + 64bit with optimally mips included also.

Sounds good to me.  What would you want to call it and where would you put it?  The code was basically copied from luasocket, so it should work everywhere luasocket works.

cool, we can drop it in the OL repo if you'd like, or keep it on your local if you want to. It just needs to be available on luarocks.

You should probably have push access anyways

Dropping it into the OL repo sounds good to me.  It's a really small module, so it shouldn't need much maintenance.

I created a repo for the gettime function https://github.com/o-lim/luasystem.  It just provides gettime and sleep functions as a Lua C module.  I didn't know what to call it so I just named it luasystem.  If you don't like the name I can rename it to something else.  And if you guys are okay with everything in it, I can make an initial release and push it to luarocks, then update this PR to use it.

Very nice! It looks great and is exactly what we need.

Closing this PR and replacing with #488, which uses luasystem to replace luasocket.

Hmm. I actually would have preferred this going into busted.
Now we just have another C module >.<

I'd really glad to see luasocket be removed. It takes too much time to install in ci infrastructure like travis.


fix loadConfig parameters

Description

@react-native-community/cli-config recently changed the input of LoadConfig, this let's @rnx-kit/preset handle the new input.
Resolves #3212.
Test plan
Tested locally on the RNW repository

Thanks for submitting a fix. I'm oof atm so I'm doing everything on my phone but I'll try to get this published later today.


Remove memory-check feature

Which issue does this PR close?

Closes #1171.
Rationale for this change
The memory-check feature was supposed to help in finding memory leaks, but the corresponding test was broken for a long time, showing that it is not really used. At the same time, the actual tracking was not behind a feature gate, adding synchronization overhead to every allocation.
What changes are included in this PR?
Removes the feature gate and the AtomicISize used for tracking.
Are there any user-facing changes?
Not sure whether this should really be considered a breaking change. The only use of the feature in the arrow-rs code base was for a unit test, so there is no change in behavior. If someone has a dependency on arrow-rs with the feature active, they would need to remove that feature from their Cargo.toml, but there would be no other code changes required.

Codecov Report

Merging #1222 (00445ac) into master (e72875e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1222   +/-   ##
=======================================
  Coverage   82.70%   82.70%
=======================================
  Files         175      175
  Lines       51712    51706    -6
=======================================
- Hits        42768    42764    -4
+ Misses       8944     8942    -2

Impacted Files
Coverage Δ

arrow/src/alloc/mod.rs
91.42% <ø> (-1.26%)
:arrow_down:

parquet/src/encodings/encoding.rs
93.71% <0.00%> (+0.19%)
:arrow_up:

parquet_derive/src/parquet_field.rs
66.21% <0.00%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72875e...00445ac. Read the comment docs.

Nice cleanup -- thanks again @jhorstmann


Change Buffer Manager Size From Shell

Currently this is done through common/config.h and restarting the shell.

We have decided to not allow dynamically resizing buffer manager.


docs: add Program Types/XDP documentation

Added documentation for https://aya-rs.dev/book/programs/xdp/
Feel free to make reviews and suggest improvements.

Applied your reviews, also corrected some typos

@vadorovsky No problem! Should be good now. I committed your suggestions and double-checked given the chosen format.
I think you already mentioned it, but it would definitely be worth having automation for formatting, or an additional check for the MD format in the workflow. Let me know if there's anything else to change here 👍

Should be good now :) Fixed the imports, my bad!

Oops.. Will fix this evening.


WIP: Log GPU plugin resource count changes per type

This improves #1113 further by:

logging both GPU plugin resource type count changes separately, and
getting rid of DeviceTree internals access

Increase in scan() method complexity required splitting the innermost loop to a separate method => changes are best reviewed from the commits themselves.
(This is WIP because there's some ongoing discussion about whether DeviceTree could provide method for this, and to indicate that it's not supposed to go in before the next release.)

I switched to first commit from https://github.com/eero-t/intel-device-plugins-for-kubernetes/tree/gpu-count-log-2 which does not touch scan() (preferred by @bart0sh), and pushed the original code here to https://github.com/eero-t/intel-device-plugins-for-kubernetes/tree/gpu-count-log-3 (in case somebody still wants to check the earlier code).

@eero-t please, fix lint check failure.

DeviceTree discussion done & change IMHO small enough for release -> removed WIP: prefix from title.


Automatic port selection in ippeveprinter.

Issue #170 for ippeveprinter utility.
Right now I am using a wrapper function which finds an available port but it is prone to race condition because of the time gap between finding an available port and port getting acquired by the ippeveprinter utility. So, changes need to be incorporated in the ippeveprinter itself.

@dheeraj135 I do not understand - if you specify a port, ippeveprinter uses it. If you do not, ippeveprinter finds an available port. What is your expectation here?

@michaelrsweet If no port is specified and the default port(8000 in my case) is in use, then ippeveprinter exits. We can add ippserver type fallback mechanism which searches for an empty port. This issue was reported for ippserver in #170.
When the port number is not specified, ippeveprinter does not search for an available port, it tries only on the default port.

OK, I see. Yes, we can update the ippeveprinter code to search for a port just as ippserver does.

[master 8b3fdab] Merge changes from CUPS master@ac90b74470f327463b93804b8442b82f6219cba8

I have unsubscribed from the mail. Still i am getting mails. Pls look into
it.
On Fri, 9 Apr, 2021, 6:42 PM Michael R Sweet, @.***>
wrote:

Closed #204 https://github.com/istopwg/ippsample/issues/204.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/istopwg/ippsample/issues/204#event-4574369186, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ6R2HENO7BWNGTQGGLCOMLTH34LFANCNFSM4JZ7MTGQ
.

@amartyapandey7681 If you load this GitHub issue into your browser it still shows you as subscribed. If the email link to unsubscribe doesn't work (GitHub problem, not ours) then load the page and unsubscribe using the button there.


delete linter only mode

(append body later)

linterOnlyMode was introduced to enable only deno lint and disable deno's lsp functionality. This could be done simply by using the following settings:

config > lspFlags > Enables language server
config > lspFlags > Enables lint

linterOnlyMode is unnecessary, so I'll delete it!

close at #54


DHT Performance Improvement Plan

Starting a meta thread to address our plan for DHT query performance. First step is micro and macro analysis of DHT query performance.
Near term:

[ ] Improve quality and quantity of logs in DHT module (golang) (@lgierth, @gpestana)
[ ] Enable opentracing backend for logging in libp2p (@lgierth, @gpestana)
[ ] Execute query_test on IPFS network to:

[ ] Discover network topology

NAT coverage
Locality / geo distribution

[ ] Get detailed traces of dialing/DHT protocol

[ ] Visualize traces
[ ] Machine-readable debug logging (could dump serialized protobufs in a comprehensible structure to enable "time travel" debugging
[ ] libp2p daemon
[ ] IPTB/go-netdef to support virtual "NAT" undialable nodes (@bigs)

[ ] IPTB support for virtual networks that span multiple physical computers (if IPTB remains unixy in its philosophy, we could theoretically make a tool that leverages IPTB to make clustered networks)

Visibility for @whyrusleeping @lgierth @gpestana @carospiegly

Closing this issue, moving to working group


Support embedded go_proto_library

Checklist

[ ] I have filed an issue about this change and discussed potential changes with the maintainers.
[ ] I have received the approval from the maintainers to make this change.
[x] This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: https://github.com/bazelbuild/intellij/issues/5566
Description of this change
Support embedded go_proto_library as source files in the same Go package.
With this change, proto refers to the pb.go as source files which is what we intend to do:
cat bazel-bin/proto/proto-106940904.intellij-info.txt
build_file_artifact_location {
  is_external: false
  is_source: true
  relative_path: "proto/BUILD.bazel"
  root_execution_path_fragment: ""
}
deps {
  dependency_type: 0
  target {
    label: "//proto:fooproto_go_proto"
  }
}
go_ide_info {
  import_path: "github.com/bazelbuild/intellij/examples/go/with_proto/proto"
  sources {
    is_external: false
    is_source: true
    relative_path: "proto/translators.go"
    root_execution_path_fragment: ""
  }
  sources {
    is_external: false
    is_source: false
    relative_path: "proto/fooproto_go_proto_/github.com/bazelbuild/intellij/examples/go/with_proto/proto/fooserver.pb.go"
    root_execution_path_fragment: "bazel-out/darwin_arm64-fastbuild/bin"
  }
}
key {
  label: "//proto:proto"
}
kind_string: "go_library"

Hi! Thanks @tingilee for your contribution. Could you please write a test for this?

Hi! Thanks @tingilee for your contribution. Could you please write a test for this?

Added tests and also include dependencies needed in the WORKSPACE.

LGTM, but there's a conflict.
@tpasternak want to have a final look?
@mai93 what's the policy for introducing new dependencies to WORKSPACE?

@tpasternak

So I just don't fully understand why it is required to add all the dependencies to the WORKSPACE file. How do we use them?

These dependencies where added similarly to https://github.com/bazelbuild/intellij/blob/f49aaf253d0bd3a8a03eb35e32b0d2bb4a98e0af/WORKSPACE#L865-L881. Previously, there was no tests for Bazel + Go integration in IntelliJ, now I've added tests for Bazel + Go integrations, we need the golang dependencies, specifically all of the dependencies to support aspect/testing/tests/src/com/google/idea/blaze/aspect/go/go_proto_library/BUILD

@tingilee I've rebased this PR and addressed the comments on this branch: https://github.com/blorente/intellij/tree/blorente/address-comments. Should be ready to merge.
If you're okay with it, feel free to rebase this PR on top of mine. Or I can just merge my version if you're busy, whatever works. This functionality would be very useful for us.

@blorente Thank you so much, your branch seems to work for me!
My Goland subscription was going unused for over 8 months because of this bug, I can finally be happy again)

@tpasternak @mai93 , would you be okay if I open a PR with the cleanups and we merge this? Some of our users really liked the feature, and it seems generally useful.

@tingilee I opened a PR with the cleanup here: https://github.com/bazelbuild/intellij/pull/6030
Please let us know in a couple of days if you'd like to incorporate the changes to yours, otherwise we'll merge it.

@blorente Hi!
I've tried out our plugin version and unfortunately it doesn't seem to solve
https://github.com/bazelbuild/intellij/issues/5538
Specifically, If an embedded proto library depends on an embedded proto library, resolution still fails. I have not yet had the time to create a more complex use-case in my demo repo, which I will try to do this week, but I'd be happy to demonstrate the problem. I'm also not against contributing a fix myself, but I have no idea how intellij works and how the plugin is structured, so it would take me really-really long to do so.

@ramilmsh I've tried to reproduce the case you mention in https://github.com/blorente/intellij/blob/blorente/repro-oss-issue-with-proto-in-proto/examples/go/with_proto/proto/BUILD.bazel, and haven't been able to.
Since this PR, though it may be incomplete, is useful on its own, I'd like to merge it soon. Let's hop over to the issue you opened to discuss if it's missing some features, and how to implement them.

Closing since https://github.com/bazelbuild/intellij/pull/6030 merged.


Add support for decorators

Note from maintainers
For people coming to this thread later—if you use MobX or a similar library, you don’t need decorators. They are just syntax sugar in this case.
Learn more: https://github.com/facebookincubator/create-react-app/issues/214#issuecomment-236151343, https://github.com/facebookincubator/create-react-app/issues/411#issuecomment-238974268.
Here is why we don’t include them: https://github.com/facebookincubator/create-react-app/issues/411#issuecomment-242740921.

The lack of decorators is currently the only thing which makes me feel uncomfortable to use this project for a MobX-based frontend.

We will add them when Babel supports them out of the box. The proposal is being updated (has it already been?) and we don't want users to suffer through a breakage caused by this.
IIRC MobX should work fine without decorators. It's just a little bit more verbose.

I would like decorators but I agree with @gaearon . It would be nice to have decorators in React Native too. Decorators are currently at "stage 1" in the ecmascript-standardization process, and it isn't until "stage 3" that all the syntax and semantics are complete, so I think it makes sense to wait. https://github.com/tc39/proposals

Since this seems like a consensus I'll close this. Thanks for kicking off the discussion @kripod!

I know that it may be against the philosophy of the project, but how about adding an optional .reactapp.json file which would allow advanced overrides to be made.
Example:
"overrides": {
  "babel": {
    "plugins": ["babel-plugin-transform-decorators-legacy"]
  },
  "eslint": {
    "extends": "airbnb"
  }
}

Sorry, we don't currently plan to support overrides like this. This makes it very hard for us to change the underlying settings and tools. You might have better luck with some of the alternatives listed in README!

For people coming to this thread later—if you use MobX or a similar library, you don’t need decorators. They are just syntax sugar in this case.
Learn more: https://github.com/facebookincubator/create-react-app/issues/214#issuecomment-236151343, https://github.com/facebookincubator/create-react-app/issues/411#issuecomment-238974268.

Decorators are now not a legacy transform (see babel-plugin-transform-decorators) and is a part of babel-preset-stage-2. Now may decorators be added?

@gaearon on a different issue you wrote

We’re happy to support decorators after the spec advances, and they are officially supported in Babel without the -legacy plugin.

Isn't this the case now? Is adding support for decorators now on your agenda?

I'd be comfortable including them once they reach Stage 3. Treating them differently from Class Properties for reasons explained earlier: we dogfood Class Properties and will release a mod if they change.

@kripod , it support reactapp.json to overrides config now??

They are just syntax sugar in this case.

It's almost never just syntax sugar. Syntax can help to inherently reduce the complexity of a program. Reading a program, writing it, understanding it. All of these tasks can be improved in many ways with the right syntax not only reducing errors but also increasing pace.

@gaearon babel seems to now be off the -legacy plugin for 7.0 https://github.com/babel/babel/tree/7.0/packages/babel-plugin-transform-decorators

@gaearon might be the good time to have decorators now :+1:

Hi @canercandan, the proposal is still currently stage-2. We will not consider adding support until they've been in stage-3 for quite some time.

There should be a way to configure CRA without ejecting, and without installing React Super Scripts or similar. We could configure Babel for example, even in an already created app. Maybe creating a config folder and setting the config folder as an env variable should leverage the CRA config.

For anyone reading this in the future, I would like to point out that the decorators spec has changed significantly. I'm really glad we made the decision to not support them at early stage, so users who didn't eject don't need to change their code.
I don't recommend anyone to rely on the legacy decorator transform (that is not part of CRA). See this thread for more info: https://twitter.com/dan_abramov/status/897491076537356288.

An update for MobX: from MobX 4 and onward, it will be a lot more simple to use MobX without decorator syntax. Enabling decorator syntax is no longer required to use decorators. Instead of writing
import { observable } from "mobx"

class X {
  @observable y = 1
}

One can 'manually' apply the decorators using the decorate utility:
import { decorate, observable } from "mobx"

class X {
  y = 1
}
decorate(X, { y: observable })

(Cross linking #214, #411 as those are closed)


More advanced references

Make it possible to refer - link to, relate to - edge, this means that a node can relate not only to another node but also to another relation
make it possible to build more complex groups of nodes and edges to be able to relate to
make it possible to have relation between 2+ nodes - to support formal logic for example.

example: node-c = node-a AND node-b

more complex groups of nodes and edges ...
I thought of this too, but isn't that already the parent node of the group, i.e the first node in it?

Basically, yes, except we want sometimes to threat differentially "inner-knowledge" of nodes and edges, for example:

not present it in search, or
keep it initially closed
associate special plugin/viewer  for the knowledge-group and lunch it when we want to enter the knowledge

Examples

brainstorming
cvrkut: a poem is presented as a cluster of nodes/edges
...


How to use the sdk

Hey, Thank you for the sdk and open source you work.
I'm having trouble to get the appId for the sdk

Updated the docs - sorry for lack of clarity!


chore: switch to Next.js

Purpose
This PR migrates this app to Next.js.
Do note that the Card layout is performed using JS and currently has broken styles when viewed with JS disabled.

note that for production deployment, you will need to head to the Netlify UI and add the Next.js cache and Essential Next.js plugins.


add tests for multipe databases and queries

Codecov Report

Merging #20 (599c60f) into master (e051dae) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   83.10%   83.26%   +0.16%
==========================================
  Files          10       10
  Lines        1308     1309       +1
==========================================
+ Hits         1087     1090       +3
+ Misses        221      219       -2

Impacted Files
Coverage Δ

src/stellar_extension.h
81.61% <100.00%> (+0.05%)
:arrow_up:

src/stellar.h
74.55% <0.00%> (+0.70%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e051dae...599c60f. Read the comment docs.


Get current crop rect

Version
3.7.0
Development Environment
Node v12.7.0, NPM 6.13.0, Chrome 78.0.3904.97
Expected behaviour
Is it possible to get the currently applied crop rectangle? I'm working on a fork where I need to extract all the transformations (i.e. crop, rotation, text) to JSON when the edit is done, most of these are no problem, but I'm having a bit of trouble finding out the best way to retrieve the crop rectangle.
My current solution is to save the crop rectangle when the crop command is executed, but this doesn't account for undo's and redo's.
src/js/imageEditor.js
  crop(rect) {
    const data = this._graphics.getCroppedImageData(rect);
    if (!data) {
      return Promise.reject(rejectMessages.invalidParameters);
    }

    // Begin modifications
    this.transformation.crop = {
      x: rect.left,
      y: rect.top,
      width: rect.width,
      height: rect.height
    };
    // End Modifications

    return this.loadImageFromURL(data.url, data.imageName);
  }

Is there a way I can read the currently applied crop directly, for example from the _canvas object in graphics.js?

Resolved this by pushing the current transformation to the undo/redo stack along with the command:


Add discord badge to the top of the README

Add a discord shield/badge to the top of the repo's README, linked to our community Discord (https://discord.gg/xWRaCDBtW4).

@lukeocodes hey want to help.
Can you assign it to me?

@subhajit20 Sure thing. Thanks for helping out!


Can't find any authorized adb device

Not sure how to debug this or replicate it, I'm on Fedora 36. Maybe this is a "me" problem but the Windows version doesn't work either so I'm a wee bit sad.

Hi. Try to connect your Galaxy M21 by wire, and make sure your Galaxy M21 has accepted the debugging request from Fedora 36.
I mean prompt like:

If nothing helped, try another app like https://play.google.com/store/apps/details?id=com.edegrangames.skyMusic


[CI] Enable CI for MXNet 1.6 pre-release

Enable CI for MXNet 1.6 pre-release. We need to ensure that our code remains compatible with MXNet 1.6. Currently we're only testing against MXNet 1.7 pre-release version.
Based on a manual build uploaded to my S3 bucket. There are currently no public builds of MXNet 1.6 pre-release available.
cc @dmlc/gluon-nlp-team

Blocked by https://github.com/apache/incubator-mxnet/issues/16933

@leezu CI still needs fix

Job PR-1023/16 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1023/16/index.html

Job PR-1023/17 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1023/17/index.html

Job PR-1023/19 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1023/19/index.html


update libcurl with SSL support

This PR updates libcurl to 7.64.1, and uses polarSSL for TLS 1.2 support

Oh cool! That's a great project. I had no idea this could work with such a small patch. I used an old port and made the patch by doing a diff. I have no idea what was even in it.
Do you know if this updated curl library works better than the old one? Do you have some code to test it with?

I ported this curl 7.64.1 +polarSSL version to PS4 (open orbis sdk) and it works nice, so I thought about updating the PSP build too. I did a quick overlook on the 7.15.1 patch, and most changes seem not relevant anymore, so I created a minimal patch to use cmake with polarSSL
I still need to test this on real PSP hardware, just to be sure everything is still working as expected. If nothing weird happens, this should be a nice feature bump from 7.15.1
Btw, it seems the Docker server is having some issues and the build checks can't start at all. I guess we'll hav to try later 😓
About test code, this small function should be enough to test, once the PSP app has a network link:
http_download("https://google.com/robots.txt", "ms0:/robots.txt");

#define HTTP_SUCCESS 1
#define HTTP_FAILED  0

int http_download(const char* full_url, const char* local_dst)
{
	CURL *curl;
	CURLcode res;
	FILE* fd;

	curl = curl_easy_init();
	if(!curl)
	{
		LOG("ERROR: CURL INIT");
		return HTTP_FAILED;
	}

	fd = fopen(local_dst, "wb");
	if (!fd) {
		printf("fopen Error: File path '%s'", local_dst);
		return HTTP_FAILED;
	}

	printf("Download URL: %s >> %s", full_url, local_dst);

	curl_easy_setopt(curl, CURLOPT_URL, full_url);
	// Set user agent string
	curl_easy_setopt(curl, CURLOPT_USERAGENT, HTTP_USER_AGENT);
	// not sure how to use this when enabled
	curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);
	// not sure how to use this when enabled
	curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);
	// Set SSL VERSION to TLS 1.2
	curl_easy_setopt(curl, CURLOPT_SSLVERSION, CURL_SSLVERSION_TLSv1_2);
	// Set timeout for the connection to build
	curl_easy_setopt(curl, CURLOPT_CONNECTTIMEOUT, 10L);
	// Follow redirects (?)
	curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);
	// The function that will be used to write the data
	curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, fwrite);
	// The data filedescriptor which will be written to
	curl_easy_setopt(curl, CURLOPT_WRITEDATA, fd);
	// maximum number of redirects allowed
	curl_easy_setopt(curl, CURLOPT_MAXREDIRS, 20L);
	// Fail the request if the HTTP code returned is equal to or larger than 400
	curl_easy_setopt(curl, CURLOPT_FAILONERROR, 1L);
	// request using SSL for the FTP transfer if available
	curl_easy_setopt(curl, CURLOPT_USE_SSL, CURLUSESSL_TRY);

	// Perform the request
	res = curl_easy_perform(curl);
	// close filedescriptor
	fclose(fd);
	// cleanup
	curl_easy_cleanup(curl);

	if(res != CURLE_OK)
	{
		printf("curl_easy_perform() failed: %s", curl_easy_strerror(res));
		remove(local_dst);
		return HTTP_FAILED;
	}

	return HTTP_SUCCESS;
}

hi @sharkwouter , quick question, what's the recommended SDK package to download from the pspdev releases?
should I use v20200725-2  (tagged as latest) ?
or maybe something newer, like Development build from Nov16, 2021 "pre-release"
I'm building a simple app to test this updated libcurl with SSL support on real hardware, and I want to be sure I'm using the best stable sdk, to closely replicate the Docker environment you're using here on the auto-build.

I'd recommend to always get the development build. We don't really make new tags at the moment.

So I am testing this PR on this branch (I know it's not a very minimal example) the only new libraries I had to link against were:
z
polarssl
curl

However compiling fails due to the following error:
build] [ 16%] Linking CXX executable curl_test
[build] /usr/local/pspdev/lib/gcc/psp/11.2.0/../../../../psp/bin/ld: /usr/local/pspdev/psp/lib/libcurl.a(mime.c.obj): in function `curl_mime_filedata':
[build] (.text+0x1c9c): undefined reference to `basename'
[build] collect2: error: ld returned 1 exit status
[build] make[2]: *** [CMakeFiles/curl_test.dir/build.make:161: curl_test] Error 1
[build] make[1]: *** [CMakeFiles/Makefile2:84: CMakeFiles/curl_test.dir/all] Error 2

A quick google search lead to this answer so I wonder if something similar is required here.

So I am testing this PR on this branch (I know it's not a very minimal example) the only new libraries I had to link against were:
z
polarssl
curl

However compiling fails due to the following error:
build] [ 16%] Linking CXX executable curl_test
[build] /usr/local/pspdev/lib/gcc/psp/11.2.0/../../../../psp/bin/ld: /usr/local/pspdev/psp/lib/libcurl.a(mime.c.obj): in function `curl_mime_filedata':
[build] (.text+0x1c9c): undefined reference to `basename'
[build] collect2: error: ld returned 1 exit status
[build] make[2]: *** [CMakeFiles/curl_test.dir/build.make:161: curl_test] Error 1
[build] make[1]: *** [CMakeFiles/Makefile2:84: CMakeFiles/curl_test.dir/all] Error 2

A quick google search lead to this answer so I wonder if something similar is required here.

thanks for your tests @KorigamiK
Yes, basename() is missing from the psp-sdk, but is still defined in the standard headers. It's a very simple function, so it can be ported to the PSP with no issues.
Until it's added to the psp-sdk, you can add the code to main.c:
char * basename (const char *filename)
{
	char *p = strrchr (filename, '/');
	return p ? p + 1 : (char *) filename;
}

That should be enough to link and compile everything (curl, polarssl, z)


Support TableProperties when writing DataFrames

Thanks for the PR - i'll merge them all and then create a release


Bump dcos-net

High-level description
Bump dcos-net and OTP
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS_OSS-1952 Upgrade OTP version
DCOS_OSS-1951 Merge dcos-dns http server into dcos-rest application
DCOS_OSS-1946 Get rid of erldns udp and tcp servers

Related tickets (optional)
Other tickets related to this change:
Checklist for all PRs

[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[x] Test Results: [link to CI job test results for component]
[x] Code Coverage (if available): [link to code coverage report]

https://github.com/dcos/lashup/pull/38
https://github.com/dcos/mesos_state/pull/36
https://github.com/dcos/telemetry-net/pull/11
https://github.com/dcos/dcos-net/pull/24
https://github.com/dcos/dcos-net/pull/23
https://github.com/dcos/erl-dns/pull/3
https://github.com/dcos/dcos-net/pull/22

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot bump-ee

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label [Ready For Review]

@mesosphere-mergebot label [Work In Progress]

@mesosphere-mergebot bump-ee

@mesosphere-mergebot label [Ready For Review]


all: determine bug origin trees and missing backports

Run reproducers on other trees in order to determine:

The tree where the bug originated.
The tree to which the bug has already spread.
Missing backports for bugs.

Extend the KernelRepo structure to contain the information about commit
flow and about the exact labels that need to be assigned for (1) and
(2).
Fore better understanding look at the tests in tree_test.go.
TODO (before merging):

[x] Display at least the minimal information in the UI: show the labels and a collapsed list of bug tree origin related jobs.
[x] https://github.com/google/syzkaller/pull/3813 will contain changes to how bug labels are stored. Rebase after it's merged.
[x] Deploy on a dev syzbot instance and see how it work in practice.
[x] We need to rename the Obsolete label in KernelRepo.

@dvyukov  PTAL

@tarasmadan PTAL


Authorization headers cached

I am using FluentD to get data from an API using an input plugin and sent data to another API using an output plugin.
The input plugin uses oauth to authenticate and this works flawless. The output plugin uses an basic Authorization header with a simple token.
The logging says: RestClient.post "http://:/services/collector/event", 7571 byte(s) length, "Accept"=>"/", "Accept-Encoding"=>"gzip, deflate", "Authorization"=>"Splunk ", "Content-Length"=>"7571", "User-Agent"=>"rest-client/2.0.0 (linux-gnu x86_64) ruby/2.1.10p492" which should work fine.
The result is a 401 Unauthorized nonetheless. I was getting insane.
I created pcap file to debug this and in the pcap it turned out that RestClient was reusing the oauth headers from the input plugin in the output plugin as well.
How is this possible? Is there a way to fix this, like force-clear headers?

Can you provide more information about these plugins? I don't know what those libraries are doing.

Output plugin: https://gist.github.com/cmeerbeek/08633a63ba2e7bfad035359809e26538
Input plugin: https://gist.github.com/cmeerbeek/1a3623811ff08f9ce1d94994e26cfe5d
Unfortunately I cannot post the code of FluentD ;-)
So the output plugin I confituren to use a simple Authorization header with a token. Instead looking at the pcap on the destination I see the oauth headers from the input plugin.
I have the pcap but I rather sent it to you directly and not on GitHub.

Sorry, I'm really not familiar with these libraries. If there's evidence of a bug in rest-client itself, please feel free to reopen.


nixos/gdm: Conflict plymouth-quit, but more carefully

Motivation for this change
To avoid extra flickering on boot, we want GDM to tell Plymouth to quit after GDM takes control of the display. That configuration was reverted in #71065 because it caused nixos-rebuild switch to bring down the graphical session. The reason was that if multi-user.target wants plymouth-quit.service which conflicts display-manager.service, then when nixos-rebuild switch starts multi-user.target, display-manager.service is stopped so plymouth-quit.service can be started. We avoid this problem by removing WantedBy: multi-user.target from plymouth-quit.service.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hi, very sorry that this has gone under the radar. I will try this out since I've been experimenting with things again lately.

I can't remember fully how to reproduce the issue before, but rebulid switch did not bring down my session.

I can still reproduce the issue before by adding the first hunk without the second hunk (i.e., reverting ed20a541c59f54e12824a867e1c288ef21963ea2). The second hunk avoids this problem.

I can still reproduce the issue before by adding the first hunk without the second hunk (i.e., reverting ed20a54) and running nixos-rebuild switch. The second hunk avoids this problem.

It all sounds good to me :+1:


Update warp extension

Description

This changes allow users to change order of items listed in "Open Launch Configuration Command".  Thanks to usage of LocalStorage the order of items is persisted. The reasoning behind those changes is that some configurations are more frequently used than others therefore users might want to have them displayed at the top of the list.
Screencast

https://github.com/user-attachments/assets/c2e7a775-30ac-4093-8a28-fbb0715e51f2
Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Do you mark it as ready when the PR is ready @drzastwakamil 🙂

@pernielsentikaer ready 😀

@joetannenbaum @theRubberDuckiee does anyone of you have some feedback before we can merge this+

@pernielsentikaer @joetannenbaum @theRubberDuckiee is there anything else I could do to help with the review process?


fix(reports) do not log error on TCP connection issues

@hbagdi CI reported linting errors. Also, I believe these log entries can be removed without keeping them around as comments


Combination of output.libraryTarget: 'window' and output.library: string[] gives a window[undefined] as result.

Bug report

What is the current behavior?
Combination of output.libraryTarget: 'window' and output.library: string[] gives an erroneous rusult:
window[undefined] =
...

If the current behavior is a bug, please provide the steps to reproduce.
const config = {
  mode: 'development',
  entry: {
    templates: './tpl.js'
  },
  output: {
    path: `${__dirname}/build`,
    filename: '[name].js',
    library: ['MyLib', '[name]'],
    libraryTarget: 'window'
  }
};

What is the expected behavior?
This config should generate output like this:
window["MyLib"] = window["MyLib"] || {}; window["MyLib"]["templates"] =
...

Other relevant information:
webpack version:  4.20.2
Node.js version: v10.7.0
Operating System: win10
Looks like the issue is here: https://github.com/webpack/webpack/blob/master/lib/LibraryTemplatePlugin.js#L28-L29
const accessorAccess = (base, accessor, umdProperty, joinWith = "; ") => {
	const normalizedAccessor =
		typeof accessor === "object" ? accessor[umdProperty] : accessor;
	const accessors = Array.isArray(normalizedAccessor)
		? normalizedAccessor
		: [normalizedAccessor];

if accessor parameter is an array it passes the typeof accessor === "object" condition anyway (thanks JS).
PS.
Sorry for not sumbiting a PR - I am not so familar with github processes.

https://github.com/webpack/webpack/blob/df7da2cdd58e9534ae5e73a25e9c064b02c4d625/lib/LibraryTemplatePlugin.js#L28-L29
Yes you are right this is the bug.
Need to be changed to
 const normalizedAccessor =
 	typeof accessor === "object" && !Array.isArray(accessor) ? accessor[umdProperty] : accessor;

and a test need to be added.
Please send a PR. Or somebody else.

Fixed https://github.com/webpack/webpack/pull/8122


Photo is always null

[Enter feedback here]
Does not work.  Photo is always Null.  Capabilities for webcam and microphone were added to app manifest package.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1e5277f4-f2e4-dffe-0c08-06531d4145a1
Version Independent ID: 1e5277f4-f2e4-dffe-0c08-06531d4145a1
Content: Media picker for photos and videos - .NET MAUI
Content Source: docs/platform-integration/device-media/picker.md
Product: dotnet-mobile
Technology: dotnet-maui
GitHub Login: @davidbritch
Microsoft Alias: dabritch

@colemd1 Which platform?

Windows 11

Hi @colemd1
Afraid this is a bug in WinUI3 that needs to be worked around. For more info, see https://github.com/dotnet/maui/issues/7660
This workaround is shipping as part of .NET MAUI 8.


FIX #182 added support for video tag

This fix can capture the video tag with its currentTime.
Default HTML5 video controls will not be captured.
Use the fix after building using grunt build

@anand-io,Excellent Job!!
I've contact owner to accept this fix.So can u solve thest conflicts and pull request again
Many tks for your patient.


Can't get in conversition-

I configed openai key.but, aways get this page.

no input shows

The chat view needs to occupy the full height of a pane, so please ensure that nothing else is open. I plan to fix this issue in the future.

The chat view needs to occupy the full height of a pane, so please ensure that nothing else is open. I plan to fix this issue in the future.

+1 to the issue filed here. I always keep a todo list in my sidebar. So, I have to drag my todo list out of the sidebar every time I want to use the chat function (after I realized why I couldn't start a chat). The Weaver extension should be able to allow for something else to be in the sidebar at the same time and just adjust Weaver's size accordingly (with the ability to scroll all the way to the bottom without having it cut off and not visible).

A new update will be coming soon, and I will try to address this in that update.


Don't trigger searching, in the GENERIC viewer, when Shift is used together with the regular keyboard shortcut (issue 12421)

Please note that this change won't affect the Firefox built-in PDF Viewer, since it uses the native browser findbar. However, it brings the GENERIC viewer inline with how searching is normally triggered in browsers.
Note that in Firefox searching is only triggered by Ctrl+F (or command+F on Mac), but Shift isn't used; see https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly#w_search
Furthermore, looking at the "Miscellaneous" section of https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly#firefox:mac:fx81 the command+Shift+F shortcut is even reserved for the "Toggle Full Screen" functionality on Mac.
Fixes #12421

/botio-linux preview

Thanks!


Update to new grant API

See https://github.com/mirage/mirage-xen/pull/9 and #32.
Also, convert to dune and fight bit-rot.

The Travis jobs are mostly failing with:
[sexplib.v0.12.0] downloaded from https://ocaml.janestreet.com/ocaml-core/v0.12/files/sexplib-v0.12.0.tar.gz
[ERROR] The sources of the following couldn't be obtained, aborting:
          - parsexp.v0.12.0: Curl failed

Master hadn't been tested for a year. I set up a monthly cron job, which failed because of opam lint.


Test Network :: Network interface and functionalities test module

Run IPMI With Multiple IPs Configured :: Test out-of-band IPMI com... | FAIL |
404 != 200

Also teardown failed:
Several failures occurred:

1) 404 != 200

2) Evaluating expression ''<IP_ADDRESS>' == '{u'description': u"The specified property cannot be found: 'Address'"}'' failed: SyntaxError: invalid syntax (<string>, line 1)

3) 404 != 200

4) Evaluating expression ''<IP_ADDRESS>' == '{u'description': u"The specified property cannot be found: 'Address'"}'' failed: SyntaxError: invalid syntax (<string>, line 1)
------------------------------------------------------------------------------
Test Network :: Network interface and functionalities test module ... | FAIL |

In review https://gerrit.openbmc-project.xyz/#/c/10092/


*[android]fix the bug of extra data not add to param in image load event @notdanger

Is the iOS have the extra field now?

I do not check extra field in iOS.

The CI is broken and the PR have no response for a long time. I'll close it shortly. If there still need further discussions about it, you could open a new pull request.
Thanks for your cooperation.


Update Streams index page

(This issue is closely related to https://github.com/pod4lib/aggregator/issues/771 in that whichever option (expand/collapse hidden date range info or use a tooltip to display it) we decide to go with, we probably should use that option for both that issue and this one.)
My understanding is we need to convey these new things to the user about default or previously default streams:

Whether a stream was previously the default stream
If it was previously the default, the date range, or date ranges, it was the default stream
That they cannot make a previously default stream the default stream again

Below are two sets of mockups represented two different approaches to conveying this new information. In both approaches we would:

Rearrange the first two columns of the current table so that Status is the second column (it doesn't currently have a heading, and is the first column)
Add an Actions column heading for the last column that displays the "Make default" and "Destroy" buttons (if the user has permissions to those)
Swap order of the the "Make default" and "Destroy" buttons
Change the label of the "Destroy" button to "Delete"
When a stream was previously the default stream, add Previous default to its Status column

The difference between the two options below is how we enable the user to see the date range(s) a stream was previously the default:

Using a disclosure icon to reveal table rows showing the date range(s) a stream was previously the default
Using a tooltip to display the date range(s) a stream was previously the default

Overall, I think the tooltip option is simpler, UX-wise, but that option does mean adding some new Javascript and might be a bit harder to implement in an accessible way. Choosing between the two options is a technical decision as much as a UX one.
Option A: Using a disclosure icon
With this option we would include the date range values for each stream that was previously the default stream as additional lines/rows in the table, but hide them by default:

A user interested in knowing when exactly this stream was previously the default stream can use the disclosure icon to expand the hidden row to see the date range:

If the stream was previously the default more than once (though I'm confused about whether this is actually possible, since one of the requirements I heard was not allowing a stream that was previously the default to be made the default again; but maybe it used to be possible so we have to account for that?), we'd just display additional lines/rows:

Option B: Using a tooltip
This option is a little simpler in terms of the effect on the UI, since we wouldn't be affecting the page layout, just adding the tooltip layer above it. Instead of the disclosure icon to expand/collapse the date range lines, we'd use an info icon that is a trigger for a tooltip:

A user interested in knowing when exactly this stream was previously the default stream can mouseover/keyboard select the info icon to reveal the tooltip with the date range:

And if the stream was previously the default stream more than once:

If we decide to go with the tooltip option, a variation we could consider is to start using a "Previous default" badge for streams where that applies. This would make the display in the streams index table a bit more consistent, possibly at the expense of the availability of the date range info being a bit harder to recognize:

It would, however, enable us to easily display the start date of the default stream using a consistent pattern.
Whichever option we decide to implement, we might be able to make the displayed date range info look a bit better than in my mockups with more thoughtful styling; I didn't want to get bogged down by that until we know which option we're going to go with.

I'm interested in what others think, but my preference is the tooltip approach using the yellow "Previous default" badge.

Closing this in favor of #787, since we've decide which option to go with.


Fix GetRoutePrefix issue

Fix to GetRoutePrefix to prevent occasional null reference errors. Issue exposes itself as messages indicating that $Url and $RequestData aren't accessible.

Great fix @msawczyn, thanks for contributing!


javascript-node-mongo not building the container

Hi, I'm creating a dev container based on javascript-node-mongo template, but it seems the urls in the Dockerfile is not well.
Is someone else having this issue?
[app dev_container_auto_added_stage_label 2/3] RUN . /etc/os-release     && curl -sSL "https://www.mongodb.org/static/pgp/server-6.0.asc" | gpg --dearmor > /usr/share/keyrings/mongodb-archive-keyring.gpg     && echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/mongodb-archive-keyring.gpg] http://repo.mongodb.org/apt/debian ${VERSION_CODENAME}/mongodb-org/6.0 main" | tee /etc/apt/sources.list.d/mongodb-org-6.0.list     && apt-get update && export DEBIAN_FRONTEND=noninteractive     && apt-get install -y mongodb-mongosh     && if [ "$(dpkg --print-architecture)" = "amd64" ]; then apt-get install -y mongodb-database-tools; fi     && apt-get clean -y && rm -rf /var/lib/apt/lists/*: 1.597 deb [arch=amd64 signed-by=/usr/share/keyrings/mongodb-archive-keyring.gpg] http://repo.mongodb.org/apt/debian bullseye/mongodb-org/6.0 main 2.040 Get:1 http://deb.debian.org/debian bullseye InRelease [116 kB]

Hi 👋
I built a dev container with the default javascript-node-mongo Template, and it was created successfully.
It used the default 20-bullseye Node version, @wguerram which Node version did you use for configuring the Template?

but it seems the urls in the Dockerfile is not well.

Can you help paste the error message? Thanks!

@samruddhikhandale thanks for your kindness on taking a look. You're are right, it works fine. I think was a firewall blocking something. I'm on a different nerwork.


Add dx port.

dx is a modern C++ library for DirectX programming.
Official source website here (by @kennykerr): http://dx.codeplex.com/
I created this port by using my fork here: https://github.com/sdcb/dx

Hi @sdcb, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Thanks for the PR!


Can't edit API after creation

When clicking edit on an API, the page stays on the same page and nothing happens. Konga does successfully request a few API endpoints and there are no javascript errors, the console logs the following:
SSSSSSSSSSSSSSSSSSSSSSS Object {data: Array[1], status: 200, config: Object, statusText: "OK"}
Kong Version: 0.10
I have tried in chrome, safari and firefox. This issue exists on both the master and dev branch.

Hi @pantsel
Thanks, this fixed the issue, keep up the good work!!


RpcBriefcaseUtility.openBriefcase supports multiple concurrent downloads

https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=2590561&view=logs&j=4aa4172e-637e-5768-b518-2d8dfafc7ab0&s=b15d9194-8f26-5328-b47f-5968c76b37e7&t=8eecb1f5-5b40-5ae7-7ad4-1a56e22d11f9&l=2523
this is failing repeatedly, it doesn't look like it's related to my changes

https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=2590561&view=logs&j=4aa4172e-637e-5768-b518-2d8dfafc7ab0&s=b15d9194-8f26-5328-b47f-5968c76b37e7&t=8eecb1f5-5b40-5ae7-7ad4-1a56e22d11f9&l=2523 this is failing repeatedly, it doesn't look like it's related to my changes

@khanaffan @tcobbs-bentley
[Mocha_Result_XML]:   <testsuite name="Changeset Reader API" timestamp="2023-12-22T12:05:51" tests="1" time="0.6210" failures="1">
[Mocha_Result_XML]:     <testcase name="Changeset Reader API Changeset reader / EC adaptor" time="0.6160" classname="Changeset reader / EC adaptor">
[Mocha_Result_XML]:       <failure message="expected '0x3d' to equal '0x3f'" type="AssertionError"><![CDATA[AssertionError: expected '0x3d' to equal '0x3f'
[Mocha_Result_XML]:     at Context.<anonymous> (main.js:155478:27)]]></failure>

I don't understand why this function even exists. Who uses it and why?

I don't know what the test is trying to do, but I think that the failure is that the changeset ID is changing. Also, the failure is happening when the test is run on an iOS simulator. @khanaffan, do you know what might be happening?

I don't understand why this function even exists. Who uses it and why?
Nobody should use a downloaded briefcase from a web application, and nobody should use RPC for a desktop application. Is this just from tests?

No idea, I found this bug accidentally when looking through the source code for something else. I don't want to go into detail about whether this whole class is needed or not, but I took patching this bug as a top priority and didn't want to postpone it to achieve some bigger/better refactor. IMHO, this kind of code with critical security flaws (the possibility to open a completely different iModel than what was requested) has no right to exist in our code base, even if no one uses it.

No idea, I found this bug accidentally when looking through the source code for something else. I don't want to go into detail about whether this whole class is needed or not, but I took patching this bug as a top priority and didn't want to postpone it to achieve some bigger/better refactor. IMHO, this kind of code with critical security flaws (the possibility to open a completely different iModel than what was requested) has no right to exist in our code base, even if no one uses it.

This whole concept (opening a briefcase from RPC) should be removed, not "patched" and propagated. Only checkpoints may safely be opened from RPC. I suggest you simply remove the openBriefcase function and throw an exception if anyone is still using SynchMode.PullOnly or SynchMode.PullAndPush  (and deprecate them).

This whole concept (opening a briefcase from RPC) should be removed, not "patched" and propagated. Only checkpoints may safely be opened from RPC. I suggest you simply remove the openBriefcase function and throw an exception if anyone is still using SynchMode.PullOnly or SynchMode.PullAndPush (and deprecate them).

I patched it not because I want people to use it, but because that was much faster than deprecating, removing chunks of code and then fixing all the unit tests that use it. I do agree it should be removed, but I would like that to be a part of a bigger refactor, i.e. getting rid of RpcBriefcaseUtility altogether. I'd prefer not to keep this trap in the code base while we wait for someone to find the time for that and to fix all the unit tests that will be broken.

I agree there should definitely be a refactoring to remove the whole concept. It was never a good idea and has lots of other serious implications that can't be ignored (disk space, security, performance, etc.), Fortunately we don't use it anymore and it can safely be removed. If you're not going to do that here/now (when?), I definitely think the right thing to do is to disable it somehow for our backends. We can't leave this gaping hole open.
At the very least you should deprecate the SyncMode members in this PR.

Well, there is no code path in the public API that uses this, and RpcBriefcaseUtility is not exported in the barrel file, so I hope our backends are already not using it. I added deprecation tags so if someone is somehow using it, they will get an additional warning.

https://dev.azure.com/bentleycs/iModelTechnologies/_build/results?buildId=2590561&view=logs&j=4aa4172e-637e-5768-b518-2d8dfafc7ab0&s=b15d9194-8f26-5328-b47f-5968c76b37e7&t=8eecb1f5-5b40-5ae7-7ad4-1a56e22d11f9&l=2523 this is failing repeatedly, it doesn't look like it's related to my changes

@khanaffan @tcobbs-bentley
[Mocha_Result_XML]:   <testsuite name="Changeset Reader API" timestamp="2023-12-22T12:05:51" tests="1" time="0.6210" failures="1">
[Mocha_Result_XML]:     <testcase name="Changeset Reader API Changeset reader / EC adaptor" time="0.6160" classname="Changeset reader / EC adaptor">
[Mocha_Result_XML]:       <failure message="expected '0x3d' to equal '0x3f'" type="AssertionError"><![CDATA[AssertionError: expected '0x3d' to equal '0x3f'
[Mocha_Result_XML]:     at Context.<anonymous> (main.js:155478:27)]]></failure>

that's me working on it.

https://github.com/iTwin/itwinjs-core/pull/6334


Fix small typo

Fixes:
manager.go:143] Starting server on socket %!s(*string=0xc4202178b0)

message.

This change is

Reviewed 1 of 1 files at r1.
Review status: 0 of 2 LGTMs obtained, and 1 stale

Comments from Reviewable


react-router-dom v6 support?

✘ [ERROR] No matching export in "node_modules/react-router-dom/index.js" for import "useRouteMatch"

    node_modules/use-route-as-state/dist/index.es.js:2:22:
      2 │ import { useLocation, useRouteMatch, useHistory, generatePath } from 'react-r..$
        ╵                       ~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/react-router-dom/index.js" for import "useHistory"

    node_modules/use-route-as-state/dist/index.es.js:2:37:

https://reactrouter.com/docs/en/v6/upgrading/v5

https://reactrouter.com/docs/en/v6/upgrading/v5#use-usenavigate-instead-of-usehistory
https://reactrouter.com/docs/en/v6/upgrading/v5#replace-useroutematch-with-usematch

Thanks, you're welcome to suggest a PR for it!
I will try to take it soon.

https://github.com/pbeshai/use-query-params/ solved react router v6 compatibilty
see:
https://github.com/pbeshai/use-query-params/blob/master/examples/react-router-6/src/index.js
https://github.com/pbeshai/use-query-params/issues/196#issuecomment-996893750

useRouteMatch -> useMatch

useMatch() now expects a parameter, but in use-route-as-state, useRouteMatch is called with no parameters, so is not a direct replacement.

I need some help here.
If there are breaking changes in react-router-dom, how can I support both v5 and v6 in my library? Do I need to create a separate branch and versions for that?

Hi @baruchiro
In my opinion, you shouldn't support V5 and V6 in same time in your library.
Create a new major version of you library who indicate that react-router v5 it's doesn't support anymore.
If someone want to use react-router V5, it can use the previous major version of your library.

Hi @s-roueche, thanks!
I think it means that I have two options. One is to stop supporting V5, and the other one is to maintain two branches.
Since V6 is still not stable and since the migration is a big issue, I think I need to choose option two.
WDYT?

If you want I started to implement the migration to v6 on a personal branch.
There are just 4 tests failed.... I don't really understand how to fixe it 😓
If you want I can push it on your repo ?

Yes, sure! Thank you, I will be happy to see your branch.
I also did some local work for the upgrade, and also failed on tests, you can see it here: https://github.com/baruchiro/use-route-as-state/pull/176.

I wasn't able to push my branch on your repo because I don't have the permission.
Can you give me the permission to do it ?
my username is @s-roueche

You should push your fork and open a PR.
Use gh pr create with the Github CLI.

Is done.

I wrote my own package to handle state using search params with react-router-dom-v6: https://github.com/jschwindt/react-use-search-params-state

@jschwindt Why not implement it here?

I wrote my own package to handle state using search params with react-router-dom-v6: https://github.com/jschwindt/react-use-search-params-state

@jschwindt Why not implement it here?

I extracted it from an app that I was working on, and the usage is slightly different. I commented here just in case it is useful for somebody else.

Will there be a version compatible with v6 or will this be staying with v5?

I will deprecate this package.


[Bug Report] Maze/AntMaze issues

Hi, I believe I have found a couple of issues in the Maze/AntMaze environments. I have resolved both of these issues in commit 5573d5e, and I’m happy to submit a PR.
1) AntMaze sparse reward always zero
For continuing tasks in AntMazeEnv, the sparse reward is always zero. This is because at each step, .compute_terminated() resets the goal when the Ant is sufficiently close, before the reward is calculated.
Here’s a code example to test this:
import numpy as np
import gymnasium as gym

env = gym.make("AntMaze_UMaze-v3", continuing_task=True, reward_type="sparse")

total_reward = 0

# 1000 "episodes" of 100 steps
for _ in range(1000):
    env.reset()

    for _ in range(100):
        action = env.action_space.sample()
        _, rew, _, _, _ = env.step(action)
        total_reward += rew

print(total_reward)

Currently this returns exactly zero since no reward is collected, but placing .compute_reward() above .compute_terminated() gives a non-zero reward. In PointMaze, this issue was fixed in commit ace181e2a0d83be8940103bbb4d7e917afb30119.
2) AntMaze can reset into a terminal state
The Ant will sometimes start within the goal radius. This is because there is a maze_size_scaling factor missing in the distance check in MazeEnv.generate_reset_pos().
In AntMaze maze_size_scaling = 4, so the xy position noise can be up to 1.0 in each direction. An unfortunate combination of goal noise and reset noise can cause the Ant to start within 0.45 of self.goal. This issue does not affect PointMaze because there maze_size_scaling = 1.
Here’s a code example to test this:
import numpy as np
import gymnasium as gym

env = gym.make("AntMaze_UMaze-v3", continuing_task=True)

for _ in range(1000):
    obs, _ = env.reset()
    dist = np.linalg.norm(obs["achieved_goal"] - obs["desired_goal"])
    assert dist > 0.45

Checklist

[x] I have checked that there is no similar issue in the repo (required)

Your test for sparse rewards, is not correct, since using random actions is very unlikely to get you to the terminal state

Does this also affect the PointEnv?

Thanks for taking a look at this issue.

I agree that it is not a robust test in general, it’s primarily just a check to compare pre/post commit (after the suggested changes, it does get a very small but non-zero reward). If you have suggestions for a more robust test I can implement that, but I think the issue is fairly clear from the step method of AntMaze:

https://github.com/Farama-Foundation/Gymnasium-Robotics/blob/d0a10dc8b5b919b21572b5efc5b45ba98f452553/gymnasium_robotics/envs/maze/ant_maze.py#L277-L289
and comparing to the PointMaze step:
https://github.com/Farama-Foundation/Gymnasium-Robotics/blob/d0a10dc8b5b919b21572b5efc5b45ba98f452553/gymnasium_robotics/envs/maze/point_maze.py#L379-L391
.compute_terminated() is common to both and resets the goal location if within 0.45.
This issue previously existed for PointMaze. I’m proposing to make the same fix as commit ace181e, but for AntMaze.

The PointEnv/PointMaze env’s are not affected by either of these issues, due to the commit referenced above, and because maze_size_scaling = 1 so the missing factor does not change anything.

I would say it is worrying that compute_terminated is not a pure function, it should be refactored into 2 function: compute_terminated (but now it just computes if it is terminated)

These changes would requite a new revision "AntMaze_UMaze-v4"
@rodrigodelazcano

@alexdavey feel free to make a PR


Add LogLevel for Blob Storage module

Add description of "LogLevel" environment variable to configure the output log level from Blob Storage module on IoT Edge.

@PatAltimore
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


How to compile in Windows ?

I'm following documentation. I'm on Windows 10 / Visual Studio. However I'm unable to build.
-> has to be all_build:
c:\Github\cpu_features.NET>cmake --build cmake-build-release --target all_build -v
=> works!
-> building produces several errors:
MSB3073: the command "setlocal
=> exit with 2 errors
However I managed to compile but the when using it, I get allot of exceptions.
Building also produces recursive directories: c:\Github\cpu_features.NET\src\CpuFeaturesDotNet\Native\Platforms\win\x86-64\Release\Release\Release\Release\Release\Release\Release\Release\Release\Release\Release\Release\Release\Release\Release\Release\Release\Release..

Hello, thanks for interest in cpu_features.NET! And sorry for not answering for a while...
You're right about all_build for VS.
For now we have made several changes related to VS, so you can retry with up to date master/main branch.
Also could be tried running cmd as Admin and adding --config=Release to build command.
E.g.:
cmake -S. -Bcmake-build-release -A x64 -DCMAKE_BUILD_TYPE=Release
cmake --build cmake-build-release --target all_build -v --config Release
dotnet build "src/CpuFeaturesDotNet" -c Release --force --runtime win10-x64
dotnet test "tests" -c Release --runtime win10-x64

If it doesn't solve issue, please provide some more information:

full building log (cmake --build cmake-build-release --target all_build -v > errors.log and send errors.log file)
visual studio version
os version
if running dotnet from cmd please provide full command


Parameter to truncate datetime  to 1400-9999 range

I am getting this error when trying to fetch arrow batches with timestamps that are before the year 1400.
File "/opt/env/lib/python3.6/site-packages/turbodbc/cursor.py", line 335, in fetcharrowbatches
    table = rs.fetch_next_batch()
IndexError: Year is out of valid range: 1400..9999

Do you guys know a workaround that can help here? if not, would it be worth it to add a flag to make_options to truncate the dates to the valid range?
thanks in advance

This is a limitation in turbodbc::date_to_days which uses boost::gregorian::date internally and only supports the year range 1400..9999. We should look for an alternative implementation that supports larger year spans.

@xhochy would it be possible to use the arrow::util::date classes in here directly?  I took a look at the code, but it does not seem obvious if anything is actually exposed to downstream libraries


Updates the paths to downloadable PDFs and resources from resource pages.

Fixes

Fixes #290 by @Murdock9803

Description

The pull request aims at updating the links or paths to some downloadable resources which are present at the bottom of some resource pages, as shown in the accompanying picture.
Technical details

The addition of _assets directory to the codebase required the updation of paths which pointed towards the downloadable resources.
Screenshots

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@possumbilities please have a look at the PR. the links have been fixed.


Incorrect source URL in source maps when sources not under context hierarchy

Bug report

What is the current behavior?
There is project layout
|- js
|-- packages
|--- lib
|---- package.json
|---- webpack.config.js
|---- compiled
|----- my.js
|----- my.js.map
|- lib
|-- My.kt
Imagine that my.js was produced from My.kt and my.js.map is appropriate source map, sources field in source map is something like ["../../../../lib/My.kt"].
NPM project (package.json and node_modules) is not in the same directory hierarchy as original My.kt file.
I use devtoolModuleFilenameTemplate: "[absolute-resource-path]" setting to get only absolute paths of files in output source map.
In output source map I get sources field:
["webpack/universalModuleDefinition","/Users/ilya.goncharov/reproducers/webpack5-devtool/js/packages/lib/My.kt"]
The second file is not correct location of original file.
If the current behavior is a bug, please provide the steps to reproduce.
Link to the repro: https://github.com/ilgonmic/webpack5-devtool

What is the expected behavior?
In output source map I want to get correct sources field with original locations.
["webpack/universalModuleDefinition","/Users/ilya.goncharov/reproducers/webpack5-devtool/lib/My.kt"]

Other relevant information:
webpack version:  5.27.1
Node.js version: v15.4.0
Operating System: macOS Big Sur (version 11.2.2)
Some investigations:
There was no such problem with webpack-4.
Now in NormalModule.js on creating SourceMapSource contextifySourceMap is used

https://github.com/webpack/webpack/blob/master/lib/NormalModule.js#L406
https://github.com/webpack/webpack/blob/master/lib/NormalModule.js#L635

It leads to polluting of source maps with additional webpack:// protocol.
When it is passed to source-map through SourceMapConsumer, it is normalized and then "redundant" .. is removed because it is detected not as absolute path but as URL.
So without contextify we get correct result in this case, but with contextify generated path is incorrect.
Is there reason why contextify necessary?
And is there some workaround in my particular case?
I of course can prepare Pull Request, but I am wondering is it ok to just remove contextifies or could you please give some other advice to fix this behaviour?

yeah


Implement Index for LogicalArray e.g. UuidArray

We can just forward to the inner, however, to make this ergonomic we need a wrapping type for the returned Index::Item<'a> to make it usable as a T. I think for T: Copy this is trivial, but requires the concept of ReferenceType<'a> for ArrayType impls to support T: !Copy types.
impl<
        T: LogicalArrayType<T>,
        const NULLABLE: bool,
        Buffer: BufferType,
        OffsetItem: OffsetElement,
        UnionLayout: UnionType,
    > Index for LogicalArray<T, NULLABLE, Buffer, OffsetItem, UnionLayout>
where
    Option<T>: ArrayType<T>,
    <T as LogicalArrayType<T>>::ArrayType: Nullability<NULLABLE>,
    <<T as LogicalArrayType<T>>::ArrayType as Nullability<NULLABLE>>::Item:
        ArrayType<<T as LogicalArrayType<T>>::ArrayType>,
    <<<T as LogicalArrayType<T>>::ArrayType as Nullability<NULLABLE>>::Item as ArrayType<
        <T as LogicalArrayType<T>>::ArrayType,
    >>::Array<Buffer, OffsetItem, UnionLayout>: Index,
{
    type Item<'a> = <<<<T as LogicalArrayType<T>>::ArrayType as Nullability<NULLABLE>>::Item as ArrayType<
        <T as LogicalArrayType<T>>::ArrayType,
    >>::Array<Buffer, OffsetItem, UnionLayout> as Index>::Item<'a>
    where
        Self: 'a;

    unsafe fn index_unchecked(&self, index: usize) -> Self::Item<'_> {
        self.0.index_unchecked(index)
    }
}


npx create-remix@latest errors: filePath.replaceAll is not a function

What version of Remix are you using?
Latest
Steps to Reproduce
Run npx create-remix@latest
Node: v14.15.4
Ubuntu Linux: 20.04

Expected Behavior
npx create-remix@latest
Actual Behavior
Expected the app to be created

Was wrong npm version


Support parsing directive attributes - Part 2/2

https://github.com/aspnet/AspNetCore/issues/6364

Added a new syntax for representing Directive attributes in the syntax tree
Added a feature flag to support parsing directive attributes
Updated bind, ref, event handler and key lowering passes
Updated classified span generation logic to provide cspans for @ and the :
Updated tests and error messages

Tested in VS, this is what it looks like,

🆙 📅


Note execution context

It should be made more clear whose security context a Team Flow will operate in as many people want to avoid a scenario where they set up a Team Flow that executes using the creator's (or whoever change it last's) security context. The risk of being able to set this up should be clearly pointed out in this article.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a50a5424-6bb4-c34c-bb82-991a5dd3e0df
Version Independent ID: ea8ac9ee-e014-ad33-59f5-5d15f8a38ad8
Content: Learn how to add other owners to a flow and create team flows - Microsoft Flow
Content Source: flow-docs/create-team-flows.md
Service: flow
GitHub Login: @MSFTMan
Microsoft Alias: deonhe

@SolidKnight Thanks for your feedback. We'll improve the documentation on this.


21 to22 merge

There were merge conflicts due to things not being marked as move.

Couldn't determine certificate name for signable file: D:\a\1\s\obj\ContainerSigning\81908F38B56D27361AAA5C2AA9565EDAFA8A274CCD6BC2DE96CEEB0C58F37427\Microsoft.VisualStudio.Web.BrowserLink.dl

@natemcmaster  do you know offhand how to fix the above?


[Back end] resolvers.js/queries

We need to review this together, see what is truly needed

These are still ongoing, but we're updating as we go, so Im going to close the issue since we got rid of the errors from before


Add Mindmap to Readme

Possibly improve and use the Mermaid-based mindmap to visually summarize all aspects the template covers

If #18 is concluded with adopting ruff, the mindmap must be updated.