Multiple KEDA deployments in a single cluster

Over the past weeks/months I've had more and more questions if you can deploy KEDA multiple times in a single cluster.
The scenarios for this is:

Hard Multi-tenancy - People want to isolate KEDA across teams/customers in a single cluster

Customer A should not be able to see/interfer what customer B does

Soft Multi-tenancy - People want to isolate KEDA across teams/customers in a single cluster for management purposes (example)

Given it's shared in the cluster, it lacks clear ownership

Security - People want to reduce the amount of access that a given KEDA deployment has

For example, when using pod identity a centralized KEDA needs access to every resource that the apps depend on in the cluster which is a security risk (#2656)

This issue is used to gather all scenarios to see how we can best tackle this ask; if we start doing it. If you do have more scenarios, do let us know.
Background - Why is this not supported today?
As per https://github.com/kedacore/keda/issues/470, you can see that Kubernetes upstream only allows end-users to run a single metric server per cluster. There is an open proposal by @zroubalik to improve this, but until then we cannot deploy the metric server multiple times.
The KEDA operator allows you to watch all namespaces, or just a single one. In theory, we could change KEDA so that we can re-use the metric server and change our Helm charts to be more flexible by providing 3 of them (metric-server, operator & full), we still have concerns with this scenario:

It will become harder to diagnose issues, because there is no guarantee that the operator runs the same version as the metric server
It does not provide a full isolation between everyone. This does not fix scenario 1)
The metric server is still a shared component, so there still has to be somebody in charge of managing it. This does not fix scenario 2)
If somebody removes the metric server, it will impact other teams relying on it.

Because of this, we are waiting to support this model until https://github.com/kubernetes-sigs/custom-metrics-apiserver/issues/70 is tackled in KEDA upstream.

+1 on this ask.

Ack, just wanted to make sure.
We should definitely look into having the router implemented for that purpose. Out of curiosity, do you know if the various adapters are planning to be converted to KEDA scalers in the future or some of them wants to remain standalone projects?
By the way, I started looking at the router again and I am looking for contributors to drive and maintain it. Do you perhaps have some contributors that would be interested and have time to look into that?

Ack, just wanted to make sure.

👍

We should definitely look into having the router implemented for that purpose. Out of curiosity, do you know if the various adapters are planning to be converted to KEDA scalers in the future or some of them wants to remain standalone projects?

The only one I am aware of is DataDog https://docs.datadoghq.com/containers/cluster_agent/external_metrics/?tab=helm, but there might be other adapters, I just don't know :)

By the way, I started looking at the router again and I am looking for contributors to drive and maintain it. Do you perhaps have some contributors that would be interested and have time to look into that?

That's great! @kedacore/keda-contributors ^ anybody interested. I'd be interested, but the problem for me is time :( So I'd join this effort, but cannot assure full commitment.

I'd be happy to help on the non-code side if there is need for it.
With regards to existing adapters, Prometheus is another that is already a scaler. But I think this is not related in the sense that we should be open to support other metric servers next to KEDA as well though.

With regards to existing adapters, Prometheus is another that is already a scaler. But I think this is not related in the sense that we should be open to support other metric servers next to KEDA as well though.

Yeah for Prometheus we are looking at deprecating the project in favor of KEDA Prometheus scaler which is why I was curious if other adapters also choose this path. But I completely agree that it shouldn't be a reason to limit the possibilities for the users.

It is also worth mentioning, that with the lastest architecture changes we have done (slimming down the Metrics Server logic), we might be able to provide a solution for multitenancy on our own.
The Metrics Server will be just a light layer that will route the requests to individual KEDA installations (based on the namespace).

I'm interested but I have limited bandwidth and I have several things I wanna do in KEDA for next weeks. After them, I'm willing to contribute/maintain this feature.
Could this match with your plans @dgrisonnet?

Hello, to mention my use case in case it may help... cluster operators like keda are managed by a platform team (or cluster admin team), but they only concern installation and upgrades, all of the ScaledObjects and more importantly, TriggerAuthentications, would be managed by dev teams (tenants) that can work within one or multiple namespaces only, but definitely not the keda namespace. That is impossible today with the need of having scalers for aws cloud resources, since the keda operator needs to either assume a role with permissions crossing tenant boundaries,  or be able to assume different roles also crossing boundaries in the process.
The external secrets operator solves this beautifully with the Managed SecretStore per Namespace scenario, although other multitenancy scenarios are supported. a SecretStore seems to be reminiscent of what a TriggerAuthentication is expected to be. That may be worth taking a look for ideas.

Hi @vcardenas .
Sadly, they are different use cases. The current limitation is that metrics apis only allow a single service behind the api endpoint, which totally limits the architecture to have a single metrics server with cluster scope and this is a k8s limitation. Those projects you mentioned don't have this problem because they don't expose any kind of metric to the cluster api server.
In KEDA we are working on having this multitenant support or at least something similar but it's still in progress

I get that, my comment was oriented towards the scenario of having a single keda operator/metrics-server and multiple tenants making use of it.

Hello Team, Thanks to @JorTurFer for assisting me with some of my queries. Thank you so much. What I am struggling with right now is how to make KEDA watch multiple namespaces but not all. I tried to deploy multiple keda-operators by changing the WATCH_NAMESPACE values according to my need, but this is not working. Only one namespace is actively working others are not scaling up the resources. Any guidance on configuration and anything I could do to achieve my goal. Will grateful for any help here.

as we are already talking about this on the discussion, let's continue there to not generate noise on this issue. This issue is to track the feature, and currently it's not supported.


Official Dockerfile?

Should we create an official Dockerfile that shows how to prepare the env for Icefall experiments?

There is a folder, docker, inside the root directory of icefall repo.

🤦♂
Sorry, it’s a long day.

Please see also
https://hub.docker.com/repository/docker/k2fsa/icefall/tags?page=1&ordering=last_updated
We have pre-built docker images for icefall now.


Remove Scope::defer

This method doesn't seem useful and isn't really used in practice. In addition to that, it causes confusion. A better alternative would be scopeguard::defer!.
Closes https://github.com/crossbeam-rs/crossbeam/issues/92

I think it's a little bit early to remove defer().  It's like RCU's call_rcu(), and it's quite widely used in Linux.  So I'd like to further discuss the use cases of defer() before removing it.

This code:
// A
crossbeam::scope(|scope| {
    // B
    scope.defer(foo);
    // C
});
// D

Is literally equivalent to:
// A
{
    // B
    defer! { foo() }
    // C
}
// D

The only peculiarity that might arise is how foo() gets ordered with regards to scoped thread joins.

In the current semantics, you're right, but I think we want to generalize Scope in a way that scoped guards cannot replace defer().  In https://github.com/crossbeam-rs/crossbeam/issues/173, we discussed such a generalization in which you can send a scope to another thread.  If it's implemented, scope.defer() called in another thread cannot be emulated by scoped guards.
Your example enlightens me on the semantics of defer().  I think deferred functions should be executed before joining unjoined threads.  This is not only for matching with the semantics of scoped guards, but also for dealing with the case that a handle is joined in a deferred function.  Concretely, see the following example:
scope(|scope| {
    let handle = scope.spawn(|| ());
    scope.defer(|| handle.join().unwrap());
}).unwrap();

Related https://github.com/crossbeam-rs/crossbeam/issues/92: we previously said that threads are joined before deferred functions are executed, but I think it should be the other way.
Related #32: I added a test for this case and fix the semantics as discussed in this comment.

If it's implemented, scope.defer() called in another thread cannot be emulated by scoped guards.

we previously said that reads are joined before deferred functions are executed, but I think it should be the other way.

Suppose deferred functions are executed first and then all threads are joined. What happens if a scoped thread calls scope.defer() at the moment the scope is exiting and joining all threads? Should such deferred functions be executed or not? If so, when? :)

No need - #32 already removes defer so this would just create merge conflicts.


Update profile picture and AboutUs.md

Coverage remained the same at 91.094% when pulling 5a9df861b5fb646dda6a7fc90bcdc9170fef80b1 on aditya-update into 42a982810501e53a9f16c4dc21b189182acf2003 on master.

Coverage remained the same at 91.094% when pulling 5a9df861b5fb646dda6a7fc90bcdc9170fef80b1 on aditya-update into 42a982810501e53a9f16c4dc21b189182acf2003 on master.


save model to bucket after every epoch so runs can be ended early

https://keras.io/callbacks/#modelcheckpoint
fill-in period=<epoch freq.> in ModelCheckpoint in train_segmentation_model.py

@Josh-Joseph closing without addressing, as current method of solving best model is preferred. Noted that it was considered though.


Plugin should load project config if available

Do you want to request a feature or report a bug?
Feature
What is the current/expected behavior?
I would expect vim settings to adopt those in my prettier config and not need to supply them through a vim configuration. I have a .prettierrc.yaml file within my project, but running :Prettier yields a default formatting.
Currently not supported.
What version of vim-prettier are you using - (output of :PrettierVersion) ?
0.2.7
What version of prettier are you using - (output of  :PrettierCliVersion) ?
1.18.2
What is your prettier executable path - (output of  :PrettierCliPath) ?
{project path}/node_modules/.bin/prettier

This is the purpose of the parser parameter. Closing.


Feature request: Wipe Tower

Would be great if user could choose the location on the bed where the tower is placed.
I often print large objects and CURA places the tower outside of the bed :(

Available feature with the next Cura release! ;)


Apply the safe list to projects which didn't specify an upfront include

cc @billti @amcasey

                Debug.assert(!!typeAcquisition, "typeAcquisition should be non-null");

If it can be null, do you have to check that before accessing .enable?

Refers to: src/server/editorServices.ts:2271 in 744511c. [](commit_id = 744511c878007bc14b3047d2c7e7aceff7c5b5bc, deletion_comment = True)

👍


(WIP) Fix #433: allow _id with $setOnInsert

What this PR does:
Allows specifying _id with $setOnInsert (currently leads to failure)
Which issue(s) this PR fixes:
Fixes #433
Checklist

[ ] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

Added tests for 3 commands -- findOneAndUpdate, updateOne, updateMany -- since I don't think findOneAndReplace takes update document (as per https://www.mongodb.com/docs/mongodb-shell/crud/update/ ). I think this covers all cases.


Is there a way to extract all files in a folder?

I know you can't with the GUI but is there command line support for this?

There is command line support on my AssetRipper fork.


We should revamp our styles

If you look at these two styles from avalonia:
Simple Theme:

Fluent Theme:

I think we should add some more named colors to our scheme:

ActionEnabledBackground/ActionEnabledForeground
ActionDisabledBackground/ActionDisabledForeground
InputEnabledBackground/InputEnabledForeground
InputDisabledBackground/InputDisabledForeground

Perhaps Checked variations as well?

Initially i just tried to keep as few colours as possible. I feel lack of strategy in the design overall.
May be, for instance, we should align to turbo vision approach rather than avalonia.
Lets say, we introduced colors you mentioned, what would be the values for 4bit themes there?
Out of topic: i was thinking it's such a pain to keep templates/styles updated with each upgrade. Could we teach LLM to convert Avalonia styles to Consolonia ones, using some guideline? In this case we would work on the guideline, colors etc rather than matching what was changed and needs to be synced from avalonia.

What is involved with the template definitions? Is it mostly font size layout changes, or colors or?

Everything plus additional things which do not exist in avalonia at all, like buttons - on consolonia has shadow, has delayed press. I dont think it can be automated, thats why thinking about LLM

I was doing a little survey and I think we might be able to get away with this as themes:
// basic text fore and background colors
ThemeForegroundBrush
ThemeBackgroundBrush

// alternate ? not 100% certain on this one.
ThemeAlternateForegroundBrush
ThemeAlternateBackgroundBrush

// Buttons checkboxes, radio buttons etc.
ThemeActionForegroundBrush
ThemeActionBackgroundBrush
ThemeActionCheckedForegroundBrush
ThemeActionCheckedBackgroundBrush
ThemeActionDisabledForegroundBrush
ThemeActionDisabledBackgroundBrush

// input controls
ThemeInputForegroundBrush
ThemeInputBackgroundBrush
ThemeInputDisabledForegroundBrush
ThemeInputDisabledBackgroundBrush
ThemeInputPlaceholderForegroundBrush
ThemeInputPlaceholderBackgroundBrush

// Listboxes and data grids and such
ThemeItemsForegroundBrush
ThemeItemsBackgroundBrush
ThemeItemsSelectedForegroundBrush <-- Is this always just invert of Itemsforeground/background ?
ThemeItemsSelectedBackgroundBrush

// Scroll bar
ThemeScrollbarForegroundBrush
ThemeScrollbarBackgroundBrush

// general things
ThemeBorderBrush
ThemeShadeBrush

// I noticed fluent talked about semantic theme colors. This seems like a useful idea.
ThemeSucceessForegroundBrush
ThemeSucceessBackgroundBrush
ThemeWarningForegroundBrush
ThemeWarningBackgroundBrush
ThemeErrorForegroundBrush
ThemeErrorBackgroundBrush

// We should make all of the symbols in our controls themable.
ThemeRightSymbol Examples:🞂 ➩ → ↣ etc.
ThemeLeftSymbol Examples: ◀ ⧏ 🢤 etc.
ThemeUpSymbol Examples: ⃤ ▲ etc.
ThemeDownSymbol Examples: ▼ ▽ etc.
ThemeCloseSymbol Examples: x X ╳❎❌ ⨯ etc.
ThemeCheckedSymbol Examples: ☑ ⌧ 🗹 🗷 ⮽ 🗵
ThemeUncheckedSymbol Example: ☐
ThemeIndeterminateSymbol Example: ⮿
ThemeSelectedSymbol: Examples: ⭗ ⏺
ThemeUnselectedSymbol Examples: ◯ ⭘ ⚪ 🔘
ThemeExpandedSymbol Examples: ▼
ThemeCollapsedSymbol Examples: ▶ 🞂
ThemeRefreshSymbole: Examples: ↺ ↻ 🔄

Given this as the structure for our control theming then I thnk we can do Turbo, Material style, Fluent style, monochrome etc.

Alternative is needed for popups and alternative datagtid rows.

Symbol can be multiple chars I think so TurboVision might use
ThemeUncheckedSymbol = "[ ]"
ThemeCheckedSymbol = "[x]"
while material would use richer Unicode chars.

Here's a fluent design generator
https://fabricweb.z5.web.core.windows.net/pr-deploy-site/refs/heads/7.0/theming-designer/index.html
It's cool, but much much more involved to map to the controls.
I kind of like the material design, it seems simpler.

regarding 4 bit and 3 bit I think we just have a templates which map to the 16 color or 8 color.
ThemeForegroundBrush   = White
ThemeBackgroundBrush = Black
ThemeDisabledForegroundBrush = Gray
ThemeDisabledBackgroundBrush = Transparent

etc.
If a color comes through that is not a 4 bit color, then we map the color to best guess 4 bit color, but the theme would be expressed only via 4 bit or 3 bit colors.
I think that also works for monochrome.
ThemeForeground=White
ThemeBackground = black
ThemeDisabledForeground = White
ThemeDisabledBackground = Black

etc.
Basically the RenderTarget would only emit the correct codes for the current rendermode, but the Theme would map correct values down to RenderTarget.
Bitmap renderer would map to correct color maps. Everything else would be theme based.

We might consider having a 2 stage theme for material designs.
Our templates would be expressed in terms of ThemeForegroundBrush/ThemeBackgroundBrush, etc.
We would map the material design values to the themes
ThemeForegroundBrush = Primary
ThemeBackgroundBrush = OnPrimary
ThemeAlternativeForegroundBrush = Secondary
ThemeAlternativeBackgroundBrush = OnSecondary

etc.
The alternative would be to adopt the material design names for our templates
    <color name="primary">#6750A4</color>
    <color name="onPrimary">#FFFFFF</color>
    <color name="primaryContainer">#CBC0E6</color>
    <color name="onPrimaryContainer">#201933</color>
    <color name="secondary">#625B71</color>
    <color name="onSecondary">#FFFFFF</color>
    <color name="secondaryContainer">#DCD8E6</color>
    <color name="onSecondaryContainer">#2C2933</color>
    <color name="tertiary">#7D5260</color>
    <color name="onTertiary">#FFFFFF</color>
    <color name="tertiaryContainer">#E6CDD5</color>
    <color name="onTertiaryContainer">#332227</color>
    <color name="error">#B3261E</color>
    <color name="onError">#FFFFFF</color>
    <color name="errorContainer">#E6ACA9</color>
    <color name="onErrorContainer">#330B09</color>
    <color name="background">#fcfcfc</color>
    <color name="onBackground">#323233</color>
    <color name="surface">#fcfcfc</color>
    <color name="onSurface">#323233</color>
    <color name="surfaceVariant">#e0dee6</color>
    <color name="onSurfaceVariant">#5e5c66</color>
    <color name="outline">#8e8999</color>

I do really like how LogicUI has primary, secondary and tertiary containers.
Playing around with TurboVision app, they use colors on buttons to represent

Control has Focus
Control is default (for Enter key)

regarding the templates, how do you do it today? Do you look at each template in Avalonia.Themes.Simple or something and hand tweak it?
Given we have a source (like button.axaml in Avalonia.Themes.Simple) and an existing target (consolonia/button.axaml) I definitely could write a tool to do that conversion.

Whew. OK that was a train wreck. I tried using OpenAI to generate the output and it just couldn't help itself by

Creating malformed xaml
Applying arbitrary layout
Making up theme template names
etc.
I don't think that's going to end up saving any time.

I'm starting to think we should have 2 or 3 core themes

TurboVision - literally using the turbovision design style [ ] for checkbox, drop shadow for button, etc.  This would be designed with 4 bit/16 core color and work well for non high color terminals.  This would have variants

Light/Dark/HighContrast (Monochrome?) variants of color scheme but not change the control templates.

Simple - This leans into high color and rich templated unicode support for symbols (like 🗹 I've been exploring above) and be built around a core color theme generator like LogicUI.  Variants would be simple using the light/dark variant pattern LogicUI has created. That would look fantastic, give people a sweet simple way of creating their own theme.

Are you saying we should create separate templates for turbovision vs fluent? I think maintaining two sets of templates will be 2x harder.
Speaking about how to define colors, I think makes sense to adopt already existing definitions like from some generator

Why this should be different?

ThemeInputDisabledForegroundBrush
ThemeInputDisabledBackgroundBrush

vs

ThemeMenuDisabledForegroundBrush
ThemeMenuDisabledBackgroundBrush

I dunno 🤔 lol

Do you like idea of templating the symbols?

Yes. I'm up for anything which could allow to have universal template which could be further colored into different themes.

I experimented to see what a "Simple" theme might look like in chars:

I think it looks pretty tight. The only thing that is different from Turbo is

symbol substitution
I'm drawing the outline of the textbox using border chars instead of color hightlights
I'm implementing ToggleButton and ToggleSwitch

Something I'm noticing is that it seems like we could support actual border with border thickness of 1, 2, and maybe 3 using the line art chars for 1/8, 1/4, /1/2.
So drawing a rectangle would use box chars, but border brushes could use tight vertical and horizontaol chars.  That's what I did effectively to put the box around the combobox.  With the caveat that it takes up a whole char size around (Which is why I left the top annotation off).

I think we should draw similar set of sketches for

TurboVision
Monochrome
May be htop/btop/bpytop theme
With this we can compare the difference and extract it to control properties and further to theme resources or to theme resources directly if something is not defined in the control (like shaddow character or scroll characters).

But still, manually converting Avaloina templates is a pain. And furthermore, lets say, even if chatGPT model learned how to convert that, any next time it might convert differently due to the fact we do not own the model data.


Path must be string. Received undefined.

Trying to use the 'errorMatch' feature while compiling a LaTeX project using 'cmd: scons'. Compilation works perfectly but I get the following error:
[Enter steps to reproduce below:]

Set errorMatch config as follows:

cmd: scons
errorMatch:
  - ^(?<file>[\\/0-9a-zA-Z\\._]+):(?<line>\\d+): (?<message>.*)$

while trying to match against log entry (the first line really):
./exam.tex:19: Undefined control sequence.
<recently read> \toprule

l.19                 \toprule

./exam.tex:19:  ==> Fatal error occurred, no output PDF file produced!

Atom Version: 1.12.7
Electron Version: 1.3.13
System: Ubuntu 14.04.5
Thrown From: build package, v0.67.0
Stack Trace
Uncaught TypeError: Path must be a string. Received undefined
At path.js:7

TypeError: Path must be a string.

The primary error was that the regex string needed to be enclosed in quotes. Without the quotes atom was throwing the 'Path must be a string' error.
After the quotes were added I did have to remove the ^ and $ to make the error-matching actually work.
I would suggest updating the README to reflect both of these points.


ngclient: Use %-style formatting in logging

(this is about code currently in experimental-client/ngclient branch, hopefully soon in develop)
We currently have some f-strings in logging:
                        msg = (
                            f"Adding child role {child_role_name}.\n",
                            "Not backtracking to other roles.",
                        )
                        logger.debug(msg)

Let's use %-style instead in logging (even if f-strings are great for other string formatting, see the google python style guide)

I'd like to give it a try, please?

Curious: why does Google recommend % over f-strings? I think the latter is far more readable, no?

I agree, it's just that f-strings get greedily evaluated before logger can check if they are needed: with %-style the logger can check if the string is needed (and usually it isn't) before building the string. Obviously 99% of our logging is nowhere near a critical path where this would matter ... but I'd still like to be able to log inside e.g. a download loop without thinking about it.
The other reason would be that our linters complain :) We could of course modify our linter config (and document the style guide difference) but that feels like work too...

My 0.02 BTC is that we should keep developers not Google/linters/speedtests happy, but that's just me. I will let you guys decide 🙂


Enable user to optionally remove var namespace statement at start of file

Previously script would fail if namespaces contained a . (due to attempting to var stuff like App.Name). Plus the var namespace code isn't necessary in all circumstances and reduces flexibility for the user.

Feature is already implemented.


Protected instance member inaccessible to same-class constructor via object destructuring assignment

🔎 Search Terms
class protected member constructor another instance access destructuring assignment same type typescript
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about each common issue, pre-declined request, behavior that looks wrong but is actually right, etc.

⏯ Playground Link
https://www.typescriptlang.org/play/?#code/CYUwxgNghgTiAEYD2A7AzgF3gNShAlsACpQDmAXPAK4r4COVCaAngLYBGSEA3ALABQoSLAQZmABwQlS8ALzxMMfChkAyeAG94AbVwFiZALqUMMRvAC+ffgOFo08AKpoQMTQPjxxVdgTDw4KGBUCGZ4AAsoFGAIEEpFZVJrT3EYJAxwDOB4AH0MMjRKaW1Daw9EVEUqMAwkNwAKcs8qFxhKZ1cAGib4FBAAd2k0AH5400SS7v5PAEp3ac94RoXF+dXVyOjYk3D8NAA6TZiQKfXFvIKdvf2L0jRO+AB6R-gAUQAld4B5d57PCzk8DEkiQADNegMhnJZPIAEQ0UCg5QgYCwv6LYbUVrozyUDQ49ZHbZY1yHKLHU5nda3QpOVr7MDhcAAayG9X2HL6gwKM0pVMsPRmAh6GF2ByJCHkLVJEuSi1F1xpgOBIDBEO5d2hcIRICRfVR6Mx0pgN3ymue8C+AGl0e16YyWWyOfsuUMZnKLMKFql8AA3KAZBT5DD4fwOsCsgrsjlEMZKFQlGZFMglNaLOAYKgwFDwIj7JEQDIwZZneoYOOJJNA+B7XNkOQAPgJGH2sRUovgDfgAAYHhbxr78Hh4CAAB5QVjiWKCj0CT38IA
💻 Code
declare const ValidTag: unique symbol;
declare type Tag = string & { [ValidTag]: true };

class User {
  public readonly handle: string;
  protected _tags: Tag[];

  constructor (
    user: User,
    newTags?: string[],
  ) {
    (
      {
        handle: this.handle,
        _tags: this._tags, // ERROR
      } = typeof newTags === "undefined"
        ? user
        : {
            handle: user.handle,
            _tags: User.checkTags(...newTags),
          }
    )

    this.handle = user.handle;
    this._tags = typeof newTags === "undefined"
      ? user._tags // OK
      : User.checkTags(...newTags);
  }

  private static checkTags(...T: string[]): Tag[] {
    return T.filter(
      (t: string): t is Tag =>
        t.length > 0, // trivial example
    );
  }
}

🙁 Actual behavior
TypeScript compiler fails to transpile this code to JavaScript, throwing this error on line 15 of the sample code (labeled Case 1):
Property '_tags' does not exist on type 'User | { handle: string; _tags: Tag[]; }'.

Type System: This is counterintuitive, because the logic in Case 2 looks equivalent to the untrained eye (there may be caveats I’m unaware of), but TypeScript does not error in that case.
Runtime: Although irrelevant to TypeScript desired behavior (as readonly is solely a type decoration), ES6 JavaScript equivalent syntax runs as expected:

class Foo {
  a; b;
  constructor(foo, newB) {
    ({ a: this.a, b: this.b } = typeof newB === "undefined"
      ? foo
      : { a: foo.a, b: Foo.processB(newB) });
  }
  static processB(B) { return B }
}
let me = new Foo({ a: 1, b: 2 });
console.log(me);                // {a:1, b:2}
console.log(new Foo(me));       // {a:1, b:2}
console.log(new Foo(me, 9001)); // {a:1, b:9001}

🙂 Expected behavior
TypeScript compiler successfully transpiles this code to JavaScript.
Alternative A: TypeScript compiler provides a friendlier error message to help the user fail soft (which can also potentially be Quick Fixed by VSCode).
Alternative B: Won’t Fix as expected behavior, wherein the closed bug may serve as a handy reference for any future searchers on this topic.
Additional information about the issue
No response

Essentially duplicate of https://github.com/microsoft/TypeScript/issues/9974.

Essentially duplicate of #9974.

What the… I am bad at searching. 😓 I will confirm in my example and then close as dupe.

(Thanks for triaging. I had a task on myself to come back today to ask how to Close as 'Duplicate' since I don't know how to add the tag.)


max-mxj~ package - update and fix the readme

Some updates can be made to the max-mxj~ package readme

The max-mxj~ package needs to be updated to include a line that tells you to navigate to https://www.java.com/en/download/ to get it running on Windows to download the JRE. The SE Development kit alone will need the JRE downloaded as well, or mxj~ object will come up bogus. Perhaps this doesn't need to be in the readme and can be in the "requirements."

For the sentence regarding the renaming of the JDK, it is not necessary as the folder is named jdk1.8.1 when downloaded from https://www.oracle.com/java/technologies/downloads/

It says "Build as on MacOS" , but Windows doesn't use Xcode.

There are a few typos, "embedded" is consistently spelled incorrectly.

Also, the s3 link under continuous integration is currently broken

And from Alex:
A user was unable to open MaxScore on their Windows machine. I could repro on my windows 11 machine, and ultimately found that I needed to download a fresh JRE in addition to the JDK 18 in order to get MaxScore (and in fact, any mxj classes) working.
This was surprising to me, as I thought that the JDK included the JRE.
However, I could confirm that this could get mxj working on Windows 11, and it worked for the user as well. I recommended the user also update to JDK 18 from the JDK 17 that shipped with MaxScore.

Hi, I'll handle some of them, I'm preparing a MR for macOS and M1. Maybe the point about MaxScore should be a separated issue, with inputs from  its makers.


Tie default redirection to user in the same way as ACLs

Hi,
Rather than a default redirection common to anyone, it could be tied to the user in the same way as ACLs are (any/groups/users).
The idea is to be able to achieve such a scenario, for instance: by default, anyone is redirected to some page, while users in the “admin” group are redirected to some other page, user “bob” is redirected elsewhere, etc.
In case you go for it, I would then suggest the following modifications:

Remove notification pop-ups related to successful authentication (only maintain the ones related to failure). Instead, redirect either to /secondfactor after first factor authentication or to /loggedin in case the default redirection is made to a page not requiring 2FA; and to /loggedin in case of second factor authentication.
Then, /loggedin could be dynamic:

Add “You can complete second factor authentication here.” if user has not done so yet.
Remove “If you are not redirected in few seconds, click here.” in case there is no default redirection page for the user. Else, actually redirect the user to its default redirection page (this is the current behavior).
Remove “already” from “You are already logged in as username.”—weird to see it in case you have just logged in, and not necessary otherwise.
Keep “Click here to log out.”, in any case.

Make the redirection delay configurable in Authelia's config (in a global way).
Always redirect users visiting back the login page to /loggedin: from there, the user will be able to both perform 2FA or log out (if you implement the behavior I have described so far). As of now, the user is redirected to the 2FA page in case he has not completed it yet: he cannot decide to log out—maybe he accesses only single auth protected domains and does even know what 2FA is about.

Hello @n4kre , I found out that I never replied to this proposal, my bad. Do you have a concrete use case or any example of something similar in an existing authentication system?

I will close this issue and reopen it if more users are interested in that feature.


Partial staging only works on the right hand side view?

VSCode Version: 1.16
OS Version: Win10

Steps to Reproduce:

Click on an unstaged file to open its working tree view
Select a few changed lines on the left hand side view
Menu on top-right -> stage selected range

It doesn't work.  It only works when you do this from the right hand side view.
When trying to stage removed lines it's more intuitive to do it from the left side:

Reproduces without extensions: Yes/No

This is as designed. You must select the text in the right hand side.

With this approach you can't stage/unstage just 1 deleted line from a hunk of deleted lines.
Suppose I have 3 deletions, all consecutive (so a one "hunk" in Git GUI), and I want to stage the middle line.
In Git GUI I'd do this:

But in VSCode on the right side there's only absence of code in which you can't select the middle bits, you can only select the entire deleted block as a whole:

Repro for this and another issue (#34360) https://github.com/laggingreflex/vscode-git-test

Yes, we only support staging/upstaging the entire hunks we collect together. Created #34430 for that.


FRONTEND: SignupForm.js: replace addUser() with ADD_USER

[x] SignupForm.js: Replace the addUser() functionality imported from the API file with the ADD_USER mutation functionality.

Done


Error: Invalid index

Not sure, if this issue belong in here or to the https://github.com/doingcloudright/terraform-aws-ecr-lifecycle-policy-rule repo.
I have almost the same setup, but I am using a few more terragrunt features, so it looks like this:
terraform {
  source = "git::git@github.com:doingcloudright/terraform-aws-ecr-cross-account.git?ref=1.0.1"
}

include {
  path = find_in_parent_folders()
}

dependencies {
  paths = ["../lifecycle-rules/rotate-after-amount"]
}

dependency "lifecycle-rule-rotate-after-amount" {
  config_path = "../lifecycle-rules/rotate-after-amount"
}

inputs = {
  ## .... other inputs

  lifecycle_policy_rules = [dependency.lifecycle-rule-rotate-after-amount.outputs.policy_rule]
  lifecycle_policy_rules_count = 1

  allowed_read_principals = [
   ###
  ]

  allowed_write_principals = [
    ###
  ]

}

And in the dependency we basically only use:
terraform {
  source = "git::git@github.com:doingcloudright/terraform-aws-ecr-lifecycle-policy-rule.git?ref=1.0.0"
}

include {
  path = find_in_parent_folders()
}

inputs = {
  tag_status = "tagged"
  count_type = "imageCountMoreThan"
  count_number = 30
}

Now, when running terragrunt apply in the folder of the first block, I encounter the following error:
Error: Invalid index

  on main.tf line 92, in data "template_file" "lifecycle_policy_rules":
  92:   template = replace(var.lifecycle_policy_rules[count.index], "priority:replace:this", (count.index + 1))
    |----------------
    | count.index is 0
    | var.lifecycle_policy_rules is "[\"{\\\"action\\\":{\\\"type\\\":\\\"expire\\\"},\\\"description\\\":\\\"Rotate images after amount of: 30 is reached for prefix \\\",\\\"rulePriority\\\":\\\"priority:replace:this\\\",\\\"selection\\\":{\\\"countNumber\\\":30,\\\"countType\\\":\\\"imageCountMoreThan\\\",\\\"tagPrefixList\\\":[\\\"\\\"],\\\"tagStatus\\\":\\\"tagged\\\"}}\"]"

This value does not have any indices.

Do you have any idea what might be the reason for that? I have researched a bit already, but most topics are about sets and lists (e.g. https://github.com/hashicorp/terraform/issues/24527)
My used version:
Terraform v0.14.5

provider registry.terraform.io/hashicorp/aws v3.22.0
provider registry.terraform.io/hashicorp/template v2.2.0

Terragrunt v0.27.4

@maartenvanderhoef any idea on this? I have also tried passing the policy as a json directly into the lifecycle_policy_rules variable, which results in the same error.

Using TF13.7 I have come across similar errors but caused by myself not converting the "lifecycle_policy_rules" to the TF13 syntax (remove "${....}).
I was also using https://github.com/doingcloudright/terraform-aws-ecr-lifecycle-policy-rule to generate the rules.
Just leaving this here for anyone else that comes across this.


dotnet configuration settings

In the dotnot src, there are many references to configuration settings such as 'GEN_AI_IMPLEMENTATION' as an example (in startup.cs).  There is no appsettings.json file and no other references in the solution or scripts for 'GEN_AI_IMPLEMENTATION'.  Where do these configuration settings get set in order to run the solution?  Or is it expected that we step through the code and create settings for each value needed?  Or is this a bug?

Hello @markjones-WK!
Thank you for the feedback. Environment variables can be obtained from the deployed app's settings, but that can be misleading. I've added sample env files for each project so it will be easier to configure for debugging locally.

Excellent.  Thank you!

Awesome! Closing this out for now, feel free to reopen if needed.


Is it possible to update text in a tag ?

Probably its a newbie question, but i get stuck playing with a tag.
So i want to be update to update text between
SIGN UP
and looks like with default settings i'm unable to do that.
My solution - catch start event from IgnitionUI and add contenteditable="true" to .editable a selection. Not sure that its best solution .
here is my html:
<!DOCTYPE html>

    <meta charset="utf-8">
    <link rel="stylesheet" type="text/css" href="/static/contenttools/content-tools.min.css">

Play New Experience

Easy to use landing page to showcase your new app and product. Discover now and find something amazing!

          SIGN UP

Hi @vladyslav2,
So there are 2 approaches you can take here, the first is to put the a tag within a paragraph e.g:

    SIGN UP

If this doens't work for you then you can tell the editor that the a tag is a editable text element using the data-ce-tag attribute (http://getcontenttools.com/api/content-edit#tag-names), e.g:
SIGN UP


Configuring queryToCorrelationIdMapping for RequestCorrelationIdValve

With the PR https://github.com/wso2/product-is/pull/15400, queryToCorrelationIdMapping property of the RequestCorrelationIdValve can be configured.
Change the   queryToCorrelationIdMapping   in the <IS_HOME>/repository/conf/deployment.toml file to the value given
below.
[log_correlation]
query_config = "{'customQueryParam1':'Correlation-ID', 'customQueryParam2':'Second-Correlation-ID'}"

https://is.docs.wso2.com/en/latest/deploy/monitor/work-with-product-observability/#enable-observability
Related; https://github.com/wso2/product-is/issues/6695

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Add helper function to fetch constant buffer data for D3D12 debugging

I agree that these changes need to happen. I'm not sure yet what downstream changes would need to occur to support this properly. I was planning to do another pass on a lot of the root signature traversal logic after getting more shader debug changes PR'd.
I think for constant buffers, it'd be a relatively light change to support, if you'd prefer that I do that now. Though I anticipate a more holistic change that will need to happen similarly for SRVs, UAVs, etc.

Fair point that the SRVs/UAVs have a similar issue, I should have caught that in an earlier review which is my bad.
I think I'm OK merging this for now with a plan to fix later if that's how you want to do it, but it must be fixed before hooking up DebugVertex/Pixel/Thread as this would crash as soon as someone debugs a shader with a register index out of bounds.
I guess you could have a version check in those functions which bails out when it detects SM5.1, but I don't know how many people writing D3D12 code build for SM5.0 or lower when SM5.1 is a guaranteed minspec? Is a SM5.0 only debugger worthwhile?
Indeed there will need to be changes to the register lookups in the debugging code as well, especially to handle indirect access to resources (previously the resource indices were all always compile-time fixed).

Yes, there's plenty of work that still needs to happen before the UI can allow any D3D12 debugging. This is just another thing on the pile. :) Would you prefer that I create an issue to track it, or is that too specific for the issue tracker?
I don't see much benefit to handling SM5.0 differently, and in fact it may become a detriment if there are then RenderDoc bugs specific to a compiler version. And there's plenty to support with SM6.0+ that is far more deserving.

No need to make an issue for it, as long as you're aware of it and it gets fixed that's good enough for me.
About SM5.0, I don't mean treating it differently necessarily I just meant that with SM5.0 then because the shader is D3D11 compatible there are no register spaces, and SRV registers are limited to 128 and cbuffer registers limited to 14, so the code as it is would work without change. What I'm not sure of is whether "shader debugging, but only for SM5.0" is a worthwhile feature on its own or whether. If it were, there could be value in targetting SM5.0 debugging first as a useful feature and then subsequently incrementally expand to SM5.1 which we can more-or-less treat as a superset of SM5.0.
SM6.0 is a whole separate issue because of DXIL and is a complete & utter mess :(. Fortunately there's very little overlap so we don't have to worry about it with any of this stuff.


Build error DepthPacketProcessor is now internal

Hi
the project doesn't build anymore due to recent changes in libfreenect2.
I opened an libfreenect2 issue here: [https://github.com/OpenKinect/libfreenect2/issues/496]
The build error is
kinect2_bridge.cpp:393:5: error: incomplete type ‘libfreenect2::DepthPacketProcessor’ used in nested name specifier
     libfreenect2::DepthPacketProcessor::Config config;

I use ROS jade.

See #189.

Ok thanks

PR Merged.


Framework refactor

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[ ] Code compiles correctly.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #590 (79da20e) into main (1d038fa) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #590      +/-   ##
==========================================
+ Coverage   39.00%   39.06%   +0.06%
==========================================
  Files          86       86
  Lines        6674     6701      +27
==========================================
+ Hits         2603     2618      +15
- Misses       3698     3711      +13
+ Partials      373      372       -1

Flag
Coverage Δ

e2etests
?

unittests
39.06% <ø> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

client/daemon/peer/peertask_base.go
32.86% <0.00%> (-1.83%)
:arrow_down:

client/daemon/peer/peertask_file_callback.go
62.96% <0.00%> (ø)

client/daemon/peer/peertask_file.go
53.90% <0.00%> (+0.14%)
:arrow_up:

manager/permission/rbac/rbac.go
23.07% <0.00%> (+1.80%)
:arrow_up:

client/daemon/peer/peertask_stream.go
55.25% <0.00%> (+1.98%)
:arrow_up:

client/daemon/peer/peertask_stream_callback.go
64.55% <0.00%> (+2.53%)
:arrow_up:

pkg/util/stringutils/string_utils.go
85.00% <0.00%> (+5.00%)
:arrow_up:


Initial Mean response and Optimized mean response issue

Is there a way to convert the Initial Mean response from the budget allocator to match the original conversion values?

Please chack my calcs done on the last comment here: https://github.com/facebookexperimental/Robyn/issues/227

Hi, @Leonelsentana Thanks for the response.
The calculations you mentioned in that comment are for spend but I want the calculations for Initial mean response(conversions) to match to original conversions

So, this would be almost the same but changing to response instead of spend. Does that make sense? Taking the example from https://github.com/facebookexperimental/Robyn/issues/227 you would need to do:
[total_conversions (for certain channel) + ((optmResponseUnit - initResponseUnit) x non-zero spend time_units (non-zero spend weeks or days in your window), then divide by the total_conversions].

From my data:
Aggregated csv data:
channel 1:
Total_spend=1461776
Roi_total=0.0061
Total conversions_channel1=14617760.0061=5006.78
channel 2:
Total_spend=120793.77
roi_total=0.0034
Total_conversions_channel2=120793.770.0034=732.23
Total_conversions=5006.78+732.23=5739.01
Reallocated csv data:
optmresponseunit_channel1=45.71
initResponseUnit_channel1=44.63
(optmResponseUnit - initResponseUnit)_channel1=1.08
non-zero spend time_units(as of budget allocator) =51 weeks]
Based on the formula [total_conversions (for a given channel) + ((optmResponseUnit - initResponseUnit) x non-zero spend time_units (non-zero spend weeks or days in your window for that channel), then divide by the total_conversions]
=> (5006.78+(1.08*51))/5739.01 = 0.88 what does this value represent?
What I want is the original conversions for channel 1 which is around 10042

10042 is the total conversions for 51 weeks directly from the original data and the value without division is 5061.86 which is not matching

How is it that you know that total conversions for a specific channel should be 10042, if MMM works with total non-attributed values for conversions? Please have in mind that your original data should not use any kind of attributed data, rather total spend, clicks, impressions, etc.

Hi the original data has the total spend and total conversions for each channel split. So based on this we know that that specific channel should have 100042 conversions

Hi, is your original data the data you used as input to build the model? If so, this is not correct, marketing mix models are built based on TOTAL conversions and TOTAL spend. Please avoid using any type of attributed data as an input for the MMM models.

Hi @virithavanama , there's a similar issue about this point, please check it here

Hi Team,
In the demo its mentioned "dep_var_type = "revenue", # "revenue" (ROI) or "conversion" (CPA)"" so we have used conversions as per demo. We get daily data from channels like Google ads (paid search), google DCM(paid display), etc. So, we know the total conversions for each channel individually. Then the data is transformed into weekly data and passed to the model. I have attached the screenshot of the sample data that is being passed to the model.

Hi @virithavanama I presume that when you say "we know the total conversions for each channel individually" you are applying some sort of attribution logic there to indicate which conversions correspond to which channel, correct? MMM works in a different way by looking into the time series correlation of the total Impressions or total spend data points in time from each channel with the total conversions (not on a channel level, just business's total). Does that make sense? You are comparing attributed arbitrary data based on just a rule of clicks or impressions and time between those and the conversion, which does not imply the same methodology as MMM applies.

We are not applying any logic..the data directly comes from different channels like Google ads which are for paid search so we need the total conversions. There should be logic to convert the initial mean response to business conversions right?

The logic is the one I explained above, avoiding to divide by total_conversions https://github.com/facebookexperimental/Robyn/issues/477#issuecomment-1234002864. If you want the decomposition per day you can also get it directly from pareto_alldecomp_matrix. Each column will show each of the channels and other variables contributions to the explained Y (depVarHat)

Please reopen if this issue reoccurs.


Certificate error

Description
I have an invalid certificate error when trying to access the neurobagel website see image below

Relevant documentation pages
No response
Additional details
No response

Thanks @alexpron for the report! I believe this is an issue we've seen before where cloudflare's DNS proxy is preventing GH pages from renewing the SSL certificate for our domain. We can do our short-term fix of disabling proxy, and then we should have a real fix this time.
Also tracked here: https://status.neurobagel.org/incident/63

OK, the core issue is resolved again. I'd say we keep this issue open though to discuss a long-term solution. Ideally we'd want to not have to manually fix this next time

Without reading deeply, this appears to discuss the issue: https://gist.github.com/zbeekman/ac6eeb41ea7980f410959b13416d74c9

Closing as the website is accessible again and we have a temporary manual workaround for this issue. Will investigate a more automatic solution for certificate renewal in https://github.com/neurobagel/planning/issues/165.


[9.4-stable] Do not fail SealDiskKey if PCRs/eventlog can not be saved

Backport of https://github.com/lf-edge/eve/pull/3423, otherwise EVE might face vault unlock failure.

Is this already backported to 10.4 branch?

Is this already backported to 10.4 branch?
yes.


Include uri.lua license

nakama/util/uri.lua includes a link to the original source blob, but doesn't mention or include the project's MIT license.
The license should be included, perhaps adding that module to it's own folder, renaming it to init.lua and including their LICENSE.md file.
cc @britzl

Very good point @seanpackham !

perhaps adding that module to it's own folder, renaming it to init.lua

Why a separate folder and why renaming the file?
Would it not be enough to add the copyright notice and license to the file itself? This is the license from the original repo:

The MIT License (MIT)
Copyright (c) 2015-2021 Daurnimator
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
 IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

@britzl just adding it to the license should be perfect!

@seanpackham PR with change: https://github.com/heroiclabs/nakama-defold/pull/35


docker rm -f  fails if there are two containers mounting the same directory from the host filesystem.

Here is how you can reproduce this:
ps -aef | grep docker
root     27607     1  9 19:11 ?        00:00:12 /usr/bin/dockerd --storage-driver devicemapper --raw-logs
Please note that this was not an issue with an earlier version of docker 17.03 or 17.05
docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
ubuntu              14.04               d6ed29ffda6b        9 days ago          221MB
Create two containers of the standard ubuntu 14.04 image mounting / as /hostroot
docker run -d -t -v /:/hostroot ubuntu:14.04 /bin/bash
ad34fc70cef633645240a782e276d7fb0cc5691abd2eeb9e20cf3886995fbdb0
docker run -d -t -v /:/hostroot ubuntu:14.04 /bin/bash
a5e4ce128483382c882953a12a54e2bc156b09e7fd0cc49a21342bb8dec7b1b2
Remove the first container
docker rm -f ad
Error response from daemon: driver "devicemapper" failed to remove root filesystem for ad34fc70cef633645240a782e276d7fb0cc5691abd2eeb9e20cf3886995fbdb0: failed to remove device 089022c4968c61a02d8bd0b9c4a8f5224bcb5c6f433f177b5074e1ec92976dec: Device is Busy
Attached below, docker version and docker info
docker version
Client:
Version:      17.09.0-ce
API version:  1.32
Go version:   go1.8.3
Git commit:   afdb6d4
Built:        Tue Sep 26 22:42:38 2017
OS/Arch:      linux/amd64
Server:
Version:      17.09.0-ce
API version:  1.32 (minimum version 1.12)
Go version:   go1.8.3
Git commit:   afdb6d4
Built:        Tue Sep 26 22:41:20 2017
OS/Arch:      linux/amd64
Experimental: false
docker info
Containers: 2
Running: 1
Paused: 0
Stopped: 1
Images: 1
Server Version: 17.09.0-ce
Storage Driver: devicemapper
Pool Name: docker-252:0-644769-pool
Pool Blocksize: 65.54kB
Base Device Size: 10.74GB
Backing Filesystem: ext4
Data file: /dev/loop0
Metadata file: /dev/loop1
Data Space Used: 578.4MB
Data Space Total: 107.4GB
Data Space Available: 27.93GB
Metadata Space Used: 1.073MB
Metadata Space Total: 2.147GB
Metadata Space Available: 2.146GB
Thin Pool Minimum Free Space: 10.74GB
Udev Sync Supported: true
Deferred Removal Enabled: false
Deferred Deletion Enabled: false
Deferred Deleted Device Count: 0
Data loop file: /var/lib/docker/devicemapper/devicemapper/data
Metadata loop file: /var/lib/docker/devicemapper/devicemapper/metadata
Library Version: 1.02.77 (2012-10-15)
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
Volume: local
Network: bridge host macvlan null overlay
Log: awslogs fluentd gcplogs gelf journald json-file logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 06b9cb35161009dcb7123345749fef02f7cea8e0
runc version: 3f2f8b84a77f73d38244dd690525642a72156c64
init version: 949e6fa
Security Options:
apparmor
Kernel Version: 4.4.0-87-generic
Operating System: Ubuntu 14.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 15.67GiB
Name: anpartha-1404
ID: 3DAZ:EGCG:M3LY:VHGS:GFA3:YW3Y:HA7Z:YEMT:AVWE:IHD3:HS46:QARS
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Experimental: false
Insecure Registries:
<IP_ADDRESS>/8
Live Restore Enabled: false

Please file this in https://github.com/moby/moby.


elements_by_attr.c example: make print_collection_elements() static

this remove a warning (print_collection_elements() not previously
declared)

Thanks!


Click - exact element on click

I found common bug:
https://github.com/Simonwep/selection/issues/19
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
If user select by dragging - selections gets element from bbox (just touch).
Click behaviour doesn't work that way. You have to click exact element.
If the current behavior is a bug, please provide the steps to reproduce.
For example - unclosed circle. You have to click the line to set css class. But if you select by dragging rectangle it work's fine.
What is the expected behavior?
Click in Bbox of element triggers onSelect event.

Sorry, I'm a little bit confused, do you mean mode support for single-click? :suspect:

Nope, I mean - When you select by draggin, You have to just touch the element (it finds bbox of element).
When You single click - you have to click on exact line of it. When You click inside it doesn't work.

Okay, yeah - seems like the click event gets fired if the users clicks the drawed-area, not the boundings of it. So you mean that you need to click on the drawed area to select via single click, and only touch the bounding client rect if you use mousedrag?!
If so, this isn't really a bug IMO. Just a behavior of how clicking and dragging gets interpreted. Detecting the drawed area, or vice versa would be way to computation-intensive regarding many elements.

Indeed. So it's a feature :)

Honestly - IMO it should be fixed. It look like that dragging and clicking works different way.
Mode option should be for both way's. 'Touch' should work also for click.

If so, svg element e.g. paths would be also need to be taken into account since the click event get's only fired if the user actually clicked the path. So either the core would need to be rewritten, because obviously detecting the element, and calculating (for example) if the user touches a path which can be anything and extremely complicated.
So yeah, changing it so the mode behavior also applies to singleClick would be the easiest. But since we're going really into detail, the hover and every other css-based effects which would indicate something can be clicked would fail.
Example:

The red area could be clicked and selected (using mode: touch), but no hover-effects would be applied since the user actually doesn't hovered the element.
Moreover only the mode touch would make sence since you cant cover a element with your mouse and pressing exactly the center also makes no sence.

@bemiks I've added a tapMode option in 289a50b2cb9aedf582e2573f606440880775bc99 where you can use touch to get the same behavior as if you're making an area-selection :)
Other options may follow on request 😊


Added workflow for manual deployments

Context
Added new workflow which can be used to manual deployments
Changes proposed in this pull request
New workflow for manual deployments.
Guidance to review
The work will be used for review and qa this can be expanded for other environments.
Link to Trello card
https://trello.com/c/C1sBpxLz/1717-ittms-manual-deployment-workflow
Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated or added to the Azure KeyVault

Screenshots

 ittms manual deployment workflow


Code Review the FetchCommandSlice

Apply the changes that will be defined in the code review meeting for the Command Manager Slice
Acceptance criteria

Run command in queue

add a TestCommand to the queue
subscribe to TestCommand
start, pause, resume, stop the command
assert no errors
Run command in queue with listener

add a TestCommand in the queue

add a listener to the command
start, pause, resume, stop
assert listener should receive all updates

Run 3 commands of the same type in queue

add 3 TestCommand with the same type
assert just 1 command in queue

Check CommandManager repository - lastRun

add 1 TestCommand
wait until the queue stop
get repository lastrun1
assert lastrun1 is not null and is before now
add 1 TestCommand
wait until the queue stop
get repository lastrun2
assert lastrun2 is not null and is before now
assert lastrun2 is after lastrun1


[Feature request] Add wireless audio devices from JBL

Can you see the battery percentage in the settings(in Fedora it's under Power)?
If you don't you can try enabling the Bluez experimental features. You can find out how to do it Here
I've just enabled them and everything seems to work fine.

Here's a picture of my settings:

This extension only shows the same devices as upower -d. The cleanest way to add support for another device is through the upower project.


2016 INFORMATION UPDATE

The new data set implies that this process should also be used for 2016. The "Objeto del gasto" column from the data sets had it's name changed in every data set (from 2008-2016) to "ID_OBJETO_DEL_GASTO". These are the two changes I'm trying to reflect.

Hi @Victordeleon, which columns exactly did you rename to 'ID_OBJETO_DEL_GASTO'?
The change you made only changes the path to the catalogs (e.g. from data/objeto_del_gasto/concepto.csv to data/ID_OBJETO_DEL_GASTO/concepto.csv) which will only make the code fail (as the name of the directory did not change).
As a reminder, objeto-del-gasto.py is taking these columns:

ID_CONCEPTO
In order to generate these (not all of them in all years):
ID_CAPITULO
DESC_CAPITULO
ID_CONCEPTO
DESC_CONCEPTO
ID_PARTIDA_GENERICA
DESC_PARTIDA_GENERICA
ID_PARTIDA_ESPECIFICA
DESC_PARTIDA_ESPECIFICA


Updates to 1.16

Would it be possible to get this updated for 1.16? Alternatively, provide the steps used to generate the files and I will create a PR with the updates.

Yeah sure thing.  Let me make sure that the source data has also been updated, but assuming it has I'll get this rebuilt with the latest stuff soon.


Option for closing a realm

In some cases it would be nice to be able to close the realm instance by calling a close() or closeRealm() method on the RLMRealm instance.
E.g.: We are handling migration manually and sometimes we would have to close the DB for setting a new schema version. For now I have simply nilled the instance, but as the amount of data grows it seems it takes longer to close the db this way.

@lbanders relinquishing all strong references to the Realm will cause it to become "closed", but in general we don't recommend using the same path for multiple different realm files.

I'm closing this issue as it's a fundamental design decision driving how Realm works: RLMRealm instance lifecycles map directly to database connection lifecycles. This means that as much as possible, it's safe to access data in a Realm if you have an RLMRealm instance available.
Offering a close() method would then invalidate all other realms, and there may be some active transactions at that time in other threads, so behavior would then be very surprising since those realms could invalidate at any time, without warning.

That sounds fair :)
I have found a different way of dealing with this issues as the way I was dealing with upgrades at that time was kinda buggy.


GitLens features get trampled on by vim-induced muscle memory

GitLens is great! But I've been having this problem:
Several of its features, including the gutter blame and gutter heatmap features, are documented to have this behavior:

Press Escape to turn off the annotations.

I use the Vim extension for VS Code, and as a result, I hammer the Escape key constantly while editing code. It's muscle memory that's built up over many years, and I don't think I'll ever be able to get rid of it - when I want to be in normal mode, I really want to be in normal mode.
This means that I'm not able to keep the gutter blame and gutter heatmap features enabled - whenever I toggle them on, I inadvertently toggle them off seconds later. It's my own fault, but I can't stop doing it. Is there some way to get GitLens to work around my behavior?

@eamodio advised me that there is a way to get GitLens to work around my behavior!
There's a keybinding named gitlens.key.escape that can be configured to be something else besides escape; I've set it to cmd+shift+g E for now. This seems to have completely solved my problem. Thanks @eamodio!


coreutils: date doesn't respect TZ

$ /bin/date # system date command
Tue May  5 21:12:10 HKT 2015
$ ~/usr/bin/date # linuxbrew date command
Tue May  5 13:12:16 UTC 2015 # I don't know why but it's UTC
$ TZ="Aisa/Hong_Kong" ~/usr/bin/date
Tue May  5 13:12:30 Aisa 2015 # time is wrong (the value is still in UTC).

The TZ environment variable has a funny format. See http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
It's looking for the file
`brew --prefix glibc`/etc/localtime

which doesn't exist. Try instead export TZ=:/etc/localtime
$ date
Wed May  6 00:32:21 UTC 2015
$ TZ=PST8PDT date
Tue May  5 17:32:26 PDT 2015
$ TZ=:/etc/localtime date
Tue May  5 17:32:38 PDT 2015

The glibc postinstall should probably create a $(brew --prefix glibc)/etc/localtime file.

Even easier workaround:
ln -s /etc/localtime `brew --prefix glibc`/etc/

Fixed by c569aa8d12cb6566b70968fb5f82b1c272edecf6

Thanks for the bug report, Xu.


holdApplicationUntilProxyStarts not working

Is this the right place to submit this?

[X] This is not a security vulnerability or a crashing bug
[X] This is not a question about how to use Istio

Bug Description
After migrating to istio 1.21.2 we realized that holdApplicationUntilProxyStarts stopped working, Istio stopped adding postStart hook to istio-proxy container.
We're using Helm to deploy Istio and we use the following relevant config in values.yaml:
meshConfig:
      defaultConfig:
        holdApplicationUntilProxyStarts: true

This configuration works for Istio 1.20 but doesn't work with Istio 1.21
Version
1.21.2

Additional Information
No response

@howardjohn sorry for the ping, but I saw you changed injection-template in this PR which might be realted?

are you in nativeSidecar mode? otherwise I don't see how that would happen?

Nope, not in nativeSidecar mode, also, Istiod logs show that the meshconfig is correct and has         "holdApplicationUntilProxyStarts": true, this is indeed weird

@howardjohn FYI, setting global.proxy.holdApplicationUntilProxyStarts = true fixes the issue, it's apparently somehting with MeshConfig or ProxyConfig 🤔


go 1.17

Codecov Report

Merging #40 (9b4064f) into master (1a91587) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   89.84%   89.73%   -0.12%
==========================================
  Files         185      185
  Lines        6233     6233
==========================================
- Hits         5600     5593       -7
- Misses        378      383       +5
- Partials      255      257       +2

Impacted Files
Coverage Δ

gothic.go
70.58% <0.00%> (-8.83%)
:arrow_down:

core/host.go
85.39% <0.00%> (-4.50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a91587...9b4064f. Read the comment docs.


export chroot to docker/rkt

get chroot to work ..
add dockerfile to gzip it and push from chroot..  to docker hub... or lxc.. folders also..

You can use docker import and docker push to import a chroot filesystem as a docker image.

thanks for the tip ,


Fix unlock collateral function

Currently, the unlock collateral token function compiles, but gives a runtime error when the Wasm bytecode is run either on-chain or from within cosmwasm-vm. I am yet to figure out a good way to debug this function. I can tell that the error is on the LOCKED_COLLATERALS.update line, but not yet sure as to why this is erroring out.

Done


Feature/aggregatable-locator-publisher

Hi,
I have added the aggregatable publisher/locator which create the instances of publisher/locator for each available network adapter.
More specifically for the adapters, which supports multicast and if they are Ethernet or Wireless80211 adapter.
Also added tests and added Moq framework to the tests.
I again did nothing for WinRT/WindowsPhoneSL and UWP10
Please see these projects yourself, most likely just need to add links to files

Thanks again for your hard work here. I'm not sure when I'll have time to fully review and merge though sorry. Also there was some discussion on issue #43 that this wasn't really what people wanted. I have a branch started to try and do the multi-socket thing, but it stalled due to a lack of time and some design issues. I will have to review this in light of those conversations too.
Again, really appreciate the work though. Thanks!

No problem
I think this is a very useful thing, to be able to create several entities on different adapters, but to manage them as one.
At least that's what I'm doing :)
And if I add the http listener, we'll get some kind of upnp, only without restful control
What you think, may I add the code with the http listener, which will give a description of the devices to other devices in the network for even more convenient use of the library

In theory both plans give you the ability to host/listen/search on multiple adapters, it's just how it's done/managed that changes.
I'm happy for you to put a listener in your fork, but I don't want it as a PR. I can see the appeal, but I would like to keep the main project purely about the SSDP protocol and not add features outside of that. Especially something as complex as the HTTP server (yes it might seem simple now, but we'll get feature requests etc and over time it will grow... besides many people, like me, are using this with a self hosted web API or other solution and don't need an inbuilt web server).

Most likely you are right, perhaps it makes sense to not increase functionality (http server) of the library if it's only for the specific protocol

If you wanted to look after it, you could create a new repo and package that had the HTTP listener in it and used RSSDP as a dependency. Then people who just want RSSDP can use my package, and people who want a full service solution could use yours. Up to you. A good compromise if that's something you're keen on.

Hi again,
I created a repo with these functions and with the http server
And made dependence of this library
I don't know how I should keep the license, I just indicated your repository in the description
So I think this PR can be closed


Extend cert scope tables to include parameters

Now that formal parameters are a thing, we need to document them (documentation was the main reason to introduce the concept in the first place).

Well, not perfect, but it's a start?


[FLINK-36176] Remove support for Kafka 0.1

Warp up FLINK-19152 by also removing all related producer code.
Move FlinkKafkaProducerBase.getPropertiesFromBrokerList to a new test utility class as this method is used by some tests.

LGTM although I am slightly confused if users could have used the classes removed by this PR

It was originally used by the universal producer (FlinkKafkaProducer) and the FlinkKafkaProducer01(1). It was already refactored some years ago and only left in to be able to read the serialized state of that old producer.
The base class is annotated as @Internal. The FlinkKafkaProducer011 is not marked at all but the java doc clearly states that this is just for migration.
So I have a hard time to imagine anyone using this class and being surprised that it doesn't work anymore.


Assets/Advanced Playground/Gallery/Gallery.cs(8,26): error CS0246: The type or namespace name 'NFTs_OfAContract' could not be found (are you missing a using directive or an assembly reference?)

Hi,
After updating the package to 1.0.0 the following problems occurred.

[details]
Assets/Advanced Playground/Gallery/Gallery.cs(8,26): error CS0246: The type or namespace name 'NFTs_OfAContract' could not be found (are you missing a using directive or an assembly reference?)
Assets/Advanced Playground/Gallery/GalleryController.cs(104,12): error CS0246: The type or namespace name 'NFTs_OfAContract' could not be found (are you missing a using directive or an assembly reference?)
Assets/Advanced Playground/Gallery/Gallery.cs(16,22): error CS0246: The type or namespace name 'NFTs_OfAContract' could not be found (are you missing a using directive or an assembly reference?)

V1 onwards, NFTs_OfAContract has been renamed to NFTs_OfACollection and also functions have been combined to make it more unified across different chains and networks outside Ethereum.
Refactored:
        NFTs_OfACollection
            .Initialize(destroyAtEnd:true)
            .SetChain(NFTs_OfACollection.Chains.polygon)
            .SetParameters(
                    collection: "0x42b57de948d05d17fb11d4e527df80a0420a4392",
                    include: NFTs_OfACollection.Includes.all
                    )
            .OnError(error=>Debug.Log(error))
            .OnComplete(NFTs=> collectionNFTs = NFTs)
            .Run();

Refer docs >
https://docs.nftport.xyz/docs/nftport/ZG9jOjk0NjM3NjA1-nf-ts-of-a-collection

Metaverse template sample  is yet to be updated for V1.


Close emulators on VimLeave

This plugin should tidy up after itself and close emulators and shutdown all process on VimLeave

Not entirely sure how possible this is, or where I got the idea from


Angular 18 support

What problem does this feature solve?
I'm expecting ng-zorro to be up to date with the latest Angular 18 release.
What does the proposed API look like?
Update necessary dependencies and make a release that runs fine on Angular 18.

@jornare ng-zorro 18 will come soon：)

@jornare ng-zorro 18 will come soon：)

Looking forward to it :)

什么时候发布

+1

The problem that it throws an error when trying to install it on Angular 18 project, please consider using
@angular/cdk": ">=17.3.0"

to allow installing Angular 18 without errors
https://github.com/NG-ZORRO/ng-zorro-antd/blob/843b7035225df3d3a635a5ef8926d1e80f10ae18/package.json#L31-L36

+1

https://github.com/NG-ZORRO/ng-zorro-antd/pull/8564

#8564

We'll release a v18 beta version this week

Hey Everyone 👋
I'm glad to announce that 18.0.0-beta.0 is released ! 🎉
Welcom to upgrade and have a try.  We are looking forward to your feedback and  make it stable soon :)

@Laffery works fine with Angular 18!

It's working fine on my projects. Also, I'm using PNPM. Many many thanks!

I'm having trouble with using modals/popups that has a custom component using signal inputs. Just tested with 17, but I assume this also goes for the 18 release as I can't find any fixes in that regard.

I'm having trouble with using modals/popups that has a custom component using signal inputs. Just tested with 17, but I assume this also goes for the 18 release as I can't find any fixes in that regard.

hi @jornare, would you like provide a reproduction link to help us troubleshoot the problem?

I'm having trouble with using modals/popups that has a custom component using signal inputs. Just tested with 17, but I assume this also goes for the 18 release as I can't find any fixes in that regard.

hi @jornare, would you like provide a reproduction link to help us troubleshoot the problem?

https://stackblitz.com/edit/angular-kjryqu?file=src%2Fapp%2Fapp.component.ts

Hello! I have different style in angular 17:

and angular 18:

for NzTabsModule (nz-table) component. It's ok?

@jornare ng-zorro 18 will come soon：)

could you provide an estimated delivery date please ?   "soon" is a bit vague and we are blocked from upgrading to angular 18 at the moment.

@jornare ng-zorro 18 will come soon：)

could you provide an estimated delivery date please ? "soon" is a bit vague and we are blocked from upgrading to angular 18 at the moment.

I recommend updating to the beta and posting any issues you have here

Hello! I have different style in angular 18:
and angular 17:
for NzTableComponent (nz-table) component. It's ok?

The same problem with Angular 17

Exactly, thanks. How to fix, who knows?

Close via #8568.

Hello! I have different style in angular 18:
and angular 17:
for NzTableComponent (nz-table) component. It's ok?

The same problem with Angular 17

Add NzTableModule to imports:
@Component({
  imports: [ NzTableModule ],
  selector: 'app-demo',
  standalone: true,
  styles: ``,
  template: ``
})
export class DemoComponent {}

Is v18 support zoneless?


Create package for Apt

@lakruzz I have discovered that there is a version of brew for linux, so we can potentially look into that if as well


Run jattach without sudo

Hi,
I have embedded jattach into my go script. When I run my go script from host to capture GC log, thread dump, and heap dump from the java application running inside the Docker container I get Failed to change credentials to match the target process: Operation not permitted error message. But if I run my go script with sudo it works fine.
I am using a service account. Can you help me with figuring out what priviledges are required to access the monitoring information rather than using sudo?
Thanks :)

To attach to a running JVM, a user must have exactly the same effective uid/gid as the target process. This is a limitation of the JVM, not of jattach.
If credentials do not match, jattach automatically tries to change them with seteuid / setegid calls. This is allowed to a privileged account only - typically root, or, more precisely, an account with CAP_SETUID and CAP_SETGID capabilities.

To attach to a running JVM, a user must have exactly the same effective uid/gid as the target process. This is a limitation of the JVM, not of jattach.

So you meant to say uid/gid of the user who is running java process inside a container and the user who is executing jattach from the host should match. Am I right?

uid/gid of the user who is running the java process inside a container and the user who is executing jattach from the host should match. Am I right?

Yes

Thank you @apangin. I am closing this issue for now.


build: add grpc-js system-test to continuous

Closes #403

@jkwlui Could you please remind why we want to have this test as part of cloud-profiler-nodejs? This repo does not use gRPC.

@aalexand We are aware that cloud-profiler-nodejs doesn't use gRPC. But we've decided to keep the configs here so that it makes our CI config consistent across Node.js repositories in googleapis.


[OSD-17428] etcd health check oneliner

This provides one-liner osdctl etcd health check command:
$ osdctl cluster etcd-health-check
Sample Output covering

Master node status
Etcd pod running status
Etcd member's health from etcd CR status field
Output of script

/lgtm
/approve


[Bug]: Unable to add custom spans with layer arm64 > 96 and x86 > 213

Problem Description
When using the newest versions of the Instana Layer in Nodejs with AutoTrace (wrapping the handler), the auto instrumentation part works fine, but trying to access the current span or adding intermediate spans fails (they are null and intermediate spans are not send to Instana).
After creating a Lambda Function with autoTrace and a function URL using the code blow, when executing the Lambda, we can see the following in the logs:
  | 2024-11-18T15:35:33.933Z | INIT_START Runtime Version: nodejs:20.v43 Runtime Version ARN: arn:aws:lambda:eu-central-1::runtime:4a87b8fceb008240eb9bfe7dc3126c2dec6fe75f06c6a4d8977d0267eb5da2bd
  | 2024-11-18T15:35:34.169Z | 2024-11-18T15:35:34.169Z undefined INFO @instana/aws-lambda module version: 3.21.0
  | 2024-11-18T15:35:34.693Z | 2024-11-18T15:35:34.693Z undefined INFO @instana/aws-lambda module version: 4.0.1
  | 2024-11-18T15:35:34.843Z | 2024-11-18T15:35:34.843Z undefined INFO Method warn of [object console] was already wrapped. Unwrapping.
  | 2024-11-18T15:35:34.844Z | 2024-11-18T15:35:34.844Z undefined INFO Method error of [object console] was already wrapped. Unwrapping.
  | 2024-11-18T15:35:34.869Z | EXTENSION Name: instana-lambda-extension State: Ready Events: [INVOKE, SHUTDOWN]

It looks like the original handler is wrapped in version 3.21.0, while 4.0.1 is used when requiring the package in the code.
Short, Self Contained Example
Lambda code:
const instana = require('@instana/aws-lambda');

exports.handler = async (event, context) => {
    const span = instana.currentSpan();
    const response = {
        statusCode: 200,
        body: JSON.stringify({
            currentSpanId: span ? span.getSpanId() : null,
        }),
    };
    return response;
};

Node.js Version
Lambda nodejs20.x
package.json
-

package-lock.json
-

Hi @janritter Thanks for your report! We will take a look asap!

Hi @janritter
The fix has been successfully released in v4.1.0.
You can now use the following latest layer versions for ARM64 and x86_64 in the region eu-central-1:

x86_64: Layer version 218
ARM64: Layer version 99

Please let us know if you are still encountering any problems.

@aryamohanan thanks for the quick release, I can confirm that it now works on our end


Sensitive argument masking in Data Prepper log format.

Is your feature request related to a problem? Please describe.
We want to provide the ability to mask sensitive data based off markers used in log event. e.g.
LOG.error(SENSITIVE, "log message with anchor: {}", "sensitive data");
will be logged as
log message with anchor: ******

Describe the solution you'd like
We will implement a SensitiveArgumentMaskingConverter in package org.opensearch.dataprepper.logging that extends LogEventPatternConverter in formatting the log message string and applies to the convertKey called mask:
@Plugin(name = "sensitiveArgumentMaskingConverter", category = PatternConverter.CATEGORY)
@ConverterKeys({"mask"})
public class SensitiveArgumentMaskingConverter extends LogEventPatternConverter

Then in the log4j2.xml, one can apply masking through including org.opensearch.dataprepper.logging into configuration package and apply %mask. e.g.:
<?xml version="1.0" encoding="UTF-8"?>
<Configuration packages="org.opensearch.dataprepper.logging">
    <Appenders>
        <Console name="Console" target="SYSTEM_OUT">
            <PatternLayout pattern="%d{ISO8601} [%t] %-5p %40C - %mask%n"/>
        </Console>
    </Appenders>
    <Loggers>
        <Root level="info">
            <AppenderRef ref="Console"/>
        </Root>
    </Loggers>
</Configuration>

Describe alternatives you've considered (Optional)

hard removal of sensitive argument. This has the downside of non-user friendly in debugging.
repeat the same log event with independent marker. e.g.

LOG.error(SENSITIVE, "log message: {}", "sensitive data");
LOG.error(NON_SENSITIVE, "log message.");

while this gives user the option to apply marker, it might not persist well for future development efforts as developer needs to repeat every potentially sensitive log message twice.
Additional context
Add any other context or screenshots about the feature request here.

Completed by #2188


cmake_path is new in cmake 3.20 and not available in Ubuntu 20.04

Hi,
building failed in cmakelists.txt on line 12. The reason was that cmake_path is new in cmake 3.20 and not available in Ubuntu 20.04. The build succeeded when I updated cmake using the ppa repo of cmake.
Best,
Jan

Fixed in commit 8f7508


[Security]: 1 High severity vulnerability found

Steps

Clone the project.

Run npm install

Run npm audit

Expected
Safe dependencies
Current

Hi @alamenai thanks for your contribution.
As i see this vulnerability comes from ladash since the version that we have is an old one, so it just need an update.


adds DDL storage options documentation

Codecov Report

Merging #6583 into ddl-storage-options will increase coverage by 0.12%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             ddl-storage-options    #6583      +/-   ##
=========================================================
+ Coverage                  82.95%   83.08%   +0.12%
- Complexity                 13237    13244       +7
=========================================================
  Files                       1517     1517
  Lines                      49200    49200
  Branches                    5921     5921
=========================================================
+ Hits                       40814    40876      +62
+ Misses                      5591     5534      -57
+ Partials                    2795     2790       -5

Impacted Files
Coverage Δ
Complexity Δ

...exceptions/GroupByOnArrayUnsupportedException.java
66.66% <0%> (-33.34%)
1% <0%> (-1%)

...a/io/crate/executor/transport/ActionListeners.java
33.33% <0%> (-22.23%)
2% <0%> (-1%)

core/src/main/java/io/crate/types/ByteType.java
84% <0%> (-12%)
16% <0%> (-3%)

...io/crate/protocols/postgres/types/VarCharType.java
91.66% <0%> (-8.34%)
10% <0%> (-1%)

...tor/transport/distributed/ModuloBucketBuilder.java
73.68% <0%> (-5.27%)
10% <0%> (-1%)

...otocols/postgres/RetryOnFailureResultReceiver.java
88.46% <0%> (-3.85%)
10% <0%> (-1%)

.../src/main/java/io/crate/blob/RemoteDigestBlob.java
78.57% <0%> (-1.79%)
8% <0%> (ø)

...main/java/io/crate/blob/v2/BlobIndicesService.java
72.22% <0%> (-1.39%)
22% <0%> (ø)

...te/operation/scalar/cast/CastFunctionResolver.java
97.4% <0%> (+1.29%)
11% <0%> (+1%)
:arrow_up:

sql/src/main/java/io/crate/action/sql/Session.java
87.58% <0%> (+1.37%)
31% <0%> (+1%)
:arrow_up:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd82061...406972b. Read the comment docs.


TST: Remove ncf hack for cases_test_moments

This passes locally, testing on CI
This was probably fixed by https://github.com/scipy/scipy/pull/11849
Other patch that was closed: https://github.com/scipy/scipy/pull/11768

This unused to fail locally and in azure, now it appears to pass locally but seems to still be broke on Azure. I'm backing out half the change if that fails I'll close the PR.

@sethtroisi, the Azure Windows tests are failing in all PRs at the moment.  If you see a failure in your PR, check the details to be sure it is caused by your change.

@WarrenWeckesser I noticed that the windows tests are failing to build. There was also a linux config that failed on the affected test

This is still broken in Azure, not sure why it passes locally. Sorry for the added noises


Missing license agreement

What kind of license agreements does this project have?

This is MIT licensed. Check the license here


Override webpack config

How to override webpack config with universal-cli? I just want to add a module loader.
Anyone can help?

@phatpham9 in the next release it will be possible. Or if you clone the repo and use a local version of the universal-cli. After ng init --universal there is a webpack.client.ts and a webpack.server.ts. But it is the first version! :-)

@devCrossNet  When will be the next release?

@phatpham9 you can just clone the repo yourself and use npm link to use your local version of the cli instead the one from npm.

@phatpham9 new version is now available at npm. Can I close this issue?

@devCrossNet thank you so much. Just the last question. Where can I find the default webpack config for universal?

Forget the above question please I've successfully overridden the webpack config for my project. Many thanks.


Skate and charm/kv duplicate code

Skate and the charm kv command are currently nearly copy and paste clones of each other. This makes it hard to keep them in sync and is generally not a great idea. We should make a module that has all of the Cobra CLI code in one place and use it for both skate and charm kv. It probably makes sense to have that be a submodule of Skate that gets imported in the main.go for Skate and Charm.

I've taken a crack at implementing these changes.  As it currently stands both commands aren't 100%  identical, specifically the list-db and delete-db sub-commands are not available for charm kv.
If we wish to keep it that way I can break the module out into just the overlapping sub commands and include the db sub commands in skate only.
Otherwise the changes (in charm) would then include the addition of list-db and delete-db.
Not sure if this issue is the appropriate place to have these discussions. I can also put up a draft PR to showcase the changes in code if required, it's ready @toby


ci: changed all uses of local branches to main

Description

With this PR all workflows / actions now run the CI files from the main branch. This seems to be the best practice to keep all CI activities in sync with main. It also ensures that the main branch is stable, since the checks are run against the main version – meaning that if those pass, main should not be crashed when merging PR branches.
This usage of CI running against main is already present in the steps of  package,  deploy-to-dev-cluster, deploy-docs etc.
Changelog

changed ci.yml

What happens if they're changed in a PR? We wouldn't know if they work since GitHub will be using the actions from the main branch, right?

What happens if they're changed in a PR? We wouldn't know if they work since GitHub will be using the actions from the main branch, right?

By default, yes.
The idea here is to purposefully change the reference from main to dev_branch when modifying the CI.
Then, you can check if your CI changes work as expected in your dev_branch.
Before merging into main the reference must be reset.

What happens if they're changed in a PR? We wouldn't know if they work since GitHub will be using the actions from the main branch, right?

By default, yes. The idea here is to purposefully change the reference from main to dev_branch when modifying the CI. Then, you can check if your CI changes work as expected in your dev_branch.
Before merging into main the reference must be reset.

But isn't that prone to errors?

What happens if they're changed in a PR? We wouldn't know if they work since GitHub will be using the actions from the main branch, right?

By default, yes. The idea here is to purposefully change the reference from main to dev_branch when modifying the CI. Then, you can check if your CI changes work as expected in your dev_branch.
Before merging into main the reference must be reset.

But isn't that prone to errors?

Could be.
Nonetheless, we should standardize our methodology. Either by always testing against main or always using the local branch. Not a mix of both.
We can talk in the daily about that and accept a final conclusion.

What happens if they're changed in a PR? We wouldn't know if they work since GitHub will be using the actions from the main branch, right?

By default, yes. The idea here is to purposefully change the reference from main to dev_branch when modifying the CI. Then, you can check if your CI changes work as expected in your dev_branch.
Before merging into main the reference must be reset.

But isn't that prone to errors?

Could be.
Nonetheless, we should standardize our methodology. Either by always testing against main or always using the local branch. Not a mix of both.
We can talk in the daily about that and accept a final conclusion.

Talked it through in our daily. For now, we concluded to use the local version. Therefore the PR is updated.


Faster data processing

Hi,
The proposed pull request modify the SemKITTI2train_single function. It increases the overall training speed by more than 20%. Instead of finding labels equals to 0 and then setting their value at 255 and decreasing the other values by 1 it simply decreases the value of every label by 1 : as they are encoded as unsigned int on 8 bits this is equivalent but much faster.
I also modified the training procedure so that the first error is printed : this is to help detect out of memory errors.
I added the torch.no_grad() context around the test part in test_pretrain.py.
I corrected some typos in requirements.txt file (however I wasn't able to install torch-scatter with CUDA support using only pip install -r requirements.txt, maybe the README.md file should contain a more precise installation procedure.
I hope you'll find this suggestion useful.
Best,
Marius

Thanks for your contribution!


[Request] Page 232 "Apply Customer Entries" - Move variables

Move the variables var:

ApplnRounding: Decimal
VATAmount: Decimal;
VATAmountText: Text[30];
ProfitLCY: Decimal;
ProfitPct: Decimal;
ApplnDate: Date;
ApplnType: Option " ","Applies-to Doc. No.","Applies-to ID";
CalcType: Option Direct,GenJnlLine,SalesHeader,ServHeader;

To "protected var" to allow to retrieve them in an extension page.

All these variables already in protected var section in 18.x

All these variables already in protected var section in 18.x


[rewrite: test] Add tests for iframe usage

Description:
Add test for projects using iframe with mithril (same domain)
I have a project using this feature, when inspect into rewrite, I found it's lack the tests for iframe.
Steps to Reproduce:
Render from main into iframe
var doc = frame.contentDocument || frame.contentWindow.document
m.render(doc.body, m(Component) )

Or reversely, render from iframe into main
var doc = window.parent.document
m.render(doc.getElementById('container'), m(Component) )

Expected:
Should add tests for the above situation
Actual:
Not found tests for the above situation

Because of #1390, the rewrite will not handle vdom created in a different realm (i.e. across iframe boundaries).

This is now unblocked. What tests do you suggest @futurist?

@barneycarroll As far as I can see, the test-utils should add iframe or frameset mocks, or maybe add some real browser cases.

@futurist If you do go that route, you'll need to privately brand the (IIRC) created elements with the proper document so you can do the proper security checks throughout the mocks.

Closing, since this issue has not been updated in over a month, and typically, issues inactive for that long do not usually produce any action. If you feel something in Mithril needs added or changed, please file a new issue.


Update Simple Icons To Latest Versions Using Actions

Closes #4
This PR adds a GitHub Action to create the latest release every week from the main simple icons repo.

The API endpoint for simple icons releases doesn't seem to include assets. https://api.github.com/repos/simple-icons/simple-icons/releases/latest Going to just download a zip of the master branch instead.

The API endpoint for simple icons releases doesn't seem to include assets. https://api.github.com/repos/simple-icons/simple-icons/releases/latest Going to just download a zip of the master branch instead.

You can download by version from tags using the url https://github.com/simple-icons/simple-icons/archive/refs/tags/{version}.zip or you can get the tarball and zipball urls from the endpoint that you've provided querying tarball_url and zipball_url fields.

@mondeja  That's a much better approach, thanks! 🎉
Do you have any experience with permission errors when running Python scripts in actions? I've been unable to figure out how to give it permission to add, edit, and delete files. I've opened a discussion here with more details and logs.

@mondeja That's a much better approach, thanks! 🎉 Do you have any experience with permission errors when running Python scripts in actions? I've been unable to figure out how to give it permission to add, edit, and delete files. I've opened a discussion here with more details and logs.

Try os.chmod(file, stat.S_IWRITE)

@mondeja The permissions error ended up being because I was running the script from the wrong directory using python script/main.py. Since the script navigates between the folders using os.getcwd() it wasn't able to replace the script from the path and was trying to delete/edit/create files that didn't exist.
This should be ready to go. I've removed the on push trigger leaving just the cron and dispatch so there aren't any releases currently published. If there's nothing special that needs to be done as far as simple-icons, I'll merge and run it manually for this release just to make sure it works right on main. Thank you for your help!

Ups, seems that the directory is script/, not scripts/ 😅

All good. Btw the PR you linked is on Blazor, but this one is for Stream Deck.
Release successfully created: https://github.com/mackenly/simple-icons-stream-deck/releases


Fix water conservation check

Purpose

Addressed in #436

[ ] I have read and checked the items on the review checklist.

Addressed in #436


Swift 4 migration

Issue: Link
Short description
Migrate the project to Swift 4
Solution
Build the project with Xcode 9, fix all warnings and errors and update SPM manifest syntax.
Implementation

[x] Update Package.swift file. Please, check versions of dependencies. In my opinion, it's good practice to update dependencies to next major version.
[x] Fix new syntax errors in sorted(by:) and NSTextCheckingResult.range(at:) functions.

GIF

@artemnovichkov do you have access to create branches on this repo?

One important remark: is it correct format of Package.swift? I saw this manifest and I'm not sure my version is correct. What do you think?

It is @artemnovichkov. Once travis passes we can merge it 😛

You may to define products to be able to consume this framework. If you leave them out, I'm not sure if they are auto generated

@pepibumur I'm not sure, I forked the repo.

.swift-version will need to be updated as well. Travis will probably fail without it

Yep, the bash script used to install swift uses .swift-version to determine which version needs to be installed.

@pepibumur have you checked CI errors?
We don't have build instructions for 4.0.
I guess swiftenv doesn't support Swift 4.

It looks like it only has 4.0-dev link. Can you try that one?

I should update .swift-version file, right?

Yes @artemnovichkov, and just use 4.0-dev.

Another thing that we can do is remove the swiftenv step and use the version that comes with Xcode 9. That should also work. By doing that, the execution should be faster on CI.

I have integrated buddybuild to my open-source project recently, and everything works w/o swiftenv

Then let's try that. Just remove the line from .travis.yml that installs Swift. That should work.

I think we need to update also the Tests folder structure @artemnovichkov

@pepibumur I did it!

Bum! Ready to merge. Nice job @artemnovichkov


Drew to take Incident Response Training within 60 days of joining the team

Complete by 9/17
One remaining item from #2076

Completed today (9/12/22) with @Chiakao


added: CoinChangePer.py[ Coin Changer Permutation]

congratulations on your hactoberfest contribution. if you like this repo then give it a star.Follow for updates. Happy hacking..


How to open .slnf files with Visual Studio under macOS?

I didn't find a way to open .slnf files with VS under macOS. Double click results in open the .slnf file as plain text in Visual Studio.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 108b5373-83a5-8d82-0414-939b0caf2866
Version Independent ID: 9bb010ce-5641-c2a4-ce2a-d53943ac5432
Content: Load a subset of projects - Visual Studio
Content Source: docs/ide/filtered-solutions.md
Product: visual-studio-dev16
Technology: vs-ide-general
GitHub Login: @jillre
Microsoft Alias: stsu

@stanimiryakimov -- Stanimir, thank you for your feedback. It looks like you're having an issue with the product itself, rather than an issue with the documentation. Here are a few options  you might consider:

https://social.msdn.microsoft.com/Forums/vstudio
https://www.stackoverflow.com
https://www.reddit.com/r/VisualStudio/

You are also welcome to use the Report a Problem tool to report the issue.
cc @jillre for awareness
I am closing this issue now.  You are welcome to @ mention me for any followup.
We hope to hear from you again.