FP8 training causes OOM

When FP8 is utilized model that is loaded in fp16 (llama) OOMs during training.
Model works perfectly in fp16 mode.
My guess is that autocast of model to TE layers changes dtype to float32.

In this code new TransfomerEngine Linear module is created but original weights are cloned and new module has param_dtype=torch.float32. It causes OOM when model is casted.
https://github.com/huggingface/accelerate/blob/dcde1e93d09abea02a8e7f4a07a2c5734b87b60e/src/accelerate/utils/transformer_engine.py#L31-L41C19

Indeed, the linear layer needs to be created with the same dtype as the original one. Would you like to suggest a PR with a fix?

Honestly, I lack knowledge to fix it myself and it still uses the same amount of memory.

@sgugger  I would like to work on this PR. I am new to open source contribution, so if I you can guide me on how to work on this PR, I would like to take it up.

I've tried remove old tensors and avoiding to create new tensors inside of Transfomer Engine (skip_weight_param_allocation), but may be some extra tensors are created inside of transformer engine. Not sure whether it causes OOM or I miss some tensors that should be cleaned.

I was just planning to add this to the existing code because we just want to r

etain the datatype

After this LLaMA still OOMs during loading. Probably the problem is deeper and I'm not sure now what causes it.

Yes, you are right, the parameter is params_dtype (i just wanted to show the idea in the snippet). The OOM error might be due to other causes as you said, the above change is to fix the problem that converted layer should have same dtype as original. @sgugger  kindly advise if I should create a PR for this change.

Yes, you can definitely open a PR with this fix.

added PR #1467.

Still the issue is not resolved. It simply will create tensors in fp16 and replace them with model's ones.

@overvalidated It is FP8 mixed precision training. The actual memory usage will be higher than in regular training since you ahve two copies of the model. One in FP8 and one in FP32 (or lower precision but that wouldn't really work for training).

But how fp16 training works then? Shouldn't it cause OOM either?

@overvalidated I have no code I can reproduce so I can't really explain what goes wrong for you.

Hi all, we finally narrowed down the two sources of leakage in the implementation that we could improve. #2089 will fix this, reducing your memory by a significant amount.
For example, loading in "meta-llama/Llama-2-7b-hf" in FP8 was near 38gb before, now it is only 12.61 GB (compared to 12.61 GB in bf16 where the weights were originally loaded)


Custom VLR Registration Bug

Issue : #39

Description
This is to correct the issue reported in #39 where registration of custom VLR data types wasn't working when those types and registrations were done in another module.
This seems to be due to how Julia scopes code, where (AFAIK) if you have Pkg A exporting a value (like a dict) and Pkg B uses Pkg A and modifies that value, any functions within Pkg A that rely on that value won't be updated with the new value since Pkg A and Pkg B have different scopes.
The solution I'm proposing here isn't ideal, but it avoids having to hard code a mapping of user/record ID combinations and find a way to modify them from upstream sources. Basically, we now use multi-dispatch on each combination of (user_id, record_id). This creates alot of method instances which may not be great when trying to serialise, so potentially will need to look into this further.
Types of Changes

Bug fix (non-breaking change which fixes an issue)
Configuration change

Review
List of tasks the reviewer must do to review the PR

[ ] Tests
[ ] Documentation
[ ] CHANGELOG

I've updated the approach now to avoid using excessive multi-dispatch by instead checking all registered methods (in the global scope) of the functions LASDatasets.official_user_ids and LASDatasets.official_record_ids.
This has the benefit that
a) we don't need to have hundreds of methods for a single function (yay)
b) if we register more types upstream then our system should still pick up on it as the code to grab methods is executed in the global scope


[Tabs]: Scrolling tabs when page is RTL, not working

When page layout is RTL, using scrollable tabs, doesn't scroll.

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Clicking on the scroll button does nothing

Expected Behavior 🤔
Scroll tabs and display hidden tabs

Steps to Reproduce 🕹

Steps:

Create a new project and set the body + theme to RTL.
Add Scrollable tabs to the page
Create a number of tabs that will exceed the width of the tabs container
Click on the scroll button.

I think the bug is @material-ui/core/esm/utils/scrollLeft.js. on line 48 there is this if statement
if (dummy.scrollLeft === 0) {.  But dummy.scrollLeft is 0.8....

Setting it to 0 (in debug mode),  fixes the problem. I didn't get to much in to the code so I don't want to create a PR of my own.
Context 🔦

Your Environment 🌎

`npx @material-ui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @material-ui/envinfo` goes here.

It doesn't look like this bug report has enough info for one of us to reproduce it.
Please provide a CodeSandbox (https://material-ui.com/r/issue-template-next), a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

Closing since no reproduction was provided within 14 days.


Hot exit not working in Notebooks

VSCode Version:
OS Version:

Steps to Reproduce:

Install Jupyter extension
Ensure auto save is tuned off
Open a notebook
Make changes to a cell
Reload VS Code
The changes are lost

The Jupyter extension is handling the call to backupNotebook & is returning the id of the back.
However when openNotebook is invoked by VS Code, the backupid in the NotebookDocumentOpenContext is empty.
FYI - this used to work. Has the API changed in VS Code (should we be using NotebookDocumentBackupContext in the backupNotebook method, this is ignored today).

Does this issue occur when all extensions are disabled?: Yes

Not aware of any change with the back api. Will take a look

Not aware of any change with the back api. Will take a look

Can't reproduce this issue with GitHub Issue Notebook. @DonJayamanne can you share what version of VS Code you are using, on what OS? If you are using OSS, then it will not work as designed.

Can't reproduce this issue with GitHub Issue Notebook. @DonJayamanne can you share what version of VS Code you are using, on what OS? If you are using OSS, then it will not work as designed.

Setup & Debug the Jupyter extension
Set breakpoint in openNotebook of https://github.com/microsoft/vscode-jupyter/blob/b368ea9326c13d6497e0f070d89d810d4ff86416/src/client/datascience/notebook/contentProvider.ts
Set break point in same file in backupNotebook
Open an existing notebook
Make changes (edit a cell)
Confirm backupNotebook method is invoked & backup id is returned.
Reload VS Code
Confirm openNotebook is invoked and notice how backupId is empty.

VS Code version is
Version: 1.53.0-insider
Commit: ed72c64b87ede96fb51bc16870f9d2ecbf4fcc57
Date: 2021-01-22T17:17:02.999Z

Setup & Debug the Jupyter extension
Set breakpoint in openNotebook of https://github.com/microsoft/vscode-jupyter/blob/b368ea9326c13d6497e0f070d89d810d4ff86416/src/client/datascience/notebook/contentProvider.ts
Set break point in same file in backupNotebook
Open an existing notebook
Make changes (edit a cell)
Confirm backupNotebook method is invoked & backup id is returned.
Reload VS Code
Confirm openNotebook is invoked and notice how backupId is empty.

VS Code version is
Version: 1.53.0-insider
Commit: ed72c64b87ede96fb51bc16870f9d2ecbf4fcc57
Date: 2021-01-22T17:17:02.999Z

Just saw the GitHub issues code, looks like in there you're writing to the file provided. Hmm, we always backup to our own file & return a backupid.
Interesting how this works, we never did write to that.

Just saw the GitHub issues code, looks like in there you're writing to the file provided. Hmm, we always backup to our own file & return a backupid.
Interesting how this works, we never did write to that.

I guess we need to use the same mechanism.

Lets discuss this in person. We didn't do this in the past, same goes with CustomEditor support.
We backup to our own file & return our own backupId.
Looks like something changed in VS Code that prevents this from working with our own backupid. I.e. we're now forced to use the VSC file.

I guess we need to use the same mechanism.

Lets discuss this in person. We didn't do this in the past, same goes with CustomEditor support.
We backup to our own file & return our own backupId.
Looks like something changed in VS Code that prevents this from working with our own backupid. I.e. we're now forced to use the VSC file.

Same problem for me on v1.52.1.

Same problem for me on v1.52.1.

@rebornix thanks for your help, confirmed this works but not when debugging.

@rebornix thanks for your help, confirmed this works but not when debugging.


Cypress 3.4.1: Fix files used for verification.

Motivation for this change
Cypress 3.4.1 fails to run giving verification errors.
To reproduce:

Install cypress from nixpkgs --> gets version 3.4.1
In project package directory, install cypress with CYPRESS_INSTALL_BINARY=0 npm install<EMAIL_ADDRESS>run CYPRESS_RUN_BINARY=`which Cypress` $(npm bin)/cypress open

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build cypress

This seems to work fine :+1: . Can you update to 3.5.0?

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/72

@GrahamcOfBorg build cypress

Thank you very much for your time. :+1:


{wip} RFC 1: mp design philisophy to be dependent on model

{wip} RFC 1: mp design philisophy to be dependent on model
Summary:
Test Plan:

closing for now. Stay tuned for v2 😊


Google Fonts Text subsetting

Hey, so I'm referring specifically to the Text parameter in https://github.com/typekit/webfontloader#google.
I noticed that it is being added separate from the families. I was wondering if it would be worth it to have a way to attach it right to the families themselves.
The use-case is as follows:
Let's say I have a select field (let's say I'm using something like Select2 to display the actual list) and it is displaying a list of Google fonts.
I'd love to be able to use the webfont.js api to load all these fonts, but only the characters of each font's labels.
This way you get a nice select field with each item using it's own font. A nice user experience in my opinion.
But ya, long story short, I don't see a way to use the Webfontloader for this at the moment.

You know I'd actually consider tackling this problem myself if it's something others agree should be changed... I need the FontApiUrlBuilder.prototype.build that probably just needs some adjustments.

If that text parameter is an array, perhaps map it to the same index's font family from the families parameter?

Yeah I agree. Here's another use case:

Font 1 = for title title text
Font 2 = for rest of body text

I imagine we would see a load improvement if we were to load Font 1 with just the needed text, and not the whole subset.


Prevent any access from VS Code to a certain set of folders

I'm developing a Meteor.js application. In the last week, I've been experiencing multiple errors (randomly: ENOTEMPTY, EPERM, EBUSY) during the building process of the app while Visual Code open.
The .meteor folder is included to the files.exclude; this is to prevent visual code to scan the files created by meteor during the building process (which would slow down the build process). But this does not seems to work as the code.exe process spikes up during the building process.
I'm suspecting Visual Code scans the files that Meteor creates and manipulates which triggers the errors.
There are no error when Visual Code is closed.
My understanding is if a folder is marked as to be excluded (files.exclude), then Visual Code should not try to access those files. Please, correct me if I'm wrong.
Issue also referenced:
#https://github.com/meteor/meteor/issues/8801

Any help would be appreciated.

@bouchepat there is still a file watcher running that might access those files when they change, there is currently no way to prevent this.

I'm currently experiencing the same issues, i often have to close vscode when (re) starting meteor to get it running without issues. When its once running, vscode can stay open until meteor has to rebuild (refreshes work).
Didn't find any solution yet :(

I'm experiencing similar issues with Ember-CLI apps and it's broccoli build folder /tmp.
On build (in console, outside of vscode), i can watch Code.exe spike from 0.1 to 20% CPU usage once files get created in the /tmp folder (folder empty beforehand).
The same happens on live-rebuilds. Sometimes broccoli sporadic fails here with file permission errors, maybe because Code opened the file at that time? Same issue on build cleanup, where temporary files fail to get cleaned (deleted).
My build times increased a lot lately, assumingly to this issue. I had way faster build times before, that's why i started to look into what's happening on build.
I don't have a clear date, from which on it got worse, probably with Codes April or May release.
My workspace settings are:
{
  "editor.tabSize": 2,
  "files.exclude": {
    "**/.git": true,
    "**/tmp": true
  },
  "search.exclude": {
    "**/node_modules": true,
    "**/bower_components": true,
    "**/docs": true,
    "**/dist": true,
    "yarn.lock": true
  },
   "files.watcherExclude": {
    "**/tmp/**": true,
    "**/dist/**": true,
    "**/bower_components/**": true,
    "**/.git/objects/**": true,
    "**/.git/subtree-cache/**": true,
    "**/node_modules/**": true
  },
  "eslint.enable" : true,
  "javascript.validate.enable": false,
  "emmet.syntaxProfiles": { "handlebars": "html" }
}

After adding "javascript.validate.enable": false, i at least got rid of validation errors for files in /tmp , so it seemes that the built-in validator didn't respect the exclude settings at all.
Disabling the eslint addon didn't help, so that shouldn't be the problem origin (also i've an .eslintignore).

Thanks @bpasero, was there any changes recently the way VS code scans the files?
I noticed the errors have severely increased in the last week or 2.
Also, to add to @enkol; up until now I never closed VS code when building the app and noticed the build process was taking minutes with VS open and it's down to seconds with VS close.

Not sure. Can you find out which process is locking the files? That would help.

See below, there are multiple processes Code.exe, I'm not sure how from there I can pass on more information on the culprit.
Here are some observations:
During the first build attempt, notice the Memory (135,268 K). Exception ENOTEMPTY thrown.

During the second build attempt (without closing VS between first and second attempt), notice the Memory (422,812 K). Exception ENOTEMPTY thrown.

After the second build attempt, notice the Memory (626,104 K). The build attempt lasted twice as long as the first attempt.

It seems that the memory keeps increasing during the builds and never get empty if an exception is thrown.
If there is more information needed, let me know how to get it and I'll be happy to pass it on.

I was hoping you could use a tool like https://technet.microsoft.com/en-ca/sysinternals/bb896655.aspx?f=255&MSPPError=-2147217396 to find out which process in VS Code is locking the file resources.
This issue seems very similar to https://github.com/Microsoft/vscode/issues/28013

For me it is the process "C:\Program Files (x86)\Microsoft VS Code\Code.exe" "c:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\typescript\out\utils\electronForkStart" "c:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\node_modules\typescript\lib\tsserver.js" --useSingleInferredProject --enableTelemetry --cancellationPipeName \\.\pipe\vscode-tscancellation-c4a82e1c70b64ae6ea38-sock* which takes so much CPU time once Ember-CLI's broccoli build creates it's temp files.

SysInternals procmon.exe logs hundreds of thousands file access actions of Code on that time (PID of the above mentioned process) for files in broccoli's build folder \tmp, which is on all possible exclude lists (see previous comment). Most CreateFile calls are "read attributes", "generic read" and "execute/traverse" with shared mode "read, write, delete".
But there are also some "excute/traverse" ones with only "read, write", which may cause my "can't delete folder/file" errors on broccoli builds?
Also, there are additional tries for every .js file to also read attributes of .ts, .tsx, .d.ts and extension less files with the same name).
I wasn't yet able to catch concrete handles in a case where i get file access errors on a broccoli build. Because i haven't found a good way to catch that exact moment with a tool like handle.exe (which displays "at the monent you run it" information). A logging procmon heavily slows down the build process and therefore may change timings of actions that could cause problems otherwise.
But i think it's some kind of: broccoli fails to delete a temp folder with not_empty error, because a beforehand delete_all_contents failed to delete some files/folders, which i assume are opened elsewhere and Code comes in mind because of it's CPU spikes at that time and all it's file actions within the tmp folder.

Same as @enkol,
During build, CPU spikes:

This is after the error is thrown, CPU back to normal but memory has not gone down:

Maybe this is somewhat related to #26247. In my case of Ember-CLI, the broccoli build tool uses a lot of symlinks in the tmp folder, which can point to files in folders outside tmp, mostly files in node_modules. Even though, i have both tmp and node_modules in files.watcherExclude.

I just got a file located in the tmp folder listed in search results, despite the fact that i have tmp in files.exclude and search.exclude is documented as "Inherits all glob patterns from the files.exclude setting.".
Doing the same search just again resulted in having the file not listed anymore. So there might be some issue with exclude settings not correctly working sometimes?

Dunno if this might help...
I had modified my default settings for files.exclude, search.exclude and files.watcherExclude at File->Preferences->Settings.
This seemed to work at reducing my build times but later I noticed that they started slowing down again.
At this point I noticed that a .vscode directory showed up at the root of my project.  In that directory was settings.json.  settings.json had different settings than what I had set in my defaults.
Once I set the exclusions in my project level settings.json my builds went back to excluding the directories from the VS Code.

@brucejo75 Thanks for your input!
I have my exclude settings already in the workspace settings (the ones in the projects .vscode folder). With File->Preferences->Settings you get to see both, your local user settings and the current workspace settings (switchable top right).

D'oh!  Thanks @enkol!  I probably had written out my project setting myself (maybe unwittingly).

I just noticed something.  I often put my computer to sleep.  On my last wake up from sleep, the build was consuming a fair amount of CPU for code.exe during the build.  I do not recall having that happening previously.
I closed and restarted VS Code and now the CPU load from code.exe has gone back down.
Does VS Code do special initialization on wake up?

I have same issue.
I had first 'npm isnstall error' after meteor run #28013 .  Then I solve it with closing vscode.
Meteor Can't start when vscode is opened. Meteor Can't refresh after modifying startup code as well.

Same issue here. Seems to have started with the latest stable release of VSCode.

I believe this is a duplicate of #28593
Please try out the latest vscode insiders build and let me know if you still see this issue

For me, it looks like the problemis partially fixed.
I did not get any permission errors on build, with VSCode 1.14.
But the tsserver process still seems to watche my tmp folder, despite having it on all known exclude lists (see comment 310366877).
This slows down my build process quite a bit.


Batch Gift Entry: Update Opportunity Feature May Overwrite Opportunity Fields

If Payments are enabled in an org and a customer is using Batch Gift Entry, they have the option to Update Opportunity or Apply New Payment to a matched gift if the Opportunity has no payments or all payments have been paid. Selecting the “Update Opportunity” option may lead to unintended Opportunity field changes — Amount and Close Date, for instance. The Stage will also change to Closed Won.
Recent work will address this by changing the options that appear for a matched gift:

When Payments are enabled and a matched Opportunity has no payments, we will only display an “Apply New Payment” option. We will remove the “Update Opportunity” link.

When Payments are not enabled and a matched Opportunity has no payments, there will be an option to Update Opportunity.

**lurch: attach W-033025

Tracking W-033025

Included in beta release 3.160 (Beta 1)

Included in production release 3.160


Android datepicker mode configurations added

Motivation
Currently, The DatePickerAndroid component opens the native date picker with default mode. We can't able to change the mode via configurations. To support android date-picker mode, existing component needs to be changed.
Solution
For Android >= 5.0, The DatePickerDialog doesn't provide the default method to change the mode of a date picker.  So I have added custom theme which will support two kinds of mode('spinner','calendar') ref:https://developer.android.com/reference/android/R.attr.html#datePickerStyle.
For Android < 5.0, The DatePickerDialog provides the default method to change the mode of a date picker. ref:https://developer.android.com/reference/android/widget/DatePicker.html#setCalendarViewShown(boolean).
With the help of Build.VERSION.SDK_INT I have done the above functionality with limited lines of code changes and also I have added the example to UIExplorer.
Test Plan
When opening a date picker on Android, We need to pass the option value(mode: 'calendar/spinner/default').
Example1:
DatePickerAndroid.open({ date: Date.now(), mode: 'calendar'}) // It will open datepicker with calendar mode
Android < 5.0

Android >= 5.0

Example2:
DatePickerAndroid.open({ date: Date.now(), mode: 'spinner'}) // It will open datepicker with spinner mode
Android < 5.0

Android >= 5.0

Example3:
DatePickerAndroid.open({ date: Date.now()})
(or)
DatePickerAndroid.open({ date: Date.now(), mode: 'default'})
// It will open datepicker with default native mode based on android versions.
Android < 5.0

Android >= 5.0

So If the user doesn't give mode option then default mode will be shown.
For real-time testing, you can run UIExplorer android project. I have added example code.

This looks reasonable. Why is it tagged "[URGENT]"? Can you verify that the test failures are unrelated to this change?

@ericvicenti removed the urgent tag from title. The build issues are related to Xcode8, I have changed only the DatePickerDialogModule for android.

Ok, looks great!
@facebook-github-bot shipit

We had some test failures internally. Do you know why this would happen?
/data/react-native-github/ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/DatePickerDialogFragment.java:28: error: cannot find symbol
import com.facebook.react.R;
                         ^
/data/react-native-github/ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/DatePickerDialogFragment.java:63: error: package R does not exist
        dialog = new DismissableDatePickerDialog(activityContext, R.style.CalendarDatePickerDialog, onDateSetListener, year, month, day);
                                                                   ^
/data/react-native-github/ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/DatePickerDialogFragment.java:65: error: package R does not exist
        dialog = new DismissableDatePickerDialog(activityContext, R.style.SpinnerDatePickerDialog, onDateSetListener, year, month, day);
stderr: /data/react-native-github/ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/DatePickerDialogFragment.java:28: error: cannot find symbol

@ericvicenti I have added custom styles in "react-native/ReactAndroid/src/main/res/devsupport/values/styles.xml". For reflecting those styles you have to run a clean build on android projects.

Hmm. Maybe @mkonicek can help land this, because I have no idea what I'm doing when it comes to best practices around these things.

@ericvicenti , @mkonicek I have run the "npm test" command inside react-native folder. The test cases are executed successfully.
FYI...

Can someone from android core team have a look at on this.

Try to run scripts/run-android-local-unit-tests.sh

Hi @ericvicenti , @ericvicenti , @facebook-github-bot , @leeight Finally, I have found the root cause of the issue("error: cannot find symbol import com.facebook.react.R;"). I have missed the resource dependency in date picker buck file. Now I have added the dependencies to  "ReactAndroid/src/main/java/com/facebook/react/modules/datepicker/BUCK"  file. I run the android unit test cases and it was passed and In an android integration test,  date picker modal test cases were passed.
FYI..
sh scripts/run-android-local-unit-tests.sh- Result

sh scripts/run-android-local-integration-tests.sh - Result

I have re-base the code from master and updated the pull request.

@AaaChiuuu / @spicyj Can you please review the pull request.

@pandiaraj44 Please stop tagging everyone. It sounds like @mkonicek will look into why the import failed and tell you if anything needs to be changed.

I am re-running internal tests and will land this afternoon if everything passes.

Hi @ericvicenti , FYI... All git hub checks have passed.

Hi @ericvicenti , Again I have re-base my code from upstream and tests have passed.

I think an enum is a better API for this, even if it's just two types, mode='calender' and mode='spinner' feel better to me than calenderMode.

Thanks for doing this! I have one API request: rather than using boolean, how about being explicit:
DatePickerAndroid.open({ date: Date.now(), mode: 'calendar'})
DatePickerAndroid.open({ date: Date.now(), mode: 'spinner'})

Rather than calendarMode: false the reader can immediately see this is using the spinners. It also allows for adding a third option in the future without introducing a breaking API change.

Thanks @leeight , @satya164 , @mkonicek. It is a great idea we can go with the enum. I have added another mode.
enum('calendar', 'spinner', 'default')

'calendar': Show a date picker in calendar mode.
'spinner': Show a date picker in spinner mode.
'default': Show a default native date picker(spinner/calendar) based on android versions.

Hi @leeight , I think we can go with getResources().getIdentifier(). I have removed shell dependency.
dialog = new DismissableDatePickerDialog(activityContext,
            activityContext.getResources().getIdentifier("CalendarDatePickerDialog", "style", activityContext.getPackageName()),
            onDateSetListener, year, month, day);

Hi @mkonicek , Changes are done. Can you review it.

cc @leeight

cc @satya164 @ericvicenti @facebook-github-bot

@pandiaraj44 Can you address @leeight 's nits regarding whitespace please?

@satya164 Updated the pull request.
Can you please let me know who is the potential reviewer for this pull request and when they will accept/reject this pull request?
cc @leeight

Can you please let me know who is the potential reviewer

Me, @leeight and @mkonicek are reviewing your PR, so I guess we're the reviewers

when they will accept/reject this pull request?

We'll merge when all review comments have been addressed

@satya164 Thank you very much for your information.

@pandiaraj44 Please comment once you've addressed all the comments.

Thanks!
@facebook-github-bot shipit


Liqun/fix onnx version for ort stable

current onnxruntime-training release does not support onnx 10.1. fix onnx==1.9.0

Good find. Can we pin the version in ROCm Dockerfile as well?


Google Colab fit_retriever bug

Using Google Colab for trying out the PDF converter, I keep getting fit_retriever() got an unexpected keyword argument 'X', prior to executing a query.

Try cdqa_pipeline.fit_retriever(df = df)

Thank you it worked. Is there a way to run CdQA with custom datasets and models in Colab for quick testing ? Sorry for posting the Q here.

You can take a look at our tutorials for quick testing here:
https://github.com/cdqa-suite/cdQA#notebook-examples


LORA Merge fails in 4-bit mode

Trained vicuna-13b-1.1 LORA in 4bit
Now trying to merge it for running generations but it fails with the following error
python3.11/site-packages/peft/tuners/lora.py", line 352, in merge_and_unload
    raise ValueError("Cannot merge LORA layers when the model is loaded in 8-bit mode")
ValueError: Cannot merge LORA layers when the model is loaded in 8-bit mode

Strangely the checkpoints in the output directory are also very small (adapater_model.bin is just 400 bytes).
However, the optimizer.pth is around 1GB.

I also encountered this problem. My adapter_mode.bin is also only 443kb

has the problem solved?

+1

+1
But i think it is.
https://github.com/huggingface/peft/blob/0e33ac1efe1564143bffd248906d9e17864017dc/src/peft/tuners/lora.py#L461-L463

I have looked into the source code of HF and BitsAndBytes. It seems to me the ultimate reason why this is not supported is that the bnb.nnLinear4bit module is not designed to be mergable by adding the lora weights. I have discovered a workaround

a followup to my previous post: interestingly, if we delete the line module.disable_adapters = True, the function is equivalent to dequantizing + merging Lora .

With this work around to merge Loras in 4bit, is there no performance loss if the lora you are merging was already trained in 4bit qlora?

a followup to my previous post: interestingly, if we delete the line module.disable_adapters = True, the function is equivalent to dequantizing + merging Lora. This should resolve the issue completely. :)

What would be the implementation with bias?


[WIP] Adding sourcelink to projects

Fix Issue #1760 .
See comment history on original PR: #1800
Changes

Adding common properties to _nupkg.props;
Adding package reference to Microsoft.SourceLink.GitHub

Checklist

[ ] I ran Unit Tests locally.
[ ] CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

[ ] Design discussion issue #
[ ] Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:

FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

We support comment build triggers

/AzurePipelines run will queue all builds
/AzurePipelines run <pipeline-name> will queue a specific build

/AzurePipelines run

I would like to propose a change to this:
Can you add the following snippet to this file: .props\Product.props

  <ItemGroup Condition=" $(OS) == 'Windows_NT' And $(Configuration) == 'Release'">
    <!--Analyzers-->
    <PackageReference Include="Desktop.Analyzers" Version="1.1.0">
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>
    <PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>
    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="2.9.8">
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>
    <PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="2.9.8">
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>

    <!--Build Infrastructure-->
    <PackageReference Include="Microsoft.VisualStudioEng.MicroBuild.Core" Version="0.4.1">
      <PrivateAssets>All</PrivateAssets>
    </PackageReference>
    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
  </ItemGroup>

Then, can you please remove all of these references from each of the 17 csproj files?
IM me on Teams if you have questions.


paths resolution is broken in v4.7.5

Problem
As mentioned in https://github.com/privatenumber/get-tsconfig/pull/77#issuecomment-2106651097, the latest release of get-tsconfig (v4.7.5) breaks paths resolution.
As I mentioned, TSConfig has the following map specified:
"paths": {
  "#*": ["./*/index.ts"]
},

To reproduce the problem, I use createPathsMatcher() example from the readme. TSConfig file is loaded from <path-to-project>/source/tsconfig.json and passed to createPathsMatcher().

before v4.7.5 pathsMatcher('#sample') resolves to: <path-to-project>/source/sample/index.ts.
since v4.7.5pathsMatcher('#sample') resolves to: <path-to-project>/source/source/sample/index.ts

Expected behavior
It should not break.
Minimal reproduction URL
https://github.com/privatenumber/get-tsconfig?tab=readme-ov-file#createfilematchertsconfig-tsconfigresult-casesensitivepaths-boolean
Version
v4.7.5
Node.js version
lts
Package manager
npm
Operating system
macOS
Contributions

[ ] I plan to open a pull request for this issue
[ ] I plan to make a financial contribution to this project

Thanks for the issue but the bug needs to be proven with a minimal reproduction to be confirmed.
Let me know once it's been updated and I'll reopen.

 I can't provide reproduction for that.

You're one warning away from getting banned. Please be respectful.
This is project runs on community contributions and you're benefitting from it for free. Take a look at the other issues; everyone else is doing the due diligence of providing a minimal reproduction to prove the bug exists. If you expecting others to do your work for free, please look elsewhere.

please look elsewhere.

Sure. This was the last project I was using ESLint. Thanks for extra motivation to migrate away.


React native TextInput props will not working

For example, I need to add maxLength and keyboardType, and other props

i'm having somew problems with props, inputFontSize and some other props doesn't work, and other than that text stays on top of borderbottom which it's color does not change


[flutter_tools] pin shelf version at 1.1.4

It was reported in https://github.com/flutter/flutter/issues/81010 that loading a flutter web app that had a large javascript file was taking 4-5 minutes to load. This lead to a discovery that a CastList was being used, fixing that in https://github.com/dart-lang/shelf/pull/178 made this take milliseconds.
This is being reverted as an accidental breaking change for https://github.com/dart-lang/shelf/issues/189. In the meantime, we don't want to regress performance so let's pin the shelf version until there is another major release

test-exempt: refactor with no semantic change


test tests.yml

Hey Trevor, is this to be merged?

Hey Trevor, is this to be merged?

Im trying to narrow down why the ci/cd is failing - when everything runs locally and is fine, the ava tests have issues

Where do you see them failing?
You get    message: 'Can not sign transactions for account test.near on network sandbox, no matching key pair found in InMemorySigner(UnencryptedFileSystemKeyStore(/tmp/sandbox/b7a63273-5c84-400a-ab6f-340ab73c294b)).', error from time to time if you push too many commits in a short time, but other than that they pass pretty much every time.

@ctindogaru yes thats the exact error. Is it fixable? Kinda shitty that it fails sometimes because.... shrug?

Yeah, it's shitty, I usually restart the job if it happens.
For me, it happens even locally (pretty frequent). It might be a problem with the near ava testing framework.

Got it - well im going to play with a couple ideas, and then i'll know what the issue is here.

Fingers crossed. 🤞

hehe exactly 📦

welllllll that worked :D


Improve message display

Multiline message (e.g. stacktrace) are not well displayed. Pick-up the css from kibana itself on the css .message class:
Turn (in public/css/main.css):
.message {
    color: #B0B0B0;
}

into:
.message {
    color: #B0B0B0;
    word-break: break-all;
    word-wrap: break-word;
    white-space: pre-wrap;
}

Regards

Thanks fixed. Please install 1.5.0

Kibana 4.x : ./bin/kibana plugin -i logtrail -u https://github.com/sivasamyk/logtrail/releases/download/0.1.5/logtrail-4.x-0.1.5.tar.gz
Kibana 5.x : ./bin/kibana-plugin install https://github.com/sivasamyk/logtrail/releases/download/0.1.5/logtrail-5.x-0.1.5.zip


Timeout

Should we have some sort of timeout on the tests?

Let's punt on this for now until there's an actual need.


The paper link

very appreciate your contributions to this community. However, I can't find the paper link. When will it be released? thanks:)

Of course, the link to the article has been updated now, thank you for your suggestion!


Sun becomes dimmer after one day cycle

Bug description: Sun becomes less visible after the second sunrise. At the first day, it is fully visible. Reloading the pack via F3 + T resolves the issue, but for one day cycle only.
Minecraft version: 1.18.2
FSB version: 0.5.5
Steps to reproduce

Use this resource pack: fsb_test.zip

Wait until the next in-game sunrise or do it via commands:
time set day
time set night
time set day

I can reproduce this issue with 0.5.6, however the sun disappears entirely instead of simply dimming.  I believe this is because of a separate but related bug affecting the sun's transition from one skybox to another during sunset/sunrise.

Cannot reproduce after the newest changes to 1.19.x-dev.  Please reopen if this issue is still occurring.


v-bind doesn't work will with style

Version
2.5.17-beta.0
Reproduction link
http://jsbin.com/gireyuh/edit?html,js,output
Steps to reproduce
init vue
What is expected?
the div will have a background image
What is actually happening?
it doesn't;and the attribute disappeared

You can't have parenthesis in your url(...) expression in CSS, it's just not a valid CSS property value and this has nothing to do with Vue.

thx, i missed it


setup.py: Use VERSION variable

So, first of it makes sense to have something like <pkg_name>.__version__ as lots of devs use this to check the version without using pip. (Like in the code)
Also, you use 1.1.0 twice in setup.py: Once for the download_url and once for the version. This means you will be changing the version twice for every release. Hence, it makes sense to add this as a variable and reuse in both places.
If you do the VERSION file system like how coala and coala-bears does it, you can directly make rultor make dev releases for you for every PR merge. (Which I think is cool, but not required).

i dont understand quite how, sorry

nevermind, ill jsut remove the download URL as i find it useless, im going to take the version constant for the version.


Instagram call checkpoint for this action!

Instagram call checkpoint for this action!
why is this showing

same issue here


Update JS dependencies

Use Yarn to manage JS dependencies
Limit the dependencies just to those needed by gulp, let packages
specify their own dependencies
Use libsass via node-sass to compile sass and remove Ruby dependency
Use gulp-clean-css instead of gulp-minify-css
Update the INSTALL docs

Coverage remained the same at 23.136% when pulling 95f6df5b260eeff2160afa96969a51543cac6f38 on boffbowsh:js-dependencies into 3e7a9e2dc23596cdcb82ea08394538bc0f9e7008 on DemocracyClub:master.


fix Fix tablet_id is zero when txn lazy commit (#42043)

when recycler and ms convert tmp rowsets at the same times, and finish convert task with different partitions severally, may cause tablet_id variable is zero

Proposed changes
Issue Number: close #xxx

pick #42043

run buildall


Dashboard Improvements

This PR targets #87 .
The suggested changes have been made

Hey @maanas-talwar @Ammoniya . Please review the PR


Update Chile tests

Proposed change

Update Chile tests (for complete coverage).
Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

Coverage: 99.7% (+0.02%) from 99.681% when pulling 8c95e962bbba01360e61838034b32f0c14da75a4 on KJhellico:fix-chile into 3f23fbe53a709dd55fd966142d8d61e003707404 on dr-prodigy:beta.


Memory spec

@botaberg, @terrajobst, @jkotas, @joshfree, @davidfowl

Shouldn't this talk about the OwnedMemory<T> as an interface design point?

Shouldn't this talk about the OwnedMemory as an interface design point?

The "bonus features" section will discuss this.


Re-init bones when soft contact is enabled

To prevent bones from going away to infinity under certain situations.

If I recall, the core thing to test with this subsystem is whether there are any jumps when letting go of objects palm-up (so they drop into your hand immediately) and throwing

This all feels good too (palm-up releases, throwing, and two-handed interactions tested).


Frontpage design feedback

We got some design feedback from @Linedueo. Let's break it down here and fix it.
Link to design in Figma

Front page design adjustments:

[x] left align the search bar and title. It should be flush with the cards.
[ ] search bar and title flow a bit now. (Please explain @Linedueo)
[x] cards must be left-aligned and not centred.
[x] Pagination must be right-aligned.
[x] It would also have been nice to have a centred logo over icons in the left nav. We use green logo. There is also an awful lot of spacing between logo and name.

Originally posted by @Linedueo in https://github.com/equinor/MAD-VSM-WEB/issues/113#issuecomment-934162888

👋 @Linedueo
About the top bar alignment issue you mentioned.

It would also have been nice to have a centred logo over icons in the left nav. We use green logo. There is also an awful lot of spacing between logo and name.

We are using the EDS component for top bar which have a preset padding.
We do have a bit more padding on the left though because of the ghost-button wrapping the front-page link. So we could improve it a bit, but it would still not align with the left navigation-bar.
What would you suggest?
Are you suggesting that we don't follow eds guidelines in this instance and make it look like your design?

@SjoenH I would prefer you follow my design, yes.

👋 I found this: https://medium.com/@andybarefoot/a-masonry-style-layout-using-css-grid-8c663d355ebb
But don't spend too much time on it. Also, we could look into something called masonry. Also https://www.npmjs.com/package/react-masonry-css


Puppeteer and Lighthouse for  page flow

We are working to automate our product flow using Puppeteer and lighthouse. We would like to prepare performance report all the pages in our application.
In our application we select product /product-details), add to cart (/add-to-cart), add customer details(/customer-details),  card-validation(/card-validation), checkout (/checkout).  We would like to validate individual page.  The challenge i am facing here in first page (product-details) i launch using Puppeteer and execute lighthouse and then  to get next page again call /add-cart page in Pupeteer and when i execute same page using lighthouse then i lost the data ( item selected in product-details page). then again next customer-detials page if fill using "page.type" and execute lighthouse it will not launch same page, it will start from product-details page. How this issue can be solved.

@ebidel , Can you pls help me.

We unfortunately do not have a great story there yet.  There are a couple of open bugs to discuss what  Puppeteer + Lighthouse would look like but we haven't made much progress on it. The challenge (as you've seen) is that Lighthouse reloads the page several times as it tests the page and there's no way to share state or pass a puppeteer-created page to LH.
https://github.com/GoogleChrome/lighthouse/issues/3837
https://github.com/GoogleChrome/lighthouse/issues/4403
Closing this in favor of those other issues.

@ebidel , Thanks for the help.  Is there is any other way to automate 'n' number of page flows using lighthouse without Puppeteer.

Lighthouse isn't designed to do flows like this. You might be able to use another automation tool....

What you think this approach using puppeteer:https://michaljanaszek.com/blog/test-website-performance-with-puppeteer

Looks like a lot of good stuff in there!
On Mon, Feb 26, 2018, 11:08 PM rageshpayyan<EMAIL_ADDRESS>wrote:

What you think this approach using puppeteer:
https://michaljanaszek.com/blog/test-website-performance-with-puppeteer
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GoogleChrome/puppeteer/issues/2105#issuecomment-368768769,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOigP1IOnliI0wHHDX_m1qtZACzGSdxks5tY6nUgaJpZM4SULRY
.

@rageshpayyan I checked blog but my understanding is that "lighthouse" is not used but just "puppeteer" which is not very clear to me.


transpose on Panel fails

import org.saddle._
Panel(Vec(1, 2, 3), Vec("hello", "world", "!")).T

throws
java.lang.ArrayStoreException
	at java.lang.System.arraycopy(Native Method)
	at org.saddle.array.package$.$anonfun$flatten$2(package.scala:623)
	at org.saddle.array.package$.$anonfun$flatten$2$adapted(package.scala:621)
	at scala.collection.immutable.Vector.foreach(Vector.scala:1856)
	at org.saddle.array.package$.flatten(package.scala:621)
	at org.saddle.scalar.ScalarTagAny.concat(ScalarTagAny.scala:64)
	at org.saddle.Frame.toMat(Frame.scala:1426)
	at org.saddle.Frame.T(Frame.scala:168)
	at repl.MdocSession$App.<init>(scalar.worksheet.sc:11)
	at repl.MdocSession$.app(scalar.worksheet.sc:3)

Thanks for finding this.
What do you think of Panel? In the last 10 years I never used it.

I don't have much experience with saddle.
This works fine with the regular frame constructor:
Frame(Vec[Any](1, 2, 3), Vec[Any]("hello", "world", "!")).T

Issue is probably that the underlying arrays of Vec[Int] and Vec[String] aren't compatible for the transposition. Panel allows that by taking Vec[_]in whereas the Frame example above forces Vec[Any] and corresponding scalartag.

Thanks for finding this.
What do you think of Panel? In the last 10 years I never used it.

Just chiming in to say heterogeneous Frames are important for statistical modeling where you have categorical variables and continuous variables in the same dataset. Does this forked version of saddle support heterogeneous Frames?


Migrations

Why did you delete the migrations? :(

Because we want to clean it up :)
You can apply new changes in your existing database by getting the latest MigrationId in '__EFMigrationsHistory' table, then check the commit history, get back the SimplDbContextModelSnapshot.cs at the state of that MigrationId. Then you can do 'Add-Migration' from there. Entity Framework will detect changes since that snapshot

Thank you for your response! :)


no_std training book

Shall we keep the content of the "no_std" book in this book or should it be an standalone book?
I don't have any hard opinion, what I would like to have is the code available in the repo, so we can have proper CI testing it. But since we already have a "std book" (Ferrous System training) I would do something equivalent (even if the examples are different) for no_std.

Given we have a separate book about the "std" approach probably it's not a bad idea. Also, since we have two very different approaches having all the content in one book is a bit confusing, I guess.
Another thing is, in a separate book we go deeper into more advanced topics (e.g. wifi, async). Not sure we should do that in the current book.
Additionally, probably people will go to the book, then decide which approach they want to try and then head over to the specific books.
But to be honest I also don't have a very strong opinion on this. Generally I would be fine with both options

Here is the initial version of the standalone no_std book:

repo: https://github.com/esp-rs/no_std-training
book: https://esp-rs.github.io/no_std-training/


Opensearch rest-client jar not available in maven repo.

I see the elastic search dependence is present in the maven repo but for the OpenSearch, no dependence/jar is present in the maven repo.
Where can we download the OpenSearch rest-client.jar released versions?
Maven repo for ElasticSearch : https://mvnrepository.com/artifact/org.elasticsearch
Do we have maven repo for OpenSearch?

Do we have any expected date?


sbt 1.2.8 generates a synthetic configuration instead of failing

[x] I've read the CONTRIBUTING guidelines

steps
cd /tmp
mkdir sbt101
cd sbt101
touch build.sbt

Add the following content to the file
ThisBuild / version := "1.0"

lazy val db = project.settings(
  version := "2.0",
)

lazy val business = project.settings(
  version := "3.0"
)

Save and open up a terminal
Run the following command

sbt

When you are in sbt console, run the following commands

sbt:sbt101> business/version
[info] 3.0

sbt:sbt101> business:version
[info] business / Business / version
[info] 	3.0
[info] db / Business / version
[info] 	2.0
[info] Business / version
[info] 	1.0
sbt:sbt101>

sbt:sbt101> db/version
[info] 2.0
sbt:sbt101> db:version

[info] business / Db / version
[info] 	3.0
[info] db / Db / version
[info] 	2.0
[info] Db / version
[info] 	1.0
sbt:sbt101>

problem

The output from db/version do not match with db:version.
sbt generates a synthetic Configuration which does not exist. example? see Business and Db above

expectation

The outputs from db/version and db:version(and other commands alike) should have matched their outputs.
Instead of creating a synthetic Configuration, it should have failed. The current output leads to confusions (and may be wrong as well, can't say for sure)

notes

Thanks to @dwijnand for the help on gitter chat and helping out on this issue.

sbt version: 1.2.8

expectation

The outputs from db/version and db:version(and other commands alike) should have matched their outputs.
Instead of creating a synthetic Configuration, it should have failed. The current output leads to confusions (and may be wrong as well, can't say for sure)

As mentioned on Gitter, I think the second is the correct expected behaviour.

@dwijnand , do you mean creating a synthetic Configuration is correct behavior? If yes, can you explain why, as I may have not understood it

No, "it should have failed" is what I expect.

@hhimanshu Thanks for the detailed report.
I concur with @dwijnand "Instead of creating a synthetic Configuration, it should have failed." I think is the correct behavior. The tricky part is that subprojects and plugins can introduce custom configurations, so we need to clarify the behavior around this, both in the shell and in build.sbt.

For example if there is a root project and projA and projB, and IntegrationTest configuration is found only on projA, thanks to delegation rule, IntegrationTest/someKey would work on root or projA if someKey is defined without configuration scoping in those projects (or in Global or ThisBuild).
So I'd propose that <config>:key failing only when <config> is absent from the all subprojects.

Agreed.

For example if there is a root project and projA and projB, and IntegrationTest configuration is found only on projA, thanks to delegation rule, IntegrationTest/someKey would work on root or projA if someKey is defined without configuration scoping in those projects (or in Global or ThisBuild).
So I'd propose that <config>:key failing only when <config> is absent from the all subprojects.

Totally agree with that


Sequence of keybindings only works when focus begins in terminal

VSCode Version: 1.17.2 (1.17.2)
OS Version: 10.12.6

I have the following in my keybindings.json:
    // Move focus up to editor:
    { "key": "ctrl+a ctrl+k", "command": "workbench.action.focusActiveEditorGroup", "when": "terminalFocus"},
    // Move focus down to the terminal:
    { "key": "ctrl+a ctrl+j", "command": "workbench.action.terminal.focus", "when": "editorFocus"},

The sequence of multiple keys to move from editor down to the terminal works fine, but the sequence to move back up to the editor once the terminal has focus does not register.
Reproduces without extensions: Yes

I think the problem here is that chord keybindings don't work in the terminal, not sure what a good solution to this would be as currently the keystroke is checked if the command (workbench.action.focusActiveEditorGroup) is run and if it doesn't it's sent to the shell.

Unfortunately this is just a limitation of our keybinding system that we cannot evaluate chord keybindings within the terminal.


feat: add recurrenceRule to event

Fixes: #3

Thank you for your contribution!
Since I am out of the city without my laptop this week, I will test it and make a release next week. So far, it LGTM!


proposal: cmd/go: include vcs revision in module .info files

It would be nice to have a way to tell which revision the proxy saw when it got a version from upstream. While this information isn't needed most of the time, it is helpful in debugging sum mismatches / moved tags. Currently to do so we can only download from both upstream and the proxy and diff the directories.

proxy.golang.org just forwards on the .info files generated by the go command.
cc @jayconrod @bcmills

It wouldn't be too hard to add optional fields to .info files.
But I should point out that these files aren't authenticated, and it's possible they can change over time or be reported differently by different proxies. I think the go command would have to ignore this information when reporting security errors.
cc @matloob as well.

I agree they shouldn't be considered for reporting security errors just for humans identifying issues, I don't think the information would be reliably available either (old versions, mod as vcs)

It would be easier to investigate issues like https://github.com/golang/go/issues/46348 if the vcs revision info was available.

I agree, this would make life a lot easier than e.g the steps that I had to take here:
https://github.com/argoproj/argo-rollouts/issues/2065#issuecomment-1144110068
Which took about 1-2 hours of troubleshooting to pin down. Maybe someone who is more familiar would be faster but that was not me. In particular the Go command abstracts a lot and cleans up downloaded files, so it's not easy to verify, what is the proxy URL being hit, what is the command being run to fetch data from the upstream, etc.

This is done. If you run with GOPROXY=off you will see them in all your info files that come from git.
If you are using a proxy then it depends on what the proxy serves.
By default Go uses proxy.golang.org, which serves the vcs info in info files it has gathered since Go 1.19 was released.
For example<EMAIL_ADDRESS>Older info files known to the proxy have not been refreshed, so you will see a mix of with and without vcs that way.


'coll-caselles' Split window method not valid

'coll-caselles'  method not valid and error message not useful.
Thanks

Resolved

.


[docs][base] Move styles to the bottom of demos code for SelectUnstyled

Part of #36498

[x] I have followed (at least) the PR section of the contributing guide.

Please run yarn prettier, then yarn lint, and correct all the violations.
Also, merge in the latest master.


Features/liquid with testnet based on dev

Hi, I've been working on an updated liquid branch. This branch have been tested and working as expected in my environment, on testnet, using docker compose. The liquid pegin is not working so disabled. My gues is that the liquidtestnet is not based on bitcoin testnet chain. The liquid docker is updated PR # 26 on docker repo, and build manualy in my testing.

I'm not 100% certain of my work, especially about the version migration stuff, so don't trust verify. Additionally, I've seen that some calls are not included in the requesthandler, and this raise unanswered questions about Liquid xpub, derived address, etc.. Also, I'm aware of RPI memory problems while using liquid but those concerns are not addressed.

Ooh I merged latest dev to features/liquid and features/wasabi yesterday... those branches are thus up to date since yesterday.  It could be interesting to compare your PR with the features/liquid branch.  :)
Basically for liquid, I replicated most of the Bitcoin functionalities but didn't expose, in the requesthandler, what we didn't need at Bull Bitcoin.  So let's assume what's not in the requesthandler is not tested.  That includes the xpub stuff.
elementsd alone needs at least 2GB of RAM when running on liquid, so it may be pretty difficult to deploy that stack on a RPi.
I still haven't setup the testnet chain on liquid, when I looked (when you told me about it in another issue) it wasn't clear it was ready.  It wasn't really working.

Ok then I will close this PR and build an other one with liquidtestnet. I can confirm that transactions on liquidtestnet with elements-qt, cyphernode, blockstream Green, blockstream explorer are working great, so let's implement this onto liquid branch. WIP


Add flyoutOnly class to modal

Since the modal isn't created under the root, it isn't picking up the flyoutOnly stylings. Add this class back for the new HOC design

@abchatra can this be cherry picked into stable?

Ported to stable6.4


Error when creating azure funtion via VScode

Repro steps:

Action: azureFunctions.createNewProject
Error type: Error
Error Message: Failed to get latest templates: Command "dotnet "c:\Users\momor1.vscode\extensions\ms-azuretools.vscode-azurefunctions-0.20.0\resources\dotnetJsonCli\netcoreapp3.0\Microsoft.TemplateEngine.JsonCli.dll" --require "c:\Users\momor1\AppData\Roaming\Code\User\globalStorage\ms-azuretools.vscode-azurefunctions\dotnetTemplates\itemTemplates-~3.nupkg" --require "c:\Users\momor1\AppData\Roaming\Code\User\globalStorage\ms-azuretools.vscode-azurefunctions\dotnetTemplates\projectTemplates-~3.nupkg" --operation list" failed with exit code "2147516566":
It was not possible to find any compatible framework version
T...
Version: 0.20.0
OS: win32
Product: Visual Studio Code
Product Version: 1.40.1
Language: en

@moedeveloper please check to make sure you have the .NET Core sdk installed
Here's more info about what version to use: https://docs.microsoft.com/azure/azure-functions/functions-versions


Update geo-types to 0.7.8

On a new dev build, compiling fails due to the following error:
   Compiling geo-types v0.7.7
error: expected `,`, found `.`
   --> /home/matthieu/.cargo/registry/src/github.com-1ecc6299db9ec823/geo-types-0.7.7/src/geometry/geometry_collection.rs:111:25
    |
111 | #[deprecated(since = 0.7.5, note = "Use `GeometryCollection::from(vec![geom])` instead.")]
    |                         ^ expected `,`

This issue was fixed in geo-types 0.7.8, so I updated it using cargo update --package geo-types.

Side note: I am looking into contributing to this project over the next few weeks. I'll take a look at those good first issues and see if I can open more PRs. Happy to hear any suggestions you might have re. where to start!

Would you mind fixing those up too?

Sure thing

Any particular interest?

not really, the entire project looks interesting!

a preference about the type of code

I was looking for a cool open-source project to contribute to while improving my Rust skills. My expertise lies in web dev though, so I'd say mostly Rust interspersed with web dev things when I need to give my brain a break from learning a new language.
If you have any needs related to GitHub actions, I can definitely help with that. I'm thinking the issue solved here may have not been seen because the actions rely on a stale cache? Perhaps a nightly workflow that resets the cache would solve that?
Re. how much I'm looking to contribute, in case you're wondering: I'm currently an Engineering Partner with Commit, meaning that I have time to contribute to any project of my choosing to improve my skills, but I may be joining a startup anytime soon, so I don't know how long I'll be available to contribute.

What version of rust were you using when you hit that error? I'd only expect to see it affecting nightly at this point.

Ah, yes, I am using nightly
$ rustup show

active toolchain
----------------

nightly-x86_64-unknown-linux-gnu (default)
rustc 1.67.0-nightly (b3bc6bf31 2022-11-24)

Should I open an issue/PR to add a toolchain.toml file?

Should I open an issue/PR to add a toolchain.toml file?

Not sure I've seen many projects specify toolchain.toml for stable, but it'd be fine to codify the docs (which're outdated... latest stable, not 1.61)

I'm thinking the issue solved here may have not been seen because the actions rely on a stale cache? Perhaps a nightly workflow that resets the cache would solve that?

No workflow builds everything on every commit right now. The project is small enough to make that unnecessary; there've never been more than a few people working on it at a time. There's a release process that's a bit manual, but isn't worth automating further right now.

not really, the entire project looks interesting!

A sampling of ideas, then... let me know if more context is useful for any of them

The OSM processing code is now over in https://github.com/a-b-street/osm2streets, and there's a simple Leaflet viewer for it. https://github.com/a-b-street/osm2streets/issues/132#issuecomment-1339162927
The LTN app draws road labels using https://github.com/a-b-street/abstreet/blob/ad99823cc886dfe5ccaea9581bb3e37d0a7ad6cf/map_gui/src/tools/labels.rs#L210. There are some cases when the label isn't centered vertically very well. And maybe you have design ideas to improve them generally?
https://github.com/a-b-street/abstreet/issues/1013 New features for the bike network tool
https://github.com/a-b-street/abstreet/issues/393 New features for 15-min neighbourhood tool, and also, plenty of directions this tool could go
https://github.com/a-b-street/abstreet/issues/372 Very little public transit support today. It's a huge project, but there might be pieces to bite off that're fun
https://github.com/a-b-street/abstreet/issues/88 If you have an eye for design
https://github.com/a-b-street/abstreet/issues/85 Figuring out how to visualize changes in traffic volume, and more efficiently record them


Security scheme iterator stores invalid ProcessingResult

In case of security check error, SecurityCheckFailed status will be stored to ProcessingResult despite other security checks
https://github.com/mikekonan/go-oas3/blob/1bc59da088a96dd15c738a57683457df79fe707c/generator/generator.go#L1352

fixed in https://github.com/mikekonan/go-oas3/releases/tag/v1.0.11


Component-testing - tag and group option discarded at runtime

I followed the example for Component testing, running it after my integration tests, but I cannot get the 2 runs to group together.
This is my setup:
      - name: Cypress run e2e
        uses: cypress-io/github-action@v2
        with:
          browser: chrome
          cache-key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
          install-command: yarn install --prefer-offline --frozen-lockfile
          group: 'Chrome - Integration testing'
          record: true
          start: yarn start
          tag: 'PR - Integration'
          wait-on: 'http://localhost:3000'
          wait-on-timeout: 240
      - name: Cypress run ct
        uses: cypress-io/github-action@v2
        with:
          browser: chrome
          command: yarn test:ct --record
          group: 'Chrome - Component testing'
          install: false
          record: true
          tag: 'PR - Component'

But when component testing runs, console displays the following:
  │ Params:       Tag: false, Group: false, Parallel: false                                        │

And in Cypress dashboard, the 2 runs show on separate rows, and tag / group are not set for E2E, indeed.

Use of the command parameter overrides many functions in github-action.
If there is still an issue with this setup we can take a look using current versions.


[BUG] Certain props are not present in Select component

Describe the bug
Props like searchable and scrollToSelectedOption as shown in the SelectProps page in your docs are not present in the Select component as indicated by Typescript.
To Reproduce
Steps to reproduce the behavior:

Use v1.2.0
Type the following with data of your choice:

<SelectProvider>
    <Select options={data} searchable={true} />
</SelectProvider>

Typescript throws an error:

Property 'searchable' does not exist on type 'IntrinsicAttributes & SelectProps & RefAttributes<SelectRef>'.ts(2322)

Expected behavior
Typescript should not throw an error.
Screenshots
If applicable, add screenshots to help explain your problem.

Hi @steve1316
Thanks for reporting. This bug has been fixed in v1.3.0.


Custom Font Issue

Hi There,
Thanks for creating this awesome control !
I am facing a wired issue in this. If I set custom font in expandable label its is not working it is only working in system font.
Can you plz help me in this?
Thanks in again
Hoping for positive and the quick reply.

Hi,
I'm sorry to tell you that I can't help. The author of this component has left our organization. But if you find a solution and send a pull request, I'll merge it on occasion.

@objc open var ellipsis: NSAttributedString? {
    didSet {
        let font = Utility.getFont(fontName: (getThemeArtitsObj()?.fontSemiBold)!, sizeOfFont: 14.0)

        self.ellipsis = ellipsis?.copyWithAddedFontAttribute(font)
    }
}

Please set font check it its supported custom font


static token can occasionaly be a plain identifier even in a class

in class A { static static() {} }, for example, the first static should have the type Keyword while the next one should have the type Identifier; the tokenizer currently gives the latter the same type as the former.

Does this only apply when tokenizing, or in the ast as well?

my apologies for not giving more detail -- this is only the case with the tokens returned via the tokens parser option (e.g, esprima.parse('class A{static static() {}}',{tokens:true}).tokens); I am not very familiar with esprima's inner workings, but it guess it won't have any effect on the resulting AST actually.

Right, thanks. So this is then another example where tokenization doesn't deeply consider context so we rely on what the grammar defines static to be as a token regardless of whether it's used as an identifier.


Update baseURI on the Product Comparator Demo website

Description
As per below Zendesk article below, it appears I am able to request an update to the Product Comparator Demo website update via this issue repository.
https://cdr-support.zendesk.com/hc/en-us/articles/900002933263-Add-your-organisation-to-the-Banking-Product-Comparator
Please could I request our baseURI on the Product Comparator Demo website to be updated to https://public.cdr-api.bankaust.com.au/ ?
many thanks
Wendy

Hi @Wendy-BA. Sure, we can create the PR for you if you don't know how. In the meantime, could you please email us on<EMAIL_ADDRESS>so we can verify your association with Bank Australia.

Hi Vadkor, thank you for updating the Bank Australia URL in October. It has been brought to our attention that the below github location also requires updating
https://github.com/LukePrior/Australian-Open-Banking-Data-Database#list-of-current-providers---113
Please could you advise how this list can be updated for Bank Australia?
The URL should be updated to : https://public.cdr-api.bankaust.com.au/cds-au/v1
many thanks
Wendy

Hi Wendy. The list of the Open Banking data sources you are referring to is being maintained by a private entity, not affiliated with Data Standards Body / ConsumerDataStandardsAustralia. I would recommend contacting @LukePrior or raising an issue or a PR in that GitHub repository.

Hi @Wendy-BA
I've taken this opportunity to move the Australian Open Banking Data Database repository to using the Data Holder Brands Summary API so that all sources stay correct.
The repository was created before the official API was published to serve as a central source of all URLs but it is still quite popular so it's good to keep it up to date.
Thanks,
Luke


Code UI test need to be install if missing under test.

https://docs.microsoft.com/en-us/visualstudio/test/use-ui-automation-to-test-your-code#creating-coded-ui-tests
Please add in following points
I don't see the Coded UI Test project templates.
Feature can be install if missing with Visual Studio Installer in VS Enterprise Edition.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 75817b8c-177c-f5f0-2035-e18a9dd21ae3
Version Independent ID: faa7aa5a-42d6-9695-8692-31e2d13e5bc9
Content: Use UI Automation To Test Your Code | Microsoft Docs
Content Source: docs/test/use-ui-automation-to-test-your-code.md
Service: unspecified
GitHub Login: @gewarren
Microsoft Alias: gewarren

In visual studio installer, under test and debugging Codedui is not listed. what should I do?


'Unhandled exception in script' error

v1.0.1
Win 11
Transcribed about 40 minutes of conversation using the Whisper Medium model OK. Then tried same recording with the Whisper Large-v3 model. It must have nearly completed the job but produced this error.

Full text of error message.
Traceback (most recent call last):
  File "whisper\transcribe.py", line 375, in transcribe
  File "tqdm\std.py", line 1242, in update
  File "tqdm\std.py", line 1347, in refresh
  File "tqdm\std.py", line 1495, in display
  File "tqdm\std.py", line 459, in print_status
  File "tqdm\std.py", line 452, in fp_write
  File "tqdm\utils.py", line 196, in inner
  File "buzz\conn.py", line 11, in write
  File "multiprocessing\connection.py", line 206, in send
  File "multiprocessing\connection.py", line 289, in _send_bytes
BrokenPipeError: [WinError 232] The pipe is being closed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "multiprocessing\process.py", line 314, in _bootstrap
  File "multiprocessing\process.py", line 108, in run
  File "buzz\transcriber\whisper_file_transcriber.py", line 99, in transcribe_whisper
  File "buzz\transcriber\whisper_file_transcriber.py", line 202, in transcribe_openai_whisper
  File "whisper\transcribe.py", line 228, in transcribe
  File "tqdm\std.py", line 1140, in __exit__
  File "tqdm\std.py", line 1290, in close
  File "tqdm\std.py", line 1287, in fp_write
  File "tqdm\utils.py", line 196, in inner
  File "buzz\conn.py", line 11, in write
  File "multiprocessing\connection.py", line 206, in send
  File "multiprocessing\connection.py", line 289, in _send_bytes
BrokenPipeError: [WinError 232] The pipe is being closed

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "main.py", line 4, in <module>
  File "buzz\buzz.py", line 37, in main
  File "PyInstaller\hooks\rthooks\pyi_rth_multiprocessing.py", line 50, in _freeze_support
  File "multiprocessing\spawn.py", line 122, in spawn_main
  File "multiprocessing\spawn.py", line 135, in _main
  File "multiprocessing\process.py", line 329, in _bootstrap
AttributeError: 'NoneType' object has no attribute 'write'

I tried the Whisper model Large-v2 and that worked OK. So re-ran the Large-v3 and that also worked OK. So the error above looks like it was generated by something I did.

Glad it works in the end :)


File could not be dowloaded. 404: Not Found.

https://github.com/Qengineering/Face-Mask-Detection-Jetson-Nano/archive/master.zip File could not be dowloaded. 404: Not Found.

GitHub has changed the location to https://github.com/Qengineering/Face-Mask-Detection-Jetson-Nano/archive/refs/heads/main.zip


Is Dragon Diffusion as fast as DragGan? and is VRAM extensive?

Is Dragon Diffusion as fast as DragGan? and is VRAM extensive?

Thank you for your attention. Currently, there is a comparable time complexity with DragGAN, as we do not require point tracking. We will present detailed comparison with related works in our paper :）


Invalid CSV line for probes.txt

I replicate probes.txt in the example but it didn't work

The CSV standar did change?

@dragonxtek Sorry for the long delay.  I hope your issue has been resolved since you reported it back in June.
Unfortunately, we do not have resources to provide support at this point.  I think it is best to close this issue at this point unless @kvermeul has time to look into it and prefers to keep it open.

Hello @dragonxtek I guess you are missing a protocol in your lines in probes.txt?

@dragonxtek I am closing this issue.  If you are still facing problem, please open a new issue.


Custom Dialog and Translation

Hi, can Bugshaker support custom dialog and custom string resources (to support multi-language)?

Hi @ryanhoo95!
From a quick review of the library, it looks like the email subject line can be replaced with a localized version, but that's about it.
The dialog strings are currently hard-coded: https://github.com/stkent/bugshaker-android/blob/8ff33357268c151782ec934f4e5502609756d7cd/bugshaker/src/main/java/com/github/stkent/bugshaker/flow/dialog/DialogProvider.java#L26-L29
as are the email field strings: https://github.com/stkent/bugshaker-android/blob/8ff33357268c151782ec934f4e5502609756d7cd/bugshaker/src/main/java/com/github/stkent/bugshaker/flow/email/FeedbackEmailIntentProvider.java#L94-L102
Which of these strings were you looking to localize (or was it others that I missed)? I have some ideas how to proceed but would like to learn more about what your goal is first :)

Hi @stkent , I wish to customize the dialog string, as well as the whole dialog, because I customize every dialog in my app.

Ok! What do you mean by

as well as the whole dialog

What other parts of the dialog would you ideally like to be able to control/change?

Is it possible for something like this:
When init the bugshaker in Application class, we can add in a shake listenser, implement custom dialog inside the listener.

Hmm, I think I understand now. I can explore this a bit tomorrow and see whether this is feasible or not, and I'll report back here afterwards!

@stkent Thanks...

Hi @ryanhoo95,
I have created a new version of the library for you to test! Please download it from here and place it in your project's libs folder, and then temporarily replace your existing dependency on the published BugShaker with
implementation files('libs/bugshaker-release.aar')

The documentation for this version can be found here. In particular, please try out the new setCustomDialogProvider method and see if it works for your use case. Let me know the test goes, and if it's successful I can create a new release.

A quick test using the new version of the library to create a custom dialog in the sample app:

Hi stkent, Sorry for the late reply, been very busy lately. The link given returns 404. Have you already removed the project? Thanks. Best regards,Ryan Hoo Sent from Mail for Windows 10 From: Stuart KentSent: Friday, November 8, 2019 9:59 PMTo: stkent/bugshaker-androidCc: Ryan Hoo; MentionSubject: Re: [stkent/bugshaker-android] Custom Dialog and Translation (#128) Hi @ryanhoo95,I have created a new version of the library for you to test! Please download it from here and place it in your project's libs folder, and then temporarily replace your existing dependency on the published BugShaker withimplementation files('libs/bugshaker-release.aar')The documentation for this version can be found here. In particular, please try out the new setCustomDialogProvider method and see if it works for your use case. Let me know the test goes, and if it's successful I can create a new release.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.

Hi @ryanhoo95,
No worries! That temporary file-sharing site must only keep files for 24 hours or so. Here's a link that should last a little longer: https://drive.google.com/open?id=1jRtMXQpmLpzwvPKhk3ZjZ_8u98XqZLrp
Let me know if it works for you when you're able :)

Hi @ryanhoo95,
Any update on how that new version worked out for you?
Cheers!

Hey Stkent, can you share me also the link ? your library is awesome, I tried to pass a custom dialog with the dialogProvider instance the parameter is  a closure  with activity and a listener, but how can I custom the colors/strings ?

Hey Stkent, can you share me also the link ? your library is awesome, I tried to pass a custom dialog with the dialogProvider instance the parameter is  a closure  with activity and a listener, but how can I custom the colors/strings ?

Hi @Dave181295,
I haven't actually released v2.0.0 of the library yet; I'll do that tomorrow. Once that's available you should be able to customize the dialog fully.
Hope that helps,
Stuart

Hi @Dave181295,
I haven't actually released v2.0.0 of the library yet; I'll do that tomorrow. Once that's available you should be able to customize the dialog fully.
Hope that helps,
Stuart

OK, v2.0.0 is out, please try it out!
dependencies {
    implementation("com.github.stkent:bugshaker:2.0.0")
}

OK, v2.0.0 is out, please try it out!
dependencies {
    implementation("com.github.stkent:bugshaker:2.0.0")
}


fix(store): throw error if a field is missing when writing to store

To be able to debug errors in our clients properly, we are in dire need of error reports when something goes wrong. So I have changed from logging a warning only in development environment to actually throwing an error as the apollo team wants. I also added bread crumbs in the error message so it should be easier to locate the missing field.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable


Workaround for clang-cl build

Workaround for errors caused by clang-cl bug(?)

D:\work\TOWNSEMU\src\towns\memory\physmem.h(369,37): error : non-type template argument evaluates to -2147483648, which cannot be narrowed to type 'unsigned int' [-Wc++11-narrowing]
TownsVRAMAccessTemplate           <TOWNSADDR_VRAM0_BASE        ,TOWNSADDR_VRAM0_END        > VRAMAccess0;

I prefer integral types from <cstdint>, but respect current coding style.

Seriously?  It looks to be an issue of clang as you mention.  Actually I want to make townsdef.h eventually available to High-C by cplusplus macro so that towns-app sources can directly include this header in place for vmif.h.  So, I want to avoid strongly-typed enum if possible.  Are you able to get away from the errors if you use #define instead of enum?

By the way, I was not aware that stdint.h was in C99 standard.  I thought I saw many open-source projects suffering from uintXX_t issues (multiple depending libraries declare own uintXX_t types) long after 2004, but apparently stdint.h existed after 2004.  Replacing everything all at once will most likely will cause a disaster, but I'll gradually replace long long int to int64_t.  Thanks!

Thanks!  I take it.

#define TOWNSADDR_VRAM0_BASE 0x80000000 works fine with clang-cl.
On the other hand with C compiler, I think it's also safer to use #define because enum signedness is implementation-defined.
(I cannot check High C behavior at this time, but HC17UM.DOC 8.5 does not mention on unsigned types.)


Can't start server without generate config.ini through starting the server manually...

I prepared my server as far as i could with your insctructions but when i do "systemctl start factorio" it exits with a failure. After some time looking for the problem i found out that the config.ini is missing. Because i couldn't generate a .ini through starting the server manually (because it needs the ini first??)... i don't know what to do anymore. Can you help me with the ini please? Hopefully this is the only problem. factorio-init with the factorio-updater should be configured right, the factorio version is downloaded and a save also already exists.

Hi, you used to have to "init" the ini-file by starting the server manually, however with the latest addition to the script to install I seem to have omitted that from the readme, sorry =)
Is using ./factorio install an option for you? Else you can always start the server as the factorio user sudo -u factorio /path/to/factorio/bin/factorio and work your way from there.
(let me know if you rin into any snags and I'll see if I can help you along)

Thanks for your reply :)
I figured it out by myself, that i need to start the factorio file from the factorio/bin/ folder. Everything works now! (That's the first time i set up a game server on my own) Thanks for making this script!


Can not run program

Before submitting a bug report...

[X] This bug wasn't already reported.
(I have checked every bug report on GitHub)

Title

[X] The title is no longer "[BUG] Title" and I edited it with the right error name.

Describe the bug
I get error message when i run program
Copy and paste your error
Traceback (most recent call last):
File "main.py", line 9, in
from src import Browser, DailySet, Login, MorePromotions, PunchCards, Searches
File "/home/rock/Microsoft-Rewards-Farmer-master/src/init.py", line 1, in
from .browser import Browser
File "/home/rock/Microsoft-Rewards-Farmer-master/src/browser.py", line 12, in
from src.userAgentGenerator import GenerateUserAgent
File "/home/rock/Microsoft-Rewards-Farmer-master/src/userAgentGenerator.py", line 8, in
class GenerateUserAgent:
File "/home/rock/Microsoft-Rewards-Farmer-master/src/userAgentGenerator.py", line 34, in GenerateUserAgent
browserConfig: dict[str, Any],
TypeError: 'type' object is not subscriptable
rock@rock-3a:~/Microsoft-Rewards-Farmer-master$ ^C
rock@rock-3a:~/Microsoft-Rewards-Farmer-master$ python main.py -v
File "main.py", line 26
logging.exception(f"{e.class.name}: {e}")
^
SyntaxError: invalid syntax
Screenshots

Value of dashboard variable

Did you install the required files?
What version of Python are you running?
What OS are you running on?

required files I installed,python version 3.8 and i running in Ubuntu 20.04.6 LTS

required files I installed,python version 3.8 and i running in Ubuntu 20.04.6 LTS

Can you rerun this in a venv? They tend to produce more stable results.

updating to Ubuntu 22 LTS does resolve this issue.  There is some conflict on Ubuntu 20 and python.  I'm not sure how to debug that though

Run it as a non-root user

If your problem is resolved - please close this issue out.


[ingestion bug] Failure due to missing purl attribute

Describe the bug
A clear and concise description of what the bug is.
We tried to ingest sbom files (both CDX and SPDX) using the latest guacone binary (on the main branch) however it errors out for a few files. Following are the logs for the same.
"msg":"emit error: unable to assemble graphs: Node {<image-name>[sha256:95a7593269fc3344af31c8825e72da6f705dd753417581dd0391e0296ed81242] sha256:95a7593269fc3344af31c8825e72da6f705dd753417581dd0391e0296ed81242 [] [container] {file:///<file-absolute-path>.cdx.json FileCollector}} has no value for property purl","stacktrace":"github.com/guacsec/guac/pkg/handler/collector.Collect\n\t/Users/smenezes/dev/guac-exp/guac/pkg/handler/collector/collector.go:100\ngithub.com/guacsec/guac/cmd/guacone/cmd.glob..func5\n\t/Users/smenezes/dev/guac-exp/guac/cmd/guacone/cmd/files.go:169\ngithub.com/spf13/cobra.(*Command).execute\n\t/Users/smenezes/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:920\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/Users/smenezes/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:1044\ngithub.com/spf13/cobra.(*Command).Execute\n\t/Users/smenezes/go/pkg/mod/github.com/spf13/cobra@v1.6.1/command.go:968\ngithub.com/guacsec/guac/cmd/guacone/cmd.Execute\n\t/Users/smenezes/dev/guac-exp/guac/cmd/guacone/cmd/root.go:104\nmain.main\n\t/Users/smenezes/dev/guac-exp/guac/cmd/guacone/main.go:23\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:250"}
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
GUAC version
Are you using a released version of GUAC or one build from a commit in the
repository?
The one on the main branch.
Additional context
Add any other context about the problem here.

Hey @stevemenezes, this looks like an old bug (and an error message). If you are on a fork, are you working from the latest commit on the main branch?

Hey @pxp928 thanks for getting back to me. Yeah I just tried with the latest commit on the main branch too however, I'm seeing similar error messages.
emit error: unable to ingest doc tree: unable to parse purl pkg:guac/cdx/@sha256:431168b67a3f620e2cda29cdf38af300c546fa8fd7e10192905bb3ef89c36f5f?tag=latest: name is required
Also seeing unable to create entries in collectsub server, but continuing: unable to add collect entries: rpc error: code = Unavailable desc = connection error but I think nodes are being injected as seen in the graphQL playground. Is that expected? Any insights would be helpful thanks!

Would you be able to share the CDX SBOMs top-level component name? Looks like it might be an issue with how we parse the name to create the purl.
Also, unable to create entries in collectsub server, but continuing: unable to add collect entries: rpc error: code = Unavailable desc = connection error is not an issue. This is for the collector subscriber server that runs to provide more insights via deps.dev and others. This is not needed for the ingestion to be successful (so that error can be ignored for now).

sure! The component name has the following format - foo.registry.com:4443/myapp/debian:latest

@stevemenezes This PR -> https://github.com/guacsec/guac/pull/830 should fix your issue. Please give it a try and let me know. Thanks!

Just tried it worked fine except for one of the files. Now seeing this error - unable to ingest doc tree: unable to parse purl : scheme is missing

Hi, would you be able to share the top level component metadata / name of
that file? Thanks
On Tue, May 9, 2023 at 7:02 PM stevemenezes @.***>
wrote:

Just tried it worked fine except for one of the files. Now seeing this
error - unable to ingest doc tree: unable to parse purl : scheme is
missing
—
Reply to this email directly, view it on GitHub
https://github.com/guacsec/guac/issues/828#issuecomment-1541183870, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXLDBXFJCIBS6HIAUUFESTXFLZMVANCNFSM6AAAAAAX3T542U
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@stevemenezes I updated the PR with some changes to might fix this error unable to ingest doc tree: unable to parse purl : scheme is missing. Let me know if it does. If not, would you be able to share the generated SBOM for our testing?

Just tried the new changes, rebuilt the binary and I see no errors, seems like it worked!

Thanks @stevemenezes! Can you share your usecase and what you are doing/ planning to do with GUaC? Let us know if there are any features you would like to see.

For now we're playing around with our sboms to see if GUAC allows us to ingest and query the required data correctly. One thing I also noticed is that the component properties in cdx are not being ingested at all. Also the license information is missing for both spdx and cdx data. Any insights on when that would be made available would be helpful, thanks!

Yes, that is correct, we are currently not collecting all the component properties in CDX, but the license information is one of the upcoming features we will be ingesting. This is already part of the upcoming roadmap for new features we will be adding. Are their particular component properties you would like to see collected from CDX?

Timeline-wise, it should be fairly straightforward and should be added a few weeks after the beta release (which is scheduled in a week or so)

Ideally we would want to get all of the data ingested but for now we're mostly interested in syft:package:language, syft:location:0:layerID, syft:package:type. Will also check with the team and keep you posted.

Hey @pxp928 yes we're putting together a doc listing the gaps we've encountered and would like to discuss with you about the same. Will keep you posted once it's ready thanks!


Failure of dependency scan via OWASP DC v 5.2.2. with proxy server

Hi team,
Could you please check the snapshot attached and let us know the reason for failure of dependency scan via OWASP DC v 5.2.2.
We have set the proxy server properly in the Linux box and are able to wget the nvd website.

the reason for failing analysys is: the tool cannot download the vulnerability database.
probably you have not setup proxy in the tool or for the user running the tool or the proxy is doing something wrong, but you really have not provided enough information. At least show us the env for the user and the python script.

The content of the python file is as follows:
import os
import time
import argparse
from datetime import datetime
os.chdir("/opt/Jenkins/dependency-check-5.2.2-release/dependency-check/bin")
date_time = datetime.now().strftime("%m%d%Y%H%M%S")
class DCT:
def __init__(self,inpath,outpath,project):

    self.inpath = inpath
    self.outpath = outpath
    self.project = project

def dependencyRunCommand(self):

    try:
        cmd = './dependency-check.sh --project "'+ self.project +'" --enableExperimental \
              --enableRetired --disableAssembly --scan "'+ self.inpath +'" --out "'+ self.outpath +'" \
              --format "ALL" --proxyserver "xxxxx" --proxyport "xxx" --proxyuser "\
              xxxxx" --proxypass "xxxx"'
        os.system(cmd)
        raise Exception

    except Exception as e:
        print(e)

Even I tried running the dependency-check.sh alone in the terminal as follows:
./dependency-check.sh --project "xxxx" --enableExperimental --enableRetired --scan "/opt/Jenkins/workspace/xxxxx" --out "/opt/Jenkins/workspace/xxxxx/xxx" --format "ALL" --proxyserver "xxxx" --proxyport "xxxx" --proxyuser "xxxx" --proxypass "xxxx"
Both of these gave the same out come as depicted in the screen shot provided earlier.

This is a good article for resolving this type of connectivity error (yes, this applies even though we aren't using an 'Atlassian' product): https://confluence.atlassian.com/kb/unable-to-connect-to-ssl-services-due-to-pkix-path-building-failed-error-779355358.html

Yes we have done the needfull . But still getting same error.

Maybe this debug option helps analysing the cause of the problem:
export JAVA_OPTS=-Djavax.net.debug=ssl

@a6k8s4 you only show wget (which uses Linux CA truststores) and the dependency-check call without custom trust-stores, which uses Java CA truststores). Did you actually try running the SSLPoke class until that managed to successfuly run as described in the Atlassian article that jeremylong referenced?
Gut feel: your proxy acts as a MITM to allow scanning traffic for suspicious (virus, malware) traffic and re-encrypts traffic with an untrusted certificate (issued automatically by a internal CA of the proxy) for which you didn't add the CA root cert to the CA trust store of the JVM that runs dependencycheck.

Thank you all for the explanations and it worked out for us.


docs(lifecycle): correct number of arguments

Description

Just only Documentation. 🥳
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Thanks for the correction, I added it manually to main branch 🔥

LGTM!
But.
Is this a mistake or an accident, as in the picture from "https://developers.raycast.com/information/lifecycle/arguments"

It's a bit confusing, let me try to explain the flow:

You make the PR on main branch

On merge, main pushes changes to gh-pages

If you push to gh-pages, then it will overwrite next time something is merged from main

I got.😀
I mean, "Edit on Github" on the documentation site points to the gh-pages branch. Is this the right?
What I'm wondering is: since I should open “PR” to the main branch, should this “Edit on Github” point to the main branch.
I think I know why, and it's because of the relationship between main/docs and gh-pages. and gitbook base on gh-pages branch. So "Edit on Github" points to the gh-pages branch

That's correct, it should indeed show the main branch, but it's not what it's built on 🙂


fix: Uncompress compressed layer until EOF

The CompressorStreamFactory used did not specify, that the compression library should read until the end of the input file. This caused broken compressed layer digests, as the digest was calculated only on a part of the stream.
Thank you for your interest in contributing! For general guidelines, please refer to
the contributing guide.
Before filing a pull request, make sure to do the following:

[x] Create a new issue at https://github.com/GoogleContainerTools/jib/issues/new/choose.
[ ] Ensure that your implementation plan is approved by the team.
[ ] Verify that integration tests and unit tests are passing after the change.
[ ] Address all checkstyle issues. Refer to
the style guide.

This helps to reduce the chance of having a pull request rejected.
Fixes #3982 🛠

Thank you for the contribution!


The brightness bar and volume bar color rendering error after the lower right control bar is expanded

[ ] I've read FAQ.
[ ] This bug keeps occurring
Describe the bug
Originally pink, it has been like this since updating the beta channel of 22624.1391
To Reproduce
Click to expand the control bar and it will appear
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Windows Version
Windows 11 Build 226241391 Insider beta channel

MFE doesn't have the ability to modify XAML UI elements last I remember.

Is it like this when MFE is not running?


Zenodo/DOI

So I have an action on me to make releases and mint DOIs for this and the other two repos via Zenodo. However they don't show up on my list, even though I am an admin for these repos (which is what I'm led to understand is needed). And I don't really want to pull them them to my repo then mint them because that isn't quite the point of version control...
@jamespjh: as you set these repos up, can you see them on Zenodo? (I think I heard you mention earlier that you use Zenodo...) If not, we may need to ask Arfon.

Any thoughts on this?