Error in HTML publishing if any topic has apostrophe in its name

Create a topic with apostrophe in its name e.g. i'm_topic.dita. Put it in ditamap and publish.
PDF works fine but xhtml and html5 give NullPointerException.

Indeed a NPE can be obtained with DITA OT 3.0, also with 2.5.2:
        BUILD FAILED
        C:\Users\radu_coravu\Desktop\DITA OT newest\dita-ot-3.0\build.xml:197: The following error occurred while executing this line:
        C:\Users\radu_coravu\Desktop\DITA OT newest\dita-ot-3.0\plugins\org.dita.xhtml\build_general.xml:170: The following error occurred while executing this line:
        C:\Users\radu_coravu\Desktop\DITA OT newest\dita-ot-3.0\plugins\org.dita.xhtml\build_general.xml:128: java.lang.NullPointerException
        	at org.dita.dost.ant.types.JobMapper.mapFileName(JobMapper.java:83)
        	at org.dita.dost.module.XsltModule.execute(XsltModule.java:110)
        	at org.dita.dost.ant.ExtensibleAntInvoker.execute(ExtensibleAntInvoker.java:163)
        	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
        	at sun.reflect.GeneratedMethodAccessor6.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        	at java.lang.reflect.Method.invoke(Unknown Source)
        	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
        	at org.apache.tools.ant.Task.perform(Task.java:348)
        	at org.apache.tools.ant.taskdefs.Sequential.execute(Sequential.java:68)
        	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
        	at sun.reflect.GeneratedMethodAccessor6.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        	at java.lang.reflect.Method.invoke(Unknown Source)
        	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
        	at org.apache.tools.ant.Task.perform(Task.java:348)
        	at org.apache.tools.ant.taskdefs.MacroInstance.execute(MacroInstance.java:402)
        	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
        	at sun.reflect.GeneratedMethodAccessor6.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        	at java.lang.reflect.Method.invoke(Unknown Source)
        	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
        	at org.apache.tools.ant.Task.perform(Task.java:348)
        	at org.apache.tools.ant.Target.execute(Target.java:435)
        	at org.apache.tools.ant.Target.performTasks(Target.java:456)
        	at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405)
        	at org.apache.tools.ant.helper.SingleCheckExecutor.executeTargets(SingleCheckExecutor.java:38)
        	at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
        	at org.apache.tools.ant.taskdefs.Ant.execute(Ant.java:441)
        	at org.apache.tools.ant.taskdefs.CallTarget.execute(CallTarget.java:105)
        	at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
        	at sun.reflect.GeneratedMethodAccessor6.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
        	at java.lang.reflect.Method.invoke(Unknown Source)
        	at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
        	at org.apache.tools.ant.Task.perform(Task.java:348)
        	at org.apache.tools.ant.Target.execute(Target.java:435)
        	at org.apache.tools.ant.Target.performTasks(Target.java:456)
        	at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1405)
        	at org.apache.tools.ant.Project.executeTarget(Project.java:1376)
        	at org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
        	at org.apache.tools.ant.Project.executeTargets(Project.java:1260)
        	at org.apache.tools.ant.Main.runBuild(Main.java:857)
        	at org.apache.tools.ant.Main.startAnt(Main.java:236)
        	at org.apache.tools.ant.launch.Launcher.run(Launcher.java:287)
        	at org.apache.tools.ant.launch.Launcher.main(Launcher.java:113)

Unable to reproduce with hotfix/3.0.2on OS X.

I can still reproduce the NPE on Windows. I patched the code and added some logging.
So for a topic called "i'm_topic.dita" (without the quotes) the .job.xml adds an entry like:
    <file src="file:/D:/projects/eXml/samples/dita/flowers/topics/i'm_topic.dita"
        uri="topics/i'm_topic.dita" path="topics\i'm_topic.dita"
        result="file:/D:/projects/eXml/samples/dita/flowers/topics/i'm_topic.dita" format="dita"
        target="true"/>

The method "org.dita.dost.ant.types.JobMapper.mapFileName(String)" receives a "sourceFileName" param with value "topics\i'm_topic.dita", creates from it an URI like "topics/i%27m_topic.dita" and then tries to find it in the ".job.xml", turning up with no mapping for it.

+1 Another end user encountered the same problem

👍 And yet another one of our end users encountered the same problem.

Still get the same NPE in DITA OT 3.1.2, @robander can you reproduce this problem on your Windows installation?

@raducoravu yes, just tried this and I can reproduce the NPE with html5 build from develop. PDF output is OK.

👍 Another one of our clients experienced this problem.

👍 One of our QA team encountered this problem again because they had an apostrophe in a DITA file name.

I just encountered this. it took a while to track down the error. I'd like to have a check and an informative error message for this, please, if it's not too much trouble

+1 we had another end user with a file name with apostrophe in its name.

+1 another one of our clients was using " what's_new_installation.dita" as the name of a file and this produced the NPE.

I can no longer reproduce this problem with DITA OT 3.6. Can somebody else test this with DITA OT 3.6 just to double check?

Actually I can still reproduce the problem with 3.6.1 publishing to HTML5:
/Users/r../dita-ot-3.6.1/plugins/org.dita.base/build.xml:29: The following error occurred while executing this line:
/Users/../dita-ot-3.6.1/plugins/org.dita.html5/build_dita2html5.xml:125: The following error occurred while executing this line:
/Users/..dita-ot-3.6.1/plugins/org.dita.html5/build_dita2html5.xml:157: java.lang.NullPointerException
at org.dita.dost.ant.types.JobMapper.mapFileName(JobMapper.java:79)

Re-attaching test samples:
testApos.zip

👍 One of our end users encountered this problem, they have an "User's Guide" folder with topics inside it.

@jlacour31 are you able to test that #3880 fixed this?

@jlacour31 are you able to test that #3880 fixed this?

I created a unit test that runs html5 transformation on ditamap and topics having apos in their names. The test did succeed.


Consider making verbs in HttpMethods as const string rather than static readonly string

When I am trying to use AcceptVerbsAttribute, I don't want to write verbs literally (e.g. [AcceptVerbs("GET", "POST")]) so I try to reuse the verbs defined in HttpMethods (e.g. [AcceptVerbs(HttpMethods.Get, HttpMethods.Post)]). But this is not acceptable by compiler.
How about making verbs in HttpMethods as const string rather than static readonly string so that they can be more widely used?

This has been discussed before; https://github.com/aspnet/HttpAbstractions/pull/712#issuecomment-250192311

@khellang Thanks for pointing it out. Let me close this issue.


Error while installing with pip

I tried to install it with pip on MacOS
pip3 install flask-mysqldb

This is what I got in return:
$ pip3 install flask-mysqldb
Collecting flask-mysqldb
  Using cached Flask-MySQLdb-0.2.0.tar.gz (2.1 kB)
Requirement already satisfied: Flask>=0.10 in /Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/site-packages (from flask-mysqldb) (1.1.2)
Collecting mysqlclient
  Using cached mysqlclient-2.0.1.tar.gz (87 kB)
    ERROR: Command errored out with exit status 1:
     command: /Library/Frameworks/Python.framework/Versions/3.8/bin/python3.8 -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/var/folders/sf/g8jsr5hx61707p3x_l30042r0000gn/T/pip-install-lww9m60l/mysqlclient/setup.py'"'"'; __file__='"'"'/private/var/folders/sf/g8jsr5hx61707p3x_l30042r0000gn/T/pip-install-lww9m60l/mysqlclient/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /private/var/folders/sf/g8jsr5hx61707p3x_l30042r0000gn/T/pip-pip-egg-info-geftj76p
         cwd: /private/var/folders/sf/g8jsr5hx61707p3x_l30042r0000gn/T/pip-install-lww9m60l/mysqlclient/
    Complete output (12 lines):
    /bin/sh: mysql_config: command not found
    /bin/sh: mariadb_config: command not found
    /bin/sh: mysql_config: command not found
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/private/var/folders/sf/g8jsr5hx61707p3x_l30042r0000gn/T/pip-install-lww9m60l/mysqlclient/setup.py", line 15, in <module>
        metadata, options = get_config()
      File "/private/var/folders/sf/g8jsr5hx61707p3x_l30042r0000gn/T/pip-install-lww9m60l/mysqlclient/setup_posix.py", line 65, in get_config
        libs = mysql_config("libs")
      File "/private/var/folders/sf/g8jsr5hx61707p3x_l30042r0000gn/T/pip-install-lww9m60l/mysqlclient/setup_posix.py", line 31, in mysql_config
        raise OSError("{} not found".format(_mysql_config_path))
    OSError: mysql_config not found
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

Please respond to the earliest

Getting the same error 🥲🥲

@japrozs @HarunMbaabu https://github.com/alexferl/flask-mysqldb/issues/22#issuecomment-653775776


cmd/containers: End loop early when using the json option

Signed-off-by: Zhou Hao<EMAIL_ADDRESS>

LGTM
@TomSweeneyRedHat PTAL


grizzly: 0.4.1-0 in 'kinetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository grizzly to 0.4.1-0:

upstream repository: https://github.com/g/grizzly.git
release repository: https://github.com/clearpath-gbp/grizzly-release.git
distro file: kinetic/distribution.yaml
bloom version: 0.6.4
previous version for package: 0.4.0-0

grizzly_control

No changes

grizzly_description
* Updated urdf (#21 <https://github.com/g/grizzly/issues/21>)
  * Updated urdf to have both sensor arches, all standard sensors, and some non-standard sensors
  * URDF formatting
* Contributors: dniewinski

grizzly_msgs

No changes

grizzly_navigation

No changes

Holding for sync: https://discourse.ros.org/t/preparing-for-kinetic-sync-2018-06-20/5153

Closing for newer version.


Add organized CSS color vars

Feature Description
Colour variables are currently just the colour and a number (e.g. --yellow-400). This makes it hard to quickly implement new themes. Currently, all components seem to reference raw colour variables directly.
Goal of Feature
Adding a hierarchy for CSS colour variables is an important part of a design system. This allows for more readable/maintainable code and can be used to allow users to set their own (custom) themes.
Proposed Solution
We should organize the colour variables hierarchically, such as:

Raw (hexcodes, RGB)
Semantic (primary, secondary, etc)
Component (text-color, button-background, etc)

This way, we limit the usage of raw colour values, and instead, use semantic-based and component-based colour names. Consideration should be made to the naming schemes for these semantic-based and component-based tokens.
Examples/Screenshots
:root {
    /* Raw */
    --white: #fff;

    /* Theme (Semantic) */
    --primary: var(--white);

    /* Component */
    --font-color: var(--primary)
}

Are you interested in contributing this feature?
Sure, I can contribute to this.

This is definitely a good thing we want to do. We also want to do a bunch of other things related to the design system more generally, such as having standard css classes that we use in all our components to keep them consistent.
We're hoping to get to this early next year. Going to create a new label for this.


iOS remote files immediately stopping for "longer" audio files

So I'm running into a weird issue on iOS only where when I try to play a remote file, it will "start" but then immediately stop before playing any audio (I can tell this by printing out the player state when it changes). But here's what's kind of weird:  This will only happen when trying to listen to an audiofile that's longer than about 30 seconds that was recorded on android (recorded with flutter sound).  Files will play just fine in any other combo (ie. remote files longer than 30 seconds recorded on iPhone play just fine, remote files shorter than 30 seconds recorded on android play fine).
Not sure what else to try and troubleshoot since it seems like the player is working fine in all cases but this one. I'm not getting any errors from the player, its just changing state to playing for a couple seconds without actually starting audio and then stopped.
 Please edit this, or open a new one and please follow the issue template.
Feel free to comment here and we can re open this eventually.


docs: added SkipToContent section to GlobalPage story

Overview

Adds a SkipToContent section to the GlobalPage story

This was crashing the first time I tried it but isn't now. 🤷
PR Checklist

~[ ] Related to designs:~
[x] Related to JIRA ticket: ABC-123
[x] I have run this code to verify it works
[x] This PR includes unit tests for the code change

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60be08bb0136238de9643b6b--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60bf78f30b4b37293e699146--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://60bf7c79d47e87300f9d080f--gamut-preview.netlify.appDeploy Logs


Discord Server

In our discord server, we will tell every update on the skin changers, malwares and updates with league. We have a great support team and we will always help you with the skin changer. We have 1 in our Links channel.
https://discord.gg/QhSsahfR
If you can't verify send me a DM.

Link does not work

Very toxic server from what it seems, you can see for yourself just by the name of it. Also freely uses the R word and who knows what else.

Do not promote or share any binaries/discords in this repository.


Filter out pods by selector

Describe the solution you'd like
Is there a way to filter out some kind of pod that fails, but not all in the namespace ? A particular pod of mine has often a fail in readiness, I don't want to have notifications for it...
If it's possible using botkube filters, please provide an exemple :smile:

Hey @bcouetil,
It is possible to filter notification for specific resources using annotations. Please check https://www.botkube.io/usage/#filter-events-using-annotations.

thank you for your quick response :heart:
My bad, I did not think of this approach, so missed this part of documentation :sweat_smile:


Programatically creating a dlib XML file for parsing icons

Hi all,
I want to create a custom object detector for detecting icons in a network topology diagram. These icons represent various network elements like routers, switches etc.
I have organized the images into various folders that match the names of device classes. For example,  icons representing various models of switches have been placed in a folder called switch.
Is there a way that I can programmatically generate the dlib xml file to detect these icons?
The icons are clean images and the entire image has to go into the model.
I did try searching for a XML  specification but have been unable to find one.
I cannot use the imglab tool because I am blind and the tool involves using the mouse to draw the borders of objects.
Note:
If you want to see the icons, then please grab the library from the following link.
https://www.cisco.com/c/en/us/about/brand-center/network-topology-icons.html
Pranav

You want to use the methods here http://dlib.net/ml.html#load_image_dataset_metadata which load and save dataset objects to and from that XML format.

Hi Davis,
Many thanks. I understand the format. I have been able to generate a XML file containing a stub  using the commandline options of the imglab tool.
I was looking at the commandline options of that tool and found the --box-images option which fits a single image to a single box.
I think this will do what I want and I will not have to write any code.
If I am right, how should I organize my files for them to be populated into the xml file?
As of this writing, my data set is in a folder called images. Under the images folder, I have various folders like router, switch, telecom etc. In each of these folders, there are a number of *.jpg files.
Otherwise, I will begin writing code  to add the relevant tags to the xml stub.
Pranav

I'm not sure I understand what you are trying to do.  It sounds like you are able to make the XML file you want.

Hi Davis,
Indeed, I have been able to draw the bounding boxes around the  images automatically therefore no need to mess with the GUI and the mouse. My problem is solved.


baremetal: patch kube-system host-etcd real info

ep/host-etcd of the kube-system namespace is watched by the
cluster-kube-apiserver-operator to update storageConfig.urls.
Without this, errors such as the following are normal:
W0328 12:54:56.070253       1 clientconn.go:944] grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: Error while dialing dial tcp: lookup etcd-0.dev1.kni.lab.eng.bos.redhat.com on <IP_ADDRESS>:53: no such host"; Reconnecting to {etcd-0.dev1.kni.lab.eng.bos.redhat.com:2379 0  <nil>}

It worked on the baremetal deployment:
[notstack@dev1 dev-scripts]$ oc -n kube-system get ep/host-etcd -o yaml
apiVersion: v1
kind: Endpoints
metadata:
  annotations:
    alpha.installer.openshift.io/dns-suffix: dev1.kni.lab.eng.bos.redhat.com
  creationTimestamp: 2019-03-28T21:36:49Z
  name: host-etcd
  namespace: kube-system
  resourceVersion: "950"
  selfLink: /api/v1/namespaces/kube-system/endpoints/host-etcd
  uid: 981b754b-51a1-11e9-b291-164dea3362fb
subsets:
- addresses:
  - hostname: etcd-u03
    ip: <IP_ADDRESS>
  - hostname: etcd-u04
    ip: <IP_ADDRESS>
  - hostname: etcd-u05
    ip: <IP_ADDRESS>
  ports:
  - name: etcd
    port: 2379
    protocol: TCP


[BUG] Handle empty filters on nestjsx/crud data provider

Description:
There is an issue in the handleFilter.ts file where filter handling may be improved. The current code does not properly check if the filters variable is a non-empty array, which may lead to unexpected behavior or errors.
Location:
https://github.com/refinedev/refine/blob/b07e95bbb24aaabed320810cd3c25a7132e172b4/packages/nestjsx-crud/src/utils/handleFilter.ts#L39
Proposed Fix:
Update the condition at line 39 in handleFilter.ts to the following:
if (Array.isArray(filters) && filters.length > 0) {

Hey @dfliess thank you for reporting this. Does this check cause any issues for you? Does passing an empty array of filters cause any unwanted chars in the query or in the request body?
Do you want to work on this one? We'll be happy to see your PR 🚀 Please check our Contributing Guide to get started 👏


HTML: Create Content for the 'About Us' page

Some brief info on each team member's background.  Other interesting facts could include a favorite food, first computer, cool bucket list item, etc.

Jeff did a great job completing this page


Problem during installation

ERROR: failed to register layer: devmapper: Error mounting '/dev/mapper/docker-9:2-1051856-27a2b88e520cd62629c407144a97a05a13eb9c8f0b70bdf322821038364a3f7b' on '/var/lib/docker/devicemapper/mnt/27a2b88e520cd62629c407144a97a05a13eb9c8f0b70bdf322821038364a3f7b': invalid argument
Do you have an idea ?
Environment : ubuntu 16.04, docker 1.12.1 and docker-compose 1.8.0

Issue with docker installation, closing.


Add elixir to third party implementations list

Thanks for putting all the work into this. I just wanted to add our elixir implementation to the list.

Thanks for this! Could you please include the portion of the pull request template regarding the license?


ImportError: Cannot open shared object file: No such file or directory

tried to run "sudo python ImportList.py ~/Downloads/spotify-music.txt" and get this:
Traceback (most recent call last):
  File "ImportList.py", line 8, in <module>
    from common import *
  File "/home/edson/Downloads/gmusic-playlist-master/common.py", line 9, in <module>
    from gmusicapi import __version__ as gmusicapi_version
  File "/usr/local/lib/python2.7/dist-packages/gmusicapi-10.1.1rc1-py2.7.egg/gmusicapi/__init__.py", line 4, in <module>
    from gmusicapi.clients import Webclient, Musicmanager, Mobileclient
  File "/usr/local/lib/python2.7/dist-packages/gmusicapi-10.1.1rc1-py2.7.egg/gmusicapi/clients/__init__.py", line 4, in <module>
    from gmusicapi.clients.webclient import Webclient
  File "/usr/local/lib/python2.7/dist-packages/gmusicapi-10.1.1rc1-py2.7.egg/gmusicapi/clients/webclient.py", line 16, in <module>
    from gmusicapi.clients.shared import _Base
  File "/usr/local/lib/python2.7/dist-packages/gmusicapi-10.1.1rc1-py2.7.egg/gmusicapi/clients/shared.py", line 7, in <module>
    from gmusicapi.utils import utils
  File "/usr/local/lib/python2.7/dist-packages/gmusicapi-10.1.1rc1-py2.7.egg/gmusicapi/utils/utils.py", line 24, in <module>
    from google.protobuf.descriptor import FieldDescriptor
  File "/usr/local/lib/python2.7/dist-packages/protobuf-3.2.0rc1-py2.7.egg/google/protobuf/descriptor.py", line 46, in <module>
    from google.protobuf.pyext import _message
ImportError: libprotobuf.so.12: cannot open shared object file: No such file or directory

double check that the gmusicapi dependencies are getting installed correctly.
in particular check the protobuf dependency.  try installing it via pip, some distros may have it available via their package management,  or building and installing it from source.
after all the dependencies have been installed,  you should be able to run the scripts.  when running the playlist scripts you shouldn't need to use sudo


Moving FAQ unshare  histories

Hi!
I am moving FAQ unshare histories.

This FAQ has been finalized in another PR #3372 and has been merged so we can close this issue. Thanks!


Refine .gitattributes to reflect current content of repository

This also removes the git+svn cruft.

Cheers!


Flex theme and resize columns

I'm creating the pull-request to keep all discussion in the same place, but let's merge it in only after everything is done.

Nice! Some great work here! :tada:
I'm not really sure about the "container" property. Using it means more markup versions, and more theme versions (like for the bin theme). So it would be hard to maintain.
I think the better approach would be to only use the CSS theme for it, and not use the container property.
Can you try refactoring the flex theme to work with the default markup?
The colexpand plugin looks great so far! I'll take another look at it after you finish it up.

Yep, maintenance does get complicated with more container types. I knew it from the beginning, it's just that I needed something working quickly to check what's your feedback on it. I'll get some time to work on this refactoring. Thanks!

Hello @ghinda,
I tried and tried but I found it very hard to style both cases with the flexbox container with a template that doesn't duplicates any kind of code - The cases are: a bar where you can change the current pane (like it works today); and panes that are always visible and easily repositioned with flexbox.
When having a template with a ul, it's difficult to reposition code panes where I want.
When not having a ul in the template, it's difficult to create a selection pane bar.
My decision then was to have both in the template, so it's responsibility of the theme's creator to hide and show the option they want. The default display attribute of the new .jotted-pane-title is none. In case of creating a new flexbox theme, is enough to hide the .jotted-nav and show the jotted-pane-title.

I also improved the colexpand plugin to support the console plugin and to use percentage widths on the panes.

Let's approach this a bit differently then.
Since the colexpand plugin requires flex-theme to work, what do you think about merging everything into the plugin?
That would mean:

When the plugin is constructed, manipulate the DOM to insert the new nodes you need (eg. jotted-title). You're already doing some of that now.
Instead of src/themes/flex.styl, you would have plugins/colexpand.styl. Also change the class to jotted-plugin-colexpand in the CSS. Jotted automatically adds the class to the container, it does so for every plugin (eg. jotted-plugin-$NAME).

Some advantages:

We don't need the container property
We don't need to specify the theme when using the plugin
No changes required in core
Easier to maintain

There you go... I like your suggestions, it is clean to keep everything packaged in the plugin. So there's nothing to do once you set the plugin in. Thanks

Awesome work! :beers: x 10 :shipit:
I renamed the plugin to pen since it brings a codepen-like layout, and made a couple of tweaks to keep everything in the plugin files and not have to make any changes to core.
A quick tip about the CSS: please use vanilla CSS in the future. I'm using Stylus just for nib and bundling files. So no nesting, semicolonless-ing, variables, etc..
Thanks!

And released as 1.5.0.


Accessibility Issue: Screen Reader not properly announcing expanded Menu

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
If you create a menu and apply the proper aria properties, the screen reader does not properly announce when the menu is expanded.  The screen reader announces the menu is collapsed however.
I have verified with NVDA (Windows) and the OS X VoiceOver.
Expected behavior 🤔
The screen reader should announce when menu is expanded by clicking the related button or pressing enter via the keyboard.
Steps to reproduce 🕹
Steps:

Go to https://mui.com/material-ui/react-menu/ and observe the Basic Menu example.
Use the CodeSandBox button to run the code associated with the button and menu (https://codesandbox.io/s/u2u8cx?file=/demo.js)
Using a Screen Reader (i.e. NVDA with Windows), you will notice the menu is initially announced as COLLAPSED (which is correct).
Click the button or press enter on the button.  You will notice the screen reader does not announce the menu as EXPANDED.  However, the aria-expanded property is properly set.

Context 🔦
No response
Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Thanks for the report. Can you please share a benchmark you've used for how it should behave? We use https://www.w3.org/WAI/ARIA/apg/patterns/menubutton/ as a reference for the behavior & aa1y.

hi @mnajdova .  Thanks for the response.  I believe the benchmark you are using is correct.  When the menu is opened, the aria-expanded is properly set but neither NVDA (windows) or VoiceOver (OS X) reads the expanded property.  I am not sure if it concerns the menu taking focus or some sort of timing issue concerning a state change.  Originally I believed it was my local code but the same issue occurs with the MUI example code listed above.  What do you think?

@mnajdova Hi.  Here is a screenshot of NVDA after the menu is expanded.  You can see it is not reported as expanded
https://ibb.co/Jx9yggk

i highly suspect that the problem is that the aria-expanded and aria-controls attributes are not used according to the spec.
aria-expanded
spec: https://www.w3.org/TR/wai-aria-1.1/#aria-expanded
These are its possible values:

true = The element, or another grouping element it controls, is expanded.
false = The element, or another grouping element it controls, is collapsed.
undefined = The element, or another grouping element it controls, is neither expandable nor collapsible; all its child elements are shown or there are no child elements.

in both the docs and the sandbox, when the menu is collapsed, the value of aria-expanded is undefined. i know that's what the patterns site recommends (https://www.w3.org/WAI/ARIA/apg/patterns/menubutton/), but the spec must take precedence. thus, when the menu is collapsed, we should use aria-expanded="false".
aria-controls
spec: https://www.w3.org/TR/wai-aria-1.1/#aria-controls
aria-controls is an ARIA property. unlike states, properties usually stay the same, unless there's a good reason for them to change. in this case, the only reason for aria-controls to change would be if the button was to suddenly control a different menu.
in both the docs and the sandbox, when the menu is collapsed, the value of aria-controls is undefined. the correct behavior would be to use the same value as when it is expanded: aria-controls="basic-menu".
caveats
i don't have a windows machine available right now, so can you @sforehand check if my changes fix the problem on NVDA? also, can you tell us what browser (including its version) you were using? i suspect that something about either NVDA itself or NVDA + whatever browser is triggering the following parallel logics:

"oh hey, here's a button with aria-popup but no aria-expanded or aria-controls" --> "sure, i'll treat it as a collapsed menu button"
"oh hey, here's a button with no aria-expanded --> "i surely don't need to keep an eye of it in case it becomes expanded"

on the other hand, i did test this on VoiceOver (both macOS and iOS, latest Chrome version) and in both cases i found the behavior that i would have expected if i had never read this issue in the first place: the button is initially not announced as expanded or collapsed (since it doesn't have aria-expanded), and is then announced as expanded once aria-expanded="true". so the behavior you encountered might have been the fault of the browser only, and not any of the screen readers... i recommend further testing with multiple screen readers and browsers.

in both the docs and the sandbox, when the menu is collapsed, the value of aria-controls is undefined. the correct behavior would be to use the same value as when it is expanded: aria-controls="basic-menu".

If I remember correctly, this was changed so that the aria-controls won't reference an element that doesn't exists, for example when the menu is hidden (it is not rendered, not just hidden).

If I remember correctly, this was changed so that the aria-controls won't reference an element that doesn't exists, for example when the menu is hidden (it is not rendered, not just hidden).

ah, i see. while that approach is technically acceptable in this case, it's not what i would recommend. it's a better practice to have the aria-controls point by ID to an element that always exists regardless, and only toggle the rendering of its contents according to whether the element is expanded or collapsed. for two reasons:

it allows user agents to build the accessibility tree in the correct way (because the controls/controlled relationship is always available).
it works in situations where the presence of aria-controls is required (namely, with the combobox and slider roles).

it's a better practice to have the aria-controls point by ID to an element that always exists regardless, and only toggle the rendering of its contents according to whether the element is expanded or collapsed.

Ah nice, it's a great alternative. I learned something new today :D @michaldudak it may be worth testing this approach in MUI Base and updating if it works better.
If anyone wants to take a stab and try applying this fix in Material UI, I would be happy to review it.


Polarity in flattened embedded relations

From sentences that fit the pattern A prevents B by C, we would normally expect to see two causal relations: A -> B(-) and C -> B(+?), where (-) stands for negative polarity, and (+?) stands for positive or no polarity. However, Eidos currently produces A->B(-), and C->B(-).
Here is an example with a real sentence using the webapp off the latest master:
Found Relations:
List(Causal, DirectedRelation, EntityLinker, Event) => floods prevent farming
     ------------------------------
     Rule => ported_syntax_1_verb-Causal
     Type => EventMention
     ------------------------------
     trigger => prevent
     effect (Concept, Entity) => farming
     * Attachments: Decrease(prevent,None)
     cause (Concept, Entity) => floods

     ------------------------------

List(Causal, DirectedRelation, EntityLinker, Event) => prevent farming by farmers
     ------------------------------
     Rule => advcl_by_verb-Causal
     Type => EventMention
     ------------------------------
     trigger => prevent
     effect (Concept, Entity) => farming
     * Attachments: Decrease(prevent,None)
     cause (Concept, Entity) => farmers

     ------------------------------

Note the Decrease attachment in the second relation which I don't think should be there.

Thanks @bgyori !
I think we need to add a higher priority rule for A ${inhibittrigger} B by C.
@BeckySharp: are you up for adding it?


Batch Size for Chat Models

Previously, for standard language models setting batch_size would control concurrent LLM requests, reducing the risk of timeouts and network issues (https://github.com/hwchase17/langchain/issues/1145).
New chat models don't seem to support this parameter. See the following example:
from langchain.chat_models import ChatOpenAI

chain = load_summarize_chain(ChatOpenAI(batch_size=1), chain_type="map_reduce")
chain.run(docs)

File /usr/local/lib/python3.9/site-packages/openai/api_requestor.py:683, in APIRequestor._interpret_response_line(self, rbody, rcode, rheaders, stream)
    681 stream_error = stream and "error" in resp.data
    682 if stream_error or not 200 <= rcode < 300:
--> 683     raise self.handle_error_response(
    684         rbody, rcode, resp.data, rheaders, stream_error=stream_error
    685     )
    686 return resp

InvalidRequestError: Unrecognized request argument supplied: batch_size

Is this intentional? Happy to cut a PR!

Might be related to https://github.com/hwchase17/langchain/pull/1463

any progress on this?


grype: 0.73.5 -> 0.74.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/anchore/grype/releases.
meta.description for grype is: Vulnerability scanner for container images and filesystems
meta.homepage for grype is: https://github.com/anchore/grype
meta.changelog for grype is: https://github.com/anchore/grype/releases/tag/v0.74.0
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.74.0 with grep in /nix/store/2aplnwfx92rqr5hf7qx258hs6sm64rml-grype-0.74.0
found 0.74.0 in filename of file in /nix/store/2aplnwfx92rqr5hf7qx258hs6sm64rml-grype-0.74.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
grype

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/2aplnwfx92rqr5hf7qx258hs6sm64rml-grype-0.74.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A grype https://github.com/r-ryantm/nixpkgs/archive/eb8ace4263d243fff3c22ed2f1e65077241645e3.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/eb8ace4263d243fff3c22ed2f1e65077241645e3#grype

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/2aplnwfx92rqr5hf7qx258hs6sm64rml-grype-0.74.0
ls -la /nix/store/2aplnwfx92rqr5hf7qx258hs6sm64rml-grype-0.74.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

grype

Maintainer pings
cc @fabaff @06kellyjac @kashw2 for testing.

superseded by https://github.com/NixOS/nixpkgs/pull/279203?notification_referrer_id=NT_kwDOAPHvULM4OTkwMDk0NjMwOjE1ODU1NDQw#event-11410805796


Format worker logs in production

Context
We use SemanticLogger to format our logs so that they can be queried in Logit.io. The web pod logs are formatted correctly but the sidekiq worker pods are not, specifically the message value, it's not decoded
This commit fixes this so that we can query logs in Logit
Changes proposed in this pull request
Changed production env. This is inspired by teacher vacancies production config their logs are in the correct format
Guidance to review
Visit logit and check the app.message content, it should be correctly formatted

Before
After

Message format

Before
After

Things to check

[ ] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[ ] This code does not rely on migrations in the same Pull Request
[ ] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[ ] If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
[ ] API release notes have been updated if necessary
[ ] If it adds a significant user-facing change, is it documented in the CHANGELOG?
[ ] Required environment variables have been updated added to the Azure KeyVault
[ ] Inform data insights team due to database changes
[x] Make sure all information from the Trello card is in here
[x] Rebased main
[x] Cleaned commit history
[x] Tested by running locally
[x] Add PR link to Trello card

 Fix logs in LOGIT for Apply


redux devtools Chrome extension

I have tried using the https://github.com/zalmoxisus/redux-devtools-extension according to their instructions, with no luck.
Does anyone have an idea of how to use it in Razzle?

Razzle is not connected to Redux, there is no difference between using this extension in any starter. Probably, your extension initialization is wrong. Try to check composeWithDevTools usage

@Metnew true mea culpa, it was just very late.


[Feature]: Number card to control number and input_number entities

Is your feature request related to a problem?
Mushroom cannot control number or input_number entities at the moment.
Describe the solution you'd like
Either a new "Number Card" or the ability to show slider control for entity card when a number or input_number entity is selected.

A pul request is already open for that https://github.com/piitaya/lovelace-mushroom/pull/676

A pul request is already open for that #676

Missed it, thank you.


Use size_t for sizes in XIOS interface

Use size_t for sizes in XIOS interface
Fixes #572
Fixes #562
Task List

[x] Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
[x] Implemented the source code change that satisfies the tests
[x] Documented the feature by providing worked example
[ ] Updated the README or other documentation
[ ] Completed the pre-Request checklist below

Change Description
Use size_t for sizes in the XIOS interface, rather than int, for consistency with the rest of the code base. Also, throw exceptions if the getter methods return null pointers.
NOTE: #559 and #574 will need to be merged first.

Test Description
Updated the tests accordingly.

Pre-Request Checklist

[x] The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
[x] No new warnings are generated
[x] The documentation has been updated (or an issue has been created to track the corresponding change)
[x] Methods and Tests are commented such that they can be understood without having to obtain additional context
[x] This PR/Issue is labelled as a bug/feature/enhancement/breaking change
[ ] File dates have been updated to reflect modification date
[x] This change conforms to the conventions described in the README

Ready for review, but #559 and #574 will need to be merged first so not assigning a reviewer yet.

Perfect!

Thanks! Will update file dates and then merge.


Fix shader reflection pointers

In case of OpenGL the shaders are mutable and the shader
reflection cache is cleared in the replay proxy while the UI still uses
them resulting segfault. We disable the shader cache in this case to
resolve the problem.

Thanks for identifying this issue, I think this might explain some reported crashes I've been seeing on android GL captures, which I've not been able to follow up on due to lack of contact info.
I don't think this fix is quite right though, since with your change then the shader reflection objects are going to continually leak memory, as they are allocated every time and then never deleted. Normally the shader cache keeps track of the lifetime and either re-using them or deleting them as appropriate.
I ran a test using GL over the remote proxy, and it seems like the problem kicks in e.g. when editing shaders, where a call to ReplayLog happens silently underneath the UI, which then deletes the shader reflection cache without the UI properly re-fetching the state and shader reflection objects. I think it would also happen in some other cases like opening a new panel with a preview display (like texture viewer or mesh output) which also does a ReplayLog. Is that what you're seeing?
One better fix would be to include the current EID in the shader cache key, for GL where the shaders are mutable. Unfortunately this is still going to mean the shader cache bloats in a way that's mostly unnecessary, but at least it won't keep allocating if the user selects the same event again, and the memory would be tracked and freed eventually.
If you'd like to make this fix yourself let me know, otherwise I'll commit it later today.

This problem happens when we replay a capture on remote server and the initial data is loaded. The texture viewer, pipeline viewer and mesh viewer tabs are open.
If we add the EID to the cache key, we still need to remove the cache clearing in the replay log, am I right? If yes, then I can modify the pull request to remove the cache clearing only and fix adding the EID key in a later pull request. Would it be ok for you?

I committed the fix as described above, I wouldn't want to only half-fix it now when it could easily be fixed properly.
Let me know if that fixes it for you - I'm surprised you hit this case by only loading the capture since to my thinking there wouldn't be time for the UI to have some shader reflection pointers that are then invalidated, but hopefully this will fix it either way.

I have checked your fix, it resolves the problem and works fine for me.


Unable to carry out the steps under "Re-train CoLAKE" section of README.md

Specifically, the step:
python preprocess/gen_data.py 4
Fails with:
Exception has occurred: KeyError
'ents'
File "/home/caleb/Work/CareActr/projects/phase1/repo/CoLAKE/preprocess/gen_data.py", line 62, in load_data
h, t = ins['ents'][0][0], ins['ents'][1][0]
File "/home/caleb/Work/CareActr/projects/phase1/repo/CoLAKE/preprocess/gen_data.py", line 95, in
d_ent, head_cluster = load_data()

Sorry for the late response. It seems that the data '../ernie_data/fewrel/test.json' from https://github.com/thunlp/ERNIE has changed. Fortunately, as commented in the code, this part is to remove FewRel test set from our training data for a fair comparison. So if you do not aim to publish a paper, you can just discard this part of codes: line #54 - line #61.

Thank you!


How to exclude files from the pedantic static analysis?

I need exclude some file build form build_runner.

Not sure I understand the question--which files from build_runner? What analysis issues are you seeing? Thanks.

Does https://dart.dev/guides/language/analysis-options#excluding-code-from-analysis help?

I configured the exclusion analysis file, like this:
analyzer:
  exclude:
    - lib/res.dart
    - lib/models/*.g.dart
    - lib/services/*.iconfig.dart
    - test/**

However, when I restart Android Studio and re-analyze the files,it will still show those warning message.

That sounds like an issue for the analyzer rather than pedantic; would you mind opening the issue over at the Dart SDK issue tracker please?


⚠ Minecraft has degraded performance

In 5bc6037, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 901 ms

Resolved: Minecraft performance has improved in 7c628fe.


Could not find translations.

Hey, thanks for making this, looks really good!
I tried setting up this plugin with the following boilerplate code: https://github.com/mattwaler/eleventy-starter
But despite following your setup guide exactly, I can't get the translations to load any way.
The console always outputs.
[i18n] Could not find 'hello' in 'fr-FR'. Using 'en-GB' fallback.
My code is here: https://github.com/x8BitRain/starposter-landingpage-11ty
Live: https://unruffled-mcnulty-3af42b.netlify.app/fr-fr/
The big "Hello" at the top of the page is where the Bonjour is supposed to be.
Is there something with this boilerplate's configuration that's causing this not to work?
Thanks.

Hey @x8BitRain, thanks for checking out the plugin.
You are correct. This is a bug. I'll dig in and let you know what I find.

Interestingly, this might be a versioning thing.
It seems as though the options argument being passed to addPlugin(i18n, options) is coming through empty, hence no translations. Even though that argument was added way back in 11ty 0.5.4.
The @11ty/eleventy version you're using is currently at 0.9.0. This plugin sets its peerDependencies for 11ty at 0.11.0. Perhaps something is going awry there.
Side note: You helped me spot that I'd also not properly published the latest 0.1.0. Have now republished 0.1.1 — The "Hello" you were seeing was a hangover from 0.1.0's test data.
So, to resolve:

Upgrade @11ty/eleventy to 0.11.0
Upgrade eleventy-plugin-i18n to 0.1.1

Hope that sets you on the right path.

Awesome, thanks! I was just about to tell you that I found that it never receives the configGlobalOptions parameter so it defaults to the example config all the time.
I did get it working in the end with by adding config.addFilter('i18n'..... manually but I'll try update now, cheers.


Add Anime Controllers

Add the controllers logic for anime

Hey @Abhigyan103 can u explain this feature in detail


fix datetime pattern for version generation

fixes #596
Updated the pattern to use 2 digit versions for hours, min, seconds. Thinking about ways to create non-flaky unit tests for this.

lgtm

added a couple tests

LGTM. We can start using Clock when we move to Java 8, or introduce our own should it become a problem.


Malformed code fence

File: docs/tutorials/azure/azure-ts-appservice-springboot.md
This section has a malformed code fence: https://www.pulumi.com/docs/tutorials/azure/azure-ts-appservice-springboot/#running-the-app

I haven't had a chance to verify, but there is a trailing space after the ```, which is likely throwing off Hugo's markdown renderer.


Possible documentation issue with Provider property group example - doesn't render

In the documentation here:
https://geodanila.github.io/Feliz.ReactSpectrum/#/provider
...the property group example doesn't render anything visible unless you add
Provider.defaultTheme

...in the Provider definition.
Not sure if this is a documentation issue or a code issue.

Hi Kit,
First of all - I loved your "F# from the ground up" course.
That particular examples already asumes you're using the Provider component in the root of your application for themeing. It's just used for controlling common properties for multiple child components - in that case for controlling the isDisabled prop.
Would be a good idea to specify this in the documentation.

Ah thank you!  I did guess that might be the case but didn't try it.
Very pleased you liked the course - that has made my day.
In return I must say, we are very, very excited by what you have done with Feliz.ReactSpectrum!

That is great to hear, comming from you!
I've loved F# since the day I first heard of it I've been meaning to start contribuing to the F# open source community for quite a while. The reception has been great, thank you!

Well you certainly hit the ground running!

9053e66 - added a small comment to clarify the need for a separate root-level Provider.
Thanks for the feedback.
Closing the issue.


Update report templates and methods to use new policy checklist tool

The policy checklist has been updated, and we need to update the corresponding methods and templates to support reporting on results for the 1000 Cities Challenge.
Describe the solution you'd like
A completed policy checklist XLSX file can be read and a subset of policies reported on in the default indicators reporting templates, according to the new design.
Our collaborators @anaqueralt and @JaviMolina-Garcia have prepared a draft analysis for the example city of Las Palmas that we can use to prototype this feature.  @mdlowe has prepared a draft template which I have implemented some features of, and @eugenrb will also assist in refining this.
This is part of a bigger effort to update reporting templates.

A whole load of recent updates have addressed this on the Enhancements branch; I plan to merge these in and close this issue in April 2024, once designs are signed off on and translations finalised.

Tasks/considerations from latest feedback round:

[ ] remove second 'may' from environmental disaster context
[ ] access plot legend in lower right
[ ] reference "(Box 1)" in access plot

[ ] could the access plot legend be external to the plot itself?  This would allow figure to stand alone if presented without Box 1…

[ ] updated report title in recommended citation on final page
[ ] remove levels of government from spatial report
[ ] experiment with alternate Box 1 figure (or no figure?); ML suggested TLGH cover, ER suggested more readable text.  Could show 25 maps; but would be crowded….  Or table…
[ ] more space above 'Neighbourhood walkability relative to 25 cities internationally
[ ] Summary on last page of policy checklist

[ ]  requires finalisation, use and implementation of new checklist design

[ ] Study region map; configurable choice of basemap? (could resolve ER query below)

[ ] ER suggested labels; trouble is, with translation, these could display in incorrect language, but I will look into possibilities

[ ] Box 1 in policy and spatial reports if possible
[ ] larger ticks if possible (like 1st table, at least ---ensure consistent)
[ ] policy table after destinations access? I'm not sure actually, policy is the upstream determinent of the measured outcomes, I think makes sense to have first to detail context, and then the implications


Document How to Install on Existing OP25

First - thank you for the awesome project!
I'm excited to try it but I have an existing OP25 install that is working great (and other things running on the pi too)
Would it be possible to post the installation steps for running MCH on an existing OP25?
Looking at the newinstall script, is it as simple as running the op25_mchserver.py as a systemd service and then running the android app and then setting the android app to view my existing install?
I saw the "view-only" Android version, but being able to use the features on the full version would be great!
Thanks!

The android release is available in this repo, the install script will not work with an existing OP25 installation.
Technically you could manually setup the hotspot and op25_mchserver.py but I don't currently have a write up for that.
Plus integrating with an existing install could cause unknown issues as my software expects the environment that my script provides.
You'd also have to set up a service that points to the right location which creates more potential issues when deviating from my installation.
I can look into supporting existing installs at some point but currently the recommendation is to run the script from a fresh install.


Check whether default primary key behavior is the same as postgres

We should check what the behavior of primary keys are compared to other sql systems.
It's possible we are doing the right thing.
From an exchange on gitter:
andrewchambers @andrewchambers 09:44
Does cockroachdb not automatically create the primary key field?

marc @mberhault 09:47
it will create one if you don't specify it at table creation time.
eg:
 > create table bar (v int);
CREATE TABLE
> show columns from bar;
+-------+------+-------+----------------+
| Field | Type | Null  |    Default     |
+-------+------+-------+----------------+
| v     | INT  | true  | NULL           |
| rowid | INT  | false | unique_rowid() |
+-------+------+-------+----------------+
(2 rows)
> show index from bar;
+-------+---------+--------+-----+--------+-----------+---------+
| Table |  Name   | Unique | Seq | Column | Direction | Storing |
+-------+---------+--------+-----+--------+-----------+---------+
| bar   | primary | true   |   1 | rowid  | ASC       | false   |
+-------+---------+--------+-----+--------+-----------+---------+

andrewchambers @andrewchambers 09:48
I mean for an insert
when you insert you need to generate the rowid yourself?
all the examples seem to
oh the default

marc @mberhault 09:49
it should create them, it just won't show it by default
 > insert into bar (v) values (1), (2), (3);
INSERT 3
> select * from bar;
+---+
| v |
+---+
| 1 |
| 2 |
| 3 |
+---+
(3 rows)
> select rowid from bar;
+--------------------+
|       rowid        |
+--------------------+
|<PHONE_NUMBER>21160193 |
|<PHONE_NUMBER>21225729 |
|<PHONE_NUMBER>21258497 |
+--------------------+
(3 rows)
 > select rowid,v from bar;
+--------------------+---+
|       rowid        | v |
+--------------------+---+
|<PHONE_NUMBER>21160193 | 1 |
|<PHONE_NUMBER>21225729 | 2 |
|<PHONE_NUMBER>21258497 | 3 |
+--------------------+---+
(3 rows)

andrewchambers @andrewchambers 09:50
that doesn't work if you manually specify the primary key

marc @mberhault 09:51
during CREATE, or INSERT?

andrewchambers @andrewchambers 09:51
you need to explicitly do ID INTEGER PRIMARY KEY DEFAULT unique_rowid(),
when you create
without manually specifying the DEFAULT it fails

marc @mberhault 09:51
ah, then yes, you need to specify unique_rowid, otherwise it doesn't know what to use
we only auto-generate a primary key if you don't have one

andrewchambers @andrewchambers 09:52
is this normal behaviour? i need to compare to postgres - Im shifting somethign from sqlite
I don't know how compatible they should be, but generally i thought if you specify its a primary key, the default should be implied as a unique row id

For reference I had to change
CREATE TABLE bpy.PendingUsers
(
  ID INTEGER PRIMARY KEY,
  Email VARCHAR(1024) NOT NULL,
  HashParams VARCHAR(1024) NOT NULL,
  Hash VARCHAR(1024) NOT NULL,
  ActivationCode VARCHAR(1024) NOT NULL,
  CreatedAt TIMESTAMP default current_timestamp,
  UNIQUE (ActivationCode)
);

to
CREATE TABLE bpy.PendingUsers
(
  ID INTEGER PRIMARY KEY DEFAULT unique_rowid(),
  Email VARCHAR(1024) NOT NULL,
  HashParams VARCHAR(1024) NOT NULL,
  Hash VARCHAR(1024) NOT NULL,
  ActivationCode VARCHAR(1024) NOT NULL,
  CreatedAt TIMESTAMP default current_timestamp,
  UNIQUE (ActivationCode)
);

The first one works in sqlite for example, I suppose unique_rowid() is implied.

SQLite automatically generates values for INTEGER PRIMARY KEY, but other databases (including at least PostgreSQL and MySQL) do not. Values are only automatically generated if you ask for this in the schema, either with a DEFAULT expression or database-specific shorthand (in CockroachDB and PostgreSQL that's the SERIAL type; in MySQL it's INTEGER AUTO_INCREMENT).

@bdarnell thanks, I'll check against postgres instead of sqlite as a reference next time.


refactor: avoid subshell, sign image with env. var

The private key for image signing does not need to be stored in the building process. But can be directly accessed from the env. variable.
Use parameter expansion to store the short sha commit.

Thanks for this, we'll get to this after F38 and we have some green on the board. 😄

You're welcome, yeah F38 has third party repo issues right? Anyway now it only fails in CI and no longer on our machines 😄


Create a reusable ComboBox Action

This component should have:

some supplier of possible values
internal temporary state
callback to notify another gui controls about changed value
parent com.intellij.openapi.actionSystem.AnAction
used in ActionToolbar via ActionGroup

Here is an example of it:

Here is references in JetBrains sources:

SwitchTaskAction
ComboBoxAction


add json-rpc server tutorial to docs

Motivation
Tutorials can help showcase the benefits of rolo over other frameworks. This tutorial shows how you can build a JSON-RPC over HTTP server using the handler chain and gateway.

Changes

Docs now have a tutorial section
Added a first tutorial

thanks @bentsku for the feedback on the tutorial :pray:


Triton ragged tensor support

This PR starts the work to support serving ragged tensor models.

Superseded by TensorTable migration


Fix build break

Two PRs conflicted - one added public API analyzers. One changed public API
Microsoft Reviewers: Open in CodeFlow

CI is past the build and running tests. I'm going to merge early to unblock others.


Fix creating document from struct with known types

I think that converting struct to Document is a very complex topic (just look at json/encoding), but #260 introduced behavior that is incompatible with one that was previously (see tests).

Codecov Report

Merging #330 (9fbc7d2) into main (7d37cc6) will decrease coverage by 0.01%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   61.72%   61.70%   -0.02%
==========================================
  Files          75       75
  Lines        6866     6866
==========================================
- Hits         4238     4237       -1
  Misses       2073     2073
- Partials      555      556       +1

Impacted Files
Coverage Δ

document/create.go
67.85% <55.55%> (-1.43%)
:arrow_down:

document/scan.go
64.43% <0.00%> (+0.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d37cc6...9fbc7d2. Read the comment docs.


[WIP] [Feature] CodeCamp #42 Support FSD

Motivation
Support FSD
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
The documentation has been modified accordingly, like docstring or example tutorials.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Dear maintainers, @PeterH0323  I come across this PR, and thanks for your efforts to support FSD. I may offer some help if you need, for example, the model weights for inference debugging.
There are some experiences to support FSD in MMDet3D > v1.0. (1) The coordinate system in DynamicPointPooling should be paid attention to. (2) IoUNegPiecewiseSampler  in original FSD seems to be different from the one in the new MMDet3D.
Further discussions are definitely welcome!

Dear maintainers, @PeterH0323 I come across this PR, and thanks for your efforts to support FSD. I may offer some help if you need, for example, the model weights for inference debugging. There are some experiences to support FSD in MMDet3D > v1.0. (1) The coordinate system in DynamicPointPooling should be paid attention to. (2) IoUNegPiecewiseSampler  in original FSD seems to be different from the one in the new MMDet3D. Further discussions are definitely welcome!

Hi, the creator of FSD @Abyssaledge 😄
Thx for the advice. May i ask, do you have some time, maybe we can support it together on MMDet3d 1.x ?

@PeterH0323 I cannot promise enough time, but I can help with the code review, problem discussion and lightweight commits. You could search my github username in wechat for further communication :)


MB-3552: Removing prd safeties from upload-secure-migrations

Description
This switches on the functionality for uploading migrations into the bucket for the prd environment. I've added the appropriate permissions for engineers in the GovCloud prd account and tested to make sure they can do an ls of the bucket and cp the files appropriately. I am not sure if we want to merge this immediately, but this should close the loop and make it possible to move forward with prd.

Messages

:book:
:link: MB-3552

  Generated by :no_entry_sign: dangerJS against 9a766458bcc5170ff76b1b879f7e2252a699d03f

Please also change these lines that talk about this only working in exp/stg for govcloud: https://github.com/transcom/mymove/blob/master/Makefile#L855
https://github.com/transcom/mymove/blob/master/scripts/generate-secure-migration#L77
https://github.com/transcom/mymove/blob/master/scripts/pricing-import#L126
https://github.com/transcom/mymove/blob/master/scripts/README.md
I think these should be in the same pr as this.

Hrm. Do engineers need to be able to get the migrations from the prod bucket as well? I didn't realize that. :/

@cblkwell currently they do retrieve them from prod in commercial. There's a ticket to address pulling them from govcloud here: https://dp3.atlassian.net/browse/MB-3639
I don't think you have to do that work here.

https://dp3.atlassian.net/browse/MB-3639

Yeah, I updated the permissions. I've added the things I think you wanted me to fix -- I also made some other changes to the Makefile that I'm not sure you wanted, but seemed like it was a good idea, like making the run_$ENV_migrations targets run against both commercial and AWS -- if you think that's a bad idea I can revert those particular changes.


Spec for chaosing caller saved registers

Currently in WP, we have specs for chaos-ing RAX if it used on the left hand side of a function being called. https://github.com/draperlaboratory/cbat_tools/blob/dc7b38179d23dbe8b47fe48a6f8e15c595b0627f/wp/lib/bap_wp/src/precondition.ml#L415
We should add more specs that allow us to:

always chaos RAX regardless if it was used on the left hand side of the target function
chaos the x86 caller-saved registers

Closed with #99


Release a new version

@mildsunrise when ready feel free to submit PR to bump version so we can release :+1: :)

the previous PR already bumped the version to 3.0.0, we can release now ^^

Released v3.0.0 :) thanks!


Add Smoke Grenade Activable

Smoke grenades apply a smoke effect on all ennemies and last 7 seconds. Only one smoke at a time can be used.
Requires: #203
Resolves: #210
Linked: #151

Codecov Report

Merging #212 (575aedb) into master (15d002a) will decrease coverage by 0.41%.
The diff coverage is 0.00%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d002a...575aedb. Read the comment docs.


fixing WSAS-1898

This PR is depend on.  https://github./wso2/carbon-identity/pull/129/
So merge this after identity PR is merged.


TileLayer.createTile display tile if WMS request fails

Checklist

[x] I've searched through the plugins to make sure this feature isn't already available, or think it shouldn't require a plugin.
[x] I've searched through the current issues to make sure this feature hasn't been requested already.
[x] I agree to follow the Code of Conduct that this project adheres to.

Motivation
Hello,
we use Leaflet to display openStreetMap with an overlay map. We get overlay map tiles from WMS service url (https://wms.cartografia.agenziaentrate.gov.it/inspire/wms/ows01.php?language=ita&service=WMS&version=1.3.0&request=GetMap&bbox=45.92058734473366,8.48419189453125,45.92249798457993,8.4869384765625&crs=EPSG:6706&width=256&height=256&layers=province,CP.CadastralZoning,acque,CP.CadastralParcel,fabbricati,codice_plla,simbolo_graffa&styles=default&format=image/png&transparent=false). Sometimes we receive connection error from the url to use in the tile.src, and the method TileLayer.createTile raise the event _tileOnError.
Suggested solution
We suggest to modify the event function _tileOnError to manage the exception and try to make a new request to get the tile correctly and then show it on the map grid.
Thanks.
Alternatives considered
No response

On one hand, there's already errorTileUrl and a few plugins (FunctionalTileLayer, TileLayer.Fallback) that could be applied to this use case.
On the other hand, I'm against a retry mechanism on tileservers by default: this will probably increase load in tileservers, which is not a nice thing to do - in the end, a tile server is only capable to cope with a given load, and retrying will use up some of that load capacity. You should research caching mechanisms (e.g. mapproxy) instead.


Listen along 0 seconds

For some reason whenever I try to listen along with a friend, in spotify it shows me what song they're playing and it updates when they skip, but for some reason for every song it just stays at 0 seconds and doesn't play. If i play it myself, I am not in sync with the other person, and the second they skip to the next song, it goes back to staying at 0 seconds.

same issue

For me, I got nothing on my end....no option to use it at all.

plugin just fakes premium status, the actual listening along is performed by discord itself so i doubt the plugin is causing any issues there, please try reconnecting spotify or restarting discord and spotify


Add file uploads

Initial (rough) implementation of file uploading.

Closes #2 as well.

Will go thru and make the appropriate changes, thanks for the review!

Think I hit everything, just let me know if there is any other changes you would like!


Updated README.md to authorize docker to connect to X11 server

Currently, the bash command to authorize Docker on the Jetson Nano to connect to the X11 server is incorrect.  This command does not authorize Nvidia-Docker to use the X11 server and will cause the IoT Edge NVIDIADeepStreamSDK module to fail to start.  The module's logs indicate the following error:

No protocol specified
No EGL Display
nvbufsurftransform: Could not get EGL display connection

To properly authorize Nvidia-Docker to use the X11 server, you must use the following command instead:
xhost +local:nvidia-docker
This solution was confirmed to work using the Jetson Nano Developer Kit SD Card Image w/ JP 4.2.3 & Release Date 2019/11/19.
This disk image can be downloaded using the hyperlink above or by going to the Jetson Download Center and looking for the option that looks like the image below.

Thank you for your contribution!


Creating a Navbar for the website

Need help to create a Navbar for awareness site.
Visit

Can i do this in bootstrap?

Yes Go on ! Remeber add your bootstrap files in Case folder

you can check my commit

Hello! I am a beginner & I've read the project guidelines. Could you please guide me to the right place to add my code for the Navbar for the website?

Can i Still work on this issue now?

Can i Still work on this issue now?


config active_window_opacity in app-specific window rules

Is it possible to config the active_window_opacity and normal_window_opacity per application?
I tried
yabai -m rule --add app="^iTerm2$" display=3 active_window_opacity=0.3 normal_window_opacity=0.1

in my .yabairc, but seems that it doesn't work.

Those options don't exist in the Rule context . What you want is to is to create a signal for application_activated and deactivated for iTerm. That way you can change the opacity.


Overlap at the bottom of the data table on Android phone

this appears to be affecting MS edge as well appears to crop up when changing the number of items in the selection i.e. adding all the different house types the number of pages in the list expands and causes the overlap

overlap has gone, happy to close


Expose app version number at /api

I'm thinking we might want to expose a bunch more stuff at /api, such as what probe addresses we're connected to, what version those probes are etc.

LGTM
Not this displaying this for now.

Yes yes, baby steps...

This is for #145

What's the concrete use case? I want to avoid adding things to the API because we might want to have them in the future, maybe.

This is to show the app version in the UI, for when people file bug reports.

@davkal PTAL

Also I'd propose the following patch:
diff --git a/Makefile b/Makefile
index c2245b2..c171d4f 100644
--- a/Makefile
+++ b/Makefile
@@ -11,7 +11,7 @@ SCOPE_IMAGE=$(DOCKERHUB_USER)/scope
 SCOPE_EXPORT=scope.tar
 SCOPE_UI_BUILD_EXPORT=scope_ui_build.tar
 SCOPE_UI_BUILD_IMAGE=$(DOCKERHUB_USER)/scope-ui-build
-SCOPE_VERSION=$(shell git rev-parse HEAD)
+SCOPE_VERSION=$(shell git rev-parse --short HEAD)

 all: $(SCOPE_EXPORT)

Good suggestions.

Let's move this to the right and make it a bit paler:
diff --git a/client/app/styles/main.less b/client/app/styles/main.less
index 4f9cfa4..6a06eb6 100644
--- a/client/app/styles/main.less
+++ b/client/app/styles/main.less
@@ -58,11 +58,11 @@ body {

 .footer {
   position: absolute;
-  bottom: 32px;
-  padding-left: 64px;
-  width: 100%;
-  height: 1em;
+  bottom: 16px;
+  right: 48px;
   z-index: 20;
+  color: @text-tertiary-color;
+  font-size: 85%;
 }

 .logo {

Yeah, rest looks GTM


Error when starting Zigbee-shepherd

The CC2531 Device was working well for over 1 month until yesterday morning. The LED on sniffer display green so I reboot the hassio and the add-on, the following warning message appeared.

I have already tried to re-install the hassio and the add-on, tried on another board but the problem still there.
Because I don't have the debugger so it is difficult to re-flash the firmware or check it.
Anyone could help me? Thanks in advance

The error message in text
`[Info] Configuration file found: /share/zigbee2mqtt/configuration.yaml
[Info] Configuration written to /share/zigbee2mqtt/configuration.yaml
2019-05-13T23:50:40: PM2 log: Launching in no daemon mode
2019-05-13T23:50:40: PM2 log: App [npm:0] starting in -fork mode-
2019-05-13T23:50:40: PM2 log: App [npm:0] online

<EMAIL_ADDRESS>start /zigbee2mqtt-1.3.1
node index.js
zigbee2mqtt:info 5/13/2019, 11:50:44 PM Logging to directory: '/share/zigbee2mqtt/log/2019-05-13.23-50-44'
zigbee2mqtt:info 5/13/2019, 11:50:45 PM Starting zigbee2mqtt version 1.3.1 (commit #unknown)
zigbee2mqtt:info 5/13/2019, 11:50:45 PM Starting zigbee-shepherd
zigbee2mqtt:info 5/13/2019, 11:50:53 PM Error while starting zigbee-shepherd, attempting to fix... (takes 60 seconds)
zigbee2mqtt:info 5/13/2019, 11:51:53 PM Starting zigbee-shepherd
zigbee2mqtt:error 5/13/2019, 11:51:53 PM Error while starting zigbee-shepherd!
zigbee2mqtt:error 5/13/2019, 11:51:53 PM Press the reset button on the stick (the one closest to the USB) and start again
zigbee2mqtt:error 5/13/2019, 11:51:53 PM Failed to start
{"message":"request unsuccess: 4","stack":"Error: request unsuccess: 4\n    at /zigbee2mqtt-1.3.1/node_modules/zigbee-shepherd/lib/components/zdo.js:45:21\n    at CcZnp. (/zigbee2mqtt-1.3.1/node_modules/cc-znp/lib/ccznp.js:264:13)\n    at Object.onceWrapper (events.js:273:13)\n    at CcZnp.emit (events.js:182:13)\n    at CcZnp._mtIncomingDataHdlr (/zigbee2mqtt-1.3.1/node_modules/cc-znp/lib/ccznp.js:366:14)\n    at Immediate._onImmediate (/zigbee2mqtt-1.3.1/node_modules/cc-znp/lib/ccznp.js:342:22)\n    at runCallback (timers.js:705:18)\n    at tryOnImmediate (timers.js:676:5)\n    at processImmediate (timers.js:658:5)"}
zigbee2mqtt:error 5/13/2019, 11:51:53 PM Exiting...
npm
ERR! code ELIFECYCLE
npm ERR! errno 1
npm
ERR<EMAIL_ADDRESS>start: node index.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR!
This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-05-13T22_51_53_618Z-debug.log
2019-05-13T23:51:56: PM2 log: App [npm:0] exited with code [1] via signal [SIGINT]
2019-05-13T23:51:56: PM2 log: App [npm:0] starting in -fork mode-
2019-05-13T23:51:56: PM2 log: App [npm:0] online
<EMAIL_ADDRESS>start /zigbee2mqtt-1.3.1
node index.js
zigbee2mqtt:info 5/13/2019, 11:51:59 PM Logging to directory: '/share/zigbee2mqtt/log/2019-05-13.23-51-59'
zigbee2mqtt:info 5/13/2019, 11:52:00 PM Starting zigbee2mqtt version 1.3.1 (commit #unknown)
zigbee2mqtt:info 5/13/2019, 11:52:00 PM Starting zigbee-shepherd
zigbee2mqtt:info 5/13/2019, 11:52:01 PM Error while starting zigbee-shepherd, attempting to fix... (takes 60 seconds)`

hope that helps

Did you reboot the host?

power off/on completely... that solved it for me a few times...

Try a different USB port.

Thanks For all the help. Have configured in the raspberry pi and all setting are correct. Finally it restored after I flash the latest version firmware in.
Seems it just not in the working mode so that zigbee2mqtt could not communicate with the stick even if it connected in the right port.
Thanks again for all the respond.


How to use your own data

Hello author, how do you test it with video

Hello @MayLkn,
To inference with your custom data, please make sure that you pass in arguments in lines 149-163 to the model. You may refer to our dataset file for more details about how to get these arguments.
Best,
Haotian

Which PY file needs to be modified

Hi, if i understand correctly, you need to create your own py file for your own dataset the way nuscenes_dataset.py gets created for nuscenes dataset as he pointed out in second blue text.

，如果我的理解，你需要为自己的数据集创建自己的蓝色 py 文件，就像他在第二个文本中的那样，为 nuscenes_dataset.py 正确为 nuscenes 数据集创建。

Thank you for your reply. It will be difficult

Closed due to inactivity.


Make defaultPageSize available.

Made defaultPageSize available so that Chaise apps can access it.

No comments from me. This is a simple change.


Error in console

I am seeing this error in console in chat-starter:

Everything seems to works despite it.

Meta
Moved from attach-live/attach-web-sdk#105.

Actually, this bug is already fixed, just not pushed to production due to the new setup environment.


LLVM lld-link : error : could not open ...*.lib: invalid argument

Describe the bug
could not open 'C:\Users\User\vcpkg\scripts\buildsystems\msbuild......\installed\x64-windows-static\debug\lib*.lib': invalid argument when "C++ Clang Compiler for Windows (11.0.0)" is installed and "LLVM (clang-cl)" is set.
After some digging I found out that the lld linker is unable to interpret vcpkg's output of libs.
Setting Use AutoLink to false DOES NOT fully fix the issue for me, it causes all my dependencies to be ignored (all .libs and includes)
Environment

OS: Windows
Compiler: VS 2019

To Reproduce
Steps to reproduce the behavior:

Install clang 11.0.0 from the VS Installer
In VS 2019, set General -> Platform Toolset to "LLVM (clang-cl)"
Compile
Error...

Hi @Ou7law007
Thanks for posting this issue. Since it's duplicated to #15623, let's track this issue there.


Allow the ability for an entity to bypass automatic temperature unit …

When setting up home assistant, the user chooses if they use metric or imperial units (metric is default). The Entity class uses this value to convert all temperature values to what is provided in the config. This is annoying for developers as there are times where alternative units could be useful. While the default is already set and removing it could cause breaking changes. I propose a @property to be added to the Entity object to override this automatic conversion behavior.
Breaking Change:
None
Description:
Adds override to prevent the Entity class from converting temperature units.
Example entry for configuration.yaml (if applicable):
N/A
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:
N/A
If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

I added this as an architecture discussion here: https://github.com/home-assistant/architecture/issues/217

Will close this PR while discussing the issue as the solution is probably going to be something else.


Migrate to Scalamacros Paradise

Because Scalameta support macro annotations is no longer maintained, this moves the @react macro annotation over to Scalamacros Paradise, which has much more community support. In addition, this makes the development experience with macro annotations much nicer because compile errors are shown in the context of the original code.

Any idea when this will be merged?

@matthewpflueger blocked on IntelliJ support right now; see https://gitter.im/JetBrains/intellij-scala?at=5afdf02b2df44c2d0637a5c1


v 7.0.0 doesnt work when using highcharts lib outside bundle

I have code like this:
import 'highcharts';
import ReactHighCharts = require('react-highcharts');

package.json:
dependencies: {
     "highcharts": "^4.2.3",
    "react-highcharts": "^7.0.0"
}

this results in following error in browser:
Uncaught Error: Starting with version 3 of react-highcharts, Highcharts is not bundled by default.  please include highcharts.

React-highcharts expects global Highcharts variable to be set, is that the case?

not sure what you mean.
The recipe here shows that i only need to import highcharts before using react-highcharts
https://github.com/kirjs/react-highcharts/blob/master/recipes.md#using-with-highcharts-package
I am rendering in browser, not on server.

what happens if you do
import 'highcharts';
console.log(Highcharts);
import ReactHighCharts = require('react-highcharts');

?

if i do:
import Highcharts = require('highcharts');
console.log(Highcharts);
import ReactHighCharts = require('react-highcharts');

then the highcharts object is printed out, followed by your error msg again:
Object {win: Window, seriesTypes: Object, LegendSymbolMixin: Object, CenteredSeriesMixin: Object, TrackerMixin: Object…}
ReactHighcharts.js:1 Uncaught Error: Starting with version 3 of react-highcharts, Highcharts is not bundled by default.  please include highcharts.

if you are asking people to export an npm module for highcharts, it obviously wont be present globally.
react-highcharts.jsx needs to require('highcharts')

Can you try this:
import Highcharts = require('highcharts');
global.Highcharts = Highcharts;
import ReactHighCharts = require('react-highcharts');
```?

that does work, but now it needs to be put in every single file that react-highcharts is imported.
also defeats the whole purpose of using modules in the first place.
why cant you simply require('highcharts') inside react-highcharts, kinda like you require 'react'.

Not exporting global var is a pretty new behavior, so I didn't have a chance to handle it yet.
requiring highcharts seems like the way to go, I'll update the lib when I have some time.

i created #89 to fix this

Thanks, looks like tests are failing, feel free to take a look, or leave it for me to figure out

probably has something to do with the dependencies visible to your tests.
i will leave that one for you

Looks like importing highcharts turn out to be not ideal, since the use might want to use two types of charts (e.g. ReactHighcharts and ReactHighmaps) on the same page, but they would not want to have two copies of Highcharts in their codebase.
So I suggest passing Highcharts as an argument to react Highcharts. e.g.
var Highcharts = require('highcharts');
var ReactHighcharts = require('react-highcharts')(Highcharts);

The code is in #90

this seems more like a design issue with your code.
I shouldnt have to pass highcharts, when you can indeed just import it.
a better design would be to change your import to:
require('react-highcharts/highcharts')

and just get rid of 'react-highcharts' as an import altogether.

Should be fixed by #90, feel free to reopen if not, and thanks for contributing to design decisions :)


[$500] Web – Request Money – “Show more” button is not highlighted on hover or when the cursor is moved

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click FAB (Plus sign).
Click " Request Money ".
Enter amount and click “Next”.
Select the user to proceed
Notice the “Show more” button is not highlighted on hover or when the cursor is moved

Expected Result:
Down arrow (chevron) should highlighted on hover
Actual Result:
Down arrow (chevron) does not highlighted on hover
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.56-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/38435837/8a93c65c-289e-44c9-a3b0-31807982f134
https://github.com/Expensify/App/assets/38435837/a45e9712-3760-442a-aeba-2f0368e511fd
Expensify/Expensify Issue URL:
Issue reported by: @Usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691225374193429
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01152fc4f180cf9e07
Upwork Job ID:<PHONE_NUMBER>610767872
Last Price Increase: 2023-09-07

Proposal
Please re-state the problem that we are trying to solve in this issue.
Web – Request Money – Down arrow (chevron) is not highlighted on hover or when the cursor is moved on the “Show more” button.
What is the root cause of that problem?
We didn't set the prop in Button component so that the down arrow (chevron) should be highlighted on the hover.
https://github.com/Expensify/App/blob/999ed938befa8910293cf349a4222314d5a73ccd/src/components/MoneyRequestConfirmationList.js#L364-L372
Also, even if we set the prop on the Button component, there is no code to update the color of the down arrow (chevron), so only the Show more button is highlighted, but not the down arrow (chevron).
https://github.com/Expensify/App/blob/999ed938befa8910293cf349a4222314d5a73ccd/src/components/Button/index.js#L241-L249
This is the root cause of this issue.
What changes do you think we should make in order to solve the problem?
To solve this problem we should add a prop to the Button component and then add the code to update the down arrow (chevron)'s color on hover.
We can do it like this:

Add a prop to the Button component.

              <Button
                  small
                  onPress={toggleShowAllFields}
                  text={translate('common.showMore')}
                  shouldShowRightIcon
                  iconRight={Expensicons.DownArrow}
-                 iconFill={themeColors.icon}
                  style={styles.mh0}
+                 shouldUseDefaultHover
              />

Add a new state variable here:

              constructor(props) {
                  super(props);

+                 this.state = {
+                     isHovered: false,
+                 };

                  this.renderContent = this.renderContent.bind(this);
+                 this.handleHoverIn = this.handleHoverIn.bind(this);
+                 this.handleHoverOut = this.handleHoverOut.bind(this);
              }

Create handleHoverIn and handleHoverOut functions to manage the hover state:

              handleHoverIn() {
                  this.setState({isHovered: true});
              }

              handleHoverOut() {
                  this.setState({isHovered: false});
              }

Pass these functions to the PressableWithFeedback component in here:

              <PressableWithFeedback
                  ref={this.props.forwardedRef}
                  onPress={(e) => {
                      // existing code...
                  }}
+                 onHoverIn={this.handleHoverIn}
+                 onHoverOut={this.handleHoverOut}
                  // other props...
              >

Finally, change the fill color of the IconRight based on the isHovered state in the renderContent function:

            {this.props.shouldShowRightIcon && (
                <View style={[styles.justifyContentCenter, styles.ml1, ...this.props.iconRightStyles]}>
                    <Icon
                        src={this.props.iconRight}
                        fill={this.state.isHovered ? themeColors.iconHovered : this.props.iconFill}
                        small={this.props.small}
                    />
                </View>
            )}

What alternative solutions did you explore? (Optional)

Hmm, I don't think this is a bug. We don't highlight the chevron on hoover for a pill. Right @shawnborton @trjExpensify? I think we should close though getting a second opinion.

Hm yeah, if anything, the button should probably be highlighted on hover like the confirmation button does. Not super passionate though, @JmillsExpensify.

I don't know that the chevron needs to change color in this instance. We're showing it as a button and not as an option row. However, that "Show more" button should behave exactly like our standard "Default" buttons which means it would get a slight color change on hover and on press. cc @dannymcclain
So I would say this bug report is incorrect (well, not even a bug report but rather a design inconsistency request) so no payouts here, but we could spin up an issue to make sure it has the hover state or ask whoever implemented it to go back and make the change?

Yeah I agree with Shawn—that should just work like a standard button (with the same static/hover/active/etc states).

Cool, now that that's cleared up, let's focus this issue on the "show more." Opening up for solutions.

Yeah, ideally this just uses the same exact hover style as other default buttons.

If we add only shouldUseDefaultHover,  Show more button is highlighted but Down arrow (chevron) isn't highlighted on hover.
If we can compare the icon, we can notice thatShow more button's icon is different with this with Description's on hover.
screen-capture.webm

Yup, that works for me.

@ntdiary Do you mind kicking off the BZ checklist?

In the meantime, here's the payment summary:

Issue reporter: @usmantariq96 $250 (reported before Aug. 25)
Contributor: @suneox $500 (no bonus)
Contributor+: @ntdiary $500

@JmillsExpensify as per Shawn comment I don't think I'm eligible for bounty.

Thanks @ntdiary! Everyone has been paid based on the payment summary. I'm closing this one out.


chore: expose prometheus metrics on lighthouse

lighthouse uses its config to know if it should expose an internal http handler with prometheus metrics (on /metrics)
let's enable it by default - lighthouse is already taking care of using an internal http server for it, so it has no security impact (on the webhook server which might be exposed to everybody)
note that it's not enough to enable automatic scraping of the metrics by prometheus: for that, we need to add a specific label on the lighthouse pods

Hi @vbehar. Thanks for your PR.
I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

/assign @rawlingsj

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rawlingsj
You can assign the PR to them by writing /assign @rawlingsj in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/ok-to-test

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Move data files to zivid data

LGTM. Regarding my comment about spacing, I suspect this is something we need to fix with all our Halcon samples.

I've implemented the changes. Please approve if it is ready or if not, ready for the next round.

LGTM :)

Thanks. Try to remind me to squash, I proved to forget it ;)


Plotting functions

Added plotting functions and their test functions

This PR was "closed" when you merged it into a branch in our repo. Going to open it from new branch so it can be reviewed


Support npm's two factor auth

Instead of asking for my OTP, release-it fails as soon as I want to publish to NPM. I now have to manually run npm publish, where I'm properly asked for my OTP. It would be nice if this is integrated!

Hi, @Jpunt! That feature should indeed be available.
I've just released 7.5.0-beta.0 that has this integrated. When provided nothing, the OTP will be prompted for. The OTP can also be provided with --npm.otp=123456 from the command line (useful for non-interactive/CI mode).
Could you & others please try this before I release this:
npm install release-it@beta

Thanks!

Thanks for trying!

Just wondering.. how would this work with --npm.otp? I'm guessing such an OTP is only valid for a short period of time, right? Would that be enough for a CI to arrive at this point of the release-script?

The --npm.otp argument is indeed an error-prone approach. Not sure how that value could even be obtained without another device (it would defeat the concept of 2FA). Still, there might be use-cases cq. one could prefer to use -n --npm.otp=123456 to prevent any prompts.
This release is to get things going, I still need to make sure the OTP prompt doesn't show up in CI/-n mode.

Sounds great! 👍

Released in v7.5.0

Hey!
I'm running 7.6.0, but gets the same error as Jpunt.
When i try to publish through release-it i get the following error:
yarn release
yarn run v1.7.0
$ release-it
? Ready to release 1.1.16? Yes
? Show staged files? Yes
M  package.json
? Commit (Release 1.1.16)? Yes
? Tag (1.1.16)? Yes
? Push? Yes
? Publish @adaptagency/fe_tools to npm? Yes
ERROR npm notice
npm notice 📦<EMAIL_ADDRESS>npm notice === Tarball Contents ===
npm notice 858B    package.json
npm notice 298B    main.js
npm notice 288B    main.scss
npm notice 6.2kB   README.md
npm notice 139.7kB yarn.lock
npm notice 539B    src/js/onKeyPress.js
npm notice 593B    src/js/resolvePath.js
npm notice 235B    src/scss/functions/str-remove-whitespace.scss
npm notice 267B    src/scss/functions/str-replace.scss
npm notice 691B    src/scss/functions/str-split.scss
npm notice 175B    src/scss/functions/sum.scss
npm notice 151B    src/scss/mixins/_accessibility.scss
npm notice 467B    src/scss/mixins/_multiplier.scss
npm notice 457B    src/scss/mixins/_rootModifier.scss
npm notice 352B    src/scss/mixins/layout/_full-width.scss
npm notice 1.1kB   src/scss/mixins/layout/_inner.scss
npm notice 957B    src/scss/mixins/layout/_innerBreakpoint.scss
npm notice 1.1kB   src/scss/mixins/layout/README.md
npm notice 552B    src/scss/mixins/typography/_respTypo.scss
npm notice 408B    src/scss/mixins/typography/_respTypoBp.scss
npm notice 1.8kB   src/scss/mixins/typography/README.md
npm notice === Tarball Details ===
npm notice name:          @adaptagency/fe_tools
npm notice version:       1.1.16
npm notice package size:  43.8 kB
npm notice unpacked size: 157.2 kB
npm notice shasum:        62df956dc635c13f09612751f4cd63a21e1b1219
npm notice integrity:     sha512-HKJV8JIcqdE7H[...]kIwss5Nrrjq2A==
npm notice total files:   21
npm notice
npm ERR! code ENEEDAUTH
npm ERR! need auth auth required for publishing
npm ERR! need auth You need to authorize this machine using `npm adduser`

npm ERR!      /Users/...-debug.log

Any idea what I'm doing wrong? :)
I've tried to both add the -n and --npm.otp argument, but same issue :)

Hi, @mads-thines. Not sure if the error is the same:
npm ERR! code ENEEDAUTH
npm ERR! need auth auth required for publishing
npm ERR! need auth You need to authorize this machine using `npm adduser`

Is the npm user configured? You can check with npm whoami.

Hey!
Thanks for getting back so fast :)
Yes, and it returns my user. It also works when using the regular npm publish way. :)

And now I remember #95. This comment might contain a solution.

Yes, that solved the issue. Thanks!!
If I don't add any arguments it prompts me and it works, but it would be awesome if i could get the -n argument to also prompt for otp.
Currently my script is release: release-it -n, and then run yarn release --npm.otp=myKey.
Nonetheless, thanks for the help :)

it would be awesome if i could get the -n argument to also prompt for otp.

I see, but -n is --non-interactive and that would kind of go against a prompt for OTP.

@webpro and that totally make sense! :)


Scraping suggestion

This official website from CH offers two tidbits of interesting information, worth scraping:
https://www.experimental.bfs.admin.ch/expstat/en/home/innovative-methods/swisscovid-app-monitoring.html

the app activation user base;
a sentence changing daily: "On 13 July, 5 users of the SwissCovid app entered a Covid code in their app. During the seven days between 7 and 13 July, a total of 63 Covid codes were therefore entered."

It would be worth scraping both, especially the second one.

On 15/07/2020 20:42, pdehaye wrote:

This official website from CH offers two tidbits of interesting information, worth scraping:
https://www.experimental.bfs.admin.ch/expstat/en/home/innovative-methods/swisscovid-app-monitoring.html

the app activation user base;
a sentence changing daily: "On 13 July, 5 users of the SwissCovid app entered a Covid code in their app. During the seven days between 7 and 13 July, a total of 63 Covid codes were therefore entered."

It would be worth scraping both, especially the second one.

Fine idea. Will add.
S.

Added those. They're collected now for each run but not displayed.


Bump inmanta-dev-dependencies[async,core,pytest] from 2.101.0 to 2.104.0 (#7036)

Pull request opened by the merge tool on behalf of #7036

Merged in e056ac686d9011f83b1b377f26950f2228452f80


[FeatureRequest] Support dynamic volume provisioning for TFJob

There are a lot of machine learning use cases where we need large scratch spaces for jobs, and in Kubernetes, persistent volume would be a good and efficient type to support such use case. Current kubeflow requires user to provision persistent volume claims separately as shown in https://github.com/kubeflow/tf-operator/tree/631dd0e31b8bfbb59b2b6ab7a3ea501cb289d479/examples/v1beta1/mnist_with_summaries
I was wondering if we can add support for dynamic volume provisioning in TFJobSpec and PyTorchJobSpec. A rough thought would be something similar to that of StatefulSet.
We are happy to contribute and send out PR for implementing the feature.

@zhan849 Can you explain more on it wrt to the support required and changes in API?

@johnugeorge I'm thinking about the following:

Add a slice of volume claim templates in ReplicaSpec

VolumeClaimTemplates []corev1.PersistentVolumeClaim `json:"volumeClaimTemplates,omitempty"`

In ReplicaSpec.Spec.InitContainers and ReplicaSpec.Spec.Containers, if any of the container requests a volume whose name is NOT in ReplicaSpec.Spec.Volumes but in ReplicaSpec.VolumeClaimTemplates, we create PersistentVolumeClaim objects for that container. Since containers are named with "-i" suffix, we can name the PVCs similarly.

When the managing object (i.e TFJob or PyTorchJob) is deleted, we delete the volumes as well

I can send out the PR for the community to review if the general direction is agreed.

/cc @richardsliu
/cc @gaocegege

The idea SGTM while I think storage class already  supports dynamic volume provision, what things should we do in the use case?

@gaocegege yes storage class should define how the volume should actually be provisioned. We already started some experiments in a forked branch, do you guys want me to submit a brief proposal or you want to implement it. it'd be something similar to stateful set

@zhan849 I am glad to see your proposal! Thanks for your contribution.

@richardsliu @zhan849
Should we place the feature in common-operator? It is general for all PS-worker based training jobs

@gaocegege Yes I think so. So it should be in the next API version.

@gaocegege @richardsliu agreed. will close this one and open new one under common-operator.
And also for design doc, given all the discussion threads under tf-operator, I'd suggest that we keep it there and check into community repo after the PR is finalized and merged