Update CHANGE_LOG for 0.53.0

As title.

CC @numba/czars

Looks good to me in general - one suggestion to add credit to Nick White for CGs in the CUDA highlights as well (which I realised when reading the full changelog).

Thanks for the review @gmarkall

5a65dfe  is an updated to include https://github.com/numba/numba/pull/6685 which is needed for 0.53 as it adds the Python 3.9 classifiers to setup.py.


[Question] Does grammy works on edge runtime

Hello, I just recently stumbled upon this library, and want to know if it can run on serverless envorinment, does grammy support serverless/edge runtime ?

Of course.
Check out https://grammy.dev/hosting/comparison#serverless-and-paas to see a comparison of serverless hosting solutions. Also, be sure to take a look at the hosting guides in the same section. Most of them describe how to host grammY in serverless environments.

That was quick!
Thanks! :heart:

Very welcome! 🎉


Csv renewal

This PR handles issue #321

Oh, yeah - that would preetttty nifty for all the times we do application_status.application throughout LargeLots. I'd be enthusiastic about implementing it here to test it out!


Hope to add support for the arm platform

I want to run it on my raspberry pi.

Hopefully, @jpillora will create an arm tag for this image, in the meantime if you want to run it on arm, I've managed to get it working on my pi3
https://hub.docker.com/r/eafxx/dnsmasq

Hopefully, @jpillora will create an arm tag for this image, in the meantime if you want to run it on arm, I've managed to get it working on my pi3
https://hub.docker.com/r/eafxx/dnsmasq

OK,thanks.Does it  support for arm64? my pi3 's operating system is ubuntu 64 bit.

Aye! I'm running it on my pi3, Ubuntu 18.04 64bit.

Aye! I'm running it on my pi3, Ubuntu 18.04 64bit.

That's fine, I am also Ubuntu 18.04 64bit.Thanks again.

For anyone interested, I've taken a different approach to make platform selection transparent on my fork outlyer-net/docker-dnsmasq-multiarch
See https://hub.docker.com/r/outlyernet/dnsmasq-multiarch

For anyone interested, I've taken a different approach to make platform selection transparent on my fork outlyer-net/docker-dnsmasq-multiarch
See https://hub.docker.com/r/outlyernet/dnsmasq-multiarch

It looks very good.


doc: remove duplicate 'lush-color-example' entry

Fixes #89

Tested with :helptags ./ in the doc folder without the change (fail because of duplicate) and with the change (no error, tags file correctly generated).

Thanks!


Add some notes about running Cargo's tests on Windows.

Fixes #4591 and #4601.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)


[Feature]: Confusion matrix working with strings/enum preds and y_true

Description
Confusion matrix not robust to strings / enums labels for preds/y_true.
confusion_matrix.py, line 61
        assert max(preds) <= len(
            class_names
        ), "Higher predicted index than number of classes"
        assert max(y_true) <= len(
            class_names
        ), "Higher label class index than number of classes"

here my preds are already my labels, max(preds) and max(y_true) give me an error.
Funnily enough, the confusion matrix works just fine if I don't give them class_name. I feel in that case that the class names should be infered from pred and/or y_true, but if not at least let us give them the names lol
Suggested Solution
Just replace max(preds) and max(y_true) line 61 and 64 par len(set(preds)).
        assert len(set(preds)) <= len(
            class_names
        ), "Higher predicted index than number of classes"
        assert len(set(y_true)) <= len(
            class_names
        ), "Higher label class index than number of classes"

I feel this is also more robust in case the user have class labels that are not integers starting from 0. (I guess the bug I had would also occur if the user's label are integer starting from 1)
Alternatives
No response
Additional Context
No response

Hi @adangreputationsquad, thank you for raising this along with a solution. I will pass this to our engineering team and will follow up once they get a chance to look into implementing this.
Thank you,
Nate

Hi @adangreputationsquad, would it be possible to send a minimal example of data that would cause this error? I was trying to reproduce the error and I wasn't able to with my understanding of the problem.
Thank you,
Nate

Sure

import wandb

wandb.init(project="test")

preds = [1, 2, 0, 1, 1, 2, 0]
y_true = [0, 2, 1, 0, 1, 2, 0]
plot = wandb.plot.confusion_matrix(
    preds=preds,
    y_true=y_true,
    class_names=["zero", "one", "two"])
wandb.log({"plot_1": plot})

preds_2 = ["one", "two", "zero", "one", "one", "two", "zero"]
y_true_2 = ["zero", "two", "one", "zero", "one", "two", "zero"]
plot_2 = wandb.plot.confusion_matrix(
    preds=preds_2,
    y_true=y_true_2)
wandb.log({"plot_2": plot_2})

Here when I go to wandb, the first plot generate a confusion matrix with its correct labels (zero, one two) but the second does not (the classes are class_1, class_2, class_3).
Now, I don't mind passing the labels again with the class_name argument even if it feels a bit redoundant, but it raises an error...
preds_2 = ["one", "two", "zero", "one", "one", "two", "zero"]
y_true_2 = ["zero", "two", "one", "zero", "one", "two", "zero"]
plot_2 = wandb.plot.confusion_matrix(
    preds=preds_2,
    y_true=y_true_2,
    class_names=["zero", "one", "two"])
wandb.log({"plot_2": plot_2})

  File "/path/temp.py", line 15, in <module>
    plot_2 = wandb.plot.confusion_matrix(
  File "path/lib/python3.10/site-packages/wandb/plot/confusion_matrix.py", line 78, in confusion_matrix
    counts[class_mapping[y_true[i]], class_mapping[preds[i]]] += 1
KeyError: 'zero'

Thank you @adangreputationsquad, I see the issue now. I've passed this onto the engineering team and will follow up once we have a fix on this.

Hi @tamarl08, thank you for the workaround. I just checked the ticket and we still don't have a fix on this yet but I've added your context to the ticket and can follow up once we have this resolved.

Hi @adangreputationsquad @tamarl08 quick update to let you know that we are now closing this issue as it should been addressed by this PR: https://github.com/wandb/wandb/pull/8678 please let us know if you are still encountering any issues and we will be happy to keep investigating. Thank you for reporting it!


[Event Request] table 246 "Requisition Line" - OnBeforeShowReservation

procedure ShowReservation()
var
    ReservationPage: Page Reservation;
    IsHandled: Boolean;
begin
    //A200F0008.Event19.05.ns
    IsHandled := false;
    OnBeforeShowReservation(Rec, IsHandled);
    if IsHandled then
        exit;
    //A200F0008.Event19.05.ne

    TestField(Type, Type::Item);

[IntegrationEvent(false, false)]
local procedure OnBeforeShowReservation(var RequisitionLine: Record "Requisition Line"; var IsHandled: Boolean)
begin
    //A200F0008.Event19.05
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Unknown level type provided

This might be just because i was testing, but i'm seeing this on one of my notification rules.

this is fixed by https://github.com/influxdata/influxdb/issues/14978


Replace Black and isort with Ruff formatter

For the Neovim Starter Kit for Python, it might be better to use Ruff formatter instead of Black and isort?

Can you explain why it might be better?


Date already parsed in Page::header

In \Grav\Common\Page\Page::header, $this->header->date is already a unix timestamp. strtotime does not recognize unix timestamp and will return false. Later on, it will replace $this->date by $this->modified, which is incorrect.
if (isset($this->header->date)) {
    $this->date = strtotime($this->header->date);
}

Here is an example of a header with a date that is parsed to a unix timestamp:
---
date: 2013-01-05T08:12:11-05:00
---

the page header date is not intended to be formatted like that, it's intended to be like this:
---
date: 17:34 07/04/2014
---

I've just tested it and it all works as expected

@rhukster Why not provide support for it? After all, it is a standard date format (ISO 8601).
What is the purpose of limiting the parsing of date to a specific format when you use strtotime which supports a range of parsable date string? Is it to have a single supported format?
In the doc, you say

Valid values are any string date values that strtotime() supports.

for both publish date and unpublish date.
http://learn.getgrav.org/content/headers#publish-date
http://learn.getgrav.org/content/headers#unpublish-date
However that is not true as they display the same issue (a unix timestamp passed to strtotime).
My suggestion would be to make it support any date format as well as the current one supported when you're parsing the header in \Grav\Common\Page\Page::header.


Dialog button does not show all text at 200% scaling

Describe the bug
We (Photos team) got this bug as a part of accessibility testing
Steps to reproduce the bug

Steps to reproduce the behavior:

Create dialog box with a button with long text
Set the screen resolution to 1280x768.
Set text size to 225% (Settings -> Ease of access -> Make text bigger).

Expected behavior
Text in dialog box does not scale with 200% text scaling
Screenshots
Version Info

NuGet package version:
Standard content dialog

Windows 10 version
Saw the problem?

Insider Build (18908)
Yes

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Anniversary Update (14393)

Device form factor
Saw the problem?

Desktop
Yes

Additional context
Link to bug https://microsoft.visualstudio.com/OS/_workitems/edit/22018027?src=WorkItemMention&src-action=artifact_link

Only font size scales with the text scaling setting, but the UI sizes don't. Things like ContentDialog have fixed width and don't grow. Should we consider having some of these things be more elastic or having text scaling factor in to dialog sizes? Flipping this to a feature request.

Things like ContentDialog have fixed width and don't grow.

That's not entirely true. ContentDialog has two resources in generic.xaml that control its width:
<x:Double x:Key="ContentDialogMinWidth">320</x:Double>
<x:Double x:Key="ContentDialogMaxWidth">548</x:Double>

When playing with the Xaml Controls Gallery, I can see the sample dialog become wider with the increased font size.
@marzha, the Photos app appears to have run up against the 548 max width at 100% text scale. I don't know the history of why 548 was chosen as the maximum width for ContentDialog and I hesitate to change this width in the SDK. But I'm not aware of a reason why the Photos app can't make the change locally by, for example, changing the ContentDialogMaxWidth of just this backup dialog.

I don't think that making this control work well in this scenario (which is an accessibility requirement) should be up to each app.  We would need to update every usage of the common control in the app in case the button text translated to something too long to display at 200% text size in any of the languages that we support.
I think there is a valid design question about how this common dialog should support 200% text scaling (should the button get more width or height?), but I don't think each app should have to work around the issue.
Could you please reconsider?
Thanks!

Another option is to change ContentDialog's button text to wrap, but we've avoided doing this in the past. @Chigy, do you have context as to why that is?
Also tagging @stmoy in case you have any other thoughts/suggestions.

@marzha, @KevBrown42 - I continue to believe that the most straight-forward solution to this problem is at the app level rather than the control level. ContentDialog's buttons have undergone a lot of finessing to support a majority of app scenarios. I don't think we'll be able to prioritize changing them any time soon.
To fix this particular issue, I recommend making one of the following changes in your app:

Shorten the text that's being clipped. You can likely remove one of the words in the label without loss of meaning.
Allow this instance of ContentDialog to become even wider, as outlined in my earlier reply.
Add your own buttons to ContentDialog's content instead of leveraging the built-in ones. I don't necessarily recommend this option because you'll need to do quite a bit of work to recreate the default buttons' keyboard behavior.

I realize that it would be more convenient for ContentDialog to provide a solution out of the box. Unfortunately we're heads down working on WinUI 3.0 and can't prioritize revisiting ContentDialog's design when app-side solutions exist.


BridgeException (timeout) during long-running async JS call

TLDR: Is there any way to dynamically set the call timeout (i.e. REQ_TIMEOUT in Bridge.js) to a different value, perhaps when instantiating a subclass of PyClass?
Here's my use case:

I've created a PDF toolkit in Python (using PyPDF2)
I've created a Javascript class (which extends PyClass) to wrap the Python class exactly as instructed in your docs/examples
Functionally, everything works perfectly on a small scale, but I'm currently using my JS class on a Node server that has to deal with merging & obtaining page counts for very large PDF files
The long-running async calls to my PDF toolkit class for these large files often incur a BridgeException due to the Python API call timing out (the call isn't actually hung, it's just taking longer than 100 seconds)

All problems are fixed if I increase REQ_TIMEOUT to something like 300_000 in my local node_modules, but I would love if I didn't have to change this value manually every time I provision a server w/ my project code.
Is this possible? Or can you suggest any alternative workarounds for long-running async calls from Node?

@austincondict-AngelOak, where you able to find a way to dynamically set the timeout? Modifying the source file in node_modules isn't practical in a CI environment where an automated replace would be needed after running npm install. Any ideas for a CI friendly solution?


Readme and project.json

This PR fleshes out the readme and adds some defaults to the project settings, like a logo.
It now looks like this in the project manager.

Please review the Get Started and Using Cesium for O3DE Samples for Development sections!

thanks @argallegos! look goods to me


Errors with settings files

Here's the version I'm on:

When I try to save a settings file, I get this error:

When I try to re-use an older settings file, I get this error:

Thanks!

@erikdarlingdata Thanks for reporting this.
I believe this (at least the first part) was fixed some time ago - version .166 is the latest:
https://github.com/ErikEJ/SqlQueryStress/releases

@ErikEJ thanks, i'll give that a shot in a few!

@ErikEJ yep, all good on that build. thanks again!


Optimize making of mocking and new modules

Just the other day I discovered '$handle_undefined_function'(FnName, Args) and it seems perfect to abuse! So I tried it and it was possible to cut the time to half again, never would have expected that. I extended the table in the previous PRs and it is now:

Execution time
Code

67s
Baseline (1.2.0)

32s
PR #18

9s
PRs #21 and #20

4s
This PR on top of #21

The biggest of the mocked modules in this eunit test had approx 4500 exported functions, and making the mocking module for it previously took 3.3s. It is now down to 0.1s.
The '$handle_undefined_function'/2 seems to have been introduced roughly in R16, according to my archæological excavations.
As usual, I suppose I should test it a bit more thorougly on some largish projects first, so I'm creating a draft request to indicate that. But comments are of course welcome any time.

It's documented and everything. :-)

I have run this PR plus the #26 (aa791d1111) on top in 4 large projects, and it looks good.

Thanks! Merged.


services: mysql

In my .travis.yml I have mysq service:
services:
  - mysq

After run JoliCi see errors:

[Docker\Exception\APIException]
No such image: mysql:5.5
[Docker\Exception\APIException]
No such image: mysql:5.5
[GuzzleHttp\Exception\ClientException]
Client error response [url] /images/mysql%3A5.5/json [status code] 404 [reason phrase] Not Foun

Am I douing anything wrong or is there a bug?

Hello,
Thanks for opening this issue.
Unfortunately, we don't support this repository anymore.
I'm sorry, but I'll close this issue.
I hope you understand.


Spell Corrector

Script Title - Should able to correct spelling ( Can be done by textblob library)
what will change - Adding spell corrector module
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed

Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language

[x] Python

Happy Coding,

I would like to do this

okay, go-ahead

Is this issue still available? If yes, can I work on it?

okay sure, go ahead :)


Health outcomes: Diabetes

Description: Percent of adults; 18-64 with diabetes
Logic:
Source(s):
Diabetes.xlsx
Source
Year(s):

[ ] 2002
[ ] 2010
[ ] 2017

Geographies:

[ ] PUMA
[ ] Borough
[ ] City

Race and ethnicity breakdown:
Denominator:
SME:
Questions:
Roadblocks:

similar to self-reported health. The confidence interval question and also whether UHF by race breakdown is available.


[Feature Request] Show documentation in auto-complete window of the VSCode plugin

When summoning auto-complete menu to chose from one of the procedures I would like to be able to view their documentation without having to insert a procedure call and calling "show hover" command on it. I saw in some other languages' plugins, that vscode has this ability, as shown in the screenshot below:

I do return documentation related to the completion item. Not sure how to get vscode to show it.


Add support for "swift" type for rclone-sync

Is your feature request related to a problem? Please describe.
When using type: s3 for rclone-sync, rclone fails to sync image data for harbor in Cleura environments. Using swift fixes this issue.
Describe the solution you'd like
Add a new case for .Values.config.source.type "swift" in the rclone.conf file, both for source and destination. Other than type, the following config variables are needed for the swift type:
user = {{ .Values.something }}
key = {{ .Values.something }}
auth = {{ .Values.something }}
domain = {{ .Values.something }}
tenant = {{ .Values.something }}
tenant_domain = {{ .Values.something }}
region = {{ .Values.something }}

This config file gets its values from this values file, which will need to have some new variables added.
Describe alternatives you've considered
Additional context
Following are descriptions of the config variables:

user - Corresponds to OS_USERNAME. In the apps config, this value is currently available for the source bucket in secrets.yaml as harbor.persistence.swift.username.
key - Corresponds to OS_PASSWORD. In the apps config, this value is currently available for the source bucket in secrets.yaml as harbor.persistence.swift.password.
auth- Corresponds to OS_AUTH_URL, with /v3 appended at the end (it will not work without this addition). For example, for the kna1 region on Cleura, this would be https://kna1.citycloud.com:5000/v3. In the apps config, this value is currently available for the source bucket in sc-config.yaml as harbor.persistence.swift.authURL (without the /v3).
domain - Corresponds to OS_USER_DOMAIN_NAME. In the apps config, this value is currently available for the source bucket in sc-config.yaml as harbor.persistence.swift.userDomainName.
tenant - Corresponds to OS_TENANT_NAME. In the apps config, this value is currently available for the source bucket in sc-config.yaml as harbor.persistence.swift.tenantName.
tenant_domain - Corresponds to OS_PROJECT_DOMAIN_NAME. In the apps config, this value is currently available for the source bucket in sc-config.yaml as harbor.persistence.swift.projectDomainName.
region - Corresponds to OS_REGION_NAME. In the apps config, this value is currently available for the source bucket in sc-config.yaml as harbor.persistence.swift.regionName.

Since the currently available values in the apps config all refer to harbor, it may be preferable to rename these variables to something else since it will no longer be used only for harbor. Additionally, note that all of them are the values for the source, not the destination - in some cases there may be overlap (for example the username and password may be the same for both source and destination), but for others this is unlikely (e.g. region should always differ). New variables should probably be added for all of them (i.e. don't assume any overlap).
A restriction that requires the global.ck8sCloudProvider to be citycloud may be relevant, since that is our only supported provider that uses swift.
Definition of done:

It is possible to use objectStorage.sync.type: swift and get a working rclone setup.

I would also like to see the possibility to use type: ceph


FP arithmetic instructions tests

where are FP arithmetic  instruction tests? I only see FP conversion instructions in D and F directories .(?)

Are you looking in just RV64 directories? My understanding is that RV64 uses the tests in the RV32 directory - they're shared.

They are automatically set by the macros(link)

any news about atomics?

look at the dev-partners spreadsheet here
https://github.com/orgs/riscv-admin/projects/2/views/19?pane=issue&itemId=23235596
for updates; nothing to do with this issue.


No way to configure client.

Not found any way to configure HTTP client, in particular I need to setup request timeout.

I think you can extend featherbed.Client and override clientTransform.


ci: gather debugging information about possible TestExtraPackages failure

The Issue
TestExtraPackages often fails due to

https://github.com/oerdnj/deb.sury.org/issues/2046

How This PR Solves The Issue
Experiment with gathering more information about the problem. This is explored in

https://askubuntu.com/a/990019/18314
https://askubuntu.com/a/841968/18314

The suggestions have to do with disk space (this happens at docker build time) and with removing /var/lib/apt/lists
Manual Testing Instructions
Automated Testing Overview

Related Issue Link(s)
Release/Deployment Notes

Bizarrely, I can't make it fail with these additions. This one will be a candidate for reversion if we can discover the real cause.


Complete initial specification

This draft passes around module specifiers + attributes in terms of
ModuleRequest Records. Objects are fully read out eagerly in import().
Any type checks or coercion of attribute values passed to import() is
done by the host. Hosts can also choose whether or not to reject
unknown attributes.

Thanks for the quick reviews! I've made the fixes suggested by @dandclark . I'm going to land this now, but I'd be happy to have any further reviews.


[ISV-993][ISV-1144] Publish bundle to index using IIB

Use "index" CLI to publish operator bundle to operator index.
JIRA: ISV-993

To summarize changes that go above the original AC:

uses IIB batch api
uses own Quay credentials for prod and stage
fixes ISV-1144


[SPARK-35722][CORE] wait until something does get queued

What changes were proposed in this pull request?
Currently, we continue the loop after wait timeout when ContextCleaner cleanUp if the queue is empty, It is an ineffective loop because the queue is empty.
In the PR, it prevent ineffective loop, if the queue is empty, we wait until something does get queued instead of ineffective loop after wait timeout .
Why are the changes needed?
avoid inefeective loop
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exist test

Code conflict, reopen in

Can one of the admins verify this patch?


Image picker corrects the wrong direction after zooming the image on IOS. The direction displayed on H5 is inconsistent with that displayed on app

I saw the following code in the source code dealing with the problem of image direction, but I feel that this way, the processed image is not compatible with H5. In H5, the direction of the image is not consistent with the display in the app.
  // Scaling the image always rotate itself based on the current imageOrientation of the original
  // Image. Set to orientationUp for the orignal image before scaling, so the scaled image doesn't
  // mess up with the pixels.
  UIImage *imageToScale = [UIImage imageWithCGImage:image.CGImage
                                              scale:1
                                        orientation:UIImageOrientationUp];

  // The image orientation is manually set to UIImageOrientationUp which swapped the aspect ratio in
  // some scenarios. For example, when the original image has orientation left, the horizontal
  // pixels should be scaled to `width` and the vertical pixels should be scaled to `height`. After
  // setting the orientation to up, we end up scaling the horizontal pixels to `height` and vertical
  // to `width`. Below swap will solve this issue.
  if ([image imageOrientation] == UIImageOrientationLeft ||
      [image imageOrientation] == UIImageOrientationRight ||
      [image imageOrientation] == UIImageOrientationLeftMirrored ||
      [image imageOrientation] == UIImageOrientationRightMirrored) {
    double temp = width;
    width = height;
    height = temp;
  }

I hope to solve this problem. Thank you very much.

This is a solution of the netizens I found. Please refer to it. thank you.
- (UIImage *)fixOrientation:(UIImage *)aImage {

    // No-op if the orientation is already correct
    if (aImage.imageOrientation == UIImageOrientationUp)
        return aImage;

    // We need to calculate the proper transformation to make the image upright.
    // We do it in 2 steps: Rotate if Left/Right/Down, and then flip if Mirrored.
    CGAffineTransform transform = CGAffineTransformIdentity;

    switch (aImage.imageOrientation) {
        case UIImageOrientationDown:
        case UIImageOrientationDownMirrored:
            transform = CGAffineTransformTranslate(transform, aImage.size.width, aImage.size.height);
            transform = CGAffineTransformRotate(transform, M_PI);
            break;

        case UIImageOrientationLeft:
        case UIImageOrientationLeftMirrored:
            transform = CGAffineTransformTranslate(transform, aImage.size.width, 0);
            transform = CGAffineTransformRotate(transform, M_PI_2);
            break;

        case UIImageOrientationRight:
        case UIImageOrientationRightMirrored:
            transform = CGAffineTransformTranslate(transform, 0, aImage.size.height);
            transform = CGAffineTransformRotate(transform, -M_PI_2);
            break;
        default:
            break;
    }

    switch (aImage.imageOrientation) {
        case UIImageOrientationUpMirrored:
        case UIImageOrientationDownMirrored:
            transform = CGAffineTransformTranslate(transform, aImage.size.width, 0);
            transform = CGAffineTransformScale(transform, -1, 1);
            break;

        case UIImageOrientationLeftMirrored:
        case UIImageOrientationRightMirrored:
            transform = CGAffineTransformTranslate(transform, aImage.size.height, 0);
            transform = CGAffineTransformScale(transform, -1, 1);
            break;
        default:
            break;
    }

    // Now we draw the underlying CGImage into a new context, applying the transform
    // calculated above.
    CGContextRef ctx = CGBitmapContextCreate(NULL, aImage.size.width, aImage.size.height,
                                             CGImageGetBitsPerComponent(aImage.CGImage), 0,
                                             CGImageGetColorSpace(aImage.CGImage),
                                             CGImageGetBitmapInfo(aImage.CGImage));
    CGContextConcatCTM(ctx, transform);
    switch (aImage.imageOrientation) {
        case UIImageOrientationLeft:
        case UIImageOrientationLeftMirrored:
        case UIImageOrientationRight:
        case UIImageOrientationRightMirrored:
            // Grr...
            CGContextDrawImage(ctx, CGRectMake(0,0,aImage.size.height,aImage.size.width), aImage.CGImage);
            break;

        default:
            CGContextDrawImage(ctx, CGRectMake(0,0,aImage.size.width,aImage.size.height), aImage.CGImage);
            break;
    }

    // And now we just create a new UIImage from the drawing context
    CGImageRef cgimg = CGBitmapContextCreateImage(ctx);
    UIImage *img = [UIImage imageWithCGImage:cgimg];
    CGContextRelease(ctx);
    CGImageRelease(cgimg);
    return img;
}

Hi @yangyxd
Can you please provide your flutter doctor -v, your flutter run --verbose and a minimal complete reproducible code sample.
Thank you

Hi @TahaTesser
My current environment is windows, but the code packaged on Mac OS is the same as the version of flutter.
Thank you!
[√] Flutter (Channel dev, 1.20.0-0.0.pre, on Microsoft Windows [Version 10.0.17763.1282], locale zh-CN)
    • Flutter version 1.20.0-0.0.pre at D:\Android\Flutter
    • Framework revision d9653445f4 (2 days ago), 2020-06-09 18:43:03 -0400
    • Engine revision e8c13aa012
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 5c1376615e)
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.1)
    • Android SDK at D:\Android\sdk
    • Platform android-29, build-tools 29.0.1
    • ANDROID_HOME = D:\Android\sdk
    • Java binary at: D:\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[√] Android Studio (version 4.0)
    • Android Studio at D:\Android\Android Studio
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.43.2)
    • VS Code at C:\Users\YangYxd\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.8.1

[√] VS Code, 64-bit edition (version 1.42.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.8.1

[√] Connected device (1 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64 • Android 10 (API 29) (emulator)

! Doctor found issues in 1 category.

```dart
  Future<String> uploadImage({ImageSource source = ImageSource.gallery, bool limitFileSize = true, UploadProgressCallback progress, VoidCallback onBeginUpload}) async {
    try {
      PickedFile _file = await ImagePicker().getImage(
        source: source,
        maxWidth: !limitFileSize ? null : 1920,
        maxHeight: !limitFileSize ? null : 1920,
        imageQuality: !limitFileSize ? null : 85,
      );
      if (_file == null || Utils.empty(_file.path))
        return null;
      return await upload(File(_file.path), progress: progress, onBeginUpload: onBeginUpload);
    } catch (e) {
      print(e);
      Utils.toast("上传图像失败：" + e.toString());
      return null;
    }
  }

This is the problem image

Hi @yangyxd
Tried your code sample and picked your sample image on iOS, i don't see any direction

Code Sample
import 'dart:io';

import 'package:image_picker/image_picker.dart';

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  File _image;
  final picker = ImagePicker();

  var source;
  var limitFileSize;

  Future getImage() async {
    //   final pickedFile = await picker.getImage(source: ImageSource.camera);

    //   setState(() {
    //     _image = File(pickedFile.path);
    //   });

    try {
      PickedFile pickedFile = await ImagePicker().getImage(
        source: ImageSource.gallery,
        // maxWidth: !limitFileSize ? null : 1920,
        // maxHeight: !limitFileSize ? null : 1920,
        // imageQuality: !limitFileSize ? null : 85,
      );
      if (pickedFile == null) return null;
      setState(() {
        _image = File(pickedFile.path);
      });

      // return await upload(File(_file.path), progress: progress, onBeginUpload: onBeginUpload);
    } catch (e) {
      print(e);
      // Utils.toast("上传图像失败：" + e.toString());
      return null;
    }
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Image Picker Example'),
      ),
      body: Center(
        child: _image == null ? Text('No image selected.') : Image.file(_image),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: getImage,
        tooltip: 'Pick Image',
        child: Icon(Icons.add_a_photo),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-0.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-0.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision d9653445f4 (2 days ago), 2020-06-09 18:43:03 -0400
    • Engine revision e8c13aa012
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 5c1376615e)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.11.0

[✓] Connected device (5 available)
    • Android SDK built for x86 • emulator-5554             • android-x86    •
      Android 10 (API 29) (emulator)
    • Taha’s iPhone             • 00008020-001059882212002E • ios            •
      iOS 13.5.1
    • macOS                     • macOS                     • darwin-x64     •
      Mac OS X 10.15.5 19F101
    • Web Server                • web-server                • web-javascript •
      Flutter Tools
    • Chrome                    • chrome                    • web-javascript •
      Google Chrome 83.0.4103.97

• No issues found!

if you please provide complete code sample and screenshot of the issue
Thank you

Thank you very much.
Please use the following code to deal with the exception image I gave earlier, and then you use the < img > tag in the H5 page to display. You will find that the display effect in the browser is inconsistent with the direction in the app.
import 'dart:io';

import 'package:image_picker/image_picker.dart';

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  File _image;
  final picker = ImagePicker();

  var source;
  var limitFileSize;

  Future getImage() async {
    try {
      PickedFile pickedFile = await ImagePicker().getImage(
        source: ImageSource.gallery,
        maxWidth: 1024,
        maxHeight: 1024,
        imageQuality: 85,
      );
      if (pickedFile == null) return null;
      setState(() {
        _image = File(pickedFile.path);
      });

      // return await upload(File(_file.path), progress: progress, onBeginUpload: onBeginUpload);
    } catch (e) {
      print(e);
      return null;
    }
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Image Picker Example'),
      ),
      body: Center(
        child: _image == null ? Text('No image selected.') : Image.file(_image),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: getImage,
        tooltip: 'Pick Image',
        child: Icon(Icons.add_a_photo),
      ),
    );
  }
}

Hi @yangyxd
Can you please provide code sample and screenshot for this?
then you use the < img > tag in the H5 page to display. You will find that the display effect in the browser is inconsistent with the direction in the app.

The main reason for this problem is that in the

Hi @TahaTesser
You can see the effect on GitHub. Do you see the difference?
That is to say, the effect of direct display on mobile phone is different from that of < img SRC ='My image '/ >.

Hi @yangyxd

Your image isn't chrome rotated on my browser
I used the same image as seen from the screenshot and result is same, no issues

There will be problems with chrome browsers and mobile phones.

Hi @yangyxd
I am not sure this is related to image_picker, since using any image, picked image direction isn't change

Without additional information we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.
Could everyone who still has this problem please file a new issue with the exact description of what happens, logs and the output of flutter doctor -v.
All system setups can be slightly different, so it's always better to open new issues and reference related issues.


macOS: Mouse move cancels right click context menu

Describe the bug
The native behavior on macOS when triggering the right click (two finger tap) context menu is that even if the mouse cursor it moved a bit, the context menu still appears. In Ghidra the context menu only appears if you keep the mouse cursor on the exact same position.
To Reproduce
Steps to reproduce the behavior:

Double tap in the code browser e.g.
Move the mouse slightly before the context menu appears

Expected behavior
Context menu appears

OS: macOS 10.14.3
Java: 11.0
Ghidra Version: 9.0

I've been using a mac a lot recently and haven't had any issues with this.


Add basic formtastic integration

You can use it like this: f.input :descripton, as: :trix_editor

Whoops -- sorry I didn't see this earlier @tothpeter. Would you be able to add some tests for this?

Sure, I'll add some tests as soon I will have some free time

:+1:

+1

@maclover7  I created a test as you required, what do you think?

Added some code review comments.

One or two comments left to go :)

This looks pretty much done to me -- can you just squash you commits? Thanks! :)

Sure, I've never tried it before, I hope I did it right

Good first attempt! You've got about 5 commits right now -- you want to try and shrink that down to just one commit :)

Okay, I think I got it right : -)

Hmm, almost there -- if you look at your commit list, it looks like you pulled in three commits that aren't related to the Formtastic integration...

Ah yes, sorry I forgot, thanks for your patient. How about now? Will you extend the readme, or should I do it?

Good point -- can you add some documentation to the README.md, for how to use this new feature?

Done.

:+1: Thank you for your contribution!

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

@tothpeter - build is failing: https://travis-ci.org/maclover7/trix/builds/120769625

The problem is: for some strange reason the order of the HTML attributes of the input tag is different, of course the tests are running green on my machine with the same ruby/bundler/gem version.
My first thought is:

we could use some regexp which does not care about the order of attributes for testing the input part
use simple string.include for testing the editor tag existence

Let me know what you think.


highlighting color that's not part of the palette

Such a great theme, but unfortunately it has a blue color that's not part of Dracula palette when highlights email accounts with unread messages

Thanks for the kind words! Unfortunately, I was not able to reproduce the issue:

There are unread messages in these accounts. However, I neither have this eyesore of a color (fortunately :sweat_smile:) nor these yellow circles. Can you provide additional instructions on how to reproduce the behavior?

Is a bit weird I've restarted Thunderbird and now I'm getting the right theme
I've been able to reproduce by

Doing a clean installation
Configuring an account
It seems to be happening only during the first sync of the accounts

BTW after first email account sync, I'm getting right theme again.

Interesting! And good that you documented it here. While this is a little annoying, I don't think that there is anything I can do about it, since it is probably related to the way Thunderbird handles themes. If I got you right, then everything is fine now, so I'll close the issue. Feel free to reopen, if you still encounter the problem.

Ok, I'm getting this again and I think i know exactly where it occurs.
I've sent a test email to a couple accounts and noticed that the account gets highlighted in blue each time a new message arrives.
The small yellow circle at the corner of the email account is the badge indicator for new messages

BTW, I'm using thunderbird 91.4.1 (64-bit)
May be there's a new theme selector property that's not included in this theme but I'm not sure where to find all selector properties.

I don't have rights to reopen this issue but you can reproduce it

Install thunderbird 91.4.1 (64-bit),
Then install dracula theme
Lastly configure an email account.

You'll se this effect each time you get a new email.

I was able to "sort of" reproduce it:

However, for me, the color is much more muted. It is still not part of the palette, but not really as much of an eyesore. Still, I#d prefer it to be more purple-ish.

🤔  i think that color may depend on the base OS theme.

That's what I suspect as well. Unfortunately, this would mean that it is beyond the control of this theme. I'm on Linux, I suspect you are as well?

I'm on MacOS, with OS dark theme.

If I enable Thunderbird dark theme, that blue color changes, that's why I think this theme is missing a selector.
I've googled a bit but couldn't find docs regarding theme selectors for that highlighting 😞
BTW If I can find a solution I'll let you know

If I enable Thunderbird dark theme, that blue color changes, that's why I think this theme is missing a selector.

Sounds reasonable. That blue you have there looks very much like the default "link blue".

I've googled a bit but couldn't find docs regarding theme selectors for that highlighting :disappointed:

I did a quick search myself and did not find anything as well. Unfortunately, I don't have enough time right now to search much more. :grimacing:

BTW If I can find a solution I'll let you know

That would be really appreciated. While I don't mind the color that I have, a color from the dracula palette would be much better.


Fix: UWP App crashes when managed_object->update_clipboard() is called

Operating system and version: Windows 10 / UWP
Godot version: tested on 3.1.2
Device: x86_64
Steps to reproduce: this bug sometimes occurred when I tried to launch the application
Hello!
When I attempted to port our game to Xbox One I encountered a bug which was described here:
https://stackoverflow.com/questions/58660743/uwp-app-crashes-when-clipboard-getcontent-is-called-from-inside-onnavigatedto
I attempted to apply the fix described in the article and it worked, the application won't crash anymore.
Unfortunately, I don't remember well exactly under which circumstances the bug was reproduced (as far as I've remembered, it happened when I tried to launch the release version), but I hope it will be useful...

Also, I've added the ifdef line for EGL_ANGLE_DISPLAY_ALLOW_RENDER_TO_BACK_BUFFER constant in the commit
84be975, please sorry, I understand that I should have been added it as another pull request, but I am new at contributing :(
This ifdef was added because EGL_ANGLE_DISPLAY_ALLOW_RENDER_TO_BACK_BUFFER is not present in Google Angle and Microsoft Angle is outdated and not supported anymore

This ifdef was added because EGL_ANGLE_DISPLAY_ALLOW_RENDER_TO_BACK_BUFFER is not present in Google Angle and Microsoft Angle is outdated and not supported anymore

I confirm, I had to comment out those in #46911.

Sorry for the delay reviewing.
This looks good to me overall, but the UWP platform in the master is currently broken and unmaintained. I've backported your PRs to the 3.x branch for 3.6 (could be cherry-picked for a 3.5.x release too) where the UWP platform should still work.
Superseded by #73126 and #73127.


invisible recaptcha

Hi! Thanks a lot, this is very helpful library. I have question. I need implement invisible recaptcha from Google. Can i do this with your library? ty 😄
Not, its Google magic https://www.google.com/recaptcha/intro/comingsoon/invisible.html
Docs: https://developers.google.com/recaptcha/docs/invisible
The library can already be used. I tried to implement it, but I could not teach her to communicate with netteForms.js so I used your solution. My only chance is that you manage your experience.

Hi. It looks pretty simple to me. Could you please describe in short ways how implement it? I mean there's only a submit button with some data-attributes?

+1

@misaon @michallohnisky Could you guys give me any hints how to implement it? I do not have much time to discover docs. Thanks.

+1


Turn example/analysis into a more complete CLI utility

mythx-analysis:

supports more complete analyze library options,
--version, --timeout, --delay, and --debug

Go over README descriptions:

top-level, example/README.md, package.json

include test directory in distribution
distrubute example/mythx-analysis as a standalone program
add some Solidity example files

Pull Request Test Coverage Report for Build 314

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.722%

Totals

Change from base Build 313:
0.0%

Covered Lines:
233

Relevant Lines:
295

💛  - Coveralls

As Federico says, this is good work. Thanks for addressing all of the comments too.


Port collesion on 20002 with other plugins?

I'm getting this error when installing v2.0.7 which prevents Homebridge to start.
Error: bind EADDRINUSE <IP_ADDRESS>:20002
at dgram.js:338:20
at processTicksAndRejections (internal/process/task_queues.js:85:21)
I can't find the port in the code which is wired, but after uninstalling the plugin Homebridge starts again.
This is something new that happens after the upgrade as the previous version worked

The plugin does not play well yet with multiple devices... I'm working on a platform version.
in the meantime I released v2.0.8 which should solve some issues so it won't throw the errors

Try the latest version 3

Works for me! (Boiler and Power plug)
On Mon, Oct 5, 2020 at 8:36 PM Nitay Ben-Zvi<EMAIL_ADDRESS>wrote:

Try the latest version 3
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nitaybz/homebridge-switcher-boiler/issues/11#issuecomment-703780329,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFI43ZKRNLYVGLM7T37HZ3SJH7ZRANCNFSM4R6WGWFQ
.


GNOME 45 support

There are breaking changes which will require a separate release for 45 and <=44:
See https://gjs.guide/extensions/upgrading/gnome-shell-45.html

I'll be looking into this relatively soon 👍


Cropping tool

Tool that is able to crop spectra

should it crop by x-axis values or bin number
what happens when multiple spectra are provided (possibly with different x-axis)
does it preserve x-axis just clear corresponding y-values or creates a cropped version of the spectra

there is crop widget in oranchada 0.15

crops by x-axis  values (that's what user would expect)
crops each spectrum and preserve the  x-axis  ( x-axis should only be changed by dedicated widgets as resample or calibration)


The lowest and highest values are out of block

Lightweight Charts Version: 3.1.5
https://jsfiddle.net/6dv4z2wk/14/
data is BTCUSDT future with 1M kline from binance API
Actual behavior:
The lowest and highest values are out of block
Expected behavior:
All values must be visible

Don't use strings-like-numbers where numbers are expected, they aren't the same.


Settings: Jira URL doesn't accept context path

When trying to enter the Jira URL, it is marked as invalid as soon as something other than "https://HOSTNAME" is entered. In our (company) case jira is installed as "https://HOSTNAME/jira", so the plugin apparently cannot be configured to access jira at all.
The cause seems to be the regex in app/index.html, line 369. Probably it would be fine to append
(/\w+)*/? to allow for any number of path parts. Or just (/\w+)  for a single context path (should cover 99% of all cases)
Plugin version: 2.0.2
Update 2015-11-19: formatting fix

Hi @creinig,
sorry for the late response. Your request will be available in v.2.0.4

@creinig The new version is available and you should have the update in the next 24h.


Add support of Random Early Detection (RED) congestion avoidance to PacketQueue

Currently, PacketQueue supports only tail drop mechanism where arriving packets are dropped only if there is no space in the queue. In the Random Early Detection (RED) congestion avoidance scheme, arriving packets are dropped with a probably which increases with the current average queue length. Implementation will follow the description of the mechanism given in “Random Early Detection gateways for Congestion Avoidance,” IEEE/ACM Transactions on Networking, vol. 1, no. 4, August 1993. by S. Floyd and V. Jacobson.

"The RED controller uses a smoothed moving average of queue size when deciding if a packet should be dropped. This smoothed measure avoids over-reaction to short-term bursts of traffic arriving to the queue."
The moving average queue size is updated every time a new packet arrives.
If the queue is not empty:
avg = (1 – wq) * avg + wq * q

where avg is the average queue size, q is the current number in the queue at the time of arrival, and wq is a fixed weighting factor that controls how heavily the current queue size influences the average (i.e. the degree of smoothing).
If the queue is empty:
m = f(time – q_time)
avg = (1 – wq) ^ m * avg

f - linear function of time estimating the number of "small packets" that could have been transmitted during idle time.
For each arriving packet we make a decision to accept or drop it. "If the average queue size is less than a chosen threshold minth, then the packet is accepted to the queue. If the queue size is greater than or equal to maxth, then the packet is dropped."
"Between these thresholds the packet is dropped with a probability pa calculated as follows":
pb = maxp [avg – minth] / [maxth – minth]
pa = pb / [1 - count * pb]

RED_early.twocolumn.pdf

Algorithm from the original publication:

Few notes. In our implementation we will also support a hard queue limit (not present in the original algorithm). If this limit is set, all packets are dropped when the limit is reached (drop of a packet due to hitting this limit resets the "count" variable for RED algorithm to 0). Another note, as we can notice in the pseudocode above, the current packet marking probability pa can become negative with some combinations of count and preliminary drop probability pb. To be exact, it will be negative if count * pb > 1. Even worse (div by zero) if, by accident, we end up with count * pb == 1. Hence, ifself._queue_state.count * pb >= 1, we let pa to be 1. It matches the original intent of the equation - to grow drop probability with the growth of the number of packets admitted since last dropped packet.


typings: Add the device.is_frozen field

Change-type: minor

Resolves: #
HQ:
See:
Depends-on:
Change-type: major|minor|patch

Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci I self-certify!


Consider adding type overrides

On an incoming port, it is sometimes desirable to take a string which will be converted to a sum type in Elm. Currently, TIE's generated definition will just be string for this case, but it would be nice if we could tell it to use something else such as "success" | "error"

I think, in fact, this could become a key feature. It would allow for decoding of sum types and maintaining type safety from a TypeScript perspective. To give a simple example, for the following Elm type representation of a message and variant for a status:
type alias StatusMessage =
  { message : String
  , variant : SMVariant
  }

type SMVariant = Success | Warning | Error

TIE would fail to process this if given by a port, but you could, for example, add another type to use in a port:
type alias StatusMessagePort =
  { message: String
  , variant: String
  }

statusMessagePortToStatusMessage : StatusMessagePort -> StatusMessage
statusMessagePortToStatusMessage {message, variant} = StatusMessage message <|
  case port of
    "success" -> Success
    "warning" -> Warning
    _ -> Error
-- of course, you could go further and add a Result to this

port statusMessage (StatusMessagePort -> msg) -> Sub msg

From this, TIE would generate:
// inside Elm.Main
interface StatusMessagePort {
  message: string;
  variant: string;
}

But if you could add a config file for TIE and tell it instead to generate
interface StatusMessagePort {
  message: string;
  variant: "success" | "warning" | "error";
}

Then you maintain the safety of using an Elm decoder as long as the TS definition is correct

Toml config ->
Type definitions key ->
  Key is not a table ->
    Matches an additional member ->
      Replace like for like ->
    Does not match ->
      Warn
  Key is a table ->
    Matches an interface ->
      Subkey matches a member ->
        Replace like for like
      Does not match ->
        Warn
    Does not match an interface ->
      Warn

Still to do:

[ ] Haddock
[ ] Test
[ ] User documentation

Released in Version 1.1.0


Instrumentate DO new UI for proper measuring

###Context
In order to keep track of the changes we do and how the UI performs in terms of UX we are going to need some extra classes on the CSS (happy to hear other solutions) so we can track usage of different elements using the actual tools.
From now on I propose we do 2 main things:

start using class names with no css properties but that help us tracking different elements, and under a new namespace. Something like 'trk--typeElement--qualifiers(n)'.
start using class names for groups of fields so we can focus on particular states of the UI.

For example with the new DO UI it should be something like...

With this information we can generate funnels so we see how many people is completing the different steps of the analysis. Sounds this feasible?
On the other hand, it looks like our current stack would require us to trigger a fake click event when some particular elements are shown, so we can calculate rate of completion from shown to first required action. Too hacky? It's the official solution that our provider suggest...
This would need to be added to all analysis (and to all the UI) at some moment

cc/ @noguerol @xavijam @CartoDB/design

cc @nobuti

On the other hand, it looks like our current stack would require us to trigger a fake click event when some particular elements are shown, so we can calculate rate of completion from shown to first required action. Too hacky? It's the official solution that our provider suggest...

I don't understand it. Which elements would need that?

Every screen. Think that funnel should be tracked since the moment somebody enters to a screen.

A note about the class names used to do the tracking:
In the Image Export feature we decided to use this structure:
.track-FeatureName: to name the main feature.
.track-action: to track buttons, links, or anything that users can interact with.
For example, the export button has the the classes:
track-ImageExport track-export
For other examples see:
https://github.com/CartoDB/cartodb/search?utf8=✓&q=track-ImageExport

yeah, we should update this according to the changes you forced me to
accept :P
El mar., 11 abr. 2017 a las 17:09, Javier Arce<EMAIL_ADDRESS>escribió:

A note about the class names used to do the tracking:
In the Image Export feature we decided to use this structure:
.track-FeatureName: to name the main feature.
.track-action: to track buttons, links, or anything that users can
interact with.
For example, the export button has the the classes:
track-ImageExport track-export
For other examples see:
https://github.com/CartoDB/cartodb/search?utf8=✓&q=track-ImageExport
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/11670#issuecomment-293294380,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIENTFF8HcVvTGFMNtjpR1VN0qyt6AZks5ru5eogaJpZM4MO2bb
.

blocked until #11802 is finished

I guess we can close this in favour of #12095.


Fix all the things!

Well, at least the small things that I had to leave slightly-disjointed after #609:

[x] Need to re-enable the XHProf integration test in .travis.yml
[x] Need to pass through docs and make sure everything is updated to reflect
[x] Need to update www.drupalvm.com with correct/latest information
[x] Need to switch main installation Travis tests to use Ubuntu 16.04 instead of 14.04 Docker.

Do you have an ETA on the next release? I need to upgrade a bunch of VMs and would rather wait until 3.0 unless it's far off.

++ to @oxyc for helping push this through!

@oxyc - As far as the next release goes, I was hoping to do it yesterday or today, but my energy level is down to like -5... so it will hopefully be either tomorrow by EOD, or very early in the week.
Thank you SO much for your help with all these last-minute hurdles! The last two things I want to get in are tagged in the 3.0.0 milestone, and then I want to work on one more test run pass on my Macs and PCs to make sure the 3.0.0 release is as smooth as possible.


Request: Option to watch for different process than launcher

For context, I am using GloSC primarily to play Destiny 2.  I have GloSC set to open the Battle.net launcher, which means the overlay keeps running after the game exits (since the B.NET launcher stays open).
Ideally I'd like to add a separate watchdog target than the launcher application, so it can close out when the actual game closes out.

Additionally, GlosSI should auto-detect child processes

At least child processes are somewhat implemented.
This is not really tested, though.
https://github.com/Alia5/GlosSI/commit/8d9771f0ee5bce6ecc77f9c39f1468cfe6327d63

For anyone else wondering how to launch games through the BNet launcher properly: Target the battle net launcher exe and add an additional command line option to automatically open the desired game.
So, for Diablo II: Resurrected i chose Diablo II Resurrected Launcher.exe as the target with launch arguments --exec="launch OSI" and added both Battle.net.exe and Battle.net Launcher.exe as launcher processes.
For other games' launch codes (for D2R it's OSI), look up the codes in this file: https://github.com/dafzor/bnetlauncher/blob/master/bnetlauncher/Resources/gamesdb.ini
Here's my complete D2R.json target configuration:
{
    "controller": {
        "allowDesktopConfig": false,
        "emulateDS4": true,
        "maxControllers": 1
    },
    "devices": {
        "hideDevices": true,
        "realDeviceIds": true
    },
    "extendedLogging": false,
    "icon": "D:/BlizzardGames/Diablo II Resurrected/Diablo II Resurrected Launcher.exe",
    "launch": {
        "closeOnExit": false,
        "ignoreLauncher": true,
        "killLauncher": false,
        "launch": true,
        "launchAppArgs": "--exec=\"launch OSI\"",
        "launchPath": "D:/BlizzardGames/Diablo II Resurrected/Diablo II Resurrected Launcher.exe",
        "launcherProcesses": [
            "C:\\Program Files (x86)\\Epic Games\\Launcher\\Portal\\Binaries\\Win32\\EpicGamesLauncher.exe",
            "C:\\Program Files (x86)\\Battle.net\\Battle.net.exe",
            "C:\\Program Files (x86)\\Battle.net\\Battle.net Launcher.exe"
        ],
        "waitForChildProcs": true
    },
    "name": "D2R",
    "oldName": "S",
    "snapshotNotify": false,
    "steamPath": "c:/program files (x86)/steam",
    "steamUserId": "REDACTED",
    "version": 1,
    "window": {
        "disableGlosSIOverlay": true,
        "disableOverlay": true,
        "hideAltTab": false,
        "maxFps": null,
        "scale": null,
        "windowMode": false
    }
}


issue

Repro steps:

Action: appService.Deploy
Error type: Error
Error Message: Deployment to "rpa-assessment-roi" failed. See output channel for more details.
Version: 0.14.0
OS: win32
Product: Visual Studio Code
Product Version: 1.33.1
Language: en

Call Stack
Object.<anonymous> extension.bundle.js:1:477324
o extension.bundle.js:1:475315
process._tickCallback next_tick.js:68:7

Hi @farrukhkhanacce,
Sorry for your issue.  Does this reproduce consistently?  Could you provide repro steps, please?


NOISSUE - Remove redundant user identify for backup and restore

Removed  user identification. in Backup and Restore,

I'll open another PR with the fix


Add an app icon

This is not a feature related request but it would be nice to have a meaningful icon to launch the app

Duplicate of #37


Use caret ranges for engines

npm is using node-semver to check the version of the engines. For example https://github.com/npm/cli/blob/86ac76caa4a8bd5d1acb1777befdbc4d9ebc8a1a/docs/bin/build.js#L3C1-L3C1.
They are also using caret ranges for engines. See https://github.com/npm/cli/blob/latest/package.json#L266.

thank you!


[don't merge yet] feat: enable Inquiry Checkout (PURCHASE-2684)

The type of this PR is: Feature
This enables Inquiry Checkout. The corresponding Echo PR is here.
https://artsyproduct.atlassian.net/browse/PURCHASE-2684
Description

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have tested my changes on iOS and Android.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

CI failed because Echo hasn't had the new feature key. This makes me wonder if we should

Set the new feature to false in the Echo PR, merge and deploy that.
Rebuild this PR, merge and submit for approval
When we are ready to release Inquiry Checkout, update the Echo flag to true.

Would love to pair on this and learn more about the sequencing!

But in general, I think merging the echo PR should make this PR here pass, and it will be good to go.

yeah this test is to make sure that the echo flag exists before deploying.
@starsirius the steps you outlined are exactly how we suggest to do things for timed releases. If you don't care about whether the feature becomes available on a particular day, you can also set the echo flag to true and then the feature will be switched on as soon as people update their apps to the version that this PR gets deployed in.

Thanks @pvinis and @ds300! I submitted another Echo PR to disable the feature for now. Will rebuild this PR again once it's deployed! 🙏

Could you make this PR into a draft, instead of using the [don't merge] title? It makes it clearer for us 🙏.


Add SSM send_command support

Add basic support for boto3's SSM send_command function as detailed at https://boto3.readthedocs.io/en/latest/reference/services/ssm.html#SSM.Client.send_command.
As of right now, it doesn't seem like this mock should require any real persistence unless users would want to be able to alter the state of jobs or test timeout logic.

Closed with #1484


Animation error message shows wrong track name

Godot version:
godot git master compiled today
OS/device including version:
Kubuntu 17.10
Issue description:
I am updating some older code to current Godot version and some things have changed. so animation wasn't correct on my character, and got this on debug error window:
0:00:12:0147 - Failed setting key at time 0.171352 in Animation 'jarru.R' at Node '/root/Node/Player/anim', Track 'Sprite:frame'. Check if property exists or the type of key is right for the property
but in fact, the error was on other track I had there: "Sprite:rotation_deg", which nowadays should be called "Sprite:rotation_degrees".. so after I fixed that, errors went away.
.b

Duplicate of #17718.


fix: Status - Emoji in custom status holder is not centered.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/35389
PROPOSAL: https://github.com/Expensify/App/issues/35389#issuecomment-1916811945
Tests

Go to Settings > Profile > Status
Select a square emoji and save it
Return to home page
Zoom in the emoji on profile tab and verify it is centered

[x] Verify that no errors appear in the JS console

Offline tests

Go to Settings > Profile > Status
Select a square emoji and save it
Return to home page
Zoom in the emoji on profile tab and verify it is centered

QA Steps

Go to Settings > Profile > Status
Select a square emoji and save it
Return to home page
Zoom in the emoji on profile tab and verify it is centered

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
Chrome:
https://github.com/Expensify/App/assets/85894871/aea29909-8dd4-43b0-ad97-d924f58e0e37
Safari
https://github.com/Expensify/App/assets/85894871/2a45063a-4d0a-46cd-b420-3533629fe3ce

MacOS: Desktop

I see that this is draft, but would be good with some screenshots for my design review when you're ready 👍  Thanks!

Was hard to see but tested it locally from the branch and it looks mostly good except that it's 1px too far to the right:

Nice 🦅 👁 Jon!

Correct. It's on Chrome taken with 100% so no zoom

That looks good to me. The 🟥  seems to overstep its boundries by less than a pixel. Thoughts on this @shawnborton ? Should we overflow: hidden, size it down again, or ship like this. I think the only emojis that'll go out of bounds will be 📆 and 🟥 as they are weirdly bigger than the rest

I'd be fine leaving as-is, or adding the overflow-hidden like you are suggesting.

@Krishna2323 : Let's add overflow hidden then and get this shipped 😄

No strong feelings from me, either one works!

Let's go with overflow: hidden to ensure we don't end up with any weird issues if something were to spill over.

Hi, I will check on this review tomorrow, I am assuming design team is fine with the current path.

Yup, sounds like we landed on overflow: hidden

Checking now

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/46707890/77ec2193-5dbb-405c-a659-5eb9130276a6

Android: mWeb Chrome

https://github.com/Expensify/App/assets/46707890/0fc2a0be-77f7-4f59-a811-5954b822e7ef

iOS: Native

https://github.com/Expensify/App/assets/46707890/f7370c08-9af9-4198-977e-acbe104f2ca4

iOS: mWeb Safari

https://github.com/Expensify/App/assets/46707890/798ff3b3-6858-43fc-b95f-a10383c728d4

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/46707890/25a818b9-b649-4911-a748-8153387a10cf

MacOS: Desktop

https://github.com/Expensify/App/assets/46707890/7e6272b0-de0e-4f9e-8bd2-4e6799cdb3b8

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/madmax330 in version: 1.4.82-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.82-4 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Adding Block-chain.com (BC) logo

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

@VSemenchuk
Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwalletapp.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:

Twitter: @trustwalletapp

Facebook: @trustwalletapp


Added Support for all Package Metrics, Fixes #3

Added Support for rendering all Package Metrics available in pub.dev API
This fixes Issue #3

@bruno-garcia
The tests are failing, especially those on the custom server, let me know how that can be fixed.

Thanks for the PR @AldrinMathew this is a great addition!
Sorry for the delay in reviewing it. I hope to get time on it soon.
I'm not sure yet why the tests fail. I'll pull your branch and debug them when I have a chance.

@bruno-garcia
No issues. Take your time. I will keep the PR open. Thanks for the response.

@bruno-garcia
Thanks for the quick turnaround and review. If there is anything I can do to help regarding this, let me know.


[composer] thread plugin should be active by default

the thread plugin is listed in default plugins in composer-app/main, but for new users is not on by default.

@richburdon are you sure they were a new user? If they'd opened composer prior to threads being added to the defaults list then it would not be turned on for them just because we added it to the defaults list.

confirmed threads are on by default for anon profile


Upgrade to latest phpunit

Coverage remained the same at 97.143% when pulling 12ce220f869d5379c6fa41d5212ae23a2c88924e on latest_phpunit into a7d281ed0186aabcff719422ba5265ef21b5a34e on master.

Coverage remained the same at 97.143% when pulling 12ce220f869d5379c6fa41d5212ae23a2c88924e on latest_phpunit into a7d281ed0186aabcff719422ba5265ef21b5a34e on master.


Fix for issue 1104. Update Microsoft.VSSDK.BuildTools to 15.1.192 & adding it as a dep

Fix for issue 1104. Update Microsoft.VSSDK.BuildTools to 15.1.192 & adding it as a dependency.
From: https://developercommunity.visualstudio.com/content/problem/28405/getdeploymentpathfromvsixmanifest-fails.html
I've tested this quite a few times worked great with latest VS 2017.

Don't merge. For some reason it's not installing on VS2017.

I haven't been able to generate a shared functional project & NuGet package configuration for both VS 2015 & VS 2017, so I'm adding a specific project for each.

*work in progress


Bump major-version for java.build.version upgrade

Forgot the ee part.

I fixed that already and released 6.0


Fix SAF Solution code style

Prevent a newly created solution from failing the code style check.

@nick-marnik Indeed! It is a work in progress I am afraid 😅


Custom build error

custom build makes a lot of "ERR! compile... - Bad type annotation. Unknown type ..."

build.json looks like below:
{
"export": [
    "ol.color.asArray",
    "ol.color.asString",
    ... methods what I need
],
"compile": {
    "externs": [
      "externs/oli.js",
      "externs/olx.js"
    ],
    "define": [
      "ol.ENABLE_WEBGL=false",
      "ol.ENABLE_PROJ4JS=false",
      "ol.DEBUG=false"
    ],
    "compilation_level": "ADVANCED",
    "output_wrapper": "(function(){%output%})();",
    "use_types_for_optimization": true,
    "manage_closure_dependencies": true,
    "rewrite_polyfills": false
  }
}

#6698 doesn't fix this issue because the way of custom build is already having 'typedef.js'

Can you try with manage_closure_dependencies: false?

@tschaub Error happens the same.

I have a similar issue, not so much for a custom build, but to use the externs to build an app where I want to just use ol.js.  The file generated by tasks/generate-extern.js does not generate a file that can be compiled. It seems that it needs oli.js, olx.js, and typedefs.js, and even then still it gets Bad Type Annotation Errors.  I'm going about this all wrong, why shouldn't this task just generate the  exported symbols used in ol.js and all the typedefs?

With v4.1.0 and the following config.json, running node tasks/build.js config.json ol.min.js works for me.
{
  "exports": [
    "ol.Map",
    "ol.View",
    "ol.control.defaults",
    "ol.layer.Tile",
    "ol.source.OSM"
  ],
  "compile": {
    "externs": [
      "externs/bingmaps.js",
      "externs/cartodb.js",
      "externs/closure-compiler.js",
      "externs/esrijson.js",
      "externs/geojson.js",
      "externs/oli.js",
      "externs/olx.js",
      "externs/proj4js.js",
      "externs/tilejson.js",
      "externs/topojson.js"
    ],
    "extra_annotation_name": [
      "api", "observable"
    ],
    "compilation_level": "ADVANCED",
    "manage_closure_dependencies": true,
    "rewrite_polyfills": false
  }
}

@cs09g or @polar - can you provide a complete example that demonstrates the problem you are seeing?
I'll keep experimenting with different exports.

@cs09g - with your partial example above, it looks like you are missing (at least) the externs/tilejson.js.  This is consistent with the error you are seeing.

@tschaub this json is what I tried so far. including externs/tilejson.js didn't make a difference yet.

I'm experiencing similar problems with my custom in build OL 4.1.0. I have to add a complete list of externs to avoid errors even though the sources are not exported. For example excluding "externs/cartodb.js" will throw
ERR! compile ../node_modules/openlayers/src/ol/source/cartodb.js:133:
WARNING - Bad type annotation. Unknown type CartoDBLayerInfo

My custom build looks like this:
{
  "exports": [
    "ol.Map",
    ...
  ],
  "umd": true,
  "compile": {
    "externs": [
      "externs/closure-compiler.js",
      "externs/geojson.js",
      "externs/esrijson.js",
      "externs/oli.js",
      "externs/olx.js",
      "externs/proj4js.js",
      "externs/tilejson.js",
      "externs/topojson.js"
    ],
    "define": [
      "ol.ENABLE_WEBGL=false",
      "ol.ENABLE_PROJ4JS=true",
      "ol.ENABLE_RASTER_REPROJECTION=false"
    ],
    "extra_annotation_name": [
      "api", "observable"
    ],
    "compilation_level": "ADVANCED",
    "manage_closure_dependencies": true
  }

hint from @afogelberg
I added all the js inside externs, then it's resolved. I'm not sure this is the right way to do but the build file size is almost same so it's not a big deal to add unused file.
the one thing it says as ERR! compile is
WARNING - unknown @define variable ol.DEBUG with below code.
maybe it's deprecated or something.
"define": [
  "ol.DEBUG=false"
]

I am having issues too,  am trying to compile my custom classes exclusively,  so that my min version will only contain codes from several of my files and not contain ol codes. am using the json below as input:
{   "exports": ["*"],   "umd": false,   "src": [     "src/ros/*.js"   ],   "compile": {     "externs": [       "node_modules/openlayers/externs/ol-externs.js",       "node_modules/openlayers/externs/oli.js",       "node_modules/openlayers/externs/olx.js",       "node_modules/openlayers/externs/cartodb.js",       "node_modules/openlayers/externs/proj4js.js",       "node_modules/openlayers/externs/tilejson.js",       "node_modules/openlayers/externs/topojson.js",       "node_modules/openlayers/externs/esrijson.js",       "node_modules/openlayers/externs/geojson.js",       "node_modules/openlayers/externs/bingmaps.js",       "node_modules/openlayers/externs/closure-compiler.js"     ],     "define": [       "goog.DEBUG=false"     ],     "js": [     ],     "jscomp_error": [       "*"     ],     "jscomp_off": [       "lintChecks",       "analyzerChecks"     ],     "extra_annotation_name": [       "api", "observable"     ],     "compilation_level": "ADVANCED",     "warning_level": "VERBOSE",     "generate_exports": false,     "output_wrapper": "(function(){%output%}).call(window);",     "use_types_for_optimization": true   } }
I generated ol-externs. js and placed it on externs folder. I keep getting "unsatisfied dependency 'ol. Map'". If I include ol.debug.js in src section I end up with a combination of ol +my custom classes. I just need my custom classes alone compiled. Any ideas?

@darkscript so, your code is ol-externs.js? I recommend you to keep separate OL and your code until it's done to use. then, you can simply merge and minifying both files. don't mix it up when you build OL itself.

The custom classes to be compressed are inside ros folder in [https://github.com/darkscript/custom-build-for-my-openlayers-api-using-closure/tree/master/src/ros](github link), I just need to minimize the files to one single min js. If I include link to ol files in src folder, then I end up with combined ol + my files. If I exclude ol files in src, then there this this error below of which I thought it would be solved by using ol-extern.js
ERR! Unsatisfied dependency "ol.Map" in script: C:\Users\Sam\Documents\sam\ros_compiled\src\ros\main.js

closure-compiler is not used anymore, closing.


removing the handlers from the variables and handlers role

Description
Handlers must follow order specified in their handlers file. Having handlers inherited by another role lead to them being run out of order.
https://stackoverflow.com/questions/35130051/order-of-notify-handlers
Fixes # (issue)
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules

Closing for this one which shouldnt have merge conflicts: https://github.com/confluentinc/cp-ansible/pull/315


Add ITypeDrawer for doubles, support visual debugging of enum masks

Hey, awesome! Thanks for contributing. Could you do me a favour. I merged your changes into develop and added MyDoubleComponent and MyFlagsComponent to the VisualDebugging project to test if it's working.
I added Item2 as a start value, but the drawer shows Item1.
https://github.com/sschmid/Entitas-CSharp/blob/develop/Entitas.Unity/Assets/Examples/VisualDebugging/VisualDebuggingExampleController.cs#L36
Would be great if you could look into this!

You have to make sure the enum constants are a power of two, also you should add a None enum constant:
[System.Flags]
public enum MyFlags {
    None = 0,
    Item1 = 1 << 0,
    Item2 = 1 << 1,
    Item3 = 1 << 2
}

See the FlagsAttribute docs and this stackoverflow answer for more info.

Just tested with my changes mentioned above... Still getting Item 1. :confused:

Found it! If you remove the None constant above everything works.
As soon as there is a constant with value 0 everything is off by one. This is a bug in EnumMaskField.

Ok, cool! Thanks


Removing the comma

any additional character like comma will lead to model error invalid_request_error 400 bad request

@mrbullwinkle
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Hi @jayendranarumugam, thanks for providing a potential fix. Unfortunately, it appears the 400 request error you are receiving is unrelated to the current example code. I tested to see if I could repro the issue you are encountering and was unable to do so:

This is a fairly standard functions example and other than the Azure OpenAI specific code for api key/endpoint/type/version this example is very similar to OpenAI's own examples for using functions, and the inclusion of those commas is identical in the corresponding OpenAI examples.

https://platform.openai.com/docs/guides/gpt/function-calling
https://github.com/openai/openai-cookbook/blob/main/examples/How_to_call_functions_with_chat_models.ipynb

Hi @jayendranarumugam, thanks for providing a potential fix. Unfortunately, it appears the 400 request error you are receiving is unrelated to the current example code. I tested to see if I could repro the issue you are encountering and was unable to do so:

This is a fairly standard functions example and other than the Azure OpenAI specific code for api key/endpoint/type/version this example is very similar to OpenAI's own examples for using functions, and the inclusion of those commas is identical in the corresponding OpenAI examples.

https://platform.openai.com/docs/guides/gpt/function-calling
https://github.com/openai/openai-cookbook/blob/main/examples/How_to_call_functions_with_chat_models.ipynb

Hi @mrbullwinkle thanks for getting back to me on this. I never tried this with any SDKs . I directly calling the REST APIs and getting this error.
The payload i used
{
    "messages": [
        {
            "role": "user",
            "content": "Find beachfront hotels in San Diego for less than $300 a month with free breakfast."
        }
    ],
    "function_call" : "auto",
    "functions" : [
            {
            "name": "search_hotels",
            "description": "Retrieves hotels from the search index based on the parameters provided",
            "parameters": {
                "type": "object",
                "properties": {
                    "location": {
                        "type": "string",
                        "description": "The location of the hotel (i.e. Seattle, WA)"
                    },
                    "max_price": {
                        "type": "number",
                        "description": "The maximum price for the hotel"
                    },
                    "features": {
                        "type": "string",
                        "description": "A comma separated list of features (i.e. beachfront, free wifi, etc.)"
                    }
                },
                "required": ["location"],
            },
        }
    ]
}

Used the same api-version=2023-07-01-preview
model: gpt-turbo-3.5-0613
Can you try with the payload above ? after removing the comma it worked for me. I dont know the SDKs internally removing the commas in between

    "messages": [
        {
            "role": "user",
            "content": "Find beachfront hotels in San Diego for less than $300 a month with free breakfast."
        }
    ],
    "function_call" : "auto",
    "functions" : [
            {
            "name": "search_hotels",
            "description": "Retrieves hotels from the search index based on the parameters provided",
            "parameters": {
                "type": "object",
                "properties": {
                    "location": {
                        "type": "string",
                        "description": "The location of the hotel (i.e. Seattle, WA)"
                    },
                    "max_price": {
                        "type": "number",
                        "description": "The maximum price for the hotel"
                    },
                    "features": {
                        "type": "string",
                        "description": "A comma separated list of features (i.e. beachfront, free wifi, etc.)"
                    }
                },
                "required": ["location"],
            },
        }
    ]
}

@jayendranarumugam thank you so much for the clarification. I can repro your issue when I test with a call directly against the REST API.
We can go ahead and merge your PR. I am not seeing any change in behavior in the Python example by excluding those commas. While the Python example will work either way I think it does make sense to remove any unnecessary confusion since the REST API will validate the JSON request body and throw an error. Thanks again for bringing this to our attention and taking the time to explain the repro steps.
Adding @dereklegenzoff for awareness.

#sign-off


Compilation failure: debug_draw not in scope

bevy_mod_picking version 0.16.0
When using cargo feature backend_egui but not backend_bevy_ui the crate fails to compile.
It looks like this is due to debug_draw being backed by the feature backend_bevy_ui but being added via the DebugPickingPlugin under a section conditionally added under the feature backend_egui and not backend_bevy_ui.

Thanks for the report, this is now fixed in https://github.com/aevyrie/bevy_mod_picking/commit/8f78621a6c03b73c0b896dc65af8b151d5e01bcc

Thank you for the excellent library!