shutting up debug messages

ldspdi logs crazy debug messages all the time, I can't find a way to stop them. @MarcAgate can you please look at this? This is high priority

This has been addressed now using a basic Logback.xml file in /etc/buda/ldspdi. Therefore, I think we can close this issue.

@eroux
Can we close this one now ?


Optionally deploy the workbooks

This PR makes the workbooks deployment optional, for cases where only the PowerBI reporting is needed.

Hi @wpouseele! Thanks for this PR! It seems you started considering DeployWorkbooks as something users would choose during execution or as silent deployment setting and you reverted later to a script parameter. I agree with your approach, but there are some left-overs of the previous approach (please review my in-line comments in the code). Otherwise, it looks good. Thanks!

Hi @wpouseele! Thanks for the fix/improvement. I will merge the PR and then do a small change in the "Do you want to deploy the workbooks? (Y/N)" question, recommending users to choose "Y", to get the full benefit from the engine.


Jetbrains PyCharm integration

@kghose
Hi, just discovered this tool through your talk for the CWL mini-conference 2021 (nice presentation btw).
Do you have an idea what would be the best approach to integrate this tool with Jetbrains PyCharm?
I would love to employ a good CWL syntax highlighter!

Hello @fmigneault !
Early on I tried working with PyCharm, but discovered that language server support was poor and brittle on PyCharm. It may be worth taking a second look now.
The starting point is this: https://plugins.jetbrains.com/plugin/10209-lsp-support which is PyCharm's LSP plugin.
There are instructions on how to add a configuration file for a language server here: https://github.com/gtache/intellij-lsp#add-a-language-server
Would you like to experiment with this? If you are successful I think this would end up as a PR on the IntelliJ LSP repo, or we could add instructions in this repo, like we have for VI.
Thanks!

That's too bad. I am really not familiar with LSP and the whole plugin creation pipeline.
I don't think I will have enough time between my other projects to experiment with this.


fix: add human readable error msg

Signed-off-by: lixd<EMAIL_ADDRESS>
What type of PR is this?

/kind flake
What this PR does / why we need it:
make kcctl user friendly
Which issue(s) this PR fixes:

Fixes #243
Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:

/assign @x893675

/lgtm
/approve


[stable/instana-agent] Add Affinity block

In order to be able to use anti-affinity to exclude certain nodes from this daemonset
Signed-off-by: Dan Ofir<EMAIL_ADDRESS>
Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@fstab @JeroenSoeters can you please review this PR?

@DanOfir would you please move this PR to https://github.com/instana/helm-charts/? Sounds like a great idea to merge, but merges on Helm Hub are no longer allowed.

@DanOfir we will merge this change with the upcoming version 1.1.4 of the helm chart. Meanwhile, due to the deprecation of Helm Hub, the new home of the Instana agent charts is https://github.com/instana/helm-charts.

merged by Instana team in official repo


Replace docker-py with python-on-whales

Use python-on-whales instead of docker-py as the former supports building with buildkit/buildx

docker-py looked abandoned when I opened this issue, but it seems that there's some activity again with a first new release on the horizon. Waiting this out just a little longer before committing to the switch to python-on-whales


Separate profile endpoint into 3 endpoints: profile, achievements, su…

Separate profile endpoint into 3 endpoints: profile, achievements, summary_stats
Cache summary_stats, achievements for an hour to optimize (no purge mechanism, just TTL of one hour)

@gzurowski will fix tests / add tests once I finish the frontend portion


Update button is not enabled unless a description is provided, but seems this is not a mandatory field.

I am trying to add few test cases where a false positive | resolved. But the "update" button is not enabled. But seems it has a dependency on the description field.
But I cannot identify this as a mandatory field.

Description is mandatory. Added a * to label.


Add texture slicer to visualize scalar maps

We would like to have the option of visualizing scalar maps behind our fODF glyphs (or instead of).

Issue transfered to https://github.com/scilus/dmri-explorer/issues/2


[Experiment]Check recompose

User can select list item.
Developer can see recompose by using RecomposeHighlighter

Codecov Report

Merging #172 (46974fd) into main (5b725d9) will increase coverage by 0.86%.
The diff coverage is 22.22%.

@@             Coverage Diff              @@
##               main     #172      +/-   ##
============================================
+ Coverage     30.21%   31.07%   +0.86%
  Complexity       38       38
============================================
  Files            55       56       +1
  Lines           695      724      +29
  Branches         93       99       +6
============================================
+ Hits            210      225      +15
- Misses          483      496      +13
- Partials          2        3       +1

Impacted Files
Coverage Δ

.../com/tfandkusu/template/compose/home/HomeScreen.kt
0.00% <0.00%> (ø)

...mplate/compose/home/listitem/GitHubRepoListItem.kt
0.00% <0.00%> (ø)

...tfandkusu/template/viewmodel/LiveDataExtForTest.kt
100.00% <ø> (ø)

...va/com/tfandkusu/template/viewmodel/LiveDataExt.kt
0.00% <0.00%> (ø)

...dkusu/template/viewmodel/home/HomeViewModelImpl.kt
97.72% <91.66%> (+0.75%)
:arrow_up:

...tfandkusu/template/viewmodel/home/HomeViewModel.kt
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b725d9...46974fd. Read the comment docs.


feat(bridge): Show service and time stamp on sequence details page

This PR:

adds the service image name (if it exists) or the service name to the sequence details page
replaces the existing duplicate sequence name label below the context with a time stamp on the sequence details page

Sequence details page with a service image name:

Sequence details page with a service name:

Related Issues

Fixes #6676

Hi @eyskim
many thanks for the PR! I'm not an Angular expert but reached out to the Keptn crew to review it. :)

@eyskim, when looking at the PR I have one direct feedback I would kindly ask to get addressed here. It is about the Context. This is a very technical detail that should not be so present here.

You get it also from the URL, or event payload.

[ ] I would like to ask you to remove this information from this screen.

Hi @laneli and @johannes-b. Thank you for the review! I've made changes as requested and added 2 cypress tests to check for the service name with an image tag and without. Please let me know if I should make any more changes.


[nrfconnect] Added Lighting-Switch-App example

Problem
Add Lighting-Switch-App example for nrfconnect boards.
Change overview

Added example of Light-Switch-App for nRF52DK and nRF53DK boards
Added documentation for example

Testing
Tested manually on nRF52DK and nRF53DK using lighting-app example as bound device.

I have a discussion with @markaj-nordic and we decided to merge chip-tool documentation and example documentation.


Issue with cyclomatic complexity

Hi guys,
The following function's cyclomatic complexity is computed to 1 by JSHint but it should be 2.
function main(any) {
  return (["string", "number", "boolean"].indexOf(typeof(any)) == -1) && any != null;
}

main(0);

Result of the demo page:
There is only one function in this file.
It takes one argument.
This function contains only one statement.
Cyclomatic complexity number for this function is 1.

Interesting. The logical "or" operator increases cyclomatic complexity, but the logical "and" operator does not.  This seems like a pretty glaring discrepancy, both conceptually and in terms of the source code. I can't find any discussion of this in the issue tracker, though. @rwaldron @caitp do either of you have any thoughts?


not portable posix api "pthread_getattr_np"

when porting to other posix compatible platform, the posix module may not be compiled due to the os_thread_get_stack_boundary  implementation, in which pthread_getattr_np is a GNU extension.
Is there any plan to replace pthread_getattr_np?

Yes, we may enhance the implementation: use pthread_getattr_np() for linux, and use pthread_get_stackaddr_np() for MacOS. Not sure what is your platform, and is there similar API to use?

My target platform has a ported version of musl-1.1.22/libc with partial pthread support of posix.
Unfortunately, there is no simliar api to use, but there are apis like pthread_attr_setstack and pthread_attr_setstacksize.
Is there any way to implement stack boundary when the thread is created with apis above?

The key problem is os_thread_get_stack_boundary can get pthread_t but there is no apis to get pthread_attr_t from pthread_t.
Another approach is implementing a hashtable for <pthread_t, stack_addr> and wrapping an invoking api to create a separate thread, which saves the stack_addr of this separate thread into that table, so that os_thread_get_stack_boundary can lookup the stack_addr on the go.


Detect when closed

Is it possible to know when the dialog closes?
When the user presses onBack it doesn't fire any closing event, is it possible to know when it closes?
Scenery:

Elegant Notification with progressIndicator
When the notification is showing the user presses 'on Back'.
The notification is hidden/closed.
Is it possible to detect that event? <--

Thank you!

Hello @thorito thanks for the suggesstion
I just added this scenery you can check in the latest version 1.6.2
https://pub.dev/packages/elegant_notification
Now when you use  onDismiss you will get notified when the back button is pressed (onDismiss is invoked)

It has worked well
Thank you


Feature request: view earliest commits

Gogs version (or commit ref):  <IP_ADDRESS>6
Git version: 1.9.1
Operating system: Ubuntu 14.04 LTS (64-bit)
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[ ] Yes (provide example URL)
[ ] No
[x] Not relevant

Log gist (usually found in log/gogs.log):

Description
In the current implementation, the user can view commits page-by-page. That means, if s/he wants to view the oldest/earliest commits, they have to click on the button 'Older' multiple times.
I suggest a button 'Oldest' that allows the user to view the oldest/earliest commits more easily.

I have implemented this in a down-stream fork, Gitea. Link to the relevant pull-request


feat: Belgium scraper

This PR adds a scraper for Belgium, scraping from Belgium's official source. It provides the following info:

cases provincially
hospitalized/discharged provincially
deaths regionally
tested nationally

Missing ISO code BE-WHT. @hyperknot was notified. Can be merged once this code is added to country-levels

Updates to country-levels:

added BE-WHT, FR-10
fixed FR-75, Paris

I'll be uploaded soon.

@hyperknot merge at will once it's ready!

This works great!
One issue is that Brussels should be added both as a county and a state, to make sure that the maps are covering both layers properly / adding up counts correctly.

The other is the tiny issue about the country assert line, I recommend removing it. Since country is fixed there is no point checking it.


[bug] Moving up/down effect on grayed out unused variables

VSCode Version: 1.25
OS Version: Ubuntu 18.04 LTS

Steps to Reproduce:
It's kinda hard to reproduce but you can try :

Have a function with 3 parameters, the middle one not used (should be grayed out)
Focus some lines inside the function
Make some scroll up/down
The unused param should move up/down

Does this issue occur when all extensions are disabled?: Yes and No
Without extensions, I can't manage to reproduce the auto-blink, but the grayed out param still moves up and down when I manually click a line inside the function after scrolling.

@HRK44 Can you capture your screen to show what you mean? I cannot reproduce:

@alexandrudima I'm using mouse scrolling, maybe that plays into account. Just a little up/down scroll then click on a line inside the function (to change the focus).

Another one with no extensions :

It looks like the usage of opacity for the unused decorations is causing grief with Chromium under Linux...

@HRK44 would you be willing to give some feedback if you can still reproduce this issue with a newer build that uses a newer Chrome version? You can download it from here. You will notice a new "VS Code Exploration" application with an orange icon.
Thanks!

@bpasero I didn't manage to reproduce the issue, looks clean


[DON'T MERGE]Add rebalance function

Allow us to move tokens from L1 LP to L2 LP

Codecov Report

Merging #128 (b03edf2) into develop (19b318e) will increase coverage by 17.79%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop     #128       +/-   ##
============================================
+ Coverage    71.73%   89.52%   +17.79%
============================================
  Files           68       33       -35
  Lines         2257     1079     -1178
  Branches       335      150      -185
============================================
- Hits          1619      966      -653
+ Misses         638      113      -525

Flag
Coverage Δ

batch-submitter
?

contracts
89.52% <ø> (ø)

core-utils
?

data-transport-layer
?

message-relayer
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/core-utils/src/coders/sequencer-batch.ts

packages/batch-submitter/src/index.ts

packages/core-utils/src/index.ts

packages/core-utils/src/fees.ts

packages/message-relayer/hardhat.config.ts

packages/core-utils/src/batches.ts

...itter/src/batch-submitter/state-batch-submitter.ts

...ckages/data-transport-layer/src/utils/constants.ts

...ckages/data-transport-layer/src/utils/contracts.ts

.../batch-submitter/src/transaction-chain-contract.ts

... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b318e...b03edf2. Read the comment docs.


⚠ Bofrost.fr has degraded performance

In c44fe38, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1890 ms

Resolved: Bofrost.fr performance has improved in 1424fbc.


Test in Lighthouse

Also consider adding as a GitHub action. See gaepdit/EPD-IT/issues/58 for background.

Initial test is pretty good (running locally).

Mobile test:


Feature request: Support to search prompts in the Prompt Store among many of them.

After imported awesome-chatgpt-prompts-zh from the default online import list, there are so many prompts in the store, with many pages, which may need you to turn the pages many times to find the one you need. A simple search could be very helpful in the scenario.

You can directly call it by entering the symbol "/" in the input box. However, adding a search function to this page is also necessary.

I believe it's done in af76b89fd4eb64f0d0056a8e62252fd9248d993e 👍


Favor ByteBuf Duplicates, NettyJsonContentAuthSigner and StreamChannelConnectionCaptureSerializer Refactoring

Description
This change seeks to simplify the complexity ByteBuf reading and duplicating indexes through use of .duplicate over .slice and being more intentional about side effects to the buffer after reading.
This change also seeks to harden NettyJsonContentAuthSigner by flushing the buffer in error cases and removing unnecessary release/retains.
Furthermore, moved to the Netty Base64 Encoder in ParsedHttpMessagesAsDicts to directly decode from ByteBufs.
Also, fixed up some trace logging that previously wasn't using a supplier to reduce unnecessary cycles.
This change also refactors StreamChannelConnectionCaptureSerializer to clean up the interfaces, improve performance, and remove bugs around chunking and serializing data.

Category: Refactoring
Why these changes are required? Simplify logic and make it easier to understand
What is the old behavior before changes and new behavior after changes? NettyJsonContentAuthSigner was less defensible around exceptions or handler being removed or channel closed scenarios and now will flush out buffer in those cases. ByteBufs are less likely to have their reader index modified unintentionally due to use of slicing.

Issues Resolved
MIGRATIONS-1696
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Unit testing
Check List

[x] New functionality includes testing

[x] All tests pass, including unit test, integration test and doctest

[x] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

I'd like to see the ByteBuffer conversion in the serializer be reversed. I think that it will be a big performance hit and won't always work as you are hoping that it would (making it less maintainable). The other comments should be minor/easy to address

I've updated the serializer to be more deterministic around edge cases and require less data copying. Please take a look at the latest revision


Request: Smooth scroll polyfill

Chrome and some other browsers are having issues with window.scroll, window.scrollToView, etc... Can you include a polyfill for this? Example: https://www.npmjs.com/package/smoothscroll-polyfill
Thank you!

If the behaviour is a web standard, sure!
https://polyfill.io/v2/docs/contributing/common-scenarios#new-polyfill

Hi, thanks for raising this. We love to see people wanting to extend the polyfill service to accommodate new features. We don't keep feature request issues open without a PR, but we do provide feedback on how enthusiastic we are to adopt the suggested idea. In this case, the feature you've suggested is moderately appealing to the core team, and we would be happy to receive a PR for it, and help you with reviews and testing, or with how to get started if you are a new contributor.  We would need to ensure that the polyfill is filling for a standard feature of the web platform, which we're not sure is the case here.
You can find out more about common contribution scenarios and how to make the perfect PR here:
https://polyfill.io/v2/docs/contributing/common-scenarios
If you need any further help before you submit your PR, feel free to reopen this issue!

I'm happy to submit a PR for this, if one is not currently in progress.

Hi @zgreen, feel free to submit a PR for this, one is not in progress :-)


Forward OpenFileInAppProvider calls for OCM shares to remote reva

Also closes #1032

@glpatcern nope, we append info to the list of shares. We'll update info only if there's no error returned from the webdav stat call, otherwise we'll just let it continue to have the stat response of the reference, which it previously did.

Can't do that with the current implementation. We're passing the same token around as the original user and can't make changes to it as we don't know the jwt secret of the other site. This won't be an issue in the public shares implementation so I think we can leave it be.


fix(core): window-specific event delivery, closes #3302

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Docs
[ ] New Binding issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes, and the changes were approved in issue #___
[ ] No

Checklist

[x] When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
[ ] I have added a convincing reason for adding this feature, if necessary

Other information

Any help testing this would be very welcome. I did some tests using the API example and the multiwindow example and it looks correct, but there might be other use cases that I didn't cover. I'll merge this so it can get more visibility.
Note that you need the next branch @tauri-apps/api package, so you'd need to clone the repo, cd tooling/api && yarn && yarn build && yarn link and yarn link it on your project.

I did some tests earlier and it seemed to work well in regard to the linked issue.
I also tried to test for unwanted side effects and didn't find any, but that's something you can't really be a 100% about, so take that with a grain of salt.

Thanks Fabian. Good thing we still have time to make tests and get feedback from the community (specially until the stable release) to get this working perfectly :P


No single letter variables

This allows _ to be used as a variable name, since it is conventionally
used for throwaway variables, but does not allow any other single letter
variables.
The target method of ast.Assigns will normally contain a list of nodes,
however for an unpacking assignment (such as 'a,b = c') it will contain
an ast.Tuple or an ast.List so we need to cover for all cases.

@MarcoGorelli This is giving an error with the mypy precommit hook (error: "expr" has no attribute "id” on line 22 of single_letter_variables.py) which I can’t figure out. It’s also more complicated than originally discussed to cover for a few edge cases, so I’m not sure if this is still along the right lines or not.

This is pretty neat.  _ makes sense to special-case.  Maybe also e.g. for i in range(...)? (i know we do that a lot in the cython code)

Thanks for taking a look - for i in range wouldn't be covered by this, as that's ast.For rather than ast.Assign
@klssmith if you mark this as "ready for review" we can merge it

Thanks for the comments.
@MarcoGorelli I've made the change needed to pass the mypy precommit check. I've not changed this to ready to review just yet because I've noticed that the col_offset in the error message can be misleading in a few situations. A file with this line
abc, d = (5, 6)

gives the warning of
test.py:1:1: PDF023 found assignment to single-letter variable

Since the single letter variable is at col_offset 6, I assume the message should read test.py:1:6: PDF023 ... in this case? If so, I can take a look at how the col_offset in error message can be fixed.

when you're in the for loop, does item have .lineno and coloffset attributes? If so, perhaps use those in the message?

👍 I was able to replace yield node.lineno, node.col_offset, MSG with yield item.lineno, item.col_offset, MSG as you suggested to get the col_offset working.

Thanks for the help @MarcoGorelli! I will check out pyupgrade


Added Topological Sort Algorithm

Added Topological Sort Algorithm to Graph Algorithms folder . It includes a README.md file and Program.c file containing the explaination and the implemenation of the problem and its solution respectively.

next time don't forget add issue number


Remove Hyper-V recommendation that conflicts HAXM.

@JonDouglas : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Document uses of ConnectionSharingAdapter

Summary
Please provide some discussion of the use of ConnectionSharingAdapter

Preconditions
I/O on more than one Characteristic using a BLE connection

Apologies for double-posting this: I first tried StackOverflow but need an answer ASAP.
I have been developing an app for a few months that connects to a BLE peripheral. The device has 4 characteristics: 2 write and 2 notify, all working simultaneously. I also monitor connection state changes and BLE signal strength.
It seems to be working OK without the use of ConnectionSharingAdapter, which I have only recently discovered. Have I just been lucky? When I first obtain the BLE connection, I store it in a static variable and reference the variable when I need a connection.
Could we have more extensive documentation of ConnectionSharingAdapter—what it does, when it's appropriate to use, etc.?

Hello @RobLewis
As for what the ConnectionSharingAdapter does - it is a very simple class and well named. It is an adapter that shares the RxBleConnection between different Subscribers of an Observable<RxBleConnection> (which comes most probably from RxBleDevice.establishConnection(boolean). You can look into the sources and check it out yourself.
When it is appropriate to use? I am against using it at all as any usage of reactive programming that needs more than one .subscribe() is introducing a state somewhere and it is harder to reason of what is actually going on. But you could potentially use it in a situation where you would want to perform more than one specific task independently and those tasks are independent of each other nor they can interfere (for instance reading two different characteristics).

Thanks. I almost understand what you're saying.
I've been using the following method to deliver Connection Observables to my various subscribers, and it seems to work:
    Observable<RxBleConnection> getConnectionObservable() {
        if( isConnected() ) {
            Log.d( LOG_TAG, "getConnectionObservable used existing connection");
            return Observable.just( bleConnection ); // variable where I store connection
        }
        else {
            Log.d( LOG_TAG, "getConnectionObservable re-establishing connection...");
            return bleDevice.establishConnection( NO_AUTO_CONNECT );
        }
    }

I'm thinking to replace this method with:
    Observable<RxBleConnection> getConnectionObservable() {
        return sharedConnectionObservable;
    }

And this:
    Observable<RxBleConnection> sharedConnectionObservable = this.bleDevice
            .establishConnection( NO_AUTO_CONNECT )
            .retry( CONNECTION_RETRIES )
            .compose( new ConnectionSharingAdapter() );

Am I on the right track?

Should work.

Hi, can we avoid using this class when we need to share the connection between multiple activity ? Let's suppose my app allows to control a ble device and there is multiple parameters (read battery stat, change a setting later, etc...)
Shoudln't the connection be kept (using the ConnectionSharingAdapter) for it to be more reactive ?
The other way around is to keep the RxBleConnection somewhere and unsubscribe when unneeded ?

As I noted in my OP, when I first obtain the BLE connection, I store it in a static variable and reference the variable when I need a connection. I use it to send data on 2 different characteristics, receive notifications on two others, and read the RSSI, all at the same time. It works across two different Activities and a bound Service. So I don't understand the need for a separate "connection sharing" component, though I would love to know the rationale for it!
At some point I will probably try inserting the ConnectionSharingAdapter to see its effect. But things seem to work fine without it.
I wrote up an analysis of the ConnectionSharingAdapter code for my own education. Here it is, if you're interested:
Observable.Transformer is a class with a call() method that takes Observable<T> as its argument and returns Observable<R>
Here, T and R are both RxBleConnection, so the Transformer implemented by ConnectionSharingAdapter
is transforming Observable<RxBleConnection> into another Observable<RxBleConnection>.
What it does:
	Instance member connectionObservable is an uninitialized AtomicReference to Observable<RxBleConnection> (so it's initially null).
	Thus connectionObservable has atomic get() and set() methods. Also, the call() method is synchronized on it. Should be thread safe.
	This call() method is supposed to transform one Observable<RxBleConnection> ("source") into another when invoked by .compose().
		It starts by getting the current value of connectionObservable (initially null) and copying it to rxBleConnectionObservable.
		If this rxBleConnectionObservable is not null, it is returned as the "transformed" Observable<RxBleConnection>.
		If it is null
			it creates newConnectionObservable from the supplied source
			adds .doOnUnsubscribe() that sets connectionObservable to null
			adds .replay(1) that returns a ConnectableObservable (doesn't emit RxBleConnection until ConnectableObservable's connect() method is called)
				(When connect() is called, all waiting Subscribers are served, but you can add more Subscribers later.)
				Any new subscribers get "replayed" the last 1 item emitted, which in this case would be the RxBleConnection.
			adds .refCount() that operates on a ConnectableObservable and returns an ordinary Observable:
				when the first Observer subscribes, it connects to the underlying ConnectableObservable
				when the last Observer unsubscribes, it disconnects (i.e., unsubscribes from the underlying ConnectableObservable)
			sets the instance member connectionObservable to this newConnectionObservable
			returns this newConnectionObservable

Narrative:
You use .establishConnection() to establish the RxBleConnection, then .compose() a new ConnectionSharingAdapter.
It transforms the Observable<RxBleConnection> into a different one:
The first Subscriber finds that the transformation hasn't taken place (connectionObservable is null), so
a new Observable is created that
	automatically connects to the original Observable when the first Subscriber comes along
	delivers the single RxBleConnection to the first and all subsequent subscribers
	when the last subscriber unsubscribes, unsubscribes from the original Observable and sets connectionObservable null so it will have to be re-created

Honestly, I still don't understand why it's needed. Can anyone explain?

For reference — in this stackoverflow answer is a part regarding ConnectionSharingAdapter

I guess there is no point in leaving this open.

I'll reopen it anyway, we'll document it more in the future.

I had some issues using the ConnectionSharingAdapter when dealing with a Rx chain that re-subscribes over and over again (e.g reading a characteristic periodically).
I had to use the following construct instead to prevent a re-connection to happen over and over again, when a characteristic is re-read. E.g:
// Scan for myServiceUUID, connect to it, and then read myCharUUID every 5 seconds
bleClient.scanBleDevices(settings)
        .filter { scanResult -> isMyService(scanResult.scanRecord.serviceUuids, myServiceUUID) }
        .take(1)
        .flatMap { scanResult -> scanResult.bleDevice.establishConnection(false) }
        .replay()
        .autoConnect(1)
        .flatMap { connection -> connection.readDescriptor(myCharUUID) }
        .take(1)
        .repeatWhen { completed -> completed.delay(5, TimeUnit.SECONDS) }

I needed the replay (and autoConnect) to make this happen. Using the ConnectionSharingAdapter, it kept reconnecting (kept calling establishConnection each time).

Hello @streetsofboston
That is the intended behaviour for ConnectionSharingAdapter. It allows for sharing the connection but it is not persisting it if there are no subscribers. So depending on how you have written the flow with ConnectionSharingAdapter it would connect each time a read was about to happen or persist the connection. If you have a flow with a single .subscribe() (which should be the case) then the ConnectionSharingAdapter is not needed at all.

Hi Darius,
In my example, the subscription happens over and over again, each 5 seconds, through the repeatWhen statement.
If I were to replace the replay and autoConnect with the ConnectionSharingAdapter, the re-subscriptions of the repeatWhen don't share the connection:
// Here, the myCharUUID is read every 5 seconds,
// but the `establishConnection` is called each time as well.
bleClient.scanBleDevices(settings)
        .filter { scanResult -> isMyService(scanResult.scanRecord.serviceUuids, myServiceUUID) }
        .take(1)
        .flatMap { scanResult -> scanResult.bleDevice.establishConnection(false) }
        .compose(new ConnectionSharingAdapter())
        // Share the connection?
        .flatMap { connection -> connection.readCharacteristic(myCharUUID) }
        .repeatWhen { completed -> completed.delay(5, TimeUnit.SECONDS) }

If i'm understanding correctly, the ConnectionSharingAdapter shares connections as long as the subscription-count is larger than 0. As soon as all subscribers unsubscribe (either through a terminal state of the observable or through a un-subscribe), the connection will be closed and no longer shared. Is this correct?

If i'm understanding correctly, the ConnectionSharingAdapter shares connections as long as the subscription-count is larger than 0. As soon as all subscribers unsubscribe (either through a terminal state of the observable or through a un-subscribe), the connection will be closed and no longer shared. Is this correct?

Yes, correct.
The above example would never complete until the connection would get lost though. The .establishConnection() is not completing on it's own unless an error happens or the downstream will unsubscribe. So the .repeatWhen() would never been called in the above code.

Thanks!
The example I gave is just showing the creation of the Observable of that characteristic. It doesn't show any subscription to that Observable. If the code in the example is all the code that there is, none of those things would happen, indeed; no scanning, no connection, no reading 😄

Yes but still even if you would subscribe to it-it would never complete and the .repeatWhen() would not be executed.

I modified the example somewhat, but the code is basically the same that I have in my project.
The code works; every 5 seconds the readCharacteristic is called....

There is a little bit of a difference between .flatMap { connection -> connection.readCharacteristic() }.repeatWhen() and .flatMap { connection -> connection.readCharacteristic().repeatWhen() } ;)
Either way- good that you have managed to get your use case to work.
To not be completely offtopic: I will try to wrap up the documentation for the ConnectionSharingAdapter in the near future (as this may be the only thing I may have time for).
Best Regards

Thank you, Dariusz! This library is great and makes working with BLE sooooooo much easier!

ConnectionSharingAdapter is going to be deprecated. Related to #379


deprecated code reference

https://github.com/andi611/Self-Supervised-Speech-Pretraining-and-Representation-Learning/blob/61e9edff0e0b7f5266f038bb096265f2bc392ffa/run_downstream.py#L23
But dual transformer doesn't exist since commit b7723c.
This lead to import and other errors

Hi, thanks for the heads up!
I've updated the code on master.


Integrated 0.2.0 from mxc-servcies.

Release 0.2.0

Version 0.2.0
Added

Nothing.

Changed

Abstract factories do not get pre-instantiated any longer. As other factories they
get instantiated and cached on first use. This has impact on all benchmarks which deal
with abstract factories, because the price of abstract factory instantiation gets measured
now.

Initializers do not get preinstanciated any longer. They get instanciated on first use.
This has performance impact on the first call to get, because initializer instanciation
get's mesured now.

The callback function iteratively created for delegators gets cached now.

Refactored the service resolution process for performance. Achievement around 10%.

Deprecated

Nothing.

Benchmark Comparison zend-master vs. mxc-master
Because of dropping pre-instantiation of abstract factories some benchmarks dropped in performance.
Rationale is that mxc-master does instantiation of abstract factories in get/has so time is measured,
while benchmarks do not measure zend-master abstract factory instantiation overhead at all. Same for
initializers. The benchmarks impacted most by that are marked with an asterrisk.
As of 0.1.0 we had the error that the test suites applied to zend-master and mxc-master were not
completely in sync. This was corrected in this version. The corrected benchmark unreveals that
setAlias and setOverrideAlias are much slower in zend-master than suggested by the 0.1.0 benchmark
comparison.
    $ vendor\bin\phpbench report --file=..\all.master.xml --file=..\all.020.xml --report="compare"
    benchmark: AbstractFactoryCacheBench
    +----------------------------------+-------------------+----------------+
    | subject                          | suite:master:mean | suite:mxc:mean |
    +----------------------------------+-------------------+----------------+
    | benchFetchServiceManagerCreation | 875.480μs         | 297.637μs      |
    +----------------------------------+-------------------+----------------+

    benchmark: FetchNewServiceManagerBench
    +-------------------------------------------+-------------------+----------------+
    | subject                                   | suite:master:mean | suite:mxc:mean |
    +-------------------------------------------+-------------------+----------------+
    | benchGetViaAbstractFactory                | 2.335μs           | 2.977μs        | *
    | benchGetViaCachedAbstractFactory          | 2.352μs           | 1.894μs        |
    | benchIfHasThenGetViaAbstractFactory       | 2.947μs           | 3.217μs        | *
    | benchIfHasThenGetViaCachedAbstractFactory | 2.958μs           | 2.158μs        |
    +-------------------------------------------+-------------------+----------------+

    benchmark: FetchCachedServicesBench
    +----------------------------------+-------------------+----------------+
    | subject                          | suite:master:mean | suite:mxc:mean |
    +----------------------------------+-------------------+----------------+
    | benchFetchFactory1               | 0.452μs           | 0.439μs        |
    | benchFetchInvokable1             | 0.470μs           | 0.448μs        |
    | benchFetchService1               | 0.454μs           | 0.440μs        |
    | benchFetchAlias1                 | 0.450μs           | 0.435μs        |
    | benchFetchRecursiveAlias1        | 0.468μs           | 0.456μs        |
    | benchFetchRecursiveAlias2        | 0.467μs           | 0.456μs        |
    | benchFetchAbstractFactoryService | 2.466μs           | 3.258μs        | *
    +----------------------------------+-------------------+----------------+

    benchmark: FetchNewServiceUsingConfigAbstractFactoryAsFactoryBench
    +-------------------------------------+-------------------+----------------+
    | subject                             | suite:master:mean | suite:mxc:mean |
    +-------------------------------------+-------------------+----------------+
    | benchFetchServiceWithNoDependencies | 5.020μs           | 4.507μs        |
    | benchBuildServiceWithNoDependencies | 4.617μs           | 4.187μs        |
    | benchFetchServiceDependingOnConfig  | 5.724μs           | 5.170μs        |
    | benchBuildServiceDependingOnConfig  | 5.160μs           | 4.840μs        |
    | benchFetchServiceWithDependency     | 5.662μs           | 4.990μs        |
    | benchBuildServiceWithDependency     | 5.275μs           | 4.663μs        |
    +-------------------------------------+-------------------+----------------+

    benchmark: FetchNewServiceUsingReflectionAbstractFactoryAsFactoryBench
    +-------------------------------------+-------------------+----------------+
    | subject                             | suite:master:mean | suite:mxc:mean |
    +-------------------------------------+-------------------+----------------+
    | benchFetchServiceWithNoDependencies | 3.967μs           | 3.518μs        |
    | benchBuildServiceWithNoDependencies | 3.556μs           | 3.343μs        |
    | benchFetchServiceDependingOnConfig  | 7.115μs           | 6.758μs        |
    | benchBuildServiceDependingOnConfig  | 6.594μs           | 6.467μs        |
    | benchFetchServiceWithDependency     | 8.422μs           | 8.001μs        |
    | benchBuildServiceWithDependency     | 7.896μs           | 7.694μs        |
    +-------------------------------------+-------------------+----------------+

    benchmark: FetchNewServiceViaConfigAbstractFactoryBench
    +-------------------------------------+-------------------+----------------+
    | subject                             | suite:master:mean | suite:mxc:mean |
    +-------------------------------------+-------------------+----------------+
    | benchFetchServiceWithNoDependencies | 5.314μs           | 5.870μs        | *
    | benchBuildServiceWithNoDependencies | 4.855μs           | 5.547μs        | *
    | benchFetchServiceDependingOnConfig  | 6.086μs           | 6.581μs        | *
    | benchBuildServiceDependingOnConfig  | 5.365μs           | 6.198μs        | *
    | benchFetchServiceWithDependency     | 6.002μs           | 5.962μs        | *
    | benchBuildServiceWithDependency     | 5.650μs           | 5.720μs        | *
    +-------------------------------------+-------------------+----------------+

    benchmark: FetchNewServiceViaReflectionAbstractFactoryBench
    +-------------------------------------+-------------------+----------------+
    | subject                             | suite:master:mean | suite:mxc:mean |
    +-------------------------------------+-------------------+----------------+
    | benchFetchServiceWithNoDependencies | 3.388μs           | 4.192μs        | *
    | benchBuildServiceWithNoDependencies | 2.869μs           | 4.005μs        | *
    | benchFetchServiceDependingOnConfig  | 6.677μs           | 7.660μs        | *
    | benchBuildServiceDependingOnConfig  | 6.129μs           | 7.488μs        | *
    | benchFetchServiceWithDependency     | 7.758μs           | 8.555μs        | *
    | benchBuildServiceWithDependency     | 7.496μs           | 8.135μs        | *
    +-------------------------------------+-------------------+----------------+

    benchmark: FetchNewServicesBench
    +----------------------------------+-------------------+----------------+
    | subject                          | suite:master:mean | suite:mxc:mean |
    +----------------------------------+-------------------+----------------+
    | benchFetchFactory1               | 2.836μs           | 2.664μs        |
    | benchBuildFactory1               | 2.414μs           | 2.209μs        |
    | benchFetchInvokable1             | 3.254μs           | 2.146μs        |
    | benchBuildInvokable1             | 2.648μs           | 1.693μs        |
    | benchFetchService1               | 0.470μs           | 0.439μs        |
    | benchFetchFactoryAlias1          | 2.427μs           | 2.233μs        |
    | benchBuildFactoryAlias1          | 2.450μs           | 2.224μs        |
    | benchFetchRecursiveFactoryAlias1 | 2.445μs           | 2.238μs        |
    | benchBuildRecursiveFactoryAlias1 | 2.475μs           | 2.234μs        |
    | benchFetchRecursiveFactoryAlias2 | 2.457μs           | 2.231μs        |
    | benchBuildRecursiveFactoryAlias2 | 2.461μs           | 2.229μs        |
    | benchFetchAbstractFactoryFoo     | 2.392μs           | 3.217μs        | *
    | benchBuildAbstractFactoryFoo     | 1.934μs           | 2.735μs        | *
    +----------------------------------+-------------------+----------------+

    benchmark: HasBench
    +-------------------------+-------------------+----------------+
    | subject                 | suite:master:mean | suite:mxc:mean |
    +-------------------------+-------------------+----------------+
    | benchHasFactory1        | 0.530μs           | 0.557μs        |
    | benchHasInvokable1      | 0.598μs           | 0.599μs        |
    | benchHasService1        | 0.477μs           | 0.535μs        |
    | benchHasAlias1          | 0.578μs           | 0.573μs        |
    | benchHasRecursiveAlias1 | 0.597μs           | 0.596μs        |
    | benchHasRecursiveAlias2 | 0.601μs           | 0.591μs        |
    | benchHasAbstractFactory | 0.834μs           | 1.619μs        | *
    | benchHasNot             | 0.841μs           | 1.545μs        | *
    +-------------------------+-------------------+----------------+

    benchmark: SetNewServicesBench
    +------------------------------------+-------------------+----------------+
    | subject                            | suite:master:mean | suite:mxc:mean |
    +------------------------------------+-------------------+----------------+
    | benchSetService                    | 2.020μs           | 0.647μs        |
    | benchSetFactory                    | 4.306μs           | 1.216μs        |
    | benchSetAlias                      | 19.030μs          | 1.952μs        |
    | benchOverrideAlias                 | 65.250μs          | 1.930μs        |
    | benchSetInvokableClass             | 5.301μs           | 1.229μs        |
    | benchAddDelegator                  | 3.482μs           | 2.065μs        |
    | benchAddInitializerByClassName     | 2.458μs           | 0.506μs        |
    | benchAddInitializerByInstance      | 1.772μs           | 0.548μs        |
    | benchAddAbstractFactoryByClassName | 3.524μs           | 0.738μs        |
    | benchAddAbstractFactoryByInstance  | 3.076μs           | 1.500μs        |
    +------------------------------------+-------------------+----------------+


Question re capabilities of icechunk/zarr

I am continuously downloading wind forecast gribs from NOAA and saving them raw in S3. Whenever I need to do calculations I download the relevant gribs from S3. Cumbersome because I have a whole metadata system in my DB to keep track of each file, and i end up having to download a lot of data from S3 that i just filter away in xarray.
Reason I wanted to try Icechunk was that it seemed like it might add query like capabilities where I could load pre-filtered data from an Icechunk store, as opposed to downloading the whole dataset from the store and then filter in xarray (tried to show example below). After trying, it seems more like it adds git like capabilities. Have I misinterpreted or can zarr/icechunk offer any such capabilities?
Pseudocode of desired behavior:
xr.open_zarr(icechunk_store, consolidated=False, filter=(dimensions= lat{-10 to 10} and lon{20 to 40})
or
xr.open_zarr(icechunk_store, consolidated=False, filter(dimensions= time{timestamp_x to timestamp_y})

Edit:
I see you have opened up the discussion tab now, so this question should probably been posted there.

Hello and welcome @kingkong-cmd! I think Icechunk, Zarr, and Xarray are a good solution here. Let me explain.
With Zarr and Xarray (with or without Icechunk), the idea is to build a single data cube that you can use to query your forecast data easily, rather than managing 1000s of individual grib files.
Here's an example of such a data cube for GFS

Reason I wanted to try Icechunk was that it seemed like it might add query like capabilities where I could load pre-filtered data from an Icechunk store, as opposed to downloading the whole dataset from the store and then filter in xarray (tried to show example below).

This already works today with Xarray and Zarr on S3, with or without Icechunk. The key point is that you don't have to "downloading the whole dataset from the store" in order to use Xarray's filtering. Opening the Zarr dataset with Xarray (with or without Icechunk) is an extremely cheap operation--it should definitely take less than 1s, and can take less than 100ms if you configure things correctly.
At that point, you can do operations like this
ds.sel(lat=slice(-10, 10), lon=slice(20, 40))

lazily, i.e. without downloading any of the data variables. Data are only loaded when you call compute, plot, or something else that requires the data be brought into memory. (How efficient this operation is depends heavily on the choice of chunking for your data cube.)
Does this make sense?
We did a webinar on this topic a few months ago. The recording is here.


Fixing few incorrectness and giving hints for FreeBSD for its future …

…portage.

Thanks!

Yeah this is great, thank you!


BZ:1275245 - Oracle DBs: Tasks is status 'Ready' not visible in task …

…list
The problem with the oracle database is Oracle11 considers the value '' as null. I added another condition to the dataset query to control that situation.

6.3.x: 34d5bfbdd064652d05f9ea3281b0acd02d07a38a
The fact that none of this code is tested / maintainable is very concerning. This particular error we would have only found with an integration test against Oracle, but we still need to investigate how to refactor this code/project to add more unit tests.

Thanks for the fix @nmirasch.

Please don't forget to send a PR to master if the fix should be applied there as well.


Track best time for each algorithm

Display the best time in the time display view
In the Algorithm cards, show the best time and the Ao5
The best time and the last 5 times are store in the local storage to be kept between sessions
Added the option to prioritise slow algorithms by sorting algorithm from the slowest to the fastest. (sorting is based on the best time of an algorithm)
Add a button to remove time for selected algorithms

ah, gotcha! sorry I thought it was a mistake, should have tested it first ;)
I reverted the commit and deployed the change, thanks for pointing it out.


Device Request popup > The first line of device inputted fields isn't displayed

Pre-Condition
User logins successfully and is on the W2 homepage
Steps to reproduce the problem

Click on "Device Request" option at the sidebar
Click on the "New Task" button
Observe the Device Request popup

Expected Result
The first line of device inputted fields should be displayed instead of the Add button
Actual Result
The first line of device inputted fields isn't displayed
Screenshots
ER:

AR:

Done


Make all CallbackResponse requests into a Werkzeug Request

The "request" object in CallbackResponse is the PreparedRequest send by
whatever client is used to contact the mocked moto service. This can end
up with unparsed bodies, as we added for processing presigned post
requests in #2155. This will make sure that all of the requests comming
in from mocked functions also get processed by werkzeug as if it was
running a live server.

I was thinking about this last night, and decided to take a stab at making it available of all functions this morning.

Coverage decreased (-0.06%) to 94.279% when pulling 50a147592debbbb5e887d40d34ae146dbb266cdd on gtmanfred:master into 4575f359c18fec836adce9a1cc850c9e5c69e2bd on spulec:master.


Create testnew.html

sample test do not merge

Can one of the admins verify this patch?

test commit


feat: Tests for new chains on Cayenne

Description
Tests for new chains supported on Cayenne.
Type of change

[X] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Manual Tests
Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my code
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] Any dependent changes have been merged and published in downstream modules

https://github.com/LIT-Protocol/lit-assets/pull/1135
https://github.com/LIT-Protocol/lit_node_admin_app/pull/46

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@DashKash54
Are these also on Manzano and Habanero if we publish this as a 5.0.1 patch will it work on all networks?

@DashKash54 Are these also on Manzano and Habanero if we publish this as a 5.0.1 patch will it work on all networks?

Not yet as the v0.1 release hasn't done for these networks

@DashKash54 Are these also on Manzano and Habanero if we publish this as a 5.0.1 patch will it work on all networks?

Not yet as the v0.1 release hasn't done for these networks

If we merge this into master then other networks will be able to use these additions? should we point this pr at staging/v6 instead? So we only publish it under the @cayenne tag?

If we merge this into master then other networks will be able to use these additions? should we point this pr at staging/v6 instead? So we only publish it under the @cayenne tag?

We can merge this after Habanero is deployed as it will contain these chains: https://github.com/LIT-Protocol/lit-os/blob/b5d56af53174d381fdc4de60c7a7319d506bb30a/components/common/salt/state/lit/core/blockchain/config/rpc-config.yaml#L1

@DashKash54
can you change the base branch to staging/v6

@DashKash54
Looks like ci is still running the old e2e tests, i think something is wrong with the branch. Would you be able to rebase it onto staging/v6 or just recreate the pr off of that branch?

Closing as branch has not been updated. @DashKash54 please re open with an rebased / fresh branch as the CI is not properly running when re targeting staging/v6


Remove deprecated method ProjectDependency.getProjectConfiguration()

Closed as superseded by https://github.com/gradle/gradle/issues/1716


git svn fetch failed (on svn tagging commit)

I'm trying to rebase my vapoursynth svn2git repo (that was initiated with svn2git -v --revision 2 http://vapoursynth.googlecode.com/svn/ command some time ago), but git svn fetch is failing on the svn commit performing tagging. (Same thing happens if you want to run svn2git from scratch.)
$ svn2git --rebase --verbose
Running command: git status --porcelain --untracked-files=no
Running command: git branch -l --no-color
* master
Running command: git branch -r --no-color
  repo.or.cz/master
  svn/trunk
Running command: git svn fetch
Found possible branch point: http://vapoursynth.googlecode.com/svn/trunk => http://vapoursynth.googlecode.com/svn/tags/R15, 331
Use of uninitialized value $u in substitution (s///) at /usr/share/perl5/Git/SVN.pm line 106.
Use of uninitialized value $u in concatenation (.) or string at /usr/share/perl5/Git/SVN.pm line 106.
refs/remotes/svn/trunk: 'http://vapoursynth.googlecode.com/svn' not found in ''

command failed:
2>&1 git svn fetch

I upgraded to git 1.8.0 (from debian unstable repository), but it didn't help.
The referenced part of SVN.pm is below
 89 sub resolve_local_globs {
 90         my ($url, $fetch, $glob_spec) = @_;
 91         return unless defined $glob_spec;
 92         my $ref = $glob_spec->{ref};
 93         my $path = $glob_spec->{path};
 94         foreach (command(qw#for-each-ref --format=%(refname) refs/#)) {
 95                 next unless m#^$ref->{regex}$#;
 96                 my $p = $1;
 97                 my $pathname = desanitize_refname($path->full_path($p));
 98                 my $refname = desanitize_refname($ref->full_path($p));
 99                 if (my $existing = $fetch->{$pathname}) {
100                         if ($existing ne $refname) {
101                                 die "Refspec conflict:\n",
102                                     "existing: $existing\n",
103                                     " globbed: $refname\n";
104                         }
105                         my $u = (::cmt_metadata("$refname"))[0];
106                         $u =~ s!^\Q$url\E(/|$)!! or die
107                           "$refname: '$url' not found in '$u'\n";
108                         if ($pathname ne $u) {
109                                 warn "W: Refspec glob conflict ",
110                                      "(ref: $refname):\n",
111                                      "expected path: $pathname\n",
112                                      "    real path: $u\n",
113                                      "Continuing ahead with $u\n";
114                                 next;
115                         }
116                 } else {
117                         $fetch->{$pathname} = $refname;
118                 }
119         }
120 }

I don't see anything special in r332. Any ideas what's wrong and how it can be fixed? It's definitely not about quoting apostrophes or quotation marks, as they aren't there.

This issue seems to happen because of the password issue.  I ran into this issue after finally fixing the password issue mentioned in #59 and #195.  Removing all lines containing tags and branches (not just the duplicates) from .git/config allowed me to continue.

Thank you, @the-real-trash80 . Removal of section for remotes in git/config worked for me too.

Will this be automatic anytime soon?


Handle encrypted secret values

Values like client secret in github, gitlab, google and bind password in ldap can be represented as and encrypted file. https://docs.openshift.com/container-platform/3.11/install_config/master_node_configuration.html#master-node-configuration-passwords-and-other-data
This means that CPMA should download key and encrypted file, decrypt file content and pass decrypted value to secretgen function. All decryption logic is placed inside fetchStringSource() in oauth.go

When I ran it outside of $GOPATH it seemed cli-runtime/pkg/genericclioptions/printers/ was in conflict with another imported package.

This is obsolete as secret are handled differently.
If needed please create a new issue.


sql magic commands not working properly

Document section at below link mentions that "%%sql?" can be used to see the help section for this magic cell command.
However its not working and throwing below error.
"Invalid input! database name not provided."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9d6aa152-5044-1011-2d67-72e6a241ed94
Version Independent ID: 1451bf17-f088-9874-9b8e-4c89a151f6f9
Content: Use built-in notebook commands and features in Azure Cosmos DB Python notebooks (preview)
Content Source: articles/cosmos-db/use-python-notebook-features-and-commands.md
Service: cosmos-db
GitHub Login: @deborahc
Microsoft Alias: dech

@chetansir Thank you for the feedback. We are actively investigating and will get back to you soon.

@chetansir Sorry for the trouble you are having. Could you please provide the complete error message and also the exact command you are executing either through screenshots or you can copy paste them here?

Please find below.
Capture 1 shows command working for respective DB and container

Capture 2 shows '%%sql?' magic command mentioned in documentation for viewing out the help section of this command, however it doesn't works. Neither via capture 1 script nor capture 2

@chetansir  I tested the commands and also ran into the same issue. I reached out to our product group for clarification.

@chetansir This is being assigned to the content author to evaluate and update as appropriate.

@chetansir this is a bug, our team is working on a fix.

Our dev team made a fix which will be rolling out to production around 09/08 week.

Hi Team,
Any updates on this. the magic command still doesn't work in azure.

@chetansir the fix isn't yet deployed, I am checking with our team on the next deployment date.

Hi Team,
Did we reached any conclusion on the magic commands.

@chetansir Yes, the commands are working now. The output shows help content when you run them.

We will now close this issue.

#please-close


dead link to bids-validator in the docs

Hey,
I noticed that the link to the BIDS-validator in the docs is dead, probably because the underlying repo has moved. The bad link should now point to http://bids-standard.github.io/bids-validator/ . Do you want a PR with the fix?

That'd be great!


issue with getting nixos-wsl working with nixos-vscode-server:

Hello @Trundle ,
Just thought that maybe you could take a look at this nixos-vscode-server issue that I'm having, it might have something to do with nixos-wsl because I'm unable to get them connected and working?
https://github.com/msteen/nixos-vscode-server/issues/2
Thanks in advance for the help!

The underlying issue is, that the systemd user deamon does not get started, because no session for the user is ever started.
The user-mode deamon can be started by running systemctl start<EMAIL_ADDRESS>(assuming that nixos is the username of the default user). This will work temporarily until WSL is restarted for the next time.
My permanent fix was to add the following to my configuration.nix:
  systemd.services.autostart-user-daemon = {
    wants = [<EMAIL_ADDRESS>];
    wantedBy = [ "multi-user.target" ];
    path = [ pkgs.coreutils ];
    script = "true";
  };

This adds a unit that does nothing itself, but depends on the user@-unit and is started automatically, causing the user@-unit to be started when WSL starts.

As of 89c644e7178abc4abf51e4d1c82222ec18f9878a the systemd user daemon gets started and many issues get fixed too. Make sure to update!

The user daemon does indeed get started now and nixos-vscode-server works. However, trying to connect with the WSL remote in VSCode fails now (log attached). I managed to connect by enabling the SSH server in NixOS and then using the SSH remote to connect to localhost, but that is more of a workaround than a real fix
Log file

I'm also able to get nixos-vscode-server to load nixos in windows vscode, but whenever I try to load the terminal or nix-env-selector I get errors similar to @nzbr . I'm going to use ubuntu+nix in wsl for now, until this issue gets fixed,
thanks in advance for helping fix this issue!

The terminal does not work, because the nixos-vscode-server package uses an outdated version of nodejs. There are two open PRs against the nixos-vscode-server repo that fix this issue. The issue with the terminal is not limited to NixOS-WSL but instead affects NixOS installations on real hardware as well. As a workaround I am using my fork of the nixos-vscode-server repo until one of the PRs gets merged

@nzbr ,
Thanks, I'll take a look at that,
and here's a similar issue if any of you want to take a look:
https://github.com/msteen/nixos-vscode-server/issues/2

As of 89c644e the systemd user daemon gets started and many issues get fixed too. Make sure to update!

 Do I have to build the tarball from source and do wsl --import [...] again?
Thanks for your great work!

Extremely late reply but...
You mostly update only the nix and sh files, you manually merge the changes in your own config.

A fix has been merged and is included in the latest release


DBZ-1546 Remove whitespaces between table.whitelist regexes

The table whitespace parameter should remove whitespace between regular expressions
since tables cannot start with whitespace characters.
https://issues.jboss.org/browse/DBZ-1546

@grantcooksey Applied, thanks!

Appreciate the help!


Silence warnings about puts versus log

Summary
Replace puts with log to silence Cucumber warnings.
Details
This replaces puts with log in the After scenario hook that prints output of failed commands when the scenario fails.
Motivation and Context
Cucumber's old puts behavior is deprecated. This change silences warnings from Cucumber about this.
How Has This Been Tested?
I re-ran one scenario that fails on my machine to see if the warnings disappeared.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue).
[ ] New feature (non-breaking change which adds functionality).
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

[ ] I've added tests for my code.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Lets merge #498 in first which fixes part of the CI issue. There's also some other bits I've been working on. But this can go in before those.


Cannot find 'Type 🐞

Playground Link
No response
Description
I have the same problem but angular version 17
https://github.com/taiga-family/ng-web-apis/issues/116
. any solution?

Version:
"@ng-web-apis/common": "^3.0.6",
"@ng-web-apis/speech": "^3.0.7",
"@angular/common": "17.0.2",
"@angular/compiler": "17.0.2",
"@angular/core": "17.0.2",

Angular version
17.0.2
Taiga UI version
3.0.6
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[X] Windows
[ ] Linux
[ ] iOS
[ ] Android

I had the same issue. Yarn told me to install @types/dom-speech-recognition.

After add this to compilerOptions in tsconfig.json and make sure that theese options are not overridden in tsconfig.app.json it worked for me:
    "typeRoots": ["node_modules/@types"],
    "types": ["node", "dom-speech-recognition"],

Modern npm should automatically resolve peer deps, if you use a tool that does not do it on its own (yarn, apparently 🙂) — you should do it yourself, that's what peer deps are all about. Thank you for suggesting how to do it 👍


networking.firewall.extraCommands: should run before all drop/reject

Describe the bug
networking.firewall.extraCommands should run before any drop/reject is specified, so that the user is allowed to input firewall rules before that.
Currently I need to add a rule before iptables -t raw -A nixos-fw-rpfilter -j DROP, but I am not allowed to do so, as it is added before extraCommands run.
Currently I remove and add it again.
To Reproduce
Steps to reproduce the behavior:

Try to add someting before the above specified
See it is added after
...

Expected behavior
Should be added before the rule e.g.
-A nixos-fw-rpfilter -i tun0 -j RETURN
-A nixos-fw-rpfilter -j DROP

not
-A nixos-fw-rpfilter -j DROP
-A nixos-fw-rpfilter -i tun0 -j RETURN

Metadata

system: "x86_64-linux"
host os: Linux 4.19.72, NixOS, 19.03.173481.8a30e242181 (Koi)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.2.2
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: networking.firewall
# a list of nixos modules affected by the problem
module: networking.firewall

Just wanted to add this description from the option, as it seems valid to put in here:
Additional shell commands executed as part of the firewall initialisation script. These are executed just before the final "reject" firewall rule is added, so they can be used to allow packets that would otherwise be refused.

Basically when it states so they can be used to allow packets that would otherwise be refused., I would assume it to allow to put things into any table, before drop/reject rules.

I no longer use this, and not sure it's an issue anymore. Reopen otherwise :)


add hexo-plugin-gitalk and hexo-plugin-readmore

Check List

[X] I want to publish my plugin on Hexo official website.

[X] I have read the plugin publishing doc.
[x] name is unique.
[x] link URL is correct.

“公众号”翻译为“public number”，这是否有点…
You shall not translate "公众号" as "public number".
"official account" or "public account" is better.
IMHO, removing such plugin is even better for the Internet. LOL.


single demo grasp + updates based on input consistency

Hi Amir, is there a reason why you are making the PR from a fork instead of cloning opendr directly and adding your changes to a branch from master ? It's easier for us to add commits if necessary and I don't need to approve the tests manually for them to run.
PS: to fix python formatting errors (automatic test sources test) this helps
PS: I tested the previous PR locally and it was working. I'll do the review as soon as I can

Also, the CI machines don't have graphic cards, so for the test you need to switch to cpu as done in other tools.

Hi
Alright. I'll update it accordingly
Best regards,
Amir

From: ad-daniel @.>
Sent: Friday, December 10, 2021 2:02:47 PM
To: tasostefas/opendr_internal @.>
Cc: Amir Mehman Sefat (TAU) @.>; Author @.>
Subject: Re: [tasostefas/opendr_internal] single demo grasp + updates based on input consistency (PR #166)
Also, the CI machines don't have graphic cards, so for the test you need to switch to cpu as done in other tools.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/tasostefas/opendr_internal/pull/166#issuecomment-990914597, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALR3TD4B6WH7YMSAOGK3D73UQHT6PANCNFSM5JYZKQBA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@amirmehman21 last comment I swear, it's also missing the documentation page for the learner class, to be added under docs/references and its contents should be similar in format as done for other tools.
When done, you should also add a reference to this documentation in the index.md.

Hi @amirmehman21, have you been added as contributor yet?
Just some points that need to be addressed (in the separate PR when you open it).

I've tested the demo locally and works nicely.
The unittest doesn't rely on webots, so it might not be a good idea to install webots when running  install_single_demo_grasp.sh. It is needed by the demo though, so I would instead just add these instructions directly in the readme of the demo
PROTO cache files should not be included in the PR (should be added to a gitignore)
I haven't been able to successfully run the unittest locally. It attempts to find the GPU still.

As soon as the other PR is up I can help you with some of these points

Hi
I am still waiting for the contribution invitation.
About the points:
I will remove webots installation scripts from install_single_demo_grasp.sh and update readme as suggested. Also, I will add proto cache files to git ignore.
In the last PR that I sent, I did not modify tests to use cpu but it is corrected in the version that I’m gonna make the direct PR again. For that, I am still waiting for the invitation.
Best regards,
Amir
From: ad-daniel @.>
Sent: Monday, 13 December 2021 11.43
To: tasostefas/opendr_internal @.>
Cc: Amir Mehman Sefat (TAU) @.>; Mention @.>
Subject: Re: [tasostefas/opendr_internal] single demo grasp + updates based on input consistency (PR #166)
Hi @amirmehman21https://github.com/amirmehman21, have you been added as contributor yet?
Just some points that need to be addressed (in the separate PR when you open it).

I've tested the demo locally and works nicely.
The unittest doesn't rely on webots, so it might not be a good idea to install webots when running install_single_demo_grasp.sh. It is needed by the demo though, so I would instead just add these instructions directly in the readme of the demo
PROTO cache files should not be included in the PR (should be added to a gitignore)
I haven't been able to successfully run the unittest locally. It attempts to find the GPU still.

As soon as the other PR is up I can help you with some of these points
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/tasostefas/opendr_internal/pull/166#issuecomment-992281810, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALR3TD6S5ZE5IW2OAIEJAP3UQW533ANCNFSM5JYZKQBA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I think we can close this for now, as we have the other PR open.


Bring generated code up-to-date

I didn't call generate.ps1 after one of the changes.

Completed successfully in DevOps


psutil, expect and setlocale

I am packaging this for openSUSE, and noticed that it was using ps.  I noticed because that isnt in the standard rpmbuild image, so I got file not found errors in the execs.  I wonder if it would be possible to use the Python package psutil instead, as that would make the tests a bit more independent of the host environment.
Also it is using expect.  pexpect is another alternative.
Then this package can declare all of its test dependencies, and packagers will have an effortless time ;-)
Then the remaining problem I am facing is the test suite uses setlocale, which isnt working in an rpmbuild environment, causing the tests to fail like this:
   30s] > sh: warning: setlocale: LC_ALL: cannot change locale (en_US.ascii)
[   30s] 81a88

Working area at https://build.opensuse.org/package/show/home:jayvdb:py-new/python-better-exceptions

Feel free to open a PR if it fixes it :) would love to have less of a dependency on running commands such as that.


Add metric to count the number of cases where memory exceeds quota

What problem does this PR solve?
Issue Number: close #7289
Problem Summary:
What is changed and how it works?
Add TiFlash metric to support the count of cases where memory exceeds quota.
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/cc @bestwoody

/merge


Adds action to lint conventional commits.

@nealrichardson and I are using conventional commits to keep the Git changelog clean. This change adds a GitHub action to verify that the pull request title uses the conventional commit syntax in the title.
Since we are forcing "Squash and merge", developers can continue using whatever commit title they want for individual commits. By default, those commits will be squashed into the commit body.
To test the GitHub action functionality, try fixing the title of this pull request to match the style guide.

I like this pattern a lot - it'll both make it easier to grok the commit history and opens up the possibility of scripting interactions with our git history. Very cool.
Do we need something in place to guide how commit types can (if they should) shift over time? Say we find certain commit types are noisy, or we need one that isn't enumerated here.

IIUC this only runs on new PRs, so if we want to modify the list of commit types going forward, we just edit the workflow.

I like this pattern a lot - it'll both make it easier to grok the commit history and opens up the possibility of scripting interactions with our git history. Very cool.
Do we need something in place to guide how commit types can (if they should) shift over time? Say we find certain commit types are noisy, or we need one that isn't enumerated here.

Thanks for taking a look! The commit types are configurable via the GitHub Action. As @nealrichardson mentioned, we can modify these as scenarios arise.


TypeError: Class constructor Component cannot be invoked without 'new'

We are using the latest version (v8.1.4) of jsx-dom just fine during development, but after promoting the code to production, we are encountering an error such as TypeError: Class constructor Component cannot be invoked without 'new'. After debugging the issue, it appears to be an error assoicated with the minification of jsx-dom in webpack in mode: "production".
Webpack in production mode is defaulting to using the TerserJSPlugin, which is inadverantly stripping some code from jsx-dom that is annotated with /* @__PURE__ */. This removal is preventing class components that extend React.Component from getting assigned the isReactComponent property, which is what jsx-dom is using to determine class vs. functional components. The initComponentClass() method is then skipped and the class is trying to instantiate as a function, which then throws this uncaught exception.
If we inject into our own code the same Object.defineProperties() line of jsx-dom that is getting stripped out, our production build seems to work as intended.  Was this annotation in the code intentional? This particular line was added to fix issue #86, but seems unrelated.
I have attached a sandbox.zip file containing a minimal example project that should demonstrate the issue, where index.tsx contains a bit of code that can be toggled, showing the Object.defineProperties line is required.
Thank you!
EDIT: I've also set up a codesandbox if that is preferred over the attached zip.

Published as 8.1.5. It is now checked by Component.isComponent, a static class property.

The new v8.1.5 seems to fix the issue in our example project!
Thank you again for the quick turn-around!


Using powermock to mock static methods in BluefloodServiceStarter

yeah, this is definitely the way to go :+1:

I love it! :+1:
cc: @izrik


Feature request: Checkpoint on time delta

It would be nice if there was the ability to create checkpoints based on the amount of time spent training, rather than a fixed number of epochs, e.g. -checkpoint_every 30m or -checkpoint_every 2h.
Also a -max_checkpoints flag would be nice so that you can have a rotating, finite number of checkpoint files. I have a long running job that's created over 125GB of checkpoints and is hitting the HDD capacity cap.

I agree. I am also working on specifying checkpoints by epoch rather than batch, e.g. so -checkpoint_every 0.5e does a checkpoint every half epoch.

@ChrisCummins any progress on implementing this?


Bug fix: for renaming venus-data.tar.gz in post-hook.sh

Bug fix: Renaming of the venus-data.tar.gz file to venus-data_installed.tar.gz in post-hook.sh was not working, because of wrong use of '$dir'

Nice catch, thanks!

Are you sure? It seems strange to me, that it does not work with absolute paths.

Yes, because the issue is that $dir already gives the absoluut path.
So in the original code:
for dir in /media/*; do
    if [ -f "/media/$dir/venus-data.tar.gz" ]; then

Will be converted to:
/media//media/mmcblk0p1/venus-data.tar.gz

Found also another one. I pushed a commit in my repo, so it is available more faster. Thanks!

No problem, happy to help!


evaluate the relative depth

Good job.  What method should I use to evaluate the relative depth error of the depth anything v2 model? I tried to use the method of depth anything v1 to evaluate depth anything v2, but I found that the result error was very large, and there seemed to be some problems.
https://github.com/isl-org/DPT/blob/main/EVALUATION.md
v1 pixel value:  0 - 227.5
v2 pixel value:  0 - 7.25

Hi @QingshuiL
The relative depth results need to be scaled and translated in order to compare them with any other (e.g. ground truth) results. This is a result of the training, which only aims to get the relative ordering of the pixel values correct, but not the absolute values.
The relative results are also 'inverted' compared to actual depth. The formula to get depth using the relative predictions is something like:
Depth = 1 / (A + B * prediction)
(Where prediction is the output of the depth anything model)
The A and B terms are the scaling/translating terms needed to make a proper comparison with ground truth values.
Figuring out A and B can be done using a least-squares fit. There's a discussion of this on the original MiDaS issue board (issue #171). Someone also posted some example code for doing this (issues #268).
Alternatively, you could try comparing results using inverted depth. In that case you'd probably want to normalize the depth-anything prediction (e.g. from 0 to 1) and compare that to a similarly normalized ground-truth. Though this will be sensitive to the min/max values used for normalization. A better approach may be to use the normalization from the original MiDaS paper (see page 6, equations 5 & 6)

Thank you very much for your guidance. I've learned a lot more about relative depth. I feel the method you mentioned should be correct.


chore: trigger workflow from fork

Description of changes
(Give an overview. Add a technical description describing your changes.)
Pull request checklist

[ ] Addresses an existing issue: Fixes #0000
[ ] Added relevant unit test for your changes. (yarn test)
[ ] Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
[ ] Ran precheckin (yarn precheckin)

/azp run


Module support

Do you have any plans to allow shoestring to be imported, either through require() or ES6 import?

Related: would you consider switching from AMD to ES6 imports and setting to allow modern bundlers to use jsnext:main as an entry point, and eliminate unused code from making it to the final bundle?

We actually only use modules as part of the build. I just added a form of UMD as a stop-gap for now in #124

It seems that even when shoestring is imported as a module, it pollutes the global scope, setting window.shoestring and window.$. This breaks things when shoestring is used within a library that is in turn used in the context of a page that already includes jQuery (#129).
Looking at the bespoke UMD wrapper added in #124, the path for a non-module (i.e. browser) environment relies on the factory() function to assign globals as a side-effect, rather than assigning the return value of factory() itself. As a result, even in a module-supporting environment, the global scope is still polluted, leading to #129 and rendering shoestring unusable for many use-cases.
Fixing this should be fairly straight-forward, I'll send through a PR with a fix shortly.


Pasting html double-indents second line

VSCode Version: Code - Insiders 1.15.0-insider (f39385b8326671dc6389f21f8c2e2f6afdb352a1, 2017-08-01T05:07:59.267Z)
OS Version: Darwin x64 16.6.0
Extensions: none

Testing #31831
Pasting into an empty html file, then formatting:

It might make sense to align with the formatter's result. Maybe just run the formatter when the file's content is replaced?

The clipboard has the tags without indentation:
<html>
<head>
</head>
<body>
</body>
</html>

Let's track this issue in https://github.com/Microsoft/vscode/issues/32320 which has a lot of user inputs there. This case will be considered as well .


Project text box loses value while creating a new running Time Entry

Case<PHONE_NUMBER>7, on macOS app:
(1) Click the START button
(2) Click the words "(no description)" to pop out the edit panel
(3) Begin typing in the "What are you doing?" field. The autocomplete choice I want appears in the autocomplete panel below.
(4) Click on my autocomplete choice with the mouse. The Description field fills in with my autocomplete selection, but not the Project field. (I think the Project field should also fill in at this point, but that's not why I'm writing.)
(5) Press TAB. The Project field fills in with my autocomplete selection.
(6) Now click at the end of the text in the Description field (because I want to add more text to the end of the string). The Project field clears. I think this is the wrong behavior. In Step 4 I affirmatively indicated that I wanted to select that Project, so the default behavior at this point should be to keep the value in the Project field, even though I haven't formally confirmed it yet.
(I also think the Project textbox should be filled when autocomplete is selected as well.

duplicate of #2596


Destruction of bound popup source element on closing.

I am binding an element to it's associated marker popup via marker.bindPopup(document.getElementById("popup_"+id)).  Once the popup is closed, the element is destroyed. If I had assigned it to a variable, that variable is now null and I can no longer re-query the element with document.getElementById.  Is there a less destructive way to close the popups that would allow manipulation and querying after the popup has been closed?
*Note: the source element remains in it's original location upon passing it to .bindPopup, and returns to the DOM once the popup is re-activated.  To reproduce this you must first activate the popup and then close it.

Can you set up a test case to demonstrate the issue (http://playground-leaflet.rhcloud.com/ for example) ?

Unless I've misunderstood you, this works fine.
http://playground-leaflet.rhcloud.com/cip/edit?html,output
Click the marker to do the popup with the content.
Then hit the button, and it can still use the original dom node.
I've saved the content to a variable (window.popupContent), which stays around even after putting it in the marker.
You cannot use document.getElementById to get it anymore as the content of the element are used for the popup.
ref http://leafletjs.com/reference.html#marker-bindpopup

There are nodes in the popup that i want to manipulate programmatically, like hiding and showing different data. I render the popups elsewhere but then hand them over to leaflets popup module when I initialize the map. Everything works fine up until the first time the popups are closed. They still appear, but I no longer can get a handle on them otherwise to read/write to those nodes.
Sent from my iPhone

On Oct 8, 2015, at 15:27, Dave Leaver<EMAIL_ADDRESS>wrote:
Closed #3698.
—
Reply to this email directly or view it on GitHub.

Oh. Thank you!
Sent from my iPhone

On Oct 8, 2015, at 15:27, Dave Leaver<EMAIL_ADDRESS>wrote:
Unless I've misunderstood you, this works fine.
http://playground-leaflet.rhcloud.com/cip/edit?html,output
Click the marker to do the popup with the content.
Then hit the button, and it can still use the original dom node.
I've saved the content to a variable (window.popupContent), which stays around even after putting it in the marker.
You cannot use document.getElementById to get it anymore as the content of the element are used for the popup.
ref http://leafletjs.com/reference.html#marker-bindpopup
—
Reply to this email directly or view it on GitHub.


Function keys block published content

The three function keys of the publish content area block the content that needs to be published

Yes, this is a known issue from previous versions. We aim to address this with improvements in both interaction and display in the next version. Thank you for your feedback.

Ok, thank you very much


Comparing a collection of a ComplexType with just ComplexType properties return no differences when IgnoreCollectionOrder is used.

Hi Greg
I think I found a bug where it returns that two lists of a complex type are equal, even though they have differences, when they are compared using IgnoreCollectionOrder set to true.
It fails because it tries to create a key using the properties of the complex type, but since all properties are also complex types, it can't generate one and then it treats all as duplicates.
[Test]
public void IgnoreOrderListOfComplexTypeWithNestedComplexType()
{
    CompareLogic compareLogic = new CompareLogic();
    compareLogic.Config.IgnoreCollectionOrder = true;

    var obj1 = new List<ComplexType> {
        new ComplexType {Item = new Item {Value = "20"}},
        new ComplexType {Item = new Item {Value = "21"}}
    };
    var obj2 = new List<ComplexType>
    {
        new ComplexType {Item = new Item {Value = "20"}},
        new ComplexType {Item = new Item {Value = "20"}}
    };

    var result = compareLogic.Compare(obj1, obj2);
    Console.WriteLine(result.DifferencesString);
    Assert.IsFalse(result.AreEqual);
}

public class ComplexType
{
    public Item Item { get; set; }
}

public class Item
{
    public string Value { get; set; }
}

This is a known limitation.
https://github.com/GregFinzer/Compare-Net-Objects
You will need to add a primitive type to your complex type.  For best performance define a collection matching spec.

This is a known limitation.
https://github.com/GregFinzer/Compare-Net-Objects
You will need to add a primitive type to your complex type.  For best performance define a collection matching spec.


Add /v2/flush

Add a new route /v2/flush which requires an Authorization header to be set (with the value Basic <WEBHOOK_TOKEN>)

Should we also a version of https://github.com/gnosis/safe-client-gateway/blob/main/src/routes/about/routes.rs#L101 that uses the header?

Yes I think that makes sense. I will target that in a different PR

Should we also a version of https://github.com/gnosis/safe-client-gateway/blob/main/src/routes/about/routes.rs#L101 that uses the header?

Yes I think that makes sense. I will target that in a different PR

https://github.com/gnosis/safe-client-gateway/pull/816
Still missing some tests regarding token validation on this endpoint.


BotFrameworkAdapter processActivity() Error: unable to get local issuer certificate

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Version
What version of the Emulator are you using.
My application working in bot emulator version 4.2.1 but if i update with 4.3.0 or above gives error.
Describe the bug
Give a clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to 'Start the Bot locally and run the development version in emulator'
Click on '....'
Scroll down to '....'
See error : unable to get local issuer certificate

Expected behavior
The BOT should display the start screen and re-direct to the login screen for authentication using Azure AD. The way it works on Version 4.2.1
Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
[bug]

This might be related to #1354

@tonyanziano  It's working fine in production environment but while running locally gives local issuer certificate error.

Anyone got any solution for this. we are also facing the same issue

Hello @ChandraSannamuri. Do you still see the issue when using the "Clear State" menu option?

I am having the same issue. The clear state does not help.

@rprecioso can you describe the scenario in which you are experiencing this error?


Private repositories

Is there a way to make it work with private repos. I only found exemples using public repositories. I didn't tried it yet, but it seems that we can't pass public key or whatever like for "server" function.

You can use new forward agent functionality or add your servers keys to your repositories.

The fact is my repository know my server key (but the key contains a passphrase).
I use "dep deploy -vvv" on my local machine, the connection to my server is ok, but when cloning the repository, it fails "permission denied". So I manually did the git clone displayed with the "-vvv" option on my server, it asks for my key, and the clone is a success...

Dear @creakiwi
I also met a problem as you, and I have to use features forward agent successful to solve that problem.
The first, you need to setup your system support forward agent.
On your local machine, content file ~/.ssh/config :
Host <your-server-ip>
  ForwardAgent yes

On your server, uncomment line #AllowAgentForwarding yes in file /etc/ssh/sshd_config to allow agent forwarding feature.
AllowAgentForwarding yes
#AllowTcpForwarding yes
#GatewayPorts no
#X11Forwarding no

Reload sshd service on your server.
$ sudo service sshd restart

Test forward agent from your local machine.
$ ssh-add /path/to/your-key-file
$ ssh <username>@<server_ip>
$ ssh-add -l

Check your key really loaded.
Finally, using deployer v3.0 and forward agent feature.
server('your-server', 'xxx.xxx.xxx.xxx', 22)
    ->user('username')
    ->forwardAgent()
    ->stage(['dev'])
    ->env('deploy_path', '/var/www/apps/yourappname')
    ->env('branch', 'master')

Wish you success !!!
Refs:
https://developer.github.com/guides/using-ssh-agent-forwarding/
https://github.com/oanhnn/deployer-example

Thanks for you answer @oanhnn, I'll try that tonight. (I'm handling the @creakiwi account).
Your deployer-example repo seems to be a good start, thanks for your additional informations about ssh configuration.


migrate setup and black

migrate setup.py to setup.cfg
migrate to use black as opinionated auto formater
add .git-blame-ignore-revs
fix docs compatibilty problem with Sphinx>=5.0.0
global: clean test infrastructure

the error is not on invenio-drafts-resources side. the error is in invenio-records-resources. how should we handle this? i think to fix this error we would have to create a exception handling in invenio-drafts-resources, and a proper checking of bucket in invenio-records-resources

oh and it seams it is a heisenbug! i ran the tests locally and on the first run there where two errors.
invenio_records_resources/records/systemfields/files/manager.py:set_bucket bucket.id NoneType has no Attribute id
invenio_records_resources/services/files/components/content.py:set_file_content bucket.size_limit NoneType has no Attribute size_limit
but after adding some pprint(bucket) statements. the error is gone.


bridge: remove unneeded struct

Signed-off-by: Mike Schore<EMAIL_ADDRESS>

Missed that this isn't used anywhere now.


Support for dynamic imports in body

We're leveraging dynamic imports and standard keeps complaining: "Parsing error: 'import' and 'export' may only appear at the top level"
Eslint supports suppressing this via the "allowImportExportEverywhere" parser option, but standard doesn't seem to read the .eslintrc file. /* eslint-disable /* doesn't work either.
Is anyone aware of a way to ignore this check?

/* eslint-disable */ should work...
May I ask how your setup is? I thought that dynamic imports where made via a function call (e.g. import('./foobar').then(() => /* ... */)) instead of using the import keyword?

@corvana-nbaker Are you referring to the allowImportExportEverywhere option that babel-eslint takes?

Yes! How can I get "allowImportExportEverywhere" to take effect with standard?

It appears that the allowImportExportEverywhere option is specifically for allowing import and export statements to work anywhere, effectively emulating how require() works.
I don't think this should be necessary if you're using the dynamic import() syntax.
Using babel-eslint@8 and standard@11, I am unable to reproduce this issue. It lints import() perfectly fine as far as I can tell.
Also, this appears related to: https://github.com/standard/standard/issues/1041


Complete README.md

Write first version of README.mdwith title, authors, affiliations, table with information and instructions for setting up the environment before the tutorial.
Fix #2
TODO:

[x] Change environment and Slack channel name to t21-thurs-harmonica (need to wait if it's possible to change the channel name)
[x] Check @aguspesce name, website url and affiliation(s)
[x] Check @andieie  name, website url and affiliation(s)

@andieie @aguspesce please check if your names and affiliations are correct. Feel free to make suggestions if any change is needed (go to Files changed tab, use the + symbol next to the line(s) that need some change and use the Insert a suggestion button in the text box).
After you checked that your information is right, please check the checkbox in the PR description.

I'll merge this. If anything needs some modification, we can do it later in a different PR.


Security: Bump terser-webpack-plugin to address CVE-2020-7660

The Problem
react-scripts-3.4.1 relies on terser-webpack-plugin-2.3.5 which then relies on serialize-javascript-2.1.2, which is vulnerable per https://nvd.nist.gov/vuln/detail/CVE-2020-7660.
My Ask
Can terser-webpack-plugin be bumped to 2.3.7, which relies on serialize-javascript ^3.1.0? This would address this vulnerability.
This is similar to #8159.

They've already fixed it in master (https://github.com/facebook/create-react-app/pull/8950/files) so I guess we should wait for the next release?

Good catch, yeah, looks like next release should get us there.

Does anyone know when the next release happens?

Do we know when this release will be coming?

IMO it's still valid and a new release would be much appreciated :)

Bump - this is still an issue and there still has not been any new release.

@AjkayAlan - Not sure if this is helpful or not for you but raised this discussion for confirmation as I have noticed their have been newer releases but also I am aware CRA 4 is also in progress so wanted to find out if these fixes are safe to use now
https://github.com/facebook/create-react-app/discussions/9484

@AjkayAlan - I managed to get an answer here in #9484 about the new versions and getting this fix released
https://github.com/facebook/create-react-app/discussions/9484#discussioncomment-52089

Thanks @olliecurtis! Based on the new release existing in npmjs, I think it solves our issue.
Closing.


Consider using different notify icon on windows 10

User thinks the current icon looks out of place/is distracting, compared to Windows 10's default black and white icon style.
We could think about changing the icon to a more modern version.

Not a concern for now.