Add force-package argument

This is a brute-force way to allow some tacos that fail the packager's validation step to still be packaged. For example, the recent Dremio issue where the validation rules were wrong and forced them to incorrectly add required attributes.
Tested with the Dremio scenario, and it would have worked for them. For connectors with actual XML issues, the file list is not generated so if --force-package is used the packager will crash with a python error. This is fine in my opinion, those connectors would not load in Tableau anyway, we give plenty of warning, and we're not looking to document this outside of the built-in help for the packager.

Hi, @pvanderknyff! Thanks for opening this PR!

In the file connector-packager/connector_packager/package.py:

Line 104:121: E501 line too long (193 > 120 characters)
Line 38:121: E501 line too long (243 > 120 characters)

For reference: Error Code Reference, PEP8, Python code style


[Key Vault - Keys] Remove test resources failing in nightly runs

Key Vault - Keys nightly test runs are failing with:

Error message:
expected 'CannotVerifyCopySource' to deeply equal 'OperationTimedOut'
Stack trace:
12:32:55 PM - Deleting resource group 'rg-keyvault-t3a95b6459b5a4b8f'
VERBOSE: Running registered exit actions.
VERBOSE: Logging out of service principal '***'
Remove-AzResourceGroup : The request was canceled due to the configured HttpClient.Timeout of 100 seconds elapsing.
At D:\a_work\1\s\eng\common\TestResources\Remove-TestResources.ps1:248 char:5
Remove-AzResourceGroup -Name "$ResourceGroupName" -Force:$Force
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
CategoryInfo          : CloseError: (:) [Remove-AzResourceGroup], TaskCanceledException
FullyQualifiedErrorId : Microsoft.Azure.Commands.Resources.RemoveAzureResourceGroupCmdlet
##[error]PowerShell exited with code '1'.

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1731615&view=results

@praveenkuttappan @xirzec the same issue here.

/cc @jsquire


Adjust internal command Update-SqlDbOwner

Type of Change

[x] Bug fix (non-breaking change, fixes #2775 )
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Update command to use message system and camel-cased variables (no more squiggle lines in VS Code)

kaww that's been broken a while, eh! thank you


please add Slider

Please add Slider!
see
https://getuikit.com/docs/slider
https://getuikit.com/docs/slideshow
with
Thumbnav
https://getuikit.com/docs/thumbnav
Thanks!

@Andrey-2021, closing this issue as a duplicate of #629. Pull requests are welcome too!


[W-8930428] - Aging Disbursements Report

Introducing "Aging Disbursements" report and additional Story Telling Data.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Definition of Done to see any additional details for the items below:

[ ] Any net new LWC work has JEST test coverage 50% or above
[ ] Default Sa11y tests pass for all LWC components
[ ] 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
[ ] 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
[ ] Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
[ ] Make sure that ACs are updated (if any gaps)
[ ] All acceptance criteria have been met

[ ] Developer
[ ] Code Reviewer

[ ] Pull Request contains draft release notes
[ ] Labels, help text, and customer facing messages are reviewed by Docs
[ ] QE story level testing completed

[W-8930428] - OFM - New Report of Aging Disbursements


CaptureScreen

With respect to CaptureScreen function, if no parameters are filled in and the screen scale is not 100%, the intercept is not full screen, which is equivalent to calling CaptureScreen (0,0, width* zoom, height* zoom), so that the block is not full screen.

Closed because of duplicates #129 and #135, the current zoom ratio only supports windows, the plan has not been updated yet.

May update code and other platform support in the future.

Closing is due to can't reproduce on windows7, and duplicates #129 and #135, call api processing by yourself.


fix: fix the issue in downloading windows e2e logs

What type of PR is this?

What this PR does / why we need it:
fix the issue in downloading windows e2e logs
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.486%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3727

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.486%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3727

💛  - Coveralls


Complexs

Are we happy with this name?
Use num_complex on a feature switch to implement this.
struct Rcomplex {
   inner: num_complex::Complex
}

impl Deref for Rcomplex {
   fn deref(&self) -> num_complex::Complex {
      self.inner
   }
}

https://github.com/extendr/libR-sys/blob/c184e9de8683fa36bef03a2f95bce4ed91ebe769/bindings/bindings-linux-x86_64-R4.1.rs#L2778-L2783

num_complex::Complex<f64> should map to the R complex datatype.
A vector cast to this type should behave as expected.


[RFR] Permissions reset

Describe the bug
Creating a RFR in the channel removed the 'everyone can't message' perm, reset it to default instead
To Reproduce
Numbered steps to reproduce the behavior:

Set perms for everyone to 'send messages' = False
Create a RFR in that channel
@ everyone 'send messages' will be set back to defaults

Expected behaviour
'send messages' should not be altered, only add reactions
Screenshots
N/A
Additional context
N/A

All text channel permissions reset when altering them. Not just sending messages.

All text channel permissions reset when altering them. Not just sending messages.

Fixed, issue, problem lied in implementation of overwrite permissions, cannot reuse. The same one, will create PR soon.


New rule: Disallow spaces inside of computed properties (computed-property-spacing)

https://eslint.org/docs/rules/computed-property-spacing
Replace our custom computed-property-even-spacing rule from eslint-plugin-standard with the eslint rule that just disallows spaces

Ecosystem impact: only one package effected.
Definitely should do this to be consistent with the array bracket rule that will be in standard 13.


python3Packages.curio: fix darwin network tests

Motivation for this change
trying to fix azure-cli build for darwin
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Notify maintainers
cc @

@GrahamcOfBorg build python3Packages.curio

This package is broken for darwin anyway, merging to master.
No rebuilds on linux


Transaction interface

Add transaction interface to wiki.

IGraph -> IOperations
IGraph : UOperations, ITransactionFactory
ITransaction : Ioperations + BeginTransaction()

Done.


Bug: Multisite not working

Terms

[X] I have read the guidelines for Contributing to Roots Projects
[X] This request is not a duplicate of an existing issue
[X] I have read the docs and followed them (if applicable)
[X] I have seached the Roots Discourse for answers and followed them (if applicable)
[X] This is not a personal support request that should be posted on the Roots Discourse community

Description
What's wrong?
After many attempts at configuring multisite on production (Forge Laravel) I redeemed it impossible to configure.
What have you tried?

Using various forks for plug-in "Fixes" that offers redirects (https://useful-forks.github.io/?repo=roots/multisite-url-fixer)
Messed with .env
Messed with config/application.php, enabled and disabled about everything
Messed with nginx config (without messing up laravel forge's settings), trying various redirects and default settings
Added .htaccess manually but even when providing it with a simple redirect, it won't budge. (Placed it in "/web")
Used 3 servers (together with other websites, standalone PHP8.1, standalone PHP7.4)

What insights have you gained?

Digging through the WP files and adding "/wp" results in a infinite redirect
Disabling "MULTISITE" allows me to install Wordpress like normal, enabling this will revert it back to its unusable state (but DB is filled now)

Possible solutions

Revert to another version of Bedrock

Temporary workarounds
None found so far
Steps To Reproduce

Setup bedrock and a theme of choice and deploy to Gitlab/Hub/etc.
Use Laravel Forge (or any other hosting) to provision a server
Link GiT and deploy the project
Idk what steps are recommended, obviously nothing works 😔

Expected Behavior
It works
Actual Behavior
It doesn't
Relevant Log Output
No response
Versions

Hi @Pondake! GitHub issues are meant for reproducible bug reports. Support requests should be posted on https://discourse.roots.io/.
Bedrock is multisite compatible. Bedrock does nothing with regards to server configuration. You might find the multisite configs and docs from Trellis helpful.


Master

Resolves
https://trello.com/c/YYpI3Voi/52-create-more-detailed-developer-documentation-as-we-progress
Proposed Changes
Added initial user documentation, to be further refined and updated in future sprints.

You are trying to merge master into develop? Also why are you committing to master, since it is just documentation it is not the end of the world but all of this should be done on a different branch and then merged into master to make sure that master remains our one working copy.


Update MD file on new branch 2017-18-17_07-11-35

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Change to use Vite?

Is your feature request related to a problem? Please describe.

Electron Forge now supports Vite.
It is ok to change the compile system to Vite, I think.
I heard VIte is easy to configure and superior regarding hot reload.
But I heard before that Vite doesn't have type-checking.
Describe the solution you'd like

Migrate to Vite.
Describe alternatives you've considered

Continue using Webpack.
Additional context

Type-check should be executed outside of build process. For example, we can just call tsc --noEmit for type check.
Or, if you want more rich support for type check, you can use vite-plugin-checker


Add option to formatter to forcibly align function arguments

like
call(a = b,
      b = c, c = d,
      ...

C# doesn't do it since argument alignment is a very personal thing.


The Active Conflict Is Barely Noticable

I think the border should be thicker and the color should have more contrast.

I think the thicker border is a little too heavy but agree that the light themes in particular suffer from a contrast issue. Do you think it's as much of a problem on the dark themes?

Do you think it's as much of a problem on the dark themes?

It works much better on the dark themes (maybe also because my code-oss uses dark theme)

Ok, I'll propose some updates this week 👍

Before Light:

Before Dark:

After Light:

After Dark:


Add possible ban warning

ReShade (and by proxy, Bloxshade) isn't risk free. It requires DLL injection which COULD trip the anti-cheat which CAN AND WILL result in a permaban for exploiting. This ban warning will also protect you from legal liability in the event some knucklehead DOES get banned using this and tries to take you to court over it. Also, with Roblox staff being far too corrupt, we can never be too safe. RTX Remix would be a better idea as RTX Remix hijacks the rendering pipeline on the GPU level rather than the software level and shouldn't trip the anticheat. Bloxshade appears to be Nvidia ONLY so phasing this out for an RTX Remix implementation would be wiser.
The ban warning should be at the very top of the readme in bold, and on the first page of the installer.

bloxshade doesn't inject anything and depends on Nvidia Ansel something that is part of the Nvidia display driver so there isn't any risk using it

Bloxshade uses ReShade. Says so right on the tin (the first page of the installer) and ReShade works via DLL injection. Even if we don’t use DLL injection, there is still a non-zero chance that Roblox will start issuing permabans for using this. Roblox has done it in the past with FPS unlockers. There is inherent risk; therefore a ban warning should be added. It should go something like this:
“Bloxshade uses ReShade, which accomplishes shader effects via DLL injection. There is a NON-ZERO chance that Roblox will terminate your account IF you use Bloxshade. In any case, the developers of Bloxshade SHALL NOT AND WILL NOT BE HELD LEGALLY LIABLE IN THE EVENT THAT DOES HAPPEN.”
Again, we should be using RTX Remix as there’s less risk involved.

bloxshade doesn't use reshade it uses Nvidia Ansel and Nvidia Ansel is based on reshade and thus compatible with reshade fxc shaders

also bloxshade doesn't inject anything as I said Nvidia Ansel is part of the Nvidia display drivers and thus has direct access to the rendering pipeline

Then we should update the screenshots in the readme as now it’s clear those screenshots are obsolete. I mean, the first one literally mentions ReShade and that was the brick in the window that started the riot.

also, this is a response from someone who works at Roblox.

Then we should update the screenshots in the readme as now it’s clear those screenshots are obsolete. I mean, the first one literally mentions ReShade and that was the brick in the window that started the riot.

it mentions reshade because it's configuring reshade shaders for nvidia ansel because nvidia ansel uses the reshade fx programming language

the screenshots aren't obsolete or out of date the only difference between the screenshots and the current version are the image on the side

the screenshots aren't obsolete or out of date the only difference between the screenshots and the current version are the image on the side

I'm going to admit, this stemmed from a simple misunderstanding and Bloxshade isn't transparent enough. We should rewrite "This installer will set up and configure ReShade FX shaders tailored for Nvidia Ansel on your computer." and maybe add a line of text to the installer that clearly states that Bloxshade is risk-free. And by making the installer far more transparent, you'll avoid repeats of issues like this.

I don't think it is necessary to do that. if you have any questions dm me on discord "extravi."

I don't think it is necessary to do that. if you have any questions dm me on discord "extravi."

But we should maybe add a line to the readme that expressly states Bloxshade is risk free to avoid a situation like this again and maybe also add an FAQ.

I don't think it is necessary to do that. if you have any questions dm me on discord "extravi."

But we should maybe add a line to the readme that expressly states Bloxshade is risk free to avoid a situation like this again and maybe also add an FAQ.

I don't think so


Sorting package / convention for (start, end) and (left, right)

The convention is not consistent across sort methods: sometimes the end/right point is inclusive, sometimes not.
This is in https://github.com/non/spire/blob/master/core/src/main/scala/spire/math/Sorting.scala
Suggested steps:

[ ] Document the existing convention
[ ] Verify that we test for the boundary conditions. If not, write additional tests
[ ] Harmonize the convention across methods

If you all are interested in help with this, I'm happy to crack at it this weekend assuming no one beats me to it.

Yes, please do!
When harmonizing, I suggest reusing the Java convention where end is not inclusive.
Anyway, it is not possible to allocate arrays bigger than INT_MAX - 2 or so.

@stephen-lazaro Let me know if you need on that issue!

Thanks! Sorry there hasn't been much movement on this, got caught up in work a bit more than I expected.

@stephen-lazaro @denisrosset To become more familiar with Spire, I took a crack at this. I just submitted the pull request.
Mainly I added some unit tests so as to make tweaking the implementation safer. As per the suggestion, the indices are now consistent in their meaning across the methods (end is always exclusive).

Solved by #738 ! Thanks


Update the returned Embed for the perms command

Issue:

If NOT using the <prefix> help perms command to get the description of the perms command, it could be confusing as to whether the permissions listed are for the bot itself or the user issuing the command

Resolution:

The title of the command lists the bot's name (Silk) to let anyone requesting know the command is specifically about the bot
There is a description below the title which is pulled from the DescriptionAttribute Attribute decorated on the method, which gives the full details as to what the command does and who it's aimed at

Updated look w/ my guilds prefix: silk

Updated look w/ my guilds prefix: silk


HTTP/2 support

Hi,
Is there any plan to support HTTP/2 in Koa?
Thanks!

you can use https://github.com/indutny/node-spdy, which AFAIK supports HTTP 2
koa is server agnostic - just create wrap the app in whichever server implementation you'd like.
if you were looking for a http push helper, you can try https://github.com/jshttp/spdy-push

Hi @jonathanong, thanks for clarifying that Koa is server agnostic, I will look into the server implementation that best suits my use case!
Apart from this, in Koala's docs there's a section that states:

Once SPDY becomes an HTTP standard and is baked into node.js, some of these features will be placed in Koa.

In my understanding, HTTP/2 has replaced and extended the SPDY protocol (which will not be supported from Google from early 2016 onwards).
As for the differences between SPDY adn HTTP/2, some information can be found in the Wiki link that I posted in the first comment: https://en.wikipedia.org/wiki/HTTP/2
Putting the two pieces of information together, I wondered if there was any plan to integrate HTTP/2 as the standard app.listen() in future Koa versions.
Cheers!

app.listen() will continue use require('http') by default. we just gotta wait until node supports http2 out of the box.

I'm curious if anyone actually got this to work. I was trying to use node-http2 and this very simple example:
var http = require('http2');
var koa = require('koa');
var app = koa();

var options = {
  key: fs.readFileSync('./localhost.key'),
  cert: fs.readFileSync('./localhost.crt')
};

var handleRequest = function*(next) {
  this.body = 'Hello World';
  yield next;
  console.log('done');
};

app.use(handleRequest);
http.createServer(options, app.callback()).listen(8080);

never completes the request. From the client perspective, the request is 'pending' forever, and there are no errors in node. The line console.log('done'); is hit and writes to the console.
If I swap the require from 'http2' to 'http' then it works fine.

Confirmed what @rally25rs mentioned about node-http2 module. I had the same issue today with<EMAIL_ADDRESS>Also traced down to response.writable. Good catch!

As of release 3.3.2 (maybe earlier) of node-http2, the response object has a .socket property as suggested by @temchentw above.

I was just about to raise up an issue on node-http2. Thanks @pieterb for the comment. But at the moment I forked from node-http2, it's 3.3.2 and there's no response.socket exists.
I also checked their latest code but with no luck. Would you mind to point out where it is?

Adding it to node-http2 seems like fixing the wrong thing to me; response.socket is an implementation detail of node's http implementation that is not a documented part of the API, so other libraries (namely koa) shouldn't rely on its existence.

Hi @tomchentw, there was a link in my earlier comment, but here's link to the specific version, file and line:
https://github.com/molnarg/node-http2/blob/v3.3.2/lib/http.js#L506

Oops, I'm mistaken: that commit introduced request.socket. You're talking about response.socket. No, this hasn't been introduced into node-http2. Please send the pull-request!

@pieterb what do you think about the comment from @rally25rs ? I'm concerning about it too and I'm seeing my fork of node-http2 is just a hacky solution.

@tomchentw I'd say Er comment makes a lot of sense. I've been trying to understand the relevant bits of code in koajs and node's core http and https modules, but I don't feel confident enough to create a pull request.
To be honest, I don't (fully) understand the reasoning behind testing the socket's writability in the first place. AFAICS, the intention is to check if the user has bypassed koa's response object and called res.write() or res.end() on the underlying lower-level reponse object. The test was introduced in commit 9fe483ca767b64de3e9b9e2c78b7bfaf420861c2, without explanation.

I've been looking into this a bit further. There's some interesting discussion on this topic in issues #142 and #143. I suggest we continue this discussion under #143, and convince the koa team to undo that commit (9fe483ca767b64de3e9b9e2c78b7bfaf420861c2).

Please make a nice way to use http2 with koa without having to resort to writing a full infrastructure around spdy or similar :)

@kristianmandrup I'm playing around with node-spdy and koa@2 and have gotten a fair bit.
There's a brief explanation along with some code examples over at node-spdy#277
Semi working as of now, at this point I can push resources out to the client w/ manifest support.
It doesn't work quite as well when bumping up the amount of resources to push (from ~5 to ~100) as it seems to always end up in a ton of FLOW_CONTROL_ERROR's so I'm definitely doing something wrong.
I'll see about extracting the necessary bits of code into a repo where it's easily hackable.

@kristianmandrup I've pushed what I have so far into this repo https://github.com/kasperlewau/koa-h2-man-pusher.
It's still very much a work in progress. There's a couple of examples in the /examples dir that can be run with node server.js. That will bootup a SPDY server w/ self signed certs on port 3000. The examples cover three cases; 16, 100 & 200 assets pushed to the client.
Again, it's not quite what you're asking for as far as spdy support within koa goes - but I suppose it's a start 😄

@kasperlewau Sweet :) Good job!

is it worth reopening this issue now that node is about to support http2 from the core?
https://medium.com/the-node-js-collection/say-hello-to-http-2-for-node-js-core-261ba493846e
https://github.com/nodejs/node/pull/14239

A api to things like server push is a cool feature

FWIW, it looks like http2 landed in node core a few days ago so people can start experimenting with it.

Please reopen.

Node.js v8.4.0 starts supporting http2.
@jonathanong please reopen this issue and put http2 on the agenda. :nerd_face:

Reopen? @jonathanong

Is this literally as easy as swapping out http for http2? If so I'll fork/maintain until they catch up.

Is there any benefit to using http2 other than push?

http2 supports better parallel fetching of assets and a whole host of other optimisations besides push...

http2 is what makes HTTPS faster than HTTP.

Is this supported?


Add redux.dev course callouts

Hi Mark! This PR:

Updates the docs website
Adds three SVG images for redux.dev callouts (narrow, mid, and wide sizes)
Adds the mid size callout to the homepage

I wasn’t sure how to add the callouts to the internal docs pages (I’m not super familiar with docusaurus), is that something you could help me with?
Here is where I was thinking we could place them (either mid at the bottom of the main column or narrow in the right sidebar). Also open to your suggestions here!

We could also potentially add the wide one above the nav (only on the homepage) if we wanted it higher up on the page. (Though not great for mobile and we’d probably want to hide or swap out there)

Let me know what you think works and if there’s anything else I can provide. Thanks!

Thanks! Since the PR is from your master branch, I'll just merge this and then fiddle with it a bit - probably going to add the "wide" version as a sitewide banner for the next few weeks. I'll also add it to the RTK and React-Redux sites as well.

Done! Updated all 3 docs sites ( https://redux.js.org, https://redux-toolkit.js.org , https://react-redux.js.org ) with the same top banner and front-page image.
Thanks!


Missing a semicolon in the statement

Missing a semicolon in the following example
The last say statement missed a semicolon in the https://docs.raku.org/language/grammars#Dynamic_variables_in_grammars section:
say GrammarAdvice.subparse("use rules for significant whitespace by default");
# OUTPUT: «use rules for significant whitespace by default»

say GrammarAdvice.subparse("use tokens for insignificant whitespace by default");
# OUTPUT: «use tokens for insignificant whitespace by default»

say GrammarAdvice.subparse("use regexes for insignificant whitespace by default");
# OUTPUT: «use regexes for insignificant whitespace by default»

say GrammarAdvice.subparse("use regexes for significant whitespace by default")
# OUTPUT: #<failed match>

It's not really needed in the last statement in a program, but it's good practice anyway. Thanks.


[typings] Replace deprecated typing with py built-in types

This PR:

Replace deprecated typing with python built-in types

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.22%. Comparing base (ff8cce4) to head (8dd1739).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   98.23%   98.22%   -0.02%
==========================================
  Files          66       66
  Lines        2039     2027      -12
==========================================
- Hits         2003     1991      -12
  Misses         36       36

Flag
Coverage Δ

unittests
98.22% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Exclude generated sources from checks

Reviewer checklist

[ ] Read the contributing guide
[ ] PR should be motivated, i.e. what does it fix, why, and if relevant, how
[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage: 100.0%. Remained the same when pulling 7ac6fae5795ec68afe5eb3adf0ac1230f2091dd1 on convention into 47131d59ab9cdda6a06c145e798ebbdd1a3c5612 on main.


heather-and-tara- desktop-navigation

Resolved merge conflict and add a navigation from login to the main page

Sorry, those were lib

theres tons of files that you guys included in the commits that shouldn't be in here:
.anima folder nodemodules folder package.json package-lock.json
this is probably because you npm installed modules when you weren't in the frontend directory

sorry those were libraries I had installed trying to make the figma plugin work but I ended up doing it from scratch, forgot to remove it

The tests were passed locally but it's not working here ill figure it out later after talking with Matt


[FEAT] Interactive Blur Effect

Is it possible to extend the interactive function to include blur?

Would be good to have blur effect too!


Vue plugins with generic vue versions causing issues

Some Vue plugins are causing version mismatch issues with vue, vue-template-compiler, and vue-server-renderer
e.g. https://github.com/Inndy/vue-clipboard2/blob/master/package.json#L28
Is there a recommended way to guarantee the Nuxt version of these packages without having to manually specify the vue versions in package.json?

you may add vue into dependencies manually.
dependencies: {
  "vue": "~2.4.4"
}

Nuxt.js will bump vue to 2.5.x, this issue will be resolved.

Nuxt.js will bump vue to 2.5.x, this issue will be resolved.

Do we know when will this happen?

@manico
We are working on it, about the details, pls refer: https://github.com/nuxt/nuxt.js/issues/2142


Multiple suggestions

Hi there,
I have some suggestions that I believe will improve the app.
Maybe you have the ability and free time to implement them.
1. Chose the default view (landing view)
As  you set the reminder for future days, it seems useless to make the "current day page" as the landing page.
It would be great if, in the settings, we can pick on which view we want to land when starting the app.
I would definitely pick de first view (full month calendar).
2. Long Press
As I said, the full month view is the best view for me. It can be even better with 2 things.
To create an event from this view, we need to click on the date which open the current day tab, and then, click on Add Note...
It would be great if a long press on the date automatically trigg the Add Note. It will remove 1 step.
If the reminder do not exist on the day, trigg de "Add note", otherwise, trigg "Edit note" action.

Hi, good suggestions, I'll try to add them someday.

Implemented in version 1.0.6

Hi mate. Long time no see !
I updated the app and this new feature works great.
Thank you very much 🤙


add getting started guide for BIRD

ref #10160
Signed-off-by: ArthurChiao<EMAIL_ADDRESS>

This change is

Coverage decreased (-0.02%) to 45.493% when pulling efa061acd41cd33e0d3a0e4f4d69642746145607 on ctripcloud:bird_guide into 43f7824bc3ebccf87a643ef65bc850310196f841 on cilium:master.

test-docs-please

hi @pchaigno , big thanks for your advises!
I have resolved them except two:

two pictures seems too large applying scale 70%
whether should i add sed commands to replace the placeholders in bird.conf

Commits 9cd69cf, 3e22ddc, 5ae1bb1, 45490bd do not contain "Signed-off-by".
Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/contributing/#developer-s-certificate-of-origin

emm, i'm not very familiar with Github suggestions, and i just clicked the Commit button in the page, how should i fix this problem now? @pchaigno thanks!

emm, i'm not very familiar with Github suggestions, and i just clicked the Commit button in the page, how should i fix this problem now? @pchaigno thanks!

I think you can just squash all the new commits and discard their commit messages. You can do that with git rebase -i master, then choose fixup (or just f) for all commits except the first one.

Just rebased on master and force pushed. @pchaigno

Great! I answered your questions in the inline comments above :point_up:

All comments resolved, thanks @pchaigno

There's a couple comments which we haven't resolved (see above :point_up: )

Above comments resolved, big thanks for your patience @qmonnet @pchaigno

I just realized you may not be seeing my last comments because GitHub hides them (not sure why :confused:). You need to click on "Load more..."

Indeed i missed the hidden ones just now @pchaigno

test-docs-please

@ArthurChiao can this be backported to 1.7 as well, meaning, is it confirmed to work with 1.7 so it could go into the stable doc? Thx

@borkmann yes, i have tested Cilium 1.7.0 + bird 2.0.6 (but just tested one node), the scheme works ok.
Actually in my understanding, Cilium and bird works independently, they collaborate through kernel routing tables, so as long as they do not break their kernel conventions, each of them could be upgraded/downgraded independently - or even, be replaced by similar alternatives (that's how we rolling-replaced kube-router with bird).

@joestringer that's nice way for automation, but at present there are many challenges that may threaten the availability (both bird itself and the whole cluster) instead of strengthen it, such as:

bird daemon on each node has different configurations - with respect to your BGP peering scheme, these configurations may include router ID, PodCIDR, peer ASN, peer IP, peer password, etc. I assume Daemonset is good at handling services with much the same configuration (e.g. via configmap)?
if Daemonset encountered some problems (e.g. problematic yaml), all bird daemons may exit and could not be re-launched, in this case, all announced routes will be withdrawn, then not only new Pods could not be deployed, but also all running Pods will be disconnected - the whole cluster suffers.

For these reason, we prefer standalone deployment of bird currently. However, i will consider your suggested way, thanks!


Update UI of the diagram

The goal of this issue is to modernize the UI of the diagram with some changes to the syntax of the diagram.
Some design ideas are

reduce the size of the scene and condition to allow more node to fit in the screen
remove delay from the scene into the condition
show condition configuration e.g. 15 < temp < 30 without the need to click on the device icon in the condition
Redesign the "Add Scene", "Add Condition" and "Add Begin" button

Done and merged in a17c974cada9592cdc7d60bba95a1e3c88c235af


Tron wallet shows a strange old date

Tron wallet shows a strange old date (Dec 31 1969) in the history of the transaction on iOS. See attached screenshots for more info including app version. Also, I get notifications about some deposits in but they do not show up in the history while I see them in tronscan.org

If having any issues with your trust and wallet you can write to trust wallet support to get your issues fixed
<EMAIL_ADDRESS>

Could you please share your tx hash?

@hewigovens  I sent you the info in private text, check your telegram.

This was a backend issue, resolved (btw, Jan 1, 1970 is the start of the Unix epoch).


Introduce an infix syntax for div and mod

Following a discussion in another issue, we want to be able to write in AskScript expressions like:
7 = ((7 div 3) * 3) + (7 mod 3)

where div and mod are already existing resources for integer division and modulo respectively.
We want to support it just for div and mod and not any other identifier.
Dear new contributor,
If you have any questions on how to start, please write a comment with a tag: @czerwinskilukasz1 or @mhagmajer, or join our Discord Community and let us know there. We will be very happy to help you start! :)
Hint for now: This task requires changes in our parser grammar (askscript.grammar.pegjs file), which uses PEG.js syntax .
Cheers,
Łukasz (@czerwinskilukasz1)
AskQL Core Developer

Please note that https://github.com/xFAANG/askql/issues/250 and https://github.com/xFAANG/askql/issues/412 need to be implemented first.

@czerwinskilukasz1 do you think this would be a good/appropriate second issue for me to take on?


feat(#715): Use EO Bytes Objects For Values

In this PR I changed direct usage of bytes to bytes object usage (from EO lang).
In other words, was:
<o base="org.eolang.jeo.int" name="access" data="bytes">00 00 00 00 00 00 00 03</o>

Become:
<o base="org.eolang.jeo.int" name="access">
    <o base="bytes" data="bytes">00 00 00 00 00 00 00 04</o>
</o>

Closes: #715.
History:

feat(#715): rename DirectivesData -> DirectivesValue
feat(#715): add one more unit test with expectations
feat(#715): add DirectivesBytes
feat(#715): add XmlValue
feat(#715): parse XmlClassProperties correctly
feat(#715): parse class interfaces from Xmir
feat(#715): fix XmlAttributeTest test
feat(#715): parse method exceptions correctly
feat(#715): fix XmlAnnotation implementation
feat(#715): fix DirectivesAnnotationPropertyTest
feat(#715): fix BytecodeMethodTest
feat(#715): fix a bit more unit tests
feat(#715): fix a bit more unit tests
feat(#715): fix a bit more unit tests
feat(#715): fix a bit more unit tests
feat(#715): remove 'eo-to-bytecode' integration test
feat(#715): fix all the code offences

PR-Codex overview
This PR focuses on refactoring the DirectivesData class to DirectivesValue, improving the handling of XML representations, and enhancing the overall structure of directive-related classes in the org.eolang.jeo.representation.directives and org.eolang.jeo.representation.xmir packages.
Detailed summary

Renamed DirectivesData to DirectivesValue.
Updated constructors and methods to use DirectivesValue.
Introduced DirectivesBytes for handling byte directives.
Enhanced XML processing with XmlValue and XmlBytes classes.
Refactored various classes to improve readability and maintainability.
Adjusted tests to reflect changes in directive handling and XML structure.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@rultor merge

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

@volodya-lombrozo Great work on your contribution! 🎉 You've earned +4 points, with adjustments for code volume and review. While there's room for improvement in code size and comments, we appreciate your effort. Your balance is now +97. Keep the contributions coming and check out our tips on balancing speed and quality. Looking forward to your next submission!


report event data not displaying

Describe the bug
on latest yap version 3.9.4 not all of the caller event data is displaying
What version are you running?
3.9.4

Did this happen on prior versions to the one you are running?
it def worked on 3.9.0

Is it new records only or all records?

new and old records, so all

this worked in 3.9.3 too just confirmed

these are calls I just made
3.9.3

and 3.9.4

Two different versions pointed to the same database?
From: pjaudiomv<EMAIL_ADDRESS><EMAIL_ADDRESS>Reply: bmlt-enabled/yap
<EMAIL_ADDRESS><EMAIL_ADDRESS>Date: September 16, 2020 at 8:26:40 PM
To: bmlt-enabled/yap<EMAIL_ADDRESS><EMAIL_ADDRESS>Cc: Danny Gershman<EMAIL_ADDRESS><EMAIL_ADDRESS>Assign<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject:  Re: [bmlt-enabled/yap] report event data not displaying (#478)
these are calls I just made
3.9.3
[image: Screen Shot 2020-09-16 at 8 25 08 PM]
https://user-images.githubusercontent.com/34245618/93405385-de630d80-f85a-11ea-814b-8ffcf8550351.png
and 3.9.4
[image: Screen Shot 2020-09-16 at 8 24 34 PM]
https://user-images.githubusercontent.com/34245618/93405397-e458ee80-f85a-11ea-903d-0f613d9d78c4.png
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/bmlt-enabled/yap/issues/478#issuecomment-693735738, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOD3O7CUZ2OOSQ5VVIB5S3SGFJUBANCNFSM4RPSXVCA
.

yes, thats correct. a Db that had been upgraded to 3.9.4. this is happening on sezf server as well

Fix will be in 3.9.5, you can test here: https://archives.bmlt.app/yap/yap-1811-3aed41c250bacd748b3e21359d1d2e2beadff7c0.zip

I just tested and all the event data is showing up now, but the reports are a lot slower. like slower than before before

Ok I will take a look.
On Thu, Sep 17, 2020 at 8:21 PM pjaudiomv<EMAIL_ADDRESS>wrote:

I just tested and all the event data is showing up now, but the reports
are a lot slower. like slower than before before
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/bmlt-enabled/yap/issues/478#issuecomment-694571368,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOD3O5QE7HVCFCG4HL7GIDSGKRYZANCNFSM4RPSXVCA
.

I have #480 to address some performance improvements.

You can test with https://archives.bmlt.app/yap/yap-1814-9297844b763cf4a840ac41a4e22022a597ec5bcd.zip

this bug is fixed in 3.9.5


[Fix #7574] Fix corner case in Style/GuardClause

This fixes #7574.

These differ from AST as follows.
% ruby -e 'p nil.class'
NilClass
% ruby-parse -e 'nil'
(nil)

% ruby -e 'p ().class'
NilClass
% ruby-parse -e '()'
(begin)

() is tricky, but I don't think it is handled by this cop.

Thanks!


feat: API to get all import jobs

Related Issues
SITES-23126
Build out the API to get all the import jobs data for representation in PowerBI

getAllImportJobs - To retrieve all the import jobs started between a specified startDate and endDate

Sample response:

[{
		"id": "50ad5e05-bc98-4810-a264-e1043bf7847b",
		"baseURL": "https://www.testing.ca",
		"options": {
			"enableJavascript": false,
			"scrollToBottom": true
		},
		"startTime": "2024-08-21T16:38:05.446Z",
		"status": "RUNNING",
		"urlCount": 1,
		"importQueueId": "spacecat-import-queue-1-dev",
		"initiatedBy": {
			"apiKeyName": "Dev Key",
			"userAgent": "insomnia/2023.5.8-adobe",
			"imsUserId": "Ottawa-team",
			"imsOrgId": "Adobe"
		}
}]

I see it working on stage! 👏

:tada: This issue has been resolved in version 1.62.0 :tada:
The release is available on:

v1.62.0
GitHub release

Your semantic-release bot :package::rocket:


fix: when decoding addresses restrict to 20 bytes

ref: https://discordapp.com/channels/905194001349627914/928377875827154984/1194272891957694614
When indexing the BSC chain, it's been reported that the EVM connector crashes when indexing this transaction. This is because the padding scheme used in the transaction is not using zero-bytes to pad out the value. When we parse the entire 32 bytes from the chunk into an integer, the padding non-zero bytes are contributing to the integer value, causing the parsed address value to overflow what can be actually been shown in 20 bytes. This issue is causing golang to panic and the EVM connector to crash.
The proposed fix is to decode addresses only on the right-most 20 bytes, and ignore the front 12 bytes from the chunk.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (78ea6df) 99.90% compared to head (e47e379) 99.90%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #56   +/-   ##
=======================================
  Coverage   99.90%   99.90%
=======================================
  Files          38       38
  Lines        3317     3323    +6
=======================================
+ Hits         3314     3320    +6
  Misses          2        2
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Approach looks good to me

For sake of consistency, I've checked the behaviour when someone tries to force an encode operation with an address value in bytes that would exceed the 20 bytes buffer and an error is thrown if the value doesn't fit into a uint160 type as expected.

Is there a chance to build a docker image from this branch?

I think we can get this merged today which will automatically trigger a snapshot image build

@wpater - this docker tag should have the fix now:
https://github.com/hyperledger/firefly-signer/pkgs/container/firefly-signer/168104554?tag=v1.1.11-20240117-47

It's up and running for over 30mins - looks fine from my perspective


Admin Theme - RTL : Lables will be positioned right on Edit Column Property screen

Is this issue specific to the new admin theme, or does it also appear on the old one? If so, this should be labeled as an RTL issue of the Layouts module instead.


Huddle Slack's feature

Hello everyone! It's my first time reporting something here, so I hope to do it well!
Recently, I have added the Slack service to my Ferdi account, and I realized that the new function of Slack "Huddle" is not working correctly. When you are in a huddle and someone shares its screen, you can't open the screen in full screen and you can't see the full screen, it keeps a small square in the left corner of the bottom of Ferdi's screen. Maybe in future updates, you can fix it, because now, when it happens, I have to open the Slack app and left my Ferdi app and it's boring to be running two applications at the same time.
Thank you so much!!!

hi @pscamino - thanks for trying out Ferdi. Unfortunately, there's already a ticket logged for this: #1709 - thus, I'm closing this one. Please follow the other ticket for updates.


Inking and Typing Personalization

Would be nice if we could clear this box from the app.

Does the checkbox option in Privatezilla -> under Privacy -> "Prevent using handwriting data" not turn it off?

I'm afraid not. Also if I run analyse, it says it's configured, regardless of the position of this switch.


[Feature Request] When resizing, be able to enter percentages

Title says it all really.

The feature was implemented in version 2.32.


Add default scope support

Hello!
I added support for default scope to injector.
This removes a lot of boiler plate, in projects that use other scopes than NoScope by default. For example, a lot of programs, use DI to store services, which are singletons. If this is merged, it will allow, to specify default scope, when creating Injector instance.
Thanks for all your work!
P.S. About version number: I assumed injector uses semantic versioning, this is why I set the new version to 0.14.0. I can correct it if this is necessary.

Nice!
What should happen when you make a child injector from a parent with a default scope?
Currently it looks like it's ignored but this might not be so intuitive.  If the scoped isn't passed in when making the child, then maybe the parent's should be used. Although with scope=None you can't tell if they're not setting the param or set it to None and really want the default equivalent to NoScope so you'll have to have a special flag on create_child_injector like dont_use_parent_default_scope.

Although with scope=None you can't tell if they're not setting the param or set it to None and really want the default equivalent to NoScope so you'll have to have a special flag on create_child_injector like dont_use_parent_default_scope.

I don't think this is necessary. The semantics can simply be: "if scope=None, use the parents". If you want NoScope semantics, pass NoScope.

Without getting into the details of this patch and ignoring the parent/child injector consequences for now; I'd just like to say I'm not a massive fan of this. I'm not sure if the added mental overhead (having to remember what default scope Injector is configured with) is worth it. I can easily imagine a position that makes it worth it, mind you, mine just doesn't necessarily align with it.
Additionally it makes it difficult to reuse Injector configuration between Injector instances using different default scopes (say you have a binding between Interface and Implementation with implicit singleton scope thanks to one Injector default scope being singleton - you can't just use it with another Injector that uses different default scope).

@jstasiak I don't think it would be any more confusing than auto_bind, but it's a good point about child injectors... having them with different binding scopes would be confusing.

Hello!
I've updated this pull request with some changes:
I added parent injector support. Now, if you do not explicitly provide scope when creating child injector, parent's scope will be used.
About your comments:
I understand that this is not so clear and if you want to reject this comment it is ok. Personally I don't use parent/child functionality, and this is probably why I missed this in the first place.
I also understand @jstasiak comment about reusing bindings/configurations in injectors with different default scopes. This might cause problems/bugs.
Nevertheless, I decided to update my pull request because it better to talk about something real, because you can read it and see how it looks. For me it looks quite good, maybe because, as I mentioned, I don't use parent injectors and my injector configuration and modules are quite simple.
The most important part for me, is that it won't affect existing code.
@alecthomas This is now three commits, I think you have an option to squash them to one when you are going to merge it, or if you prefer I can do it on new branch. I'm not sure, I can update this PR, I probably will have to create new PR.
Thanks!

I do think this is super useful. Sorry I didn't mean to start a whole covfefe over the parent/child thing. It might be interesting to think about how Guice would solve it, although I don't think Guice would like this change since Guice seems to encourage more thought into design as I saw mentioned in forums.  I think this change makes sense in Python where you typically have smaller ad-hoc projects.


WID-669 Create Input component

Complete WID-669
Reused some colors so I did the change on top of that.
Merge #471 first.
Also worth leaving yup and react-hook form in since we can use that to test later components and will need it in prod version.


Magus spellstrike doesn't work

Not sure if it's 2.0 or TTT, but when I have spellstrike selected on my magus (sword saint), clicking on an adjacent enemy doesn't do anything. Spell combat also just casts the spell using a standard action rather than also giving you an attack.

Spell combat casts the spell but if you attack it will become a spell
combat action. Spell strike works with any standard action or faster touch
spell.
On Tue, Oct 4, 2022, 10:03 AM Shodan14 @.***> wrote:

Not sure if it's 2.0 or TTT, but when I have spellstrike selected on my
magus (sword saint), clicking on an adjacent enemy doesn't do anything.
Spell combat also just casts the spell using a standard action rather than
also giving you an attack.
—
Reply to this email directly, view it on GitHub
https://github.com/Vek17/TabletopTweaks-Base/issues/499, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWSQPENY6ZIIRDMZ2IGP7TWBRBNFANCNFSM6AAAAAAQ4VKKII
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks, I know how it works and it used to work like that. Now, switching on spell combat just casts the spell normally whether I attack or not and spell strike just does nothing when I select it and click on an adjacent enemy.

No idea, I cannot reproduce this and TTT does not modify how these things
work in the first place. This works correctly as far as I can verify.
On Tue, Oct 11, 2022 at 11:26 AM Shodan14 @.***> wrote:

Thanks, I know how it works and it used to work like that. Now, switching
on spell combat just casts the spell normally whether I attack or not and
spell strike just does nothing when I select it and click on an adjacent
enemy.
—
Reply to this email directly, view it on GitHub
https://github.com/Vek17/TabletopTweaks-Base/issues/499#issuecomment-1274961784,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAWSQPCHTATOZPGF6DBCRM3WCWIJ7ANCNFSM6AAAAAAQ4VKKII
.
You are receiving this because you commented.Message ID:
@.***>


Chef Orange color is WRONG!

https://github.com/opscode/oc-web-core/blob/7a67c6ba5f6aec6b21522147012de37e1129f64b/lib/assets/stylesheets/oc/colors.scss#L5
Should be #F18A20.

Fixed in the new stuff: https://github.com/chef/chef-web-core/blob/02cfa3b6595699d283f21fa70b1f68a1f02bba66/lib/assets/stylesheets/chef/_settings.scss#L1


Issue downloading data

I have trouble downloading dataset.
How do I solve this issue?

Hi, seems like some of the urls have been removed. I will look into it shortly. Thanks!

Thank you taking care of the issue.  I have now encountered another issue,


How to report rocm.github.io typos?

Hi,
How can we report typos on the rocm.github.io website since the repo is hidden?
Thanks.

Report them here https://github.com/ROCm/ROCm.github.io
On Jul 4, 2017, at 9:18 PM, Ramin Ranjbar <notifications<EMAIL_ADDRESS>wrote:
Hi,
How can we report typos on the rocm.github.iohttp://rocm.github.io website since the repo is hidden?
Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/RadeonOpenCompute/ROCm/issues/149, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AD8DuWaPAzdnYfYeSXlx3QI4usSnCgWsks5sKvJ7gaJpZM4ONymO.

Thanks


[Suggestion] Support IP2Location LITE database in Atlas

@alisinabh
Altas is an interesting IP geolocation project.
I would like to introduce you to our free IP2Location LITE databases, which you can use as an alternate data source for IP geolocation lookup in Atlas. We also offer free IP2Proxy LITE databases which can provide open proxy detection.
For implementation, you can find the IP2Location Rust crate on https://crates.io/crates/ip2location .
We are glad to help you if you have further questions.

Hey, Thanks for the suggestion.
Adding more providers is on roadmap for this project. I will take a look and hopefully implement this (or somebody else can make a PR if there is interest) soon-ish.


Swift 3 support?

Does this library support Swift 3?

I do not know for sure but since the dependency is on RxSwift4 my guess is no


Creating A Location-tracking App Using Firebase and Google Maps in Android

Proposed title of article
Creating a location-tracking app using Firebase and Google Maps in android
Introduction paragraph(s):
This tutorial aims to show you how to create an android application that tracks the current location of another user. We shall create two applications, one that writes to firebase and another that reads from firebase. This way, you can be able to track the location of another user who is miles away from you.
You shall have a good understanding of how Google Maps works and how to also use Firebase to store and retrieve data from the realtime database
Key takeaways:

Understand Google Maps
Understand how to add Google Maps API to an application
Understand how firebase realtime database works
Understand how to store and retrieve data in Android

References:
N/A

👋  @carolinemusyoka
Just noticed you have two topic suggestions open - please pick one to continue with.
We are asking students to have one topic and PR open at at ime.

Cool. I will pick this one. Let me close the other topic suggestion issue. Thank you

very cool topic - approved 👍  @carolinemusyoka


Annotation tool

Simple OpenCV-based tool to collect manual annotations. Usage:
import cv2
from airo_camera_toolkit.annotation import get_manual_annotations, Annotation

annotation_spec = {
   "keypoint": Annotation.Keypoint,
   "line_segment": Annotation.LineSegment,
   "line": Annotation.Line,
   "bounding_box": Annotation.BoundingBox,
   "polygon": Annotation.Polygon,
}

image = cv2.imread(image_path)
annotations = get_manual_annotations(image, annotation_spec)

Example:

Output:
{   'bounding_box': ((715, 423), (1408, 972)),
    'keypoint': (967, 261),
    'line': ((1736, 975), (-174, -449)),
    'line_segment': ((1102, 124), (1387, 325)),
    'polygon': [   (1037, 472),
                   (1183, 593),
                   (1284, 687),
                   (1341, 771),
                   (1336, 852),
                   (1333, 905),
                   (1313, 906),
                   (1241, 913),
                   (1227, 901),
                   (1235, 869),
                   (929, 903),
                   (861, 901),
                   (810, 851),
                   (753, 810),
                   (812, 730)]}

Related issue #78

maybe also update readme of airo-camera-toolkit to include this functionality? should be easy to find.


fix warnings

fix: spacing
fix: fixed warnings

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Docker to share network

Trying the docker image with docker run --net="host" because I need the code to proxy through TOR which is set up on local host (and also the additional network performance) but running the image with the above option doesn't seem to work at all, the HTTP API doesn't work, what's wrong with this?

bro,do you solve this problem?i use "docker run --network host scrapinghub/splash --disable-private-mode" just now ,but don`t work

Hello,
I ended up running TOR in another docker container and configuring splash to use it through a proxy profiles file:
[proxy]

; proxy settings for docker and splash service
; required, must point to TOR proxy, tor must accept "lan" requests
host=<IP_ADDRESS>   ; your internal IP
port=9050

; optional, default is no auth
;username=username
;password=password

; optional, default is HTTP. Allowed values are HTTP and SOCKS5
type=SOCKS5

[rules]
; optional, default ".*"
whitelist=
    .*\.onion\.*

; optional, default is no blacklist

Finally, don't forget to pass the flag to map to the folder where you have this file: For example -v /home/splash/proxy-profiles:/etc/splash/proxy-profiles

thanks , bro


Add slote to textbox

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[X] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[ X] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[ ] All tests are passing

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Thanks for the PR! Just a few comments:

Please revert the dist files changes
Why did you remove HTMLDivElement types? Is it not working otherwise?
Some code in RoomsList.vue file was removed (probably a merge issue), please update the PR with the latest master branch

Closing this PR has it doesn't respect guidelines


instagram call  checkpoint for this action

i can't log in , please fix it quickly i need ign dm

Same here

yes same here

today is still no working

Que tengo que hacer para poder entrar si tengo este problema?

i don't know the developer has to fix

Thanks for Fix ;-) @ifedapoolarewaju


Optional showing of labels on project boards

Feature Description
When having a project board that has issues with a lot of labels it eats up a lot screenspace. So to provide more screen realestate to issues, make the showing of labels optional.
I see this as a configuration on a per project basis, or even something like the "show whitespace" setting in PRs that a user can toggle it themselves.
Screenshots

In the CSS rules for .board-column changing either of these rules would IMO already be a huge improvement:
height: calc(100vh - 40px);  /* was -450px */
min-height: 100vh;           /* was  60vh */

One of these changes is enough to allow for much more vertical space.


Add support for disabling shadow casting per material

Related to #82
Related to #161
Adds a flag for disabling the casting of shadows from certain materials. Works by disabling hits for materials only when the direct light sampling is used which primarily contributes lighting to diffuse surfaces. How can we determine a specular ray from a diffuse ray? From the sampling? From the probability? From how far off from a perfectly specular reflection it is?
ptMaterial.materials.setCastShadow( index, value );

TODO

[x] Update Docs
[x] Add demo flag
[ ] Get this working without MIS

determine whether a ray is "specular" without MIS
add surface skipping if not MIS ray
check specular ray probability and use to randomly pass through the surface or not (or use a fixed threshold?)
OR check how far off of the ideal specular direction the ray is.

Images of the orb in an entirely enclosed box lit by an environment map:

cc @setpixel

MIS

No MIS


Update README.md to include acknowledgement

Add acknowledgement to original source code in README.md

Codecov Report

Merging #16 (18a968f) into master (fa4997a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #16   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Submit benchmarks written in Rust to the codebase

This is a followup for https://github.com/near/wasmtime/issues/90
Ideally, we would have all Rust benchmarks submitted to wasmtime repository and compiled to WASM as a part of the build process to avoid storing massive WASM binary blobs in Git. This will also make it much easier to experiment with different Rust compilation flags when we try to optimize the resulting zkAsm.
A rough flow will be:

We submit a benchmark like https://gist.github.com/akashin/a02b4b72883674072e09b226904f2b5e to wasmtime
We introduce a build.rs script that builds it to wasm32 target and stores it in generated directory
We pick up the generated WASM file in the test_zkasm.rs and generate zkAsm out of it
We run that zkAsm with zkasm_runner.rs

Some relevant resource to learn about Build scripts:

https://doc.rust-lang.org/cargo/reference/build-scripts.html
https://web.mit.edu/rust-lang_v1.25/arch/amd64_ubuntu1404/share/doc/rust/html/cargo/reference/build-scripts.html
https://www.reddit.com/r/rust/comments/14cvubt/statically_embed_the_output_of_a_wasm_crate_in/
https://kazlauskas.me/entries/writing-proper-buildrs-scripts


[BUG] Validation rules are not evaluated for default/initial value

Describe the bug
The validation-rules are not evaluated for the default/initial value. The makes it possible that invalid default values can be submitted in the connection dialog.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: macOS Catalina
Tableau Version: 2021.1.1

About you:
Name: Ali Smesseim
Company: Databricks

internal tracking id : 1268965

The connection dialog is designed to only validate a fields after the user inputs to the field.
However, I see the problem that invalid value could be passed through without validation.  We have decided to address the issue by two means,

In Connector packager to make sure default value is valid against the validation rule;
When the user click "Sign In" button, we will validate the fields user has bot changed.

I have created the above items in our backlog.

If you are using default value as placeholder to provide a hint, we are going to support placeholder in connection fields.

@sxlin currently the Databricks connector (for Tableau 2021.3) uses an invalid default value as placeholder. Does this change need to be reverted?

@alismess-db Yes, it should be reverted.  The default value should be a valid value.

@alismess-db I have created a feature to support placeholder for fields in our backlog.  I am closing this issue.  Please reopen it or create another issue if you have further questions.


Occurs-check broken

Trealla Prolog (c) Infradig 2020-2023, v2.27.44
?- set_prolog_flag(occurs_check, true).
   true.
?- -X=X.
   X = - -X, unexpected.
   false. % expected, but not found

Yet unify_with_occurs_check/2 works. Will look into it.
On Tue, Sep 26, 2023 at 7:09 PM UWN @.***> wrote:

Trealla Prolog (c) Infradig 2020-2023, v2.27.44
?- set_prolog_flag(occurs_check, true).
true.
?- -X=X.
X = - -X, unexpected.
false. % expected, but not found
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/348, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEWX6PRWQIPYV46XLHLX4KLTRANCNFSM6AAAAAA5HLZA64
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

It even 'worked' within the same query:
Trealla Prolog (c) Infradig 2020-2023, v2.27.44-7-gb7236
?- set_prolog_flag(occurs_check, true), -X=X.
   false.
?- -X=X.
   X = - -X, unexpected.

(Closing now in v2.27.45)


Can you make a 2d version many would appreciate it

there arent any assets or information of grappling in godot 4 2d

Yeah, that should be pretty easy to do given that the tech is the same. I'll try to find some time this week to make it.


Impressum: Javaland

Please take over the current Impressum from official Javaland site: https://www.javaland.eu/impressum-kontakt/impressum/.
I suspect there will be further requests to take over the complete Javaland footer (with contact form etc.). So we should probably prepare for further alignments or even direct take over of the complete footer with links to the main site pages?

with #4 fixed we have the means to copy their footer. But the space might be better used to add a finger-friendly menu (for smartphone users)

imprint copied; let's create a new ticket for the footer if it comes up!


Decrease size of Text struct

This implements the changes outlined in #18. However, I'm not really sure merging this in is a good idea because of the amount of code required to implement Serialize and Deserialize manually. I honestly don't think that its worth the effort, especially seeing that the TextContent enum is incomplete (see #19), and changes to that affects the Serialize/Deserialize impls.
closes #18
Test plan
cargo test

In retrospect my suggestions probably weren't so great. Sorry about that.

No worries, it was a good exercise for me.


Kit is missing pieces

This starterkit is missing a lot of pieces:

Unlike the other starterkits that require services and provision them automatically,  the Hypersecure service must be added manually (provisioning takes about 5 minutes and it requires a term agreement from the user, password security requirements, etc.).  If this service is not added, service enablement does not produce the proper instrumentation code - in this case we are missing the MongoDB drivers.

I suspect because of this same problem, this kit is missing a localdev-config.json

We need to add instructions to the README about how to provision this service.  Now that the service just moved to Beta from experimental, users can select the database type in the "plans" section.  This kit only works for MONGO at this time, so we need to tell users to select these plans.

This definitely seems like the most complicated of the starter kit -> code pattern conversions, so I've been saving it for last :) Thanks for the specific pointers on what needs to be done!


Docs: Missing content for createEntityAdapter

The documentation seems to be missing for createEntityAdapter in the Core Adapters page. The other sections of this page features a description of the adapters, how to use them and the source code:

If I can be of any help in investigating these, please tell me!

Oh yeah. For this one, the source code is long and not very pretty. I just put a link to the source code instead. Maybe I should make it look less broken. Maybe change it to Please see [url] for source code.
What do you think?

Oh and this is the bottom of those docs. They're there, just above where you're looking. It's just the source code section that looks broken.

Good idea! It might will also look consistent with other external references in other pages:


Show notification time in mobile app

:bulb: Idea

Mobile app shows notification time only if it's from today. But if it's older than that it only shows "yesterday" or just the date, but not the time. So for example if I got a notification before midnight when I'm at sleep and in the morning when I open my phone, the app just says the notification is from yesterday and I can't tell what time it was.
:computer: Target components

Mobile app (iOS, I haven't tested Android app)

The funny thing is that this was meant to be a feature, not a bug, but I agree...


Compiler doesn't catch builtin overwrite

What version of Go are you using (go version)?
1.12.5
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
windows_amd64
What did you do?
https://play.golang.org/p/q64y6jcU9n4
I added a function called delete, replicating the signature of the builtin of the same name.
What did you expect to see?
The compiler should throw an error akin to delete is a builtin.
What did you see instead?
The code compiles cleanly, leading to unexpected behavior during run-time.

This is how pre-declared identifiers work; they can be replaced in a package or function block by another declaration. See https://golang.org/ref/spec#Predeclared_identifiers.

Thanks for the spec link!
Interesting. One would assume this is considered an anti-pattern, a source of otherwise easily avoidable software faults.

This approach permits us to add new built-in functions without breaking existing code.


Disallow local hooks if BUILDKITE_NO_LOCAL_HOOKS is set.

Useful for preventing hostile hooks in the repository from escaping whatever
chroot/container/etc mechanism may be in use around the build commands.

I'm all for this, thoughts @keithpitt?
Eventually I'd love to roll together some security settings in to a --hardened mode.

This is interesting! Couldn't a hostile person just change the build script contents and pretty much circumvent the whole thing anyway?
i.e I want to get a rm -rf into the build process. You've disabled hooks, so I can't insert one there. But I can just add it to script/ci and do the same thing. If you've got access to the code, you can pretty much do what evs...
Unless this is protect against another sort of vulnerability that I'm not seeing? I may need more ☕

The pipeline configuration runs the build scripts/etc inside a chroot/container-y thing, so whatever they do it can't have any influence outside of the build directory.

The thing I like about this is that local hooks are a way to override global hooks, which if you are trying to lock things down is a concern. You can run your command hook in a chroot/container/VM, but unless you run your checkout in there then there is a spot for rogue hooks to execute outside that protection.

@keithpitt and I discussed this and are 👍
Will port to master too. Thanks @solemnwarning


Fix missed doer

Fix #29879

Overall LGTM, maybe it's better to leave it open for a few days before merge.


Implement clearing the user

false

https://github.com/project-chip/connectedhomeip/blob/f0f5de0d79ae1c51d7fddbf70900ebac0acd899a/src/app/clusters/door-lock-server/door-lock-server.cpp#L379-L384

This issue was generated by todo-issue based on a TODO comment in f0f5de0d79ae1c51d7fddbf70900ebac0acd899a.

Should already be addressed in the SDK.


Design - Class builder and wrappers in awesome APIs

The awesome lua APIs are implemented as wrappers of structs which are built as lua tables dynamically using a class builder. However, RLua allows a native rust-side class system for userdata using the UserData trait. I wonder why way-cooler does not use it, as it would be more straight-forward and would maybe leverage RLua-side optimization. My guess is that it is simply because way-cooler copies AwesomeWM's internal system, but I would like to know other motivations behind this choice if there are some.

It's been a long strange trip to where we currently are with the object system in place in Way Cooler. Most of it was motivated by how rlua works, so you might want to read up on the limitations that I've mentioned in another comment here and to read the API docs yourself.
Way Cooler actually does use the UserData trait for its objects, We use the class/object builders and traits to make it easier to construct objects, exactly like how C Awesome currently does it.
In particular, look at the Objectable trait, which abstracts away a lot of boiler plate while also stipulating that the thing it's wrapping implements UserData. The reason you won't find it implemented everywhere is because that too has been abstracted out by this macro (search for uses of it to see how to use it).
The object system is heavily abstracted, perhaps too much so, in both Way Cooler and Awesome. It's a teeny bit easier to use here, but just as confusing when you dig into the details.

Thanks for your time.
However, sorry, my question was not asked properly, I was more wondering about the nesting of classes (with for example Tag wrapping an object, wrapping a TagState) and the relative roles of the two wrappers. In my understanding, the top-level wrappers implement a class, the Object class serves as a "boilerplate remover" and the lowermost structs are the real state. However, I do not understand the need for the two top-most wrapper, as the classes are native rust + rlua feature and the general code could be implemented as it is for now in a trait, but without the casting and the wrapping.

I'm not 100% sure I'm following, but if you're asking why are we using AnyUserData and then casting the type it's because that's the value we get from Lua: it can pass any user data and so we need to cast it to the correct type (or signal an error if it's not what we expect).
If I'm still not understanding, apologies. Perhaps some code examples of your proposed structure would help me understand.

Ok now the code follows the structure:
pub struct Tag<'lua>(Object<'lua>);

                   ↓

pub struct Object<'lua> {
    pub object: AnyUserData<'lua>
}

                   ↓

pub struct TagState {
    name: Option<String>,
    selected: bool,
    activated: bool
}

I think this could be expressed as
#[derive(Objectable)]
pub struct Tag {
    name: Option<String>,
    selected: bool,
    activated: bool
}

where Objectable provides the same functionalities as it provides now, simply redesigned. I could be wrong as I am fairly new to Rust. However, this would mean
fn set_name<'lua>(lua: &'lua Lua,
                  (obj, val): (AnyUserData<'lua>, String))
                  -> rlua::Result<Value<'lua>> {
    let mut tag = Tag::cast(obj.clone().into())?;
    tag.get_object_mut()?.name = Some(val.clone());
    signal::emit_object_signal(lua, obj.into(), "property::name".into(), ())?;
    Ok(Value::Nil)
}

would then become
fn set_name<'lua>(lua: &'lua Lua,
                  (tag, val): (Tag, String))
                  -> rlua::Result<Value<'lua>> {
    tag.name = Some(val.clone());
    signal::emit_object_signal(lua, &tag, "property::name".into(), ())?;
    Ok(Value::Nil)
}

which is a lot more straight-forward (or something along those lines). This would mean we could (I think) drop the Rc and the is statements, which Rust warns against and which is slower than compile-time safety.
Moreover, the allocate method could be relocated to the add_methods function, so the code would follow more closely RLua's intent.
So the question is, why this abstraction? I would like to understand the constrains it solves, as it seems to me as more verbose and not following the guidelines of the library.

Ahhh, after re-reading, I think my last paragraph is the most important one: set_user_value.
You write:

Concerning AnyUserData, RLua states 'This API should only be used when necessary. Implementing UserData already allows defining methods which check the type and acquire a borrow behind the scenes.', so this means part of the job of Object is already done, and RLua is designed not to use this.

Exercise (I once also tried something like this myself):
Implement the following with rlua:

You have two kinds of objects, let's say tag and client.
Both can be created from lua code via e.g. tag() and client().
A tag has a list of clients that can be set from lua: t.clients = { c1, c2 }
The list of clients can also be "getted": print(t.clients[1])

Now make this code work correctly:
local t = tag()
-- Check that tag really keeps a client and does not just copy it
do
  local c1 = client()
  t.clients = { c1 }
  assert(c1 == t.clients[1])
  local check_real_equality = {}
  check_real_equality[t.clients[1]] = 1
  assert(check_real_equality[c1] == 1)
end
-- Now check for "tag keeps clients alive"
do
  local c1, c2 = client(), client()
  t.clients = { c1, c2 }
end
collectgarbage("collect") -- Just because c1 and c2 are now out of scope
local clients = t.clients
print(clients[1], clients[2], clients[3], clients[1] == clients[2])

(Really, try this out, it helps a lot)
Since the clients are Lua objects and since this example is designed so that tags need to keep a reference to clients, you can only really do this with set_user_value on AnyUserData. One cannot cheat here and just create a new instance refering to the same client, because the == and the table index would catch this. Thus, assignment to clients needs to be implemented by e.g. having a tag save a table in its set_user_value. This table contains all the clients that are saved in the tag.

Ok, thanks for your reply. Concerning cloning the RLua documentation states "Implementing UserData already allows defining methods which check the type and acquire a borrow behind the scenes", so I thought cloning the values only meant cloning the rust-side values, all pointing to the same Lua object, thus allowing to change the values in clones but keeping the same references, thus exactly the same lua tables.
It is true though that I'd need to experiment with RLua before really contributing to way-cooler, so will-do.

Thanks for the in depth description @psychon, I'll be sure to point to these comments next time someone asks this.
Gonna go ahead and close this, assuming all your questions are answered @AdminXVII.

Yes, this covered it I think.
For the record, this is a minimal, stripped-down, working example of my idea:
POC.tar.gz

Don't worry, you sounded just fine. Just to clarify the intent of the code, this was to serve as a base point for future reference, so if someone has this same idea, they can see the problems you mentioned without too much effort, but maybe it wasn't clear enough. Thanks for your detailed remarks as they further illustrate your comment, and they will help as future reference.


Support new annotation for Service

What this PR does / why we need it:
Support to specify port ID to create Service of LoadBalancer type.
Use case:
Sometimes, we need to know the service IP address before a Service is actually created, so other applications who replies on the Service could be deployed with no dependenies.
In order to specify port ID to create Service, a new annotation for Service is added, e.g.:
annotations:
  loadbalancer.openstack.org/port-id: "849ee2ed-72a6-44a4-911e-6a8be46dbe8e"

Please be aware that after the Serivce is created, port ID can not be changed.
Which issue this PR fixes:
Special notes for your reviewer:
Release note:

Add a new annotation(`loadbalancer.openstack.org/port-id`) for Service of LoadBalancer type to specify a particular Neutron port for creating the Octavia load balancer.

/test cloud-provider-openstack-acceptance-test-csi-cinder

/test cloud-provider-openstack-acceptance-test-csi-cinder

/test cloud-provider-openstack-acceptance-test-csi-cinder

/test cloud-provider-openstack-acceptance-test-csi-cinder

service IP address before a Service is actually created
can you help to share why this is needed? just curious the use case.. thanks

so the port id which we got from a port need to be queried ? seems this expose too much detail on the cloud itself..

can you help to share why this is needed? just curious the use case.. thanks
so the port id which we got from a port need to be queried ? seems this expose too much detail on the cloud itself..

Think about creating k8s in k8s, before the api service is up and running, we need to create kube-apiserver certificate which needs the all the dnsNames such as <IP_ADDRESS>, kubernetes.default, private ip and potential floating ip, etc, which means we need to know the ip addresses information before the kube-apiserver Service is created.
That is a real use case from us in order to do k8s service management in the public cloud.
Make sense?

/approve
/lgtm


Add ability to use wildcards

Ability to use wildcares (e.g. * seed, * rune, *potion*, energy potion*) would be a very helpful feature for this plugin

Added in v1.1, waiting for approval now: https://github.com/runelite/plugin-hub/pull/3826


How do I remove DataStore from my amplify project?

This is a general usage question:
I have a project set up that uses DataStore. But due to https://github.com/aws-amplify/amplify-js/issues/5119 I cannot use DataStore.
It looks like the schema is very different from projects without DataStore set up, so my question is:  How does one remove datastore to use amplify without it again?

@raelmiu You would have to delete the ResolverConfig from the transformer.conf.json

@ammarkarachi and then? When I did the modelgen function is updating the API.ts file again. But all the extra data fields etc are still there.

@raelmiu Can you delete them and invoke amplify push

I seem to have a lot of boilerplate still in the code, but everything does work. Thank you @ammarkarachi

This is a general usage question:
I have a project set up that uses DataStore. But due to aws-amplify/amplify-js#5119 I cannot use DataStore.
It looks like the schema is very different from projects without DataStore set up, so my question is: How does one remove datastore to use amplify without it again?

Hi!
1.) type in terminal - 'amplify update api'
2.) choose - 'GrapQl'
3.) choose - 'Disable DataStore fro entire API'
DONE - have a nice day!

This is a general usage question:
I have a project set up that uses DataStore. But due to aws-amplify/amplify-js#5119 I cannot use DataStore.
It looks like the schema is very different from projects without DataStore set up, so my question is: How does one remove datastore to use amplify without it again?

Hi!
1.) type in terminal - 'amplify update api'
2.) choose - 'GrapQl'
3.) choose - 'Disable DataStore fro entire API'
DONE - have a nice day!

nice one mate

Can I disable Data modeling? I have enabled data modeling which designing schema!


Add Custom Language Model to Transcribe operator

Add Custom Language Model to Transcribe operator to support Video Localization application.
https://docs.aws.amazon.com/transcribe/latest/dg/create-custom-language-model.html

Duplicate of #533


Cannot Delete Members after Original Project Owner Is Deleted

What kind of request is this (question/bug/enhancement/feature request): Bug
Steps to reproduce (least amount of steps as possible):
If a project owner gets deleted, none of the other members get deleted; the lifecycle is stuck even after adding a new project owner.
Result:
None of the resources can be deleted from a project if the original owner is deleted.
Other details that may be helpful:
de25-11e9-90d4-e4434b134a34]'s doesn't have an owner, continue on next item
I0120 20:18:42.241120       1 garbagecollector.go:404] processing item [management.cattle.io/v3/User, namespace: , name: u-ss7ximwqbr, uid: ffddc45c-8009-11ea-9b13-e4434b21b984]
I0120 20:18:42.241424       1 garbagecollector.go:447] object [management.cattle.io/v3/User, namespace: , name: u-bvhkjycqxm, uid: 3aba90d6-d835-4267-a1a9-4876fd745d49]'s doesn't have an owner, continue on next item

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.4.5
Installation option (single install/HA): HA

gz#14291

See also: https://github.com/rancher/rancher/issues/29148


Vertically split window is removed in full screen zen mode after moving tab

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.76.2
OS Version: Ubuntu 22.04.2 LTS

Steps to Reproduce:

Open an empty VSCode instance
Open x4 blank editor tabs
Drag tabs 3 and 4 to a right hand side vertically split window
Go full screen
Enter zen mode
Drag tab 3 or 4 to the left hand window split
Exit full screen
The vertically split window has been removed

Version updated and the issue remains.

Unable to repro now. Let us know if the issue still occurs for you on VS Code 1.96.


Improving the template.

I'm not sure if you can add this directly to spread sheets but you could add this bit of javascript to make the fid easier to make. Alternatively you could just copy and paste it into the script editor.
function fidGenerator(input,source) {
var start = source.concat(".");
var end = ((input.toLowerCase()).replace(/'/g , "")).replace(/\s/g , "-");
var output = start.concat(end);
return output;
}
I'm sure sure it could be optimised (the middle bit is terrible) but I've never used javascript before.
Then in the template it's just put " =fidGenerator(B1,"source") " in A1.

IDs are used internally as keys, and must remain constant even if the name changes (e.g. fixing typos). Programattic creation of IDs would work initially, but it would have to be static thereafter... There's a lot of potential for this causing issues if e.g. someone left an ID as dynamically generated and then changed the name.
Thus, will not be implementing this.


Support for PHP 8

With PHP 8 around the corner, it would be nice to have support for it. Even if it's RC, I'm checking the compatibility of my project with this version.

Hey, i've just created the PR: https://github.com/thephpleague/oauth2-facebook/pull/63
It looks like the previously set phpunit version won't work with PHP 8.0 - so I had to update it.
And I've migrated also the phpunit.xml config to the "new scheme" (what was advised by the phpunit itself) :)
The tests required the changes more by the new phpunit version than the PHP (I guess).
In my fork you can find the Dockerfile (on branch php8-dockerfile) i used for testing - https://github.com/lbacik/oauth2-facebook/blob/php8-dockerfile/Dockerfile - haven't added it to the PR as I'm not sure whether you want to have it here, but if you copy it to the main project directory then you can say:
$ docker build -t php8:local .
$ docker run --rm -ti -v $(pwd):/opt/project php8:local composer i
$ docker run --rm -ti -v $(pwd):/opt/project php8:local vendor/bin/phpunit
PHPUnit 9.4.3 by Sebastian Bergmann and contributors.

......................                                            22 / 22 (100%)

Time: 00:00.594, Memory: 8.00 MB

OK (22 tests, 54 assertions)

Code coverage is 100% of files (from src) but 80% of lines - so maybe more tests to fulfil the gaps would be now a good "next step"?


Motion and Touch Gesture Together

Hello,
I checked your code. Overall looks good. But i need to see same as facebook 360 video. Both iphone motion and finger gestures apply together. How can i do it? Can you help me?
Thanks

@Maulik699 Have you solved your problem?

@Leezz233 No still not.

Anyone resolved above issue?

Just remove the first line of code
if(self.isUsingMotion) return;
in the touch callbacks (began, moved, ended)...


Show ToolTip on progress indicator

I didn't like not knowing what percent my download was at, so a quick win is to show it on the tooltip

Moved.. sorry, i swear I tried there and it had errors about not being able to find .help which I took as it not being compatible with a UIKit progress

Moved.. sorry, i swear I tried there and it had errors about not being able to find .help which I took as it not being compatible with a UIKit progress


Exposing gcalcli as an API to other programming languages (maybe using JSON)

I have a large system written in Perl / Prolog that I'm trying to sync with GCal, and I was unable to get the GCal clients for Perl to work, when I came across gcalcli, which worked great!  Thank you!  I am wondering is there a way to programmatically access gcalcli, such as via a RESTful API, or via a wrapper, or something.  I would like to avoid parsing the STDOUT of the gcalcli CLI program, but if I have to, are there ways to have it dump the entire event spec, hopefully in JSON, etc.  I know very little Python.

For now, there's no json output option built into the program.  Depending on what information you're trying to extract, the --tsv option may give you something close enough.  Alternatively, the json package is in the Python standard library, so hacking json.dumps(event) into the code somewhere shouldn't be hard.
I'd be interested in a json output PR if you make something nice.

You'd might want to use google-calendar3-cli for that purpose

Yeah, if anyone has use cases for things they'd like to do programmatically like this from python, I could take a look and think over options. IMO it's at least worth documenting any good related libraries if not exposing our own.
Does anyone know if https://github.com/Byron/google-apis-rs/tree/main/gen/calendar3-cli is easy to use as a dep of a python project or in other cases where someone might want programmatic APIs? From a glance I'd guess you'd use it by invoking an executable, not importing a library, but that may be a fine approach depending on what someone's wanting to do with it.


space after SCORE_MAX in TSV in answerwed_questions tsv

Causing validation errors in pandas read_csv, may cause issues in automated testing.

same issue in assignment_graded

same issue in quiz_completed


Remove error check

Error check (and return) at https://github.com/docker/docker/blob/master/api/server/server.go#L948 isn't needed, the error should be just ignored to just get the default 0 value from strconv.Atoi

You can use int64Value from https://github.com/docker/docker/blob/master/api/server/form.go#L14 or add another helper for int values there to be consistent.

sure, this was meant as a beginner issue @calavera, I may add intValue then

yeah, I just wanted to mention that we already have those there, so we're consistent :smile:

@calavera yup, I'm thinking to update this issue to include intValue implementation along with this to entirely remove the error checking/ignoring here

sounds great!

updated

@LK4D4 @calavera could we add label exp/beginner or exp/proficient here?

#dibs


Implement public activate account.

This change is

src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/AccountServerInterceptor.kt, line 46 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…

      if (!fullMethodName.contains(AUTHENTICATE_METHOD_NAME)) {
        if (fullMethodName.contains(ACTIVATE_ACCOUNT_METHOD_NAME)) {

We don't want to bind to the method here, but rather allow the service code to check for the expected principal. What we want the interceptor to do is put the authenticated principal into the current context. This requires doing a DB lookup to authenticate the account (hence the AuthenticateAccount method).
My apologies, I owe a design doc on these auth parts. I didn't realize you'd need them immediately for activation.

I get what that means for the other methods, but don't I still need to check the method since authenticate just requires the issuer and with activateAccount there is no account to be authenticated yet since it hasn't been activated.

src/test/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/AccountsServiceTest.kt, line 162 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
probably best to have these check for unimplemented for now, right?

These tests now assert against an error with the TODO comment above them.

src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/AccountServerInterceptor.kt, line 46 at r1 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
What I mean is that we want the code that indicates what the expected credentials/principal are to live closer to the service method. In the future we could do something like using proto annotations and checking the options from the method descriptor here, but a simpler approach for now would be just to have the interceptor do nothing if there are no credentials and let the method impl throw an exception if it can't find the expected context key.

Modified the interceptor now.

src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/AccountsService.kt, line 97 at r2 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…

with

Why using with here? Seems to only make things more confusing w.r.t. what this is.

Removed with here.

src/main/kotlin/org/wfanet/measurement/api/v2alpha/AccountConstants.kt, line 21 at r2 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
I don't think this is the right package. This isn't specific to the v2alpha version of the API.

I moved it to org.wfanet.measurement.api.

src/test/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/AccountsServiceTest.kt, line 99 at r3 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…

  // TODO("Not yet implemented")

What are these about?

Just listing out the tests I will have to do later since those methods aren't implemented yet.

src/test/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/AccountsServiceTest.kt, line 99 at r3 (raw file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Either write the actual tests knowing that they'll fail and mark them with @Ignore, or don't implement the test methods at all. Otherwise it looks like these are actually implemented tests that are passing.
Note that this TODO syntax is a Kotlin construct that's used within an actual function body and throws when you try to call it, as opposed to our TODO comments which are for documentation.

Done.

src/test/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/AccountsServiceTest.kt, line 162 at r1 (raw file):
Previously, tristanvuong2021 (Tristan Vuong) wrote…
These tests now assert against an error with the TODO comment above them.

Added implementations and made them ignored.


Can not connect

Installed matterbridge-plus on the same box that running Mattermost. Mattermost is behind a NGINX proxy redirecting everything in HTTPS (301)
In settings, if I use:
server="mattermost.mydomain.tld"

Got: can not connect
Now, if I try:
server="https://mattermost.mydomain.tld"

Got: LOGIN: /users/login: , Post https://http://mattermost.mydomain.tld/api/v1/users/login: dial tcp <my IP address>:0: connection refused, reconnecting in 1.852727759s
See the double http(s) in the URL

Matterbridge-plus only supports https connections to mattermost.
Is your server running on 443 ? If so and if it's running on the same box, try <IP_ADDRESS> or the ip mattermost is bound to.

Mattermost itself is only running locally, HTTPS is done with Nginx reverse proxy.

If you do a curl https://mattermost.mydomain.tld on the same server where you try matterbridge-plus, does it work ?
Did you try with the IP address instead of mattermost.mydomain.tld ?

I seem to be having the same issue. Mattermost and matterbridge-plus are on the same box with SSL terminated via Nginx. <IP_ADDRESS> doesn't work either. I can connect to IRC ok, and there are no error logs for the Mattermost instance that I can find.

Can you let me know if the current version still gives you problems?


Identity Schema (FKs) Remove/Create always added in Migrations when add new migration to project

I create a new Web App Project with Identity.
So, when I add "MyModel" class to "Models" folder, add to "ApplicationDbContext" too and execute "dnx ef migrations add MigrationName" command, migrations operations for Remove and Create Identity foreign keys is included in my "MigrationName"...
If I repeat the operation, the same behavior occurs.
Any suggestions?

This was fixed in https://github.com/aspnet/EntityFramework/pull/3756 and will ship in RC2. In the meantime you can either remove the extra calls... or if your just prototyping you can leave them in and let EF drop and create the FKs all the time.


Remove ga tag

Remove google analytics v4

NOTE: I took out pnpm-lock file because there was already npm-lock file


suffix identifiers in backticks with colons consistently

Looks good except for those two nits.

updated

thanks @tkellen!


docs: document errorLoadRemote lifecycle calls

Description

Related Issue

Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Checklist

[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I have updated the documentation.

The Chinese part needs to be changed simultaneously, and I need to combine an mr

I can try using ChatGPT to update the Chinese. But will need someone to translate or check its translation haha.


Add vulcanization

grunt runs the vulcanization
Can be disabled via ?vulcanize=0 URL param

Fixes #33

LGTM


Update configure-hana-azure-monitor-sap-solutions.md

Add pre req for secure comm and added #2 under configure section

@MightySuz
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Update location_extract to recognize LocationMapsGeneratorService

Error loading configuration file marc_to_solr/lib/traject_config.rb:33 NameError:uninitialized constant LocationMapsGeneratorService

closed by #1192


Return key len to code layer in SGX attestation

If the code layer passes a nonce (hash) of NULL or some other invalid
pointer to get_attestation(), the SGX backend will make a key size
request to the AESM daemon (or return a dummy value if the daemon
cannot be reached). Otherwise, the code layer can pass a pointer to
a hash with length 32 as the nonce (hash) and a Quote will be returned
to the code layer.
Resolves #313

Hmm, doesn't fit with #314

Hmm, doesn't fit with #314

Probably best to combine this and #314

Probably best to combine this and #314

@lkatalin needs a rebase

@lkatalin needs a rebase

@lkatalin needs a rebase

@connorkuehl Thanks! Rebased.

@lkatalin needs a rebase

@connorkuehl Thanks! Rebased.