GIProbe allows light to pass though walls

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Manjaro 17.0.5
Godot 3.0 Master Build
NVidia GT540M, driver 384.90
Issue description:

GIProbe produces light "artifacts". If bias is setted to 0 it produces artifacts. If bias is setted to default 1.5 the the light passes though the walls.
BIAS 1.5

BIAS 0

Steps to reproduce:
Any light with shadow with a range going beyond a wall and a GIProbe.
Run the example, and play with the range of the Omni light or with the bias of GIProbe.
Link to minimal example project:
GIProbe.zip

Should be fixed (or compensated) in Godot 3.1 with anisotropy setting..
On Oct 11, 2017 9:20 AM, "kakoeimon"<EMAIL_ADDRESS>wrote:

Operating system or device, Godot version, GPU Model and driver (if
graphics related):
Manjaro 17.0.5
Godot 3.0 Master Build
NVidia GT540M, driver 384.90
Issue description:
GIProbe produces light "artifacts". If bias is setted to 0 it produces
artifacts. If bias is setted to default 1.5 the the light passes though the
walls.
BIAS 1.5
[image: screenshot_2017-10-11_15-10-33]
https://user-images.githubusercontent.com/13662414/31440092-5a59039c-ae97-11e7-9e9d-e6526544b42a.png
BIAS 0
[image: screenshot_2017-10-11_15-16-39]
https://user-images.githubusercontent.com/13662414/31440127-79d21ee8-ae97-11e7-9b44-1c9cd4b8f056.png
Steps to reproduce:
Any light with shadow with a range going beyond a wall and a GIProbe.
Run the example, and play with the range of the Omni light or with the
bias of GIProbe.
Link to minimal example project:
GIProbe.zip
https://github.com/godotengine/godot/files/1375518/GIProbe.zip
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/12024, or mute the thread
https://github.com/notifications/unsubscribe-auth/AF-Z2xvBGo2aAiQJ5y5_WLaLWZbR8z5mks5srLKggaJpZM4P1YT_
.

@reduz Is that going to be an anisotropy setting for the GIProbe itself?
(BTW, I couldn't find much documentation on GIProbe, it might be a good idea to have a dedicated doc or tutorial on it since it's one of the strong selling points of Godot 3.)

@tagcup Ah, I was planning on writing docs on lighting techniques before Beta is out, guess I should work on that ASAP.

@tagcup Regarding Anisotropy, there are two ways of doing it.
The first is having a cubemap array, so you have lighting info for each voxel face, which means increasing the probe size by 6
The second (what I will do) is adding a RGB565 cubemap array of two elements which contains the lighting distribution on each voxel face. This has the problem that, for colored light, you can get color bleeding for lights on both sides, but It's not too bad honestly.

@reduz Ah, didn't realize you were planning for a wider topic (lighting techniques), that'd be awesome since a lot of the settings in light-related nodes are mystery to users.
I'm pretty sure there are higher-priority tasks before the feature-freeze, but you know your schedule best.
So about the cubemaps, what exactly is going to be anisotropic?

Did not have time to fix this for 3.1, given no rendering changes will be made pending port to Vulkan.
Kicking to 3.2

I got a similar issue with OmniLight without even using GIProbe. I saw no one reporting it so I don't know if I should file a new bug report or simply post here as it is very similar.
This is how it looks in my game :

And the project to reproduce it :+1:
LightBleedExample.zip
After searching for the cause of my issue tested various solutions. I tried various settings like increasing the wall thickness, adjusting the biais, switching shadow casting to double-sided...
Nothing fixes it.
The only work around I found is to try to adjust the render layer of objects that shouldn't be affected to move them in a layer that isn't affected by the light. But it's messy and probably not the intended solution.
So, sorry for bumping an old thread but considering I encountered the same issue without any GIProbe I figured that maybe the title should be changed ?

@Adinimys This is unrelated to GIProbe. Please ask in one of the other community channels instead, as I don't think this is a bug (it could be an issue with your wall model).

I forgot to mention that I asked on Discord before posting here. I was told there by two users that looked at my project that they couldn't fix it and that it looked like a bug and that I should come post on Github.
About my mesh being manifold. I followed these advices : https://blender.stackexchange.com/questions/7910/what-is-non-manifold-geometry and I think that it's ok. I found no issues. It seems suitable to me. You can take a look at it here :
walls.blend.zip

@Adinimys I looked into your reproduction project. The reason you are seeing some color on the back of the walls is because you have your shadows to set to gray instead of black. Gray shadows let some light through (which is the entire point of having gray shadows). If you don't want color in the shadows area, set your shadow color to black.

Damn.  Sorry for wasting your time with that :/

Ah nevermind, I hadn't seen that the now-resolved https://github.com/godotengine/godot/issues/12024#issuecomment-581072895 was added to a pre-existing valid report.

This was resolved to an extent in the new Vulkan renderer (after enabling anisotropy in GIProbe), closing. Also, the new lightmapper should be leak-free and SDFGI can be made more resistent to leaks by enabling occlusion (at the cost of performance).
In any case, you may have to design your level around it by making walls thick enough when possible. (This is generally the case in any game engine out there.)


[Improvement]: Web console default deployment to the running one

Describe the improvement
Hi folks,
I have a project named zort-2, and it contains 4 deployments

1 Stopped and Dirty.
2 Stopped and Committed.
1 Running and Committed.

When I open the Web Console to see logs, it defaults to the first deployment shown in the list although it's stopped and not begin used anymore. That might be misleading when an operator wants to check the logs for the running version of the deployment, or at least requires the operator to manually pick the running deployment all the time.
Instead, either

Sorting the deployments with the order Running deployment and then the Stopped deployments by their timestamp.
Showing the active deployment's pane by default.

can be done to improve that part.
IMHO, having the 1st option is more useful in terms of the developer experience and reduce the cognitive overhead when debugging/observing a system.
Duplicate declaration

[X] I have searched the issues and this improvement has not been requested before.

I agree, showing logs for a stopped deployment when you have a running deployment is not useful, and it's unexpected. The console isn't open-source yet, but we'll look into this, thanks for the report and the suggested solutions!

For console.shuttle.dev, no deployment logs are opened by default. If we add that, we'll reconsider the logic for which one to pick.


fix: remove 4844 transaction type

Motivation
EIP-4844 transactions are not supported on OP stack networks https://specs.optimism.io/protocol/exec-engine.html#ecotone-disable-blob-transactions
Solution
Removes 4844 variants from transaction and receipt consensus types.
We still have those on RPC types, should we introduce op-specific RPC types? it would also unblock https://github.com/alloy-rs/op-alloy/pull/121

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

We still have those on RPC types, should we introduce op-specific RPC types? it would also unblock #121

yepp valid, pls open an issue and link in the blocked issue

We still have those on RPC types, should we introduce op-specific RPC types? it would also unblock #121

yepp valid, pls open an issue and link in the blocked issue

looks like we already track it in https://github.com/alloy-rs/op-alloy/issues/27
don't think think we should duplicate the types completely, can just keep extra fields as None and don't implement 7702 and 4844 builders for OpTransactionRequest


MC/Discord Linking Nickname Format

Hello, I'd like to request to have the bot change the nickname directly to the linked MC name instead of the current format.
Current format being:
discordname[MC:mcname]
to
mcname
Many users on my discord server already have their discord account name as their MC name. Plus it would make things so much cleaner to look at.
Thankies!

Hi. Okay so, this feature was implemented based on a previous request, which requested to have the username in that format.
We would have to make it configurable, which shouldn't be an issue. This will only be implemented with V3 of the mod though, since we are busy rewriting the entire mod

Implemented in V3 beta


BlockUntil insufficient for testing Timers

As per https://github.com/jonboulle/clockwork/issues/82, BlockUntil blocks on the number of active waiters, and for Timers/Tickers this means construction. Stop removes the waiter, and Reset adds it again. In practice I've found BlockUntil is insufficient to test code using Timers and Tickers because it can't distinguish between before a call to Stop, and after a call to Reset.
I'm curious if maintainers would be interested in the proposed addition. I've been using this in my test code implemented as a wrapper around clockwork, but supporting it in the library itself would be preferable. Happy to contribute the change.
Real-ish World Example
Imagine you want to write a test for the following state machine:
// Sends an incrementing counter on the counters channel every 3 seconds.
// If a heartbeat isn't received within 5 seconds, exits with an error.
func runStateMachine(
	ctx context.Context,
	clock clockwork.Clock,
	counters chan int,
	heartbeats chan struct{},
) error {

	counterTimer := clock.NewTimer(3 * time.Second)
	defer counterTimer.Stop()

	heartbeatTimeout := clock.NewTimer(5 * time.Second)
	defer heartbeatTimeout.Stop()

	counter := 1

	for {
		select {
		case <-counterTimer.Chan():
			counterTimer = clock.NewTimer(3 * time.Second)
			counters <- counter
			counter++

		case <-heartbeats:
			heartbeatTimeout.Stop()
			heartbeatTimeout = clock.NewTimer(5 * time.Second)

		case <-heartbeatTimeout.Chan():
			return fmt.Errorf("Timeout at %d", clock.Now().Unix())

		case <-ctx.Done():
			return ctx.Err()
		}
	}
}

You'll end up running into a situation where there's no primitive in the clockwork library to ensure that Advance doesn't race with the resetting of a timer:
func TestRunStateMachine_SendingHeartbeatResetsTimeout(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
	fakeClock := clockwork.NewFakeClockAt(time.Unix(0, 0))
	counters := make(chan int)
	heartbeats := make(chan struct{})

	done := make(chan error, 1)
	go func() {
		err := runStateMachine(ctx, fakeClock, counters, heartbeats)
		done <- err
	}()

	// Ensure state machine timers are initialized at time zero before advancing.
	fakeClock.BlockUntil(2)
	fakeClock.Advance(3 * time.Second)
	counter := <-counters
	require.Equal(t, 1, counter)

	// Sending a heartbeat gives us another 5 seconds, allowing for another counter to be
	// produced at 6 seconds in.
	heartbeats <- struct{}{}
	log.Println("Trigger race by removing this print statement (at least on my machine)")

	// PROBLEM: What do we block on here to ensure that the heartbeat timer is reset at time 3
	// rather than time 6? We can't use BlockUntil(2) because the condition is already true
	// before heartbeatTimeout.Stop() is called.

	fakeClock.Advance(3 * time.Second)
	counter = <-counters
	require.Equal(t, 2, counter)

	fakeClock.Advance(2 * time.Second)
	err := <-done
	require.Error(t, err)
	require.Contains(t, err.Error(), "Timeout at 8")
}

Possible Solution: Adjust System Under Test
Sometimes it's possible to write your system under test such that this race is avoided. In the above example, we reset the counterTimer before sending on the counters channel, ensuring that the reset always happens before the reset. However, in-practice I've found situations where it's just not reasonable to contort your system under test to solve for this race condition. In the above example, the heartbeatTimeout reset is similar to a real world situation I ran into, and ultimately solved with the solution proposed below.
Proposed Solution: Add BlockUntilMonotonic or BlockUntilSeenSoFar
What I've found works quite well, is a BlockUntilMonotonic method on FakeClock which blocks on the monotonically increasing number of watchers the clock has ever seen.
In the example above, the usage would look like this:
heartbeats <- struct{}{}
fakeClock.BlockUntilMonotonic(4)
// Unblocks after the new Timer is created.

In-practice, I've found reasoning about the total number of watchers that have been created over the life of the test to be tedious, so I've created a helper method that avoids me having to count.
seen := fakeClock.CurrentMonotonic()
heartbeats <- struct{}{}
fakeClock.BlockUntilMonotonic(seen + 1)
// Unblocks after the new Timer is created.

Implementation
I suspect the implementation will be relatively simple: just keep track of the total number of waiters the FakeClock has ever seen, and use a similar blocker primitive to unblock when enough new waiters are seen.
Naming
I don't have strong feelings about the naming. So far I've liked BlockUntilSeenSoFar or BlockUntilMonotonic the most as far as naming goes.

From my perspective, I'm not generally supportive of making BlockUntilContext even more complex. It's behavior is already kinda racey and hard to manage.

Totally agree that this adds complexity. As per https://github.com/jonboulle/clockwork/issues/82, the complexity is already there if you want to develop and test any non-trivial use of timers/tickers. I see this as pretty similar to the context ticket you have open (https://github.com/jonboulle/clockwork/issues/94) where it's filling in the gaps that are keeping clockwork for being a complete solution for testing time related things in Go. Ideally we keep this issue open so folks keep thinking about it, and maybe we'll either land on a simpler API or decide that it's worth biting the complexity bullet.


Upgrade govuk_content_models, hence govspeak, and hence nokogiri.

I was seeing the following test failure when running on OS X Yosemite with the
default libxml provided by Apple:
ERROR (0:00:26.315) test: ListingTags should display tags in alphabetical order grouped by their parent.
      Unable to find css "li.parent-tag:nth-of-type(2)"
    @ .bundle/gems/gems/capybara-2.1.0/lib/capybara/node/finders.rb:41:in `block in find'
      .bundle/gems/gems/capybara-2.1.0/lib/capybara/node/base.rb:81:in `synchronize'
      .bundle/gems/gems/capybara-2.1.0/lib/capybara/node/finders.rb:30:in `find'
      .bundle/gems/gems/capybara-2.1.0/lib/capybara/session.rb:354:in `block (2 levels) in <class:Session>'
      .bundle/gems/gems/capybara-2.1.0/lib/capybara/session.rb:221:in `within'
      .bundle/gems/gems/capybara-2.1.0/lib/capybara/dsl.rb:51:in `block (2 levels) in <module:DSL>'
      test/integration/listing_tags_test.rb:34:in `block (2 levels) in <class:ListingTagsTest>'
      [...truncated...]

I believe this was because the version of the nokogiri gem specified in
Gemfile.lock, i.e. v1.5.11, was incompatible with the version of libxml
available by default in OS X Yosemite.
The govuk_content_models gem pinned at v28.5.0 in the Gemfile was
constraining govspeak to ~> 3.1.0 which in turn was constraining nokogiri
to ~> 1.5.10. Thus I was prevented from upgrading nokogiri to a version
supported by my libxml version.
A pull request relaxing the former constraint was merged and released
in govuk_content_models v3.3.0.
This commit upgrades govuk_content_models to this new version and upgrades
nokogiri to v<IP_ADDRESS> which is the latest version. This fixes my failing test
and all the tests pass on my laptop.
The upgrade of govuk_content_models should be ok, because it's just a minor
version change, but I'm not familiar enough with the code to know for sure.
You can see the relevant changes in this GitHub comparison. The most
significant commits appear to be this one and this one.

Nokogiri has subsequently been updated to <IP_ADDRESS> on master.  Closing this.


Handle blinds

Description
Handle blinds (e.g. cards being debuffed, etc.). Take Chicot into account.

[x] The Club (Clubs debuffed)
[x] The Goad (Spades debuffed)
[x] The Head (Hearts debuffed)
[x] The Window (Diamonds debuffed)
[x] The Plant (Face cards debuffed)
[x] The Pillar (Previous-to-Ante played cards debuffed): This one is tricky. The simplest way to implement this is probably to add a "Debuffed?" checkbox to all cards that's only shown if this blind is selected.
[x] Verdant Leaf (All cards debuffed until joker sold): Users can remove the joker they would sell to simulate disabling the boss blind effect; however, to handle scoring while Verdant Leaf's effect is still active, I need a notion of "Blind effect is active".

Implemented in https://github.com/kleinfreund/balatrolator/commit/ecbab32a087b6c26c9a792647bcaaa98c065e7b3 and https://github.com/kleinfreund/balatrolator/commit/89756799024f947847a9d2148da3667341a059f5.

One more note: "Crimson Heart" disables a random joker. This doesn't currently have a dedicated interaction in the UI, but since one can remove a joker and add it again later, I don't think there's a pressing need for it.


AndroidDocumentProvider is overzealous with updates

DocumentProvider is obligated to tell its Listener that the tree changed by calling the DocumentProvider.Listener.onPossiblyChanged() method. DOM then picks this up and re-reads the entire tree and does some smart stuff and pushes the delta over to Chrome.
However, AndroidDocumentProvider calls onPossiblyChanged() once per second. Every second. Even if nothing could possibly have changed! If we can hook into something like ViewTreeObserver correctly then we should be able to have a better idea of when we should call actually call this method.
The goal: if the app is idle, then AndroidDocumentProvider should not call onPossiblyChanged().

I'm taking a look at this :)


Price Filter tickSize problem on creating an order

Version
v0.0.76 (9119c6d)
Description
As the ticksize in 0.1 and the create order use 2 decimals, there is a 'PRICE_FILTER' error.
https://api.binance.com/api/v3/exchangeInfo?symbol=AAVEUSDT
AAVEUSDT Buy Action Grid Trade #1 (12:10:50.056): STOP_LOSS_LIMIT
- Order Params:
{
  "orderParams": {
    "symbol": "AAVEUSDT",
    "side": "buy",
    "type": "STOP_LOSS_LIMIT",
    "quantity": 1.3895,
    "stopPrice": 359.14,
    "price": 359.49,
    "timeInForce": "GTC"
  }
}

Execution failed (12:10:50.789)
Job: Trailing Trade
Code: -1013
Message:
Filter failure: PRICE_FILTER
- Current API Usage: 366

To Reproduce
Place a manual limit BUY order to AAVEUSDT with a 2 decimals price.

I assume the issue is resolved. I will close the issue.

Yep, will test that this afternoon !

To confirm you that v0.0.77 fix that issue on Apply to global only
=> perhaps we could add a cronjob that runs every 6 hours, cleans redis trailing-trade-symbols.symbol-info and refresh exchangeInfos for all selected symbols ?


Mapped a bunch of villager and gossip related stuff

I figured out gossips, iron golem mechanics and a few other misc methods in VillagerEntity.

Just make sure this one does not conflict with #533

@liach Is there a quick way to check that? I'll go through them manually for now.

hmm, i think you can try a compare between the 2 branches

Hm, so we need to figure out a strategy in regards to the 3 way intersection with #527, #536 and #537

Hm, so we need to figure out a strategy in regards to the 3 way intersection with #527, #536 and #537

#537 seems pretty easy to fix. I can't see any collisions why #527 though?

#527 maps villager gossip related code


Incomplete rendering of tracks in the queue and playlist tabs with seemingly random frequency

Hello!
I would like to thank you so much for creating such a wonderful, open-source, application.
I seem to be having an issue with seeing tracks added to playlists or queues after specific files.
The queue will appear fully blank even if there are many tracks enqueued. The same applies to playlists.
What I'm currently seeing:

There are 8 tracks visible in this playlist, but MPD reports 261 total tracks in the same playlist.
The same issues are visible in the Queue

The Library does not appear to be affected by this bug

I would be expecting the interface to present all the tracks enqueued or added to the playlists as seen here

If I have a spare moment I'll take a look at the source code to identify the possible problem and suggest a potential fix.
Thank you again!

Thank you so much for the detailed report! This sounds like the same bug reported in the "Discussions" page about a month ago.
#3
Unfortunately, I have not found the cause of the bug yet. The problem is that I can't reproduce the bug in my environment. I hate to ask you but, if it is OK, could you copy the queue in the debug log (bottom right window) and paste it here? (or you could mail it to me)
It looks something like this below. I'd very much like to test and find the cause. Thank you in advance.
>>>>playlistinfo
<<<<file: John Lee Hooker/The Very Best Of John Lee Hooker/One Bourbon, One Scotch, One Beer.mp3
<<<<Last-Modified: 2021-01-07T12:52:08Z
<<<<Artist: John Lee Hooker
<<<<Album: The Very Best Of John Lee Hooker
<<<<Title: One Bourbon, One Scotch, One Beer
<<<<Genre: Blues
<<<<Date: 2002
<<<<Time: 187
<<<<duration: 187.380
<<<<Pos: 324
<<<<Id: 653
<<<<file: John Lee Hooker/The Very Best Of John Lee Hooker/Shake It Baby.mp3
<<<<Last-Modified: 2021-01-07T12:49:40Z
<<<<Artist: John Lee Hooker
<<<<Album: The Very Best Of John Lee Hooker
<<<<Title: Shake It Baby
<<<<Genre: Blues
<<<<Date: 2002
<<<<Time: 251
<<<<duration: 250.976
<<<<Pos: 325
<<<<Id: 654
<<<<file: John Lee Hooker/The Very Best Of John Lee Hooker/Terraplane Blues with Roy Rogers.mp3
<<<<Last-Modified: 2021-01-07T12:53:20Z
<<<<Artist: John Lee Hooker
<<<<Album: The Very Best Of John Lee Hooker
<<<<Title: Terraplane Blues with Roy Rogers
<<<<Genre: Blues
<<<<Date: 2002
<<<<Time: 176
<<<<duration: 176.297
<<<<Pos: 326
<<<<Id: 655
<<<<file: John Lee Hooker/The Very Best Of John Lee Hooker/You Know, I Know.mp3
<<<<Last-Modified: 2021-01-07T12:51:38Z
<<<<Artist: John Lee Hooker
<<<<Album: The Very Best Of John Lee Hooker
<<<<Title: You Know, I Know
<<<<Genre: Blues
<<<<Date: 2002
<<<<Time: 245
<<<<duration: 245.350
<<<<Pos: 327
<<<<Id: 656
<<<<OK

I think I know the cause... My initial theory was wrong. It wasn't parsing. It's the updates. Your screenshot gives me an idea (Thanks). You turns "consume" mode on. It means the entire queue list updates every time song changes. And it may cause conflict in some situation especially if you have a long queue list. When you turns "consume" mode on and change songs rapidly, MPDCtrl receives flood of huge queue lists from MPD asynchronously.

I just uploaded a new version (v3.0.6) to Microsoft Store. It should be available within a few days. It may or may not fix your problem. It might have been a different bug. Hope you try it out and see it's been fixed. Thank you in advance!

Hello! Sorry about the delay, I saw your message last night and forgot to respond.
Thank you for looking into this! I can still provide the debug log if you'd like, I'll gather the information shortly

Attached are the debug logs as requested -
I have noticed that only certain tracks (or rather tracks by a particular artist) seem to fault the application.
2021-06-03-MPD_Ctrl_Debug.log
For completeness, this is what is shown in the GUI.

Thank you again!

Thank you so much for the log!

I have noticed that only certain tracks (or rather tracks by a particular artist) seem to fault the application.

Interesting... then it could be a different bug.
I'll debug the app using the logs you gave. Thank you very much.

Ah-ha!

'System.ArgumentException' (System.Private.CoreLib.dll)
Exception@ParsePlaylistInfo: An item with the same key has already been added. Key: Genre

<<<<file: Harris Heller/Synthwave/Sunset/01 - Zig the Zag.flac
<<<<Last-Modified: 2021-06-03T16:52:10Z
<<<<Album: Sunset
<<<<AlbumArtist: Harris Heller
<<<<Artist: Harris Heller
<<<<Date: 2021-03-05
<<<<Disc: 1
<<<<Genre: Electro
<<<<Genre: Dance
<<<<Title: Zig the Zag
<<<<Track: 1
<<<<Time: 126
<<<<duration: 126.250
<<<<Pos: 6
<<<<Id: 1439
I've never expected to receive duplicated "Genre"!
Finally! Thank you so much!

Ah, wow! Very interesting, I actually had no idea one could add duplicate entries to the metadata tags
The tracks in question came to me pre-tagged in this case
I was intrigued and decided to take a look at how different media players and tag editors rendered the metadata for files with duplicate tag entries.
Mp3tag will render the multiple Genres as Electro\\Dance in the editor textbox, but in the "Extended Tag Editor" have multiple entries of the GENERE tag. Interestingly enough, the Mp3Tag file properties window for the track only shows Electro as the genre.
The Windows file properties dialog renders the genre field as Electro; Dance
VLC simply combines them with a space character making Electro Dance
MPC-HC's MediaInfo renders the tag as Electro / Dance
It appears there isn't one standardized solution for this, but it's quite fascinating, nonetheless!
Let me know if you need anything further from me :)
Thanks!

I was gonna check the same thing! You beat me (and did whole lot better). :-)
A quick search told me it isn't popular but there is no standard way.
I just uploaded a yet another new version (v3.0.7) to Microsoft Store. So, I'd much appreciate it if you could check to see if it works.
Thank you very much again!

It appears to be working quite well now!
This is very exciting :)

Thank you for the prompt resolution, I really appreciate your hard work!


✨ [FEATURE] - Remove duplicate python methods in .pyi file

Description
All elements share many common methods, it would be nice if Element was treated as an abc.ABC class and had all common methods in there.
Additional information
No response
Type
Enhancement

Closing because abstract method and classes are not supported with pyo3.


Licence file states MIT but the javascript file says GPL 2.0

In the licence of it says this jquery plugin is MIT however in the javascript file it is stated as being GPL 2.0. Does this just need to be changed in the javascript file or is it actually GPL 2.0?

Hi @Rambomst.  For clarity: as of v1.0.0, this plugin is licensed MIT and the packaged / minified JavaScript files should reflect that.  Versions prior to v1.0.0 were licensed GPL2.
I see, however, that the source file mentions GPL2, which is incorrect.  I'll fix that here shortly.


UTF-8 Chars and OKHttp 2.6

As pper https://github.com/square/okhttp/issues/2016 OKHtttp is more restrict with HTTP headers and all non ASCII file names causes crash on beta 3 when used with OKHttp 2.6.
Everything is OK with 2.4
In did try to use URLEncoder ( http://developer.android.com/reference/java/net/URLEncoder.html ) before upload, but this caused file name to be double encoded

Here is a sample stack trace
STACK_TRACE=java.lang.IllegalArgumentException: Unexpected char 0x410 at 10 in header value: {"path":"/риценко.mp4","mode":{".tag":"overwrite"},"autorename":false,"mute":false}
at com.squareup.okhttp.Headers$Builder.checkNameAndValue(SourceFile:295)
at com.squareup.okhttp.Headers$Builder.add(SourceFile:245)
at com.squareup.okhttp.Request$Builder.addHeader(SourceFile:194)
at com.dropbox.core.http.OkHttpRequestor.toOkHttpHeaders(SourceFile:91)
at com.dropbox.core.http.OkHttpRequestor.startUpload(SourceFile:84)
at com.dropbox.core.http.OkHttpRequestor.startPost(SourceFile:69)
at com.dropbox.core.http.OkHttpRequestor.startPost(SourceFile:30)
at com.dropbox.core.v2.DbxRawClientV2.uploadStyle(SourceFile:169)
at com.dropbox.core.v2.DbxFiles.upload(SourceFile:8176)
at com.dropbox.core.v2.DbxFiles.access$5900(SourceFile:25)
at com.dropbox.core.v2.DbxFiles$UploadBuilder.start(SourceFile:8224)
at com.dropbox.core.v2.DbxFiles$UploadBuilder.start(SourceFile:8190)
at com.dropbox.core.v2.DbxUploadStyleBuilder.run(SourceFile:29)
at dhy.a(SourceFile:56)
at dhb.a(SourceFile:123)
at com.nll.cloud.DroboxV2IntentService.a(SourceFile:43)
at dfv.a(SourceFile:97)
at dfv.onHandleIntent(SourceFile:58)
at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:65)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:136)
at android.os.HandlerThread.run(HandlerThread.java:61)

We just switched to using ASCII-only in beta-4, so hopefully that works for you.  (When I switched to ASCII-only I didn't think anyone would be immediately affected since the previous code worked for me, but I never tested OkHttp :-)
BTW, this repo is deprecated.  You should use "dropbox-sdk-java" repo instead.


Add ID client

This PR adds support for clients.
Clients can use the function SupportID() to determine if the server supports the ID command.
In addition, they can send an ID command and get the server's ID as response.
I hope this meets all requirements to get merged.
Thanks.

Thanks!


Haiku: Add utmpx functions and constants

Progressing further on #2429 adding functions and constants related to the utmpx structure
Haiku headers for reference

@bors r+


test(extension): e2e add noStrictFlaky option

LW-10859
Adding 'noStrictFlaky' flag to cucumber options. This will not fail a suite which had a failed test that passed on retry.
Works as advertised, test on cucumber report is marked as failed but not failing whole runner results as it passed on retry:

Allure Report
allure-report-publisher generated test report!

smokeTests: ✅ test report for 81d348e7

passed
failed
skipped
flaky
total
result

Total
33
0
0
0
33
✅


Host-based tests don't generate resource coverage

When performing tests using the "host" type resource coverage is not correctly generated (it is completely absent).
I believe I have diagnosed why and found a work-around, but it isn't clear to me what the complete and proper fix is.
When test_module is set in lib/rspec-puppet/support.rb it is set (line 32):
        test_module = class_name.split('::').first

class_name is set like so in lib/rspec-puppet/support.rb, lines 111-113:
    def class_name
      self.class.top_level_description.downcase
    end

The result is that for a test declaration such as describe 'testhost' do now test_module equals testhost. This causes the test in RSpec::Puppet::Coverage.filter_resource? (lines 139 - 144 in lib/rspec-puppet/coverage.rb) to always filter any Class resource, as it is always comparing against the hostname instead:
      if resource.type == 'Class'
        module_name = resource.title.split('::').first.downcase
        if module_name != test_module
          return true
        end
      end

The work-around is that you have to override class_name in the host test, which also then means you need to override the node name, as it defaults to class_name for the node case.
So, if you are testing a class called test and trying to do a host-level test in spec/hosts/myhost_spec.rb it would have to look something like:
describe 'myhost' do
  let(:class_name) { 'test' }
  let(:node) { 'myhost' }
....

This seems to not be the intent of the design, nor terribly user friendly (especially for anyone just getting started with spec testing).
Part of the fix seems obvious to me. You can eliminate the requirement to specify node again by fixing nodename (in lib/rspec-puppet/support.rb) to point to the top level description:
diff --git a/lib/rspec-puppet/support.rb b/lib/rspec-puppet/support.rb
index 56dc871..a4ad2ed 100644
--- a/lib/rspec-puppet/support.rb
+++ b/lib/rspec-puppet/support.rb
@@ -103,6 +103,8 @@ module RSpec::Puppet
       return node if self.respond_to?(:node)
       if [:class, :define, :function, :application].include? type
         Puppet[:certname]
+      elsif type == :host
+        self.class.top_level_description.downcase
       else
         class_name
       end

This reduces it to only having to specify class_name. It would be great to not have to specify class_name, but it is not clear to me how to do it (or even if it is feasible).

I have posted a simple repository which will demonstrate this. It expects to be checked out in a directory called "issue466" (to match the module name). The repository is here: https://github.com/seanmil/rspec-puppet-issue-466-example


Processing code for Pi In the Sky

Community Contribution
Link to live project, video, or image:

Sharing

[ x] I would be happy to have my project shared on The Coding Train's social media!

Please take a look at the community contribution guide on how to contribute! If this was meant as a processing port please use the correct format (see other challenges)


[LLVMGPU] Make linalg_ext.online_attention op as the root op

This commit changes LLVMGPUSelectLoweringConfig to look for linalg_ext.online_attention op. In order to make that work, the lowering from linalg_ext.attention is hoisted just above the pass.
As a consequence linalg_ext.online_attention op now implements LinalgFusionInterface and generateResultTileValue.

Cool I ll change the tests -- quite wasn't sure which inputs should be tested here given that fronted still gives us linalg_ext.attention


Cost bo loop

Currently, we can only pass initial data points and their corresponding function values to the BO optimization loop. However, in case we also want to keep track of the cost per function evaluation, we should also be able to pass the initial cost. Otherwise, this will mess up our internal loop state.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #195 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #195   +/-   ##
=======================================
  Coverage   89.47%   89.47%
=======================================
  Files         105      105
  Lines        2861     2861
  Branches      292      292
=======================================
  Hits         2560     2560
  Misses        249      249
  Partials       52       52

Impacted Files
Coverage Δ

emukit/core/loop/loop_state.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 472b5f0...11beb8c. Read the comment docs.

Actually one more thing. Can you add a unit test that verifies initial cost is used as expected? Can be as simple as "create bo loop, make sure cost is in the state, done"

ok I've updated a simple unit test that check whether the all the initial data is in the loop state

Looks good, but the build fails for some reason

hmm wired, I dont understand why it suddenly throws an import error?

Ok after some digging, the problem seems to be a bug in pytorch here
It seems that they are already working on a PR. In the meantime: brew install libomp seems to solve the problem

Ok, few options:

Wait until they release the fix in pytorch
Amend our build and, once the bug is fixed, reverse this change
Install older version of pytorch that didn't have the bug yet. again reverse once fixed

2 and 3 would be best i guess. if you go down that route, can you please create an issue and reference the PR or whatever we can from PyTorch repo?

ok let's go for 2 since I don't know after which pytorch version that bug occurred

So the build has passed, but running times are concerning: over 20 minutes on macos. @aaronkl how long does  this new test run locally for you?

it's seems that the test for Bohamiann take much longer than necessary. I will send another PR to solve that.

Much better times now, merging


[SPARK-42521][SQL] Add NULLs for INSERTs with user-specified lists of fewer columns than the target table

What changes were proposed in this pull request?
Add NULLs for INSERTs with user-specified lists of fewer columns than the target table.
This is done by updating the semantics of the USE_NULLS_FOR_MISSING_DEFAULT_COLUMN_VALUES SQLConf to only apply for INSERTs with explicit user-specific column lists, and changing it to true by default.
Why are the changes needed?
This behavior is consistent with other query engines.
Does this PR introduce any user-facing change?
Yes, per above.
How was this patch tested?
Unit test coverage in InsertSuite.

Hi @gengliangwang 👋

LGTM except one comment and the pending test failures.

Thanks, merging to master/3.4
This makes the column default feature simpler and more reasonable.
cc @xinrong-meng


Overlapping Equations

Steps to reproduce the problem

Go to https://learn.qiskit.org/course/ch-algorithms/quantum-teleportation
scroll down to Step 2
See overlapping equation text

What is the current behavior?
A clear and concise description of what the bug is.
What is the expected behavior?
the content of the equations within Step 2 overlap with the glossary content to the right
Screenshots (optional but very helpful)

Environment (optional but very helpful)

Device: Mac OS
Browser: Safari

It no longer happens since the layout refactor. Can you confirm @gracelindsell ? Maybe you have to hard-refresh the content to update CSS.


[hotfix] Don't call check_spam if user cannot be loaded from request

Purpose

Before 0.138, wiki spam cwas checked in Node.on_update, which
checks if user before calling check_spam.
WikiVersion.check_spam does NOT check if user, so the
check_spam call raises an error.
This is preventing some users' submissions to OSF4M.
Changes

Don't call WikiVersion.check_spam unless a user can be loaded from the request.
QA Notes

Quick regression test to make sure OSF4M submission still works.
Documentation

Side Effects

This may not be the best long-term solution, but it's low-risk, and
this will at least allow prod users to submit to OSF4M. In the future, we may want to allow check_spam to work without a user.
Ticket

Sentry: https://sentry2.cos.io/cos/osf-back-end/issues/2892/
(no JIRA ticket)

Test failure is unrelated to this code.


#10483 Response::redirect() uses 200 status code for IE 11

Adjustments for #10483
Response::redirect() uses 200 status code if 'X-Ie-Redirect-Compatibility' header sent

https://github.com/yiisoft/yii2/commit/57ab949be543471a7f59aa3c18c2d5199e17de91

Wait, shouldn't the check be if the header is absent, as it is specified in the phpdoc above the function? This MR changed the === back to a !==. The documentation contradicts the code now.
How is it supposed to work? Should the header be specified for the redirect to work on IE? That would require to change every ajax call to include the X-Ie-Redirect-Compatibility header for the redirect to work in IE. That doesn't seem right?

@michaelarnauts please create a separate issue since comment is likely to be lost...


Flutter analyze dives deep into the build/ tree

Analyzer looks into the volatile build/ tree. In fact it steps into ANY not hidden
(dot) directory tree. This is time wasted at every invocation.
Steps to Reproduce
% flutter create -a kotlin -i swift exapp ; cd exapp && flutter build
  # flutter build populates build with some 200MB+ /

% mkdir -p build/kotlin/live_examples/bundled/dartcode/

% echo 'noneSuchType x = 0;'> build/kotlin/live_examples/bundled/dartcode/fail.dart

% flutter analyze
Analyzing /testbed/flutter/exapp...
    error • Undefined class 'noneSuchType' at build/kotlin/live_examples/bundled/dartcode/fail.dart:1:1 • undefined_class
    1 issue found.
    (Ran in 14.6s)

Logs
N/A
Flutter Doctor
[✓] Flutter (Channel beta, v0.1.5, on Linux, locale pl_PL.utf8)
    • Flutter version 0.1.5 at /testbed/lib/flutter
    • Framework revision 3ea4d06340 (4 weeks ago), 2018-02-22 11:12:39 -0800
    • Engine revision ead227f118
    • Dart version 2.0.0-dev.28.0.flutter-0b4f01f759

[✓] Android toolchain - develop for Android devices (Android SDK 26.0.2)
    • Android SDK at /testbed/lib/Android/Sdk
    • Android NDK at /testbed/lib/Android/Sdk/ndk-bundle
    • Platform android-27, build-tools 26.0.2
    • ANDROID_HOME = /testbed/lib/Android/Sdk
    • Java binary at: /testbed/lib/Android/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[✓] Android Studio (version 3.0)
    • Android Studio at /testbed/lib/Android/android-studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[✓] Connected devices (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 6.0 (API 23) (emulator)

• No issues found!

cc @devoncarew


#8049: Automate perf measurements

Scripts enable couple of things:

perf_summary.py removes all warmup runs from csv and only process latest run
get_falcon40b_perf_numbers.sh runs 128 and 2048 seq_lens and executes perf_summary script after so only manual step is to get grouped_summary for both seq_lens and paste into excel sheet for getting full report with calculated component times, whole layer time, predicted model time and perf (tok/s).

@johanna-rock-tt, modified scripts only affect how perf is measured and do not impact any model component so I didn't run any tests.


Remove MutatingWebhook/ValidatingWebhook from default watching K8s resources

What this PR does / why we need it:
Because in the case of using GKE Autopilot, they are denied by GKE.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

Remove MutatingWebhook/ValidatingWebhook from default watching K8s resources (They can be added explicitly in Piped config).

/lgtm

/approve


[DMP 2024]: Cross-border verification using a foreign trust registry

Ticket Contents
Description
The Cross-Border Credential Verification System is aimed at enabling seamless verification of credentials across borders. The system facilitates verification between different trust registries, allowing entities in one country to verify credentials issued by trusted sources in another country. As an example, this system allows Canadian entities to verify credentials issued by Bhutanese sources, and vice versa
Goals & Mid-Point Milestone
Goals

[ ] Week 1 : Identify ways to resolve Trust Registry of a Issuer/ Verifier
[ ] Week 2 : Create Mock Data for existing Trust Registry as per this issue
[ ] Week 3 : Configure & Integrate with CREDEBL Trust Registry
[ ] Week 4 : Resolve other Trust Registries in Issuance process
[ ] Week 5 : Resolve other Trust Registries in Verification process

Setup/Installation
CREDEBL platform installation guide is given here
Trust Registry work is as per this issue
Expected Outcome
Platform should be able to resolve Issuer and Verifier from the respective Trust Registries compliant with Trust Registry Specification
Acceptance Criteria
No response
Implementation Details
Must have experience with NodeJS with NestJS framework
Mockups/Wireframes
No response
Product Name
CREDEBL platform
Organisation Name
Blockster Labs (CREDEBL)
Domain
Identity & Digital Credentialing
Tech Skills Needed
ESLint, NestJS, OAuth, RESTful APIs
Mentor(s)
@tipusinghaw
@ankita-p17
@jacquesvb71
Category
API, Backend, Breaking Change, Research, Other

@ankita-p17  can we use Next.js with Node.js  and other open source library for the security purpose and ease to development ?

@ankita-p17 can we use Next.js with Node.js and other open source library for the security purpose and ease to development ?

Hi @jayesh9747 CREDEBL platform is build using NestJS framework. This feature is to add support to resolve Trust Registries in existing Issuance and Verification Process.

@ankita-p17 I have started working on the issue Trust Registry Implementation including Registry of Registries l have outlied how i want to approach to the issue as a comment on the issue ticket would love you feeback on it

Do not ask process related questions about how to apply and who to contact in the above ticket. The only questions allowed are about technical aspects of the project itself. If you want help with the process, you can refer instructions listed on Unstop and any further queries can be taken up on our Discord channel titled DMP queries. Here's a Video Tutorial on how to submit a proposal for a project.

@ankita-p17 , I started deploying the application locally, but the local deploy requires a twilio sendgrid API key, but to obtain that, we are required to enter company details and bogus details are not accepted, is there by any chance you have test API keys for the .env file?


Cannot setup mails on docker

Hello, i can't setup mails on docker
version: '3.1'
services:
  ghost:
    image: 'ghost:latest'
    restart: always
    ports:
      - '4574:2368'
    environment:
      database__client: mysql
      database__connection__host: db
      database__connection__user: root
      database__connection__password: 'XXXXXXX'
      database__connection__database: ghost
      url: 'XXXXXXX'
      mail__transport: SMTP
      mail__options__host: ssl0.ovh.net
      mail__options__port: 465
      mail__options__secureConnection: true
      mail__options__auth__user: XXXXXXX
      mail__options__auth__pass: XXXXXXX
      mail__from: XXXXXXX
  db:
    image: 'mysql:8.0'
    restart: always
    environment:
      MYSQL_ROOT_PASSWORD: XXXXXXX

The ghost app container does not seems to get the mail config either

Here is the message i get on Ghost itself

Thanks for the help, tell me if you need more infos about this 👍🏼

It seems that it is working anyway but still not writing the config in the json and displays the error message anyway.

I can assure you that this is not an issue with this docker container. The default config is not set to send mails. You should refer to https://ghost.org/docs/config/

The environment variables you've specified are read by Ghost's code directly -- there's not anything in the image or Ghost that will auto-update the JSON files with those values.


Linting

Files re-formatted with prettier. No other changes.

Is this applied to all files? Don't we want to make it automatic for every commit?

@rastislav-chynoransky Prettier is typically used to format your code when you save a file so that you don't have to worry about formatting while working. For me, not having to worry about spaces, newlines etc while writing code is the main benefit; having all files neat and tidy is secondary.
I've considered doing a 'format all' commit but decided against it in the end (it would obscure some of our commit history and the benefit is... 🤷♂). But I'd be happy to do it if you guys are up for it.
In this particular PR I wanted to separate the re-formatting from the changes in other PRs, just so that they're easier to digest.
BTW, I'm sorry I never explained the inclusion of Prettier to you. I don't know how familiar are you with it and how much do you use auto-formatting in your IDE. For me, "format on save" has been a great time saver, so I highly recommend that setup :) https://prettier.io/

Thanks for the explanation. I haven't noticed it being pre-configured for the project. I'll be happy to use it.
However when I want to enable it in vscode for modifications only it fails with error. Have you had the same issue?

@rastislav-chynoransky

However when I want to enable it in vscode for modifications only it fails with error. Have you had the same issue?

I haven't had much success with formatting "modifications only" in general. Maybe the Output view will give you some hints:

If the re-format is too big a change, there's always the "save without formatting" option.


Strategy for DCA config managment

Per #320

Longer term/TBD: Have separate issue for automating config generation via CI after JSON generation? Or, at least run a check to compare DIFF between JSON and config without pushing any changes

@aclayton555 I'm happy we can close this during our next sprint review or kick-off


Question: X axis at top of chart?

Is it possible to have the X axis at top of the chart instead of the bottom? I couldn't find any option for it nor any discussion on it.

In D3.js the x axis has an attribute ' .attr("transform", "translate(0," + height + ")") '. If we don't add this line x-axis will be on top of the chart. Something similar to this should be available in C3 too.

d3.select('c3-axis-x').attr("transform", "") works to get the axis on top. But when new data comes in using  the load function the transform is reset. What's the best option to keep this permanent?

Is there a solution for this problem?
So far changing the attribute seems to work, but it doesn't feel good ;)

@af-sko I think I used the y2 axis as x and rotated ...


Make auto scaling backward compatible

So service owners  can still use launch config without enabling auto scaling to launch new instances.
Also add batch attach instance function.
@yujunglo @nickdechant @sbaogang

r+!


Priority Queues using Max heap

Hii  @tarun26091999 , I want to add Priority Queues using Max Heap in the Algo-Tree.
I am good with c++ data structures.
Kindly assign this issue to me under GSSOC'21 ,so i can also contribute to open source.
Looking forward for the positive response.

hello @tarun26091999 @rudrakshi99 can i work on this issue in python?
Thank you!

Hi, I am a GSSOC'21 participant, I would like to contribute to this issue.
I will use c++ as mentioned,
Kindly assign this to me.
@plazzy99 , @rudrakshi99..


unit test coverage from dependent modules is not showing up on Coveralls

I have a lumen application with several dependency modules for which I am trying to generate unit test coverage. My phpunit.xml includes all these dependent modules from the vendor folder added to whitelist (I just replaced the company name and repo name with * and +, but otherwise, this is how the filter section in my phpunit.xml looks like.
<filter>
  <whitelist processUncoveredFilesFromWhitelist="true">
    <directory suffix=".php">./vendor/****/++++/src</directory>
    <directory suffix=".php">./vendor/****/++++/src</directory>
    <directory suffix=".php">./vendor/****/++++/src</directory>
 </whitelist>
</filter>

The tests are run on dockerized environment on Travis-CI. Here is how .coveralls.yml at me project root looks like (again masking the repo token from the coveralls project repository)
service_name: travis-ci
repo_token: ******
coverage_clover: build/logs/clover.xml
json_path: build/logs/coveralls-upload.json

I am running multiple testsuites in during my build process, so using phpunit/phpcov module to merge the coverage report generated from these different testsuites. Here is the snippet from .travis.yml that I am using to run testsuites.
script:
- docker exec -it $(docker-compose ps -q fpm) sh -c "vendor/bin/phpunit --testsuite=functional1 --coverage-php build/cov/clover1.cov"
- docker exec -it $(docker-compose ps -q fpm) sh -c "vendor/bin/phpunit --testsuite=functional2 --coverage-php build/cov/clover2.cov"

- docker exec -it $(docker-compose ps -q fpm) sh -c "php vendor/bin/phpcov merge --clover build/logs/clover.xml build/cov"

after_success:
- travis_retry docker exec -it $(docker-compose ps -q fpm) sh -c "php vendor/bin/coveralls -v --coverage_clover=build/logs/clover.xml"

In the travis build log, I can see the coverage for all the folders included in the phpunit.xml whitelist filter. Here is the screenshot of the same

But when I see coveralls dashboard, it is not displaying the coverage for the vendor folders. What is missing here?

php-coveralls is an app that pass your coverage report to CoverAlls service. That's all, no logic about how to handle coverage is hidden in this app.
Following issue could have one of following 2 reasons:

code coverage report is not including following folders, then you must adjust how you generate reports
code coverage report is including those folders, yet CoverAlls is not displaying it as covered, then report issue to CoverAlls service

on a side note, I would strongly recomment to not rely/measure code coverage of 3rd party code, it's not yours, you should not measure it and show as your own code coverage statistics

Thank you, I will raise an issue with coveralls. Just fyi, these are not third party modules that I am trying to measure the coverage. These are my own project related modules.

I was mislead by vendor dir, which is usually for external packages...


Disable background color and suppress warnings

Makes sense. Thanks!

Yes, thank you very much. This weekend I will try to find time to merge this (and other pull requests)


This is working with unity3d?

Unity3d use .net 3.5.

I haven't yet tested with Unity3D, but this will work with net35.
Its on my list to verify with unity.
On Tue, Jan 19, 2016 at 3:26 PM -0800, "Lailore"<EMAIL_ADDRESS>wrote:
Unity3d use net 35

Reply to this email directly or view it on GitHub:
https://github.com/evolutional/flatbuffers-net/issues/52


Implement BigDecimal

This PR adds a BigDecimal implementation.
The motivation for having BigDecimals is to have an arbitrary precision exact decimal type. This is required at least in financial calculations, where the precision of Floats and is not enough and BigRationals may have other problems due to denominator potentially being something else than 10**x. At least Ruby, Python and Java contain something like this in their standard libs.
The design is mostly adapted from bigdecimal-rs written for Rust. It holds its actual value in a BigInt, and a scale (decimal point place) in UInt64. It currently contains basic + - * / arithmetics. Possible future needs: implementation of ** (power) and supporting scientific "123E45" notation.
Please critique liberally. This would be my first larger Crystal contribution.

LGTM

Looks like You forgot about
struct BigDecimal
  # Returns *num*. Useful for generic code that does `T.new(...)` with `T`
  # being a `Number`.
  def self.new(num : BigDecimal)
    num
  end

Some info here: #2292.

@akzhan Thanks, added that.

@vegai Can you apply @RX14 proposed parser and remove duplicated it as @mverzilli proposed?

Yeah, as soon as you apply that we're ready to merge

Ah, yes. I'll do that today, i.e. during the next 24h.

Changes made & rebased to single commit.

Thanks @vegai ! Couple of things:

I still don't see a test for <= (https://github.com/crystal-lang/crystal/pull/4876#discussion_r137932485), is that on purpose or maybe you missed that comment?

Next time, would you mind not squashing while we're at the middle of a review? For big PRs like this one it forces reviewers to re-read the whole diff instead of just focusing on the parts that change. We can always squash at the moment of merging if it makes sense.

Looks like CircleCI build failed due to LLVM 5.0, your branch based on too old master (that doesn't support LLVM 5.0 some days ago).

@mverzilli Yes, I indeed missed that. Will add. Sorry about silly rebasing, will contain myself a bit better in the future.
@akzhan rebased from upstream's master.

@RX14 you had already approved but then requested some changes. This LGTM now, so feel free to merge once it's good for you.

But where is def hash(hasher)?

@akzhan Ah, right. I'm on it.

To clarify:
hash is currently not implemented. Although there is the default Struct Hash implementation, it just combines hashes of member variables.
You really want to ensure this invariant for your type: if a==b then a.hash==b.hash
Looking at the equality method, that is NOT currently ensured because it is possible for two bigdecimals with different members in to be equal.

@oprypin it's yet another "Number Normalization" issue was proposed by me and @funny-falcon a time ago.
Looks like I push it until 5 January :)

Added some more tests. Changed to_s slightly so that it factors powers of ten away before outputting (so "1.00" will output 1). Made hasher use to_s and wrote some tests for that too -- one test specially trying out the a==b <=> h[a]==h[b] case.

Does this PR not have any to_i/to_u/to_f impls? I think that "copping out" by going via string for any conversions in this PR is wrong.

Java's BigDecimal impl is very interesting. It too goes via String for float and double. For int and long it uses a method called setScale to set the scale to 0, and then simply converts the BigInt to an integer.

Added to_f/u/i implementations and a few specs. to_f goes via to_s while to_u and _i scale up a bit like Java's implementation.

Should this PR be in the "Numbers" project?

Thank you! 🎉

Thank you @vegai! Amazing work, and outstanding patience to bear with reviews :)

This PR added src/big_decimal.cr which got obsolete because of #5121.

btw, why BigDecimal doesn't inherit from Number?

@oprypin Done - #5276


Question: How can fill properly the JFXlistView with a fxml file using SceneBuilder ?

Hi,
I copy/past this in my own file:
<JFXListView fx:id="list1" styleClass="custom-jfx-list-view"
			layoutX="0" layoutY="50">
			Item 1
			<JFXListView fx:id="subList" styleClass="sublist">
				<groupnode>
					 My Sub List
				</groupnode>
				 Buttons
				 Check Box
			</JFXListView>
			Item 2
			Item 3
			Item 4
			<JFXListView fx:id="subList1" styleClass="sublist">
				<groupnode>
					 My Sub List
				</groupnode>
				 Buttons
				 Check Box
			</JFXListView>
			Item 6
			Item 7
			Item 8
		</JFXListView>

Directly in the fxml file ... that works but it's really bad I guess.
Someone can help me on this subject.
Create items and groupenode. Even on internet I don't find any information about it :/
Thank you

please note that not all controls are compatible with scene builder, it needs some customization from the scene builder side in order for it to work properly. feel free to open a request in the scene builder bitbucket repository
https://bitbucket.org/gluon-oss/scenebuilder

Thank you ;)


YML for running builds through WinUI tests & updating CsWinRT dependency

This PR adds a YML file to our main CI pipeline. The new stage has a task that only runs on nightly builds, and a task that only runs on (public) release builds. The task for nightly builds will trigger a WinUI CI pipeline and pass the CsWinRT preview NuPkg so that the WinUI tests run using the latest preview of CsWinRT. The other task, that runs on release builds of CsWinRT, triggers a WinUI pipeline which updates the CsWinRT version used in the WinUI repo.

WinUI PR to fix the script: https://microsoft.visualstudio.com/DefaultCollection/WinUI/_git/microsoft-ui-xaml-lift/pullrequest/7205661


Incorrect Groupings Not Resetting dropdown

If you try to put in an invalid grouping, it doesn't reset to the default option, so to try again you must manually switch it and then switch it back to get it to try again.

fixed in 6fd2889


Songs don't scrobble

I'm using mopidy-gmusic from the current development branch together with mopidy-scrobbler. The scrobbler works for local files but not for tracks played through mopidy-gmusic.
As the scrobbler is correctly transmitting the "Now playing" information, I would guess this is a problem on the gmusic side. Maybe it doesn't properly tell when a song has been fully played?

Also mentioned at https://github.com/mopidy/mopidy-scrobbler/issues/6

Fixed in develop branch, will be part of upcoming 1.0.0 release.


Testnet Insight API returning wrong payloads

When querying https://testnet-insight.dashevo.org/insight-api/blocks?limit=1, we are sometimes getting a payload with no blocks. This is breaking for us. Such as the one below
{
  "blocks": [],
  "length": 0,
  "pagination": {
    "current": "2021-11-24",
    "currentTs":<PHONE_NUMBER>,
    "isToday": true,
    "more": false,
    "next": "2021-11-25",
    "prev": "2021-11-23"
  }
}

Perhaps related is the fact that https://testnet-insight.dashevo.org/insight-api/status often returns a payload where the blocks value is a number that is far behind.
{
  "info": {
    "blocks": 616345,
    "connections": 11,
    "difficulty": 0.002247077821617921,
    "errors": "Warning: unknown new rules activated (versionbit 3)",
    "insightversion": "3.1.1",
    "network": "testnet",
    "protocolversion": 70219,
    "relayfee": 1.0e-5,
    "timeoffset": -1,
    "version": 170003
  }
}

We got this response on Wed, 24 Nov 2021 09:53:38 GMT, a time where the actual tip of the DASH testnet was 618900.
We were only able to reproduce this through programmatic calls. On the browser we always get the right response.
Are we somehow getting answers from a node that is stuck?

Issue has started happening again.


RHIDP-1811 Update 1.1 release notes for fixes in 1.1.1

Let's also merge https://github.com/redhat-developer/red-hat-developers-documentation-rhdh/pull/133 at the same time.


Front page example queries cause JS error

Clicking any of the example queries on the front page will cause a JS error alert and leave that section grayed out and "loading".

Fixed on dev.

Fixed in hotfix 1.12.5


Where do I find the forecasts after update to the current version?

Version of home_assistant
2023.9.2
Where do I find the forecasts after update to the current version?

I have the same problem with Home Assistants 'Custom Weather Card'. It doesn't work any more, because the forecast attribute is missing.

Unfortunately it had to be removed due to changes in HA: Forecast Attribute
I primarily suggest, that you inform the developer of your custom card to adapt as well. However I could provide the forecast as a separate sensor if requested.

The forecast attribute was a very useful feature for me.
I've used this by the following code:
template:
  - sensor:
      - name: "Temperatur DWD Waltrop Heute Min"
        unique_id: temperatur_dwd_waltrop_forecast_0_temp_min
        state: "{{state_attr('weather.waltrop_abdinghof','forecast')[0]['templow'] | float(0) }}"
        unit_of_measurement: "°C"
        device_class: temperature

Could anybody supply a code example, how to get current day's min and max expected temperature from DWD prediction?
Greetings
Heiko

`template:

trigger:

platform: time_pattern
hours: "/1"
platform: homeassistant
event: start
platform: event
event_type: event_template_reloaded
action:
service: weather.get_forecast
data:
type: daily
target:
entity_id: weather.salzuflen_bad_salzuflen_bad
response_variable: forecast
sensor:
name: wetter_temp_vorhersage_heute_max
unique_id: wetter_temp_vorhersage_heute_max
state: "{{ forecast.forecast[0].temperature}}"
unit_of_measurement: "°C"
name: wetter_temp_vorhersage_heute_min
unique_id: wetter_temp_vorhersage_heute_min
state: "{{ forecast.forecast[0].templow}}"
unit_of_measurement: "°C"`

Thanks a lot. That works!
Here, you can find the code:
template:
    - trigger:
          - platform: time_pattern
            hours: "/1"
          - platform: homeassistant
            event: start
          - platform: event
            event_type: event_template_reloaded
        action:
          - service: weather.get_forecast
            data:
              type: daily
            target:
              entity_id: weather.dwd_waltrop_abdinghof
            response_variable: forecast
        sensor:
          - name: "DWD Waltrop-Abdinghof Vorhersage Heute Max"
            unique_id: dwd_waltrop_abdinghof_forecast_today_max
            state: "{{ forecast.forecast[0].temperature}}"
            unit_of_measurement: "°C"
          - name: "DWD Waltrop-Abdinghof Vorhersage Heute Min"
            unique_id: dwd_waltrop_abdinghof_forecast_today_min
            state: "{{ forecast.forecast[0].templow}}"
            unit_of_measurement: "°C"

Greetings,
Heiko


Update outdated reference

See https://getkong.org/docs/0.9.x/plugin-development/distribution/
It references the old Yaml configuration format.

fixed by https://github.com/Mashape/getkong.org/commit/f50446a16038be142d8dd0632d3ff4bd83f4f783


Make connection types more flexible?

Background:
I am refactoring my code to use this crate with the elasticsearch crate.
Currently, I am using juniper and since they do not support the relay cursor connection spec, I have defined code to translate an elasticsearch search response to a graphql connection object, but with extra elasticsearch information:
#[derive(Deserialize, Debug)]
struct Hits<T> {
    #[serde(default)]
    page_size: usize,

    #[serde(default)]
    took: Duration,

    #[serde(default)]
    timed_out: bool,

    #[serde(default, rename = "total")]
    total_count: Count,

    #[serde(default)]
    max_score: Option<f32>,

    #[serde(default = "Vec::new", rename = "hits")]
    edges: Vec<Hit<T>>,
}

#[derive(Deserialize, Debug)]
struct Hit<T> {
    #[serde(default)]
    sort: InnerCursor,

    #[serde(rename = "_version")]
    version: Option<u64>,

    #[serde(rename = "_seq_no")]
    sequence_number: Option<u64>,

    #[serde(rename = "_primary_term")]
    primary_term: Option<u64>,

    #[serde(rename = "_score")]
    score: Option<f32>,

    #[serde(default)]
    highlight: HashMap<String, Vec<String>>,

    #[serde(rename = "_id")]
    id: String,

    #[serde(rename = "_index")]
    index: String,

    #[serde(rename = "_source")]
    node: T,
}

And then I use a proc-macro (not ideal) to use #[async_graphql::Object] and convert a Hits to a *Connection and a Hit to an *Edge, using the sort field from elasticsearch to create a cursor etc.
My questions are:

Would it be possible to update the built in Connection object type to add custom fields like highlight, sequence_number etc? Maybe via a trait (maybe more ideal?) or add a generic field extra_info or something (less ideal?)?
If not, is there a way to get around the fact that graphql types ending in Connection and Edge are reserved so that I can keep my current code without having to rename them?

We fully support the features you mentioned, but unfortunately, we are modifying the API of Relay Connection, because the old version is not easy to use in many places. The new API will be released in a few hours, we need to update the document. Then I will show you how to add additional fields to Edge. 😁

Adding additional fields to Connection is not yet supported, and I am adding this feature.

I released version 1.14.0, and both Connection and Edge were able to extend the fields, which depended on the new DataSource implementation, so this is a breaking change again. 😂


Recommendation:  Add a segment that outlines the ability to test your Skype Room System V2 account once it is created.

There's a lot of great documentation on the creation of the account, but how does one "proof" the account once it is created. If the account is created 3-4 weeks before hardware installation, as recommended, then where can one go to use the account and account credentials to fully verify is works as required?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 41965bc8-45c0-e4eb-aa36-5ef5adbe460a
Version Independent ID: 97de65ad-04fc-5b62-c7c7-fba8d0aeb1de
Content: Deploy Skype Room Systems v2 with Office 365
Content Source: Skype/SfbServer/deploy/deploy-clients/with-office-365.md
Product: skype-for-business-itpro
GitHub Login: @jambirk
Microsoft Alias: jambirk

I've added an initial section to the file, the essence is you should be able to test a device account with any of the standard clients (that's also the case with Skype for Business on Surface Hub) as the SRS v2 is essentially a specialized SfB client.
If this doesn't satisfy your issue, please let us know.


Does not work

Nothing happens when I start, I tried it several times on a clean installation of Python 3.9.0

Hi, this project was made for educational purpose only, and i suggest directly using EasyOCR which this project wraps.
However if you would still like to use it, i fixed it by adding modifying the app.py file to include:
 if __name__ == "__main__":     app.run(debug=True)
This change ensures that the app runs when the script is executed.


Un-blur update popup for chromium browsers

Just see before and after.

✅ Ready to merge

I have found some contrast issues, I don't know if I should fix them or not:

Light theme, change theme button:

Dark theme, "Communauté" tab:

The white on dark-blue should be less contrasted (It's my personnal feeling)

I also noticed that the screenshots are not in a good quality (little image size, jpeg image format used)


Link direct from ezEML to portal's preview EML?

This would be an incredibly useful feature. Now one needs to download EML from ezEML, go to portal, click on tools/preview, navigate to EML file, click to preview. Imagine if there was a 'preview EML' on the left sidebar of ezEML that would take you to a preview in one click....

Just a note: this would entail configuring ezEML servers with the CSS, etc. as expected by the preview pages so the pages can be rendered on the ezEML server. Not impossible, of course, but it will take a little doing.

That sounds way more involved than what I was imagining when I posted. I thought there might be a way to pass that xml to the existing previewer on portal and maybe open in a new tab. If that sort of solution doesn't exist, you probably have more important things to work on.
Mary
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Jon Ide @.>
Sent: Tuesday, October 31, 2023 6:21:07 PM
To: PASTAplus/ezEML @.>
Cc: hubbardbrook @.>; Author @.>
Subject: Re: [PASTAplus/ezEML] Link direct from ezEML to portal's preview EML? (Issue #123)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
CAUTION: This email originated from outside of the University System. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Just a note: this would entail configuring ezEML servers with the CSS, etc. as expected by the preview pages so the pages can be rendered on the ezEML server. Not impossible, of course, but it will take a little doing.
—
Reply to this email directly, view it on GitHubhttps://github.com/PASTAplus/ezEML/issues/123#issuecomment-1788052989, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AYPZWLK5XJ7J4DLTBJK42FLYCFTUHAVCNFSM6AAAAAA54SAJLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYGA2TEOJYHE.
You are receiving this because you authored the thread.Message ID: @.***>

Roger Dahl came up with an elegant way to implement this. Added in release 2023.11.08.


Create test.py

test

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

感谢您提出的宝贵问题，我们有7x24小时服务的“HaaS百事通”客服系统，
您可以先尝试能否解决您的问题(https://haas.iot.aliyun.com/?ask=1&f=a2cre.b82925042)

如果“HaaS百事通”没有解决您的问题，请回复“人工支持”，我们会在工作日(10:00-12:00/14:00-18:00)10分钟内回复您。

This issue has not been updated for a while, so we close this issue.  If you have further request, please reopen it or add it.  We will response as soon as possible.
本issue因太久未更新而关闭，如果您还有进一步的问题，请reopen本issue，或者新开一个issue，我们会尽快回复您。


[FAI-6768] Add destination packaging test to ci.yml

Description
Issues like the one which happened when we bumped Commander package which had to be reverted might be able to be caught before merging by attempting the destination packaging within our CI workflow

I think we should create a new job and invoke it on PRs only.

The new step is failing with:
npm ERR! notarget No matching version found for<EMAIL_ADDRESS>


[Bug] Cannot execute CTRL+P or CTRL+(SHIFT)+TAB

Describe the bug
I cannot get CTRL+P (Markdown preview), nor CTRL+TAB (switch tabs) to work
To Reproduce

Open  file
Type some markdown text
Press CTRL+P to show markdown preview
Open second tab
Press CTRL+TAB to switch tabs

Expected behavior

Markdown preview opens
Tabs are switched

Desktop (please complete the following information):

OS: [Windows 10 1903 18362.295]
Version [v<IP_ADDRESS> Beta]

Additional context
Downloaded from Microsoft Store

What kind of file did you opened, is it .md file?

Didn't realize markdown only worked in .md file.


Nidoran Male/Female conventional names don't work

Only nidoran-m and nidoran-f work

Related to the fact that they're usually depicted with non-alphabetic characters in their names
https://pokemondb.net/pokebase/294054/which-pokemon-characters-other-standard-alphabet-english

Also their names don't display correctly, as well as some others in the above list


Call to a member function format() on bool

good day,
i set up my project just as described in the guide. problem is that the plugin works great on my local machine (hosted with laravel valet) but not on my remote host (namecheap shared hosting).
it just gives me the error message: Call to a member function format() on bool
in debug mode nothing more useful gets written to the console as well.
does the server have to fulfill any special requirements ? i also checked the git-php lib but couldnt find any.
best,
elias

found the solution was to set the gitBin option to the specific path of namecheap shared hosting
/usr/local/cpanel/3rdparty/bin/git


add text2voice action to catalog

We could use as an example the Watson API

@csantanapr , I updated the catalog.md for this issue and created a pull request. Is it necessary?

Hi @lzbj Thanks for the contribution, but the docs are ready in https://github.com/IBM-Bluemix/docs/pull/169
The content just needs to be sync with the content in this repo.

@csantanapr , Ok, thanks.

@csantanapr , sorry if bother you, we also have a documentation for the SpeechToText action already, right?

@jasonpet-ibm is working on the speechtotext docs already

thank you.

Closing this one since implementation and docs are merged now in this repo for text2speech
Tracking speech2text in another issue #510


kill villager, didn't kill before

also made it so that you get sent text if you don't have right item and right click villager

I was not expecting any PR on this project lmao, it's just a very small project I've made for a friend in a few days but it's cool to see someone interested on it
Thanks for fixing these small issues

Eh, a bunch of party gamers practice with both your plugins
Also, I'm making a multiplayer supported jigsaw rush using your plugin too

Oh that cool I didn't know that, good luck with the multiplayer support


~\dub\packages\ae\0.0.2845\ae\utils\iconv.d(111,29): Error: Bidirectional control characters are disallowed for security reasons.

I get this error message when I try to "dub build" in the directory for your cloned repo. This happens in both Windows and Linux. Am I doing something wrong or is the code too old to be built successfully now? Thanks.

Yes, the code is old, but you should still be able to use an older version of D to build it.


Explanation of Status terminology

Please provide some explanation about how the various status options should be used and how they affect the score.
To Address and Planned seem like the same thing to me, so I"m not sure when to choose one or the other.
Also, Resolved through 3rd Party and Resolved through alternate mitigation seem like the same thing, so I'm not sure when to use each of those.
The text states that we can Ignore an item, but Ignore is not a status choice.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bfcc3d22-db50-3c7a-a6b8-b9740a34920c
Version Independent ID: d283a2fc-92fc-ab0e-5a7d-b92248213d2e
Content: What is identity secure score? - Azure Active Directory
Content Source: articles/active-directory/fundamentals/identity-secure-score.md
Service: active-directory
Sub-service: fundamentals
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@DeanGross
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Note out to PG for detail


kola/gce: shrink hostname to be lower than 63 char

GCP Pro is failing because hostname is > 63 char:
Apr  5 19:52:27.522820 kubelet[1762]: E0405 19:52:27.522513    1762 kubelet_node_status.go:93] "Unable to register node with API server" err="Node \"jenkins-gce-pro-5-91a967ef5450cb932bc5.c.flatcar-212911.internal\" is invalid: metadata.labels: Invalid value: \"jenkins-gce-pro-5-91a967ef5450cb932bc5.c.flatcar-212911.internal\": must be no more than 63 characters" node="jenkins-gce-pro-5-91a967ef5450cb932bc5.c.flatcar-212911.internal"

Let's remove jenkins and gce from the hostname, these
information are not critical for debugging purposes.
Hostname should now looks like
"basic-5-91a967ef5450cb932bc5.c.flatcar-212911.internal" or
"pro-5-91a967ef5450cb932bc5.c.flatcar-212911.internal"
Signed-off-by: Mathieu Tortuyaux<EMAIL_ADDRESS>
No changelog required.

[ ] CI: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/5361/cldsv/

@flatcar-linux/flatcar-maintainers CI passed on gce / gce_pro.

cherry-picked to:

flatcar-lts-2605
flatcar-3139
flatcar-3185
flatcar-3200


Added additional functions:

truncate - truncates to given string length
truncate_words - truncates to given words count
truncate_sentences - truncated to given sentence count
truncate_html - truncates to given length preserving the html
truncate_html_words - truncates to given word count preserving the html
truncate_html_sentences - truncate to given sentence count preserving the html
count_words - counts words in a string
count_sentences - counts sentences in a string

Pull Request Test Coverage Report for Build 64

82 of 82 (100.0%) changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 60:
0.0%

Covered Lines:
438

Relevant Lines:
438

💛  - Coveralls


Better About Page(s)

About PD needs to be something like –
Penny Dreadful is
AN ULTRA-BUDGET MAGIC ONLINE FORMAT
WITH MORE THAN 10,000 LEGAL CARDS
INCLUDING HYPERGENESIS, CHAIN LIGHTNING AND CRUEL ULTIMATUM
WITH FOUR WEEKLY TOURNAMENTS
    Prizes

A 24/7 LEAGUE COMPETITION
    Current League
    etc.

SUPPORT ON MAJOR SITES
    Scryfall
    Magidex
    etc.

A LIVELY AND FRIENDLY COMMUNITY
    Discord

    Subreddit

What are you waiting for?
Discord

League

How to Get a Game

Getting Started with Magic Online

Is this for pdmtgo.com?

We have /about/ right now that does a little sales job on pd. I was gonna spruce it up. If we worked up something great I could see us putting it on the front of pdmtgo.com or ... something. Not quite sure how to reconcile the two sites even if we were given control of both. I guess have one become a non-canonical alias for the other eventually??

#1605, which I'm going to close, is one idea.

We have /about/ and /about/pd/ and the intro box now. We are all good.


allow newer clients to talk to older tiller instances

See discussion in #1523
Closes #4547

So here's the deal with our relatively constrained version compatibility system: When we start getting different Kubernetes core libraries involved in the same validation/installation logic, things can get weird.
As we all well know, every single version of Kubernetes breaks compatibility with the previous version. Core APIs change, but so does validation logic, names of resources, apis, versions, and kinds, and all sorts of seemingly arbitrary bits of logic.
To protect ourselves from having disagreements between client and server as to what is "valid", we have forced client and server to have both the same major and minor version number.
We are 💯 sure, for example, that the "core" of Helm (gRPC, message formats, templates) are backward compatible. They are not forward compatible, though. It is possible that an additive change, which is allowed by SemVer on minor increment, could "pass" on the client and fail on the server. (Example: New template function, or the introduction of CRD support in 2.10)
So the nuanced answer is:

We could allow cross-talk if the client's minor is >= Tillers, and that would be somewhat risky
We could require only a major version match, and that would be substantially risky
We could allow a client/Tiller minor version distance of, say, 2 (one must be within two minor releases of the other, in either direction), and that would be somewhat risky

Keep in mind that the result of removing the requirement introduces a substantial stability risk, and introduces combinatoric complexity to Helm environments. All of this will directly translate to support issues of the form "X is not working, and I'm running client version P and server version Q."
If we want to accept the liability (increased workload, diminished stability), we can do that. I would prefer, though, to at least emit a warning if the versions are different. Then it will show up in logs.

/cc @ultimateboy

We support older clients talking to newer versions of tiller, which is part of that backwards-compatible guarantees we make. The template function change/CRD support cases are very valid cases, so thank you for demonstrating an example that shows why we cannot support this.
I'm in favour of closing this out and not fixing this issue given that we have not made any guarantees towards maintaining forwards-compatibility.

Still an issue here, I am new to helm and ran straight into that:
Error: incompatible versions client[v2.10.0] server[v2.9.1]
Error: incompatible versions client[v2.10.0] server[v2.9.1]

This is definitely a big issue. A minor version should allow a newer client to interact with an older server.
I reckon everybody here is a sensible developer, but the current state of the cli does not follow sensible rules of software development. Backwards compatibility could be taken a little bit more seriously.

And I am going to explain my pain further:
So I have a small task to do, install a "chart" onto the cluster.
Ok, I need to downgrade my local version to match the major.minor version of whatever is running in my clients cluster.
I cannot (yet) upgrade the server, since I have not throughly checked the changes and I would probably need to force all my colleagues to upgrade their toolchain (maybe, because as I read you have compatibility the other way round figured out).
So I thought, hej, lets just drop the binary into its own folder and symlink the version that should be active.
And turns out the binary cannot execute if it symlinked or at least if it is not the same as in $PATH.
$ helm init
-bash: /usr/local/bin/helm: cannot execute binary file: Exec format error
$ readlink /usr/local/bin/helm
/usr/local/lib/helm/2.9.1/bin/helm
$ which helm
/usr/local/bin/helm
$ /usr/local/lib/helm/2.9.1/bin/helm

Regardless of the lengthy explanation, more care should be taking in favor of compatibility.

I can't help but feel pretty upset about this comment. Backwards compatibility is taken very seriously in Helm, which is why older versions of the client can talk to newer instances of Tiller. We take great care in ensuring that the client APIs are fully backwards compatible. You could've written a Javascript GRPC client library to interact with Tiller in Helm 2.0.0 and it would still work today.
What @technosophos is pointing out boils down to the fact that Kubernetes makes breaking API changes every minor release, and we cannot control that. The core message to take away from this is loosening the restriction means we can no longer always guarantee compatibility. If that is acceptable to the community (which I highly doubt), then we can loosen the restriction.
We can only begin to guarantee forwards compatibility once Kubernetes stops breaking core APIs.

I can't help but feel pretty upset about this comment.

Sorry, didn't mean to upset you. Forgive my ignorance.

Backwards compatibility is taken very seriously in Helm, which is why older versions of the client can talk to newer instances of Tiller.

That is what I might need to learn to accept, my expectation is the other way around.


PRNG + LCG chapters

This is a draft PR for the next set of chapters. It will include the following:

[ ] An intro to RNG

[ ] a discussion of where RNG is used in different fields
[ ] quick histogram check to see how random your RNG is

[ ] Diehard tests

[ ] Birthday spacings
[ ] Overlapping permutations
[ ] Ranks of matrices
[ ] Monkey tests
[ ] Count the 1s
[ ] Parking lot test
[ ] Minimum distance test
[ ] Random spheres test
[ ] The squeeze test
[ ] Overlapping sums test
[ ] Runs test
[ ] The craps test

[ ] Linear Congruential Generators

[ ] Explain why they might be used in CG applications / GPU kernels (due to other RNG methods being cumbersome)

Might be biting off a bit too much, but I've been wanting to do diehard tests forever now and it'll be fun creating the testsuite.

Idea: add Linear-Feedback Shift Registers as a (cheap) hardware PRNG, although it can be quite weak as a PRNG


Add valtimer warp teleport

The "dash" skill of valtimer will be a teleport to the destination instead of a dash
While the teleporting is occurring the player should not take damage
Implement the same for every dash and leap mechanic

What should happen if the player takes damage while teleporting?

What should happen if the player takes damage while teleporting?

We decided that the player should not take damage while teleporting since you wont be able to see you in the animation, we talked about this with @marco-paulucci


[Debian] Fails to load SDL version compile from source

If you compile SDL from source and install it SDL_ts fails to load the correct version always loading the version installed via apt.

This should be fixed with https://github.com/smack0007/SDL_ts/pull/39


Feature Request - PVC usage option instead of host storage

Use cases

Volatile environments where all nodes might be lost (like environments that use spot ec2 instances)
Environments that are only up for a few hours a day (like dev or qa)

Why would I still want to use longhorn in the situations instead of cloud provided solutions

Longhorn could allow me easily and cloud agnostically do ReadWriteMany (I could use EFS, but it's spendy for what it does and is not cloud agnostic)
If an availability zone (or equivalent) goes down I would be caught in a situation where some pods would not be able to start due to region contraints of EBS hardware.  This isn't a problem for most applications, but monolythic applications running on kubernetes (like jira, confluence, jenkins, or even minecraft) could experience significant downtime.

Thanks for humoring me!  I look forward to seeing what the future of this project holds.

Looking at the helm chart it looks like this would be easy to implement.  I will experiment around with this when I have time and see about putting in a PR if no one else beats me to it. 🙂

@unacceptable Longhorn's RWX is an upcoming feature and it won't be a full HA solution like EFS. Longhorn's main use case is still RWO.
Also, it's in fact not easy to implement local storage via PVC. The problem is Longhorn dynamically detects the disks (including available spaces etc), but Kubernetes cannot dynamically attach PVC to a running Pod. To make PVC useful similar to the way as host directory, we will need to create one pod per PVC, then somehow still allow Longhorn manager to know what's happened on the disk.
Of course, it's not impossible, but it will take some time to design and implement.

@yasker Thanks for replying back.
I understand the RWX is scheduled for the 1.1 release milestone (and I am super excited to get my hands on that when it's available).  I believe that this RWO functionality as I described it is possible via the helm chart today with some chart modifications (I just wouldn't be protected against an availability zone becoming unresponsive until 1.1).
Dynamic PVCs which could be attached to the pod would be able to be expanded if the storage class supports it: https://kubernetes.io/docs/concepts/storage/storage-classes/#allow-volume-expansion.
I am probably doing a terrible job of explaining my vision for using longhorn to meet some use cases that I have.  Maybe I could draw something up on draw.io/awwapp.io or attend an office hours after I work on this PoC a bit so that my intention becomes clearer.
Thanks for being patient with me and developing such a badass project.  Kubecon this year has been really enlightening on some things that I can implement in my team's architecture to make it more resilient.

I'd be very interested in this for basically the same reasons. Let EKS/EBS Controller manage attaching EBS, and get the nice replication and backup benefits of Longhorn as using EBS with StatefulSets makes node maintenance and upgrades a bear to manage.


Outdated information

In this page it's said that the user/kernel address space is 8TB/248TB

For a 64-bit process, the virtual address space is the 8-terabyte range 0x000'00000000 through 0x7FF'FFFFFFFF.
...
The 8-terabyte range from 0x000'00000000 through 0x7FF'FFFFFFFF is used for user space, and portions of the 248-terabyte range from 0xFFFF0800'00000000 through 0xFFFFFFFF'FFFFFFFF are used for system space.

However in Memory Limits for Windows and Windows Server Releases I see that since Windows 8.1 and Windows Server 2012 R2 the user/kernel address space has been changed to 128/128 TB

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ebe87d57-198f-66f4-69ff-6fdbc15eb214
Version Independent ID: 880a9327-3f4f-83eb-c0f7-030588344330
Content: Virtual address spaces - Windows drivers
Content Source: windows-driver-docs-pr/gettingstarted/virtual-address-spaces.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @EliotSeattle
Microsoft Alias: eliotgra

Thanks for the heads-up.  A fix will appear in the next few minutes.

@tedhudek It looks like there is additional out of date info on the page. Down midway under "User Space and System Space" there is a diagram and explanatory blurb that still reference the out of date 8TiB User address space, and 248TiB system address space.

Hi @BRabbit777 , I appreciate the feedback.  I went ahead and removed the sentence and diagram.
If you like, I'd encourage you to submit a pull request if there are particular points/links you'd like to see added to this page.  To do that, click the Edit button on the docs.microsoft.com page, and then click the pencil ("edit this file") icon on GitHub.  Happy to take a look at anything you think would be worthwhile.


[material-ui/system] Type declarations

I'm trying to use material-ui/system in a Typescript projects and none of the style functions or props in the package are typed. I know that the project is in alpha version right now, but it already looks great! I'd love to help add typings if there's a need in contributors. (I ended up scaffolding basic ones just so my project works)

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Package has type declarations.

Yes please! Can't wait to use it in typescript projects.

Yeah we've had to add a bunch of local types to our project (I'm new to TypeScript - don't judge! 😄):
type SystemProp = number | string | object

export interface BorderProps {
  border?: SystemProp
  borderTop?: SystemProp
  borderRight?: SystemProp
  borderBottom?: SystemProp
  borderLeft?: SystemProp
  borderColor?: SystemProp
  borderRadius?: SystemProp
}

export interface DisplayProps {
  display?: SystemProp
  displayPrint?: SystemProp
}

export interface FlexboxProps {
  flexDirection?: SystemProp
  flexWrap?: SystemProp
  justifyContent?: SystemProp
  alignItems?: SystemProp
  alignContent?: SystemProp
  order?: SystemProp
  flexGrow?: SystemProp
  flexShrink?: SystemProp
  alignSelf?: SystemProp
}

export interface PaletteProps {
  color?: SystemProp
  bgcolor?: SystemProp
}

export interface PositionsProps {
  zIndex?: SystemProp
  position?: SystemProp
  top?: SystemProp
  right?: SystemProp
  bottom?: SystemProp
  left?: SystemProp
}

export interface ShadowsProps {
  boxShadow?: SystemProp
}

export interface SizingProps {
  width?: SystemProp
  height?: SystemProp
  minWidth?: SystemProp
  minHeight?: SystemProp
  maxWidth?: SystemProp
  maxHeight?: SystemProp
}
export interface SpacingProps {
  m?: SystemProp
  mt?: SystemProp
  mr?: SystemProp
  mb?: SystemProp
  ml?: SystemProp
  mx?: SystemProp
  my?: SystemProp
  p?: SystemProp
  pt?: SystemProp
  pr?: SystemProp
  pb?: SystemProp
  pl?: SystemProp
  px?: SystemProp
  py?: SystemProp
}

export interface TypographyProps {
  textAlign?: SystemProp
  fontWeight?: SystemProp
  fontSize?: SystemProp
  fontFamily?: SystemProp
}

Accepting PRs if anybody wants to work on this. Since I haven't used it myself I think others should be more familiar with the API.
If anybody needs some inspiration they can look at how we organized the declarations and tests for it at ./packages/material-ui-styles. Important parts are located in the tsconfig.json, package.json and src/index.d.ts. PR should include tests i.e. ts files that include usage of the package.

I use @willbamford definitions as follow
const Box = styled('div')(compose(display,position)) as React.FunctionComponent<DisplayProps & PositionsProps>;

maybe not the best or even not correct way, but I don't know another way :-(

Added types with `#15357. The basic demos are also available in TypeScript to showcase usage of the types: https://deploy-preview-15357--material-ui.netlify.com/system/basics/
Since I never used styled-components with system-style functions I need some feedback to get those right.


[Feature] Add ExprRandomNumber

this expression allows, like that of skript (Minecraft), to generate an integer (Long) or a non-integer number
@Syst3ms told me that it would be even better to do 2 syntaxes and check which one is used in the init function, I will do it later (if i dont forget lol)
Edit: used function for generate random Number was implemented in java 7, see https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadLocalRandom.html

Thx to @Syst3ms for his help ^^


docs: document the release process and CI jobs

Background
We should document the release process to reduce cognitive overhead and ease onboarding.
Suggested Design
We should aim to have:

the sequence of steps
the automated CI jobs and links to them that we should run
the manual steps
team rules and guidelines

E.g. ask at least one person to review before publishing
do not @ for minor announcements in Discord

explanation of why we need each step

RELEASE.md file in the root of the repository.
Acceptance Criteria

RELEASE.md is created
all suggestions above are covered
The process is easy to follow for anyone not having done a release before

Documented this on Click Up


Add vector_euler_angles_from_quaternion

Closes #68
I'm a little out of my depth here, I just took an implementation from stackoverflow and vectorized it.
I added two tests to compensate for my lack of confidence. 🤣

I cannot judge the implementation itself, so I looked mostly at the tests (and nitpicks).
One way the tests could be improved is to also test the batch-usage. This has been broken for other functions in the past. We can leave the hypothesis tests for the individual usage, and add a simple test similar to this:
https://github.com/pygfx/pylinalg/blob/a6688b79d9a374677444c2337d60ee5b47f32ffd/tests/func/test_vectors.py#L12-L37

Sounds good, will do.

One way the tests could be improved is to also test the batch-usage. This has been broken for other functions in the past. We can leave the hypothesis tests for the individual usage, and add a simple test similar to [...]

Done!


New Contributor Made Changes

Hello, I am a new contributor to this and learning code for cause.
Thank you for providing such great valuable content on Youtube.

Thanks @CodyHarsh for your PR, Welcome to the coommunity.

Thanks @CodyHarsh for your PR, Welcome to the coommunity.


Charts contained in a widget are not displayed on WIDGET TESTS

Steps to Reproduce
We have screens/widgets that load some charts, example is with PieChart.
https://pub.dev/packages/charts_flutter
https://github.com/google/charts/blob/master/charts_flutter/lib/src/pie_chart.dart
When we run the app, the screens are loading fine.
When we created a widget test on one of our screens, the chart is not displayed
flutter run test/your_test.dart

flutter doctor:
/Users/user/Documents/Flutter/sdk/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, v1.7.8+hotfix.4, on Mac OS X 10.14.4 18E226, locale en-US)
    • Flutter version 1.7.8+hotfix.4 at /Users/user/Documents/Flutter/sdk/flutter
    • Framework revision 20e59316b8 (7 weeks ago), 2019-07-18 20:04:33 -0700
    • Engine revision fee001c93f
    • Dart version 2.4.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/user/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/user/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.2, Build version 10E125
    • CocoaPods version 1.6.1

[✓] iOS tools - develop for iOS devices
    • ios-deploy 1.9.4

[✓] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 33.4.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] IntelliJ IDEA Community Edition (version 2019.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 33.4.3
    • Dart plugin version 191.6183.87

[✓] Connected device (1 available)
    • SM test • serialnumber • android-arm64 • Android 8.0.0 (API 26) (emulator)

• No issues found!
Process finished with exit code 0

Hi @snickersv2
Is this still a valid issue ?
If so, can you please provide a minimal reproducible code sample that shows the issue ?
Thanks.

Without additional information, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now.
Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.