Use custom monolog configuration and laravel default configuration at the same time

Hi @taylorotwell,
monolog configurator force us to choose either using our own monolog configuration or using default laravel monolog configuration.
What I want to achieve is that because monolog can have multiple handlers, I want to using my configuration and laravel default configuration at the same time.
It isn't possible because according this commit 3ed034e23677155acbe963068fbd950f4e9e4bdb, you use if else.
if ($app->hasMonologConfigurator()) {
    call_user_func(
        $app->getMonologConfigurator(), $log->getMonolog()
    );
} else {
    $this->configureHandlers($app, $log);
}

Can we use this instead ?
if ($app->hasMonologConfigurator()) {
    call_user_func(
        $app->getMonologConfigurator(), $log->getMonolog()
    );
}
$this->configureHandlers($app, $log);

And in the configureHandlers
/**
 * Configure the Monolog handlers for the application.
 *
 * @param  \Illuminate\Contracts\Foundation\Application  $app
 * @param  \Illuminate\Log\Writer  $log
 * @return void
 */
protected function configureHandlers(Application $app, Writer $log)
{
    if (! ($logConfiguration = $app['config']['app.log'])) {
        return;
    }

    $method = 'configure'.ucfirst($logConfiguration).'Handler';

    $this->{$method}($app, $log);
}

so we still can use laravel default configuration if we want to, if we don't want, we could set the app.log to null.
If you agree, I'll create a PR about it.
Thank you.

These issues arn't a way to contact Taylor. Please discuss on slack, or just go straight to a PR as implied by our docs.

So @xian13 did you do a PR for this? I want the same thing! If you haven't done a PR and it's still not possible to do this then I will do one. Your approach seems sound.

@bhuvidya because the discussion was ended, I didn't make the PR. But what I do to achieve this is creating a Service Provider that push handler to the monolog in boot method.


ImportError while running demo.py because of commented code in lib.core.preprocess

I was about to submit a PR but thought you guys should do it rather.

Thank you! Fix this bug in the latest commit.

Its not done yet, should I make a PR? Is that what you mean ?

Sorry about that, may be you can show more details about the ImportError?

The issue was
  File "tools/demo.py", line 29, in <module>
    from lib.core.postprocess import morphological_process, connect_components_analysis, fitlane
ImportError: cannot import name 'fitlane' from 'lib.core.postprocess' (/home/YOLOP/lib/core/postprocess.py)

But this can be resolved if the code in 'lib.core.postprocess is uncommented.

Fix this in the 'import bug fixed' commit. Thank you!


[Word Search] ...

Extension
https://www.raycast.com/rishabswift/word-search
Description
When I press enter over a word, i'd like it to copy to my clipboard.
Who will benefit from this feature?
I often use this feature from alfred and when you press enter on a highlighted word, it will copy it to your clipboard so you can easily paste it.
Anything else?
No response

Thanks for suggesting this feature. It's been requested a few times and I'm working on a settings option so that you can control the default behaviour (copy to clipboard OR paste in the active app).
For now, you can hit Command + Return to copy it to the clipboard.

Hey, just to let you know that this feature is now live so you can change the default behaviour by going to the extension preferences.


Ensure we're using i18n where possible

There is a scattered usage of i18n.T() throughout descriptions and flags. Let's make future translations easier by ensuring we're using i18n where feasible.
Examples:
https://github.com/kubernetes/kubectl/blob/19b50d838ed2e2a7389a3fb467b259982c772b73/pkg/cmd/apply/apply.go#L171
https://github.com/kubernetes/kubectl/blob/19b50d838ed2e2a7389a3fb467b259982c772b73/pkg/cmd/annotate/annotate.go#L153
/sig cli
/kind cleanup
/priority backlog
/good-first-issue

/remove-kind feature

I think I can help with that.
/assign

/assign

What kind of pattern should I follow to internationalise the strings, is it applicable to only the help text for commands ?

@jayendra13 let's aim to get command and flag descriptions wrapped and then evaluate what else you find.

@jayendra13 let's aim to get command and flag descriptions wrapped and then evaluate what else you find.

👍 got it.

@jayendra13 @eddiezane It seems like nothing has happened here for a while, is it ok if I take over?

yes sure I got busy with some other stuff, and I almost forgot this.
you can continue on this.

may be this can help https://github.com/kubernetes/kubectl/pull/916

Somehow adding i18n translations on every single Short and Long line seems a bit micromanaging in a way. Wouldn't it be easier to go through all the commands and add that separately? This would allow the code that describe how the commands should work less cluttered, more consise and easier to read and we can ensure that all commands get these translations.
WDYT @eddiezane?

xref: https://github.com/kubernetes/kubernetes/pull/97610

xref: https://github.com/kubernetes/kubernetes/pull/97610


Kovan magic link during workshop was malformed

you sent me this on telegram: https://kovan.aw.app/AQAAAABdXmK02RXIrTJB9FmkWty7-K9CyqVhoVQAMDAwMA==
Did you truncate it by accident?

Was probably a debug issue - at that time we were half way through the key refactor. It's fixed now, here's the same token link:
https://kovan.aw.app/AQAAAABdaxrg2RXIrTJB9FmkWty7K9CyqVhoVQCMAe4UMQtjBB9dhWtFHD7kx5cbkmSiZHHh7rKZtUIOE4TkrREcY0aeC8xrB9H-KyQ5pupengHLPZ1dwTfctzuRs=

@JamesSmartCell tapping on that link shows “
error: io.stormbird.token.entity.SalesOrderMalformed”. Is that expected?

Yes because I thought telegram had mangled it so I mistakenly unmangled it, thus breaking it. Try this one.
https://kovan.aw.app/AQAAAABda18U2RXIrTJB9FmkWty7-K9CyqVhoVQCmCSGVN478Us0tDsqlp-lX6WfArno77FibujWUtsrJoIbYF8Ex4EFHmVvVV-hkpoDe_cePMbhx-V2JV0nARI5yxw=

Looks good for me too. Thanks :)


Exit when cookbook vendoring fails.

Signed-off-by: Tim Lane<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, I need another approval. I should probably just use the update branch button instead of rebasing manually.


Apply decorator pattern to hearings and providers

What
Apply decorator pattern to hearings and providers
Ticket
N/A
Why
Extract presentation layer logic out of hearing
and provider resource objects and views. Best practice
and consistent with previous work for offences.
TODO

[X] move provider name_and_role to provider decorator
[X] move hearing.provider_list to hearing decorator
[x] move hearing.defendant_name presentation to hearing decorator
[x] move hearing.prosecution_advocate_names presentation to hearing decorator
[x] move hearing.judge_names presentation to hearing decorator
[x] test with view specs?!

👍

👍


Wrong schema detected

Do you want to request a feature or report a bug?
Bug
What did you do?

Install k3s on with curl -sfL https://get.k3s.io | INSTALL_K3S_CHANNEL=latest sh -s - --disable traefik,servicelb
Deploy helmfile's https://gist.github.com/lexfrei/fb5849f338ad1953a15def5a4b2e3b40

What did you expect to see?
http://<IP_ADDRESS>:9090 as the endpoint for k8s-dashboard
What did you see instead?
ForwardURL="https://<IP_ADDRESS>:9090"

Output of traefik version: (What version of Traefik are you using?)
Image:         traefik:2.3.1
helm chart:    9.10.1

What is your environment & configuration (arguments, toml, provider, platform, ...)?
Htlmfiles
K8s-dashboard export

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
time="2020-11-07T17:31:14Z" level=debug msg="vulcand/oxy/roundrobin/rr: begin ServeHttp on request" Request="{\"Method\":\"GET\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/favicon.ico\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Accept\":[\"image/avif,image/webp,image/apng,image/*,*/*;q=0.8\"],\"Accept-Encoding\":[\"gzip, deflate\"],\"Accept-Language\":[\"ru-RU,ru;q=0.9,en-GB;q=0.8,en;q=0.7,en-US;q=0.6,fr;q=0.5\"],\"Cache-Control\":[\"no-cache\"],\"Connection\":[\"keep-alive\"],\"Cookie\":[\"_ga=GA1.2.693130189.1592868586\"],\"Dnt\":[\"1\"],\"Pragma\":[\"no-cache\"],\"Referer\":[\"http://dashboard.k8s.home.lex.la/\"],\"User-Agent\":[\"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.183 Safari/537.36\"],\"X-Forwarded-Host\":[\"dashboard.k8s.home.lex.la\"],\"X-Forwarded-Port\":[\"80\"],\"X-Forwarded-Proto\":[\"http\"],\"X-Forwarded-Server\":[\"traefik-8464f8798c-2z65b\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"]},\"ContentLength\":0,\"TransferEncoding\":null,\"Host\":\"dashboard.k8s.home.lex.la\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:64754\",\"RequestURI\":\"/favicon.ico\",\"TLS\":null}"
time="2020-11-07T17:31:14Z" level=debug msg="vulcand/oxy/roundrobin/rr: Forwarding this request to URL" Request="{\"Method\":\"GET\",\"URL\":{\"Scheme\":\"\",\"Opaque\":\"\",\"User\":null,\"Host\":\"\",\"Path\":\"/favicon.ico\",\"RawPath\":\"\",\"ForceQuery\":false,\"RawQuery\":\"\",\"Fragment\":\"\",\"RawFragment\":\"\"},\"Proto\":\"HTTP/1.1\",\"ProtoMajor\":1,\"ProtoMinor\":1,\"Header\":{\"Accept\":[\"image/avif,image/webp,image/apng,image/*,*/*;q=0.8\"],\"Accept-Encoding\":[\"gzip, deflate\"],\"Accept-Language\":[\"ru-RU,ru;q=0.9,en-GB;q=0.8,en;q=0.7,en-US;q=0.6,fr;q=0.5\"],\"Cache-Control\":[\"no-cache\"],\"Connection\":[\"keep-alive\"],\"Cookie\":[\"_ga=GA1.2.693130189.1592868586\"],\"Dnt\":[\"1\"],\"Pragma\":[\"no-cache\"],\"Referer\":[\"http://dashboard.k8s.home.lex.la/\"],\"User-Agent\":[\"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.183 Safari/537.36\"],\"X-Forwarded-Host\":[\"dashboard.k8s.home.lex.la\"],\"X-Forwarded-Port\":[\"80\"],\"X-Forwarded-Proto\":[\"http\"],\"X-Forwarded-Server\":[\"traefik-8464f8798c-2z65b\"],\"X-Real-Ip\":[\"<IP_ADDRESS>\"]},\"ContentLength\":0,\"TransferEncoding\":null,\"Host\":\"dashboard.k8s.home.lex.la\",\"Form\":null,\"PostForm\":null,\"MultipartForm\":null,\"Trailer\":null,\"RemoteAddr\":\"<IP_ADDRESS>:64754\",\"RequestURI\":\"/favicon.ico\",\"TLS\":null}" ForwardURL="https://<IP_ADDRESS>:9090"
time="2020-11-07T17:31:44Z" level=debug msg="'504 Gateway Timeout' caused by: dial tcp <IP_ADDRESS>:9090: i/o timeout"

I can see the correct scheme in the pod definition

Hello @lexfrei,
you did set the correct scheme on the liveness probe. That is tough, not utilized for the scheme detection for Traefiks backends.
What you can try to do is to overwrite the scheme on the service with that annotation traefik.ingress.kubernetes.io/service.serversscheme: http, as mentioned on our docs https://doc.traefik.io/traefik/routing/providers/kubernetes-ingress/.
As this is primarily a question, I gonna close that issue. Please feel free to reach out on the community forum for cases like that https://community.traefik.io/c/traefik/traefik-v2/10


Needs a better structure

Feature Request
Is you/your team sponsoring this project

[ ] Yes
[x] No

Is your feature request related to a problem? Please describe
Right now you have to reference source files directly when importing anything that isn't in the main nanoexpress import, and (more annoyingly) the import path depends on whether you're using commonjs or esm (when using typescript and targeting esnext or when using native esm).
This is how it looks right now:
// I'm okay with this...
import nanoexpress from 'nanoexpress';
// ...but not with this.
import Route from 'nanoexpress/cjs/Route.js';
// This is how the import would look like if I were targeting native esm:
// import Route from 'nanoexpress/src/Route.js';

Additionally, you can't do things like:
import nanoexpress, { Route } from 'nanoexpress';
const route = new Route(...);

Or
import nanoexpress from 'nanoexpress';
const route = new nanoexpress.Route(...);

Describe the solution you'd like
I'd like for src/nanoexpress.js to export everything (for example the Route class), while still default-exporting the nanoexpress function.
Another thing that's maybe worth considering is also having stuff like Route be properties on the default-exported nanoexpress function (similarly to how it works in express), so they can be used like nanoexpress.Route, but that's definitely optional and I'm not even sure it's a good idea.
Describe alternatives you've considered
Just using nanoexpress as-is, that's what I'm currently trying to do.
Teachability, Documentation, Adoption, Migration Strategy
It shouldn't be very different to how it's used nowadays so changing the docs would probably be trivial.
If anything, it'll be easier to use since the import path will be be the same regardless of the module system you use/target.
I might be able to work on this but I'll have to learn a bit about exports first since I've never worked on a node library before.

I welcome any PR with changes related to this as well as more test coverages help project better.
Currently on my projects i am using native uWebSockets.js, fiber (golang) so I spend less time improving this project.
but great companies supporting me with great apps/services so i should do improve as they trusted me as Open Source author

Fair enough, I might make a contribution then.
Thanks for the reply!

As no PR related to this issue - it’s not issue, just your wishes


Add files via upload

@connordallas I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host byramhills.academy not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!


Research github actions for building react applications

Goal:
Find one or possibly two solutions that help us have a mechanism to use github to do the following steps automatically:

Take the code from the branch in question
Run arbitrary commands on it like jest for testing
Save the code coverage and only allow pass based on certain thresholds
Combine the results into a package using npm.
Deploy the code to a test location so it can be reviewed.

@alexjball effectively did the work related to this ticket. Adding a separate issue for the last bullet related to ongoing deployment/running of the storybook code. Added #136 for the last bullet to handle later as a stopgap.


Possible to take a photo from the camera app?

Would it be possible to take a photo with the camera app using the Detox testing framework? This would be while running on a simulator/emulator.

Interactions with other apps is not supported. On iOS, the photo picker is drawn in a different process, and thus not supported. Mock your camera API so it returns some image.


OccupancyGrid(pgm and meta) exporter from pbstream

This file loads submaps from pbstream file, generates occupancy grid, and exports map server compatible pgm image and yaml file.
Note that WriteOccupancyGridToPgm isn't very optimized. So, any optimization suggestion is welcome. And WriteOccupancyGridInfoToYaml is copy from old code.
resolves #475

Why did you not do this in the asset writer? This seems to be fundamentally the same as bringing up Cartographer with the map and then running map_server.

Why did you not do this in the asset writer?

Because asset writer requires rosbag. Using rosbag is not an option for us.

Your solution seems to be fundamentally the same as bringing up Cartographer with the map and then running map_server.

Yes, you are right. It is fundamentally the same as bringing up run cartographer with the map, run map_server, and map_saver. I implemented this exporter because running roscore,  cartographer, occupancy grid node, map server, and map saver is too much overhead to extract a map from a file.

Because asset writer requires rosbag. Using rosbag is not an option for us.

Are you saying that you using a different data format to serialize your data to disk? Or that you do not serialize your sensor data?

Yes, you are right. It is fundamentally the same as bringing up run cartographer with the map, run map_server, and map_saver. I implemented this exporter because running roscore, cartographer, occupancy grid node, map server, and map saver is too much overhead to extract a map from a file.

What you describing can be expressed in a single launch file - is that not a workable solution.
Here are my thoughts: The proposed way for cartographer_ros is to use the asset writer to generate probability grids (currently blocked on #475, but we'll fix this probably today). My understanding is that you are unable to use the asset_writer because you do not fully embrace the ROS standards, but swapped out rosbag for a custom implementation. Because of this, the asset writer is unavailable to you and you built this workaround - which should not be used by anybody that uses rosbag. This raises the question why it should be maintained in cartographer_ros. If this reasoning is sound, I am uncomfortable with merging this.
Instead it seems like we should think how you can make use of the assets writer, probably by providing an interface that is not tied to rosbag. Wdyt?

Here are my thoughts: The proposed way for cartographer_ros is to use the asset writer to generate probability grids (currently blocked on #475, but we'll fix this probably today). My understanding is that you are unable to use the asset_writer because you do not fully embrace the ROS standards, but swapped out rosbag for a custom implementation. Because of this, the asset writer is unavailable to you and you built this workaround - which should not be used by anybody that uses rosbag. This raises the question why it should be maintained in cartographer_ros. If this reasoning is sound, I am uncomfortable with merging this.

I don't get why you got an impression that we are using the different format of serialized data. It is just a extracting a data from pbstream file that is already generated. And it is just because we let the robot move lively around to SLAM the environment and generate pbstream file without recording rosbag data.
And since the generated pbstream file already included all submap images and their poses, it was easy to generate a unified version just as occupancy_grid_node.

Instead it seems like we should think how you can make use of the assets writer, probably by providing an interface that is not tied to rosbag. Wdyt?

It can be alternative if asset writer can run only with pbstream file. I don't like the fact that I have to maintain another inflexible configuration file though.(e.g I can't dynamically(or via cmd line) configure the exported map file location.)

I would like to divert your attention to googlecartographer/cartographer/issues/508, which might be a bit relevant.
In case you do not want to save bags, but only the serialized .pbstream state - if inside the trajectory nodes you also had the full range data stored as before (which is the subject of the issue), you would not need the bag at all to write assets, the pbstream would be enough.

@ojura that's something else actually. I am currently pretty happy with not having range data in pbstream and during operation. It reduced the pbstream file size and saved memory consumption during operation.

@ojura I do not agree that this is relevant in this discussion. #508 is about holding scans in memory or not - essentially having an in-memory-asset-writer-light. While @jihoonl is concerned about converting a Cartographer state with the contained map textures into a PGM + yaml.

I don't get why you got an impression that we are using the different format of serialized data.

It was a misunderstanding of your statement that rosbag is not an option. I understand now that you are not interested in an offline process using canned sensor data at all, instead you specifically only want to use Cartographer state to generate PGM and YAML. I then also understand that you do not perceive the asset writer as an option to you.
I think you would get the best possible quality for your occupancy grid if you were writing a bag with maybe subsampled sensor data and generating your map using the asset writer - it will give equal quality if all submaps are good and higher quality in case any of your submaps in the .pbstream are faulty. It seems to me a more principled approach to your needs that is long term supported and superior in quality.
But to support precisely the use case you add in this new binary, how about we add a service to the occupancy grid node that writes out a PGM and YAML? In your online example you could just keep the OccupancyGrid node running, but not subscribe to its /map topic. This means it effectively does not use any CPU. Instead you could call this new rosservice to write out a PGM and YAML occasionally. This would effectively replace map_saver for Cartographer and help users of #475 as well. Would that work for you?

Ok. It looks like I misguided the direction here. I step back and describe the intention behind.
What I intended with this PR is to introduce a way of introspecting, manipulating and utilising the content of pbstream without bothering cartographer_node(or let's say offline processing without rosbag).  Occupancy grid extraction was the easy first step(and of course to fulfill our usecase) of taking a look the submaps in pbstream. Later, I plan to merge overlapping submaps, drop submaps with no information, and rearrange submap coordination in pbstream.
I understand that this PR has a very specific use case. But, it was to simplify many hassle processes. Having a rosservice in occupancy grid is just a replacement of map_saver which doesn't reduce # of nodes to run to obtain the same output.
Do you concern about opening pbstream data besides cartographer_node and asset_writer? Or what's your concern? If you don't like the exporter, can you accept the PR that only refactors occupancy grid? Then, I can keep the exporter in our package.

I step back and describe the intention behind.

This is much appreciated. Without elaborate context some PRs are really hard to evaluate and review sometimes.

Later, I plan to merge overlapping submaps, drop submaps with no information, and rearrange submap coordination in pbstream.

This is interesting and also here I'd like to understand why. It seems superior to me to keep some sensor data around and then reassembling a new state using the best SLAM trajectory in the asset_writer instead of rewiring the online state. Maybe we should discuss this in person or on a VC.

Do you concern about opening pbstream data besides cartographer_node and asset_writer? Or what's your concern?

This is one of my concerns. The main ones can be summarized by "no is temporary, yes is forever" (non-primary-source). To make this a bit more fine grained and spell some of them out:

Adding a new binary means we have to support it forever. Before we commit to this I want to fully understand that existing solutions can not be simply extended to fulfill the desired use cases.
The .pbstream data format is non-public, an implementation interface of Cartographer and so far we only support modifying it through the use of Cartographer. We can choose to make it part of Cartographer's public API, but this has similar costs to 1. Again before committing to this I'd like to understand and evaluate the uses cases and see if they can not be expressed on a library level.
Related: .pbstream is a data format of cartographer, not related to ROS. So if a binary derives assets out of it, it should live inside cartographer. This would mean moving the drawing code into cartographer and making it part of its public API.
Optimizing the cartographer state, i.e. the .pbstream seems in scope of Cartographer, but it is not done right now. There I'd like to understand the use cases better.

If you don't like the exporter, can you accept the PR that only refactors occupancy grid? Then, I can keep the exporter in our package.

Yes, how about for now you pull the drawing code into a library in cartographer and make use of it in the occupancy grid node. Then you can have the binary in your own package and we do not bring back the yamlcpp dependency in ROS?

This is interesting and also here I'd like to understand why. It seems superior to me to keep some sensor data around and then reassembling a new state using the best SLAM trajectory in the asset_writer instead of rewiring the online state. Maybe we should discuss this in person or on a VC.

We have been using a small size of submap(num_range_data < 30) to reduce errors from odometry. It resulted to have hundreds of submaps with a lot of overlapping area. So, I would like to explore options to manipulate submaps to drop outdated submaps, merge small size submaps, and etc.

Adding a new binary means we have to support it forever. Before we commit to this I want to fully understand that existing solutions can not be simply extended to fulfill the desired use cases.

Thanks for the clarification! It helped to understand your concern as a maintainer. I am basically creating PRs that fulfill our use cases and things that can benefit many others as a contributor. Then, letting you to decide how to merge the PR . :smile: :smile: :wink:

The .pbstream data format is non-public, an implementation interface of Cartographer and so far we only support modifying it through the use of Cartographer. We can choose to make it part of Cartographer's public API, but this has similar costs to 1. Again before committing to this I'd like to understand and evaluate the uses cases and see if they can not be expressed on a library level.
Optimizing the cartographer state, i.e. the .pbstream seems in scope of Cartographer, but it is not
done right now. There I'd like to understand the use cases better.

I think providing an access to .pbstream is inevitable for later use such as data introspection, and modification. I can't explain in details since I didn't get to the point to investigate this necessity. But, I have a strong feeling about it.

Related: .pbstream is a data format of cartographer, not related to ROS. So if a binary derives assets out of it, it should live inside cartographer. This would mean moving the drawing code into cartographer and making it part of its public API.

I was also unsure where it should go. I put it in cartographer_ros because pgm and yaml are for ROS though. I agree that the code that touches .pbstream would be better to go under cartographer.

Yes, how about for now you pull the drawing code into a library in cartographer and make use of it in the occupancy grid node. Then you can have the binary in your own package and we do not bring back the yamlcpp dependency in ROS?

Ok. sounds good to me. I close this and will open a new PR against cartographer.

Optimizing the cartographer state, i.e. the .pbstream seems in scope of Cartographer, but it is not done right now. There I'd like to understand the use cases better.

This is the exact motivation why I worked on full deserialization of Cartographer's state over at the libcartographer repo.

Thanks for the clarification! It helped to understand your concern as a maintainer. I am basically creating PRs that fulfill our use cases and things that can benefit many others as a contributor. Then, letting you to decide how to merge the PR . ￼ ￼ ￼

That is fine of course! I hope that you can understand my reluctance too.  My goal is to get everybody what they need. I am sorry if it might occasionally feel like I am actively standing in the way of progress. That is really not my intention.
I think it would help if your goals with any code change are made more clear to us earlier, so that we can advise and iterate earlier on potential approaches.


fix(sql): printer to handle eol correctly

I have the original document like below (with CRLF eol)
CREATE TABLE `CHANGELOG` (
  `ID` NUMERIC(20, 0) PRIMARY KEY NOT NULL,
  `APPLIED_AT` VARCHAR(25) NOT NULL,
  `DESCRIPTION` VARCHAR(256) NOT NULL
) ENGINE = INNODB DEFAULT CHARSET = UTF8MB4;

when I set endOfLine config to crlf than result like below
CREATE TABLE `CHANGELOG` (

  `ID` NUMERIC(20, 0) PRIMARY KEY NOT NULL,

  `APPLIED_AT` VARCHAR(25) NOT NULL,

  `DESCRIPTION` VARCHAR(256) NOT NULL

) ENGINE = INNODB DEFAULT CHARSET = UTF8MB4;

when I debug,
sql printer handle eol correctly, but I can find \r\n is replaced by \r\r\n after return formatted value.
actually I didn't find any reference but I guess prettier gives nomalized input as LF and process eol after printer printed.
this patch remove any eol conversion. so, prettier will handle it.

Hello, @JounQin could you review this PR?


ember-derequire doesn't derequire the ember-engine bundles.

I am trying to build an lazy engine, the engine bundle is not getting derequire'ed... it still has require/define... looking at options of how to go about it.
Not sure where does derequire picks the files to update? is there a configuration that i can update to let derequire pick dist\engines-dist?
I am looking at other options of using grunt.file to do this... thoughts?

These PRs might help show how to do this:
https://github.com/Esri/ember-esri-loader/pulls?utf8=✓&q=is%3Apr+is%3Aclosed+engine


glass material shows no caustics using path engine, rough glass has caustics

Path engine should render caustics for glass material, but only rough glass works under path engine.

update: I can use rough glass with lowest roughness as a workaround.

Please upload a scene and a render.
Which light source is casting the caustic? It has to be intersectible so path can find it.

00000.bcf.zip
bidi-20 samples

pathocl - 200 samples

pathocl- 5000 samples - rough glass

Ok, so spot light is not intersectible light. That's the reason.
I just wonder how does the rough glass material works in this case


Using BuildKite for GPU related CI?

Just checked JuliaGPU, and they run their GPU functions in BuildKite.
https://github.com/JuliaGPU/buildkite
https://github.com/CliMA/Oceananigans.jl
It is worth taking a look at. Suggested test: compare CPU F32 with GPU F32 simulation results.

Ok, so now we have access to Julia's GPU CI. These are the following steps:
https://github.com/JuliaGPU/buildkite/?tab=readme-ov-file#steps-for-developers

I will leave some links here:
Benchmarks
https://lux.csail.mit.edu/benchmarks/
https://github.com/benchmark-action/github-action-benchmark/
BenchmarkTools.jl


Add k to pinecone's "ask" functionality

We were running into an issue when asking a question of OpenAI using pinecone, where there were occasions where the context provided by the ask method was over the 4096 tokens, and so was exceeding the default OpenAI context window for question asking. This change would allow a user to add in an additional parameter k to the ask method, which could be subsequently passed to similarity_search to allow the user to have the amount of relevant results they wish, instead of defaulting to the 4 that is with similarity_search currently.

@asmorris I wouldn't be opposed to adding the same param to all other vector search DBs if you feel like coding it up!

I wouldn't be opposed to adding the same param to all other vector search DBs if you feel like coding it up!

I can absolutely do that! Great idea


jupyter extension - fix handling of bad input specs

INT-1232

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Kevin Yang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Projects Added

You should not include node_modules in the repository, they are very big and redundant because programmer can install those modules on his machine using package.json. Please make a PR again!

Ok I am Making a PR again


tr_tr.json Turkish Localization

i added lang file in src>main>resources>assets>constructionstick directory and added en_us.json too, for others find it easily

the en_us.json inside generated/resources/assets/constructionstick/lang get generated whenever the datagen runs and should not be duplicated into the regular resources folder


Possible reasons: server offline (I have already tried both proxy and cookie settings.)

Bug description
Hello?
I started using Grabber a week ago.
At first, I added "furry.booru.org" to the sources, and the program worked well then.
But when I checked yesterday, the message "Possible Reasons: server offline" appears and is not being searched.
I've tried all the known methods, but there's still a problem, and the program isn't working today either...
I've tried proxy, DNS bypass, installing Microsoft visual C++, reinstalling the program, and setting up cookies, but there's still a problem....
However, when I accessed "furry.booru.org" in chrome, I found that Cloudflare appears. Is it related to this?
Steps to reproduce

Go to 'favorites'

Click on 'sources'

Click on 'add'

trying add 'furry.booru.org'

See error

Go to 'new tab'

searching 'keywords'

see error (possible reasons:server offline)

Expected behavior
As was the case a week ago, the source was added and searched on the "https://furry.booru.org" site.
Context
main.log
settings.txt
Screenshots

System information

OS: Windows 10
Grabber version: 7.6.0 (x64)

Additional context
I have already reinstalled the program after deleting it, and I have installed all of Microsoft visual C++ 2013, 2015, 2019 x64, x86. But the problem still continues.

Dude seriously, E621.net is a way better furry site just use that one and guess what, it's already on the list!

Dude seriously, E621.net is a way better furry site just use that one and guess what, it's already on the list!

That's right! I already know! Unfortunately, however, some of the illustrations that are not in E621 remain only at furry.booru.org. TT
So.... I'm desperately hoping for furry.booru.org as well.

[13:47:10.104][Error] [furry.booru.org][Html] Cloudflare wall for 'https://furry.booru.org/index.php?page=post&s=list&tags=&pid=0'
[13:47:10.104][Warning] [furry.booru.org] No valid source of the site returned result.

Again it's cloudflare error, you need user agent, you can set it in the source settings. You will need a user-agent in the headers, a cookie clearance cookie, and maybe a login.
Well, there is something else, I can confirm even with a login, a user agent, and a cloudflare cookie, I still get the same error. I noticed the url on my browser as an argument with some cloudflare related things :
&__cf_chl_jschl_tk__=... (look lik a token) Maybe grabber now need to send thoses too, seem annoying.


DOC: Sundry documentation fixups

Polish release notes and include release dates.
Add some missing plans and plan stubs.

Codecov Report

Merging #970 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #970   +/-   ##
=======================================
  Coverage   90.52%   90.52%
=======================================
  Files          48       48
  Lines        7851     7851
=======================================
  Hits         7107     7107
  Misses        744      744

Impacted Files
Coverage Δ

bluesky/plans.py
85.89% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c548068...21ed2d9. Read the comment docs.


feat: getting started page enhancements

Closes #1142

Figma:  https://www.figma.com/file/KZ6SWR2abIniIJY4RewDeA/RL_Designing_GetStarted?node-id=10%3A13436
Box Notes for specific changes: https://ibm.ent.box.com/notes/997577728498?s=37v97opzd2ea21ffaaepqlyynhiybkq4

Testing:

Make sure functionality and designs follow Figma above
http://localhost:3000/designing/get-started

Loks like the table and dropdown don't hang left in the Figma file, but the coded table does hang. I also double checked the assets table and it hangs left too. Wasn't sure what was correct? If you match Figma file, should we also update the Assets table to not hang?

Yeah, looks like there's some confusion about hanging and not hanging tables... and I can see why. Since the catalog is a custom table and it hangs and It has the same sort dropdown as our data tables do (which is eventually going to become a fluid input) — it probably makes sense to also hang the data tables. But I'll leave this up to @kingtraceyj
Even if we decide not to hang the data tables, we just need to make sure then that none of them are hanging.

@alisonjoseph talking to @jeanservaas we will go ahead a hang the table since we will have fluid drop downs at some point. i'll update the redlines.


Sending raw text to the model

Hi there,
I'm developing an autocomplete app using web-llm, but I'm having trouble injecting my own raw prompt with control tokens bypassing the preconfigured chat conversation template. I have tried several methods, but it always seems like the lib is injecting control tokens into the LLM. I'm wondering if there is a way to send raw text to the model and get a completion without relying on high-level chat APIs?
I'm trying to achieve something like this:
const prompt = `
<|start_header_id|>system<|end_header_id|>
You are a friendly assistant
<|eot_id|>
<|start_header_id|>user<|end_header_id|>
What's 2+2
<|eot_id|>
<|start_header_id|>assistant<|end_header_id|>
`;

const stop = '<|eot_id|>';
const reply = await engine.completion(prompt, stop);
// "The answer is 2+2=4"

Thanks 😅

Hi! Raw text completion is supported in npm 0.2.56 via engine.completions.create(). See https://github.com/mlc-ai/web-llm/pull/534 for more! This should ignore everything except the stop tokens and stop strings in mlc-chat-config.json. You can override mlc-chat-config.json with ChatOptions, and override the conversation template with ChatConfig.conv_config.

It may help for debug to add console.log(prompts) and console.log(tokens) here: https://github.com/mlc-ai/web-llm/blob/41e786b3f4097c165b1fc109b1b9317ed3193089/src/llm_chat.ts#L978
This is the exact string and tokens fed into the model, after applying any chat template. But this requires you to build WebLLM from source, which may take more work than other TS/JS packages due to dependency to TVMjs (will fix this soon): https://github.com/mlc-ai/web-llm?tab=readme-ov-file#build-webllm-package-from-source

Thank you for adding this feature!


Do you support 32 bit application on VS 2015 ?

[Enter feedback here]
I don't succeed to works with 32-bit application  and i see that this issue already fixed

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 17f573c0-3c98-2744-e2df-5bf023ee13cb
Version Independent ID: 9c27ea10-29c8-5310-aa89-c3287d779d50
Content: Getting started with WebView2 for Win32 apps - Microsoft Edge Development
Content Source: microsoft-edge/webview2/gettingstarted/win32.md
Product: microsoft-edge
Technology: webview
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

@orengav Could you add some more detail about what you're running into? If you can, please open an issue in our feedback repo, which asks extra questions and details that will help us to diagnose your problem.
https://github.com/MicrosoftEdge/WebViewFeedback/issues/new?assignees=&labels=bug&template=bug_report.md&title=
Thanks!

I'll go ahead and close the issue now. Thanks.


Bump deps; implement detectInputTypeSupport in terms of purescript-dom

Resolves #8
@garyb Would you mind reviewing this? In particular, I didn't think I should have needed all three instances of unsafeInterleaveEff (it seemed like the one around f i should have been unnecessary, but perhaps I am thinking about the variance incorrectly), but I couldn't figure out a way around it in the naïve way.

:+1:

thanks!


ddev snapshot --all fails if any projects are stopped

Is there an existing issue for this?

[X] I have searched the existing issues

Run a Diagnostic and Paste Link Here
https://gist.github.com/FLeudts/51c1c7ab6d0051c1939d1305b2cd3507
Current Behavior
If I run the ddev snapshot --help command it tells me that ddev snapshot --all should only snapshot running projects. It still tries to snapshot a stopped project and then fails because the db container is stopped.
Expected Behavior
ddev snapshot --all should ignore stopped projects or the description should be edited.
Steps To Reproduce

Have two or more projects
Stop the first project in ddev list and start the others
Execute ddev snapshot --all
No snapshots will be created

Anything else?
No response

Thanks, I can recreate that. It used to work!

I will work on this.


update submodules

https://github.com/mandiant/capa/blob/master/.gitmodules
should point to master/commits, not those old branches.

looks like the submodules point to the correct commits (at least in GH interface) but the .gitmodules file points to the wrong branches. this probably confuses some clients that may not fetch all branches/history.


NonLinearCoordinateTransform transformId deserialization bug

A good fix for this would probably also resolve #80, but documenting separately while I think about that.  The current implementation of renderapi.transform.NonLinearCoordinateTransform will, when given a json dictionary, load the proper attributes and then overwrite transformId with the argument value (default None).  This is problematic for dereferencing transformations and probably should have a test.

resolved with #83


[Feature Request] Right align label

Right now a label can be left or center aligned.
A right align option should exist, I would think.

Hi,
Yes, it absolutely should exist.
v5.2 will support Right-to-left writing as well. With this I will implement this as well!

I added "Right aligned text" support to dev_5.2
It works like this:
    lv_obj_t * label = lv_label_create(lv_scr_act(), NULL);
    lv_label_set_text(label, "Very long line\n"
                             "a\n"
                             "two words");
    lv_label_set_align(label, LV_LABEL_ALIGN_RIGHT);

A quick test would be welcome :)
I mentioned Right to left support as well, but release v5.2 quicker I delayed this feature. If somebody needs Right-to-left support, please tell it here: https://github.com/littlevgl/lvgl/issues/46

To see the progress of dev-5.2 I close this issue.
If you have any remarks don't hesitate to reopen it! :)


Switch from abstract test classes and callbacks to JUnit test rules with a fluent API

Currently a generated test case results in an abstract class with one @Test-annotated method that will be executed by JUnit. Since the abstract class must be extended, for each actual test a subclass must be created.
To be able to use the generated test code in a more flexiable way, each test case should result in a JUnit test rule. A test rule can be used by a test class with multiple tests (@Test-annotated methods).
When switching from abstract test classes to JUnit test rules, the callback mechanism based on inheritance will not work anymore. A generated test rule must provide fluent APIs for different BPMN elements and waiting states (e.g. user task, external task, timer jobs, etc.) as well as a fluent API to create and execute a process instance (the selected test case) with variables, business key and mocks. If the BPMN process changes, the fluent APIs methods also change (different name or different type) and produce compile errors, like the callback methods previously.
Example:
public class MyTest {

  @Rule
  public TC_order_fulfillment__Happy_Path tc = new TC_order_fulfillment__Happy_Path();

  @Test
  public void test1() {
    // a fluent API for the user task "checkAvailabilityUserTask"
    tc.handleCheckAvailabilityUserTask()
        // first parameter will be ProcessInstanceAssert (from camunda-bpm-assert)
        // second parameter depends on the BPMN element - in this case the user task
        .verify((pi, task) -> {
          pi.hasVariable("customerId");

          assertThat(task.getAssignee(), equalTo("xyz"));
        })
        .withVariable("available", true)
        .complete();

    tc.createExecution()
        .withVariable("customerId", "XYZ")
        .withBusinessKey("order-123")
        .withMock("approveOrder", new ApproveOrderDelegate())
        .execute();
  }

  @Test
  public void test2() {
    // ...
  }
}

Before a test method is executed, the generated test rule is responsible to deploy the corresponding process definition. After a test method execution that process definition must be undeployed and fluent APIs must be resetted.

Implemented first version of this feature and updated code snippets in README, which show the new usage.


How to set a image for a form field?

Can pdf-lib be used to programmatically fill form field with a image in a template PDF
I tried like this,but failed
const sigAppearanceStream = PDFContentStream.of(
  PDFDictionary.from({
    Type: PDFName.from('XObject'),
    Subtype: PDFName.from('Form'),
    BBox: PDFArray.fromArray([
      PDFNumber.fromNumber(0),
      PDFNumber.fromNumber(0),
      PDFNumber.fromNumber(200),
      PDFNumber.fromNumber(50),
    ], pdfDoc.index),
    Resources: PDFDictionary.from({
      XObject: PDFDictionary.from({}, pdfDoc.index)
    }, pdfDoc.index),
  }, pdfDoc.index),
    drawImage('MarioEmblem', {
      x: 447,
      y: 520,
      width: marioEmblemDims.width * 0.75,
      height: marioEmblemDims.height * 0.75,
    }),
);

i find that i need to set FRM stream for sigAppearanceStream,n0 stream and n2 stream in FRM, finally set image stream in n2. This is the right way to set a image in a form field.

hi, @ConandSherry can you please show a sample of your code on how you manage to create a signature appearance with an image?
I know that I need to create inside the Resources a value FRM but the way I'm doing it's not working.
Hope with your help I will manage to get this thing working.
Thanks!

@ConandSherry @Hopding can you help me with this? thanks

can u show me your pdf structure opened with iText

@ConandSherry what do you mean by opened with iText?  Do you mean the content of the pdf? I'm not using iText I'm using this lib and node-signpdf to sign a pdf.

@FilipeAraujo  i changed the api drawImage.The original one can't support FRM value which PDF structure needed

@ConandSherry did you created a fork for it? can I have a look on the code? thanks

@FilipeAraujo  i use drawImage('FRM') to create FRM stream and i add

if (!options) {
   return [
      pushGraphicsState(),
      translate(0, 0),
      image(name),
      popGraphicsState(),
    ].filter(Boolean) as PDFOperator[];
  }

in the orignal drawImage function

with iText u can see the pdf struct. so u can compare the difference between yours and pdf which has a signature appearance with an image

@FilipeAraujo  also pdf-lib's saving function can't suport incremental addition. u may also have trouble when adding a signuature form field with a pdf has one. pdf-lib will make the origin one modified.

Thanks for the tips @ConandSherry , for now, I will not have incremental additions/updates.
Although, and help me with this @Hopding , I thought that was possible in 'pdf-lib' to do something like:
const n2 = PDFContentStream.of(
      PDFDictionary.from(
        {
          Type: PDFName.from('XObject'),
          Subtype: PDFName.from('Form'),
          BBox: PDFArray.fromArray(
            [
              PDFNumber.fromNumber(0),
              PDFNumber.fromNumber(0),
              PDFNumber.fromNumber(width),
              PDFNumber.fromNumber(height)
            ],
            pdfDoc.index
          ),
          Resources: PDFDictionary.from(
            {
              Font: PDFDictionary.from(
                {
                  Helvetica: this.font
                },
                pdfDoc.index
              )
            },
            pdfDoc.index
          )
        },
        pdfDoc.index
      ),

      drawImage('watermark', {
        x: 0,
        y: 0,
        width: width * 0.4,
        height: height * 0.4
      }),

      drawText(this.cargo, {
        x: MARGIN * 4,
        y: height / 2,
        font: 'Helvetica',
        size: 20,
        colorRgb: [0, 0, 0]
      }),
      drawLinesOfText(this.dn.split('\n'), {
        x: width / 2,
        y: height / 2 + (10 * this.dn.split('\n').length) / 2,
        font: 'Helvetica',
        lineHeight: 10,
        size: 5,
        colorRgb: [0, 0, 0]
      })
    );

    const FRM = PDFContentStream.of(
      PDFDictionary.from(
        {
          Type: PDFName.from('XObject'),
          Subtype: PDFName.from('Form'),
          BBox: PDFArray.fromArray(
            [
              PDFNumber.fromNumber(0),
              PDFNumber.fromNumber(0),
              PDFNumber.fromNumber(width),
              PDFNumber.fromNumber(height)
            ],
            pdfDoc.index
          ),
          Resources: PDFDictionary.from(
            {
              n2: n2
            },
            pdfDoc.index
          )
        },
        pdfDoc.index
      )
    );

    const sigAppearanceStream = PDFContentStream.of(
      PDFDictionary.from(
        {
          Type: PDFName.from('XObject'),
          Subtype: PDFName.from('Form'),
          BBox: PDFArray.fromArray(
            [
              PDFNumber.fromNumber(0),
              PDFNumber.fromNumber(0),
              PDFNumber.fromNumber(width),
              PDFNumber.fromNumber(height)
            ],
            pdfDoc.index
          ),
          Resources: PDFDictionary.from(
            {
              FRM: FRM
            },
            pdfDoc.index
          )
        },
        pdfDoc.index
      )
    );
    const sigAppearanceStreamRef = pdfDoc.register(sigAppearanceStream);

This is a rough conversion and it's just to explain what I mean.
Isn't that possible? I'm trying to follow the structure of
https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/PPKAppearances.pdf (page 11).

@FilipeAraujo  u miss a n0 stream . i think your file struct is wrong. if u need the right struct, pdf-lib can do almost all things,  u only need to modify the drawImage API.
PDFContentStream.of(
        PDFDictionary.from(
            {
                Type: PDFName.from('XObject'),
                Subtype: PDFName.from('Form'),
                Resources: PDFDictionary.from(
                    {
                        XObject: PDFDictionary.from(
                            {
                                n0: pdfDoc.register(n0Stream),
                                n2: pdfDoc.register(n2Stream)
                            },
                            pdfDoc.index
                        )
                    },
                    pdfDoc.index
                ),
                BBox: PDFArray.fromArray(defaultBBox(), pdfDoc.index),
                FormType: PDFNumber.fromNumber(1),
                Matrix: PDFArray.fromArray(defaultMatrix(), pdfDoc.index)
            },
            pdfDoc.index
        ),
        drawImage('n0'),
        drawImage('n2')
    );

@ConandSherry thanks! however, would it be great to do this without changing the pdf-lib core. @Hopding do you have something in the pipeline related to this? thanks!

@FilipeAraujo I do plan to greatly improve pdf-lib's support for signatures and acroform fields. I'm currently working on finishing v1.0.0, which includes a new high level API for pdf-lib's existing features. After that, one of the things I'd like to work on is better acroform and signature support. I can't commit to a specific timeline. But hopefully it'll be done within a few months.

@Hopding I'm trying to add an image into a form field location instead of x y coordinates, is this possible yet?


WebSocketException: Connection to #server failed because the connection was not upgraded to websocket

Hi,
Since the transition from 1.3.9 to 1.4.0 I can no longer establish a connection with the SignalR server, the error states:
WebSocket connection to #server failed: WebSocketException: Connection to #server was not upgraded to websocket
No settings have been changed, and when I go back to 1.3.9, no more problems.
About settings :
final httpConnectionOptions = HttpConnectionOptions(
      logger: logger,
      logMessageContent: true,
      requestTimeout: _requestTimeOut,
      accessTokenFactory: () => Future.value(
          'Bearer ${Config.serverAuth}|UserAuthorization $userToken'),
      transport: HttpTransportType.WebSockets,
      skipNegotiation: true,
    );

_hubConnection = HubConnectionBuilder()
        .withUrl(Config.signalRHubUrl, options: httpConnectionOptions)
        .withAutomaticReconnect()
        .configureLogging(logger)
        .build();

I noticed since 1.4.0 there is a "0" port, which for me is not normal, namely that I don't specify the connection port in my configuration because it's the default SSL port: 443

But even specifying port 443, I have the same error :

But it is no longer specified "0" before the hashtag :

I think my problem comes from the modification of how the "access_token" went in 1.4.0 :

Indeed, in my project I have a double authentication, via an application token (valid for 1 year), and via the user's token (short duration).

@autocar  is it working after downgrading to 1.3.9?

any update for this problem :(

@hoaq139 use 1.3.9 it's working

So instead of adding 'Bearer' string with the token. Just send the token in accessTokenFactory and it will work.


[donotmerge] vendor.conf: add ostree-go

it is used by containers/image for pulling images to the OSTree storage.
This is required in preparation of: https://github.com/containers/image/pull/279
Signed-off-by: Giuseppe Scrivano<EMAIL_ADDRESS>

We typically create a single skopeo PR, initially (for test run purposes) vendoring from the unmerged containers/image branch and then updated to vendor from containers/image master; but this works as well, if @runcom is OK with it.

Scratch that, sorry, NAK as is; we do vendoring differently in containers/image and skopeo.
In containers/image, only vendor.conf is checked into git, and the dependencies are pulled by the test process.
In skopeo, both vendor.conf and the resulting vendor directory is checked into git; so, merely adding a line to vendor.conf would not fix the test failures in https://github.com/containers/image/pull/279 .
I.e., please run vndr on top of this PR, and add the resulting changes to the same commit.

@mtrmac I've pushed a new version with the ostree-go files vendor.
Is there any wish for Skopeo to use trash as well for maintaining vendor?

ACK, thanks. (Still up to @runcom whether he wants this stand-alone PR.)

Is there any wish for Skopeo to use trash as well for maintaining vendor?

I was personally hoping to avoid having to care until Golang finally standardizes on something :) At least for me personally, vndr works well enough that I don’t see an urgent need to change; of course there might be a great features I don’t know  I am missing.

@mtrmac as for another PR, I won't probably open one to re-vendor containers/image.  The change for using ostree go bindings is not really so urgent and it can probably wait until next sync.
From my limited experience: the only advantage with trash is that it maintains a cache, most libs will be shared with containers/image.  It also opens up to the possibility of dropping vendor completely (as regenerating it is quite cheap from the cache) as containers/image does.

can't see why we need to merge this now when https://github.com/containers/image/pull/279 is still in-flight, so let's just wait and do a commit when that's merged and bumped here.

can't see why we need to merge this now when containers/image#279 is still in-flight,
@runcom Because containers/image#279 tests fail without a vendor update, we need something in skopeo.

So, I guess let’s do the traditional “DO NOT MERGE: Vendor containers/image $branch” PR?

So, I guess let’s do the traditional “DO NOT MERGE: Vendor containers/image $branch” PR?

Yep

renamed to [donotmerge]..  I'll give a run for the containers/image PR with this branch to be sure tests will still pass once we will merge this.

@giuseppe I’m sorry we keep being unclear (I’ll try to clarify the README in https://github.com/projectatomic/skopeo/pull/343 , and please do speak up if it is insufficient): the point is not special naming conventions of the PR, but having a skopeo PR which both integrates the new proposed containers/image version and contains any other updates necessary so that skopeo keeps building and working.
(When we initially split the skopeo and containers/image repos, we have had huge problems with the two getting out of sync, mostly by API changes, where updates of containers/image would break skopeo and nobody would notice that skopeo needs updating. Hence make test-skopeo to detect this in containers/image, and if make test-skopeo fails, creating these “do not merge” “pre-PRs” to show what exactly will be updated in skopeo; once that “pre-PR” has tests passing, the containers/image PR is merged and the “pre-PR” is converted into a regular PR vendoring from containers/image:master and immediately merged.)

the point is not special naming conventions of the PR, but having a skopeo PR which both integrates the new proposed containers/image version and contains any other updates necessary so that skopeo keeps building and working.

i.e. something like https://github.com/projectatomic/skopeo/pull/352 , (which seems to fail because skopeo’s CI also needs updating to install dependencies)

@mtrmac thanks for the explanation.  (I think) I got it now :)  About the containers/image PRs I've opened https://github.com/containers/image/pull/279 is currently blocked on https://github.com/containers/image/pull/281.  I'll rebase it and do the changes once 281 is merged.  At that point we can amend the changes in the donotmerge PR for Skopeo and ensure the tests are still passing.
Does that make sense?

Yes, perfect.

Thanks!


Valid_Queue Size = 50% of Train by default

Any thought or intuition as to why we split the train data in half as opposed to the more common practice of [15-30] percent for validation split. Does the sampling have to come from the train set or can it come from a different distribution of validation data like on a standard train, validation, test split?
Feel free to close after answering.
Regards.

We didn't try different ways to split the data. I think any kind of sampling/split would be fine as long as we don't touch the test set. Arguably, it would easier to distinguish the generalization ability of different architectures with a relatively small training/validation ratio.


Good old times has an incorrect line

del data[:]
As far as I know, this line would not have the desired effect of clearing the data memory. The slice notation Python makes a copy of the data.  So that's not what we want.  To fit in with the rest of the code and allow old data to be garbage collected, just assign an empty list to the data variable.

@milesmajefski are you quite sure? http://stackoverflow.com/a/1400622

I think this is how you delete the contents of a list, but if you point me to documentation otherwise, I'll rewrite. Thanks.

del data[:] is correct for deleting the contents of a list while leaving the list object itself alone.
By demonstration:
>>> data = [1,2,3]
>>> id(data)
4549185608
>>> del data[:]
>>> data
[]
>>> id(data)
4549185608
>>>


Weird behaviour AeInputAddress

Adds additional symbols while deleting the prefix

There is no such issue in current version.


computed properties are not executed

Version
3.0.0
Reproduction link
https://codesandbox.io/s/magical-fog-4shec?file=/src/components/List.vue
Steps to reproduce
When you click change to audit, the log function is executed, but the computed attribute is not executed.
vue 3.rc-10 version, it can work normally.
What is expected?
When the ref value in setup is changed, the computed attribute is also changed
What is actually happening?
When the ref value in setup is changed, the calculated attribute is not changed

Make userList reactive:
userList: reactive([
  { id: 1, name: "name1", isAudit: false },
  { id: 2, name: "name2", isAudit: true },
  { id: 3, name: "name3", isAudit: true },
])

Make userList reactive:

userList: reactive([

  { id: 1, name: "name1", isAudit: false },

  { id: 2, name: "name2", isAudit: true },

  { id: 3, name: "name3", isAudit: true },

])

Thank you. I got it wrong

Or a ref, that would also work


telegram-desktop: 5.2.3 -> 5.3.2

Diff: https://github.com/telegramdesktop/tdesktop/compare/v5.2.3...v5.3.2
Changelog: https://github.com/telegramdesktop/tdesktop/releases/tag/v5.3.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I just sent a message mentioning this pull request into three Telegram groups (NixOS English, NixOS Russian, materialgram) and I urge everyone to test. I hope, there will be some testers that are interested in this campaign

i was able to build from nixos 24.05 with specific telegram-desktop pr branch. Didn't have issue for general use, not sure about calling feature etc.
Additionally, overriding for materialgram(#321531, with version <IP_ADDRESS>) failed for patching, patches = [] currently fixes now.

Let's merge this and test it in the wild. Voice calling seems to work for me.


add link preview metadata showing map

Currently we have no metadata:

can test with https://github.com/rafaelmardojai/share-preview


Thanks for the update - still troubles

Hello again,
I have updated both blender and gms, and created a simple object in blender, which i wanted to show in your tutorial project (tut 2 - "load vb").
However, sometimes it loads, sometimes it crashes but it never looks like the geometry I designed in blender.
As i see your other tutorials are running fine, even animating, the error must be on my side, but I can't figure out, what I do wrong.
Please see attached blender file of a simple chimney-like object.
Here's what I did:
The object looks like this:

These are my export settings, as far as I can tell, they match your "native" vbf:

The attributes are set to:

I have also attached a .vb file, the add-on generates from the blender file.
Could you please tell me, what I am doing wrong? For a totally-zero-pre-knowledge-person, the tutorials seem not to be enough to get it working, or I missed something completely.
Thanks for your help!
Cheers,
Gris
gms-test.zip

TLDR: I wrote the exporter for my specific workflow and missed an edge case. Thanks for bringing this to my attention.
The vertex buffer function will crash if there's no data in the exported vb file. This can happen if you use the Export Selected option without objects being selected, where the exporter will create a file with only compression data and no vertex data. Clicking around in Blender may deselect the object(s) you wish to export.
For the incorrect geometry, your mesh color attribute uses Vertex as its domain, which is a case I did not test for:

The exporter expects Face Corner dormain, as this is aligned per triangle (the way gms2 handles vertex buffers) instead of per vertex. Using vertex domain stores less data and can screw up the space between vertices when creating data on export. The vertex buffer is only "valid" if the length of the buffer = (number_of_vertices x byte_size_of_format), which is why the vertex_create_buffer() and vertex_submit() calls fail sometimes. When it doesn't error, the position attribute is only aligned correctly for some vertices and other attributes bleed over (note the white and alpha on the top of the mesh):

Converting the color attribute to domain Face Corner and data type Byte Color fixes this issue:

I'll work on a fix that can read the Vertex domain correctly so color attributes don't need to be converted beforehand. Expect an update to the development repo soon.

oh my -- thank you very much!
I really didn't expect that there's an edge case on your end -- glad, we found it!  💯


MudDataGrid: Fixed with EditMode="DataGridEditMode.Cell"

Description
If DataGrid was in Cell edit mode, the SelectColumn wouldn't render any check boxes inside the grid, since SelectColums was missing an EditTemplate. Removed select on row click with this mode as well.
How Has This Been Tested?
All test that were present passed. No new tests needed for this change.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[ ] I've added relevant tests.

I have made a change to behavior of DataGridEditMode.Cell. It has previously selected on row click. Even though I'm clicking on editable field. So I disabled this functionality for this mode and have changed the test as well. Please look into it if my intention is good.

Since the DataGrid is currently far away from being done, we should hold reviewing PRs for it.

Hi @tjscience this is maybe another PR for you to inspect?

What is the ETA on this?  I need to see the select if the grid is in cell edit mode.

@just-the-benno Hey, some time has passed, Data Grid is released and I have have updated the pr. Can you tag the correct person to review it?

@ScarletKuro Hello, this pr has been on hold for quite some time, but now since DataGrid has been released, I'd like to merge this pr. And I've seen that you've been active lately. Can you assign a reviewer pls?

Hi @K0rhak
Is the problem still present? I noticed that this PR was done before a major refactoring that took place https://github.com/MudBlazor/MudBlazor/pull/6049.
Could you provide a reproduction of the issue using try.mudblazor.com?

No new tests needed for this change.

However, we do need a bUnit test to ensure that this doesn't break in the future. I believe the test should be simple and straightforward by checking if the checkboxes are displayed in the grid when the datagrid is in the Cell edit mode.
Then we can move forward and merge this.

@ScarletKuro Thanks for reply.
To my surprise, when I returned to it after more than a year, the bug was still present.
Reproduction is here, https://try.mudblazor.com/snippet/GkGxYrFIYGxFeMUs (just switch Form - Cell)
I fixed the SelectionColumn, it was missing EditTemplate. Along with MultiSelection, where it selected row on click, even when it is not desirable, eg. clicking on cell to edit it.
It might take few days to write bUnit tests, since I have not done it and I'm quite busy over the weekend.

Reproduction is here, https://try.mudblazor.com/snippet/GkGxYrFIYGxFeMUs (just switch Form - Cell)

Thanks for the link, it's definitely a bug.

It might take few days to write bUnit tests, since I have not done it and I'm quite busy over the weekend.

No worries.

There is also an alternative PR #7207, and there are some concerns regarding your changes https://github.com/MudBlazor/MudBlazor/pull/7207#issuecomment-1636826841

Well, I tried to fix MultiSelection as well. Which is not present at #7207.  I can't replicate is on trymudblazor, since it's not against a dev branch. But here is the video of what I would consider a bug
https://github.com/MudBlazor/MudBlazor/assets/24293505/29d659b2-7e91-4145-a460-c945ed7b39f5
Tjsience wrote that I disabled row click when it was in read only mode which is not correct. I disabled it when clicking on row has some effect, like entering TextField in cell or opening an edit dialog window in DataGridEditTrigger.OnRowClick. It still works if ReadOnly = true.
But I agree that you might want to leave up to the developer to not turn on the MultiSeleciton if ReadOnly is false.

Ok, I will reopen this PR then if you still plan to work on it.

I can't replicate this on trymudblazor, since it's not against a dev branch

Sadly, we have only docs against the dev branch https://dev.mudblazor.com/

Well, I tried to fix MultiSelection as well.

Could you add this in description, like what exactly needs to be fixed? Because from the issue description and the reproduction link I understood that the only problem is the missing checkboxes during DataGridEditMode.Cell

@tjscience can you review this please? Also read this comment https://github.com/MudBlazor/MudBlazor/pull/4821#issuecomment-1642623836

@tjscience can you review this please? Also read this comment #4821 (comment)

If you look at my review comment, this is still an issue.

We should still "select" the row when in edit mode and trigger the SelectedItemChanged & SelectedItemsChanged. There are implementations (ours included where editing is done in place with Cell mode and we need the selection to happen as well.

If you look at my review comment, this is still an issue.

Your comment is pending. We cannot see it, only you do. You need to click review changes -> submit review.
Open the page in private mode to check whatever your review is visible or not.

@tjscience can you review this please? Also read this comment #4821 (comment)

If you look at my review comment, this is still an issue.

We should still "select" the row when in edit mode and trigger the SelectedItemChanged & SelectedItemsChanged. There are implementations (ours included where editing is done in place with Cell mode and we need the selection to happen as well.

So can I manually remove the element from SelectedItems instead of skipping SetSelectedItemAsync? Or this whole problem/pr is feature instead of a bug?

If you look at my review comment, this is still an issue.

@tjscience your comment is pending. We cannot see it, only you do. You need to click review changes -> submit review. Open the page in private mode to check whatever your review is visible or not.

Just submitted. I didn't realize it was pending.

@tjscience I have looked through the code and the only internal use case is checking whether all items are selected so header cell should be checked as well. Which is normal selection behaviour I'm trying to prevent. But I understand that it would be a breaking change.
But after all I find it weird and counter intuitive that turning on MultiSelection suddenly enables row click selection. That should be in a separate parameter. Why should that behaviour be exclusive to MultiSelection?... Now that I look at SetSelectedItemAsync method, it might be a bug. With SingleSelection it selects the item but does not add it to the Selection. So it doesn't appear checked. But it is still in SelectedItem. Which I find weird to have selected item not be selected visually but internally yes. Btw, as the name implies, should you be able to select multiple rows with SingleSelection (which you can do if you click on the checkboxes)? Shouldn't it be max 1 row selected? I mean visually, internally it is.
https://try.mudblazor.com/snippet/muwduBxPhiXfrJGK


md5 32 encryption

How to use the md5 32-bit encryption method, can it be added？

It's already implemented:
{{md5("test")}}


Auto resolve circular dependencies

Will this program support auto resolve circular dependencies feature in future?

Hey @fpemud!
Probably it will.
This program will have it's own parser that will read logs from Portage and try to make sense of them.
Parser will serve 2 purposes:

send an update report via email/IRC to users about what has happened during an update;
try to solve errors during an update, like masked/blocked packages, build failures etc.;

There are some difficulties with solving circular dependencies, however. Fist, it's usually an invasive procedure that requires deleting packages which can break the system if done automatically or incorrectly. Second, it's a bit hard to reproduce.
In any case, solving circular dependencies will not be done in the scope of Google Summer of Code 2023 (so not before September 2023), but I will most likely work on it afterwards 🙂
It will be very helpful to have a reproducible test suite, like a container or steps to recreate the circular dependency problem. Also if you have any links to Gentoo's Bugzilla where this issue was reported, it will be very helpful as well.

What this really needs is an implementation for https://bugs.gentoo.org/175808 (where Portage already demonstrates it knows what to do) to make Portage actually queue packages twice in the same run.

Probably it will. This program will have it's own parser that will read logs from Portage and try to make sense of them. Parser will serve 2 purposes:

This part, of course, is inextricably linked with https://wiki.gentoo.org/wiki/Google_Summer_of_Code/2023/Ideas#portage_machine_readability.

What this really needs is an implementation for https://bugs.gentoo.org/175808

@thesamesam  please correct me if I misunderstood the comments in bug.
It seems that with --autounmask-continue flag emerge can already resolve circular dependency problem by configuring correct USE flags, is that right?

This part, of course, is inextricably linked with https://wiki.gentoo.org/wiki/Google_Summer_of_Code/2023/Ideas#portage_machine_readability.

I agree. In my proposal I mentioned that it would be awesome if both projects got accepted, because using json/yaml output from portage is much more convenient and reliable than parsing logs, and of course is the preferred method.
However, me and @afalko decided on a parser for now because (although not an ideal solution) it is just simpler to implement at the current moment (I only have a bit more than 2 months to complete the project).


Fix bug in variable decrement & comparison in post-start

Hi,
This PR fixes (minor) bugs in post-start script of elasticsearch. The corner case of timeouts was not handled correctly and are fixed with this PR.
See commit message for details.
Kindly review & let me know your comments!
Thanks,
Hari

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Infra-Red any chance of a formal release which includes this fix?

@jpluscplusm I'll verify latest changes and schedule release for tomorrow.


Add to Bower

Hi,
This is a bit of a minor improvement (as it's possible to install manually via "bower install glibin/smartapp-banner", but it would help to have this package available in Bower as well.  :)
I've added a bower.json (which gets rid of some of the warnings when installing via the github repo path) but you will need to register the repo per here: http://bower.io/docs/creating-packages/
Thanks for creating this module!  It's nice that it's jquery-free.

Merged, thanks!


change: better result and IO assertions in CLI tests

Description
Changed the helpers that assert empty IO and results to macro rules, so the test errors show the line within the test case, not the helper definition.
I would love to find a way to show the error at the line of the MockIO that caused the error, but it's more tricky here in Rust than would be in Scala with the scope implicit.
Checklist

[x] Commit sequence broadly makes sense and commits have useful messages.
[x] New tests are added if needed and existing tests are updated.
[ ] Relevant logging and metrics added
[x] CI passes. See note on CI.
[ ] Any changes are noted in the changelog.md for affected crate
[x] Self-reviewed the diff

Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges.  Please contact IOG Partner Chains developers to do this
for you.

I understand the idea is to make sure that operations that have been defined to be carried out via MockIOContext should actually be carried out and the test should fail if that is not the case. That makes sense.
Searching around I found a suggestion that would boil down to implementing Drop for MockIOContext. So the dropwould check if !self.expected_io.borrow().is_empty() and panic if not.
Entirely possible that this doesn't work or doesn't make sense for some reason - You let me know ;)

I understand the idea is to make sure that operations that have been defined to be carried out via MockIOContext should actually be carried out and the test should fail if that is not the case. That makes sense.
Searching around I found a suggestion that would boil down to implementing Drop for MockIOContext. So the dropwould check if !self.expected_io.borrow().is_empty() and panic if not.
Entirely possible that this doesn't work or doesn't make sense for some reason - You let me know ;)

This is a much better approach and I will switch this PR to it once I'm done with more important tasks!


VxMapRemapPatch - Fix

Fix - Conditional jump on uninitialized value

@LakshmiKumar23 can you verify the fix for VxMapRemapPatch?

@LakshmiKumar23 can you verify the fix for VxMapRemapPatch?

@kiritigowda I still see the random fails. I ran it thrice, and it failed twice. The random fail is still seen

@LakshmiKumar23 can you verify the fix for VxMapRemapPatch?

@kiritigowda I still see the random fails. I ran it thrice, and it failed twice. The random fail is still seen

can you send me your run command?

@LakshmiKumar23 merging this to fix the Conditional jump on uninitialized value will look into remap patch again. Could not reproduce the failure after this fix.


NixOS installer tests: Add a test using Gummiboot

Issue #14956. Note that unfortunately doesn't catch the bug in #14902 as that happens only with nix.package overridden.

 I'm pretty sure our test framework doesn't boot with uefi mode enabled

@dezgeg Wow that was fast. Looks good, I'm giving it a try.
@shlevy Are you sure? This should force Qemu to boot with only UEFI support. The same is done for the ISO booting tests.

It does work for me, this is the part of the log after the first reboot: https://gist.github.com/dezgeg/5f82f3cbffdb1a94e9c121ff6b76f98d... though now I see the initial boot might not be booting in UEFI mode.

It's booting correctly here too. It indeed seems the installer itself somehow isn't booting with UEFI. I added:
virtualisation.useEFIBoot = mkIf (bootLoader == "gummiboot") true;

to the machine configuration, but it still doesn't seem to boot using EFI.
I was thinking ideally you'd want to use the ISO for booting the installer. That is a more real-life scenario and I know that supports EFI. However, since we already have the boot tests for the ISO, that functionality is already covered by those tests. So, ideally, but not that important.
That said, it's about the second boot. That certainly boots with EFI with this PR (I see EFI related output from the kernel), so this is better than what we had before. This combined with the ISO boot tests should cover most of what is needed for EFI installations.
I guess it doesn't hit the #14902 issue because it doesn't change the gummiboot configuration when it executes nixos-rebuild switch. Not sure if it's worth doing something about that.
Other than that, :+1:

I guess it doesn't hit the #14902 issue because it doesn't change the gummiboot configuration when it executes nixos-rebuild switch.

No, it does not hit that because that requires nix.package to be set by the user. If I add this:
diff --git a/nixos/tests/installer.nix b/nixos/tests/installer.nix
index c9aa9f9..515405a 100644
--- a/nixos/tests/installer.nix
+++ b/nixos/tests/installer.nix
@@ -35,6 +35,7 @@ let
         ''}

         hardware.enableAllFirmware = lib.mkForce false;
+        nix.package = pkgs.nixStable;

         ${replaceChars ["\n"] ["\n  "] extraConfig}
       }
@@ -211,6 +212,7 @@ let
                 pkgs.gummiboot
                 pkgs.perlPackages.XMLLibXML
                 pkgs.perlPackages.ListCompare
+                pkgs.nixStable
               ]
               ++ optional (bootLoader == "grub" && grubVersion == 1) pkgs.grub
               ++ optionals (bootLoader == "grub" && grubVersion == 2) [ pkgs.grub2 pkgs.grub2_efi ];

...then I do get the error in #14902:
machine# copying NixOS/Nixpkgs sources...
machine#
machine# *** Copying ‘/nix/store/yzcyinv0zh62w9cw50gxzjfsdjv2qjvj-nixos-16.09pre-git’ from ‘/tmp/root/nix/store/yzcyinv0zh62w9cw50gxzjfsdjv2qjvj-nixos-16.09pre-git’
machine#
machine# created 1 symlinks in user environment
machine# finalising the installation...
machine# Created /boot/EFI.
machine# Created /boot/EFI/gummiboot.
machine# Created /boot/EFI/Boot.
machine# Created /boot/loader.
machine# Created /boot/loader/entries.
machine# Copied /nix/store/23ymqlw874az7fm5qb1y0hf84hcjh4n3-gummiboot-48/lib/gummiboot/gummibootx64.efi to /boot/EFI/gummiboot/gummibootx64.efi.
machine# Copied /nix/store/23ymqlw874az7fm5qb1y0hf84hcjh4n3-gummiboot-48/lib/gummiboot/gummibootx64.efi to /boot/EFI/Boot/BOOTX64.EFI.
machine# Traceback (most recent call last):
machine#   File "/nix/store/mwlr2f6s9zwfi3gfq40aljnp3yv67bds-gummiboot-builder.py", line 112, in <module>
machine#     gens = get_generations("system")
machine#   File "/nix/store/mwlr2f6s9zwfi3gfq40aljnp3yv67bds-gummiboot-builder.py", line 67, in get_generations
machine#     "--option", "build-users-group", ""
machine#   File "/nix/store/8gv8s398yqbwfk01x29x1b5hhfq29s8k-python-2.7.11/lib/python2.7/subprocess.py", line 566, in check_output
machine#     process = Popen(stdout=PIPE, *popenargs, **kwargs)
machine#   File "/nix/store/8gv8s398yqbwfk01x29x1b5hhfq29s8k-python-2.7.11/lib/python2.7/subprocess.py", line 710, in __init__
machine#     errread, errwrite)
machine#   File "/nix/store/8gv8s398yqbwfk01x29x1b5hhfq29s8k-python-2.7.11/lib/python2.7/subprocess.py", line 1335, in _execute_child
machine#     raise child_exception
machine# OSError: [Errno 2] No such file or directory
machine: exit status 1
machine: output:
error: command `nixos-install < /dev/null >&2' did not succeed (exit code 1)
command `nixos-install < /dev/null >&2' did not succeed (exit code 1)
cleaning up

You all rock - keep this one pushing as booting the the most critical part of OS.

Ah sorry, indeed. Should something similar be incorporated into this PR as
well?
On Mon, Apr 25, 2016, 08:28 Domen Kožar<EMAIL_ADDRESS>wrote:

You all rock - keep this one pushing as booting the the most critical part
of OS.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/14957#issuecomment-214154423

Ah, missed the OMVF line, cool

Merging as it's already an improvement. Further refinements can be done in further PRs.


Add iostat output

add iostat output  , just a simple table

great.
Is that also possible with iotop?


feat(konflux): adjust pipelines and add renovate.json

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.35%. Comparing base (ed2ee81) to head (be97050).

Additional details and impacted files

@@                     Coverage Diff                      @@
##           appstudio-policies-frontend     #430   +/-   ##
============================================================
  Coverage                        88.35%   88.35%
============================================================
  Files                              115      115
  Lines                             2490     2490
  Branches                           491      491
============================================================
  Hits                              2200     2200
  Misses                             275      275
  Partials                            15       15


Cannot find name 'res' and other syntax errors

Angular 2 newbie here.
Thanks John Papa for awesome tutorial. I don't know if this is the right place to post this, but I am posting anyway.
I'm using webpack and following the ng-conf presentation. When I run npm start I get following error
ERROR in ./src/app/service/mock-data-service.service.ts
(13,25): error TS1005: '=>' expected.

ERROR in ./src/app/service/mock-data-service.service.ts
(13,27): error TS1005: ';' expected.

ERROR in ./src/app/service/mock-data-service.service.ts
(13,40): error TS1005: ';' expected.

ERROR in ./src/app/service/mock-data-service.service.ts
(13,30): error TS7027: Unreachable code detected.

ERROR in ./src/app/service/mock-data-service.service.ts
(13,30): error TS2304: Cannot find name 'res'.
Child html-webpack-plugin for "index.html":
    chunk    {0} index.html 512 kB
         + 3 hidden modules
webpack: bundle is now VALID.

and my contents in mock-data-service.service.ts are
import { Injectable } from '@angular/core';
import {Http, Response} from '@angular/http';
import 'rxjs/add/operator/map';

@Injectable()
export class MockDataService {

  constructor(private http: Http) {
  }

  getMockData() {
    return this.http.get('./src/database/mockdata.json')
    .map((res: Response)) => res.json());
  }

}

You can view the full picture here

@ksharifbd you have a typo. Replace:
 .map((res: Response)) => res.json());

to
 .map((res: Response) => res.json());


Add reverse-dep tests for packit-service

It should work now, here I tried to break the p-s and it failed.
Fixes #742

recheck

recheck


No such file or directory for AudioAnalysis.py, even though I added it to bashrc?

Hi!
I'm trying to run audioAnalysis.py on a directory of wav files. I've gone through the installation steps of cloning locally. That said, I'm not sure if I'm editing my bashrc.sh profile correctly, as I'm getting the following error:
python: can't open file 'audioAnalysis.py': [Errno 2] No such file or directory
Here's what my bashrc.sh file looks like after editing:
source /etc/bash.bashrc source ~/.bashrc export PYTHONPATH=$PYTHONPATH:"/Users/davegoldblatt/pyAudioAnalysis"   PS1="$"
Any ideas?
Thanks in advance!

Nevermind, typo in the directory path :p


Logger questions

Is it possible to write logs into files?  and where is the default log file location?
I wonder if I can user Nlogger in the project?

I can implement something like that, but I don't recommend write logs into files.


Enable Cookie auth with requests

Added possibility to use Cookie Auth when consuming the rest services in client scripts on the same site.
Localize your scripts with an object with root-url and nonce:
function my_enqueue_scripts() {
    wp_enqueue_script( 'app', get_template_directory_uri() . '/assets/dist/bundle.js', array(), false, true );
    wp_localize_script( 'app', 'WP_API_Settings', array(
        'root' => esc_url_raw( get_json_url() ),
        'nonce' => wp_create_nonce( 'wp_json' ) )
    );
}
add_action( 'wp_enqueue_scripts', 'my_enqueue_scripts' );

And use this nonce when initialising the library:
var WP = require( 'wordpress-rest-api' );
var wp = new WP({
    endpoint: window.WP_API_Settings.root,
    nonce : window.WP_API_Settings.nonce
});

Thanks for this! Would you be able to add a unit test to verify that the correct property gets set on the response, and validate that the tests pass once you've done so? If not I can tackle that later this week.

Hi, yes will look into it, and fixing those CI errors as well!

Hi, was a little unsure where to add the test, in the ".post()" test in tests/lib/shared/wp-request.js adding an
´´´javascript
wpRequest._options.nonce = 'xxx';
´´´
would break the test since the auth() method would never be called then. So maybe I leave that for you.
But have fixed the stuff that broke the travis-ci and added a section to the Readme.mb about how to use Cookie Auth.

Thanks, @gerhardsletten. I'll try to take care of the rest this weekend!—apologies for the delay, it's been a busy week!


Add linter

Needs to have a linter just like table baseline and form baseline

Linter has been added.


adding license at the end of every file for CC-BY-SA

I, James Schloss, the copyright holder of this work, irrevocably grant anyone the right to use the Algorithm Archive, including derivatives created during the review process, under the Creative Commons Attribution ShareAlike 4.0 license (legal code). (Anyone may use, share or remix this work, as long as they credit the appropriate author and share any derivative work under this license.)
This means that all previous versions of the Algorithm Archive before this point are still under CC-NC, but all versions beyond this point will be appropriately attributed to the author of each chapter and chapter editors.
Full discussion can be found in the #493.

I think we need to modify the license section a bit to also include graphics and PRs and be more structured. I thought of something like this for the License section:
License
Text
The text of this of this chapter by PERSON, PERSON, ... and PERSON is licensed under CC BY-SA 4.0.
Code
The code examples are licensed under the MIT license (found in LICENSE.md).
Images/Graphics

The first image "IMAGENAME" by PERSON is licensed under CC BY-SA 4.0.
The second image "IMAGENAME" by PERSON is licensed under CC BY-SA 4.0.
...
The nth image "IMAGENAME" by PERSON is licensed under CC BY-SA 4.0.

Pull Requests
The following Pull Requests changed this chapter:

#560
PR
...

Changes

I changed the wording for the attribution a bit. This way it's shorter and complies with https://wiki.creativecommons.org/wiki/Best_practices_for_attribution
The new images/graphics section allows us to credit the author of each image/graphic properly.
The new PR section enables the reader to easily comprehend the progress of the chapter creation.
The general structure allows for an easier overview.

To comply with https://wiki.creativecommons.org/wiki/Best_practices_for_attribution (and since it's good to do so) we should also try to make IMAGENAME and PERSON links, if possible.
For new chapter contributions we can then ask each person easily how they want to be linked.

Since two of the images were created by me, more specifically: "split_op_method" and "huffman_tree", here's also my statement (I don't know, if it's really needed, but it doesn't hurt for sure).
I, Julian Schacher, the copyright holder of the images "split_op_method" and "huffman_tree", irrevocably grant anyone the right to use this work, including derivatives created during the review process, under the Creative Commons Attribution ShareAlike 4.0 license (legal code).
(Anyone may use, share or remix this work, as long as they credit me and share any derivative work under this license.)

Cool, thanks for catching those!


Add option to configure StrictHostKeyChecking for SSH connection

@ryantemple thank you, but the project is now standalone, can you make the change in this project https://github.com/shipitjs/shipit ?

Yeah sure no problem - will update the standalone project
On 25 January 2015 at 17:40, Greg Bergé<EMAIL_ADDRESS>wrote:

Closed #48 https://github.com/shipitjs/grunt-shipit/pull/48.
—
Reply to this email directly or view it on GitHub
https://github.com/shipitjs/grunt-shipit/pull/48#event-224332530.


AVL Tree

Added AVL tree implementation

@sakshikhachane Thanks for contributing! 🎉
Please remove the extra source files. (Bucket Sort & Kadane's Algorithm)

@amanmehara I have removed the files. Sorry for such a mistake.


fix(rbac): added unit test for AdminPage

Description
Add unit test for AdminPage merged in #989
PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[x] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Snice https://github.com/janus-idp/backstage-showcase/pull/989 is cherrypicked to 1.1.x, evidently this should be too.
/cherry-pick 1.1.x

Cherrypick failed, see https://github.com/janus-idp/backstage-showcase/pull/1019 for manual PR + merge.


.take problem

The take command doesn't seem to give me any currency but it reduces the target's balance.

It's weirdly named. Take does not take. it removes. It's the opposite of award.


Show side by side doesn't work

In Windows 8.1, I'm facing the problem of not being capable of Showing windows side by side with Brackets.
If I click Windows Bottom Tool Bar > Show windows side by side, Brackets' window won't re-size.

Thanks for reporting this. This use case I think was never tested for or reported in windows till now.
Most probably and issue with native shell.


[FIX-10784][Bug] [ALERT-SERVER] FEISHU Plugin might block the whole alert process loop

Purpose of the pull request
closed #10784
Brief change log

dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/AlertConfig.java
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/java/org/apache/dolphinscheduler/alert/AlertSenderService.java
dolphinscheduler-alert/dolphinscheduler-alert-server/src/main/resources/application.yaml
dolphinscheduler-standalone-server/src/main/resources/application.yaml

Verify this pull request
This pull request is already covered by existing tests, such as dolphinscheduler-alert/dolphinscheduler-alert-server/src/test/java/org/apache/dolphinscheduler/alert/runner/AlertSenderServiceTest.java.

Codecov Report

Merging #10888 (4f6c57d) into dev (aa8b88a) will increase coverage by 0.00%.
The diff coverage is 72.72%.

:exclamation: Current head 4f6c57d differs from pull request most recent head 74907e2. Consider uploading reports for the commit 74907e2 to get more accurate results

@@            Coverage Diff            @@
##                dev   #10888   +/-   ##
=========================================
  Coverage     40.13%   40.14%
- Complexity     4843     4844    +1
=========================================
  Files           940      940
  Lines         36945    36948    +3
  Branches       4033     4028    -5
=========================================
+ Hits          14828    14831    +3
+ Misses        20630    20626    -4
- Partials       1487     1491    +4

Impacted Files
Coverage Δ

...org/apache/dolphinscheduler/alert/AlertConfig.java
0.00% <0.00%> (ø)

...che/dolphinscheduler/alert/AlertSenderService.java
56.39% <100.00%> (+2.06%)
:arrow_up:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.00% <0.00%> (-1.39%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.60% <0.00%> (-0.30%)
:arrow_down:

...eduler/api/service/impl/DataSourceServiceImpl.java
29.49% <0.00%> (ø)

.../dolphinscheduler/plugin/task/datax/DataxTask.java
0.00% <0.00%> (ø)

...cheduler/plugin/task/api/ShellCommandExecutor.java
0.00% <0.00%> (ø)

...er/api/service/impl/TaskDefinitionServiceImpl.java
24.01% <0.00%> (+0.05%)
:arrow_up:

...hinscheduler/plugin/alert/wechat/WeChatSender.java
29.78% <0.00%> (+0.20%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8b88a...74907e2. Read the comment docs.

I had rerun the failed CI.

LGTM if CI pass

I'll deal with it

I had rerun the failed CI.

CR, Please

Please CR @caishunfeng

LGTM,GOOD JOB Please check e2e failures. thanks! dolphinscheduler-e2e-case: There are test failures.

ok! done!


add StatementRefs. Closes #39 and #99.

This makes it possible to, for example, have a StatementTemplate for "reviewing accomplishment" statements where the actor reviews an object agent, then have another StatementTemplate for "has been judged competent in" statements that must have a context statement StatementRef pointing at "reviewing accomplishment" statements.
Also includes a variety of other clarifying language related to this change, some of which should be reviewed for inclusion if this PR is rejected.

+1, "If the referenced Statement is available to the checking system, it MUST be checked for matching the given Statement Template, but if it is not, it MUST be assumed to match the given Statement Template. If all the rules are fulfilled, and the StatementRefs check out, then the statement matches the template."
I like this change, seems like the logical way to check statements with StatementRefs against Statement Templates

Consensus: merge, evaluate as the whole spec gets looked at

"the Learning Record Provider MUST make it the UUID of a Statement matching at least one of the specified Statement Templates."
Does the referenced statement then have to be received by the LRS before the referencing statement? What if they come in a batch? What about paging via more links?
I'd be inclined to make this a SHOULD as very difficult to validate unless it's made over restrictive.

@garemoko agreed on difficulty of validating, which is why the behavior of the LRP is a MUST, but the validating system is given this language:

Additionally, check if the object StatementRef and context StatementRef requirements are met. If the referenced Statement is available to the checking system, it MUST be checked for matching the given Statement Template, but if it is not, it MUST be assumed to match the given Statement Template.