Documentation: Falco <-> libs versioning (more details)

Based on the discussion in https://github.com/falcosecurity/libs/pull/580 additional documentation in this repo (falco) can help increase technical clarity around versioning.

https://github.com/falcosecurity/libs/pull/580#discussion_r964497282
https://github.com/falcosecurity/libs/pull/580#discussion_r964522134

CC @leogr

Hello there, Can I work for this one??

@h20220025 for sure! Any help is welcome. I don't think solid workstream for this has started yet, but I think either this issue or the Slack channel might be the right places to discuss about this.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Hey @h20220025
PR https://github.com/falcosecurity/falco/pull/2205 has already addressed this issue in an excellent way!
@incertum :pray:
If you think there's more to add, feel free to open a PR.
/close

@leogr: Closing this issue.

In response to this:

Hey @h20220025
PR https://github.com/falcosecurity/falco/pull/2205 has already addressed this issue in an excellent way!
@incertum :pray:
If you think there's more to add, feel free to open a PR.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Fix failing to print report of repository with never used library

Fixes #63

Codecov Report

Merging #70 (f65f91e) into main (49c46ac) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

:exclamation: Current head f65f91e differs from pull request most recent head 4f65534. Consider uploading reports for the commit 4f65534 to get more accurate results

@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   94.34%   94.22%   -0.13%
==========================================
  Files          14       14
  Lines         814      814
==========================================
- Hits          768      767       -1
- Misses         46       47       +1

Impacted Files
Coverage Δ

sherlock/model.py
92.88% <100.00%> (ø)

sherlock/report/json.py
92.85% <0.00%> (-7.15%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c46ac...4f65534. Read the comment docs.


TiKV store size among TiKV nodes are very different after Titan is enabled

Bug Report

What version of TiKV are you using?

What operating system and CPU are you using?

Steps to reproduce

Enable Titan and prepare some data with Sysbench wide-table prepare
What did you expect?
Store size on TiKV nodes are roughly same
What did happened?
Store size is different due to different compression rate

The reason is the compression rate of RocksDB data and Titan data is different. And each node's Titan data percentage is different which is by design.

@tonyxuqqi for this issue, we should add 6.5, 7.1 right?

maybe dup with https://github.com/tikv/tikv/issues/16055

https://github.com/tikv/tikv/issues/16055


Add initial implementation

Initial checklist

[x] I read the support docs
[x] I read the contributing guide
[x] I agree to follow the code of conduct
[x] I searched issues and couldn’t find anything (or linked relevant results below)
[x] If applicable, I’ve added docs and tests

Description of changes
This is the initial implementation of unist-lsp.

@remcohaszing done?

Yep, IMO this is good to go. :+1:

PS I do the following in settings on new repos:

turn wiki’s off
turn merge/rebase off
change squash to “default to pull request title” (I think this is new, will have to see if this works well)
turn on suggest updating branches, auto-merge, and auto-delete branches

Meh, github-tools/npm-tools pause after like 90 days or so. Reactivated them.

Ready for a release too I presume?

Meh, github-tools/npm-tools pause after like 90 days or so. Reactivated them.

Annoying!

Ready for a release too I presume?

Yep! Let’s make it version 1.0.0.

Are you sure it’s wise not to add a main to package.json. Despite what Node says in their docs, not everyone is using Node.
Not blocking to me, we can see if this works fine. But I’d err on the side of having it.

Also, is rimraf no longer needed for tsc?

Bundlephobia is reporting a dep is missing<EMAIL_ADDRESS>Not sure which one, and why?

Also, is rimraf no longer needed for tsc?

I’m not running into any issues anyway.

Bundlephobia is reporting a dep is missing<EMAIL_ADDRESS>Not sure which one, and why?

Oops! #2


trait bound error when nesting Reflect types in a HashMap inside another Reflect type

Having a HashMap with a Reflect type as the key inside another Reflect type produces this error:
error[E0277]: the trait bound `std::collections::HashMap<Thing, u32>: bevy::prelude::Reflect` is not satisfied
 --> examples/hello_world.rs:9:19
  |
9 | #[derive(Default, Reflect)]
  |                   ^^^^^^^ the trait `bevy::prelude::Reflect` is not implemented for `std::collections::HashMap<Thing, u32>`
  |
  = help: the following implementations were found:
            <std::collections::HashMap<K, V, ahash::random_state::RandomState> as bevy::prelude::Reflect>
  = note: required for the cast to the object type `dyn bevy::prelude::Reflect`
  = note: this error originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info)

Bevy version
9239621f
Operating system & version
Arch Linux
What you did
This example demonstrates the error:
 use std::collections::HashMap;
 use bevy::prelude::*;
 use serde::{Serialize, Deserialize};

 fn main() {
     App::build().run();
 }

 #[derive(Default, Reflect)]
 struct ThingContainer {
     things: HashMap<Thing, u32>
 }

 #[derive(Clone, PartialEq, Eq, Hash, Serialize, Deserialize, Reflect)]
 #[reflect_value(PartialEq, Serialize, Deserialize)]
 enum Thing {
     One,
     Two,
 }

What you expected to happen
I expect to be able to nest Reflect structs inside other Reflect structs, even if there's a collection involved.
What actually happened
Doesn't compile

Looking into this a bit more, there is an implementation for bevy_utils::HashMap but not for std::collections::HashMap. The difference is that bevy_utils::HashMap is pub type HashMap<K, V> = std::collections::HashMap<K, V, RandomState>;
@cart mentioned on discord that he expected this to work, but is the expectation that it work with the vanilla std HashMap or only with the tweaked bevy_utils::HashMap?


[stable/kubernetes-dashboard] Clean up cluster-service label

What this PR does / why we need it:
kubernetes.io/cluster-service label is deprecated by kube-addon-manager. The label is used by kubectl cluster-info only for kind: Service resources.
The PR removes the label usage from kubernetes-dashboard chart for non kind: Service resources.
Ref kubernetes/kubernetes#72757
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[ ] Variables are documented in the README.md
[x] title of the PR contains starts with chart name e.g. [stable/chart]

/assign @desaintmartin

/assign @kfox1111

/lgtm

After this change, helm upgrade will come to:
Error: Deployment.apps "kubernetes-dashboard" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"release":"kubernetes-dashboard", "app":"kubernetes-dashboard"}: `selector` does not match
template `labels` && Ingress.extensions "kubernetes-dashboard" is invalid: spec.rules[0].http.paths: Required value

You need to delete the release or helm upgrade --force


Timeout creating networking resources on private GKE cluster

Full reproduction from scratch!

NAME           LOCATION        MASTER_VERSION  MASTER_IP      MACHINE_TYPE   NODE_VERSION   NUM_NODES  STATUS
istio-test     europe-west1-b  1.15.7-gke.23   <IP_ADDRESS>  n1-standard-2  1.15.7-gke.23  1          RUNNING

How was Istio installed?
$ istioctl manifest apply

Verify Istio system workloads are healthy. :heavy_check_mark:
Attempt to create a gateway:
$ kubectl create -f - <<EOF
---
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: http-gateway
spec:
  selector:
    istio: ingressgateway
  servers:
  - port:
      number: 80
      name: http
      protocol: HTTP
    hosts:
    - "*"
EOF

Observed behaviour
Error from server (Timeout): error when creating "STDIN": Timeout: request did not complete within requested timeout 30s

Expected behaviour
gateway/http-gateway created

Version
$ istioctl version --remote

client version: 1.4.3
control plane version: 1.4.3
data plane version: 1.4.3 (1 proxies)

$ kubectl version

Client Version: version.Info{Major:"", Minor:"", GitVersion:"v0.0.0-master+70132b0f13", GitCommit:"70132b0f130acc0bed193d9ba59dd186f0e634cf", GitTreeState:"", BuildDate:"1970-01-01T00:00:00Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.7-gke.23", GitCommit:"06e05fd0390a51ea009245a90363f9161b6f2389", GitTreeState:"clean", BuildDate:"2020-01-17T23:10:45Z", GoVersion:"go1.12.12b4", Compiler:"gc", Platform:"linux/amd64"}

@dylanpiergies It's because the master can not reach the node VM. You have to create a firewall rule for tcp:9443 port that used by the galley webhook validation. https://cloud.google.com/kubernetes-engine/docs/how-to/private-clusters#add_firewall_rules
Or you can use this script for creating the GCP firewall rule. https://gist.github.com/ismailbaskin/d7222dc7a74807431399ecff9e259792

@ismailbaskin Yeah. Creating a suitable firewall rule solves this. Thank you. :)


Do not depend on http4s' cats-effect version transitively

It seems we're using the cats-effect version from http4s transitively: https://github.com/47degrees/github4s/pull/501#discussion_r433683082.
It'd be better to depend on it directly I think.

I hear there's an awesome sbt plugin called sbt-explicit-dependencies that can find issues like this for you


Refactor nv plugins

Refactor NV plugins:

Removes computation of not needed parameters.
Adds new plugin which computes the summed waveform for NV events.
Some minor readability changes

Requires https://github.com/AxFoundation/strax/pull/744 to be merged. After meging this PR we need to change the data types which are produced and shipped from the EBs. In addition, to hitlets, events_nv and event_positions_nv, event_wavefrom_nv must be made and shipped. The total amount of compressed data will be ~30 % smaller than before.

Long time no news converting into draft.

Tests can only pass once the strax PR is merged

coverage: 91.161% (+0.3%) from 90.816%
when pulling 327fa7975b17d51edb80d03072b22ea0e4d792cd on refactor_nv_plugins
into c1eda3e63bbcfe29efc81fdd5ad2bfafec1eebaf on master.


js_build.sh error

ERROR in ./javascripts/explore/explore.jsx
Module not found: Error: Cannot resolve 'file' or 'directory' ../../node_modules/bootstrap-toggle/js/bootstrap-toggle.min.js in /Users/robbin/Documents/www/caravel/caravel/assets/javascripts/explore
 @ ./javascripts/explore/explore.jsx 33:0-73

ERROR in ./javascripts/explore/explore.jsx
Module not found: Error: Cannot resolve 'file' or 'directory' ../../node_modules/bootstrap-toggle/css/bootstrap-toggle.min.css in /Users/robbin/Documents/www/caravel/caravel/assets/javascripts/explore
 @ ./javascripts/explore/explore.jsx 38:0-75

ERROR in ./visualizations/filter_box.jsx
Module not found: Error: Cannot resolve module 'react-select' in /Users/robbin/Documents/www/caravel/caravel/assets/visualizations
 @ ./visualizations/filter_box.jsx 13:19-42

ERROR in ./~/css-loader!./~/less-loader!./stylesheets/react-select/select.less
Module build failed: Cannot resolve 'file' or 'directory' ../../node_modules/react-select/less/spinner.less in /Users/robbin/Documents/www/caravel/caravel/assets/stylesheets/react-select
 @ /Users/robbin/Documents/www/caravel/caravel/assets/stylesheets/react-select/select.less (line 93, column 0)
 near lines:
   @import "../../node_modules/react-select/less/multi.less";
   @import "../../node_modules/react-select/less/spinner.less";

I need run below command,then it's ok
npm  install bootstrap-toggle react-select --save

@robbinhan which version of caravel is that? have you upgraded without running npm install again?

I just pushed a fixed to package.json, should be good now.

@mistercrunch bootstrap-toogle is still missing though?


Added flags to coverage upload depending if it is a PR or a push and …

…updated badge icon to point only to master flag

Thanks for your interest @ghandic! I was checking that there's no need to use flags, it's possible to use the same current badges pointing to master.
But still, it seems that leaving them as they are they already point to master. I just created a broken PR here: https://github.com/tiangolo/fastapi/pull/4887 removing lots of tests, that would reduce the coverage. But the badges still seem to show 100%, so it seems that by default they show the percentage of master.
Given that, I'll close this PR now, but thanks for the effort!


Port as pkg to ROS2

Before build, please run
$ rosdep update
$ rosdep install --from-paths src -i --rosdistro=$ROS_DISTRO

to install dependencies (pacmod-msg, automotive-msg, etc).
Then,
$ colcon build --packages-up-to as
$ ros2 run as  pacmod_interface --ros-args -p vehicle_info.wheel_base:=3.0 -p vehicle_info.wheel_radius:=0.5

to test the node.
I had some trouble with the usage of the message_filters. So I wrote the same way as in Autoware.Auto. Please check if it is correct.

We also need to decide how to handle the global parameter, such as vehicle_info.wheel_base.

this is ready for review

Also, if you can, using ament_auto in CMakeLists.txt is great. See https://github.com/tier4/Pilot.Auto/pull/7/commits/ef382a9b430fd69cb0a0f7ca57016d66ed7ef29d for an example.

I changed to the auemt_auto style and pushed. I'm not confident about the usage, so would check the CMakeList?

Looks good, I'd say after those small CMakeLists.txt issues it can be merged! I already approved.

For the global parameter such as vehicle_info.wheel_base, we have decided to handle them as just a local parameter for now.
There is still the deprecated Float32 issue. We can discuss this in the next daily mtg.


Test the Managed AMI image for PG and ES  (AWS and Azure)

we have to setup the cluster of PG in AWS (manage by AWS ).
Post that we need to use the PG cluster in the A2HA exiting setup.
If it work in that case we need to find, how customer will make use of its existing PG if customer wants.
Q. If we install A2HA setup, we need to provide the number of node in PG cluster.

Acceptance Criteria
We support all the existing A2HA functionalists with the Managed services.
Definition of Done

Installation of A2HA Cluster (Deployment).
Backup and Restore works
Support the Upgrade for FE and BE.
Support the DR.
Extra Documentation if required.
Documentation for the deprecated command
Few command won't work if we use the Managed Services.
If all the above points we support's, we need to  Modify the some of the scripts.

Testing Steps

Deployment
Addition of New FE/BE nodes to the existing Infrastructure.
Backup and Restore.


Add condition to check for definition of "provider"

Fixes #1056

looks like there is an issue with the switch to multi-line syntax:
aws:
TASK: [lvm | Create volume group] *********************************************
failed: [mantl-ci-289-1-control-01] => {"failed": true}
msg: Device " /dev/xvdh " not found.
...

gce:
TASK: [lvm | Create volume group] *********************************************
failed: [mantl-ci-289-3-control-02] => {"failed": true}
msg: Device " /dev/disk/by-id/google-lvm " not found.

I just tried to fix it, but I'm having trouble testing on GCE, AWS, and OS :(

Looks like the whitespace issue is fixed, I'm unsure what's happening now:
msg: Device "/dev/xvdh" not found.

I'm going to try removing the quotes.

Looks like that did it! Build is passing on AWS.

+1 on GCE. lgtm

Thanks for testing @ryane, sorry for the oversights!


VS Code is automatically taking my C Drive in explorer.

Issue Type: Feature Request
Hello Team,
I am having issue while installing application Visual Studio Code Application. I want someone's guidance in installing it as it is taking my C drive name directly.
Regards,
Bhabesh Dutta
VS Code version: Code 1.54.2 (fd6f3bce6709b121a895d042d343d71f317d74e7, 2021-03-11T00:56:19.848Z)
OS version: Windows_NT x64 10.0.19042

See https://code.visualstudio.com/docs/editor/portable for how to set up a VS Code instance without using any C-drive space.

@gjsjohnmurray thanks.
Will close the issue. Please ping if there is still something unclear with clear steps about what you try to achieve and why it fails.


Outdated lockfile

Rust Book FAQ
Please update the lock file prior to tagging, so the package can be built using cargo.lock. Currently this is not possible.

Oops. Most of my Rust releasing so far had been for libraries (99%) so I hope it's understandable that I made this mistake.
I'll fix, re-tag/release but unfortunately can't fix the cargo release so I'll just roll-out another release.

No problem, thank you!


InfluxDB secrets specified in multiple places

Is your feature request related to a problem? Please describe.
The passwords for InfluxDB are stored in the secrets.yaml file under influxDB.users and prometheus.remoteWrite. Obviously, the password for remote write must match one of the InfluxDB user passwords to make things work, but this is not mentioned anywhere and there is no explanation for these fields. (Comments in the secret "templates" are stripped.)
influxDB:
  users:
    adminPassword: somelongsecret
    wcWriterPassword: somelongsecret
    scWriterPassword: somelongsecret
...
prometheus:
  remoteWrite:
    # Same as the password for the 'influxDB.users.wcWrtier' user in 'sc-config.yaml'.
    password: somelongsecret

Describe the solution you'd like
The password(s) for remote write should not be duplicated (if possible). And in either case it should be made clear what each password is supposed to be used for.
Describe alternatives you've considered
Keep duplicate copies of the passwords (e.g. sc-secrets.yaml and wc-secrets.yaml to match the current sc-config.yaml and wc-config.yaml) to make multiple WCs easier. In this case it would be helpful to use the same field in each file to make it obvious what should match. For example, store the password at influxDB.users.remoteWrite.password in both sc-secrets.yaml and wc-secrets.yaml instead of using prometheus.remoteWrite.password in wc-secrets.yaml.
Additional context
Definition of done:
InfluxDB passwords are not duplicated in secrets.yaml and/or these fields are well described so it is easy to understand if two fields must match.

Postpone evaluation of InfluxDB alternatives (#419) and #407 .


1.19.3 update

ehe
didn't require much except a mixin fix

for people who are waiting for the PR to be accepted and don't want to compile the mod, here is it.
(i have to put it in a zip for GH to accept it, so download and the jar is right in, you just need to extract it)
bears-armor-hud-0.3.8.zip

Thank you, but it is not necessary anymore since I updated mod for 1.19.4

Thank you, but it is not necessary anymore since I updated mod for 1.19.4

Fine

I want to have 1.19.3

I want to have 1.19.3

You can use the jar in the zip above


Mobx package upgrade

"mobx": "^6.3.7",
"mobx-observable-history": "^2.0.3", (includes @Nokel81 's fix https://github.com/ixrock/mobx-observable-history/pull/8)

closes lensapp/lens/pull/4135

Actually please don't merge yet, I cannot seem to open drawers

I'm wondering if we should do this in 5.3.1 (i.e. don't commit to master yet). Something like this might need some time to soak/test and we may not have that time before 5.3.0 is released?

@ixrock would making mobx a "peerDependency" of your package be a good idea, maybe this is caused by a version mismatch.

@Nokel81 PTALA

I'm wondering if we should do this in 5.3.1 (i.e. don't commit to master yet). Something like this might need some time to soak/test and we may not have that time before 5.3.0 is released?

I think I agree that we should hold off until after the release of 5.3.0


Improve usability with Bash completion for Ollama on Linux

Please review this PR for adding Bash completion to install.sh for Linux.
Currently works for all arguments and options, including autocomplete for long model names (yay!)
ollama ls works, but it's missing from the -h/--help and ollama listing. I'll open a separate issue for it.
It does not include  autocomplete for ollama rm as I consider easy destructive actions would need user confirmation before execution. I'll also create an issue for it.
This version of install.sh has been tested successfully on Fedora 39, Ubuntu 23.10 and Debian 12.5.

I was just about to open an issue for this.

I'd take this contribution in:
https://github.com/ericcurtin/podman-ollama
just saying...

I merged the change here with you as co-author https://github.com/ericcurtin/podman-ollama/pull/54

Hi @aosan thank you so much for the PR! Sorry for the late review. I'm a little hesitant to merge this vs building it into the ollama binary (e.g. https://github.com/ollama/ollama/pull/980) since that will make sure it stays up to date with new commands etc. That said I really appreciate the time and effect to add this to the install script

It looks like this only completes models for run?  In other ways it's more complete than my script, but mine (just thrown together this morning, based on another script I found + some continue.dev work) completes model names for cp and create too.  This functionality should probably should be folded in.
_complete_ollama() {
   local cur prev words cword
   _init_completion -n : || return

   if [[ ${cword} -eq 1 ]]; then
       COMPREPLY=($(compgen -W "serve create show run push pull list ps cp rm help" -- "${cur}"))
   elif [[ ${words[1]} == "create" && ${prev} != "--file" && ${prev} != "-f" ]] && [ ${cword} -eq 2 ]; then
       WORDLIST=$((ollama list 2>/dev/null || echo "") | tail -n +2 | cut -d "	" -f 1)
       COMPREPLY=($(compgen -W "${WORDLIST}" -- "${cur}"))
   elif [[ ${words[1]} == "create" && (${prev} == "--file" || ${prev} == "-f") ]]; then
       COMPREPLY=($(compgen -f -- "$cur"))
   elif [[ ${words[1]} == "cp" ]] && [ ${cword} -gt 1 ]; then
       if [ ${cword} -eq 2 ]; then
           WORDLIST=$((ollama list 2>/dev/null || echo "") | tail -n +2 | cut -d "	" -f 1)
           COMPREPLY=($(compgen -W "${WORDLIST}" -- "${cur}"))
       elif [ ${cword} -eq 3 ]; then
           WORDLIST=$((ollama list 2>/dev/null || echo "") | tail -n +2 | cut -d "	" -f 1)
           COMPREPLY=($(compgen -W "${WORDLIST}" -- "${cur}") )
       fi
   fi
}

_complete_ollama_trash() {
   local cur words cword
   _init_completion -n : || return

   if [[ ${cword} -eq 1 ]]; then
       WORDLIST=$((ollama list 2>/dev/null || echo "") | tail -n +2 | cut -d "	" -f 1)
       COMPREPLY=($(compgen -W "${WORDLIST}" -- "${cur}"))
       __ltrim_colon_completions "$cur"
   elif [[ ${cword} -eq 2 ]] && [ "${prev}" != "" ]; then
       WORDLIST=$((ollama list 2>/dev/null || echo "") | tail -n +2 | cut -d "	" -f 1)
       COMPREPLY=($(compgen -W "${WORDLIST} ${cur}") )
   fi
}

complete -F _complete_ollama ollama
complete -F _complete_ollama_trash ollama-trash


Flaky test failures related to DNS

This CI failure is the second one (I think?) I've seen related to the preview2_ip_name_lookup test:
failures:

---- async_::preview2_ip_name_lookup stdout ----
preopen: TempDir { path: "/tmp/wasi_components_preview2_ip_name_lookup.component_UOrqd7" }
[guest] stderr:
thread 'main' panicked at crates/test-programs/src/bin/preview2_ip_name_lookup.rs:8:27:
called `Result::unwrap()` on an `Err` value: ErrorCode { code: 5, name: "timeout", message: "The operation timed out before it could finish completely." }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

===
thread 'async_::preview2_ip_name_lookup' panicked at crates/wasi/tests/all/async_.rs:299:57:
called `Result::unwrap()` on an `Err` value: error while executing at wasm backtrace:
    0: 0xe836 - <unknown>!__rust_start_panic
    1: 0xe6b2 - <unknown>!rust_panic
    2: 0xe5e5 - <unknown>!std::panicking::rust_panic_with_hook::hc97f08b908247b1d
    3: 0xd9b8 - <unknown>!std::panicking::begin_panic_handler::{{closure}}::hdd638bdaba0c6bcc
    4: 0xd8e3 - <unknown>!std::sys_common::backtrace::__rust_end_short_backtrace::h5b392607309abb6a
    5: 0xdfbc - <unknown>!rust_begin_unwind
    6: 0x12da6 - <unknown>!core::panicking::panic_fmt::h9fec598e5939a913
    7: 0x144ca - <unknown>!core::result::unwrap_failed::hf6fa377d4c4189f7
    8: 0x1dd0 - <unknown>!core::result::Result<T,E>::unwrap::h4c22dad2f3481e72
    9: 0x2223 - <unknown>!preview2_ip_name_lookup::main::h5c29a9b721419f34
   10: 0x13d2 - <unknown>!core::ops::function::FnOnce::call_once::h36602a529b14996f
   11: 0x13a9 - <unknown>!std::sys_common::backtrace::__rust_begin_short_backtrace::hdb75a96ebebc7895
   12: 0x148a - <unknown>!std::rt::lang_start::{{closure}}::h5311d15c72bddc30
   13: 0xc326 - <unknown>!std::rt::lang_start_internal::h11043ae9961d0df9
   14: 0x1435 - <unknown>!std::rt::lang_start::h1076db45b0cb32fb
   15: 0x37a8 - <unknown>!__main_void
   16: 0x134b - <unknown>!_start
   17: 0x254cba -<EMAIL_ADDRESS>note: using the `WASMTIME_BACKTRACE_DETAILS=1` environment variable may show more debugging information

Caused by:
    wasm trap: wasm `unreachable` instruction executed
stack backtrace:
   0: rust_begin_unwind
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/panicking.rs:72:14
   2: core::result::unwrap_failed
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/result.rs:1649:5
   3: core::result::Result<T,E>::unwrap
   4: all::async_::preview2_ip_name_lookup::{{closure}}::test_impl::{{closure}}
   5: all::async_::preview2_ip_name_lookup::{{closure}}
   6: <core::pin::Pin<P> as core::future::future::Future>::poll
   7: tokio::runtime::park::CachedParkThread::block_on::{{closure}}
   8: tokio::runtime::park::CachedParkThread::block_on
   9: tokio::runtime::context::blocking::BlockingRegionGuard::block_on
  10: tokio::runtime::scheduler::multi_thread::MultiThread::block_on::{{closure}}
  11: tokio::runtime::context::runtime::enter_runtime
  12: tokio::runtime::scheduler::multi_thread::MultiThread::block_on
  13: tokio::runtime::runtime::Runtime::block_on
  14: all::async_::preview2_ip_name_lookup
  15: all::async_::preview2_ip_name_lookup::{{closure}}
  16: core::ops::function::FnOnce::call_once
  17: core::ops::function::FnOnce::call_once
             at /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

failures:
    async_::preview2_ip_name_lookup

This is specifically failing on this line which is trying to do a real name lookup on the internet. This was known ahead of time that it could possibly be flaky, so I wanted to open this to see if we should do something about it. I'll also try to log future occurrences of failures into this issue too.
cc @badeend

One option would be to put the test execution in a new mount namespace with a new file bind mounted over /etc/resolv.conf. And then in this new file choose a dns resolver which allows injecting arbitrary domains.

Another failure


Upload manager with relationships

I have issue for I can not store the one to many relationships with Uploads manager.
I need one product has many images and I want use the upload manager.
How can I implement it with one to many relationship of product and product images with use of upload manager.

Good suggestion.

@gdbhosale good to see you back after a long time .. hope this project will be updated soon and all issues will be addressed with it .


Explore computational expressions in rust (do notation)

F# includes support for what they call computational expressions which seems to be an extremely useful and powerful abstraction which doesn't require a large number of extra syntax to support it. There is a gentle introduction here, an official documentation page, and a paper discussing the topic.
I'm not an expert and am actually quite new to the idea but I'm going to try to present the idea briefly below. See the links above for more thorough discussion of these topics. I think the idea is very interesting and if the rust developers haven't seen the idea, I should think it would be a useful concept in the future development of rust.
Also, I think it can be understood as an approach to make error handing in the functional style more agreeable and some people find that very appealing. I'm not going to try to explain in detail how it works because the article linked does a much better job that I would.

I view computational expressions somewhat as an inversion of implementing the iterator trait in rust. In rust, if you have a type which you implement the iterator trait for, you immediately gain access to all of the methods iterators provide and more importantly, the ability to use the for loop construct directly.
struct X;

// We implement this iterator trait
impl Iterator for X {}

let x = X;

// and in the *context of a for loop*, you gain the benefit of *clean iteration*
for i in x {}

In a computational expression, the situation is reversed: you implement the functionality, let's assume for the moment it was an iterator, and in the context of the type, you gain the benefit of a for loop construct.
Now, I'm not sure the previous analogy is fully accurate in F# for a for loop but for let, it is more precise. Consider the following testable example where a construct maybe_worker is defined which modifies how binding occurs to allow options have simple mathematical equations applied to them. This works correctly regardless of whether any of the options are None or otherwise.
maybe_worker {
    let! x = Some 3
    let! y = Some 4
    let! z = Some 5

    return x * y + z
}

This type of construct is quite general and as such, allows you a lot of flexibility to apply these bindings to do various types of extra work (such as logging) however you define it. Another interesting aspect is they don't create extra operators, as can be seen here. They have reused many of the normal keywords of the language in these constructs as a kind of extension seeming to add a lot of flexibility.
Also interestingly, since these types holding these operation variants are essentially adding side effects
to and slightly modifying operations, they have had great success using them with types such as async and seq among others.

To anyone who missed this, computational expressions = do-notation.

I didn't know that. Then this form is probably less unknown than I was afraid of. I was afraid people would see my bad explanation and gloss the issue.

For reference, the paper linked above distinguishes between this type of abstraction and the do-notation Haskell utilizes and so therefore assuming them equivalent is not necessarily accurate. Those of you well versed in do-notation might find it interesting and helpful.

Isn't this just catch or am I missing something?

I don't think so. I looked for the most recent RFC on try and didn't see a catch so I'm not sure specifically what you're referring to (though it is possible I am incorrect). The following snippet in F# in this instance quite literally translates to something like this:
// F#
maybe_worker {
    let! x = Some 3
    let! y = Some 4
    let! z = Some 5

    return x * y + z
}

// Translated into a rust direct equivalent
fn maybe_worker() -> Option<i32> {
    Some(3).and_then(|x|
        Some(4).and_then(|y|
            Some(5).and_then(|z|
                Some(x * y * z)
            )
        )
    )
}

However, those comparisons don't really do it justice because implemented differently, that same F# snippet would be equivalent to this:
// Rust equivalent when logging is desired
fn maybe_worker() -> Option<i32> {
    Some(3).and_then(|x| {
        println!("Got `{}`", x);
        Some(4).and_then(|y| {
            println!("Got `{}`", y);
            Some(5).and_then(|z| {
                println!("Got `{}`", z);
                println!("Returning `Some({})`", x * y * z);
                Some(x * y * z)
            })
        })
    })
}

Now let! is only one of their operators that this supports. Using this type of binding, they added support for for loop concepts and yield operations. Many others exist to yield code which might match our conceptual models easier than otherwise.

@mdinger with catch that F# snippet is
do catch {
    let x = Some(3)?;
    println!("Got `{}`", x);
    let y = Some(4)?;
    println!("Got `{}`", y);
    let z = Some(5)?;
    println!("Got `{}`", z);
    println!("Returning `Some({})`", x * y * z);
    z * y * z
}

Do you mean catch from rfc https://github.com/rust-lang/rfcs/pull/243? Is it implemented out of curiousity?

Unstable with temporary synyax of do catch { ... }
On Jun 19, 2017 7:10 AM, "mdinger"<EMAIL_ADDRESS>wrote:

Do you mean catch from rfc #243
https://github.com/rust-lang/rfcs/pull/243? Is it implemented out of
curiousity?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-lang/rfcs/issues/2034#issuecomment-309334261,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AApc0mXYIkg6b5a3Yu62GOszht6lQ-zGks5sFfTKgaJpZM4N7-gL
.

@clarcharr Yes, catch and ? gives do notation for the Result and Option monads.  Also, the coroutine eRFC proposes creating do notation tied to function bodies for Futures using procedural macros, aka #[async] and await!.  I think the question should be what else would benefits from a do notation, like say transactional data structures or anything listed in the links above.

I was not aware of catch though it seems less flexible than the example I included (probably because it is hardcoded). I'm glad to see they're pursuing a lightweight and flexible approach to that RFC as opposed to using new keywords at every juncture.
BTW, I thought the F# approach was very interesting and different from the standard rust "macro" approach and I thought others might as well. Maybe it will be useful when devising future designs.

Before a proposal like this is relevant, I think we need to be able to reason generally regarding and_then and return for any monad, which requires at least generic associated types and possibly HKTs.

F#er here who is interested in Rust. I most commonly use the built-in computation expressions for async and sequences.
let dbQuery =
    async {

        // the ! means that the expression returns an async, so unwrap it
        let! dbData = runDbQuery ()
        let! apiData = runApiCall ()

        let saveQuery = makeSaveQuery dbData apiData
        return! save saveQuery
    }

let validate customer =
    seq {
        if String.IsNullOrWhiteSpace customer.Name then
            yield CustomerNameInvalid

        // the ! means the expression returns a sequence, so flatten it
        yield! List.map validateContacts customer.Contacts
    }

F#er here who is interested in Rust. I most commonly use the built-in computation expressions for async and sequences.
let dbQuery =
    async {

        // the ! means that the expression returns an async, so unwrap it
        let! dbData = runDbQuery ()
        let! apiData = runApiCall ()

        let saveQuery = makeSaveQuery dbData apiData
        return! save saveQuery
    }

let validate customer =
    seq {
        if String.IsNullOrWhiteSpace customer.Name then
            yield CustomerNameInvalid

        // the ! means the expression returns a sequence, so flatten it
        yield! List.map validateContacts customer.Contacts
    }

This is the beauty of computation expressions, you basically extend the language without modifying the compiler.
What is achieved in other languages with special keywords and container types (IEnumerable and yield ; Task and async/await; ) in F# you just use computation expressions ( seq{} async{} task{} ...)
Another usecase is the Bolero (fsbolero.io) wasm Frontend lib which uses computation expressions to define a dsl for its html templating. With the ability of F# compiler perform inlining when compiling the expression the resulting code is performant.
Computation expressions in this form are one of the superpowers of F#.


clear function not available in the minified version

I think the minified version in the dist folder is an old version of the script. It's missing the clear method.

Please read the documentation (2nd or 3th line).
The documentation states that the clear function is not yet implemented in the ngcordova version of this plugin.


Update contexts schema to 1-0-1

Which allows an empty [] array of contexts.

This will make the Ruby Tracker only compatible with Snowplow core versions 0.9.14 and higher.

That should be fine


vim-bdubs does not work with Oni

Oni Version:
0.3.6
Operating System:
MacOS
Issue:
Oni is not compatible with vim-bdubs. When I try to run :BD command raise an error.
Expected behavior:
It should close all other buffers except the currently open one.
Actual behavior:
It says: not editor command: BD.
Steps to reproduce:
Add vim-bdubs to your Neovim config and try to execude :BD command from any open buffer.

I've given it a quick try and it seems to work for me.
Could we get some more info on how you installed it?
Once thing that it could be (and we should probably surface to the user more) is that nvim is reloaded only on a full restart of Oni. On Linux and Windows that is fine, since Oni closes when you close it. But on macOS, since it closes to the dock, its a bit more awkward.
So, did you restart Oni after the install, either with Cmd-Shift-P and Reload Oni (which does a full reload) or with right clicking Oni in the dock, and then re-opening?
Thats just a guess, but it is a possible cause, since it sounds less like its not working, and more like its not installed/being found, since the command isn't appearing at all.

 I was messing around with multiple vim configs at the same time so heavly that I forgot to install the plugin in new location 🤦♂ . Sorry and thank you for checking this issue.
I'm closing it as it works as expected.


Update wit ls5 plugin ref to latest wit book

Hi, @BexDunn and @MatthewJA . How are you. In this PR, I almost just copy paste from notebook codes to WIT plugins.
There are several changes:

In the WIT plugin transform section, there is only one timestamp in Dataset, so there is no need to do the time missing check
Use the _tcw() to replace the calculated_indices(): I test it, and their output are same.
There is no polygon mask filter in plugin, becuase it happen in drill.py

I only do the single-scene test in EKS environment by CMD: dea-conflux run-one --uuid 5514b137-737d-425e-8e49-c252bc9e5241 --plugin examples/wit_ls5.conflux.py -o s3://dea-public-data-dev/projects/WIT/pod_run_test -s s3://dea-public-data-dev/projects/WIT/test_shp/ramsar_wetlands_3577_perth-index_42-only.shp. Once we merge this PR, I can have the new docker image from develop branch and test it on Airflow environment.

I see you changed the resampling, is that a better set up for the datatypes? Also, I see the pc_missing is based off bare soil, is there ever a chance that other bands will have missing data that isn't captured by bs? I think we already masked bs based on the water and wet so I'm guessing not, but wanted to check we wouldn't get caught by nodata values on this if there was nodata in bs but not in npv or pv for example. I think 0 should just be 0 in FC, not an additional nodatavalue?

Oh, yes, I will add the pc_missing back. I exclude it to make my test run easy.
For the resampling side: I plan to change the plugin design after we review/validate/sign-off the WIT plugin output. The new design will use a different way to define the loading approach, not like my current solution here to mimic notebook processing solution.


Add snapshot shield to README

Add a snapshot shield to the README, so the snapshots are easier to discover.
Rendered version: https://github.com/aSemy/json5k/blob/patch-1/README.md
The colour and text are editable, as documented here: https://shields.io/badges/maven-metadata-url.

Good idea, thank you!


Local gallery viewer

For users who are new to budo/nodejs, it would be nice if there was an npm script that could run the gallery locally.  This could be some simple thing where you do:
npm run examples

And then it pops up a page with a list of all the examples in the gallery visible that you can click on and run.

Maybe we could have a fancy index page inside www folder which contains links to gallery, compare etc?

Thinking about this now, it doesn't seem like this is a great idea.  We already have a gallery that works, there's no need to be adding extra stuff.


Always bind Cython functions in py3

Rebased 1bb26b964060392ecb08c3b6c8ca4626e5c1eec7 for cython 0.29.x, and made conditional to Python 3.  This
does not solve the original staticmethod problem in Python 2 but it does
resolve classmethod problems in Python 3.9.  Therefore, it unbreaks
other packages on Python 3.9, improves overall state for Python 3
and does not introduce regressions in Python 2.

I agree that it improves on the current situation. Thanks.


Generic case classes and Resources.inferName don't work

There is no file written when I:
checkAll("GoldenCodec[PlanResult[AppointmentDelivery]]", GoldenCodecTests[PlanResult[AppointmentDelivery]].unserializableGoldenCodec)

final case class PlanResult[A](appointment: A, succeeded: Boolean)

Guess Resources.inferName doesn't work with that type

Are you using 0.2.1? I fixed something similar last week.

It's fixed, upgraded :)


HAbridge and Home Assistant Error log

Hi there
Get the following error in Home Assistant when i control my Milights configured in HABridge. The lights still work but the error seems to stop the automation. Any suggestions? it looks to me like that Home assistant expects a responce for HABridge it never gets and stops the automation proceeding>?
2017-08-22` 21:19:35 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
File "/usr/lib/python3.6/asyncio/tasks.py", line 181, in _step
result = coro.throw(exc)
File "/usr/lib/python3.6/site-packages/homeassistant/core.py", line 1025, in _event_to_service_call
yield from service_handler.func(service_call)
File "/usr/lib/python3.6/site-packages/homeassistant/components/light/init.py", line 281, in async_handle_light_service
yield from light.async_turn_off(**params)
File "/usr/lib/python3.6/asyncio/futures.py", line 331, in iter
yield self  # This tells Task to wait for completion.
File "/usr/lib/python3.6/asyncio/tasks.py", line 244, in _wakeup
future.result()
File "/usr/lib/python3.6/asyncio/futures.py", line 244, in result
raise self._exception
File "/usr/lib/python3.6/concurrent/futures/thread.py", line 55, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/lib/python3.6/site-packages/homeassistant/components/light/hue.py", line 452, in turn_off
self._command_func(self.light_id, command)
File "/usr/lib/python3.6/site-packages/phue.py", line 898, in set_light
converted_light) + '/state', data))
File "/usr/lib/python3.6/site-packages/phue.py", line 667, in request
return json.loads(response.decode('utf-8'))
File "/usr/lib/python3.6/json/init.py", line 354, in loads
return _default_decoder.decode(s)
File "/usr/lib/python3.6/json/decoder.py", line 339, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python3.6/json/decoder.py", line 357, in raw_decode
raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 81 (char 80)

If you could look in the ha-bridge log and see if there is an associated error. Otherwise I won't have any ideas.

nope, all i get in HAbridge is this: but the lights work, this i get everytime i call the lights via HAbridge from Home assistant at the same time i get the errors in Home Assistant.

Udp Call to be presented as udp://<ip_address>:/payload, format of request unknown:
com.bwssystems.HABridge.plugins.udp.UDPHome

Please post your device,db, Thanks.

device.db.txt
attached

I am looking into this

It seems the device TV Room Lights has an empty second device call for on and off which causes the error. All other devices seem to work properly in my tests.

Did you fix your device config?


wiki/Configuring-OAUTH empty

The Readme mentions a WIki page for "configuring omniauth provider in helpy"
but that wiki page is empty:  https://github.com/helpyio/helpy/wiki/Configuring-OAUTH

Strange. I think it has been removed. But if you go to the settings file here , you will find commneted examples under omniauth. If you just uncomment one of them and provide the id and secret it should work. A list of valid strategies with the corespongin gem installations is found here

I miss a more detailed documentation specific for helpy.
Devise/Omniauth has multiple ways to be implemented.
In our specific scenario, omniauth-saml that settings and its specific confir loader is not enough because SAML has different parameters than key/secret.
I found the omniauth support on helpy very limited.

I guess the doc is this one.
https://support.helpy.io/en/knowledgebase/11-Installing-Helpy/docs/19-Setting-Up-OAUTH-for-your-Helpy

Check this out https://github.com/helpyio/helpy/wiki/SSO--Configuring-OAUTH . The name/url is different.

Thanks @scott, then you should update the Readme.
I tried to configure a SAML Omniauth provider that is kinda different than an oauth2 provider.
It has different settings parameters than the pair id and secret
So far I added its settings to the config/settings.yml file
omniauth:
  providers:
    saml:
      issuer: "http://localhost/users/auth/saml/metadata"
      assertion_consumer_service_url: "http://localhost/users/auth/saml/callback"
      single_logout_service_url: "http://localhost/users/auth/saml/sls"
      idp_entity_id: "<idp_entity_id here>"
      idp_sso_target_url: "<idp_entity_sso here>"
      idp_slo_target_url: "<idp_entity_slo here>"
      idp_cert: "<x509 cert here>"
      name_identifier_format: "urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress"
      uid_attribute: "User.email"
      attribute_statements: {email: 'User.email', uid: 'Username', name: 'User.FirstName', first_name: 'User.FirstName', last_name: 'User.LastName'}

I then edited config/initializers/devise.rb to be able read those settings.
# ==> OmniAuth
  # Add a new OmniAuth provider. Check the wiki for more information on setting
  # up on your models and hooks.
  # config.omniauth :google_oauth2, 'APP_ID', 'APP_SECRET', scope: 'user:email'
  unless Settings.omniauth.nil? || Settings.omniauth.providers.nil?
    Settings.omniauth.providers.each do |provider|
      if provider[0].eql?(:saml)
        config.omniauth provider[0],
          :assertion_consumer_service_url => provider[1].assertion_consumer_service_url,
          :issuer => provider[1].issuer,
          :single_logout_service_url => provider[1].single_logout_service_url,
          :idp_sso_target_url => provider[1].idp_sso_target_url,
          :idp_slo_target_url => provider[1].idp_slo_target_url,
          :idp_sso_target_url_runtime_params => {:original_request_param => :mapped_idp_param},
          :idp_cert => provider[1].idp_cert,
          :name_identifier_format => provider[1].name_identifier_format,
          :uid_attribute => provider[1].uid_attribute,
          :attribute_statements => provider[1].attribute_statements
      else
        config.omniauth provider[0], provider[1].id, provider[1].secret, scope: 'user:email'
      end
    end
  end

And finally I added at app/controllers/omniauth_callbacks_controller.php
  def saml
    auth_hash = env["omniauth.auth"]
    user = User.find_by(uid: auth_hash[:uid])

    sign_in_and_redirect user
  end

but then I got:
ActionController::InvalidAuthenticityToken

I read this post and already tried to add
protect_from_forgery with: :exception, except: [:saml]

On aplication_controller.rb and at omniauth_callbacks_controller.rb with no luck
@scott do you know how to solve this? is your app extra protecting from CSRF attacks with something different than the protect_from_forgery defined on the app controller?

Wow.  yeah I have done a SAML before with Devise, and it was pretty painful getting everything configured just right.  I will have to take a look at my notes and see what how I did it.

If you need an IdP for testing, let me know, send me a mail (find it on my profile) and I can configure it for you and provide user credentials, so you only need to spend time figuring out how fix the InvalidAuthenticityToken issue.
P.S Thanks for the fast reply

Ok, I figured out how to fix that, at the end was simply add
  protect_from_forgery with: :exception, except: [:saml]

at aplication_controller.rb, but when I tried it, I got another 500 error but was for a setting issue.
I will send a PR later

Sure, a PR would be great @pitbulk It would also be awesome if you would write a wiki on how you got this configured.  I will add what I learned as well.

I sent the PR #1215

Thanks @pitbulk I will check it out!


Add danger toast if converted value is NaN

If the converted value is NaN, a danger toast is brought up to indicate an error and the copy to clipboard operation is not carried.
Another solution could be to change the attribute type to number and add the attribute step=0.01 so the converted value would be 0 if the duration value is anything else than a number. The optimal solution would be to prevent anything but numbers and period with a regexp like [0-9]*\.?[0-9]*, but I was not able to achieve that solution
Screenshot

I had to remove this changing after setting the keyboard as type number. Thanks for your time. ❤


Several small fixes

Grammatical fixes, correctly formatted text as a note

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: mufeez-amjad sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@mufeez-amjad : Thanks for your contribution! The author, @diegoviso, has been notified to review your proposed change.


bugfix: fixing the bug of missing dot to extract sub props from ingestion job and minion

fixing the bug of missing dot to extract sub props from ingestion job filesytem spec and minion segmentNameGeneratorSpec

Codecov Report

Merging #8511 (c2ae181) into master (68c89b7) will decrease coverage by 55.15%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #8511       +/-   ##
=============================================
- Coverage     69.26%   14.10%   -55.16%
+ Complexity     4284       84     -4200
=============================================
  Files          1674     1629       -45
  Lines         87642    85734     -1908
  Branches      13273    13069      -204
=============================================
- Hits          60701    12095    -48606
- Misses        22676    72730    +50054
+ Partials       4265      909     -3356

Flag
Coverage Δ

integration2
?

unittests1
?

unittests2
14.10% <0.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...che/pinot/controller/util/FileIngestionHelper.java
91.02% <ø> (ø)

...nandpush/SegmentGenerationAndPushTaskExecutor.java
0.00% <0.00%> (ø)

...ain/java/org/apache/pinot/core/data/table/Key.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/spi/utils/BooleanUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/core/data/table/Record.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/apache/pinot/core/util/GroupByUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...java/org/apache/pinot/spi/trace/NoOpRecording.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/config/table/FSTType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/org/apache/pinot/spi/data/MetricFieldSpec.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...va/org/apache/pinot/spi/utils/BigDecimalUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 1303 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68c89b7...c2ae181. Read the comment docs.


Access Bridge Explorer does not work on 32-bit machines

When running AccessBridgeExplorer.exe on a 32-bit version of Windows, there is an error displayed in the "Messages" view stating "Error retrieving accessible context info".

This has been fixed in the latest release (0.9.1)


Error when indexing with ColBERTv2

Hi, I'm using the new_api branch and the provided ColBERTv2 checkpoint to index a 2M dataset but the indexer doesn't seem to be able to create a ivf.pt, which I assume is related to faiss.

Seems like something is getting lost. I'll debug but I just thought of dropping this here first.

Hmm, this is strange. Can you share more of the output? I'm primarily interested in the stage before encoding the passages, where the model is doing k-means clustering.
It basically looks like some of the centroids (clusters) are associated with none of the vectors, which is very odd!
Do you have a ton of repeated passages in your collection, by any chance? Are you able to index a 200k-passage subset (10%) of your collection just fine?

Ah, come to think of it, I can see how a very extreme edge case can give rise to this, if there's a lot of redundancy in the text. Basically, it looks like you get some centroids that are very close to other centroids.
I'd like to learn more about the dataset if you'd like to share more information. The easiest fix for this special case is probably to reduce the number of partitions:
https://github.com/stanford-futuredata/ColBERT/blob/378001bcc439cb3ed2d8935473c368604a7dd46e/colbert/indexing/collection_indexer.py#L75
self.num_partitions = int(2 ** np.floor(np.log2(16 * np.sqrt(self.num_embeddings_est))))

->
self.num_partitions = int(2 ** np.floor(np.log2(8 * np.sqrt(self.num_embeddings_est))))

This isn't a parameter at the moment because we've never had to edit it before, but it looks like you might need to.

It's an e-comerce dataset which I'm not sure I could disclose. I was able to run the indexer for the first 10k documents from the corpus with no problem.
Thanks! I'll try this suggestion and get back to you.

I got the same error, but with with different size AssertionError: (torch.Size([65292]), 65536)
errorlog.txt

Could you change the line to:
self.num_partitions = int(2 ** np.floor(np.log2(2 * np.sqrt(self.num_embeddings_est))))
This should work. We'll edit the indexing code to handle this more gracefully in the future.

A nice side-effect of this change is that indexing will be faster for you.

Still same error:
AssertionError: (torch.Size([16380]), 16384)

Haha that is interesting. Removing the 2 * altogether should do the trick, since the margin has become so small now

Now it seems to have worked! Thanks man

Should we close the issue?


Manual input for fadeout frames no longer works

In 0.1.0 you could type in your fadeout frames manually, but in 0.3.0, you have to use the arrows and change the value one frame at a time.

This is an issue in Slint that has been fixed in their latest release. Once I finish the new NSFPresenter features that fix will be integrated. For now, you can also hold the up/down arrow keys while the box is focused to change the value much faster.


Formatting a folder gives cryptic error message when a file fails to parse

I wanted to format a whole folder so I ran $ roc format examples/, and got the following cryptic error message.
If there is an issue formatting a file within a folder, roc will report the parsing error but doesn't identify which file failed in the error messages. Even if we don't have a pretty error message report for this specific parser error, we should provide a clear message saying which file failed to parse.
$ roc format examples/
We ran into an issue while compiling your code.
Sadly, we don't have a pretty error message for this case yet.
If you can't figure out the problem from the context below, please reach out at <https://roc.zulipchat.com>
Unexpected parse failure when parsing this formatting:

"app [main!] {\n    pf: platform \"../platform/main.roc\",\n}\n\nimport pf.Stdout\nimport pf.Arg\n\nmain! : {} => Result {} _\nmain! = \\{} ->\n\n    args = Arg.list! {}\n\n    # get the second argument, the first is the executable's path\n    when List.get args 1 |> Result.mapErr (\\_ -> ZeroArgsGiven) is\n        Err ZeroArgsGiven ->\n            Err (Exit 1 \"Error ZeroArgsGiven:\\n\\tI expected one argument, but I got none.\\n\\tRun the app like this: `roc main.roc -- input.txt`\")\n\n        Ok first_arg ->\n        Stdout.line! \"received argument: $(first_arg)\"\n"

Parse error was:

Expr(Closure(Body(When(IndentBranch(@489), @227), @227), @124), @56)

Location: crates/cli/src/format.rs:193:9

Closing in favour of #7379


Change Layout/AlignHash to table mode

As a developer I wish the Rubocop setting for the Layout/AlignHash cop to be table mode.
Because at present it uses the default (No alignment) and this does not fall in line with the best practice as agreed with the NDR technical architect.

It's done when the following does not report a Rubocop error :

  hash = {
    a_key:       1,
    another_key: 2
  }

I hate table mode

Hate it

👍


proposal: cmd/go: add a test flag to update runnable example output comments

We have support for examples which can be run as part of go test, as documented in https://pkg.go.dev/testing#hdr-Examples.
Right now, if I change the example code in any way that changes its output, such as by tweaking the package API implementations, I'll get a failure when running go test again. With https://github.com/golang/go/issues/41980, that failure will show me a diff, which is pretty neat.
However, if I do intend to change the output of the example for good, I'll need to manually update the // Output: comment lines in the example code, such as by copying the output text from the output of go test, pasting it in the editor, commenting out those lines, and placing them where the old ones are.
It would be nice if we instead had a flag, like go test -updateoutput but with a better name, so that could happen in-place automatically. It could also work with unordered output lines, which could keep the source code deterministic by e.g. sorting the lines.
The reason it would be a flag is because the existing default behavior should be kept. By default with go test, a runnable example whose output doesn't match should result in a failure.
It should be noted that @cznic has implemented an external version of this in https://pkg.go.dev/modernc.org/fe. It can certainly work outside of cmd/go, though I'd argue that it would be nice to have it built-in, akin to how we have other cmd/go commands to edit source in-place such as go fix or go mod edit.
One question might be: how often does this come up? I personally run into this scenario relatively often, as I try to design end-user Go APIs by first writing one or two examples, often in runnable form. As I iterate on implementing the logic of the APIs, I want to verify that their output becomes what I expect, akin to re-running a test until it succeeds.
This may not need to be a proposal, but since the suggestion is to add a new go test flag, I'm erring on the side of caution - it may be a controversial feature request :)
cc @bcmills @matloob (Bryan and I briefly discussed this idea on Slack back in September 2021)

or maybe under go fix since having go test change the source code seems a bit suprising.

I have run into cases before where it was hard to get the output comment correct because there was some trivial whitespace that didn’t affect overall correctness but was hard to get right and copypaste through the terminal was slightly off (I forget the exact details but it was like some tabs mixed with spaces which weren’t copying correctly or something). Having this feature would have been very helpful.

This example pattern is very similar to the NodeJS library, Jest, with its "Snapshot" pattern.
https://jestjs.io/docs/snapshot-testing
run tests to validate that the examples match:
jest

update the examples on disk:
jest --updateSnapshot

I'd be super excited to see this in Go!


Empty command check false positives

The code that highlights the second ; in foo; ; bar as an error also fires for :; followed by newline. Found by @phy1729.

The relation to #568 is through the newline that follows the comment in the alias-comment1 test file:
https://github.com/zsh-users/zsh-syntax-highlighting/blob/d766243f7a2a920b01a405d8fd0b12cb18f6d5bc/highlighters/main/test-data/alias-comment1.zsh#L32

The XFail test is XPASSing: #623.


Improve packaging

Refactor all the resources into separate packages.

Copy pattern in Hashicorp AWS provider for configuring provider for acceptance tests
Clean up code coupling along the way.
Use -p 1 for go test since we now have multiple packages and we can't have multiple process running for acceptance test. Otherwise Artifactory will get overwhelm and returns 503.
Manually add back 'pub' repo type from earlier PR.

@alexhung please fix the conflict


Make it possible to customize the map background color in WebGL context.

Mimicking the class "ol.renderer.canvas.Map.prototype.renderFrame", trigger the render event "PRECOMPOSE" after the viewport clear-up operation so that I have a good chance of customizing the map background color. The custom background color is feasible for Canvas 2D, because the render event "PRECOMPOSE" happens after the context.clearRect() invocation.
Thank you for your interest in making OpenLayers better!
In order to get your proposed changes merged into the master branch, we ask you to please make sure the following boxes are checked before submitting your pull request.

[ ] This pull request addresses an issue that has been marked with the 'Pull request accepted' label & I have added the link to that issue.
[x] It contains one or more small, incremental, logically separate commits, with no merge commits.
[ ] I have used clear commit messages.
[ ] Existing tests pass for me locally & I have added or updated tests for new or changed functionality.
[x] The work herein is covered by a valid Contributor License Agreement (CLA).

@stuartZhang Please do not add changes that address a different issue to an existing pull request that has a different purpose.

Sorry! I thought a new pull request will be automatically created for my 2nd change. However, my 2nd change is aggregated to the 1st pull request, which is not my intention.
Now, I have reverted the 2nd change.

Thanks @stuartZhang. Now let's start marking off checkboxes in the ticket description above. The ones we really care about are

[ ] It contains one or more small, incremental, logically separate commits, with no merge commits.

For this to pass, please squash the commits into one.

[ ] The work herein is covered by a valid Contributor License Agreement (CLA).

You can submit one by following the link above and filling out either an electronic ICLA, or send a CCLA by e-mail.

I have checked the two items:

It contains one or more small, incremental, logically separate commits, with no merge commits.
The work herein is covered by a valid Contributor License Agreement (CLA).

Sorry @stuartZhang, but neither have we received a CLA from you, nor have you squashed the commits into one. So I had to uncheck the boxes again.

I have just used "git rebase -i" command to squashed the commits into one.

Ok @stuartZhang, now you have to use push --force to get your changes pushed to Github.

And because you have checked the box again: we still have not received a CLA from you, @stuartZhang. Let me know if you need help understanding the procedure.

I have just forcibly pushed the changes to Github, resorting to the Git GUI client.

I have just submitted a digital Individual Contributor License Agreement.

CLA received, thanks. However, I don't know where you pushed your changes to. I don't see them here, and they are also not in your branch.

@stuartZhang Looks like you do not have your other change to ol.style.RegularShape in any branch. So if you rebase, you'll loose those changes. Maybe @gberaudo can help you turn your master branch into two valid pull requests?

My changes for the class "ol.style.RegularShape" has been reverted in Git, because it doesn't match the pull-request title. The "ol.style.RegularShape" modification will be placed into a brand-new pull request as soon as possible.
My only improvement for our project is the 466th line in the class "ol.renderer.webgl.Map".

I have got a following Git Error, when the Git command "git cherry-pick 0d72cf227553dd7197de2d953fa62f9f9c85c310" was run in my local Fork branch.

On the flip side, I have checked out the master branch to my local disk and executed the same command, but I have got another Git Error:

Please give me a bit of technical help.

Sure @ahocevar, I am happy to give a hand if you think it can help.
First @stuartZhang, I suggest you close this PR since it uses an origin branch of master which is only bringing issues. Instead you should always work on feature branches. See https://git-scm.com/book/en/v2/Git-Branching-Branching-Workflows.
Then use the following procedure to create 2 new PRs based on 2 feature branches:
git remote add gberaudo git@github.com:gberaudo/ol3
git fetch gberaudo

git checkout -b isoceles_triangles  gberaudo/zhang_isoceles_triangles
git push origin

git checkout -b gberaudo/zhang_webgl_precompose  gberaudo/gberaudo/zhang_webgl_precompose
git push origin

With the above steps you will get 2 branches on github from which you can create 2 separate PRs.


SVGO dies on the image

Here's the image:
https://gist.github.com/b9b2f5b7222be4dff803
What I'm doing is:
/js/javascript-nodejs
iliakan> svgo -i ~/svg/class-inheritance-array-object.svg -o 1.svg

/js/javascript-nodejs
iliakan> ls 1.svg
ls: 1.svg: No such file or directory

That happens because svgo keeps IDs values in an object dictionary, and 'proto' id rewrites prototype of the internal svg representation, thus breaking svgo work.

Maybe release a new version with this fix?

Yes, the new version is coming. Need to fix some other bugs too.

Okay, looking forward to test it on my svgs :)

v0.5.1 with the fix has been just published.


Terraform changes for Automate HA based on EAP feedback

Description
Below are the terraform changes which will be covered as part of this story:
* Enable EBS/EFS encryption
* Application LB - select least outstanding request as algorithm
* Enabling ALB logs is vital for post incident analysis
* Add - Consider using outbound rules in Security Groups
* EC2 instances are using the same Security Groups as the Load Balancer
* Remove - base_windows Security Group
* Restrict - base_linux Security Group with port 22 opened to the world - Check and plan accordingly
* Move to GP3 from GP2 for EBS storage
* Kibana - Es IP private - Wait for open search then do
* Update the default AMI to latest Centos and test the same
Acceptance Criteria
Automate HA should work with these changes

Open question

' chefautomate cli uses hab 1.6.121 which is from 2020 - How to use latest
Bastion host -> Management host


Add "printing" tests for supported subset of syntax

Add printing tests of supported subset of syntax. All tests must cover these constructions:

if + else
while
def
assign

no need for "printing" tests, because the tests can just be self-checking. This is how they work now.


Add more Remote tests

Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

tests aren't too happy

LGTM

/lgtm


different hotkeys for different languages

It would be awesome if it were possible to set up different hotkeys for different languages, so you wouldn't have to tweak the settings constantly. Great software, by the way!

there is a command to switch a language. laitis settings pack.

no idea how I didn't notice it myself to be honest.  thanks it works great!


Towards reproducible deployment

This includes three changes made over the course of getting tryhaskell ready to deploy with Halcyon.

Instead of hardcoding port 4001, read the PORT environment variable.

Give mueval more time, as mentioned in https://github.com/chrisdone/tryhaskell/issues/21#issuecomment-61946338

Instead of always loading jQuery over HTTP, use the appropriate protocol.

how  to  solve  issue ' In the end, the problem was simple — tryhaskell was passing -t 1 to mueval, which was not enough time for mueval to do anything interesting.' @mietek .I need  you help.thanks


Protect the /api/updates route

this is the web hook endpoint from Github
it's not protected by a secret and probably should be

can't seem to see the webhooks page, might be admin only


Links: Provide QR Code

When producing a link (either single or multi ben), could also provide a QR code. Tog are interested in this so that they can put a multi ben link on posters; they pointed to Survey Monkey as a good example of this functionality.

 Onboarding 3.0 + ease of use


assign value to a variable and return at the end.

Fixed exp_find_by_token method to return values correctly when finding token within an expression with mixed operators
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1660460
before

after

@gtanzillo @jrafanie please review
@dclarizio cc

@bdunne made requested changes

Hammer backport details:
$ git log -1
commit 8e31216c10fe109043267b82e0903ff0a1f2cb94
Author: Joe Rafaniello<EMAIL_ADDRESS>Date:   Fri Jun 14 10:51:10 2019 -0400

    Merge pull request #18867 from h-kataria/mixed_operator_conditions_fix

    assign value to a variable and return at the end.

    (cherry picked from commit 0466cd65679de80ca08eda54d6cccb2f6b0d49c9)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1720753


URL checking should ignore case

When checking if a social media URL is valid, the matching algorithm should ignore case.
To reproduce:

Go to http://ringdev.measuredvoice.com/usagov/embed-example.html
Enter "Http://Twitter.com/whitehouse" and click "Verify"

Expected: The status of the account should be displayed.
Current: An error is displayed because the URL doesn't match any of the social media services.
@huboard:{"order":13.0}

Verified the fix on ringdev.


Plot Bottom Bug

Issue description

Expected result: What were you expecting to happen?
Actual result: What actually happened?
I have edit Border Block Set to true, and i have a Void Bug

Steps to reproduce the issue

... Generate a Plotworld
... See my Picture

OS and versions
 Dev 633

Plugin Version:
PocketMine-MP: 3.15.1
PHP: 7.3
Game version: PE (delete as appropriate)

Other Plugins
 Multiworld, Worldprotect, EnchantUI, FormApi, Economy Api, ScoreHud, PurePerms, PureChat, MyplotHomes, AddNetherite HeroTeam

If you remove all other plugins, does the issue still occur? Yes (delete as appropriate)
If the issue is not reproducible without other plugins:

Have you asked for help in the community discord before creating an issue?
Can you provide sample, minimal reproducing code for the issue? If so, paste it in the bottom section.

Console error, backtrace or other files

[

Many Plots have this Problem but not all.

unable to reproduce with given steps and plugins


Add example demonstrating multiple different blas in one tlas

this needs to test how multiple blas with multiple geometry might all go into one tlas, and how the geometry from one blas must be offset by the geometry of the previous blas

Pull request #27 solves this issue


Uniformly include license as comment at the top of every source file.

From now on all new files will also require the license of this software at the top of every file as
a comment.

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   93.32%   93.32%
=======================================
  Files           4        4
  Lines         539      539
=======================================
  Hits          503      503
  Misses         36       36

Impacted Files
Coverage Δ

UIFontComplete/UIFont+Extension.swift
100% <ø> (ø)
:arrow_up:

UIFontCompleteTests/UIFontCompleteTests.swift
100% <ø> (ø)
:arrow_up:

UIFontComplete/FontRepresentable.swift
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0301c1...244b903. Read the comment docs.


Mixin serialization - Guidance

Is there an option in the Model Serializer to include all mixin members as part of the shape they are applied to
Currently the mixins will show up as a separate object
"MyInput": {
      "type": "structure",
      "mixins": [
        {
          "target": "test#HasId
        }
      ],
      "members": {
        "first": {
          "target": "smithy.api.String",
        }
      }
      }

No, mixins form a graph and don't repeat the shapes that are mixed in to. You can flatten mixins, which copies members into the places they were mixed in, but it also removes mixins from the model.
For example:
use software.amazon.smithy.model.transform.ModelTransformer;
...
Model flattened = ModelTransformer.create().flattenAndRemoveMixins(model);

Thank you , I didnt know that Transformer existed .That solves my problem


Invert Yaw, change to fbx

So by changing to FBX the textures appear nicely in Gazebo. As can be seen in the below two screenshots (before / after)

However, as you can see, the models are rotated incorrectly (on yaw). I've resolved this by inverting the pose in the sdf file, but not 100% if thats the right place (further comment on the line changed). It does work as you can see here:

Closes #102

@azazdeaz just in case you didnt get this

Thank you Tomo.
By the way, do I understand correctly that rotation is somehow handled differently based on the 3d data format used?

Yes it would seem so, although this is slightly confusing to me because I understand that the initial blender file handles axis / rotations differently to how gazebo reads them, but a model type itself (fbx / obj etc) is a bit odd as my assumption would be that would be the same (as its all coming from an initial blenderfile). Not sure if Andras has any additional input on that?

Thank you @tomonorman! Sorry that i missed this.

But should we do it further up the chain?

Yes, in the export_fbx.py, there is the bpy.ops.export_scene.fbx() call with has these two options axis_forward='-Z', axis_up='Y' https://docs.blender.org/api/current/bpy.ops.export_scene.html#bpy.ops.export_scene.fbx
The confusing thing is that we're currently using the defaults and the defaults are the same as in the OBJ export, so nothing should change.
If i remember correctly, all the gltf, fbx, and obj exports were oriented the same. I'll try to look into this too.

thanks @azazdeaz
So would you says its ok to keep it as it is with the inversion in the sdf pose? or its best to make the change in the export scene?
If the change is made in the export_scene, would the sdf pose also have to change to 0 0 0 0 0 0  ?

If the change is made in the export_scene, would the sdf pose also have to change to 0 0 0 0 0 0  ?

No, the idea was that all the exported models should have the same orientation that works in simbuilder, and we rotate them during the export to match the export target. For now, Gazebo only.

So would you says its ok to keep it as it is with the inversion in the sdf pose? or its best to make the change in the export scene?

I think we can merge this as it is. My issues is that we shouldn't need to change the pose rotation in the export SDF because the FBX should have the same orientation as the OBJ.
If you switch back to .obj, or change to .gltf, do you also have to switch back the change in the pose rotation?

I tried converting the coffee shop models to .fbx with RoboProp and reload the environment in Gazebo, and seemingly the only change is that the textures are fixed :confused:

I'll try to think about what can cause the difference :thinking:

Did you do that using this branch? or just main? I ask as I see that the chairs have the correct orientation so to me that suggests that (if you did it on this branch), a change is required for rotation? (because its working in the screenshot)

Thank you, thats odd indeed. I need to make the change

If you switch back to .obj, or change to .gltf, do you also have to switch back the change in the pose rotation?
Yes, with an fbx the rotation becomes a mirror of what it should be

The rotation on yaw was occuring on arm (macos). When running a conversion on amd (linux) the change to pose was not necessary. It seems arm and amd blender operate slightly differently. As we are mostly amd, I am removing the change to pose, and will cite as an issue / in the wiki

crazy stuff!


Fix expectLater to not wrap the delegate in a guard

Follow-up to https://github.com/flutter/flutter/pull/17063
https://github.com/flutter/flutter/issues/16859


Missing link adjacency between /herb_base and /head/wam2

To replicate: Set the head's DOF values to [ 1.0, 1.0 ].

This seems to be fixed in the current version of the HERB model. I'm not sure what changed, because the link adjacency is still missing. Maybe this was fixed by our new HERB collision geometry?


vscode.workspace.openTunnel() does not resolve

Still works in stable, must be a regression in insiders. We use the following to establish a tunnel, the promise no longer resolves:
	await vscode.workspace.openTunnel({
		remoteAddress: {
			host: '<IP_ADDRESS>',
			port
		}
	});

@chrmarti, hijacked a command with this:
	context.subscriptions.push(vscode.commands.registerCommand('remote-containers.settings', async () => {
		const temp = await vscode.workspace.openTunnel({ remoteAddress: { host: '<IP_ADDRESS>', port: 3000 } });
		console.log(temp);
	}));

I'm not seeing any problems with it. Do you have any other ideas on how to repro?

I'm calling this from the resolver, maybe the implementation waits for something to finish that only finishes after the resolver returned?


Any way to install JustAssembly without registering?

Two installers are offered. One EXE and one MSI (which requires a Telerik account).
While the EXE seems registration-free, it isn't.

Is there any way to install (not a portable zip) JustAssembly without registering? This practice is far too predatory, especially for an open-source product.

Incredibly infuriating, I ended up rewriting the IL of the installer itself to skip the login step, but that did work, so at least I didn't need to register for an account.


Handle Empty Domain

This PR provides a default value for the existing_records variable in the event a domain has no existing records.
I noticed recently while working with Cloudflare on a newly added domain that for some reason the API is returning
{
  obj: None
}

rather than the more sensible
{
  objs: []
}

When no records currently exist on a domain.
This change ensures an empty array is in place to prevent the module from choking on the bad objs reference.  I tried to get a test running but it seems like the tests are currently broken and I'm not experienced enough with Python to know how to properly fix them or if this is even the best fix for the problem. Either way it got me rolling again so I figured I'd open a PR.
Thanks for writing this module it really came in handy!

Thank you for the PR! I'll review it as soon as I'm in front of a computer.
:-)
On Sat, 11 Jul 2015 03:10 Matthew Surabian<EMAIL_ADDRESS>wrote:

This PR provides a default value for the existing_records variable in the
event a domain has no existing records.
I noticed recently while working with Cloudflare on a newly added domain
that for some reason the API is returning
{
obj: None
}
rather than the more sensible
{
objs: []
}
When no records currently exist on a domain.
This change ensures an empty array is in place to prevent the module from
choking on the bad objs reference. I tried to get a test running but it
seems like the tests are currently broken and I'm not experienced enough
with Python to know how to properly fix them or if this is even the best
fix for the problem. Either way it got me rolling again so I figured I'd
open a PR.
Thanks for writing this module it really came in handy!
You can view, comment on, or merge this pull request online at:
https://github.com/DrMegahertz/ansible-cloudflare/pull/5
Commit Summary

Provide a default value in the event a domain has no existing records

File Changes

M library/cloudflare_domain.py
https://github.com/DrMegahertz/ansible-cloudflare/pull/5/files#diff-0
(3)

Patch Links:

https://github.com/DrMegahertz/ansible-cloudflare/pull/5.patch
https://github.com/DrMegahertz/ansible-cloudflare/pull/5.diff

—
Reply to this email directly or view it on GitHub
https://github.com/DrMegahertz/ansible-cloudflare/pull/5.

Thank you for your contribution, I'll try to get a test up and running as well.


feat(nimtable): nimtable hide iceberg row

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?

Hide _row_id for iceberg sources.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Please update the code  pks = vec!["_row_id".to_string()]; with ROWID_PREFIX on create_table.rs simultaneously