Fix string addition for Koalas Series

This PR updates __add__ and __radd__ functions to handle string concatenation. Before this patch, when adding two string columns or string column and literal, you get None, because the library would use Spark columns addition.
I updated the function to use concat Spark SQL function instead, this applies for cases of two columns or column and literal. Added unit tests to verify the intended behaviour.
Pandas does not support 'str' + 'int' or 'int' + 'str', or other cross types additions; so I only added handling for strings.

__add__ function became a bit messy, because of that check. Also I found that error messages are not consistent between Koalas and Pandas when it comes to adding columns of different types.

Fixes #219

Codecov Report

Merging #235 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
+ Coverage   91.48%   91.54%   +0.06%
==========================================
  Files          34       35       +1
  Lines        2970     3005      +35
==========================================
+ Hits         2717     2751      +34
- Misses        253      254       +1

Impacted Files
Coverage Δ

databricks/koalas/series.py
91.08% <100%> (+0.35%)
:arrow_up:

databricks/koalas/tests/test_series_string.py
100% <100%> (ø)

databricks/koalas/__init__.py
88.88% <0%> (-3.71%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbaa1d...9780d13. Read the comment docs.

Thanks Ivan. Merged.


Added alpha to FromColorString and ColorHexString

Fixes #118

Coming back to the repo to do some cleaning. Have you had time to look at my review?

This PR was made redundant by ea4b914. Thank you for your contribution anyway :)


Make a 0.7-alpha1 pre-release

cc @Rhuagh @omni-viral @Xaeroxe @WaDelma
I intend to release pre-release versions of shred and Specs today so we can check if everything is working as intended.

bors r+


[WIP] Add reverse_sequence op

Trying to figure out adding new ops to nd4j.

@eraly SameDiff test passing, please check TF mapping.

@agibsonccc Needs to map int byte buffers to floating point
https://github.com/deeplearning4j/nd4j/blob/6a7efaa05f1b3c5d2f8177cf34be3da460e48acd/nd4j-backends/nd4j-api-parent/nd4j-api/src/main/java/org/nd4j/imports/graphmapper/tf/TFGraphMapper.java#L960
To test pull reverse_sequence branch in nd4j and run TFGraphTestSubDir.java
Don't forget to pull dl4j-test-resources and build again

Import test now passes with
https://github.com/deeplearning4j/nd4j/pull/2766/commits/26eecb89d20c3948c1ff822c8c132a10975f0125

This + the changes in the TFGraphMapper is now open as https://github.com/deeplearning4j/nd4j/pull/2766. Closing this.


chore(release): 0.49.0

0.49.0 (2024-11-18)
Features

JA: Add manifest upload and download to complete the JA standalone API+CLI featureset. (b5b203b)
refactor manifest aggregation, add helper to persist manifests and check disk capacity (#483) (f57f637)
JA: Add force-rehash option to snapshot command. Move Integ Tsts for Diff and Snapshot to Integ (276edae)
JA: Implementation for Job Attachments diff command (#465) (97e8bc4)

Bug Fixes

state upperbound (3.12) for python version support (#501) (f35765f)
De-duplicate error messages on expired credentials (cfc7759)
Refresh queue parameter defaults when loading a new job bundle (5abcef1)
The hash_cache fails with filenames including surrogates (#492) (39c285d)
Fix skipped test. Should not hard code root prefix of Queue CAS as an assumption. (#491) (d9e70d2)
Integration test fix and skip a test. (#490) (eaef7e0)
Job parameter values dropped when merging with queue parameter (73e1b24)
Disable failing test case to debug offline (#479) (322a072)
pass in cache directory for attachment upload (#476) (1f776f6)

I added a breaking changes section to the release change logs


RealmList - notifications as flows

Added support for list notifications as flows using list.observe().
Internal support for freezing/thawing lists.

Also missing a changelog entry on the ability to import objects by adding them to a managed list.


This will solve CPU-only, CUDA-only and any mix of them.

This solves the post-fix_symbolic problem with cuda, the initialize_from_another_model problem with cuda, and the cpu problem related (already mentioned in this PR) that forced to use cuda.

@KindXiaoming This should close many issues related to using CUDA. To work properly, I recommend updating requirements.txt to the following
matplotlib==3.6.2
numpy==1.26.4
scikit-learn==1.4.2
setuptools==69.5.1
sympy==1.11.1
torch==2.2.2
tqdm==4.66.2

Please let me know if you want me to make another PR or you'll handle this by yourself.

There's another device missing in https://github.com/KindXiaoming/pykan/blob/master/kan/KAN.py#L205. I've addressed it in my fork at https://github.com/Jim137/pykan/tree/develop. Would you be open to merging my changes and submitting a pull request together?

Good point, I added it.

Can you run the with create_dataset?
{
	"name": "RuntimeError",
	"message": "Expected all tensors to be on the same device, but found at least two devices, mps:0 and cpu!",
	"stack": "---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[7], line 1
----> 1 model.train(dataset, opt=\"LBFGS\", steps=20, lamb=0.01, lamb_entropy=10.)

File ~/anaconda3/envs/ROS_Self-driving-car/lib/python3.8/site-packages/kan/KAN.py:898, in KAN.train(self, dataset, opt, steps, log, lamb, lamb_l1, lamb_entropy, lamb_coef, lamb_coefdiff, update_grid, grid_update_num, loss_fn, lr, stop_grid_update_step, batch, small_mag_threshold, small_reg_factor, metrics, sglr_avoid, save_fig, in_vars, out_vars, beta, save_fig_freq, img_folder, device)
    895 test_id = np.random.choice(dataset['test_input'].shape[0], batch_size_test, replace=False)
    897 if _ % grid_update_freq == 0 and _ < stop_grid_update_step and update_grid:
--> 898     self.update_grid_from_samples(dataset['train_input'][train_id].to(device))
    900 if opt == \"LBFGS\":
    901     optimizer.step(closure)

File ~/anaconda3/envs/ROS_Self-driving-car/lib/python3.8/site-packages/kan/KAN.py:243, in KAN.update_grid_from_samples(self, x)
    220 '''
    221 update grid from samples
    222
   (...)
    240 tensor([0.0128, 1.0064, 2.0000, 2.9937, 3.9873, 4.9809])
    241 '''
    242 for l in range(self.depth):
--> 243     self.forward(x)
    244     self.act_fun[l].update_grid_from_samples(self.acts[l])

File ~/anaconda3/envs/ROS_Self-driving-car/lib/python3.8/site-packages/kan/KAN.py:311, in KAN.forward(self, x)
    307 self.acts.append(x)  # acts shape: (batch, width[l])
    309 for l in range(self.depth):
--> 311     x_numerical, preacts, postacts_numerical, postspline = self.act_fun[l](x)
    313     if self.symbolic_enabled == True:
    314         x_symbolic, postacts_symbolic = self.symbolic_fun[l](x)

File ~/anaconda3/envs/ROS_Self-driving-car/lib/python3.8/site-packages/torch/nn/modules/module.py:1511, in Module._wrapped_call_impl(self, *args, **kwargs)
   1509     return self._compiled_call_impl(*args, **kwargs)  # type: ignore[misc]
   1510 else:
-> 1511     return self._call_impl(*args, **kwargs)

File ~/anaconda3/envs/ROS_Self-driving-car/lib/python3.8/site-packages/torch/nn/modules/module.py:1520, in Module._call_impl(self, *args, **kwargs)
   1515 # If we don't have any hooks, we want to skip the rest of the logic in
   1516 # this function, and just call forward.
   1517 if not (self._backward_hooks or self._backward_pre_hooks or self._forward_hooks or self._forward_pre_hooks
   1518         or _global_backward_pre_hooks or _global_backward_hooks
   1519         or _global_forward_hooks or _global_forward_pre_hooks):
-> 1520     return forward_call(*args, **kwargs)
   1522 try:
   1523     result = None

File ~/anaconda3/envs/ROS_Self-driving-car/lib/python3.8/site-packages/kan/KANLayer.py:170, in KANLayer.forward(self, x)
    168 batch = x.shape[0]
    169 # x: shape (batch, in_dim) => shape (size, batch) (size = out_dim * in_dim)
--> 170 x = torch.einsum('ij,k->ikj', x, torch.ones(self.out_dim, device=self.device)).reshape(batch, self.size).permute(1, 0)
    171 preacts = x.permute(1, 0).clone().reshape(batch, self.out_dim, self.in_dim)
    172 base = self.base_fun(x).permute(1, 0)  # shape (batch, size)

File ~/anaconda3/envs/ROS_Self-driving-car/lib/python3.8/site-packages/torch/functional.py:380, in einsum(*args)
    375     return einsum(equation, *_operands)
    377 if len(operands) <= 2 or not opt_einsum.enabled:
    378     # the path for contracting 0 or 1 time(s) is already optimized
    379     # or the user has disabled using opt_einsum
--> 380     return _VF.einsum(equation, operands)  # type: ignore[attr-defined]
    382 path = None
    383 if opt_einsum.is_available():

RuntimeError: Expected all tensors to be on the same device, but found at least two devices, mps:0 and cpu!"
}

I don't know why but if use MPS(Apple SIlicon) to loss is nan.
model.train(dataset, opt="LBFGS", steps=20, lamb=0.01, lamb_entropy=10., device=device.type);

@brainer3220 I'm afraid I can't help too much with MPS, but it seems nonetheless a common issue between MPS and Torch (see https://github.com/pytorch/pytorch/issues/112834, for example).

I am trying to run the given example of KAN in colab with AlessandroFlati:develop implementation:

Still getting the above error. I used the following requirements:
matplotlib==3.6.2
numpy==1.26.4
scikit-learn==1.4.2
setuptools==69.5.1
sympy==1.11.1
torch==2.2.1
tqdm==4.66.2
In case I want to run on cpu, it says no NVIDIA drivers selected.
Any help to resolve this is appreciated. Thanks!

I am trying to run the given example of KAN in colab with @AlessandroFlati AlessandroFlati:develop implementation:
Still getting the above error. I used the following requirements: matplotlib==3.6.2 numpy==1.26.4 scikit-learn==1.4.2 setuptools==69.5.1 sympy==1.11.1 torch==2.2.1 tqdm==4.66.2
In case I want to run on cpu, it says no NVIDIA drivers selected.
Any help to resolve this is appreciated. Thanks!

First you need to initialize a torch.device like this device = torch.device('cuda' if torch.cuda.is_available() else 'cpu')
Then use device in all constructors device = device
Finally, you will need to put the dataset tensor on device doing this:
dataset['train_input'] = dataset['train_input'].to(device)
dataset['train_label'] = dataset['train_label'].to(device)

Thanks, now I am able to run on colab GPU. But the CPU problem persists.

Thanks, now I am able to run on colab GPU. But the CPU problem persists.

This pull request solves it, you can try to modify pykan like in those commits:
https://github.com/KindXiaoming/pykan/pull/98/commits/d606bd88bd76f867ef1e2e0780d68fb4f378ce65
https://github.com/KindXiaoming/pykan/pull/98/commits/c857dd65b737ce5f1845555416ddef8ba7865ff8
I had the same problem #75.

You shouldn't just model.to(device), but rather create both model and dataset passing device=device argument. Besides, you're missing test_input and test_label keys for dataset


Equation labels are left out when rendered under SVG

In Chrome and Safari, when printing (e.g. Ctrl-P) the output, equation labels are not printed if the equations are rendered via SVG.
This works correctly in Firefox (and equation labels are printed in other rendering modes).

Thanks for the report. Could you provide a live sample where a problem occurs?
I suspect this is unfortunately expected behavior (but again, a live sample would clarify). Say I open this sample on my machine. Everything looks good. However, my viewport size is considerably wider than a print page. To print this page, Chrome has style the page to fit a print page (I don't know if they do more than apply a print stylesheet for this).
While the HTML/CSS output can use relative widths, SVG does not have that notion, so MathJax has to hardcode the width between the label and the equation (the width is calculated during rendering to fit the viewport width). As a result, if you modify the viewport size after MathJax SVG rendering is done, you'll cut off the lable -- and this is what happens during print-to-pdf.
What would have to happen is for MathJax to re-render the content once Chrome applies the styling it uses for printing. That way it could recalculate the width between equation and label under the constraints of Chrome's (or the page's) print stylesheet.
I don't know if there is a way to do so (besides generating a separate print version of the page with fixed width of a print page).

Ah I understand the problem -- that is too bad, but thanks for the explanation. (A live sample is available on my personal website here: http://www.kevinli.co/minimax-duality.html)

I think the following should work in theory -- but something goes wrong. Maybe ask on StackOverflow etc?
var mediaQueryList = window.matchMedia('print');
mediaQueryList.addListener(function(mql) {
    if (mql.matches) {
      MathJax.Hub.Queue(["Rerender",MathJax.Hub]);
    } else {
        MathJax.Hub.Queue(["Rerender",MathJax.Hub]);
    }
});
``


[DO NOT MERGE] Experiment Metrics Advisor - Add Grow-up methods

As an experiment to confirm that DPG can grow to a meaningful SDK, we want to experiment on Metrics Advisor:

Generate DPG of Metrics Advisor

Here is the generated code for DPG

Add grow up methods for all the operations mentioned here.
Run sample tests and live tests for all the operations mentioned here.

Adding the links for the grow up methods for all the operations mentioned here:

MetricsAdvisorClient

GetAllFeedback
AddFeedback
GetFeedback
GetMetricDimensionValues

MetricsAdvisorAdministrationClient

GetDataFeed
GetDataFeeds
CreateDataFeed
UpdateDataFeed
DeleteDataFeed

API changes have been detected in Azure.AI.MetricsAdvisor. You can review API changes here

API changes have been detected in Azure.AI.MetricsAdvisor. You can review API changes here

API changes have been detected in Azure.AI.MetricsAdvisor. You can review API changes here

API changes have been detected in Azure.AI.MetricsAdvisor. You can review API changes here

For listMetricFeedbacks method, next link function is generated as GetMetricFeedbacksNexts instead of GetMetricFeedbacksNext.
Pipeline is failing with the below error:
CSpell: Files checked: 2, Issues found: 2 in 1 files
cspell run complete, restoring original configuration and removing temp file.
./sdk/metricsadvisor/Azure.AI.MetricsAdvisor/api/Azure.AI.MetricsAdvisor.netstandard2.0.cs:211:76 - Unknown word (Nexts)
./sdk/metricsadvisor/Azure.AI.MetricsAdvisor/api/Azure.AI.MetricsAdvisor.netstandard2.0.cs:212:81 - Unknown word (Nexts)
##[error]Spelling errors detected. To correct false positives or learn about spell checking see: https://aka.ms/azsdk/engsys/spellcheck
Check here for more details.
Issue is being tracked here - https://github.com/Azure/autorest.csharp/issues/2074

API changes have been detected in Azure.AI.MetricsAdvisor. You can review API changes here

@ShivangiReja, would you be willing to create a "clean APIView" for this? By that I mean one that doesn't show the deletions of public methods from the API, but instead, only the addition of the protocol methods.

https://apiview.dev/Assemblies/Review/8a748256fc2447a29e464c9d1d6cf5a2?diffOnly=True&diffRevisionId=a51d3d13ed3b4214ba20ab6a2c0296c2

API change check for Azure.AI.MetricsAdvisor
API changes have been detected in Azure.AI.MetricsAdvisor. You can review API changes here

/check-enforcer override

/check-enforcer override

Were you able to address the string/Guid problem we discussed in the last DPG Design Meeting?
Would it be possible to update the custom APIView you created?

@annelo-msft

Were you able to address the string/Guid problem we discussed in the last DPG Design Meeting?

I've updated this PR.

Would it be possible to update the custom APIView you created?

https://apiview.dev/Assemblies/Review/a9812a1691e54ab4bf52540c4e54d433/66cd7343ae6c47988e3f8b3caf52617b?diffRevisionId=9260bdbf10e346b9ba8dac7399ea885b&doc=False&diffOnly=False

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.AI.MetricsAdvisor


Update aqua-data-studio to 18.0.12

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.
After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Confirmation of sha256: http://www.aquafold.com/download/v18.0.0/datastudio-18.0.12-sha256.txt

Thank you for your contribution and for the sha256 confirmation link!


heavy.com is clean

heavy.com (line 10708) doesn't contain porn, it's for "Breaking News, Sports, Entertainment, TV, Tech, Gaming & Health" .

Thanks, I will cover this in the future.


[IMPROVEMENT] Remove or Change Helm pre-upgrade hook to support ArgoCD

As of now, longhorn stopped working with ArgoCD, due to ArgoCD implementing helms post-upgrade hooks as PreSync (and they have no plans to change this, since they believe Helm charts should not use any pre/post upgrade hooks), causing it to run even the first time during installation. This causes the pre-upgrade job of Longhorn to fail, since the service account is not yet created.
It would be nice if this helm chart would be working in ArgoCD.
Also see this issue: https://github.com/argoproj/argo-cd/issues/7536#issuecomment-1656763866

Relates to: https://github.com/longhorn/charts/pull/126

@acelinkio can you also create a PR to longhorn/longhorn?

@c3y1huang
Additional pr opened https://github.com/longhorn/longhorn/pull/6421

I can see that this was added to the v1.6.0 milestone. Are there any plans for a v1.15 release? or a workaround we can use until then?
Thanks

@frg there is a partial solution to just apply the manifests manually via helm template--which is unable to apply any hooks.  From there hooks will have the resources to run properly.

@acelinkio Thanks for the suggestion but wouldn't this also disable the pre delete hook making uninstallation risky?
I think we'll have to go for v1.4, then a volume migration when we upgrade to v1.6. Can't find simple ways we can go around this.

Yeah... preselected hook is not supported.   I really don't know why these hooks are being used because none of these capabilities are available when doing the kubectl apply install method.  https://longhorn.io/docs/1.5.1/deploy/install/install-with-kubectl/

This will be backported to 1.5.

The pre-upgrade hook is only for the helm to prevent any invalid upgrade after upgrading the Longhorn setup to the new version, so it can ensure the current setup with the old version is intact if the upgrade hook failed.
If using kubectl apply to do the upgrade, the same behavior will be tackled but it's after the Longhorn manager pods have been upgraded, so if the upgrade failed due to an invalid upgrade path, users need to recover it w/ some little effort than the helm way. For more detail, go check https://longhorn.io/docs/1.5.1/deploy/upgrade/longhorn-manager/#upgrading-from-unsupported-versions.
However, we should tackle it better for GitOps solutions indeed.
cc @mantissahz add more context if anything I missed here.
cc @longhorn/qa

Without pre-upgrade hook, you need to take care of upgrade path by yourself. You would need to roll back to previous REVISION manually by the CLI command if upgrade failed.
Yes, having a switch to disable pre-upgrade hook is good.
I've tested the PR by helm upgrade with and without enabling helmPreUpgradeCheckerJob and it is fine but not tested for ArgoCD.

Any updates on having these merged?   Looks like everything passed review/testing

I have also encountered this problem and would be very happy to see a solution. Currently I install it by hand and only then activate ArgoCD to manage the app.

Commenting to keep in the loop on this.
We exclusively deploy to clusters using ArgoCD so this is preventing us from installing Longhorn and I'll probably have to investigate Linstor or OpenEBS unless this gets through in the next few weeks.

https://github.com/longhorn/longhorn/pull/6421 the PR is not merged yet,
@QuinnBast @mrclrchtr you might be able to follow the PR to disable the pre-upgrade check.

Thank you guys for fixing it. Will be there any Docker image or Helm chart release soon to integrate this?

Agreed, the 1.5.1 chart doesn't seem to have these updates applied yet.

Thank you guys for fixing it. Will be there any Docker image or Helm chart release soon to integrate this?
Will disabling this job have any negative effect?

We are going to release 1.5.2 on 11/6 that week and it will include this fix.
Disabling it will have some effects but not negative ones. Please check this comment, https://github.com/longhorn/longhorn/issues/6415#issuecomment-1667718648.

This is still not working after pulling 1.5.2...

waiting for completion of hook batch/Job/longhorn-pre-upgrade

Error creating: pods "longhorn-pre-upgrade-" is forbidden: error looking up service account longhorn/longhorn-service-account: serviceaccount "longhorn-service-account" not found

Does this fix work with 1.6.0? For some reason with 1.6.0 I am again not able to install even with using the helmPreUpgradeCheckerJob.enabled: false
Have anyone tried it?

OK I see it was renamed.

OK I see it was renamed to preUpgradeChecker.jobEnabled, this is actually a breaking change for the chart, which is not reflected by the chart version.

Thanks! I followed the official documentation, but this still shows the old name. (https://longhorn.io/docs/1.6.1/deploy/install/install-with-argocd/)
This helped me deploy with argocd!


Link color in info boxes

Closes https://github.com/pandas-dev/pandas-sphinx-theme/issues/35
Closes https://github.com/pandas-dev/pandas-sphinx-theme/issues/38
Before:

After:

Fixed my padding issue to
Before

After

I've increased the size for h1 and h2 to give more contrast between h2 and h3, especially when they're right after eachother
Before

After

These all seem like good changes to me! Thanks for the improvements!

@TomAugspurger Thanks!


Cloud Spanner - Warning: number of channel maxed out bounded

Hi,
Using google cloud spanner I'm getting some of those warnings printed directly to stdout:
[Warning] The number of channel for the target spanner.googleapis.com:443 is maxed out bounded.
[Warning] Target upper bound: 1. Current size: 1.
[Warning] Target spanner.googleapis.com:443 will not be persisted.

They occur randomly when I run DML select.
Is it an issue rised from spanner, or from the php lib? If it's from the library can you, please, help to figure out what is causing it and how to avoid it or possibly how to increase the given limitation?
I found the spanner doc to be more succinct than other GCP products and sometimes some things are not mentioned in both of the php lib doc and the spanner doc.
Environment details

OS: Linux
PHP version: 7.0
Package name and version: google/cloud v0.84.0

Hey there @gsouf. Would you be able to share the code you're running, which version of the gRPC extension you have enabled, and whether or not you are using php-fpm?
From what I can tell, this warning seems to be bubbling up from the gRPC extension.
@WeiranFang, @ZhouyihaiDing - Do you think this could be related to google/grpc-gcp?

For spanner in google/grpc-gcp, it sets the upper_bound to 10 at least. I am expecting the warning shows something like Target upper bound: 10 instead of 1. Probably the config file in google/grpc-gcp is not parsed correctly?
The background for the upper bound: in case that the number of channels grow infinite under the php-fpm, we have a upper bound(by default is 1) for it. When the upper bound is arrived, and none of the existing persisted channels can be removed(not disconnected, not idle, etc), we will dump this warning because this channel will be destructed when the script finishes.

Thanks for the response,
@dwsupplee Here is the code I'm running, at least the various parts involved with spanner:
$client = new SpannerClient();
$instance = $client->instance('someinstance');
$db = ->database('somedb');

$db->execute('SELECT somefields FROM sometables' , [
    'parameters' => [
        'someparam' => 'somevalue'
    ]
]);

I also observed it when running some $db->insertOrUpdate or $db->insertBatch, or maybe transaction not sure which as I didn't have any stack trace.
But it does not happen everytime, I only observed it a very few times.
It produced via http behind php-fpm indeed, but it also produced in cli as often as in php-fmp.
Something I noticed, but I cannot guarantee it's true: it looks like it will happens once per script probably when the initial connection to spanner is initiated. I mean I started a mass insert recently that run for hours and will do many insertBatch calls, and I observed that warning only at the begining of the script and not even once after that.
Note that we dont use spanner a lot yet as it's just on development machines for now but we still might have multiple of those queries invoked at the same time by different php processes (cli or fpm).

google/grpc-gcp version: 0.1.2
grpc module version: 1.16.0

@ZhouyihaiDing is there anything I can do to verify that everything is going right with upper_bound config? As I just said I also ad the exact same issue on cli ( Target upper bound: 1.)

We've been having trouble reproducing this and there have been a few changes to the google/grpc-gcp library that may have resolved this since the issue has been opened. I'm going to close this out for now, if anyone else runs in to this please feel free to re-open.


Merge compatible to berkeley apr17 2024

Just a merge
Also includes a warning fix (that should have happened in one of previous merges)

!ci-build-me

!approved-for-mainnet


Consistent UI labels

all the labels, drop down menus, filters, etc should use the same titles throughout the application.  See #527, #528, #529 for suggestions and wording preferences.

Can we relabel: College Names to ‘Colleges and Main Units’
Mission Area labels to be renamed as Project or Community Partner Mission Area

Engagement-Type report COMPLETE

Test document: https://drive.google.com/open?id=1Ym_TWrHELQIjOHVJT60L4czuPK_U6jwePXSZHUDn6Sc


Compare with Lumino?

Very nice! Have you considered using https://github.com/jupyterlab/lumino, too?

Hi @deeplook, it's surely feasible with lumino. It's just my personal choice to save time since I'm more familiar with the FlexLayout library. In fact, except for the layout manager, I reused all the UI components and CSS  from jupyterlab


0.75.1: Communication corruption on native USB!

Getting some really weird corruption on communications with server 0.75.1 running on Raspberry Pi 3 - with Jesse. (Running armhf version.)
0.75.1-log.txt
Connecting the same cable to pc shows normal communications.
This is the native Arduino Due USB port so the vcp baudrate should not matter, but it is matching the firmware. (It actually doesn't work if not matched!)
I also notice that protocol choice is gone from 0.75.1 ?
Being a stickler for the binary protocol I never had these issues before.

You never could select protocol in server since quite a while. It was always preset in firmware xml definition file and for repetier defaults to binary.
Log shows the the binary protocol is not the problem, that direction seems to work. Only answers seem not able to have more then 3-4 correct chars in a row. Have you compiled firmware for both ports or native serial exclusively? Have Pi 3 running with programming port with no issues. Would that work on your pi 3 or also cause problems? I mean server does not distinguish between those - absolutely same code. So normally I'd assume the same problem if it comes from server - or there is a difference I currently don't see.

Interesting.
I have it set to allow use of both ports but it does not work on the prog port.
Not on pc nor on pi.
It is strange however that it does work on pc.
(Albeit I have had 3 hangs where everything just locks up and a reset of pi is not enough and I need to disconnect host, reset pi, and then reconnect host to get the VCP back. Happened on random spots running git master fetched 3 days ago.)

Btw, with echo on it's hard to see what is coming from where, especially on Repetier Host.
There should possibly be a way to turn on a byte in the log to indicate H or P for host or printer?
I see ju,mps in temp graph to 2000+ btw when it apparantly misinterprets or somehow gets data corrupted. With binary protocol this should never be possible though???

Binary protocol is only in sending direction, answers are always in ascii. Adding a resend/verify here would drop speed significantly so that is no real option. Only thing would be adding a checksum so host knows if it can trust the answer. Would at least solve the temperature jump problem.
The temp. jumps are errors in temp. reads where a digit was added. Happens if communication is working bad.
One critical thing on Pi 3 is power/voltage. It is very sensitive on voltage so you need AWG20 usb cable and a good power unit. I think the official raspi power delivers more then 5V. If you have a screen connected you can see it on the rainbow that power is critical. This causes often hangs/reset on serial connection and errors.
Regarding log I have to think how many lines would be affected by that problem. Most come from server as it does all the work, only slicer and some other info messages would come from host.

Got some more data here and it appears it may be a interface problem due to bad tolerance on crystal on the due board.
I will do some accurate measurements later but i did find that the prog port didn't work at 230400 baud without massive corruption. At 250000 it does work but I suspect this is because this rate is a correct multiple so the errors do not compound. I'll measure the actual clock on the sam3x later to verify but so far it appears to be the issue.
What is bad however is the inability over native usb to recover the connection.
This could possibly be related to windows though as it requires unit to reconnect after the program has closed the port, or the port will be busy/locked and unable to re-establish link.
Using the prog port which will always be up regardless of firmware state seems simply put a stabler and safer alternative.  Sad but true.


Uploaded files contains an empty UploadedFiles …

… when no file is supplied.
That is, I have a form for uploading images, and sometimes we don't want an image. Reading the comment on $request->getUploadedFiles(): @return array An array tree of UploadedFileInterface instances; an empty array MUST be returned if no data is present suggested to me that I should be able to go if (! empty($request->getUploadedFiles()) and then move into what I do with the images. However, that's not working. Instead, it returns:
Array ( [file] => Array ( [0] => Slim\Http\UploadedFile Object ( [name:protected] => [type:protected] => [size:protected] => 0 [error:protected] => 4 [sapi:protected] => 1 [stream:protected] => [moved:protected] => [file] => ) ) )

Am I misunderstanding something? How are you intending to check whether a file was uploaded or not? I can check $_FILES, but I prefer working with as few globals as possible.
Also, thank you for your good work, I'm enjoying using Slim.

$_FILES will be parsed as an array of UploadedFileInterface
You'll need to check the same way you would do with $_FILE.
Something like:
$image = $request->getUploadedFiles()['file']; //your upload image form name is file, right?
if($image->getError() != UPLOAD_ERR_OK){
    //You don't have an image :)
}

If you could have more than 1 image named file: $image will be an array of UploadedFileInterface

Thanks =) Alright, so I’d misunderstood what the interface demanded.
This can be closed

2 mars 2016 kl. 17:36 skrev Matheus Marques<EMAIL_ADDRESS>$_FILES will be parsed as an array of UploadedFileInterface
You'll need to check the same way you would do with $_FILE.
Something like:
$image = $request->getUploadedFiles()['file']; //your upload image form name is file, right?
if($image->getError() != UPLOAD_ERR_OK){
//You don't have an image :)
}
If you could have more than 1 image named file: $image will be an array of UploadedFileInterface
—
Reply to this email directly or view it on GitHub https://github.com/slimphp/Slim/issues/1792#issuecomment-191317346.


Improve automatic language detection in ployglot notebooks

Improve the language detection in ployglot notebooks by language detection in cell content, workspace stats, etc.

Thinking through this a bit, it's probably the case that almost all of the time your notebook will be in the same language. So it could be nice to instead have some sort of "the current language isn't correct, please use a different one" command. On "normal" notebooks this would end up being just a toggle between the notebook's one code lang (python, gh issue query, etc.), and markdown. In polyglot notebooks it'd do some sort of ML-assisted cycling: "current cell is python, user says pick a new language, so run the detector on all the languages the notebooks supports except python, and set to what what it says".
What do you think about something along those lines?


Memory leak on accelerate.init_empty_weights

System Info
- `Accelerate` version: 0.18.0
- Platform: Linux-5.15.0-82-generic-x86_64-with-glibc2.31
- Python version: 3.10.12
- Numpy version: 1.25.2
- PyTorch version (GPU?): 2.1.0+cu121 (True)
- `Accelerate` default config:
        Not found

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
import tracemalloc
import psutil
import gc
import torch

from diffusers.models.autoencoder_kl import AutoencoderKL

f = open("tracemalloc.txt", "w")
process = psutil.Process()
tracemalloc.start()

for i in range(1000):
    tracemalloc.reset_peak()
    kwargs = {'torch_dtype': torch.float16, 'device_map': None, 'max_memory': None, 'offload_folder': None, 'offload_state_dict': False, 'variant': None, 'low_cpu_mem_usage': True}
    AutoencoderKL.from_pretrained("./vae", **kwargs)

    size, peak = tracemalloc.get_traced_memory()
    log = f"iter {i+1}: current size: {size}, peak size: {peak}, threshold: {gc.get_threshold()}, cnt: {gc.get_count()}, mem: {process.memory_info().rss}\n"
    print(log)
    f.write(log)

tracemalloc.stop()
f.close()

These iterations cause memory leaks.

Log (1,000 iteration): tracemalloc.txt

I found the leaks come from accelerate.init_empty_weights: https://github.com/huggingface/accelerate/blob/9fd64b7ea994dd34345d42b75372e9dc771d5301/src/accelerate/big_modeling.py#L51
Actually, PyTorch makes this issue when it initializes the parameters on meta device.
With other devices (e.g. cpu, cuda), it doesn't leak the memory.
nn.Module.register_parameter(module, name, param)
module._parameters[name] = torch.nn.Parameter(module._parameters[name].to("cpu"), **kwargs)   # NO LEAK!
module._parameters[name] = torch.nn.Parameter(module._parameters[name].to("cuda"), **kwargs)  # NO LEAK!
module._parameters[name] = torch.nn.Parameter(module._parameters[name].to("meta"), **kwargs)  # LEAK!

Expected behavior
I suggest adding an option for device for init_empty_weights.
For example,
@contextmanager
def init_empty_weights(include_buffers: bool = None, device: str = "cuda"):
    if include_buffers is None:
        include_buffers = parse_flag_from_env("ACCELERATE_INIT_INCLUDE_BUFFERS", False)
    with init_on_device(torch.device(device), include_buffers=include_buffers) as f:
        yield f

Log (1,000 iterations with cuda - No leaks): tracemalloc_cuda.txt

Probably best to open this on pytorch then, and just use init_on_device instead for them to fix the root of the issue rather than directly changing a critical part of the Accelerate API.


[7.11.24] Add contact as choice for "insert" in TinyMCE

Motivation

Contact information referred in contents are changed and updated centrally. This is why we implement a new model "contact". Let's give it a place where it shines.
Proposed Solution

Add an "contact" to the option "Insert" in TinyMCE, like Media Library and Link.
Where each contact is embedded, must be calculatable and handed over in contact_form.view (search for # to implement later, how do we collect such pages?).

Alternatives

User Story

Additional Context

Wait for #2952
Design Requirements

One idea how we could do it:
Represent contacts as urls and add a new url endpoint to the cms that returns contacts. When a user inserts a contact in tinymce we would just insert the url to it (plus maybe some parameters that specify which fields of the contact should be shown).
Advantage:

We won't have to update any pages when a contact changes
We easily figure out in which pages contacts are used using linkcheck and prevent users from deleting contacts if they are still used
We don't include any styling in the html and leave that up to the app

Disadvantage

The App team would have to write some custom code to correctly render these urls as contacts in the app

We can make non-editable elements in TinyMCE by adding the HTML attribute contenteditable="false". I would propose to put the div with all that should be displayed for the content inline this way.


how to set bool=True in im2rec.py

In the im2rec.py, how to set shuffle=True to False?

I have sent a PR to fix the issue you noticed. You can either merge in this change, or as a workaround you could do --shuffle '' . (Note that this is two single apostrophes, not quotation mark). This passes an empty string which sets shuffle to False.

Thank you!


Provide empty fallback value for API_TOPIC_PREFIX in create-topics.sh

Prevents the script from failing when API_TOPIC_PREFIX is not explicitly set.

Addresses issue - https://github.com/DependencyTrack/hyades/issues/343


upgrade to ver 1.2. Addition of symbolic constants.

@JuliaRegistrator register

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.


Recursively serialize numpy array in as_dict

Summary
Fixes #1424
Details and comments
The serialization function for QobjItems was not recursively serializing numpy arrays.

@diego-plan9 @ajavadia what do you think about adding the following serialization function:
if hasattr(obj, 'as_dict'):
    return obj.as_dict()

So if we have custom Python objects as parameters in QobjItems they can define their own serialization function. This would be extremely useful for more complicated snapshot objects in the future.
This would also replace the line:
if isinstance(obj, QobjItem):
      return obj.as_dict()

Thanks for taking care of this bug @chriseclectic. The list and dict were recursively serialized, but we had missed the numpy array.
Should the code here do if-elif-else rather than a bunch of if statements? @diego-plan9

Thanks @chriseclectic !

Should the code here do if-elif-else rather than a bunch of if statements? @diego-plan9

Since they are if ... return, it is not really worth blocking over - specially since eventually we will move Qobj to the model system.


Remove / trimming on the end of href

The Problem
When using the  component the href value gets striped of any '/' at the end.
Example:
Users
becomes
Users
in the html. This behaviour is irritating for developers especially since the route could handle links with '/' at the end just fine. This PR is changing the behaviour of the normalise function to correct the behaviour.

I think the challenge here is /users/ and /users ultimately need to match the same route.  The one that has caused more issues in the past is the root url http://mysite.com versus http://mysite.com/.  Or if there is a baseUrl in configuration.  Also, some servers append the trailing slash on initial page load and others don't - and of course folks can link to either from outside.
The normalizePath function is not only used for .  It is also used to normalize the route when matching - so it really needs to result in the same output whether there is a trailing slash in the input or not.  It is also used when joining path parts where it needs to strip the trailing slash to avoid double slashes.
If optionally keeping the trailing slash in the  href is really a concern then it probably needs its own regex.  It would be good to keep the code located close to the existing normalizePath function though as they need to (almost) "match".

I understand the problem that '/users/' and '/users' must finally point to the same route. However, I think the way the routes look inside the application should be chosen by the developer. It leads to a bad experience if links don't look like the developer described them in his code. In addition, in some frameworks the router makes a distinction between '/users/' and '/users'.
In my tests the router can already handle '/users/ and '/users' without problems even with the changes to the 'normalizePath' function. Also I could not find any situation where double slashes occur. Even when merging paths it should not happen, because all double slashes are always removed at the beginning and only one remains at the end. This can also be seen in utils.spec.ts in line 243.
So to me it seems like the changes should be fine. Could you construct a case where my changes break the router?

I think the challenge here is /users/ and /users ultimately need to match the same route. The one that has caused more issues in the past is the root url http://mysite.com versus http://mysite.com/.

Sorry to hijack but in that case do you know how I can get activeClass to match both /path and /path/ in combination with end (since I don't want to match /path/something?


New command: planner plan get

Usage
planner plan get [options]
Description
Retrieve information about the specified plan
Options

Option
Description

-i, --planId <planId>
The Id of the plan

Additional Information
GET https://graph.microsoft.com/v1.0/planner/plans/{plan-id}
Example
m365 planner plan get -i gndWOTSK60GfPQfiDDj43JgACDCb

Thanks for the suggestion @Abderahman88 👍
Want to take it?

Yes @garrytrinder. You beat me first on the question 😄

Is there also a way to get the plan based on its name?

@waldekmastykarz A possible way is to search in a certain group and filter the correct plan.
This method is used by the PnP-Powershell.
Get-PnPPlannerPlan -Group "Marketing" -Identity "Conference Plan"

But getting a random plan by name (without group), I doubt there is an endpoint for this.

The reason why I'm asking is because users are more likely to know the names of the group and the plan rather than their IDs. So if we'd require IDs, they'd need to manually look them up which isn't convenient. That's why I think we should consider simplifying it.

I definitely agree with you. For users, it's much easier with the name.
I think we need to support both cases.

Get plan with id (mainly for plans not associated with a group / more usefull in script, build pipelines, ...)

m365 planner plan get --id gndWOTSK60GfPQfiDDj43JgACDCb

Get plan with name (easier for common use)

m365 planner plan get --name myPlan --ownerGroupName MyGroup
m365 planner plan get --name myPlan --ownerGroupId MyGroup
The group-property is necessary in this case, because the list all plans depends on it. In MS Graph, there in no REST call to get all (non group/group related) plans.

Good options. Could you update the spec so that it reflects our latest thinking? Thank you! 👏

To stay consistent with existing commands, I'll need to change name-property to title.


Install additional php module after deployment

I failed to notice that php-ldap was not included in the build scripts prior to deployment.  I certainly noticed after I migrated an existing site and got the notice.
How can I update the vmss to install the php-ldap module? Any pointers would be appreciated.
Deployed using the "small to midsize" template (modified to use 18.04 as the base).
Thanks!

Would love to accept any PRs around supporting php-ldap module as part of the template.


Changing class prop breaks display

I am trying to change the class in a vue way, so I can change the color based on certain input.
Example:
https://jsfiddle.net/afr80kpm/1/
I see this was requested in another issue https://github.com/vueform/slider/issues/17 , although I feel that is a very hacky way around it.
It would be better if I could set a computed property to the props and have it update automatically without having to worry about dom and such.

It is breaking the display, because you're overriding the container class of the Slider, which gets replaced by nouislider and probably Vue does not insert that to the vnode tree.
An easy (and I think even better) workaround is to wrap the slider to a div and set the computed class on that.


Fix unused import in Go discovery sample gen

Change to template means "fmt" is no longer used when response is
empty.

Current coverage is 78.91% (diff: 100%)

Merging #529 into master will not change coverage

@@             master       #529   diff @@
==========================================
  Files           248        248
  Lines          9089       9089
  Methods           0          0
  Messages          0          0
  Branches       1184       1184
==========================================
  Hits           7173       7173
  Misses         1608       1608
  Partials        308        308

Powered by Codecov. Last update 184ab47...cf37538

lgtm

LGTM


Input parameters ranges cannot be defined

Parameters ranges (authorized values) cannot be defined as additional properties, listed within each input parameter element. It would be helpful to express a range for a parameter in CWL, and have it exposed within the OGC API Processes interface, for any input parameter.
For example:

for AOI: multiple areas (expressed as multi-polygon)
for dates: multiple time intervals (expressed as Start date - End date tuple)

This has to be addressed at CWL specification level - requires engaging with the CWL team.
@fabricebrito What is the next step here?

CWL supports enumerations with symbols see https://www.commonwl.org/v1.2/Workflow.html#InputEnumSchema and https://www.commonwl.org/v1.0/CommandLineTool.html#CommandInputEnumSchema
@simonevaccari is this the feature you're looking for?


Add files via upload

Instructions:
use W/S to navigate toppings
use D to select
copy the burger on the left
select bell to confirm burger
select trash can to clear
If you get it incorrect 3 times you fail
Your checklist for this pull request
kevin
kevin:

burger_game
What is your game about?
make burgers
How do you play your game?
Instructions:
use W/S to navigate toppings
use D to select
copy the burger on the left
select bell to confirm burger
select trash can to clear
If you get it incorrect 3 times you fail
Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[ ] The image is in the /games/img directory.
[ ] The name of the image matches the name of your file.

Thanks for your PR!

I get this error when trying to play the game.

Hello,
I think the file may have been corrupted. I believe I have fixed it and
re-uploaded the game to GitHub. Thanks.
On Wed, Sep 18, 2024 at 11:07 AM Cheru Berhanu @.***>
wrote:

I get this error when trying to play the game.
Screenshot.2024-09-18.at.11.06.33.png (view on web)
https://github.com/user-attachments/assets/fd72d3c2-6687-46ae-af7d-82be52b77190
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/2301#issuecomment-2358734614, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BLBZWCIZIEOIATTYUYGA5ODZXGJKFAVCNFSM6AAAAABNXKOV66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJYG4ZTINRRGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hello,
Thank you for reviewing my game! Glad you enjoyed it. Looking forward to
getting my sprig!
Thanks again,
Kevin
On Tue, Nov 26, 2024 at 11:47 AM Mare Cosmin @.***>
wrote:

@.**** approved this pull request.
Hey! I liked going through your game, and all the mechanics seem to work
now. Sorry for the long time it took to re-review this!
If you're a teen, you can get your sprig here!
https://sprig-order.hackclub.dev/
Hack Clubbers would love to see this! Just post a link and 1-2 sentences
talking about your game to our #ship
https://hackclub.slack.com/archives/C0M8PUPU6 channel
https://hackclub.com/slack/:)
—
Reply to this email directly, view it on GitHub
https://github.com/hackclub/sprig/pull/2301#pullrequestreview-2462137204,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BLBZWCKDA7IX5F3HUE2EUT32CSQZHAVCNFSM6AAAAABNXKOV66VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINRSGEZTOMRQGQ
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


container background code in web-analogs document can be simpler.

In styling and aligning text section of the web-analogs document:
  decoration: new BoxDecoration(
    backgroundColor: Colors.grey[300],
  ),

section could be simplified to
color: Colors.grey[300]
because of a recent commit

cc @LarkAscending

Thanks for the suggestion!

Thanks, actually there are 5-6 more instance of
decoration: new BoxDecoration(
    backgroundColor: Colors.grey[300],
  ),

in the page. Does your change fixes all of them?

Nope, sorry.
Would you be willing to send over a PR?

https://github.com/flutter/website/pull/437


Remove old cmake find modules

Remove bundled FindGSL.cmake and friends.

https://github.com/votca/csg/pull/252


Support dataclasses with frozen=True

Currently there is logic that attempts to cast dataclass values by progressively setting the field values. This casting logic runs even when none of the field values would actually be changed. For dataclasses with frozen=True set, this fails. We should fix this.

This is supported when checked with Sematic 0.32.0.


Update sbt-ci-release to 1.8.0

About this PR
📦 Updates com.github.sbt:sbt-ci-release from 1.7.0 to 1.8.0
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.sbt", artifactId = "sbt-ci-release" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.sbt", artifactId = "sbt-ci-release" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #286.


Add component that can add/remove components from the actor

This allows the pacman ghosts to change behaviour when something happends.
Like dude eats awesome candy

Ahhh good idea!


How to Convert UWCR dataset to the dataset given in The RAMP-CNN paper

Table 2 of the RAMP-CNN paper, this code belongs to, it is shown the sizes and frames of the dataset used for RAMP-CNN.

I see you have given the Raw UWCR dataset dataset, but the program code presented here is shown with a sample dataset, to understand it. Even I don't understand that the UWCR dataset data given has 898 * 20+897 * 2 = 19754 frames. But you have shown in table II, that the test dataset itself has 25098 frames.
So, would you please tell how the dataset is created, as shown in Table II of the paper?

Sure. The provided UWCR dataset is just a portion of the complete dataset we collected and used in the RAMP-CNN paper. Therefore, the number of 19754 frames does not match the number in the paper.

Thanks. What about this reply this reply you have provided?. Does this CRUW Dataset is same as UWCR dataset or it has full dataset.

CRUW Dataset is also partial and only provides the processed range-angle radar images & camera images


Need data to validate the Plug-in Gait joint kinetics expressed in the proximal frame

The code is available but was not tested nor validated.

I have data , with joink kinetics expressed in distal, proximal and global frame. I can share it

This would be perfect! Can you provide these data for a same anonymized subject using the basic variant of Plug-in Gait?

Subject information (subject measurements for the Plug-in Gait model, marker diameter, etc.)
Calibration trial stored in a C3D file
Dynamic trial stored in a C3D file with the kinetics results exported in the distal frame
Dynamic trial stored in a C3D file with the kinetics results exported in the proximal frame
Dynamic trial stored in a C3D file with the kinetics results exported in the global frame

Important: For validity's sake, it is important not to filter data for all the trials. Like that, we could better explain possible differences in the inverse dynamics algorithms. This is the same for the force plate to foot assignment. If you can assign the force plates manually, it might reduce the difference between the results.

yes of course. i didn t think you need it
2016-11-13 14:58 GMT+00:00 Alzathar<EMAIL_ADDRESS>
This would be perfect! Can you provide these data for a same anonymized
subject using the basic variant of Plug-in Gait?

Subject information (subject measurements for the Plug-in Gait
model, marker diameter, etc.)
Calibration trial stored in a C3D file
Dynamic trial stored in a C3D file with the kinetics results
exported in the distal frame
Dynamic trial stored in a C3D file with the kinetics results
exported in the proximal frame
Dynamic trial stored in a C3D file with the kinetics results
exported in the global frame

Important: For validity's sake, it is important not to filter data for
all the trials. Like that, we could better explain possible differences in
the inverse dynamics algorithms. This is the same for the force plate to
foot assignment. If you can assign the force plates manually, it might
reduce the difference between the results.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/OpenMA/openma/issues/28#issuecomment-260191093, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC9GBTjsNc3wqfmoVrKnJzEg-Ae8dsLhks5q9yWOgaJpZM4KqLCh
.

--
Fabien
Fabien Leboeuf
Research fellow ( University of salford)

phD Mechanics-Biomechanics (university of Poitiers, FRANCE)

College of Health & Social Care
University of Salford
Allerton Building
Frederick Road Campus
Salford, M6 6PU, UNITED KINGDOM

Hi,
you will find attached  normal gait c3ds with kinetics expressed in distal, proximal and global referential.
the processing was carried out with Nexus 2.3.  Static enables flat foot option and no tibial torsion. Marker diameter is 14 mm.
i hope that can help you
cheers

i don t manage to upload files with github.
You can get files from my dropbox : [(https://www.dropbox.com/sh/amzx252vneorjf0/AAArkcfjyXjTw2rP1KPq6ISCa?dl=0)]


[Monitor]support setting default metric alert rules

Fix #11085
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

@qwordy Hi. Please review this PR. Thanks!

close this PR first since it may not be needed anymore


Combining metrics

I have a metric that comes from different hosts exported by node_exporter. Due to the way it's exported it has two different labels: env and instance. I'd like to remove them for a set of metrics but once I do so a query error appears:
(label_replace(label_replace(domain_check_expiration_date,"instance", "", "instance", ".*"),"env", "", "env", ".*") - time()) / 3600/24 < 14

Error executing query: duplicated label set in output of label_replace(): domain_check_expiration_date{job="node", name="example.org"}

This metric comes from two hosts for redundancy reasons but it should be aggregated as a single one. How can I do this? I'm fine to move to a blackbox_exporter but I don't see cmd support there and expect to get same issues with duplicates.

What are you expecting as the output? The error is because what you've requested results in clashing time series, and there's no sane semantics for that.

Also as a general note adding additional duplicate exporters for redundancy is often more hassle than it's worth. In this case even if you have a single exporter that fails, you'll have many days to get it back up and running which is more than enough time to get domains renewed.

I have some other metrics that should be duplicated. At the moment I have redundancy for all the prometheus stack including prometheus itself and an alert manager and I'm very happy with the way it works – no duplicated alerts at all.

What are you expecting as the output? The error is because what you've requested results in clashing time series, and there's no sane semantics for that.

Good point. In this particular case I'd like to get min value but once I apply the min function all the labels got lost. So at least it's possible to create a personal rule for each domain and use the min function. Is there way to avoid this?

I believe you meant without – I wasn't able to create a valid queue with ignoring.
And it did work, thank you so much!
(min(domain_check_expiration_date) without (job,env,instance) - time() )/3600/24

Oops, with ```without I still get two results but they are similar, should this result in a single alert?

Are you sure you've removed all the labels you need to?

I am, I have now two labels left:
{host="some_ip_here",name="example.org"}

And the values are expectedly equal.

Oops, my bad, IP were different. Closing this now, thank you again!


Add updateBranch parameter to CheckForUpdates action

Issue: Running the "Update AL-Go System Files" with directCommit set to 'Y' always creates a PR that targets the main branch insted of the branch the action was invoked on.
Solution: Add an updateBranch parameter to CheckForUpdates action and corresponding script to use as a target branch when creating a PR with the updates. By default, the updateBranch should be the branch the action is run on.

Shouldn't there be a change in UpdateGitHubGoSystemFiles.yaml from both the PTE and the AppSource templates as well?
If you made the changes in your versions of the AL-Go-PTE and/or AL-Go-AppSource, then the change would be collected to f.ex.
https://github.com/microsoft/AL-Go/blob/main/Templates/Per Tenant Extension/.github/workflows/UpdateGitHubGoSystemFiles.yaml

Shouldn't there be a change in UpdateGitHubGoSystemFiles.yaml from both the PTE and the AppSource templates as well? If you made the changes in your versions of the AL-Go-PTE and/or AL-Go-AppSource, then the change would be collected to f.ex. https://github.com/microsoft/AL-Go/blob/main/Templates/Per Tenant Extension/.github/workflows/UpdateGitHubGoSystemFiles.yaml

No, no changes are needed there. The default branch will be github.ref_name (the branch the workflow is invoked on).
Initially, I didn't want to add it as a parameter for action CheckForUpdates because why would anyone want to use another branch. However, it has to be a parameter for the script CheckForUpdates and there is a test that verifies that both the action and the script have the same parameters.

Got it, thanks

End 2 End tests are failing because no NextMajor is available at this time - will wait for that.
(Should happen today)


Some issues

Holes of different types could have different colors

Holes should really have tooltips saying what type they are

I managed to create a  definition statement, and fill in the name hole with Add Fresh (which btw is great!!!) but can't figure out what can be done with the other hole... which should be  aterm or statement but neither of those is accepted

1 and 2: Yes, great ideas! But the language I defined here doesn't have types yet.
3: When you create a definition statement, the second hole is a term. (not a term statement, which is what Add Term would try to do, add a statement that is just a term. Like writing 3; in C) You can try Add Lam for example. I know it's a bit confusing, if I keep working on this I'll make that more clear.


ci: update dependabot labels

Reason for Change:

Hard to easily discern and sort which dependencies are being updated for each release train. Adding existing release/* and pkg labels to respective dependabot PR(s).
Issue Fixed:

Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[x] relevant PR labels added

Notes:

Did not use release/latest label for current master/default branch as this will mix the next release train in with an older label. We should consider creating a release/1.6 label or use a different process.

/azp run Azure Container Networking PR


Update airframe-log to 22.2.0

Updates org.wvlet.airframe:airframe-log from 22.1.0 to 22.2.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.wvlet.airframe", artifactId = "airframe-log" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #357.


commandInstruction  doesn't show the right command in npm run ... situations

If this is still valid, can you give an example?

I don't remember the example of this that we had before. If it pops up again I'll file a better issue.


Text dropshadow color is wrong and it is being affected by the outline stroke

3 examples with a red dropShadow with blur.

var app = new PIXI.Application(300, 300, {backgroundColor: 0x1099bb});
document.body.appendChild(app.view);

var style = new PIXI.TextStyle({
    fontFamily: 'Arial',
    fontSize: 36,
    fill: '#ffffff',

    strokeThickness: 5,

    dropShadow: true,
    dropShadowAngle: Math.PI/2,
    dropShadowDistance: 45,
    dropShadowColor: '#FF0000',
    dropShadowBlur: 5
});

var text = new PIXI.Text('Sample Text', style);
app.stage.addChild(text);

Same code without the strokeThickness set to 1. You can still see the drop shadow blur is red but the shadow itself is now black instead of red.

Same code without strokeThickness. You can barely see the drop shadow blur but the shadow itself is now completely black.

This is fixed in the latest dev branch via https://github.com/pixijs/pixi.js/pull/4069

Oops sorry, I forgot to take a look at closed issues I just looked in the open ones. I didn't think about the possibility of it being fixed already.
Thank you.


Update msg fields to include units

The msg fields now include units for greater clarity.
These units reflect the data that is directly outputted from
the sensors as noted in:
https://ubcsailbot.atlassian.net/wiki/spaces/ADA2/pages/506167525/CAN+Bus+Inputs+and+Outputs
Note: From what I've been told, the ais' gps is intended to be
used as a backup. These fields are not currently being stored
in the network table. Further investigation is required.

Updated the gps_timestamp units to indicate 'utc' standard - I think this is more clear and useful information

From Simon: some fields have more precision.
gps, gyroscope, accelerometer should be switched to float32

Clarification Needed:
gps lat and lon are actually received in 'degree, minutes, decimal minutes' convention.
Ie. Longitude (degree, minutes, decimal minutes DDMM.MMMMMMM)
Is this the form you want it in? The data has to be processed once received from the CANbus anyways, so I can separate it into degrees, minutes, and decimal minutes.

@brucecui97 Do you need to know the actual angular position of the winch itself (ie. how much of the rope is in)? The only "feedback" of the rigging is the Sailencoder (boom angle), but I can add a frame that reports the angular position reported by the winch motor.

@brucecui97 Do you need to know the actual angular position of the winch itself (ie. how much of the rope is in)? The only "feedback" of the rigging is the Sailencoder (boom angle), but I can add a frame that reports the angular position reported by the winch motor.

good point, thanks for asking! I actually haven't thought too much about the low-level sail controller yet, but currently I think it's helpful to have both:

actual angular position of the winch itself (ie. how much of the rope is in)
Sailencoder (boom angle)

@brucecui97 Do you need to know the actual angular position of the winch itself (ie. how much of the rope is in)? The only "feedback" of the rigging is the Sailencoder (boom angle), but I can add a frame that reports the angular position reported by the winch motor.

good point, thanks for asking! I actually haven't thought too much about the low-level sail controller yet, but currently I think it's helpful to have both:

actual angular position of the winch itself (ie. how much of the rope is in)
Sailencoder (boom angle)

Updated in https://ubcsailbot.atlassian.net/wiki/spaces/ADA2/pages/506167525/CAN+Bus+Inputs+and+Outputs. @brucecui97 @briellelaw Please check updates for CAN IDs 0x50, 0x51, 0x53, 0x54.

Just curious can we merge this now?

From Simon: some fields have more precision.
gps, gyroscope, accelerometer should be switched to float32
gps lat/lon from float64 to float32?

I personally think let's be consistent and convert everything to float 32

From Simon: some fields have more precision.
gps, gyroscope, accelerometer should be switched to float32
gps lat/lon from float64 to float32?

I personally think let's be consistent and convert everything to float 32

Agreed, If anything, if we find the 32-bit precision to be insufficient (ie. with lat/long), we can always switch to float64

Tbh not sure how the conversion works, but it sounds simple enough on either end, so choose whatever is easier.
Again, we just want to have the best most up to date values whenever we can. However we can best get that, just let us know. Sounds like the bool would make it easy to know for sure? Not sure when gps would be off.

alright, i'll modify all the relevant fields to be float32,
will leave the lat/lon as degree-minutes,
and will add a bool for the gps state.
I'll make these minor changes and then merge it in by tonight.

From Simon: some fields have more precision.
gps, gyroscope, accelerometer should be switched to float32
gps lat/lon from float64 to float32?

I personally think let's be consistent and convert everything to float 32

Agreed, If anything, if we find the 32-bit precision to be insufficient (ie. with lat/long), we can always switch to float64

I think I know why we had it as a float64 originally. To parse the data from the canbus, a float64 prevents any possibility of overflow since we are adding 2x 32bit integers. But i will do the intermediate computations with a float64, and store the result in a float32 for consistency.

Awesome thanks Brielle!


Add uncaughtException handler

In the current version the whole nodered process dies if the request url cannot be reached and an EHOSTUNREACH occurs. The req.on('error',function(err) doesn't catch this error because of the asynchronous request handling.
process.setMaxListeners(0) is required to prevent the warning "possible EventEmitter memory leak detected. 11 uncaughtException listeners added" on startup.

Coverage decreased (-0.1%) to 88.186% when pulling 4ad08b615ab20624d5961dc1a278f9ad9273023e on nobodyMO:patch-1 into e6b5552cbac0b041f8a1785a585a620d9dcc0b20 on node-red:master.

This is not an acceptable fix for the issue. Adding a global handler like this will affect the whole runtime, not just this node.
There must be an appropriate place to add an error handler that is specific to this node. If it isn't exposed by the underlying module, that should be an issue raised against the module.
Please also note our contribution guidelines that require a signed CLA before we can merge any pull requests.

I'm aware that this is not a nice solution. From my point of view no exception should be triggered for such a comon situation. For this case there is the error handler in the request function.
A try statement or a local error handler in the node did not work, because the exception is triggered asynchronously.
The error handler for the event emitter is the only solution I've found that really prevents the crashes. If you have a better solution for that, it's also ok for me. But node-red schould not crash if the target system is unreachable.
The CLA:
The IBM corporation should have all approvals for use because I'm an IBM employee. Is a scan of the agreement in a signed mail via Lotus Notes sufficient?

Agreed that node-red shouldn't be crashing. My point is there will be a proper way to fix this and that's what we'll do.
As an IBMer you need to read the contribution guidelines as the process is different.

I tried to reduce the scope of the catch statement.
So far it seems that a catch statement limited to the node is also sufficient.

Coverage remained the same at 88.322% when pulling 7b5ff60da82eed5eccaef42224dfe125e1cb6641 on nobodyMO:patch-1 into e6b5552cbac0b041f8a1785a585a620d9dcc0b20 on node-red:master.

Do you have a test case for this bug? What version of Node and Node-RED are you using?
I've been trying to simulate this error and whilst I can't figure out a sample URL to trigger the EHOSTUNREACH, I'm seeing Node-RED handle other connection errors (ETIMEDOUT and ENOTFOUND) without an issue.

Distributor ID: Raspbian
Description:    Raspbian GNU/Linux 8.0 (jessie)
Release:        8.0
Codename:       jessie
node v4.5.0
npm 2.15.9
Both installed from the debian repository of nodesource.
node-red 0.14.6
Demo-Flow:
[     {         "id": "e25cd491.b2bed8",         "type": "inject",         "z": "96f1d94b.d7a958",         "name": "",         "topic": "",         "payload": "",         "payloadType": "str",         "repeat": "",         "crontab": "",         "once": false,         "x": 191,         "y": 553,         "wires": [             [                 "f0745e6a.1620a"             ]         ]     },     {         "id": "f0745e6a.1620a",         "type": "http request",         "z": "96f1d94b.d7a958",         "name": "",         "method": "GET",         "ret": "bin",         "url": "http://<IP_ADDRESS>/test.html",         "tls": "",         "x": 461,         "y": 548,         "wires": [             [                 "20873c27.04bc14"             ]         ]     },     {         "id": "20873c27.04bc14",         "type": "debug",         "z": "96f1d94b.d7a958",         "name": "",         "active": true,         "console": "false",         "complete": "false",         "x": 827,         "y": 543,         "wires": []     } ]
Just insert a non existing ip address inside your local network and try.
The result on my system:
[error] [http request:f0745e6a.1620a] Error: connect EHOSTUNREACH <IP_ADDRESS>:80
and node-red stops.
The reason for that is inside the red.js in line 284 ff:
process.on('uncaughtException',function(err) {     util.log('[red] Uncaught Exception:');     if (err.stack) {         util.log(err.stack);     } else {         util.log(err);     }     process.exit(1); });

I'm not sure if it is ever a good idea to have a global exception handler in the red.js, witch exits the whole node-red process on any uncatched exception. Every badly programmed node can therefore kill node-red.

Thanks for the updated information.
I've pulled down the Docker image for the OS you're using above, with the same versions of Node-RED and NPM installed. Once I've installed your flow, if I try to connect to an invalid IP I get the errors logged in the console but it doesn't killed the Node-RED instance.
Here's what I see:

It looks like you're seeing the HTTP request error log line which means that exception has been caught, because it's logged from here:
https://github.com/node-red/node-red/blob/master/nodes/core/io/21-httprequest.js#L185
I'm not seeing a second exception being thrown that causes the process to crash.
Can you try adding the following to the handler to print out the stack trace for the exception and paste the result in this issue?
process.on('uncaughtException', function(exception) {
    console.log('uncaughtException occurred: ' + exception.stack);
});

Hi, likewise have just tried on a Pi,  node.js 4.5.0  , npm 2.15.9
I get

Also not taking Node-RED down...
The exception handler needs to be somewhere - Once an async exception occurs the internal state may well then be unknown - or unstable - or may indeed be OK - but you cannot tell - So we believe it is safer to abort at that point - and then rely on systemd or pm2 or whatever the user chooses to restart automatically, as then it will be in a known state.
Yes a bad node can take it down... but in theory there is nothing to stop someone writing a node with process.exit() in... and exiting anyway if they so wished...

hi,
somehow for me it is not the same when someone forgets an exception handler or intentionally ends the process ...
First of all thanks for your support.
I've also done a little more research. I've probably accused the exception handler in the red.js  wrongly.
node-red runs with me not alone but as part of iobroker. The adapter starts the node-red Process with spawn and monitor the process. However, there is no registered error function for spawn . So every uncatched exception inside node-red terminates node-red...
I will now expand the iobroker adapter accordingly so that this will not happen again.


Huggingface Support

Dear xAI team,
Thank you for this gift to the community! Pure awesomeness.
Huggingface support and a Model Card would be appreciated. Huggingface is like a super cool and very popular model hub. This will help the user with a standard workflow.
Thanks,
Vulcan

Found the link here: https://huggingface.co/xai-org/grok-1


Center and contain sudoku grid

I set a minimum size for the app window, centered the sudoku grid in its column, and made the buttons etc. in the left column wrap around to keep them from being hidden behind the sudoku on small window sizes. As a result, the smallest window looks like this:

And when there's space around the sudoku on either the y or x axis, the sudoku sits in the middle:

I achieved this by calculating the point for the upper left corner of the sudoku based on the parent column's height and width.
I also modified the filtering input field to be much smaller, but long enough to show three digits.
If something should be still modified I can do it.

So the codecov checks failed because I modified main.rs, adding several lines that are not covered by the tests. I made changes to the eframe options and I don't think this code can be moved elsewhere. What can I do?

So the codecov checks failed because I modified main.rs, adding several lines that are not covered by the tests. I made changes to the eframe options and I don't think this code can be moved elsewhere. What can I do?

Adding main.rs behind --ignore flag like gui in ci.yml should work

So the codecov checks failed because I modified main.rs, adding several lines that are not covered by the tests. I made changes to the eframe options and I don't think this code can be moved elsewhere. What can I do?

Adding main.rs behind --ignore flag like gui in ci.yml should work

Can I do it directly to main or do I need to do it in ci-testing branch?


Remove the cfg file from download for better mod manger support

Please remove the cfg file from download to not reset configs every update if people use mod managers.
This goes for the original mod by Sligili as well, but he doesn't have his GitHub linked.

I just downloaded 1.1.3 and the config file is in the zip. However i will look into removing the config from the zip anyway as it was also an annoyance when i update the mod and the keybinds reset.

Fixed in v1.0.6


Index child route search params type issue

Describe the bug
Consider the following scenario:

I have a documentsRoute which does have a path, but is's just an Outlet.
There's a documentRoute, which is a child of documentsRoute, which is the index (path: "/") for the parent as well
The documentRoute has a search param year, validated by zod
When using useNavigate(documentRoute.id) in the documentRoute, and using the resulting navigate function without a to, you get a type error.

If you have a look at the minimum repro in the stackblitz, the issue should be fairly obvious.
Your Example Website or App
https://stackblitz.com/edit/github-fbut9a?file=src/Document.tsx
Steps to Reproduce the Bug or Issue
Have the stackblitz compile and have a look at the Document.tsx file. The navigate function shows a type error.
Expected behavior
The navigate function should not result in a type error.
Screenshots or Videos
No response
Platform

OS: Windows
Browser: Firefox
Version: 110

I'm aware that that would solve the issue, but imho, it's just a workaround. I get that /documents/ is not a valid path, but it's downright confusing that you have to use the fullPath for the from in useNavigate and the id for other hooks.
If this is the way that it should work, fine, but then at least let's make this very clear in the provided examples as well.

I’m working on a way to for id to work as from. It messes with relative paths right now, but it’s required for search params to work right. I’ll figure it out soon.

The issue seems to persist on beta 84: https://stackblitz.com/edit/github-fbut9a-k4gyfs?file=src%2FDocument.tsx%3AL8

I think I fixed this. Stay tuned

I don't think this is fixed. I have updated the stackblitz to the new router version and I still get a type error on the useNavigate function in Document.tsx: https://stackblitz.com/edit/github-fbut9a-xyzkf1?file=src%2Fmain.tsx,src%2FDocument.tsx

The stackblitz above is still using route.id. Try route.fullPath

Hello @tannerlinsley. Should we use the fullPath property instead of the id?

Yes


Minor updates to UI & adhere to the needsonboarding flag.

Replaced the ADD button with the system-add (+) icon.
wrap category titles in onboarding
During auto-login (LauncherViewController.swift), check the user's needsOnboarding flag to see if they should go thru onboarding.

@Revenaunt there are changes in some of these files that I didn't expect. I'm going to see if there's a setting or something that would cause this to happen.
Probably don't want to merge this just yet.

@Revenaunt ok, this is ready for review, now.

:+1:


why are 'prop' tables bad?

The check com.google.fonts/check/unwanted_tables suggests removing 'prop' tables. What's the reason for this? The code currently does not report a reason for that. We should at least figure it out and clarify the message.

You mean "prep"?

Ha! "prop" the AAT table => https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6prop.html

Yeah, prop is bad because it's AAT; AAT was the Apple pre-OpenType way of doing font cleverness. It's OS X specific (although Harfbuzz now has optional AAT support), and it's old, so new fonts should not be doing that.

There are a lot more AAT tables, why signal this one out?

I guess once one is flagged, the message has been successfully delivered to the user ;-)
Please open an issue with a longer list of tables to be rejected and we'll do so (only when reasonable, of course!).

But it is not a particularly important AAT table, I can drop it and keep, say, morx or kerx tables and it would still be an AAT font that only works where AAT is enabled (or works differently).
Case in point this font is broken when AAT is supported and it does not have a prop table (only morx and feat).

Code moved like a million times, but here is the commit that introduced this table and the issue that requested it. Nothing is mentioned about AAT and I doubt that ever was the reson, either the table was mistaken for another table or because FontTools didn’t support this table in 2016 someone checked a font with ttx and thought it is some junk table.

Thanks! That's right. Reading the issue, I see that @davelab6 thought it was a FontForge properties table (which is not the case). And even made it clear he was not sure by saying "(I think)". I blindly trusted him then, just like I am trusting you guys here this week.
We started rejecting that table for the wrong reason, but it turns out that we might really want to reject all AAT tables. Is that really the case?

Google Fonts profile might want to reject them, but it shouldn’t be a universal check since there might be valid uses for such a font (and thanks to HarfBuzz support, AAT font are now more widely supported than they ever have been).

I just don't want to trust blindly anymore. That's why I've been going after better rationales for the checks. And that's what made me touch this issue this week. I could not accept that a table being rejected without a clear justification.

It might be worth a WARNING though, even in universal profile, since people often generate morx table from FontForge by mistake and it is almost always a non-functioning table as well.

Google Fonts profile might want to reject them, but it shouldn’t be a universal check

Yeah, I was wondering about that. Is FontTools support meant to facilitate working mostly with legacy fonts that happen to use AAT ("old / OSX-only" stuff in @simoncozens' words)? Should we discourage AAT usage in new fonts unless the designer is really sure about what's being done? I would consider keeping a universal check for all AAT tables at WARN level and making it a FAIL on googlefonts profile check. Would that be OK?

FontTools got AAT support when Sacha was making test AAT fonts when Behdad was adding AAT support to HarfBuzz, and HarfBuzz got AAT support because Chrome wanted to stop using the CoreText bridge in HarfBuzz as it was slow and AAT fonts are still common in macOS.
Whether AAT fonts are still relevant or not, is not something I can answer. Some AAT tables might still be useful, and both HarfBuzz/CoreText seem to allow for a hybrid model where OpenType and AAT tables can be mixed. Someone might find this useful (for example, IIRC, kerning using kern table is faster then GPOS and AAT kern and kerx tables are more capable than legacy kern table, so someone might legitimately want to use them).

Thanks for all that background info, @khaledhosny!
@davelab6, what's your opinion on checking for the presence of AAT tables both on googlefonts profile (as a FAIL) as well as on universal (as a WARN)?
Also, who else should I be asking this question?

ping @davelab6


remove sponsors section from index

closes #627

LGTM. Have you checked that the front page still looks OK?

Of course. 😃

Double-checked. Thank you @rettinghaus


fix(editor): make the form update correctly

What is the PR about?
Fix the error with removing the item from array type property.
What is the code about?

Change the properties update logic
Before, it will call FieldModel.prototype.update when remove a property of array or object. But, it just update the value by keys instead of removing the key. So now I change to put the existed keys and values to new array or object, then the others will be removed.
Make the form can be controlled
When remove the items of array, the sort of items are changed but the form would not be updated.

have conflict


Fix typo

iPasOS to iPadOS
MacOS to macOS
FireFox to Firefox
(And thank you for the article :+1: )

감사합니다 😆


visual enhancements

Following visual enhancements have been done:

The border of the terminal & scrollbar made the same as that of the sidebar to maintain uniformity in the theme.
Background color added to activity and status bars to distinguish them from the rest of the editor.
Active tab border removed as it didn’t seem to match with the entire theme
Lightened color of inactive tabs and tabs background to distinguish them from the active tab
Removed unnecessary hover effect from the active and inactive tab

Hi, thanks for the pull request. Tabs look great and using same bg color for status bar makes sense. Thanks again!
I did remove status bar and activity bar borders, I found unnecessary. And I kept the activity bar background as it was. #9

@sssmi thanks for merging the PR. As you have reset the activity bar and removed the border from the status bar, I was wondering if we could keep both with the same background color as that of the rest of the editor and just have a border around them to distinguish them better?
This appeals better to me with a minimalist feel. Let me know your thoughts! :)


This reverts commit 8b63e4b89e9544018f9e61e996b23ec0f6673531.

https://issues.apache.org/jira/browse/CAMEL-10672

There is a reason for this revert. It breaks the build order. Please find another solution.

Ah wasn't sure thanks for clarifying :) Wonder how it was working before.
We could declare the dependency in camel-itest-osgi (and other modules that use it too).

Yeah the latter would work.

PR updated. Looks like only camel-itest-osgi needed it in Camel.
Thanks for taking time and looking into this :)

Please hold on merging this PR while I do more testing.

It turns out the above approach won't work because camel-karaf will look for the karaf feature version to use in it's own jar file only.
Instead I propose a solution similar to what is done to determine the karaf-version to use by way of specifying the version through the camelKarafFeatureVersion System property (and fail fast if none exist instead of fetching LATEST or hardcoding the version etc...).
Let me know what you think :)

Yeah that is a good idea @johnpoth

Thanks for the PR it has been merged. Do you mind closing this?

Thanks for reviewing this :)


error - TypeError: Cannot read property 'trim' of undefined

TypeError: Cannot read property 'trim' of undefined
at ServerClient.BaseClient (I:\react\briOS\node_modules\postmark\dist\client\BaseClient.js:22:28)
at new ServerClient (I:\react\briOS\node_modules\postmark\dist\client\ServerClient.js:28:23)
at eval (webpack-internal:///./src/lib/postmark/index.ts:13:16)
at Object../src/lib/postmark/index.ts (I:\react\briOS.next\server\pages\404.js:770:1)
at webpack_require (I:\react\briOS.next\server\webpack-runtime.js:33:42)
at eval (webpack-internal:///./src/graphql/resolvers/mutations/comment/index.tsx:11:71)
at Object../src/graphql/resolvers/mutations/comment/index.tsx (I:\react\briOS.next\server\pages\404.js:473:1)
at webpack_require (I:\react\briOS.next\server\webpack-runtime.js:33:42)
at eval (webpack-internal:///./src/graphql/resolvers/mutations/index.ts:8:94)
at Object../src/graphql/resolvers/mutations/index.ts (I:\react\briOS.next\server\pages\404.js:495:1)

Same here!

Yes

Gotcha, thanks for the heads up — this is likely because you don't have any environment variables defined. You'll need either a .env file, or if you use Vercel you can use vercel dev and host your secrets directly on your Vercel project (this is what I do).


Print labels in verbose checks

I have no idea why this worked the right way the first time around, but it does.
New behavior for .verbose following the discussion in #74.

@brentleyjones I believe this solves #74 quite nicely.

:boat:


revert: improve user experience on setting compression type

Reverts GreptimeTeam/greptimedb#2765

Standalone config still needs to fix
https://github.com/GreptimeTeam/greptimedb/blob/d0d0f091f01f8d7bdde7603c1e868a2a032b73a2/config/standalone.example.toml#L137

We can use deserialize_struct_case_insensitive in the serde_aux crate to support case-insensitive deserialization.
https://docs.rs/serde-aux/latest/serde_aux/container_attributes/fn.deserialize_struct_case_insensitive.html


KC Feeding Trough inventory size.

KC Tek Feeding Trough inventory size is 600 stacks, yet will only allow 300 stacks of items.

tested in live, working as expected.


Ops-Eng Python Refactor: organisation.py to move_users_to_teams.py

Create a united code base
As a developer
I want refactor the existing code into the script and utilise the GH Service layer code
so that this code follows the code standard for this repository
Code will exist either in script or in the service layer
Functional Requirements:

Move the organisation.py code into move_users_to_teams.py
Refactor the code across move_users_to_teams.py and github_service.py
Add / move the tests to reflect these changes.
Do not replace the current code until repository.py is also ported to move_users_to_teams.py

Acceptance Criteria:

Code is moved over from organisation.py to move_users_to_teams.py.
Test pass in move_users_to_teams.py and github_service.py
Current move_users_to_teams.py tests will pass.

Notes:

Refactored the organisation class from organisation.py.
The changes have been applied to new files so that the current implementation of move_users_to_teams script can still operate daily as-is.
Additionally the close_expired_move_users_to_team_issues script is affected by the refactor of organisation.py. The changes have been applied to new files as well.
I have added a Refactor status within the current scripts and tests to keep track of what functionality has been refactored/moved as part of the larger refactor process.
See commit.


Show submission status

From external user research.

Mike flagged that we should probably get all the new statuses from the get go (especially for supplementary reporting parts)

I believe this is capture in ticket #219 so will close this ticket.


Vault systemd service file on main branch fails on systemd 237

I am hoping that by this time you haven't stuck my picture on a dartboard.
I forked ansible-vault yesterday and have been using it instead of the galxy version. Unfortunately I found that the systemd vault service is invalid on my Ubuntu bionic system running systemd 237. There seem to be 3 problems:

The Capabilities statement on line 26 is invalid. It appears to have been removed as per:
https://github.com/systemd/systemd/blob/master/NEWS. I think it needs to be incorporated into the CapabilityBoundingSet setting on line 27

the mlock item on line 39 is causing Missing '=' messages. If I understand https://github.com/hashicorp/vault/issues/3605 then it can be removed since the presence of LimitMEMLOCK=infinity on line 40

the StartLimitIntervalSec at 37 generates an unknown lvalue error. The https://github.com/systemd/systemd/blob/master/NEWS indicates that this item has been removed from the Service section to the Unit section.

steve

Heyo, the systemd unit has been updated in v2.0.5!


Fix #1306: Evolve Location entity integration

Describe your changes :

I'm trying to have first a solid base of tests before implementing the Location entity integration. I'm using ingestion/tests/unit/mysql_test.json as an example for sample_data.py.

[x] source/sample_data.py works with stage/file.py
[ ] Ingestion of location with sample_data connector
[ ] Ingestion of location with the Glue connector

Type of change :

[x] Bug fix
[x] New feature

Checklist:

Reviewers

@amiorin Left few comments on Python code. But this PR is big and contains the other changes. Do you want to separate the changes into multiple  PRs. Easier to understand and review

I always use git --amend
I can summarize the changes here:

CatalogApplicationDev.java is an attempt of automating the creation of a fresh start of OM Java when I run metadata ingest -c pipelines/sample_data.json. There is room for improvement.
There is a bug fix in the Java code of Location.
openmetadata-dev.yaml because I prefer to have the logs in the console instead of logs/openmetadata.log
sample_data/glue to avoid to create confusion given that BigQuery is used manly with the internal storage that doesn't expose a location
sample_data/locations to be able to create locations without a Table or a Database
stage/file.py because I thought that this module should be compatible with source/sample_data.py
get_database_service_or_create_v2 because I wanted to use the new style of creating services
unit/stage_test.py an attempt to create a standard pytest for workflows. I'd like to add support for Docker containers.

I always use git --amend I can summarize the changes here:

CatalogApplicationDev.java is an attempt of automating the creation of a fresh start of OM Java when I run metadata ingest -c pipelines/sample_data.json. There is room for improvement.
There is a bug fix in the Java code of Location.
openmetadata-dev.yaml because I prefer to have the logs in the console instead of logs/openmetadata.log
sample_data/glue to avoid to create confusion given that BigQuery is used manly with the internal storage that doesn't expose a location
sample_data/locations to be able to create locations without a Table or a Database
stage/file.py because I thought that this module should be compatible with source/sample_data.py
get_database_service_or_create_v2 because I wanted to use the new style of creating services
unit/stage_test.py an attempt to create a standard pytest for workflows. I'd like to add support for Docker containers.

Changing Java API changes and ingestion at the different places will be confusing and makes the PR unnecessarily big. We can do the related changes in the same patch for ingestion and java
You added CatalogApplicaitonDev that is not related to this PR. However I am not in favor adding that code at all.
Otherwise rest of the changes looks good to me, left few comments

@harshach
I'll create a new PR for the Glue modifications. We can merge this one IMO.


Website is offline / gives 403 error

Visiting http://livereload.com I see this:
403 Forbidden

Code: AllAccessDisabled
Message: All access to this object has been disabled
RequestId: Q1TCVB4CMCWHZFMS
HostId: XhMry0Ek5aWfN1OiJZ7/KUIoLnuLgtSSslvnUMf4i7fSIHdmxR4Ed136tFaUHt1gfZibC8EK+Y8=

@andreyvit are you able to have a look at this?


how to set all corners to the webview

how to set all corners to the webview
i have used clipBehavior and borderRadius, but it doesn't work

No,
This package doesn't support this.

No, This package doesn't support this.

Could you explain the principle of how WebView2 on Windows is displayed within Flutter? Thank you.

This package just put a Microsoft WebView2 Win32 control on top of the flutter view, without OpenGL texture involved.
So I called this package a 'floating' webview.
It is drew by itself, so flutter sdk cannot do any post-processing such as clip/setAlpha/scale.


fix: set default timezone to 'America/New York' - Resolves #358

Please check the following

[ ] Do the tests still pass? (see Run the Tests)
[ ] Is the code formatted properly? (see Linting (Formatting))
For New Features:

[ ] Have tests been added to cover any new features or fixes?
[ ] Has the documentation been updated accordingly?

Please describe additional details for testing this change
Resolves #358 by setting default timezone to America/New York wherever dayjs is configured

Closing because this didn't work when experimentally deployed


DONOTMERGE: use batchcli instead of gearcmd

JIRA:
https://clever.atlassian.net/browse/INFRA-2217
Overview:
Testing:
Roll Out:

[ ] Remember to deploy both s3-to-redshift and s3-to-redshift-fast

closing in favor of #95