T::Boolean type does not correctly infer type in the given example

Input
→ View on sorbet.run
# typed: true
extend T::Sig

sig {returns(T::Boolean)}
def check_something?
  false # dummy, could return true or false
end

def foo
  a = T.let(false, T::Boolean)
  a = check_something?
  return if a

  a = true if check_something?

  return if a
end

def bar
  a = T.let(false, T::Boolean)
  a = check_something?
  return if a

  2.times do
    a = true if check_something?
  end

  return if a
end

Observed output
editor.rb:28: This code is unreachable https://srb.help/7006
    28 |  return if a
          ^^^^^^
    editor.rb:28: This condition was always falsy (FalseClass)
    28 |  return if a
                    ^
  Got FalseClass originating from:
    editor.rb:21:
    21 |  a = check_something?
              ^^^^^^^^^^^^^^^^
    editor.rb:22:
    22 |  return if a
                    ^
Errors: 1

Expected behavior

This can be reproduced in the second example with any block.

👋 I ran into something similar recently as well. It seems like the issue is that Sorbet can't detect whether or not a block has been invoked when it's passed to a method.
→ View on sorbet.run
# typed: true
extend T::Sig

works_as_expected = T.let(nil, T.nilable(String))
works_as_expected = "Hi"
works_as_expected.upcase

doesnt_work_as_expected = T.let(nil, T.nilable(String))
1.times do
  doesnt_work_as_expected = "Hi"
end
doesnt_work_as_expected.upcase

Observed output
editor.rb:12: Method upcase does not exist on NilClass component of T.nilable(String) https://srb.help/7003
    12 |doesnt_work_as_expected.upcase
                                ^^^^^^
  Got T.nilable(String) originating from:
    editor.rb:8:
     8 |doesnt_work_as_expected = T.let(nil, T.nilable(String))
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Autocorrect: Use -a to autocorrect
    editor.rb:12: Replace with T.must(doesnt_work_as_expected)
    12 |doesnt_work_as_expected.upcase
        ^^^^^^^^^^^^^^^^^^^^^^^
Errors: 1

My hope would be that Sorbet could detect that the block given to the times method will be invoked immediately.


Ability to use ElementSchema.findFirstValidPos while in invalid state

I got the following situation. I want to write a transformer to convert to a fully expanded fig in Texture JATS. Schema:
object-id, title, caption, graphic

However as an input I have the following state: el = <fig><graphic/></fig>, which is valid in JATS4R but not TextureJATS.
Now I want to add (expand) the missing pieces (object-id,title,caption), and would like to ask for the correct insert position using schema inspection. However schema.findFirstValidPos() always returns -1 if el is in an invalid state.
let schema = TextureJATS.getElementSchema('fig')
let pos = schema.findFirstValidPos(el, 'object-id')
...

Is it possible / achievable to make that work still, so we can insert elements until the schema is finally correct. I'd expect pos to be 0 in the example before.
@oliver---- thoughts?

Obsolete.


Carriage return breaks cell delimiters

After working on my notebook with SQL and markdowns, it will become one big single cell on the next open. Using MySQL. Here is file as a .txt: mysql.txt
What are the rules on how cells are determined? So I can manually avoid this problem in the future.

Ah, this looks like a bug that's triggered by the usage of carriage returns. Until I publish a release with this fixed, you'll need to change your editor configuration to use bare lines feeds (newlines) instead.

Alright. Thanks!

Alright. Thanks!


[demoing-storybook] install spam

When installing storybook, we get this spam:
warning "@open-wc/demoing-storybook ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@open-wc/demoing-storybook ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@open-wc/demoing-storybook ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency "regenerator-runtime@*".
warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency "react@*".
warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency "react-dom@*".
warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency "react@*".
warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency "react-dom@*".
warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^15.0.1 || ^16.0.0".
warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^15.0.1 || ^16.0.0".
warning "@open-wc/demoing-storybook > @storybook/addon-docs ><EMAIL_ADDRESS>has unmet peer dependency "webpack@>=4".
warning "@open-wc/demoing-storybook > @storybook/addon-docs > @storybook/api ><EMAIL_ADDRESS>has unmet peer dependency "react-dom@*".
warning "@open-wc/demoing-storybook > @storybook/addon-docs > @storybook/theming ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@open-wc/demoing-storybook > @storybook/addon-docs > @storybook/theming ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@open-wc/demoing-storybook > @storybook/addon-docs > @storybook/theming ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning "@open-wc/demoing-storybook > @storybook/addon-docs > @storybook/api > @storybook/router ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| 16.x || 16.4.0-alpha.0911da3".
warning "@open-wc/demoing-storybook > @storybook/addon-docs > @storybook/theming > @emotion/styled ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>
It would be nice of we can avoid this

welcome to the world of peer dependencies 😭
we probably will need to prebuild a version of @storybook/addon-docs or extract the mdx compiler into a separate package... then we would not have any direct dependency on storybook anymore and would also not get it's peerDependencies


Improve Windows build documentation

Update the Windows build instructions to use PHP's new Windows SDK .

@gkralik I can help with this, I’ll make a pull request on the docs. Should I make the instructions for the latest versions of php? 7.2 and greater?

Yes, 7.2 and up would be best. I tried it last week using the new SDK and it seems much easier to build now. If you can help, that would be much appreciated.

I've added support for specifiying a path to the NW RFC SDK using --with-sapnwrfc=PATH in 47a31e29626828f8f9ad76f253ff3521952895c7. This should help keeping the PHP build directory clean (no need to copy the SDK files into the PHP source tree).

@gkralik Should I make the instructions for the master branch?

Yes.

This should solve my 7.4.2 build issue also?

@gkralik I'll wait for the 2.0.0 release before doing this.


Fatal Error when selecting the "Browser data" option from a table

Actual Result

Fatal Error when selecting the "Browser data" option from a table

Expected Result

FlameRobin 0.9.6 should display the table data when selecting the "Browser data" option from a table

Steps to Reproduce the Issue

Open a Database and right click a table selecting the "Browser data" option.

When the user selects the Yes option in the dialog in the previous image the following error dialog is displayed:

Actually the problem is with the setup installer. I faced the same errors in FlameRobin 0.9.6.
You can see the discussion and manual solution at #293

Please, download and install the latest release file again
Should be fixed now

This issue is no longer reproducible on flamerobin-0.9.6-setup-x64.exe.
Thanks for the fix!
Best Regards,
Luciano


Failed to download v2

I subscribed to apple music, and re-exported cookies, but the download was difficult to succeed, and an error was thrown at any time. Is there anything else that needs special attention? Sometimes I can see the download reaches 100%, and then it prompts that the download failed.
PS D:\Portable Soft\Downloads> gamdl https://music.apple.com/cn/album/难念的经/1072048491?i=1072048505
Downloading "难念的经" (track 1/1 from URL 1/1)
[download] Got error: <urlopen error EOF occurred in violation of protocol (_ssl.c:992)>
[download] Got error: <urlopen error EOF occurred in violation of protocol (_ssl.c:992)>
[download] 86.7% of ~ 9.53MiB at 264.14KiB/s ETA 00:09 (frag 26/30)
Failed to download "难念的经" (track 1/1 from URL 1/1)
Done (1 error(s))
PS D:\Portable Soft\Downloads> gamdl https://music.apple.com/cn/album/难念的经/1072048491?i=1072048505
Downloading "难念的经" (track 1/1 from URL 1/1)
ERROR: [generic] None: Unable to download webpage: The read operation timed out (caused by TimeoutError('The read operation timed out')); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriateissue template. Confirm you are on the latest version using  yt-dlp -U
Failed to download "难念的经" (track 1/1 from URL 1/1)
Done (1 error(s))
PS D:\Portable Soft\Downloads> gamdl https://music.apple.com/cn/album/难念的经/1072048491?i=1072048505
Downloading "难念的经" (track 1/1 from URL 1/1)
Failed to download "难念的经" (track 1/1 from URL 1/1)
Done (1 error(s))
PS D:\Portable Soft\Downloads> gamdl https://music.apple.com/us/album/花心/151290612?uo=4
Traceback (most recent call last):
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\urllib3\connectionpool.py", line 700, in urlopen
self._prepare_proxy(conn)
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\urllib3\connectionpool.py", line 996, in prepare_proxy
conn.connect()
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\urllib3\connection.py", line 414, in connect
self.sock = ssl_wrap_socket(
^^^^^^^^^^^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\urllib3\util\ssl.py", line 449, in ssl_wrap_socket
ssl_sock = ssl_wrap_socket_impl(
^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\urllib3\util\ssl.py", line 493, in _ssl_wrap_socket_impl
return ssl_context.wrap_socket(sock, server_hostname=server_hostname)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\ssl.py", line 517, in wrap_socket
return self.sslsocket_class._create(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\ssl.py", line 1075, in _create
self.do_handshake()
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\ssl.py", line 1346, in do_handshake
self._sslobj.do_handshake()
ssl.SSLEOFError: EOF occurred in violation of protocol (_ssl.c:992)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\requests\adapters.py", line 489, in send
resp = conn.urlopen(
^^^^^^^^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\urllib3\connectionpool.py", line 787, in urlopen
retries = retries.increment(
^^^^^^^^^^^^^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\urllib3\util\retry.py", line 592, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='beta.music.apple.com', port=443): Max retries exceeded withurl: / (Caused by SSLError(SSLEOFError(8, 'EOF occurred in violation of protocol (_ssl.c:992)')))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 198, in run_module_as_main
File "", line 88, in run_code
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Scripts\gamdl.exe_main.py", line 7, in
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\gamdl_init.py", line 107, in main
dl = Gamdl(
^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\gamdl\gamdl.py", line 52, in init
web_page = self.session.get('https://beta.music.apple.com').text
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\requests\sessions.py", line 600, in get
return self.request("GET", url, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\requests\sessions.py", line 587, in request
resp = self.send(prep, **send_kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\requests\sessions.py", line 701, in send
r = adapter.send(request, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alway\AppData\Local\Programs\Python\Python311\Lib\site-packages\requests\adapters.py", line 563, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: HTTPSConnectionPool(host='beta.music.apple.com', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLEOFError(8, 'EOF occurred in violation of protocol (_ssl.c:992)')))
PS D:\Portable Soft\Downloads> gamdl https://music.apple.com/cn/album/难念的经/1072048491?i=1072048505
Downloading "难念的经" (track 1/1 from URL 1/1)
Failed to download "难念的经" (track 1/1 from URL 1/1)
Done (1 error(s))
PS D:\Portable Soft\Downloads> gamdl https://music.apple.com/cn/album/有没有一首歌会让你想起我/151212454?i=151212668
Downloading "有没有一首歌会让你想起我" (track 1/1 from URL 1/1)
Failed to download "有没有一首歌会让你想起我" (track 1/1 from URL 1/1)
Done (1 error(s))

Try adding aria2c to PATH.

The three exe files aria2c, MP4Box and mp4decrypt are in one folder and have been added to path.


Error in code snippet

On instantiating the MapFragment as in the below code, the parameter "Resource.Id.map_container" throws error "Resource Id doesn't exist".
var mapFrag = MapFragment.NewInstance();
activity.FragmentManager.BeginTransaction()
.Add(Resource.Id.map_container, mapFrag, "map_fragment")
.Commit();

Please try out the linked sample. It uses AddMapFragmentToLayout(Resource.Id.map_container) which is referenced here and is basically the same syntax as above (from this doc).


Update culture_map.txt for TFE unmapped cultures

Mostly post-Roman cultures, but also a dead culture map that don't seem to map to any culture in CK3, modded or vanilla

You sure you uploaded the correct file? I only see a single addition and one commented out change,

Ah, nvm, I missed the roman block in the diff spam. all good.


No support for chaging year.

It seems that there is no support for changing year in foundation date-picker.
This is basic functionality and it should be present. It is really irritating for user to go from current month to next 3 to 4 years.

Just click here
[image: Inline image 1]
Ing. Peter Beňo
Web development & computer vision
http://about.me/peterbeno
On Tue, Mar 17, 2015 at 10:06 AM, sagaraspl<EMAIL_ADDRESS>wrote:

It seems that there is no support for changing year in foundation
date-picker.
This is basic functionality and it should be present. It is really
irritating for user to go from current month to next 3 to 4 years.
—
Reply to this email directly or view it on GitHub
https://github.com/najlepsiwebdesigner/foundation-datepicker/issues/79.


Updated README.md

Summary

Hello ,
I have made some changes in the readme , have added some API data boxes which will help the visitors to get the data of this repo . I have added some API boxes of

visitor
PR's
open issues
Contributors
Last commit
Lisence etc.

Checklist

[x] The Pull Request has tests
[x] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
[x] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

[Implement ...]

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you, but we're going to leave the badges in the readme as-is for now.


bug: npx create-remix not working on Windows

What version of Remix are you using?
/
Steps to Reproduce
yarn create remix > YOUR_PATH > Just the basic > Cloudflare Pages > TypeScript > No
using npx still cause error
using other deploy target also cause error
Expected Behavior
Work
Actual Behavior
It returns an error:
🚨 The provided template must be a Remix project with a `package.json` file, but that file does not exist in D:\Project\test-remix\package.json

https://github.com/remix-run/remix/discussions/2709#discussioncomment-2539300
Seems like it only affects windows. @kentcdodds.

Tracked in #2691
For now you can use npx<EMAIL_ADDRESS>

@machour that looks like an unrelated issue. This issue is related to npx create-remix tar extraction skipping all files.
quote from the discussion
https://github.com/remix-run/remix/blob/7d799e2b6d71f5d7ff572addca623545f975af96/packages/remix-dev/cli/create.ts#L255-L271
At least on windows, header.name.startsWith(filePath) is always false causing all files to get ignored.

ReOpening so that @mcansh can take a look

I'm seeing the same issue on my windows machine, strangely enough, the pre-configured stack, ready for production works just fine

Tracked in #2691 For now you can use npx<EMAIL_ADDRESS>
I don't understand why it's not friendly to Window users, it seems that only Apple is you guys choice.

I don't understand why it's not friendly to Window users, it seems that only Apple is you guys choice.

This is a bug. It's not intentional. It will be fixed.

I don't understand why it's not friendly to Window users, it seems that only Apple is you guys choice.

I'd recommend just using WSL for the meantime.

Anyone on Windows able to give the latest pre-release a run and see if it fixes your issues?
npx<EMAIL_ADDRESS>

Anyone on Windows able to give the latest pre-release a run and see if it fixes your issues?
npx<EMAIL_ADDRESS>

I am able to get it working just fine, having created the remix app server deployment option.

I still have similar issue
C:\Code>npx<EMAIL_ADDRESS>Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) Y
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
? Where would you like to create your app? remix-jokes
? What type of app do you want to create? Just the basics
? Where do you want to deploy? Choose Remix if you're unsure; it's easy to change deployment targets. Remix App Server
? TypeScript or JavaScript? TypeScript
? Do you want me to run npm install? Yes

Creating your app…🚨 The provided template must be a Remix project with a package.json file, but that file does not exist in C:\Code\remix-jokes\package.json.
npm notice
npm notice New minor version of npm available! 8.6.0 -> 8.7.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.7.0
npm notice Run npm install -g<EMAIL_ADDRESS>to update!
npm notice

@leefisher Can you run it again with 1.4.1-pre.2 and this time pass the --debug flag? I want to see what kind of template it works out for you. If you select Remix App Server it should log this:
🔍 Using the remix template from the remix-run/remix repo

It didn't seem to log that, but I did get this output
C:\Code>npx<EMAIL_ADDRESS>--debug
? Where would you like to create your app? remix-jokes
? What type of app do you want to create? Just the basics
? Where do you want to deploy? Choose Remix if you're unsure; it's easy to change deployment targets. Remix App Server
? TypeScript or JavaScript? TypeScript
? Do you want me to run `npm install`? Yes
/ Creating your app…Error: 🚨 The provided template must be a Remix project with a `package.json` file, but that file does not exist in C:\Code\remix-jokes\package.json.
    at Object.createApp (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\create.js:160:11)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Object.create (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\commands.js:74:3)
    at async Object.run (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\run.js:377:9)

@leefisher Thanks a ton. Sorry to keep bugging you, but could you try once more with 1.4.1-pre.3? None of us are able to reproduce the issue so your help is very much appreciated!

I'm happy to help!
I don't really see any change here I'm afraid.
C:\Code>npx<EMAIL_ADDRESS>--debug
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
? Where would you like to create your app? remix-jokes
? What type of app do you want to create? Just the basics
? Where do you want to deploy? Choose Remix if you're unsure; it's easy to change deployment targets. Remix App Server
? TypeScript or JavaScript? TypeScript
? Do you want me to run `npm install`? Yes
- Creating your app…Error: 🚨 The provided template must be a Remix project with a `package.json` file, but that file does not exist in C:\Code\remix-jokes\package.json.
    at Object.createApp (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\create.js:160:11)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Object.create (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\commands.js:74:3)
    at async Object.run (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\run.js:377:9)

@leefisher Just to be sure, do you already have a folder named remix-jokes?

hm these questions seem out of order/date, the "TypeScript or JavaScript?" question should come after the app is created 🤨

@leefisher Just to be sure, do you already have a folder named remix-jokes?

i think we changed our order of things to use a remote template before a local one

@leefisher Yeah the ordering of questions is fishy to me too. Wondering if you have an npx caching issue here. Maybe try clearing it?
npx clear-npx-cache

If that doesn't work, you might need to nuke the _npx directory altogether (<ROOT>/npm-cache/_npx on Windows, I think)

BTW: It's working for me on Windows

Thanks for the feedback.
There is currently no remix-jokes folder.
I tried npx clearing cache but no real change.
I'll try deleting cache folder completely.
C:\Code>npx clear-npx-cache
Need to install the following packages:
  clear-npx-cache
Ok to proceed? (y) y

C:\Code>npx<EMAIL_ADDRESS>--debug
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
? Where would you like to create your app? remix-jokes
? What type of app do you want to create? Just the basics
? Where do you want to deploy? Choose Remix if you're unsure; it's easy to change deployment targets. Remix App Server
? TypeScript or JavaScript? TypeScript
? Do you want me to run `npm install`? Yes
- Creating your app…Error: 🚨 The provided template must be a Remix project with a `package.json` file, but that file does not exist in C:\Code\remix-jokes\package.json.
    at Object.createApp (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\create.js:160:11)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Object.create (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\commands.js:74:3)
    at async Object.run (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\run.js:377:9)

I clobbered the npm-cache directory.
It installed again but order of questions has not changed.
strange!
C:\Code>npx<EMAIL_ADDRESS>--debug
Need to install the following packages:
<EMAIL_ADDRESS>Ok to proceed? (y) y
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
? Where would you like to create your app? remix-141p3
? What type of app do you want to create? Just the basics
? Where do you want to deploy? Choose Remix if you're unsure; it's easy to change deployment targets. Remix App Server
? TypeScript or JavaScript? TypeScript
? Do you want me to run `npm install`? Yes
| Creating your app…Error: 🚨 The provided template must be a Remix project with a `package.json` file, but that file does not exist in C:\Code\remix-141p3\package.json.
    at Object.createApp (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\create.js:160:11)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async Object.create (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\commands.js:74:3)
    at async Object.run (C:\Users\USER\AppData\Roaming\npm\node_modules\create-remix\node_modules\@remix-run\dev\cli\run.js:377:9)
npm notice
npm notice New minor version of npm available! 8.6.0 -> 8.7.0
npm notice Changelog: https://github.com/npm/cli/releases/tag/v8.7.0
npm notice Run npm install -g<EMAIL_ADDRESS>to update!
npm notice

Thanks @leefisher, and very sorry for the frustration here! We may move forward with the release for others, but I'll keep this open until we can eliminate any issues on our end.

For everyone else who isn't having issues, I just released v1.4.1 stable so npx create-remix@latest should work as expected moving forward. We also now have tests in place for this so hopefully we won't have any regressions moving forward 😬

@chaance another error-case reported here for the pre-release: https://github.com/remix-run/remix/discussions/2709#discussioncomment-2588823

I have tried npx create-remix@latest and it works for me

@chaance another error-case reported here for the pre-release: #2709 (reply in thread)

This is because you're running an old version of Node that doesn't support String.prototype.replaceAll. We'll fix that in #2867 but I'd recommend using [at least] Node 14 if you can :)

I am getting the same error on Windows when using WSL with the latest release.

Windows 11
Ubuntu 18.04 LTS
Node 16.14.2
create-remix@latest and<EMAIL_ADDRESS>
? Where would you like to create your app? ./my-remix-app
? What type of app do you want to create? Just the basics
? Where do you want to deploy? Choose Remix if you're unsure; it's easy to change deployment targets. Remix App Server
? Do you want me to run `npm install`? No
⠼ Creating your app…🚨 There was a problem extracting the file from the provided template.

I have another (possibly related issue) on Ubuntu 18.04. I selected "Javascript" instead of TS, which may be what the problem is here? I see the file prisma/seed.js, but the scripts are trying to find prisma/seed.ts... can anyone help?
wyatt@wyatt-home:~/Projects$ npx create-remix --template remix-run/indie-stack love.me
Need to install the following packages:
  create-remix
Ok to proceed? (y) y
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
? Do you want me to run `npm install`? Yes
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated

> postinstall
> remix setup node

Missing the "remix" package. Please run `npm install remix` before `remix setup`.
Successfully setup Remix for node.

added 1329 packages, and audited 1330 packages in 40s

228 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
? TypeScript or JavaScript? JavaScript
💿 Running remix.init script

> setup
> prisma migrate dev && prisma db seed

Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
Datasource "db": SQLite database "data.db" at "file:./data.db?connection_limit=1"

SQLite database data.db created at file:./data.db?connection_limit=1

Applying migration `20220307190657_init`

The following migration(s) have been applied:

migrations/
  └─<PHONE_NUMBER>0657_init/
    └─ migration.sql

Your database is now in sync with your schema.

✔ Generated Prisma Client (3.11.1 | library) to ./node_modules/@prisma/client in 50ms

Running seed command `ts-node --require tsconfig-paths/register prisma/seed.ts` ...
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module './seed.ts'
Require stack:
- /home/wyatt/Projects/love.me/prisma/imaginaryUncacheableRequireResolveScript
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.resolve (node:internal/modules/cjs/helpers:108:19)
    at requireResolveNonCached (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:489:16)
    at getProjectSearchDir (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:459:40)
    at phase3 (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:263:27)
    at bootstrap (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:44:30)
    at main (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:32:12)
    at Object.<anonymous> (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:519:5)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1155:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/wyatt/Projects/love.me/prisma/imaginaryUncacheableRequireResolveScript'
  ]
}

An error occured while running the seed command:
Error: Command failed with exit code 1: ts-node --require tsconfig-paths/register prisma/seed.ts

Environment variables loaded from .env
Running seed command `ts-node --require tsconfig-paths/register prisma/seed.ts` ...
node:internal/modules/cjs/loader:936
  throw err;
  ^

Error: Cannot find module './seed.ts'
Require stack:
- /home/wyatt/Projects/love.me/prisma/imaginaryUncacheableRequireResolveScript
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.resolve (node:internal/modules/cjs/helpers:108:19)
    at requireResolveNonCached (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:489:16)
    at getProjectSearchDir (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:459:40)
    at phase3 (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:263:27)
    at bootstrap (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:44:30)
    at main (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:32:12)
    at Object.<anonymous> (/home/wyatt/Projects/love.me/node_modules/ts-node/dist/bin.js:519:5)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1155:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/home/wyatt/Projects/love.me/prisma/imaginaryUncacheableRequireResolveScript'
  ]
}

An error occured while running the seed command:
Error: Command failed with exit code 1: ts-node --require tsconfig-paths/register prisma/seed.ts
🚨 Oops, remix.init failed

Command failed: npm run setup

I have another (possibly related issue) on Ubuntu 18.04. I selected "Javascript" instead of TS, which may be what the problem is here? I see the file prisma/seed.js, but the scripts are trying to find prisma/seed.ts... can anyone help?

that's not so much related, but we need to tweak our remix.init on the stacks to update some scripts to point to prisma/seed.js (and other js files) instead of prisma/seed.ts

This version is now working for me on WSL in the Linux sub-system directory and on mounted device directories.

Remix previous version installation error
There was no error when installing the latest version of Remix, but if you proceed with npx<EMAIL_ADDRESS>as shown below, the installation fails with the error below.
"Creating your app…🚨 The provided template must be a Remix project with a package.json file, but that file does not exist in /home/goomin/desktop/test/app/package.json."
What should I do and what is the problem? 😖
I tried it on Mac and Ubuntu, but it still shows the same error.
npx<EMAIL_ADDRESS>? Where would you like to create your app? ./
? What type of app do you want to create? Just the basics
? Where do you want to deploy? Choose Remix App Server if you're unsure; it's
easy to change deployment targets. Vercel
? TypeScript or JavaScript? TypeScript
? Do you want me to run `npm install`? Yes
⠧ Creating your app…🚨 The provided template must be a Remix project with a `package.json` file, but that file does not exist in /home/goomin/바탕화면/test/package.json.

리믹스 이전 버전 설치 오류
최신 버전의 Remix 설치 시 오류가 발생하지 않았으나, 아래와 같이 npx<EMAIL_ADDRESS>진행하면 아래와 같은 오류가 발생하며 설치가 실패합니다.
"앱 만들기…🚨 제공된 템플릿은 package.json 파일이 있는 Remix 프로젝트여야 하지만 해당 파일이 /home/goomin/desktop/test/app/package.json에 존재하지 않습니다."
어떻게 해야 하며 무엇이 문제입니까? 😖
Mac과 Ubuntu에서 시도했지만 여전히 동일한 오류가 표시됩니다.
npx<EMAIL_ADDRESS>? Where would you like to create your app? ./
? What type of app do you want to create? Just the basics
? Where do you want to deploy? Choose Remix App Server if you're unsure; it's
easy to change deployment targets. Vercel
? TypeScript or JavaScript? TypeScript
? Do you want me to run `npm install`? Yes
⠧ Creating your app…🚨 The provided template must be a Remix project with a `package.json` file, but that file does not exist in /home/goomin/바탕화면/test/package.json.

If you select the vercel server, an error will appear.
Remix
When I selected App Server, the installation went well without any errors.
But how can I get rid of this error if I need to use vercel server?


DID Documents: Link to Self-Description

Feature #36
After #19, #186
Description
Each DID document should contain the link to the corresponding self-description.
A dataspace participant is identified via it's DID document, which serves as the root from which additional information about a participant, like the self-description, can be retrieved.
Acceptance Criteria

[ ]  DID documents (dataspace participants including dataspace authority) contain the link to the corresponding self-description.

Tasks

[ ] Add endpoint to serve self-description endpoint.
[ ] Test coverage.

Is this still needed?
In https://github.com/eclipse-dataspaceconnector/IdentityHub/pull/23 we introduced the Identity Hub endpoint serving the self-description.
This GET endpoint has URL: IDENTITY_HUB_BASE_URL + /self-description, while IDENTITY_HUB_BASE_URL is already provided as a serviceEndpoint in the DID document.
So as long as, each DID document contains the URL of the identity hub, then it also indirectly contains the URL of the self-description endpoint.

@bscholtes1A I think this is indeed required for correctness, as it is not mandatory that the self-description document is served by the Identity Hub.


Incorrect exercise: [deckId=eng_contextualized-brivla][exerciseId=3046]

Description
The obvious answer is correct, so this isn't a big problem since the exercise is still functional, but doesn't "do pu zdani ma" mean "who were you a house for?"
I think "Which house did you live in?" would be "ma pu zdani do", but I'm kind of new to this Lojban thing so I might be wrong.
Diagnostics information (do not remove)

Exercise identifier: [deckId=eng_contextualized-brivla][exerciseId=3046]
Exercise payload: {"sentences":[{"text":"Which house did you live in?","lojbanic":false},{"text":"do pu ____ ma","lojbanic":true}],"title":"Complete the translation","type":"typing"}
Attempted solution: {"text":"zdani"}
Attempted solution was classified as correct: yes
Validation payload: {"canonicalAnswer":"zdani","correct":true}

Thank you for reporting!
You are correct. Indeed, "which house did you live in" could be translated as "ma pu zdani do" (literally, "what was a house for you?"). I fixed the exercise by changing the Lojban sentence to "do pu xabju ma noi zdani", just to make it a little closer to the English prompt, but your proposal is correct as well.


Spark not updating

Happy first issue!
I was able to replace Arc icon, but when doing it for Spark (email app) it does not replace it even the message says it was updated fine.
EDIT:
Finder also cannot be updated, perhaps is a permissions issue?

Hehe, yep, forgot to mention that in the readme. Starting from Big Sure I believe, Apple updated their security policy for system apps, and they can't be messed with without disabling SIP(which I strongly suggest you to keep enabled). And "system" apps also include apps installed from App Store, I'm guessing that's where you installed it from, right?
I'm gonna research a little bit more, maybe someone smarter than me figured a workaround.. Also you will notice that after app updates itself, the icon is reset to default one, that's because when the app is updated, the whole bundle gets rewritten. I already have a POC to fix this ready locally, need to test a little more, since a lot of changes were made.
But coming back to your initial question: ATM it's not possible to change icons of system apps and the ones installed through App Store. I'll definitely update you if I find any info on how to fix this.
BTW to fix your particalar issue, you can just install it from official .dmg, 1 more benefit you get with that is that you'll get updates much earlier than App Store version.
Hope this helps!

Perfect, makes a lot of sense about the system app. And Yes I installed Spark from the App Store.
Thanks for the clarification!


Security Fixes - Docker Image

Context
Even if the RedHat base image is supposed to be free of problems, I noticed that there are some key issues related to its usage:

It's a fully-fledged operating system, so it has plenty of packages which we will never use
Since it's an operating system, the final size of the image is way bigger than what we could expect
Snyk throws different results on the scan than the RedHat website

Changes
Due to that, I decided to implement the following changes:
Use a multi-stage build approach
There is no need of having the full operating system on the final image, even if we need some packages for compiling our dependencies. Due to that, we compile the dependencies of our project in a first stage within the context of a venv and then we use those already compiled dependencies for running the application.
Use a custom non-root user
I know the RedHat image uses it's 1001 user by default, but I think it's better if we control in every moment which is the user that we're using and which permissions does it have over which directories.
Of course, using a root user isn't an option.
Run the WSGI Server within the context of a venv
We don't want to use all the system-dependencies but just the ones that we explicitly installed and provided during the build step.
Improves

Old Image
New Image

Size
1.06 GB
332 MB

Dependencies[^1]
429
116

Vulnerabilities[^1]
805
48

Also, the previous implemented cache capabilities will remain.
[^1]: docker scan [IMAGE]

@upkarlidder can you please review this one?


Fixed Versionable loading foreign objects broken.

Fix for issue #198

@martinj Do you want to port this patch (including unit tests) to Propel2 ?


DRS 2.0 disabled rules

Some of the rules in DRS 2.0 appear disabled by default. It would be helpful if this was noted in the documentation so as not to confuse disabled by default (MS) and disabled on purpose (user).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a0666d1b-c83b-3c13-07fc-7be0f528a368
Version Independent ID: 2ba31a6a-8f2a-9881-fce3-744e8428234d
Content: Azure Web Application Firewall on Azure Front Door DRS rule groups and rules
Content Source: articles/web-application-firewall/afds/waf-front-door-drs.md
Service: web-application-firewall
GitHub Login: @vhorne
Microsoft Alias: victorh

Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Thank you for your dedication to our documentation.
Unfortunately, we have been unable to review this issue in a timely manner. We sincerely apologize for the delayed response. We are closing this issue. If you feel that the problem persists, please respond to this issue with additional information.
Please continue to provide feedback about the documentation. We appreciate your contributions to our community.
#please-close


Backend for policy group removal

Relies on APIs that don't exist yet, so it won't actually work. That will be addressed soon, then I'll come back and add CLIs on top of this.
Also adds an undo stack so that we don't need to have a naggy confirmation dialog thing

:rocket:

One question, but otherwise :+1:


Update powershell formula to version 7.2.2

PowerShell 7.2.2 released on March 16: https://github.com/PowerShell/PowerShell/releases/tag/v7.2.2

LGTM :shipit:


0.83.0b0 Webhooks not working with Node Red.

Home Assistant release with the issue:

83.0.0b0
Last working Home Assistant release (if known):
0.82.1
Operating environment (Hass.io/Docker/Windows/etc.):
Ubuntu 18.04.1 LTS running Hassio
Component/platform:
webhooks
Description of problem:
Since upgrading to 0.83.0b0 Node Red is having problems sending webhooks to Hassio, every thing seems to be working fine in Node Red and it can receive events no problem. If I try to turn on a light it seems to work but if i try to turn off or toggle a light nothing happens.
I am  getting this error in the Home Assistant logs
Error executing service <ServiceCall light.toggle (c:038e378a731147fc9d4477d7dc77c63c): entity_id=['light.living_room']>
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/core.py", line 1177, in _event_to_service_call
    await service_handler.func(service_call)
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity_component.py", line 177, in handle_service
    self._platforms.values(), func, call
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/service.py", line 250, in entity_service_call
    permission=POLICY_CONTROL
homeassistant.exceptions.Unauthorized: Unauthorize

Additional information
I tried completely removing Node Red and reinstalling but it acts just the same.

OK just tried it using the IP address, not the Hassio URL and it worked. So it looks like its a Hassio issue.


NEW add MFA protection to the reset password flow

When a logged in user vists e.g. Security/changepassword (default
route) they are prompted for their existing password and a new one.
However when they have forgotten their password and used
Security/forgotpassword to send an email with a reset link to the
holder of the account linked with that email address (if it exists)
then they do not have to enter the existing password first.
If MFA is installed AND enabled, then the person who visits that link
should be prompted to pass through an MFA check before the password
reset is allowed.
Closes #27

Please see the provided link

😠 https://travis-ci.com/silverstripe/silverstripe-mfa/jobs/197337179#L709-L714
Is it just composer update silverstripe/admin then yarn build mfa module?

This is a problem we'll have to solve. Build your bundle with 1.3 of admin checked out for now.
See https://github.com/silverstripe/silverstripe-mfa/issues/116

Updated the travis build details instead. This will keep being a painful constraint in future developments otherwise.

This will keep being a painful constraint in future developments otherwise.

I think you can drop the "otherwise" 😅 . This will continue to be a problem. We need to fix it (#116)

There are some uncovered methods which seem pretty important to test: getSchema, startMFACheck, verifyMFACheck. Even if you wrote a happy path unit test for these it'd be better than nothing

Testing this, I've found two issues:

When you successfully verify MFA you get a console error (the app still works)

If you use a password that has been used already (depending on your password policy config) you get sent back to the start of the process, i.e. you have to verify with MFA again before it tells you the error and asks you to try again

Rebased, going to merge on green with @Cheddam's approval


fix: change LDAP attribute from cn to title for correct username mapping

Problem
When integrating applications with Casdoor's LDAP server, the user's name is not correctly retrieved because it's currently mapped to the title attribute instead of the standard cn attribute.
Solution
Change the attribute mapping from cn to title in the LDAP search response.
Changes
#3376
Testing

Started Casdoor with LDAP server enabled
Connected an LDAP client application
Verified that user names are now correctly retrieved using the cn attribute

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhangming seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@dacongda plz review


api: added create and update methods to registries

Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

This is not really api but since you've already created the services objects, it's much easier to move them to grape later.

Coverage failed :(

This is not really api but since you've already created the services objects, it's much easier to move them to grape later.

I have created the API endpoints 😕

For some reason I didn't see the update in the api/registries.rb file. Sorry! :sweat_smile:

@vitoravelino tests are passing


Pre-requirement in clean OS installations - README.md

Context
When running the generator in a new operating system environment it fails
looking for the 'git-init' generator.

Running  npm i -g yo generator-git-init has fixed the issue.

Hi, thanks for notice that @diegofreemind !
I have a solution and i should release a new version soon

So, there was a bug. I was not using the local version of generator-git-init, please, give a new try on https://github.com/e3Labs/generator-kube-microservice-node/releases/tag/v2.3.8

@all-contributors please add @diegofreemind for bug, ideas


Responsive

I think that there are still some responsive issues

Hi @adrien2p, the admin is definitely still not responsive. We are currently in the process of giving our admin a facelift, and making it responsive is a part of that process. We are aiming to have the design implemented in Q1 of 2022 :)

Yeah I know that 😀 it was just in case. I got that on the last PR url preview 😊

Ahh all right! It's still very early stages, and the login has not been touched at all so far. So the previews of the revamp branches might look a little stange in the coming weeks, as we are doing the revamp one (or a couple of) components at the time 😁


Unable to access local IPFS Gateway

When retrieving an asset from IPFS, the fetch method in the Asset class fails with the following error:

InvalidUrlClientError: IPFSSPEC_GATEWAYS=%22http://None:5001,https://ipfs.io,https://gateway.pinata.cloud,https://cloudflare-ipfs.com,https://dweb.link%22,,/ipfs/bafybeiap2dsmoozvrqz42hf2r2nvuikfshrprjqfpiwfx4qvzy2apxxgkq`

This can be resolved by updating our implementation to use IPIP-280 for http gateway access.

Resources:

https://github.com/fsspec/ipfsspec/issues/29
https://github.com/ipfs/specs/pull/280

Changes to be made:

Update ipfsspec dependency to the latest version

This will require an update to fsspec, and s3fs

Remove deprecated env variable IPFSSPEC_GATEWAYS and use IPFS_GATEWAY instead.

@matthewnanas, I was mistaken about needing the s3fs library as it was a requirement that needed to be updated for the Gedi Tutorials.

See #47 for additional details as it seems there is another factor to take into consideration.


Add a conditional attribute to force execution regardless of changes

Hi all!
I think it would be valuable to have an option to force the execution of the pipeline if a certain condition is met, possible use cases are the following:

Always run the entire pipeline when build is triggered on main branch.
Always trigger certain (or all) steps based on PR labels

That would be helpful for devs that want a full regression on their changes

I was thinking of a OR operator on this case. If it's matches the diff OR the additional conditions.

+1


Slow triangular mesh boundary calculation for large meshes

For large meshes (+100K vertices), the current calculation TriangularMeshBoundaryPredicates is slow.
E.g. a 400K vertice mesh can end up taking +30 seconds.
From debugging, it seems that the slow computation is from a continuous update of a CSCMatrix[Boolean]:
    triangles.foreach { triangle =>
      edgesOfATriangle.foreach { edge =>
        val v1 = triangle.pointIds(edge._1).id
        val v2 = triangle.pointIds(edge._2).id
        edgeOnBorderTmp(v1, v2) = !edgeOnBorderTmp(v1, v2)
        edgeOnBorderTmp(v2, v1) = !edgeOnBorderTmp(v2, v1)
      }
    }

This issue has been resolve (PR #414 ) and published as v0.92.1


[Question] possible to display date of last update

Is there an option to have newsboat display the date of last update for items and possible sort on this?  This would allow users to quickly identify stale entries in ~/.config/newsboat/urls

I don't think there is something like that built-in in Newsboat at the moment.
However, you can get this information from Newsboat's cache file, e.g. using a query like:
sqlite3 $HOME/.newsboat/cache.db "SELECT DATETIME(MAX(pubDate), 'unixepoch'), feedurl FROM rss_item GROUP BY feedurl ORDER BY pubDate;"

Thank you for the sqlite3 stanza, unique idea!


Why TryRead and WriteAsync methods now receive a byte[] instead of Message

Hi guys,
I just would like to get know why now the TryRead and WriteAsync methods into the Channel class receive a byte[] instead of a Message object which one had the next properties: Payload, Type and EndOfMessage. My question is how SignalR is managing now the message type and the end of the message.
Thanks a lot!

The Channel<byte[]> is used by the Sockets layer, which is a low-level networking abstraction designed to behave like a standard TCP socket. We used to have a low-level framing protocol we added on top of that raw socket which included this data (though we didn't use it on WebSockets, because it already has framing) but we decided to move it up to the SignalR layer to keep the Sockets layer cleaner.
Message Types, Framing, etc. are all handled in the IHubProtocol implementations now. EndPoints work with raw binary data (allowing the EndPoint to apply whatever protocol it wants). This means that EndPoints can easily be used to implement other protocols.


bios

It would be great if everyone wrote a short paragraph to sit beside their headshot on the People page. If this happens, we can change the current grid layout to a list/table with pictures on the left and text to the right.
Sidenote: this would also be a nice layout for the Projects page, with a graphic set next to a short project description. Anyone have good ideas for the HTML / Jekyll to implement that cleanly?

It should be doable in a similar way to headshot.html's templating.


CLI --ignored-files behavior differs from readme

Greetings!
I've only used this package from the CLI and I have discovered that --ignoredFiles only seems to take one blob. However, I can specify --ignoredFiles multiple times to specify multiple blobs.
I'm using PowerShell and have not tried bash.
I found that this does not work:
linguist-js.ps1 --offline --json --analyze . --quick --ignoredFiles "*.txt *.xml"

but this does work:
linguist-js.ps1 --offline --json --analyze . --quick --ignoredFiles "*.txt --ignoredFiles *.xml"

I'd like to update the readme to reflect this.

You're not meant to pass it as a single string, it's meant to be a plain list:

:x: linguist -a . --ignoredFiles "*.txt *.json"
✅ linguist -a . --ignoredFiles *.txt *.json

But yes what you have suggested does also work. I'll update the readme to include both ways.


Aborting after clicking "Delete fork" not possible

Please ensure:

[X] The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Description
It's not possible to stop the deletion process after clicking the "Delete Fork" button in the top right corner.
Screenshot

Console errors
No response
Example URL
https://github.com/edisim/outline/tree/master
Browser(s) used
Firefox Developer Edition 91.0b3 (64-Bit) on Windows 10

Oh god nightmare scenario. Let's

Fix the z-index issue
Add once:true global click listener to interrupt the process to ensure this can never happen


incorrect/missing error message

non-user-friendly error message: restore session
incorrect error message:  at transfer, when valid address is entered without amount, the error message is about entering a valid address.
incorrect error message: at transfer when token is selected, address entered, and amount not selected, it says to enter a valid ID.
error message duplicate: at minting, when selected mint multiple tokens, 2 different error messages appear.
incorrect message: at minting, when mint multiple tokens is activated (looks like when it's deactivated, it works fine), token amount is entered wrong but address is random generated, it displays a correct error message and another message saying token is successfully generated.
no error message for when token is not selected from the available tokens in transfer page after restoring a session.
"succesfully" spelling is incorrect.
better to write "hexadecimal", rather than "hexnumber"

new bug: at mint, uncaught error shown when string length exceeds 42. After bug appears, the minting function is disabled and error messages malfunction. (Minting failed: invalid address (argument="address", value="0x123123123222321232123212321232123212321232123212", code=INVALID_ARGUMENT, version=address/5.7.0))

solved all bugs and issues

solved all issued

solved all issues


⚠ Bofrost.es has degraded performance

In 878cc13, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1617 ms

Resolved: Bofrost.es performance has improved in df0eef2 after 6 minutes.


Bug: USBDevice::FromIdAsync

Which crate is this about?
windows
Crate version
0.48.0
Summary
Trying to get a USBDevice by ID results in Err(Error { code: HRESULT(0x00000000), message: "Der Vorgang wurde erfolgreich beendet." }) instead of Ok(USBDevice...)

Toolchain version/configuration
Default host: x86_64-pc-windows-msvc
rustup home:  C:\Users\V0640063.rustup
installed toolchains
stable-x86_64-pc-windows-msvc (default)
nightly-x86_64-pc-windows-msvc
active toolchain
stable-x86_64-pc-windows-msvc (default)
rustc 1.70.0 (90c541806 2023-05-31)
Reproducible example
#[tokio::main]
async fn main() {
    let devices=windows::Devices::Enumeration::DeviceInformation::FindAllAsync().unwrap().await.unwrap()
            .into_iter().filter_map(|di|di.Id().ok()).collect::<Vec<_>>();
    let aiousbdevices=devices.iter().filter_map(|deviceid|windows::Devices::Usb::UsbDevice::FromIdAsync(deviceid).ok()).collect::<Vec<_>>();
    let mut usbdevices=Vec::new();
    for iao in aiousbdevices{
        usbdevices.push(iao.await);
    }
    println!("{:?}",usbdevices);
}

Crate manifest
[dependencies]
tokio = {version = "1.28.2", features = ["rt","macros","rt-multi-thread"]}

[dependencies.windows]
version="0.48.0"
features = ["Devices",
            "Devices_Usb",
            "Foundation",
            "Foundation_Collections",
            "Devices_Enumeration"]

Expected behavior
Get a Ok(USBDevice) from a plugged in  USB Device when using the corresponding ID
Actual behavior
Got Err(Error { code: HRESULT(0x00000000), message: "Der Vorgang wurde erfolgreich beendet." })
Additional comments
No response

When S_OK (0x00000000) is returned as a result it means that the underlying API call succeeded but did not return a valid object so there was no value for the Ok(T) variant to contain.
I'm not familiar with this API so I suggest you check on https://stackoverflow.com/ if someone knows what might be the issue with the way you're calling it.

Ah Okay, thanks, would it be possible to make that clearer with the associated error Message? as it stands the Error message roughly translates to "operation successfull", which is really confusing

Not really. The error message is actually just the generic description for the S_OK error code returned by the API. It comes down to the API that decides to return nothing and call it success. 🫠
As always, you need to read the docs and understand how a particular API works and this is just one of those odd things that a few APIs have chosen to do. But I have been meaning to document it over here: https://kennykerr.ca/rust-getting-started


Update one_sp_queue_traffic_test.go

Pull request from cisco for dp-1.7

/gcbrun

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 57.081%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1181

Relevant Lines:
2069

💛  - Coveralls

b/271033767 has the internal test results.

/gcbrun


Could not find org.jetbrains.kotlin:kotlin-reflect:.

Ref: https://github.com/serpro69/kotlin-faker/issues/250#issuecomment-2440920179
Changes since last rc: https://github.com/serpro69/kotlin-faker/compare/v2.0.0-rc.6...8e77afdc7ece6b265099e61f1f530699fec5777e

@dees91 , I couldn't reproduce your issue on my end. I've just made a simple project in intellij w/o any dependencies but kotlin-faker, and that seems to work: https://github.com/serpro69/kotlin-faker-issue-253
Can you see if the same project works for you? And can you try to reproduce your issue there?
I wonder if the missing dependencies are due to some android specifics, where you need to explicitly add kotlin-reflect or smth like that?
Also, when I try to list dependencies from your repro project, I can see reflect dependency is reported as failed in a lot of places. So something is definitely going awry in the build process:
➜ ./gradlew :app:dependencies > deps.txt

mp.oKtCHvux8B on  main [?] is 📦 unspecified via 🅺 v2.0.20 via ☕ v17.0.12 …
➜ cat deps.txt | grep reflect
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED
|    +--- org.jetbrains.kotlin:kotlin-reflect FAILED
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED
     |    +--- org.jetbrains.kotlin:kotlin-reflect:1.6.10
     +--- org.jetbrains.kotlin:kotlin-reflect:1.6.10
          +--- org.jetbrains.kotlin:kotlin-reflect:1.6.10
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED
|    +--- org.jetbrains.kotlin:kotlin-reflect FAILED
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED
|    +--- org.jetbrains.kotlin:kotlin-reflect FAILED
|    +--- org.jetbrains.kotlin:kotlin-reflect FAILED

I get a similar error in the project https://github.com/serpro69/kotlin-faker-issue-253:
kotlin-faker-issue-253:main: Could not find org.jetbrains.kotlin:kotlin-reflect:.
Required by:
    project : > io.github.serpro69:kotlin-faker:2.1.0-SNAPSHOT:20241028.081202-24

Possible solution:
 - Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html

more info:
$ ./gradlew dependencies > deps.txt
$ cat deps.txt | grep reflect
     |    +--- org.jetbrains.kotlin:kotlin-reflect:1.6.10
     +--- org.jetbrains.kotlin:kotlin-reflect:1.6.10
          +--- org.jetbrains.kotlin:kotlin-reflect:1.6.10
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED
     +--- org.jetbrains.kotlin:kotlin-reflect FAILED

Thanks for the info @dees91 !
I've cleaned local caches for both maven and gradle, and I can still run the code locally.
However, the failed dependency I'm also getting now in the graph. So I'll try to find the root cause of that, and hopefully that will fix this issue.


Unable to use system ml 1.3 snapshot for coursera Advanced ML and signal processing course.

@romeokienzler  pip installing this package isn't leading to a system ml version upgrade in the watson studio.
https://github.com/IBM/coursera/blob/master/systemml-1.3.0-SNAPSHOT-python.tar.gz
Please refer to the following thread on coursera

thanks a lot! [x] fixed (in the template)


feature: send enabled projects on wire for global-setup

sends enabled projects across the wire to playwright test server
currently params isn't read by the listener, so this shouldn't cause any issues
below is reference code for listener, where params is unused -
https://github.com/microsoft/playwright/blob/ff5f1628dc8dbbb0217554adc3105bff4e0a504c/packages/playwright/src/runner/testServer.ts#L149

this change appears to affect a number of tests, but I want to see if this approach will be accepted before I go down the path of fixing them all


⚠ Bofrost.lu has degraded performance

In e4a4524, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1082 ms

Resolved: Bofrost.lu performance has improved in 707a5c2 after 13 minutes.


Do not bind test running to cmake test build rule

This PR also fixes the reason why cray(daint) was not uploading build results to the dashboard. By running the tests as part of the build stop, the Build.xml was never generated, since many of the tests were failing and the job timed out.
This PR has no effect on other code/tests/etc and shoul be merged ASAP to ensure that daint can be used for dashboard results.


Docs: Update the main README documentation for simpler getting started docs and move the separated packages docs into another md file

Looking to simplify the README docs for an easier "get started" experience read-through, now that we have different packages for web.
I think the separate runtime packages deserve their own MD file to explain further each of their purpose (and when we inevitably add more docs to it). We can link to it from the installation section. This new WEB_RUNTIMES.md is mainly just moved over from the main README, with a few tweaks to the wording here and there. I put @rive-app/webgl as the current recommendation for now.
Re: the main README:

Updated the wording on the intro sections and installation and getting started piece
Added a blurb at the end of the getting started section about forking a simple CodeSandbox example I spun up, so it's easy to plop in the rive file and go.
Moved the v6 and WASM sections to the bottom
Removed references to rive-js / rive.js
Any formatting nits were I think done by my Prettier vscode plugin?

LGTM! Only recommendation I have is to maybe add a visual to call the CodeSandBox demo out even more:

Good call! Added https://github.com/rive-app/rive-wasm/pull/167/commits/3a6e8b7679b588374aa6d3d76677e51f515cb07e to get a photo in.

Regarding formatter, I think we're open to suggestions. Are you some standard one that you recommend? I don't think any of us made any concerted effort to standardize on markdown formatting, so this is a good opportunity to do so!

I generally have used Prettier in the past for opinionated formatting, and think it works quite well, not just for markdown, but JS/TS, JSON, and others. I can set up a prettier config file in a follow-up change!


Bump<EMAIL_ADDRESS>

This ensures that preview tabs work for all files, not just files that open TextEditors.

Pushed 0.73.0 to master, closing this out, thanks for improving the preview tabs :+1:


fix(nodev6): socket.destroy() throws segmentation fault, end() is enough

Dunno why, but socket.destroy() throws segmentation fault here. .end() works well

cc @isaacs


HDDS-11186. First container log missing from bundle

What changes were proposed in this pull request?
Logs for one of the containers for each run is missing from acceptance test artifacts.
For example, docker-ozone-datanode-1.log and docker-ozonesecure-ha-datanode1-1.log here:
$ find 2024/07/12/32233/acceptance-s3a -name 'docker*' | sort
2024/07/12/32233/acceptance-s3a/ozone/s3a/docker-ozone-datanode-2.log
2024/07/12/32233/acceptance-s3a/ozone/s3a/docker-ozone-datanode-3.log
2024/07/12/32233/acceptance-s3a/ozone/s3a/docker-ozone-httpfs-1.log
2024/07/12/32233/acceptance-s3a/ozone/s3a/docker-ozone-om-1.log
2024/07/12/32233/acceptance-s3a/ozone/s3a/docker-ozone-recon-1.log
2024/07/12/32233/acceptance-s3a/ozone/s3a/docker-ozone-s3g-1.log
2024/07/12/32233/acceptance-s3a/ozone/s3a/docker-ozone-scm-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-datanode2-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-datanode3-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-httpfs-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-kdc-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-kms-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-om1-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-om2-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-om3-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-recon-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-s3g-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-scm1.org-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-scm2.org-1.log
2024/07/12/32233/acceptance-s3a/ozonesecure-ha/s3a/docker-ozonesecure-ha-scm3.org-1.log

This happens due to difference in output of Docker Compose v1 and v2:

v1 prints two lines of header,
v2 prints only one.

$ docker-compose ps
      Name                    Command               State                                            Ports
----------------------------------------------------------------------------------------------------------------------------------------------------
ozone-datanode-1   /usr/local/bin/dumb-init - ...   Up      <IP_ADDRESS>:33548->19864/tcp,:::33548->19864/tcp, <IP_ADDRESS>:33549->9882/tcp,:::33549->9882/tcp
ozone-datanode-2   /usr/local/bin/dumb-init - ...   Up      <IP_ADDRESS>:33550->19864/tcp,:::33550->19864/tcp, <IP_ADDRESS>:33551->9882/tcp,:::33551->9882/tcp
ozone-datanode-3   /usr/local/bin/dumb-init - ...   Up      <IP_ADDRESS>:33546->19864/tcp,:::33546->19864/tcp, <IP_ADDRESS>:33547->9882/tcp,:::33547->9882/tcp
ozone-httpfs-1     /usr/local/bin/dumb-init - ...   Up      <IP_ADDRESS>:14000->14000/tcp,:::14000->14000/tcp
ozone-om-1         /usr/local/bin/dumb-init - ...   Up      <IP_ADDRESS>:9862->9862/tcp,:::9862->9862/tcp, <IP_ADDRESS>:9874->9874/tcp,:::9874->9874/tcp
ozone-recon-1      /usr/local/bin/dumb-init - ...   Up      <IP_ADDRESS>:9888->9888/tcp,:::9888->9888/tcp
ozone-s3g-1        /usr/local/bin/dumb-init - ...   Up      <IP_ADDRESS>:9878->9878/tcp,:::9878->9878/tcp
ozone-scm-1        /usr/local/bin/dumb-init - ...   Up      <IP_ADDRESS>:9860->9860/tcp,:::9860->9860/tcp, <IP_ADDRESS>:9876->9876/tcp,:::9876->9876/tcp

$ docker compose ps
NAME                IMAGE                                  COMMAND                  SERVICE             CREATED             STATUS              PORTS
ozone-datanode-1    apache/ozone-runner:20240316-jdk17-1   "/usr/local/bin/dumb…"   datanode            25 seconds ago      Up 23 seconds       <IP_ADDRESS>:33549->9882/tcp, :::33549->9882/tcp, <IP_ADDRESS>:33548->19864/tcp, :::33548->19864/tcp
ozone-datanode-2    apache/ozone-runner:20240316-jdk17-1   "/usr/local/bin/dumb…"   datanode            25 seconds ago      Up 22 seconds       <IP_ADDRESS>:33551->9882/tcp, :::33551->9882/tcp, <IP_ADDRESS>:33550->19864/tcp, :::33550->19864/tcp
ozone-datanode-3    apache/ozone-runner:20240316-jdk17-1   "/usr/local/bin/dumb…"   datanode            25 seconds ago      Up 23 seconds       <IP_ADDRESS>:33547->9882/tcp, :::33547->9882/tcp, <IP_ADDRESS>:33546->19864/tcp, :::33546->19864/tcp
ozone-httpfs-1      apache/ozone-runner:20240316-jdk17-1   "/usr/local/bin/dumb…"   httpfs              25 seconds ago      Up 23 seconds       <IP_ADDRESS>:14000->14000/tcp, :::14000->14000/tcp
ozone-om-1          apache/ozone-runner:20240316-jdk17-1   "/usr/local/bin/dumb…"   om                  25 seconds ago      Up 23 seconds       <IP_ADDRESS>:9862->9862/tcp, :::9862->9862/tcp, <IP_ADDRESS>:9874->9874/tcp, :::9874->9874/tcp
ozone-recon-1       apache/ozone-runner:20240316-jdk17-1   "/usr/local/bin/dumb…"   recon               25 seconds ago      Up 23 seconds       <IP_ADDRESS>:9888->9888/tcp, :::9888->9888/tcp
ozone-s3g-1         apache/ozone-runner:20240316-jdk17-1   "/usr/local/bin/dumb…"   s3g                 25 seconds ago      Up 23 seconds       <IP_ADDRESS>:9878->9878/tcp, :::9878->9878/tcp
ozone-scm-1         apache/ozone-runner:20240316-jdk17-1   "/usr/local/bin/dumb…"   scm                 25 seconds ago      Up 23 seconds       <IP_ADDRESS>:9860->9860/tcp, :::9860->9860/tcp, <IP_ADDRESS>:9876->9876/tcp, :::9876->9876/tcp

and the code that collects logs only starts at the third line (tail -n +3):
https://github.com/apache/ozone/blob/63a232b798c2eba71f19bafc607c20c8144a41af/hadoop-ozone/dist/src/main/compose/testlib.sh#L305-L311
https://issues.apache.org/jira/browse/HDDS-11186
How was this patch tested?
Verified that datanode1 log is also saved (in addition to all other container logs):
renamed 'ozone-balancer/result/docker-ozone-balancer-datanode1-1.log' -> '/home/runner/work/ozone/ozone/hadoop-ozone/dist/target/ozone-1.5.0-SNAPSHOT/compose/result/ozone-balancer/docker-ozone-balancer-datanode1-1.log'

https://github.com/adoroszlai/ozone/actions/runs/9954339826/job/27500597426#step:5:124
whereas previously datanode2 was the first item, datanode1 was missing:
renamed 'ozone-balancer/result/docker-ozone-balancer-datanode2-1.log' -> '/home/runner/work/ozone/ozone/hadoop-ozone/dist/target/ozone-1.5.0-SNAPSHOT/compose/result/ozone-balancer/docker-ozone-balancer-datanode2-1.log'

https://github.com/apache/ozone/actions/runs/9936569749/job/27445931351#step:5:123

Thanks @sadanand48 for the review.


fix(NaN/Ifinity): Don't target/track NaN, Infinity, or -Infinity

Pull Request Test Coverage Report for Build 698

11 of 13 (84.62%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 89.162%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

core-api/src/main/java/com/optimizely/ab/internal/EventTagUtils.java
1
3
33.33%

Totals

Change from base Build 691:
-0.04%

Covered Lines:
2501

Relevant Lines:
2805

💛  - Coveralls

@msohailhussain do you know when you might be able to merge this? @mikeng13 it might be nice to get this into the first official 3.0 release.


not working in Meteor <IP_ADDRESS> while tap-i18n defined in package

i created a simple repro of the issue https://github.com/chongwang87/testTAP
the languages file packages/lib/i18n/en.i18n.json didn't work.
if move  packages/lib/i18n to i18n (root), then it'll works.
reported in meteor as well https://github.com/meteor/meteor/issues/6941

Same here man. i18n blows up on the server

Any progress on this?

Any progress on this?

same issue


[FEATURE]

I am running Flowise under Docker container on my Mac and noticed that there are many places in the user interface where there is no Save and Cancel buttons. i.e. once you make changes and click outside that popup window, your changes are saved by default.  For example when you click the 'Additional Parameters' or 'Format Prompt Values' option on agents. The 'system Prompt' option does have 'Save' and 'Cancel' buttons. We would like consistent interface like this with 'Save' and 'Cancel' options on all input boxes.

That's a good suggestion. Thanks for your advice.
If you have used Docker, have you used Servbay? Maybe it's more suitable for you.

We make this by default because having Save and Cancel on all input boxes can be alot and daunting for every changes you are making. It kinda depends on user preference. We think the work of having confirming every changes is not necessarily a better UX than automatically saving all the changes. Having said that, we might revisit in future to see if there is a better way to improve

Thanks @HenryHengZJ though saving by default is kind of risky as you can save unwanted things as user changes their mind unless the UI provide a way to rollback to previous settings. Considering some of the dialog boxes are heavy with content and user needs to scroll a fair bit, may be a better option is to provide a popup confirmation dialog when user clicks outside the settings windows.


suddenly a working gguf workflow gives this

newbyteorder was removed from the ndarray class in NumPy 2.0. Use arr.view(arr.dtype.newbyteorder(order)) instead.

Probably something has updated your numpy to 2.0, it generally still causes lots of issues, I don't know where that issue happens here as none of that error is in my code. Downgrading to numpy 1.26.4 should fix that for now.
pip install numpy==1.26.4
or for portable comfy, in python_embeded folder:
python.exe -m pip install numpy==1.26.4


New README

Main changes:

Cleaned up style inconsistencies
Removed screenshots. I think showing the commands is sufficient. Showing the output is not necessary as it should be fairly obvious what it will be.
Removed some redundant sections

This looks great! Thank you @indragiek.


Provide a standard, convenient way to apply settings conditional on the Scala version

People do this in a bunch of different and sometimes too creative ways, e.g.:

https://github.com/scala/scala-module-dependency-sample#sbt-sample
https://github.com/scalatest/scalatest/blob/6ca0fe0204d97f40ad0457dfd6ab2f3f434023b9/project/GenEvery.scala#L9
https://github.com/typelevel/scalacheck/blob/fea563b341ff7554d019ae0fff27b69b4cade259/build.sbt#L66-L82

This is problematic since it's easy to get wrong, and when adding Dotty support to a build it's a pain to even find all the places where people are attempting to parse the Scala version in their build. CrossVersion.partialVersion(scalaVersion.value) is the closest thing to a standard, but it's not something you can figure out on your own (like many things in sbt...), so the solution might be as simple as to define a parsedScalaBinaryVersion setting and then encourage people to use that.
A more ambitious proposal would be to make the scalaVersion act like an axis, something like:
ScalaVersion("2.12") / scalacOptions += "-foo"

I think that would make cross-compiling builds much easier to read in general.

A more ambitious proposal would be to make the scalaVersion act like an axis

https://github.com/sbt/sbt-projectmatrix kind of gives you that.


update(README.md): add missing incubating repos

What type of PR is this?
/kind documentation
/kind incubating
Any specific area of the project related to this PR?
/area proposals
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: jasondellaluce
To complete the pull request process, please assign nestorsalceda after the PR has been reviewed.
You can assign the PR to them by writing /assign @nestorsalceda in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 84edc9cc19646f71422c3d7caa4cdef70d9a91ab

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Flow_base change

Hi, haotian,  thanks for your work.  I have two questions:

if I just predict images rather than video, could I remove the "flow_base" setting in the Config, or how to change the "flow_base"?
I download mobilenet weights "yolact_edge_mobilenetv2_54_800000.pth "  from Yolact and Yolact_edge link, separately, but seem very similar. How to run the Yolact model in yolact_edge? what parts of the Config and commands line should be changed?

Any suggestions would be appreciated.

Hi, for your questions:

You can remove flow_base, but you should also check all of the conditional statements that is affected by cfg.flow and make sure they are handled correctly.
For the most up-to-date version of YolactEdge, you can use almost all of the Yolact models without doing any modifications, and YolactEdge code will convert it automatically.

Hi, for your questions:

You can remove flow_base, but you should also check all of the conditional statements that is affected by cfg.flow and make sure they are handled correctly.
For the most up-to-date version of YolactEdge, you can use almost all of the Yolact models without doing any modifications, and YolactEdge code will convert it automatically.

Thanks a lot, haotian

I am closing this issue for now due to inactivity. If there are any further questions that I could help with, please feel free to reopen, thanks.


Nathan - Hyphens in Volumes (Credit: Daniel Russell)

Cherry-picked from https://github.com/DanielRussell/sockguard/tree/allow-hyphen-in-volume - credit to @DanielRussell
Getting this into upstream to avoid issues with our fork long term, and since it can benefit others.
Allow volumes with hyphens in the name
Prior to this patch, sockguard would return something like:
GET /v1.30/volumes/ecs-jenkins-...-bccfa78debe6e3b4a901 not implemented yet

Will merge once tests pass.

No tests running according to GH? merging anyway


The SVG and DOM property configs have moved to react-dom

This will add support for react ^15.4.0, where the HTMLDOMPropertyConfig and SVGDOMPropertyConfig have been moved to react-dom.
You could probably bump a major version if you merge this, since it's a breaking change.

Nice catch!

@cskeppstedt We also need to add react-dom as a peer dependency now.

<3


Timeout occurs during build

It seems to me, that the backend is not fast enough to actually compile the code anymore.
It seems to be random, therefore maybe load dependent, but I sometimes get a timeout even with a simple fn main() {}.
Can you investigate that? I'm not sure how to reproduce it, because as said, it is somewhat random and does not depend on the code itself.

Yep. I think it's been this way for a few months now. I haven't had time to figure it out, or even to add some basic metrics to help in figuring it out. It may just be that Rust / Cargo / the various crates are slower.

It's a 2x Intel(R) Xeon(R) CPU E5-2686 v4 @ 2.30GHz and ~8GiB of RAM.

I've also been hitting this recently, but running with miri usually doesn't hit this. Is running w/ Miri less CPU intensive?

I'm getting timeouts repeatedly now. I can hardly run any code in the playground, even just basic hello worlds don't run anymore.

(responding to https://github.com/integer32llc/rust-playground/issues/762#issue-1090649922)

To fix this, the timeout duration could be increased from 10 seconds to a higher value.

I'm not well-versed in queuing theory, but wouldn't this make it worse or otherwise not help? If we assume a consistent rate of requests and we increase the timeout, then more compilations will be occurring concurrently, fighting each other for the same resources, slowing each other down for a longer period.
I also expect that at some inflection point, people will assume "oh, something broke" while waiting for a request and will resubmit the request, exacerbating the problem as now that one user has doubled their load. Even preventing a second submit in the UI is problematic as people can reload the page and retry, which is even a tiny bit more expensive.

Alternatively, cargo build and cargo run could have different timeouts, for example 15 seconds for compilation and 2 seconds for running.

This is perhaps something that we should have otherwise, but I also don't see how it would fix the problem. Compilation and running both contend for the same CPU time slice.

For a picture, here is "Timeouts vs Load average":

And for the last 7 days


Add a man page

This adds a man page in groff_man(7) format, based on the --help output and the README, and adds it to the source distribution.
Since man pages are platform-dependent, I made no attempt to install it, only to make it available for, e.g., Linux distribution packagers.

Brilliant! Thank you @musicinmybrain!


[WFLY-16866] / [WFLY-16858] Upgrade to Elytron EE 3.0.0.Beta3

https://issues.redhat.com/browse/WFLY-16866
https://issues.redhat.com/browse/WFLY-16858
This upgrade enables us to override some of the Soteria integration to add Elytron specific implementations.

@darranl See https://github.com/wildfly/wildfly/pull/15973

Thanks @darranl!


"Failed to load API definition."

When trying to access the swagger url, it greets me with the following error:

And then when going to the direct JSON endpoint it shows me this in the browser:
Object.entries requires that input parameter not be null or undefined

Though, this only happens when being on the experimental version from elysia. I need that version though, because of the other routing bug in latest 👀
I don't know if I should report it here or in the other repository.
Example Code:
import { Elysia } from "elysia";
import { swagger } from "@elysiajs/swagger";

export const app = new Elysia()
    .use(swagger({
        path: "/api/swagger",
        swagger: {
            info: {
                title: "e.bio API",
                version: "2.0.0-beta"
            }
        }
    }));

app.get("/api", () => {
    res.send("Hello World!");
});

Also, I don't know why, but the specified title and version aren't showing either within Swagger on elysia@latest since a few weeks.

Got it, Elysia experimental has an internal breaking change for handling schema which I haven't updated the swagger plugin to match the latest version yet.
Updating to @elysiajs/swagger: ^0.5.0-beta.0 should fix your problem.

Thank you, this resolved my issue :)
Though, the other one with the title and version isn't. Should I open another issue?

Oh, and also it seems like the scheme isn't loading?

Ohh sorry for the late response.
That's great, thank you! <3


Display recommendation if user authenticates with large amounts of STX

Recommendation would be displayed upon entry of Secret Key and detection of STX holdings over N threshold, advising that the user consider the desktop Stacks Wallet with a hardware device for increased security.
This might help educate users as to the best practice of using separate Secret Keys across separate wallet types.
cc @MarvinJanssen

Trezor does this when sending a large amount.


Removed the dependency on PhoneNumberKit package for easier contribution

Now, the contributor needs only dart to contribute to the package. Earlier they require python to contribute to the package because of dependency on this package PhoneNumberKit.
Also, I have updated it to the latest metadata.

awesome !

this is a great contribution, thanks


Add fleet grpc vendoring

These Go vendoring is related to the PR #1426. As discussed in #1426 (comment), it should be better to include the go packages in a different PR, instead of in the same PR #1426 .

ping @dongsupark

Great! In general it looks good. I just manually checked out both #1426 and #1657, and ran both unit tests and functional tests. It works without any error.
One problem is that glide.lock and glide.yaml in the both PRs make conflicts with each other. So I had to fix it manually. Before merging the 2 PRs, we need to sort out this part to get the glide changes included only one of the 2 PRs.
Apart from that, I think it's ready to be merged.
Thanks! :-)

@dongsupark Solved!. I added them to the original PR https://github.com/coreos/fleet/pull/1426

@hectorj2f LGTM.
I'll create another PR just for running functional tests on semaphoreci.
If that passes, I'd like to merge #1426, #1657, and #1656 tomorrow.

It turns out that travis doesn't like a test directory which is not buildable, while a unit test runs well when tested locally. Strange...
no buildable Go source files in /home/travis/gopath/src/github.com/coreos/fleet/vendor/google.golang.org/grpc/test"

I'll create a new PR for removing the vendor/google.golang.org/grpc/test, as well as adding missing license headers etc.


Implement user token persistency

Fixes #26.
It also regenerates the token on password change, which will force all your devices (except the one you changed the password on) to re-login.

TODO: I forgot to regenerate the token when changing the password using the CLI.

@xPaw, can we add a text when changing the password (e.g. under the form for the UI, confirmation message when calling the CLI command) saying "[For security purposes,] all your other sessions will be logged out" or something like that? I'll let you or any native speakers decide on the wording.

@astorije Added a message when changing the password on web. It doesn't make much sense to keep in CLI (maybe worth mentioning on website documentation though).

@astorije Added a message when changing the password on web.

I'd rather see something showing up in advance rather than "ah ah, you are now disconnected everywhere, sucks to be you", but we can always improve later.
👍 and merging, awesome work @xPaw!


Map OracleLinux stream names to RHEL.

OracleLinux renames a number of module streams from rhel8 to ol8 and from rhel
to ol.  This commit maps the names back to rhel8 and rhel so that migrate2rocky
doesn't blow up on them.

@pajamian Doesn't completely resolve. Error during distro-sync remains. Full (non-expiring) paste is here.

It resolves the issue of the stream names differing between OL and RL.  The issue in the paste is separate to that and is caused by the fact that BTRFS is installed for Oracle but not supported in RL (as it's not supported in RHEL 8).  At this stage I think we need to add a note to the known issues in the README file about Oracle Linux and BTRFS.
Possibly checking for any btrfs package in a repository that we're replacing and abort if we find one on the system?


Feature/dynamic routing

I refactored my code and included dynamic routes. To do this I had to:
· change the demo data
· make the library page the index.js of a new tutorials folder
· create service functions

Preview:
https://capstone-project-git-feature-dynamic-routing-kai-franke.vercel.app/tutorials
https://capstone-project-git-feature-dynamic-routing-kai-franke.vercel.app/tutorials/bathing-a-hamster
https://capstone-project-git-feature-dynamic-routing-kai-franke.vercel.app/tutorials/baking-sourdough-bread
https://capstone-project-git-feature-dynamic-routing-kai-franke.vercel.app/tutorials/building-a-helpful-robot


Support mwak having the thrown property

For melee weapons having the thrown property for the Prone condition, you should verify the distance between the source and target token before giving advantage (like in Paralyzed condition for crit), because if greater than 5', it should be disadvantage not advantage in that case:
https://github.com/thatlonelybugbear/automated-conditions-5e/blob/9bdb2ab4d6f764e0ffb36b70715b9d966d65d34f/scripts/hooks.mjs#L83

Will be included in next release. Thanks!

Closing with https://github.com/thatlonelybugbear/automated-conditions-5e/pull/8


shell: add flk up command

Automatically generate a configuration for your current system using nixos-generate-config, placed in the up directory. A file is added in hosts/up-$(hostname).nix importing said configuration.
Useful for getting up and running quickly, but if the user intends to use more than one host, they should probably move the generated bits directly into their host config manually.
@blaggacao, would appreciate your input.

Added a commit which namespaces flk up and stages the files, since the flake can't find them without it.

Added a commit which namespaces flk up and stages the files, since the flake can't find them without it.

Looks pretty useful already!

Looks pretty useful already!


Updated object-bin.hbs to meet Ember 2.0 syntax

I am attempting to update my application to Ember 2.0 and noticed that this addon was still using the old each helper syntax.
Updated the each helper syntax in the object-bin component to remove the deprecation warning.

Thanks for taking the time to do this. I just got back from holidays. I have a much upgraded and deprecation free branch ready to be merged, including this fix. You should see it released this week.

What's the news on this?
@dgavey I'm assuming you're talking about mharris717/ember-drag-drop/tree/develop?
It would be great to just get this pull request merged and deployed. It's unintrusive and will help people upgrade.

Yes I was referring to the develop branch. So sorry, been busy I will release it tonight, I promise.

Version v0.1.6 has been published, there should be no more deprecation warning.

:+1: awesome thanks.


Support IP range Blocking

I think this is a duplicate of https://github.com/wso2/product-apim/issues/7413
Shall we close this issue ?


[4.2] Fix benchmark suite on 32-bit platforms

Cherry-picked from #17268

Fix integer overflow issues with iteration count
Fix RandomIntegersLCG to use an integer type with a non-varying width

Reviewed by @natecook1000 and @gottesmm
rdar://problem/41177686

@swift-ci please smoke benchmark

@swift-ci please test

Build comment file:
Build failed before running benchmark.

Again, the benchmark succeeded but the build was marked red due to it not being able to compare results.


Remove back-compatibility with mongo in base_result_id in TaskQueue

Remove back-compatibility with mongo in base_result_id in TaskQueueORM

Closed by #542.


Fix cannot edit ongoing event

Fixes #2005.

Web frontend checklist

[x] Formatted my code with yarn format && yarn lint --fix
[x] There are no warnings from yarn lint
[x] There are no console warnings when running the app
[ ] Added any new components to storybook
[x] Added tests where relevant
[x] All tests pass
[x] Clicked around my changes running locally and it works
[x] Checked Desktop, Mobile and Tablet screen sizes

@lucaslcode want to take another look?


bigint: allow Sub to work in-place on the RHS

A new Fibonacci benchmark demonstrates the improvement by using both
addition and subtraction in each iteration of the loop, like #200.
Before:
test fib2_100          ... bench:       4,558 ns/iter (+/- 3,357)
test fib2_1000         ... bench:      62,575 ns/iter (+/- 5,200)
test fib2_10000        ... bench:   2,898,425 ns/iter (+/- 207,973)

After:
test fib2_100          ... bench:       1,973 ns/iter (+/- 102)
test fib2_1000         ... bench:      41,203 ns/iter (+/- 947)
test fib2_10000        ... bench:   2,544,272 ns/iter (+/- 45,183)

@homu r+

:pushpin: Commit 388a313 has been approved by hauleth

:zap: Test exempted - status


Apollo 2.3.0 does not trigger cache changes when cache is populated first time.

Summary
Apollo 2.3.0 does not trigger cache changes when cache is populated first time. On 2.2.0 version everything is fine.
Version
2.3.0.

Thanks for the bug report! Can you share more details about the scenario?

How is the cache populated? Through a query? Or using the imperative store APIs (store.write, ...) ?
How are changes detected? A query watcher? Something else?

The cache is populated from query and changes are detected with ApolloStore.RecordChangeSubscriber.

This might be linked to https://github.com/apollographql/apollo-android/issues/2537 although that other issues apparently also happens with 2.2.0

I have found the problem:
In RealApolloStore:
@Override public void publish(@NotNull final Set<String> changedKeys) {
    checkNotNull(changedKeys, "changedKeys == null");

    if (changedKeys.isEmpty()) {
      return;
    }

    Set<RecordChangeSubscriber> iterableSubscribers;
    synchronized (this) {
      iterableSubscribers = new LinkedHashSet<>(subscribers);
    }

    for (RecordChangeSubscriber subscriber : iterableSubscribers) {
      subscriber.onCacheRecordsChanged(changedKeys);
    }
  }

changedKeys is empty.

@piotr-pawlowski there is a potential fix in https://github.com/apollographql/apollo-android/pull/2538.
Can you check the snapshots to see if it applies here?

I tested version 2.3.1 and it doesnt work too :(

This is expected, the patch isn't released yet. The latest snapshot is 2.3.2-SNAPSHOT. To use it, you'll have to enable the snapshots repository: https://github.com/apollographql/apollo-android#releases
repositories {
  maven {
    url = uri("https://oss.sonatype.org/content/repositories/snapshots/")
  }
}

Ok, version 2.3.2-SNAPSHOT seems to work properly.
Are you gonna fix the issue #2532 too?

Ok, version 2.3.2-SNAPSHOT seems to work properly.

Nice! Glad to hear that

Are you gonna fix the issue #2532 too?

This bug looks different, let's move the discussion over there.


iOS・フォアグラウンドで受信した通知をタップしても何も反応しない不具合の対応

iOS・フォアグラウンドで受信した通知をタップしても何も反応しない不具合の対応
Description

https://github.com/dejiren/rd-react-dejirenclient/issues/1850
Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
https://user-images.githubusercontent.com/86858519/209603947-fbbb0730-105c-4f78-8c0a-5bb8af9da294.MP4
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@k-kiriyama
ご確認いただきありがとうございました。
こちらマージいたします。