fix/add release automation

fix(build): avoid dynamic metadata
fix: add bench backwards compat

The "meat":

fix: add release automation

ping

Go for it now. The future is promised to no one.   - Wayne Dyer

Kindly help move this PR forward. Many thanks from Yours Sincerely!

Fears are nothing more than a state of mind.   - Napoleon Hill

Kindly help move this PR forward. Many thanks from Yours Sincerely!

  - Richard Bach

Kindly help move this PR forward. Many thanks from Yours Sincerely!

  -

Kindly help move this PR forward. Many thanks from Yours Sincerely!

You may say Im a dreamer, but Im not the only one, I hope someday you will join us, and the world will live as one.  - John Lennon

Kindly help move this PR forward. Many thanks from Yours Sincerely!

I have just three things to teach: simplicity, patience, compassion. These three are your greatest treasures.   - Lao Tzu

Kindly help move this PR forward. Many thanks from Yours Sincerely!

The important thing is this: to be able at any moment to sacrifice what we are for what we could become.  - Charles Dubois

Kindly help move this PR forward. Many thanks from Yours Sincerely!

  - Henry Ford

Kindly help move this PR forward. Many thanks from Yours Sincerely!

Our distrust is very expensive.  - Ralph Emerson

Kindly help move this PR forward. Many thanks from Yours Sincerely!

An invincible determination can accomplish almost anything and in this lies the great distinction between great men and little men.  - Thomas Fuller

Kindly help move this PR forward. Many thanks from Yours Sincerely!


New tests do not appear in the test explorer

When I add tests in an test file (For example I add an it to an existing describe) the test explorer will not show them, until I issue the >Test Explorer: Reload tests command in the command palette.
Anyway very nice work so far! thank u

Yep, I should be able to set up a file system watcher for this


Switch to boost regex

this was slower than re2 but I did it so I wanted to submit it in case we need it in the future


Added support for VectorIntoWasmAbi and VectorFromWasmAbi

In this pull request (see also: this related issue), the capability to return a  Vec<SomeType> was introduced to wasm-bindgen, where SomeType has the #[wasm_bindgen] attribute.
This PR further extends this capability to support returning Vec<SomeType> where SomeType derives Tsify. This is done by implementing VectorIntoWasmAbi and VectorFromWasmAbi introduced in the linked PR.
Two new attributes were added to control whether the above traits should be implemented.
Example:

#[derive(Serialize, Deserialize, Tsify)]
#[tsify(into_wasm_abi, from_wasm_abi)]
#[serde(tag = "kind", content = "value")]
pub enum Pet {
    Cat(String),
    Dog(String),
}

#[wasm_bindgen]
pub fn return_pets() -> Vec<Pet> {
    vec![Pet::Cat("Pumpkin"), Pet::Dog("Cookie")]
}

#[wasm_bindgen]
pub fn read_pets(pets: Vec<Pet>) {
    // ...
}

@siefkenj  Sorry for the noise. I had an old clippy installed that did not detect the dead code. This also probably explains why the CI did not nag when this code was added first. (This is unrelated to the PR.)

Thank you for the contribution! I will review it as soon as I can :-)

Is there a reason to put these behind a flag? Would it cause problems if into_wasm_abi implied vector_into_wasm_abi? (I would think that would be the default expected behavior)
Could you please add some tests to this PR?

Thanks for your effort!

Thank you for merging my pull request!
Could you please also publish a new release that includes these changes?

Done :-)

Thank you so much !
This is really great stuff ! I was just missing this XD


Stack Using Array

Implementation of Stack using Array

Please star this repository to show your support, in the meantime I am reviewing your code.


Usage in Web Workers (again)

I saw a previous query about using wasm-vips in a web worker - but the op closed it due to realising that the lib opens its own web worker. #7
Would it be possible to use this lib inside a custom webworker? if so - any guidance would be greatly appreciated.

Hi @bentron2000,
I think it should work without any issues, as long as you override Emscripten's locateFile hook and mainScriptUrlOrBlob setting. For example, with this:
importScripts('./vips.js');

Vips({
  locateFile: (fileName, scriptDirectory) => scriptDirectory + fileName,
  mainScriptUrlOrBlob: './vips.js',
}).then(vips => {
  const im = vips.Image.black(100, 100);
  console.log(JSON.stringify({
    width: im.width,
    height: im.height,
    space: im.interpretation,
    channels: im.bands,
    depth: im.format
  }));
  const outBuffer = im.writeToBuffer('.png');
  console.log(outBuffer);
  im.delete();
  postMessage('Done!');
});

const worker = new Worker('worker.js');
worker.onmessage = e => console.log(e.data);

I see:

Amazing!
That was exactly what I was looking for. Thank you.
I've put in a PR with that parameter in the typescript defs to make it easier to find for others. #16
Really appreciate your efforts on this project - just great :)
B

FWIW, wasm-vips' ES6 modules doesn't require overriding Emscripten's locateFile hook and mainScriptUrlOrBlob setting. For example:
es6-worker.js:
import Vips from './vips-es6.js';

Vips({
  // Optimize startup time by disabling the dynamic modules
  dynamicLibraries: []
}).then(vips => {
  const im = vips.Image.black(100, 100);
  console.log(JSON.stringify({
	width: im.width,
	height: im.height,
	space: im.interpretation,
	channels: im.bands,
	depth: im.format
  }));
  const outBuffer = im.writeToBuffer('.png');
  console.log(outBuffer);
  im.delete();
  postMessage('Done!');
});

index.html:
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>wasm-vips in a ES6 web worker</title>
  </head>
  <body>
    <script>
      const worker = new Worker('es6-worker.js', { type: 'module' });
      worker.onmessage = e => console.log(e.data);
    </script>
  </body>
</html>

$ docker run -p 8080:80 --rm -v $(pwd):/src emscripten/emsdk:3.1.49 emrun --port 80 --no_browser /src
# Visit http://localhost:8080/index.html

(this example assumes vips-es6.js, vips.wasm and vips-es6.worker.js are served from the same directory where es6-worker.js and index.html reside)


Unique constraint not working in SQlite3

Environment
Knex version: 0.19.5
Database + version: sqlite3 4.1.0
OS: macOS mojave 10.14.5
Bug

Explain what kind of behaviour you are getting and how you think it should do

I would like to force a field to be unique. But when I run the migration, the generated DDL code in SQLiteStudio doesn't show a Unique constraint.

Error message

Here's the generated DDL code. This is consistent across multiple ways to write the same Knex code (rearranging notNullable() and unique(), putting user.unique('email') on a different line, etc)
Generated DDL code
CREATE TABLE users (
    id       INTEGER       NOT NULL
                           PRIMARY KEY AUTOINCREMENT,
    email    VARCHAR (128) NOT NULL,
    password VARCHAR (256) NOT NULL
);

Reduced test code, for example in https://npm.runkit.com/knex or if it needs real
database connection to MySQL or PostgreSQL, then single file example which initializes
needed data and demonstrates the problem.

NPM Runkit is not working for me, apologies. It's giving an error on the first line even if I don't change any code - not accessing sqlite3_bindings.node
Here's my copied code, hopefully this is enough to reproduce
Knex file:

development: {
  client: 'sqlite3',
  useNullAsDefault: true,
  connection: {
    filename: './data/KappaSchool.db3',
  },
  migrations: {
    directory: './data/migrations'
  },
  seeds: {
    directory: './data/seeds'
  },
  pool: {
    afterCreate: (conn, done) => {
      conn.run('PRAGMA foreign_keys = ON', done);
    },
  },
},

Knex migration:
exports.up = function (knex) {
    return knex.schema
        .createTable('users', users => {
            users.increments();
            users.string('email', 128).notNullable().unique();
            users.string('password', 256).notNullable();
        })
}

Closing issue because my code already forces the Unique Constraint.
Seems like SQL actually performs two commands - first to create the table, then another command to create the unique index. I was seeing the first but not the second.
Tested and confirmed that this existing code forces unique constraints - check out this helpful SO answer for more details
https://stackoverflow.com/questions/58769668/why-is-this-knex-migration-not-forcing-a-column-to-be-unique/58791953#58791953


Migrate codebase to use banderwagon

Blockers

Currently, we are pointing to a branch named "banderwagon_migration" in ipa-multipoint. Once that is merged, we can point this to master.

Since the test vectors have not been updated, this will fail tests.


Missing error handling in README

is it possible/I would like to open an PR to add error handling section in the README file?

@fkanout of course.  Open AYC and we'll review.  Thanks.


Set up github CI workflows

What it says on the tin.
Setting up standard CI workflows for building, testing, and deploying.

There's a mostly default CodeQL workflow in already, which I set up while setting up the project.
It most likely will continue to fail until I'm closer to finishing #2

The CodeQL workflow got nuked by a change I made earlier.
It has been restored and appears to be doing its thing, at the moment...

Well, I suppose I can at least set most of this up before #3 can move forward - just not the deploy to nuget obviously.
I'll set up build and test workflows since those aren't really dependent on it.

This actually prompted a review and revamp of our internal workflows.
What I'm going to do is take those and just cherry-pick the parts of that I feel are at least nice to have over here, because most of those are significant overkill for this repo.


Secure connections to a pull server using client authentication

This may work because the download manager logs the certificate being used

Published by @bgelens


fix set thread name fail with string more than 16 byte.

according to man pthread_setname_np, thread name should be  restricted to 16 characters, including the terminating null byte ('\0').
 By  default,  all the threads created using pthread_create() inherit the program name.  The pthread_setname_np() function can be used to set a unique name for a thread, which can be useful for debugging multithreaded applica‐
       tions.  The thread name is a meaningful C language string, whose length is restricted to 16 characters, including the terminating null byte ('\0').  The thread argument specifies the thread whose name is to be  changed;  name
       specifies the new name.

opened new PR to unstable branch https://github.com/KvrocksLabs/kvrocks/pull/496, closing this one.


Lapacke problem

Hi,
I have just installed OpenBlas and I can't find examples of code to test if it works.
I found 2 pieces of code: one that uses "cblas.h" and another one to invert a matrix that uses "Lapacke.h". Unfortunately, the one using Lapacke doesn't work, it returns thousands of errors. It seems as though it can't find lapacke functions like "lapack_make_complex_double".
Here is the code I used :
`
#include <stdio.h>
#include "cblas.h"
#include "lapacke.h"
// inplace inverse n x n matrix A.
// matrix A is Column Major (i.e. firts line, second line ... not C[][] order)
// returns:
//   ret = 0 on success
//   ret < 0 illegal argument value
//   ret > 0 singular matrix
lapack_int matInv(double *A, unsigned n)
{
int ipiv[n+1];
lapack_int ret;
ret =  LAPACKE_dgetrf(LAPACK_COL_MAJOR,
                      n,
                      n,
                      A,
                      n,
                      ipiv);

if (ret !=0)
    return ret;

ret = LAPACKE_dgetri(LAPACK_COL_MAJOR,
                   n,
                   A,
                   n,
                   ipiv);
return ret;

}
int main()
{
double A[] = {
0.378589,   0.971711,   0.016087,   0.037668,   0.312398,
0.756377,   0.345708,   0.922947,   0.846671,   0.856103,
0.732510,   0.108942,   0.476969,   0.398254,   0.507045,
0.162608,   0.227770,   0.533074,   0.807075,   0.180335,
0.517006,   0.315992,   0.914848,   0.460825,   0.731980
};
for (int i=0; i<25; i++) {
    if ((i%5) == 0) putchar('\n');
    printf("%+12.8f ",A[i]);
}
putchar('\n');

matInv(A,5);

for (int i=0; i<25; i++) {
    if ((i%5) == 0) putchar('\n');
    printf("%+12.8f ",A[i]);
}
putchar('\n');

}
`
Is it a problem with the way I built the library or I'm not using it correctly ?
Thank you in advance.
Ps: Im using it on Visual Studio 2019.

Do you have a Fortran compiler installed ? While LAPACKE itself is C, it only provides the bindings for calling the LAPACK functions which require a Fortran compiler to get built. If no Fortran compiler is available, your library will only contain the BLAS (and CBLAS) functions.


"Xamarin Forms" Checkbox gets the focus twice while Tabbing from "Ios/Android" to Create Workbook button.

Pre-Requisite:
Follow the instructions for installing the app from
https://docs.microsoft.com/en-us/xamarin/tools/workbooks/install?tabs=windows
Steps to Reproduce

Launch Xamarin Workbooks application.
Select the working platform to "Ios/Android".
Navigate to "Xamarin Forms" checkbox using Tab and then to "Create workbook" button from "Ios/Android"

Expected Behavior
"Xamarin Forms" checkbox should get focus only once.
Actual Behavior
"Xamarin Forms" Checkbox gets the focus twice while Tabbing from "Ios/Android" to Create Workbook button.
Note:
On the first time it sets focus on "Xamarin Forms" , if user tries to check the checkbox , it will not be performed. Only on second time focus user can check the checkbox.
User Impact
People with visual impairments can become disoriented when keyboard navigation takes focus somewhere unexpected or when they cannot easily find the content surrounding an interactive element.
Environment
Windows : Version 1803 (OS Build : 17134.48)
Xamarin Version : 1.4(master/b3f92f9)
Screenshots:

Log File

Please add the following labels to the bug:
A11yMAS
Accessibility
Xamarin-Workbooks-Windows
Wipro
MAS2.4.3

Exemption Approved - 1813


don't wrap packets in constructors for Result when encoding to JSON?

It seems that all of the packets encoded to json are wrapped in "Ok". I would expect the file to only contain values that were once wrapped in the 'Ok' constructor, but then unwrapped when encoded.

That was something I was thinking about. What should the JSON file contain if parsing lead to some error? Should I ignore it? I was not sure, so I left it as a result. I know it's a terrible design choice, but was not able to come up with anything else. Please let me know if you have anything in mind, I'd be glad to incorporate that ! :D

i was thinking that it should be left out. perhaps you could also log to the user that there were some packets you were unable to encode? i think if you give the user just a u32 representing the number of packets you were unable to decode, that would be sufficient.
p.s. thanks for the awesome project! much more digestible code than wireshark

Take a look now, I have merged the changes. the errors are logged onto the console. Thanks for the suggestion :D

p.s. thanks for the awesome project! much more digestible code than wireshark
Thanks xD


cardboards information

Hi @wilkinson,
when I utilize the API to get any informations about distributed processes, I have 2 options:
/v1/cardboard?key=982770f29

and
/v1/cardboard?status=waiting

But, can I know how much processes are waiting in current time (for all cardboards)?

No, it cannot be known. As you have noticed, you may only access an avar by a known box and a known key, or else by a known box and a known status. Both require a user to specify a known box; there is no way to query for all possible box values. This design provides a basic security model in which users may collaborate privately by sharing a box which is almost certain to be unused and unknown by anyone else -- especially if it is a UUID. The privacy of the box is therefore the responsibility of the users.
Thank you for asking. I will try to make this more clear in the manual :-)

no no @wilkinson, it's clear in the manual.
I'm asking for this because we like to extract some statistics about current traffic (in real-time) in the QMachine Network (for a paper), but it's unnecessary.
Thank you for help


Scatter Plots Support from Matplotlib. Closes #1394

Depends on #1544.

I was testing this with a simple scatterplot but was getting an empty figure. (I merged #1544 into the branch beforehand.)
import matplotlib.pyplot as plt

xs = list(range(0, 100))
y = [ 2*x for x in xs ]
plt.scatter(xs, y)
plt.show()

Any thoughts about the issue?

This branch is not ready for review yet.


Lifecycle-manage EndpointSlices on workload clusters for each LoadBalancer-fronted gateway

With #42 we now have a way to serve DNS records from within a workload cluster, based on annotated EndpointSlices in that cluster's API server.
Here we'll automate the creation of those annotated-EndpointSlices on all clusters, based on state in the management cluster.
We'll scope this just to gateways fronted by Service type:LoadBalancer
New CRD:
# lives in the management cluster, in the same namespace as the Cluster it refs
apiVersion: connectivity.tanzu.vmware.com/v1alpha1
kind: GatewayDNSRecord
metadata:
  name: strawberry-gateway
  namespace: foo-team
spec:
  cluster: strawberry
  namespace: projectcontour
  service: envoy
  resolutionType: loadBalancer

New controller:

For each GatewayDNSRecord G

Use Cluster API to discover the public IP address of the ref'd load-balancer service
Render an annotated EndpointSlice, sufficient to drive DNS resolution via #42

For each workload cluster C

ensure there's a copy of that EndpointSlice in the cluster's apiserver

The EndpointSlices would look like
# one of these on every managed workload cluster
kind: EndpointSlice
metadata:
  name: foo-team-strawberry-gateway
  namespace: capi-dns
  annotations:
    connectivity.tanzu.vmware.com/dns-hostname:
      "*.gateway.strawberry.foo-team.clusters.internal"

addressType: IPv4
endpoints:
- addresses:
  - "<LB IP addr>"

Handle updates/deletes as well.

Notes from team discussion:

We'll want to change the EndpointSlice DNS server to only watch 1 namespace (e.g. capi-dns), not all
We'll probably want the installation of that DNS server to be what creates the capi-dns namespace.  Creating the namespace shouldn't be the responsibility of this controller

Notes from team discussion:

Changing the data model to use a clusterSelector instead of the name of the cluster. This is a one to many relationship between the CRD and the clusters. This seems useful because we imagine that the gateway may be deployed similarly on many clusters and repeating that information for each CR is not useful.

apiVersion: connectivity.tanzu.vmware.com/v1alpha1
kind: GatewayDNS
metadata:
  name: contour-clusters
  namespace: foo-team
spec:
  clusterSelector:
    matchLabel:
      hasContour: true
  namespace: projectcontour
  service: envoy
  resolutionType: hostPort


Proposal: Move to github pages & YML files to add authors

Hey! I love the idea of this project and I'd love to help it succeed. It seems like there's been a struggle to get these names out there because of merge conflicts etc.
I'm proposing a few things that I think could help if you're interested, and I'd be willing to try to submit a PR to help out (we'll likely all learn something in the process, definitely me included). I'm proposing that this repo restructure itself similar to the up-for-grabs repo:

Move this repo to generate a web page hosted via github pages. This way we can use a build process to spit out a nice looking list of speakers.
Speaker entries move to YML files within _data/speakers. This will allow folks to quickly & easily add their own speaker information without conflicts. (can also let us build a script to check each speaker file).

I'm thinking it could be a simple site at first that generates the table you're looking for.
Since this is a straightforward repo so far, I'm going to fork it and start making these changes. I'll add an in-progress PR. But by all means, if this isn't a way forward that interests you, let me know. 👍

Oops, I missed the work you were doing over on #78! Let me know if you're set on using hugo or if you'd like me to explore this route. For now I'll put the brakes on it.


FIX: TimeOfMinute subseconds

There was a bug in TimeOfMinute subseconds. Also the minutely condition did not work correctly for subseconds as well.
For example these did not work:

TimeOfMinute("15.2", "45.2")
TimeOfMinute("15.002", "45.002")

Codecov Report

Merging #91 (0a72974) into master (2413a22) will increase coverage by 0.13%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   91.44%   91.57%   +0.13%
==========================================
  Files          89       89
  Lines        4488     4500      +12
==========================================
+ Hits         4104     4121      +17
+ Misses        384      379       -5

Impacted Files
Coverage Δ

rocketry/time/interval.py
98.45% <92.85%> (+2.15%)
:arrow_up:

rocketry/core/time/anchor.py
88.76% <100.00%> (+1.04%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Support directConnect PhantomJS through GhostDriver

Given that PhantomJS has built-in support (GhostDriver) for WebDriver, might it be possible to add directConnect support for it? It would certainly be very convenient to be able to run headless tests without spawning Selenium separately...

This would be a feature of WebDriverJS, so I'm going to close the issue here.


add support for the wasm wasip1 build target

closes #207
please note that I only tested FAT32 image generation at https://github.com/rgl/go-diskfs-create-fat32-img, which was successfully tested with wasmtime, but fails with wasmer. take a look at that repo github actions workflow results.

Pretty cool.


Add a new Korean sample text taken from HunminJeongEum Eonhae (훈민정음언해)

This is to demonstrate the full capability of Noto Sans (CJK) KR -
modern Hangul, archaic Hangul and Hanja.
The sample text was taken from https://ko.wikisource.org/wiki/훈민정음언해
Will fix googlei18n/nototools#120

@dougfelt PTAL Thanks

LGTM


Restore .dockerignore file

This was just a test to see what was wrong with the build. I'm not planning to submit it.
(I do think this would be worth restoring later, but you're right there's a ton of irrelevant stuff in this file atm)


mat-sort-header add noise to mat-cell for accessible users

Bug, feature request, or proposal:
Bug: Table header with mat-sort-header add noise "Change sorting" to all individual mat-cell for accessible users when traversing table using screen reader.
What is the expected behavior?
Sortable table headers are announced as '<column_name> sorted <sort_direction>'.
Grid cells are announced as '<column_name> <cell_value>'.
What is the current behavior?
Sortable table headers are announced as 'Change Sorting for Sorted by <sort_direction>'.
Grid cells are announced as ''Change Sorting for Sorted by <sort_direction> <cell_value>'.
What are the steps to reproduce?
https://drive.google.com/file/d/1-fIokzLKDbx15O8PkDF6uzjwHT5f8dZ6/view?usp=sharing
Try screen reader on the sorting demo example: https://material.angular.io/components/table/examples
What is the use-case or motivation for changing an existing behavior?
Reducing the cognitive load for screen-reader users.

Closing as a duplicate of https://github.com/angular/material2/issues/13012.


Save history of commands after finishing the debug session

First of all, thank you all for this debugger, I'm really enjoying it! 👏
One of the things I miss from byebug is the history of commands (.byebug_history), sometimes when debugging some part of a code we have to run a test more than once to understand what's happening, and in those cases sometimes we have to run more commands than a simple next or continue and then having a history of the commands we've run in the prior session would be really useful.
For example, I was writing a test case for a Rails issue I was checking, but wasn't understanding why the test was passing, to check some information I run connection.execute "SELECT name, sql FROM sqlite_master WHERE type='table' ORDER BY name;", and in the second time I run the test I touched ⬆ of my keyboard to select the command but none of the commands I ran in the prior session was suggested, which required to me write the command again.
I would really appreciate it if it would be possible to add this functionality in future versions of  debug.

Byebug's Implementation
byebug introduced this feature with 3 additional configs:

histfile - the file to store history (.byebug_history)
histsize - the number of commands to store in the file
autosave - whether to save history to histfile

And one commnd: hist[ory] <num>
Also, history is only saved when the user exists the session.
Pry's Implementation
pry also has 3 configuration options for this

Pry.config.history_save is a boolean option, it defaults to true
Pry.config.history_load is a boolean option, it defaults to true
Pry.config.history_file is a string option, it defaults to ~/.pry_history

And a command: hist[ory].
Potential Implementation for debug
New Configs

history_file - default is ~/.debug_history
history_size - default is 1000
history_save - default is true

Commands

hist[ory] - list all history commands
hist[ory] <num> - list <num> history commands
hist[ory] </pattern/> - filter commands with pattern
hist[ory] <num> </pattern/> - list the first <num> of filtered history commands

@ko1 wdyt?

it is in TODO
https://github.com/ruby/debug/blob/master/TODO.md#ui
my considerations:

do you need history command? when do you use it?
do you need size? (why not unlimited?)
do you need history_save? (who want to modify it?)

irb seems to have two configurations:
IRB.conf[:HISTORY_FILE] = nil
IRB.conf[:SAVE_HISTORY] = 1000
my proposals are:

history_file (default: ~/.rdbg_history) and nil/empty for disable history feature.
unlimited history lines
saved at exit

Hey @ko1, sorry I didn't see that TODO file

do you need history command? when do you use it?

I never used history command itself, only through the arrow up.

do you need size? (why not unlimited?)

I don't have opinions on this, maybe today they have limit on size because it can become slow when there are too many lines? (I suppose that it would need a huge amount of lines to become slow)

do you need history_save? (who want to modify it?)

I never had seen a reason to modify it.

my proposals are:
history_file (default: ~/.rdbg_history) and nil/empty for disable history feature.
unlimited history lines
saved at exit

+1 from me

do you need history command? when do you use it?

I don't use it often but I sometimes I use it to recall a Ruby evaluation I used before, for example:
# make ActiveRecord print sqls to stdout
ActiveRecord::Base.logger = Logger.new($stdout)

Its usage is very similar to the history command in terminal.

do you need size? (why not unlimited?)

I'm ok with unlimited size.

do you need history_save? (who want to modify it?)

I don't disable it. So I guess it's ok to not have it.

my proposals are:

history_file (default: ~/.rdbg_history) and nil/empty for disable history feature.
unlimited history lines
saved at exit

Sounds good 👍

https://github.com/ruby/debug/pull/327

Thanks! 🎉🚀


@NGD, @NBD do not work for string arrays

Reported by Andrew Wittenberg on 25 Jul 2007 17:53 UTC
The @NGD and @NBD transformations do not work for string arrays.  See bug 1488
for a related issue.
    NOAA/PMEL TMAP
    FERRET v6.03
    Linux(g77) 2.4.21-32 - 05/25/07
    25-Jul-07 13:45

yes? let a = {1,,2}
yes? let b = {"a",,"b"}
yes? list a,b
X: 0.5 to 3.5
Column  1: A is {1,,2}
Column  2: B is {"a",,"b"}
A   B
1   / 1:  1.000 "a"
2   / 2:   .... ""
3   / 3:  2.000 "b"
yes? list a[            X: 0.5 to 3.5 (number of valid)
Column  1: A is {1,,2} (# of points)
Column  2: B is {"a",,"b"} (# of points)
A   B
I / *:     2.000 ""
yes? list ai=@nbd,b[i=@nbd]
X: 0.5 to 3.5 (number flagged bad)
Column  1: A is {1,,2} (# of points)
Column  2: B is {"a",,"b"} (# of points)
A   B
I / *:     1.000 ""
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/1522

Comment by<EMAIL_ADDRESS>on 25 Jul 2007 18:19 UTC
The idea of missing values for string variables needs more discussion.
I don't find anything in the CF specification about missing-values for string
variables, and Ferret does nothing with missing values for them either:
yes? let b = {"a",,"b"}
yes? say `b,return=bad`
!-> MESSAGE/CONTINUE -1.E+34
-1.E+34

Does a null string necessarily mean a "bad" value for the string variable? It
might be a good default missing value.
As a workaround, if looking for null strings, this can be accessed with STRLEN:
yes? let bgood = IF (STRLEN(b) GT 0) THEN 1
yes? let ngood = bgood(i=@NGD)
yes? let nbad = bbad(i=@NBD)

Comment by ansley.b.manke on 17 Nov 2008 17:29 UTC
We don't have the concept of a "missing" value for string variables. A null string "" is used if a string variable is entered with empty strings. I suppose it wouldn't do any harm to have @NGD and @NBD count the null strings as if they're bad, returning the result with a note:
*** NOTE: For string variables, counting null strings as missing

Comment by ansley.b.manke on 24 Nov 2008 20:31 UTC
Fixed; with the missing value for strings assumed to be the null string (note we COULD probably use the attribute handling code to let the user assign any string to be "missing" without defining Ferret data structures for bad values of strings.)


DUPLO-11108: airflow startup script support

Task linked: DUPLO-11108 TF: support for startup script for airflow


Fix set affinity for user overlay problem (Fixes #2986)

Description

This PR fixes #2986

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

@rhtyd before it is in #2986, then after have not taken, but the author of the issues has confirmed that this solved the problem. We can ask him for a screenshot though.

@rafaelweingartner no problem, sure

I am considering the LGTM given by @svenvogel on #2986. Therefore, I will merge this PR.


site.siteMetaData is not being queried

The starter has the line const siteTitle = get(this, 'props.data.site.siteMetadata.title'); which ultimately resolves to undefined because the site metadata is not being queried in the graphql query.
Need to add this to make it work:
    site {
      siteMetadata {
        title
      }
    }

I'm just starting out with Gatsby and GraphQL. Would you mind telling me where exactly I need to add this?

Pull request #41 resolves this issue. The solution is defined in https://www.gatsbyjs.org/tutorial/part-four/#data-in-gatsby

Resolved with #41


plotDensity in prtDataSetClass is broken

Breaks on line 762 of prtDataSetClass:
xLoc = sort(cat(1,xLoc(:),ds.getObservations(:,iFeature)),'ascend');
More specifically:
ds.getObservations(:,iFeature)

'Input arguments to function include colon operator. To input the colon character,
use ':' instead.'

Not sure if it has something to do with using a newer version of MATLAB (breaks in 2015b and 2016a), or a change made in ds.getObservations.
Changing the line in question to:
xLoc = sort(cat(1,xLoc(:),ds.X(:,iFeature)),'ascend');
fixes the problem.

Ahhh.  Yes.  I think we knew this was coming.  So TMW changed whats allowed in function calls and no longer string-ifies colons for you.... Unfortunately this is all over the place in the PRT.
I went through and found this or similar problems in the following files:
prtPreProcHistEqKde
prtPreProcLogDiscPostPlsda
prtDataGenContextDependent
prtDataSetClass
prtClass
prtDataSetInMem
prtPreProcLogDisc
prtRvKde
prtClassSvmPegasos
prtClassFld
prtClassRvm
prtClassSvmMcode
prtPreProcHistEq
prtRegressRvm
They should all be fixed now.  If you find any more, please let us know.  The easy fix is what you described - .getObservations --> .X and .getTargets --> .Y.
Thanks Dima!

I just found another example of the same issue popping up on line 116 of prtClassBinaryToMaryOneVsAll.
cDataSet = dataSet.setTargets(dataSet.getTargetsAsBinaryMatrix(:,iY));
As suggested by the resulting error, I just changed : to ':' to fix the issue.

Weird - is your PRT up to date?  Those lines don't have that code in my PRT (which I think is up to date)

Nope, it wasn't. Sorry about that! All works great now :).

No prob!  Glad to know you're using it!  And always feel free to report bugs or problems you find.


support abi v2

Pull Request Test Coverage Report for Build 103

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.153%

Totals

Change from base Build 102:
0.0%

Covered Lines:
463

Relevant Lines:
497

💛  - Coveralls


Just A Question

Hi Alex,
Thanks for the great IP.
Can you explain concept of the frame WRT AXI-S, and how you use it?
Thanks
Mike

A frame is just a block of data that is transferred across multiple cycles.  Useful if you're moving things like Ethernet frames over AXI stream.

ok,
How do you determine a frame error?
From the diagram, its tlast & tuser asserted during the same clock?
Is there a meaning defined for tuser?
Thanks
Mike
On Sat, Jul 3, 2021 at 5:29 PM Alex Forencich @.***>
wrote:

A frame is just a block of data that is transferred across multiple
cycles. Useful if you're moving things like Ethernet frames over AXI stream.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/alexforencich/verilog-axis/issues/14#issuecomment-873479052,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLFICCZTXHGTVTXNOUZAVTTV6FN5ANCNFSM47YRGWQA
.

There isn't a standard way of reporting bad frames in AXI stream.  What I usually do is use tuser[0] to mark bad frames, asserted coincident with tlast.

ok, tuser[0] means 'bad frame' as determined by some upstream module in the
system.
What is the design intent of axis_fifo when notified "you just stored a bad
frame"?
Does it rewind the read pointer so that the bad frame is functionally
removed from the fifo?
Thanks
Mike
On Sat, Jul 3, 2021 at 6:11 PM Alex Forencich @.***>
wrote:

There isn't a standard way of reporting bad frames in AXI stream. What I
usually do is use tuser[0] to mark bad frames, asserted coincident with
tlast.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/alexforencich/verilog-axis/issues/14#issuecomment-873482623,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLFICB72BKSRAU4QFC6BBLTV6KJPANCNFSM47YRGWQA
.

Yep.  The FIFOs, in frame mode, can look at any bit of tuser for the bad frame indication.  And yes, the response is to revert the write pointer back to the start of the frame to remove the frame from the FIFO.  Note that this is only possible in frame FIFO mode where the complete frame is spooled in the FIFO before it is released.

It is a great idea; sounds complex though because what if part of that data
has already been read?
Maybe then the pointer is not moved.
Maybe the surrounding state machines are smart enough not to start reading
until they see a non-bad frame enter the fifo.
Poking around on the internet it sounds like some people use a tuser bit
for a start_of_frame indication in video applications.
https://lauri.võsandi.com/hdl/zynq/axi-stream.html
https://lauri.võsandi.com/hdl/zynq/axi-stream.html
Thanks
MIke
On Sat, Jul 3, 2021 at 7:20 PM Alex Forencich @.***>
wrote:

Yep. The FIFOs, in frame mode, can look at any bit of tuser for the bad
frame indication. And yes, the response is to revert the write pointer back
to the start of the frame to remove the frame from the FIFO. Note that this
is only possible in frame FIFO mode where the complete frame is spooled in
the FIFO before it is released.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/alexforencich/verilog-axis/issues/14#issuecomment-873489662,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLFICA3ZHJMLQNVMXKQO2DTV6SNHANCNFSM47YRGWQA
.

In frame FIFO mode, the write pointer is only transferred to the read side when once the entire frame is in the FIFO.

So in frame FIFO mode, the acts a a full packet accumulation buffer. Nice.

Another Question on axi_register module:
Does it register the both valid ready?

Yes.  An additional benefit to frame FIFO mode is that each packet is guaranteed to be delivered without any gaps (tvalid = 0 before tlast = 1), which is useful when feeding Ethernet MACs and similar that cannot tolerate gaps.
The axis_register module will register both the tvalid and tready signals, if it is not bypassed.  There are 3 different REG_TYPE values, 0 means bypassed, 1 means a single register slice with 50% throughput, 2 means a full skid buffer with 100% throughput.  Both the single register slice and the skid buffer will put a flip flop in the tready path (incidentally, the presence of this register is what limits the single register slice to 50% throughput).


zone import fails

This is autogenerated. Please review and update as needed.
Describe the bug
This occurs on any machine i try to import a zone file with.
Command Name
az network private-dns zone import
Errors:
The command failed with an unexpected error. Here is the traceback:
argument of type 'NoneType' is not iterable
Traceback (most recent call last):
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 231, in invoke
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 657, in execute
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 720, in _run_jobs_serially
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 691, in _run_job
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/__init__.py", line 328, in __call__
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/privatedns/custom.py", line 47, in import_zone
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/zone_file/parse_zone_file.py", line 415, in parse_zone_file
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/zone_file/parse_zone_file.py", line 305, in _add_record_names
  File "D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/network/zone_file/parse_zone_file.py", line 205, in _serialize
TypeError: argument of type 'NoneType' is not iterable

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az network private-dns zone import -g {} -n {} -f {}

Expected Behavior
Environment Summary
Windows-10-10.0.19041-SP0
Python 3.8.9
Installer: MSI

azure-cli 2.28.0

Extensions:
application-insights 0.1.13

Additional Context

network


Small speed/mem/style improvements

Some minor improvements.
I looked into further speed improvements, but could not find a usable solution.

Parsing the whole tree with Ox is about 4x faster but uses about 4x the memory, because it keeps the whole tree in memory, unlike Saxerator.
Building a custom streaming parser (with Nokogiri) was about 2x faster than using Saxerator, but is a lot of work to get right and fast. I decided that it's not worth the time and maintenance effort.

LGTM :shipit:


Bug: Delete History not working

The Issue
Deleting visited links does not remove the media thumbnails in the viewer. At first, when you delete it disappears everything as if the history deleted, but once you click on Library tab, the video thumbnails are right there/ re-appears.
Steps to Reproduce

Click on Library tab.

Notice the recently watched media.

Select all the visited media links and delete.

Notice the viewer is empty.

Later click on Library tab, the past media thumbnails are shown / re-appear.

Expected Behavior
Just empty the library viewer / container when user opts to delete the history.
Actual Behavior
The library tab / container shows the past media thumbnails unless they are deleted by clicking on delete icon at the media player one after other.
Suggested Solutions
A simple 'Delete History' button to clear past media / watch history.
System Configuration

Anything Else
Thanks! for the great product.

Thanks for opening this issue! Can we show you some appreciation
The history was for the portion on top, not your LBRY downloads. There's no way to mass delete downloads yet. Closing this issue as the history section is going away for the next release.


Looks like Beta_nether does not exist. Whoops on your part!

2011-12-17 23:39:03 [WARNING] [MultiVerse-NetherPortals]  Looks like Beta_nether does not exist. Whoops on your part!
2011-12-17 23:39:03 [WARNING] [MultiVerse-NetherPortals]  You should check your Multiverse-NetherPortals configs!!
2011-12-17 23:39:03 [INFO] East/West
2011-12-17 23:39:03 [INFO] 2.0,0.6,0.0
2011-12-17 23:39:03 [WARNING] bobdig moved wrongly!
ALL players with identical permissions using the same portal. Some are allowed in and others are refused with the above error.
After a few players are refused the server begins to lag and is constantly spammed with 'cant keep up' messages.

At a minimum, this bug is a Multiverse-NetherPortals bug. Please refile it here. Thanks!


outsiders cannot assign themselves  to work packets.

that makes sense ... shouldn't be too much trouble.
also please merge the PR for the training set.

I haven't found a matching GitHub action for this... Going to develop one over the weekend if I find the time.

I would like to work on this please!

Automatic assignment of issues working through GitHub Actions now. I'll adjust the documentation accordingly.

All done.


Reverse a string using stack

Thanks for your PR.
But how is this related to FizzBuzz?
Please consult the ReadMe before contributing.


improvements on plotting functions that use 'groupby'

This PR addresses issues from #979 and #1103 related to sc.pl.dotplot and replaces PR #1127
Furthermore, the current PR attempts to unify common code between dotplot, matrixplot and stacked_violin plots while at the same time adding more flexibility to the plots.
This PR also makes possible to plot fold changes, log fold changes and p-values from sc.tl.rank_genes_groups as suggested in #562
To achieve this the sc.pl.dotplot, sc.pl.matrixplot and sc.pl.stacked_violin method had been transformed into wrappers for the new DotPlot, MatrixPlot and StackedVioling classes. Accessing the new classes directly allows further fine tuning of the plots.
The use of the sc.pl.dotplot, sc.pl.matrixplot and sc.pl.stacked_violin  didn't change, only the new parameter return_fig was added.
For clarity, the relevant code has been moved to scanpy.plotting._groupby_plots.py.
The new plot classes are all descendants of a BasePlot class that captures most of the common code shared between the plots. The design of the classes follows the method chaining (as found in Pandas or Altair). This allows the addition of independent features (via well documented methods) to the plot without increasing the number parameters of a single function. This was first suggested here #956.
For example, for dotplot is now is possible to add category totals, define the titles for the colorbar and size legend and modify the values for edge color and edge line with for dot plot and the size exponent used (among may other options). For example:
adata = sc.datasets.pbmc68k_reduced()
markers = {'T-cell': ['CD3D', 'CD3E', 'IL32'], 'B-cell': ['CD79A', 'CD79B', 'MS4A1'],
           'myeloid': ['CST3', 'LYZ']}
dp = sc.pl.dotplot(adata, markers, groupby='bulk_labels', return_fig=True)
dp.add_totals(size=1.2)\
    .legend(color_title='log(UMI count+1)', width=1.6, show_size_legend=True)\
    .style(cmap='Blues', dot_edge_color='black', dot_edge_lw=1, size_exponent=1.5)\
    .show()

All objects have consistent functions for legend, to set up titles and width, style() to set visual parameters specific to each plot like colormap, edge color, linewidth. swap_axes to transpose the figure, add_dendrogram with options to change the with of the dendrogran and add_total tho show a bar plot of the total number of cells per category. Also includes options to sort the categories.

Here is description of changes:
all figures:

Set a title to the image.
Pass an axe where to plot the image.
Return a dictionary of axes for further manipulation
using return_fig the plot object can be used to adjust the proportions to the legend and other visual aspects can be fine tuned.
a bar plot with the totals per category can be added. This will align at the left of the image if the categories are plotted in rows or at the top if they are plotted in columns.
legend can be removed
groupby can be a list of categories.

dotplot

Improved the colorbar and size legend for dotplots. Now the colorbar and size have titles, which can be modified using the colorbar_title and size_title arguments. They also align at the bottom of the image and do not shrink if the dotplot image is smaller.
Plot genes in rows and categories in columns (swap_axes).
Using the DotPlot object the dot_edge_color and line width can be set up, a grid added as well as several other features
sc.pl.rank_genes_groups_dotplot can now plot pvals and log fold changes

matrixplot

added title for colorbar and positioned as in dotplot
sc.pl.rank_genes_groups_matrixplot can now plot pvals and log fold changes

stacked_violin

[update] violin colors can be colored based on average gene expression as in dotplots
made the linewidth of the violin plots smaller.
removed the tics for the y axis as they tend to overlap with each other. Using the style method they can be visualized.

TODO:

[x] Update tests
[x] Update tutorial and readthedocs

This looks nice.
Any estimation of this will be merged into master? Thanks

@z5ouyang Mostly is ready. I have been using it and does not break any previous functionality. Seems quite stable. I am now working on the tutorial.

The last changes in stacked_violin allows to use a color map as in dotplot
pmbc = sc.datasets.pbmc68k_reduced()
marker_genes_dict = {'NK': ['GNLY', 'NKG7'], 'T-cell': ['CD3D'],
                     'B-cell': ['CD79A', 'MS4A1'],
                     'Monocytes': ['FCGR3A'],
                     'Dendritic': ['FCER1A']}

fig, (ax1, ax2) = plt.subplots(1, 2, figsize=(11,5), gridspec_kw={'wspace':0.3})
sc.pl.stacked_violin(pbmc, marker_genes_dict, groupby='bulk_labels', ax=ax1, show=False)
sc.pl.dotplot(pbmc, marker_genes_dict, groupby='bulk_labels', ax=ax2, show=False)

In the dotplots, when the color_on == 'square', fixed dot edge color might lead to some trouble in visibility when the square color and dot edge happen to be similar.
There is a nice feature of seaborn heatmap, where the annotation text color is determined conditionally on the square color, see:

It can be too much work, feel free to ignore but just wanted to highlight.

@gokceneraslan Thanks for pointing this out! The relative_luminance function required for this can be easily imported from seaborn, therefore, I imagine that the code can be adapted easily.

@gokceneraslan I just added the dynamic coloring of the circles when the color is on the background square.
adata = sc.datasets.pbmc68k_reduced()
markers = {'T-cell': ['CD3D', 'CD3E', 'IL32'],
           'B-cell': ['CD79A', 'CD79B', 'MS4A1'],
           'myeloid': ['CST3', 'LYZ']}

sc.pl.dotplot(adata, markers, groupby='bulk_labels', return_fig=True)\
             .style(color_on='square', cmap='binary').show()

Looks phenomenal! Thanks so much.

@fidelram Sorry, I completely missed your asking for a review! It does look good though.
However, it looks like this is breaking the docs. Could you take a look into that?

I think the issue that there are references to the DotPlot class, but no doc page get's generated for that class. I think this can be fixed by adding something like:
Classes used for these plots:

.. autosummary::
   :toctree: .

   pl._dotplot.DotPlot

to the doc-string of the plotting module.

@gokceneraslan I just added the dynamic coloring of the circles when the color is on the background square.

@fidelram The cool dynamic line coloring feature seems broken now, I wonder why :/

Is because we changed dot edge the defaults shortly before the release. Time to add a test for this.
I will make a fix but meanwhile you can trigger the dynamic coloring by setting dot_edge_color and dot_edge_lw as None:
sc.pl.dotplot(adata, markers, groupby='bulk_labels', return_fig=True)\
             .style(color_on='square',  dot_edge_color=None, dot_edge_lw=None).show()


Can´t find variable: PushNotification with 1.9.0 plugin version

Hello everybody,
I am developing Cordova iOS app in Visual studio on Windows PC. I am deploying app to device via remote agent on my MAC.
When I deploy app to a device I got following error in Web Inspector:
Reference error: Can´t find variable: PushNotification
Project settings:
Cordova CLI: 6.4.0
iOS platform version: 4.3.0
Plugin version: 1.9.0
Device: iPhone 5s (iOS 10.1.1)
I got this in my config.xml:
 <engine name="ios" spec="~4.1.0" />

<plugin name="phonegap-plugin-push" spec="https://github.com/phonegap/phonegap-plugin-push.git">
       <variable name="SENDER_ID" value="123456789xxxx" />
</plugin>

Sample Push Data Payload
$body['aps'] = array(
'alert' => array(
'title' => $mobile_title,
'body' => $message,
),
'sound' => 'default',
'badge' => 1,
);
Sample Code that illustrates the problem:
var push = PushNotification.init({
android: {
senderID: "123456789xxxx",
},
ios: {
alert: "true",
badge: "true",
sound: "true",
},
windows: {}
});
I have been stuck for few days now. I didn´t install Cocoa Pods (Don´t know if this is optional or required?). Trick mentioned here https://github.com/phonegap/phonegap-plugin-push/issues/779 doesn´t seem to work now.
Also plugin was working fine with earlier versions before iOS 10 came out.
Any help would be mostly appreciated.
Tomas

@1989TomE Yeah, cocoapods are required in 1.9.0 and later.
Try installing cocoapods or using 1.8.4.

I faced the same issue in Android while building it in build.phonegap.com, downgrading it to v1.8.4 solved the issue
p.s: It is not happening while building it in local machine for android.

Thanks you for your answers.
I finally managed to resolved the issue by moving my cordova project to MAC. I upgraded cordova iOS platform to 4.3.0 there, than opened and deployed the app directly in Xcode. I installed cocoapods and pod file was created automatically (by upgrading platform or when building project I am not quite sure).
Downgrading to v1.8.4 might be bettter solution regardless, because I wouldn´t have to move my project to MAC. Thanks for the tip.


Questions regarding disposition_category in the hospitalization table

Good afternoon! I am currently working on disposition_category for the Penn data transformation. I have a few questions perhaps somebody can help clear up.

Are we mapping all AMAs as Other or Home?
We have a category for discharge to law enforcement custody - would this be home or other? (My thoughts are that the patient is medically ready for home but not legally ready for home so "home" should be appropriate.)
We also have a category for patient's admitted for deceased organ donation - they are not physically deceased yet but will be upon donation - would we categorize this as Dead or Other?
Finally, would a disposition of "observation" be considered acute care hospital or other?

we need to discuss this further, but I have wanted to keep AMA as its own category, but we should talk as a group about that.  I know that for 90% of projects they will get lumped into "Home" (that's where i think it should be lumped into), but there may be times when doing studies on less severe things that would warrant being able to identify those patients.
agreed... should be Home
I think this speaks to need an admission category as well.  not sure we have talked about that yet.  I would argue that having the admission category be "Deceased Organ Donation" and Dispo be "Dead" would be appropriate.  It would also help us filter out these admission because MOST of the time we won't want these admission at all
good question.... I think this brings up another issue.... technically the entire admission should be considered in these databases and the "hospitalization_id" (previously "encounter_id") should represent the whole hospitalization from start to finish.  Technically no one should have a disposition of observation... it should technically be the dispo of the observation admission should be the dispo for both of those encounters (I'm assuming they are separate encounters based on the data).  @08wparker does that make sense

@ingra107 I agree with 4. I am assume these are scenarios where the patient goes from the ED to an observation unit. ideally we would join the ED visit and an observation record into one hospitalization_id if the patient never left the hospital

@ingra107 @08wparker As Nick notes in #3 having an admission category will be helpful. ('Hospital Transfer', 'ED Admit', 'Direct Admission', 'Elective Surgery'). I think this will be important; for example for any process 'early in the course of critical illness' we may want to exclude transfer patients. Certainly that would probably be the case for prone positioning and early ventilator settings...?

so @chochbe1 the idea is to make admission_type_name and admission_type_category and add it to the hospitalization table?

@08wparker ... yes.  I think that will be best.  you can see how I do dispo and admit type in my logic below
if(!exists("admit_source_trib")){

admit_source_trib <- tribble(
                                                                        ~enc_admit_source, ~enc_admit_source_cat,
                                                                   "Emergency Department",                     1,
                                                                              "Home/Work",                     1,
                        "Skilled Nursing, Intermediate Care, or Assisted Living Facility",                     1,
                                                                    "Admission From Home",                     1,
                                                                "External ED to Hospital",                     1,
                                                                "Non-Healthcare Facility",                     1,
"Admission From Skilled Nursing Facility, Intermediate Care, or Assisted Living Facility",                     1,
                                                    "Non-HealthEast Emergency Department",                     1,
                                                                  "Court/Law Enforcement",                     1,
                    "Admission From Psych, Substance Abuse, or Behavioral Rehab Facility",                     1,
                                                                        "Normal Delivery",                     1,
                                                                                "Hospice",                     1,
                                                 "Transfer from Critical Access Hospital",                     1,
                                                                     "Premature Delivery",                     1,
                                                                       "Extramural Birth",                     1,
                                                              "Born Inside this Hospital",                     1,
                                                                     "Trans from Hospice",                     1,
                                                             "Born Outside this Hospital",                     1,
                                               "Transfer from Another Home Health Agency",                     1,
                        "Transfer from a Designated Disaster Alternative Care Site (ACS)",                     1,
                                                                  "Admission From Clinic",                     2,
                                                             "Physician or Clinic Office",                     2,
                                                         "Prescheduled Admission/Surgery",                     2,
                                           "Transfer From Hosp Inpt Within Same Facility",                     2,
                                                      "Discharge/Readmit (Same Hospital)",                     2,
                                                              "Ambulatory Surgery Center",                     2,
                                                                   "Hospital to Hospital",                     3,
                                                         "Hospital (Acute Care Facility)",                     3,
                                                     "Other Type of Health Care Facility",                     3,
                                                 "Other Health Care Facility To Hospital",                     3,
                                                                                NA,                     4,
                                                              "Information Not Available",                     4,
                                                                           "HMO Referral",                     4
)

# factor admission source
admit_source_trib <- admit_source_trib |>
  mutate(enc_admit_source_cat = factor(
    enc_admit_source_cat,
    levels = 1:4,
    labels = c("ED" ,
               "Direct" ,
               "OSH" ,
               "Other")
  ))
}

###  Getting discharge categories set
if(!exists("discharge_disp_trib")){

discharge_disp_trib <- tribble(
                                                                   ~enc_disch_disp, ~enc_discharge_disp_cat,
                                                               "Home or Self Care",                       1,
                                                            "Home-Health Care Svc",                       1,
                                                           "Home IV  Drug Therapy",                       1,
                                                               "Home Care - Other",                       1,
                                                          "Home Care - HealthEast",                       1,
                                                                     "CORE Clinic",                       1,
                                       "Home with Planned Hospital IP Readmission",                       1,
                           "Planned Acute Care IP Readmission - Home or Self Care",                       1,
                           "Planned Acute Care IP Readmission - Home Care - Other",                       1,

                       "Home-Health Care Svc with Planned Hospital IP Readmission",                       1,
                                  "IRTS - Intensive Residential Treatment Program",                       1,
                                                   "Adoptive Parent / Foster Care",                       1,
                                                                            "IRTS",                       1,

                                                                 "Assisted Living",                       2,

                                                                      "Group Home",                       3,
                                                             "Jail/Police Custody",                       3,
                                                        "MN Correctional Facility",                       3,
                                                                         "Shelter",                       3,
                                                                   "Halfway House",                       3,
                                                           "Court/Law Enforcement",                       3,
                        "Jail/Police Custody with Planned Hospital IP Readmission",                       3,

                                                            "Acute Rehab Facility",                       4,
                                                      "Rehab Facility - Inpatient",                       4,
                       "Acute Rehab Facility with Planned Hospital IP Readmission",                       4,
                  "Planned Acute Care IP Readmission - Rehab Facility - Inpatient",                       4,

                                                        "Skilled Nursing Facility",                       5,
                                        "Medicaid Only Certified Nursing Facility",                       5,
                           "Nursing Facility with Planned Hospital IP Readmission",                       5,
                   "Skilled Nursing Facility with Planned IP Hospital Readmission",                       5,
                    "Planned Acute Care IP Readmission - Skilled Nursing Facility",                       5,

                                                         "Left Without Being Seen",                       6,
                                                     "Left Against Medical Advice",                       6,

                                                     "Psych Facility - HealthEast",                       7,
                                                            "Psychiatric Hospital",                       7,
                                                          "Psych Facility - Other",                       7,
   "Substance Abuse Treatment Program - Inpatient/Not Part of Acute Care Facility",                       7,
                                                        "CD Facility - HealthEast",                       7,
                       "Psychiatric Hospital with Planned Hospital IP Readmission",                       7,
                                                             "CD Facility - Other",                       7,
                      "Planned Acute Care IP Readmission - Psych Facility - Other",                       7,
                                                  "Mental Health Jud Commit Anoka",                       7,
                                                                "Crisis Residence",                       7,

                                                             "Short Term Hospital",                       8,
                                     "Another Health Care Institution Not Defined",                       8,
                                                 "Acute Hospital - Non-HealthEast",                       8,
                                                      "Intermediate Care Facility",                       8,
                                            "Cancer Center or Children's Hospital",                       8,
                                                     "Acute Hospital - HealthEast",                       8,
            "Another Health Care Institution with Planned Hospital IP Readmission",                       8,
                        "Short Term Hospital with Planned Hospital IP Readmission",                       8,
                                                                       "Swing Bed",                       8,
                                                         "Disaster Alternate Care",                       8,
                             "Disch/Trans to Designated Disaster Alternative Site",                       8,
                              "Planned Acute Care IP Readmission - Acute Hospital",                       8,
                                                        "Critical Access Hospital",                       8,
                   "Critical Access Hospital with Planned Hospital IP Readmission",                       8,
                 "Intermediate Care Facility with Planned Hospital IP Readmission",                       8,
                                                                "Federal Hospital",                       8,
                                   "Intermediate Care Facility - State Designated",                       8,
                           "Federal Hospital with Planned Hospital IP Readmission",                       8,
                            "Planned Acute Care IP Readmission - Federal Hospital",                       8,
           "Cancer Center or Children's Hosp with Planned IP Hospital Readmission",                       8,
                                  "Swing Bed with Planned Hospital IP Readmission",                       8,

                                       "Planned Acute Care IP Readmission - LTACH",                       9,
                                                            "Long Term Acute Care",                       9,
                                                                "LTACH - Bethesda",                       9,
                                                          "LTACH - Non-HealthEast",                       9,
                       "Long Term Acute Care with Planned Hospital IP Readmission",                       9,

                                                                    "Hospice/Home",                      10,
                                                             "Hospice - Home Care",                      10,
                                                      "Hospice - Medical Facility",                      10,
                                                        "Hospice/Medical Facility",                      10,

                                                              "Expired in Hospice",                      11,
                                                                         "Expired",                      11,
                                                     "Expired in Medical Facility",                      11,
                                                         "Expired - Place Unknown",                      11,
                                                                 "Expired at Home",                      11,

                                                      "ED Dismiss - Never Arrived",                      12,
                                                                      "FV Cutover",                      12,
                                                 "ED Dismiss - Diverted Elsewhere",                      12,
                                                               "Level III Nursery",                      12,
                                                             "ED Dismiss - Code 9",                      12,
                                                                                NA,                      12,

                                                        "Admitted as an Inpatient",                      13,
                                                                 "Still a Patient",                      13
   )

# factor discharge destination
discharge_disp_trib <- discharge_disp_trib |>
  mutate(enc_discharge_disp_cat = factor(
    enc_discharge_disp_cat,
    levels = 1:13,
    labels = c(
      "Home",
      "Assist Living",
      "Group Home/Shelter/Jail" ,
      "Acute Inpt Rehab" ,
      "SNF" ,
      "Against Med Advice (AMA)" ,
      "ChemDep/Psych"  ,
      "Another Hosp"  ,
      "LTACH"  ,
      "Hospice" ,
      "Expired" ,
      "missing",
      "Still Admitted"
    )
  ))

}

looks like your admission_type_category proposal is ("ED" , "Direct" , "OSH" , "Other") which seems like a good start to me.
@ingra107 looks like this enc_discharge_disp_cat field has several more levels than the CLIF discharge_category which has levels
"Home"
"Hospice"
"Acute care hospital"
"Still Admitted"
"Inpatient Rehab Facility"
"Skilled Nursing Facility"
"Long Term Care Hospital"
"Psychiatric Hospital"
"Dead"
"Other"
Do you want to propose a modification to our discharge_category CDE as the point of contact for the hospitalization table? Remember we will still have discharge_name.
Also I would recommend storing as string VARCHAR data types (instead of that specialty R factor data type with levels/labels)

re VARCHAR: totally agree... you can tell this was the first thing i did when i translated my stata to R code lol.... very newbie mistake to factor something so quickly
re discharge_category: These are the ones I use for studies, I wasn't sure if ppl had put a lot of thought in to the discharge_category before and thus didn't want to step on toes.  I think finding that sweet spot of keeping some granularity without getting too into the weeds is ideal and I think these categories suffice.  I think adding "Against_medical_advice" would be appropriate.  The only other I have thought about is whether we have a Chemical_dependecy_detox category as well.

I think this makes the most sense to me
1 Home
2 SNF
3 Expired
4 Acute Inpt Rehab
5 Hospice
6 LTACH
7 Another Hosp
8 Group Home/Shelter/Jail
9 ChemDep/Psych
10 Against Med Advice (AMA)
11 Assist Living
12 Still Admitted
13 missing/other

Notes:

If discharged to Home/Hospice, discharge_category == Hospice
Final discharge_category
1 Home
2 Skilled Nursing Facility (SNF)
3 Expired
4 Acute Inpatient Rehab Facility
5 Hospice
6 Long Term Care Hospital (LTACH)
7 Acute Care Hospital
8 Group Home
9 Chemical Dependency
10 Against Med Advice (AMA)
11 Assist Living
12 Still Admitted
13 Missing
14 Other
15 Psychiatric Hospital
16 Shelter
17 Jail

@kaveriC - add UMMN mapping to CLIF repository & data dictionary

Admission source category: "ED" , "Direct" , "OSH" , "OR", "Other" @clif-consortium add another open issue to be discussed Post-ATS


Age Of Empires

Hello Please make compatibility with Age Of Empires.
When you copy a file to a game, bad colors disappear but FPS is slow

I don't have any FPS issues. Are you using the latest experimental release? Which version of Windows and Age of Empires?

Win 7 64 bit. Age of empires v. 0.7.22

Yes Latest experemental release. In the past release fps is excellent, but the colors in the menu are different and there is no mouse

I'm not sure if we're talking about the same game. I don't think there was a v0.7.22 of AoE. Even the file version of the trial is already <IP_ADDRESS>2 and product version is 1.0. Official patches are also like 1.0a/b/c.
Please right click on "empires.exe", go to Properties -> Details and copy the following fields here:

File description
File version
Product name
Product version

Also, what do you use to measure your FPS? Or is it just visibly stuttering? Do you have any issues in the main menus or only in game?
Make sure desktop composition is enabled and there are no compatibility settings applied to the executable file, as those could cause issues also.

Closing due to inactivity. Feel free to reopen if you have more info available.

Closing due to inactivity. Feel free to reopen if you have more info available.


fix: Turn off maxBodyLength in Axios

Axios has a maxBodyLength which defaults to
2000 bytes. Given that the payloads for the
logger can be much larger than this, turn this
limitation off. It should be noted that there's
only 1 report of this in the wild, and the problem
has not been able to be reproduced.
Semver: patch
Fixes: https://github.com/logdna/logger-node/issues/44

LGTM, I think it makes more sense to lean on FLUSH_BYTE_LIMIT here anyway

Yes it does, although we shouldn't have to mess with that much. I'm using 1MB payloads and can't re-produce the error.  In any case, we don't need Axios limiting us here.


Receiving error

I've substitued the issuesId and the credentials from the code that's uploaded. Do I need to change something more?
I'm receiving this error:
node:internal/errors:541
      throw error;
      ^

TypeError [ERR_INVALID_ARG_TYPE]: The "id" argument must be of type string. Received undefined

I ran into the same issue and realized I missed the step of setting up the GOOGLE_APPLICATION_CREDENTIALS environment variable. You can check if it's set by doing the following:
echo $GOOGLE_APPLICATION_CREDENTIALS
See this page for how to set it: https://cloud.google.com/docs/authentication/provide-credentials-adc#local-key
It worked for me! Hope this helps


Single file release for in-browser use

consider this a rant
I am building a full stack app that also has desktop components all the way down to native code and code patching to capture video.
As such I am allergic to 100500 build systems used at all layers, and NPM with Webpack are of the most annoying ones for oh so many reasons.
Can I please have a prepacked single .js file of the latest release I could copy to my SPA and import as a ES6 module? The only thing I ever needed was to know if my SDP answer has a=inactive for the video stream. 😭

You are requesting something because AFAIU this library fails to be imported when using webpack.  It shouldn't fail unless webpack is doing wrong assumptions, and I'm pretty sure that webpack is able to import this library. If not, please dig into the problem and, if you figure out it's related to this library, then report a proper issue.
Other than that I suggest the author @clux to close this ticket since having to provide with a bundled single JS file is not the way to go anymore in modern JS development.

THE SOFTWARE IS PROVIDED 'AS IS'.
Explicit suggestions are of course welcome, but this is unproductive.


Missing Information

[Enter feedback here]
This page doesn't specify the product it applies to

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 893843c1-bbd0-2953-5594-b7483accd046
Version Independent ID: 33b132fe-2c07-0c59-4766-e3b534ea010b
Content: Performance tuning with result set caching - Azure Synapse Analytics
Content Source: articles/synapse-analytics/sql-data-warehouse/performance-tuning-result-set-caching.md
Service: synapse-analytics
Sub-service: sql-dw
GitHub Login: @XiaoyuMSFT
Microsoft Alias: xiaoyul

@DennesTorres
Thank you for reaching out. At this time we are reviewing the ask and will provide an update as appropriate

@DennesTorres
Thank you for reaching out. At this time we are reviewing the ask and will provide an update as appropriate

Hello @DennesTorres  . I was reviewing the doc and I do see that , it is mentioned as "dedicated SQL pool " , which to me looks to me good enough to point that the content is related to dedicated SQL Pool . Let me know if you have any other ideas .

Hello @DennesTorres  . I was reviewing the doc and I do see that , it is mentioned as "dedicated SQL pool " , which to me looks to me good enough to point that the content is related to dedicated SQL Pool . Let me know if you have any other ideas .

@DennesTorres  We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.

@DennesTorres  We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


⚠ BroadcasTheNet has degraded performance

In 0029903, BroadcasTheNet ($BTN) experienced degraded performance:

HTTP code: 200
Response time: 1760 ms

Resolved: BroadcasTheNet performance has improved in 498a0c8.


Feature Request: download button in app

It would be nice to have the download functionality of the web app available in the iOS app.

Related to https://github.com/OdyseeTeam/odysee-ios/issues/198 and https://github.com/OdyseeTeam/odysee-ios/issues/104.


Expose mAP50_95 Object Detection metrics

When OD metrics are calculated, MaP50 and MaP95 calculations are both done at the same time. Expose both of these metrics to users in Model Builder / CLI.

@luisquintanilla  if I understand this scenario correctly we want to expose them to training results, right?

If yes, ml.net IEvaluateMetricManager does not allow us to expose more than one metric calculation, even if it calculates but still exposes on of them.
This might be don from ml.net sides
@LittleLittleCloud  thoughts?

Correct. This is as part of the training results.

We should only expose mAP 95 since we're letting users choose their threshold.

Sorry for the confusion. mAP50_95 is what we're looking to expose.


Best Volume Control

Hello, what is the best way to control the sonos volume with the Home-App, is it
"platforms": [
{
"platform": "ZP",
"service": "fan"
}
]
Is it also possible to use it with Siri?
Greeting

See https://github.com/ebaauw/homebridge-zp/issues/10#issuecomment-270743358.


ResourceExhaustedError - Jetson TX1

I ran into a ResourceExhaustedError errror on my Jetson TX1 with 4GB of RAM. How much RAM is needed/recommended to test the code???
Ubuntu 16.04
python 3.5
tensorflow 1.5.0
cv2 3.3.0
pretrained_dilation_cityscapes.pickle - 537MB

ResourceExhaustedError (see above for traceback): OOM when allocating tensor of shape [7,7,512,4096] and type float
[[Node: fc6/Variable/initial_value = Const[dtype=DT_FLOAT, value=Tensor<type: float shape: [7,7,512,4096] values: [[[-4.46356426e-05 0.000302301254 -0.00146040611]]]...>, _device="/job:localhost/replica:0/task:0/device:GPU:0"]()]]

Hi @kaisark,
I can run the forward inference on a Quadrok2200 with 4GB of memory.
Are you trying to train the model or just using the pretrained one frozen for inference? Since during training your memory footprint is much bigger.

I'm running into the same problem and I'm not training the network. Just running it.
GPU: NVIDIA GeForce GTX 1060 3GB
8 GB of RAM
Running it on a windows desktop

Is it possible that the pickle may have been updated and is now larger?

The pickle containing pre-trained weights was never updated since the first release on this repo.
The weird thing is that I tried today on my Quadro (I have not used this model recently) and it goes indeed in OOM.


Fix CI flake overrides

We were victims of the non-transitivity of flake overrides. This should work better.

It appears that libcrux has copy-pasted some karamel files into its repo, hence using the eurydice-compatible version of karamel is not enough. I'll let them sort that out.


ChocolateyGui.exe - blank icon

Don't know why doesn't show a proper icon, if there's such a thing for the .exe:

File version <IP_ADDRESS>

This should be fixed in the upcoming version of ChocolatyGUI.
See issue #589


add tests to validate working state

I wrote some tests as I familiarized myself with the code.  I figured they might be seen as helpful.

Most definitely, if you are poking around and something seems weird, please say so. Would be easy to change now as Sibbell is the only thing using it. Merge whenever you want.
I poked around a little on the python 3.6 thing with Travis, I'm guessing you probably did some of the same. I'll make an issue for that, would be nice to test against 3.6...

@davegaeddert
Okay, this is now working with python 3.6 as well as everything else.  I had to be specific and explicit, but it seems like clean, obvious solution.

Closes #9

Seems good to me.


"Has Flea" still inconsistent

"Has Flea: False" now excludes flea pricing from components of a craft, but the end product still seems to use the flea price

These aren't the flea prices; these are the amounts you'd get for selling these items to traders. The theory being that if a player doesn't have the flea, an item is "worth" the amount they'd get if sold to a trader. However, the icon should probably be different to differentiate it from "buy from trader" prices.

No, the sell to trader prices are clear, I'm talking about the price under the result product (The power cord), it still says
"39 000 R @ Flea Market"

Oh yeah I see that now. Crafts will basically never be profitable before the flea market, though. The whole question of how much ingredients "cost" and how much crafted items are worth is really weird in that context.

@Reithan I see a pull request #128 was linked in this PR and now closed. Did this resolve the issue or is this still a problem? If so, I can label accordingly or close if it is resolved

That's another similar issue, rather than a pull request it looks like?
This issue is...not cut-and-dry I think, as @Razzmatazzz was pointing out - I don't know what the best answer to this one is.
As he pointed out - if we do what the 'obvious' thing here is and show the trader value for crafts if you have no flea, then nothing will be worth crafting.
But, you could assume that most people know that, and would likely be crafting things they plan to sell once they get flea unlocked? I don' tknow

Perhaps we could just add a warning in like big red letters at the top if you have flea toggled off?
But still show all the non-flea numbers.

 But caveat emptor, I suppose.


Store stuff with SQLite instead of Postgres

SQLite is stored in a file, not with a service. Makes things simpler. Look at https://github.com/jgallagher/rusqlite

When migrating, use transactions!


Collections 1.1.3 adoption

Update the swift-collections dependency to use version 1.1.3.
This bug fix update fixes:

a performance bug in BigString which affects swift-foundation (https://github.com/apple/swift-collections/pull/405), rdar://131176282
Deque.Iterator's Sendable conformance.

This is an augmented cherry-pick of https://github.com/swiftlang/swift/pull/76101 (adds updates to the 6.0 and 6.0.1 branches).

@swift-ci please test

Swift 6.0.2 has been released.


2 little fixes needed in New-SelfSignedCertificateEx

I've found few differences creating a self signed certificate using New-SelfSignedCertificateEx.

If I don't specify explicitly KeyUsage = "CRLSign, KeyCertSign" when creating a certificate with IsCA parameter, Key Usage in certificate property is "Information Not Available".
In documentation it says that if IsCA option is used KeyUsage is set to CRLSing, KeyCertSign by default.

If I don't specify ProvideName explicitly with ProviderName option, provider used is "Microsoft Enhanced RSA and AES Cryptographic Provider".
In documentation it says that default parameter is "Microsoft Enhanced Cryptographic Provider v1.0". (maybe I'm using Windows 2016 S.O.)

it is my fault. When migrated the code I simply forgot this. Will fix this.
Docs issue. Online version is updated to reflect actual behavior. I deprecated "Microsoft Enhanced Cryptographic Provider v1.0" default provider long ago.

First part of this issue is fixed in the code.


[otbn] Outstanding blanking discussion

Blanking has been added to OTBN with this PR: https://github.com/lowRISC/opentitan/pull/10824
In the review @vogelpi raised two points of discussion that still need to be resolved.

How should write data into the register file be blanked? Currently this is blanked per register, so we have an independent set of blanking AND gates for each register. As an alternative we could have a single set of blanking AND gates for the write data that fans out to all registers. If we use this alternative then data being written will be present at the D input of all registers rather than just the register being written to. Will this cause undesirable leakage?

Can we remove some blanking from the bignum ALU data path? Withing the bignum ALU there are two adders, adder X and Y. One of the operands for adder Y can come either from the register file or from result of adder X. There are blanking AND gates on the datapath between the register file and the operand selection mux for adder Y, are these needed? See the ASCII diagram in the file https://github.com/lowRISC/opentitan/blob/6c31d3c9048cd84a77539549af3889cda251536d/hw/ip/otbn/rtl/otbn_alu_bignum.sv#L38-L74

This blanking is the small 'b' between 'A' and adder Y via a mux at the bottom of the diagram. I explained on the PR in more detail:

When Adder X and Adder Y are used together the adder Y input is from Adder X, the operand A input isn't used by Adder Y. We only use the A operand directly with Adder Y when we use Adder Y alone.

When we're using Adder X and Adder Y operand A generating a power signature it doesn't need to in the mux above Adder Y (see text diagram at top of this file) may not be a problem as it will generated a power signature in Adder X, which it has to do.

Again when we're using Adder Y only A will generate a power signature in adder X (which it doesn't need to do) and a power signature in the mux above Adder Y (which it does need to do). Perhaps also not a problem?

@vogelpi @msfschaffner @cdgori @tjaychen what are your thoughts?

Thanks @GregAC for opening this issue and for giving more background info.

The cost for blanking per register is around 8kGE (32*256 AND gates) compared to blanking the write data (1x 256 AND gates) but I think if we can spend the area we should probably keep it to be on the safe side. Blanking per register should give weaker leakage as the fan out is reduced quite a lot. Also, it might save us from issues where two subsequent instructions using different ALU/MAC parts write to different registers. We already blank the different ALU/MAC parts separately so should also cover this case but the blanking per register adds some additional safety in case we missed something.

This is much cheaper than 1. and I think we should have it, too. What changed my mind is the scenario where we use Adder Y alone. I am not an expert with masked software but I think depending on the algorithm/implementation it is possible that a single operand/register may contain both shares e.g. split in LSBs and MSBs, or that shares are distributed to different operands/registers. Now, imagine we have Share 0 of 2 secrets in Operand B and Share 1 of the same secrets in Operand A and want to shift Operand B and add it to Operand A in Adder Y to compute something like Share 0 Secret 0 + Share 1 Secret 1. If we don't blank the inputs for Adder X separately, we will also get the Leakage of unshifted addition, i.e., Share 0 + Share 1 for both secrets. This would be bad. I would say let's just keep the individual blankers for every Adder/Shifter/Mux input inside the ALU.

I agree with @vogelpi on number 1. The fanout could potentially be a big issue if we miss something.
Regarding number 2, i agree with @vogelpi about the blanking in front of adder X, but i thought the question was more about the blanking in front of adder Y? So in the scenario you're describing, the input of adder X should already be blanked, so the intermediate results shouldn't be too interesting.  Let me know what I missed.

@GregAC: What's the follow-on action for this?

I think we'll leave things as is. Effectively what we have here is potentially more blanking than we actually need. We're agreed the per register write data blanking is needed (which is the part that's expensive in area), maybe we can remove some blanking from the ALU data path but it's not a big deal to leave in.


Complete the process of sending data to Segment

Created tooling to send data into Segment.
For testing purposes the funcitonality was split into three scripts:

mk-segment-batch-payload.sh - For creating JSON records for the Segment batch API
segment-uploader.sh - For actually talking to the batch API
segment-mass-uploader.sh - For splitting a stream of records into right-sized chunks for uploading and then repeatedly calling segment-uploader.sh

Also needed a slight change to splunk-to-segment.sh to make it emit compact records instead of formatted data.

@amisstea fixed according to your suggestions, PTAL


DynamicParameters built inside a PowerShell function ignore ParameterAttribute.Position property

DynamicParameters built inside a PowerShell function ignore ParameterAttribute.Position property
Steps to reproduce
function DynamParamFunc {
    [CmdletBinding()]
    param(
        [Parameter(Position = 2)]
        $Param2
    )

    dynamicparam {
        $Param1Attribute = New-Object -TypeName System.Management.Automation.ParameterAttribute
        $Param1Attribute.Position = 1

        $AttributeCollection = New-Object -TypeName System.Collections.ObjectModel.Collection[System.Attribute]
        $AttributeCollection.Add($Param1Attribute)
        $Param1Param = New-Object System.Management.Automation.RuntimeDefinedParameter('Param1', [string], $AttributeCollection)
        $ParamDictionary = New-Object System.Management.Automation.RuntimeDefinedParameterDictionary
        $ParamDictionary.Add('Param1', $Param1Param)
        return $ParamDictionary
    }

    end {
        $PSCmdlet.GetDynamicParameters()
        $Param2
    }
}

Try and use tab completion for the parameters, Param2 will appear first despite Param1 having a lower position.
Expected behavior
Param1 is position 1
Param2 is position 2
Actual behavior
Param2 is position 1
Param1 is position 2
Environment data
Name                           Value
----                           -----
PSVersion                      5.1.14393.1066
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.1066
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

@lfshr Thanks for your report! Here is PowerShell Core repo - please check the Issue with latest PowerShell Core version.

There is no intentional correlation in ordering of parameters during tab completion and the position attribute.
Generally speaking, the order is the order declared, but this is not guaranteed. For binary cmdlets, we rely on reflection, and the order returned by reflection is not guaranteed. It is often the order the parameters were defined in C#, but not necessarily.
Also note that hosts are free to reorder the completions, e.g. Intellisense may sort them alphabetically.
It's also not clear if honoring the position provides a good experience with all cmdlets - e.g. if we started mixing parameter sets to honor position, things could get more confusing.

The 'Position' parameter seems fairly pointless if it doesn't position it in the way specified. Generally speaking I like to position things in the order of importance, with non-mandatory parameters being at the end. This is currently not achievable with a dynamic parameter. What if I wanted a really important parameter to help the user by offering a dynamic ValidateSet? (this is my use-case atm)

The point of Position is so you can omit the parameter name, so in a way, it's like the opposite of what you want for Intellisense.
That said, dynamic validate set seems to be the primary use case for dynamic paramaters these days - so I opened an issue: https://github.com/PowerShell/PowerShell/issues/3744

Closed as #3744 is a better solution.


fix for code warnings at compiation time

Ok in general I can rename other as unsupported and then provide an error. Have to add the tests and check under the original occa.


[WIP] normalize_doc_attributes option: convert doc attributes to comments

In order to help out with https://github.com/servo/servo/issues/21059, I started looking at #2883.
This PR converts #![doc = ""] and #[doc = ""] attributes to //! and /// doc comments.
I marked it as WIP because of these points I'm unsure about:

it's been a while since I've contributed and there were no mentoring instructions on the issue: is this how you were expecting this feature to be done ? There might be obvious problems with this approach/code, but that the tests don't cover currently ?
should I offset or shrink the shape before passing it to rewrite_doc_comment ?
I've documented the option as unstable in Configurations.md, is that correct ?
what kind of tests should I add in addition to the one in the PR ? Do you foresee possible problems interacting with other options for example ?

Thanks for the PR!

it's been a while since I've contributed and there were no mentoring instructions on the issue: is this how you were expecting this feature to be done ? There might be obvious problems with this approach/code, but that the tests don't cover currently ?

Looks good to me!

should I offset or shrink the shape before passing it to rewrite_doc_comment ?

I'm not 100% sure, but I don't think so. It would be worth experimenting with a few doc comments on different items with different relative indents though.

I've documented the option as unstable in Configurations.md, is that correct ?

Yes.

what kind of tests should I add in addition to the one in the PR ? Do you foresee possible problems interacting with other options for example ?

the new tests look good. I would add some tests which check that when the option is on that other attributes stay the same and also that when the option is off doc comment attributes are not converted (this latter might be covered already in some other case, in which case we don't need new ones).
The only other options I would worry about interaction with are the other comment ones. Given they are not in a great state I wouldn't worry about any specific tests though.

I've pushed commits to add more tests and address the comments

Thanks for the changes!


Add volume adjustment while in standby

This should resolve #43.
This is done by forcing a TTS for "......." before setting the volume if nothing is detected playing.  When playing a Flash Briefing, there is no media reported, but it appears to successfully change the volume without interrupting the skill.   Tested for US English so it's possible the multiple period may break in another language.

@keatontaylor Would you object to using the TTS hack as a temporary fix until you have time to reverse the APK?
As for your other thought on routine sequences from the script, I looked when I implemented routines in the API but I didn't see an effective way to do it. While I could find examples of how to call existing sequences, I didn't see a programmatic way to create them. The script doesn't have a solution either for volume.
Of course, I'll need to refactor this for #73 before I merge it in.

Nevermind, I found the sequence being used in routines Alexa.DeviceControls.Volume. This is tested to work even when set_media didn't. I'll close this proposal and add it to the 1.0.0 release.


Visual enhancement

Hi
I noticed for the recent added 4px one of the stages is not in bold as the others
Example:

Thanks for your great work!

Hi, thanks for the feedback.
I've just released some visual changes, removed the bold text and added a label for the location.
What you think?

Hi, thanks for the feedback.
I've just released some visual changes, removed the bold text and added a label for the location.
What you think?

Hi
It looks great
Good job!
Thanks for your work :)

Hi
It looks great
Good job!
Thanks for your work :)

Cool!

Cool!


Nullify deployed_by_id if the user removed

If the user got removed, the deployed_by_id in deployments points to the id of the user that no longer exists. Need to add the dependent :nullify strategy.

TESTED on prod - OK