Dependency version warning

Dependency line:
github.com/fuweid/embedshim --> github.com/containerd/containerd --> github.com/urfave/cli
github.com/containerd/containerd v1.5.13 --> github.com/urfave/cli v1.22.1
https://github.com/containerd/containerd/blob/v1.5.13/go.mod#L119
Background
Repo github.com/containerd/containerd at version v1.5.13 uses replace directive to pin dependencygithub.com/urfave/cli to version v1.22.1.
According to Go Modules wikis, replace directives in modules other than the main module are ignored when building the main module.
It means such replace usage in dependency's go.mod cannot be inherited when building main module. And it turns out that fuweid/embedshim depends on<EMAIL_ADDRESS>which is different from the pinned version containerd/containerd needed.

https://github.com/fuweid/embedshim/blob/unstable/go.mod(Line 19)

github.com/urfave/cli v1.22.2

https://github.com/containerd/containerd/blob/v1.5.13/go.mod(line 52&119)

github.com/urfave/cli v1.22.2
github.com/urfave/cli => github.com/urfave/cli v1.22.1

So this is just a reminder in the hope that you can notice such an inconsistency.
Solution
1. Bump the version of dependency github.com/containerd/containerd
You can try upgrading dependency github.com/containerd/containerd to a newer version, which may have eliminated the use of this directive.
2. Add the same replace rule to your go.mod
replace github.com/urfave/cli => github.com/urfave/cli v1.22.1

Closing because it looks like bot reply. Please feel free to reopen it if it is mistake.

It seems to relate to issue https://github.com/urfave/cli/issues/1092. I'm just giving a kind reminder entirely from the perspective of dependency analysis. It doesn't necessarily mean it will cause dependency issues to your project at now, but it might be better to update to a new fixed version of urfave/cli, say [v1.22.6 - v1.22.12]. Overall, it depends on your choice and there is nothing particularly serious.

@Ben131-Go Thanks for the comment. I reopen it and fix it later.


Update Stable Manifest (release branch)

Motivation
Modifications
Result
PR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags

[ ] Unit tests pass locally
[ ] FVT tests pass locally
[ ] If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

[ ] Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

/retest

@vaibhavjainwiz do we still need this pr?


Add new learning factors

The priority is to define two new learning factors for the enhanced version of the advanced brain.  One will enable it to see whether or not the member's decision was good for the whole team or if the actions selected put the team's survival in jeopardy. The other required factor will be to see, while testing and exploring, if it's better to converge as a whole on a few targets at the same time or if it's better to go and attack the target that has a tactical disadvantage against us.

The optional learning factor will depend on how long the spike turns out to be and if there's enough time before handing in the prototype. The last factor for learning will enable the brain to make safe and tactical decision while attacking the human's party. Even though a target might be given at the beginning, it may be required to change our target in-between even if it isn't eliminated.
The reason behind this is, even though a character might have a tactical advantage over one character, against more than one, the chance of survival becomes slim. A character must then be able to "think" and assess a situation. Maybe there's a target that is isolated and be attacked instead of a dangerous target that has his team members for backup. The heat map will enable the brain to make efficient decision towards where to send next a unit.


Lock Screen Notifications settings don’t work

Expected behavior
Settings under Global settings → Notifications → Lock Screen Notifications should affect the content of lock screen notifications. I.e., “Message count and senders” should show the number of new emails and their senders, “Application name” should show only the K-9 Mail name and nothing else, and so on. (This presumes, of course, that the Android global setting to hide sensitive content in lock screen notifications is disabled.)
Actual behavior
All settings under Global settings → Notifications → Lock Screen Notifications are completely ignored and have zero effect. Lock screen notifications are normal, revealing senders, subjects and body content. The only setting within K-9 Mail that affects lock screen notifications is Global settings → Privacy → Hide subject in notifications; when enabled, notifications show only the number of unread emails per account.
This happens both on my new Samsung Galaxy S8+ and my old Asus Zenfone 3 (ZE552KL).
All apps (including Android) are fully updated.
Steps to reproduce

Go to Global settings → Notifications → Lock Screen Notifications and select any setting.
Lock phone and receive a new email (such as by sending one to yourself via another device).
Observe that chosen setting is completely ignored; senders, subjects and body content are all visible.
Optionally, enable Global settings → Privacy → Hide subject in notifications, which hides email content, but is still unaffected by the Lock Screen Notifications settings.

Environment
K-9 Mail version: 5.600
Phone: Samsung Galaxy S8+
Android version: 8.0.0
Account type: IMAP (Gmail)

Am I the only one this happens to? Or was my bug report unclear? Would’ve expected someone to reply or close this or something by now. Just wondering.

I ran into this myself when I picked the "Hide subject" option...  which doesn't actually hide it only on the lock screen, but everywhere, if the message comes in while locked.  i.e. unlocking the phone doesn't return the information to the notification.  I forgot where I had set that so I was screwing with the Lock Screen Notifications setting in the meantime before I found it again and reproduced the above while playing with that. I'm currently running version 5.706

The Hide subject option didn't work particularly well (see comment by justdave). If we fixed it to work properly, it would most likely match the Lock Screen Notifications option Message count and senders. So with #5690 we got rid of the Hide subject setting.
I wasn't able to reproduce the issue of the Lock Screen Notifications setting not having any effect at all. However, it does require using a "secure" screen lock method (i.e. not "Swipe") and choosing the option "Show sensitive content only when unlocked" when setting up the screen lock in Android settings.
An issue I did run into was the lock screen notification being empty when there was just one new message. When there were multiple new messages the lock screen notification worked as intended.
The reason for that is Android's notification grouping mechanism not quite working as expected. When there's only one new message we're still treating it as a (notification) group. That means we create a notification for the individual message and a "summary" notification with essentially the same contents. On Android versions that don't support grouped notifications that summary notification is the only one that is displayed. On newer Android versions the notification sound and some other values are taken from the summary notification, but the collapsed notification is mostly generated from the contents of the individual notifications that make up the notification group. The "public" notification, i.e. the one that is displayed on secure lock screens, is a property of the summary notification. But only if the notification group consists of more than one message. If there's only one message, the "public" notification needs to be set on the individual notification (the notification sound is still taken from the summary notification :shrug:). This is quite annoying, but easy to work around.

This seems to be broken since I got the latest upgrade. Notifications on the lock screen show all details independent of the setting.
Pixel 4a
K9 version 6.000
Android version 12
Account type IMAP

Please open a new issue including instructions on how to reproduce the bug.


chore: regular upgrade

chore: regular upgrade
refactor: use std

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.92%. Comparing base (24461f7) to head (8f836b7).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   89.13%   88.92%   -0.22%
==========================================
  Files          15       15
  Lines         948      948
==========================================
- Hits          845      843       -2
- Misses        103      105       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix discoJar task

There's some conflict with the META-INF keys, excluding the directory in
the shadow task fixes it.

Current coverage is 81.42% (diff: 100%)

Merging #412 into master will not change coverage

@@             master       #412   diff @@
==========================================
  Files           185        185
  Lines          6914       6914
  Methods           0          0
  Messages          0          0
  Branches        896        896
==========================================
  Hits           5630       5630
  Misses         1015       1015
  Partials        269        269

Powered by Codecov. Last update 94de9f2...49c8091

I'm adding this to every discovery related change from now on hahaha

LGTM
(but what does META-INF do and why do we need it?)

As best I understand, it's metadata pooled from all the individual jars associated with the project. The stuff I'm excluding is keys that are included from some of the third party jars that, when the jar is executed, cause a security mismatch due to invalid signature. Excluding them all prevents this failure.


feat: Add job management API endpoints

This PR adds job management API endpoints exposed via a new class named TriggerManagementAPI

/claim #388

Thanks for this @neo773! Our front-end guru who will be picking this front-end design up is away for the week on holiday so it might be awhile before we can get this one in to production.

@ericallam Any updates?

Sorry this has been in a holding pattern, our designer @samejr is hopefully going to get to this next week 👍

@neo773 working on the UI now...

/tip $200

Hey @neo773 thanks for working on this issue. I'm going to close this PR now as we need to rework some more things before we can implement it, but i've paid the bounty in the meantime.


Creating a Client with set_as_default=False sets client as default

What happened:
If I create a Client with set_as_default=False in the arguments, the client still gets set as the default.
What you expected to happen:
The client that I create should not be set as the default client.
Minimal Complete Verifiable Example:
>>> from distributed import Client, default_client
>>> default_client()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.8/site-packages/distributed-2.25.0-py3.8.egg/distributed/client.py", line 4550, in default_client
    raise ValueError(
ValueError: No clients found
Start a client and point it to the scheduler address
  from distributed import Client
  client = Client('ip-addr-of-scheduler:8786')

>>> c = Client(set_as_default=False)
>>> c
<Client: 'tcp://<IP_ADDRESS>:40813' processes=4 threads=4, memory=12.57 GB>
>>> default_client()
<Client: 'tcp://<IP_ADDRESS>:40813' processes=4 threads=4, memory=12.57 GB>
>>> c == default_client()
True

The default_client() calls after creating a client with set_as_default=False should throw a ValueError just like before creating the client.
Anything else we need to know?:
None.
Environment:

Dask version: 2.25.0
Python version: 3.8.5
Operating System: Linux f9c08655086d 4.19.76-linuxkit #1 SMP Tue May 26 11:42:35 UTC 2020 x86_64 GNU/Linux
Install method (conda, pip, source): pip

This could be a bug -- maybe it's a usability issues.  I am not very familiar with the set_as_default flag but I would assume this is used more often when a cluster is already created and usage looks more like :
cluster = LocalCluster(...) # or some other cluster creation
client = Client(addr, set_as_default=False)

Could be wrong.  @kinghuang it looks like you are relying on Client to also create the cluster

It's still the default client, but it isn't the default Dask scheduler.  If you go and run some computation
df.compute()

Dask will still use whatever default scheduler there is (likely the local threaded scheduler)

Ah, perhaps I'm not understanding the distinction between a client and a scheduler. I always thought that running something like df.compute() caused it to use the default client. How do I find out what the default scheduler is, and detect that I'm not overriding it?
I'm trying to write unit tests for some code that can potentially create multiple clients (to different Dask clusters). I'm specifying set_as_default=False to not affect the default client, and was checking this via default_client(), but it seems my understanding of how Dask works is incorrect.
So, if I do something like the following, I should still expect the dataframe to be computed locally, even though the default client is pointing to a remote cluster?
client1 = Client("tcp://remote-cluster-a:8786", set_as_default=False)
client2 = Client("tcp://remote-cluster-b:8786", set_as_default=False)

df.compute()

The set_as_default keyword was originally designed to protect
against overwriting the non-distributed schedulers, see
https://docs.dask.org/en/latest/scheduling.html
In this case "Scheduler" is a bit overloaded because the distributed
scheduling system also has a component named "Scheduler" (the thing made by
the dask-scheduler command), which is somewhat different.
The default scheduler function is, I think, accessible as
dask.config.get("scheduler").  I don't know of a way to protect against
overwriting the default client today.
The behavior that you're asking for here is reasonable.  The fact that this
situation is confusing is mostly our fault.  We could change the meaning of
the set_as_default keyword.  I think that there might be unintended
consequences though.  The next step here is probably to make this change,
run the test suite, and see if anything breaks.
On Mon, Aug 31, 2020 at 12:42 PM King Chung Huang<EMAIL_ADDRESS>wrote:

Ah, perhaps I'm not understanding the distinction between a client and a
scheduler. I always thought that running something like df.compute()
caused it to use the default client. How do I find out what the default
scheduler is, and detect that I'm not overriding it?
I'm trying to write unit tests for some code that can potentially create
multiple clients (to different Dask clusters). I'm specifying
set_as_default=False to not affect the default client, and was checking
this via default_client(), but it seems my understanding of how Dask
works is incorrect.
So, if I do something like the following, I should still expect the
dataframe to be computed locally, even though the default client is
pointing to a remote cluster?
client1 = Client("tcp://remote-cluster-a:8786", set_as_default=False)client2 = Client("tcp://remote-cluster-b:8786", set_as_default=False)
df.compute()
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/6584#issuecomment-683997551, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AACKZTC4ML53E6UCEZJEWOTSDP4KTANCNFSM4QQZUJSQ
.

Thanks, that helps me understand things much better, especially the current behaviour of set_as_default.


vscode-extensions: Add OceanicNext theme

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

There should be only one single commit, formatted just like the PR title

should I create a new pr, or what can I do with the current one?

@ofborg build vscode-extentions.naumovs.theme-oceanicnext

Thanks for your contribution! Welcome to the Nix family.
Keep PRs coming!

@drupol Thank you for your help. In the near future I will create pr of other extensions, based on your recommendations, which other users may also need.


Allowing use of internal sdcard

It seems like it was just that easy. Running into some issues importing from studio, though.

Does this change work for all phones?

(e.g. - do some phones not have an SD card?)


Deleting Downloaded files

How do you delete downloaded files? Is this done automatically?

There is a settings option that let's you automatically clear the list upon startup. You can also hit shift-d to delete them one by one.


METRON-1709 : Added the required scripts to start / stop PCAP topology from Ambari

Contributor Comments
Created PCAP topology as Metron component, Created  required scripts to create kafka topic, hdfs folder for pcap sequence files with required ACL's and added controls to start / stop the PCAP topology from Ambari.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[x] Have you included steps or a guide to how the change may be verified and tested manually?

[ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[ ] Have you written or updated unit tests and or integration tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

I am not able to spin-up the Full Dev environment with this.  It keeps failing here.
TASK [ambari_config : Deploy cluster with Ambari; http://node1:8080] ***********
fatal: [node1]: FAILED! => {"changed": false, "failed": true, "msg": "Ambari client exception occurred: Could not create blueprint: request code 400,                     request message {\n  \"status\" : 400,\n  \"message\" : \"Cluster Topology validation failed.  Invalid service component count: [METRON_PCAP(actual=0, required=1)].  To disable topology validation and create the blueprint, add the following to the end of the url: '?validate_topology=false'\"\n}"}
	to retry, use: --limit @/Users/nallen/tmp/metron-pr1201/metron-deployment/development/centos6/ansible/playbook.retry

PLAY RECAP *********************************************************************
node1                      : ok=76   changed=42   unreachable=0    failed=1

Ansible failed to complete successfully. Any error output should be
visible above. Please fix these errors and try again.

Can you merge this with master?  It is hard to tell what is part of this PR.

@nickwallen having separate panel for PCAP configs is been addressed in the pull request  1132. It will be a duplicate effort here.

@MohanDV ... pull request 1132. It will be a duplicate effort here.

Gotcha.  I was not aware of the other PR.  That will work.

+1 Looks great.  Thanks a bunch for the contribution.

I want to hold off on the merge until we get the pcap properties change sorted on this. @anandsubbu  is opening a re-opening a PR on that.

Hi @nickwallen , I would like to create a fresh pull request based on these changes. Could you go ahead and merge this please ?


Installation issues?

While trying to get FoundationPress up and running I ran into a problem. First my notes:
Node.js:	https://nodesource.com/blog/chris-lea-joins-forces-with-nodesource
after a lot of searching around I ended up here.  Run the named script and ended up with node.js 0.10.40 which seems to be good. Older version gave warnings in previous tries..
npm:	https://docs.npmjs.com/getting-started/installing-node
This tells me how to update npm after installing node.js:  sudo npm install npm -g
After this I have npm 3.3.3 installad
under wp-content/themes/  clone FoundationPress with
git clone https://github.com/olefredrik/FoundationPress.git
the line as mentioned in the readme.md doesn't seem to work due to the lack of credentials or smt.
For now I leave the name as is as I just want things to work..
cd FoundationPress
npm install
as mentioned in the README.md
And there the issues start:
--->8---
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g
npm WARN lifecycle<EMAIL_ADDRESS>cannot run in wd %s %s (wd=%s<EMAIL_ADDRESS>bower install && grunt build /var/www/wordpress/wp-content/themes/FoundationPress
--->8---
and according to the html source of the frontpage there should now be a http://<IP_ADDRESS>/wp-content/themes/FoundationPress-master/assets/stylesheets/foundation.css
But.. no stylesheets directory nor content..
So are my expectations wrong, did I miss something? While I understand that this is not an  issue perse (although the docu seems to be a bit lacking for sass beginners) I couldn't really find an other place to discuss FoundationPress.

Hi @jondor ,
I just wrote a blog post called FoundationPress for beginners. Check it out here:
https://foundationpress.olefredrik.com/posts/tutorials/foundationpress-for-beginners
I have just updated the repository (about an hour ago) with support for the most recent version of Node.js. So if you clone a fresh version of the repository and head over to nodejs.org and install version 4.1.1, you should be good to go.

Thank  you, but no.. it still doesn't work.
I created a clean new virtual machine with ubuntu server 14.04. Installed apache, mysql, php and wordpress and have a working environment.
Installed node.js (4.1.1), upgraded npm globaly to 3.3.3, installed sass (3.2.12) and git of course..
Bower is also available systemwide with version 1.5.3
Added FoundationPress to the themes folder using git clone https://github.com/olefredrik/FoundationPress.git
cd FoundationPress, npm install..  as written in the readme.
As I don't really have a clue what the result should be I activated FoundationPress as theme and checked the homepage. No CSS, but according to the header there should be an assets/stylesheets/foundation.css which isn't there.
I assume this should be created among thing using the npm install. But nope.
npm install seems to run fine with two warnings:
npm WARN prefer global<EMAIL_ADDRESS>should be installed with -g
and
npm WARN lifecycle<EMAIL_ADDRESS>cannot run in wd %s %s (wd=%s<EMAIL_ADDRESS>bower install && grunt build /var/www/wordpress/wp-content/themes/FoundationPress
My gut says the later should be the problem, but really no clue why. After that it's the dependency tree.
node_modules is nice and full, no error logs in the FoundationPress folder, but also no assets/stylesheets nor a foundation.css
For what it's worth, bower, grunt and node-sass are all in the node_modules folder.
Afaik I've followed the readme (more than once I might add..;) and even installed ruby-sass in case of.
Any tips or tricks are appreciated as I'm new to this environment. I'm learning a lot from all this, but still no working FoundationPress..
Thanks!

Hi @jondor ,
Looks like we're almost there. The reason why your assets folder does not contain the stylesheets and scripts, is because this is generated last in the npm install process (postinstall).
I'm a little unsure why this happens. Possibly it has to do with permissions related to your Node/npm installation?
What you could do, is to install Grunt (if you haven't already done that) http://gruntjs.com/installing-grunt and remove the postinstall script from your package.json file.
Your new package.json file should now look like this:
{
 "name": "foundationpress",
 "title": "FoundationPress",
 "version": "1.5.0",
 "description": "FoundationPress is a WordPress starter theme based on Foundation 5 by Zurb",
 "keywords": [
   "FoundationPress",
   "WordPress",
   "starter theme",
   "Foundation",
   "semantic",
   "mobile first",
   "customizable",
   "responsive"
 ],
 "homepage": "http://foundationpress.olefredrik.com/",
 "bugs": "https://github.com/olefredrik/FoundationPress/issues",
 "license": "MIT",
 "main": "Gruntfile.js",
 "repository": {
   "type": "git",
   "url": "https://github.com/olefredrik/FoundationPress.git"
 },
 "devDependencies": {
   "bower": "~1.4.1",
   "grunt": "~0.4.5",
   "grunt-cli": "^0.1.13",
   "grunt-contrib-compress": "~0.13.0",
   "grunt-contrib-concat": "~0.3.0",
   "grunt-contrib-copy": "~0.4.1",
   "grunt-contrib-uglify": "~0.2.7",
   "grunt-contrib-watch": "~0.5.3",
   "grunt-sass": "~1.1.0-beta",
   "grunt-string-replace": "~0.2.7",
   "node-sass": "~3.3.0",
   "time-grunt": "~1.1.0"
 }
}

Then run npm install && bower install && grunt build

Thanks.. I managed to get a stylesheet and an answer on what went wrong.. It was, of course, my own stupidity. As this is a virtual test environment which will never see any other user but me I made my life easy (I thought) and logged in as root..
Bower doesn't like that..  For now I used the --allow-root to deal with this, but it's clear that I have to restart once more using a more professional approach to installing my "play" environment..
For now thanks for the top-notch service and help!

Yay, I'm glad you figured it out! If everything is now as it should, feel free to close the issue :)


Don't allow web connections in specs

See https://robots.thoughtbot.com/how-to-stub-external-services-in-tests

:+1:


Add ability to add a point on either side of a linear element

I thought this was already in place, but I can't make it work:
I expect that if I select a "starting" point, then press "alt", I should be able to "prepend" points to the line. But it seems that I can only add points to the end.

Could be easily implemented, but what about when you select points in the middle? Should it append to one of the ends, or should it create a new point in between the selected + next point?

I think creating a new point in between would be nice, the problem is, which side of the selected point? And this will leave one segment that you cannot add points to (say the first segment from p0 to p1).
This is a solved problem in other software, here's what Sketch does:

Doesn't require alt pressed, always is in "add point at front mode"
Allows you to highlight any segment, if you click on it you create a point at the precise location you're pointing at
To add point before first point, first select the first point, then you get to create a point there

I kinda like the alt requirement though, because without it the vector tools always feel like you create accidental points which you didn't intend to create.

Here's an option (but might not be super obvious):

Support selecting multiple points using shift (this should be a separate issue that we don't atm)
If two points are selected, pressing alt creates a new one between them

One thing about this alt based creation: You get to see the result before you confirm it with a tap.
(there should also be a way to close the loop, not sure whether we have an issue for that)

if two points are selected, pressing alt creates a new one between them

I think this is too complex, both conceptually (hard to explain this behavior in a hint) and ergonomically.
How about this:
Create the next point based on cursor position relative to the selected point based on what "side" the cursor is on. To figure out what side to create it on, we'd consider the selected point's normal (line perpendicular to its tangent):

This should work for first and last point, too. Not sure if there are edge cases for which it would not work.

(there should also be a way to close the loop, not sure whether we have an issue for that)

Actually, if you create/position the last point close to the first point, it auto-closes the loop already. The only problem is it currently doesn't show the preview of this behavior while you hold ALT.

Create the next point based on cursor position relative to the selected point based on what "side" the cursor is on by taking into account the selected point's normal (line perpendicular to its tangent):

That said, for edge points this algo might not be desired. E.g. consider the below case:

I think this problem occurs for the middle points too (ie, I might want to create the middle point on the other side of the "normal"), and this is why the suggested approach might work (or might not be "ideal"). But it's worth implementing and seeing how it feels, maybe iterating on it later.

Actually, if you create/position the last point close to the first point, it auto-closes the loop already. The only problem is it currently doesn't show the preview of this behavior while you hold ALT.

We should file an issue for this (if not already).

@dwelle fyi, what you are talking about is called a Voronoi diagram. Each shaded area corresponds to all the pixels that are closest to a particular point in the 2d space.

I think this problem occurs for the middle points too (ie, I might want to create the middle point on the other side of the "normal"), and this is why the suggested approach might not be "ideal". But it's worth implementing and seeing how it feels, maybe iterating on it later.

That's true, but an argument can be made that more often than not when creating a point between to other points, you just want to correct for something and not deviate too far. Thus the algo I propose may be "good enough" for the common case. But it'd need to be implemented so we can try it out, as you say.

@dwelle fyi, what you are talking about is called a Voronoi diagram. Each shaded area corresponds to all the pixels that are closest to a particular point in the 2d space.

Right, I now recall this. It's a similar concept but my proposal is not aiming to figure out which of the two points are closer to the cursor, instead I want to figure out which of the two planes (delineated by the selected point's normal) the cursor is on. In Voronoi diagrams you can notice that the borders do not intersect the points, while in my solution they do.


browser to phone Call

Hello
how to set specific number for caller id  there are only one parameter for create new call "destinationNumber".
const params = {
destinationNumber: document.getElementById('number').value, // required!
audio: document.getElementById('audio').checked,
video: document.getElementById('video').checked ? { aspectRatio: 16/9 } : false,
};
currentCall = client.newCall(params);
there are caller id set randomly please help me how to set from number in new call function

Hi @cooldeeparmar! Set the caller id in the JS SDK is not supported yet. We're working on it and will be released soon!

@cooldeeparmar You can specify callerNumber when making a new call, and it will properly set the caller ID when dialling a phone number. Thanks for the suggestion!

Thank you for your reply
On Tue, 17 Sep 2019, 10:26 pm Bryan Rite<EMAIL_ADDRESS>wrote:

@cooldeeparmar https://github.com/cooldeeparmar You can specify
callerNumber when making a new call, and it will properly set the caller
ID when dialling a phone number. Thanks for the suggestion!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/signalwire/signalwire-node/issues/180?email_source=notifications&email_token=ADCDLUKMW4MR4GNNUSI4R5TQKED2LA5CNFSM4IVDTPPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD65F6FI#issuecomment-532307733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADCDLUN3ZHQCYULTAFG5BOLQKED2LANCNFSM4IVDTPPA
.


feat: bundle login as separate feature

The login option is still actively under construction. In order to separate this from other stable features, we have classified the login functionality as a conditionally compiled feature. By default login will not be included, but may be adding --features login to cargo build or cargo run.
Closes #167

@malandis do the list of "features" show up in the help somewhere?  If so, I would prefer to just comment out the option.  If not, then this is probably fine.
@rlinehan would you mind reviewing this?  My suggestion was to just comment out the subcommand for now, I figure when you all start picking this work up again you can just use a local build of mm until the command is ready for prime time.  I don't really want the "under construction" thing to show up in the help menu after our GA announcement.  Just wanna make sure this is okay with you.

@malandis do the list of "features" show up in the help somewhere? If so, I would prefer to just comment out the option. If not, then this is probably fine.

No, it doesn't show up. This is more like a feature flag. You have to specify you want it included at build time, eg
cargo build --features login
Otherwise it is not compiled in

However, I couldn't figure out if the features are included in build steps when we open PRs or merge PRs? I would definitely want that the features can be compiled.

Thank you for considering this. In b0fc3893cbf438adf232f0890a49e8abe83625e9 I added a matrix to the CI workflow so that the build and tests will exercise over both the production features and also the login features. That way when a developer works on the login code they will also have automated build and tests through GH. Once we graduate login to stable we can remove the feature from both the code and the CI workflow.


Fixing identation

[Added Chrome Support]
[FIXED Identation]
[IPull Request Details]
Here are the list of files I have updated/Created
Created a new File  chrome.py

Made a new file to control Varibles for chrome extension

Central file manager for  its global variables which are used/shared across multiple modules

Updated File  __main__.py

Added support  new argument --chrome  -cr

made a function modchecker  which initialises global variables from chrome.py across the entire  programme, and checks whether chrome argument was passed or not and act accordingly

refactored code in such a way, that when chrome extension is called, the server will run, even for command line ( so that it can recieve post requests)

Updated File  tab.py

added CORS support to flask app, so that it can  handle cross origin ajax requests from browsers, and provide call authorisation from browser for security reasons

Created a new function, so as to recieve songs from browser via post requests

modified songchanged function , to handle song changes due to extension, using the variable isSameSong

Updated File  spotify.py

added support to recieve songs and artist from chrome.py when spotify.song() and spotify.artist() are called in tab.py

Hello @TarunKurella! Thanks for opening this PR.

In the file setup.py:

Line 19:121: E501 line too long (126 > 120 characters)

In the file swaglyrics/__main__.py:

Line 34:1: W191 indentation contains tabs
Line 37:1: W191 indentation contains tabs
Line 38:1: W191 indentation contains tabs
Line 39:1: W191 indentation contains tabs
Line 39:46: F821 undefined name 'port'
Line 40:1: W191 indentation contains tabs
Line 41:1: W191 indentation contains tabs
Line 41:1: W293 blank line contains whitespace
Line 42:1: W191 indentation contains tabs
Line 42:2: E265 block comment should start with '# '
Line 43:1: W191 indentation contains tabs
Line 44:1: W191 indentation contains tabs
Line 44:3: E117 over-indented
Line 45:1: W191 indentation contains tabs
Line 46:1: W191 indentation contains tabs
Line 46:4: E117 over-indented
Line 47:1: W191 indentation contains tabs
Line 48:1: W191 indentation contains tabs
Line 49:1: W191 indentation contains tabs
Line 49:4: E117 over-indented
Line 50:1: W191 indentation contains tabs
Line 55:1: W191 indentation contains tabs
Line 60:1: W191 indentation contains tabs
Line 60:3: E117 over-indented
Line 61:1: W191 indentation contains tabs
Line 62:1: W191 indentation contains tabs
Line 62:22: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 63:1: W191 indentation contains tabs
Line 63:4: E117 over-indented (comment)
Line 64:1: W191 indentation contains tabs
Line 64:4: E117 over-indented
Line 65:1: W191 indentation contains tabs
Line 66:1: W191 indentation contains tabs
Line 95:1: W391 blank line at end of file

In the file swaglyrics/spotify.py:

Line 66:1: W191 indentation contains tabs
Line 66:2: E117 over-indented
Line 66:21: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 67:1: W191 indentation contains tabs
Line 67:3: E117 over-indented
Line 68:1: W191 indentation contains tabs
Line 68:1: W293 blank line contains whitespace
Line 87:1: W191 indentation contains tabs
Line 87:2: E117 over-indented
Line 87:21: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 88:1: W191 indentation contains tabs
Line 88:3: E117 over-indented
Line 89:1: W191 indentation contains tabs
Line 89:1: W293 blank line contains whitespace
Line 105:1: W391 blank line at end of file

In the file swaglyrics/tab.py:

Line 28:1: E302 expected 2 blank lines, found 1
Line 33:8: F821 undefined name 'request'
Line 33:36: F821 undefined name 'request'
Line 34:20: F821 undefined name 'request'
Line 40:38: W291 trailing whitespace
Line 47:24: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 51:14: E111 indentation is not a multiple of four
Line 51:14: E117 over-indented
Line 52:19: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 55:1: W293 blank line contains whitespace
Line 56:1: W293 blank line contains whitespace
Line 59:1: W391 blank line at end of file

Do see the Hitchhiker's guide to code style

namespace chrome error during CI builds.
update test

namespace chrome error during CI builds.
need to update test

Patch the tests that do not contain chrome with that argument set to false 👍

The extension isn't working for me.

What's the status?


await deleteCookies() Atleast URL or Domain needs to be specified for deleting cookie

Expected behavior
await deleteCookies() >> should clear all browser cookies
Actual behavior
Error Message: Error: Atleast URL or Domain needs to be specified for deleting cookies
Stacktrace:
Error: Atleast URL or Domain needs to be specified for deleting cookies
Steps to reproduce

apply await deleteCookies() as part of step implementation

Versions
taiko version 0.7.1 (Chromium: 74.0.3723.0)
node version v12.4.0

@adea11 deleteCookies() clears all browser cookies as of taiko version 0.8.0. Please update Taiko to make use of this functionality.


Run clang-format on all source code and follow that code style since then

Came up during the team meeting today

also need something in travis to avoid breaking with new changes.


Disabled the MDR_* environment variables

These variables are used to define the content of the GUI.
Due to the way that the scripts have been written for Docker, the
env.json file is completely overwritten, so that the things you
define there are ignored, even if you don't define any of the
MDR_* variables.
By commenting out the offending lines, I have re-enabled the
env.json file, but the MDR_* environment variables no longer
have an effect. This allows Thomas' changes to work.
And defining the GUI in the docker-compose.yml file seems rather
ugly.

Thomas is now getting on just fine without these changes


Size: null, Ntime: null, Permissions: null

I've gone through all steps and settings, and cannot seem to push a file to the Squarespace server.
Directory info is being read apparently (last update via Espresso2). Hrmm
I'm really loving this package so far, but making it work is obviously important. HAHA
Guess I'll try "sftp deployment" again for a day.

Have you opened the file from the server? It's not possible to create new files on the server using this plugin.

No, I didn't, but in the previous hours I was also trying to get "sftp deployment" to work. Maybe 'empty' folders were created and sent-up? Seems so weird.

Have you done anything else with this? I don't really understand why you're having problems.

Thanks for your patience @sveale. I'm going to give it another go with Atom 1.0 now and I'll report-back.

@sveale same exact issue. New Project and new path on server.
— When going to PACKAGES menu / REMOTE EDIT / BROWSE HOSTS - cannot view files; all I get is this error.

So the issue is that you cannot view files that are located on the existing server? What if you try to choose one of the directories in the above screenshot?


How user can extend placement scheduling.

Subtask of https://github.com/open-cluster-management-io/OCM/issues/33

/assign @haoqing0110

close as PR merged


Need Concept for Title Screen

We need a concept for the title screen eg:
Do we want all characters? Even if we haven't completed characters can we block em out?
Maybe we can determine a background setting so the logo and background can get piexelated to be ready for when characters are ready.

For the title screen I was thinking how the original games had it. Just the main character and a setting, which would be the main hub/world. I'll whip up some concept art for it.


Add support for passing URL instance to unleash client constructor

Gives consumer greater control over format of url whilst still ensuring that it is valid.
Makes it possible to use relative urls (as requested in #59) when initialising client.

would be great to get this feature


Update default threading behavior

If a message was sent in a thread, answer in a thread per default.

Hey! Looks good, how about adding a test for this? That would help merging it faster. Thanks!

Hey @jsargiot, thanks for the response. I won't make it to create a custom testing instance of Slack nor configure Travis. It would be way easier for me (and everybody else who wants to contribute), if you could setup your Travis to run all the tests. If you are concerned about user that are not that familiar with git and that add several commits to fix test errors, you could automatically squash all commits of a PR.

Have you read https://docs.travis-ci.com/user/pull-requests/?


Handling of nil values

The current code base needs more testing, because the up until now, I have chose only happy paths.
For instance:
Given this terraform file which defines only a minimal basic pool:
terraform {
  required_providers {
    leostream = {
      source = "registry.terraform.io/hocmodo/leostream"

    }
  }
}

// This block configures the Leostream provider.
provider "leostream" {
  host     = "https://<broker url>"
  username = "someapiuser"
  password = "somepassword"
}

resource "leostream_basic_pool" "pool1" {
    name = "Test a basic pool"
    pool_definition = {
        restrict_by = "A"
    }
}

Above will fail with:
% terraform apply --autoapprove
......
Plan: 1 to add, 0 to change, 0 to destroy.
leostream_basic_pool.pool1: Creating...
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ApplyResourceChange call. The plugin logs may contain more details.
╵

Stack trace from the terraform-provider-leostream_v0.1.0 plugin:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x104613a3c]

goroutine 56 [running]:
terraform-provider-leostream/leostream.(*basicPoolResource).Create(0xd?, {0x104b3eff8, 0x14000526cf0}, {{{{0x104b43328, 0x14000546690}, {0x104a3a820, 0x14000546030}}, {0x104b451a0, 0x140000999f0}}, {{{0x104b43328, ...}, ...}, ...}, ...}, ...)
	terraform-provider-leostream/leostream/pool_resource_basic.go:386 +0x1dc
github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).CreateResource(0x140001f81e0, {0x104b3eff8, 0x14000526cf0}, 0x140004d9560, 0x140004d9500)
	github.com/hashicorp/terraform-plugin-framework@v1.9.0/internal/fwserver/server_createresource.go:101 +0x41c
github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).ApplyResourceChange(0x140004d96c0?, {0x104b3eff8, 0x14000526cf0}, 0x14000528410, 0x140004d96c0)
	github.com/hashicorp/terraform-plugin-framework@v1.9.0/internal/fwserver/server_applyresourcechange.go:57 +0x380
github.com/hashicorp/terraform-plugin-framework/internal/proto6server.(*Server).ApplyResourceChange(0x140001f81e0, {0x104b3eff8?, 0x14000526bd0?}, 0x14000528370)
	github.com/hashicorp/terraform-plugin-framework@v1.9.0/internal/proto6server/server_applyresourcechange.go:55 +0x314
github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ApplyResourceChange(0x140001ce640, {0x104b3eff8?, 0x140005261e0?}, 0x1400031a0e0)
	github.com/hashicorp/terraform-plugin-go@v0.23.0/tfprotov6/tf6server/server.go:865 +0x2b0
github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ApplyResourceChange_Handler({0x104b11fc0?, 0x140001ce640}, {0x104b3eff8, 0x140005261e0}, 0x14000112000, 0x0)
	github.com/hashicorp/terraform-plugin-go@v0.23.0/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:518 +0x164
google.golang.org/grpc.(*Server).processUnaryRPC(0x1400018ce00, {0x104b3eff8, 0x14000526150}, {0x104b43e78, 0x14000178000}, 0x1400052a000, 0x140002ef980, 0x104ff69b8, 0x0)
	google.golang.org/grpc@v1.64.0/server.go:1379 +0xba0
google.golang.org/grpc.(*Server).handleStream(0x1400018ce00, {0x104b43e78, 0x14000178000}, 0x1400052a000)
	google.golang.org/grpc@v1.64.0/server.go:1790 +0xc78
google.golang.org/grpc.(*Server).serveStreams.func2.1()
	google.golang.org/grpc@v1.64.0/server.go:1029 +0x8c
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 20
	google.golang.org/grpc@v1.64.0/server.go:1040 +0x150

Error: The terraform-provider-leostream_v0.1.0 plugin crashed!

This is caused by me not thinking of the fact that building up nested resources without actively checking for nil values will cause these hideous crashes.
I will start a new branch to work on this and try to eliminate this throughout the code.

Branch #2 opened


Getting grpc error when running in docker toolbox on windows

Description
After I initially extract AMP and attempt to run it in Docker Toolbox on Windows 7 (64bit) I'm getting a grpc error when it attempts to get the server version of AMP
Steps to reproduce the issue:

Download AMP from here: https://get.atomiq.io/builds/Windows/x86_64/amp-v0.11.0.zip
Attempt to run the command:
./amp --server localhost version
grpc error is noted (see error below)
Run the command:
amp -s localhost cluster create

Get the output:
Cluster status: healthy
zb3v6ovm8u0y4uslni0af14sb

Attempt to run the command:
./amp --server localhost version
Error below noted again

Results you received:
dmckenna@ITEM-AX43897 MINGW64 ~/workspace
$ ./amp --server localhost version
[localhost:50101]
grpc: addrConn.resetTransport failed to create client transport: [connection err
or: desc = "transport: dial tcp [::1]:50101: operation was canceled" {localhost:
50101 <nil>}]; Reconnecting to %!v(MISSING)
Client:
 Version:       v0.11.0
 Build:         f7e0520e
 Server:        localhost:50101
 Go version:    go1.8.1
 OS/Arch:       windows/amd64

Server:         not connected

Seems related to #968

I also get this on Mac:
Moxie-3:Downloads ingo$ amp version -s localhost
[localhost:50101]
Client:
Version:       v0.11.0
Build:         f7e0520e
Server:        localhost:50101
Go version:    go1.8.1
OS/Arch:       darwin/amd64
Server:
Version:       v0.11.0
Build:         f7e0520e
Go version:    go1.8.1
OS/Arch:       linux/amd64
Moxie-3:Downloads ingo$ amp version
[cloud.appcelerator.io:50101]
grpc: addrConn.resetTransport failed to create client transport: [connection error: desc = "transport: dial tcp <IP_ADDRESS>:50101: operation was canceled" {cloud.appcelerator.io:50101 }]; Reconnecting to %!v(MISSING)Client:
Version:       v0.11.0
Build:         f7e0520e
Server:        cloud.appcelerator.io:50101
Go version:    go1.8.1
OS/Arch:       darwin/amd64

Running into the same issue on Windows 10 anniversary update x64.
AMP v0,11.0 and v0.12.0-dev
This error shows when doing
amp --server localhost version
but not
amp --server localhost -v
It also shows when creating a user

It alternates:
Moxie-3:Downloads ingo$ amp version
[cloud.appcelerator.io:50101]
grpc: addrConn.resetTransport failed to create client transport: [connection error: desc = "transport: dial tcp <IP_ADDRESS>:50101: operation was canceled" {cloud.appcelerator.io:50101 }]; Reconnecting to %!v(MISSING)Client:
Version:       v0.11.0
Build:         f7e0520e
Server:        cloud.appcelerator.io:50101
Go version:    go1.8.1
OS/Arch:       darwin/amd64
Server:         not connected
Moxie-3:Downloads ingo$ amp version
[cloud.appcelerator.io:50101]
Client:
Version:       v0.11.0
Build:         f7e0520e
Server:        cloud.appcelerator.io:50101
Go version:    go1.8.1
OS/Arch:       darwin/amd64
Server:
Version:       v0.12.0-dev
Build:         036c673c
Go version:    go1.8.1
OS/Arch:       linux/amd64
Moxie-3:Downloads ingo$ amp version
[cloud.appcelerator.io:50101]
Error: grpc: Decompressor is not installed for grpc-encoding "gzip"

do you experience this issue after 15 min of inactivity, or is it as soon as it is deployed? We've fixed recently an issue related to the VIP timeout, that my be related.

I get it after I deploy the cluster. Deploy of cluster concludes with message:
dmckenna@ITEM-AX43897 MINGW64 ~/workspace
$ ./amp -s localhost cluster create
[localhost:50101]
wait for cluster
ok
cluster size is 1
deploy amp monitoring stack to cluster - stage 1
deploy ampmon.1.stack.yml => amp
Creating service amp_elasticsearch
Creating service amp_nats
Creating service amp_etcd
ok
wait for all amp monitoring stage 1 stack service replicas to be running
ok
deploy amp monitoring stack to cluster - stage 2
deploy ampmon.2.stack.yml => amp
Creating service amp_ampbeat
Creating service amp_kibana
ok
wait for all amp monitoring stage 2 service replicas to be running (540 sec)
ok
deploy portal stack to cluster
deploy portal.stack.yml => amp
Creating service amp_portal
ok
wait for all portal service replicas to be running (540 sec)
ok
deploy amp stack to cluster
deploy amp.stack.yml => amp
Creating service amp_amplifier
Creating service amp_amplifier-gateway
Creating service amp_agent
ok
wait for all amp service replicas to be running (540 sec)
ok
deploy amp proxy stack to cluster
deploy ampproxy.stack.yml => amp
Creating service amp_proxy
ok
wait for all amp proxy service replicas to be running (540 sec)
ok

Cluster status: healthy
f573e897-7aa0-4516-a195-42ee91039e97

@davidrmckenna @ingo @alasdairhurst  apologies for the delayed response.
We don't plan to support Docker Toolbox for Windows for the GA release. You need Docker for Windows instead.
However, we did a bit of investigation with Docker Toolbox for Windows. There are a few adaptations to be made around accessing the deployed stacks, which we have not planned for the GA. Here is what we found:
With the Toolbox, Docker runs inside a VM and not on your machine itself, which is why you got the grpc error on passing localhost as the server address.
The workaround for this is to use the IP of the Docker Machine running on the VM. You can do this by launching Docker Quickstart Terminal and running :
$ echo $DOCKER_HOST
Use the IP returned instead of localhost for the commands.

@neha-viswanathan  While @davidrmckenna is running docker toolbox, I was running Docker for windows (Docker for windows doesn't work on win 7, and docker toolbox doesn't work on win 10)
As you can see, I was getting identical grpc issues.

@alasdairhurst I am unable to reproduce the grpc issue that you are facing with Windows 10. It would be helpful to further investigate if you can open another issue describing the steps to reproduce it.

@neha-viswanathan  created #1479

Closing the issue since we do not support Docker Toolbox on any OS.


File explorer opens file under cursor on [Esc] key.

VSCode Version: Code 1.11.1 (d9484d12b38879b7f4cdd1150efeb2fd2c1fbf39, 2017-04-06T13:58:12.954Z)
OS Version: Windows_NT ia32 6.1.7601

Steps to Reproduce:

Switch to File Explorer
Move cursor to another file
Hit [Esc]

Expected behavior:

return to editing current file

Current behavior:

open file under cursor

@LexRiver what do you do exactly, can you share a video?

Is it just me?

hit Ctrl+Shift+E to activate explorer
hit Down to select next file
hit Enter to open file
hit Ctrl+Shift+E to activate explorer again
hit Up to select first file again
hit Esc <- this opens first file again, instead of focus on editor

If this is just me, then sorry.

I can reproduce and fix.

-- Sorry for the English, I used Google Translator --
@bpasero Now when you click Esc the focus is not going back to the file you were editing, but getting a blue border, time in "Open Editors" time in the whole project.
Can you reproduce?
The change that only affects where all the files are or also for "Open Editors"?

@Tekbr there was no change for "Open Editors", only the "Files Explorer" below.

@bpasero
My steps:
1- I typed the text
2 - Press Ctrl + Shift + E
3- I navigated through the file with the up and down arrows
4- I pressed Esc.
5- Focus still continued in the archives
6- I pressed Esc.
7- Focus continued in File Explorer
Was not the idea to return the focus of the cursor to editing the file? 🤔

No, that was not the idea.

I was expecting to continue editing the opened file also -)

-- Sorry for the English, I used Google Translator --
@bpasero In my view the idea was always this.

Expected behavior:

return to editing current file

It may be a lack of interpretation or even wrong understanding.
Notice that @LexRiver  himself said again that the idea was to go back to the edited file.

I was expecting to continue editing the opened file also -)

For me it got worse than before. I vote for reopening the issue, and check if it's possible to do this by going back to the file. I do not know if @LexRiver  agrees.

How about assigning a keybinding that ESC puts focus to the editor when pressed while the explorer has focus?
Otherwise I do not understand the request to reopen this bug that was fixed, sorry.

-- Sorry for the English, I used Google Translator --

Otherwise I do not understand the request to reopen this bug that was fixed, sorry.

@bpasero Corrected in parts, because that was not what was asked for. Sorry for the sincerity. 😉
Before I used it in a different way, a "jerry-rig" (I think that's the English term, if not sorry), but that worked more or less. And that stopped after the update. I looked for the case and found this one. But that is beside the point.

How about assigning a keybinding that ESC puts focus to the editor when pressed while the explorer has focus?

I do not understand much, but I guess that's what I mean?
The idea is to work as in Atom.
1- Type a text
2 - Press Alt +  \
3- Navigate between files and with up and down arrow
4- Press Esc.
5 - See that it returns to the editor
6 - See that the focus (this white color where I stopped stays there)
7- Re-press Alt +  \
8- The same back where you left the cursor.

For VSCode my idea is (see if @LexRiver  agrees):
1- Type a text
2 - Press Ctrl + Shift + E
3- Navigate between files and with up and down arrow
4- Press Esc.
5- Back to the Editor
6- Keep focus (This gray color in the file I'm editing)
7- Press Ctrl + Shift + E again
8- The same lap where you leave the cursor (with this light blue color) and the file that is open (with the darker blue color). That already happens. But it is interesting to keep.

@bpasero Tell me if I need to open a new issue for this situation.
This step is now something I hate about VSCode (especially now after it's changed), and if it can be fixed (or if it's a config), it has a bit of a bearing on that case. (I do not know if you'll understand, sorry for English again)
1- Type a text
2 - Press Ctrl + Shift + E
3- Navigate between files and with up and down arrow
4- Press Esc.
5- The Focus is still in the archive tree.
6- Press Esc again
7- The Focus is in the rectangle that is the file tree.
8- Click the editor or press Ctrl + Shift + E again
9- Press again Ctrl + Shift + E
10- Focus goes to Open Editors

This is very boring!!
Maybe Ctrl + 0 (not numeric) will focus on Open Editors and Ctrl + Shift + E in the file tree.
As I said in another case, I know that Ctrl + 0 may not be his job, but for that I think it works well. If you have a better idea, tell me.

-- Sorry for the English, I used Google Translator --
@bpasero Sorry for the delay in responding !!
Yes, your tip worked for Esc. (Should have come by default). It's possible?
But I do not understand why the focus (blue bar in the files tree).
Do these steps (using only the keybindings that you mentioned above):
1- Have a project with two or more files open.
2- Click the blank area in the file tree.
3- The focus is on the whole area.
4- Press Esc.
5. Press Ctrl + Shift + E .
6- Focus goes to Open Editors.
Another situation:
1- Have a project with two or more files open.
2- Close the folder.
3- Open the project again.
4 - Press Ctrl + Shift + E.
5- Focus goes to Open Editors.
I searched and found "Focus on Open Editors" Ctrl + <kbd k E. That is, it does not make sense to me when I hit Ctrl + Shift + E in the above situations it points to Open Editors.
If you were confused or did not understand something, let me know. Or make a gif if you prefer. Sorry for using Google Translate.

The blue focus in the tree is for accessibility reasons, you can start to arrow up or down in this mode to start selecting entries from the tree.

-- Sorry for the English, I used Google Translator --
@bpasero Question 1: But did you do the steps I spoke up? Should this really happen?

you can start to arrow up or down in this mode to start selecting entries from the tree.

Question 2: Yes, but I can not access the main folder with the up and down arrow. If I want to create a new folder or a new file, using the 'Menu' key, right?  Or am I doing something wrong?

Agree, in your case focus should go back to the explorer even though it has no focused item.

-- Sorry for the English, I used Google Translator --

@bpasero The intention if your answer was not clear to me. Is it a problem or do I have to make a request? I believe your answer is about my first question.

About my second question would it also be a resource request? Did you get the point?

If what I have written is confusing, please let me know that I will try to write in another way. 😉

@Tekbr let's tackle individual issues in individual bug reports, makes it easier to track. Feel free to open new issues as you see fit.


Duplicate selected values after multiple re-setting choices

Hi, thank you for the cool widget!
found a bug:
setChoices with replaceChoices = true and preselected choice in the data leads to nonsense duplicated value:
<select multiple></select>

const element = document.querySelector('select');
const choices = new Choices(element);

choices.setChoices([
  {label:'Choice 1', value:'1'},
  {label:'Choice 2', value:'2', selected:true},
  {label:'Choice 3', value:'3'},
], undefined, undefined, true);

choices.setChoices([
  {label:'Choice 1', value:'1'},
  {label:'Choice 2', value:'2', selected:true},
  {label:'Choice 3', value:'3'},
], undefined, undefined, true);

demo

Hey - looks like the selected choice isn't being cleared. Thanks for raising

Yes, as a workaround i load data without selected attr and set selected items via API separately.

When this issue will be fixed? It's quite an important bug

Is this issue been resolved?


Cannot activate add-on v.1.02 in Blender 4.0.2

After installing the v.1.0.2 Add-on in Blender 4.0.2, I cannot activate it in Blender because it gives me the following error:
  File "/home/algo/software/blender-4.0.2-linux-x64/4.0/scripts/modules/addon_utils.py", line 364, in enable
    mod = importlib.import_module(module_name)
  File "/home/algo/software/blender-4.0.2-linux-x64/4.0/python/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1004, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'MedBlend-1'

I think that means that the zip file containing the add-on is not called "MedBlend". It is probably called "MedBlend-1.zip". Renaming the zip file and reinstalling the addon should fix it

Ok. I could go further by unzipping  the add-on, renaming the root directory to MedBlend, then zipping it back before installing it in Blender using the normal process. However, when I try to activate it, an error occurs saying Blender cannot fin the pydicom module.
Traceback (most recent call last):
  File "/home/algo/software/blender-4.0.2-linux-x64/4.0/scripts/modules/addon_utils.py", line 364, in enable
    mod = importlib.import_module(module_name)
  File "/home/algo/software/blender-4.0.2-linux-x64/4.0/python/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/home/algo/.config/blender/4.0/scripts/addons/MedBlend/__init__.py", line 54, in <module>
    from .dicom_util import (
  File "/home/algo/.config/blender/4.0/scripts/addons/MedBlend/dicom_util.py", line 4, in <module>
    import pydicom
ModuleNotFoundError: No module named 'pydicom'

So it seems the dependency installation script doesn't do its job. My OS is Ubuntu 23.10.

I got the same issue. No module named 'pydicom'.
= Blender 4.0.2 System Information =
Blender:
version: 4.0.2, branch: blender-v4.0-release, commit date: 2023-12-05 07:41, hash: 9be62e85b727, type: release
build date: 2023-12-05, 13:01:12
platform: 'Windows-10-10.0.22631-SP0'

After installing 'pydicom' manually and pressing the 'Install Dependencies' button Blender just tilts and turns grey.

MedBlend also needs these modules to run properly:
numpy==1.23.5
pydicom==2.3.1
platipy==0.7.1
SimpleITK==2.3.1

If you are getting pydicom "not found" error when activating this addon, use this solution that worked for me:

Locate to your Blender installation directory (in my case, this is D:\Software\Blender Foundation\Blender 4.1\)
In this directory, find an embedded Python interpreter. In my case, this is located at <blender dir>\4.1\python\bin.
When you found a directory with Blender's internal Python interpreter, open command line in this directory. In command line, print python.exe and press Enter. The Blender's Python interpreter will be launched.
Print import pip and press Enter.
Print pip.main(['install', 'pydicom', '--user']) and press Enter. Wait for installation.
When installed, print exit() and press Enter again. Close command line.
Restart Blender and try to activate addon again.

When successfully activated, locate to Medical tab and press Install dependencies to download all remaining dependencies. Be sure that your Blender will freeze while installing dependencies - to show installation progress, toggle Blender's system console before running installation.


README.md recommends an insecure default configuration

Now that OAuth clients are supported, I think the recommended configuration in the README.md should show an OAuth configuration rather than an API key based one.
I also think it should suggest that you should configure an OAuth client with acl:read scope when running tests, and a second one with acl for applying updates. This prevents an escalation path where the ACLs can be updated from an arbitrary branch by updating the workflow, i.e.
name: Sync Tailscale ACLs

on:
  push:
    branches: [ "main" ]
  pull_request:
    branches: [ "main" ]

jobs:
  acls:
    runs-on: ubuntu-latest

    steps:
      ...
      - name: Deploy ACL
        # By commenting out this `if`, the ACLs get applied when the workflow runs on the PR trigger.
        # if: github.event_name == 'push'
        id: deploy-acl
        uses: tailscale/gitops-acl-action@v1
        with:
          api-key: ${{ secrets.TS_API_KEY }}
          tailnet: ${{ secrets.TS_TAILNET }}
          action: apply
      ...

For reference, this is the workflow we're using, and how we have the secrets configured.

name: Sync Tailscale ACLs

on:
  push:
    branches: [ "main" ]
  pull_request:
    branches: [ "main" ]

jobs:
  apply-acls:
    if: github.event_name == 'push'
    environment: production
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v3

      - name: Fetch version-cache.json
        uses: actions/cache@v3
        with:
          path: ./version-cache.json
          key: version-cache.json-${{ github.run_id }}
          restore-keys: |
            version-cache.json-
      - name: Deploy ACLs
        id: deploy-acls
        # Tailscale has released OAuth support for their action, but haven't cut a new release yet
        uses: tailscale/gitops-acl-action@287fb935799def5f8a2aef4df9b1286f78fc384b
        with:
          oauth-client-id: ${{ secrets.TS_OAUTH_CLIENT_ID }}
          oauth-secret: ${{ secrets.TS_OAUTH_SECRET }}
          tailnet: ${{ secrets.TS_TAILNET }}
          action: apply

  test-acls:
    if: github.event_name == 'pull_request'
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v3

      - name: Fetch version-cache.json
        uses: actions/cache@v3
        with:
          path: ./version-cache.json
          key: version-cache.json-${{ github.run_id }}
          restore-keys: |
            version-cache.json-
      - name: Test ACLs
        id: test-acls
        # Tailscale has released OAuth support for their action, but haven't cut a new release yet
        uses: tailscale/gitops-acl-action@287fb935799def5f8a2aef4df9b1286f78fc384b
        with:
          oauth-client-id: ${{ secrets.TS_OAUTH_CLIENT_ID }}
          oauth-secret: ${{ secrets.TS_OAUTH_SECRET }}
          tailnet: ${{ secrets.TS_TAILNET }}
          action: test

I'm not sure I follow your solution to privilege escalation in PRs.
What is to stop me from making any number of other changes to the yaml in a PR that results in them being applied before merging to main?
I think the solution is to just not allow anyone untrusted to make PRs in the repository in the first place.

@rowanmoul yes you can limit access to an environment based on a branch:

screenshot

Typically over in the repo settings under Environments > select your environment and you will be able to limit the environment to a branch or branches/tags/etc.
https://github.com/{user_or_org}/home/settings/environments/{environment_id}/edit


Discussion: How to start incorporating Frictionless Data standards in the file/database upload?

@K-Beicher has already started looking into this last year. This data structure standard isn't super common outside of research, and also not super common within, but it is one of the most popular and established standards available. So it would be good for us to follow some standard rather than wrestling with our own/doing something in conflict with others.

Continued in #485


Compile error about ambiguous ViewStore when reducer uses BindingState/BindableAction

Description
When a reducer contains BindingState/BindableAction but a SwiftUI view doesn't use this, the compiler complains about ambiguous init. (The use case for this may be that this SwiftUI view doesn't need the binding, but a child view does.)
I've written a test that shows this here:
https://github.com/johankool/swift-composable-architecture/tree/ambiguous_viewstore
Checklist

[ ] I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
[ ] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior
It compiles just fine.
Actual behavior
Ambiguous use of 'init(_:observe:content:file:line:)'
Steps to reproduce
 struct BindableReducer: Reducer {
      struct State: Equatable {
        @BindingState var something: Int
      }

      enum Action: BindableAction {
        case binding(BindingAction<State>)
      }

      var body: some Reducer<State, Action> {
        BindingReducer()
      }
    }

    struct SomeView: View {
      let store: StoreOf<BindableReducer>

      struct ViewState: Equatable {

      }

      var body: some View {
        WithViewStore(store, observe: { _ in ViewState() }) { viewstore in // Ambiguous use of 'init(_:observe:content:file:line:)'
          EmptyView()
        }
      }
    }

The Composable Architecture version information
a4d371e8adc9d081d616f988fb0f089b479e9553 (current prerelease/1.0 branch)
Destination operating system
iOS 16.4
Xcode version information
Version 14.3.1 (14E300c)
Swift Compiler version information
> xcrun swiftc --version
swift-driver version: 1.82.2 Apple Swift version 5.9 (swiftlang-<IP_ADDRESS>.10 clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx13.0

Thanks! I've cherry picked your test in and PR'd a fix: #2278.


rand: use a MatchCallByPackage helper

Updated the rand rule to use the helper added by https://github.com/GoASTScanner/gas/pull/67
Also changed MatchCallByObject to MatchCallByPackage since it only matches functions on a package, not objects.

Hmm not sure why this fails on 1.5 but passes on tip. Think it's probably an incompatibility issue with my helper function. I'll try to figure out what's happening here.

@tam7t Checkout this change 7a275fd0a. When I did some experimentation here it seems as though there is a big difference between 1.5.x and 1.7.x as far as the information in types.Object's. I've put together this slightly less optimal change to work around this and maintain support for the older 1.5.x release.


Add Newsela to list of companies using Luigi

We use Luigi at Newsela for ETL stuff, and we like it!

We usually prefer links to slidedecks, presentations or blogposts. Do you have anything like that to link to instead of just to your website?

@Tarrasch not right now. We'd still like to be included on the list though, but it's up to you.

Hey @rayrrr, we've revamped how we record companies which use Luigi. We can accept your company into the list. Just resolve the conflict here and add your company to the list without extra luigi-related media. Thanks!

I'm not sure why this commit shows +6 instead of +1. But whatever. I'll merge after build turns green. Thanks

My mistake while resolving merge conflicts. It's +1 now. Build should pass :crossed_fingers: thanks!

At this point the build failure appears to be systemic:
Warning, treated as error:
README.rst:117: WARNING: Duplicate explicit target name: "spotify".
ERROR: InvocationError: '/home/travis/build/spotify/luigi/.tox/docs/bin/sphinx-build -W -b html -d /home/travis/build/spotify/luigi/.tox/docs/tmp/doctrees doc doc/_build/html'
___________________________________ summary ____________________________________
ERROR:   docs: commands failed
The command "./scripts/ci/conditional_tox.sh" exited with 1.

@rayrrr I keep seeing that error on multiple builds. Nothing you did.
I'm going to merge anyway as error is unrelated.

@Tarrasch something needs to be done about this build error. Also, the purpose of having these tests run is that they should be fast. However, the two -cdh builds alone take well over 30 minutes each to complete. What do they even test?


Analyze performance impact of TagHelperContent not being lazy on TagHelperOutput properties.

The initial implementations of the "new" TagHelperOutput data structure (one with buffers instead of strings) was originally lazy with the buffers construction but was then removed due to the added complexity via code review. We should analyze its perf impact to determine if being lazy about construction of PreElement, PreContent, Content, PostContent and PostElement's TagHelperContent objects is beneficiary.

Please see https://github.com/aspnet/Razor/issues/317 for additional info.

Please have a chat with @rynowak before starting the perf investigation.

beneficiary

Yes. Let's discuss

Hah!

Let's discuss

This is definitely worth addressing

Upon investigating a proper fix for this issue I decided to investigate what it'd take to have TagHelperOutput be an IHtmlContent (since it's responsible for lazily initializing buffers). After a lot of playing around with the idea and talks with @DamianEdwards it definitely fits.
This will also involve removing the WriteTagHelperAsync method from Mvc.

bdf869c3d586e1ac4b94882aa91a719058ec9aa3
e8327eeec76afcb4156e95763e580df3693f4d8e
6b43ebc88b4645ab62e0f0f87a687d477f7f7c39
https://github.com/aspnet/Mvc/commit/2dc13b523d9b346fc99f998902f8d69a44222948


Possible inconsistency between implementation and examples

Is there an inconsistency between
https://github.com/xamarin/TorchSharp/blob/93a03123c7cf6657d479e89bb55902ae9db17794/src/Examples/MNIST.cs#L128
and
https://github.com/xamarin/TorchSharp/blob/93a03123c7cf6657d479e89bb55902ae9db17794/src/TorchSharp/NN/Module.cs#L77 ?
The constructor of Module takes three arguments and base(name) gives just one. VisualStudio complains that torch.nn.Module has no constructor with one argument.

You will need the newest set of changes, which have not been released to NuGet yet. To use the latest examples, you have to build TorchSharp yourself. The protected constructor that is meant for custom modules is located on line 527 in the current master branch.


Fix code scanning alert - Uncontrolled data used in path expression

Tracking issue for:

[ ] https://github.com/wu4f/secure-code-game/security/code-scanning/7

fixed


[Suggestion] Config options

Add more config options for turning off or on different modifiers and edit their weights?

check out the readme for how to create a datapack.