Add TXN_CLOSE hook to CPPAPI TransactionPlugin

Email to dev@
We recently ran into a core dump issue due to one of our TransactionPlugin's continuations being called back with TXN_CLOSE event.

The current CPPAPI's TransactionPlugin does not expect a call back on TXN_CLOSE, and asserts on it. This is because the expectation seems to be that all the continuations for TransactionPlugins attached to the Transaction are destroyed in the global TXN_CLOSE hook. However, this only works based on the plugin table in the Transaction object, which gets populated based on `Transaction::addPlugin()`. Turns out, some of our plugins do not call `Transaction::addPlugin()` and just create a `TransactionPlugin()` and register hooks to it resulting in them getting called back for TXN_CLOSE event as well.

Long story short, it didn't particularly seem unreasonable to add support to TXN_CLOSE event in TransactionPlugin, since the current API does not seem to mandate calling `Transaction.addPlugin()`.

https://github.com/apache/trafficserver/pull/6800

Please let me know if there are any concerns/comments.

Here's the stack trace
#0  0x00002aabdd0cc1d7 in raise () from /lib64/libc.so.6
#1  0x00002aabdd0cda08 in abort () from /lib64/libc.so.6
#2  0x00002aabdd0c5146 in __assert_fail_base () from /lib64/libc.so.6
#3  0x00002aabdd0c51f2 in __assert_fail () from /lib64/libc.so.6
#4  0x00002aabfb6223cf in invokePluginForEvent (event=468845984, ats_txn_handle=0x2aac6e63a070, plugin=0x2aac92d6d4e0) at utils_internal.cc:148
#5  atscppapi::utils::internal::invokePluginForEvent (plugin=plugin@entry=0x2aac92d6d4e0, ats_txn_handle=ats_txn_handle@entry=0x2aac6e63a070, event=event@entry=TS_EVENT_HTTP_TXN_CLOSE) at utils_internal.cc:222
#6  0x00002aabfb624310 in (anonymous namespace)::handleTransactionPluginEvents (cont=0x2aad52c4ce00, event=TS_EVENT_HTTP_TXN_CLOSE, edata=0x2aac6e63a070) at TransactionPlugin.cc:57
#7  0x00000000004c4833 in INKContInternal::handle_event (this=0x2aad52c4ce00, event=60012, edata=0x2aac6e63a070) at InkAPI.cc:1012
#8  0x00000000005b5b1f in HttpSM::state_api_callout (this=this@entry=0x2aac6e63a070, event=event@entry=60000, data=data@entry=0x0) at HttpSM.cc:1638
#9  0x00000000005bca82 in HttpSM::state_api_callback (this=this@entry=0x2aac6e63a070, event=event@entry=60000, data=data@entry=0x0) at HttpSM.cc:1507
#10 0x00000000004d9a69 in TSHttpTxnReenable (txnp=0x2aac6e63a070, event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5714
#11 0x00002aabfbea9e41 in AtsPluginUtils::creqCleanup (cont=0x2aabfb2fc3a0, event=TS_EVENT_HTTP_TXN_CLOSE, edata=0x2aac6e63a070) at ClientRequest.cc:76
#12 0x00000000004c4833 in INKContInternal::handle_event (this=0x2aabfb2fc3a0, event=60012, edata=0x2aac6e63a070) at InkAPI.cc:1012
#13 0x00000000005b5b1f in HttpSM::state_api_callout (this=this@entry=0x2aac6e63a070, event=event@entry=60000, data=data@entry=0x0) at HttpSM.cc:1638
#14 0x00000000005bca82 in HttpSM::state_api_callback (this=this@entry=0x2aac6e63a070, event=event@entry=60000, data=data@entry=0x0) at HttpSM.cc:1507
#15 0x00000000004d9a69 in TSHttpTxnReenable (txnp=0x2aac6e63a070, event=TS_EVENT_HTTP_CONTINUE) at InkAPI.cc:5714
#16 0x00002aabfb621e25 in (anonymous namespace)::handleTransactionEvents (cont=<optimized out>, event=<optimized out>, edata=0x2aac6e63a070) at utils_internal.cc:95
#17 0x00000000004c4833 in INKContInternal::handle_event (this=0x2aabfb2fcf40, event=60012, edata=0x2aac6e63a070) at InkAPI.cc:1012
#18 0x00000000005b5b1f in HttpSM::state_api_callout (this=0x2aac6e63a070, event=<optimized out>, data=<optimized out>) at HttpSM.cc:1638
#19 0x00000000005bbeba in HttpSM::kill_this (this=this@entry=0x2aac6e63a070) at HttpSM.cc:7039
#20 0x00000000005bcd80 in HttpSM::main_handler (this=0x2aac6e63a070, event=2301, data=0x2aac6e63b400) at HttpSM.cc:2958
#21 0x00000000005fee8d in handleEvent (data=0x2aac6e63b400, event=2301, this=<optimized out>) at ../../iocore/eventsystem/I_Continuation.h:153
#22 HttpTunnel::main_handler (this=0x2aac6e63b400, event=<optimized out>, data=<optimized out>) at HttpTunnel.cc:1642
#23 0x000000000076da7e in handleEvent (data=0x2aac0aed7e98, event=103, this=<optimized out>) at ../../iocore/eventsystem/I_Continuation.h:153
#24 write_signal_and_update (vc=0x2aac0aed7d00, event=103) at UnixNetVConnection.cc:179
#25 write_signal_done (vc=0x2aac0aed7d00, nh=0x2aabe160be00, event=103) at UnixNetVConnection.cc:224
#26 write_to_net_io (nh=nh@entry=0x2aabe160be00, vc=0x2aac0aed7d00, thread=<optimized out>) at UnixNetVConnection.cc:564
#27 0x000000000076ddd8 in write_to_net (nh=nh@entry=0x2aabe160be00, vc=vc@entry=0x2aac0aed7d00, thread=<optimized out>) at UnixNetVConnection.cc:421
#28 0x000000000075dba4 in NetHandler::mainNetEvent (this=0x2aabe160be00, event=<optimized out>, e=<optimized out>) at UnixNet.cc:530
#29 0x000000000078f3ef in handleEvent (data=0x2aabdf7fd8c0, event=5, this=<optimized out>) at I_Continuation.h:153
#30 process_event (calling_code=5, e=0x2aabdf7fd8c0, this=0x2aabe1608000) at UnixEThread.cc:152
#31 EThread::execute (this=0x2aabe1608000) at UnixEThread.cc:279
#32 0x000000000078dffa in spawn_thread_internal (a=0x2aabde99d6d0) at Thread.cc:86
#33 0x00002aabdc0f4dc5 in start_thread () from /lib64/libpthread.so.0
#34 0x00002aabdd18e76d in clone () from /lib64/libc.so.6

In the state dump, in frame #4, it seems to be showing the parameters in the reverse order from what they are declared in the function:  https://github.com/apache/trafficserver/blob/bf097d4289a3eaa3759a58fb19e48381b89ce32f/src/tscpp/api/utils_internal.cc#L113
The event parameter is not TS_EVENT_HTTP_TXN_CLOSE (60012).
When the TXN_CLOSE hook is triggered, the CPPAPI destroys the instance of your custom class that is derived from TransactionPlugin.  So you are supposed to put anything you want to run on that hook in the destructor of that class.  Because continuations on hooks run in arbitrary order, I think your change could cause a use after free.

In the state dump, in frame #4, it seems to be showing the parameters in the reverse order from what they are declared in the function:
https://github.com/apache/trafficserver/blob/bf097d4289a3eaa3759a58fb19e48381b89ce32f/src/tscpp/api/utils_internal.cc#L113
The event parameter is not TS_EVENT_HTTP_TXN_CLOSE (60012).
When the TXN_CLOSE hook is triggered, the CPPAPI destroys the instance of your custom class that is derived from TransactionPlugin. So you are supposed to put anything you want to run on that hook in the destructor of that class. Because continuations on hooks run in arbitrary order, I think your change could cause a use after free.

The problem is that cppapi does not have the handle for my custom class in the TransactionPlugin table, because my plugin never called addPlugin() on it. So, cppapi does/can not destroy my plugin object.
Does that answer your question or did I misunderstand your point?

Potential use after free I think, and duplicating an existing capability.

Can you look at the updated diff? I reset the Transaction object inside Txn arg, which will prevent potential use-after-free and also cleaned up the the transaction plugin object/continuation in txn-clsoe event.

It seems like these changes would be benign to those using the CPPAPI as originally intended. But I can't see how logic that you can't be sure will execute would be useful.

The primary motivation for me is to prevent the assert from firing. However, this will also allow other users that want to do stuff in TXN_CLOSE hook without having to put that stuff into the d'tor (which is actually a little bit ugly).

In the state dump, in frame #4, it seems to be showing the parameters in the reverse order from what they are declared in the function:
https://github.com/apache/trafficserver/blob/bf097d4289a3eaa3759a58fb19e48381b89ce32f/src/tscpp/api/utils_internal.cc#L113
The event parameter is not TS_EVENT_HTTP_TXN_CLOSE (60012).
...
Does that answer your question or did I misunderstand your point?

What about the parameter reversal?

In the state dump, in frame #4, it seems to be showing the parameters in the reverse order from what they are declared in the function:
https://github.com/apache/trafficserver/blob/bf097d4289a3eaa3759a58fb19e48381b89ce32f/src/tscpp/api/utils_internal.cc#L113
The event parameter is not TS_EVENT_HTTP_TXN_CLOSE (60012).
...
Does that answer your question or did I misunderstand your point?

What about the parameter reversal?

Yeah, that is interesting. Not sure how to explain that, wonder if it's stack corruption.

After this line: https://github.com/apache/trafficserver/blob/3376d438b4a6410187e1ddedd87d2e89279ec196/include/tscpp/api/TransactionPlugin.h#L94 I think you should add:
   *
   * \note For automatic destruction, you must either register dynamically allocated instances of
   * classes derived from this class with the the corresponding transaction (with
   * Transaction::addPlugin()), or register HOOK_TXN_CLOSE (but not both).

[approve ci autest]

Can this be squashed to a single commit before it gets merged?

Can this be squashed to a single commit before it gets merged?

Yes, I'm going to use the github's option to "Squash and Merge". Just need an approval.

Cherry-picked to v9.0.x branch.


man_pages reports "can't chown/unlink (null) Bad address" error

Info

Operating System: Kernel: 5.19.0-41-generic arch: x86_64 bits: 64 Console: pty pts/0 Distro: Ubuntu 2.10 (Kinetic Kudu)
Shell: zsh (running as root)
Terminal: windows wezterm remote login with tmux
nvim --version:
NVIM v0.10.0-dev-36941942d
Build type: Release
LuaJIT 2.1.0-beta3
Run "nvim -V1 -v" for more info
fzf --version: 0.30.0 (2093667)

[x] The issue is reproducible with mini.sh

Description

man_pages provider reports can't chown (null): Bad address and man: can't unlink (null): Bad address.
No previewer for any man page entries.

Other information:

https://github.com/ibhagwan/fzf-lua/issues/368 may be relevant but different.  -c is --catman and man man says This option is not for general use and should only be used by the catman program.. mandb exists but seems nothing relevant when I run mandb or mandb --test.

When running man -c <entry> in the terminal, all the <entry> reports similar errors on chown and unlink. e.g.,

$ man strcpy
man: can't chown (null): Bad address
man: can't unlink (null): Bad address
strcpy.

man comes from man-db debian package; which is https://man-db.gitlab.io/man-db/.

$ dpkg -S $(which man)
man-db: /usr/bin/man
$ man --version
man 2.10.2

@hongxuchen, this error is not specific to fzf-lua, if you can’t run the command in the same manner in the shell fzf-lua obviously can’t do it either.
Fix the underlying issue and once man works from the shell fzf-lua will be able to display the command output as well.

But my "man" is preinatalled by  Ubuntu/debian package manager, which should affect many other users. In addition, telescope man_files works perfectly fine.
…

Idk what command Telescope man runs, fzf-lua just outputs the terminal command, having this error in the shell is not normal and should be fixed which is probably the reason why there are no other issues about it from other Debian users.
Something is obviously wrong with your man install, once you fix that fzf-lua will work as well.

But my "man" is preinatalled by  Ubuntu/debian package manager, which should affect many other users. In addition, telescope man_files works perfectly fine.
…

Idk what command Telescope man runs, fzf-lua just outputs the terminal command, having this error in the shell is not normal and should be fixed which is probably the reason why there are no other issues about it from other Debian users.
Something is obviously wrong with your man install, once you fix that fzf-lua will work as well.

I tried another machine Debian Sid (Host: debian Kernel: 6.1.0-9-amd64 arch: x86_64 bits: 64 Console: pty pts/7 Distro: Debian) and preinstalled man (still from man-db, with newer version 2.11.2) and there are similar errors when running man -c man (for sure, without -c arg man man works perfectly fine).
I suppose other Debian/Ubuntu users will also be affected since I haven't done anything customization on man command.
May I know what's the equivalent command of running vanilla fzf when invoking man_pages within fzf-lua? And is there any way to invoke without -c?

But my "man" is preinatalled by  Ubuntu/debian package manager, which should affect many other users. In addition, telescope man_files works perfectly fine.
…

Idk what command Telescope man runs, fzf-lua just outputs the terminal command, having this error in the shell is not normal and should be fixed which is probably the reason why there are no other issues about it from other Debian users.
Something is obviously wrong with your man install, once you fix that fzf-lua will work as well.

I tried another machine Debian Sid (Host: debian Kernel: 6.1.0-9-amd64 arch: x86_64 bits: 64 Console: pty pts/7 Distro: Debian) and preinstalled man (still from man-db, with newer version 2.11.2) and there are similar errors when running man -c man (for sure, without -c arg man man works perfectly fine).
I suppose other Debian/Ubuntu users will also be affected since I haven't done anything customization on man command.
May I know what's the equivalent command of running vanilla fzf when invoking man_pages within fzf-lua? And is there any way to invoke without -c?

From your post it seemed that the error was appearing when running man <cmd> (without -c)  in the shell:

$ man strcpy
man: can't chown (null): Bad address
man: can't unlink (null): Bad address
strcpy.

This is an easy fix, see https://github.com/ibhagwan/fzf-lua#default-options
require'fzf-lua'.setup {
  previewers = {,
    man = {
      -- NOTE: remove the `-c` flag when using man-db
      -- replace with `man -P cat %s | col -bx` on OSX
      cmd  = "man %s | col -bx",
    }
}

@ibhagwan OK, it works now. It seems the issue of --catman/-c or catman mandb issue of debian packaged man-db.

@ibhagwan OK, it works now. It seems the issue of --catman/-c or catman mandb issue of debian packaged man-db.

Yes, as I wrote in the default options comments the -c should be removed when using mandb, I was confused since you posted terminal output of the command without using -c (in the OP) which made me believe your man command is broken.

Sorry I pasted the wrong command which cause the misconstruction.


Intermittent failures in web_tool_tests due to failure to connect to chrome

The failures happened in HHH flutter web bot (running heads of engine, flutter, and dart SDK) that runs flutter web_tool_tests.
Related: flutter/flutter#85043
Example: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-engine-linux/13586/overview
Failed to establish connection with the application instance in Chrome.
This can happen if the websocket connection used by the web tooling is unable to correctly establish a connection, for example due to a firewall.
#0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
#1      ResidentWebRunner.run (package:flutter_tools/src/isolated/resident_web_runner.dart:328:7)

#2      AppDomain.launch. (package:flutter_tools/src/commands/daemon.dart:595:9)

#3      AppDomain.launch (package:flutter_tools/src/commands/daemon.dart:593:5)
...

/cc @jonahwilliams would it be possible to add verbose logging in throwToolExit, so we can pinpoint the failing code? I suspect something fails in dwds but cannot repro this locally.


Adding Proxy Only Mode

Edge core can now do a proxy only mode allowing it to serve
CONNECT proxy requests despite not being able to obtain Pelion
credentials from edge-core.

Refer to this link for build results (access rights to CI server needed):
https://edge-jenkins.isgtesting.com/job/test_team-build-edge_proxy/65/

Might make things more clear to refactor into a function.

Refer to this link for build results (access rights to CI server needed):
https://edge-jenkins.isgtesting.com/job/test_team-build-edge_proxy/66/

Refer to this link for build results (access rights to CI server needed):
https://edge-jenkins.isgtesting.com/job/test_team-build-edge_proxy/67/

Refer to this link for build results (access rights to CI server needed):
https://edge-jenkins.isgtesting.com/job/test_team-build-edge_proxy/69/


Naginata - Adapt the software to competitions needs

What's different with Kendo
There is one more score possible in Naginata:

Sune (shin)

What other things we need to adapt
We should have some templates system we can switch with software settings. I think when we create a competition we can select whats kind of martial art it concern.
So we can adapt things like the scores, the background image and so on...
Contact
Mark Alexander Berghaan ETD Naginata

You might want to create also another template for Iaido

@dragon2ag I agree, however I need all specifications and differences from Kendo competitions to think about a good way to implement it. I do not know about this specifications


Request for Contact  Inquiry on Dataset Management

Would it be possible to share a contact point, such as an email address or a preferred platform, where I could reach out to you for a more in-depth discussion?
Thank you very much for your time and consideration. I look forward to the possibility of exchanging ideas and learning from your experiences.

Yes, of course. Here is my email address for your kind convenience:
@.*** (Personal)
@.*** (Official)
On Mon, 19 Feb, 2024 at 11:45 PM, PebriKurniaSandi @.***>
wrote:

Would it be possible to share a contact point, such as an email address or
a preferred platform, where I could reach out to you for a more in-depth
discussion?
Thank you very much for your time and consideration. I look forward to the
possibility of exchanging ideas and learning from your experiences.
—
Reply to this email directly, view it on GitHub
https://github.com/minhazkamal/Arabic-Handwritten-Character-and-Digit-Recognition/issues/2,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQ2246PXZ557V2674NFU553YUOFSPAVCNFSM6AAAAABDP3H6ZSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DEOBYG4YDCNQ
.
You are receiving this because you are subscribed to this thread.Message
ID:
<minhazkamal/Arabic-Handwritten-Character-and-Digit-Recognition/issues/2@
github.com>

Yes, of course. Here is my email address for your kind convenience<EMAIL_ADDRESS>(Personal<EMAIL_ADDRESS>(Official)
…
On Mon, 19 Feb, 2024 at 11:45 PM, PebriKurniaSandi @.***> wrote: Would it be possible to share a contact point, such as an email address or a preferred platform, where I could reach out to you for a more in-depth discussion? Thank you very much for your time and consideration. I look forward to the possibility of exchanging ideas and learning from your experiences. — Reply to this email directly, view it on GitHub <#2>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ2246PXZ557V2674NFU553YUOFSPAVCNFSM6AAAAABDP3H6ZSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DEOBYG4YDCNQ . You are receiving this because you are subscribed to this thread.Message ID: <minhazkamal/Arabic-Handwritten-Character-and-Digit-Recognition/issues/2@ github.com>

I think github has censored your address so I can only see *@, this is possible to maintain privacy. Is there another way?

Thank you, I have sent you an email


complete proteomes

@ninewise @bmesuere @silox UniProt also provides a list of complete proteomes. Instead of retrieving the "complete genomes" from genbank, we might also work from this list. However, this would only include the complete genomes (not the partial ones). At least, we could do a check to see how much "complete proteomes" the two resources have in common.
Original issue by @pdawyndt on Tue Apr 07 2015 at 13:12.
Closed by @bmesuere on Sun Jan 24 2016 at 13:18.

It seems that all UniProt proteomes are also linked to to an Assembly, so probably they have also built the proteome database from the same resource as we have. It might be worthwile to check if Unipept has the same list of "complete proteomes" as UniProt after the new data has been included into Unipept.
Original comment by @pdawyndt on Tue Apr 07 2015 at 13:33.

Instead of only providing a link to the Assembly record, we could also include a link to the UniProt proteome record.
Original comment by @pdawyndt on Tue Apr 07 2015 at 13:33.

If the two list differ not too much, we could provide the option to upload one or mores proteomes directly from the UniProt proteomes, by providing a list of proteome IDs (or directly in the format that can be exported from Uniprot proteomes: Proteome ID, Organism, Taxonomic identifier and Last modified, separated by tabs)
Original comment by @pdawyndt on Tue Apr 07 2015 at 14:41.

Unipept uses UniProt proteomes since version 3.1
Original comment by @bmesuere on Sun Jan 24 2016 at 13:18.


PowMr to EV Charger help needed

Hello - I need some project help connecting my PowMr through some controller (Raspberry PI, ESP, Arduino) to an EV charger. I can pay a nominal hourly fee. Are either of you available and interested?

I would suggest to post a bit more details about what you want to accomplish.


Wip nydus-image: nydus v6 support explicit uid and gid

Sorry, this PR doesn't have any test case, I just tested it manually, and for the next PR I'll introduce fssum to test.
Signed-off-by: zyfjeff<EMAIL_ADDRESS>

@zyfjeff , a new test job has been submitted. Please wait in patience.

@zyfjeff , The CI test is completed, please check result:

Test CaseTest Result

merge-target-branch:white_check_mark:SUCCESS

build-docker-image:white_check_mark:SUCCESS

compile-nydus:white_check_mark:SUCCESS

compile-ctr-remote:white_check_mark:SUCCESS

compile-nydus-snapshotter:white_check_mark:SUCCESS

start-nydus-snapshotter-config-containerd:white_check_mark:SUCCESS

run-container-with-nydus-image:white_check_mark:SUCCESS

Congratulations, your test job passed!


Bundle GPSd

It would be nice to have GPSd included in the image to provide offline time sync and for geotagging in software like kismet.

Please submit a PR to add gpsd to wlanpi0/00-install-packages/05-packages.


launchAff_ ∷ Aff Unit → Effect Unit

It's very easy to accidentally discard values when with launchAff_ it can produce dumb "bugs". I think it would be better to specialize it's type to:
-launchAff_ ∷ ∀ a. Aff a → Effect Unit
+launchAff_ ∷ Aff Unit → Effect Unit

Maybe we can do this in next braking change if people agree if people agree?
(This is what I was thinking before https://github.com/purescript/purescript-prelude/issues/203 but I got convinced with just specializing a to Unit)

Isn't that why launchAff exists?
launchAff_ exists because it's less verbose than void <<< launchAff
So by choosing to use launchAff_, aren't you indicating that you don't
care what the return value is?
Or am I misunderstanding you?

Yeah, it's pretty much the whole point of launchAff_ over launchAff. Similar to traverse_, for_, etc. where they discard any value also.


Remove yarn.nix

This is a dead file, not used and confused people.
Going to merge without review.

Looks good. Remember to delete the branches after merging. (It's a small cleanup task)


GitHub actions automations

Add Github action to comment on issues if a fix for that issue has been released
Add Github action to automatically add new/reopened PRs and issues to the "Python SDK" project.
Label PRs that have as base branch "potel-base" with "Project: POTel"

Can be done in the UI with Github Projects Workflows. Closing.


feat: 🎸 sanitize HTML in createElement

Decided to go with https://github.com/cure53/DOMPurify for a few reasons:

Newest version does not contain any known vulnerabilities: https://snyk.io/vuln/npm:dompurify
Easy to use
They offer a bug bounty program
Worked really well on the payloads that I've tried:

		const doc = new jsPDF();
		window.html2canvas = html2canvas;
		const html = `

a

<img src=x onerror=alert('XSS')//

">
">
<svgonload=alert(1)>
<svg/onload=alert('XSS')>
<svg onload=alert(1)//
<svg/onload=alert(String.fromCharCode(88,83,83))>
<svg id=alert(1) onload=eval(id)>
"><svg/onload=alert(String.fromCharCode(88,83,83))>
"><svg/onload=alert(/XSS/)

	`;
	doc.html(html, {
	callback: function (doc) {
	}
	});

Closes #2795

@HackbrettXXX Please verify that everything works as I have tested this locally by changing the dist code, but haven't installed it via npm locally.

Looks good. Thank you very much for the help. I'll notify you as soon as the new release is out.


chore(deps): update engines to 3.13.0-7.d0e454832ed9b907fa334540e72c4d087abbebc1

This automatic PR updates the engines to version 3.13.0-7.d0e454832ed9b907fa334540e72c4d087abbebc1. This will get automatically merged if all the tests pass.
Packages:

Package
NPM URL

@prisma/engines
<EMAIL_ADDRESS>

@prisma/engines-version
<EMAIL_ADDRESS>

@prisma/fetch-engine
<EMAIL_ADDRESS>

@prisma/get-platform
<EMAIL_ADDRESS>

Needed a manual PR, since our PR bot is rate limited by GitHub at the moment, for an unknown reason.


Fix JVM CodeHeap memory pool collection

Since Java 9, code heap was split into three different pools. Their names containing single-quote (') which is not acceptable by my metric collector. To be honest, I think most collector does not like single-quote. Therefore, it makes sense to sanitize the names (like it did with the space character) in the Ultrabrew Metrics library.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

This will, of course, change the metric names for anyone who is currently using them on Java 9+ successfully with a collector that has no issues with such characters.

True, so we could change it in the reporters possibly.

Arguably, reporters should fixup characters they can not deal with, since the core code can't know about every possible reporters' limitations.

@rafan mind putting this in our internal repo instead please?

Sure, I will do it for the internal reporter.


Bug: Use of Field(index=True) on bool type field breaks Model.find()

I have found what seems to be a bug that is likely the underlying cause of issue #299.
When using this model:
class User(JsonModel):
okta_id: Optional[str] = Field(index=True)
username: str = Field(index=True)
password: str = Field(index=True)
token: Optional[str] = Field(index=True)
email: Optional[str] = Field(index=True)
full_name: Optional[str] = None
enabled: bool = Field(index=True, default=True)
The .find() method does not return any results both with no filters applied and with any combination of valid filters applied. As soon as I change the enabled model property to not be a Field(index=True) but instead just a static True, the .find() method begins behaving as expected.
I have reproduced this issue in both versions 0.2.2 and 0.3.1 from PyPi.

Hi @AzorianMatt - so the underlying issue with booleans was (pre 0.3.1) that a boolean would be interpreted in the index creation as a NUMERIC, but serialized to a JSON boolean (which RediSearch is equipped to query as a tag field). This caused the objects to actually break on insertion and not be queryable.
However there's another issue in the way the ExpressionProxy (the lambda source for redis om python) interprets the queries. I can't override the dunder __bool__ method of the expression proxy without shattering the library into a million pieces, consequentially, we unfortunately cannot use unary boolean operations (so you have to do truth evaluations like find(Model.enabled == True) rather than find(Model.enabled)  :
let's take a look at this from a test:
@py_test_mark_asyncio
async def test_boolean():
    class Example(JsonModel):
        b: bool = Field(index=True)
        d: datetime.date = Field(index=True)
        name: str = Field(index=True)

    await Migrator().run()

    ex = Example(b=True, name="steve", d=datetime.date.today())
    exFalse = Example(b=False, name="foo", d=datetime.date.today())
    await ex.save()
    await exFalse.save()
    res = await Example.find(Example.b == True).first()
    assert res.name == "steve"

    res = await Example.find(Example.b == False).first()
    assert res.name == "foo"

    res = await Example.find(Example.d == ex.d and Example.b == True).first()
    assert res.name == ex.name

Does this help at all?

Hi @AzorianMatt - the issue is resolved in 0.3.1 (the version I just released yesterday), if you were having indexing failures you would be able to see the failures in the FT.INFO of the index - steps to check:

Create your index with Migrator().run(), insert your docs
check your index name (FT._LIST will print out all your indexes)
call FT.INFO index-name on the index
Check the hash_indexing_failures field in there - that's what will tell you whether something failed to insert
You can always check to see what kind of documents you have in the index by querying it with FT.SEARCH index-name *

@slorello89 thank you! This is very helpful information. I will see what I can do in order to get updated to the latest version. For now, I can work around the issue by avoiding indexing of the bool field as I don't actually need it quite yet.

Sounds good @AzorianMatt - if this issue does recur in the latest version of Redis OM Python, please by all means reopen.


changing placement of hamburger to right

Related Issue

Information about the related issue

Closes: #
Describe the changes you've made
changing placement of hamburger to right

Type of change
What sort of change have you made:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update.
[ ] This change requires a documentation update

How Has This Been Tested?

Checklist

[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented on my code, particularly wherever it was hard to understand.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[ ] Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original
Updated

Code of Conduct

[x] I agree to follow this project's Code of Conduct

Hey @vinzvinci @Anmol-Baranwal @thehashmap
Please review this PR.


Error when training with 1 gpu: RuntimeError: a leaf Variable that requires grad is being used in an in-place operation.

Settings:
Win10 Pro
python 3.7.9
ptorch 1.8.1+cu111
1 GPU
GLOO backend
jupyter notebook
I can run the rest of the methods fine. I can run classifier_sample.py, super_res_sample.py but when I tried to run classifier_train.py I got a runtime error.
...\torch\distributed\distributed_c10d.py in broadcast(tensor, src, group, async_op)
1027         return work
1028     else:
-> 1029         work.wait()
1030
1031
RuntimeError: a leaf Variable that requires grad is being used in an in-place operation.
This is the argument I used and the training commands:
TRAIN_FLAGS="--iterations 300000 --anneal_lr True --batch_size 256 --lr 3e-4 --save_interval 10000 --weight_decay 0.05"
CLASSIFIER_FLAGS="--image_size 128 --classifier_attention_resolutions 32,16,8 --classifier_depth 2 --classifier_width 128 --classifier_pool attention --classifier_resblock_updown True --classifier_use_scale_shift_norm True"
%run scripts/classifier_train.py --data_dir r"G:\data_set\imagenette2-160\train" $TRAIN_FLAGS $CLASSIFIER_FLAGS
Thanks for any comments and assistance in advance.

@jaketalyor32325 I was able to comment out dist_util.sync_params(self.model.parameters()) from train_util.py and get the training to run. I assume the parameters really only need to be sync'd across multiple-gpus.

@jaketalyor32325 Hello, do you need to make any adjustments when using your own data set code part when training guided_classifier?


Networking: Peer connection limits

Summary
Add settings to control the amount of peers we connect to and discover.
Problem
Homestar will attempt to dial every peer that is under our rendezvous namespace, and since we always register with other nodes it leads to an exponential discovery until every node has dialed every other node in the network.
Impact
At the moment it is fine since we dont have any large networks, but this needs to be addressed before then or networking will be over stressed.
Solution
Add limits to the amount of connected peers in settings.
Detail
When below limits ask around for more peers, then when we start running low (maybe a low level parameter as well?) we start discovering peers again.
https://docs.rs/libp2p/latest/libp2p/connection_limits/struct.ConnectionLimits.html
Additional context
https://github.com/ipvm-wg/homestar/pull/236#discussion_r1302093005

Solved by internal configuration.


how to solve

HTTP code is 500 which indicates error: server error - {"message":"Get https://registry-1.docker.io/v2/: dial tcp: lookup registry-1.docker.io on <IP_ADDRESS>:53: too many redirects"}

Please make sure that you're on a stable connection and use a solid DNS such as Google DNS.


Fix skipping certain SDK tests

Fixes the issue where SDKs set by SKIP_TESTS were not skipped by Mint.
Adds container-id look up in the main script. This way Mint prints ready to use command to copy out the logs.

@krisis any reviews here


WIP: Move to Julia 1.3 and Zygote

This will need the following packages on master:
  [be33ccc6] CUDAnative v2.4.0 #master (https://github.com/JuliaGPU/CUDAnative.jl.git)
  [3a865a2d] CuArrays v1.3.0 #master (https://github.com/JuliaGPU/CuArrays.jl.git)
  [587475ba] Flux v0.9.0 #master (https://github.com/FluxML/Flux.jl.git)
  [e88e6eb3] Zygote v0.3.4 #master (https://github.com/FluxML/Zygote.jl.git)
  [700de1a5] ZygoteRules v0.2.0 #master (https://github.com/FluxML/ZygoteRules.jl.git)
  [7869d1d1] IRTools v0.2.3 #master (https://github.com/MikeInnes/IRTools.jl.git)

With Zygote we will loose the ability to specify trainable parameters of a model through TrackedArrays. The replacement for this is Flux.trainable which we would have to overload for each type

the trainable issue could be solved like this: https://github.com/nmheim/GenerativeModels.jl/blob/ce9e6ecdcc0e7199e34211a1b44dd7a6f123613e/src/pdfs/abstract_pdfs.jl#L126-L129
@smidl @vitskvara @honzabim what do you think?

Codecov Report

Merging #36 into master will decrease coverage by 65.92%.
The diff coverage is 68%.

@@             Coverage Diff             @@
##           master      #36       +/-   ##
===========================================
- Coverage   86.95%   21.03%   -65.93%
===========================================
  Files          11       11
  Lines         230      233        +3
===========================================
- Hits          200       49      -151
- Misses         30      184      +154

Impacted Files
Coverage Δ

src/GenerativeModels.jl
100% <ø> (ø)
:arrow_up:

src/pdfs/gaussian.jl
100% <ø> (ø)
:arrow_up:

src/utils/saveload.jl
0% <0%> (-100%)
:arrow_down:

src/pdfs/cgaussian.jl
23.52% <100%> (-76.48%)
:arrow_down:

src/pdfs/abstract_pdfs.jl
80% <60%> (-20%)
:arrow_down:

src/pdfs/abstract_cgaussian.jl
37.14% <81.25%> (-62.86%)
:arrow_down:

src/pdfs/svar_cgaussian.jl
0% <0%> (-100%)
:arrow_down:

src/models/vae.jl
0% <0%> (-95%)
:arrow_down:

src/models/rodent.jl
0% <0%> (-94.12%)
:arrow_down:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4239c6d...169f2ad. Read the comment docs.


Do not add slave connection on broken link

When the slave is being reconnected after being disconnected and is out of sync link with master is broken and making read calls could return either null or LOADING Redis is loading the dataset in memory response. To ensure that client connects to good health slave, sentinel provides master-link-status which shows current status.

Hi, is there any chance that this PR will be part of an 1.1.7 release ?

Hi, is there any chance that this PR will be part of an 1.1.7 release ?


Old flutter gallery text contrast tests fail when images actually load

00:27 +85: /opt/s/w/ir/x/w/flutter/dev/integration_tests/flutter_gallery/test/accessibility_test.dart: Gallery home page meets text contrast guidelines options menu - dark theme
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: Text contrast should follow WCAG guidelines
  Actual: <Instance of 'WidgetTester'>
   Which: SemanticsNode#35(merge boundary ⛔, Rect.fromLTRB(0.0, 0.0, 800.0, 48.0), flags:
[isHeader], label: "Diagnostics", textDirection: ltr):
          Expected contrast ratio of at least 3.0 but found 1.92 for a font size of 20.0.
          The computed colors was:
          light - Color(0xff003d75), dark - Color(0xff000000)
          See also: https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html

When the exception was thrown, this was the stack:
#0      fail (package:test_api/src/expect/expect.dart:137:31)
#1      _expect.<anonymous closure> (package:test_api/src/expect/expect.dart:112:9)
<asynchronous suspension>
<asynchronous suspension>
(elided 6 frames from dart:async and package:stack_trace)

The test description was:
  options menu - dark theme
════════════════════════════════════════════════════════════════════════════════════════════════════

00:27 +85 -1: /opt/s/w/ir/x/w/flutter/dev/integration_tests/flutter_gallery/test/accessibility_test.dart: Gallery home page meets text contrast guidelines options menu - dark theme [E]
  Test failed. See exception logs above.
  The test description was: options menu - dark theme

Due to a misunderstanding of https://github.com/flutter/flutter/issues/103724 this issue was raised when we tested with real icons instead of ahem


Typo in example 6 in sets-functions-relations/size-of-sets/enumerability.tex

Typo location:
https://github.com/OpenLogicProject/OpenLogic/blob/87ad058e9cbc7e07b855d911cfca1013534a5335/content/sets-functions-relations/size-of-sets/enumerability.tex#L129
What is the typo:
g(n) as defined excludes 1 from the range
Proposed correction:
g(n) = 2n - 1

Good catch, yes. There is an alternate version of this (and two other) sections in this chapter that define enumerability differently, and use \Nat instead of \PosInt.  (The definition of g is correct if you are looking for functions Nat -> Nat.) You might like that better for your purposes.

PS see https://github.com/OpenLogicProject/set-theory/blob/master/settheory.tex for how they are imported in the Set Theory book.

PS see https://github.com/OpenLogicProject/set-theory/blob/master/settheory.tex for how they are imported in the Set Theory book.

Thanks!

Fixed in 514bad7913cbf6d1e3bad0372a6c1f5f427f9064


⚠ Bofrost.de has degraded performance

In 02bfc03, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1285 ms

Resolved: Bofrost.de performance has improved in e53bcf2.


Mixed Paint Bucket - Fix Exhausted Pallete Picks being not Exhaustable

...nah. It's not a bug, but an unforseen feature.


Support splitting a Flutter app's assets into multiple packages

For Android Instant Apps, and probably for Fuchsia and probably for hot updates, we will want to split an apps' assets into blobs of data each of which can be shipped separately and loaded independently. It would probably make sense to do it along package: boundaries like we do for Dart code.
cc @zanderso @tvolkert @jason-simmons @chinmaygarde @cbracken

See also https://github.com/flutter/flutter/issues/16816, about managing assets by locale.

See also: https://github.com/flutter/flutter/issues/16812, https://github.com/flutter/flutter/issues/16813


Assign type scope for exclamation mark preceding colon

class Cl {
    one?: string;
    two!: string;
}

Some themes have different coloring for type punctuation scopes like keyword.operator.type. But exclamation mark stands out because it's keyword.operator.logical.

It would be nice for it to have a separate scope (like question mark keyword.operator.optional) or at least the same as colon keyword.operator.type.

Could someone explain to me the difference between "?" and "!", obviously in this TS context

!: - property is NOT optional, and you want to override TypeScript (maybe it will definitely be assigned later)
?: - property is optional (can be omitted (undefined))


postgresql - query timestamps with timezone

Fixes timestamp issues from #11
Per http://www.postgresql.org/docs/9.1/static/datatype-datetime.html:

The SQL standard requires that writing just timestamp be equivalent to timestamp without time zone, and PostgreSQL honors that behavior. (Releases prior to 7.3 treated it as timestamp with time zone.) timestamptz is accepted as an abbreviation for timestamp with time zone; this is a PostgreSQL extension.

Wow, nice catch. Thanks.

Thanks for the quick merge :)

@llambda Can you also rev and publish the fix? Thanks!

Yep published!


apps:point toward download button

What's this PR for?
This PR enhance the icon button work in zulip/apps. This PR adds a functionality that points a user toward download button on click
Testing Plan:
Tested on Ubuntu, Mozilla
GIFs or Screenshots:

@rrhythmsharma in addition to the stuff on CZO,
I wanted to point out that you should have the commit summary (title) follow the convention we use. You can read more about that in the version-control docs here.
Please run ./tools/lint from within vagrant to get the related error messages.
It should be fine if you change it to something with the format of:
apps: Point to download button - jquery.

@YashRE42  actually @vinitS101  was helping me with where to put jquery code (discussed here) so i push a temp commit, i was just about to squash commits then you messaged here so that's why i stopped, don't worry about it, it's just a wrong commit message(temp commit)

I didn't mean it about the temp commit. I meant to point out that it's a space followed by a capital letter after the ":" and a fullstop at the end, again, you'd see the regex in the error if you ran ./tools/lint :sweat_smile:


Use isInBrowserContext() to avoid window/document broswer issues

Solves #96 .
Tested in local

While testing I had an issue with:
'createGtm' is not exported by ../vue-gtm/dist/index.js, imported by src/main.js
file: /Volumes/Data/Development/skedr/landing/src/main.js:6:9
4: import { routes } from "./routes"
5: import VueGtag from "vue-gtag"
6: import { createGtm } from "@gtm-support/vue-gtm"
            ^
7: //import VueHotjar from "vue-hotjar-next"
Error: 'createGtm' is not exported by ../vue-gtm/dist/index.js, imported by src/main.js
    at error (/Volumes/Data/Development/skedr/landing/node_modules/rollup/dist/shared/rollup.js:158:30)
    at Module.error (/Volumes/Data/Development/skedr/landing/node_modules/rollup/dist/shared/rollup.js:12382:16)
    at Module.traceVariable (/Volumes/Data/Development/skedr/landing/node_modules/rollup/dist/shared/rollup.js:12767:29)
    at ModuleScope.findVariable (/Volumes/Data/Development/skedr/landing/node_modules/rollup/dist/shared/rollup.js:11559:39)
    at ReturnValueScope.findVariable (/Volumes/Data/Development/skedr/landing/node_modules/rollup/dist/shared/rollup.js:6930:38)
    at ChildScope.findVariable (/Volumes/Data/Development/skedr/landing/node_modules/rollup/dist/shared/rollup.js:6930:38)
    at Identifier.bind (/Volumes/Data/Development/skedr/landing/node_modules/rollup/dist/shared/rollup.js:6419:40)
    at CallExpression.bind (/Volumes/Data/Development/skedr/landing/node_modules/rollup/dist/shared/rollup.js:5025:23)
    at CallExpression.bind (/Volumes/Data/Development/skedr/landing/node_modules/rollup/dist/shared/rollup.js:9396:15)
    at CallExpression.bind (/Volumes/Data/Development/skedr/landing/node_modules/rollup/dist/shared/rollup.js:5021:31) {
  code: 'MISSING_EXPORT',
  url: 'https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module',

and I solved using:
export { createGtm }

But I'm not sure it was just in the testing phase with the bundle or will error also in the build phase...

Seems you have not activated allow changes by maintainer :slightly_frowning_face:
Could you do me a favor any copy over my draft https://github.com/gtm-support/vue-gtm/pull/98/files into this PR?
I added a test and I moved the condition one step up.
I would like that you get the credits / commit mention of this PR :slightly_smiling_face:
Then I can delete my draft
Also please have a look over the ssg-mode.test.ts file and check if we should change anything there.

One additional question:
I found out that app.mount('#app') also fails in "SSG"-Mode :thinking:, so how do you bypass this?

Oh, in addition you should make a rebase and then use pnpm. I switch slowly all my projects to pnpm but this project wasn't touched for a while.

Sorry I didn't know that option existed.

One additional question:
I found out that app.mount('#app') also fails in "SSG"-Mode 🤔, so how do you bypass this?

For prerendering I'm using https://github.com/antfu/vite-ssg so I'm not using the options in the Vite directly. That project has a few added benefits that Vite didn't have due to being framework agnostic.
Haven't used pnpm but I'll try 👍🏼

Ah okay, I just didn't know ViteSSG / how it works :slightly_smiling_face:

Have a look in https://github.com/Skedr/landing It's the landing page of my project. There's no fancy stuff so easy to see.

I haven't used TS and I have an error it not happened before when I tried the tests...
ERROR: src/index.ts:150:16 - error TS2664: Invalid module name in augmentation, module '@vue/runtime-core' cannot be found.

150 declare module '@vue/runtime-core' {
                   ~~~~~~~~~~~~~~~~~~~

All tests fail now :O
I've made an install with pnpm I guess I delete the yarn.lock and add the pnpm-lock.yaml right?

Cause the main branch is now newer than yours
https://github.com/gtm-support/vue-gtm/blob/eb55407f4faf6bf2f4685511e57499d339bc09f0/src/index.ts#L147

Seems you copied it with one indent offset
Please run pnpm run format and I think we are good to go

I haven't reviewed the tests :/

I haven't reviewed the tests :/

You are right :+1: I will give you time to do that

I've left the only relevant test. If you remove the new if() clause that test will return 'ReferenceError: document is not defined`

I will merge it tomorrow or late this evening
You have also some time this way to change anything if needed

Released<EMAIL_ADDRESS>please test it 🙂

Released<EMAIL_ADDRESS>please test it 🙂

Everything is working. Thanks!


Failed to load the native TensorFlow runtime.

System information

OS Platform and Distribution windows 10
TensorFlow installed from source
TensorFlow 2.3
Python 3.8
Installed using conda

Describe the problem
I am just trying to a run a code that i downloaded from github if someone can help this is my first time using tensorflow.
Any other info / logs
[Running] python -u "c:\Users\projects\Desktop\Machine and  Deep learning\TensorflowProjects-master\TensorflowProjects-master\MNIST\HelloTensor.py"
Traceback (most recent call last):
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\Users\projects\Desktop\Machine and  Deep learning\TensorflowProjects-master\TensorflowProjects-master\MNIST\HelloTensor.py", line 1, in
import tensorflow as tf
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow_init_.py", line 41, in
from tensorflow.python.tools import module_util as module_util
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python_init.py", line 50, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 69, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.
[Done] exited with code=1 in 145.607 seconds
[Running] python -u "c:\Users\projects\Desktop\Machine and  Deep learning\TensorflowProjects-master\TensorflowProjects-master\EmotionDetection\EmotionDetector.py"
Traceback (most recent call last):
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\Users\projects\Desktop\Machine and  Deep learning\TensorflowProjects-master\TensorflowProjects-master\EmotionDetection\EmotionDetector.py", line 1, in
import tensorflow as tf
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow_init_.py", line 41, in
from tensorflow.python.tools import module_util as module_util
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python_init.py", line 50, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 69, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.
[Done] exited with code=1 in 366.04 seconds
[Running] python -u "c:\Users\projects\Desktop\Machine and  Deep learning\TensorflowProjects-master\TensorflowProjects-master\EmotionDetection\EmotionDetector.py"
Traceback (most recent call last):
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\Users\projects\Desktop\Machine and  Deep learning\TensorflowProjects-master\TensorflowProjects-master\EmotionDetection\EmotionDetector.py", line 1, in
import tensorflow as tf
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow_init_.py", line 41, in
from tensorflow.python.tools import module_util as module_util
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python_init.py", line 50, in
from tensorflow.python import pywrap_tensorflow
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 69, in
raise ImportError(msg)
ImportError: Traceback (most recent call last):
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 58, in
from tensorflow.python.pywrap_tensorflow_internal import *
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 28, in
_pywrap_tensorflow_internal = swig_import_helper()
File "C:\Users\projects.conda\envs\tensorflow\lib\site-packages\tensorflow\python\pywrap_tensorflow_internal.py", line 24, in swig_import_helper
_mod = imp.load_module('_pywrap_tensorflow_internal', fp, pathname, description)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 242, in load_module
return load_dynamic(name, filename, file)
File "C:\Users\projects.conda\envs\tensorflow\lib\imp.py", line 342, in load_dynamic
return _load(spec)
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.
Failed to load the native TensorFlow runtime.
See https://www.tensorflow.org/install/errors
for some common reasons and solutions.  Include the entire stack trace
above this error message when asking for help.
[Done] exited with code=1 in 196.316 seconds

@Abdallah-isa
What is make/model of your cpu?
I suspect your cpu model does not support AVX instructions sets.See hardware requirements
Make sure to download the latest microsoft visual c++ redistributable from here.
.Also, please follow the instructions from to install from Tensorflow website.
Please, check Your CPU/Python is on 32 bits?Please, refer #36167 and see if it helps you.Please, refer similar issues #36167 #36151 #36138 #36054 #36045 #36020 #36003 #35988 #35903 #35880 #35865 #35805 #35789 #35773 #35772 #35767 #35766 #35749 #35721 #35618 #35204
Thanks!


pull request for e2e test at 01/02/2017 01:15:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


New Year Progression missing old features

Bug description:
The Year Progression is missing some of the features of the old one:

target is gone
30 day rolling average is gone
12 month rolling average is gone

Chrome version
61, but with Vivaldi  1.12.955.38 (using Chrome engine),
Plugin version:
5.11.0
Console errors? (press F12 to see developer console, and copy paste here):
FitnessDataService.js:209 Fetch fitnessData from fitnessDataService.getFitnessData
FitnessDataService.js:68 Fetch fitnessObjectsWithDaysOff from fitnessDataService.getFitnessObjectsWithDaysOff
FitnessDataService.js:183 First preview day is Sat Sep 30 2017 00:00:00 GMT+0100 (GMT Daylight Time)
FitnessDataService.js:214 Generating FitnessData from storage took 458 ms.
fitnessTrendGraph.js:25 FitnessTrendGraph: message fitnessDataLoaded received
fitnessTrendGraph.js:267 Configure graph options
fitnessTrendTable.js:12 FitnessTrendTable: message fitnessDataLoaded received
fitnessTrendGraph.js:539 Generating Fitness Graph took 638 ms.
5YearProgressController.js:258 Graph loaded
angular.js:14700 mdMenu: The $mdOpenMenu method is deprecated. Please use `$mdMenu.open`.
(anonymous) @ angular.js:14700
11YearProgressController.js:258

Seen ! I will provide fix asap. Ty for report


vitest does not resolve nitro (h3) auto-imports

Environment

Operating System: Linux
Node Version:     v18.18.0
Nuxt Version:     3.11.2
CLI Version:      3.11.1
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      devtools
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/github-xdspn8
Describe the bug
It is impossible to test server API and server route implementations directly, because vitest does not auto import nitro (h3) functions like e.g. defineEventHandler().
When executing the test in the linked minimal reproduction, I receive this error:
FAIL  test/server/routes/something.spec.ts [ test/server/routes/something.spec.ts ]
ReferenceError: defineEventHandler is not defined
 ❯ eval server/routes/something.ts:1:217
 ❯ eval test/server/routes/something.spec.ts:2:31

Additional context
server/routes/something.ts
export default defineEventHandler(() => 'OK');

test/routes/something.spec.ts
import { it } from 'vitest';
import handler from '../../../server/routes/something';

it('should return OK', () => {
  const response = handler({} as any);
  expect(response).toBe('OK');
});

Logs
No response

Yes, the vitest environment is a client environment.
We can track nitro environment via https://github.com/nuxt/test-utils/issues/531.


Unclear what "two rose cases" means

In unit 4, section "The advantages and disadvantages of policy-gradient methods", it is unclear what this statement means:
The problem is that the two rose cases are aliased states, or specifically, was 'rose cases' a typo?
The description is written in this file
Correction:
I subsequently understood that. it is referring to the rose-coloured tiles. However the next section refers to same tiles as "red" : move right when in a red state or always move left.
I would suggest rewriting as rose-coloured tiles in both places

Hey there 👋 thanks for pointing this out. Long story short we use rose initially but some students told us that they didn't know what rose it was (it's a French term used in English) so we changed it to red but we forgot to change it on this one.
From here there are two solutions:

You can change the term rose to red (more inclusive) and open a PR.
If you prefer not to open a PR I can add it to the update list 🤗

Cool, Here's the PR


RPi4 for HASS: Z-Wave devices to be recognized by HASS

Part of https://github.com/130s/hut_10sqft/issues/644

[ ] Z-Wave devices listed on HASS

Clicking "Add integration" link from https://www.home-assistant.io/integrations/zwave_js/, I saw some errors, then HASS said it found Z-WaveJS running on another host that I've been using (but am trying to replace this time). For now I'm ok to keep using and am actually curious how running Z-Wave gateway on another host works, so accepted. Then I got:
Z-Wave JS: Retrying setup

Invalid server version: Z-Wave JS Server version is incompatible: 1.21.0 a version is required that supports at least api schema 22

Giving up multi-host setting, as the current Z-WaveJS server is running on a host where I've been struggling to upgrade the pkg https://github.com/130s/hut_10sqft/issues/673. For now run Z-WaveJS on the same host as HASS runs on.
Issue: Network stops when Z-Wave hub USB device is plugged.
I don't know what's going on, but I verified that this RPi4 loses network connection when I plugged in Z-Wave USB hub.
Some syslog
Sep 12 01:06:06 raspberrypi kernel: [    1.681304] usb 1-1: New USB device found, idVendor=2109, idProduct=3431, bcdDevice= 4.21
Sep 12 01:06:06 raspberrypi kernel: [    1.681341] usb 1-1: New USB device strings: Mfr=0, Product=1, SerialNumber=0
Sep 12 01:06:06 raspberrypi kernel: [    1.681357] usb 1-1: Product: USB2.0 Hub
Sep 12 01:06:06 raspberrypi kernel: [    1.683362] hub 1-1:1.0: USB hub found
Sep 12 01:06:06 raspberrypi kernel: [    1.683599] hub 1-1:1.0: 4 ports detected
Sep 12 01:06:06 raspberrypi kernel: [    2.198798] NET: Registered PF_INET6 protocol family
:
Sep 12 01:06:08 raspberrypi containerd[552]: time="2022-09-12T01:06:08.796811257-04:00" level=info msg="Start cri plugin with config {PluginConfig:{ContainerdConfig:{Snapshotter:overlayfs DefaultRuntimeName:runc DefaultRuntime:{Type: Engine: PodAnnotations:[] ContainerAnnotations:[] Root: Options:<nil> PrivilegedWithoutHostDevices:false BaseRuntimeSpec:} UntrustedWorkloadRuntime:{Type: Engine: PodAnnotations:[] ContainerAnnotations:[] Root: Options:<nil> PrivilegedWithoutHostDevices:false BaseRuntimeSpec:} Runtimes:map[runc:{Type:io.containerd.runc.v2 Engine: PodAnnotations:[] ContainerAnnotations:[] Root: Options:0x4000468ea0 PrivilegedWithoutHostDevices:false BaseRuntimeSpec:}] NoPivot:false DisableSnapshotAnnotations:true DiscardUnpackedLayers:false} CniConfig:{NetworkPluginBinDir:/usr/lib/cni NetworkPluginConfDir:/etc/cni/net.d NetworkPluginMaxConfNum:1 NetworkPluginConfTemplate:} Registry:{Mirrors:map[docker.io:{Endpoints:[https://registry-1.docker.io]}] Configs:map[] Auths:map[] Headers:map[]} ImageDecryption:{KeyModel:} DisableTCPService:true StreamServerAddress:<IP_ADDRESS> StreamServerPort:0 StreamIdleTimeout:4h0m0s EnableSelinux:false SelinuxCategoryRange:1024 SandboxImage:k8s.gcr.io/pause:3.2 StatsCollectPeriod:10 SystemdCgroup:false EnableTLSStreaming:false X509KeyPairStreaming:{TLSCertFile: TLSKeyFile:} MaxContainerLogLineSize:16384 DisableCgroup:false DisableApparmor:false RestrictOOMScoreAdj:false MaxConcurrentDownloads:3 DisableProcMount:false UnsetSeccompProfile: TolerateMissingHugetlbController:true DisableHugetlbController:true IgnoreImageDefinedVolumes:false} ContainerdRootDir:/var/lib/containerd ContainerdEndpoint:/run/containerd/containerd.sock RootDir:/var/lib/containerd/io.containerd.grpc.v1.cri StateDir:/run/containerd/io.containerd.grpc.v1.cri}"
Sep 12 01:06:08 raspberrypi containerd[552]: time="2022-09-12T01:06:08.797162424-04:00" level=info msg="Connect containerd service"
Sep 12 01:06:08 raspberrypi containerd[552]: time="2022-09-12T01:06:08.797515942-04:00" level=info msg="Get image filesystem path \"/var/lib/containerd/io.containerd.snapshotter.v1.overlayfs\""
Sep 12 01:06:08 raspberrypi containerd[552]: time="2022-09-12T01:06:08.808621720-04:00" level=error msg="failed to load cni during init, please check CRI plugin status before setting up network for pods" error="cni config load failed: no network config found in /etc/cni/net.d: cni plugin not initialized: failed to load cni config"
 :

https://raspberrytips.com/how-to-power-a-raspberry-pi/ and others indicate power issue although I'm not yet sure (as the issue seems to be only occuring with network). Maybe dedicated USB-C (amazon.com) (the recommended product (amazon.com) is unavailable on amazon).

I switched the source of the power-supply USB-C from a power hub to the dedicated single cable (which is plugged on to Powerline client that exposes a single outlet) but the result is the same.
Maybe the USB charger is a cellphone charger, which https://raspberrytips.com/how-to-power-a-raspberry-pi/ doesn't recommend (see "Using a Phone Charger to Power a Raspberry Pi" section). So bought a dedicated charger but amazon says it'll take 3 weeks to arrive...

Going through Z-Wave JS setup https://zwave-js.github.io/zwave-js-ui//#/usage/setup

Week passed, today I see Z-Wave JS started including devices.
HASS added Z-Wave JS, when I set 3xxx port for WS? server. Then HASS was able to connect.


Add tests for TTL far in the future

Test that it is not possible to submit Tx with TTL too far in the future. Current slot + 3k/f slots should be the furthest slot.

Implemented in https://github.com/input-output-hk/cardano-node-tests/pull/1067


[config] Add config can set brpc connection type and brpc failed need rebuild connection the server

Proposed changes
Add two config of BE:

brpc_connection_type Add brpc connection_type config, default type is "single", the different of the  connection_type ref: https://brpc.apache.org/docs/client/basics/

enable_brpc_failed_reconnected brpc failed. add config to decide whether to reconnect the connection the remote server

To try find user network bug

run buildall

run buildall

run buildall

run buildall


Moved Python 3 version 3.4.0 to ID Python.Python.3.4.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Yeah, I don't know why GitHub wasn't detecting a merge conflict (it claimed this was one commit ahead of master). Closing...


Get content-length for Incoming HTTP2 Bodies

Update Body::content_length to return the content length of when Body::Kind is H2, instead of returning None. Kind::H2 also holds the value of the content-length header as well as the h2::RecvStream.
Closes: #1546

@joshleeb if you get a chance, can you include a commit to enable the corresponding checks in the tests from #1556?

Sorry, it seems github doesn't send notifications about rebased/ammended commits. I'll look now.

 Should be all fixed now 👍

Thanks!


PHOENIX-6337 : Bump default HBase version to 2.3.4

2nd commit is to be reverted after we have QA results available.

2nd commit is to be reverted after we have QA results available.

Relevant change for this PR: https://github.com/apache/phoenix/pull/1115/commits/bee4559a233f6a70be5834ef0a7f98a69c9842a8

Relevant change for this PR: https://github.com/apache/phoenix/pull/1115/commits/bee4559a233f6a70be5834ef0a7f98a69c9842a8

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
16m 19s
master passed

+0
hbaserecompile
23m 10s
HBase recompiled.

+1 :green_heart:
compile
1m 34s
master passed

+1 :green_heart:
javadoc
1m 28s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m 57s
the patch passed

+0
hbaserecompile
42m  2s
HBase recompiled.

+1 :green_heart:
compile
1m 29s
the patch passed

+1 :green_heart:
javac
1m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 19s
the patch passed

_ Other Tests _

-1 :x:
unit
105m 53s
root in the patch failed.

-1 :x:
asflicense
1m  2s
The patch generated 611 ASF License warnings.

155m 23s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1115

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux 71ce4f900b3f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / a737617

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
12925 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
16m 19s
master passed

+0
hbaserecompile
23m 10s
HBase recompiled.

+1 :green_heart:
compile
1m 34s
master passed

+1 :green_heart:
javadoc
1m 28s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
8m 57s
the patch passed

+0
hbaserecompile
42m  2s
HBase recompiled.

+1 :green_heart:
compile
1m 29s
the patch passed

+1 :green_heart:
javac
1m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
1m 19s
the patch passed

_ Other Tests _

-1 :x:
unit
105m 53s
root in the patch failed.

-1 :x:
asflicense
1m  2s
The patch generated 611 ASF License warnings.

155m 23s

Reason
Tests

Failed junit tests
phoenix.end2end.PermissionNSEnabledWithCustomAccessControllerIT

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1115

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux 71ce4f900b3f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / a737617

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
12925 (vs. ulimit of 30000)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
4m 42s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
11m 31s
master passed

+0
hbaserecompile
23m 18s
HBase recompiled.

+1 :green_heart:
compile
1m 45s
master passed

+1 :green_heart:
javadoc
2m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 52s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
9m  8s
the patch passed

+0
hbaserecompile
17m  0s
HBase recompiled.

+1 :green_heart:
compile
1m 42s
the patch passed

+1 :green_heart:
javac
1m 42s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
104m 34s
root in the patch failed.

-1 :x:
asflicense
2m 18s
The patch generated 618 ASF License warnings.

159m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1115

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux 1b9c3784c5aa 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 3092f46

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/2/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/2/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
13575 (vs. ulimit of 30000)

modules
C: phoenix-core phoenix-server . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/2/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
4m 42s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
11m 31s
master passed

+0
hbaserecompile
23m 18s
HBase recompiled.

+1 :green_heart:
compile
1m 45s
master passed

+1 :green_heart:
javadoc
2m 40s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 52s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
9m  8s
the patch passed

+0
hbaserecompile
17m  0s
HBase recompiled.

+1 :green_heart:
compile
1m 42s
the patch passed

+1 :green_heart:
javac
1m 42s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  5s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
104m 34s
root in the patch failed.

-1 :x:
asflicense
2m 18s
The patch generated 618 ASF License warnings.

159m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1115

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux 1b9c3784c5aa 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / 3092f46

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/2/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/2/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/2/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
13575 (vs. ulimit of 30000)

modules
C: phoenix-core phoenix-server . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1115/2/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Committed.
I have updated the commit message to match the updated ticket description,

Committed.
I have updated the commit message to match the updated ticket description,


Revert "Change the implementation of the priority queue to use a heap data structure"

Reverts CircuitVerse/CircuitVerse#3916
The older circuits made with delays breaks with the new queue implementation since the delays create a different resolution order.

@tachyons


[Installer] Load plugin files from path gems

Closes #5429 .
Because RubyGems doesn't know about path gems before we install, we need to manually load the plugin files for the path gems we're installing. This is basically copying the logic RG uses, but scoped only to those gems that we're entirely responsible for.

This ought to pass now

Fixed

@bundlerbot r+


outlier_detection: fix divide-by-zero in success rate processing.

Fixes oss-fuzz issue https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10812.
Risk Level: Low
Testing: Unit test and corpus entry added.
Signed-off-by: Harvey Tuch<EMAIL_ADDRESS>

I had a quick look around and didn't see anything scary, LMK if there is any code that you think is concerning.


[Bug] Cannot install @nxrocks/nx-flutter in PNPM

Plugin Name
@nxrocks/nx-flutter
Plugin Version
4.0.2
Nx Version
14.6.4
Expected Behaviour
Install latest nx-flutter with no problems
Actual Behaviour
➜ pnpm add --save-dev<EMAIL_ADDRESS> WARN  deprecated<EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
 WARN  deprecated<EMAIL_ADDRESS>Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
 ERR_PNPM_NO_MATCHING_VERSION  No matching version found for<EMAIL_ADDRESS>
The latest release of @nxrocks/common is "1.2.2".

If you need the full list of all 7 published versions run "$ pnpm view @nxrocks/common versions".
Progress: resolved 1224, reused 1223, downloaded 1, added 0

Steps to reproduce the behaviour

Create new workspace pnpm create nx-workspace
pnpm add -D<EMAIL_ADDRESS>

Hi @rubiagatra
Thanks for reporting this.
Under investigation on https://github.com/tinesoft/nxrocks/tree/fix/flutter-pnpm...

In the meantime, creating a .npmrc file in the root of your workspace, with strict-peer-dependencies set to false can help.
See https://pnpm.io/npmrc#strict-peer-dependencies for more info

I still can't install it @tinesoft with your suggestion. For now I only using Flutter CLI manually

Update:
I fixed the bug after updating Nx to v15.0.4, but the issue is back again after update to recent version of Nx.
So until they properly fix the problem, you can use this workaround:
in your package.json:
{
  "pnpm": {
    "peerDependencyRules": {
      "ignoreMissing": ["@nxrocks/common"]
    }
  }
}


support dash notation in cli parameters

load python script from stdin:
cq-server -

export box.py to stdout:
cq-server box.py -e -

load python script from stdin, export to stdout:
cq-server - -e -

fixed in d77aad2
only for output file - input is too complex for the user need (mainly because there is no directory and we need to deal with all places where the directory attribute is read.)


WIP - Add temporary code for field rename

This PR builds upon https://github.com/fabric8-services/fabric8-wit/pull/2330. I will update this PR once https://github.com/fabric8-services/fabric8-wit/pull/2330 is merged.
The PR -

Fixes tests in expression_compiler https://github.com/fabric8-services/fabric8-wit/pull/2333/commits/d0e6171f032a508c6dfe71a5fd1628c43722e34f

Skips full text search tests and tests that depend on database triggers https://github.com/fabric8-services/fabric8-wit/pull/2333/commits/08a84da3740c5ac874429245b0f8779f4cca781a
The full text search depends on the TSV which are not yet fixed and the IfModifiedSince tests depend on the triggers defined on work_item table. We have not yet fixed a database and it's causing test failures. I have created an issue for this https://github.com/fabric8-services/fabric8-wit/issues/2332.

Adds replaceFieldName (incoming/request workitem payload) and addFieldName (outgoing/response payload) with tests https://github.com/fabric8-services/fabric8-wit/pull/2333/commits/99154fc602ccc49d45b6d15f293424f816535a4f
The request and response payload for /workitem(s) endpoint has changed

Updates all the Golden Files https://github.com/fabric8-services/fabric8-wit/pull/2333/commits/31d7ccf5e8be9b64cfda0135c3a698ab3c610ac1

[test]


chromium.inc: update DEPENDS

The gypi file for this recipe explicitly requests that xkbcommon be used,
therefore adding a dependency on it.
Signed-off-by: Trevor Woerner<EMAIL_ADDRESS>

Thanks for the patch. We already have this dependency for Wayland builds, set by CHROMIUM_WAYLAND_DEPENDS. Isn't libxkbcommon automatically pulled in by having x11 in DISTRO_FEATURES?
If we need this for x11 based builds as well, the patch should remove libxkbcommon from the CHROMIUM_WAYLAND_DEPENDS.

Hi Zoltan, thanks for the feedback!
I see what you mean with the wayland builds. I stumbled upon this a while back, I was doing x11 builds and going through cycles of deleting sstate and tmp then just bitbaking chromium by itself. I'll do some more testing to confirm and get back to you either way.

I've just completed a bunch of tests and here's what I found: I can't reproduce this error when building with the RPB (and swapping out its meta-browser for the LHG one), but if I do a build using the minimum layers required and nodistro, then this dependency issue shows up even when "x11" is in DISTRO_FEATURES. In all tests I'm only doing x11 builds (i.e. not wayland builds) and, starting from scratch, I'm only building the chromium target (i.e. not an image that includes chromium).
So it's up to you. If anyone is using this layer on their own they might see the problem. but even at that the chances are low since most will probably be building an image and xkbcommon will probably be built as part of the image. I just had a weird use-case.

We are not doing X11 based builds, but I'm happy to get that fixed. On the other hand, libxkbcommon needs to be than removed from CHROMIUM_WAYLAND_DEPENDS.


bug: Undo/redo messages, yank summaries, and other reports are shown as errors

Did you check docs and existing issues?

[X] I have read all the noice.nvim docs
[X] I have updated the plugin to the latest version before submitting this issue
[X] I have searched the existing issues of noice.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
0.10.2
Operating system/version
14.7
Describe the bug
I'm not sure why this is happening. I can't find a filter to turn these off, and I'd rather just redirect them to standard messages to appear in the mini view.

Steps To Reproduce
No one else is complaining about this so I assume it's a package comflict, or a setting I have turned on. However I'm not sure where to start debugging this.
Expected Behavior
Reports and undo/redo summaries would appear in the default message view.
Repro
Noice config:

require("noice").setup({
    lsp = {
        -- override markdown rendering so that **cmp** and other plugins use **Treesitter**
        override = {
            ["vim.lsp.util.convert_input_to_markdown_lines"] = true,
            ["vim.lsp.util.stylize_markdown"] = true,
            ["cmp.entry.get_documentation"] = true -- requires hrsh7th/nvim-cmp
        }
    },
    presets = {
        bottom_search = false, -- use a classic bottom cmdline for search
        command_palette = true, -- position the cmdline and popupmenu together
        long_message_to_split = true, -- long messages will be sent to a split
        inc_rename = true, -- enables an input dialog for inc-rename.nvim
        lsp_doc_border = true -- add a border to hover docs and signature help
    },
    messages = {
        enabled = true, -- enables the Noice messages UI
        view = "mini", -- default view for messages
        view_error = "notify", -- view for errors
        view_warn = "notify", -- view for warnings
        view_history = "messages", -- view for :messages
        view_search = "virtualtext", -- view for search count messages. Set to `false` to disable
    },
    cmdline = {
        enabled = true, -- enables the Noice cmdline UI
        view = "cmdline_input2", -- view for rendering the cmdline. Change to `cmdline` to get a classic cmdline at the bottom
        opts = {}, -- global options for the cmdline. See section on views
        ---@type table<string, CmdlineFormat>
        format = {
            -- conceal: (default=true) This will hide the text in the cmdline that matches the pattern.
            -- view: (default is cmdline view)
            -- opts: any options passed to the view
            -- icon_hl_group: optional hl_group for the icon
            -- title: set to anything or empty string to hide
            cmdline = {pattern = "^:", icon = "", lang = "vim"},
            search_down = {
                kind = "search",
                pattern = "^/",
                icon = " ",
                lang = "regex"
            },
            search_up = {
                kind = "search",
                pattern = "^%?",
                icon = " ",
                lang = "regex"
            },
            filter = {pattern = "^:%s*!", icon = "$", lang = "bash"},
            lua = {
                pattern = {"^:%s*lua%s+", "^:%s*lua%s*=%s*", "^:%s*=%s*"},
                icon = "",
                lang = "lua"
            },
            help = {pattern = "^:%s*he?l?p?%s+", icon = ""},
            input = {view = "cmdline_input", icon = "󰥻 "} -- Used by input()
            -- lua = false, -- to disable a format, set to `false`
        }
    },
    views = {
        cmdline_input2 = {
            view = "cmdline_popup",
            position = {row = -3, col = "50%"},
            border = {style = "rounded", padding = {0, 1}}
        },
        notice = {
            backend = "popup",
            relative = "editor",
            focusable = false,
            align = "center",
            enter = false,
            zindex = 210,
            format = {"{confirm}"},
            position = {row = -3, col = "50%"},
            size = "auto",
            border = {style = "rounded", padding = {0, 1}},
            win_options = {
                winhighlight = {
                    Normal = "NoiceConfirm",
                    FloatBorder = "NoiceConfirmBorder"
                },
                winbar = "",
                foldenable = false
            }
        }
    },
    routes = {
        {view = "notice", filter = {event = "msg_showmode"}},

         -- my attempt at fixing the problem
        {
            filter = {event = "msg_show", kind = "", find = "before"},
            opts = {skip = true}
        }, {
            filter = {event = "msg_show", kind = "", find = "after"},
            opts = {skip = true}
        }
    },
    notify = {enabled = true, view = "notify"}
})

that';s a known Neovim issue in some versions.

@folke do you know which versions? I'm running @latest - NVIM v0.10.2


The engine "node" is incompatible with this module. Expected version "^8.4.0". (yarn install)

I'm using node 9.11.1, but your package.json only allows node 8.x
https://github.com/zzarcon/react-circle/blob/57bb4d19df08b739017ce98c3a634ce91da0b596/package.json#L10

Good one! Do you mind opening a PR with the change? I'd more than happy to merge it 🚀

Please also publish to npm. Right now it seems to be the old version

@thebarty published in 1.0.3 🎉

THANKS MAN!!!!! GREAT STUFF! 👍


Proposed Field Name, SpecialAccommodations

SpecialAccommodations
Special accommodations the household will require.
Source: Samuel Kelsey

Will not fix.


New method SpaceComponent.GetCenter()

This method gets the center position of the space component instead of its top-left point.
The go idiomatic way would be to rename Center(p) to SetCenter(p) and GetCenter() to Center(). But since that change would break backwards-compability I went for GetCenter() as the new method name.
If you would like the methods to be renamed to SetCenter(p) and Center() I can change the commit accordingly. As a first time contributor I think it is not up to me to decide whether or not a change like this should break backwards-compability. :)

Will repost this with own branch instead of using master branch.


EatonForeseer TemplateSpec Solution --Do not merge as 1P solution

Change(s):
See guidance below
Reason for Change(s):
This PR is part of template spec solution migration for solution EatonForeseer.
See guidance below
Version Updated:
2.0.0
Required only for Detections/Analytic Rule templates
See guidance below
Testing Completed:
The link for test results is -
https://microsoftapc.sharepoint.com/:w:/r/teams/SentinelCATTeam/_layouts/15/Doc.aspx?sourcedoc={5115B984-7AA2-440B-BDB4-380B7E48DA23}&file=Sentinel Solution Migration -TemplateSpec - Eaton Foreseer.docx&action=default&mobileredirect=true&share=IQGEuRVRonoLRL20OAt-SNojAaaiwJ1sSWN4U_6yh4hwTfU
See guidance below
This is a 1P solution.

all seems ok need to merge

Hi @v-laanjana
Can you please get confirmation on this PR merging or closing and act accordingly.
Thanks

@v-sabiraj Please look into this. Thanks


test: Add test_cross_product_parallelism.test_slow from duckdb

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
Checklist

[x] I have written necessary rustdoc comments
[x] I have added necessary unit tests and integration tests
[x] All checks passed in ./risedev check (or alias, ./risedev c)

@mergifyio requeue

@Mergifyio requeue


from_json seems not to work for empty datasets

If I dump a collection, in which one of the datasets has zero entries, The from_json will throw an error.

Solution might be to just ignore empty datasets in the dump function. Then we will never have the problem of loading datasets without entries.


Update Jenkinsfile adding some comment in jenkinsfile

adding the comments

Can one of the admins verify this patch?


Cat photo app step 14 has a typo

Step 14 of Cat Photo App in RWD, and also the Cat Photo App workshop in the new cert have a typo:

It should be "attribute" instead

can i work on this issue?

/avneets0419

@Agung1606 @avneets0419 Thank you for your interest in contributing.
We typically do not assign issues. Instead, we accept the first pull request that comprehensively solves the issue.
Issues labeled with help wanted or first timers only are open for contributions.
Please make sure you read our guidelines for contributing. We prioritize contributors following the instructions in our guide. Join us in our chat room or the forum if you need help contributing - our community will be happy to assist you.


nbsphinx_custom_formats: proper handling of strings

This was broken before because strings are sequences!

Why not just add a check for strings like not isinstance(convertor, str)? This restricts the convertor to being a list/tuple and a convertor implementing Sequence protocol might be skipped.

I didn't really like the complicated if-condition.
But I guess you are right, it's better to allow Sequence and make sure it's not str.
I've updated this PR: c31716d48a794bce30dfd782ad54038061586412

Feel free to cherry pick my PR to use collections.abc .

I've just merged your PR and re-based this one.

Given that str was previously allowed it could be an incompatible change based on the API usage. I will leave it up to you to decide on tests, changelog.

str was previously allowed it could be an incompatible change based on the API usage.

It was indeed allowed, but it wasn't possible to provide a valid string value.
Only two-element sequences were allowed, e.g. 'xy', but the second element was then used as **kwargs, which would have raised an exception.
So there is no previously successful usage that's now impossible.
In this sense it's not an incompatible change.
Only if you relied on having an exception raised when passing a string. Which you shouldn't have.

I will leave it up to you to decide on tests

Well tests would be great of course (then I would have spotted this in the first place), but currently there are none for this case ...


poetry2nix: cross fixes

Motivation for this change
Make poetry2nix builds work when cross compiling.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS (x86_64 -> armv7)
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This should go to the poetry2nix upstream at https://github.com/nix-community/poetry2nix as explained in https://github.com/NixOS/nixpkgs/blob/2240f37a107fbb9e24c8508d604010027dc5d21d/pkgs/development/tools/poetry2nix/poetry2nix/README.md.
If you make a PR against the proper upstream I'll make sure to get it merged and into nixpkgs quickly.

@adisbladis Oh I see, I'll relocate the pr.
ps. Might be a good idea to add a header to these files, a bit more discoverable than a burried readme.