[Enhancement]: Enabling cube rotation via 'right-click-drag' # 277

Description
I have added a listener for the right mouse down.
This now detects mouse downs by the right click and handles them as desired.
The functionality for the left is left untouched.
Fixes:  #277

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x ] I have made this from my own
[ ] I have taken help from some online resourses
[ ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x ] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK (if applicable)

Hi @Aaryan-Ajith-Dev
Thank you for your effort. However, your current code does not fulfill the requirement of enabling cube rotation via 'right-click-drag'. Specifically, it only allows the cube rotation to be initiated with the left mouse button. Could you please revise it to enable rotation with the right mouse button as well?

https://github.com/Dev-tanay/Rubik-Cube/assets/117074091/f1fad487-5458-4883-8ac6-4cff6229266d
I apologize for the oversight @Dev-tanay.
I have attached a small video file for how it was working for me (in my branch), and I had committed the same.
Thank you for your time


Add support for scheduled weight decays in RectifiedAdam.

RAdam implements weight decay based on AdamW, and the latter supports scheduling for both learning rate and weight decays.
This patch extends existing support of Keras schedulers for the learning rate to weight decay, matching the weight decay features of AdamW.
Related issue: https://github.com/tensorflow/addons/issues/1908

@cyberzhg
You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.


Allow pulling images from private repositories

I am testing kitematic out for our DevOps group. I am trying to pull from our private repo one of the containers but it says "Cannot find a matching image". I know the image is correct because I copy/pasted from our running container in our QA environment.
sad face

+1 You'll need to add support for logging in to Docker Hub and seeing private repos there.

I am facing this same issue.  We're implementing a docker development workflow at our company and this tool would be a godsend, however I'm unable to see my private dockerhub repos so it won't work for us right now.
I have to say brilliant app.  I'm loving using it apart from the private repo issue.

Unfortunately, without the ability to log in and pull private repos, I'll have to hold off on really testing this out.

The ability to use private repos would be a very important addition. Perhaps you could point out where that would be done, and we could contribute that portion?

@mgmonteleone I think maybe here https://github.com/kitematic/kitematic/blob/master/src/Registry.js

How about supporting a list of repos that should be searched (dockerhub being the default). Then have something in the UI to differentiate which repo it came from?

Hey all - thanks for the issue and feedback.
This feature is heavily WIP by the team, but first needs the ability to login / signup.
Once that's done this should be relatively straightforward via Registry.js. Keep an eye out for work around login / signup.

This doesn't rely on login / signup for our internal repository, since it's locked down by LDAP credentials. All we need is the ability to enter the container name just like we do on command line docker:
docker pull artifactory.cobalt.com/hyde

Allowing us to enter it in the search bar would un-block our in house use of kitematic.  Searching & browsing the in-house repository would be nice, but they can wait on a future release (along with login)

In the meantime, you can do so with the command line provided by Kitematic ( docker icon in left down corner of the window). You run 'docker login', enter your credentials and after you can pull and run containers from your private repo. You can manage the running containers from the Kitematic UI.

bump

this feature would help a lot +1.

It's our highest priority feature!

I know you guys are busy but it doesn't seem like it is to me.
Anyone know where this is on the roadmap? I'm trying to get the team on board with Docker (they're Sys. Admins and Engineers, not devs) and this would really help.

+1

+1 for being able add private insecure registries

+1 for allowing private registries

Looking at the above 'pool' of test users, can some of you QA this PR?
https://github.com/kitematic/kitematic/pull/1076
It should add support within the preference panel for any repo link. Only downfall is that if the repo isn't valid/online it will currently prevent Kitematic from loading properly.
I don't know if there's a way to test the repo and confirm it's a proper docker repo? Any feedback/input welcome :D

PR https://github.com/kitematic/kitematic/pull/1076 has been updated to add a private repo test, so that Kitematic has a valid repo to use/work from.

What's holding back on this? Is it because dockertoolbox should generate $$ for dockerhub - and dockerhub only?

@davidkarlsen A lot of moving parts not at all related with $$  - Please see https://github.com/kitematic/kitematic/issues/210#issuecomment-156252142 for details.
Closing in favor of #210


Call the registration API from the identity web app

Current status: early draft. This needs some comments and tidy-up and maybe some testing; for now I wanted to get an end-to-end flow working. I can see it hitting the identity API endpoint and returning a known error which should be fixed once https://github.com/wellcomecollection/identity/pull/348/ is deployed, so I think it's close to working.
Who is this for?
New members!
What is it doing for them?
Making sure they can complete the sign-up flow.

I think this is good enough to be reviewed.
It'd be nice to get some tests on the registration API endpoint, but there aren't any existing tests and we also have protection in the identity API itself. I'd like to push on with getting the full end-to-end flow working before I come back to write a new test framework.


ValidationSummary doesn't display property errors if ModelState and M…

…odelMetadata meets the specific conditions #4831
Hi @dougbu
I removed test which is naming conflicts.
and closing #7221 PR

Thanks @kishanAnem


KAFKA-13103: add REBALANCE_IN_PROGRESS error as retriable error

Add REBALANCE_IN_PROGRESS error as retriable error for all group API handlers in KIP-699, and tests for it.

AlterConsumerGroupOffsetsHandler
DeleteConsumerGroupOffsetsHandler
DeleteConsumerGroupsHandler
DescribeConsumerGroupsHandler
ListConsumerGroupOffsetsHandler
RemoveMembersFromConsumerGroupHandler

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@dajac @rajinisivaram , please take a look. Thank you.

@dajac , sorry, I might misunderstand the ticket. So we just change for AlterConsumerGroupOffsetsHandler only, is that right? I mean, if we just wanted to change the REBALANCE_IN_PROGRESS error.

I haven't checked the handlers so I don't know :). We need to check where REBALANCE_IN_PROGRESS is actually expected and decide if making it retryable make sense.

Yes, you're right. We have handled all kinds of expected errors in previous PRs. So, we should only update for AlterConsumerGroupOffsetsHandler here, unless we also want to put GROUP_AUTHORIZATION_FAILED into retriable error (but I don't think that makes sense, though).
I've updated the PR. Thank you.

@dajac , could you help take a look at this PR? Also, do we want to put this PR into v3.0? Thank you.

excuse me for the delay

Never mind! :)
And thanks for the comment. I've updated the PR. Thank you.

@dajac , thanks for the comment. I've updated the PR. Thanks.

@dajac , I think this PR is good to get merged. WDYT?
Failed tests are unrelated. Thanks.
    Build / JDK 11 and Scala 2.13 / kafka.network.DynamicConnectionQuotaTest.testDynamicListenerConnectionCreationRateQuota()
    Build / JDK 8 and Scala 2.12 / org.apache.kafka.streams.integration.StoreQueryIntegrationTest.shouldQueryStoresAfterAddingAndRemovingStreamThread

@showuon Yes. Could you update the description of the PR to reflect what has been done? The description is outdated. I will merge it after.

Thanks for reminding. Updated. Thank you.


Add: the 'isolation' CSS property

CSS isolation property allows to isolate groups of elements from their deeper background and to blend their background color together, useful in conjunction with background-blend-mode.
at present time it is a Candidate Recommendation
https://drafts.fxtf.org/compositing-1/#isolation

:+1:

+1

+1

+1

+1

+1

Now available at https://caniuse.com/#feat=mdn-css_properties_isolation


Can not access the website of Qiita

Can not access https://qiita.ucsd.edu/ or download anything from Qiita.

Hi @wxgao33, the system is back online, there was a network issue that has been resolved. Best


Replace trace ID with latency in trace list

closes: #154

looking good! I know tab is reserved for moving to other signals.. not in this change, but I wonder if we can do like ctrl+s or some other thing to toggle which column to sort by

Thanks! ah, sorting feature is tracked in #18 👍
I've received some suggestions to sort by span latency, I'm planning to work on it soon.


[GHSA-4vhf-2hv7-8mrx] Improper Restriction of XML External Entity Reference in Apache ActiveMQ

Updates

Affected products
References
Source code location

Comments
Add a patch https://github.com/apache/activemq/commit/b9696ac80bb496b52d05c3884f81b0746d9af9e2, of which the commit message claims https://issues.apache.org/jira/browse/AMQ-5333 - make xpath parser features configurable, same with the msg of current patch commit.

The vulnerability in GHSA-4vhf-2hv7-8mrx was fixed in 5.10.1. The commit for the 5.10 branch is https://github.com/apache/activemq/commit/3e5ac6326db59f524a0e71f6b717428607d7b67d. Since https://github.com/apache/activemq/commit/b9696ac80bb496b52d05c3884f81b0746d9af9e2 addresses later branches that can be assumed to have the fix, the additional commit is unnecessary.


fix: battling cypress' dashboard feature

Following up on a series of PRs to try and fix cypress run, latest being this one https://github.com/apache/superset/pull/30430.
Here I'm working a bit in the dark since the logic on master in CI is slightly different from the logic in PRs.
On my latest try, I had an error related to a combination of retries in the context where the dashboard is used. Issue was around the group id's not being unique. Here I'm working around it by adding the attempt number to the group's id, which should fix it.
At this point I'm beyond annoyed with Cypress. Last try before I shut down using the dashboard feature (a paying service we don't really get much if any benefit from) at all.
Previous error for reference:

This ran as expected except all 5 retries ran and failed, trying to break down nativeFilters.test.ts into 2 files... hopefully the second test group doesn't depend on the first one...

At this point I'm beyond annoyed with Cypress. Last try before I shut down using the dashboard feature (a paying service we don't really get much if any benefit from) at all.

OK THIS IS IT! The CYPRESS SAGA IS OVER. MERGE! MERGE! MERGE! MERGE!


runelite: 2.0.0 -> 2.1.5

Updates runelite from 2.0.0 to 2.1.5. Also fixes https://github.com/NixOS/nixpkgs/issues/123827

@ofborg eval

@GrahamcOfBorg eval

Result of nixpkgs-review pr 124427 at 7f4b2e2c run on x86_64-linux 1

1 package built successfully:

runelite

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/games/runelite/default.nix:29:3:
   |
29 |   installPhase = ''
   |   ^


Persist Tornjak Database between restarts.

Tornjak database that stores cluster information should be persisted in persistent storage, the same as SPIRE does it, so the information is not deleted every time we restart Tornjak service (Tornjak container)

We are able to demonstrate this with #141 ! Thank you @mrsabath


Middle Element of an Array

Description 📜
A C program where user can find the middle elements of a "n" size array.

Domain of Contribution 📊

[x] C/CPP

/assign

/assign

Hey! I want to work on this issue.


Toolbar: Add Toolbar component

Toolbar: Add Toolbar component

This update adds a new Toolbar component, which is used to provide a
UI container for an array of actions or items.
The Toolbar is pretty versatile, and comes with a couple of theme
and placement options.
Resolves: https://github.com/helpscout/blue/issues/139

Changes Unknown when pulling fda1f30f9fbe67d8263ab5ee37cab39081860fc1 on Toolbar/add into ** on master**.

Changes Unknown when pulling e3a9a75009665d9deb5a3bbd5e71103eed11630f on Toolbar/add into ** on master**.


Scatterplots w/ sprites

Is it possible to change scatterplot markers to that they "look" like they're a 2D point (e.g., a flat plane that always faces the camera no matter the orientation).
E.g., this is the default behavior in matlab, so I think a lot of people will have this in mind when they look at the scatter function here:
https://www.mathworks.com/help/matlab/ref/scatter3.html?requestedDomain=www.mathworks.com

Yes, it's been on my TODO list for quite a while, it's called sprites, thanks for opening this. It should also give a better performance for many points, say in the order of 10^6.

Please also add opacity support; when plotting large numbers of points being able to alter the blend factors is huge.  (Came here to file that bug, actually.)

I'd be happy to try implementing this if  you can give me a few hints of where to start.

This is implemented, see referred PR's


Question modbus address

Hello Martin,
I am very interested in you plugin. Could you please tell me what line is the modbus address of the inverter please ?
Because I think this is the reason why it is not working here. My solax address is 3, not 1.
Today I turnaround using solax modbus integration in Home Assistant. The inverter is connected with RS485 cable to a N510 USR in TCP.
Thank you for you kind help,
Best regards,
JFH

I have just added Unit ID as a standard parameter of the plugin. Please try it and let me know if it helps.
Martin

Oh no, in the end that was not the problem.
Though I see when connecting to the N510 : CONNECTED (2). So it connects but gets wrong answer I believe.
Here are domoticz logs :
2024-08-02 13:29:29.021 solax G4 Hybrid: Pushing 'onHeartbeatCallback' on to queue
2024-08-02 13:29:29.072 solax G4 Hybrid: Processing 'onHeartbeatCallback' message
2024-08-02 13:29:29.072 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:29:29.072 solax G4 Hybrid: Calling message handler 'onHeartbeat' on 'module' type object.
2024-08-02 13:29:29.072 solax G4 Hybrid: onHeartbeat
2024-08-02 13:29:29.072 solax G4 Hybrid: Connecting to: <IP_ADDRESS>:502
2024-08-02 13:29:32.074 solax G4 Hybrid: Modbus Error: [Input/Output] Modbus Error: [Invalid Message] No response received, expected at least 8 bytes (0 received)
2024-08-02 13:29:32.074 solax G4 Hybrid: Unable to read input registers.
2024-08-02 13:29:32.074 solax G4 Hybrid: Updating devices from Local array
2024-08-02 13:29:32.074 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:29:39.001 solax G4 Hybrid: Pushing 'onHeartbeatCallback' on to queue
2024-08-02 13:29:39.051 solax G4 Hybrid: Processing 'onHeartbeatCallback' message
2024-08-02 13:29:39.052 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:29:39.052 solax G4 Hybrid: Calling message handler 'onHeartbeat' on 'module' type object.
2024-08-02 13:29:39.052 solax G4 Hybrid: onHeartbeat
2024-08-02 13:29:39.052 solax G4 Hybrid: Connecting to: <IP_ADDRESS>:502
2024-08-02 13:29:42.056 solax G4 Hybrid: Modbus Error: [Input/Output] Modbus Error: [Invalid Message] No response received, expected at least 8 bytes (0 received)
2024-08-02 13:29:42.057 solax G4 Hybrid: Unable to read input registers.
2024-08-02 13:29:42.057 solax G4 Hybrid: Updating devices from Local array
2024-08-02 13:29:42.057 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:29:49.034 solax G4 Hybrid: Pushing 'onHeartbeatCallback' on to queue
2024-08-02 13:29:49.085 solax G4 Hybrid: Processing 'onHeartbeatCallback' message
2024-08-02 13:29:49.085 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:29:49.085 solax G4 Hybrid: Calling message handler 'onHeartbeat' on 'module' type object.
2024-08-02 13:29:49.085 solax G4 Hybrid: onHeartbeat
2024-08-02 13:29:49.085 solax G4 Hybrid: Connecting to: <IP_ADDRESS>:502
2024-08-02 13:29:52.090 solax G4 Hybrid: Modbus Error: [Input/Output] Modbus Error: [Invalid Message] No response received, expected at least 8 bytes (0 received)
2024-08-02 13:29:52.090 solax G4 Hybrid: Unable to read input registers.
2024-08-02 13:29:52.090 solax G4 Hybrid: Updating devices from Local array
2024-08-02 13:29:52.090 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:29:59.024 solax G4 Hybrid: Pushing 'onHeartbeatCallback' on to queue
2024-08-02 13:29:59.074 solax G4 Hybrid: Processing 'onHeartbeatCallback' message
2024-08-02 13:29:59.074 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:29:59.074 solax G4 Hybrid: Calling message handler 'onHeartbeat' on 'module' type object.
2024-08-02 13:29:59.074 solax G4 Hybrid: onHeartbeat
2024-08-02 13:29:59.074 solax G4 Hybrid: Connecting to: <IP_ADDRESS>:502
2024-08-02 13:30:02.078 solax G4 Hybrid: Modbus Error: [Input/Output] Modbus Error: [Invalid Message] No response received, expected at least 8 bytes (0 received)
2024-08-02 13:30:02.079 solax G4 Hybrid: Unable to read input registers.
2024-08-02 13:30:02.079 solax G4 Hybrid: Updating devices from Local array
2024-08-02 13:30:02.079 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:30:09.005 solax G4 Hybrid: Pushing 'onHeartbeatCallback' on to queue
2024-08-02 13:30:09.055 solax G4 Hybrid: Processing 'onHeartbeatCallback' message
2024-08-02 13:30:09.055 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:30:09.055 solax G4 Hybrid: Calling message handler 'onHeartbeat' on 'module' type object.
2024-08-02 13:30:09.056 solax G4 Hybrid: onHeartbeat
2024-08-02 13:30:09.056 solax G4 Hybrid: Connecting to: <IP_ADDRESS>:502
2024-08-02 13:30:12.060 solax G4 Hybrid: Modbus Error: [Input/Output] Modbus Error: [Invalid Message] No response received, expected at least 8 bytes (0 received)
2024-08-02 13:30:12.060 solax G4 Hybrid: Unable to read input registers.
2024-08-02 13:30:12.060 solax G4 Hybrid: Updating devices from Local array
2024-08-02 13:30:12.061 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:30:19.039 solax G4 Hybrid: Pushing 'onHeartbeatCallback' on to queue
2024-08-02 13:30:19.090 solax G4 Hybrid: Processing 'onHeartbeatCallback' message
2024-08-02 13:30:19.090 solax G4 Hybrid: Acquiring GIL for 'onHeartbeatCallback'
2024-08-02 13:30:19.090 solax G4 Hybrid: Calling message handler 'onHeartbeat' on 'module' type object.
Thank you for your help,
JFH

In fact inverter itself doesn't provide Mod-bus over TCP. There is converter for it anyway. The difference is in the model. I am using Solax one which is USB dongle with WiFi in my case.
The question is which functions are supported and how it is implemented in your one.
I see two possible root causes of your issue:

Problem with timing on Mod-bus. I have fond this commend in documentation: "The query cycle is expected to be controlled at about 1 second." May be there is some problem in the reading via RS-485 in terms of timeouts.
For reading all the data from the inverter I am using possibility to read more value in one reading cycles. In one of early version I read up to 200 registres in one read. Finally I recognized it is not stable. Sometimes it produce input/output errors and sometimes it caused that dongle stop to answer ModBus at all. In current version the function is different. There is loop which repeats more read cycles with smaller amount of data. It looks to me stable now ...but is valid for original Solax dongle.
Try to change the number of bytes in one cycle. It is in function updateDevices. Look for "inputRegisters = self.getInputRegisters(0, 290, 10)". Currently it reads 100 registers and request 10 registers per one red function.

Hopefully it helps.
Martin

I am having exactly the same issue as @jfh75, Modbus Error: [Input/Output] Modbus Error: [Invalid Message] No response received, expected at least 8 bytes (0 received), although I am connected over the com/lcd port with a waveshare RS485 to RJ45 Ethernet Module
@saidlm So should we try to increase/decrease the number of registers in the getInputRegisters, as for example using inputRegisters = self.getInputRegisters(0, 290, 20)? What range of values can we work with? Can you share some relevant modbus documentation? In my experience the solax dongle is unreliable, specially if the inverter is to be used for a performance critical operation, such as charging an EV in a solar mode, as per my separate post. I'm happy to report here my findings with the waveshare but I need to have something to work with. Please can you spend some time giving me some guidance? Thanks.

Really tiring to learn how modbus works...hats down to you guys
I've installed openmodscan and have successfully been able to connect with the waveshare using a length (number of registers read) of 10 as you have defined in the plugin

However the client.read_input_registers on this line always fails with the above error, no matter what combination of steps that I use (10, 1, 20, 50, 100)... I've also tried a start address of 1 instead of 0, still no luck...

Hi, I've just created a PR which should fix this issue. Let me know if it works. I had to fiddle around quite a bit until I finally found this comment which did the trick.

Thanks,
Martin


Minor refinements to question templates

1. Remove bottom padding from question_advice and hint fields
A padding-bottom of 10px was being added to markdown formatted
text which we don't really need because there's a padding-bottom
of 10px added to all paragraphs.
Removing the padding-bottom makes questions with both question_advice
and a hint look neater.
--> before

--> after

2. Preserve margins on validation messages
We were losing vertical margins on .validation-messages because the parent container wasn't expanding to account for them. Learn more about block formatting context (BFC). disclaimer: not that interesting
--> before

--> after

I'm not clear we do add 10px of padding-bottom to paragraphs. I can't find that in any of the CSS resets (for the buyers, suppliers or admin apps). There is a 1em margin in the default browser styles but we shouldn't rely on it.

padding-bottom: 10px; is applied to paragraphs in %markdown-description blocks (ie, question hints and question advice).  See here.

👍


Sticky Columns

Resolves https://github.com/giantswarm/giantswarm/issues/26553
Summary
There are situations where we want to keep dynamically imported data columns connected with manually edited columns in Google Spreadsheet sheets.
This PR solves that issue by introducing a set of functions that perform something akin to an SQL INNER JOIN, specifically  an equi-join using two ID columns.

@MarcelMue You can test the feature here: https://docs.google.com/spreadsheets/d/1JDLhxEnuOyP7uL6O4rrZ7FqK4rslJqmytJDMkWBvrGA
Ping me for an introduction or discussion.


Remove eshell obsolete variable

eshell-buffer-shorthand was removed in Emacs 25, see https://github.com/emacs-mirror/emacs/blob/master/etc/NEWS.25#L1078-L1082

Thanks!


Codify

I want to add a feature to help users automatically generate .go files from existing yaml files.
User Experience
I think we should have something like this:
cat deployment.yaml | naml codify > deployment.go
kubectl get po <name> -oyaml | naml codify > pod.go

Maybe also we can consider directories and more later. For now lets get the 1:1 things working and build out a system with the Go compiler to validate and format the code.

interested if anyone has any experience reports for 0.2.1

closed with #42


Added Support for All Joint Types

Patched back in coverage for ripping configurable, spring, character etc joints as they are used very frequently in any game utilizing rag dolls, etc...

Same case https://github.com/mafaca/UtinyRipper/pull/372

Just to explain what I mean. Every asset type should be able to read any version and it should support conversion from old to any new version. As an example see Mesh converter
https://github.com/mafaca/UtinyRipper/blob/master/uTinyRipperCore/Converters/Classes/Mesh/MeshConverter.cs
It is not enough to just implement reading for 2017 version

Just to explain what I mean. Every asset type should be able to read any version and it should support conversion from old to any new version. As an example see Mesh converter
https://github.com/mafaca/UtinyRipper/blob/master/uTinyRipperCore/Converters/Classes/Mesh/MeshConverter.cs
It is not enough to just implement reading for 2017 version

I found this code (somewhere I couldn't ever find it again for the pre-2017 version of unity joints and then reimplemented it for the post 2017 (as supported by your software) build.  I wish I could find who did the joint code from before as I owe it all to him or her, I will look through the mesh converter code for how you handle delineating versions though I was under the impression somewhere around 2017.3.7 ish they changed the asset format and other than that, things would just be supported as / when they are introduced, so basically anything crossing the 2017 formatting paradigm shift would need to be distinguished. I'm away from pc but I'll look through what you referenced thank you for your hard work on this great project hope I can help going forward


Inconsistent layout of buttons in Row widget android/linux/windows

Steps to reproduce

Include more than one button in a Row widget using mainAxisSize: MainAxisSize.min in an app.
Test the app on android/linux/windows. Macos/iOS untested.
The buttons in android will be nicely spaced with about 8dp (or whatever you call your spacing units) between them.
The buttons in linux/windows will be immediately adjacent, requiring the use of conditional Padding.

Expected results
I would expect the layout to be identical on all platforms.
Actual results
Inconsistent layout on different platforms.
Code sample
Code sample
                child: Row(
                  mainAxisSize: MainAxisSize.min,
                  children: [
                    Padding(
                      padding: EdgeInsets.only(
                        right: Platform.isWindows || Platform.isLinux ? 4 : 0),
                      child: IconButton(
                        icon: const Icon(Icons.add),
                        color: Colors.white,
                        style: ButtonStyle(
                          backgroundColor: const MaterialStatePropertyAll(
                            Colors.indigo),
                          shape: MaterialStatePropertyAll(
                            RoundedRectangleBorder(
                              borderRadius: BorderRadius.all(
                                Radius.circular(8),
                              ),
                            ),
                          ),
                        ),
                        onPressed: () {
                          zoomIn();
                          showZoomButtons();
                        },
                      ),
                    ),
                    Padding(
                      padding: EdgeInsets.only(
                        left: Platform.isWindows || Platform.isLinux ? 4 : 0),
                      child: IconButton(
                        icon: const Icon(Icons.remove),
                        color: Colors.white,
                        style: ButtonStyle(
                          backgroundColor: const MaterialStatePropertyAll(
                            Colors.indigo),
                          shape: MaterialStatePropertyAll(
                            RoundedRectangleBorder(
                              borderRadius: BorderRadius.all(
                                Radius.circular(8),
                              ),
                            ),
                          ),
                        ),
                        onPressed: () {
                          zoomOut();
                          showZoomButtons();
                        },
                      ),
                    ),
                  ],
                ),

Edit: The app is on https://github.com/billthefarmer/busapp

Screenshots or Video

Screenshots / Video demonstration

This is the android app with no padding. The linux/windows appearance is similar because of the conditional padding I have added.
Logs
Logs
N/A

Flutter Doctor output
Doctor output
$ flutter doctor -v
[√] Flutter (Channel stable, 3.19.0, on Microsoft Windows [Version 10.0.19045.4046], locale en-GB)
    • Flutter version 3.19.0 on channel stable at D:\adt\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision bae5e49bc2 (4 days ago), 2024-02-13 17:46:18 -0800
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at D:\adt\android-sdk-windows
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.8.4)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.8.34408.163
    • Windows 10 SDK version 10.0.22621.0

[√] Android Studio (version 2023.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)

[√] Connected device (4 available)
    • Moto G (mobile)   • TA93003J7P • android-arm    • Android 7.1.2 (API 25)
    • Windows (desktop) • windows    • windows-x64    • Microsoft Windows [Version 10.0.19045.4046]
    • Chrome (web)      • chrome     • web-javascript • Google Chrome 121.0.6167.161
    • Edge (web)        • edge       • web-javascript • Microsoft Edge 121.0.2277.112

[√] Network resources
    • All expected network resources are available.

• No issues found!

I've run into the same issue. It turns out that this is intentional—according to Material design specs, mobile apps should have a minimum tap target size of 48x48 dp.
If you want to make this consistent across devices, you can set the tapTargetSize as part of your button style (and unrelated, but you can use .styleFrom() and you won't need MaterialStateProperty classes):
IconButton(
  icon: const Icon(Icons.add),
  color: Colors.white,
  style: IconButton.styleFrom(
    backgroundColor: Colors.indigo,
    shape: const RoundedRectangleBorder(
      borderRadius: BorderRadius.all(Radius.circular(8)),
    ),
    padding: EdgeInsets.zero,
    tapTargetSize: MaterialTapTargetSize.padded,
  ),
),

Thanks for filing this @billthefarmer.
I can reproduce this on the latest master and stable channels without the conditional padding (reproduced this on macOS and iOS).

macOS
iOS

With the workaround shared here https://github.com/flutter/flutter/issues/143643#issuecomment-1951417350, I can't seem to reproduce this, can you try this out as well?

@nate-thegrate @dam-ease Yes, I've tried that and it works fine. Thank you.

Thanks for your response. Closing this as this is WAI


bug: Madara fails to sync block 20732 because of Legacy contract deserialization

Is there an existing issue?

[X] I have searched the existing issues

Description of bug
While trying to sync mainnet with Madara, I found that sync fails on block 20732 when it attempts to request class 0x371b5f7c5517d84205365a87f02dcef230efa7b4dd91a9e4ba7e04c5b69d69b.
Error (not very helpful):
The provider has returned an error: Error serializing request: invalid type: null, expected a sequence, retrying in 6s

Specifically, it fails when trying to convert to a LegacyContractClass via serde_json::from_value here.
If we print the value it's attempting to use, we see that it has a null for abi:
{"abi":null,"entry_points_by_type":{"CONSTRUCTOR" ...

Which I'm guessing is why it fails.
 Tell me if it works.

This PR should solve it #394. Tell me if it works.

Confirmed that it is fixed. Thanks!


Support for <3.11

Removed use of StrEnums to support earlier versions of python.

Can you remove the bug note from the documentation?

This is an interesting way to do it. The easier fix is to use the enum values rather than string values in create e.g. self.style == "default" becomes self.style == EmbedStyle.DEFAULT

This is an interesting way to do it. The easier fix is to use the enum values rather than string values in create e.g. self.style == "default" becomes self.style == EmbedStyle.DEFAULT

That's what it was originally lol. I thought I recalled someone complaining about doing it that way so I changed it to a string. Will change it back then.

Nevermind, I see what you mean.

This is an interesting way to do it. The easier fix is to use the enum values rather than string values in create e.g. self.style == "default" becomes self.style == EmbedStyle.DEFAULT

you know this would've been the smarter way to do it now that I think about it lmao


Cache some prepared statements

This reduces datastore CPU usage during puts.

https://ocd.appscale.com:8080/job/Daily Build/2852/

https://ocd.appscale.com:8080/job/Daily Build/2910/
The tools test failed when the machine rebooted.


Documentation for website developers?

Hi there :wave: long time fan of DuckDuckGo here & glad such an alternative to <the other search engine> exists.
My company uses Hubspot and recently started embedding various Hubspot forms & CTA widgets in our website. Several of our employees who use the DuckDuckGo privacy extension report issues with our website that ultimately end up being the result of the privacy extension blocking Hubspot content (including our company's main contact form).
Unfortunately, it seems the end result is only partially blocking the content (see example screenshot of a CTA button that is blocked by the DuckDuckGo privacy extension, though the underlying link itself is not blocked).

We would like to be a good citizen RE: privacy, so I'm sorta wondering if there's any documentation that either explains how to avoid having certain valid content blocked by the DuckDuckGo privacy extension -OR- how to model the objectionable content in such a way that DuckDuckGo will not display it at all (so we don't end up with partially rendered buttons).
Thanks in advance for your help!

This is a really great idea, thank you. I'll take it internally and see what people think.
It's a difficult problem to solve. Our clients use a block list that is derived from our monthly crawls. During these crawls, we monitor the activity initiated by third parties and look for whether they set cookies, access browser APIs known to be used for fingerprinting, and a variety of other "tracky" behaviors. Domains found to be engaging in an excessive amount of suspect activity are added to our block list. Here's an example of what we saw for the HubSpot domain hsforms.net during our last crawl.
Our goal is to stop as much tracking as possible without breaking the web. Unfortunately sometimes we end up blocking something that looks tracky but is essential to site functionality, which sounds like what you're seeing here.
I'd like to get this fixed for you. Could you please share a couple links to pages that we are breaking so I can debug what's going on and ship a fix?

Thank you for the very detailed and helpful response! I presumed that this would be a hard problem to solve since you can't exactly document how to work around the (helpful and appreciated!) privacy protections provided by this extension – it would defeat the purpose! 😄
I'm glad to know there may be some other way to resolve this issue though. The issues we're having are only related to the "essential site functionality", specifically including Hubspot buttons and forms on our site. I would hope that the other tracking capabilities of Hubspot (many of which we don't use, but can't disable without switching platforms) could be blocked for users who wish to do so without impacting forms and buttons.
Here's an example of an issue we're seeing: https://sensu.io/blog/filling-gaps-in-kubernetes-observability-with-the-sensu-kubernetes-events-integration
There's a button at the end of this blog post that is partially blocked. It is an embedded Hubspot button, so I suspect some javascript is being blocked that is preventing the correct styling of the button, but the underlying link element is still visible (and ugly). Let me know if this can be resolved in the extension, or if we need to take any action on our side to resolve it.
Cheers 🍻
PS – we had previously experienced some issues with Hubspot embedded forms on our site (sensu.io), but we are no longer able to reproduce those, so perhaps this has already been resolved on your end?


Update publications

Final checks are running and are expected to succeed, you can proceed with the review in the meantime.

Also a few other places:
https://github.com/JHUGen/JHUGen/blob/94beda0a5ba9f2aa986410ae9dab7d9f879e6fa3/Manual/manJHUGenerator.tex#L1568-L1569
https://github.com/JHUGen/JHUGen/blob/7e3a02c8b87c817858517c1167659b11eccf9b78/NOTICE#L8
https://github.com/JHUGen/JHUGen/blob/7e3a02c8b87c817858517c1167659b11eccf9b78/LICENSE#L188
https://github.com/JHUGen/JHUGenMELA/blob/36059e0567e5aa192bf78dc84a3a47afc0ffe1b1/NOTICE#L8
https://github.com/JHUGen/JHUGenMELA/blob/36059e0567e5aa192bf78dc84a3a47afc0ffe1b1/LICENSE#L188
https://github.com/JHUGen/JHUGen/blob/7e3a02c8b87c817858517c1167659b11eccf9b78/JHUGenerator/main.F90#L5

@gritsan, @TOPAZdevelop, @hroskes, @jdavis36,
Why are we quoting these papers everywhere? We should refer to the list of publications once and for all. I suggest that in all instances except the program printouts, the NOTICE is referenced explicitly, something like
'When you use this program, please cite the papers outlined in the NOTICE.'
Otherwise, I find this to be a very untenable approach.

This is now updated on the web page as well:
https://spin.pha.jhu.edu/NOTICE.txt
https://spin.pha.jhu.edu/LICENSE.txt
It is not a big deal if we do this once in several years.
For sure we should have this fully in the generator printout and in the manual.
The fact is that this is now in the NOTICE and LICENSE is a side effect of introducing those.
On Sep 29, 2020, at 10:14 AM, Ulascan Sarica <notifications<EMAIL_ADDRESS>wrote:
Also a few other places:
https://github.com/JHUGen/JHUGen/blob/94beda0a5ba9f2aa986410ae9dab7d9f879e6fa3/Manual/manJHUGenerator.tex#L1568-L1569https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJHUGen%2FJHUGen%2Fblob%2F94beda0a5ba9f2aa986410ae9dab7d9f879e6fa3%2FManual%2FmanJHUGenerator.tex%23L1568-L1569&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563890303&sdata=X6PNYS6J9Bd%2FGw2EchybwPr2mbQhpekU679q2mDvpl4%3D&reserved=0
https://github.com/JHUGen/JHUGen/blob/7e3a02c8b87c817858517c1167659b11eccf9b78/NOTICE#L8https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJHUGen%2FJHUGen%2Fblob%2F7e3a02c8b87c817858517c1167659b11eccf9b78%2FNOTICE%23L8&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563900295&sdata=0jSg7SAtS0IjQcmxKxENU2yJMFYwf4eIl3XC5nyjidc%3D&reserved=0
https://github.com/JHUGen/JHUGen/blob/7e3a02c8b87c817858517c1167659b11eccf9b78/LICENSE#L188https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJHUGen%2FJHUGen%2Fblob%2F7e3a02c8b87c817858517c1167659b11eccf9b78%2FLICENSE%23L188&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563900295&sdata=Mi7MpX7x4SAbbcjjTLgvrVrwl5cvx%2Fm3WQH%2BO6TFvzE%3D&reserved=0
https://github.com/JHUGen/JHUGenMELA/blob/36059e0567e5aa192bf78dc84a3a47afc0ffe1b1/NOTICE#L8https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJHUGen%2FJHUGenMELA%2Fblob%2F36059e0567e5aa192bf78dc84a3a47afc0ffe1b1%2FNOTICE%23L8&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563910295&sdata=2QSrU4YzmW2dgUUEMoEaI6RPLiqN732h7%2F5O%2B2YPShc%3D&reserved=0
https://github.com/JHUGen/JHUGenMELA/blob/36059e0567e5aa192bf78dc84a3a47afc0ffe1b1/LICENSE#L188https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJHUGen%2FJHUGenMELA%2Fblob%2F36059e0567e5aa192bf78dc84a3a47afc0ffe1b1%2FLICENSE%23L188&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563910295&sdata=M1DNwRBJl4Uj9spaHBHkf4YPsH0RRGZWn%2BnZy7ytu8M%3D&reserved=0
https://github.com/JHUGen/JHUGen/blob/7e3a02c8b87c817858517c1167659b11eccf9b78/JHUGenerator/main.F90#L5https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJHUGen%2FJHUGen%2Fblob%2F7e3a02c8b87c817858517c1167659b11eccf9b78%2FJHUGenerator%2Fmain.F90%23L5&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563910295&sdata=H%2BKOWUTF6%2FwQggZFarjMwtpi%2B71VPp9zQ3b0h0ZjuOM%3D&reserved=0
@gritsanhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgritsan&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563920288&sdata=Zs3I4Qt5PJxY2aNB%2BXSwEWN0VBddEf4%2FeORtk663gJY%3D&reserved=0, @TOPAZdevelophttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTOPAZdevelop&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563920288&sdata=t6G2ZTBClxfy85QGSItew%2BRqM2MZlkOj7WEY7EMxOjw%3D&reserved=0, @hroskeshttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhroskes&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563930276&sdata=hVvNhP%2FmUld9BojqQiKpE3gu0hmw3VrQ%2FeI2zMu%2Be2c%3D&reserved=0, @jdavis36https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjdavis36&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563930276&sdata=%2FIj5GQFqkM3r70ig%2BxhJGR%2FeTgIFHpEzVh0CNjnUfZw%3D&reserved=0,
Why are we quoting these papers everywhere? We should refer to the list of publications once and for all. I suggest that in all instances except the program printouts, the NOTICE is referenced explicitly, something like
'When you use this program, please cite the papers outlined in the NOTICE.'
Otherwise, I find this to be a very untenable approach.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJHUGen%2FJHUGen%2Fpull%2F161%23issuecomment-700733640&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563940280&sdata=30EpSM3C2bi9ahdjILevuLz7X5ch7LGDL0xi7M4N4mw%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADCHOBTMPUYQM3XLXTWOZEDSIHTTNANCNFSM4R5ML6IQ&data=02|01|gritsan%40jhu.edu|2762e2b7a2284cc19fb908d86481f29f|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369856563940280&sdata=Zjh8Gt%2F0hb8lPsei%2BOFjtbSF1c6i69W%2FlxgyYc1Sleo%3D&reserved=0.

This is now updated on the web page as well: https://spin.pha.jhu.edu/NOTICE.txt https://spin.pha.jhu.edu/LICENSE.txt It is not a big deal if we do this once in several years. For sure we should have this fully in the generator printout and in the manual. The fact is that this is now in the NOTICE and LICENSE is a side effect of introducing those.

It is a big deal when it consumes people's time unnecessarily.
I think duplicating the NOTICE in the LICENSE is not very helpful to begin with while one can simply refer to the NOTICE explicitly. For sure, quoting references in main.F90 comment lines is not very helpful either.

about duplication in the NOTICE and LICENSE, it is a good point where I also wanted to reduce duplication, see this update:
https://spin.pha.jhu.edu/LICENSE.txt
I would suggest to adopt this version of license in other places as well, and then we will not need to update it.
On Sep 29, 2020, at 10:39 AM, Ulascan Sarica<EMAIL_ADDRESS>wrote:
This is now updated on the web page as well: https://spin.pha.jhu.edu/NOTICE.txt https://spin.pha.jhu.edu/LICENSE.txt It is not a big deal if we do this once in several years. For sure we should have this fully in the generator printout and in the manual. The fact is that this is now in the NOTICE and LICENSE is a side effect of introducing those.
It is a big deal when it consumes people's time unnecessarily.
I think duplicating the NOTICE in the LICENSE is not very helpful to begin with while one can simply refer to the NOTICE explicitly. For sure, quoting references in main.F90 comment lines is not very helpful either.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJHUGen%2FJHUGen%2Fpull%2F161%23issuecomment-700750940&data=02|01|gritsan%40jhu.edu|f8589b3c1d8d4fbe81c508d864857fc4|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369871828095232&sdata=rghLS8r%2BO7fi6KENpRXX5TRXfoGqXtbTRWBMF%2BMhiZg%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADCHOBVKJY7X6KATPIH7MJLSIHWRDANCNFSM4R5ML6IQ&data=02|01|gritsan%40jhu.edu|f8589b3c1d8d4fbe81c508d864857fc4|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637369871828105227&sdata=LcRHL%2Bgc6r%2FQu%2BWGw3Csn7JgqOlX%2FMLjZ%2FaRUAs2n%2Bw%3D&reserved=0.

@gritsan Would you please check if the updated Web/index.html file is synced with what is on the webpage? This file needs to be kept up-to-date.

Hi Ulascan,
When we reference to NOTICE, the suggestion was to refer to the actual web location:
https://spin.pha.jhu.edu/NOTICE.txt
(this is on line 184 of LICENSE for example)
I know there is also LICENSE on Git, but this print statement will make it explicit.
I did not run the new version, so to make sure: When we run either JHUGen or MELA, do we keep the statement that
these papers (with explicit list of papers) should be cited? It looks like you removed this from the main.F90, which was
not the plan.
Andrei
On Oct 9, 2020, at 9:47 AM, Ulascan Sarica <notifications<EMAIL_ADDRESS>wrote:
@gritsanhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgritsan&data=02|01|gritsan%40jhu.edu|0b29f497483149c604da08d86c59eb9c|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637378480759045398&sdata=6GPhmN%2BPTw%2F4r6qH1VIUhjG9K97zkxQpFAtchAKiZBo%3D&reserved=0 Would you please check if the updated Web/index.html file is synced with what is on the webpage? This file needs to be kept up-to-date.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJHUGen%2FJHUGen%2Fpull%2F161%23issuecomment-706190808&data=02|01|gritsan%40jhu.edu|0b29f497483149c604da08d86c59eb9c|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637378480759055391&sdata=cm%2F%2F73bCXrA7oAr6GTbWfYPHkRxhwmG0S9SakDFvfik%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADCHOBSLTXPBGWWC3YS5F73SJ4IARANCNFSM4R5ML6IQ&data=02|01|gritsan%40jhu.edu|0b29f497483149c604da08d86c59eb9c|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637378480759055391&sdata=EKZFgv4%2BLODv7Qx%2Bl%2BHURLezkd3Z4anJhhAFOuN4MOI%3D&reserved=0.

Hi Ulascan, When we reference to NOTICE, the suggestion was to refer to the actual web location: https://spin.pha.jhu.edu/NOTICE.txt (this is on line 184 of LICENSE for example) I know there is also LICENSE on Git, but this print statement will make it explicit. I did not run the new version, so to make sure: When we run either JHUGen or MELA, do we keep the statement that these papers (with explicit list of papers) should be cited? It looks like you removed this from the main.F90, which was not the plan. Andrei

I think it is better if the notice is kept here. You can have a separate copy of it on the webpage.
Yes, the printouts are in mod_Misc.F90. The removed lines in main.F90 belong to code comments. We should not have our citations in code comments; there is no point to it (as we already discussed above).

@gritsan One more suggestion: Please reply using the web interface. I think you are replying via email, but we get a long list of safe links...

Since all required checks have passed, we are waiting for 2 people to approve per new rules.

We need one more approval/review.

72 hours passed. Is it possible to have another person's approval?

As I mentioned earlier, this was for our in-person (Zoom) discussion.
Andrei
On Oct 12, 2020, at 3:59 PM, Ulascan Sarica <notifications<EMAIL_ADDRESS>wrote:
72 hours passed. Is it possible to have another person's approval?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJHUGen%2FJHUGen%2Fpull%2F161%23issuecomment-707317462&data=02|01|gritsan%40jhu.edu|7c22a925656243faed9a08d86ee95ee8|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637381295880077803&sdata=8O8N%2F6jf%2BoirNkvDP4lxD%2BFb1aVNmQTmu408tMCQmIE%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FADCHOBU2EK2EREALU722EFLSKNN2JANCNFSM4R5ML6IQ&data=02|01|gritsan%40jhu.edu|7c22a925656243faed9a08d86ee95ee8|9fa4f438b1e6473b803f86f8aedf0dec|0|0|637381295880087800&sdata=flILJiroKmdffULO0sicbZQAW%2B4lXYWu4cQ5mw7cd3Y%3D&reserved=0.

@gritsan Ok, but can we make a practical step? Do you think you can submit a change request like Heshy did before?

(also pretty please use the web interface)

@gritsan Would you please remind what the pending issue on this PR is?


chore: switch tailwind to use px values

fixes #944

I have no idea how that works (I’m too dumb) and the answer is probably yes, but do we want a 2 year old dependency with 2 stars?
If not, we could also just do a search and replace for the values defined in the plugin:
https://github.com/rise8-us/tailwind-pixel-perfect-preset/blob/main/index.js#L1-L213
Anyway, I trust you, add whatever you think is best. 👍

Yes so the downside of using that unmaintained package is, if tailwind adds any more options they won't get converted right?
I thought they would just have had config option for this.
Two options:

keep the plugin, if it ever comes up that we need to add more values, open a PR
just copy the values into our theme config as stated in the tailwind recommended way

Its up to you!

Yeah I'm not sure if it's actually unmaintained or just they haven't needed to update anything in while because its just a fairly simple preset. I figure if we ever need to change it we can just bring the one file over to our repo and start managing it ourselves.
I don't love the way tailwind recommends because it would mean adding a couple hundred lines of (imo) boilerplate for what should probably be a single line config change. Using a preset makes it more or less a single line config change which can then be overridden by our tailwind file.

Cool! Thanks for the explanation 🙌


Add delete button to builds

To make it possible to remove builds that have been manually cancelled on jenkins

Issue migrated to our-city-app/plugin-mobicage-control-center#11


ICX, ADL: Release event updates

ICX

Add INT_MISC.CLEARS_COUNT, FP_ARITH_INST_RETIRED, and SQ_MISC.BUS_LOCK events.

ADL

Add BR_MISP_RETIRED.INDIRECT to GLC.
Add LD_HEAD.L1_MISS_AT_RET to GRT.

Thanks Ian. Sorry if some of these event updates intercept your mailing list submission process at inconvenient times.

No worries, I should have figured there were more coming from SPR update. Presumably TGL, RKL and ICL are pending?

For TGL and ICL (RKL) I currently see a description change in the release pipeline, but will verify if other changes are planned. SKL did have additional changes https://github.com/intel/perfmon/pull/59.


Feat: Workflow caching

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ci: fix update_version.py, make version.txt and version.py compatible

Fixes following up on https://github.com/EC-USGS/pywatershed/pull/206

Codecov Report

Merging #207 (35e5be6) into develop (2fd55cb) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##           develop     #207      +/-   ##
===========================================
- Coverage    79.55%   79.43%   -0.13%
===========================================
  Files           51       51
  Lines         6476     6466      -10
===========================================
- Hits          5152     5136      -16
- Misses        1324     1330       +6

Impacted Files
Coverage Δ

pywatershed/version.py
100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Portable binary with musl

Hello! Thank you for Nuitka!
Could you please advice what is the best way to make standalone binary with portable musl wich will work portable on Ubuntu and Alpine? I tried and looks like close to success.
Here is the example and additional questions below:

I build the xxh project (it hasn't any complex libs) with Nuitka:

docker run --rm -it -v `pwd`:/host alpine sh
apk add --update musl-dev gcc python3-dev py3-pip chrpath git
pip3 install -U "https://github.com/Nuitka/Nuitka/archive/factory.zip"
pip3 install pexpect pyyaml
git clone --depth 1 https://github.com/xxh/xxh
cd xxh
nuitka3 --python-flag=no_site --python-flag=no_warnings \
        --show-progress --standalone --follow-imports xxh

After it I have xxh.dist with ldd xxh on Alpine:

/lib/ld-musl-x86_64.so.1 (0x7f58f86fb000)
libpython3.8.so.1.0 => ./libpython3.8.so.1.0 (0x7f58f7a96000)
libc.musl-x86_64.so.1 => /lib/ld-musl-x86_64.so.1 (0x7f58f86fb000)

The app works perfect on Alpine.

Then I move it to Ubuntu and I've got ldd xxh:

linux-vdso.so.1 (0x00007ffeeedd9000)
libpython3.8.so.1.0 => /home/pc/xxh/xxh/xxh.dist/./libpython3.8.so.1.0 (0x00007efd2813c000)
libc.musl-x86_64.so.1 => not found
libc.musl-x86_64.so.1 => not found

When I copy libc.musl-x86_64.so.1 from Alpine to xxh.dist
I've got ldd xxh on Ubuntu:

linux-vdso.so.1 (0x00007ffce37ac000)
libpython3.8.so.1.0 => /home/pc/xxh/xxh/xxh.dist/./libpython3.8.so.1.0 (0x00007fbbf0df5000)
libc.musl-x86_64.so.1 => /home/pc/xxh/xxh/xxh.dist/./libc.musl-x86_64.so.1 (0x00007fbbf0d5f000)

Looks good, but not working:

ubuntu$ ./xxh
bash: ./xxh: No such file or directory

And only if I copy musl to /lib on Ubuntu I have success:

$ sudo cp libc.musl-x86_64.so.1 /lib/ld-musl-x86_64.so.1
$ ./xxh -V
0.6.0

If I open xxh binary in vim I see absolute path /lib/ld-musl-x86_64.so.1 and it looks like the cause why I should copy the musl to system lib directory.

A. Please advice what I can do to make musl portable with the app?
B. Is there a way to statically compile musl inside the app?
C. Is there a way to make one big static binary xxh file?
Musl is small and some projects use it instead of libc for creating static standalone apps. It will be great if Nuitka can do the same.
Many thanks to your work!

The glibc cannot be included, simply because it fails to work with older kernels. We therefore have code that specifically inhibits it.
I am not versed with muslc at all. Does it not have the same issue. Are you saying that there is a portable version of muslc and there is a trick to use it? Nuitka surely could change how to links and statically link that. Just let me know which flags you need to add for that to gcc and ld. You can export CCFLAGS= and LDFLAGS= and Nuitka will include it for your experimentation.

Nuitka surely could change how to links and statically link that. Just let me know which flags you need to add for that to gcc and ld. You can export CCFLAGS= and LDFLAGS= and Nuitka will include it for your experimentation.

Hello @romkatv! Could your experience of building zsh-bin with static musl be applied here?

You need to enable static linking. If you are using gcc, try LDFLAGS=-static.

Next steps. I've built static python as described in wiki and got libpython3.8.a. Next I tried to static build with LDFLAGS:
export LDFLAGS="-static -l:libpython3.8.a"
nuitka3 --python-flag=no_site --python-flag=no_warnings --show-progress \
        --standalone --follow-imports xxh

After this I've got xxh.dist with ldd xxh:
/lib/ld-musl-x86_64.so.1 (0x7f890d65e000)

It's better than before!
But

When I tried to run ./xxh I've got:

Traceback (most recent call last):
  File "/xxh/xxh.dist/xxh", line 5, in <module>
  File "/xxh/xxh.dist/xxh_xxh/xxh.py", line 1, in <module xxh_xxh.xxh>
  File "/xxh/xxh.dist/yaml/__init__.py", line 8, in <module yaml>
  File "/xxh/xxh.dist/yaml/loader.py", line 8, in <module yaml.loader>
  File "/xxh/xxh.dist/yaml/constructor.py", line 14, in <module yaml.constructor>
  File "/xxh/xxh.dist/datetime.py", line 8, in <module>
ImportError: Dynamic loading not supported

The musl still not statically linked.

Any thoughts are welcome.

I've edited my previous message. Statically linking was success!
@kayhayen could you please take a look on python traceback and my nuitka arguments?

I've got success!
  File "/xxh/xxh.dist/yaml/constructor.py", line 14, in <module yaml.constructor>
  File "/xxh/xxh.dist/datetime.py", line 8, in <module>

This error means that on line 8 in Python standard datetime.py file there is an import of module which not included to Python static while building.
To fix this:

Find datetime.py (/usr/lib/python3.8/datetime.py on Alpine) and get the module name from line 8 (it's math module)
Open Python3.8.2/Modules/Setup, search the module and uncomment:

math mathmodule.c _math.c

Rebuild static Python and copy to /usr/lib:

./configure LDFLAGS="-static" --disable-shared
make LDFLAGS="-static" LINKFORSHARED=" "
cp libpython3.8.a /usr/lib

Now try to rebuild app with Nuitka:

export LDFLAGS="-static -l:libpython3.8.a"
nuitka3 --python-flag=no_site --python-flag=no_warnings --show-progress \
        --standalone --follow-imports xxh

If you faced with error go to step 1 and repeat until getting all required modules to static Python
If you have success you've got the static linked binary of your app which portable on Alpine, Ubuntu, Arch, CentOS (I've tested):

alpine# ldd xxh.dist/xxh
/lib/ld-musl-x86_64.so.1 (0x7f890d65e000)
ubuntu# ldd xxh.dist/xxh
statically linked


fix(versions): update Activiti/activiti-cloud-notifications-graphql versions into master

UpdateBot pushed maven dependency: org.activiti.cloud.notifications.graphql:activiti-cloud-notifications-graphql-dependencies to: 7.1.151

UpdateBot commands:
updatebot push-version --kind maven org.activiti.cloud.notifications.graphql:activiti-cloud-notifications-graphql-dependencies 7.1.151


DacFx: Cannot include $node_id in an index

DacFx Version: SQL Server Data Tools 17.0.62203.25080
Environment: VisualStudio.17.Release/17.1.3+32328.378, Windows 11

Problem:
This syntax is invalid in Visual Studio right now.
(Note: this syntax is valid and works in SSMS just fine. )
CREATE INDEX IDX_MYINDEX
	ON graph.MYNODE (Column1) INCLUDE ($node_id)

Resulting error:

This syntax, however, is not invalid in Visual Studio right now.
CREATE INDEX IDX_MYINDEX
        ON graph.MYNODE ($node_id) INCLUDE (Column1)

Workaround: Run as string using EXEC(@SQL) in POSTPUBLISH script. Like this:
DECLARE @SQL VARCHAR(MAX) = '
IF NOT EXISTS (SELECT name FROM sysindexes WHERE name = ''IDX_MYINDEX'')
CRCREATE INDEX IDX_MYINDEX
	ON graph.MYNODE (Column1) INCLUDE ($node_id)'
EXEC(@SQL)

@llali @barbaravaldez kindly assign this as well to me. I have a fix well under way.

@llali @barbaravaldez kindly assign this as well to me. I have a fix well under way.

Thanks! items assigned.


Atom 1.6 Frequently Freezes with Remote Project Folders (All Platforms)

Description
Note - Title was edited to reflect that the issue is reported on all platforms, though the following report was originally for Ubuntu 14.04
Since updating to version 1.6.0 (from 1.5.4, where the problem didn't exist) Atom freezes when trying to open files in networked project folders (i.e. remote folders added to an Atom Project) which are connected via SFTP (edit: Confirmed to also occur on Samba, SSHFS, etc ). I have run Atom in safe mode and also tried 1.7 beta and had the same problem.  The networked folders are connected through the built-in "Connect to Server" feature in Ubuntu's Nautilus file browser.  Ubuntu 14.04 was the platform tested.
The Editor is not responding message appears after waiting for nearly thirty seconds, and choosing Keep Waiting sometimes unfreezes the window, though sometimes not. The problem happens again as soon as another file is selected from the project tree. Atom also commonly freezes when restarting the program with these project folders added, and if it does eventually unfreeze it will soon freeze again when trying to open a project file.
The problem occurs with linked folders on local virtual servers as well as remote servers, so high WAN latency does not appear to be the issue. Atom does not seem to have any CPU spikes during the freeze either as far as I can tell.
Steps to Reproduce

Mount a remote folder via SSH/SFTP in Ubuntu using its Nautilus file browser ('Connect to server' option).
Add the folder to an Atom project using the standard folder browser.
Once folder is added try to view folder structure or open a file in Atom's tree view.

Expected behavior:
Expected behavior is that the remote project folder operates identically to a local project folder.
Actual behavior:
Atom repeatedly freezes for an extended period of time when using the project tree viewer for remote folders and files.
Versions
Problem occurs in Atom 1.6.0 and later.  Problem did not exist in Atom 1.5.4.  Platform is Ubuntu 14.04 LTS.

I experience the exact same problem on Windows 10.
But instead of using Nautilus (duh), I'm using "SFTP Net Drive Free" to mount a folder of a local virtual machine (Debian Jessie) as a network drive.
Should I open a separate issue because of the different OS?

same issue here on archlinux, mouting folder throught sshfs, it freezes as soon as I try to open a file (but I can browse directories)

I have a very similar problem, Atom 1.6 randomly freezes when working on files on a Samba share on Windows 10.
I attached a screenshot where you can clearly see that the editor basically stops responsing for about 10 seconds.

I traced the bottleneck to

relativizeToWorkingDirectory (_path) {
return this.getRepo()
.then(repo => this.relativize(_path, repo.workdir()))
}

in src/git-repository-async.js (line ~165), which eventually leads to

function _tickCallback() {
...
}

In node.js, line ~335, whose executions lasts about 10 seconds. It's making the editor unusable, because I work on Samba shares. Is there a way to downgrade to 1.5 while this is taken care of?

@dborsatto The download page for all versions of 1.5.4, the latest release without this issue, is at:
https://github.com/atom/atom/releases/tag/v1.5.4
I cannot speak for the Windows version, but in Ubuntu I was able to uninstall 1.6.0 (without purging settings) and reinstall 1.5.4 without any settings or plugin conflicts occurring, but mileage may vary.

I am having the exact same issue as described here on OSX El Capitan (10.11.3) using a SMB file share as source folder  v.1.5.4 works without issue. Thanks @dborsatto for the v.1.5.4 link.

Confirmed, I am using 1.6.0 without any samba or sshfs shares and is doing the same thing. 1.6.0 is currently unusable.

I am having the same issue for SSHFS mounted folder. Previous release does not have this issue.

I can confirm the same issue happening on Fedora 23 while working with SMB.

same problem on mac OS X Yosemite 10.10.5 - gone back to 1.5.4

I have the same issue on OS X 10.11.4 working on a remote git project (mounted using SSHFS 2.5.0 and OSXFUSE 2.8.3). This bug makes Atom unusable. If a fix is not available very soon, version 1.6.0 should be pulled.

@Rondo5000 could you change the title? The issue is not related to SFTP only, from what I can gather it happens with every kind of network directory (SFTP, Samba, SSHFS etc).
I work with a Ubuntu VM guest as a local server, using Windows 10 as a host, and until now I used Samba to share a folder from inside my VM (I work with symlinks so I can't use NTFS) so I could access it from the host. I knew of performance issues with Git, that's why I can't use a GUI (like SourceTree or the recent GitKraken) because of unreasonable loading times, so until now I've stuck with command line via SSH, or using Ungit (which gets executed inside the server).
Now it sounds like whatever Atom was doing, it was more performant under these circumstances. If they won't find a fix, I'll either have to stick with 1.5.4, or I'll have to start using Sublime (please please please don't make me do that).

Same issue here on OS X El Capitan using SSHFS and Fuse. As I only work with remote drives, this makes atom unusable...

Exactly the same issue as @clovis... keeps freezing when using remote drives.

Same as @tshazar but on OS X Yosemite. Downgraded to 1.5.4

Same issue here. Downgraded to 1.5.4 and everything works fine again. No freezing/unresponsiveness. I am using Windows 10.

I can reproduce this issue every time and it is has made Atom unusable when trying to open any project using a mounted drive.
To quickly remedy the issue:

I dismount the drive
Kill Atom & Atom Helper
I rename ".git" in my project folder to just "git" so that atom will not read it.
Remount the drive
Open Atom back up and it seems to be working smoothly.

Somewhere it's reading .git and hanging. (regardless of git version or size of project)
OS: Mac 10.10.5
Atom: 1.6.0
SSHFS version 2.5 (OSXFUSE SSHFS 2.5.0)
OSXFUSE library version: FUSE 2.7.3 / OSXFUSE 2.8.2

Made some possible progress narrowing this down. I can reliably freeze a vanilla Electron app when reading directory entries from an SSHFS mount when capturing a timeline or profiling. I'm sure many people experiencing this issue were not recording a profile at the time, but I wonder if investigating the cause of that problem might lead to more insight into this problem.
Are people seeing this happen when expanding directories in the tree view? That would match up with where I'm seeing the lock-up occur with profiling enabled in my testing. What specific scenarios are causing freezes?

This happens randomly. Sometimes when navigating the tree view, sometimes saving a file, sometimes when idle.
Looking at the changelog, I honestly thought this problem was connected to the changes made to the underlying git engine, but I suppose I was wrong.

You might not be wrong, but I'm having a hard time inspecting what's happening due to the dev tools related lock ups. Has anyone had these lock ups in non-git folders?

@dborsatto How did you form your hypothesis about Git? I'd love to retrace your steps myself.

@nathansobo For me the freezing occurred whilst opening new (previous unopened) files or saving files with changes.
Downgraded to 1.5.4 and everything is working fine again.

Is it always happening when interacting with the tree view?

@nathansobo Well, I looked at the changelog and I saw this implementation switch: https://github.com/atom/atom/pull/9213
I've know for a while of git performance issues while working with remote project folders, so I made an educated guess, also confirmed by what @CDawg said on https://github.com/atom/atom/issues/11214#issuecomment-200474938
Of all the stuff that changed in 1.6, this seemed to me the one that most likely could be the culprit. Unless the problem is with a dependency, such as Electron itself, of course.

@nathansobo Just updated to 1.6.0 to check, it does not freeze on interaction with tree view. The only consistent freeze is when saving, most of the time.
Interesting behaviour is that I do get a freeze every time atom goes to the background (e.g. go to chrome to type this message) when I go back to atom it freezes on using the tree view.

So, with the help of @as-cii I'm pretty sure we've found the culprit. We took a process profile during a slow interaction and discovered that the majority of the time was being spent in node-git checking for ignored files. Our node-git-based AsyncRepository implementation is new as of 1.6 so this makes sense. I think our old implementation probably performed vastly fewer file system calls.

Sample of Atom Helper.txt
@joshaber could you take a look at the code paths involved here and see if we might apply some caching or some other technique to reduce the thrashing here?

@nathansobo This problem occurred for me when I tried interacting with the tree view (like clicking on files/folders). Also, if I try to 'Add Project Folder' to view in the tree view, Atom will freeze up.

@nathansobo Ha, so that stack trace is actually git-utils, not async git. So that hasn't changed. It doesn't look terribly suspicious. Just the callstack for git_ignore_path_is_ignored.
One theory I had is that since async git is ... async ... we could be hitting the FS in parallel a lot more than we did before, leading to more disk contention, which network file systems might not handle so well.

i have the same issue i think: 5-10sec freeze everytime i refocus on the atom-window

im on windows 10
my projects are mounted via samba (from virtualbox linux-guest)
i dont have the problem with 1.5.3

Just wanted to note that this seems to be a very similar issue (duplicate?) of #1766 .
In that issue I confirmed that Atom's Git implementation is scanning and reading every file in the project (using ~26 lstat and open calls for each file) and doing this every time Atom is brought to the foreground, a process that may take many minutes depending on the network speed and project size. Additionally, these check cycles seem to get queued up and my run one after another, leading to even longer periods of contention.

We're getting traction on this, but anyone using network mounts should fall back to 1.5.x and disable automatic updates until this is resolved.

@adamfranco woah, that certainly is a lot of calls! Why so many?

I also have this issue, but I'm still on 1.2.4.. I wonder why auto-update didn't work. :P
Anyway, I'll upgrade to 1.5.4 until the issue is resolved.

@dborsatto For reference, this gist shows all 388 lstat and open calls made when bringing Atom into focus with my small test Project Folder (3 files).
Looking at this, I notice that the project directory, .git directory, and some .git subdirectories get scanned sometimes several times during the status check for each file. It may be that the Git implementation is searching the the .git sub-directories for objects and not caching objects or the directory listings.

Trouble is, if you cache, when do you bust that cache? Simple timeout?

@nathansobo, I wonder if it would be reasonable the Git implementation to consider the repository contents static/atomic for the length of the entire "check the git status for the Project Folder" operation. If .git/HEAD is the first thing loaded, all of the objects referenced by that ref should already exist on the file-system and (if I remember how git works correctly, which is debatable :wink:) should persist without modification until git gc is run. If other git operations add new objects/refs/tags/heads/etc, those referenced by the initial look at .git/HEAD would still be there. I would think that to make such a system work the caller would need to pass either some sort of cache object or cache-id to the git implementation to use for each of the git status checks.

1.6.1 is now out which should make life more bearable. It's still not as fast as 1.5.4 was. We're continuing to work on it.

@joshaber Thanks for the work! I love what you're all doing.

As of #11315 performance should be back on par with 1.5.4. It'll be released publicly in 1.8.
I'm sorry this painful regression happened. Thanks for all the reports!

@joshaber how come Atom 1.8 and not 1.7? 1.6.1 has definitely made some great progress (freezes for me occur very rarely) and I can use it rather painlessly, but I have a local network share (from the VM inside my PC) on an SSD, so I'm kind of lucky, and it's weird to think that people on really slow networks need to wait 2 minor releases  before upgrading from 1.5.
I'm not sure what the patch policy is, but seeing this is critical and blocking for some users, couldn't the commits be cherry-picked into 1.7?

That's a fair question @dborsatto. Because they are fairly large changes, I'd like them to go through the standard beta testing process so that we can try to catch any new bugs before it's released.

I have only today been able to test the 1.6.1 fix (I created the original report) and Atom remains unusable for me because of problems that may have originated from the changes made to remedy the freezes.  I am now experiencing the blank files issue from #11327 instead of the lock-ups.  The remote files which I would be attempting to open only appear after a long time which is comparable to the extended freeze I reported above.  So essentially, Atom remains in a responsive state instead of freezing, but the desired action of the remote file contents actually appearing for editing remains just as delayed as prior to these changes.
I'll note that as in the original report I am still using Ubuntu 14.04 and an SSH mounted drive, and I'll also note that I'm horribly sorry to keep being the bearer of bad news(!), and my thanks to all others involved.

@joshaber Fair enough. But for people like me, who on working on big remote projects, I have to wait until 1.8 is out.

@eddy147 Alternatively, you could download 1.5.4 and disable updates until 1.8 is out.
As for timing, no guarantees, but I'd expect 1.7 to be out in a week or two, which means 1.8 would be available for download as a beta then. And then another few weeks until 1.8 is out as the stable release.

@joshaber Thank you!

Btw, v1.8.0-beta0 is available as of ~2 hours ago :wink:.

Still an issue on 1.8.0 linux mint 17.3.  Alt-tabbing freezes the window for several seconds
1.5.4 is working fine

bump for reopening. @joshaber
i can't type, while working on gvfs-sftp. it just hangs for 2-3 seconds during typing.

1.12.5 on Ubuntu still freezes all the time, almost unusable with low ping (through VPN or something).

I noticed, that it freezing each time it check is file changed on disk. Look like they did it synchronous.

Still having the same issue in the latest version. Actually, it was working really well until I did a large git commit on my repository and now Atom just times out over and over again.

@kylefarris i managed to workaround it by mounting with cache timeout 1 hour and more. As far as i understand, the issue is caused by underlying architecture: eveerything requests in man thread, synchronymous mode. You may see, when you're reloading folder content, whole UI is freezing.
Same thing with git plugin, file saving etc.
For example you cant switch tab while file save in process.
Try to disable atomic save, and increase sysctl vm timeouts.

@Enelar Thanks! I'm generally experiencing this when I'm working on my Windows 10 machine at work unfortunately so the sysctl part won't help much but atomic save may. Is the atomic save a config option in Atom itself?


Clear accessory

can i delete only some accessories so as not to show them in the homebridge?

can i delete only some accessories so as not to show them in the homebridge?

Yes. Take note of the device ID, then look for the setting that is listed for each device.

Thank you

thanks for helping here @MoTechnicalities
gonna close this, assuming @marcgrc you got what you needed


error in task editor when using tableFind()

I've created a task with the below query and getting error when using tableFind().Attaching the screenshot of the error. Shouldn't be tableFind() used in task?
data = from(bucket: "flowEvents_1hr")
|> range(start: -5h, stop: -4h)
|> tableFind(fn: (key) => key._field == "c")

And since tableFind() isn't working, I've used first() / last() so that it'll give me only one table and used getRecord() to get the first record of the table, but getting error 'missing object properties'. Attaching the screenshot of the error.

Actually, my use-case is that I've a task, which will  downsample the data to destination bucket. I need this without failure, hence I want to run this task twice a day, I need a logic such that it should check the data from destination bucket for the last 24 hr, if there is any data present then skip the processing else do the processing.
Hence I'm trying to check whether destination bucket has data for the past 24hr. How can I achieve this?

I have same problem. Is there any solution or workaround ?

I only get this error in OSS 2.0.3. It works fine in InfluxDB Cloud.

The code to fix this was already in OSS, but it was hidden behind a feature flag. PR to remove the flag and make the corrected behavior the default is incoming.

Thanks for the update @danxmoran! If I want to enable this feature flag (I'm running the docker container) today can you tell me how would I do it?

As a CLI option you'd pass --feature-flags simpleTaskOptionsExtraction=true. In a config.yml I think it'd be:
feature-flags:
  simpleTaskOptionsExtraction: true

Fantastic thanks, will give it a go 👍
On Fri, 5 Mar 2021, 16:33 Daniel Moran<EMAIL_ADDRESS>wrote:

As a CLI option you'd pass --feature-flags
simpleTaskOptionsExtraction=true. In a config.yml I think it'd be:
feature-flags:
simpleTaskOptionsExtraction: true
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/influxdata/influxdb/issues/17666#issuecomment-791533309,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGCKPOHRXBL7DAEHQA2KKDTCEBUNANCNFSM4MDWWBXA
.

@danxmoran Despite reading through https://github.com/influxdata/influxdb/pull/17851, I've not been able to get the feature flags to work.
I am happy to open an issue, but is there anything else you would suggest I read first just to make sure I've got the correct understanding?
Have been through

@beyond-code-github I'm honestly not that familiar with the feature-flag setup (it was added before I joined Influx, and hasn't been used heavily since). I'll poke at it myself and report back

@beyond-code-github how are you trying to pass in the flags? They seem to be working for me via CLI option:
# Using the 2.0.4 binary

# This server fails to save the task from the issue description
$ ./influxd

# This server allows saving the task
$ ./influxd --feature-flags simpleTaskOptionsExtraction=true

I've tried all three options... if I use the CLI:
docker run -d -p 8086:8086 --name influxdb2 \
	-v $PWD:/root/.influxdbv2 \
	-e INFLUXD_CONFIG_PATH=/root/.influxdbv2 \
	quay.io/influxdb/influxdb:nightly \
	influxd --feature-flags simpleTaskOptionsExtraction=true

ts=2021-03-06T13:59:48.493305Z lvl=info msg="Running with feature flag overrides" log_id=0SiyEiqW000 overridesError="unsupported value type"
If I use the config file:
log-level: info
feature-flags:
  simpleTaskOptionsExtraction: true

Error: configured overrides for non-existent flags: simpletaskoptionsextraction

See 'influxd -h' for help```

Using the environment variable:

```docker run -d -p 8086:8086 --name influxdb2 \
        -v $PWD:/root/.influxdbv2 \
        -e INFLUXD_FEATURE_FLAGS="{\"simpleTaskOptionsExtraction\": true}" \
        quay.io/influxdb/influxdb:nightly```

No error messages but not discernable effect, task creation still fails.

In the first and third cases, if I GET http://localhost:8086/api/v2/flags then the output is:

`{"appMetrics":false,"bandPlotType":false,"communityTemplates":true,"frontendExample":42,"mosaicGraphType":false,"notebooks":false,"timeFilterFlags":false}`

In the second case the service fails to start.

The feature flag will be removed in 2.0.5, and the behavior it was guarding will be the default


[ROCKETMQ-117] add telnet server to namesrv

https://issues.apache.org/jira/browse/ROCKETMQ-117

Coverage increased (+0.2%) to 31.003% when pulling dffb20e349980b86fdb3e22b97c2b33a6baffbc9 on Ah39:ROCKETMQ-117 into a947fe21ba9bbdea08d20661eacabe7c88677363 on apache:master.

Coverage increased (+0.2%) to 31.003% when pulling dffb20e349980b86fdb3e22b97c2b33a6baffbc9 on Ah39:ROCKETMQ-117 into a947fe21ba9bbdea08d20661eacabe7c88677363 on apache:master.

Coverage increased (+0.1%) to 30.927% when pulling 737c3e7148afd51cb3b2b5dedd77b4f3b2df5578 on Ah39:ROCKETMQ-117 into a947fe21ba9bbdea08d20661eacabe7c88677363 on apache:master.

Coverage increased (+0.1%) to 30.927% when pulling 737c3e7148afd51cb3b2b5dedd77b4f3b2df5578 on Ah39:ROCKETMQ-117 into a947fe21ba9bbdea08d20661eacabe7c88677363 on apache:master.

Have you look through the PR instruction, please follow the other PR topic, modify yours "Rocketmq 117"

Hi @Ah39 ,
I am not sure is this PR a real demand, since we have mqadmin tool.
On the other hand, do we have any method to intercept or approve the requests from telnet client, like a hook?

Maybe  the QA and other rd may need the telnet tool. They can not use the mqadmin tool.
They may need know the topic infomation and connection , so telnet is most useful tool

@Ah39 Maybe console is a better tool for QA, and your concern makes sense indeed, let's wait for other committers' thoughts.


Introduce a feature that allows users to more easily copy their selected option in select & multiselect  fields

SUMMARY
In our current version, it's relatively tricky for users to copy the value for their selection for the select and multiselect type fields without inspecting the HTML and pulling the value from the component. This is a relatively bad user experience.
Update the portal logic, allowing users to auto-copy their selected option's value to the clipboard and make it the default behaviour. It should also be easy to disable this and return to the original behaviour if a user so desires.
When configuring the auto copy to clipboard, we would expect to be able to do it at the property level of the field(s), i.e.:
fields:
 - label: countries-to-rate-limit
    properties:
      display: Which countries should have a limited request rate?
      type: multiselect
      disableAutoCopySelection: true
      choices:
        - US
        - UK

fields:
 - label: countries-to-rate-limit
    properties:
      display: Which countries should have a limited request rate?
      type: select
      disableAutoCopySelection: false # Default option
      choices:
        - US
        - UK

Note the additional property disableAutoCopySelection

SUCCESS CRITERIA

Add an additional property to the select & multiselect fields that allow users to enable and disable auto-copying of their selection easily

This property will be called disableAutoCopySelection

Update README documentation to reflect changes added

Addressed in release  v2.1.0


Jenkins needs clang-format installed

Description
see log here
+ clang-format --version
<EMAIL_ADDRESS>line 4: clang-format: command not found

I think the flatiron jenkins server needs to have clang-format installed on it
Current Version:
v4.3.0

Argh I probably didn't see it because it's not failing with exit code 0.
I'm on it!

clang-format added to the docker image.
clang-format --version
clang-format version 10.0.0-4ubuntu1


Fix selene linting about TestEz files

This fixes selene accidentally linting about TestEz files so the lint doesn't have a bunch of unnecessary warnings

Selene does have support for TestEZ, which can also fix the warnings. https://kampfkarren.github.io/selene/roblox.html#testez-support

Selene does have support for TestEZ, which can also fix the warnings. https://kampfkarren.github.io/selene/roblox.html#testez-support

But wouldn't that apply for all files and not just *.spec.lua files?

Selene does have support for TestEZ, which can also fix the warnings. https://kampfkarren.github.io/selene/roblox.html#testez-support

But wouldn't that apply for all files and not just *.spec.lua files?

Haven't tested that, so not sure if it would apply for all files. But considering the fact that the file needs to be *.spec.lua it will most likely ignore all other files.

Selene does have support for TestEZ, which can also fix the warnings. https://kampfkarren.github.io/selene/roblox.html#testez-support

But wouldn't that apply for all files and not just *.spec.lua files?

Haven't tested that, so not sure if it would apply for all files. But considering the fact that the file needs to be *.spec.lua it will most likely ignore all other files. With "roblox+TestEZ" it will combine both the normal and TestEZ library.

It would require

But first you'll need to create a testez.yml file, which you can do so with this template.

So I think it's better to blacklist the files than to setup testez

Yeah, agreeing with you there. Way easier to just blacklist the files.


feat(dependabot): add dependabot.yml config file

To automate checks for version upgrades and vuln scans, and create a PR.
Also requires the repo owner to manually adjust some settings on the repo:

Settings > Security > Code security & analysis.
Enable security updates, grouped updates, and version updates

Detailed directions at: https://docs.github.com/en/code-security/dependabot/dependabot-security-updates/configuring-dependabot-security-updates

I'm deliberately raising this PR to merge to main instead of 1.3, because dependabot needs to be on the main branch before it can start checking for updates. From testing on my own repo, the current codebase has ~26 vulns that can be quickly address through dependabot automating the dependency updates.
I recommend we deploy this to main sooner than the 1.3 release so that we can also hotfix the various dependency updates.


Assist with passing travis #268

Saw the comment on #268 about adding linode_test.go file (and a few tests). Frankly, there isn't coverage tests in the other Drivers (rackspace, digitalocean, etc). I don't see why we can't  add Linode tests later.

It seems currently there're only coverage tests for amazon_ec2 driver and the tests there are very specific to the driver itself (not the integration). Linode driver has its tests in its own package so I used a blank test just like other drivers.


My CocoaPods badge is not working

(If this is an issue on their side and not y'alls, I'll go open an issue with them instead)
Are you experiencing an issue with...

[x] shields.io
[ ] My own instance
[ ] badge-maker NPM package

:beetle: Description
None of the badges for my CocoaPod, FLEX, are working:

But other pods are working:

:link: Link to the badge
https://img.shields.io/cocoapods/v/FLEX.svg

Hi. I think this is an issue on the CocoaPods side rather than us.
We are calling https://trunk.cocoapods.org/api/v1/pods/FLEX/specs/latest which redirects us to a spec file that doesn't exist: https://raw.githubusercontent.com/CocoaPods/Specs/387275e64a7555c0c316840d4e3d5cd36043f401/Specs/f/7/1/FLEX/4.4.1/FLEX.podspec.json
Interestingly if I call https://trunk.cocoapods.org/api/v1/pods/FLEX/specs/4.4.1 that redirects us to a spec file that does exist: https://raw.githubusercontent.com/CocoaPods/Specs/8ea09b48deb3a500717d2c4fac5634a5cb2f140a/Specs/f/7/1/FLEX/4.4.1/FLEX.podspec.json
Can you try raising an issue with them about it. Thanks

Weird! Thanks for debugging that for me. I didn't know how you guys were calling into their API.
Thanks again :)


Build failed on export

Exporting org.winehq.Wine.gecko to repo
error: Build directory flatpak_app not initialized, use flatpak build-init
Export failed: Child process exited with code 1
Error: Build failed: Error: The process '/app/bin/xvfb-run' failed with exit code 1

If I build my application locally in my arch, then when I export it will also have this error, but it does not affect anything and I can safely install the application from my local repository, but with this action so does not work with this error everything just crashes, and even using flatpak build-init did not help me.


Update test setup

This is done to avoid conflicts with other BCP demo tokens (ASH, BASH, CASH, MESH …) to simplify multichain demos.

interesting names

Well, it is hard to come up with new names all the time. The names are basically random but alphabetically ordered (H, I, J).


Problem with unit testing

Hi, I've included CommandLineParser in a solution and started writing unit tests. I have strange problems with the ParseArguments method.
I wrote 4 tests (they have exacly the same code), the problem is that the first one executes correctly and the rest throw an exception:
Result Message:
Test method MyAppTest.MyAppBehaviour.ShouldDisplayHelpWhenNoArgumentsDefined2 threw exception:
System.ObjectDisposedException: Cannot write to a closed TextWriter.
Result StackTrace:
at System.IO.__Error.WriterClosed()
at System.IO.StringWriter.Write(String value)
at Microsoft.VisualStudio.TestPlatform.MSTestFramework.ThreadSafeStringWriter.Write(String value)
at System.IO.TextWriter.SyncTextWriter.Write(String value)
at CommandLine.Parser.DoParseArguments(String[] args, Object options)
at CommandLine.Parser.ParseArguments(String[] args, Object options)
at MyApp.MyApp.ParseArguments(String[] args)

My app invokes ParseArguments like this:
public class MyApp
{
Options options = new Options;
....
private void ParseArguments(string [] args)
{
if (CommandLine.Parser.Default.ParseArguments(args, options) == false)
{
if (args.Length > 0 && args[0] != "--help")
Console.WriteLine("error");
else
showHelp = true;
}
}
}
Any idea what can I change? Like I said this code works in the first test method but not in the rest (all of them have the same code, and all of them initialize a MyApp object)
Thanks for your help in advance!

Are there any plans to release the latest version on GitHub via NuGet?

The author abandoned this library a while ago. There is a maintained fork available but I don't think it's been published to NuGet yet.

It is: https://www.nuget.org/packages/CommandLineParser19/ and https://www.nuget.org/packages/CommandLineParser20/

2.0 is now quite usable, even if still in alpha. Latest commit (@ the moment of writing) is aligned with NuGet.
I think I can close this issue.
Please post back if needed! Project will continue to stay...


varying level of treatment over time

Hi all,
thanks for the great package.
The company i work for is a B2B so during the week-end and bank holidays business users are less active and media reach of business users is lower.
In the scenario of the treatment being "paused" (the "pause" might be a true pause in media treatment or due to a significant reach drop due to characteristic of the media & target under experimentation) for example during a bank holiday or the week end... or long week-ends and these happening during the experiment treatment period.
Do you have any recommendation on handling these scenarios?

Hi @stefanoallima ! Sorry for not replying sooner to your issue.
I think its worth making a distinction between these two cases: turning the treatment on and off during the treatment period and a treatment with some degree of weekly seasonality.
For the case of a treatment with weekly seasonality, where the user does not manually change something and the campaign evolves as expected (large audience on weekdays, low audience on weekends), I suggest you leave as is.  This is Business As Usual for the campaign, given the nature of your B2B business.  When we run these types of experiments, we would like to be able to measure what would happen in a normal scenario without the ongoing experiment, to make results as relatable to normal circumstances as possible.
For the case where you turn a treatment on and off during a treatment period, because for example no sales happen during weekends and campaigns are paused, then you could exclude these days from the analysis.  But if you do so, I would exclude all weekends from the series, given that sales for all regions are zero on those days.  If that is not the case, and you have some regions that had sales and some that didn't on weekends, I would keep the series as is, given that not all locations behave the same in your dataset.
Closing this issue for now.  Feel free to reopen if you have further comments.


nicer logs with potential to output to file

The ability to output verbose and other output to a file in realtime would be helpful for debugging and general use.

The logger branch will solve this. The goal is to be able to have all threads publishing to the log file along side the main script and to use a logging function to handle verbose/debug output instead of using write-verbose and write-debug etc that we're using currently

Logging is practically  done. Decided not to both using .NET functions to write to file as there doesn't seem to be any drastic improvement for the amount of complexity it brings (1 line to like 5-6 with non-intuitive code)
Only thing that I'm not confident on is that there are logs being created everywhere there needs to be. This is something that can be fixed with further releases though.
Another thing of concern is that should the logging be enabled the logs that strippy creates will themselves need to be sanitised. If someone ran Strippy over it's own logs bad things would happen.

This is closed with v2.1.0


Zachmu/update vitess

Hold off on this -- I have some bugs to iron out

Hold off on this -- I have some bugs to iron out

Darn it I was halfway through reviewing this lol

While testing this, found that errors in tableEditor.close() permanently poison the session:
mysql> select * from a;
+------+----------------------------+
| x    | t                          |
+------+----------------------------+
|    1 | 2020-09-11 21:53:24.727333 |
|    2 | 2020-09-11 21:57:14.352303 |
|    3 | 2020-09-11 21:57:14.352303 |
|    4 | 2020-09-11 21:57:14.352303 |
|   10 | 2020-09-12 00:08:13.993816 |
+------+----------------------------+
5 rows in set (0.00 sec)

mysql> insert into a values (11, now());
ERROR 1105 (HY000): unknown error: failed to write table back to database
mysql> insert into a values (12, now());
ERROR 1105 (HY000): unknown error: failed to write table back to database

Since the breaking bug I found actually exists on the earlier version of dolt, let's get this checked in and you can fix it off of master instead of this branch.


OpenWRT doesn't have ssh-keygen

Describe the bug
When Python sshnpd tries to generate a key on OpenWRT it fails due to missing ssh-keygen
Generating SSH Keys
INFO:sshnpd:Generating SSH Keys
Exception in thread Thread-6 (sshnp_callback):
Traceback (most recent call last):
  File "/usr/lib/python3.11/threading.py", line 1045, in _bootstrap_inner
  File "/usr/lib/python3.11/threading.py", line 982, in run
  File "/usr/lib/python3.11/site-packages/sshnpd.py", line 301, in sshnp_callback
  File "/usr/lib/python3.11/site-packages/sshnpd.py", line 263, in _direct_ssh
  File "/usr/lib/python3.11/site-packages/sshnpd.py", line 410, in _generate_ssh_keys
  File "/usr/lib/python3.11/subprocess.py", line 1026, in __init__
  File "/usr/lib/python3.11/subprocess.py", line 1950, in _execute_child
FileNotFoundError: [Errno 2] No such file or directory: 'ssh-keygen'

Steps to reproduce

First I spin up a VM running OpenWRT 23.05.0 x86_64
Then I copy over the ipks from https://github.com/atsign-foundation/Atsign_OpenWRT_packages/releases/tag/v0.4.1
Ensure dependencies can be found with opkg update
Install SDK with opkg install python3-atsdk_0.2.0-1_x86_64.ipk
Install Python sshnpd with opkg install python3-sshnpd_0.4.1-1_x86_64.ipk
Copy over an atKey
Run sshnpd e.g. sshnpd -m @cpswan -a @snowboard89 -d openwrt23 -u
Attempt to connect from a client using sshnp

Expected behavior
Daemon should test for presence of ssh-keygen before trying to run it, and provide an error message if it can't be found.
Alternatively use a pure Python way of generating keys.
Additional context
I tripped over this as I tried to test Dropbear for #633

We can do a dart native keygen, which is what we do for the pure-dart client

@cpswan I'm going to wait to solve this in the C daemon.

We can add SELECTS:=openssh-keygen to the Makefile, which I've done for the C sshnpd.


[Android] [Bug] Fix  - Unordered list followed by ordered list not working correclty

Description
If a text contains unordered list followed by ordered list, the bullet point is not showing and replaced with numbers.
Sample Card
                {
			"type": "TextBlock",
			"text": "1. Numbered\r- List\r",
			"wrap": true
		}

How Verified
verified with the card

Before
After

Thanks for fixing this @karthikgopal36 . do you know if this is android specific or might be required to be handled on iOS too?

Thanks for fixing this @karthikgopal36 . do you know if this is android specific or might be required to be handled on iOS too?

@GabrielMedAlv  this is android only issue. iOS works fine.