[SPARK-26224][SQL] Advice the user when creating many project on subsequent calls to withColumn

What changes were proposed in this pull request?
We have seen many cases when users make several subsequent calls to withColumn on a Dataset. This leads now to the generation of a lot of Project nodes on the top of the plan, with serious problem which can lead also to StackOverflowExceptions.
The PR improves the doc of withColumn, in order to advise the user to avoid this pattern and do something different, ie. a single select with all the column he/she needs.
How was this patch tested?
NA

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5969/
Test PASSed.

Test build #99969 has started for PR 23285 at commit da2c82e.

Test build #99969 has finished for PR 23285 at commit da2c82e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99969/
Test FAILed.

Test build #99975 has finished for PR 23285 at commit a40db10.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99975/
Test FAILed.

retest this please

Test build #99981 has started for PR 23285 at commit a40db10.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/5980/
Test PASSed.

Test build #99981 has finished for PR 23285 at commit a40db10.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99981/
Test FAILed.

the test failure shows a potential regression due to this patch I hadn't thought of. Collapsing the projects may avoid the usage of plans which are cached. Unfortunately, this cannot even be checked because the plan can be cached later.
@cloud-fan @viirya I don't have any idea how to address this potential regressions. So if you don't have suggestions, I'll close this PR. What do you think? Thanks.

IMHO, given that it's not easy to make chained withColumns works like one projection, we might want to consider exposing withColumns to public. If chains are independent, they could be changed to one of withColumns, and even some chains depend on others, the depth of projection could be greatly reduced.

@HeartSaVioR I'd rather say that withColumns can be easily done as well using select. So I am not sure it is so useful to expose it. There is already a "workaround" for this problem, this PR just meant to avoid that issue since many people use it.

@mgaido91 Yeah, agreed there's a workaround (select), as well as it would be more ideal if we can collapse chain of withColumn properly. This is based on that it doesn't seem to achieve it, and we need to guide end users to take a workaround. End users using withColumn seem to feel more convenient than using select, then IMHO withColumns might become another convenient method for end users, alternative of withColumn.

@HeartSaVioR I am just telling you what is my experience: I remember in one of my very first work with Spark that I used withColumn too in a for loop because it was easier/more convenient to work with one expression per time for me. When I realized that it was a bad idea for this reason, then I think that having a withColumns or using select doesn't make a big difference, as in any case you have to build your columns in advance and then pass them to the method. In this sense, I don't see the withColumns method being useful.
As an alternative, I'd propose here to check if there are several project on the top (we can define a threshold, eg. 50), when calling withColumn and in that case emit a warning saying something like: "Your plan contains a may Project nodes on top of each other. This usually happens if you are using withColumn in a for loop and you are adding many columns. Doing this is highly discouraged and can cause serious issues. Please use a single select and add all your new columns to it instead.". What do you think? cc @cloud-fan @viirya too.

It sounds good to me if we can provide warn message to guide replacing them with select. IMHO, the real issue is basically end users don't know chaining withColumn does harm on performance of query. Once we can guide it, it would be enough.

Test build #100253 has started for PR 23285 at commit e37c2d6.

I have updated the PR with the WARN approach. I can make the threshold configurable if we agree on this. WDYT @cloud-fan @HeartSaVioR  @viirya ?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/6225/
Test PASSed.

Test build #100253 has finished for PR 23285 at commit e37c2d6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/100253/
Test PASSed.

This seemed to got a bit stale. I think there are 2 approaches possible:

using doc as suggested by @HyukjinKwon ;
emitting a WARN as I think is more effective.

Can we find agreement on which of these 2 possible paths follow? Thanks.

Let's do documentation first, and then warn later if people still face this issue.

ok, thanks @HyukjinKwon

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9397/
Test PASSed.

Test build #104048 has started for PR 23285 at commit 5d1fc00.

Test build #104048 has finished for PR 23285 at commit 5d1fc00.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104048/
Test PASSed.

Merged to master.
Let's consider the actual fix later when we see users still complain.

Ahh ... actually we should fix R and Python side too. Let me make a quick followup.


Refactored the tags parsing and message construction so it can be sub…

…classed more easily.
This is needed since main fields (e.g. statsType, tags) are private instead of protected, which means that the child class can not override the parsing easily.

hey @cyrille-leclerc thanks for the comment and merging the change.

hi, @cyrille-leclerc  can you help with merging this PR? also, can we get a new release if possible?
Thank you

Can you please test https://github.com/jmxtrans/jmxtrans-agent/releases/tag/jmxtrans-agent-1.2.11-rc-2 and i'll cut a release.
Thanks again for your contribution.

Can you please test https://github.com/jmxtrans/jmxtrans-agent/releases/tag/jmxtrans-agent-1.2.11-rc-2 and i'll cut a release.
Thanks again for your contribution.

Will do, thanks for merging

hey, @cyrille-leclerc we are running into an interesting issue with:
java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;

Triggered from https://github.com/jmxtrans/jmxtrans-agent/blob/master/src/main/java/org/jmxtrans/agent/StatsDOutputWriter.java#L231
I think the root cause is exactly https://stackoverflow.com/questions/61267495/exception-in-thread-main-java-lang-nosuchmethoderror-java-nio-bytebuffer-flip
curious which JDK version was used to compile and release into maven?

@endoplasmicR I probably have used OpenJDK 15.
Precisely
java -version
openjdk version "15.0.2" 2021-01-19
OpenJDK Runtime Environment AdoptOpenJDK (build 15.0.2+7)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 15.0.2+7, mixed mode, sharing)

Y

@endoplasmicR I probably have used OpenJDK 15.
Precisely
java -version
openjdk version "15.0.2" 2021-01-19
OpenJDK Runtime Environment AdoptOpenJDK (build 15.0.2+7)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 15.0.2+7, mixed mode, sharing)

The explicit casting suggested in the stackoverflow article seems to be a good solution to me as it doesn't put constraints on the build process. What do you think?

Yes, I have submitted a PR https://github.com/jmxtrans/jmxtrans-agent/pull/156, can you update the RC version if possible?
Thank you.


Assertion failed name > 0

Testing the runtime gave me this error with the sample bellow.
OpenGL ES 2.0 Renderer: AMD BONAIRE (DRM 2.50.0, 5.3.0-59-generic, LLVM 9.0.0)
OpenGL ES 2.0 Batching: ON
godot.x11.opt.tools.64: modules/spine_runtime/spine-cpp/src/spine/Skin.cpp:96: spine::Skin::Skin(const spine::String&): Assertion `_name.length() > 0' failed.
dragon.zip
nvm, the sample's from an older version of spine... sorry

Confirming it doesn't work.
I transferred the project into the latest 3.8 spine. It deleted a few animations when doing so. However, re exporting it still didn't make it work. The error message makes not sense:
Failed method: Button update_minimum_size:
Object deleted while awaiting callback
--../--


[documentation] make customPlaygroundQuickLook availability message match reality

All other instances of the customPlaygroundQuickLook availability message already mentioned "a future Swift version" rather than "Swift 5.0". (See the output of find stdlib -name *.swift -exec egrep -H available\.+customPlaygroundQuickLook {} \; from the repo top level)

No SR.

@swift-ci please smoke test

@swift-ci Please smoke test Linux platform

@swift-ci Please test Windows platform


Hhj

Nm

Hi, please let me know if you have a question or issue that we can address.  Thank you, the Google Team


1.18

Update to 1.18 :>

Thank you for this! I'll take a look at it and get a release out shortly.
I don't recall if I was fully finished and satisfied with the changes I made to the config screen just yet

I can only tell you that it works. :D

I can only tell you that it works. :D

How can i build from this souce a Java file?

I can only tell you that it works. :D

How can i build from this souce a Java file?

yes -> Clone my repository change to 1.18 an run ./gradlew build

or use this jar --> https://fantacs.de/cmdkeybind-1.5.2-1.18.jar

I released this on curseforge, thank you for the work!

^^


Update README.md

Fix Gitter icon

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

thanks!


Take off calls to action from both prototype page titles

EU  - our prototype currently states to 'Enter vehicle registration number' - should we remove the word 'enter' as all other calls to action from the page titles as well?
Anthony Lord
13:28 Yesterday
Yes, we probably should.
The guidance here says we must be consistent: https://www.gov.uk/service-manual/design/form-structure#structure-your-form-to-help-users
So if we stick with 'enter' where we have it, to be consistent this means we must add 'select' to this h1 for example: https://verify-local-patterns.herokuapp.com/service-patterns/parking-permit/example-service/permit-length. So it would be 'Select how long will you need your permit'. We don't tell users they must click or select things, so we don't need to tell them to enter things. A paper form doesn't tell people they need to 'Write your registration number', so a digital form doesn't either

Just to note this will have quite a lot of implications, not just taking the verb off the titles. As this is an online transaction rather than a form (where users expect to write a thing in a box to in response to its label), the sub-headers and in some cases the page titles will need to be more active e.g. phrased as questions, Register to vote being an exemplar https://www.gov.uk/register-to-vote
So I'm drafting the new content in a new branch, which will then be processed as a pull request.


Add BETA label in UI

As discussed in out stand up today I added a BETA label to the page header. Feel free to merge and install @fsteeg


WEBAPP-259: Make 3rd level categories look more subordinate

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword WEBAPP.
Thx @Schedulaar :+1:
Indent 3rd level categories.

Hmm... looks odd to me, when there are no thumbnails for the 3rd level available (which is our official recommendation)
http://localhost:3000/deutschlandtemplate2018/en/education-work-und-university-studies

@Schedulaar

better like this?

I don't think it is necessary asking #design-marketing for this, since the changes of the design are quite small and it's only affecting the design on desktop.

I like it that there are no icons. Icons are also distracting and very difficult to get right.
Like how would you distiguish between an icon for 'Mobilität' vs. 'Öffentliche Verkehrsmittel'.

So you would just don't show any icons for 3rd level categories even if there are some?

@klinzo I think that's what looks odd to @Schedulaar. imo its fine if there are none.
We should ask in the Slack if we tell people to add icons for sub categories.

@maxammann No, I think prior to this task, it looked fine when there were no icons. Since 'no icons' is our official recommendation, we shouldn't care (too much) if it doesn't look good if there are icons.
With this task the indentation of the yellow lines don't align any more which looks (for me) somewhat strange, and we don't follow the design of the native app as well...
Plus it looks odd, when cities mix icons / no icons: http://localhost:3000/augsburg/de/lebensorganisation

imo it also didn't look very good if there were no icons before this task (because the yellow line started before the text which looks strange for me), plus imo there was way to less difference between second and third level categories, as it was criticised by some cities and clara.

As we're already disussing here we should move this to Slack I think :)


What is the utils folder used for?

@afang
You can put some helper functions here. e.g. function to disable contextMenu event:
export function disableEvent(event) {
  event.preventDefault();
  return false;
}

Just a folder for helper functions.


Uf3 lammps cpu

Added lammps_plugin directory.
The directory contains source code to run LAMMPS with UF3 potentials.

ML-UF3 --> Contains the c++ source code for pair_style uf3

documentation_lammps_format  --> Contains documentation about pair_style uf3 in LAMMPS format

scripts --> Contains a python script to convert UF3 potentials from JSON format to UF3 LAMMPS potential files.

timing_info --> Contains some performance information of the CPU version of ML-UF3.

tungsten_example --> Contains example LAMMPS scripts running structure relaxation and NVE calculations using Tungsten UF3 potentials

unittest --> Contains a unittest in LAMMPS unittest format

README.rst --> Describes how to compile LAMMPS with ML-UF3 support, how to run LAMMPS using UF3, and structure of UF3 LAMMPS potential files.

Thanks, Ajinkya, Hendrik, and Stephen, for the great work. The pull request looks clearly structured and well documented to me.


ContinueNormal (HybridMode) stopped working for 1.16.5

OTG Plugin or Mod
[Please specify if it's about Forge Mod or Spigot server Plugin placing "x" into []]

[x] OTG Mod for Forge
[ ] OTG Plugin for Spigot

OTG Version
[Please specify the full OTG version that you are running by placing "x" into []]

[1.16.5-0.1.4] Other - specify here

Forge or Spigot Versions
Forge 36.2.2 for MC 1.16.5
Description
ContinueNormal does not work anymore.
Upon teleporting outside the edges of the map (e.g. 20.000 200 0) presents the user with the default ocean biome. The same happens when teleporting to area's where there are no biomes defined. In short, continue normal stopped working.
This issue is reproducible with any map that utilizes the continuenormal mode whilst using from image. E.G. Dregora which can be found here: https://www.curseforge.com/minecraft/mc-mods/dregora/files/3515674

Thanks for reporting, fixed for 0.1.6.


Cannot get a name and parameters for RoleProviderPluginManager

Hi! I have fatal error with PHP7.0.18 + ZF2.5.3 + ZF-Commons/zfc-rbac 2.6.2
Fatal error: Uncaught Zend\ServiceManager\Exception\ServiceNotFoundException: ZfcRbac\Role\RoleProviderPluginManager::get was unable to fetch or create an instance for in /var/www/vhosts/pf-portal/vendor/zendframework/zend-servicemanager/src/ServiceManager.php:555
Stack trace:
#0 /var/www/vhosts/pf-portal/vendor/zendframework/zend-servicemanager/src/AbstractPluginManager.php(161): Zend\ServiceManager\ServiceManager->get(NULL, true)
#1 /var/www/vhosts/pf-portal/vendor/zf-commons/zfc-rbac/src/ZfcRbac/Factory/RoleServiceFactory.php(60): Zend\ServiceManager\AbstractPluginManager->get(NULL, false)
#2 /var/www/vhosts/pf-portal/vendor/zf-commons/zfc-rbac/src/ZfcRbac/Factory/RoleServiceFactory.php(77): ZfcRbac\Factory\RoleServiceFactory->__invoke(Object(Zend\ServiceManager\ServiceManager), 'ZfcRbac\\Service...')
#3 [internal function]: ZfcRbac\Factory\RoleServiceFactory->createService(Object(Zend\ServiceManager\ServiceManager), 'zfcrbacservicer...', 'ZfcRbac\\Service...')
#4 /var/www/vhosts/pf-portal/vendor/zendframework/zend-se in /var/www/vhosts/pf-portal/vendor/zendframework/zend-servicemanager/src/ServiceManager.php on line 555

The issue in \ZfcRbac\Factory\RoleServiceFactory
with this code:
$roleProvider = $pluginManager->get(key($roleProviderConfig), current($roleProviderConfig));

The internal pointer in array $roleProviderConfig is in the end of array, because of that key($roleProviderConfig) and current($roleProviderConfig) return null.
There is two options to fix it on place:

Reset internal pointer in array to the beginning:

reset($roleProviderConfig);
$roleProvider = $pluginManager->get(key($roleProviderConfig), current($roleProviderConfig));

Use different functions, which work without pointer.

$roleProvider = $pluginManager->get(array_keys($roleProviderConfig)[0], $roleProviderConfig[array_keys($roleProviderConfig)[0]]);

I think first is better and it is good practice to get first element of associative array.

My config looks like this:
'zfc_rbac' => [
    'role_provider' => [
        'ZfcRbac\Role\ObjectRepositoryRoleProvider' => [
            'object_manager' => 'doctrine.entitymanager.orm_default',
            'class_name' => 'Module\User\Entity\Role',
            'role_name_property' => 'name',
        ],
    ],
],

Fix PR merged into master.
This issue is fixed.


added android sdk 2.2.0 rns

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: \ Release Notes for ff-android-client-sdk 2.2.0
Jira/GitHub Issue numbers (if any): \ FFM-11225
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[X] Successful preview build.
[X] Code owner review.
[X] No merge conflicts.
[X] Release notes: version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6619092c9e5c12044bbc3565--harness-developer.netlify.app


Update importlib-metadata

Motivation
Causes a conflict in python<3.8 and the latest version of pip fails to install manim because of this. It caused some problems in Chocolatey package.
Overview / Explanation for Changes
Any version of importlib-metadata should be fine as the API we are using isn't changed in the latest version also.
Oneline Summary of Changes
- Update importlib-metadata (:pr:`1046`)

Acknowledgements

[x] I have read the Contributing Guidelines

Reviewer Checklist

[ ] Newly added functions/classes are either private or have a docstring
[ ] Newly added functions/classes have tests added and (optional) examples in the docs
[ ] Newly added documentation builds, looks correctly formatted, and adds no additional build warnings
[ ] The oneline summary has been included in the wiki

@huguesdevimeux thanks.


delete from nuget command line tool working now

delete command(/api/v2/packages) from nginx.conf.example working now

Why do you need to make this change? What's an example of a delete URL that fails with the old config but works with the new one?

Closing this since I never heard back. Let me know if you still need this change.


Sound starts playing randomly when opening app when headphones are plugged in

I am using this package together with react-native-music-control which has caused issues in the past, so there is that. I am curious whether others experience this issue as well.
After digging through code and docs a bit I found the possible reason in RNSoundm lines 21-25:
    if (audioSessionRouteChangeReason == AVAudioSessionRouteChangeReasonNewDeviceAvailable){
        if (player) {
            [player play];
        }
    }

Anyone knows what these lines are used for? (@kurokky, I think you added these lines) It seems to trigger unwanted sound plays for our app.
I created a PR which removes these files which can be merged in case no one needs them.

Hi @schumannd
Did you see https://github.com/zmxv/react-native-sound/issues/201
There is no place calling the random method in my request.
Unfortunately, I have never used react-native-music-control.
So, I don't know why to happen in your environment it.
When I checked it did not do such a move and I have not requested If I found it.
More people would comment if my request was the cause.
However, from that time a long time has passed but never once.
I hope that you should test without react-native-music-control rather than deleting the code.

Hello @kurokky. In the meantimeI I removed react-native-music-control as it caused other issues as well. I thought maybe you could explain what these lines do. For me it looks like it is simply starting playback when a new device is plugged in? Or when is AVAudioSessionRouteChangeReasonNewDeviceAvailable the RouteChangeReason or what exactly does [player play] do in that situation?

@schumannd - seems kind of backwards to remove a feature from this library because another library didn't play well with it

@schumannd - see #201

@ngandhy the issue occurred independently of another package.


Bos miner.web.grpc.get_pool_groups() return OSError: [WinError 121]

Describe the bug
When i try get miner's pools status by miner.api.pools() i got empty dict then i try to use
miner.web.grpc.get_pool_groups()
i got
OSError: [WinError 121]
Screenshots
Traceback (most recent call last):
    x = await controle_object.web.grpc.get_pool_groups()
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\Оксана\Desktop\Sam\venv\Lib\site-packages\pyasic\web\bosminer\__init__.py", line 525, in get_pool_groups
    return await self.send_command("get_pool_groups", GetPoolGroupsRequest())
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\Оксана\Desktop\Sam\venv\Lib\site-packages\pyasic\web\bosminer\__init__.py", line 319, in send_command
    metadata.append(("authorization", await self.auth()))
                                      ^^^^^^^^^^^^^^^^^
  File "c:\Users\Оксана\Desktop\Sam\venv\Lib\site-packages\pyasic\web\bosminer\__init__.py", line 333, in auth
    await self._get_auth()
  File "c:\Users\Оксана\Desktop\Sam\venv\Lib\site-packages\pyasic\web\bosminer\__init__.py", line 345, in _get_auth
    await stream.send_message(req, end=True)
  File "c:\Users\Оксана\Desktop\Sam\venv\Lib\site-packages\grpclib\client.py", line 241, in send_message
    await self.send_request()
  File "c:\Users\Оксана\Desktop\Sam\venv\Lib\site-packages\grpclib\client.py", line 173, in send_request
    protocol = await self._channel.__connect__()
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\Оксана\Desktop\Sam\venv\Lib\site-packages\grpclib\client.py", line 748, in __connect__
    self._protocol = await self._create_connection()
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Users\Оксана\Desktop\Sam\venv\Lib\site-packages\grpclib\client.py", line 725, in _create_connection
    _, protocol = await self._loop.create_connection(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Оксана\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 1085, in create_connection
    raise exceptions[0]
  File "C:\Users\Оксана\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 1069, in create_connection
    sock = await self._connect_sock(
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Оксана\AppData\Local\Programs\Python\Python311\Lib\asyncio\base_events.py", line 973, in _connect_sock
    await self.sock_connect(sock, address)
  File "C:\Users\Оксана\AppData\Local\Programs\Python\Python311\Lib\asyncio\proactor_events.py", line 726, in sock_connect
    return await self._proactor.connect(sock, address)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Оксана\AppData\Local\Programs\Python\Python311\Lib\asyncio\windows_events.py", line 846, in _poll
    value = callback(transferred, key, ov)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Оксана\AppData\Local\Programs\Python\Python311\Lib\asyncio\windows_events.py", line 633, in finish_connect
    ov.getresult()
OSError: [WinError 121]

Desktop (please complete the following information):

python 3.11.4
windows 10

Miner Information (If applicable):

Type: Antminer S19J Pro NoPic (BOS)
Firmware Type: [BraiinsOS]
Firmware Version: 2023-04-20-0-0ce150e9-23.03-plus

Additional context
i use pyasic 0.46.0

OSError 121 is refused connection, you have to update your miner to the latest version, since older versions don't have gRPC support.
I would also recommend updating pyasic to the latest version, as that will fix some other bugs.

Also, on recent versions, it will become miner.web instead of miner.web.grpc, but I would recommend using get_config instead if you just intend to get config information.

What i BOSerWebAPI and BOSMinerRPCAPI. I mean that  why do you need to create two classes for Bos?

I see that use get_config is good practic, but i need to get pools status (Are they Alive or Dead?)

Regarding your first question; The reason for 2 BOS+ classes is that they dropped support for S9 (and technically X17) prior to implementing gRPC, so in order to maintain compatibility in a simple way with S9s, I split the classes out into something for S9 and something for newer models.  This is slightly buggy with X17 models, because they are updatable to new versions but have tuner issues, so it's troublesome to decide between implementations there.
Regarding active pool status, yes, that's the correct way to do that then.  I've considered trying to add that to miner data, but it seems complicated to structure that in a useful way, and it's not something I would want to put into miner config...

I see that use get_config is good practic, but i need to get pools status (Are they Alive or Dead?) get_config give me pools parameters but not statuses

Getting this added into miner data, some miners already have it, and more are getting it soon.

This should be fixed in latest, give it a test and let me know if you still have issues.


Could not find UaaMetrics object on MBean server. Please deploy UAA in the same JVM

What version of UAA are you running?
UAA version: 4.12.1
What output do you see from curl <YOUR_UAA>/info -H'Accept: application/json'
FAILURE
How are you deploying the UAA?
I am deploying the UAA

locally only using gradlew

What did you do?
I use command "gradlew run" to deploy UAA on my local machine. below is the error
> Task :assemble
:assemble took 0ms

> Task :cleanCargoConfDir UP-TO-DATE
:cleanCargoConfDir took 0ms
<============-> 97% EXECUTING [1m 12s]
> :cargoRunLocal

And I check uaa-server.log under uaa/build/reports/tests/   Error as below:
Caused by: java.lang.IllegalArgumentException: KeyManager must be set
	at org.springframework.util.Assert.notNull(Assert.java:134)
	at org.springframework.security.saml.metadata.MetadataManager.afterPropertiesSet(MetadataManager.java:156)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1688)
	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1626)
	... 111 more
2018-05-04 12:53:09.694  INFO 10996 --- [pool-2-thread-1] o.c.identity.statsd.UaaMetricsEmitter    : Could not find UaaMetrics object on MBean server. Please deploy UAA in the same JVM.

What did you expect to see? What goal are you trying to achieve with the UAA?
Expect to deploy UAA using gradlew on local successful.
What did you see instead?
uaa log as attachment
uaa-server.log

Hello @JiaHaoJerry Thanks for creating this issue, unfortunately I am unable to reproduce.
 git co 4.12.1
./gradlew run --info
Tomcat 8.x started on port [8080]
[ant:cargo] Press Ctrl-C to stop the container...
Press Ctrl-C to stop the container...

Can you please provide some information on your environment (OS/ java version)?

Hello @DennisDenuto Thanks for your reply.
I use Windows10 to run UAA and  my java version is 1.8.0_131.
I modify uaa/webapp/WEB-INF/spring/saml-idp.xml to add  to bean "idpMetadataManager".
After do this the error java.lang.IllegalArgumentException: KeyManager must be set did not appear . But the process still stop on 97%. The log as attachment
uaa-server.log

@JiaHaoJerry thanks for providing that information. Can you show the git diff of what you changed in uaa/webapp/WEB-INF/spring/saml-idp.xml to add to bean "idpMetadataManager"

@DennisDenuto
uaa/webapp/WEB-INF/spring/saml-idp.xml
Before edit the code as below:
 <bean id="idpMetadataManager"
         class="org.cloudfoundry.identity.uaa.provider.saml.idp.NonSnarlIdpMetadataManager"
         depends-on="spMetaDataProviders" destroy-method="destroy">
       <constructor-arg name="configurator" ref="spMetaDataProviders" />
       <property name="refreshCheckInterval" value="${login.saml.metadataRefreshInterval:0}" />
       <property name="generator" ref="zoneAwareIdpMetadataGenerator"/>

   </bean>

After edit:
<bean id="idpMetadataManager"
        class="org.cloudfoundry.identity.uaa.provider.saml.idp.NonSnarlIdpMetadataManager"
        depends-on="spMetaDataProviders" destroy-method="destroy">
      <constructor-arg name="configurator" ref="spMetaDataProviders" />
      <property name="refreshCheckInterval" value="${login.saml.metadataRefreshInterval:0}" />
      <property name="generator" ref="zoneAwareIdpMetadataGenerator"/>
      <property name="keyManager" ref="idpZoneAwareSamlKeyManager"/>
  </bean>

Ping @JiaHaoJerry

@DennisDenuto It works. Thanks a lot.


Forwarding not working

Today I set up a fresh VM and installed wg-access-server on it. To my surprise it didn't work out of the box unlike my other server.
I think the reason is that on my old server I was adding forwarding config myself.
Relevant wg-access-server config parts:
vpn:
  cidr: "<IP_ADDRESS>/16"

  rules:
    allowVPNLAN: true
    allowServerLAN: false
    allowInternet: true
    allowedNetworks:
      - <IP_ADDRESS>/13
      - 40.71.XX.XX/32 # Servers external IP

Out of the box after the start of wg-access-server my iptables looked like this...

Executing...
sudo iptables -A WG_ACCESS_SERVER_FORWARD -o wg1 -j ACCEPT

Seemed to be enough to fix it. I don't really understand all the iptables rules, but most wireguard configs I looked at execute both -i wg1 and -o wg1.
But of course the chain is cleaned on each restart. So until it is fixed I am using this for now:
sudo iptables -A FORWARD -o wg1 -j ACCEPT
sudo iptables -A FORWARD -i wg1 -j ACCEPT

After that I tried setting allowInternet: false and expected it to continue working, but it didn't. Took me forever to debug, but the missing rule was:
sudo iptables -t nat -A WG_ACCESS_SERVER_POSTROUTING -s <IP_ADDRESS>/16 -o eth0 -j MASQUERADE

After that everything seems to be working as expected.
So...
		if err := ipt.AppendUnique("filter", "WG_ACCESS_SERVER_FORWARD", "-s", cidr, "-i", gatewayIface, "-o", wgIface, "-j", "ACCEPT"); err != nil {
			return errors.Wrap(err, "failed to set ip tables rule")
		}
		if err := ipt.AppendUnique("filter", "WG_ACCESS_SERVER_FORWARD", "-s", cidr, "-i", wgIface, "-o", gatewayIface, "-j", "ACCEPT"); err != nil {
			return errors.Wrap(err, "failed to set ip tables rule")
		}
		if err := ipt.AppendUnique("nat", "WG_ACCESS_SERVER_POSTROUTING", "-s", cidr, "-o", gatewayIface, "-j", "MASQUERADE"); err != nil {
			return errors.Wrap(err, "failed to set ip tables rule")
		}

Should be enabled regardless of whether AllowInternet is on and the filter rules need to be changed to only have one interface.
And then it should all work. If AllowInternet is false, then the REJECT rule should take care of the blocking (it worked in my case).

Hey it'd be great if you could attempt a PR for this one! I'd be happy to merge it in.

@KimchaC i've fixed this in the above commit. Let me know if that doesn't work for you.
You can try it using 0.2.0-rc5 or from master.


Rename to something shorter, more explicit or fun/memorable

There are only two hard things in Computer Science: cache invalidation and naming things. — Phil Karlton

True.
responsive-image-widths is not easy to spell (image or images? width or widths?) and type in a shell, so we would like to rename it to something shorter, and either more explicit or more fun/memorable.
Current options:
👍 srcset-sizer
😁 daltons (there is already a dalton package on npm, but there should be no ambiguity)
🎉 BRITS: Better Responsive Image Tools Selection
You can vote with reactions, and suggest other names in comments.

BRITS (Better Responsive Image Tools Selection)

@jygastaud no mention of width or size, which is the aim of the tool?

@ryuran @vvalentin-ca do you really believe there is no risk with a catchy but non self explicit name?

If the tool is interesting, it will be known by any name in my opinion.

@vvalentin-ca that's a valid point indeed.

RIWAL
As Responsive Image Widths et AL. (which means "and any other things/people/locations" from latin).
RIWAL is easy to say and to remember.
Just any idea ;)

Thanks @oliviermartinerie!

So be it, renamed to daltons!


Upload the distribution snapshot plugin zips to nexus maven snapshot repo.

Is your feature request related to a problem? Please describe
https://github.com/opensearch-project/opensearch-build/issues/1234
Describe the solution you'd like
mvn install:install-file -DgroupId=org.opensearch.plugin -DartifactId=pgplugin -Dversion=0.0.1 -Dpackaging=zip -Dfile=package.zip -DlocalRepositoryPath=../loacalrepo/
With the above cli command now we have folder created as maven coordinates
loacalrepo/org/opensearch/plugin/pgplugin/0.0.1
This will have pom file and zip file stored in loacalrepo/org/opensearch/plugin/pgplugin/0.0.1
settings.xml
<settings xmlns="http://maven.apache.org/SETTINGS/1.0.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0
                      https://maven.apache.org/xsd/settings-1.0.0.xsd">
  <servers>
    <server>
      <id>nexus</id>
      <username>${SONATYPE_USERNAME}</username>
      <password>${SONATYPE_PASSWORD}</password>
    </server>
  </servers>
</settings>

mvn --settings="${mvn_settings}" deploy:deploy-file -DgeneratePom=false -DrepositoryId=nexus -DpomFile=loacalrepo/org/opensearch/plugin/pgplugin/0.0.1/pgplugin-0.0.1.pom -Dfile=loacalrepo/org/opensearch/plugin/pgplugin/0.0.1/pgplugin-0.0.1.zip -Durl=$repo_url

Looks like a dup of https://github.com/opensearch-project/opensearch-build/issues/716

Hey @dblock, since there are two aspects for this maven publish, one for snapshots repo and other for actual release repo, the two repo workflows are not constant, as release repo has more wider process, like pre staging, promoting, signing, additional maven tags and then releasing, so I have created a meta issue https://github.com/opensearch-project/opensearch-build/issues/1916 that expands with more details based on the issue https://github.com/opensearch-project/opensearch-build/issues/716.
Right now the snapshot zips for maven snapshot repo, does not have an enforced workflow to publish a zip, unlike the actual release repo, so I have separated into two tasks for snapshot plugin zips and release plugin zips and together tracked in https://github.com/opensearch-project/opensearch-build/issues/1916.

Using the plugin opensearch.pluginzip and with existing CI worflows, the zips will signed and published
Example
https://repo1.maven.org/maven2/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>/
https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/opensearch-ml-plugin/<IP_ADDRESS>-SNAPSHOT/
Closing this issue as resolved :)
@dblock @bbarani


Deeper integration with postcss-loader

Currently I can't use postcss-modules due to not being able to access the loader context or get the bundle name of the processed file, so I can't generate modules/[name].json for each webpack entrypoint. It would be nice if postcss-modules could detect itself running under postcss-loader and expose the loader context to getJSON.
Alternatively, a way to call getJSON on an entire webpack bundle would be great.
I realize that these issues may be out of scope for this project.

I have the same use case, I want to import the CSS file directly from my JS file, like
index.css
.foo {}

.bar {}

index.js
import indexStyles from `./index.css`;

const div = document.createElement('div');

div.className = indexStyles.foo;


Explains manufacturing string information

Change-type: patch
Signed-off-by: Alex Bucknall<EMAIL_ADDRESS>

resolves #57


[VMD] Animation engine

Description
This PR provides an engine to drive animations from common code.
It supports all the basic types of animations:

Ease In
Ease Out
Ease In/Out
Custom Cubic Bezier
Spring

This PR also:

Refactor sample's Home Screen to include sections
Adds a SwiftUI utility to use foreach directly with VMDIdentifiableContent
Adds AtomicStackReference in trikot.foundation

Motivation and Context
Using the MVVM pattern it is pretty hard for a view to perform a change animated because the view layer don't have any insight on the type and context of a change. To alleviate that, we introduce the concept of animations in the view model layer.
There is basically two ways to perform an animated change:
Closure based
A closure based version suitable when the change occur as a result of the press of a button or a specific lifecycle event. All the published properties updated within that block will be animated.
withAnimation(VMDAnimation.Tween(duration = 1.seconds, easing = VMDAnimationEasing.Standard.EaseInEaseOut)) {
        // Perform the change here
}

Binding based
If the change is introduced as part of a binding on a reactive chain, we also have the possibility to bind a value animated. Instead of providing only the value, we have to supply a pair of the value and an optional animation object. The exemple bellow animates the alpha value but does not animate the initial value and animates only the visible -> hidden transition while performing the hidden -> visible change without animation.
bindHiddenAnimated(
    hiddenPublisher.withPreviousValue().map {
        val previousValue = it.first
        val value = it.second
        if (previousValue == null) { // No animation if its the first value received
            Pair(value, null)
        } else { // Optionally animate only some changes
            Pair(value, if (value) VMDAnimation.Tween() else null)
        }
    }
)

Usage in native code
SwiftUI
Since SwiftUI is able to automatically infer the updated properties and interpolate between them, there is no further step required for the animation to be effective. It is the equivalent of performing a change for a @State or an @ObservedObject within a withAnimation closure.
Jetpack Compose
It is a bit more effort on the Jetpack Compose side because the animation engine requires that we specifically declare an interpolator for a property to be animated.
Example for animation of the alpha value
val animatedHiddenProperty by viewModel.textField.observeAnimatedPropertyAsState(
    property = viewModel.textField::isHidden,
    transform = { hidden -> if (hidden) 0f else 1f }
)
val alphaAnimationProgress by animateFloatAsState(
    targetValue = animatedHiddenProperty.value,
    animationSpec = animatedHiddenProperty.animationSpec()
)

Notes
The previous animation mechanism that was iOS only and that would animate all the changes no mater the type of change have been completely removed as it is nearly unused internally and it has just been introduced.
Result
iOS
https://user-images.githubusercontent.com/291573/158255503-7b985480-776b-4c66-9726-54281c2c8c48.mp4
Android
https://user-images.githubusercontent.com/291573/158255555-3de5c3e2-fd39-43fd-b163-4797747620f5.mp4
How Has This Been Tested?
An animation showcase screen was added in the sample app.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Still reading the code, :amazed:

I did not work with Declarative VMs yet so I cannot give a profound opinion.
From my point of view, its 👍 . I think the WithAnimation block should be the way to go.

Not sure if it means the way to go over the other method or not but both the withAnimation block and bindXAnimated functions are required because the block based API cannot properly enclose a change in a reactive chain.


[BUG] [Databricks 12.2] RapidsDeltaWrite queries that reference internal metadata fail to run

Describe the bug
The plugin creates query plans that contain a RapidsDeltaWriteExec stub and later replaces it with a GpuRapidsDeltaWriteExec. However, if the entire query falls back to CPU before this replacement occurs then the query fails at runtime because RapidsDeltaWriteExec is not executable.
One use case that can trigger this is when the read query references internal metadata columns in a file scan, such as _databricks_internal_edge_computed_column_skip_row. There may be other use cases that we have yet to discover.
Example plan:
RapidsDeltaWrite
+- Project [a#15918, b#15919, c#15920]
   +- Filter (b#15919 >= d)
      +- Filter ((_databricks_internal_edge_computed_column_skip_row#16180 = false) AND UDF())
         +- FileScan parquet [b#15919,c#15920,_databricks_internal_edge_computed_column_skip_row#16180,a#15918] Batched: true, DataFilters: [], Format: Parquet, Location: TahoeBatchFileIndex(1 paths)[file:/tmp/pyspark_tests/0510-200844-r43n977z-10-59-236-39-master-122..., PartitionFilters: [], PushedFilters: [], ReadSchema: struct<b:string,c:string,_databricks_internal_edge_computed_column_skip_row:boolean>

Failure:
23/07/19 16:51:46 WARN GpuOverrides: Can't replace any part of this plan due to: Delta Lake metadata queries are not efficient on GPU
23/07/19 16:51:46 ERROR GpuFileFormatWriter: Aborting job 6b5305df-b442-4e05-92ba-3509be4f10a5.
java.lang.IllegalStateException: Should have been replaced with a GPU node before execution

Steps/Code to reproduce bug
Enable test_delta_deletion_vector test on Databricks 12.2
Expected behavior
Query should not fail.
Environment details (please complete the following information)
N/A
Additional context

It was never intended for RapidsDeltaWriteExec to be executable.  If RapidsDeltaWriteExec is trying to be executed then that means there's a plan tagging bug in the code that decided to place that node in the plan.

Here is some more information from some debugging I have been doing.
We see a DeleteCommand and convert it to GPU:
DeleteCommandEdgeMeta.tagSelfForGpu(): command=DeleteCommandEdge com.databricks.sql.transaction.tahoe.DeltaLog@238fe7dc, (b#2511 < d)
   +- SubqueryAlias spark_catalog.delta.`/tmp/pyspark_tests//0510-200844-r43n977z-10-59-160-63-master-21088-230952237//DELTA_DATA/GPU`
      +- Relation [a#2510,b#2511,c#2512] parquet
, target=SubqueryAlias spark_catalog.delta.`/tmp/pyspark_tests//0510-200844-r43n977z-10-59-160-63-master-21088-230952237//DELTA_DATA/GPU`
+- Relation [a#2510,b#2511,c#2512] parquet

During execution in GpuDeleteCommand.performDelete(), the query gets transformed to add a filter on _databricks_internal_edge_computed_column_skip_row and there is a call to GpuOptimisticTransaction.writeFiles which inserts a RapidsDeltaWrite, even though the query is no longer supported on GPU.
The child query of RapidsDeltaWriteExec at this point is the following CPU query:
*(1) Project [a#2510, b#2511, c#2512, _change_type#2708, isnotnull(_change_type#2708) AS __is_cdc#2714]
+- *(1) Project [a#2510, b#2511, c#2512, if ((b#2511 >= d)) null else delete AS _change_type#2708]
   +- *(1) Filter ((_databricks_internal_edge_computed_column_skip_row#2776 = false) AND UDF())
      +- *(1) ColumnarToRow
         +- FileScan parquet [a#2510,b#2511,c#2512,_databricks_internal_edge_computed_column_skip_row#2776] Batched: true, DataFilters: [], Format: Parquet, Location: TahoeBatchFileIndex(1 paths)[file:/tmp/pyspark_tests/0510-200844-r43n977z-10-59-160-63-master-247..., PartitionFilters: [], PushedFilters: [], ReadSchema: struct<a:int,b:string,c:string,_databricks_internal_edge_computed_column_skip_row:boolean>


Cleanup and improve assertions of ShotoverProcess

Changes:

The initial cargo build was swapped to run_command as that will print output on failure.
.env("RUST_LOG", "debug,shotover_proxy=debug") was removed as it did nothing (didnt bother investigating why) and it is incorrect (we should be logging at info level not debug level)
wait() now returns WaitOutput so we dont have to guess what tuple value contains what.
implemented AssertExitsWith which will trigger the requested assert when ShotoverProcess is dropped.

I realized the API I made here was really confusing.
The AssertExitsWith logic isnt run if wait is called.
Its also not intuitive to setup the AssertExitsWith logic in the constructor.
So I instead I rewrote it such that the Drop impl always panics if some kind of wait was not called.
At the very least @conorbros should rereview the PR.
@benbromhead can also take a look if he wants

@conorbros can relook at it thanks


OpenVPN Instances: Peer Certificate Authority

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[X] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[X] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Describe the bug
Using external certificate management may result in different CAs for server and client certificates. The old "Servers" configuration has an option "Peer Certificate Authority" to explicitly select the client CA.
The forum mentions that it is derived form the server certificate, which prevents migration of some existing rollouts.
To Reproduce
Steps to reproduce the behavior:

Create Instance with same parameters as existing server
Take server down, start instance
Connect with existing client configuration
See error:  VERIFY ERROR: depth=0, error=unable to get local issuer certificate: CN=XXXX

Expected behavior
The migrated instance should accept the clients as the server before.
Environment
OPNsense 23.7.1_3-amd64

Similar option has disappeared with new ipsec connection UI.
Legacy IPSec ui allowed to select/enforce the remote certification authority to check when validating remote certs in pubkey authentication. This was materialized by rightca=<issuer dn> in ipsec.conf.
In swanctl.conf it is now connections.<conn>.remote<suffix>.cacerts=<ca certificates> (certificate should be placed in cacerts directory), but for now the new ipsec UI don't allows to define it.
Same reasoning as discussed in #6709 can apply, is it worth a separate issue ?

@pfoo just open a new ticket, by default it should allow all configured CA's, but if you want to constraint, a selection might be possible.
https://github.com/opnsense/core/blob/27e723a00ed8e89c55d060c4be72ecf88780061b/src/etc/inc/plugins.inc.d/ipsec.inc#L1110-L1131


Steps to follow!

Basically, we will do the following steps for this task, if I were not wrong:

Initialize GitHub Actions by creating a .yml file within .github/workflows in the repository.
Define Workflow Triggers by specifying events like push or pull request to the main branch that initiate the workflow, which includes check out the repository, set up a Python environment, install necessary Python packages: numpy, matplotlib, pytest, flake8, perform linting using flake8, and run unit tests with pytest.
Finally, the Documentation part, where we will write instructions detailing the process of creating and configuring theGitHub Actions workflow.
Correct me if I was wrong here.

I think that you are pretty correct in here, thank you for sharing @tirthbha


#BuidlGuidl5 added check-in counter from the Batch Registry contract

Description
A counter to show how many builders are checked-in is added into index.tsx file
Additional Information

[x] I have read the contributing docs (if this is your first contribution)
[ ] This is not a duplicate of any existing pull request

Related Issues
Closes #{8}
Follows instruction for issue https://github.com/BuidlGuidl/batch1.buidlguidl.com/issues/8
Your ENS/address: babacan.eth / 0x5D70E3b540f58beCd10B74f6c0958b31e3190DA7

I know there is already a PR for this issue but I wanted to challenge myself and give a shot just for applying what I learned so far :)

Looking sharp @0xBabacan
Thank you!


Add anoushka to contributors list

Hi  @Anoushka-Anu, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Hi..I am very excited to learn to contribute to OSS ,this was my first
contribution so I am very happy about this ..Hope I could move further into
contributing.
Thank you so much for making me contribute for the fiirst time..Your
tutorial was perfect for beginners..Please list any new easy contributing
projects for newbies.
Thanks
Anoushka
On Sat, Sep 1, 2018 at 12:06 AM Roshan Jossey<EMAIL_ADDRESS>wrote:

Hi @Anoushka-Anu https://github.com/Anoushka-Anu, I'm quite elated
about your pull request. I wanna evolve this project to addresses various
problems faced by first-time contributors. I'd love to learn about your
journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a
pull request and learned that I merged it?
We’ve recently added social share to our web app. Could you please go to
https://roshanjossey.github.io/first-contributions/#social-share and
share your first contribution to open source? Also, check out projects with
easy issues while you’re there.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Roshanjossey/first-contributions/pull/6362#issuecomment-417754442,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ae8z_ufYK784aL3-sdN8ZSw8E5JjFqGdks5uWYI4gaJpZM4WVriO
.

I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh


fix(space-wizard): improve ux as per design, remove tech debt and fix some defects

Closes #1043
Closes #885
Closes #1208
Closes #1071

ux improvements
==============

improve responsive behavior of wizard with edge,firefox,safari and chrome
resolve white space overflow issue causing  dialog to appear malformed when page resized
bring ux in closer conformance with ux design.
add wizard step visualizer ( i.e show current step indicator on top of forge form)
add wizard pipeline visualizer (i.e show pipelines stages/description as returned from forge)

feature fixes
===========

add visualizers per ux designs
add codebase to space and close wizard dialog after used acknowledges result

tech debt improvements with a view to moving to an npm module
=================================================

better encapsulate styles and style cleanup /refactoring
clean up and linting
refactor dialog close logic
improve error handling
prep for moving to npm module
added optional console log formatting

There were the following issues with your Pull Request

Commit: d4538b5e4af59801a9bb2eb78194364122effa6b

Your subject line is longer than 50 characters

Commit: b4e02425bda74fdfd48634d595b0b2edadb0e0cf

Your subject line is longer than 50 characters

Commit: 44a3011ab92d45d38bdcc87fc96c8e879b0227c3

Your subject line is longer than 50 characters

Commit: a4e98b881fc9dc299661bd5bdb538c3f6ef8ea9c

Your subject line is longer than 50 characters

Commit: 3e809104e71f6bf502e792157de583bfb6aa3f69

Your subject line is longer than 50 characters

Commit: 369cebc3c403f9350bf5c827421b7356a8729701

Your subject line is longer than 50 characters

Commit: b0204a2b3b00ec97d908d08f463a8afe54f9e4ff

Commits must be in the following format: %{type}(%{scope}): %{description}

Commit: 5326a6a560f6ea1e0b71473c4a40031196524a7c

Your subject line is longer than 50 characters

Commit: 5e9df857b7185b21661fca6e2342e03f18701b35

Your subject line is longer than 50 characters

Commit: b4c5a075b432d0600489412eb1a0603b6b647a40

Your subject line is longer than 50 characters

Commit: 069bc31cd82352676ef45e77878a2992fe694b75

Your subject line is longer than 50 characters

Commit: 13cd9cb143dcab74e157a09afe9014b250226235

Your subject line is longer than 50 characters

Commit: 86587e38ff8c2b9db901feec09816e02a904e788

Commits must be in the following format: %{type}(%{scope}): %{description}

Your subject line is longer than 50 characters

Commit: 725d05e9977d9ab47d784a74ffd0147fe1c07942

Your subject line is longer than 50 characters

Commit: b14616dee67c1c76fe42b273e553ff46b1b1aeb5

Your subject line is longer than 50 characters

Guidelines are available at https://github.com/fabric8io/fabric8-ui

This message was auto-generated by https://gitcop.com

Can one of the admins verify this patch?

@mitchharpur snapshot fabric8-ui is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-1309-fabric8-ui.int.rdu2c.fabric8.io

[test]

Please rebase.


How to create new table, database dynamically ?

Hi, please @David Fahlander, this is my scenario:
What i want
1-I have an ecommerce  backend which host article to sell
2-I have my electron application wich use Dexie db
3-I want to allow end user to :
a-Create or delete or edit new Database
b-Create or delete or edit new tables to a selected database
4-Each modification on the offline part (electron app) will be replicate to the online server.
The question
My question: is Dexie allow me to make a sort of app with hight risque ?
And if Ok,
-How to create programmatically new database an new tables ?
PS: i found this https://stackoverflow.com/questions/39000780/errors-with-indexeddb-versions-and-dexie-js?rq=1 at StackOverflow but it is not clear for me.

hi,
You can create delete db dynamically, try play with this sample code and se if it helps in undestanding ...
//
// !!Please open your console in devtools to see any action!!
//

async function changeSchema(db, schemaChanges) {
	db.close();
	const newDb = new Dexie(db.name);

	newDb.on('blocked', () => false); // Silence console warning of blocked event.
	// Workaround: If DB is empty from tables, it needs to be recreated
	if (db.tables.length === 0) {
		await db.delete();
		newDb.version(1).stores(schemaChanges);
		return await newDb.open();
	}

	// Extract current schema in dexie format:
	const currentSchema = db.tables.reduce((result, { name, schema }) => {
		result[name] = [ schema.primKey.src, ...schema.indexes.map((idx) => idx.src) ].join(',');
		return result;
	}, {});

	console.log('Version: ' + db.verno);
	console.log('Current Schema: ', currentSchema);

	// Tell Dexie about current schema:
	newDb.version(db.verno).stores(currentSchema);
	// Tell Dexie about next schema:
	newDb.version(db.verno + 1).stores(schemaChanges);
	// Upgrade it:
	return await newDb.open();
}

// Open database dynamically:
async function playAround() {
	let db = new Dexie('FriendsDatabase2');
	if (!await Dexie.exists(db.name)) {
		console.log('Db does not exist');
		db.version(1).stores({});
	}
	await db.open();
	console.log('Could open DB');

	// Add a table with some indexes:
	db = await changeSchema(db, {
		friends: 'id, name',
	});
	console.log('Could enforce friends table with id and name');

	// Add another index in the friends table
	db = await changeSchema(db, {
		friends: 'id, name, age',
	});
	console.log('Could add the age index');

	// Remove the age index again:
	db = await changeSchema(db, {
		friends: 'id, name',
	});
	console.log('Could remove age index');

	// Remove the friends table
	db = await changeSchema(db, {
		friends: null,
	});
	console.log('Could delete friends table');
}

playAround().catch((err) => console.error(err));


Provide documentation to allow users to produce their own images.

Something like:
If you prefer an OS base image distribution that we don't provide an image for, you can copy the JDK using the COPY --from instruction in a Dockerfile, similar to the following example:
Dockerfile
# Example of using Temurin image to create a new image with a different base image
FROM debian:buster-slim
ENV JAVA_HOME /usr/lib/jvm/temurin-11-amd64
ENV PATH "${JAVA_HOME}/bin:${PATH}"
COPY --from=dockerhub.com/eclipse-temurin/jdk:11-ubuntu $JAVA_HOME $JAVA_HOME

# Continue with your application deployment
RUN mkdir /opt/app
COPY japp.jar /opt/app
CMD ["java", "-jar", "/opt/app/japp.jar"]
To create a custom Java runtime image, use a Dockerfile similar to the following example:

@gdams Unless I misheard I believe you said in one of our calls today that you'd done this. Can you clarify where it is please?

it's all documented in https://github.com/docker-library/docs/pull/2008
Specifically:
Using a different base Image
If you are using a distribution that we don't provide an image for you can copy the JDK using a similar Dockerfile to the one below:
# Example
FROM <base image>
ENV JAVA_HOME=/opt/java/openjdk
COPY --from=%%IMAGE%%:11 $JAVA_HOME $JAVA_HOME
ENV PATH="${JAVA_HOME}/bin:${PATH}"

Creating a JRE using jlink
On OpenJDK 11+, a JRE can be generated using jlink, see the following Dockerfile:
# Example of custom Java runtime using jlink in a multi-stage container build
FROM %%IMAGE%%:11 as jre-build
# Create a custom Java runtime
RUN $JAVA_HOME/bin/jlink \
         --add-modules java.base \
         --strip-debug \
         --no-man-pages \
         --no-header-files \
         --compress=2 \
         --output /javaruntime
# Define your base image
FROM debian:buster-slim
ENV JAVA_HOME=/opt/java/openjdk
ENV PATH "${JAVA_HOME}/bin:${PATH}"
COPY --from=jre-build /javaruntime $JAVA_HOME
# Continue with your application deployment
RUN mkdir /opt/app
COPY japp.jar /opt/app
CMD ["java", "-jar", "/opt/app/japp.jar"]

Let's sit on this until dockerhub.com/eclipse-temurin is available then share more widely.

This will be shared in https://github.com/adoptium/blog.adoptium.net/pull/84


gfycat mp4 support.

Hi, in the  mime_parsers.py  you choose webm as default format for gfycat, but gfycat provide better and smaller file in mp4 format. For example here the output of youtube-dl --list-format on a gfycat link
webm         webm       1920x1080  56.50MiB
mp4          mp4        1920x1080  4.77MiB (best)

By modifying the mime_parsers.py I get the mp4 as default format, here's the modifications
--- mime_parsers.py	2018-09-23 16:51:33.165590261 +0200
+++ /usr/lib/python3.7/site-packages/rtv/mime_parsers.py	2018-09-23 16:49:21.805756332 +0200
@@ -113,8 +113,8 @@
         parts = url.replace('gifs/detail/', '').split('/')
         api_url = '/'.join(parts[:-1] + ['cajax', 'get'] + parts[-1:])
         resp = requests.get(api_url)
-        image_url = resp.json()['gfyItem']['webmUrl']
-        return image_url, 'video/webm'
+        image_url = resp.json()['gfyItem']['mp4Url']
+        return image_url, 'video/mp4'

 class YoutubeMIMEParser(BaseMIMEParser):

Would be nice if you can merge the modification into rtv.

Just make a pull request. First time doing that I hope I did it properly :)


[Feature]: ERC-721 Enumerable protection

Feature Request
For theerc721_enumerable_component to work, its logic must be included in the contract, adding sensitive code into mint(), burn(), and re-implementing functions transfer_from() and safe_transfer_from (). The erc721:: enumerable_mintable_burnable preset exemplifies it.
This logic should be insideerc721_enumerable_component, and not exposed to the contract creator. Any changes to that could make the components behave erratically.
Proposed Solution
By using existing SRC5 introspection, erc721_balance_component can understand if the contract is using erc721_enumerable_component or not, and ask it to do what it has to do inside transfer_from() and safe_transfer_from (). Contracts that do not require this component should still include them, but not expose its functions.

Enable SRC5 introspection on all ERC-721 components.
Include the enumerable component on all components that access erc721_balance_component.
Include the enumerable component on all contracts, even the ones that do not use it, like presets::erc721::mintable_burnable.cairo. Enumerable functions must not be embedded on these contracts.
Add initialise() function to erc721_enumerable_component, calling sr5.register_interface(IERC721_ENUMERABLE_ID). Contracts that make use of erc721_enumerable_component need to call that function at construction time.
Add after_transfer() function to erc721_enumerable_component, with the logic currently at the preset, updating its models accordingly.
Check if the contract makes use of erc721_enumerable_component by calling sr5.supports_interface(IERC721_ENUMERABLE_ID), and call erc721_enumerable_component::after_transfer() if it does.
Remove internal calls from the erc721:: enumerable_mintable_burnable preset.
Remove transfer_from() and safe_transfer_from () from the erc721:: enumerable_mintable_burnable preset, and expose the original functions from erc721_balance_component.

Alternatives
Adding before_update() and after_update() hooks to erc721_balance_component, like OpenZeppelin does. but implementing that inside another component is not possible, and should be included inside the token contract, which takes us back to the original problem we're trying to solve.
Related Code
No response
Additional context
No response
If the feature is accepted, would you be willing to contribute it?

[X] Yes I would be willing to contribute

already working on this, will open PR as soon as #79 is closed.

Hi @rsodre can i work on this?


Sandbox API work continued

What is the problem you're trying to solve
There are still lots of work that is not merged about Sandbox API, this issue is a track of these requests
Describe the solution you'd like

[x]  https://github.com/containerd/containerd/pull/8268
[x]  https://github.com/containerd/containerd/pull/9275
[x]  https://github.com/containerd/containerd/pull/9279
[x] https://github.com/containerd/containerd/pull/9391
[x] https://github.com/containerd/containerd/pull/9463
[x] https://github.com/containerd/containerd/pull/9644
[x] https://github.com/containerd/containerd/pull/9617
[x] https://github.com/containerd/containerd/pull/9598
[x] https://github.com/containerd/containerd/pull/9736
[x] https://github.com/containerd/containerd/pull/9738
[x] https://github.com/containerd/containerd/pull/9853
[x] https://github.com/containerd/containerd/pull/9883
[x] https://github.com/containerd/containerd/pull/9903
[x] https://github.com/containerd/containerd/pull/9965
[x] https://github.com/containerd/containerd/pull/10190
[x] https://github.com/containerd/containerd/pull/10201
[ ] https://github.com/containerd/containerd/pull/9904
[x] https://github.com/containerd/containerd/pull/9882
[ ] https://github.com/containerd/containerd/pull/9884

Additional context
No response

Priority:

#9736 #9903
#9965
#9853 #9882 #9883
#9884
#9904

Excuse me, When can these PRs be merged  at the latest?

@abel-von Hi, when will this work be completed?

@silence-coding Thanks for your attention! These PR were ready, waiting for review of containerd maintainers.

@silence-coding Thanks for your attention! These PR were ready, waiting for review of containerd maintainers.

It's been over a month. Is there an expected timeline?

@abel-von @dmcgowan The rest of the tasks can be safely moved to the v2.1 milestone?

Although sanboxer has been abstracted, I found that after the task server provided by sanboxer restarts, containrd still restarts the container to which it belongs.
https://github.com/containerd/containerd/blob/c0cdcb34f189459e11f8b90d271577914aee7339/internal/cri/server/container_start.go#L147C1-L185C75

Sorry, I don't quite get it, what is the problem with the cited codes? @silence-coding


WIP: add new version of intoto type

[ ] move tests out of e2e dir and into pkg-specific version
[ ] add test coverage

Summary
This adds v0.0.3 of the intoto type, aiming to address a few issues in v0.0.2:

https://github.com/sigstore/rekor/issues/1139
https://github.com/sigstore/rekor/issues/1164
ensure that index keys and digests are computed only off of validated inputs
more cleanly separating the schema between what should be proposed VS what is returned from the log

Release Note
Adds new default version of intoto type
FYI @pxp928 @bdehamer

sorry, quick comment before I dive in: wdyt about renaming to a dsse type? i was talking with @laurentsimon and had a huge amount of confusion myself about what content/payloadHash referred to, and if it's a dsse type it could be better named as predicate/envelopeHash
I think this came up in an issue before but I can't find a reference.

sorry, quick comment before I dive in: wdyt about renaming to a dsse type? i was talking with @laurentsimon and had a huge amount of confusion myself about what content/payloadHash referred to, and if it's a dsse type it could be better named as predicate/envelopeHash
I think this came up in an issue before but I can't find a reference.

In https://github.com/sigstore/rekor/blob/224afcab4145900192f3f5354f7e0e1cf96a3c1b/pkg/types/intoto/v0.0.3/intoto_v0_0_3_schema.json#L12 I tried to make this clear that this would only accept DSSE envelopes that are signed intoto attestations.
I would presume that a more generically named dsse type could refer to any payload, but this type has been specific to intoto attestations?

My two cents:
I think it would be a bit cleaner to have the type referring to the outer envelope, e.g. dsse. Then after the envelope is parsed, we can extract certain fields based on a set of payload types Rekor recognizes, such as in-toto statements (and the predicate type for build provenances like it is today). This is e.g. how cose does it: https://github.com/sigstore/rekor/blob/fd8e054af754dcb9e8861c0a9189669ee443e2d7/pkg/types/cose/v0.0.1/entry.go#L115.
The risk with this is of course that there can be a combinatorial explosion of "subtypes" in the dsse type, but with proper structure of the code I think it should be fine.
I guess with this way, it would be easier for a consumer to use.
To start with we may only recognize in-toto statements, but any dsse enevelope could be uploaded.


File writer that includes message metadata

Is there currently a supported way to include message metadata in the delimited text output (such as offset, topic, partition, and timestamp)? After searching through the code a bit, it seems like that isn't supported without some customization on our end.
We'd like to output these fields as part of each logged message value for searching (such as indexing on it in elastic) and programatic replay (finding a particularly small window of offsets in a file).
Have I just overlooked an obvious setting that can accomplish this, and if not, would it be something useful enough to submit in a pull request?
Thanks!

We usually don't keep those metadata on per message level.  Some of the metatdata (e.g. topic/partition, starting offset was kept per file level).
If you want to do it on per message level, you can implement the MessageTransformer class to do that.


major update to plotting options

hello here are the new things:

label_color to set color of labels
tick_direction and tick_color to use inward/outward axis ticks with custom colors
colorbar_ticksize, colorbar_label, colorbar_label_size do what you'd expect them to do
patch for adding a beam/FWHM to the bottom right of the figure
added minorticks
return_fig_ax to instead return the figure to modify in python rather than showing it (or saving)
Original behaviour is maintained. Unfortunately we are still on matplotlib 3.4 because log=True breaks in 3.5
Has it been tested? yes

Thanks!


Custom validation groups

Given you can't define specific groups to validate on sub-types with @Assert\Valid (see here), validating them is a major hassle with having to follow the flow_<formName>_step<stepNumber> format.
It would be really helpful to be able to define some additional validation groups in the steps config:
/**
 * {@inheritDoc}
 */
protected function loadStepsConfig()
{
    return array(
        array(
            'label' => 'delivery',
            'type' => new DeliveryType,
            'groups' => array('address')
        ),
        array(
            'label' => 'payment',
            'type' => new PaymentType,
            'groups' => array('address')
        )
    );
}

That way my AddressType sub-type could simply define the assertions within an "address" group, and then when it's used in both the delivery (shipping address) and payment (billing address) steps, I don't have to define both the "flow_checkout_step1" and "flow_checkout_step2" validation groups.

Could you have a close look at #172?

Thanks, that looks spot on. I'll give it a test over the next few days.


chore(main): release 22.1.0

:robot: I have created a release beep boop
22.1.0 (2024-08-31)
Features

Added split-view to the plugin (308024c), closes #131

Bug Fixes

Fixed a bug causing callbacks to not work. (6641174)
Minor bug fixes for splitView (3471b7b)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v22.1.0
:sunflower:


Create compilation mode for serving native ES Modules

Suggestion
import { Foo } from './foo';
It would be nice if the above import in TypeScript could be compiled into the following:
import { Foo } from './foo.js';
So that one could serve TS-compiled-into-ES-modules directly from the browser (without a "pack" step).
Background: I have a large web app written in JS that uses native ES modules (import { Foo } from './foo.js') that can be served in a debug mode (i.e. serve the raw ES modules directly to the browser without a bundling step). For production, I also have a step that concats all modules into a giant JS bundle for production serving, but this is specifically about the "debug" step, making the edit-save-test use case as quick as possible.
Now I'd like to start converting this app into a TypeScript app piecemeal. The primary motivation is to take advantage of static analysis and autocomplete/suggestions from excellent tools like VS Code.
I have updated my build steps to include a tsc compilation step which properly takes all JS/TS files in src/, compiles them into JS files, and puts them into the dist/ folder for serving. Unfortunately the imports are the problem - changing the import to the extension-less target would help VS Code resolve to the TypeScript, but doesn't solve the serving ES modules in the browser use case.
I'm assuming this would be some new output compiler option in tsc...
🔍 Search Terms
ES Modules, Compilation, Import, Debugging
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
--compileToEsModule option in tsc/tsconfig
📃 Motivating Example
This would take a TS file like src/bar.ts:
import { Foo } from './foo';
let result: Foo.Result = Foo.run();

and output a JS file like dist/bar.js:
import { Foo } from './foo.js';
let result = Foo.run();

💻 Use Cases

Quick debug steps.
Serving native ES modules directly (in smaller web apps).
Further native ES module interop (all browsers now support it natively).
Help people when learning TypeScript for the first time

See also https://stackoverflow.com/questions/55251956/how-does-javascript-import-find-the-module-without-an-extension

Ok, I didn't dig deep enough - found https://github.com/microsoft/TypeScript/issues/16577#issuecomment-703190339 and all the surrounding duped issues. I'm sad that this isn't a simple fix, but not surprised.
However, I would like to point out that in my experience, using VS Code, import { Foo } from './foo.js' works, but the editor did not seem to have the proper TS context (?) to make useful autosuggest features for me, my guess is that it's because it's importing JS and not TS.

I take it back - VS Code can deal with this just fine, apparently.


JS (CountSubstrAPI): Draft implementation of count_substr

I kindly request feedback regarding my recent changes. The current implementation is not functioning as expected, and due to my limited experience with C, it's challenging to comprehend the underlying processes.

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


update object under spec to null not work

Rancher versions:
rancher/server: 2.0
rancher/agent:
Steps to Reproduce:

add a cluster
go to logging, select a target, saved
change to another target, saved, could see from the UI request, UI send the request to that set the old target to null, but it not work, the old target still here.

The same problem happens to other crd, like pipeline, alert, or ... We test around three days before, it could success set null to the crd, but the framework seems has some issue now.

verify worked


[SwipeableDrawer] Buttons and other interactable components prevent opening a Swipeable edge drawer.

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Current behavior 😯
On mobile, when there is a button, slider, checbox etc... as part of the swipeable drawer edge (Demo), you cannot click on them, due to them inheriting the pointer-events: none style.
Forcefully overriding it to the pointer-events: all allows you to now click on the components, but can no longer open the draw when dragging with them.
Expected behavior 🤔
You should be able to swipe to open the drawer, and also interact with the components in the edge component.
Steps to reproduce 🕹
Please see demo:
Requires mobile touch emulation in order to see the effects:
https://codesandbox.io/s/swipeableedgedrawer-material-demo-forked-d3shm?file=/demo.js
Context 🔦
We have a swipeable edge drawer, that is really hard to open due to having a large button in it.
I have already identified and come up with a solution in my PR.
Your environment 🌎

`npx @mui/envinfo`
  System:
    OS: Windows 10 10.0.19042
    CPU: (12) x64 AMD Ryzen 5 2600X Six-Core Processor
    Memory: 6.90 GB / 15.93 GB
  Binaries:
    Node: 14.17.6 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.17 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 6.14.15 - C:\Program Files\nodejs\npm.CMD
  Managers:
    Composer: 1.8.6 - C:\ProgramData\ComposerSetup\bin\composer.BAT
    pip2: 20.2.2 - C:\Program Files (x86)\Python27-18\Scripts\pip2.EXE
    pip3: 19.0.3 - C:\Program Files (x86)\Python37-32\Scripts\pip3.EXE
  Utilities:
    Git: 2.31.1.
  Virtualization:
    Docker: 20.10.6 - C:\Program Files\Docker\Docker\resources\bin\docker.EXE
  SDKs:
    Windows SDK:
      AllowDevelopmentWithoutDevLicense: Enabled
      AllowAllTrustedApps: Enabled
      Versions: 10.0.17763.0, 10.0.18362.0, 10.0.19041.0
  IDEs:
    VSCode: 1.63.2 - C:\Program Files\Microsoft VS Code\bin\code.CMD
    Visual Studio: 16.11.31702.278 (Visual Studio Community 2019)
  Languages:
    Bash: 5.0.17 - C:\Windows\system32\bash.EXE
    PHP: 7.3.7 - C:\PHP7\php.EXE
    Python: 2.7.18
  Browsers:
    Chrome: 97.0.4692.99
    Edge: Spartan (44.19041.1266.0), Chromium (97.0.1072.69)
    Internet Explorer: 11.0.19041.1202

Tested in multiple browsers, on both desktop and mobile, both iOS and Android.

Any movement on this?

@Agrejus He made a PR and it got merged recently, update MUI to the latest version and it should work using allowSwipeInChildren={true}.

It's 2K24, still actual issue, not fixed


Stripe fields allow infinite input when clearing the field by highlighting all contents

Reproduction
Input values into a Stripe field, highlight all values then press backspace to clear. The user will now be able to enter infinite values with the cursor staying at the beginning of the field.
Summary
This issue applies to all Stripe fields. It is triggered by clearing the field by highlighting all field contents and either inputting new values or pressing backspace/delete. Once the fields maximum character input is reached, the new values overwrite the existing.
Focusing on another element will fix this issue.
Can be reproduced in the demo jfiddle: https://jsfiddle.net/attystripe/xux7qzch/

Hi @msweett, sorry to hear this isn't working as expected. I just tried to reproduce this behavior in two different browsers (Desktop Chrome and Safari) and I'm not seeing the contents get overwritten as you described. Could you share your specific platform and browser version, and also let me know the results of testing in an incognito or private browsing window in that browser?

Hi @fred-stripe, I am using a mac (OS v. 10.13.5) and have been seeing this issue on Chrome (Version 69.0.3497.100 Official Build 64-bit) in both in normal and incognito mode.
This doesn't seem to be an issue on FireFox or Safari.

Thanks for the details @msweett! It seems that I'm on a slightly different version of Chrome (69.0.3497.92), but my colleague was able to reproduce on the version you mentioned. Interestingly this does not happen with Chrome Canary. Will test further and let you know what we find!

Hey @msweett, sorry to keep you waiting on a reply! We did some extensive testing and we could sometimes reproduce this issue in Chrome 69.0.3497.100. Based on our testing this issue doesn't happen at all in Chrome Canary so we believe this has already been addressed by the Chrome team. If you have further concerns please let us know!


Improve performance

Benchmarking Mapperly with https://github.com/mjebrahimi/Benchmark.netCoreMappers, we get the following results:
|        Method |       Mean |    Error |    StdDev |  Gen 0 |  Gen 1 | Allocated |
|-------------- |-----------:|---------:|----------:|-------:|-------:|----------:|
|   AgileMapper | 2,310.4 ns | 42.40 ns |  91.27 ns | 0.6714 | 0.0038 |      3 KB |
|               |            |          |           |        |        |           |
|    TinyMapper | 3,242.9 ns | 28.77 ns |  30.78 ns | 0.4578 |      - |      2 KB |
|               |            |          |           |        |        |           |
| ExpressMapper | 3,175.4 ns | 63.40 ns | 122.15 ns | 1.0414 | 0.0076 |      5 KB |
|               |            |          |           |        |        |           |
|    AutoMapper | 1,582.5 ns | 31.25 ns |  47.71 ns | 0.4044 | 0.0019 |      2 KB |
|               |            |          |           |        |        |           |
| ManualMapping |   535.2 ns | 10.72 ns |  19.88 ns | 0.2465 | 0.0005 |      1 KB |
|               |            |          |           |        |        |           |
|       Mapster |   545.6 ns |  5.08 ns |   4.51 ns | 0.4044 | 0.0010 |      2 KB |
|               |            |          |           |        |        |           |
|      Mapperly |   843.0 ns |  7.27 ns |   6.80 ns | 0.5178 | 0.0029 |      2 KB |

This is already pretty good, but I think we can improve this to match the ManualMapping time. We need to profile this, but I think the main culprit is our LINQ usage.

The major performance optimizations are done, closing this for now. Future optimizations will be done on a per-case basis.


Go client

When building this, I tried to mimic the Python client's API as closely as possible. However, some method names are simpler in the Go version (in alignment with Go idiom). Also, the Go client obviously has to pay more attention to type information than the Python client.

Thanks for the contribution!


PowerBroadcastReceiver will no longer be received.

As of Oreo, Android will no longer Broadcast a ACTION_POWER_CONNECTED / DISCONNECTION broadcast, if targetSDKVersion >= 26.
See: https://developer.android.com/guide/components/broadcast-exceptions
Unless I am missing something ( always a possibility!), this class will no longer be called under any circumstances.

Sorry, missed that you were using an explicit receiver, I had assumed it was implicit.


Add Restore Table/Database module guidance to CockroachCloud docs

Recovery Information link (table/database):

Link opens modal with information for push-button RESTORE
User pushes button to RESTORE
User checks status on the CC Ops List Page (and is kicked there once job starts)

@lnhsingh, is this issue the same as https://cockroachlabs.atlassian.net/browse/CC-1772?src=confmacro? Do we expect to have these docs in place for the 20.2 release, or will it come later since CC isn't on the same cadence. Trying to figure out if we should call this out in the 20.2 release notes.
cc @mwang1026, @kannanlakshmi

It's possible but I would say don't plan on the RESTORE changes being ready for marketing release.

Likely we'll release RESTORE to GCP before AWS, with AWS coming later.


Error in JUnit4 readme

In the example to "Adding mock beans", there are two errors I think.

The test class is called TestClassProducerTest, but MockBeanTest is added to the container instead.
In the body of the produceBar method, there is one closing parentheses too much at the end

You're right, thanks for pointing it out!


⚠ DDoS-Relay EU-C-fsn1-1 has degraded performance

In 77bbc91, DDoS-Relay EU-C-fsn1-1 (http://<IP_ADDRESS>:42069/;csv) experienced degraded performance:

HTTP code: 200
Response time: 187 ms

Resolved: DDoS-Relay EU-C-fsn1-1 performance has improved in c261b98 after 5 minutes.


groonga: 8.0.5 -> 8.0.6

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from groonga.
meta.description for groonga is: '"An open-source fulltext search engine and column store"'.

Checks done (click to expand)

built on NixOS
/nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/bin/groonga-suggest-create-dataset passed the binary check.
/nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/bin/groonga passed the binary check.
Warning: no invocation of /nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/bin/groonga-benchmark had a zero exit code or showed the expected version
/nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/bin/groonga-httpd passed the binary check.
Warning: no invocation of /nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/bin/groonga-httpd-restart had a zero exit code or showed the expected version
3 of 5 passed binary check by having a zero exit code.
0 of 5 passed binary check by having the new version present in output.
found 8.0.6 with grep in /nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6
directory tree listing: https://gist.github.com/a1443e14ad969c9e4bb353be1d6c0da8
du listing: https://gist.github.com/76b3b6e6d8036ae247db02632c2b0a61

Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

Install cachix from https://cachix.org/
Use r-ryantm's cache:cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:
nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/26cbe20c6e0ef83d98b0fbf7c0edfe82b15c32cb.tar.gz -p groonga
ls -la /nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6

cc @ericsagnes for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: groonga
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: groonga
Partial log (click to expand)
/nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/share/groonga/examples/dictionary/eijiro/eijiro-import.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/share/groonga/examples/dictionary/init-db.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/share/groonga/examples/dictionary/gene95/gene-import.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/share/groonga/examples/dictionary/edict/edict-import.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6...
moving /nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/sbin/* to /nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6/bin
running install tests
Groonga 8.0.6 [linux-gnu,x86_64,utf8,match-escalation-threshold=0,nfkc,mecab,onigmo,epoll]

configure options: < '--disable-static' '--disable-dependency-tracking' '--prefix=/nix/store/hqz0fks2c2kplslaac46166r8rg5y4g3-groonga-8.0.6' 'CC=gcc' 'CXX=g++' 'PKG_CONFIG_PATH=/nix/store/l2n5wqqnkhgmm8hqnl9cxyqwcy6vh9n3-kytea-0.4.7/lib/pkgconfig:/nix/store/nz19axinbk6kb554z6yx0dmm3r14yd1v-libedit-20180525-3.1-dev/lib/pkgconfig:/nix/store/n5a8v7vz4vv054vdigc5bl5qlm4ja8wy-ncurses-6.1-dev/lib/pkgconfig'>

Success on aarch64-linux (full log)
Attempted: groonga
Partial log (click to expand)
/nix/store/9ncd57qpv8agsc41qky3m21shgm5v9j0-groonga-8.0.6/share/groonga/examples/dictionary/gene95/gene-import.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/9ncd57qpv8agsc41qky3m21shgm5v9j0-groonga-8.0.6/share/groonga/examples/dictionary/eijiro/eijiro-import.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/9ncd57qpv8agsc41qky3m21shgm5v9j0-groonga-8.0.6/share/groonga/examples/dictionary/edict/edict-import.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/9ncd57qpv8agsc41qky3m21shgm5v9j0-groonga-8.0.6...
moving /nix/store/9ncd57qpv8agsc41qky3m21shgm5v9j0-groonga-8.0.6/sbin/* to /nix/store/9ncd57qpv8agsc41qky3m21shgm5v9j0-groonga-8.0.6/bin
running install tests
Groonga 8.0.6 [linux-gnu,aarch64,utf8,match-escalation-threshold=0,nfkc,mecab,onigmo,epoll]

configure options: < '--disable-static' '--disable-dependency-tracking' '--prefix=/nix/store/9ncd57qpv8agsc41qky3m21shgm5v9j0-groonga-8.0.6' 'CC=gcc' 'CXX=g++' 'PKG_CONFIG_PATH=/nix/store/szhdgk5v63w3ffakzmkc2hn26pglc1ha-kytea-0.4.7/lib/pkgconfig:/nix/store/wm3jimwrw6rp38lav4p8qz3dbahs7zzm-libedit-20180525-3.1-dev/lib/pkgconfig:/nix/store/ys5m0l9hwrizy55fw0sa34l0dq3i8n6p-ncurses-6.1-dev/lib/pkgconfig'>
/nix/store/9ncd57qpv8agsc41qky3m21shgm5v9j0-groonga-8.0.6


7ac8822c-4ef0-4194-adf0-74290611b1c6: "COVID-19AirwayEpitheliumImmune" (New<EMAIL_ADDRESS>

Done and import form completed

Missing cell count (Missed that in previous release)

Actually, forget that
Data browser is still not indexing project.estimated_cell_count, so this is expected


Eval displays 'nan' with 'reg:gamma' objective and 'gblinear' booster

I noticed the tree evals keep displaying 'nan's with  'reg:gamma' objective and 'gblinear' booster. The default eval metric for "reg:gamma" objective is "gamma-nloglik". Below is the notebook that can reproduce the issue:
https://github.com/gorkemozkaya/ds_debugging/blob/master/xgboost_gamma_regression.ipynb

I have also found similar behaviour behaviour. Here is the script used to reproduce.
https://gist.github.com/honzasterba/79bfcb95e6c183479b45218a40b8af3b
Is this a bug?

@hcho3 , can you verify if this is a bug?


BUG: run: extracttar error: exit status 1, output: error extracting tar

in a test, we have 3 linearly dependent images:

image/test-1
acbuild ...

image/test-2
acbuild dep add image/test-1
acbuild ...

image/test-3
acbuild dep add image/test-2
acbuild ...

when each image is small, build for all of them works fine

when each image size gets to some 100 MB (individually, compressed), the following error starts to occur during image/test-3 build, after image/test-2 download:

run: extracttar error: exit status 1, output: error extracting tar

the only apparent breaking point trigger is adding more packages to the image, not clear why:
https://github.com/appc/acbuild/blob/master/vendor/github.com/coreos/rkt/pkg/tar/chroot.go#L89

the following workaround makes the build work again:

image/test-3
acbuild dep add image/test-1
acbuild dep add image/test-2
acbuild ...

but that does not scale due to lack of cache https://github.com/appc/acbuild/issues/125

using release
https://github.com/appc/acbuild/releases/tag/v0.3.1

Sorry about the slow responses, currently in the middle of some other work.
Unless you're able to make an acbuild script that can reproduce this, that tar error is nowhere near descriptive enough for me to start hunting around as to what is causing this. I threw together a little patch to get acbuild to always print the full details for tar errors, would you be willing to run this patch on your system and share the output?

thank you for the PR

patch did not help, still same error
run: extracttar error: exit status 1, output: error extracting tar

I will try to produce build script decoupled from internal dependencies

please bake version/branch/tag into acbuild - its easy to get lost in patches

The patch didn't work? That's really interesting...
As far as baking version/branch/tag into acbuild, at the very least acbuild version should report the most recent tag + a commit hash (assuming you're building with the build tag). Would adding branch information also be useful there?

Experiencing the same issue.

@sanicheev would you be able to share more information about your setup? If I can reproduce this, I might be able to fix it.
Things that might be useful:

distribution
filesystem
are you using a release from github, or did you build it yourself?
if you built it yourself, golang version?
would you be willing to share your build script?

hello - Is there an issue with size of files that go into build "acbuild dep add filename.tar" . I have a big file filename.tar/10GB that goes as part of that. I noticed acbuild completes successfully but during the time of rkt run image I get following error:
rkt --debug --insecure-options=image run --interactive sas94m5-linux-amd64.aci
image: using image from local store for image name coreos.com/rkt/stage1-coreos:1.29.0
image: using image from file /usr/lib/rkt/stage1-images/stage1-coreos.aci
image: using image from file /opt/rkt_images/sas94m5-linux-amd64.aci
run:
└─error rendering tree store
└─cannot render aci
└─error extracting ACI
└─extracttar error: exit status 254, output: error extracting tar:
Sudhir Nallagangu


[new pattern] mvw

PR #13 was closed automatically when the dev branch was removed.
I reopened it.

rebased, but still, issues persist.
I don't like having to use the dependencies added, we should rebuild this PR and copy the needed code only.

close in favor of #26


feat: tests for create terraform

/hold
Need to know what github permissions to use

/hold cancel
@jstrachan - how is this looking for you?

/lgtm

/test this


Add command overload builders

This should make command builders cleaner for lib users and should also implement #264.

This should be ready to merge, after fixing me being a dummy.

Not anymore, it seems

Closing by Finite's request


Fix injection iso script under darwin

Signed-off-by: Itxaka<EMAIL_ADDRESS>

Also adds extra jobs on script change.


Feature: Update footer links

What type of PR is this? (check all applicable)

[x] 🍕 Feature
[] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] ⏩ Revert

Description

Updated the footer
Related Tickets & Documents

Feature: Update footer links #27
Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[ ] 🙅 no, because they aren't needed
[x] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📕 storybook
[x] 🙅 no documentation needed

📸 Credits
This pull request template was created by Open Sauced 🍕

sorry i  made a mistake in the branch name i though it was a fix

done

fixed

fixed

Ive  reverted  the changes

Awesome :tada: Thanks for your contribution :rocket:


AttributeError: 'EasyDict' object has no attribute 'TRAIN'

I'm using feature_extraction for IDN but encounters the above problem during building network in tensorflow, anyone can help me? thanks!
Traceback (most recent call last):
File "tools/extract.py", line 58, in
net.create_architecture(False)
File "/home/projects/HAKE-Action-Torch-IDN-Integrating-Decomposing-Network-/feature_extration/tools/../lib/networks/net_HO.py", line 163, in create_architecture
self.build_network(is_training)
File "/home/projects/HAKE-Action-Torch-IDN-Integrating-Decomposing-Network-/feature_extration/tools/../lib/networks/net_HO.py", line 149, in build_network
head       = self.image_to_head(is_training)
File "/home/projects/HAKE-Action-Torch-IDN-Integrating-Decomposing-Network-/feature_extration/tools/../lib/networks/net_HO.py", line 89, in image_to_head
with slim.arg_scope(resnet_arg_scope(is_training=False)):
File "/home/projects/HAKE-Action-Torch-IDN-Integrating-Decomposing-Network-/feature_extration/tools/../lib/networks/net_HO.py", line 37, in resnet_arg_scope
weights_regularizer = tf.contrib.layers.l2_regularizer(cfg.TRAIN.WEIGHT_DECAY),
AttributeError: 'EasyDict' object has no attribute 'TRAIN'

I assume that you can directly modify 'cfg.TRAIN,WEIGHT_DECAY' in line37 in net_HO.py to '1e-2', since line23 in this file has the same error but has already been fixed in the latest commit by author.
Or you can choose to add '__C.TRAIN=dict()' and '__C.TRAIN.WEIGHT_DECAY=1e-2' in feature_extraction/lib/ult/config.py.

@IreneMahhy ok, thanks, it's fixed~

Thanks, we have updated the manuscript.

Thanks, we have updated the manuscript.


Console error on load

Describe the bug

To Reproduce
Steps to reproduce the behavior:
Load https://web.loren.temporal-dev.tmprl.cloud/
Desktop (please complete the following information):

Browser latest mac chrome

It looks like this has been fixed. I can't reproduce it.


Update Ikea_E1842.md

Is flagged as working of ZHA cod master himself https://github.com/zigpy/zha-device-handlers/issues/741

Is it good adding the E1841 2 ?
Its working as one on/off plug/light in deCONZ and ZHA without quirk/whitelisting then its on good zigbee 3 device. Z2M have making one quirk for it so its working.

Is it good adding the E1841 2 ?
Its working as one on/off plug/light in deCONZ and ZHA without quirk/whitelisting then its on good zigbee 3 device. Z2M have making one quirk for it so its working.