From Developer: I'm droping support for angular 2

Hello everyone,
I'm droping support for angular v2 due to below reason.
Angular 5 version going to release within couple of days. From this version the renderer is removed Instead Renderer2 will be available which is introduced in v4. This change is for angular universal support.
I don't know how many of you using this carousel in v2 but most of the people already using v4 including me. If anyone using v2 please comment below. based on the commands i will work on v2 too
Thanks for your love and support

With this new implementation of angular universal support are we going to be able to use this package with a server side rendering configuration?
If so when would we see a release of your package to support this new version of angular?

@sheikalthaf I'm currently considering ngx-carousel for a project that uses Angular Universal. Do you already know what kind of server-side rendering limitations currently exist? How will the integration of hammerjs be handled?

I'm currently receiving an error when I want to run my universal application on firebase

Error: Error occurred while parsing your function triggers.

/tmp/fbfn_2688hWWnMRqgekX4/node_modules/ngx-carousel/src/ngx-item/ngx-item.component.js:1
(function (exports, require, module, __filename, __dirname) { import { Component } from '@angular/core';
                                                              ^^^^^^
SyntaxError: Unexpected token import
    at Object.exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:543:28)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.0tz6 (/tmp/fbfn_2688hWWnMRqgekX4/dist-server/main.bundle.js:1:20895)
    at n (/tmp/fbfn_2688hWWnMRqgekX4/dist-server/main.bundle.js:1:211)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Does this library align with the angular package format? Maybe you should use ng-packagr+angular cli to provide a simpler start for potentially contributors.

Any update on this? Does this plugin support Universal/will support Universal soon? Working on a new project and would ideally like to avoid reinventing the wheel(carousel)

I tried the carousel with this https://angular.io/guide/universal demo. carousel works fine. Didn't tried with the real-world app. soon i will share more information

@CanKattwinkel https://github.com/angular/universal-starter this link has the details about the universal support.

@dalvarezr @CanKattwinkel @Renader @G1itcher
Finally Angular Universal support
Why I created another repo because of most of the user still in angular 2. So it is difficult to add universal support in this repository.
I have cloned this carousel with universal support in another repository ngu-carousel.
In npm @ngu/carousel
With this package, I have updated to renderer2 to support Angular Universal.
In future, this package will be maintained

@sheikalthaf
Are you sure, that most of the users are still on Angular 2? In my opinion a fork and the associated segmentation at this time is not advantageous. People depending on Angular 2 should use an old version of ngx carousel. If you want you could even align with the semantic versioning of Angular in order to give better overview.
Also I couldn't integrate your @ngu/carousel into my SSR project. Since you import hammerjs - at least in the version that is published under npm (1.3.3).  NOT in the Github source.
import * as Hammer from 'hammerjs';
in<EMAIL_ADDRESS>This obviously causes my node server to fail since no hammerjs is available on server side. So I highly recommend to integrate the ngu changes into this package and to fix the hammerjs imports. The Github source looks good to me, alternatevly you can take a look at how Material 2 handles the (optional) hammerjs import.
Additional types:
https://github.com/angular/material2/blob/0834a31d03ae6707633e01d43200703840b70c5a/src/lib/core/gestures/gesture-annotations.ts
Save access to hammerjs:
https://github.com/angular/material2/blob/0834a31d03ae6707633e01d43200703840b70c5a/src/lib/core/gestures/gesture-config.ts

That is a good point.

@sheikalthaf and @iamlothian any news on this issue? I want to release a project by the end of next month and currently only the carousel is blocking my universal build since it requires hammerjs directly.
Imho you should bump this project to version 5.0.0 and do the breaking change of removing renderer. Also you should remove all direct references to hammerjs in sourcecode. At places where you might need document you can inject it like this or just wrap it into if statements.
To support legacy versions of Angular you can simply create a branch 1.3.x and do bugfix releases there. Parallel distribution of multiple versions is no problem for NPM, the angular cli team works similarly ( Master represents the recent development stand which is currently 1.6.rc, also there are  Branches for 1.3,1.4,1.5 in order to provide bugfixes for older versions).

@CanKattwinkel updated the @ngu/carousel to make hammerjs as optional dependency v.1.3.4
hope this version will fix your problem and also updated the repo


Need a fundamental overhaul of data types, columns, rows, and cells.

While reading the CSVW docs and then attempting to write my Writer classes, it became abundantly clear that I need to do a pretty major overhaul on my fundamental building block classes (data types, rows, columns, and Data (going to rename Cell)). I will add more later.

Take a look at this for data types: https://www.w3.org/TR/xmlschema-2/#NMTOKEN


ART-11024: update nightly index operator image

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

/lgtm


Warn about inheriting from Generic before BaseModel

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
Inheriting from (Generic[T], BaseModel) instead of (BaseModel, Generic[T]) results in confusing behaviour, as seen in e.g. https://github.com/pydantic/pydantic/issues/7829. I also made this mistake recently and was confused for a bit, although I don't remember the exact context.
ModelMetaclass.__new__ is still called either way, and there's already code in there that looks at whether bases contains Generic. It seems reasonable to log a warning (assuming that throwing an exception would be too disruptive) if the order looks wrong, at least sometimes. Is there any situation where putting Generic first is desirable?
Example Code
from typing import Generic, TypeVar

from pydantic import BaseModel

T = TypeVar("T")

class M1(BaseModel, Generic[T]):
    x: T

class M2(Generic[T], BaseModel):
    x: T

for M in [M1, M2]:
    print(M[int])
    print(type(M[int]))
    print(type(M[int](x=1)))
    print()

"""
<class '__main__.M1[int]'>
<class 'pydantic._internal._model_construction.ModelMetaclass'>
<class '__main__.M1[int]'>

__main__.M2[int]
<class 'typing._GenericAlias'>
<class '__main__.M2'>
"""

Python, Pydantic & OS Version
pydantic version: 2.4.2
        pydantic-core version: 2.10.1
          pydantic-core build: profile=release pgo=true
                 install path: /home/alex/work/pydantic/pydantic
               python version: 3.11.5 (main, Sep  9 2023, 21:35:25) [GCC 7.5.0]
                     platform: Linux-5.15.0-86-generic-x86_64-with-glibc2.35
             related packages: typing_extensions-4.7.1 email-validator-2.0.0.post2 mypy-1.1.1 pydantic-extra-types-2.1.0 pydantic-settings-2.0.3

Hi @alexmojaki,
Thanks for reporting this. I would agree - a warning could be helpful. I think a docs update would help many people as well.

I'll take a look.

Found some more cases where the wrong order caused bugs and this warning would have helped:

https://github.com/pydantic/pydantic/issues/7236
https://github.com/pydantic/pydantic/issues/7006

But then I found https://github.com/pydantic/pydantic/issues/6994 which suggests that it might sometimes be justified to use that order, waiting for confirmation.


How to use it with Laravel Mix

Hi,
I would like to use this plugin with laravel Mix. How i can acheive this?
Thanks
Regards

I resolved my issue, here the solution:
// webpack.mix.js
mix.webpackConfig({
    module: {
        rules: [
            {
                // Matches all PHP or JSON files in `resources/lang` directory.
                test: /resources\/lang.+\.(php|json)$/,
                loader: 'laravel-localization-loader',
            }
        ]
    }
});

Awesome @MikeElghali! You are surely fast! I will improve the docs using your own reply. Thank you!


Add missing JSON field to docs generator output for constants

Fixes #6202
The id field was missing in the JSON serialization of constants, resulting in an undefined value when using it to generate link targets for search results.
I added Constant#id and used this in the template as well, instead of reusing Constant#name to be more explicit (although both methods return the same value) and to have a consistent interface like the other classes where id and name are usually different.

@straight-shoota Could you point where the id read and missing?

https://github.com/crystal-lang/crystal/blob/ee71f884ef401fc0c745d5844779dd5eb3dd9065/src/compiler/crystal/tools/doc/html/js/_search.js#L128-L139

Great! thanks for clarifying.


OnnxRuntimeGenAIException - OrtValue shape verification failed, when running Phi-3 model with DML

CPU version works fine with the corresponding model and nuget package. DirectML version throws the exception below.
Model: https://huggingface.co/microsoft/Phi-3-mini-128k-instruct-onnx/tree/main/directml/directml-int4-awq-block-128
Using Microsoft.ML.OnnxRuntimeGenAI.DirectML 0.2.0-rc6 nuget
I have called generatorParams.TryGraphCaptureWithMaxBatchSize(1);
Max tokens is set to 4000
Exception thrown when calling generator.ComputeLogits();
Microsoft.ML.OnnxRuntimeGenAI.OnnxRuntimeGenAIException: 'Non-zero status code returned while running DmlFusedNode_0_0 node. Name:'DmlFusedNode_0_0' Status Message: D:\a_work\1\s\onnxruntime\core\framework\execution_frame.cc:173 onnxruntime::IExecutionFrame::GetOrCreateNodeOutputMLValue shape && tensor.Shape() == *shape was false. OrtValue shape verification failed. Current shape:{1,32,121,96} Requested shape:{1,32,4001,96}'
PC: Windows 11 Version	10.0.22631 Build 22631
Core i9 13th Gen, 128GB with RTX4090 with the latest Nvidia drivers.
Thanks,
Ash

Hi @AshD, is this running the HelloPhi2 sample? (To help us with the repro)

Mostly the same code.
The exact code is here https://github.com/feiyun0112/SemanticKernel.Connectors.OnnxRuntimeGenAI
With the addition of generatorParams.TryGraphCaptureWithMaxBatchSize(1);

Hi @AshD,
The problem is on this line: generatorParams.SetSearchOption("past_present_share_buffer", onnxRuntimeGenAIPromptExecutionSettings.PastPresentShareBuffer);
When using graph capture (cuda_graph/dml_graph), PastPresentShareBuffer should always be set to true. This is something we'll make clearer or maybe even force for DML in future versions, but for now you should set it to true when using DML.

Thanks @PatriceVignola  That fixes the issue :-)
Would appreciate some guidance on the discussion I opened
https://github.com/microsoft/onnxruntime-genai/discussions/425


how to serve images, fonts, other static files

What convention should be followed for including static assets, such as images & fonts? I poked around in the webpack config builder & saw the loader in common that seems set up for images, but I can't figure it out. None of my static assets besides the files in index-icons/are being compiled into my app.
Where should I store image files used in my app, and how should I reference them in my app? For instance, how do I access app_logo.svg from a react app component src/components/LogoAppBar.js that I'm importing in my main App.js:
//...
  render() {
    return (
      <Toolbar style={styles.ToolBar}>
        <ToolbarGroup firstChild={false}>

        </ToolbarGroup>
//...

You want to import the image like this:
import MySrc from './folder/file.svg';
The compiler will copy the file to the appropriate place in the output directory.
At runtime, MySrc will be a string URL. So you pass that to your img like this:

And that should work!

I need to add a lot to the docs at some point, including this :)

Just a note, you can put img tags with a src in your HTML file and it will copy those files to the output for you as well. This is for when you need some default layout in your "page" that's always there.

@resistdesign Thanks for the explanation! Got it.
I don't understand webpack very well. In a different project, I was using the file loader to copy images I kept in /public/images/ over to /dist/images/, and referencing them with relative urls in the src attribute in my .jsx files. I wasn't assigning hashes to the file names, so I didn't need to import the image files in js to get their full path - I already knew what it was.
I guess I was trying to figure out how to do something similar w/ rdx. But importing them and getting the cacheble file name will be better.
Anway here's the relevant section of my webpack config from the other project if you are curious.
/*
public/
├── actions/
├── api/
├── components/
├── constants/
├── fonts/
├── helpers/
├── images/
├── routes/
├── stores/
├── index.html
├── index.jsx
└── index.styl
*/

const PATHS = {
  PUBLIC: path.join(__dirname, 'public'),
  LIB: path.join(__dirname, 'lib'),
  DIST: path.join(__dirname, 'dist')
};

module.exports = {
  entry: {
    app: PATHS.PUBLIC,
  },
  output: {
    path: PATHS.DIST,
    filename: '[name]-[hash].min.js',
  },
  module: {
    loaders: [
      {
        test: /\.css$/,
        loader: extractCss.extract('style', ['css', 'postcss']),
      },
      {
        test: /\.(js|jsx)$/,
        loader: 'babel',
        include: [PATHS.PUBLIC, PATHS.LIB],
        query: {
          presets: ['react', 'es2015', 'stage-1'],
          plugins: ['transform-decorators-legacy'],
        },
      },
      {
        test: /\.(jpe?g|png|gif|ico)$/i,
        loader: "file?name=images/[name].[ext]",
      },
    ],
  },
  plugins: [
    new HtmlWebpackPlugin({
      template: 'public/index.html',
      inject: 'body',
      filename: 'index.html',
    }),
    new webpack.optimize.OccurenceOrderPlugin(),
    new webpack.optimize.UglifyJsPlugin({
      compressor: {
        warnings: false,
        screw_ie8: true,
      },
    }),
    new StatsPlugin('webpack.stats.json', {
      source: false,
      modules: false,
    }),
    new webpack.DefinePlugin({
      'process.env': {
        NODE_ENV: JSON.stringify('production'),
      },
    }),
    extractCss,
    extractStyl,
  ],
  postcss: () => [autoprefixer],
  resolve: {
    extensions: ['', '.js', '.jsx'],
  },
};

Just fyi, you don't need the hash, but it's for cache busting :)


in customise

in customize section we can add features to draw, text in various colors, a color panel for selection of colors, to overlay another image and also to crop them.

we are utilising features of imagekit.io in the backend which allow us to do the text transformations and provide text overlays .
And i doubt whether imagekit has features to overlay one image over another and the other requested stuff


refreshAccessToken gets new refreshToken

In src/client/resources/tokens.js there is a refreshAccessToken function. The function is intended to use an unexpired refreshToken to refresh an expired accessToken. In the function the parameter 'access_type' is being set to 'offline'. Per the documentation, "Set to offline to receive a refresh token on an authorization_code grant type request. Do not set to offline on a refresh_token grant type request."
My understanding is that this should only be set to offline when requesting the initial tokens (with the 'code' from the redirectURI).
When tested with 'offline' - this it returns both a refresh and access token.
When tested without 'offline' - this ONLY returns an access token (leaving the unexpired refreshToken still valid).
I will put together a PR for this change.

I've thought about this behavior a little too, but what's really been on my mind lately is this; I've been logging a message inside the "on token" event td.on('token', async token => {} and notice that it can fire many times in a row. Is there some way to refresh the token and wait until it's finished before exiting? If so, subsequent calls to the "is expired" methods would return false, preventing additional calls to refresh.

@marknokes that sounds like a race condition in which case a lock would be a nice thing to have. we'll first need a test to recreate the issue. would you like to give it a go?

I'm not sure I would know where to start, tbh. I found the refreshAndRetry method, and thought it could perhaps be the culprit. I don't really know how to test it though.


Adds timeout option to dendrite

If a response takes too long the dendrite will fail to parse. The default setting for the AsyncClient timeout is 5s and this change updates the default to 12s

Change should be made on per POST / request level, not global
closing


To include process arguments in user section event

Desc:
This PR is to include process arguments in user section event

UserAction event occurs when a user executes a program

SCT-305

Codecov Report

Merging #38 (f69e999) into main (0578f23) will increase coverage by 0.78%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   51.89%   52.67%   +0.78%
==========================================
  Files          26       26
  Lines        1771     1792      +21
==========================================
+ Hits          919      944      +25
+ Misses        810      808       -2
+ Partials       42       40       -2

Flag
Coverage Δ

unittests
52.67% <100.00%> (+0.78%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/auditd/sessiontracker/sessiontracker.go
84.52% <100.00%> (+0.54%)
:arrow_up:

... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Let's get some testing for this.

Let's get some testing for this.

Added the test cases , Please have a look and let me know the feedback.


Add Telink 825x platform codes.

Add code for telink 825x platform.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

abandon


Add support for FilterExpr in find_many and find_one.

As requested by @CodingDoug , this PR brings support for FilterExpr to both findMany and findOne functions in the TS API. I've also made the filterExpr a little bit stricter so that it doesn't accept filters for keys which are not part of the entity.

ChiselEntity.delete() and ChiselEntity.upsert() also do filtering with restrictions (but not predicate). How about adding FilterExpr to those?


New Feature: Highlighting how results matched

Long-time ago,  @JohnTheGr8 created a pull request to add this feature to WOX.
Unfortunately, the pull request was never merged and there have been so many changes that a new pull request would be needed.
Original pull request: https://github.com/Wox-launcher/Wox/pull/977
In my opinion, this is a great feature and should be added.
I will try to pick out his changes and add them to this repository.
Let me know what you think about it. :)

I think this will be a great add, will help further how users search. :+1:

This feature is now added thank you @SysC0mp @JohnTheGr8


support loading checkpoint from GCS

This isn't read to push: the first model trained from the checkpoint performs badly in eval, which indicates that training isn't being resumed correctly.
Since the checkpoint files are large, we're going to store them on GCS instead of github. I've added a ml_perf/get_data.py script that grabs the checkpoint & training target from GCS and freezes the model protos.

Does this PR require python2? I used python3 and got the following error message. This is on GCP.
-------------:~/minigo$     BOARD_SIZE=9 python ml_perf/get_data.py
Making dir ml_perf/checkpoint
I0329 22:25:29.311440<PHONE_NUMBER>38528 utils.py:54] Running: gsutil  -m  cp  -r  gs://minigo-pub/ml_perf/checkpoint/
9  ml_perf/checkpoint
I0329 22:25:35.458297<PHONE_NUMBER>38528 utils.py:86] gsutil finished: 6.146 seconds
Making dir ml_perf/target
I0329 22:25:35.459384<PHONE_NUMBER>38528 utils.py:54] Running: gsutil  -m  cp  -r  gs://minigo-pub/ml_perf/target/9  m
l_perf/target
I0329 22:25:36.840321<PHONE_NUMBER>38528 utils.py:86] gsutil finished: 1.381 seconds
I0329 22:25:36.840956<PHONE_NUMBER>38528 utils.py:54] Running: python  freeze_graph.py  --model_path=ml_perf/target/9/
target  --use_tpu=False
Traceback (most recent call last):
File "ml_perf/get_data.py", line 63, in
app.run(main)
File "/usr/local/lib/python3.5/dist-packages/absl/app.py", line 300, in run
_run_main(main, args)
File "/usr/local/lib/python3.5/dist-packages/absl/app.py", line 251, in _run_main
sys.exit(main(argv))
File "ml_perf/get_data.py", line 56, in main
freeze_graph('ml_perf/target/{}/target'.format(N))
File "ml_perf/get_data.py", line 42, in freeze_graph
'--model_path={}'.format(path), '--use_tpu={}'.format(FLAGS.use_tpu)))
File "./ml_perf/utils.py", line 102, in wait
raise result
File "/usr/lib/python3.5/asyncio/tasks.py", line 239, in _step
result = coro.send(None)
File "./ml_perf/utils.py", line 72, in checked_run
p.returncode, expand_cmd_str(cmd), stdout))
RuntimeError: Return code 1 from process: python  freeze_graph.py  --model_path=ml_perf/target/9/target  --use_tpu=
False
Traceback (most recent call last):
File "freeze_graph.py", line 18, in
import dual_net
File "/home/christine_cheng/minigo/dual_net.py", line 35, in
import features as features_lib
File "/home/christine_cheng/minigo/features.py", line 29, in
import utils
File "/home/christine_cheng/minigo/utils.py", line 27
def dbg(*objects, file=sys.stderr, flush=True, **kwargs):
^
SyntaxError: invalid syntax
christine_cheng@instance-1:~/minigo$  which gdb | xargs grep -a python
christine_cheng@instance-1:~/minigo$ python3
Python 3.5.3 (default, Sep 27 2018, 17:25:39)
[GCC 6.3.0 20170516] on linux
Type "help", "copyright", "credits" or "license" for more information.

I never saw anything like that on my end. I'm using the exact same version of Python too.
I've just push another commit, can you re-pull and run BOARD_SIZE=9 python ml_perf/get_data.py again please?

It's possible that the version of python being launched by as a subprocess is different for some reason. Are you using a virtual env?
Can you add the following to the top of main in ml_perf/get_data.py and compare against which python binary & version you expect to be running?
print(utils.wait(utils.checked_run('which', 'python')))
print(utils.wait(utils.checked_run('python', '--version')))

Also, what happens if you run python freeze_graph.py --model_path=ml_perf/target/9/target --use_tpu=false directly?


Change 'bool supports(const std::string&)' to 'int supports(string_view)'

By changing to int, we allow future queries to return more information than just a bool (for example, perhaps a supports("maxchannels") would return the maximum number of channels allowed by the format). By changing the argument to a string_view, we make the call less expensive by no longer requiring a temporary string be constructed in many cases.
This should not require any changes to client-side source code, since all existing queries just return true or false (1 or 0), and the string_view can accept either a char* or a std::string (or for that matter, a ustring).
However, if you have written any custom ImageInput or ImageOutput plugins, you will need to change the signature of any supports() methods in your
subclasses.
I have bumped the OIIO_PLUGIN_VERSION, and after merging will also bump the OIIO release version.

Any comments or objections?

I will merge this tomorrow unless there are objections voiced.


API endpoints are no longer working

Is this an issue with the Heroku app? None of the endpoints (search, recent, top) seem to be responding.

Working for me. Sometimes TPB website is down

Yes, seems to be working now. Does it always query thepiratebay.org or are there mirrors that it falls back to in case the original isn't available?

Only original


Add Tizen 5.0 bindings

#5
Change the reference profile to Iot headed from wearable because the Iot headed profile has more common API set.
Add Tizen 5.0 bindings

import 'package:tizen_interop/5.0/tizen.dart';

Update README.md to provide the supported APIs table.
Cleanup scripts

@WonyoungChoi Yeah, creating a branch in the public repo is usually intended for collaboration, but I thought nobody would like to do so for this work.

@WonyoungChoi Yeah, creating a branch in the public repo is usually intended for collaboration, but I thought nobody would like to do so for this work.

:sob:


[Feature Request] AABB, tile based collisions support to SypherEngine

As of right now SypherEngine doesn't have anyway to add proper collision to a game object... physics must be hardcoded into the game... The basics of physics support in a game engine start with collisions, and since SypherEngine is a pixel based rendering engine... AABB, tile based collisions should be added to SypherEngine

[ ] AABB
[ ] Circle collisions
[ ] Polygon collisions

This will be thought of at a later date, as of now, collisions in SypherEngine has been made easy with the collidesWith() method


feat: add new authorizer cmds

Renamed the extender command to trusted-clients, as clients was already in use.
Renamed also the file, functions, variables etc. according to the command name change.


Roll Flutter Engine from ccccee513fb2 to dbd1cfa22a0a (1 revision)

https://github.com/flutter/engine/compare/ccccee513fb2...dbd1cfa22a0a
2023-01-20<EMAIL_ADDRESS>Roll Dart SDK from fbbfc122dba6 to ac4c63168ff2 (1 revision) (flutter/engine#39030)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Ensure to reload alerting_rules file when changed

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes https://github.com/pipe-cd/pipe/issues/2013
Does this PR introduce a user-facing change?:

NONE

/lgtm

Way to go 🚀
/approve


Add values to VariantParams

Sorry, I am a Golang newbie and my use case is to introduce a new key into the variant called 'rendition-id' to help clients create a rendition switcher.
package main

import (
	"fmt"

	"github.com/grafov/m3u8"
)

// https://godoc.org/github.com/grafov/m3u8#VariantParams

type myVariantParams struct {
	*m3u8.VariantParams
	RenditionId string
}

func main() {

	masterPlaylist := m3u8.NewMasterPlaylist()

	pp, _ := m3u8.NewMediaPlaylist(3, 5)
	for i := 0; i < 5; i++ {
		pp.Append(fmt.Sprintf("test%d.ts", i), 5.0, "")
	}

	// WORKS
	masterPlaylist.Append("chunklist2.m3u8", pp, m3u8.VariantParams{ProgramId: 123, Bandwidth: 1500000, Resolution: "576x480"})

	// Trying to extend VariantParams doesn't !
	// masterPlaylist.Append("chunklist2.m3u8", pp, myVariantParams{VariantParams: &m3u8.VariantParams{ProgramId: 123, Bandwidth: 1500000, Resolution: "576x480"}, RenditionId: "foo"})

	fmt.Println(len(masterPlaylist.Variants))
	masterPlaylist.ResetCache()

	fmt.Println(masterPlaylist.Encode().String())

}

Perhaps this is the same as #82. Anyway, just thought I'd convey my use case. My tact now is to fork and add the missing values.

The error you should be getting is:
./main.go:29: cannot use myVariantParams literal (type myVariantParams) as type m3u8.VariantParams in argument to masterPlaylist.Append

This is because the append method on MasterPlaylist is
func (p *MasterPlaylist) Append(uri string, chunklist *MediaPlaylist, params VariantParams)

As Go is a strongly typed language, the only type that can be used for the 3rd argument is a type github.com/grafov/m3u8.VariantParams.
So you won't be able to do exactly what you want this way.
If the HLS RFC does have this as a field, we can add it to the VariantParams type, but if you're trying to add a custom field to be added when calling the String() method, then you'll need to do a lot more work with how the API is right now (we don't support custom fields).

I ended up adding what I needed by forking the repo here: https://github.com/Spuul/go-m3u8/commit/a418099cf75c3a917a309d5cd1d3641c6fdeee84

Yeah that would be the change that's required to add support for that field (to write that field, but you'll need to do more to read the field), I take it this isn't a field in the HLS RFC? If it is, we'll be happy to add that field ourselves.

It's a custom field. We're also using a Javascript library https://github.com/tedconf/node-m3u8 which has a non-annoying item.set API. I am not sure how that works in a strongly typed sense..

If it's a custom field and you're OK with running a fork, then that'll be the best option until we support some kind of custom fields, such as VariantParams taking on a X map[string]string type.

There was another request for custom fields: #82. I think we need some time for clarifying needs for this and implementing it without breaking existent API. So thank for a question!

Another field I need is AVERAGE-BANDWIDTH.. guess I will be adding it to my fork. https://github.com/Spuul/go-m3u8

Any field in the the HLS draft RFC can be added to this library by either asking if we can implement or sending a pull request. It's only custom fields that there's a limitation and a fork may be your best option.

Ok, I'll try implement it and do a pull request specially only upon AVERAGE-BANDWIDTH


[PkgConfig] Print warning message when pkg-config not found

When users require system packages, they will typically want to use pkg-config
to help identify the location of libraries on the system to link to. We will
now print a warning to let users know they should install this tool if they
are running into link errors.

@aciidb0mb3r I pulled the "emission" logic out to the static method since I couldn't think of a good way to get the DiagnosticsEngine passed into that lazily computed variable. I plumbed DiagnosticsEngine through the callers, and hopefully, this was the approach you were thinking about too. Let me know if not!

@swift-ci please smoke test


Consider having conversions from AbstractArray infer size

A little bit of convenience I initially expected from my use of FixedSizeArrays:
mat = [1 2; 3 4]
SMatrix(mat)

currently results in
ERROR: MethodError: no method matching size(::Type{StaticArrays.SMatrix})
Closest candidates are:
  size{T<:StaticArrays.StaticArray{T,N}}(::Union{T<:StaticArrays.StaticArray{T,N},Type{T<:StaticArrays.StaticArray}}, ::Integer) at <dir>/packages/v0.5/StaticArrays/src/abstractarray.jl:4
  size{N}(::Any, ::Integer, ::Integer, ::Integer...) at abstractarray.jl:30
  size(::BitArray{1}) at bitarray.jl:39
  ...
 in convert at <dir>/packages/v0.5/StaticArrays/src/core.jl:61 [inlined]
 in StaticArrays.SMatrix{S1,S2,T,L}(::Array{Int64,2}) at ./sysimg.jl:53

This works:
mat = [1 2; 3 4]
SMatrix{2, 2}(mat)

but it's a little annoying to have to specify the size parameters manually.

That's the last one for now. Thanks for your work! I think this will end up being quite an improvement over FixedSizeArrays.

Thanks for all your bug-chasing and corner-case-catching, @tkoolen! :)
That one is a little tricky... currently it will steal the size parameters from another StaticArray but it assumes nothing else has a size defined on the type. So in some sense it is not trained to play nicely with other static array packages, and its hard to get good compatibility with FixedSizeArrays without explicitly importing it... I've tried to write it so that the functions are type stable - they simply won't work if they can't figure out the size properly. I'll look into this anyway - a better error message might be a good short-term solution/
At least there is a workaround in this case.  You can also try using StaticArrays.FixedSizeArrays for some compatibility-layer, but it's not designed for using both packages (FixedSizeArrays and StaticArrays) at once (and it is not tested).

Oh, sorry I misinterpreted this one slightly (I thought of Mat from FixedSizeArrays).
Anyway, the plan is that no, you will not be allowed to do anything type-unstable, unless you try hard (e.g. SMatrix{size(mat,1), size(mat,2)}(mat). If you are using this package, then you probably want/need your arrays to be faster than Base.Array. Doing what you suggest in the middle of a function would make it 10x slower than just using Array.
I'm deciding to close this issue for now - but thank you again (very much!) for your feedback, and let me know if you have any other issues.

Alright, that makes a lot of sense. I wasn't relying on this kind of conversion in anything performance critical, just as a convenience thing. Probably still best to not allow it in your code. It's easy enough to write a helper function yourself if need be.
And wow, you're quick. Thanks for taking care of all of these!


Add Pashmak Programming Language Request

New Programming Language
Pashmak Programming language
the .pashm files is pashmak programming languge
please add it
The Pashmak Github Ripository
Pashmak
Thanks

If the language meets the popularity requirement detailed in the CONTRIBUTING.md file, feel free to submit a PR adding support for this language. The requirement is vague at the moment, but we take 200 unique user/repos as a minimum.

Used in only a handful of repos (to be exact, 4), nowhere near meeting the requirements.

Hello.
I'm creator of the @pashmaklang
I know count of repositories related to this language should be more than 200.
But about syntax highlighting, we should use which standard?
Currently we have a syntax highlighter for vscode (https://github.com/sami2020pro/vscode-pashmak) and also nano editor(i'm fan of vim ((: ).
What should we do for syntax highlighting? is vscode extension enough?

Yes, any TextMate-compatible grammar is fine, so you can use a grammar for TextMate, Atom or VSCode.

Yes, any TextMate-compatible grammar is fine, so you can use a grammar for TextMate, Atom or VSCode.

Thanks!

I sent pull request #5218 for adding Pashmak.
Please close this issue.

I know count of repositories related to this language should be more than 200.

Where? Github lists only 77 pashm files. https://github.com/github/linguist/issues/5107#issuecomment-774781832

I know count of repositories related to this language should be more than 200.

Where? Github lists only 77 pashm files. #5107 (comment)

Yes. not now, new repos will be created soon. I'll re-open the #5218 soon.

Yes. not now, new repos will be created soon.

It needs 200 unique repositories to be added, I don't think that would happen 'soon'. I think this issue as well should be closed in the meantime.

Yes. not now, new repos will be created soon.

It needs 200 unique repositories to be added, I don't think that would happen 'soon'. I think this issue as well should be closed in the meantime.

ok.


ERROR [ExceptionsHandler] Duplicate column name

PropertyEntity:
@PrimaryGeneratedColumn({ type: 'int', unsigned: true })
id: number;
@Column({ name: 'district_id', type: 'int' })
districtId: number;
@ManyToOne(() => DistrictEntity, (district) => district.properties, {
eager: true,
})
@JoinColumn({ name: 'district_id' })
district: DistrictEntity;
DistrictEntity:
@PrimaryGeneratedColumn()
id: number;
@Column({ nullable: true })
district_name: string;
Paginate with eager load:
const config: PaginateConfig<PropertyEntity> = {
  loadEagerRelations: true,
  relations: ['district'],
  sortableColumns: ['id'],
};

return paginate<PropertyEntity>(query, this.propertyRepository, config);

This throw exception:  QueryFailedError: Duplicate column name '__root_district_id'

Which version are you using?

The current major version of nestjs-paginate is 8.3.0, somewhere around 6/7 duplicate columns where fixed. Could you try upgrading to preferably version 8, and see if this resolves it?


Docs: Remove usage of non-scoped deck.gl module

Background
In the docs and examples, avoid showing/using the legacy deck.gl module. Instead used scoped modules (@deck.gl/react, @deck.gl/core, etc).
To Do List

[x] Add label and assign to milestone
[x] Doc update

Closing in favor of the more gradual plan agreed in team meetings.


Add: Github Copilot prompt

Hi @yakGPT
I have been playing since yesterday using the Github copilot prompt using your amazing repo
I added like this let me know if you want to incorporate at your work 🙂
Also I put your robot image 🤖
You can tested with questions like Using Python, please write a simple turn based fantasy fighting game that implements the rules of "rock, scissors, paper".

Love this, thx @pabl-o-ce !

@yakGPT thanks your awesome work you inspire!


Handshake time out error windows client

We are getting handshake timeout error when connecting nebula light house node from windows, we could not ping the light house ip

Perhaps you should discuss this on reddit (e.g.: https://www.reddit.com/r/NebulaVPN/)

Hi @velguru1988 - I'm closing this issue out as it's lacking necessary info to debug the problem. If you'd like it reopened please provide full Nebula logs and config files from both sides and tag me directly. Thanks!


Grant @dexx7 alert rights

This should be a no-brainer really.  @dexX7 is doing great work for us and in my opinion should be given alert broadcast rights.
Opinions aside though, he has merge access so in theory could simply add his own alert address if he wanted to anyway.  Thus I propose we request @dexX7 supply us with a mainnet address that can be added to CMPTransaction::step2_Alert along with existing approved senders.
@dexX7 - this is not mandatory mate - if you don't want to that's fine - but I thought given how much you have contributed for us and how involved you are in the project it was only right to at least extend the option.

Thanks @zathras-crypto.
I tagged it as release, as task to do until the release. :)

Speaking of, I was always wondering how we could properly test the alert system via automated tests, without hardcoding keys, which are used in the tests.
The answer is actually simple: (note to self) make it configurable.
There could be a startup option --alertsender=address, and while doing so, it would probably also make sense to have --ignorealert=address, just to be on the safe side.

I can see the value in something like --alertallowsender=address for testing but can you fill me in on what purpose you see for --alertignoresender=address? (in the context that --overrideforcedshutdown is already available?

Shutdown, and likewise overwriting the shutdown are nuclear options, but there are more aspects.
In the best case a compromised alert key might be used to broadcast messages, which are then shown in Omni Core. Pushing a new version without that key is certainly the way to go, but as temporary solution the key could be ignored.
I'm playing devil's advocat here though. :)


No Reverse for 'tinymce-js'

As reported by @dilatgh
zinnia-wysiwig-tinymce doesn't work. "tinymce-js" URL name and its view textareas_js  don't exist in django-tinymce anymore: https://github.com/aljosa/django-tinymce/commit/1535f5c33544c4ac49d397ec14e2ec88e177587d#diff-99f82678a1ffa0a31e0576ec938419c9

I see this is closed. Is it fixed in 'develop'? I get the error when installing latest from pip.


Doc typo?

const state = create({ post: fetch(url).then((res) => res.json()) })
Should the state object be wrapped in proxy instead of create?

Yes, You're right.

Here is  a direct link:
https://github.com/pmndrs/valtio#suspense-out-of-the-box

Nice catch! It's fixed.


Detect virtualenv and refuse to do anything.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.
[x] Have you successfully run brew tests with your changes locally?

This change detects whether brew is running inside a python virtualenv and exits immediately if it is.
I have an alias brewup that runs brew doctor before and after every upgrade. "brew doctor | awk '!/ready to brew/' ; brew update; brew upgrade; brew doctor"
I was inside a virtualenv and ran brewup and I noticed a warning message that caught my attention.
Warning: "config" scripts exist outside your system or Homebrew directories.
`./configure` scripts often look for *-config scripts to determine if
software packages are installed, and what additional flags to use when
compiling and linking.

Having additional scripts in your path can confuse software installed via
Homebrew if the config script overrides a system or Homebrew provided
script of the same name. We found the following "config" scripts:
  /Users/<me>/projects/<some project>/venv/bin/python-config

The warning itself is totally benign, but it made me wonder whether homebrew use a fixed value for PATH or whether it intentionally uses the PATH (and other environment variables) that the user has set.  I figured it's probably the latter, so I added a check for virtualenv-ness.
The /bin/brew script is probably not the right place for a check like this and there should be a way to force brew to run even if it is inside a virtualenv, but adding it where I did was easy and it gives people something concrete to consider, so there's that.

Do you have any formulae etc. that fail under this configuration?

@MikeMcQuaid I haven't tried looking for formulae that fail when running inside a virtualenv, I was just surprised that homebrew was using my PATH at all.

May reopen this in future but passing on it for now if there's no specific formula issues here. We have a longer-term goal that would handle PATH filtering (https://github.com/Homebrew/brew/issues/932) and want to hold off on checking more specific cases before that. Thanks!


Code review fixes

This change is

@mvd-ows here is the PR related to the discussion we had on the initial commit.

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Create an is_icon_font condition based on Panose values

@tphinney suggested: "check if the Panose declares the font to be an icon font, and default to treating it appropriately"
Some checks do not apply to icon fonts while others need to be tweaked to have slightly different checking criteria.
This Panose-based icon font detection should be placed in a condition that would be used to skip (or customize) checks so that icon fonts are inspected correctly.

I believe that such condition would default to False (not an icon font). And it could potentially be extended later with additional heuristics to detect icon fonts. I accept suggestions of other possible detection mechanisms, but we'll start with just Panose for now.

I'm working on this but I do warn you that Panose is useless. Noto Emoji has a Family Kind==5, but Noto Symbols, Noto Color Emoji and Material Symbols do not.

I am sorry to hear that these Google fonts are defective!  :P


fix: bar chart selection

Closes https://github.com/datavisyn/visyn_core/issues/89
Follow up of #438
Developer Checklist (Definition of Done)
Issue

[ ] All acceptance criteria from the issue are met
[x] Tested in latest Chrome/Firefox

UI/UX/Vis

[x] Requires UI/UX/Vis review

[x] Reviewer(s) are notified @thinkh @dvmoritzschoefl
[ ] Review has occurred (link to notes)
[ ] Feedback is included in this PR
[ ] Reviewer(s) approve of concept and design

Code

[x] Branch is up-to-date with the branch to be merged with, i.e., develop
[x] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[x] Descriptive title for this pull request is provided (will be used for release notes later)
[x] Reviewer and assignees are defined
[x] Add type label (e.g., bug, feature) to this pull request
[x] Add release label (e.g., release: minor) to this PR following semver
[x] The PR is connected to the corresponding issue (via Closes #...)
[x] Summary of changes is written

Summary of changes

Fix bar plot selection

Screenshots

TBD

Additional notes for the reviewer(s)

N/A

Here's some feedback from my testing in visyn_core directly:

[ ] Unknown category should always be the last one

[ ] we should hide the labels when the bar is too small in a grouped / stacked bar, as the labels overflow anyways:
![image](https://github.com/user-attachments/assets/6e00

2b51-3227-4bde-a88f-2ec998a4dab3)

[ ] when removing facets the remaining chart should use 100% of the height again. Currently, there's a lot of whitespace:

[ ] Bars are overflowing in stacked mode:

[ ] I'd reduce the max length of the tick label by half, as it is very long currently and takes up a lot of space:

[ ] half of the axis labels is missing (I have the same config as in the above screenshot, except for the bar direction):

[ ] Axis labels are missing

[ ] In the old barchart we could sort the individual axis either by category, or by the count which is not possible currently, but needed from our side:

[ ] Aggregate type minimum seems to be wrong imo

In my testing ECharts had pretty good animations. When switching from count to minimal for instance it seemed to remount the chart instead. Is this intentional?

I disabled the animations because they were disturbing and sometimes misleading when enabled. Please take a look by enabling this flag:
https://github.com/datavisyn/visyn_core/blob/f6194c7d0243d54b56302df4c8974e33f707ccb3/src/vis/bar/SingleEChartsBarChart.tsx#L362
I also disabled the merging of series because it led to wrong results when switching the grouping and/or category column.
https://github.com/datavisyn/visyn_core/blob/f6194c7d0243d54b56302df4c8974e33f707ccb3/src/vis/bar/SingleEChartsBarChart.tsx#L571-L573
I'd be happy to use it if it works correctly and improves the user experience.

All the comments except those marked unchecked are addressed. This PR is the most up to date version as of https://github.com/datavisyn/visyn_core/pull/497/commits/10a45315dabc89012fe04c0ec62f775aa0a67551 and would close the following unmerged PRs:

#519
#438
#330
#272

This would also make these refs redundant:

https://github.com/datavisyn/visyn_core/tree/mh/echarts_hook
https://github.com/datavisyn/visyn_core/tree/thinkh/refactor-bar-chart-using-echarts
https://github.com/datavisyn/visyn_core/tree/och/bar-chart-react-window
https://github.com/datavisyn/visyn_core/tree/ua/89-remove-arquero-from-bar-plot
https://github.com/datavisyn/visyn_core/tree/ua/89-bar-plot

@dv-usama-ansari Currently open tasks:

[ ] Global min/max for all facets to calculate the scale for all the echart bar charts
[ ] Check if there is a flag margin/padding of the domain -> echarts should do this automatically according to these demos
[ ] Clipped tooltip in view -> set higher z-index for tooltip
[ ] Bar background color for grouped bars, add the alpha to the hex value #RRGGBBAA instead of #RRGGBB + opacity (see example) -> the numbers on top of the bar should not be transparent because the opacity is not set
[ ] Sorting of the categorical axis (Daniela's feedback)
[ ] A single bar chart should use the full height of the container -> add a config flag use full height with default value false (Daniela's feedback)

@thinkh
I have addressed all the points mentioned by you in the comment

Make category labels on the y-axis wider (e.g., more than just REACTOME_...)

I made this work how we would expect to see the truncation in DOM elements. We now have a constant to define the maximum label width in pixels and the component would handle truncated text automatically:
https://github.com/datavisyn/visyn_core/blob/3f2337e3122afcecf08ba0a5c6d4b5795d729c66/src/vis/bar/constants.ts#L24
As of https://github.com/datavisyn/visyn_core/pull/497/commits/3f2337e3122afcecf08ba0a5c6d4b5795d729c66, I still have to fix the heights of individual charts when the group type is Grouped in Horizontal direction with facets enabled.
I would document this in detail in this PR very soon.

It was a tricky implementation but according to https://github.com/datavisyn/visyn_core/pull/497/commits/13b22fc19387103e0069dec8af0ee9e4ec37a7e9, the bar plot labels are now responsive like we saw in the PowerBI dashboard
responsive-labels-bar-plot.webm

[ ] setting the group to a gene expression (log TPM+1) in bioinsight makes the application crash

[ ] In our old bar chart we had the possibility to sort the bars having sort icons besides the axis labels.

[ ] in the bioinsight use case it would be useful if the plot would also scale vertically. Having facets we will need the scroll area anyways I guess

[ ] if I reduce the horizontal space to much a lot of labels on the x-axis are missing and everything seems off

[ ] please use the same title font as used in other vis types and center it

[ ] having facets we should maybe have a combined title of categorical column and facet

[ ] I think we should use a dedicated color for Unknown in all vis types (maybe gray). We should define one in colors.ts @dvdanielamoitzi

[ ] when setting to normalized show count % instead of count

[ ] I have a pointer for title and axis labels even though there is no action connected. Better switch to cursor

[ ] truncate the labels for numerical groups

Thanks for your feedback @dvmartinweigl! I have some comments for you regarding the feedback as below:

setting the group to a gene expression (log TPM+1) in bioinsight makes the application crash

I would need to check this with you since it does not happen in Ordino as well as visyn_core. I am suspecting that it may be an issue with setting ranges for color scale exactly at this location, but we still need to check:
https://github.com/datavisyn/visyn_core/blob/9f0edaa4486e090bb8727cf58a3f7298be844ba4/src/vis/bar/BarChart.tsx#L376

In our old bar chart we had the possibility to sort the bars having sort icons besides the axis labels.

Unfortunately, the axis titles in eCharts does not support adding icons, we could only add rich text at the best. We should discuss this with @dvdanielamoitzi if we have a better solution.

in the bioinsight use case it would be useful if the plot would also scale vertically. Having facets we will need the scroll area anyways I guess

The IBarConfig has a property useFullHeight which you could use in case you require vertical responsiveness. useFullHeight uses container's height instead of a static value when there are no facets:
https://github.com/datavisyn/visyn_core/blob/9f0edaa4486e090bb8727cf58a3f7298be844ba4/src/vis/bar/interfaces.ts#L45
https://github.com/datavisyn/visyn_core/blob/9f0edaa4486e090bb8727cf58a3f7298be844ba4/src/vis/bar/BarChart.tsx#L43

if I reduce the horizontal space to much a lot of labels on the x-axis are missing and everything seems off

I would make it configurable if the bar chart should hide the labels in the axis if they overlap.
I would address all the other points in follow up commits :+1:

[ ] always show tooltips for rotated labels, for normal ones only show it when truncated
[ ] add back sorting with text instead of the sorting icons. Extend the label text with the three states (Unsorted) --> (Ascending) --> (Descending). If possible make the ascending/descending state orange colored
[ ] remove pointer from title if there are no facets
[ ] check the case of counts with many digits (rotate labels in bars?)
[ ] increase the spacing between y-label and plot

Found a bug in reprovisyn with these settings:

Found a bug in reprovisyn (test_db) with these settings

Fixed in https://github.com/datavisyn/visyn_core/pull/497/commits/d463e0ce6e068c64670ddb94627d02b869f5127e

Found a bug in reprovisyn (test_db) with these settings

Fixed in d463e0c

@dv-usama-ansari is it also fixed in the vertical direction? because your first screenshot shows vertical and not horizontal.

Potential usability issue:

[ ] Lazy loading echarts in hook

@dv-usama-ansari is it also fixed in the vertical direction? because your first screenshot shows vertical and not horizontal.

Yes, this was a miscalculation which exploded the scales. Since the underlying aggregation is fixed, the bar chart displays normally irrespective of the orientation.

@thinkh When you are reviewing this, please make sure to check these commits:

https://github.com/datavisyn/visyn_core/pull/497/commits/b04a18a5a737bb6af8c4ae1976d73c9016533bc8
https://github.com/datavisyn/visyn_core/pull/497/commits/99de3a612c529d097c0ed7bb8d89cfbfbfdab648
https://github.com/datavisyn/visyn_core/pull/497/commits/94752fd9973fe2a57035548eb9bec621e3b5d6cd
https://github.com/datavisyn/visyn_core/pull/497/commits/1090cdb357f5721c1dc461b8ff9420add20175e1: Please also check the Intl.NumberFormat here

Thanks for your changes. Both the horizontal and vertical bar plots now work much better. I have a few comments that I will put here to be addressed:

Please add the selected column to the value-axis, otherwise, users won't know what average is used.

When the bar plot is scrollable, and neither the title, nor the axis are visible, the user will not know what values they are looking at without adding this information to the tooltip.

Please again account for different conditions between count and other aggregations

Scrollbar and axis title are overlapping

Legend cannot be interacted with due to scrollbar

Please ensure that category values are always used as strings, not numbers

Implementation with the new tooltip:

Please ensure that category values are always used as strings, not numbers

This was not reproducible :point_up:

Implementation with the new tooltip:

Please ensure that category values are always used as strings, not numbers

This was not reproducible ☝

General comment (though probably unrelated to this issue): I would assume that the values shown within the bars are hidden in cases where the bar sections are too small to show values without heavy overlapping. I think this is also the behavior in other off-the-shelf tools like PowerBI. Ordino users should not be able to configure plots with heavy overplotting of labels or other nonsense visualizations (like the one shown in the screenshot). If the user wants to see the exact values of small bar sections, they can hover over the bar to read the value from the tooltip.

General comment (though probably unrelated to this issue): I would assume that the values shown within the bars are hidden in cases where the bar sections are too small to show values without heavy overlapping. I think this is also the behavior in other off-the-shelf tools like PowerBI. Ordino users should not be able to configure plots with heavy overplotting of labels or other nonsense visualizations (like the one shown in the screenshot). If the user wants to see the exact values of small bar sections, they can hover over the bar to read the value from the tooltip.

Thanks for your comment @mstreit! I have already taken care of overlapping and echarts provides a flag out of the box to avoid such a condition. The only reason that this plot looks like this is because the values associated with an individual bar is in millions.  (For example: The wider red bar in chromosome 18 has a value of about 75M and due to this, all the other labels are hidden since they would overlap).
Do you suggest that I use number formatter to show them as 75M instead of 75086514 in the bar plot?
Unfortunately, we do not have a control over the process of hiding the labels since it is done by echarts internally. This is the reason why the bar labels overlap the axis labels in some cases.

General comment (though probably unrelated to this issue): I would assume that the values shown within the bars are hidden in cases where the bar sections are too small to show values without heavy overlapping. I think this is also the behavior in other off-the-shelf tools like PowerBI. Ordino users should not be able to configure plots with heavy overplotting of labels or other nonsense visualizations (like the one shown in the screenshot). If the user wants to see the exact values of small bar sections, they can hover over the bar to read the value from the tooltip.

Thanks for your comment @mstreit! I have already taken care of overlapping and echarts provides a flag out of the box to avoid such a condition. The only reason that this plot looks like this is because the values associated with an individual bar is in millions. (For example: The wider red bar in chromosome 18 has a value of about 75M and due to this, all the other labels are hidden since they would overlap). Any bar which is hovered would show its value even if it overlaps the others.
Do you suggest that I use number formatter to show them as 75M instead of 75086514 in the bar plot? We already have the whole number displayed in the tooltip.
Unfortunately, we do not have a control over the process of hiding the labels since it is done by echarts internally. This is the reason why the bar labels overlap the axis labels in some cases.

I see. Thanks for clarifying this. Regarding how it should behave in corner cases, I suggest looking at general-purpose tools like PowerBI or Tableau.

@dvmartinweigl: I have set a minimum width to the bars so that they do not get very narrow. In case when the bar plot does not fir horizontally, a scrollbar is available. Could you please check that? Alternately, I could also add a config to shrink responsively and not use the min-width. Please let me know if I should go ahead with this.
/cc @thinkh

Alternately, I could also add a config to shrink responsively and not use the min-width. Please let me know if I should go ahead with this.

@dv-usama-ansari We could use a similar config like useFullHeight for the width as well. Then BioInsight could use the responsive mode that has no minimum bar width.
What do you think @dv-usama-ansari and @dvmartinweigl?

Just tested this again in bioinsight and everything looks good from my side :+1:

@dv-usama-ansari the list of feedback discussed in our review:

[ ] Add unit tests for /interfaces/internal/helpers/*
[ ] Remove sort buttons from header
[ ] Unknown color in legend and tooltip

[x]  Unknown color in legend and tooltip

This has been fixed in https://github.com/datavisyn/visyn_core/pull/497/commits/3bc84de9315f56273d2c949194b08ba79ef9b4c9

Fixed these issues from https://github.com/datavisyn/visyn_core/pull/497/commits/ad99544566b3730ce1a118f57d99d4f60253a193 to https://github.com/datavisyn/visyn_core/pull/497/commits/b9d4752968a446296f1c59096fed5a98a69af2e7:

https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404850466
https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404852492
https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404854719
https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404857865
https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404874012
https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404875704
https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404877637
https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404879739
https://github.com/datavisyn/visyn_core/issues/563#issuecomment-2404956316

Storybook fixed in https://github.com/datavisyn/visyn_core/pull/497/commits/45f3fb01dd5b9c8f8510f0fabc046ba90783e598
Below tests are still pending to write (in the same priority order):

https://github.com/datavisyn/visyn_core/blob/ua/bar-chart-selection/src/vis/bar/interfaces/internal/helpers/sort-series.test.ts
https://github.com/datavisyn/visyn_core/blob/ua/bar-chart-selection/src/vis/bar/interfaces/internal/helpers/get-bar-data.test.ts
https://github.com/datavisyn/visyn_core/blob/ua/bar-chart-selection/src/vis/bar/interfaces/internal/helpers/normalized-value.test.ts

I would write tests after finishing up https://github.com/datavisyn/reprovisyn/pull/2059/

Grouping by numerical column shows the bins correctly, but the colors are wrongly assigned.
I'd expect that the colors are assigned from light blue for the lowest values to dark blue for the highest values.

Fixed in https://github.com/datavisyn/visyn_core/pull/497/commits/94862478e95da4cb43ba15ab3a5df145958bb65f

@dv-usama-ansari Thanks for the fix. I can confirm that it works now as expected.

@dv-usama-ansari I saw that the Playwright tests are failing for this branch. in comparison the develop branch succeeded with the latest merge. Please check the tests and fix them. Thanks.

I have updated the MainApp like it was in develop. All of the tests pass except the download tests which are unrelated to this PR: https://github.com/datavisyn/visyn_core/actions/runs/11368336264/job/31623179398

Thank you for taking care of this.


Loglevel

Continuation of #618

I think it's ready now @stas00, did you want to add something else ?

LGTM


Align x-axis of all plots

When I'm looking at our benchmarks, I'm often interested in systematic effects. Was there recently a change that moved measurements into the one or the other direction.
Particularly for benchmarks/tests we added very recently this can be confusing since the x-axis does not align with the ones we've been running for a long time. That makes it difficult to correlate changes.
This could be improved by aligning all x-axis on the same page to be the same.
For example, the two plots below are really hard to correlate

This is not easy to do with native x-axis resolving in Vega, as we'd need to combine them into a single mega-chart. Probably the best way to do this would be to find a reasonable min/max value across all charts and manually apply it individually to the x-axis for all of them.


Prettier code formatting added... need more tooling?

What's added?

Prettier and pre-commit hooks for code styling
Styled existing JS and CSS files

What about other tooling?
Well, if this repo is to kept simple, more tooling can't be added because that would make it more complex to make changes. However, since many are involved, we will lose consistency without much tooling. Adding Prettier was an opinionated choice from my side and I don't know if this will get merged. If it does, do we go for more? Currently, HTML files are not being fixed (Prettier can't handle them) and if we care about optimizing, then we could be going for webpack or some other solution.
I wanted to raise this as an issue but it seems there is no option for doing that. @dvdsgl  is it cool to reorganize to support tooling or should this be kept simple?

Thank you for tackling this. Yes, if there is some simple command like npm run format and we add it to the README, I think that's a good idea.
I wonder if we could also integrate a reformatting process into npm start that watches for changes and formats on save?

@dvdsgl The way I have it setup in this PR is using prettier and husky to format CSS/JS when someone tries to commit. That way, it should be guaranteed to be consistent no matter what editor dev is using. It is possible to make prettier watch for changes and format accordingly although I think the present setup is more formidable. Plus, if someone is using an IDE/editor that has the corresponding prettier plugin installed, it should format on save like how it is for me.
We could add an npm run format command as well and maybe find suitable linting/fixing for the remainder of the files in the repo. I'd love to get suggestions on how to approach this since there are so many ways.

Oh I didn’t know about husky! Looks good, let’s try it.


[Epic] - Add Miranum Connect support for Flowable

[x] Description created
[x] Reviewed by peer: @Hafflgav
[x] Prioritised

Description
As a user of Flowable I want to be able to create integrations for my processes using Miranum Connect. I want to be able to use all features Miranum Connect currently offers for Camunda 7 and Camunda 8 Platform, such as worker registration, process start and message correlation.
Sub-Tasks
### Tasks
- [ ] https://github.com/FlowSquad/miranum/issues/71
- [ ] https://github.com/FlowSquad/miranum/issues/68
- [ ] https://github.com/FlowSquad/miranum/issues/69
- [ ] https://github.com/FlowSquad/miranum/issues/70
- [ ] https://github.com/FlowSquad/miranum/issues/71

Stakeholder
@Hafflgav @dominikhorn93
Acceptance

A worker use case implementation for Flowable
A process use case implementation for Flowable
A message correlation use case implementation for Flowable
I can create any workflow that is currently supported for Camunda7/8 Platform using Flowable.
The current examples which are implemented for C7/8 are extended to have Flowable example

Hey @rami-nk & @dominikhorn93,
given that we had some problems leveraging the external task pattern in Flowable, I have had a chat with one of their solution consultants. His recommendation was to rather publish events to a message queue and consume them from there. This is how they communicate with microservices in their projects most of the time.
Wdyt?

If that is the case, how is error & Incident handling done?
What about retries?
Are they using send reply pattern with message correlation?
We do the same at LHM by providing a "streaming template" that is used by every integration.
At this point the element templates change and things get a bit more complicated.
@lmoesle our pair programming 1 month ago in combination with a BPMN Call Activity should be a good start I guess?


Increase DJL Version for main branch

Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

Codecov Report

Merging #1644 (3f53295) into master (bb5073f) will decrease coverage by 1.24%.
The diff coverage is 62.14%.

@@             Coverage Diff              @@
##             master    #1644      +/-   ##
============================================
- Coverage     72.08%   70.84%   -1.25%
- Complexity     5126     5433     +307
============================================
  Files           473      507      +34
  Lines         21970    23769    +1799
  Branches       2351     2589     +238
============================================
+ Hits          15838    16839    +1001
- Misses         4925     5640     +715
- Partials       1207     1290      +83

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <ø> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <ø> (-5.24%)
:arrow_down:

...odality/cv/translator/BigGANTranslatorFactory.java
33.33% <0.00%> (+8.33%)
:arrow_up:

...nslator/InstanceSegmentationTranslatorFactory.java
14.28% <0.00%> (-3.90%)
:arrow_down:

.../modality/cv/translator/YoloTranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

...i/djl/modality/cv/translator/YoloV5Translator.java
5.69% <0.00%> (ø)

...odality/cv/translator/YoloV5TranslatorFactory.java
8.33% <0.00%> (-1.67%)
:arrow_down:

... and 245 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fab209...3f53295. Read the comment docs.


Prototype: Nylas availability drag-selection

Allows click+drag creation and click+drag movement of events
Contextual awareness of busy slots: will split a long event into multiple events if you drag over busy timeslots
Multi-day chaining: if an event ends at midnight and the next event starts the following day at midnight, consider that a single event
Timespans shown in events: now show "HH:MM - HH-MM" in all selected event spans (don't make the user glance to the ticks axis)
Side-effect: allow partial_bookable_ratio = 0 to let you book overtop of busy timeslots

https://user-images.githubusercontent.com/713991/133119312-5d80e252-d74f-4640-a3a6-046d4d2c8c34.mov
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@philrenaud per the slack conversation, I was testing dragging past 12 AM and you mentioned that the expected beahviour is triggering a "cancel" action (drag selection is cancelled).
I think we should re-think that as it is fairly easy for someone to lose their selection cancelling if they are moving quickly. We'll provide a better UX if we are a lot more lenient IMO.

Finally, the other bug is the "undefined" value for the end dates if we're at the end of the selectable time period (see the above gif).

Looking great, Phil! 🎉


Dijkstra distance between nodes are Infinity when using undirected graph

Hi!
I'm quite new to graphs, so this may not be a bug at all. Anyway, I noticed while i'm working on my network viewer(http://high5.io/network/), that the distance between nodes is quite randomly set to Infinity, instead of 1 or 2. When i type graphlib.alg.dijkstra(h5.network.graph, h5.id) in the console, I should see distance 0, 1 or anything but not Infinity I think. When I change the graph to directed and copy the edges, this problem seems to be gone. Any idea? Thanks by the way for creating this library!

The behavior is counter intuitive. The default edge traversal function is outEdges, regardless of whether the graph is directed or undirected. However, the behavior of outEdges is undefined for an undirected graph. The correct fix for this is to use outEdges for directed graphs and nodeEdges for undirected graphs.
To hold you over until I get the fix in, you can use:
graphlib.alg.dijkstra(h5.network.graph, h5.id, null, function(v) { return h5.network.graph.nodeEdges(v); })

Thanks! That worked perfectly.

I faced the same issue as @jvanveen.
Suggested hotfix worked fine.
@cpettitt do you consider this issue to be a bug?
p.s. thx for the lib


Add graph PU

Added a powerup that allows the user to display any multidimensional analysis view in a dashboard.

Please fix Readme.md


Update README.md to add detail about regional STS configuration / PrivateLink usage

Issue #, if available:
N/A
Description of changes:
Minor update to README.md to add additional detail about regional STS configuration file parameters / environment variables which may be required to force the IAM Auth library to use the regional STS URLs for traffic to be correctly routed via AWS PrivateLink.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Done


Default template from cargo lambda new generates unused warnings

We currently generate unused warnings from the boilerplate function generated by cargo lambda new. It's slightly off-putting to people who are starting, because warnings are scary.
We currently use this function signature:
async fn function_handler(event: Request) -> Result<Response<Body>, Error> {
   // ..
}

Perhaps we should simply add an underscore to event, e.g.:
async fn function_handler(_event: Request) -> Result<Response<Body>, Error> {
   // ..
}

i support that change

Done :)


Migrate Format checks on Startup of the application

Also we should consider creating a List for formats for individual repositories, in case an application has multiple repositories set up.

On hold now, as this app will be used for wildfly only currently.

Still would be nice for test isolation in combination with startup event firing

whenever a PR changing config file gets merged.

However it might get changed directly without PR. This is also problem currently

I think this is done now. Reopen otherwise.


Define basestring for Python 3

Also, avoid hardcoding the location of Python
Signed-off-by: Chris Clauss<EMAIL_ADDRESS>

Codecov Report

Merging #321 into master will decrease coverage by 0.03%.
The diff coverage is 50%.

@@            Coverage Diff            @@
##           master    #321      +/-   ##
=========================================
- Coverage   88.93%   88.9%   -0.04%
=========================================
  Files         115     115
  Lines        4582    4586       +4
=========================================
+ Hits         4075    4077       +2
- Misses        507     509       +2

Impacted Files
Coverage Δ

crawler/dockercontainer.py
91.82% <50%> (-0.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47cf882...fff997a. Read the comment docs.


feat(jest-config): Throw an error instead of showing a warning if multiple configs are used

Summary
Closes #12506

Test plan
I wrote/updated specific tests.

thanks for your help and review.


Port-forward requests mess up API success rate

What happened?
We are currently having KubeAPIErrorBudgetBurn alerts in our cluster, and our Grafana chart show pretty clearly that there are many read requests targeting pods that run for exactly 60 seconds.

After some digging and running this query cluster_quantile:apiserver_request_duration_seconds:histogram_quantile{resource="pods", cluster=""} we see that it is the portforward request that takes longer than what the SLO specifies.

But it seems to me that port-forwards should be long running operations by definition.
Did you expect to see some different?
As port-forwards are long running operations, it seems to me that it makes sense to take them out when calculating the aggregated success rate for the API resources.
How to reproduce it (as minimally and precisely as possible):
Run a bunch of port-forwards in a non-busy cluster. In our case, our developers connect to the development environment and many use Kube Forwarder.

The alert comes as-is from kubernetes-mixin project, please open an issue there.

Thanks @paulfantom and sorry for bothering you here. I opened an issue there: https://github.com/kubernetes-monitoring/kubernetes-mixin/issues/652.


added custom table naming strategy

Added a new strategy for naming tables in the sink connector that allows the source.table to be extracted from json value. Made it possible to create a single topic for multiple tables and use it to replicate multiple tables to the target DBMS.

Hi @nossheart, can you please target main for pull requests?


Spacing in RTL layout is incorrect

Rocket.Chat.Android version:
versionCode 1009
versionName "2.0.0-dev7"
Device
Device Name - Nexus 6
Android Version - 7.1.1
Description
change Layout from LTR to RTL. Spacing is incorrect between images and text.
Image

@filipedelimabrito Can I work on this issue?

@eliezer-of yes, please :relaxed:


State Management Sample

State management sample updated, fixed an import in Core Bot and updated requirements of CoreBot and Rich Cards.

updating of requirements fixes #170

        #time_property = Timex(result.travel_date)

Assuming broken?

Refers to: samples/Core-Bot/dialogs/main_dialog.py:59 in 0f276ad. [](commit_id = 0f276adb994cb125f76be67c0e43a2d52c5ed1c9, deletion_comment = False)

"""

Might want to adopt standard docstrings that autorest using..

Refers to: samples/Core-Bot/dialogs/booking_dialog.py:32 in 0f276ad. [](commit_id = 0f276adb994cb125f76be67c0e43a2d52c5ed1c9, deletion_comment = False)

Paste this URL in the emulator window - http://localhost:9000

Probably should default to 3978, and do we need to support V3?  Also, if it should add /api/messages

Refers to: samples/State-Management-Bot/README.md:29 in 0f276ad. [](commit_id = 0f276adb994cb125f76be67c0e43a2d52c5ed1c9, deletion_comment = False)

Select EchoBot-with-State.bot file

Think this is out of vogue now..

Refers to: samples/State-Management-Bot/README.md:25 in 0f276ad. [](commit_id = 0f276adb994cb125f76be67c0e43a2d52c5ed1c9, deletion_comment = False)

        #time_property = Timex(result.travel_date)

Assuming broken?
Refers to: samples/Core-Bot/dialogs/main_dialog.py:59 in 0f276ad. [](commit_id = 0f276ad, deletion_comment = False)

The Timex to natural language functionality is not ported yet


Audit drops/frees and zero sensitive data

We want to ensure that before we free sesitive memory we zero it.

https://crates.io/crates/zeroize

wip


Different Themes

I appreciate if you could add different themes with darker color for the user interface

Duplicate of #34.

I've actually tried this once already, but it was way to much work for me at that time. Especially since there were/are more important things to do, like bugfixes, code refactoring or more features in order to have a bit more advanced/distinguished crawler/downloader compared to all the other ones out there.
That's probably why most people either use:

MahApps Metro toolkit or
Material Design In XAML Toolkit

They both look pretty and using them is as simple as adding a few lines code. But then it looks like all the other apps again ;). I think the new TumblRipper is also using it and selling it as "big new feature" for basically no own work.

If you want, you can play around with it. I'll probably still find enough other playgrounds to sink time into.


Added Dissect Processor Functionality

Description
Implemented Dissect processor functionality.
Design overview:
For each pattern in map -

Breakdown the pattern into 2 groups:

List of fields
List of delimiters

Assign the properties of prefix and suffix notations.

(Used regex for above 2 steps. These are executed only once to process the dissect pattern, before processing the logs)

For an incoming log, check if the dissect_when expression satisfies

For each mapped field's value if present -

Split the string with the help of delimiters and assign the the text beween the delimiters to the fields.
Perform the operations on the fields, with the help of the suffix and prefix properties.
Convert the field types based on the target_types  map provided in the config.
Populate the output Json with the fields and their assigned values

Issues Resolved
[None]
Check List

[x] New functionality includes testing.
[x] New functionality has been documented.
[ ] New functionality has javadoc added
[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Closing in favor of #3363


Lazy create StaticFileMiddleware statemachine

Lazy create StaticFileMiddleware statemachine

@rynowak @JamesNK @Tratcher question...
dotnet new mvc etc adds app.UseStaticFiles(); prior to app.UseRouting() and app.UseEndpoints()  (also before auth) is this desirable?
https://github.com/aspnet/AspNetCore/blob/8b536b08ca76126e58f662b7f500bb191116f2bd/src/ProjectTemplates/Web.ProjectTemplates/content/StarterWeb-CSharp/Startup.cs#L157-L174
e.g. it outputs
app.UseStaticFiles();

app.UseCookiePolicy();

app.UseRouting();

app.UseAuthorization();

app.UseEndpoints(endpoints =>
{
    endpoints.MapControllerRoute(
        name: "default",
        pattern: "{controller=Home}/{action=Index}/{id?}");
    endpoints.MapRazorPages();
});

For the call chain

dotnet new mvc etc adds app.UseStaticFiles(); prior to app.UseRouting() and app.UseEndpoints() (also before auth) is this desirable?

Yes. Static files short circuits when it matches and doesn't interact with any of these things. So it makes sense to put before.

@Tratcher the ignore whitespace diff is clearest to look at


Can't add chem classes

For some reasons, I can't add chem classes. I can select the chem department, but then when I try to click the course number field, nothing happens (it's greyed out and I can't click it).

Sorry for the late reply. :(
This should now be fixed. Please reopen this issue if you are still facing problems.


Spelling error

I was checking my Github connection on my Dotenv page and I saw the logs had this statement: coud not locate base ref
It should say: could not locate base ref
The "l" in "could" is missing.

Good catch! Thank you. fixed up going forward.


very strange breakdown problem

Hi,
it looks like the Chrome extension is unavailable and my previously installed PHP Console not working anymore.

Hey,
There was some misunderstanding with Chrome Web Store policy auditors. They going to restore extension in a few days.
But for now you can use this version https://chrome.google.com/webstore/detail/pjlgfjdeemcagkbhcdnffmjcagnbnhme
Sorry about that.

Thank you! This tool saves a lot of time for me, I'm very happy about using of it!

Good news!
It's unlocked https://chrome.google.com/webstore/detail/php-console/nfhmhhlpfleoednkpnnnkolmclajemef


Add typescript-plugin-css-modules

Resolves #5677.
This can be tested by running:
npx git+ssh://git@github.com:mrmckeb/create-react-app.git#cra \
  test-app \
  --scripts-version=git+ssh://git@github.com:mrmckeb/create-react-app.git#react-scripts-typescript  \
  --typescript

Just tested it. Works like a charm.
Would it be a good idea to put a comment on how to enable it?

Hi @amshtemp, thanks for the feedback. Do you mean a comment in documentation? Or a comment in command line on how to use it with your IDE (mostly VSCode)?
Possibly docs, then linking to those docs from the command line?

@mrmckeb,
I don't know about the command line thing... isn't that a bit invasive?
I guess the docs is a better place, with cross referencing between the IDE and CSS Modules sections.
Maybe a better Idea is to have VSCode team adopt this. Do you think there is a chance? I'm asking because MS use their own CSS language server and this module fit that task well.

Docs would make sense. I understand what you're saying, but this solution works in all IDEs that support TypeScript, it's not related to VSCode.

Closing this off until plugins work at build-time.


Update yarn.lock to fix issues with private repos

Before this patch installing dependencies with Yarn would fail, due to
all the packages pointing to a private repository, which would return
401 Unauthorized for some packages.
Fixes #20

Thank you @mmieluch


React native 0.59 Async storage

After update react native to 0.59, I found some warnings related to AsyncStorage, because, the lastest version of react native, dont use AsyncStorage from react-native, they has moved this dependency to https://github.com/react-native-community/react-native-async-storage , I ask me if is possible do this change, if you want i could make a pull request with this change

will be fixed in the next version

Hii
Async storage not working .. it shows failed to download this image
Please help .. how to implement with async storage


Print a message when a build has no tests

If a call to get_tests returns a job that had no tests, print a message
indicating so to the user. Adding this message required adding the TESTS
QueryType.

I'll take in mind. I think we can merge it. I'll add a note in the daily about this break line between lines.
What do you mean about break line?
The issue I see with the output is that I requested for "--build 1" but got "No builds in query." - Not sure if that's expected or on purpose. I would expect to not see such jobs at all (jobs that don't have build number 1)

I'll take in mind. I think we can merge it. I'll add a note in the daily about this break line between lines.
What do you mean about break line?
The issue I see with the output is that I requested for "--build 1" but got "No builds in query." - Not sure if that's expected or on purpose. I would expect to not see such jobs at all (jobs that don't have build number 1)

I'm sorry. I took a look to the mail received not the comment in the PR:

Now I get what you mean.

You're right @bregman-arie, I have this issue identified and a task opened for it. I had the same problem with the Jenkins source, and can reuse the solution for elasticsearch, so during the day I'll submit patches for this problem for tests and builds.


Inspection middleware with jsonpickle

Inspection Middleware leveraging jsonpickle.
fixes #334

packages=["botbuilder.core", "botbuilder.core.adapters"],

inspection.

Refers to: libraries/botbuilder-core/setup.py:34 in 927a736. [](commit_id = 927a736afb2e1442bbedac58c42b6982dd6e46f5, deletion_comment = False)

packages=["botbuilder.core", "botbuilder.core.adapters"],

inspection.
Refers to: libraries/botbuilder-core/setup.py:34 in 927a736. [](commit_id = 927a736, deletion_comment = False)

Done


It possible to add namespace?

Hi @LeCanardNoir
For the moment not on this class, however you can use the API Core class to achieve the same thing, that is fully namespaced.
https://github.com/N1ghteyes/apicore
An example of the UAPI with it (untested):
`
setServer("server.cpanel.com");
$api->setVersion("1.1", FALSE);
$api->setBasePath('execute');

$response = $api->POST->Mysql->create_database(['name' => $cPanel->user.'_MyDatabase']);
?>
`

Thank you for the answer, i build a class exactly like this one with a namespace and use GuzzleHttp.
For the Core API i didn't have access, only root can use it in my hosting.
Thank


Full OLMo checkpoints?

🚀 The feature, motivation and pitch
Hi, really appreciate the work that y'all are doing.
Are y'all planning to release the checkpoint files for OLMo 7B? Right now the HF checkpoints don't seem to contain enough information to do finetuning using this repo. For e.g., optimizer states and config files are missing.
Alternatives
No response
Additional context
No response

Hi @jiahai-feng, yes we are. @2015aroras do you know the status of this?

https://github.com/allenai/OLMo/pull/500


Fix the order of tasks

What would you like to be added:
Right now bunch of different tasks in the doc have the same weight. We should come up with some sort of order in which we want / expect users to run through the tasks.
Why is this needed:
The tasks seem to be all over the place.
Completion requirements:
a order for the tasks decided and weights updated.
This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[x] Docs update

The artifacts should be linked in subsequent comments.

/remove-kind feature
/kind documentation


79 m1 config GitHub action to create release

Maybe we can squash these commits so avoid cluttering the other branches.


Generate webpack analyze JSON file without analyze mode triggers notice

Added
    analyze: {
      analyzerMode: 'disabled',
      generateStatsFile: true,
    },

to my nuxt.config.js file.
Run nuxt build --modern=client and still getting :
"Notice: Please do not deploy bundles built with \"analyze\" mode, they're for analysis purposes only."

Is this a false warning?

@pi0 could you have a quick look on that one please? I'm also trying to understand if there's a cli option to pass analyze config without using the nuxt.config file (for our CI pipeline)


Why the audio object should have integer title ?!!!!!!!!!!

I send audio with integer title to my robot and it throw exception after calling the getUpdates() method.


Increase default bottom drag for eddying channel simulation

@sandreza @xiaozhour please confirm this is your suggested change.

Confirmed! @xiaozhour and I used 1e-2, but 2e-2 should also be good. 2e-3 was way too small

Thanks


Gas optimisation

here's the stuff I wrote to improve gas efficiency in the methods that does the swap, if you're interested! I'm quite surprised this worked ahaha

thanks! I'll test more thoroughly on kovan and merge 👍


Add Code blocks in limit-storage-consumption.md

Add Code blocks in the Markdown spec to make it easy to read.

Signed-off-by: ydFu<EMAIL_ADDRESS>

/lgtm
/approve

/lgtm
/approve


Prevent infinite tree expansion for recursive elements.

Some elements in the data model may be infinitely recursive, meaning there is a loop with an element's type potentially having that same element as a child.
This looping allows a user to continue to expand the tree on the frontend without any sort of prevention or error.
Some mechanism should be in place to help prevent users from taking this action from both a UX and performance perspective.

The current behavior seems acceptable since it is up to the user whether or not to manually expand the tree and the loop does not continue on its own automatically.


Make file formatting comply with POSIX and Unix standards

UTF-8, LF, and no BOM are all recommended for file formatting. These settings are the most compatible with various tools and also take up the least amount of space (CRLF -> LF in a file means saving one byte per line). If the whole file has diffs, that's CRLF -> LF.
The POSIX standard for text files says that each text file should end with a newline, otherwise it is by definition not a text file. GitHub shows a warning when a file is committed without a terminating newline (see the "before" diffs of this PR), and GCC shows warnings when compiling files that don't end with newlines. See this SO question and this Unix SE question for more information.
CC @memononen

Pinging @memononen

These are external libraries, I will not alter them. If you convince upstream to change it, then I can merge the new files.

Upstream was uncooperative, unfortunately.


emit specific events for version changes

This will help us track how long it takes to indicate that we've achieved the next version.

/lgtm


Check if clause node src is a template uri before calling loadTemplateCallback

This ensures that we are calling loadTemplateCallback function with a template uri. We have added support for kits in Clause and the src attribute may now also point to a kit uri. The regex for kit uri differs from the regex for template uri.

@dselman Yes, it can

Will look at this more when I have a chance, but you'll want to adjust your commits (guide)

I would rather not hard code the format of template URIs into the component like this. If you can handle this check inside the callback yourself I think that would be preferable.


Add the ability to filter by date

Did you check if a similar feature request has already been reported?
Please do so first: https://github.com/ransome1/sleek/issues
yes
Describe the solution you'd like
A clear and concise description of what you want to happen.
It would be really useful to be able to quickly filter activities by their due date in the near future.
I believe the following filters are sufficient:

today;
tomorrow;
this week.

I believe this is already implemented as part of the filter syntax https://github.com/ransome1/sleek/wiki/Filter-Expressions-for-Advanced-Search#due-date-comparison

This is true, but it would be much more convenient to be able to do it faster from the predefined filters panel on the left (show filters -> B key)

More generally to implement this, I really think being able to set saved filters would be the best solution. That way people can customize to their needs.


Add handler for email errors by Symfony Mailer component

Since the Mailer component has appear in Symfony ecosystem, there is no need for Swift Mailer. But since monolog-bundle can't work with it we need to have one more dependency in our projects.
Adding a handler let escape of unnecessary dependency.

Implemented in symfony/symfony/pull#33456


FirewallRules Technet Scriptcenter Download

I came across your FilewallRules powershell files on gallery.technet.microsoft.com but didn't see any reference to project site or a way I can contribute here.

I'm going to close this 'issue' as it is really only a comment.  Though, I do suggest links and references are added on area you're distributing parts of your work.


Craft init needs a public path?

Looks like I needed to add:
publicPath: "/assets/javascripts"

@gregkohn Where did you need to add this, exactly?

I've also faced to this problem. In the task-config.js file you need to add:
publicPath: '/assets/javascripts'
to the javascript array. So it looks default like this way:
javascripts: {     publicPath: '/assets/javascripts',     entry: {       app: ["./app.js"]     }   }


VRAM usage is very high

Is your request related to a problem? Please describe.
My 970M only has 2 GiB VRAM, so it can't (properly) run 1080p, only 720p in emibl, but it can in viknell. It only runs because I have 8 GiB shared RAM, so it swaps out memory all the time. This means that on 1k it runs at 10-15 fps and 4k is probably way worse.
Describe the solution you'd like
A lot taken from my old branch https://github.com/TeamWisp/Procedural-Ray-Tracing/tree/feature_optimization.

Frame buffers:

G-Buffer

Use RG8 instead of RG16f for roughness (2 Bpp reduce)
Use normal compression to use RG16f instead of RGBA16f (4 Bpp reduce)

Get rid of unused (24 Bpp)
Total: 30 Bpp (30 / 76.75)

Textures:

Load HDR textures using RGBA16f instead of RGBA32f
Internally bake it to dds or load it with compression (always)

Models:

uv & pos can use ushort instead; 10 Bpv (saving 10 Bpv)
normal, tangent, bitangent can use unorm quat instead; 4 Bpv (saving 32 Bpv)
color can use uint instead; 4 Bpv (saving 8 Bpv)
Total: 18 Bpv instead of 68 Bpv

Describe alternatives you've considered
N.A. it's optimization.
Additional context
Note: The following is taken after ad0a90b9a65a1a646d03e78e2bacd7e2b1cb1180, meaning that we use a lot less VRAM, like 40 Bpp less
Constant usage:

128 - 256 MiB are taken by models (64 per pool)

Vertex size is 56, so approx 1 Mil vertices per pool (think about fragmentation that gets worse if vertices aren't compressed, since we have less vertices).

Use vertex compression; this can reduce it to approx 24 Bpv instead of 56, giving us 2.3x the vertices (might be important for big scenes)
Compression might have to use a compute shader, since we have A LOT of work to be done; 1 compute shader should get the max values, 1 should use those to compress them. Using 1 thread or 8 (multi threaded) is a lot less logical.

Textures take up A LOT in Emibl

One image already takes up 128 MiB (reason: DirectXTexHDR reads it as RGBA32f, while RGBA16f should be used)
Use texture compression (internally bake it to dds or process it)
Variable usage:

Frame buffers

Individual

Deferred main: 20 Bpp (4 depth, 6 normal, 6 color, 2 roughness, 2 metallic)
Convolution & Cubemap take up: 24 Bpp (12 each; unused)
Deferred composition: 8 Bpp (color)
Post processing: 4 - 8 Bpp (color; depending on if you render to HDR backbuffer)
DoF CoC: 4 Bpp (cone of confusion)
DoF down scale: 4 Bpp (16 Bpp 8 near, 8 far color, but half res)
DoF dilate near: .25 Bpp (4 Bpp, but quarter res)
DoF dilate flatten: .25 Bpp (4 Bpp, but quarter res)
DoF dilate flatten 2: .25 Bpp (4 Bpp, but quarter res)
Bokeh: 4 Bpp (16 Bpp, but half res)
Bokeh filter: 4 Bpp (16 Bpp, but half res)
DoF post filter: 4 - 8 Bpp (color; depending on if you render to HDR backbuffer)

Per task

Deferred main: 20 Bpp
Deferred composition: 8 Bpp
Post processing: 4-8 Bpp
DoF: 12.75- 16.75 Bpp
Bokeh: 8 Bpp
Unused: 24 Bpp

Total:

Non HDR: 76.75 Bpp
HDR: 84.75 Bpp

Meaning that (non HDR):

1280x720 = 67 MiB
1920x1080 = 152 MiB
3840x2160 = 607 MiB

https://github.com/microsoft/DirectXTex/blob/master/DirectXTex/DirectXTexCompress.cpp#L70


Add email notifications for when new reports are available

Add email notifications for when new reports are available.

Schedule a lambda function: https://github.com/cisagov/crossfeed/blob/master/backend/src/tasks/functions.yml#L1-L7
Function implementation: https://github.com/cisagov/crossfeed/blob/master/backend/src/tasks/scheduler.ts#L320
Send email code: https://github.com/cisagov/crossfeed/blob/7e41ccaaa71e0cf5009853bae3910186ee716d1f/backend/src/api/helpers.ts#L85

The entire reporting interface will be replaced by the existing back-office CyHy reporting API eventually.  Reporting notifications will be addressed at that time, not before.


Resource ID always set to '1' on calls to ActiveRecord::Base#create

Calling ActiveRecord::Base#create using a postgresql database and activerecord-jdbc-adapter-1.2.2 does not set the resource ID to the next value in the primary key sequence. Rather it's always set to 1. The value is correct in the database, and if the resource is reloaded, the id is correctly set.
Here is a simple script that illustrates the problem.  Change the Gemfile to use activerecord-jdbc-adapter-1.1.3 and the problem goes away.
https://github.com/lance/pk_sequence_test

Confirmed, regressed in ff14f8d3f626450f3f99bf1d2161254724c514c3.

Quick turnaround - thanks much!


Unrelated debugging extensions activated during debug sessions

Found discussing with @amyhartwig, @nalogan, and @chrisdias.
When debugging various project types, it appears that all extensions that support debugging are activated. This is not ideal in the presence of lots of extensions that might need to get activated at once. This might also affect activation events that extension authors keep track of.
#88849 might be related, as it relates to Microsoft-authored extensions that need to be switched to newer APIs.
If we can get someone from the engineering team to determine whether this is working as intended or a bug, that would be great.

VS Code debugging tries hard not to activate debug extension unnecessarily. But this requires that debug extensions use the correct activation events.
In order to investigate this issue we need additional information and reproducible steps:

What debug extensions get activated unnecessarily?
What are the steps that result in unnecessarily activation?

Looking at other chats, Naomi, explained it in the following way.

The reason is VS Code needs to activate all debuggers to collect the configurationProviders dynamically registered via API for launch configuration generator, and calls the corresponding configurationProvider according to the debugging language.

https://github.com/microsoft/vscode-java-debug/issues/238
https://github.com/microsoft/vscode-python/issues/9557
Specifically, the one I'm interested in is the built-in TypeScript/JavaScript Language Features extension.

"configurationProviders" are only needed in the initial (and rare) case where no launch.json exists and "unspecific" F5 debugging is requested and multiple debug extensions re installed. After a launch.json has been created, "configurationProviders" are never requested again.