Default unicode escape in JsonResponse

Laravel Version: 7.8.1
PHP Version: 7.2.29
Database Driver & Version: N/A

Description:
Hi!
The Illuminate\Http\JsonResponse class extending the Symfony\Component\HttpFoundation\JsonResponse class, overwrites the default encodingOptions with 0 value.
    public function __construct($data = null, $status = 200, $headers = [], $options = 0)
    {
        $this->encodingOptions = $options;

        parent::__construct($data, $status, $headers);
    }

The Symfony defaults are more secure than the 0 value defined by Laravel.
class JsonResponse extends Response
{
    // Encode <, >, ', &, and " characters in the JSON, making it also safe to be embedded into HTML.
    // 15 === JSON_HEX_TAG | JSON_HEX_APOS | JSON_HEX_AMP | JSON_HEX_QUOT
    const DEFAULT_ENCODING_OPTIONS = 15;

    protected $encodingOptions = self::DEFAULT_ENCODING_OPTIONS;

The "0" encodingOptions is not safe when the data is embeded into html
The same problem has been reported to Express : https://github.com/expressjs/express/issues/3268
I know this problem is not easily exploitable with direct API call in web browsers and in all other cases, users should not print json in html context without html encoding it first.
But we never know how data will be used and frameworks should have defaults as secured as possible.
In this case, the default encoding options used by Symfony are more secure than the default 0 value of Illuminate\Http\JsonResponse.
Steps To Reproduce:
class TestController extends Controller
{
    public function test()
    {
        return Response::json('<script>alert("abc");</script>');
    }
}

It should return
"\u003Cscript\u003Ealert(\u0022abc\u0022);\u003C\/script\u003E"

Instead of
"<script>alert(\"abc\");<\/script>"

Thanks. :)

This is asking for a behavior change and is not a "bug" we can fix on an existing patch release.


fix: add strict_subtract_mappings

This change is

Codecov Report
Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.59%. Comparing base (d88ec0a) to head (1ad5e5a).
Report is 8 commits behind head on main.

Files
Patch %
Lines

crates/blockifier/src/state/cached_state.rs
85.71%
0 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1632      +/-   ##
==========================================
+ Coverage   70.15%   70.59%   +0.44%
==========================================
  Files          59       59
  Lines        8330     8350      +20
  Branches     8330     8350      +20
==========================================
+ Hits         5844     5895      +51
+ Misses       2012     1977      -35
- Partials      474      478       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crates/blockifier/src/state/cached_state.rs line 155 at r4 (raw file):
Previously, noaov1 (Noa Oved) wrote…
I think it won't work after all :( See here.
So we may need to use the non-strict subtraction for this field.

I am not sure I completely understand why this is problematic. Does this function also get papyrus state? if that's the case should I use non-strict subtraction with a todo? or just a comment to say why it is not used?


Update directed-acyclic-graph.md

Pull Request type

[ ] Bugfix
[ ] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] WHOSUSING.md
[x] Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.
Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered

Doc fix based on https://github.com/conductor-oss/conductor/issues/177


Enable via story parameter

Hey folks,
is there a way to make a story initially show outlines? So that the viewer does not have to (know of and) press the button?

This repo is deprecated. The outline addon was moved to the Storybook core repo: https://github.com/storybookjs/storybook/tree/next/code/addons/outline


Feature/lint files

Linted lib/commands directory files.

updated @modulus/standard and tested everything, looks good.
was everyone able to look through lib/project.js?

@tzmanics I think this branch looks good, ready to review sub-branches as you complete them

@tzmanics I'm afraid all this work might be a lost cause 😢  :

we no longer use @modulus/standard internally, finally gave in and just use standard now
it is likely more work than is worth it just to get this back to not having conflicts

How do you feel about closing it and I will give it another shot

created #163 which converts the project to standard with very little other refactoring

Replaced by #163
Thanks @tzmanics for the effort!!


Milestone v0.8.0 planning

Please comment with links to issues that you feel should be tackled in the v0.8.0 release cycle

https://github.com/openservicemesh/osm/issues/685

https://github.com/openservicemesh/osm/issues/685

ref https://github.com/openservicemesh/osm/issues/2316

ref https://github.com/openservicemesh/osm/issues/2316

Consolidated list:

#685
#2316
#2115

Consolidated list:

#685
#2316
#2115

https://github.com/openservicemesh/osm/issues/2364

https://github.com/openservicemesh/osm/issues/2364

SMI Metrics:

#379
#984
#1540

SMI Metrics:

#379
#984
#1540

https://github.com/openservicemesh/osm/issues/2363
https://github.com/openservicemesh/osm/issues/2263
https://github.com/openservicemesh/osm/issues/2218
https://github.com/openservicemesh/osm/issues/2097
https://github.com/openservicemesh/osm/issues/1892
https://github.com/openservicemesh/osm/issues/1860
https://github.com/openservicemesh/osm/issues/705
Finish the remaining work in routes refactor:
https://github.com/openservicemesh/osm/issues/2048
https://github.com/openservicemesh/osm/issues/2038
If SMI metrics is a part of 0.8 I think we can incorporate this issue too :
https://github.com/openservicemesh/osm/issues/1671

https://github.com/openservicemesh/osm/issues/2363
https://github.com/openservicemesh/osm/issues/2263
https://github.com/openservicemesh/osm/issues/2218
https://github.com/openservicemesh/osm/issues/2097
https://github.com/openservicemesh/osm/issues/1892
https://github.com/openservicemesh/osm/issues/1860
https://github.com/openservicemesh/osm/issues/705
Finish the remaining work in routes refactor:
https://github.com/openservicemesh/osm/issues/2048
https://github.com/openservicemesh/osm/issues/2038
If SMI metrics is a part of 0.8 I think we can incorporate this issue too :
https://github.com/openservicemesh/osm/issues/1671

https://github.com/openservicemesh/osm/issues/2310

https://github.com/openservicemesh/osm/issues/2310

https://github.com/openservicemesh/osm/issues/2386

https://github.com/openservicemesh/osm/issues/2386

Candidates for v0.8

https://github.com/openservicemesh/osm/issues/85
https://github.com/openservicemesh/osm/issues/172
https://github.com/openservicemesh/osm/issues/281 -- could close it or could create a small tool - is it needed?
https://github.com/openservicemesh/osm/issues/507
https://github.com/openservicemesh/osm/issues/878
https://github.com/openservicemesh/osm/issues/893 (upgrades)
https://github.com/openservicemesh/osm/issues/902 (Prometheus metrics)
https://github.com/openservicemesh/osm/issues/912 (cli)
https://github.com/openservicemesh/osm/issues/917 (document observ'ty)
https://github.com/openservicemesh/osm/issues/959
https://github.com/openservicemesh/osm/issues/971 (refactor) -- close?
https://github.com/openservicemesh/osm/issues/1001 - ???
https://github.com/openservicemesh/osm/issues/1020
https://github.com/openservicemesh/osm/issues/1034
https://github.com/openservicemesh/osm/issues/1038
https://github.com/openservicemesh/osm/issues/1045 (HA)
https://github.com/openservicemesh/osm/issues/1152
https://github.com/openservicemesh/osm/issues/1150
https://github.com/openservicemesh/osm/issues/1140
https://github.com/openservicemesh/osm/issues/1139
https://github.com/openservicemesh/osm/issues/1085
https://github.com/openservicemesh/osm/issues/1407 (ci)
https://github.com/openservicemesh/osm/issues/1390
https://github.com/openservicemesh/osm/issues/1388
https://github.com/openservicemesh/osm/issues/1198
https://github.com/openservicemesh/osm/issues/1189
https://github.com/openservicemesh/osm/issues/1181
https://github.com/openservicemesh/osm/issues/1426
https://github.com/openservicemesh/osm/issues/1420
https://github.com/openservicemesh/osm/issues/1511 (integrate with Azure Monitor -- add ConfigMap?)
https://github.com/openservicemesh/osm/issues/1508
https://github.com/openservicemesh/osm/issues/1501
https://github.com/openservicemesh/osm/issues/1489
https://github.com/openservicemesh/osm/issues/1488
https://github.com/openservicemesh/osm/issues/1461
https://github.com/openservicemesh/osm/issues/1717
https://github.com/openservicemesh/osm/issues/1718
https://github.com/openservicemesh/osm/issues/1720
https://github.com/openservicemesh/osm/issues/1723
https://github.com/openservicemesh/osm/issues/1785
https://github.com/openservicemesh/osm/issues/1839
https://github.com/openservicemesh/osm/issues/1841
https://github.com/openservicemesh/osm/issues/1851
https://github.com/openservicemesh/osm/issues/1855
https://github.com/openservicemesh/osm/issues/1860
https://github.com/openservicemesh/osm/issues/1874
https://github.com/openservicemesh/osm/issues/1892 (multicluster story)
https://github.com/openservicemesh/osm/issues/1913
https://github.com/openservicemesh/osm/issues/1916
https://github.com/openservicemesh/osm/issues/1919
https://github.com/openservicemesh/osm/issues/1921
https://github.com/openservicemesh/osm/issues/1933
https://github.com/openservicemesh/osm/issues/1938
https://github.com/openservicemesh/osm/issues/1939
https://github.com/openservicemesh/osm/issues/1941
https://github.com/openservicemesh/osm/issues/1958
https://github.com/openservicemesh/osm/issues/1974
https://github.com/openservicemesh/osm/issues/1975
https://github.com/openservicemesh/osm/issues/1979
https://github.com/openservicemesh/osm/issues/1983
https://github.com/openservicemesh/osm/issues/2008
https://github.com/openservicemesh/osm/issues/2012
https://github.com/openservicemesh/osm/issues/2034
https://github.com/openservicemesh/osm/issues/2038
https://github.com/openservicemesh/osm/issues/2048
https://github.com/openservicemesh/osm/issues/2052
https://github.com/openservicemesh/osm/issues/2064
https://github.com/openservicemesh/osm/issues/2068
https://github.com/openservicemesh/osm/issues/2097
https://github.com/openservicemesh/osm/issues/2100
https://github.com/openservicemesh/osm/issues/2103
https://github.com/openservicemesh/osm/issues/2106
https://github.com/openservicemesh/osm/issues/2115
https://github.com/openservicemesh/osm/issues/2126
https://github.com/openservicemesh/osm/issues/2134
https://github.com/openservicemesh/osm/issues/2147
https://github.com/openservicemesh/osm/issues/2151
https://github.com/openservicemesh/osm/issues/2152
https://github.com/openservicemesh/osm/issues/2156
https://github.com/openservicemesh/osm/issues/2172
https://github.com/openservicemesh/osm/issues/2190
https://github.com/openservicemesh/osm/issues/2201
https://github.com/openservicemesh/osm/issues/2207
https://github.com/openservicemesh/osm/issues/1528
https://github.com/openservicemesh/osm/issues/1537
https://github.com/openservicemesh/osm/issues/1540
https://github.com/openservicemesh/osm/issues/1575
https://github.com/openservicemesh/osm/issues/1590
https://github.com/openservicemesh/osm/issues/1596
https://github.com/openservicemesh/osm/issues/1655
https://github.com/openservicemesh/osm/issues/1658
https://github.com/openservicemesh/osm/issues/1670
https://github.com/openservicemesh/osm/issues/1678
https://github.com/openservicemesh/osm/issues/1681
https://github.com/openservicemesh/osm/issues/2263
https://github.com/openservicemesh/osm/issues/2218
https://github.com/openservicemesh/osm/issues/2279
https://github.com/openservicemesh/osm/issues/2311
https://github.com/openservicemesh/osm/issues/2316
https://github.com/openservicemesh/osm/issues/2344
https://github.com/openservicemesh/osm/issues/2356
https://github.com/openservicemesh/osm/issues/2363
https://github.com/openservicemesh/osm/issues/2364
https://github.com/openservicemesh/osm/issues/2365

clean up:

https://github.com/openservicemesh/osm/issues/94 - close
https://github.com/openservicemesh/osm/issues/286 - close
https://github.com/openservicemesh/osm/issues/178 - close
https://github.com/openservicemesh/osm/issues/291 - close
https://github.com/openservicemesh/osm/issues/836 - close
https://github.com/openservicemesh/osm/issues/892 - close
https://github.com/openservicemesh/osm/issues/979 - close
https://github.com/openservicemesh/osm/issues/1041 - close

check status:

https://github.com/openservicemesh/osm/issues/705
https://github.com/openservicemesh/osm/issues/1037
https://github.com/openservicemesh/osm/issues/1058 - can we close it? If not - add it to v0.8 so we can close this
https://github.com/openservicemesh/osm/issues/1167 - ?
https://github.com/openservicemesh/osm/issues/1427
https://github.com/openservicemesh/osm/issues/1710 - this could be closed
https://github.com/openservicemesh/osm/issues/2022

Candidates for v0.8

https://github.com/openservicemesh/osm/issues/85
https://github.com/openservicemesh/osm/issues/172
https://github.com/openservicemesh/osm/issues/281 -- could close it or could create a small tool - is it needed?
https://github.com/openservicemesh/osm/issues/507
https://github.com/openservicemesh/osm/issues/878
https://github.com/openservicemesh/osm/issues/893 (upgrades)
https://github.com/openservicemesh/osm/issues/902 (Prometheus metrics)
https://github.com/openservicemesh/osm/issues/912 (cli)
https://github.com/openservicemesh/osm/issues/917 (document observ'ty)
https://github.com/openservicemesh/osm/issues/959
https://github.com/openservicemesh/osm/issues/971 (refactor) -- close?
https://github.com/openservicemesh/osm/issues/1001 - ???
https://github.com/openservicemesh/osm/issues/1020
https://github.com/openservicemesh/osm/issues/1034
https://github.com/openservicemesh/osm/issues/1038
https://github.com/openservicemesh/osm/issues/1045 (HA)
https://github.com/openservicemesh/osm/issues/1152
https://github.com/openservicemesh/osm/issues/1150
https://github.com/openservicemesh/osm/issues/1140
https://github.com/openservicemesh/osm/issues/1139
https://github.com/openservicemesh/osm/issues/1085
https://github.com/openservicemesh/osm/issues/1407 (ci)
https://github.com/openservicemesh/osm/issues/1390
https://github.com/openservicemesh/osm/issues/1388
https://github.com/openservicemesh/osm/issues/1198
https://github.com/openservicemesh/osm/issues/1189
https://github.com/openservicemesh/osm/issues/1181
https://github.com/openservicemesh/osm/issues/1426
https://github.com/openservicemesh/osm/issues/1420
https://github.com/openservicemesh/osm/issues/1511 (integrate with Azure Monitor -- add ConfigMap?)
https://github.com/openservicemesh/osm/issues/1508
https://github.com/openservicemesh/osm/issues/1501
https://github.com/openservicemesh/osm/issues/1489
https://github.com/openservicemesh/osm/issues/1488
https://github.com/openservicemesh/osm/issues/1461
https://github.com/openservicemesh/osm/issues/1717
https://github.com/openservicemesh/osm/issues/1718
https://github.com/openservicemesh/osm/issues/1720
https://github.com/openservicemesh/osm/issues/1723
https://github.com/openservicemesh/osm/issues/1785
https://github.com/openservicemesh/osm/issues/1839
https://github.com/openservicemesh/osm/issues/1841
https://github.com/openservicemesh/osm/issues/1851
https://github.com/openservicemesh/osm/issues/1855
https://github.com/openservicemesh/osm/issues/1860
https://github.com/openservicemesh/osm/issues/1874
https://github.com/openservicemesh/osm/issues/1892 (multicluster story)
https://github.com/openservicemesh/osm/issues/1913
https://github.com/openservicemesh/osm/issues/1916
https://github.com/openservicemesh/osm/issues/1919
https://github.com/openservicemesh/osm/issues/1921
https://github.com/openservicemesh/osm/issues/1933
https://github.com/openservicemesh/osm/issues/1938
https://github.com/openservicemesh/osm/issues/1939
https://github.com/openservicemesh/osm/issues/1941
https://github.com/openservicemesh/osm/issues/1958
https://github.com/openservicemesh/osm/issues/1974
https://github.com/openservicemesh/osm/issues/1975
https://github.com/openservicemesh/osm/issues/1979
https://github.com/openservicemesh/osm/issues/1983
https://github.com/openservicemesh/osm/issues/2008
https://github.com/openservicemesh/osm/issues/2012
https://github.com/openservicemesh/osm/issues/2034
https://github.com/openservicemesh/osm/issues/2038
https://github.com/openservicemesh/osm/issues/2048
https://github.com/openservicemesh/osm/issues/2052
https://github.com/openservicemesh/osm/issues/2064
https://github.com/openservicemesh/osm/issues/2068
https://github.com/openservicemesh/osm/issues/2097
https://github.com/openservicemesh/osm/issues/2100
https://github.com/openservicemesh/osm/issues/2103
https://github.com/openservicemesh/osm/issues/2106
https://github.com/openservicemesh/osm/issues/2115
https://github.com/openservicemesh/osm/issues/2126
https://github.com/openservicemesh/osm/issues/2134
https://github.com/openservicemesh/osm/issues/2147
https://github.com/openservicemesh/osm/issues/2151
https://github.com/openservicemesh/osm/issues/2152
https://github.com/openservicemesh/osm/issues/2156
https://github.com/openservicemesh/osm/issues/2172
https://github.com/openservicemesh/osm/issues/2190
https://github.com/openservicemesh/osm/issues/2201
https://github.com/openservicemesh/osm/issues/2207
https://github.com/openservicemesh/osm/issues/1528
https://github.com/openservicemesh/osm/issues/1537
https://github.com/openservicemesh/osm/issues/1540
https://github.com/openservicemesh/osm/issues/1575
https://github.com/openservicemesh/osm/issues/1590
https://github.com/openservicemesh/osm/issues/1596
https://github.com/openservicemesh/osm/issues/1655
https://github.com/openservicemesh/osm/issues/1658
https://github.com/openservicemesh/osm/issues/1670
https://github.com/openservicemesh/osm/issues/1678
https://github.com/openservicemesh/osm/issues/1681
https://github.com/openservicemesh/osm/issues/2263
https://github.com/openservicemesh/osm/issues/2218
https://github.com/openservicemesh/osm/issues/2279
https://github.com/openservicemesh/osm/issues/2311
https://github.com/openservicemesh/osm/issues/2316
https://github.com/openservicemesh/osm/issues/2344
https://github.com/openservicemesh/osm/issues/2356
https://github.com/openservicemesh/osm/issues/2363
https://github.com/openservicemesh/osm/issues/2364
https://github.com/openservicemesh/osm/issues/2365

clean up:

https://github.com/openservicemesh/osm/issues/94 - close
https://github.com/openservicemesh/osm/issues/286 - close
https://github.com/openservicemesh/osm/issues/178 - close
https://github.com/openservicemesh/osm/issues/291 - close
https://github.com/openservicemesh/osm/issues/836 - close
https://github.com/openservicemesh/osm/issues/892 - close
https://github.com/openservicemesh/osm/issues/979 - close
https://github.com/openservicemesh/osm/issues/1041 - close

check status:

https://github.com/openservicemesh/osm/issues/705
https://github.com/openservicemesh/osm/issues/1037
https://github.com/openservicemesh/osm/issues/1058 - can we close it? If not - add it to v0.8 so we can close this
https://github.com/openservicemesh/osm/issues/1167 - ?
https://github.com/openservicemesh/osm/issues/1427
https://github.com/openservicemesh/osm/issues/1710 - this could be closed
https://github.com/openservicemesh/osm/issues/2022

#2390
#2392

#2390
#2392

#2394

#2394

I'd like to have the routes refactor completed and ready for cut-over by the end of this milestone. The issues needed to achieve this are :
https://github.com/openservicemesh/osm/issues?q=is%3Aopen+is%3Aissue+label%3A"routes+v2"

I'd like to have the routes refactor completed and ready for cut-over by the end of this milestone. The issues needed to achieve this are :
https://github.com/openservicemesh/osm/issues?q=is%3Aopen+is%3Aissue+label%3A"routes+v2"

#2159

#2159

https://github.com/openservicemesh/osm/issues/2414

https://github.com/openservicemesh/osm/issues/2414

#1045

Milestone 0.8 planning was completed a while ago


Ignore Super and other modifier keys except for Alt

Description
Mozc doesn't know Super and other extra modifier keys except for Alt. For example, "Super + Space" (IBus' default for switching input methods) is recognized as "Space".
This change ignores key events that have these extra modifiers to let others handle the events.
Issue IDs
#853
Steps to test new behaviors (if any)
A clear and concise description about how to verify new behaviors (if any).

OS: Ubuntu 24.04 + Wayland
Steps:

Switch to Japanese (Mozc) by pressing Super-Space
Switch to English by pressing Super-Space again
Confirm the switch (before this PR,  a full-width space was inserted instead)

Additional context
Add any other context about the pull request here.

When using ibus-mozc with Japanese input mode enabled and set to full-width hiragana input mode, there is an issue where pressing Super+space inserts a full-width space instead of switching the input source. This PR resolves this issue. I tested it on Manjaro Linux and confirmed that it works well.

Hi kzys,
Thank you for your PR with tests! Overall, it looks good to me.
I left small comments regarding our coding style.
Thank you,

Thanks! Addressed in the last revision.

I'm encountering some issues. When I checked earlier, there were no problems, but now, upon rechecking, I've found the following issues. While switching input sources works fine, I'm facing two problems:
The system doesn't accept input of full-width characters like hiragana.
Pressing the full-width key doesn't switch the input mode.

Currently, I'm clearing the cache and rebuilding to recheck these issues.

After testing in my local environment, I found that either of the following solutions resulted in the expected behavior:

Completely remove the changes in src/unix/ibus/key_event_handler.cc and keep only the changes in src/unix/ibus/key_event_handler_test.cc.
In the modified part of src/unix/ibus/key_event_handler.cc, set kExtraModMask to only IBUS_MOD4_MASK.

I continued troubleshooting.
It might depend on keyboard layouts, but in my environment, adding IBUS_MOD2_MASK to kExtraModMask prevented the IME from being activated by the half-width/full-width key or the hiragana key.
Removing IBUS_MOD2_MASK from kExtraModMask and using only IBUS_MOD4_MASK, or adding either or both of IBUS_MOD3_MASK and IBUS_MOD5_MASK, allowed the IME to be activated.
Since this might be environment-dependent, I think it might be better to limit it to just IBUS_MOD4_MASK for the Super key to minimize potential impacts.
For your reference.
 * @IBUS_MOD1_MASK: Modifier 1 (Usually Alt_L (0x40),  Alt_R (0x6c),  Meta_L (0xcd)) activated.
 * @IBUS_MOD2_MASK: Modifier 2 (Usually Num_Lock (0x4d)) activated.
 * @IBUS_MOD3_MASK: Modifier 3 activated.
 * @IBUS_MOD4_MASK: Modifier 4 (Usually Super_L (0xce),  Hyper_L (0xcf)) activated.
 * @IBUS_MOD5_MASK: Modifier 5 (ISO_Level3_Shift (0x5c),  Mode_switch (0xcb)) activated.

It might depend on keyboard layouts, but in my environment, adding IBUS_MOD2_MASK to kExtraModMask prevented the IME from being activated by the half-width/full-width key or the hiragana key.

Thanks. Interesting. Let me check. I don't have a Japanese keyboard nearby though.
I don't know how these Japanese-specific keys get Mod1. Is it coming from XKB somehow?
https://github.com/ibus/ibus/blob/fa10c116c2f0dad5026fa6665e9513cd5dcded75/client/wayland/ibuswaylandim.c#L690-L691

@phoepsilonix Can you check xmodmap on your machine? I got the below.
% xmodmap
xmodmap:  up to 4 keys per modifier, (keycodes in parentheses):

shift       Shift_L (0x32),  Shift_R (0x3e)
lock        Caps_Lock (0x42)
control     Control_L (0x25),  Control_R (0x69)
mod1        Alt_L (0x40),  Alt_R (0x6c),  Alt_L (0xcc),  Meta_L (0xcd)
mod2        Num_Lock (0x4d)
mod3        ISO_Level5_Shift (0xcb)
mod4        Super_L (0x85),  Super_R (0x86),  Super_L (0xce),  Hyper_L (0xcf)
mod5        ISO_Level3_Shift (0x5c)

The differences are about as follows. Eisu_toglle probably refers to the alphanumeric toggle.
lock        Eisu_toggle (0x42)
lock        Caps_Lock (0x42)
xmodmap:  up to 4 keys per modifier, (keycodes in parentheses):

shift       Shift_L (0x32),  Shift_R (0x3e)
lock        Eisu_toggle (0x42)
control     Control_L (0x25),  Control_R (0x69)
mod1        Alt_L (0x40),  Alt_R (0x6c),  Alt_L (0xcc),  Meta_L (0xcd)
mod2        Num_Lock (0x4d)
mod3        ISO_Level5_Shift (0xcb)
mod4        Super_L (0x85),  Super_R (0x86),  Super_L (0xce),  Hyper_L (0xcf)
mod5        ISO_Level3_Shift (0x5c)

I use NUMLOCK enabled at startup. I always keep NUMLOCK on because I have a numeric keypad. Some keyboards don't have a numeric keypad, and NUMLOCK might affect the main keyboard layout. I was wondering if this could be the cause of the issue.
This is a behavior test of ibus-mozc with IBUS_MOD2_MASK added to kExtraModMask.

When NUMLOCK is off, the IME becomes active and Japanese input becomes possible.
When NUMLOCK is on, it seems impossible to toggle the IME on and off.
In other words, the on/off state of NUMLOCK is affecting the behavior of the full-width/half-width key and the hiragana key. This issue does not occur with ibus-mozc without adding IBUS_MOD2_MASK to kExtraModMask.

@phoepsilonix Thanks! That makes more sense. Updated the mask.

We have merged your PR.
Thank you for your contribution!


Unicode foldernames for navigation

If a folder in content contains unicode characters, it fails to match in Page.find on this line of code:
disk_path = Dir["#{path}/*#{search_path}/*.yml"]
I'm not sure how to fix it, but it seems Dir is a bit allergic to this sort of thing.
Example (using bonsai's support content with added folder):
1.9.2-p318 :127 > pp Dir["spec/support/content/*"]
["spec/support/content/1.about-us",
 "spec/support/content/10.many-pages",
 "spec/support/content/2.products",
 "spec/support/content/3.unicode-æøå",
 "spec/support/content/index",
 "spec/support/content/legals",
 "spec/support/content/render"]
1.9.2-p318 :128 > Dir["spec/support/content/*unicode-æøå"]
 => []
1.9.2-p318 :129 > Dir["spec/support/content/*about-us"]
 => ["spec/support/content/1.about-us"]

Since Navigation relies on the the converted foldernames, it means there is no way to have a page with a unicode title.
It seems Ruby has these notorious unicode issues, so perhaps a solution would be, to add a manual override of the default behaviour for extracting navigation items. E.g. in the case of the presence of a specially named .yml file, read the name and title from from that file, instead of inferring it from the parent foldername?

No reply from maintainer.


STR-687: improve NUMS unspendable public key

Description

The codebase currently uses a nonstandard instance of a BIP-341 method for producing unspendable public keys. It does so by applying an arbitrary offset to a known unspendable key. This offset is not verifiably random, and provides no security benefit. It is therefore unnecessary.
This PR replaces all uses of this method. Instead, we hash a fixed string and use it to produce a curve group generator. Note that this is not guaranteed to be a uniformly-sampled curve point! However, this is not relevant here, as the only security requirement is that the result not have an efficiently-computable discrete logarithm relation against the standard generator.
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[x] Refactor
[ ] New or updated tests
[ ] Dependency Update

Notes to Reviewers

There are multiple uses of this construction. All should be carefully reviewed to ensure that corresponding changes are done consistently.
Checklist

[x] I have performed a self-review of my code.
[x] I have commented my code where necessary.
[x] I have updated the documentation if needed.
[x] My changes do not introduce new warnings.
[x] I have added tests that prove my changes are effective or that my feature works.
[x] New and existing tests pass with my changes.

Related Issues

None.

error: unresolved link to `UNSPENDABLE_INTERNAL_KEY`
  --> crates/bridge-tx-builder/src/operations.rs:70:34
   |
70 |     /// internal key being the [`static@UNSPENDABLE_INTERNAL_KEY`].
   |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no item named `UNSPENDABLE_INTERNAL_KEY` in scope
   |
   = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
   = note: `-D rustdoc::broken-intra-doc-links` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(rustdoc::broken_intra_doc_links)]`

That's annoying.

@delbonis: Fixed.


manually updated places / checkins have weird creation dates

Fetched http://me.singly.com/Me/places/update to force the update of my places collection, got a huuuuuge pile of events that showed a date in HelloPlaces of sometime today.

I've not seen/reproduced this, could you check again and maybe grab the actual json returned at https://me.singly.com/Me/places?offset=0&limit=1000&sort=at&order=-1 ?

Which date? Lot's of objects have a timestamp that is whenever the collection encountered the object and a "created_at" date or something like that that is a true creation date.

I'm just going by the date shown in the stock HelloPlaces list viewer. If this is the behavior you guys expect, that's fine, but it surprised me, because I was expecting the date of the checkin / photo / whatever.

Sounds like we can close this? @othiym23?

Yeah, I think this can be put down to me being confused about what happened at place event creation time. Closing.


Converted remaining vars to const or let.

For better block scoping, converted remaining occurrences of var to
const or let where reassignment was necessary.

Nice job in converting app.js to ES6 syntax. 👍 I noticed there were a lot of vars still hanging around. For better block scoping in converted the remaining ones to const unless reassignment was necessary.   This builds and passes your jest test. I also dropped it into a local copy of your examples and they all work.

Hi @rbiggs! Thank you, but this is the same as https://github.com/hyperapp/hyperapp/pull/42.

This won't happen using Rollup + Buble. But there another thing would happen that will increase the bundle with 50-100 bytes (because the route function).

Closing


Crypto Exchange

@shawaj we recommend Binance but they don't seem to actually let you trade HNT?

https://www.binance.us/en/trade/HNT_USD
This page implies you can @ryanteck ?

https://www.binance.us/en/trade/HNT_USD
This page implies you can @ryanteck ?

Sorry yep via the simplified view they currently dont but via another they do.

Sorry yep via the simplified view they currently dont but via another they do.

It seems binance.com only allows HNT/BTC and HNT/USDT but binance.us also allows HNT/USD
https://www.binance.com/en/trade/HNT_BTC

It seems binance.com only allows HNT/BTC and HNT/USDT but binance.us also allows HNT/USD
https://www.binance.com/en/trade/HNT_BTC


docs[srs-23]: complete SRS-23

Contains the cost section of the SRS
$0 monetary cost. My PC has all the power we need to train our models
Time cost is straightforward, we'll probably be consistently working on this until the final expo so 8 months
Using function point cost estimate (volere says it's the best for non-unit estimations)

No major disagreements here. For non commercial usages, spotify API calls are free. I'm not 100% certain we should state that machine learning training is to be done on Matthew's desktop setup, but it is a good suggestion/consideration at the very least.


Trying to open a non-existant .po file gives incorrect error

                raise IOError('Syntax error in po file %s(line %s)' %
                              (fpath, self.current_line))

but in fact the file doesn't exist.

The problem here is that polib can both parse a string directly, or read a file and parse its contents. If the input is not an existing file (polib.py line 1266), it assumes that input is a string and tries to parse it, hence the error message you're seeing.
"Fixing" the error message would mean guessing that the input looks path-like and giving the user feedback to that effect.

Hmm.. well that's unfortunate. I guess the real fix is to have different arguments for path and for a string. But the error message could at least say "The file does not exist, or there's a syntax error" or something. It's not great, but it's at least not a lie.

@kthy What about assuming that if the string contains a line break, it is meant as direct text, and in all other cases it's a filepath? This simple rule would get the error message from "always wrong" to "wrong in probably less than 1/10000 cases".
I don't think there are practical use cases where a file is named msgid "".po.


[FLINK-6632][table]Improved the method BoolLiteral of ExpressionParse…

This PR. only improved the method BoolLiteral of ExpressionParser for case insensitive.

[x] General

The pull request references the related JIRA issue ("[FLINK-6632][table]Improved the method BoolLiteral of ExpressionParser for case insensitive.")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[x] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Hi, @twalthr In this PR. I want change the method boolLiteral of ExpressionParser. @fhueske had a suggestion that we should add "true" and "false" as keywords to the parser. Because Keywords are parsed case-insensitive. And I appreciate If you can give us some suggestions.
Thanks,
SunJincheng

Thanks @sunjincheng121. Yes, I think a keyword is a nicer approach. I will add it and merge your tests.


1.1 Login Credentials [frontend]

Description
As a user, I want to login via email, username, or SSO so that I can access my account and continue using the app.
Story Points: 8
Priority: 1
Risk: Low
Child Tasks:
Acceptance Criteria:
Task Breakdown:
Implementation Breakdown:
Blackbox Testing:
Regression Testing:
Demo Steps:

Proposed UI from Figma:


ignoring unsupported keyword arguments for client and ExtraArgs

Problem description
Be sure your description clearly answers the following questions:

What are you trying to achieve?
Using the smart_open.open function I am trying to pass the client and ExtraArgs keywords allowed in Boto3 to my stream to an S3 bucket. boto3 upload docs
What is the expected result?
My expectation is that the data will be added to the s3 bucket without any warnings and that the ExtraArgs will be applied
What are you seeing instead?
What I am seeing instead is that while the data is still being uploaded to the s3 bucket it:
1. Kicks back a warnings re: client and ExtraArgs keywords
2. Doesn't apply the ExtraArgs to the dataset on s3

Steps/code to reproduce the problem
In order for us to be able to solve your problem, we have to be able to reproduce it on our end.
Without reproducing the problem, it is unlikely that we'll be able to help you.
input

s3_client = boto3.client("s3")
extra_args = {'ContentType': 'text/csv'}
file_path = smart_open.open(("s3://" + bucket + "/" + key), 'w', newline="",
                                        transport_params=dict(client=s3_client, ExtraArgs=extra_args))

file = io.StringIO()
with file_path as file_out:
    writer = DictWriter(file)
    writer.writeheader()
    file_out.write(file.getvalue())

output
WARNING - ignoring unsupported keyword arguments: ['ExtraArgs', 'client']

Include full tracebacks, logs and datasets if necessary.
Please keep the examples minimal (minimal reproducible example).
Versions
Please provide the output of:
import platform, sys, smart_open
print(platform.platform())
print("Python", sys.version)
print("smart_open", smart_open.__version__)

Windows-10-10.0.19041-SP0
Python 3.8.3 (tags/v3.8.3:6f8c832, May 13 2020, 22:37:02) [MSC v.1924 64 bit (AMD64)]
smart_open 4.2.0

Checklist
Before you create the issue, please make sure you have:

[x] Described the problem clearly
[x] Provided a minimal reproducible example, including any required data
[x] Provided the version numbers of the relevant software

We don't support ExtraArgs, because we don't call the function that accepts them (upload_file). See https://github.com/RaRe-Technologies/smart_open/blob/develop/howto.md#how-to-pass-additional-parameters-to-boto3 for more details.
Does the warning go away if you remove ExtraArgs?

Thanks for the heads up regarding ExtraArgs. Is there thoughts on adding this as a feature eventually?
Also the warning for client still appears when ExtraArgs is removed.

No, because we use a different API to upload the file. What arguments are you attempting to pass? Is it possible to pass them as something compatible with the functions that we are calling instead?
Furthermore, the reason the client is being ignored is because you're incorrectly passing a tuple instead of a string as a URL.
Wrong:
file_path = smart_open.open(("s3://" + bucket + "/" + key), 'w', newline="", ...)

Right:
file_path = smart_open.open("s3://" + bucket + "/" + key, 'w', newline="", ...)

For the Extra Args we are looking at setting the ServerSideEncryption and ContentType. I looked at the Boto3 docs and they have both of those as passable arguments for what appear to be all of the functions you call from the how-to docs you sent me. However when I put them in I get the same warning and they aren't added to my file in S3.
s3_client = boto3.client("s3")
            file_path = smart_open.open("s3://" + bucket + "/" + key, 'w', newline="",
                                        transport_params=dict(client=s3_client, ContentType=extra_args['ContentType'],
                                                              ServerSideEncryption=extra_args['ServerSideEncryption']))

output:
smart_open.utils - WARNING - ignoring unsupported keyword arguments: ['ContentType', 'ServerSideEncryption', 'client']

I also tried running:
s3_client = boto3.client("s3")
            file_path = smart_open.open("s3://" + bucket + "/" + key, 'w', newline="",
                                        transport_params=dict(client=s3_client))

and still got the error
smart_open.utils - WARNING - ignoring unsupported keyword arguments: ['client']

OK, I've worked out what the problem is. First and foremost, the docs were for an unreleased developer version, and you had 4.2.0 installed. I've since released 5.0.0 - if you install that, the behavior should be more like what you expected.
Second, you're passing the Content-Type parameter (and other parameters) incorrectly. You need to do something like this:
transport_params = {
  'client_kwargs': {
     'S3.Client.put_object': {
       'Content-Encoding': ...,
     },
  },
}

See the docs for more examples.

Thanks for all of your help. I was able to pass the parameters and have it run without warnings now.


Fragile localization

In some places - like here, some assumptions are made as to how sentences will be constructed. In English:
{person} added {label} {time ago}

In Dutch, this would be:
{person} heeft {label} {time ago} toegevoegd

Thing is - solving this is quite tricky. We're basically concatenating UIButtons and UILabels (that have text in them) instead of text itself. 🤔
Not sure if there would be actual plans localizing the app, but thought I'd create an issue for visibility anyway.

Ya, I've honestly cut some corners here.

Thing is - solving this is quite tricky.

Pretty much. Once (if) I take supporting more locales more seriously I'll def re-evaluate. Gonna be some time tho.

Think it would be a really fun one to try and figure out though!


FEAT: Support Paged Attention

Is your feature request related to a problem? Please describe
VLLM implements paged attention using Ray to significantly increase generation speed. We can implement paged attention without using Ray as a dependency.
This is a gif from VLLM's website demonstrating the generation process with paged attention:

#445


Different output from the BUILDING.md  when doing Demo1.sh

After I run through the release build in BUILDING.md for linux,
jlu@jlu-G551JM:~/Public/mcsema/mc-sema/tests$ ./demo1.sh
Using bin_descend to recover CFG
Disassembly not guided by outside facts.
Use :'../../build/mc-sema/bin_descend//bin_descend-p ' to feed information to guide the disassembly
low : 0 high : 5
low : 0 high : 5
Disassembly not guided by outside facts.
Use: -p ' to feed information to guide the disassembly
TT x86 : i386-unknown-unknown
Looking at Object File section: .text
Found symbol: .text in .text
Found symbol: filler in .text
Found symbol: start in .text
addDataEntryPoints: skipping non-data section: .text
We have 1 entry points
Calling getFunc on: 1
getFunc: Starting at 0x1
getFunc: toVisit size is: 1
Processing block: block_0x1
1:	addl	$1, %eax
4:	retl
getFunc: Function recovery complete for  func at 1
Looking up target...
Reading module ...
TT x86 : i386-unknown-unknown
Deserializing functions...
Creating module...
Setting target...
Done setting target
Adding external funcs...
Adding external data...
Adding internal data...
Adding entry points...
Returning modue...
Setting initial triples...
Looking at entry points...
Already have driver for: start
Getting LLVM module...
Converting to LLVM...
Inserted function: sub_1
Adding entry point: demo1_entry
Doing post analysis passes...
in : doPostAnalysis
registering passes
debugging this script\n
CC is clang
./demo1.sh: line 24: clang: command not found
./demo1.sh: line 25: ./demo_driver1.exe: No such file or directory
This is different from the the one in the BUILDING.md since the second line, what is going on

jlu@jlu-G551JM:~/Public/mcsema/mc-sema/tests$ clang
clang: error: no input files
In my terminal clang is installed and runnable.


Woodwork metadata cannot handle Series

For Featuretools' secondary time index and last time index, Woodwork tables need to be able to store a pandas, koalas, or dask series as a value in its metadata dictionary.
However, there are two issues with storing a Series this way:

WoodworkTableAccessor's table equality check does self.metadata != other.metadata which is not a valid way of comparing the equality of any series that might be in metadata
The schema property returns a deepcopy of the TableSchema, and Koalas raises an error, apparently, if you try and deepcopy a series like that: TypeError: cannot pickle '_thread.RLock' object

(these issues will be problems for both table and column metadata)
Below is a test that produces both of the above issues:
def test_series_in_metadata(sample_df):
    series = sample_df['id'].copy()

    sample_df.ww.init(table_metadata={'series': series})
    assert sample_df.ww.metadata['series'] is series

    assert sample_df.ww.schema == sample_df.ww._schema

I can think of 2 possible fixes:

We iterate through metadata. For each item in the dictionary, if the variable type is a Series, use the Series.equals function. I wonder if this is problematic for Koalas/Dask Series.

We don't support Series type in metadata.

On another note, can the secondary time index and last time index be stored as a column in the Woodwork DataFrame? We can just keep the column name in the metadata of the Woodwork DataFrame...

I'm not sure we want to support storage of Series or other arbitrary objects in the metadata in general, if we can avoid it. This seems like it could be a challenge from a serialization/deserialization perspective in addition to the equality and copying issues raised above.

So it seems like there's three potential places where Featuretools would want to put a series in the Woodwork metadata:

secondary time index - could potentially be a column on the DataFrame
last time index - could potentially be a column on the DataFrame
interesting values - cannot be a column on the DataFrame (but can be a list, potentially)

It seems like we have the ability on Featuretools' end to avoid storing a Series in the metadata, and we should probably take that opportunity, since I think I agree that we should have more restrictions around what can be in Woodwork metadata.
I guess the restrictions on what can be metadata are informed by its deepcopying, equality, and serialization ability. Not sure how to actually restrict that when setting the metadata, though. So maybe it's just a note we add near metadata in the docstrings.

I agree with you @tamargrey that we should avoid Featuretools storing Series on the metadata.
Created an issue to address this: https://github.com/alteryx/woodwork/issues/1022
Closing this issue now.


Change Mezzanine Form to Disallow Username Changes

Describe the feature you'd like and what it will do
The internal mezzanine form for the admin account should be altered to no longer allow username changes if possible, since doing so breaks the resource.
Why is this feature important?
This will be policy moving forward, that usernames cannot be changed.
I will work with Scott to see if this change is feasible.

@sblack-usu We said I'd make an issue for this and speak about it

It is a pretty simple update as we are already customizing the user admin form.  PR created.


Cycle 4 Funding: Community Engagement Follow-on work by OrgMycology

We've attached a proposal to create a follow-on for the work we've been doing with Astropy. We see some key areas we think we could be helpful going forward, and welcome conversation over the coming weeks to co-create some intitiatives under this outline proposal. We'd very much like to hear from the CoCo about priorities they might have from our community survey that they think we could potentially contribute to.

We'd also love to hear from community members who've read our Astropy Community Survey Report what they think should be key activities of the community could / should be based on their reading of the report.
We've tried to outline some things we think could get community management in front of more eyeballs in the community. I've also outlined a few things about easing contributors into their first contributions to Astropy (not necessarily code contributions). Would love to hear from community members about ways in which they would like to see more of this kind of work.
With our proposed work, we feel that skills maps can help ground some descriptions of community roles, and a few tangible workshops and activities can model for the broader community ways to help each other cross into new skills within the community.
We're quite flexible in scoping this proposal into a mix of supporting and key community actions that increase the cohesion and community contributions (beyond just software).

Please react to this comment to vote on this proposal (👍, 👎, or no reaction for +0)

Hi Jonah,
I'm writing on behalf of Astropy's Finance Committee regarding the outcome of your recent Funding Request.
We are sorry to report that your proposal could not be funded during this funding Cycle. We will be closing the FR as a result.
While the community vote was the primary driver of this, it is important to note that this likely does not reflect anything about you as a member of the Astropy Community. Rather, it reflects the specific balance of projects proposed this cycle, the available funds, and the priorities of this cycle’s funding sources relative to others.
We encourage you to read feedback in the thread above or other feedback you might have received via other means, and consider an FR for the next cycle with whatever modifications you think would help. You are also welcome to reach out to the Finance Committee for feedback if you would like.
Ana- on behalf of the Astropy Finance Committee


[REQ] Small warning when adding custom fonts via the app

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
AFAIK, adding a custom font with the app will overwrite all of the fonts with the selected font.
Tho the inconvenient is the font is the same one for the different versions such as bold, italic, semi-bold etc...
What i mean by that is if something needs bold, it may not be bold, if its in italic, it wont be in italic etc...
I suggest adding a small warning prompting users to either
A. Download a font from the mods forum of the server as it may have variantes of the font like Bold, Extra bold etc thus having maximum support
B. Download a variable font (which should adapt itself automatically)
C. (For experienced users ig) Download the font and it's variantes and then add the files manually
D.


Add mechanism to instruct test engine to throw error

Handles @CoryDanielson's request in #15

Expose throwError as a faux-effect that returns an object with a key @THROW and an error message
In the test engine, if we see a value that matches throwError we can instruct the generator to throw
This lets consumers explicitly define that they want the generator to error out in their mappings instead of writing a value that will cause an error indirectly (like in this unit test: https://github.com/DNAinfo/redux-saga-test-engine/blob/master/tests/index.js#L336)

Only thing left to do is merge master in and resolve the conflict caused by the ES5 build stuff. Specifically, we have to make sure throwError is exposed at the top level.

Just updated this PR per your feedback, Cory
Will merge once CI passes


[chip-test] chip_sw_flash_lc_escalate_en

Test point name
chip_sw_flash_lc_escalate_en
Host side component
No response
OpenTitanTool infrastructure implemented
No response
Contact person
@tjaychen @matutem
Checklist
Please fill out this checklist as items are completed. Link to PRs and issues as appropriate.

[ ] Check if existing test covers most or all of this testpoint (if so, either extend said test to cover all points, or skip the next 3 checkboxes)
[ ] Device-side (C) component developed
[ ] Bazel build rules developed
[ ] Host-side component developed
[ ] HJSON test plan updated with test name (so it shows up in the dashboard)
[ ] Test added to dvsim nightly regression (and passing at time of checking)

AIs from the last DV meeting for this test
[matute] Update this testplan to map with all_escalation test and explain how this is actually tested.

I vaguely remember we wanted to test this test as follows. @matutem please correct me if it's wrong.
When lc_esc happens in a block, we increment a counter in flash mem. But if this happen to flash, the counter won't be incremented, which indicates that the flash is locked up. After the chip is reseted, SW reads the counter back to check the value is expected.
I'm not sure if the all_escalation test already has this check. perhaps @matutem can confirm.

the thing is, once life cycle controller escalate, no one will be able to run any code out of flash.
The flash doesn't allow access which means there is no code execution unless you run the test out of rom.
I think matute changed the all escalate test to prove that escalation happens even if we cannot access any code, but I think what this test specifically wants is that we check flash controller cannot be accessed during escalation.
I think the best way to check that would probably be through a stub cpu, since that one won't be vulnerable to all the faults / exceptions that are going to happen.

Actually we don't need a new test for this, but just change the all_escalation_resets test to require the interrupt counter(s) not increment when the fault is for flash_ctrl. Otherwise the test currently checks that the alert is for the expected cause using alert_info dump.


Add script to generate simple architecture configs

Can be further customised if needed, submitting PR mainly for review

Will close this for the time being.


Reverse Proxy

Hello,
I set up ambar behind an haproxy to handle ssl termination. I tried to do it by using the local and external key for api and fe in the config.json but I couldn't get it to work that way.
Looking at the template it seems the local key is not used anywhere.
In the end I got it working by editing the docker-compose.yml file and setting the public hostname in
the fe and api environment and using my lan configuration for the external key in config.json.
Am I missing something ?
Regards

+1 for a fix... Thank ovv, found the same workaround. Adjust docker-compose.yml and set external host for webapi and fe

Hello, I'm having issues to make my ngnix proxy work with ssl/tls. Would you mind which part of the docker-compose.yml did you change exactly?
Thanks in advance


As a frontend developer, I want an endpoint that will store the playlist queue  (list of episodes) the user last had in the player.

Acceptance Criteria:

[ ] An endpoint is created to store the playlist queue for the user in the player.
[ ] The playlist queue data is securely stored and associated with the user.
[ ] Users can retrieve their last playlist queue by making a request to the endpoint.
[ ] The endpoint handles potential edge cases, such as empty or invalid playlist queue data.

Demo Steps:

Make a request to the endpoint to store a playlist queue for a specific user.
Verify that the playlist queue data is successfully stored.
Retrieve the last playlist queue for the same user and confirm it matches the stored data.
Test the endpoint with various scenarios, including empty or malformed playlist queue data.

Potential Risks:

[ ] Security vulnerabilities if the endpoint is not properly secured against unauthorized access.
[ ] Data integrity issues if the playlist queue is not accurately stored or retrieved.
[ ] Increased server load if there is a high demand for frequent playlist queue updates.
[ ] Inefficient data storage leading to slower response times.

Technical Notes:

[ ] Implement proper authentication mechanisms to secure the endpoint.
[ ] Consider data encryption for playlist queue storage to enhance security.

Playlist is still broken in main as of now, pushing this to next release

This is a cut feature, asked the frontend dev (radwan), and we will not be implementing this


Add fantasy-land canonical type references?

Canonical references to the described types are provided via https://github.com/fantasyland/fantasy-land/blob/master/index.js.
These can probably be added with something like this:
addMethod('map', ...);
Stream.prototype[fl/map] = Stream.prototype.map;
_[fl/map] = _.map;

The benefit of doing this would be to provide interoperability between other fantasy-land-implementing libraries (ramda,  fluture, zoom, crocks,  etc).
It looks like the existing types covered are:

fantasy-land/concat
fantasy-land/filter
fantasy-land/map
fantasy-land/of
fantasy-land/chain
fantasy-land/ap (provided by #643)

Also worth nothing:

fantasy-land/reduce conflicts with he current 2.x version _.reduce, but the ^3.0.0-beta.5 matches. I'm not sure how to handle this.
fantasy-land/traverse could be fulfilled by mixing some high-level functions if fantasy-land/reduce were fulfilled.
fantasy-land/alt could possibly be interpreted to be fulfilled by _.otherwise
fantasy-land/empty could be fulfilled simply by () => h.of(h.nil)

Would this be desirable?

Yes, we should do this.

fantasy-land/reduce conflicts with he current 2.x version _.reduce, but the ^3.0.0-beta.5 matches. I'm not sure how to handle this.

reduce in Highland doesn't match reduce in fantasy land, even though it's very close. The type signature for reduce in Highland is
reduce :: Highland a ~> ((b, a) -> b, b) -> Highland b

Essentially, we can do the reduce operation, but we can't unwrap the value, because it's produced asynchronously.

fantasy-land/empty could be fulfilled simply by () => h.of(h.nil)

I'd prefer using h([]) instead.
I think we can also have

fantasy-land/zero - Same as empty.
fantasy-land/chain - Same as flatMap.

You're right about reduce, I overlooked the final signature somehow.
empty makes sense to me. I incorrectly wrote the one I mentioned above here as well as in #643 (https://github.com/caolan/highland/pull/643#discussion_r228009364).
I'll look at opening a PR sometime soon.


Fundamental overrides in Node, Tank, DecayTank, etc.

This issue is set to discuss any needs for enabling overrides in fundamental nodes including Node, Tank, DecayTank, etc.

Do we need an issue for Node overrides? the only parameter is name which I think we don't allow to override

How to override decay, datum, initial_storage? Should these overrides be put into the Surface or the Tank, DecayTank?

OK it makes sense - I guess Tank overrides are the sensible solution to this

Do we want to handle initial_storage -> storage? If yes, how? I guess the storage cannot be a property because it is going to be updated at each timestep?
        # Set parameters
        self.capacity = capacity
        self.area = area
        self.datum = datum
        self.initial_storage = initial_storage

        WSIObj.__init__(self)  # Not sure why I do this rather than super()

        # TODO I don't think the outer if statement is needed
        if "initial_storage" in dir(self):
            if isinstance(self.initial_storage, dict):
                # Assume dict is VQIP describing storage
                self.storage = self.copy_vqip(self.initial_storage)
                self.storage_ = self.copy_vqip(
                    self.initial_storage
                )  # Lagged storage for mass balance
            else:
                # Assume number describes initial stroage
                self.storage = self.v_change_vqip(
                    self.empty_vqip(), self.initial_storage
                )
                self.storage_ = self.v_change_vqip(
                    self.empty_vqip(), self.initial_storage
                )  # Lagged storage for mass balance
        else:
            self.storage = self.empty_vqip()
            self.storage_ = self.empty_vqip()  # Lagged storage for mass balance

Well I think the main reason initial_storage was its own attribute was to enable saving of the model that reverts the config to its initial state.
I think it makes sense that we do not allow storage to be set in overrides - though could add a little catch that pings a message like "storage not override-able, please use initial_storage" or something.
I would suggest that we put this in a function:
            if isinstance(self.initial_storage, dict):
                # Assume dict is VQIP describing storage
                self.storage = self.copy_vqip(self.initial_storage)
                self.storage_ = self.copy_vqip(
                    self.initial_storage
                )  # Lagged storage for mass balance
            else:
                # Assume number describes initial stroage
                self.storage = self.v_change_vqip(
                    self.empty_vqip(), self.initial_storage
                )
                self.storage_ = self.v_change_vqip(
                    self.empty_vqip(), self.initial_storage
                )  # Lagged storage for mass balance

that is called by apply_overrides and the __init__?
There may be a more elegant solution that makes use of property - but I think for now let's focus on making overrides work properly, if there are any further clever ideas you can always make them a new issue

fixed by #91


Custom switch / radio / checkbox / inputs improvements

Based on Adrian Roselli's posts "under-engineered toggles", "under-engineered custom radios buttons and checkboxen" and "under-engineered text-boxen".

[ ] WHCM in IE11 and ChromiEdge
[ ] dark color scheme
[x] reduced motion
[x] RTL mode
[x] print
[x] etc.

Bootstrap made great improvements in v5. This basically leaves us with WHCM (#510) and color-scheme (#511)—so I'm closing this.


Unable to find IoT Hub:  {name} in current subscription with Service Principal login in az iot hub device-identity create

Describe the bug
Running following command with logged in SPN, fails with error
Unable to find IoT Hub: ssmiothubdapr in current subscription <subid>
az iot hub device-identity create -n ssmiothubdapr -d certification-test-device

Please note this works as expected with user account login where a user has owner access on subscription.
This issue has been observer  with az login --service-principal, SPN in scope has IoT Hub Data Contributor
To Reproduce

Create a SPN

Create a IOT HUB

Assign IoT Hub Data Contributor access role to SPN on the scope IoT hub.

Login with SPN
az login --service-principal -u $AzureCertificationServicePrincipalClientId -p $AzureCertificationServicePrincipalClientSecret --tenant $AzureCertificationTenantId

Try to run commands to operate on IoT hub like creating a device or device simulate
` az iot hub device-identity create -n ${AzureIotHubName} -d ${IOT_HUB_TEST_DEVICE_NAME}`

`az iot device simulate -n ${AzureIotHubName} -d ${IOT_HUB_TEST_DEVICE_NAME} --data 'testmessageForEventHubCertificationTest' --msg-count 2 --msg-interval 1 --protocol http --properties "iothub-userid=dapr-user-id;iothub-messageid=dapr-message-id"`

Expected behavior
Command should have been successful.
Environment Summary
Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.29, Ubuntu 20.04.1 LTS
Python 3.8.12
Installer: DEB

azure-cli 2.35.0

Extensions:
application-insights 0.1.15
azure-iot 0.14.0
interactive 0.4.5

Dependencies:
msal 1.17.0
azure-mgmt-resource 20.0.0

Additional Context

@surenderssm The IoT Hub Data Contributor role provides access to data plane operations but it actually requires resource level permissions to manage it. You need to provide it permissions at the resource scope as documented, which is what you have done.
Based on your requirement, you could create a custom role for your SPN so that it may only access specific sub-resources to limit access.
Hope that clarifies the behavior. Since there is no change required here, closing this issue.


adding a macrotask quiz question in javascript

Summary of changes

adding a macrotask quiz question in javascript
Checklist

[x] I have read and followed the contribution guidelines.
[x] I have read through the Code of Conduct and agree to abide by the rules.
[x] This PR is for one of the available issues and is not a PR for an issue already assigned to someone else.
[x] My PR title has a short descriptive name so the maintainers can get an idea of what the PR is about.
[x] I have provided a summary of my changes.

closes #XXXXX

thank you @jdwilkin4 ! Just committed all your changes :)


Add an example showing live air traffic from the OpenSky Network.

This example is hidden, as we probably need to inform the OpenSky Network if we make it obviously public.
This has a lot of different features:

It uses a web worker to collect data
Drawing color scales is optimized by overriding style.get and using a   LUT rather than a d3 scale.
It shows off scaling to a large number of vertices (given time).
It uses width, color, and opacity to indicate different properties.
It can show live or static data.

This is an example I mostly wrote some time ago.  I'm making a PR now to make it easier to share.


Display partition names consistently in log messages

With CAF 0.18, actor names must be constant strings. The active and passive partition carry their human-readable name in the variable self->state.name already.
In active_partition.cpp and passive_partition.cpp we currently have a lot of log messages using the actor name rather than the human-readable partition name. We need to change them like this:
  VAST_DEBUG("{} persists partition with a total size of {} bytes",
-            *self, fbchunk->size());
+            self->state.name, fbchunk->size());

:100: Definition of Done
All log messages created by the active/passive partition actors use the human-readable partition name.

I'm closing this as stale; our experiment of using GitHub Issues has never really picked up, and our plans for this have changed since.


Interactive API beta

A new Python API was introduced. It allows defining Federated Learning tasks, data loaders, and models in an interactive environment such as Jupyter Notebook taking advantage of the introduced interactive API component.
Defined objects are then serialized and may be transferred to a remote node.

I have read the CLA Document and I hereby sign the CLA

@igor-davidyuk could you squash commits which are from Igor Davidyuk user, since CLA check failed. Maybe even squash everything into single commit will help to resolve this.


Retry requests in case of network failure

While doing large bulk lookups internet connectivity may be lost. We should do an exponential backoff until connectivity is restored.

@jonathan-kosgei Should it be done in API or in CLI?

Solved


 would not show

Hi, while playing around with SU, I ran into a really weird thing, when setting icon class to "man" or "woman", the icon would not show. But it's ok for other icons like "male/female" .etc. I'm using the latest commit, 219fedaaa3a12761a13d5f98a4b962848d63cc2d.
Do you guys have any clues ? Would really appreciate your help :)

I can't seem to reproduce your problem on commit 219feda; all of the mentioned icons show up for me in Chromium 40.0.2214.111 Ubuntu 14.04. As jsfiddle + externally hosted webfonts don't seem to be on the best of terms, could you maybe upload files that show this bug happening?

Women rarely show up when you really need them. Did this help? :)

Can't reproduce your issue. Can you create a test case?


Added a section for the specific channel's bots

Because the channel might have more than one bot

Well then they can just add another one. You only need one to prove the point.


getWaka.com isn't updating any more

My current installed version of the app is from getwaka.com and is only on 2.2.0. However, the latest version of the new link, waka.app is on 2.3.0. Would I have to remove and install the new app (and re add all my bus stops) in order to get the new updates?

Waka uses Service Workers, so you'll need to close all tabs and the reopen in order to get the new update.

issue solved, it just took a bit of time


fix(nvidia): Enable persistenced service

Add extra option to use /var/tmp as the tmp storage dir

This looks good.

Merging, broken builds are an upstream churn issue


JDBC prepared statement returns NullPointerException

Expected behavior and actual behavior
Calling a prepared statement via jdbc interface returns NullPointerException
Exception in thread "main" java.lang.NullPointerException
at com.orientechnologies.orient.jdbc.OrientJdbcResultSetMetaData.getColumnType(OrientJdbcResultSetMetaData.java:192)
at TestOrientdb.main(TestOrientdb.java:42)
A prepared statement should work without problems via jdbc interface.
Steps to reproduce the problem
Using the default database:
      OrientJdbcConnection conn = (OrientJdbcConnection) DriverManager.getConnection("jdbc:orient:" + dbUrl, info);

      //create and execute statement
      String stmtStr = "SELECT FROM V WHERE song_type like ?";

      PreparedStatement stmt = conn.prepareStatement(stmtStr);
      stmt.setString(1, "original");

      ResultSet rs = stmt.executeQuery();

      int type = rs.getMetaData().getColumnType(1);

Important Questions
Runninng Mode

[ ] Embedded, using PLOCAL access mode
[ ] Embedded, using MEMORY access mode
[ X] Remote

Misc

[ ] I have a distributed setup with multiple servers. How many?
[ ] I'm using the Enterprise Edition

OrientDB Version

[ ] v2.0.x - Please specify last number:
[ ] v2.1.x - Please specify last number:
[X ] v2.2.x - Please specify last number: 0

Operating System

[ ] Linux
[X ] MacOSX
[ ] Windows
[ ] Other Unix
[ ] Other, name?

Java Version

[ ] 6
[ ] 7
[ X] 8

Try this:
String stmtStr = "SELECT FROM V WHERE song_type like '?' ";

I tried statement String stmtStr = "SELECT FROM V WHERE song_type like ?"; doesn't work too.
stmt.setString(0, "'original'");
For this statement it returns java.sql.SQLException: No current record
I also tried with an int an it doesn't work too:
String stmtStr = "SELECT FROM V WHERE performances = ?";
PreparedStatement stmt = conn.prepareStatement(stmtStr);
stmt.setInt(0, 1);
For this statement it returns a NullPointerException.

Did use quotes?
SELECT FROM V WHERE song_type like '?'

Your code works fine if you wrap the ? with sigle quotes, as stated on previous comment:
SELECT FROM V WHERE song_type like '?'

You're querying the GratefulDeadConcerts,  that is mainly schema less, so the line
 int type = rs.getMetaData().getColumnType(1);

can't get any result because, internally, it relies on db metadata.

But the same happens if I query the VehicleHistoryGraph db. I have a question: If  I have a query doesn't return any result, why getColumnCount() throws an exception? Is it not possible to read the meta data another way?
I have this problem by using BIRT and orientdb via jdbc driver. In BIRT you can create some filter parameters which are applied as prepared statements on the data set. Since this parameters are set dynamically by user BIRT cannot create a schema at the time of data set definition because of SqlException. With the sqlite db this use case works without problems.

which version please?

Orientdb version 2.2.0
BIRT version 4.5.0

The implementation respect the javadoc form JDBC specs:
  * @return the description of a ResultSet object's columns or
     *         null if the driver cannot return a
     *         ResultSetMetaData object

I this case the ResultSet will be null, and so the metadata. Note that even if a PreparedStatement is used, The driver can't precompute the ResultSet metadata

Which method do you refer to with the last comment? ResultSetMetaData.getColumnCount()?

No, sorry, is the javadoc from ResutlSet.getMetadata:
 /**
     * Retrieves the  number, types and properties of
     * this ResultSet object's columns.
     *
     * @return the description of this ResultSet object's columns
     * @exception SQLException if a database access error occurs or this method is
     *            called on a closed result set
     */
    ResultSetMetaData getMetaData() throws SQLException;

The problem is that at the JDBC level we don't have all the info about the documents retrieved from Orient. And even if you work with plain OrientDB API what you get  as a query result is a list od ODocuments, nothing more. On 3.0 we are working  to overcome this,  providing more metadata about the documents set returned by the database.

Check if you have included the mysql-jdbc-connector or the connector to your database library into your project.


Local Jekyll rendering incorrectly

#Bug
Local server rendering incorrectly.
It can be noted as the local server address have an extra /. I am not sure if I should call it a bug, since it renders correctly when I push to GitHub, but if I want to check from my local server, I have to remove the baseURL /.
Solution
Remove the ending /
_config.yml
sidebars: [home_sidebar]
permalink: pretty
baseurl: /

to
sidebars: [home_sidebar]
permalink: pretty
baseurl:

Local server before removing /

Fixed by #130


Accessibility

Accessibility
User Story
AS A marketing agency
I WANT a codebase that follows accessibility standards
SO THAT our own site is optimized for search engines
Acceptance Criteria
GIVEN a webpage meets accessibility standards
WHEN I view the icon and images elements
THEN I find accessible alt attributes

Closed in PR https://github.com/aripandini/module-1-challenge/pull/7


you might be interested in sans forgetica

Hi,
Just heard about your project in the logseqweekly newsletter, I thought you might be interested in Sans Forgetica, it's a font that's supposed to help retention : https://en.wikipedia.org/wiki/Sans_forgetica
Maybe you want to create an addon that forces this font in the flashcard mode ;) ? I don't need it but that's just an idea.
Have a nice day and thanks for all these addons!

It is not really supposed to help retention. If you read https://en.wikipedia.org/wiki/Sans_forgetica#Evidence
https://www.sciencedaily.com/releases/2020/05/200528115754.htm


Add C412 rule to complain about list comprehension on rhs of 'in'

This is a proposal for a new checker.
y in [f(x) for x in foo] can be rewritten with generator expression like y in (f(x) for x in foo).
Allocation of the whole list is unnecessary.
How would you like it?

Do you have any benchmarking details?

The generator version can shortcut if there is any match.
$ time python3 -c "5000000 in (x for x in range(10000000))"
python3 -c "5000000 in (x for x in range(10000000))"  0.56s user 0.01s system 98% cpu 0.579 total
$ time python3 -c "5000000 in [x for x in range(10000000)]"
python3 -c "5000000 in [x for x in range(10000000)]"  0.80s user 0.24s system 98% cpu 1.054 total

Thank you very much! Released in version 2.2.0! https://pypi.org/project/flake8-comprehensions/


Floating Panel: Can we get the dimensions in order to set the content insets on the map view?

Is there a way to get the floating panel's location and size so that we can set the content insets accordingly on the mapView? The floating panel resizes and changes location based on device size and orientation. But choosing something like zooming to a feature will not zoom to the right location:

In the image above, zooming to the trace results should center the results in the un-obscured part of the mapview. That could happen if we had a way to get the dimensions of the floating panel.

Related / potential duplicate of #299


CSS Class name

Whitelist css class names for date picker to prevent tree shaking
<DatePicker
          value={currentData ? (JSON.parse(currentData.Date) as Day) : null}
          onChange={(day) => {
            day && dispatch(setDate(JSON.stringify(day)));
          }}
          inputPlaceholder="Select a day"
          inputClassName="appearance-none block w-full bg-gray-200 text-gray-700 border rounded py-3 px-4 mb-3 leading-tight focus:outline-none focus:bg-white"
        />

Closed by: https://github.com/eastlakehs/community-service-tracker/pull/65


Misbehaviour.csv should have abbreviations for every Misbehaviour

The field 'abbrev' in Misbehaviour.csv has no significance in the domain model as used by system-modeller. However, it can be useful for development of other tools to extract and display information from a system model exported from system-modeller after validation and risk calculation.
For example, one can extract and display threat graphs, in which Misbehaviour Sets (threat effects) are shown as a node in the graph. The URI of a Misbehaviour Set is not human readable as it contains a hash of the associated asset URI, which to a human is not related to any specific asset. Instead, one must construct a label for the node from the Misbehaviour type and asset label. But this becomes quite a long-winded phrase, especially if the Misbehaviour type takes the form 'Loss of TWA', where TWA is the associated trustworthiness attribute.
It is helpful if an abbreviation can be used, but these have not been included for every Misbehaviour added to the network domain model since version 4x. The missing entries should now be added, so shorter forms can be created as needed for every type of Misbehaviour.
Note that abbreviations do not need to be unique. It is OK to use the same abbreviation for Misbehaviours that apply to different assets. For example, the abbreviation 'Auth' can be used for Loss of Authenticity (in Data and related assets), and for network spoofing (in host-subnet interfaces) without causing any issues.

Addressed in branch 65.


Hope incorporate DALI

It would be perfect if you incorporate DALI !!
https://github.com/NVIDIA/DALI
The NVIDIA Data Loading Library (DALI) is a library for data loading and pre-processing to accelerate deep learning applications. It provides a collection of highly optimized building blocks for loading and processing image, video and audio data. It can be used as a portable drop-in replacement for built in data loaders and data iterators in popular deep learning frameworks.

I will look into this. At a glance, this may be better in a separate library for deep learning acceleration, but I am not too familiar with DALI. The install is via pip, so I am not sure how it'll interact with the RAPIDS conda dependencies.

yes, perhaps Dali would be better in a separate library


patientBirthDatePropertyName marked as deprecated but still required for SystemFunctionResolver

Some time ago, https://github.com/cqframework/clinical_quality_language/pull/439/commits/7b8f43536555e7b75dc40bfd8eb959617382a44f marked patientBirthDatePropertyName as deprecated within the modelinfo schema.
As such, i would expect to be able to omit it from the model info header if i define the patient context in my model info:
    <ns4:contextInfo name="Patient" keyElement="id" birthDateElement="birthDatetime">
        <ns4:contextType modelName="Example" name="Patient"/>
    </ns4:contextInfo>

Compiled against cql like this:
library example_1

using Example

context Patient

define "patients":
    AgeInYears() > 18

I would expect success.
However i get this instead
Error:[8:5, 8:16] Cannot invoke "String.indexOf(int)" because "birthDateProperty" is null

The problem seems to lie in this snippet here: https://github.com/cqframework/clinical_quality_language/blob/dfafdb933f23ab54ce750c4ed1d6d1bf910e9bed/Src/java/cql-to-elm/src/main/java/org/cqframework/cql/cql2elm/SystemFunctionResolver.java#L414-L415
This code is still looking specifically at the information in the modelinfo header.
The "simple" fix seems like it would be to call getContextInfo() and retrieve the birthDateElement from one of the contexts returned. That would require it to be context aware to work properly, i think. Which is not information that i see readily available to the class right now.
Looking at the cql spec here: https://cql.hl7.org/07-physicalrepresentation.html
i do see a clause that seems to describe an alternate behavior to what is happening here, under "Context Information":

For patient contexts, Patient Birth Date information must be supplied as well to allow the CQL-to-ELM translator to render references to patient-age-related functions (AgeInYears, AgeInYearsAt, etc.) into the non-patient-aware age-related functions in ELM (CalculateAgeInYears, CalculateAgeInYearsAt, etc.). This information is not required, but if it is not present, references to patient-age-related functions will be passed directly through to ELM as FunctionRefs.

I'm fairly green to the project, i fully admit i could be missing something, but i couldnt find any reference to this elsewhere so im logging this for at least a discussion/explanation of it.

I think your assessment is correct. The FunctionRef would need to have context information attached to it. That information is available in the compiler at the point the FunctionRef is created, but it's not on that class. That said, I'm going to noodle on this a bit. In cases where the FunctionRef points to a function that's not system defined, the context is available on the corresponding FunctionDef. So this is something that impacts system-defined functions only. There also may be some implication here for cross-context function calls I need to think through.


Support ES modules in Node 14 and 12

New feature description
This is a somewhat big PR that, as you can see by the number of commits, does quite a number of things, all in service of being able to load our modules as ES modules in Node (and, incidentally, to explicitly define which modules can be imported in Webpack 5 as well).
Specifically:

CI checks now run in Node 14 too.
When we import CommonJS modules (which all our dependencies currently still are, in Node), we no longer use named imports, which are not supported by CommonJS. Except for...
N3, which annoying exports ES modules with named imports to browsers, but CommonJS modules with only a default export for Node. This means that import { Parser } from "n3" would break in Node, but import n3 from "n3" would break in Webpack. I worked around that via dynamic import - a comment in the code and the associated commit message explain this in more detail.
Added a fourth build output (after CommonJS modules, .js ES modules for bundlers, and a UMD build for people wanting to include a single script): .mjs ES modules for Node.
Add an export map detailing which submodules we export. I've kept the top-level export to avoid introducing a breaking change for people upgrading their Node/Webpack versions. (And since the filenames matter for this, I renamed the file containing File-related API's to file.ts.)
I added minimal projects that import functions from solid-client in different environments. After publishing a preview release, that release is added to those projects in CI and then run/built, to see if that breaks. I hope that they cover the most common usages.
I added the package-check to check for best practices, such as publishing ES modules.

Checklist

[x] All acceptance criteria are met.
[x] Relevant documentation, if any, has been written/updated.
[x] The changelog has been updated, if applicable.
[x] New functions/types have been exported in index.ts, if applicable.
[x] Commits in this PR are minimal and have descriptive commit messages.

Great. I also added bad8e5007cc4b1b49ed4718c50cfcd39b0f7619c, which moves everything that's prefixed with internal_ into its own modules (suffixed .internal.ts), so that people on Node 12+ and Webpack 5 will not be able to import them. (And so we can automatically exclude them from our docs, so this would've been useful long ago.)


Correction for raw affiliation LIP, CNRS UMR 5668, INRIA, ENS de Lyon, Universit Claude Bernard Lyon 1, France

Correction needed for raw affiliation LIP, CNRS UMR 5668, INRIA, ENS de Lyon, Universit Claude Bernard Lyon 1, France
raw_affiliation_name: LIP, CNRS UMR 5668, INRIA, ENS de Lyon, Universit Claude Bernard Lyon 1, France
new_rors: 029brtt94;02kvxyf05;04zmssz18;02feahw73;04msnz457
previous_rors: 029brtt94;02kvxyf05;04zmssz18;02feahw73
works_examples: W1538843523
contact: 27ac43c5bc8a6a6ab3c40fa16b2180df:d46c96c6e6fa10486eb3675aa7ec @ ens-lyon.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Dev

Codecov Report

Merging #45 (70ad1bf) into main (53ec70c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   61.79%   61.79%
=======================================
  Files          13       13
  Lines          89       89
=======================================
  Hits           55       55
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ec70c...70ad1bf. Read the comment docs.


Fix extra skeleton hands in mirror

Fixes https://github.com/Unvanquished/Unvanquished/issues/603.

Thanks for looking for this!
It removes one skeleton out of three, but maybe that's not the right one? Actually it seems to have removed the one from the first person model, not the one from the wonky “third-person first person model”.
cg_mirrorgun off:

cg_mirrorgun on:

With this patch the skeleton now looks the same viewed through a mirror or directly. I couldn't tell you what a skeleton is supposed to look like, but it looks the same with or without mirrors, so if there is a bug it's not related to mirrors.

cg_mirrorgun is only referenced from CG_AddViewWeapon, the function that draws the first-person weapon. So it's a cgame bug that it is not applied to the 3rd-person weapon.


Add app zone util

Set up:

Create a Zone entity
Run this script on the zone entity
https://hifi-content.s3.amazonaws.com/robin/dev/utils/AddAppZone.js
Ensure you have rez permissions in your domain (the fingerPaint app requires it)

Testing Plan:

Remove fingerPaint app from your tablet. This script uses it.
Enter zone entity, the fingerPaint app should now appear on your tablet
Feel free to draw with it
Leave zone entity, the fingerPaint app should be removed from the tablet and unload itself.

Other tests:

Teleport in and out of the zone entity
After entering the zone, use Goto to change your domain. The fingerPaint app should be removed.
Enter zone, delete fingerPaint app from your "running scripts...". Leave the zone. Enter the zone again, and the fingerPaint app should be loaded again.

@misslivirose removed the sit script from PR.

Testing.

Testing complete:
Testing Plan:
Remove fingerPaint app from your tablet. This script uses it. Check
Enter zone entity, the fingerPaint app should now appear on your tablet Check
Feel free to draw with it Check
Leave zone entity, the fingerPaint app should be removed from the tablet and unload itself. Check
Other tests:
Teleport in and out of the zone entity Check
After entering the zone, use Goto to change your domain. The fingerPaint app should be removed. Check
Enter zone, delete fingerPaint app from your "running scripts...". Leave the zone. Enter the zone again, and the fingerPaint app should be loaded again. Check
Notes: I noticed that the app screen stays open when leaving when on desktop- and same in HMD but on the tablet, the app must be exited, but functionality doesn't work as intended leaving the zone so I think this is fine.
Pass :)


Modify mention user and mention report extras field names in ExpensiMark htmlToText and htmlToMarkdown rules

This PR changes field name of extras in ExpensiMark to prevent type check fails.
Modify mention user and mention report extras field names in ExpensiMark htmlToText and htmlToMarkdown rules
Fixed Issues
$ https://github.com/Expensify/App/issues/40928
Tests

What unit/integration tests cover your change?
I have tested it on my other PR, thread report from report action that contains mention room and mention user should display report name properly in header report and in LHN.

QA

What does QA need to do to validate your changes?
N/A

What areas to they need to test for regressions?
N/A

I have read the CLA Document and I hereby sign the CLA

@mollfpr The failling tests are because I didn't changes the fields in the test files yet, I am sorry. Should be fine now...


Add GitHub Actions

Add GitHub Actions
A while ago we had CI/CD integration with Travis CI to run the application tests and make sure everything was ok. But, there was a change in the management of Travis CI himself, which forced us to pay for the service. This made us give up using it and now we will opt for GitHub Actions. If you have any suggestions or want to help, we're open for conversations here.

GitHub Actions Already Available!
Today we finalized our GitHub Actions and it is now available to help us with development.


Subscribing to events with many parameters is a tedious job

If I subscibe to the event OnBeforeFormatAddress on Codeunit Format Address I get to type 20 parameters manually (of which 2 needs to include var).
In C/AL, these are autogenerated when I chose which event to subscribe to.
Is there any way to autogenerate this?
The way I'm currently doing it, is by going to definition of the event, but in the definition, var is not listed, so I have to remember which of the 20 parameters that are var

This is addressed in the upcoming update. Please see #149 for more details

Cool stuff, I searched but couldn't find anything.

#149 only applies to the event subscriber, not the procedure itself, right?
The key thing here is what happens when in C/AL you accepted to overwrite the signature:

Can we expect something simular in AL?


adding 198-House-Robber.c

File(s) Modified: 198-House-Robber.c
Language(s) Used: C
Submission URL: _https://leetcode.com/submissions/detail/781922670/_

Thanks, @PritomKarmokar!


Empty popup behavior on Linux changed in 11.2.0

Describe the bug
<Popup Name="MyPopup">
    <Panel Background="LightBlue" />
</Popup>

This Popup shows nothing in Avalonia version < 11.2.0 (for example, 11.1.5).
It shows a 300x200 rectangle in Avalonia version >= 11.2.0. It seems to always at the top left of the screen regardless of PlacementTarget.

To Reproduce
https://github.com/Genteure/avalonia-linux-empty-popup
Or if the repository is deleted in the future:

Repro steps
Run dotnet new avalonia.app (Avalonia.Templates version <IP_ADDRESS> but this shouldn't matter too much)
<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFrameworks>net8.0;net9.0</TargetFrameworks>
    <Nullable>enable</Nullable>
    <BuiltInComInteropSupport>true</BuiltInComInteropSupport>
    <ApplicationManifest>app.manifest</ApplicationManifest>
    <AvaloniaUseCompiledBindingsByDefault>true</AvaloniaUseCompiledBindingsByDefault>
  </PropertyGroup>

  <PropertyGroup>
    <AvaloniaVersion Condition="'$(AvaloniaVersion)' == ''">11.2.0</AvaloniaVersion>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Avalonia" Version="$(AvaloniaVersion)" />
    <PackageReference Include="Avalonia.Desktop" Version="$(AvaloniaVersion)" />
    <PackageReference Include="Avalonia.Themes.Fluent" Version="$(AvaloniaVersion)" />
    <PackageReference Include="Avalonia.Fonts.Inter" Version="$(AvaloniaVersion)" />
    <!--Condition below is needed to remove Avalonia.Diagnostics package from build output in Release configuration.-->
    <PackageReference Include="Avalonia.Diagnostics" Version="$(AvaloniaVersion)">
      <IncludeAssets Condition="'$(Configuration)' != 'Debug'">None</IncludeAssets>
      <PrivateAssets Condition="'$(Configuration)' != 'Debug'">All</PrivateAssets>
    </PackageReference>
  </ItemGroup>
</Project>

<Window ......>
    <StackPanel Margin="5">
        <TextBlock Name="RuntimeInfo" />
        <Button Click="TogglePopup" Content="Toggle Popup" />
        <TextBlock Name="PopupIsOpenStatus" />
        <Popup Name="MyPopup">
            <Panel Background="LightBlue" />
        </Popup>
    </StackPanel>
</Window>

public partial class MainWindow : Window
{
    public MainWindow()
    {
        InitializeComponent();

        var currentDotnetVersion = Environment.Version;
        var currentAvaloniaVersion = typeof(Button).Assembly.GetName().Version;
        RuntimeInfo.Text = $"Running on .NET {currentDotnetVersion} and Avalonia {currentAvaloniaVersion}";
    }

    private void TogglePopup(object sender, RoutedEventArgs e)
    {
        MyPopup.IsOpen ^= true;

        var panel = (Panel)MyPopup.Child!;
        PopupIsOpenStatus.Text = $"Popup is currently {(MyPopup.IsOpen ? "open" : "closed")}\nPopup.PlacementTarget: {MyPopup.PlacementTarget}\n" +
            $"\nHeight: {panel.Height}\nWidth: {panel.Width}" +
            $"\nDesiredSize: {panel.DesiredSize}\nBounds: {panel.Bounds}";
    }
}

dotnet run -f net8.0 -p:AvaloniaVersion=11.2.0
dotnet run -f net8.0 -p:AvaloniaVersion=11.1.5

Expected behavior
I have not tested this in other OS but the behavior should match.
Avalonia version
11.2.0
OS
Linux
Additional context
https://github.com/amwx/FluentAvalonia/issues/634
300, 200 seems to be coming from Avalonia.X11/X11Window.cs.
PopupRoot got two commits in 11.2.0: 1cfa82 and b27228.

I've heard this also happens on macOS but the popup window size is a lot bigger. I don't own any Apple devices so I can't test myself.


Number is not compatible with Int or Float in engine-q

use nu_engine::CallExt;

use nu_protocol::{
    ast::Call,
    engine::{Command, EngineState, Stack},
    Category, IntoPipelineData, PipelineData, ShellError, Signature, SyntaxShape, Value,
};

#[derive(Clone)]
pub struct Foo;

impl Command for Foo {
    fn name(&self) -> &str {
        "foo"
    }

    fn signature(&self) -> nu_protocol::Signature {
        Signature::build("foo")
            .rest("foo", SyntaxShape::Number, "foo")
            .category(Category::Generators)
    }

    fn usage(&self) -> &str {
        "foo {rest}"
    }

    fn run(
        &self,
        engine_state: &EngineState,
        stack: &mut Stack,
        call: &Call,
        _input: PipelineData,
    ) -> Result<PipelineData, ShellError> {
        let span = call.head;

        let rest: Vec<Value> = call.rest(engine_state, stack, 0)?;

        Ok(Value::List { vals: rest, span }.into_pipeline_data())
    }
}

I think you have to match on Value after calling it a Number. See round.rs for an example.

This looks like a typechecker bug. I added the type coercion to the type checker and can get further with the examples I tried:
https://github.com/nushell/engine-q/pull/679


chore: add Commitizen

This PR follows Commitizen's documentation to install and add prepare commit message hook to trigger Commitizen command and also added a README section!
From now on when we add a new commit, Commitizen will walk you through a set of questions to properly prepare the right commit message that follows Semantic Versioning 🙆♂
NOTE: If you just want to make a quick commit, you can ^ + C to escape Commitizen and use your existing commit message too!

Thanks so much for the great feedback, @mdjmoore 🙏 ! Somehow I thought Commitizen would get automatically installed when people run npm i from now on lol But I think I need to add commitizen to our package.json first 😂
Will do that now, so people don't need to explicitly install Commitizen globally!

Just updated the PR and will auto merge! Thanks again!