path accepts only \ and not /

Description
When I use "/" instead of "\" in the path input, the folder name shows differently on the tab header and the folder icon doesn't appear. But I can access the folder, which seams kind of odd.
Example:

Path => C:\Users\User\Desktop\Path/To/Folder
Tab title => Path/To/Folder (without icon)

I also tried to use drag & drop with winrar (from Files to Winrar) and it didn't work until I changed all '/' in the path to '\'
I haven't tried to go to a path with '/' in the middle of it, just at the end of the path like shown in the example
Steps To Reproduce

Open Files
Enter a path manually with both '\' and '/'

Expected behavior

Tab title shows the folder name only with its icon
Drag & drop works properly

Files Version
Version: <IP_ADDRESS> OS Version: 10.0.19044.1706
Windows Version
Windows 10 Pro 21H2 19044.1706 + Windows Feature Experience Pack 120.2212.3030.0
Relevant Assets/Logs
debug.log
debug_fulltrust.log

This issue should be resolved with #9229.


Exception Alert for Social.Messaging.MessageRecipient

Description of bug
Since upgrade to DNN 9.5.0 I've noticed a new error in the admin log.
Steps to reproduce
Not clear at the moment. I think it's when a user archives messages in Message Center.
Screenshots

Error information
From Log File:
2020-03-11 00:29:32,742 [generic262][Thread:57][ERROR] DotNetNuke.Services.Exceptions.Exceptions - System.IndexOutOfRangeException: Archived
at System.Data.ProviderBase.FieldNameLookup.GetOrdinal(String fieldName)
at System.Data.SqlClient.SqlDataReader.GetOrdinal(String name)
at System.Data.SqlClient.SqlDataReader.get_Item(String name)
at DotNetNuke.Services.Social.Messaging.MessageRecipient.Fill(IDataReader dr)
at DotNetNuke.Common.Utilities.CBO.FillObjectFromReader(Object objObject, IDataReader dr)
2020-03-11 10:15:49,658 [generic262][Thread:12][ERROR] DotNetNuke.Services.Exceptions.Exceptions - System.IndexOutOfRangeException: Archived
at System.Data.ProviderBase.FieldNameLookup.GetOrdinal(String fieldName)
at System.Data.SqlClient.SqlDataReader.GetOrdinal(String name)
at System.Data.SqlClient.SqlDataReader.get_Item(String name)
at DotNetNuke.Services.Social.Messaging.MessageRecipient.Fill(IDataReader dr)
at DotNetNuke.Common.Utilities.CBO.FillObjectFromReader(Object objObject, IDataReader dr)
Affected version
9.5.0 is all I have to test with at the moment.

[ ] 10.0.0 alpha build
[ ]  9.5.1 alpha build
[X]  9.5.0 latest supported release
[ ]  9.4.4

Affected browser
N/A

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 11
[ ] Microsoft Edge (Classic)
[ ] Microsoft Edge Chromium

What version did you upgrade from?

9.4.4

Same here after upgrading from DNN 8.0.4 to 9.8.1. Please reopen!

The error messages stopped to appear in the logs after moving some (or all) message recipients into archive:
update dbo.CoreMessaging_MessageRecipients set Archived = 1 where Archived = 0

Still have no idea what would be causing this.

Wonder if this is due to messages not archived possibly from users that may have been deleted.  IE: Recipient received a message from sender. Later the  sender or recipient is deleted. The non delete sender or recipient later archives the message.
On a site the mimics my production I ran a "select * from dbo.CoreMessagingRecipents". The list contains UserID's that when looking at the limited number of users on this site don't match except for a 1 or 2.
UserIDs.pdf is from running "select UserID from users"
Query 1.pdf
UserIDs.pdf
I tried creating this on a local test/dev site (DNNdev.me) running 9.8.1 with symbols and was unable to duplicate it. Of course kind of hard to recreate if the condition is not known.
On my production site I only seen it once in a while. Messaging is not widely used on it.
If the above is of any significance I can run the same on my production site to see if the same correlation between messages and userIDs.

I've checked dbo.CoreMessaging_MessageRecipients for deleted users, but there are none:
select count(*) from dbo.CoreMessaging_MessageRecipients where UserID is not in (select UserID from dbo.Users)

Well, That might rule that theory out. Just for info reasons if what my environments look like.
FYI: I think there is an error in your SQL "is not in"
select count(*) from dbo.CoreMessaging_MessageRecipients where UserID not in (select UserID from dbo.Users)
Test site the Mimics production: 13
Production: 542
select count(*) from dbo.CoreMessaging_MessageRecipients where CreatedByUserID not in (select UserID from dbo.Users)
Test site the Mimics production: 13
Production: 499
Looking at my production site with users that have been deleted over the years. Not sure of the full impact of this, but maybe this is something that should be looked into. Does this pose any issues with the old orphaned data points? Seems kind of concerning that there doesn't appear to be any cleanup or purging of data. I would think if user is deleted the archived or stored messages references should be purged.
Considering I only have 1004 messages in the list. Oldest one being from 2012.
select count(*) from dbo.CoreMessaging_MessageRecipients

FYI: I think there is an error in your SQL "is not in"

Correct.

I'm having the same issue coming from an original install of 6.0.0 and moving to 9.8.1
I applied Roman's fix to stop the logs getting flooded with these message
update dbo.CoreMessaging_MessageRecipients set Archived = 1 where Archived = 0

A user was messaging me earlier today. Went in a looked at the logs and I don’t think this has anything to do with actually archiving of messages. The reason being I have these message now in the log that seem to correlate to myself and this user. It seems like it might be happening during creating of the messaging interface/view. The reason for this thought is looking in the logs and can see my login and then shortly after the error event. Which would correlate to logging and immediately click the message notification in the menu bar.
2021-02-21 10:27:26,135 [generic262][Thread:52][ERROR] DotNetNuke.Services.Exceptions.Exceptions - System.IndexOutOfRangeException: Archived
at System.Data.ProviderBase.FieldNameLookup.GetOrdinal(String fieldName)
at System.Data.SqlClient.SqlDataReader.GetOrdinal(String name)
at System.Data.SqlClient.SqlDataReader.get_Item(String name)
at DotNetNuke.Services.Social.Messaging.MessageRecipient.Fill(IDataReader dr)
at DotNetNuke.Common.Utilities.CBO.FillObjectFromReader(Object objObject, IDataReader dr)
2021-02-21 10:56:50,444 [generic262][Thread:97][ERROR] DotNetNuke.Services.Exceptions.Exceptions - System.IndexOutOfRangeException: Archived
at System.Data.ProviderBase.FieldNameLookup.GetOrdinal(String fieldName)
at System.Data.SqlClient.SqlDataReader.GetOrdinal(String name)
at System.Data.SqlClient.SqlDataReader.get_Item(String name)
at DotNetNuke.Services.Social.Messaging.MessageRecipient.Fill(IDataReader dr)
at DotNetNuke.Common.Utilities.CBO.FillObjectFromReader(Object objObject, IDataReader dr)
2021-02-21 11:34:41,817 [generic262][Thread:11][ERROR] DotNetNuke.Services.Exceptions.Exceptions - System.IndexOutOfRangeException: Archived
at System.Data.ProviderBase.FieldNameLookup.GetOrdinal(String fieldName)
at System.Data.SqlClient.SqlDataReader.GetOrdinal(String name)
at System.Data.SqlClient.SqlDataReader.get_Item(String name)
at DotNetNuke.Services.Social.Messaging.MessageRecipient.Fill(IDataReader dr)
at DotNetNuke.Common.Utilities.CBO.FillObjectFromReader(Object objObject, IDataReader dr)
2021-02-21 11:40:59,865 [generic262][Thread:65][ERROR] DotNetNuke.Services.Exceptions.Exceptions - System.IndexOutOfRangeException: Archived
at System.Data.ProviderBase.FieldNameLookup.GetOrdinal(String fieldName)
at System.Data.SqlClient.SqlDataReader.GetOrdinal(String name)
at System.Data.SqlClient.SqlDataReader.get_Item(String name)
at DotNetNuke.Services.Social.Messaging.MessageRecipient.Fill(IDataReader dr)
at DotNetNuke.Common.Utilities.CBO.FillObjectFromReader(Object objObject, IDataReader dr)

@sleupold it looks like this issue may have been introduced in #3540. That script edited CoreMessaging_GetNextMessagesForDigestDispatch and CoreMessaging_GetNextMessagesForInstantDispatch to use an explicit column list instead of SELECT *.
Previously: https://github.com/dnnsoftware/Dnn.Platform/blob/714db32390f800ea2336bb0fd2d54fc589256e6b/DNN Platform/Website/Providers/DataProviders/SqlDataProvider/07.02.00.SqlDataProvider#L472-L481
As of 9.5.0: https://github.com/dnnsoftware/Dnn.Platform/blob/714db32390f800ea2336bb0fd2d54fc589256e6b/DNN Platform/Website/Providers/DataProviders/SqlDataProvider/09.05.00.SqlDataProvider#L209-L229
However, that SQL is only called by code which materializes that data into MessageRecipient instances: https://github.com/dnnsoftware/Dnn.Platform/blob/a37c4f80c516272c9f4129b1c157920cae95ab14/DNN Platform/Library/Services/Social/Messaging/Internal/InternalMessagingControllerImpl.cs#L452-L456
MessageRecipient requires the Archived and Read columns, as well as the audit columns CreatedByUserID, CreatedOnDate, LastModifiedByUserID, and LastModifiedOnDate, which aren't supplied by the above stored procedure:
https://github.com/dnnsoftware/Dnn.Platform/blob/714db32390f800ea2336bb0fd2d54fc589256e6b/DNN Platform/Library/Services/Social/Messaging/MessageRecipient.cs#L90-L100

Just a little bump on this so Stale Bot doesn't close it out and it dies on the vine.

I added four missing columns to the procedure and we will see if it fixes the errors.

@prjrvp Did your test work?

@prjrvp Did your test work?

I had to add every single remaining field R.(fieldname) before it worked.  I will note that while this is failing messages are NOT going out.

Weird as have not noticed messages not working. I have received messages and responded to messages without issue. Just each one creates a log entry.

My system sends out heavy messages (about 35 a day) which dropped to a trickle of 1 to 2 a day.  After, I finally fixed it the number went back up to 35 a day.  IN the meantime I learned that user who were to receive these message had received nothing from us.
If the issue was failing and restarting from where it left off, the messages would eventually have been sent. This did not happen. It moved forward in the queue without actually sending the message to the users.  Now, if your users do not use the email and simply look at their message queue on the website, they will not miss messages. They are on the website, just not being sent.
I can not tell you why some messages went out while others did not.

Our site is minimal messages but I was getting the emails also when I was testing and outside of testing. Weird we're having different results. Maybe it has a message volume component also. Would be nice to get this defect resolved though.

Agreed. It is an easy fix on two procedures that you can do live in the production environment using SSMS.

Seems like the fix is known for this. I'm not a developer or I would do a PR to resolve. Would be nice if someone could take a look at this and provide a fix.

@prjrvp can you share the changes you did to resolve this?

Yes, these are the changes required to fix this issue once and for all:
Change Stored Procedure "CoreMessaging_GetNextMessagesForDigestDispatch" to:
/****** Object:  StoredProcedure [dbo].[CoreMessaging_GetNextMessagesForDigestDispatch]    Script Date: 7/31/2021 6:40:55 AM ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[CoreMessaging_GetNextMessagesForDigestDispatch]
@Frequency         INT,
@SchedulerInstance UNIQUEIDENTIFIER,
@BatchSize         INT
AS
BEGIN
UPDATE R
SET   [EmailSchedulerInstance] = @SchedulerInstance,
[LastModifiedOnDate]     = GetDate()
FROM  dbo.[CoreMessaging_MessageRecipients] R
JOIN  (SELECT TOP (@BatchSize)
UserID
FROM  dbo.[vw_MessagesForDispatch]
WHERE [EmailSchedulerInstance] IS NULL
AND   [EmailFrequency] = @Frequency
GROUP BY UserID
ORDER BY UserID) D ON R.UserID = D.UserID
SELECT M.[PortalID],
       M.[NotificationTypeID],
       M.[To],
       M.[From],
       M.[Subject],
       M.[Body],
       M.[SenderUserID],
       M.[ExpirationDate],
       M.[Context],
       R.[RecipientID],
       R.[MessageID],
       R.[UserID],
       R.[EmailSent],
       R.[Read],
       R.[Archived],
       R.[EmailSchedulerInstance],
	   R.[CreatedByUserID],
	   R.[CreatedOnDate],
	   R.[LastModifiedByUserID],
	   R.[LastModifiedOnDate],
	   R.[SendToast]
 FROM  dbo.[CoreMessaging_MessageRecipients] R
 JOIN  dbo.[CoreMessaging_Messages]          M ON R.MessageID = M.MessageID
 WHERE [EmailSent] = 0 -- Filter these 4 columms to use proper index
   AND [Read]      = 0
   AND [Archived]  = 0
   AND [EmailSchedulerInstance] = @SchedulerInstance
 ORDER BY --[PortalID],
          [UserID],
          [RecipientID] DESC

END; -- Procedure
Change Stored procedure 'CoreMessaging_GetNextMessagesForInstantDispatch' to:
/****** Object:  StoredProcedure [dbo].[CoreMessaging_GetNextMessagesForInstantDispatch]    Script Date: 7/31/2021 6:44:12 AM ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[CoreMessaging_GetNextMessagesForInstantDispatch]
@SchedulerInstance UNIQUEIDENTIFIER,
@BatchSize         INT
AS
BEGIN
-- reset possibly remaining records from any previous run of this SchedulerInstance:
UPDATE dbo.[CoreMessaging_MessageRecipients]
SET [EmailSchedulerInstance] = Null,
[LastModifiedOnDate]     = GetDate()
WHERE [EmailSchedulerInstance] = @SchedulerInstance
AND [EmailSent] = 0 AND [Read] = 0 AND [Archived] = 0;
-- reset possibly remaining outdated records from other instances:
UPDATE dbo.[CoreMessaging_MessageRecipients]
 SET   [EmailSchedulerInstance] = Null
 WHERE [EmailSent] = 0 AND [Read] = 0 AND [Archived] = 0
   AND [EmailSchedulerInstance] Is Not Null AND [LastModifiedOnDate] < DateAdd(hh, -2, GetDate());

-- mark messages for dispatch, so they won't be handled by another SchedulerInstance:
UPDATE TOP (@BatchSize) R
 SET   [EmailSchedulerInstance] = @SchedulerInstance,
       [LastModifiedOnDate]     = GetDate()
 FROM       dbo.[CoreMessaging_MessageRecipients] AS R
 INNER JOIN dbo.[CoreMessaging_Messages]          AS M ON R.MessageID = M.MessageID
 LEFT  JOIN dbo.[CoreMessaging_UserPreferences]   AS P ON R.UserID    = P.UserID    AND M.PortalID = P.PortalID
 WHERE R.[EmailSent] = 0 AND R.[Read] = 0 AND R.[Archived] = 0 AND EmailSchedulerInstance IS NULL
   AND CASE
        WHEN M.NotificationTypeID IS Null
        THEN IsNull(P.[MessagesEmailFrequency],      0) -- direct mails are sent immediately by default
        ELSE IsNull(p.[NotificationsEmailFrequency], 2) -- notifications are sent as daily digest by default
       END = 0;

SELECT M.[PortalID],
       M.[NotificationTypeID],
       M.[To],
       M.[From],
       M.[Subject],
       M.[Body],
       M.[SenderUserID],
       M.[ExpirationDate],
       M.[Context],
       R.[RecipientID],
       R.[MessageID],
       R.[EmailSent],
       R.[Read],
       R.[Archived],
       R.[EmailSchedulerInstance],
       R.[UserID],
	   R.[CreatedByUserID],
	   R.[CreatedOnDate],
	   R.[LastModifiedByUserID],
	   R.[LastModifiedOnDate],
	   R.[SendToast]
 FROM  dbo.[CoreMessaging_MessageRecipients] R
 JOIN  dbo.[CoreMessaging_Messages]          M ON R.MessageID = M.MessageID
 WHERE [EmailSent] = 0 -- Filter these columms 4 to use proper index
   AND [Read]      = 0
   AND [Archived]  = 0
   AND [EmailSchedulerInstance] = @SchedulerInstance
 ORDER BY --[PortalID],
          [UserID],
          [RecipientID]

END; -- Procedure

In addition to modifying the two procedures mentioned above, and updating table CoreMessaging_MessageRecipients setting Archived = 1, for an ordinary user it's OK; but entering the site with host or admin user, it logs again the error. It seems this is caused by other type of notifications like from Feedback and other modules.
AbsoluteURL:/Default.aspx
DefaultDataProvider:DotNetNuke.Data.SqlDataProvider, DotNetNuke
ExceptionGUID:5a0cd914-9f5a-4js0-ae2b-4376e84fc43f
AssemblyVersion:
PortalId:-1
UserId:-1
TabId:-1
RawUrl:
Referrer:
UserAgent:
ExceptionHash:Nk4I1Bqc86r3ndSp4HxRGtk2XjB34M=
Message:IsSystem
StackTrace:
at System.Data.ProviderBase.FieldNameLookup.GetOrdinal(String fieldName)
at System.Data.SqlClient.SqlDataReader.GetOrdinal(String name)
at System.Data.SqlClient.SqlDataReader.get_Item(String name)
at DotNetNuke.Entities.Tabs.TabInfo.Fill(IDataReader dr)
at DotNetNuke.Common.Utilities.CBO.FillObjectFromReader(Object objObject, IDataReader dr)
InnerMessage:
InnerStackTrace:
Source:System.Data
FileName:
FileLineNumber:0
FileColumnNumber:0
Method:

Yes, these are the changes required to fix this issue once and for all: Change Stored Procedure CoreMessaging_GetNextMessagesForDigestDispatch to:
/****** Object:  StoredProcedure [dbo].[CoreMessaging_GetNextMessagesForDigestDispatch]    Script Date: 7/31/2021 6:40:55 AM ******/
SET ANSI_NULLS ON
GO
SET QUOTED_IDENTIFIER ON
GO
ALTER PROCEDURE [dbo].[CoreMessaging_GetNextMessagesForDigestDispatch]

What is the purpose of SELECT query at the end of these procedures. How it's result will be used? Although modified the two procedures, the DNN log continuously records the same error message of this issue.


Update versions & Improve C# support

Summary

Fixes #14

Changes

Update versions to latest
linux-headers is necessary as abseil is used as dependency
Use cmake instead of make (deprecated)

Notes for Reviewers
We need at least 1.27.1 of gRPC to generate C# code for proto2 syntax (used in gogo.proto). We should make sure that all clients are able to use those 1.28.1 generated classes.
gRPC 1.26.0 used Protocol Buffers 3.8.0 and gRPC 1.28.1 uses Protocol Buffers 3.11.2. So there might be some requirements to update the minimum version or Protocol Buffers in the libraries.

Hi @Falco20019 - Thanks for this PR!
Could you please confirm that using this image generates the same *.pb.go files in the core repo?

It can't, since protobuf and therefore protoc was updated. So the generated files will change to some extend and we would have to test this for all clients. But there is no other way as C# won't work with 1.26 that we currently use. I will add path files for all languages to make testing easier.

I can't upload them directly as .diff is not an allowed file extension... There is one patch file for each language.
patches.zip

It's a bit problematic to force all libraries to use the same min. gRPC version.
For what I can see, these are the most significant changes between 1.26.1 and 1.28.1 (including protobuf changes):

C++

Mostly related to experimental API
Min. PROTOBUF_VERSION increased from 3008000 to 3011000

Go

MarshalToSizedBuffer replaced MarshalTo
GoGoProtoPackageIsVersion2 increased to GoGoProtoPackageIsVersion
ErrUnexpectedEndOfGroupCollector was added

Java

Mostly just documentation updates

JS

Setter return the type now for chaining
jspb.Map.deserializeBinary signature was changes (new field added)

Python

_b replaced with b
Experimental APIs added

@yurishkuro I would propose that the library maintainers check, if their code base is usable with Protocol Buffer 3.11 as more and more users are updating their libraries.
If it's compatible without increasing the minimal protobuf version, this change should make no problems. If there are compatibility problems, we can also generate those libraries with the old protoc for now in jaeger-idl to keep the version as low as possible. But in the long run, we should be able to upgrade. And this sadly is the minimum version of gRPC / ProtoBuf that C# needs to be able to compile gogo.proto (which we don't even need but must contain to be able to generate the protos from this).

I don't understand why there needs to be a cross-language dependency. I understand dependency on the common version of protoc, but gRPC version can be independent for each language, can it not?

I sadly was not able to find a better solution in the meantime. As those changes come from the common protoc, it's hard without having different protoc versions for each language contained. Right now, all use a common protoc. I'm not sure if having multiple protoc in this container would help us, since we also include the header files in the image.
I will still try to adjust this PR to include a second protoc.

I was able to create a version that fulfills your requirement of keeping all other versions (protobuf + grpc) the same. It involves a separate protoc (as expected) just for C# and an adjusted protoc-wrapper.

I wonder if it would make sense to do a bit of circular dependency and pull jaeger-idl repo during CI and try running the image against it. Otherwise it's a bit difficult to test & ascertain if the changes are good.

As jaeger-idl is just a make file, you can adjust the PROTOC_VER to the one generated here and call make proto. Takes just a couple of seconds. Already did that test after building this docker image locally (which takes ~40-50 minutes as the old protobuf make for 3.8.0 is super slow compared to the cmake for 3.11.2...).

@Falco20019 did you try using the new image to regenerate types in the main repo https://github.com/jaegertracing/jaeger/ ?  It would be useful to validate that there would be no changes to generated files, especially with the version bumps.

I will do a comparison tomorrow. The only changed (introduced) version now is for protoc-csharp. All other versions have been reverted in the PR. So no files other then cs should be affected. I even use the old alpine image.

@yurishkuro The docker image build here is nowhere available, right? Then I need to rebuild it locally... Did a cleanup yesterday since the build increases dockers virtual disc by 12 GB on Windows due to all the intermediate containers necessary until packing...

You were not kidding about 45min docker build...  I don't understand why these are taking so long:
Cloning into '/grpc/third_party/benchmark'...
Cloning into '/grpc/third_party/bloaty'...
Cloning into '/grpc/third_party/boringssl'...
Cloning into '/grpc/third_party/boringssl-with-bazel'...
Cloning into '/grpc/third_party/cares/cares'...
Cloning into '/grpc/third_party/envoy-api'...
Cloning into '/grpc/third_party/gflags'...
Cloning into '/grpc/third_party/googleapis'...

Perhaps because they are being done in the Docker layered file system. What if we mount a local directory from the host and run all the temp steps there?
Also, it would be useful to alter the GH Action so that Docker images from PRs are also uploaded to Docker Hub, e.g. as jaegertracing/docker-protobuf-snapshot/${commit_sha}.

Perhaps because they are being done in the Docker layered file system. What if we mount a local directory from the host and run all the temp steps there?

Sorry to disappoint you, but on my local machine it also takes around 30 minutes without docker. The main problem is, that the old Makefile + Bazel build is preeeeeeetty slow (being responsible for 30 of the 45 minutes). Building the same stuff with CMake (which only really works reliably starting with gRPC 1.28.0, see here) takes only 10 minutes. The remaining 5 minutes were building Java, Go, GoGo and packing everything together. So the whole bottleneck is having to build Protobuf 3.8.0 as part of gRPC 1.26.0.

I did the following test:

build image from this branch: docker build . -t build
regenerate types in the main Jaeger repo: make proto JAEGER_DOCKER_PROTOBUF=build
There were no differences in the generated files.


Adding some functions to hook dictionary

Adding nn.LayerNorm, nn.InstanceNorm1d,nn.InstanceNorm2d,InstanceNorm3d, nn.PReLU, nn.Softmax to dictionary.

Please merge this pr with https://github.com/Lyken17/pytorch-OpCounter/pull/133


Fix contravariant/covariant markings for IReadOnlyList and IReadOnlyCollection

Summary
IReadOnlyList<T> and IReadOnlyCollection<T> are actually covariant in T, not contravariant (as evident by the fact they both declare <out T> and inherit from the covariant IEnumerable<T>).

Awesome, thanks!


install.sh: 10: Syntax error: "(" unexpected (expecting "then")

HELP. i cant find solution anymore.
tar.exe: Error opening archive: Failed to open 'release.tar.gz'
tar.exe doesnt work even i use wget so i manually downloaded the install.sh in URL. but following error oucurred:
install.sh: 10: Syntax error: "(" unexpected (expecting "then")
+WSL is always root even im not elevated but im in administrator account on windows. i have no other account. how to login 'normal user'?

I have the same problem.
root@X9Ti-U8MPK1I:~/release# ./install.sh Please run this as normal user instead of root. Aborting.


Request for license

Dear @fpoussin Thanks a lot for publishing this helm chart.
Would you be able to add a license file to clarify how you intend to allow others to use it?
Thanks a lot.

Done!


Bug when the disk space of the PC becomes zero

When the disk space of the PC becomes zero during "run-container-torizon-release-arm64", the files that extension were running were erased, that is the "Dockerfile" "Dockerfile.debug" and my "main.py".
Only the content of the file was erased, the file wasn't.

Sorry @lucasbernardestoradex we are not able to reproduce this here. Please if this is 100% reproducible take a look at the VS Code side logs, this seems to be an issue there. If you think I'm wrong, feel free to reopen here.


[zero-copy] Start running CI on zero-copy

This is a test - I'm not sure if I need to make this change on master instead.

We'll need to remember to remove zero-copy before merge, but this seems good. Ready to merge?

Yep, good to merge


Baseline alignment does not work when baseline target has fixed height

As can be seen in the navigationview-properties.js snippet, baseline aligning to a textview with a fixed height does not work.

duplicate of https://github.com/eclipsesource/tabris-js/issues/1272


human readable operations

As a front-end developer, I would like to interpret the operations without reading the ABI (for block explorer and extensions for browsers).
In the current implementation, an operation to transfer tokens looks like this:
  {
    "type": "koinos::protocol::call_contract_operation",
    "value": {
      "contract_id": "Mkw96mR+Hh71IWwJoT/2lJXBDl5Q=",
      "entry_point":<PHONE_NUMBER>,
      "args": "MIjFLcnM3djFydHBnUnlmd0VabmN1S01RUW5ZNUpocVhWU3giMTM3Sld2ZzRVZUQ0djg3VzFVTWJ0U2NKWGlVUjRXV3JDcgAAAAJUC+QA",
      "extensions": {}
    }
  }

It would be good to have:

entry_point as string.
args as json.

  {
    "type": "koinos::protocol::call_contract_operation",
    "value": {
      "contract_id": "Mkw96mR+Hh71IWwJoT/2lJXBDl5Q=",
      "entry_point": "transfer",
      "args": {
        "from": "1Krs7v1rtpgRyfwEZncuKMQQnY5JhqXVSx",
        "to": "137JWvg4UeD4v87W1UMbtScJXiUR4WWrCr",
        "value": "10000000000"
      },
      "extensions": {}
    }
  }

In this sense, it would be easy to present this information to the user (for instance, a request for signing a transaction using an extension in the browser) without having to get the ABI of each smart contract.

This issue is stale because it has been open for 30 days with no activity.


No AP

does not work, no AP and portal ..

More details...

Details about not working. A screenshot would help.

captive portal not capturing any input. in the terminal "indentifier box" nothing shows up. Captive portal needs to be started manually by starting apache.


save converted yolov5

Exported the module to folder using "to_folder" and encounter "NameError: name 'onnx2torch_converter_lambda_' is not defined" error when inference after import the module. Any tips what's wrong?

Hello, @clh-b.
Could you provide minimal example to reproduce this error?

I hope #118 solves your problem.
Feel free to reopen PR.

Hello, @clh-b.
Could you provide minimal example to reproduce this error?

Tested v1.5.6, the error is solved. Thanks


Add ability to block blocks from analysis (or specific rules)

Title
Get a ton of warnings for issues that are a non-issue, where I want it to throw the run time error.
Description
I don't want to disable the rule as a whole, e.g. AA0139, but I want to be able to turn it off when I pass it into a function that is external to my code (and thus want it to throw) as the function should resolve this for me.
Reason for the rule
Hides warnings that are not relevant to dev, making it easier to process rules quickly.
Good and bad practices for fixing the rule
Good solution would be something that can turn off the compiler warnings for certain sections, such as:
//IGNORE-BEGIN:AA0139,AW0009,...
code
//IGNORE-END:AA0139,AW0009,...
Remarks
It would be a huge QoL improvement as I am currently diffing to find new issues.

+1 for this enhancement, need it too!


class_weight in .fit fails with InvalidArgumentError: Graph execution error:

A simple model throws an error "InvalidArgumentError: Graph execution error" when using the 'class_weight' parameter. Without this parameter, the model trains without any issues. Conducted multiple experiments; the error is reproducible both on a local PC and in Google Colab
keras version: '2.10.0'
import numpy as np
from keras.models import Sequential
from keras.layers import Dense, Flatten

# X_train_original = np.random.rand(1000, 100, 4)
X_train = np.random.rand(1000, 400)
y_train = np.random.randint(0, 2, size=(1000, 100))

model_test = Sequential([
    # Flatten(input_shape=(4, 100)),  # Изменен input_shape
    Dense(10, activation='relu'),
    Dense(100, activation='sigmoid')  # Размер выходного слоя остается прежним
], name='model_test')

model_test.compile(loss='binary_crossentropy', metrics=['categorical_accuracy'])

model_test.fit(X_train, y_train, epochs=5, class_weight={0: 1., 1: 760.})  # - ERROR
# model_test.fit(X_train, y_train, epochs=5)  # OK

@sachinprasadhs  was able to replicate the issue reported here. Thank you!

Hi @Satori1313, you have 3 classes in your training and you are setting class_weight for just two classes. The following code should fix your issue.
import numpy as np
from keras.models import Sequential
from keras.layers import Dense, Flatten

# X_train_original = np.random.rand(1000, 100, 4)
X_train = np.random.rand(1000, 400)
y_train = np.random.randint(0, 1, size=(1000, 100))

model_test = Sequential([
    # Flatten(input_shape=(4, 100)),  # Изменен input_shape
    Dense(10, activation='relu'),
    Dense(100, activation='sigmoid')  # Размер выходного слоя остается прежним
], name='model_test')

model_test.compile(loss='binary_crossentropy', metrics=['categorical_accuracy'])

model_test.fit(X_train, y_train, epochs=5, class_weight={0: 1., 1: 760.})  # - ERROR
# model_test.fit(X_train, y_train, epochs=5)  # OK

Hi @divyashreepathihalli, I don't understand why you're talking about three classes.
y_train = np.random.randint(0, 2, size=(1000, 100)) creates an array with two classes: '0' and '1'. ('2' is not included in the randint range)
This can be easily verified:
y_train = np.random.randint(0, 2, size=(1000, 100))
print(y_train.min(), y_train.max())

Output: 0 1
In your example, y_train = np.random.randint(0, 1, size=(1000, 100)), the entire y_train array consists exclusively of '0'."
y_train.max()
0.0
y_train.min()
0.0


BitVM2: bump rust nightly

Description
Same version as main.
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Refactor
[ ] New or updated tests
[x] Dependency Update

Notes to Reviewers

Checklist

[x] I have performed a self-review of my code.
[x] I have commented my code where necessary.
[x] I have updated the documentation if needed.
[x] My changes do not introduce new warnings.
[x] I have added tests that prove my changes are effective or that my feature works.
[x] New and existing tests pass with my changes.

Related Issues

All of the expect comments are valid but they will be off from the main branch

This might not be needed since https://alpenlabs.atlassian.net/browse/STR-769

This might not be needed since https://alpenlabs.atlassian.net/browse/STR-769

Yeah the plan is to tackle all the changes at once and create a single PR but those changes don't include bumping the nightly version. If you want to merge this one before that ticket, that works too. if not, you can go ahead and close this ticket and I or somebody else will pickup the other one.


Sourcebin Commands

Allows a user to create a sourcebin, or view information on a certain sourcebin.

Finished -
(4/9/2023) Pending push to main branch!


[SMALLFIX] Fix a race condition and a small improvement to error handling

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12959/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12961/
Test PASSed.

Merged build finished. Test PASSed.

@apc999 PTAL

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12964/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/12965/
Test PASSed.

LGTM


Replacing a collection with another does not remove replaced collection

I have a specific situation highlighted like this:
+-----+            +-----+
|  A  |--hasMany-->|  B  |
+-----+            +-----+

However, whenever I'm replacing the collection of B entities with a new collection, the old (replaced) collection entities are never removed.
I even configured orphanRemoval=true, but it seems there is no effect.
Any hints on getting this working?

Thanks for this issue. We have decided to officially end-of-life JSDoc support in ESLint. As a result, this repository and project will no longer be maintained.
Thanks for understanding and we apologize for any inconvenience.


⚠ Fortnite has degraded performance

In cad2dd5, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1745 ms

Resolved: Fortnite performance has improved in 3f6e39e.


Add pre-commit

Add configuration for pre-commit.

Should include ruff and potentially mypy checks (if it doesn't slow things down too much) -- look at
Should this only run on commits to main?
Add setup steps to new CONTRIBUTING.md doc (WIP)

I spotted a failing Dependabot issue for Black that was created back in March, which can be a problem for pre-commit:
Sadly, Dependabot does not support pre-commit (nor will it anytime soon). To keep hooks and Python packages in sync, you must manually track hook updates by running pre-commit autoupdate regularly.
A mismatch between the Black Python package and pre-commit hook versions can lead to wrongly formatted code. Similar issues can occur with other quality tools.
I don't have a practical solution for this situation, but it is something to consider.
Cc. @epw1624 (we discovered this during a Zoom call)


May I ask if conv1d, conv2d, and batchnorm will be supported to implement the Clone trait?

https://github.com/huggingface/candle/blob/f685b2231cad71e98257b62618b364c255feacd7/candle-nn/src/conv.rs#L24
https://github.com/huggingface/candle/blob/f685b2231cad71e98257b62618b364c255feacd7/candle-nn/src/conv.rs#L92
https://github.com/huggingface/candle/blob/f685b2231cad71e98257b62618b364c255feacd7/candle-nn/src/batch_norm.rs#L42

It could be easily implemented. You could wrap with Arc to achieve this, or construct a new ] Conv1d/2d/etc manually by constructing from the tensors.

It's certainly possible to wrap the layers in some Arc or Rc to make it cloneable, that said the Tensor type itself uses an Arc so it cloning of these layers should be fairly cheap so I've made #910 to implement this trait for the layer where it makes sense.

It's certainly possible to wrap the layers in some Arc or Rc to make it cloneable, that said the Tensor type itself uses an Arc so it cloning of these layers should be fairly cheap so I've made #910 to implement this trait for the layer where it makes sense.

This is an excellent job


python packages updates: thumbor, statsd, ...

As usual, you begin fixing a single package, and you end up updating an entire chain of dependencies as well.

Thumbor cc @proger
statsd cc @domenkozar
pyramid cc @domenkozar  @garbas

Built locally with nox review wip

Thanks!

:cake:  One nitpick: I'd prefer we disable failing tests instead of the whole testsuite, since tests are the single source of truth in Python.

@proger Thanks, comment is removed now.
@domenkozar I agree with you. It's a pity it often gets so time-consuming. It would be nice if some day we could disable tests in a manner that would work with all runners. I removed the specific test in statsd now.


[BUG]

I'm using 2.1.1 (f641425-2673)
Connected to Barco E2.
eventmaster: Change aux on destination does not change the aux. I have tried this with Windows, Mac and Linux, same results. All other Eventmaster commands working fine.
When I reverted to Companion 1.4 it works fine.

Not sure if it's related, but I've noticed that when this instance tries to send out a 0 it sends a NULL instead. I've never figured out why or why it sometimes sends an actual 0. This is a problem when changing the first AUX or changing anything to the first source.
label: 'nve3MJ4Jo:change_aux',
instance: 'nve3MJ4Jo',
action: 'change_aux',
options: { source: null, auxDestination: '1' } } +0ms
instance:barco-eventmaster:nve3MJ4Jo run action: change_aux +2s

This is probably the select nothing error. When adding the action but not selecting a different source. Could this be the case? I thought this was fixed

I have multiple sources and the result is same. Gonna try to change Aux destination and see it that will change

Changing destinations works. So I guess as a workaround, after creating the button I need to select some random Aux destination and source before I use the Aux and source that I need.

I've updated the module so standard first option will be selected (thats also the one you see). The issue here is, that the dropdown box is filled later than the initial settings so no option was selected.


[WIP] BLD: Adding meson.build to sparse.linalg

Reference issue

What does this implement/fix?

Additional information

CI is doing its job:)

There's a ton of build warnings from SuperLU. Since it's a vendored library that's actively maintained, we don't want to fix those (maybe at some point, fix upstream). So you can silence them (unless they look suspicious).

There's a ton of build warnings from SuperLU. Since it's a vendored library that's actively maintained, we don't want to fix those (maybe at some point, fix upstream). So you can silence them (unless they look suspicious).

Yeah, I will continue that tomorrow. Tricky part today was to convert .f.src->.f. Though I figured out that its from_template of numpy.disutils doing the thing. I just edited, generate_f2pymod to do it. Let me know if its the correct way.

Tricky part today was to convert .f.src->.f. Though I figured out that its from_template of numpy.disutils doing the thing. I just edited, generate_f2pymod to do it. Let me know if its the correct way.

That sounds about right. If it works, let's leave it like that. An alternative could be to change the templating to tempita, see https://github.com/scipy/scipy/issues/13930. (note that the .c.src and .f.src are very different, so it does not apply 1:1).

IMHO, C++ templates would be the best alternatives to go for. They are modern and easy to handle. They are used by everyone so whatever updates in them will help us where as by hand templating in .c.src is specific to our projects, so we have to maintain the logic for converting .c.src -> .c which is an overhead. C++ templates are available for free without any maintenance headache. So, any day I will be +1 to port .c.src to .cpp with templates.

It seems like the error hasn't gone away yet,
E   TypeError: C function scipy.linalg.cython_blas.daxpy has wrong signature (expected void (int *, __pyx_t_5scipy_6linalg_11cython_blas_d *, __pyx_t_5scipy_6linalg_11cython_blas_d *, int *, __pyx_t_5scipy_6linalg_11cython_blas_d *, int *), got void (int *, __pyx_t_11cython_blas_d *, __pyx_t_11cython_blas_d *, int *, __pyx_t_11cython_blas_d *, int *))

It seems like the error hasn't gone away yet,

Hmm, it did rebuild this one extension as intended, but the issue is still there - odd:
[1120/1120] Linking target scipy/optimize/_highs/_highs_constants.cpython-39-x86_64-linux-gnu.so
ninja: Entering directory `build'
[1/4] Generating _decomp_update with a custom command
[2/4] Compiling Cython source scipy/linalg/_decomp_update.pyx
[3/4] Compiling C object scipy/linalg/_decomp_update.cpython-39-x86_64-linux-gnu.so.p/meson-generated_scipy_linalg__decomp_update.pyx.c.o
[4/4] Linking target scipy/linalg/_decomp_update.cpython-39-x86_64-linux-gnu.so
~/work/scipy/scipy/build ~/work/scipy/scipy
ninja: Entering directory `.'
ninja: no work to do.

And the other thing to fix is that CI status isn't red when a test command fails.

The last thing to improve is to split CI stages into:

build
install
run tests

The meson install command generates one line of output per target it installs, which makes it hard to find other things.

Pushed a commit to split the CI job. It will only run the tests for constants until the Cython build issue is fixed. That issue is extremely annoying since it's not deterministic, so I'm having trouble finding a fix that is definitely working.

The installation is failing on CI. While you look into the Cython signature issue (as you are pretty close to it), I will try fixing Segfault in DIRECT algorithm. Thanks.

Sounds good. I'll fix CI and will test this PR locally.

Thanks Ralf.


Add XSS vulnerability in league/commonmark

See https://github.com/thephpleague/commonmark/issues/353

A CVE identifier has been requested.  I will amend this PR or submit a new one once it has been assigned.


⚠ Mobitopup has degraded performance

In 304cc3a, Mobitopup (https://napcard.voz.tech) experienced degraded performance:

HTTP code: 200
Response time: 8993 ms

Resolved: Mobitopup performance has improved in d44bf5d after 7 minutes.


Finalize repo QA compliance

As part of the TM issue https://github.com/api3dao/tasks/issues/849 for QA, some requirements need to be addressed:
Repo setup requirements as per new_repo_creation_checklist.md:

[x] Link the repo to some relevant page if applicable
[x] Add the relevant license file LICENSE.md consistent with the organisational standards or project requirements.
[x] Review and confirm the repository’s settings align with the organization’s compliance and security protocols. (e.g. cross check https://github.com/api3dao/design-tokens/security)
[x] Install Renovate in the repository, following the guidelines outlined in dependencyManagementStrategy.md.
[x] Create a renovate.json configuration file in the root of the repository to manage dependencies effectively, as per our dependency management strategy.
[x] Set up Renovate (or Dependabot or a similar tool) for automated security vulnerability scanning to detect vulnerabilities in the codebase.

AFAICT all steps are completed. It would be great if @BTT21000 or someone else can review them 🙏

AFAICT all steps are completed. It would be great if @BTT21000 or someone else can review them 🙏

LGTM! I'm closing the issue. Thank you


Conflict with other jQuery plugin due to .transition

Hi,
Swiper conflict with plugin: http://ricostacruz.com/jquery.transit
Due to "transition()", I renamed all instances to prevent conflict and is working.
Any suggestions?
Thanks,
David

Same issue here.

Closed due to no proper feedback form authors.


Use "__typename" for Fragment Resolution

The analyzer should attach all possible types that would trigger a fragment within the canonical operation. Afterwards, the executor can use the __typename (#6) field every map should expose to decide whether the fragment was triggered.

As of alumbra/alumbra.analyzer@8f5e487304a9952bbe20a26f577f8bc80f5ccfd9 the types that trigger a fragment are attached to the canonical operation.
As of alumbra/alumbra.claro@25ffde9 the conditional projection relies on __typename.


Redirect SchemeRewriteSpecifier doesn't seem to strip ports as specified

If you are reporting any crash or any potential security issue, do not
open an issue in this repo. Please report the issue via emailing
<EMAIL_ADDRESS>where the issue will be triaged appropriately.
Title: Redirect SchemeRewriteSpecifier doesn't seem to strip ports as specified
Description:
According to the docs
	// When the scheme redirection take place, the following rules apply:
	//  1. If the source URI scheme is ``http`` and the port is explicitly
	//     set to ``:80``, the port will be removed after the redirection
	//  2. If the source URI scheme is ``https`` and the port is explicitly
	//     set to ``:443``, the port will be removed after the redirection

However, with
      redirect:
        pathRedirect: /full-path-replacement
        responseCode: FOUND
        schemeRedirect: http

I see:

Host: a:80 -> Location: http://a:80`
Host: a -> Location: http://a`

Wwith
      redirect:
        pathRedirect: /full-path-replacement
        responseCode: FOUND
        portRedirect: 80
        schemeRedirect: http

I see:

Host: a:80 -> Location: http://a:80`
Host: a -> Location: http://a:80`

Neither of these seem to represent a way to strip the port, which the docs suggest.
Related is https://github.com/envoyproxy/envoy/pull/25573, which I believe suggests a new explicit field to strip.

cc @alyssawilk @RyanTheOptimist


Init lc.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Got it, thanks. If you want to get something merged in the future please lmk.


[New game]: Bubble shooting game

🎮 Game Request
Game logic and basic description : It's a Bubble Shooter Game, made using HTML,CSS,JS .
Point down the features
High Score Tracking: Optionally, track the player's highest score achieved in a single session or overall.
Progressive Difficulty: Increase the complexity of the game over time by adding more letters to the sequence or reducing the time limit for typing.
Tech Stack: HTML,CSS,JS
Select program in which you are contributing
GSSoC24
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @codewithganeshhh !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @codewithganeshhh!
We are already having a similar game request in #3098 👀
Make sure you come up with a cool unique idea 😀
Waiting for your new game idea 💗.

Hey @codewithganeshhh ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Logo Images for tech-stacks not available due to migration at source

Issue:
Recently, I came across this issue: Logo Image in tech-stack card is not visible and name is shown as fallback text.

Cause:
On the source app of wappalyzer, image logo files are migrated to new location.
Old Location: https://raw.githubusercontent.com/wappalyzer/wappalyzer/master/src/drivers/webextension/images/icons/
New Location: https://raw.githubusercontent.com/wappalyzer/wappalyzer/master/src/images/icons/
Required change:
Updating the path in TechStack.tsx
Successfully tested in local:

Thanks @khantiRindani for the detailed ticket
I've pushed a fix out for this :)
Although sadly this feature might not be around for much longer, as the author of Wappalyzer has made the project private. I'm working on a fork of it at the moment.
https://twitter.com/ITSecurityguard/status/1694674956204880132

Got it, thanks @Lissy93 for sharing. Do you think if it's possible to ask wappalyzer for a feature request where image is also part of the API response? We would be free from github repo dependency. The limitations with free tier of API usage would still be there though.

Well it's already using icons from their CDN, rather than the GitHub (updated in 49cfad2dbe00325fe4668af9786b6f014a611169)
https://github.com/Lissy93/web-check/blob/6d8b2368e7dc8a128d08acc9d172995a727cffde/src/components/Results/TechStack.tsx#L83
I'm affraid that using the Wappalyzer API is not an option. Their API has no free tier, and pricing starts from $250/month for only 5000 requests. I can't afford that, even for testing.
But feel free to fork the repo, if you'd like to add support for Wappalyzer API (you'll need your own keys to develop this).

Alternativley, I've got a fork of Wappalyzer which I'm going to be maintaining here: https://github.com/Lissy93/wapalyzer
The original version is no longer available on GitHub.

Got it, thanks @Lissy93.


toggle-files-button: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.

Description
TypeError: Failed to execute 'observe' on 'MutationObserver': parameter 1 is not of type 'Node'.
    at observeElement (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:6796:23)
    at init (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:6898:28)
    at async runFeature (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:3955:20)
    at async setupPageLoad (chrome-extension://hlepfoohegkhhmjieoechaddaejaokhf/refined-github.js:3961:34)

How to replicate the issue
Click on a folder in a repo
Extension version
22.7.20
Browser(s) used
Brave

repo-age is also failing:
❌ repo-age
refined-github.js:3897 📕 22.7.20 → TypeError: Cannot read properties of undefined (reading 'append')
    at init (refined-github.js:9163:70)
    at async runFeature (refined-github.js:3955:20)
    at async setupPageLoad (refined-github.js:3961:34)

I think there's some race condition?

Both work, it’s just an ajax issue. Closing since it’s tracked in https://github.com/refined-github/refined-github/issues/5835


Consider revisiting regexes

Poking around in common.go, some of the regexes could benefit from golang's raw string support.  For example,
"double": scanner.Definition{regexp.MustCompile("^\"([^\"\\n]|\\\")*\""), "STRING"},

becomes
"double": scanner.Definition{regexp.MustCompile(`^"([^"\n]|\")*"`), "STRING"},

Thus avoiding the tricky double escaping and becoming much clearer.

Thanks, you're right! Unfortunately we've currently got our hands too full to start visiting stylistic improvements, but we definitely welcome pull requests!

Hey, no problem, I'm here to help. More than happy to push it down at some point.
I, too am busy with more interesting things (like adding escape code,  HTML and Perl support to your lexer), but I just wanted an issue to track this for when I finally do get the chance to revisit it.

Feel free to do so in that case. We can add you as a contributor to this
project if you want to work on it. We are currently not using this so we're
open to additions, we think that the right solution is to build a lib that
can use an existing editor's or syntax highlighting package's language
definitions, not to build our own definition format and set of definitions.
I feel we won't continue to maintain it if the direction is toward more
manual upkeep of our own definitions
On 14 April 2015 at 02:39, alaska<EMAIL_ADDRESS>wrote:

Hey, no problem, I'm here to help. More than happy to push it down at some
point.
I, too am busy with more interesting things (like adding escape code, HTML
and Perl support to your lexer), but I just wanted an issue to track this
for when I finally do get the chance to revisit it.
—
Reply to this email directly or view it on GitHub
https://github.com/sourcegraph/lexer/issues/2#issuecomment-92455598.

You absolutely want to support other editors' syntax highlighting. It only makes sense to pull in mind share from other editors, and that was a goal I started this project with. I looked into the way highlighting was done in other environments and came up with the following candidates for automatic conversion:

vim

would need to do automatic conversion of all highlighting keywords as well as support setting flags for the ifdef-like blocks in each one
would need to automatically convert from vim regex to Go
would need to at least casually parse vimscript to issue warnings about files that try to do anything more in vimscript than include another file

submlime/textmate:

would need to do automatic conversion of Oniguruma regexes to Go ones. Would need to be kept up to date to ensure new incompatibilities due to drift between them were handled

rainbows/highlight.js/other js solution:

would need to parse relevant definition sections. These might have to be at least extracted by hand before being fed to the converter.

pygments

would obviously need to parse the python directly out of the files in pygments/lexers.

I looked into some others like katepart, but didn't have the time to dig through the code which is now part of kdelibs ;)
Then it becomes a matter of picking which one is easiest, working for feature parity with their highlighting engine.  Based on my considerations, textmate or pygments parsing seem the most likely candidates, with pygments winning in terms of easy access to the lexer code.
If you guys wanted to settle on which framework you wanted to support import from, I could probably start to look into meaningful changes that need to happen to achieve feature-parity. You'd want to generate .go files automatically with a tool at least to avoid needing to bundle the files of whatever framework you want to borrow from with the lib.


Dummy PR - sonar test

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6352 (SL-JID-1514)

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6352 (SL-JID-1517)


I want to maintain this package!

Hello, guys!
I have used this package extensively in the past and now have students who would greatly benefit from using this package. I have the time and would like to maintain the package.
I thought of forking the package, but decided it was better to bring the discussion here.
Thanks!

Awesome, thank you for your interest! The best way to get started would be to go through the issues list and send a pull request. My personal no 1. priority would be to fix Jupyter Lab support as the report renders very badly at the moment.

Did this ever get settled? This package is amazing and I'd also love to help. Please let me know and thank you for this repo!


Rearranging tabs: Remove temporary pixels

Task/Issue URL: https://app.asana.com/0/1207418217763355/1207724966190088/f
Description
This PR just removes temp pixels.

#4975  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @0nko and the rest of your teammates on  Graphite


chore(package_info_plus): Update http dependency constraints

Description
Adjusting dependency constraints for http package to let people decide if they want to keep using old version or already switch to 1.0.0 without bumping min Dart of package_info_plus to 3.
Closes #1840

release date?

Released in 4.0.2 today


Add all of an artists albums to a playlist

Is your feature request related to a problem? Please describe.
I'd like the ability to add all of an artists albums from their Artists page to a playlist like this Chrome extension does:
https://chrome.google.com/webstore/detail/spotify-artists-all-songs/jdicfniianljldbajoghhnilmnghgmno

@bonelifer: Heya. This sounds very doable. I do have something in the pipeline regarding discographies, but this is distinct enough that I can implement it. I will also readily welcome a PR if you already have your sight on building it yourself.
Quick questions:

Does the other extension no longer work? Or are you looking to just consolidate its feature into this one?
The most I can do is get every song of an artist and maybe songs they are a feature on. I can also try to remove duplicates, but this will probably be based on song names, thus there could be similar song versions like remix, acoustic, and live. I think that's in line with what the extension currently does. I assume you make or have made use of that extension, so does this sound about in line with what you envision?

Maybe later on I can add additional options like including/excluding explicit tracks, whether to include remixes and acoustic versions, allowing user to set the playlist name, moving feature to popup (though not likely as a user wanting to use this feature would already be on the web ui). I can do these on another iteration down the line.


add Backend.Dart enum value

This is necessary in order to add Dart support to IntelliJ.
After looking through git grep -l tools.Backend and git grep -l java.runtime.tools in various repos, I don't see where this change can cause problems.
It is true that in ceylon-ide-intellij there is logic like "If not Java, it must be JavaScript", but that should be fine for the time being.

Can one of the admins verify this patch? (see README)