Adopt Zabbix protocol

Zabbix is a traditional and widely used metrics monitoring mechanism. We should consider to adopt its network protocol, and convert to our metrics system.
All @apache/skywalking-committers , this requirement will need more discussion on tech details. If any of you feels interested in this, please reply.
NOTE, Zabbix is GPL licensed, but because we don't copy any codes, just implement its protocol in our own codes, and optional feature only. it is not an issue.

I have started reading their API document a few days, we need to using Host, Host Group, and Item.
Follow the API document, I think we need a new fetcher to process all the Zabbix hosts and metrics data.
At the fetcher processing, we need to follow these steps.

Creating a new schedule task to query their API, similar to Prometheus fetcher.
User needs to provide their Zabbix user account at the configuration, so we could access their API after login.
User needs to provide metrics conversion mapping, such as MAL. We need to use item API to get all these host metrics data and convert them to the meter system.
Using host group and host API to get The necessary data, to build the service or service instance data.

I have started reading their API document a few days, we need to using Host, Host Group, and Item.
Follow the API document, I think we need a new fetcher to process all the Zabbix hosts and metrics data.
At the fetcher processing, we need to follow these steps.

Creating a new schedule task to query their API, similar to Prometheus fetcher.
User needs to provide their Zabbix user account at the configuration, so we could access their API after login.
User needs to provide metrics conversion mapping, such as MAL. We need to use item API to get all these host metrics data and convert them to the meter system.
Using host group and host API to get The necessary data, to build the service or service instance data.

Using zabbix: prefix to build their service or service instance name. separate with agent side service and service instance name.

Using zabbix: prefix to build their service or service instance name. separate with agent side service and service instance name.

Doesn't Zabbix agent use push mode? The idea is replacing the Zabbix server, rather than reading data from it.

Doesn't Zabbix agent use push mode? The idea is replacing the Zabbix server, rather than reading data from it.

Doesn't Zabbix agent use push mode? The idea is replacing the Zabbix server, rather than reading data from it.

Do you mean using Sender? It seems like sending to the Zabbix proxy.

Doesn't Zabbix agent use push mode? The idea is replacing the Zabbix server, rather than reading data from it.

Do you mean using Sender? It seems like sending to the Zabbix proxy.

Take a look at https://www.zabbix.com/documentation/current/manual/introduction/overview
SkyWalking OAP should be a replacement of Zabbix server to support Zabbix proxy and agents.

Take a look at https://www.zabbix.com/documentation/current/manual/introduction/overview
SkyWalking OAP should be a replacement of Zabbix server to support Zabbix proxy and agents.

Take a look at https://www.zabbix.com/documentation/current/manual/introduction/overview
SkyWalking OAP should be a replacement of Zabbix server to support Zabbix proxy and agents.

It seems like Active Checks Mode, agent side query items need to be monitored and collecting metrics items sending to proxy or server.

Take a look at https://www.zabbix.com/documentation/current/manual/introduction/overview
SkyWalking OAP should be a replacement of Zabbix server to support Zabbix proxy and agents.

It seems like Active Checks Mode, agent side query items need to be monitored and collecting metrics items sending to proxy or server.

I see. Let's see how the metrics really look like, whether to be compatible with our MAL, then, we could set up the tech stack for TCP connection this time.

I see. Let's see how the metrics really look like, whether to be compatible with our MAL, then, we could set up the tech stack for TCP connection this time.

I have installed a simple Zabbix agent and server demo in the local machine, and using Wireshark to monitor the network base on Active Checks Mode. It will help to debug and watch data locally. I uploaded this pcapng file, you can view the specific data by downloading the Wireshark software.
The metrics key in Zabbix follow this format: keyName[params], for more specifications, please refer to https://www.zabbix.com/documentation/current/manual/config/items/item/key
Let's take the key of system.cpu.load[all,avg15] as an example, and divide it into two parts: Key Name and Parameter:
Key Name
In the above example, it is system.cpu.load.
The metrics key in Zabbix is not particularly compatible with our MAL. When MAL parses, it will consider system as a metric and cannot find the cpu property. Zabbix does not provide a similar formatting key function, such as system.cpu.load -> system_cpu_load.
So I thought of two ways to solve it:

Users manually replace the "." with the "_" symbol when inputting expressions. In the above example, the expression of MAL must be manually replaced with system_cpu_load. When the backend receives the data and prepares to convert the MAL, it will also change the . -> _ of the key in the metrics.
The user does not need to change the name of the metrics, it is solved by extending the function of MAL. When MAL cannot find SampleFamily, a new SampleFamilyFinder is provided to solve it. In SampleFamilyFinder, it can be solved by implementing the propertyMissing method.

Parameter
In the above example, it is all,avg15
We can convert it into the form of multiple tag values, and identify the index as a tag key. In the above data, it will become {0: all, 1: avg15}.
At this time, you can filter by .tagEqual('0','all').tagEqual('1','avg15') in MAL.

I have installed a simple Zabbix agent and server demo in the local machine, and using Wireshark to monitor the network base on Active Checks Mode. It will help to debug and watch data locally. I uploaded this pcapng file, you can view the specific data by downloading the Wireshark software.
The metrics key in Zabbix follow this format: keyName[params], for more specifications, please refer to https://www.zabbix.com/documentation/current/manual/config/items/item/key
Let's take the key of system.cpu.load[all,avg15] as an example, and divide it into two parts: Key Name and Parameter:
Key Name
In the above example, it is system.cpu.load.
The metrics key in Zabbix is not particularly compatible with our MAL. When MAL parses, it will consider system as a metric and cannot find the cpu property. Zabbix does not provide a similar formatting key function, such as system.cpu.load -> system_cpu_load.
So I thought of two ways to solve it:

Users manually replace the "." with the "_" symbol when inputting expressions. In the above example, the expression of MAL must be manually replaced with system_cpu_load. When the backend receives the data and prepares to convert the MAL, it will also change the . -> _ of the key in the metrics.
The user does not need to change the name of the metrics, it is solved by extending the function of MAL. When MAL cannot find SampleFamily, a new SampleFamilyFinder is provided to solve it. In SampleFamilyFinder, it can be solved by implementing the propertyMissing method.

Parameter
In the above example, it is all,avg15
We can convert it into the form of multiple tag values, and identify the index as a tag key. In the above data, it will become {0: all, 1: avg15}.
At this time, you can filter by .tagEqual('0','all').tagEqual('1','avg15') in MAL.

For MAL details, @hanahmily what do you think? Personally, . -> _ as an auto mechanism is fine.

For MAL details, @hanahmily what do you think? Personally, . -> _ as an auto mechanism is fine.

I thought about the format of the configuration file. The configuration can also be placed in the same directory and can be distinguished by files based on different metrics.
entities: # All entities support the metrics
  - service: test_service # Combine all hosts, adding prefix "zabbix:"
     instance-pattern: .+ # All hosts will support keys, adding prefix "zabbix:"
metrics:
  - name: system_cpu_util # Save to meter system name, adding prefix "meter_"
    keys: # Define need receive data keys from agent, all key update limit is `1m`, support number value only
      - system.cpu.util[,system]
      - system.cpu.util[,user]
      - system.cpu.util[,iowait]
      - system.cpu.util[,idle]
    exp: system.cpu.util  # MAL expression

When the agent asks which metrics keys need to be monitored, it will obtain all metrics.keys according to entities.instance-pattern. Also:

keys that are repeatedly declared will be deduplicated before sending.
If entities.instance-pattern is declared in multiple configuration files, then metrics.keys among them will tell the agent to query.

When pushing data content on the agent side, the data will also be aggregated into the entities.service service according to the specified host. The data content is generated based on all metrics.exp and metrics.keys.

I thought about the format of the configuration file. The configuration can also be placed in the same directory and can be distinguished by files based on different metrics.
entities: # All entities support the metrics
  - service: test_service # Combine all hosts, adding prefix "zabbix:"
     instance-pattern: .+ # All hosts will support keys, adding prefix "zabbix:"
metrics:
  - name: system_cpu_util # Save to meter system name, adding prefix "meter_"
    keys: # Define need receive data keys from agent, all key update limit is `1m`, support number value only
      - system.cpu.util[,system]
      - system.cpu.util[,user]
      - system.cpu.util[,iowait]
      - system.cpu.util[,idle]
    exp: system.cpu.util  # MAL expression

When the agent asks which metrics keys need to be monitored, it will obtain all metrics.keys according to entities.instance-pattern. Also:

keys that are repeatedly declared will be deduplicated before sending.
If entities.instance-pattern is declared in multiple configuration files, then metrics.keys among them will tell the agent to query.

When pushing data content on the agent side, the data will also be aggregated into the entities.service service according to the specified host. The data content is generated based on all metrics.exp and metrics.keys.

I think we don't have to add prefix like zabbix: forcely, we have the group concept on UI, which could be declared through the configuration. Check the oc-receiver rules.
And many metrics of Zabbix should follow this #6108, which is also focusing on the VM metrics.

I think we don't have to add prefix like zabbix: forcely, we have the group concept on UI, which could be declared through the configuration. Check the oc-receiver rules.
And many metrics of Zabbix should follow this #6108, which is also focusing on the VM metrics.

I think we don't have to add prefix like zabbix: forcely, we have the group concept on UI, which could be declared through the configuration. Check the oc-receiver rules.
Of course, add a new configuration item named expSuffix, and add the tags service and service instance to each metric.
And many metrics of Zabbix should follow this #6108, which is also focusing on the VM metrics.
Sure, I will following this issue, then I could add metrics into VM.

I think we don't have to add prefix like zabbix: forcely, we have the group concept on UI, which could be declared through the configuration. Check the oc-receiver rules.
Of course, add a new configuration item named expSuffix, and add the tags service and service instance to each metric.
And many metrics of Zabbix should follow this #6108, which is also focusing on the VM metrics.
Sure, I will following this issue, then I could add metrics into VM.

I think we don't have to add prefix like zabbix: forcely, we have the group concept on UI, which could be declared through the configuration. Check the oc-receiver rules.

Of course, add a new configuration item named expSuffix, and add the tags service and service instance to each metric.

And many metrics of Zabbix should follow this #6108, which is also focusing on the VM metrics.

Sure, I will following this issue, then I could add metrics into VM.

I think we don't have to add prefix like zabbix: forcely, we have the group concept on UI, which could be declared through the configuration. Check the oc-receiver rules.

Of course, add a new configuration item named expSuffix, and add the tags service and service instance to each metric.

And many metrics of Zabbix should follow this #6108, which is also focusing on the VM metrics.

Sure, I will following this issue, then I could add metrics into VM.


Company and Contact Page - tags are not showing suggestions by Vinod Sir

Describe the bug
https://www.berrycast.com/conversations/77992e31-75c5-5ad1-861e-f7acc9a8ca8f

https://www.berrycast.com/conversations/91db2e26-8058-5076-831e-ecc72c19f2d1


Fix typo for domain check

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.149%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1788

Relevant Lines:
2703

💛  - Coveralls


Countdown not showing in red for Armenia

At 8:04am it's showing:

Not able to reproduce, seems to be rendering issue not updating correctly.


All list/search commands are broken

LP version: 4.1.100
/lp group owner listmembers error
https://haste.jartexnetwork.com/curunetonu.sql
/lp search group.owner error
https://haste.jartexnetwork.com/awahuwujes.sql
Using mysql 5.7.21, and query SELECT * FROM `luckperms_user_permissions` WHERE `permission` LIKE 'group.owner' just works in command line.

I can confirm.
Shouldn’t that be prepared statements? To prevent against SQL injection etc

Yes they should.


fix fix incorrect grouping of vertical compaction columns in tables only with key columns

master #32896
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


fix(p9k::defined): work when -u is set

Without this fix, set -u will cause commands to fail because of the
prompt.

Maybe the tests should all have set -u set in them?  I haven't looked into the tests in detail to see how to do that correctly.

Having set -u in all test is probably a good idea.. But my gut feeling tells me that we have a lot of unused variables... IMHO we should address them in separate PRs..


Timeseries scale

Timeseries scale added, see this issue for more info: https://github.com/chartjs/Chart.js/issues/4189
small example here: https://codepen.io/ilyabelyaev/pen/BRvKPw

@IlyaBeliaev I haven't had a chance to look at this in detail yet, but could you rebase this against master?

I think this is ready to be merged (other than the conflict in src/chart.js)

it's good! made rebase

Also curious how many KB this PR introduces compared to the master Chart.min.js size?

Yeah, timeseries is conceptually part time / part category However, it turns out that it's quite hard to share much code with category. I tried that first I believe, but there were only a few methods that were generally the same and even they had subtle differences that made sharing hard. I think inheriting from time is actually the better way to go as it cuts down more on the amount of code required.

Sizes: 155 734 bytes vs 153 051 bytes

About a code from category scale. I'm working on the next PR that will add support of tick alignment and major units for timeseries scale. There timeseries scale have an other code to determine tick positions etc. So it was a good decision to inherit it from time scale.

@simonbrunel Thank you for the review. I think I can refactor timebase a bit in a next PR.


Error attempting to prune local branches

Pretty likely that someone's used some unexpected characters in branch names.
I'm getting an error attempting to tidy a repo:
Pruning local branches that show as 'merged' to local ...
fatal: malformed object name --format=%(refname:short)

If there is some way to get more info -- like what the branch name is that's causing trouble -- that would be super-helpful. There's no more information, and tidy continues on (yay!).

Hi @HerbWarren!
Does the repo you used this on have a main or master branch as it's trunk branch? I played around with this a bit, and I'm guessing it does not and that is why the error is happening:
@HaywardMorihara ➜ /workspaces/gh-tidy (main) $ trunk_branch=
@HaywardMorihara ➜ /workspaces/gh-tidy (main) $ git branch --merged $trunk_branch --format='%(refname:short)'
fatal: malformed object name --format=%(refname:short)
@HaywardMorihara ➜ /workspaces/gh-tidy (main) $ git branch --merged main --format='%(refname:short)'
main
@HaywardMorihara ➜ /workspaces/gh-tidy (main) $ git branch --merged master --format='%(refname:short)'
fatal: malformed object name master

You can see the line where this command is executed here

Ah -- that also explains this line of output that I should have guessed was related:
Determined '' as the trunk branch
We do have a master branch on this repo, so that's a little odd, but the default branch is develop

Nah, let's do it! Let's add support for develop! I was actually working in another repo that has develop as the trunk branch and wasn't able to use this because of it so was thinking I should make this more flexible anyway. And support other potential branches as the trunk.
Also, maybe a more helpful error message if it isn't finding an appropriate trunk.
I'll try to get to it this weekend, or feel free to take a crack at it yourself and submit a pull request!

I didn't address the "more helpful error message" part, just the bare minimum to let someone specify their own trunk branch.

I made a couple of other tiny changes to help people find/use the new trunk option.

Awesome, thank you! Requested a couple of changes on the PR

Thought: this is a place where https://github.com/HaywardMorihara/gh-tidy/issues/43 would be nice


Add Parsers

See #277
cc @acburdine @knownasilya @acorncom
I'd love to get some extra eyes on this and feedback on the API changes.

This looks nice. I'll give it a whirl later this week.

The test failures here are the result of changes to the Action API, and the tests need to be updated to handle parsers (and expanded to test them as well). However, I'm holding off on this until the container refactor settles, since once that lands we should be able to shake out some unit test helpers, which in turn will mean refactoring these Action tests.

What's the progress on this?

Holding on this until the container PR lands/settles. The past few weeks have been a bit demanding of my time, so I haven't had much (read: any) spare time to devote here, but fear not, I haven't disappeared for good.
Comments and thoughts on the container PR are more than welcome - they will likely help it land faster hint hint.

Do we still need this PR or is it okay to close since the relevant changes are on the container-injections branch?

Yes, we can close - the container injections branch has this change.


Auto trigger post init hooks

What does this PR do?
Leverages attrs functionality to auto trigger post init hooks
Checklist

[x] Did you adhere to PEP-8 standards?

[x] Does your PR pass all existing unit tests?
[x] Did you add associated unit tests for any additional functionality?
[x] Did you provide documentation (Google Docstring format) whenever possible, even for simple functions or classes?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 96.014%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
1927

Relevant Lines:
2007

💛  - Coveralls


Go back to previous page after edit/update terms

Is your feature request related to a problem? Please describe.
Go back to previous page after edit/update terms.
Describe the solution you'd like
eg. You have 20 pages of terms, you go to page 11, edit and save one of those terms, and it should stay on page 11.
Describe alternatives you've considered
Use command+click to pop up a new window on macOS.
Additional context
I use phpMyAdmin instead for the moment.

Fixed in develop branch.  e.g:

click on "forwards", edit and save, and Lute goes back to same page:

This is in v1.1.7.

Verified in my install.  @99MengXin , please re-open if you install it and it doesn't work for you.  Cheers and thanks for the idea! z


⚠ Fetchers has degraded performance

In 71ccf02, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 266 ms

Resolved: Fetchers performance has improved in a3bb517.


svg-sprite's --sprite option is ignored

Looks like it's parsed and stored in the sprite variable, but that variable is unused and the sprite output uses the component name instead.

Fixed in v0.4.14


Add rules/discovery adapters for Amalgam8 controller/registry

Adapters based on the controller/registry clients
Refactor the caching clients as cache adapters
Refactor the FilterRules(Filter, []Rule) function as a Filter.Apply([]Rule) method, and add a fast path for empty filters.

@zcahana can we get rid of the amalgam8 term in the discovery/rules
adapters? We could call it "custom". Everything in this codebase is part of
a8 :), whether we use k8s backend or swarm backend or some custom backend.
On Sun, Dec 11, 2016 at 6:01 AM Zvi Cahana<EMAIL_ADDRESS>wrote:

Merged #440 https://github.com/amalgam8/amalgam8/pull/440.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/amalgam8/amalgam8/pull/440#event-889543633, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AH0qd-tXNq7GlkwdXyMXrMN_jmgbaa-Jks5rG9fugaJpZM4LJ46Z
.

--
~shriram


Improve GitHub Actions for pull requests

See https://github.com/Senzing/community-roadmap/issues/71

Pull requests:

https://github.com/Senzing/docker-aptdownloader/pull/32


Move away from LanguageServiceAccessor

We want to only format using the LSP server, we override LanguageServiceAccessor here:
https://github.com/themartdev/intellij-gleam/blob/9eea2c41723d6c2b99bf15e70b04545952b4f194/src/main/kotlin/com/github/themartdev/intellijgleam/ide/formatter/lsp/GleamAbstractLspFormattingServiceProxy.kt
With LSP4IJ 0.7.0, there should be a new way of achieving this behavior. See #22

fixed by 6df4db1590b459aad5334bdf0161b1d1b5d59ac3

Note: Need to wait for LSP4IJ v0.7.0

Probably not news anymore, but posting anyway: 0.7.0 was released on 15th :tada:


Suggestion api shows deleted entities.

Affected module
Backend
Describe the bug
Suggestion api shows deleted entities
To Reproduce
https://user-images.githubusercontent.com/83201188/156990256-80bf147e-2253-4564-9755-20e7327bb690.mov
https://user-images.githubusercontent.com/83201188/156990264-77d7ff7f-5f54-43ad-a376-081bbc3a39e4.mov
Expected behavior
A clear and concise description of what you expected to happen.
Suggestion API should not show deleted entity
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: [e.g. 0.8]
OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
cc @darth-coder00

this is fixed


Use the NgRx 8 create factory functions

Describe the feature you'd like:
The release of NgRx 8 gave us a way to define actions and reducers in a less verbose way with createAction and createReducer. I would like to see this project to use these functions and the new createEffect.
Other information:
I tried to list all of the features using NgRx here below.
Feel free to claim your own feature 🙂

[x] Auth
[ ] Settings
[x] CRUD (Books)
[x] Form
[x] Stock market
[x] Todos
[ ] google-analytics

We're here to guide you along the way.
(I will probably pick one feature in a couple of days, to get this started)

Also, here is a great blog post detailing how to do it in practice ! https://offering.solutions/blog/articles/2019/07/01/updating-your-angular-app-to-ngrx-8/

I'll work on CRUD part tonight.

@geromegrigon great, thanks ! 🔥

@evgenyfedorenko do you want to pick one up? Please don't feel obligated

@timdeschryver a bit slammed at the moment with other stuff. I will certainly consider doing it later.

Sure, feel free to check in at any point 🙂

Hi @timdeschryver ,
I can take few, let me know which part i can work on.

I was just about to pick up Auth myself, feel free to claim your own @santoshyadav198613

Cool @timdeschryver , working on one very old issue, as soon as it is done, will pickup Todos.

I am taking Form next.

@timdeschryver  this is coming together in a very nice speed ! Amazing community work!

@abedzantout thanks for your contribution but for furthers contributions you should communicate about your contribution to avoid people working both on the same part.
@santoshyadav198613 : Form part has been merged fyi.

Cool @geromegrignon , in that case taking settings.

@geronegrignon i’ll Be working on updating the settings also. Should be done soon

@geromegrignon i’ll Be working on updating the settings also. Should be done soon.
@santoshyadav want to help me with the tests ?

Oops i was already done with actions and effects, never mind please update before you start working to avoid rework.
Sure push the changes i will take care of test cases.

@santoshyadav198613 Please check PR

It seems like we have everything covered, thanks for your help! 🙌

Thanks for the epic contributions peeps ! 👍


libinput.accelProfile: improve docs & new default

The link to some (of course non-existing, i.e. freedesktop) “libinput”
documentation is replaced by a piece of the API documentation.
The default is changed since the documentation suggests adaptive should
be it.
https://wayland.freedesktop.org/libinput/doc/latest/group__config.html#gad63796972347f318b180e322e35cee79
Manual builds.

lgtm, whether adaptive is really the better default in all cases is not mine to judge.

@eskimor The manual states it’s the default, so we should make it the default imo.

fyi I found another minor bug in scrollButton and added it to the commit.

Changing the default value is an impacting change. Users will observe a behaviour change for their trackpad while nothing changed in their configuration.
May I suggest to change the option to a types.nullOr with an optionalString (just like cfg.accelSpeed for example)? Let the driver handle the default case, and the fallback to the second case. Use the option only to override the driver's decision.

@layus if that works I'm +1 on that, feel free to open a PR :)

May I suggest to change the option to a types.nullOr with an optionalString (just like cfg.accelSpeed for example)? Let the driver handle the default case, and the fallback to the second case. Use the option only to override the driver's decision

Sounds good. I’d keep the enum and the descriptions of flat and adaptive and additionally link to the API for the relevant function.


Make Ebiten work on Unity

We need a Go compiler backend to produce MSIL code, maybe?

https://github.com/GridProtectionAlliance/go2cs

Succeeded to convert to C# (MonoGame), but we abandoned this. See #1148


Statement/Branch coverage for all tests

Adding Statement/Branch Coverage to Treadle
The idea was to modify the treadle tester so that it would make certain modifications to the given FIRRTL source code in order to track the line coverage. Once that was done, we needed to check these additional ports and compile the results in a line coverage report. The modifications related to this work can be found here. Note that coverage can be enabled using the EnableCoverage annotation.
Modifying the input FIRRTL code
The first thing that needed to be done was to add ports to the given design. This is done depending on the amount of multiplexers that are in the design, since any code that isn't in a multiplexer is executed by default. The idea would thus be to do the following:

Parse the input FIRRTL code to find:

The location of the i/o declaration
The locations of every multiplexer in the design
The total number of multiplexers

Add additional coverage validator outputs in the i/o declaration part of the code. The idea is to add 2 additional 1-bit ports per multiplexer.
At each multiplexer use in the FIRRTL source, output the path taken to 2 coverage validators as follows:out_a <= mux(cond, in_a, in_b)  //Example use of a multiplexer
io_cov_valid_1 <= cond
io_cov_valid_2 <= not(cond)  //Use of coverage validators to keep track of the path that was taken

These are all of the modifications that are needed to keep track of line coverage during a simulation.
Generating a Coverage report
The main work here was interpreting the meaning of the outputs added to the FIRRTL source. The idea here was to do a second pass of the coverage parser once a given test was done. The big difference now is that we have access to the values of the different coverage validators, which allows us to know which multiplexer paths were taken during the different tests. So we can compile the data retrieved from the coverage validators througout an entire test suite to find out which paths were taken and which were skipped. The results are then shown in a coverage report that has the following structure:
COVERAGE: 50.0% of multiplexer paths tested
COVERAGE REPORT:

+ circuit Test_1 :
+   module Test_1 :
+     input io_a : UInt<1>
+     input io_b_0 : UInt<2>
+     input io_b_1 : UInt<2>
+     input clock : Clock
+     output io_cov_valid_0 : UInt<1>
+     output io_cov_valid_1 : UInt<1>
+     output out : UInt<2>
+
+     io_cov_valid_0 <= io_a
-     io_cov_valid_1 <= not(io_a)
+     out <= mux(io_a, io_b_0, io_b_1)

Here the first line gives a general percentage of how many of the possible control paths were taken and then the COVERAGE REPORT shows a modified version of the FIRRTL source with coverage prefixes added to each line:

+ means that the line was covered by a test in the test suite.
- means that the line was missed during all of the test suite's tests.

Interpreting the Coverage Report
What this report tells us (in the above example) is that one of our artificially added FIRRTL lines wasn't covered. This information can be used to deduce which path of our multiplexer was taken. For example, the above COVERAGE REPORT:
+     io_cov_valid_0 <= io_a
-     io_cov_valid_1 <= not(io_a)
+     out <= mux(io_a, io_b_0, io_b_1)

actually tells us that the case where io_a == 0 was never tested and thus one of our potential outputs was never tested.
Mapping loFIRRTL to Chisel
One could discuss the usefulness of having line coverage on Chisel code. One main case where this would not be as helpful would be when writing hardware generators, since there the notion of coverage isn't as clear: Has the hardware generator been tested? or more interestingly Has the generated hardware been tested?. I think that this question is open to discussion. This coverage report is thus given at the FIRRTL level but an other interesting report would contain the same line coverage information, shown directly in our original source description.
Future work on this part of the project could thus be to find a way to map the results to the original Chisel source using source locators. An other version of the coverage report would thus be:
COVERAGE: 50.0% of multiplexer paths tested
COVERAGE REPORT:

+ circuit Test_1 :
+   module Test_1 :
+     input io_a : UInt<1>
+     input io_b_0 : UInt<2>
+     input io_b_1 : UInt<2>
+     input clock : Clock
+     output io_cov_valid_0 : UInt<1>
+     output io_cov_valid_1 : UInt<1>
+     output out : UInt<2>
+
+     io_cov_valid_0 <= io_a
-     io_cov_valid_1 <= not(io_a)
+     out <= mux(io_a, io_b_0, io_b_1)

NEW REPORT:

+ class Test_1 extends Module {
+    val io = IO(new Bundle {
+        val a = Input(UInt(1.W))
+        val b = Input(Vec(2, UInt(2.W)))
+        val out = Output(UInt(2.W))
+    })
+    when(io.a) {
+        out := io.b(0)
-    }.otherwise {
-        out := io.b(1)
+    }
+ }

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for the PR Andrew, this is great!
I really like the thought you put into how to communicate the coverage results back to the user.
Some notes on how this could be improved:

Ideally you should try to write a firrtl pass over the firrtl compiler data structures instead of working on the string representation directly. This will make some of the current short comings much easier to solve.
Currently you name the outputs without checking whether that name is already used in the module. The firrtl compiler provides a Namespace class to help you automatically resolve any potential name clashes.
You seem to connect the coverage information to outputs of the module, however, how is this going to work for a design that has a module hierarchy? Here the firrtl compiler also features some helpers (namely the WiringTransform which can connect arbitrary wires/outputs throughout the module hierarchy).
An interesting variation on your current approach for connecting the coverage signals might be to use the new cover statement. This way you would not have to worry about finding a unique name (cover statements are not named) or wiring things through the hierarchy. Unfortunately, treadle does not have support for cover statements yet, however, it is on the radar to implement and I think it would be great if you could give @chick some feedback on what you would expect from an implementation. For example, assuming that you have a pass to insert cover statements for all mux conditions, in which format would you expect treadle to report the results so that you can then use them to generate your coverage report?

For high firrtl / Chisel coverage it might be interesting to consider the pass that Daniel Kasza has been working on: https://github.com/danielkasza/dank-formal/blob/main/src/main/scala/transforms.scala#L13 He is essentially adding cover statements for all branches in high firrtl. This information should be enough to calculate the line and branch coverage and you could try to map it back to the Chisel source using the FileInfo that is attached to every firrtl statement.

Thanks a lot for the quick response!
I completely agree with the comments, this solution felt a bit brute-force-y when I implemented it.
I'll try to change my solution so that it uses the firrtl compiler rather than string parsing, as you suggested.Once that's done hopefully other problems will be easier to solve.
Thanks again for the review!

Thanks a lot for the quick response!

Thanks for the PR!

I completely agree with the comments, this solution felt a bit brute-force-y when I implemented it.
I'll try to change my solution so that it uses the firrtl compiler rather than string parsing, as you suggested.Once that's done hopefully other problems will be easier to solve.

I know that writing your first firrtl pass is hard since there is very little documentation. Feel free to ask any questions that come up on the firrtl gitter: https://gitter.im/freechipsproject/firrtl

New Version of the Statement Coverage PR
As per the request, the coverage parser that was used to add additional coverage ports to the source code, via string parsing, was converted into a firrtl pass.
FIRRTL pass
A firrtl pass AddCoverageExpressions was created, which takes care of adding the additional coverage ports that were previously done using brute-force string parsing.
This now uses the Namespace of the module it's working on to make sure that no name collisions can occur and also handles multi-module circuits.
Coverage package object
The coverage package object defines a new Info child class that allows us to store the names of the newly added ports in the circuit's info. These names are then used when compiling the final report (which is still done by modifying the original source code's string for printing purposes).
The package also defines a Ledger class, similar to the one shown in the firrtl wiki. This class is used to keep track of the number of multiplexers in the design as well as maintaining references to the ports that were added in order to add them to the circuit's info at the end of the pass.
Coverage
The Coverage class, which was previously named CoverageReporter, now uses the information stored in the circuit's info field to generate the final coverage report rather than parsing the source string a bunch of times.
Let me know if ever there's anything that still needs to be changed/improved !

Thanks a lot for the review @ekiwi , your comments make a lot of sense, I'll get right to it!

I missed one other suggestion for how to schedule and run the pass. I think you should add this to AddCoverageExpressions
  /** Only run this pass if there is an EnableCoverageAnnotation present
    *
    * @param state
    * @return
    */
  override def execute(state: CircuitState): CircuitState = {
    if(state.annotations.contains(EnableCoverageAnnotation)) {
      state.copy(circuit = run(state.circuit))
    } else {
      state
    }
  }

@ekiwi any other thoughts

I think it is a fine implementation for the time being. Maybe we could mark it as experimental to allow for future API breaks.
The next step would require us to implement support for the cover statement in treadle. This way we can replace the output ports with cover statements which would almost automatically make this work for submodules as well. @Dobios work can serve as a good use-case example to see how a custom coverage report generator might want to plug into a generic cover statement implementation. I.e., the idea would be that treadle can load coverage report generator classes that analyze the coverage and turn it into a human readable report.

@ekiwi any other thoughts

I think it is a fine implementation for the time being. Maybe we could mark it as experimental to allow for future API breaks.

Nice thanks!

The next step would require us to implement support for the cover statement in treadle. This way we can replace the output ports with cover statements which would almost automatically make this work for submodules as well. @Dobios work can serve as a good use-case example to see how a custom coverage report generator might want to plug into a generic cover statement implementation. I.e., the idea would be that treadle can load coverage report generator classes that analyze the coverage and turn it into a human readable report.

I did see that since I've implemented the first version of this the cover statement was added to Chisel, it does seem like a more elegant solution. Is anyone currently working on adding it to Treadle?

To backport this to 1.3.x, we should tweak the change to TreadleOptions to use https://github.com/alexarchambault/data-class
Basically, define the copy and unapply methods as they exist today (well, before this change), and then change it from a case class to @data.

To backport this to 1.3.x, we should tweak the change to TreadleOptions to use https://github.com/alexarchambault/data-class

I don't think this needs to be backported. This is more of a technology demo and not really ready for production usage anyways. Like currently it only works if you only have a single module in your design.

Makes sense, fair enough. Getting the SNAPSHOT autopublishing in will be nice so people can try it out using the SNAPSHOT.


esp_http_client_get_chunk_length() for chunked responses (IDFGH-3319)

In the past I have successfully used the esp-http-client, and it was really simple exchanging headers and then receiving the data length specified in the content-length reply header. But now I am interfacing an API that responds with chunked transfers. Chunked responses lack the content-length header, and currently the API does not allow obtaining the current chunk length. esp_http_client_fetch_headers() returns a length of 0 bytes, and esp_http_client_get_content_length() returns -1 for chunked transfers.
Since each chunk length is written just before the chunk starts, it should be easy writing a function, something like esp_http_client_get_chunk_length() to get the current chunk length of chunked responses.

@doragasu Thanks for raising this feature request.

@doragasu ,
Can you share the use case of this API and details about the chunked server you are using? Is it a local server or an online server?

This behavior occurs when interfacing GameJolt Game API: https://gamejolt.com/game-api/doc
You can test for example against the following API call: https://api.gamejolt.com/api/game/v1_2/time/?game_id=496055&format=keypair&signature=4756d315673a00abd4f60966bb12c8b135f5be80
When doing the call above, debug log shows this:
D (10303) http_url_set: init, HTTP URL: https://api.gamejolt.com/api/game/v1_2/time/?game_id=496055&format=keypair&signature=4756d315673a00abd4f60966bb12c8b135f5be80
W (10318) http_init: no valid certificate found, len 8192000, start: 0
D (10327) http_method_set: set method 0
D (10329) http_method_set: HTTP method: 0
D (10332) http_open: opening
D (10335) HTTP_CLIENT: Begin connect to: https://api.gamejolt.com:443
D (10341) esp-tls: host:api.gamejolt.com: strlen 16
D (11625) esp-tls: handshake in progress...
D (15832) HTTP_CLIENT: Write header[3]: GET /api/game/v1_2/time/?game_id=496055&format=keypair&signature=4756d315673a00abd4f60966bb12c8b135f5be80 HTTP/1.1
User-Agent: ESP32 HTTP Client/1.0
Host: api.gamejolt.com
Content-Length: 0

D (15852) http_open: HTTP open OK, 0 bytes
D (16003) HTTP_CLIENT: on_message_begin
D (16005) HTTP_CLIENT: HEADER=Server:nginx
D (16008) HTTP_CLIENT: HEADER=Date:Sat, 30 May 2020 07:00:49 GMT
D (16011) HTTP_CLIENT: HEADER=Content-Type:text/plain;charset=UTF-8
D (16015) HTTP_CLIENT: HEADER=Transfer-Encoding:chunked
D (16018) HTTP_CLIENT: HEADER=Vary:Accept-Encoding
D (16022) HTTP_CLIENT: HEADER=Expires:Sat, 30 May 2020 07:00:48 GMT
D (16028) HTTP_CLIENT: HEADER=Cache-Control:no-cache
D (16033) HTTP_CLIENT: HEADER=Access-Control-Allow-Origin:*
D (16038) HTTP_CLIENT: HEADER=Access-Control-Allow-Credentials:false
D (16044) HTTP_CLIENT: http_on_headers_complete, status=200, offset=300, nread=300
D (16052) HTTP_CLIENT: http_on_body 138
D (16055) HTTP_CLIENT: http_on_chunk_complete
D (16059) HTTP_CLIENT: http_on_chunk_complete
D (16063) HTTP_CLIENT: http_on_message_complete, parser=40107e1c
D (16069) HTTP_CLIENT: content_length = -1
D (16073) http_finish: HTTP finish: 200:<PHONE_NUMBER> bytes
D (16087) HTTP_CLIENT: is_data_remain=0, is_chunked=1
D (16099) HTTP_CLIENT: is_data_remain=0, is_chunked=1
I (16102) http_recv: server closed the connection

The HTTP client works, but there is no way to get the chunk length in advance. That is what I am requesting, to implement a function to get chunk length in advance.

Thanks!!!


“-c requires argument”, but it has one

Python docopt works OK for simple cases, but in this case it keeps saying -c requires argument, despite it having an argument.
Minimal code (Python 3.6):
'''Usage:
test_docopt.py x YYY ZZZ [-a AAA] [-b BBB] [-c CCC]

Options:
   -a AAA  description
   -b BBB  description
   -c CCC  description'''

from docopt import docopt

print(docopt(__doc__))

Result:
C:\>python3 test_docopt.py x foo bar -a alpha -b bravo -c charlie
-c requires argument
Usage:
    test_docopt.py x YYY ZZZ [-a AAA] [-b BBB] [-c CCC]

C:\>

What am I doing wrong?

I looked into this. It seems likely you've moved on by now, but the lowercase x is parsed as a Command not an Argument. It works fine with a capital X. Can't yet explain why this is the case, but, compare:

Required(Required(Command('x', False), Argument('YYY', None), Argument('ZZZ', None), Optional(Option('-a', None, 1, None)), Optional(Option('-b', None, 1, None)), Optional(Option('-c', None, 1, None))))

with the working:

Required(Required(Argument('X', None), Argument('YYY', None), Argument('ZZZ', None), Optional(Option('-a', None, 1, None)), Optional(Option('-b', None, 1, None)), Optional(Option('-c', None, 1, None))))

Docopt really needs better debugging tools... :)

So my workaround above is functional but not what you intended.
The root of the issue is just that you didn't indent the line after Usage:...
'''Usage:
    test_docopt.py x YYY ZZZ [-a AAA] [-b BBB] [-c CCC]

Options:
   -a AAA  description
   -b BBB  description
   -c CCC  description'''

from docopt import docopt

print(docopt(__doc__))

works fine :)


⚠ Bofrost.nl has degraded performance

In aaaa746, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1536 ms

Resolved: Bofrost.nl performance has improved in 9b9f062.


Update to latest versions of the test-retry and test-distribution plugin

@jonnybbb Why is this PR against release?

@wolfs there is no real need to go into release. The changes we did for the test-retry plugin (https://github.com/gradle/test-retry-gradle-plugin/pull/60/files#diff-4b43e8bcfe035c6cc7635d5645e82d2aR67) fixed a compatibility issue with gradle 6.6 (TestNG only) and a deprecation warning releated to the configuration cache feature (https://gradle.slack.com/archives/C012L0276KF/p1595342462336600).
The test-distribution plugin does not have to go into release either - if you apply it you will benefit from a better performance (https://docs.gradle.com/enterprise/test-distribution-gradle-plugin/#history).

We are not going to upgrade the versions on release. Replaced by https://github.com/gradle/gradle/pull/14025 for master.


[device_info_plus] update versions for publishing

Description
Right now using published versions of device_info_plus on Windows and Linux fails with Flutter 2.8.1. #574 and #598 needs publishing. Fixes #646.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@nohli should we merge this and release it? if so, then how about this one? https://github.com/fluttercommunity/plus_plugins/pull/671

@nohli should we merge this and release it? if so, then how about this one? https://github.com/fluttercommunity/plus_plugins/pull/671

@mhadaily I would merge it. Since the other PR is just updating the changelog for changes that are already merged, I will then rebase it, so it can be merged, and then we release a new version including all PRs? What so you think?

@mhadaily I would merge it. Since the other PR is just updating the changelog for changes that are already merged, I will then rebase it, so it can be merged, and then we release a new version including all PRs? What so you think?

@nohli  Happy new year too! sounds good. let's do it

@nohli  Happy new year too! sounds good. let's do it


Material-UI V1 website is down

[x] This is a v1.x issue (v0.x is no longer maintained).
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Material-UI website is down for some reason, is there maintenance currently going on?

Seems to be on Yandex navigator, nvm.


Fail to Install, please help

pip install signalr-client-aio
Collecting signalr-client-aio
Using cached https://files.pythonhosted.org/packages/83/90/82d1e2feffb173ad9d9c9e25f395eabec11c3426b5cb134a689227222d5d/signalr_client_aio-<IP_ADDRESS>.2-py2.py3-none-any.whl
Requirement already satisfied: requests>=2.18.4 in c:\users\terminal-3\anaconda3\lib\site-packages (from signalr-client-aio) (2.21.0)
Collecting websockets>=4.0.1 (from signalr-client-aio)
Using cached https://files.pythonhosted.org/packages/9c/60/f96f535f3354cb6ba5e5c7ab128b1c4802a2d040ee7225e3fe51242816c1/websockets-8.0.2-cp37-cp37m-win_amd64.whl
Requirement already satisfied: certifi>=2017.4.17 in c:\users\terminal-3\anaconda3\lib\site-packages (from requests>=2.18.4->signalr-client-aio) (2018.11.29)
Requirement already satisfied: idna<2.9,>=2.5 in c:\users\terminal-3\anaconda3\lib\site-packages (from requests>=2.18.4->signalr-client-aio) (2.8)
Requirement already satisfied: urllib3<1.25,>=1.21.1 in c:\users\terminal-3\anaconda3\lib\site-packages (from requests>=2.18.4->signalr-client-aio) (1.24.1)
Requirement already satisfied: chardet<3.1.0,>=3.0.2 in c:\users\terminal-3\anaconda3\lib\site-packages (from requests>=2.18.4->signalr-client-aio) (3.0.4)
Could not install packages due to an EnvironmentError: [Errno 2] No such file or directory: 'c:\users\terminal-3\anaconda3\lib\site-packages\pandas-0.24.2.dist-info\METADATA'

Python version? Are you installing in a clear venv?


Add names to grammar nodes

Right now only dictionaries have names. All nodes should, for better error handling

Fixed in 0.1.2


Feature request: Ruby gem

Given the major improvements to Ruby on Rails in the last two versions, to the point it has eclipsed even Node based web solutions even it its areas of historical weakness (e.g. post-deployment speed) I plan to work primarily in Ruby from now on, and foresee many others doing the same. This will likely also affect my preferences in CLI apps, and when I begin writing these it will be in Ruby as first preference over Node, Python, Bash script etc, due in large part to the elegance and coder-friendliness of the language, as well as the fact I will be using Rails elsewhere, so advanced knowledge of the language will necessitate some degree of specialization.
As such, and accepting that even Rails utilizes JavaScript when unavoidable, as there any chance of a version of this library that's a Ruby gem?

You should check : https://github.com/markets/awesome-ruby#cli-builder

I don't think this will happen. Closing this.


Issue 147 solarthermal

Do you see any potential problems with this pull request? It would be nice if you integrated it into the master. Thanks!


Can't deploy on OpenShift 4.7.2

When trying to deploy the controller, the pod gets into CreateContainerError state, with the following error:
container create failed: time="2021-03-02T12:02:28Z" level=error msg="container_linux.go:366: starting container process caused: chdir to cwd ("/home/nonroot") set in config.json failed: permission denied"

Have found similar problems, the controller is running under different User, not 65532 as expected by the gcr.io/distroless/static:nonroot image.
https://bugzilla.redhat.com/show_bug.cgi?id=1934177


Bug 1311024 - Fix the sample job xml to match current example

@bparees fixed... i think the sample-app job should now work with the sample-app source


Improved URL escaping for searches.

Fixes #345

Add XCTestCase-based unit test harness
Refactor URL escaping into a helper class
Add tests for URL escaping
Improve URL escaping
Verify that searches for "915 Northwest 45th Street, Seattle, WA 98107" now work properly.

:+1: for tests

hmph, looks like i'm going to have to fight with Travis a bit. @bbodenmiller if you have any ideas on how to deal with this error, I'd love your input:
There was a problem starting the test bundle: Testing with the 'iphoneos' SDK
is not yet supported.  Instead, test with the simulator SDK by setting '-sdk iphonesimulator'.


feat(linter): no-irregular-whitespace rule

Parser, trivias and trivias_builder were edited to get all whitespaces. Now Trivias struct store comments and whitespaces Vec. After that, i will implement the no-irregular-whitespace rule.
P.S.: There isn't a way to implement this feature without lose a little bit of performance, comparing with my last PR #1819 to minimax this trouble instead of store the irregular whitespace as Span it was stored as u32, i removed a map iterator and removed too a unused function. If you have a suggestion about it pls give me a feedback.

Can we just implement the rule in eslint way, https://github.com/eslint/eslint/blob/main/lib/rules/no-irregular-whitespace.js, they just use source code to detect irregular whitespace rule, https://github.com/eslint/eslint/blob/main/lib/rules/no-irregular-whitespace.js#L203-L205

Because lexer is the infra of the Javascript tools, not only linter use it, transformer, formatter, minifier would use it too.

Hi @IWANABETHATGUY thanks for your feedback, I did this way because in the insure of these feature @Boshen suggest to edit the parser and store it in a vec

https://github.com/oxc-project/oxc/issues/612

in discord channel

but i am just wait you decide what way should i proceed, both way are well.

Let's just hold this pull request, and wait @Boshen to take a look.

To minimize the performance impact, we should only store the irregular whitespaces
https://github.com/oxc-project/oxc/blob/1f3f21d722d22f97f20d9d2b47050dc86e185660/crates/oxc_parser/src/lexer/mod.rs#L360

done!


[data-export]: "Add deleted records?" label change to "Deleted/Archived Records?"

Data Export has an option labeled "Add deleted records?".
Request: change this label to indicate that option covers archived records as well as deleted records
Reason: several admins were falling back to SF Dataloader because they didn't know SF Inspector could export the archived records they needed
Current

Proposed

Hi @mckayhowell you are right this is not clear at the moment.
I updated the label 👍
https://github.com/tprouvot/Salesforce-Inspector-reloaded/commit/2db5e8314517e476bb1c585f1baaac2da2875a13


cortile tile for xfce not working for css tweaked firefox

i have a tweaked firefox that has the address bar at the same level of close button, this is done with css modification, cortile is note correctly managing that, firefox does not adhere to the cortile rules.

Cortile uses xgb to communicate with the X server. Any customs modifications on the client side (like css) are not part of the EWMH specification and can't be accessed.
If you want to use cortile, consider removing any client side custom decorations.


Move to lambda.

Please answer these questions before submitting pull request

Why submit this pull request?
[ ] Bug fix
[x] New feature provided
[ ] Improve performance

As compile in 1.8. move code to lambda.

Like I mentioned multiple times, please don't focus on coding style. Lamda or not, what is the matter?

ok, i won't.


raft 1.0 release

To release 1.0, we need to solve following issues:

[ ] Add examples
[ ] Enhance documentations
[ ] Review all APIs for proper access level

Looking at the access level, one issues seems to be that the way the tests are set up requires making all kinds of internals public. Maybe it would make sense to move those tests into the relevant modules (in a #[cfg(test)] module, of course) in order to enable more restricted access on internals.

One problem with isolating these sorts of details to #[cfg(test)] only is you cannot use them in benchmarking code. In order to refine this we'll probably need to have some sort of feature = ["simulator"] or something.


Enhancement: use local git user for stub runner by default

I want to run my stubs that are stored in Git without having to provide git username and password. The stub runner must be able to just use my local git account, that I am using with Git CLI.
version 2.1.2.RELEASE, maven runner

I'm sorry but can you create the issue properly from the beginning until the end? I have no idea what the problem is, for which version, what you did and what you're planning to do.

updated

What did you update? This issue?
Can you please read the comment we're providing for better issue creation when you click on the New issue? I'll paste it for your convinience
<!--
Thanks for raising a Spring Cloud issue. What sort of issue are you raising?

Question

Please ask questions about how to use something, or to understand why something isn't
working as you expect it to, on Stack Overflow using the spring-cloud tag.

Bug report

Please provide details of the problem, including the version of Spring Cloud that you
are using. If possible, please provide a test case or sample application that reproduces
the problem. This makes it much easier for us to diagnose the problem and to verify that
we have fixed it.

Enhancement

Please start by describing the problem that you are trying to solve. There may already
be a solution, or there may be a way to solve it that you hadn't considered.
-->

Also please read on how to ask a good question on SO (it can give you pointers to how ask good questions on GitHub too) - https://stackoverflow.com/help/how-to-ask

I meant that I'd edited the description, i.e. the first comment. I don't really know what to add, don't have time to set up a whole project but basically, when using any stub runner and specifying contractsRepositoryUrl property as a Git repository (starts from git://...) then it required me to also provide contractsRepositoryUsername  and contractsRepositoryPassword (given my repository is private) because authentication fails without these.
The suggestion is to use local Git user credentials by default. Here is my reasoning:
I am writing code on my machine, so when I run my tests, I don't want to explicitly supply credentials to a git repository I already have access to using my CLI or IDE. Just like my IDE, I want this tool to recognize my local git user and use that. For CI it would be fine, but again, the CI could also use a git user.
Hopefully, that's clear enough.

Found #1205 and your response actually solves my problem! If I execute these 2 lines then I don't need to provide username and password, which is exactly what my concern was. https://github.com/spring-cloud/spring-cloud-contract/issues/1205#issuecomment-528431188
I suggest updating the documentation. Otherwise, the issue may be closed

Great, are you willing to do a PR? :) That would be a nice contribution (over here I guess https://github.com/spring-cloud/spring-cloud-contract/blob/master/docs/src/main/asciidoc/howto.adoc#how-can-i-use-git-as-the-storage-for-contracts-and-stubs)


Add length token filter docs #8152

Description
Add length token filter docs
Issues Resolved
Closes https://github.com/opensearch-project/documentation-website/issues/8152
Version
all
Checklist

[x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@udabhas Will you review this PR for technical accuracy? Thank you.

@udabhas Will you review this PR for technical accuracy? Thank you.

@udabhas @varun-lodaya This is a month old. We need tech review approval to move it forward in the documentation process. Please review this week or provide a peer who can review it. Thank you.


EXC_BAD_ACCESS when socket reconnects

Hi, i have a crash when trying to restore socket connection. I've written a simple WebSocket extension with method that counts reconnection tries and reconnects according to RFC:
extension WebSocket {
    private struct AssociatedKeys {
        static var currentTry: UInt8 = 0
    }

    private func maxReconnectTries() -> Int {
        return 4
    }

    var currentConnectionTry: Int {
        get {
            guard let value = objc_getAssociatedObject(self, &AssociatedKeys.currentTry) as? Int else {
                return 0
            }
            return value
        }
        set(newValue) {
            objc_setAssociatedObject(self, &AssociatedKeys.currentTry, newValue, objc_AssociationPolicy.OBJC_ASSOCIATION_RETAIN_NONATOMIC)
        }
    }

    func tryConnect(){
        self.currentConnectionTry+=1
        logDebug("Connecting web socket:\(self), try:\(currentConnectionTry)")
        guard self.currentConnectionTry > 1 else {
            self.connect() //crash here
            return
        }
        let currentTry = self.currentConnectionTry
        if currentTry <= maxReconnectTries() {
            DispatchQueue.main.asyncAfter(deadline: .now() + .seconds(self.getDelay(forTry: currentTry)), execute: {
                self.connect()
            })
        }
    }

    private func getDelay(forTry currentTry: Int) -> Int {
        let maxInterval = Int(pow(Double(2), Double(currentTry))) - 1
        let minInterval = Int(pow(Double(2), Double(currentTry-1))) - 1
        let delay = randomNumber(inRange: minInterval...maxInterval)
        logDebug("Will reconnect socket in:\(delay) seconds")
        return delay
    }

    private func randomNumber<T : SignedInteger>(inRange range: ClosedRange<T> = 1...6) -> T {
        let length = Int64(range.upperBound - range.lowerBound + 1)
        let value = Int64(arc4random()) % length + Int64(range.lowerBound)
        return T(value)
    }
}

method tryConnect() is called in websocketDidDisconnect delegate method.  Do you have any idea what may be wrong?

Made some investigation: it crashed even if call socket.connect() in websocketDidDisconnect delegate method.
#0	0x000000010adc384a in CFReadStreamCopyProperty ()
#1	0x000000010acbc2a8 in SEL_retain ()
#2	0x00000001056726d7 in FoundationStream.connect(url:port:timeout:ssl:completion:) ()
#3	0x0000000105676d45 in protocol witness for WSStream.connect(url:port:timeout:ssl:completion:) in conformance FoundationStream ()
#4	0x00000001056852c2 in WebSocket.initStreamsWithData(::) ()
#5	0x0000000105684211 in WebSocket.createHTTPRequest() ()
#6	0x0000000105680221 in WebSocket.connect() ()
#7	0x0000000102c40302 in WebSocketDelegate.websocketDidDisconnect(socket:error:)

We refactored a lot with #653. If this continues to happen then we can reopen this issue.


Merging ConnectedVMwarevSphere changes from azure-rest-api-specs-pr private repo...

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

Microsoft.ConnectedVMwarevSphere is in private preview and we are targeting for public preview by Oct end. All the changes are already ARM approved and signed off. This PR  is to merge those changes to the public repo to get ready for the public preview. Here are the approved changes https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/connectedvmware. All the changes are exactly same as https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/connectedvmware which are already ARM reviewed and approved. There were few lint issues were fixed and hybridmetadata resource we are not using to public preview.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
Oct end 2021

When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
Oct end 2021

If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No refresh required for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in a stable version
[ ] Removing properties in a stable version
[ ] Removing API version(s) in a stable version
[ ] Updating API in a stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

/azp run

@subbartt, thanks for including the very helpful context. I've looked at the changes. Some of the changes you are making here (removing two resource type endpoints, adding properties to existing resource types) require a new API version. To get ARM review on a new API version, you will need to make a new PR and ensure that the first commit is the unchanged previous API version files (the ones from the private repo).

@subbartt, thanks for including the very helpful context. I've looked at the changes. Some of the changes you are making here (removing two resource type endpoints, adding properties to existing resource types) require a new API version. To get ARM review on a new API version, you will need to make a new PR and ensure that the first commit is the unchanged previous API version files (the ones from the private repo).

@mentat9 , adding new properties already PR in private repo and merged today https://github.com/Azure/azure-rest-api-specs-pr/pull/4931. Also after discussing with team internally we have decided not to remove any endpoints. Now both private repo swagger and public repo swagger are exactly the same ( except few lint fixes).

@mentat9 , can you please help merge the PR? we are good to merge and move onto next steps.

@mentat9 , can you please help merge the PR? we are good to merge and move onto next steps.

ARM team doesn't approve or merge PRs. The SDK owners and assignee @akning-ms will move it forward.


Custom rules configmap

Which problem is this PR solving?
When creating sampling rules for a larger amount of datasets with Honeycomb Classic using the current method, the Values file gets larger and larger and harder to maintain. This PR is to enable users to pass in the name of their own configmap.
My particular use case is using Refinery as a subchart inside of a larger parent chart. If I have my own ConfigMap template, I will the be able to use templating to merge a collection of YAML within the files/ directory of my parent chart. This will enable the possibility of a YAML file per dataset. All of the files will get merged in to one value for the key rules.yaml as expected.  However, it's up. to the user to figure this out.
The default behavior is to work as is.

Closes #

Short description of the changes
Added logic to only create a configmap for rules if the user doesnt add a name for a different configmap to use.  The name field for the rules configmap in the deployment is either the default or the name passed in the vaules file.
How to verify that this has the expected result
If the name for the custom configmap for rules is left blank you get
RulesConfigMapName:

helm template .
volumes:
- name: refinery-config
projected:
sources:
- configMap:
name: release-name-refinery-config
items:
- key: config.yaml
path: config.yaml
- configMap:
- name: release-name-refinery-rules
items:
- key: rules.yaml
path: rules.yaml

If it's set you get
helm template .
RulesConfigMapName: "customName"

volumes:
- name: refinery-config
projected:
sources:
- configMap:
name: release-name-refinery-config
items:
- key: config.yaml
path: config.yaml
- configMap:
- name: customName
items:
- key: rules.yaml
path: rules.yaml

Thanks @teaguecole 🎉

@MikeGoldsmith looking at the contribution docs and the history of releases, it appears that releases for refinery helm chart come out roughly every month?  Just trying to ballpark estimate when I can expect to see this come through.

@teaguecole we don't have a set cadence for these tools, it's when we have something to release. I'll look to process a release soon.


Propagate method type signatures from classes to instances

Let's say we have the following:
class MyClass a where
  myMethod : someType a

instance MyClass MyType where
  myMethod = impl

Currently infer the type of impl and then check that it subsumes someType MyType. It would be better to check impl against someType MyType to start with, as we can then get better inference of constructor types and dependent types, and additionally get better code since the generalised version of impl may have implicit arguments in a different order than someType MyType.

This seems to require the "declassify" pass, which desugars classes, to be interleaved with typechecking, since we need to be working in abstract syntax and not concrete syntax to properly construct the instantiations of the method types.
Now that https://github.com/ollef/sixten/issues/54 has been fixed you can write out the signature explicitly as a workaround, though any instance context needs to be added to the explicit signature.
When fixing this issue, the instance context, i.e. the MyClass a => part of instance MyClass a => MyClass (List a), should probably be implicitly added to explicitly given signatures.


New release?

Hi,
any chance of getting a new release with the group by foreign key fields fix (#28) included?

Hello !!
I released it as very soon after the merge ... it's an awesome addition !
https://pypi.org/project/django-slick-reporting/ version 5.7


[BEAM-7772] remove pkb from JDBCIOIT, HadoopFormatIOIT

Removes perfkit usage from JDBC and HadoopFromat ioit tests.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run seed job

Run Java TextIO Performance Test HDFS

Run Java TextIO Performance Test

Run Java JdbcIO Performance Test

Run Java HadoopFormatIO Performance Test

Run Java ParquetIO Performance Test

Run seed job

Run seed job

Run Java HadoopFormatIO Performance Test

Run Java JdbcIO Performance Test

Run Java ParquetIO Performance Test

Run Java TextIO Performance Test HDFS

Run Java JdbcIO Performance Test

Run seed job

Run seed job

Run Java JdbcIO Performance Test

Run Java HadoopFormatIO Performance Test

Run Java TextIO Performance Test HDFS

@lgajowy LGTM, thank you for the refactor!


Fixed KCA Sink handling of Json and Avro; support for kafka connectors that overload task.preCommit() directly

Motivation

Kafka Connect Sink expects KC Data Struct instead of Avro or Json.
at some version of Kafka Connect, tasks got preCommit() method with default implementation that simply calls flush(). Some tasks override preCommit() directly, now KCA Sink supports it.

Modifications

support for preCommit()
Avro and Json remapped into Kafka's Struct for the sinks to handle the data correctly
updated unit tests

Verifying this change

[ ] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

updated tests in KafkaConnectSinkTest

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
No
Documentation

[X] no-need-doc

no changes in API

@congbobo184 are you happy now with this patch ?


[windows] onDurationChanged return -256204778:48:05.477000 in play local file

 Flutter (Channel stable, 3.3.10, on Microsoft Windows [版本 10.0.19045.2486], locale zh-CN)
    • Flutter version 3.3.10 on channel stable at D:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 135454af32 (4 weeks ago), 2022-12-15 07:36:55 -0800
    • Engine revision 3316dd8728
    • Dart version 2.18.6
    • DevTools version 2.15.0

Which AudioPlayers version do you use?

audioplayers: ^2.0.0
final player = AudioPlayer(playerId: 'my_unique_playerId');

await player.play(DeviceFileSource('E:\Music\分飞.m4a'));

player.onDurationChanged.listen((Duration d) {
  print('d');
  print(d);
  duration.value = d.inSeconds < 0 ? const Duration(seconds: 0) : d;
});

Sorry I meant the audio file... ;D Best regards

Sorry.
分飞.zip
The same is true for other MP3 files, audioplayers will return the result twice, and the second time is correct.

This will help https://www.youtube.com/watch?v=IMQdSTlTXjA

Ok this is due to the play statement, which doesn't wait until the player has buffered enough audio to determine the duration. See #361


Add Java-Deobfuscator

Recently I have analyzed lots of java RAT (due to cross-platform capability) with multi layer obfuscations and I found out Java-Deobfuscator do the job greater than other tools. They come with GUI too in case user having issue to setup the config file.
Java-Deobfuscator
https://github.com/java-deobfuscator/deobfuscator
GUI
https://github.com/java-deobfuscator/deobfuscator-gui

Inside PDFStreamDumper there is some JavaCode Analysis...also maybe jsunpack or js-detox

@jdmaster85 We've added a package for Java-Deobfuscator-Gui. You can install via choco install java-deobfuscator-gui.fireeye


cliui dependency error

Describe the bug
require() of ES Module error when trying to build the project, caused by dependency on cliui
Use the solution in the documentation to fix it but it fails.
Log
$ electron-builder install-app-deps

project\node_modules\cliui\build\index.cjs:291
const stringWidth = require('string-width');
                    ^
Error [ERR_REQUIRE_ESM]: require() of ES Module project\node_modules\string-width\index.js from project\node_modules\cliui\build\index.cjs not supported.
Instead change the require of index.js in project\node_modules\cliui\build\index.cjs to a dynamic import() which is available in all CommonJS modules.
    at Object.<anonymous> (project\node_modules\cliui\build\index.cjs:291:21)
    at Object.<anonymous> (project\node_modules\yargs\build\index.cjs:1:60678)
    at Object.<anonymous> (project\node_modules\yargs\index.cjs:5:30)
    at Object.<anonymous> (project\node_modules\electron-builder\out\builder.js:7:15)
    at Object.<anonymous> (project\node_modules\electron-builder\out\cli\cli.js:11:19)
    at Object.<anonymous> (project\node_modules\electron-builder\cli.js:4:1)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Electron-Vite Version
^2.0.0
Electron Version
^28.1.1
Vite Version
^5.0.11
Validations

[X] Follow the Code of Conduct.
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

cliui issues about this issue
https://github.com/yargs/cliui/issues/138

This problem seems to be caused by tailwindcss. It will return to normal after removing the relevant dependencies.

This problem occurred when trying to install vue-router@4. After testing, it seems that this error will occur as long as vue-router@4 is installed.

electron-app.zip
This problem was successfully reproduced in this blank project

Very strange, it seems that as long as tailwindcss is introduced first, and then vue-router is introduced, this problem will be triggered.

cliui only supports esm, so you need to exclude it in externalizeDevPlugin or install in devDependencies.

I developed it in an esm environment, and this bug still appears, and this bug is also related to the dependent installation order, which is very confusing.

failed when executing electron-builder install-app-deps command?

Yes, direct yarn install will also fail

You can try the blank project I posted above

It may be that cliui does not correctly handle the relationship between dependent packages(esm or cjs). You  can remove postinstall script in your package.json.  electron-builder install-app-deps command use to rebuild native node module, you can skip it first. If you cannot use it normally, it is recommended to replace it with other packages.

ok


How to use this?

I can install this, but do you have any code samples?
How do I register user?
How do I login?
Thanks

Disclaimer: not affiliated with the package author
@AndreFabris looks like this package is still very much work in progress, and you can't do much atm. However, here's how to get started:
<?php

$username = 'myuser';
$password = '';

$u = Matrix::session();
$u->login($username, $password);
/*
=> [
        "access_token" => <some access token>,
        "home_server" => "matrix.mydomain.com",
        "user_id" => "@myuser:matrix.mydomain.com",
        "device_id" => "LWYGRFMNKJ",
    ]
*/

You can get this info at any time by calling $u->user() or session('updivision_matrix_data');
// Get the currently logged in user:
$up = Matrix::user();
$up->getProfile();
/*
=> [
      "displayname" => "That's my name",
    ]
*/
$up->setDisplayName('Some other name');
$up->getProfile();
/*
=> [
      "displayname" => "Some other name",
    ]
*/

Seems like from this object you can also register a user, however I haven't tried it myself
$up->register('anotheruser', 'somepassword');

This all works managed to register and login users


fix: duplicate acceptance of offers using same tokens

Bug Report
Current behavior
It's possible to accept 2 different offers regarding the same token. The blockchain retrieves an error afterward but the frontend confirms the Swap anyways.
Expected behavior
It shouldn't be possible to accept 2 token offers with the same token after the first swap is confirmed.
Steps to reproduce

Create 2 Token Offers for the same address with teh same token
Accept the first offer (everything is okay)
Accept the second offer (shouldn't be possible because the token is already swapped

Other information

Hey @eduramme
I want to understand why the swap is being accepted in the front-end. As I remember, a swap is accepted in case the blockchain returns a successful transaction. And if the blockchain is returning an error, then the swap shouldn't be accepted in the front as the transaction reverting is a sign that we should not display the accept scenario.
I think the front-end is not handling the error correctly. Hence this is what I think needs to be done:

Await to handle the blockchain error and display the appropriate results
Simulate the transaction with Viem before actually casting it to make sure it is working

investigate simulateContract - Viem


refactor(pm): migrate pnpx to pnpm dlx

🔗 Linked issue

N/A
❓ Type of change

[X] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
pnpx was deprecated and replaced with pnpm dlx in pnpm v6 and removed in v7. PR
Changed the command shown in <Pm-X> for pnpm (in app/utils/package-manager.ts).

📝 Checklist

[ ] I have linked an issue or discussion.
[X] I have updated the documentation accordingly.

You might want to make a PR for https://github.com/unjs/automd as well

Ah, automd is already using pnpm dlx


Show site in page search results

Is your proposal related to a problem?
On multi-site installations, it is common for certain pages to have the same title and URL. For example "Terms & Conditions". When searching for this in a page chooser, or in the admin, it is not clear which site the page belongs to. See examples from the wagtail admin:

Page chooser:

Describe the solution you'd like
Add a column in the search results that shows which site. Ideally, this column would only be shown if there is more than one Site object.
Describe alternatives you've considered
There is no alternative other than to manually browse the page tree.
Anyone can contribute to this. View our contributing guidelines, add a comment to the issue once you’re ready to start.

Hey @vsalvino, I like to work on this issue. Please assign.

Thanks for your interest @its-kunal! We do not assign issues outside of the core team - anyone is free to work on any issue.
We recommend thoroughly reading https://docs.wagtail.org/en/latest/contributing/first_contribution_guide.html before making your first contribution. You may also wish to join our #new-contributors channel on Slack.

I am currently working on this!


python311Packages.publicsuffixlist: <IP_ADDRESS>40305 -> <IP_ADDRESS>40312

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 295414 run on x86_64-linux 1

13 packages built:

parsedmarc (python311Packages.parsedmarc)
parsedmarc.dist (python311Packages.parsedmarc.dist)
pretalx
pretalx.dist
pretalx.static
python311Packages.checkdmarc
python311Packages.checkdmarc.dist
python311Packages.publicsuffixlist
python311Packages.publicsuffixlist.dist
python312Packages.publicsuffixlist
python312Packages.publicsuffixlist.dist
trustymail
trustymail.dist


[Blocking] Third party libraries not automatically copied when packaging a UE4 project

With bare minimum functioinality added, these libraries were required for the exe to open.

libcrypto-1_1-x64.dll
libssl-1_1-x64.dll
nats.dll
protobuf-c.dll

Possibily these would be required at some stage, but not for the test I did.

libprotobuf.dll
libprotobuf-lite.dll
libprotoc.dll

Are you using the most recent version of the code?
PR #5 should have solved this issue.

Duplicate of #2 unless the issue still exists.

This is a similar issue, not the same as #2. That was when building the plugin (known in the documentation early on).
What I mean here is within UE4, after packaging the project the exe requires the top four listed dlls files to be in the same folder as the executable is, without forcing a copy from a content folder they are not included at all. Normally not an issue when packaging a normal project, as could copy these before uploading or passing on to a consumer. But our end product will be automatically packaged to cloud services and need this dlls copied to the exe automatically.
I'm unsure the process for UE4 and if it possible however, we're going to also ask the developers working on our cloud solution if they can move the files after packaging to the correct location.

What command are you using to package?
For example, I'm using /Engine/Build/BatchFiles/RunUAT.sh BuildCookRun -project=/home/trichards/fu/FracturedUniverse.uproject -noP4 -platform=Linux -clientconfig=Development -serverconfig=Development -cook -server -serverplatform=Linux -noclient -build -stage -pak -archive -archivedirectory=/home/trichards/fu-run for Fractured Universe.
Are you using RunUAT?.

Not using commands, just the editor. So guessing that is the issue. Have never needed to use commands for building/packaging before.

Just tried with the command prompt this morning using the commands below with just my testing/building project for the plugin only (also using source version of 4.27):
Engine\Build\BatchFiles\RunUAT.bat BuildCookRun -project="D:\NatsIOTest_2\NatsIOTest_2.uproject" -noP4 -platform=Win64 -clientconfig=Development -serverconfig=Development -cook -noserver -serverplatform=Win64 -build -stage -pak -archive -archivedirectory="C:\Users\SilverSun VR\Desktop\Ue4 Builds\TensorWorks_NDI_NATS"
This has done the exact same process as packaging within the editor. The DLLs are copied to project location NatsIOTest_2/Binaries/Win64 (for staging?) but still not copied/moved to the pakaged project location.

Just to keep you up to date, I am still actively working on this issue.


Create interaction modifier to allow/prevent dropping items

Whilst developing a plugin using this library I've come across an issue where you're able to drop items from the GUI by pressing 'Q' (or whatever key is binded to dropping an item). I've made some simple additions to make this optional by adding it to the InteractionModifier enum.

This commit shouldn't of been added to this PR, please discard it if this PR is merged


Missing a dot

Under “View your credentials in PowerShell”. Tenant ID:
$aadConntext.TenantId.Guid
Won’t work.  TenantID is not a property of Connect-AzureAD.  I think you meant:
$aadContext.Tenant.Id.Guid
With a dot between Tenant and ID.
This also needs to be updated in the last command under “Sign in with the service principal”
Add-RdsAccount -DeploymentUrl "https://rdbroker.wvd.microsoft.com" -Credential $creds -ServicePrincipal -AadTenantId $aadContext.TenantId.Guid
Change to:
Add-RdsAccount -DeploymentUrl "https://rdbroker.wvd.microsoft.com" -Credential $creds -ServicePrincipal -AadTenantId $aadContext.Tenant.Id.Guid

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 156a552a-fe64-e5dc-b86a-b7d8ccbeee1d
Version Independent ID: d83f235e-3ae2-ad71-30c6-0bd7f95fb894
Content: Create Windows Virtual Desktop service principals and role assignments by using PowerShell  - Azure
Content Source: articles/virtual-desktop/create-service-principal-role-powershell.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@tsrob50
Thanks for your feedback! We will investigate and update as appropriate.

@tsrob50 : Looking/confirming now. However, TenantID is working, unless we're using different AzureAD modules. Can you confirm which module you're using?

I don't have access to the system I was working on but did just try it again with <IP_ADDRESS> and the commands worked.  I must have an outdated version.  Thanks for looking into this, you can close the issue.

Thanks for checking back! #please-close


say_monitoring is undefined for SlackDeveloperOutput class

Fixes this error:
  File "/workspaces/art-bot/artbotlib/brew_list.py", line 396, in _find_rhcos_build_rpms
    so.say_monitoring(f"Encountered error looking up the latest RHCOS build RPMs: {ex}")
AttributeError: 'SlackDeveloperOutput' object has no attribute 'say_monitoring'

/lgtm


K8SPXC-510 Removing obsolete steps

Since RedHat allows us to interact with images in CR
we no longer need reading the corresponding data from ENV

Test name
Status

scaling
passed

storage
passed

recreate
passed

upgrade-haproxy
passed

big-data
passed

haproxy
passed

self-healing
failed

init-deploy
failed

scaling-proxysql
passed

restore-to-encrypted-cluster
passed

security-context
passed

upgrade-proxysql
passed

limits
passed

smart-update
passed

demand-backup
passed

monitoring-2-0
passed

self-healing-advanced
passed

affinity
passed

one-pod
passed

operator-self-healing
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

scheduled-backup
failed

users
failed

upgrade-consistency
failed

tls-issue-self
failed

tls-issue-cert-manager
failed

demand-backup-encrypted-with-tls
failed

tls-issue-cert-manager-ref
failed

validation-hook
failed

Test name
Status

recreate
passed

haproxy
passed

restore-to-encrypted-cluster
passed

init-deploy
failed

demand-backup
passed

scheduled-backup
passed

storage
passed

big-data
passed

self-healing
failed

upgrade-haproxy
passed

scaling
passed

scaling-proxysql
passed

security-context
passed

upgrade-proxysql
passed

smart-update
passed

upgrade-consistency
passed

limits
passed

monitoring-2-0
passed

affinity
passed

one-pod
passed

auto-tuning
passed

proxysql-sidecar-res-limits
passed

users
failed

self-healing-advanced
passed

operator-self-healing
passed

tls-issue-self
passed

demand-backup-encrypted-with-tls
passed

tls-issue-cert-manager
passed

tls-issue-cert-manager-ref
passed

validation-hook
passed


Implementing the Core Extra structure

From the discussion: #476 Make the ShortenerTool.Core a completed package

[X] code Cloud5mins.ShortenerTools.Core
[X] code Cloud5mins.ShortenerTools.Function
[X] code Cloud5mins.ShortenerTools.FunctionLight
[ ] deployment
[ ] documentation

Still need to update the documentation to explain everything and the deployment to make it more dynamic (standalone or with TinyBlazorAdmin)
Feed back is welcome!

@microsoft-github-policy-service agree

Currently working on fixing the deployment.
Note: this new version will allow the free SWA plan again 🥳

Current status: The deployment work without any error, the resources seem to be all deployed... but it's not working. I have a feeling that it doesn't get the configuration.
I'm missing time, if someone out like to give it a look... :)

Quick Update

Upgrade to .NET 8.0
Deployment manual works and both redirect and TinyAdin works

Next Step

Validating the auto deployment
refreshing the documentation


OCPBUGS-34021: Activate flags for timeout, retry and maxParallelDownload

Description
This PR  activates the following containers/image flags in order to help reduce errors during mirroring.

--retry-times: the number of times to possibly retry. default is 2.
--retry-delay: delay between 2 retries. Default 1s
--image-timeout : Timeout for mirroring an image. Defaults to 10mn
--max-parallel-downloads : the maximum layers to pull at the same time. Applies to a single copy operation.. Default to 6

Fixes # OCPBUGS-34021
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
E2E and unit tests pass.
Expected Outcome
This will take some manual testing to actually be able to see the various flags in action.

/label qe-approved

/lgtm


Missing word "read"

hello. I can't find the word "read" in en_UK.txt
read /riːd/, /red/
Could you please add it?

also did not find these important forms of irregular verbs:
In en_UK.txt: are, lead, leant, learned, lied, mow, mowed, put, read, rose, sow, do, ate, have, tear, wear, won, wind, wound, leading, leads, mowing, mows, putting, puts, reading, sows, swinging, does, tears, winding, winds.
In en_US.txt: awoken, mown, sawn, spelt, awaking, awakes, kneels, sews


nodemcu-uploader not working with current NodeMCU DEV build

Hi, I have just flashed the latest DEV build on my ESP (custom built). Even though I adjusted the default baud rate back to 9600 in the firmware, I cannot use the "old" nodemcu-uploader". I do not get an ACK for the filename, and the console later shows "bad argument #1 to 'open'...)
I would have tried with the current version of nodemcu-uploader, but that even refuses to connect to the usb-tty device, even though I can flash firmware through it without problems. I use some AliExpress module based on ESP-12 with a CH340 converter chip.

I used it with dev from 2 days ago but I'll check again.
Den 26 mars 2016 11:28 fm skrev "Konrad Hübner"<EMAIL_ADDRESS>
Hi, I have just flashed the latest DEV build on my ESP (custom built).
Even though I adjusted the default baud rate back to 9600 in the firmware,
I cannot use the "old" nodemcu-uploader". I do not get an ACK for the
filename, and the console later shows "bad argument #1
https://github.com/kmpm/nodemcu-uploader/issues/1 to 'open'...)
I would have tried with the current version of nodemcu-uploader, but that
even refuses to connect to the usb-tty device, even though I can flash
firmware through it without problems.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/kmpm/nodemcu-uploader/issues/53

With uploader v0.3.1 I did the following on a adafruit Huzzah with and FTDI serial converter on my USB bus. I just created a custom build using nodemcu-build.com from the dev branch and added the crypto module (to enable sha1 verification)
$ nodemcu-uploader -B 115200 upload README.md --verify=sha1
opening port /dev/ttyUSB0 with 115200 baud
Preparing esp for transfer.
Transferring README.md as README.md
Verifying using sha1...
Remote SHA1: 7d5edeb47f2a1fd9130c6e472af642a69d36013d
Local SHA1: 7d5edeb47f2a1fd9130c6e472af642a69d36013d
Verification successful. Checksums match
All done!

The -B or --start_baud lets you change the "default" baudrate that uploader uses. This should match the default baudrate of the firmware.
There must be something else going on with your device or using an old version of nodemcu-uploader. There is a known issue, #48, with older versions of nodemcu-uploader that looks like your problem but that is fixed in the latest.
I'm closing this issue but feel free to reopen if it really is something wrong with v0.3.1 and dev firmware. If it's something else, please create a new issue.


Update non-human animal disease classifications

These terms are currently listed as direct children of 'non-human animal disease'
MONDO:1010034 'cleft lip with or without cleft palate, non-human animal'
MONDO:1011458 'glaucoma, primary closed-angle, non-human animal'
MONDO:0024953 'lameness, non-human animal'
MONDO:1010041 'Meckel diverticulum, non-human animal'
MONDO:1010023 'patent ductus venosus, non-human animal'
MONDO:1010077 'Pelger-Huet anomaly, non-human animal'
See if there are more specific parents for these terms.

We need a spreadsheet with terms that need to be re-classified and we can work together on this one Wednesday together with @sabrinatoro and @yshwetar.
@yshwetar I will reach out to you about a time to work on this and what it entails.

See spreadsheet here: https://docs.google.com/spreadsheets/d/1h0fgfTVjf-Hdohl_dGc7CPUu_NUlTAhfiY6QxOKEEYI/edit?gid=0#gid=0


Authenticate to Azure Resources

Having an issue with this spot, 'Authentication to Azure Resources' not sure where I should define workspace. I thought that was covered in line 2.

Let me know if I need to provide more information.

Any update on this?

@jenztales which notebook did you run into this issue? FYI we are updating the ML notebooks and the LinkedService may not work 100% due to this migration. Let us know what notebook you are referring to & we can guide you the next steps.

Azure Synapse - Masquerading Process Name Anomaly Algorithm
Thank you


No logger implementation found when using Tanuki Wrapper.

When the jar is run, no errors are given. So the build is fine. But when the jar is started through a bat file that calls the wrapper,

jvm 1    | LOGGER WARN: No logging framework implementation found in classpath. Add tinylog-impl.jar for outputting log entries.

To replicate, first run the DAS.jar (to see it works properly) and then the Test.bat (both found in the bin folder).
Tanuki_tinylog.zip

Could you provide the source code and your build script?

Tanuki.zip
Here's the while eclipse folder.

I will have a look tomorrow.

Sounds great.
Not sure if it makes a difference but it happens on jdk8 and jdk11 and on most recent and older versions of tanuki.

I propose to post this issue to Tanuki's user mailing list. Your workarounds look like that the problem is very Tanuki specific and we cannot do much from tinylog side.

Well the project has 17 other jars besides Tinylog that work fine and so did it when using logback (before switching to tinylog). So i think it might be a combination of how tanuki handles jars and how the api impl mix works? But i'll post it there and see what the response is.

I have just tested it on my system and it works.
My project: Tanuki.zip

Ok, so it works if the libs are inside the main jar. In my case i'd like to keep that jar as small as possible (limited bandwith) but this is probably a good solution for others.

It works even without fat JAR.
Here, the libs are outside of the main JAR: Tanuki.zip

Hm, gues i'll try to figure out what makes the difference...