Working with UE4 games?

Anyone tried modifying it for any UE4 game? Tried using the DL2 version that worked on other games (like Metro Exodus and Guardians) but no luck so far (tried on Deep Rock Galactic and Ready or Not). Might be a problem regarding the typical UE4 folder structuring - the DLSS dll is hidden behind atleast 3 or 4 subfolders from the game exe. Tried symlinks and hard links, but no dice.

I believe, both of these games use DirectX 11 (as per System Requirements in the according Steam pages), while this project atm works with DirectX 12

Both games have DX11 and DX12 as a launch option, so that part should not be the problem.

@xv0t probably has some special GPU checks that need patching out
@ronoverdrive yeah, that’s why I mentioned the 2 games above. DRG and RoN, for example, don’t have EAC to complicate things.

I kinda managed to activate the DLSS option in Deep Rock Galactic, but for me it gives a lot of visual glitches. But anyway, I had to place JMP (0xEB) in 0xEC4DBF to skip GPU check (corresponds to "else if (!IsRHIDeviceNVIDIA())" line in the plugin source code, particularly in file "DLSS.cpp"). Not sure yet how to patch it, cause for some reason my proxy dll is injected during debugging session but skipped during clean start.

@lnfecteDru Great work! Yeah, there were mentions of that string in the Discord server, found being mentioned in the DLSS Programming guide and then later while randomly searching interesting strings.
Also an interesting thing that may or may not be useful. After the latest commits regarding UE compatibility, I tried the DXVK+VKD3D meme spoof to RTX 3080 on my RX580 again. And now, there were no driver version error dialogue, and the DLSS option actually got exposed and it's working. Well, "working" as its got visual artifacts everywhere, as you've mentioned.
@PotatoOfDoom mentioned you'd have to play around with FoV and Depth values to get it working better, Also mentioned the common UE4/5 depth values are:  NearPlane: 10.0  FarPlane: 1010.0

For Ghostwire this works as well even though it was a bit harder to find, cause there were no such string. The address is 0x12C3FDB where 6 bytes need to be replaced with NOPs. The game has visual glitches too, but different ones.

Could you show me a screen of the Ghostwire address? I'm trying to look for it in Ready or Not, but it also doesn't have this string. Neither does Chivalry 2.

Could you show me a screen of the Ghostwire address? I'm trying to look for it in Ready or Not, but it also doesn't have this string. Neither does Chivalry 2.

Sure, here it is!

I was searching for this particular section:
...
else if (!bLoadLibraries)
{
	UE_LOG(LogDLSS, Log, TEXT("NVIDIA NGX library loading has been disabled with r.NGX.Enable=0"));
	DLSSSupport = EDLSSSupport::NotSupported;
}
else
{
	// This one
	const bool bIsDX12 = (RHIName == TEXT("D3D12")) && GetDefault<UDLSSSettings>()->bEnableDLSSD3D12;
	const bool bIsDX11 = (RHIName == TEXT("D3D11")) && GetDefault<UDLSSSettings>()->bEnableDLSSD3D11;
	const bool bIsVulkan = (RHIName == TEXT("Vulkan")) && GetDefault<UDLSSSettings>()->bEnableDLSSVulkan;
...

Even though there are no log strings in Ghostwire, there are still strings "D3D12", "D3D11" and "Vulkan". And I was looking for jumps to this section.

In case of Ready or Not - the address is 0xABDBBF where you need to replace 1 byte with 0xEB (which is JMP). I'll attach a screenshot of the debugger later.

@lnfecteDru You won't believe it, but I actually managed to patch it myself! Saw your screen regarding D3D12, found it, tried the JNE to JMP and managed to bypass it. Then I came here, and saw you already posted the screenshot XD
Thanks for all the help. Will try it on other UE4 games too.

Managed to find it for The Ascent too!
Change JNE to JMP on RVA 0xF95596 and it should work.

This is how it originally looks like

@lnfecteDru here's an interesting found. It seems CyberFSR2 does work with some UE4 games.
Hellblade Enhanced and Chivalry 2 (bypassed EAC launch and tried on offline mode) are both UE4 games and have no GPU check. And it works just fine with both games, no artifacting. But other UE4 games with RTX/GPU Checks still keep on artifacting.
Interesting, to say the least.
Hellblade Enhanced
Chivalry 2

@lnfecteDru here's an interesting find. It seems CyberFSR2 does work with some UE4 games.
Hellblade Enhanced and Chivalry 2 (bypassed EAC launch and tried on offline mode) are both UE4 games and have no GPU check. And it works just fine with both games, no artifacting. But other UE4 games with RTX/GPU Checks still keep on artifacting.
Interesting, to say the least.
Hellblade Enhanced
Chivalry 2

Interesting indeed, I'll have a look.

Looks like disabling dilated motion vectors (r.NGX.DLSS.DilateMotionVectors 0) fixes the strange ghosting-like artifacts. Blinks, however, are still there.

@lnfecteDru Going by Discord, that option fixed the ghosting for both Ghostrunner and Chorus. But now comes the fun part.
The tester trying it out for Ghostrunner has a Pascal GPU (1050Ti), did not need GPU Check bypass (I suspect it requires only Nvidia GPU, not RTX, despite the in-game note saying RTX lol), mod works great after using that command.
Meanwhile, I tried my RX580 - needed to bypass the GPU check - DLSS option exposed - artifacting like crazy, even with the command.
The Ascent on 1660Ti apparently also works fine, even with the required GPU Check bypass - meanwhile it artifacts on Radeon as usual.
Seems to me Radeon isn't getting parsed correct data when the GPU Check is present in UE4, for whatever reason.

Also, CVars may be applied without patching by putting it in Engine.ini:
[SystemSettings]
r.NGX.DLSS.DilateMotionVectors=0

So there's no really need to patch it.
About the glitch part, probably there are some nvidia driver calls. I'll try to find something.

Forgot to mention in the last comment, but yes, pretty sure there's no need for patching as adding the command to Engine.ini should make it work everywhere.

(idk tho if section name or ini-file matter)

ini files matter for UE4, so it will only work if you put that whole command (with the SystemSettings part too) specifically in Engine.ini in WindowsNoEditor folder where the game config files are located

r.SceneColorFormat=5 fixed it for me. Can anybody check it as well?

Give me a few mins and I can check it out.

@lnfecteDru Potato on Discord:
"sry I am super busy rn. the ue4 fix you guys found seems to be caused by a bug in fsr 2: https://github.com/GPUOpen-Effects/FidelityFX-FSR2/issues/39
(Probably already fixed in the internal tree 🙄). I'll add the fix to my fsr2 fork as soon as I have access to a pc again"

@lnfecteDru Potato on Discord:
"sry I am super busy rn. the ue4 fix you guys found seems to be caused by a bug in fsr 2: GPUOpen-Effects/FidelityFX-FSR2#39 (Probably already fixed in the internal tree 🙄). I'll add the fix to my fsr2 fork as soon as I have access to a pc again"

Not really sure if it will help in this case, cause it looks like motion vector scale, sent by the engine, is equal to 1 regardless of settings:

Hi,
are someone interested in help fixing the UE5 5.1 City demo.. @lnfecteDru @TheRazerMD  ?
https://www.dsogaming.com/news/the-matrix-awakens-megacity-unreal-engine-5-1-available-for-download/
download this UE5.1 demo:
https://drive.google.com/file/d/1eQ_Oav8pxMJ-55qwwyRurjS_dyKgFGqZ/view
seems have some checks..
log:
[2022.08.27-05.35.35:282][  0]LogDLSS: FDLSSModule::StartupModule Enter
[2022.08.27-05.35.35:282][  0]LogDLSS: PluginBaseDir ../../../CitySample/Plugins/DLSS
[2022.08.27-05.35.35:302][  0]LogDLSS: NGXBinariesDir ../../../CitySample/Plugins/DLSS/Binaries/ThirdParty/Win64/
[2022.08.27-05.35.35:303][  0]LogDLSS: GDynamicRHIName NVIDIA D3D12
[2022.08.27-05.35.35:313][  0]LogDLSS: Plugin settings: NGXAppId = 0
[2022.08.27-05.35.35:317][  0]LogDLSS: Warning: NGX Application ID not specified, using the Project ID by default.
[2022.08.27-05.35.35:319][  0]LogDLSSNGXRHI: FNGXRHIModule::StartupModule Enter
[2022.08.27-05.35.35:321][  0]LogDLSSNGXRHI: FNGXRHIModule::StartupModule Leave
[2022.08.27-05.35.35:327][  0]LogDLSSNGXRHI: Searching for custom and generic DLSS binaries
[2022.08.27-05.35.35:328][  0]LogDLSSNGXRHI: NVIDIA NGX DLSS binary nvngx_dlss.dll not found in search path E:\a4\CitySample_51_DLSS_Cinematic\CitySample\Binaries\ThirdParty\NVIDIA\NGX\Win64\
[2022.08.27-05.35.35:329][  0]LogDLSSNGXRHI: NVIDIA NGX DLSS binary nvngx_dlss.dll not found in search path E:\a4\CitySample_51_DLSS_Cinematic\CitySample\Binaries\Win64\Binaries\ThirdParty\NVIDIA\NGX\Win64\
[2022.08.27-05.35.35:330][  0]LogDLSSNGXRHI: NVIDIA NGX DLSS binary nvngx_dlss.dll found in search path E:\a4\CitySample_51_DLSS_Cinematic\CitySample\Plugins\DLSS\Binaries\ThirdParty\Win64\
[2022.08.27-05.35.35:332][  0]LogDLSSNGX: [SDK]: [2022-08-27 07:35:35] [NGXSafeInitializeLog:130] App logging hooks successfully initialized
[2022.08.27-05.35.35:346][  0]LogDLSSNGX: [SDK]: [2022-08-27 07:35:35] [NGXGetPathUsingQAI:127] Path to driverStore found using QAI: C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispig.inf_amd64_800c5375bcee0134
[2022.08.27-05.35.35:883][  0]LogDLSSNGX: [Core]: [2022-08-27 07:35:35] [NGXSafeInitializeLog:130] App logging hooks successfully initialized
[2022.08.27-05.35.35:996][  0]LogDLSSNGX: [Core]: [2022-08-27 07:35:35] [NGXCheckHardwareSupportUsingINF:212] error: unsupported hardware detected
[2022.08.27-05.35.36:002][  0]LogDLSSNGXD3D12RHI: NVSDK_NGX_D3D12_Init_with_ProjectID(ProjectID = 914301364FA2BD41AB81DA86AC490783, EngineVersion=5.1, APIVersion = 0x14, Device=0000012D6C4A1040) -><PHONE_NUMBER> NVSDK_NGX_Result_FAIL_FeatureNotSupported)
[2022.08.27-05.35.36:086][  0]LogDLSSNGX: [Core]: [2022-08-27 07:35:36] [NGXCheckHardwareSupportUsingINF:212] error: unsupported hardware detected
[2022.08.27-05.35.36:106][  0]LogDLSSNGXD3D12RHI: NVSDK_NGX_D3D12_Init_with_ProjectID(ProjectID = 914301364FA2BD41AB81DA86AC490783, EngineVersion=5.1, APIVersion = 0x13, Device=0000012D6C4A1040) -><PHONE_NUMBER> NVSDK_NGX_Result_FAIL_FeatureNotSupported)
[2022.08.27-05.35.36:111][  0]LogDLSSNGXD3D12RHI: NVSDK_NGX_D3D12_Init (Log C:/Users/rtfss/AppData/Local/CitySample/Saved/Logs/NGX/NGX_2022.08.27-07.35.35_478E6EB7483B6E0FFCA9559322110D8C) -><PHONE_NUMBER> NVSDK_NGX_Result_FAIL_FeatureNotSupported)
[2022.08.27-05.35.36:113][  0]LogDLSS: DLSS not supported by the NVIDIA D3D12 RHI in the NGXD3D12RHI module at runtime
[2022.08.27-05.35.36:113][  0]LogDLSS: NVIDIA NGX DLSS supported 0
[2022.08.27-05.35.36:114][  0]LogDLSS: FDLSSModule::StartupModule Leave

Hi, are someone interested in fixing the UE5 5.1 City demo (with DLSS support)?.. @lnfecteDru @TheRazerMD ? https://www.dsogaming.com/news/the-matrix-awakens-megacity-unreal-engine-5-1-available-for-download/ download this UE5.1 demo: https://drive.google.com/file/d/1eQ_Oav8pxMJ-55qwwyRurjS_dyKgFGqZ/view seems have some checks.. log:
[2022.08.27-05.35.35:282][  0]LogDLSS: FDLSSModule::StartupModule Enter
[2022.08.27-05.35.35:282][  0]LogDLSS: PluginBaseDir ../../../CitySample/Plugins/DLSS
[2022.08.27-05.35.35:302][  0]LogDLSS: NGXBinariesDir ../../../CitySample/Plugins/DLSS/Binaries/ThirdParty/Win64/
[2022.08.27-05.35.35:303][  0]LogDLSS: GDynamicRHIName NVIDIA D3D12
[2022.08.27-05.35.35:313][  0]LogDLSS: Plugin settings: NGXAppId = 0
[2022.08.27-05.35.35:317][  0]LogDLSS: Warning: NGX Application ID not specified, using the Project ID by default.
[2022.08.27-05.35.35:319][  0]LogDLSSNGXRHI: FNGXRHIModule::StartupModule Enter
[2022.08.27-05.35.35:321][  0]LogDLSSNGXRHI: FNGXRHIModule::StartupModule Leave
[2022.08.27-05.35.35:327][  0]LogDLSSNGXRHI: Searching for custom and generic DLSS binaries
[2022.08.27-05.35.35:328][  0]LogDLSSNGXRHI: NVIDIA NGX DLSS binary nvngx_dlss.dll not found in search path E:\a4\CitySample_51_DLSS_Cinematic\CitySample\Binaries\ThirdParty\NVIDIA\NGX\Win64\
[2022.08.27-05.35.35:329][  0]LogDLSSNGXRHI: NVIDIA NGX DLSS binary nvngx_dlss.dll not found in search path E:\a4\CitySample_51_DLSS_Cinematic\CitySample\Binaries\Win64\Binaries\ThirdParty\NVIDIA\NGX\Win64\
[2022.08.27-05.35.35:330][  0]LogDLSSNGXRHI: NVIDIA NGX DLSS binary nvngx_dlss.dll found in search path E:\a4\CitySample_51_DLSS_Cinematic\CitySample\Plugins\DLSS\Binaries\ThirdParty\Win64\
[2022.08.27-05.35.35:332][  0]LogDLSSNGX: [SDK]: [2022-08-27 07:35:35] [NGXSafeInitializeLog:130] App logging hooks successfully initialized
[2022.08.27-05.35.35:346][  0]LogDLSSNGX: [SDK]: [2022-08-27 07:35:35] [NGXGetPathUsingQAI:127] Path to driverStore found using QAI: C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispig.inf_amd64_800c5375bcee0134
[2022.08.27-05.35.35:883][  0]LogDLSSNGX: [Core]: [2022-08-27 07:35:35] [NGXSafeInitializeLog:130] App logging hooks successfully initialized
[2022.08.27-05.35.35:996][  0]LogDLSSNGX: [Core]: [2022-08-27 07:35:35] [NGXCheckHardwareSupportUsingINF:212] error: unsupported hardware detected
[2022.08.27-05.35.36:002][  0]LogDLSSNGXD3D12RHI: NVSDK_NGX_D3D12_Init_with_ProjectID(ProjectID = 914301364FA2BD41AB81DA86AC490783, EngineVersion=5.1, APIVersion = 0x14, Device=0000012D6C4A1040) -><PHONE_NUMBER> NVSDK_NGX_Result_FAIL_FeatureNotSupported)
[2022.08.27-05.35.36:086][  0]LogDLSSNGX: [Core]: [2022-08-27 07:35:36] [NGXCheckHardwareSupportUsingINF:212] error: unsupported hardware detected
[2022.08.27-05.35.36:106][  0]LogDLSSNGXD3D12RHI: NVSDK_NGX_D3D12_Init_with_ProjectID(ProjectID = 914301364FA2BD41AB81DA86AC490783, EngineVersion=5.1, APIVersion = 0x13, Device=0000012D6C4A1040) -><PHONE_NUMBER> NVSDK_NGX_Result_FAIL_FeatureNotSupported)
[2022.08.27-05.35.36:111][  0]LogDLSSNGXD3D12RHI: NVSDK_NGX_D3D12_Init (Log C:/Users/rtfss/AppData/Local/CitySample/Saved/Logs/NGX/NGX_2022.08.27-07.35.35_478E6EB7483B6E0FFCA9559322110D8C) -><PHONE_NUMBER> NVSDK_NGX_Result_FAIL_FeatureNotSupported)
[2022.08.27-05.35.36:113][  0]LogDLSS: DLSS not supported by the NVIDIA D3D12 RHI in the NGXD3D12RHI module at runtime
[2022.08.27-05.35.36:113][  0]LogDLSS: NVIDIA NGX DLSS supported 0
[2022.08.27-05.35.36:114][  0]LogDLSS: FDLSSModule::StartupModule Leave

From what I see in the plugin source code, the DLSS loading procedure is the same as in UE4 (I'll check it later in game). According to the log, the game is trying to load nvngx_dlss.dll instead of nvngx.dll, are you sure you activated EnableSignatureOverride.reg?

This UE5 Demo is torture
R9 5950X + RX 6800 XT
Ultra

Upscaling: OFF

Upscaling: Ultra Quality

Upscaling: Quality

Upscaling: Balanced

Upscaling: Performance

Upscaling: Ultra Performance

@lnfecteDru thanks for looking into it..
in the meanwhile I also was able to fix it also by changing:
E8 04 D7 C4 01 84 C0 75 2D
E8 04 D7 C4 01 84 C0 74 2D
so changed jne with je, fix it for me but then remember a complete fix is change with jmp instruction inconditionally..
this fixes the IsRHIDeviceNVIDIA(void) in DLSS..
but then as I have a system with NV and AMD GPU even if I disable the NV card from device manager seems the DLSS static libraries linked into exe search for Nvidia installed drivers on Driverstore folder and use this _nvngx.dll breaking DLSS support..
the UNIQUE way to fix this is by putting cyberfsr2 nvngx.dll in the game folder "CitySample_51_DLSS_Cinematic\CitySample\Binaries\Win64"
seems Nvidia left a way for users to use update nvngx.dll by putting in game exe folder NOT in thirdparty (CitySample_51_DLSS_Cinematic\CitySample\Plugins\DLSS\Binaries\ThirdParty\Win64)
this is important!!
this may be required by people also with old NV GPUs not supporting DLSS as they have a NV driver installed..

Hi,
even this is a issue about DLSS let me talk about UE5 D3D12 render issues on AMD cards..
in fact I make a BIG CLAIM: using this DLSS hacked support right now is a MUST for running UE5 content rendered correctly on AMD GPUs (at least currently).. I mean using D3D12 and also authored to use SM6 backed (needed for Lumen anyway?).. this demo is an example of a UE5 D3D12 SM6 only compiled demo.. i.e. forcing -d3d11 or -sm5 demo will not run..
the example is @MOVZX (Upscaling: OFF) screenshoot (so no DLSS)..
@MOVZX have you noticed running the demo without DLSS enabled, (your Upscaling: OFF screenshot), has rendering issues, big "pixelation" effects, even tough it should be better than or equal to DLSS ultra quality, right? notice especially around the girl you control..
before hacking DLSS support, I had noticed that running on RX Vega D3D12, and thinked it was a Vega HW issue, or some driver issue.. I see now RDNA2 cards are also affected which is sad..
also noticed that running under VKD3D on Linux under RADV the issues aren't present.. (might require running with -novendordevice)
under Windows VKD3D for AMD also needs a hack for enabling SM6.6 support because of missing NV_compute_derivatives..
but even then AMD Windows Vulkan driver +VKD3D doesn't boot the demo..
seems old NV hardware without DLSS has no rendering artifacts under D3D12 SM6(.6) mode..
would be nice to see with Intel DG2 hardware like A380 if this demo without DLSS has rendering issues..

Tested another Unreal 4 game: Observer System Redux
FSR 2.1.1 from the CB77 Nexus mod works like a native implementation (version 0.8.0-beta2). Boost performance with ZERO perceived image quality loss. Zero artefacting or ghosting. 10/10 implementation.

Tested another Unreal 4 game: Observer System Redux
FSR 2.1.1 from the CB77 Nexus mod works like a native implementation (version 0.8.0-beta2). Boosted performance with ZERO perceived image quality loss. Zero artefacting or ghosting. 10/10 implementation.

Look at this comparison images
NATIVE FSR

CyberFSR 0.8.0-beta2

It's a day and night difference.

Has anyone here tried it with The Ascent (also UE4 and does only support DLSS2)?

Has anyone here tried it with The Ascent (also UE4 and does only support DLSS2)?

It does work as long you use 0.8.0 beta 2. But there will be ghosting/smearing.

If you're wondering why the SceneColorFormat hack is needed, it's because some (or all?) versions of DLSS UE plugin has a bug where the InputColor buffer is in the wrong resource state (D3D12_RESOURCE_STATE_RENDER_TARGET). AMD hardware applies compression that are incompatible with SRV use, and using SceneColorFormat=5 works only because F32 is not compressed at all. It also comes at a performance cost.
It might be worth trying injecting a transition to D3D12_RESOURCE_STATE_NON_PIXEL_SHADER_RESOURCE | D3D12_RESOURCE_STATE_PIXEL_SHADER_RESOURCE before FSR dispatch, then after the dispatch transition it back to D3D12_RESOURCE_STATE_RENDER_TARGET so that the engine don't get confused.


Generated Code Sets Non-Canonical Headers

Bug Report

Generated code in azdatalake directly sets http headers https://github.com/Azure/azure-sdk-for-go/blob/sdk/storage/azdatalake/v1.3.0/sdk/storage/azdatalake/internal/generated/zz_path_client.go#L1 instead of using the req.req.Header.Set because of which processing the request outside of azdatalake requires dealing with Header as a map instead of using Set and Get.

Package /sdk/storage/azdatalake
SDK version master

The official documentation has canonicalized headers so this can lead to some confusions.

This is by design and due to some unique legacy behaviors of the storage services. Specifically, this part from the docs.

Note that metadata names preserve the case with which they were created, but are case-insensitive when set or read.

Can you clarify the problem this is causing?

@jhendrixMSFT I actually thought that metadata name casing is no longer preserved because when i parse the metadata headers, they are always canonicalised (eg: if I set a property prop-name using the go sdk, the response contains the property Prop-Name. Is there a way to avoid this case information loss?

For responses you're correct the headers are canonicalized. This happens as part of the underlying transport in the standard library and there's no way for us to disable this behavior.

@jhendrixMSFT ideally in this case then the non canonical headers would only be used for the X-Ms-Properties header while the others use the Set method, but this isn't a major issue for me so if it's a lot of effort feel free to close this issue, I'd really appreciate it if I could get some help for https://github.com/Azure/azure-sdk-for-go/issues/23841 because that's a major blocker for me.

Changing the way we set headers at this point would likely break somebody so I will close this.
Regarding the other issue, I've routed it to the owners of the storage SDKs to take a look.


Variant type deduction

Ran into another problem.
While i was trying to clone a repo with the build html pages, it was failing, because of a too long creation path:
public/hg/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterStorage/index.html

So I checked the created docs directory of doxide and found the same folder structure with the related markdown files and sub-folders.
~/git/docs/hg/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterTypeStorage/ConstantNodeParameterStorage.md

The related source code:`
typedef _STD variant<
    /**/
    ConstantNodeParameterTypeStorage<NodeLinkValueType::u8>::type,
    ConstantNodeParameterTypeStorage<NodeLinkValueType::u16>::type,
    ConstantNodeParameterTypeStorage<NodeLinkValueType::u32>::type,
    ConstantNodeParameterTypeStorage<NodeLinkValueType::u64>::type,
    /**/
    ConstantNodeParameterTypeStorage<NodeLinkValueType::f32>::type,
    ConstantNodeParameterTypeStorage<NodeLinkValueType::f64>::type,
    /**/
    ConstantNodeParameterTypeStorage<NodeLinkValueType::f32vec2>::type,
    ConstantNodeParameterTypeStorage<NodeLinkValueType::f32vec3>::type,
    ConstantNodeParameterTypeStorage<NodeLinkValueType::f32vec4>::type,
    /**/
    ConstantNodeParameterTypeStorage<NodeLinkValueType::f32mat2x2>::type,
    ConstantNodeParameterTypeStorage<NodeLinkValueType::f32mat3x3>::type,
    ConstantNodeParameterTypeStorage<NodeLinkValueType::f32mat4x4>::type
    /**/
    //ConstantNodeParameterTypeStorage<NodeLinkValueType::color>::type // Does already exists as `f32vec4`
> ConstantNodeParameterStorage;

So I guess the variant is a problem :?
Anyway, if you need more of the source code, msg me again.
Sorry for the inconvenience.

I've tightened the query for typedefs in 9534721, which acts as an appropriate recovery from the parse error, and fixes this particular case. This macro expansion issue may arise again and require further tweaks. Tagged as v0.0.3, packages rebuilding.

It respects namespaces, yes, including C++ nested namespace declarations like namespace a::b::c. If you use @ingroup, however, it will shift an entity out of its namespace and into the given group.
I can do something to make it quieter. But despite the warnings, is it producing the expected documentation?

If you're happy to share a larger chunk of your codebase that captures these issues I can have a look. Just point me to the repo, or you can email an archive (address on my profile).

Closing the ticket as the original issue is resolved, although still some thinking to do on handling macros.


Add configuration signals for i22 fswitch

These configuration/metadata fields are required to be in the Nexus file for i22's fswitch.
Fixes #566.
Instructions to reviewer on how to test:

Run fswitch count plan
Verify that added configuration fields are in the descriptor document

Checks for reviewer

[ ] Would the PR title make sense to a scientist on a set of release notes
[ ] If a new device has been added does it follow the standards
[ ] If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly

Do the definitions in i22.py and p38.py also need updating?

Yes just pushed a new revision containing the change for i22
I didn't add it to p38 as I assume they don't have an fswitch.

Could you add a fake one for p38? With fake_with_ophyd_sim=True. That way we can generate documents from p38 that contain all the information needed to make the nexus structure we want, even if it's mostly 0s etc in p38's case

Could you add a fake one for p38? With fake_with_ophyd_sim=True. That way we can generate documents from p38 that contain all the information needed to make the nexus structure we want, even if it's mostly 0s etc in p38's case

Thanks - done now.


CASSANDRA-20100 Interpret inet, bigint, varint, and decimal as non-reversed types for query construction and post-filtering

patch by Caleb Rackliffe; reviewed by ? for CASSANDRA-20100

Committed as https://github.com/apache/cassandra/commit/86868c6df88b23af3941a087b9f6e7082065d6db


IndexError: list index out of range in index = faiss.IndexFlatL2(len(embeddings[0]))

File "/usr/local/lib/python3.11/site-packages/langchain/vectorstores/faiss.py", line 347, in __from
index = faiss.IndexFlatL2(len(embeddings[0]))
~~~~~~~~~~^^^
IndexError: list index out of range

I get the same error

i also got the same error

same

also seeing this:
│ ❱ 1 import_docs()                                                                                │
│   2                                                                                │
│                                                                                │
│ in import_docs:33                                                                                │
│                                                                                │
│   30 │                                                                                │
│   31 │   documents = text_splitter.split_documents(langchain_documents)                          │
│   32 │   embeddings = OpenAIEmbeddings(openai_api_key=OPENAI_API_KEY, )                          │
│ ❱ 33 │   vectorstore = FAISS.from_documents(documents, embeddings)                               │
│   34 │                                                                                │
│   35 │   # Save vectorstore                                                                      │
│   36 │   with open("./openlegalquerybase/embedded_docs.pkl", "wb") as file:                      │
│                                                                                │
│ /home/cw/miniconda3/lib/python3.10/site-packages/langchain/vectorstores/base.py:116 in           │
│ from_documents                                                                                │
│                                                                                │
│   113 │   │   """Return VectorStore initialized from documents and embeddings."""                │
│   114 │   │   texts = [d.page_content for d in documents]                                        │
│   115 │   │   metadatas = [d.metadata for d in documents]                                        │
│ ❱ 116 │   │   return cls.from_texts(texts, embedding, metadatas=metadatas, **kwargs)             │
│   117 │                                                                                │
│   118 │   @classmethod                                                                           │
│   119 │   @abstractmethod                                                                        │
│                                                                                │
│ /home/cw/miniconda3/lib/python3.10/site-packages/langchain/vectorstores/faiss.py:345 in          │
│ from_texts                                                                                │
│                                                                                │
│   342 │   │   │   │   faiss = FAISS.from_texts(texts, embeddings)                                │
│   343 │   │   """                                                                                │
│   344 │   │   embeddings = embedding.embed_documents(texts)                                      │
│ ❱ 345 │   │   return cls.__from(texts, embeddings, embedding, metadatas, **kwargs)               │
│   346 │                                                                                │
│   347 │   @classmethod                                                                           │
│   348 │   def from_embeddings(                                                                   │
│                                                                                │
│ /home/cw/miniconda3/lib/python3.10/site-packages/langchain/vectorstores/faiss.py:307 in __from   │
│                                                                                │
│   304 │   │   **kwargs: Any,                                                                     │
│   305 │   ) -> FAISS:                                                                            │
│   306 │   │   faiss = dependable_faiss_import()                                                  │
│ ❱ 307 │   │   index = faiss.IndexFlatL2(len(embeddings[0]))                                      │
│   308 │   │   index.add(np.array(embeddings, dtype=np.float32))                                  │
│   309 │   │   documents = []                                                                     │
│   310 │   │   for i, text in enumerate(texts):                                                   │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯

IndexError: list index out of range

same error

Guys- it is because document is not created on your local, may be your html file is not downloaded. Check the document length.

Is there a resolution to this problem? I am also experiencing this in a larger doc.

same problem

I am also getting this error.

I experienced the same issue using the DirectoryLoader until I set the loader_cls parameter.
    loader = DirectoryLoader("C:\\directory",loader_cls=TextLoader,
                             recursive=True, show_progress=True,
                             use_multithreading=True,max_concurrency=8)
    raw_documents = loader.load()

Replaces line 12 of ingest.py
Don't forget to update the import statement: from langchain.document_loaders import DirectoryLoader,TextLoader

I also encountered this mistake. Because the file I loaded was empty. When I added the writing text, the problem was solved.

I also encountered this mistake. Because the file I loaded was empty. When I added some text, the problem was solved.

same error

Same exact error

yes, the same error

I encountered the same error.
I first tried to downgrade to langchain==0.0.120 but it doesn't work. It should be because that website is updated now and the loader cannot parse it anymore.
I solved it for my case. If you just want to try the demo, just change ingest.py a little:
text = """the langchain docs copied from the website"""

#....

def ingest_docs():
      doc = Document(page_content=text, metadata={"source": str("https://api.python.langchain.com/en/latest/api_reference.html")})
      raw_documents = [doc]

      #...

Using this on a bunch of pdfs:
loader = DirectoryLoader(DATA_PATH_PDF,
glob='*.pdf',
loader_cls=PyPDFLoader, show_progress=True)
They load without error but then get the same error:
index = faiss.IndexFlatL2(len(embeddings[0]))
IndexError: list index out of range

i get the same error when creating a new vectorstore

I think I might have found the issue. One of the pdfs I was reading did not have any text (it was scanned text) and the reader read the page_content text as blank string '' for all pages. You may need to do some OCR on your pdf to get the text out first before sending to FAISS

I got the same error when creating a new FAISS vectorstore with texts and embeddings. I resolved it by passing a list(zip(texts_list, embeddings_list)) instead of zip(texts_list, embeddings_list).
The following example in the FAISS API document in LangChain does not work and will lead to the out of index error. https://api.python.langchain.com/en/latest/vectorstores/langchain.vectorstores.faiss.FAISS.html?highlight=faiss#langchain.vectorstores.faiss.FAISS.from_embeddings
from langchain import FAISS
from langchain.embeddings import OpenAIEmbeddings

embeddings = OpenAIEmbeddings()
text_embeddings = embeddings.embed_documents(texts)
text_embedding_pairs = zip(texts, text_embeddings)
faiss = FAISS.from_embeddings(text_embedding_pairs, embeddings)

The following on works for me:
from langchain import FAISS
from langchain.embeddings import OpenAIEmbeddings

embeddings = OpenAIEmbeddings()
text_embeddings = embeddings.embed_documents(texts)
text_embedding_pairs = zip(texts, text_embeddings)
text_embedding_pairs_list = list(text_embedding_pairs)
faiss = FAISS.from_embeddings(text_embedding_pairs_list, embeddings)

Re-check your documents. They might need OCR recognition before being read as text. They might not be readable by your current PDF loader. So there was no text in the first embeddings[0] to actually retrieve from. That was my problem.

I had the same error thrown again function scrape_kbs:
  File "KBScrapeVectorize.py", line 130, in scrape_kbs
    db = FAISS.from_documents(docs, embeddings)
...
index = faiss.IndexFlatL2(len(embeddings[0]))
IndexError: list index out of range

This function was supposed to scrape relevant details from some knowledge base articles, create documents and use them to create a vectorstore. However, when I checked the documents created from the scraped KBs, there were all empty as the auth had failed to the site. Once I corrected the auth and documents had some content, FAISS.from_documents worked fine.

Can anyone got solution?
please help me to solve the error

File "/usr/local/lib/python3.11/site-packages/langchain/vectorstores/faiss.py", line 347, in __from index = faiss.IndexFlatL2(len(embeddings[0])) ~~~~~~~~~~^^^ IndexError: list index out of range

Not able to solve the error please help me to solve the error

I posted what I think is the answer already. You have an empty document that you are trying to put into FAISS. Remove any docs that are empty

On Oct 14, 2023, at 9:49 AM, MuvvaThriveni @.***> wrote:
File "/usr/local/lib/python3.11/site-packages/langchain/vectorstores/faiss.py", line 347, in __from index = faiss.IndexFlatL2(len(embeddings[0])) ~~~~~~~~~~^^^ IndexError: list index out of range
Not able to solve the error please help me to solve the error
—
Reply to this email directly, view it on GitHub https://github.com/langchain-ai/chat-langchain/issues/68#issuecomment-1763037422, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIHCIQ3G53VQSWTEM6CU3DX7K7BTANCNFSM6AAAAAAXQUITZI.
You are receiving this because you commented.

Thanks for reply
here you can see what i am doing
I am loading some urls and then splitting the data and creating embeddings
using openai and lastly using faiss to store my embeddings
but facing the list index out of range.
could you please help me to solve the problem
loader = UnstructuredURLLoader(urls=urls)
data = loader.load()
# split data
text_splitter = CharacterTextSplitter(separator='\n', chunk_size=1000,

chunk_overlap=200)
docs = text_splitter.split_documents(data)
# embeddings
embeddings = OpenAIEmbeddings()

# save embeddings to FAISS index
vectorstore_openai = FAISS.from_embeddings(docs,embeddings)

On Sun, 15 Oct 2023 at 01:26, Skisquaw @.***> wrote:

I posted what I think is the answer already. You have an empty document
that you are trying to put into FAISS. Remove any docs that are empty

On Oct 14, 2023, at 9:49 AM, MuvvaThriveni @.***> wrote:
File
"/usr/local/lib/python3.11/site-packages/langchain/vectorstores/faiss.py",
line 347, in __from index = faiss.IndexFlatL2(len(embeddings[0]))

>
> Not able to solve the error please help me to solve the error
>
> —
> Reply to this email directly, view it on GitHub <
https://github.com/langchain-ai/chat-langchain/issues/68#issuecomment-1763037422>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABIHCIQ3G53VQSWTEM6CU3DX7K7BTANCNFSM6AAAAAAXQUITZI>.

> You are receiving this because you commented.
>

—
Reply to this email directly, view it on GitHub
<https://github.com/langchain-ai/chat-langchain/issues/68#issuecomment-1763163697>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2OUNOLKOASD2R7WV23IOHTX7LU6JAVCNFSM6AAAAAAXQUITZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGE3DGNRZG4>
.
You are receiving this because you commented.Message ID:
<EMAIL_ADDRESS>

Yes I found docs are empty...
Now I am facing other issue
023-10-17 21:43:14.139 Uncaught app exception
Traceback (most recent call last):
File "C:\VS_CODE\langchain\Equity Research
Analysis\venv\Lib\site-packages\streamlit\runtime\scriptrunner\script_runner.py",
line 565, in _run_script
exec(code, module.dict)
File "C:\VS_CODE\langchain\Equity Research Analysis\app.py", line 52, in

vectorstore_openai = FAISS.from_embeddings(docs,embeddings)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\VS_CODE\langchain\Equity Research
Analysis\venv\Lib\site-packages\langchain\vectorstores\faiss.py", line 641,
in from_embeddings
texts = [t[0] for t in text_embeddings]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\VS_CODE\langchain\Equity Research
Analysis\venv\Lib\site-packages\langchain\vectorstores\faiss.py", line 641,
in
texts = [t[0] for t in text_embeddings]
~^^^
TypeError: 'Document' object is not subscriptable
Can You please help me to solve the error
On Tue, 17 Oct 2023 at 18:14, Thriveni 5J6 @.***>
wrote:

Thanks for reply
here you can see what i am doing
I am loading some urls and then splitting the data and creating embeddings
using openai and lastly using faiss to store my embeddings
but facing the list index out of range.
could you please help me to solve the problem
loader = UnstructuredURLLoader(urls=urls)
data = loader.load()
# split data
text_splitter = CharacterTextSplitter(separator='\n', chunk_size=1000,

chunk_overlap=200)
docs = text_splitter.split_documents(data)
# embeddings
embeddings = OpenAIEmbeddings()

# save embeddings to FAISS index
vectorstore_openai = FAISS.from_embeddings(docs,embeddings)

On Sun, 15 Oct 2023 at 01:26, Skisquaw @.***> wrote:

I posted what I think is the answer already. You have an empty document
that you are trying to put into FAISS. Remove any docs that are empty

On Oct 14, 2023, at 9:49 AM, MuvvaThriveni @.***> wrote:
File
"/usr/local/lib/python3.11/site-packages/langchain/vectorstores/faiss.py",
line 347, in __from index = faiss.IndexFlatL2(len(embeddings[0]))

>
> Not able to solve the error please help me to solve the error
>
> —
> Reply to this email directly, view it on GitHub <
https://github.com/langchain-ai/chat-langchain/issues/68#issuecomment-1763037422>,
or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ABIHCIQ3G53VQSWTEM6CU3DX7K7BTANCNFSM6AAAAAAXQUITZI>.

> You are receiving this because you commented.
>

—
Reply to this email directly, view it on GitHub
<https://github.com/langchain-ai/chat-langchain/issues/68#issuecomment-1763163697>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2OUNOLKOASD2R7WV23IOHTX7LU6JAVCNFSM6AAAAAAXQUITZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGE3DGNRZG4>
.
You are receiving this because you commented.Message ID:
<EMAIL_ADDRESS>

If anyone has this trouble, try iterating each chunk whether that check has the value or not. I checked that if the given chunk is empty, it fails like this (exit 0)

index = faiss.IndexFlatL2(len(embeddings[0]))
IndexError: list index out of range
This looks like an ERROR def merge_from in faiss
Also Shows AttributeError: type object 'FAISS' has no attribute 'IndexFlatL2' when tried to print. IndexFlatL2.

I get what a lot of you are saying about the files being empty but I am using the same files he is using in the video and still the same error, I also already try the suggestionsin the things trend and still the same

@MuvvaThriveni did you get it how to solve this error.Pls help me

I had the same error but when I changed the pdf file. The issue was resolved. So I think all pdfs can't be processed so OCR based tools will come handy.

Same error

Those who are here from the codebasics LLM video
you can use this code ->
if process_url_clicked:
# load data
loader = UnstructuredURLLoader(urls=urls)
main_placefolder.text("Data Loading...Started...✅✅✅")
data = loader.load()
if data:
    # split data
    text_splitter = RecursiveCharacterTextSplitter(
        separators=['\n\n', '\n', '.', ','],
        chunk_size=1000
    )
    main_placefolder.text("Text Splitter...Started...✅✅✅")
    docs = text_splitter.split_documents(data)

    if docs:
        # create embeddings and save it to FAISS index
        embeddings = OpenAIEmbeddings()
        vectorstore_openai = FAISS.from_documents(docs, embeddings)
        main_placefolder.text("Embedding Vector Started Building...✅✅✅")
        time.sleep(2)

        # Save the FAISS index to a pickle file
        vectorstore_openai.save_local(file_path)
    else:
        main_placefolder.text("Text Splitter produced empty documents. Check data.")
else:
    main_placefolder.text("Data loading failed. Check URLs or network connection.")

Also Note:
in the Requirements.txt folder there is python-magic and libmagic
which is not required, so uninstall them from pycharm by doing
pip uninstall libmagic
pip uninstall python-magic
pip uninstall python-magic-bin
pip install python-magic-bin==0.4.14
Now run the code. Hope it'll be helpful

TypeError                                 Traceback (most recent call last)
 in <cell line: 3>()
2 file_path="/content/drive/MyDrive/Deep Learning/News Research Tool/vector_index.pkl"
3 with open(file_path,"wb") as f:
----> 4     pickle.dump(vectorindex_openai, f)
TypeError: cannot pickle '_thread.RLock' object
please  slove the error

If you get this error when using  "FAISS.from_documents(docs, emb_model)", please make sure that input docs is not empty. Hope it helps !

my docs is not empty . but its showing error in TypeError: cannot pickle '_thread.RLock' object like this

just downgrade your open ai and langchain versions to the specified ones.
then you may encounter an error where it says davinci -002 is a deprecated version then just change the model as
llm = OpenAI(model="gpt-3.5-turbo-instruct", temperature=0.9, max_tokens=500)
you should be fine and good to go... hope this helps

Once you installed all necessary libraries. If same  error still persist , it is because of no data in the data folder.

yaa , i got the solution ...
Try using pdf with less page & check , it won't go out of index .,

File "/usr/local/lib/python3.11/site-packages/langchain/vectorstores/faiss.py", line 347, in __from index = faiss.IndexFlatL2(len(embeddings[0])) ~~~~~~~~~~^^^ IndexError: list index out of range

yaa , i got the solution ...
Try using pdf with less page & check , it won't go out of index .,

Those who are here from the codebasics LLM video
you can use this code -> if process_url_clicked: # load data loader = UnstructuredURLLoader(urls=urls) main_placefolder.text("Data Loading...Started...✅✅✅") data = loader.load()
if data:
    # split data
    text_splitter = RecursiveCharacterTextSplitter(
        separators=['\n\n', '\n', '.', ','],
        chunk_size=1000
    )
    main_placefolder.text("Text Splitter...Started...✅✅✅")
    docs = text_splitter.split_documents(data)

    if docs:
        # create embeddings and save it to FAISS index
        embeddings = OpenAIEmbeddings()
        vectorstore_openai = FAISS.from_documents(docs, embeddings)
        main_placefolder.text("Embedding Vector Started Building...✅✅✅")
        time.sleep(2)

        # Save the FAISS index to a pickle file
        vectorstore_openai.save_local(file_path)
    else:
        main_placefolder.text("Text Splitter produced empty documents. Check data.")
else:
    main_placefolder.text("Data loading failed. Check URLs or network connection.")

Also Note: in the Requirements.txt folder there is python-magic and libmagic which is not required, so uninstall them from pycharm by doing pip uninstall libmagic pip uninstall python-magic pip uninstall python-magic-bin pip install python-magic-bin==0.4.14
Now run the code. Hope it'll be helpful

dude love you!!!! your code solved my index out of list range error but now it is showing error for pickle file being corrupted or incompatible here is it UnpicklingError: invalid load key, '\xef'.
Traceback:
File "C:\Users\Param Jethwa\AppData\Roaming\Python\Python311\site-packages\streamlit\runtime\scriptrunner\exec_code.py", line 88, in exec_func_with_error_handling
result = func()
^^^^^^
File "C:\Users\Param Jethwa\AppData\Roaming\Python\Python311\site-packages\streamlit\runtime\scriptrunner\script_runner.py", line 590, in code_to_exec
exec(code, module.dict)
File "C:\Users\Param Jethwa\langchain\2_news_research_tool_project\main.py", line 67, in
vectorstore = pickle.load(f)
^^^^^^^^^^^^^^

I have changed the api key in env file but it's showing wrong key always please someone know how resolve it please let me know

Thanks for reply here you can see what i am doing I am loading some urls and then splitting the data and creating embeddings using openai and lastly using faiss to store my embeddings but facing the list index out of range. could you please help me to solve the problem.... loader = UnstructuredURLLoader(urls=urls) data = loader.load() # split data text_splitter = CharacterTextSplitter(separator='\n', chunk_size=1000, chunk_overlap=200) docs = text_splitter.split_documents(data) # embeddings embeddings = OpenAIEmbeddings() # save embeddings to FAISS index vectorstore_openai = FAISS.from_embeddings(docs,embeddings)
…
On Sun, 15 Oct 2023 at 01:26, Skisquaw @.> wrote: I posted what I think is the answer already. You have an empty document that you are trying to put into FAISS. Remove any docs that are empty > On Oct 14, 2023, at 9:49 AM, MuvvaThriveni @.> wrote: > > > File "/usr/local/lib/python3.11/site-packages/langchain/vectorstores/faiss.py", line 347, in __from index = faiss.IndexFlatL2(len(embeddings[0])) ~~~~~~~~~~^^^ IndexError: list index out of range > > Not able to solve the error please help me to solve the error > > — > Reply to this email directly, view it on GitHub < #68 (comment)>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABIHCIQ3G53VQSWTEM6CU3DX7K7BTANCNFSM6AAAAAAXQUITZI>. > You are receiving this because you commented. > — Reply to this email directly, view it on GitHub <#68 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2OUNOLKOASD2R7WV23IOHTX7LU6JAVCNFSM6AAAAAAXQUITZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGE3DGNRZG4 . You are receiving this because you commented.Message ID: @.***>
I got a error in that api key is wrong I also changed the key in env but it's showing the same please let me know if you know the answer

I have changed the api key in env file but it's showing wrong key always please someone know how resolve it please let me know

Did you get the solution yet?

No bro
On Sat, Nov 9, 2024, 7:19 PM Pourush31 @.***> wrote:

I have changed the api key in env file but it's showing wrong key always
please someone know how resolve it please let me know
Did you get the solution yet?
—
Reply to this email directly, view it on GitHub
https://github.com/langchain-ai/chat-langchain/issues/68#issuecomment-2466223331,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY4TPHHFGBRTKNS6WP2LRQTZ7YHGBAVCNFSM6AAAAAAXQUITZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGIZDGMZTGE
.
You are receiving this because you commented.Message ID:
@.***>

Did you get it ?
On Sat, Nov 9, 2024, 7:22 PM Dinesh Kumar M @.***>
wrote:

No bro
On Sat, Nov 9, 2024, 7:19 PM Pourush31 @.***> wrote:

I have changed the api key in env file but it's showing wrong key always
please someone know how resolve it please let me know
Did you get the solution yet?
—
Reply to this email directly, view it on GitHub
https://github.com/langchain-ai/chat-langchain/issues/68#issuecomment-2466223331,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY4TPHHFGBRTKNS6WP2LRQTZ7YHGBAVCNFSM6AAAAAAXQUITZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGIZDGMZTGE
.
You are receiving this because you commented.Message ID:
@.***>

For those who are here from codebasics.
For the below code snippet, I got len(data) 0 for urls thing. To avoid it run the blow code it worked for me:
import nltk
nltk.download('averaged_perceptron_tagger')

loader=UnstructuredURLLoader(
    urls=[
        "https://www.moneycontrol.com/news/business/banks/hdfc-bank-re-appoints-sanmoy-chakrabarti-as-chief-risk-officer-11259771.html",
        "https://www.moneycontrol.com/news/business/markets/market-corrects-post-rbi-ups-inflation-forecast-icrr-bet-on-these-top-10-rate-sensitive-stocks-ideas-11142611.html"
    ]
)
data= loader.load()
len(data)

For those who are here from codebasics.
I got len(data) = 0 for urls thing. To avoid it, run the below code it worked for me:
import nltk
nltk.download('averaged_perceptron_tagger')

loader=UnstructuredURLLoader(
    urls=[
        "https://www.moneycontrol.com/news/business/banks/hdfc-bank-re-appoints-sanmoy-chakrabarti-as-chief-risk-officer-11259771.html",
        "https://www.moneycontrol.com/news/business/markets/market-corrects-post-rbi-ups-inflation-forecast-icrr-bet-on-these-top-10-rate-sensitive-stocks-ideas-11142611.html"
    ]
)
data= loader.load()
len(data)

Hi!
is it possible for u to give the full working repo?

I am not getting the output if you get from someone who did that will it be
helpful for me also
On Sun, Dec 22, 2024, 4:16 PM Pourush31 @.***> wrote:

For those who are here from codebasics.
I got len(data) = 0 for urls thing. To avoid it, run the below code it
worked for me:
import nltk
nltk.download('averaged_perceptron_tagger')
loader=UnstructuredURLLoader(
urls=[
"https://www.moneycontrol.com/news/business/banks/hdfc-bank-re-appoints-sanmoy-chakrabarti-as-chief-risk-officer-11259771.html",
"https://www.moneycontrol.com/news/business/markets/market-corrects-post-rbi-ups-inflation-forecast-icrr-bet-on-these-top-10-rate-sensitive-stocks-ideas-11142611.html"
]
)
data= loader.load()
len(data)
Hi!
is it possible for u to give the full working repo?
—
Reply to this email directly, view it on GitHub
https://github.com/langchain-ai/chat-langchain/issues/68#issuecomment-2558412185,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY4TPHGHXNAMJZSGAX6T4YT2G2J75AVCNFSM6AAAAAAXQUITZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJYGQYTEMJYGU
.
You are receiving this because you commented.Message ID:
@.***>


Credentials callback returned an invalid cred type.

Hello, I am having issues with Version Control - Credentials part, I typed in username and Private Access Token, but it still says "Credentials callback returned an invalid cred type.". I was trying to commit to my own public repository, and I tried both Private Access Token and password for this, but still same error comes out. Is there anyone who can help me with this?

Hello. Is it a GitHub repository or from other sites? Also make sure you have given the appropriate permissions to the personal access token.

Hello. Is it a GitHub repository or from other sites? Also make sure you have given the appropriate permissions to the personal access token.

Hi, this is a Github repository, and I checked all permission available.

 Thanks and sorry for taking your time.


Drop resolv.conf hack

This commit drops resolv.conf hack and uses POD's dnsConfig instead
Signed-off-by: Dinar Valeev<EMAIL_ADDRESS>

Fixes https://github.com/k8gb-io/k8gb/issues/712 (nice change)


Create Marshmallow objects/modules package

Add setup.py and setup.cfg files
Implement marshmallow_objects library
Add tests

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0c979c0). Click here to learn what that means.
The diff coverage is 97.95%.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   97.95%
=========================================
  Files             ?        2
  Lines             ?       98
  Branches          ?        0
=========================================
  Hits              ?       96
  Misses            ?        2
  Partials          ?        0

Impacted Files
Coverage Δ

marshmallow_objects/__init__.py
100% <100%> (ø)

marshmallow_objects/models.py
97.91% <97.91%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c979c0...b291586. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0c979c0). Click here to learn what that means.
The diff coverage is 97.95%.

@@            Coverage Diff            @@
##             master       #2   +/-   ##
=========================================
  Coverage          ?   97.95%
=========================================
  Files             ?        2
  Lines             ?       98
  Branches          ?        0
=========================================
  Hits              ?       96
  Misses            ?        2
  Partials          ?        0

Impacted Files
Coverage Δ

marshmallow_objects/__init__.py
100% <100%> (ø)

marshmallow_objects/models.py
97.91% <97.91%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c979c0...d34aeec. Read the comment docs.


Typo "Azure notebook"→"Azure Notebook"

https://docs.microsoft.com/en-us/azure/databricks/applications/mlflow/model-example

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53922162-a109-255b-0c00-87cff80db280
Version Independent ID: ed4b4d6a-3ede-748f-0f7e-7a4848a83455
Content: Model inference example - Azure Databricks
Content Source: databricks/applications/mlflow/model-example.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@hyoshioka0128 - Thanks for the feedback. We will look into it and update you shortly.

@mssaperla - Can you please take a look and do the needful.

Thanks for the feedback. A fix for this typo is currently under review within Databricks.
#please-close

Only Microsoft employees can close issues or pull requests via commenting in this repo.

Thanks again for the feedback. Looking more closely, the Databricks articles were not referring to the (now discontinued) Azure Notebook service, but to Databricks notebooks meant to run on Azure. This is not a typo.
#please-close

Only Microsoft employees can close issues or pull requests via commenting in this repo.

@mdlinville - Thanks.
Closed #61918 .


English translation of README?

I know it might be out of scope for you, but I would be greatly appreciative if there was an English translation of the README file.

Thanks for attention. I'll fix that


network-path: memory and CPU optimization to parseTCP

What does this PR do?
In some profiles we can see that the network path traceroute feature is, in some cases, allocating a lot of memory: example profile.
The goal of this PR is to improve the performance of the parseTCP function from an allocation standpoint but also from a CPU usage point of view.
Benchmarks:
$ go test -benchmem -run=^$ -tags test -bench ^BenchmarkParseTCP$ github.com/DataDog/datadog-agent/pkg/networkpath/traceroute/tcp
# before
BenchmarkParseTCP-10    	 3401749	       338.8 ns/op	     816 B/op	      13 allocs/op
# after
BenchmarkParseTCP-10    	10998318	       103.4 ns/op	     384 B/op	       1 allocs/op

# benchstat
goos: darwin
goarch: arm64
pkg: github.com/DataDog/datadog-agent/pkg/networkpath/traceroute/tcp
cpu: Apple M1 Max
            │   old.txt    │               new.txt               │
            │    sec/op    │   sec/op     vs base                │
ParseTCP-10   334.90n ± 1%   95.70n ± 2%  -71.43% (p=0.000 n=10)

            │  old.txt   │              new.txt               │
            │    B/op    │    B/op     vs base                │
ParseTCP-10   816.0 ± 0%   384.0 ± 0%  -52.94% (p=0.000 n=10)

            │   old.txt   │              new.txt               │
            │  allocs/op  │ allocs/op   vs base                │
ParseTCP-10   13.000 ± 0%   1.000 ± 0%  -92.31% (p=0.000 n=10)

The main things this PR does, is move the things that are not moving, that are re-usable from one call to parseTCP to the next to a structure, owned by handlePackets. This allows parseTCP to reduce drastically the amount of allocation required.
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


test production issue

will work?

Hi, I have some suggestions to help solving this issue!
Here is a list of similar issues:

New issue

new issue

test new issue

new issue

adsaddsa

Also, fjsj made a PR to close a similar issue, so it might be good to ask them for help.
Hope this is useful!
Cheers,
Cinnabot.


Select between  selfie/back camera.

three.js examples seem to use the back camera, while A-Frame examples use the front facing camera.  Not sure why the discrepancy, but there should be some kind of option to be able to select between the two.
Using a samsung galaxy note 4.

https://dev.opera.com/articles/getusermedia-access-camera-privacy-ui/
"Which camera is used is left to the device: "User agents are encouraged to default to using the user's primary or system default camera and/or microphone (as appropriate) to generate the media stream."
So i guess the best case here is to have some kind of camera switch UI.

Thank for reporting and the links. i will read them
honnestly the camera selection is an issue with the new API. i would prefer to avoid the manual selection, to keep the user experience as smooth as possible.
Currently my code is sketchy on that 😢
https://github.com/jeromeetienne/AR.js/blob/master/three.js/threex-artoolkitsource.js#L153

Is there a way to set the back camera as default?

If so I would love to hear 😄
On Sun, May 28, 2017, 1:36 PM curtello<EMAIL_ADDRESS>wrote:

Is there a way to set the back camera as default?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jeromeetienne/AR.js/issues/74#issuecomment-304510979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPcIiMrC_kIv7CcBJs8HtrZczE8kwB1ks5r-Wo-gaJpZM4NoJQ_
.

@jeromeetienne @curtello friggin' back camera is pretty damn elusive on mobile browsers

mozilla prompts it for you, when i tried it locally at least

Yes. The only gentleman on the browser scene.
It does it also when the code is run on the web.

supposedly fix now


[0.8] dom-module nice but not perfect

The example you mentioned template-me what actually indicates already a bit what I mean by perfect.
Nice
<dom-module id="template-me">

  <template>

This is local DOM

  </template>
</dom-module>

Perfect

<dom-template id="template-me-dom">

This is local DOM

</dom-template>

or if the style is going to mess with the other styles then you could do it like this
also notice I prefer attributes.
<dom-style polymer="template-me template-me2">
    div { color: red }
</dom-style>

<dom-template polymer="template-me">

This is local DOM

</dom-template>

You can share dom styles if the polymer attribute allows to define more than one template

I'd rather see everything inside , script and css like the way
it was in 0.5.  then you can only need to specify the  custom element name
once (DRY).  When 0.5 allowed implicit naming, i was happy because i often
forgot to change one name and wondered why my element silently didn't work.
they must have had their reasons for splitting out
You can share dom styles if the polymer attribute allows to define more
than one template
—
Reply to this email directly or view it on GitHub
https://github.com/Polymer/polymer/issues/1380#issuecomment-90747079.

I'd love to see a well documented public facing imperative api for what dom-module is solving.

<template id="template-me">

This is local DOM

</template>

In the example provided,
<dom-module id="register-me">
  <template>

Hello from my local DOM

  </template>
</dom-module>

I don't see the point of having the id attribute on dom-module (id="register-me") AND in the the Polymer call with {is: "register-me"}. It should be one or the other, and I would prefer it to be in the id attribute to align with the DOM over JavaScript philosophy.

Hi
This seems to work without the id attribute on the dom-module provided you declare or import the Polymer declaration inside the dom-module.  I don't know the full implications of doing it this way but this similar to how I was defining elements in 0.5 substituting dom-module with template.
<link rel="import" href="bower_components/polymer/polymer.html">
<link rel="import" href="bower_components/paper-button/paper-button.html">

<dom-module>
    <link rel="import" type="css" href="example-element.css">
    <template>
            <paper-button on-tap="hello">Example Element</paper-button>
    </template>

</dom-module>

that's great as it's more DRY like 0.5.  seems silly over one value, but i
more than once had the values mismatched.
On Fri, Apr 17, 2015 at 2:33 PM Jon Geho<EMAIL_ADDRESS>wrote:

Hi
This seems to work without the id attribute on the dom-module provided
you declare or import the Polymer declaration inside the dom-module. I
don't know the full implications of doing it this way but this similar to
how I was defining elements in 0.5 substituting dom-module with template.

—
Reply to this email directly or view it on GitHub
https://github.com/Polymer/polymer/issues/1380#issuecomment-94047118.

I think @jongeho1's example works because of a (deprecated) method of declaring an element where it used a template immediately preceding the script tag. I would not rely on this continuing to work.
I think the point of having an ID on the dom-module is that it lets you deliver the HTML and JavaScript separately. But maybe @sorvell or @kevinpschaaf can shed more light on the reasoning here.

Thanks @arthurevans. Sounds like there are implications. For custom elements, I think this syntax works well and offers more structure in the composition. Javascript, HTML and CSS may be externalized for development and brought together with a vulcanize. The other syntax is not too far off so not a big deal but be interested to know how long that flavor has to live.

We're investigating supporting a DRY version of dom-module / Polymer. Otherwise we're satisfied with the syntax.


Fix bugs / tests with empty string default for missing assets

Fix a bug with all possible template placeholders being incorrectly detected in some situations
Fix some bugs introduced by https://github.com/prebid/prebid-universal-creative/pull/171 (that were caught by tests, but tests did not run on that PR)
Enable circle tests on PRs
Updated browser list for circleCI (using the same list used in prebid.js)

@muuki88 could anyone from highfivve take a look?

@anitaschiller can take at look on Tuesday. She's out of office tomorrow and Monday.
Maybe I have some time tomorrow ☺

@anitaschiller can take at look on Tuesday. She's out of office tomorrow and Monday.
Maybe I have some time tomorrow ☺
@dgirardi can you elaborate on this statement?

Fix a bug with all possible template placeholders being incorrectly detected in some situations

@muuki88, can you spot it? :)
const placeholderIndex = (~doc.body.innerHTML.indexOf(placeholder)) ? doc.body.innerHTML.indexOf(placeholder) : (doc.head.innerHTML && doc.head.innerHTML.indexOf(placeholder));
if (~placeholderIndex) {
    placeholders.push(placeholderKey);
}

(a refresher, ~(-1) === 0). If the placeholder is not in body.innerHTML and head.innerHTML is falsy, the placeholder was not found but is still added to the list of found placeholders.


If possible, for find-font, add named param to select: mono, serif, or sans

It looks like one of the fontconfig bin programs (fc-list) shows sans, serif, or mono as "atoms" for fonts it lists. You are not presently using the "style" as a named parameter that I see so far.

Latest PDF::Font::Loader 0.7.1 has a :serif option. :serif for :serif fonts and :!serif for sans-serif fonts. This is implemented by passing serif or sans-serif as the family name to fontconfig, which should treat these as special generic font names. See https://wiki.archlinux.org/title/Font_configuration/Examples#Default_fonts
Also, this release passes any additional find-font or load-font options through to fontconfig.  A monospace font can be selected by passing :spacing<mono>, which is a standard fontconfig property.

Thanks, David!


custodian sans subcommands raises error

This appears to have been regress for a while
 $ custodian
Traceback (most recent call last):
  File "/Users/kapil/projects/cloud-custodian/bin/custodian", line 11, in <module>
    load_entry_point('c7n', 'console_scripts', 'custodian')()
  File "/Users/kapil/projects/cloud-custodian/c7n/cli.py", line 335, in main
    _setup_logger(options)
  File "/Users/kapil/projects/cloud-custodian/c7n/cli.py", line 301, in _setup_logger
    level = 3 + (options.verbose or 0) - (options.quiet or 0)
AttributeError: 'Namespace' object has no attribute 'verbose'

expected output
$ custodian
usage: custodian [-h] {report,logs,metrics,version,validate,schema,run} ...

Cloud fleet management

positional arguments:
  {report,logs,metrics,version,validate,schema,run}
    report              Report of resources that a policy matched/ran on. The
                        default output format is csv, but other formats are
                        available.
    logs                Get policy execution logs from s3 or cloud watch logs
    metrics             Retrieve metrics for policies from CloudWatch Metrics
    version             Display installed version of custodian
    validate            Validate config files against the json schema
    schema              Interactive cli docs for policy authors
    run                 Execute the policies in a config file Multiple regions
                        can be passed in, as can the symbolic region 'all'.
                        When running across multiple regions, policies
                        targeting resources in regions where they do not exist
                        will not be run. The output directory when passing
                        multiple regions is suffixed with the region.
                        Resources with global endpoints are run just once and
                        are suffixed with the first region passed in or us-
                        east-1 if running against 'all' regions.

optional arguments:
  -h, --help            show this help message and exit

there's some variance here between python2 and python3, so its not per se a regression, just a compatibility issue, python2 does currently do a short form message like this
$ custodian
usage: custodian [-h] {report,logs,metrics,version,validate,schema,run} ...
custodian: error: too few arguments

where as python3 gives that traceback above.


Show something if icon can not be found

If I mistype the icon name, and I don't have an image, then it should show me something other than the ghost indicator.
eg I type "standard:accoun" and miss the t on the end.
Suggest showing a blank icon like standard:default

@tschug just adding this one for you, because I know you were working on this, and it is a lovely idea.

I like the concept, but I do think it's too heavy of a lift to be able to verify the 2nd half.  We could do the standard: and custom: stuff, but I'm skeptical of being able to "spell check" users.
Previously, I demoed hardcoded a default value for an Icon when both the name and image were not configured for an indicator, but I removed that when we set up that if everything is left blank then do not show an icon at all.
However, this wouldn't work because there's a typo in the Icon Name.  And I don't think the SLDS Avatar notifies us if the icon doesn't exist, which means we'd have to track every valid option somewhere (CMDT or Custom Setting or CSV Static Resource) in order to validate it.
My concern is needing to manage the package with an upgrade every time SLDS adds a new icon.  Right now, UnofficialSF is storing it as hardcoded list..  Ideally we'd retrieve this from a resource that can be managed by the user in a pinch, which is why I listed those 3 options above.

There is idea to try:
If you use tag image and check url of icon you can set flag for icon display and do conditional display based on this flag.
This would be invisible image because of width and height size is set to 1. Purpose of it is to set flag.
HTML:

in controller you can define value for flag and then use it in HTML to display default icon.
controller methods
Controller.js
pageOnline: function(component, event, helper) {
component.set("v.urlValid",true);
},
pageOffline: function(component, event, helper) {
component.set("v.urlValid",false);
},
If I understand well issue details this may work.
Let me know


PERF: Add a way to disable snapshot change tracking

For the cases where the user is explicitly painting changes via the Entry APIs.

We need to keep in mind:

We should try to measure the impact against snapshotting and notification entities before we make the actual change
Currently original value relies on snapshots. We would need to change the entry APIs to copy the original value the first time there is a change
Change detection be automatically disabled when this option is enabled


feat: add non-root container check

Introducing the non-root container check for Dockerfiles in repository (eclipse-tractusx/sig-infra#91).
The check will use the previously added helper function container.findDockerfilesAt() function to get all Dockerfiles in repo. Afterwards the Dockerfiles will be parsed for USER instruction and validate the provided username/group-name/uid/gid.
Valid usernames follows the adduser recommendations, please refer to https://manpages.debian.org/unstable/adduser/adduser.conf.5.en.html#NAME_REGEX for details.
Go dependencies has been updated and DEPENDENCIES file is up to date.
Unhandled circumstance:

No USER instruction is found in Dockerfile.

Decision required if Test should fail or pass in this case.

LGTM

close this due to messed up commit history. New PR #55


Capstone Simulator Latency

Facing severe latency/lag when using the simulator for the capstone project. This happens specifically when the camera is turned on. Also, when the generated waypoints in the waypoint-updater node are set to the default 200 (camera off), the same latency appears (seems kind of OK if the waypoints are reduced to 50).
I have a Windows 7 machine with i7 / 32 GB of RAM and a GPU. I first used the simulator inside the VM (with 6 CPU allocated + around 12GB RAM). Then I moved on to a native install by converting the provided VM to a physical drive via Clonezilla. However, I don't see any decrease in latency even after moving to a native install.
I contacted support & was told that there are no known issues but obviously there are. Apart from getting frustrated and wasting a lot of time, this is stopping me from completing the final project in a timely fashion. A quick search over Slack & the forum reveals that a number of students are facing the same issue. I request for a speedy resolution of this issue. Thanks

I am having the same issue on two different machines

Capstone project has now been moved to a workspace to help isolate any particular issues - please re-open if you see the same issues arising within the workspace.

@mvirgo I have been using the workspace recently.
Things stay good till the int camera is NOT ON.
With camera being ON, Car barely manages to stay on track for 10 seconds and then goes off.
So workspace does not seem to be the solution for the problem reported.
Video https://drive.google.com/file/d/1NrsOC8JU-d9X2XXB3pPnrqZMm-JCDIrX/view?usp=sharing

@MyCodeBits Can you post your internet connection speed as well as what browser you are using?

@MyCodeBits Can you post your internet connection speed as well as what browser you are using?

Hi @mvirgo. Thanks for quick response. Earlier videos/tests were using Chrome Browser in last comment.
Internet connection speed
Chrome on Host m/c (mac OS)

Firefox inside Workspace

Created another video of what the current state is at the workspace using Firefox on host (Mac OS) accessing Workspace at July 25th 3:00 PM PST

Car without CAMERA ON goes off track. https://drive.google.com/open?id=1mSMFCYRNuoPm-sZUnOWjaLejragU5FU9

I would be happy if you want me to try any instrumented code for any reason.
Further please note that there are other people in my team who are facing the same issue who are geographically at different locations.
My understanding is that given the workspace is remote, if one has a decent enough internet connection, the connection speed in remote workspace only should be of consideration. Please comment if i am missing/over simplifying.
CC @SIakovlev

On the observation for Workspace getting struck: till the manual operation is present, the terminal runs at nominal pace. when the manual checkbox is unchecked, then the program runs at a slower pace.
For each image topic received
Actual Time                         Delta time from previous
1532625293.0018000000    0.4056799412
1532625293.5656900000    0.5638899803
1532625293.9795300000    0.4138400555
1532625294.5536900000    0.5741598606
1532625295.1094800000    0.5557899475
1532625295.5538500000    0.4443700314
1532625295.9139400000    0.3600900173
1532625296.2937000000    0.3797600269
1532625296.8977800000    0.6040799618
1532625297.3851800000    0.4874000549
1532625297.7796800000    0.3945000172
1532625298.2115300000    0.4318499565
1532625298.6865300000    0.4750001431
1532625299.1741400000    0.4876098633
1532625299.5141200000    0.3399801254
1532625300.0766600000    0.5625398159
1532625300.5452900000    0.4686300755
1532625300.8820800000    0.3367900848
1532625301.2525100000    0.3704299927
1532625301.6422000000    0.3896899223
1532625302.0498000000    0.4075999260
1532625302.4078500000    0.3580501080
1532625302.7898200000    0.3819699287
1532625303.1111800000    0.3213601112
1532625303.4052600000    0.2940800190
1532625303.9557500000    0.5504899025
1532625304.3985300000    0.4427800179
1532625304.7305400000    0.3320100307
1532625305.1275000000    0.3969600201
1532625305.5279200000    0.4004199505
1532625305.9520800000    0.4241600037
1532625306.3499500000    0.3978700638
1532625306.7005000000    0.3505499363
1532625307.1803400000    0.4798400402
1532625307.6294700000    0.4491300583
1532625308.0477500000    0.4182798862
1532625308.4741300000    0.4263799191
1532625308.8001100000    0.3259801865
1532625309.1900000000    0.3898899555
1532625309.6295500000    0.4395499229
1532625310.0781400000    0.4485900402
1532625310.3754400000    0.2972998619
1532625310.8115100000    0.4360702038
1532625311.2482000000    0.4366898537
1532625311.6494300000    0.4012300968
1532625311.9611100000    0.3116800785
1532625312.4449300000    0.4838199615
1532625312.8244400000    0.3795099258
1532625313.2389800000    0.4145400524
1532625313.6539400000    0.4149599075
1532625314.0785500000    0.4246101379
1532625314.7061800000    0.6276299953
1532625315.1100900000    0.4039099216
1532625315.3070800000    0.1969900131
1532625315.3842100000    0.0771300793
1532625315.4616300000    0.0774199963
1532625315.5367000000    0.0750699043
1532625315.6145000000    0.0778000355
1532625315.6913000000    0.0767998695
1532625315.7682300000    0.0769300461
1532625315.8403500000    0.0721199512
1532625315.9141200000    0.0737700462
1532625315.9960000000    0.0818800926
1532625316.0744300000    0.0784299374
1532625316.1645600000    0.0901300907
1532625316.2793400000    0.1147799492
1532625316.3689000000    0.0895600319
1532625316.4614500000    0.0925500393
1532625316.5559000000    0.0944499969
1532625316.6602500000    0.1043498516
1532625316.7534200000    0.0931701660
1532625316.8396400000    0.0862197876
1532625316.9276100000    0.0879700184
1532625317.0184100000    0.0908000469
1532625317.1038900000    0.0854799747
1532625317.2116200000    0.1077301502
1532625317.2978300000    0.0862100124
1532625317.4037900000    0.1059598923
1532625317.4947600000    0.0909700394
1532625317.5928800000    0.0981199741
1532625317.6964200000    0.1035399437
1532625317.7957400000    0.0993199348
1532625317.8946900000    0.0989501476
1532625317.9857900000    0.0910999775
1532625318.0801800000    0.0943899155
1532625318.1683300000    0.0881500244
1532625318.2614400000    0.0931100845
1532625318.3467600000    0.0853199959
1532625318.4351000000    0.0883400440
1532625318.5383200000    0.1032199860
1532625318.6375100000    0.0991899967
1532625318.7277300000    0.0902199745
1532625318.8281400000    0.1004099846
1532625318.9242300000    0.0960900784
1532625319.0219600000    0.0977299213
1532625319.1298200000    0.1078600883
1532625319.2173200000    0.0874998569
1532625319.3214600000    0.1041400433
1532625319.4047700000    0.0833098888
1532625319.5123000000    0.1075301170
1532625319.6167000000    0.1043999195
1532625319.7118300000    0.0951299667
1532625319.8026800000    0.0908501148
1532625319.8751700000    0.0724899769
1532625319.9713200000    0.0961499214
1532625320.0650900000    0.0937700272
1532625320.1593000000    0.0942101479
1532625320.2509800000    0.0916798115
1532625320.3423000000    0.0913200378
1532625320.4300000000    0.0877001286
1532625320.5175900000    0.0875899792
1532625320.6145500000    0.0969600677
1532625320.7099100000    0.0953598022
1532625320.8370000000    0.1270899773
The top rows are when Manual is unselected and Camera is selected. Bottom rows are when both Manual and Camera selected.  So the camera processing is not creating any problem. When manual is selected, the delay between two topics received by our program is about 0.5 seconds whereas in the other case it is <0.1 seconds.
Left side is the clock info, right column is the delta between previous to current clock.

Couple items for further clarification and testing on our end -
1 - How is the performance of the simulator within each browser?
2 - Are you running a detection model when you unselect Manual mode? That is when the code starts calling to a detection model (or attempting to). Depending on how you've coded this call, or how large the model is (if one is included), can have a big impact here.

@mvirgo

Couple items for further clarification and testing on our end -
1 - How is the performance of the simulator within each browser?
I did try with Safari and Chrome with not much changes. Performance was bad on both.

2 - Are you running a detection model when you unselect Manual mode? That is when the code starts calling to a detection model (or attempting to). Depending on how you've coded this call, or how large the model is (if one is included), can have a big impact here.
When I am testing my code, there is not detection code deployed. You can assume it to be walkthrough code getting tested, where car will move forward ignoring Traffic Lights.

CC @SIakovlev

I have the same problem. Since I see the issue is closed, is there a solution to the problem or not?

I have the same problem as well. In workspace and on my laptop.

Performance is still very bad. To the point of being unusable. Any way to get better performance out of the simulator when the camera is turned on?

I have the same problem with the workspace, I tried the docker option locally but the car still goes off, although I don't have a GPU. My system info is:
OS: Ubuntu 18.04
Processor: intel core i7 @ 2.00 GHz
RAM: 8 GB
My question is: is a GPU required in order to be able to run the project?

I toohave the same problem.

Same here, lags with VM ROS and local simulator, but somehow at least for a part of the track usable if waypoint frequency is reduced to 10Hz. Workspace really bad, Docker only usable without Camera.
I'm using Arch Linux locally, so in theory I could run native ROS, but unfortunately Opencv3 in ROS doesn't work.
My Maschine is a Intel Core i7 Notebook with 16GiB RAM and an nvidia gtx 950m

Any solution for the problem?

Hopefully this article can help
<EMAIL_ADDRESS>


Syntax for namespaces

We need some syntax to create local namespaces. Maybe something like:
namespace abc
	...
end

(I mean why over complicate this?)
This would be usefull in the lua-compiler, if we want to add love-bindings, since it's kinda namespaced.

I would say either
abc :: namespace do
    ...
end

or
abc :: namespace {
    ...
}

It would be more in line with the language as it is currently.

Unclear if this is needed or not.


[FLINK-11504] Remove invalid test JobManagerConnectionTest

What is the purpose of the change
This test tests really legacy classes. We now have rpc abstractions and their own tests.
Brief change log
Delete JobManagerConnectionTest.scala
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector:(no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

cc @tillrohrmann

Test is covered in org.apache.flink.runtime.rpc.akka.AkkaRpcActorTest#testFailingAddressResolution.


Allowing usage of a session to download files from host.

While working on Zuul tests, I realized that in order to download a file from Zuul I need to have the SSL session up and running. I already got that, but I could not pass it to the 'download' function. This request adds the opportunity to override the HTTP session that the function uses to perform the request.

To pass CI make sure that #286 is incorporated


[CI] FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout

Test failure introduced in #1167 was caught on PR #1440. Looks like a race condition as this test juggles a lot of timing variables? I think this whole test implementation needs to be simplified (perhaps a separate issue).
REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout" -Dtests.seed=58869CBBC128ED5C -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=uk-UA -Dtests.timezone=America/Kralendijk -Druntime.java=17

Suite: Test class org.opensearch.monitor.fs.FsHealthServiceTests
  1> [2021-10-26T13:58:12,070][INFO ][o.o.e.NodeEnvironment    ] [testLoggingOnHungIO] using [1] data paths, mounts [[/ (/dev/root)]], net usable_space [68.3gb], net total_space [96.8gb], types [ext4]
  1> [2021-10-26T13:58:12,086][INFO ][o.o.e.NodeEnvironment    ] [testLoggingOnHungIO] heap size [512mb], compressed ordinary object pointers [true]
  1> [2021-10-26T13:58:12,397][WARN ][o.o.m.f.FsHealthService  ] [testLoggingOnHungIO] health check of [/var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/server/build/testrun/test/temp/org.opensearch.monitor.fs.FsHealthServiceTests_58869CBBC128ED5C-001/tempDir-003/nodes/0] took [401ms] which is above the warn threshold of [106ms]
  1> [2021-10-26T13:58:12,499][INFO ][o.o.m.f.FsHealthServiceTests] [testFailsHealthOnHungIOBeyondHealthyTimeout] before test
  1> [2021-10-26T13:58:12,572][INFO ][o.o.e.NodeEnvironment    ] [testFailsHealthOnHungIOBeyondHealthyTimeout] using [3] data paths, mounts [[/ (/dev/root)]], net usable_space [68.3gb], net total_space [96.8gb], types [ext4]
  1> [2021-10-26T13:58:12,572][INFO ][o.o.e.NodeEnvironment    ] [testFailsHealthOnHungIOBeyondHealthyTimeout] heap size [512mb], compressed ordinary object pointers [true]
  1> [2021-10-26T13:58:12,609][INFO ][o.o.m.f.FsHealthServiceTests] [testFailsHealthOnHungIOBeyondHealthyTimeout] --> Initial health status prior to the first monitor run
  1> [2021-10-26T13:58:12,611][INFO ][o.o.m.f.FsHealthServiceTests] [testFailsHealthOnHungIOBeyondHealthyTimeout] --> First monitor run
  1> [2021-10-26T13:58:12,666][INFO ][o.o.m.f.FsHealthServiceTests] [testFailsHealthOnHungIOBeyondHealthyTimeout] --> Disrupt file system
  1> [2021-10-26T13:58:14,751][INFO ][o.o.m.f.FsHealthServiceTests] [testFailsHealthOnHungIOBeyondHealthyTimeout] --> Fix file system disruption
  1> [2021-10-26T13:58:14,769][WARN ][o.o.m.f.FsHealthService  ] [org.opensearch.monitor.fs.FsHealthServiceTests] health check of [/var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/server/build/testrun/test/temp/org.opensearch.monitor.fs.FsHealthServiceTests_58869CBBC128ED5C-001/tempDir-005/nodes/0] took [1430ms] which is above the warn threshold of [199ms]
  1> [2021-10-26T13:58:14,770][ERROR][o.o.m.f.FsHealthService  ] [org.opensearch.monitor.fs.FsHealthServiceTests] health check of [/var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/server/build/testrun/test/temp/org.opensearch.monitor.fs.FsHealthServiceTests_58869CBBC128ED5C-001/tempDir-005/nodes/0] failed, took [1430ms] which is above the healthy threshold of [752ms]
  1> [2021-10-26T13:58:16,110][WARN ][o.o.m.f.FsHealthService  ] [org.opensearch.monitor.fs.FsHealthServiceTests] health check of [/var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/server/build/testrun/test/temp/org.opensearch.monitor.fs.FsHealthServiceTests_58869CBBC128ED5C-001/tempDir-006/nodes/0] took [222ms] which is above the warn threshold of [199ms]
  1> [2021-10-26T13:58:16,228][INFO ][o.o.m.f.FsHealthServiceTests] [testFailsHealthOnHungIOBeyondHealthyTimeout] after test
  2> REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout" -Dtests.seed=58869CBBC128ED5C -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=uk-UA -Dtests.timezone=America/Kralendijk -Druntime.java=17
  2> java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([58869CBBC128ED5C:DAF2C2B2B5D49B14]:0)
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertTrue(Assert.java:52)
        at org.opensearch.monitor.fs.FsHealthServiceTests.testFailsHealthOnHungIOBeyondHealthyTimeout(FsHealthServiceTests.java:239)

another failure on #1469. Should the timeout variables be more conservative?

Todays main test passed on #1469 so close it.


UnknownEventKind 6

Describe the bug
kind:6 but UnknownEventKind occured.
To Reproduce
Steps to reproduce the behavior:
See https://snort.social/e/note19lcv9jck7gu9kj2e5wwyz5kr8ku6h4duscv9rp7j0ledvu9vrrzs6p4e3l
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

As per the readme file, snort does not yet support NIP-18 which introduces the event kind 6, which is a repost event.
@v0l please close this issue if the above explanation is valid 👆🏽

We dont support replying to reposts (yet?)


[OpenAI] Add OpenAI-API-compatible function calling support

For the record, tested it with n > 1, stateful = true with multiround of function calling request, and streaming. All worked very well. Here is a screen shot of running example/open_ai.ts:


Added command for running cypress against review app

Cypress can be launched against a review app for a particular pull request with
yarn run open:reviewapp PR_NUMBER

eg
yarn run open:reviewapp 586

Thanks @jebw :)


The chairman application only connects to "Core node 0".

https://github.com/input-output-hk/cardano-node/blob/070cb238baa176a3f9011b3f0c60ea0c901f41ce/cardano-node/src/Cardano/Chairman.hs#L114
This will create one connection per core node, but they will all be towards "Core node 0".

Thank you for catching this @karknu !


Add valid_tls_protocols_in to allow for per-domain protocols.

This has merge conflicts, and we'll need a new 8.1.x PR. Also, feel free to recommend / suggest other PRs that this depends on, such that it makes the back porting easier.


Change BaseUnityPlugin to UKMod, fix bugs

Reference UMM (sorry Maranara, I broke your references :P)
Chang mod to be a UKMod instead of a BaseUnityPlugin
Fix a animation bug where you could have two fists out at the same time
Made fist icon represent last fist used
Fix a animation bug where two fists would be active at the same time, now the last fist used will be active

I also added unloading, forgot to include that. Feel free to change the description/version/name until you like it.