[reggen] Remove FIFO depth when window is used

Problem:
reggen creates unintentional TL-UL buffers inside `tl_socket_1n` for
window feature, which creates higher number of outstanding
acceptances in the device port.

When window feature was implemented, tlul_fifo_sync doesn't have a
way to remove internal FIFO. So, when instantiating tl_socket_1n for
window requests, ReqDepth and RspDepth are set to 1h. It results
in the number of outstanding acceptances in a IP that having a window
port, to be more than or equal to 4 at least. One buffer in HReq,
another in DReq, 1 in DRsp, and 1 in DReq.
This PR is to remove the FIFO inside tlul_socket_1n, thanks to @tjaychen
added the condition of Depth == 0 and Pass == 1 case.
The IPs, for instance HMAC, still have a buffer internally. If
tlul_adpater_sram is used to convert TL-UL interface to the SRAM
interface, that module still has buffers internally.
The issue is discussed in #860
Signed-off-by: Eunchan Kim<EMAIL_ADDRESS>

@cindychip still I see the failure of max_outstanding limit. tlul_adapter_sram can store two outstanding requests, so the value should be changed to 3h I think. Could you please double-check in your side?

Oh thanks for the reminder Eunchan, my PR has not merged yet.
https://github.com/lowRISC/opentitan/pull/871
On Tue, Nov 5, 2019 at 3:25 PM Eunchan Kim<EMAIL_ADDRESS>wrote:

@cindychip https://github.com/cindychip still I see the failure of
max_outstanding limit. tlul_adapter_sram can store two outstanding
requests, so the value should be changed to 3h I think. Could you please
double-check in your side?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/884?email_source=notifications&email_token=ACXPOONIZMP2VYTHIEFZPHDQSH6FHA5CNFSM4JJMMKK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDEWJUA#issuecomment-550069456,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXPOONAV4HSAQ5JKHU6SDTQSH6FHANCNFSM4JJMMKKQ
.

LGTM

LGTM, my testbench has some UVM warning, I will debug one that. Thanks for the implementation.

Thanks. I will wait merging until you root-cause the issue.

Thanks Eunchan,
Seems like the fifo_depth prediction is not correct in my testbench, I will
find a new probing signal (relying on tlul interface seems not enough) to
update when fifo writes. Will let you know once the PR is up.
On Tue, Nov 5, 2019 at 8:44 PM Eunchan Kim<EMAIL_ADDRESS>wrote:

LGTM, my testbench has some UVM warning, I will debug one that. Thanks for
the implementation.
Thanks. I will wait merging until you root-cause the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/884?email_source=notifications&email_token=ACXPOOKKBFKTVG3AU4N3SJ3QSJDTRA5CNFSM4JJMMKK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDFH2YQ#issuecomment-550141282,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXPOONBAL2SK6E3F5VKFJTQSJDTRANCNFSM4JJMMKKQ
.

Thansk for the update. Do you want me to merge this design and digging or just
want this PR to be waited?
On Wed, Nov 06, 2019 at 08:55:17AM -0800, cindychip wrote:

Thanks Eunchan,
Seems like the fifo_depth prediction is not correct in my testbench, I will
find a new probing signal (relying on tlul interface seems not enough) to
update when fifo writes. Will let you know once the PR is up.
On Tue, Nov 5, 2019 at 8:44 PM Eunchan Kim<EMAIL_ADDRESS>wrote:

LGTM, my testbench has some UVM warning, I will debug one that. Thanks for
the implementation.
Thanks. I will wait merging until you root-cause the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/884?email_source=notifications&email_token=ACXPOOKKBFKTVG3AU4N3SJ3QSJDTRA5CNFSM4JJMMKK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDFH2YQ#issuecomment-550141282,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXPOONBAL2SK6E3F5VKFJTQSJDTRANCNFSM4JJMMKKQ
.

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/lowRISC/opentitan/pull/884#issuecomment-550401354

Thanks for asking, I think you can go ahead merge. I am pretty sure it is
not any design issue - as I turn off the fifo depth checking, the digest
and everything else is correct.
On Wed, Nov 6, 2019 at 9:15 AM Eunchan Kim<EMAIL_ADDRESS>wrote:

Thansk for the update. Do you want me to merge this design and digging or
just
want this PR to be waited?
On Wed, Nov 06, 2019 at 08:55:17AM -0800, cindychip wrote:

Thanks Eunchan,
Seems like the fifo_depth prediction is not correct in my testbench, I
will
find a new probing signal (relying on tlul interface seems not enough) to
update when fifo writes. Will let you know once the PR is up.
On Tue, Nov 5, 2019 at 8:44 PM Eunchan Kim<EMAIL_ADDRESS>wrote:

LGTM, my testbench has some UVM warning, I will debug one that. Thanks
for
the implementation.
Thanks. I will wait merging until you root-cause the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/lowRISC/opentitan/pull/884?email_source=notifications&email_token=ACXPOOKKBFKTVG3AU4N3SJ3QSJDTRA5CNFSM4JJMMKK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDFH2YQ#issuecomment-550141282
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ACXPOONBAL2SK6E3F5VKFJTQSJDTRANCNFSM4JJMMKKQ

.

--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/lowRISC/opentitan/pull/884#issuecomment-550401354

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/884?email_source=notifications&email_token=ACXPOOMEAKTXUEEAZ4CJJSLQSL3U5A5CNFSM4JJMMKK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDHJRAI#issuecomment-550410369,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXPOOKK37V4ZOX3OIBRGGTQSL3U5ANCNFSM4JJMMKKQ
.


Can't accept suggestion with tab

Set "emmet.triggerExpansionOnTab": true
Open some .ts file, trigger suggestions, press tab
I expect it to accept the current suggestion, but it just inserts a tab instead

I see that it's running editor.emmet.action.expandAbbreviation every time I press tab in the editor, I don't know it worked before but seems probably related to https://github.com/microsoft/vscode/pull/110891

I'm seeing the same broken behavior for all types of suggestion (also while programming TS): fields, methods, tabnine...
❌ Affected version (broken):
Version: 1.52.0-insider
Commit: caf01baa45b9816e2e1d8a2de22b40cf89459c03
Date: 2020-11-20T07:35:38.417Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0

✅ Confirmed that behavior is correct (not broken) in my stable version:
Version: 1.51.1
Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
Date: 2020-11-11T01:11:34.018Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0

Duplicate of https://github.com/microsoft/vscode/issues/111119


Return statements clip into the bottom of other statements

Describe the bug
The return statement clips into the bottom of other statements when it is inside of those statements.
To Reproduce
Steps to reproduce the behavior:

Create a function.
Put a if statement in that function.
Grab a return statement in that block. This might happen with other ending blocks, although this is not tested.
The return statement now intersects the bottom of the if statement.

Note that this happens with the return statement by itself, it appears to clip into the function block slightly.
Expected behavior
The return statement terminates the if statement cleanly. That being there isn't any clipping going on.
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser: Firefox
Version: 113.0.1 (64-bit) (Original Bug Report Version - Confirmed broken on 125.0.3 (64-bit))

Additional context
I'm not entirely sure about the Issues Policy.
This issue was ignored in https://github.com/microsoft/pxt-microbit and has been posted here as a result of that. The original issue can be found at https://github.com/microsoft/pxt-microbit/issues/5142 and has not been closed.

Issue Clarification: Return statement visuals are buggy in general, and don't just occur with if statements.

Bug is tracked in pxt-microbit repo.


[feature request] simple query to return health of the node for writes

See https://groups.google.com/forum/#!msg/influxdb/O50VLuuNGRs/kYR-NbZ3DwAJ for the use case. Right now there's no way to know a cluster is good for writes except to send a write. However, writes must be POSTed, and many load balancer checks (ELB for example) can only issue GETs.

Fixed by https://github.com/influxdb/influxdb/pull/4600/files


port: [#3986] Deletes old team projects (#6005)

Fixes #3986
Description
To have botbuilder-js consistent with .net version, we are removing old Teams projects.
Specific Changes

Deleted folder testing/teams-scenario with its contents.
Updated testing/README file to remove references to the deleted projects.

Testing
This image shows the CI pipelines passing after the changes.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 84.543%

Files with Coverage Reduction
New Missed Lines
%

libraries/botbuilder-lg/src/templateExtensions.ts
1
84.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
19660

Relevant Lines:
22028

💛  - Coveralls


[FLINK-30702] Add Elasticsearch dialect

https://issues.apache.org/jira/browse/FLINK-30702

@MartijnVisser Hi! I've fixed code formatting, so I think build can be rerun now. Thanks!

@eskabetxe Could you review the PR, please?

Due to recent refactoring it was easier to create a new PR: https://github.com/apache/flink-connector-jdbc/pull/136
Closing this one.


Starling 24/25 showing as ‘01/04/21’

Could this be because there is no confirmed date yet? Is it possible for them to be removed until there is a date?

Date_precision is set to month, so it means that Starlink 24 and 25 should launch in April, but there's no fixed date as of today.

See https://github.com/r-spacex/SpaceX-API/tree/master/docs/v4#launch-date-faqs

Sorry, didn't see that. Is there anyway to hide the ones where the date precision is set to month?

When sorted by flight_number, these show up in the correct order.
But when sorted by date, it is incorrect.
I assume the launch date is not known, thus defaulting to April 1st, which has passed.
If the launch is expected in April, should the dates be set to end of April?

@ChopsKingsland
POST to https://api.spacexdata.com/v4/launches/query with the body:
{
    "query": {
        "upcoming": true,
        "date_precision": {
          "$ne": "month"
        }
    },
    "options": {
        "sort": {
            "flight_number": "asc"
        }
    }
}

Should get you what you're looking for 👍

Thanks, it works better now, as Crew-2 has been moved in front of the starlink ones, so my app isn't always showing t+


Huge Backup import "Work-horse was terminated unexpectedly (waitpid returned 9)".

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Steps to Reproduce (for bugs)

imported Visdrone2019-det-train dataset with ~6.500 frames and +300.000 objects in YOLO 1.1 format
did a backup via CVAT UI of the Visdrone2019-det-train task
Searched & Replaced annotations.json with vim to merge classes (e.g. people & pedestrian => person)
Tryed to import the modified backup (Download)
Error: Request failed with status code 500. "Work-horse was terminated unexpectedly (waitpid returned 9)". after long waiting time.
importing the original backup ends with the same error.

I guess the ammount of annotations is just too huge! What can I do? Extend some timeout?
Your Environment

Git hash commit (git log -1): a8e921bdd7d008f6b7a9a07430956a5fba6385f5
Docker version docker version (e.g. Docker 17.0.05): Docker Engine 24.0.2
Are you using Docker Swarm or Kubernetes? ❌
Operating System and version (e.g. Linux, Windows, MacOS): macOS

Importing in YOLO 1.1 works. Had to split in 3 parts with ~2.500 frames each to make reimport work. Stil I'm wondering if there is some option to make it work anyway? Increase Docker's memory & CPU? Is there something else that might help?

Most likely the process was killed due to OOM, try increasing the memory limit for the cvat_worker_export container or RAM on the host if the limits are not set


Fixing the styling of sign up page

Description
As the the styling of Sign up page is disturbed , the cancel and submit button also going out of the container
I Would like to fix this
Screenshots

@beRajeevKumar please assign this task to mee Because I really loved your website and want contribute with you.
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I'm a GSSoC'24-Extd contributor
[X] I'm a Hacktoberfest'24 contributor
[X] I am willing to work on this issue (optional)

@beRajeevKumar Please assign this task to me


[Android] fetch doesn't work for https://...

08-09 18:08:29.066 1018-2224/com.zerocar W/ReactNativeJS: Network request failed

it is not able to request https on android platform since android native doesn't support it.

there should be better documentation since it doesn't say anything or make changes on native module. sorry i have no experience to fix this kind of issue. 😢

Are you sure the https certificate is signed correct?
See also this: https://developer.android.com/training/articles/security-ssl.html
I had once problems with connecting to a ssl connection when I was working on pure native Android because of this.
I think ssl request should just work in react native. However have not tested it myself.
Good luck with fixing it. Maybe you should try another https api to see if it the same problem occurs.

i use https and it's ok with fetch

I created new project with $ react-native init but it still not working.
I/ReactNativeJS: { err: [TypeError: Network request failed] }

This is what i did.
/**
 * Sample React Native App
 * https://github.com/facebook/react-native
 * @flow
 */

import React, { Component } from 'react';
import {
  AppRegistry,
  StyleSheet,
  Text,
  View
} from 'react-native';

class TestFetch extends Component {
  componentDidMount() {
    fetch('https://engine.socar.kr')
      .then(res => {
        console.log({ res });
      })
      .catch(err => {
        console.log({ err });
      })
  }

  render() {
    return (
      <View style={styles.container}>
        <Text style={styles.welcome}>
          Welcome to React Native!
        </Text>
        <Text style={styles.instructions}>
          To get started, edit index.android.js
        </Text>
        <Text style={styles.instructions}>
          Double tap R on your keyboard to reload,{'\n'}
          Shake or press menu button for dev menu
        </Text>
      </View>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#F5FCFF',
  },
  welcome: {
    fontSize: 20,
    textAlign: 'center',
    margin: 10,
  },
  instructions: {
    textAlign: 'center',
    color: '#333333',
    marginBottom: 5,
  },
});

AppRegistry.registerComponent('TestFetch', () => TestFetch);

I created new project with $ react-native init but it still not working.
I/ReactNativeJS: { err: [TypeError: Network request failed] }

This is what i did.
/**
 * Sample React Native App
 * https://github.com/facebook/react-native
 * @flow
 */

import React, { Component } from 'react';
import {
  AppRegistry,
  StyleSheet,
  Text,
  View
} from 'react-native';

class TestFetch extends Component {
  componentDidMount() {
    fetch('https://google.com')
      .then(res => {
        console.log({ res });
      })
      .catch(err => {
        console.log({ err });
      })
  }

  render() {
    return (
      <View style={styles.container}>
        <Text style={styles.welcome}>
          Welcome to React Native!
        </Text>
        <Text style={styles.instructions}>
          To get started, edit index.android.js
        </Text>
        <Text style={styles.instructions}>
          Double tap R on your keyboard to reload,{'\n'}
          Shake or press menu button for dev menu
        </Text>
      </View>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    justifyContent: 'center',
    alignItems: 'center',
    backgroundColor: '#F5FCFF',
  },
  welcome: {
    fontSize: 20,
    textAlign: 'center',
    margin: 10,
  },
  instructions: {
    textAlign: 'center',
    color: '#333333',
    marginBottom: 5,
  },
});

AppRegistry.registerComponent('TestFetch', () => TestFetch);

Actually it's working. Maybe our server setup has something wrong. sorry for confusion.

The HTTPS certicate is not properly signed and Android blocks that. https://developer.android.com/training/articles/security-ssl.html


fix: [WIP] input delay truncation

Description
Fixes # (issue)
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/input-delay-truncation

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
56.44 (0.03)
37.94 (0.11)
36.12 (0.11)
56.66 (0.04)

:green_circle:
app/client/src/actions/metaActions.ts
84.21 (5.64)
100 (0)
57.14 (32.14)
81.25 (11.25)

:green_circle:
app/client/src/components/designSystems/appsmith/SearchComponent.tsx
79.31 (3.45)
83.33 (8.33)
66.67 (16.67)
78.57 (3.57)

:red_circle:
app/client/src/components/editorComponents/EditorContextProvider.tsx
86.67 (-6.19)
100 (0)
50 (-16.67)
86.67 (-6.19)

:sparkles: :new:
app/client/src/reducers/entityReducers/metaReducer/index.ts
61.9
37.5
54.55
58.97

:red_circle:
app/client/src/resizable/resizenreflow/index.tsx
54.07 (-0.74)
56.6 (-0.95)
40 (0)
52.38 (-0.79)

:green_circle:
app/client/src/sagas/selectors.tsx
79 (1)
58.33 (0)
66.67 (4.17)
75.32 (1.64)

:red_circle:
app/client/src/utils/WorkerUtil.ts
89.76 (0)
70.59 (-1.96)
100 (0)
93.33 (0)

:green_circle:
app/client/src/utils/helpers.tsx
71.73 (2.73)
39.5 (3.5)
60.34 (5.17)
69.57 (2.77)

:red_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.71 (-0.23)
40.83 (-0.84)
36.21 (0)
56.74 (-0.25)

:red_circle:
app/client/src/widgets/BaseWidget.tsx
79.23 (-0.61)
46.94 (-2)
76.47 (0)
79.03 (0)

:green_circle:
app/client/src/widgets/MetaHOC.tsx
85.25 (0.87)
66.67 (12.82)
81.25 (-11.06)
86.79 (3.74)

:sparkles: :new:
app/client/src/widgets/MetaUpdatesMap.ts
55.56
100
33.33
55.56

:green_circle:
app/client/src/widgets/ChartWidget/component/index.tsx
50.9 (0.6)
23.23 (1.01)
54.84 (3.23)
49.35 (0.65)

:red_circle:
app/client/src/widgets/PhoneInputWidget/widget/index.tsx
40.38 (-0.21)
6.52 (0)
43.75 (0)
40.2 (-0.2)

:red_circle:
app/client/src/widgets/TableWidget/component/TableHeader.tsx
50 (0)
48.98 (-4.08)
30 (0)
47.37 (0)

:green_circle:
app/client/src/widgets/TableWidget/component/index.tsx
28.57 (1.3)
27.27 (24.67)
21.05 (5.26)
27.03 (1.35)

:green_circle:
app/client/src/widgets/TableWidget/widget/index.tsx
29.5 (2.88)
9.2 (3.17)
28.85 (1.93)
29.4 (2.89)

:red_circle:
app/client/src/widgets/TabsWidget/component/index.tsx
89.11 (0)
60 (-5)
81.82 (0)
90.7 (0)

:red_circle:
app/client/src/widgets/TabsWidget/widget/index.tsx
64.29 (-14.28)
43.06 (-4.08)
78.95 (0)
64.44 (-13.34)

:red_circle:
app/client/src/workers/evaluation.worker.ts
7.89 (-0.22)
0 (0)
33.33 (0)
8.39 (-0.24)

:green_circle:
app/client/src/workers/evaluationUtils.ts
62.84 (0.6)
60.98 (0.78)
67.19 (0)
61.1 (0.73)

:green_circle:
app/client/src/workers/DataTreeEvaluator/DataTreeEvaluator.ts
76.52 (0.21)
58.36 (0)
74.16 (0)
76.23 (0.08)

:x:
app/client/src/reducers/entityReducers/metaReducer.ts
33.33
0
20
35

/ok-to-test sha=61a9666

/ok-to-test sha=4f5437a

/ok-to-test sha=90c5eef

/ok-to-test sha=6ea9d1d

Changes in this PR were a POC and will be cherry-picked in separate PRs.


Check for skuba executable instead of installed RPM

We don't need the RPM installed, we need the skuba executable
available. It's totally fine to use a different skuba
version (eg. build from git).

Ah. Ok. Missed that. Thanks for the pointers!


Add one more failing test case for structs parsing

Closes #472

[ ] I have updated CHANGELOG.md
[ ] I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
[x] I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
[x] I have run all the tests locally and no test failure was reported
[x] I have run the linter, formatter and spellchecker
[x] I did not do unrelated and/or undiscussed refactorings

CI failing because of some changed addresses

Interestingly enough CI now only fails on Windows and it's not because of timeouts


Expose accessors to RestTemplateBuilder and WebClientBuilder

Registering custom beans that want to interact with Vault require code duplication of the code that configures RestTemplateBuilder and WebClientBuilder. It would make sense to expose both objects in a way that does not require copying code and that returns fresh builder instances to avoid state mutation.

Potentially we could have a type like WebClientFactory so access would be possible via:
WebClientFactory factory  = …; // bean
WebClient webClient = factory.create();
WebClient anotherWebClient = factory.create(builder -> …) // customizer pattern.

Requires Spring Vault 2.3 M1


Automated cherry pick of #3631: fix: 避免匹配到64导致version是6

Cherry pick of #3631 on release/2.11.
#3631: fix: 避免匹配到64导致version是6

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@d8cc67c). Click here to learn what that means.
The diff coverage is 50%.

@@              Coverage Diff               @@
##             release/2.11   #3634   +/-   ##
==============================================
  Coverage                ?   7.13%
==============================================
  Files                   ?     479
  Lines                   ?   77812
  Branches                ?       0
==============================================
  Hits                    ?    5552
  Misses                  ?   71794
  Partials                ?     466

Flag
Coverage Δ

#aFlag
7.13% <50%> (?)

Impacted Files
Coverage Δ

pkg/util/imagetools/imagetools.go
47.5% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cc67c...a91a4f7. Read the comment docs.

/approve
/lgtm


design-doc: convert isolated

Description
This document presents a solution for migrating OptimismMintableERC20, which corresponds to locked liquidity in L1, to the SuperchainERC20 standard to be interop compatible.
To do that, we suggest  using the L2StandardBridge mint/burn rights over the legacy representations to allow easy conversion between the OptimismMintableERC20 and the corresponding SuperchainERC20.

We decided to go with the approach in https://github.com/ethereum-optimism/design-docs/pull/46, so closing this


Developing issue regarding iframe on videohosting service

Checklist

[x] I'm asking a question
[x] I've looked through the README and FAQ for similar questions
[x] I've searched the bugtracker for similar questions including closed ones

Question

I'm trying to write an extractor for a site. This site refers to an external video hosting service with a custom domain pointing to it.
Normally, from what I've seen in the codebase, this would be handled by writing a second extractor with the site name and redirect to this new extractor through '_type': 'url_transparent' like in motorsport extractor.
Given that the iframe site name is arbitrary, what should be the best course of action?

The extractor for the site is the first one from the known extractors (or the list of one specified extractor) whose suitable(url) class method succeeds. Normally this means matching _VALID_URL but you can override that.
One possible tactic could be to use smuggle_url() (utils.py) to pass required auxiliary data including an identifying flag from your original extractor (eg url = url_smuggle(url, { 'ie_key': 'MyRandomlyNamedVideoSite', ...}), unsmuggle the data in the MyRandomlyNamedVideoSiteIE.suitable() class method and use it like this:
class MyRandomlyNamedVideoSiteIE:
    @classmethod
    def suitable(cls, url):
        _, data = unsmuggle_url(url, {})
        return data.get('ie_key') == cls.ie_key()


Update S2 definitions to 0.0.2-beta

Blocked by:

https://github.com/flexiblepower/s2-ws-json/issues/17
https://github.com/flexiblepower/s2-ws-json/issues/18


Adding collision to a package laravel package

I have a simple package that I'm adding tests to for the first time, I enjoy working with collision in laravel so I was hoping I could also add it to a laravel package.
So far I've installed collision:
composer require nunomaduro/collision --dev

I've edited the I also have phpunit 9.0.1, I actually meant to install 8.5.1 so I could run tests from inside phpstorm.
if I run tests from the command line now, I end up with the following:

Once I add collision to phpunit.xml I get the following error:

I've attempted to register collision in the boot and boot methods of the service provider, however neither seem to remove this. Can you let me how a package should be configured to allow collision?
Thanks

It should be fixed.
It's NunoMaduro\Collision\Adapters\Phpunit\Listener instead of
'NunoMaduro\Collision\Adapters\Phpunit\Printer'

You are using a old version of collision.

Got it sorted, sorry forgot to close this.


feat: Chime Identity AppInstanceBot.

Adds support for Messaging App Instance Bot.
Ran example locally with proper lex bot alias ARN.  Commented out that part of example as lex ARN needs to be account, region, and user specific.

Conflicts resolved and merged here: https://github.com/cdklabs/cdk-amazon-chime-resources/pull/427


swift-corelibs-foundation requires libcurl for URLSession

What's in this pull request?

This is a purely documentation change. Non functional change.

@swift-ci Please smoke test OS X platform


No way to pick existing IAM user on amplify configure

Page: /cli/start/install
Feedback:
Does AWS Amplify require its own dedicated IAM user? Instructions force you to create one; what if you already have an IAM user with the necessary permissions? Is it possible to use it with Amplify?

Yeah but using amplify init seems to force you to create a new backend app in amplify.
In my case, I have a existing IAM user AND and existing backend setup.
amplify configure forces me to create a new user, whereas init forces me to create a new backend, both not good.

Yeah but using amplify init seems to force you to create a new backend app in amplify.
In my case, I have a existing IAM user AND and existing backend setup.
amplify configure forces me to create a new user, whereas init forces me to create a new backend, both not good.

tldr; just ignore the console that opens up and continue.
I found another Issue on the same topic... https://github.com/aws-amplify/amplify-cli/issues/4744 in which they clarify that amplify configure seems to have 2 main functionalities, create a user and configure. So as a workaround, you could add your existing user name when prompted for the new one. Then as you know the aws console webpage opens up for you to finish the aws creation of the IAM new user, but you can ignore it completely ( you can just close it ). Next in the cli, press enter to continue. This goes on to the next step thinking you finished the configuration on the webpage. Now you can continue adding your existing keys and secret.
A fix for this would be that the cli asked you in a previous step/prompt if you have a user or you need to create one. It could then continue with the same process that it does now with the slight difference that after typing the user name: if you are creating a new user it opens up the aws console webpage and if your not, then it continues.


Fix wrong documention

get_messages actually blocks for the full time if block is True regardless of whether or not count messages has been fetched.

Wont merge. The documentation accurately reflects the intended interface.
If get_messages isn't working as documented, then there's probably a bug. I can't replicate this issue locally; can you post some code or steps to replicate?

closing the PR -- please open an issue on this instead.


Update to govuk-components 3.0.6

Changes proposed in this pull request
The latest govuk-components

I've fixed the broken tests. The two issues were:

some of the tests for links styled as buttons were too brittle, and broken when extra attributes were added to these links in the upgrade to govuk-components 3.0.6 (for example, adding role="button"). Fixed by switching to the have_link spec matcher.

there was an accidental breaking change in govuk-components 3.0.6 which meant that the govuk_header component now expects classes on the navigation items to be set to an empty array instead of nil. This meant that when they were active, the component code broke when trying to append a class to nil. This has been fixed by manually setting the classes to an empty array wherever the struct is called. However a better fix might be to change the NavigationItem class so that the classes default to an empty array instead of nil. Unfortunately this isn't super easy using Struct.  @peteryates is also looking at an upstream fix which would allow nil to continue to be used instead of requiring an empty array.


concat and minify js & css

Uses hugo asset pipeline to bundle and minify js and css
Requires Hugo 0.43+

BEFORE

AFTER

Nice work, merging!

@appernetic  you might want to do the same thing with mathjax etc that are pulled in from CDN. I don't use/know about mathjax stuff so have left it alone.

How do you configure so it will not brake the site? I tried to use the exampleSite and got this error:  function "resources" not defined

Tried with assetDir = "/" and did not work.

What's the version of hugo? piplines requires a recent hugo build (0.43+) I think

Hugo Static Site Generator v0.46 linux/amd64 BuildDate: 2018-08-01T10:55:24Z

Is there some important settings needed in the config or in each md files front matter?
Also by default there is no assets folder in this theme when it's published, just /fonts and /modal

There is no style_custom.css:
error calling Get: stat /home/bror/Documents/JannesBlog/test/themes/hugo-bootstrap-premium/assets/css/style_custom.css: no such file or directory
So I created an empty file and got it working.
No need to have any extra settings in config or md files. But we have to add an empty style_custom.css in themes/hugo-bootstrap-premium/assets/css

I have just added the missing file, updated theme.toml with the new features.


CriticalBug - Disks disappear from disk drives

Hi there...
Our entire inventory is lost (unless there is a way to restore it.)
[16:54:24] [Server thread/ERROR] [FML/]: A TileEntity type refinedstorage.tile.TileDiskDrive has throw an exception trying to write state. It will not persist. Report this to the mod author java.lang.NullPointerException 	at refinedstorage.apiimpl.storage.NBTStorage.writeToNBT(NBTStorage.java:89) ~[NBTStorage.class:?] 	at refinedstorage.tile.TileDiskDrive.write(TileDiskDrive.java:181) ~[TileDiskDrive.class:?] 	at refinedstorage.tile.TileBase.func_189515_b(TileBase.java:121) ~[TileBase.class:?] 	at net.minecraft.world.chunk.storage.AnvilChunkLoader.func_75820_a(AnvilChunkLoader.java:384) [atj.class:?] 	at net.minecraft.world.chunk.storage.AnvilChunkLoader.func_75816_a(AnvilChunkLoader.java:175) [atj.class:?] 	at net.minecraft.world.gen.ChunkProviderServer.func_73242_b(ChunkProviderServer.java:202) [lr.class:?] 	at net.minecraft.world.gen.ChunkProviderServer.func_186027_a(ChunkProviderServer.java:230) [lr.class:?] 	at net.minecraft.world.WorldServer.func_73044_a(WorldServer.java:1011) [ls.class:?] 	at net.minecraft.server.MinecraftServer.func_71267_a(MinecraftServer.java:355) [MinecraftServer.class:?] 	at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:636) [MinecraftServer.class:?] 	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:471) [MinecraftServer.class:?] 	at java.lang.Thread.run(Unknown Source) [?:1.8.0_91]
For the next 30 minutes, this error occurred every few minutes:
[16:55:56] [Server thread/ERROR] [FML/]: A TileEntity type refinedstorage.tile.TileDiskDrive has throw an exception trying to write state. It will not persist. Report this to the mod author java.lang.NullPointerException
Haven't seen it again. Any ideas? Any way to restore the lost 8 64k disks?

Which Refined Storage version are you using?

This shouldn't be happening. Unless you have backups, there is no way to restore your inventory.
Is it possible that there are items from a removed mod in your RS system?

Hi there, we were using 0.8.12 - and weird thing is, it happened without anything going on with the server - no reboots, no removed mods. However I can tell you that we set up a quarry to a 'global' ender chest and was pumping items from that and a miner into the RS system.
We've decided to start new with a 1.7.10 mudpack until 1.10.2 becomes more stable (issues with IC2 tileentity errors as well and cables becoming disconnected). Thanks for all your contributions and keep up the good work!

Going to close this as I can't reproduce it nor do I know what causes it.


refactor(interpolate): remove redundant $watchGroup param

@marcin-wosinek thnx, this looks like a good move but I think that we can go a step further - left a comment in the code. WDYT?


Flow disagragation returns non-whole numbers

When splitting up number of trips I get non-whole number results.
e.g. A flow of 309 people split into 11 lines 309 / 11 = 28.09091
I think it would make more sense to return 10 x 28 and 1 x 29
0.09 trips does not make sence and if rounded all results will be 28 meaning a trip has been lost (28 * 11 = 308).
Can there be an option to return whole numbers?

I think this is a reasonable request. Should be easy to round and then top-up/down to ensure totals are the same.


change PR to "waiting on author" after "changes requested" review

It would be useful if rustbot changed the status of a PR to S-waiting-on-author after observing a "changes requested" review from the assigned reviewer.
Branched out from https://github.com/rust-lang/triagebot/issues/1339

Seems like this still doesn't work so I opened https://github.com/rust-lang/triagebot/issues/1857


Update author for iOS articles.

#assign: @sinnypan
@dubiety @sinnypan

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


[ANCHOR-103] Add kotlin reference server

PR Checklist
PR Structure

[ ] This PR has reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR avoids mixing refactoring changes with feature changes (split into two PRs
otherwise).
[ ] This PR's title starts with name of package that is most changed in the PR, ex.
paymentservice.stellar, or all or doc if the changes are broad or impact many
packages.

Thoroughness

[ ] This PR adds tests for the most critical parts of the new functionality or fixes.

What
Add Kotlin reference server for SEP-24. Currently mirrors minimal functionality from existing reference server. Interactive workflow to be finished in the separate PR.
Why
It should be more friendly towards developers reading into examples not familiar with Java/Spring
Known limitations
N/A

Reference Server Preview is available here:https://anchor-ref-pr686.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr686.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr686.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr686.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr686.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr686.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr686.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr686.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr686.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr686.previews.kube001.services.stellar-ops.com/

Something went wrong with PR preview build please check

Reference Server Preview is available here:https://anchor-ref-pr686.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr686.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr686.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr686.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr686.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr686.previews.kube001.services.stellar-ops.com/

Reference Server Preview is available here:https://anchor-ref-pr686.previews.kube001.services.stellar-ops.com/SEP Server Preview is available here:https://anchor-sep-pr686.previews.kube001.services.stellar-ops.com/


what is this regex intended to match?

https://github.com/KonduitAI/konduit-serving/blob/485642123c362110cae5e76c42e08b869b329ea5/python/konduit/client.py#L150
it seems this would replace \[1337\]default by default. when is this relevant?

I'm asking specifically about this, as https://github.com/KonduitAI/konduit-serving/issues/17 seems to have input name matching issues and I want to understand the intended behaviour.

@maxpumperla this is intended to be matching partname[0 through 9]. Multi part batches get assembled allowing something like:
partname[0]
partname[1]
This allows you to send things like documents indicating which input should be which row or slice in the batch. A "name" is an "input name" in neural networks. An input name gets mapped to a part name.


fix(n-avatar): component desc

close https://github.com/tusen-ai/naive-ui/issues/4975

https://github.com/tusen-ai/naive-ui/pull/4979


Component type error

I think it is TailwindComponent? but it is any.

I also found out later that this should not be changed to any, otherwise it would be anyscript.

@MathiasGilson Could you help with this issue?

By the way, I believe specifying a type for the component's props should automatically set the same type for conditional props as well.
Right now, I have this example code:
const Button = tw.button<ButtonProps>`
  ${p => p.primary && "bg-red-500"}
`

And then I get this:

When we should expect this behavior by default (without specifying the props directly in parameters too):

Any option to fix it?

Any fix planned on this issue?

Any solution?

same for me

Just published the version 2.2.0 that should address this issue
I've got a warning for excessively deep type instanciation though, and I'm not sure how to fix that
If some of you guys are typescript experts and could have a look at #71 it would be greatly appreciated!


Standardized way to disable foreign key constraints

I am having an issue with disabling foreign key checks differently in my different environments. I am trying to use SQLite for testing and MySQL for development/production. Each has their own way to disable foreign key checks.

MySQL:
DB::statement('SET FOREIGN_KEY_CHECKS = 0');

SQLite:
DB::statement('PRAGMA foreign_keys = OFF');

+1
I totally agree with @ikari7789 this should be implemented on the DB class/façade.

When I tried  DB::disableForeignKeyCheck(), it dosen't seem to work. Has this actually been added???

@anik786 No, it isn't implemented yet, as proven by a simple "Find in all files" search within the repository.
The alternative is to use the code posted by the original poster/reporter depending on your sql server.
In my case, I use MySQL, so I use the following:
DB::statement('SET FOREIGN_KEY_CHECKS = 0');

1+ for @ikari7789  DB::disableForeignKeyCheck() DB::enableForeignKeyCheck()

Currently experiencing this issue with in 5.1 so this is the workaround im using for the time being on till Taylor have time to integrate it inside the framework.
//DatabaseSeeder.php
public function run(){
   $this->disableForeignKeyCheck();
   //....
   $this->enableForeignKeyCheck();
}

private function disableForeignKeyCheck(){
        $connection = config('database.connections')[config('database.default')];
        $sql='';
        switch ($connection['driver']) {
            case 'mysql':
                $sql='SET FOREIGN_KEY_CHECKS = 0';
                break;
            case 'sqlite':
                $sql='PRAGMA foreign_keys = OFF';
                break;
        }

        DB::statement($sql);
    }
    private function enableForeignKeyCheck(){
        $connection = config('database.connections')[config('database.default')];
        $sql='';
        switch ($connection['driver']) {
            case 'mysql':
                $sql='SET FOREIGN_KEY_CHECKS = 1';
                break;
            case 'sqlite':
                $sql='PRAGMA foreign_keys = ON';
                break;
        }

        DB::statement($sql);
    }


Audit logs and events for recovery flows

The product needs to have audit logs for the below recovery scenarios.

Welcome Email (Ask password feature)
Forgot password (Password reset with recovery email feature)
Admin reset password (Admin forced password reset with recovery email feature)

Some of these flows already have audit logs and events triggered. Below are some of the flows I could capture.
Password reset with recovery email has below events triggered at the time when the recovery email is sent.
PRE_SEND_RECOVERY_NOTIFICATION
POST_SEND_RECOVERY_NOTIFICATION

And below audit log is printed
TID: [-1234] [2020-10-13 10:09:00,660] [8c522ea4-3f51-4462-b160-0a4261f832f6]  INFO {AUDIT_LOG} - Initiator<EMAIL_ADDRESS>| Action : Password recovery | Target : user6 | Data : {"UserStoreDomain":"PRIMARY","Notification Channel":"EMAIL"} | Result : Success
When the user recovers the password, the below events are triggered.
PRE_ADD_NEW_PASSWORD
POST_ADD_NEW_PASSWORD

Below audit log is printed
TID: [-1234] [2020-10-13 10:09:51,066] [7e85d4eb-b958-4f5c-b60c-4743e9c986b9]  INFO {AUDIT_LOG} - Initiator<EMAIL_ADDRESS>| Action : Password reset | Target : user6 | Data : {"ServiceProviderName":"User Portal","UserStoreDomain":"PRIMARY"} | Result : Success
However, the ask password feature does not have such comprehensive logs and events. All the above 3 flows need to be verified for events and audit logs and add them.

Duplicate of https://github.com/wso2/product-is/issues/10365


TS Server fatal error:  Debug Failure. False expression.

We have written the needed data into your clipboard because it was too large to send. Please paste.

/needsMoreInfo


Support FilamentAsset child entities

Hello,
we have created a model with multiple child nodes and would like to receive the clicked child node.
So for example we have a model containing two cubes. When the user presses cube_1 we would like to start the animation of cube_1 and same for cube_2.

In Scenekit for iOS this seems to be really easy. You can access a list of the child nodes and with a hit test you also get the clicked child node.
With Sceneform for Android and the glb model I was not able to get this working. You can access the different animations and the different materials. But not the child nodes and which one the user clicked. I found those old issues in the archived sceneform sdk:
https://github.com/google-ar/sceneform-android-sdk/issues/63
https://github.com/google-ar/sceneform-android-sdk/issues/206
Is there any progress on that? And is there a better way to achive that than just adding two models to seperate nodes?
Thanks!

Hi,
Unfortunately there won't be any progress on this part inside sceneform-android
You will have to move to sceneview-android and wait a little for us to add the Filament Pick API which will enable the feature you describe for any child entity inside your model.
Maybe, you could think of sponsoring or contributing in order to speed it up since we hardly find time to spend on specific features those days.
We have to work on remunerative apps instead of here because of missing sponsors.
Sponsor SceneView
Thanks

Hi @MarcoGoe!
This was supported in SceneView in this pull request: https://github.com/SceneView/sceneview-android/pull/96

你好，
我们创建了一个具有多个子节点的模型，并希望接收单击的子节点。
例如，我们有一个包含两个立方体的模型。当用户按下 cube_1 时，我们希望启动 cube_1 的动画，对于 cube_2 也是如此。
在适用于 iOS 的 Scenekit 中，这似乎非常简单。您可以访问子节点的列表，并且通过命中测试，您还可以获得单击的子节点。
使用适用于 Android 的 Sceneform 和 glb 模型，我无法使其正常工作。您可以访问不同的动画和不同的材料。但不是子节点以及用户单击的哪个节点。我在归档的sceneform sdk 中发现了那些旧问题： google-ar/sceneform-android-sdk#63  google-ar/sceneform-android-sdk#206
这方面有什么进展吗？除了将两个模型添加到单独的节点之外，还有更好的方法来实现这一点吗？
谢谢！

你好，
我们创建了一个具有多个子节点的模型，并希望接收单击的子节点。
例如，我们有一个包含两个立方体的模型。当用户按下 cube_1 时，我们希望启动 cube_1 的动画，对于 cube_2 也是如此。
在适用于 iOS 的 Scenekit 中，这似乎非常简单。您可以访问子节点的列表，并且通过命中测试，您还可以获得单击的子节点。
使用适用于 Android 的 Sceneform 和 glb 模型，我无法使其正常工作。您可以访问不同的动画和不同的材料。但不是子节点以及用户单击的哪个节点。我在归档的sceneform sdk 中发现了那些旧问题： google-ar/sceneform-android-sdk#63  google-ar/sceneform-android-sdk#206
这方面有什么进展吗？除了将两个模型添加到单独的节点之外，还有更好的方法来实现这一点吗？
谢谢！

we have created a model with multiple child nodes and would like to receive the clicked child node.How did you finally implement it in java?


Market not showing any offers

The APP doesn't show any offers from any country. Tried logging out and logging in again, uninstalled and reinstalled the app from f-droid store and created a new account. Nothing seems to change. No proxy, VPN or DNS hole activated. The website is working normally, though, so its not a connectivity issue or geographical block

Please update the app to 1.1.1 version, it should solve it.

Ohh, F-Droid will be updated in a few days, meanwhile, you can use the app from the github
https://github.com/AgoraDesk-LocalMonero/agoradesk-app-foss/releases/tag/v1.1.1


Mod Name
SD-VABO_Support
Author(s)
SheepDog2142
License
SDVABO © 2024 by SheepDog2142 is licensed under CC BY-NC-SA 4.0. To view a copy of this license, visit https://creativecommons.org/licenses/by-nc-sa/4.0/
Homepage link
https://forum.kerbalspaceprogram.com/topic/225797-wip-sdvabo-vab-organizer-support-mod/
Download link
https://github.com/Sheepdog2142/SDVABO_Support

Do i need to do anything else to get this added to CKAN?

Hi @Sheepdog2142, thanks for the submission.

Do i need to do anything else to get this added to CKAN?

Yes, you'll need to make at least one release. That's how CKAN tracks what version is installed, and currently there are none:

https://github.com/Sheepdog2142/SDVABO_Support/releases

GitHub has documentation about how to do this, and you can use many existing KSP mods as a model.

Ok updated the name and created the release.


Update travis to only run on supported versions of ruby

I'd like to help get the test suite back into shape. I think the first step is to drop the old versions of ruby that are no longer supported from the travis config, since it's unlikely that anyone is actually using them.
This PR updates the travis config to use the latest releases of ruby 2.4, 2.5 and 2.6, and remove a stray gem install that dates back to the ruby 1.9 era.
This doesn't fix the test suite, but I think it's a good first step.

What do you think also locking the stripe gem to "< 5"? That should pass all the specs on Travis 💚. That could be final 2.5.x release, where as version 3.0 would then add support for stripe >= 5.
At the time upgrading the stripe gem to version >= 5 and using stripe-ruby-mock will 💔 in tests relying on Stripe mock.

we a going to merge #647 and your changes are included. That's why I want to close your PR. Thank you

@alexmamonchik Thanks, that's fine by me. I'm looking forward to seeing #647 merged soon!


SideEffectsFlagPlugin does not resolve the right descriptionFileData in nested packags

I'm not sure it's SideEffectsFlagPlugin, the data is resolved else where where but I found it there.
Consider 1 npm package with internal packages.

@scope/root
@scope/root/root-child

All of the bundles are set inside dedicated directories so:
UMD (main)

@scope/root/bundle/root.js
@scope/root/bundle/root-child-root.js

FESM5 (module)

@scope/root/fesm5/root.js
@scope/root/fesm5/root-child-root.js

The package.json:

@scope/root/package.json
@scope/root/child-root/package.json

Each package.json will point to the proper bundles, which means that child package will use
a relative import, e.g for @scope/root/child-root:
  "main": "../bundles/root-child-root.js",
  "module": "../fesm5/root-child-root.js",

for @scope/root:
  "main": "bundles/root.js",
  "module": "fesm5/root.js",

Importing @scope/root works fine.
Importing @scope/root/child-root works, it will import to proper file but when the package.json
data is needed in SideEffectsFlagPlugin (to determine sideEffect) it will use the data of @scope/root/package.json
What I think happens is that to get the package.json webpack search's for the file on the current dir then goes up until it finds it, in this case its in @scope/root/fesm5/ and goes up to @scope/root  which is not the right file.
The end result is the the sideEffect property set for @scope/root/root-child is ignored and the one of @scope/root is used.

That's working as intended.
It's not relevant from which package.json you are coming from. For a module that next package.json found in parent folders provides the information. The main/module field is only a redirect.

Well, this works as intended but very confusing.
I guess this might be coming from some sort of spec, but what it says is:

Resolving a module is done using package.json
Resolving package.json is done using file-system

The example above is the output of @angular/cli library builder using ng-packgr.
When this happen it not trivial to debug...


Request missing config for POPP Flow Stop 2 (POPE701479)

Which device is missing?
POPP Flow Stop 2 - POPE701479
What are the IDs?
Manufacturer ID: 0x0154
Product type: 0x0005
Product ID: 0x0003
Did you check if we really don't have it?

[x] It is not in the configuration DB
[x] It was not merged recently or has a pending PR
[x] It is not in the TODO list

Do you have a link to the PDF manual?

Manual
Product page
Flyer
Data sheet

A mismatch in label potentially, but this is listed.
https://devices.zwave-js.io/?jumpTo=0x0154:0x0005:0x0003:1.1

Ah, looks like it the manual for Flow Stop says its ID is 0x0154.0x0003.0x0512 and the manual for Flow Stop 2 says its ID is 0x0154.0x0005.0x0003
So there's some mixing going on. :) I'm not sure how the configs are loaded though, but shouldnt my device (0x0154.0x0005.0x0003) match this config, instead of saying
Manufacturer:				| Product 		| Product code
Unknown manufacturer 0x0154		| 0x0005 		| Unknown product 0x0003

I'm using the latest build of zwjs2mqtt (2.4.0) and zwave-js 6.6.3.

I'm not overly experienced, but what firmware version is your device?
I'm unsure if this is the reason, but the config states 1.1 - 1.2

Hmmm, the version tab says:
Library type	| Z-Wave protocol version 	| Z-Wave chip firmware versions | Z-Wave chip hardware version
6 		| 4.5 				| ["1.6"] 			| undefined

Did a re-interview:
2021-03-18 19:40:45.041 INFO ZWAVE: Success zwave api call refreshInfo { success: true, message: 'Success zwave api call', result: undefined }
19:40:45.051 CNTRLR « [Node 039] received response for protocol info:
basic device class: Routing Slave
generic device class: Binary Switch
specific device class: Valve
is a listening device: true
is frequent listening: false
is a routing device: true
is a secure device: unknown
is a beaming device: true
maximum baud rate: 40000 kbps
version: 4
19:40:45.053 CNTRLR [Node 039] Interview stage completed: ProtocolInfo
19:40:45.054 CNTRLR » [Node 039] pinging the node...
2021-03-18 19:40:45.100 INFO ZWAVE: Node 39 is alive
19:40:45.100 CNTRLR [Node 039] The node is alive.
19:40:45.102 CNTRLR « [Node 039] ping successful
19:40:45.103 CNTRLR » [Node 039] querying node info...
19:40:45.161 CNTRLR « [Node 039] node info received
supported CCs:
· Z-Wave Plus Info
· Version
· Manufacturer Specific
· Device Reset Locally
· Powerlevel
· Association
· Association Group Information
· Binary Switch
· All Switch
· Basic
controlled CCs:
19:40:45.164 CNTRLR [Node 039] Interview stage completed: NodeInfo
19:40:45.170 CNTRLR [Node 039] ManufacturerSpecificCC: doing a complete interview...
19:40:45.170 CNTRLR » [Node 039] querying manufacturer information...
2021-03-18 19:40:45.255 INFO ZWAVE: Node 39: value added: 114-0-manufacturerId => 340
2021-03-18 19:40:45.257 INFO ZWAVE: Node 39: value added: 114-0-productType => 5
2021-03-18 19:40:45.258 INFO ZWAVE: Node 39: value added: 114-0-productId => 3
19:40:45.264 CNTRLR « [Node 039] received response for manufacturer information:
manufacturer: Popp & Co (0x0154)
product type: 0x05
product id: 0x03
19:40:45.266 CNTRLR [Node 039] VersionCC: doing a complete interview...
19:40:45.267 CNTRLR » [Node 039] querying node versions...
2021-03-18 19:40:45.315 INFO ZWAVE: Node 39: value added: 134-0-libraryType => 6
2021-03-18 19:40:45.317 INFO ZWAVE: Node 39: value added: 134-0-protocolVersion => 4.5
2021-03-18 19:40:45.318 INFO ZWAVE: Node 39: value added: 134-0-firmwareVersions => 1.6
19:40:45.326 CNTRLR « [Node 039] received response for node versions:
library type: Routing Slave (0x06)
protocol version: 4.5
firmware versions: 1.6
19:40:45.328 CNTRLR » [Node 039] querying CC versions...
19:40:45.329 CNTRLR » [Node 039] querying the CC version for Binary Switch...
19:40:45.379 CNTRLR [Node 039] supports CC Binary Switch (0x25) in version 1
19:40:45.380 CNTRLR » [Node 039] querying the CC version for Association...
19:40:45.478 CNTRLR [Node 039] supports CC Association (0x85) in version 2
19:40:45.479 CNTRLR » [Node 039] querying the CC version for Association Group Information...
19:40:45.527 CNTRLR [Node 039] supports CC Association Group Information (0x59) in version 1
19:40:45.529 CNTRLR » [Node 039] querying the CC version for Battery...
19:40:45.576 CNTRLR [Node 039] does NOT support CC Battery (0x80)
19:40:45.577 CNTRLR [Node 039] skipping query for Device Reset Locally (0x5a) because max implem
ented version is 1
19:40:45.578 CNTRLR » [Node 039] querying the CC version for Manufacturer Specific...
19:40:45.632 CNTRLR [Node 039] supports CC Manufacturer Specific (0x72) in version 2
19:40:45.633 CNTRLR [Node 039] skipping query for Powerlevel (0x73) because max implemented vers
ion is 0
19:40:45.633 CNTRLR [Node 039] skipping query for Security 2 (0x9f) because max implemented vers
ion is 0
19:40:45.634 CNTRLR [Node 039] skipping query for Supervision (0x6c) because max implemented ver
sion is 1
19:40:45.634 CNTRLR [Node 039] skipping query for Transport Service (0x55) because max implement
ed version is 0
19:40:45.634 CNTRLR » [Node 039] querying the CC version for Version...
19:40:45.687 CNTRLR [Node 039] supports CC Version (0x86) in version 2
19:40:45.689 CNTRLR » [Node 039] querying the CC version for Z-Wave Plus Info...
19:40:45.741 CNTRLR [Node 039] supports CC Z-Wave Plus Info (0x5e) in version 2
19:40:45.742 CNTRLR [Node 039] skipping query for All Switch (0x27) because max implemented vers
ion is 0
19:40:45.744 CNTRLR [Node 039] trying to load device config
19:40:45.761 CNTRLR [Node 039] no device config loaded
19:40:45.820 CNTRLR [Node 039] ZWavePlusCC: doing a complete interview...
19:40:45.821 CNTRLR » [Node 039] querying Z-Wave+ information...
19:40:45.873 CNTRLR « [Node 039] received response for Z-Wave+ information:
Z-Wave+ version: 1
role type: AlwaysOnSlave
node type: Node
installer icon: 0x1500
user icon: 0x1500
19:40:45.875 CNTRLR [Node 039] BinarySwitchCC: doing a complete interview...
19:40:45.876 CNTRLR » [Node 039] querying Binary Switch state...
2021-03-18 19:40:45.923 INFO ZWAVE: Node 39: value added: 37-0-currentValue => false
2021-03-18 19:40:45.925 INFO ZWAVE: Node 39: value added: 37-0-targetValue => undefined
19:40:45.929 CNTRLR « [Node 039] received Binary Switch state:
current value: false
19:40:45.931 CNTRLR [Node 039] AssociationCC: doing a complete interview...
19:40:45.931 CNTRLR » [Node 039] querying number of association groups...
19:40:46.021 CNTRLR « [Node 039] supports 1 association groups
19:40:46.023 CNTRLR » [Node 039] querying association group #1...
19:40:46.075 CNTRLR « [Node 039] received information for association group #1:
maximum # of nodes: 5
currently assigned nodes: 1
19:40:46.077 CNTRLR [Node 039] AssociationGroupInfoCC: doing a complete interview...
19:40:46.077 CNTRLR » [Node 039] Association group #1: Querying name...
19:40:46.129 CNTRLR « [Node 039] Association group #1 has name "Lifeline"
19:40:46.130 CNTRLR » [Node 039] Association group #1: Querying info...
19:40:46.181 CNTRLR « [Node 039] Received info for association group #1:
info is dynamic: false
profile: General: Lifeline
19:40:46.182 CNTRLR » [Node 039] Association group #1: Querying command list...
19:40:46.269 CNTRLR [Node 039] Interview stage completed: CommandClasses
19:40:46.270 CNTRLR [Node 039] Interview stage completed: OverwriteConfig
19:40:46.271 CNTRLR » [Node 039] requesting node neighbors...
19:40:46.287 CNTRLR « [Node 039] node neighbors received: 1, 2, 3, 4, 6, 7, 10, 11, 12, 13, 14, 15
, 16, 17, 18, 19, 20, 21, 22, 23, 24, 27, 29, 30, 31, 32, 36, 37, 41, 42
19:40:46.288 CNTRLR [Node 039] Interview stage completed: Neighbors
19:40:46.288 CNTRLR [Node 039] Interview completed
2021-03-18 19:40:46.298 INFO ZWAVE: Node 39: value added 39-37-0-currentValue => false
2021-03-18 19:40:46.299 INFO ZWAVE: Node 39: value added 39-37-0-targetValue => undefined
2021-03-18 19:40:46.300 INFO ZWAVE: Node 39: value added 39-114-0-manufacturerId => 340
2021-03-18 19:40:46.300 INFO ZWAVE: Node 39: value added 39-114-0-productType => 5
2021-03-18 19:40:46.301 INFO ZWAVE: Node 39: value added 39-114-0-productId => 3
2021-03-18 19:40:46.301 INFO ZWAVE: Node 39: value added 39-134-0-libraryType => 6
2021-03-18 19:40:46.302 INFO ZWAVE: Node 39: value added 39-134-0-protocolVersion => 4.5
2021-03-18 19:40:46.302 INFO ZWAVE: Node 39: value added 39-134-0-firmwareVersions => 1.6
2021-03-18 19:40:46.303 INFO ZWAVE: Node 39: value added 39-134-0-hardwareVersion => undefined
2021-03-18 19:40:46.304 INFO ZWAVE: Node 39 ready: Unknown manufacturer 0x0154 - Unknown product 0x0003 (0x0005)
19:40:46.304 CNTRLR [Node 039] The node is ready to be used
2021-03-18 19:40:46.311 INFO ZWAVE: Node 39: interview completed, all values are updated

Ok,
The only thing that is looking at me is the firmware version support on the config (given you have V2), it makes sense.
I could be wrong of course, so it might be best for someone with more knowledge to back up my thought (or shoot it down  😄)
@blhoward2 ?

This won't match if it exceeds the fw version in the file. Usually we don't supply a max like that, though. Can you try to dig out a change log or manual showing the parameters yours supports versus what we have?
Brian

Hi,
Just to clearigy: fw version = ["1.6"] ?
Could you give me some guidance on what you're asking for and how I can find it? (ref: «change log or manual showing»).
The only differences that I can see in the manual, is that this (newer one = v2) one do not support assoc groups except from lifeline, while the other one does. However, the config does not mention any association groups.

Is there any difference in parameters/metadata between your device version, and the one we have listed?
https://devices.zwave-js.io/?jumpTo=0x0154:0x0005:0x0003:1.1

From what I can see in the manual; there's no configuration. The only difference is that the 1st version support assoc.group Valve (up to 10 nodes)  while the 2nd version do not support it. (Strange that the newer version don't?)
But other than this it seems to be the same device. But I guess that users with the 1st version can't use the provided config, as it the ID of the device dont match the one in the config.

We can fix the id and version so both are included. We just need to verify that both should be covered by the file.

From what I can see in the manual; there's no configuration. The only difference is that the 1st version support assoc.group Valve (up to 10 nodes) while the 2nd version do not support it. (Strange that the newer version don't?)
But other than this it seems to be the same device. But I guess that users with the 1st version can't use the provided config, as it the ID of the device dont match the one in the config.

I can only quote myself, as the only difference I can see in the manual is the assoc.groups. One have Valve the other don't. And the config do not have any configuration params either.

@blhoward2
it does look as if V2 has no config params.
More than happy to PR the changes with a condition for the parameters (if its not on your list)

Go for it


ci: Notify slack of codegen failures

Fixes #N/A
Description
This PR adds handling to send slack messages over to the notification channel when the codegen for Karpenter fails
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.495%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4920

Relevant Lines:
5964

💛  - Coveralls


[PartEditor] Revise backend combobox change

This will revise backend selection combobox change not to update backend.
ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

for #822 from draft #851


Default RequestAdapter BaseUrl to client BaseAddress

Fixes Blazor WASM client unable to send web requests through HttpClient BaseAddress microsoft/kiota-http-dotnet#109
This change allows clients to propagate the BaseUrl through the RequestAdapter's supplied HttpClient instead of needing to set that property explicitly.

@microsoft-github-policy-service agree


Design map options block

We haven't found any design about the image below in the builder.

@nobuti has implemented it but we need some better looking :).

Its on the white lateral panel when clicking the settings icon in the blue
bar. I'll attach the mock-up in a while.
On Jul 2, 2016 4:38 PM, "Javier Álvarez Medina"<EMAIL_ADDRESS>wrote:

We haven't found any design about the image below in the builder.
https://cloud.githubusercontent.com/assets/132146/16431972/4d37150e-3d83-11e6-9cfc-133191486d09.png
@nobuti https://github.com/nobuti has implemented it but we need some
better looking :).
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/CartoDB/cartodb/issues/8415, or mute the thread
https://github.com/notifications/unsubscribe/AAIENWiiEANJplIW170mWBFEOrhqqZ8aks5qRnfOgaJpZM4JDr8R
.

But let's remove the 1st step for the time being :)

Widgets column option is not ready, we can't add it right now, @nobuti, create a ticket for that please.
Also, i guess there is a map title above this panel right?

Closing, it is being implemented.


Orientation information in the renderer

Once the orientation labelling (#243) is done, we need to display this information in the renderered diagram.
Here are some ideas:

different colours (how will this interact with the different shades for points, wires, regions)
asymmetric boxes for the points (related to #519)
arrows on the wires (#553)
dashed/dotted wires?
flip normals in GL

Hi -- can this please be prioritised, now we are using the alpha tool a lot it would be really great to get this rendering information in properly.

There is a problem with this idea unfortunately. Basically we cannot change the saturation, since a HSL value with positive saturation, and non-extremal lightness, will always have some "colour" to it, i.e. it will not be on the black-white spectrum. This means that, if we varied S/L as we were planning, a white or black generator would sometimes be shown with a nontrivial hue.
I think the best alternative is to just use 9 different lightness values. For example:
L=15%, vertex, orientation -1
L=23%, vertex, orientation 0
L=31%, vertex, orientation +1
L=39%, wire, orientation -1
L=47%, wire, orientation 0
L=55%, wire, orientation +1
L=63%, surface, orientation -1
L=71%, surface, orientation 0
L=79%, surface, orientation +1

We may want to cycle these choices if the initially-chosen colour was particularly light or dark.

Is it really worth differentiating surfaces? For points and wires it makes sense because you can contract those, but for surfaces it seems superfluous. That would at least reduce the number of lightness values.

Yes I think it's important because you can have homotopies-on-homotopies-on-homotopies of the same generator. So you can have an entire diagram of points, wires and surfaces all with the same generator label (and potentially all with the same orientation).

Alright I've set the lightness according to this in #717.

L=15%, vertex, orientation -1
L=23%, vertex, orientation 0
L=31%, vertex, orientation +1
L=39%, wire, orientation -1
L=47%, wire, orientation 0
L=55%, wire, orientation +1
L=63%, surface, orientation -1
L=71%, surface, orientation 0
L=79%, surface, orientation +1

I think this is going to require a little more tweaking given that some of the
colours seem far too dark etc.
I'm going to play around with the colours and see if I can get something which
is clear but sufficiently different between codimensions/orientations.

This is what's implemented now in #717. Note that instead of setting the lightness of a colour, I lighten or darken it by a factor.

Co.
Or.
lightening fac.

point
inv.
0.15

wire
inv.
0.20

surface
inv.
0.25

point
zero
-0.05

wire
zero
-0.1

surface
zero
-0.15

point
fwd.
0.00

wire
fwd.
0.05

surface
fwd.
0.10

Thanks for this Jasper. I think this is much too subtle unfortunately, can you jump into Zoom for a quick discussion.

Jasper thanks for your pull request with the configurable lightnesses. I played around and a good spread of lightnesses (I used -0.36 -0.24 -0.16 -0.05 0.02 0.1 0.17 0.27 0.39) works very well regarding legibility. But we need the property we discussed before: the generator needs to be drawn in its defined colour when appearing in its "natural state", so take that as a starting point and cycle the lightnesses around the interval by adding (1/9) to achieve the 9 states. Can you do this as a priority on Monday morning please and push to alpha. Any queries please ask.

Right now (on #717), colours are computed as follows:

lightening factor (fixed with wrapping)

positive
point
0.00

positive
wire
0.08

positive
surface
0.16

zero
point
0.24

zero
wire
0.32

zero
surface
0.40

negative
point
0.48

negative
wire
0.56

negative
surface
0.64

I know this doesn't follow the 1/9 but I personally think it achieves
good clarity.
Right now, I darken light colours instead of lightening them which avoids
wrapping in most cases (when colours wrap, they look jarringly different). I
guess the problem is that we need to make sure that colours are sufficiently
differentiable while also being recognisably the same generator.
We currently ignore the future requirement of making generators look the same
colour when viewing slices of a larger diagram.

Thanks for that update Jasper. The requirement of making generators appear their defined colour in their standard diagram is essential, of course it's ok to do it in a future PR, but I don't see how it's compatible with this plan.
Another question, what is your proposal for handling intermediate lightness colours with lightness 0.5.

Thanks. Ok, clearly I misunderstood what was meant by natural diagram (are generators not always positive points in their natural diagram).
At the moment, colours with medium lightness are roughly treated as dark colours. There is a threshold between light and dark which is rather arbitrary (used by UI code to ensure legibility). Potentially, we could avoid wrapping any colours altogether if we make these medium lightness colours choose lightnesses either side of centre (eg. zero -> darken, positive -> darken/lighten, negative -> lighten).

So let's work out once and for all this formula for when a generator is appearing in its "natural state". An N cell appearing as a vertex in an N-diagram is in its natural state (regardless of whether we are looking at a 2d, 3d or 4d projection), as is an N-cell appearing as a wire in an (N+1)-diagram, or as a surface in an (N+2)-diagram.
So in general suppose we have an N-dimensional generator appearing in a D-dimensional diagram, where it occurs as an K-dimensional entity (K=0 for point, K=1 for wire, K=2 for surface.) Then define its codimension C = D - N - K.
Then we must colour the entity in one of 9 possible ways, depending on the 9 values of the pair (C mod 3, R) where R is the orientation number, either -1, 0 or +1.
We need the property that the pair (0, +1) is given exactly the natural colour of the generator, as that is the "standard" way the generator will be viewed.

I remember when I was working on hiding homotopies that it was possible for N to be larger than D, so I had to clamp D - N to make sure it doesn't underflow. I admit I now can't understand how that could happen, but that's something to keep in mind.

It's easy to conceive of a 2-diagram of 4-cells (for example) so N is often greater than D

Yes the situation this can happen is if you navigate to a singular slice.

So my new suggested formula is C = S + D - N - K, where S is the total "singularness" of the slice you are viewing.

Yes I forgot this works on the "visible diagram" rather than the whole diagram.

So my new suggested formula is C = S + D - N - K, where S is the total "singularness" of the slice you are viewing.

Hmm I think it's enough to clamp D - N - K, but I'm also not entirely sure.

OK so for now let's define C = max(0, D - N - K) and we can iterate in future if necessary.

The recently discussed algorithm for determining colours is now implemented and merged into alpha. I'll implement this change for gl and tikz etc soon.

Thanks that is very good.
On Tue, Aug 30, 2022 at 5:44 PM Jasper Parish @.***>
wrote:

The recently discussed algorithm for determining colours is now
implemented and merged into alpha. I'll implement this change for gl and
tikz etc soon.
—
Reply to this email directly, view it on GitHub
https://github.com/homotopy-io/homotopy-rs/issues/550#issuecomment-1231913731,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQ4OHVOD7AU5RZZZVBDQM3V3Y3AHANCNFSM5ZXXSWSA
.
You are receiving this because you commented.Message ID:
@.***>

Getting the colours right in 3D and 4D will require some changes to the buffering system, as, at the moment, objects of the same codimension are group by generator into draw calls and each draw call gets a single choice of colour. We'll have to key the buckets based on a (generator + orientation) composite key.

Thank you that is interesting.

I think we can close this, we now have colours in both 2D and 3D.
I would still like to have arrows + asymmetric boxes as an alternative to colours, but that can be tracked elsewhere.