Roll Flutter Engine from de6b2552faf2 to<PHONE_NUMBER>24 (1 revision)

https://github.com/flutter/engine/compare/de6b2552faf2...470652849224
2023-05-29<EMAIL_ADDRESS>Roll Skia from 3b86de3c85d0 to 19af8f052d64 (1 revision) (flutter/engine#42393)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


ignite-cli: init at 28.1.0

Description of changes
https://github.com/ignite/cli
https://github.com/ignite/cli/releases/tag/v28.1.0
Ignite CLI is the all-in-one platform to build, launch, and maintain any crypto application on a sovereign and secured blockchain

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 276666 run on x86_64-linux 1

1 package built:

ignite-cli


Allow customization of the toot length

I am using Shaarli and Shaarli2mastodon with my Pleroma instance, where the default toot/status length is much higher than 500 characters.
Would it be possible to add an editable parameter to change the toot length?

This is now available in the last beta version : https://github.com/kalvn/shaarli2mastodon/releases/tag/v3.0.0-beta1
Would you like to give a try let me know if it works as expected?

This is now available in the last beta version : https://github.com/kalvn/shaarli2mastodon/releases/tag/v3.0.0-beta1
Would you like to give a try let me know if it works as expected?

Yes, it works perfectly!
https://kayii.goe.land/notice/A3lpVNFk4uTvuc2dM0

Yes, it works perfectly!
https://kayii.goe.land/notice/A3lpVNFk4uTvuc2dM0

v3 is out :)


feat(docs): add link to LazyVim For Ambitious Developers to README

As requested, here's a link to my book from the README. I'll add the video and this link to the main page of lazyvim.org as well.

You should reword the commit to something like doc(readme): Add link to LazyVim For Ambitious Developers to README for the CI to pass :)

Thanks!

I don't think I've ever had a PR merge that fast, even when I was the one merging it. 🤯

I don't think I've ever had a PR merge that fast, even when I was the one merging it. 🤯

another reason to use lazyvim

PR's without code are pretty easy to review ;)


How to add more anchor's scale?

In order to increase the anchor's scale, I changed the model.rpn_head.anchor_strides = [4, 8, 16, 32, 64] to model.rpn_head.anchor_strides = [4, 6, 8, 16, 20, 32, 48, 64] in config file mask_rcnn_r50_fpn_1x.py, but I met some errors:

Traceback (most recent call last):
File "./tools/train.py", line 82, in
main()
File "./tools/train.py", line 77, in main
logger=logger)
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/mmdet/apis/train.py", line 57, in train_detector
_dist_train(model, dataset, cfg, validate=validate)
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/mmdet/apis/train.py", line 92, in _dist_train
runner.run(data_loaders, cfg.workflow, cfg.total_epochs)
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/mmcv/runner/runner.py", line 349, in run
epoch_runner(data_loaders[i], **kwargs)
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/mmcv/runner/runner.py", line 255, in train
self.model, data_batch, train_mode=True, **kwargs)
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/mmdet/apis/train.py", line 37, in batch_processor
losses = model(**data)
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/torch/nn/modules/module.py", line 477, in call
result = self.forward(*input, **kwargs)
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/mmcv/parallel/distributed.py", line 47, in forward
return self.module(*inputs[0], **kwargs[0])
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/torch/nn/modules/module.py", line 477, in call
result = self.forward(*input, **kwargs)
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/mmdet/models/detectors/base.py", line 79, in forward
return self.forward_train(img, img_meta, **kwargs)
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/mmdet/models/detectors/two_stage.py", line 92, in forward_train
rpn_losses = self.rpn_head.loss(*rpn_loss_inputs)
File "/home/jwwangchn/anaconda2/envs/python3.6/lib/python3.6/site-packages/mmdet/models/rpn_heads/rpn_head.py", line 153, in loss
assert len(featmap_sizes) == len(self.anchor_generators)
AssertionError

What should I do to solve this problem? Thanks.

Current rpn_head force only one anchor scale(stride) on each fpn feature maps. See details in init() and forward() function.
You can rewrite a rpn_head file to support more flexible ways.

Anchor settings are specified with anchor_scales and anchor_ratios, while anchor_strides corresponds to the feature map strides. If you want to use more scales, you can specify anchor_scales=[4, 8, 16] and anchor_ratios=[0.5, 1.0, 2.0], so that 9 anchors will be generated in each location.

@hellock If I want to halve the anchor scales for mask-rcnn (reset50-fpn), i.e. change [32, 64, 128, 256, 512] to [16, 32, 64, 128, 256], How should I change the configs?

@wangg12 You just need to modify anchor_scales=[8] to anchor_scales=[4].

@hellock I wonder How the scales are calculated based on these configs?

@hellock I wonder How the scales are calculated based on these configs?

metoo

Anchor scale is calculated as anchor_scales * anchor_base_sizes, if anchor_base_sizes is not set, anchor_strides is used by default.
If anchor_scales=[8] and anchor_strides=[4, 8, 16, 32, 64], then anchor scales for each fpn level are calculated as [8*4, 8*8, 8*16, 8*32, 8*64].

The anchor settings is not flexible, i have to change it by myself.....

Anchor scale is calculated as anchor_scales * anchor_base_sizes, if anchor_base_sizes is not set, anchor_strides is used by default.
If anchor_scales=[8] and anchor_strides=[4, 8, 16, 32, 64], then anchor scales for each fpn level are calculated as [84, 88, 816, 832, 8*64].

@hellock it is clear, But I have a question. If the areas of the objects in my dataset range from 40^2 to 150^2,which means these objects are medium and large, should set the anchor_strides=[4,6, 8,10,12,14 16,] to get better detection rseult? Because anchor_scales=[8], and anchor_scales * anchor_base_sizes ? Will the network convergence faster use these scheme in theory?

@hellock , how do you set or change the anchor_base_sizes?


Pie chart Label Type

When use Pie chart, I can use Catetory Name, Value or Percentage.
Can I use the Category Name and Percentage at the same time?

Notice: this issue has been closed because it has been inactive for 278 days. Feel free to comment and request for this issue to be reopened.


Adds Emerald Ore to the alert

Can you submit this without a merge commit, please.

@viveleroi There you go.


Split iapp_template into two plugins

@zancas
What's this change do?
The f5_sys_iapptemplate plugin needs to be split into two plugins: one for a full template upload, and the other for a composite template.
There's a great deal of changes in the yaml templates. Mostly copy paste and changing file names. The other fixups are to migrate from one plugin to two.
Any background context?
This is to be done for usability and readability, as they are two different starting points that reach the same end (creating an iapp template on the bigip). When these two plugins were squashed into one plugin, there was extra logic to facilitate both types of input. This was becoming cumbersome and difficult to read.
@swormke: Wondering about how docs should be handled for this new plugin?
Where should the reviewer start?
Start at the unit tests

Bumping this to @zancas now that shawn has fixed the slack integration


Would you like to support disconnect feature?

Hello,
obviously I am a fan of this package, if you can add a disconnect function, that'll be great!
thanks!

Hi @vancelin
Thank you so much for your support ✨
Regarding a disconnect function, MetaMask doesn't support dApps disconnecting a wallet. Users need to do this from MetaMask itself.
How I usually handle disconnect is,
I have a disconnect button somewhere (dropdown, v-else with Connect button, Profile page, etc.) which when clicked will just remove the address and other information stored in variables or global state. Then the ConnectWalletButton will be back to its original state showing "Connect Wallet".
However, in terms of the button UI of this package perhaps adding a disconnect red button state could be helpful? That can be as close as it gets to supporting it.

Hey,
of course yes, if you can add a disconnect red button, that will be useful!


Is there any way return deis model

With all new changes, draft.io is not usable, it ads so many complexities comparing to deis, and also run's slow locally :(

Curious about this; it runs lightning fast for me, but of course running in the cloud is great, too. I'm taking it to be that you just want it to build in the cloud because that's easier/faster?

just to avoid extra moving parts and make it faster. If you're using compiled language e.g. scala, java, c# you probably equipped with the powerful machine, but if you're a web developer you're fine with something not really powerful. it's nice to build it elsewhere.

completely understood. We definitely want that model to work for you as well, but haven't gotten there. The move local makes minikube extremely fast; but if you have some time, could you try using the ACR builder to do your work in the cloud, while your coding happens locally? Here's the link to take a shot at it. https://github.com/Azure/draft/blob/master/docs/acr-build.md
It's our intention to enable you to choose the model that suits you. We haven't gotten there yet, of course.

Project feedback is always welcome :)
In the interest of closing tickets, are there any particular action items which we can address here, or just giving general feedback on the project? If it's feedback, then perhaps would it be better to move the conversation over to Slack/email so we can keep the issue queue focused on bugs/features. How does that sound to you?


Update gizaartifactory URL to LF provided Artifactory zowe.jfrog.io

Current artifactory https://gizaartifactory.jfrog.io/ will expire at Feb 2020. CI/CD squad is working on migrating to use https://zowe.jfrog.io/ instead.
This task is to replacing all the URLs from old Artifactory to the new one.
Describe the solution you'd like

Replace URLs starting with https://gizaartifactory.jfrog.io/gizaartifactory to https://zowe.jfrog.io/zowe.
Related doc pages

Example: https://docs.zowe.org/stable/extend/extend-apiml/api-mediation-onboard-a-spring-boot-rest-api-service.html#add-zowe-api-enablers-to-your-service
And there are more links to replace.
Additional context

This should be done after the CI/CD artifactory migration is done.

Part of https://github.com/zowe/zowe-install-packaging/issues/702 work.


Dynamic instanceType fetching.  Addresses #2149.

Addresses #2149 and #2135.
Still adding to this, but this should allow us to fetch EC2 instance price/specs/types programatically now.
To Do:

Check user input for poorly specified instance types
~Create better static list and region specific diff lists~
Unittests

Why is cost in the list? Is it used anywhere? Getting the instance types should be fast. What is this huge file to download?

Cost is there to sort by cost in the clusterScaler, which hasn't been refactored yet. We use resource requirements as a proxy right now but it should be cost.
The API fetches a 220Mb+ json. I agree the API should be better but I don't see any way around it. That's why I made it an option to fetch the latest info rather than pulling it. There are comments in the code explaining it.

I don't see cost in #2114. What refactor?

#2114 doesn't sort by price because it needs this PR's ability to fetch price.  This PR doesn't use cost because changing the clusterScaler would interfere with #2114.
I felt this was separate enough to warrant its own PR.  Otherwise, this would have been a part of #2114.
I'd already eliminated all of the unnecessary fields from cgcloud that we never used to begin with.  I'd like to argue for having cost in there because now that we can access it easily, it seems like the most important field for running workflows cheaply.  #2114 does a priority sort by resources (the instance with the lowest memory that can run the job is the one that's used), but this is kind of a proxy, because we assume low memory == low cost.  That's not always true though.  With this new field, that would be relatively straight forward to change.

I'd like to argue for keeping cost in and adding the sort by cost after these are both merged.  I think it's worth doing.

Can you please put the cost in a different PR. I need this PR without the cost.

Alright, no problem.


[BEAM-8523] JobAPI: Give access to timestamped state change history

When connecting to GetStateStream, the job service will first stream the history of missed state events, thereby catching up the client.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Note that this PR depends on https://github.com/apache/beam/pull/9965 which depends on https://github.com/apache/beam/pull/9969

This is ready for another look.

Run Python PreCommit

I reworked this a bit to make it easier for other job services to implement state history, and I added some tests for the local job service.

Forward fixed in https://github.com/apache/beam/pull/10280


Pricing information

This would mean better scraper functionality, but it would be great to display current pricing information so the user can see the cheapest parking spot at the current time.

 Some are based on current time, others just on the amount of time spent there. This is probably not going to find it's way into the app anytime soon or ever.


Make stack yml interpolation default ENVs extendable for plugin devs

Fixes #2644
I think this is what you were after? You should now be able to overwrite the default_envs method and get more "factory envs" into the interpolation even during variable parsing.
ping @matti

This makes it a bit easier, but I think I was looking for a way to not overwrite anything - not sure what that would be.
Anyway this is a good change just for the code quality reasons.

You can already use from: env: ASDF to access arbitrary envs via opto, and declaring those as opto variables also means that they're persisted on the server for use in stack upgrades.

When you have 20 stacks and every single one has the 5 envs in them, you end up with massive repetition in stack ymls.

You may want to take a peek at https://github.com/jannishuebl/orchparty and especially https://github.com/jannishuebl/orchparty/issues/10
Looks quite promising and a lot like the stack DSL I have been prototyping a bit.


Fix milliseconds() to report the correct unit

The milliseconds() function was uploading the value as microseconds. Correct the unit so the values are reported correctly to CloudWatch Metrics

Thanks @troylar.
Would you be able to publish an updated version of cloudwatch-fluent-metrics with the fix to pypi when it's convenient?


Automatic plot check for new plots - display good/bad status of plots on Farming page.

With increasing farm size, a background process to periodically run a chia plots check on all plots (particularly new ones) would be useful.  Farming page would display the status of each plot, sortable so one could find any plots flagged as problematic.

Awesome!! Can't wait for this :)

I like that this is built into the UI but can it include the option to toggle on/off or disable, or include the ability to specify how often it runs? I'd really only want to run this on new plots or choose to manually run it at a later time as it is currently impactful to how I have things set up across multiple forks, fileshares, and servers.

Yes, v0.6.7 will allow you to set plots_check_analyze_skip environment variable if you wish to disable automatic checks.


If a iproj.json is loaded and it is th only one with a project root, make it the project root.

The problem is that the default Merlin tile will load you into the /projects directory.  If you clone a github project you will be prompted to make that directory the root, but upon reload you will be not be prompted and /projects is once more the workspace root.
In this more, the Code for i extension and project explorer will not recognize the project in the subdirectory

@SanjulaGanepola This would be a nice enhancement to get in.


[Event Request] Codeunit 90 Purch.-Post - OnBeforeSetPostingFlags

Hi, in the Codeunit 90 Purch.-Post, trigger SetPostingFlags, would it be possible to get an event OnBeforeSetPostingFlags, like this :

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Incorrect dependancy range for @dessert-box/core

Hit this error after updating @desert-box/react
WARNING in ./node_modules/.pnpm/@dessert-box+react@0.3.0_react<EMAIL_ADDRESS>25:17-34
export 'composeClassNames' (imported as 'composeClassNames') was not found in '@dessert-box/core' (possible exports: extractAtomsFromProps, getClassName)

I think you just need to bump the despondency on core to ^0.2.0 here

For reference, I also had a similar error with version 0.3.0:
TypeError: core.composeClassNames is not a function

Installing<EMAIL_ADDRESS>instead made it go away 👍

@ehyland @jgrancher Just published version 0.4.0 with a fix for this, sorry about it! Will add some extra tests to make sure issue like this don't go trough next time!

Closing as this was fixed.


Update template spec for tuple -> AliasSeq renaming

This is to be applied in tandem with https://github.com/D-Programming-Language/phobos/pull/3756

I already bumped into this issue - please update the docs :)

I want someone else to eyeball it before I hit merge tho... and I walso want the old "Tuple" link to work, and a note of some sort saying like "Template sequence parameters were previously known as tuple parameters. They were renamed to avoid confusion with the other tuple"

Other than that, looks good :+1:

Fixes in jamadagni#1.

Hi I have an exam coming up and so slow to respond/work on this. Will do so next week. Thanks for your patience.

Ping - merge my pull request?

LOL. Request fulfilled.

@ntrel I guess you should resubmit that against dlang.org master now :)

I should have tagged jamadagni to avoid ambiguity ;-)
Resubmitted: https://github.com/dlang/dlang.org/pull/1283


add socket timeout exception as cause

for issue #139

Codecov Report

Merging #180 into dev will increase coverage by 0.03%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##                dev    #180      +/-   ##
===========================================
+ Coverage     31.36%   31.4%   +0.03%
- Complexity     1351    1353       +2
===========================================
  Files            97      97
  Lines         23307   23307
  Branches       3872    3872
===========================================
+ Hits           7310    7319       +9
+ Misses        14577   14569       -8
+ Partials       1420    1419       -1

Flag
Coverage Δ
Complexity Δ

#JDBC41
31.29% <0%> (+0.03%)
1348 <0> (+3)
:white_check_mark:

#JDBC42
31.28% <0%> (+0.04%)
1346 <0> (+1)
:white_check_mark:

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
34.88% <0%> (ø)
0 <0> (ø)
:x:

...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
21.32% <0%> (+0.08%)
157% <0%> (+1%)
:white_check_mark:

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
45.16% <0%> (+0.21%)
183% <0%> (ø)
:x:

...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
24.1% <0%> (+0.44%)
36% <0%> (ø)
:x:

...om/microsoft/sqlserver/jdbc/SimpleInputStream.java
39.7% <0%> (+1.47%)
10% <0%> (+1%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f58aa...a348b37. Read the comment docs.


Change the webhook port from 10251 to 10250

How to categorize this PR?

/kind bug
What this PR does / why we need it:
With port 10251 the webhook cannot be called on GKE clusters:
* Internal error occurred: failed calling webhook "operating-system-config.registry-cache.extensions.gardener.cloud": failed to call webhook: Post "https://gardener-extension-registry-cache.extension-extension-registry-cache-z8mc9.svc:443/operating-system-config?timeout=10s": context deadline exceeded

According to https://github.com/gardener/gardener/pull/2660 port 10250 is already open on GKE and using it avoids special configurations steps on GKE.
Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
N/A
Release note:

The default webhook server port for the registry-cache extension is now changed to from 10250 to 10251. Port 10250 is already open on GKE and using it avoids special configurations steps on GKE.

/approve

/lgtm

/cherry-pick release-v0.2


add the add-closed-milestone-dueDate to show closed milestones was du…

Working with milestones a lot and when trying to report on them I found it difficult from the closed milestones screen to know when the milestone was originally due as it only shows the closed date which is not very useful.
This PR adds only in the closed milestones list the was due on timestamp and highlights the closed date with a red color

We probably shouldn’t make that many api calls at once.

would love to hear your opinion on other direction @bfred-it. I thought so as well in the beginning but couldn't think of anything better 🙄

query repoProjects($owner: String!, $name: String!) {
repository(owner: $owner, name: $name) {
  milestones(first: 10, orderBy: {field: DUE_DATE, direction: DESC}){
    nodes{
      createdAt
      description
      dueOn
    }
  }
  }
}

GraphQL Would be nice here

Thanks a lot @yakov116 for the GraphQL Idea. @bfred-it I have now updated the PR to:

Include a GraphQL lib file to communicate with the Github API v4/GraphQL
Do a one call to get all the milestones visible in that page and add them to a "map"
Process the DOM and add the due dates accordingly

Too much code, we don’t need an abstraction, GraphQL-request and lodash. A plain fetch is enough

In a similar way why there is an api.js to abstract API why you don't want a GraphQL one ? I am happy for the removal of Lodash as that makes sense

@ahmadassaf I don't see why would have cashe it . We're not going to run into api limit issues anyways

Thats fine @yakov116 but I still do not see a problem with having an abstract file for GraphQL queries. If that will be a blocker for this PR then I will remove it.

Thanks @busches for the CR. I have addressed those comments in the latest push

The PR needs a better title.

The API code has been merged in #1522
After that has merged, this only needs a cleanup as per my previous review

Sorry guys .. lost track of this. I will be finishing this today/tomorrow and addressing all the rest of comments

This PR needs to be updated for the changes done in https://github.com/sindresorhus/refined-github/pull/1679.


Support for ODMs missing

Doctrine ODMs (MongoDB and PHPCR) support is missing.
Is there any plan to add them to the supported platforms?

A partial support was added in 2.x but I couldn't really maintain them so I removed the doc for it. In 3.x this could be done in https://github.com/theofidry/AliceDataFixtures if one is willing to do so. The abstracting to allow that exists, but I don't have enough time neither I am using them enough to add support for it. So PR are welcome, otherwise no support is currently plan :)

I'm currently working on it and seems really easy, since AliceDataFixtures ObjectManagerPersister uses the common doctrine interface. The only things missing are the purgers.
@theofidry What do you think about changing the current LoaderInterface::load signature removing $purgeWithTruncate and $shard argument to pass them as an options array? This would allow to implement concrete loaders for ODMs upon the same interface

I'm currently working on it and seems really easy

It used to be really annoying on the maintenance side. Might be easier now yeah :)

What do you think about changing the current LoaderInterface::load signature removing $purgeWithTruncate and $shard argument to pass them as an options array?

I think I prefer explicit arguments. ODM or other are unlikely to give additional options are they? If so I would just ignore it or throw an error if passed with the wrong value in the context of the ODM

Ok, thanks for the quick reply!
I will submit a couple of PR tomorrow here and on https://github.com/theofidry/AliceDataFixtures.

The support for both has been added to AliceDataFixtures. The feature can now be added to HautelookAliceBundle

On top of my head:

Add a command (I'm not sure to which extend DoctrineOrmLoadDataFixturesCommand can be re-used
Register that command as a service when Doctrine ODM is installed (the exact same way this is done for Doctrine ORM)
When both Doctrine ODM & ORM are picked: a config parameter should be allowed to be able to pick one, so we could bail out with an error requesting the user to pick one.

Eventually at some point we could add support for allowing one to use both ORM & ODM at the same time like in 1.x. However it requires more work and should be done later IMO

@theofidry Isn't also https://github.com/hautelook/AliceBundle/pull/391 one step in that direction?

Indeed, and it would need to be finished as well :/


Hyperparameters settings for Implicit matrix factorization algorithm.

New beginner for recommender system. I don't know how to tune the hyperparameters and don't know what is a literally good result. I would like to know what is a proper setting of hyperparameters for the simple Implicit matrix factorization method.
My example codes is like this.

The result is like this.

The MRR and the RMSE scores seem to be not that good for training set or testing, though there is clear overfitting here.
Thanks!

I would encourage you not to use the explicit models. Try the implicit model and see if you can improve MRR?

I will have a try. Thanks!


WindowReposition improvements

Allow explicitly specifying window (thus allowing changing the position of a window outside of that windows immediate context)
Return bool that represents if the window moved. This matters because if windows have relationships against each other, you want to reposition windows until none of them move (bar cyclic relationships)

ping :) @knoxfighter


BUG: Two Sections genre and Free- E-Books are Overlapping

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The Genre Section and the Free E-books Sections are overlapping.
Let me resolve the issues.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@anuragverma108 let me work on the issue.

@anuragverma108

This issue already exists. Please check the existing issues before raising a new one. Find another issue or feature to contribute to. Thank you!


F# Interactive v14 backward incompatibility: Error FS0193 when calling inlined Array.init

Hi. I have Visual Studio Community 2013 Update 4 and 2015 RC on my system. While I was experimenting with F# 4.0, I encountered a problem with the new F# Interactive (v14.0.22810.0).
I did my best to isolate the problem into a minimal example. Here are the steps to reproduce:

Compile an F# library with the code

namespace Library1

module Test =
    let inline init1 n f = Array.init n f
    let init2 n f = Array.init n f

targeting FSharp.Core <IP_ADDRESS>.

Have a script file where you call Test.init1

#r "./bin/Debug/Library1.dll"
open Library1

let a = Test.init1 4 (fun _ -> 4.)

and run it within F# Interactive 14.0.22810.0.
You get:
error FS0193: The module/namespace 'ErrorStrings' from compilation unit 'FSharp.Core' did not contain the val '{MemberParentMangledName = null;
 MemberIsOverride = false;
 LogicalName = "InputMustBeNonNegativeString";
 TotalArgCount = 0;}'

whereas if you run it with F# Interactive 12.0.30815.0 it runs fine:
val a : float [] = [|4.0; 4.0; 4.0; 4.0|]

Here is some extra information:

If you call Test.init2, which has the same type with Test.init1, with F# Interactive 14.0.22810.0, there is no error and it runs fine. So, there is something to do with inline.

When you call Test.init1 from an F# console application

open Library1

[<EntryPoint>]
let main argv =

    let a = Test.init1 4 (fun _ -> 4.)
    printfn "%A" a

there is no error. So, the error is about F# Interactive.

When you compile the library code targeting FSharp.Core version <IP_ADDRESS>, there is no error with F# Interactive 14.0.22810.0. So, this is a backward compatibility problem of the new F# Interactive with existing libraries compiled for FSharp.Core <IP_ADDRESS>, I think.

This commit broke the binary compatibility of FSharp.Core:  https://github.com/Microsoft/visualfsharp/commit/52a7252337983b093c7c0b1e5a4361de259cbe7c
because the "module let" bindings were changed to "static member" bindings, and as far as F# metadata is concerned these are different.  This obviously needs to be fixed for FSharp.Core <IP_ADDRESS>.
These items are referred to in the inlined implementations of Array.init and other functions.

that commit was mine, so i think i should help :smile: , i'll fix this
Possible fix:

revert the old ErrorStrings module (backward compatibility).
add the static methods as functions in ErrorStrings module (or another module like Resources maybe? so we can reuse it for all the FSharp.Core resources if needed? )

But @dsyme can you help me to understand better the problem?
The root problem i think is: FSharp.Core.SR.resources is private/internal, so functions like FSharp.Core.SR.resources.GetString or SR.GetString(SR.arrayWasEmpty)  etc, cannot be inlined, but some methods require it ( like average ) so we use a public wrapper ErrorStrings
That's ok, we can inline some functions, but not others unless we wrap the (SR.GetString(SR.arrayWasEmpty) as functions inside ErrorStrings.
The problem is:
Currently is difficult to inline more functions, because we break backward compatibility each time (like this bug).
If we add a new functions in ErrorStrings, reference the old version break for a simple refactoring (and maybe is a good perf improvement like an inline).
Maybe is already discussed before but cant we make a wrapper of FSharp.Core.SR.resources public instead? And use inlined functions for type safety access of resource strings?

module internal SR =

    //public wrapper
    let resourceManager: ResuorceManager = resources

module internal Resources =

   let inline GetString(name:System.String) : System.String =
        SR.resourceManager.GetString(name, System.Globalization.CultureInfo.CurrentUICulture)

   let inline arrayWasEmpty () = GetString(SR.arrayWasEmpty)

inside the code we can do Resources.arrayWasEmpty () and that is compiled as `SR.resourceManager.GetString("arrayWasEmpty", System.Globalization.CultureInfo.CurrentUICulture)
Another options is to use a GetString: string -> Culture option -> string wrapper instead to expose the ResourceManager class, but dont know, localization and resources are complicated.


Update components.md

修复翻译问题:
For most attributes, the value provided to the component will replace the value set by the component. So for example, passing type="large" will replace type="date" and probably break it! Fortunately, the class and style attributes are a little smarter, so both values are merged, making the final value: form-control date-picker-theme-dark.

原文译法可接受，本着尊重原译的态度，暂不做更改了。
不过还是感谢你的支持


SharePoint PnP JavaScript Core library URL

The current URL points to a deprecated repository (https://github.com/SharePoint/PnP-JS-Core), please update to the new repository https://github.com/pnp/pnpjs.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 142aa03b-97e7-1755-bf21-dcda38a6fe24
Version Independent ID: 5516201f-4576-16c9-b5bb-39fee234506a
Content: SharePoint Framework development tools and libraries
Content Source: docs/spfx/tools-and-libraries.md
Product: sharepoint
GitHub Login: @spdevdocs
Microsoft Alias: spdevdocs

Thanks for your post.


Stop PathFinder::pathFind from copying so much.

pathFind may be spending a lot of time copying values. If this is happening use pointers and references to speed the process up.

We should test both solutions and be sure that the new solution actually runs faster than the old one. There  may be lots of things being copied, but they are small. It is conceivable that pointer work will be slower.


Dead Letter function in LogStash Plugin

Is your feature request related to a problem? Please describe.
In current implementation at [1], LogStash plugin possibly lose our data before sending data to Azure when the network is unreachable for long time.
[1] https://github.com/Azure/Azure-Sentinel/blob/master/DataConnectors/microsoft-logstash-output-azure-loganalytics/lib/logstash/logAnalyticsClient/logStashAutoResizeBuffer.rb#L90
Describe the solution you'd like
I'd like to have Dead Letter Queue function in this plugin. More details are in [2].
With Dead Letter Queue Input plugin [3], we can handle undelivered message as we like if it is adaptable.
As [2] describe, currently this is implemented only in ElasticSearch output plugin but I believe this error handling is suitable way as entire LogStash plugins.
[2] https://www.elastic.co/guide/en/logstash/current/dead-letter-queues.html
[3] https://www.elastic.co/guide/en/logstash/current/plugins-inputs-dead_letter_queue.html
Describe alternatives you've considered
More simply, if we can just output undelivered message as file, it should be good.
Additional context
Because this plugin output targets only Azure cloud, I believe the down time can be relatively longer than more vicinity systems, that include network error.
Especially in my context, we are transferring Security related information, which should not be loss as much as possible.

Thanks for the contribution, we are taking a look and will address the issue.


Audit Log, when I click on Time sort order, I lose the ability to see the most current events

Rancher versions: master 2.0 8/10
Steps to Reproduce:

Go to Audit Log
Click on Time, click on it again

Results:  It only returns events that are "a day ago", all the most current fired events are lost

hi @tfiduccia , I can not reproduce this issue against master and v2.0.0-alpha9.  I can see the current events when I click on Time and click it again.

@loganhz - I have demonstrated this to Vincent, it still exist and he know why.  Please touch base with him.

You have to have a longer history/more events to see.  The problem is the initial set of events is sorted server-side, but clicking on the headers after that is doing client-side sorting of only the data that was already loaded instead of going back to the server to get more.

Version - 2.0 master 10/16
Verified fixed


Concurrency and Game Copy Validation

Not sure how well this is actually working so am open to opinions on this.
Should make the download and extraction for the patcher run at the same time as copying the EFT directory if either are required. Will also ensure validate that any eft files already copied are correct so that it won't copy if they aren't required.

Might be even better solutions than this but this is my immediate gut response. In order to prevent this slowing things down we could store a csv/json file of the file path, its hash and its last write time value. When we go to do a subsequent copy we can compare write times and (in theory at least) if the file hasn't been modified we can skip checking the hash. We could the provide a separate "validate" feature that does check the hashes.  You decide


Added beam area and beam squared area calculations

A fairly simple addition that allows the UVBeam to output the integral of the beam and the integral of the beam squared.

@acliu It looks like the Travis checks failed because of some pep8 issues. Also, can you add testing to fully cover your functions?

Thanks Bryna! I've made the changes outlined above, written a bunch of tests, and have also checked against pep8 standards.

Ok, I just tried to fix the pep8 issues. The weird thing is that the pep8 checker on my computer didn't seem to pick up on them, but when I clicked the link next to the failed build (thanks for the tip!), they showed up.


Update abstract op so early return is obvious

Is there any chance there could be more than one matching group in groups? The previous algorithm selected the last one, this selects the first. I suspect it doesn’t matter here but wanted to call it out.

Nope, it's guaranteed to be unique. But that wasn't obvious from the code, which is why I thought to change it. Since you made it an abstract op, the early return is easy (I couldn't find a similar "break" op in a "for each" loop).

Maybe we should add an assertion before the loop - something that ensures that any [[Key]] in the groups list only appears once?

Do you know how we would phrase that? Is it ok to hand wave and say "at most one record will match SameValueZero"?

Alternatively, I could switch back and Assert: _group_ is ~empty~.

I think phrasing like that would work; give me a bit and I’ll make a PR.

Found a couple useful precedents; filed #23


"find in selection" for notebook

@Xinyu-Wu-0000 commented on Tue Apr 13 2021
Issue Type: Feature Request
Hope to use "find in selection" function in notebooks.
Extension version: 2021.5.743038836-dev
VS Code version: Code - Insiders 1.56.0-insider (48387dfc3d691558404cff1ea2582e3862a40080, 2021-04-13T05:15:44.407Z)
OS version: Linux x64 5.11.0-13-generic

@IanMatthewHuff commented on Tue Apr 13 2021
I do repro this as well. However with the new Native Notebook UI this search / find UI is controlled by core VS Code, not the Jupyter extension. I'm going to transfer this issue to their repo.

@Xinyu-Wu-0000 commented on Tue Apr 13 2021
Issue Type: Feature Request
Hope to use "find in selection" function in notebooks.
Extension version: 2021.5.743038836-dev VS Code version: Code - Insiders 1.56.0-insider (48387df, 2021-04-13T05:15:44.407Z) OS version: Linux x64 5.11.0-13-generic
@IanMatthewHuff commented on Tue Apr 13 2021
I do repro this as well. However with the new Native Notebook UI this search / find UI is controlled by core VS Code, not the Jupyter extension. I'm going to transfer this issue to their repo.
+1

I'm kind of conused why is this considered a feature request and not a bug? Find is not respecting global search settings like "Auto find in selection".  I guess it's just semantics but tagging this as feature seems like a way to de-emphasize its importance, but given the number of dups I'd say it's pretty important to people.

Solution is given in #141493 with the F3 key which allows find in selection/cell so this can be closed

No, it can’t. F3 doesn’t do anything differently.

I am in vscode 1.75.0 and F3 to search and replace in a notebook cell does not work anymore, is this issue related to that problem or should I open a new one?
https://github.com/microsoft/vscode/issues/141493#issuecomment-1196872284

I'm having the same problem as @lgonzalezsa

I am in vscode 1.76.0 and I am experiencing the same problem

I can also confirm the same problem in 1.76.0.

also in 1.78.2
We need F3 back

Also in 1.80.0
This would be much needed.

Related on Stack Overflow: Why is find and replace in Notebooks in VS Code different than in text documents? Are there ways to make them more similar?

Any update on this?

Helo,
I tried using the latest (1.85.2) version of VSCode, and found that:
when you select and type Ctrl F, the search starts from the beginning of
the notebook, while it starts from the selection for a plain file.
I subsequently found that if you click again after Ctrl F, the search
starts from the point of selection for a notebook too, and then the
behavior is similar to the plain file's one.
Sincerely,
Gilles
Le mar. 30 janv. 2024 à 00:18, miguelroboso @.***> a
écrit :

Any update on this?
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/121218#issuecomment-1915744703,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABN6LF7FQMBD4GX343BEDZLYRAU4PAVCNFSM4233MKL2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJRGU3TINBXGAZQ
.
You are receiving this because you commented.Message ID:
@.***>

Is there a roadmap where the missing feature will be added? a workaround I am using is to copy the cell code in a new text file and then replace what I need in a controlled way.

Related to work done at: #209839
This issue requests textual selections (multiple lines in a cell, etc). There is now support for cell selections upon the enabling of the newly introduced setting "notebook.experimental.find.scope.enabled": true

Great! Can I use it today? I added the setting not sure what to expect in the find UI.

Related to work done at: #209839
This issue requests textual selections (multiple lines in a cell, etc). There is now support for cell selections upon the enabling of the newly introduced setting "notebook.experimental.find.scope.enabled": true

Glad to hear that

Great! Can I use it today?

@lgonzalezsa the search in cell selection you can 👍 if you enable the setting, you will see the new "in selection" button to the left of the arrows that let you step between results. The feature is active on insiders, and is included in the upcoming stable release as well. Here's a video of how it currently works, and I'll be working to expand functionality for textual selections (in addition to cell selections) this month.
https://github.com/microsoft/vscode/assets/12552271/ef6dacb5-cdb4-4ada-b1ef-47f86d6214bf

I added the setting not sure what to expect in the find UI.

Without the setting enabled, you will not be able to see the "in selection" button within the find widget when you are using a notebook editor. When enabled, the button should be visible.

It is not working for me, I added it to the bottom of my settings file as follows:

Hm, interesting. Could you check which version of vscode you are running? The feature would only be available in a recent insiders, and not until stable 1.90 is released this week. This can be checked via the help menu -> About.
Could you also check if the setting is visible in the settings UI? Searching just for "notebook find" should populate the setting.

Got it! seeing it now in 1.90 was waiting for that feature to be enabled again! helps a lot, THANKS!

Hello,
Thanks a lot for the features, very useful! Is it correct that when I
change the scope to another cell by pointing the mouse there, I have to
redo the Find in cell (otherwise, the search remains focused on the same
cell) ?
Thanks again
Le ven. 31 mai 2024 à 21:29, Michael Lively @.***> a
écrit :

Related to work done at: #209839
https://github.com/microsoft/vscode/issues/209839
This issue requests textual selections (multiple lines in a cell, etc).
There is now support for cell selections upon the enabling of the newly
introduced setting "notebook.experimental.find.scope.enabled": true
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/121218#issuecomment-2142863910,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABN6LF7C2ARIJ7SVN4G3I6LZFDFP7AVCNFSM4233MKL2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMJUGI4DMMZZGEYA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Yes, the "Find in Selection" button needs to be toggled off and on again to change the selection. This is currently the same behavior that works for standard editor "Find in Selection" in regards to changing the selection. The decorations applied to the cells are a good indicator of the range you will be searching within.


Feature Request: Team File Listing

Could you please extend this to also facilitate showing all files that are part of a team?
Obviously admins would see all files and non-admins would see files that they have permission to access, but this would be very helpful in finding things quickly that have been uploaded.

Hi,
Sure, can do.
I've started working on it on a separate branch. Based on my availability I think it should be done in a week or so, but we'll see about that.

I'm thinking whether I should allow searching for files of channels where the admin is not a member. I mean, by default an admin can't even see a list of private channels, let alone browser their contents.
I'll probably add an opt-in config setting for this feature because it seems weird from privacy standpoint.
Now that I think of it, Mattermost might even block downloading of files from channels where one is not a member, but I'll just display file names instead of links if need be.

Well, yeah, I think this approach of flexibility is good.  Better to give such options to admin users vs locking them down.


Update zsh-plugin-reload.plugin.zsh

add support for custom $ZDOTDIR

@amogus07 Can I get more information?

@aubreypwd As of now, the location of .zshrc is hardcoded to be ~. With the changes, the content of the environment variable $ZDOTDIR is used by default to determine the location of .zshrc. This variable allows users to change the location of .zshrc and other zsh related files in the home directory. For example, I set ZDOTDIR to /home/konstantink/.config/zsh. If $ZDOTDIR is empty, $HOME is used as a fallback.


Copied content not showing up

Hi! Just noticed this bug while using the app (absolutely beautiful UI btw, encryption pretty please?), whenever I copy a huge paragraph on one of the notes, it doesn't show it in its entirety (more like 1/10th of the whole thing). I can't even scroll down unless I go into edit mode. It's quite inconvenient to not be able to copy stuff since I do it pretty regularly, but your notes app is the most visually pleasing alternative to Keep. So it's kinda a shame that I can't use it as a daily for now.
Appreciate the great app though! You guys rock!
I hope the image attachment works, here's a comparison between Notally and POSP Note:

Oh yea this is totally a bug in the legacy app version, but it has been fixed for quite some months now on the new app (which is set to release very soon), so dw about it as it won't be present in the next update

@HrX03 Damn that was a quick response :D
Thanks! That's awesome news, I look forward to using it! I'll buy you a cup of coffee as soon as I have a bank account :p


Multi Line selection using 'command' and 'shift' in developer console - Feature request

In developer console, using 'command' key, I can edit multiple lines. But Selection of multiple lines using the combination of shift key and command key is not working while editing the files. It is selecting only one line.
Issue

Feature requested:

Thanks for the request ! This repo is only for the content of WebFundamentals site. Please file any feature request over at crbug.com Thanks ! 👍

Okay Cool Thanks


View/Edit/Delete Saved Point

Desktop mockup
Mobile mockup
As a logged-in user of any role I want to be able to view the data I saved for a point, and edit or delete my saved points. Similar workflow options for both desktop and mobile.

Click on saved point on map
Point is highlighted to show it's selected
Panel opens to show saved data

shows lat/long in decimal degrees

Additional option to Hide on map

when checked, point doesn't show up on map

Options to edit point data

Point name
Color
Notes
Images

Option to delete point and data

I think this may have changed since it was created. Maybe close and add more current ideas?
I've got the zoom, delete, and more/less as options now.


keydb: init at 6.3.1

Description of changes
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 191973 run on x86_64-linux 1

1 package built:

keydb

built keydb on x86-64_linux and aarch64-linux as well as pkgsCross.aarch64-multiplatform.keydb on x86_64-linux


fix: change background image to handle bug at microsoft edge

Changelog:

fix: change background image to handle bug at microsoft edge

looks good to me 🫡


Read and parse UNFCCC CRF (common reporting format) data files for UK

Is your feature request related to a problem?
We need to be able to incorporate and understand emissions inventory data using the CRF format (Excel spreadsheet) used by Annex I countries when reporting to the UNFCCC. We mainly need to be able to read in data for the UK for now.
This will be 1D emissions data initially.
Describe the solution you'd like
Create a new parser to be able to read specific CRF files (this may be difficult to generalise but would be good to keep within the current framework even if its specific).
Additional context
This will be 1D emissions data and so Issue #301 will need to be completed for this.

What format are we looking for?
One thought I had was to make a separate file for each species. If the files were dataframes, then the index would be a datetime index with years, and the column would be emissions in each sector, possibly with multilevel columns for the different groups of sectors.
Does this sound okay? I guess a netCDF would let us track the units as well.


geoserver: init at 2.21.0

Description of changes

GeoServer is the reference implementation of the Open Geospatial Consortium (OGC) Web Feature Service (WFS) and Web Coverage Service (WCS) standards, as well as a high performance certified compliant Web Map Service (WMS), compliant Catalog Service for the Web (CSW) and implementing Web Processing Service (WPS). GeoServer forms a core component of the Geospatial Web.

Try it out:

mkdir -p data_dir
GEOSERVER_DATA_DIR=$PWD/data_dir result/bin/geoserver-startup
Go to http://localhost:8080/geoserver (admin:geoserver)
Read more: https://docs.geoserver.org/latest/en/user/index.html

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg eval


Excessive flickering of lines when editing shapes in WorldWind

When editing points in WorldWind the lines that are drawn flicker a lot.
Use the following script and edit the shape by moving the control points
var counterattack = new emp3.api.MilStdSymbol({
  symbolCode: "GFTPKF--------X",
  positions: [
    {latitude: 20, longitude: 50}, // Tip of the arrow
    {latitude: 20, longitude: 49}, // Back of the arrow
    {latitude: 20.1, longitude: 49.8} // Shape of the arrow
  ]
});
this.props.addFeature(counterattack);

var overlay = new emp3.api.Overlay();
this.props.addOverlay(overlay);

map0.addOverlay({
  overlay: overlay,
  onSuccess: function() {
    overlay.addFeature({
      feature: counterattack,
      onSuccess: function() {
        map0.zoomTo({
          overlay: overlay
        });
        map0.editFeature({
          feature: counterattack
        });
      }
    });
  }
});

Test case:
The fix reduces the flickering. test by comparing the flickering in the dev branch against this branch. the test is a success if the flickering in this branch is reduced.

Still flickering while editing

Reintegrate

Already merged into the dev branch. Closing this issue.


[Docker] The SECRET_KEY setting must not be empty.

What I'm trying to achieve
Install and run Saleor on Docker in production
Steps to reproduce the problem

docker build -t mystorefront .
docker run mystorefront:latest

What I expected to happen
Launch the store on port 8000
Screenshots

System information
Operating system: UBUNTU 18.04
Browser:
General questions:
What are the env variables that docker is using and how can I change them?

For local development you might want to use docker-compose up
Env variables are listed here: https://docs.getsaleor.com/en/latest/gettingstarted/configuration.html

Hi @Pacu2, this is not for development, it's for production.

I'm really confused here and I don't know how to deploy using docker. I'm still getting this error.
What are the correct steps please?

Please try docker run -e SECRET_KEY=*** -e DATABASE_URL=*** -p 8000:8000 saleor

Are those parameters (-e DATABASE_URL=*** ) referring to docker's postgres?

It can be any postgres database owned by you. You can run postgresl via docker or buy postgreql from cloud provider.

But isn't that docker's purpose? To have everything in a single container that doesn't affect the system you're working on?
I really don't want to run postgres outside docker as I think it'd become harder to maintain..

Sure, then you can run another postgresql container via docker. You can not setup multiple services in one container. So I would recommend you use docker-compose. Refer https://docs.getsaleor.com/en/latest/customization/docker.html

Thanks for your comment, but isn't that, per say, for development and not for production?

Or you can run docker run -d -e POSTGRES_USER=saleor -e POSTGRES_PASSWORD=saleor postgres:9.6-alpine to startup your postgresql service. Then you database url would be postgres://saleor:saleor@localhost:5432/saleor

IMO, docker-compose can be used for production, only if you setup correctly

Ok, let's see what the maintainers have to say in this.
Thanks for your efforts.

Yes, the env command gives the secret_key I set. But I noticed it got reset every time I ssh to my server.
Should I set it inside docker or the ubuntu server?

I added the export command to .bash_profile and now it's persisted. But so is the problem :)

@jxltom is right. You need to set the environment variable from outside the Docker. Either give it explicitly when starting docker (docker run -e SECRET_KEY=soverysecret ...) or export it in your startup script and tell Docker to use the value (docker run -e SECRET_KEY ...).

Thanks for the confirmation.
Thanks to @jxltom too. I'll try and get back to you.
More stress for a detailed documentation.

UPDATE, the server runs without issues, but when I try to connect to ip:8000 the connection is refused.
Any idea why? I checked iptables, explicitly allowd tcp on 8000 but still connection refused.

It should be accessed in <IP_ADDRESS>:8000.
For accessed via <IP_ADDRESS>:8000, probably you need to setup proxy if your server is running behind a reverse proxy such as nginx

I don't think it works:
curl: (7) Failed to connect to <IP_ADDRESS> port 8000: Connection refused

Have you you added -p 8000:8000 in docker run?
Besides, are you sure you have never set PORT environment varialble other than 8000?

I didn't change anything in that. it's by default.
EXPOSE 8000
ENV PORT 8000

It works thanks a lot.
Why do you think the initial config didn't work out?

It is because EXPOSE only make the port be accessed within docker. -p which is publish argument make it can be accessed anywhere.

Awersome. Thanks a lot for all the help.


Remove points until we can see the big picture

Most conversations right now are revolving around the point values for
each check. These aren't very productive conversations right now since
we can't see the big picture to know what the total point count is.  I
propose we shelf the points concept until we have a clear picture of
what the MVP quality metrics are.  From there we can determine an
initial total and what share of that total each metric should comprise.

I agree with this completely. I think having Yes/No for an indicator allows one to quickly see that a cookbook has "10 out of 12" quality indicators achieved. Even if some of the metrics are easier than others, you can tell the difference between "4 of 12" vs. "12 of 12" for example.

I think this is a really good idea and it removes the confusion of how one rule weighs against another. I do think that in the end a numeric scale can be extremely helpful and influential. If done wrong it can be very destructive. This is a good approach to safely test the quality metric.

Just to clarify I don't think we should eliminate the point system all together.  I just think during the initial conversation of what metrics we want we're not helping ourselves by debating the difference between 5 points and 10 points.

:+1: it feels too early for points.

:+1: :100:

:+1:

:+1:


Synapse Notebooks missing as "Data transformation activities"

Concerning Data transformation activities / Compute Environments:
Synapse Notebooks are missing

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab1bddf8-6515-3979-ffde-0bab66caa817
Version Independent ID: c1f105f2-3faa-3aca-7365-02ffeaae6d0a
Content: Pipelines and activities - Azure Data Factory & Azure Synapse
Content Source: articles/data-factory/concepts-pipelines-activities.md
Service: data-factory
Sub-service: orchestration
GitHub Login: @dcstwh
Microsoft Alias: weetok

@keen85 Thank you for feedback. We are actively monitoring it and revert back soon with updates. Thank you.

@dcstwh - User is requesting for Synapse  Notebook activity under Data Transformations activities section.
Could you please validate feedback and update as appropriate. Thank you.

I have notified the owners to add this to the docs.
Thank you for the feedback.

#please-close

The docs for Synapse notebook activity is already covered here
https://docs.microsoft.com/en-us/azure/synapse-analytics/synapse-notebook-activity

Yes, the concept of Synapse Notebooks has its own article.
My point is, that Synapse Notebooks can also be part of a Synapse Pipeline. In this case, Synapse Notebooks is a data transformation activities and it is still missing in this very list...


Metamorph: dynamic values for name attributes possible?

In between we use dynamic values (regularly taken from values of the same record) to create the name of new elements for the target record. Here you can find an example for this
My question: Is this possible with Metamorph? Do you have an idea what has to be done to get something similar with Metamorph / Metafacture mechanisms?

Thanks for any response!
Günter

Hi Günter,
there are a number of ways to generate literal and entity names from the data values received.

The easiest is to use <combine>. It allows you to use variables in the name attribute in the same way as in the value attribute:

<combine name="${NAME}" value=${VALUE}">
  <data source="name-source-field" name="NAME" />
  <data source="value-source-field" name="VALUE" />
</combine>

To dynamically set the name of an entity you can use the <entity-name> statement:

<entity>
  <entity-name>
     <data source="name-source" />
  </entity-name>
  <data soource="entity-contents" />
</entity>

And finally, there is the <switch-name-value> function which can be used in data statements to swap name and value of the currently processed literal. It allows you to access the literal name and also to manipulate the name of the generated literal. It is a bit complicated to use though:

<data source="021A.p">
 <switch-name-value />
</data>

If this statement receives the literal 021A.p=Personalname, it will output Personalname=021A.p.
<data source="021A.p">
 <constant value="foo" />
 <switch-name-value />
</data>

Receiving the same literal as above, this statement will produce the output foo=021A.p. It first set the output value to foo and than changes name and value, so foo becomes the new name and 021A.p the value.

Hello @guenterh, could you solve your issue following these hints? Then you could close the issue.


Fixed typo on "trtaffic"

Typo in Get Started with Kubernetes network policy.

Deploy preview for calico ready!
Built with commit fcae1f63c6a491c84df866af68a93a85d27ac8f8
https://deploy-preview-2790--calico.netlify.com


Pull in latest tokens from figma

Made a few updates to the figma tokens file --
Semantic gap spacers

Added semantic gap tokens that @thatblindgeye created in: https://github.com/patternfly/patternfly/pull/6957. Needed to add "--default" to existing group-to-group/horizontal and vertical tokens so they export correctly.

Color tokens to support read-only controls

Added global/border/color/50 and global/dark/border/color/50
Added global/border/color/control/read-only
Added global/background/color/control/read-only

DPO Typography Updates

Base tokens:  Increases our font--size--600 and icon--size--300 from 22px to 24px.
Base tokens: Adjusts font--weight--300 from 700 to 500
Base tokens: Also adjusted figma only line-height value, but that should be filtered out.

Will create core issues for follow-up work

closed by https://github.com/patternfly/patternfly/pull/7075


losinglena.com domain expired

The domain linked in the README has expired and now acts as a For Sale sign for the domain. Not sure if there is another link that could replace it or what, but figured I would give you all a heads up
https://github.com/BinomialLLC/basis_universal/blob/ad9386a4a1cf2a248f7bbd45f543a7448db15267/README.md?plain=1#L27-L31

Thanks, I'll redirect that to archive.org.


Update to operator-sdk v1.38.0

Followed README steps to create a new project with operator-sdk v1.38.0 and update all project files accordingly

[x] example-cnf installation - https://www.distributed-ci.io/jobs/7f1cf69b-0d39-4ebe-a630-20f17ea2870f/jobStates?sort=date
[ ] full example-cnf pipeline with preflight and certsuite - https://www.distributed-ci.io/jobs/b6634377-f03e-4a58-90bf-2f69cf0aa947/jobStates?sort=date

I've found several failures in certsuite and preflight that need to be checked, I'll move this to draft for the moment.

Addressed the certsuite and preflight issues with this commit. These are the modifications:

Define metrics services for controller managers as PreferDualStack, so that networking-dual-stack-service certsuite test can pass
Declare HTTPS metrics port, 8443, in all controller manager pods, so that networking-undeclared-container-ports-usage certsuite test can pass
Honestly, it's quite strange that BasedOnUbi preflight test for cnf-app-mac-operator container image is failing since we use ubi8 image. Don't know if the comment with the original FROM sentence is causing issues, I've just removed that

In the last job, I could see the issues were fixed but now it's failing another certsuite test, because I'm using a wrong container port name, it must be prefixed by http- or tcp-, so I'll use http-s- instead of https-. Preflight is now working, so in the next run, I'll just test certsuite to save some time

from change #108:

SUCCESS https://www.distributed-ci.io/jobs/80e9bedb-38b4-4794-8cfd-09693bf8ee59/jobStates

Now we have exactly the same results in certsuite testing than in daily jobs: (this one is from today in the same OCP version: https://www.distributed-ci.io/jobs/9030b8be-a296-45ff-87a3-4d69fe83ffe7/tests/8398b325-8a3e-408f-9322-c124aac0bda1), so this change is now ready for review.


have some config for redis to print redis trace param on skywalking ui?similar as plugin.mysql.trace_sql_parameters of agent

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

If there isn't this config in the document, then we haven't provided it yet. If you want, consider contributing to this.


Sub-cursor updates are concurrent

const data = Immutable.fromJS({a: 1, b: 2});

const cursor = Cursor.from(data, newData => {
  console.log(newData)
});

cursor.set('a', 2); // Map {"a": 2, "b": 2}
cursor.set('b', 3); // Map {"a": 1, "b": 3}

The second .set() call disregards the value which the first .set() call sets. I require the second .set() to return Map {"a": 2, "b": 3}
Context
Two sub cursors (which don't share the same parent cursor), are passed to a React component as two individual props. I wish to update the values of both sub cursors in the same function call within that React component.

In older versions of Immutable you needed to actually redefine the cursor on each change.
Try something like:
const cursor = Cursor.from(onTransaction);
function  onTransaction(newData, oldData) {
      cursor = Cursor.from(newData, onTransaction);
}

From the source it looks like you just use withMutations:
  it('can have mutations apply with a single callback', () => {
    var onChange = jest.genMockFunction();
    var data = Immutable.fromJS({'a': 1});

    var c1 = data.cursor(onChange);
    var c2 = c1.withMutations(m => m.set('b', 2).set('c', 3).set('d', 4));

    expect(c1.toObject()).toEqual({'a': 1});
    expect(c2.toObject()).toEqual({'a': 1, 'b': 2, 'c': 3, 'd': 4});
    expect(onChange.mock.calls.length).toBe(1);
  });

I think the problem is more like this, in code:
const data = Immutable.fromJS({a: 1, b: 2});

const cursor = Cursor.from(data, newData => {
  console.log(newData)
});

const cursor1 = cursor.get('a');
const cursor2 = cursor.get('b');

// pass cursor1 and cursor2 to different places, then

cursor1.set('a', 2); // Map {"a": 2, "b": 2}
cursor2.set('b', 3); // Map {"a": 1, "b": 3}

The cursors are independent, changing one has no effect on the other, which makes them less useful than they could be. You could say they are not "live" - once you derive a cursor from a parent, changes to the parent (because they need to overwrite the parent), don't affect the child any more.
All the cursors do is enable you to apply "local-looking" changes to the global data structure as of the time they were created.
Normally you'd solve this with chaining, but since they are now in different places, you can't do even that. Not sure how to proceed in this case...

The core of the problem is that each cursor holds it's own reference to the root data, not a shared one. It would IMHO require significant changes to how cursors work to enable this use-case.

@jameshopkins based on your requirements from context section:

Two sub cursors (which don't share the same parent cursor), are passed to a React component as two > individual props. I wish to update the values of both sub cursors in the same function call within that React component.

One approach would be to pass an onChange handler to the child  component that calls a function on the parent with both new values. Then your parent component can use withMutations to make both changes transitionally.

@jurassix that sort of defeats the point of using cursors in the first place - i.e. getting away from the callback spaghetti :)

Using flux, the difference between dispatching an action with a batch of updates to make to the global app state vs two sequential single updates definitely simplifies the code; which is really what I'm advocating, but my example was for the trivial non-flux case.
In practice, I think actually mutating data inside a component via set is something to avoid. So callbacks, or actions, that keep components pure are preferred. Then when mutations are needed we dispatch actions to update our stores. A cursor then just simplifies the store and dispatching of change events.
I used to think that cursors could stand in as a replacement for flux; but because it leads to mutating global app state inside of a component I don't feel that way anymore. In non-flux apps I'd advocate for callbacks in the child components to increase the number of pure components, and reduce the actual number of components that mutate data. This separating will aid in reusability of the components outside of the current context too.

Closing this aging issue


Reporting a User

Support for all the main functions of Instagram Web

but there is no reporting function and instagram web has reporting function

Do you still need to use this function ? If so, I will try to PR the project but I can't promise you.

Do you still need to use this function ? If so, I will try to PR the project but I can't promise you.


Transpiling for the Typescript release (0.2.3)

Before the Typescript version can be released, there needs to be proper transpiling of the package.
Ideally, Webpack + Babel OR Rollup + Rollup-Typescript is used to transpile the project into a minified JS package that can be imported both in the browser and in Node.

@deanpress we are able to transpile for the web platform using webpack. To check it our you can test #40

Although I got the builds for the browser & Node.js working (some shady hack), we still need to define the scripts in package.json for proper transpiling process.


figcaption for images

A great idea
As seen in the picture, the image tag is added into the figure tag, but when I want to write a figcaption, there is no option I can do, I wonder if there is a way to add it or  would you consider adding it?

Perhaps you can disable the expansion of images and then allow the use of figcaption related tags.
The relevant documentation can be found here
https://imzbf.github.io/md-editor-rt/en-US/docs#🍤 markdownItPlugins
https://imzbf.github.io/md-editor-rt/en-US/demo#🔏 Modify XSS configuration

Thanks for your advice.


SW spec never hooks into the "runs a worker" term that the CSP spec uses to enforce CSPs

https://w3c.github.io/webappsec/specs/content-security-policy/#processing-model-workers says "Whenever a user agent runs a worker: …", but https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html never updates the definition of "run a worker" from http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#run-a-worker nor mentions the Content-Security-Policy header in order to apply it directly.

@jyasskin Due to the different lifecycle and the processing model, SW spec defines Run Service Worker algorithm instead of hooking into Worker's run a worker algorithm. Run Service Worker, when called, runs already fetched service worker script, and the actual script fetching is done in Update algorithm step 4.3.7. Do you have any suggestion how to enforce CSPs for SW?

You would need to look at how it's done in the "run a worker" algorithm. You may also have to send @mkwst a patch for the CSP spec so it has a hook for SWs.

I brought the text from CSP spec to SW Security Considerations section for now: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#content-security. When things are settled on CSP.next, we may just link to CSP. Note that the origin's globally unique identifier check step is omitted as the script's origin should not be a globally unique identifier once it gets to the point where it can invoke Run Service Worker algorithm.
Closing.


Added additional information to the capability levels

Added additional information for each capability level in l5 operator
Signed-off-by: Manna Kong<EMAIL_ADDRESS>

Fixes #116

/lgtm


Remove mention of 'VideoLocker' since it is no longer meaningful as we add features

@hanningni I don't know if it makes any sense to review this, but basically I replaced all the mentions of 'edXVideoLocker' with 'edX' since we're adding non video features. I wanted to do this now because it will be harder to move things around with more people joining the project. You may want to do the analogous thing in the android app.


Fix issues with connection threads

This PR fixes some issues with connections and threading. Specifically, the  changes in #618 which introduced threading in HostConnection, also introduced some issues. To fix them, the following changes were made:

A specific TCP listener thread is used and manually started, instead of using one of the threads in the pool. The TCP listener thread is a long lived thread that should always be running (as long as the connection is through TCP) and be blocked listening on the TCP socket, so it shouldn't be managed in a pool, where, theoretically, it can be paused and reused;
Changed the number of threads to 5. We need 2 threads to run correctly, so we shouldn't create much more than this, otherwise we can overwhelm some Kodi hardware;
Had to sprinkle some synchronized's to avoid race conditions. For instance, through a TCP connection, as soon as Kore is opened (from a clean state) it will call at least GetActivePlayers, GetProperties, Ping. Given that the TCP socket isn't set up yet, each of these calls has the potential to create a socket (and a TCP listener thread), so we would open 3 or more sockets, 2 of which would be leaked because we would use only 1 from then on. A synchronized in executeThroughTcp prevents this. The others prevent similar issues.

Additionally:

Tweaked the playlist fetching code, so that most of it happens in HostConnectionObserver and when PlaylistFragment is notified of changes, it already gets the playlist data. This somewhat simplifies the code, and makes it more consistent with the Player Observer code;
Change EventServerConnection to accept a Handler on which to post the result of the connection, so that the caller can control on which thread the result is called;
Calls to the various RegisterObserver loose the reply immediately parameter, as it was always true.

@poisdeux When you have the time, i would appreciate if you could make some tests on this, specifically to make sure that the playlist fetching code is working in all situations. I tried to cover them all, but you probably have more knowledge about edge cases.

Only had a look at the code. I will do some testing later on. The code looks good.
There is only one edge case I can currently think of. I didn't bother implementing it as I found it to be a far stretched case that might not be an issue at all. So was thinking on only solving it when users start complaining :).
The edge case has to do with adding a large amount of items at once. As we also listen to Playlist.OnAdd and Playlist.OnRemove events we might want to add some logic to wait until we have received the last event. We now start fetching the new playlist at the first call which might result in only a partial playlist as the other items are still being added. We could post delay the call to checkPlaylist() and if we get a subsequent Playlist.OnAdd call before the delay passes we remove the previous call and post a new delayed call. This would make sure that if someone adds a zillion items at once we wait until the last item has been added before calling checkPlaylist(). A drawback is that it might take a while before the playlist is shown in Kore.
(Of course the ideal solution would be to implement pagination)

Yeah, but maybe that's not an issue at all, depending on how Kodi adds items to its playlist. Maybe It adds all of them at once,  and them sequentially notifies clients with Playlist.OnAdd for each one. So, maybe the first checkPlaylist is enough to get all the added items. Anyway, i also think that's something for later.
I was referring more to test cases that the previous code handled that might turn out wrong with the modifications of this PR.

@poisdeux Could you take a look at this PR when you have the time.
I would like to do a release soon, and the issues with threads should be fixed.

@SyncedSynapse Sorry, but I've been rather busy lately. Hopefully I can find some time to look at this and #658 in about two weeks.

@SyncedSynapse I tried to simply rebase this branch on top of #658 to see if the tests run and succeed. Unfortunately they do not and as there has been a lot of changes on master since this PR was created it is a bit difficult to see why things are failing. Can you rebase this branch on the the latest commit on master and check if your changes still work?

@poisdeux This PR applies cleanly on top of the current master, and works as intended, afaict. #658 doesn't apply cleanly because of the changes to PlaylistFragment, which honestly i'm not a fan of, as they seem a particularly complex way of solving a race issue that only occurs in testing. Serialing the access would be simpler and not have impacts on performance as it only applies to tests.

Woohoo! All green!


List of packages update : display version issue

In the list of packages update (to 15.7.8), there is a small display version issue for package openldap-client and openssh-portable

Fixed in https://github.com/opnsense/core/commit/6f075701a257890238018469a173986a1b702296 and already queued up for 15.7.9 -- but nice catch :)


Support for prefers-color-scheme?

Hi,
does react-responsive have support for the prefers-color-scheme query, and if it doesn't could it be implemented?
Thanks!

If it is supported as a CSS media query the library supports it

Thanks! It turns out that I was trying to use it in an environment (Adobe UXP plugins) that is not yet able to make it work—hence it didn't :-)


issue with the new design at crhoy.com, it only reads 6 articles

The newspaper portal has changed and today if we run the framework is only reading 6 articles.
import newspapers
crhoy = newspaper.build('http://www.crhoy.com/', language='es')
print(len(crhoy.articles))

Do you see any workaround here?
Thanks

Hi there,
You may use the "memoize_articles=False" config attribute. As stated in the doc :

"memoize_articles", default True, “cache and save articles run after run”

With this config, I get 55 articles which seems a bit low considering the home page of crhoy. Hops it hels you. :)

Thanks you @Ennoriel


[DH-273] update vscode...and lots of other things

https://jira-secure.berkeley.edu/browse/DH-273

Did some basic testing locally.  Made sure vscode launched, used gcc to build a simple hello world program.  More testing is probably warranted in staging before moving this to prod.


[Event Request] Codeunit 12 CreateGLEntriesForTotalAmounts - Add IsHandled to OnBeforeCreateGLEntriesForTotalAmounts

Hello!
We would like to control the way how entries for total amounts are created. Although we can change the invoice post buffer we can not prevent the insertion via PostCust, because a ledger entry is inserted and the therefore an entry for total amounts is also created.
We would favor an additonal IsHandled parameter in procedure OnBeforeCreateGLEntriesForTotalAmounts():
local procedure OnBeforeCreateGLEntriesForTotalAmounts(var InvoicePostBuffer: Record "Invoice Post. Buffer"; GenJournalLine: Record "Gen. Journal Line"; var GLAccNo: Code[20]; var IsHandled: Boolean)
Thank you and best regards,
Johannes

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Map IDs to Classes

is it possible to add a plugin that would remove the id attr from an element and map it to a class with an optional prefix and / or postfix?
For example
- mapIDsToClasses:
    prefix: 'svg-'
    postfix: ''

would map:
<path id="arrow" d="M50 514.26l-25 25 25 25z"/>

to:
<path class="svg-arrow" d="M50 514.26l-25 25 25 25z"/>

Additionally:
This:
<rect id="cool-rect" class="cool-things" x="13" fill="#FFFFFF" width="4" height="30"/>

would map to:
<rect class="cool-things svg-cool-rect" x="13" fill="#FFFFFF" width="4" height="30"/>

My reason is that Group and path names in Adobe Illustrator come out as IDs when you save as an SVG but if you insert the resulting SVG into an HTML doc more than once it will invalidate the document because it will have more than one element with the same ID
Thoughts?

Well, it's totally possilble. Couple of caveats though:

cleanupIDs will remove unused IDs. So, the plugin should run before it, or cleanupIDs needs to be disabled, if these IDs aren't being referenced. If they are, references should also be updated of course.
SVGO cannot parse CSS for now. So, replacing IDs there requires some additional managing.

May be it's better just to update cleanupIDs to work in a such manner through option.

It would for sure need to run before cleanupIDs but after it does run cleanupIDs would have no IDs to cleanup.
Re: CSS, I was thinking a little more brute force in that each element would only care about itself.
class="
{any pre existing value of class attribute}
{optional space if class attribute was not already empty}
{prefix}
{value of id attribute}
{postfix}
"

Then remove id attribute and that's it.  No need to parse CSS.  But if we can add elegance or intelligently extend another function that would be boss.  Adding it as a param to cleanupIDs would ensure it ran first!
Thoughts?

No doubts about class content. I was talking about selectors in possible <style> declarations that can use IDs.

Great point!  I had not thought of that.  It could just be a documented shortfall of that option.  Are there any other features you're considering that might need, or benefit from, CSS parsing?
This doesn't seem like the cost benefit is there with this one feature on its own.

Yeah, CSS parsing is desirable feature. At least for checking styles. It's important to know in some places whether there is fill or stroke property for example. There is already a method computedAttr but it checks only for (perhaps inherited) attributes for now.
Of course, there could be some optimizations.
Unfortunately, it requires some work which I have no time for. Parse CSS, construct AST, bind with DOM, etc…

If you remove IDs, how do you use a <use xlink:href="#arrow-right" /> type of reference?

@dangayle I don't think you could but the reason i want to strip ids is because i plan on using the same svg in the dom in several places and best practices say that your ids should all be unique. You would have to decide whether or not you would need to use references like that before stripping the ids.

Inlining may be an option, inlineStyles plugin PR: https://github.com/svg/svgo/pull/592
Prefix plugin PR: https://github.com/svg/svgo/pull/700

( Figma can also add the layer names as id's, but it does make sure that they are unique automatically. So if two items in Figma are named "Shape" they will get the ids "Shape" and "Shape_2". So in the case of figma there is less need for this. )

@TrySound - this request still seems valid and very useful. Can you discuss why it was closed?

@chrisjshull Mapping ids to classes is not safe as there can be references to ids in links. prefixIds plugin should do the trick, maybe with some template prefix. Depends on exact usage.

if I use the same SVG multiple times, e.g. by inserting the SVG via JS via a template, how will prefixIds help? Won't I end up with the same (now prefixed) ID multiple times on my page?
I'm also happy to have svgo throw an error if it sees references to ids in links (if I had a id-to-class setting enabled).
Can we please reopen this?

You can specify template in prefix and generate unique_id per usage.
{
  name: 'prefixIds',
  params: {
    prefix: "{{unique_id}}__"
  }
}

If you want a linter to fail on ids write custom plugin.
const plugin = {
  type: 'visitor',
  name: 'lint-ids',
  fn: () => {
    return {
      element: {
        enter: node => {
          if (node.attributes['xlink:href'] != null) {
            throw Error(`Found unexpected reference: "${node.attributes['xlink:href']}"`)
          }
        }
      }
    }
  }
}

The issue is out of svgo scope. But you can use SVGO to build more tools for your needs.

You can specify template in prefix and generate unique_id per usage.

Are you suggesting I bundle svgo into the JS I send to each end-user's browser just so that I can set a unique prefix each time I insert the same SVG into the DOM?

SVGO only inject template syntax. You can use this template with framework or template engine you use to build your app.

Oh, I see - you mean literally have {{unique_id}}__ and then in runtime JS swap out {{unique_id}} with a random identifier on each insert. That's a tad expensive as you can't clone nodes after the first DOM parse (first need to string manipulation), but I guess one could manage. Ty!


feat: onboarding welcome screen

The type of this PR is: Feature

This PR resolves CX-1089
Description

Add Onboarding welcome screen
Note: The navigation bar and status bar will be made translucent once the splash screen PR is merged in a separate PR

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

#squashongreen


Direct upload to nextion without esphome ?

Hi !
Thanks for your tutorial about the NsPanel
Were you able to do a direct upload of the tft file to the nexion display without using esphome ?
Thanks !

Which tft do you mean? This berry driver is focused on the stock firmware/tft and only works with the custom serial protocol of the stock firmware. So uploading TFT files in this berry driver would only be useful for updates of the stock firmware.


Dose Kong support variables in the uri ?

version 0.14.1

Do you mean capturing items from a path?
See https://docs.konghq.com/0.14.x/proxy/#capturing-groups
Note that this sort of question is better directed at Kong Nation.

@james-callahan
route path: /version/(?\d+)/users/(?\S+)
service path: /users/{user}?version={version}
How do I get the route uri variable in the service?


Provide option to configure smtp sender mail address

Describe your changes :
Currently, there's no inbuilt config parameter to set the smtp sender mail address. This could be worked around using the extraEnvs, but providing an option under the smtp config directly seemed helpful.
If the sender mail values is not provided, we get the following error during sign-up (when we expect a verification email to be sent):

Type of change :

[x] Improvement

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my own.
[ ] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[ ] All new and existing tests passed.

Reviewers

@akash-jain-10 Sure, I've updated the README.


[C++][Python] Add Opaque canonical extension type

Describe the enhancement requested
Part of #43453.
Component(s)
C++, Python

Issue resolved by pull request 43458
https://github.com/apache/arrow/pull/43458


Perhaps it's time to write your interpreter.

#!/usr/bin/ruby
eval 'm=Hash.new(p=0);'+ARGF.read.gsub(
        /([A-Za-z_][A-Za-z0-9_]*)|./,
        'pipi' => 'p+=1;',
        'pichu' => 'p-=1;',
        'pi' => 'm[p]+=1;',
        'ka' => 'm[p]-=1;',
        'pika' => '(',
        'chu' => ')while((m[p]&=255)!=0);',
        'pikachu' => 'putc m[p];',
        'pikapi' => 'm[p]=STDIN.getbyte if !STDIN.eof;')

I agree. I should get around to this, it's sat for too long.

I appreciate the assistance. I wanted to use python and ply as a learning tool. I have created a interpreter that does what I want for now.
Thanks for your help!


Sqlite write-ahead-log mode

This PR sets sqlite to use WAL mode, to allow reads concurrent with writes and generally better performance.
This PR also adds logic to run PRAGMA optimize; every 15 minutes. It apparently benefits greatly from running periodically, according to sqlite docs.

@ljedrz This is not the full fix for #1184. We need read-only handles in a follow-up PR, but this should improve DB performance.


on IOS ,  getCalories return []

Hello everyone, my authorization is successful on ios, and both step and distance can get data, but on the debug and release packages, getCalories  method return [],  has anyone encountered this problem ?

time period problem,solved

How did you solve it? I am also facing the same issue while using getCalories(), it always return me an empty array.


Patches for 23.0.x

It appears that the current build for 23.0.6 was done with go 1.19.9.
There are a number of CVE fixes in 1.19.10 (e.g. CVE-2023-29404. CVE-2023-29405, CVE-2023-29402).
Are there any plans to publish and other version for 23.0.x to address these issues?

Although I can't speak for the moby/moby project and Docker team that publishes the docker binaries that we use from https://download.docker.com/linux/static, I don't see how these vulnerabilities apply since they all only matter when building a go project and do not really apply to running go-built binaries.

CVE-2023-29404

The go command may execute arbitrary code at build time when using cgo. This may occur when running "go get" on a malicious module, or when running any other command which builds untrusted code. This is can by triggered by linker flags, specified via a "#cgo LDFLAGS" directive. The arguments for a number of flags which are non-optional are incorrectly considered optional, allowing disallowed flags to be smuggled through the LDFLAGS sanitization. This affects usage of both the gc and gccgo compilers.

CVE-2023-29405

The go command may execute arbitrary code at build time when using cgo. This may occur when running "go get" on a malicious module, or when running any other command which builds untrusted code. This is can by triggered by linker flags, specified via a "#cgo LDFLAGS" directive. Flags containing embedded spaces are mishandled, allowing disallowed flags to be smuggled through the LDFLAGS sanitization by including them in the argument of another flag. This only affects usage of the gccgo compiler.

CVE-2023-29402

The go command may generate unexpected code at build time when using cgo. This may result in unexpected behavior when running a go program which uses cgo. This may occur when running an untrusted module which contains directories with newline characters in their names. Modules which are retrieved using the go command, i.e. via "go get", are not affected (modules retrieved using GOPATH-mode, i.e. GO111MODULE=off, may be affected).

(Closing as 23.x is no longer supported here.)


Rails6 rc1 - deploy first stand alone without ActionText

@jamesjefferies Could we look at squashing this down to a single commit?


Please invite me to the community

Name
GreyRabbitty
Discord Username (if applicable)
grey_rabbit0679
Additional Context
To join to your Community, I am a Dev. I want to keep the best friendship with others.

Thanks. I will keep up the good work


[Proposal] Kubernetes target

Hi, It will be awesome if we can transform our Event to Kubernetes manifest and post it to API.
I think a bigger problem here is a templating, because we need to merge our event data with kubernetes manifest data. (I'm not sure if it's a nature for TriggerMash).
Links with similar implementations:

https://argoproj.github.io/argo-events/sensors/triggers/k8s-object-trigger/
https://tekton.dev/docs/triggers/triggertemplates/

Raised at least 2 more times by users wanting to trigger a Kubernetes Job.

I have a similar requirement. I have to create and execute a container everytime a particular event is received. I have tried a lot playing around different K8S APIs, but have been half-successful. Here is what I've tried:

Created a HTTPPollerSource --> listens to a webpage every 60 secs (lets use a random data generator as example)
Created a memory broker (for development)
Created a trigger (with no filters as of now)
Created a HTTPTarget with target as K8S API (POST) - here I've tried jobs, pods, deployments - everything work once when the HTTPTarget manifest is applied. They dont get triggered upon the next event. The YAML is like this:

`---
apiVersion: targets.triggermesh.io/v1alpha1
kind: HTTPTarget
metadata:
name: call-abi-pod
namespace: default
spec:
restartPolicy: Always
response:
eventType: CallPodResponseEvent
eventSource: kubernetes-api-response
skipVerify: true
endpoint: 'https://kubernetes.docker.internal:6443/apis/apps/v1/namespaces/default/deployments'
endpoint: 'https://kubernetes.docker.internal:6443/apis/batch/v1/namespaces/default/jobs'
endpoint: 'https://kubernetes.docker.internal:6443/api/v1/namespaces/default/pods'
method: 'POST'
headers:
Content-type: 'application/yaml'
Deploy as a Deployment
data: |

apiVersion: apps/v1
kind: Deployment
metadata:
name: sample-abi-job
spec:
replicas: 1
strategy:
type: RollingUpdate
rollingUpdate:
maxUnavailable: 1
maxSurge: 0
selector:
matchLabels:
app: abi
template:
metadata:
labels:
app: abi
spec:
volumes:
- name: tmp
hostPath:
path: /tmp/
type: Directory
containers:
- name: abi-demo
image: busybox
imagePullPolicy: IfNotPresent
volumeMounts:
- name: tmp
mountPath: /tmp/
readOnly: false
env:
- name: JOB_LOG_DIR
value: "/tmp/logs/"
command:
- /bin/sh
- -c
- mkdir -p ${JOB_LOG_DIR}; echo [date +"%Y-%m-%d-%H:%M:%S"]-Hello this is a sample log file from abi job. >> ${JOB_LOG_DIR}/fl_scenario.log; echo "Log file written successfully."; cat ${JOB_LOG_DIR}/fl_scenario.log;
---`


Update the UX for the merge status bar item

Per UX team review, moved to center and split into 2 items: 1 to manage the connection and 1 to manage merging
Will update to SvgDisconnet to offline.svg once it gets into itwinui-icons. Waiting on repo permissions

looks fine to me, i didnt pull to test, just need to localize a few items in test app and template.
could you add some screenshots of the changes you made?

before authorization:

clicking the offline icon executes login
after authorization:

proper status indicator will be in the "Changes" area and will be clickable if out-of-date


Escape characters in strings not handled correctly

This axel file:
(module Main)

(= example "This should be a quotation mark: \"")

(= main (print example))

Transpiles to the following Haskell code:
module Main where
import Axel
import qualified Prelude as GHCPrelude
import qualified Axel.Parse.AST as AST
example  = "This should be a quotation mark: ""
main  = (print example)

Which, for obvious reasons, does not compile.
Is this expected? I couldn't find anything specific about the way Axel is supposed to be treating escapes in the documentation, but the String literals section gives an example which includes an escape sequence.

This is rather embarrassing: Turns out, \t (and other escape sequences in general) are also being output inappropriately. In theory, I had golden tests which should've caught this issue. But, apparently, I only ever visually confirmed that the files looked like valid Haskell, instead of actually trying to run them in GHC. Among other things, this meant I couldn't easily tell when inappropriate whitespace like \t snuck in.
Action items for me:

[ ] Fix escape sequences
[ ] Add regression test based on the example above
[ ] Add verification step for Haskell golden test files (see #80).

Thank you so much for catching this!

Next is for me to finish #80 and #81, and then I'll push a new release. Thanks again!