[FEATURE REQUEST] Ensure support exists for Experimental PlayMode Options

Is your feature request related to a problem? Please describe.
There are several newer options in Unity for disabling reloading the app domain and/or reloading the scene when entering playmode. These greatly speed up iteration time in the editor. I'd like to be able to make sure that EntitasRedux supports working with these options, particularly as there are several static classes used for contexts and other areas.

Describe the solution you'd like
It should be possible for a developer to activate these options without errors or other issues being caused by EntitasRedux. This may require setting up an editor-only handler to flush or reset any static state after exiting playmode back to edit mode.

Merged to develop in 0f08a70e6f91955d5832f2d24a253f5eeae4d93f


Mods Template/Functions and Lists in GPO + more...

Good to have!

Added saving Black/White List in GPO (not yet active in WAU) https://github.com/Romanitho/Winget-AutoUpdate/discussions/256#discussioncomment-4710599

@Romanitho  couldn't make the -contain work with the array from GPO, switched to -match in:
if (($toUpdate -match $app.Id) -and $($app.Version) -ne "Unknown") and if (-not ($toSkip -match $app.Id) -and $($app.Version) -ne "Unknown"), ist that OK by you?

the thing with -match can make issue I think if different apps have same name parts, no ? like mozilla.firefox and mozilla.firefox.esr

You're absolutely right!
But I have tried and tried, but no go with -contains in the check of return Get-ItemProperty -Path "HKLM:\SOFTWARE\Policies\Romanitho\Winget-AutoUpdate\BlackList" to if (-not ($toSkip -contains $app.Id) -and $($app.Version) -ne "Unknown")
The dinosaur has bitten the dust!
Do you have the time?

ChatGPT solved my problem when I asked it and showed my code!

Forgot to document this in README.MD...

ADML/ADMX revision 4.7 in this PR should close Issue #265:

Another big one :)

Another big one :)

It started of as just bits in the Mods Template/Functions, but then evolved with https://github.com/Romanitho/Winget-AutoUpdate/discussions/256#discussioncomment-4710599...
...and corrections of v1.16.0 GPO bug found in #265
Maybe release WAU v1.16.1?

Quick question regarding GPO:
Should Application GPO Whitelist and Application GPO Blacklist mention that Get Black/White List from external Path (URL/UNC/GPO/Local) must be set to GPO ?

and I think there is a small typo:

Yes, the Interval should be at Logon.
Regarding GPO Whitelist/Blacklist it says in (but the more info, the better)

facultative is a unknown thing for me, if you have an idea of howto? then go for it!

yes, but not in the Application GPO Whitelist or Application GPO Blacklist. So if someone enable Application GPO Whitelist for instance, maybe it should be mentioned that Get Black/White List from external Path (URL/UNC/GPO/Local) needs to be set to "GPO" ?

by the way, I like this:

from this:

I wonder if this could not be settable from command line as well (with dedicated install arguments). And of course, if settings are changed they get applied on next scheduled task run.

Just remember that you can't set anything directly in registry under HKLM\SOFTWARE\Policies\Romanitho\Winget-AutoUpdate
It must be handled by editing the Policies.

anyway, your GPO with whitelist by GPO works like a charm. Currently testing on a customer environment 👍🏻


clarification to README

First, thanks a lot for this amazing package.
I noted that in the README.md there is an example that says:
In [5]: print(np.dot(x, x.T) / 2)  # fast!
[[  2.52727051e+03   8.15895557e+00  -8.53276134e-01 ...,  # ...

In [6]: print(np.dot(x, x.T) / 2)  # even faster!
[[  2.52727051e+03   8.15895557e+00  -8.53276134e-01 ...,  # ...

Given that both examples are exactly the same, maybe there is a mistake here in saying the other is "even faster".
Thanks again for JAX, I feel that this will be a gift that keeps giving. Bonus points for a funky and very well crafted logo!

Thanks for the kind words!
Actually the idea behind that readme line is that on the second call some JIT-compiled operations are cached, so the second call to them saves on compile time (and things like autotuning).
Does that make sense? Maybe we could add something to the readme to clarify what that line means.


Incorrect position when tray is on the left on Windows

Windows 10
menubar 5.2.3

I had the same issue, and am now using https://github.com/hacdias/electron-menubar which works fine.

Update:

electron-menubar has issues correctly handling multiple displays, which I couldn't get to fix. Instead, it was easier to fix menubar to correctly behave on Windows, while still behaving perfectly with multiple displays.
I'm now using this menubar fork: https://github.com/BaguetteEngineering/menubar, based off Sidney's commit: https://github.com/sidneys/menubar/commit/233bcb8e65a8009222059e78be90ef0982c9a52d.

Fixed in<EMAIL_ADDRESS>🚀


Double RSpec run on rails api-generated app

Closing until we make more frequent use of the API generator.


Toolchain docs don't exist (broken link)

In README.md, in the section Toolchain, there is a link to some documentation (goes to https://vberlier.github.io/beet/toolchain/) but that page doesn't exist.

Yeah it's not quite there yet but I still prepared the link so I don't forget to do it. I'm keeping the issue open until the docs are up 👍

The docs are now live at mcbeet.dev. Still a work-in-progress though.


Gap appearing between options and selected options list

A gap appears between the options and selected options list. Unsure as to why but the only code run on the select statement is $(selector).select2(); so I can only assume it should work.
See https://gyazo.com/e9f6c75f89b3eacb249e1a27b5038109

Without any more information, this is most likely a duplicate of https://github.com/select2/select2/issues/3970.


When using "duplicate" on a file, mode (+x) is not preserved

To reproduce, right-click any file with mode +x, duplicate it, and the mode (+x) is not preserved. I am expecting it to be preserved, see enclosed image.

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
[Description of the issue]
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expect to happen]
Actual behavior: [What actually happens]
Reproduces how often: [What percentage of the time does it reproduce?]
Versions
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Please reopen this on the atom/tree-view repository and completely fill out the issue template.  Thanks!


feat(api)!: add distinct error type

The commit adds an Error enum to the public API of the opml crate to
make it easier to reason about what went wrong during OPML
parsing/writing.

Thanks for merging this quickly and pushing a new version to crates :) Now I can finish my podcast manager off haha :)


Collect a list of known defects

Any bug searching technique lives and dies by its ability to find, well, bugs. To judge how well our approach is doing in this project we need a list of known defects. That is:

details / bug issue number
[optional] method to reproduce
impacted version(s) of Rust

From this we can start to build a table of Time to Discovery for the given issue.

CWE-680: Integer Overflow to Buffer Overflow
Details: https://groups.google.com/forum/#!topic/rustlang-security-announcements/CmSuTm-SaU0
Impacted version: Rust 1.26.0 stable to 1.29.0 stable


Take image virtual size into account when creating Volumes

This is a followup to https://github.com/harvester/dashboard/pull/1104
When creating new volumes on the Volume screen in Harvester, the default size is empty, i.e. it's not pre-filled with anything at all.  If the source is set to "VM image" we can now take the image virtual size and use that as the default size for the volume. Unlike when creating VMs (which always set the volume to a minimum of 10GiB regardless of virtual size, for consistency with earlier harvester versions), on this screen we just use the virtual size as-is.  If the user wants to make it bigger, they can.
Related issue: https://github.com/harvester/harvester/issues/4905

Wait, I've just discovered this isn't quite right -- it's now effectively impossible to manually edit the size once an image is chosen (I think because everything calls update()). I'll have to rework this somehow :-/

OK, that seems to have done the trick... If there's a better way to structure anything here, please LMK.

Sorry, not sure if I misunderstand this PR purpose,  we want to pre-fill the Size based on user selected image virtual size.
Do we need specific backend change or master-head is enough ?
It's not work as expected when I test locally.
https://github.com/user-attachments/assets/5d654b55-40cf-4697-bec3-b0b71b4ec09b

Sorry, not sure if I misunderstand this PR purpose, we want to pre-fill the Size based on user selected image virtual size or actual size.

Yep, it's meant to pre-fill the Size based on whichever is greater of the image virtual size or actual size.

Does this PR need specific backend change or master-head is enough ?

It should work fine provided your backend harvester cluster is v1.4 or master -- looking at the version in the video, it seems you're on v1.3.1, which doesn't support virtual size... But even in that case I would have expected it to at least fill the field with the physical size of the image -- const imageSize = Math.max(imageResource?.status?.size, imageResource?.status?.virtualSize) should pick up whichever is available, right? -- so I'm not sure what's going on here :-/

This change contains some more code changes, but you can make use of the already fetched images. Don't know why they are fetched because the current code does not make use of it. Maybe @torchiaf should have a final look on it if you want to apply this patch.
diff --git a/pkg/harvester/edit/harvesterhci.io.volume.vue b/pkg/harvester/edit/harvesterhci.io.volume.vue
--- a/pkg/harvester/edit/harvesterhci.io.volume.vue	(revision 3ee5fbdbd0b0d589ebbf7002ceab1ff488846b55)
+++ b/pkg/harvester/edit/harvesterhci.io.volume.vue	(date<PHONE_NUMBER>157)
@@ -56,6 +56,7 @@
     const hash = await allHash(_hash);

     this.snapshots = hash.snapshots;
+    this.images = hash.images;

     const defaultStorage = this.$store.getters[`harvester/all`](STORAGE_CLASS).find( O => O.isDefault);

@@ -77,6 +78,7 @@
       storage,
       imageId,
       snapshots: [],
+      images: [],
     };
   },

@@ -108,10 +110,8 @@
     },

     imageOption() {
-      const choices = this.$store.getters['harvester/all'](HCI.IMAGE);
-
       return sortBy(
-        choices
+        this.images
           .filter(obj => obj.isReady)
           .map((obj) => {
             return {
@@ -251,8 +251,7 @@
     },
     updateImage() {
       if (this.isVMImage && this.imageId) {
-        const images = this.$store.getters['harvester/all'](HCI.IMAGE);
-        const imageResource = images?.find(image => this.imageId === image.id);
+        const imageResource = this.images?.find(image => this.imageId === image.id);
         const imageSize = Math.max(imageResource?.status?.size, imageResource?.status?.virtualSize);

         if (imageSize) {

Sorry, not sure if I misunderstand this PR purpose, we want to pre-fill the Size based on user selected image virtual size

Test with master-head deployment. It's good. 👍
Just notice the size only accepted integer.... I turn to use formatSi to get more precise size number to decimal.
  this.storage = formatSi(imageSize, {
            increment: 1024, addSuffix: true, maxExponent: 3, minExponent: 3, suffix: 'i'
          });

But got webhook error 😓

It might be best to just stay with and integer value - I could be wrong, but I don't think we allow decimals anywhere in any size fields, it's all just whole GiB.

Thanks @votdev, I've applied that patch and it seems to work fine. I'm happy to wait for @torchiaf to review as well.

@mergifyio backport release-harvester-v1.4


AnsiMode support for GetArrayItem GetMapValue and ElementAt for Spark 3.1.1

Fix https://github.com/NVIDIA/spark-rapids/issues/2272 and https://github.com/NVIDIA/spark-rapids/issues/2276
This PR adds shim support for GetArrayItem, GetMapValue and ElementAt to match the CPU behavior on Spark 3.1.1.
This relies on https://github.com/rapidsai/cudf/pull/8209 and https://github.com/NVIDIA/spark-rapids/pull/2260.
More:
This adds an parameter all_null for ArrayGen in the data_gen part in integration_test.
This parameter is used to create null array instead of empty array.
Null array is used to create a corner case for GetArrayItem:
For a dataframe like:
+------------------------+
|col_1                   |
+------------------------+
|null                    |
|null                    |
+------------------------+

df.select(col("col_1")[2]).show() will return without exception:
+--------+
|col_1[2]|
+--------+
|    null|
|    null|
+--------+

build

build


Redis url is not honored even when specified in the config

The python module does not honor the redis URL mentioned in the config and always uses localhost (the default). Investigate and fix this.

Hi Yatharth, I'd like to work on this issue, reproduce the bug and fix it.

Hi @Hsankesara , sure. To reproduce it, set the Redis URL to something different in the config file. It will still take it up as localhost no matter what is configured. It could be using one of the default values for parameters in init (possibly in the Connection and Publisher classes).

Thanks @yatharthranjan, I changed the host in redis_publisher in config.yaml from localhost  to xyz but I got connection error and it didn't use localhost for connection.

Yes, that is right, this happens 2 times at startup, the first time it takes the correct URL from the config and hence you see the error, but if you get past the error, this will happen a second time, and this time it will use localhost. Can you try that?
You can add a new host binding on your system by editing /etc/hosts file.


[Constraint system] Sink initialization logic into SolutionApplicationTarget

Sink more of the logic for handling type checking of initializations into SolutionApplicationTarget:

Handle constraint generation on SolutionApplicationTarget
Handle the property-wrapper transformations needed for initialization on SolutionApplicationTarget itself

@swift-ci please smoke test


Will release model based on Llama3?

As the title.

Hi, we haven't yet, but I will update this thread if we do


MQTT v3.1 support

this is a strict version of MQTT 3.1. The specification requires less restrictions on utf-8.


[CS2103-T11-1] Incident Management System

@Tirameshu @Yoshi275 @atharvjoshi @hellopanda128

In your fillCommandSequenceDiagramWithoutParams.png, I think that specifying the command arguments within the command call is unnecessary.

Your diagram font sizes are quite small, perhaps try to make them bigger?

Perhaps consider making your explanations slightly more concise.

Within SearchIncidentsSequenceDiagram.png:

The :SearchIncidentsCommandParser calls a method within Model but does not specify that method's name - it only specifies the argument "Alex".
Your getFilteredIncidentList is missing the brackets ()
Maybe you'd like to show the self invocation activation bars?

Within your EditCommandSequence.png:

throws Exception is shown as a self-call. Should it be a return instead?
The creation of EditCommand does not have a return arrow when your other diagrams do for object creation
Your execute(edit) arrow should point to the :LogicManager activation bar


feat: changing builder configs from factor to boost

Boost is a percentage multiplier and should accommodate for the same requirements as factor but also gives the validator more precise control on how much they are willing to increase privileged relays score.
One additional feature of this is that validators could also create a new group and reduce the score of a specific relay. At the moment we don't see this as an issue, but would love to get your opinion on this.

Thanks for the PR @MrKoberman. We took a look through it and request that you revert to using the name factor and making it a percentage. This will reduce the amount of changes required in the PR.

@MrKoberman we're looking at releasing a beta in the next few days, at which point we'd want to freeze the features.  As such, if you could make the changes as mentioned above by @Bez625 (leave the name as factor, make it a percentage, stick with integer maths) ASAP it will allow us to include this.  Once the feature is in a release it will be much harder for us to change.

Thank you for the review, @mcdee, @Bez625. I addressed the comments on the PR with the latest commit.


Tracer compile issue: irq_ack_o

Looks like this port is removed recently, but still connected to the tracer.
/usr/local/google/home/taliu/ibex_dbg/ibex/rtl/ibex_core.sv, 645
Identifier 'irq_ack_o' has not been declared yet. If this error is not
expected, please check if you have set `default_nettype to none.
https://github.com/lowRISC/ibex/blob/master/rtl/ibex_core.sv#L645

Hi @taoliug ,
thanks for reporting this issue. Also the port list in ibex_core_tracing.sv needs to be fixed.
I will prepare a fix for that.
Best regards,
Pirmin

I am also adding @towoe as he might have some input on this.
@taoliug , I removed the port from the tracer and switched to the new interrupt interface in several remaining files. You can have a look here: https://github.com/vogelpi/ibex/tree/fix-interrupt-interface
To me, it seems that the irq_ack_o signal was only used in RVFI and the tracer for UVM purposes. But I am not sure if you actually had a test running for this. Nevertheless, I did not dare to touch the UVM files. It seems that there is some infrastructure for testing this interrupt interface. The following files are affected:

dv/uvm/common/irq_agent/irq_if.sv
dv/uvm/common/irq_agent/irq_master_driver.sv
dv/uvm/common/irq_agent/irq_monitor.sv
dv/uvm/tb/core_ibex_tb_top.sv

Could you have a look at these and replace/adapt accordingly? In general, the interrupt interface of the core is now much simpler. The core has only level-sensitive interrupt inputs and there is no acknowledge signal.
Best regards,
Pirmin

Yes, I have a PR locally to fix it. I think it's OK to push the design changes in, and I will submit the DV changes short after.

Okay thanks for your feedback @taoliug . This sounds like a plan.

Alright, PR #188 is merged. Please let me know when you want to me to review your PR or once it is merged.

TB update is checked in, closing this bug.


test start script

we might need to add the start script here instead of in https://github.com/OpenSenseAction/OPENSENSE_sandbox/pull/33
This PR tries to find that out... (since I cannot find the info or just do not understand detailed enough how it works...)

a start script does not work for our task (init of submodules from content repo and installation to R and Python of these submodules) because the start script is run before nbgitpuller pull the content repo into already running binder instance.


Feature Request: Allow default tokens to be returned, for optional tokens

Hi,
Consider these statements ...
let x = 1;
let const x = 1;

fn main() {}
fn main() -> void {}

We often have such instances where the default token is assumed, if it is not given by the user.
Thus, it would be easier for us, if the default tokens were returned if optional tokens don't exist in our rules.
This would be helpful, as currently to represent the return type of the functions, I would need to use an Option<>, and modify the AST nodes after parsing, to set the function's return type as void.

// in pest file
function = { "fn" ~ id ~ "(" ~ (args)? ~ ")" ~ ("->" ~ type)? ~ "{" ~ function_item* ~ "}" }

// in rust file
#[derive(Debug, Clone, FromPest)]
#[pest_ast(rule(Rule::function))]
pub struct Function {
    pub id: Id,
    pub args: Args,
    pub r#type: Option<Type>, // <<< Issue ... created by optional rule ("->" ~ type)? above
    pub items: Vec<FunctionItem>,
}

This is rather tedious work, and complicates our compiler's AST representation.
In OCaml's Menhir parser generator, if a rule doesn't match anything, we are allowed to return a default node.
Such a feature would also be extremely helpful for pest.
type:
  | (* empty *) { Ast.Type_Void } (* <<< If nothing exists for return type token, then return a Void type  *)
  | ARROW INT { Ast.Type_Int }
  | ARROW id = ID; { Ast.Type_Derived id }
  ;

Thanks! I'm glad to help. :smiley:
Developing this feature may obviously take some time, so for users like me who will be waiting, I would recommend not to use such optional grammar right now, and instead chose to only use the base grammar.
i.e
// Don't support optional grammar
let x = 1;

// Instead, only support the base grammar
let const x = 1;

This is for two reasons:

Users can develop their base grammar well, and simplify their compiler.
When the default argument feature gets implemented, the users can immediately use it by using only a single attribute. This is important to state, because If they chose to use the optional grammar right now, then their compiler code will become little complex, and in future, they'll have to refactor lot of code to remove the complexity and use this new implemented feature.


deCODE method to detect CHIP

Script to perform QC & find (individuals with) singleton mutations (with low MAF) in TOB.

@lgruen @illusional @katiedelange Hi all, thank you so much for reviewing the code! I have revised the scripts accordingly, and the scripts have beed tested.

sub.py is written to help beginners (like me) creating and executing jobs using Hail batch (Not being used in this analysis)
sub_dataproc.py is for dataproc jobs
deCODE_by_CHR.py is the main script. I have added more annotations and description of this method can be found in the README.md file.

Sorry for the confusions in the last commit. Hopefully this version is neater and easier for reviewing!

Thanks, @uqzqiao! Any chance you could move code that isn't used in this analysis to separate PRs? It's always best to keep each PR as small and self-contained as possible. Then you'll get much more focussed (and quicker) reviews.

@lgruen Hi Leo! I believed most of the comments should have been resolved. Could you please review the updated script and check whether it can be merged? Thank you!


tests: storage: remove ifdef from ztest_test_suite

Having #ifdefs inside 'ztest_test_suite' makes sanitycheck fail.
Move the #ifdef's inside the test function itself instead to
avoid the failure.
Fixes #25057
Signed-off-by: Håkon Øye Amundsen<EMAIL_ADDRESS>

did not see this until after I submitted #25070


Add tests for torch=2.2.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (28f81e8) 100.00% compared to head (32b1e04) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #464   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           58        58
  Lines         1579      1579
  Branches       193       193
=========================================
  Hits          1579      1579

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


whare Is www.virtapay.com web site i try open site so redirect to virtacoin so why ?

whare Is www.virtapay.com web site i try open site so redirect to virtacoin so why ?
How To Open www.virtapay.com website ?

URI: virtacoin:1B8MKqoF3MKGjafbeWi3bvDkuc6CMUnPzB
Address: 1B8MKqoF3MKGjURI: virtacoin:1B8MKqoF3MKGjafbeWi3bvDkuc6CMUnPzB
Address: 1B8MKqoF3MKGjafbeWi3bvDkuc6CMUnPzB Here's my information, how do I convert into Bitcoins, and how do I cash outafbeWi3bvDkuc6CMUnPzB Here's my information, how do I convert into Bitcoins, and how do I cash out

https://github.com/feccruz/tripping-tribble.git


Some form component not styled

For select tag like :
<select>
      <option>1</option>
      <option>2</option>
      <option>3</option>
      <option>4</option>
      <option>5</option>
    </select>

Or textarea is not styled ?

Select are not styled as they are notoriously hard to style. We are aware and thinking about possibilities. See #854.
Textareas are styled and can be found on the components page.
For future reference: Please use the issue search before opening a new issue.


Check for convergence LogReg

class LogReg(NoiseAwareModel) GD method needs convergence criteria to guarantee noise-aware logistic converges to near optimal.

Closed in v0.5.0 (also all in TF now, so easy to add more if needed!)


WIP: feat/779: Refactor Tx in shared & sdk

Related to #854
Refactor Tx and Batch Tx into a single type

Closing, will open new PR with updates


README: cleanup and merge from master

Thanks. I've done a real merge from the master branch and applied the whitespace changes with modified commit message in d98d43cf38645f70f4aaef94e5e4dad5a762d412.


consume parameters dynamically in AQA Test Pipeline

This PR passes the parameters from AQA Test Pileine to its child jobs dynamically.
It means we will not need to add specific code for setting/passing new parameters
to child jobs moving forward.
This will also allow AQA Test Pileine to trigger any kind of test build, including Grinder.
A powerful use case could be to run specific test(s)/BUILD_LIST using specific releases
(i.e., TOP_LEVEL_SDK_URL) on all platforms in Grinder.
resolves: https://github.com/adoptium/aqa-tests/issues/5049
Signed-off-by: Lan Xia<EMAIL_ADDRESS>

link
link
link => tests are executed as expected. The failure is not related to this PR.

@sophia-guo could you please ensure this change works in your environment?

@llxia Fee free to merge once you've checked it works in your env.

What's the best test case?

@sophia-guo This is your test build config issue. Please ensure LIGHT_WEIGHT_CHECKOUT is set to false and regen test build if you want to use my repo and branch.

Couple of issues to test it in temurin-eclipse. The main issue is related LIGHT_WEIGHT_CHECKOUT, but also related with the rename openjdk_tests to aqa-tests. However the test should be good as long as child builds can be triggered with correct params ( no need to be succeed.) That is saying it works in temurin-eclipse.


Adjust Series.mode to match pandas Series.mode

Currently, Series.mode reserves the name of Series in the result, whereas pandas Series.mode doesn't:
>>> kser1
x    1
y    2
Name: z, dtype: int64
>>> kser1.mode()
0    1
1    2
Name: z, dtype: int64. # Reserve name
>>> pser1 = kser1.to_pandas()
>>> pser1.mode()
0    1
1    2
dtype: int64. # Not reserve name

In addition, unit tests are added.

Codecov Report

Merging #1995 (9180849) into master (ae5c8d8) will decrease coverage by 3.57%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1995      +/-   ##
==========================================
- Coverage   94.52%   90.94%   -3.58%
==========================================
  Files          50       50
  Lines       10952    10848     -104
==========================================
- Hits        10352     9866     -486
- Misses        600      982     +382

Impacted Files
Coverage Δ

databricks/koalas/series.py
95.56% <100.00%> (-1.19%)
:arrow_down:

...bricks/koalas/tests/plot/test_frame_plot_plotly.py
26.43% <0.00%> (-73.57%)
:arrow_down:

databricks/koalas/plot/plotly.py
26.31% <0.00%> (-68.43%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
25.66% <0.00%> (-66.65%)
:arrow_down:

...ricks/koalas/tests/plot/test_series_plot_plotly.py
37.73% <0.00%> (-58.88%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
47.82% <0.00%> (-52.18%)
:arrow_down:

databricks/koalas/__init__.py
68.75% <0.00%> (-21.88%)
:arrow_down:

databricks/conftest.py
89.83% <0.00%> (-10.17%)
:arrow_down:

databricks/koalas/spark/functions.py
88.88% <0.00%> (-7.41%)
:arrow_down:

databricks/koalas/accessors.py
86.43% <0.00%> (-7.04%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae5c8d8...9180849. Read the comment docs.

Codecov Report

Merging #1995 (9180849) into master (ae5c8d8) will decrease coverage by 3.57%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1995      +/-   ##
==========================================
- Coverage   94.52%   90.94%   -3.58%
==========================================
  Files          50       50
  Lines       10952    10848     -104
==========================================
- Hits        10352     9866     -486
- Misses        600      982     +382

Impacted Files
Coverage Δ

databricks/koalas/series.py
95.56% <100.00%> (-1.19%)
:arrow_down:

...bricks/koalas/tests/plot/test_frame_plot_plotly.py
26.43% <0.00%> (-73.57%)
:arrow_down:

databricks/koalas/plot/plotly.py
26.31% <0.00%> (-68.43%)
:arrow_down:

databricks/koalas/usage_logging/__init__.py
25.66% <0.00%> (-66.65%)
:arrow_down:

...ricks/koalas/tests/plot/test_series_plot_plotly.py
37.73% <0.00%> (-58.88%)
:arrow_down:

databricks/koalas/usage_logging/usage_logger.py
47.82% <0.00%> (-52.18%)
:arrow_down:

databricks/koalas/__init__.py
68.75% <0.00%> (-21.88%)
:arrow_down:

databricks/conftest.py
89.83% <0.00%> (-10.17%)
:arrow_down:

databricks/koalas/spark/functions.py
88.88% <0.00%> (-7.41%)
:arrow_down:

databricks/koalas/accessors.py
86.43% <0.00%> (-7.04%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae5c8d8...9180849. Read the comment docs.

Thanks! merging.

Thanks! merging.


Avoid sync fs.realpathSync calls in reducers

While looking into #167, I noticed
folders.forEach((folder) => {
    musicFolders.push(fs.realpathSync(folder));
});

I think it would be better to avoid doing it that way.

It will never exceed more than 100 elements (usually, it's just one), it's kind of an overkill.

@KeitIG shouldn't folders we get from app.config.get('musicFolders') already be resolved?

Good point.


fix SQLite database bugs

Before I was getting this error: ValueError: invalid literal for int() with base 10: ''
I realized with the help of ChatGPT, that I needed to clean up my data so I added this block of code that converted any commas into integers:


Create utb.txt

I have added the student domain of Polhemskolan in Sweden.
A link to a IT/Technology-related education (available only in swedish): https://www.lund.se/polhemskolan/utbildningar/teknikprogrammet/.
Official IT noticeboard:
https://iktsamordningenlund.wordpress.com/, on which utb.lund.se is given as the official email adress of staff and students. This page is linked to from https://www.lund.se/Skolportal/.

@Dod12 Could you please clarify how old the students of the school are? If we are talking about professional versions of JetBrains tools, educational license for them is for high and higher schools students, i.e. those who are over 13 of age. If the school students are younger, we are glad to offer them Community versions of the tools, which are free to everybody, such as PyCharm Community Edition, etc.

@philipto As can be see on https://www.lund.se/en/polhemskolan/om-skolan/, Polhemskolan is an upper secondary school. In Sweden, this means admitting students aged 16 and upwards.

@Dod12 Thank you very much for the clarification! Pull request merged.


slice plugin, intercept handler that uses cache_range_request

Redid the squash.  Deleting and repushing the branch closed the previous PR.

[approve ci autest]

[approve ci]

[approve ci]

We've had this on one production machine for almost a month and a half, currently its at ~450cpu hours.


Setup Release Pipeline with Ring-0(Deploy AKS+ACR) and Ring-1(Purge AKS+ACR) stages

Done with AKS creation Ring


[Django Upgrade] [ENG-3947] Update markdown extension

Purpose
Old versions of markdowns python library no longer work with Django so we have to upgrade Markdown to be compatible and update a few functions.Additionally Our forked markdown extension library https://github.com/CenterForOpenScience/mdx_del_ins/ is no longer compatible with markdown, so it had to have a minor fork. https://github.com/CenterForOpenScience/mdx_del_ins/pull/1
https://www.notion.so/cos/6188c43512ee482586da59bc5fdacf38?v=bb051c7d4d7346d69d9fcbbc979dd883&p=02a1b6368b0b47fbbab07a01d88135d9&pm=s
Error:
https://gist.github.com/Johnetordoff/84c900be9f2427db40ac57d18386cf6f
Changes

updates markdown to use new format for passing arguments
forks mdx_del_ins to work with new version of markdown.

QA Notes
Please make verification statements inspired by your code and what your code touches.

Verify
Verify

What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation

Side Effects

Ticket

@cslzchen After replicating this issue, it seems that the markdown problem was caused by a DRF incompatibility Error I'm looking to see if there's a version of DRF that works with both Django 3.2 and our current markdown, but it doesn't look like there's a version that satisfies both, so changing Markdown seems easiest.

@cslzchen After replicating this issue, it seems that the markdown problem was caused by a DRF incompatibility Error I'm looking to see if there's a version of DRF that works with both Django 3.2 and our current markdown, but it doesn't look like there's a version that satisfies both, so changing Markdown seems easiest.

Ah, I see. I remember this AttributeError: 'OrderedDict' object has no attribute 'register' error on one of my reference PRs too. Let me take another look at this one.


Safari <8 support ?

I have read the docs and tried the demos at http://google.github.io/lovefield/
and indeed LoveField does NOT yet support Safari
Is there any chance of officially supporting Safari  via a shim such as : IndexedDB Polyfill over WebSql or FaceBook's IndexedDB polyfil
Safari 7.1 theoretically supports IndexedDB according to CanIUse.com
Apple has officially stated at WWDC 2014 that Safari 8 and iOS 8 will have full support for IndexedDB.
If there won't be any official support then it would be timely for us to provide a patch with Safari support.

WebSQL based back store is implemented, since we saw no sign that Apple will fix their IndexedDB bug any time soon. Please consider this is a gap filling solution and we'll remove this backstore as soon as Apple fixes their bugs.
Change 655024eb281ac4793ff78bd3632c6a764f280a41 contains the finalized code.

Tested broken on iOS 8 Safari and OSX 10.10 Safari, investigating.

Fixed 2e6ba5f70c1d8754d45fa2d5d8b1620919a87c08


Update dependency to explicitly support version 7

While creating a patch for #980, I have found out the currently supported
elasticsearch version by elasticsearch-model is unnecessarily wide. ( > 1 )
Also, the previous dependency of > 1 and the nonexistence of version-parameterized test
means that the CI is not running against versions under 7.x. for elasticsearch-model.
I doubt the current code on master still works for old versions,
and I would like to avoid writing code to support compatibility on old versions on master branch.
To solve this issue, I have updated the dependency based on Elasticsearch gems' version policy.
This improves gem consistency and maintenance efficiency.
c.f.
https://github.com/elastic/elasticsearch-rails/tree/756a4dae1c51331a54bab8f00b0fcb88b4a480ad/elasticsearch-model#compatibility
#875

Thank you ❤


DropdownButtonFormField popupMenu invalid borderRadius

Steps to reproduce

In MaterialApp specify

      popupMenuTheme: PopupMenuThemeData(
        shape: RoundedRectangleBorder(
          borderRadius: BorderRadius.circular(12),
        ),
      ),

create DropdownButtonFormField  with borderRadius: BorderRadius.zero

Expected results
I expected popup get its borderRadius from theme (12).
It would be logical - all anchors (MenuAnchor, PopupMenuButton, etc) use borderRadius from popupMenuTheme.
But dropdown menu is different -_-
It seems like this menu is a lot of M2 menu - background, elevation, border...
Actual results
Popup will be with radius 0 instead of 12
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
        popupMenuTheme: PopupMenuThemeData(
          shape: RoundedRectangleBorder(
            borderRadius: BorderRadius.circular(12),
          ),
        ),
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
        title: Text(widget.title),
      ),
      body: Center(
        child: SizedBox(
          width: 100,
          child: DropdownButtonFormField(
            borderRadius: BorderRadius.zero,
            value: 1,
            items: const [
              DropdownMenuItem(value: 1, child: Text('1')),
              DropdownMenuItem(value: 2, child: Text('2')),
            ],
            onChanged: (_) {},
          ),
        ),
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]
DropDown:

Menu from showMenu:

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.16.9, on macOS 14.3.1 23D60 darwin-arm64, locale en-RU)
    • Flutter version 3.16.9 on channel stable at /opt/homebrew/Caskroom/flutter/3.10.4/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 41456452f2 (3 weeks ago), 2024-01-25 10:06:23 -0800
    • Engine revision f40e976bed
    • Dart version 3.2.6
    • DevTools version 2.28.5

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/geara0/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Users/geara0/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.1)
    • IntelliJ at /Users/geara0/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.85.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.80.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 14.3.1 23D60 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 121.0.6167.160
    ! Error: Browsing on the local area network for iPhone HOME. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
    ! Error: iPhone mrodeon has recently restarted. Xcode will continue when iPhone mrodeon is unlocked. (code -14)

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Hello @Geara0.
Not sure I fully understood your issue, I see you are using a DropdownButtonFormField and not a PopupMenuButton.

I expected popup get its borderRadius from theme (12)

Trying to get this if in docs, can you please point me to this? If not, will this be a request for a change and not an actual issue?
Kindly help with more information on this.

Thanks for your response @Geara0
This might be similar/related to https://github.com/flutter/flutter/issues/25151.
Can you also check out dropdownMenuTheme in your case?

@dam-ease
dropDownMenuTheme doesn't override any properties of menu either
        dropdownMenuTheme: DropdownMenuThemeData(
          menuStyle: MenuStyle(
            shape: MaterialStatePropertyAll(
              RoundedRectangleBorder(borderRadius: BorderRadius.circular(100)),
            ),
            elevation: const MaterialStatePropertyAll(0),
            shadowColor: const MaterialStatePropertyAll(Colors.red),
          ),
        ),

Nothing changed:

(but it's related to https://github.com/flutter/flutter/issues/25151)
My take is: menuStyle property shouldn't exist at all in dropDownMenuTheme. All properties should be derived from popupMenuTheme as written in M3 docs

CC @QuncCccccc


Clicking in text while adding dynamic tags clears out text

[x] Feature (could be bug too, but not sure)
[x] Related issues checked
[x] Latest version: (used: 4.0.6)
[x] Demo (see below)

Steps to reproduce (using: https://jsbin.com/hukeravete/edit?html,js,output)

Start typing next to "DemoText1" to start creation of new dynamic tag
Type "Demo Text2" (don't enter nor select the entry)
Click between "Demo" & "Text" to attempt to remove the space
Field will be cleared rather than remain in edit mode to be able to remove the space

Remarks:

This behavior is expected when clicking outside the textarea, not when clicking inside the text.
Workaround is to only use the arrow keys to get to the space. (but our users aren't a big fan of that)

Cheers,
Kevin

Confirm!

This appears to be occurring because the click within the search box is propagating back to the selection area, which is causing the dropdown to be closed and the search box to be cleared as a result.

The new version 4.7-rc0 does still have this bug.

same experience with 4.0.7. Any chance to be fixed in the nearly future? thanks a lot

same issue here with 4.0.7

This appears to be occurring because the click within the search box is propagating back to the selection area, which is causing the dropdown to be closed and the search box to be cleared as a result.

@kevin-brown
I looked the code and confirm this. Before i do a PR, what should be the correct behavior?

Should not close the dropdown at all
Should close the dropdown but not clear the text

I think the former is the correct.
Also should the dropdown close on click even if not searching?

@blikblum I would prefer the first one

I would prefer the first one

Done at #5551


Fix ping error message by installing ping

I received the following error when creating the docker container, and it seems ping was not included in the install. This pr adds ping.
/unbound.sh: line 35: ping: command not found

Thank you.


Create Monitoring Qual LME Data

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context (wireframes, business rules, etc.)?
[x] Is this traceable to a feature, epic, or PI?

As an ECMPS user, I want the ability to create new Monitoring Qual LME Data, so that I can add new data
Acceptance Criteria:
Given the user has selected Qualifications from the Sections dropdown
When the user chooses to add a new Qualification for LME (Create Qual LME)
Then the system displays the create modal
and the user can add new LME Qualifications data
Qualification Data Year: drop-down (Starting 2000 to ending in current year+ 2 years)
Operating Hours: Text
SO2 Tons: Text
NOx Tons: Text
Given the user has added LME Qualifications data
When the user chooses to save and close
Then the data is saved
And the modal closes
And the user is returned to the landing page for Qualifications data
Warning message to pop-up when a user updates data and closes the modal without saving the updates.
Does this Story require 508 Testing?

[x] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
Refer to page 129 from https://ecmps.camdsupport.com/documents/ECMPS Monitoring Plan Reporting Instructions 2021 Q2.pdf
Testing
Test Case: TC502
Tester: @mosesdeeCVP
Definition of Done

[x] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[x] Has the code been unit tested and peer reviewed?
[x] Have the functional tests been executed?
[x] Have all defects been reviewed and dispositioned, resolved, or deferred?
[x] Has the user story been accepted by the Product Owner?
[x] Is the user story ready to be deployed to the test/staging environments?

Test Passed


[Release-1.22] Race condition in the cloud provider

Backport of https://github.com/k3s-io/k3s/issues/4217

Confirmed with the same steps as https://github.com/k3s-io/k3s/issues/4217#issuecomment-956511024 using v1.22.3-rc1+k3s1


[RIPD-772] Validator key manifests (take 2)

Fix some things
Support ephemeral validator keys in UniqueNodeList
Add new ManifestCache
Trade validator key manifests via peer gossip

This pull request supersedes https://github.com/ripple/rippled/pull/978.
Reviewers: @scottschurr @ximinez

There are some issues brought up in other comments, but I don't have anything else to add, so I'll give a tentative :+1: and follow any additional commits before final sign off.

@josh-ripple: If you're punting on VersionEncoding, then I think that's the last of my concerns.  I think it's good to go assuming that @JoelKatz and @vinniefalco are happy with the Don't verify signatures under mutex lock fix.  So I'll give you a tentative...
:+1:

This code has to go back to the drawing board at least somewhat, to change the way it queues signature checks. And it should use the HashRouter to squelch pointless forwards.

Travis failure on 94861ee appears legit. The changes look good so far, but the build fails in MSVC, too.
1>..\..\src\ripple\overlay\tests\manifest_test.cpp(57): error C2885: 'malformed': not a valid using-declaration at non-class scope
1>..\..\src\ripple\overlay\tests\manifest_test.cpp(58): error C2885: 'untrusted': not a valid using-declaration at non-class scope
1>..\..\src\ripple\overlay\tests\manifest_test.cpp(59): error C2885: 'stale': not a valid using-declaration at non-class scope
1>..\..\src\ripple\overlay\tests\manifest_test.cpp(60): error C2885: 'invalid': not a valid using-declaration at non-class scope

Ping!

The commits added above are the result of rebasing over develop (nixing the addition of for_each to Overlay in favor of the one that's now there) and adding three new commits to fix two breakages in the test code and add a new test case.

@josh-ripple Is it time to give this pull request another review?  Or are you still working on it?

The four new commits above are ready.  I'm still working on suppressing duplicate manifest deliveries.

So you'll be adding more commits before it's ready for a final review?

Yes.

Closing this until its ready for review.


Protocol existentials do not trigger warnings if they will never be executed

Description
Early returns do not trigger warnings for protocol existentials, see example below
Reproduction
protocol SomeProtocol {
    func doTheThing()
}

func output(someProtocol: SomeProtocol) -> String {
    return "test"
    someProtocol.doTheThing() // this should be a warning
}

Expected behavior
early return should cause a compiler warning on the code that will never be executed
Environment
$ swift-driver version: <IP_ADDRESS> Apple Swift version 5.10 (swiftlang-<IP_ADDRESS> clang-15<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
Additional information
using a generic brings the warning back, e.g.
func output(someProtocol: some SomeProtocol) -> String {
    return "test"
    someProtocol.doTheThing() // this shows a warning
}

looked into this a bit out of curiosity. it seems to me likely that this behavior is due to hitting this branch in the SILGen code. it appears that, by default, diagnosing 'implicit' expressions (i.e. those that are not explicitly-written in source code) is suppressed, but there are a handful of carve-outs for things that should be exempted from this rule (e.g. optional chaining). in the reproduction, the relevant portion of the AST is something like:
(open_existential_expr implicit type='()' location=/app/example.swift:12:18 range=[/app/example.swift:12:5 - line:12:29]
  (opaque_value_expr implicit type='any SomeProtocol' location=/app/example.swift:12:5 range=[/app/example.swift:12:5 - line:12:5] @ 0x5a20baa22810)
  (declref_expr type='any SomeProtocol' location=/app/example.swift:12:5 range=[/app/example.swift:12:5 - line:12:5] decl=output.(file).output(someProtocol:maybeSP:someClass:).someProtocol@/app/example.swift:9:13 function_ref=unapplied)
  (call_expr type='()' location=/app/example.swift:12:18 range=[/app/example.swift:12:5 - line:12:29] nothrow isolationCrossing=none
    (dot_syntax_call_expr type='() -> ()' location=/app/example.swift:12:18 range=[/app/example.swift:12:5 - line:12:18] nothrow isolationCrossing=none
      (declref_expr type='(any SomeProtocol) -> () -> ()' location=/app/example.swift:12:18 range=[/app/example.swift:12:18 - line:12:18] decl=output.(file).SomeProtocol.doTheThing()@/app/example.swift:2:10 [with (substitution_map generic_signature=<Self where Self : SomeProtocol> (substitution Self -> @opened("7A730076-1388-11EF-ABE0-81AF1B259855", any SomeProtocol) Self))] function_ref=single)
      (argument_list implicit
        (argument
          (opaque_value_expr implicit type='any SomeProtocol' location=/app/example.swift:12:5 range=[/app/example.swift:12:5 - line:12:5] @ 0x5a20baa22810))))
    (argument_list))))))

so i'd assume adding some special handling for that particular structure (i.e. OpenExistentialExpr), as is done for the optional chaining case, would likely be one way to address the issue. or perhaps there's a way to generalize what the special cases have in common, e.g. a top-level implicit expression which internally contains a non-implicit expression that should be diagnosed.


The UI is not changeable

This would me helpful, if we can change the UI's of the replies and it will look better if you can change the look of cancel button.

Hi @Habib2959 ,
thanks for using this project. Here are the ways you can alter the cancel button:

Cancel link does not have a dedicated class, but you could use a regular CSS selector, for example like this.

.reply-title a {
    color: red;
}

To change text on the link/button (the one with 'Cancel X' text on demo), pass an object to translationOverrides prop of the component. The object's cancelLinkLabel property can be set to the text you need.

If you want to actually make it look like a button, you could also use CSS. Take a look at this example on stackoverflow.

Hope that helps. Let me know if you need any further help.
I'll close this issue in a few days.


SystemParamBuilder - Allow deriving a SystemParamBuilder struct when deriving SystemParam.

Objective
Allow SystemParamBuilder implementations for custom system parameters created using #[derive(SystemParam)].
Solution
Extend the derive macro to accept a #[system_param(builder)] attribute.  When present, emit a builder type with a field corresponding to each field of the param.
Example
#[derive(SystemParam)]
#[system_param(builder)]
struct CustomParam<'w, 's> {
    query: Query<'w, 's, ()>,
    local: Local<'s, usize>,
}

let system = (CustomParamBuilder {
    local: LocalBuilder(100),
    query: QueryParamBuilder::new(|builder| {
        builder.with::<A>();
    }),
},)
    .build_state(&mut world)
    .build_system(|param: CustomParam| *param.local + param.query.iter().count());

Looks reasonable, but needs to be documented in a user facing way :) Probably in the SystemParam and system param builder docs?

I added docs to the SystemParam trait near the rest of the #[derive(SystemParam)] docs.
I think the SystemParamBuilder docs need a larger rewrite to mention the new features from this and the other PRs, so I'd like to try to do that as a separate PR.  I should also update the list of system params in the module level docs with a section for params that only make sense when building a system.


Include forecasts in observed plot

Show actual forecasts in the plot of observed data as well
Fancy idea: clicking on a point in the main plot shows the forecast data for that date in the observed plot

Include forecasts 20, 50, 80%s in observed plot for each date (clicking on the date would show the forecasts)

50% quantiles are now included. Closing this issue, will reopen another one for inclusion of bands with 20% and 80% data.


Remove menu items on the left of the map except for 'about us'

the menu items in the map are only for the events map and should be removed for other uses. the 'about us' link can stay as other projects using it will be by the Focallocal community


fix: react state propogation bugs by using hooks directly

implements @graphiql/react hooks as a way to prevent undesired state propogation that causes bugs
this was the same solution to the issue for explorer plugin, so it appears to fix both the jumping cursor and operation name state issues!
NOTE: temporarily pinned to canary versions until release is ready
Behavior:

if the URL contains a hash, and the current query is blank, or is the default query, it overrides the editor value
it the current editor tab contains a query that's the same as the one in the URL, nothing happens
if there is a URL hash, and the current editor contains a blank or default query, a new tab is created and it sets the value

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I want to add one last change, where readFromUrl doesn't return defaultQuery so the comparison for default query will no longer be needed, which will make it slightly faster when replacing default query with a new value, and less logic


WIP: Add starting bits for OpenBSD cross compile

At this point it's basically a copy of netbsd's with a s/net/open/gi.
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Is this still alive?

Yep


The sample does not work out-of-the-box

There are a few issues with the provided sample code.

When a user clones the repo and goes follows the instructions for the sample README, the application refuses to start. This is because the sample code reference the local client code and not what is installed via NPM

When using NPM, the package.json references v1.0.2 of the client but the current codebase is v1.0.3.

The Get Company Info use case does not work.

Thanks for the quick feedback @abisalehalliprasan, much appreciated!

So sample still does not work - the callback action has no reference to oauthClient. I am unable to get my code to run nor can I get the sample to work even when I fix this so Id love to see an actual piece of working code.

@cyberwombat :  You might have got confused with the callback URI. Just follow the instructions listed on the sample README.md and you should be able to authenticate using this library.
If you are seeing a different error, please provide the screenshot and we can look into it.

@abisalehalliprasan - my bad - I was looking at this from my need which is stateless hence my issue with empty oauthClient.


Using secret for url field

Is there an existing issue for this?

[X] I have searched the existing issues

Feature description
Hello,
I tried to use a dependabot secret (or combinaison of ones) for the url field but it seems impossible. I always get an error message saying that it's not a proper http or https valid url.
I guess this due to a lack of templating (issue here) ?
To be more specific, my current dependabot.yml file that works for me is:
registries:
  python-codeartifact:
    type: python-index
    url: https://XXX/pypi/XXX/simple/
    token: ${{secrets.CODEARTIFACT_USERNAME}}:${{secrets.CODEARTIFACT_AUTH_TOKEN}}
    replaces-base: false

But I would like to do something like this:
registries:
  python-codeartifact:
    type: python-index
    url: ${{secrets.CODEARTIFACT_URL}}
    # or this
    # url: https://${{ secrets.CODEARTIFACT_DOMAIN }}-${{ secrets.CODEARTIFACT_DOMAIN_OWNER }}.d.codeartifact.${{ secrets.AWS_REGION }}.amazonaws.com/pypi/${{ secrets.CODEARTIFACT_REPOSITORY }}/simple/
    token: ${{secrets.CODEARTIFACT_USERNAME}}:${{secrets.CODEARTIFACT_AUTH_TOKEN}}
    replaces-base: false

Is possible to use secret for the url field ?
Thank you

Any update on this?

I would like to contribute. Can you give me some info about this? Where is performed the secrets resolving?

I would also like to use a github secret for the url value.


UPDATED API URLS AND OWNER

Note: this supersedes #52.

@MattIPv4 Please merge these changes

@anshtyagi0 Please have some patience

sorry I thought you forgot to do that.


[Bug]: The user should be allowed to Adjust the Slipt screen according to his needs and also same goes in pages section

Is there an existing issue for this?

[X] I have searched the existing issues

Description
The user should be allowed to Adjust the Slipt screen according to his needs and also same goes in pages section
Steps To Reproduce

go to application
enable split screen
Now try to adjust the screen to make the query screen little bigger
this is not enabled

Public Sample App
No response
Environment
Release
Issue video log
No response
Version
v1.15

closing this as it is not a requirement for this milestone, and a known limitation,


Helidon v2.1.0

Dependencies still using JDBC v19 and other packages that may be uneccessary, Updated
No NPE guards for missing environment variables, Updated
Environment variables not homogenous, and undocumented, Updated
Add README for running instructions, Updated
Improve code to be more flexible, Updated

@Kuassim Please review when possible and merge

@jeandelavarene Please review and merge when possible


Add CI-job that checks for compile errors

A CI-job should be added that clone some big java projects, applies all rewrites and checks for compile errors.

Implemented.


Add a headless app mode

Current situation
Our desktop apps use Electron to run the UI and package it like a desktop app. However, this means that the user cannot use their favorite browser and browser features (like bookmarks, groups, etc.).
Ideal future situation
There is a way to run Headlamp's destop version using the default browser.
Implementation options

All apps have a headless mode, which means that when they are run with this option, they will open the default browser instead of using the electron view.
We build a new headlamp-headless version of the desktop app which doesn't include Electron (meaning the app is also lighter in size).

This has landed in the master branch. We can close this issue now.

This has landed in the master branch. We can close this issue now.

@joaquimrocha

@joaquimrocha


Hide full screen option when running as an app

Rather than showing it disabled, hide it to remove the noise.
Requires some detection of when it is running as an app.

Related to #19

https://stackoverflow.com/a/41749865/774554


blinking when beautify scss file

Description
blinking when beautify scss file

Input Before Beautification
This is what the code looked like before:
<INSERT CODE HERE>

Expected Output
The beautified code should have looked like this:
<INSERT CODE HERE>

Actual Output
The beautified code actually looked like this:
<INSERT CODE HERE>

Steps to Reproduce

Add code to Atom editor
Run command Atom Beautify: Beautify Editor
This beautified code does not look right!

Debug
Here is a link to the debug.md Gist:
Checklist
I have:

[x] Tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
[x] Reloaded (or restarted) Atom to ensure it is not a caching issue
[x] Searched through existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue
[x] Filled out the Input, Expected, and Actual sections above or have edited/removed them in a way that fully describes the issue.
[x] Generated debugging information by executing Atom Beautify: Help Debug Editor command in Atom and added link for debug.md Gist to this issue

I fund the scss config conflicts with the whitespace and editorconfig.
insert_final_newline = true
trim_trailing_whitespace = true

Does it only happen when saving?  What version of atom-beautify are you running?

Platform: darwin
Versions
Atom Version: 1.19.3
Atom Beautify Version: 0.30.4

Upgrade to 0.30.5 and try


Node.js SDK 1.12.1 release

Node.js SDK 1.12.1 release

@srinathnarayanan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Add support for Snowflake Stages and SNOWFLAKE_FULL encryption

This PR consolidates all changes on the Rust side for supporting Snowflake internal stages as a first class store.
It also restructures much of the code (with many misc changes) to ensure the encryption functionality could be introduced in a generic way.

A ToDo for one day is to test the encrypted put/get using randomized input/chunk size as a stress test to exercise all state machine transitions inside CrypterReader and CrypterWriter

I managed to write the randomized test for CrypterWriter and CrypterReader and add the requested clarifications.


unix,win: make uv_get_process_title() stricter

This commit causes uv_get_process_title() to:

return EINVAL if the buffer is null or size is 0
return ENOBUFS if the title is too big for the buffer
null terminate the buffer on success

Fixes: https://github.com/libuv/libuv/issues/315

@saghul would you mind taking a look?

@bnoordhuis updated

@cjihrig can you check what we do for uv_exepath and uv_cwd? I think we do the opposite, that is, if the buffer is too small we write as much as we can.
One possibility would be to support passing a NULL buffer and then return UV_ENOBUFS and set the size (if passed) to the required size, Windows API style.

It looks like uv_cwd() just does this before stripping trailing slashes:
if (buffer == NULL || size == NULL)
  return -EINVAL;

if (getcwd(buffer, *size) == NULL)
  return -errno;

It doesn't look like getcwd() truncates. It looks like uv_exepath() can truncate because it defers to readlink()'s behavior.
I don't think we could do the Windows thing here because uv_get_process_title() takes a size_t, and not a size_t*.

@saghul any more feedback here?

LGTM with a suggestion.

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/73/

@cjihrig go ahead if the CI is :green_heart:

Landed in 840a8c599ec1f138992a538f5b8109f91f31805e. Thanks for the reviews.


Fix tests that weren't working on Linux

Casing issue and a timing issue.
Closes #1297

I manually updated the CI build to run tests on linux just to test this PR
@dotnet-bot test Ubuntu14.04 Build for CoreCLR please
@dotnet-bot test Ubuntu16.04 Build for CoreCLR please

Tests passed!
Ubuntu 14.04: https://ci.dot.net/job/Microsoft_msbuild/job/master/job/_Ubuntu14.04_CoreCLR_prtest/163/testReport/
Ubuntu 16.04: https://ci.dot.net/job/Microsoft_msbuild/job/master/job/_Ubuntu16.04_CoreCLR_prtest/165/testReport/


Manual propTypes validation warning

Since updating my React to 15.3.2, I am seeing this warning:

Warning: You are manually calling a React.PropTypes validation function for the minW prop on GridItem. This is deprecated and will not work in the next major version. You may be seeing this warning due to a third-party PropTypes library. See https://fb.me/react-warning-dont-call-proptypes for details.

Not exactly sure since which react version this warning would start to appear. Since I know you guys are working on a V2 so probably this should be noted as manual validation would not be supposed in the next "major version" and React seems to be coming out with a major release every 6 months or so.

I believe this is fixed in the latest RGL release, could you please update
and verify?
On Nov 19, 2016 10:36 AM, "jackychow"<EMAIL_ADDRESS>wrote:

Since updating my React to 15.3.2, I am seeing this warning:
app_grid.self.js?body=1:167133 Warning: You are manually calling a
React.PropTypes validation function for theminWprop onGridItem. This is
deprecated and will not work in the next major version. You may be seeing
this warning due to a third-party PropTypes library. See
https://fb.me/react-warning-dont-call-proptypes for details.
Not exactly sure since which react version this warning would start to
appear. Since I know you guys are working on a V2 so probably this should
be noted as manual validation would not be supposed in the next "major
version" and React seems to be coming out with a major release every 6
months or so.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/STRML/react-grid-layout/issues/417, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABJFP-85oaQYUSnBItu99yFDVLYWp5rdks5q_yWfgaJpZM4K3TBp
.

hey @STRML, hmmm I haven't tried the latest release. But unless the release includes changes that is not in the master branch, I believe this problem still exists in master?
https://github.com/STRML/react-grid-layout/blob/master/lib/GridItem.jsx#L39

No, custom propTypes validators is not the issue, the issue is calling something like this.constructor.propTypes.minX(val).

ahhh @STRML , you are right. Sorry I misunderstood the issue!
updated to the latest release and you are correct, the warning is no longer there.
Thanks!


BUG: idangerous Swiper - Multiple nested vertical slides with fade

The easiest way to explain the bug is by showing you, check out this fiddle:
https://jsfiddle.net/iforwms/a13fgzdm/13/
Sliding to slide number 2 and sliding up and down through the nested vertical slides results in the third set of slides being scrolled, not the current set of slides.
Regardless of how many sets of vertical slides you add, it's always the last set that get scrolled. It's an issue of the opacity I think, the browser picks up the top level div (the last one in the code) and scrolls through that, because the opacity is set to 0 but the div element is still there.
Changing line 5 of the javascript, removing the fade effect on the horizontal slide removes the issue.

Fixed, thanks!

In this case fade is still broken
https://jsfiddle.net/a13fgzdm/29/


Cannot find 'key' in scope

Why this example doesn't works?
extension Defaults.Keys {
	static let isUnicornMode = Key<Bool>("isUnicornMode", default: true)
}
print(UserDefaults.standard.bool(forKey: isUnicornMode.name))  //=> true

This is more of a general Swift question and not related to Defaults.
You need to use the full path, in this case, Defaults.Keys.isUnicorn.

Sorry, but I don't understand...
Why general Swift question when I can't call a let in a extension of Defaults following your sample code?
Using UserDefaults.standard.bool(forKey: "") why isUnicornMode.name, used in example, doesn't works and I need use a different code?

Oh, I missed that you were referencing the docs. That's just a typo. Fixed now.

Thanks!


feat(spdk): spdk bindings improvements

NVME status code refactored to refer directly to SPDK enums
NVMF subsystem event support refactored

bors try

bors try


refactor signomial loop conditional

also add #348 proto-test

ready4review

Looks good to me, @pgkirsch if you agree you can hit merge.

Sorry for the delay

495 additions and 513 deletions
that's progress!

Check the release notes :D


Deprecate UsageContext and introduce getOutgoing

[ ] Add tests to ensure that usage still works

We will be creating another variant type entirely and another software component interface to expose that type.


Super class for MD parsers

We can perhaps make a super class for MD parsers, which deals with repeated functions like parts of parse_thermodynamic_data() and the frame rate sampling.

I just recently thought about this also. I can work on this if you like.

Yes, that would be good. Let's keep in contact about it though. I don't want to lose track of what is happening within these parsers, or else it will be increasing difficult for me to deal with user issues.


#8 Enable with-credentials in ajax call

Add with-credentials to iron-ajax element

Depands on https://github.com/lyio/is-there-a-movie/pull/37


Creating duplicate item without a required field gives the wrong error message

Scenario:

Two or more hosts with a given name exists (within different inventories)
Try to create a new host with that same name without specifying the inventory

Result:

Error message Error: Expected one result, got 2. Tighten your criteria.

What it should do:

Error message Error: Missing required fields: inventory

I think this is solved by #135

Issue is not resolved in 2.3.2 release:
(env) sitan-OSX:Desktop sitan$ tower-cli host create --name localhost -v --insecure
*** DETAILS: Checking for an existing record. *********************************
GET https://ec2-54-234-179-218.compute-1.amazonaws.com/api/v1/hosts/
Params: {'name': u'localhost'}

Error: Expected one result, got 2. Tighten your criteria.

Upgrade milestone to 2.4.0.


Add support for webp emotes

Added support for 7tv zero-width emotes, which are basically just emote overlays.
Switched to serde_json instead of json. I didn't realize the json crate was unmaintained. I'm not really familiar with using serde so there might me a better way to define the structs in downloader.rs.
I found a way to avoid the code path in image that was causing a panic, so webp emotes should now work.
I have a PR in progress (image-rs/image#1907) that fixes an issue with emotes having a white background, so for now I switched the image version to point to my fixed fork. It is probably best to wait for it to get merged and a new version to be released before merging this.

This will close #341 as well.

It's weird because there should never be emotes in message_emotes which are not in emotes.info. When I find a new emote in a message, I basically add it to emotes.info before even adding it to the message.
https://github.com/Nogesma/twitch-tui/blob/0e69b4fdbb202bbe357882c6c7e5f97b0521f4f2/src/handlers/data.rs#L242 (load_emote adds the emote into emotes.info)
I haven't managed to replicate it yet on my computer. I will add a log message if this happens so I can investigate.

Okay nice, I'll make another PR when image-rs will have a new release with the patch I have on my fork.
I you find a way to reliably trigger the warning here: https://github.com/Xithrius/twitch-tui/blob/30e533e371dc964da0430033e299b245095b6d55/src/emotes/mod.rs#L152 please let me know, I think it's just a quick fix and the underlying issue is not fixed.

It seems a new release of this crate won't be able to go through until your patch goes through on image-rs, given the following error on cargo publish:
error: all dependencies must have a version specified when publishing.
dependency `image` does not specify a version
Note: The published dependency will use the version from crates.io,
the `git` specification will be removed from the dependency declaration.

Hmm, I can set it to the 0.24.6 version in the meantime, but most of 7tv emotes will have a white background.

that'll do for now

I'll just revert to that version until the fix happens

reverted in a19dee51bb1dd296399c5a07781301a44e04272a


Dracula for Streamlit

Please have a look at this implementation of Dracula Theme for Steamlit.io: https://github.com/twrogers1/dracula_streamlit
Thanks!

That's awesome @twrogers1! I just sent you an invite to join the organization.
Once you accept it, you'll be able to transfer the repo and I'll take care of adding it to the site.
Thanks for building this! 🎉

There you go: https://draculatheme.com/streamlit
Thanks @twrogers1!!!


ISPN-11685 Update to RxJava 3.0

https://issues.redhat.com/browse/ISPN-11685

The latter commit is more interesting as I removed our usage of internal rxjava classes and replaced some code with new, especially InnerPublisherSubscription.

Updated to remove and added back in javadoc comments I accidentally removed.

Thanks @wburns


Automatic remaining value in split calculation ignores locale settings

I'm operating in Germany, hence I use comma instead of the dot. Would be nice to take this from the YNAB settings (if possible).

@whiskeysierra I believe this was inadvertently fixed by #400 and should be in the next release!

This should now be fixed in v0.5.1. If that's not the case please let us know!


Error GoogleMaps ionic-native

I have an error when i try to instance GoogleMap.

if I remove the line "new GoogleMap()....." the app runs.
What is this problem??
I'm from Argentina. My English isn't so good. Sorry

Unfortunately I'm not familiar with ionic at all.
It seems the error says you did not install the ionic-native.
I guess you need to install this one.
https://www.npmjs.com/package/ionic-native

@mserravalle92 are you install ionic-native/google-maps? If you see the oficial documentation you can see this command:
npm install --save @ionic-native/google-maps

Use this import: import { GoogleMap, GoogleMapsEvent, MarkerOptions, Marker, LatLng } from '@ionic-native/google-maps';

Thanks!. I solved the issue. The solution was like vosecek said.
The course that i was taking was Outdate.
I repeat. I'm from Argentina. My English isn't so good. Sorry.


Occasionally, support Waver is selected over Skadi

I tested this last night, but I currently have these settings for my config and occasionally, waver with MLB Chaldea Lunchtime is selected:
--AutoSupportSelection Defaults
Support_SelectionMode = "preferred"
Support_SwipesPerUpdate = 10
Support_MaxUpdates = 10
Support_FallbackTo = "first"
Support_FriendsOnly = 1
Support_FriendNames = "Brandon, Ian, Jason, FalK-ON, Haise, Benu, Brun, Randomacts, Annie Hastur"
Support_PreferredServants = "skadi_3.png, skadi1.png, skadi2.png, skadi3.png, skadi4.png"
Support_PreferredCEs = "*chaldea_lunchtime.png"

And for the dictionary of presets:
Autoskill_List =
{
	{
		--Lancelot, Waver, Skadi, Skadi + Plugsuit
		Name = "Everything",
		Skill_Command = "d1g1f14,#,ecx21fi1e4,#,hjd14",
		Support_SelectionMode = "preferred"
	}
}

When waver is selected, it is not the fallback either, it seems to identify it was a preference. I'm currently using the skadi photos inside the repo.
Has anyone else experienced this yet on NA?

Having the same problem. Waver gets picked instead of skadi. Tried to make my own support images instead of using the ones in the directory and it would still pick waver or not pick anything.

I was getting this too. I haven't really seen it since enabling final ascension portraits in Game Options. Maybe the pattern matching for waver3.png and the skadi support images are too similar.


Extracting struct name

Is your feature request related to a problem? Please describe.
I would like to have an object like this:
#Person: {
  name: <nameOfStruct>
}

John: #Person

Which should produce
John: {
  name: John
}

This is obviously just a minimal example, I would like to use the name in some transformations and interpolation.
Describe the solution you'd like
Added syntax for a construct like this
Describe alternatives you've considered
I can create another string inside the object instead and use that as an identifier that will be expanded. To make it exactly 1-to-1 I would also have to add validation that the identifiers are unique across objects.

The example you've given can be accomplished using templates:
// person.cue
#Person: {
    name: string
}

[Name=string]: #Person & {
    name: Name
}

John: {}

$ cue export person.cue
{
    "John": {
        "name": "John"
    }
}

Oh, thank you. I have gone through the tutorials in cuelang but I seem to have missed this one.


US-44 As I developer I want to know what to test and have efficient tests for it.

Because
Efficiently written tests makes writing further tests easier, and tests by themselves makes development much easier.
Tasks

[x] Make a clear definition of what to test (meeting 20/11/2023).
[x] Remove deprecated tests from the tests package (if there are any).
[x] Write tests for everything that should have test (according the the new clear definitions).
[x] Rewrite duplicate tests using parametric testing to ensure efficiency (looking at movement tests specifically).
[x] Adding another task: Read the Javadoc while looking through all the tests, since many classes has been changed and therefore the Javadoc is inaccurate.

Acceptance criteria
There exists a test for everything that should be tested according to the "Arbetsflöde" appendix of the group contract. There are no duplicate tests. There are clear definitions for what should be tested.
DoD
All tasks finished according to acceptance criteria

Issue continued in #115 because git issues in branch.


feat: route delivery receipts to different queue

Route SES and SNS delivery receipts to a dedicated queue to not clog the Notify queue.
See the API PR for more details
https://github.com/cds-snc/notification-api/pull/1216
:warning: The API PR needs to be deployed before this one in staging and in production, otherwise no workers will pick up tasks from this queue.

Sorry for the commit/messages mess, tfsec acted weirdly for a few minutes and the Docker image was not pullable. Tried to fix that but in the end, I reverted to the version we use and now all is good.
Logged an issue to use the latest version thought #168

Sorry for the commit/messages mess, tfsec acted weirdly for a few minutes and the Docker image was not pullable. Tried to fix that but in the end, I reverted to the version we use and now all is good.
Logged an issue to use the latest version thought #168


Add URL(), Path() methods

Simplified version of NSBundle.mainBundle().urlForResource("filename", withExtension:".txt")
Something like:
let url = URL("filename.txt")
let path = Path("filename.txt")

I think this may be confusing if you are trying to create a file, since you can never create a file in a bundle. What about let url = URL(forFileInMainBundle: "filename.txt"). Also I feel like this may be outside our scope. I'd prefer something like let movie = Movie(loadFromMainBundle: "movie.mp4")


fix: missing role permissions

adding missing read permissions on environments, which resulted in the following error

WARNING: error loading TeamSettings to determine if in GitHub app mode: failed to setup the dev environment for namespace 'jx': environments.jenkins.io is forbidden: User "system:serviceaccount:jx:jenkins-x-slack" cannot create resource "environments" in API group "jenkins.io" in the namespace "jx"

adding missing read permissions on configmaps, to be able to read git auth config

move the role rules in the chart values, to allow customization of the rules without requiring updates of the chart

ping @rawlingsj - thanks!

awesome - thanks @vbehar!


TouchScreenButton: Fix screen capability check

Fixes #69572.
Thanks @spatker for identifying the issue and the likely fix.
I haven't tested the change but it seems clear that the previous logic was wrong.
The code in 3.x is correct and matches what this PR restores:
                        if (!Engine::get_singleton()->is_editor_hint() && !OS::get_singleton()->has_touchscreen_ui_hint() && visibility == VISIBILITY_TOUCHSCREEN_ONLY)

Thanks for making this pull request! I have tried the same change locally, and it does fix the visibility issue, but the button is still not interactive in the emulator, just as before this fix. So that maybe a different issue.

@spatker Yeah this would only impact visibility, for actual input processing it might be a different issue. I'd suggest opening a new issue about that with a simple reproduction project for testing.

Seems like the input issue can be fixed by https://github.com/godotengine/godot/commit/67126ff6e265fe83b05fa1647d4ba7d89ebf9919


invalid value encountered in divide

Some tests emit the warning RuntimeWarning: invalid value encountered in divide. While it is likely to be fine, we should make sure it really is and maybe silence the warning if it is indeed.
python-libraries/nanover-core/tests/imd/test_imd_force.py:487
  /home/jon/narupa/narupa-protocol-gh/python-libraries/nanover-core/tests/imd/test_imd_force.py:487: RuntimeWarning: invalid value encountered in divide
    np.subtract(interaction, position)

python-libraries/nanover-core/tests/imd/test_imd_force.py::test_constant_force[position6-interaction6-1-expected_force6]
  /home/jon/narupa/narupa-protocol-gh/python-libraries/nanover-core/src/nanover/imd/imd_force.py:275: RuntimeWarning: invalid value encountered in divide
    force = distance_vector / np.linalg.norm(distance_vector)

This is the case where the interaction and atom are at the same point. All the other forces drop to zero here, but since this is the constant force I'm not sure what's best. Could make exact zero distance a special case where force drops to zero (is this discontinuity a problem?), or an arbitrary vector is chosen (this is probably what happens in practice, oscillating around the interaction point). Could introduce a drop-off for small distances--or some continuous function to that effect. Not sure what best matches the intent.

From meeting: let's go ahead and make it 0 force in this case


Add fee rate (sat/byte) to help users

In light of the ongoing spam, the fee rate of satoshi/byte is a useful measure for if a tx will 'get past the spam'.
We know the fee on sends so could add a fee rate next to it/  below it in the transactions details wizard.

Do you mean after the fact (as in transaction details on Payments) or before the fact (as in confirmation screen on Send)?

It is most useful on the send confirmation screen but could appear on both. My inclination would be to put it on both.
It does not need to be stored as you can work it out (for sends where you have the tx fee stored).
Fee rates seem to have standardised on satoshi/byte e.g. see http://www.cointape.com

I have added the transaction fee rate, with units 'sat/byte' to the transaction details page.
It cannot be added to the Send confirm screen though as, at this point, the transaction is not signed so you do not know how big it is when serialised.
You can cross check the fee rate by selecting 'smartbit.com.au' as your block explorer as that bock explorer show fee rate.
Awaiting review and closing.

Screenshot:

Verified working.
Closing.


Can someone help me with the detailed instruction ?

I could not understand the steps mentioned here.
I would like to know more details like what to be imported in appmodule, where to put the code blog and stuffs like that.
But I could not get these details here, if documentation is improved little bit then more people like me can also experience this nice plugin.

I improved the README and added a more detailed introduction as well as an FAQ. Please tell me if there is still something unclear.


next_objects field is now a JSONB array. It is updated in the create …

…script and the mockdata.
The model is updated in ahmed's model repo #16

Yeah, let's make the repo public now @ahmedhamodi ?

Done


merge package template from Kronos-Tools/npm-package-template

LICENSE

fix: update LICENSE

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   97.52%   97.52%
=======================================
  Files           1        1
  Lines         121      121
=======================================
  Hits          118      118
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cce30a...d9ab7fc. Read the comment docs.


Add account loader

This adds an AccountLoader to retrieve current account information from the legacy code base. This will be used in the account edit feature.

I'm assuming this is in preparation for using the new UI to edit server settings. I feel like this is making things more complicated than they need to be.
To edit and check the server settings we don't need to know about the whole account (e.g. account options). So AccountIncomingConfigViewModel, AccountOutgoingConfigViewModel, and ServerValidationViewModel probably shouldn't use AccountStateRepository, but maybe a ServerSettingsStateRepository interface (that InMemoryAccountStateRepository can implement). For editing server settings we could then provide an AccountServerSettingsStateRepository that is accessing an existing account and is completely separate from InMemoryAccountStateRepository.

I simplified the AccountLoader and it is now pretty much standalone not interacting with the InMemoryAccountStateRepository anymore.

Build related issues have been moved to https://github.com/thundernest/k-9/pull/7178. Once merged this could be rebased.


Panic when registering the same type but diff urls

Panic on typeurl registration when you register the same type but
different urls for that type.
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Codecov Report

Merging #1243 into master will increase coverage by 0.17%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
+ Coverage   28.08%   28.25%   +0.17%
==========================================
  Files          28       28
  Lines        2834     2838       +4
==========================================
+ Hits          796      802       +6
+ Misses       1889     1888       -1
+ Partials      149      148       -1

Impacted Files
Coverage Δ

typeurl/types.go
78.82% <100%> (+3.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c52523c...a3769f8. Read the comment docs.

LGTM


Include dedicated derivative functions for FiniteDifferences/ForwardDiff instead of relying on jacobians?

Hey all.
As it stands, calling AD.derivative for FiniteDifferences and ForwardDiff back-ends first calculates the jacobian and then flattens it into the derivative. For a few edge cases, say a single-input function, this is significantly slower:
using FiniteDifferences, BenchmarkTools
import AbstractDifferentiation as AD

fdm = central_fdm(2,1,adapt=0)

fd = AD.FiniteDifferencesBackend(fdm)

with_AD(x) = AD.derivative(fd,sin,x)
without_AD(x) = fdm(sin,x)
blame_the_jacobian(x) = jacobian(fdm,sin,x)

@benchmark with_AD(1.)
@benchmark without_AD(1.)
@benchmark blame_the_jacobian(1.)

BenchmarkTools.Trial: 10000 samples with 10 evaluations.
 Range (min … max):  1.070 μs … 552.240 μs  ┊ GC (min … max): 0.00% … 99.30%
 Time  (median):     1.160 μs               ┊ GC (median):    0.00%
 Time  (mean ± σ):   1.327 μs ±   5.524 μs  ┊ GC (mean ± σ):  4.13% ±  0.99%

    ▅█
  ▂███▆▄▃▃▃▂▂▂▂▃▂▂▂▃▂▂▂▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁▁ ▂
  1.07 μs         Histogram: frequency by time        2.42 μs <

 Memory estimate: 944 bytes, allocs estimate: 17.

BenchmarkTools.Trial: 10000 samples with 961 evaluations.
 Range (min … max):  85.640 ns …  2.145 μs  ┊ GC (min … max): 0.00% … 93.60%
 Time  (median):     88.658 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   97.445 ns ± 46.875 ns  ┊ GC (mean ± σ):  0.98% ±  2.08%

  ▂█▇    ▁▄▅▄▃    ▄     ▁▁▁▁                                  ▁
  ███▇██▆██████▆▆███▄▅▆▇█████▇▆▅▃▄▅▅▄▅▆▆▅▆▇▇█▇▃▄▄▂▅▄▅▄▅▃▄▄▅▃▄ █
  85.6 ns      Histogram: log(frequency) by time       173 ns <

 Memory estimate: 32 bytes, allocs estimate: 2.

BenchmarkTools.Trial: 10000 samples with 111 evaluations.
 Range (min … max):  774.775 ns … 47.623 μs  ┊ GC (min … max): 0.00% … 97.59%
 Time  (median):     819.820 ns              ┊ GC (median):    0.00%
 Time  (mean ± σ):   950.669 ns ±  1.825 μs  ┊ GC (mean ± σ):  7.82% ±  4.01%

  ▄▇█▆▄▂▂▁▁▁▁  ▃▄    ▁▁                                        ▁
  ██████████████████████▇▆▆▆▆▆▆▆▆▅▆▅▅▆▆▅▆▄▅▅▅▅▄▄▄▄▆▅▄▆▄▄▄▅▅▄▄▅ █
  775 ns        Histogram: log(frequency) by time      1.83 μs <

 Memory estimate: 864 bytes, allocs estimate: 14.

This is also the case for other, less silly examples like small neural networks with a single input. What are the reasons for not implementing the derivative directly? Something along the lines of:
function AD.derivative(ba::AD.FiniteDifferencesBackend, f, xs...)
    return (ba.method(f, xs...),)
end

I assume it wasn't done because it worked without it, and noone ran those benchmarks.
A PR to implement this would be apprecated


Use AppVeyor

This is blocked by #44 because heapsize is broken with last nightlies.

r=me once #44 lands

:umbrella: The latest upstream changes (presumably #46) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-servo r+

:pushpin: Commit eec2c5d has been approved by larsbergstrom

:hourglass: Testing commit eec2c5d with merge d5f3026...

@bors-servo r-
AppVeyor unhappy.

Ah no, never mind.

@bors-servo r=larsbergstrom

:pushpin: Commit eec2c5d has been approved by larsbergstrom

:sunny: Test successful - travis


Cannot delete rows, see description

Error: Exception calling "DeleteRow" with "1" argument(s): "Comment does not exist in the worksheet"
I have tried clearing all comments in the file to an empty string, but the error persists. Any ideas?

Need a small repo, script and code or what you are trying to do.

@dfinke ah yes sorry. I am simply calling excel.deleterow(1). I am not at my pc right now to get the specifics but the logic is:
I want to delete the first 13 rows. So I do a simple loop 13 times and call deleterow(1) for each of them.
This works great until I get to rows that have comments in them, this exception is throw. If I had to guess, the module is trying to delete the comment but fails. My next step was to look at that function but I couldn’t find it in a timely manner today.
Thank you!

Still need to see the script. Off the top of my head, maybe deleting the rows from the last row to first row of the range.

Tried it backwards but it still crashes on the same rows:
$i = 13

1..13 | % {

    ##Write-Log -Level 'INFO' -Message ("REMOVING ROW " + $_)
    ##$DATAws.DeleteRow(1)

    Write-Log -Level 'INFO' -Message ("REMOVING ROW " + $i)
    $DATAws.DeleteRow($i)

    $i--

}

Log Output:
[INFO   ] REMOVING ROWS
[INFO   ] REMOVING ROW 13
[INFO   ] REMOVING ROW 12
[INFO   ] REMOVING ROW 11
[INFO   ] REMOVING ROW 10
[ERROR  ]
ForEach-Object: Script.ps1:184:21
Line |
184 |              1..13 | % {
|                      ~~~
| Exception calling "DeleteRow" with "1" argument(s): "Comment does not exist in the worksheet

Need to see the spreadsheet too. Could be an internal issue.

Redacted Sample.xlsx

I had to remove the table data due to sensitivity, but the file contains the rows with issues.

Not sure why that doesn't work. Don't have time right now. Not sure it is the module causing it.
I would try a stepped approach to figure things out. See where it breaks first. Delete 1 row, then 1 and 2, then 1,2,3. Go from there.
This worked for me $excel.Data.DeleteRow(1, 13) in one block.

Wow that one liner is way more practical. I wasn’t aware you could pass it two parameters. Thanks for the suggestions. I might just use the working method and leave this issue for now. Thank you for the awesome toolset and looking into this.


Remove availability_zones from autoscaling group

I am getting a failure with the autoscaling group when using the vault-cluster submodule. I get an error telling me that it is no longer allowed to specify both availability_zones and vpc_zone_identifier. Since this module requires both availability_zones and subnet_ids to be passed, it seems that we should not pass availability_zones to the autoscaling_group.
Here is the PR in the aws provider that made the change:
https://github.com/terraform-providers/terraform-provider-aws/pull/12927
Terragrunt version: 0.23.33
Terraform version: 0.12.29
Vault module version: 0.13.11
Submodule: vault-cluster

Since this module requires both availability_zones and subnet_ids to be passed, it seems that we should not pass availability_zones to the autoscaling_group.

It does NOT require both to be passed. Both are set to null by default. If you pass just one or the other, it should work. Could you try?

Ah yes I see that in the variables.tf. The documentation on the registry is wrong then. It lists availability_zones and subnet_ids as required inputs.
https://registry.terraform.io/modules/hashicorp/vault/aws/0.13.11/submodules/vault-cluster?tab=inputs

I can also confirm that not passing availability_zones, the module works as expected now. I'll close my PR out. Should I open a new issue for the documentation problem?

Ah yes I see that in the variables.tf. The documentation on the registry is wrong then. It lists availability_zones and subnet_ids as required inputs.
https://registry.terraform.io/modules/hashicorp/vault/aws/0.13.11/submodules/vault-cluster?tab=inputs

Hm, seems like a bug in the registry, no?

No response in a few months. Closing.

No response in a few months. Closing.