Added support for Web Components with Lit

This PR introduces a minimal usage of Lit to replace the sidebar component of the NWB GUIDE application.
It encapsulates sidebar-specific HTML, CSS, and JS into a single class that can be used anywhere in the application.
Notably, using Lit in our current Electron configuration—and likely Electron generally—requires transpiling the source code so that the lit package (in ESM) can be read. As such, we had to add a bundler (vite) to output a bundled JS file in the dist folder that is then referenced by the original Electron app.
While this additional requirement could be seen as a drawback, it also opens several opportunities (not introduced in this PR):

With the addition of a tsconfig.json file, we can move forward with writing the frontend in TypeScript for better predictability, readability, etc.
With a single additional script specified in package.json, we can use Vite to serve the frontend by itself during development

Shall this count as one of the first 'purges'?
Tried running it, seemed to behave fine for me

I'd say this is more of a feature addition, specifically of Web Components using Lit and Vite.
The general workflow for the "purges" will now go as follows:

Make a Web Component for a desired page and sub-elements
Put all JavaScript and CSS it uses into it
Replace the original usage in the parallel guide instance

Since these Components will go into the parallel guide instance, we'll be "purging" their unused code without actually adding deletions until we wipe the original SODA instance.

@CodyCBakerPhD Looks like the review was marked as stale again. Whoops!

Yeah, conflict resolution counts as fresh commits - it's all for maximum safety, though, so an annoyance we happily put up with


qa_crowbarsetup: Fix runupdate to correctly re-run zypper if needed

When zypper returns 103, then it means that the zypp stack got updated
and zypper needs to be re-run.

+1

+1


Karma-webpack takes ~2 minutes to load

Using 1.7.0 and webpack 1.12
When I start my unit tests I get an the following logs with loglevel: config.LOG_DEBUG
02 03 2016 09:19:46.010:DEBUG [plugin]: Loading karma-* from /.../node_modules
02 03 2016 09:19:46.013:DEBUG [plugin]: Loading plugin /.../node_modules/karma-chai.
02 03 2016 09:19:46.014:DEBUG [plugin]: Loading plugin /.../node_modules/karma-chai-as-promised.
02 03 2016 09:19:46.015:DEBUG [plugin]: Loading plugin /.../node_modules/karma-chai-sinon.
02 03 2016 09:19:46.017:DEBUG [plugin]: Loading plugin /.../node_modules/karma-chrome-launcher.
02 03 2016 09:19:46.021:DEBUG [plugin]: Loading plugin /.../node_modules/karma-coverage.
02 03 2016 09:19:46.207:DEBUG [plugin]: Loading plugin /.../node_modules/karma-firefox-launcher.
02 03 2016 09:19:46.209:DEBUG [plugin]: Loading plugin /.../node_modules/karma-mocha.
02 03 2016 09:19:46.210:DEBUG [plugin]: Loading plugin /.../node_modules/karma-nyan-reporter.
02 03 2016 09:19:46.257:DEBUG [plugin]: Loading plugin /.../node_modules/karma-sinon.
02 03 2016 09:19:46.258:DEBUG [plugin]: Loading plugin /.../node_modules/karma-webpack.
02 03 2016 09:21:50.288:DEBUG [karma]: List of files has changed, trying to execute
02 03 2016 09:21:50.289:WARN [karma]: No captured browser, open http://localhost:9876/
02 03 2016 09:21:50.291:DEBUG [watcher]: Watching "/.../app/index.test.js"
02 03 2016 09:21:50.294:INFO [karma]: Karma v0.13.19 server started at http://localhost:9876/
02 03 2016 09:21:50.298:INFO [launcher]: Starting browser Firefox

Notice that loading the karma-webpack takes a little under two minutes to load before the next line runs?
I inherited a fairly large app it has over 640 unit tests. But by far the thing that takes the longest is waiting for karma-webpack module to load. I am trying to figure out why it takes so long to load.
Currently each test is required by the file that it is testing, like so:
// inside custom-date-form directive
if (process.env.NODE_ENV === 'test') {
  require('./custom-date-form.test')(ngModule)
}

I have tried to fix it with a few configuration tweaks but I haven't seen any results. Is there a way I can figure out exactly why it is taking so long to load?

I am seeing a similar problem. From what I have found out so far, it looks like karma-webpack triggers an initial Webpack run right when it is initialized. I was able to optimize test runtime (also on subsequent karma runs) by removing unneeded entry items from the Webpack config used by karma.webpack and moving to the "Alternative usage" proposed in the Readme. Before karma-webkit was basically recompiling the whole bundle for each test file.

Experiencing the same issue with karma 0.13.22 and karma-webpack 1.7.0

What happens if you disable source maps? They are usually by far the largest culprits when it comes to webpack load times.

@TheMcMurder @tf any resolution on this?

@hankthewhale no and unfortunately I no longer have access to the project where this is an issue.


🌱 Relocate version change validation to preflight check

What this PR does / why we need it:
Previously, the check was executed at the end of reconciliation and in multiple instances. By moving it to the beginning, the process is halted when installed and desired versions match, streamlining the reconciliation workflow.

/hold

The issue is addressed in https://github.com/kubernetes-sigs/cluster-api-operator/pull/168, so the only meaningful thing we can take from this PR is to move preflight checks into a separate package.


Mobile responsive design for the new Devhub Homepage

Is your feature request related to a problem? Please describe.
A mobile responsive design for the new homepage revamp.
Describe the solution you'd like
The new devhub homepage should work on mobile screen size along with the desktop size.
Assets
Figma - Link

Assign this to me

Hey @jaswinder6991 , I would love to work on this. :)

Hi @abitsalihu, Zeeshan already started working on this. Apologies for the delay in response.

Resolved by #417 and #427


How can we evaluate the results with the official MSE loss?

@CommissarMa  Hi. I notice that in your implementation, the ground truth is down-sampled four times to compare with the predicted density map. From my understanding, this down-sampled ground truth makes a difference between your MSE loss and that calculated from the original MSE loss. Would you mind explaining this in detail?

@freshn I have the same question. Have you solved it?

@freshn I have the same question. Have you solved it?

Sorry but no. I got no response from the author. Now it has been quite a long time...


Poor perfromance on Adreno 306 and 308

Hello, while checking base performance on multiple devices for our future project I found two devices where my simple test would render basically unplayable. Reducing test to
const app = new PIXI.Application({
autoResize: true, backgroundColor: 0x1099bb,
});
document.body.appendChild(app.view);
and later updating on resize  app.renderer.resize(777,360);
still doesn't reach more than 40 FPS. Using Pixi-legacy and canvas, the performance is much better.
Profiling doesn't show much, most of the time is spent on System (self) with no further details.

Devices were Huawei MediaPAd T3 10 and Samsung Galaxy Tab A(SM-T550), both runing android 7.  Browsers tested were Chrome and Firefox.
Any sugestion what I am doing wrong or what setting could improve performance?

Andreno 308, 306 is a very slow.
It is not problem of PIXI, it is problem of devices.
System call is very heavyweight.
Usung screen image preview on debuger decrease performnace too. Disable it and capture performance log, then include it as attachment, we we try resolve your problem.

Hi, thank you for looking at this and I apologise for late reply.
I did as you suggested and performance in logs has improved. To bring it closer to the performance edge I used full scale render this time.
I am attaching three files, all from Huawei MediaPad T3 10, rendered at 1555x720.
Profiles.zip
First one is "empty" demo without any graphics added, just background colour as in initial post.
Second one is "slot" from examples. I had to remove blurring effect from symbols, since those instantly brought down performance to 15FPS.
Last one is "custom" test made on top of slot example, with more symbols, background image instead of colour and proper masking instead of black bars. Addition of masking doesn't seem to do any performance hit. Background had to be composited together, cached and masked to avoid offscreen rendering due to oversized background. All textures were packed in single sprite.
While this does run at 50FPS (40 without bitmapcaching), I am afraid that this would still drop below 30 with more items and animations added. Since those three samples are rendered at full resolution, I still have an option to render in half scale if needed. Are there any other suggestions what can be done to bring performance up?


tests: rtc: time_incrementing: set nsec member

The rtc test suite uses timegm to convert a unix
timestamp to datetime, specifically struct tm which has no nsec field, so the nsec field is not initialized properly.
Update tests to init nsec and isdst members of struct rtc_time.

ping @henrikbrixandersen @fabiobaltieri  :)


Make spell checking and style checking part of our doc checkin gate.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
Assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Most of the build time in Jekyll is spent sorting and resorting the site pages in order to produce the left hand nav bar. The logic for that is here: https://github.com/istio/istio.github.io/blob/master/_includes/sort-hierarchy.html. What makes this code painful is that the Liquid language has no functions, no data structures, no recursions, and is incredibly slow. Second, the sorting logic has to run on every page of the site. When working on the site, I go to _layouts/docs.html and change docs=site.docs to docs=site.blog which cuts the total build time by 80% by using the small blog data set to produce the main doc sidebar. Its incorrect, but it is fast. Anyway, if you can think of a better way to sort the site properly, I'd love to see it :-)
I'll do the follow on tests. I did already see that the style checker doesn't actually report an error code when it finds errors. So for now, it'll dump stuff out on the console, but won't prevent the presubmit from failing. I'll look for a solution for that.


PostWRF installation problems (Arch Linux)

Hello, it's my first time with PostWRF, I use Arch Linux and when I try to install it happened it:

Please, I need help with it.

Greetings,
You need to set a ssh-key in your local machine and add it to your github profile. You can follow the instructions bellow:

Generating a new SSH key and adding it to the ssh-agent
Adding a new SSH key to your GitHub account

In summary:

cd ~/.ssh
ssh-keygen
It will save a new file (id_rsa.pub) in ~/.ssh - You can set no password.
Copy the contents of id_rsa.pub
Go to Github Settings -> SSH and GPG keys -> New SSH key
Paste the contents of id_rsa.pub

Now you must be able to clone any repositories into your local machine.


Usage and Documentation

You should at least add a documentation of how this program can be used so when I download it I can use it

add a help command to your package

And you should develop your logical thinking and finally figure out how to READ other issues, to make soure one you are making is unique.

Duplicate of #11


Added --config command line argument, version updated to 1.0.3

This is useless and also breaks tests. I'd prefer not to merge.


Config

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the feature you'd like
I would love to see a config, where i can toggle if i want the items i craft myself to be affected by the plugin.
In my opinion it would be nice if the loot i get from endcitys, dungeons, villagers etc would have qualities but the stuff i craft myself should be +-0 or it should get better the more i craft.
Additional context
Add any other context or screenshots about the feature request here.

I can do that, not fully sure about the getting better the more you craft, I'll see what I can do


baseline results

Hi,
Thanks for the great work!
I have one question about the baseline results of Table 2 in the paper. The paper claims that the baseline results on Waymo Dataset are obtained following OpenPCDet. However, I find the results reported in the paper are much lower than that in OpenPCDet. For example, the result of CenterPoint (VoxelNet) is 61.81/61.30, 63.62/57.79, and 64.96/63.77 in the paper. OpenPCDet reports the result of 63.16/62.65, 64.27/58.23, and 66.11/64.87 for CenterPoint (VoxelNet).

I have the same question, seems like the improvement upon the "true" baseline is much smaller if compared to the openpcdet repo.

Thanks for your interest. The CenterPoint results in Tab.2 are directly borrowed from GCC-3D(ICCV-21). Other results are based on OpenPCDet-v0.3 that only contained Waymo models of SECOND, PartA2 and PV-RCNN at that time. We implement CenterPoint based on the official codebase, thus the results are different from OpenPCDet-v0.5 as you indicated. We would like to add support for OpenPCDet-v0.5 to further improve the results.

Hello, thank you for your interesting work!
I notice that the "training from scratch" results are also borrowed from GCC-3D (ICCV 2021). However, you mentioned that you use a different implementation of CenterPoint. Thus the "training from scratch" results should be conducted with your implementation.
Would you offer your implementation of CenterPoint in the future?

The ‘different implementation of CenterPoint’ refers the model for ONCE dataset. We don't have plan to release the ONCE version right now. Thanks for you attention!

Thank you for your reply! But would you provide training from scratch results on Waymo with your implementation? Because to demonstrate the effectiveness of pre-training methods, we need the same model for training from scratch and for initialized by pre-training methods.

You can just find the Waymo results in the 'Main Results' part of Readme. Thanks.

Thanks for your prompt reply! In my understanding, the results are mAPH for different categories and overall. The results are different from what you present in the paper. Is that right? Thank you again for your patience.

mAPH is right the 'overall' metirc mentioned in the paper. The baseline results in thie repo are also from our implementation, thus are different from the GCC-3D baseline results in the paper.

Got it. Thank you for the clarification!


Sorting discrepancy

file: gef_8e3OrbuWti6wAR59UMqR7Q/QTOP.OUT
check unix account llr199
fotis: id: B, 0+2/2
me: id: E, 0+2/2, but much lower in the ranking.
fotis also has other 0+2/2 ids much later

yeap; you have a point.
what is the output of command grep llr199 qstat.out ? the answer will be hidden there!

and also, why cmspliot002 is in different plce in the right output? that's a bit weird;
I suspect that the sorting tuple is with the columns (all, unix account), that's what it seems like and it makes sense for improved stability in the output

yes, the more I think about it, the more descending (all, unix account) makes sense for both of the above

yeap, you were right. Fixed! still need to fix unsorted ids mess though! (broken)


Set up your network for Teams live events Points to Review Site

The Set up your network for Teams live events link points to a protected review.docs link

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: becbf3ca-b88c-b033-a145-9a1af201ced3
Version Independent ID: 41a6a9b5-d3dd-d8c9-9e97-920ff2fd1a24
Content: What are Teams live events?
Content Source: Teams/what-are-teams-live-events.md
Service: msteams
GitHub Login: @tonysmith
Microsoft Alias: tonysmit

@davidyack - thanks for taking the time to post this catch. The review.docs.microsoft.com site pulls from the 'master' branch on GitHub and unfortunately is behind corp net. Which doesn't make a lot of sense for how we use GitHub since the 'master' branch is public on GitHub. The 'live' branch on GitHub is where the docs.microsoft.com site pulls from. We will get this fixed and pointed to the correct URL. Thanks again for taking the time to report!

It's been removed for now from the content. We will add the link back in once the content is completed. Thanks, Tony


Update README.md

Changed Travis CI button to be correct GitHub account

Current coverage is 81.81% (diff: 100%)

Merging #35 into master will not change coverage

@@             master        #35   diff @@
==========================================
  Files             3          3
  Lines            55         55
  Methods           4          4
  Messages          0          0
  Branches         12         12
==========================================
  Hits             45         45
  Misses           10         10
  Partials          0          0

Powered by Codecov. Last update 3a836b5...a1de5eb

Apparently I'm really bad at this 😁 (ref #36)
Thank you for the PR!


Reduce Binary Size

At the moment the design of the library causes quite excessive code bloat that still requires investigation. In any case it should be a goal to reduce this.

deser::ser::driver::SerializeDriver::advance seems very bloaty


DHCP client changes to reorder options/parameters and to add right options to discover packet

This PR adds additional options to discover packet and also re-orders options/parameters in ascending order. The reordering is not mandated by protocol but this does make debugging easier when we capture network trace. I have tested the changes and discover packet changes appears to be fixing the Dhcp NAK issue as well.

cool. Did you come up with these changes by looking at dhclient?

@edhemphill - Yes, the changes are mostly based on network traffic captured from udhcpc client and looking into DHCP rfc.

Info: This PR has now been rebased.
If this was made in error, feel free to force-push your local branch to restore the PR.

Closing and reopening to see if the Travis CI updates get taken.

Yas! CI changes finally took!

CI ran and checks passed - kudos to @cmonr


Modus-Modal show option for angular

Hi, im tring to use the Modus-modal on an Angular application, but im trying to figure it out a way to appear an disappear this element,
Would be great if this component has a property called show with a boolean value, to appear and dissapear the component
Or would be great to have an example how to use the methods open and close for angular app, the example on the documentation page show only with javascript
Thanks

Hey Ana, one way to go about this is to hook up a @ViewChild that references the modal component, and runs the method off of the nativeElement property.
HTML:
  <modus-modal #myModal>
  </modus-modal>

Component ts:
@ViewChild('myModal') modal: ElementRef<HTMLModusModalElement>;
this.modal.nativeElement.open();

Hi, Thanks, on .ts file is working good, but runing on the web browser it says that nativeElement is undefined, maybe I miss something.

Hi @anamarquezz
My best guess without seeing all of your code is that you are references this.modal before it has been defined.
Is this code being run in an ngOnInit hook or similar? If not, then it might be that the code is being run before the DOM is rendered and could be the reason you are getting undefined.

@ryan-henness-trimble @anamarquezz is the issue resolved ?

@anamarquezz Please feel free to re-open the issue if not resolved.


Focus on  so that the Google "directions" icon shows on the bottom right of screen

When I press on a Marker, it displays a set of Google icons on the bottom right of the screen to either get directions automatically to this Marker location from my location or open the Google Maps app.
But how do I "select" or "focus" on the Marker without actually physically pressing on the Marker first?

Merging to #1872


updated docker image

I tried to build the latest image from the steps mentioned in the wiki and it works pretty fine , but when I deploy the mesos/logstash as marathon app , logstash-executor image is getting pulled from the mesos docker hub and which is old docker image.
I have the latest image for logstash-executor and logstash-scheduler do let me know how can I update it to Docker Registry HUB.

We need to keep our Docker Hub images up to date with the repository.
Our Docker Hub repository is here and here.
Both are 5 months (!) out of date.
Compare Docker Hub repository for Elasticsearch which was updated yesterday.
We have a Gradle build task for publishing
Just need the credentials for this

Here's how to run the task, assuming you have the credentials
./gradlew -PdockerHubUsername=U -PdockerHubPassword=P -PdockerHubEmail=E publishDockerImageWithVersion

@mwl any idea who has the credentials for this?

We'll push a new version as soon as we have a reasonable stable build.

No I dont have credentials for it.


Note that <IP_ADDRESS> is necessary in this configuration

Hm, I must acknowledge I've been sitting on this PR for awhile because I'm not sure its necessary?
See the last comment in the kubernetes-engine-sample PR: https://github.com/GoogleCloudPlatform/kubernetes-engine-samples/pull/31#issuecomment-336996354


added Caiman assembly tutorial doc with Dietrich's edits

Ok. I created a new branch for the documentation file to avoid losing my other work since the other branch was 10 commits ahead. This pull request contains the assembly tutorial doc and only the assembly tutorial doc

Looks good to me!  Four minor changes I'd like to request:

If you're gonna mention the code highlighting thing, link it: https://github.com/Checkmate50/caiman-vsc
You may also run the compiler with this flag after “run” to get a lot of information about the entered file:. this is specifically for seeing the node-representation of the translated file, so I'd like to reword this to read You may also run the compiler with the this flag to see the translation to the intermediate representation, including any explication that was done:
Please drop the with Dietrich's edits from the PR title, the title is what gets merged in, and no need to mention that there
I want to rewrite the first two paragraphs (the introduction) to read:
"""
Caiman is a research language that is a project of CU Capra. Caiman programs consist of several "specification languages" and an "implementation" of those specification languages.  The intention of this divide in responsibility is to make it easier to explore performance tradeoffs while maintaining program semantics.

This repository contains implementations of three levels of abstraction for working with the Caiman compiler:

The raw IR, which you can write directly as a Rust .ron file
Caiman Assembly, which gives you exacting control over the generation of the Caiman IR (and is essentially just a .ron file with node names and some small quality of life changes)
High Level Caiman (HLC), which lets you write Caiman with slightly higher-level semantics.  Note that we are in the process of updating names so that HLC is just called Caiman, since this is the intended representation of the Caiman language.

The structure of the Caiman compiler, at the moment, is roughly as follows:
HLC -> Caiman Assembly -> Explication (currently empty) -> Caiman IR -> Rust

Where each of these arrows can be "bypassed" by writing a lower level of abstraction.  Note that typechecking is done on the Caiman IR, though HLC and Caiman Assembly also do some lowering work and may error as a result.
"""

I should really make a flowchart for the Caiman compiler


failure to export pdf

[Enter steps to reproduce below:]

...
...

Atom Version: 1.10.0
Electron Version: 0.37.8
System: Unknown Windows Version
Thrown From: markdown-themeable-pdf package, v1.2.0
Stack Trace
Uncaught AssertionError: html-pdf: Failed to load PhantomJS module. You have to set the path to the PhantomJS binary using 'options.phantomPath'
At assert.js:89

AssertionError: html-pdf: Failed to load PhantomJS module.  Here I can not do much more than to recommend you perform a clean installation and read the closed Issues.
See #17

NOTE: the default usage of html-pdf may not work since the NAME CHANGE of phantomjs to >>>phantomjs-prebuilt<<<.
evidence is here:
npm WARN deprecated<EMAIL_ADDRESS>Package renamed to phantomjs-prebuilt. Please update 'phantomjs' package references to 'phantomjs-prebuilt'
npm WARN deprecated<EMAIL_ADDRESS>ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
The options on the last line below,  probably need to be set as follows in your code(doing this did not fix it for me, but at least I got past that error message):
            htmlToPdf.create(dom, {
                format: absolute ? undefined : atom.config.get('markdown-themeable-pdf.format'),
                width: absolute ? width : undefined,
                height: absolute ? height : undefined,
                orientation: atom.config.get('markdown-themeable-pdf.orientation'),
                border: atom.config.get('markdown-themeable-pdf.pageBorder'),
                type: jobInfo.exportType,
                quality: atom.config.get('markdown-themeable-pdf.imageQuality'),
                header: customHeader,
                footer: customFooter,
                phantomPath: "./node_modules/phantomjs-prebuilt/bin/phantomjs"


I can translate md file to Turkish

Checklist

[ ] I've translated README.md file to turkish.

Turkish version of README.md

Problem it solves
Localization helps to reach more users to use, contribute, support etc

Thanks! We'll discuss this idea internally (whether we want to support localized readme's or not) and reply back to you.

How exactly do you plan the translated README.md to be shown?

Im not quite sure but when i look at to projects with different README files, their file name is in format README.la-CO.md
which is la stands for language code. My is tr and CO is country and mine is TR. So, i planned to create file name README.tr-TR.md and translate contents into new file

The thing is… it creates the unrealistic idea that the project is then able to provide support, respond to issues or provide documentation in that language, or engage with users in other channels using their native tongue (which is not the case here).
Yet the first thing to do after installation is to interact with the cli and its help/man params or documentation site that's all solely in english anyways. The english-only readme is unfortunately not THE language barrier here.


feat: add org-indent-mode-turns-on-hiding-stars equivalent

Follow on from #627.
Bullet points:

Added new config flag: org_indent_mode_turns_on_hiding_stars which is enabled by default
Added docs reflecting new configuration flag

Crosses another one off my list of indent mode features.

As an aside, do you mind if I PR a quick make format to nightly? Getting assaulted by the linter on every pre-push is driving me ever so slightly insane.

@kristijanhusak I applied your patch and rebased on top of nightly for the formatting


Unwrap spawnSyncBinding.spawn?

Hi, this line in unwrap function looks strange:
if (spawnSyncBinding) {
  spawnSync = spawnSyncBinding.spawn // <----- this line
}

https://github.com/tapjs/spawn-wrap/blob/master/index.js#L60

I think you want to write spawnSyncBinding.spawn = spawnSync.

Fixed on master.


No Data loaded on Dashboard after refresh

Hello,
All the process is successfully done but when i try to refresh from the dashboard Tab on Excel, i can't see any data.
All tab are empty and not data are loaded from csv file.
Could anyone assist me on this please?
Many thanks in advance.

Issue Resolved.
All file should be in C:\adfs and not somewhere else.


MappableField is not functioning on getter

my_class.dart
import 'package:dart_mappable/dart_mappable.dart';

part 'my_class.mapper.dart';

@MappableClass()
class MyClass with MyClassMappable {
  covariant dynamic fields;
  late final String _jsonType;

  MyClass({
    this.fields,
  }) {
    _jsonType = 'my-class';
  }

  @MappableField()
  String get jsonType => _jsonType;
}

main.dart
print(MyClass(fields: {
  'one': 1,
  'two': 'two',
}).toMap());

// results:  {field: {one: 1, two: two}}

Appears to be a bug introduced in 4.0.0-dev.0 as it works fine with dart_mappable 3.1.3 and dart_mappable_builder 3.2.0 (using Dart 3.0.6)

Ah yes I released this for 3.2.0 but still need to cherrypick ot for v4

This is released now as v4.0.0-dev.1


DynamicForm Add support for webAbsoluteUrl

Q
A

Bug fix?
[ ]

New feature?
[*]

New sample?
[ ]

Related issues?
fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Added webAbsoluteUrl to IDynamicFormProps interface
Edited the contructorto define the sp setup based on the existence of the prop webAbsoluteUrl
Created a new private prop to define the web url private webURL base on the exitence of webAbsoluteUrl prop
Edited 7 lines of code to include the new private webURL as parameter

Edited Lines

Added a condition to hide save and cancel button when disabled

I thing I manage to fix the conflicts

Thanks @6gal6ler6!


Error trying to serialize {}:: undefined method `to_msgpack' for 2018-11-27 05:21:10 UTC:Time

fluentd version: 1.3.0
Configuration

<source>
  @type elb_log
  region            us-east-1
  s3_bucketname     <bucket_name>
  s3_prefix         <bucket_prefix>
  timestamp_file    /fluentd/etc/elb_last_at.dat
  buf_file          /fluentd/etc/fluentd-elblog.tmpfile
  refresh_interval  60
  tag               elb.access
</source>

<match elb.access>
  @type copy
  <store>
    @type gelf
    host <graylog_host>
    port 12201
    flush_interval 5s
  </store>
  <store>
    @type stdout
  </store>
</match>

Problem explanation:
While using the plugin fluent-plugin-gelf-hs for graylog output, getting this error:

 Error trying to serialize {
   "time"   =>"2018-11-27T05:21:10.506751+0000   ",
   ...
}: undefined method `to_msgpack' for 2018-11-27 05:21:10 UTC:Time

Because msgpack cannot handle Time object.

Could you paste entire backtrace here?

And could you try this patch?
diff --git a/lib/fluent/plugin/out_gelf.rb b/lib/fluent/plugin/out_gelf.rb
index d52f3f8..93eeeba 100644
--- a/lib/fluent/plugin/out_gelf.rb
+++ b/lib/fluent/plugin/out_gelf.rb
@@ -70,7 +70,7 @@ module Fluent

       begin
         make_gelfentry(
-          tag,time,record,
+          tag,timestamp,record,
           {
             :use_record_host => @use_record_host,
             :add_msec_time => @add_msec_time

I'll report this issue in https://github.com/bodhi-space/fluent-plugin-gelf-hs.

hey, this patch worked! :) Thanks a lot..

Delegate to https://github.com/bodhi-space/fluent-plugin-gelf-hs/pull/5. Closing.


Patch 2

Adds Option IsGlobalCatalog to xAdDomainController per issue/feature request #75 and fixes get-dscconfiguration issue with xAdDomainController #111 .

This change is

Hi @Merto410, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

I believe the appveyor check is wrong.  I have validated that on a server, that it shows true when sitename matches and false when it doesn't and set properly moves the server without issue if sitename doesn't match.

I just glanced at this code to help you with the tests failing. Saw some other things I commented on as well
Would you be so kind to add tests for the new parameters and logic as well.

Review status: 0 of 3 files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

README.md, line 248 at r2 (raw file):
Please review code PR #111. The schema is not correct if you wanted the same functionality as  PR #111.
Also, please mention original author in your PR description, since you continue working on the abandoned PR #111.

It's important that when you create a new pull request from someone elses work, that you mention the the original pull request, and also aknowledge the original author and mention the work it is based on. For example mention the original author in the descriptive field when you create the new pull request.

https://github.com/johlju/DscResources/blob/master/GettingStartedWithGitHub.md#how-to-continue-working-on-a-pull-request-when-an-author-contributor-is-unable-to-complete-it

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.psm1, line 204 at r2 (raw file):

        [Bool]$IsGlobalCatalog = $true,

        [Bool]$Ensure,

What does this do? Not mentioned in the Readme.md, please add it.

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.psm1, line 206 at r2 (raw file):

        [Bool]$Ensure,

        [String]$NTDSSettingsObjectDN

Please add this to the README.md.

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.psm1, line 224 at r2 (raw file):

        $existingResource = Get-TargetResource @PSBoundParameters
        $isCompliant = $existingResource.Ensure

What is this row meant to achieve ?

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.psm1, line 240 at r2 (raw file):

            $isGCCorrect = $false
        }
        if ($isGCCorrect -eq $false -or $isinsite -eq $false)

This is always evaluated to $false. The variables are not assigned before this evaluation? Probably why the test fail.

Comments from Reviewable

@johlju  Thanks for looking at it.
to answer:
"Would you be so kind to add tests for the new parameters and logic as well."
Where is the existing tests, and how would I go about modifying/updating the logic
"Also, please mention original author in your PR description"
I can certainly do that but I only linked it when I saw someone had the same issue so that no one would duplicate effort.  I resolved it completely independently without input or code from another author. (which is why the functionality isn't quite the same).
PR #111
For the next two, that is part of the fix to the get-dscconfiguration being broken.  The vars called in the schema have to be referenced in all three functions.  The purpose is referenced in the readme.md.  would further explanation of each line be helpful in the readme or would it be better to have line comments?
"   $existingResource = Get-TargetResource @PSBoundParameters
$isCompliant = $existingResource.Ensure"
These were in the code prior to my changes but they pull the get to perform the test and set the default state equal to the install state of AD services.
"This is always evaluated to $false. The variables are not assigned before this evaluation? Probably why the test fail."
I suspected as much but this requires a re-write of the test and I'm not sure where or how to update that.  The updated test function is needed to correct the GC state
Thanks again

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

Hi @Merto410, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.
TTYL, MSBOT;

Updated test to account for Global Catalog options

@Merto410 and @johlju : How is the status of this PR? I would like to use and extend the resource with the GC functionality added.

@raandree I haven't seen any update on when the review is taking place or what needs to happen to make it go forward.  I'm circling the runway :)

Hi @Merto410. Do you still want to move this PR forward? I'd like to know because I need to figure out if I should review this PR or not. If you want to go forward, I'll review. If not I'll close this PR instead and open a new one myself (or maybe assign it to @raandree).

 I'm available to get this merged so I'm hoping you have time to work on it. If you don't, then please let me know and I will mark it as abandoned so that someone else can continue the work. Thanks!

@johlju, @bgelens  if it hasn't already been addressed in a different pull then it should reviewed for inclusion yes.

@Merto410 Happy to review this. Could you please rebase this PR against dev so you get the latest changes, and so README.md is correct. Thanks!

Reviewed 1 of 3 files at r1, 1 of 2 files at r3, 1 of 1 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.psm1, line 28 at r5 (raw file):

        [String]$SiteName,

        [Bool]$IsGlobalCatalog = $true

We should not add unused non-mandatory parameters to Get-TargetResource.
https://github.com/PowerShell/DscResources/blob/master/BestPractices.md#get-targetresource-should-not-contain-unused-non-mandatory-parameters

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.psm1, line 58 at r5 (raw file):

                    $returnValue.SiteName     = $dc.Site
                    $returnValue.IsGlobalCatalog = $dc.IsGlobalCatalog
                    $returnValue.NTDSSettingsObjectDN = $dc.NTDSSettingsObjectDN

We should not return internal objects to Get-DscConfiguration. If this is only necessary for the Set-TargetResource, then I suggest we make sure to get this property another way in the Set-TargetResource function and not add it as a read-only parameter.

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.psm1, line 162 at r5 (raw file):

            ## DC is not in the expected Global Catalog state
            Write-Verbose "Setting the Global Catalog state to '$IsGlobalCatalog'"
            if ($IsGlobalCatalog -eq $true){$value = 1}

We should have the braces on there own lines.

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.psm1, line 163 at r5 (raw file):

            Write-Verbose "Setting the Global Catalog state to '$IsGlobalCatalog'"
            if ($IsGlobalCatalog -eq $true){$value = 1}
            if ($IsGlobalCatalog -eq $false){$value = 0}

We should have the braces on there own lines.

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.psm1, line 164 at r5 (raw file):

Set-adobject

Set-AdObject (upper 'A' and 'O')

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.schema.mof, line 12 at r5 (raw file):

    [write] String SiteName;
    [write] Boolean IsGlobalCatalog;
    [read] Boolean Ensure;

Please add the read-only properties to the README.md.
See example how this can be done here; https://github.com/PowerShell/SqlServerDsc#sqlag

DSCResources/MSFT_xADDomainController/MSFT_xADDomainController.schema.mof, line 13 at r5 (raw file):

    [write] Boolean IsGlobalCatalog;
    [read] Boolean Ensure;
    [read] String NTDSSettingsObjectDN;

See another comment about  this read-only property.

Tests/Unit/MSFT_xADDomainController.Tests.ps1, line 303 at r5 (raw file):

       It 'Calls "Set-ADObject" when "IsGlobalCatalog" does not match' {
         Mock Get-TargetResource {

We should indent with four spaces. Throughout, multiple locations.

Tests/Unit/MSFT_xADDomainController.Tests.ps1, line 314 at r5 (raw file):

Set-ADObject  -MockWith {}

Double space between cmdlet name and named parameter. Throughout, multiple locations.

Comments from Reviewable

@Merto410 Just pinging to check if you have the time to continue working on this PR? If not I will try to get this through.

This PR continues in PR #255.


README: document supported config.json options

I purposefully omitted the option we created to work around https://github.com/juttle/juttle-service/issues/9.
@mstemm

lgtm.


"Execute SQL Statement" on vertical/block selected text executes code outside the selection

System information:

Windows 10
DBeaver 21.1.3
No additional extensions

Connection specification:

N/A

Describe the problem you're observing:
When I make a vertical/columnar/block selection in the SQL Editor (via Ctrl+Shift+A), and then "Execute SQL Statement" (via Ctrl+Enter) to execute that block of text, DBeaver fails to exclude text outside the selected region except to the left of the top line and the right of the bottom line.  It should only execute the SQL statements within the selected area.
Steps to reproduce, if exist:
select * from (values (1),(2)) t(val)     where t.val < 2
union
select * from (values (3),(4)) t(val)     where t.val < 4
union
select * from (values (5),(6)) t(val)     where t.val < 6
-- select a block from start to here --
-- (without the where clauses)       --

I would expect the result set to be all values from 1-6.  However, it actually includes the where clauses from the first two queries, and does not return the values 2 and 4.

A few more illustrations using the following as the base text:
Line1front excluded     select * from (values (1),(2)) t(val)     where t.val < 2  Line1back included
Line2front included     union
Line3front included     select * from (values (3),(4)) t(val)     where t.val < 4  Line3back included
Line4front included     union
Line5front included     select * from (values (5),(6)) t(val)                      Line5back excluded

@jetzerb Hello, thank you for the report.

Verified


FYI: strange behavior of FF addons on 5347CH N61N3 0PH dnt 🐝 😈 inc.

S077y 4 ✏ing this way, I hope it w0uld m4ke it a bit less 🔍able.

install python (or what you want)
download geckodriver into the same dir
install noscript and μmatrix and ub0 + enable rfp.
disable JS ad css via these addons for all websites
open python, create a webdriver object pointing to your profile
make sure that all the extensions are working as intended, test on Wolfram.
open the website I meant (hope everyone got what website is it) and input anything into the box and hit enter
surprisingly ... the webpage manages to detect webdriver and constantly reloads itself. Not quite itself, it is a loop of 2 pages. Hit esc to stop
disable js via about:config and f5
looping has stopped
devtools network tab shows that the redirection was done by a script block, but the position given is extremily strange - in the middle of word and the code there doesn;t look like a redirect.
I have grepped the previous page URI for tokens in the following redirect - the only place where the unique token appears is within that script tag
that script tag has nonce attr.

it seems that some JS is executed on that website even if all other websites write that there is no JS.

1f y0u2 1n73n710n w45 ju57 70 m4k3 7h15 1355 5342ch4813, why n07 3nc0d3 7h3 519n1f1c4n7 p4275 1n 845364 02 h3x 1n5734d 0f 1337?
17 w0u1d 83 1355 c2yp71c.


Don't default publishDecorations and showWorkspaceLoaded to true on the server

If the client doesn't specify these explicitly, that very likely means it
doesn't know about them and so we shouldn't send them. In particular, the recent
change to this default caused decorations to be sent to emacs, resulting in a
lot of warning spam.

This may be reasonable in the short term... but long term we really should use the workspace/configuration request. InitializationOptions is intended to be used more like a list of command line arguments (and iirc may be deprecated in the future).
I started down this path in #806 but haven't had time to finish it (but it should not be that hard).

Note that workspace/configuration goes in the opposite direction of most request/responses. The server asks the client what it's configuration should be and the client responds (and of course we have sensible defaults on the server side). This works in tandem with the didConfigurationChange notification.

Agree that publish decorations should be false by default, but I think it makes sense to enable “workspace loaded” notification by default.
Unlike decorations hack, it uses the LSP feature, and should be supported by all the Clients. It is also a very useful troubleshooting tool: if a user is in trouble, asking “have you seen workspace loaded” notification should help us bisect possible causes.
I do think that advance users might want to just disable this notification, but the default is specifically aimed at people who launch rust analyzer for the first time.

I think decorations should be in the Client Capabilities somehow, I.e we make a 'proper' protocol extension using the right apis in vscode. However, they should be able to be disabled in the config.

Agree that publish decorations should be false by default, but I think it makes sense to enable “workspace loaded” notification by default.

You're right... I'll change it when I get the time.

Ok, changed it back to default showWorkspaceLoaded to true, and simplified the default handling a bit (so they only have to be in two places instead of three...)
The file had CRLF line endings by the way, that's why it now looks as if the whole file changed. (?w=1 shows the actual changes)

bors r+


Lack of createSvgIcon in an /es folder results in bundle duplication

This is a variation of https://github.com/mui-org/material-ui/issues/10649
I'm trying to load all of my material-ui components from the /es folder to keep bundle size small.  Unfortunately, once you load a single icon, a call to icons/utils/createSvgIcon is triggered, which leads to things being loaded right from the /core folder, duplicating equivalent items that were already loaded from the /es folder.

[X - version 3.0.1 ] This is a v1.x issue.
[ X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Nothing duplicated from /core and /core/es
Current Behavior

Duplication, see above
Steps to Reproduce

N/A - see linked issue - this bug report is regarding the bundle duplication.  Apologies if this case is not needed.
Context

Minimizing bundle size.
Your Environment

Tech
Version

Material-UI
v3.0.1

React
16.4

Browser
Chrome

TypeScript
3.0.1

etc.

This is a variation of #10649

@arackaf How is this not a duplicate of this issue? What's the variation?

I guess only variation I was pointing out is that this still causes problems without any SSR at all, namely bundle content duplication.  If this issue is of no use then apologies.

@arackaf Yes, I agree, the core issue is around the duplicate. The only path forward I can think of is to release a second package like @material-ui/icons-es.


Added extra check to keypath macro

Thanks @nlutsenko for idea implementation: https://github.com/facebook/KVOController/pull/95

Suggestion: Do not use kp for variable name, but rather use extobjckeypath or __extobjckeypath__ or something that has the non-ambiguous and unique name. If anything on the local context has kp as a variable name - there is a good chance you will get a shadowing variable warning. THat's the reason I used fbkvokeypath which I hope is unique enough.

This is a good idea for a change, but I'm not a fan of adding a runtime check to a macro which is supposed to increase compile-time safety.
I'd like to think of a way to statically detect a single key. I'll try thinking about it, but let me know if you have any ideas too.

@jspahrsummers, here is compilation result with optimization enabled:
NSLog(@"%s", keypath(self.window.frame));

=>
	.loc	2 32 5                  @ /Users/k06a/Projects/Test/AppDelegate.m:32:5
	movw	r1, :lower16:(L_.str3-(LPC0_1+4))
Ltmp1:
	movt	r1, :upper16:(L_.str3-(LPC0_1+4))
	movw	r0, :lower16:(L__unnamed_cfstring_2-(LPC0_2+4))
LPC0_1:
	add	r1, pc
	movt	r0, :upper16:(L__unnamed_cfstring_2-(LPC0_2+4))
LPC0_2:
	add	r0, pc
	adds	r1, #5
	blx	_NSLog

and this:
#define KEYPATH(PATH) \
    (((void)(NO && ((void)PATH, NO)), \
    ({ char *kp = strchr(# PATH, '.'); NSCAssert(kp, @"Provided key path is invalid."); kp + 1; })))

NSLog(@"%s", KEYPATH(self.window.frame));

=>
.loc	2 33 5                  @ /Users/k06a/Projects/Test/AppDelegate.m:32:5
	movw	r1, :lower16:(L_.str3-(LPC0_1+4))
Ltmp1:
	movt	r1, :upper16:(L_.str3-(LPC0_1+4))
	movw	r0, :lower16:(L__unnamed_cfstring_2-(LPC0_2+4))
LPC0_1:
	add	r1, pc
	movt	r0, :upper16:(L__unnamed_cfstring_2-(LPC0_2+4))
LPC0_2:
	add	r0, pc
	adds	r1, #5
	blx	_NSLog

Looks like this is exactly the same assembly when compiling with Release scheme instead of Debug.

Yup, because it's NSCAssert, which gets removed if using the release scheme, as it has NS_BLOCK_ASSERTIONS enabled (I hope I am right about the name).

Since it makes no difference in runtime, I see no problem to use this solution :)

Yup, there is a big difference in development though... Hopefully no developer runs ships their stuff without running it at least once, right?

@jspahrsummers are you planning to merge it?

Looks good. Sorry, this was before GitHub notified of PR changes, I think. 😅


add hello world in using racket language

thank you if you liked this project give us star to share this project to more  people


SLURM

Andreas/Sebastian please take a look!
This:
(1) adds support for the SLURM queue manager assuming that it is configured with consumable resources as commented in the code (a standard configuration profile).
We are using SLURM on our cluster so this should get extensive testing.
(2) implements site-wide configuration in /etc/cgat/. Here /etc/cgat/pipeline.ini is used for pipeline configuration, analogously /etc/cgat/scripts.ini could be used for the CGAT scripts collection.
This is needed to allow straightforward (i.e. administrator rather than user configured)  deployment of the code on foreign clusters.

Hi Steve,
Just a note to say that the '-V' option passed to SGE signifies that the current environment (i.e. the state of environment variables in the current login session) should be passed to the session on the worker node. This ensures that things like the current working dir and the contents of PATH are the same on the head node and the worker node.
I don't know if this would be necessary for SLURM.

Aha good to know, thanks - I'll amend the comment when I next commit. I understand that SLURM passes all environment variables by default - I am able to run pipelines with this code using SLURM on a test server.

Sorry, can't go through this in detail, but looks good on first view. Many thanks!
I don't think that hard-coded params should go to /etc/cgat, because cgat should in principle be runnable without having root access.

Thanks Andreas.
I would then suggest that hard coded params go to CGATPipelines/Pipelines/pipeline.ini and that these are substituted in the order:
(1) .../CGATPipelines/Pipelines/pipeline.ini
(1) /etc/cgat/pipeline.ini
(2) ~/.cgat
(3) etc
This would make it trivial for admins/users to clone the config file and amend as required site-wide or per user. How about that?

Many thanks All.
According to the documentation, the existing code already accounted for user-defined configuration files:
The order of initialization is as follows:
    1. hard-coded defaults
    2. pipeline specific default file in the CGAT code installation
    3. :file:`.cgat` in the users home directory
    4. files supplied by the user in the order given
    If the same configuration value appears in multiple
    files, later configuration files will overwrite the
    settings form earlier files.

Have you tried that, Steve?
If that did not work for you, but these amendments do, then please update the documentation of the code accordingly.
Other than that, your approach to work either with SGE or SLURM is quite nice.
Many thanks,
Sebastian.

Thanks. I think keeping a /etc/cgat.ini is fine. In addition to a user ini it will allow an admin to set site-wide preferences so users need not be aware of cluster configuration.
However, hardcoded defaults should stay within the code.


Log ignored migrations

Fixing issue #1398.
Added warning log for ignored migrations.

This fix is incorrect. It will also log when just invoking info.


Write usability tests

There is a page for end-to-end testing here:
https://github.com/NHMDenmark/Mass-Digitizer/blob/main/tests/Usability_test_procedure.md

I have a page for function testing here:
https://github.com/NHMDenmark/Mass-Digitizer/blob/main/tests/Functional_test_procedure.md

Great start! But I think they need to be more extensive and some example data to test with.

I'd say every instance where we discovere(d) a bug should be made into a functional test including sample data.

@jlegind to update this with results of functional tests

The end-to-end testing document has gotten some minor updates today. Mainly around the multi-specimen/-object radio button functionality.

@bhsi-snm Should we close this? There doesn't appear to be much action on this.

sure @PipBrewer


ClusterConnectionManager.this.getLastPartitions() appear out of memory

3.13.4

you provided a command execution timeout. I need a memory dump to check it.

I understand that the reason for the exception is that there is a problem with the redis connection，memory dump is the data stored in redis?

I used cluster mode with a total of 10 nodes and used the default configuration for the number of connections

I understand that the reason for the exception is that there is a problem with the redis connection，memory dump is the data stored in redis?

I meant JVM memory dump


Global Slot Mappings: Wrong warning for overriding custom slot mapping

Rasa Open Source version
3.0.0rc1
Rasa SDK version
3.0.0rc1
Rasa X version
No response
Python version
3.9
What operating system are you using?
OSX
What happened?
When using the FormValidationAction with a mapping of type 'custom' (see full warning on the inside) the SDK prints the warning below. It shouldn't as this is expected. Relevant code here
UserWarning: Slot 'slot1' is mapped in the domain and your custom action defines 'extract_slot1'. 'extract_slot1' will override any extractions of the predefined slot mapping from the domain. It is suggested to define a slot mapping in only one of the two ways for clarity.

Command / Request
No response
Relevant log output
No response

@wochinge  or @alwx
Does it make sense to either:
a) change the warning message and if statement so that all custom slots are defined in the domain, for example:
if extract_method and not slot_in_domain:
            warnings.warn(
                f"Slot '{slot_name}' is not mapped in the domain and your custom "
                f"action defines '{method_name}'. You must define a custom slot mapping "
                f"for slot '{slot_name}' in the domain. Please see the [docs](add link) for more information."
            )

b) remove the warning and if statement entirely, and don't replace with another warning?

@alwx Tagged you as reviewer - in the end went with option b). I don't deem the new warning vital and could potentially cause headaches for those migrating from 2.x used to the 2.x instruction to not add the custom slot mappings defined in FormValidationAction in the domain 😅 WDYT?

Closed via https://github.com/RasaHQ/rasa-sdk/pull/598


extend prompt toolkit functionality

Improve AutoHandler so the user can specify things custom completers/a list to fuzzy complete from, can create custom dialogs by passing some flags to a function
https://python-prompt-toolkit.readthedocs.io/en/master/pages/dialogs.html
https://github.com/seanbreckenridge/autotui/blob/master/autotui/namedtuple_prompt.py#L40-L44

partially added in 1180b903119fdca424c17a7cf160c401743d9828, but that requires a user completely override and write all custom prompt_toolkit code
can still improve by letting user pass list to fuzzy complete from etc...

havent really found a case where writing a complete fuzzy completer in prompt toolkit to be viable, would probably just use fzf instead
I think adding additional helpers here adds too much friction -- user has to import additional things/learn the API -- its easier to just completely overwrite the prompt function without helpers from here -- either by using input, or a third party lib like click or just writing your own prompt_toolkit validator, like I do in here


avoid almost all unwraps

~Includes #11 and #10~ avoids all unwraps

Closes #12

@drahnr Some of these were covered in https://github.com/pyroscope-io/pyroscope-rs/tree/0.3.1 but I'm yet to merge to main. Could you compare against that Branch?

Rebased and reduced.


Darwin: switch lock implementation to os_unfair_lock

pthread_mutex_t is much slower than os_unfair_lock on Darwin because (contrary to Linux) pthread_mutex_t is fair on Darwin.
We should just switch to os_unfair_lock for the Darwin versions where that's available.

os_unfair_lock will burn CPU inside ConditionLock, as there's no built-in condition support like in pthread_mutex_t. I'll make a PR and measure perf.

ConditionLock should stay on pthread, just Lock should use unfair_lock

I don't follow. ConditionLock uses Lock, which you're saying should use unfair_lock?

It does today because it made the implementation easier and ConditionLock can just reach into the implementation details of Lock. For layering reasons this isn’t ideal anyway but so far there wasn’t enough of a reason to change it.
In the future, there’s no reason that ConditionLock uses Lock internally because we can use a faster underlaying mutex for Lock (but not for ConditionLock)

I think on Darwin pthread_mutex_t is now itself backed by a os_unfair_lock but this needs to be checked. Maybe this can be closed.

This can be closed.


Three double quotes on one line results in an exception

This seems to be fixed now that the regular expressions are improved and each lexer has a fallback error entry.


Cognitive Search: Odata Filter or Search across multiple Edm.String fields in Collection(Edm.ComplexType)

I have the following Index:
{
  "value": [
    {
      "acs_index_id": "0",
      "name": "Name1",
      "application": [
        {
          "L1": "House",
          "L2": "Hospital",
          "L3": "House",
          "L4": "Church"
        },
        {
          "L1": "Dog",
          "L2": "Cat",
          "L3": "Mouse",
          "L4": null
        }
      ]
    }
  ]
}

I am able to filter across all the application/L1 using:
$filter=application/any(a: a/L1 eq 'House')
In order to search across all "L's" (L1,L2,L3,L4), I am using:
$filter=application/any(a: a/L1  eq 'House') or
            application/any(a: a/L2  eq 'House') or
            application/any(a: a/L3  eq 'House') or
            application/any(a: a/L4  eq 'House')

Questions:

Is there a more elegant way to filter across all the "L" fields? Maybe in one line?
Am I able to search across the fields or am I limited to using filter?

@dozienwankwoh, Thanks for leveraging Azure docs feedback channel to raise this question. Could you please share the Azure documentation for which this feedback is applicable to?
As a side note, this channel is reserved for ‘Azure docs’ feedback- for sharing doc feedback and suggesting content improvements.

@dozienwankwoh, Adding more:
Because the granularity of your index is at the parent level rather than the child level, currently it is not possible pull only the child item from the list.
Alternatively, you could change the granularity of your index. Another option could be to keep your existing schema and then do a second layer of filtering of the */child at the application layer, to have only required criteria to list in your application.
Quoting the response from Derek Legenzoff (from our Azure Search PG).

We don't have any immediate plans to change the way this works that I'm aware of but we're always looking to improve the product based on feedback from customers like yourself so we appreciate you sharing the feedback with us.

Kindly check this thread for similar feedback request, response from our PG and workaround that you could leverage:
[FEATURE REQ] Azure Search Working with Complex Collections]
Also checkout this doc - [Model complex data types in Azure Cognitive Search] for more info (https://docs.microsoft.com/azure/search/search-howto-complex-data-types?tabs=complex-type-portal#creating-complex-fields)

Thank you @AjayKumar-MSFT

Dozie.. 🥺
On Thu, Dec 9, 2021 at 4:16 PM dozie @.***> wrote:

Closed #85024 https://github.com/MicrosoftDocs/azure-docs/issues/85024.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/85024#event-5741565841,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWIOIMSR55LGPMM3VYJLUALUQDB3ZANCNFSM5JU6FKVQ
.

Wow, I am surprised people are keeping track of closed issues @AjayKumar-MSFT :)
I am in the same boat. The problem is our schema is it is very tough to change the granularity of our index. Secondly, having a second filter at the application level doesn't make much sense too. Considering the index has around a million documents, if we first check at index level whether any document has particular child element(s) which fulfill the search criteria, then return all such parent documents in Search response and then do a further filter into all those child elements again. This doesn't sound optimized experience.
I am all ears for thoughts :)

Wow, I am surprised people are keeping track of closed issues @AjayKumar-MSFT :)
I am in the same boat. The problem is our schema is it is very tough to change the granularity of our index. Secondly, having a second filter at the application level doesn't make much sense too. Considering the index has around a million documents, if we first check at index level whether any document has particular child element(s) which fulfill the search criteria, then return all such parent documents in Search response and then do a further filter into all those child elements again. This doesn't sound optimized experience.
I am all ears for thoughts :)

Thanks for sharing more details about your requirement. As soon as we hear more info on this, we will share it here. Thanks for your patience!

definitely need this feature!

Definitely need this feature!


chore: Reason only in terms of NodePools in the scheduler

Fixes #N/A
Description
Drops the need for having two separate arguments in the scheduler, one for NodePools and the other for NodeClaimTemplates
How was this change tested?
make presubmit
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

13 of 13 (100.0%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.04%) to 81.007%

Files with Coverage Reduction
New Missed Lines
%

pkg/test/expectations/expectations.go
2
95.96%

Totals

Change from base Build<PHONE_NUMBER>:
-0.04%

Covered Lines:
8155

Relevant Lines:
10067

💛  - Coveralls


Allow to customise cache file path

This change allows to customise file path for database cache. The default location remains the same.
The main motivation for this change is the scenario, where remote database is used. If the download fails on first download attempt, there is no fallback. Being able to customise file path allows to ship some fallback database with a release and easily point to it. The default location, which is user_cache dir, is harder to provision.

Applied review suggestions - requesting a review again.


does not work in vivaldi

does not work in vivaldi a chromeium based browser
it would be helpful if this would work in brave also

@hackathoner @zachallett @wijagels


Decouple from smol async runtime

The ublk_wait_and_handle_ios function has a hard dependency on smol for its async runtime. Is this necessary or can libublk be implemented independently of any particular runtime? I'd like to use tokio or monoio for my runtime and would prefer to avoid bloating my binary.
pub fn ublk_wait_and_handle_ios(exe: &smol::LocalExecutor, q: &UblkQueue) {
    loop {
        while exe.try_tick() {}
        if q.flush_and_wake_io_tasks(|data, cqe, _| ublk_wake_task(data, cqe), 1)
            .is_err()
        {
            break;
        }
    }
    q.unregister_io_bufs();
}

The UblkQueue also can't be shared across threads. Is there guidance on how to build a multi-threaded ublk device? Or is that explicitly not supported for a reason?

The ublk_wait_and_handle_ios function has a hard dependency on smol for its async runtime. Is this necessary or can libublk be implemented independently of any particular runtime? I'd like to use tokio or monoio for my runtime and would prefer to avoid bloating my binary.

I think that is definitely reasonable to not let libublk not bind with
smol, and so far looks it is just for example code.
I will think a bit and try to move it into the rublk code.
Then smol will become invisible for this library.
Thanks,

The UblkQueue also can't be shared across threads. Is there guidance on how to build a multi-threaded ublk device? Or is that explicitly not supported for a reason?

So far, UblkQueue can't cross threads, that is also what the ublk driver is implemented.
But we are considering to try to relax this limit, please see the following
discussion:
<EMAIL_ADDRESS>


using messageWithIdentifier initializing with transitingType always nil

Hi guys,
I am using your nice library to communicate watchOS and iOS, I did use it before for watchOS 1 and no problems at all, but now trying to handle from watchOS 2 on I am facing something weird.
If I initialize with:
 self.wormhole = [[MMWormhole alloc]<EMAIL_ADDRESS>                                                        optionalDirectory:@"x"                                                             transitingType:MMWormholeTransitingTypeSessionContext];
and then
id messageObject = [self.wormhole messageWithIdentifier:@"identifier"];
the messageObject is nil always when the app is awaking with context even if I opened the app on iOS before and initialize this identifier. Interesting enough is if I open the app on iOS and make a change on this identifier, then the listener is called right and showing me the changes with this code below (so I guess all the configuration is ok for the group ids and so on):
[self.listeningWormhole listenForMessageWithIdentifier:@"identifier" listener:^(id messageObject) {             NSString * var =  messageObject;              if (var != nil) {             NSLog(@"Listening from phone%@", var);         }       }];
Seems like the initialization with transitionType (If I got it right is the new way for watchOS 2 ) is not reading the value directly but only with the listener. In this case I cannot initialize values, I have to modify and then the listener is called. Your example also does the same for me on my machine.
Perhaps I got it wrong and this new transitionType is only for messaging with listener and to initialize I need the old way of wormhole (traditional one). But then I don't understand why in your example is done like this.
Thanks ! and keep making good things !
Maxi

Hey Maxi,
There are a few reasons why this might be the case. It's possible that when the watch app starts up, it hasn't yet received an updated "Application Context" from the WatchConnectivity framework. If you want to test this out, just ask the WCSession.defaultSession for the current application context after checking the wormhole's messageWithIdentifier.
If the application context is nil, or it's contents are empty, then that's why the wormhole is returning no value - because nothing has been delivered yet.
If the application context is not nil, and has valid contents...but the wormhole is still returning no value, then I would like to know, because that's definitely a bug :)
Unfortunately it's just kind of hard to tell exactly why without checking WatchConnectivity, because the whole feature is built on WatchConnectivity and there can be a lot of reasons why WatchConnectivity's content hasn't updated yet.
Curious what you find out.
Thanks,

Conrad

Hi @cnstoll,
I am back developing this code again and finally I could make it work on the watch side. Problem was that I was trying to access to the message before activating the session listening.
Interesting now is the watch is working with:
[self.watchConnectivityWormhole messageWithIdentifier:@"whatever"];
and also:
[self.listeningWormhole listenForMessageWithIdentifier:@"shoppingLists" listener:^(id messageObject)]
so perfect. But again I have exactly the same code like on the watch, on my iOS side and if it is working only with the listener but not with messageWithIdentifier. So the listener is being called when I change something on the watch with a certain identifier, but when I try to access normally to the same identifier through
[self.iOSConnectivityWormhole messageWithIdentifier:@"whatever"];
then is returning nil for the same identifier that was called on the listener. :-O
When I debug your library and get into the code of the method messageObjectForIdentifier, I see that this line is returning empty dictionary. Is that ok ?
NSDictionary *receivedContext = self.session.receivedApplicationContext;
the session is ok but the received context is empty, if I understand correctly, this context should contain the latest data that I sent from the watch part, right? Am I missing anything ? or misunderstanding ?
I hope you can help my out
Thanks !
Maxi


Heatmap with prettified names?

Hi @sbslee ,
Thanks for your very recent updates to heatmap (from clustermap) - just in time for what I need. Just wondering how I could incorporate your 'prettified names' function - to get taxa names as the y-axis labels such as is possible in the legend of the taxa_abundance_bar_plot output?
Thanks,
Michelle

@mishkb,
Thanks for the great suggestion! I just added the pretty_taxa argument to the heatmap method in the 1.11.0-dev branch (the official release of 1.11.0 will be made within 10 days; I aim to make a Dokdo release every month). When you set pretty_taxa=True it will display only the smallest taxonomic rank like how it's done in the taxa_abundance_bar_plot method with the legend_short argument:
import dokdo
import matplotlib.pyplot as plt
%matplotlib inline
import seaborn as sns
sns.set()

fig, [ax1, ax2] = plt.subplots(1, 2, figsize=(15, 7))

qza_file = '/Users/sbslee/Desktop/dokdo/data/moving-pictures-tutorial/table-l3.qza'

dokdo.heatmap(qza_file,
              normalize='log10',
              flip=True,
              ax=ax1)

dokdo.heatmap(qza_file,
              normalize='log10',
              flip=True,
              pretty_taxa=True,
              ax=ax2)

plt.tight_layout()
plt.savefig('heatmap.png')

Is this what you had in your mind? Let me know if you need more help.

This is wonderful - thanks for your prompt response. Based on your figures, this is just what I was looking for.  I'll give it a whirl today.

OK @sbslee ,I've been able to implement that new function - thank you! Now I'm wondering...

is possible to change the x-label to another label from the metadata file (e.g. at the moment the heatmap uses the first column as the label [#Sample_ID or similar], but I'd like to use an alternate column i.e. Sample_name.
Is it possible to control the number of taxa that are plotted in the heatmap? I'd really only like to visualize to top taxa (20-50 say), as is possible for the taxa_abundance_bar_plot

Michelle

@mishkb,
Thanks for the great ideas. I think I can implement both fairly easily, but let's take one step at a time. I just added the label_columns parameter to the dokdo.heatmap method. It works the same way as it does for the dokdo. taxa_abundance_bar_plot  method.
import dokdo
import matplotlib.pyplot as plt
%matplotlib inline
import seaborn as sns
sns.set()

fig, [ax1, ax2] = plt.subplots(1, 2, figsize=(15, 7))

qza_file = '/Users/sbslee/Desktop/dokdo/data/moving-pictures-tutorial/table-l3.qza'
metadata_file = '/Users/sbslee/Desktop/dokdo/data/moving-pictures-tutorial/sample-metadata.tsv'

dokdo.heatmap(qza_file,
              metadata=metadata_file,
              normalize='log10',
              flip=True,
              pretty_taxa=True,
              ax=ax1)

dokdo.heatmap(qza_file,
              metadata=metadata_file,
              normalize='log10',
              flip=True,
              pretty_taxa=True,
              label_columns=['sample-id', 'body-site'],
              ax=ax2)

plt.tight_layout()

If you are happy with above, we can move on to the next (i.e. showing top taxa). Let me know what you think.

Works exactly as I was hoping - thanks @sbslee!
Does the heatmap function automatically align labels vertically or horizontally depending on the figure size/space available? (I think I have to look more at the plt.tight_layout() function and matplotlib.

@mishkb,
Glad to hear that works for you. As for the rotation of tick labels, AFAIK, it is automatically determined by the seaborn.heatmap method (which is used by dokdo.heatmap). BTW, you can easily change the rotation of tick labels in the following way:
ax = dokdo.heatmap(...)

for ticklabel in ax.get_xticklabels():
    ticklabel.set_rotation(90)

It sounds like we are good to move on to the next task: showing only the top taxa. Stay tuned.

@sbslee I have just realised the 'prettified names" function actually truncates species names to just show the s__name, not g__Genus; s__species name. I just noticed this in the taxa_abundance_bar_plot plot and obviously, it also is the same now in heatmaps if I use that option.
Is there a way to return the last two ranks - so in your example,

a = 'd__Bacteria;p__Actinobacteriota;c__Actinobacteria;o__Actinomycetales;f__Actinomycetaceae;g__Actinomyces;s__Schaalia_radingae'

print(dokdo.pname(a))
g__Actinomyces;s__Schaalia_radingae

I am using taxonomy from NCBI that separates the genus names and species names - so with the 'prettified names', it is impossible to tell which genus the species come from.
(BTW, I can make this a separate issue if that is better).

@mishkb,
No worries about opening another issue. And thanks for the great suggestion. I myself have come across that issue before. The good news is I just updated the pname method to allow returning of more than one taxonomic rank:
import dokdo
import matplotlib.pyplot as plt
%matplotlib inline
import seaborn as sns
sns.set()

a = 'd__Bacteria;p__Actinobacteriota;c__Actinobacteria;o__Actinomycetales;f__Actinomycetaceae;g__Actinomyces;s__Schaalia_radingae'
dokdo.pname(a)

Will produce the usual:
's__Schaalia_radingae'

However, if you provide the levels option:
a = 'd__Bacteria;p__Actinobacteriota;c__Actinobacteria;o__Actinomycetales;f__Actinomycetaceae;g__Actinomyces;s__Schaalia_radingae'
dokdo.pname(a, levels=[6, 7])

It will give what you want:
'g__Actinomyces;s__Schaalia_radingae'

I extended this to the heatmap and taxa_abundance_bar_plot methods by adding the pname_kws argument to both methods:
fig, [ax1, ax2] = plt.subplots(1, 2, figsize=(15, 7))

qza_file = '/Users/sbslee/Desktop/dokdo/data/moving-pictures-tutorial/table-l3.qza'

dokdo.heatmap(qza_file,
              normalize='log10',
              flip=True,
              ax=ax1)

dokdo.heatmap(qza_file,
              normalize='log10',
              flip=True,
              pretty_taxa=True,
              pname_kws=dict(levels=[2, 3]),
              ax=ax2)

plt.tight_layout()

qzv_file = '/Users/sbslee/Desktop/dokdo/data/moving-pictures-tutorial/taxa-bar-plots.qzv'
dokdo.taxa_abundance_bar_plot(qzv_file,
                              figsize=(10, 7),
                              level=6,
                              count=8,
                              legend_short=True,
                              pname_kws=dict(levels=[5, 6]),
                              artist_kwargs=dict(show_legend=True,
                                                 legend_loc='upper left'))
plt.tight_layout()

Updated documentations:
pname: https://dokdo.readthedocs.io/en/1.11.0-dev/dokdo_api.html#module-dokdo.api.pname
heatmap: https://dokdo.readthedocs.io/en/1.11.0-dev/dokdo_api.html#heatmap
taxa_abundance_bar_plot: https://dokdo.readthedocs.io/en/1.11.0-dev/dokdo_api.html#taxa-abundance-bar-plot
Does this work for you?

That looks great to me @sbslee - I hope yourself and others will find it useful as well. I really appreciate you making these adjustments and answering my questions.

@mishkb,
No problem! I also added the count argument to the heatmap method; it's similar to the count argument in the taxa_abundance_bar_plot  method:
import dokdo
import matplotlib.pyplot as plt
%matplotlib inline
import seaborn as sns
sns.set()

fig, [ax1, ax2] = plt.subplots(1, 2, figsize=(15, 7))

qza_file = '/Users/sbslee/Desktop/dokdo/data/moving-pictures-tutorial/table-l3.qza'
metadata_file = '/Users/sbslee/Desktop/dokdo/data/moving-pictures-tutorial/sample-metadata.tsv'

dokdo.heatmap(qza_file,
              metadata=metadata_file,
              normalize='log10',
              flip=True,
              pretty_taxa=True,
              ax=ax1)

dokdo.heatmap(qza_file,
              metadata=metadata_file,
              normalize='log10',
              flip=True,
              pretty_taxa=True,
              count=20,
              ax=ax2)

plt.tight_layout()

Let me know if this is what you wanted.

Fantastic @sbslee! This has worked perfectly with my data. Thank you again for adding those options to your code. I'm so grateful that I found Dokdo and that you are still actively working on it.


:sparkles:  Java provider as external provider

Closes #469

@shawn-hurley Dep analysis seems to be working

I assume that the removal of the dep code snip is failing the e2e tests. I think that we may not be able to make this change as a follow up.


[Refactor] Follow Proper Naming Conventions

Use snake_case (lowercase with underscores) for libraries, directories, packages, and source files.
Start private variable names with underscores.
Use lowerCamelCase for constants, variables, parameters, and named parameters.
Use UpperCamelCase for classes, types, extension names, and enums.

heya @a-mabe are you looking for support on this issue still?

Sure thing @a-mabe please assign it to me.
How would you like the methods and functions named?

Thank you @alastairrmcneill, I have assigned the issue to you. Please name methods and functions using lowerCamelCase


56389 - [Issue 183] Background activity dialog

I added background activity dialog, which asks user whether to turn off battery life optimisation for Smittestopp app. I used a default Android App AlertDialog, which I implemented in uncalled method ShowBackgroundActivityDialog in InfectionStatusActivity. Screenshot of the dialog below. Texts are only in English.

And what with "Do not ahow again" option?

So this button should close and never show dialog to a user.

The buttons on the dialog should probably have the same color as the rest of the dialog buttons in the app.

Ok I will change that.

Agree with Kamil should probably be "No, and do not show again" - since the other formulation might be confusing - also I do not think the dialog should be shown again after an update of the app, if the user has pressed "No, and do not show again" before, if it is possible.

Yes, you are right. I will implement that.


angular-meteor and autoform

Hi there,
I'm not new to angular but to angular and meteor. I have a simple app running and I've defined a model that I successfully generated a form for using aldeed:meteor-autoform. I can use this form to insert items into my collection. This all works perfectly fine.
BUT, I have no clue how I can show values that already exist in my collection inside an autoform. Here's an example that works if you only have meteor.
In my simple application I've generated list and details page for books using the angular-meteor package. Therefore the object that I want to show inside of the autoform is available in my details controller like this:
$scope.book = $meteor.object(Books, $stateParams.dockerhostId);

How can I get $scope.book inside an autoform template that looks like this:
  {{#autoForm collection="Books" type="update" id="booksUpdateForm"}}
      {{> afFormGroup name="name" template="bootstrap3-horizontal" label-class="col-sm-3" input-col-class="col-sm-9"}}
  {{/autoForm}}

Thank you in advance!
-Konrad

Hi,
I've found this way, although it seems to fetch the document from MongoDB twice, doesn't it?. In my controller I use the Template.MY_AUTOFORM_ID.helpers(MY_OBJECT) function to register a variable that I can use in the {{#autoForm}} template:
book-detail.controller.ng.js:
'use strict'

angular.module('myapp')
  .controller('BookDetailCtrl', function ($scope, $stateParams, $meteor) {
    $scope.book = $meteor.object(Books, $stateParams.booksId);
    $meteor.subscribe('books');

   Template.booksUpdateForm.helpers({
      selectedBookDoc: function () {
       // This fetches the object from MongoDB again.
        return Books.findOne({_id: $stateParams.dockerhostId});      }
    });

   $scope.save = function () {
      if ($scope.form.$valid) {
        $scope.book.save().then(
          function (numberOfDocs) {
            console.log('save successful, docs affected ', numberOfDocs);
          },
          function (error) {
            console.log('save error ', error);
          }
        )
      }
    };

    $scope.reset = function () {
      $scope.book.reset();
    };
  });

book-detail.html (Note new doc=selectedBookDoc):
  {{#autoForm collection="Books" type="update" id="booksUpdateForm" doc=selectedBookDoc}}
      {{> afFormGroup name="name" template="bootstrap3-horizontal" label-class="col-sm-3" input-col-class="col-sm-9"}}
  {{/autoForm}}

I know it works but can this be improved somehow or is it bad practice in any sense?
Thanks in advance.

I quickly looked at the autoform package. To me it reads: form package for people who do not use angular. automatic insert and update and even advanced validations are so well supported in Angualr, that for me using this package with angular sounds like a reciepe for troubles. Just my 2c.

Hi Tally, thanks for replying. What would you recommend for validation?
Another package maybe or just plain angular? Autoform does this all based
on the model so it's pretty convenient to use.
2015-06-19 18:11 GMT+02:00 Tally Barak<EMAIL_ADDRESS>
I quickly looked at the autoform package. To me it reads: form package for
people who do not use angular. automatic insert and update and even
advanced validations are so well supported in Angualr, that for me using
this package with angular sounds like a reciepe for troubles. Just my 2c.
—
Reply to this email directly or view it on GitHub
https://github.com/Urigo/angular-meteor/issues/450#issuecomment-113560878
.

Any specific use cases?
Angular has really good mechanism on input + formatting + validation

@kwk look at the example in meteor-include API:
http://angular-meteor.com/api/meteor-include#usingangularscopeinsidemeteortemplate
Let me know if getting the scope inside the template helps

Hi all,
Have you checked angular formly? If you are using angular, it seems
appropriate to use it. I see fomly as the autoform package but written for
angular.
For validation, I think collection2 (plus simple-schema) maybe an awesome
choice.
Bye ...
On Sun, Jun 21, 2015 at 2:55 PM, Uri Goldshtein<EMAIL_ADDRESS>wrote:

@kwk https://github.com/kwk look at the example in meteor-include API:
http://angular-meteor.com/api/meteor-include#usingangularscopeinsidemeteortemplate
Let me know if getting the scope inside the template helps
—
Reply to this email directly or view it on GitHub
https://github.com/Urigo/angular-meteor/issues/450#issuecomment-113945590
.

@Urigo thank you, your' example helped a lot.
@mgrivera thank you.

@kwk where should you put your collections in your app directory structure (for security)?

Also, I'm not sure how to convert the meteor code to AngularJS-Meteor compatible code:
For:

                       <template name="insertBookForm">

                          {{> quickForm collection="Books" id="insertBookForm" type="insert"}}
                        </template>

I tried:

                       <template name="insertBookForm">

                          <meteor-include src="quickForm" collection="Books" id="insertBookForm" type="insert"></meteor-include>
                        </template>

I have an idea that the template is probably not being parsed by Angular-Meteor (because the filename ends in .ng.html), but not sure of the syntax to use as the docs I've looked at don't cover an alternate syntax for Blaze templates https://www.meteor.com/tutorials/blaze/templates

One last question, is there any way I can pass the hook for the submitted form back to Angular's scope? I'd like to keep as much Blaze/Meteor out of the project as possible, outside of the stack.
I'm pro bono consulting for a non-profit and have a Meetup.com group that may be helping out on Tuesday. The hackathon will be only 2.5 hours, so I'd rather stick to Angular because I won't have time to ramp up people on the Meteor aspects.

I generally went with the directory structure generated by yeoman. You might want to give it a try and see how yeoman lays out the structure in a fresh project:
npm install -g yo
npm install -g generator-angular-meteor
yo angular-meteor appName

I've put the meteor template files right next to *.ng.html files.
I'm sorry but I cannot tell out of my mind how to pass the hook back to angular.

Great, thanks!

I thought about it for a bit and as far as the autoform speaking to angular, I think I could do a Meteor.call() and somehow get the data to Angular that way.
But on a side note, I'm starting to think this is a bit too much work, though. I don't see why Angular-Meteor is better than just using a MEAN stack. I need to be able to hand off this application to the non-profit, and I think they're going to keep coming back to me as there is compounding complexity here of talking between Meteor/Angular that's not covered in the tutorials.
For my personal tastes, it's pretty great, as I like both Meteor (so far) and AngularJS, but maybe not for this project. I've got alot to think about as I'm going to involve other devs who are volunteering their free time to join.

hey @kwk, how did you solve this at the end? I'm having the same issue whether I can only retrieve the working object to be updated using the helper (as you did in you original example). Any hint?
/* book-detail.html */
<template name="bookDetailTemplate">
    {{> quickForm collection="Books" id="updateBook" doc=book type="update"}}
</template>

/* book-detail.ng.html */
<meteor-include src="bookDetailTemplate"></meteor-include>

/* book-detail.ng.js */
angular.module("myapp").controller("BookDetailCtrl",
    function($scope, $stateParams, $meteor){

        $scope.book = $meteor.object(Books, $stateParams.bookId);

        Template. bookDetailTemplate.helpers({
            book: function () {
                return Books.findOne({_id: $stateParams.bookId});
            }
        });
    }
);


Clarification needed between "alev1" and "alevel" coordinates

I have noted that many of the CMIP6 tables include reference to an alevel coordinate that does not exist in the CMIP6_coordinate.json. This search shows the occurrences of alevel:
https://github.com/PCMDI/cmip6-cmor-tables/search?utf8=✓&q="alevel"
In the following coordinate JSON file there is a definition of the coordinate alev1:
https://github.com/PCMDI/cmip6-cmor-tables/blob/master/Tables/CMIP6_coordinate.json
The alev1 coordinate does not appear to be referenced by any variable definitions - see the following search results:
https://github.com/PCMDI/cmip6-cmor-tables/search?utf8=✓&q="alev1"
I am guessing that the definition of alev1 in the CMIP6_coordinate.json file should be changed to alevel.
Please have a look. Thanks, Ag

alevel is not a real coordinate (dimension).
See the following example test_python_jamie_6.py.  In this example  axis alevel is declared as hybrid_height which is defined int he CMIP6_coordinates.json file.
This alevel dimension also contains formula terms defined in CMIP6_formula_terms.json

Hi @dnadeau4, Having discussed it with my colleagues we now understand what is going on here. Thanks for your response. Closing this one now :-)


Fix physical bones positions when creating physical skeleton for GLTF

Fix physical bones positions when using Create physical bones to generate the bones.
To fix the issue, the physical bone origin is computed using the bone_rest origin vector, and rotation is fixed by changing the collision shape child (this avoid physics engine issue).
Tested on GLTF and DAE models, but not FBX.
Issue linked: https://github.com/godotengine/godot/issues/39757
Test project: testSkeleton-godot3-2.zip
Contains GLTF and DAE (and their blender files).
To test, open some scene Scenery/****DAE.tscn or ****GLB.tscn, erase the physical bones, and recreate them using Create Physical Skeleton

Before the patch: OK with DAE, FAILED with GLTF
After the patch: OK for both

If you post a test project I can make sure it's reviewed faster.

Good idea, thank you, it is my first PR. I will prepare very soon a project with different models to test, including your models and my own where I also met the issue. After that, ok for a PR for Godot 4

Test project is now added to the first comment

Create Physical Skeleton is also broken in Godot 4 indeed. Should I create a separate issue for 4.0 or this issue could be shared?

You can create a new pr for master, but we can't test the change..

You can create a new pr for master, but we can't test the change..

It is our policy to create a pr for master first.
I'll try to find effort to do a Godot Engine PR for fixing physical bone positions, or if you want to create a pr -- Shout!

Oh sorry about that, at that time I tried to fix the bug also for Godot 4.0 but applying the same changes as Godot 3.x did not work. I should give a try again

Well, I need to close this PR, since I have stupidly deleted the branch some weeks ago...

@Blackiris I've not tried it, but it should be possible to recover your deleted branch: https://garrytrinder.github.io/2020/05/recover-pr-after-accidentally-deleting-source-branch

@madmiraal Thanks a lot, no worry, I have already prepared another branch for Godot 3.x. Currently there is a PR for Godot 4.0 (https://github.com/godotengine/godot/pull/48310), but cherry-picking won't work here since the filename has changed (skeleton_editor_plugin.cpp to skeleton_3d_editor_plugin.cpp).
Once the PR for 4.0 is validated I will finish the one for 3.X


From Meteor reactivity to view through method callback

Hi all!
I need to show/use in view some data resulting from the execution of a Meteor method (async), the latter fired by a change in mongo collection. (If a document change, then I can see evidence in another browser tab).
First I used simple scope variable

angular.module 'trackerApp'
.controller 'UsersCtrl', ($scope) ->

  $scope.usersClosed = []

  $scope.getClosed = () ->
    Meteor.call('reports.getClosed', (error, result) ->
      if !error
        $scope.usersClosed = result
    )

but assignment in callback function doesn't render again the view.
So I decided to use helper variable

  $scope.helpers({
    usersClosed: []
  })

It works fine, but in client console appear some warnings like:
defining 'usersClosed' value helper, note that this feature will be deprecated in 1.4 in favor of using 'getReactively' - http://www.angular-meteor.com/api/1.3.1/get-reactively
After that I moved to a helper function

  $scope.helpers({
    usersClosed: () ->
      $scope.getReactively('xyz')
  })

It never works.
Why it doesn't? Isn't $scope made reactive by default?
(You can find more explanation in #1110; I tried also to use $reactive(this).attach($scope) )
Let's look handling of collection changes. I tried two way:

observer

  $scope.getClosed = () ->
    Meteor.call('reports.getClosed', (error, result) ->
      if !error
        $scope.usersClosed = result
    )
  $scope.getClosed()
  Reports.find().observeChanges(
    added: (id, fields) ->
      $scope.getClosed()
    changed: (id, fields) ->
      $scope.getClosed()
    removed: (id) ->
      $scope.getClosed()
  )

autorun

  $scope.autorun (computation) ->
    Reports.find()
    Meteor.call('reports.getClosed', (error, result) ->
      if !error
        $scope.usersClosed = result
    )

Only the first one works, but it's quite annoying.
Why autorun doesn't react to collection changes? Isn't autorun a reactive context and collection a reactive source?
The full example code is here. (Remember to keep open all the three pages to verify reactivity)

PS: An alternative to first part could be use Session

$scope.helpers({
    usersClosed: () ->
         Session.get('xyz')
  })

$scope.getClosed = () ->
    Meteor.call('reports.getClosed', (error, result) ->
      if !error
        Session.set('xyz', result)
    )

, even if it seems to be concerning session of user (I don't feel confident to use it).

The reason the callback doesn't rerender the view is because $scope.$digest is not running after the callback. Read my comment here.
I'm not sure what you tried to do next, so I hope this solves your problem.

@ozsay Thank you for your answer!
About autorun:
Can it be used like tracker autorun? - ...you can monitor a cursor (which is a reactive data source).. -
Because code below doesn't work

$scope.autorun (computation) ->
    Reports.find()
    Meteor.call('reports.getClosed', (error, result) ->
      if !error
        $scope.usersClosed = result
    )

No unfortunately it can't, since a result of a meteor method is not a reactive data source.
In 1.3.6 There will be an api for making this:
for example:
myModule.controller('MyCtrl', ['$scope', '$reactive', function($scope, $reactive) {
  $reactive(this).attach($scope);

  this.call('reports.getClosed', (error, result) => {
      if !error
        $scope.usersClosed = result
    });
}]);

I'm closing since the API has been added.

Can't wait to use the new api. I am running in some reference issue with executing a Meteor.call.
In my callback success, the this doesn't reference back to the this before the Meteor call.
So I can't stop a spinner from spinning for example. The new Api would hopefully fix this?

@mattiLeBlanc just use a variable for that, example:
var ctrl = this;

// something here...

Meteor.call('somemethod', (err, res) => {
	ctrl.spinner = false;
});

You would think so. However it lost its reactivity. So update of variable doesn't work it's way back up
So I need to kick the baby somewhere.

Can't say without seeing your code, but I use this all the time for spinners and similar without issue.
Are you using scope directly or attaching the scope to this?

class xCtrl {
  private process: boolean = false;

  constructor( private $scope: any ) {
    $reactive(this).attach($scope);
  }

  aFunction() {
      var that = this;
      this.processing = true;

      Meteor.call( 'invoice.credit', function( error, result ) {
        console.log(that);
        if ( error ) {
          that.$log.error( error );
        }
        that.processing  = false;
        that.success     = true;
        that.$scope.$apply();
      } );
  }
}

This is not my full class of course. But the point is that in the callback I need to execute apply to make it update.
Running Angular Meteor 1.3.5 on TypeScript compiler

Hmm, I don't usually work with TypeScript, but maybe it could be related with how the code is translated to JavaScript.
What does it log for "that"?
If I was to write that in JS I would do it like this, which is what I usually use and usually works for me:
function ($scope, $reactive) {
	const that = this;

	$reactive(this).attach($scope);

	this.processing = false;
	this.success = false;

	this.aFunction = () => {
		this.processing = true;

		Meteor.call('invoice.credit', (error, result) => {
			console.log(that);

			if (error) {
				that.success = false;
			} else {
				that.success = true;
			}
			that.processing = false;
		} );
	};
}

That would be the this object. So setting the var works as a workaround for now. Maybe it is the compiler (pbastowski:typescript). Maybe not.

I hadn't noticed before that you mentioned that calling the $scope.$apply() made it work for you.
I still think it's a bit strange you need to call $apply() for it to work, but at least you got it working.

Yes, it strange. It think it is somehow cut of from angulars 2 way binding? Or just running after the digest maybe. Cause it is an async call.

Seriously...it stopped working and I tried $digest which no works....I am a bit scared of this behaviour.

<EMAIL_ADDRESS>was released.
Please check the new this.call to see if that works for you.

Yep, it seems to have been resolved. Thank you!

facing same issue:
https://github.com/Urigo/angular-meteor/issues/1116#issuecomment-175592538


Specifics for debugging: Cannot use 'in' operator to search for 'attachments' in undefined

I tried using my SNU moodle account to fetch documents. But I am prompted with the following error.

I used this URL: https://lms.snuchennai.edu.in/ after selecting Custom backend

This should be fixed now - It was caused by minor differences in the LMS systems of SSN and SNU.
Check now, and do let me know if it persists, and feel free this issue if it doesn't!

Awesome, It works.
I am closing this issue.


Allow to source for multiple times

stream
  .source('*.js', { baseDir: './foo' })
  .source('*.css', { baseDir: './bar' })

IssueHunt Summary

Sponsors (Total: $100.00)

 issuehunt ($100.00)

Become a sponsor now!
Or submit a pull request to get the deposits!
Tips

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on IssueHunt to raise funds.

@issuehunt has funded $100.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

Hi I'm sure I really need this 😅I would merge if I find a use case.

Can I get the bounty for the work done?

I basically need 100 USD for tomorrow

If I fix other prs, will I get paid for them within reasonable time frame, I assume you have about as much time on your hands as I do. I also feel like because there's a bounty on this issue it's a waste to just let it sit until a use case is found.


DVAS-1236: Fix guess_java_version function for Java 11.

Add unit tests to cover all of the strange legacy edge cases.
Refactor a little to make the function more unit testable.

@markbastiaans - would you mind taking a look here too, please? Thank you in advance!

Release Notes:
This release contains a bug fix in the m2ee library.
Bug fix addresses the java version detection logic mainly to account for the JDK version-string scheme changes introduced as per JEP-223