Daemon crash after restarting process on MacOS 10.14.5

Computer went to sleep when it woke up I restarted the daemon to continue sync and it crashed with the following
{"timestamp":"2019-08-08 10:36:39.328278Z","level":"Debug","source":{"module":"Coda","location":"File "src/app/cli/src/coda.ml", line 477, characters 63-70"},"message":"Long async cycle: $span milliseconds","metadata":{"pid":39230,"span":"9.544557s"}}
{"timestamp":"2019-08-08 10:36:39.335695Z","level":"Trace","source":{"module":"Coda","location":"File "src/app/cli/src/coda.ml", line 533, characters 64-71"},"message":"Creating database of type $typ in directory $directory","metadata":{"directory":"/Users/paul/.coda-config/receipt_chain","pid":39230,"typ":"receipt_chain_database"}}
{"timestamp":"2019-08-08 10:36:39.342423Z","level":"Trace","source":{"module":"Coda","location":"File "src/app/cli/src/coda.ml", line 541, characters 62-69"},"message":"Creating database of type $typ in directory $directory","metadata":{"directory":"/Users/paul/.coda-config/transaction","pid":39230,"typ":"transaction_database"}}
{"timestamp":"2019-08-08 10:36:54.742969Z","level":"Debug","source":{"module":"Kademlia__Membership","location":"File "src/lib/kademlia/membership.ml", line 254, characters 64-71"},"message":"Process $process does not exist, won't kill","metadata":{"pid":39230,"process":"16276"}}
{"timestamp":"2019-08-08 10:36:54.743387Z","level":"Debug","source":{"module":"Kademlia__Membership","location":"File "src/lib/kademlia/membership.ml", line 191, characters 56-63"},"message":"Kademlia command-line arguments: $argv","metadata":{"argv":["test","<IP_ADDRESS>","("<IP_ADDRESS>", 8303)","("<IP_ADDRESS>", 8303)"],"pid":39230}}
{"timestamp":"2019-08-08 10:36:54.749179Z","level":"Info","source":{"module":"Transition_router","location":"File "src/lib/transition_router/transition_router.ml", line 98, characters 53-60"},"message":"Starting Bootstrap Controller phase","metadata":{"pid":39230}}
{"timestamp":"2019-08-08 10:36:54.749479Z","level":"Debug","source":{"module":"Network_pool__Transaction_pool","location":"File "src/lib/network_pool/transaction_pool.ml", line 224, characters 69-76"},"message":"no frontier","metadata":{"pid":39230}}
{"timestamp":"2019-08-08 10:36:54.749522Z","level":"Debug","source":{"module":"Network_pool__Transaction_pool","location":"File "src/lib/network_pool/transaction_pool.ml", line 224, characters 69-76"},"message":"no frontier","metadata":{"pid":39230}}
{"timestamp":"2019-08-08 10:36:54.750066Z","level":"Info","source":{"module":"Coda_lib","location":"File "src/lib/coda_lib/coda_lib.ml", line 150, characters 63-70"},"message":"Coda daemon is now connecting","metadata":{"pid":39230}}
{"timestamp":"2019-08-08 10:36:54.750151Z","level":"Info","source":{"module":"Proposer","location":"File "src/lib/proposer/proposer.ml", line 224, characters 57-64"},"message":"Pausing block production while bootstrapping","metadata":{"pid":39230}}
{"timestamp":"2019-08-08 10:36:54.750212Z","level":"Trace","source":{"module":"Web_pipe","location":"File "src/app/cli/src/web_pipe.ml", line 122, characters 58-65"},"message":"Not running a web client pipe","metadata":{"pid":39230}}
{"timestamp":"2019-08-08 10:36:54.750287Z","level":"Info","source":{"module":"Coda","location":"File "src/app/cli/src/coda.ml", line 600, characters 56-63"},"message":"Daemon ready. Clients can now connect","metadata":{"pid":39230}}
{"timestamp":"2019-08-08 10:36:59.780452Z","level":"Error","source":{"module":"Kademlia__Membership","location":"File "src/lib/kademlia/membership.ml", line 277, characters 65-72"},"message":"Kademlia stderr output: All peers failed to","metadata":{"pid":39230}}
{"timestamp":"2019-08-08 10:36:59.780555Z","level":"Debug","source":{"module":"Kademlia__Membership","location":"File "src/lib/kademlia/membership.ml", line 303, characters 64-71"},"message":"Creating instance","metadata":{"kademlia_level":"DBUG","pid":39230}}
{"timestamp":"2019-08-08 10:36:59.780577Z","level":"Debug","source":{"module":"Kademlia__Membership","location":"File "src/lib/kademlia/membership.ml", line 303, characters 64-71"},"message":"Attempting to connecting to peer: \"<IP_ADDRESS>\":8303, \"nvs0lNH8gOlIewTboq/+CA90mNp+UR6Hz0K0dERMxxY=\"","metadata":{"kademlia_level":"DBUG","pid":39230}}
{"timestamp":"2019-08-08 10:36:59.780599Z","level":"Debug","source":{"module":"Kademlia__Membership","location":"File "src/lib/kademlia/membership.ml", line 303, characters 64-71"},"message":"Connection to peer failed NodeDown","metadata":{"kademlia_level":"EROR","pid":39230}}
{"timestamp":"2019-08-08 10:36:59.780631Z","level":"Error","source":{"module":"Kademlia__Membership","location":"File "src/lib/kademlia/membership.ml", line 277, characters 65-72"},"message":"Kademlia stderr output:  respond!\n","metadata":{"pid":39230}}
{"timestamp":"2019-08-08 10:36:59.795688Z","level":"Fatal","source":{"module":"Kademlia__Membership","location":"File "src/lib/kademlia/membership.ml", line 228, characters 68-75"},"message":"Kademlia process died: $exit_or_signal","metadata":{"exit_or_signal":"exited with code 1","pid":39230}}
{"timestamp":"2019-08-08 10:36:59.795827Z","level":"Debug","source":{"module":"Coda_run","location":"File "src/app/cli/src/coda_run.ml", line 70, characters 52-59"},"message":"Successfully wrote the visualization of the registered masks at location: /Users/paul/.coda-config/registered_masks.dot.","metadata":{"coda_run":"Logging state before program ends","pid":39230}}
{"timestamp":"2019-08-08 10:36:59.797942Z","level":"Debug","source":{"module":"Coda_run","location":"File "src/app/cli/src/coda_run.ml", line 83, characters 58-65"},"message":"Could not visualize transition frontier since daemon is currently bootstrapping","metadata":{"coda_run":"Logging state before program ends","pid":39230}}
(monitor.ml.Error (Kademlia.Membership.Child_died)

("Raised at file "src/lib/kademlia/membership.ml", line 233, characters 18-34"
"Called from file "src/job_queue.ml" (inlined), line 131, characters 2-5"
"Called from file "src/job_queue.ml", line 170, characters 6-47"
"Caught by monitor coda"))

Thanks Paul.
Our seed nodes were offline at this time and I suspect that was the root cause of this failure.
Can you try reconnecting now? (we're back up.)
Please also be sure to grab the newest binary. (website should be updated soon)
@o1pranay

Closing this issue as it is stale for a long time.


[SPARK-13919] [SQL] fix column pruning through filter

What changes were proposed in this pull request?
This PR fix the conflict between ColumnPruning and PushPredicatesThroughProject, because ColumnPruning will try to insert a Project before Filter, but PushPredicatesThroughProject will move the Filter before Project.This is fixed by remove the Project before Filter, if the Project only do column pruning.
The RuleExecutor will fail the test if reached max iterations.
Closes #11745
How was this patch tested?
Existing tests.
This is a test case still failing, disabled for now, will be fixed by https://issues.apache.org/jira/browse/SPARK-14137

Test build #53560 has started for PR 11828 at commit ffe1270.

Test build #53560 has finished for PR 11828 at commit ffe1270.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53560/
Test FAILed.

Test build #53572 has started for PR 11828 at commit d956aad.

Test build #53574 has started for PR 11828 at commit b26d1c0.

Test build #53577 has started for PR 11828 at commit 920de45.

Test build #53572 has finished for PR 11828 at commit d956aad.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53572/
Test FAILed.

Test build #53574 has finished for PR 11828 at commit b26d1c0.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53574/
Test FAILed.

Test build #53577 has finished for PR 11828 at commit 920de45.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53577/
Test PASSed.

Merged build finished. Test PASSed.

Test build #53600 has started for PR 11828 at commit b1118e5.

Test build #53600 has finished for PR 11828 at commit b1118e5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53600/
Test PASSed.

cc @cloud-fan

Test build #53698 has started for PR 11828 at commit 6e698cc.

Test build #53698 has finished for PR 11828 at commit 6e698cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53698/
Test PASSed.

If my understanding is right, what we want is:

insert a Project below Filter, so that we may have chance to push it down further.
push down Filter through Project, to reduce the number of input rows.

The problem is: at the time we push Filter through Project, we don't know if this Project can be pushed down further, and we may mistakenly lift it and make the plan sub-optimal.
I think logically we should put ColumnPruning and PushPredicatesThroughProject in different batches, so that when we push down Filter through Project, we can make sure this Project can't be pushed further and it's safe to lift it.
Anyway, this PR does fix the problem, but I think we should simplify the Operator Optimizations batch, it contains over 30 rules, and is very hard to reason about how these rules interact with each other.

@cloud-fan That's correct. The reason we keep them together is that many rule depend on each other. It make sense to split them as multiple batches, I'm not sure how clearly we can split them, that's another topic.

We need to add more tests when splitting the Optimizer rules into multiple batches. So far, the test coverage of Optimizer is weak. We only evaluate the effects of the individual rules. After introducing Constraints, I found more rules become correlated. For example, the rule SimplifyCasts affects the predicate push down. : (

Test build #54069 has started for PR 11828 at commit 6a41cd4.

Test build #54069 has finished for PR 11828 at commit 6a41cd4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54069/
Test FAILed.

Test build #54090 has started for PR 11828 at commit bb8f0cc.

Test build #54090 has finished for PR 11828 at commit bb8f0cc.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54090/
Test FAILed.

Test build #54144 has started for PR 11828 at commit cd7132e.

Test build #54144 has finished for PR 11828 at commit cd7132e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54144/
Test PASSed.

@cloud-fan Does this look good to you?

Test build #54150 has started for PR 11828 at commit d2da9e4.

LGTM

Test build #54150 has finished for PR 11828 at commit d2da9e4.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/54150/
Test FAILed.

Test build #2694 has started for PR 11828 at commit d2da9e4.

Test build #2694 has finished for PR 11828 at commit d2da9e4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merging into master, thanks!


Fix crash on requests that returns an error

It should fix issue #44

@andrewhavens just rebased with current master and pushed to my branch, Im not sure if I still need to do something else to see if the Travis build will pass. thanks!

@andrewhavens Travis build have passed! :)

I'm going to merge this since it looks good to me.


Tap-to-Run & Snapshots not showing in HA

Govee Device SKU
H606A
Govee2MQTT Version
2024.07.13-82ddc6e9
Describe the issue
I'm following the FAQ to enable video effects, but they don't appear in HA after purging cache.  I do see an old shortcut I had since removed - so it was working, it just doesn't seem to add new effects.
Startup Diagnostics
not sure where to generate from HAos
Additional Logs
No response
Home Assistant Logs
No response
Anything else?
No response

Maybe related to : https://github.com/wez/govee2mqtt/issues/317

Deleted my dreamview and purged cache - still now scenes or new effects in HA

Did you try to Restart addon and reload mqtt config?

Ah thanks, that was it.

Reboot or action blocking others ?

I did an OS reboot and that brought the updated effects in


Fix local authority import multiple files issue

It's possible for the downloader to return multiple matching files, and this was causing the download_and_import_local_authorities command to fail. This patch fixes the issue by detecting a list of files and looping round it, importing each one.

squashed, lets merge this once this final build goes green


Option to filter un-routable IP addresses from announce messages

Option to filter private, loopback, and unspecified IP addresses from announce messages.

Codecov Report

Merging #146 (745f20a) into main (38ba08b) will decrease coverage by 0.14%.
The diff coverage is 55.26%.

@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   64.45%   64.30%   -0.15%
==========================================
  Files          21       22       +1
  Lines        2377     2415      +38
==========================================
+ Hits         1532     1553      +21
- Misses        665      678      +13
- Partials      180      184       +4

Impacted Files
Coverage Δ

option.go
41.66% <0.00%> (-2.29%)
:arrow_down:

subscriber.go
74.01% <0.00%> (-0.74%)
:arrow_down:

mautil/mautil.go
77.77% <77.77%> (ø)


#223: Fix waveform length when merging pulses

Fixes issue #223

While I'm here ... It seems to me that the if-blocks like "if (tNow < tNext1) ..." (lines 3233, 3250, 3267) will never get executed, and can be safely removed.
tNow will always be equal to the smaller of tNext1 and tNext2 (because of lines 3282,3283. This is also true at first iteration - tNow is 0, and at least one of tNext1 and tNext2 must be 0). Therefore, if (tNext1 < tNext2) (line 3229), then (tNow == tNext1), and the conditional (tNow < tNext1) (line 3233) will always be false. The same idea applies to the other two places (lines 3250 and 3267)

This fails a couple of tests in x_pigs and x_pipe which should pass.  I'll need to revisit this at a later date.


Video playback status and process are out of sync

@brianegan

存在的问题：
视频已经播放结束，但是状态isPlaying还是true的状态
(google translate)
Problems:
The video has ended, but the state isPlaying is still true.

This seems to be an issue with the video_player plugin. Chewie only provides the GUI on top of it. Please open an issue at https://github.com/flutter/flutter/issues with the output of flutter doctor -v and a full example demonstrating the issue.


Update json4s-jackson, json4s-scalap to 3.6.5

Updates

org.json4s:json4s-jackson
org.json4s:json4s-scalap

from 3.6.4 to 3.6.5.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [{ groupId = "org.json4s" }]

https://github.com/json4s/json4s/compare/v3.6.4...v3.6.5


Get rid of json-simple

Gets rid of json-simple from the python executioner

@farizrahman4u once this is merged please update your dl4j PRs as well.


Python3 support for bin/ycsb

I have set python3 as my default version of python, system wide.
As a result, if I run bin/ycsb the program fails and simply states a syntax-error...
Please add the functionality to check if python is compatible and if not, try using python2 command to run ycsb.
-Cheers.

A symptomatic fix would be to change the shebang in bin/ycsb to request python2 from env.
It should be noted that python 2.x is sunsetted upstream. That implies a migration to python 3 would be in order either way.
The simplest fix would be the following patch:
- #!/usr/bin/env python
+ #!/usr/bin/env python2

Anything  beyond that will necessarily be more involved. It might be worth checking upstream how YCSB handles the python2 sunsetting.

+1 for the env solution. Please file a PR. #hacktoberfest
Clemens Lieb<EMAIL_ADDRESS>schrieb am So., 14. Okt. 2018,
14:49:

A symptomatic fix would be to change the shebang in bin/ycsb to request
python2 from env.
It should be noted that python 2.x is sunsetted upstream. That implies a
migration to python 3 would be in order either way.
The simplest fix would be the following patch:

#!/usr/bin/env python+ #!/usr/bin/env python2

Anything beyond that will necessarily be more involved. It might be worth
checking upstream how YCSB handles the python2 sunsetting.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TSDBBench/YCSB-TS/issues/12#issuecomment-429623816,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABTaflL6dTjARqh15qbOty5U6X5-Mwesks5ukzK_gaJpZM4XbFnB
.


Clarifying language in GCP tutorial

This change makes the language clearer based on the dropdowns in GCP:

Thanks!


feat: include prettier

📑 Description
Added prettier configuration file.
✅ Checks

[x] My pull request adheres to the code style of this project
[x] My code requires changes to the documentation
[x] I have updated the documentation as required
[x] All the tests have passed

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[usecase-linux][xwalk-3696] Add usecase for start_url

Impacted tests(approved): new 1, update 0, delete 0
Unit test platform: [Linux]
Unit test result summary: pass 0, fail 1, block 0
Comments:
Test app with web source start_url can't be launched successfully.
Issue tracked by xwalk-3656

@zqzhang
I have updated following your comments.


[PE-D][Tester A] User guide command format misleading for deleting teams.

The command format for the deleting teams is:

However, when I try it:

I believe the command should be deleteteam instead
Also, when I see the UG, I can't really understand how the command works and how I should delete teams. Maybe you can consider writing more in your UG and provide meaningful examples.

Labels: severity.Medium type.DocumentationBug
original: aliciamichellew/ped#6

Duplicate issue. This documentation bug has now been resolved.


Training from scratch in another language

I want to train AlBert from scratch in a non-English language. I have access to a corpus of 1-2 B words. Would that be sufficient?
Would training on one single Cloud TPU v3 with 128Gb RAM be feasible? Can you give an estimated training time for base, large and xlarge?

@peregilk
I haven't run pretraining, so I don't know how much time it will take.
This codebase has only supported for GPU and CPU.  You use the original author implementation for TPU based training. After training, you convert the weights to tf2.0 using for further fine-tuning tasks


Notifications ringtones

Sorry for my bad english I use google traduction
Expected behavior
When I receive several emails I should have a notification and only one ringtone.
Actual behavior
When I receive several emails I have a notification and several ringtones.
Steps to reproduce
Launch K9Mail, receive several emails.
Environment
K-9 Mail version: 5.716 ( and 5.715 )
Android version: android 8.1.0
Account type (IMAP, POP3, WebDAV/Exchange): IMAP
Please take some time to retrieve logs and attach them here:
2020-06-05 13:59:18.336 11624-11651/com.fsck.k9 V/MessagingController$ControllerSyncListener: Creating notification for message INBOX:30532
2020-06-05 13:59:18.667 11624-11651/com.fsck.k9 V/MessagingController$ControllerSyncListener: Creating notification for message INBOX:30531
2020-06-05 13:59:18.892 11624-11651/com.fsck.k9 V/MessagingController$ControllerSyncListener: Creating notification for message INBOX:30530
2020-06-05 13:59:19.131 11624-11651/com.fsck.k9 V/MessagingController$ControllerSyncListener: Creating notification for message INBOX:30529
Here I had 4 rings

Duplicate of #4559


globalRequire in case of npm (server)

Finalising the globalRequire idea :
The flag really solves a lot of issues. The only thing here is that it was not taken into consideration in the npm or server target case.
With this PR, it affects all the cases of global.require references.

https://github.com/fuse-box/fuse-box/blob/467d7f5dc37e5161c9881d37c496528279dddeaa/modules/fuse-box-responsive-api/index.js#L13-L16
Isn't it there already?

Oh yeah, you right.


[deps] rust-tools.nvim has been archived.

Feature description
Luckily, there is still a heavily customized fork of it.
https://github.com/mrcjkb/rustaceanvim
I wonder if we should move from rust-tools to it.
Additional information
No response

since most of us don't write rust, maybe a pr will be nice?


Remove static label tests

This PR removes the currently failing tests that reference static files - they will be reintroduced later.
#2989

@SchrodingersGat this PR fixes the failing tests in master for now.


Added Trie [CPP]

Fixes #334
By submitting this pull request I confirm I've read and complied with the below declarations.

[x] I have read the Contribution guidelines and I am confident that my PR reflects them.
[x] I have followed the coding guidelines for this project.
[x] My code follows the skeleton code structure.
[x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

@yashLadha Nice work. Please resolve the issues.

Sir the syntastic flagged error to use an unsigned long value. Syntastic is
code linter and syntax checker for vim.
On 22 Jun 2017 8:43 am, "Avi Aryan"<EMAIL_ADDRESS>wrote:

@aviaryan requested changes on this pull request.
In trie/trie.cpp
https://github.com/iiitv/algos/pull/338#discussion_r123413282:

// Check that the last node reached is leaf node and not null as well
return (pCrawl != NULL && pCrawl->get_leaf_status());
+};

+// Driver function
+int main() {

// keys to insert into Trie
char keys[][8] = {"the", "a", "there", "answer", "any",

"by", "bye", "their"};

// Output the status of key
char output[][32] = {"Not present in trie", "Present in trie"};
// Root of Trie (Crawling starts from root, insertion as well)
class TrieNode *root = new TrieNode();
// Insertion into Trie
for (unsigned long i = 0; i < ARRAY_SIZE(keys); ++i)

why use unsigned long here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/iiitv/algos/pull/338#pullrequestreview-45613031, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARMqT5YfdTJjM2eFGIFxT3IGZFFN4t6uks5sGdvygaJpZM4N_SiY
.


Fix bug AVX

The AVX code was never compiled because of a wrong define, and when correctly included did not compile.
However, I still get an error:
        Start   2: run_nfllib_demo8_60_uint32_t_op
  2/122 Test   #2: run_nfllib_demo8_60_uint32_t_op .....................***Failed    0.03 sec

When running the test, I get the following output:
Polynomials of degree 8 with 60 bit coefficients and 32 bit limbs
======================================================================
Time per polynomial setcoeffs: 0.675 us
Time per polynomial generation (uniform): 3.25 us
Time per polynomial generation (bounded 6 bits): 0.25 us
Time per polynomial generation (gaussian sigma=20 k=128): 1.6 us
Time per polynomial NTT: 0 us
Time per polynomial inverse NTT: 0.1 us
Time per polynomial in-place addition a+=b: 0.2 us
Time per polynomial addition c=a+b: 0 us
Time per polynomial subtraction c=a-b: 0 us
Time per polynomial multiplication (NTT form) c=a*b: 0.1 us
error with vectorized mul_shoup

@aguinet @serge-sans-paille ?

Hmm it also fails for me when using SSE-only. Am I the only one?

Using cmake -DNFLLIB_USE_AVX=OFF -DNFLLIB_USE_SSE=ON -DNFL_OPTIMIZED=ON -DCMAKE_BUILD_TYPE=Debug -G Ninja ..

Okay I think I got the issue, somehow one refactoring must have failed... I'll keep you in touch!

I pushed two commits that I think fix the issues (for SSE and AVX2)!

Well, it seems that there is still an aligment issue for AVX2! I will check that this afternoon.

@aguinet that works for me, can we merge?

Merging it


AwaitExpression used isOneOfCall incorrectly

with the big refactor, I think some code got swept away (See fix for #2)
This PR fixes that bug again.

My bad, thanks!


EDNS0?

Is EDNS0 parsing planned to be added to the dns layer in the near future?
Thx
Russ

Hi Russ
I am the original comitter of the DNS layer. I do not have much time to add this by now, but I'll be happy to review your pull request if you decide to add this. I can also answer your questions to debunk your way to this.
Laurent

Sounds good. I'll likely do a patch.
Thx!
On Thursday, April 14, 2016, Laurent Hausermann<EMAIL_ADDRESS>wrote:

Hi Russ
I am the original comitter of the DNS layer. I do not have much time to
add this by now, but I'll be happy to review your pull request if you
decide to add this. I can also answer your questions to debunk your way to
this.
Laurent
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/google/gopacket/issues/184#issuecomment-209871723

@lhausermann @rleighton I am currently working on some DNS decoding projects. I am interested to know if there has been any progress on EDNS support or should I work to take this one.
I am also interested to know if you have looked at TCP DNS.


Adding HEARTBEAT send support

Hi there,
I'm thinking of adding HEARBEAT send support to Stompex- I have a fairly good idea how to implement it from the STOMP specification. The question is, where should I add the code for this? Is there a specific convention for developers to use on this project?
Thanks!

Currently most of that sort of logic lives in stompex.ex but to be perfectly honest, it's starting to get a little cluttered, so I'm thinking at some point of splitting it out into a number of other modules. But if you wanna take a crack at it, stompex.ex would be the place

Hi,
pareeohnos<EMAIL_ADDRESS>writes:

Currently most of that sort of logic lives in stompex.ex but to be
perfectly honest, it's starting to get a little cluttered, so I'm
thinking at some point of splitting it out into a number of other
modules.

Yeah, I figured that out from looking over the code just after
reporting that bug (I know, the wrong way round!!).
I think it would be a good idea to split it out into different
modules. Perhaps an issue should be created for that?
Another thing I thought about was how there were functions in
stompex.ex, such as handle_info, which specifically says in the
docstring that "This function should not be invoked directly
(..snip..)"- surely they should be marked as private functions? I can
make a PR to fix this, but I'm not sure about the safety of doing
that.

But if you wanna take a crack at it, stompex.ex would be the place

Yeah, I'm having a bit of a crack at the moment. Currently working my
way through the spec to understand. AFAICT, I don't need to implement
sending, but I do need to implement the HEARBEAT header into the
initial handshake..
Wish me luck!
--
Best regards,
Dom Rodriguez
`Top-posting causes armed conflicts.'
~~ anon

Yeah probably not a good idea, will get one opened in a bit. I was thinking of restructuring to also cater for the different specification versions, as there are a few differences between 1.0, 1.1 and 1.2 (although can't think of them off the top of my head)
The handle_info function needs to stay public (least I'm pretty sure it does) as it's part of the way GenServer works. Stompex starts up a GenServer instance, and all messages received by other processes that aren't send via a cast or call will be handled there, so I would've thought that by making it private, it would stop receiving the TCP message.
As for the heartbeats themselves, the spec seems to state that the header must be supplied on connection which is already possible in stompex, but the sending of the heartbeat is a little fiddly I think. If you're not sending any data to the server it's pretty straight forward, you just send it a new line. If you are sending data to the server however, then the heartbeat only needs to be sent when there isn't any other message being sent in the time frame specified. As per the spec:
- the sender MUST send new data over the network connection at least every <n> milliseconds
- if the sender has no real STOMP frame to send, it MUST send an end-of-line (EOL)
- if, inside a time window of at least <n> milliseconds, the receiver did not receive any new data, it MAY consider the connection as dead
- because of timing inaccuracies, the receiver SHOULD be tolerant and take into account an error margin

Just checking in on this to see if you'd made any progress? I ask, as I've actually rewritten a lot Stompex due to finding a number of massive issues when we tried using it with another server, and that may have an impact on anything you've done so far.

Hi,
pareeohnos<EMAIL_ADDRESS>writes:

Just checking in on this to see if you'd made any progress? I ask,
as I've actually rewritten a lot Stompex due to finding a number of
massive issues when we tried using it with another server, and that
may have an impact on anything you've done so far.

Honestly, no. I've been busy with college assignments, so I haven't
really dedicated much time to this.
Don't worry about it having any impact, I'll work around as and when.
--
Best regards,
Dom Rodriguez
`Top-posting causes armed conflicts.'
~~ anon

ok great, will get everything updated :)

Update on this, still busy with college assignments, will work on it later this summer.

No problem, haven't had any request for this to be an immediately required feature so not to worry :)

@pareeohnos Did you get my email I sent to you?

@shymega no? Not received anything, what's up?

@pareeohnos Righto. It's a lengthy email, and I didn't particularly want to discuss it on GH - have I got the right email address, then?

@shymega ah there we are, had gone to my spam folder, will reply :)

@pareeohnos Cool, thanks. FWIW, I will mention it on GH at some point - I just don't want it public right now :smile:

@shymega haha yeah no problem, whenever it's ready 😄

@pareeohnos Just replied to your email. (In case it goes to spam again..!)

@pareeohnos Do you have any IM accounts we could have a quick chat on? Having some teething issues with Stompex, I'd find it useful for your thoughts in real time.
I'm on the Elixir Slack, and Freenode IRC, as shymega.
Cheers.

Sure, just sent you a message on IRC :)

Still in progress - on hold for a bit until the code is tidied up a bit.


add a better elrond converter

Elrond Converter does the same thing: "converting data" but has a better UI/UX than the "original"

Hey, @SkyzoxRobin, what should we do with this one?

Hey, @SkyzoxRobin, I allowed myself to add https://xconverters.netlify.app/. I think it is the same app but with a new domain. I will close this one. But please add changes if needed.


NIFI-3651 - Add logo to README.md

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically master)?

[X] Is your initial contribution a single, squashed commit?

For code changes:

[X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] ~Have you written or updated unit tests to verify your changes?~
[X] ~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?~
[X] ~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~
[X] ~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~
[X] ~If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?~

For documentation related changes:

[X] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@apiri - I used the embedded HTML markdown notation as this seems to be a more universal approach to image resizing. There's are other options
http://stackoverflow.com/questions/14675913/how-to-change-image-size-markdown

+1 LGTM, thanks much, I like the look and the links :)  Merging to master

Lookes great on dekstop and mobile


Insert Link dialog

The dialog (Ctrl-K) doesn't look like an Electron one, maybe it's some kinda JS modal dialog, not sure. But it certainly doesn't blend in.
Is there any way to style it also?
P.S. Seems that the theme's vertical dividers appear on top of the modal's background.

@andrei-a-papou With the latest release it should look better. ;)

Looks great now, thanks!


Made Voulunteer form in volunteer.html

#247  Issue Resolved
Issue
Volunteer Page was not made  and a blank site was visible as shown in the below image

Changes Proposed

I made a responsive website to submit a form for volunteering
Tech stack used : HTML,CSS,JS and Bootstrap
I have also added the navbar of the main page for easy redirection between different pages

Preview of Webpage

Desktop view

Responsive View

Form was not needed in this page


Pattern:  Quote Prod QA testing of the additional copy line 2 to quote's source

User Story

As a [user role below]:
developer using the ibm.com Library ?pattern name?

I need to:
have a version of the pattern or component that has been tested for accessibility compliance as well as on multiple browsers and platforms

so that I can:
be confident that my ibm.com web site users will have a good experience

Additional information

Browser Stack link
Browser Standard
Browser versions to be tested:  Tier 1 browsers will be tested with defects created as Sev 1 or Sev 2.  Tier 2 browser defects will be created as Sev 3 defects.
Platforms to be tested, by priority:  1)  Desktop  2)  Mobile  3)  Tablet
Mobile & Tablet iOS versions: 13.1 and 13.3
Mobile & Tablet Android versions: 9.0 Pie and 8.1 Oreo
Browsers to be tested:  Desktop: Chrome, Firefox, Safari, Edge, Mobile: Chrome, Safari, Samsung Internet, UC Browser, Tablet: Safari, Chrome, Android
Accessibility Checklist
Creating a QA bug
See the Epic for the Design and Functional specs information
Dev issue (#2685)

Acceptance criteria

[ ] Accessibility testing is complete.  Pattern is compliant.
[ ] All browser versions are tested
[ ] All operating systems are tested
[ ] All devices are tested
[ ] Defects are recorded and retested when fixed

7/7/2020:  Visual and function testing is finished.  Accessibility testing is in progress.

7/14/2020:  all testing finished.  Bugs created.


Request: support moduleResolution compiler option in tsconfig.json

via: https://github.com/Microsoft/TypeScript/wiki/Compiler Options
This option is available on TypeScript 1.6.

Note workaround: if you compile with module commonjs it automatically switches to node resolution ;) :rose:

Up for grabs
Implementer's guide
Code is here : tsconfig.ts

:+1:


chore(deps): update registry.access.redhat.com/ubi8/go-toolset docker digest to 742ae6e

This PR contains the following updates:

Package
Type
Update
Change

registry.access.redhat.com/ubi8/go-toolset
stage
digest
430d5a5 -> 742ae6e

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for the registry.access.redhat.com/ubi8/go-toolset 742ae6e update again.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


[i2c,dv] I2C timing assertions

Description
This issue is here to track the work required to add assertions to the test bench. For example, SDA should not change at the same time as SCL, which caused the following issue: https://github.com/lowRISC/opentitan/issues/18718

@marnovandermaas could you do the assertion for SDA/SCL not changing together ASAP as an aid to verifying: https://github.com/lowRISC/opentitan/pull/18729?

@GregAC I've added this assertion as a commit to this PR: https://github.com/lowRISC/opentitan/pull/18729

Moving to M2.5 backlog since the SDA / SCL assertion has been merged.

V3, so M5 looks correct

V3, hence moved to P4


hssi 10G: port_ -> src_port_ and dst_port_

Replaces the notion of a single port for both Tx/Rx with one port for the Tx side and a separate port for the Rx side.
Adds mbox_write(), mbox_read() variants that accept a port selection as a parameter.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.005%) to 65.528%

Files with Coverage Reduction
New Missed Lines
%

libraries/plugins/xfpga/error.c
1
86.7%

Totals

Change from base Build<PHONE_NUMBER>:
-0.005%

Covered Lines:
13137

Relevant Lines:
20048

💛  - Coveralls

Yes, but I'd like to save that for a separate pull request.


Add files via upload

Suez Canal University

@YoussefReda101 I am sorry, the domain ci.suez.edu.eg is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

@YoussefReda101 I am sorry, the domain ci.suez.edu.eg is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


python: pyperf: get_stack_offset randomly fails

Flaky test failures stemming from get_stack_offset occasionally failing:
[2022-10-06 12:22:46,079] DEBUG: gprofiler.utils: (['/tmp/_MEIg4dLPw/gprofiler/resources/python/pyperf/get_stack_offset']) stderr: 'stack not found, searched for 16384 bytes into task_struct\n'
[2022-10-06 12:22:46,079] DEBUG: gprofiler.profilers.python: eBPF profiler error: Command '['/tmp/_MEIg4dLPw/gprofiler/resources/python/pyperf/get_stack_offset']' returned non-zero exit status 1.
stdout: b''
stderr: b'stack not found, searched for 16384 bytes into task_struct\n'

(excerpt from this failure).
This might be only some issue in the test, but might also be a real problem occuring in the wild.

When it happens - it does seem to happen multiple times for the same test run (i.e the same problem reproduces on the same kernel / state).

Another failure example - https://github.com/Granulate/gprofiler/actions/runs/3220091322/jobs/5266664858


node_generator does not use upstream sources

What version of gRPC and what language are you using?
340bffa55560f02944dd81413aa764081a60f329
What operating system (Linux, Windows, …) and version?
macOS 10.14
What runtime / compiler are you using (e.g. python version or version of gcc)
ghost:grpc vmax$ clang -v
Apple LLVM version 10.0.0 (clang-1<IP_ADDRESS>)
Target: x86_64-apple-darwin18.0.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

What did you do?
Updated node_generator.cc in grpc/grpc-node repo
What did you expect to see?
Updated plugin behaviour when using grpc/grpc
What did you see instead?
node_generator source are vendored-in here
Anything else we should know about your project / environment?
I'm going to work on making grpc/grpc use generator plugin from grpc/grpc-node. Any advice on how to best approach it?

Can you explain a little more what exactly you are trying to do here?
Also, I want to clarify that the node generator code is not vendored into src/compiler. Rather, it has been moved from src/compiler to the grpc-node repo, and we have not completed the second step of that process, which is deleting the original copies.

@murgatroid99
goal: I need this commit to be available on grpc/grpc because that's what pubref/rules_proto is using to integrate gRPC with bazel projects
implementation detail: I'm trying to get sources from grpc/grpc-node to build the generator and plugin together in grpc/grpc
shortest way of achieving the goal will probably be syncronizing node_generator.cc file in this repo with grpc/grpc-node
what's the plan for sources removal from grpc/grpc?

Moving forward, it seems like the best solution would be to have a BUILD file in grpc/grpc-node to build the plugin, and then you can depend on that directly.


Trigger?

Is it possible to trigger the sort instead of using the select that is generated?

Never mind...
$('#undefined-sort').trigger('change');


Opening Control Panel opens a Not Folder

Description
If you enable "Set Files as the default file manager" and use "Uninstall" button to remove not a modern app (Tizen studio in my example) Files will try to open some path: ::{26EE0668-A00A-44D7-9371-BEB064C98683}\8::{7B81BE6A-CE2B-4676-A29E-EB907A5126C5} in my example and show an error message.
Example:

Steps To Reproduce

Enable "Set Files as the default file manager"
Try to uninstall "legacy" app (like Google Chrome, Visual Studio, Steam, Discord, etc)
See an error

Expected behavior
Show Programs and Features page (either in Files or in explorer.exe), preferably - also select needed app (unlike explorer.exe)
Expected window:

Files Version
Version: <IP_ADDRESS>
Windows Version
Windows 11 10.0.22000.434
Relevant Assets/Logs
2022-02-10 16:21:57.8937|WARN|NormalizePath|::{26EE0668-A00A-44D7-9371-BEB064C98683}\8\::{7B81BE6A-CE2B-4676-A29E-EB907A5126C5}\
	System.UriFormatException: Invalid URI: The format of the URI could not be determined.
   at SharedLibrary!<BaseAddress>+0xafcde0
   at System.Uri..ctor(String) + 0x17
   at Files.Helpers.PathNormalization.NormalizePath(String) + 0xef

From debug.log
2022-02-10 16:21:57.2471|WARN|StartSTATask|The system cannot find the file specified. (0x80070002)
	System.IO.FileNotFoundException: The system cannot find the file specified. (0x80070002)
   at Vanara.PInvoke.HRESULT.ThrowIfFailed(String message)
   at Vanara.PInvoke.Shell32.ShellUtil.GetShellItemForPath(String path)
   at Vanara.Windows.Shell.ShellItem..ctor(String path)
   at FilesFullTrust.Win32API.GetFileIconAndOverlay(String path, Int32 thumbnailSize, Boolean getOverlay, Boolean onlyGetOverlay)
   at FilesFullTrust.MessageHandlers.Win32MessageHandler.<>c__DisplayClass3_0.<ParseArgumentsAsync>b__1()
   at FilesFullTrust.Win32API.<>c__DisplayClass0_0`1.<StartSTATask>b__0()

From debug_fulltrust.log
Let me know if full files are needed.
P.S. Excuse me if this was reported before, could not find it in Opened issues with search tag for Experimental/Default

@makisukurisu is this still an issue in the preview version? https://files.community/download/preview

@yaichenbaum , just installed Files from link you provided, now it opens old control panel just fine with no error messages.
Thanks for your reply 😄

Also I had some updates on my system, just in case this may affect this issue:
Version: <IP_ADDRESS>
OS Version: 10.0.22000.613


add GitHub Actions

Can you also add a formatter test step, please?

Do you mean to run crystal tool format --check in the CI so it will fail if the formatting is not correct?

Exactly. You can use https://crystal-lang.github.io/install-crystal/configurator.html to generate the CI configuration.

CI now fails on Windows. Could you please take a look at it.
It also fails on Linux using Crystal 0.35.1 I see in shards.yml that 0.36 is required so I can remove 0.35.1 from the matrix, but I think something should verify that the crystal dependency of this shard is also satisfied. shards check seems to only check the dependencies and not the current shard.

Yes, HTTP::Client is not yet supported on windows. So this shard can't work there either. I think we should be good with just testing against ubuntu-latest, though. There's no platform-specific implementation in this shard, so we don't need to multiply platforms.
I suppose we should add 0.36.0 to the version matrix, as that's the lower bound.

Sure, I'll do that even though I think it is always a good idea to run the tests on other platforms as well to make sure that our assumption that there is no platform specific code holds true. (Case in point there is something that makes this shard not working on Windows.)

Now the CI is happy.

Case in point there is something that makes this shard not working on Windows.

I don't think that point counts here. The failure does not depend on a shortcoming of this shard. As soon as windows support for HTTP::Server lands, it will be compatible with that.

ok, so what shall I do to let you accept this pr? Shall I remove mac as well from the matrix?

I'd definitely want to wait for other opinions on this. We should probably include this in the general discussion in https://forum.crystal-lang.org/t/migrate-ci-in-crystal-lang-projects/3363

I think that checking against different platforms in a pure crystal shard should be than if:

there are platform specific blocks via macros or runtime
if overrides or interacts closely with parts of the std-lib that are platform specific

If we are sure that once http is supported on windows there are little chances of this not working then we can test only on ubuntu.

I think the whole point of testing and running CI is to reduce the risk of any bugs because we missed some edge case. A case we have not thought of some weird interaction between things that should not have any impact on each other. That's why I would test every piece of code on all the platforms crystal and the specific shard is expected to support.
Unless it incurs some unreasonable cost.
Anyway, I am going to comment out the Mac tests as well now to make this PR progress.

on all the platforms crystal and the specific shard is expected to support.

The thing is, this can quickly grow very large (hopefully!). Currently, we can easily run CI on only six supported platforms. So there's some limitation at least. But we'd like to do more if the opportunity presents. Tests should also run against different Crystal releases (nightly, 1.0, 1.1 etc.), and there might be differences between platforms. If a shard has dependencies, different dependency versions might also be considered. The compiler for example should definitely be tested against several LLVM versions.
If you multiply all of that - and hopefully a lot more platforms and releases in the future - that would be an enormous amount of CI jobs for very little benefit.
Sure, we don't pay for the CI hours directly. But nevertheless, we should use it responsibly. I'd really prefer if Github saves money that they can put into supporting aarch64-darwin or BSD platforms.
Besides, we are also limited by the total amount of parallel jobs.

I have not touched Crystal for almost 2 years now, I am surprised this PR is still pending and I doubt the two commented out lines were stopping it from being accepted, but nevertheless I accepted the change proposal.


[24/10/2022]: Create/Upload Course (restricted to admin).

Sub Issue : https://github.com/Open-Science-Community-Saudi-Arabia/MOOCs/issues/5#issue-1406773854
Summary
Only Admins can create and upload courses.
What needs to be done?

[ ] Create/Upload Course (restricted to Admin).

Who want to work on this issue?
Assigned to me by @RealRichi3

@RealRichi3 I made changes, added, committed and then pushed to github. I am not seeing a PR on github for reasons unknown to me.
Also I made a new branch for this task. Are you familiar with this type of issue?

When did you make the PR?

@oEbuka if your referring to  PR for the models #25, it has been merged already

@oEbuka if your referring to PR for the models #25, it has been merged already

Good day, I wasn't referring to this. Thanks.
When I try to push to upstream, I'm restricted.
When I push to origin it's says my branch is behind. So I pull, it shows the additions, but when I commit it shows there's 'nothing to commit', then when I push again it's still says the branch is behind.

First, you can't push to upstream because you have no permission. Try synchronizing dev_team2 branch on the forked repository in your GitHub account. Then pull again


Revert #35409

This test was preemptively disabled to avoid problems from some
forthcoming changes.  Those problems have been fixed elsewhere,
so we no longer need to disable this test.
Resolves rdar://73049300

@swift-ci Please test

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 365a1db2a9eba9c4925c60faa5bc48951232b241

Build failed
Swift Test Linux Platform
Git Sha - 365a1db2a9eba9c4925c60faa5bc48951232b241

@swift-ci Please test Linux platform

@swift-ci Please test Linux platform


Fix pricing link

Go to houndci.com, click on docs or FAQ link at the top, then click pricing link at the top. The #pricing gets added to the URL but that doesn't go anywhere unless you're on the initial houndci.com URL.

:+1:


Fixed bug when switching to orthographic camera on first frame

Don't merge until https://github.com/CesiumGS/cesium/pull/8850 is ready.
This PR fixes the first issue here: https://github.com/CesiumGS/cesium/issues/6865
When going from perspective to orthographic, it does a depth pick to figure out what size to make the frustum. The closer you are to an object, the smaller the orthographic frustum.
This was failing on the first frame because it was reading a garbage depth value, since nothing had been renderer yet. This PR adds a check for this and uses the cartographic height as a fallback.
There's another fix in here which makes sure to reconstruct the world space position using the correct frustum. The old code was reconstructing the perspective-generated depth with the new orthographic frustum, resulting in an incorrect world position. Now it reconstructs with the perspective frustum before changing to orthographic.
Before:

After:

Thanks for the pull request @IanLilleyT!

:heavy_check_mark: Signed CLA found.
:grey_question: Unit tests were not updated.

Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

Confirmed that this fixes the problem of the orthographic frustum not being sized correctly on the first frame.
Local sandcastle vs. hosted sandcastle


For InitializeComponent() issue

Close the project and open it again that's it...

@Uthayananthaseenivasan Is there a particular problem you are running into? If you could provide a description of the problem, steps to reproduce it, and a copy of the C# log from the output pane, that would be helpful.


Figure out a tagging strategy for quilt

Tagging can be used for:

Issues
PRs

Types of tags:

Priority
Difficulty
Genre (tooling, testing, accessibility, …)
Scope (existing package, new package, repo-wide)
Administrative (good starter, feature request, needs help, won’t fix)
Status (WIP)

Recommendation:

Priority is better managed in projects than in issues
Effort - High, Low, Medium (light blue)
Area - Tooling, Testing, Server, … (yellow)
New Package (orange)
Feature Request (green)
Needs discussion
Package: foo (dark blue)
WIP: red


NERDTree is not retaining the open tree and collapsed tree between the show and hide toggling of NerdTree

To assist in resolving your issue, provide as much information as possible, in place of the ellipses (…) below.

Environment: Describe your Vim/NERDTree setup.

Operating System: … Mac, Linux ubuntu

Vim version :version:Vi IMproved 8.0

NERDTree version git rev-parse --short HEAD:b0bb781

NERDTree settings applied in your vimrc, if any: F2 For show and hide of Nerdtree
…

Process: List the steps that will recreate the issue.

Assume i expand the directory tree present some of them. Now I press F2 which hides NERDTree now when i press again F2 NerdTree shows up but the Expansion of the tree is not retained between Show and Hide of NerdTree. its really painful to expand all the open dir tree and navigate everytime i hide NerdTree window and come back again.

Please include your <F2> mapping.  That's the only way for us to see the commands that are actually being executed.

F2 is probably mapped to NERDTree, not toggle. This is a default that doesn't help much.

Thanks, @juanibiapina. You are likely correct here.

I tried reproducing this below are my findings.
1 . First using the toggle command
The problem cannot be reproduced using NERDTreeToggle, the expanded folder structure will be preserved.
2. Second using NERDTree command
If we hide nerd tree using the toggle command (or NERDTreeClose) then reopen it using NERDTree command the expanded folder structure won't be preserved.
To me this is normal behavior.
According to the help:

:NERDTree [ | ]                         :NERDTree
Opens a fresh NERD tree. The root of the tree depends on the argument
given. There are 3 cases: If no argument is given, the current directory
will be used.  If a directory is given, that will be used.

:NERDTreeToggle [ | ]             :NERDTreeToggle
If a NERD tree already exists for this tab, it is reopened and rendered
again.  If no NERD tree exists for this tab then this command acts the
same as the |:NERDTree| command.

This issue looks like it has been solved.  Now closing... reopen if necessary.


perf: memory leak

Occasionally I'm seeing perf processes whose memory continues growing forever. Here's one example for /proc/pid/status of such a perf - it shows that anonymous memory takes up most of the space (700mb). This perf process is at least 2 weeks old.
ame:	perf
Umask:	0022
State:	S (sleeping)
Tgid:	3966
Ngid:	0
Pid:	3966
PPid:	3825
TracerPid:	0
Uid:	0	0	0	0
Gid:	0	0	0	0
FDSize:	64
Groups:	0 1001
NStgid:	3966
NSpid:	3966
NSpgid:	3966
NSsid:	3665
VmPeak:	  732316 kB
VmSize:	  732208 kB
VmLck:	       0 kB
VmPin:	    5136 kB
VmHWM:	  707368 kB
VmRSS:	  707368 kB
RssAnon:	  702548 kB
RssFile:	    4820 kB
RssShmem:	       0 kB
VmData:	  712220 kB
VmStk:	     132 kB
VmExe:	   11512 kB
VmLib:	       4 kB
VmPTE:	    1452 kB
VmSwap:	       0 kB
HugetlbPages:	       0 kB
CoreDumping:	0
THP_enabled:	1
Threads:	2
SigQ:	0/15540
SigPnd:<PHONE_NUMBER>000000
ShdPnd:<PHONE_NUMBER>000000
SigBlk:<PHONE_NUMBER>000000
SigIgn:<PHONE_NUMBER>000004
SigCgt:<PHONE_NUMBER>014c02
CapInh:<PHONE_NUMBER>000000
CapPrm:	0000003fffffffff
CapEff:	0000003fffffffff
CapBnd:	0000003fffffffff
CapAmb:<PHONE_NUMBER>000000
NoNewPrivs:	0
Seccomp:	0
Speculation_Store_Bypass:	thread vulnerable
Cpus_allowed:	3
Cpus_allowed_list:	0-1
Mems_allowed:	00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000000,00000001
Mems_allowed_list:	0
voluntary_ctxt_switches:	130270
nonvoluntary_ctxt_switches:	1686839

What's interesting - there are 2 perf processes (one for DWARF and one for FP) and both have roughly the same amount of used memory. Something causes perf to continue accumulating memory over time, we need to figure it out and either restart perf from time to time, or configure it to prevent this from happening.

https://github.com/Granulate/gprofiler/pull/613 helps relieving the problem (if perf becomes too memory heavy, we restart it).
The underlying problem of perf growing indefnitely was not resolved yet, hence I keep the ticket open.


Need to update all unpkg links in docs for 7.1

Before 7.1 docs are published need to update unpkg links.
Also would be nice to figure out an automated system for this in the future 😅 !

I'd like to modify the release workflow such that the unpkg links are automatically updated in the release PR (commit messages in docs files' commit histories may become very confusing otherwise); yet need to do some research on how to achieve that.


Set Heroku to only deploy after successful CI builds

See example
https://circleci.com/docs/2.0/deployment-integrations/#a-simple-example-using-heroku

@lzy7071 thanks for getting this going. I debugged the CircleCI config and merged it with master.
Please close the issue when you agree its completed.

Closing because this has been completed and will be replaced with Netlify.


How do 301 redirects work with Gridsome?

Description
I plan on launching a new site built with gridsome, but want to setup a 301 redirect. Usually this is done with a .htaccess file, and uploading it in the root. Is it that same with gridsome?
I plan on hosting this with Netlify.

Have a _redirects file in your /static folder to configure redirects rules for Netlify. You can also add redirect rules with a netlify.toml file in the root folder of your project. Read more about it here.

Thank you @hjvedvik !

@hjvedvik I was wondering if this could be done without Netlify as I'm using 'Contentful' as a CMS solution?

@LocusT221 it should be possible with just about any host, how it's implemented really comes down to where the site is hosted but the redirects would be done on the hosting end not within Gridsome.

I've tried putting a _redirects file in my /static folder, but it doesn't seem to have any affect. Is this still where it is supposed to go?


App crashes when try to turn off the video during a video call

MUIC-556

Should it also somewhere check the nullability of the getVideo?

LGTM - but please investigate why mediastate.getAudio() was null


Unified Pricing Model

Merge the existing pricing model with Hivemapper priceing model

cc: @jimmylee @jcace @alvin-reyes @schreck23

Ok, here is an explanation of the current iteration of the pricing model and sheets, special thanks to
@Zorlin for helping me get a snapshot of reality to get these models more truthy than they were. The first 4 tabs are the most significant ones, whereby the underlying costs are outlined and combined with a Model A business scenario.
FDI TCO Infra (current)
This is a living snapshot of our CapEx and Opex.
tldr; Our initial investment is around $300K, our monthly operating expenses run at around $3600
FDI Financial Timeline (current)
This is a living representation of all of our expenditures from FDI’s inception into the next forecasted 5 years. It maps out when and what we are expecting to spend our money on, and our storage capacity (raw, useable and offsite). This represents the now and the foreseeable reality.
Model A
This is where it gets sort of fun. Model A is a theoretical model that anyone can use to forecast a simple 5 year business model. The fields Estimated Initial Setup and Estimated Monthly Opex can be edited. I’ve seeded them with $300K and $3600 to based on what we now know.
Importantly, the parameters of the Model itself are below the estimated profit chart. All of these fields are editable and will reflect on the chart and monthly profit map above. It is noteable that, with this version of the model, the break even is $4.75 and not the original $3.00 that was originally estimated. (I dropped the ball on the previous value, as there was no accounting for staff hours... apparently people like to get paid, who knew). It’s very important to remember that this number reflects serving fast egress - that’s our special sauce, the entire experience. (ie, this is not deep glacier storage, it is instant egress)
tldr; onboarding 4 PiB/month at $100k/PiB/year is a lucrative
FDI Timeline with w/ Model A
This is a combined amalgamation of reality + our best guess modelling from above. It maps the profits from Model A onto the FDI Financial Timeline, giving a rough estimate of what we could expect to see if we onboard a targeted 3-4 PiB/month.
Ignore the last two sheets, they will likely go away.
Still todo, (but I would like your feedback first), is refactoring the model into a quarterly instead of monthly cadences

https://docs.google.com/spreadsheets/d/1_ZnsiL_N4s4c-_KrKE5XqsqugvkLfg-nkkqWfYN0lWc/edit#gid=360804146

Added Model B to reflect Corvault cost model


Validate mempool-specific transaction consensus rules

Motivation
Transactions must be validated before being added to the mempool. In https://github.com/ZcashFoundation/zebra/pull/2679 we just call the existing transaction verifier. The only specific check added there is to make sure there aren't coinbased inputs if it's a mempool transaction.
However, there may be other mempool-specific rules that we need to enforce. We should review which of them are already being checked and implement any rules missing, if any.
Specifications
There isn't any official specification for mempool-specific rules, but https://en.bitcoin.it/wiki/Protocol_rules#.22tx.22_messages seems to be a good reference. It may be also helpful to check what zcashd does.
ZIP 401: Addressing Mempool Denial-of-Service might have some useful rules, but it's zcashd-specific.
Designs

Related Work
Follow up to https://github.com/ZcashFoundation/zebra/pull/2679

I added ZIP-401 to the specs section, added this ticket to the tracking issue, and tweaked the name so it made sense in the tracking issue.

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @upbqdn

Quoting @teor2345 from a source external to github:

We checked the ZIPs and specs for mempool-specific consensus rules. And we're validating the 4 we know about. (Transaction size limit, no coinbase transactions, expiry of transactions in the mempool, and clearing the mempool on network upgrades.)

Anything that we are not validating is therefore an "undocumented mempool transaction validation rule" and as such I will close this issue for now. If we do find any undocumented mempool transaction validation rules we should open a separate issue for each rule that we find.

We checked the ZIPs and specs for mempool-specific consensus rules. And we're validating the 4 we know about. (Transaction size limit, no coinbase transactions, expiry of transactions in the mempool, and clearing the mempool on network upgrades.)

Anything that we are not validating is therefore an "undocumented mempool transaction validation rule" and as such I will close this issue for now. If we do find any undocumented mempool transaction validation rules we should open a separate issue for each rule that we find.

Just for the record, the Bitcoin and zcashd mempools cache transactions with missing inputs (orphans), until they can be validated.
For Zebra, we decided on an alternative implementation:

connect to lots of nodes
crawl other nodes' mempools periodically
un-reject transactions with missing outputs when the chain tip block changes


Can't access the documentation page

When visiting https://money-legos.studydefi.com/ I would get
`Secure Connection Failed
An error occurred during a connection to money-legos.studydefi.com. Peer reports it experienced an internal error.
Error code: SSL_ERROR_INTERNAL_ERROR_ALERT`
The error is on all web browsers that I tried (Chrome, Firefox).
Is there any other web page with docs?

same here.

This might be able to help you - https://money-legos-git-dydx-study-defi.vercel.app/#/dydx


Renaming structs following tips from GoLint

Closing this for the same reason as https://github.com/Shopify/sarama/pull/829


Apply Dscanner checks only to specific modules

This enables https://github.com/dlang-community/D-Scanner/pull/460 for Phobos.
Selective checks are great because

we can incrementally introduce new checks (no need for big all or nothing PRs anymore)
we can disable a specific static code analysis check for e.g.

etc (e.g. +std or -etc)
deprecated Phobos modules -std.outbuffer,-std.xml

Especially the ability to gradually introduce new checks means that enabling a check can be a distributed, "crowd-sourced" effort :)
For example,

has_public_example was only a "workaround" against the absence of selective filtering in Dscanner
once a module has been "fixed" for a specific check (e.g. every function should have a public unittest, every function should have a ddoc header, ...) the check can be extended to this modules which allows to automatically prevent regressions

CC @andralex @CyberShadow @JackStouffer

What's with Jenkins again?

What's with Jenkins again?

DUB's test suite is quite nasty as it neither doesn't stop on an error nor makes it easy to search for it. The trick seems to be to search for "31m", which yields this:
Fetching dub 0.9.20...
Fetching dub 0.9.21...
Cannot remove package 'dub', there are multiple possibilities at location
'user'.
Available versions:
  0.9.20
  ~master
  1.1.0
Please specify a individual version using --version=... or use the wildcard --version=* to remove all versions.
Script failure.

Will close & restart to see if it's transient ...

DUB's test suite is quite nasty as it neither doesn't stop on an error nor makes it easy to search for it. The trick seems to be to search for "31m", which yields this:

A small step to make the output of DUB's testsuite a bit easier to digest for humans: https://github.com/dlang/dub/pull/1156

Will close & restart to see if it's transient ...

It seems that Jenkins doesn't restart on close events anymore?
I could reproduce the failure on my machine and I submitted a PR:
https://github.com/dlang/dub/pull/1157
Though I am not sure why this this only happening on a "transient basis"...

Should be doable with Dustmite :)

Without running into a AssertionError in Dscanner and multiple times in libddoc, this is might have been possible without Dustmite. So with hacked t
Anyhow, thanks to a script that I hacked together, here's a working blacklist to get us started:
asm_style_check="-std.math"
auto_ref_assignment_check="-std.algorithm.mutation,-std.format"
could_be_immutable_check="-std.algorithm.comparison,-std.algorithm.iteration,-std.algorithm.mutation,-std.algorithm.searching,-std.algorithm.setops,-std.algorithm.sorting,-std.array,-std.base64,-std.bigint,-std.bitmanip,-std.complex,-std.concurrency,-std.container,-std.container.array,-std.container.binaryheap,-std.container.dlist,-std.container.rbtree,-std.container.slist,-std.container.util,-std.conv,-std.csv,-std.datetime,-std.datetime.date,-std.datetime.interval,-std.datetime.stopwatch,-std.datetime.systime,-std.datetime.timezone,-std.digest.crc,-std.digest.digest,-std.digest.hmac,-std.digest.md,-std.digest.murmurhash,-std.digest.ripemd,-std.digest.sha,-std.encoding,-std.exception,-std.experimental.allocator,-std.experimental.allocator.building_blocks.affix_allocator,-std.experimental.allocator.building_blocks.allocator_list,-std.experimental.allocator.building_blocks.bitmapped_block,-std.experimental.allocator.building_blocks.bucketizer,-std.experimental.allocator.building_blocks.fallback_allocator,-std.experimental.allocator.building_blocks.free_list,-std.experimental.allocator.building_blocks.free_tree,-std.experimental.allocator.building_blocks.kernighan_ritchie,-std.experimental.allocator.building_blocks.region,-std.experimental.allocator.building_blocks.stats_collector,-std.experimental.allocator.gc_allocator,-std.experimental.allocator.mallocator,-std.experimental.allocator.typed,-std.experimental.checkedint,-std.experimental.logger.core,-std.experimental.logger.multilogger,-std.experimental.typecons,-std.file,-std.format,-std.functional,-std.getopt,-std.internal.cstring,-std.internal.digest.sha_SSSE3,-std.internal.math.biguintcore,-std.internal.math.biguintnoasm,-std.internal.math.biguintx86,-std.internal.math.errorfunction,-std.internal.math.gammafunction,-std.internal.scopebuffer,-std.internal.test.dummyrange,-std.json,-std.math,-std.mathspecial,-std.meta,-std.mmfile,-std.net.curl,-std.net.isemail,-std.numeric,-std.outbuffer,-std.parallelism,-std.path,-std.process,-std.random,-std.range,-std.range.interfaces,-std.range.primitives,-std.regex,-std.regex.internal.backtracking,-std.regex.internal.generator,-std.regex.internal.ir,-std.regex.internal.kickstart,-std.regex.internal.parser,-std.regex.internal.tests,-std.regex.internal.thompson,-std.signals,-std.socket,-std.stdio,-std.string,-std.uni,-std.uri,-std.utf,-std.uuid,-std.variant,-std.windows.registry,-std.xml,-std.zip,-std.zlib"
exception_check="-std.concurrency,-std.net.curl,-std.parallelism,-std.range,-std.socket"
function_attribute_check="-std.algorithm.iteration,-std.concurrency,-std.conv,-std.datetime.interval,-std.exception,-std.functional,-std.net.curl,-std.numeric,-std.parallelism,-std.random,-std.range,-std.range.primitives,-std.socket,-std.uni"
imports_sortedness="-etc.c.curl,-std.algorithm.comparison,-std.algorithm.internal,-std.algorithm.iteration,-std.algorithm.mutation,-std.algorithm.searching,-std.algorithm.setops,-std.algorithm.sorting,-std.array,-std.bigint,-std.bitmanip,-std.c.freebsd.socket,-std.c.linux.pthread,-std.c.process,-std.complex,-std.concurrency,-std.container.array,-std.container.binaryheap,-std.container.dlist,-std.container.rbtree,-std.container.slist,-std.container.util,-std.conv,-std.datetime,-std.datetime.date,-std.datetime.interval,-std.datetime.systime,-std.datetime.timezone,-std.digest.digest,-std.digest.hmac,-std.exception,-std.experimental.allocator,-std.experimental.allocator.building_blocks,-std.experimental.allocator.building_blocks.affix_allocator,-std.experimental.allocator.building_blocks.allocator_list,-std.experimental.allocator.building_blocks.free_list,-std.experimental.allocator.building_blocks.free_tree,-std.experimental.allocator.building_blocks.kernighan_ritchie,-std.experimental.allocator.building_blocks.region,-std.experimental.allocator.common,-std.experimental.allocator.mallocator,-std.experimental.allocator.mmap_allocator,-std.experimental.allocator.showcase,-std.experimental.allocator.typed,-std.experimental.checkedint,-std.experimental.logger.core,-std.experimental.typecons,-std.file,-std.format,-std.functional,-std.getopt,-std.internal.math.biguintcore,-std.internal.test.dummyrange,-std.json,-std.math,-std.meta,-std.mmfile,-std.net.curl,-std.net.isemail,-std.numeric,-std.outbuffer,-std.parallelism,-std.path,-std.process,-std.random,-std.range,-std.range.primitives,-std.regex,-std.regex.internal.backtracking,-std.regex.internal.generator,-std.regex.internal.kickstart,-std.regex.internal.parser,-std.regex.internal.tests,-std.signals,-std.socket,-std.stdio,-std.string,-std.uni,-std.utf,-std.uuid,-std.variant,-std.windows.charset,-std.windows.registry,-std.windows.syserror,-std.zip"
label_var_same_name_check="-std.algorithm.iteration,-std.algorithm.sorting,-std.array,-std.bigint,-std.bitmanip,-std.conv,-std.encoding,-std.experimental.allocator.building_blocks.segregator,-std.experimental.typecons,-std.format,-std.internal.digest.sha_SSSE3,-std.parallelism,-std.process,-std.utf"
length_subtraction_check="-std.algorithm.internal,-std.algorithm.iteration,-std.algorithm.mutation,-std.algorithm.searching,-std.algorithm.sorting,-std.array,-std.concurrency,-std.container.array,-std.container.binaryheap,-std.conv,-std.datetime.timezone,-std.experimental.allocator.building_blocks.segregator,-std.experimental.logger.core,-std.file,-std.format,-std.getopt,-std.internal.math.biguintcore,-std.internal.math.biguintnoasm,-std.internal.math.biguintx86,-std.internal.scopebuffer,-std.math,-std.net.curl,-std.net.isemail,-std.numeric,-std.parallelism,-std.path,-std.process,-std.range,-std.regex,-std.regex.internal.parser,-std.regex.internal.tests,-std.string,-std.uni,-std.windows.charset,-std.windows.registry,-std.zip"
logical_precedence_check="-std.algorithm.mutation,-std.algorithm.searching,-std.algorithm.setops,-std.algorithm.sorting,-std.array,-std.container.array,-std.conv,-std.experimental.checkedint,-std.file,-std.format,-std.getopt,-std.math,-std.net.isemail,-std.path,-std.range,-std.range.primitives,-std.stdio,-std.string"
long_line_check="-std.regex.internal.thompson"
mismatched_args_check="-std.container.dlist,-std.encoding,-std.internal.math.biguintcore,-std.math,-std.net.curl,-std.numeric,-std.range.primitives,-std.uni"
number_style_check="-std.algorithm.iteration,-std.algorithm.sorting,-std.array,-std.bigint,-std.bitmanip,-std.container.array,-std.conv,-std.datetime.date,-std.datetime.systime,-std.datetime.timezone,-std.digest.crc,-std.digest.digest,-std.digest.md,-std.digest.ripemd,-std.digest.sha,-std.experimental.allocator.building_blocks.free_tree,-std.experimental.allocator.building_blocks.kernighan_ritchie,-std.experimental.checkedint,-std.file,-std.format,-std.functional,-std.internal.math.biguintcore,-std.internal.math.gammafunction,-std.json,-std.math,-std.outbuffer,-std.parallelism,-std.random,-std.range,-std.regex.internal.generator,-std.utf,-std.zip,-std.zlib"
object_const_check="-std.algorithm.searching,-std.array,-std.bitmanip,-std.concurrency,-std.container.rbtree,-std.conv,-std.datetime.interval,-std.encoding,-std.exception,-std.experimental.checkedint,-std.experimental.logger.core,-std.experimental.typecons,-std.format,-std.functional,-std.meta,-std.numeric,-std.range,-std.regex,-std.stdio,-std.variant,-std.xml"
opequals_tohash_check="-std.algorithm.searching,-std.array,-std.complex,-std.container.array,-std.container.dlist,-std.container.rbtree,-std.container.slist,-std.datetime,-std.datetime.date,-std.experimental.checkedint,-std.functional,-std.internal.test.dummyrange,-std.json,-std.numeric,-std.random,-std.range,-std.socket,-std.uni"
properly_documented_public_functions="-etc.c.odbc.sql,-etc.c.odbc.sqlext,-etc.c.zlib,-std.algorithm.comparison,-std.algorithm.iteration,-std.algorithm.mutation,-std.algorithm.searching,-std.algorithm.setops,-std.algorithm.sorting,-std.array,-std.ascii,-std.base64,-std.bigint,-std.bitmanip,-std.complex,-std.container,-std.container.array,-std.container.binaryheap,-std.container.dlist,-std.container.rbtree,-std.container.slist,-std.container.util,-std.csv,-std.datetime,-std.datetime.date,-std.datetime.interval,-std.datetime.stopwatch,-std.datetime.systime,-std.datetime.timezone,-std.demangle,-std.digest.crc,-std.digest.digest,-std.digest.hmac,-std.digest.md,-std.digest.murmurhash,-std.digest.ripemd,-std.digest.sha,-std.encoding,-std.exception,-std.experimental.allocator,-std.experimental.allocator.building_blocks.affix_allocator,-std.experimental.allocator.building_blocks.allocator_list,-std.experimental.allocator.building_blocks.bitmapped_block,-std.experimental.allocator.building_blocks.bucketizer,-std.experimental.allocator.building_blocks.fallback_allocator,-std.experimental.allocator.building_blocks.free_list,-std.experimental.allocator.building_blocks.free_tree,-std.experimental.allocator.building_blocks.kernighan_ritchie,-std.experimental.allocator.building_blocks.null_allocator,-std.experimental.allocator.building_blocks.quantizer,-std.experimental.allocator.building_blocks.region,-std.experimental.allocator.building_blocks.scoped_allocator,-std.experimental.allocator.building_blocks.segregator,-std.experimental.allocator.building_blocks.stats_collector,-std.experimental.allocator.common,-std.experimental.allocator.gc_allocator,-std.experimental.allocator.mallocator,-std.experimental.allocator.showcase,-std.experimental.allocator.typed,-std.experimental.checkedint,-std.experimental.logger.core,-std.experimental.logger.filelogger,-std.file,-std.format,-std.functional,-std.getopt,-std.internal.cstring,-std.internal.math.biguintcore,-std.internal.math.biguintnoasm,-std.internal.scopebuffer,-std.internal.test.dummyrange,-std.internal.unicode_tables,-std.json,-std.math,-std.mathspecial,-std.meta,-std.mmfile,-std.net.curl,-std.net.isemail,-std.numeric,-std.outbuffer,-std.parallelism,-std.path,-std.random,-std.range,-std.range.interfaces,-std.range.primitives,-std.regex,-std.regex.internal.backtracking,-std.regex.internal.ir,-std.regex.internal.kickstart,-std.regex.internal.parser,-std.regex.internal.thompson,-std.signals,-std.socket,-std.stdio,-std.string,-std.uni,-std.uri,-std.utf,-std.uuid,-std.variant,-std.xml,-std.zip,-std.zlib"
redundant_attributes_check="-std.concurrency,-std.digest.md,-std.digest.ripemd,-std.digest.sha,-std.internal.math.biguintcore,-std.math,-std.meta,-std.range,-std.regex.internal.ir,-std.uni,-std.windows.registry"
style_check="-etc.c.curl,-etc.c.odbc.sqlext,-etc.c.odbc.sqltypes,-etc.c.odbc.sqlucode,-etc.c.sqlite3,-etc.c.zlib,-std.algorithm.comparison,-std.algorithm.internal,-std.algorithm.iteration,-std.algorithm.mutation,-std.algorithm.sorting,-std.array,-std.base64,-std.bitmanip,-std.c.linux.linux,-std.compiler,-std.container.array,-std.conv,-std.datetime.date,-std.datetime.interval,-std.datetime.systime,-std.digest.digest,-std.digest.murmurhash,-std.digest.sha,-std.encoding,-std.exception,-std.experimental.allocator,-std.experimental.allocator.building_blocks.affix_allocator,-std.experimental.allocator.building_blocks.allocator_list,-std.experimental.allocator.building_blocks.bucketizer,-std.experimental.allocator.building_blocks.fallback_allocator,-std.experimental.allocator.building_blocks.free_list,-std.experimental.allocator.building_blocks.free_tree,-std.experimental.allocator.building_blocks.null_allocator,-std.experimental.allocator.building_blocks.region,-std.experimental.allocator.building_blocks.segregator,-std.experimental.allocator.common,-std.experimental.allocator.gc_allocator,-std.experimental.allocator.mallocator,-std.experimental.allocator.mmap_allocator,-std.experimental.checkedint,-std.experimental.typecons,-std.format,-std.functional,-std.getopt,-std.internal.digest.sha_SSSE3,-std.internal.math.errorfunction,-std.internal.math.gammafunction,-std.internal.test.dummyrange,-std.internal.unicode_tables,-std.json,-std.math,-std.meta,-std.numeric,-std.parallelism,-std.path,-std.process,-std.random,-std.range,-std.range.primitives,-std.regex,-std.regex.internal.ir,-std.regex.internal.kickstart,-std.signals,-std.socket,-std.stdio,-std.string,-std.uni,-std.uri,-std.utf,-std.uuid,-std.variant,-std.zlib"
undocumented_declaration_check="-etc.c.curl,-etc.c.odbc.sql,-etc.c.odbc.sqlext,-etc.c.odbc.sqltypes,-etc.c.odbc.sqlucode,-etc.c.sqlite3,-etc.c.zlib,-std.algorithm.sorting,-std.array,-std.ascii,-std.base64,-std.bitmanip,-std.c.linux.linux,-std.c.linux.socket,-std.c.osx.socket,-std.c.process,-std.compiler,-std.complex,-std.concurrency,-std.container,-std.container.array,-std.container.binaryheap,-std.container.dlist,-std.container.rbtree,-std.container.slist,-std.conv,-std.csv,-std.datetime.date,-std.digest.digest,-std.digest.hmac,-std.digest.md,-std.digest.murmurhash,-std.digest.ripemd,-std.digest.sha,-std.encoding,-std.exception,-std.experimental.allocator,-std.experimental.allocator.building_blocks.affix_allocator,-std.experimental.allocator.building_blocks.allocator_list,-std.experimental.allocator.building_blocks.bitmapped_block,-std.experimental.allocator.building_blocks.fallback_allocator,-std.experimental.allocator.building_blocks.free_list,-std.experimental.allocator.building_blocks.free_tree,-std.experimental.allocator.building_blocks.kernighan_ritchie,-std.experimental.allocator.building_blocks.quantizer,-std.experimental.allocator.building_blocks.region,-std.experimental.allocator.building_blocks.segregator,-std.experimental.allocator.building_blocks.stats_collector,-std.experimental.allocator.gc_allocator,-std.experimental.allocator.mallocator,-std.experimental.checkedint,-std.experimental.logger.core,-std.experimental.typecons,-std.file,-std.format,-std.functional,-std.internal.digest.sha_SSSE3,-std.internal.math.biguintcore,-std.internal.math.biguintnoasm,-std.internal.math.biguintx86,-std.internal.math.errorfunction,-std.internal.math.gammafunction,-std.internal.test.dummyrange,-std.internal.test.uda,-std.internal.windows.advapi32,-std.json,-std.math,-std.mmfile,-std.numeric,-std.outbuffer,-std.parallelism,-std.path,-std.process,-std.regex,-std.regex.internal.parser,-std.signals,-std.socket,-std.stdio,-std.string,-std.system,-std.uni,-std.utf,-std.variant,-std.windows.charset,-std.windows.registry,-std.windows.syserror,-std.xml,-std.zip,-std.zlib"
unused_label_check="-std.conv,-std.format,-std.internal.math.biguintx86,-std.regex.internal.thompson,-std.signals,-std.uni"
unused_variable_check="-std.algorithm.comparison,-std.algorithm.iteration,-std.algorithm.mutation,-std.algorithm.searching,-std.algorithm.setops,-std.algorithm.sorting,-std.array,-std.bigint,-std.bitmanip,-std.complex,-std.concurrency,-std.container,-std.container.array,-std.container.dlist,-std.container.rbtree,-std.container.slist,-std.conv,-std.csv,-std.datetime,-std.datetime.date,-std.datetime.interval,-std.datetime.stopwatch,-std.datetime.systime,-std.datetime.timezone,-std.digest.crc,-std.digest.digest,-std.digest.md,-std.digest.murmurhash,-std.digest.ripemd,-std.digest.sha,-std.encoding,-std.exception,-std.experimental.allocator,-std.experimental.allocator.building_blocks.affix_allocator,-std.experimental.allocator.building_blocks.bitmapped_block,-std.experimental.allocator.building_blocks.bucketizer,-std.experimental.allocator.building_blocks.kernighan_ritchie,-std.experimental.allocator.building_blocks.stats_collector,-std.experimental.allocator.common,-std.experimental.allocator.gc_allocator,-std.experimental.allocator.mallocator,-std.experimental.allocator.typed,-std.experimental.checkedint,-std.experimental.logger.core,-std.experimental.typecons,-std.file,-std.format,-std.functional,-std.getopt,-std.internal.cstring,-std.internal.digest.sha_SSSE3,-std.internal.math.biguintcore,-std.internal.math.biguintx86,-std.internal.math.errorfunction,-std.internal.scopebuffer,-std.internal.test.dummyrange,-std.json,-std.math,-std.meta,-std.mmfile,-std.net.curl,-std.numeric,-std.parallelism,-std.process,-std.random,-std.range,-std.range.interfaces,-std.range.primitives,-std.regex.internal.backtracking,-std.regex.internal.tests,-std.regex.internal.thompson,-std.signals,-std.socket,-std.stdio,-std.string,-std.uni,-std.uri,-std.utf,-std.uuid,-std.variant,-std.windows.registry,-std.xml,-std.zip,-std.zlib"
useless_initializer="-etc.c.odbc.sqlext,-etc.c.zlib,-std.algorithm.iteration,-std.algorithm.mutation,-std.algorithm.searching,-std.algorithm.setops,-std.algorithm.sorting,-std.array,-std.bigint,-std.bitmanip,-std.compiler,-std.container.array,-std.container.dlist,-std.container.rbtree,-std.conv,-std.csv,-std.datetime.systime,-std.digest.md,-std.digest.murmurhash,-std.digest.ripemd,-std.encoding,-std.exception,-std.experimental.allocator,-std.experimental.allocator.building_blocks.bitmapped_block,-std.experimental.allocator.building_blocks.free_tree,-std.experimental.allocator.building_blocks.kernighan_ritchie,-std.experimental.allocator.common,-std.experimental.allocator.mallocator,-std.experimental.logger.core,-std.experimental.logger.multilogger,-std.file,-std.format,-std.functional,-std.getopt,-std.internal.cstring,-std.internal.digest.sha_SSSE3,-std.internal.math.biguintcore,-std.internal.math.biguintnoasm,-std.internal.math.biguintx86,-std.internal.math.gammafunction,-std.internal.test.dummyrange,-std.json,-std.math,-std.net.curl,-std.numeric,-std.parallelism,-std.path,-std.process,-std.random,-std.range,-std.range.interfaces,-std.range.primitives,-std.regex,-std.regex.internal.backtracking,-std.regex.internal.generator,-std.regex.internal.ir,-std.regex.internal.kickstart,-std.regex.internal.parser,-std.regex.internal.tests,-std.regex.internal.thompson,-std.signals,-std.socket,-std.stdio,-std.string,-std.uni,-std.uri,-std.utf,-std.uuid,-std.variant,-std.windows.registry,-std.windows.syserror,-std.xml,-std.zip,-std.zlib"
vcall_in_ctor="-std.socket,-std.xml"

The script might have a few false positives as after fixing the third error in Dscanner, I used the Pokeman exception catching style (catch(Error e) {}) for every module. Also there, might be a few checks that we never want to enable and could stay in the way of people, but that's also part of the discussion on the follow-up PR ;-)

Wow, some of these are scary long.
Are they all actionable? If a warning has false positives, we should just disable it completely. Linting (where false positives are OK) is fine but should not be clumped together with mandatory checks.

Wow, some of these are scary long.

Yep ...

Are they all actionable?

Hehe, I think most of them are. There are even some are from @andralex and @WalterBright's high-level vision:

Make sure every function in Phobos has an example => has_public_example (I realized that this one apparently isn't part of Dscanner yet)
Make sure every function in Phobos has Params: and Returns: sections http://www.digitalmars.com/d/archives/digitalmars/D/Phobos_Documentation_-_call_to_action_258777.html => properly_documented_public_functions

Actionable

asm_style_check: only std.math
could_be_immutable_check: @JackStouffer and @BBasile are big fans of this
exception_check: Pokemon exception catching style (silent sinkhole for bugs), only a few occurrences
function_attribute_check: duplicate attributes @safe @safe void foo() {}
has_public_example: high-level vision
label_var_same_name_check: very confusing to read, only a few occurrences
long_line_check: fixed in https://github.com/dlang-community/D-Scanner/pull/465
mismatched_args_check: prevents myFunction(counter, obj) for void myFunction(A)(A obj, int counter)
object_const_check: checks whether opEquals, opCmp and toHash are const
opequals_tohash_check checks for aggregates which have opEquals defined, but not toHash
properly_documented_public_functions: high-level vision
redundant_attributes_check: see https://github.com/dlang/phobos/pull/5477
undocumented_declaration_check: prevents accidentally leaked symbols, unfortunately a lot has happend in the past. I tried to fix std.algorithm once: https://github.com/dlang/phobos/pull/4312
unused_label_check: this check doesn't support mixins yet (https://github.com/dlang-community/D-Scanner/issues/467)
unused_variable_check: mostly artifacts from debug sessions

To be discussed

auto_ref_assignment_check: only two occurrences, false positives?
imports_sortedness: I still need to modify the Dscanner check to ignore selective sortedness ...
length_subtraction_check: these may be unsigned and could lead to integer underflow
logical_precedence_check: if (a && b || c) // bad, if (a && (b || c)) // good
number_style_check: big numbers should use an underscore
style_check: many, many symbols aren't named according to the DStyle
useless_initializer: seems to be a quite common pattern in Phobos
vcall_in_ctor: only a four occurrences

If a warning has false positives, we should just disable it completely. Linting (where false positives are OK) is fine but should not be clumped together with mandatory checks.

Yep, especially the newer Dscanner checks might require some dogfooding.
That's why I wanted to move this discussion to a separate PR. Upgrading Dscanner doesn't depend on the setting/agreeing on a blacklist and I also have other PRs (e.g. https://github.com/dlang/phobos/pull/5477) in the queue, which would profit from selective filtering ;-)

has_public_example was only a "workaround" against the absence of selective filtering in Dscanner

Respective PR to "cleanup" the tools repo: https://github.com/dlang/tools/pull/237

Awesome.
Well, I don't see any reason not to go forward with this.


Doesn't capture Cmd & Shift & MouseClick key combo on the Mac

Hi, I love this Keycastr. Works great. I was recording a tutorial and noticed today it didn't pick up
Cmd & Shift & MouseClick key combo.
In InDesign, this key combo is used to Override / Unlock Master Page Items.
Is there any way that this can be picked up by Keycastr in the next iteration?

Have the same problem for IDE. Control+Click is a navigation shortcut

Also a problem for me when demonstrating CAD software.

MouseCastr?
+1 for a mouse Key HUD in the other corner.

These use cases should be covered by the mouse visualizer functionality. More creative or specific ideas could be proposed separately. Thanks


226 teamcity support

As discussed on #226, this will enable statistics in TeamCity by utilizing TeamCity service Messages.
The currently supported TeamCity statistics are:

TeamCity Statistic Key
Description

CodeCoverageL
Line-level code coverage

CodeCoverageC
Class-level code coverage

CodeCoverageM
Method-level code coverage

CodeCoverageAbsLTotal
The total number of lines

CodeCoverageAbsLCovered
The number of covered lines

CodeCoverageAbsCTotal
The total number of classes

CodeCoverageAbsCCovered
The number of covered classes

CodeCoverageAbsMTotal
The total number of methods

CodeCoverageAbsMCovered
The number of covered methods

Is there anyway this can be achieved by simply creating a new reporter? Even if it means re-designing the IReporter interface to be more flexible. Adding a whole new option just for a single CI service seems quite odd

Yeah I can do that

Nevermind, I added a boolean to all reporters indicating if their output should be written to the console or a file. Turned out less jank than I expected

@tonerdo do you care about the drop in coverage? Do I have to do anything else to get this merged?

do you care about the drop in coverage?

Not particularly. This is ready to be merged once you address comments

Thank you!


Ability to run plugin even on failure

Now plugins can determine whether the build has already been marked as failed.
This will be needed when we have BuildConfigs to prune.

Shouldn't there be a code in inner.py which sets the variable appropriately (once the build has finished)? Also, wouldn't it make more sense to name it build_has_failed?
Maybe I just didn't get the patch.

Yes, build_has_failed probably makes more sense.
The point of this change is to allow a post-build plugin to decide how to behave based on whether this build has failed. That's why we have to set the variable as soon as a plugin fails that is not allowed to fail (https://github.com/projectatomic/atomic-reactor/commit/701bf3abdd20a8b11811697a6d53626c7f0ed7cf#diff-6efbaa8f7bea401e03542bd227209afbR218).
Setting it after all the plugins have run would mean no plugin gets to use it.
For an example of this in action, see https://github.com/projectatomic/atomic-reactor/pull/230.

I'm sorry I still don't get it, let me show you how would I implement it.

This is what I would expect this PR to contain: https://github.com/TomasTomecek/atomic-reactor/commit/990fcfb0c9144fee0dbe1e216b22e77518d78ff1

OK, I see what you mean now. Yes, it needs to do that.
However, looking more at that code I see we also need to have a type of plugin that always runs, even if (for example) a pre-build plugin failed, or the Docker build itself failed. Maybe it could be called CleanupPlugin.
I'll look at adding this.

https://github.com/projectatomic/atomic-reactor/issues/110

Oh, didn't see that.

Once we merge this, we should then transform these plugins to be exit plugins:

remove_built_image (removing base image)
store_metadata_in_osv3
store_logs_to_file

We need to decide which approach is best: exit plugins, or run_always plugin arguments.

Once we merge this, we should then transform these plugins to be exit plugins:

Oh, we'll need to give exit plugins access to the workflow instance then.

I've changed the ExitPlugin argument from a bool to a DockerBuildWorkflow instance and squashed some commits to make the history nicer. I also changed those plugins to be exit plugins.

Oh, remove_built_image needs the tasker as well.

I've added a test case to show how exit plugins work. It also has machinery for checking the case where the first of two prebuild plugins fails, but it's commented out (last line). Currently the second plugin will still run... is that what we want?

(coveralls failure is due to pulp test no longer getting run, see https://github.com/release-engineering/dockpulp/pull/16)

I've changed the plugin failure hook so that it sets plugin_failed instead of build_failed, and added a build_process_failed property. CI failures are my fault but elsewhere :-(

Very nice! Ready for merge?

Actually, no, I think the conversion of some plugins to exit plugins isn't complete. I'll fix that up.

Previously, an older osbs-client would try running what are now exit plugins as postbuild plugins, and they would not run. Now ExitPlugin inherits from PostBuildPlugin, and the plugins runner logs an error if an exit plugin is being run as a post-build plugin.
The upshot is that we now provide more compatibility for older osbs-client versions. Note: we still need to update osbs-client to actually run the exit plugins as exit plugins not post-build plugins.
This is ready for merge, with one open question: is this test valid? https://github.com/projectatomic/atomic-reactor/commit/0f218ecb8b3d2d98880dc1085406326a3e09a5d2#diff-1d4c7d01e22fd1091edb1a829562521cR261

Let's leave the issue of running all plugins of a certain type even when one fails until after this PR is merged. For now, I've added a test to verify the current behaviour.
Ready for merge.

Fixes #110.

I thought this is already merged. Can you rebase please? (I should have merged this first, sorry about that)

Rebased and fixed a conflict caused by the movement of test_rpmqa_plugin().


Add plan-wide region variable to configure sunbeam region

Requires:

[ ] https://review.opendev.org/c/openstack/sunbeam-charms/+/918972

force push is rebase on main


Strange exception error given when invalid Thread_ID given

An odd exception occurs when an invalid thread_id or board is given. This is unhelpful to the developer, as it gives no indication that there are any issues with thread_ids. It can be avoided by simply providing a valid thread ID though.
On basc_py4chan, it simply gives an empty thread object. Maybe there should be exception handling?

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/amersel/Git/py420chan/py420chan/board.py", line 140, in get_thread
    thread = Thread._from_request(self, res, thread_id)
  File "/home/amersel/Git/py420chan/py420chan/thread.py", line 53, in _from_request
    return cls._from_json(res.json(), board, id)
  File "/home/amersel/Git/py420chan/py420chan/thread.py", line 62, in _from_json
    head, rest = posts[0], posts[1:]
IndexError: string index out of range

completed in this commit, returns None object on IndexError
https://github.com/bibanon/py420chan/commit/da67c81d3504e568b23f42a1dd3404d2d6eeb9b4


Make Fragment an Element

Closes #205
Fragments can now be used directly as children of a component:
local function component()
    return Roact.createElement("Frame", {}, {
        fragments = Roact.createFragment({
            A = Roact.createElement("Frame", {}, {})
        })
    })
end

Turning Fragments into Elements make them have their own virtual node, so they can be reconciled as any other nodes.
I'm not so sure about how to write good tests for that, let me know what's the best way (not sure where to assert exactly).
Checklist before submitting:

[ ] Added entry to CHANGELOG.md
[ ] Added/updated relevant tests
[ ] Added/updated documentation

For testing, I think it should be possible to use the mountVirtualNode method of the reconciler to get back a tree of virtual nodes that you can introspect to some degree? I'm not sure if you'll run into issues with data contained in private internal tables, but I don't think you will.
Look at some of the other tests in createReconciler.spec.lua for ideas, but I think the way to go is to get a tree of nodes and expect things like Type.of(node.currentElement) and hostKey and children, etc.
As for what cases to test, I'd just try combinations of places you can put fragments? An element with fragments in its children is a good start.
I'd also test things that will have name duplication and make sure they work out correctly, but those tests are more involved.

Closing and re-opening to trigger CI checks.

Coverage decreased (-0.2%) to 93.012% when pulling 6465b0c11e7a416a28d48fff8d4122e1cbb46da7 on jeparlefrancais:fragment-fix into b1db3f82a2510c4e5e5b2bdc2c47298ea02dabd8 on Roblox:master.