Auto fetch images from upstream-source

wouldn't it be even nicer to template the images and fetch them from the individual charm's metadata.resources.{image_name}.upstream-source?

Originally posted by @PietroPasotti in https://github.com/canonical/cos-lite-bundle/pull/51#pullrequestreview-1193337354
Instead of hardcoding the images in the .j2.yaml, and keep remembering to update it when we update the underlying charms, the rendering script could auto fetch the upstream-source for every charm.
This is relevant for testing purposes when rendering a bundle with one or more charms from local path, e.g.:
./render_bundle.py local.yaml \
  --prometheus ../prometheus-k8s-operator/prometheus-k8s_ubuntu-20.04-amd64.charm`

Yes, that could be awesome @PietroPasotti.
render_bundle could have the urls to the metadata.yamls hardcoded and fetch from there. But then we won't be able to render the bundle yaml without internet.

Also need to remember to update the bundle every time we update the images.

We should update this manually when we notice it's off. There is not enough value in this to motivate building parse and replace automation for it.


Ability to customize which Markdown processor is used

I would like the ability to specify which markdown processor is used for processing the markdown text. The Caius based one is decent but does not handle all embedded HTML fragments.
~As a generalization, ability to support multiple processors (markdown, asciidoc etc.) would be even better, based on the file extension for example.~ -->  #65

I made a separate issue for your second paragraph.

Done in 60c1a463281d93db63c808988d1bcac588448593.


6pm a tutor office hour table

If this PR is not ready for review, please convert this PR to a draft. Also, please make sure you add a description to this PR!


[Feature]: Givecoreax.metric.MMD and coreax.weights.MMD unique names

Describe the feature that you would like.*
There exists both coreax.metric.MMD and coreax.weights.MMD, but it is not clear to a newcomer that the following are not importing the same class:
from coreax import MMD # coreax.metric.MMD
from coreax.weights import MMD # coreax.weights MMD

In the examples this requires:
from coreax import MMD
from coreax.weights import MMD as MMDWeightsOptimiser

If the coreax.weights.MMD is renamed to coreax.weights.MMDWeightsOptimiser then any ambiguity is removed.
Why is this feature valuable to you?*
Results in an easier to understand codebase.
Describe alternatives you've considered
No response
Additional context
No response
Code of Conduct*

[X] I agree to follow this project's Code of Conduct

Also SBQWeightsOptimiser.


Factor out simplejson and just use json

json is stdlib and since elastalert doesn't support python2.6 it doesn't
provide any speed benefits.  It also looks like (?) it was only being used in
a test?

CC @Qmando


Add minimal hierarchical widget definition

Add an new widget enum variant for a hierarchical widget, with no actual implementation. That way it can be used during development of vector editor before widget tree implementation is done.

@Frizi please add at least short description.

Since the vector editor needs to be usable on its own, it won't be using that temporary hierarchical widget. Instead, it will hardcode its own "code editor" widget for all entries until the widget hierarchy is done. This task is no longer needed.


Show command to download SBOM in component list page

Fixes

https://issues.redhat.com/browse/HAC-3318

Description

Show download SBOM command in the components list page.

Type of change

[x] Feature

Screen shots / Gifs for design review

https://user-images.githubusercontent.com/6041994/223459240-4c4cb9d4-761b-492d-ab9d-4ddbb5446b04.mov
Browser conformance:

[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

/lgtm

Merging this PR as the PR checks environment is broken because of the cluster being upgraded right now.


Revert "wrappers: remove shorthandOnlyDefinesConfig"

This reverts commit 8549bbeb0c4b2fce7baa64a7e424e1f48eadf6a6.
Fixes #1042 #1043

I pointed my flake input to that 0250b29d255f33bc3f483f9c6ad6045430fc1c12 and was able to successfully build my configuration.


Image inputs ollama support

Ollama image support, based on @langchain4j from image_input branch.

@bidek it was closed automatically for some reason when I merged my PR... Could you please reopen it against main branch? Thank you!


Docker support

Providing a dockerized version of justpy would be helpful e.g. for testing

scripts/rundocker test
[+] Building 0.6s (11/11) FINISHED
 => [internal] load build definition from Dockerfile                               0.0s
 => => transferring dockerfile: 37B                                                0.0s
 => [internal] load .dockerignore                                                  0.0s
 => => transferring context: 2B                                                    0.0s
 => [internal] load metadata for docker.io/library/python:3.10-slim                0.5s
 => [1/7] FROM docker.io/library/python:3.10-slim@sha256:59129c9fdea259c6a9b6d9c6  0.0s
 => CACHED [2/7] WORKDIR /usr/src/                                                 0.0s
 => CACHED [3/7] RUN pip install --no-cache-dir justpy                             0.0s
 => CACHED [4/7] RUN apt update                                                    0.0s
 => CACHED [5/7] RUN apt install -y git                                            0.0s
 => CACHED [6/7] RUN git clone https://github.com/elimintz/justpy                  0.0s
 => CACHED [7/7] RUN pip install green                                             0.0s
 => exporting to image                                                             0.0s
 => => exporting layers                                                            0.0s
 => => writing image sha256:b12cd8554c0ece59fb576cefe05a2ea4fc65c42650d5129d67f47  0.0s
 => => naming to docker.io/library/justpy-dev                                      0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
..

Captured stdout for tests.test_demjson.TestDemJson.testDemjson
Starting test testDemjson, debug=False ...
test testDemjson, debug=False took   0.0 s

Captured stdout for tests.test_importability.TestImportability.test_importability
Starting test test_importability, debug=False ...
/mnt/justpy
Module directory: /mnt/justpy, Application directory: /mnt
test test_importability, debug=False took   0.2 s

Ran 2 tests in 0.284s using 8 processes

OK (passes=2)

scripts/rundocker
[+] Building 0.7s (7/7) FINISHED
 => [internal] load build definition from Dockerfile                               0.0s
 => => transferring dockerfile: 37B                                                0.0s
 => [internal] load .dockerignore                                                  0.0s
 => => transferring context: 2B                                                    0.0s
 => [internal] load metadata for docker.io/library/python:3.10-slim                0.6s
 => [1/3] FROM docker.io/library/python:3.10-slim@sha256:59129c9fdea259c6a9b6d9c6  0.0s
 => CACHED [2/3] WORKDIR /usr/src/                                                 0.0s
 => CACHED [3/3] RUN pip install --no-cache-dir justpy                             0.0s
 => exporting to image                                                             0.0s
 => => exporting layers                                                            0.0s
 => => writing image sha256:5e64e7995717d0f24f37191440b08bf2c3c8f6586fd6878c0bd3c  0.0s
 => => naming to docker.io/library/justpy                                          0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
root@1135e29f9adf:/mnt# ls
LICENSE    docker  examples  pyproject.toml  tests
README.md  docs    justpy    scripts	     tutorial

scripts/rundocker dev
[+] Building 1.3s (11/11) FINISHED
 => [internal] load build definition from Dockerfile                               0.0s
 => => transferring dockerfile: 37B                                                0.0s
 => [internal] load .dockerignore                                                  0.0s
 => => transferring context: 2B                                                    0.0s
 => [internal] load metadata for docker.io/library/python:3.10-slim                1.2s
 => [1/7] FROM docker.io/library/python:3.10-slim@sha256:59129c9fdea259c6a9b6d9c6  0.0s
 => CACHED [2/7] WORKDIR /usr/src/                                                 0.0s
 => CACHED [3/7] RUN pip install --no-cache-dir justpy                             0.0s
 => CACHED [4/7] RUN apt update                                                    0.0s
 => CACHED [5/7] RUN apt install -y git                                            0.0s
 => CACHED [6/7] RUN git clone https://github.com/elimintz/justpy                  0.0s
 => CACHED [7/7] RUN pip install green                                             0.0s
 => exporting to image                                                             0.0s
 => => exporting layers                                                            0.0s
 => => writing image sha256:b12cd8554c0ece59fb576cefe05a2ea4fc65c42650d5129d67f47  0.0s
 => => naming to docker.io/library/justpy-dev                                      0.0s

Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
root@c4429ef1da39:/mnt# cd /usr/src/justpy/
root@c4429ef1da39:/usr/src/justpy# ls
LICENSE  README.md  docs  examples  justpy  pyproject.toml  scripts  tests  tutorial

@WolfgangFahl should we also provide this image on https://hub.docker.com/?

@rodja  yes this would be good but i'd prefer to have a solution for showing off all demos in the docker image.
on jpdemo.bitplan.com i am currently starting a process per demo and use apache redirects. In a docker image apache is a bit heavy wait and i wonder whether we could do the "routing" with a justpy frontend app instead. In the long run I'd love to supply all some 150 tutorial examples this way.
#!/bin/bash
# WF 2022-05-15
# start Justpy demo code

# goto project directory
cd $HOME/source/python/pyJustpyWidgets
# get current version
git pull
# install dependencies
scripts/install
# prepare logging
logroot="/var/log/jpdemo"
if [ ! -d $logroot ]
then
  sudo mkdir -p $logroot
  sudo chgrp $(id -g) $logroot
  sudo chmod g+w $logroot
fi

initIndex() {
  local lIndex="$1"
  sudo touch $lIndex
  sudo chown www-data.www-data $lIndex
  sudo chmod 660 $lIndex
cat << EOF > $lIndex

Justpy Demo

wiki.bitplan.com links

Justpy

pyJustpyWidgets

Demos

example	source

EOF
}
addEntryToIndex() {
  local l_Index="$1"
  local l_module="$2"
  local l_name="$3"
cat << EOF >> $l_Index

$l_name	$l_module

EOF
}

closeIndex()  {
  local l_Index="$1"
cat << EOF >> $l_Index

EOF
}

initRedirectMap() {
  local l_rMap="$1"
  cat << EOF > $l_rMap
#
# this file is the Apache Webserver redirect map for the
# jpdemo.bitplan.com website
#
# WF 2022-05-15
#
# this example is created with the jpdemo script
#
# see documentation for Apache RewriteMap at
# https://httpd.apache.org/docs/2.4/rewrite/rewritemap.html
#
# if you need redirects with anchors see:
#  https://stackoverflow.com/questions/2686075/mod-rewrite-with-anchor-link
#  https://stackoverflow.com/a/2686157/1497139
#  so the no escape flag is needed [NE]
#
EOF
   sudo chown www-data.www-data $l_rMap
   sudo chmod g+w $l_rMap
}

addRedirectMapEntry() {
  local l_rMap="$1"
  local l_rLine="$2"
  echo "$2" >> $1
}

export PYTHONPATH=.
port=10000
redirectmap=/var/www/redirects/jpdemo-map.txt
index=/var/www/jpdemo/index.html
initIndex $index
initRedirectMap $redirectmap
host=$(hostname -f)
echo "current directory is $(pwd)"
for module in $(find jpdemo -name "*.py")
do
  moduleName=$(basename $module .py)
  case $moduleName in
    __init__|basedemo)
      ;; # ignore
    *)
     echo "starting $module on port $port"
     pgrep -fla "python $module"
     if [ $? -eq 0 ]
     then
       echo "killing existing demo $moduleName"
       pkill -f "python $module"
     fi
     logfile="$logroot/$moduleName.log"
     nohup python $module --port $port >$logfile 2>&1&
     echo "log file is at $logfile"
     redirectLine="$moduleName http://$host:$port"
     addRedirectMapEntry $redirectmap "$redirectLine"
     addEntryToIndex $index $module $moduleName
     port=$((port+1))
     ;;
  esac
done
closeIndex $index
sudo service apache2 restart


Build warnings

This points out a few build warnings as seen with Clang on macOS, solving one by initialising a variable before use, and blindly suppressing two others by eliminating an unused variable or a lot of dead code. I have not (yet?) analysed what would be the correct solution for the latter two, and the last one seems particularly problematic (how do you test that your test code is indeed executed...). Moral of the story: warnings are people too, don't ignore them!

For the first issue I added some quick-and-dirty code to demonstrate what can go wrong (although unfortunately the issue seems unreachable to a regression test), and for the third issue I re-enabled the code and instead added some assertions that should fail but don't because the code is not being executed.

Is anything still holding you back from integrating this?
The first commit points out the problems, and both commits together constitute a proposed solution. The first issue is pretty clear, even though I failed to tease out failure from the outside without a little help from the inside. For the second and third issues I just guessed, leaving it to you to validate whether those changes are appropriate.

Thanks @rfschtkt, hopefully, the TBB team will review and comment on your proposed bug fixes.

Implemented.


Remove standard iOS powered-off alert.

This removes the standard ios bluetooth is powered off alert (Turn on bluetooth to allow "App Name" to connect to accessories)
Developers can handle this case using noble.on('stateChange',
callback(state)); instead. This is an improvement because it moves the decision of how to handle this case to the javascript.

This seems fine. Ill merge, but probably wont have time to cut a release atm so just grab from head or commit.

Thank you!


onTrial() - replace Carbon::today() with Carbon::now()

Currently following line is used to determine whether a subscription is on a trial.
return Carbon::today()->lt($this->trial_ends_at);
However using Carbon::now() would be more accurate, because in the current version the onTrial method keeps returning true until the next day. This leads to problems. For example if you cancel the subscription after the trial has actually ended (but onTrial still returns true), the line $this->ends_at = $this->trial_ends_at; will be executed, which will lead to the immediate cancellation of the subscription rather than the cancellation at the periods end. (However the user has already payed for the period because the trial has ended in stripe.)

I'm experiencing similar bug -- The trial ends at "2016-09-19 22:35:58" and the subscription ends_at "2016-09-19 22:35:58".  It's currently "2016-09-19 22:40:01 and yet valid() still returns true.  Changing it to today() and it returns false as expected.

I noticed this as well. Definitely doesn't make sense to automatically give users extra time on a trial. If the trial_ends_at is in the past, the trial should be ended, full-stop.

This depends the use case. Some people will allow until the end of the day for the subscription to be canceled, some want it to end at the second the payment cycle is done. My solution would be to override the ends_at column to use Stripe's returned data instead of the one by cashier.

Closing since it's not actually a bug, it's intended.

@themsaid , @Francismori7 You'll note that everywhere in this package a timestamp is needed, even in comparing dates, Carbon::now() is used and not Carbon::today().
So if its intended, its inconsistent and the package should decide on using now or today.
https://github.com/laravel/cashier/blob/7.0/src/Billable.php#L168
https://github.com/laravel/cashier/blob/7.0/src/Subscription.php#L115
https://github.com/laravel/cashier/blob/7.0/src/Subscription.php#L325


:sparkles: Enable to override params at predict time in KedroPipelineModel

Description
Close #445, improve #587  and generalize #580.
The goal is to support inference parameters for KedroPipeline Model, in order to be able to modify inference pipeline behaviour at runtime without retraining (e.g. retraining makes no sense just to change a threshold or the temperature)
Development notes
What have you changed, and how has this been tested?

Pin mlflow>=2.7.0 which is the lowest version that support params
Update MlflowHook to infer parameter signature from the inference pipeline of a PipelineML. this signature is passed when logging the custom model.
Also add a "runner" argument to the signature to enforce the ability
Update KedroPipelineModel.predict to propagate params and use the runner and params provided.

⚠ Passing hooks via this mechanism is out of scope, because they should be defined at logging time and because mlflow supports only native python / pandas / numpy dtypes.
⚠ ~This is heavily tested locally with mlflow==2.17. The CI test suite fails because of unrelated #613.~-> Fixed with kedro-mlflow>=0.13.4.
Checklist

[X] Read the contributing guidelines
[X] Open this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Update the documentation to reflect the code changes
[X] Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
[X] Add tests to cover your changes

Notice

[X] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Calychas This should already work, can you try? If you do'nt have a custom signature in yuor pipeline ml factory, yuo have nothing to change: just train normally and you should see available parameters in the signature of the model in the UI. Then do:
model=mlflow.pyfunc.load_model(f"runs:/{run_id}/{artifact_path}")
model.predict(data, params={"<your_param_name>":<your_param_value>})

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.90%. Comparing base (023049b) to head (fadd662).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #612   +/-   ##
=======================================
  Coverage   99.90%   99.90%
=======================================
  Files          30       30
  Lines        1054     1063    +9
=======================================
+ Hits         1053     1062    +9
  Misses          1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Branch update dg delete task

Codecov Report

Merging #227 (5fa4e86) into master (2d4084d) will increase coverage by 12.74%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master     #227       +/-   ##
=============================================
+ Coverage     55.45%   68.20%   +12.74%
- Complexity      571      706      +135
=============================================
  Files           105      105
  Lines          2420     2434       +14
  Branches        318      325        +7
=============================================
+ Hits           1342     1660      +318
+ Misses          968      635      -333
- Partials        110      139       +29

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/ManualCommand.java
92.85% <0.00%> (-7.15%)
:arrow_down:

...rc/main/java/seedu/address/model/person/Email.java
47.82% <0.00%> (+4.34%)
:arrow_up:

...rc/main/java/seedu/address/model/person/Phone.java
47.82% <0.00%> (+4.34%)
:arrow_up:

...ava/seedu/address/model/person/TelegramHandle.java
47.82% <0.00%> (+4.34%)
:arrow_up:

src/main/java/seedu/address/model/person/Name.java
77.27% <0.00%> (+4.54%)
:arrow_up:

...c/main/java/seedu/address/model/person/Person.java
70.37% <0.00%> (+5.55%)
:arrow_up:

...ain/java/seedu/address/storage/StorageManager.java
100.00% <0.00%> (+5.55%)
:arrow_up:

...a/seedu/address/logic/commands/ArchiveCommand.java
5.55% <0.00%> (+5.55%)
:arrow_up:

src/main/java/seedu/address/model/person/Task.java
91.17% <0.00%> (+5.88%)
:arrow_up:

...ain/java/seedu/address/model/person/StudentId.java
90.00% <0.00%> (+10.00%)
:arrow_up:

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d4084d...5fa4e86. Read the comment docs.


Fix xcode section checking swift and local being displayed globally

Description
Fixes the xcode section from using defined swift variables. Further, it fixes the version being displayed regardless if the local variable was set or not. This is because the global version and local version are both set using a *.xcode-version, versus the swiftenv alternative has a ../version file and a .swift-version file for local folders. Issue on this is posted at #616.
Screenshot
Below is a screenshot displaying the variables from xcenv. Note that the global version here is set to false, and local is set to true. This PR address the issue.

Succeeded by #1268


Remove added id field

Starting from nbformat 4.5 notebook cells must have an id. So adding a new cell with new_code_cell will add a cell with an id field. However, if the notebook was based on a previous version (e.g. 4.2), then it would contain a mix of id and non id cells. Newer versions of nbformat (5.6) raise an error when validating such notebook while before they were mutating it. nbconvert uses nbformat to validate it builds proper notebooks, in particular after applying preprocessors.
This change remove the id added by new_code_cell if the notebook didn't have ids (just checking the first cell, seems enough).

codecov failed on some jobs, other failures are unrelated.


[GA] Add GA4 timing event around detec/fulfill endpoints

This is still somewhat experimental, since GA4 removed native support for page timing events:
https://support.google.com/analytics/answer/9964640#settings-with-no-GA4-equivalent&zippy=%2Cin-this-article
@pradh Adding minimal information first that we can continue to augment if this works, though please let me know if any of the other parameters would be useful to track.

thanks for the reviews! i've added a todo to add past queries.


Add code coverage to main GitHub workflow and upload to Codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@dd63bd7). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #119   +/-   ##
=========================================
  Coverage          ?   95.80%
=========================================
  Files             ?        6
  Lines             ?      286
  Branches          ?        0
=========================================
  Hits              ?      274
  Misses            ?       12
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd63bd7...b208a13. Read the comment docs.

Closed - This seems to report the coverage of the test code. Reworking it.


add integer column type

As a future feature request, can you add integer class to the col_type?
I have a .xlsx spreadsheet with integer-based columns, but read_excel reads them in as character. When I had tried to specify the columns as numeric, I received an error message.
Thank you.

Please provide a reproducible example. There are three things you need to include to make your example reproducible: required packages, data, and code.

Packages should be loaded at the top of the script, so it's easy to
see which ones the example needs. This is a good time to check that you're
using the latest version of each package: it's possible you've discovered
a bug that been fixed since you installed the package.

The easiest way to include data in a question is to use dput() to
generate the R code to recreate it. For example, to recreate the mtcars
dataset in R, I'd perform the following steps:

Run dput(mtcars) in R
Copy the output
In my reproducible script, type mtcars <-  then paste.

Try and find the smallest subset of your data that still reveals
the problem.

Spend a little bit of time ensuring that your code is easy for others to
read:

Make sure you've used spaces and your variable names are concise, yet
informative.

Use comments to indicate where your problem lies.

Do your best to remove everything that is not related to the problem.
The shorter your code is, the easier it is to understand, and the
easier it is to fix.

Finish by checking that you have actually made a reproducible example by starting a fresh R session and copying and pasting your script in.

re-posting a reprex request, that's specific to this project
How to provide a readxl reprex
We're in a much better position to address your issue if you can provide a reprex (reproducible example). Provide as much of this as you can:

An actual xls or xlsx file. Preferably stripped down to the minimal size and complexity to demonstrate your point. And, obviously, stripped of any sensitive data.
A small bit of R code that uses readxl on the provided xls or xlsx file and demonstrates your point.

Consider using the reprex package to prepare this. In addition to nice formatting, this ensures your reprex is self-contained. Currently GitHub-only, but going to CRAN soon.

Any details about your environment that seem clearly relevant, such as operating system.
reprex(..., si = TRUE)
will append a standard summary, folded neatly away, at the bottom of your reprex.

How to provide the xls/xlsx file? In order of preference:

Attach the file directly to your issue. Instructions are always at the bottom of the issue or comment box.
Share via DropBox or Google Drive and provide the link in your issue.
Explain you absolutely cannot provide a relevant file via github.com and offer to provide privately.
Don't share a file and realize you're hoping for, e.g., a bug fix with no concrete example to go on.

Expanded column guessing and specification is now covered by #198.
If you have an example (see above) that sheds light on a new or specific aspect of this, please share and reopen or open a new issue.


add options for parsing a file containing repos

Ref. lib/reel.rb:56
# TODO add options for parsing a file containing repos
# TODO implement downloading a regular URL
# TODO add fish, zsh, and bash support (link and/or source files)

(automatically generated by Github-Todos)

Ref. lib/reel.rb:37
# TODO: add options for parsing a file containing repos
# TODO: implement downloading a regular URL
# TODO: add fish, zsh, and bash support (link and/or source files)
# FIXME: fish loading does not seem to be working

Completed.


Update dependencies for app init to include changes to go base app and demo.json

Description of change
Update dependencies for app init to include changes to go base app and demo.json
Related to: https://github.com/meroxa/turbine/pull/24
Project issue: https://github.com/meroxa/turbine-project/issues/88
Type of change

[ ]  New feature
[ ]  Bug fix
[x]  Refactor
[ ]  Documentation

How was this tested?

[ ]  Unit Tests
[x]  Manual

i don't think all these vendor changes are right... i'm not seeing that locally


[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
Can i turn off the agent log? Our application is in docker, before application load agent that should  copy agent directory  to the application docker image. To prevent the log from being to large that affect running application, we need turn off the agent log. Is there any way to turn off the agent log?
Or are there other better solutions？

You could set the log level to OFF.
# Logging level
logging.level=OFF


Add single docker-compose file for services

Added docker-compose dir to start all services together using single command

@sevenzing is this PR still relevant? otherwise let's close it


add makefile with coverage

Added a new command to makefile, which should allow us to generate coverage output files in html format and view them in browser, without invoking coveralls.io and seeing results locally. In my opinion, this can be something useful for us to get better test coverage. Plus voteup if you think this can be useful.

👍


how to print a div content to pdf using jspdf?

Thank you for submitting an issue to jsPDF. Please read carefully.
Are you using the latest version of jsPDF?
Have you tried using jspdf.debug.js?
Steps to reproduce
Ideally a link too. Try fork this http://jsbin.com/rilace/edit?html,js,output
What I saw
What I expected

exmample:

function export_div(){

	var pdf = new jsPDF("p", "pt", "a4");
	pdf.addHTML($('#div_id'), 15, 15, function() {
	  pdf.save('div.pdf');
	});
}

Hi Nolonolo,
I have already tried with this but it doesn't support the css styles which is applied for the div content
Kindly help me on this

Sorry, I have not tried it. But... Doesn't apply any css style? Is the PDF printed all in one line?

Yeah it doesn't apply any css style but it just print the data as it is how it looks in browser but the styles are not applied while generating the pdf:(


Fix attestations revoking in the app

Expected Behavior
Users / devs can revoke attestations
Current Behavior
Not supported in contract kit Attestations wrapper

Fixed in https://github.com/celo-org/celo-monorepo/pull/4339/files


Failed Startup after coming back to this app

Describe the bug
I used to use once single container version was available for unRAID. I was on 0.6.1. I couldn't login anymore, decided to wipe and start fresh since I didn't do much with it initially, but now I have a new doorbell camera that I can use with it, so I'm back, but even after a clean reinstall, I cannot create an account, getting same error when trying to login on previous install. Same thing with both 0.6.1, and latest 1.1.0 version. I looked at log and it seems to fail at compreface-admin over and over.
To Reproduce
Steps to reproduce the behavior:
Leave default 4 options that seem to use internal database from unRAID template, also clear them all which I think does same thing anyways. Either way is a problem.
Expected behavior
It it load up successfully so I can create and account and login.
Desktop (please complete the following information):

OS: unRAID
Browser: Chrome
Version 108.0.5359.125

Additional context
Log attached next post.

101371cb6ca6406a23c481e25d4efd8b834df276c077e06cd775e6c305834c43-json.log

{"log":"2022-12-19 15:23:44.181 UTC [31] LOG:  could not bind IPv6 address \"::1\": Cannot assign requested address\n","stream":"stdout","time":"2022-12-19T15:23:44.181715269Z"}
{"log":"2022-12-19 15:23:44.181 UTC [31] HINT:  Is another postmaster already running on port 5432? If not, wait a few seconds and retry.\n","stream":"stdout","time":"2022-12-19T15:23:44.181725593Z"}
This is from your logs. It looks like it can't start the database. It says that the port is taken by some other application.
That is strange, as I don't see how postgres can be run twice inside a container
Is it possible you expose the 5432 outside and some other application took it?
I would also recommend deleting the db volume as well:
docker volume rm compreface-db

Now that you mention that, one thing I did in between using this was actually install postgres for something else that does use my server's 5432 port. Would that be conflicting then? If so, since I have postgres now anyways, should I just be using it via the external database option?

Although I shutdown the other postgres and it still doesn't work, still getting error not expected about compreface-admin.

Sorry for a long response
It can't use this PostgresSQL as an external option because to use it as an external option, the database should be set up for this (user and database should be created, only then it will be initialized by CompreFace)
Is the error the same after you shut down other Postgres?
Can you connect to the container and find out what process takes 5432 port?

No problem, thanks. Sorry I didn't update this. I set up a new database within my postgres container for CompreFace and then configured CompreFace to use it and it now works.

im getting this same issue on a fresh install of unraid, but an older server is working perfectly fine. I also know for a fact im not running another server on the same port


[QUESTION] where are @types/tar ^6.0

please: where are @types/tar ^6.0
i only found @types/tar ^4.0

I don't maintain types for this library.  Ask whoever you got types for tar@4 from.


Update direct-routing-connect-the-sbc.md

Fixed a typo

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


[e2e]: container workflow_dispatch main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3391116829
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri Nov  4 04:04:37 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3391116829
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri Nov  4 06:07:00 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/3391629687
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.container.workflow_dispatch.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.container.workflow_dispatch.main.default.slsa3.yml
Trigger: workflow_dispatch
Branch: main
Date: Fri Nov  4 06:14:15 UTC 2022
Tests are passing now. Closing this issue.


Download Archived Results

Just one question: For your pre-processed script you're returning to the user the date that the data was downloaded, correct?

Yep, and placing it in the correct directory so that all downstream analyses can proceed


Use front camera and surface simultaneously

Hi @pedroSG94,
I want to use the front camera to capture my face and also broadcast my screen is it possible to use another RTMP server URL for the camera and another one for screen capture?

You can do it:
https://github.com/pedroSG94/rtmp-rtsp-stream-client-java/issues/497


Ramen Graph: string entry clicked on starts at middle

When clicking on a string entry the cursor starts in the middle of the text box instead of the beginning.  String entry cursor should be at the beginning when string entry is clicked on.

Should be fixed here
https://github.com/louisVottero/vtool/pull/492


fix path

fix everything allowed pod path in README.md

Thank you @JimBugwadia!

Thank you @JimBugwadia!


Sign Packages and Linux Repositories with SHA256.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If contributing rules or changes to rules, please make sure to also uncomment one of the following line:

/kind rule-update

/kind rule-create

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area rules

/area tests

/area proposals

What this PR does / why we need it:
Currently, Falco Linux packages are signed with SHA1. This prevents the installation of Falco on high-assurance systems that do not allow for the installation of packages without signatures made using SHA256.
Which issue(s) this PR fixes:

Fixes #1751
Special notes for your reviewer:
The SHA256 algorithms should be well supported by Linux distributions in use today. I do not believe this this will break installs for anyone.
Does this PR introduce a user-facing change?:
Linux packages and repositories that are created with the modified build scripts will have newer signature algorithms.

update: Linux packages are now signed with SHA256

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: twa16
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

2613bed Set digest-algo for gpg to use SHA256 for linux packages.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Looks like the one fail here is also on the main branch right now so probably no related to the PR.

https://github.com/falcosecurity/falco/pull/1764 should address the failing test. Let's wait for it.

Hey @twa16
#1764 has been merged into master. Could you rebase on master? :pray:  Once done, the failing test should pass.

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

b8f5919 Merge pull request #1 from flickerfly/sha256-rebase

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@twa16: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@leogr  Ok, rebased! Let's see how it goes.

Closing and re-opening to trigger the CI
/close

@leogr: Closed this PR.

In response to this:

Closing and re-opening to trigger the CI
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/reopen

@leogr: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LGTM label has been added.  Git tree hash: f60f9f0e14164f69cce4a38295aca9a6120c459d

/approve
/milestone 0.31.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr, twa16
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Expose examples as their own sections.

This PR exposes examples from doc comments as a section per each example. Should fix https://github.com/MicrosoftDocs/quantum-docs-pr/issues/1121. Marked as draft until an e2e build can verify correct documentation output.
Please see build at https://dev.azure.com/ms-quantum-public/Microsoft Quantum (public)/_build/results?buildId=19347&view=results for documentation built from this PR.

It looks like it works (example below), so moving this out of draft.
---
uid: Microsoft.Quantum.Arrays.All
title: All function
ms.date: 11/23/2020 12:00:00 AM
ms.topic: article
qsharp.kind: function
qsharp.namespace: Microsoft.Quantum.Arrays
qsharp.name: All
qsharp.summary: >-
  Given an array and a predicate that is defined
  for the elements of the array, and checks if all elements of the
  array satisfy the predicate.
---

# All function

Namespace: [Microsoft.Quantum.Arrays](xref:Microsoft.Quantum.Arrays)

Package: [Microsoft.Quantum.Standard](https://nuget.org/packages/Microsoft.Quantum.Standard)

Given an array and a predicate that is defined
for the elements of the array, and checks if all elements of the
array satisfy the predicate.

```qsharp
function All<'T> (predicate : ('T -> Bool), array : 'T[]) : Bool
```

## Input

### predicate : 'T -> [Bool](xref:microsoft.quantum.lang-ref.bool)

A function from `'T` to `Bool` that is used to check elements.

### array : 'T[]

An array of elements over `'T`.

## Output : [Bool](xref:microsoft.quantum.lang-ref.bool)

A `Bool` value of the AND function of the predicate applied to all elements.

## Type Parameters

### 'T

The type of `array` elements.

## Example

The following code checks whether all elements of the array are non-zero:

```qsharp
open Microsoft.Quantum.Arrays;
open Microsoft.Quantum.Logical;

function AllDemo() : Unit {
    let predicate = NotEqualI(_, 0);
    let isNonZero = All(predicate, [2, 3, 4, 5, 6, 0]);
    Message($"{isNonZero}");
}
```

## Remarks

The function is defined for generic types, i.e., whenever we have
an array `'T[]` and a function `predicate: 'T -> Bool` we can produce
a `Bool` value that indicates if all elements satisfy `predicate`.

Can we merge this @cgranade?

Can we merge this @cgranade?

@cgranade I think the PR build should be fixed by #806 if you merge main into this branch now.

@cgranade I think the PR build should be fixed by #806 if you merge main into this branch now.


Styling Colors doesn{t keep between sessions...

Styling Colors doesn{t keep between sessions...

Hi @nanohtpc
I have tried setting background color for frame info and movieprint and both persisted when I restarted the app.
Please let me know what operating system and which app version you are using. Not sure where the problem could lie. Is that the only thing which does not persist?

Latest version
Win10x64
The problem is in the styling option, i use 2 colors. RGB 255,0,0 and
128,0,128, but only shows results into the first one... seems that doesnt
update...
On Mon, May 25, 2020 at 12:21 PM Jakob Schindegger<EMAIL_ADDRESS>wrote:

Hi @nanohtpc https://github.com/nanohtpc
I have tried setting background color for frame info and movieprint and
both persisted when I restarted the app.
Please let me know what operating system and which app version you are
using. Not sure where the problem could lie. Is that the only thing which
does not persist?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fakob/MoviePrint_v004/issues/15#issuecomment-633659393,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIFQYLEBLYGU6QN4B2B3OPDRTKSLJANCNFSM4NJQEXHQ
.

Hmm, that is strange. Here some questions:

When you change other settings, are they kept after an app restart?
Are your movies and MoviePrint selections kept after an app restart?

You could do a factory reset of the app.
Go to the Application menu -> View -> Reset application - CAREFUL this will remove all movies, MoviePrint selections and reset the settings!

I input this....
but get that...
On Tue, May 26, 2020 at 2:10 PM Jakob Schindegger<EMAIL_ADDRESS>wrote:

Hmm, that is strange. Here some questions:

When you change other settings, are they kept after an app restart?
Are your movies and MoviePrint selections kept after an app restart?

You could do a factory reset of the app.
Go to the Application menu -> View -> Reset application - CAREFUL this
will remove all movies, MoviePrint selections and reset the settings!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fakob/MoviePrint_v004/issues/15#issuecomment-634220474,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIFQYLG3AJZ7UFQEGVERGZ3RTQHZNANCNFSM4NJQEXHQ
.

On Sun, May 31, 2020 at 4:04 PM Procesiones y Desfiles<EMAIL_ADDRESS>wrote:

I input this....
but get that...
On Tue, May 26, 2020 at 2:10 PM Jakob Schindegger <
<EMAIL_ADDRESS>wrote:

Hmm, that is strange. Here some questions:

When you change other settings, are they kept after an app restart?
Are your movies and MoviePrint selections kept after an app restart?

You could do a factory reset of the app.
Go to the Application menu -> View -> Reset application - CAREFUL this
will remove all movies, MoviePrint selections and reset the settings!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fakob/MoviePrint_v004/issues/15#issuecomment-634220474,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIFQYLG3AJZ7UFQEGVERGZ3RTQHZNANCNFSM4NJQEXHQ
.

Hi @nanohtpc it seems that there is information missing in your replies. I assume that email replies do not allow attachments.

Program : Pirple
[image: Screenshot (333).png]
Result :RED?????????????
[image: 01.12.20 - El Doctorcito de Santa Rosa Cercado 2020 -
Preview.mkv-MoviePrint-1.png]

@nanohtpc sorry, still no attachments visible.


Firebolt OpenRPC 2.0

Firebolt OpenRPC 2.0
Overview
This version of firebolt-openrpc has two major changes.

Support for slicing up an OpenRPC API into multiple SDK artifacts
Normalize most tasks to take a single OpenRPC document as input, rather than a directory full of "modules"

OpenRPC task
The openrpc task takes a single OpenRPC document and "Fireboltizes" it, i.e. Interprets Firebolt method tags and inserts external Markdown descriptions via JSON-Schema $ref.
This task continues to support a directory of modules and will merge and Fireboltize them into a single file.
Slice task
To support outputting multipel SDK's, there is a new slice task. This task takes a single OpenRPC document and slices it into separate OpenRPC documents based on a provided sdk.config.json, e.g.:
{
  "info": {
    "title": "Firebolt Core SDK",
  },
  "methods": [
    {
      "module": "Lifecycle",
      "use": [
        "xrn:firebolt:capability:lifecycle:ready"
        "xrn:firebolt:capability:lifecycle:ready"
      ],
      "manage": [],
      "provide": [
        "xrn:firebolt:capability:discovery:entityInfo",
        "xrn:firebolt:capability:discovery:purchases"
      ]
    }
  ]
}

The info.title attribute is copied to the output, and each entry in the methods array is used to query methods from the input using module names and capabilities.
Any info.x- extension attributes will also be copied from the sdk.config.json into the output OpenRPC document.
Generally, this task is run using the output of the openrpc task as input, however, it's not required.
Wildcards are supported in module as well as use, manage, and provide.
SDK, Declarations, and Docs
These tasks all take a single OpenRPC document and generate their respective artifacts.
They all have the same arguments and are all implemented using shared code for more consistency.
--input: The input OpenRPC document
--output: The output location
--template: An optional template directory for adding to and overriding the built in templates

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Allow markdown in comments/answers

Some answers may benefit (readability, etc.) from the ability to use enhanced formatting.
At the moment it doesn't seem possible to use markdown in answers and even \n is stripped from them, which makes it hard to write complex answers that are easy to read. For example a script or code section in the answer would be very hard to read.

I wasn't aware of that, thanks @unsystemizer for pointing that out. Let me check well and then we'll what we can do about it.

This was solved with #84. Closing it now.


Authorization edge case handling

When setting up entities for authorization using nestjs-query I've had a few issues that have tripped me up. It would be good to get some confirmation if there's already a known way to get these working or what if what I want conflicts with overall vision for the library. If these are just missing functionalities, I'll see If I can address any of them with a PR.
Issue 1 - Creation authorization.
I was hoping that I could prevent users creating a resource in a configuration that conflicts with the authorization filter.
I have managed to triage this in my own project by extending the query service to use the authorization filters with the inbuilt applyFilter on the create-dto. I think an option could be passed to the query-service to enable this behaviour (or the default behaviour)
Issue 2 - Related Creation Authorization
If we accept that the above is desired, I'd love an inbuilt way to prevent things being related to items that you don't have permissions to, I'm not sure what the implementation of this would be and at the moment I just allow this to happen which wouldn't be too big of a problem except for the next issue.
Issue 3 - Inferring data through relation filters
Once you have a filterable relation set up it's possible to construct queries that leak information about the items even if you don't have permission to that item but have permissions to a related item.
As per my example you can ask for subtasks where task meets condition X and it will not consider your permission to the tasks so you can find out that tasks meeting condition X exist in the system even if you don't have permission to any of them.
When joining relationships, I believe we need to apply the authorization filters to the join.
Here's a repo to demonstrate the issue: https://github.com/Smtih/netjs-query-auth-issues/blob/main/test/issue-3.e2e-spec.ts

Issue 1:
In my own projects I tend to do this in the before-create hook, a better solution is always welcome but I don't quite understand yours?
Issue 3:
I don't quite understand this one either, you say "no access" but the auth filter says complete: false access, so if I'm not mistaken the query applied to todoItem should be the merged auth filter and the filter provided? Is that not the case?

Sorry I was trying to produce an example that was close to the boilerplate example used throughout the code, but I think I've made it too unrealistic so perhaps it's too hard to understand.
Issue 1:
In my app users belong to one or more groups all authorization is provided at the group level and my jwt contains the array of groups you belong to.
This means most of my apis have you specify which groupId you are creating the resource against and my auth filters look like { groupId: { in: context.req.user.groups } }
Here's a code diff of what I was thinking generalizing what I've done in my service would look like.
https://github.com/Smtih/nestjs-query/pull/1

I'll start a PR for this then, I'm reworking my example to highlight what I think is wrong with issue 3 with a bit more of a realistic setup.

@TriPSs Here's a more complete example to illustrate Isssue 3.
Here's a more complete set up and test.
https://github.com/Smtih/netjs-query-auth-issues/blob/main/test/issue-3.e2e-spec.ts
Permission setup:
Groups - authed if my token says i belong to it.
https://github.com/Smtih/netjs-query-auth-issues/blob/82589a9e15bedac45e2daac4ee54e1b8635f3161/src/group/group.dto.ts#L11
Tasks - authed if my token says I belong to the group it's in and I'm assigned.
https://github.com/Smtih/netjs-query-auth-issues/blob/82589a9e15bedac45e2daac4ee54e1b8635f3161/src/task/task.dto.ts#L9
We can then expose filters that allow the FE to get something like Groups I have uncompleted tasks in.
Groups will implicitly be filtered to my groups thanks to the baked in auth filtering, however once we start asking questions about connected tasks in the nested filters we don't get the same behaviour, so we need to start adding explicit filters to ensure we're only filtering by my tasks.
The fact we get the auth filtering at the top level, but not at nested levels I think is a bit unintuitive, but more problematically, it also allows for sensitive information to leak.
I can now maliciously ask for all my groups where others have not completed their tasks, even though I have no access to other people's task. This is what I mean by leaking information in my original post.

Yeah, that's correct, resolving the related entities will trigger the auth filter, but not simply filtering by information on related entities.
I think when performing the left joins in order to apply the filter, we should also be applying the authorization filter of that resource (or at least have an option that would enable such behaviour)
If you think this is a sane behaviour for the library, I'll try and find time to raise another PR but probably need some pointers as to where this relation filtering/joining logic is happening in the library to get started.

I agree that it's sane behavior, will also try to find some time the coming days to look into this.
Don think we need to release it as breaking change, just so everyone is aware default behavior has been changed.

I think it would need to be, as asking the question give me groups where any tasks are incomplete is a sane question to ask and people may rely on it even with a similar permission model.
I think other than a flag that restores the current behaviour globally we'd also want to consider passing information to the authorizer (e.g. through the Operation type/name?) that specifies where evaluating it for the purpose of filtering?


feat(sqlparser): support WITHIN GROUP

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
support WITHIN GROUP so that ordered_set agg such as percentile_cont can be implemented later
select percentile_cont(0.3) within group (order by x desc) from unnest(array[1,2,4,5,10]) as x;

Checklist For Contributors

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
[ ] All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

[ ] I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.

SQL commands, functions, and operators

Release note

Just fyi that visitors of agg calls (in binder/planner/optimizer) may need to be updated similar to when we add filter and order by #4762 Not sure if it is needed to supported correlated column inside within group, but it is better to test it and avoid panic.


The text from the input field disappears if you click in an empty area

The text from the input field disappears if you click in an empty area.
Steps:

Input text on input field
Press in an empty area or switch to another channel

Expected Result: The text in the input field does not disappear. On web version
Actual result: Text from the input field disappears
The web version works as expected.

Zulip 1.7.0
Electron 1.6.15
win32 x64 10.0.16299
field_bug.zip

@fleytman thanks for reporting!  I'd be surprised if this were an electron app bug, and not a test procedure difference.
I'd like to make sure you're testing correctly: In Zulip, clicking an area that isn't a link or anything special will close the compose box (and save the content as a draft), while switching narrows should not close the compose box; is that what you're seeing?

@timabbott,
Zulip electron windows

I click on empty area and compose box close, and message no in draft
I click on empty area and compose box close, and message no in draft
Zulip firefox (57, 64bit)
I click on empty area and compose box no close
I click on empty area and compose box no close,
See https://github.com/zulip/zulip-electron/files/1507698/field_bug.zip

New test: The behavior of IE and Chrome is similar to an electron

I want save my message if i miss-click

@fleytman have you tried using the d hotkey or the "drafts" button at the bottom of the screen?

@timabbott, I did not know about this feature. Thank you very much for your help!

@timabbott, I did not know about this feature. Thank you very much for your help!
Retest on firefox without extension, is similar to an electron, IE and chrome

But it seems to me that it's a bad idea to nullify the field and not everyone will get into the manual to find out about the feature with drafts.
When I'm writing a long message and I lose it, I'm very angry.

Agreed.  A few thoughts on what we should actually do here:
(1) We should have a little notice that the message was saved as a draft when we save a draft; it'd be a simple code change and make this much more discoverable.
(2) Did you find an issue with clicking links to renarrow closing the compose box?  It shouldn't.
I think both types of issues actually belong on https://github.com/zulip/zulip (this part of the desktop app is just running the code from the webapp).  So maybe we should close this and open a new issue there for at least (1) and maybe also (2)?

So maybe we should close this and open a new issue
I agree

OK, I'll take care of that.

See https://github.com/zulip/zulip/issues/7539


Add metadata for Chef 12.7.2 and update instructions

Generating metadata for all releases fails so the instructions were't accurate

Ping @lamont-granquist

:+1:

FWIW prolly worth a minor version bump in foodcritic when you get around to releasing this.


Setting 'User-Agent' header causes error in browser.

Particle.request() and downloadFirmwareBinary() explicitly set the 'User-Agent' string. This isn't allowed in the web browser (see http://stackoverflow.com/questions/7210507/ajax-post-error-refused-to-set-unsafe-header-connection). The API calls works fine if this code is removed.

Thanks for the bug report! I'll see about making this conditional, and if not, removing it altogether.

Thx bryce.

I'm getting this as well in Chromium with particle.login():
XMLHttpRequest cannot load https://api.particle.io/oath/token. Request header field User-Agent is not allowed by Access-Control-Allow-Headers.
Going to try removing the line that add the User Agent and give it a try.

I just released 5.2.3 which fixes this issue.

Hello Brycekahle.
I might be out of line here, i just downloaded version  "particle-api-js": "^5.2.6"
{
  "name": "photon",
  "private": true,
  "scripts": {
    "start": "meteor run"
  },
  "dependencies": {
    "meteor-node-stubs": "~0.2.0",
    "particle-api-js": "^5.2.6"
  }
}

made an easy login request
with this code

import { Template } from 'meteor/templating';
import { EventDB } from '../api/eventDB.js';
import { ReactiveDict } from 'meteor/reactive-dict';
import './body.html';

var Particle = require('particle-api-js');

var particle = new Particle();
var access_token = "";

//get access token
particle.login({username: 'email', password: 'password'})
  .then(
    function(data){
      access_token = data.body.access_token;
    },
    function(err) {
      console.log('API call completed on promise fail: ', err);
    }
  );

var pumpStuff = function(message){
  var fnPr = particle.callFunction({
      deviceId: 'jackdaniels',
      name: 'leanMachine',
      argument: message,
      auth: access_token
    });

  fnPr.then(
    function(data) {u
      console.log('Function called succesfully:', data);
    }, function(err) {
      console.log('An error occurred:', err);
    }
  );
};

exports.pumpStuff = pumpStuff;

And i get error in chrome console log

XMLHttpRequest cannot load https://api.particle.io/oauth/token. A wildcard '*' cannot be used in the 'Access-Control-Allow-Origin' header when the credentials flag is true. Origin 'http://localhost:3000' is therefore not allowed access. The credentials mode of an XMLHttpRequest is controlled by the withCredentials attribute.

I have been asking on the forum about it but yet not received any answer but other people have reached out to me saying they have this issue as well and it was caused from an update but they cant say which one.
Could this update have anything to do with it?
BR
Dimi

@brycekahle
I am not sure my comment above is valid. It might be so that the login needs to be called from the server part of meteor and not the client. i have not been able to varify thou. Sorry to bother you without testing enough.
/Dimi

@Dimicus I think your bug is valid. I see that superagent is setting withCredentials to true for browser requests. If the server does not respond with Access-Control-Allow-Credentials: true and a non * value for Access-Control-Allow-Origin, the browser will reject the request.

On further examination, it only sets that if withCredentials() is called, which we do not.

@brycekahle
Intresting, how come i get the issue when the only thing i do is calling the login function from particle? Will do some more test when i get some time.
Where Can i see IF the package i downloaded with npm install particle-api-Js contains this issue? Please note that other people have claimed the same i.e https://community.particle.io/t/particle-api-js-user-agent-and-cache-control-errors/20664
And some others.
So IT might be some issues
Anyway.
Br
Dimi

@Dimicus the errors in that thread are different and were fixed by the code that solved this issue. What you are experiencing is something different and I have a suspicion is meteor related.

I guess you are right.
Bryce. thank you very much and have a great day.
If i find anything related to this i will let you know :)
/Dimi

If you can provide a small example meteor application that demonstrates the error, I can help dig in.

Im pretty sure its meteor now.
Everything works great when i use the code in the server enviroment but if i use the same in client i get the issue.
If you want to test you can use the login example below and use it on main.js in client folder on your meteor project ( meteor 1.3 )
var Particle = require('particle-api-js');
var particle = new Particle();

particle.login({username<EMAIL_ADDRESS>password: 'pass'}).then(
  function(data){
    console.log('API call completed on promise resolve: ', data.body.access_token);
  },
  function(err) {
    console.log('API call completed on promise fail: ', err);
  }
);

Think due to 1.3 that you also need to do meteor install npm, happens alot there now so hard to follow :)
But from my point of view this is all meteor issues, or rather that you need to use credential code in the server and not client, is security :) So its more a feature that you can use it on client side.
BR
Dimi


Go: Clean up the interface for reading ZIP files. [phab:D813]

Created by fromberger at 2016-04-05 14:47:45:
Rather than passing in an io.ReadSeeker and adapting it to the
io.ReaderAt that the archive/zip package requires, make the user pass in
the reader and length explicitly. This improves performance in cases
where the filesystem has a faster implementation of ReadAt than a seek
followed by a read.

shahms accepted this revision at 2016-04-05 15:38:01

schroederc accepted this revision at 2016-04-05 15:38:17

fromberger closed via commit 5c2313e06395c913640462d249d9ecac83fd17f6 at 2016-04-05 15:45:31


Added list file API route and check for atime

List file (with depth option, and compare option)
Check for writable rights and atime availability for repos with 'freeze' option

Cool, ready to merge?

Should be fine


Issue w/ VoiceMailAudioProcessingFunction

Hi all,
When I am working through the test flow. I get an error on the send voicemail directly to an agent flow. It looks like this particular function errors with:
"errorType": "Runtime.UnhandledPromiseRejection",
    "errorMessage": "BadRequest: Object tags cannot be greater than 10",
    "reason": {
        "errorType": "BadRequest",
        "errorMessage": "Object tags cannot be greater than 10",
        "code": "BadRequest",
        "message": "Object tags cannot be greater than 10",
        "region": "us-west-2",

I'm assuming that this is trying to write to an object to s3 with more than 10 tags. I tried removing attributes to see if the attributes were being written to tags. But that didn't seem to make a difference.

HAre you using the test flows or your own implementation? And which version of the function are you using (can be fouind by looking at the EXPTemplateVersion parameter in your cloudformation template)? I just tested this on a clean install and did not encounter this issue.

Running the canned test flows.
2022.03.23

Closing this. Moving to the Salesforce solution thank you @dougjaso


Can't find module

I'm getting this error when attempting to use the library in a Node program:
C:\Root\Apps\Control\@V\RobotJS\Scripts>node Dist/Main.js
Loading native binary<EMAIL_ADDRESS>module.js:597
  return process.dlopen(module, path._makeLong(filename));
                 ^

Error: The specified module could not be found.
<EMAIL_ADDRESS>    at Error (native)
    at Object.Module._extensions..node (module.js:597:18)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (C:\Root\Apps\Control\@V\RobotJS\Scripts\node_modules\iohook\index.js:16:21)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)

The file, however, does exist: I copied the path above exactly, into Windows explorer, and it opened the file.
I did a search, and found a similar error message here: http://stackoverflow.com/questions/41253450/error-the-specified-module-could-not-be-found
They suggested to use the Dependeny Walker program to see if it was trying to use a dll that was missing. (as that can be the cause of the error)
I did so, and saw this:

So, it seems that the "libuiohook.dll" file is missing.
But why? I'm not sure how to fix it, as running "npm run build" myself errors, and I can't find a prebuilt copy of the "libuiohook.dll" file.

The same problem.. @Venryx  Some advance?

@soyFerrero I didn't figure out how to fix it, so I'm just using a different module for global hooks for now: https://github.com/tomzx/gkm
There are some others listed here, if that one doesn't work for you: https://github.com/octalmage/robotjs/wiki/Plugins-(or-compatible-modules)

@Venryx Thank u so much. I'm going to try it

The same for me on Windows 10 :/ I have the same issue..

You need recompile iohook for windows. At this moment I can't configure appveyor for normal automated compiling for windows :(
But I try to do in in virtual machine with windows today


Pulumi README copyedits

Proposed changes
Light copyedits on Pulumi ReadMe.
Checklist
Before creating a PR, run through this checklist and mark each as complete.

[X] I have written my commit messages in the Conventional Commits format.
[X] I have read the CONTRIBUTING doc
[X] I have added tests (when possible) that prove my fix is effective or that my feature works
[X] I have checked that all unit tests pass after adding my changes
[X] I have updated necessary documentation
[X] I have rebased my branch onto master
[X] I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Two little notes there, but other wise looks great. I'll merge once you update with those.
Jay

Resolved both of these. I think I did it in the correct workflow with a new commit, but feel free to lmk if there's a better way.


Avoid reading all modes

Add parameter to avoid reading all modes from a results file. Useful to have a better memory management when analyzing a big case in a PC.

Closed with #32


no tooltips for pie charts

Hi, im wondering why there are no tooltips for the examples of pie/doughnut/radar charts.
The console throws a lot of errors of this type:
undefined is not an object (evaluating 'element._xScale.getLabelForIndex')

Well, seems the bleeding edge release fixed this :)
Only the easeInOutBounce animation still doesn't seem to work :(

@p0fi can you post a fiddle for the animation issue?

I'm afraid I don't know how to do this exactly :-/

I'm getting no problems with pie chart tooltips.

Tested this today using the latest from master. No issues.


Determine approach for extracting cell type leaf ancestors from CL

Approach

Validate part-of is only relationship we're interesting in
Sanity check size of generated map
Review existing related functionality
Document in Filter by Metadata (v3) - Tech Spec

Current R Implementation
From Pablo:
https://github.com/pablo-gar/sc-normalization-explorations/blob/main/scripts/processing/make_ontology_ordering_v2.R
The important function is set_order_recursion. It returns a flatten list of cell types and the tree, and this is the logic in words (I bolded the important steps for tree)

Load the CL ontology, using either the cl.obo or cl.owl from the source file here.
Subset the ontology to only contain the cell types of interest along with their ancestors.
Create a 2-dimensional representation of the DAG using the dot method of graphiz. See here for a full description of this method.
Initialize an empty tree
Traverse the DAG starting at the root:
a. If node is present in cell types of interest:
i. add to the final ordered list.
ii. add as child of current parent in tree
b. Remove the node from nodes of interest.
c. Get children nodes
d. Perform recursion for each child node, going left-to-right through the children nodes.
Return the ordered list and tree

Python Implementation
From Pablo:
https://github.com/chanzuckerberg/single-cell-data-portal/blob/aea2c7440d5f87286282e38f0eb0a3693bd60cf1/backend/wmg/data/transform.py#L37

Drawing a two-dimensional version of the DAG, traversing depth-first and left-to-right, whichever is the first children-parent relationship found in the DAG that’s the one kept.

Filter by Metadata (v3) - Tech Spec (Filter by Cell Type Ontology)
compute_cell_type_view.ipynb - Uses Pablo's method to simplify DAG, converts depth output to UI tree
compute_cl_is_a_graph.ipynb - Tags datasets with cell type ancestors
rdev

PoC deployed to rdev, cc/filter-ontology branch. See technical spec.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-k8s-25-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3717

Questions ?
Please refer to the Backport tool documentation


Fix MDNS Announcements

To be compliant, the A and AAAA records (of the target of an announcement) should be published das "additional" records, not as answers

Do you mean when we respond to a query or when we announce a new service to the world?
Could you provide the reference in the RFC?

Thanks for your issue. The bonjour library is about to be replaced by new ciao library (which is basically a rewrite). I'm not sure what exactly you wanted to point out with your issue, though ciao strongly follows the RFC, thus the issue is closed.


Feature: Change in rules

Type of feature
🍕 Feature
Current behavior
There have been concerns about merge conflicts occurring due to PRs with large numbers of content being added to the recipe and pizza-facts-and-trivia files
Suggested solution
Add in new rules to the contributing guide, such as "To keep things organized, You choose to either add one new pizza fact to the pizza-facts.md file or add one new recipe to the pizza-recipes.md file."
Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[ ] I agree to follow this project's Contribution Docs

@CBID2 : )!

Hey @CBID2 !
I would also suggest adding a link to an article or video on how to resolve merge conflicts so if a beginner does run into that issue, even with the change in rules, they will know how to resolve it.
Maybe a short opensauced link would work in this case.
Just food for thought 👍

Hey @CBID2 !
I would also suggest adding a link to an article or video on how to resolve merge conflicts so if a beginner does run into that issue, even with the change in rules, they will know how to resolve it.
Maybe a short opensauced link would work in this case.
Just food for thought 👍

Good idea @jdwilkin4! 😃 @adiati98 is working on a PR for merge conflicts. I'll add a link to that once it's merged. 😃

Hey @BekahHW @CBID2,
Should I submit separate PR for:

Changing the rule
Adding a resolving conflict section.

Or should I put them in the same PR?

Hey @BekahHW @CBID2,
Should I submit separate PR for:

Changing the rule

Adding a resolving conflict section.

Or should I put them in the same PR?

@adiati98, creating separate PRs does sound best :)


initial estimate always generates smaller point cloud

I found that if I use two exact "same" point cloud, the code still generates smaller point cloud in the initial steps. If the loss is zero, I was wondering why the initial point cloud is always smaller ?

You need to clarify wether the issue appears in similarity (scale + rigid), affine or deformable registration examples. If it is during similarity registration, then there is most likely a numerical instability when calculating the singular value decomposition (SVD) for identical point clouds.
This is common in numerical methods. People usually get around this by adding a small value to the error term to avoid singularities when dealing with small numbers.
Given that this is a corner case, and in my opinion of little practical value, I am not going to fix it. Specially since the algorithm ultimately converges to the correct solution.


rewrite int module in micropython to improve performance.

replace mpz implementation with uint64_t
int module can be found at py/objinit.c and the mpz implementation can be found at py/objinit_mpz.c

Fixed by #e2a0771


Refactor update program-related stuff

…ributes AB#26629

Closing this PR, as the useful stuff was taken out into other PRs/branches.


Explain what Polly is

A link to https://github.com/App-vNext/Polly or http://www.thepollyproject.org/ at least, would be useful. A short explanation of what Polly is and how it relates to HttpClientFactory would be even better.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7b506236-b211-eb9d-b571-5efecdde76c8
Version Independent ID: 1bb011dd-a559-c0d7-b0cf-984fbb2d4bd3
Content: Use HttpClientFactory to implement resilient HTTP requests
Content Source: docs/standard/microservices-architecture/implement-resilient-applications/use-httpclientfactory-to-implement-resilient-http-requests.md
Product: dotnet
GitHub Login: @CESARDELATORRE
Microsoft Alias: wiwagn

That's a good suggestion. @mvelosop @CESARDELATORRE can you please take a look?

Hi @IanKemp, @mairaw, Polly is explained in the article following the one referenced in this issue, that is:
Implement HTTP call retries with exponential backoff with HttpClientFactory and Polly policies

Hi @IanKemp, will improve this article and include the suggested mentions.


Update filename in flit --help output

It's still listing flit.ini but  that's not what's generated anymore.

Thanks, but can we lose the test? This wouldn't have caught the problem, because the test would have been out of date too, and testing a human-readable message just means it's slightly more effort whenever you update that message.

Thanks!


[Bug]: Not working after basic install

Bug Description
Installed using Lazy, when trying to run any function getting the following error:
 E5108: Error executing lua: ...azy/nvim-scissors/lua/scissors/read-write-operations.lua:22: package.json could not be read
 stack traceback:
 ▸   [C]: in function 'assert'
 ▸   ...azy/nvim-scissors/lua/scissors/read-write-operations.lua:22: in function 'readAndParseJson'
 ▸   ...e/nvim/lazy/nvim-scissors/lua/scissors/vscode-format.lua:21: in function 'getSnippetFilesForFt'
 ▸   ...ocal/share/nvim/lazy/nvim-scissors/lua/scissors/init.lua:74: in function 'addNewSnippet'
 ▸   /home/rizhiy/.config/nvim/lua/plugins/cmp.lua:25: in function </home/rizhiy/.config/nvim/lua/plugins/cmp.lua:25>

Relevant Screenshot
No response
To Reproduce
Install it using lazy and try to execute using Lua
neovim version
NVIM v0.9.4
Build type: Release
LuaJIT 2.1.1692716794

Make sure you have done the following

[X] I have updated to the latest version of the plugin.

I don't know how snippets work underneath, can't you create a standard one by default?

Hmm yeah, in that case it's about bootstrapping a vs code snippet dir, which would go into a similar direction as #2

rn I am using the one from your dot files

@FormalSnake I added the automatic bootstrapping of the package.json if none exists in your snippet file in the last few commits.
I'll also add a section explaining the requirements for the package.json to the readme momentarily.

nice, thank you.

I added an FAQ showing the requirements for the VSCode-style snippet format:
https://github.com/chrisgrieser/nvim-scissors#cookbook--faq


Expected string value. (authManagement)

changePassword({ commit }, {email,oldPassword,password}) {
    return new Promise((resolve, reject) => {
      let data = {
        'action': 'passwordChange',
        'value': {

          'user': {
            email: email
          },
          oldPassword,
          password
        }
      }
      axios.post("/authManagement/", data,{ headers: {Accept: 'application/json',"Authorization" : `Bearer ${localStorage.getItem('accessToken')}`} })
        .then((response) => {
          resolve(response)
        })
        .catch((error) => { reject(error) })
    })
  },

Please provide more details about the context and the error, indeed this test is ok, which seems pretty similar to what you do.

yes but the response is  ststusCode 400
with message : Expected string value. (authManagement)

yes but without context we don't what values/types you provide in email, password, etc.
Provide either a complete example or more information.

i want to test this article https://hackernoon.com/setting-up-email-verification-in-feathersjs-ce764907e4f2
with axios and HTTP fetch:

changePassword({ commit }, {email,oldPassword,password}) {
    return new Promise((resolve, reject) => {
      let data = {
        'action': 'passwordChange',
        'value': {

          'user': {
            email: email
          },
          oldPassword,
          password
        }
      }
      axios.post("/authManagement/", data,{ headers: {Accept: 'application/json',"Authorization" : `Bearer ${localStorage.getItem('accessToken')}`} })
        .then((response) => {
          resolve(response)
        })
        .catch((error) => { reject(error) })
    })
  },

and resopnse this message: statusCode: 400
Expected string value. (authManagement)

I've got many other issues with trying to implement authentification management with current feathersjs (ts)
I appreciate the effort of those who already done a lot, but without proper usable exemple it results in a lot of waisted time/frustration.
I'm willing to help put a a proper usable exemple.
It's really frustrating working with tools of that level and to be there having to do black magics and re-invent the weal when coming to do something as exotic as users change password process !
feathersjs is close to 50k downloads a week and user change/forgot password is in black magic?
Perhaps we could be not so selfish and share our efforts to put a a working exemple?
As I'm no black magic expert, I can help but will need some guidance.
Anyone who got this working with feathers in typescript would be willing to help me put a working exemple?

@cantoute I don't know if your difficulties are related to TS or simply the module usage. As far as I can see there are already some articles detailing how to use it like 1, 2 or 3 in addition with the docs.
Sometimes part of these materials can be outdated depending on the Featers version but the principles still remains and it seems to me that the API has not changed much so that it can be easily adapted. As a consequence I can't really approve "user change/forgot password is in black magic". Moreover this is Open Source software, you can open the box and look at what is inside, eg password change operation is a couple of lines of code, I see no black magic here. If errors are raised you can simply put some breakpoint in the relevant operation and identify where it comes from so that you can correct your code or open issue with relevant information to help you.
This module is a community supported module not part of the FeathersJS core so you can help providing an up-to-date example if you think we need it. IMHO what is missing is probably a global chart explaining how the different operations relate to each others.

Hi @claustres
Thanks for your message.
I'm hitting many many issues.
One was about typescript, the feathers-authentication-management-ts helped.
Next thing is that all bits of exemple are mostly outdated... and only comes in bits.
I'm sorry, but this https://hackernoon.com/setting-up-email-verification-in-feathersjs-ce764907e4f2 is not of much help.  I would actually call it a waist of time!!
There isn't a usable functional exemple... that seams so unbelievable at this level.
Someone did share an implementation, and I want to thank @meditatingdragon for sharing his code.
follow up https://github.com/MohammedFaragallah/feathers-authentication-management-ts/issues/4

This module is a community supported module not part of the FeathersJS core so you can help providing an up-to-date example if you think we need it. IMHO what is missing is probably a global chart explaining how the different operations relate to each others.

Been working on it... But still a long way to go https://github.com/cantoute/feathers-authentication-management-ts-example
Does it seem logic that as a first time setting this up I have to do a 'How To' ?
I'm not pointing out those who have yet done a lot for this framework.  I'm pointing out that it can't be that I'm the first one hitting this issue.  I'm sure many have implemented all this in their apps... Are they keeping it for them self?
I know we are part of a society of 99.9% selfish bastards that are happy to take all they can from those who give and not give nothing back... but it always heart to face it so
Second question:
Is it like we are doing computing for computers or for humans ?
Been in IT business for over 20 years.
Frameworks I used had this implemented from scratch and would take no more then a couple hours to get your app to work for humans (yes and humans forget their password or change email)
Now to have spent 2 weeks implementing lost password for an app that took 5 days to build drives me totally crazy.

I am not familiar with TS but it seems to me this module has a pretty simple interface, a single service with a couple of operations as detailed here. It should not be a big deal otherwise I will start to believe TS will hardly support large projects ;-)
Authorization management (aka roles) is a really different beast than authentication, it really depends on what is your use case. For instance we propose an approach for role management here https://blog.feathersjs.com/access-control-strategies-with-feathersjs-72452268739d but it might not apply to all use cases.
According to Separation of Concerns (SoC) it would not be great to add some role management in this module, this should be something not intrusive to be flexible enough. IMHO you can easily add role management using eg https://github.com/feathersjs-ecosystem/feathers-permissions or CASL directly.

I was wondering if it would be worth integrating some basic role management at same time ?
It could be a nice kit for newbees like me :)

Seems I wasn't very clear, here I ment integrating some form of role management in the exemple, not in auth module :)
The idea would be to have an exemple with most of what are very common things for most apps to have (aka: made for human users).
A clean implementation of authManagement + a role management fairly simple yet that covers most common use case.
It's kind of starter kit I would love to find...

Hello,
I've got the same problem with axios : for example
`    const payload={
"action": "verifySignupLong",
"token": "58893d753824437c8b8f3fc9c517df"
}
axios.post(API_BASE_URL+'/authManagement', payload)
    .then(function (response) {
        if(response.status === 200 || response.status === 201){
        } else{
            alert.error(`${t('alert.error')}`);
        }
    })
    .catch(function (error) {
        alert.error(`${t('alert.authenticate-false')}`);
    });`

And error in console :
className: "bad-request" code: 400 data: {} errors: {$className: "badParams"} $className: "badParams" message: "Expected string value. (authLocalMgnt)" name: "BadRequest"


Don't prompt for Remote-WSL on mac

I think I installed Remote-WSL on a windows machine, got it settings sync'd over to my mac, now I see this on mac:

Ah, I know I saw this too :(

Thanks for pointing this out - this notification is part of the experiment. I'm wondering if we should filter in the experiment or in the extension itself to only show this to Windows users (I'm not immediately sure how to do that in the experiment, but I feel like there should be a way?).

Duplicate of https://github.com/microsoft/vscode-remote-release/issues/3965.
I will fix it in the extension and push today

I believe @aeschli fixed this issue at the beginning of this week- if this happens again or I'm mistaken, please just let me know. Thanks again!


AggroInstrumentationStage.java:25: In aggro mode,...

The puzzle 99-a8b3c755 from #99 has to be resolved:
https://github.com/pragmatic-objects/oo-atom/blob/25169c70a8b3079415f0a4e52c7c9933eff8448d/atom-basis/src/main/java/com/pragmaticobjects/oo/atom/codegen/stage/AggroInstrumentationStage.java#L25-L25
The puzzle was created by Kapralov Sergey on 04-Jun-18.
Estimate: 0 minutes,
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@skapral please pay attention to this new issue.


deIndex is being called wrong

https://github.com/AmpersandJS/ampersand-collection/blob/master/ampersand-collection.js#L310-L311
Pretty sure we want to send the old values to _deIndex
    _onModelEvent: function (event, model, emitter, options) {
        if ((event === 'add' || event === 'remove') && emitter !== this) return;
        if (event === 'destroy') this.remove(model, options);
        if (model && event === 'change:' + this.mainIndex) {
            this._deIndex(emitter);
            this._index(model);
        }
        this.trigger.apply(this, arguments);
    }

Also, what happens if any other attribute in this.indexes change?

Maybe
    _onModelEvent: function (event, model, emitter, options) {
        var attribute = event.split(':')[1];
        event = event.split(':')[0];
        if ((event === 'add' || event === 'remove') && emitter !== this) return;
        if (event === 'destroy') this.remove(model, options);
        if (model && event === 'change' && this._indexes[attribute]) {
            this._deIndex(emitter);
            this._index(model);
        }

In case of single attribute change, emitter is the new value of this attribute.
Maybe we could use previousAttributes()
var attribute = event.split(':')[1];
        event = event.split(':')[0];
        if ((event === 'add' || event === 'remove') && emitter !== this) return;
        if (event === 'destroy') this.remove(model, options);
        if (model && event === 'change' && this._indexes[attribute]) {
            this._deIndex(model.previousAttributes());
            this._index(model);
        }

this._deIndex(model, attribute, value)
This would require deIndex to be given the index value too, much like it can be given the specific index/

ok but maybe optional parameters. If they aren't passed to the method, we loop on all model attributes. (useful for _addReference)
We could do the same for _index

Can I fill a PR ? Even if you don't accept my changes, I added some useful test cases.

@chabou this issue is 100% intended for someone who has the time to write up a PR for this THANK YOU SO MUCH if you have the time.

Closed by #47


Remove unused error varient, clean up benchmarks

Includes:

Removing GeoArrowError::External, which appears to be unused
Fixing up the benchmarks so that they all compile
Tweaking the benchmark config so that they correctly declare their required features
Tweaking the geos_buffer benchmark to run fewer iterations (the default config required 120 seconds to run and criterion was printing a warning)
Disabling the wkb benchmark b/c it's currently broken (this assertion fails: https://github.com/geoarrow/geoarrow-rs/blob/bea907646232d62db7856bc87542614c27dda14d/benches/wkb.rs#L17)
Adding CI check for the benchmarks (just to build them, not to run them)

Disabling the wkb benchmark b/c it's currently broken (this assertion fails:

Oh I think what I did locally (and didn't document) was in pyarrow converting that GeoParquet file to another with only the geometry column. I didn't understand the parquet apis well back then

Thanks!


set up handling system

@MalevolentGoat : I think about putting the files on the dropbox, because this one updates the folders automatically. Under consideration of Flo, which has deactivated automatic start when Windows is started, Github is preferred because we don't have to copy paste the issues from an external list;
testers would be:

Flo
Patrick
Steffi
Gerfried
Alex
Vuko
... anyone else?

What? Can you be more cryptic pls?

should we let everythin grun over github or save the exe and a xls for bugs on the dropbox?


If UseWebpackDevMiddleware gets back an error from Node during app startup, it fails to surface good error information

Exception occures when adding app.UseWebpackDevMiddleware(new WebpackDevMiddlewareOptions {HotModuleReplacement = true}); to Configure()
Node: 6.2.2
SpaServices: 1.0.0-beta-000009
at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)    at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)    at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)    at Microsoft.AspNetCore.Hosting.Internal.ConfigureBuilder.Invoke(Object instance, IApplicationBuilder builder)    at Microsoft.AspNetCore.Hosting.Internal.ConfigureBuilder.<>c__DisplayClass4_0.<Build>b__0(IApplicationBuilder builder)    at Microsoft.AspNetCore.Hosting.ConventionBasedStartup.Configure(IApplicationBuilder app)    at Microsoft.AspNetCore.Hosting.Internal.AutoRequestServicesStartupFilter.<>c__DisplayClass0_0.<Configure>b__0(IApplicationBuilder builder)    at Microsoft.AspNetCore.Hosting.Internal.WebHost.BuildApplication()    at Microsoft.AspNetCore.Hosting.Internal.WebHost.Initialize()    at Microsoft.AspNetCore.Hosting.WebHostBuilder.Build()    at AurelaTestProject.Program.Main(String[] args) in D:\downloads\AurelaTestProject\src\AureliaTestProject\Program.cs:line 14

So i got this sorted. The exception is actually from here:
https://github.com/aspnet/JavaScriptServices/blob/dev/src/Microsoft.AspNetCore.NodeServices/HostingModels/HttpNodeInstance.cs#L66
But it did not bubble to the surface so I could actually read the actual message, so that might be something someone should look at.

Thanks for reporting that! I'll look into whether we can better report exceptions that occur in that location.

In the current version, we do surface such errors (at least in the cases I'm aware of). If anyone can still repro disappearing error messages, please let us know!


document and release groups and teams

Adds the release documentation and reveals all cli commands for groups and teams channelMessages and files support.

Does this PR need a docs update or release note?

[x] :white_check_mark: Yes, it's included

Type of change

[x] :world_map: Documentation

Issue(s)

#3988

Test Plan

[x] :muscle: Manual

@vkamra Changes made.


httputil.DumpRequestOut excluding Cookie header

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.9.2 windows/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\Michael\go
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
What did you do?
when using net/http/cookiejar - the cookie jar works and sends out cookies that is receives in subsequent requests - however, on those subsequent requests, httputil.DumpRequestOut does not show the Cookie header - it shows all the other headers that were sent - just not Cookie
I verified the exact headers sent on the server to make sure it was indeed sending the Cookie header
this is obviously not a critical issue - but figured I would pass it along
What did you expect to see?
Per the docs on httputil.DumpRequestOut, I expected to see all headers which were sent
What did you see instead?
All headers sent, except the Cookie header

Some reproduce code (since I don't have a real server to bounce requests off of, I added a cookie to the cookie jar):
package main
import (
"fmt"
"net/http"
"net/http/cookiejar"
"net/http/httputil"
"net/url"
"strings"
"time"
)
func main() {
transport := &http.Transport{
MaxIdleConns:    20,
IdleConnTimeout: 15 * time.Second, // how quickly are connections that we create GCed
}
client := &http.Client{
Timeout:   10 * time.Second,
Transport: transport,
CheckRedirect: func(req *http.Request, via []*http.Request) error {
return http.ErrUseLastResponse
},
}
cj, _ := cookiejar.New(nil)
var url *url.URL
url, _ = url.Parse("https://golang.org/")
var cookies []*http.Cookie
cookie := &http.Cookie{
Name:  "cname",
Value: "cvalue",
Path:  "/",
}
cookies = append(cookies, cookie)
cj.SetCookies(url, cookies)
client.Jar = cj
body := ""
req, _ := http.NewRequest("GET", url.String(), strings.NewReader(body))
dump, _ := httputil.DumpRequestOut(req, true)
fmt.Println(string(dump))
}

Sorry - upon further investigation.. it does show the Cookie header - but only if you call httputil.DumpRequestOut after executing the request and getting the response - which is fine.  I thought httputil.DumpRequestOut should know what headers it was going to send before sending them, but it does not work that way with a cookie jar evidently.


Extension prevents streaming on tv.jw.org, and Broadcastify.com

As title says.  Either causes an error, or hangs playback at 0:00.

tv.jw.org is fixed in <IP_ADDRESS>