test: add test for legacy ice url member

Codecov Report

Merging #61 into master will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
+ Coverage   96.89%   97.01%   +0.12%
==========================================
  Files           1        1
  Lines         805      805
==========================================
+ Hits          780      781       +1
+ Misses         25       24       -1

Impacted Files
Coverage Δ

rtcpeerconnection.js
97.01% <0%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9372ebb...694e42c. Read the comment docs.


prefer-lodash-method shouldn't complain about Object.create(null)

There is no equivalent in lodash for Object.create(null). Calling _.create(null) doesn't do the same thing, so its misleading to suggest to use the lodash method

Hmm, how about _.stubObject()?

What is the difference between them?

_.create(null).hasOwnProperty

hasOwnProperty() { [native code] }
Object.create(null).hasOwnProperty

undefined
Lodash just defaults to the object prototype, creating an object that inherits Object methods onto the prototype, one creates a real plain object that has no prototype, meaning it is a true empty map that can be used like a map


Motion PDF Export: export without pre-selected svg logo

Description: The motion PDF export is not possible with an SVG file that is to be output in the header, for example. The image won't be exported. However, other image formats can be used without any problems.
Reproduction:

download https://upload.wikimedia.org/wikipedia/commons/b/b0/NewTux.svg file, for example
Open a meeting
open files and upload the the file
mark the new file with one of the header options in the three-dot-menu
open motions > create a motion > export it -> logo is not exported

What should happen:
It should be possible to use a svg file for header options.

At the moment, we don't support svg file in pdf export. See IMAGE_USABLE_FOR_PDF_MIMETYPE.
This is not a bug. Adding the support for svg requires some work, but I think could be possible with pdfmake.

pdfmake supports svg. However, they are integrated differently than images. This also needs to be implemented.


sso-express dependency supports multiple kc_idp_hint

Contributing a new feature to our sso-express dependency is required to enable #223.
See https://github.com/bcgov/cas-template-app/issues/67 for the description of the work

Hey team! Please add your planning poker estimate with Zenhub @AntBush @marcellmueller @VB-at-Bis

https://www.npmjs.com/package/@bcgov-cas/sso-express v3.2.0 was released


[release/1.4] Improve image pull performance from http 1.1 container registries

Improve image pull performance from http 1.1 container registries
(cherry picked from commit cc3785c815a1b560c088e3c349a91d3e0851b0bf)
Signed-off-by: Amr Mahdi<EMAIL_ADDRESS>

/ok-to-test

backport from #4653

@amrmahdi is that merged commit? Just see @estesp as a author

@amrmahdi is that merged commit? Just see @estesp as a author

Yes, see https://github.com/containerd/containerd/pull/4653

@amrmahdi is that merged commit? Just see @estesp as a author
Yes, see #4653

I think we generally cherry-pick the commit itself, not the merge commit, so in this case it would be the three commits from the PR; 289130b8a7760b813c7bcfdd37f978a17f10c31a, f6834d4c0b9a0433d6723ea172ad333ddc44936b, and b81917ee72a8e705127006084619b5c0ef76aa8e
Could you re-do the cherry-pick with those?;
git cherry-pick -s -x 289130b8a7760b813c7bcfdd37f978a17f10c31a f6834d4c0b9a0433d6723ea172ad333ddc44936b, and b81917ee72a8e705127006084619b5c0ef76aa8e

Thanks!

Thanks @amrmahdi !


Duplicate plugin

Description
It keeps saying "Duplicate Plugin" about cactbot overlay on notification tab.
Additional information
Here is the notification I got. What should I do?

could you screenshot your plugin list as well please?

Hello,
Here is my plugin list, I don't know where double cactbot comes from. How
to delete it?
[image: image.png]
2022년 5월 30일 (월) 오후 3:58, Akurosia Kamo @.***>님이 작성:

could you screenshot your plugin list as well please?
—
Reply to this email directly, view it on GitHub
https://github.com/quisquous/cactbot/issues/4549#issuecomment-1140772600,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZMTMZKQDGOOQUZ3A2UDISTVMRRKDANCNFSM5XJOA4GA
.
You are receiving this because you authored the thread.Message ID:
@.***>

Apperently the image does not load. but from your comment i think you have 2 cactbot instances.
To remove an instance you can click the small x in the top right corner.
To be sure to have the latest version (and a correct one, not an outdated corrupt one) i would remove both and install a fresh copy of cactbot via the getplugin button

Yes, exactly. I'll remove them and install a new one.
Thank you!
2022년 5월 30일 (월) 오후 6:11, Akurosia Kamo @.***>님이 작성:

Apperently the image does not load. but from your comment i think you have
2 cactbot instances.
To remove an instance you can click the small x in the top right corner.
To be sure to have the latest version (and a correct one, not an outdated
corrupt one) i would remove both and install a fresh copy of cactbot via
the getplugin button
—
Reply to this email directly, view it on GitHub
https://github.com/quisquous/cactbot/issues/4549#issuecomment-1140904616,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZMTMZOTF2Z7PED2MMFJ5JDVMSA37ANCNFSM5XJOA4GA
.
You are receiving this because you authored the thread.Message ID:
@.***>

No problem, if your issue is fixed, please close the github issue :)


Visualizer and Song Info Scale are not sanity checked

Rainmeter does not support decimals without a leading 0, thus if the user does not know this and enters .8 instead of 0.8 the scaled content will disappear and cause rainmeter CPU usage to max.
Not sure if it can be sanity checked easily, if not just slap a warning on it somewhere.

I also totally didn't just accidentally do this and spend a minute wondering why my rainmeter was lagging all the sudden.

Bug was fixed with the commit 89f2b43e306175b8751ebb142a6e43371171b06e.


Enable shumway in private browsing window.

At the current implementation, Shumway doesn't run in private browsing window on Firefox even if we set shumway.disabled as false.  I think that this is not good for testing for feedbacks, and this behavior confuse us for  coherency of the configuration.

There is the shumway.enableForPrivate about:config setting to enable that for private mode. See https://github.com/mozilla/shumway/wiki/Debugging-and-Configuring-Shumway . Thanks


Unrecoverable invalid_grant error state after multiple login attempts

Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.28.1
Wrapper Library
Not Applicable
Wrapper Library Version
None
Public or Confidential Client?
Confidential
Description
We have been using msal-browser for 18 months in our app successfully. However, I was troubleshooting a UI issue where multiple logins could be queued. While fixing the UI issue I had one loginPopup succeed immediately followed by another loginPopup showing a login window. This appear to get me into an unrecoverable invalid_grant: UserPrincipal doesn't have the key ID configured. state.
This state was not fixable by doing a full logout. In addition, it polluted other apps in the same browser, such as Office.com, Teams, and Kusto. The login flow did not give me the option to "Sign out and forget" the affected account either. The only fix that worked was to delete all cookies for login.microsoftonline.com in the browser.
Error Message
invalid_grant: UserPrincipal doesn't have the key ID configured.
Msal Logs
No response
MSAL Configuration
auth: {
  clientId: MsalAuthService.authClientId,
  redirectUri: `${window.location.origin}/authLanding.html`,
  clientCapabilities: ['CP1'],
  authority: getTenantAuthority(),
  navigateToLoginRequestUrl: true
},
cache: {
  cacheLocation: 'localStorage',
  storeAuthStateInCookie: false
}

Relevant Code Snippets
// Simplified version of code that I assume got me into this state
await loginPopup();
await loginPopup();

Reproduction Steps

Call loginPopup and log in successfully
Immediately call loginPopup again

Expected Behavior
While I know that calling loginPopup isn't proper use of the API, it seems this error should be recoverable through the MSAL API without requiring manual user intervention.
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Edge
Regression
No response
Source
Internal (Microsoft)

We think this is a MFA issue at the backend. Will reach out if we have specific conditions you may have to check in your app registration to surpass this.

Closing. Tracking offline as needed.


NHAIS Java Version

Java implementation of NHAIS supporting all feature up to and including 486960e2602f39f286cc2c709e22dd8442413f09
NIAD-148: create scaffold for HA/GP link adaptor service inbound

Create a new rebased branch


h

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

GAA!


chore: align vitest config filenames

Motivation
Make sure vitest configuration files all follow the same pattern: vitest.$TYPE.config.ts

@jeluard The sim tests are failing, before re-running double check if the error output is understandable or we need any improvements there.

@nazarhussain Unclear how I should read the error. I only see
├──── node-1-beacon_lodestar: node has not finalized expected slot finalizedSlot=56 expectedFinalizedSlot=64

as suspicious.

So node is not finalizing the chain, it should have reached to 64 finality but yet reaches to 56. There must be some attestations missing and there would be some error messages for it as well.

@nazarhussain what does that error have to do with this PR?

:tada: This PR is included in v1.16.0 :tada:


Physics simulation

Possible applications include:

Particles
Fluids
Rigid bodies
Deformable objects/continuum mechanics

Not sure it has any use here but I started investigating finite elements some time ago for solving static mechanical problems in JS http://thibauts.me/bridge/.
The elements here are simple bars (no moments, only bar compression / extension) but it should be quite easy to extend the engine to support more complex elements given the correct stiffness matrices (though they can be very complicated to compute).


addidng sender in place of history api

Add a PR title
Describe what changed in this PR at a high level.
Issue
Add a link to the issue here.  Consider using
closing keywords
if the this PR isn't for a story (stories will be closed through different means).
Checklist

[ ] I have added tests to cover my changes
[ ] I have added logging where useful (with appropriate log level)
[ ] I have added JavaDocs where required
[ ] I have updated the documentation accordingly

Note: You may remove items that are not applicable

Closing this PR as the code has been merged using this other PR.


feat: add array/base/join

Resolves #1327 .
Description

What is the purpose of this pull request?

This pull request adds array/base/join.
Related Issues

Does this pull request have any related issues?

This pull request:

closes #1327

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

@adityacodes30 Also, please note how I updated your OP and the PR title. The more you can reduce maintainer noise, the quicker you'll be to receive a review and the more likely that your future PRs will be merged.

got it @kgryte, thanks for the very descriptive review - does make things a lot clearer for this pr and going forward

@kgryte i have made the requested changes, let me know if any other edits are needed


TypeError: Q.nextTick.runAfter is not a function

var answer = q.defer();
var replyQueue;
function MaybeAnswer(msg) {
      answer.reject(new Error(msg.content.toString()));
}

return ch.assertQueue(toQueue, queueOptions || this.queueOptions)
                           .then(function () {
                               return ch.assertQueue('', this.replyQueueOptions);
                           }.bind(this))
                           .then(function assertQueueSuccess(qok) {
                               replyQueue = qok.queue;
                               return ch.consume(replyQueue, MaybeAnswer.bind(this), {noAck: true});
                           }.bind(this))
                           .then(function consumeSuccess() {
                               ch.sendToQueue(toQueue || this.queue, new Buffer(msg), props);
                               return answer.promise;
                           }.bind(this))
                           .catch(function (error) {
                               // Return Error to the outer .catch()
                               this.logger.error(error);
                               return q.reject(error);
                           }.bind(this))
                           .finally(function () {
                               if (this.standalone) {
                                   conn.close();
                               }
                               else {
                                   ch.close();
                               }
                           }.bind(this));

While running above code I'm getting an error

TypeError: Q.nextTick.runAfter is not a function

stack trace: at trackRejection (/Volumes/DATA/projects/cirrent/api-dev/node_modules/q/q.js:1059:20)
at reject (/Volumes/DATA/projects/cirrent/api-dev/node_modules/q/q.js:1133:5)
at deferred.reject (/Volumes/DATA/projects/cirrent/api-dev/node_modules/q/q.js:634:16)
at Object.MaybeAnswer (/Volumes/DATA/projects/cirrent/api-dev/node_modules/API-Common/helpers/rpc.js:98:44)
at Channel.BaseChannel.dispatchMessage (/Volumes/DATA/projects/cirrent/api-dev/node_modules/amqplib/lib/channel.js:466:12)
at Channel.BaseChannel.handleDelivery (/Volumes/DATA/projects/cirrent/api-dev/node_modules/amqplib/lib/channel.js:475:15)
at emitOne (events.js:77:13)
at Channel.emit (events.js:169:7)
at /Volumes/DATA/projects/cirrent/api-dev/node_modules/amqplib/lib/channel.js:263:10
at Channel.content [as handleMessage] (/Volumes/DATA/projects/cirrent/api-dev/node_modules/amqplib/lib/channel.js:316:9)
I really couldn't find out what's gone wrong with my code. I'd appreciate if anyone can help with this.

I just started seeing this issue as well in a section of code that has not been touched in months.  It doesn't happen in my development environment - only in my staging environment.  It doesn't look like any of my module dependencies have changed either.  If I find a solution I will post back here.

Might be useful to share versions of Node.js and perhaps any modules that might be monkey-patching nextTick. Maybe do a search for occurrences of runAfter. There are no direct references to nextTick.runAfter in Q.

Here is the relevant part of my package.json:
"dependencies": {
"apn": "^1.7.5",
"binaryjs": "^0.2.1",
"body-parser": "^1.14.0",
"bufferutil": "^1.2.1",
"compression": "^1.6.0",
"connect-mongodb-session": "^1.0.6",
"cookie-parser": "^1.4.0",
"ejs": "^2.3.4",
"express": "^4.13.3",
"express-session": "^1.12.1",
"express-stormpath": "^2.1.0",
"express-ws": "^0.2.6",
"fluent-ffmpeg": "^2.0.1",
"moment": "^2.10.6",
"moment-timezone": "^0.5.0",
"mongodb": "^2.0.47",
"mongoose": "^4.2.4",
"multer": "^1.1.0",
"newrelic": "^1.23.0",
"numeral": "^1.5.3",
"q": "^1.4.1",
"sharp": "^0.11.4",
"stormpath": "^0.13.4",
"twitter": "^1.2.5",
"winston": "^2.1.0",
"winston-mongodb": "~1.2.0",
"xml2js": "^0.4.15"
},
"engines": {
"node": "^5.0.0",
"npm": "^3.3.10"
}

Interestingly, I only have this problem on a single (virtual) machine.  Even when I deploy the same setup to a different server (i.e, my qa server), it works fine.
Also, not sure what you mean when you say "There are no direct references to nextTick.runAfter in Q."  It is defined in q.js line 240, making it all the stranger that it doesn't find it.

BTW, thanks for such a quick response.

I have fixed my issue.  In copying and pasting my package.json, I realized there were a couple of modules that I wasn't using any longer and removed them (grunt-git, grunt-spritesmith, throttle and signal-master).  I also removed a "require" reference to one of the modules which was never being called (throttle).  When I redeployed to the server that was reporting this error, the problem went away.
Not sure if this helps @nikolay211 or not, but I thought I would at least report how I resolved it.
Thanks again for the response.

Pardon, I was on the wrong branch. Q does in fact have a nextTick.runAfter now.

We've just been bitten by this issue as well, after an upgrade to node v4 and latest versions of React, etc.  Yet to find a solution.

Would anyone be able to Q.nextTick.toString() and manually verify that nextTick.runAfter is missing? Sounds like something is monkey-patching Q.

looks like it was the [node-newrelic](https://github.com/newrelic/node-newrelic) module. they just released a fix today. https://github.com/newrelic/node-newrelic/commit/8042f18e65cdbfa9c1acf13e39f28483741a3944

Thanks @mdressman. Let’s keep this issue open to track how Q can be more resilient against this kind of monkey-patching. nextTick should close over its runAfter dependency instead of exposing it as public API.

The rationale was to let people change the scheduler kind of like bluebird's setScheduler. I don't think we should explicitly hide it.

Perhaps we can move it to a top level hook.
On Tue, Feb 23, 2016 at 12:56 AM Benjamin Gruenbaum <
<EMAIL_ADDRESS>wrote:

The rationale was to let people change the scheduler kind of like
bluebird's setScheduler. I don't think we should explicitly hide it.
—
Reply to this email directly or view it on GitHub
https://github.com/kriskowal/q/issues/764#issuecomment-187606563.

Any news on this? I would also like to change the scheduler for use with Angular where I would require all handlers to execute within the digest cycle.
This is done in angular-bluebird-promises using bluebird's setScheduler as follows.
  ...
  .run(function($rootScope, Bluebird) {
    Bluebird.setScheduler((cb) => $rootScope.$evalAsync(cb));
  });

Thanks.

As the person who suggested the scheduler APi for bluebird I'll gladly implement an API for Q for the same thing if Kris asks.

In the meantime, the following appears to work for Angular:
// monkey-patch Q so that it schedules tasks during the digest cycle.
const angularNextTick = task => () => $rootScope.$evalAsync(task);
const {nextTick} = Q;
Q.nextTick = task => nextTick(angularNextTick(task));
const {runAfter} = nextTick;
Q.nextTick.runAfter = task => runAfter(angularNextTick(task));

And here is a simple test to confirm that it's always $digest phase:
setInterval(() => {
    Q.delay(10).then(() => console.log('$$phase =', $rootScope.$$phase));
}, 100);

@zamb3zi , Attempting your workaround, runAfter comes back as undefined when destructuring nextTick after reassignment.  I'm using<EMAIL_ADDRESS>


[type:fix] fix timestamp error

Make sure that:

[ ] You have read the contribution guidelines.
[ ] You submit test cases (unit or integration tests) that back your changes.
[ ] Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

Codecov Report

Merging #3720 (996052d) into master (059c124) will increase coverage by 0.56%.
The diff coverage is 88.73%.

@@             Coverage Diff              @@
##             master    #3720      +/-   ##
============================================
+ Coverage     63.61%   64.17%   +0.56%
- Complexity     5980     5993      +13
============================================
  Files           897      897
  Lines         24681    24622      -59
  Branches       2249     2237      -12
============================================
+ Hits          15700    15801     +101
+ Misses         7565     7407     -158
+ Partials       1416     1414       -2

Impacted Files
Coverage Δ

...d/loadbalance/ShenyuSpringCloudServiceChooser.java
87.69% <87.69%> (ø)

...e/shenyu/plugin/springcloud/SpringCloudPlugin.java
94.11% <100.00%> (+23.52%)
:arrow_up:

...in/springcloud/SpringCloudPluginConfiguration.java
100.00% <100.00%> (ø)

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
68.75% <0.00%> (-31.25%)
:arrow_down:

...controller/ShenyuClientHttpRegistryController.java
77.77% <0.00%> (-22.23%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
70.40% <0.00%> (-19.39%)
:arrow_down:

...yu/sync/data/http/refresh/AbstractDataRefresh.java
68.96% <0.00%> (-13.80%)
:arrow_down:

...ruptor/RegisterClientServerDisruptorPublisher.java
52.94% <0.00%> (-11.77%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc73d4f...996052d. Read the comment docs.


Icon request: Escape from Tarkov

URL for the brand / site / app
https://www.escapefromtarkov.com/?lang=en
Logo resources for the icon
No response
Proof of the Aegis-compatible 2FA
https://forum.escapefromtarkov.com/topic/75988-accounts-security/
Anything else?
With all this things happening in Ukraine, I understand if you do not want to add a icon for a Russia gamedev. Just tell me if so
Confirmation

[X] I have read and followed the issue guidelines & issue form.

We're okay with it.
But please don't change issue title formatting.

Here you go!
https://github.com/aegis-icons/aegis-icons/blob/master/icons/1_Primary/Battlestate Games.svg

:question: How to add icon(s) to Aegis?
:star: Support this project by giving a star! Just adding like to this comment is also appreciated.


[google_sign_in] adds option to re-authenticate on google silent sign in

Adds an optional paramter to the signInSilently method which allows the application using the plugin to decide whether re-authentication should be attempted.
Fixes #88556
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[X] I signed the CLA.
[X] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[X] I updated CHANGELOG.md to add a description of the change.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[X] All existing and new tests are passing.

Thanks @ThetaSinner! As I said, in web I'm not sure that calling signInSilently multiple times will cause the same effect as in android, but that's a gap that can be filled later. We just need to confirm it, so we can document the difference across platforms.

Looks like you're right about the web behaviour, the existing login is used to build the response to signInSilently.
The underlying JavaScript library does not discuss ID tokens (that I have seen!). The signIn method it provides is interactive.
It doesn't look like working quietly  with ID tokens on web will work without a change to the google-api-javascript-client library. I don't need it so I'm happy with documented differences. Would you like me to find somewhere for that to go and add it to this PR?

The web version is going to need a bunch of rewriting soonish, that might change things. In the meantime, let's do this. I think the web version re-authenticates automatically, so as long as one always requests the current identity from the JS code, the token will always be valid (at least, that's my operating assumption :P)

Thanks for the super-late review @cyanglaz !!

Hey @ThetaSinner, I wanted fresh idToken whenever i sign in. So I used this signInSilently method with reAuthenticate param as true. But I keep on getting the same idToken even after using this.

So the OAuth API itself won't give us new idtoken unless it is about to/did expire? Is there any way to force the api to respond with new id token whenever I request? I'm using a service which have just 60 seconds window time to validate.


TestMovingConnectionMemif failing in packet CI

Expected Behavior
Tests should pass reliably in CI
Current Behavior
https://circleci.com/gh/networkservicemesh/networkservicemesh/48157

I guess the link to circleci is wrong. Can you check?

I've run this test locally and the issue doesn't reproducible.
It's can be related to the packet loading. For this case, I'll reduce max NSC count and also enhance logs

Logging added, locally is not reproducible.


Upgrade gradle version to 7.3.3 and java version to 17

Description
Upgrade gradle version to 7.3.3 and java version to 17
Issues Resolved
https://github.com/opensearch-project/opensearch-plugin-template-java/issues/30
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi thanks for change, I think we should go right to the latest 7.4.2, as the core one [1] and client [2].
[1] https://github.com/opensearch-project/OpenSearch/blob/main/gradle/wrapper/gradle-wrapper.properties
[2] https://github.com/opensearch-project/opensearch-java/blob/main/gradle/wrapper/gradle-wrapper.properties

Hey @reta I have tested with 7.4.2 and with java version 17, I can see build successful but with some warnings,  I dint not see much with 7.3.3, so should we still go with 7.4.2, being latest is always good, but I guess few plugins are still using 7.3.3, any thoughts @dblock @reta ?
[opensearch@11827a526d02 opensearch-plugin-template-java]$ ./gradlew build
Downloading https://services.gradle.org/distributions/gradle-7.4.2-bin.zip
...........10%...........20%...........30%...........40%...........50%...........60%...........70%...........80%...........90%...........100%
Starting a Gradle Daemon (subsequent builds will be faster)
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.4.2
  OS Info               : Linux 5.4.186-113.361.amzn2int.x86_64 (amd64)
  JDK Version           : 17 (Eclipse Temurin JDK)
  JAVA_HOME             : /opt/java/openjdk-17
  Random Testing Seed   : 33B66407CABEA770
  In FIPS 140 mode      : false
=======================================

> Task :javadoc
/usr/share/opensearch/git/opensearch-plugin-template-java/src/main/java/org/opensearch/path/to/plugin/RenamePlugin.java:13: warning: no comment
public class RenamePlugin extends Plugin {
       ^
1 warning

> Task :compileTestJava
Note: /usr/share/opensearch/git/opensearch-plugin-template-java/src/test/java/org/opensearch/path/to/plugin/RenamePluginIT.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :integTest
OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/usr/share/opensearch/.m2/repository/org/opensearch/test/framework/2.0.0-alpha1-SNAPSHOT/framework-2.0.0-alpha1-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/usr/share/opensearch/.gradle/wrapper/dists/gradle-7.4.2-bin/48ivgl02cpt2ed3fh9dbalvx8/gradle-7.4.2/lib/plugins/gradle-testing-base-7.4.2.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

> Task :test
OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/usr/share/opensearch/.m2/repository/org/opensearch/test/framework/2.0.0-alpha1-SNAPSHOT/framework-2.0.0-alpha1-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/usr/share/opensearch/.gradle/wrapper/dists/gradle-7.4.2-bin/48ivgl02cpt2ed3fh9dbalvx8/gradle-7.4.2/lib/plugins/gradle-testing-base-7.4.2.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

> Task :yamlRestTest
OpenJDK 64-Bit Server VM warning: Ignoring option --illegal-access=warn; support was removed in 17.0
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.opensearch.bootstrap.BootstrapForTesting (file:/usr/share/opensearch/.m2/repository/org/opensearch/test/framework/2.0.0-alpha1-SNAPSHOT/framework-2.0.0-alpha1-SNAPSHOT.jar)
WARNING: Please consider reporting this to the maintainers of org.opensearch.bootstrap.BootstrapForTesting
WARNING: System::setSecurityManager will be removed in a future release
WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.gradle.api.internal.tasks.testing.worker.TestWorker (file:/usr/share/opensearch/.gradle/wrapper/dists/gradle-7.4.2-bin/48ivgl02cpt2ed3fh9dbalvx8/gradle-7.4.2/lib/plugins/gradle-testing-base-7.4.2.jar)
WARNING: Please consider reporting this to the maintainers of org.gradle.api.internal.tasks.testing.worker.TestWorker
WARNING: System::setSecurityManager will be removed in a future release

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4.2/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 40s
28 actionable tasks: 28 executed

@peterzhuamazon @bbarani

Hey @reta I have tested with 7.4.2 and with java version 17, I can see build successful but with some warnings, I dint not see much with 7.3.3, so should we still go with 7.4.2, being latest is always good, but I guess few plugins are still using 7.3.3, any thoughts @dblock @reta ?

Thanks @prudhvigodithi , in my opinion, I don't see the reasons to use the unsupported Gradle version release line, we should aim to stay on the latest one, as core does (and so would be good to have plugins updated as well).

Hey @reta, make sense, in my latest commit I have updated gradlew, gradlew.bat, gradle/wrapper/gradle-wrapper.properties, gradle/wrapper/gradle-wrapper.jar  that support 7.4.2 version.

Thanks @prudhvigodithi !

Hey @reta I guess there is something missing, downloading the gradle-7.4.2.zip from releases, I can see gradle-wrapper.properties uses gradle-7.4.1-bin.zip
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

@prudhvigodithi This is non-issue, the wrapper does not need to change from release to release, you could also check it here:
[1] https://gradle.org/release-checksums/

@reta yes the link you provided is what I have used to verify the checksums, but found this link upgrading_wrapper, its always good to upgrade the wrapper with version as well.
But ya this separate discussion, need not be with this PR.

Hey @reta and @dblock can we merge this PR, I will create a new PR adding the custom gradle plugin opensearch.pluginzip, with opensearch_version = "2.0.0-alpha1-SNAPSHOT" .


various Dialect enhancements

This patch incorporates the following changes in the area of Dialects:
Improvements to SQL type mappings
The patch improves the Dialect-specific SQL type name mappings:

eliminate the massive duplication in type name registration; each dialect now only overrides what is non-standard
use timestamp with time zone where possible, depending on the dialect (for Java types OffsetDateTime, ZonedDateTime, and Calendar)
use boolean instead of bit where possible, depending on the dialect (for Java types Boolean and boolean)
sort out some confusion surrounding binary string type mappings
improvements specific to TimesTen and Mimer

SQL type precision and scale
Most importantly, it fixes a bunch of issues surrounding precision and scale:

allow JavaTypeDescriptors to contribute a length/precision/scale to their mapped type
fix the total mess that was real vs float vs double — since none of these type names has anything like a consistent precision across databases, and since float vs double is definitely not a difference of precision (!), explicit float(24) and float(53) are now used as consistently as possible
allow user to specify timestamp(p) precision using @Column(precision=p)
fix mapping of BigInteger to give it scale 0 — fixes a pretty ancient bug
when any decimal, numeric, or timestamp type has no explicitly-defined precision, use a dialect-specific default — this makes casting and DDL generation more portable across databases, especially with BigInteger and BigDecimal
change default mapping for Duration from bigint to numeric(21,0)

Additional types in cast() function
The following additional cast() target types are now supported

Binary
Character
BigDecimal and BigInteger
Boolean (with caveats)
LocalTime,  LocalDate, and LocalDateTime

Also, length or precision/scale may be specified for target types.

cast(number as String(10))
cast(text as Binary(100)
cast(amount as BigInteger(20))
cast(measurement as BigDecimal(10, 5))

Of course, the length, precision, or scale might be ignored, depending on the SQL type defined by the Dialect. (In particular, they're always ignored on Spanner, which doesn't support length, precision, or scale in cast().)
Additional "standard" HQL functions
HQL was enhanced with the following new "standard" functions:

left() and right(), as simpler alternatives to substring()
any() and every() aggregate functions

Additional dialect-specific function registrations
The following non-standard function registrations were added:

add missing trunc(), truncate(), and insert() functions on most databases
add a bunch of dialect-specific SQL aggregate functions, especially statistical functions
registered some dialect-specific functions similar to current_date/current_time
improvements specific to Mimer and Teradata
migrate MimerDialect and SpannerDialect to use of CommonFunctionFactory

This patch also fixes the use of non-standard functions in the select clause.
Function list
To allow the user to actually see what functions a dialect supports:

add the hibernate.dialect.show_sql_functions property to allow the user to easily log all the registered SQL functions with their signatures to the console
some misc improvements to SQL function registrations in order to get a more accurate signature list

fix the total mess that was real vs float vs double .. since none of these type names has anything like a consistent precision across databases, and since float vs double is definitely not a difference of precision (!), explicit float(24) and float(53) are now used as consistently as possible

The irony here is that the interpretation of the precision  argument of the FLOAT type isn't totally consistent either. There are a couple of DBs which interpret it as decimal digits instead of binary digits.
And then there's Sybase. Even after reading it about 20 times I still don't understand what Sybase interprets it to mean  ¯_(ツ)_/¯. Somehow single precision is p<=16. Perhaps they have an idiosyncratic interpretation of "single precision".
So anyway I will probably introduce an additional abstraction over float precision.

I've introduced some support for mapping things to time[stamp] with timezone. It's disabled for now because these JDBC types just aren't well-supported on most databases for now. But users of Oracle could surely take advantage of it in their user types. (And it's there for the future.)

There are a couple of DBs which interpret it as decimal digits instead of binary digits.

I've fixed this issue, at least for Mimer and CUBRID. I don't have access to Sybase to try and figure out what its semantics are.

I added the very-useful hibernate.dialect.show_sql_functions setting.

Damn, looks like due to some changes in the tests for envers, the build of this branch is now failing. 😟

FTR, I think it's commit @da13a0b401290283ed6fc0b6630d9e3379f19bbe that breaks my branch.

I have merged #2873 and #2872 into this branch.

I have merged #2860 into this branch.

I have merged #2860 into this branch.

I have merged #2871 and #2877 into this branch.

@gavinking Thanks for the heads up!
I honestly dislike the fact that a few of the Envers tests operate this way in the first place, essentially they allow hbm2dll to create the schema then the test drops part of it to manually re-create with to allow null values in columns.  I made a note when I ported these to come back to them as a part of 6.0 and see if these can be re-worked not to operate this way in the first place.
The good news is this only impacts 3 test Envers classes overall and they all do precisely the same.  The columns that are actually re-created using this approach don't have any form of precision, length or scale so that's likely why the original author picked the method in the first place.

WTF, how can I have merge conflicts when I just rebased on the most recent revision of wip/6.0? I didn't think that was even possible!

any() and every() aggregate functions

Any may cause ambiguity for subqueries that return a single boolean valued column. From the PostgreSQL documentation:

Boolean aggregates bool_and and bool_or correspond to standard SQL aggregates every and any or some. As for any and some, it seems that there is an ambiguity built into the standard syntax:
SELECT b1 = ANY((SELECT b2 FROM t2 ...)) FROM t1 ...;

Here ANY can be considered either as introducing a subquery, or as being an aggregate function, if the subquery returns one row with a Boolean value. Thus the standard name cannot be given to these aggregates.

Are we sure any and every names are appropriate and non-ambiguous in JPQL/HQL?

Are we sure any and every names are appropriate and non-ambiguous in JPQL/HQL?

They're unambiguous in context because of how they occur syntactically.

@gavinking I am going to make some time this week to help you get this up to date with the current 6.0 branch if you have the time as well.

I am going to make some time this week to help you get this up to date with the current 6.0 branch if you have the time as well.

Great, let's do it!

Tomorrow work for you?

Yep, should work fine. You are in central time, right?

Yes.  Around 9 or 10 (my time) works best for me.  @dreab8 may join as well

Yep, 4pm my time looks good.


Additional prompt when overwriting value

Description
When overwriting value with a new value additional prompt show up
Steps to Reproduce
uses set secret1 foo
Overwrite value? (y/n) y
Enter value:

Since value of secret is provided additional Enter value: is not required.

This in not an issue since the format for setting a secret in a single line is uses set name=value.


Question: webpack loaders includes 'node_modules' folder

Question:
Why do the css, json, file and url loaders all include node_modules folder?
It works without it, and the build time is shortened.

Because people often need to consume these files from external packages. (For example Bootstrap.)
If you see optimization opportunities inside Webpack for this please let us know. It's a bit weird that including a directory makes build slower even if you don't import anything from that directory.


Install missing _utils.py and binary/wrappers.

This patch installs the missing _utils.py and nanopb_pb2.py into the
expected proto/ subfolder.  Otherwise the generator script imports will
not find them in the proper namespace.
It also installs the generator and wrapper scripts in
CMAKE_PREFIX_PATH/bin/. WIN32 is handled specially since it has a
separate wrapper (.bat).

Hmm, I think nanopb.proto might be needed also, so that .proto files that import it will compile without extra settings.
If you can, try e.g. ..../nanopb_generator.py tests/common/person.proto to see if that works.

OK, I just corrected this.  Please review, as I did it 'generically' by adding the rule to install the .proto file from within the foreach() although I'm not sure of the design.
Thanks for pointing me at this feature.  I've historically used .options, but have at least once gotten into trouble when someone regenerated the messages forgetting the .options files and silently broke everything.  Having the nanopb specific stuff directly in the .proto is a better solution IMHO.

Thanks. I'll try to add some kind of build test later if I remember.


Document the Zowe architecture

Describe the high-level architectural components of Zowe. Provide a good overview of how those components fit together. Also how the architecture will evolve.
There is one placeholder topic now: https://github.com/zowe/docs-site/blob/docs-staging/docs/getting-started/zowe-architecture.md. We need diagrams and more detailed explanations.

This topic is here: https://zowe.github.io/docs-site/latest/getting-started/zowe-architecture.html.


Set up a configuration for dependabot

Starting out with news being updated monthly as we don't run it that often, GitHub Actions and the main Python dependencies as daily as we use/push things out that frequently. I am starting out with npm turned off until we are comfortable to handle the initial onslaught of updates that will trigger and we are comfortable with our testing being able to catch potential errors.

Codecov Report

Merging #13671 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13671      +/-   ##
==========================================
- Coverage   59.72%   59.70%   -0.03%
==========================================
  Files         674      674
  Lines       37667    37667
  Branches     5404     5404
==========================================
- Hits        22498    22490       -8
+ Misses      14016    14007       -9
- Partials     1153     1170      +17

Impacted Files
Coverage Δ

src/client/datascience/crossProcessLock.ts
79.41% <0.00%> (-11.77%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-5.89%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

src/client/logging/levels.ts
61.11% <0.00%> (ø)

src/client/logging/logger.ts
62.74% <0.00%> (ø)

src/client/logging/formatters.ts
53.57% <0.00%> (ø)

src/client/logging/transports.ts
65.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5699d4...3fc29f0. Read the comment docs.


QXL Kernel Module causing display corruption

In certain guests (Fedora 30, Debian Stretch), having the QXL kernel module enabled causes display corruption when using SPICE instead of VNC.  Blacklisting the QXL module and rebooting resolves the issue.
The current workaround is to do this in user-data, but it can be unwieldy, especially for new users.
The kinetic image build process should account for this in affected images.

Started this work in https://git.cybbh.space/bitskrieg/images/blob/master/mods/fedora30.yaml.
Appears to function correctly in Fedora.  Waiting for more feedback.

Images created with virt-builder (http://libguestfs.org/virt-builder.1.html) do not have this problem.  The bakery should be built around this tooling where possible.


Refactor how Embrace attributes are defined

Goal
Create an abstraction for an Embrace Attribute and define a sealed class for each attribute and an implementation of that class for each valid value.
I converted two attributes just to get some feedback as to whether this is a good idea/implementation. If it looks good, I can convert EmbType/TelemetryType to this format as well.
The goal is to be able to use these class when validating values in tests, and also when we write out the property to OTel objects, instead of having to hardcode rules like putting emb. in front of attribute names, etc.
If this looks good, I'll add convenience methods to internal objects and tests to simply the code that words with Embrace attributes, so you can do something like span.setEmbraceAttribute(ErrorCode.Failure)
Testing
Existing tests cover the usage, but unit tests should be added to test the abstract classes if this is deemed a good way to go.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#526  👈
#525
#524
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite

Merge activity

Mar 11, 11:26 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.


Errno::EAGAIN: Resource temporarily unavailable @ rb_sysopen

Getting this error when running bundle install and a new gem needs to be downloaded/installed:

--- ERROR REPORT TEMPLATE -------------------------------------------------------
- What did you do?

  I ran the command `/home/user/.rbenv/versions/2.2.4/bin/bundle install`

- What did you expect to happen?

  I expected Bundler to...

- What happened instead?

  Instead, what actually happened was...

Error details

    Errno::EAGAIN: Resource temporarily unavailable @ rb_sysopen - /home/user/app/Gemfile.lock
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/definition.rb:268:in `initialize'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/definition.rb:268:in `open'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/definition.rb:268:in `block in lock'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/shared_helpers.rb:114:in `filesystem_access'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/definition.rb:267:in `lock'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/environment.rb:34:in `lock'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/installer.rb:72:in `run'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/installer.rb:21:in `install'
      /home/user/.rbenv/rbenv.d/exec/gem-rehash/rubygems_plugin.rb:27:in `install'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/cli/install.rb:105:in `run'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/cli.rb:172:in `install'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/cli.rb:10:in `start'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/exe/bundle:19:in `block in '
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/lib/bundler/friendly_errors.rb:7:in `with_friendly_errors'
      /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0/gems/bundler-1.11.2/exe/bundle:17:in `'
      /home/user/.rbenv/versions/2.2.4/bin/bundle:23:in `load'
      /home/user/.rbenv/versions/2.2.4/bin/bundle:23:in `'

Environment

    Bundler   1.11.2
    Rubygems  <IP_ADDRESS>
    Ruby      2.2.4p230 (2015-12-16 revision 53155) [x86_64-linux]
    GEM_HOME  /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0
    GEM_PATH  /home/user/.rbenv/versions/2.2.4/lib/ruby/gems/2.2.0:/home/user/.gem/ruby/2.2.0
    Git       1.9.1
--- TEMPLATE END ----------------------------------------------------------------

Unfortunately, an unexpected error occurred, and Bundler cannot continue.

First, try this link to see if there are any existing issue reports for this error:
https://github.com/bundler/bundler/search?q=Resource+temporarily+unavailable+%40+rb_sysopen+-+%2Fhome%2Fuser%2Fapp%2FGemfile.lock&type=Issues

If there aren't any reports for this error yet, please create copy and paste the report template above into a new issue. Don't forget to anonymize any private data! The new issue form is located at:
https://github.com/bundler/bundler/issues/new

This happens after all the gems are installed.
Gemfile.lock is not updated.
Then I run bundle install again and it succeeds and updates Gemfile.lock.
The OS is Ubuntu 14.04 in a virtualbox VM.

@segiddins @RochesterinNYC looks like we're missing a permissions error from the friendly handler

Fixed by #4189.


Copy PDB files option in build tools

Copy PDB files option in build tools
I see the option to copy pdb files when compiling in editor for both UWP and Standalone Windows:

However, I couldn't find this option exposed on unity command line, nor in the MRTK command line build scripts. It would be nice to have this option exposed so that we can build with PDB files on CI builds.
Solution
I suggest we add an bool to BuildInfo and flag to ParseBuildCommandLine which can then be used to set the some value in the Unity C# build settings.

Closing as stale for now; please reopen if this is still necessary.


Stream verb design for connection drops

[x] design
[ ] changes in server
[ ] changes in SDK
[ ] testing
[ ] merge to trunk

POC code checked into
https://github.com/atsign-company/murali-snippets/tree/master/stream

dev testing is done. logic to code when to initiate stream resume from client pending

server release 2.0.3 for stream resume support


Flash of empty content

When loading the list of products, I'm seeing a "Sorry, we couldn't find what you're looking for" for a brief period. This is then replaced by the list of products. It seems that until the products have been fetched, we're rendering the "couldn't find what you're looking for message.
This appears to be what's rendered on the server as well, so it seems that perhaps the Server Side Rendering is not correctly rendering a list of products.

Worth noting that this issue was seen on our test deployment and it is probably not connected to the latest 1.15.0 API, so it may not be present on the latest version.

Had the same issue when using React Apollo (not SSR scenario though). Maybe it is related. See https://github.com/apollographql/react-apollo/issues/1314


How to disable rpi-sb-provisioner

After installing Version 1.2.0 and rebooting I don't seem to have a service running
systemctl list-units rpi-sb-provisioner*

  UNIT LOAD ACTIVE SUB DESCRIPTION
0 loaded units listed. Pass --all to see loaded but inactive units, too.
To show all installed unit files use 'systemctl list-unit-files'.

I would like to stop the service so that I can manually run rpiboot.

I do have a .service file but the service is not found.
$ cd /usr/local/lib/systemd/system
/usr/local/lib/systemd/system $ cat<EMAIL_ADDRESS>[Unit]
Description=Provision a Raspberry Pi Device with a authentication key, a device-unique key, and an OS that you supply.

[Service]
Type=oneshot
ExecStart=/usr/local/bin/rpi-sb-provisioner.sh %I
EnvironmentFile=/etc/rpi-sb-provisioner/config
/usr/local/lib/systemd/system $ sudo service rpi-sb-provisioner status
Unit rpi-sb-provisioner.service could not be found.

rpi-sb-provisioner is installed.
$ dpkg -s rpi-sb-provisioner
Package: rpi-sb-provisioner
Status: install ok installed
Priority: optional
Section: admin
Installed-Size: 116479
Maintainer: Tom Dewey<EMAIL_ADDRESS>Architecture: arm64
Version: 1.2.0
Depends: fastboot (>= 33.0.3), python3, python3-pycryptodome, openssl, cpio, sed, android-sdk-platform-tools, awk, xxd, rpi-eeprom (>= 26), rpiboot, coreutils, curl, bash, gzip, dctrl-tools, diffutils, findutils, libengine-pkcs11-openssl, libp11-kit-dev, gnutls-bin, jq
Pre-Depends: dpkg (>= 1.16.1)
Conffiles:
 /etc/default/rpi-sb-provisioner 27158014ce808e1f35615456a9d2c4b7
Description: Automated provisioning of secure boot for Raspberry Pi Devices
Homepage: https://www.raspberrypi.com/software

I'll add this to the docs - but essentially, your safest move is to just disable the udev trigger, in the manner described in this AskUbuntu thread: https://askubuntu.com/questions/240632/how-to-disable-udev-net-rule-generation
I'd go for something like...
sudo ln -s /dev/null /etc/udev/rules.d/60-rpi-sb-provisioner.rules
Don't forget to delete that symlink when you want to turn it back on. It will persist across reboots.


Use Travis to build and release module binaries for all target platforms

This PR replaces node-pre-gyp with prebuild and updates the Travis config to build the modules for Linux (64-bit), macOS (64-bit) and Windows (32- and 64-bit). Target Node versions can be specified via the PREBUILD_TARGETS variable in .travis.yml.
Notes:

By default, prebuild and prebuild-release expect release tags to start with v (this prefix can be changed via the --tag-prefix argument).
GitHub token in .travis.yml needs to be changed.

Tested on Ubuntu 18.04 (64-bit), Windows 7 (32-bit), Windows 10 (64-bit) and macOS 10.12 (64-bit).
Fixes https://github.com/tessel/node-usb/issues/289 and https://github.com/tessel/node-usb/issues/78.

Thanks!
@HipsterBrown do you want to review this since you have experience with prebuild? Otherwise I'll take a look this weekend.

It would be wonderful if this PR could be modified slightly to include Electron builds.
I've added a 'suggestion' via github that I'm pretty sure you can just include with a couple clicks?

@Mike-Dax Done.

The appveyor badge in the readme needs to removed as well.

@kevinmehall If it's helpful, we're using these changes internally and it's working well. (We run an internal prebuild registry)


Enable VSIX caching

Enable VSIX caching so that the same VSIX need not be downloaded if requested again

@sandy081 Remote-Containers has its own cache folder locally and copies VSIXs from that into containers. Could that reuse the CachedExtensionVSIXs folder?

I would not recommend to mix caches because these vsixs can be for different environments. I know currently they are same but this will lock us if in future if we get platform specific vsixs.

@sandy081 Ack, although that will be something to consider for the Remote-Containers VISX cache anyway.


Prefer trailing comma

We currently disallow trailing commas, even though this might be one of the more useful Kotlin features, and is in line with trends in other modern languages like golang. Having trailing commas helps diffs staying smaller, and easier copy'n pasting of code and moving code lines up and down.
Unnecessary trailing comma before ")" (standard:trailing-comma-on-call-site)

I'd suggest we switch from disallowing trailing commas to requiring them.

I agree with you, I also prefer trailing comma. I am not sure why it's disabled by default, there must be a reason (maybe historic because kotlin did not support it at some point?)
But yes, we have to require trailing comma

I guess we can close this now. Does the author close it, or the maintainer? Contribution guidelines aren't clear on that

Yes, we can close it, there are no written rule on it. It is usually automatically closed by github
fixed in https://github.com/IZIVIA/ocpi-toolkit/releases/tag/R-0.0.41


Renames the quickfix-related builtin variables from lsp references

Prior to this commit, there looks to have been some missed renames and cleanup for variables for the quickfix builtin function. Was referencing the LSP Reference builtin variables and labels.

Thanks!


Fail in Agent initialization if GRE tunnel type is used with IPv6

The 'gre' tunnel type does not work for IPv6 overlays. The correct
tunnel type for OVS would be 'ip6gre'. For dual-stack clusters with both
an IPv4 and an IPv6 overlay, we would need 2 default tunnel ports: one
for IPv4 (with type 'gre') and one for IPv6 (with type 'ip6gre'). This
would add complexity (and require testing) as the code currently assumes
a single default tunnel port. Rather than trying to support IPv6 with
the added complexity that it entails, we choose to fail during Agent
initialization for now if the user-provided tunnel type is 'gre' and the
cluster supports IPv6.
Note that this means that the default manifest for IPsec
(antrea-ipsec.yml) cannot be used in an IPv6 cluster as the tunnel type
defaults to GRE in that case. However, this is not new, and it is better
to fail explicitly rather than have a cluster where the Agent appears to
be running fine but there is no connectivity.
See #3150
Signed-off-by: Antonin Bas<EMAIL_ADDRESS>

Codecov Report

Merging #3156 (527eea4) into main (ebeb2d4) will decrease coverage by 2.33%.
The diff coverage is 31.25%.

@@            Coverage Diff             @@
##             main    #3156      +/-   ##
==========================================
- Coverage   60.74%   58.40%   -2.34%
==========================================
  Files         295      295
  Lines       24907    24909       +2
==========================================
- Hits        15130    14549     -581
- Misses       8118     8783     +665
+ Partials     1659     1577      -82

Flag
Coverage Δ

kind-e2e-tests
44.70% <31.25%> (-2.91%)
:arrow_down:

unit-tests
40.37% <12.50%> (+0.02%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/agent.go
51.97% <31.25%> (+1.07%)
:arrow_up:

...g/agent/apiserver/handlers/featuregates/handler.go
0.00% <0.00%> (-82.36%)
:arrow_down:

...kg/apiserver/registry/system/supportbundle/rest.go
19.54% <0.00%> (-55.18%)
:arrow_down:

pkg/support/dump_others.go
0.00% <0.00%> (-51.73%)
:arrow_down:

pkg/support/dump.go
8.33% <0.00%> (-48.34%)
:arrow_down:

...egator/apiserver/handlers/recordmetrics/handler.go
0.00% <0.00%> (-44.45%)
:arrow_down:

...g/agent/apiserver/handlers/addressgroup/handler.go
0.00% <0.00%> (-40.00%)
:arrow_down:

...agent/apiserver/handlers/appliedtogroup/handler.go
0.00% <0.00%> (-40.00%)
:arrow_down:

...gregator/apiserver/handlers/flowrecords/handler.go
0.00% <0.00%> (-40.00%)
:arrow_down:

pkg/apiserver/handlers/loglevel/handler.go
0.00% <0.00%> (-38.47%)
:arrow_down:

... and 34 more

@jianjuns @tnqn I rebased and resolved conflicts, could I get another review so I can merge this for 1.6?

/test-all

/test-all


Feature request - Add support of 3D Secure

Since 3D Secure is needed for some cards it would be nice that this plugin implements it.
Here is an exemple I fould about supporting 3D Secure for Stripe Checkout if it can be useful : https://jsfiddle.net/ywain/5j580jxa/

Just a little reminder that in September 2019, 3D Secure 2 will be required for every payments made in Europe : https://stripe.com/guides/3d-secure-2#d-secure-2-and-strong-customer-authentication

Hi @superheri thanks for the reminder.

@superheri do you see this feature as optional or required?

It is required for every card that require 3D Secure for transactions, otherwise the transactions will be refused by the card issuer. For now it is not much a problem, but it will be in September 2019 where 3D Secure will be required for every card transaction in the Europe (and I'm not talking about only one country).
We still have 5 months before it becomes a real problem, but I was only posting a reminder to inform you about this law.
This is mentionned in the link above to Stripe documentation as well as in many other articles like this one :
"14th September 2019 - PSD2’s SCA requirements go live in Europe. Any business with substantial European volume will need to have 3D Secure 2.0 implemented by this date in order to most effectively meet SCA requirements."
https://www.adyen.com/blog/psd2-understanding-strong-customer-authentication

Any update on this issue or workarounds?

Hello all, this issue is due in September 2019. I apologize, I am very busy right now. I hope I can find time to do this soon. Please be patient. Also, a PR would be much appreciated. Thanks.

I'm working on something, I might create a PR soon with this, so we could discuss about how to make it better because for now it's not optimal but it works.

That would be great. Please keep me updated.
On Sun, Apr 21, 2019, 08:36 superheri<EMAIL_ADDRESS>wrote:

I'm working on something, I might create a PR soon with this, so we could
discuss about how to make it better because for now it's not optimal but it
works.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/jofftiquez/vue-stripe-checkout/issues/48#issuecomment-485205637,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACB46I44RFKNZE3A6LHIVODPROZJPANCNFSM4GR4UWBQ
.

After research, Stripe is no more using the checkout modal. Instead, they updated their checkout window to be directly on their website. This checkout window has already the 3D Secure support and is auto updated so it will automatically support 3D Secure 2 when it will be available. This checkout window can be used in 2 ways, Client side or Server side.

Server side is almost completely fulfilled by the server so there is no point for a Vue integration.
Client side is still only a redirect sith some informations, like the product id of the product entered in Stripe Dashboard, that goes directly to Stripe checkout page to fulfill the transaction using a webhook or something like that.

So after al that research I don't see how all this can be integrated into a Vue component since there is almost no front-end code and the most Checkout window is dealed back-end.
@jofftiquez Can you give me your thoughts on this?

@superheri thank you for the insight. I will also research further regarding this.

I just want to let you know that will be done very soon. Thanks.

Hi Jofferson,
Just wanted to know have you already working on the this feature?

Hello @wpgeek922 I am. It's currently on a local branch. I will continue working on this soon. I'm sorry I  am so busy right now. Thank you for reminding me.

Hi @jofftiquez, thanks for working on this, much appreciated! Do you have any update on when can we expect this to be merged?
Thanks a million and keep up the great work!

Kindly refer to #64


Please make a new release.

Please make a new release so that the pyethereum package is again useable with the latest solidity version. We need a release that contains this PR: https://github.com/ethereum/pyethereum/pull/858
cc @joeykrug

Done!

Hahaha. Okay man thank you. That was really fast.


Error while using nvim on windows

Error
Every time i open nvim,there exists a couple of similar errors:
Error detected while processing C:\Users<MyUserName>/.vim/setting/nvim-lualine/lualine.nvim.vim:
E5108: Error executing lua vim/_init_packages.lua:24: cannot open C:\Users<MyUserName>.vim\plugged\lualine.nvim/lua/lualine.lua: No such file or directory
stack traceback:
[C]: in function 'error'
vim/_init_packages.lua:24: in function <vim/_init_packages.lua:18>
[C]: in function 'require'
[string ":lua"]:44: in main chunk
Not only can't this plugin load,other plugins only available at Neovim 0.7.0 also shows the same error
i don't need to show every error,they are exactly the same except plugin name
My try
I've tried to reinstall everything correlated,but the error remains the same.
I've also tried to check the encoding.It didn't help.
Note:every file path is correct and can be open in any terminal
I don't know why it can't be find in lua.Maybe it's caused by permissions,but i don't know how to fix it.
Tips
I've tried it on linux.Everything is ok.
So it is about windows and lua.

sorry i've just fix it myself.
It is about encoding.
I copy the .vim folder to gbk folder and it works.
Thanks.


[Request] Offline Editor Tool

I'd prefer if the editor was an offline tool instead that doesn't require you to use browser or internet.
Is it possible please?

Anything can be programmed; but what I'm willing to do, no it will remain online only. It does allow you to go offline once you've loaded it once though.

Anything can be programmed; but what I'm willing to do, no it will remain online only. It does allow you to go offline once you've loaded it once though.

Is it possible to at least save the page so, it still works offline even if you exit the browser and revisit later?

It should already do that. It does have an offline mode, it's had one for a few years i believe. Although I haven't tried in a long time to see if it still works.

It should already do that. It does have an offline mode, it's had one for a few years i believe. Although I haven't tried in a long time to see if it still works.

Nope, it's not working. Tried saving as a single HTML file and its all broken so tried saving via SingleFile addon and it seems to have only saved the design and not the scripts so the buttons do nothing.
Finally, tried saving as complete webpage and it loads fine but when I tried to load the save, I get an error both online/offline saying the following:-
Error

Error reading file:
undefined
(undefined:undefined)

So, I'm assuming not all scripts are saved :\

no, there is nothing to save. you just use the website as normal when you're offline. Saving it is going to break it.


Grape instrumentation renames last segment

Description
Last tracked event (database query, external api request or custom instrumentation anything that newrelic_rpm support) always renamed to "Middleware/Grape/<...>/call" where <...> is class name that implements grape api.
Expected Behavior
Grape instrumentation doesn't rename any custom instrumentation or instrumentation included in newrelic_rpm gem.
Steps to Reproduce
It is always reproducible with setup using: rackup + grape + newrelic_rpm
I created very simple example app https://github.com/seriousdev-gh/grape_new_relic_example

In screenshot you can see recieved segments. Example app create two segments with names Custom/LongProcess/1, Custom/LongProcess/2 and durations 1 and 2 seconds respectively. 2 second event must be named Custom/LongProcess/2 instead of Middleware/Grape/Main/call.
Your Environment
ruby 3.3.2 (2024-05-30 revision e5a195edf6) [x86_64-linux]
newrelic_rpm (9.16.1)
Other gem versions in example app.
Additional context
Found this line of code that i think causes the issue https://github.com/newrelic/newrelic-ruby-agent/blob/dev/lib/new_relic/agent/instrumentation/grape/instrumentation.rb#L62
For a workaround in my production app i wrote a monkeypatch:
module NewRelic::Agent::Instrumentation # rubocop:disable Style/ClassAndModuleChildren
  module Grape
    module Instrumentation
      extend self # rubocop:disable Style/ModuleFunction

      def name_transaction(route, class_name, version)
        txn_name = name_for_transaction(route, class_name, version)
        NewRelic::Agent::Transaction.set_default_transaction_name(txn_name, :grape)
      end
    end
  end
end

Hi @seriousdev-gh - Thank you so much for your detailed description and reproduction, and for sharing your workaround—it helped us quickly explore this issue and create a fix. It appears that renaming the last segment was part of an older Grape instrumentation that is no longer relevant. We've updated this part of the code in https://github.com/newrelic/newrelic-ruby-agent/pull/2987, which will go out in our next release.


Add alt text to images

Images on the Accord Project tech docs lack alternative text to describe the information for people with visual impairments.
https://docs.accordproject.org/
Here are some helpful resources:
https://www.w3.org/WAI/tutorials/images/
https://moz.com/learn/seo/alt-text
If you need help deciding what to make the alt text for an image, let me know.
Example of image with no alt text:

Looks awesome! I can take a look at this.

@Alexandria that would be great, thanks!

@Michael-Grover I see a lot of these pics have a generic alt message like "Advance-Late-1". Are you wanting those updated/changed or are you only concerned with the images that have no alt text at all?  Thanks!

@Alexandria more informative alt text would be good. The resources I sent in the issue are helpful for writing good alt text. Thanks for pointing this out and asking!

@Alexandria more informative alt text would be good. The resources I sent in the issue are helpful for writing good alt text. Thanks for pointing this out and asking!

Yup, I've been looking through those links. They have been supper helpful so far.

Hi @Michael-Grover could I also try to solve this issue, I am still newbie though 😅 ✌
thanks @Alexandria for made it clearer 👍

@djiwandou, I'll leave that up to @Alexandria since they've claimed this issue already. Thank you for being interested in helping!

@djiwandou Go for it! I am currently working on the home page(I'll open a draft request later). I did a quick run through the application and there is certainly enough work for two peeps. I'm also new too so no worries 👍
@Michael-Grover I had a question about the code base. Like I mentioned above I am working on the homepage. I see in the code where the image is being added. However I am not sure how to add the alt property to it.
I am looking here /website/pages/index.js

This seems to correlate to this image on the homepage.

It looks like the imgUrl() function may be creating the <img> tag but I am not sure. Would you be able to explain how I would go about adding the alt property in this case or point me in the right direction?

@Alexandria , I think @jeromesimeon would be able to answer your question. I'm not familiar with how this subsite is coded.

@Alexandria these docs are made from Docusaurus, I would look into their developer docs which could be helpful.

Hey @Alexandria @Michael-Grover @jeromesimeon , i love html can i take this issue would love to contribute

Is this still available to do? I am pretty good at HTML and would love to take this on!

Hey @Alexandria @Michael-Grover @jeromesimeon , i love html can i take this issue would love to contribute

Is this still available to do? I am pretty good at HTML and would love to take this on!

@Snaked06 and @aditya1rawat, up to @Alexandria and @djiwandou if they need help with the issue.

@Alexandria your PR looks great, I will add my review soon. Was anyone able to help you add alt text to the interior pages?
https://deploy-preview-135--accordproject-old.netlify.com/docs/accordproject.html

@Snaked06  and @aditya1rawat no additional help is needed right now with this one, but thanks!

@Michael-Grover I figured out how to modify the alt text in the internal webpages. I'll try to have another pull request buy the end of the day 👍

@Alexandria , awesome, thank you!

if @Alexandria is done with this, we can close it and open another one for improving the alt text of interior pages.

Once that issue is created we can close this issue.

I found a couple of images which doesn't have an alt text yet. added the related labels and submitted a PR.

I see there are still a lot of other A11Y issues in this repo. Would you like me to go ahead and fix them?

@devcer yes, I think making incremental issues for A11Y related work, then working off of them would be great.

I would like to work on this issue.

@Michael-Grover @irmerk Is this done?

Closing for now, as mentioned https://github.com/accordproject/techdocs/pull/221#issuecomment-551929461 @Alexandria can reopen with a new PR.


Add request-benchmark CL2 scenario

What type of PR is this?
/kind feature
What this PR does / why we need it:
Followup to https://github.com/kubernetes/perf-tests/pull/2156
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
In a single run the benchmark may create a number of config maps and perform GET/LIST operations on them.
/assign @mborsz
/assign @marseel

/lgtm
/approve


Raster API Info  does not return the info

Problem description
I have added the item from digital africa s2_l2a. It shows the boundary on the index.html but when it does not show the image on viewer page and raise the error {"detail":"'/vsis3/deafrica-sentinel-2/sentinel-s2-l2a-cogs/35/Q/RA/2017/1/S2A_35QRA_20170101_1_L2A/AOT.tif' does not exist in the file system, and is not recognized as a supported dataset name."}

Expected Output
It should return the image on the map

Environment Information
Ubuntu 22-04
Docker version 24.0.6
python 3.10.12
EoAPI release: 0.1.0 (TBD)

@Leon-Carto did you allowed deafrica-sentinel-2 bucket in you IAM role for the lambdas?
By default it's * but maybe you changed it https://github.com/developmentseed/eoAPI/blob/main/infrastructure/aws/cdk/config.py#L87-L91

aws s3 ls --region af-south-1 --no-sign-request s3://deafrica-sentinel-2/sentinel-s2-l2a-cogs/35/Q/RA/2017/1/S2A_35QRA_20170101_1_L2A/AOT.tif
2020-10-13 12:41:52     102737 AOT.tif

rio cogeo info s3://deafrica-sentinel-2/sentinel-s2-l2a-cogs/35/Q/RA/2017/1/S2A_35QRA_20170101_1_L2A/AOT.tif
...
rasterio.errors.RasterioIOError: The af-south-1 location constraint is incompatible for the region specific endpoint this request was sent to.

Oo That's interesting there might be something with GDAL/Rasterio or how the env variable are set in the service.
I guess the easiest way to fix this for now is to use https url instead of s3:// because the data is public

Oo
we have to set two env variable for this bucket in af-south-1
AWS_S3_ENDPOINT=s3.af-south-1.amazonaws.com
AWS_NO_SIGN_REQUEST=YES

AWS_S3_ENDPOINT=s3.af-south-1.amazonaws.com AWS_NO_SIGN_REQUEST=YES rio cogeo info s3://deafrica-sentinel-2/sentinel-s2-l2a-cogs/35/Q/RA/2017/1/S2A_35QRA_20170101_1_L2A/AOT.tif
Driver: GTiff
File: s3://deafrica-sentinel-2/sentinel-s2-l2a-cogs/35/Q/RA/2017/1/S2A_35QRA_20170101_1_L2A/AOT.tif
COG: True
Compression: DEFLATE
ColorSpace: None

Profile
    Width:            1830
    Height:           1830
    Bands:            1
    Tiled:            True
    Dtype:            uint16
    NoData:           0.0
    Alpha Band:       False
    Internal Mask:    False
    Interleave:       BAND
    ColorMap:         False
    ColorInterp:      ('gray',)
    Scales:           (1.0,)
    Offsets:          (0.0,)

Geo
    Crs:              EPSG:32635
    Origin:           (799980.0, 2100000.0)
    Resolution:       (60.0, -60.0)
    BoundingBox:      (799980.0, 1990200.0, 909780.0, 2100000.0)
    MinZoom:          8
    MaxZoom:          11

Image Metadata
    AREA_OR_POINT: Area
    OVR_RESAMPLING_ALG: MODE

Image Structure
    COMPRESSION: DEFLATE
    INTERLEAVE: BAND
    PREDICTOR: 2

Band 1
    ColorInterp: gray

IFD
    Id      Size           BlockSize     Decimation
    0       1830x1830      256x256       0
    1       915x915        128x128       2
    2       458x458        128x128       4
    3       229x229        128x128       8


ENG-508: save secrets in DB by default

are you sure you pushed everything?

Yes, the DB part was already done in #71.


OpenGD77 Support

Hey,
I'm using Baofeng DM-1801 with OpenGD77 (http://github.com/rogerclarkmelbourne/OpenGD77/) which is superb, but it's not being detected by dmrconfig (CPS utility for it looks similar on windows as original one.).

Hello,
I'm adding some details to help any developer who will tackle this issue.
The main difference between the stock firmware and OpenGD77 is the protocol used to transfer the CPS.
The stock fw uses probably a custom DFU variant, while OpenGD77 uses a text-based protocol
built on top of a USB virtual COM.
So the main issue would be to implement the virtual COM support, provided that no other radio
already has it. But on modern operating systems you directly get a serial tty, so it shoulndn't be hard.
The CPS layout should be quite identical, some bits which have undefined semantics in the
original fw have been assigned some behaviour in OpenGD77.

The OpenGD77 also supports 80 channel zones, but again, I don't think that its a big difference and would be easy to change in this code

After some hesitation between improving the python script for OpenGD77 and this, I've started work on this. Looks like the serial protocol for OpenGD77 differs significantly from the one already implemented in serial.c, but I'll just export dev_path and implement it in opengd77.c.
@rogerclarkmelbourne can you please point me to some code or docs which explain the format of the binary blobs, and what goes where? Not particularly well versed in C# ...

Thanks. Looks promising!
Gary, WB8LEA
On Mon, Jul 13, 2020, 12:33 AM Roger Clark<EMAIL_ADDRESS>wrote:

Did you post to the OpenGD77 forum. If so there were a load of replies to
your question
https://www.opengd77.com/viewtopic.php?f=12&t=959&start=10
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sergev/dmrconfig/issues/49#issuecomment-657352610,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACDG2FMYZJHFMK3LKMCTQI3R3KFA5ANCNFSM4MGJZUEA
.

Indeed, this was me on the forum and after some further consideration I've decided to go the python way. Speed and efficiency are not key here, a functioning CPS tool is. Also, this C code will need some rework in places to accommodate the new serial protocol.

OK

Thanks @kzyapkov ! Great to have that until support (hopefully) ends up in dmrconfig when someone has time.


test-branch/execute-job/wrong-comment-on-pr/4b9dbcfa-2a52-4c86-9c52-6b1ffb542a2e

PR for testing ba9a1bc7d999b64c3d3b6b2c216734e8afd3ab0d

comment 1


design system adaptation on CAWeb theme

Our goal is to modify CAWeb theme that would be:

running on design system css from combined-css component
no divi or State template styles
using design system JavaScript from same combined-css component (no jQuery or bootstrap)
Header and page section are using design system structure

WHY:

Making CAWeb theme look like design system will give editors consistent visual experience. (Sites will look the same in WP environment as they will look live)
We could leverage theme's CAWeb options where editors and administrators could control many aspects of the website, such as main navigation, footer navigation, statewide header and footer links, custom css and JS, logo, theme color, search settings, etc.

Progress:
Contacted with Danny from CAWeb Publishing, he suggested using The "core" branch in CAWeb theme repo as starting. Point. I was able to do initial PR here:  https://github.com/CA-CODE-Works/CAWeb/pull/676
In that PR i did following modifications to the core branch of the CAWeb theme:
UPDATE STYLES:
/assets/css/cagov/version5.5/colorscheme/
update styles from design system combined-css component

delta.css replace with drought.css
eureka.css replace with cannabis.css
oceanside.css replace with cagov.css

In each file remove @supports properties otherwise it will be gulp errors.
Move fonts parts of delta.css, eureka.css, and oceanside.css files into cagov.font-only.css file and make sure paths are starts with ../
Move all Public-sans fonts into /fonts/ folder as well as CAGov.woff2
In gulpfile.js find "sync function buildFrontEndStyles" function
comment out these lines:
// f = f.concat(config.frontendCSS); // f = f.concat( config.SCSSAssetDir + 'cagov/version' + ver + '/custom.scss' );
Run gulp frontend-css to generate updated cagov-v5.5-oceanside.css file (note only delta, eureka and oceanside themes will have ds colors)

DISABLE JQUERY
In functions.php add this code
/** * Completely Remove jQuery From WordPress Admin Dashboard */
add_action('wp_enqueue_scripts', 'no_more_jquery');
function no_more_jquery(){
wp_deregister_script('jquery');
}
ADD JAVASCRIPT:
Get index.js file from design system's combined-css component and replace /assets/js/cagov/version5.5/cagov.core.js
Remove code from /assets/js/cagov/version5.5/custom.js
Remove this "config.a11yJS" peice of code from async function buildCAWebJS in gulpfile.js
Remove all jQuery code from /assets/js/caweb/google.js
Run gulp cawed-js to generate updated cawed-v5.5.js file.
Update layout and structure
Update header.php structure to go inline with design system.
Update utility header structure to reflect design system (remove utility icons section and settings button)
Add d-none class to the settings.php section
Update branding.php to reflect design system branding component (remove mobile-controls.php from header) and add similar section to the branding. Add php package lines from search-form.php and mobile-controls.php
Update search form structure
Update navigation inside of header.php
Update navigation structure class-cawed-nav-menu.php inside of /inc folder
Need to work on:
Navigation sub navigation is not set up yet.
JavaScript (not opening nav menu in mobile)
When footer menu is activated it's breaking the page (need to finish up with footer layout)
Screenshot

Closing this one while cleaning up some boards now that we are starting to get the rest of this backlog cleared.


Update to reflect ability to pull NPSP data schema

The purpose of this change is to call out the ability of this connector to pull many different data schemas in Salesforce, specifically the nonprofit success pack.  We have worked with both Salesforce and the Azure Data Factory team to validate this data pull success for this schema.  Calling out this ability is critical for the MS Tech for Social Impact Sales team.

@elucht : Thanks for your contribution! The author(s) have been notified to review your proposed change.


New version: Jackett.Jackett version 0.20.2870

Pull request has been automatically created using 🛫 WinGet Releaser.
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Implement licensing

Summary of the changes / Why this improves CrateDB
Implement license support for CrateDB. Main features:

trial licenses of 30 days are auto-generated if no license is already registered
enterprise licenses can be registered to the cluster using the new set license 'license-key' statement
multiple user notifications for when license is about to expire/expired
current license information is exposed in the sys.cluster.license field
Upon expiration: all statements are blocked / exceptions: set license statements and read-only system queries
Also
setting: 'license.ident' becomes @deprecated

Checklist

[x] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed

@andreidan done suggestion and squashed commits

@mfussenegger @andreidan please check once more


Remaining bitnodes.io to bitnodes.21.co

As a new user it confused be that there were mentions to bitnodes.io for the image although that site seemed completely unrelated.

D'oh! Good catch, thanks for submitting the PR :)


Remove mathjs dependency

GitHub warning about mathjs < 3.17.0 having a high severity security
vulnerability. Since we don't really need to import this library,
removing it instead.
Note: progress.js is legacy code that is not being imported into the
project right now.

🚢


Set up missing MAIN_BRANCH env variable in CI

Signed-off-by: Patrik Stas<EMAIL_ADDRESS>

Codecov Report

Merging #638 (a34819a) into main (0e5a2a8) will decrease coverage by 16.57%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #638       +/-   ##
===========================================
- Coverage   64.30%   47.72%   -16.58%
===========================================
  Files         213      213
  Lines       20040    14897     -5143
  Branches     4547     2899     -1648
===========================================
- Hits        12886     7110     -5776
- Misses       3771     5593     +1822
+ Partials     3383     2194     -1189

Flag
Coverage Δ

unittests-aries-vcx
47.72% <ø> (-16.39%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


bump trl and accelerate for latest releases

kto_pair was removed upstream in trl https://github.com/huggingface/trl/pull/1734/files


feature: aggresive deps cache

:clipboard: Add associated issues, tickets, docs URL here.
Overview
Describe what your Pull Request is about in a few sentences.
Changes
Describe your changes and implementation choices. More details make PRs easier to review.

Change 1
Change 2
...

Testing
Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

Coverage remained the same at ?% when pulling beb08a61aa67791c79cda24b9803e0d690815837 on aggresive_deps_cache into aabead0347053f174c46b7e4c423e730e243e3fe on master.


PX4 firmware hex / binary file

Hi,
I am trying to design a new version of Pixhawk-based board (for which I am thinking of using your baseboard design) for a project, to add jetson nano instead of raspberry pi, and in my design, I am not sure how you have managed to to provide direct bootloader access to only the pixhawk, so have you already compiled a hex or binary for just PX4, so that atleast I can upload it on JTAG, thanks!

Follow-up question, do I have to download a bootloader specific to H7 MCU, and how did you guys compile it? It would be great if we could collaborate on this project together


Fix bazel dependency

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.fl237079 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


meta-dts-distro/recipes-dts/dts/dts.bb: replace coreboot customizer

Tested in QEMU that the utility can be started:
bash-5.1# dcu -h
dcu - Dasharo Configuration Utility

Usage:
  dcu COMMAND
  dcu [COMMAND] --help | -h
  dcu --version | -v

Commands:
  smbios   Edit SMBIOS data in a firmware image
  logo     Insert custom logo boot splash into firmware image

Options:
  --help, -h
    Show this help

  --version, -v
    Show version number

Examples:
  dcu smbios coreboot.rom -u 96bcfa1a-42b4-6717-a44c-d8bbc18cbea4 -s D07229051
  dcu logo coreboot.rom -l bootsplash.bmp

bash-5.1# ls

should we release new version of DTS with this utility? If yes, please bump distro version and leave entry in changelog.

DCU is not really something we need, but we have introduced a couple of more important fixes already on this integration branch: https://github.com/Dasharo/meta-dts/tree/novacustom-hotfixes
The release should happen when we have 1.5.2/1.7.2 versions available for the public release - hopefully sometime next week.


Per user notification settings

We would like the ability to change the notification settings. It is not necessary for all of our admins to receive all notifications from PEAKS. For example, our CAO has access to all permissions. Yet the don't need to know each time when items expire for someone.

Votes: 4
Author: jjvidaca
Voters: jjvidaca,swells,mceligot,szkerner

Agreed.  A "silent" option would be very helpful when an acknowledgement is not needed by an employee.
Author: swells

Agreed, notification settings would be helpful.
Author: mceligot

We would also like to edit the notification so we can change who is listed as contacts.
Author: szkerner

We would also like to edit the notification so we can change who is listed as contacts.
Author: szkerner


Fixing yt volume rendering script in docs

This updates the script in the docs to make a volume rendering with yt to be compatible with current API.
NOTE: This does not fix Issue 193, that is a bug on the yt side that is fixed here, which will be merged into yt today (hopefully) and be included in the next stable release (3.2).

I don't know what's causing the python3 failures and I can't reproduce them locally, so I might ignore them...

Do the example scripts in the docs get run as tests?

...good question.  Even if they do, though, your changes shouldn't have affected py3.
And after restarting the tests, they don't.  I don't know what went wrong, but it was ephemeral.


overnight tests are failing: "Sandbox.run() has been disabled"

See original issue on GitLab
In GitLab by [Gitlab user @jjardon] on Nov 21, 2019, 12:58
Job #356665659 failed for 8ae2f7da6ac3356a7054531a587cd2bfecb62301:

In GitLab by [Gitlab user @tristanvb] on Nov 5, 2020, 12:08
This appears to be an incident which has been solved for a while now.

In GitLab by [Gitlab user @tristanvb] on Nov 5, 2020, 12:08
This appears to be an incident which has been solved for a while now.


Add Anchor Tags to List Items for Direct Link

note: depends on how blazor ui will handle the anchor after the async data load

Implementing a url with filter value rather than anchor tag


Notifications on Android PWA mode does not open a link Padé

Another finding on android,
When a notification is received on android, it does not open Padé or related conversation. No link

Can you please try and install on desktop and see it you get the same issue. Thanks

Apparently same issue on PC with chrome and extension, does not open link to conversations. On android notifications works fine even with app shut down :) and that's super cool !!!
except it does not open link to app and converstation. That's what i noticed

On PC, app is opened and comes to foreground. On Android, app is opened, but stays in background. Not sure why it does not come to foreground. I will have to investigate further.
There is also an issue with opening the exact conversation that created the notification. That is also not working. For now, use the badge icon in the active conversation view to see all unread messages count.


[release-v0.36.x] de-dupe order and resource dependencies

Changes
This is a manual cherry-pick of https://github.com/tektoncd/pipeline/pull/5446.
In case of a pipeline with a huge list of redundant dependencies, the list is growing exponentially. This way of calculating the list of dependencies is causing extra delay in the validation cycle. This delay sometimes hit the webhook timeout during validation. This is one of the changes being proposed to make the validation cycle efficient and avoid unneccesary delay.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
De-dupe task dependencies - order and resource dependencies all together. It's very common to have a task with multiple when expressions referring to the same task but different results. Maintain a set of dependencies and add only a new parent.

Build failed with: 🤔
================================
==== YAML LINT TESTS PASSED ====
================================
Error: error creating publisher: KO_DOCKER_REPO environment variable is unset
2022/09/12 18:39:49 error during command execution:error creating publisher: KO_DOCKER_REPO environment variable is unset
=================

/retest

/lgtm

/approve


"Incorrect password" notification for private blogs

I have just noticed that if one were to type in a password incorrectly on a private blog then the notification shows in the bottom left, totally away from the main content. This isn't really a bug but I feel it would be more user friendly to potentially show it above the field or something, just so that it isn't confusing for any one who doesn't spot it way in the bottom left there.

@surdaft Thanks! Actually though, this is a bug with Ghost itself, using the default private.hbs template.
If you like, could you re-open another issue on that repo?

Ohh, sorry I didn't notice that, alright will do. Thanks for that @acburdine :)


Remove the redundant setting.

config.action_mailer.raise_delivery_errors will be false by default.
And it will cause some confusion to users
as there have the comment # config.action_mailer.raise_delivery_errors = false above it.

Thanks @monaka this makes sense


BI-2132 - Create new experiment workflow

Description
Story: BI-2132

Workflow selection code (BI-2122) will be shown as changes in here until it is merged into develop

Review should focus on stuff from CreateNewExperimentWorkflow process down
However, there were a few changes from BI-2122 to pass exceptions up

Updated experiment import integration tests

Only updated tests that were related to creating experiments or environments
Tests that were updating based on obsunitid were not changed

Checked for ExperimentProcessor work done after refactor branched off develop

BI-2128, added change
BI-2065, BI-1993, BI-2104 were already in develop prior to refactor being branched off

Workflow organization

Code common to the create and append/update workflows that depended on DAOs was broken out into Experiment services
A number of steps were defined in the create workflow package that correspond to the main steps in the experiment processor code. The main goal was just to remove use of member variables and explicitly pass data between methods for everything other than referenced services, daos, or properties.

Dependencies

bi-web feature/BI-2121

Testing
Given I have navigated to the Experiment Import page
And I have selected the Create New Experiment option from the Workflows select box
And I have an experiment import file with values in the ObsUnitID column
When I click Upload
Then I should see an error notification Error detected in file: <filename>. ObsUnitIDs are detected. Import cannot proceed

Regression testing ideas:
Verify that appending a new environment to an experiment using the create new experiment workflow works

Verify that status updates on the jobs page work

Test different import file error conditions and verify they still occur as before

Checklist:

[x] I have performed a self-review of my own code
[x] I have tested my code and ensured it meets the acceptance criteria of the story
[ ] I have tested that my code works with both the brapi-java-server and BreedBase
[x] I have create/modified unit tests to cover this change
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to documentation
[ ] I have run TAF: <please include a link to TAF run>

TraitControllerIntegrationTest tests are failing with null program cache, seems like something is messed up with DI. Application stuff related to traits seems to work fine...