[Flutter Platform Views]Camera feed not shown in iOS with DataScannerViewController

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I've use Flutter Plaltform View to embed Native iOS view into Flutter. Native iOS view is associated with DataScannerViewController which come along with Vision Kit. But when starting the flutter app, the view is white.
But I ran the same code in native iOS. It worked fine. My Code work is as bellow. is there anyway to over come this issue?
https://github.com/Hashan1599/matrixQR
Code

@override
  Widget build(BuildContext context) {
    return MaterialApp(
        title: 'Flutter Demo',
        theme: ThemeData(
          colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
          useMaterial3: true,
        ),
        home: const UiKitView(viewType: 'ARViewContainer'));
  }

//Code in Swift

//App Delegate
@UIApplicationMain
  @objc class AppDelegate: FlutterAppDelegate {
    override func application(
      _ application: UIApplication,
      didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
    ) -> Bool {
        GeneratedPluginRegistrant.register(with: self)
        weak var registrar = self.registrar(forPlugin: "my-views")
        let cealQrViewfactory = ARViewContainerNativeViewFactory(messenger: registrar!.messenger())
        let viewRegistrar = self.registrar(forPlugin: "<my-views>")!
        viewRegistrar.register (cealQrViewfactory,
        withId: "ARViewContainer")
      return super.application(application, didFinishLaunchingWithOptions: launchOptions)
    }
  }

  import UIKit
  import VisionKit
  import AVKit

  class ARViewContainerNativeViewFactory: NSObject, FlutterPlatformViewFactory {
      private var messenger: FlutterBinaryMessenger

      init (messenger: FlutterBinaryMessenger){
          self.messenger = messenger
          super.init ()
      }

      public func createArgsCodec() -> FlutterMessageCodec & NSObjectProtocol {
          return FlutterStandardMessageCodec.sharedInstance()
      }

      func create( withFrame frame: CGRect, viewIdentifier viewId: Int64,
                   arguments args: Any?) -> FlutterPlatformView{
          return ARViewContainerNativeView(frame: frame, viewIdentifier: viewId, arguments: args, binaryMessenger: messenger)
      }

  }

  class ARViewContainerNativeView: NSObject, FlutterPlatformView {
      private var _view: UIView
      let channel: FlutterMethodChannel

      init( frame: CGRect, viewIdentifier viewId: Int64, arguments args: Any?,
            binaryMessenger messenger: FlutterBinaryMessenger?
      ) {
          let argumentsDictionary = (args as? Dictionary<String, Any>) ?? [:]
          _view = UIView()
          channel = FlutterMethodChannel(name: "ARContainerView/\(viewId)", binaryMessenger: messenger!)

          super.init ()
          createNativeView(view: _view, productList: argumentsDictionary)
      }

      func view() -> UIView {
          return _view
      }

      func createNativeView(view _view: UIView, productList :Dictionary<String, Any>) {
          let vc = UIStoryboard(name: "MatrixBarcodeStory", bundle: nil).instantiateViewController(withIdentifier: "MatrixBarcodeVC") as! MatrixBarcodeVC
          vc.view.frame = _view.bounds
          _view.addSubview(vc.view)
      }

      public func sendFromNative(_ text: String) {
        channel.invokeMethod("sendFromNative", arguments: text)
      }
  }

  class MatrixBarcodeVC: UIViewController, DataScannerViewControllerDelegate {

      let dataScannerVC = DataScannerViewController(
          recognizedDataTypes: [.barcode()],
          qualityLevel: .balanced,
          recognizesMultipleItems: true,
          isGuidanceEnabled: true,
          isHighlightingEnabled: false
      )

      private var isScannerAvailable: Bool {
          DataScannerViewController.isAvailable && DataScannerViewController.isSupported
      }

      var itemHighlightViews: [RecognizedItem.ID: UIView] = [:]

      override func viewDidLoad() {
          super.viewDidLoad()
          dataScannerVC.delegate = self
          dataScannerVC.view.frame = self.view.bounds
          self.view.addSubview(dataScannerVC.view)
          try? self.dataScannerVC.startScanning()
      }
  }

  //DataScannerViewControllerDelegate
  extension MatrixBarcodeVC{

      func dataScanner(_ dataScanner: DataScannerViewController, didAdd addedItems: [RecognizedItem], allItems: [RecognizedItem]) {
          for item in addedItems {
              switch item {
              case .barcode(_):
                  let newView = newHighlightView(item: item)
                  itemHighlightViews[item.id] = newView
                  dataScanner.overlayContainerView.addSubview(newView)
                  print("item \(item)")
              default:
                  break
              }
          }
      }

      func dataScanner(_ dataScanner: DataScannerViewController, didUpdate updatedItems: [RecognizedItem], allItems: [RecognizedItem]) {
          for item in updatedItems {
              if let view = itemHighlightViews[item.id] {
                  updateHighlightView(item: item, view: view)
              }
          }
      }

      func dataScanner(_ dataScanner: DataScannerViewController, didRemove removedItems: [RecognizedItem], allItems: [RecognizedItem]) {
          for item in removedItems {
              if let view = itemHighlightViews[item.id] {
                  itemHighlightViews.removeValue(forKey: item.id)
                  view.removeFromSuperview()
                  print("didRemovedItems \(removedItems)")
              }
          }
      }

      func updateHighlightView(item:RecognizedItem, view:UIView){
          var rect = CGRect(origin: item.bounds.bottomLeft,
                            size: CGSize(width: item.bounds.topRight.x - item.bounds.topLeft.x,
                                         height: item.bounds.topRight.y - item.bounds.bottomRight.y))
          view.frame = rect
      }

      func dataScanner(_ dataScanner: DataScannerViewController, didTapOn item: RecognizedItem) {
          print("didTapOn \(item)")
      }

      func dataScanner(_ dataScanner: DataScannerViewController, becameUnavailableWithError error: DataScannerViewController.ScanningUnavailable){
          print("became unavailable with error \(error.localizedDescription)")
      }

  }

  //MARK: Helping Methods
  extension MatrixBarcodeVC{

      func newHighlightView(item:RecognizedItem) -> UIView{
          print("height :: \(item.bounds.topRight.y - item.bounds.bottomRight.y)")
          switch item {
          case .barcode(let barcode):
              print(barcode.payloadStringValue)
          default:
              break
          }
          return UIView()
      }
  }

Logs

Logs

<!-- Paste your logs here -->

Flutter Doctor output
Details

[✓] Flutter (Channel beta, 3.16.0-0.3.pre, on macOS 12.6.2 21G320 darwin-x64, locale en-US)
    • Flutter version 3.16.0-0.3.pre on channel beta at /Users/hashank/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 476aa717cd (4 days ago), 2023-10-19 20:10:52 -0500
    • Engine revision 91cde06da0
    • Dart version 3.2.0 (build 3.2.0-210.3.beta)
    • DevTools version 2.28.1

[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
    • Android SDK at /Users/hashank/Library/Android/sdk
    • Platform android-33, build-tools 32.0.0-rc1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode14.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Ultimate Edition (version 2019.1)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.83.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.74.0

[✓] Connected device (3 available)
    • H’s iPad (mobile) • 00008020-000E683A0A81402E • ios            • iOS 16.3.1 20D67
    • macOS (desktop)        • macos                     • darwin-x64     • macOS 12.6.2 21G320 darwin-x64
    • Chrome (web)           • chrome                    • web-javascript • Google Chrome 118.0.5993.88

[✓] Network resources
    • All expected network resources are available.

Hi @Hashan1599. Thanks for filing this. Can you please share a sample repo that could be ran directly to reproduce this issue, using the code snippets shared, I seem to be running into other issues which could be as a result of missing out on some information attached to your comment.
Thank you!

Hi @Hashan1599. Thanks for filing this. Can you please share a sample repo that could be ran directly to reproduce this issue, using the code snippets shared, I seem to be running into other issues which could be as a result of missing out on some information attached to your comment.
Thank you!

repo:
https://github.com/Hashan1599/matrixQR

Thanks for this. I can reproduce this issue on the latest master and stable channels. Not too certain but this might be an implementation issue. Labelling for more insights.
Thank you!
flutter doctor -v

[✓] Flutter (Channel stable, 3.13.8, on macOS 14.0 23A344 darwin-arm64, locale
    en-NG)
    • Flutter version 3.13.8 on channel stable at
      /Users/damilolaalimi/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6c4930c4ac (7 days ago), 2023-10-18 10:57:55 -0500
    • Engine revision 767d8c75e8
    • Dart version 3.1.4
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)

[!] Android Studio (version unknown)
    • Android Studio at /Users/damilolaalimi/Downloads/Android Studio
      Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build
      17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.83.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] VS Code (version 1.83.1)
    • VS Code at /Users/damilolaalimi/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (3 available)
    • iPhone 15 Pro Max (mobile) • 56A225C9-B8F6-4201-A0AE-8C3CFA4CE152 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-17-0 (simulator)
    • macOS (desktop)            • macos                                •
      darwin-arm64   • macOS 14.0 23A344 darwin-arm64
    • Chrome (web)               • chrome                               •
      web-javascript • Google Chrome 118.0.5993.117

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[✓] Flutter (Channel stable, 3.13.8, on macOS 14.0 23A344 darwin-arm64, locale en-NG)
    • Flutter version 3.13.8 on channel stable at /Users/damilolaalimi/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 6c4930c4ac (7 days ago), 2023-10-18 10:57:55 -0500
    • Engine revision 767d8c75e8
    • Dart version 3.1.4
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[!] Android Studio (version unknown)
    • Android Studio at /Users/damilolaalimi/Downloads/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.83.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] VS Code (version 1.83.1)
    • VS Code at /Users/damilolaalimi/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.50.0

[✓] Connected device (3 available)
    • iPhone 15 Pro Max (mobile) • 56A225C9-B8F6-4201-A0AE-8C3CFA4CE152 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-17-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-arm64   • macOS 14.0 23A344
      darwin-arm64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome
      118.0.5993.117

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

do this:

@yiiim, This works!! Thank you very much

@yiiim , This works!! Thank you very much


remove bower and component support

Do you still intend on supporting browser usage?

I've opted to build an ES5 version in nes and hawk. I'm conflicted about this but it seems like an easy enough thing to do for now as we figure out this transition period.

OK, any particular motivation? the browserfied distro is 14k, a pleasant browser consumable module. ES3 browsers are dead, so no need to worry about them.

Soon I'll be releasing a v6.x that restores ES5 compatibility. After that, v7.0.0 will remove bower/component support completely. As soon as possible, I will restore ES3 compatibility - not only are those engines not "dead" but it's not actually that difficult to support them, so I'll be doing so.


Quota trigger re-creation not done correctly when promoting user to org

See SB/5253608
I tried this on the console:
> u = User[username: 'someusername']
> u.rebuild_quota_trigger
Setting user quota in db 'cartodb_user_someuuid_db' (someusername)
NOTICE:  function public._cdb_userquotainbytes() does not exist, skipping
=> nil

but still the table gives problems of type Missing "public"._CDB_UserQuotaInBytes()
I think the problem is that the table was in public schema then moved to someorg schema but its triggers still reference public. I don't know how special this case might be.

I fixed this particular case by regenerating the triggers:
SELECT CDB_CartodbfyTable('orgschema', 'orgschema.broken_table_name');

This workaround has been enough in my case:
SELECT cartodb._CDB_drop_triggers('brokentable'::REGCLASS);
SELECT cartodb._CDB_create_triggers('schema'::TEXT, 'brokentable'::REGCLASS);


fix: update only for values are present

Codecov Report

Merging #5 into master will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   45.10%   45.00%   -0.11%
==========================================
  Files          35       35
  Lines         838      840       +2
==========================================
  Hits          378      378
- Misses        460      462       +2

Impacted Files
Coverage Δ

app/services/update_claim_event_info_service.rb
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033afe3...467a974. Read the comment docs.


[TextInput] onBlur not triggered when multiline is true

Hi guys,
I have two TextInput with onBlur property. and I'm switching between them.
The input with multiline={true} does not trigger onBlur event.
<TextInput
  style={styles.input}
  onBlur={() => console.log('onBlur - name')}
  placeholder="Your Name" />
<TextInput
  style={styles.about}
  multiline={true}
  onBlur={() => console.log('onBlur - about')}
  placeholder="Write a little bit about you..." />

Tested on RN v0.11.0
Thanks,
Ran.

I'm having the same issue.

This still seems to be an issue in v0.13. Any idea when this will be fixed?

@davidsims9t Just tested this on 0.14.2 and is working fine.


cherry-pick: use OpenResty's API for mtls (#99)

Summary
Cherry-picks:

Added support for https_sni in healthcheck.lua (https://github.com/Kong/lua-resty-healthcheck/pull/49[)](https://github.com/Kong/lua-resty-healthcheck/commit/c8c6bb67803a3f36de13b486daea94072efcdd38)
fix(mtls) use OpenResty's API for mtls (https://github.com/Kong/lua-resty-healthcheck/pull/99[)](https://github.com/Kong/lua-resty-healthcheck/commit/44b68d5893facde6c5232147cc1fc32f8430ec15)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: ADD-SP:x: HansK-pYou have signed the CLA already but the status is still pending? Let us recheck it.


WIP: ADCSAdministration PowerShell reference update

1871153
One new cmdlet. Other changes are Input and Output.

Docs Build status updates of commit c84bd73:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/adcsadministration/ADCSAdministration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CAAuthorityInformationAccess.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CACrlDistributionPoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CATemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Backup-CARoleService.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Confirm-CAAttestationIdentityKeyInfo.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Confirm-CAEndorsementKeyInfo.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CAAuthorityInformationAccess.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CACrlDistributionPoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CATemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Restore-CARoleService.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 611ce2f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/adcsadministration/ADCSAdministration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CAAuthorityInformationAccess.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CACrlDistributionPoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CATemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Backup-CARoleService.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Confirm-CAAttestationIdentityKeyInfo.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Confirm-CAEndorsementKeyInfo.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CAAuthorityInformationAccess.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CACrlDistributionPoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CATemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Restore-CARoleService.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit d290a25:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/adcsadministration/ADCSAdministration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CAAuthorityInformationAccess.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CACrlDistributionPoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CATemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Backup-CARoleService.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Confirm-CAAttestationIdentityKeyInfo.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Confirm-CAEndorsementKeyInfo.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CAAuthorityInformationAccess.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CACrlDistributionPoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CATemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Restore-CARoleService.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Hi @tiburd - I got SME approval for this one. Ready for review.

@tiburd It looks like we have three approvals and are ready for merge.

Docs Build status updates of commit f83e85b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/adcsadministration/ADCSAdministration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CAAuthorityInformationAccess.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CACrlDistributionPoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Add-CATemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Backup-CARoleService.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Confirm-CAAttestationIdentityKeyInfo.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Confirm-CAEndorsementKeyInfo.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CAAuthorityInformationAccess.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CACrlDistributionPoint.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Remove-CATemplate.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/adcsadministration/Restore-CARoleService.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Select: Meta/Alt/Control keys used as filter

When a Select menu is open/active, you can type x to jump to the first x___ items in the list. This is great.
However, if you press CMD (and presumably Control), it jumps to the first Meta___ item in the list.
This is because ev.key === "Meta" and there's likely a filter somewhere in Bits/Melt that is using that value.
This also happens with Alt (verified) and Control keys.
Solution is to ignore the event if ev.metaKey, ev.altKey or ev.ctrlKey are true.

Hey @lukeed, nice catch! That's on the Melt side and I'll take care of it now!

Closed by melt PR, thanks :)


First version. Still much to doo

Signed-off-by: David Riosalido<EMAIL_ADDRESS>

Sorry, wrong remote where to push...


[BUG] - unable to run claude models in us-west-2

Describe the bug
Filling out this field will help us investigate the issue efficiently. Providing detailed information allows us to set the appropriate priority. We appreciate your cooperation.
A clear and concise description of what the bug is.
To Reproduce

setting AWS_DEFAULT_REGION=us-east-2
closing repo
running ./bin.sh

Then I was unable to access any model - and would see the following

I have access to all the models in the us-east-2 region:

the model id does seem like the same model id:

I see the following two log messsages in the cloudwatch logs for the Websocket Lambda:

This is the message in the browser on the client side of the WSS call:
"{\"conversationId\":\"01HWKDG43PGTFQNRP1Y9WK45TM\",\"message\":{\"content\":[{\"body\":\"test\",\"contentType\":\"text\"}],\"model\":\"claude-v3-opus\",\"role\":\"user\",\"feedback\":null,\"parentMessageId\":\"system\"},\"token\":\"eyJraWQiOiJzY2k0aWMxUXZEVTEwU2lUM2gyRnNUZ1dBTVM5ZlNsVFErK0g3cUlcL21GND0iLCJhbGciOiJSUzI1NiJ9.eyJzdWIiOiI3OGIxMjNmMC1lMDkxLTcwNTAtZTIxOC01OWRhNTMzZWFhZmUiLCJjb2duaXRvOmdyb3VwcyI6WyJBZG1pbiIsIlB1Ymxpc2hBbGxvd2VkIl0sImVtYWlsX3ZlcmlmaWVkIjp0cnVlLCJpc3MiOiJodHRwczpcL1wvY29nbml0by1pZHAudXMtd2VzdC0yLmFtYXpvbmF3cy5jb21cL3VzLXdlc3QtMl9DbzcxbUpzSXAiLCJjb2duaXRvOnVzZXJuYW1lIjoiNzhiMTIzZjAtZTA5MS03MDUwLWUyMTgtNTlkYTUzM2VhYWZlIiwib3JpZ2luX2p0aSI6ImYwNGM2ZmYwLTY5YTItNGQxOC1hMDdmLTIwYmQ2MjlkYTExNyIsImF1ZCI6IjZwaDZ0Z3RrZjQ1a3I5Mm0xOG85dHNxbGwiLCJldmVudF9pZCI6ImUzOGVjNDZkLWE5MTUtNDA5YS04YmRkLTZiNTViNjc4ODQ1YyIsInRva2VuX3VzZSI6ImlkIiwiYXV0aF90aW1lIjoxNzE0MjA0MzEwLCJleHAiOjE3MTQ0MjkzODQsImlhdCI6MTcxNDM0Mjk4NCwianRpIjoiMDQzOWI3NGEtNDEyMS00ZWZjLThhY2YtZTk4ZmM1MTljNGY2IiwiZW1haWwiOiJ0aG9ybmlicm9va0BzZWVrLmNvbS5hdSJ9.BPwjF8w8M0PAAnZa-wg0SVAaXWM1RcPuznv4gbzy6AA-OAoFb14X-i27vYiKaLdkzRzBAb2KTCIs1h50BBirz5bbR41q_cikjBw5tpReaj78XyvVhwvDVWd7DiwjwbPYx_vWw-qTiC8vmKXvTWDRq86WYduJO9ny6oyyHUqbkaIeNJqT2VQ7Yitflw___FoTQIaqvH27hj17HJjUCXuLn_MljeEHgUaYP7x7tbfisQt5DGxa35PQ66fvvSHlirDlHOGtWFw2DdbG07L1l0XcfDZAVlM9_PYv0ppiuNpUGXT6Q5t0axx4Jc354OBUWKgNS5txyELOAfRr2HH_MTZwdw\"}"

Additional context
Add any other context about the problem here.

Could you please let me know Sonnet / Haiku are available?

Hello, I have the exact same error as tnh, and to confirm, I also have Haiku and Sonnet enabled, these are working fine in the Chat, Opus is not and is showing the same error as above, if you require any further context, please let me know

Have both of you modified bedrockRegion?
ref: https://github.com/aws-samples/bedrock-claude-chat#deploy-using-cdk

Yes, Claude 3 Opus is only available in Oregon hence bedrockRegion is set to us-west-2 in cdk.json, I also tried again and replaced any instance of us-east-1 to us-west-2 and still have this error. Also tried in multiple AWS accounts just in case


Cleaned up shell.nix by removing bash commands and replacing them with just recipes

The just recipes added are used for setting up Cosmonic and its dependencies. An additional directory "scripts" has been added for scripts used by just but that have been separated for better readability.

Ready for merging!


Add some docker clean up

Move Dockerfiles to a subdirectory and pin the versions of Keras and TensorFlow to the version in lab41/nbserver.

Codecov Report

Merging #80 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   87.86%   87.86%
=======================================
  Files          29       29
  Lines        1615     1615
  Branches      214      214
=======================================
  Hits         1419     1419
  Misses        171      171
  Partials       25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e318cd...68f5a78. Read the comment docs.


db.Model constructor and password method

I noticed in Chapter 8 after the following added to class User
@property
def password(self):
    raise AttributeError('password is not a readable attribute')

@password.setter
def password(self, password):
    self.password_hash = generate_password_hash(password)

the following in the shell can be done
>>> u = User(username = 'susan', password = 'cat')
How the constructor recognize keyword password? By doing so it invokes the setter password(). Or property decorator alone makes this happen? Thanks in advance. I'm stuck.

Yes, it works automatically, because password is defined as a property with a setter method.

But I failed to reproduce this behavior by making a toy class of my own. So I wonder if this also has something to do with an appropriate init(). To be specific
c = Toy(foo='cat')
doesn't work but
c = Toy()
c.foo = 'cat'

works as expected.

Is Toy a subclass of db.Model? The Model class from SQLAlchemy is the one that provides the logic to initialize the object from constructor arguments.

No and thanks for pointing that out.

Whats the difference in having say def custom_method() in a .py file and importing them versus in a db.Model i.e. User.custom_method()? For example generate_confirmation_token or a similar custom method.

@simanacci then it wouldn't be a method, it would be a function, right? The difference is that the way I do it uses object-oriented programming, your solution is based on functions. You can make things work either way, if you prefer functions, then you should use functions.


All-purpose Media widget

It's a rather minor request, and totally up for discussion, however I feel that Flutter would benefit from having a generic Media widget, alongside Image and VideoPlayerController.
Back in the days, when glittering GIFs ruled the world, if a website hosted images it hosted images, when it hosted videos – it hosted videos. Nowadays the lines are blurring, and Webm is slowly but surely pushing GIF out of the picture. Thus, websites that used to host files like PNG, JPG and GIF (all possible to be displayed through Image widget), also host MP4 and WEBM files now (both possible to be displayed through VideoPlayerController), and sometimes even MP3 and other media formats.
Thus, if I wanted to grab, say, 50 newest files files from Imgur, half of them or so would be Webm. And that makes it impossible to display them all in a grid of Image widgets. Of course I could go through each and every one of them, check what's the file extension, compare it to my list of image extensions, list of sound extensions, list of video extensions, and create a widget based on that, so a PNG file will be displayed in Image, and Webm will be displayed in VideoPlayerController.
Question is: should that be the case? Shouldn't an all-purpose Media widget take care of that?
Another possibility would be an inline Chrome window, but it doesn't give full control over how is the media being displayed, and I don't think that a grid of 200 or so Chrome windows is a particularly good idea.
Thoughts? Opinions? Already exisitng solutions?

Hope nobody minds a bunp after those seven months.


Usage documentation for Kitura-redis

Closing this due to the vagueness of the issue. Depending on this issue's scope, the usage section in Kitura-redis' README could already satisfy this. If we want additional documentation, we should open another issue.


Line length and threshold in the MaxLineLength message

Expected Behavior of the rule
I think the MaxLineLength message should contain line length and threshold, as it is done in other metrics.
Now the message looks like this: "Line detected that is longer than the defined maximum line length in the code style".
But it could look something like this: "Line detected that is longer than the defined maximum line length in the code style (146/120)".
Context
I'm working on a tool that analyzes student code. We need code metrics, in particular line lengths that exceed a threshold.

This is a quality-of-life improvement to me. We actually have two rules with regards to the maxlinelength rule:

The first one is Detekt native rule (https://github.com/detekt/detekt/blob/main/detekt-rules-style/src/main/kotlin/io/gitlab/arturbosch/detekt/rules/style/MaxLineLength.kt), where you pointed out that we are missing the information on the stats.
The second one is Ktlint rule (https://github.com/pinterest/ktlint/blob/master/ktlint-ruleset-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/MaxLineLengthRule.kt) where it does seem to provide some statistics info in the error message.

You are always welcome to contribute to the Detekt native rule. On the other hand, feel free to try out detekt-formatting according to the doc to see if the second approach meets your need.

@chao2zhang Thank you! Unfortunately, Ktlint rule only shows the threshold, but not the line length. :pensive:

If ktlint doesn't do that you can report it to ktlint. Or, if you have the time, create a PR there.

Closing because this issue is not fixable by detekt.


Broken since latest version (3127)

material_theme_accent_xxx doesn't work anymore, you can't change the colour
no more file icons

should be default material theme colour and icons viewable

Thanks for the report, I'll look into it.

Same problem here

Okay, so Build 3127 had a lot of UI changes that might have triggered this to happen.
This seemed to fix the issue for me:

Switch to some other non-Materialize theme
Switch back to the Materialize theme
Restart Sublime (If not fixed already)

This seemed to revert the theme back to its normal state. Can you guys try it and let me know if it works?

It seems that they roll back: https://www.sublimetext.com/3
I brew cask uninstall sublime-text-dev and brew cask install it and when I click on "update", there's no update.
3127 isn't available anymore apparently. So I can't try.

You can find it via https://download.sublimetext.com/Sublime Text Build 3127.dmg but there's also https://download.sublimetext.com/Sublime Text Build 3128.dmg apparently.

I'll be back on this issue when homebrew will update sublime-text-dev. As I reinstalled it via brew cask, it installed 3126 (so stable version) and I don't have any update for the moment.
I'm too lazy to update sublime-text-dev cask task to put the latest version, and I don't want to install it manually. So when I'll be back on dev channel, i'll come back here to say if it works or not. Thanks for your comprehension :D

Np, just let me know whenever.

Thank you very much for your answer, your time, and your excellent sublime text theme. ;)
By the way, there's a new new update: https://www.sublimetext.com/3dev 3128

It often takes more time to explain than doing it: https://github.com/caskroom/homebrew-versions/pull/3620

Same here, the accent color preference is ignored but I do get file icons. Changing to a non material theme and back does not fix the problem.

Hmm, accents + file icons seem to be fine for me on Build 3128. Let me detail my exact steps in case there was some nuance in what I did that may have fixed it:

In Command Palette, type UI: Select Theme and then I switched to Material Theme (not Materialize, this is the original Material Theme)

Do UI: Select Theme again and switch back to a Materialize theme (Material Spacegray for example).

Restart Sublime

Check that file icons are working and adding something like material_theme_accent_red: true works.

@lucsky If following the above steps didn't fix it for you, would you mind providing the following info:

Are you on build 3127 or 3128?
Are you using the Materialize-White-Panels or Materialize-Appbar plugins?
If restarting Sublime didn't fix anything, could you also try uninstalling Materialize, reinstalling it, switching to a Materialize theme with the UI: Select Theme and then restarting Sublime and check if there are any issues.

@saadq: I did all the steps and yes file icons are working for me but the material_theme_accent_[whatever]: true is ignored and appear to be "stuck" with indigo as shown in @kud screenshot.

I am on build 3128
I do use Materialize-Appbar but it doesn't seem to have any impact, I get the same problem without it.
I did uninstall, reinstall and restart it several times but it is still "stuck" with the indigo accent.

Okay I've been investigating a bit and this issue seems very strange... I'm not entirely sure what the cause is right now but I'm currently working on trying to get a permanent solution. For now, I think I have a working fix although it is kind of strange:

Uninstall Materialize as well as Material Theme if you have it installed.
Install BOTH Materialize and Material Theme.
Do UI: Select Theme and choose Material-Theme.sublime-theme.
Do UI: Select Color Scheme and choose Material-Theme.
Restart Sublime.
At this point, things get a little funky. Your editor might currently look like this:

As you can see, some files have their icons, and some files don't. For any file that is not displaying the file icon, just hover your cursor over it and the file icon should appear next to it.

Do UI: Select Theme and choose a Materialize theme (Example: Material Spacegray.sublime-theme)
Do UI: Select Color Scheme and choose a Materialize color scheme (Example: Material Spacegray)
Restart Sublime for good measure.

At this point, the Materialize theme should not have any of the weird accent overrides and file icons should be showing.

This is a TEMPORARY workaround. I know it's a bit much, but I'm looking into a better solution (or hopefully another Sublime build is released that fixes whatever breaking changes occurred here).
Please let me know if the above still doesn't work for you.

@saadq : yup, that made it work, I'm back to where I was before the update to 3128 including with the AppBar addon. Thanks !

It didn't work for me. I did it twice.
Plus, $ subl . doesn't work anymore here, so I come back to 3126. :/

@kud So both file icons and accents are still screwed up for you?
Just to check, if you use Material-Theme as your theme, does it work fine or is it messed up as well?

Okay, I did a fresh install of Sublime Text + removed my preferences and put it back, now, everything is ok.
I think what I missed was Material Theme which asked you to install "A File Icon" package I didn't have.
Everything's fine, or even better because I've got beautiful icons now.

https://github.com/ihodev/a-file-icon is clearly needed I think.

Okay, I understand more and more now.
If you have some icons troubles, remove "a file icon" or "zzz a file icon zzz" and reinstall it if you want it (or not, if you want classic icons).

By the way, why do we have to install Material-Theme?
Materialize doesn't provide colour scheme but also theme?

I'm not entirely sure, but Materialize and Material Theme had drifted a bit from each other, and I need to finish the rework so that they are much more alike. The icons they had been using were the same, but it looks like since then Material Theme switched to using the package that is mentioned above. I will probably do something similar. Thanks for the info @kud.

Update: It looks like as of Build 3131, you won't have to deal with this workaround, everything should be working fine (try reinstalling Materialize in case it isn't). This means you don't have to keep the Material Theme installed. It's still recommended that you install the A File Icon package as their icons look better, and I will probably make installing them a prereq to installing Materialize (similar to what Material Theme does) soon.

+1 for "A File icon".


Usage examples in native code

It would be very helpful if you added some short usage examples with best practices for Android and iOS. Things are a bit more straight forward on Android since RevolverViewModel uses StateFlow and SharedFlow, APIs that are anyhow quite standard nowadays. On iOS, however, it's a bit unclear what are there are DOs and DONTs, in particular when it comes to properly tying the ViewModel's lifecycle to the View that it's bound to.

@l0rdyx something for you?


docs: add pull_request_template

What type of PR is this?

docs
What does this PR do?

add pull_request_template
Which issue(s) does this PR fix?

Fixes #14
Special notes for your reviewer:

是否满足本项目pull需求
Related Projects:

community-infra
kosmos-web

Screenshots (if applicable):

Additional Comments:

Already modified
/cc @wuyingjun-lucky
/cc @duanmengkk
/cc @hanweisen
/cc @wangyizhi1

/lgtm

/approve


Update chaincode4ade.rst

update an error in the document

Thanks for the contribution, but it's only a read-only mirror. You can go to Gerrit and submit the patch.


fix(version): update ngx-login-client to 1.1.5

@fabric8cd fabric8/fabric8-ui:SNAPSHOT-PR-2179-2 is deployed and available for testing at https://fabric8-ui-fabric8-ui-pr-2179-fabric8-planner.badger.fabric8.io


Support for UEFI BIOS

Hi there,
I made an attempt to boot using a uefi bios and failed. I'd loved to see uefi support so I can demo a personal project on a webpage.
I attempted to boot using a prebuilt ia32 uefi package from here https://www.kraxel.org/repos/jenkins/edk2/
I unpacked the files like so
ymir:foo$ rpm2cpio edk2.git-ovmf-ia32-0-20181129.806.ga5274cdc87.noarch.rpm | cpio -idmv
./usr/share/doc/edk2.git-ovmf-ia32
./usr/share/doc/edk2.git-ovmf-ia32/README
./usr/share/edk2.git
./usr/share/edk2.git/ovmf-ia32
./usr/share/edk2.git/ovmf-ia32/OVMF-need-smm.fd
./usr/share/edk2.git/ovmf-ia32/OVMF-pure-efi.fd
./usr/share/edk2.git/ovmf-ia32/OVMF-with-csm.fd
./usr/share/edk2.git/ovmf-ia32/OVMF_CODE-need-smm.fd
./usr/share/edk2.git/ovmf-ia32/OVMF_CODE-pure-efi.fd
./usr/share/edk2.git/ovmf-ia32/OVMF_CODE-with-csm.fd
./usr/share/edk2.git/ovmf-ia32/OVMF_VARS-need-smm.fd
./usr/share/edk2.git/ovmf-ia32/OVMF_VARS-pure-efi.fd
./usr/share/edk2.git/ovmf-ia32/OVMF_VARS-with-csm.fd
./usr/share/edk2.git/ovmf-ia32/UefiShell.iso
29490 blocks

Then moved the UEFI binary & iso in v86
ymir:foo$ cp usr/share/edk2.git/ovmf-ia32/OVMF-pure-efi.fd ../v86/bios/
ymir:foo$ cp usr/share/edk2.git/ovmf-ia32/UefiShell.iso ../v86/images/

I made these changes to basic.html to point to the uefi bios & iso.
--- a/examples/basic.html
+++ b/examples/basic.html
@@ -12,13 +12,10 @@ window.onload = function()
         vga_memory_size: 2 * 1024 * 1024,
         screen_container: document.getElementById("screen_container"),
         bios: {
-            url: "../bios/seabios.bin",
-        },
-        vga_bios: {
-            url: "../bios/vgabios.bin",
+            url: "../bios/OVMF-pure-efi.fd",
         },
         cdrom: {
-            url: "../images/linux.iso",
+            url: "../images/UefiShell.iso",
         },
         autostart: true,
     });

The last step were make run and finally navigated to http://<IP_ADDRESS>:8000/examples/basic.html only to see black screen and no output. I also tried leaving the vga bios in place.
Note I can boot into the uefi shell with qemu-system-i386 -bios bios/OVMF.fd -cdrom images/UefiShell.iso
Cheers, Jon

You have two vga bioses and are still using the original bios..
Or am I mistaken?

Hi Ben,
The basic.html section was a diff although I didn't explain that. Here's the js section plain.
[nix-shell:~/v86]$ cat examples/basic.html
<!doctype html>
<title>Basic Emulator</title><!-- not BASIC! -->

<script src="../build/libv86.js"></script>
<script>
"use strict";

window.onload = function()
{
    var emulator = window.emulator = new V86Starter({
        memory_size: 32 * 1024 * 1024,
        vga_memory_size: 2 * 1024 * 1024,
        screen_container: document.getElementById("screen_container"),
        bios: {
            url: "../bios/OVMF-pure-efi.fd",
        },
        cdrom: {
            url: "../images/UefiShell.iso",
        },
        autostart: true,
    });
}
...

Hi Ben,
Here you go. I had to zip together OVMF-pure-efi.fd & UefiShell.iso into ovmf-ia32.zip because of github upload restrictions.
Cheers, Jon

Hey! This thread doesn't really clarify what the way to go forward is; how should I go ahead to load an EFI program? Does SeaBIOS have a UEFI build? How can I get my hands on that?

What does qemu use for UEFI boot?

For QEMU, we tend to use OVMF for EFI booting.


Create Flutter.gitignore

Ignore rules for the Flutter SDK (see flutter.io). Based of the default
.gitignore rule generated for new projects. Does not include
rules already covered by Dart.gitignore.
Reasons for making this change:
Google's Flutter SDK needs custom ignore rules on top of Dart.gitignore
Links to documentation supporting these rule changes:
https://github.com/flutter/flutter/blob/master/.gitignore
If this is a new template:

Link to application or project’s homepage: https://flutter.io/

Does not include rules already covered by Dart.gitignore.

@saschpe correct me if I'm wrong here, but given how Flutter is coupled to Dart I think it's worth keeping those rules together - if you were to create a new Flutter project using just these rules you might find yourself committing the wrong files from the beginning.
Two potential solutions come to mind:

add a section for Flutter to Dart.gitignore - this simplifies maintenance, might affect discoverability, but reflects that Flutter is part of the Dart ecosystem
duplicate the rules from Dart.gitignore into Flutter.gitignore - this is preferred if you anticipate significantly more distinct rules for Flutter, and want to avoid churning the file significantly

@shiftkey There are other popular Dart projects around, most notably AngularDart, that would yield another section in Dart.gitignore soon as well. I don't have a strong opinion in either direction...
@RinaFave01 huh?

I'm going to close this out due to inactivity, but based on #2857 I'm interested in:

an update to Dart.gitignore to add Flutter-specific rules (opt-in or enabled by default)
a community/Dart/Flutter.gitignore template that refers to the main Dart.gitignore template


Features/default mock

v11.2.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.


Invalid value written to definitions.request.data element for body parameters

In the case where creating a request element for an endpoint in an input Swagger document that has a body parameter, an invalid value is written to the definitions.request.data element in the output Postman collection for that endpoint.
According to the Postman v1 schema, only null or array values are valid for this element, but in these cases a string value is written here corresponding to the description of the parameter from Swagger.

@gdereese The transformer has been updated to fix this bug - https://www.npmjs.com/package/postman-collection-transformer. We'll soon be releasing updates to the swagger converter to support folder ordering too.

Thanks for addressing this.
As for the fix to swagger2-to-postman, I submitted pull request #26; feel free to review it and see if that resolves the issue to your liking.


autosave should not have two ways to enable/disable

As each package has an enable/disable option through the settings view, a package should not have its own enable/disable setting, as a package should never have to check for itself if it is enabled or not.
If autosave is not something that should be enabled by default (which I feel it isn't), it probably shouldn't even be installed by default in the first place.
Small cleanups like these could probably help make Atom faster. Even though it's only 2ms in this case, all bits help (especially because the Atom startup time, on my desktop, is currently around 7 seconds).

I think this is a duplicate of https://github.com/atom/autosave/issues/14.


Runtime dependency switching

Hi I'd like to be able to switch implementation of certain classes during runtime - based on some "profile" switch.
For example
``
abstract class SecurityFilter
class LowSecurityFilter extends SecurityFilter
class HighSecurityFilter extends SecurityFilter
``
I'd like to be able to use SecurityFilter as dependency in other classes and be able to switch its implementation when running JVM for example using security_level parameter passed as command line argument
is there any recommended way to do it or there's no way to achieve such behaviour because of compile time nature of macwire ?

I would just do:
val securityFilter = if (config.securityLevel == "high") {
  new HighSecurityFilter(...) // or using wire[]
} else {
  new LowSecurityFilter(...)
}

But both HighSecurityFilter and LowSecurityFilter can have their own dependencies, they can be defined in module so how would module definition have that config available?

Well then the module definition needs to be parametrized with the config - either as an abstract trait member or another layer of constructor parameters.
If the dependencies are lazy, only the ones that are indeed used will be constructed.

e.g.
trait MyModule {
  def globalConfig: Config

  lazy val myModuleConfig = new MyModuleConfig(globalConfig)
  lazy val highSecFiltDependency = new ...
  lazy val securityFilter = if (myModuleConfig.securityLevel == "high") {
    new HighSecurityFilter(highSecFiltDependency, ...) // or using wire[]
  } else {
    new LowSecurityFilter(...)
  }
}

But in that case if I'd like to have let's say ModuleXYZ which imports dependencies from MyModule then MyModule would need to be object instead of trait. Furthermore globalConfig would need to be mutable var set at the beginning of app and entire dependency injection would rely on fact that this mutable variable is initialized before any lazy dependency is requested.
Do I see it right of there's some other way?

I don't think I understand why you would need global objects or mutable variables ...
In the main method, you can do e.g.
val modules = new MyModule1 with MyModule2 with ... {
  lazy val globalConfig = Config.load()
}

and that's it

It definitely makes more sense now :)
thx I'll give it a try

I think those examples are enough for this topic :)


Problem:(Fix #42) No un-jail instruction in the testnet docs

Instead of adding un-jail instruction, added instructions of transfer, staking & query balance. A note is also added at the end for redirecting people to chain-maind cli page.

Oh cos I was thinking to just copy the title of the issue #42 . I'll be mindful next time.

/staging


Put large files to LFS, clean large notebooks

lfs support is on, history commits also moved to lfs
lfs files are:
*.p
uplift/notebooks/*.ipynb
domyshnik/notebooks/*.ipynb
opends/notebooks/*.ipynb
experiments/sensors/*.ipynb
experiments/scenario_gender/notebooks/adversarial_demo.ipynb
experiments/scenario_gender/notebooks/adv_demo_interface.ipynb


Delete FinalFrontier-0.9.3-1792.ckan

This version deleted from Kerbalstuff by mod author. No longer appears in version list.

Merging with my thanks


Adding Reqmodule

This PR adds the UI of the Request Module for the web app.
Includes:

a place for users to add the headers, request body, HTTP method, and token used to get the request

I am going to make a new PR with the new changes and just merge it from there


Create menu entry for display dashboard command

Refer this link: https://cnpagency.com/blog/creating-sublime-text-3-plugins-part-1/

Not adding key-bindings because of too many existing key bindings already present in sublime


Hover effect

Feature request:
There should be some hover effect in opportunity page's boxes, i want to work on this issue under GSSoC'21.

if you don't like the idea you can close the issue , i will create new issue.

@kumarishalini6 Let's keep it similar to the hover effect that's on homepage.

Ok

I have send PR with  latest upstream . please check it.

Please close this issue

Please close this issue

You should ideally mention the issue with your PR, so that when the PR is merged , the issue closes automatically.


Add Interface to son-emu for son-cli profiling to run experiments

Implemented a class which can establish an ssh connection to a specified remote host and start a sonata topology there, connect to it and upload a service package. This service will be run for a specified amount of time and then stopped. Lastly, the topology is stopped and log files are collected via ssh

@edmaas We should replace the absolute paths with relative ones:
/home/levathos/son-emu...
to
~/son-emu


Use more specific don/ka types when writing to fumen (ド, コ, ドン, カッ, カ)

Since TJA files use only a single number to represent dons and kas (1 and 2 respectively), I have only been writing a single type of don/ka to the converted .bin file.
However, official fumens actually have 3 types of dons and 2 types of kas. And, different types will be used depending on how the dons and kas are grouped together:

Theoretically, my converter could track if a note is part of a triplet/quad/etc. and write the different notes accordingly. But, it might be quite tricky to programmatically detect groupings of notes.
Maybe what I could do is track "time since last note". If the time decreases (i.e. notes are closer together), we enter a "grouping". If the time stays the same, then we're still within the grouping. If the time increases (i.e. notes are further apart), we have exited the grouping. But, I don't know how foolproof that is if we consider BPMCHANGE commands, etc. 🤔

I assume that the logic goes like this:

Single notes just use ド (do) and カ (ka)
Groupings of 2 or more will always end on ドン (don) and カッ (ka~tsu)
If there are multiple don notes in a row in a grouping, they'll alternate between ド (do) and コ (ko)

For example:

DD -> ドドン -> Do-don
DDD -> ドコドン -> Do-ko-don
DDDDD -> ドコドコドン -> Do-ko-do-ko-don
DDDDK -> ドコドコカッ -> Do-ko-do-ko-katsu
KDK -> Is this カドカッ (Ka-do-katsu) or カドカッ (Ka-ko-katsu)? Presumably the former, right?

Groupings seem to include any set of notes with identical durations between them, e.g.:

(Note the katsu at the end, even when notes are spaced out)

I will have to be quite careful when keeping track of note groupings (tracking between-measure groupings, making sure to properly identify when a grouping ends, etc.).

It looks like there are a handful of approaches for clustering in 1D (see this SO answer). Many of them are using numpy / scipy, though. So, ideally, I would be able to implement something in pure Python?
I do think that the 1D clustering problem here is quite a bit simpler than the cases described on SO:

All of the ms timings of the notes are A) linear and B) unique
The spacing between ms timings is predictable and consistent
The smallest spacings (48th notes, 24th notes, 16th notes, 8th notes, etc.) are pretty much guaranteed to be grouped.

So, maybe I can come up with some sort of simplified algorithm to group the notes, given some assumptions.


Improve responses when http request validation fails

Given the following verb:
type GetPayReqQueryParams struct {
	LNURL string
}

type GetPayReqRequest = builtin.HttpRequest[ftl.Unit, ftl.Unit, GetPayReqQueryParams]

//ftl:typealias
type Decimal = decimal.Decimal

type PayReq struct {
	Callback    string  `json:"callback"`    // The URL from LN SERVICE which will accept the pay request parameters
	MaxSendable Decimal `json:"maxSendable"` // Max millisatoshi amount LN SERVICE is willing to receive
	MinSendable Decimal `json:"minSendable"` // Min millisatoshi amount LN SERVICE is willing to receive. can not be less than 1 or more than `maxSendable`
	Metadata    string  `json:"metadata"`    // Metadata json which must be presented as raw string per LUD06
	Tag         string  `json:"tag"`         // Type of LNURL
}

type LnServiceError struct {
	Status string `json:"status"`
	Reason string `json:"reason"`
}

type GetPayReqResponse = builtin.HttpResponse[PayReq, LnServiceError]

//ftl:ingress GET /lnurl/payreq
func GetPayReq(ctx context.Context, req GetPayReqRequest) (GetPayReqResponse, error) {
	logger := ftl.LoggerFromContext(ctx)

	logger.Infof("lnurl %s", req.Query.LNURL)

	return GetPayReqResponse{
		Status: http.StatusNotImplemented,
		Error:  ftl.Some(LnServiceError{Status: "NotImplemented", Reason: "Not implemented"}),
	}, nil
}

sending a request without the required query param results in the following response:
❯ curl -v "http://localhost:8891/lnurl/payreq"
* Host localhost:8891 was resolved.
* IPv6: ::1
* IPv4: <IP_ADDRESS>
*   Trying [::1]:8891...
* connect to ::1 port 8891 from ::1 port 53779 failed: Connection refused
*   Trying <IP_ADDRESS>:8891...
* Connected to localhost (<IP_ADDRESS>) port 8891
> GET /lnurl/payreq HTTP/1.1
> Host: localhost:8891
> User-Agent: curl/8.7.1
> Accept: */*
>
* Request completely sent off
< HTTP/1.1 400 Bad Request
< Content-Type: text/plain; charset=utf-8
< Vary: Origin
< X-Content-Type-Options: nosniff
< Date: Wed, 11 Sep 2024 06:23:42 GMT
< Content-Length: 47
<
lnurl.GetPayReqRequest.query.lnurl is required
* Connection #0 to host localhost left intact

it's awesome that FTL handles validation but i think the response can be improved. Most of the current response is unhelpful and potentially misleading to a caller. If i hadn't implemented this verb and received lnurl.GetPayReqRequest.query.lnurl as a response. i would think:

what is lnurl.GetPayReqRequest?
is this the expected shape of some json object i'm supposed to send as a request body?

maybe something along the lines of "lnurl is a required query param"

another thought that crossed my mind is that these error messages returned by FTL won't match a developer-defined error response type.
e.g. a developer is designing an API and has decided that all non 2xx responses will have a response body that looks something like:
type APIError struct {
	Message string
	Errors  []Error
}

//ftl:data export
type Error struct {
	Message string
	Code    ftl.Option[int]
	Field   ftl.Option[string]
}


As a participant I want to receive mails from the backend application

Is your feature request related to a problem? Please describe.
No emails are sent from the backend.
The logic is missing / not implemented yet.
Templates texts are available
Describe the solution you'd like
Mails are sent to the points in the process.
Additional context

A mail account is requested
Spring Mail is integrated in the backend
An element template exists for modeling
A delegate & mail service exists
The processes are extended

To achieve the goal, backend should be refactored and project structure has to be restrukted. There are a lot of overhead classes and code pieces that are incorect like:
 private final UUID id; final without value definition....
private final RegistrationService registrationService; CDI&@Autrowired??
@dominikhorn93  , Please, give me your feedback :)

Hey Vlad,
private final UUID id is totally fine. Initalization is done via constructor that is generated with the Lombok annotation.
Same with CDI. If you take a look at the class you'll find a @RequiredArgsConstruct. With that Lombok generates dependency injection via construct which is much better than using @Autowired. We are using Lombok to avoid boilerplate code.


APEXMALHAR-2350 #resolve #comment The key and value stream should mat…

…ch with the bucket

@siyuanh Can you please take a look? This seems to be related to the work you did for time bucket assignment for the windowed operator.

@siyuanh Could you have a look when you got time

@bhupeshchawda What I did is to improve the performance and try to avoid copy bytes and garbage collection. So the test is in the range of benchmark which we already have benchmark application. On the other side, this change should not impact the function which can be monitored by all existing unit tests.
I implemented a mechanism to monitor all the memory used by all SerializationBuffer instances, but it was not accepted. So it's hard to monitor all SerializationBuffer instances.

@brightchen I understand that most of these changes are for performance enhancement.
However, as the JIRA indicates, this is a bug. I think it arises when ManagedTimeUnifiedStateImpl is used as the store, which has time buckets instead of key buckets. It seems you have also made changes to solve this issue. The test I was requesting was to make sure that this bug is resolved.

@bhupeshchawda Added unit test, please review

@bhupeshchawda @chaithu14 applied comments. please review

@bhupeshchawda @chaithu14 Could you please merge if no further comments

Looks good to me.


Create salmon partial selective alignment index

Creating a separate issue for the partial selective alignment index file.
Implementing this in the workflow may require rewriting the generateDecoyTranscriptome.sh script linked below into separate workflow processes so mashmap and bedtools can use biopackages docker containers, or creating a single docker image with mashmap and bedtools. Alternatively, installing mashmap and/or bedtools as part of the process script into a container might not be a terrible option.
This step will probably require a large instance.
https://github.com/COMBINE-lab/SalmonTools/blob/master/README.md
https://raw.githubusercontent.com/COMBINE-lab/SalmonTools/master/scripts/generateDecoyTranscriptome.sh

Moving to icebox, as I don't think we are likely to use this based on initial comparisons, as discussed in https://github.com/AlexsLemonade/alsf-scpca/blob/911cae106db395daac4451c82131e5b2d77256ef/workflows/benchmarks/benchmark-analysis.Rmd, which used a prebuilt index for initial comparisons.

Closing, because this will not be compatible with alevin-fry as we are using it.


go/doc: Synopsis can return a sentence spanning multiple paragraphs and code blocks

The Synopsis function defines the logic to determine the synopsis, often used on package documentation. The logic is:

Synopsis returns a cleaned version of the first sentence in s. That sentence ends after the first period followed by space and not preceded by exactly one uppercase letter. The result string has no \n, \r, or \t characters and uses only single spaces between words. If s starts with any of the IllegalPrefixes, the result is the empty string.

Let "paragraph" mean a block of text separated from other text by a blank line (i.e., "\n\n"). The current synopsis logic means a sentence can span across multiple paragraphs. For example:
fmt.Println(doc.Synopsis(`This is a sentence that starts in the first paragraph

and it keeps going in the second paragraph

and ends in the third paragraph. This is the second sentence.`))

// Output: This is a sentence that starts in the first paragraph and it keeps going in the second paragraph and ends in the third paragraph.

(Playground link: https://play.golang.org/p/hSAetYyxkwa)
Perhaps we should consider changing the logic such that a sentence is not allowed to span multiple paragraphs.
From what I've observed, that is rarely used intentionally, but can happen unintentionally. For example, the current version of the github.com/rs/cors package has a very long synopsis that spans multiple paragraphs and includes code blocks:
$ go list -f '{{.Doc}}' github.com/rs/cors
Package cors is net/http handler to handle CORS related requests as defined by http://www.w3.org/TR/cors/ You can configure it by passing an option struct to cors.New: c := cors.New(cors.Options{ AllowedOrigins: []string{"foo.com"}, AllowedMethods: []string{http.MethodGet, http.MethodPost, http.MethodDelete}, AllowCredentials: true, }) Then insert the handler in the chain: handler = c.Handler(handler) See Options documentation for more options.

/cc @griesemer @julieqiu
Edit: Another one is github.com/peterhellberg/link:
$ go list -f '{{.Doc}}' github.com/peterhellberg/link
Package link parses Link headers used for pagination, as defined in RFC 5988 Installation Just go get the package: go get -u github.com/peterhellberg/link Usage A small usage example package main import ( "fmt" "net/http" "github.com/peterhellberg/link" ) func main() { for _, l := range link.Parse(`<https://example.com/?page=2>; rel="next"; foo="bar"`) { fmt.Printf("URI: %q, Rel: %q, Extra: %+v\n", l.URI, l.Rel, l.Extra) // URI: "https://example.com/?page=2", Rel: "next", Extra: map[foo:bar] } if resp, err := http.Get("https://api.github.com/search/code?q=Println+user:golang"); err == nil { for _, l := range link.ParseResponse(resp) { fmt.Printf("URI: %q, Rel: %q, Extra: %+v\n", l.URI, l.Rel, l.Extra) // URI: "https://api.github.com/search/code?q=Println+user%3Agolang&page=2", Rel: "next", Extra: map[] // URI: "https://api.github.com/search/code?q=Println+user%3Agolang&page=34", Rel: "last", Extra: map[] } } }

Edit 2: Another one is<EMAIL_ADDRESS>$ go list -f '{{.Doc}}' github.com/astaxie/beego/orm
Package orm provide ORM for MySQL/PostgreSQL/sqlite Simple Usage package main import ( "fmt" "github.com/astaxie/beego/orm" _ "github.com/go-sql-driver/mysql" // import your used driver ) // Model Struct type User struct { Id int `orm:"auto"` Name string `orm:"size(100)"` } func init() { orm.RegisterDataBase("default", "mysql", "root:root@/my_db?charset=utf8", 30) } func main() { o := orm.NewOrm() user := User{Name: "slene"} // insert id, err := o.Insert(&user) // update user.Name = "astaxie" num, err := o.Update(&user) // read one u := User{Id: user.Id} err = o.Read(&u) // delete num, err = o.Delete(&u) } more docs: http://beego.me/docs/mvc/model/overview.md

Seems reasonable. Should perhaps run a small experiment and see if and which synopsis change, say for the std lib (I expect close to none to change).

Sounds good. To make progress on this issue, we should run that experiment and confirm the results are favorable. We should be able to include a corpus with a number of third-party packages in the experiment, in addition to the standard library packages.

I ran an experiment on the standard library and some modules that were recently published (by using the module index). The results seem favorable, and there are quite a few cases where the synopsis extends well beyond the first paragraph.
First, there is one diff in the standard library:
<EMAIL_ADDRESS>"Package ppc64 implements a PPC64 assembler that assembles Go asm into the corresponding PPC64 instructions as defined by the Power ISA 3.0B. This document provides information on how to write code in Go assembler for PPC64, focusing on the differences between Go and PPC64 assembly language."
→
"Package ppc64 implements a PPC64 assembler that assembles Go asm into the corresponding PPC64 instructions as defined by the Power ISA 3.0B."

It's a good change. It helps with a case in the cmd/internal/obj/ppc64 package where the sentence ends with "3.0B.", which isn't recognized as the end of a sentence (which itself a small issue, but it's out of scope here).
There are more diffs in the golang.org/x modules:
<EMAIL_ADDRESS>"Package otr implements the Off The Record protocol as specified in http://www.cypherpunks.ca/otr/Protocol-v2-3.1.0.html The version of OTR implemented by this package has been deprecated (https://bugs.otr.im/lib/libotr/issues/140)."
→
"Package otr implements the Off The Record protocol as specified in http://www.cypherpunks.ca/otr/Protocol-v2-3.1.0.html"

<EMAIL_ADDRESS>"Package rc2 implements the RC2 cipher https://www.ietf.org/rfc/rfc2268.txt http://people.csail.mit.edu/rivest/pubs/KRRR98.pdf This code is licensed under the MIT license."
→
"Package rc2 implements the RC2 cipher"

<EMAIL_ADDRESS>"Package xtea implements XTEA encryption, as defined in Needham and Wheeler's 1997 technical report, \"Tea extensions.\" XTEA is a legacy cipher and its short block size makes it vulnerable to birthday bound attacks (see https://sweet32.info)."
→
"Package xtea implements XTEA encryption, as defined in Needham and Wheeler's 1997 technical report, \"Tea extensions.\""

<EMAIL_ADDRESS>"Gobind generates language bindings that make it possible to call Go functions from Java and Objective-C. Typically gobind is not used directly."
→
"Gobind generates language bindings that make it possible to call Go functions from Java and Objective-C."

<EMAIL_ADDRESS>"Package publicsuffix provides a public suffix list based on data from https://publicsuffix.org/ A public suffix is one under which Internet users can directly register names."
→
"Package publicsuffix provides a public suffix list based on data from https://publicsuffix.org/"

<EMAIL_ADDRESS>"This program is a server for the WebDAV 'litmus' compliance test at http://www.webdav.org/neon/litmus/ To run the test: go run litmus_test_server.go and separately, from the downloaded litmus-xxx directory: make URL=http://localhost:9999/ check"
→
"This program is a server for the WebDAV 'litmus' compliance test at http://www.webdav.org/neon/litmus/ To run the test:"

<EMAIL_ADDRESS>"mkwinsyscall generates windows system call bodies It parses all files specified on command line containing function prototypes (like syscall_windows.go) and prints system call bodies to standard output."
→
"mkwinsyscall generates windows system call bodies"

<EMAIL_ADDRESS>"Deprecated: benchcmp is deprecated in favor of benchstat: golang.org/x/perf/cmd/benchstat The benchcmp command displays performance changes between benchmarks."
→
"Deprecated: benchcmp is deprecated in favor of benchstat: golang.org/x/perf/cmd/benchstat"

These changes seem favorable too. Most happen because the first sentence is missing a period. A few happen because there is a period but it is not recognized due to a quote character, or being mistaken for an acronym.
The benchcmp change is questionable, but its documentation doesn't follow the suggested style of starting a package comment with "Package [name] ..."; the deprecated paragraph needs to be moved below.
In third-party packages, the vast majority of instances have a zero diff (9505 .go files out of 1070 unique modules). There are instances where the diff is non-zero (91 .go files out of 1061 unique modules). The changes overall look favorable. In many cases, they help reduce an accidentally very long synopsis to one that is much shorter and more readable. In the remaining cases, it turns a poor synopsis into a slightly shorter but also poor synopsis. You can see the raw data here.
Based on this data, I think it's reasonable to move this issue to NeedsFix state. @griesemer Do you agree?


Minor refactoring for metadata cache, using sync.Once instead

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[x] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any changes that may affect Istio users.

What is the motivation here?  What is the reason for making this change?
IIRC, this was intentionally NOT a sync.Once when when updated because Metadata retrieval had proven to be flaky, and there was a concern that if the initial retrieval failed, we wouldn't get the proper Metadata when needed.
Also, the way this is structured, we end up with nested sync.Once calls. That doesn't seem useful.

What is the motivation here? What is the reason for making this change?
IIRC, this was intentionally NOT a sync.Once when when updated because Metadata retrieval had proven to be flaky, and there was a concern that if the initial retrieval failed, we wouldn't get the proper Metadata when needed.
Also, the way this is structured, we end up with nested sync.Once calls. That doesn't seem useful.

The logics are the same as the current one. The same issue could happen if metadata retrieval failed the logic won't update metadata in the second attempt because of the check at L140-144:
'''
e.Lock()
defer e.Unlock()
if e.metadata != nil {
return e.metadata
}
'''
Can you expand with an example of why it will end up with nested sync.Once calls?

I do not agree that the logic is the same. If there is a temporary metadata failure, we would expect that e.metadata would not get populated with any values, right?
But even if the logic was the same, then what is the value in changing it? I still don't understand the motivation here.
RE: nesting - the parseGCPMetadata uses env.Once.

Whoops. Sorry, you are right. we should be checking that metadata is empty, not nil.

Whoops. Sorry, you are right. we should be checking that metadata is empty, not nil.

yep, I will revert sync.Once. The original motivation is for readability, but now i guess it is only my personal preference.
I am proposing we start relying on this code to fetch GKE cluster info used in isito-agent without user input. It is nice to have you revisit this code here as well.

@elfinhe: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
7314bb1ed7b5e27962edb384efa20f4d0efd84eb
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@douglas-reid can take one more round of review?


Measure code coverage

Update Selenium WebDriver
Add Blanket.js lib
Add unit test to calculate the code coverage

#193

:shipit:


Occasional missing images in "build" folder when rebuilding APKs from inside another process

I'm investigating an issue whereby some images are sometimes missing from the "build" folder created when rebuilding an APK. The set of missing images varies from one rebuild to another. I can confirm that all the images are present in the folder passed to Apktool.
I'm running Apktool.bat from within another process (our proprietary localisation software) using the Windows CreateProcess API function. It occasionally reproduces when running automated test scripts on a machine with 8GB of RAM but never when used on dev machines (all have 16GB). I didn't want to log a bug proper as I don't have enough information but was wondering if this is something you've seen before or might have an explanation for?

Are you using aapt1 or aapt2? It it more reproducible with one over the other?
aapt2 is a multi stage build, while aapt1 isn't which is why I ask.

Hi,
We've been using aapt1 (I only learned of the aapt2 flag when you posted! :)
We're going to switch over to aapt2 to see if that addresses the problem. I'm not sure if it's some kind of race condition in how we call ApkTool, or if something is removing files on the host machine like antivirus, but I don't think it's that either.


Unresponsive cursor

Type: Performance Issue
At work I switched from Windows to using Fedora and now I'm experiencing freezing* and odd cursor behavior**.
* The top menu can still be opened. The top-right buttons work as they should, I think.
** Unless I disable hardware acceleration, the cursor is very jittery. Also, I think the top bar flickers as you type, if I remember correctly.
If you spend a few days with VS Code on Fedora I'm sure you'll see what I mean. It's not a fun experience.
VS Code version: Code 1.70.1 (6d9b74a70ca9c7733b29f0456fd8195364076dda, 2022-08-10T06:09:15.055Z)
OS version: Linux x64 5.18.17-200.fc36.x86_64
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 PRO 5750G with Radeon Graphics (16 x 3453)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
0, 0, 0

Memory (System)
31.14GB (13.26GB free)

Process Argv
--unity-launch --crash-reporter-id 60a43f92-093c-479d-9594-8d692eb08608

Screen Reader
no

VM
0%

DESKTOP_SESSION
gnome

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome

XDG_SESSION_TYPE
wayland

Extensions (3)

Extension
Author (truncated)
Version

vscode-drawio
hed
1.6.4

rest-client
hum
0.25.1

gitblame
wad
9.0.1

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
pythondataviewer:30285071
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411cf:30542925
vsaa593cf:30376535
pythonvs932:30410667
wslgetstarted:30449410
cppdebug:30492333
pylanb8912:30545647
vsclangdc:30486549
c4g48928:30535728
hb751961:30543456
dsvsc012cf:30540253
azure-dev_surveyone:30548225

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.70.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Update README.md

improve pod formatting

Don't know how I could have missed this, merged, thanks 🎉


Wrapping content in separate DIV results into non delegated events not being listened to properly

The bound _triggerEvent function has not been added to the content DIV.
This massively complicates the way we are adding event listeners.

Thanks for reporting this @alexanderGugel. How should we go about resolving this?

 I'm not sure yet how to best resolve this.

Can you please expand on what you mean by non-delegated events or provide a quick sample?

@jd-carroll Of course!
Currently we are delegating as many events as possible. Unfortunately not all events bubble, therefore we have to add an event listener directly to the element corresponding to the Node when it doesn't bubble (e.g. mouseenter).
The EventMap defines what types of events are being delegated and which constructor function is being used to serialize the event:
E.g.
    click                          : [MouseEvent, true],

means the event of type click is being delegated (true) using the MouseEvent constructor.
This works perfectly fine. But let's say we have an event that doesn't bubble:
    mouseleave                     : [MouseEvent, false],

We need to attach the event listener to that element corresponding to the node. And here is the issue: If we have a content DIV, we need to attach the listener there, otherwise we need to add it to the containing DIV. Currently we don't do that, so non-bubbling events will stop working when setting a content after the listener has been added.


fix typo in runner.go

Signed-off-by: Pavol Pitonak<EMAIL_ADDRESS>

@sriv marking this as release candidate as there seems to be previous commit upgrading grpc lib versions and it's probably best to release.

Thanks for the contribution @ppitonak


fix(renderLess): support less 2.0

Changes:

use less.render for a cross-version solution

Closes #103

Coverage decreased (-0.21%) when pulling 760807dbd5a2f0aa527f523413c7f34ca4976370 on kingcody:fix/less-2.0-support into 2b7bbe8919aa578196d046b66547f674daf64ccb on niftylettuce:master.

Coverage decreased (-0.11%) when pulling 265764bfd2b7a60b87ca59d615f3c8f11b8e5d2f on kingcody:fix/less-2.0-support into 2b7bbe8919aa578196d046b66547f674daf64ccb on niftylettuce:master.

Coverage increased (+3.1%) when pulling d3f118dfdb4f0de987d92b34e44d611cd5b392ed on kingcody:fix/less-2.0-support into 2b7bbe8919aa578196d046b66547f674daf64ccb on niftylettuce:master.

It would seem that the issues with the tests failing on node v0.11.14 are related to tj/consolidate.js#143
Any ideas on a solution?

Thank you for this? Can you please rebase?

Hi @kingcody, all,
Any news on that? Thanks!

I'll do a rebase tonight :)

Coverage increased (+3.1%) to 86.54% when pulling c394dd004014c0c0c558f8f34540b6292ebd7840 on kingcody:fix/less-2.0-support into c722449c9548194f1ab41186cc70e80f5643637b on niftylettuce:master.

Coverage increased (+3.1%) to 86.54% when pulling 1163d6757aa400a61a164fdaf2212ed40ee4a6e6 on kingcody:fix/less-2.0-support into c722449c9548194f1ab41186cc70e80f5643637b on niftylettuce:master.

Coverage increased (+3.1%) to 86.54% when pulling 1163d6757aa400a61a164fdaf2212ed40ee4a6e6 on kingcody:fix/less-2.0-support into c722449c9548194f1ab41186cc70e80f5643637b on niftylettuce:master.

@jeduan any idea whats up with the libsass error on iojs build?

Other than that, it should be good (rebased and what not).

Coverage increased (+0.53%) to 83.97% when pulling 1af126f8243f8890e4bec1c0f7e1137ce759d407 on kingcody:fix/less-2.0-support into c722449c9548194f1ab41186cc70e80f5643637b on niftylettuce:master.

Coverage increased (+3.1%) to 86.54% when pulling 2cc4e30bd41e366f415326c9b5eebac5c64db737 on kingcody:fix/less-2.0-support into c722449c9548194f1ab41186cc70e80f5643637b on niftylettuce:master.

Ok, turns out node-sass doesn't support iojs > 1.2 ATM. Switched to 1.2.0 in .travis.yml.


Prepare a VAST v2.4.2 release

This PR backports #3047 and prepares the repository for a new patch release on the v2.4.x branch.

@tobim I will have to merge this using an administrative override as we broke the v2.4.x CI by renaming the default branch from master to main. I would still like to get an approval on this. I ran the tests locally and confirmed that the issue is fixed with this on this branch as well.


MSW: nested objects with the same attribute names.

What are the steps to reproduce this issue?

Set Up the Environment:

Install orval v6.17.0 on your machine.

Provide the OpenAPI Definition:
Create an OpenAPI document in which the parent attribute appears multiple times in a nested structure.
openapi: "3.0.0"
info:
  version: 1.0.0
  title: Swagger Petstore
  license:
    name: MIT
servers:
  - url: http://petstore.swagger.io/v1
paths:
  /pets/{petId}:
    get:
      summary: Info for a specific pet
      operationId: showPetById
      parameters:
        - name: petId
          in: path
          required: true
          description: The id of the pet to retrieve
          schema:
            type: string
      responses:
        "200":
          description: Expected response to a valid request
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/Pet"
components:
  schemas:
    Pet:
      type: object
      required:
        - id
        - name
      properties:
        id:
          type: integer
          format: int64
        name:
          type: string
        tag:
          type: string
        parent:
          $ref: "#/components/schemas/Parent"
    Parent:
      type: object
      required:
        - id
        - name
      properties:
        id:
          type: integer
          format: int64
        name:
          type: string
        tag:
          type: string
        parent:
          $ref: "#/components/schemas/GrandParent"
    GrandParent:
      type: object
      required:
        - id
        - name
        - parent
      properties:
        id:
          type: integer
          format: int64
        name:
          type: string
        tag:
          type: string
        parent:
          $ref: "#/components/schemas/GreatParent"
    GreatParent:
      type: object
      required:
        - id
        - name
        - parent
      properties:
        id:
          type: integer
          format: int64
        name:
          type: string
        tag:
          type: string

Run Orval Code Generator:
run command with config mock:true.
orval

Inspect the Generated MSW Mock:
/**
 * Generated by orval v6.17.0 🍺
 * Do not edit manually.
 * Swagger Petstore
 * OpenAPI spec version: 1.0.0
 */
import { rest } from "msw";
import { faker } from "@faker-js/faker";

export const getShowPetByIdMock = () => ({
  id: faker.datatype.number({ min: undefined, max: undefined }),
  name: faker.random.word(),
  tag: faker.helpers.arrayElement([faker.random.word(), undefined]),
  parent: faker.helpers.arrayElement([
    {
      id: faker.datatype.number({ min: undefined, max: undefined }),
      name: faker.random.word(),
      tag: faker.helpers.arrayElement([faker.random.word(), undefined]),
      parent: faker.helpers.arrayElement([
        {
          id: faker.datatype.number({ min: undefined, max: undefined }),
          name: faker.random.word(),
          tag: faker.helpers.arrayElement([faker.random.word(), undefined]),
        },
        undefined,
      ]),
    },
    undefined,
  ]),
});

export const getDefaultMSW = () => [
  rest.get("*/pets/:petId", (_req, res, ctx) => {
    return res(ctx.delay(100), ctx.status(200, "Mocked status"), ctx.json(getShowPetByIdMock()));
  }),
];

What happens?
The GreatParent type, which should appear nested under the GrandParent schema's parent attribute in the generated MSW mock, is missing.
What were you expecting to happen?
The GreatParent mock should be generated in the MSW mock file, reflecting its definition and the structure provided in the OpenAPI spec.
Any logs, error output, etc?
No specific error messages are shown during the code generation, but the generated code is missing the expected mock structure.
Any other comments?
It's crucial for our application to have complete mock data for accurate testing, including nested types.
What versions are you using?
**Operating System: Mac Ventura 13.4.1
**Package Version: Orval: v6.17.0, Node:20.5.0
**Browser Version: -

@Will-Mann-16 wanna verify this one?

I can validate this happens, I'll investigate and see if I can find a fix.

Awesome I assigned it to you.


Unable to read the GPS location of Images (BB Android)

Hello Sir,
The source code unable to read the GPS location (Images taken by Blackberry Android phones).
in line 797 of your code
case 4:
// GPS longitude
if (format == 5 && length == 3) {
But BB Android Images format is 10.
Please check once. Here I am attaching a sample image.
Regards
naresh

Thanks for reporting Naresh, putting in a patch now.


🐞 When changing font size, line heights are not recalculated until view refresh

If you change your font size, lines do not grow with the new size as expected. The lines only reflect the font size change when changing tabs or closing and reopening the file.

@austincondiff - can we generalize this issue to instead be:
Changing any code editing preference should automatically update the CodeEditTextView with the changes

Closed with #122


'Standardize' code structure

Pending formal discussion

From:

TrueMyth

Maybe.cs
TrueMyth.csproj

To:

samples
src

TrueMyth

Maybe.cs
TrueMyth.csproj

test

@chriskrycho I opened this quick PR to give the project a src + tests folder structure, but I imagine the existing "Program" might turn into an example of some kind? And we'd create a library project? Maybe we can do that later?

Yeah, using it as an example – or, equally, just dropping it in favor of the README and docs – seems sensible to me. I only needed that particular bit specifically for the teaching aspect, as something I could walk through in real-time.

@aggieben, since I see you also forked – if you're on the same page with @chrisriesgo here, I'll happily merge it and we can proceed with that!

@chriskrycho - updated the PR. made the old .csproj a baseline example/sample, then created a new csproj netstandard lib (can really be changed to whatever we want) with Maybe and Result living under it.
Unless you have some other ideas, @aggieben

Looks good to me, @chriskrycho @chrisriesgo

:shipit:


update date every time when clock restart

(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)
Types of changes
Please put an x in the box that applies

[x] Bugfix
[ ] New feature
[ ] Refactoring
[ ] Breaking change (any change that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Other (please describe)

Description
Describe what the change is
Previously the date on top of the clock is set once launched. Now the date is re-checked every time a clock finishes.
Steps to Test This Pull Request
Steps to reproduce the behavior:
I haven't think of a nice way of testing the desired behavior.

sounds good.
On Tue, Jul 21, 2020 at 6:04 AM Taihsiang Ho<EMAIL_ADDRESS>wrote:

@tai271828 approved this pull request.
The implementation is elegant. I like it very much.
not for this pull request: I smell some duplicated lines. Maybe we could a
function like refresh_widgets in the future pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zztin/ctimer/pull/20#pullrequestreview-452110925, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AH2QX2K3VRSHGY4LP4VETQTR4UHVLANCNFSM4PB6RLPA
.


Support installing plugin SNAPSHOTs with SNASPHOT distribution

Description
Support installing plugin SNAPSHOTs with SNASPHOT distribution
/opensearch-2.19.0-SNAPSHOT$ ./bin/opensearch-plugin install transport-reactor-netty4
-> Installing transport-reactor-netty4
-> Downloading transport-reactor-netty4 from opensearch
[=================================================] 100%

Related Issues
Part of https://github.com/opensearch-project/opensearch-build/issues/5096, addresses https://github.com/opensearch-project/OpenSearch/pull/16219

Check List

[ ] Functionality includes testing.
[ ] API changes companion pull request created, if applicable.
[ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The signature part is not yet settled:
/opensearch-2.19.0-SNAPSHOT$ ./bin/opensearch-plugin install transport-reactor-netty4
-> Installing transport-reactor-netty4
-> Downloading transport-reactor-netty4 from opensearch
[=================================================] 100%
-> Failed installing transport-reactor-netty4
-> Rolling back transport-reactor-netty4
-> Rolled back transport-reactor-netty4
Exception in thread "main" java.io.IOException: Server returned HTTP response code: 403 for URL: https://artifacts.opensearch.org/snapshots/plugins/transport-reactor-netty4/2.19.0-SNAPSHOT/transport-reactor-netty4-2.19.0-SNAPSHOT.zip.sig
        at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:2013)
        at java.base/sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1614)
        at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:223)
        at java.base/java.net.URL.openStream(URL.java:1325)
        at org.opensearch.plugins.InstallPluginCommand.urlOpenStream(InstallPluginCommand.java:490)
        at org.opensearch.plugins.InstallPluginCommand.verifySignature(InstallPluginCommand.java:630)
        at org.opensearch.plugins.InstallPluginCommand.downloadAndValidate(InstallPluginCommand.java:608)
        at org.opensearch.plugins.InstallPluginCommand.download(InstallPluginCommand.java:316)
        at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:271)
        at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:248)
        at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:104)
        at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
        at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
        at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
        at org.opensearch.cli.Command.main(Command.java:101)
        at org.opensearch.plugins.PluginCli.main(PluginCli.java:60)

Success!
$ ./bin/opensearch-plugin install transport-nio
-> Installing transport-nio
-> Downloading transport-nio from opensearch
[=================================================] 100%
-> Installed transport-nio with folder name transport-nio

$ /home/opensearch-3.0.0-SNAPSHOT$ ./bin/opensearch-plugin install transport-nio
-> Installing transport-nio
-> Downloading transport-nio from opensearch
[=================================================] 100%
-> Installed transport-nio with folder name transport-nio

$ ll plugins/transport-nio/
total 3.3M
-rw-r--r-- 1 user group  12K Nov 12 14:15 LICENSE.txt
-rw-r--r-- 1 user group 329K Nov 12 14:15 netty-buffer-4.1.114.Final.jar
-rw-r--r-- 1 user group 344K Nov 12 14:15 netty-codec-4.1.114.Final.jar
-rw-r--r-- 1 user group 653K Nov 12 14:15 netty-codec-http-4.1.114.Final.jar
-rw-r--r-- 1 user group 679K Nov 12 14:15 netty-common-4.1.114.Final.jar
-rw-r--r-- 1 user group 564K Nov 12 14:15 netty-handler-4.1.114.Final.jar
-rw-r--r-- 1 user group  37K Nov 12 14:15 netty-resolver-4.1.114.Final.jar
-rw-r--r-- 1 user group 510K Nov 12 14:15 netty-transport-4.1.114.Final.jar
-rw-r--r-- 1 user group  44K Nov 12 14:15 netty-transport-native-unix-common-4.1.114.Final.jar
-rw-r--r-- 1 user group  16K Nov 12 14:15 NOTICE.txt
-rw-r--r-- 1 user group  59K Nov 12 14:15 opensearch-nio-3.0.0-SNAPSHOT.jar
-rw-r--r-- 1 user group 1.9K Nov 12 14:15 plugin-descriptor.properties
-rw-r--r-- 1 user group 1.7K Nov 12 14:15 plugin-security.policy
-rw-r--r-- 1 user group  66K Nov 12 14:15 transport-nio-client-3.0.0-SNAPSHOT.jar

@saratvemulapalli LGTY? thanks!


Reformat code.

Reformat code using Android Studio (most of the time).
Drop tabs by spaces for indentation.

@kevin-lot we need a .editorconfig file (http://editorconfig.org/) so the styling is enforced, otherwise this PR has no use since the formatting can be freely changed with another PR