[Error] crc start : Error starting machine: Error in driver during machine start: Unable to detemine VM's IP address, did it fail to boot?

General information
OS: Windows
Hypervisor: Vmware Workstation 16 Pro
Did you run crc setup before starting it (Yes) But it fails
Running CRC on: Dell Desktop

CRC version
CRC version: 2.15.0+cc05160
OpenShift version: 4.12.15
Podman version: 4.3.1

CRC status
CRC VM:          Running
OpenShift:       Unreachable (v4.12.5)
RAM Usage:       511.5MB of 9.399GB
Disk Usage:      12.65GB of 32.74GB (Inside the CRC VM)
Cache Usage:     16.06GB
Cache Directory: /home/student/.crc/cache

CRC config
consent-telemetry                     : no

Host Operating System
NAME="Red Hat Enterprise Linux"
VERSION="9.1 (Plow)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="9.1"
PLATFORM_ID="platform:el9"
PRETTY_NAME="Red Hat Enterprise Linux 9.1 (Plow)"
ANSI_COLOR="0;31"
LOGO="fedora-logo-icon"
CPE_NAME="cpe:/o:redhat:enterprise_linux:9::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/red_hat_enterprise_linux/9/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 9"
REDHAT_BUGZILLA_PRODUCT_VERSION=9.1
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="9.1"
Red Hat Enterprise Linux release 9.1 (Plow)
Red Hat Enterprise Linux release 9.1 (Plow)
processor       : 0-7
vendor_id       : GenuineIntel
cpu family      : 6
model           : 167
model name      : 11th Gen Intel(R) Core(TM) i9-11900KF @ 3.50GHz
stepping        : 1
microcode       : 0x57
cpu MHz         : 3503.999
cache size      : 16384 KB
physical id     : 1
siblings        : 4
core id         : 3
cpu cores       : 4
apicid          : 7
initial apicid  : 7
fpu             : yes
fpu_exception   : yes
cpuid level     : 27
wp              : yes

Steps to reproduce
# crc delete -f
Deleted the instance

# crc cleanup
INFO Removing vsock configuration
INFO Removing 'crc' network from libvirt
INFO Removing /etc/NetworkManager/dnsmasq.d/crc.conf file
INFO Using root access: Removing NetworkManager configuration file in /etc/NetworkManager/dnsmasq.d/crc.conf
INFO Using root access: Executing systemctl daemon-reload command
INFO Using root access: Executing systemctl reload NetworkManager
INFO Removing /etc/NetworkManager/conf.d/crc-nm-dnsmasq.conf file
INFO Using root access: Removing NetworkManager configuration file in /etc/NetworkManager/conf.d/crc-nm-dnsmasq.con
INFO Using root access: Executing systemctl daemon-reload command
INFO Using root access: Executing systemctl reload NetworkManager
INFO Removing crc daemon systemd socket units
INFO Removing crc daemon systemd service
INFO Removing crc's virtual machine
INFO Removing crc libvirt storage pool
INFO Removing hosts file records added by CRC
INFO Removing pull secret from the keyring
INFO Removing older logs
INFO Removing CRC Machine Instance directory
INFO Removing crc executable symlink
Cleanup finished

# crc setup
INFO Using bundle path /home/student/.crc/cache/crc_libvirt_4.12.5_amd64.crcbundle
INFO Checking if running as non-root
INFO Checking if running inside WSL2
INFO Checking if crc-admin-helper executable is cached
INFO Checking if running on a supported CPU architecture
INFO Checking minimum RAM requirements
INFO Checking if crc executable symlink exists
INFO Creating symlink for crc executable
INFO Checking if Virtualization is enabled
INFO Checking if KVM is enabled
INFO Checking if libvirt is installed
INFO Checking if user is part of libvirt group
INFO Checking if active user/process is currently part of the libvirt group
INFO Checking if libvirt daemon is running
INFO Checking if a supported libvirt version is installed
INFO Checking if crc-driver-libvirt is installed
INFO Checking crc daemon systemd service
INFO Setting up crc daemon systemd service
INFO Checking crc daemon systemd socket units
INFO Setting up crc daemon systemd socket units
INFO Checking if systemd-networkd is running
INFO Checking if NetworkManager is installed
INFO Checking if NetworkManager service is running
INFO Checking if /etc/NetworkManager/conf.d/crc-nm-dnsmasq.conf exists
INFO Writing Network Manager config for crc
INFO Using root access: Writing NetworkManager configuration to /etc/NetworkManager/conf.d/crc-nm-dnsmasq.conf
INFO Using root access: Changing permissions for /etc/NetworkManager/conf.d/crc-nm-dnsmasq.conf to 644
INFO Using root access: Executing systemctl daemon-reload command
INFO Using root access: Executing systemctl reload NetworkManager
INFO Checking if /etc/NetworkManager/dnsmasq.d/crc.conf exists
INFO Writing dnsmasq config for crc
INFO Using root access: Writing NetworkManager configuration to /etc/NetworkManager/dnsmasq.d/crc.conf
INFO Using root access: Changing permissions for /etc/NetworkManager/dnsmasq.d/crc.conf to 644
INFO Using root access: Executing systemctl daemon-reload command
INFO Using root access: Executing systemctl reload NetworkManager
INFO Checking if libvirt 'crc' network is available
INFO Setting up libvirt 'crc' network
INFO Checking if libvirt 'crc' network is active
INFO Starting libvirt 'crc' network
INFO Checking if CRC bundle is extracted in '$HOME/.crc'
INFO Checking if /home/student/.crc/cache/crc_libvirt_4.12.5_amd64.crcbundle exists
Your system is correctly setup for using CRC. Use 'crc start' to start the instance

# crc start
INFO Checking if running as non-root
INFO Checking if running inside WSL2
INFO Checking if crc-admin-helper executable is cached
INFO Checking if running on a supported CPU architecture
INFO Checking minimum RAM requirements
INFO Checking if crc executable symlink exists
INFO Checking if Virtualization is enabled
INFO Checking if KVM is enabled
INFO Checking if libvirt is installed
INFO Checking if user is part of libvirt group
INFO Checking if active user/process is currently part of the libvirt group
INFO Checking if libvirt daemon is running
INFO Checking if a supported libvirt version is installed
INFO Checking if crc-driver-libvirt is installed
INFO Checking crc daemon systemd socket units
INFO Checking if systemd-networkd is running
INFO Checking if NetworkManager is installed
INFO Checking if NetworkManager service is running
INFO Checking if /etc/NetworkManager/conf.d/crc-nm-dnsmasq.conf exists
INFO Checking if /etc/NetworkManager/dnsmasq.d/crc.conf exists
INFO Checking if libvirt 'crc' network is available
INFO Checking if libvirt 'crc' network is active
INFO Loading bundle: crc_libvirt_4.12.5_amd64...
CRC requires a pull secret to download content from Red Hat.
You can copy it from the Pull Secret section of https://console.redhat.com/openshift/create/local.
? Please enter the pull secret *************************************************************************************

INFO Creating CRC VM for openshift 4.12.5...
INFO Generating new SSH key pair...
INFO Generating new password for the kubeadmin user
INFO Starting CRC VM for openshift 4.12.5...
**** wait for good old 20 minutes. Then this ***
Error starting machine: Error in driver during machine start: Unable to determine VM's IP address, did it fail to boot?

View logs
# crc setup --log-level debug
DEBU CRC version: 2.15.0+cc05160
DEBU OpenShift version: 4.12.5
DEBU Podman version: 4.3.1
DEBU Running 'crc setup'
INFO Using bundle path /home/student/.crc/cache/crc_libvirt_4.12.5_amd64.crcbundle
DEBU Checking if systemd-resolved.service is running
DEBU Running 'systemctl status systemd-resolved.service'
DEBU Command failed: exit status 4
DEBU stdout:
DEBU stderr: Unit systemd-resolved.service could not be found.
INFO Checking if running as non-root
INFO Checking if running inside WSL2
INFO Checking if crc-admin-helper executable is cached
DEBU Running '/home/student/.crc/bin/crc-admin-helper-linux --version'
DEBU Found crc-admin-helper-linux version 0.0.12
DEBU crc-admin-helper executable already cached
INFO Checking if running on a supported CPU architecture
DEBU GOARCH is amd64 GOOS is linux
INFO Checking minimum RAM requirements
DEBU Total memory of system is<PHONE_NUMBER>0 bytes
INFO Checking if crc executable symlink exists
INFO Checking if Virtualization is enabled
DEBU Checking if the vmx/svm flags are present in /proc/cpuinfo
DEBU CPU virtualization flags are good
INFO Checking if KVM is enabled
DEBU Checking if /dev/kvm exists
DEBU /dev/kvm was found
INFO Checking if libvirt is installed
DEBU Checking if 'virsh' is available
DEBU 'virsh' was found in /usr/bin/virsh
DEBU Checking 'virsh capabilities' for libvirtd/qemu availability
DEBU Running 'virsh --readonly --connect qemu:///system capabilities'
DEBU Found x86_64 hypervisor with 'hvm' capabilities
INFO Checking if user is part of libvirt group
DEBU Checking if current user is part of the libvirt group
DEBU Current user is already in the libvirt group
INFO Checking if active user/process is currently part of the libvirt group
INFO Checking if libvirt daemon is running
DEBU Checking if libvirtd service is running
DEBU Running 'systemctl status virtqemud.socket'
DEBU Command failed: exit status 3
DEBU stdout: * virtqemud.socket - Libvirt qemu local socket
     Loaded: loaded (/usr/lib/systemd/system/virtqemud.socket; enabled; vendor preset: disabled)
     Active: inactive (dead)
   Triggers: * virtqemud.service
     Listen: /run/libvirt/virtqemud-sock (Stream)
DEBU stderr:
DEBU virtqemud.socket is neither running nor listening
DEBU Running 'systemctl status libvirtd.socket'
DEBU libvirtd.socket is running
INFO Checking if a supported libvirt version is installed
DEBU Checking if libvirt version is >=3.4.0
DEBU Running 'virsh -v'
INFO Checking if crc-driver-libvirt is installed
DEBU Checking if crc-driver-libvirt is installed
DEBU Running '/home/student/.crc/bin/crc-driver-libvirt version'
DEBU Found crc-driver-libvirt version 0.13.5
DEBU crc-driver-libvirt is already installed
INFO Checking crc daemon systemd service
DEBU Checking crc daemon systemd service
DEBU Checking if crc-daemon.service is running
DEBU Running 'systemctl --user status crc-daemon.service'
DEBU Command failed: exit status 3
DEBU stdout: * crc-daemon.service - CRC daemon
     Loaded: loaded (/home/student/.config/systemd/user/crc-daemon.service; static)
     Active: inactive (dead)
TriggeredBy: * crc-vsock.socket
             * crc-http.socket

Mar 26 09:56:49 crc2.example.com systemd[2233]: Starting CRC daemon...
Mar 26 09:56:49 crc2.example.com crc[8841]: level=info msg="using socket provided by crc-vsock.socket"
Mar 26 09:56:49 crc2.example.com crc[8841]: level=info msg="using socket provided by crc-http.socket"
Mar 26 09:56:49 crc2.example.com systemd[2233]: Started CRC daemon.

Mar 26 10:07:42 crc2.example.com systemd[2233]: Stopped CRC daemon.
DEBU stderr:
DEBU crc-daemon.service is neither running nor listening
DEBU Checking if crc-daemon.service has the expected content
INFO Checking crc daemon systemd socket units
DEBU Checking crc daemon systemd socket units
DEBU Checking if crc-http.socket is running
DEBU Running 'systemctl --user status crc-http.socket'
DEBU crc-http.socket is listening
DEBU Checking if crc-http.socket has the expected content
DEBU Checking if crc-vsock.socket is running
DEBU Running 'systemctl --user status crc-vsock.socket'
DEBU crc-vsock.socket is listening
DEBU Checking if crc-vsock.socket has the expected content
INFO Checking if systemd-networkd is running
DEBU Checking if systemd-networkd.service is running
DEBU Running 'systemctl status systemd-networkd.service'
DEBU Command failed: exit status 4
DEBU stdout:
DEBU stderr: Unit systemd-networkd.service could not be found.
DEBU systemd-networkd.service is not running
INFO Checking if NetworkManager is installed
DEBU Checking if 'nmcli' is available
DEBU 'nmcli' was found in /usr/bin/nmcli
INFO Checking if NetworkManager service is running
DEBU Checking if NetworkManager.service is running
DEBU Running 'systemctl status NetworkManager.service'
DEBU NetworkManager.service is already running
INFO Checking if /etc/NetworkManager/conf.d/crc-nm-dnsmasq.conf exists
DEBU Checking NetworkManager configuration
DEBU NetworkManager configuration is good
INFO Checking if /etc/NetworkManager/dnsmasq.d/crc.conf exists
DEBU Checking dnsmasq configuration
DEBU dnsmasq configuration is good
INFO Checking if libvirt 'crc' network is available
DEBU Checking if libvirt 'crc' network exists
DEBU Running 'virsh --connect qemu:///system net-info crc'
DEBU Checking if libvirt 'crc' definition is up to date
DEBU Running 'virsh --connect qemu:///system net-dumpxml --inactive crc'
DEBU libvirt 'crc' network has the expected value
INFO Checking if libvirt 'crc' network is active
DEBU Checking if libvirt 'crc' network is active
DEBU Running 'virsh --connect qemu:///system net-info crc'
DEBU libvirt 'crc' network is already active
INFO Checking if CRC bundle is extracted in '$HOME/.crc'
INFO Checking if /home/student/.crc/cache/crc_libvirt_4.12.5_amd64.crcbundle exists
DEBU /home/student/.crc/cache/crc_libvirt_4.12.5_amd64.crcbundle exists
Your system is correctly setup for using CRC. Use 'crc start' to start the instance

This looks like a nested virtualization setup, @jasonwcc any reason why don't you start crc directly on the windows using hyperV instead nested virtualization setup? We have close to no testing around nested virtualization side.

Actually, prior to this v4.12.5, the older version CRC all working wonderful over my nested virtualization using Vmware workstation. only this version pose this issue.
My company dictate that I am not supposed to use my local laptop windows to setup as hypervisor, hence the use of vmware workstaiton or virtual box as mean of testing and training.
Thank you and Warmest Regards
On Monday, March 27, 2023 at 01:29:53 PM GMT+8, Praveen Kumar<EMAIL_ADDRESS>wrote:

This looks like a nested virtualization setup, @jasonwcc any reason why don't you start crc directly on the windows using hyperV instead nested virtualization setup? We have close to no testing around nested virtualization side.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@jasonwcc what was the last crc version you tried and worked as expected?

Hi
following version: <IP_ADDRESS>.<IP_ADDRESS>.124.9.15
practically since 4.9.x to 4.11.x4.12.5 is the first version i cant use
Thank you and Warmest Regards
On Wednesday, March 29, 2023 at 03:51:18 PM GMT+8, Praveen Kumar<EMAIL_ADDRESS>wrote:

@jasonwcc what was the last crc version you tried and worked as expected?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@jasonwcc there is lot of things changes from each openshift release on OS level also (like kernel package updates) we are not sure what changed and not working for you. We also don't have any CI in place to do nested virtualization test for these kind of setup and mentioned in the doc.

Error starting machine: Error in driver during machine start: Unable to determine VM's IP address, did it fail to boot?

Most likely a VMware related issue. Without further info it is hard to determine the cause. Please try to add more info, such as console output.

I face exact the same issue with crc 2.13.1+3b466f8 on RHEL 9.1.
Similar issue found at https://github.com/crc-org/crc/issues/2397 which is not really fixed.  If I try multiple times and reboot my VM, it may succeed occasionally. But this is still an issue to me.
[myuser@myhost crc-linux-2.13.1-amd64]$ ./crc start -m 24000 -c 8 -d 100
WARN A new version (2.20.0) has been published on https://developers.redhat.com/content-gateway/file/pub/openshift-v4/clients/crc/2.20.0/crc-linux-amd64.tar.xz
INFO Checking if running as non-root
INFO Checking if running inside WSL2
INFO Checking if crc-admin-helper executable is cached
INFO Checking for obsolete admin-helper executable
INFO Checking if running on a supported CPU architecture
INFO Checking minimum RAM requirements
INFO Checking if crc executable symlink exists
INFO Checking if Virtualization is enabled
INFO Checking if KVM is enabled
INFO Checking if libvirt is installed
INFO Checking if user is part of libvirt group
INFO Checking if active user/process is currently part of the libvirt group
INFO Checking if libvirt daemon is running
INFO Checking if a supported libvirt version is installed
INFO Checking if crc-driver-libvirt is installed
INFO Checking crc daemon systemd socket units
INFO Checking if systemd-networkd is running
INFO Checking if NetworkManager is installed
INFO Checking if NetworkManager service is running
INFO Checking if /etc/NetworkManager/conf.d/crc-nm-dnsmasq.conf exists
INFO Checking if /etc/NetworkManager/dnsmasq.d/crc.conf exists
INFO Checking if libvirt 'crc' network is available
INFO Checking if libvirt 'crc' network is active
INFO Loading bundle: crc_libvirt_4.12.0_amd64...
CRC requires a pull secret to download content from Red Hat.
You can copy it from the Pull Secret section of https://console.redhat.com/openshift/create/local.
? Please enter the pull secret ****************************************************************************************************************************************************************
INFO Creating CRC VM for openshift 4.12.0...
INFO Generating new SSH key pair...
INFO Generating new password for the kubeadmin user
INFO Starting CRC VM for openshift 4.12.0...
Error starting machine: Error in driver during machine start: Unable to determine VM's IP address, did it fail to boot?

At this point 4.12.0 is quite old, any chance you could try a newer version? Either the latest release with a 4.12.x bundle, or the latest release which ships with OpenShift 4.13?
And is this with nested virtualization?

Hey,
same issue here but with a differente problem apprach.
What I'm running :

A latest fedora 40VM vm in a ESXII77 (the vm has nested virtualziaicon applied in ESXII config)
Crc version by the moment:  2.39.0+0849cb
Openshift version:  4.16.0
libvirtd version: 10.1.0
dnsmasq version 2.90
hostname of the vm: localhost

I have found the problem is related with the service libvirtd as is shown in the following exmaple:

I run crc start and I get this:

crc start --log-level debug
DEBU CRC version: 2.39.0+0849cb
DEBU OpenShift version: 4.16.0
DEBU Running 'crc start'
DEBU Total memory of system is<PHONE_NUMBER>2 bytes
DEBU No new version available. The latest version is 2.39.0
DEBU Checking file: /home/user/.crc/machines/crc/.crc-exist
DEBU Found binary path at /home/user/.crc/bin/crc-driver-libvirt-amd64
DEBU Launching plugin server for driver libvirt
DEBU Plugin server listening at address <IP_ADDRESS>:40199
DEBU () Calling .GetVersion
DEBU Using API Version 1
DEBU () Calling .SetConfigRaw
DEBU () Calling .GetMachineName
DEBU (crc) Calling .GetBundleName
DEBU (crc) Calling .GetState
DEBU (crc) DBG | time="2024-07-25T19:12:15+02:00" level=debug msg="Getting current state..."
DEBU (crc) DBG | time="2024-07-25T19:12:15+02:00" level=debug msg="Fetching VM..."
DEBU Making call to close driver server
DEBU (crc) Calling .Close
DEBU (crc) DBG | time="2024-07-25T19:12:15+02:00" level=debug msg="Closing plugin on server side"
DEBU Failed to make call to close driver server: unexpected EOF
DEBU Making call to close connection to plugin binary
DEBU Checking file: /home/user/.crc/machines/crc/.crc-exist
INFO Loading bundle: crc_libvirt_4.16.0_amd64...
DEBU Checking file: /home/user/.crc/machines/crc/.crc-exist
DEBU Found binary path at /home/user/.crc/bin/crc-driver-libvirt-amd64
DEBU Launching plugin server for driver libvirt
DEBU Plugin server listening at address <IP_ADDRESS>:32901
DEBU () Calling .GetVersion
DEBU Using API Version 1
DEBU () Calling .SetConfigRaw
DEBU () Calling .GetMachineName
DEBU (crc) Calling .GetBundleName
DEBU (crc) Calling .GetState
DEBU (crc) DBG | time="2024-07-25T19:12:16+02:00" level=debug msg="Getting current state..."
DEBU (crc) DBG | time="2024-07-25T19:12:16+02:00" level=debug msg="Fetching VM..."
INFO A CRC VM for OpenShift 4.16.0 is already running
DEBU Making call to close driver server
DEBU (crc) Calling .Close
DEBU (crc) DBG | time="2024-07-25T19:12:16+02:00" level=debug msg="Closing plugin on server side"
DEBU Failed to make call to close driver server: unexpected EOF
DEBU Making call to close connection to plugin binary
Started the OpenShift cluster.
INFO Loading bundle: crc_libvirt_4.16.0_amd64...
INFO A CRC VM for OpenShift 4.16.0 is already running
Started the OpenShift cluster.

The server is accessible via web console at:
  https://console-openshift-console.apps-crc.testing

Log in as administrator:
  Username: kubeadmin
  Password: 123456789

Log in as user:
  Username: developer
  Password: developer

Use the 'oc' command line interface:
  $ eval $(crc oc-env)
  $ oc login -u developer https://api.crc.testing:6443

In other terminal check for libvirtd service logs (localhost is the name of the fedora40 machine)

 sudo journalctl -u libvirtd -f
Jul 25 19:10:44 localhost systemd[1]: Starting libvirtd.service - libvirt legacy monolithic daemon...
Jul 25 19:10:45 localhost systemd[1]: Started libvirtd.service - libvirt legacy monolithic daemon.
Jul 25 19:11:03 localhost libvirtd[1781]: libvirt version: 10.1.0, package: 3.fc40 (Fedora Project, 2024-07-09-11:57:17, )
Jul 25 19:11:03 localhost libvirtd[1781]: hostname: localhost
Jul 25 19:11:03 localhost libvirtd[1781]: End of file while reading data: Input/output error
Jul 25 19:11:03 localhost libvirtd[1781]: End of file while reading data: Input/output error

There is a relation between everytime I run crc start with a new errror of: Jul 25 18:53:20 localhost libvirtd[4632]: End of file while reading data: Input/output error

I have trid to restart the libvirtd service  and de dnsmasq service, but still not workking.

@valkiriaaquatica nested virtualization is something not tested by us also as per logs I can see that cluster is already running so I am not sure what is the issue you are facing can you delete the cluster and provide the output of following commands (may be in a gist)
$ crc delete
$ crc setup --log-level debug
$ crc start --log-level debug
$ sudo cat /var/log/libvirt/qemu/crc.log


Render a simple mesh

We left master in a broken state during last friday's refactoring session; let's get it to the point where can render a simple mesh again.

In #6 I (more or less) have the triangle working again. But need some more work to get meshes working. Would you like me to split this up so we have a working master sooner?

That would probably be a good idea :)

reopening: not there yet :)

We can now render a mesh in one color or with a texture. No lighting yet. Let's track that in #29


I'm being asked to remind you to update the app via github (https://github.com/visnkmr)

When I opened the wireless file manager app it's saying the version of app I have installed is 2.3A6i.
Today's date as per your device is 29 November 2023
Your are seeing this message because
-your device time is incorrect
If your device time is correct.

Then you are using an obselete(very old) version of the app; check for app updates on github (https://github.com) or Appstore via the update button below.

If no app updates are available; It seems we have forgotten about the app.
This is the reminder I'm sending you to please fix this problem as soon as possible.

Hey,
Sorry for the late reply.
The update has been pushed to amazon appstore as of 2 weeks ago and should be available soon, if you so prefer you can also download from our appstore/github @
https://vnkappstore.vercel.app/details/Wireless File Manager
https://visnkmr.github.io/appstore/details/Wireless File Manager
https://github.com/visnkmr/wfm/releases
Thanks.


fix: build on ios

I'm really sorry, but as mentioned in #9, I didn't have any macOS devices to test my PR. It looks like I missed a Copy&Paste error which breaks iOS builds..
This PR fixes it (tested on an iPhone)

Thank you for your hard work. Version 1.3.1 has been released.


install-chef-suse: Remove setting REPOS_SKIP_CHECKS env var for DEPS iso

We don't check these repos in this script anymore.

There are some references here:
https://github.com/vuntz/crowbar/blob/no-repos-skip/scripts/install-chef-suse.sh#L416

There are some references here:
https://github.com/vuntz/crowbar/blob/no-repos-skip/scripts/install-chef-suse.sh#L416

But they're only for PTF repos, not for Pool/Updates. Maybe the commit message needs to be clearer?

Ah OK, is only dropping the extension of this in the media

+1

+1


Show browser warning banner for ie10 and below

Currently, we show a "not supported" banner for users on ie9 and under.  I suggest we update this to ie10 and below because a) there are very few ie10 users, and b) microsoft ended support for this a while ago
The code for changing this is here: https://github.com/pypa/warehouse/blob/master/warehouse/templates/base.html#L100

Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, please work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, please feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.

Hi Nicole!
@ewdurbin and I just spent some time pairing on this and have a solution in mind that should work. However, we have problems testing it on an IE10 browser. Do you have suggestions for a testing workflow we can use? Thanks so much!
-Janice

@nlhkabu @ewdurbin perhaps you could could request free testing from Crossbrowsertesting.com for this project, since it is open source.

hi @contrepoint - we are in the process of applying for an open source account with BrowserStack.  In the meantime, if you want to make a PR, I can test it with my personal account?

Can close now. :)


Scan folder on click

Hi there,
EDIT: It seems I was wrong sorry, but folders are indeed removed from the Taskbar if they came from Google Drive or something that launches after Cairo (on PC startup.)
Thanks,
Keep up the good work.

Do you mean the folder stacks in the menu bar at the top of the screen? Which version of Cairo are you running?

Closing per update above.


can't install monaco-languageclient using pnpm

Hi there! I'm trying to install monaco-editor-wrapper using pnpm, and since monaco-languageclient is a dependency, it's installs it and tries to execute the postinstall script:
https://github.com/TypeFox/monaco-languageclient/blob/05923623781bd4bd21e895a0e9310fca5719300e/packages/client/package.json#L69
But it appears that an error occurs while doing so:
$ pnpm add monaco-editor-wrapper
...
node_modules/.pnpm/monaco-languageclient<EMAIL_ADDRESS>Running postinstall script...
 ELIFECYCLE  Command failed.

Even when trying to install monaco-languageclient by it's own:
$ pnpm add monaco-languageclient
...
node_modules/.pnpm/monaco-languageclient<EMAIL_ADDRESS>Running postinstall script...
 ELIFECYCLE  Command failed.

I'm not sure if I should report the issue to pnpm team or to you guys, please let me know if I should ask pnpm team about it.
Thanks!

Hi @Yokozuna59 are you aware of this pnpm verification example?
https://github.com/TypeFox/monaco-languageclient/blob/main/packages/verify/pnpm/package.json
pnpm like yarn have problems with using peerDependencies if they are not defined as regular dependencies (see here an explanation: https://github.com/TypeFox/monaco-languageclient/issues/524#issuecomment-1683453842). So you need to define them as regular dependencies.

@kaisalmen I see, thanks.


tools: fix get kubectl logic for arm64 downloads

Signed-off-by: Edward Vielmetti<EMAIL_ADDRESS>
Description

Adds logic to the tools.go to get the correct kubectl binary for arm64 systems.
Motivation and Context

[x] I have raised an issue to propose this change (required)

Fixes #418 .
How Has This Been Tested?

Tested on an arm64 system, which correctly downloads the right
binary after this patch is applied.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I've read the CONTRIBUTION guide
[x] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

[x] I have tested this on arm, or have added code to prevent deployment

Thanks for the PR.
Are you using an ARM64 desktop/client, or are you logging into your Kubernetes nodes in order to run these tools?

@alexellis
Systems I am testing on include

Windows on Arm laptop with WSL using Ubuntu 20.04 (linux/arm64) - client
Jetson Nano using Ubuntu 20.04 (linux/arm64) - client and server using kind for arm64
ThunderX using Ubuntu 20.04 (linux/arm64) - server using kind for arm64

The future system I am looking forward to is a Mac with the M1 chip, don't have one
of those yet.


Problems with activation

I have installed both PLM Pack and stack  builder on Windows 8 machine without any issues. Received activation codes on my email and managed to test the software. Later on I have tried installing same software on Windows 7 machine and got to the activation window stage - user name was already chosen, typed in my email address and organisation name but the next button is still greyed out. To troubleshoot the problem I uninstalled the software on Windows 8 and tried to install it again thinking I must have done something else during installation, but now I am getting the same issue. Cannot send a 'request' for activation codes. What am I doing wrong?

Hello
As far as i am aware you can reuse the same key on multiple installations.
Met vriendelijk groet,
Dipak Kumar.
2017-03-09 13:18 GMT+01:00 MarcinRumia<EMAIL_ADDRESS>
I have installed both PLM Pack and stack builder on Windows 8 machine
without any issues. Received activation codes on my email and managed to
test the software. Later on I have tried installing same software on
Windows 7 machine and got to the activation window stage - user name was
already chosen, typed in my email address and organisation name but the
next button is still greyed out. To troubleshoot the problem I uninstalled
the software on Windows 8 and tried to install it again thinking I must
have done something else during installation, but now I am getting the same
issue. Cannot send a 'request' for activation codes. What am I doing wrong?
[image: capture]
https://cloud.githubusercontent.com/assets/26301583/23749920/d46b9284-04ca-11e7-9288-f02cb97b6c34.PNG
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/treeDiM/StackBuilder/issues/77, or mute the thread
https://github.com/notifications/unsubscribe-auth/AKYIxjbPpc9g7KtezZqRG6jM5kl4biMeks5rj-4igaJpZM4MYApy
.

Hello
As far as i am aware you can reuse the same key on multiple installations.
just tried it and it let me click next

Met vriendelijk groet,
Dipak Kumar.

You should have sent an email at the following address<EMAIL_ADDRESS>The autoresponder then sends you an email back with your key, that you copy in the field.
Anyway, the installation key for StackBuilder 2 is: FX15VR70ZH07


CSIP structure

CSIP structure (chapter 4, pages 31-35) The duplication of a logical and a physical structure (that should, but do not need to match each other exactly) might need to be better explained. Some colleagues felt that the Common Specification should not make any rules about the physical storage structure.

Connected to overall comment https://github.com/DILCISBoard/GroupDocumentation/issues/13

This has already been changed.


TypeScript and JavaScript organize imports

Add support for TypeScript organize imports command. This command:

Sorts imports
Remove unused imports
Other?

Also look into the typescript sort imports extension (https://marketplace.visualstudio.com/items?itemName=miclo.sort-typescript-imports) which gives great deal of control over sorting and grouping order.


Removing Alloys causes script error during /mt reload

I mentioned this in https://github.com/jaredlll08/ModTweaker2/issues/17#issuecomment-70767121, but when I try to remove an alloy recipe, it both doesn't remove the original recipe, as well as after doing a /mt reload, throws a null pointer exception.  Just as bad, after I do a /mt reload, the new recipe doesn't even show up because the script breaks.

Did you try a jenkins build?

We actually pulled down the latest from GitHub and built it manually since we don't have access to the jenkins.  The build was from about a day or so ago.

@jaredlll08 you never made a commit anywhere, how is it fixed?

I thought I fixed it. I am suspecting it is a problem with the script HOWEVER I did insert a check to make sure that the liquid being removed actually exists

and I cant always commit!

The original issue of the removeMelting() method call sends to be working fine now, but now I'm having an issue on the removeAlloy() method call; if that clarifies anything.

I and a friend are having the same problem. Java reports an error with the .zs-file followed by a stack trace from a null pointer exception. We are also trying to remove an alloy from TConstruct using the line:
mods.tconstruct.Smeltery.removeAlloy(<liquid:angmallen.molten>);
The error occurs when we run /mt reload. The main difference is that we're not trying to add the alloy back. But I thought I'd report it here since we're also failing at removing an alloy. We're using version 2.0.6, latest release.

@froghouse could you test it with the latest version?

So the new version doesn't throw the error anymore, but it's also not removing the alloys correctly. The initial load still shows the old and new recipes, but when I do a /mt reload, it doesn't error, but then only has the original alloy recipe, rather than the new one.

@jaredlll08 shall look into it.

Undead, remind me today to test it in the rewritten version xD

Oh, has it been possibly fixed?  Sure, you can go ahead and test it if you'd like, otherwise if I have some free time I'll see what I can find.

In the rewritten version it doesn't throw a null pointer anymore, however, it does nothing. With the script from the wiki I cannot remove Manyullin's alloy recipe. @jaredlll08 !

That's what I recall happening when I took a look a few weeks ago.

The problem was, you had to use the EXACT fluid amount, for example:
mods.tconstruct.Smeltery.removeAlloy(liquid:manyullyn.molten*16);

I have fixed this now :)

Yeah, I saw Joshie's comment on the other thread.  Once I get the chance, I'll pull down the latest and run some tests.


preventDefault and stopPropagation support

There is currently neither a first-class way to do preventDefault and stopPropagation nor a good workaround (via e.g. ports).
See https://groups.google.com/forum/#!topic/elm-discuss/W3X_m1mE70w for a motivating use case.

Check it out! http://package.elm-lang.org/packages/evancz/elm-html/4.0.0/Html-Events#onWithOptions


Appending the SHA to the version number doesn't work

Doesn't work in the new TypeScript version of the Action.

Ultimately fixed in a745603eef443621976df401f45aaff4d849056b.


Generating align attribute for th and td tags is invalid HTML

I read through https://github.github.com/gfm/#example-199 and #145 to understand a bit better and I'm not sure what's the best course of action here: the HTML spec for td (and th just below) don't like align as a valid attribute.
For more context, I discovered this issue when working on https://github.com/rust-lang/rust/pull/84480. The goal is to check that rustdoc generated pages are completely valid by using tidy. The problem is that it's an invalid attribute because not listed in the spec. The solution would be to rename align into data-align. However, the browsers are using this attribute to change the content display. So maybe the best thing to do is to simply ignore this warning and keep things as is... If so, please just close the issue.

I have this problem in a zola generated site.
The correct property seems to be "text-align".
https://www.w3schools.com/Css/css_table_align.asp

Yeah, it's tricky, because indeed this should be done using the css property text-align, but if we'd set that inline, I think we would override other css rules. Inline css isn't great in any case. An alternative would be to set data-align as Guillaume suggested, but then it wouldn't display correctly without any css. I'm not sure what the best solution is here..

I don’t understand what using 'text-align' would break.
If I use ':----' syntax, I want to align my columns left. I want it to override the default 'text-align'.
Since colgroup are very limited in style, it has to be inline, direct or class. [1]
'align', which does not work, is already inlined. It just needs to be replaced with 'text-align'
[1] Knowing align in advance, with a table id (generated by pulldown-cmark) and nth-child, it might be possible to not inline it.
Something like :
#cmarkid001 tr :nth-child(2) {
  text-align: center;
}

You've convinced me that indeed inline CSS is the way to go. I've created a pull request to make the change.

This has been fixed!


Added Support for Structured Bindings

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]
   for (auto const& [key,value] : json.items())
   {
      std::cout << "key: " << key << ", value: " << value << '\n';
   }

For further details, read #1388 and https://blog.tartanllama.xyz/structured-bindings/
Structured Bindings help simplify writing code and using this library greatly especially given the way they are implemented in C++17 and the addition of the items function.
The method of implementation ensures that Structured Bindings implementation can also be added in projects using C++11 with only C++17 being able to reap the benefits.

Pull request checklist
Read the Contribution Guidelines for detailed information.

[ ]  Changes are described in the pull request, or an existing issue is referenced.
[ ]  The test suite compiles and runs without error.
[ ]  Code coverage is 100%. Test cases can be added by editing the test suite.
[ ]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header file single_include/nlohmann/json.hpp. The whole process is described here.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for these kind of bugs). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

   for (auto const& [key,value] : json.items())
   {
      std::cout << "key: " << key << ", value: " << value << '\n';
   }

Is probably same as
   for (auto const& elem : json.items())
   {
      auto const key = elem.get<0>();
      auto const value = elem.get<1>();
      std::cout << "key: " << key << ", value: " << value << '\n';
   }

In generic context, one would always use std::get<0>(...), especially to avoid writing j.template get<0>()

Coverage remained the same at 100.0% when pulling f6e5e40b43b5725b9996f257611b886faf8c46ce on pratikpc:develop into e73dfef6e51b876cbfd8fadb8b6a1771a196b6e8 on nlohmann:develop.

I just pushed a commit on my fork which is still a wip, but the basic use-case works (with non-member get functions).
I had to move out iteration_proxy_internal outside of iteration_proxy to be able to partially specialize tuple_size and tuple_element (otherwise, only nlohmann::json would support structured bindings, not different instances of nlohmann::basic_json<...>).
There might be some refactoring to be done with iteration_proxy/_internal, I'd like to know what @nlohmann thinks about it, I do not know that part of the code very well.
Also, I have not tested edge-cases yet...
@pratikpc What do you think about incorporating my changes in your PR? We can work out the remaining details if you want :)

@pratikpc What do you think about incorporating my changes in your PR? We can work out the remaining details if you want :)

That's a superb change.
Making it public and independent of iteration_proxy kills of all the problems we were facing.
I am all for it.
In the commit we can possibly push the get function to the std namespace as well
namespace std
{
   // structured bindings support
   template <std::size_t N, typename IteratorType, enable_if_t<N == 0, int> = 0>
   auto get(const nlohmann::detail::iteration_proxy_internal<IteratorType>& i) -> decltype(i.key())
   {
      return i.key();
   }

   template <std::size_t N, typename IteratorType, enable_if_t<N == 1, int> = 0>
   auto get(const nlohmann::detail::iteration_proxy_internal<IteratorType>& i) -> decltype(i.value())
   {
      return i.value();
   }
}

Although I still believe we need to know @nlohmann 's views regarding that.

@theodelrieu the commit broke a Unit Test.
Specifically the test-regression
One way to correct it is to add a Constructor in Basic Json class which accepts iteration_proxy_internal as an argument
template<typename Iterator>
basic_json(detail::iteration_proxy_internal<Iterator> other) : basic_json{ other.value() }
{}

However, my belief is that this is a temporary fix
The error I faced was
[2018-12-13 07:41:19] [build] /usr/include/c++/7/bits/stl_algo.h:5337:16: error: no match for ‘operator=’ (operand types are ‘std::insert_iterator<nlohmann::basic_json<> >’ and ‘nlohmann::detail::iteration_proxy_internal<nlohmann::detail::iter_impl<nlohmann::basic_json<> > >’)
Also faced here at LGTM

Oops, my bad, I only tested unit-items.cpp......

In the commit we can possibly push the get function to the std namespace as well

That's illegal unfortunately, the get methods are where they should be, i.e. in the same namespace as the class.
I will make the code work on my box and let you know when I push!

That's illegal unfortunately, the get methods are where they should be, i.e. in the same namespace as the class.

Oh.
I thought it would be fine if they were kept in std namespace.
Because Structured Bindings still works on GCC and MSVC

I will make the code work on my box and let you know when I push!
The unit-tests now no longer fail after adding the Constructor.
But yes, finding a more permanent solution would be a good idea for us all.

I would add a commit which shifts get back into the namespace as before

I just push-forced on my fork, the fix was in conversions/to_json.hpp as you can see.
I've added a test with a custom basic_json alias as well, if you have other tests in mind do not hesitate to add them :)

I thought it would be fine if they were kept in std namespace.

You can see the rules from cppreference

@theodelrieu I can't find the changes.
Did you make them at https://github.com/theodelrieu/json/blob/feature/structured_bindings/include/nlohmann/detail/conversions/to_json.hpp

It is still in namespace detail, so the current name does not annoy me that much. Need @nlohmann's input on this one.
I do think the PR is complete, could you squash your commits?

@theodelrieu how does one squash a commit exactly???

First, do not forget to run make amalgamate and commit the result.
Once this is done, run git rebase -i develop. It will open a prompt.
Then, keep the first line as-is, and replace pick in all the others by fixup.
Save and quit, then git push --force.

@theodelrieu thanks!!!

@theodelrieu The following tests FAILED:
80 - test-unicode_all (Timeout)
On Appveyor
Does this mean we have to start the process again?

I’ll restart.

Appveyor seems to work now. :)

I am traveling right now, so I won’t be able to check before next week. But anything that brings us closer toward support of structured bindings is greatly appreciated!

Thanks so much!


Consider adding OverflowList component

@lu-perfect Moved this issue to the components repo. Draft name: LabelList


remove unnecessary temporary variable

remove unnecessary temporary variable

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "temvarible" git@github.com:mqliang/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

Thanks @mqliang, looks like you forgot to sign-off your commit. Can you fix that, using the steps that @GordonTheTurtle described above?

LGTM once signed.

@thaJeztah @aaronlehmann signed.

LGTM

Thanks for another contribution @mqliang !


Watchdog reset fail because state is off()

2018-08-27T02:40:25.248808+00:00 app[web.1]: 10:40:25 SILL StateSwitch <Wechaty> on() is true
2018-08-27T02:40:33.155426+00:00 app[web.1]: 10:40:33 SILL Puppet constructor() watchdog.on(reset) reason: {"data":"ws.on(message)","timeout":240000}
2018-08-27T02:40:33.155605+00:00 app[web.1]: 10:40:33 SILL Puppet constructor() this.on(reset) reason: {"data":"ws.on(message)","timeout":240000}
2018-08-27T02:40:33.155788+00:00 app[web.1]: 10:40:33 SILL Puppet constructor() resetThrottleQueue.subscribe() reason: {"data":"ws.on(message)","timeout":240000}
2018-08-27T02:40:33.155866+00:00 app[web.1]: 10:40:33 VERB Puppet reset({"data":"ws.on(message)","timeout":240000})
2018-08-27T02:40:33.156000+00:00 app[web.1]: 10:40:33 SILL StateSwitch <PuppetPadchat> off() is pending
2018-08-27T02:40:33.156125+00:00 app[web.1]: 10:40:33 VERB Puppet reset({"data":"ws.on(message)","timeout":240000}) state is off(), do nothing.
2018-08-27T02:40:35.253789+00:00 app[web.1]: 10:40:35 SILL StateSwitch <Wechaty> on() is true

Related to: https://github.com/caiyunapp/caiyun-wechaty/issues/16

It seems this is because when we are recovering from the WebSocket reset, there's some problem caused we set state.off(true) which should not.

@zixia Could you provide more logs for this issue? From the logs that you pasted above, it is not clear whether this is the first time reset get called or not. If not, then the behavior is expected.

Yes we need more log.
This log is come from caiyun, I have no more but let's keep a eye on this kind of problems in the future.

I agree with you that this should not happen if this is the first time calling reset().
But if this is not the first time calling reset(), then the state is off makes some sense here. It means the reset process is stuck half way somewhere, and we do not want to do reset() anymore since there is one ongoing or failed (Well, in this case, still bug :P ).
Anyway, let's keep an eye on this problem.


Restore compatibility with older versions of regex

If applied, this PR will make flanker able to run with versions of regex older than 2017.07.xx.

Can one of the admins verify this patch?

@b0d0nne11 tests seems to be passing. I have no objections.


Switched to ArrayDeque in RntbdClientChannelPool.

This is just a first attempt to start a discussion. Is it really a good idea to remove the concurrent dequeue here?
If it's used just in one thread - it seems so - it should be safe. But it's a public API.
ConcurrentDeque has a non constant cost for size() and concurrency is not required. ArrayDeque is faster and uses less memory.
Fixes https://github.com/Azure/azure-sdk-for-java/issues/33982
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

@xinlian12 - please take a look at this change as well. I agree - don't think we need a thread-safe data structure - all access is from single netty io thread.

@mkrueger - it is public API - but within the implementation package - which is not exported and not part of the public surface area. Kind of the equivalent of internal API in a .net assembly.

Removed the log output usage.


python

Expected Behavior

Actual Behavior

Your FULL config.json (remove your username, password, gmapkey and any other private info)

Output when issue occurred

Steps to Reproduce

Other Information
OS:

Branch:

Git Commit:

Python Version:

Any other relevant files/configs (eg: path files)

Short Description

Possible solution

How it would help others

What is this?


Fix undefined temporary environment restoring issue

Close #1448
Signed-off-by: Tw<EMAIL_ADDRESS>

The reason for the failure below
--- FAIL: TestEPM (0.03s)
    --- FAIL: TestEPM/use_epm (0.03s)
        epm_test.go:13: unexpected exception
        epm_test.go:13: got: vals.cannotConcat: cannot concatenate nil and string
        epm_test.go:13: stack trace: []string{"$E:XDG_DATA_HOME/elvish/lib", "use epm"}
        epm_test.go:13: want: <nil>

is that $E:XDG_DATA_HOME doesn't exist, It returned "" before, but now nil.
This is what I want to ask: do we need to make this compatible or introduce a breaking change when retrieving a non-exist environment variable?

This is what I want to ask: do we need to make this compatible or introduce a breaking change when retrieving a non-exist environment variable?

I can't speak for the project owner, @xiaq, but I believe the current behavior is incorrect and your change introduces correct behavior. At least in so far as expanding a non-existing environment variable should be a fatal error. The current behavior (expanding to an empty string) is a source of security bugs, or at least surprising behavior. The current behavior is probably inherited from POSIX shells where expanding a variable that doesn't exist produces an empty string rather than an error unless the "-u" (or "no_unset") option is enabled.
Your change identifies a bug: the bundled epm module assumes that $E:XDG_DATA_HOME exists. That module should instead use has-env XDG_DATA_HOME rather than not-eq $E:XDG_DATA_HOME ''.

Agree with you @krader1961 . Mind I opening a PR to fix it?

I'm going to have to retract my earlier LGTM. That's because this change causes expansion of a non-existent env var to return $nil rather than an empty string. I believe it should instead raise the same exception that get-env does when given a non-existent env var name. In other words, the two cases should behave identically and both should raise an exception. The current behavior for $E: expansion of non-existent env vars substituting an empty string is a source of unexpected behavior (aka bugs). Replacing the empty string with $nil as this P.R. does is an improvement but inconsistent with get-env and how every other undefined var dereference is handled.

Thanks for the PR, it does fix the bug, but I don't really like the idea of getting a $nil for non-existent environment variables. It should either evaluate to more reasonable useful default value (the current behavior) or throw an exception (what @krader1961 proposed).
Moreover, this will break code that tests whether an environment variable is unset or empty silently; eq $E:VAR '' currently outputs $true if $E:VAR is unset, but with the change in this PR it will output $false instead.
Getting back to whether E:NONEXISTENT_VAR should throw an exception, I am in favor of the current behavior of evaluating to an empty string. It's true this perpetuates a sloppy behavior inherited from earlier shells. But this sloppy behavior is now ingrained in the ecosystem - most scripts and programs that handle environment variables do not distinguish unset vs empty [1]. So it makes more sense for Elvish to play along than to try to fix the problem. There is always get-env anyway if one wishes to make that distinction.
[1] If someone has evidence that shows otherwise I'd be happy to be proven wrong, and consider making $E:NONEXISTENT_VAR throw an exception instead.

most scripts and programs that handle environment variables do not distinguish unset vs empty

That's certainly true for POSIX scripts but is it true for Elvish scripts? And to the extent that Elvish scripts rely on the current behavior I would argue that is only due to the different behavior between $E:NONEXISTENT_VAR and get-env NONEXISTENT_VAR. If both forms threw an exception we would, obviously, see every Elvish script use has-env if they wanted to protect against an env var not being set. Having said all that I'm inclined to agree the $E:... form should retain its current behavior of expanding to an empty string if not set but that behavior should be documented (it is for get-env but not $E:...). I'll open a documentation P.R. in a few minutes.
@tw4452852, Hopefully you'll rework your fix to retain returning an empty string for an unset env var and open a new P.R.

Hi @xiaq
Yes, I agree with you about the current decision on $E:NONEXIST due to the compatibility. Maybe I will work out another approach to fix the original issue.
@krader1961
Of couse.


python3Packages.bidict: overwrite bundled pytest.ini

Overwrite the bundled pytest.ini instead of calling pytest with -c /dev/null to bypass it.
For some reason the latter suddenly started failing with a PermissionError on Darwin after working fine for the last 11 days.
Fixes #299933

Please reword commit (and pr title) to something like python3Packages.bidict: overwrite the bundled pytest.ini

Thanks @Aleksanaa, done in the latest revision.

All checks passed and I think this is ready to merge, but I don't have permission to merge it.

I have asked for help here
If there isn't any response, I will try the discourse method suggested here

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3738

@ofborg build python311Packages.bidict


add target dependencies for apple m1

i build servo on my apple m1 macbook, but got error error[E0463]: can't find crate for 'objc'  when compile surfman, so i add the target dependencies for apple m1.
i have already build passed and tested on my m1 macbook with command:
cargo build -p surfman
cargo test --lib

@bors-servo r+
Thanks!

:pushpin: Commit 6670ffd has been approved by jdm

:hourglass: Testing commit 6670ffd8c881939914528b2c99ab82d641c11300 with merge 8dba5ea6235bf7e884a86d79acec05c54325d1aa...

:boom: Test timed out

@bors-servo retry

:hourglass: Testing commit 6670ffd8c881939914528b2c99ab82d641c11300 with merge 3443ff7b16528e905de7bd8cf71751b022adb9b5...

:sunny: Test successful - checks-travis
Approved by: jdm
Pushing 3443ff7b16528e905de7bd8cf71751b022adb9b5 to master...


add an index or overview notebook for binder.

The current README markdown badge link points to overview/fundamental-path/index.ipynb:
https://mybinder.org/v2/gh/xarray-contrib/xarray-tutorial/HEAD?labpath=overview/fundamental-path/index.ipynb
The link can be modified to point at other notebooks in the repo like overview/intermediate-path/index.ipynb


efm8 support

Why support them
The efm8 series of 8051 microprocessors by Silicon Labs are probably the cheapest, smallest and simplest FS USB capable micoprocessors on the market. Some highlights include:

Power directly from USB 5V with internal regulator.
The only external components necessary for FS USB support are 4 decoupling capacitors.
Preloaded USB HID bootloader
In volume they can be potentially be purchased for about 1USD.
Smallest package is a 3x3mm QFN20 with 13 GPIO
Also come in 24-QSOP, 32QFN, 32QFP, 48QFP
Flash sizes range from 8-64kB.
8051 based core runs at 48MHz.
UART, SPI, I2C

Feature support
The efm8 series would be best suited for USB only keyboards, but could also support I2C split and maybe nRF24 receiver mode. Battery mode would probably not be implemented for efm8.
According to Silcon Lab's documentation, their USB SDK can be compiled with SDCC. So it should be quite easy to add support.
Progress

[X] USB communication working
[X] Reading/Writing layouts
[X] EFM8 factory bootloader support in GUI
[x] Handle shared HID descriptors for media, nkro and mouse control.
[x] Matrix scanning

References

efm8ub1 (harder to support, since they only have max 16kB flash)
efm8ub2 (32-64kB, QFN32, QFP32, QFP48)
efm8ub3 (40kB, QFN20, QSOP24, QFN24)
c8051f380 (Note: older more expensive, no bootloader from factory, but can sink 100mA on IO pins and 5 PWM pins)

Hi,
SILabs EOL'd one of these parts today:
https://www.silabs.com/mcu/8-bit-microcontrollers/efm8-universal-bee/device.efm8ub31f40g-qfn24
Also, the UB2 is a C8051F38x part, with different printing on the outside.


Browsing Files: Back doesn't work properly and rotating the device causes the list to go to the begining.

I am working on fixing this bug


Update to fc with logger fix - 1.8.x

Change Description

Update to include https://github.com/EOSIO/fc/pull/103

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[x] Documentation Additions

Documentation should describe SIGHUP logging behavior now that it works reliably.


Typescript Build fails

Typescript build fails.
To Reproduce
Steps to reproduce the behavior:

npm run deploy:twilio-cli

Expected behavior
build should succeed without any errors
Screenshots
/apps/twilio-video-app-react/src/hooks/useScreenShareParticipant/useScreenShareParticipant.tsx
TypeScript error in /Users/hannad/workspace/apps/twilio-video-app-react/src/hooks/useScreenShareParticipant/useScreenShareParticipant.tsx(18,11):
Argument of type 'Participant | undefined' is not assignable to parameter of type 'SetStateAction<undefined>'.
  Type 'Participant' is not assignable to type 'SetStateAction<undefined>'.
    Type 'Participant' provides no match for the signature '(prevState: undefined): undefined'.  TS2345

    16 |       const updateScreenShareParticipant = () => {
    17 |         setScreenShareParticipant(
  > 18 |           Array.from<Participant>(room.participants.values())
       |           ^
    19 |             // the screenshare participant could be the localParticipant
    20 |             .concat(room.localParticipant)
    21 |             .find((participant: Participant) =>

Environment (please complete the following information):

OS: [mac os 10.15.3]
Node.js version: [v12.16.1]

Thanks @hannadrehman! This does appear to be an issue. We're about to get a fix merged in.


Feat: validation on both server and client

Single source of JSON schema for server- and client-side validation:

[x] json-schema in .json form
[x] server-side postgraphile plugin for validation
[x] client-side rjsf feature to validate multiple forms on the click of one button
[x] tests

@pbastia just a couple of small optional improvements, and a question re. using forwardRef

@pbastia I see some failing unit tests, looks good otherwise


[Question] It is possible to disable SCP?

First of all, thank you for this very useful project, kudos!
For my PhD work I need to get some "real" payload for some of the procedures, therefore the idea is to run the core network, and capture some traffic over the docker bridge interface.
So far I managed to run the sa-deploy.yaml along with the UERANSIM gNB and UE and captured some data.
But seems that all the communication is being proxy by the SCP.
So I thought to just disable (aka comment) the container from the docker-compose file (and comment all the depends_on) and run a capture again. But this time I did not get any HTTP/2 traffic so seems that things are not working.
Edit. Indeed AMF is not happy at all:

Here the question, there is a simple way to have a SA deployment without the SCP?
According to this: https://github.com/open5gs/open5gs/issues/1845 it should be possible, but I guess some configuration is needed for the other network functions. Any suggestion?
Thank you!

I think it should be possible. Good catch btw, I will fix this right away.

I pushed new commits to address this. Please pull latest commits and give it a try

I'll keep you posted, I guess I need to rebuild the containers right?

No need to rebuild the images. Just restart the docker-compose with SCP disabled

Ok seems that AMF is still not happy:

while NRF seems up:

And in Wireshark I do not see any packet between them just tons of ARP asking for the SCP.
Any suggestion?

Still the same:

If you suspect it is a bug in Open5GS I can open an issue there referring to this one

My bad, it was supposed to be delegated: no. Eitherway I tested with that as well and still all 5G components are failing so I think its a bug on open5gs

I see then I'll open an issue on the open5gs repo, mentioning this one.
Just for a better understanding the files like amf.yaml are the configuration for each network function of the 5G core right?

Just for a better understanding the files like amf.yaml are the configuration for each network function of the 5G core right?

yep. that is right.

for reference: https://github.com/open5gs/open5gs/issues/2116

I found a solution, rather than commenting out SCP in docker-compose, you can add the following in all the NFs (amf, smf, bsf, udr, udm, pcf, nssf, nrf, ausf, nssf). Then it will use NRF only
parameter:
    no_scp: true

and use in all above mentioned NFs except NRF
    discovery:
      delegated: no

Thank you very much for your support!
I'm going to try it and close this issue when done.

I confirm everything works as expected, I can clearly see from wireshark that the NF communicate between themselves.
Now I would like to contribute this back to your repo.
I guess I can use the .env file to set the delegated: DELEGATED and no_scp: SCP_DISABLED right?
So in the ENV file I can have DELEGATED=no and SCP_DISABLED=true and then populate this parameter in the single yaml file for each NF, I guess using the bash file XXX_init.sh that is in each folder.

im also facing the same issue. i tried commenting out scp section in docker-compose file sa-deploy file. Now all the NF will depend upon NRF only right?
parameter:
no_scp: true
discovery:
delegated: no
im adding this in all the yaml files of NF.  still it is showing retrying to register with NRF. So by default, the NFs are trying to connect to NRF or SCP in this case?

With the latest commit (f12c344441e444476cf0dda3d66d08cbc9c033f7) in master branch you can remove the scp configuration under sbi client as shown in below amf configuration to disable SCP and use only NRF
    sbi:
      server:
        - address: AMF_IP
          port: 7777
      client:
        nrf:
          - uri: http://NRF_IP:7777

I see the following in your logs, which suggests that you are not using tag v2.7.0 of open5gs. You need to recompile open5gs base image after switching to latest commits

amf | Open5GS daemon v2.6.6

amf      | 01/30 17:01:33.001: [sbi] ERROR: Connection timer expired (../lib/sbi/client.c:605)
amf      | 01/30 17:01:33.001: [sbi] WARNING: ogs_sbi_client_handler() failed [-3] (../lib/sbi/path.c:62)
amf      | 01/30 17:01:33.002: [sbi] WARNING: [e380ad72-bf62-41ee-a03f-e1bde4c664f5] Retry registration with NRF (../lib/sbi/nf-sm.c:182)
smf      | 01/30 17:01:36.409: [sbi] ERROR: Connection timer expired (../lib/sbi/client.c:605)
smf      | 01/30 17:01:36.410: [sbi] WARNING: ogs_sbi_client_handler() failed [-3] (../lib/sbi/path.c:62)
smf      | 01/30 17:01:36.410: [sbi] WARNING: [e569d370-bf62-41ee-b839-25a6f7fa19af] Retry registration with NRF (../lib/sbi/nf-sm.c:182)
bsf      | 01/30 17:01:41.195: [sbi] ERROR: Connection timer expired (../lib/sbi/client.c:605)
bsf      | 01/30 17:01:41.195: [sbi] WARNING: ogs_sbi_client_handler() failed [-3] (../lib/sbi/path.c:62)
bsf      | 01/30 17:01:41.195: [sbi] WARNING: [e85a5d02-bf62-41ee-8d63-0b7acb5d16d4] Retry registration with NRF (../lib/sbi/nf-sm.c:182)
udr      | 01/30 17:01:42.085: [sbi] ERROR: Connection timer expired (../lib/sbi/client.c:605)
udr      | 01/30 17:01:42.085: [sbi] WARNING: ogs_sbi_client_handler() failed [-3] (../lib/sbi/path.c:62)
udr      | 01/30 17:01:42.086: [sbi] WARNING: [e8e29de8-bf62-41ee-9119-ff2d9fc1aa0e] Retry registration with NRF (../lib/sbi/nf-sm.c:182)
pcf      | 01/30 17:01:42.126: [sbi] ERROR: Connection timer expired (../lib/sbi/client.c:605)
pcf      | 01/30 17:01:42.127: [sbi] WARNING: ogs_sbi_client_handler() failed [-3] (../lib/sbi/path.c:62)
pcf      | 01/30 17:01:42.127: [sbi] WARNING: [e8f0fff0-bf62-41ee-a3ae-7b8e701b4016] Retry registration with NRF (../lib/sbi/nf-sm.c:182)
ausf     | 01/30 17:01:42.189: [sbi] ERROR: Connection timer expired (../lib/sbi/client.c:605)
ausf     | 01/30 17:01:42.189: [sbi] WARNING: ogs_sbi_client_handler() failed [-3] (../lib/sbi/path.c:62)
ausf     | 01/30 17:01:42.190: [sbi] WARNING: [e263a4c6-bf62-41ee-9591-e31fb7c59d37] Retry registration with NRF (../lib/sbi/nf-sm.c:182)
udm      | 01/30 17:01:42.801: [sbi] ERROR: Connection timer expired (../lib/sbi/client.c:605)
udm      | 01/30 17:01:42.801: [sbi] WARNING: ogs_sbi_client_handler() failed [-3] (../lib/sbi/path.c:62)
udm      | 01/30 17:01:42.802: [sbi] WARNING: [e2b413a2-bf62-41ee-874a-d5ae472279ee] Retry registration with NRF (../lib/sbi/nf-sm.c:182)
nssf     | 01/30 17:01:43.237: [sbi] ERROR: Connection timer expired (../lib/sbi/client.c:605)
nssf     | 01/30 17:01:43.237: [sbi] WARNING: ogs_sbi_client_handler() failed [-3] (../lib/sbi/path.c:62)
nssf     | 01/30 17:01:43.238: [sbi] WARNING: [e304507e-bf62-41ee-a95c-31d858ed33d0] Retry registration with NRF (../lib/sbi/nf-sm.c:182)
amf      | 01/30 17:01:44.005: [sbi] ERROR: Connection timer expired (../lib/sbi/client.c:605)
amf      | 01/30 17:01:44.005: [sbi] WARNING: ogs_sbi_client_handler() failed [-3] (../lib/sbi/path.c:62)
amf      | 01/30 17:01:44.005: [sbi] WARNING: [e380ad72-bf62-41ee-a03f-e1bde4c664f5] Retry registration with NRF (../lib/sbi/nf-sm.c:182)
smf      | 01/30 17:01:47.416: [sbi] ERROR: Connection timer expired (../lib/sbi/client.c:605)
smf      | 01/30 17:01:47.416: [sbi] WARNING: ogs_sbi_client_handler() failed [-3] (../lib/sbi/path.c:62)
smf      | 01/30 17:01:47.416: [sbi] WARNING: [e569d370-bf62-41ee-b839-25a6f7fa19af] Retry registration with NRF (../lib/sbi/nf-sm.c:182)
It is showing same error. Retry to register with NRF.
logger:
file: /open5gs/install/var/log/open5gs/amf.log
sbi:
server:
no_tls: true
client:
no_tls: true
global:
max:
ue: MAX_NUM_UE
parameter:
amf:
sbi:
server:
- address: AMF_IP
port: 7777
client:
nrf:
- uri: http://NRF_IP:7777
# scp:
#   - uri: http://SCP_IP:7777
ngap:
server:
- address: AMF_IP
guami:
- plmn_id:
mcc: 001
mnc: 01
amf_id:
region: 2
set: 1
tai:
- plmn_id:
mcc: 001
mnc: 01
tac: 1
plmn_support:
- plmn_id:
mcc: 001
mnc: 01
s_nssai:
- sst: 1
security:
integrity_order : [ NIA2, NIA1, NIA0 ]
ciphering_order : [ NEA0, NEA1, NEA2 ]
network_name:
full: Open5GS
amf_name: open5gs-amf0
metrics:
server:
- address: AMF_IP
port: 9091
time:
t3512:
value: 540
this is my amf.yaml file. I have updated all other yaml files except NRF and SCP. nrf and scp are same as what I downloaded from the repo.  @herlesupreeth is this the problem in open5gs core itself?

no_scp_diff.txt
download the file and execute from docker_open5gs folder the following command
git apply /location_of_downloaded_file/no_scp_diff.txt
and then run docker compose -f sa-deploy.yaml up

@herlesupreeth I have freshly installed it in some other computer. There it is working without any errors. Thanks for the help.
I want to know whether I can do a volte/vonr call by running sa-vonr-deploy.yaml similarly? I have added 2 users in core and Hss as well. Will volte call supported by this repo now?

I want to know whether I can do a volte/vonr call by running sa-vonr-deploy.yaml similarly? I have added 2 users in core and Hss as well. Will volte call supported by this repo now?

This completely depends on the UE if its allowed to do a VoNR call over default bearer that is used for IMS signalling (usually phones prefer QoS which is achieved via dedicated bearer). Since there is no implementation of N5 interface towards PCF from kamailio P-CSCF there is no way to guarantee QoS for VoNR.
However, you can give it a try for VoNR call since one of the users of repo was able to perform VoNR call between two Samsung phones.


V5 it's comingg?????? pleassseee releasseee yaaaa

ATTENTION: DO NOT USE THIS FIELD TO ASK SUPPORT QUESTIONS. USE THE PLATFORM CHANNELS FOR THIS. THIS SPACE IS DEDICATED ONLY FOR FEATURE REQUESTS
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

ref https://github.com/jonataslaw/getx/issues/2797


enable shell-emulator in .npmrc

rerf:

https://pnpm.io/cli/run#shell-emulator
https://www.petermekhaeil.com/til/pnpm-shell-emulator/

is this efficien for docker volume mount with powershell??


Added deployment type to checks

Closes #613

Codecov Report
Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (f959cf2) 63.55% compared to head (f28e783) 62.40%.

Files
Patch %
Lines

lib/src/commands/update_command.dart
0.00%
15 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   63.55%   62.40%   -1.16%
==========================================
  Files          50       50
  Lines        1888     1902      +14
==========================================
- Hits         1200     1187      -13
- Misses        688      715      +27

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Mobile-App: missing npm commands for starting ionic

In the contributor guide, it mentions using the NPM Task Runner in Visual Studio to start up the ionic serve and ionic serve --lab but these commands are not in the mobile app's package.json file.

I am working on this one.

@tonysurma can you add the label mobile app instead of documentation?  The docs are correct but the functionality is missing from the mobile app project.

thanks for the catch @digitaldrummerj


example update

Thanks. We try to keep examples/ compiling in JDK8. But it can be hard to remember to check as we use JDK14 to develop.


[4.14] Installation fails during bootstrap

With 4.14.0-rc.3 we are seeing that bootstrap is failing with following error.
[#3107] failed to create some manifests:
Jul 11 05:45:54 crc-m55rz-bootstrap bootkube.sh[4652]: "99_openshift-cluster-api_master-machines-0.yaml": failed to create machines.v1beta1.machine.openshift.io/crc-m55rz-master-0 -n openshift-machine-api: the server could not find the requested resource
Jul 11 05:45:54 crc-m55rz-bootstrap bootkube.sh[4652]: "99_openshift-cluster-api_worker-machineset-0.yaml": failed to create machinesets.v1beta1.machine.openshift.io/crc-m55rz-worker-0 -n openshift-machine-api: the server could not find the requested resource

Looks like machineapi is now not part of default and added as part of capabilities https://pkg.go.dev/github.com/openshift/api/config/v1#ClusterVersionCapability


use docker/spdystream again

spdystream has been updated since i last messed with it.
commit log promises important race fixes.
So this PR uses docker/spdystream again, without my fixes.
(it seems they handled what i fixed differently).
But this doesn't pass the peerstream tests :/ it deadlocks. not sure
if its on our side or spdystream's. (i suspect spdystream)

Note: travis tests broken. run go test locally.

and these tests pass with your version of spdystream?

Yeah :/, but the version I have is broken too, as we discovered after testing it.
—
Sent from Mailbox
On Wed, Jun 3, 2015 at 11:30 AM, Jeromy Johnson<EMAIL_ADDRESS>wrote:

and these tests pass with your version of spdystream?
Reply to this email directly or view it on GitHub:
https://github.com/jbenet/go-peerstream/pull/9#issuecomment-108563824

we should try out https://github.com/SlyMarbo/spdy . maybe it doesnt have the bug we're seeing here?
@SlyMarbo, any comparisons between your lib and dockers spdystream?

I haven't done any comparison myself and I'm not familiar with Docker's package. I have no reason to believe you should have any issues with my package, but I'd recommend moving on to HTTP/2 if that's an alternative, since SPDY is being deprecated by a lot of people. https://github.com/bradfitz/http2 would be a great place to start, but if you're committed to SPDY give my package a go :)

@SlyMarbo thanks for the response! we'll be moving to http2 soon, we're only using spdy because we can interop with node easier that way (no streams based http2 impl in node yet)

that may not have fixed it...

yeah... so that didnt fix it.. it just removed the deadlock. now i'm getting EOF's all over.

@whyrusleeping fixed it! :) see: https://github.com/jbenet/spdystream/commit/f8ff317f21a2515b7f58514a4b2c1152867a8f72
What doesn't make me feel great is that i can seemingly deadlock spdystream: https://github.com/jbenet/spdystream/commit/d9719ba3991d6e74f08ddfc640e104adecb93755 though not sure if I'm doing something stupid

Thats... concerning. You gonna PR against docker?


ERROR: Found x federation configs.

Hey man,
I've a lerna based mono repo with packages at different levels.
packages/a/b/c/federation.config.json packages/e/f/federation.config.json
Getting the ERROR: Found x federation configs.
~Do we need to update some of the path resolution to use process.cwd()?~
In fact I can see by debugging it that findFederationConfigs is traversing the node_modules of the package, and lerna has npm linked to the other package, so that script is finding the federation.config.json of that project too. If we really need to do this traversing, filtering out node_modules might be worth doing:
const findFederationConfigs = (base, files, result) => {     files = files || fs.readdirSync(base);     files = files.filter(f => f !== 'node_modules'); // something like this.     result = result || [];

Hey Derek, thanks for submitting this issue. I am not familiar with how Lerna links packages, but it sounds like it's doing some sort of npm link under the hood (creating a symlink from the node_modules directory of one package to the linked package). Let me take a closer look here, but it sure sounds like you are correct that the traversing needs to be more defensive.

I'll have some time to open up a PR for this today. In addition to ignoring the node_modules when trying to find the federation.config.json file, I'll stop the traversal when it finds the closest federation.config.json.

Thanks for looking at this @gthmb.
Perhaps I'm using it wrong but I've also noticed the generated types code doesn't match up what I expect. For example if you have this:
{   "name": "myRemote",   "exposes": {     "./MyRemoteButton": "./src/button/index.ts",   } }
Working in the context of the latest WP5 module federation setup (at the time of this comment), I'd reference it like 'myRemote/MyRemoteButton' in the code, ie:
const { MyButton } = await import('myRemote/MyRemoteButton');
However it seems the top level node_modules/@types/__federated_types/* declare the modules with the exposes path value, not the exposes key value:
declare module "myRemote/button/index"
... so typescript doesn't actually have the typings and I still have to drop a // @ts-ignore above my dynamic remote import line.
Any ideas?


Support for storing activations for blocking calls

Problem:
I/O Runtime doesn't store the activation record for successful blocking invocations. A developer testing code will need to add this header to each request if he wants to force the creation of the activation record: "X-OW-EXTRA-LOGGING: on".
Solution:
aio CLI could automatically add this header when used to invoke an action. I/O Runtime will honor the request if applicable or just discard it (no error thrown).

Have you tried this feature against an active deployment? I am seeing failures against standalone openwhisk related to authentication. I believe that when a header is specified, npm openwhisk is not adding the basic auth header and all invokes fail.
 WSK_CONFIG_FILE=~/.local-wskprops ./bin/run runtime:action:invoke user/login
 ›   Error: failed to invoke the action: the resource requires authentication, which was not supplied with the request (401 Unauthorized)
 ›     specify --verbose flag for more information

running with DEBUG=* shows:
  { accept: 'application/json',
     'user-agent': 'Needle/2.4.1 (Node.js v10.16.3; darwin x64)',
     'x-ow-extra-logging': 'on',
     'content-length': 2,
     'content-type': 'application/json; charset=utf-8',
     host: 'localhost:3233' } } +0ms


Add arguments to all upload APIs that set checksums.

When uploading: the application should be able to provide the checksum value for the objects, in which case the library will not compute them but pass them on to the server.  The application should also be able to ask the library to compute the checksum values on its behalf, in which case the library will pass on the computed values to GCS.

@houglum does this make sense?  If not, please provide a better description.

Yeah, it's worth considering whether or not we want to add this functionality.
Pros:

Convenience. Our service relies on MD5 and CRC32C checksums for integrity checking, so it makes sense that we might provide utility methods to calculate those for local files.

Cons:

Bloat / scope creep. It's arguable as to whether our client library should be responsible for computing those checksums, as opposed to allowing users to do so themselves -- there are plenty of utilities out there to calculate them, allowing users to then pass the computed checksum to one of our methods (or calculate checksums for downloaded objects).

I think it's worth checking out our other storage client libraries and seeing what they do, at least for the download case (comparing the downloaded bytes' checksum to the checksum in the X-Goog-Hash header of the response).

This was fixed in #1344.


REGEXP_REPLACE trim last character

SELECT load_extension('./re.so');
-- .load ./re
SELECT REGEXP_REPLACE('this year is 2021', '[0-9]+', '2050');

This returns 205 instead of 2050.
Linux. SQLite version 3.22.0

Thanks for reporting! There is definitely a problem with older versions of SQLite. Will investigate.

For my testing:

on CLI, I install by sudo apt-get install sqlite3 , (v.3.22.0)
GUI https://sqlitebrowser.org/  - sqlite v.3.35.5
On sqlite.org, Latest Release Version 3.39.2 (2022-07-21).

Can you suggest another program with GUI than supports SELECT load_extension('./re.so') ?

Fixed in 0.15.3.


Hive Spark DDL Extractor Utility

This is a utility to extract DDLs from Hive metastore. Users can use this to accelerate the Hive migration journey.

renamed the template from "Hive Spark DDL to BQ" to "Hive DDL Extractor" as the original name was misleading and the new name is more accurate to the functionality of the template

Thanks Nilo - Will work on it and update.

@shubhamgoogle will work on this. He is helping me out to contribute this to Dataproc templates.

Hi @shubhamgoogle, the code snippet I post above is almost the full code that we need, only missing logging and error handling. The work/effort is mostly to substitute the current code with that


Java port

Hi!
Is there a Java port for this? If not I'd be interested in porting it.

There's a JVM port by @AlmasB: https://github.com/AlmasB/grammy
https://twitter.com/GalaxyKate/status/1093919399570862080


Install/Upgrade Error

Hi,
I'm having trouble installing the new version 3.7 of this package. I've read the other issues reported by the users and solutions suggested but none of them seem to work for me. I have the git installed and added to my path environment variable. Initially, i had the the version 3.6.7 installed but since it failed to update to the new version I thought uninstalling the old version might help but it didnt.
Please let me know of any other possible solutions that i can try and thank you for the great work.
=================================================================================
apm install script
Installing script to C:\Users\tom.jones.atom\packages failed
npm ERR! git fetch -a origin (git://github.com/monsterkodi/node-simple-plist.git) fatal: unable to connect to github.com:
npm ERR! git fetch -a origin (git://github.com/monsterkodi/node-simple-plist.git) github.com[0: <IP_ADDRESS>]: errno=No error
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Users\tom.jones\AppData\Local\atom\app-1.7.2\resources\app\apm\bin\node.exe" "C:\Users\tom.jones\AppData\Local\atom\app-1.7.2\resources\app\apm\node_modules\npm\bin\npm-cli.js" "--globalconfig" "C:\Users\tom.jones\.atom\.apm\.apmrc" "--userconfig" "C:\Users\tom.jones\.atom\.apmrc" "install" "C:\Users\tom.jones\AppData\Local\Temp\d-116321-12328-41wgyd\package.tgz" "--target=0.36.8" "--arch=ia32" "--msvs_version=2013"
npm ERR! node v0.10.40
npm ERR! npm  v2.13.3
npm ERR! code 128
npm ERR! Command failed: fatal: unable to connect to github.com:
npm ERR! github.com[0: <IP_ADDRESS>]: errno=No error
npm ERR!
npm ERR!
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     https://github.com/npm/npm/issues

I'm able to install it now, not sure what has changed. Sorry about that.


Feature/#11 java8

update to java 8

Coverage increased (+0.01%) to 21.199% when pulling 53f13bc01127484547906a189b727523f6f19d36 on feature/#11-java8 into acd63a4555a4283b6c337f5260f9cea38045dbd8 on master.


namespaces grant-permission should accept comma separated roles

bin/pulsar-admin namespaces grant-permission --role user1,proxy --actions produce,consume my-tenant/ns1

should grant permissions to user1 & proxy, no a non-existant user 'user1,proxy'.

This feature has been implemented in the golang CLI pulsarctl - https://github.com/streamnative/pulsarctl


fix: feedback from sonarcloud

Checklist

[x] Ensure PR title matches the conventional commits format.

CodiumAI Agent Commands
As required run the following CodiumAI Agent commands:

Request PR review using @CodiumAI-Agent /review (and if required, request an incremental update with @CodiumAI-Agent /review -i)
Request PR improvement suggestions with @CodiumAI-Agent /improve --extended
Request PR update using @CodiumAI-Agent /describe

@CodiumAI-Agent /review

PR Analysis

🎯 Main theme: The main theme of this PR is to improve code quality by addressing feedback from SonarCloud. This includes adding module docstrings and updating default values for strings in the App class.
📝 PR summary: This PR addresses feedback from SonarCloud to improve code quality. It adds module docstrings to __main__.py and app.py files, providing a brief description of the module's purpose. It also updates the default values for strings in the App class from None to an empty string.
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 2
The PR is relatively small and straightforward, involving changes to docstrings and default values for strings. However, it's important to ensure that changing the default values does not introduce unexpected behavior.
🔒 Security concerns: No
The PR does not introduce any obvious security concerns. However, it's always a good practice to ensure that sensitive data such as tokens and URLs are securely handled.

PR Feedback

💡 General suggestions: The PR is generally well done. The addition of module docstrings improves the readability of the code and provides useful context. Changing the default values for strings in the App class from None to an empty string can help avoid potential issues with NoneType errors. However, it's important to ensure that this change doesn't introduce unexpected behavior elsewhere in the code.

 🤖 Code feedback:

relevant file: ado_asana_sync/sync/app.py
suggestion: Consider adding a check to ensure that the string parameters are not empty, as this could lead to unexpected behavior. [important]
relevant line: ado_pat: str = "",

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.

@CodiumAI-Agent /improve --extended

How to use PR-Agent

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option.
/describe: Modify the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback.
/ask <QUESTION>: Pose a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, use the /config command.


FFmpeg camera broke

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.40.0
Python release (python3 --version):
Python 3.4.2
Component/platform: Camera_ generic: ffmpeg stream of RTSP camera
Description of problem:
component doesn't load. grey screen in frontend, errors in log
Expected:
view RTSP stream
Problem-relevant configuration.yaml entries and steps to reproduce:
camera:
  - platform: generic
    still_image_url:  http://api.buienradar.nl/image/1.0/RadarMapNL?w=500&h=512
  - platform: ffmpeg
    input: rtsp://<IP_ADDRESS>:554/user=admin&password=mammaloe&channel=1&stream=1.sdp
    name: Achtertuin

Additional info:
Errorlog:
result = yield from result
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/components/camera/__init__.py", line 253, in get
    response = yield from self.handle(request, camera)
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/components/camera/__init__.py", line 272, in handle
    image = yield from camera.async_camera_image()
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/components/camera/ffmpeg.py", line 60, in async_camera_image
    extra_cmd=self._extra_arguments)
  File "/home/homeassistant/.homeassistant/deps/haffmpeg/tools.py", line 78, in get_image
    image, _ = yield from self._proc.communicate()
AttributeError: 'NoneType' object has no attribute 'communicate'

Do you have any log exception inside log?

Pascal, here is the log:
File "/home/homeassistant/.homeassistant/deps/sqlalchemy/util/compat.py", line 203, in raise_from_cause
reraise(type(exception), exception, tb=exc_tb, cause=cause)
File "/home/homeassistant/.homeassistant/deps/sqlalchemy/util/compat.py", line 186, in reraise
raise value.with_traceback(tb)
File "/home/homeassistant/.homeassistant/deps/sqlalchemy/engine/base.py", line 1114, in _execute_context
conn = self._revalidate_connection()
File "/home/homeassistant/.homeassistant/deps/sqlalchemy/engine/base.py", line 424, in _revalidate_connection
"Can't reconnect until invalid "
sqlalchemy.exc.StatementError: (sqlalchemy.exc.InvalidRequestError) Can't reconnect until invalid transaction is rolled back [SQL: 'SELECT states.state_id AS states_state_id, states.domain AS states_domain, states.entity_id AS states_entity_id, states.state AS states_state, states.attributes AS states_attributes, states.event_id AS states_event_id, states.last_changed AS states_last_changed, states.last_updated AS states_last_updated, states.created AS states_created \nFROM states INNER JOIN (SELECT max(states.state_id) AS max_state_id \nFROM states \nWHERE states.created >= %s AND states.created < %s AND states.domain NOT IN (%s, %s) GROUP BY states.entity_id) AS anon_1 ON states.state_id = anon_1.max_state_id'] [parameters: [{}]]
17-03-21 17:52:49 ERROR (Recorder) [homeassistant.components.recorder.util] Error executing query: (_mysql_exceptions.OperationalError) (2002, "Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)")

@pvizeli @dennis071nl I am having problems with ffmpeg as well, using the docker image. Information below:
Home Assistant release (hass --version):
0.42.2
Python release (python3 --version):
Python 3.5.3
Component/platform:
ffmpeg
Description of problem:
homeassistant crashes after about a minute or sooner. Re-configuring the camera source quality to any different platform does not have any effect.
Expected:
The camera does load as expected. However HASS crashes soon after.
Problem-relevant configuration.yaml entries and steps to reproduce:
- platform: ffmpeg
  name: 'Patio'
  ffmpeg_bin: /usr/bin/ffmpeg
  input: -rtsp_transport tcp -i rtsp://<IP_ADDRESS>:554/

Have also tried variations of extra_arguments:
- platform: ffmpeg
  name: 'Patio'
  ffmpeg_bin: /usr/bin/ffmpeg
  input: -rtsp_transport tcp -i rtsp://<IP_ADDRESS>:554/
  extra_arguments: -pred 1 -q:v 2

or:
- platform: ffmpeg
  name: 'Patio'
  ffmpeg_bin: /usr/bin/ffmpeg
  input: -rtsp_transport tcp -i rtsp://<IP_ADDRESS>:554/
  extra_arguments: -q:v 2

Traceback (if applicable):
17-04-13 02:24:18 ERROR (MainThread) [aiohttp.server] Unhandled exception
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/components/camera/__init__.py", line 269, in handle
    image = yield from camera.async_camera_image()
  File "/usr/src/app/homeassistant/components/camera/ffmpeg.py", line 60, in async_camera_image
    extra_cmd=self._extra_arguments)
  File "/usr/local/lib/python3.5/site-packages/haffmpeg/tools.py", line 78, in get_image
    image, _ = yield from self._proc.communicate()
  File "/usr/local/lib/python3.5/asyncio/subprocess.py", line 182, in communicate
    loop=self._loop)
  File "/usr/local/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "uvloop/future.pyx", line 434, in uvloop.loop.BaseTask._fast_wakeup (uvloop/loop.c:114015)
  File "/usr/local/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
concurrent.futures._base.CancelledError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.5/site-packages/aiohttp/web_protocol.py", line 430, in start
    yield from resp.write_eof()
  File "/usr/local/lib/python3.5/site-packages/aiohttp/web_response.py", line 576, in write_eof
    yield from super().write_eof()
  File "/usr/local/lib/python3.5/site-packages/aiohttp/web_response.py", line 413, in write_eof
    yield from self._payload_writer.write_eof(data)
  File "/usr/local/lib/python3.5/site-packages/aiohttp/http_writer.py", line 281, in write_eof
    yield from self.drain(True)
  File "/usr/local/lib/python3.5/site-packages/aiohttp/http_writer.py", line 291, in drain
    self._transport.write(b''.join(self._buffer))
  File "uvloop/handles/stream.pyx", line 632, in uvloop.loop.UVStream.write (uvloop/loop.c:74612)
  File "uvloop/handles/handle.pyx", line 150, in uvloop.loop.UVHandle._ensure_alive (uvloop/loop.c:54917)
RuntimeError: unable to perform operation on <TCPTransport closed=True reading=False 0x33b7908>; the handler is closed
17-04-13 02:24:22 ERROR (Thread-10) [homeassistant.components.sensor.command_line] Command failed: hass --version
17-04-13 02:24:57 ERROR (MainThread) [aiohttp.server] Unhandled exception
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/components/camera/__init__.py", line 269, in handle
    image = yield from camera.async_camera_image()
  File "/usr/src/app/homeassistant/components/camera/ffmpeg.py", line 60, in async_camera_image
    extra_cmd=self._extra_arguments)
  File "/usr/local/lib/python3.5/site-packages/haffmpeg/tools.py", line 78, in get_image
    image, _ = yield from self._proc.communicate()
  File "/usr/local/lib/python3.5/asyncio/subprocess.py", line 182, in communicate
    loop=self._loop)
  File "/usr/local/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "uvloop/future.pyx", line 434, in uvloop.loop.BaseTask._fast_wakeup (uvloop/loop.c:114015)
  File "/usr/local/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
concurrent.futures._base.CancelledError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.5/site-packages/aiohttp/web_protocol.py", line 430, in start
    yield from resp.write_eof()
  File "/usr/local/lib/python3.5/site-packages/aiohttp/web_response.py", line 576, in write_eof
    yield from super().write_eof()
  File "/usr/local/lib/python3.5/site-packages/aiohttp/web_response.py", line 413, in write_eof
    yield from self._payload_writer.write_eof(data)
  File "/usr/local/lib/python3.5/site-packages/aiohttp/http_writer.py", line 281, in write_eof
    yield from self.drain(True)
  File "/usr/local/lib/python3.5/site-packages/aiohttp/http_writer.py", line 291, in drain
    self._transport.write(b''.join(self._buffer))
  File "uvloop/handles/stream.pyx", line 632, in uvloop.loop.UVStream.write (uvloop/loop.c:74612)
  File "uvloop/handles/handle.pyx", line 150, in uvloop.loop.UVHandle._ensure_alive (uvloop/loop.c:54917)
RuntimeError: unable to perform operation on <TCPTransport closed=True reading=False 0x3111b98>; the handler is closed
17-04-13 02:25:17 ERROR (MainThread) [aiohttp.server] Unhandled exception
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/components/camera/__init__.py", line 269, in handle
    image = yield from camera.async_camera_image()
  File "/usr/src/app/homeassistant/components/camera/ffmpeg.py", line 60, in async_camera_image
    extra_cmd=self._extra_arguments)
  File "/usr/local/lib/python3.5/site-packages/haffmpeg/tools.py", line 78, in get_image
    image, _ = yield from self._proc.communicate()
  File "/usr/local/lib/python3.5/asyncio/subprocess.py", line 182, in communicate
    loop=self._loop)
  File "/usr/local/lib/python3.5/asyncio/futures.py", line 380, in __iter__
    yield self  # This tells Task to wait for completion.
  File "uvloop/future.pyx", line 434, in uvloop.loop.BaseTask._fast_wakeup (uvloop/loop.c:114015)
  File "/usr/local/lib/python3.5/asyncio/futures.py", line 293, in result
    raise self._exception
concurrent.futures._base.CancelledError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.5/site-packages/aiohttp/web_protocol.py", line 430, in start
    yield from resp.write_eof()
  File "/usr/local/lib/python3.5/site-packages/aiohttp/web_response.py", line 576, in write_eof
    yield from super().write_eof()
  File "/usr/local/lib/python3.5/site-packages/aiohttp/web_response.py", line 413, in write_eof
    yield from self._payload_writer.write_eof(data)
  File "/usr/local/lib/python3.5/site-packages/aiohttp/http_writer.py", line 281, in write_eof
    yield from self.drain(True)
  File "/usr/local/lib/python3.5/site-packages/aiohttp/http_writer.py", line 291, in drain
    self._transport.write(b''.join(self._buffer))
  File "uvloop/handles/stream.pyx", line 632, in uvloop.loop.UVStream.write (uvloop/loop.c:74612)
  File "uvloop/handles/handle.pyx", line 150, in uvloop.loop.UVHandle._ensure_alive (uvloop/loop.c:54917)
RuntimeError: unable to perform operation on <TCPTransport closed=True reading=False 0x315bee8>; the handler is closed

@jtscott yeah that look like a bug in aiohttp. @dennis071nl can you run ha-ffmpeg with debug logging Level and send my the Output? Do you have other config option for ffmpeg? Do you run ffmpeg or the fork of it?

I'm getting this same error on with my Eyeonet. Weird thing is that the video/image of the camera does appear in HA. It just doesn't seem to even update. That and the same error in the logs.

@jtscott shouldn't the config be like:
ffmpeg:
  ffmpeg_bin: /usr/bin/ffmpeg

camera:
  - platform: ffmpeg
    name: 'Patio'
    input: -rtsp_transport tcp -i rtsp://<IP_ADDRESS>:554/
    extra_arguments: -q:v 2