Intermittently failing Code unit tests

There was a failure in https://github.com/rust-analyzer/rust-analyzer/runs/4422139463?check_suite_focus=true:
Downloading VS Code 1.61.0 from https://update.code.visualstudio.com/1.61.0/win32-archive/stableDownloaded VS Code 1.61.0 into D:\a\rust-analyzer\rust-analyzer\editors\code\.vscode-test\vscode-win32-archive-1.61.0

[main 2021-12-05T12:14:16.619Z] update#setState idle

Starting extension host with pid 5932.

(node:5932) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `Code --trace-deprecation ...` to show where the warning was created)

UNRESPONSIVE extension host, 'matklad.rust-analyzer' took 54% of 213.636ms, saved PROFILE here: 'file:///c%3A/Users/RUNNER~1/AppData/Local/Temp/exthost-560f9e.cpuprofile' [ { id: 'matklad.rust-analyzer', total: 114562, percentage: 54 } ]

Enabling inspect port on extension host with pid 5932.
⌛ Launch configuration/Lens
  ✔ A binary
  ✔ One of Multiple Binaries
  ✔ A test
✔ Launch configuration/Lens
⌛ Launch configuration/QuickPick
  ✔ A binary

  ✔ One of Multiple Binaries

  ✔ A test

✔ Launch configuration/QuickPick

⌛ Runnable env

  ✔ Global config works

  ✔ null mask works

  ✔ order works

  ✔ mask works

  ✔ exact test name works

  ✔ test mod name works
✔ Runnable env

Extension host with pid 5932 exited with code: 0, signal: null.

Exit code:<PHONE_NUMBER>
Done
Failed to run tests Failed

npm ERR! Test failed.  See above for more details.
Error: Process completed with exit code 1.

and another one in https://github.com/rust-analyzer/rust-analyzer/runs/4417427958?check_suite_focus=true:
⌛ Launch configuration/Lens

  ✔ A binary

  ✔ One of Multiple Binaries

  ✔ A test

✔ Launch configuration/Lens

⌛ Launch configuration/QuickPick

  ✔ A binary

  ✔ One of Multiple Binaries

  ✔ A test

✔ Launch configuration/QuickPick

⌛ Runnable env

  ✔ Global config works
  ✔ null mask works

  ✔ order works

  ✔ mask works

  ✔ exact test name works

  ✔ test mod name works

✔ Runnable env

Exit code:   SIGABRT
Done

Failed to run tests SIGABRT
npm ERR! Test failed.  See above for more details.
Error: Process completed with exit code 1.

I'm not sure what happens here. It might be either:

caused by the new test framework in #10903
something caused by a recent dependency upgrade
the tests might have been failing even before, but we didn't notice it because status reporting never worked

Exit code:<PHONE_NUMBER>

That's STATUS_STACK_BUFFER_OVERRUN.

Another failure mode in https://github.com/rust-analyzer/rust-analyzer/pull/10966#issuecomment-988961694.

Looks like a version check (needed to download the Code version used in tests?) failed.

https://github.com/microsoft/vscode/issues/138500 probably helped here, but after running the tests in a loop for 10 minutes or so on Linux, I got a new crash:
[main 2022-02-06T09:22:32.017Z] Extension host with pid 308716 exited with code: 0, signal: null.
Exit code:   SIGSEGV
Done

Failed to run tests SIGSEGV

[83106.811149] code[308660]: segfault at fffff6182871067b ip 00007f7d42ebf424 sp 00007f7d2c8e38f8 error 5 in libpthread-2.33.so[7f7d42ebb000+f000]
[83106.811158] Code: ba 45 02 00 00 48 8d 35 e4 b1 00 00 48 8d 3d 10 b2 00 00 e8 de c2 ff ff e8 69 c2 ff ff 66 0f 1f 84 00 00 00 00 00 f3 0f 1e fa <8b> 47 10 89 c2 81 e2 7f 01 00 00 90 83 e0 7c 75 7b 53 48 83 ec 10

CC @roblourens I was asked to verify the fix for #138500 one week after it got locked automatically.

Apologies, thanks for opening a new issue

Hopefully fixed in https://github.com/microsoft/vscode/pull/143074.
I don't know if that fixed the Windows crash, but it's somewhat less actionable, so let's close this until it resurfaces.


Transaction auto fetch reference block ID

When creating a Tx object a reference block ID must be specified.
Introduce an optional way for the Tx object to fetch the reference block ID behind the scenes.

what do you think about using client.get_latest_block(is_sealed=False) in background? if user don't pass a specific block him/herself, reference_block_id field can fill with client.get_latest_block(is_sealed=False) automatically.

Yes! This is exactly what I had in mind here! Sorry for the poor description.


ARM64 Windows support

As discussed in previous standups, we should add support for Winnows on ARM64. This would take a form similar to our MacOS support today:

Alpha+ stage

Cross-build binaries on Windows x86_64
Add to PR notes
Add to GitHub and Storage releases (no direct support for installers or other channels yet)
Binary only in a releasable .zip file (with NOTICE.txt)
azd --version smoke test only on an ARM64 windows machine (no e2e or other tests)

Beta+

Tests running on Windows ARM64 agents
MSI w/o Custom Action (needed only for telemetry

GA

MSI with Custom Action (how does this get cross compiled?)
Add to all releases (install scripts/winget/choco)

Other considerations:

How do we bootstrap tools? (like bicep, etc.)

Things to remember:

Cross builds happen on x86_64 machines https://github.com/Azure/azure-dev/blob/main/eng/pipelines/templates/jobs/cross-build-cli.yml
Tests run on ARM64 machines in scheduled builds


Doesn't detect or scrobble default musicapp. LG Optimus X2

I'm having problems with detecting and scrobbling music from the default music player through SLS. Also, it says Android music player (and other players) isn't installed, though it scrobbles other players. I've also tried using Scrobbledroid and the default Last.FM-app and that doesn't work either. Downloaded players like Winamp, Poweramp, PlayerPro and so on scrobbles just fine.
Model: LG-P990
Android version: 2.3.4
Baseband: 1035.21_20120521
Kernel: <IP_ADDRESS>
LG version: LGP990-V20s

@rezs Is this still a problem or no?

Hi. I'm sorry, I don't have a LG anymore.
Den 1 maj 2015 18:58 skrev "HumbleBeeBumbleBee"<EMAIL_ADDRESS>
@rezs https://github.com/rezs Is this still a problem or no?
—
Reply to this email directly or view it on GitHub
https://github.com/tgwizard/sls/issues/62#issuecomment-98177623.

Thanks! Hopefully this is fixed.
It's an old post so I'll be closing it.


Create a database based on a diagram

Hi,
@Odongo006  and @Koshao-sys we worked on the following requirements in this PR,

Create a file named schema_based_on_diagram.sql where you implement the database from the diagram.

Create Patients table

Create medical_histories table

Create Invoices table

Create treatments table

Create invoice_items table

Join tables from many-to-many relationships might not appear in the diagram, but you still need them.

Create join table for many-to-many relationship between medical_histories and treatments.

add the FK indexes as below:

@BregornOriginal Thanks for the review


Figure out how to accumulate primary key, foreign key values

Figure out how to do this efficiently using akka streams. Time-box?

I'm not sure if this is the same thing as checking primary key uniqueness?
For uniqueness, there are already some implementations, e.g. https://squbs.readthedocs.io/en/latest/deduplicate/ and https://mkyong.com/java8/java-8-find-duplicate-elements-in-a-stream/, plus quite a bit of research, e.g. https://scholar.google.com/scholar?hl=en&as_sdt=0%2C5&q=map+reduce+duplicate+detection&btnG=&oq=map+reduce+ and all the stuff about sorting unbounded streams.
For our case, we have a number of dimensions that form the primary key; let's call them D1, D2, ... Dn. Each dimension has a range of values, say the sets V1, V2, ... Vn. The size of these sets, multiplied together, is the (maximum) number of unique rows we can have in our data stream -- it's the size of the cross product, | V1 x V2 x ... x Vn |.
We could represent (set) membership of this cross product as a bitmap of the same size and while we're passing over the stream, check the relevant bit in the bitmap for each row is zero before setting it to one, and if it's not zero, then we have a duplicate. If the bitmap is in RAM, then 1GB would allow us to check an 8 billion row CSV.
The next issue is how to figure out whether we can get away with a single pass over the stream by working out the values of V1, V2... beforehand, e.g. using the foreign key declarations.

I'm not sure if this is the same thing as checking primary key uniqueness?
For uniqueness, there are already some implementations, e.g. https://squbs.readthedocs.io/en/latest/deduplicate/ and https://mkyong.com/java8/java-8-find-duplicate-elements-in-a-stream/, plus quite a bit of research, e.g. https://scholar.google.com/scholar?hl=en&as_sdt=0%2C5&q=map+reduce+duplicate+detection&btnG=&oq=map+reduce+ and all the stuff about sorting unbounded streams.
For our case, we have a number of dimensions that form the primary key; let's call them D1, D2, ... Dn. Each dimension has a range of values, say the sets V1, V2, ... Vn. The size of these sets, multiplied together, is the (maximum) number of unique rows we can have in our data stream -- it's the size of the cross product, | V1 x V2 x ... x Vn |.
We could represent (set) membership of this cross product as a bitmap of the same size and while we're passing over the stream, check the relevant bit in the bitmap for each row is zero before setting it to one, and if it's not zero, then we have a duplicate. If the bitmap is in RAM, then 1GB would allow us to check an 8 billion row CSV.
The next issue is how to figure out whether we can get away with a single pass over the stream by working out the values of V1, V2... beforehand, e.g. using the foreign key declarations.


client/question/question.html URL seems redundant

Could we move the HTML files out of their folders and up into the client/ directory? This seems like it would eliminate that redundancy.

SGTM

Hmm... thinking about why this is like this... I would guess that it was when we expected to have multiple questions. In that case, we would have used client/question/reversewords.html
Perhaps we changed reversewords.html to question.html, because we only had one question at the time. In that case, we should consider that we will have multiple questions. Even if we don't have a navigation UI to browse through them, since TIE may be embedded into a page that handles presentation/navigation across questions.

Fixed in #578


Row selection has no keyboard support

One idea is to allow tab to focus on each row. While focused, an enter (or space) press would select that row. If the ctrl / cmd modifier is used when selecting, it would add/remove the row to the existing selection. If shift modifier is used, it would select a range of rows.
While a row is selected, the up and down arrows could move from one row to another (without activating them) -- this is where the shift modifier would be useful.
Row states:

focused (user used tab to focus the row); with a mouse, this is achieve via a click
selected (user hit enter while row was focused; with a mouse, this is achieved a click
highlighted (user uses up or down to move between rows without focusing the row); with a mouse, this is achieve via hovering

I've built something like this before with angular and it wasn't too bad to implement (but I wasn't working with a general purpose table widget so I could use more hacks and dirty tricks that would be acceptable for a large project).
Would PRs implementing something like this be accepted? I don't really have a ton of time to focus on this right now but perhaps with a little guidance on implementation strategy me or someone else could take a stab at this.

Hi there,
I think this will be a solid addition to the table selection features. I'm not really too sure I understand the exact use case for the tab stuff. I feel like the up and down keys should handle that no?

In my experience, the following work bests (with slight changes for Mac like Cmd-A selects all in multiple selection). I would love to have keyboard features. I think there should be a default mapping of keys to events but the default mapping should be configurable.
Navigation (changes the focused row with a visual clue often highlighting):

Up: Move selection focus up one row. If scrolling enabled and at top row, scroll.
Down: Move selection focus down one row. If scrolling enabled and at bottom row, scroll.
Page-down: If scrolling enabled: If not at bottom visible row, move selection focus to bottom row. If at bottom visible row, scroll up one scroll viewport. If scrolling is not enabled: Do nothing special (let the browser do it's thing).
Page-up: Opposite of page-down when scrolling is enabled. If scrolling is not enabled: Do nothing special (let the browser do it's thing).
Home: Set selection focus to top most row (of full dataset).
End: Set selection focus to bottom most row (of full dataset). This should be optional because sometimes going to the end of a dataset directly cannot be easily/quickly done.
Ctrl-Right: Pan right if scrolling enabled (future when horizontal scroll is implemented)
Ctrl-Left: Pan left if scrolling enabled (future when horizontal scroll is implemented)
Tab and Shift-Tab should NOT be used inside the table. In my opinion, those should go to the next or previous component/control.

Multiple selection:

Spacebar: Add focused row to the selected list of rows if not selected. If the row is already selected, remove it from the selected.  Would be nice if spacebar also navigated down one row (often you are selecting multiple rows together).
Click: Select clicked row if the row is unselected. If the row is already selected, unselect it. Either way, unselect all other rows.
Ctrl-Click: Same as spacebar.
Shift-Click: Selects all rows from the row that was last selected to the current row (under click).
Alt-A: Selects all rows.

Single selection:

Navigation auto selects the focused row and unselects all other rows. For example, the Up key would bring into focus and select the next row up.
Click: Toggle whether the current row (under the mouse cursor) is selected. Regardless unselect all other rows.

Notes:

Single selection and Multiple selection are mutually exclusive.
In multiple selection, the visual clue for the currently focused row should be different from the selection status visual clue. For example, a check mark could be used to show if the row is selected and a row highlight could be used to show the currently focused row.

update from a recent feature.
i disabled the built in ELT row selection in favor of a checkbox column with a header column with toggle select all checkbox for the following reasons:

the row highlight color needs to be accompanied by a visual indicator for a11y reasons. if contrast of highlight/text color is not high, then it's hard to see that rows were selected. designer picked a light bg color for selection.
i tested on two users and they were confused by the need to cmd + click initially. when a visual indicator is added to indicate selected status of row, the user expectation of the behavior became checkbox semantics. my wife flat out told me it was stupid. lol.
if other components are clickable in the cells, the row click is confusing.
checkboxes natively support keyboard navigation and have none of the other problems. the only thing they natively lack is the ability to extend selections using shift modifier, but that could be implemented quite easily, i believe.

note: it was not difficult to implement this. took about an hour, including updating tests, etc.
so an alternative to the current selection method is the checkbox column (assume it has extend selection enhancement i mentioned above and the up/down navigation system proposed by Scott).
thoughts? i can throw up example of this if it would aid the discussion - let me know.

I have the same need for keyboard support. However, I thought, too, about the checkboxes idea but they are a little old school for my taste (i.e. they were needed before the AJAX era but not anymore). Beside, they are slower than an "Excel style" selection where you can quickly select a large range of rows with the mouse. I like the suggestions of @ScottSmix for the navigation and selection.
Anyway, I will implement my thing, put up a demo and you guys tell me what you think.

Excellent! I am glad you are going to tackle this!

I agree that the checkboxes feel a little retro.
I too look forward to seeing your demo with keyboard support.
On Tue, Nov 22, 2016, 8:08 PM Pierre-Luc Carmel Biron <
<EMAIL_ADDRESS>wrote:

I have the same need for keyboard support. However, I thought, too, about
the checkboxes idea but they are a little old school for my taste (i.e.
they were needed before the AJAX era but not anymore). Beside, they are
slower than an "Excel style" selection where you can quickly select a large
range of rows with the mouse. I like the suggestions of @ScottSmix
https://github.com/ScottSmix for the navigation and selection.
Anyway, I will implement my thing, put up a demo and you guys tell me what
you think.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/offirgolan/ember-light-table/issues/236#issuecomment-262412354,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABBEYHwzORtn8_G_F9DCRi6CaPb-YCudks5rA5H9gaJpZM4KeYIW
.

Sorry it has been a long time. I am working on it full time now. Should be ready anytime soon.

Demo: https://plcarmel.github.io/ember-light-table/#/rows/spreadsheet
I will prepare a PR soon.

Demo looking good! It is very much appreciated. A few notes from my perspective (based on my original suggestions):
Using keyboard navigation on a multiple row selection table, shouldn't the spacebar toggle row selection?
In the demo using the navigation keys  (like cursor up or down) un-selects a row. I think that should only be the behavior on single row selection. In multiple row selection, the navigation keys should not automatically un-select a selected row (only spacebar should toggle).

I was trying to replicate the behavior of a spreadsheet because it is the behavior that I wanted to have in my app. However, I also did a heavy refactoring (but 100% backward compatible) to allow complete customization of the behavior of the keyboard and mouse. This way, we will be able to provide a large number of different behaviors to the users and they will be able to provide their own if the proposed behaviors do not suit them.
So, if you don't like the way it works, don't worry, it can be just one of many possible options.


exclude folder

On the from, possibility to ignore folder or subfolder.

You could use a where clause on path or is_dir/is_file fields for that. Or could you elaborate the issue more?

I was considering exclude keyword, but wouldn't it be less functional than where conditions?
And this adds some ambiguity as well:
fselect path from /test exclude foobar, morestuff

Is 'morestuff' excluded or searched within?
Well, finally I gave up that idea as being impossible to implement without bringing some completely different syntax.


Update UG sections related to Appointment

Codecov Report

Merging #113 (f9ebb01) into master (5a1573f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #113   +/-   ##
=========================================
  Coverage     56.70%   56.70%
  Complexity      779      779
=========================================
  Files           167      167
  Lines          3194     3194
  Branches        368      368
=========================================
  Hits           1811     1811
  Misses         1284     1284
  Partials         99       99

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a1573f...f9ebb01. Read the comment docs.


chore(tests): fix lint failures

Motivation
Every PR has been failing the make lint checked with the following error since https://github.com/argoproj/argo-workflows/pull/12960 was merged (example):
 			assert.Equal(t, 1, len(status.Outputs.Parameters))
			^
Error: test/e2e/suspend_test.go:124:4: len: use assert.Len (testifylint)
			assert.Equal(t, 1, len(status.Inputs.Parameters))
			^
make: *** [Makefile:466: lint] Error 1

This is happening due to a conflict between that PR and https://github.com/argoproj/argo-workflows/pull/13467. The latter PR was merged on August 14th, but the latest CI run for the former was on May 22nd.
Modifications
Change to use assert.Len()
Verification
Ran make lint locally

Thank you for doing this


Intermit Build Cache Issues

Describe the bug
We see intermit cache issues when working with GHA as cache.
This happens across branches and looks random which job actually breaks 🤷
We experience this since #2027 and tried to fiddle around with #2083 and #2086
CC @livio-a @eliobischof

For further tracking the related issue https://github.com/docker/buildx/issues/681

Some examples to this
#14 [go-test 1/4] COPY . .
161
#14 ERROR: blob not found
162
------
163
 > [go-test 1/4] COPY . .:
164
------
165
Dockerfile:18
166
--------------------
167
  16 |     ## Go test
168
  17 |     FROM go-base as go-test
169
  18 | >>> COPY . .
170
  19 |     #Migrations for cockroach-secure
171
  20 |     RUN go install github.com/rakyll/statik
172
--------------------
173
error: failed to solve: failed to compute cache key: blob not found
174
Error: buildx failed with: error: failed to solve: failed to compute cache key: blob not found

https://github.com/caos/zitadel/runs/3190017719?check_suite_focus=true#step:5:167
#10 [artifact 3/5] RUN apk add -U --no-cache ca-certificates
150
#10 ERROR: blob not found
151

152
#12 [internal] load build context
153
#12 transferring context: 414.67kB 0.0s done
154
#12 CANCELED
155
------
156
 > [artifact 3/5] RUN apk add -U --no-cache ca-certificates:
157
------
158
Dockerfile:53
159
--------------------
160
  51 |     ARG OS=linux
161
  52 |
162
  53 | >>> RUN apk add -U --no-cache ca-certificates
163
  54 |
164
  55 |     COPY --from=prod-go-build /go/src/github.com/caos/zitadel/zitadelctl /app/zitadelctl
165
--------------------
166
error: failed to solve: failed to compute cache key: blob not found
167
Error: buildx failed with: error: failed to solve: failed to compute cache key: blob not found

Ok this is new but not great
https://github.com/caos/zitadel/runs/3221111899#step:5:725

Hey our team is having a similar issue with our CI. Don't know if this is the best place to comment on that but though it might be useful to know.

Hi @decaby7e
Thanks for your input. At the moment we have no other workaround found than deactivating the cache and wait 🙈
Enjoy your weekend

It looks like the buildkit error should be fixed https://github.com/docker/buildx/issues/681#issuecomment-934211900
I will open a PR for this


Widget failed to load - couldn't find icon

I was not able to load this widget until I modified the name parameter in the widget's manifest.json file.  The original name was "Add Layer to Map".  Apparently that defined the path for where to find the AddLayer icon.  I got an error in the console:
https://machinename:3344/webappbuilder/stemapp//widgets/Add Layer to Map/images/icon.png  404 not found.
Once I modified the name to "AddLayer", then the widget loaded and I was able to configure it.

You're exactly right. I fixed the manifest.json file.
Thanks for catching this.


deal with speakers

I'm not sure if we need this, but it seems there is a hacky way for each event to scrape speakers and aggregate them in the backend.
https://github.com/prgblockweek/prague-blockchain-week/blob/main/data/23/events/dotprague/_sync.js
To be discussed.

IMO the website should contain minimal information. If anyone wants to know about the speakers they can go to each event's website. The number of speakers in last year's PBW is immense and does not really help in any sense https://explore.prgblockweek.com/23

yes, franzi also said that. I already removed the speaker section. 👍🏼


typo Update profile screenshot.

Proposed changes
Issue Number: close #xxx
I found that the screenshot in the document is still an old version, so I decided to update a new screenshot.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

please rebase the code @yagagagaga

run buildall


pythonPackages.pipdeptree: init at 0.13.2

Motivation for this change
Make 'pipdeptree' Python package available in Nix.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I'd sure like to have this tool available. Can we re-package?

Looks like you already did. Is it ready for a PR?

Yes, it should be ready, give me some time to submit the final version in a PR


update version for next release from stable

Auto-merge toggled on

fail_compilation/lexer2.d needs to be undated.

Replaced with #5664.


Testing if datetime is aware fails

manager.run(force)
  File "/var/www/hosts/bettersubbox.com/dev/local/lib/python2.7/site-packages/django_cron/__init__.py", line 209, in run
    with self.lock_class(cron_job_class, self.silent):
  File "/var/www/hosts/bettersubbox.com/dev/local/lib/python2.7/site-packages/django_cron/backends/lock/base.py", line 60, in __enter__
    raise self.LockFailedException(self.lock_failed_message())
  File "/var/www/hosts/bettersubbox.com/dev/local/lib/python2.7/site-packages/django_cron/backends/lock/cache.py", line 47, in lock_failed_message
    started = self.get_running_lock_date()
  File "/var/www/hosts/bettersubbox.com/dev/local/lib/python2.7/site-packages/django_cron/backends/lock/cache.py", line 90, in get_running_lock_date
    if not timezone.is_aware(date):
  File "/var/www/hosts/bettersubbox.com/dev/local/lib/python2.7/site-packages/django/utils/timezone.py", line 340, in is_aware
    return value.utcoffset() is not None
AttributeError: 'NoneType' object has no attribute 'utcoffset'
``

Django 1.9, failed once out of thousands of runs...

@mikicz can I have a little more information about your implementation? I am having trouble replicating

Hi, I think I just followed the tutorial and documentation and did no modyfing, this really occured once after many months of production runtime and never happen since, I don't know if its worth trying to replicate...

I think there is a race condition around lock release and lock acquisition failed message.
Say you have 2 processes trying to run the same job A and B
A. acquire lock
A. run job
B. acquire lock
A. release lock
B. read lock value

I had this error occur today and wanted to say what I saw. I am using this on Windows through the task scheduler and have it set to run every 5 mins. For some reason, Windows did not run the script at 1:50 PM. I think it then tried to run it twice at 1:56 PM.
I also think that the first process messed up the second process in more than 1 way. It was trying to run a job at 1:50 PM that was scheduled for 4 AM. The only time I saw something like this happen, I had an issue with the backend (e.g. database was down so it attempted to run all of the jobs).
So, I guess what I am trying to say is that this issue may be with the OS or with the cache backend.

We run a lot of jobs and I'm getting this error at least every day, sometimes multiple times a day. Any idea when this will be fixed in pip?

Resolved in https://github.com/Tivix/django-cron/pull/130


Show version

It would be useful to display the version somewhere in the IHM (perhaps in a corner).
If we don't use docker, there is no information about the deployed version.
Great product !

Thanks !
Will add try to find a way to deal with it !
For now, you can have the information in json on  http://localhost:8080/info

Thanks, the  tags  information from the API is perfect.


Make NotFound Errors exportable

If they are not exportable, it's impossible to write unit-test on library using engine-api that would return an imageNotFoundError or other NotFoundErrors 🐹.
This is a naive approach and I'm not sure this is the right one either. But somehow, in some unit-test in libcompose I need to make my client returning a networkNotFoundError (or the same for other types) and there is currently no way I can do that (or I'm missing something :stuck_out_tongue_closed_eyes: ).
/cc @calavera @LK4D4 @runcom @stevvooe
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

There's an interesting read about errors: Assert errors for behaviour, not type http://dave.cheney.net/2016/04/27/dont-just-check-errors-handle-them-gracefully
:smile_cat:

@runcom yeah I've read it this last week, this morning too but… not sure how to apply there though…
Maybe like this :
type InspectNotFoundError interface {
    ID() string
}

type imageNotFoundError struct {
    imageID string
}

func (i imageNotFoundError) ID() string {
    return i.imageID
}

func (i imageNotFoundError) Error() string {
    return fmt.Sprintf("Error: No such image: %s", i.ImageID)
}

// …
func IsErrNotFound(err error) bool {
    _, ok := err.(InspectNotFoundError)
    return ok
}

… and thus removing all IsErrContainerNotFound, … and just keep a IsErroNotFound.
WDYT ?

Perhaps I'm misunderstanding, but weird thing is that Golang itself exports it's errors, e.g. ErrNotExist, but looks like they do some additional trickery https://golang.org/src/os/error_unix.go?h=isNotExist#L25 (called from os.IsNotExist()), so should we have a IsNotFound() function, that returns true if it's an ImageNotFound, VolumeNotFound etc? Sorry if I'm talking BS here :sweat_smile:
Note; IsErrInspectNotFound(err) should probably be IsInspectNotFound(err) (no Err in the name)

It makes sense that the errors are exported if we're going to generate them from other libraries. They were originally intended to be private.
LGTM

I don't think we should generate those from other libraries either. Since those errors are "not found" errors, at least we should provide a way to check that an error is of type not found, not by exporting them (same as go/net does for OpError)

And other libraries should not couple like this imo.

@runcom I'll rework it with the interface, as it makes less/almost no coupling :wink:

looks better to me - NotFound() seems not necessary though (except for the interface implementation) because it always returns true :/

LGTM
May want to introduce a separate errors package to centralize error handling but that is outside the scope of this PR.
Prevents this in client code:
func isUnknownContainer(err error) bool {
	return strings.Contains(err.Error(), "No such container:")
}

@runcom

looks better to me - NotFound() seems not necessary though

Indeed, but it represents the best practices in error handling. I don't agree with everything in that blog post, but it's extremely composable and highly flexible. See net.Temporary/net.Timeout for another example.

Indeed, but it represents the best practices in error handling. I don't agree with everything in that blog post, but it's extremely composable and highly flexible. See net.Temporary/net.Timeout for another example.

me neither - was just pointing that out thinking out loud - net.Temporary/net.Timeout is exactly what I was looking before chiming in here ;)

Updated
/cc @runcom @LK4D4 @calavera @stevvooe :angel:

LGTM

LGTM

Still LGTM


[Go Live][Dec 22]

Push to live

Docs Build status updates of commit 1f756ef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/add-resource.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/provision.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/use-CICD-template.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1f756ef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/toolkit/add-resource.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/provision.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/use-CICD-template.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Data Ingestion stage

[x] update config yaml
[x] research or analysis
[x] update the entity
[x] update the configuration manager in src config
[x] update the components
[x] update the pipeline

Dry run successful for stage 01


[error]actionable error msg for broken deck.gl chart

Hexagons demo chart shows error after loading samples:

POST to explore_json fails with error:
POST https://my.host.here/superset/explore_json/?form_data=%7B%22slice_id%22%3A77%7D&dashboard_id=5 500 (INTERNAL SERVER ERROR)

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/superset/views/base.py", line 177, in wraps
    return f(self, *args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/superset/utils/cache.py", line 108, in wrapper
    return f(*args, **kwargs)
  File "/usr/local/lib/python3.7/site-packages/superset/views/core.py", line 534, in explore_json
    return self.generate_json(viz_obj, response_type)
  File "/usr/local/lib/python3.7/site-packages/superset/views/core.py", line 430, in generate_json
    payload = viz_obj.get_payload()
  File "/usr/local/lib/python3.7/site-packages/superset/viz.py", line 480, in get_payload
    payload = self.get_df_payload(query_obj)
  File "/usr/local/lib/python3.7/site-packages/superset/viz.py", line 512, in get_df_payload
    query_obj = self.query_obj()
  File "/usr/local/lib/python3.7/site-packages/superset/viz.py", line 2375, in query_obj
    self.add_null_filters()
  File "/usr/local/lib/python3.7/site-packages/superset/viz.py", line 2356, in add_null_filters
    for column in self.get_spatial_columns(key):
  File "/usr/local/lib/python3.7/site-packages/superset/viz.py", line 2291, in get_spatial_columns
    raise ValueError(_("Bad spatial key"))
ValueError: Bad spatial key

Expected results
Hexagons should load properly
what you expected to happen.
How to reproduce the bug

Load examples from scratch
Navigate to deck.gl dashboard

Bad spatial key map layer problem? man i dont know what to do with all these broken charts 😂 i also not sure how many people are still using this chart

Did any one got a fix on this
I am using superset 1.0.1 still issue exists getting the same error

It would be beneficial if the chart logged some more information to the user rather than just "Bad Spatial Key" by showing the field that caused the chart to crash

Bump! This is still a useful bug fix to have. Please pin!

I'm no longer seeing this in Superset 2.1.0. Is anyone else? If not, I'll close it.


Plugin Icon Missing

Not a big issue in the slightest, but to report, the Speckle QGIS plugin does not present an icon on its toolbar button.

MacOS 12.5.1
QGIS 3.22.3
Speckle 2.7.0

This appears to be fixed on PC and Mac


ADDED SOLUTION FOR LC PROBLEM : 114. Flatten Binary Tree to Linked List

ADDED SOLUTION FOR LC PROBLEM : 114. Flatten Binary Tree to Linked List
Problem link:
https://leetcode.com/problems/flatten-binary-tree-to-linked-list/

this is amazing @shubhamnegi9
thanks for the contribution in my repo and please share in social media and tag me on twitter


docs: refactor jest.retryTimes() documentation

Summary
Refactoring jest.retryTimes() documentation so that admonitions could be used.
Test plan
Deploy preview.

/easycla

@SimenB Friendly ping. I guess this one just got overlooked.
By the way, great news regarding jestjs org! That was slow change, but still nice to see how things are moving forward.


Write the test() functions with model/transform re-loading

Description
The updated demos/node-classification/epgm-example.py and demos/node-classification/epgm-yelp-example.py have no test() implemented - it should load the saved model/transforms from disk, and apply them to the graph. These should be written, to show users how to load and apply saved models.
Done Checklist (Development)

[ ] Produced code for required functionality
[ ] Branch and Pull Request build on CI
[ ] Branch and Pull Request pass unit tests on CI
[ ] Branch and Pull Request pass integration tests on CI
[ ] Peer Code Review Performed
[ ] Code well commented

With https://github.com/stellargraph/stellargraph/pull/889, we no longer have any of the above scripts, so moving this to done.


Batching put support using w1c workers

Per discussions over the last couple of weeks, performance on large batch puts is dramatically better if those batches are parallelized in Riak. @jonmeredith pointed out that the obvious way to do so without introducing more infrastructure is to leverage the write-once workers already present on the coordinating node, hence this PR.
This changes all puts handled by the write-once logic, so it will need to be reviewed carefully.
Before this is approved I/we need to come up with a test to verify the behavior on worker failure and timeouts.

I performed manual testing by inserting crashes and long sleeps into the write once worker; the flow seems correct (after fixing and then removing the effective timeout logic).

Unclear why dialyzer is griping. Even a local test reveals nothing other than an error exists somewhere.

+1 526880d
Ran this through some of the r_t ts's, and they pass.
Local dialyzer passes here as well; looks like bors is running a second one for whatever reason? Weird, but seems unrelated to the change. The tests that are failing appear to be query parsing and compilation, something this does't touch at all.

Unit tests pass locally, dialyzer still failing locally with no useful information even with --verbose added.

Introduced some sleeps and crashes to the worker processes, things behave as expected.
Pushed a dialyzer fix, but the unit tests are probably doomed to fail until all of the renaming PRs are merged (at which point this branch might need rebasing, but I doubt it).

Ah, phooey. @lordnull I can't retry the build until you +1 the latest commit

@macintux Hope this helps

:+1:  e0af5b1

@borshop merge


#1010 resurfaced in release 11.2.0

Hello, after upgrading from 10.1.11 to the latest release 11.2.3, we've observed that the bug described in #1010 is happening again. We've managed to trace it back to release 11.2.0. Hope this helps!

Fixed at 12.0.1


slave images: maven has access to openshift slave does not

Maybe I am missing something. But if I run the maven k8s slave image, it can access the openshift project (eg oc get all). However if I use the base slave image, I get the following:
+ oc get all
Error from server (Forbidden): User "system:serviceaccount:project-build:default" cannot list buildconfigs in project "project-build"
Error from server (Forbidden): User "system:serviceaccount:project-build:default" cannot list builds in project "project-build"
.
.
.

I added the slave with the same settings as maven and nodejs in Kubernetes Pod Template in the Cloud setting block.

@wozniakjan this might be another item to tackle (it's just doc improvements)

Have some cycles now ... will craft a doc pull either today or tomorrow.


Added positions submitted via email

yes! cybercom
Reynaldo Boulogne
E-Mail: reynaldo.boulogne
@gmail.com
Mob: +46 (0) 70 022 53 93 <+46%2070%20022%2053%2093>
LinkedIn: https://www.linkedin.com/in/reynaldoboulogne/
Website: https://reynaldoboulogne.wordpress.com/
On Sun, Oct 28, 2018 at 6:04 PM Jim Holmström<EMAIL_ADDRESS>wrote:

@Jim-Holmstroem requested changes on this pull request.
In _companies/cybercom.md
https://github.com/Stockholm-AI/stockholm-ai/pull/171#discussion_r228756465
:

@@ -0,0 +1,13 @@
+---
+name: BYON8

cybercom?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Stockholm-AI/stockholm-ai/pull/171#pullrequestreview-169100563,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AenjvdLx_zWJ2Z7yZsl16xOnoC6MjADiks5upeOagaJpZM4X-D6d
.

The cybercome file is wrong. I will submit it again
On Sun, Oct 28, 2018 at 6:51 PM Reynaldo Boulogne <
<EMAIL_ADDRESS>wrote:

yes! cybercom
Reynaldo Boulogne
E-Mail: reynaldo.boulogne
@gmail.com
Mob: +46 (0) 70 022 53 93 <+46%2070%20022%2053%2093>
LinkedIn: https://www.linkedin.com/in/reynaldoboulogne/
Website: https://reynaldoboulogne.wordpress.com/
On Sun, Oct 28, 2018 at 6:04 PM Jim Holmström<EMAIL_ADDRESS>wrote:

@Jim-Holmstroem requested changes on this pull request.
In _companies/cybercom.md
https://github.com/Stockholm-AI/stockholm-ai/pull/171#discussion_r228756465
:

@@ -0,0 +1,13 @@
+---
+name: BYON8

cybercom?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Stockholm-AI/stockholm-ai/pull/171#pullrequestreview-169100563,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AenjvdLx_zWJ2Z7yZsl16xOnoC6MjADiks5upeOagaJpZM4X-D6d
.

fixed by https://github.com/Stockholm-AI/stockholm-ai/pull/172


What is the reason for setting the label/s to 50?

Is the reason for setting the Feature Encoder of Wav2Vec2 to 50 considering that it compresses audio in 20ms increments? When I actually passed a 20-second audio with 16,000 samples through Wav2Vec2, I obtained around 1,000 Time values, so I'm assuming that's the case. Or is there another reason?

Yes. wav2vec2 has a stride of 20ms (or, to be precise, 320 samples, which is 20ms at 16kHz), so by default, the Wav2Vec2ForAudioFrameClassification class in Transformers (which is what's being used here) will output 50 values per one second of speech.
The entire output will be one value shorter though (only 999 values for 20s of speech). I believe this is because the actual audio context is larger (25ms?), but I've never looked into it.


[Enhancement] display a loading bar when downloading

use charm's bubbletea package to achieve this... because i have their swag on my laptop lol

sick new tutorial!! @Yuno-obsessed
https://www.youtube.com/watch?v=5lxQJS3b38w


Fixes for the find widget history

Fixes: https://github.com/microsoft/vscode/issues/235102

@osortega should this be a draft?


langchain: update /libs/langchain/pyproject.toml w Cohere latest release

Description:
Update /libs/langchain/pyproject.toml w Cohere latest release from version 4 to 5. This is needed due to changes in Cohere API v5, and the recent Cohere migration from community to langchain_cohere.
Issue:
https://github.com/langchain-ai/langchain/discussions/19461
Twitter handle:. johnalexander

@baskaryan - would you mind taking a look? Thanks!


Rename tasks to pubs

Summary
Details and comments
Fixes #

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

43 of 59 (72.88%)  changed or added relevant lines in 10 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.315%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit_ibm_runtime/qiskit/primitives/estimator_pub.py
9
11
81.82%

qiskit_ibm_runtime/qiskit/primitives/sampler_pub.py
5
10
50.0%

qiskit_ibm_runtime/qiskit/primitives/base_sampler.py
3
12
25.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
3254

Relevant Lines:
5395

💛  - Coveralls


MULTIARCH-4359 Adding documentation for multiarch payload job names

The multiarch team has defined a pattern to follow for naming ci jobs that utilize the multi-payload.  This PR links the different places of documentation to one another.

/lgtm

/lgtm


cg.jl memory leak fix

cg.jl had several memory leaks arising from https://github.com/JuliaMath/IterativeSolvers.jl/blob/master/src/cg.jl#L45
and
https://github.com/JuliaMath/IterativeSolvers.jl/blob/master/src/cg.jl#L54.
julia> @time x = cg(A, rhs; maxiter=2000);
  0.073056 seconds (12.04 k allocations: 31.635 MB, 14.14% gc time)

In this PR I have defined mutating functions for these functionalities and now we have
julia> @time cg(A, rhs; maxiter=2000);
  0.051681 seconds (8.04 k allocations: 714.328 KB)

Please note that I have found many such areas of optimizations in gmres.jl, lancoz.jl etc. but due to want of time I won't be able to address those issues.
Maybe @haampie can fix these during the summer.

cg.jl had several memory leaks arising from

Those aren't memory leaks. Memory leaks are when allocations aren't tracked either by the GC or manually, leading to a buildup of memory over time. This is just extra allocations which weren't necessary. There's a difference. "Reduced allocations", not "fixed memory leaks".
The branch you PR'd from was not master, and so this has a bunch of other changes mixed in. You'll want to cherrypick the changes for this PR to a new branch and use the clean branch for the PR.


[PE-D][Tester E] Invalid Error Handling in Date

Error should be date does not exist --> not it is in the wrong format ( because it is still in YYYY-MM-DD)

Labels: severity.Low type.FunctionalityBug
original: taggyhan/ped#17

Thank you for pointing this out. We will be modifying the error message to handle this correctly.


nix-index: Wrap with nix-env in PATH

This fixes an impurity in nix-index: Previously it would take the nix-env
binary from the users PATH. I discovered this while trying to run nix-index in a
systemd service, which by default doesn't have nix-env in its path. The
errors it threw were not informative at all and it took me hours to
finally figure out the reason.
Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: nix-index
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ipj75mk3da0piqs8x9kgxd14bll7nyix-nix-index-0.1.2
shrinking /nix/store/ipj75mk3da0piqs8x9kgxd14bll7nyix-nix-index-0.1.2/bin/nix-locate
shrinking /nix/store/ipj75mk3da0piqs8x9kgxd14bll7nyix-nix-index-0.1.2/bin/.nix-index-wrapped
strip is /nix/store/n4hb93w6j076xcjw5pm09rdmc09s075b-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ipj75mk3da0piqs8x9kgxd14bll7nyix-nix-index-0.1.2/bin
patching script interpreter paths in /nix/store/ipj75mk3da0piqs8x9kgxd14bll7nyix-nix-index-0.1.2
/nix/store/ipj75mk3da0piqs8x9kgxd14bll7nyix-nix-index-0.1.2/etc/profile.d/command-not-found.sh: interpreter directive changed from "/bin/sh" to "/nix/store/yal8k8rgbaj8p9vi08q1kh21ls0ndq95-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/ipj75mk3da0piqs8x9kgxd14bll7nyix-nix-index-0.1.2...
/nix/store/ipj75mk3da0piqs8x9kgxd14bll7nyix-nix-index-0.1.2

Timed out, unknown build status on x86_64-darwin (full log)
Attempted: nix-index
Partial log (click to expand)
[ 30%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/BlockFrequencyInfo.cpp.o
[ 30%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/BlockFrequencyInfoImpl.cpp.o
[ 30%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/BranchProbabilityInfo.cpp.o
[ 30%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CFG.cpp.o
[ 30%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CFGPrinter.cpp.o
[ 30%] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CFLAndersAliasAnalysis.cpp.o
building of '/nix/store/awxnkzy6ls7ki8s7n12bw1qf15hkc9lw-rustc-1.30.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/pn1d764lcjqmyy6hjick36yawify5pd3-cargo-1.30.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/r3vyamga2f1jy1npglr1rmb60b0d483p-nix-index-0.1.2.drv': 2 dependencies couldn't be built
error: build of '/nix/store/r3vyamga2f1jy1npglr1rmb60b0d483p-nix-index-0.1.2.drv' failed

Success on aarch64-linux (full log)
Attempted: nix-index
Partial log (click to expand)
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/78m40pnrq49jdfwrv4kyay7qq6rl2s0q-nix-index-0.1.2
shrinking /nix/store/78m40pnrq49jdfwrv4kyay7qq6rl2s0q-nix-index-0.1.2/bin/.nix-index-wrapped
shrinking /nix/store/78m40pnrq49jdfwrv4kyay7qq6rl2s0q-nix-index-0.1.2/bin/nix-locate
strip is /nix/store/qjrnv0qw44bw1hc23zhfh26xd1c25dfs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/78m40pnrq49jdfwrv4kyay7qq6rl2s0q-nix-index-0.1.2/bin
patching script interpreter paths in /nix/store/78m40pnrq49jdfwrv4kyay7qq6rl2s0q-nix-index-0.1.2
/nix/store/78m40pnrq49jdfwrv4kyay7qq6rl2s0q-nix-index-0.1.2/etc/profile.d/command-not-found.sh: interpreter directive changed from "/bin/sh" to "/nix/store/bpspdmsl0yys24gs70flsvcw3wcnl7lx-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/78m40pnrq49jdfwrv4kyay7qq6rl2s0q-nix-index-0.1.2...
/nix/store/78m40pnrq49jdfwrv4kyay7qq6rl2s0q-nix-index-0.1.2

Perhaps feedback from @bennofs (author) would be desirable here.


NIFI-12016: Allow use of compatible NAR bundles when loading flow from cluster connection (backport)

Summary
NIFI-12016 When determining what bundles are compatible, consider not just any bundle if it's the only one but also any bundle whose version matches the framework version so that when NiFi is upgraded, it is handled more gracefully.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the support/nifi-1.x branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 8

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

@mattyb149 Is this is still wanted for the 1.x branch?

Yes please :)

+1 merging


#623: Test new pipeline on fork PRs

This is a dummy-PR to test the changes from #623.

test was successful, closing PR.


Simulate authentication page

Describe the solution you'd like
Instead of directly integrating with all supported providers, use a simulated login page that allows a user to specify the provider, user info, and roles that they want to log in as.
When the app navigates to /.auth/<provider>/login, display the following screen:

(the anonymous and authenticated roles are always included when authenticated)
Upon "login", store the provided information in a cookie. When an API endpoint is accessed, add a x-ms-client-principal header using the identity from this cookie.
Accessing /.auth/me returns the info from this cookie.
/.auth/logout clears this cookie.

Notes from last meeting with Anthony Chu and Mitali Karmarkar:

provider input are simple free text input (no validation). Default it to the current route.
store state in localStorage
cookie format remains the same. Entries: userId, userName, provider, userDetails.
auth should just redirect to callback.
roles are stored in cookie.
current cookie format:

{
  "clientPrincipal": {
    "identityProvider": "github",
    "userId": "c017e8557def49f9bec3e0f011fdf746",
    "userDetails": "anthonychu",
    "userRoles": [
      "anonymous",
      "authenticated"
    ]
  }
}
```

Notes from last meeting with Anthony Chu and Mitali Karmarkar:

provider input are simple free text input (no validation). Default it to the current route.
store state in localStorage
cookie format remains the same. Entries: userId, userName, provider, userDetails.
auth should just redirect to callback.
roles are stored in cookie.
current cookie format:

{
  "clientPrincipal": {
    "identityProvider": "github",
    "userId": "c017e8557def49f9bec3e0f011fdf746",
    "userDetails": "anthonychu",
    "userRoles": [
      "anonymous",
      "authenticated"
    ]
  }
}
```


feat: implement graceful, modifiable UDS Core CoreDNS overrides

Description
Implements an alternative CoreDNS override that relies on UDS Core's base service mesh, Istio. Uses the admin and tenant ingress gateways as the rewrite targets to gracefully handle ungraceful Docker restarts/stops, where host.k3d.internal fails. Also handles the case of integrating and routing to potential/future alternative service meshes via CoreDNS (e.g., kong). Another added benefit is the end-user's ability to add further rewrites based on additional or alternative gateways, domains, subdomains, services and/or virtual services.
Related Issue
Fixes #99
Type of change

[X] New feature (non-breaking change which adds functionality)

Checklist before merging

[X] Test, docs, adr added or updated as needed
[X] Contributor Guide Steps followed

Local tests were performed to ensure the override works with UDS Core (slim-dev).

@rjferguson21 @mjnagel I sort of modified things based on a combination of your guys' comments. Please let me know if there's more you'd like me to change. Thank you!

@rjferguson21 @mjnagel turns out, the wrong indent type was used, thanks @rjferguson21 for pointing it out! Everything is in working order now. feel free to run things without and with an override to see how they work.

Final output without providing the override at deployment:
apiVersion: v1
data:
  uds.override: |
    rewrite stop {
      name regex (.*\.admin\.uds\.dev) admin-ingressgateway.istio-admin-gateway.svc.cluster.local answer auto
    }
    rewrite stop {
      name regex (.*\.uds\.dev) tenant-ingressgateway.istio-tenant-gateway.svc.cluster.local answer auto
    }
    rewrite stop {
      name regex (.*\.uds\.dev) host.k3d.internal answer auto
    }
kind: ConfigMap
metadata:
  annotations:
    meta.helm.sh/release-name: uds-dev-stack
    meta.helm.sh/release-namespace: uds-dev-stack
  labels:
    app.kubernetes.io/managed-by: Helm
  name: coredns-custom
  namespace: kube-system

Final output when supplying the override within docs/DNS.md:
apiVersion: v1
data:
  uds.override: |
    rewrite stop {
      name regex (.*\.uds\.dev) host.k3d.internal answer auto
    }
kind: ConfigMap
metadata:
  annotations:
    meta.helm.sh/release-name: uds-dev-stack
    meta.helm.sh/release-namespace: uds-dev-stack
  labels:
    app.kubernetes.io/managed-by: Helm
  name: coredns-custom
  namespace: kube-system


How to train the code on local?

Hello, I'm using Ubuntu 20.04 system and want to train this project on my pc.
I have downloaded the MUSDB18-HQ with all the .wav form profiles to my pc and created a conda environment with python=3.8 and torch=1.8.1 as shown in the readme.
In which path should I put my dataset?
In data/musdb_wrapper.py I see
`    @staticmethod
def add_data_provider_args(parent_parser):
parser = ArgumentParser(parents=[parent_parser], add_help=False)
    parser.add_argument('--musdb_root', type=str, default='etc/musdb18_samples_wav/')

    return parser`

does this mean I need to change the "musdb18hq" foler name(with subfolders "train" and "test") into "musdb18_samples_wav" and put into the folder "etc"? Or should I take all the song folders into the "musdb18_samples_wav" folder without subfolders "train" and "test"?
Thank you.

Hi @Logicino, Thank you for your question.
We no longer use parser.add_argument('--musdb_root', type=str, default='etc/musdb18_samples_wav/') cause now we are mangaging the whole project with hydra (https://github.com/ashleve/lightning-hydra-template).

Could you try this commend?
python train.py trainer.gpus=1 dataset.batch_size=6 dataset.musdb_root=$YOURMUSDBROOT
, where $YOURMUSDBROOT is your MUSDB18 directory?

Ah, you don't have to put the other options like trainer.gpus=1 dataset.batch_size=6 if you don't need them.

Also, you might as well check our new repository of the LASAFT-Net-v2 (https://ws-choi.github.io/LASAFT-Net-v2/) if you want to try the newest model.
But sorry in advance, that repository is not well documented yet. I will revise them sooner or later.

Thank you for you reply! I

Hi @Logicino, Thank you for your question.
We no longer use parser.add_argument('--musdb_root', type=str, default='etc/musdb18_samples_wav/') cause now we are mangaging the whole project with hydra (https://github.com/ashleve/lightning-hydra-template).
Could you try this commend?
python train.py trainer.gpus=1 dataset.batch_size=6 dataset.musdb_root=$YOURMUSDBROOT , where $YOURMUSDBROOT is your MUSDB18 directory?

I think this project does not use the argparser "--musdb='directory'" as we usually use the python train.py --directory"musdb", so I can just take the HYDRA training method, am I correct?

I set the dir of LaSAFT project(at /home/usrname/Conditioned_Source_Separation_LaSAFT), and my musdb_root is in other dirpath(/dev/musdb/musdb18hq/train and /test)
As I tried this
python train.py trainer.gpus=1 dataset.batch_size=6 dataset.musdb_root=$YOURMUSDBROOT in the terminal command line, it asked me to register a wandb profile(I didn't use the HYDRA and I think this is a option tool that provides some training tricks). I registered and got a API key for the wandb, and I put the API key into the terminal when asked for.
However, then I run python it reports an error like below:

Global seed set to 2020
wandb: Currently logged in as: kinologic. Use `wandb login --relogin` to force relogin
wandb: Tracking run with wandb version 0.13.5
wandb: Run data is saved locally in ./wandb/run-20221110_150236-293r0nox
wandb: Run `wandb offline` to turn off syncing.
wandb: Syncing run grateful-bee-6
wandb: ⭐ View project at https://wandb.ai/kinologic/lasaft
wandb: 🚀 View run at https://wandb.ai/kinologic/lasaft/runs/293r0nox
Error executing job with overrides: ['dataset.musdb_root=dev/musdb/musdb18hq/']
Traceback (most recent call last):
  File "train.py", line 24, in hydra_entry
    main(cfg)
  File "train.py", line 19, in main
    trainer.train(cfg)
  File "/home/usrname/Conditioned-Source-Separation-LaSAFT/lasaft/source_separation/conditioned/scripts/trainer.py", line 45, in train
    wandb_login(key=cfg['wandb_api_key'])
omegaconf.errors.InterpolationResolutionError: KeyError raised while resolving interpolation: "Environment variable 'wandb_api_key' not found"
    full_key: wandb_api_key
    object_type=dict

Set the environment variable HYDRA_FULL_ERROR=1 for a complete stack trace.
wandb: Waiting for W&B process to finish... (failed 1). Press Control-C to abort syncing.
wandb: Synced grateful-bee-6: https://wandb.ai/kinologic/lasaft/runs/293r0nox
wandb: Synced 6 W&B file(s), 0 media file(s), 0 artifact file(s) and 0 other file(s)
wandb: Find logs at: ./wandb/run-20221110_150236-293r0nox/logs

it seems the 'wandb_api_key' not found, but I really inputed the API key. Should I ask the wandb for help? Or is there any other training method without using this HYDRA?

I'll later try about the version 2. Thank you for your answers :)

I can just take the HYDRA training method, am I correct?

Yes, as you already tried.

However, then I run python it reports an error like below:

Ah, sorry for the poor documentation. You must use .env file to register your wandb api key.
I revised the readme file for it.
https://github.com/ws-choi/Conditioned-Source-Separation-LaSAFT#4-logging-mandatory-wandb
Hope it works this time :)

Ah, sorry for the poor documentation. You must use .env file to register your wandb api key.

Thank you for your reply!
I'm sorry for these days my server's broken and I had to fix these problems which really takes time...
for the .env file, I pasted the wandb key into the .env.sample and changed its file name into .env, this truly solves the previous problem, thank you!
However,  this time it run into questions about 'the PyTorch_lightening trainer got an unexpected keyword argument "truncated_bptt_steps", the whole log is shown in below:
wandb: Currently logged in as: kinologic. Use `wandb login --relogin` to force relogin
wandb: Tracking run with wandb version 0.13.5
wandb: Run data is saved locally in ./wandb/run-20221117_142143-2scwpkn6
wandb: Run `wandb offline` to turn off syncing.
wandb: Syncing run sage-brook-13
wandb: ⭐ View project at https://wandb.ai/kinologic/lasaft
wandb: 🚀 View run at https://wandb.ai/kinologic/lasaft/runs/2scwpkn6
wandb: WARNING Calling wandb.login() after wandb.init() has no effect.
wandb: logging graph, to disable use `wandb.watch(log_graph=False)`
Error executing job with overrides: ['trainer.gpus=1', 'dataset.batch_size=6', 'dataset.musdb_root=/home/data/musdb/']
Traceback (most recent call last):
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 62, in _call_target
    return target(*args, **kwargs)
  File "/home/usrname/anaconda3/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/utilities/argparse.py", line 339, in insert_env_defaults
    return fn(self, **kwargs)
TypeError: __init__() got an unexpected keyword argument 'truncated_bptt_steps'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "train.py", line 28, in <module>
    hydra_entry()
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/main.py", line 49, in decorated_main
    _run_hydra(
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/_internal/utils.py", line 367, in _run_hydra
    run_and_report(
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/_internal/utils.py", line 214, in run_and_report
    raise ex
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/_internal/utils.py", line 211, in run_and_report
    return func()
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/_internal/utils.py", line 368, in <lambda>
    lambda: hydra.run(
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/_internal/hydra.py", line 110, in run
    _ = ret.return_value
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/core/utils.py", line 233, in return_value
    raise self._return_value
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/core/utils.py", line 160, in run_job
    ret.return_value = task_function(task_cfg)
  File "train.py", line 24, in hydra_entry
    main(cfg)
  File "train.py", line 19, in main
    trainer.train(cfg)
  File "/home/usrname/Conditioned-Source-Separation-LaSAFT/lasaft/source_separation/conditioned/scripts/trainer.py", line 49, in train
    trainer = HI.trainer(cfg, callbacks=callbacks, logger=logger, _convert_="partial")
  File "/home/usrname/Conditioned-Source-Separation-LaSAFT/lasaft/utils/instantiator.py", line 44, in trainer
    return cls.instantiate(cfg['trainer'], **kwargs)
  File "/home/usrname/Conditioned-Source-Separation-LaSAFT/lasaft/utils/instantiator.py", line 52, in instantiate
    return hydra.utils.instantiate(*args, **kwargs)
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 180, in instantiate
    return instantiate_node(config, *args, recursive=_recursive_, convert=_convert_)
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 249, in instantiate_node
    return _call_target(target, *args, **kwargs)
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 64, in _call_target
    raise type(e)(
  File "/home/usrname/.local/lib/python3.8/site-packages/hydra/_internal/instantiate/_instantiate2.py", line 62, in _call_target
    return target(*args, **kwargs)
  File "/home/usrname/anaconda3/envs/lasaft/lib/python3.8/site-packages/pytorch_lightning/utilities/argparse.py", line 339, in insert_env_defaults
    return fn(self, **kwargs)
TypeError: Error instantiating 'pytorch_lightning.trainer.trainer.Trainer' : __init__() got an unexpected keyword argument 'truncated_bptt_steps'

I think I need to look into the PyTorch lightening and the 'truncated_bptt_steps'... Do you have any idea on this problem? Thank you!

I think I solved this problem because of the version of pytorch lightning.
The file suggest for pytorch lightning >=1.3.2, however before I tried 1.4.0, 1.5.0, 1.5.10, 1.6.0, these won't work!
Please try to fix this suggestion :)

I can just take the HYDRA training method, am I correct?

Yes, as you already tried.

However, then I run python it reports an error like below:

Ah, sorry for the poor documentation. You must use .env file to register your wandb api key.
I revised the readme file for it.
https://github.com/ws-choi/Conditioned-Source-Separation-LaSAFT#4-logging-mandatory-wandb
Hope it works this time :)

Well, as I tried LASAFTv2(https://github.com/ws-choi/LASAFT-Net-v2), it comes up with other questions.
I have created the .env file like:
wandb_api_key="43a557ffd01194ec0417f41b6efb218c078275f1" # go wandb.ai/settings and copy your key
data_dir="/home/data/musdb" # Your Musdb data directory. must be an absolute path.
HYDRA_FULL_ERROR=1

and as I tried to train LASAFTv2 using:
(lasaft) usrname@ubuntu-18:~/LASAFT-Net-v2$ python train.py trainer.gpus=1 dataset.batch_size=6 --version=v2
usage: train.py [--help] [--hydra-help] [--version] [--cfg {job,hydra,all}] [--resolve] [--package PACKAGE]
                [--run] [--multirun] [--shell-completion] [--config-path CONFIG_PATH] [--config-name CONFIG_NAME]
                [--config-dir CONFIG_DIR] [--info [{all,config,defaults,defaults-tree,plugins,searchpath}]]
                [overrides [overrides ...]]
train.py: error: argument --version: ignored explicit argument 'v2'

It seems it is not the proper command to train this. As I looked into the project of LASAFTv2, I didn't see any suggestions about training. Could you please tell me? Thank you!

I have fixed all the problems of this project 👍 Thank you~
I'm looking forward to the document update of LASAFTv2 :)

I think I solved this problem because of the version of pytorch lightning.
The file suggest for pytorch lightning >=1.3.2, however before I tried 1.4.0, 1.5.0, 1.5.10, 1.6.0, these won't work!
Please try to fix this suggestion :)

this can only be 1.3.2

Hi @Logicino , thanks a lot for letting me know that issue.
I'll update this and v2 repository sooner or later (or you can make a PR if you want :) )


Occasional type error

Often while a SpaceShoes app is running, we'll get a function with mismatched type error when attempting to report the Ruby VM state. It's possible this is a ruby.wasm error that will get worked out upstream, or even an emscripten error -- there's one that looks similar.
It's also possible we're doing something wrong that causes this. File operations like fwrite seem to be easy to misuse in a way that can cause it, though the error happens even in Shoes apps that use no additional files. (Huh, maybe I should remove the file loader since we usually don't need it?)
This issue is a place to dump information about this bug as we go along.
For instance, it will often occur after the Shoes app has been running awhile, many heartbeats in. So it doesn't seem to be immediately triggered by something new that just happened a moment ago. There seems to be some built in randomness or delay.

It's possible that we're generating an RbFatalError on the JS side (ref: https://www.npmjs.com/package/@ruby/wasm-wasi). If so, might be possible to catch it and reload. That would lose any data in Ruby mem, of course.

I haven't seen this, including in calc.html, since I got rid of the JS-based DOM modification and replaced with the JS gem. I also made sure an element exists in the DOM before trying to modify it in all cases. So maybe this is fixed.
I'll consider it provisionally fixed for now, and update this issue if I see it again.


Status Effects always in effect no matter Condition

The Status Effects are adjusting the stat even if the Condition has a larger number. It should only take happen if the Condition is a lower than the Status Effect.

#57 fixes this issue


[Future Request] New function too reload the phrase files

Hi @dawalters1
Thank you for all you hard work and this awesome library "Wolf.js" it's make our unofficial bot doing great.
So allow me to ask you if there any chance to add a new function to phrase helper file called reload so we can update the phrase file's without restart the bot.
basics of function Reload :
// clear the _phrase
clear();
// call _local_load
_local_load();
Again thank you and look forward to v2 . Can't wait .

https://github.com/dawalters1/wolf.js/blob/version2/src/helper/phrase/Phrase.js#L19

i ask if you can do it on this version as well


Make lib.crc documentation introduction consistent with other stdlib modules

Do you mind adjusting the commit message to match our conventions, too?

Oops, done.

Thanks!


Possibility to change size on text, cover art.

Hi, is there a way to change the text size? Or better yet give an option like  size: "xsmall", "small", "medium", "large", etc.

Still interested in this? Would config options for roomName and artifst/trackName be sufficient?

yepp, that would be great !
thx


Link to privacy policy in footer is broken

What happened?
Link to privacy policy: https://www.linuxfoundation.org/en/privacy/#:~:text=The Linux Foundation's core purpose,%2C a “Project”).&text=The Privacy Policy does not,employees or other TLF personnel. does not exist

What did you expect would happen?
Privacy policy link should take the user to: https://www.linuxfoundation.org/legal/privacy-policy
What is the name + path of the page where you encountered the issue?
Homepage: https://opentelemetry.io
What browser, OS, and platform were you using when you encountered the problem?
MacOS + Safari

Oh, thanks! @raunaqgupta

do you want to provide a PR for it?


fix(FX-4315): hide artsy guarantee in some cases

The type of this PR is: Fix

This PR solves FX-4315
Description
Hides Artsy guarantee section when an artwork is:

sold
in auction
isOfferableFromInquiry: false

thanks @araujobarret


⚠ Bofrost.at has degraded performance

In 5ddcd37, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2787 ms

Resolved: Bofrost.at performance has improved in c19157c.


Bug fix for existential subquery in legacy syntax

Pull Request Test Coverage Report for Build 1271

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.08%) to 77.307%

Totals

Change from base Build 1270:
0.08%

Covered Lines:
10012

Relevant Lines:
12450

💛  - Coveralls


change-able window size

dont have neuralnote be fixed to one size. weirdly enough updating the window size is the only way to refresh what the gui is displaying on linux with wine

the "RECORD" button doesn't seem to do anything and the dropdowns don't show the updated selection until a full repaint of the settings window (by closing and opening it again). having it not be able to change size genuinely breaks the program on linux

I don't plan on making the UI resizable. But if someone knows a simple way to do it and wants to contribute, I'm open.
Also, please stop referring to issues your having with Wine on Linux as it is not and will not be supported.

I don't plan on making the UI resizable. But if someone knows a simple way to do it and wants to contribute, I'm open.
Also, please stop referring to issues you're having with Wine on Linux as it is not and will not be supported.

looking at the source code now, i think the neuralnotemainview is being repainted from memory over and over and thats what causing the bug. im too drunk and tired to actually know if thats whats happening and my understanding of c is shite so apologies if this is a witchhunt but there 100% is something wrong somewhere, i can screen record the bug if needed

void NeuralNoteMainView::paint(Graphics& g)
{
// is this re-painting the display over and over again?
auto background_image = juce::ImageCache::getFromMemory(BinaryData::background_png, BinaryData::background_pngSize);

the background image is loaded from memory in the paint method using the juce::ImageCache::getFromMemory function. this means that every time the paint method is called, the image is retrieved from memory.

im pretty sure but i dont understand this all well enough

would something like this make more sense
// Initialize the background image to a default image
currentBackgroundImage = juce::ImageCache::getFromMemory(BinaryData::background_png, BinaryData::background_pngSize);
// Use the currentBackgroundImage as the background
// Reusing the loaded image, which was already loaded during object construction.
g.drawImage(currentBackgroundImage, getLocalBounds().toFloat());

if this is giibberish i apologise i genuinely am off my rocker with whiskey apologies

would something like this make more sense

by the way this is designed to allow for future modification of the image
// this is just pseudo-code and probably doesnt work but you get what im trying to say here
juce::FileChooser fileChooser("Select a background image...",
juce::File::getSpecialLocation(juce::File::userPicturesDirectory));
if (fileChooser.browseForFileToOpen()) {
juce::File selectedImageFile = fileChooser.getResult();
currentBackgroundImage = juce::ImageFileFormat::loadFrom(selectedImageFile);
}
// redraw new image
repaint();

if what i said makes no sense apologies, i can screen record the issue if you want to see for yourself

tl;dr: i think but am not sure that the image is being re-loaded from memory in the paint method using the juce::ImageCache::getFromMemory function. this means that every time the paint method is called, the image is retrieved from memory causing weird graphical issues. i am trying to update the code to load the image once and reuse it in the paint method


Remove @tbdex-js api reference

When we merge this: https://github.com/TBD54566975/tbdex-js/pull/116
We need to do the following in our developer website:

expose a link to https://tbd54566975.github.io/tbdex-js in our API Reference Guides page
forward any tbdex-js api reference to the new https://tbd54566975.github.io/tbdex-js address:

The ExchangesApi link should point to https://tbd54566975.github.io/tbdex-js/interfaces/_tbdex_http_server.ExchangesApi.html

remove our https://developer.tbd.website/docs/tbdex/api-reference folder

ok sounds good

Can i work on it

The PR is already merged! So you are good to work on this! I really appreciate the offer! :)

Can i work on it

hey, thank you! here's all that needs to be done:

add card on API Reference page
Change tbDEX → API Reference on navbar to point to external page (kinda tricky)
Update link in Message Types guide to point to external page
Update link in Anatomy of a PFI guide to point to external page
Update link in Creating Quotes guide to point to external page

which card I have to add on API Reference page

tbDEX → API Reference should point to this https://tbd54566975.github.io/tbdex-js link right?

Update link in Message Types guide to point to external page
Update link in Anatomy of a PFI guide to point to external page
Update link in Creating Quotes guide to point to external page
tell me the links to which I have to point to these

which card I have to add on API Reference page

tbDEX JS SDK


Maintaining documents in the keylime repo

Propose to merge keylime documentation repo to the keylime repository, this move will helps we maintain document update with code changes more conveniently.

I strongly support this proposal. After several months contributing code to keylime, I observe that the effect o having documentation on a separate repository on me is to make me less likely of updating documentation pari passu with the changes on the code.

We could do this if it meant folk actually bothering to document their changes (I am sceptical to be honest). Otherwise we are just rearranging the furniture, but the underlying problem still remains.

I think this would be a good change because there have been times I've wanted to hold off on merging something until it was documented. But I can't really do that as they are in 2 separate repos and that would mean documentation would have to land before code which isn't terrible, but a bit harder to coordinate.
With this change we could simply withhold merging something until the documentation is also part of the PR.

I'm supporting this change. I've now written my own tenant implementation and the current API documentation was not really helpful so I updated it.
If now more systems interact with Keylime we should have an up-to-date documentation for easier integration. Also the crypto and key derivation parts should be documented somewhere outside the original paper.

The change is done with https://github.com/keylime/keylime/pull/1018


Dev

Dear Sadra,
due to the issue #6, I've implemented the basic Player class in player.py which handles mafia players by instantiating this class each time a new user is added to the game. As a result, I had to change mafia.py, GOD.html and Player.html as well to conform to the new structure.

If you have time, I think it would be great if we make a class for Role too.

I couldn't agree more. This is actually what I am currently working on.

If you have time, I think it would be great if we make a class for Role too.

I couldn't agree more. This is actually what I am currently working on.

That's nice you can work on it too it won't cause any conflict but just in the case you can:
git remote add omid_repo https://github.com/Thepunisher79/mafia
git fetch omid_repo

and merge omid_repo/dev to your dev if it's necessary.

@Thepunisher79 It seems right practically.
After considering these minor issues I'll merge it.


added WEBSOCKET_URL var to build-client

Description
Small change to add the react web socket env var as a build argument

@ben16williams
After this PR, we had to do one more step to get the websocket working: we had to update what events the Stripe webhook listened for on the dev account dashboard. If staging and production use different webhooks, they'll need to be updated accordingly. I have included an image below of the events currently added. I also took this as an opportunity to also add the events that will be needed for PR #595.


ci(.github): add installer.sh tests

Runs installer.sh in docker containers for each listed OS.

Should this just delete /tests/installer.sh


Navbar styling rework

Extract navbar CSS to own file
Reduce height from 52px to 48px
Give every item a hover effect of of 36px, including the logo and on mobile
Consistent horizontal padding of 10px left and right

@wxiaoguang care to review?

I do not understand the layout ".menu > .navbar-left > .item", it doesn't seems a correct Fomantic UI layout.
If it wants to use Fomantic Menu, then I think it's better to follow Fomantic UI's examples. If it doesn't want to, then do not use "menu"

We can likely remove the fomantic menu, but it'll require a bit of more CSS as stuff like .active link styling relies on it.

I will have a look whether this can be cleanup up easily.

Wow this turns out too be way too tricky because of how much of a hack this mobile menu is.

It seems fragile to do ".menu > .navabr-left > .item" and ".menu > .navabr-right > .item"
If it needs to re-use Fomantic styles, it could be:

Then it doesn't violate Fomantic UI structures.
While I won't block it.

Implemented this now, it took some effort with making mobile menu flex-wrap and the first two items 50% width, but it seems to work fine now.

There's some regression in the dropdown menus, fixing...

All fixed. These nested .item were the problem.


[Need Help!] Got "tx parse error" with abci_code "65538" when send transactions using go-sdk!

I tried to send BNB, but got error message like this:
{   "jsonrpc": "2.0",   "id": "",   "result": {     "check_tx": {       "code": 65538,       "log": "{\"codespace\":1,\"code\":2,\"abci_code\":65538,\"message\":\"tx parse error\"}"     },     "deliver_tx": {},     "hash": "859D06623E35669FC042F268BF5493D29AB3D2C14672F5424955CD031AF57028",     "height": "0"   } }
Below show what I did :
I add a test demo in keys/keys_test.go
`
    func TestTransferBNB( t *testing.T) {
fromKeyManager, err := NewPrivateKeyManager("7a4be77ccd436458e7fc3093d47cfa6fd27f027117c4fe026466aefe270a953a")
if err != nil {
	t.Error(err)
	return
}
from := fromKeyManager.GetAddr()
to, _ := hex.DecodeString("33b9e9c387328b16823aa9a0dbfa22c4dcacd80a")
accountNumber := int64(208884)
sequence := int64(0)
sendMsg := msg.CreateSendMsg(from, ctypes.Coins{ctypes.Coin{Denom: "BNB", Amount: 5000000}}, []msg.Transfer{{to, ctypes.Coins{ctypes.Coin{Denom: "BNB", Amount: 5000000}}}})

signMsg := tx.StdSignMsg{
	ChainID:       "Binance-Chain-Tigris",
	AccountNumber: accountNumber,
	Sequence:      sequence,
	Memo:          "",
	Msgs:          []msg.Msg{sendMsg},
	Source:        0,
}

signResult, err := fromKeyManager.Sign(signMsg)
if err != nil {
	t.Error(err)
	return
}
fmt.Println("transaction to send : ", "0x" + string(signResult))
 }

`
When send the signResult to binance chain, the "tx parse erro" occues.
Can anyone tell me why?  There are still very few BNB in from address, you can just run the demo and locate the error.
Thanks!

seems i added semicolon when submit transaction


Merge support ssh command

Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html

OK, Got it
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月23日(星期四) 下午3:20
收件人<EMAIL_ADDRESS>抄送: "裴龙武"<peilongwu<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] Merge support ssh command (#3283)
Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月23日(星期四) 下午3:20
收件人<EMAIL_ADDRESS>抄送: "裴龙武"<peilongwu<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] Merge support ssh command (#3283)
Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I already modify the pr title and comment.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月23日(星期四) 下午3:20
收件人<EMAIL_ADDRESS>抄送: "裴龙武"<peilongwu<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] Merge support ssh command (#3283)
Hi,
Please modify the pr title and add the pr content according the specifications[1]. Thx a lot for your good job~
[1] https://dolphinscheduler.apache.org/zh-cn/docs/development/pull-request.html
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi,
We can not include and use jsch officially in DolphinScheduler because of the licenses.

Hi,
Please make sure the 0.1.42 version license of jsch to avoid the license problem.

Hi,
I switch to your branch and check the feature.

Remote machine resources may not be suitable for being put with dataSources. And we can talk about the remote machine resource manage place. [1]

If you have any question or suggestion, welcome to put forward.

I add this test in root pom before.
I forgot to add this test when I solved the conflicts in this time.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月23日(星期四) 晚上7:55
收件人<EMAIL_ADDRESS>抄送: "裴龙武"<peilongwu<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command  (#3283)
@yangyichao-mango commented on this pull request.
In dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceService2Test.java:
> +import org.apache.dolphinscheduler.common.enums.UserType; +import org.apache.dolphinscheduler.dao.entity.User; +import org.junit.Assert; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.context.SpringBootTest; +import org.springframework.test.context.junit4.SpringRunner; + +import java.util.Map; + +@RunWith(SpringRunner.class) +@SpringBootTest(classes = ApiApplicationServer.class) +public class DataSourceService2Test {
Hi,
Why introduce this test case without adding this test to root pom?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月23日(星期四) 晚上10:42
收件人<EMAIL_ADDRESS>抄送: "裴龙武"<peilongwu<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command  (#3283)
Hi,
We can not include and use jsch officially in DolphinScheduler because of the licenses.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月23日(星期四) 晚上10:50
收件人<EMAIL_ADDRESS>抄送: "裴龙武"<peilongwu<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command  (#3283)
Hi,
Please make sure the 0.1.42 version license of jsch to avoid the license problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Hi,
I have checked the license of jsch, it is suitable for DolphinScheduler~
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月24日(星期五) 上午10:02
收件人<EMAIL_ADDRESS>抄送: "Yichao Yang"<1048262223<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command  (#3283)
I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"                                                                                <notifications@github.com>;
发送时间: 2020年7月23日(星期四) 晚上10:50
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "裴龙武"<peilongwu@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command  (#3283)
Hi,
Please make sure the 0.1.42 version license of jsch to avoid the license problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I do not have a good idea to add many remote servers. If we can not add these remote servers to data source, we must develop a new feature to manage remote server.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月23日(星期四) 晚上11:09
收件人<EMAIL_ADDRESS>抄送: "裴龙武"<peilongwu<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command  (#3283)
Hi,
I switch to your branch and check the feature.
Remote machine resources may not be suitable for being put with dataSources. And we can talk about the remote machine resource manage place. [1]
If you have any question or suggestion, welcome to put forward.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

OK, it's very  good.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月24日(星期五) 上午10:04
收件人<EMAIL_ADDRESS>抄送: "裴龙武"<peilongwu<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command  (#3283)
Hi,
I have checked the license of jsch, it is suitable for DolphinScheduler~
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"                                                                                <notifications@github.com>;
发送时间: 2020年7月24日(星期五) 上午10:02
收件人: "apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com>;
抄送: "Yichao Yang"<1048262223@qq.com>;"Mention"<mention@noreply.github.com>;
主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command  (#3283)
I do not import jsch in DolphinScheduler. When I use jsch, it's already in that.
------------------&nbsp;原始邮件&nbsp;------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"                                                                                <notifications@github.com&gt;;
发送时间:&nbsp;2020年7月23日(星期四) 晚上10:50
收件人:&nbsp;"apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com&gt;;
抄送:&nbsp;"裴龙武"<peilongwu@qq.com&gt;;"Author"<author@noreply.github.com&gt;;
主题:&nbsp;Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command  (#3283)
Hi,
Please make sure the 0.1.42 version license of jsch to avoid the license problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

It has a lot of cases to use many remote serves to execute some shell commands. So I think that we must to design a good method to support this feature.
I want to add a new table to manage the remote servers， but many committers feel that this change is too big. They think we can manage remote servers like data sources. So I develop this feature like this.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月23日(星期四) 晚上11:09
收件人<EMAIL_ADDRESS>抄送: "裴龙武"<peilongwu<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command  (#3283)
Hi,
I switch to your branch and check the feature.
Remote machine resources may not be suitable for being put with dataSources. And we can talk about the remote machine resource manage place. [1]
If you have any question or suggestion, welcome to put forward.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

It has a lot of cases to use many remote serves to execute some shell commands. So I think that we must to design a good method to support this feature. I want to add a new table to manage the remote servers， but many committers feel that this change is too big. They think we can manage remote servers like data sources. So I develop this feature like this.
…
------------------ 原始邮件 ------------------ 发件人: "apache/incubator-dolphinscheduler"<EMAIL_ADDRESS>发送时间: 2020年7月23日(星期四) 晚上11:09 收件人<EMAIL_ADDRESS>抄送: "裴龙武"<peilongwu<EMAIL_ADDRESS>主题: Re: [apache/incubator-dolphinscheduler] [Feature-2585][server] Support ssh command (#3283) Hi, I switch to your branch and check the feature. Remote machine resources may not be suitable for being put with dataSources. And we can talk about the remote machine resource manage place. [1] If you have any question or suggestion, welcome to put forward. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

I got it.

When I set the password free login, and I do not set the password in the remote server settings, the following error will appear. Do we have to set the password when we want to login in the remote server? In a lot of scene,  we already set the password free login. Can you add the password free login to the sshtask?

@peilongwu , supporting ssh task will be an important feature, and could you add password free to ssh task?  by the way, please solve the conflicting files, thx

Hi,
When I set the password free login, and I do not set the password in the remote server settings, the following error will appear. Do we have to set the password when we want to login in the remote server? In a lot of scene, we already set the password free login. Can you add the password free login to the sshtask?

@peilongwu , supporting ssh task will be an important feature, and could you add password free to ssh task? by the way, please solve the conflicting files, thx

Hi,
When I set the password free login, and I do not set the password in the remote server settings, the following error will appear. Do we have to set the password when we want to login in the remote server? In a lot of scene, we already set the password free login. Can you add the password free login to the sshtask?

OK, I will perfect this feature in the next time.  I was changing job recently. Now I  work in a new company and I have times to finish this feature.

there are some conflict files need to be sovled, please solve it locally, then I will merge into dev, thx

no update.


Use xl runners for test/lint

Not sure if these work, but they seem to be used in other repos in the org, so maybe they exist.

Hm, I guess only GitHub themselves have this runner type; I was bamboozled by https://github.com/search?q=%2Fruns-on%3A+ubuntu-latest-%2F+lang%3Ayaml+owner%3Amicrosoft&type=code. But maybe we have other ones available.


Ability to see previous versions of the specification for an interface

As of v0.1.1 of Spectacular, for a given interface, it is currently only possible to view the "Latest agreed version" of the interface's specification and any number of versions with "Proposed Changes" currently open against it.
As seen in the screen shot below, it would be good to show a list of previous versions of the interface specification.

The previous versions could be determined by identifying git tags that were created for each previous version of the specification file.

As of v0.2.0, after the UI refresh #19, here is a potential mockup of how the "Spec Evolution" could be extended to achieve this request.


[cf-core] Add regex support to test container

Right now, you have to run make test-cf which runs every test and takes ages. Adding regex support to the jest config/bash scripts would help speed up iterations immensely.

Yes please.

make is great for shortcuts & simplifying CI/CD but sadly it doesn't accept command line args.
That's fine though bc the test script itself already supports this. You can run just one test like this:
$ bash ops/test-cf.sh modules/cf-core/test/machine/integration/setup-then-set-state.spec.ts
Starting indra_ethprovider_cf_tester..
e924c5fa08b4a5414f871d756181c8d3a415cc2b1bd20952c09096da281e72f8
CF tester container launched!
Waiting for ethprovider to wake up..
Launching tests!

 PASS  test/machine/integration/setup-then-set-state.spec.ts (10.826s)
  Scenario: Setup, set state on free balance, go on chain
    ✓ should distribute funds in ETH free balance when put on chain (5889ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        10.888s
Ran all test suites matching /modules\/cf-core\/test\/machine\/integration\/setup-then-set-state.spec.ts/i.
Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?

Tests finished, stopping test containers..
indra_ethprovider_cf_tester


"Learnt compile failed" if path to file contains "&"

Perhaps simple escaping this symbol will solve this issue.

I think I’ve tried to resolve this in the past and not found it so straightforward.

The relevant  line is 229 in the injectSource.pl script bundle. You could try:
   (my $escaped = $selectedFile) =~ s/([‘ &])/\\$1/g;