EVA CLIP is EVA02-CLIP-L-14-336, error

The EVA CLIP is EVA02-CLIP-L-14-336, but should be downloaded automatically (will be located in the huggingface directory).
I don't know why it can't be downloaded automatically. There is no manual download address either...

File "D:\ComfyUI\custom_nodes\PuLID_ComfyUI\eva_clip\pretrained.py", line 300, in download_pretrained_from_hf
cached_file = hf_hub_download(model_id, filename, revision=revision, cache_dir=cache_dir)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\sunny.conda\envs\comfyui\Lib\site-packages\huggingface_hub\utils_validators.py", line 118, in _inner_fn
return fn(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^
File "C:\Users\sunny.conda\envs\comfyui\Lib\site-packages\huggingface_hub\file_download.py", line 1406, in hf_hub_download
raise LocalEntryNotFoundError(
huggingface_hub.utils._errors.LocalEntryNotFoundError: An error happened while trying to locate the file on the Hub and we cannot find the requested files in the local cache. Please check your connection and try again or make sure your Internet connection is on.

I have the same problem, EVA02-CLIP-L-14-336 does not automatically download from huggingface. Tip: “An error happened while trying to locate the file on the Hub and we cannot find the requested files in the local cache. Please check your connection and try again or make sure your Internet connection is on.” But I made sure the network is fine. But it won't download and I know where the downloaded path is!

same error

https://github.com/cubiq/PuLID_ComfyUI/issues/8

I placed the file I downloaded, EVA02_CLIP_L_336_psz14_s6B.pt, in the folder on my local machine at ~/.cache/huggingface/hub/models--QuanSun--EVA-CLIP/snapshots/11afd202f2ae80869d6cef18b1ec775e79bd8d12/. However, after running it, I still get the same error message and I'm not sure what the problem is. Could you please translate the above text into English for me?

I placed the file I downloaded, EVA02_CLIP_L_336_psz14_s6B.pt, in the folder on my local machine at ~/.cache/huggingface/hub/models--QuanSun--EVA-CLIP/snapshots/11afd202f2ae80869d6cef18b1ec775e79bd8d12/. However, after running it, I still get the same error message................... It seems that downloading one file is not enough, there are many files to download, if the environment is not smooth, still can not use

This method is actually possible, but it still requires a file, models -- QuanSun -- EVA CLIP/refs/main, with the file content being 11afd202f2ae80869d6cef18b1ec775e79bd8d12 for testing and can be used

I placed the file I downloaded, EVA02_CLIP_L_336_psz14_s6B.pt, in the folder on my local machine at ~/.cache/huggingface/hub/models--QuanSun--EVA-CLIP/snapshots/11afd202f2ae80869d6cef18b1ec775e79bd8d12/. However, after running it, I still get the same error message................... It seems that downloading one file is not enough, there are many files to download, if the environment is not smooth, still can not use

This method is actually possible, but it still requires a file, models -- QuanSun -- EVA CLIP/refs/main, with the file content being 11afd202f2ae80869d6cef18b1ec775e79bd8d12 for testing and can be used

thanks,It's working.

I saw a lot of EVA files in -QuanSun--EVA-CLIP. When I only downloaded EVA02_CLIP_L_336_psz14_s6B.pt and models -- QuanSun -- EVA CLIP/refs/main, I still got an error. Should I put all the files on huggingface? Can it be used after downloading everything?

Why not just put the chekpoint in the path /models/eva_clips and Load_EVA_Clip with checkpoint name list like ipadapter loader?
And models/facedection is already used by reactor, so I add the path
FACEDETECTION_DIR = os.path.join(folder_paths.models_dir, "facedetection") if "facedetection" not in folder_paths.folder_names_and_paths:     current_paths = [FACEDETECTION_DIR] else:     current_paths, _ = folder_paths.folder_names_and_paths["facedetection"] folder_paths.folder_names_and_paths["facedetection"] = (current_paths, folder_paths.supported_pt_extensions)
and add the model_rootpath to FaceRestoreHelper
face_helper = FaceRestoreHelper(             upscale_factor=1,             face_size=512,             crop_ratio=(1, 1),             det_model='retinaface_resnet50',             save_ext='png',             device=device,             model_rootpath=FACEDETECTION_DIR         )

My cache path is  .cache/huggingface/hub/models--QuanSun--EVA-CLIP, just put download file in this folder
with pdb, the download codes is in ComfyUI/custom_nodes/PuLID_ComfyUI/eva_clip/pretrained.py
def download_pretrained_from_hf(         model_id: str,         filename: str = 'open_clip_pytorch_model.bin',         revision=None,         cache_dir: Union[str, None] = None, ):     has_hf_hub(True)     cached_file = hf_hub_download(model_id, filename, revision=revision, cache_dir=cache_dir)     return cached_file

Loaded EVA02-CLIP-L-14-336 model config.
Shape of rope freq: torch.Size([576, 64])
Loading pretrained EVA02-CLIP-L-14-336 weights (eva_clip).
incompatible_keys.missing_keys: ['visual.rope.freqs_cos', 'visual.rope.freqs_sin', 'visual.blocks.0.attn.rope.freqs_cos', 'visual.blocks.0.attn.rope.freqs_sin', 'visual.blocks.1.attn.rope.freqs_cos', 'visual.blocks.1.attn.rope.freqs_sin', 'visual.blocks.2.attn.rope.freqs_cos', 'visual.blocks.2.attn.rope.freqs_sin', 'visual.blocks.3.attn.rope.freqs_cos', 'visual.blocks.3.attn.rope.freqs_sin', 'visual.blocks.4.attn.rope.freqs_cos', 'visual.blocks.4.attn.rope.freqs_sin', 'visual.blocks.5.attn.rope.freqs_cos', 'visual.blocks.5.attn.rope.freqs_sin', 'visual.blocks.6.attn.rope.freqs_cos', 'visual.blocks.6.attn.rope.freqs_sin', 'visual.blocks.7.attn.rope.freqs_cos', 'visual.blocks.7.attn.rope.freqs_sin', 'visual.blocks.8.attn.rope.freqs_cos', 'visual.blocks.8.attn.rope.freqs_sin', 'visual.blocks.9.attn.rope.freqs_cos', 'visual.blocks.9.attn.rope.freqs_sin', 'visual.blocks.10.attn.rope.freqs_cos', 'visual.blocks.10.attn.rope.freqs_sin', 'visual.blocks.11.attn.rope.freqs_cos', 'visual.blocks.11.attn.rope.freqs_sin', 'visual.blocks.12.attn.rope.freqs_cos', 'visual.blocks.12.attn.rope.freqs_sin', 'visual.blocks.13.attn.rope.freqs_cos', 'visual.blocks.13.attn.rope.freqs_sin', 'visual.blocks.14.attn.rope.freqs_cos', 'visual.blocks.14.attn.rope.freqs_sin', 'visual.blocks.15.attn.rope.freqs_cos', 'visual.blocks.15.attn.rope.freqs_sin', 'visual.blocks.16.attn.rope.freqs_cos', 'visual.blocks.16.attn.rope.freqs_sin', 'visual.blocks.17.attn.rope.freqs_cos', 'visual.blocks.17.attn.rope.freqs_sin', 'visual.blocks.18.attn.rope.freqs_cos', 'visual.blocks.18.attn.rope.freqs_sin', 'visual.blocks.19.attn.rope.freqs_cos', 'visual.blocks.19.attn.rope.freqs_sin', 'visual.blocks.20.attn.rope.freqs_cos', 'visual.blocks.20.attn.rope.freqs_sin', 'visual.blocks.21.attn.rope.freqs_cos', 'visual.blocks.21.attn.rope.freqs_sin', 'visual.blocks.22.attn.rope.freqs_cos', 'visual.blocks.22.attn.rope.freqs_sin', 'visual.blocks.23.attn.rope.freqs_cos', 'visual.blocks.23.attn.rope.freqs_sin']

that's fine

I placed the file I downloaded, EVA02_CLIP_L_336_psz14_s6B.pt, in the folder on my local machine at ~/.cache/huggingface/hub/models--QuanSun--EVA-CLIP/snapshots/11afd202f2ae80869d6cef18b1ec775e79bd8d12/. However, after running it, I still get the same error message................... It seems that downloading one file is not enough, there are many files to download, if the environment is not smooth, still can not use

This method is actually possible, but it still requires a file, models -- QuanSun -- EVA CLIP/refs/main, with the file content being 11afd202f2ae80869d6cef18b1ec775e79bd8d12 for testing and can be used

thanks,It's working.

I tried this, but it didn't work. The model keeps reporting errors.

Hello Matteo,
Thank you for your outstanding work—the nodes and tutorials have been incredibly helpful to me. I came across the PuLID video on YouTube, which was truly impressive. However, in the process of using this node, I encountered issues similar to those with EVA02-CLIP-L-14-336, and it seems there is currently no reliable solution (if there is already a solution, could you please let me know directly, as my English might not be good enough to miss it). Please fix it if possible—should PuLID be applicable to commercial processes, I can apply for sponsorship from my institution to help you focus more on development work. Thank you once again for everything you've done.

I also had the problem with eva clip loader getting stuck and not progressing.
I manually downloaded it from here
https://huggingface.co/QuanSun/EVA-CLIP/tree/main
only the file EVA02_CLIP_L_336_psz14_s6B.pt
i put it in the folder ComfyUI\models\clip
after restarting comfyui various times, it decided to work.

可帮解决，+v：八七六八七六二七

https://zhuanlan.zhihu.com/p/697350603#/  this article helps！

Load pulid model from ipadapter folder---line 201 & 208:

return {"required": { "pulid_file": (os.listdir(os.path.join(folder_paths.models_dir, 'ipadapter')), )}}

ckpt_path = os.path.join(folder_paths.models_dir, 'ipadapter', pulid_file)

Load evaclip from clip_vision folder or autodownload (download to huggingface cache folder (C:\Users\username\.cache\huggingface\hub) on windows)---line 259:

from .eva_clip.factory import create_model_and_transforms

        eva_clip_model_path = os.path.join(folder_paths.models_dir, "clip_vision\EVA02_CLIP_L_336_psz14_s6B.pt")
        if not os.access(eva_clip_model_path, os.F_OK):
            eva_clip_model_path = 'eva_clip'
        # model, _, _ = create_model_and_transforms('EVA02-CLIP-L-14-336', 'eva_clip', force_custom_clip=True)
        model, _, _ = create_model_and_transforms('EVA02-CLIP-L-14-336', pretrained=eva_clip_model_path, force_custom_clip=True)

        model = model.visual

Load Insightface model from facedetection folder---line334---(Not test):

image = tensor_to_image(image)

        FACEDETECTION_DIR = os.path.join(folder_paths.models_dir, "facedetection")
        face_helper = FaceRestoreHelper(
            upscale_factor=1,
            face_size=512,
            crop_ratio=(1, 1),
            det_model='retinaface_resnet50',
            save_ext='png',
            device=device,
            model_rootpath=FACEDETECTION_DIR,
        )

        face_helper.face_parse = None

重新在管理器中安装一下PuLID_ComfyUI  问题就解决了

I tried this, but it didn't work. The model keeps reporting errors.

download the model form huggingface
filename : EVA02_CLIP_L_336_psz14_s6B.pt
put it in /comfyui/models/LLM  :)

Loaded EVA02-CLIP-L-14-336 model config. Shape of rope freq: torch.Size([576, 64]) Loading pretrained EVA02-CLIP-L-14-336 weights (eva_clip). incompatible_keys.missing_keys: ['visual.rope.freqs_cos', 'visual.rope.freqs_sin', 'visual.blocks.0.attn.rope.freqs_cos', 'visual.blocks.0.attn.rope.freqs_sin', 'visual.blocks.1.attn.rope.freqs_cos', 'visual.blocks.1.attn.rope.freqs_sin', 'visual.blocks.2.attn.rope.freqs_cos', 'visual.blocks.2.attn.rope.freqs_sin', 'visual.blocks.3.attn.rope.freqs_cos', 'visual.blocks.3.attn.rope.freqs_sin', 'visual.blocks.4.attn.rope.freqs_cos', 'visual.blocks.4.attn.rope.freqs_sin', 'visual.blocks.5.attn.rope.freqs_cos', 'visual.blocks.5.attn.rope.freqs_sin', 'visual.blocks.6.attn.rope.freqs_cos', 'visual.blocks.6.attn.rope.freqs_sin', 'visual.blocks.7.attn.rope.freqs_cos', 'visual.blocks.7.attn.rope.freqs_sin', 'visual.blocks.8.attn.rope.freqs_cos', 'visual.blocks.8.attn.rope.freqs_sin', 'visual.blocks.9.attn.rope.freqs_cos', 'visual.blocks.9.attn.rope.freqs_sin', 'visual.blocks.10.attn.rope.freqs_cos', 'visual.blocks.10.attn.rope.freqs_sin', 'visual.blocks.11.attn.rope.freqs_cos', 'visual.blocks.11.attn.rope.freqs_sin', 'visual.blocks.12.attn.rope.freqs_cos', 'visual.blocks.12.attn.rope.freqs_sin', 'visual.blocks.13.attn.rope.freqs_cos', 'visual.blocks.13.attn.rope.freqs_sin', 'visual.blocks.14.attn.rope.freqs_cos', 'visual.blocks.14.attn.rope.freqs_sin', 'visual.blocks.15.attn.rope.freqs_cos', 'visual.blocks.15.attn.rope.freqs_sin', 'visual.blocks.16.attn.rope.freqs_cos', 'visual.blocks.16.attn.rope.freqs_sin', 'visual.blocks.17.attn.rope.freqs_cos', 'visual.blocks.17.attn.rope.freqs_sin', 'visual.blocks.18.attn.rope.freqs_cos', 'visual.blocks.18.attn.rope.freqs_sin', 'visual.blocks.19.attn.rope.freqs_cos', 'visual.blocks.19.attn.rope.freqs_sin', 'visual.blocks.20.attn.rope.freqs_cos', 'visual.blocks.20.attn.rope.freqs_sin', 'visual.blocks.21.attn.rope.freqs_cos', 'visual.blocks.21.attn.rope.freqs_sin', 'visual.blocks.22.attn.rope.freqs_cos', 'visual.blocks.22.attn.rope.freqs_sin', 'visual.blocks.23.attn.rope.freqs_cos', 'visual.blocks.23.attn.rope.freqs_sin']

Hi, is this message normal?

Let me just add,
1: The file is stored in the directory [ComfyUI.cache\huggingface\hub\models--QuanSun--EVA-CLIP],
2: There are two folders in the directory: snapshots and refs.
3: the [EVA02_CLIP_L_336_psz14_s6B. Pt] in [models - QuanSun - EVA - CLIP \ 11 afd202f2ae80869d6cef18b1ec775e79bd8d12 snapshots ] Within the directory,
4: [refs] a [main] file folder, remember that no suffix, this is an editable text file, inside the input for afd202f2ae80869d6cef18b1ec775e79bd8d12 [11]

This method is actually possible, but it still requires a file, models -- QuanSun -- EVA CLIP/refs/main, with the file content being 11afd202f2ae80869d6cef18b1ec775e79bd8d12 for testing and can be used

https://zhuanlan.zhihu.com/p/697350603#/ this article helps！

Please share a website that can be used by other people outside China. Or just put the solution you read here.

I placed the file I downloaded, EVA02_CLIP_L_336_psz14_s6B.pt, in the folder on my local machine at ~/.cache/huggingface/hub/models--QuanSun--EVA-CLIP/snapshots/11afd202f2ae80869d6cef18b1ec775e79bd8d12/. However, after running it, I still get the same error message................... It seems that downloading one file is not enough, there are many files to download, if the environment is not smooth, still can not use

This method is actually possible, but it still requires a file, models -- QuanSun -- EVA CLIP/refs/main, with the file content being 11afd202f2ae80869d6cef18b1ec775e79bd8d12 for testing and can be used

thanks,It's working.

I tried this, but it didn't work. The model keeps reporting errors.

I have two computers both installed pulid, but the EVA clip automatically downloaded in different folders.
Computer A is as said in the ~/.cache/huggingface/hub/models--QuanSun--EVA-CLIP/snapshots/11afd202f2ae80869d6cef18b1ec775e79bd8d12/ folder,
with a notype text file named main in the ~/.cache/huggingface/hub/models--QuanSun--EVA-CLIP/refs/ folder with the content being 11afd202f2ae80869d6cef18b1ec775e79bd8d12 .
Computer B is in the ~/.cache/huggingface/hub/.locks/models--QuanSun--EVA-CLIP/snapshots/11afd202f2ae80869d6cef18b1ec775e79bd8d12/ folder,
with a notype text file named main in the ~/.cache/huggingface/hub/.locks/models--QuanSun--EVA-CLIP/refs/ folder with the content being 11afd202f2ae80869d6cef18b1ec775e79bd8d12 .
I don’t know why this happened, but pulid works normally on both computers.
Maybe you should try to put the EVA clip as my computer B.

直接把huggingface改为镜像源可以完成下载，但是下载完依旧有错，下面是报错：
Loaded EVA02-CLIP-L-14-336 model config.
Shape of rope freq: torch.Size([576, 64])
Loading pretrained EVA02-CLIP-L-14-336 weights (eva_clip).
incompatible_keys.missing_keys: ['visual.rope.freqs_cos', 'visual.rope.freqs_sin', 'visual.blocks.0.attn.rope.freqs_cos', 'visual.blocks.0.attn.rope.freqs_sin', 'visual.blocks.1.attn.rope.freqs_cos', 'visual.blocks.1.attn.rope.freqs_sin', 'visual.blocks.2.attn.rope.freqs_cos', 'visual.blocks.2.attn.rope.freqs_sin', 'visual.blocks.3.attn.rope.freqs_cos', 'visual.blocks.3.attn.rope.freqs_sin', 'visual.blocks.4.attn.rope.freqs_cos', 'visual.blocks.4.attn.rope.freqs_sin', 'visual.blocks.5.attn.rope.freqs_cos', 'visual.blocks.5.attn.rope.freqs_sin', 'visual.blocks.6.attn.rope.freqs_cos', 'visual.blocks.6.attn.rope.freqs_sin', 'visual.blocks.7.attn.rope.freqs_cos', 'visual.blocks.7.attn.rope.freqs_sin', 'visual.blocks.8.attn.rope.freqs_cos', 'visual.blocks.8.attn.rope.freqs_sin', 'visual.blocks.9.attn.rope.freqs_cos', 'visual.blocks.9.attn.rope.freqs_sin', 'visual.blocks.10.attn.rope.freqs_cos', 'visual.blocks.10.attn.rope.freqs_sin', 'visual.blocks.11.attn.rope.freqs_cos', 'visual.blocks.11.attn.rope.freqs_sin', 'visual.blocks.12.attn.rope.freqs_cos', 'visual.blocks.12.attn.rope.freqs_sin', 'visual.blocks.13.attn.rope.freqs_cos', 'visual.blocks.13.attn.rope.freqs_sin', 'visual.blocks.14.attn.rope.freqs_cos', 'visual.blocks.14.attn.rope.freqs_sin', 'visual.blocks.15.attn.rope.freqs_cos', 'visual.blocks.15.attn.rope.freqs_sin', 'visual.blocks.16.attn.rope.freqs_cos', 'visual.blocks.16.attn.rope.freqs_sin', 'visual.blocks.17.attn.rope.freqs_cos', 'visual.blocks.17.attn.rope.freqs_sin', 'visual.blocks.18.attn.rope.freqs_cos', 'visual.blocks.18.attn.rope.freqs_sin', 'visual.blocks.19.attn.rope.freqs_cos', 'visual.blocks.19.attn.rope.freqs_sin', 'visual.blocks.20.attn.rope.freqs_cos', 'visual.blocks.20.attn.rope.freqs_sin', 'visual.blocks.21.attn.rope.freqs_cos', 'visual.blocks.21.attn.rope.freqs_sin', 'visual.blocks.22.attn.rope.freqs_cos', 'visual.blocks.22.attn.rope.freqs_sin', 'visual.blocks.23.attn.rope.freqs_cos', 'visual.blocks.23.attn.rope.freqs_sin']

incompatible_keys.missing_keys: ['visual.rope.freqs_cos', 'visual.rope.freqs_sin', 'visual.blocks.0.attn.rope.freqs_cos', 'visual.blocks.0.attn.rope.freqs_sin'...

This log message can be ignored.
Please see https://github.com/baaivision/EVA/issues/56#issuecomment-1488570921


Data creation

@arokem We need to write a function to put data into AFQ-viz. One component of this is that each fiber should be sampled to 100 nodes.

This data structure should contain a core fiber with 100 nodes

With pull request #13, we no longer need a separate core fiber in the data structure.


Refactor/remove unecessary inspect calls

Remove unnecessary inspect calls.
absinthe-graphql/absinthe#573 issue has shown a big percentual time to resolve queries after they're fetched from the database.
After some debug @jeroenvisser101 pointed one of the problems.

... I did some further investigation, and found that the inspect calls are actually made from dataloader: absinthe-graphql/dataloader@ce9ac3f#diff-cb130db1770f44aedd393088b4d91bcdR252 ...

It seems like some changes were made in the way errors are reported. Dataloader.Ecto seems to rely on errors to update pending batches, because it abuses fetch/3 to check if a value has previously been loaded. If we either added a argument to fetch/3 to toggle detailed errors, or to introduce fetched?/3 and used that in load/3, we would prevent inspect calls.

I got the call and refactored load creating a fetched?/3 function, so it will not pass through unnecessary inspect calls on both kv and ecto implementations.
Debugging the problem summed inspect calls represents 13% of the time (sample above).
'Elixir.Inspect.Atom':inspect/2                                                                   40000     0.18     5363  [      0.13]
'Elixir.Inspect.Algebra':'-container_doc/6-fun-0-'/4                                              50000     0.19     5622  [      0.11]
'Elixir.Inspect.Algebra':nest/2                                                                   10000     0.08     2290  [      0.23]
'Elixir.Inspect.Tuple':inspect/2                                                                  10000     0.05     1577  [      0.16]
'Elixir.Inspect.Map':inspect/3                                                                    10000     0.06     1715  [      0.17]
'Elixir.Inspect.PID':inspect/2                                                                    10000     0.06     1804  [      0.18]
'Elixir.Inspect.Algebra':container_each/6                                                         70000     0.42    12405  [      0.18]
'Elixir.Inspect.Algebra':flex_break/1                                                             50000     0.49    14245  [      0.28]
'Elixir.Inspect.Opts':'__struct__'/0                                                              10001     0.09     2494  [      0.25]
'Elixir.Inspect.Algebra':apply_nesting/3                                                          10000     0.09     2495  [      0.25]
'Elixir.Inspect.Algebra':group/2                                                                  20001     0.09     2775  [      0.14]
'Elixir.Inspect.Algebra':flex_glue/2                                                              50000     0.19     5665  [      0.11]
'Elixir.Inspect.Algebra':join/4                                                                   50000     0.22     6501  [      0.13]
'Elixir.Inspect.Algebra':flex_glue/3                                                              50000     0.22     6523  [      0.13]
'Elixir.Inspect.Atom':color_key/1                                                                 40000     0.32     9400  [      0.23]
'Elixir.Inspect':impl_for/1                                                                       70001     0.32     9406  [      0.13]
'Elixir.Inspect':'impl_for!'/1                                                                    70001     0.67    19677  [      0.28]
'Elixir.Inspect.Algebra':to_doc/2                                                                 70001     0.70    20405  [      0.29]
'Elixir.Inspect.Algebra':color/3                                                                 100001     0.81    23779  [      0.24]
'Elixir.Inspect.Algebra':decrement/1                                                              60000     1.08    31509  [      0.53]
'Elixir.Inspect.Algebra':concat/2                                                                180000     1.25    36417  [      0.20]
'Elixir.Inspect.Algebra':fold_doc/2                                                               60000     1.39    40727  [      0.68]
'Elixir.Inspect.Algebra':format/3                                                                410003     2.97    86865  [      0.21]

After the refactor the same query using Dataloader now goes from something like 11_502_307 to 8_260_419 fn calls. Complete results here.

@benwilson512 ping

Thank you!


Fix incorrect handling of request/response body data chain of ngx_buf_t buffers.

The documentation [http://nginx.org/en/docs/dev/development_guide.html#buffer]
clearly states that .pos, .last must be used to reference actual data
contained by the buffer. Whereas .start, .end denote the boundaries of the memory
block allocated for the buffer (in case of dynamically allocated data) or just
NULL (when .pos, .last reference a static memory location - one can see that
kind of usage in ngx_http_gzip_filter_module.c:ngx_http_gzip_filter_gzheader()).
To back up my words I invite to examine
ngx_http_charset_filter_module.c:ngx_http_charset_recode() as an example of
iteration over data contained in data buffer.
Without this fix ngx_http_modsecurity_body_filter feeds random bytes from
memory pointed by .start, .end range to msc_append_response_body. In my case
is was 8KB of data instead of 10 bytes when referenced by (.pos, .last).
That is this vulnerability may disclose sensitive data like passwords or
whatever from nginx heap.
The fix for ngx_http_modsecurity_pre_access_handler is to use .pos not .start to
reference data as they may differ in general case.

Thank you @turchanov, i will have a look together with @defanator.

@turchanov please disregard my latest comment here, messed up things a bit. Will provide more information later.

@turchanov this change looks good, though I'd use the ngx_buf_size() macro here. Also, it would be better to move chain assignment closer to the cycle in ngx_http_modsecurity_pre_access_handler() for better readability (I'd even love to use "standard" for loop as it is commonly used across the code and dev guide).
Consider the following patch on top of your one:
diff --git a/src/ngx_http_modsecurity_body_filter.c b/src/ngx_http_modsecurity_body_filter.c
index edf44f6..690190c 100644
--- a/src/ngx_http_modsecurity_body_filter.c
+++ b/src/ngx_http_modsecurity_body_filter.c
@@ -152,7 +152,8 @@ ngx_http_modsecurity_body_filter(ngx_http_request_t *r, ngx_chain_t *in)
         {
             u_char *data = chain->buf->pos;

-            msc_append_response_body(ctx->modsec_transaction, data, chain->buf->last - data);
+            msc_append_response_body(ctx->modsec_transaction, data,
+                                     ngx_buf_size(chain->buf));
             ret = ngx_http_modsecurity_process_intervention(ctx->modsec_transaction, r);
             if (ret > 0) {
                 return ngx_http_filter_finalize_request(r,
diff --git a/src/ngx_http_modsecurity_pre_access.c b/src/ngx_http_modsecurity_pre_access.c
index 6f4cbcb..3abfacc 100644
--- a/src/ngx_http_modsecurity_pre_access.c
+++ b/src/ngx_http_modsecurity_pre_access.c
@@ -131,8 +131,6 @@ ngx_http_modsecurity_pre_access_handler(ngx_http_request_t *r)

         dd("request body is ready to be processed");

-        ngx_chain_t *chain = r->request_body->bufs;
-
         /**
          * TODO: Speed up the analysis by sending chunk while they arrive.
          *
@@ -161,12 +159,13 @@ ngx_http_modsecurity_pre_access_handler(ngx_http_request_t *r)
             dd("inspection request body in memory.");
         }

+        ngx_chain_t *chain = r->request_body->bufs;
         while (chain && !already_inspected)
         {
             u_char *data = chain->buf->pos;

             msc_append_request_body(ctx->modsec_transaction, data,
-                chain->buf->last - data);
+                                    ngx_buf_size(chain->buf));

             if (chain->buf->last_buf) {
                 break;

dev/pull104 is now on our build bots.

I voiced some of my concerns about ngx_buf_size in my comment in #105. I thought that you would answer them...

Hi @turchanov,
I did not merged to main line yet. Place it in this new branch. Waiting for @defanator's comments.

If did you ask to re-post my comments from #105, I can do it, but @defanator already answered them in #105. I'am sorry if I caused such a confusion. So what do I need to do?

Merged. Thanks ;)

Merged. Thanks ;)


Consider deprecating MAKES_NON_ROOT

MAKES_NON_ROOT is only supported on a container level: https://github.com/fluidattacks/makes/blob/4e2e7ab3295e092237691336ec406273c54c3c4b/makes/container-image/main.nix#L135
This creates two m commands: One with MAKES_NON_ROOT support and another one without it.
If you try to reinstall makes via nix-env from the container, you end up with a Makes version that does not support MAKES_NON_ROOT. This creates strange behaviors that are very difficult to debug.

We will keep the makes user available so users can use it for tools that require to be executed with a non-root user.


Added all the provided links

all links have been added

Hey @Ijaiswalshivam  facing the same merge issue [Azure Static Web Apps CI/CD / Build and Deploy Job failed].
Is the problem from our end ?
@Anupkjha2601 do let us know

@manasi-jain it can only be answered by @Anupkjha2601 🥲

@Anupkjha2601 please merge it.

there is one conflict between 608 to 615 line in index.html file, so check it

conflict is resolved : )

done brother.

also please mark/label it to GSsoc'23


ocm-lib introduction

What this PR does / why we need it:
It provides an introduction and overview of the ocm-lib to help other developers to get started.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release Notes:

@fabianburth @mandelsoft What should happen with this issue?

Closed, as it's quite outdated by now and will not be prioritized in the near future.


[skip ci] dev-deploy: mnt path fix

PR Description
Type of change

[x] Bug fix

Summary of the change and which issue is fixed
Main changes: TODO

Checklist

I have run format.sh under script
I have commented my code, particularly in hard-to-understand areas
New and existing unit tests pass locally with my changes

r+ @YangKian

will fix in #840


Initial AbstractFactory changeset

I've created https://github.com/nicmcd/libfactory to host the factory. SuperSim has been upgraded to use this abstract factory methodology. Thank you!


A bit more flexible package.json

I think this covers minimum that everyone should have

is Anyone out there? @jeanregisser

@jeveloper these are devDependencies, why do you want to update them?

Just contributing  a bit to the project :)
By the way, RN 37 removes SliderIOS (although i dont think you use it) in favour of Slider

Thanks, I'm closing this as these are now outdated as well.


"Modbus Failure On State sending Get More About It By Logging"

Which node-red-contrib-modbus version are you using?
5.27.2
What happened?
I'm getting randomly the warning message "Modbus Failure On State sending Get More About It By Logging"
Server
"Modbus Flex Getter" Node
How can this be reproduced?
No.
What did you expect to happen?
I like to get more about it by logging. But I don't know how that can be achieved.
Can you provide information, how logging can be activated? Can you provide an example?
Thank you.
Other Information
No response

Go into the Node for the server and down the bottom under Show Errors is Logging, tick to enable. Then add a debug node after the server node and monitor the messages in debug.

Go into the Node for the server and down the bottom under Show Errors is Logging, tick to enable. Then add a debug node after the server node and monitor the messages in debug.

Thank you, but I do not understand.
What "server node" do you mean? Is it the "Modus Server" node, which is for testing?
I'm using the "Modbus Flex Getter" node, and checked "Show Errors" under the options tab, see screenshot.
But I do not get any logging data in the output, see 2nd screenshot.
Whats my mistake?

Your first post said
'Modbus-Server Node'
and this is the node I was referring to, flex getter node is not a modbus server node.

Your first post said
'Modbus-Server Node'
and this is the node I was referring to, flex getter node is not a modbus server node.

Yes, I'm sorry, that was wrong reported, and I did correct it. In my opinion the "modus server" is the photovoltaic system and I'm using the flex getter node as a client to get data. This works in general, but around 10 times a day I'm getting the mentioned warning which refers to Logging. And logging is what I try to get.

So have you added a debug node to the output of the flex getter mode so you can see what info it currently puts out.
Do you have any other kit connected to the PV Modbus Server.

Yes I have a debug node and I can see the data coming from PV, responseBuffer. Nothing more connected to PV.
Look at the screenshot and my general question is: Whats the reason and how can I "...get more about it by logging"?

Well I assume the message about logging is about logging on the server which is your PV inverter not the flex getter node. If the server was a node then you can turn on logging.
As its a comms issue even if you could get logging on the flex getter then how can it get the info when it has no link as the error is no link.
So you need to get access to the PV inverter logs and see if they have messages ref RS485 not being available.
For it to be only 10 messages a day it will be a minor issue.

Is it actually giving you any problems or is it you just want rid of the messages.
Is it RS485-RTU or RS484-TCP

If its RTU is the cable good stranded shielded twisted copper with 120ohm resistors both ends
If its TCP how good is the network connection, have you tested pings over a period including the messages appearing.

In the example above you are requesting 36 registers starting at address 0.
Do you have just this request or other requests with other address and quantity too ?
Maybe you can split this request into "smaler" one?

It is TCP RTU-buffered.
Will setup pings in parallel to check the network.
I'm getting the data from PV split into 4 parts due to number of registers, waiting 100ms in between.
Its a minor issue. It was interesting to me how to  "get more about it by logging", assuming that there is a way to get closer information for investigation of root cause.

Have you tried "Defalut" instead of "RTU-BUFFERED"?
How are your timeout settings?

I cured a regular every 15 minutes with gap of 20 sec comms by turning off the Gui on a Pi plus only running one node-red flow. The Pi was getting overloaded.
Make one change only then test.

3b, hard wired ethernet, the cpu was not getting overloaded but there were 3 node red flows with modbus (all using same server), yasdi2mqtt running and MQTT server. Either a data pipe was getting overloaded or data was clashing. Only one flow has the issue strangely.

It is TCP RTU-buffered. Will setup pings in parallel to check the network. I'm getting the data from PV split into 4 parts due to number of registers, waiting 100ms in between. Its a minor issue. It was interesting to me how to "get more about it by logging", assuming that there is a way to get closer information for investigation of root cause.

may there are requests much too fast in communication and it is not supported in power of the server to call every 100ms - try 250ms or higher, because Modbus in RTU is more stable with more time. If the RTU server is closing on overload on its side you get a lot overhead in Node-RED to get re-connected and the results are much more worst then to communicate less with more time. Why 100ms? In the most cases it is enough to read every 1 sec.

Hi, changed to 250ms. Will observe.

Is stable now. Very seldom timeouts on the network.


20-transfer: use a regex for denomination path parsing

Determine whether this is actually clearer / more ergonomic than our current logic.

Closing since we recently decided to not use regex for string parsing. We will keep using strings.Split instead.


AMBARI-24147 Make STOMP updates immutable.

What changes were proposed in this pull request?
STOMP update events made immutable, this prevents STOMP cache corrupting during simultaneous retrieving current values and update handling. Also cache locks were optimized for for host data holders.
How was this patch tested?
Manual testing.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2966/
Test PASSed.


Feature/bump min target sdk

Phase 1:

Removed obsolete sdk checks
bumped min to 28, target 33

@TrianguloY next phase: SAF support. Maybe this weekend

As of I don't have access to this repository, I cannot edit "reviewers" section

@TrianguloY What about the min SDK? I believe that the application should support Android 9.0 at minimum (released 5 years ago). This can keep code base with minimum amount of legacy code

This change is where I'm most concerned with, let me explain:
LL has always been a 'fast launcher' for low-end devices, even if latest versions had a lot of 'advanced' features.
According to Android Studio, sdk 28 (android 9) runs on 84.1% devices, which leaves a 15.9% of devices out.

The current LL community will probably be glad to still be able to use LL in older devices, if this doesn't mean to leave out features and updates.
Basically: I'm not opposing to increasing the sdk, but I would like to have a valid technical reason to do so, if possible. Was sdk 28 chosen because it fails on sdk 27 or just as a '80%' rule? Will the app still work if the target sdk is increased to 33, but the minsdk is kept at 14 (for the time being) or increased to 19?

@TrianguloY Let's start with the fact that the data is relevant on may 30, 2023.
I understand that the ability to maintain the most important number of devices is a natural desire.
But objectively, the number of old devices will only decrease. Yes, in general, you can add API 26+ support, increasing the number of devices by 5-7%.
But adding devices below - it makes no sense in the future.
since the application is written in Java, we do not have the opportunity to use the latest features of the language, as in Kotlin. For example, full support for java 8 was added only in API 26 (java streams)

I understand that.
I'm still not convinced about increasing the sdk just because. If you check my other apps you will see that I try to support very old devices, even if it means not being able to use some of the latest features (which I know are nice to have, but they don't provide any value to a final user). I also dislike Kotlin (even though I really love the language) because it makes apps very bloated, but that's more debatable.
Question: Since right now the app is just being cleaned up, is it possible to keep the min sdk as-is, and don't remove any check, and only when new development is made (and it justifies the newer sdk) increase it? In other words: can you make it so that:

commit/pr: increase target sdk and make required changes, but don't touch the min sdk.
commit/pr: Enhancement/code style with Android Studio code style
other non-feature changes
commit/pr: increase min sdk
other feature changes

If you don't agree, and you still think the min sdk should be increased, then...I'll still accept the pr. I value keeping LL alive more than supporting older devices, but I just want you to consider it.

Okay. minsdk downgraded to 26. Some checks reverted, but is quite minimal effort.
Oreo is the best compromise

Ok.
I'm still sad that old devices are now unsupported without apparent reason, but as you said Oreo is a good compromise.
Remember that I'm not opposed to increasing it further if the benefits are noticeable. I'll check now the next pr.
Thanks for all your effort! Merged.


[Question] How to change code highlighting syntax theme?

Hello, thank you for this amazing and wonderful tool!!
Please see the image below.

I have create a method and export it, I use jest test to tell my user how to use it.
I know that typedoc use highlight.js to highlight the syntax, and I know that highlight.js support several  code syntax highlighting theme like monokai or dracula, etc...
How can I change my generated doc to use different syntax highlighting theme?
Thank you very much!!

There isn't any functionality for this in the default theme yet, it seems like a reasonable request. PR welcome :)

I'm thinking about what's the best way to support this and I think allowing arbitrary CSS to be added is the easiest approach. The highlight js theme isn't very big so the cost of overriding the styles would be small.
The problem I'm struggling with is "how configurable should the theme be?". The theme is easy to fork (if you know how to point typedoc to it) so I don't want to add too many flags for theming.

Maybe no theme at all, let typedoc generate a JSON that represent the whole website.
So the people who wants totally different theme can do whatever they want in the front-end.

Maybe no theme at all, let typedoc generate a JSON that represent the whole website.

You should already be able to do this by outputting JSON, is there something missing that prevents this workflow?

@Gerrit0 OMG, that's a hidden feature! Thank you!

This is possible now with --highlightTheme, run typedoc --help to get a list of available Shiki themes.

For those wondering where the --highlightTheme option went, it was split into --lightHighlightTheme and --darkHighlightTheme in typedoc 0.22.


Verify behaviour in case of invalid message body

For example badly formatted chunks.

On the request? For bad request chunks you shouldn't even receive them, Http.Sys should fail.

Is there any scenario where we get to start reading the body and while the client is sending it realize it's invalid?

perhaps, but it would be reported as a read error or disconnect.

I want to verify that we get an exception that we expect.


Add a standard README

Here is a sample minimal standard readme which one can refer sample
OR you can refer this sample2

For what do you need the Readme? The code explanation?

Well, that would take too long.
I just want it in the below format:

Name of Program - Brief description (<3 lines).

e.g.

Contrast Stretching - Contrast stretching is a simple image enhancement technique that improves the contrast in an image by expanding the dynamic range of intensity values it contains.

let me dot it for you @pranav6670

@rjrahul10 go ahead 👍


Minor Update

-Add Soul Wars assets (actually removing the texture within the file because its cleanest option)
-Fix Minimap orbs that I forgot about fixing the outlines for (keeping black outline when hovered)
-Minor Override changes (Xp Tracker to match Overlay, Fix Diary line Opacity)

did not mean to delete the branch kekw, this is the intended update


Allow a V2 view to specify its parent, regardless of how it's nested

I've been thinking about an "impendance mismatch" between V1 and V2 that will make upgrading more difficult (whether manual or scripted). This is an attempt to patch over a common case. I'm not 100% sold on it myself - I'd like to keep the DSL as simple as possible. Feedback welcome.
Consider the following V1 Blueprint:
class WidgetBlueprint < Blueprinter::Base
  view :normal do
    field :name
  end

  view :extended do
    include_view :normal
    field :description
  end
end

There are currently two ways to represent this in V2: inheritance and partials.
# Inheritance has the drawback that the extended view's name will change to
# "normal.extended". This will require callsites to be updated with the new name.
class WidgetBlueprint < Blueprinter::V2::Base
  view :normal do
    field :name

    view :extended do
      field :description
    end
  end
end

# Using partials avoids that, but looks...not great. A converted codebase would be
# full of Blueprints defined like this:
class WidgetBlueprint < Blueprinter::V2::Base
  partial :normal do
    field :name
  end

  view :normal do
    use :normal
  end

  view :extended do
    use :normal
    field :description
  end
end

What this PR adds
This PR allows a view to specify which view it should inherit from, without affecting the name:
class WidgetBlueprint < Blueprinter::V2::Base
  view :normal do
    field :name
  end

  view :extended, inherit: :normal do
    field :description
  end
end

Maybe a better idea??
Note that the above doesn't address cases where V1 views inherit from multiple views. Those would still need to resort to partials. What if every view implicitly defined a partial for itself? 🤯 I think that would solve everything. Much simpler to implement, too.

Dropped in favor of https://github.com/procore-oss/blueprinter/pull/488.


Expose list of ongoing video compressions and improved logging

As requested in https://github.com/zauberzeug/field_friend/pull/155#issuecomment-2315503366, this PR adds logging to the video compression so we can see when it finishes. It also introduces the ongoing_computations property which holds a list of all target video filenames which are currently created.

@falkoschindler I could test it on F13 later today, but i'm fine with just merging it

Me too.lets merge


Examples for Yarn 1 (Classic) and Yarn Berry / Modern (Version 2 and later)

This is an enhancement request to add examples to clearly demonstrate using GHA for both Yarn 1 (Classic) and Yarn Berry / Modern (Version 2 and later).
Current situation
The following workflows and example directories target yarn:

.github/workflows/example-install-command.yml using

examples/install-command with the corresponding v9 version, both with a yarn.lock lockfile v1.

.github/workflows/example-start-and-yarn-workspaces.yml using

examples/start-and-yarn-workspaces including two workspaces, with a corresponding v9 version, both with a yarn.lock lockfile v1.

The examples demonstrate only Yarn 1 (Classic).
Suggestion
Create new workflows with yarn in their names so that they are easily identified:
- Yarn 1 (Classic) example-yarn-classic
- Yarn Modern example-yarn-modern
Naming
Note that both terms Yarn Berry and Yarn Modern are in use and equivalent.
The GitHub repository https://github.com/yarnpkg/berry is named with the term berry. It includes releases for Yarn version 2 onwards. The site https://yarnpkg.com/ includes the note "This documentation covers modern versions of Yarn.", introducing the term "modern". The page https://yarnpkg.com/getting-started/qa#why-should-you-upgrade-to-yarn-modern more specifically uses the terms Yarn Classic and Yarn Modern side-by-side when discussing migration.
I suggest to use the term Yarn Modern, when referring to Yarn version 2 and later, in preference to the term Yarn Berry. The term Yarn Modern is immediately recognizable as being a later version than Yarn Classic without the need for any reference materials.
Related documentation issue

https://github.com/cypress-io/github-action/issues/798

Assuming agreement, I plan to submit a PR to implement this enhancement request.

I've been reviewing my suggestion and I plan to split it into two parts:

Establish a Yarn Classic example clearly labeled
Add a Yarn Berry example

otherwise it will be unduly complex and difficult to review.

PR #828 submitted as the first installment to implement this suggestion

The second installment of this suggestion is now submitted through PR #838


x/website:  Error of "Developing a RESTful API with Go and Gin" chapter

What version of Go are you using (go version)?

$ go version
go version go1.16.6 windows/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GOHOSTARCH=amd64
set GOHOSTOS=windows

What did you do?

I wrote a RESTful API for adding albums according to the documentation(Tutorial: Developing a RESTful API with Go and Gin), but when i called it according to the curl command in the case, an error occurred.
$ curl http://localhost:8080/albums \
    --include \
    --header "Content-Type: application/json" \
    --request "POST" \
    --data '{"id": "4","title": "The Modern Sound of Betty Carter","artist": "Betty Carter","price": 49.99}'

Finall I found out that I need to escape the double quotes in the data send using curl, otherwise the problem will occur.
The following case can be send successfully.
curl http://localhost:8080/albums --include --header "Content-Type: application/json" --request "POST" --data '{\"id\": \"4\",\"title\": \"The Modern Sound of Betty Carter\",\"artist\": \"Betty Carter\",\"price\": 49.99}'

What did you expect to see?
curl http://localhost:8080/albums --include --header "Content-Type: application/json" --request "POST" --data '{\"id\": \"4\",\"title\": \"The Modern Sound of Betty Carter\",\"artist\": \"Betty Carter\",\"price\": 49.99}'

What did you see instead?
$ curl http://localhost:8080/albums \
    --include \
    --header "Content-Type: application/json" \
    --request "POST" \
    --data '{"id": "4","title": "The Modern Sound of Betty Carter","artist": "Betty Carter","price": 49.

which shell is this? In sh-like shells the outer single quotes mean the inside double quotes don't need to be escaped

the price must be string in JSON

CMD and Powershell don't accept the arguments used in BASH(--include, --header, etc). They are named differently. Try the following to post data to the album instead:
curl http://localhost:8080/albums/ -Method POST -Body '{"id": "4","title": "The Modern Sound of Betty Carter","artist": "Betty Carter","price": 49.99}'


Adding LB or VM is stuck in "saving".

Rancher Version:v1.2.0-pre1-rc1
Add an LB service and click on create.
  Not sure if it's because it's missing the network agent or if it just has to have 1 service on it before.

LB -> Service -> Containers -> Mounts was missing a config key to not serialize mounts, which caused a circular loop serializing the balancer (or other kinds of things)

version - 1.2.0-pre1-rc3
Not fixed

Oops sent Darren wrong bug
Version - v1.2.0-rc3
Verified fixed


Per notebook run support via py package repo

The need of this issue is to have granular access to each notebook while having the repo being a package that can be run via pip. This is for advanced users in the space who want to change the code for different metrics and modifications so they can run each notebook one by one along with having the option to pip install the fmbt package.

this is done


Error in documentation

On the documentation site https://flextype.org/documentation/getting-started/configuration the path to the configuration file is specified incorrectly as project/config/settings.yaml

I'm sorry, it looks like my mistake


Domain templates or clone from domain

Why is there no templates or clone a domain record set on new domain creation

Because it's not been coded yet? This is already a feature-request -- see #54.
Patches welcome.

Feature is available in development branch. Waiting to merge to master.


Create sitemap.xml

Create sitemap.xml listing all snapshot articles. Consider using sitemap.xml as RSS feed and to create the table of contents on landing page.

Created XML file and javascript parsing script.


Rethink the top-level unrolled block and record APIs

llvm_mapper::unroll::UnrolledBlock currently has a bunch of APIs with signatures that look roughly like this:
pub fn one_record(&self, code: u64) -> Result<&UnrolledRecord, BlockMapError> { ... }
pub fn one_block(&self, id: BlockId) -> Result<&UnrolledBlock, BlockMapError> { ... }

These are convenient in each record/block mapping implementation, but they're also constraining: because they return BlockMapError as their error type, downstream types need to either accept that type (e.g. with thiserror's #[from]) or mangle it into something more local and context sensitive. This in turn makes it harder to make the mapping traits more flexible in terms of error handling.

#20.


Table: add basic table components

Adds the first round of components for the Table: Table, Table.Body, Table.Cell, Table.Header, Table.HeaderCell, and Table.Row.

[x] Documentation
[x] Tests
[ ] Experimental evidence (required for Masonry changes)
[x] Accessibility checkup - I added scope for the header cells and used the Chrome audits tab

Screenshots of the docs:


Add option to truncate menu entries

First of all thanks for this nice plugin.
One important option for me, which is currently missing, is the ability to truncate the menu entries. When programming in C and C++ the entries can get quite long. All other well known completion plugins provide a way to define a max length option for each entry section.
In coc.nvim:
"suggest.labelMaxLength": 55,
"suggest.detailMaxLength": 30,

In completion.nvim: (https://github.com/nvim-lua/completion-nvim/issues/245)
vim.g.completion_abbr_length = 55 -- completion item (left)
vim.g.completion_menu_length = 30 -- extra info for completion item (right)

Current situation with nvim-compe:

Current situation with completion-nvim:

Try setting up pumheight. It should limit completion menu's height.

The height is not the problem. The problem is the width of the entries.

Duplicate #55
Thank you for pointing out that other plugins features.

BTW, I don't want to add many options as much as possible.
Because IMO, it makes buggy software.
(If the option is really needed, I think it is ok to add)

Without truncation it is impossible to see useful information like the LSP kind and the detail field. When working with an editor width  of max. 120 character I would not be able to use your plugin. The reason for max. 120 character is that I use a tiling window manager with a browser on 1 half of the screen and Neovim on the other half.
nvim-compe in an editor with max. 120 character:

completion-nvim in an editor with max. 120 character:

In completion-nvim I can cleary see if the entry is of type Function or Class and would the return type of a given function is.


Release v0.7.2

Overview
This is a patch release.
Pull request checklist

[ ] I have read the contributing guide.
[ ] I have agreed to the Contributor License Agreement.
[ ] I have updated the documentation.
[ ] I have resolved any merge conflicts.
[ ] I have included tests that cover my changes.
[ ] All new and existing tests pass.

Code review checklist
This is the checklist that the reviewer will follow while reviewing your pull request. You do not need to do anything with this checklist, but be aware of what the reviewer will be looking for.

[ ] Ensure that any changes to external docs have been included in this pull request.
[ ] If the changes require that minor/major versions need to be updated, tag the PR appropriately.
[ ] Ensure the new code is properly commented and follows Idiomatic Go.
[ ] Check that tests have been written and that they cover the new functionality.
[ ] Run tests and ensure they pass.
[ ] Build and run the code, performing any applicable integration testing.

Regarding the build failures:
The failure on Go 1.8 is not unique to this release. The previous release, v0.7.1, also exhibits this failure. I triggered a manual build to demonstrate this. The previous build on v0.7.1 passed. Either this issue is caused by a Go 1.8 point release, or there is something strange going on in the build environment. We are not considering this failure to be a blocker for the release, and this failure is not occurring on Pilosa master.
 Also not a blocker for release.


Typo?

"Starting from 2022 release wave 2, the Dynamics 365 Business Central server is running on .NET Standard and if you are using on-premises .NET add-ins that targets .NET Framework, you need to convert them to use .NET Standard, because add-ins compiled with .NET Framework will stop working in Business Central 2022 release wave 1."
Is it wave 1 or 2?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1bd94618-808b-ebda-96d8-bcf0d41ccfda
Version Independent ID: 1bd94618-808b-ebda-96d8-bcf0d41ccfda
Content: Migrating from .NET Framework to .NET Standard - Business Central
Content Source: dev-itpro/developer/devenv-migrate-from-dotnet-framework-to-dotnet-standard.md
Service: dynamics365-business-central
GitHub Login: @KennieNP
Microsoft Alias: kepontop

Hello, this is a typo, and thanks for catching this. In both cases it should be Business Central 2022 release wave 2. This is fixed with the most recent doc refresh. Thanks


WIP: Make template schema update synchronous

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@139272e). Click here to learn what that means.
The diff coverage is 87.5%.

@@            Coverage Diff            @@
##             master    #5992   +/-   ##
=========================================
  Coverage          ?   83.13%
  Complexity        ?    12404
=========================================
  Files             ?     1433
  Lines             ?    46919
  Branches          ?     5766
=========================================
  Hits              ?    39004
  Misses            ?     5232
  Partials          ?     2683

Impacted Files
Coverage Δ
Complexity Δ

...n/java/io/crate/metadata/doc/DocIndexMetaData.java
93.58% <ø> (ø)
125 <0> (?)

...rate/metadata/doc/InternalDocTableInfoFactory.java
100% <100%> (ø)
2 <1> (?)

...executor/transport/TransportShardUpsertAction.java
86.07% <100%> (ø)
73 <0> (?)

...crate/executor/transport/SchemaUpdateResponse.java
100% <100%> (ø)
2 <2> (?)

.../crate/executor/transport/SchemaUpdateRequest.java
100% <100%> (ø)
7 <7> (?)

sql/src/main/java/io/crate/plugin/SQLModule.java
100% <100%> (ø)
2 <0> (?)

...a/io/crate/executor/transport/ActionListeners.java
55.55% <55.55%> (ø)
3 <3> (?)

...o/crate/executor/transport/SchemaUpdateClient.java
69.23% <69.23%> (ø)
2 <2> (?)

...ava/io/crate/metadata/doc/DocTableInfoBuilder.java
81.63% <75%> (ø)
13 <0> (?)

...xecutor/transport/TransportSchemaUpdateAction.java
92.45% <92.45%> (ø)
11 <11> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 139272e...5a44990. Read the comment docs.


fix vpc peering connection terraform import

About this change—what it does
VPC peering connection id parser doesn't validate user input and panics.
Why this way
New parser:

validates user input has valid size
won't panic because of validation

could you please run the acceptance tests?

could you please run the acceptance tests?

There is only one test for AWS and it requires AWS credentials.


How to make the robotium source file into jar?

From<EMAIL_ADDRESS>on May 04, 2012 00:50:27
What steps will reproduce the problem? 1.I download the robotium source file from the github, and made some changes. Then use jar command to make it into jar file.
But when I run it in an android test project, it just comes across "can't find calss jayway.Robotium.solo.Solo."
I'm not sure whether the process of packaging the robotium source file into jar is right, is there any clue or instruction for making the robotium source file into jar??
Appreciation for any help~~~
Original issue: http://code.google.com/p/robotium/issues/detail?id=257

From<EMAIL_ADDRESS>on May 04, 2012 01:17:54
Use maven to create the jar.
Status: Invalid


150 perform filtering based on basemean only in the controls

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 87.87879% with 8 lines in your changes missing coverage. Please review.

Project coverage is 57.42%. Comparing base (f3e0bad) to head (0e778f0).
Report is 1 commits behind head on development.

Files with missing lines
Patch %
Lines

src/differential_expression.rs
0.00%
8 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #151      +/-   ##
===============================================
+ Coverage        56.63%   57.42%   +0.79%
===============================================
  Files               28       28
  Lines             2707     2760      +53
===============================================
+ Hits              1533     1585      +52
- Misses            1174     1175       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


UglifyJS setting is breaking external packages relying on currying

Do you want to request a feature or report a bug?
Bug - depending on how you want to look at it
What is the current behaviour?
Similar to https://github.com/developit/preact-cli/issues/136 the keep_fargs setting breaks any external packages that make use of Function.length, ie. anything that uses currying like lodash's curry method.
If the current behaviour is a bug, please provide the steps to reproduce.

Start a new project with this CLI and add lodash's curry method. Run production build and the code will be stripped out.
What is the expected behaviour?
The code should not be stripped out
If this is a feature request, what is motivation or use case for changing the behaviour?
Please mention other relevant information.

Node version: n/a
npm version: n/a
Operating system: n/a
CLI version: v2.2.1
Browser: n/a

I could get around it for now by specifying a custom config file and popping this in there:
export default (config, env, helpers) => {
	const { plugin } = helpers.getPluginsByName(config, 'UglifyJsPlugin')[0] || {};
	if (plugin && plugin.options) {
		plugin.options.compress.keep_fargs = true;
	}
};

Not sure how much savings this setting is enabling, but can't think it is much. Consider keeping it as the default true instead of false.

Indeed, I doubt this setting is really having that huge of an effect. Should be fine to switch to the default value.


About README

My English is poor, can you provide Chinese documents? thanks.

Sure, I got it.
中文文档


🔥 !important

Sorry... slipped through as part of my last PR 🤠 #77

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add support for namespace label selectors in K8s policies

This PR makes a few changes in the policy plugin, adding support for namespace label selectors, both for Ingress and Egress Rules. Also fixes bugs related to empty podSelectors and empty namespaceLabelSelectors. Fixes should be also part of #560 and #565

Coverage decreased (-0.04%) to 76.785% when pulling b5542d520597565757cafc96c0fd96e257c9ef5d on brecode:master into 197704155c2a7196e12066c07439c7cb1a74f743 on contiv:master.

https://github.com/brecode/vpp/commit/8ad1e7ed7958be6a35524c28c460d87d920afeb3
Fix formatting errors on plugins/policy/processor/matches_calculator.go & plugins/policy/processor/processor.go fixes "make check_format" from travis by removing unnecessary whitespaces. Solution is to run gofmt on the files producing the error.


Staking: fork frame V3 staking pallet and implement threefold staking

We need to fork frame V3 staking pallet and implement our own staking rules. Currently the staking pallet relies on a inflation curve, we can modify the payout code to reward validators with funds from a central account (staking pool account)

WIP: https://github.com/threefoldtech/tfchain_pallets/pull/52


dibs: I will implement exercise triangle

Sweet, thanks for the pull request. I checked out some other language tracks and most of them seem to return a TriangleKind/TriangeType enum (java, csharp, scala). I think we should go with that pattern for conformity sake, here is a sample implementation:
diff --git a/exercises/triangle/src/example/kotlin/Triangle.kt b/exercises/triangle/src/example/kotlin/Triangle.kt
index af394b0..e69889e 100644
--- a/exercises/triangle/src/example/kotlin/Triangle.kt
+++ b/exercises/triangle/src/example/kotlin/Triangle.kt
@@ -5,9 +5,16 @@ class Triangle<out T: Number>(val a: T, val b: T, val c: T) {
         require(a + b >= c && b + c >= a && c + a >= b, { "Sides must satisfy triangle inequality"})
     }

-    val isEquilateral = a == b && b == c
-    val isIsosceles = a == b || b == c || c == a
-    val isScalene = !isIsosceles
+    private fun isEquilateral() = a == b && b == c
+    private fun isIsosceles() = a == b || b == c || c == a
+
+    fun getType(): TriangleType {
+        return when {
+            isEquilateral() -> TriangleType.EQUILATERAL
+            isIsosceles() -> TriangleType.ISOSCELES
+            else -> TriangleType.SCALENE
+        }
+    }

     private infix operator fun <T: Number> T.compareTo(other: T): Int = this.toDouble().compareTo(other.toDouble())
     private infix operator fun <T: Number> T.plus(b: T): Double = this.toDouble().plus(b.toDouble())
diff --git a/exercises/triangle/src/example/kotlin/TriangleType.kt b/exercises/triangle/src/example/kotlin/TriangleType.kt
new file mode 120000
index 0000000..581da9e
--- /dev/null
+++ b/exercises/triangle/src/example/kotlin/TriangleType.kt
@@ -0,0 +1 @@
+../../main/kotlin/TriangleType.kt
\ No newline at end of file
diff --git a/exercises/triangle/src/main/kotlin/TriangleType.kt b/exercises/triangle/src/main/kotlin/TriangleType.kt
new file mode 100644
index 0000000..e2b5987
--- /dev/null
+++ b/exercises/triangle/src/main/kotlin/TriangleType.kt
@@ -0,0 +1,4 @@
+
+enum class TriangleType {
+    EQUILATERAL, ISOSCELES, SCALENE
+}

The tests would have to obviously change.

Thanks for the review. I went with that sort of implementation originally - it's very natural for an old Java-head like me. But then I saw this issue being pointed at in the test data: https://github.com/exercism/x-common/issues/379 and realised it really did make sense to go with the property-based approach. Please have a look at let me know.

Hey @nithia, sorry for the delay!  This track was a little understaffed for a while.
In light of that discussion, I wholeheartedly agree!  I'll give this PR a formal review...

Hey @jtigger, I've made the changes as requested and also upgraded to kotlin 1.0.6 in line with the rest of the exercises. Agree this track could use a few more people on it. I'm completely happy to contribute as time and $dayjob permit :) Kotlin is a lot of fun & I'm looking forward to the 1.1 release.

Yikes @nithia!  Sorry for the super long delay!
Thanks for making those edits.  This looks really good.  Appreciate your help!


[firebase_messaging] Disable interception of notification to allow for local notification generation

Discussed in https://github.com/FirebaseExtended/flutterfire/discussions/6113

Originally posted by Minituff May 11, 2021
Background
I am trying to create a chat app which delivers reliable notifications that includes action buttons such as Mark as Read and Reply which creates an input field.
Unfortunately the firebase_messaging plugin does not support advanced options like Action/Input buttons. So, to do this in Flutter, I am using a great package called AwesomeNotifications which allows for all these advanced features. For anyone unfamiliar, it is like a more advanced version of the Local Notifications plugin.
Using this plugin, I am able to handle the FirebaseMessaging.onBackgroundMessage(_fcmBackgroundHandler); callback from firebase_messaging and generate the notification with all the properties and actions that I like.
The Problem
If the notification includes the notification property then firebase_messaging will automatically display the notification and  AwesomeNotifications will then display its notification--resulting in duplicate notifications.
However, removing the notification property turns it into a data-only notification which, according to the FlutterFire docs are low-priority`

As mentioned above, data only messages are classed as "low priority". Devices can throttle and ignore these messages if your application is in the background, terminated, or a variety of other conditions such as low battery or currently high CPU usage.
You should not rely on data only messages to be delivered, they should only be used to support your applications non-critical functionality, e.g. pre-fetching data so the next time the user opens your app the data is ready to be displayed and if the message never gets delivered then your app still functions and fetches data on open.
To help improve delivery, you can bump the priority of messages. Note; this does still not guarantee delivery.

I have also tested this with my own IOS and Android devices and I would not receive data-only messages unless the app was in the foreground or the last used app on IOS. Notifications would not come through if I was using another app, or it was swiped away from recents.
For a chat application, getting reliable messages is a priority and therefore I need to use the notification property to ensure delivery of my notifications. The issues:

I cannot use a plugin like AwesomeNotifications or Local Notifications to create advanced functioning notifications because it will create duplicate notifications as long as the notification property is set. However, the notification property is required for reliable notifications.
The firebase_messaging plugin does not support advanced features such as Action/Input buttons.

A greater explanation of (number 1):
firebase_messaging automatically intercepts notifications and displays them and I don't think there is a way to disable that. Per the docs below:

Messages can be handled via the onBackgroundMessage handler. When received, an isolate is spawned (Android only, iOS/macOS does not require a separate isolate) allowing you to handle messages even when your application is not running.
and further
If your message is a notification one (includes a notification property), the Firebase SDKs will intercept this and display a visible notification to your users (assuming you have requested permission & the user has notifications enabled). Once displayed, the background handler will be executed (if provided).

The Feature Request
I would like to be able to disable the firebase_messaging automatic notification display while still having the onBackgroundMessage callback fire. This way I can send reliable notifications (with the notification property) and have them be displayed by the more advanced flutter tools.
If this is not possible, then I would love to see ActionButtons and Input fields come to the firebase_messaging plugin.
Additional Infromation
I created another issue here https://github.com/rafaelsetragni/awesome_notifications/issues/165

Have you already found any solution? @Minituff

Have you already found any solution? @Minituff

@coccyx-cyst No I haven't yet. The latest update I've found on a solution is here:
https://github.com/rafaelsetragni/awesome_notifications/issues/165#issuecomment-1013559494
It looks like @rafaelsetragni is getting close to a solution in the release-0-7-0 branch.

Same issue

Facing the same issue. I want to add some customisations to notifications but turns out we can not customise background notifications. And if we try to launch our own custom notification then there are duplicates as there is no way to disable default background notifications.
My ask is, please provide a flag to disable triggering of automatic background notifications and let user create his own.

Hi @Minituff, there is no way of changing the system behaviour, it will always display a notification is it is present on the payload. You can increase the "low priority" aspect to data only payloads by doing the following:
On Android, set the priority field to high.
On Apple (iOS & macOS), set the content-available field to true.

" If this is not possible, then I would love to see ActionButtons and Input fields come to the firebase_messaging plugin."
That would be optimal!

@russellwheatley there should be a way. We should include mutable-content in payload and fcm should code this workaround https://developer.apple.com/documentation/usernotifications/modifying_content_in_newly_delivered_notifications
Was thinking this might be related to our #9300. It seems silent notifications wont be triggered if

To recap issue is:
Silent notifications lets developers manipulate the content before showing head ups. Unfortunately they are not reliable on iOS which deliver then with low priority
apns-priority:5
contentAvailable: true
The result is that they dont work well when app is terminated and they might not be triggered under many conditions even in foreground/background mode.
Remote notifications are always delivered with highest priority and triggered in all app states: foreground / background / terminated.
However, as of now, firebase_messaging displays them instantly and prevents developers from editing its content. This feature is key for chat apps which need to decrypt notifications’ payload before displaying it.
Solution is to support content-mutable:1 inside payload and let developers edit payload fields even for “notification”, not just “data”.
https://developer.apple.com/documentation/usernotifications/modifying_content_in_newly_delivered_notifications


Error in response of POST API with AlmofireXMLToObjects

I am doing a POST request but it is giving the below error at runtime:
Error Domain=com.alamofirejsontoobjects.error Code=1 "Data could not be serialized. Could not get a dictionary from the XML." UserInfo={NSLocalizedFailureReason=Data could not be serialized. Could not get a dictionary from the XML.}
I tried the request on POSTMAN but it is working fine and giving expected XML response.
Regards
Dev

I suggest you look at what you're actually getting and check the differences between your Postman request and the one you're making from code.
In the future, you should open questions like this on Stack Overflow and tag alamofire.
Cheers. 🍻

From our Contribution Guidelines
Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.


Error running pipeline with Nextflow 0.32.0

Yesterday we ran the pipeline with the brand new version of Nextflow. In the attachment the error. We opened another issue when running the same pipeline: #93.
command_error_log.txt
nextflow.log.1.txt

ERROR ~ Error executing process > 'star (UHR_Rep2_ERCC-Mix1_1)'

Caused by:
  Not a valid memory value: null

Source block:
  prefix = reads[0].toString() - ~/(_R1)?(_trimmed)?(_val_1)?(\.fq)?(\.fastq)?(\.gz)?$/
  def avail_mem = task.memory == null ? '' : "--limitBAMsortRAM ${task.memory.toBytes() - 100000000}"
  seqCenter = params.seqCenter ? "--outSAMattrRGline ID:$prefix 'CN:$params.seqCenter'" : ''
  """
  STAR --genomeDir $index \\
      --sjdbGTFfile $gtf \\
      --readFilesIn $reads  \\
      --runThreadN ${task.cpus} \\
      --twopassMode Basic \\
      --outWigType bedGraph \\
      --outSAMtype BAM SortedByCoordinate $avail_mem \\
      --readFilesCommand zcat \\
      --runDirPerm All_RWX \\
      --outFileNamePrefix $prefix $seqCenter \\
  """

@pditommaso, I guess this is being caused by the statement task.memory == null. Is this something that's changed in the last release? Should this code be replaced with something different?

This seems an issue on NF side, a possible and nicer workaround should be 👍
task.memory ? "--limitBAMsortRAM ${task.memory.toBytes() - 100000000 : ''

Updated and in PR #96 - tests now running. Thanks both!

Do you think that this will now be a problem? https://github.com/nf-core/rnaseq/blob/acd11620641af65a89f96afecf67409e3db66552/conf/hebbe.config#L18

Hi @edxxgardo,
I've just merged what I hope is a fix into the dev branch. If you could try running again and see if you still get the same problem, that would be great!
Thanks,
Phil

Ok, no more memory error. But, the problem with the never ending process mentioned in #93 is still there.

Great stuff, thanks! 🎉


Upgrade to Angular RC5

Angular 2, RC5 landed yesterday. It would be nice to update the seed to keep pace.
see: https://angular.io/docs/ts/latest/cookbook/rc4-to-rc5.html
I went through the npm upgrade locally but encountered the following...
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(2,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'afterEach'.
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(4,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'beforeEach'.
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(5,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'beforeEachProviders'.
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(6,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'ddescribe'.
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(7,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'describe'.
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(8,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'fdescribe'.
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(9,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'xdescribe'.
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(12,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'iit'.
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(13,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'it'.
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(14,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'fit'.
dist\tmp\app\frameworks\test\shorthand\ng2-jasmine.ts(15,3): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/testing"' has no exported member 'xit'.
dist\tmp\testing\router\mock-location-strategy.ts(7,24): error TS2305: Module '"Z:/src/automata/node_modules/@angular/core/src/facade/async"' has no exported member 'ObservableWrapper'.

Hi @dopry we usually wait til the parent seed updates so keep an eye here for when that lands:
https://github.com/mgechev/angular2-seed
We do this to keep as tight parity as possible with the parent in terms of build features, etc.
Once rc5 lands there, you can expect to see it here within a day or 2 after (excluding the next 5 days because I'm getting married ;) )... Wednesday next week I'll be back at it. 👍

@NathanWalker Congratulations
I'll took a stab at a branch for this, but it's not building yet.

ng2-jasmine.ts
The jasmine methods from angular/core/testing were deprecated in favor of the globals. (beforeEach, beforeEachProvider, ddescribe, and iit no longer seem to be in the angular/core/testing namespace I'm having trouble importing directly from angular/core/testing/testing_internals, getting  a module not found.

mock-location-strategy.ts
ObservableWrapper has bee removed, as best I can tell it was just a wrapper for EventEmitter, so I was going to call the methods on _subject directly rather than running it through the ObservableWrapper proxy.

I'll re-prioritize and work on one for upstream... With luck you'll just need to do some merges and code review after your honeymoon.
Cheers.

@NathanWalker congrats on your wedding, have fun!

@dopry
https://github.com/angular/angular/blob/master/CHANGELOG.md states "testing: introduce new testing api to support ng modules (d0a95e3), closes #10354"
https://github.com/angular/angular/commit/d0a95e3

@NathanWalker Congrats on your wedding!
In other news, if there's someone able to attempt to update the Advanced seed, the parent seed has integrated RC5 successfully: https://github.com/mgechev/angular2-seed/commit/df5ab29739790502bf054a11cb4337924430a600

@mko @dopry @lfarran Thanks! I started on the upstream merge today and it's coming along however still more to do. However, I won't be able to merge it to master until NativeScript supports rc5.
In meantime, the upgrade/parent upstream merge wip is taking place here:
https://github.com/NathanWalker/angular2-seed-advanced/tree/rc5-upgrade
Once {N} rc5 support is available, I will finish the branch and merge to master.

Following...I just downloaded the advanced seed and upon running npm install I get
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.

I am also facing same issue here. Please somebody give some solution. I am stuck.,....
"Requires a Peer"

@ngrx/store has been update to depend on ng2-rc5, and the dependency isn't
well pinned in the package.json
You can update the  version for @ngrx/store in package.json to "2.0.0"
instead of "^2.0.0" and it should work.
ᐧ
On Tue, Aug 16, 2016 at 11:15 PM, Dan Bunker<EMAIL_ADDRESS>wrote:

Following...I just downloaded the advanced seed and upon running npm
install I get
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NathanWalker/angular2-seed-advanced/issues/197#issuecomment-240302713,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAXqOBRXgRjBqvILqpRm_85ZvcirYmWYks5qgnzLgaJpZM4Jhfzd
.

--
Darrel O'Pry
The Spry Group, LLC.
http://www.spry-group.com
718-355-9767 x101

dopry thanks a lot.
This has solve the ngrx/store problem but now same problem it is giving for
UNMET PEER DEPENDENCY<EMAIL_ADDRESS>

ok I updated the packge.jsone to "reflect-metadata": "0.1.2" and it worked.

I am getting now this error now when I do "npm run start.android"
Unable to install dependencies. Make sure your package.json is valid and all dependencies are correct. Error is: The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!

For those who are interested, there's an ongoing PR for nativescript-angular upgrading to RC5: https://github.com/NativeScript/nativescript-angular/pull/405

The rc.5 update is now complete for web, desktop and NativeScript 👍
If you are merging in latest master to update an existing project or working off a fork/clone, you will want to run this command after merging in latest:
npm run clean

Then you should be able to run/build all the platforms.


Release tags?

There's a lot of useful code here, thanks!
Might seem burdensome, but it would be great to see some release tags issued. If you do so, please peg those to the corresponding TensorRT releases.

We should definitely add release tags.
I think when I finalize the massive changes on the memory-refactor branch, then it would be a good time to do tagged releases.


[CI] Run sample job YAML tests in buildkite

Why are these changes needed?
Sets up the Buildkite CI pipeline to test the RayJob sample YAML files using kind.

Related issue number

Closes #1246
Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

Not working yet so I'll mark as draft

The Buildkite sample rayjob YAML test passed and the test logs are as expected: https://buildkite.com/ray-project/ray-ecosystem-ci-kuberay-ci/builds/1249#0189e5e3-9193-4717-8edd-c8c1bdc7ea3a/237-2560


[CL Incentives] Implement setIncentiveRecords and getIncentiveRecords

Closes: #4274
What is the purpose of the change
This PR implements a more portable version of state reads/writes relating to incentive records with the primary goal of making it simpler to abstract this logic into a separate module in the future. Specifically, it changes incentive records to work based off of pool Ids instead of as a field under pool objects.
Brief Changelog

Implement set/get functions for incentive records that do not depend on pool objects
Remove the PoolIncentives field from CL pools

Testing and Verifying

The new functions/logic are tested in incentives_test.go

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (no)
How is the feature or change documented? (not documented)

Reverting since the base branch is already quite large & difficult to review. Made new PR #4295 that we should hold off on merged until #4231 is reviewed and merged


Fix product name missing

Questions
Answers

Description?
Don't know if you have noticed guys but the name was missing for me, patching this line fixes it.

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes https://github.com/PrestaShop/PrestaShop/issues/22628

How to test?
Create a product, set the availability to 0. Register for notification with a user account. Set the availability back to 1 (or anything else). Wait for the email, the name will be empty.

Screenshot

PrestaShop <IP_ADDRESS>, The way to reproduce the issue is simple:
Create a product, set the availability to 0. Register for notification with a user account. Set the availability back to 1 (or anything else). Wait for the email, the name will be empty.
Moreover the product object is assigned in the line before, why not using it anyway as I've done?

Unfortunately, I'm not able to reproduce. Could you please create an issue on the main repository, a team will try to understand what happened to you and make sure it's reproducible

Hello @PierreRambaud
I managed to reproduce it with ps_emailalerts v2.2.1, see the attached screenshot below:

Thanks!

Hello @PierreRambaud
I managed to reproduce it with ps_emailalerts v2.2.1, see the attached screenshot below:

Thanks!

You're talking about the Firstname & Lastname, not the product name in your screenshot :thinking:

Mmh that's right, wonder if this screenshot is after applying the patch (but I don't think so). The client name is not the problem here, nor it doesn't matter to me.
To give you more informations mine is a new installation from presta <IP_ADDRESS> with some costum modules and no modifications to core files, so theoretically this should be the same as a test installation. Php version 7.2.33

@PierreRambaud yes I'm talking about the customer name not the product cause it's the only issue I encountred.
@Massi-X I think we need to change the issue title :wink:

@PierreRambaud yes I'm talking about the customer name not the product cause it's the only issue I encountred.
@Massi-X I think we need to change the issue title

I don't think we have to change the issue title, he spots a different problem than the one about the firstname and lastname, there is already an issue about this one

Yeah that's right I'll try to explain better in the bug tracker here

Issue was not confirmed ⚠ what do we do with the PR?

It's wrong, this change doesn't respect product combination.

Mmmh ok good point I didn't check that. So maybe the problem occurs while retrieving the name of the product with id_attribute? Needs further testing

@Massi-X I remember one issue like this and it was related to corrupt structure of table related to product attributes, do you have any non-native module for products import?

I can see that our QA team wasn't able to reproduce this issue, so am I, I'm closing this PR as it must be related to your installation of PrestaShop, not directly to ps_emailalerts module.

Nope no module for product import but I will check that table to see if there is something wrong


Support for answerExpression extension

Is your feature request related to a problem? Please describe.
Issue: #979
When building a data collection questionnaire, there is often a need to filter the options in a drop down list based on the selected answer to an earlier list. For example: Country > State > City - see #979
Describe the solution you'd like
Enable dynamic filtering of answerOptions using answerExpression with FHIRPath - see here
In the scenario in issue #979, where there are Country > State > City, each of which the answerOptions comes from a valueSet, the following should happen:

If country is USA
Populate the State lists with ValueSet of states from USA
When changing the value of the State, the City list is updated

Describe alternatives you've considered
Using nested set of enableWhen components
Other information
For Ux example of dynamically updating lists see issue #979

Update on this ticket
We are unable to find any example questionnaires as this expression is still in draft from FHIR side.
http://build.fhir.org/ig/HL7/sdc/StructureDefinition-sdc-questionnaire-answerExpression.html ,
http://hl7.org/fhir/R4/versions.html#std-process

@fredhersch @jingtang10 is there sample questionnaire that can be used in order to unblock this issue?

@fredhersch i think the example with country/state/city in the original description of this issue doesn't quite match the exampel given in here http://build.fhir.org/ig/HL7/sdc/expressions.html#answerExpression for answerExpression.
From what we can see (discussed with @f-odhiambo @RaaziaTarique @maimoonak) the way this works is very similar to candidateExpression (see #1038), but answerExpression has very low maturity level. So we should definitely seek some clarity on fhir chat. 1) what's the diff between answerExp and canddiateExp and 2) with the maturity level being 0 is it worth implementing this.

@jingtang10 I posted the query to zulip chat and got this reply https://chat.fhir.org/#narrow/stream/179255-questionnaire/topic/expression.20library/near/282944010

CC: @f-odhiambo @maimoonak

Thanks @RaaziaTarique @jingtang10 I've actually posted a follow up question on the FHIR chat to get some input. I see the point on the maturity level - thanks for flagging that - let's see what comes back.
I suppose we could use candidateExpression for the first set of options and constrain them to only select from the set provided (is this possible?).
What I don't understand is how you would then populate the next set of drop-down's based on the answer to the first drop-down. That is really what we are trying to achieve here.
Thoughts?

@RaaziaTarique @jingtang10 @pld - I posted this on FHIR Chat and get the following response from Lloyd Mackenzie.

@Tarun-Bhardwaj Should this be closed? I think answerExpression was covered in a different issue.
cc: @jingtang10

As per chat with @maimoonak , closing the issue as it is resolved.


Migrating hubot to a bot account breaks it partially

With the new bot account from Mattermost, I converted my existing hubot user to a fully fledged bot account. Doing so partially broke it.
Writing directly to the bot in a private message works perfectly but the issue is when posting in other channels. The bot has the 'System Admin' permission but is no longer monitoring the other channel and since it's a bot account it cannot be added as member since by default he's already a member of all the channels as sys admin.
A direct message to the bot to trigger a message in another room result in a 'permission denied'
Here's an exemple:
In a direct message:
hubot announce 'maintenance starting now' in tests channel

Result in the following line in the log:
{"level":"error","ts":1578947833.2254527,"caller":"mlog/log.go:174","msg":"You do not have the appropriate permissions","path":"/api/v4/posts","request_id":"ksc5t5wbjbr4tjnb15mqaj9h7e","ip_addr":"<IP_ADDRESS>","user_id":"dq3ryuzuk3dmijt6o7dhzuccne","method":"POST","err_where":"Permissions","http_code":403,"err_details":"userId=dq3ryuzuk3dmijt6o7dhzuccne, permission=create_post"}

you can check permissions for the account

Both permissions are enabled already

In our context, after similar migration (user -> bot account) we noticed a strange behavior.
One of our action is based on two reply. The first one appears, but not the second one (only logged in console).


Upgrade protobuf/grpc, use newer macos builder, fixes bugs in local launcher where vineyardd may fail, use latest black as formatter

Fixes #2657
Fixes #2634

Codecov Report

Merging #2650 (efc7bfa) into main (2657bec) will decrease coverage by 37.77%.
The diff coverage is 50.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2650       +/-   ##
===========================================
- Coverage   73.66%   35.89%   -37.77%
===========================================
  Files          99       99
  Lines       10279    10287        +8
===========================================
- Hits         7572     3693     -3879
- Misses       2707     6594     +3887

Impacted Files
Coverage Δ

python/graphscope/framework/utils.py
45.83% <50.00%> (-21.67%)
:arrow_down:

... and 61 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2657bec...efc7bfa. Read the comment docs.


twitter: Keep the "Consumer Secret" a secret.

how do I hide the Consumer Secret?
I dont want to hard-code Consumer Secret in my source code.

You can put it in the Info.plist and have it compiled into your app.


NetworkTarget not working in Azure VM when poining to loopback.

I have a log collector application (Nxlog) listening at port 514. My application sets the following target to NLog:
var target = new NetworkTarget
{
	Address = "tcp4://<IP_ADDRESS>:7777",
	Layout = new JsonLayout(),
	NewLine = true,
	MaxQueueSize = 0,
};
config.AddTarget("nxlog", target);
config.LoggingRules.Add(new LoggingRule("*", LogLevel.Debug, target));

I see not log lines being reported by log collector. Typing {} on telnet <IP_ADDRESS> 7777 produces lines just as expected. I injected the following snippet in my application and it produces lines too:
var client1 = new TcpClient("localhost", 7777);
using (var writer = new StreamWriter(client1.GetStream()))
{
	writer.WriteLine("{\"Message\":\"localhost\"}");
	writer.Flush();
}

I tried tcp://localhost:7777, tcp://<IP_ADDRESS>:7777, tcp4://localhost:7777... all combinations I could think of.
Running the same settings on my workstation works just fine.
Why on earth NetworkTarget does not work on Azure!?

Link at stackoverflow: http://stackoverflow.com/questions/30651322/why-nlog-networktarget-cannot-connect-to-tcp-127-0-0-1-on-azure-vm

Did you checked the internal log file? (after enabling)

2015-06-05 00:16:00.8708 Error Error when sending System.IO.IOException: Error: ConnectionRefused

I saw something when googling this that Azure won't uses the same port on default?

Maybe helpful:http://stackoverflow.com/questions/24226490/do-azure-virtual-machines-support-tcp-sockets

And http://stackoverflow.com/questions/30001949/azure-website-how-to-establish-a-socket-connection-on-loopback-interface/30002470#30002470

Did you have any success on this one?

Closing this due to inactivity.