test cases coverge coverage.Icov is empty

I tried cloning and running test coverage but coverge.Icov is empty.
Steps to reproduce:

clone and npm install

npm run test:cov
All test cases succeed but coverage looks like this in the terminal

----------|----------|----------|----------|----------|----------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------|----------|----------|----------|----------|----------------|
All files |  Unknown |  Unknown |  Unknown |  Unknown |                |
----------|----------|----------|----------|----------|----------------|

and the coverage.Icov file is empty

I haven't touched coverage in over a year. We should probably get it working again.

if your run npm run test:cov returns unknown
but if you edit /src/utils/shallowEqual.js line 12 and add a semicolon at the end then rerun npm run test:cov shallowEqual.js shows in the coverage.
alsot if you edit src/utils/wrapActionCreators.js line 1 and add a semicolon at the end  and then rerun npm run test:cov wrapActionCreators.js shows in the coverage.
Not sure what it means actually but maybe it will help you discover something

If nobody is working on that issue could I have a try during next few days? This issue seems a good one to start with:)

Absolutely. It's a race to the PR! 😄

This days I've been working on the issue and for now I am stuck and perhaps need some help or advise.
For now I have managed to change config of the nyc (istanbul cli) as shown on the picture below:

and all the src folder files appear to be in the report but with some kind of strange coverage results

Current investigaton and nyc/babel/istanbul issues checking didn't point at the idea of what could have happened here.
Any ideas from anyone where to point the attention to?
Original changes can be found in the fork


feat(side-panel): added click theming

Добавлена темизация АО для компонента SidePanel

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 80.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
7980

Relevant Lines:
9012

💛  - Coveralls

Давай добавим скриншот-тест на темизацию


Consistent highlighting of module qualifications and types

Comments on each change in the change's commit message

Thanks @garborg

No problem. GitHub deleted your comment about matching @ in the dots pattern, but here's the justification:
The lookahead now containing @ should match Module.export and exports can start with a letter or @. Before, the . after a module was highlighted unless a macro followed.


support parallel writers

To improve write speed for some proxy that do not support pipeline mode, this pull request supports parallel writers in RDB restore mode.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Considering that parallel writers mode is not necessarily much faster than pipeline mode, so this change is not general enough. I would close it. Thanks~~~

This PR can be close.


Passing match to handleCreate results in false positive

First off, thanks for writing this library. I think it will drastically clean up my tests.
I'm using handleCreate to replace my existing sinon mock. After reading through the docs, I saw the match option. This seems like a really cool feature, but I keep getting false positives when trying to use it.
For example:
TestHelper.handleCreate('project', {match: {name: "Not Tony"}});

I then proceed to write my test code to create an author with the name of "Tony". I would expect that to fail based on the match condition.
Upon closer inspection I saw the code inside MockCreateRequest's calculate method is calling tmpRecord.serialize(matchArgs). Looking at the ember data source, I see this for serialize:
  /*
    Create a JSON representation of the record, using the serialization
    strategy of the store's adapter.

   `serialize` takes an optional hash as a parameter, currently
    supported options are:

   - `includeId`: `true` if the record's ID should be included in the
      JSON representation.

    @method serialize
    @param {Object} options
    @return {Object} an object whose values are primitive JSON values only
  */
  serialize: function(options) {
    return this.store.serialize(this, options);
  },

So, it doesn't seem like the match args are actually going to survive beyond the call to serialize. That would explain my false positive. Am I interpreting your README correctly?
Thanks again :)
ember-data beta 16.1
ember 1.11.3
ember-data-factory-guy 1.0.7
ember-cli 0.2.3

Boy, that is a puzzler @tonywok, because this functionality has been pretty well tested .. and I retested it again today .. kept trying to make this not fail, but it works as expected for me. But maybe you are doing something in model, test, setup that is different?  So .. try sending the model, the full test, the factory .. and I can then try and recreate this one.
The matchArgs do survive the serialize call, but it was good idea to look there.

@danielspaniel That could be. It's an old (funny using that word) ember app, so there's lots of work arounds.
I'll take a closer look and resubmit if needed. Thanks.


Add startpage?

I just installed this on both my piholes, but it is not yet working.  Is this because it is cached, and takes time to flush out the duckduckgo address?
Also, is it possible to add startpage to the list?
Thanks !

What version of Pi-hole are you using?
What is your upstream resolver?
Is there anything in your hosts file?
What does /etc/dnsmasq.d/restrict.conf (may not be exact filename but
you should be able to find it) look like?

I can definitely take a look at startpage for you :)
On Wed, May 27, 2020 at 10:26 AM jdsmf<EMAIL_ADDRESS>wrote:

I just installed this on both my piholes, but it is not yet working. Is
this because it is cached, and takes time to flush out the duckduckgo
address?
Also, is it possible to add startpage to the list?
Thanks !
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jaykepeters/PSS/issues/9, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJBRUURM3XRQZ4MLQBKCS3TRTUWK7ANCNFSM4NMHW3VQ
.

Hi Jayke,
Thanks for following up. Answers, in order:

v.5.0

The VPN DNS for PIA: <IP_ADDRESS> and <IP_ADDRESS>

I believe it is just the defaults:
<IP_ADDRESS>       localhost
::1             localhost ip6-localhost ip6-loopback
ff02::1         ip6-allnodes
ff02::2         ip6-allrouters

This looks the way it should.  It is a little long, but the first few lines are:

/tmp/safesearch.txt generated on 05/27/2020 10:17 by unifipi
Google SafeSearch Implementation
host-record=forcesafesearch.google.com,<IP_ADDRESS>
host-record=safe.duckduckgo.com,<IP_ADDRESS>
host-record=restrict.youtube.com,<IP_ADDRESS>
host-record=strict.bing.com,<IP_ADDRESS>
host-record=safesearch.pixabay.com,<IP_ADDRESS>
cname=google.com,www.google.com,forcesafesearch.google.com
cname=google.ad,www.google.ad,forcesafesearch.google.com
cname=google.ae,www.google.ae,forcesafesearch.google.com
...

Thanks for that information! I will try that out tonight and report back to
you with my findings. Something could have changed with recent Pi-hole
updates, so my script may need to be updated. What does a dig on localhost
do for google.com?
Jayke Peters
<EMAIL_ADDRESS>+1<PHONE_NUMBER>
On Wed, May 27, 2020 at 2:24 PM jdsmf<EMAIL_ADDRESS>wrote:

Hi Jayke,
Thanks for following up. Answers, in order:

v.5.0
2.
The VPN DNS for PIA: <IP_ADDRESS> and <IP_ADDRESS>
3.
I believe it is just the defaults:
<IP_ADDRESS> localhost
::1 localhost ip6-localhost ip6-loopback
ff02::1 ip6-allnodes
ff02::2 ip6-allrouters
4.
This looks the way it should. It is a little long, but the first few
lines are:
/tmp/safesearch.txt generated on 05/27/2020 10:17 by unifipi Google
SafeSearch Implementation
host-record=forcesafesearch.google.com,<IP_ADDRESS>
host-record=safe.duckduckgo.com,<IP_ADDRESS>
host-record=restrict.youtube.com,<IP_ADDRESS>
host-record=strict.bing.com,<IP_ADDRESS>
host-record=safesearch.pixabay.com,<IP_ADDRESS>
cname=google.com,www.google.com,forcesafesearch.google.com
cname=google.ad,www.google.ad,forcesafesearch.google.com
cname=google.ae,www.google.ae,forcesafesearch.google.com
...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jaykepeters/PSS/issues/9#issuecomment-634889095, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJBRUUWQUL4PMSBGLYGV7FTRTVSG3ANCNFSM4NMHW3VQ
.

By "localhost", I assume you mean on the pihole.   Are we still having issues, or were those resolved, and now we just want Startpage added? I've been working many hours a week, so I have put coding/projects to the side temporarily, but I did see your message there and did not forget! Always in the back of my mind ;)

Actually, I think that it works now.  It might have just taken time for the cache in my browsers to flush out with the old DNS.
I also looked into safe search with Startpage.  It might not be so simple, since it works by settings, and not by domain.

That’s good to hear! As for startpage that may not be so good, but I am
always looking for other search providers that offer DNS-enforced
safesearch.
On Fri, Jun 12, 2020 at 10:53 AM jdsmf<EMAIL_ADDRESS>wrote:

Actually, I think that it works now. It might have just taken time for the
cache in my browsers to flush out with the old DNS.
I also looked into safe search with Startpage. It might not be so simple,
since it works by settings, and not by domain.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jaykepeters/PSS/issues/9#issuecomment-643347173, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJBRUUWN6A3W7QDBTQ4AAQDRWJFOBANCNFSM4NMHW3VQ
.

--
Jayke Peters
<EMAIL_ADDRESS>+1<PHONE_NUMBER>


CadenceError.ToException() conversion method strips error message.

The converter CadenceError.ToException() method is deconstructing the CadenceError, but when constructing the resulting Exception, the error message in the most deeply nested "{ }" gets dropped.
Example:
Original Error Message: System.Exception{external activity failed}
One Conversion: {System.Exception}
Two Conversions: {}
This is causing 2 tests to fail in Master:

[x] Test_EndToEnd.ActivityExternalErrorById,
[x] Test_EndToEnd.ActivityExternalErrorByToken.

This is basically tracking the same issue as #662.  I'm going to close this and finish up there.


Add EXE Installers to IDMComputerSolutions,Inc.UEStudio version 24.0.35

Related to #157277

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Fix hipMemsetAsync() for NULL and zero inputs

hipMemsetAsync() gives hipSuccess and also Aborted(core dumped) when the first parameter is passed as NULL or 0. Ran all the tests in memory module under directed tests  in my local machine and found  no issues.

@luckynikki you need to re-base to latest code and put dest NULL check in ihipMemset().

@luckynikki I have fixed this as part of #404


[NVIDIA] OpenGL support

Hello, is there any way to "enable" OpenGL with NVIDIA in this repository (to run games, etc.)? For example when I try to run gzdoom, I get this:
OS: KISS Linux, Linux 5.18.9 on x86_64
M_LoadDefaults: Load system defaults.
W_Init: Init WADfiles.
 adding ./gzdoom.pk3, 668 lumps
 adding ./game_support.pk3, 2514 lumps
 adding ./DOOM.WAD, 2306 lumps
 adding ./game_widescreen_gfx.pk3, 214 lumps
S_Init: Setting up sound.
I_InitSound: Initializing OpenAL
  Opened device ALSA Default
[ALSOFT] (WW) pthread_setschedparam failed: Operation not permitted (1)
[ALSOFT] (WW) D-Bus not supported
  EFX enabled
ID out of range. Using default device.
I_Init: Setting up machine state.
CPU speed: 2904 MHz
CPU Vendor ID: GenuineIntel
  Name: Intel(R) Core(TM) i5-9400F CPU @ 2.90GHz
  Family 6, Model 158, Stepping 10
  Features: SSE2 SSE3 SSSE3 SSE4.1 SSE4.2 AVX AVX2 F16C FMA3 BMI1 BMI2 HyperThreading
V_Init: allocate screen.
ST_Init: Init startup screen.
Checking cmd-line parameters...
S_InitData: Load sound definitions.
G_ParseMapInfo: Load map definitions.
Texman.Init: Init texture manager.
ParseTeamInfo: Load team definitions.
LoadActors: Load actor definitions.
script parsing took 124.54 ms
R_Init: Init Doom refresh subsystem.
DecalLibrary: Load decals.
M_Init: Init menus.
P_Init: Init Playloop state.
ParseSBarInfo: Loading custom status bar definition.
D_CheckNetGame: Checking network game status.
player 1 of 1 (1 nodes)
Using video driver wayland
libEGL warning: MESA-LOADER: failed to open nouveau: /usr/lib/dri/nouveau_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open nouveau: /usr/lib/dri/nouveau_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open nouveau: /usr/lib/dri/nouveau_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open nouveau: /usr/lib/dri/nouveau_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open nouveau: /usr/lib/dri/nouveau_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open nouveau: /usr/lib/dri/nouveau_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open nouveau: /usr/lib/dri/nouveau_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open nouveau: /usr/lib/dri/nouveau_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open nouveau: /usr/lib/dri/nouveau_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open nouveau: /usr/lib/dri/nouveau_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

libEGL warning: MESA-LOADER: failed to open swrast: /usr/lib/dri/swrast_dri.so: cannot open shared object file: No such file or directory (search paths /usr/lib/dri, suffix _dri)

Could not create OpenGL window:
Could not initialize EGL

Also, when I run vkcube-wayland, I get this:
vkEnumerateInstanceExtensionProperties failed to find the VK_KHR_surface extension.

Do you have a compatible Vulkan installable client driver (ICD) installed?
Please look at the Getting Started guide for additional information.

was this solved?

No, I've not had the time to investigate it, but I guess it's because the nvidia package only has the bare minimum required to run firefox. So installing the other libs aswell would probably fix it

was this solved?

Unfortunately, no. I reopen this issue

after my repository gkiss-multilib was created, I will try yo tackle this.

https://user-images.githubusercontent.com/47404953/183542502-4d76804e-a132-497e-8c40-574085dc1cec.png
OpenGL game under steam is working, however i had failed to get vkcube, where do you get it?

Wow! I didn't think gaming was possible on KISS Linux
About vk-cube, I got it from my Arch Linux installation [0], but you can also build it from here.
[0] vkcube.tar.gz

normal nvidia in this repository does not provide important Vulkan files or libraries, so thats probably why it didn't work.
I have tested an OpenGL game above and a DXVK game under wine, do you have any games you want me to test @nvidiaLinuxUser ?

maybe someone will find a solution.

:)

@wael444 Thanks for your work! I'm currently on Arch Linux for some reasons, I'll post here when I'm on KISS.
:D

Fixed

@git-bruh Thank you so much! Can't wait to test it out :D

@nvidiaLinuxUser , if you are going to use Steam, please use the Flatpak.


Can't create or update powerpc jails on powerpc64

When attempting to update my powerpc(32-bit) jail on powerpc64 I see the following error:

sudo poudriere jail -u -j ppc32
[00:00:00] ====>> Cross-building ports for powerpc on powerpc.powerpc64 requires QEMU
[00:00:00] ====>> Error: You need to setup an emulator with binmiscctl(8) for powerpc

I need an official list on what archs can cross-execute other archs.

It looks like kern.supported_archs is exactly what I need.


Support for HAProxy socket sender?

I see you guys implemented native support for OpenResty NGINX socket types as well as luasocket:
https://github.com/cloudflare/raven-lua/blob/master/raven/senders/
We use Lua in HAProxy which has its own Socket class implementation (compatible with the Lua Socket class) due to the non-blocking nature of HAProxy:
https://www.arpalert.org/src/haproxy-lua-api/2.3/index.html#socket-class
Would you consider a PR that adds a sender for this type of socket as well? Otherwise we cannot use this library as it will block our Lua scripts' operations.

There is an HTTP library that is built to leverage HAProxy's non-blocking runtime we could use: https://github.com/haproxytech/haproxy-lua-http

Hi @jdesgats, @nevmerzhitsky, could you guys weigh in here? I'd be happy to open a PR just want to make sure this project is actively maintained!

Hi @jdesgats, @nevmerzhitsky, could you guys weigh in here? I'd be happy to open a PR just want to make sure this project is actively maintained!

Seems a good idea to add, imho.

For another dependency, pgmoon, we ended up hacking into package.loaded to modify the runtime socket library to use HAProxy's Lua API:
-- Monkeypatch socket package class to core for runtime (non-blocking) connections only
    if pg_settings["socket_type"] == nil then
        package.loaded["socket"] = core
    end

Might be easier to do something like this as well.


ModuleNotFoundError: No module named 'face_recognition'

face_recognition version:f ace-recognition 1.3.0
Python version:python 3.8
Operating System: MacOS M1

Description
Traceback (most recent call last):
File "/Users/chukwuebuka/web/project2/backend/my_flask.py", line 3, in
from face import recognize_faces
File "/Users/chukwuebuka/web/project2/backend/face.py", line 1, in
import face_recognition
ModuleNotFoundError: No module named 'face_recognition'
What I Did
trying to run a python code where i used the face regonition library but I get this errors
Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

Did you installed library by the pip?

give me the commands that you ran.

I removed .venv, install again, execute pip3 install --upgrade setuptools, and fix the issue.

Ok
On Tue, 25 Jun 2024, 1:23 pm Facundo Cachan, @.***>
wrote:

I removed .venv, install again, execute pip3 install --upgrade setuptools,
and fix the issue.
—
Reply to this email directly, view it on GitHub
https://github.com/ageitgey/face_recognition/issues/1564#issuecomment-2188223011,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATPSFDEOAG64JT7VUCMUSRDZJEOXVAVCNFSM6AAAAABHQLBRMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBYGIZDGMBRGE
.
You are receiving this because you commented.Message ID:
@.***>


checkpoints in google drive empthy

i downloaded a checkpoint from the google drive and tried to unzip it but the file didn't contain any data at ail.. this makes the whole repo unusable

Hi , you don't need to  unzip it , just put the file in checkpoint folder

I downloaded the checkpoint folder from the Google drive and they'd to unzip it but I get the error that it contains no data. I use Debian Linux 12


Longest Common Subsequence

Added longest_common_subsequence.cpp
Have you read the Contributing Guidelines on Pull Requests?
Yes
Description
Added DP solution in C++ for Longest common subsequence
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
issue #438

@Abhijit2505 @iamrajiv @atarax665 can you review this pr?

@iamrajiv Added requested changes

@Abhijit2505 Added requested changes

@Abhijit2505 please review this

@HarshCasper @ricardoprins , Please merge the PR guys.

@all-contributors please add @Joshitha18 for code

@all-contributors please add @Joshitha18 for code


There is a problem with mi band 4, connect not works

Hello @zaurhasanov
I'm not a contributor, but I think you might be hitting the server-side pairing requirement of the new firmwares.
You can find more info in the Gadgetbridge wiki: basically, you need to pair through the mifit app then pass an auth token to successfully pair.

Hello @zaurhasanov
I'm not a contributor, but I think you might be hitting the server-side pairing requirement of the new firmwares.
You can find more info in the Gadgetbridge wiki: basically, you need to pair through the mifit app then pass an auth token to successfully pair.

Can you tell me how to get the auth token from mi fit app after pairing my mi band 4/5 with mi fit?

The Mi band makers are trying to prevent open use of the device, and also add security by requiring that key. Its kinda of a pain to get.
Here is how to get the key: https://codeberg.org/Freeyourgadget/Gadgetbridge/wiki/Huami-Server-Pairing#requirements
The process differs depending on whether you have a rooted device or not. Either involves a sql query into the db the Bands main app, or running a python script.


Allow starting "+" sign for values to be parsed in valueOf() method

The valueOf() method of scalars currently does not allow a starting '+' sign, since that is not part of the official definition of a number in, e.g., en_US format. A more lenient way would be to strip the initial '+' from the string, and parse it.

Re-generated the code with the new NumberParser class from djutils. The valueOf() funtion now looks as follows:
    public static Area valueOf(final String text)
    {
        Throw.whenNull(text, "Error parsing Area: text to parse is null");
        Throw.when(text.length() == 0, IllegalArgumentException.class, "Error parsing Area: empty text to parse");
        try
        {
            NumberParser numberParser = new NumberParser().lenient().trailing();
            double d = numberParser.parseDouble(text);
            String unitString = text.substring(numberParser.getTrailingPosition()).trim();
            AreaUnit unit = AreaUnit.BASE.getUnitByAbbreviation(unitString);
            if (unit == null)
                throw new IllegalArgumentException("Unit " + unitString + " not found");
            return new Area(d, unit);
        }
        catch (Exception exception)
        {
            throw new IllegalArgumentException(
                    "Error parsing Area from " + text + " using Locale " + Locale.getDefault(Locale.Category.FORMAT),
                    exception);
        }
    }

And all unit tests work fine.


 You should add an  :not(.icon.list) on .ui.list .list. Thank you!

I have used the following CSS locally to work around this issue.
.ui.list i.icon.list {
padding: 0;
}

Fixed since Fomantic-UI 2.7.0


:lipstick: added new theme "Chimera-autumn"

I have not updated the README with new theme as I was unsure if this is something that needed to be done.
Chimera probably has 3 main themes and the rest are extras??
If I contribute more themes, do you want a screenshot of the theme in the PR for easier checkout or not?

If you could provide a screenshot that would be nice. I suggest you to copy The html of https://www.cssbed.com/sakura-vader/ as it showcases a wide variety of html-elements

Here are two screenshots for the theme.

Btw I think you should reference to either the HTML of the link you provided or an example file you have coded yourself in the GUIDE, so contributors know what is preferred.

Theme looks great! However it looks like there is an issue on The input type button under The radiobuttons: it dosent look like The text is visible 🫣
Also could you try white button text just to see wether it looks better?
On the previous note of using cssbed as example html code, that is just my personal preference for testing but we could recommend it in The guide :)😎

I think that it is important to document The available themes in the readme, which is why i will suggest  that you do appropriate changes there as well.

Feel free to merge after my reviews adressed. Great job🤘

README updated w/ screenshot of theme. Regarding the text under radiobuttons, it was just a screenshot error so it's there. Also here's the white button text:

Looking good


Table cell elements are always left-aligned

Jodit Version:  3.4.xxxxx
Browser:  Chrome
OS:  Windows
Is React App:  False
.jodit-wysiwyg table tr td, .jodit-wysiwyg table tr th {
   text-align: left;
}

Expected behavior: <td> <th> should not be specifically aligned. (text-align: left property should be removed)
Actual behavior: <td> <th> and the child elements are always left aligned.

@xdan any update on this issue? now it is blocking for us.

@xdan thanks for the fix.


Are you using mobilityDCAT-AP?

Are you using mobilityDCAT-AP?
If you are using mobilityDCAT-AP submit a comment on this issue to include the information in this repository.
Please structure your comment as follows:

The name of the NAP/mobility data portal/mobility data space
Link to the NAP/mobility data portal/mobility data space
Contact info to reach out: GitHub profile, email or Twitter
Status of the implementation: , , ,
(If available) Target deployment date (e.g., Q1 2025)
(If available) Link to the documentation to access the mobilityDCAT-AP metadata (e.g., API documentation)

NAP The Netherlands
https://toegangspuntmobiliteit.nl
<EMAIL_ADDRESS>Interested
Q1 2025

Hi @marioscrock We have started with the first steps on mobilityDCAT-AP, therefore, is it possible for you to change the status of the NL NAP to 'preparation'?


Ogamed vs library

Hello, just a quick question.
Has the Ogamed service only got a limited subset of the main library resources? So for example it currently it cannot call 'GetEspionageReport' resources until they are added to https://github.com/alaingilbert/ogame/blob/master/cmd/ogamed/main.go#L74 ?

That's right.
The thing is, I use the library a lot, and improve it all the time, and I don't really use the service.
So it gets a little bit neglected. But it would be very easy to add any missing feature.

Ok that's all I needed to know. Was just making sure I was not missing something that would allow me dynamically call the libs underneath via the HTTP interface.


example title links are not working in style guide for guide articles.

The 3 example links for properly named titles under Title Section in style guide for guide articles are broken.
click on this link to get to the issue
freeCodeCamp/docs/style-guide-for-guide-articles.md

May I take this one?


Proposed requirements and expanded spec for facet registrations

One-line summary:
proposed updates to registry.md
Problem
Call for contributions to the proposed registry
Solution
Changes:
02c1fc611a6005df3063d98475eb489f1e0b2d50 - Added a requirement
b8f6e5b4adc11e5b910d89a08fed7a2585f61ec7 - Added an entry for "core" to propose changes to the spec with a "known" starting point.
This entry:

root_doc_URL: "https://openlineage.io/spec/facets/"
produced_facets: [
"ol:core:1-0-0/ColumnLineageDatasetFacet.json",
"ol:core:1-0-1/ColumnLineageDatasetFacet.json",
"ol:core:1-0-0/DataQualityAssertionsDatasetFacet.json"
]

indicates that the documentation for the produced facets are at:
https://openlineage.io/spec/facets/1-0-0/ColumnLineageDatasetFacet.json
https://openlineage.io/spec/facets/1-0-1/ColumnLineageDatasetFacet.json
https://openlineage.io/spec/facets/1-0-0/DataQualityAssertionsDatasetFacet.json
b099579e093e33461d4ba39c8f3de25c3fc518ef - Proposing a new formatting of producer/consumer objects instead of an array of strings.
I have modified the "core" example, to show the translation between old and new format.
Added an "egeria" example which is both a producer and consumer.

Producer and consumer doc root URLs may differ, so they are set inside the producer/consumer object
It is assumed that the documentation link only applies to the facets owned by the same entity

e.g. egeria owns NewCustomFacet so the docs are at the Egeria doc URL
egeria does not own ColumnLineageDatasetFacet so there are no docs at the Egeria doc URL (unless it's extended by egeria?)

"sample_URL" is where the examples/tests can be found (recommended but not required)
"owner" is added for clarification. egeria produces their own custom facet plus one facet from core in this example
spec_versions array for compatibility
use_cases to better create the documentation page
since there are "consumer" and "producer" objects, "facets" replaces "produced_facets" and "consumed_facets"

8a0aee1b88d2aa326ef83022819d5b4a09bd60db - added another proposed requirement
11da7b5a697ef4f0add1a61f4e6229418d9503ba - added note about accuracy of registry entries
a53cfa04c7d83c3517ff42dfa325e5ebb52a359b - added Acceptance guidelines
d9eacf244b98fd9b8df03d29edaa80757e2cc8b3 - added a note about reserving names for the future.
Checklist
- [ ] Your change modifies the core OpenLineage model
- [ ] Your change modifies one or more OpenLineage facets

[x] You've signed-off your work
[x] Your pull request title follows our guidelines
- [x] Your changes are accompanied by tests (if relevant)
[x] Your change contains a small diff and is self-contained - NOTE: each commit is self-contained, but the PR contains multiple commits.
- [x] You've updated any relevant documentation (if relevant)
[x] Your comment includes a one-liner for the changelog about the specific purpose of the change (if necessary)
- [x] You've versioned the core OpenLineage model or facets according to SchemaVer (if relevant)
- [x] You've added a header to source files (if relevant)

SPDX-License-Identifier: Apache-2.0
Copyright 2018-2023 contributors to the OpenLineage project

@Sheeri would you be able to go over the responses and add comments or resolve conversations so we can merge this in?

Abaolutrly
Sent from ProtonMail mobile
-------- Original Message --------
On Nov 21, 2023, 4:27 PM, Harel Shein wrote:

@.***(https://github.com/Sheeri) would you be able to go over the responses and add comments or resolve conversations so we can merge this in?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

OK, I have resolved the comments that were effectively "thumbs-up" ones, and removed 2 open questions that we don't have answers to. cc @harels

Also resolved the merge conflicts.

(FYI the force push was because I hadn't signed off my changes with -s in my commits)


added sidebar animation

I modified the sidebar animation to use jquery animation. Its much cleaner than my previous solution.

👍 Thanks!


Test another super edge case

@eregon - Renamed, clarified the case you mentioned, and added another case in there. Should be good to go.

Thank you for your contribution!


How can i run my script?

Hi,
"Ctrl+B will run the current file (with AutoHotkey.exe)" is not working for me.
It always compiles the .ahk to an .exe but it won't run it.
what can i do?

Try Ctrl+Shift+B then.

tried it also it just says:
"Successfully compiled:
[Finished in 0.1s]"
But the script will not started..

Which Sublime Text version are you on ?
Also make sure you are running the latest version of AutoHotkey package. Ctrl-Shift-P, then "Package Control Upgrade Package" -> AutoHotkey

I am pretty sure, ive installed Sublime Text 3. The install folder is also named in Sublime Text 3. Checked ST3 for updates, no aviable.
Ctrl+Shift+P -> Package Control Upgrade Package = "---------------------------
Sublime Text
Package Control
There are no packages ready for upgrade
OK
"
When i press Ctrl+Shift+B, i can choose "Autohotkey" and "Autohotkey - Run", both are compiling the script, but won't run it.

I also have the same problem. I don't  konw how to deal with it.

This problem is caused by not having sublimetext running as administrator.

The command name is ahkrun. Source: https://stackoverflow.com/a/18882121
For sublime 3, you need to open up Preferences --> Key Bindings and append the following key binding to the right panel (user keybindings file):
[
	{ "keys": ["ctrl+shift+r"], "command": "ahkrun" }
]

or something similar. Whatever your preferred keybinging is. Custom user defined keybindings aught to override the default system and package level keybindings. So you can override ctrl+shift+b instead if you prefer.
Valid json: Assuming you are brand new to sublime settings files, it has to be valid formed json data. So each keybinding array items which are not the last item in the list need to have a comma between them, for example:
[
	{ "keys": ["ctrl+shift+a"], "command": "first_command" },
	{ "keys": ["ctrl+shift+b"], "command": "ahkrun" },
	{ "keys": ["ctrl+shift+c"], "command": "last_command_no_comma" }
]


Missing deprecation date for macos-11

Breaking changes
When will macos-11 be removed?
Target date
???
The motivation for the changes
The image deprecation policy in the README says:
https://github.com/actions/runner-images/blob/cb3fcb62b9ccef6bfcf0ffd613e0baad92e5a9e8/README.md?plain=1#L137-L144
macos-11 got deprecated rather unceremoniously in https://github.com/actions/runner-images/commit/5418817c5fd272379f7d5a56c2e63a3d7f1a49d8 a couple month ago, yet I cannot find any deprecation issue or announcement for it (in contrast to 10.15 for example). The one comment I found is from almost a year ago:

When will macOS 11 be deprecated?

@vpolikarpov-akvelon: According to the policy image deprecation process will start when new version (it's 13 currently) is out of beta. I can't provide any exact dates though. Deprecation will be announced in advance.

Possible impact
Know when macos-11 will be removed
Platforms affected

[ ] Azure DevOps
[ ] GitHub Actions

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[X] macOS 11
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[ ] Windows Server 2022

Mitigation ways
Upgrade

Hey @h-vetinari!
All the available information was published here: https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/#macos-11-deprecation-and-removal
It will take about one more week to deprecate macOS-11 image completely.

Thank you! I had opened the issue because the README had said:

During this time there will be an Announcement pinned in the repo to remind users of the deprecation.

In any case, that provides the requested information for me! Unless you think this issue could help other people looking for the same information, feel free to close it. :)

What's the state of this? The communicated removal date of June 28th has passed, but currently builds seem to be stuck in queued state for hours (so I'm assuming the GitHub macOS 11 workers are shut down).

Hi @h-vetinari, the macOS-11 image was deprecated. The issue will be closed.


fixes issue #3003

Coverage remained the same at 94.444% when pulling 2fed432a9726a57c2e19c9f4587a539a603e1141 on FinalAngel:develop into d3e1801f1e0a785173d8555f6d1442bd322d337a on divio:develop.

Coverage remained the same at 94.444% when pulling 2fed432a9726a57c2e19c9f4587a539a603e1141 on FinalAngel:develop into d3e1801f1e0a785173d8555f6d1442bd322d337a on divio:develop.

Coverage remained the same at 94.444% when pulling 2fed432a9726a57c2e19c9f4587a539a603e1141 on FinalAngel:develop into d3e1801f1e0a785173d8555f6d1442bd322d337a on divio:develop.

Coverage remained the same at 94.444% when pulling 2fed432a9726a57c2e19c9f4587a539a603e1141 on FinalAngel:develop into d3e1801f1e0a785173d8555f6d1442bd322d337a on divio:develop.


Add mode that shows the React elements on the page.

When clicking on the icon, inject a style sheet that gives a green outline or other indicator of where the React components are. Facebook would look something like this:

Happy to work on this, just wanted to make sure you were interested in this feature.

Sounds cool. Looking forward to a PR. If it's ok with you, I'll wait to release your other PR until this one gets in too. Thanks!

This has been published. You should get the update within the hour. Thanks for the PR!


Improve input argument checks of gemmt

Fix return value for invalid info: Looks like uplo was moved in the function signature at some point and the return values were not adjusted accordingly
Add missing checks for ldA, ldB
Use reference-LAPACK-like checks: Instead of ld < n use ld < MAX(1, n) . In other words, ld = 0 && n = 0 is now invalid

Thank you


Support using raw mmcif files

It would be much more convenient if alphafold could use the 'raw' mmcif files (e.g. gz compressed and divided by middle 2 characters). This has a number of advantages:

Considerably smaller (61GB vs 217GB)
Directories have only hundreds of files as opposed to 185'000 files
Easy to update with rsync

Hi Spencer, thanks a lot for this suggestion! Unfortunately it's not currently part of our plans due to other ongoing priorities but feature requests like this are much appreciated.


TypeScript build fails due to missing export of LocalizedStringFormatter type in React-Aria

Provide a general summary of the issue here
When attempting to use the useLocalizedStringFormatter hook from "react-aria" in a TypeScript project, the build fails. This is due to the absence of an export for the LocalizedStringFormatter type in the @react-aria/i18n package, which is necessary for proper type annotation in TypeScript.
I created a repo to showcase this here: https://github.com/alexasselin008/react-aria-i18n-feature-request/tree/main

I copied the CSS Starter kit and removed extra components,
I added a loading state to the button, with a localized "pending" string.
I added tsup to build the package.

When building, I receive the error:
src/intl/src/useLocalizedString.tsx(11,17): error TS2742: The inferred type of 'useLocalizedString' cannot be named without a reference to 'react-aria/node_modules/@internationalized/string'. This is likely not portable. A type annotation is necessary.

🤔 Expected Behavior?
The project should build successfully without any TypeScript errors, recognizing the LocalizedStringFormatter type used by the useLocalizedString hook.
😯 Current Behavior
The build process fails with a TypeScript error:
src/intl/src/useLocalizedString.tsx(11,17): error TS2742: The inferred type of 'useLocalizedString' cannot be named without a reference to 'react-aria/node_modules/@internationalized/string'. This is likely not portable. A type annotation is necessary.

💁 Possible Solution
I've tested this by directly modifying my node_modules, and it worked:

In @react-aria/i18n, export the LocalizedStringFormatter type from the package.
In react-aria, re-export the LocalizedStringFormatter type from @react-aria/i18n.

🔦 Context
No response
🖥 Steps to Reproduce

Clone the sample repository from https://github.com/alexasselin008/react-aria-i18n-feature-request/tree/main.
Install dependencies by running yarn in the project directory.
Attempt to build the project using yarn build.

Version
latest
What browsers are you seeing the problem on?
Chrome
If other, please specify.
No response
What operating system are you using?
Windows
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

Current code i was using
const Resources = {
    "en-US": resourcesEnUS,
    "fr-FR": resourcesFrFR
};

export function useLocalizedString() {
    return useLocalizedStringFormatter(Resources, "my-component-library");
}

My current workaround
Duplicating the types

const Resources = {
    "en-US": resourcesEnUS,
    "fr-FR": resourcesFrFR
};

type ResourceKeys = keyof typeof Resources[keyof typeof Resources]

export function useLocalizedString(): LocalizedStringFormatter {
    return useLocalizedStringFormatter(Resources, "my-custom-lib");
}

interface LocalizedStringFormatter {
    format: (key: ResourceKeys, variables?: Record<string, string | number | boolean>) => string;
}


Feature Request - Need Something like HttpApplication (that's pooled and assocaited to a thread)

In old ASP.NET we had HttpApplication (Global) that was tagged to a thread which in turn was pooled by ASP.NET. So effectively, there was one instance of HttpApplication for each pooled thread and thus:

HttpApplication was pool
We had an instance of HttpApplication that was automatically associated to a thread and so no overhead was incurred synchronizing an instance of HttpApplication to a request thread (in our application) or accessing this instance from within an ASP.NET application such as a WebForm, Controller or Handler.

This was very useful, because if we need to pool any of our own classes we could simply create an instance of this class in Global (typically in the Init() method) and assign it to a custom property of Global and this property was directly accessible from a WebForm, Handler or (WebAPI) Controller like so
((Global)HttpContext.Current.ApplicationIstance).MyProperty

Granted all pooled "things" need to be stateless or need to zero out their state at the beginning of every request. The benefit of being able to something like this is:

Throughput and Scale
Reduced pressure on the GC
Improved performance

If provided out of the box - makes it really easy for folks to get these benefits (caveat emptor), just like we were able to do riding on HttpApplication in old ASP.NET
I hope all of this makes sense?
Some code examples below, just in case I've not been clear enough on how I used this in old ASP.NET
The code below shows how one would initialize these pooled objects in Global. The QInsightManager is the property the makes the "pooled" object available to WebPages, Handlers, Controllers etc.
public class MvcApplication : System.Web.HttpApplication
{
    private QInsightManager _qInsightManager;

    internal QInsightManager QInsightManager
    {
        get { return _qInsightManager; }
    }

    public override void Init()
    {
        base.Init();
        _qInsightManager = new QInsightManager();
    }
}

The code below show how this pooled object can be consumed on an MVC ControllerBase class and made available to all descendants very simply.
internal QInsightManager QInsightManager
{
    get { return ((MvcApplication)HttpContext.ApplicationInstance).QInsightManager; }
}

This implementation ensures that we grab the instance associated with the instance of Global that is handling the request.

We had an instance of HttpApplication that was automatically associated to a thread and so no overhead was incurred synchronizing an instance of HttpApplication to a request thread (in our application) or accessing this instance from within an ASP.NET application such as a WebForm, Controller or Handler.

I'm not sure it was associated with a thread (that wouldn't work for async requests as they hop threads all the time) but @GrabYourPitchforks might know better. (ref https://github.com/Microsoft/referencesource/blob/master/System.Web/HttpApplicationFactory.cs)

This was very useful, because if we need to pool any of our own classes we could simply create an instance of this class in Global (typically in the Init() method) and assign it to a custom property of Global and this property was directly accessible from a WebForm, Handler or (WebAPI) Controller like so

What kind of objects did you need to associate with the HttpApplication? Those that didn't have any request affinity? If do, why not just make them singletons.
We're not going to build this into the framework but you can add a middleware that basically does the same thing. Pooling objects requires care so things don't leak across requests (as you may already know) and we're ok making it possible for you to pool objects but there no reason to build something like this in when it can be implemented in another package.

HttpApplication was pooled. May not have been pinned to a particular thread for its lifetime. But ASP.NET did pool them and associated one instance with the thread on which the incoming Request was made. I've used this "feature" since ASP.NET 1.1. IHttpHandler has a property IsResuable, which when set to true would also be pooled (which is also something I use all the time). We just need to do all we can to reduce the pressure on the GC.
Yes, as stated in my post, one had to be aware that these objects are pooled and thus need to be stateless or one has to ensure all state is reset at the start of every request. But that's no reason to not used such a feature given the huge performance and throughput gains to be had.
And you're correct. When doing async work, one has to be aware that when as task returns asynchronously it is most likely on a different thread. Many ways to handle this scenario. Again, no reason to support this feature.

What kind of objects did you need to associate with the HttpApplication? Those that didn't have any request affinity? If not, do, why not just make them singletons. If they do have request affinity, how do you zero them out?

My entire application (barring Controllers and the like) , that is all object instances are pooled "effectively". Except for models, DTOs and the like (input and output parameters). Basically, a Controller/Handler/Page accesses the Façade via the code show earlier. That's it, from then on I am in a stateless world. All classes are stateless all the way to the database and back.
Stateless is not "exactly" equal to a Singleton. A Singleton, also implies the need to be threadsafe. Which pooled objects generally are if they are stateless, but there are caveats...
This is a breaking change for me if there is no out of the box way of doing this. I'm simply asking for a feature that has been in ASP.NET since 1.1 and something that was used by ASP.NET and exposed to us (for example the IHttpHandler).
In fact, I was going to also ask if we could have pooled Controlers (using the IsReusable property like in IHttpHandler). My controller are also stateless (in the way they are written) but I'm still paying the penalty of adding pressure to the GC .
Yes, I know I can do anything I need with any given codebase. I'm asking for a "hook" (if you will) that I can use (similar to HttpApplication), that I can use.

we're ok making it possible for you to pool objects
Yup, that's what I'm asking for :smirk:

HttpApplication was pooled. May not have been pinned to a particular thread for its lifetime. But ASP.NET did pool them and associated one instance with the thread on which the incoming Request was made. I've used this "feature" since ASP.NET 1.1. IHttpHandler has a property IsResuable, which when set to true would also be pooled (which is also something I use all the time). We just need to do all we can to reduce the pressure on the GC.

To understand what feature you need and what can be done I need to understand if you are just looking to pool objects that have request affinity. If the answer is yes then we can move on, but the previous post made it seem like you were talking about thread affinity.

Yes, as stated in my post, one had to be aware that these objects are pooled and thus need to be stateless or one has to ensure all state is reset at the start of every request. But that's no reason to not used such a feature given the huge performance and throughput gains to be had.

You can do this on your own, like I said, we're not adding this to the framework via some object like http application. All of the building blocks are there though.

This is a breaking change for me if there is no out of the box way of doing this. I'm simply asking for a feature that has been in ASP.NET since 1.1 and something that was used by ASP.NET and exposed to us (for example the IHttpHandler).

ASP.NET 5 is a breaking change from all of ASP.NET. There is no IHttpHandler, HttpApplication etc nor will they be. I'm just trying to get to the core of what you're asking for instead of asking for what was in the original ASP.NET because it won't look the same.

Yes, I know I can do anything I need with any given codebase. I'm asking for a "hook" (if you will) that I can use (similar to HttpApplication), that I can use.

I'm still not 100% on what you're asking for (maybe you can clarify in the chat room https://jabbr.net/#/rooms/AspNetvNext or https://gitter.im/aspnet/Home). The "hook" you have dependency injection and maybe a piece of middleware (but I'm not even sure you need middleware).

Here's an example using the DI system:
public class Startup
{
    public void ConfigureServices(IServiceCollection services)
    {
        // ..  More things here
}

public class MyController
{
    private readonly ThingIWantToPool _thing;

    public MyController(PooledObject<ThingIWantToPool> pooled)
    {
        _thing = pooled.Value;
    }
}

public class ThingIWantToPool
{

}

public class PooledObject<T> : IDisposable where T : class, new()
{
    private static readonly ObjectPool<T> _pool = new DefaultObjectPoolProvider().Create<T>();

    public PooledObject()
    {
        Value = _pool.Get();
    }

    public T Value { get; }

    void IDisposable.Dispose()
    {
        _pool.Return(Value);
    }
}

In the above example, the PooledObject<T> is allocated per scope (there's a default request scope) and is used to control the lifetime of the T that it wraps. I'm using our ObjectPool from https://github.com/aspnet/Common/tree/dev/src/Microsoft.Extensions.ObjectPool. It's referenced by project.json:
{
  "version": "1.0.0-*",
  "compilationOptions": {
    "emitEntryPoint": true
  },

  "dependencies": {
    "Microsoft.AspNet.IISPlatformHandler": "1.0.0-rc1-final",
    "Microsoft.AspNet.Server.Kestrel": "1.0.0-rc1-final",
    "Microsoft.AspNet.Diagnostics": "1.0.0-rc1-final",
    "Microsoft.Extensions.ObjectPool": "1.0.0-*"
  },
  ...
}

Thread affinity or Request affinity depends on the implementation because from the point of view of the Application, they both look the same.
I’m going into details to jot down some things only so we’re on the same page (conceptually) and don’t mean to suggest you don’t know this stuff :smiley:
I’m assuming that in the framework you manage a pool of threads (managed threads) that get associated to the TCP connection (or whatever IPC method you use) from the web server. This association will need to be done using some form of thread synchronization (lock for example).
Now if you had a ThreadContext object (in addition to HttpContext) that is associated to each of your threads at the time the thread was created (rather than per request) then one could potentially attach other “things” to this context once at the time the thread is created by the pool. The ThreadContext would be disposed when the thread pool determines it no longer needs the thread. If once could have a means to access this ThreadContext (only) in order to associate other things we wanted pooled, then I’d called this Thread Affinity
Another way would be that the framework provides hooks such that we can provide it with an xxxFactory and it can create instances and associate them with whatever is pooled and associated to each request (and dispose of them as it sees fit). This would require thread synchronization to be in play as well. I’d call this Request Affinity.
Ok, I’m hoping conceptually we’re on the same page at this point
Request Affinity is probably easier to support but support for Thread Affinity would be fantastic! I’m not sure what we have currently in the framework that stays alive (in a pool) and gets associate to each request.
I’ve implemented (outside of the framework) the Thread Affinity model based solution. Works as expected but if such a feature is provided, a lot of folks could use this without having to roll their own.

Just saw your earlier post after I replied...
Thanks for the code/sample. Yes, I know I can do at this way. Some (additional) thread synchronization is needed in the DefaultObjectPoolProvider. As in the previous post, I'm guessing some form of thread synchronization is already being done once during the lifetime of the Request within the framework. I'd like to be able to plug into that. That way, any number of types can be associated to the Request with only one lock (at least for this purpose).
With the thread affinity model, once something is associated to the thread I never have to synchronize for that thread that object is always available. I also don't have my own pool since the threads are pooled I'm able to use that same pool for my instances.
I guess because I'm using the word "pool" you're thinking I want to do the pooling :smile:. While I want to piggy back on the pooling you already have.

Now if you had a ThreadContext object (in addition to HttpContext) that is associated to each of your threads at the time the thread was created (rather than per request) then one could potentially attach other “things” to this context once at the time the thread is created by the pool. The ThreadContext would be disposed when the thread pool determines it no longer needs the thread. If once could have a means to access this ThreadContext (only) in order to associate other things we wanted pooled, then I’d called this Thread Affinity

I still don't know why you care about threads in particular. Sounds like a BCL feature as ASP.NET isn't managing threads. We're just using the .NET Thread pool.

Another way would be that the framework provides hooks such that we can provide it with an xxxFactory and it can create instances and associate them with whatever is pooled and associated to each request (and dispose of them as it sees fit). This would require thread synchronization to be in play as well. I’d call this Request Affinity.

You can already do that today in about 5 different ways. The "hooks" you need are available.

Thanks for the code/sample. Yes, I know I can do it this way. Some (additional) thread synchronization is needed in the DefaultObjectPoolProvider.

Don't think so. Actually I think this does exactly what you need.

With the thread affinity model, once something is associated to the thread I never have to synchronize for that thread again since that object is always available. I also don't have my own pool since the threads are pooled I'm able to use that same pool for my instances.

That's not how any of this works. That's not how ASP.NET 4.x works either. You seem to be mixing up the general concept of a thread pool or maybe .NET's thread pool with the lifetime of pooled objects. HttpApplication instances were "pooled" and had no thread affinity; they were reset per request.

With the thread affinity model, once something is associated to the thread I never have to synchronize for that thread again since that object is always available. I also don't have my own pool since the threads are pooled I'm able to use that same pool for my instances.

See my earlier response about ASP.NET and thread management.

I guess because I'm using the word "pool" you're thinking I want to do the pooling :smile:. While I want to piggy back on the pooling you already have.

Still doesn't' make sense to me. We don't pool anything so you can't piggy back on anything.
The code I sent is pretty close to what you want. Like I said before, we're not going to built in any concept of pooling but the hook already exists (and now you have a sample).

ok, I've tried explaining what I need in many different ways and I can't seem to get through. You've got fixated on something that I know I don't need.

The code I sent is pretty close to what you want. Like I said before, we're not going to built in any concept of pooling but the hook already exists (and now you have a sample).

Yea, I know how that works but honestly that's not what I'm asking for. Thanks for your patience David. I mean dude, seriously.  Very much appreciated. :bow: .
I'll just use what I have and I'm not managing a pool and yet my objects pooled in the context of threads so once associated I never need to lock and associate

ok, I've tried explaining what I need in many different ways and I can't seem to get through. You've got fixated on something that I know I don't need.

That's unfortunate.

I'll just use what I have and I'm not managing a pool and yet my objects pooled in the context of threads so once associated I never need to lock and associate

How you choose to pool things is up to you. You don't have to use Microsoft.Extensions.ObjectPool, you can use whatever lifetime you need. The appropriate begin/end request hooks are there for you to reset objects as needed.

That's unfortunate.
No worries. I'll be back :smile_cat:

Yes, I'm using ThreadLocal. In this way:

I don't have to manage a pool
Once an instance is associated to a thread it is always available (automatically) without having to re-associate an instance from a pool (and have to use some form of synchronization) for every request to the application. This is done/managed by ThreadLocal and I find it to be extremely performant.

Here is what my class looks like. So far I've found this to be dependable and extremely performant. I plan on comparing this with what we get in ASP.NET old (since I have a number of large production systems with load and scalability tests already in place. I can remove the code I "typically" have in Global replace it with this class. I may need to make this class static so I don't have to create instance of this class for every request (since Controllers are not re-used across requests). One more instance of a type should still keep my comparison apples to apples.
    public abstract class ThreadLocalContextProvider<T> : IDisposable
    {
        private ThreadLocal<T> _threadLocal;

        private bool _disposed = false;

        public ThreadLocalContextProvider(Func<T> factoryMethod)
        {
            _threadLocal = new ThreadLocal<T>(() =>
            {
                T instance = factoryMethod();
                return instance;
            });
        }

        public T GetThreadLocalInstance()
        {
            return _threadLocal.Value;
        }

        public void Dispose()
        {
            Dispose(true);
            GC.SuppressFinalize(this);
        }

        private void Dispose(bool disposing)
        {
            if (!_disposed && disposing)
            {
                if (_threadLocal != null)
                {
                    _threadLocal.Dispose();
                    _threadLocal = null;
                }

                _disposed = true;
            }
        }
    }

Won't all this thread-specific code barf when you start using anything async?

No, why would it?
It's true that when an async task returns it's most likely on a different thread. But it's a thread. And this class will give you an instance (either previously created for that thread or a new one depending on whether the thread is brand new or one that has been used before). Either ways, you'll always have an instance of T issued to you by this class.
The key is to always ask this class for an instance when the async task returns rather than storing a local variable for the T on your end .
The way I use this is something like this.
I have a base controller that looks like this:
    public abstract class ControllerBase: Controller
    {
        private readonly DomainFacadeProvider _domainFacadeProvider;

        protected ControllerBase(DomainFacadeProvider domainFacadeProvider)
        {
            _domainFacadeProvider = domainFacadeProvider;
        }

        protected DomainFacade DomainFacade
        {
            get
            {
                return _domainFacadeProvider.GetThreadLocalInstance();
            }
        }
    }

Notice the DomainFacadeProperty. Also in this case the _domainFacadeProvider is just a closed generic type (descendant of ThreadLocalContextProvider<T>, the class in the previous post).
Now in say my HomeController (which is a descendant of ControllerBase)
        public async Task<IActionResult> Index()
        {
            var id = await GetData();
            return Content("Here's your data: " + DomainFacade.GetSomeData());
        }

I'm using the property, but the property accessor is getting it from the ThreadLocalContextProvider<T>. Basically anywhere you need an instance of DomainFacade, just use the property and you'll be fine. Just don't store a reference to it (in order to try an optimize).

@matlus
If you use it local to the method and return it at the end you can even go across await points with something like
public class PooledObjectFactory<T> where T : class, new()
{
    [ThreadStatic]
    private static T _pooledObject;

    public T Get()
    {
        if (_pooledObject != null)
        {
            var pooledObject = _pooledObject;
            _pooledObject = null;
            return pooledObject;
        }
        return new T();
    }

    public void Return(T pooledObject)
    {
        if (_pooledObject == null)
        {
            _pooledObject = pooledObject;
        }
    }
}

public void ConfigureServices(IServiceCollection services)
{
    services.AddSingleton(typeof(PooledObjectFactory<DomainProvider>),
        typeof(PooledObjectFactory<DomainProvider>));
}

public class MyController
{
    private readonly PooledObjectFactory<DomainProvider> _domainProviderPool;

    public MyController(PooledObjectFactory<DomainProvider> pool)
    {
        _domainProviderPool = pool;
    }

    public async Task<IActionResult> Index()
    {
        var id = await GetData();
        var provider = _domainProviderPool.Get();
        var content = Content("Here's your data: " + provider.GetSomeData());
        _domainProviderPool.Return(provider);
        return content;
    }
}

Though going across awaits may mean you are always creating on one thread (as it doesn't have one stored) then throwing away on another (as it already has one stored)

It doesn't create another one if it has one for the current thread. Why do you say it throws it away?

Sorry, I didn't see your previous post....where you've suggested a different class.
I only ever need (and want) one instance created for a given thread. If I understand your code correctly it looks like you'd likely create a new instance for a given thread if it already had one previously. Not sure why you think this is good.
Also seems to clutter the client code a bit, no?

public T Get()
{
    if (_pooledObject != null)
    {
        var pooledObject = _pooledObject;
        _pooledObject = null;
        return pooledObject;
    }
    return new T();
}

returns current thread's one if it exists; setting it to null for safety; creates new one if it doesn't already exist.

Also seems to clutter the client code a bit, no?

Can always wrap it in using if you perfer, but that would mean the Dispose method of the object would need to return it to the pool.

Sorry, I don't see the value of doing this. At least not they way I'm used to programming. Could you compare and contrast how I use the class I posted to what you've posted? Maybe I'm missing something.
FYI I'm going on vacation now...so my responses may be very sporadic for a week.

That's handled by the TreadLocal.

Am using ThreadStatic not ThreadLocal (though ThreadLocal uses ThreadStatic behind the scenes).

What the safety issue?

Someone will await somewhere and then you will have two threads using the same object or the object will change if you go back to the property. If you aren't worried about it going terribly terribly wrong by someone somewhere writing the wrong code then you can simplify it a bit.

I don't see how 2 threads will use the same object (if used correctly). Also if these types are thread safe and stateless then I don't have a problem with reusing the same instance across multiple threads (but in the way I mentioned, that won't be an issue. All my types are stateless with pure methods so personally I don't have issues like this, but yes caveat emptor!
ThreadLocal does all the heavy lifting for you that TreadStatic doesn't. See how your class would change if you use ThreadLocal?

All my types are stateless with pure methods

Just make all the methods static then and don't even create any objects at all?

Or if you want an object (so you can swap it for testing etc); then use services.AddSingleton and it will reuse the same object for everything.

I use them polymorphically.
Yes, in ASP.NET 5 I register the provider using the AddInstance() method. This class it provides (the T) is typically the only class used in this way. The other classes is the application are stateless and pure methods (is what I meant).

You probably want something like this then https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNet.Http/HttpContextAccessor.cs but for your specific type

If they are stateless and thread safe, why do you need an instance per thread instead of just an instance?

Thats fine, you can store things in TLS but I and use the DI system to flow instances around the code and manage the lifetime of the instance within a single request. I have more general question though:

If a request starts on one thread and finishes on another thread do you expect to get different instances of T?
As a follow on from that question, do you lazily initialize the request storage from the thread local storage? If so when thread hops occur (because ya know async code) do you just pick up the value from whatever thread accessed the value first?
Who cleans up the storage on the thread? i.e. when does Dispose get called?

Example:

Threads in the .NET thread pool denoted by T_n
Requests ASP.NET 5 are aware of denoted by R_n

T_1, T_2, T_3, T_4
R_1, R_2
R_1 starts on T_1
access TLS on T_1
await
R_1 continues on T_2
access TLS on T_2
R_1 ends on T_2
R_2 starts on T_2
access TLS on T_2
await
R_2 continues on T_1
access TLS on T_1
R_2 ends on T_1
When you access those values (where I have access TLS on T_n), I assume you want to get the same value before and after right?

To answer your first question:

If a request starts on one thread and finishes on another thread do you expect to get different instances of T?

Yes. Another way to say this is that I (shouldn't) don't care what instance of T I'm working on.

When you access those values (where I have access TLS on T_n), I assume you want to get the same value before and after right?

The "value" is an instance of some T. So no, I don't expect the same value. More specifically, the way code is written is to not care about what instance since this instance is stateless.
To answer @pranavkm

If they are stateless and thread safe, why do you need an instance per thread instead of just an instance?

Yes, This is really for two reasons:

Some code (third party as well as some legacy libraries) is not thread-safe. A single instance is reusable across multiple requests (stateless) but you can't have multiple threads partying on the same instance.
It's easier to reason about your code when you're dealing with just one thread (mentally) at a time.

The genesis of this was not throwing away instances after every request which is a lot of instances. Our first proof of concept was all static. Then due to the above, we moved to a "One instance per thread". On doing some throughput testing between the two, no discernable difference was seen. But huge differences between this style and the "A new instance of every class that is required to service a given request".

To answer your first question:

If a request starts on one thread and finishes on another thread do you expect to get different instances of T?

Yes. Another way to say this is that I (shouldn't) don't care what instance of T I'm working on.

When you access those values (where I have access TLS on T_n), I assume you want to get the same value before and after right?

The "value" is an instance of some T. So no, I don't expect the same value. More specifically, the way code is written is to not care about what instance since this instance is stateless.
To answer @pranavkm

If they are stateless and thread safe, why do you need an instance per thread instead of just an instance?

Yes, This is really for two reasons:

Some code (third party as well as some legacy libraries) is not thread-safe. A single instance is reusable across multiple requests (stateless) but you can't have multiple threads partying on the same instance.
It's easier to reason about your code when you're dealing with just one thread (mentally) at a time.

The genesis of this was not throwing away instances after every request which is a lot of instances. Our first proof of concept was all static. Then due to the above, we moved to a "One instance per thread". On doing some throughput testing between the two, no discernable difference was seen. But huge differences between this style and the "A new instance of every class that is required to service a given request".

Here is a simple (albeit a micro benchmark) test I did. All I'm trying to do here is a simulate (to the nearest approximation) a scenario that occurs typically and that is, if for every request, one creates new instance of all of the classes needed in order to handle a particular request and that the memory allocated for these classes is say 800K (in the real world this is quite a bit more). Then for this test, my T allocates a byte[] of 800K in size. That is, each time an instance of T is created, 800K gets allocated.
I remember doing a similar test way back during ASP.NET 1.1 days to see if the hypothesis (using pooled instances) had any weight and after the simplistic test showed some merit I conducted some real world tests using an entire production system and found the benefits we even greater that what this simplistic test was predicting.
Scenario 1:
We create an instance of T for every request.
Scenario 2:
We use the ThreadLocalContextProvider<T> shown in an earlier post in this conversation thread.
For the first Scenario my ConfigureServices() and Configure() methods in Startup look like this:
        public void ConfigureServices(IServiceCollection services)
        {
        }

        public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
        {
            app.Use(async (httpContext, next) =>
            {
                await httpContext.Response.WriteAsync(new DomainFacade(System.Threading.Thread.CurrentThread.ManagedThreadId).ThreadId.ToString());
            });
        }

For the second test (we'll pool instance of T using ThreadLocalContextProvider<T>. The ConfigureServices() and Configure() methods look like this:
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddInstance(new DomainFacadeProvider(() => new DomainFacade(System.Threading.Thread.CurrentThread.ManagedThreadId)));
        }

        public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
        {
            app.Use(async (httpContext, next) =>
            {
                var domainFacadeProvider = httpContext.ApplicationServices.GetRequiredService<DomainFacadeProvider>();
                await httpContext.Response.WriteAsync(domainFacadeProvider.GetThreadLocalInstance().ThreadId.ToString());
            });
        }

I used Apache Benchmark to simulate the work load. 100,000 requests with 50 concurrent.,using
ab -n 100000 -c 50 -k http://localhost/27126/
I'm using IISExpress as the webserver because I couldn't for some reason get AB to talk to Kestrel but for this test it doesn't matter what web server is used.
In Scenario 1 I get about 1,500 request/second
in Scenario 2 I get 2,650 request/second
increasing the memory allocation per request to 8MB I get the following results
In Scenario 1 I get about 853 request/second
in Scenario 2 I get 2,648 request/second
Food for thought.....
I will be testing this class in an ASP.NET 4.5 application that is in production, where we use Global to provide a similar capability to what the ThreadLocalContextProvider<T> affords, and replace the use of Global with it. Its not a simple swap but I think I can get close such that the comparison is still an Apples-apples comparison.

Here is a simple (albeit a micro benchmark) test I did. All I'm trying to do here is a simulate (to the nearest approximation) a scenario that occurs typically and that is, if for every request, one creates new instance of all of the classes needed in order to handle a particular request and that the memory allocated for these classes is say 800K (in the real world this is quite a bit more). Then for this test, my T allocates a byte[] of 800K in size. That is, each time an instance of T is created, 800K gets allocated.
I remember doing a similar test way back during ASP.NET 1.1 days to see if the hypothesis (using pooled instances) had any weight and after the simplistic test showed some merit I conducted some real world tests using an entire production system and found the benefits we even greater that what this simplistic test was predicting.
Scenario 1:
We create an instance of T for every request.
Scenario 2:
We use the ThreadLocalContextProvider<T> shown in an earlier post in this conversation thread.
For the first Scenario my ConfigureServices() and Configure() methods in Startup look like this:
        public void ConfigureServices(IServiceCollection services)
        {
        }

        public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
        {
            app.Use(async (httpContext, next) =>
            {
                await httpContext.Response.WriteAsync(new DomainFacade(System.Threading.Thread.CurrentThread.ManagedThreadId).ThreadId.ToString());
            });
        }

For the second test (we'll pool instance of T using ThreadLocalContextProvider<T>. The ConfigureServices() and Configure() methods look like this:
        public void ConfigureServices(IServiceCollection services)
        {
            services.AddInstance(new DomainFacadeProvider(() => new DomainFacade(System.Threading.Thread.CurrentThread.ManagedThreadId)));
        }

        public void Configure(IApplicationBuilder app, IHostingEnvironment env, ILoggerFactory loggerFactory)
        {
            app.Use(async (httpContext, next) =>
            {
                var domainFacadeProvider = httpContext.ApplicationServices.GetRequiredService<DomainFacadeProvider>();
                await httpContext.Response.WriteAsync(domainFacadeProvider.GetThreadLocalInstance().ThreadId.ToString());
            });
        }

I used Apache Benchmark to simulate the work load. 100,000 requests with 50 concurrent.,using
ab -n 100000 -c 50 -k http://localhost/27126/
I'm using IISExpress as the webserver because I couldn't for some reason get AB to talk to Kestrel but for this test it doesn't matter what web server is used.
In Scenario 1 I get about 1,500 request/second
in Scenario 2 I get 2,650 request/second
increasing the memory allocation per request to 8MB I get the following results
In Scenario 1 I get about 853 request/second
in Scenario 2 I get 2,648 request/second
Food for thought.....
I will be testing this class in an ASP.NET 4.5 application that is in production, where we use Global to provide a similar capability to what the ThreadLocalContextProvider<T> affords, and replace the use of Global with it. Its not a simple swap but I think I can get close such that the comparison is still an Apples-apples comparison.

Was an issue in rc1 with Kestrel and ab; should be resolved in rc2 https://github.com/aspnet/KestrelHttpServer/issues/406

Was an issue in rc1 with Kestrel and ab; should be resolved in rc2 https://github.com/aspnet/KestrelHttpServer/issues/406

That's nice to know! I went a bit bat eyed and finally just gave up.

That's nice to know! I went a bit bat eyed and finally just gave up.

Scenario 3:
Directly output the same string without an instance of T or using the ThreadLocalContextProvider<T>. The code to achieve this is as below
            app.Use(async (httpContext, next) =>
            {
                await httpContext.Response.WriteAsync(System.Threading.Thread.CurrentThread.ManagedThreadId.ToString());
            });

Gives me about 2,928 Requests/second

Scenario 3:
Directly output the same string without an instance of T or using the ThreadLocalContextProvider<T>. The code to achieve this is as below
            app.Use(async (httpContext, next) =>
            {
                await httpContext.Response.WriteAsync(System.Threading.Thread.CurrentThread.ManagedThreadId.ToString());
            });

Gives me about 2,928 Requests/second

@matlus It looks like you have a solution then. That's great!

@matlus It looks like you have a solution then. That's great!

@davidfowl In the very fist post in this thread I said:

If provided out of the box - makes it really easy for folks to get these benefits (caveat emptor), just like we were able to do riding on HttpApplication in old ASP.NET

So, I would say I don't. I mean I've had a solution for a while (ever since starting to play with ASP.NET 5), what I asked for was something out of the box, as I think it is very useful.

But as I said in earlier posts, we will not be providing something like this and after seeing what you've done it looks pretty esoteric (and is nothing like how HttpApplication works today).

and is nothing like how HttpApplication works today.
HttpApplication is pooled by ASP.NET. Are you saying it is not?

I agree the use of HttpApplication (riding on the fact that it is pooled) in this way is esoteric. Throughput requirements drive this.

But as I said in earlier posts, we will not be providing something like this

Yes, I'm aware.

HttpApplication is pooled by ASP.NET. Are you saying it is not?

It's not stored in a thread local/thread static. The original PooledObject<T> is more like what HttpApplication does today.

It's not stored in a thread local/thread static.
Yes, I know that. It's pooled. That's what I've been asking for. Something that is pooled and that we (as users of ASP.NET) can piggy back on. I don't really care how it is pooled :)

Closing this


[ALLUXIO-3393] Add a new scheduling method ADSM

https://alluxio.atlassian.net/browse/ALLUXIO-3393
ADSM is a parameter auto-tuning and low overhead method to schedule data blocks on tier storage, and SP-factor mechanism is desiged to promote  performance of hybrid memory system consists of HBM and DRAM.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/1386/
Test FAILed.

alluxio-bot, check this please

alluxio-bot, check this please

alluxio-bot, check this please

@RangerSjzhao if you are still interested in merging this can you please re-target this to master rather than branch-1.8?
I'm going to close this for now, but we would enjoy this contribution if you can re-target to master.
Thanks!


feat: [IDP]: Added the release notes for v0.35

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6710a5f1d8f8e68aa44c42bb--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6710c002bcb337ade5acd0e7--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6715e605ee5caae5409ed7f6--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6715f47f809f46f4ed25cc28--harness-developer.netlify.app

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6715fbd13dd600fd3e3fae8c--harness-developer.netlify.app


template is not defined (generateLegend)

I've bin trying out the 2.0 dev version mainly because for x-axis-filter & y-axis-filter.
Besides the x-axis-filter not working i found that the generateLegend  was missing the helpers object.
Rule 1457  generateLegend function should return helpers.template
i found that the Legend doesn't automatically update when adding a new data set butt that is outside the scope of my project.
http://jsfiddle.net/Ripmeester/3n74mpfs/20/

This has been fixed.


Claims Appeared Out of Order

If a relationship did not have a label, such as PFSCustomer, then the claims were ordered by node2.

Fallback to the relationship name.  Fix merged into dev.


[BUG] Signing QR is cut off

Describe the bug
When signing a tx the pairing QR is cut off
Expected behavior
Scale Signing QR with window size
Screenshots

macOS with v1.1

This happens after a device joins. where it normally diretly should proceed to signing when threshold is met

QA done.


Automated test suite

Decent starting set of tests added in a89a49d, 69072b2, bdb7986, 7dccf8e, 4a0a247, 9e608bf and 11ba44c, need to check and expand coverage of tests. Use the code added in these commits as a starting point.


When having a lot of experimental variables in an experiment I have to scroll to the right

Describe the bug
When adding a lot of experimental variables I have to scroll to the right to see all of them.
To Reproduce
Steps to reproduce the behavior:

Add a lot (>15) experimental variables
You have to scroll to the right

Expected behavior
The variables are in multiple rows.
Screenshots

Smartphone (please complete the following information):

Version data manager 1.2.3

does not work for
Firefox 129.0.2

@Steffengreiner this issue does not reference a PR, but has the status "Needs Review". Please link the PR that addresses the issue.

Dear @sven1103. my apologies, These cards are a remnant of the discussion i had with @Shraddha0903.
The original issue was already addressed in an older PR, however the cards resizing themselves had to be fixed.
I linked the relevant PR


[Summer 2021]Supplement open-api document (both en-US and zh-CN)

hi, thanks for your contribution, please resolve conflicts files.

The file is updated

The conflict files has been resolved weiyi xu @.*** 签名由 网易邮箱大师 定制 On 07/29/2021 10:45, Kirs wrote: hi, thanks for your contribution, please resolve conflicts files. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

@ptyp PTAL,thx


jinja2 templates?

hi again, last question for now ;) .
it seems sad that cactus pulls in all of (a very old 1.5) version of django just to use the templating engine. is it possible that cactus will eventually support, for example, jinja2 templates, which django itself now officially supports as of version 1.8?
seems like it would be much lighter just to rely on a modern templating engine rather than a (currently ancient) version of django.
just general questions, no expectations. i'm an open source developer myself and i have a full understanding of the time constraints of volunteer developers.
cheers.

more information on issue #117

ok, thanks for the pointer.  it's interesting that django itself now supports jinja2 templates, i wonder if that makes it any easier to add support to cactus.

The main reason for not upgrading to newer Django is Python 2.6 support, which was dropped after Django 1.5.
Cheers,

@krallin thanks for working on this, I think it's a very desirable feature.
I don't think that anybody care for python 2.6 support.

i agree would be nice, thanks @krallin ;)

:+1: I agree, please consider

@fedelibre,
I think it's a bit dangerous to just disregard whomever might be using Python 2.6. Another concern with upgrading is that some plugins might tie into Django internals directly, and those have changed a bit since Django 1.5.
Basically, I have more work to do on identifying what has changed before we can upgrade.
Cheers,


Splinter doesn't work with Selenium 4.0

Selenium 4.0.0 was just released.
With the latest version there are apparently some API changes that Splinter doesn't handle well.
Our issue was TypeError: __init__() got an unexpected keyword argument 'timeout' on https://github.com/cobrateam/splinter/blob/253a6f21699a60651943bac11cf87a24da4d5a81/splinter/driver/webdriver/firefox.py#L71

or upgrade to splinter>=0.16.0 😄

how do I do that? Whenever I run pup upgrade it keeps getting splinter==0.15.0

or upgrade to splinter>=0.16.0 😄

how do I do that? Whenever I run pup upgrade it keeps getting splinter==0.15.0

you can try pip install --upgrade splinter or pip install "splinter>=0.16.0"

upgrade to splinter>=0.16.0

0.16.0 pins selenium<4 so that won't work.
This is unfortunate because file uploads don't work on Selenium 3.x on Python 3.9.

@blaise-io 0.16.0's release pins selenium 3 in order to prevent dependency conflicts, it has nothing to do with getting selenium 4 to work.
Selenium 4 compatibility is coming soon-ish.

0.16.0 pins selenium<4 so that won't work.

Right, the workaround I mentioned is for installing Splinter with Selenium 3.x. Not for making Splinter work with Selenium 4.x. Just to be clear.

Fixed by #963


Fix keyboard navigation in menus

🐛 Bug Report
Keys Up, Down, Right, Left must change selected item in the menus.
Enter must click menu item.
💻 Repro or Code Sample
Go to https://www.fluentui-blazor.net/Menu
For ex., scroll to "Simple context menu" and try to press Up / Down / Enter
🤔 Expected Behavior
Keys Up, Down, Right, Left must change selected item in the menus.
Enter must click menu item.
😯 Current Behavior
Viewport is scrolled, enter does not click

This works, but you need to activate the 'Menu' section first, using the Tab key for example.


Crontab permission denied with non-privledged user

One more request in regards to hardening!
Right now, the container seems unable to schedule the cron task based on the envionrment variable when running as a non-privledged user. When running as a non-root, custom user (by adding user: UID:GID in the compose file, I will note I'm not using the included backuptool user), the following error is generated:
vaultwarden-backup-1       | /app/entrypoint.sh: line 46: //crontabs: Permission denied
vaultwarden-backup-1       | time="2024-01-12T11:47:11-05:00" level=fatal msg="open //crontabs: no such file or directory"

Could be an error on my part but any input would be appreciated! Thanks!

Now, using a non-root user must be done through the built-in backuptool (with UID and GID both set to 1100).
This was a poorly designed choice I made early on when I wasn't familiar with Docker. I will redesign the way non-root users are used, such as allowing users to input UID and GID.
For now, you can either use the root user directly or the backuptool user.


Introduce Runtime Security Agent - RFC Security Agent

What does this PR do?
This PR implements the Security Agent RFC
Motivation
This PR introduces the Runtime Security Agent with its first feature: File Integrity Monitoring. Most of the code resides in system-probe and leverages eBPF to detect abnormal behaviors based on rules provided in a configuration file.
Additional Notes
Most of the code resides in system-probe.

pkg/security/agent:
Receive events sent by the runtime security agent part of system-probe
and forwards them to Datadog

pkg/security/api:
Protobuf definition of triggered security alerts

pkg/security/config:
Definition of the confiuration of the runtime security agent

pkg/security/ebpf:
C source of eBPF programs required by the runtime security agent

pkg/security/module:
Runtime security system-probe module

pkg/security/policy:
Policy - set of rules and macros - loading

pkg/security/probe:
Core of runtime security agent.
Loads eBPF programs, decode and evaluate events sent from the kernel

pkg/security/rules:
Rules evaluation

pkg/security/secl:
Rules parser and code generation for fast evaluation

pkg/security/tests:
Functional test suite

Describe your test plan
Functional test suite that will be run automatically in a future CI Job

You should probably specify the owner of pkg/security on the CODEOWNERS file


Unexpected template path when binding hardware feature to a model.

Hi Folks,
So I have a feature of type hardware in aquilon called network/bonding-mode4. I expect the associated template file to be: ~/$sandbox> $archetype/features/hardware/network/bonding-mode4/config.pan.
However, when I bind the feature to a given model, the include statement created in the pre_feature template does not appear to have the correct path:
include {
        if ((value("/hardware/manufacturer") == "dell") &&
            (value("/hardware/template_name") == "r430-2015-cephgw")){
                return("features/hardware/network/bonding-mode4")
        } else{ return(undef); };
};
"/metadata/features"={
        if ((value("/hardware/manufacturer") == "dell") &&
            (value("/hardware/template_name") == "r430-2015-cephgw")){
                append("features/hardware/network/bonding-mode4/config");
        } else { SELF; };
};

I would expect line 4 to read return("features/hardware/network/bonding-mode4/config") not return("features/hardware/network/bonding-mode4"). Is this a bug?
Best wishes,
Bruno

That was due to our template code using non-standard naming convention for hardware features. The current version of the broker uses if_exists() to support both the legacy and the standard naming.


[fix][#3895] unable to open urgency folder

if mobile site setting has disabled

Coverage increased (+1.5%) to 80.129% when pulling 0a720fd7d6cc5d5c142ba3118bf0195ce38ec0b7 on fix/ss-3895 into 387418b93ed406f6446e1f05bce7e89f85fcb048 on master.

Coverage increased (+1.5%) to 80.129% when pulling 0a720fd7d6cc5d5c142ba3118bf0195ce38ec0b7 on fix/ss-3895 into 387418b93ed406f6446e1f05bce7e89f85fcb048 on master.

Coverage increased (+1.5%) to 80.129% when pulling 0a720fd7d6cc5d5c142ba3118bf0195ce38ec0b7 on fix/ss-3895 into 387418b93ed406f6446e1f05bce7e89f85fcb048 on master.


Non-semantic labels require IDs & yield minimum target size

In the example you’re using non-semantic labels that require IDs. Why not use them in the traditional fashion?
<label>Name:
<input type="text"></label>

This also has the benefit of allowing you to observe Fitt’s Law and  control the target size of the element perfectly.

Sorry, but can you please clarify which code you're referring to?


Parent test step

Codecov Report

Merging #18 (0ec5458) into master (9b70848) will decrease coverage by 0.01%.
The diff coverage is 41.77%.

@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
- Coverage     53.38%   53.37%   -0.02%
- Complexity     1050     1054       +4
============================================
  Files           204      204
  Lines          5207     5235      +28
  Branches        770      778       +8
============================================
+ Hits           2780     2794      +14
- Misses         2185     2193       +8
- Partials        242      248       +6

Impacted Files
Coverage Δ

...assandra/model/factory/CassandraTestStepFactory.kt
0.00% <0.00%> (ø)

...cessor/db/model/factory/DatabaseTestStepFactory.kt
0.00% <0.00%> (ø)

...rocessor/http/model/factory/HttpTestStepFactory.kt
0.00% <0.00%> (ø)

...or/ibmmq/model/factory/BaseIbmMqTestStepFactory.kt
0.00% <0.00%> (ø)

...mq/model/factory/IbmMqConsumableTestStepFactory.kt
0.00% <0.00%> (ø)

...cessor/ibmmq/model/factory/IbmMqTestStepFactory.kt
0.00% <0.00%> (ø)

...rocessor/jdbc/model/factory/JdbcTestStepFactory.kt
0.00% <0.00%> (ø)

...cessor/rmq/model/factory/BaseRmqTestStepFactory.kt
0.00% <0.00%> (ø)

.../rmq/model/factory/RmqConsumableTestStepFactory.kt
0.00% <0.00%> (ø)

.../processor/rmq/model/factory/RmqTestStepFactory.kt
0.00% <0.00%> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b70848...0ec5458. Read the comment docs.


[WIP] Omnibus package for Windows

upgrade ruby version to 2.4.1
upgrade readline & nokogiri to work with ruby 2.4.1
msi package config

Fixes #2307

Needs merge with #2656
This is a blocker for the 1.4 release.

It seems that we cannot get this to work in time for 1.4. We probably need to document cli installation on Windows better:

use Linux Subsystem for Windows
install Ruby & Devkit

WSL with Ubuntu Ruby packages works great for me. Personally I use a Linux VM for running docker daemon and using DOCKER_HOST pointed at the VM I can easily do kontena build from the WSL now instead of inside the VM. The only issue I have is there are warnings about my PATH containing locations from other filesystems.  To quash those warnings I added this to .profile:
export PATH=${PATH%%:/mnt/*}

Status? Should this PR be updated, or closed because we're not planning on setting up windows build hosts?

We tried to setup windows build hosts but getting working builds seems to be very hard. We can probably close this for now (or leave it open for 1.5).

Were the problems with the actual omnibus build, or with getting the CI automation setup? This PR could still be useful if it let you do manual omnibus builds.

Problems were with omnibus build. Not sure if they were related to Windows Server but the actual build environment is very tricky to setup for Windows.

Out of date and not going anywhere.


C elegans sex validation does not allow XO/XX

Describe the issue
The sex field for C elegans is an odd edge case that doesn't seem to work correctly right now. XO and XX should be allowed when the species is set as C elegans.
Steps to Reproduce
https://github.com/NeurodataWithoutBorders/nwb-guide/assets/310197/dc07c255-bb3c-46e8-b908-7308d9421d02
Operating System
Mac M1
GUIDE Version
main
Code of Conduct
Yes
Did you confirm this issue was not already reported?
Yes

fixed in #705