runOnDemandCloseAfter blocks the path after teardown

Which version are you using?
v1.8.2
Which operating system are you using?

[ ] Linux amd64 standard
[ ] Linux amd64 Docker
[ ] Linux arm64 standard
[x] Linux arm64 Docker
[ ] Linux arm7 standard
[ ] Linux arm7 Docker
[ ] Linux arm6 standard
[ ] Linux arm6 Docker
[ ] Windows amd64 standard
[ ] Windows amd64 Docker (WSL backend)
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
Using runOnDemand with runOnDemandCloseAfter seems to create an issue where the path will block and become unresponsive until the runOnDemandCloseAfter times out even if the path is destroyed.
Can we get runOnDemandCloseAfter to reset and run immediately if the path is destroyed or a way to reset it?
Or is there a way to clear out and reset the path with runOnNotReady?
Describe how to replicate the issue

Set runOnDemandCloseAfter: 60s
start the server
read the path
stop the path source
attempt to read the path again before the timeout
attempt to read the path again after the timeout

Did you attach the server logs?
<!-- STOP SOURCE -->

07:07:45 DEB [RTSP] [conn <IP_ADDRESS>:37054] [c->s] TEARDOWN rtsp://<IP_ADDRESS>:8554/front-door RTSP/1.0
CSeq: 6
Session: 6e3581c500424bef8d4695af4e4ac9a8
User-Agent: Lavf60.3.100

07:07:45 INF [path front-door] runOnReady command stopped
07:07:45 INF [path front-door] runOnNotReady command launched
07:07:45 INF [RTSP] [session de560115] destroyed: torn down by <IP_ADDRESS>:37054
07:07:45 DEB [RTSP] [conn <IP_ADDRESS>:37054] [s->c] RTSP/1.0 200 OK
CSeq: 6
Server: gortsplib

07:07:45 INF [RTSP] [conn <IP_ADDRESS>:37054] closed: EOF

<!-- ATTEMPT TO OPEN PATH FAILS -->
07:08:15 INF [RTSP] [conn <IP_ADDRESS>:53748] opened
07:08:15 DEB [RTSP] [conn <IP_ADDRESS>:53748] [c->s] OPTIONS rtsp://localhost:8554/front-door RTSP/1.0
CSeq: 2
User-Agent: LibVLC/3.0.20 (LIVE555 Streaming Media v2016.11.28)

07:08:15 DEB [RTSP] [conn <IP_ADDRESS>:53748] [s->c] RTSP/1.0 200 OK
CSeq: 2
Public: DESCRIBE, ANNOUNCE, SETUP, PLAY, RECORD, PAUSE, GET_PARAMETER, TEARDOWN
Server: gortsplib

07:08:15 DEB [RTSP] [conn <IP_ADDRESS>:53748] [c->s] DESCRIBE rtsp://localhost:8554/front-door RTSP/1.0
Accept: application/sdp
CSeq: 3
User-Agent: LibVLC/3.0.20 (LIVE555 Streaming Media v2016.11.28)

07:08:20 INF [RTSP] [conn <IP_ADDRESS>:32700] opened
07:08:20 DEB [RTSP] [conn <IP_ADDRESS>:32700] [c->s] SETUP rtsp://localhost:8554/front-door RTSP/1.0
CSeq: 0
Transport: RTP/AVP;unicast;client_port=9346-9347

07:08:20 INF [RTSP] [session bf9e0231] created by <IP_ADDRESS>:32700
07:08:20 DEB [RTSP] [conn <IP_ADDRESS>:32700] [s->c] RTSP/1.0 461 Unsupported Transport
CSeq: 0
Server: gortsplib
Session: 3abe25442c0b42218fa1d0ae00783bb2

07:08:20 INF [RTSP] [conn <IP_ADDRESS>:32700] closed: invalid URL ((null))
07:08:20 INF [RTSP] [session bf9e0231] destroyed: not in use
07:08:20 INF [RTSP] [conn <IP_ADDRESS>:24446] opened
07:08:20 DEB [RTSP] [conn <IP_ADDRESS>:24446] [c->s] OPTIONS rtsp://localhost:8554 RTSP/1.0
CSeq: 1
Clientchallenge: 9e26d33f2984236010ef6253fb1887f7
Clientid: Linux_2.4_<IP_ADDRESS>5_play32_RN01_EN_586
Companyid: KnKV4M4I/B2FjJ1TToLycw==
Guid: 00000000-0000-0000-0000-000000000000
Playerstarttime: [28/03/2003:22:50:23 00:00]
Regiondata: 0
User-Agent: RealMedia Player Version <IP_ADDRESS>5 (linux-2.0-libc6-i386-gcc2.95)

07:08:20 DEB [RTSP] [conn <IP_ADDRESS>:24446] [s->c] RTSP/1.0 200 OK
CSeq: 1
Public: DESCRIBE, ANNOUNCE, SETUP, PLAY, RECORD, PAUSE, GET_PARAMETER, TEARDOWN
Server: gortsplib

07:08:20 INF [RTSP] [conn <IP_ADDRESS>:24446] closed: EOF

<!-- runOnDemand FINALLY TIMES OUT -->
07:08:40 INF [path front-door] runOnDemand command stopped: not needed by anyone
07:08:40 INF [path front-door] runOnUnDemand command launched

<!-- ATTEMPT TO OPEN PATH SUCCEEDS -->
07:08:51 INF [RTSP] [conn <IP_ADDRESS>:60874] opened
07:08:51 DEB [RTSP] [conn <IP_ADDRESS>:60874] [c->s] OPTIONS rtsp://localhost:8554/front-door RTSP/1.0
CSeq: 2
User-Agent: LibVLC/3.0.20 (LIVE555 Streaming Media v2016.11.28)

07:08:51 DEB [RTSP] [conn <IP_ADDRESS>:60874] [s->c] RTSP/1.0 200 OK
CSeq: 2
Public: DESCRIBE, ANNOUNCE, SETUP, PLAY, RECORD, PAUSE, GET_PARAMETER, TEARDOWN
Server: gortsplib

07:08:51 DEB [RTSP] [conn <IP_ADDRESS>:60874] [c->s] DESCRIBE rtsp://localhost:8554/front-door RTSP/1.0
Accept: application/sdp
CSeq: 3
User-Agent: LibVLC/3.0.20 (LIVE555 Streaming Media v2016.11.28)

07:08:51 INF [path front-door] runOnDemand command started

Did you attach a network dump?
no

Would this be the cause of the API and path outputs freezing?

I meet this similar problem，as runOnDemandCloseAfter is default to 10s, this issue should be a common problem while using OnDemand source/publisher. My log as below:
2024/07/09 09:49:31 INF [RTSP] [conn <IP_ADDRESS>:64348] opened
2024/07/09 09:49:31 INF [RTSP] [session b3be0d4a] created by <IP_ADDRESS>:64348
2024/07/09 09:49:31 INF [RTSP] [session b3be0d4a] is publishing to path 'test', 2 tracks (H265, MPEG-4 Audio)
2024/07/09 09:49:31 INF [HLS] [muxer test] is converting into HLS, 2 tracks (H265, MPEG-4 Audio)
2024/07/09 09:50:00 INF [RTSP] [conn <IP_ADDRESS>:64348] closed: read tcp <IP_ADDRESS>:8554-><IP_ADDRESS>:64348: wsarecv: An existing connection was forcibly closed by the remote host.
2024/07/09 09:50:00 INF [path test] runOnDemand command exited: command exited with code 1
2024/07/09 09:50:05 INF [path test] runOnDemand command exited: command exited with code 1
2024/07/09 09:50:10 INF [RTSP] [session b3be0d4a] destroyed: session timed out
2024/07/09 09:50:10 INF [HLS] [muxer test] destroyed: terminated
2024/07/09 09:50:10 INF [path test] runOnDemand command exited: command exited with code 1
2024/07/09 09:50:10 INF [HLS] [muxer test] created (requested by [::1]:64352)
2024/07/09 09:50:20 INF [path test] runOnDemand command stopped: not needed by anyone
fix patch proposal as below:
diff --git a/internal/core/path.go b/internal/core/path.go
index 2119927c..0f12d8ae 100644
--- a/internal/core/path.go
+++ b/internal/core/path.go
@@ -531,6 +531,9 @@ func (pa *path) doAddReader(req defs.PathAddReaderReq) {
 	}

 	if pa.conf.HasOnDemandStaticSource() {
+		if pa.onDemandStaticSourceState == pathOnDemandStateClosing {
+			pa.onDemandStaticSourceStop("error: static source terminated unexceptedly!")
+		}
 		if pa.onDemandStaticSourceState == pathOnDemandStateInitial {
 			pa.onDemandStaticSourceStart(req.AccessRequest.Query)
 		}
@@ -539,6 +542,9 @@ func (pa *path) doAddReader(req defs.PathAddReaderReq) {
 	}

 	if pa.conf.HasOnDemandPublisher() {
+		if pa.onDemandPublisherState == pathOnDemandStateClosing {
+			pa.onDemandPublisherStop("error: publisher terminated unexceptedly!")
+		}
 		if pa.onDemandPublisherState == pathOnDemandStateInitial {
 			pa.onDemandPublisherStart(req.AccessRequest.Query)
 		}
diff.patch

Hello, the problem of both proposed solutions (https://github.com/bluenviron/mediamtx/issues/3455#issuecomment-2216296201 and #3507) is that they prevent runOnDemandRestart: yes from working, which is also the correct way to address the issue, although it's slightly slower, since the command is restarted after some seconds and not immediately.
Furthermore, runOnDemandRestart: yes makes the run-on-demand logic to behave exactly live the source-on-demand logic, reducing the number of possible server states and therefore the number of possible bugs.
Therefore, a proper fix consists in making runOnDemandRestart: yes the default option.

Unfortunately, runOnDemandRestart: yes won't work in my situation since I use runOnDemand and runOnUnDemand to start/stop a camera publishing to MTX, and setting runOnDemandRestart: yes will causes runOnDemand to constantly trigger the script to start the camera:
runOnDemand command exited: command exited with code 0
runOnDemand command exited: command exited with code 0
runOnDemand command exited: command exited with code 0
...

Is there a way we can still trigger pa.onDemandPublisherStop("publisher removed") if runOnDemandRestart: no is set?

@mrlt8 in every operating system or programming language there are two ways to start subprocesses:

in the foreground, in which the subprocess is launched directly, stays open during runtime and can be eventually be restarted in case of errors. This is supported here by using runOnDemand and runOnDemandRestart: true.
in the background, in which the subprocess is started and detached from the main process. Restarts are not a mattern of concern for the main process and should be handled directly inside the subprocess or a wrapper (like systemctl). This is supported here by using runOnDemand, runOmDemandRestart: false and runOnUndemand.

The situation you are describing is a mixture between both cases - basically you want to start a background process but keep the monitoring logic into the server. We cannot support this scenario since it's too specific. Adapt your scripts to run either as foreground processes or background processes with a restart logic.

Sorry, @aler9 it seems there might have been a bit of a misunderstanding.
I don't need mediaMTX to monitor or restart the subprocess. I'm just looking for a way to clear out the onDemandPublisherCloseTimer when the on demand publisher closes.
Thanks for your help!

The onDemandPublisherCloseTimer becomes unnecessary once the onDemandPublisher has closed

This is not true, the on-demand publisher might be in the process of restarting, as described in the background logic mentioned above. Adding this in the server would cause a service, which is already started, to start again.
Summing up, the logic you are describing is not compatible with the most common use cases for the run-on-demand command and it's also confusing since it mixes up different layers. Switch to one of the two logics written above.

Thanks for the quick reply, @aler9.
If runOnDemandRestart is set to false, the publisher shouldn't be attempting to publish to the path once the runOnNotReady command is launched. However, I suppose a temporary connection issue could cause the path to appear down even if it's still publishing, as you're describing?
Is there an alternate way we might be able to clear the onDemandPublisherCloseTimer, perhaps through the API or as an option with runOnNotReady?
Thanks again for looking into this!


Name field needs to include first and last

https://github.com/ascott1/ethical-web-dev/blob/master/web-apps-for-everyone/04-inclusive-forms.md
In my head, we only new the first name of the patient. BUT, I have re-learned that we need first and last. However, I think it's good to have just one input box for name, per the link above.
Should we add additional helper copy to indicate that we need both names?

I've never seen that inclusive forms doc before and I kinda love it!
I think that adding helper copy to indicate that we need both names is a great.
(This is partially represented in #55 too.)

@mebates what are the next steps here? CM weigh in, frontend changes in the pregnancy view form, something else?

How about just changing the text box label, like this?

Perf! Retagging as frontend, this is a pretty straightforward change.
Whoever takes this on will want to pop into the form field and adjust the label attribute in that particular instance. Refer to the docs in the rails-bootstrap-forms gem we use here: https://github.com/bootstrap-ruby/rails-bootstrap-forms

There are two places where we'll need to fix this, most likely: the app/views/pregnancies/_patient_dashboard view, and the app/views/pregnancies/_new_patient view. I think that's the only place we plug in names.


Add a brute force option to re-use common structs

Currently, it's impossible for kopium to detect similar structs re-used at different hierarchies because the schemas all have to be inlined and we cannot use $ref in schemas. https://github.com/kubernetes/kubernetes/issues/62872
Suggestion
We should try to brute-force compare all structs to all previously seen structs in the analyzer to deduplicate so that we don't generate 3 different structs for things such as livenessProbe, resources, MatchLabels (under different names).
We already have the skeletons of such code, but it only checks for a few known ones like Condition here and it's enabled toggled under a flag (default enabled) --no-condition.
If we pass existing state into the extractor functions (such as extract_container) we can then inspect current state before adding duplicates (ensuring we only take the first instance of a struct) via something like is_duplicate_struct. It would also avoid having an awkward O(n^2) algorithm at the end.
My thinking is that it might not be a particularly heavy operation on (at most) a few hundred kB of schema data.
Limitations
This would not solve the problem where we are generating a type for something know; e.g. Condition might be identified with this algorith, and while it would be deduplicated, but it would not point to the upstream type in k8s-openapi.
This is probably fine however; it allows overrides to be done more easily (change / elide one struct rather than find and replace multiple), and it's a good stepping stone towards identifying them with upstream variants (such as is done for Condition).
More Context

https://github.com/kube-rs/gateway-api-rs/issues/38
https://github.com/kube-rs/kube/discussions/1667

+1, this would be very helpful for https://github.com/kube-rs/gateway-api-rs/issues/38


Xiao ming qi ka branch

Related Issue
Reason(purpose, problem)
Description(do, change)
Test case(new, change, influence)

Other git store


Component Request: ListView

Please add the ListView component

please add ListView component.

@symmetriccurve hi,how to add components


WFLY-5146 Expose Infinispan's remoteCommandExecutor thread pool confi…

…guration
Jira
https://issues.jboss.org/browse/WFLY-5146

Linux Build 7625 is now running using a merge of 4b93aa5d2b27486c4c78c0feaac8a886389746b7

Linux Build 7625 outcome was SUCCESS using a merge of 4b93aa5d2b27486c4c78c0feaac8a886389746b7
Summary: Tests passed: 3117, ignored: 364 Build time: 00:49:06

Looks good.


Updating the kit - issues with component imports

On the cross gov slack @marthaboggins raised an issue where the charcterCount wasn't working - it looks like this was a combination of updating to the latest frontend, but the kit referencing the old component at old path. The docs also didn't make clear what things were using what versions and only worked for certain versions.
I see a few issues which wouldn't be too hard to fix:

The kit update docs don't tell you you need to update layout.html to reference the new location.
If you’ve got your own changes in layout.html (not unlikely), you'd have to merge those with the new components as they’re manually added.

Suggestion:
We've long had the aim that stuff in app should be user specific - but in this case the components need to be manually added. Copying the app folder from an old prototype to a new one won't work.
I'd suggest that the individual macro imports for all gov.uk components should be done via separate include file. That way if the kit gets updated and macros are added, that include file can be automatically updated rather than manually adding the items in layout.html.

Suggesting something like this, where we reference the macros, but don't actually define them in layout.html

This spike is somewhat related: https://github.com/alphagov/govuk-frontend/pull/1436

@nickcolley yeah, that seems similar.
Presumably less risky / easier to do if just for the kit? Essentially just abstracting out the other macro includes to a file outside of /app

Yes it should be done in the kit first, just posting for reference.

closing in favour of #967


Broken Link to Graph Docs

Hi,
the link Set up a multitenant organization using Microsoft Graph API in the Section 'Related Topics' is broken.
Maybe this is the right one:
https://learn.microsoft.com/en-us/azure/active-directory/multi-tenant-organizations/multi-tenant-organization-configure-graph

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0191a050-64de-1a38-e2a0-a09964f6dc2b
Version Independent ID: 0191a050-64de-1a38-e2a0-a09964f6dc2b
Content: Set up a multitenant org in Microsoft 365 (Preview) - Microsoft 365 Enterprise
Content Source: microsoft-365/enterprise/set-up-multi-tenant-org.md
Service: microsoft-365-enterprise
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@J-a-k-o-b Thank you for your feedback. We have made changes to the document via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/12848
Once the author approves, the changes will be live.
Thanks
Sri


POSTing a RAMON 'succeeds' (200) even when it fails

Using documentation listed here.
Steps to reproduce:

Create a token/channel annotation target. (I'm using ndio_demos/ramontests).
POST to http://openconnecto.me/ocp/ca/ndio_demos/ramontests/ with a binary file as the POST data. I used a small PNG file.

Expected behavior:

500 or other server error

Actual Behavior:

Server returns a 200 OK with no further debug information or output to indicate that the upload was a failure.

@alexbaden @kunallillaney this is what i mentioned in the channel. Don't have privileges on this repo or I'd add the appropriate labels.


email provider not linking with existing facebook account.

Regarding firebaseUI auth, i found that if an email account is already linked with facebook provider there is an error of
W/AccountLinker: Error linking with credential
    com.google.firebase.FirebaseException: User has already been linked to the given provider.
        at com.google.firebase.auth.api.internal.zzce.zzb(Unknown Source:221)
        at com.google.firebase.auth.api.internal.zzao.zzd(Unknown Source:35)
        at com.google.firebase.auth.FirebaseAuth.zzc(Unknown Source:15)
        at com.google.firebase.auth.FirebaseUser.linkWithCredential(Unknown Source:11)
        at com.firebase.ui.auth.util.accountlink.AccountLinker.start(AccountLinker.java:82)
        at com.firebase.ui.auth.util.accountlink.AccountLinker.<init>(AccountLinker.java:52)
        at com.firebase.ui.auth.util.accountlink.AccountLinker.linkToNewUser(AccountLinker.java:65)
        at com.firebase.ui.auth.viewmodel.idp.LinkingSocialProviderResponseHandler.startSignIn(LinkingSocialProviderResponseHandler.java:43)
        at com.firebase.ui.auth.ui.idp.WelcomeBackIdpPrompt$1.onSuccess(WelcomeBackIdpPrompt.java:129)
        at com.firebase.ui.auth.ui.idp.WelcomeBackIdpPrompt$1.onSuccess(WelcomeBackIdpPrompt.java:126)
        at com.firebase.ui.auth.viewmodel.ResourceObserver.onChanged(ResourceObserver.java:45)
        at com.firebase.ui.auth.viewmodel.ResourceObserver.onChanged(ResourceObserver.java:14)
        at android.arch.lifecycle.LiveData.considerNotify(LiveData.java:109)
        at android.arch.lifecycle.LiveData.dispatchingValue(LiveData.java:126)
        at android.arch.lifecycle.LiveData.setValue(LiveData.java:282)
        at android.arch.lifecycle.MutableLiveData.setValue(MutableLiveData.java:33)
        at com.firebase.ui.auth.viewmodel.OperableViewModel.setResult(OperableViewModel.java:24)
        at com.firebase.ui.auth.data.remote.FacebookSignInHandler.access$600(FacebookSignInHandler.java:39)
        at com.firebase.ui.auth.data.remote.FacebookSignInHandler$ProfileRequest.onCompleted(FacebookSignInHandler.java:172)
        at com.facebook.GraphRequest$1.onCompleted(GraphRequest.java:301)
        at com.facebook.GraphRequest$5.run(GraphRequest.java:1380)
        at android.os.Handler.handleCallback(Handler.java:790)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6494)
        at java.lang.reflect.Method.invoke(Native Method)

and that error is probably fine. but there  NO CALBACK to onActivityResults. instead i get a toast that an error has occured.
Here are the steps to reproduce:

login with facebook

logout

signin with email provider and use the same email as the facebook account.

3b. user then get the prompt: you've already used<EMAIL_ADDRESS>. Sign in with facebook to continue

after facebook prompt appears to resolve the collision enter in facebook credentials (or hit continue if it does not prompt etc)

library gives the above error and a toast message that an error has occured.

expected results: i get a callback with result OK and move forward.
for your info in the firebase console the email account i tested with only had the facebook provider listed.

dont close this yet. let me try again to give you steps. i'll grab the updates that you guys up in past few days also. will report back soon.

do you guys recommend i fork this repo or Alex's if i need the most recent changes ?

What changes are you looking for specifically?

There are actually snapshot builds now, so unless you need the advanced account linking, those should cover it. 👍

Oh wait, you filed https://github.com/SUPERCILEX/FirebaseUI-Android/issues/27! So actually, this turns out to be a major oversight on my part that primarily affects my fork, but would have nipped us in the butt pretty bad later on had you not caught it. So... thanks! ❤ I've already included a fix in f0a391a50b of my fork and you can view the PR: #1293.

#1293 is merged so there should be a 4.0.0 SNAPSHOT build availabile with the fix in a half hour or less.  Would love if you could confirm that it fixes your problem.

i already put the changes in manually since it was a not big changes. its working now.


Connect to QGC while using mavsdk on the companion computer

Hi all：
I am trying to connect via serial (ttyAMA0) from pixhawk to a raspberryPi and control my drone throught MAVSDK-Python.
In the meantime, I want to connect my drone to QGC through mavlink-router, but it failed.
Firmware: PX4 1.13.3
MAVSDK-Python: 1.4.9
mavsdk-server: 1.4.17
First, i run the mavsdk-server manually:  ./mavsdk_server_linux-arm64-musl -p 50051 serial:///dev/ttyAMA0:921600
then, I run the example python code——firmware_version.py  which
drone = System(mavsdk_server_address='localhost',port=50051)
await drone.connect(system_address="serial:///dev/ttyAMA0")

So I think the above pictures can prove that the connection between the mavsdk and the drone is fine.
Next, I want to connect to QGC on my ubuntu PC <IP_ADDRESS> by udp, so i run the mavlink-router on raspberryPi like this:
mavlink-routerd -e <IP_ADDRESS>:14550 /dev/ttyAMA0:921600

At this moment, I found error message in mavsdk_server terminal, and the connection of QGC is very unstable(sometimes ready to fly and sometimes disconnected)

Finally, I just want to use mavsdk-python at the same time QGC was connected to observe the status of the drone, but the QGC connection remained unstable
What should I do to solve this problem? Please help. Thank you!

Just to add, The error message of the mavsdk_server termi  is shown in the figure below

Looks like you are trying to access the same serial device in two places: once with mavsdk-server and once with mavlink-routerd. You can use mavlink-routerd to create a second endpoint:
mavlink-routerd -e <IP_ADDRESS>:14550 -e <IP_ADDRESS>:20000 /dev/ttyAMA0:921600

and make the mavsdk-server use the new endpoint (assuming that mavlink-routerd and mavsdk-server run on the same machine):
./mavsdk_server_linux-arm64-musl -p 50051 udp://<IP_ADDRESS>:20000

oh!!!, it's a good idea. Later I will retest according to your guidance.
Thank you very much!

@dayjaby answered it perfectly. I'll close this as I think it'll solve the problem.


could not create/update output branch: rpc error: code = Unknown desc = etcdserver: request is too large

What happened?:
Ran pachctl update pipeline -f - with the following input:
{
  "enable_stats": true,
  "input": {
    "pfs": {
      "glob": "/*/",
      "lazy": true,
      "name": "iarpa",
      "repo": "iarpa-assembly-input-shuffle"
    }
  },
  "parallelism_spec": {
    "coefficient": 1
  },
  "pipeline": {
    "name": "iarpa-wtdbg2-assembly"
  },
  "pod_patch": "[{\"op\": \"replace\", \"path\": \"/containers/0/imagePullPolicy\", \"value\": \"Always\"}]",
  "resource_requests": {
    "cpu": 24
  },
  "standby": true,
  "transform": {
    "cmd": [
      "bash"
    ],
    "image": "bdgp/wtdbg2",
    "stdin": [
      "set -eux -o pipefail\n[[ -d $iarpa ]] || exit\n[[ ! -e \"$iarpa\"/info/family || $(cat \"$iarpa\"/info/family) = bacteria ]] && exit\n# get the median genome size in nucleotides\n# do pass-only and pass/fail assemblies\ng=$( (find \"$iarpa\"/reference_genome/*.{fa,fasta} ||true) |xargs -d \\\\n perl -0076 -ne 'chomp; next if !$_; ($h,$s)=split/\\n/,$_,2; $s=~s/\\s+//g; $s{$ARGV}+=length($s); END{@f=sort {$s{$a}<=>$s{$b}} keys %s; $f=$s{$f[int(@f/2)]}; print \"$f\\n\"}') || true\ng=${g:-125m}\n# set prefix\nmkdir -p \"/pfs/out/$(basename \"$iarpa\")/assembly/wtdbg2\"\nprefix=/pfs/out/$(basename \"$iarpa\")/assembly/wtdbg2/wtdbg2\nwtdbg2 -x ont -g \"$g\" $(printf -- \"-i %q \" \"$iarpa\"/nanopore/*/*/*/*.fastq) -t0 -fo \"$prefix\"\nwtpoa-cns -t0 -i \"$prefix.ctg.lay.gz\" -fo \"$prefix.ctg.fa\"\n# polish with short reads\nbwa index \"$prefix.ctg.fa\"\nfind \"$iarpa\"/illumina/*/*_R2_*.fastq.gz |perl -pe 's/_R2_/_R1_/' |xargs -d \\\\n gzip -cd |pigz >read1.fq.gz\nfind \"$iarpa\"/illumina/*/*_R2_*.fastq.gz |xargs -d \\\\n gzip -cd |pigz >read2.fq.gz\nbwa mem -t 24 \"$prefix.ctg.fa\" read{1,2}.fq.gz |samtools view -Sbu - |samtools sort -@ 24 - |samtools view - |wtpoa-cns -t0 -x sam-sr -d \"$prefix.ctg.fa\" -i - -fo \"$prefix.ctg.polished.fa\"\nmv -v \"$prefix.ctg.polished.fa\" \"/pfs/out/$(basename \"$iarpa\")/assembly/wtdbg2_assembly.fasta\"\n"
    ]
  }
}

Received the following error:
Reading from stdin.
could not create/update output branch: rpc error: code = Unknown desc = etcdserver: request is too large

What you expected to happen?:
The pipeline should have been updated.
How to reproduce it (as minimally and precisely as possible)?:
Not sure how to reproduce, seems to happen sporadically. Usually I end up having to delete and re-create all pipelines to work around.
Anything else we need to know?:
Environment?:

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-19T16:40:16Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.5", GitCommit:"2166946f41b36dea2c4626f90a77706f426cdea2", GitTreeState:"clean", BuildDate:"2019-03-25T15:19:22Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"linux/amd64"}

Pachyderm CLI version (use pachctl version):

COMPONENT           VERSION
pachctl             1.9.0
pachd               1.9.0

Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s):

on-premises

OS (e.g. from /etc/os-release):

Arch linux

Others:

I found another workaround: I edited the etcd kubernetes yaml command section and added the following argument: --max-request-bytes 33554432

@benwbooth Sorry you're hitting this! There are a few different places where we can hit a transaction size limit -- we thought we got most of them, but clearly missed a few.
In think this is a similar issue to #3879. Shoudn't be too hard to fix and glad you hae a temporary workaround for now.

Is the branch you're taking as input iarpa-assembly-input-shuffle@master the result of a long chain of pipelines? That's the only thing I could think of that would lead to a request that's too large, the content of the pipeline shouldn't have any effect because that code gets stored in a commit, not in etcd.

This has probably been solved by #3958, which shipped in 1.9.3, feel free to reopen if you hit it again.


Dexie Cloud feature request: in-app invitations

Shared realms is an excellent feature of Dexie cloud, but the e-mail-to-invite default behaviour isn't flexible enough for all use-cases. I've encountered two related issues:
Problem 1: If the developer is using custom auth, Dexie may not have e-mail addresses or those addresses may not be up-to-date with what the custom auth system knows.
Problem 2: Users who do not know each other well may not want to share their e-mail address, but still want to collaborate.
Current Solution: In the current system, both issues can be solved by e.g. the developer creating a backend endpoint that handles creating realms and adding users to it with whatever invitation infrastructure it wants to use. The problem with this solution is that a user can't hit that backend endpoint if the app is currently in offline mode.
I have two suggested solutions. Either or both could be implemented:
Proposed Solution 1: Add web hooks to Dexie cloud, such that Dexie calls out to an arbitrary HTTP endpoint provided by the webapp developer whenever an invite needs to be sent (this infrastructure could also be used for custom e-mails, as an alternative to sharing SMTP settings). This endpoint could receive the dexie-cloud ID and issue invitations however it sees fit. Options include forcibly adding them to the realm, sending an e-mail or SMS, or having the app developer implement solution 2 below.
Proposed Solution 2: In-app invitations
I think it's possible to make realm invitations work using just dexie-cloud sync without an external e-mail service. Here's how I imagine the flow:

Alice wants to invite Bob to a shared realm.
Bob shares some identifying information with Alice however he sees fit. It could be his e-mail address or an opaque custom auth ID, or even a username or possibly even Alice shares her profile in the public realm. Dexie-cloud places no restrictions on this information; the app gets to decide what to do with it.
Alice inputs this information into the webapp
The webapp uses whatever tools it has at its disposal to figure out what Bob's dexie-cloud user id is. For example, it may query a backend endpoint that looks bob's dexie-cloud ID up in an auth database.
The webapp creates a new realm using the current realm creation flow.
The webapp adds Bob's ID as a member to the realm with invite: true (or maybe appInvite: true or something to distinguish from e-mail based invites)
---- Sync to Dexie Cloud ----
Dexie cloud service recognizes that Bob has not accepted an invitation, so he is not added to the new realm yet.
Dexie cloud service adds some data to a new sharedInvites dexie-cloud table. This data would include roughly the same stuff that currently gets sent in an e-mail: who the inviter is, the name of the realm, etc.
---- The table syncs to Bob's browser ----
Bob's client webapp live-queries the invitations table and uses whatever UI it thinks is suitable to render an invitation to Bob.
Bob can either accept or decline the invite using whatever interactions make sense to that webapp. The accept or decline state gets stored in the invitation table
---- Sync to Dexie Cloud ----
Dexie-cloud service sees that an invitation was accepted and does the same magic it currently does when a user clicks the accept link in an invitation e-mail
Dexie-cloud service adds Bob to the realm
The realm data syncs to Bob's device using the existing flow
Possibly some knowledge about whether Bob accepted or declined the invite syncs back to Alice, or perhaps that information is better kept private.

At least proposed solution 1 could be implemented with generic data mutation web hooks:

It should be possible to register web hooks that listens to certain tables and criterias (configurable).
Whenever an object is created that fullfills the criteria, web hook is called and that backend could use REST api to perform additional tasks, including sending out invite on a channel of their choice.

The configuration could be done via CLI or Manager app.


Add is_ok, etc.

This PR adds is_ok, is_retry, and is_err methods to OperationResult. (I think it's pretty straightforward.)

Thank you! Released in 1.3.0.


celeste: 0.8.1 -> 0.8.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/hwittenborn/celeste/releases.
meta.description for celeste is: GUI file synchronization client that can sync with any cloud provider
meta.homepage for celeste is: https://github.com/hwittenborn/celeste
meta.changelog for celeste is: https://github.com/hwittenborn/celeste/blob/v0.8.2/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.8.2 with grep in /nix/store/5ffnl5id79f5iqap2bjhnir2kl7ixnby-celeste-0.8.2
found 0.8.2 in filename of file in /nix/store/5ffnl5id79f5iqap2bjhnir2kl7ixnby-celeste-0.8.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

celeste

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5ffnl5id79f5iqap2bjhnir2kl7ixnby-celeste-0.8.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A celeste https://github.com/r-ryantm/nixpkgs/archive/cbe431a053f0984e089b5f024f12deead472cfc7.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/cbe431a053f0984e089b5f024f12deead472cfc7#celeste

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5ffnl5id79f5iqap2bjhnir2kl7ixnby-celeste-0.8.2
ls -la /nix/store/5ffnl5id79f5iqap2bjhnir2kl7ixnby-celeste-0.8.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

celeste

Maintainer pings
cc @dotlambda for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/celeste-file-sync/versions.
meta.description for celeste is: GUI file synchronization client that can sync with any cloud provider
meta.homepage for celeste is: https://github.com/hwittenborn/celeste
meta.changelog for celeste is: https://github.com/hwittenborn/celeste/blob/v0.8.3/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.8.3 with grep in /nix/store/6rqd38l6xqkznswzqpj7davdsssx09cr-celeste-0.8.3
found 0.8.3 in filename of file in /nix/store/6rqd38l6xqkznswzqpj7davdsssx09cr-celeste-0.8.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

celeste

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6rqd38l6xqkznswzqpj7davdsssx09cr-celeste-0.8.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A celeste https://github.com/r-ryantm/nixpkgs/archive/00f383408bb19c71cf1b6bb22da303ccf0ef4258.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/00f383408bb19c71cf1b6bb22da303ccf0ef4258#celeste

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6rqd38l6xqkznswzqpj7davdsssx09cr-celeste-0.8.3
ls -la /nix/store/6rqd38l6xqkznswzqpj7davdsssx09cr-celeste-0.8.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

celeste

Maintainer pings
cc @dotlambda for testing.


Fix Spark issues that were found recently

Part of https://github.com/quasar-analytics/quasar/issues/1907

Codecov Report

Merging #1922 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1922      +/-   ##
==========================================
+ Coverage    65.6%   65.62%   +0.01%
==========================================
  Files         376      376
  Lines       18583    18586       +3
  Branches      229      228       -1
==========================================
+ Hits        12192    12197       +5
+ Misses       6391     6389       -2

Impacted Files
Coverage Δ

...n/scala/quasar/physical/sparkcore/fs/package.scala
12.5% <ø> (ø)
:white_check_mark:

...n/scala/quasar/physical/sparkcore/fs/Planner.scala
67.77% <100%> (+0.54%)
:white_check_mark:

...a/quasar/physical/sparkcore/fs/local/package.scala
11.76% <100%> (ø)
:white_check_mark:

...nector/src/main/scala/quasar/qscript/MapFunc.scala
64.17% <ø> (+0.4%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcbbcc...f8ca3c4. Read the comment docs.

This makes all the it/test passes for both spark-hdfs and spark-local connectors. This is pre-requirement to put Spark on travis.

Part of https://github.com/quasar-analytics/quasar/issues/1666


Add wait_for for futures

Describe your changes
This PR changes the handling of all futures used by the charge_point.cpp or charge_point_impl.cpp by adding wait_for for futures.
libocpp consumers (like everest-core have timeouts that might exceed if the changed function do not return within a defined timeout. This occured e.g. for a DataTransfer.req triggered externally which resulted in an everest-framework cmd timeout of 300s.
Without this change, messages might be 'stuck' in the message queue and the time until the message is being processed in the message queue can be very long. This can e.g. happen if connection problems are present and/or the CSMS does not respond to messages as expected or as per spec. Adding the wait_for of 60 seconds makes sure that these functions return within a defined timeout.
Issue ticket number and link
Checklist before requesting a review

[ ] I have performed a self-review of my code
[ ] I have made corresponding changes to the documentation
[ ] If OCPP 2.0.1: I have updated the OCPP 2.0.1 status document
[ ] I read the contribution documentation and made sure that my changes meet its requirements

At least in charge_point there are still some send_async left that we should also have a look at I think.

At least in charge_point there are still some send_async left that we should also have a look at I think.

There was missing handling for the future on_get_15118_ev_certificate_request so I added this. For the other send_async it is never attempted to retrieve the value of the future, so without looking further into it, I was wondering a bit why send_async is even used there.


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter tractive-gps for common errors and appropiate suggestions to keep this adapter up to date.
Please see the result of the check below.
ioBroker.tractive-gps
   -

:thumbsup: No errors found
WARNINGS:

[ ] :eyes: [W174] Potential sensitive data "password" not listed at "encryptedNative" in io-package.json

Please review issues reported and consider fixing them as soon as appropiate.
Warnings reported by repository checker should be reviewed. While some warnings can be considered as a suggestion and be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
Note: This issue replaces issue #202
@mcm1957 for evidence

This issue has been replaced by new isse #205
This issue can be closed.
your
ioBroker Check and Service Bot


Receiving S3 backend credential error when using an AWS config assumed role profile

I receive the error:
Error configuring the backend "s3": No valid credential sources found for AWS Provider.
When attempting to run terragrunt using an AWS config assumed role profile.  The same exact terragrunt command works perfectly fine using a AWS config profile that is either using an IAM user (Access Key + Secret Key) or assumed credentials (Access Key + Secret Key + Token).
Here is a rundown...
> export AWS_PROFILE=aws.premium.staging
> export AWS_DEFAULT_PROFILE=aws.premium.staging
> aws sts get-caller-identity
{
    "UserId": "AROAIYKNPLZYTEIM2JL46:botocore-session-1543851525",
    "Account": "##REDACTED##",
    "Arn": "arn:aws:sts::##REDACTED##:assumed-role/OrganizationAccountAccessRole/botocore-session-1543851525"
}

> TF_LOG=debug TERRAGRUNT_DEBUG=true terragrunt plan
[terragrunt] [/Users/<REDACTED>/code/smar/terraform_premium/live/staging/IAM] 2018/12/03 07:40:13 Running command: terraform --version
[terragrunt] 2018/12/03 07:40:13 Reading Terragrunt config file at /Users/<REDACTED>/code/smar/terraform_premium/live/staging/IAM/terraform.tfvars
[terragrunt] 2018/12/03 07:40:13 WARNING: no double-slash (//) found in source URL /CloudOps/tfm_smar_iam.git. Relative paths in downloaded Terraform code may not work.
[terragrunt] 2018/12/03 07:40:13 Terraform files in /Users/<REDACTED>/code/smar/terraform_premium/live/staging/IAM/.terragrunt-cache/35z1Uw8yNAtpa2jho5yiyAsrb_M/KUZWpCLP92GDGc5x4p0Yt0vOivM are up to date. Will not download again.
[terragrunt] 2018/12/03 07:40:13 Copying files from /Users/<REDACTED>/code/smar/terraform_premium/live/staging/IAM into /Users/<REDACTED>/code/smar/terraform_premium/live/staging/IAM/.terragrunt-cache/35z1Uw8yNAtpa2jho5yiyAsrb_M/KUZWpCLP92GDGc5x4p0Yt0vOivM
[terragrunt] 2018/12/03 07:40:13 Setting working directory to /Users/<REDACTED>/code/smar/terraform_premium/live/staging/IAM/.terragrunt-cache/35z1Uw8yNAtpa2jho5yiyAsrb_M/KUZWpCLP92GDGc5x4p0Yt0vOivM
[terragrunt] 2018/12/03 07:40:15 Running command: terraform plan -var-file=/Users/<REDACTED>/code/smar/terraform_premium/live/staging/terraform.tfvars -var-file=/Users/<REDACTED>/code/smar/terraform_premium/live/staging/../common.tfvars
2018/12/03 07:40:15 [INFO] Terraform version: 0.11.10
2018/12/03 07:40:15 [INFO] Go runtime version: go1.11.1
2018/12/03 07:40:15 [INFO] CLI args: []string{"/usr/local/Cellar/terraform/0.11.10/bin/terraform", "plan", "-var-file=/Users/<REDACTED>/code/smar/terraform_premium/live/staging/terraform.tfvars", "-var-file=/Users/<REDACTED>/code/smar/terraform_premium/live/staging/../common.tfvars"}
2018/12/03 07:40:15 [DEBUG] Attempting to open CLI config file: /Users/<REDACTED>/.terraformrc
2018/12/03 07:40:15 [DEBUG] File doesn't exist, but doesn't need to. Ignoring.
2018/12/03 07:40:15 [INFO] CLI command args: []string{"plan", "-var-file=/Users/<REDACTED>/code/smar/terraform_premium/live/staging/terraform.tfvars", "-var-file=/Users/<REDACTED>/code/smar/terraform_premium/live/staging/../common.tfvars"}
2018/12/03 07:40:15 [INFO] Building AWS region structure
2018/12/03 07:40:15 [INFO] Building AWS auth structure
2018/12/03 07:40:15 [INFO] Setting AWS metadata API timeout to 100ms
2018/12/03 07:40:15 [INFO] Ignoring AWS metadata API endpoint at default location as it doesn't return any instance-id
2018/12/03 07:40:21 [DEBUG] plugin: waiting for all plugin processes to complete...
Failed to load backend:
Error configuring the backend "s3": No valid credential sources found for AWS Provider.
	Please see https://terraform.io/docs/providers/aws/index.html for more information on
	providing credentials for the AWS Provider

Please update the configuration in your Terraform files to fix this error.
If you'd like to update the configuration interactively without storing
the values in your configuration, run "terraform init".

However... I can use the same assumed role profile with terraform directly (or aws cli as show above) without issue.

Worth noting, this is what my AWS config profile looks like:
[profile aws.premium.staging]
region = us-west-2
role_arn = arn:aws:iam::##REDACTED##:role/OrganizationAccountAccessRole
source_profile = master_billing

Any profile that has credentials defined (in ~/.aws/credentials) seems to work just fine.

I have discovered a workaround that may shed some light on the root cause.  If I set the AWS_SDK_LOAD_CONFIG env var to a truthy value it uses the AWS_DEFAULT_PROFILE and standard (i.e. non-golang) AWS config properties.
Here's the interesting piece of the aws-sdk-go project that utilizes that var:
https://github.com/aws/aws-sdk-go/blob/master/aws/session/env_config.go#L162
Not sure why this is a problem with terragrunt but I can execute terraform code just fine.  Perhaps the version of the aws-go-sdk in terragrunt is out of date?

Just forked terragrunt, updated the aws-go-sdk to the latest version, did a go build and am still seeing this error when running with that custom built bin.  This is likely a problem with how the terragrunt remote package is handling assumed roles?
Another workaround is to use the --terragrunt-iam-role CLI option, TERRAGRUNT_IAM_ROLE env var, or the iam_role= option in the terragrunt{} section of the terragrunt.tfvars file and using that to assume the desired role instead of using an assumed role profile works as desired.

Might have to do with how we configure the profile to use here, which is read from the backend config, but does not seem to take env vars into account.

@JoshiiSinfield I'm running into the same exact issue.  Thanks for your post/comment.  Did you ever find a workaround?

Hi @jonathanhle,
Not for terragrunt to perform the assume_role no. I was hoping to dive deep into the code but just not had chance.
instead we use a providers.tf with the terraform provider resources as was the pattern before terragrunt was able to assume role.
I do plan on having a go at working it out. I need to up my go skills first though!
Cheers,
Josh

@JoshiiSinfield
I'm seeing the same failure mode.
@jonathanhle
Here is what I've done to work around this.
I was previously using a static provider.tf file with aliases to manage this.
To make this more dynamic I added the following in a provider.tf file in each of my module
provider "aws" {
  alias  = "alias1"
  region = "${var.a_region}"

  assume_role {
    role_arn = "${var.assume_role_arn}:role/OrganizationAccountAccessRole"
  }
}

To each vars.tf
variable "assume_role_arn" {
  description = "Role ARN used to assume the account."
}
variable "a_region" {
  description = "Region fight should be placed in"
}

I can then pass in the correct Role ARN to utilize via any of the methods Terraform provides (.tfvars, CLI, Env Variables).

Hi @brikis98
Did you get a chance to review this at all?
Unfortunately I've not had chance to dive in and try to fix it yet. I'm keen to hear any ideas/comments you have before I do.
Cheers,
Josh

@JoshiiSinfield Other than what I wrote in https://github.com/gruntwork-io/terragrunt/issues/616#issuecomment-444185765, no, I haven't had a chance to dig in deeper


Issue: Progress Bar Not Filling

Hello,
When I launch the docker, all processes seem to run correctly, and I can access the streams properly. However, I notice that the progress bar for drops is not filling.
Do you have a solution to suggest?
Best regards,

Is good thank you


[SPARK-45562][SQL] XML: Add SQL error class for missing rowTag option

What changes were proposed in this pull request?
rowTag option is required for reading XML files. This PR adds a SQL error class for missing rowTag option.
Why are the changes needed?
rowTag option is required for reading XML files. This PR adds a SQL error class for missing rowTag option.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Updated the unit test to check for error message.
Was this patch authored or co-authored using generative AI tooling?
No

Lemme merge first but please let me know if there's anything that doesn't look making sense to you.

Merged to master.

BTW, let's don't forget to add [FOLLOW-UP] tag


Add ReqResp codec tests for cborg codecs

This has been implemented; they are included in typed-protocols-cbor package.


List style documentation

General Support Request

We need documentation for list styles to align between code and design.
Possible Solution

Create documentation in Figma for designers to see.

[x] All list styles made as components
[x] Redlined list styles

Context

There will be discrepancies between the Figma bullets (default bulleting feature) and the actual bullet we support. This documentation aims to inform designers about what it will look like in implementation.

List documentation link: https://www.figma.com/file/j91JPGmxjH88rMnmi7HG9s/list-styles?node-id=5746%3A16389&t=ZrXVtfGXvMaHKgvn-4


Is this still maintained?

Although I plan to maintain this repository as much as possible, to be honest, I might not be able to invest significantly in it.

That's unfortunate. Cool repo tho, i'm to make HLS support working with ffmpeg.


Change the way code is generated

Currently text/template is used for code generation.
The way template looks like: https://github.com/colegion/goal/blob/master/tools/generate/handlers/handlers.go.template
So, it's quite complex, we had to introduce \ to get rid of newlines and special meaning of :\t sequence for formatting our code in a readable form.
Now I lean toward an approach that is used by Go's stringer tool: https://github.com/golang/tools/blob/master/cmd/stringer/stringer.go#L560-L570. It's a set of consts and fmt.Sprintf.
Looks simpler to me. Though, I'm not sure. Probably we should introduce some kind of package for code generation?
Requirements are ease of use, ability to cover code by tests, probably type safety of the whole code generation stuff. Currently, template can be executed, rendered, and all but still output an incorrect go file. Is it possible to fix this?

Go's stringer tool does look simple.

\ and :\t for formatting have been removed. Now the output is passed to (go/fomat).Source instead. As a result the template has become a bit more cumbersome and ugly (as opposed to what I expected). But after template functions are introduced instead of a shitload of variables this must be improved. Maybe, we even won't need refactoring with fmt.Sprintf.


win32: Use Wide API in vim_getenv() in misc1.c

Currently, vim_getenv() cannot handle Unicode characters on Windows. E.g.:
:let $a='Ā'
:echo $a
?

This patch makes it possible by using Wide API:
:let $a='Ā'
:echo $a
Ā

Looks good. Possibly this can be tested?

Codecov Report

Merging #4008 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4008      +/-   ##
==========================================
+ Coverage   79.13%   79.15%   +0.01%
==========================================
  Files         105      105
  Lines      141111   141112       +1
==========================================
+ Hits       111669   111693      +24
+ Misses      29442    29419      -23

Impacted Files
Coverage Δ

src/misc1.c
78.92% <100%> (ø)
:arrow_up:

src/if_xcmdsrv.c
83.48% <0%> (-0.72%)
:arrow_down:

src/ex_cmds2.c
84.89% <0%> (-0.1%)
:arrow_down:

src/message.c
76.65% <0%> (+0.04%)
:arrow_up:

src/window.c
83.59% <0%> (+0.06%)
:arrow_up:

src/ui.c
50.22% <0%> (+0.07%)
:arrow_up:

src/channel.c
83.16% <0%> (+0.07%)
:arrow_up:

src/terminal.c
78.29% <0%> (+0.08%)
:arrow_up:

src/gui.c
58.25% <0%> (+0.36%)
:arrow_up:

src/gui_gtk_x11.c
48.96% <0%> (+0.68%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbd854d...f216fa5. Read the comment docs.


Please invite me to the Community Organization

Name
Ibukun
Discord Username (if applicable) E.g John#412
Highbeek
Questions & suggestions?
No response

Welcome to the community @Highbeek 🙌🏾🙂


Update clinical assays

In this PR I'm trying to coordinate recently added clinical assays for TURBO with a use case from the National Toxicology Program (NTP). I've tried to break my changes into distinct steps for easy review:

lowercase 'lipid' in the labels for four 'lipid panel reflex direct venous blood ...' assays
normalize the use of single-quotation marks in assay.tsv (no change to ontology content)
add 'count' to the label of 68 cytometry assays: @cstoeckert says that these assays specifically result in absolute counts of cells, and the textual definitions all say "measures the count of X". However NTP needs similar cytometry assays that don't result in counts, but percentages or maybe relative abundance. So the labels of these 79 are too general, and adding 'count' to the label fixes this problem (I think).
fix textual definitions of 11 hematocrit assays: they said "measures the count of hematocrit", but now they say "measures the proportion of red blood cells"
change 14 'count assays' to be subclass not equivalent: This is needed to distinguish them from more general "abundance" assays that I want to add. Most of them were already subclass.

... more to come.

@cstoeckert Are you OK with the work so far, especially step 3?

Thanks @cstoeckert. I implemented that change to 11 hematocrit assays and updated the PR description.
Now I'll work on adding some new terms.

@cstoeckert I edited the PR description again with more details. Can you please open src/ontology/obi-edit.owl in Protege, run HermiT, and take a look at these new terms in the inferred class view? I think they're straightforward groupings, but if you have any concerns just let me know. Thanks!

Arg, I didn't actually submit my changes to the PR description until just now. Sorry.

Good points @cstoeckert. I made those changes. Thanks, I really appreciate your help.
Now I'll turn off "Draft" mode, and plan to discuss this PR on Monday's call (briefly, I hope).


QAF BDD plugin for IntelliJ

I need the QAF BDD plugin for IntelliJ but I can find it only for eclipse.
Does this plugin exist also for IntelliJ?
Thanks,
Eyal Yovel

For BDD syntax currently, there is no any plugin available for IntelliJ.
As an alternative, I think you can use Cucumber Plugin for IntelliJ and use GherkinTestFactory provided by QAF.

Hi Amit,
Thanks for the help. We are using Gherkin Test Factory, but when we use the @QAFTestStep annotation for our step definitions then the cucumber plugin fails to recognize the implemented steps.
Do you think this is the expected behavior of Cucumber plugin with our @QAFTestStep annotation?
Thanks,
Kulin

@kulin24,
IntelliJ Cucumber plugin can not find @QAFTestStep annotations, it can find only cucumber-java annotations, this is expected behavior.
To resolve this there is only one option that you can build your custom plugin from cucumber-java plugin with required some minor changes. ;-)

Thanks for your inputs. :)

Any plan on creating plugin for Intellij as it will be helpful?
Also could you please share any resource to customize the cucumber- java plugin.

A plugin for Intellij would be greatly appreciated

Any help in getting the cucumber-java plugin to work with QAF?

Alternate is to use BDD2 with QAF-cucumber and cucumber plugin for IDE of your choice. BDD2 is supported by TestNG runner using BDDTestFactory2 and by cucumber runner using QAF-cucumber. When using  QAF-cucumber you can use cucumber step implementation.


Special handling for HP and other fields

Some cards have a variable HP, displayed as "*". Right now the "HP" property is a number, which doesn't allow for these special cases.

One option is to say that if HP is negative, show "*" and use the absolute value for the HP field. In digital this is represented like this:
      "hitpoints": 12,
      "hitpointsText": "*"

and in Card Creator it's just
[[hp]] *
[[text]] [=*] on this card = [H] times 3.\nThe first time /Unmute/ would be dealt damage each turn, redirect it to this card.\nThe first time this card is dealt damage by each other target each turn, it deals the source of that damage 3 melee damage.


Fix channel not found in scan spec when the row_index column exists

Fixes: #10855

Hello @Yuhta ,
Could you help to take a look this? I'm not sure the reason we exclude the row_index column from scan spec, but this behavior would cause issues, if row_index is not the last column. For details, pelase check https://github.com/facebookincubator/velox/issues/10855 .
Thanks.

@Yuhta , could you help to take a look again? Thanks.

Kindly ping, @Yuhta , thanks.


Feature Request for Embed Mode: include xml in load event

If a document is loaded with the load action, it would very useful if the actually loaded xml document is included in the load event. This is particularly practical when loading a png or svg file.
This is the current behavior:
vscode -> drawio: { action: "load", xml: "<mxfile host="localhost" modified="2020-05-14T16:04:47.043Z" agent="5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.45.0 Chrome/78.0.3904.130 Electron/7.2.4 Safari/537.36" version="13.0.9" etag="hUiw05cRziyfAYYzymtF">
    <diagram id="Wvb0a2wADpB9Kn_nfm9h">
        ddHNEoIgEADgp+GuMFmdzfLSyUNnRjZhBl0GabSePh0kY6wLs3y7sPwQlrfjxXIjryhAE5qIkbAToTRLsmmc4elhF6CxSnhKV6jUCxZMFn0oAX1U6BC1UybGGrsOahcZtxaHuOyOOu5qeAMbqGqut3pTwkmvB7pfvQTVyNA5zY4+0/JQvNykl1zg8EWsICy3iM5H7ZiDnt8uvItfd/6T/RzMQud+LJiCde9pEn0QK94=
    </diagram>
</mxfile>", autosave: 1, actionId: "1" }
vscode <- drawio: { event: "load", pageVisible: true, translate: { x: 606, y: 468 }, bounds: { x: 606, y: 468, width: 0, height: 0 }, currentPage: 0, scale: 1, page: { x: 606, y: 468, width: 827, height: 1169 } }

As you can see, the input xml is not returned.
I know that I can request the current xml, but if the autosave feature is used, it would be much easier to keep the xml model synchronized if load also reports the current xml.
The autosave feature sends an event that contains the new xml whenever something changes.

What problem case does this fix?

I have to admit, this would solve a rather special problem case.
In my Draw.io extension for VS Code, I maintain a synchronized drawio xml document.
For requesting an xml document, there is a getXml method.
This method has to account for the possibility of being accessed directly after loading a new drawio document, but before autosave has been fired.
In this case, I have to export the xml manually. However, in the meantime, autosave could have been triggered by user interaction, leading to possible race conditions.
It is unclear whether the requested export has priority over autosave, if the export has been issued before. It is very clear that an autosave cannot happen before the load request has been answered.
If load would return the loaded xml document, maintaining a synchronized xml document would be a bug free no-brainer. If autosave is understood as a way of synchronization and load accepts various input formats (*), it makes only sense that load triggers the initial synchronization.
(*) this is why I cannot/don't want just use the input file as the first version of the internal xml document: It might not even be xml.
If this is too complex to implement or if you do think this might lead to feature bloat, I can understand and live with that. However, I think it works well together with how autosave works.


Suggestion: Eliminate "O2" from "Toggle internals" alert

Description
Eliminate "O2" from "Toggle internals" alert. It is not representative of actual gas you are breathing, and if you are slimeperson, you don't even want to breathe O2. Minor issue.
Screenshots
Slimeperson breathing nitrogen:

I feel like the O2 generally just helps clarify to players that the tank depicted contains something they breathe. Even if it's not technically accurate in every single way, it helps convey the message.


fix(watch): should not leak this.proxy to setup()

Fix https://github.com/vuejs/vue-next/pull/2753#issuecomment-819595259

Simpler fix in 1526f94e - thanks for the test case!


Manually set priority of emote tab-completion

Basically in some chats I end up tab-completing to the wrong emote because they have an emote enabled that takes alphabetical priority. For example, "OMEGALAUGHING" takes priority over "OMEGALUL". It would be nice if we had a way to set manually set the priority of emotes in order to avoid this.

This issue is out of scope of the Chatterino project.


feature Enable write into cache when uploading file to s3 using s3 file writer

Proposed changes
Issue Number: close #xxx
This pull request introduces significant enhancements to Apache Doris, specifically focusing on the S3 file writer and S3 file buffer pool, as outlined in issue #23953. In essence, it empowers the ability to efficiently store data in a file cache during the process of uploading data to S3 using the S3 file writer.
Notably, this PR provides users with the flexibility to control whether this caching process occurs synchronously or asynchronously through the configuration parameter enable_flush_file_cache_async. Also user can control whether writing into file cache or not using enable_file_cache config in BE.
Additionally, this PR includes improvements to the FileCache system in advance of the BlockCache merge, such as proactively modifying the cache type in preparation for the BlockCache merge, ensuring seamless compatibility and optimal functionality for the S3 file writer.


The texture looks like triangles DISTINCTLY

After I connect the Solidify Colors nodes, I run the Block-On, but some textures look like big triangles distinctly.
Is this a sampling problem?
This occurs on large mesh with small image texture.

Right now the node network is only sampling one color per triangle face in the original mesh for this  mode. At some point in the future I plan on having it sample the nearest fragment so you don't get these triangles; I just haven't had time to update this project in awhile.
For now you might be able to work around this by subdividing the original mesh, which will create more triangles for the add-on to sample from.


Queue worker - rabbitmq consumer and publish data to API endpoint

Q
A

Bug fix?
no

New feature?
yes

Tests pass?
not present

Fixed issues
#7

Added rabbitmq consumer code,
pushesh request data to API endpoint
TODO: need to modify API endpoint

Todo:1. confirm API endpoint to call to nodejs server (To be decided IP and port)
2. We will be using the following date format throughout the system DD-MM-YYYY format.

I'll update the readme with the message format the consumer is expecting from rabbitmq queue
TODO: update readme

TODO: document queue name in rabbitmq, connection config


Update settings to center window when changing resolution

Right now it leaves the center the same, so when I change it to 1080p, part of the window is off screen.
This update fixes it so the window will be centered on the screen.

i didn't expect anyone at all would contribute to this template, but sure


Disable RVIZ visualization

Hi, could help please help me with disabling RVIZ visualization? I am running ROS in a docker container where it keeps crashing because of RVIZ.

In launch file, please annotate rviz node.

You can just remove rviz from the launch file.


Fix test cases for examples

This PR updates the test case to use for v1.21

Thanks @tengqm .
/lgtm


Mimecast TTP

This is a draft PR to run the validation checks for Mimecast TTP.

Thanks @nipun-crestdatasystem for raising this PR, we will review by 30 Aug 2023

Hi @nipun-crestdatasystem, the folders inside Data connector folder are incorrectly placed, please make following changes : -

Move Parsers folder to \Solutions\MimecastTTP\

Remove the logo folder and move the logo to https://github.com/Azure/Azure-Sentinel/tree/master/Logos
(you would also need to change the path of the logo in the Solutions/MimecastTTP/Data/Solution_MimecastTTP.json file)

Also apart from the above mentioned changes, please make the following changes :
Please do add release notes, please follow this link -https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md
Please add workbook metadata here - https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V2/WorkbookMetadata/WorkbooksMetadata.json
After all these changes, repackage the solution.

@v-rbajaj thanks for the review we are working on the changes and we will get back to you as soon as possible.

Hi @nipun-crestdatasystem, please resolve merge conflicts and update this branch from master.

Hi @nipun-crestdatasystem, please resolve merge conflicts and will validate changes by 15 Sep 2023.


Documentation site no longer works

Go to this site:
https://optum.github.io/giraffle/#/
The Get Started control is disabled so you can't access the documentation.

I found the issue and redeployed the documentation site.


Why Infer doesn’t find error with LOCK_CONSISTENCY_VIOLATION?

Please make sure your issue is not addressed in the FAQ.
Please include the following information:

[v0.17.0 ] The version of infer from infer --version.
[ubuntu14.04 ] Your operating system and version, for example "Debian 9", "MacOS High Sierra", whether you are using Docker, etc.
[infer -- gcc ] Which command you ran, for example infer -- make.
[ ] The full output in a paste, for instance a gist.
[ok ] If possible, a minimal example to reproduce your problem (for instance, some code where
infer reports incorrectly, together with the way you run infer to reproduce the incorrect
report).

infer version : v0.17.0
OS : ubuntu 14.04
I used command : infer -- gcc -c testcode.c -lpthread
testcode.c is test code including LOCK_CONSISTENCY_VIOLATION error.
but, Infer not found this. ( No issue found )
Why Infer doesn’t find this error?
also, I found infer option " --report-custom-error --developer-mode ".
It can find incorrect Mutex usage.
Where can I find options that aren't in the doc?
Smart guys, please help me.
/*

Copyright (c) Facebook, Inc. and its affiliates.

This source code is licensed under the MIT license found in the
LICENSE file in the root directory of this source tree.
*/

#include <pthread.h>
#include <stdio.h>
#include <unistd.h>
#include <stdlib.h>
pthread_mutex_t mutex_lock;
int g_count = 0;
void t_function(void data)
{
int i;
char thread_name = (char)data;
// critical section
g_count = 0;
for (i = 0; i < 5; i++)
{
printf("%s COUNT %d\n", thread_name, g_count);
g_count++;
sleep(1);
}
}
int main()
{
pthread_t p_thread1, p_thread2;
int status;
pthread_create(&p_thread1, NULL, t_function, (void *)"Thread1");
pthread_create(&p_thread2, NULL, t_function, (void *)"Thread2");
pthread_join(p_thread1, (void *)&status);
pthread_join(p_thread2, (void *)&status);
}

Infer does not report races on plain C code, only on C++/Obj/Java. Infer also does not recognise pthread_mutex lock operations.

Dear ngorogiannis,
Thank you for your prompt reply.
It helped me a lot.
If you don't mind can I get some more advice with this brilliant tool ?
I have encountered lots of problems regarding misuse of MUTEX_LOCK (which results in race conditions).
So I really would like to detect potential errornous statements in advance before running at real situations.
Below are my questions (or naive ideas ) ...

1.Are there any plan to make 'infer' smarter by adding feature like recognizing 'pthread_mutex lock'
( Because I really need this for the moment and pthread_mutex is so common in POSIX based OS like Linux ).
I'm just wondering if there is any specific reason for not supporting this . It would be very helpful and thankful to support this feature, I think.
2.Is it possible or are there any plans for 'infer' command-line option to provide some efficient way to train additional tokens which could be defined by user (programmer) or some standards ?
( Tokens might be user-defined or C++ STL funtions like std::vector::iterator type and shared variable which is defined as that type )
Actually I got to think about above idea as Ocaml is an language for AI applications, I heard..
They are just naive ideas but it would be appreciated if I could have your thoughtful opinion or answers .
I look forward to hearing from you.
Best regards,

Infer does not have a general data race checker.  What it focuses on is classes and their methods that may be called concurrently -- this reduces the search space a lot.  pthread_mutexes in plain C code make this a lot harder, and since the code we check does not primarily use these features, such support is not planned.  We are always open to pull requests :)

I don't understand what you mean by tokens.

I want to thank you for taking the time out of your busy schedule.
Thank you very much!

@junhyung-lee38 Have you heard about clang's Thread Safety Analysis? It isn't perfect, but it can do a lot and it's a compiler warning, i.e. it's fast. As far as I know, clang already ships C++ standard library with thread safety annotations. I believe you can push libpthreads developers to annotate their headers as well (if they haven't done that already).

Dear @ngorogiannis,
Regarding 'Tokens', I assume that Tokens are some kinds of 'Data Types' or 'Identifiers'.
As far as I know, 'Tokens' ( or 'lexeme') are used for Lexical analysis stage and 'Data Types' or 'Idendifiers' are commonly used for Syntax Analysis stage in compiler.


First pass

Motivation and Context

What has changed

How to test?

Links

/deploy manna

/deploy manna

/deploy manna


Want any of these as pull requests?

Hey, I've been having a great time building on your config and making it my own. I've made a good number of changes (many extracted from Spacemacs), and I was wondering if you'd like me to create pull requests for any of the following:

Evil MC - I liked evil multiedit, but it's nice being able to arbitrarily place cursors. I saw your note about evil-mc not working, but I was able to integrate it just fine
Neotree - Automatically hide tree on enter file
Neotree - better evil keybindings (h - up tree/collapse, j - down, k - up, l - enter file / expand dir)
Gist.el - create gists from region or buffer
Large File - Prompt to open large file (size threshold configurable) in read-only fundamental mode for massive perf improvement
restclient mode - Super awesome amazing tool for creating rest requests
better interactive copy / rename / delete (current and other) file functions
winum mode - quick select window by number
auto indent on paste
jump most recent buffer

I figured I'd just create an issue and see if you were interested in any of these changes before I started creating pull requests. I'll submit bug PR's right away, but I realize many of these are more personal preference. Thanks again for this ... your configs and themes are killer

That's a fantastic list, thank you for the offer! I'd appreciate a PR for:

evil-mc: I tried evil-mc a long time ago, so I wouldn't be surprised if it'd work now, and I look forward to finally having a proper multiple-cursor implementation in Emacs!
Large File
Neotree - better evil keybindings

A few fyi's about other items on your list:

winum-mode: I have something similar in place already (avy) via M-x ace-window (bound to C-w C-w by in my bindings).

restclient-mode: I already have this in modules/lang/rest; a fantastic tool! I use it in combination with org-babel to test (and annotate) REST requests and test APIs.

auto indent on paste: I was tempted, but decided against it because not all major modes have good [enough] indentation functions (like yaml-mode, or python-mode/sh-mode in some cases) for me to trust to automation.
Also: In case you didn't know, I have a +evil/reselect-paste command bound to gp that makes it much easier to reindent pasted blocks manually (e.g. pgp=).

gist.el: I intend to add webpaste.el to my config soon, which provides access to several pastebin services, including gists. I'll write ex commands for it too.

Anyhow, thank you for the kind words and good work!

Cool, I'll create those pull requests soon!
I totally missed the fact that you had restclient in already in the config. I tried to pull over all the things I wanted to keep piecemeal, but I'm still finding new (and awesome) things as I continue to mine through the config. Also, I think I'll actually be removing winum-mode, ace-window is actually a much better solution. Thanks for pointing that out.
It's been fun learning elisp as I go along, I think my favorite find so far is advice-add, I fully expect to do both great and terrible things with this in the future.


Use keyboard to position windows in fancy zones.

📝 Provide a description of the new feature
I don't want Either Windows keyboard positioning OR FancyZones keyboard positioning. I want BOTH at the same time!
For Windows you can use +Arrow keys to position windows and even move them between screens. This functionality can be replaced by FancyZones window positioning. But then I lose the windows version! I would like to be able to do both these at the same time! Perhaps this means we need an option in PowerTools FancyZones to assign a different key-cut to move the other way, or perhaps it means the features should be complementary. Reason for this ask is that I position full screen windows with the Windows functionality and then I also want to position in my FancyZones - not either or.

If you'd like to see this feature implemented, add a 👍 reaction to this post.

@noopman
this is already possible, please read the documentation https://docs.microsoft.com/en-us/windows/powertoys/fancyzones

@noopman
this is already possible, please read the documentation https://docs.microsoft.com/en-us/windows/powertoys/fancyzones

I have updated this request. I did not mean to be vague. Sorry. I do realize you can override the Windows behaviour with the FancyZones placements. I want BOTH at the same time because I use both! Can this suggestion be reopened or do I need to create a new-new issue?

I have updated this request. I did not mean to be vague. Sorry. I do realize you can override the Windows behaviour with the FancyZones placements. I want BOTH at the same time because I use both! Can this suggestion be reopened or do I need to create a new-new issue?

@noopman
there is already an issue for that https://github.com/microsoft/PowerToys/issues/4795

@noopman
there is already an issue for that https://github.com/microsoft/PowerToys/issues/4795


Specifying secret.pgbackrest does not override underlying pgbackrest properties

What happened?
This is what the final pgbackrest configmap render looks like:
data:
  pgbackrest.conf: |
    [global]
    compress-level=3
    compress-type=lz4
    process-max=4
    repo1-cipher-type=none
    repo1-path=/my/path/
    repo1-retention-diff=2
    repo1-retention-full=2
    repo1-s3-endpoint=s3.amazonaws.com
    repo1-s3-region=us-east-2  # This should be us-west-2
    repo1-type=s3
    spool-path=/var/run/postgresql
    start-fast=y
    [poddb]
    pg1-port=5432
    pg1-host-user=postgres
    pg1-path=/var/lib/postgresql/data
    pg1-socket-path=/var/run/postgresql
    link-all=y
    [global:archive-push]
    [global:archive-get]

Did you expect to see something different?
I expected the region to be us-west-2
How to reproduce it (as minimally and precisely as possible):
See values below and deploy the chart
Environment
dev

Which helm chart and what version are you using?

0.22.0

What is in your values.yaml ?

timescaledb-single:

  podAnnotations:
    iam.amazonaws.com/role: "arn:aws:iam::my.role"

  secrets:
    pgbackrest:
      PGBACKREST_REPO1_S3_REGION: "us-west-2"
      PGBACKREST_REPO1_S3_BUCKET: "arn-my-bucket"

Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.15", GitCommit:"58178e7f7aab455bc8de88d3bdd314b64141e7ee", GitTreeState:"clean", BuildDate:"2021-09-15T19:23:02Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.15", GitCommit:"58178e7f7aab455bc8de88d3bdd314b64141e7ee", GitTreeState:"clean", BuildDate:"2021-09-15T19:18:00Z", GoVersion:"go1.15.15", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:
helm + concourse + argo

Anything else we need to know?:
Probably a pgbackrest issue, but specifying an IAM role with access to S3 bucket doesn't work as pgbackrest still forces me to specify a secret key and access key 🤷

if you add repo1-s3-key-type=auto it will use role from service account. That worked for me.

Yes I forgot to mention but I had both the secret and the pgbackRest properties so they were conflicting with each other. Specifying repo1-s3-key-type=auto does indeed work as expected.


During a DBT run, dropping a view will also drop dependent views that haven't been recreated.

Describe the bug
When there are views in the DAGs e.g. (view_root -> view_middle -> view_leaf)
A dbt run causes problems because:

when view_root completes, it'll drop all its dependent views, i.e. view_middle and view_leaf in this case.
view_middle and view_leaf will not be re-created until they're run.
This is a problem because view_root might run very early in a run while view_middle and view_leaf run hours later and causes these views to not be available.

Our BI tools relying on view_middle and view_leaf are broken while dbt is running.

Steps To Reproduce
Created a sample dbt project to reproduce: https://github.com/nickwu241/dbt_reproduce_drop_view_cascade_bug
It will

create a postgres docker locally
create a dbt DAG of view_root -> view_middle -> view_leaf
has post-hook wih SELECT * FROM pg_sleep(10)

so that you can see view_middle and view_leaf are unavailable after view_root runs.
feel free to adjust 10 to be 30 if you need more time to see the database

Expected behavior
I expect dbt to not drop the dependent views until the whole run has finished.
- I expect DROP view_root_backup CASCADE; won't happen until all dependent views are re-created.
Screenshots and log output
dbt run --profiles-dir .
Running with dbt=0.15.2
Found 3 models, 0 tests, 0 snapshots, 0 analyses, 125 macros, 1 operation, 0 seed files, 1 source

09:57:30 |
09:57:30 | Running 1 on-run-start hook
09:57:30 | 1 of 1 START hook: dbt_reproduce_drop_view_cascade_bug.on-run-star... [RUN]
09:57:30 | 1 of 1 OK hook: dbt_reproduce_drop_view_cascade_bug.on-run-start.0... [CREATE TABLE in 0.00s]
09:57:30 |
09:57:30 | Concurrency: 1 threads (target='dev')
09:57:30 |
09:57:30 | 1 of 3 START view model public.view_root............................. [RUN]
09:57:41 | 1 of 3 OK created view model public.view_root........................ [CREATE VIEW in 10.14s] <<<<<<<<<<< view_middle and view_leaf will be dropped here
09:57:41 | 2 of 3 START view model public.view_middle........................... [RUN]
09:57:51 | 2 of 3 OK created view model public.view_middle...................... [CREATE VIEW in 10.08s]
09:57:51 | 3 of 3 START view model public.view_leaf............................. [RUN]
09:58:02 | 3 of 3 OK created view model public.view_leaf........................ [CREATE VIEW in 10.06s]
09:58:02 |
09:58:02 | Finished running 3 view models, 1 hook in 31.74s.

Completed successfully

Done. PASS=3 WARN=0 ERROR=0 SKIP=0 TOTAL=3

System information
Which database are you using dbt with?

[x] postgres
[ ] redshift
[ ] bigquery
[ ] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
installed version: 0.15.2
   latest version: 0.15.2

Up to date!

The operating system you're using:
macOS Mojave 10.14.6
The output of python --version:
Python 3.7.3
Additional context
Let me know if you require more information or have any questions! You can reach me on the DBT slack as Nick Wu as well.
Thank you!

hey @nickwu241 - this is a good question! There isn't any mechanism in Postgres to define a view as "late bound" or "unbound" or anything like that. dbt unfortunately must drop cascade the root tables, resulting in downstream views being dropped during the run. Here are some examples of how this is addressed on modern data warehouses:

Redshift has "late bound views" which do not need to be cascade-dropped when their parent tables are dropped
Snowflake views are late-bound
BigQuery views are late-bound

My recommendation would be to either:

create your Bi-focused models as tables instead of views so they aren't dropped during a run
consider building your dbt project in a separate schema (say, analytics_new), then swap the analytics schema for the analytics_new schema at the end of the run (this is called a blue/green deployment)
consider (and I know, this is a heavy answer to your question) using an analytical database instead of Postgres - Snowflake, BigQuery, and Redshift are all great choices, and they come equipped with tools for analytics-minded applications like late-bound views (amongst others!)

Closing this as I don't anticipate making any changes to dbt to support this use-case on Postgres, but I do want to validate that the issue you're seeing is real, it's just not one that Postgres makes particularly easy for dbt to support today.

@drewbanin Thank you for the detailed response and also with the recommendations, I appreciate it very much!
We are actually currently using Redshift for analytics but I produced the issue in Postgres because it's easier to reproduce with docker.
So for the short term I'll use bind: False for those views. And we'll definitely also consider the 2 other recommendations of

blue-green deploy with schemas
changing BI tools to depend on tables

Thanks again!


Hide localtime for Expensify Emails (Automated Accounts)

@pecanoro Can you please review?
Details
Added the expensify emails block from expensify-common and hid the localtime when participants are automated accounts.
Fixed Issues

$ #4664
Tests

Tested the chats with regular users to confirm localtime shows
Tested the chats with automated accounts to confirm localtime doesn't show
Tested group participants with 0 or more Expensify email accounts.

QA Steps

Go to chat with any system accounts - concierge, chronos, receipts, qa, bills, etc.
It shouldn't show localtime for the system accounts

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-08.  :confetti_ball:


Maleghast Sheet Update New Feature

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[x] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[x] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: < https://tombloom.itch.io/magnagothica-maleghast  >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Character Sheet Info Roll20 Internal Use only.


Add basic layout and styling

Setup initial project settings
Background component
Logic component for questions & answers.
Basic json file for q&a
Mui setup, converted HTML to components.
Main page categories
Add basic routing to questionary & categories using react-router-dom.
Configure linters, formatters, ignore files etc.
Tested branch protection rules - it works!

TODO:

create a Mui reset theme.
create context for theme & mui components.

Comments didn't go through, added major changes.


Test secure keys for binstar and Amazon s3

Apparently secure key do not work on forked repos so I clone also the choderalab/opentis and test it here.

IT WORKS!!!! So cool...
Actually the conda package already assumes that the project is called openpathsampling, so I assume we need to rename this. But the documentation is online! Still VERY simple, but it's coming...
http://openpathsampling.s3-website-us-east-1.amazonaws.com/html/

Looking good!

I'm going to merge this so that I can start a PR to tweak things to work with http://openpathsampling.org


SQLite persistence and indexation for lemmatisation

Grep begins to be long after 1000 books. For stats on a Query, it could be faster to have an index. SQLite is probably the right choice, usable with different language

Now solved with Lucene persistence.


Make it easier to polyfill built-in extensions

This PR adds separate interfaces for constructors, similarly to how lib.es*.d.ts define ECMAScript built-ins.
This ensures that downstream typings can extend built-in constructor with static methods when polyfilling new and/or unstable features.
This was not possible with inline type declarations, because TypeScript does not allow variable declaration merging, but it is possible with a separate interface because you can declare them with the same name downstream, and it will get merged into the base type.

This idea has been rejected because it would generate too many new global names and thus would cause more global pollution.

@saschanaz Well it aligns better with built-in ECMAScript APIs, and not doing this is causing real problems (unability to polyfill static methods).
For example, right now I'm blocked on this (or any alternative solution) to be able to define types for js-types proposal of WebAssembly that adds static type() to a bunch of built-ins, and there's no workaround that I know of, and I'm sure this is not the only API that is running into similar issues.

If the concern is specifically the global namespace, we could put all these declarations into some sort of artificial module e.g.
declare module 'dom-constructors' {
  interface AbortController { ... }
  ...
}

var AbortController: import('dom-constructors').AbortController;

For the reference: https://github.com/microsoft/TSJS-lib-generator/issues/222#issuecomment-566652324 seems like even a better option, and would also allow extending built-ins.


Update Fixed Number Allocations in Botswana

Please update the fixed allocation numbers for Gaborone area, Botswana to include
the following number range.
Number Range: 311 XXXX
Example Phone Number: 311 1000
Area: Gaborone Area
Country Calling Code: +267
Country: Botswana
Reference Link: https://en.wikipedia.org/wiki/Telephone_numbers_in_Botswana

Hi,
Thanks for providing all the details we need! We've accepted this issue and will fix this in an upcoming release.
Please note that you have submitted this information with the knowledge that we may use, modify, reproduce, publicly display, and distribute the information in accordance with our open source policies. Please let us know if you did not intend to submit the information for such use.

Fixed in release 8.3.3.


openBMC sensors Test

Place holder for automation for

[x] Soft sensors/non sensors
[x] Real sensors

This is done.


Correct spelling error and internationalize

East Oceania presumably spells 'radicalize' with an 's', so we can allow our British compatriots to be appropriately good.
Both East and West Oceania spell 'surveillance' with two 'L's, though.  Unless they spell it 'intelligent video analytics', but that's another ball of wax.

On behalf of The Inner Party, I thank your contribution. May we reign victorious over our enemies who seek to destroy our way of life.


How to handle insecure registries

Hi ,
while trying to analyze image in private registry using clairctl  I am getting this error. http: server gave HTTP response to HTTPS client.
I tried adding insecure registry in config.yml too but it does not help.
Can you please help me with this.

have same issue, please help


Fix confusing language filter on the module page

This PR addresses Issue #95
The current language filter on the modules page is confusing. Assuming the locale is set to English, It is currently formatted as follows:

This is problematic for two reasons:

It uses the two letter locale–en in this case–to indicate the language.
When English is set as the language, it doesn't make sense to have the second option.

This PR changes the filter as follows:
It uses the full language name in place of the two letter locale.

It removes the second option when the user has selected English as their preferred language.

Out of scope of this PR:

Translation of the full option sentences in the filter. Only the translated language name has replaced the two letter locale.
Implementing the actual filter functionality.

Thanks! Not only did I not do this on the stream, I forgot to even write it down as an issue. Thanks for grabbing it!
One small modification I'll make is that I don't prefer yoda checking, so I'll reverse the order of your 'en' and 'locale' checks.

Haha, Yoda checking. I didn't know it was called that. I'm not a big fan of it but it seems to have traction within many communities so I tend to use it when contributing. Maybe I will stop doing that.


Add on initial apply callback

Happy to rename if you feel like this should be a different name.
The goal with this is to know when the initial yjs-prosemirror sync has finished so that I can do something else

Thanks, I'll rename this probably to onFirstRender (just a personal preference; feels clearer).


Scala Repo Server: add import from static repo

Have you seen this? #77

Nope. Sorry, I was searching by "import" keyword.


Inline media for topics

From this idea: https://github.com/demcra/demcra/issues/12
Detect when a link is pointing to a video, gif, etc, and when possible, allow the topic to be expanded (in the list) to show that media.
Do we want to allow the submitter to choose the media file and/or image preview?   I think it's better to automate that part, but maybe add a way to fix for when the wrong media is selected.

I was just about to suggest this. Sometimes, an image is not detected, even though one is available from the web page, so you're stuck with the generic link icon. I think you should be able to manually add an image if you want to. This also helps when all of the images from your link are boring, and you want to add something to catch people's attention.


[as2_behaviors_motion] Fix warning about service client access

Basic Info

Info
Please fill out this column

Issue(s) this addresses
#282

ROS2 version tested on
Humble

Aerial platform tested on
-

Description of contribution in a few bullet points

Replace the deprecated explicit access of the service client to the .future.share() one

@RPS98 As we only support humble and above I would merge this.

this is the error @RPS98, can you check it ?


docs: add custom symbol demo

Checklist

[ ] npm test passes
[ ] benchmarks are included
[ ] commit message follows commit guidelines
[ ] documents are updated

Description of change

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.691%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
10556

Relevant Lines:
11801

💛  - Coveralls

@wangxingkang 可以把截图中的 tooltip 去掉吗！

@pearmini 看下是否可以

@wangxingkang 可以的，我周一上传一下！

@wangxingkang
https://mdn.alipayobjects.com/huamei_qa8qxu/afts/img/A*UM2yQKYXczEAAAAAAAAAAAAADmJ7AQ/original

@pearmini 可以了


Error occurs when setting up, could be related to the update of GroundingDINO two days ago

Hi, thanks for your great work! I have been using your model for several weeks on Google Colab. It worked well, and I got good masks. However, I just found today there is an error occurring when running the first cell, installing GroundedDINO:
/content/Grounded-Segment-Anything
Installing build dependencies ... done
Checking if build backend supports build_editable ... done
Getting requirements to build editable ... done
Preparing editable metadata (pyproject.toml) ... done
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 254.7/254.7 kB 4.9 MB/s eta 0:00:00
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.2/2.2 MB 41.9 MB/s eta 0:00:00
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 72.2/72.2 kB 9.9 MB/s eta 0:00:00
error: subprocess-exited-with-error
× Building editable for groundingdino (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> See above for output.
note: This error originates from a subprocess, and is likely not a problem with pip.
Building editable for groundingdino (pyproject.toml) ... error
ERROR: Failed building editable for groundingdino
ERROR: Could not build wheels for groundingdino, which is required to install pyproject.toml-based projects
So, I checked the pyproject.toml of GroundDINO of Grounded-Segment-Anything, and I found that they updated the pyproject.toml two days ago. I think the error could be related to this update, but I am not sure if it's true, and I don't know exactly how to fix it. Maybe can you check if the problem is related to the update or something else? Thanks!

@lanlanyan0817 I updated the project and it runs for me. Could you check again if you still need it?


Japanese localized version of README

Summary

This is the 1st commit of the Japanese localized version of README.
I would like to contribute in this way step by step.
Please review if it is in line with the organizer's expectations.

Issue
https://github.com/JetBrains/resharper-rider-samples/issues/20
Proposal for creating a Japanese localized version
How did I test it?

I have only conducted self-verification using a translation tool.
If you have a reliable Japanese person, I would like to ask for a third-party review.

NOTE

Some parts have been "free/loose translation".
I have filled in the gaps between the lines from a Japanese developer's point of view and translated them into what I consider to be more appropriate expressions.

Have a good life 👍

@sun-flat-yamada you are amazing ❤ Thank you!


[tv2hu] Add new extractor

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests

What is the purpose of your pull request?

[ ] Bug fix
[x] New extractor
[ ] New feature

Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.
New extractor for hungarian TV2 (tv2.hu)

Thanks, Do you want to be credited as one of the authors of youtube-dl? If so under what name?

No, thank you!


new release

last release seems to be several years old:
https://github.com/google/android-classyshark/releases/tag/8.2

Thanks for the bug, we don;t have any new content/fucntionality that requires a new release


Introduction Text

Currently i have made a placeholder for an introduction text that is displayed as the first thing a user sees.
Should there be an introduction text and what should it be?

Where can I see this now? The latest version of the the dactoolkit code I ran locally just shows me a wallet, so I'm a bit confused. I'd like to get the whole member registration process going quickly. Thanks!

My suggestion would be to put in text that covers what's going to happen:

Log in with Scatter
Register as a member of the DAC
Vote for custodians

The pop up screen should only show up once, not every time you visit the DAC toolkit.

This is how it looks. It shows up in the stepper after logging in with scatter and if you are not a member yet.
Iirc you already used it to register on the testnet.

Ah, that's what I was confused, I had already gone through the process. Is there any easy way for me to undo that? I was thinking of possibly doing a live stream demo of the DAC toolkit tomorrow on the team meeting.
We'll need a profile page of some kind so that people can show profile information. Should show something like:

Signed constitution on  (or block number???)
(constitution should be a link to show the file)
Registered as a member on  (or block number???)

There should also be an option from the profile page to unregister with appropriate warnings for the results of doing so.
Thoughts?