Support react-native 0.29

Since RN 0.29, getPackages() is defined in MainApplication, so modules's constructors can't have access to the activity. It's now required to call getCurrentActivity() from ReactContextBaseJavaModule whenever the activity is needed.
As the activity is attached to the context in onResume, OrientationModule also need to implement LifecycleEventListener to be able to call activity.registerReceiver
This pull request would close #83

I just tried your fork @youennPennarun and it wasn't working for me until I added the following to OrientationModule's constructor:
ctx.addLifecycleEventListener(this);

Looks to be working perfectly on RN0.29 with that addition though, thanks!

Indeed, I forgot to add this line. Thanks @jwarby

@yamill Can you merge this one?

Should be OK.

Thanks for that @youennPennarun and the rest of you guys!

Thanks for this. Any ETA when it will be merged and released?

I'm not sure how to implement this change i changed the package.json to point to "youennPennarun/react-native-orientation#master", removed node_modules and npm i.
Afterwards i ran  rnpm link react-native-orientation
After linking i run react-native run-android
I followed the configuration steps for the android files
Runing into these errors
/Main
Activity.java:46: error: method does not override or implement a method from a superty
pe
    @Override
    ^
/Users/donedgardo/skyrocket/piso13RNApp/android/app/src/main/java/com/piso13rnapp/Main
Activity.java:51: error: constructor OrientationPackage in class OrientationPackage ca
nnot be applied to given types;
            new OrientationPackage(this),
            ^
  required: no arguments
  found: MainActivity
  reason: actual and formal argument lists differ in length
2 errors

Not sure if im doing this right, or that theres an issue with my configuration.

Could you please help me to implement this package, because it is not work for me. When I used RN 0.26, it works fine, but now with RN 0.29, they add MainApplication.java and I am confused.
I fork this pull request with support for RN 0.29 and run rnpm:
sudo rnpm link react-native-orientation

Everything works fine, console log
rnpm-link info Linking react-native-orientation android dependency
rnpm-link info Android module react-native-orientation has been successfully linked
rnpm-link info Linking react-native-orientation ios dependency
rnpm-link info iOS module react-native-orientation has been successfully linked

I do not know, if I have to add 3. step in installation (Register module (in MainActivity.java)) and where do I have to add configuration?
Thank you very much for answers.

@Dudyboy Did you upgraded your application to RN0.29.2? Since modules aren't instantiated in MainActivity anymore, rnpm was broken with RN0.29.0. This has been fixed in RN0.29.2.
After the upgrade, try react-native link

Thank you for answer. Yes, I have RN0.29.2.
Dependencies:
    "react": "15.2.1",
    "react-native": "0.29.2",
    "react-native-orientation": "git+https://github.com/Dudyboy/react-native-orientation.git",

MainActivity looks like this:
package com.newapp;

import com.facebook.react.ReactActivity;
import com.github.yamill.orientation.OrientationPackage;
import android.content.Intent;
import android.content.res.Configuration;

public class MainActivity extends ReactActivity {

    @Override
      public void onConfigurationChanged(Configuration newConfig) {
        super.onConfigurationChanged(newConfig);
        Intent intent = new Intent("onConfigurationChanged");
        intent.putExtra("newConfig", newConfig);
        this.sendBroadcast(intent);
    }

    /**
     * Returns the name of the main component registered from JavaScript.
     * This is used to schedule rendering of the component.
     */
    @Override
    protected String getMainComponentName() {
        return "newApp";
    }
}

MainApplication.java looks like:
package com.newapp;

import android.app.Application;
import android.util.Log;

import com.facebook.react.ReactApplication;
import com.facebook.react.ReactInstanceManager;
import com.facebook.react.ReactNativeHost;
import com.facebook.react.ReactPackage;
import com.facebook.react.shell.MainReactPackage;
import com.github.yamill.orientation.OrientationPackage;

import java.util.Arrays;
import java.util.List;

public class MainApplication extends Application implements ReactApplication {

  private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
    @Override
    protected boolean getUseDeveloperSupport() {
      return BuildConfig.DEBUG;
    }

    @Override
    protected List<ReactPackage> getPackages() {
      return Arrays.<ReactPackage>asList(
          new MainReactPackage(),
          new OrientationPackage(this)
      );
    }
  };

  @Override
  public ReactNativeHost getReactNativeHost() {
      return mReactNativeHost;
  }
}

It shows error
incompatible types: <anonymous ReactNativeHost> cannot be converted to Activity
          new OrientationPackage(this)
                                 ^
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
1 error
:app:compileDebugJavaWithJavac FAILED

FAILURE: Build failed with an exception.

What am I doing wrong?

Your fork doesn't contain this pull request, as you can see when you compare my fork with yours.

You are rgiht :) ... my mistake. Now is everthing working like charm.
Thank you very much.

@yamill Any update on when this will be released?

I'm getting these errors:
Application.java:44: error: constructor OrientationPackage in class OrientationPackage
 cannot be applied to given types;
              new OrientationPackage(this)
              ^
  required: no arguments
  found: <anonymous ReactNativeHost>
  reason: actual and formal argument lists differ in length
1 error

Also its notifying me inside MainApplication.java
import com.github.yamill.orientation. OrientationPackage;
'Cannot resolve symbol OrientationPackage'.
Pls help.

@donedgardo It's new OrientationPackage(), there is no arguments anymore.
I updated the readme to reflect that change.

@youennPennarun I pulled down your fork. It fixes my Android build issues, but the orientation listeners are not working. I can lock / unlock orientation without issues, and my views rotate when unlocked, so I know orientation events are making it into the application. Just the listeners are not firing (listeners work fine on iOS).

Works fine for me

@zaynyatyi I figured out the issue is there is no Android support for the rotation specific listeners. The regular orientation listeners work fine.
I put this on the backburner for my app for the moment, but I eventually plan to circle back and add Android support for rotation specific listeners if no one beats me to it.

@youennPennarun you might consider leaving the Activity constructor, so upgraders have less friction.
@ronaldheft to clarify, you had no issue with this PR that you wouldn't have with master, correct?
I'd like to get this merged up. I have some additional changes staged that build on this.

@igrayson Correct, this PR is working.

Hi guys, just merged this! Thanks so much for supporting this. I haven't had time lately, would be awesome if anyone wants to help take over this module!


Polyfill for Symbol.dispose/Symbol.asyncDispose

Is there a polyfill for Symbol.dispose?
The Symbol.observable turns out to be useful for userland libs and is used de-facto, even the observable standard is not stabilized yet.
Would similar polyfill package for Symbol.dispose be required?
The use-case is v observable in spect, that creates a proxy, observing passed target. It needs a cancellation way, which should not conflict with target props, and special symbol seems perfect for it.

Ok, here's the repository: https://github.com/spectjs/symbol-dispose.
Please feel free to reach / address issues, that is tentative, I'm open to requested changes, if any.

Thanks for this. I'm not aware of other specific polyfills for the symbols at this time. The @esfx/disposable package has Disposable.dispose and AsyncDisposable.asyncDispose symbol, but does not attach them to the global Symbol.

Symbol.dispose / Symbol.asyncDispose available in core-js from 2019.

https://npmjs.com/disposablestack also contains one.


Missing /dev/sev-guest when trying to get the attestation report

Hi there,
I'm trying to run sec-guest get-report report.bin in the guest is getting the following error:
[sev-guest]root@localhost# ./sev-guest get-report report.bin
Generating report using the following hash:
<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000
<PHONE_NUMBER>000000000000000000000000000000000000000000000000000000

open: No such file or directory
get_report: No such file or directory

Based on the source code, it's looking for /dev/sev-guest, which is not my case. I'm using the kernel in AMDESE/AMDSEV for the guest and the guest kernel version is 5.17.0-rc6-snp-guest-dfa5ba8 . The truncated dmesg output is the following in the guest
[    0.011868] memblock_alloc_try_nid: 8208 bytes align=0x1000 nid=-1 from=0x0000000000000000 max_addr=0x0000000000000000 sev_es_init_vc_handling+0xea/0x169
[    0.012020] memblock_alloc_try_nid: 8208 bytes align=0x1000 nid=-1 from=0x0000000000000000 max_addr=0x0000000000000000 sev_es_init_vc_handling+0xea/0x169
[    0.012150] memblock_alloc_try_nid: 8208 bytes align=0x1000 nid=-1 from=0x0000000000000000 max_addr=0x0000000000000000 sev_es_init_vc_handling+0xea/0x169
[    0.012273] memblock_alloc_try_nid: 8208 bytes align=0x1000 nid=-1 from=0x0000000000000000 max_addr=0x0000000000000000 sev_es_init_vc_handling+0xea/0x169
[    1.967344] AMD Memory Encryption Features active: SEV SEV-ES SEV-SNP
[    2.332836] SEV: Using SNP CPUID table, 31 entries present.
[    2.544657] SEV: SNP guest platform device initialized.

My understanding is the kernel module for sev-guest was loaded successfully, but I don't know why I cannot find it under /dev

I think you should use the guest kernel version  as documented in the stable-commits file of the sev-snp-devel branch of the AMDSEV repo. Now the guest kernel is based 5.19, not 5.17.

This is resolved, see this

Hi, I am trying to load /dev/sev-guest, but it fails with could not insert module ./sev-guest.ko: No such device.
Does anyone has similar problem?
My dmesg | grep -i sev of guest kernel is
[     0.166648] Memory Encryption Features active: AMD SEV SEV-ES

My kernel is 5.19.0-rc6-snp-guest-c4daeffce56e.
I launched the kenel with SEV support only for some reason.
I found sev-guest.ko under /lib/modules/5.19.0-rc6-snp-guest-c4daeffce56e,
but insmod ./sev-guest.ko does not work due to the above reason.


Sage/Getting Started with Celo; A Beginner Guide

Added tutorial

Updated Tutorial Info

Markdown changes

Thanks for submitting this tutorial for Celo Sage
Before you hit "Create Pull Request", make sure you have read the Tutorial Contribution Guidelines and reviewed the Sample Tutorial Structure.
Please confirm the following before submitting your tutorial for review -
[x] My tutorial follows the Tutorial Contribution Guidelines.
[x] The title of the Pull Request matches the title of my tutorial.
[x] I've followed the tutorial template structure.
[x] I've proofread the tutorial for spelling and grammar mistakes.
[x] I've thoroughly explained the code, with inline code comments and text explanations.
[x] I've run a linter & prettifier to format my code blocks.
[x] I've run the tutorial to test it and the code works.

NOTE: We cannot review your Pull Request if it does not meet the standard outlined above.
Reviewers - @joenyzio & @viral-sangani

Closing Celo Sage PRs


Core dump on mintermizing of several files

This is separate from the high-memory issue; these fail pretty much immediately.
./build/examples/example06-mintermization automata-bench/bench2/ltl_afa/created_ltl/LTLf-specific/Response/N360.mata
... (outputs original file)...
Segmentation fault (core dumped)

Thid will be of great help when debugging the issue. Thank you for the reports.

The Bug
The execution fails on line 101 because the previous assertion on line 100 is turned off by the release compilation. This assertion would normally be triggered when bdd.type equals OptionalBdd::TYPE::NOTHING_E.
https://github.com/VeriFIT/mata/blob/8b885af40bf91b4d96674a75e4ec6a2ec67c6b9b/src/mintermization.cc#L94-L106
Is It Really a Bug?
As can be inferred from the comments and variable names in the for-loop, it deals with some kind of disjuncts (lhs_to_disjuncts_and_states). The variable ds_pair is even of the type DisjunctStatePairs, defined as:
using DisjunctStatesPair = std::pair<const FormulaGraph *, const FormulaGraph *>;

This, along with the fact that the automaton:
@AFA-bits
%Initial qOR2
%Final qI & qOR2
qI \true
qOL1 aV1
qOL2 aV2
qOR2 (qOL1 | qOL2) & qI

leads to an assertion failure on line 100, whereas the automaton:
@AFA-bits
%Initial qOR2
%Final qI & qOR2
qI \true
qOL1 aV1
qOL2 aV2
qOR2 (qOL1 & qI) | (qOL2 & qI)

passes without any problem, suggests that the official automaton format accepts formulae only in Disjunctive Normal Form (DNF).
Should We Extend AFA-bits for Formulae in General Form?
This observation raises the question of whether we should extend the AFA-bits automaton format to support transition formulae in general form (not limited to DNF) or leave it as it is.
What to Do Now?
If you need the AFA-bits format immediately, I suggest manually transforming all transition formulae into DNF. The provided automaton ltl_afa/created_ltl/LTLf-specific/Response/N360.mata loads perfectly after the transformation.


Suggestion

The library works very well, the only difference i noted using message template is that it is not possible to edit message button.
The configuration is possible only at template creation time (MessageTemplate), but using TemplateMessage adding ComponentType.BUTTONS there is no way to pass subtype, payload, text, url on the buttons. Thanks for your work.

Hello @fabiofavale85 ,
The changes and fixes to message templates are now available in version v0.2.0.

It works very well. Great Job!!! @Bindambc


Error: Could not authenticate request invalid_grant: Invalid JWT Signature.

Index.js
`const multer = require('multer');
const gcs = require('@platoai/multer-gcs');
var path=require('path');
var express=require('express');
var bodyparser=require('body-parser');
const app = express();
app.get("/", (req, res) => {
res.sendFile(path.join(${__dirname}/index.html));
});
const storage = gcs({
filename: function(req, file, cb) {
cb(null, file.fieldname + '-' + Date.now());
},
bucket: 'fenchy100',
credentials: require('C:/Users/memon/Downloads/FenchyImage-f8ed647b7099.json'),
// optional metadata to add to the file
metadata: {
contentType: 'audio/wav'
},
// optional, passed to the @google-cloudg/storage getSignedUrl method
// defaults to:
urlConfig: {
action: 'read',
expires: new Date(new Date().getTime() + 7 * 24 * 60 * 60 * 1000),
},
// optional, see: https://cloud.google.com/storage/docs/access-control/lists
// defaults to:
acl: 'publicRead',
});
const gcsUpload = multer({storage: storage});
app.post('/upload', gcsUpload.single('file'), function(req, res, next) {
res.send('File was uploaded successfully!');
});
const PORT = process.env.PORT || 8080;
app.listen(PORT, () => {
console.log(App listening on port ${PORT});
console.log("Press Ctrl+C to quit.");
});
`
Package.Json
`"dependencies": {
"@google-cloud/storage": "^1.5.1",

 "@platoai/multer-gcs": "^1.1.0",

"express": "^4.16.2",

"express-jwt": "^5.3.0",

"gcloud": "^0.36.0",

"google-cloud": "^0.57.0",

"grpc": "^1.7.3",

"grpc-tools": "^1.6.6",

"jsonwebtoken": "^8.1.0",

"multer": "^1.3.0",

"restify": "^6.3.4"

},
"devDependencies": {
"webpack-babel-jest": "*",

"jest-cli": "*",

"babel-cli": "^6.26.0",

"babel-preset-es2015": "^6.24.1",

"babel-preset-stage-2": "^6.24.1"

}`

First, the error stack doesn't seem to include this library -- it looks like google's library that's throwing the error.
Second, the credentials passed to gcs appear to be stashed in a JSON file you didn't include; I would expect issues reported here to have explicitly called this library at some point in the sample.
Without more information, I would bet that the JSON file with the credentials is probably corrupted or the signature has already expired. Paste the token at jwt.io and it'll help troubleshoot the actual token.


[Network] Remove nulls from VPN connection show/list output

Fixes #1615.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
- [ ] The PR has modified HISTORY.rst with an appropriate description of the change.
Command Guidelines
- [ ] Each command and parameter has a meaningful description.
- [ ] Each new command has a test.
(see Authoring Command Modules)

Codecov Report

Merging #2748 into master will decrease coverage by 0.03%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master    #2748      +/-   ##
==========================================
- Coverage   61.16%   61.13%   -0.04%
==========================================
  Files         480      480
  Lines       25711    25727      +16
  Branches     3888     3894       +6
==========================================
+ Hits        15726    15727       +1
- Misses       9056     9075      +19
+ Partials      929      925       -4

Impacted Files
Coverage Δ

...work/azure/cli/command_modules/network/commands.py
98.98% <100%> (ø)
:arrow_up:

...twork/azure/cli/command_modules/network/_format.py
36.84% <6.25%> (-8.16%)
:arrow_down:

...dback/azure/cli/command_modules/feedback/custom.py
34.69% <0%> (ø)
:arrow_up:

src/azure-cli-core/azure/cli/core/util.py
68.99% <0%> (ø)
:arrow_up:

...-cli-role/azure/cli/command_modules/role/custom.py
19.28% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f4af8b...d36691c. Read the comment docs.

Can we include a description of this change in the change log?

@derekbekoe feedback addressed.


CoreInfo update functionality

Hi. I have a feature request.
Could you add functionality to update the CoreInfo (the coreData variant map to be specific)? The client does that as well when you click File -> Core Info.
It'd be great to be able to check the number of clients connected to the core (sessionConnectedClients in coreData). With that, one can write a script to mark the user as "away" or rename the user when there are less than 2 clients connected.

Added through 4bd502d (version 0.9.0)
Call it like this:
quassel.sendInitRequest("CoreInfo", "");

You'll receive a 'coreinfo' event:
quassel.on('coreinfo', function(coredata) {
    console.log(coredata);
});

coredata object is not kept in sync (core limitation), so in order to refresh it, you must resend and InitRequest.


Clarify that anyone can participate in the project

Adds an "Everyone" role to try and clarify that you do not need to be a "contributor" to contribute. It's just a perhaps unfortunate choice for the name of the role we've chosen for folks that regularly participate in the Paketo projects. Everyone can contribute, those with the contributor role contribute a lot.
Resolves #84

@davidmirror-ops Thoughts on this?

I was thinking of a Casual contributor role to effectively define 'Everyone'
And also to rename the Contributor role to Core contributor.
So, the contribution ladder will start from casual contributions, then becoming a more regular -core- contributor and then eventually a maintainer.
wdyt?

We can also draw inspiration from the CNCF Contributor ladder template

I actually like the "everyone" notion. Besides, it is also a defined role in the Cloud Foundry community repo https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md.

Oh, happy coincidence there @loewenstein. I had picked "Everyone" because was the most inclusive word I could come up with. Even if I've never done anything for the project, I still know I fit in that category.
I like the table in the CFF roles. That is really easy to follow and for comparison purposes. If others like that too, I could make one for Paketo roles and submit in a separate PR.

Oh @loewenstein that's a pretty clear role definition table!
Even for 'everyone' the requirements and privileges are crystal clear

I added a summary table: https://github.com/paketo-buildpacks/community/blob/gh_issue_84/GOVERNANCE.md#summary
Thoughts?

You've got a copy & paste artifact left in the table.

Member of the Cloud Foundry Slack workspace

Thanks @loewenstein - fixed that.

Also, I am not sure I agree to the requirement to be nominated for steering committee by invitation of the steering committee. But that might be a more general governance thing and not an issue with the table itself.

@dmikusa-pivotal any blockers to merging this?

I think we are 👍. Ryan approved as well, so that's two of three steering committee members.


NFS shared folder mount issue in win 8 , virtualbox 5.0.14 , vagrant 1.8

There seems to be a "mount" issue in windows 8 , virtualbox 5.0.14 , vagrant 1.8.
I am getting the following errors after doing the vagrant up
                                                                                ==> openapphackvm: Waiting for machine to boot. This may take a few minutes...
openapphackvm: SSH address: <IP_ADDRESS>:2222
openapphackvm: SSH username: vagrant
openapphackvm: SSH auth method: private key

==> openapphackvm: Machine booted and ready!
==> openapphackvm: Checking for guest additions in VM...
==> openapphackvm: [vagrant-hostsupdater] Checking for host entries
==> openapphackvm: [vagrant-hostsupdater] Writing the following entries to (C:/Windows/system32/drivers/etc/hosts)
==> openapphackvm: [vagrant-hostsupdater]   <IP_ADDRESS>  openapphackvm.dev  # VAGRANT: a1df56e4bac5b25eab788b41952aa201 (openapphackvm) / 5a8274be-ec73-4c49-8b8f-131d7f5f2a2c
==> openapphackvm: [vagrant-hostsupdater] This operation requires administrative access. You may skip it by manually adding equivalent entries to the hosts file.
==> openapphackvm: Setting hostname...
==> openapphackvm: Configuring and enabling network interfaces...
==> openapphackvm: Exporting NFS shared folders...
==> openapphackvm: Preparing to edit nfs mounting file.
[NFS] Status: running
==> openapphackvm: Mounting NFS shared folders...
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!
_**mount -o '' <IP_ADDRESS>:'/C/Users/sa272015/Sites/openapphackvm' /var/www/openapphackvm
Stdout from the command:
Stderr from the command:
stdin: is not a tty
mount.nfs: mount system call failed
**_

Delete the \HashiCorp\Vagrant\embedded\gems\gems\vagrant-1.8.1\plugins\provisioners\ansilbe
Get the same from git https://github.com/mitchellh/vagrant/  and paste over there ,take a reboot ,Run git bash as Administrator ,Install the  the vagrant plugins again .


Remember Me checkbox should work in case local storage is deleted

Steps to reproduce:

Remove cache and keep settings.json file.
Delete localstorage entry for checkbox from the app.
Run the installer

Observation:
The username and password fields are there, but the checkbox is unchecked (as there is no localstorage entry).

@mohitsuman @sudhirverma could you update description with steps to reproduce the issue?

@dgolovin I have update the description of the issue. This was reproducible for me on macOS.


How do I use the CantopopLyrics Google Docs Add-on?

Select all lyrics text.
Click the menu item: Add-ons > CantopopLyrics > Make Cantopop lyrics ...

A preview of the lyrics should appear in the sidebar.

Save the Cantopop lyrics to Google Drive.

Save as Document (a Google Document)
Save as Text (a plain text file)


Lock document only if found

I have issue that some documents expire in mongodb and references return null.
Then $repository->find($invalidId, LockMode::OPTIMISTIC); throws exceptions when UnitOfWork tries to lock NULL.

:+1:

Thanks for the fix!

What about setLockMode in Doctrine\ODM\MongoDB\Query\Query like Doctrine\ORM\Query?

@men232 feel free to open new issue or submit a PR implementing that :)


Left/right arrows

If you open a lot of files the tab view shows two left/right buttons but they don't work.

Thank you for the feedback.
I'll investigate it.

Sorry for leaving this issue unattended for a long time.
Please use the latest version of SmoothCSV (3.0.0).
https://github.com/kohii/smoothcsv3


Improve doc

Community Contribution
Link to live project, video, or image:

Sharing

[ ] I would be happy to have my project shared on The Coding Train's social media!

Instagram:
Twitter:

Please mark as invalid and spam, this is an obvious attempt to get a free t-shirt by 'contributing'(hacktoberfest)
This will also ban the user for trying to abuse the system by doing marginal effort

Thanks for your suggestion! We like to be thoughtful about modifications to the Coding Train website and I don't see how this change would improve the site. If you disagree, please explain why you think this change would make the website more clear or help in some other way. I'd be happy to reopen this pull request for discussion.
If you're interested in contributing to the Coding Train website, I'd suggest contributing a link to a project you've made based on one of our videos. You can see more instructions on doing that in the community contributions guide.
You can also practice using GitHub with our Rainbow-Poem repository which was covered in the Git/GitHub series. Unfortunately there's a rather large backlog of pull requests open there so it's unlikely it that any new pull requests will be merged soon.


Fixed docs in functions that update matrices

Fixes https://github.com/oxfordcontrol/osqp/issues/127

Coverage remained the same at 87.764% when pulling dfacf3ead778bed3b21e4dd48c6d31d7adc0363d on update_docs into 1a229e20816402b821b03bebbe80f96b84d9062a on master.


feat: Ce 443 automate coms access

Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Further comments

Closing in favor of new branch off of new release branch


Lottie animation

This patch adds the velato crate which implements a Lottie animation player on top of vello.
The implementation is incomplete but it is capable of rendering a large number of animations. Notable missing features that are on the roadmap:

Solid color layers
Trim paths
Merge paths (pending kurbo pathops!)
Cubic time mapping and interpolation
Stars/polygons
Blur effects (pending support in vello)
Probably more...

Currently depends on a modified version of the bodymovin-rs parser. I believe we'll eventually want a different solution to parsing that is robust in the context of an evolving file format, but this works for now.
To avoid churn and additional merge conflicts, I haven't updated any of the example code to exercise this, though there is example usage in the readme. It's only a few lines of code to get a lottie file into a scene builder.

Might be nice to include a simple example, so you can do cargo run --example some_example_name?

I changed the catch all svgs command line argument in the winit demo to accept both svg and lottie json files and added an ExampleScene generator for the latter so cargo run -p winit -- path/to/lottie.json will now work.

I changed the catch all svgs command line argument in the winit demo to accept both svg and lottie json files and added an ExampleScene generator for the latter so cargo run -p winit -- path/to/lottie.json will now work.

Could you include a very basic lottie json, so the user can run an example without having to find their own?

I've really struggled to find suitably licensed lottie files; however, the files in https://github.com/CommunityToolkit/Lottie-Windows/tree/main/LottieSamples/Assets appear to be MIT licensed.
I tried https://github.com/CommunityToolkit/Lottie-Windows/blob/main/LottieSamples/Assets/LottieLogo1.json, which gave incorrect rendering

Aah I see. If there are licensing issues then I don't think it's super important. Perhaps someone could make an animation later (explaining vello 👀) and add it to the project.

There are other files in the examples repository; I might have also tried the light bulb document, which might have worked, although it is a bit dull. It would be good to have a thematic example, although I'm not the person to make such a thing.

I don't think having an example lottie file should block this PR. Let's merge this, then perhaps open an issue for someone to find or create a lottie file with the right licensing.

We've chosen to move this to it's own repository, i.e. linebender/velato. Go give it some love 🎉
This allows greater flexibility in making changes there, without compromising the review standards of the Vello repo.


Update README instructions for starting Hound in the test env

I haven't tested this, but I think the following is better for users rather having to add it to the list of applications.

Thank you @scrogson. I'm merging this. Hound must be started before ExUnit, but I'll make that change later.


Token Method 1 no longer works

Method 1 OAuth redirects to a non-existent GitHub Pages URL. Suspect this is due to the maintainer changing their GH account?

WORKAROUND

Replace erroneousboat with jpbruinsslot in the GitHub Pages URL pushed by the OAuth redirect. This will take you to the correct page.

Version: 0.5.0
Installation method: binary

I used method 1 to get code and just paste url in the browser using method 2 curl command
$ curl -s "https://slack.com/api/oauth.access?client_id=91899392594.382712253827&client_secret=c7986be41b6ddb478041d1848dad5f6e&code=[code-goes-here]"


bugfix: calculate realHTTPFileLength which is different realFileLength

Signed-off-by: Starnop<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Now the writer will calculate the file Length dynamically which includes the piece header and piece tailer. However, we will use httpFileLength which is the length of the file contents to check whether file length matches the expected.
Ⅱ. Does this pull request fix one issue?

None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
None.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #569 into master will increase coverage by 0.06%.
The diff coverage is 52.94%.

@@            Coverage Diff            @@
##           master    #569      +/-   ##
=========================================
+ Coverage   48.53%   48.6%   +0.06%
=========================================
  Files          94      94
  Lines        5227    5232       +5
=========================================
+ Hits         2537    2543       +6
+ Misses       2497    2496       -1
  Partials      193     193

Impacted Files
Coverage Δ

supernode/daemon/mgr/progress/progress_util.go
21.42% <0%> (-0.35%)
:arrow_down:

supernode/daemon/mgr/cdn/manager.go
17.77% <0%> (+0.57%)
:arrow_up:

supernode/daemon/mgr/cdn/super_writer.go
92.06% <90%> (+0.83%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2286d5...f1f0a14. Read the comment docs.


Support for attributes of mocked class

E.g.:
use Symfony\Component\HttpFoundation\ParameterBag;
use Symfony\Component\HttpFoundation\Request;

$this->attributes = $this->prophesize(ParameterBag::class);

$this->request = $this->prophesize(Request::class);
$this->request->attributes = $this->attributes->reveal();

Will error with:
Access to an undefined property
Prophecy\Prophecy\ObjectProphecy<Symfony\Component\HttpFoundation\Request>::$attributes.

In that case, it's right that way. Mocking those is discouraged by Prophecy, see: https://github.com/phpspec/prophecy/issues/86

Can understand that in many cases but I need to mock it to test that specific functions are called and specific functions should not be called and thats only possible with mocking.

That's still testing internal behavior, I would not advise it. You can instead inspect the final $request state after calling the unit under test.

@Jean85 is right.


self-update failed

WHAT
After I run afx self-update, an error zsh: exec format error: afx arised. The version before the update was 1.21.
I manually reinserted afx and it fixed, so it seems that the detection of OS or architecture is failing during self-update.
I use Ubuntu20.04 on WSL2 and afx_linux_x86_64.tar.gz.

I don't have above environment so I can't reproduce your situation. Maybe related code is here:  https://github.com/b4b4r07/afx/blob/master/pkg/github/github.go#L162-L223
Please contribute it

https://github.com/b4b4r07/afx/blob/ee7148103bd3c744a20743e00f7c60e90793cb03/pkg/github/github.go#L207
2022/05/30 10:25:02 [DEBUG] assets.filter: filtered: []string{"afx_linux_arm64.tar.gz", "afx_linux_i386.tar.gz", "afx_linux_x86_64.tar.gz"}
2022/05/30 10:25:02 [DEBUG] assets.filter: filtered: []string{"afx_linux_arm64.tar.gz", "afx_linux_x86_64.tar.gz"}
2022/05/30 10:25:02 [WARN] 2 assets found: []string{"afx_linux_arm64.tar.gz", "afx_linux_x86_64.tar.gz"}
2022/05/30 10:25:02 [WARN] first one "afx_linux_arm64.tar.gz" will be used

It seems that arm64 matches this regex (since it contains 64). Should I modify it so that it should not include arm? (I don't know of any reason why only 64 would be allowed.)


[FEATURE] Allow crawl subcommand to use hosts found with scan

The crawl command takes a list of hosts to perform the crawl from the CLI, but could be extended to use the hosts found from performing a scan. This would also require adding a --cache flag to point to where the scan information is stored and should point to the normal default location if not specified. Any hosts added as positional arguments would be added to the scan in addition to the ones in the cache. It may also be worth adding a --no-cache flag to only perform the crawl only with the CLI hosts supplied.
The use would be something like:
magellan scan --subnet <IP_ADDRESS> --subnet-mask <IP_ADDRESS> --cache ./hosts.db
magellan crawl --username <username> --password <password> --cache ./hosts.db <IP_ADDRESS>

This will stored found host on the <IP_ADDRESS> subnet into ./hosts.db and will be included in the crawl in the second command, while also adding the <IP_ADDRESS> to the crawl as well.

By changing collect's implementation to use the CrawlBMC function internally, this may not be necessary anymore. The better option would be to have the collect being used like before and having the crawl command used to specify a host. The difference is that collect uses the hosts found from performing a scan and the crawl will be a subset of that used to inspect individual BMC nodes.


Cannot reset custom theme

Cannot clear the theme css with backspace. Right now if I want "just" dark theme without any modifications, I have to add empty.css to do so.

Should be able to hit escape to clear the input fields.  Looks like that code got lost somewhere in the React port.


Steroscope looking for podman rather than docker sock

I build a docker container using the<EMAIL_ADDRESS>and<EMAIL_ADDRESS>actions. But do not push the container to Artifactory at this point.
The image is built and loaded into docker fine, however when I try to run this action it cannot find the image locally and appears to be looking for a podman sock rather than docker.
- name: Generate SBOM
        id: sbom
        uses: anchore/sbom-action@v0
        with:
          image: "${{ inputs.registry }}/${{ inputs.image_name }}:${{ steps.image_date_tag.outputs.TAG_NAME }}"

gives the error (PII removed from container and repo names)
[0000] DEBUG no socket address was found. Trying default address: /run/user/1001/podman/podman.sock from-lib=stereoscope
  [0000] DEBUG looking for socket file: stat /run/user/1001/podman/podman.sock: no such file or directory from-lib=stereoscope

  [0000] DEBUG image: source=OciRegistry location=docker-local.my.artifactory.systems/gha-scaleset-runner:20230621-121746 from-lib=stereoscope

  [0000] DEBUG pulling image info directly from registry image="docker-local.my.artifactory.systems/gha-scaleset-runner:2023062-[121](https://github.com/my_org/my_repo/actions/runs/5333937405/jobs/9665073233#step:13:122)746" from-lib=stereoscope
  [0000] DEBUG no registry credentials configured, using the default keychain from-lib=stereoscope

  2023/06/21 12:22:03 error during command execution: 1 error occurred:
  	* failed to construct source from user input "docker-local.my.artifactory.systems/gha-scaleset-runner:20230621-121746": could not fetch image "docker-local.my.artifactory.systems/gha-scaleset-runner:20230621-121746": unable to use OciRegistry source: failed to get image descriptor from registry: GET https://docker-local.my.artifactory.systems/v2/gha-scaleset-runner/manifests/20230621-121746: MANIFEST_UNKNOWN: The named manifest is not known to the registry.; map[manifest:gha-scaleset-runner/20230621-121746/manifest.json]

I am not sure why it is looking for a podman socket when all the documentation refers to using docker and I cannot find a config option for this.
Thanks for the help.

It looks like the client itself doesn't automatically respect the DOCKER_HOST env var:
https://github.com/moby/moby/blob/b6ad25bf5e718142a03ae1027933e8b976dfc923/client/client.go#L133-L155

Hi, Apologies I have been away.
Thanks for your continued investigation of this.

Here is some testing I did after disabling the default docker socket on my laptops (the one at /var/run/docker.sock):
$ syft docker:busybox:latest
2023/07/10 11:54:40 error during command execution: 1 error occurred:
  * failed to construct source from user input "docker:busybox:latest": could not
  fetch image "busybox:latest": scheme "docker" specified; image retrieval
  using scheme parsing (busybox:latest) was unsuccessful: unable to use
  DockerDaemon source: unable to inspect existing image: Cannot connect to the
  Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?;
  image retrieval without scheme parsing (docker:busybox:latest) was
  unsuccessful: unable to determine image source

$ DOCKER_HOST="unix://$HOME/.docker/run/docker.sock" syft docker:busybox:latest
 ✔ Loaded image
 ✔ Parsed image
 ✔ Cataloged packages      [1 packages]
NAME     VERSION  TYPE
busybox  1.36.1   binary

It looks like syft is already respecting DOCKER_HOST, I just haven't found the code that makes it do that.

@apr-1985  one thing you might try doing is explicitly specifying that syft should be using docker:
 - name: Generate SBOM
        id: sbom
        uses: anchore/sbom-action@v0
        with:
          image: docker:"${{ inputs.registry }}/${{ inputs.image_name }}:${{ steps.image_date_tag.outputs.TAG_NAME }}"

(note docker prefixed on the image input). Please let us know if that helps. Thanks!

Hi thanks for the update and the continued investigation.
I have tried as requested but it is still failing on looking for the docker sock
  [0000] DEBUG image: source=DockerDaemon location=docker-local.artifactory.systems/gha-scaleset-runner:20230711-090433 from-lib=stereoscope

  [0000]  WARN scheme "docker" specified, but it coincides with a common image name; re-examining user input "docker:docker-local.artifactory.systems/gha-scaleset-runner:20230711-090433" without scheme parsing because image retrieval using scheme parsing was unsuccessful: unable to use DockerDaemon source: unable to inspect existing image: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

  [0000] DEBUG image: source=UnknownSource location=docker:docker-local.artifactory.systems/gha-scaleset-runner:20230711-090433 from-lib=stereoscope
  2023/07/11 09:08:42 error during command execution: 1 error occurred:
  	* failed to construct source from user input "docker:docker-local.artifactory.systems/gha-scaleset-runner:20230711-090433": could not fetch image "docker-local.artifactory.systems/gha-scaleset-runner:20230711-090433": scheme "docker" specified; image retrieval using scheme parsing (docker-local.artifactory.systems/gha-scaleset-runner:20230711-090433) was unsuccessful: unable to use DockerDaemon source: unable to inspect existing image: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?; image retrieval without scheme parsing (docker:docker-local.artifactory.systems/gha-scaleset-runner:20230711-090433) was unsuccessful: unable to determine image source

So I've confirmed in a Linux VM (fedora running under lima in case that matters for some reason in the future) that syft is respecting DOCKER_HOST even when its a tcp port instead of a local socket. Running the same command below with and without DOCKER_HOST in the environment:
$ DOCKER_HOST=tcp://localhost:2376 syft packages docker:busybox:latest
 ✔ Loaded image
 ✔ Parsed image
 ✔ Cataloged packages      [1 packages]
NAME     VERSION  TYPE
busybox  1.36.1   binary
# re-run without DOCKER_HOST to prove that was why it worked previously
$ syft packages docker:busybox:latest

2023/07/11 21:34:04 error during command execution: 1 error occurred:
	* failed to construct source from user input "docker:busybox:latest": could not fetch image "busybox:latest": scheme "docker" specified; image retrieval using scheme parsing (busybox:latest) was unsuccessful: unable to use DockerDaemon source: unable to inspect existing image: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?; image retrieval without scheme parsing (docker:busybox:latest) was unsuccessful: unable to determine image source

So it looks like DOCKER_HOST is respected by syft correctly in this case. It seems like there are two possibilities:

The environment variable is not being set for syft when syft runs
Something else about the setup is making syft try to talk to docker on the wrong host.


Bug 2295778: osd: reweight osd while resizing

Normally the device class of an OSD is determined at provisioning and is not updated thereafter. In some scenarios the admin may want to force update the device class to a new value. The device classes can be updated by first setting allowDeviceClassUpdate in the storage spec of the cephcluster, then updating the device class specified on the deviceSets or other OSDs.
(cherry picked from commit 88e952a3acefbf04016f5e75e0bf8b1ee496f3ef)

Checklist:

[ ] Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
[ ] Reviewed the developer guide on Submitting a Pull Request
[ ] Pending release notes updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

/assign @travisn

/bugzilla refresh


Rename Date to PosixDate

https://github.com/ponylang/ponyc/issues/1902

Date -> PosixDate.
If any of the creation arguments is negative set them to zero.
Tests for PosixDate.

Thanks @slayful.
In the future, can you add more informative commit messages, perhaps stealing some reasoning from the issue and include a "Closes #XXXX"?
Both those will help us greatly.
Once this passes CI, I'm going to squash your commit, add a good commit message explaining the change and then close the corresponding issue.

We need to update the changelog-tool before this can be merged and then .travis_script.sh will need to be updated as part of this PR to use the correct version of the changelog-tool.

I'm leaving this for now. @Theodus lets discuss how to handle this at the next sync. This will come up from time to time and I think its a good chance to figure out how we will deal with. Sorry this will delay your PR @slayful.

No problem, thanks for the update. :)


Not supported: The Cygwin, TDM, MinGW compiler, help to change that or use MinGW64 with 32/64 bits.

UPDATE./  Can you guys PLEASE state that you do not support 3.6.  I've spent half the day only to realise you guys do not support it yet state you do on your website.
C:\Users\Bain3>Nuitka --exe 123.py
Nuitka:WARNING:Not recursing to 'selenium' (C:\Users\Bain3\Anaconda3\Lib\site-packages\selenium), please specify --recurse-none (do not warn), --recurse-all (recurse to all), --recurse-not-to=selenium (ignore it), --recurse-to=selenium (recurse to it) to change.
Nuitka:WARNING:Not recursing to 'selenium.webdriver.support.ui' (C:\Users\Bain3\Anaconda3\Lib\site-packages\selenium\webdriver\support\ui.py), please specify --recurse-none (do not warn), --recurse-all (recurse to all), --recurse-not-to=selenium.webdriver.support.ui (ignore it), --recurse-to=selenium.webdriver.support.ui (recurse to it) to change.
Nuitka:WARNING:Not recursing to 'selenium.webdriver.support' (C:\Users\Bain3\Anaconda3\Lib\site-packages\selenium\webdriver\support), please specify --recurse-none (do not warn), --recurse-all (recurse to all), --recurse-not-to=selenium.webdriver.support (ignore it), --recurse-to=selenium.webdriver.support (recurse to it) to change.
Nuitka:WARNING:Not recursing to 'selenium.webdriver.common.by' (C:\Users\Bain3\Anaconda3\Lib\site-packages\selenium\webdriver\common\by.py), please specify --recurse-none (do not warn), --recurse-all (recurse to all), --recurse-not-to=selenium.webdriver.common.by (ignore it), --recurse-to=selenium.webdriver.common.by (recurse to it) to change.
Nuitka:WARNING:Not recursing to 'requests' (C:\Users\Bain3\Anaconda3\Lib\site-packages\requests), please specify --recurse-none (do not warn), --recurse-all (recurse to all), --recurse-not-to=requests (ignore it), --recurse-to=requests (recurse to it) to change.
Nuitka:WARNING:Not recursing to 'selenium.common.exceptions' (C:\Users\Bain3\Anaconda3\Lib\site-packages\selenium\common\exceptions.py), please specify --recurse-none (do not warn), --recurse-all (recurse to all), --recurse-not-to=selenium.common.exceptions (ignore it), --recurse-to=selenium.common.exceptions (recurse to it) to change.
Nuitka:WARNING:Not recursing to 'retrying' (C:\Users\Bain3\Anaconda3\Lib\site-packages\retrying.py), please specify --recurse-none (do not warn), --recurse-all (recurse to all), --recurse-not-to=retrying (ignore it), --recurse-to=retrying (recurse to it) to change.
Error, cannot find "gendef.exe" which is required though.

The current develop version is working fine with Python 3.6 on win10. The only thing is to try to manage to install gendef.exe.

By Gendef.exe you mean Mingw?  Could you provide the direct links for download or  maybe a more in depth tutorial?  I spent the whole day trying to get this work yesterday.  To my knowledge I have Mingw installed.  I tried Pyinstaller which worked great.  Just add cython and you're app is good as gold.  I also reinstalled it on laptop and a virtual machine and had major issues getting it to recognise visual studio, mingw which were installed when using Nuitka.  I believe someone had same issue years ago but I resolved it with Pyinstaller + cython.    Of course, maybe they can get Nuitka to recognise Mingw and Visual Studio but good luck with that one!   There is a bit more documentation with Cython too.

My case: install is:

Windows 10
Anaconda Python 3.6
TDM-GCC-64
Visual Studio Build Tools 2017
Nuitka from github source (pip installed)

gendef.exe downloaded from a probably not so safe location (here) and added to the tdmgcc/bin folder.
And it works fine.

Well, ...
I'm just not using mingw64 ... the rest, obviously, looks like windows to me...

Very well.  So GCC http://tdm-gcc.tdragon.net/download as well as https://sourceforge.net/projects/mingw/files/MinGW/Extension/gendef/gendef-1.0.1346/gendef-1.0.1346-1-mingw32.RELEASE_NOTES/download  . I'm not even sure I have a tdmgcc/bin folder.  The first link is an executable so should be no problem.  The gendef I cannot find that folder.  I assumed downloading mingw that it installed the gendef automatically...

re-tested same issue.  Pyinstaller + cython is a viable workaround for others who have this issue

As usual, ... "please provide a reproducible example" would be a good suggestion.
And, about the tdmgcc/bin, that's what I meant: C:\TDM-GCC-64\bin it's where you actually install the TDM....

Thanks but I've done all of that.  Mark as resolves as it was resolved with Cython and Pyinstaller. I appreciate the help but it just does not work for me :)

Wow... For what I can tell (and I'm not a nuitka dev, just "another dev"), I don't appreciate your help in making the package better. No reproducible example, no details. Just an "it doesn't work, so I used something else". How rude.

It is resolved.  I also don't like someone attacking me for stating what I found helpful.   I used Cython + pyinstaller.  I'm not trying to be rude I'm trying to be sensible.  I spent one whole day trying to get it work.  I poured over stackoverflow questions and found another with the same question unresolved.  I have other stuff to get done and might look into this when I have time but sadly, I do not right now.  I don't want the stress of futility getting this app to work when it just does not want to run on any windows pc.  I have tried REinstalling pc 3 seperate times.  I think that the concept is great and I hope others can use it but its just not user friendly enough for me.  I like a quick install, a command that works.  Pyinstaller + Cython do this for me.  I am sorry I offended you but I hope you can use this as feedback so that you can make it more detailed so others do not get frustrated and just use a program that works for them.  Also the errors speak for themselves.  I don't know how much more detailed I can be.  Also, I don't get how it is rude do go with a program that works.  This works for some but not for me.

Anyway, thanks again for your feedback on that matter, it really will help nuitka devs make the project better.

@ThomasLecocq If you want to use TDM, you have work in front of yourself, it's not supported. The gendef.exe is part of MinGW and used to generate an import library to use the PythonXY.DLL
@Haydeman The Python 3.6 is fully supported and I think it says so on the web site.
@Haydeman Please get "other stuff" done. I am sure you can contribute elsewhere even more.
BTW: This issue is a perfect example of why using the Github issue tracker is generally a bad idea. It's too easy to report and people are quick to start fights that gain nothing.
If someone were so productive as to provide the output of --show-scons and potentially others as I request, I might add a warning about using TDM. As it stands, specifically standalone mode is very demanding about the C runtime, standalone for other GCC variants might not even be feasible. I clearly am not interested in doing it myself.
@ThomasLecocq I put this on needs_volunteer, you are welcome to try and figure out, if gendef.exe is needed with TDM in the first place, and how to support it. Ought to be fiddling mostly. And maybe the shell APIs do not work as needed. If you work on that and get stuck, I might decide to help. Otherwise I am out of this issue.

@kayhayen TDM was just installed and working for me, only reason I advertised for it. I should definitively switch to MINGW (mingw64?).
The OP didn't use TDM, but mingw, it seems. But the OP didn't provide much details, at all. So no, the title shouldn't be changed to TDM-related AFAIK.
One option for avoiding that github issue tracker frenzy is to use github templates for issues, as done for  obspy for example: https://github.com/obspy/obspy/issues/new
You can close the issue, TDM works for me but I'll follow your advice and switch to mingw !
Cheers from Brussels,

@ThomasLecocq The MinGW and MinGW64 are two different beasts. One is supported, the other is not. I put a prominent note in the user manual about it. But who reads that anyway.
@ThomasLecocq I don't mind using TDM if it works. I do know that Cygwin does not. And surely you can imagine that I can for the life of it not be bothered to make every Windows compiler work and bother with its shortcomings.
@ThomasLecocq I will definitely look into that template issue. It's a good point to bring up typical issues, like e.g. using MinGW over MinGW64. However I would prefer for Nuitka to be able to detect all those, and warn/error about not supporting it directly.

@kayhayen hehe, yep, I actually read it :) but you know, memory... :-) So yep, I have MINGW64 now and it works fine for my --module case. I tried a simple --standalone, all OK (as with my TDM-GCC+gendef install before, but seems faster). Then a very complex one (including obspy == lots of dependencies (matplotlib, scipy, etc), that fails. Now time to read the doc and understand more what's under the hood and how to debug properly.

I am in fact so happy with MinGW64 and winlibs, I won't consider the other C compiler variants of gcc on Windows to be worth the effort.

eheh, someone's cleaning old issues here :-) 👍

It was in fact kept open on purpose, as a landing spot for people that would want to add support for Cygwin or TDM, however, since now LTO is supported on Windows with gcc from MinGW64, and the integration with the automatic download is so easy with winlibs, I am letting go of this idea forever.


Enable Void return type mapper methods

Expanding 'returnsVoid' boolean to include 'Void' return type method signatures would allow mybatis methods to be passed as implementations of java 8 Function interface.
Please let me know if I've made any mistakes, or should make any changes or corrections. Thanks!

Hi @johhud1 ,
Thank you for the PR and I'm sorry for a late reply!
I think you need to use Consumer instead of Function.
Or, one of the answers to the following SO questions may be helpful.
https://stackoverflow.com/q/29945627
https://stackoverflow.com/q/14319787
Whatever you are trying to achieve, declaring a method with Void return type does not seem to be the right solution.

I've closed this because no reply.


[CSL-2354] Merge master to develop

Will also try to test this locally with a dev cluster, and report back.

@nc6 Tested with a local cluster, so far so good:

[x] Import Genesis Wallet
[x] Restore a wallet from seed
[x] Send/receive a transaction
[x] Create a new wallet
[x] Generate new addresses

Finally merging this bad body, @nc6 !
As clarified with @domenkozar , the hydra failures are genuine but they affect only Mac devs building cardano via nix (using stack test worked fine on my machine).
Provided we open a follow-up PR using weeder to get rid of the unused deps, we are now ready to go. 🎉


Support release_path or current_path (if in standalone mode)

Since there is no release_path unless you're deploying, fall back to current_path.
We use Capistrano to run a lot of remote commands. In those cases, there's no release_path so rvm-capistrano fails to find the correct Ruby version. It is acceptable to use current_path in that case.

Anyone maintaining this project and/or evaluating PRs? I don't think Travis will pass since the specs (and Ruby) are out-of-date. This change should not break the build, though.

the failing tests are because of bad dependencies

for a full release the dependencies need to be fixed, it requires iterating through the gems and finding the old enough but newest version that supports given ruby - would you have some time for that?


Add updateAndPushDocs task

After this PR the producer only needs to execute
./gradlew updateAndPushDocs

from the java root directory in api-client-staging. This command will automatically update and push all the javadocs into Github.io
If you don't want the automatic push, you can still run:
./gradlew updateDocs

This command will only update and commit the docs so you can push them manually.

Codecov Report

Merging #1316 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1316   +/-   ##
=========================================
  Coverage     86.48%   86.48%
  Complexity     3836     3836
=========================================
  Files           378      378
  Lines         15328    15328
  Branches       1694     1694
=========================================
  Hits          13256    13256
  Misses         1622     1622
  Partials        450      450

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb472d3...7b5a0f7. Read the comment docs.

@michaelbausor  PTAL

LGTM


Pub/Sub README bug - should copy settings, not secret

Moved to buganizer (id 109937660). Closing.


Bug: when resizing in maximize mode, an unrecoverable bug occurs

Just see the gif below:

The resize must not be visible in maximized mode.
Tested with Fluent UI demo app.

This issue was fixed, disallowing window resizing when fullscreen or maximized


WSL error Wsl/0x80070422 (still not working after tried sc.exe config LxssManager start=auto)

Windows Version
Microsoft Windows [Version 10.0.22631.3374]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-2
Distro Version
No response
Other Software
No response
Repro Steps
type "wsl" in terminal
Expected Behavior
wsl works
Actual Behavior
The service cannot be started, either because it is disabled or because it has no enabled devices associated with it.
Error code: Wsl/0x80070422
Diagnostic Logs
No response

WslLogs-2024-04-23_20-31-16.zip

WslLogs-2024-04-23_20-31-16.zip

@keranrong I had the same issue, I fixed it by, opening the the "Services" app, then look for "WSL Service"
Double click "WSL Service" and set 'Startup type' as 'Manual'.

@keranrong: I do see that wslservice is set to Disabled. Does configuring it as Manual solve the issue ?
You can do this via:
sc.exe config wslservice start= demand

Also FYI Antiviruses might be disabling wslservice, so you might need to add exclusion rules for that.

Yes, I think it is because of my antivirus software (Avast), I just disabled part of its scanning. Thanks so much for your help, everyone!!


Feature request (send links of web pages)

Is your feature request related to a problem? Please describe.
I don't like the thing that you can't send links of web pages
Describe the solution you'd like
We can send link to the page by typing it or maybe with drag and drop
Describe alternatives you've considered
No response
Additional context
No response

You can send links already. It is just a text message.

You can send links already. It is just a text message

Does it download a txt file on the pc?

No, except you send multiple text messages

Closing this as sending links is already possible.


Maybe a bug regarding the labels of the symbol table

Hello,
I am trying to use yosys to generate an AIGER circuit from a Verilog file. I especially need the generated AIGER symbol table to use the names specified in the Verilog file for the inputs, outputs etc.
For that, I tried using the following command: yosys -p "synth; abc -script abc.script" input_file.v with the abc.script containing several commands and ending with write_aiger -s out.aig.
However, I observed that the symbol table generated like that did not use the names used in the Verilog input file but rather some possibly default values like n0, n1.
In order to debug this, I tried running the commands seperately by first calling yosys and there running first read_verilog input_file.v, then synth and then write_blif test.blif (in order to be able to switch to yosys-abc). Then I exit yosys and start yosys-abc, where I first executed read_blif test.bilf before running the commands contained in abc.script, the last one being write_aiger -s out.aig. To my surprise, I observed that the symbol table now contained the desired labels.
So I added a write_blif and a read_blif step to my command resulting in yosys -p "synth; write_blif test.blif; abc -script abc_2.script" input_file.v where the abc_2.script is the same as the abc.script but with a read_blif test.blif command added to the beginning of the file. Running the command like this again resulted in the desired output regarding the symbol table.
I am now wondering why the intermediate writing and reading of the BLIF file makes a difference at all? I would have expected, that all necessary information is also passed internally from yosys to yosys-abc directly and that there would be no need to write a temporary BLIF file. However, exactly this seems to make a difference, so maybe there is a bug or I am overlooking something?
I am really looking forward to better understanding this issue and thank you in advance for all explanations offered. Please let me know if you need more information in order to be able to reproduce this issue.
Best regards,
Norine

For that, I tried using the following command: yosys -p "synth; abc -script abc.script" input_file.v with the abc.script containing several commands and ending with write_aiger -s out.aig.

This is nonsense. The "abc" commands purpose in Yosys is to pass (parts of) a design through ABC. In many cases the circuit(s) that ABC sees in this flow are not even the entire design.
For example, unless the -dff option to Yosys' abc command is used, the command will only pass the combinatorical paths in the design to ABC. In such cases the circuit ABC sees does not contain any FFs.
If you want to further process the design in ABC after having done high-level processing in Yosys, simply write it to e.g. a BLIF file with write_blif and then read that BLIF file in ABC.
If you just want to generate AIGER, there is no need to use ABCs write_aiger at all. There is a native write_aiger command in Yosys.


Error executing

Error executing callback ui_tabs_callback for D:\stable-diffusion-portable-main\extensions\SD-Prompt-Enhancer\scripts\sd_prompt_enhancer.py
Traceback (most recent call last):
  File "D:\stable-diffusion-portable-main\modules\script_callbacks.py", line 151, in ui_tabs_callback
    res += c.callback() or []
  File "D:\stable-diffusion-portable-main\extensions\SD-Prompt-Enhancer\scripts\sd_prompt_enhancer.py", line 191, in on_ui_tabs
    token_list = sorted(make_token_list(all_sections))
  File "D:\stable-diffusion-portable-main\extensions\SD-Prompt-Enhancer\scripts\extra_helpers\utils.py", line 11, in make_token_list
    parse_and_add(ret_list, section.name)
  File "D:\stable-diffusion-portable-main\extensions\SD-Prompt-Enhancer\scripts\extra_helpers\utils.py", line 27, in parse_and_add
    words = re.findall(r'\b\w*[a-zA-Z]\w*\b', str_to_parse)
  File "D:\stable-diffusion-portable-main\python\lib\re.py", line 240, in findall
    return _compile(pattern, flags).findall(string)
TypeError: expected string or bytes-like object

I found the reason for this error is the file brutaltruthlinux929_tags .csv, if I delete this file, the extension starts without errors. So could you check it, please?

This issue is caused by empty cells in between populated cells in a csv file.  I patched the parsing error but I will continue to develop a method to ignore empty sandwiched cells.


chore: bdd-spring-1585491786 to 0.0.1

chore: Promote bdd-spring-1585491786 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


login_call_resetPassword

🍰 Pullrequest

Implement the existing calls:

resetpassword
checkEmail
loginViaEmailVerificationCode
on Apollo.

Multiple processes will be unified and simplified:

On Register -> send EMail -> set Password & Activate -> Login
On Forgot Password -> send EMail -> set Password -> Login
On NoPassword but Activated -> send Email -> set Password & Activate -> Login (legacy)

Following Calls will be implemented:

requestSetPassword
setPassword

Furthermore the two-step-call process will be a one-step-call process.

Before: EMail Link -> Call for Login on open page-> Call for Reset Password/Activate Account on submit
After: EMail Link -> Call for Reset Password/Activate Account on submit

Issues

fixes #836
fixes #837
fixes #833
includes #1131

Todo

[x] remove checkEmail & loginViaEmailVerificationCode calls
[x] combine checkEmail & loginViaEmailVerificationCode with resetPassword calls into single setPassword call
[x] integrate with createUser process
[x] integrate with loginUser process for legacy reasons & not activated
[ ] frontend implementations @Elweyn

frontend implementations TODOs

[ ] Withdraw password fields of registration form
[ ] Make a view that will handle (set password, Forgot password & loginViaEmailVerificationCode) same as thx.vue

i skipped the whole resetPassword test since it completely changed - I think we need to rewrite it once we done with this

I'd like to merge this and do the frontend part in another PR to reduce complexity. This means we reduce coverage requirement for the frontend to 84% again, since the whole check/reset-Password Component has to change and therefore no test is working anylonger on that. Whats your verdict @Mogge ?

@ulfgebhardt I changed the frontend on this branch!

In case a User has not activated his email/account and try to login => get's redirected to /reset/login that shows a message to check his email to activate his account!
In case a User sends a setPassword and get's an optin expired => Users get's redirected to the resetPassword page with a new message that says optin has expired want a new?


Processing data

Completed Project requirements
Create models

Create model classes for all entities as shown in the ERD diagram.
Set up associations between models.

Use models to insert data

Open rails console for your project.
Create at least one user by running the following code:   first_user = User.create(name: 'Tom', photo: 'https://unsplash.com/photos/F_-0BxGuVvo', bio: 'Teacher from Mexico.')
   second_user = User.create(name: 'Lilly', photo: 'https://unsplash.com/photos/F_-0BxGuVvo', bio: 'Teacher from Poland.')

Create at least 4 posts written by one of the users you created by running the following code:   first_post = Post.create(author: first_user, title: 'Hello', text: 'This is my first post')

Create at least 6 posts comments for one of the posts you created by running the following code:   Comment.create(post: first_post, author: second_user, text: 'Hi Tom!' )

Use other CRUD methods to find, update and delete entities.

Create custom methods
Your models should include some additional methods.

Users

A method that returns the 3 most recent posts for a given user.

Posts

A method that updates the posts counter for a user.
A method which returns the 5 most recent comments for a given post.

Comments

A method that updates the comments counter for a post.

Likes

A method that updates the likes counter for a post.

note

when you create new likes and posts you should add save to them to commit the changes


Keyboard navigation support

child of #1
Keyboard input
No strict requirements how. This is a good candidate for iteration during development.

What is supposed to be added here?
Right now, because we rely on vaadin-combo-box, keyboard navigation works out of the box, focusing, blurring, arrows and enter keys work as expected when selecting an item.  User can also write a value in the text-field, and when the value is in the combo it is selected.
The only missing part might be whether we want to allow filtering items while the user types

Functionality was discussed with @jouni .
Final decision was not to show dropdown when step is less than 15 mins

Right now, it will be quite difficult to reach e.g. 23:30 with keyboard when precision is 60 or 1 second.
Probably we need to focus by sections as native does, and increase each section.
I'm thinking that we might reuse native accessibility by configuring native input as type=time


bug: Types not visible in trouble document symbols sidebar

Did you check docs and existing issues?

[X] I have read all the trouble.nvim docs
[X] I have searched the existing issues of trouble.nvim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.0 Build type: Release LuaJIT 2.1.1716656478
Operating system/version
ArchLinux, kernel 6.9.3
Describe the bug
TypeScript types not visible in symbols panel, only interfaces.

Steps To Reproduce

load nvim config: https://github.com/zayihu/dotfiles/tree/main/nvim
Open project folder in nvim.
Open TypeScript types file.
Interfaces are visible as document symbols, types are not.

Expected Behavior
Expecting TypeScript types to be visible as doc symbols too.
Repro
No response

If you use :Trouble symbols, then there's a filter added to only show the most relevant kinds.
See the config at https://github.com/folke/trouble.nvim?tab=readme-ov-file#-configuration
I just checked and it seems that type defs have the kind Variable, which is weird tbh.
You can change the filter to inucde those or to include all.
You can also see all of them by using :Trouble lsp_document_symbols instead

Thank you very much! Will try.


Setup plugins-java-base and plugins-groovy

Extract code from plugins into 2 new JVM platform projects.
This is a first step.  There is too much code in plugins-java-base and splitting that project further is an obvious next step.

@bot-gradle test QFL

I've triggered the following builds for you. Click here to see all build failures.

QuickFeedbackLinux build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@jvandort Suggested the JavaPluginHelper should live next to the java plugin, as it works hand-in-hand with that class.
There are unfortunately some problems with this currently:

Class org.gradle.api.plugins.internal.JavaPluginHelper, referenced in method GroovyPlugin.configureGroovydoc(Project), will not be accessible from module gradle.plugins-groovy.main
Class org.gradle.api.plugins.internal.JavaPluginHelper, referenced in constructor DefaultJavaResolutionConsistency.DefaultJavaResolutionConsistency(Project, SourceSetContainer, ConfigurationContainer), will not be accessible from module gradle.plugins-java-base.main
Class org.gradle.api.plugins.internal.JavaPluginHelper, referenced in method DefaultJavaPluginExtension.withJavadocJar(), will not be accessible from module gradle.plugins-java-base.main
Class org.gradle.api.plugins.internal.JavaPluginHelper, referenced in method DefaultJavaPluginExtension.withSourcesJar(), will not be accessible from module gradle.plugins-java-base.main

The first of these will be solvable once there is a separate plugins-java project that plugins-groovy can depend upon.  This will be the next platformization PR after this one.
The other issues are less tractable.  It seems this class needs to live with java-base due to these usages - It is needed by the java extension, which is added by base.

After discussion, going to move JavaPlugin into plugins-java-base, renaming it to plugins-java in order to avoid difficult questions of dependencies between the java and java-base plugins for now.
This should remove the issues with the groovy plugin needing to reference the java plugin type by name as well.
After this issue is complete, https://github.com/gradle/gradle/issues/26300 will follow up with work that should allow splitting the java-base plugin into its own project.

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@jvandort This is updated and ready for review.

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

Also, what are your thoughts on squashing the commits of this PR? Given that some classes have moved multiple times in this PR, I think its worth squashing for the clean git history

Even if we do this temporarily, I think these should be merged eventually.

That's the goal.  After the work on consistent resolution.

Also, what are your thoughts on squashing the commits of this PR? Given that some classes have moved multiple times in this PR, I think its worth squashing for the clean git history

Sure.  I'll squash now.

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

PullRequestFeedback build

@bot-gitstream check all

I question the project's existence as a whole, and wonder how it really differs from platform-jvm. IMO, jvm isn't a language and shouldn't have a _language-` project.

That project existed prior to this PR.  Reassessing the need for a separate language-jvm and platform-jvm is a good idea, but out of scope for this change, which is aiming to get JVM code out of a mixed project and into /platforms.  We should save this for after we have extract all JVM code into the platform.
I'd expect we'll be able to find many similar reorganizations that might simplify and reduce the number of JVM projects.

But in any case, it still seems odd that JvmComponentDependencies, DefaultJvmComponentDependencies, Jar, FeatureSpec, and JavaResolutionConsistency are in that project.

I disagree with moving these to plugins-java.  They aren't specific to the java plugin and should live in a dependency of that project so they can be directly referenced by, say, the groovy plugin, instead of as a transitive dependency of plugins-java.
The (very long-term) goal would be to have groovy/scala/kotlin no longer depend on java and instead depend on a java-base/jvm-base plugin only.

FeatureSpec and JavaResolutionConsistency are both only used by the java plugin extension. Why would they not belong with it?

FeatureSpec and JavaResolutionConsistency are both only used by the java plugin extension. Why would they not belong with it?

The java plugin extension is used by more than just the java plugin though.

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


chore: don't publish ReactiveUI-Core as package no longer exists

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix ish. Remove the "Core" publish target, which was removed during the merge.
It's possible that the target should actually be kept, in which case we need to reinstate it in nuget/csproj generation.
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements

[ ] The commit follows our guidelines: https://github.com/reactiveui/reactiveui#contribute
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:

Coverage remained the same at 66.835% when pulling 27e9f4ba139b66c769d2723575883464d54ae221 on olevett:remove-core-target into 775aa7cf91be6b28897c6bc7c955f8c9e9350e20 on reactiveui:develop.

nah; wrong approach. I want to keep the core package. Working on packaging now. Check Slack for some more insights.

More slack discussion on this around https://reactivex.slack.com/archives/C02AJB872/p1495795159523437

Coverage remained the same at 66.835% when pulling 27e9f4ba139b66c769d2723575883464d54ae221 on olevett:remove-core-target into 775aa7cf91be6b28897c6bc7c955f8c9e9350e20 on reactiveui:develop.

Had a change of heart on this one.
a) using reactiveui means the NuGet count on the main package is higher. (i.e. marketing)
b) couldn't find a compelling reason to continue using a metapackage.
c) undoing this won't be so hard for users in the future if this turns out to be bad idea (tm)


CachedLanguageName not set on Windows 8.1/10

CachedLanguageName determines the text that shows up in the keyboard selection widget in the task bar. This is currently not set due to a regression, leading to languages unknown to the core NLS APIs in Windows to show up as "<English Language Name> (bcp47-Latn)", such as "Võro kiil (vro-Latn)".

Should be fixed in v0.4.1.


Fix compiler warning on AWSClient.swift

Fix Swift compiler warning on line 166:

/workspace/.build/checkouts/aws-sdk-swift-core/Sources/AWSSDKSwiftCore/AWSClient.swift:166:9: warning: using '_' to ignore the result of a Void-returning function is redundant
_ = credentialProvider.shutdown(on: eventLoop).whenComplete { _ in
^~~~

This fix is already on the main branch

Good to know. What is the purpose of the 5.x.x branch?

I do all my 5.x.x released off the 5.x.x branch. I merge main into 5.x.x just before doing a release. I cannot remember the exact reason I needed a separate branch at this stage, but it's there now. I do the equivalent in the aws-sdk-swift repo to avoid swapping the version of aws-sdk-swift-core in Package.swift from "from: 5.0.0-alpha" to "main" repeatedly as I make releases.

Sounds good, thank you for taking time to explain it.


Changing UI of error 404 page and adding timer

I will change the UI of error 404 page and will make it more attractive, also I will add a timer so that after a certain the redirection will happen itself to homepage.

@sk66641 Please assign me this issue under gssoc'24.

@sk66641 Change the labels as level 2.


Improve LHS navigation

Make the Left Nav bar independently scrollable
Allow the top-level sections to be collapsable, so we can navigate the index easier.

https://github.com/citusdata/citus_docs/pull/416 ran into some trouble given the current theme styling. The PR is closed now, but contains useful comments for when we investigate changing either our theme or docs generation system.

Renamed this since the menu redesign will take care of the independent scrolling aspect.

There are two things that make this pretty difficult.
First, I thought I could override the menu markup to use a special html tag called <summary> for the open/close toggle. For instance:

Click me!
The fun stuff inside

<!-- the code for the above -->
<details>
<summary>Click me!</summary>
The fun stuff inside
</details>

However the markup used within the menu is hard-coded deep inside Sphinx, not in the theme.
Next, the open or closed status has to be tied to which url you're on. For instance if the user visits https://docs.citusdata.com/en/v7.3/get_started/concepts.html then the Get Started section needs to be opened by default. This state is managed with a combination of sphinx adding a "current" class to the open menu item markup, and javascript to toggleCurrent on navigation clicks.
To get collapsible top level items we'd have to do one of three things

Fork sphinx itself and change the markup for the menu. Not sure how to use a sphinx fork on RTD hosting  though. Also the changed markup would probably mess with existing javascript like toggleCurrent.
Add heavy javascript that works alongside the script from the theme to hide/show sections of the menu. Seems fragile and complicated.
Change the structure of each ReStructuredText section so that they all have one top-level header, and remove captions from the main menu. This would change the look of the menu however since those captions are brighter and slightly set apart from the menu items.

These options are all difficult, and imho don't seem worth it. A change this big would be reason to probably look at an entirely different docs system. (Unless there's another option that I overlooked.)
/cc @samay-sharma

(From in-person discussion: Decided to do option 3)


Proofread several documents

about.pod6, community.pod6, faq.pod6 and tables.pod6
Changes include minor rewording, text reflow, replacing indented code samples
with =code directives-wrapped code samples, order book list in faq.pod6 alphabetically, etc.

Tests are failing:
t/02-pod-valid.t ........6/392# There's been this error in file: doc/Language/about.pod6
# ===SORRY!=== Error while compiling /test/doc/Language/about.pod6
# Expected "=end pod" to terminate "=begin pod
#
# There's been this error in file: doc/Language/about.pod6
# "; found "=end code" instead.
# at /test/doc/Language/about.pod6:97
# ------> =end code⏏<EOL>

Yep, I fixed that before. You need to be careful when deindenting code that includes pod.

We don't force any kind of style there: they can use =for, =begin code or simple indentation; and those can use indentation too.

While proofreading some of the documents, I came across 4-space indented code samples that were rendered as code but still with four spaces and code samples wrapped in =code directives that were still 4-space indented. I figured that using code directives (both for and =begin/=end), instead of indentation, was the most sensible and meaningful thing (at least for someone reading the pod files) to do.

Unless it makes the code longer than 80 characters, it's probably better to leave it alone.

I'll be more careful moving forward ;-).


Module not found: Error: Can't resolve 'child_process'

Hi folks! I installed catalog via the CLI and running into the following issues when I try catalog build or catalog start:
Module not found: Error: Can't resolve 'child_process' in
./internal/utils.js,
./node_modules/happypack/lib/HappyThread.js,
./node_modules/node-notifier/lib/utils.js

So far, after installing, I've added catalog/babel to my .babelrc and Markdown loaders as specified in the guide. Any ideas on what might be going on?
FWIW, I'm on Node 8 and my regular builds seem to be working fine without any such error.
Thank you!

Hi!
From the trace it looks like an issue outside of Catalog (it uses neither of those modules). My best guess is maybe a dependency conflict.
If you can share a setup that I can run, I can try to investigate but otherwise it’s hard to tell what’s going on.


make sure it works for multiple languages

the only thing I could think of might break are the getBlocksWith... functions, but it'd be best to test for everything once they add testable localization

should be resolved now that onChange uses the block type (which should always be english 📦 )


If vulkan version miss some .spv files?

When I run PBR -vulkan on Windows, it first threw the VK_ERROR_LAYER_NOT_PRESENT ERROR,
then I modified the related code not to load layers, then run again, it threw the Error: Could not open file: shaders/spirv/tonemap_vs.spv
But I didn't find the tonemap_vs.spv in the shaders dir. Is there anything missed?

I may got that spv should be translated from glsl. Maybe my vulkan version is the newest, so it don't support "VK_LAYER_KHRONOS_validation"
But it still can't work after I change the layer, because it has no output of spv files. Maybe it's not compatible with the new version?

So I have to solve it by manually add .psv files like this:
void add_spirv(const char* shadername, const char* stage)
{
	char cmdline[225];
	sprintf(cmdline, "glslangValidator -V -S %s -o \".\\shaders\\spirv\\%s.spv\" \".\\shaders\\glsl\\%s.glsl\" ", stage, shadername, shadername);
	std::cout << cmdline << std::endl;
	system(cmdline);
}

...

add_spirv("equirect2cube_cs", "comp");
add_spirv("irmap_cs", "comp");
add_spirv("pbr_fs", "frag");
add_spirv("pbr_vs", "vert");
add_spirv("skybox_fs", "frag");
add_spirv("skybox_vs", "vert");
add_spirv("spbrdf_cs", "comp");
add_spirv("spmap_cs", "comp");
add_spirv("tonemap_fs", "frag");
add_spirv("tonemap_vs", "vert");

then it can work at least...


"Valea Șesii" is listed in the drop-down menu

Description:
"Valea Șesii" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Valea Șesii" in the search bar.

Expected results
The location is listed in the drop-down menu as "Valea Șesii, Alba (Lupșa)".


[PROJECT] Title and Link

This repo has currently the following title and link:

An open source smart contract platform https://github.com/EOSIO/eos

The eos.io site mentions

The most powerful infrastructure for decentralized applications

This should be possibly aligned to be at least similar (branding thing).
But in any case, the link of the repo here should not point to the repo, but to the most relevant site (I assume the developer-site https://developers.eos.io)

@taokayan , are you joking?

He’s not joking. He’s competing against 2 others for my coveted “Closer of Issues” title.

Link fixed :)


tests: Add the possibility to change stream_port

This change adds the possibility to change the default
stream_port where cri-o listens.
Signed-off-by: Salvador Fuentes<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

/ok-to-test

This change adds the possibility to change the default
stream_port where cri-o listens.

@chavafg are you having issues right now in kata requiring this change? just wondering, it looks fine

@runcom not really, but now docker 18.06 uses this same port. So if having the docker service up and running the cri-o tests, leads to this error:
# time="2018-07-19 10:16:17.758637844Z" level=error msg="Failed to start streaming server: listen tcp <IP_ADDRESS>:10010: bind: address already in use"

/test all


Quicksign dependency

Whats the best way to remove any dependency to quicksight (basically not use quicksight at all but keep everything else)?

Hey @bazooka720, thanks for your question and marking the enhancement label. You can customize the solution code to remove the dependency to Amazon QuickSight by removing the nested stack QuickSightStack in the code and rebuilding the solution.
In this solution, we specifically designed the QuickSight portion of the functionality as nested stack for better separation. Refer to https://github.com/awslabs/discovering-hot-topics-using-machine-learning/blob/5aba8dcf98d9d64b985f47d0875962912c7ae50b/source/lib/discovering-hot-topics-stack.ts#L132 and other references to QuickSight and the nested template qsNestedTemplate variable in the same file. One option is to add a CfnParameter to the CloudFormation of the solution to conditionally create or not create the QuickSight resources. Another option is to remove the code for creation of QuickSightStack object in source/lib/discovering-hot-topics-stack.ts and its related code (also in other files).
Are you looking for an option to enable / disable Amazon QuickSight functionality when deploying the solution? Or an option to remove (or not use) the Amazon QuickSight code during the build of the solution?

Hey @bazooka720, closing this issue for now, but please let us know if you have any further questions/suggestions to discuss. Thanks.

Hey @bazooka720, closing this issue for now, but please let us know if you have any further questions/suggestions to discuss. Thanks.


JBDS-4449 Reselect vbox checkbox after repeated unsuccessful detection

Codecov Report

Merging #762 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
- Coverage   98.67%   98.53%   -0.14%
==========================================
  Files          31       31
  Lines        2640     2798     +158
  Branches      230      409     +179
==========================================
+ Hits         2605     2757     +152
+ Misses         35       31       -4
- Partials        0       10      +10

Impacted Files
Coverage Δ

browser/model/virtualbox.js
93.42% <100%> (+1.29%)
:arrow_up:

browser/model/jbosseap.js
96.9% <0%> (-2.01%)
:arrow_down:

browser/model/helpers/downloader.js
96.94% <0%> (-1.52%)
:arrow_down:

browser/pages/confirm/controller.js
91.16% <0%> (-1.33%)
:arrow_down:

browser/services/componentLoader.js
98.78% <0%> (-1.22%)
:arrow_down:

browser/model/jdk-install.js
98.84% <0%> (-0.56%)
:arrow_down:

browser/pages/location/controller.js
100% <0%> (ø)
:arrow_up:

browser/model/devstudio.js
100% <0%> (ø)
:arrow_up:

browser/main.js
100% <0%> (ø)
:arrow_up:

browser/model/helpers/installer.js
100% <0%> (ø)
:arrow_up:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cfb46b...11d6832. Read the comment docs.


Switch away from WS

I think switching away from the WS lib might be a good idea, see here:

https://github.com/websockets/ws/issues/751
https://github.com/websockets/ws/issues/629
184 open issues
39 open PRs

Socket.IO is probably the best alternative choice, as others (like uWS) aren't easy to compile on Windows.

In fact, I was thinking about switching to uWS because of performance, Socket.IO does to much IMHO.
If you've got some problem on Windows, perhaps you should consider using Docker, the beta for Windows and OSX works very well.

I thought about uWS as well, but sadly it doesn't compile on Windows yet.

Noticed that there are potential problems with ws as Gemnasium was warning about them:

Another potential reason to consider switching from it?

except from the required work, no :) Will consider it for Mozaïk 2

@kurtextrem https://github.com/plouc/mozaik/pull/103/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R65 :)

Cool - I'd say this counts as fixed. If anyone needs a hacky solution for v1 contact me.


Build error on macOS

When trying to build DJV on macOS (10.14.6) I get the following error:
[ 92%] Linking CXX executable ../../build/bin/djvTest
Undefined symbols for architecture x86_64:
  "_WebPConfigInitInternal", referenced from:
      _TWebPSetupEncode in libtiff.a(tif_webp.c.o)
  "_WebPEncode", referenced from:
      _TWebPPostEncode in libtiff.a(tif_webp.c.o)
  "_WebPFreeDecBuffer", referenced from:
      _TWebPPreDecode in libtiff.a(tif_webp.c.o)
      _TWebPSetupEncode in libtiff.a(tif_webp.c.o)
      _TWebPCleanup in libtiff.a(tif_webp.c.o)
  "_WebPIAppend", referenced from:
      _TWebPDecode in libtiff.a(tif_webp.c.o)
  "_WebPIDecGetRGB", referenced from:
      _TWebPDecode in libtiff.a(tif_webp.c.o)
  "_WebPIDelete", referenced from:
      _TWebPPreDecode in libtiff.a(tif_webp.c.o)
      _TWebPSetupEncode in libtiff.a(tif_webp.c.o)
      _TWebPCleanup in libtiff.a(tif_webp.c.o)
  "_WebPINewDecoder", referenced from:
      _TWebPPreDecode in libtiff.a(tif_webp.c.o)
  "_WebPInitDecBufferInternal", referenced from:
      _WebPInitDecBuffer in libtiff.a(tif_webp.c.o)
  "_WebPPictureFree", referenced from:
      _TWebPSetupDecode in libtiff.a(tif_webp.c.o)
      _TWebPCleanup in libtiff.a(tif_webp.c.o)
  "_WebPPictureImportRGB", referenced from:
      _TWebPPostEncode in libtiff.a(tif_webp.c.o)
  "_WebPPictureImportRGBA", referenced from:
      _TWebPPostEncode in libtiff.a(tif_webp.c.o)
  "_WebPPictureInitInternal", referenced from:
      _WebPPictureInit in libtiff.a(tif_webp.c.o)
  "_WebPValidateConfig", referenced from:
      _TWebPSetupEncode in libtiff.a(tif_webp.c.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [build/bin/djvTest] Error 1
make[1]: *** [tests/djvTest/CMakeFiles/djvTest.dir/all] Error 2
make: *** [all] Error 2

This is probably not enough info, ket me know how i can provide more.

Hi,
I haven't seen that one before; are you building the latest code from the master branch? Also could you include the CMake command you used to configure the build?
Thanks, Darby

Yes, latest master, following the README.md build instructions.
cmake ../djv-git -DCMAKE_BUILD_TYPE=Debug

I just checked in a change that should hopefully fix this, try fetching the latest and building again.
The error was coming from the libtiff library, which apparently now supports webp compression which I didn't know about. I've disabled it for now, but if it's useful to try and get it working a separate issue can be created for it.

Thanks for info and for the fix. I can build now!