HBASE-24267 add limit support for scan in rest api

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 27s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 49s
master passed

+1 :green_heart:
compile
1m 14s
master passed

+1 :green_heart:
shadedjars
5m 35s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 41s
the patch passed

+1 :green_heart:
compile
1m 12s
the patch passed

+1 :green_heart:
javac
1m 12s
the patch passed

+1 :green_heart:
shadedjars
5m 29s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 29s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 51s
hbase-protocol-shaded in the patch passed.

-1 :x:
unit
1m 10s
hbase-rest in the patch failed.

27m 27s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux c8ef6f5d28c8 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84f2e95dd5

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/testReport/

Max. process+thread count
434 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 52s
the patch passed

+1 :green_heart:
compile
1m 23s
the patch passed

+1 :green_heart:
javac
1m 23s
the patch passed

+1 :green_heart:
shadedjars
5m 43s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  1s
hbase-protocol-shaded in the patch passed.

-1 :x:
unit
1m  4s
hbase-rest in the patch failed.

27m 46s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 44ca5771bb35 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84f2e95dd5

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/testReport/

Max. process+thread count
469 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 29s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 33s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 34s
master passed

+1 :green_heart:
checkstyle
0m 31s
master passed

+1 :green_heart:
spotbugs
3m 54s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 16s
the patch passed

-0 :warning:
checkstyle
0m 19s
hbase-rest: The patch generated 2 new + 129 unchanged - 0 fixed = 131 total (was 129)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m  5s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
hbaseprotoc
1m 25s
the patch passed

+1 :green_heart:
spotbugs
4m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.

37m 28s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
dupname asflicense cc hbaseprotoc prototool spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 8af1bd5b2dab 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84f2e95dd5

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
4m  5s
master passed

+1 :green_heart:
compile
1m 23s
master passed

+1 :green_heart:
shadedjars
6m 45s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 15s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m 20s
the patch passed

+1 :green_heart:
compile
1m 26s
the patch passed

+1 :green_heart:
javac
1m 26s
the patch passed

+1 :green_heart:
shadedjars
6m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 54s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
3m 36s
hbase-rest in the patch passed.

32m 55s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux c75b9f1daac1 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84f2e95dd5

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/2/testReport/

Max. process+thread count
2652 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 48s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 48s
master passed

+1 :green_heart:
checkstyle
0m 33s
master passed

+1 :green_heart:
spotbugs
4m 15s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 32s
the patch passed

-0 :warning:
checkstyle
0m 21s
hbase-rest: The patch generated 4 new + 129 unchanged - 0 fixed = 133 total (was 129)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 26s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
hbaseprotoc
1m 30s
the patch passed

+1 :green_heart:
spotbugs
4m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

41m  8s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
dupname asflicense cc hbaseprotoc prototool spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 9c4d0a803fa0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84f2e95dd5

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 17s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 18s
the patch passed

+1 :green_heart:
compile
1m 43s
the patch passed

+1 :green_heart:
javac
1m 43s
the patch passed

+1 :green_heart:
shadedjars
6m 23s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 21s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  7s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
3m 18s
hbase-rest in the patch passed.

37m 10s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 2de740587328 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 84f2e95dd5

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/2/testReport/

Max. process+thread count
2308 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 37s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 37s
master passed

+1 :green_heart:
compile
1m  9s
master passed

+1 :green_heart:
shadedjars
5m  3s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
5m 10s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 46s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
3m 47s
hbase-rest in the patch passed.

27m 51s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 8341e8b1afe4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7f6672eb9e

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/3/testReport/

Max. process+thread count
2590 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  6s
the patch passed

+1 :green_heart:
compile
1m 26s
the patch passed

+1 :green_heart:
javac
1m 26s
the patch passed

+1 :green_heart:
shadedjars
5m 31s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 23s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  9s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
3m 21s
hbase-rest in the patch passed.

30m 32s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 6d8e949461ef 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7f6672eb9e

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/3/testReport/

Max. process+thread count
2610 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 55s
master passed

+1 :green_heart:
checkstyle
0m 27s
master passed

+1 :green_heart:
spotbugs
4m  1s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 12s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 38s
the patch passed

-0 :warning:
checkstyle
0m 19s
hbase-rest: The patch generated 4 new + 129 unchanged - 0 fixed = 133 total (was 129)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 18s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
hbaseprotoc
1m 26s
the patch passed

+1 :green_heart:
spotbugs
4m 18s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

40m 34s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
dupname asflicense cc hbaseprotoc prototool spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 259f61c342f2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 7f6672eb9e

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

LGTM, just a small nit on the numbering of ScannerMessage fields, ain't sure if that's necessary or not.

Thanks for pointing out this problem, and it has been updated as recommended.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 52s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+0 :ok:
mvndep
0m 35s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 37s
master passed

+1 :green_heart:
compile
1m 12s
master passed

+1 :green_heart:
shadedjars
5m  9s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 30s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 16s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 25s
the patch passed

+1 :green_heart:
compile
1m 10s
the patch passed

+1 :green_heart:
javac
1m 10s
the patch passed

+1 :green_heart:
shadedjars
4m 57s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 44s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
3m 40s
hbase-rest in the patch passed.

32m  1s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 029cf46835e9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6eb5cafe34

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/4/testReport/

Max. process+thread count
2559 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
4m 51s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
prototool
0m  0s
prototool was not available.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+0 :ok:
mvndep
0m 36s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
3m 35s
master passed

+1 :green_heart:
checkstyle
0m 29s
master passed

+1 :green_heart:
spotbugs
3m 53s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 26s
the patch passed

-0 :warning:
checkstyle
0m 17s
hbase-rest: The patch generated 4 new + 129 unchanged - 0 fixed = 133 total (was 129)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 47s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
hbaseprotoc
1m 26s
the patch passed

+1 :green_heart:
spotbugs
4m 11s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 22s
The patch does not generate ASF License warnings.

42m 51s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
dupname asflicense cc hbaseprotoc prototool spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux cbc55d50982e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6eb5cafe34

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-rest.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 18s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 45s
the patch passed

+1 :green_heart:
compile
2m  1s
the patch passed

+1 :green_heart:
javac
2m  1s
the patch passed

+1 :green_heart:
shadedjars
7m  5s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 22s
hbase-rest in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  8s
hbase-protocol-shaded in the patch passed.

+1 :green_heart:
unit
4m 33s
hbase-rest in the patch passed.

45m 46s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1591

Optional Tests
unit javac javadoc shadedjars compile

uname
Linux 8ffd35ad3305 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 6eb5cafe34

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/4/testReport/

Max. process+thread count
2136 (vs. ulimit of 12500)

modules
C: hbase-protocol-shaded hbase-rest U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1591/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Implement dry-run on new env creation

Was looking at wrong cmd (conda env): conda create has a dry-run flag, "-d".

Create fn-method in CondaEnvir class to be run after .create_new_env_tml in cli.main
Update README

Not possible!
conda create can do a dry-run update with a file provided using the --file option, but this file cannot be a yaml file.
The file format required by conda create  is undocumented (afaik), but it is my educated guess that it is the conda format issued from conda export --explicit > file.txt command.


Render JSON docs [skip ci]

Docs for read/to_json were not rendering

Looks good to me.  Merging.  At some point in the future we should also try to add See Also sections to all of these functions to improve linking.


common: return strconv.Atoi's error when parsing whole dollar amount

Issue: https://github.com/moov-io/paygate/issues/202

Codecov Report

Merging #203 into master will decrease coverage by 4.28%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   56.14%   51.86%   -4.29%
==========================================
  Files          30       30
  Lines        4018     4020       +2
==========================================
- Hits         2256     2085     -171
- Misses       1299     1498     +199
+ Partials      463      437      -26

Impacted Files
Coverage Δ

common.go
85% <100%> (+0.38%)
:arrow_up:

accounts.go
10.95% <0%> (-69.87%)
:arrow_down:

internal/database/mysql.go
11.11% <0%> (-52.78%)
:arrow_down:

ofac.go
38.65% <0%> (-35.3%)
:arrow_down:

internal/filetransfer/sftp.go
42.77% <0%> (-23.13%)
:arrow_down:

internal/filetransfer/config.go
55.11% <0%> (-0.79%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc6e57...3037082. Read the comment docs.


Auto-disconnection in some Android devices

Prerequisites

[X] I checked the documentation and FAQ without finding a solution
[X] I checked to make sure that this issue has not already been filed

Expected Behavior
Maintain the connection
Current Behavior
Devices disconnect after some seconds
Library version
3.2.0
Device
Samsung s22 ultra, Pixel, ..
Environment info
-

Steps to reproduce

Formatted code sample or link to a repository
-

Relevant log output
-

Additional information

Hi @intent-kacper-cyranowski !
As you said to me, I have opened a new issue. I am attaching the logs you asked me in https://github.com/dotintent/react-native-ble-plx/issues/1197#issuecomment-2204467303
EXPECTED BEHAVIOUR: the app connects to the device and ask for his state until the user closes the BLE connection manually
log.txt
BAD BEHAVIOUR: the app connects to the device and ask for his state but connection drops
log2.txt

Hi @joanmarcs
We have opened a ticket for your issue. I would like to clarify some information.
Did the error occurred on different devices then previously specified? Samsung and Pixel have their own SoC, and if error occurs only there it might be the cause.
You have mentioned that you are working with vehicle chargers, can you specify what is the device, or can you provide any other device on which you were able to reproduce the issue.
Everything that will help in reproducing and solving the issue is welcome.

Also observed with an ESP32 device.

Also get event disconnect after connect around 10-15 seconds, It's crazy

+1 @nhaduongc same here. Every few seconds, Android drops connection, reconnects, then drops connection again.

Solved with this workaround: https://github.com/dotintent/react-native-ble-plx/issues/1197#issuecomment-2256601221


[Feature] Control glue database/schema for tmp tables generated by incremental models

Is this your first time submitting a feature request?

[X] I have searched the existing issues, and I could not find an existing issue for this feature

Describe the feature
In case of incremental models tmp tables I would like to have control where the tmp table is going to be written.
It will be nice to have an additional parameter tmp_schema or schema_tmp that can be used in case of tmp tables.
Ideally those tmp tables are written in place not exposed to final users, that's why having control on such schema/glue db make sense.
If we take in mind also Lakeformation permissions make even more sense.
Describe alternatives you've considered
No response
Who will this benefit?
Use that don't want to expose tmp tables to final users that query their data-platform.
Are you interested in contributing this feature?
No response
Anything else?
No response

Covered by #659


Slow performance of ArangoDB while traversing a graph of 50+ depth and 200k+ nodes

My Environment

ArangoDB Version:        3.4.1
Storage Engine:             RocksDB
Deployment Mode:       Cluster
Deployment Strategy:   ArangoDB Starter
Configuration:               3 DB servers, 3 Coordinators 3 DB server
Infrastructure:               own
Operating System:        MacOS 10.13.6
Total RAM in your machine:    8 GB DDR3
Disks in use:        Macintosh HD
Used Package:              N/A

Component, Query & Data
Affected feature:
AQL query using web interface
Size of your Dataset on disk:
200mb
Replication Factor & Number of Shards (Cluster only):
6 shards, 1 replication
Problem:
I have a graph database on ArangoDB which have a node depth of around 100 levels and around 205k nodes for some users. For normal uses the AQL used to traverse the graph works well. But there are some scenarios on which the graph traversal is taking too much time, which are:
Calculating the maximum depth for some user
Calculating weight for a root node which have a node depth around 50+ and child node 200k+. Here weight is calculated by summing the weight of each child node.
Fetching all the nodes on a specific level for some node.
Results are attached with the ticket.
Explain has been already executed on these queries, but no specific suggestion was provided related to indexes. Default primary and edge key index are used
Expected result:
The time to traverse the graph should less then 10s.
ArangoPerformance.pdf

Yes, I also have this situation, very slow. Simply query of 20K+ edge node, it  spend 20s more, we need some help from here

With ArangoDB 3.4 being EOLed and  ArangoDB 3.7 I'm closing this as out of date.


Complete SERIAL data type support

SERIAL is introduce in #1493 but not completely supported. The following are what is missing currently:

[x] RETURN SERIAL values. Add SERIAL to Value and FlatTupleIterator.
[x] Expression evaluations over SERIAL. We should cast SERIAL to INT64 for expression evaluations.
[x] Updates. (Deletions should be handled automatically, no update is allowed on serial values, insertions need to be double checked)
[x] Allow SERIAL as non primary key properties in node table.
[x] Index lookup over SERIAL properties.
[x] Add SERIAL in apis (not prioritized).

Done in a serial of PRs (#3565, #3588)


Area Overload

My Pleasure. Thanks for accepting my pull request!
On Wed, Oct 7, 2020 at 2:20 AM Abraham Hernandez<EMAIL_ADDRESS>wrote:

Merged #81 https://github.com/AllAlgorithms/java/pull/81 into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AllAlgorithms/java/pull/81#event-3847507977, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AORWHDXCBRDCUZL7RJS4X7LSJN7INANCNFSM4SAELPQQ
.


Very little information is received when using try catch

when I use try catch and debugPrint it show some error below
try {
      final json = jsonDecode(res.body);
      final account = LoginResponse.fromMap(json);
      return account;
    }catch(e){
      debugPrint(e);
    }

[VERBOSE-2:ui_dart_state.cc(157)] Unhandled Exception: type 'NoSuchMethodError' is not a subtype of type 'String'
#0      NonUserApi.login (package:andes_mobile_user/src/commons/apis/nonuser.dart:54:18)
<asynchronous suspension>
#1      LoginControl.login (package:andes_mobile_user/src/commons/controllers/login.dart:57:27)
#2      _LoginPageState._validateForm (package:andes_mobile_user/src/commons/views/login.dart:247:16)
#3      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:706:14)
#4      _InkResponseState.build.<anonymous closure> (package:flutter/src/material/ink_well.dart:789:36)
#5      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
#6      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:486:11)
#7      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:264:5)
#8      BaseTapGestureRecognizer.handlePrimaryPointer (package:flutter/src/gestures/tap.dart:199:7)
#9      PrimaryPointerGe<…>

It is incomplete and I cannot detect the problem.
even if I changed debugPrint to print, all I got was
flutter: NoSuchMethodError: The method '*' was called on null.
Receiver: null
Tried calling: *(1000)

When I disable try catch, I receive the full error information and it leads me to the exact location of the error
final json = jsonDecode(res.body);
      final account = LoginResponse.fromMap(json);
      logs(account);
      return account;

[VERBOSE-2:ui_dart_state.cc(157)] Unhandled Exception: NoSuchMethodError: The method '*' was called on null.
Receiver: null
Tried calling: *(1000)
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:53:5)
#1      new DateTime.fromMillisecondsSinceEpoch (dart:core-patch/date_patch.dart:41:36)
#2      new InfoUser.fromMap (package:andes_mobile_user/src/commons/models/info_user.dart:31:26)
#3      new LoginResponse.fromMap (package:andes_mobile_user/src/commons/models/login_response.dart:13:26)
#4      NonUserApi.login (package:andes_mobile_user/src/commons/apis/nonuser.dart:50:37)
<asynchronous suspension>
#5      LoginControl.login (package:andes_mobile_user/src/commons/controllers/login.dart:57:27)
#6      _LoginPageState._validateForm (package:andes_mobile_user/src/commons/views/login.dart:247:16)
#7      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:706:14)
#8      _InkResponseState.build.<anonymous closure> (package:flutter/src/material/ink_well.dart:789:36)
#<…>

How can I use try catch and get all the error information?

you should also print the stackTrace:
try {

} catch (err, stackTrace) {
  debugPrint(err);
  debugPrint(stackTrace);
}

It worked ! Thanks :D


Make some models macroable

Hi,
Would it be an idea to make some models macroable.
For example I need to add an address to the order model. If the order
model was macroable I could add the relation like this:
Boot method in serviceprovider:
Illuminate\Database\Eloquent\Builder::macro(‘address’, function() {
    $model = $this->getModel();

    if($model instanceof App\Address) {
         return $model->belongsToMany(App\Address::class);
    }
    unset(static::$macros['address']);
    return $model->address();
 });

Would you accept a PR for this or is there a better way?
Thanks!

Hi @larsjanssen6 ,
I'm ok with making things macroable. Another way would be to make classes swappable by setting the class in the config, but that would take a lot of work.

Looks like this is not possible on models yet in Laravel:
https://github.com/laravel/ideas/issues/1870

For now I have overwritten the subscription class but maybe in the future we could add this macroable trait if it's supported would be nice :)

Yeah that was what I was afraid of with the macroable trait...
Just curious, how did you overwrite it?

@sandervanhooft I made a custom class and extend the Subscription mollie class (only need this for Laravel nova).

Good to know. Thanks!

I recently made a little package which allows to add macros to Eloquent models:
https://github.com/javoscript/laravel-macroable-models
Let me know if you try it out and if it is of any use! =)


Handle multiple selection

Summary
I need to choose more than one image and the result should be array of Uri to be used in the application
Android version
30
Impacted devices
all devices
Installation method
Gradle
SDK version
30
Other information

https://ibb.co/yNTjDnc

Screenshot to clarify the issue
(https://i.ibb.co/JcLJNRw/Screenshot-1622470271.png)

@michaelsam94 This feature is not yet available in ImagePicker.

@michaelsam94 This feature is not yet available in ImagePicker.

will it be available soon or in future plan?

It's in future plan.

+1

+1

+1


how to delete gperftools for build envoy

Title: One line description
Description:

Describe the desired behavior, what scenario it enables and how it
would be used.

I want build envoy for chinese cpu, but gperftools is not use for this, how to delete this
[optional Relevant Links:]

Any extra documentation required to understand the issue.

You can disable tcmalloc with
bazel build -c opt //source/exe:envoy-static --define=tcmalloc=disabled


fix: Don't inline normalizr into cjs

BREAKING CHANGE: Requires node 12
Motivation

Keep the same entities
class should inherit from class or new breaks

Solution

rollup is configured to keep external the packages in peerdeps, but since normalizr is transitive dep it was being inlined. it's really best to only import from things explicitly stated, so we move it to only import from endpoint
target node 12

oops, commited but didn't push the node12 stuff

cool, still LGTM but now it all makes sense


Revert "add prod app in manifest"

Reverts nyu-devops-2021-summer-promotions/promotions#136
It does not work stable at IBM cloud, and not it does not work, so we need to keep the other way.

Codecov Report

Merging #138 (2a62964) into main (7aaeb46) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   96.19%   96.19%
=======================================
  Files           5        5
  Lines         289      289
=======================================
  Hits          278      278
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aaeb46...2a62964. Read the comment docs.

IBM Cloud toolchain: Delivery Pipeline deployed promotions to dev, including commit f742e10e43e83dd48b4703dc334fc79994c2f555


feat(aws-iam): grants support non-identity principals

feat(aws-iam): grants support non-identity principals  …
Add support for non-identity Principals in grants (for example,
principals that represent accounts or organization IDs). For resources
that support them, the required IAM statements will be added to the
resource policy. For resources that don't support them (because they
don't have resource policies) an error will be thrown.
Add a new OrganizationPrincipal principal which represents all
identities in the given AWS Organization.
Fixes #236.

Pull Request Checklist

[x] Testing

Unit test added
CLI change?: manually run integration tests and paste output as a PR comment
cdk-init template change?: coordinated update of integration tests with team

[x] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated

[x] Title and Description

Change type: title prefixed with fix, feat will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[ ] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@rix0rrr  let us know when you want a re-review

I need to get around to it again. But nothing majorly blocking in the reviews so far it seems.

Ready for that re-review @eladb @RomainMuller

We agreed during a chat to make grant methods output an opaque type which will be produced by our grant method.
Also split out grant method into 2 flavours for the different code paths.

NuGet build error again. Seems to be getting worse?


Sample Powershell is not a sample its a solution

The "Sample Powershell Script" heading and section is misleading, because it is actually a solution to the firewall popup issue highlighted further up this page for Desktop clients. It should be highlighted and addressed as a solution in the Security and Compliance section and troubleshooting section. I'm also surprised there is not a option for this popup suppression fix via the the Teams/Office ADMX GPO template?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6457d204-d229-9154-28fd-ca9bbb4bddcd
Version Independent ID: f5d82846-41cb-3548-6997-ce23bd8f89c6
Content: Get clients for Microsoft Teams - Microsoft Teams
Content Source: Teams/get-clients.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@markszili Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@LolaJacobsen please can you assist. Should this be changed in the article?

Thanks for the heads up. I clarified the title and added a link from the Windows section of the article.


Is there a way to set the default-ulimits?

When using dockerd there is a way to set the default-ulimits for the containers created (https://docs.docker.com/engine/reference/commandline/dockerd/) is there something equivalent for containerd?
Apologies if this is a "bugs only" issue tracker.
Thanks

No there is not. In containerd, we don't really have daemon wide settings.  We keep things per container to keep it more flexible.  There are a few daemon wide "defaults" such as what snapshotter (overlay,btrfs) to use but other than that, it is based on the configuration you pass to each individual container.
I hope this helps!

I am also in search of a way to specify default ulimit values for containers with containerd, we use EKS for CI (very parallel, needs a lot of open files, pending signals and deep stacks) and before EKS 1.23 it was using Docker and we were able to set
/etc/docker/daemon.json:
"default-ulimits": {
    "stack": {
      "Name": "stack",
      "Hard": 67108864,
      "Soft": 67108864
    },
    "nofile": {
      "Name": "nofile",
      "Hard": 1024000,
      "Soft": 1024000
    },
    "sigpending": {
      "Name": "sigpending",
      "Hard": 512000,
      "Soft": 512000
    }
  }

Now with EKS 1.24+ it uses containerd it is honestly completely unclear so far on how does one set ulimit values with K8S + `containerd.
Reading everything I could find for few hours I came to following understanding and please correct me if I'm wrong:

Docker allowed setting default ulimits for continers (we used that, config attached)
containerd is designed with more flexibility in mind so it allows setting ulimits for each container without defaults (? but then some defaults seem to be present in code)
Kubernetes does not have a way to set default ulimits or override them for specific pod/container (!) and delegates that to be configured with container runtime, so it's a chicken and egg problem https://github.com/kubernetes/kubernetes/issues/3595
So users of Kubernetes + containerd are left stranded w/o a good way to set ulimits per container and/or default ulimits (?)

I'll be experimenting with system wide limits and restarting containerd to see whether it affects the limits of new containers, but briefly looking through the source code left me unclear so far.
Crosslinking other issues for context:

https://github.com/containerd/containerd/issues/6063
https://github.com/kubernetes/kubernetes/issues/3595

@artem-zinnatullin did you find a conclusive answer to this question you posed?

So users of Kubernetes + containerd are left stranded w/o a good way to set ulimits per container and/or default ulimits (?)

having a similar problem that needs a not so repeating workaround/config

https://github.com/moby/moby/issues/45060#issuecomment-1443647463
trying to verify like above, seem no need set as it is like that
# Having non-zero Limit*s causes performance problems due to accounting overhead
# in the kernel. We recommend using cgroups to do container-local accounting.
LimitNPROC=infinity
LimitCORE=infinity
LimitNOFILE=infinity

here


Configuring export directories

Hoping this is the appropriate place to ask this question. Apologies if it isn't.
I'm looking to use the clean export function within PL to get a directory structure exported of my twig files that matches what's in the source directory. Ideally, this would include:
- _data
- _layouts
- _macros
- _meta
- _patterns <-- with all variants etc.
- _twig-components
- images
- js
- etc. <-- any files and dirs that would normally export to public or export directories.

In our shop we use a WordPress framework that makes use of twig files to build our templates with an MVC setup.
I can copy and paste or setup a deploy of some sort to dump out, but the export feature seems to be the more "tool centric" way to go. Is it extensible at all? Could I customize that in some way? Thanks and I'll hang up and listen. :-)
P.S. @dmolsen said to post here and maybe @aleksip or @EvanLovely could help me out. Thanks!

@Webslung tough to see what exactly you need to do, but generally when I'm creating integrations like this, I'll use Grunt or Gulp to copy over the appropriate files to the appropriate places in my build. So something like:

/source/patterns/* => production/includes
/public/css/* => production/css/
/public/js/* => production/js/
/source/_data/* => production/_data/

And so on. When I call the command gulp export-to-production or whatever, the copy command copies things to the appropriate folders.
I don't know if that's generally what you're trying to accomplish.

@Webslung I take it you are talking about the php core/console --export command, and customizing it somehow? Or adding a custom command to do something similar?
I'm not 100 % sure about this, but I don't think there is a way to customize existing commands (other than using a plugin, but there are no plugin events for the export). I don't think there is a supported way to add new commands either. So currently something like what @bradfrost suggested would probably be the best way to do something other than what the default export command does.
However, this might change in the (hopefully near) future, as we are planning to refactor PL PHP core to use Symfony's Console component and also make it possible to provide custom PL commands.

@aleksip and @bradfrost your answers are what I was looking for. A set of gulp tasks was my fallback plan if something more integrated couldn't be used. I was looking to do something that built off of the core if possible, but gulp or some other task runner will do the trick. Thanks for the responses. Love PL!


Popsicle crashes on text/plain response

I'm currently using a REST API usually returns JSON, but returns text when anything bad happens (like 403 access denied or 500 internal server error).
However, text/plain responses lead to popsicle throwing an exception when using the json
plugin.
PopsicleError {cause: undefined, code: "EPARSE", popsicle: Request, message: "Unhandled response type: text/plain", name: "PopsicleError", …}

This is inconvenient: I would rather like to check for the returned HTTP status and present an appropriate message to the user. This is currently impossible, as I cannot access the response when an exception is thrown.
Is there any way to change this behavior?

It’s all just functions, so if it’s not going to be returning JSON and you know this, you could skip the parsing as JSON step.

That’s not true, like I said - you can check before you parse as JSON. If the plugin returned text when you’re expecting a JSON response, it would be very confusing and hard to type check. That’s why it works like this. If you share the code you have right now, I can show how you can do what you’re after.

The code is very basic. I constructed a minimal example below.
  private async getData(url: string) {
    const result = await popsicle.request({
      headers: {
        'Authorization': 'Bearer ' + localStorage.getItem(API_TOKEN_KEY) || '',
      },
      method: 'GET',
      url: api.base + url,
      })
      .use(popsicle.plugins.parse('json'));

    if (result.status !== 200) {
      alert("Oh no. Something bad happened");
    }
    return result;
  }

I don't know how I could use another plugin to check the content type skip the JSON parsing.

So you can always write code like:
const result = await popsicle.request({
    method: 'GET',
    url: api.base + url,
})
.use(function (req) {
    if (isTrue) {
        return popsicle.plugins.parse('json')(req);
    }

    return somethingElse;
});

If it helps, I can look at turning this into a small module you can reuse such as fn(req => isTrue, parse, somethingElse).

Thank you, that example is fully sufficient. I will think a bit about solving the situation nicely and then post my solution here.


ELB retrieval functionality broken for instances outside of ASG

Pull request #17 broke the ELB retrieval functionality for instances which are not part of an Auto Scaling group.
I am referring to function "get_elb_list()" in file "load-balancing/elb/common_functions.sh", broken by commits 7f9cdd2 and 5ab0577 from 04.09.2015. This function now displays the “list index out of range” error message for the aforementioned type on instances.

Hi,
Thanks for the bug report. We've pushed a fix to this so you should now be able to use this for non-AutoScaling instances again.


Model selection for extracting jukebox representations

Hello,
I would like to ask a question regarding the language model selection in the main script for extracting jukebox representations. I am referring to the main python script under jukemir/representations/jukebox.
There are two options for the language model, '5b' or '1b_lyrics'. However, when setting parameters there are a couple of if statements referring to a model '5b_lyrics'. Please see the below excerpt of the code from line 153 onwards:
# Set up VQVAE
model = "5b"  # or "1b_lyrics"
hps = Hyperparams()
hps.sr = 44100
hps.n_samples = 3 if model == "5b_lyrics" else 8
hps.name = "samples"
chunk_size = 16 if model == "5b_lyrics" else 32
max_batch_size = 3 if model == "5b_lyrics" else 16

Is there a choice between three different models or "5b" is identical to "5b_lyrics"? Which values did you use for n_samples, chunk_size and max_batch_size when using the pretrained 5B-parameter language model for extracting representations for the datasets you used in the paper?
Thank you!

Hi,
So sorry for the very late response, but to answer your question, the "5b_lyrics" model has lyric-conditioning, so we did not use it at all. For n_samples, chunk_size, and max_batch_size, we just used what is given by the code above (i.e. what would happen if the model is not 5b_lyrics).

Thank you for the response!


When more weight, the value goes down

When I put more weight on the scale, the value goes down in the negatives. Maybe the offset is not well calibrated, but the value should go up when I put more weight.
Does someone know why ?

Simple solution. Just tur the load cell by 180 degree in vertical axis. Sometimes the manufacturer put the sticker other way around. This should help.

I'll do that if there is no software solution but the load cell is already fixed so it is not so easy to turn it around. Do you know a software solution ? Otherwise I'll do just that.
Thank you !

Meanwhile, can you provide more info? Which function you want to use? is it get_weight_mean? Do you "zero" (tare) the scale with hx.zero method? I think that if you set the variable  hx._scale_ratio_A_128 = - ratio  to negative ratio this should just work fine. Then do not use hx.set_scale_ratio(scale_ratio=ratio) method to set the ratio. There is check if the ratio is negative it raises ValueError. You have to access the variable as described above. As I said I'll look at it tomorrow. Let me know if this worked.

I'll provide more info this afternoon!
I'll try your solution and tell you if it works

If you are using channel A and gain 128 try this and copy the output. If not working try debug mode.
hx = HX711(dout_pin=21, pd_sck_pin=20)
result = hx.reset()
result = hx.zero(readings=20)
input('Put known weight on the scale and then press Enter')
data = hx.get_data_mean(readings=20)
if data != False:
    known_weight_grams = input(
        'Write how many grams it was and press Enter: ')
    value = float(known_weight_grams)
    print(str(value) + ' grams')
    ratio = data / value  # calculate the ratio for channel A and gain 128
    print('data:', data)
    print('known weight is:', value)
    print('Ratio should be for you a negative number. It is:', ratio)
    hx._scale_ratio_A_128 = ratio  # in this case ratio should be negative number
else:
    raise ValueError('Cannot calculate mean value. Try debug mode.')
while (True):
    current_weight =  hx.get_weight_mean(10)
    print('Current weight on the scale is:', current_weight)

You can try to pull the latest changes from master branch. the example.py should work.

Sorry I didn't have much time to respond before.
Thank for the info. I did what you told me too and it worked like a charm. I then pulled your latest changes that did the exact same thing so it is great now. I'll be using your library a lot in the next few weeks so I'll come back if needed.
Thank you again, great work.


Using Symbolic formula

After I trained the KAN on the dataset of mnist dataset. And fixed the symbolic formula. I got the symbolic formula from the model.
Can I just use the symbolic formula as a Python function to classify the data?

I have faced same situation on regression case.
You can look up this issue => https://github.com/KindXiaoming/pykan/issues/206
Author also replied it.

I have faced same situation on regression case.
You can look up this issue => https://github.com/KindXiaoming/pykan/issues/206
Author also replied it.

Thank you, it is really helpful.


Update _navbar.scss

collapse component - inline -style  height:0px  problem

Please describe the problem that this addresses, using full sentences.

Hey there!
We're automatically closing this issue since the original poster (or another commenter) hasn't yet responded to the question or request made to them 14 days ago. We therefore assume that the user has lost interest or resolved the problem on their own. Closed issues that remain inactive for a long period may get automatically locked.
Don't worry though; if this is in error, let us know with a comment and we'll be happy to reopen the issue.
Thanks!
(Please note that this is an automated comment.)


VirtualBox & Hyper-V

This can be a non-issue (sorry for that) but the swarm lab suggests installing Docker for Mac in order to use docker-machine later on for provisioning local VirtualBox VMs.
Isn't there an issue about having both virtualization products on the same box (like VirtualBox breaking after Hyper-V runs)? I don't have a Windows box anymore, so I can't test it myself.
If this is something as simple as "do not run Docker for Windows after boot" perhaps it should be mentioned. Looking up the "disabling Hyper-V" subject looks kinda scary (https://marcofranssen.nl/switch-between-hyper-v-and-virtualbox-on-windows/).
Once again, if this is a non-issue please ignore.

It's a good documentation issue. We need to test the lab in Powershell. Virtualbox will not run with Hyper-V enabled. However you should be able to use the hyperv driver instead.

@andrevtg Docker for Mac and Windows both install Docker Machine as part of the install (along with Docker Compose).
On Mac, we have a detailed description of how to run these: https://docs.docker.com/docker-for-mac/docker-toolbox/
On Windows, I need to update the docs to be clearer, but you should be able to switch off Hyper-V, and then run Docker Machine with Virtual Box with no repercussions. I did this the other day to test a different scenario and all worked fine. I will re-test this particular entire workflow today (testing Swarm as well) to be sure, then document it. More soon. Thanks for raising the question.
Cc'ing @friism

@andrevtg I'm running VMware Fusion + VirtualBox + Docker for Mac on my MBP. Each hypervisor has its strengths so I can switch projects and run them in parallel. Two for Vagrant, all three for Docker.
On Windows 7 I have a notebook with VMware Workstation + VirtualBox, also works fine and in parallel. Both for Vagrant or Docker. There is no Hyper-V on Windows 7 so I have this "freedom".
But on a Windows 10 machine you probably switch to Hyper-V and then you are locked in to it as it does not support other hypervisors in parallel. This might change in the future, but for now you have to reboot your host to switch hypervisors.
Hm, while writing this I think of that we should update the swarm docs to use docker-machine -d hyperv which should work in parallel to a Docker for Windows installation.

@andrevtg @StefanScherer thanks Stefan. I am just testing all this now, and figured out what I need to add to the docs. On Docker for Mac, users can use Toolbox-installed Docker machine (which installs VirtualBox) or the Docker Machine that comes with Docker for Mac to create machines on a cloud provider (e.g., AWS, Digital Ocean, etc.) then use either of those sets of machines as swarm nodes.
On Docker for Windows it's a little more restrictive and you guys are right, you can't use Docker Machine to create local machines (because your only option there would be to create them using VirtualBox, which you can't have running with Hyper-V). But what you can do, is use the Docker Machine that comes with Docker for Windows to create remote machines on a cloud provider (then use them as swarm nodes). I'm going to just finish this test with Docker for Windows creating cloud nodes, and if it works I'll update the Swarm docs to clarify this. I'll ping you on the exact wording with which I plan to update the docs if you want to chime in. More soon, thanks!

@StefanScherer I'll ask @friism about your suggestion re: docker-machine -d hyperv  and also get him to review everything

Instead of cloud nodes maybe the docs should point to using the hyper-v
driver for Docker-machine.
Haven't tested them myself, tho...
Em quarta-feira, 21 de setembro de 2016, Victoria Bialas <
<EMAIL_ADDRESS>escreveu:

@andrevtg https://github.com/andrevtg @StefanScherer
https://github.com/StefanScherer thanks Stefan. I am just testing all
this now, and figured out what I need to add to the docs. On Docker for
Mac, users can use Toolbox-installed Docker machine (which installs
VirtualBox) or the Docker Machine that comes with Docker for Mac to create
machines on a cloud provider (e.g., AWS, Digital Ocean, etc.) then use
either of those sets of machines as swarm nodes.
On Docker for Windows it's a little more restrictive and you guys are
right, you can't use Docker Machine to create local machines (because your
only option there would be to create them using VirtualBox, which you can't
have running with Hyper-V). But what you can do, is use the Docker Machine
that comes with Docker for Windows to create remote machines on a cloud
provider (then use them as swarm nodes). I'm going to just finish this test
with Docker for Windows creating cloud nodes, and if it works I'll update
the Swarm docs to clarify this. I'll ping you on the exact wording with
which I plan to update the docs if you want to chime in. More soon, thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/labs/issues/55#issuecomment-248745491, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJ3LO8G4x7qfqnt9xt4a9pWD5H9FLG6aks5qsZ6rgaJpZM4KCxxz
.

--
André Fernandes
Founder, Board Advisor
+55 21 2232-0123
+55 21 98191-1299
<EMAIL_ADDRESS>

@andrevtg well, I don't think that will work but will give it a try, and let you know. If it did, it would be fantastic :-)

@andrevtg https://github.com/andrevtg , it totally works with the hyper-v
driver ! I'll have the documentation all updated tomorrow regarding this
(yay!)
On Wednesday, September 21, 2016, André Fernandes<EMAIL_ADDRESS>wrote:

Instead of cloud nodes maybe the docs should point to using the hyper-v
driver for Docker-machine.
Haven't tested them myself, tho...
Em quarta-feira, 21 de setembro de 2016, Victoria Bialas <
<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> escreveu:

@andrevtg https://github.com/andrevtg @StefanScherer
https://github.com/StefanScherer thanks Stefan. I am just testing all
this now, and figured out what I need to add to the docs. On Docker for
Mac, users can use Toolbox-installed Docker machine (which installs
VirtualBox) or the Docker Machine that comes with Docker for Mac to
create
machines on a cloud provider (e.g., AWS, Digital Ocean, etc.) then use
either of those sets of machines as swarm nodes.
On Docker for Windows it's a little more restrictive and you guys are
right, you can't use Docker Machine to create local machines (because
your
only option there would be to create them using VirtualBox, which you
can't
have running with Hyper-V). But what you can do, is use the Docker
Machine
that comes with Docker for Windows to create remote machines on a cloud
provider (then use them as swarm nodes). I'm going to just finish this
test
with Docker for Windows creating cloud nodes, and if it works I'll update
the Swarm docs to clarify this. I'll ping you on the exact wording with
which I plan to update the docs if you want to chime in. More soon,
thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/labs/issues/55#issuecomment-248745491, or
mute
the thread
<https://github.com/notifications/unsubscribe-auth/
AJ3LO8G4x7qfqnt9xt4a9pWD5H9FLG6aks5qsZ6rgaJpZM4KCxxz>
.

--
André Fernandes
Founder, Board Advisor
+55 21 2232-0123
+55 21 98191-1299
<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','andre@vertigo.com.br');>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/docker/labs/issues/55#issuecomment-248747293, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALHuA0hwM1Fyx7LnbPiNXCvx_Jq5s0dcks5qsaBXgaJpZM4KCxxz
.

@andrevtg There's updated documentation in the Hyper V driver:
https://docs.docker.com/machine/drivers/hyper-v/
And I've added a Powershell script to the Swarm Mode tutorial.


Animation in react native

Thanks for the suggestion @asifmom. What specific kind of animations you have in mind (UI Transitions, for example)?

Since there's no info here, I'll add an opinion. Maybe go deeper with the React CSSTransitionGroup add-on.

In the above case, the images are dynamic and coming from server. Each fruit or object would have different weight and the scale tilt depending on the weight

Cool example, @asifmom. Can you share the source code?

this is implemented in apache cordova. Interesting to see how this would be done using react-native. especially the performance and finesse of the interaction


support LLama3

hi , will you support LLama3 ?

Hey,
Sorry for the misunderstanding. This repo contains my tweaks to slicegpt for my own experiments.  slicegpt is the repo you should be looking at


Dependency annotations (ES7)

I've started to use ES6 with grigio:babel. ES6 classes don't allow you to add properties. So the only way would be to add this properties after the class declaration. I think it's better when the dependencies are annotated on the top.
This pull request adds the capability to declare your dependencies with the ES7 annotations that are also available with Babel. It's inspired by https://github.com/angular/di.js/.
You can see an example in the tests.

Hey @Sanjo, this looks great!
The only thing I am concerned about is that @Dependencies and @RequiredModules are now defined as global functions. It might not be a big deal, but would it be possible to move them into the Space namespace? so that you call them like @Space.Dependencies(…)

Yeah, I can do that. Than I can still just say in my project:
Dependency = Space.Dependency;
RequireModule = Space.RequireModule;

Done ;-)

Thanks! This is definitely a great addition :+1:
… although it's sad that es6 classes can't have static properties anymore?

hmm … but Dependencies and RequiredModules are actually just prototype properties on the classes – which should definitely be possible in es6?

 They didn't add it to ES6 to avoid the problem with the shared state between instances I think. You can still add values to the prototype with:
class MyClass {}

MyClass.prototype.Dependencies = {
  dependencyProperty: 'dependencyName'
}

Anyway, I think dependency declarations are a great use case for the ES7 annotations/decorators.

You can't avoid that problem in Javascript because it's an inherent property of the language. Sometimes that's even what you want! And it certainly doesn't help to remove a standard feature for everyone only to "save" some Javascript beginners to learn the language (what they have to anyway). But let's not talk about ES6, it makes me angry every time I see only a glimpse of it.
Yeah, ES7 annotations would be a great way to declare dependencies! The current implementation was basically inspired by Java annotations, so that's the obvious way forward :wink:


instance: No collisions between proxy device and network fwd listenAddr

Closes #11332

Static analysis failing.

sorry, wrong branch :)

@gabrielmougard looks like the latest changes broke the tests.

Thanks!

Thank you for fixing this; it was certainly brain-bending to work out what had gone wrong :)


perf is poor.

https://github.com/stefanpenner/ember-cli/issues/2597#issuecomment-65381619
Startup with esnext
Build successful - 73386ms.

Slowest Trees                  | Total
-------------------------------+----------------
EsnextFilter                   | 33580ms
EsnextFilter                   | 11862ms
ES3SafeFilter                | 8355ms
ES6Concatenator          | 7184ms
JSHint - App                  | 7058ms

Incremental Rebuild
Build successful - 3205ms.

Slowest Trees                  | Total
-------------------------------+----------------
ES6Concatenator          | 518ms
JSHint - App                  | 380ms
EsnextFilter                   | 357ms
ES3SafeFilter                | 351ms
Funnel                           | 349ms
TemplateCompiler         | 221ms

Startup without esnext
Build successful - 26832ms.

Slowest Trees                  | Total
-------------------------------+----------------
ES3SafeFilter                 | 9011ms
ES6Concatenator           | 6255ms
JSHint - App                   | 6211ms
JSHint - Tests                 | 2468ms

Incremental Rebuild without esnext
Build successful - 2464ms.

Slowest Trees                  | Total
-------------------------------+----------------
ES6Concatenator           | 416ms
JSHint - App                   | 361ms
ES3SafeFilter                 | 338ms
Funnel                            | 251ms
TemplateCompiler          | 221ms
Funnel                            | 148ms
Concat                            | 130ms

No longer directly relevant with 6to5 merge.


Alert of new pixi version releases

Problem description
Other command line tools (like Github CLI, juliaup, ...) automatically check in the background whenever a command is used (like pixi add or something similar), and print an info message when there are updates available.
Would be nice if pixi did something similar, asking the user to run pixi self-update whenever it finds there are new versions available.

There are a few questions that come to mind:

When would you want to get this alert? I guess, for every command would be to much.
Implementing it for every package manager would be extreme so only do it for the GitHub releases?
Should it have a certain delay? Like power users might want to be quick to the punch but most users probably don't care about being on par with the latest and greatest every time.
Should we (pixi devs) have the power to trigger this? e.g. we do a important bug fix , should we sendout a alert? And on normal we could skip it?
How would we turn it off if the user doesn't care. Is it a onetime request? Is it an env variable.

Not doing this for now. Maybe after a release v1

I closed it because it was stale, and we want to avoid clutter. It's not a bad idea just not worth the work and maintenance for now in my opinion.
Still open to PR as always.


Post release automated changes for datafactory releases

Post release automated changes for azure-arm-datafactory

API change check
API changes are not detected in this pull request.


Tee exit status is 0

This prevents the test from turning red.
Alternative is to disable the generation of the report, or find a better way to report exit status - but
will try to do it in separate PR, for now things are really broken.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
50367d8144662c4f3b832efce45d6b882143d9c1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
50367d8144662c4f3b832efce45d6b882143d9c1
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
50367d8144662c4f3b832efce45d6b882143d9c1
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Insert auto-complete when a new operator is added

The select downloads all users as options, but do not filter options when the admin start writing the user email
We should also avoid downloading all users emails and wait for the user to type at least a couple chars


[prototype] Speed up adjust_contrast_image_tensor

Related to #6818
Small performance improvement for uint8 images by avoiding the double casting from floats to ints and back to floats.
Floats remain unaffected, a 5% boost on uint8s:
[----------- adjust_contrast_image_tensor cpu torch.float32 -----------]
                         |  adjust_contrast_image_tensor old  |  fn2 new
1 threads: -------------------------------------------------------------
      (16, 3, 400, 400)  |               13600                |   13500
      (3, 400, 400)      |                 538                |     535
6 threads: -------------------------------------------------------------
      (16, 3, 400, 400)  |               14300                |   14300
      (3, 400, 400)      |                 838                |     834

Times are in microseconds (us).

[---------- adjust_contrast_image_tensor cuda torch.float32 -----------]
                         |  adjust_contrast_image_tensor old  |  fn2 new
1 threads: -------------------------------------------------------------
      (16, 3, 400, 400)  |                196                 |    196
      (3, 400, 400)      |                 64                 |     62
6 threads: -------------------------------------------------------------
      (16, 3, 400, 400)  |                197                 |    197
      (3, 400, 400)      |                 64                 |     62

Times are in microseconds (us).

[------------ adjust_contrast_image_tensor cpu torch.uint8 ------------]
                         |  adjust_contrast_image_tensor old  |  fn2 new
1 threads: -------------------------------------------------------------
      (16, 3, 400, 400)  |               26100                |   25000
      (3, 400, 400)      |                1109                |     999
6 threads: -------------------------------------------------------------
      (16, 3, 400, 400)  |               28300                |   30000
      (3, 400, 400)      |                1700                |    1550

Times are in microseconds (us).

[----------- adjust_contrast_image_tensor cuda torch.uint8 ------------]
                         |  adjust_contrast_image_tensor old  |  fn2 new
1 threads: -------------------------------------------------------------
      (16, 3, 400, 400)  |               257.3                |    242
      (3, 400, 400)      |                89.7                |     79
6 threads: -------------------------------------------------------------
      (16, 3, 400, 400)  |               258.1                |    242
      (3, 400, 400)      |                90.2                |     80

Times are in microseconds (us).

cc @vfdev-5 @bjuncek @pmeier

@vfdev-5 thanks. It seems there is an unrelated flaky test about resizing bboxes:
https://github.com/pytorch/vision/actions/runs/3427555648/jobs/5710704975
Could you have a look?
FAILED test/test_prototype_transforms_functional.py::TestKernels::test_against_reference[resize_bounding_box-55] - AssertionError: Tensor-likes are not equal!

Mismatched elements: 2 / 16 (12.5%)
Greatest absolute difference: 1 at index (2, 2)
Greatest relative difference: 0.25 at index (2, 3)

The failure occurred for item [0]
FAILED test/test_prototype_transforms_functional.py::TestKernels::test_against_reference[resize_bounding_box-56] - AssertionError: Tensor-likes are not equal!

Mismatched elements: 2 / 16 (12.5%)
Greatest absolute difference: 1 at index (2, 2)
Greatest relative difference: 0.25 at index (2, 3)

The failure occurred for item [0]
FAILED test/test_prototype_transforms_functional.py::TestKernels::test_against_reference[resize_bounding_box-57] - AssertionError: Tensor-likes are not equal!

Mismatched elements: 2 / 16 (12.5%)
Greatest absolute difference: 1 at index (2, 2)
Greatest relative difference: 0.25 at index (2, 3)

The failure occurred for item [0]


Make 50-100 Playgrounds exposable to the Playground examples pane

Update playground component to include (isMain="true") to expose them.

This has now been done.


Avoid duplicate template loading for indexing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 10 (100.0%)  changed or added relevant lines in 2 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.07%) to 84.561%

Files with Coverage Reduction
New Missed Lines
%

hermes/config.py
2
87.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.07%

Covered Lines:
1079

Relevant Lines:
1276

💛  - Coveralls


Port scala's docs

Once https://github.com/playframework/play-scala-grpc-example/pull/42 is merged, port the docs into this repo. The porting will require reviewing the contents and @@snip references.

Related to #36


Rollback the ASP.NET Core 2.X content

Hi,
In my company, we have a lot of dependencies incompatible with .NET Core. Then we use .NET Framework with ASP.NET Core 2.1.
After a lot of work, we eliminated this problematic dependencies and are preparing the migration from ASP.NET Core 2.1 to ASP.NET Core 6. Last week, I read interesting about the automatic validation return on this documentation page. But today, all that interesting content is gone...
The removal of this content is voluntary as the ticket #24695 reveals. But I don't understand the reason.
ASP.NET Core 2.1 is always supported on .NET Framework as indicated in this page :
https://dotnet.microsoft.com/en-us/platform/support/policy/aspnet#dotnet-core

To help facilitate migrating applications to ASP.NET Core on .NET Core, the following ASP.NET Core 2.1 (latest patched version only) packages will be supported on the .NET Framework and follow the support cycle for those .NET Framework versions. ASP.NET Core 2.1 is defined as "Tools" in the Microsoft Support Lifecycle Policy. A "Tool" requires a minimum of 12 months notification prior to the end of support

A lot of company continue to use ASP.NET Core 2.1 and will migrate. This documentation with ASP.NET Core 2.X notes is a welcome help.
Can you rollback the deleted content about ASP.NET Core 2.X?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b391017f-25e1-d5e1-c4f7-020408ade7b5
Version Independent ID: 263a7b64-2e42-bbfc-c1d3-61680438e1e4
Content: Create web APIs with ASP.NET Core
Content Source: aspnetcore/web-api/index.md
Product: aspnet-core
Technology: aspnetcore-webapi
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

You can see the deleted content here. It's almost identical to the 3.1 version.

Coded deleted in #24697 and no easy way to restore that code. cc @guardrex

ASP.NET Core 2.1 is defined as "Tools" in the Microsoft Support Lifecycle Policy.

That doesn't seem to be an accurate remark ...
https://docs.microsoft.com/en-us/troubleshoot/developer/webapps/aspnet/development/support-lifecycle-web-stack
The support policy AFAIK is ...
https://docs.microsoft.com/en-us/lifecycle/products/microsoft-net-and-net-core
I'll talk to Dan and Artak about it tonight. WRT restoring all of the 2.1 content over this, I gravely doubt that (but don't know that) they'll want all such content restored. I recommend waiting for an answer before proceeding to restore this content.

Confirmed by Artak. In spite of that funky statement about ASP.NET Core 2.1 being a "Tool," they want to KEEP the 2.1 content ... as in restore all of it.

@Rick-Anderson @serpent5 @wadepickett Do you think that the PRs that removed the content can just be reverted ... at this late date? Is it felt that it might ✨ Just Work™ ✨?

No, I've saved an old repo snapshot. We'll restore them on a case by case basis. I'll restore this one today.

Ok ... that sounds better, but Artak was clear that they want it all restored ... as in like ALL of IT 🙈😄.
You know, my early retirement was coming up here! ⛱🍹 *This might be a good time to consider extra early retirement. 🤔😆

@vernou 2.1 will be live in 10 minutes.

Thank @Rick-Anderson
@guardrex write :

That doesn't seem to be an accurate remark ...

I think the support of ASP.NET Core 2.1 ended at 21/08/2021 for .NET Core, but the support is maintained for .NET Framework.
Do I lack of understanding about the ASP.NET Core 2.1 support?

The entries listed for "Tools" don't include "ASP.NET Core 2.1" as the original post copied from the first doc. However, support will be maintained per PU management regardless of the incorrect remark in the doc.

Glad to read this.
@guardrex : What is "PU management"?

"PU" = "product unit"

Does ASP.NET Core 2.2 have the same support policy as 2.1 when run on .NET Framework?

Yes, @WillGunn ... that's correct.

ASP.NET Core 2.2 packages aren't deprecated, but they haven't a recent version unlike ASP.NET Core 2.1 packages.
ASP.NET Core 2.1 has a branch on GitHub that continue to be developed with this recent PR that fix some governance alerts to ASP.NET Core 2.1 packages :
Update references to System.IO.Pipelines #46360
And the PR has this comment :

Since 2.1 still has support for full framework, we're stuck having to fix the alerts.

I'm sorry to have some doubts.
@guardrex, can you link a reference that confirm ASP.NET Core 2.2 has a support policy on .NET Framework?

My understanding was that all versions of ASP.NET Core on .NET Framework adopt the .NET Framework support policy. I was perhaps mistaken in that only the LTS release is going to be supported, and that would be 2.1, not 2.2.
In .NET and .NET Core Support Policy, there's a section on 2.1, ASP.NET Core 2.1 on .NET Framework with a link to "ASP.NET Support" that's broken, but the page shows up by removing a link segment at ASP.NET Support Policy. That page indicates that ...

To help facilitate migrating applications to ASP.NET Core on .NET Core, the specified ASP.NET Core 2.1 packages (latest patched version only) will be supported on the .NET Framework and follow the support cycle for those .NET Framework versions.

My current thinking is now, no 🎲🎲 on 2.2 on .NET Framework.
If could've made one suggestion to management, it would've been to NOT comingle them in the section heading of .NET and .NET Core Support Policy because that's very confusing to see past dates in the Out of Support area that map to 2.1/2.2 under that section heading. I suggest breaking out .NET (Core) and .NET Framework into two pairs of tables (Supported versions and Out of support versions for each) to make it clear exactly what's supported when.
cc: @mkArtakMSFT ... Will know for sure and can correct me if my assessment is incorrect.

Yeah I don't remember seeing anywhere that specified 2.2 as not LTS for 2.x targeting Framework, let alone EOL.  The quoted sentence only says that the latest patch of 2.1 is supported, but the lack of any mention of 2.2 doesn't indicate that it is EOL, its state is ambiguous/undefined if that is the only reference.  A clarification in the docs would be helpful.
We went to 2.2 a while back due to the improvements as listed: https://learn.microsoft.com/en-us/aspnet/core/release-notes/aspnetcore-2.2 and while we're working on getting off of Framework, its an ongoing project.
Is there any discussions on why 2.1 was selected over 2.2 (if that is indeed that case) for LTS on Framework?  2.2 is what introduces HTTP2 support as well as improved performance.

its state is ambiguous/undefined

I agree that it's confusing.

Is there any discussions on why 2.1 was selected over 2.2 (if that is indeed that case) for LTS on Framework?

I can't say outside of the fact that 2.2 was never an LTS release in it's own right.
I think @mkArtakMSFT will be along in a bit to assist.

Glad to post a new Issue if you prefer, but I posted a 2.1-on-Framework question on Learn that now seems unlikely to get a qualified response: https://learn.microsoft.com/en-us/answers/questions/1327232/microsoft-aspnetcore-dataprotection-2-1-1-dependen


chore: cdk v2 migration tests part 1

Description of changes
This is a draft; as I'm still working through some hiccups with the migration tests scaffold to support v10 -> v11.
The general idea is to make use of the pre-existing migration test framework, and then we can extend this with more specific test scenarios.

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

closing this in favor of: https://github.com/aws-amplify/amplify-cli/pull/11535


Create Number functions

Create Number functions

We will use this approach #86 that can minimise spaghetti code.
So, we don't need to create pure functions for everything.


feat: support configurable server side ssl ca check

Related Issue(s) & Descriptions

Checklist

[x] Tests were added or are not required
[x] Documentation was added or is not required

Where should the CA be placed if the user want to use SSL/TLS? Maybe it will be better if the path of CA is configurable too?

Where should the CA be placed if the user want to use SSL/TLS? Maybe it will be better if the path of CA is configurable too?

It is already configurable.
mysql_server_ssl_ca=
mysql_server_ssl_cert=
mysql_server_ssl_key=

/pick-and-release release-0.3 0.3.8-alpha1


Cannot import organised factoids from Trello into CAIRIS

Expected behaviour
Have signed into my account on the Trello API. I have selected my board and want to import the factoids from here into CAIRIS.
Actual behaviour
It shows my boards but when I click "import" CAIRIS does nothing. It shows no error message or success. The factoids do not show up in CAIRIS
Steps to reproduce the behaviour

Link Trello account to cairis
select board
click "import"

Version of CAIRIS
V1.7.1
Operating Systems / Hardware
PG13 CAIRIS VM

I've just tried reproducing the problem and can't.  Some things to check:

Have you created a skeleton persona in CAIRIS, e.g. Alice  .  Don't worry about the content for now.  There just needs to be a persona object created.
Is the Trello board the same name as the persona the imported persona characteristics will be associated with, e.g. Alice
Are the list names postfixed with a colon and the behavioural variable that persona characteristic will be associated with.  For example, if the list is called 'someChar' and is associated with activities then it's name should be 'someChar: activities'
Have you added a grounds, warrant, or rebuttal label to each card.

If you still get problems, can you please check your browser's javascript console to see if any errors have been reported there.


Duplicate Detection in UI

Hi,
I can't seem to progress past saving a record once a duplicate has been detected. It looks like its meant to be handled in the xrmApp.Entity.Save(); or xrmApp.CommandBar.ClickCommand("Save & Close"); but both fail as per below. Please advise.
Message: Test method Microsoft.Dynamics365.UIAutomation.Sample.UCI.XXX.XXX.threw exception:
System.InvalidOperationException: unknown error: Element ... is not clickable at point (24, 162). Other element would receive the click: ...
(Session info: chrome=69.0.3497.100)
(Driver info: chromedriver=2.38.552522 (437e6fbedfa8762dec75e2c5b3ddb86763dc9dcb),platform=Windows NT 10.0.17134 x86_64)

Hello @petemossuk , thanks for raising this issue to us.
Could you try commenting out line 552 line within WebClient.cs in the Microsoft.Dynamics365.UIAutomation.API.UCI prject?
                    //Select the first record in the grid
                    (552) driver.FindElements(By.XPath("//div[contains(@class,'data-selectable')]"))[0].Click();

The current design is built to choose the Ignore and Save, so this line should be unnecessary and may be contributing to the issue. We'll need to add in additional functionality for further control over the Duplicate Detection dialog.
Could you try this out and report back if it helps with the xrmApp.Entity.Save() scenario?
Note: From reviewing the current project structure, CommandBar.ClickCommand("Save & Close") would require an additional API call to interact with any dialogs, if present. This is not currently available for UCI, but I've added an item to the back log to add this functionality as well.
Best Regards,
Tyler

Thanks @TYLEROL
I tried that which allowed the save but the Dialog was still present meaning you couldn't browse anywhere. I dug a bit deeper and found that it's just a timing issue, If you add in a wait to the HandleSaveDialog in WebCLient.cs then it works perfectly :)
    internal BrowserCommandResult<bool> HandleSaveDialog()
    {
        Browser.ThinkTime(1000);

Cheers
Pete

Thanks again @petemossuk for helping confirm. We'll evaluate this in the future when we look to make the api's more resilient to timing issues like these.
For now, I've added the same Browser.ThinkTime method to the core code to help alleviate this problem for all.
Best Regards,
Tyler


RuboCop support

(This is branched off of #79, so contains it for starters.)
This configures RuboCop to white-list the current state and then fixes some offences on a per-commit basis (to be continued).
@plexus: Let me know which ones you disagree with. ‘Every single one of these needs to be reverted except for the one in the middle which won’t let you rebase cleanly’ is a perfectly fine response!

Ok, this is no longer a work-in-progress – @plexus, please review and let me know which ones to revert. ;)
There are some FIXMEs in .rubocop.yml to be addressed separately.

All in all I agree with 99% of the changes. Good stuff! Things I don't agree with

%w() instead of %w[] this makes no sense to me. Can we configure it to use []?
format instead of %. Just because it's a syntactic construct doesn't make it evil

Regarding alias vs alias_method, according to the style guide the former creates issues, but it doesn't really explain what they are. I personally prefer alias, but if anyone can explain me what the issue is I don't mind switching to alias_method
Things I have different opinions on but am willing to accept the community concensus
$1 vs Regexp.last_match. Just because it's Perl doesn't make it evil. It's a global anyway, no need to try to hide it.
Same but less strong opinion on $/ vs $SOME_LONG_NAME_I_CANT_REMEMBER_ANYWAY. Whereas I expect every Ruby programmer to understand code that uses $1, I don't expect everyone to know $/ or $: or $$. So :+1: for readable code, even though I need to check the docs to know how to write it :)

Addressed the requirements – I’ll try to figure out alias vs alias_method, but in the evening at the earliest, so please either revert it (and merge this PR) or merge it and then I’ll revert it if I can’t come up with a good reason.

Thanks for all the effort! Don't feel obliged, I'll be reminded to research it myself every time Rubocop reminds me to use alias_method

\o/ Happy to be useful! https://www.youtube.com/watch?v=S65ZzffW-Cw


TypeScript docs follow-up

21.1 port of #9776 + reference addition in install-client-drivers.md.

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0cbc935cd5a608e1676a60b0b5701ee4da4138b8/
Edited pages:

v20.2/build-a-typescript-app-with-cockroachdb.md
v20.2/install-client-drivers.md
v21.1/build-a-typescript-app-with-cockroachdb.md
v21.1/install-client-drivers.md


Victor VosMottor: Watch tsf20

Victor VosMottor requests the watch of the watch_keyword tsf20. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

tsf20 has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


feat: enable testing with travis and appveyor

The README for this project says A wrapper around Sentry and Mixpanel that works in the browser, Node and Electron. - do we need to test each of those environments separately, or is just a single set of tests good enough?


Update use-pod-security-policies.md

Updated line 485 from Delete the network policy to Delete the security policy

@kmoussa : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Fix crash when assign request property of SDWebImageDownloadToken

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[ ] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[ ] I have added the required tests to prove the fix/feature I am adding

[ ] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

Fixed #2380 .

Reason I change the attribute to strong is:
Actually, we don't need to copy at all. The request and response are readonly to public.
Even they can be modify, they still have not any effect to NSURLSession.

Codecov Report

Merging #2381 into 5.x will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              5.x    #2381      +/-   ##
==========================================
- Coverage   69.14%   69.01%   -0.14%
==========================================
  Files          48       48
  Lines        6696     6696
==========================================
- Hits         4630     4621       -9
- Misses       2066     2075       +9

Flag
Coverage Δ

#iOS
70.06% <ø> (-0.15%)
:arrow_down:

#macOS
68.28% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

SDWebImage/SDWebImageDownloader.m
81.29% <ø> (ø)
:arrow_up:

SDWebImage/SDWebImageDownloaderOperation.m
85.32% <0%> (-3.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc39b1...28eb1b4. Read the comment docs.

@zhongwuzw 😅 I saw you contribue some PRs for SDWebImage, and your skill about the framework development, Objective-C/C seems good enough. We're all some people who spend spare time to contribute to Open Source project, but we seems lack of new people to develop it further.
If you're intereted in it and have the hope, I can ask bpoplauschi to introduce you to the SDWebImage's Collaborator and contribute to the project easier. You can review others changes, write documentations, check and fire issue tags, push to branches, etc.
This does not means that there are some "daily tasks, works or missions force you to do". We just think if you're interested in this project and want to contribute more, this can make it easier.

@dreampiggy Thanks for your invitations. 👍 I'd be glad and honor to be the Collaborator of SDWebImage. I'm the open source enthusiast, and more, I love SDWebImage and almost use it in all the apps I participate. I would look in depth to the whole framework, learn and the same time, propose some fixes, optimizations or something .
Thanks again! 🍻

I agree with @dreampiggy's proposal here. @zhongwuzw you have proved your worth here.
@rs can we add @zhongwuzw as a collaborator?

Invitation sent.

Appreciate it, @rs

@bpoplauschi Yeah, thanks and appreciate! 🍻🍻🍻

@zhongwuzw Welcome ;)


[BUG] Package requirements

Describe the bug
It seems the setup.py file is not listing all the requirements that the package is explicitly using (importing)
To Reproduce
Search for the following packages in the codebase
    - imlib
    - magicgui
    - numpy
    - qtpy
    - skimage
    - tifffile

Expected behaviour
The package should list all the dependencies.

Thanks for spotting @goanpeca! Will fix now.

Hi @adamltyson thanks for the quick fix. Working on a pre-commit hook to help spot this more easily :)
Cheers!


Remove CoreStringNames and SceneStringNames

See https://chat.godotengine.org/channel/scripting?msg=ZCRd86Xg7vAtDaNKu
Not certain that this is desired, but CoreStringNames and SceneStringNames aren't used very consistently, several of their StringNames are unused, and they're no longer that useful for caching the StringNames since we have the SNAME() macro. I this will make it less work to implement something better like https://github.com/godotengine/godot-proposals/issues/2152.

I think part of the idea was to prevent bugs caused spelling errors in the strings... although the StringNames classes were not really used very diligently or consistently throughout the database. What about SceneStringNames?

I think part of the idea was to prevent bugs caused spelling errors in the strings... although the StringNames classes were not really used very diligently or consistently throughout the codebase

Didn't know about SceneStringNames, if CoreStringNames gets removed then it probably should too...
I like https://github.com/godotengine/godot-proposals/issues/2152 better though, I think the signal names should be local to the class they originate from.

What about SceneStringNames, should that be removed too? There may be others.

From a quick search it seems SceneStringNames is the only other similar class.

Alright, I removed SceneStringNames too... I was careful to not just do a simple regex replace, but to make sure that the strings actually matched what they were before (I used a regex to check for all StringNames that weren't the same as their variable name).

I think this may still make sense but would likely need to be redone.
But we should discuss it a bit more beforehand to make sure we agree on what should be done. SNAME() can in theory replace these classes but there's a valid point to make that it's not necessarily a gain to rely more on strings (and thus potential typos) instead of caching them in one location.
Back when this was discussed we also had some ideas to maybe use a macro that could define this kind of static StringName in the class with an actual C++ identifier so we avoid strings, but reduz wasn't fond of the idea IIRC.

Related: #80573 and #81303
After the latter is merged, I plan to replace all strings with their singleton equivalents if available. The advantage of stringname singletons is that they allocate the name only once, which results in smaller binary size and faster initialization time (see #80573).
While the gain is rather minimal, it's still better to use them in place of repeated SNAMEs and plain strings. Though unused singleton names and names used once should be removed, I plan to clean up that too.

Superseded by #91909.


Fix centered timeline

With introducing PurgeCSS, I broke the centered timeline 😨

Looks like purgecss fails there (converts nth-child(odd) to nth-child(2n), though this means even)

PurgeCSS will be re-introduced as soon as https://github.com/FullHuman/purgecss/issues/16 is fixed


Update string

@Benuuu ready for re-review

I think we need to get some kind of license going on at the top of the files and then I'm good with the current state of things.

👍 🚢