buildDotnetModule: add passthru.fetch-deps

Motivation for this change
This adds a script which fetches nuget dependencies for all projects using buildDotnetModule, as this was something that you had to do manually before. It should make packaging dotnet applications a lot more user friendly.
For example:
~/nix/nixpkgs > nix-build -A python-language-server.passthru.fetch-deps
/nix/store/p5yfgpgi2rr63gva01l94f2vxm8lwj2k-fetch-python-language-server-deps
~/nix/nixpkgs > /nix/store/p5yfgpgi2rr63gva01l94f2vxm8lwj2k-fetch-python-language-server-deps
/tmp/python-language-server.KuJ /nix/store
  Determining projects to restore...
  Restored /tmp/python-language-server.KuJ/src/Analysis/Core/Impl/Microsoft.Python.Analysis.Core.csproj (in 1.38 sec).
  Restored /tmp/python-language-server.KuJ/src/Parsing/Impl/Microsoft.Python.Parsing.csproj (in 1.38 sec).
  Restored /tmp/python-language-server.KuJ/src/Analysis/Ast/Impl/Microsoft.Python.Analysis.csproj (in 19 ms).
  Restored /tmp/python-language-server.KuJ/src/Core/Impl/Microsoft.Python.Core.csproj (in 17 ms).
  Restored /tmp/python-language-server.KuJ/src/LanguageServer/Impl/Microsoft.Python.LanguageServer.csproj (in 16.54 sec).
Writing lockfile...
Succesfully wrote lockfile to: /tmp/python-language-server-deps.nix

The location the file get's written to is kind of arbitrary, if anyone has a better suggestion please share!
This could potentially be used for auto-updating as well, though I'm not very familair with how that works. I'll have to look into it.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

cc @prusnak

/marvin opt-in
/status needs_reviewer

There are 0 rebuilds anyway, so let's merge this in.

This seems to break custom passthru's of derivations. See the failing tests on this PR.
https://github.com/NixOS/nixpkgs/runs/4647348126?check_suite_focus=true

This seems to break custom passthru's of derivations.

@IvarWithoutBones Can you please have a look?


Check if Narcissus JS can be used for parsing/rewriting code

My homegrown parser/rewriter is not exactly great... :)

Another suggestion was to use burrito: https://github.com/substack/node-burrito


Fixes

What was the feature/problem?
{Please write here}
How does this PR address the above feature/problem?
{Please write here}
Check lists (check x in [ ] of list items)

[ ] Test passed
[ ] Coding style (indentation, etc)

Additional Comments (if any)
{Please write here}

Codecov Report

Merging #29 into developnew will decrease coverage by 5.27%.
The diff coverage is 47.05%.

@@              Coverage Diff               @@
##           developnew      #29      +/-   ##
==============================================
- Coverage       65.38%   60.11%   -5.28%
==============================================
  Files               6        7       +1
  Lines             130      178      +48
  Branches           13       21       +8
==============================================
+ Hits               85      107      +22
- Misses             37       55      +18
- Partials            8       16       +8

Flag
Coverage Δ

#api
60.11% <47.05%> (-5.28%)
:arrow_down:

#ui
100% <ø> (ø)
:arrow_up:

Impacted Files
Coverage Δ

api/src/routes/wish.js
21.12% <27.27%> (-0.03%)
:arrow_down:

api/src/routes/about.js
47.05% <47.05%> (ø)

api/src/app.js
89.47% <83.33%> (-1.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e703c...4535205. Read the comment docs.


Iteration extension

This is not really an issue but more of a devellopement direction. We currently have a separation between Iteration objects and symbolic objects. More specifically, no symbolic operation can be done on Iteration objects. However in a more general case, we may want to have Iteration accepting any kind of Symbolic data (e.g including derivatives) in order to avoid "by hand" implementation of some aaource terms or receiver terms.
Currently when we do  src.add(m,u) it does not support doing  - src.ad(m,u) (adding the source with a minus sign) and extending it to something that would allow to do (src.dt).add(m,u) would allow to work with a lot of more general inversion objective function implementations

OK, I'm not entirely sure how to do this neatly, but I feel you might be approaching this from the wrong end:
a) Making an Iteration object propagate any outer terms to it's multiple inner expressions is possible but tricky to generalise, since you are effectively implementing arithmetic on vector variables. At least I think this might get tricky, since you need to do some sanity checking to make sure that the propagated expression makes sense.
b) The real problem, I think, is that src.add() has the wrong argument structure. I think it should take an expression as input instead of symbols, so that you can easily negate the expression. For this I believe we need to separate the generic point-interpolation coefficients from the source expression that we are interpolating onto the grid points.
To do this I think we want the PointSource base to provide the .add(target, expr) function, which creates the list of Iteration objects and applies the interpolation coefficients to expr in the body expression. So then you can either write expr out explicitly in the application/example like this:
src = PointData(...)
src.add(target=u, src * dt *dt / m)
# to negate:
src.add(target=u, - (src * dt *dt / m))

or alternatively let the SourceLike class provide the expr as a property:
src = SourceLike(...)
src.add(target=u, src.expression)
# to negate:
src.add(target=u, - src.expression)

In the latter, the source object will have control over the expression and the target, allowing you to implement different types of source terms, I think. Does this sound like it would allow you to do what you want?

I think your way of thinking is the right way to go. My only "concern" was the limited possibilities we currently have to handle source/receiver term which are add or read with fixed coefficients and expression. Generalizing the SourceLike object to handle expression instead of hard coding it inside would indeed broaden the possibilities and would allow to keep Iteration object to handle the expression itself.
I will lok into it and see what we can do, but this is not on top of my list yet.

I believe issue #189 is what you are after here, right? If so I think this can be closed.

@mloubout Prod. Is issue #189 what you are after for this? If so please close this issue to avoid duplication.


'HighwayEnv' object has no attribute 'np_random'

I'm not able to resolve this issue, please help

I found this error in the parking environment because of the order of the installs. If you install highway-env after the other dependencies it should fix it.

Hey, will try that out. thank you.
On Wed, Dec 7, 2022, 6:56 PM JoshYank @.***> wrote:

I found this error in the parking environment because of the order of the
installs. If you install highway-env after the other dependencies it should
fix it.
—
Reply to this email directly, view it on GitHub
https://github.com/eleurent/highway-env/issues/394#issuecomment-1340965758,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATHV3E6GW6UXTW5C4LN7R73WMCF6VANCNFSM6AAAAAASV7RICU
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
The information contained in this electronic communication is intended
solely for the individual(s) or entity to which it is addressed. It may
contain proprietary, confidential and/or legally privileged information.
Any review, retransmission, dissemination, printing, copying or other use
of, or taking any action in reliance on the contents of this information by
person(s) or entities other than the intended recipient is strictly
prohibited and may be unlawful. If you have received this communication in
error, please notify us by responding to this email or telephone and
immediately and permanently delete all copies of this message and any
attachments from your system(s). The contents of this message do not
necessarily represent the views or policies of BITS Pilani.

this solved it for me:

pip install stable-baselines3[extra]
pip install highway-env==1.5

Cool will try it out. Thank you.
On Thu, Dec 8, 2022, 5:41 PM Ainaz Jamshidi @.***>
wrote:

this solved it for me:

pip install stable-baselines3[extra]
pip install highway-env==1.5

—
Reply to this email directly, view it on GitHub
https://github.com/eleurent/highway-env/issues/394#issuecomment-1342635015,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATHV3E76NE5QOE4KZUVQ463WMHF7VANCNFSM6AAAAAASV7RICU
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
The information contained in this electronic communication is intended
solely for the individual(s) or entity to which it is addressed. It may
contain proprietary, confidential and/or legally privileged information.
Any review, retransmission, dissemination, printing, copying or other use
of, or taking any action in reliance on the contents of this information by
person(s) or entities other than the intended recipient is strictly
prohibited and may be unlawful. If you have received this communication in
error, please notify us by responding to this email or telephone and
immediately and permanently delete all copies of this message and any
attachments from your system(s). The contents of this message do not
necessarily represent the views or policies of BITS Pilani.


Is not possible to expand to "tab" character in bat, cmd files

Issue Type: Bug
It is not possible to expand to "tab" character in bat and cmd script files. The file uses tab indentation and I unchecked detect indentation and insert spaces options in settings and it doesn't still work, the tab is still expanded to 4 spaces. But I tested the mentioned options for other file types for example *.reg file and options work well so the tab is expanded or not expanded according to the settings of the mentioned options BUT it doesn't work for bat and cmd file types.
VS Code version: Code 1.56.2 (054a9295330880ed74ceaedda236253b4f39a335, 2021-05-12T17:13:13.157Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8365U CPU @ 1.60GHz (8 x 1896)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
23.82GB (12.40GB free)

Process Argv
--crash-reporter-id 1113e8e4-b9a9-4df5-8d80-931efc3c1b69 --crash-reporter-id 1113e8e4-b9a9-4df5-8d80-931efc3c1b69 --crash-reporter-id 1113e8e4-b9a9-4df5-8d80-931efc3c1b69

Screen Reader
no

VM
0%

Extensions (9)

Extension
Author (truncated)
Version

project-manager
ale
12.1.0

bat-snippets
bat
0.2.0

gitignore
cod
0.7.0

git-extension-pack
don
0.1.3

githistory
don
0.6.16

gitlens
eam
11.4.1

vscode-language-pack-cs
MS-
1.56.2

rech-editor-batch
rec
0.0.19

vscode-open-in-github
ziy
1.3.6

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30291415
vspre833:30267464
pythonptprofiler:30281270
vshan820:30294714
vscoreces:30290705
pythondataviewer:30285071
vscus158cf:30286554
vscgsv2:30307504
vscorehov:30309549
bridgeflight:30302069
vscod805cf:30301675

When pressing Tab, the editor will insert the current configured value (tab or spaces) depending on the current opened file. The current configured value is rendered in the status bar:

e.g. For indenting with tabs:

e.g. For indenting with spaces:

The indentation settings can be controlled by 3 options:
// The number of spaces a tab is equal to. This setting is overridden based
// on the file contents when `editor.detectIndentation` is on.
"editor.tabSize": 4,
// Insert spaces when pressing `Tab`. This setting is overridden based on
// the file contents when `editor.detectIndentation` is on.
"editor.insertSpaces": true,
// Controls whether `editor.tabSize#` and `#editor.insertSpaces` will be
// automatically detected when a file is opened based on the file contents.
"editor.detectIndentation": true,

The indentation settings can also be controlled by extensions, so please make sure to disable all extensions before trying.

Hi, thank you for your response. Yeah, I know the settings about indentation, but here really doesn't work it. Nevertheless, the issue was in the extension "Rech Batch", so I disabled it and it works fine. So you are right that it can be caused by some extensions. So you can close the issue. Thank you


Closes #20. Added some dependencies

Closes #20 . Added routine for multiplying integers, an plotting an image using Altair.

hey @gpcureton, thank you again for your contributions here. !! i am going to close this pr for the time being! i hope all is well!!

@all-contributors please add @gpcureton for code, review


Add Documentation to Abstract Methods?

Question
Should we be adding any sort of documentation to abstract methods like the "_factory_type_name" and "_registry" in the DynamicFactory class in core.py? I notice that there is no documentation in place and was wondering if that was by design.

I think for these private methods, it's good to just have a summary and perhaps an extended summary. That seems to be the approach taken in numpy.


[Feature Request] ion-refresh on the bottom

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[x] 2.x
[x] 3.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[x] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

Currently it is only possible to pull for refresh at the top of the page
Expected behavior:
It is desirable to have an option to push to refresh in case of chat apps where the newest data is on the bottom.

Hello! Thanks for the feature request. I'm going to move this issue over to our internal list of feature requests for evaluation. We are continually prioritizing all requests that we receive with outstanding issues. We are extremely grateful for your feedback, but it may not always be our next priority. I'll copy the issue back to this repository when we have begun implementation. Thanks!

This issue was moved to ionic-team/ionic-feature-requests#247


Convert package to ESM

Started to explore this road as the latest version of p-timeout only supports ESM.
ESM is also the way forward.
However, it is still experimental with TypeScript and Mocha.

Learnings:

Converting package to ESM is feasible, however it is likely to restrict users as it seems that ESM packages cannot be imported in non-ESM packages. As we can see, p-timeout was converted to ESM which makes it difficult for us to use in js-waku.
Mocha support of ESM+TypeScript is experimental but it works
Karma support of ESM seems feasible but hackish.

For now, let's not convert to ESM.


discord link broken

fyi - sorry the discord is closed down / shutdown.  for ordbase help & support you are more than welcome to start here -> https://github.com/geraldb/help

is there a ordinals community you can point me to? I'm new here

try the official ordinals discord, more here https://github.com/ordinals/ord


Template type invokemethod

Bump min flutter version to 1.2.0 for most plugins.
Add template type parameter for invokeMethod calls.
Sensor plugin has not been changed since no invokeMethod is called in the plugin.
The plugin version of in app purchase has not be updated because it is still under development.
Need to publish all plugins after this PR is merged, except in_app_purchase and sensor.
https://github.com/flutter/flutter/issues/26431

android_alarm_manager changes LGTM.

There are many places where you are using <dynamic> and then doing a manual cast - those should be refactored to use <correctType>

Closing the PR now for refactoring using invokeListMethod and invokeMapMethod

Updated invokeMethod and invokeMethod to using invokeListMethod and invokeMapMethod. Reopen the PR.

I am going to close this one and create different PRs for each plugin. I feel like much safer that way and easier to review.


Please publish to appimagehub.com or flathub.org

Hello, I just found out about this project and wanted to ask for an easier way to install onto SteamDeck. If you don't want to implement Flatpak builds, the easiest way would be to talk to the people on appimagehub.com to get your app included in their catalog so that appimagepool can find it, I guess.

Will do once I get my steam deck in about a month! Want to make sure everything works properly

Progress has been started on the branch feature/flatpak. Got a very first working version working but it still needs some refinement and bug fixes.

Flatpak support would be great. :-)

Having some issues with automating the npm sources and yarn sources (Especially yarn is a pain to work with so far). Just found this repo which may help resolving the issue: https://github.com/flatpak/flatpak-builder-tools/tree/master/node

Consider submitting the Flatpak manifest file directly to Flathub. They have their own build infrastructure + target most end-users since Flathub is considered the main Flatpak repository and as such is available out-of-box on many distributions including SteamOS.

Experimental .flatpak file will be provided with the next build (non-tested). Expect a lot of bugs still as i havent tried the gamepad or streaming capabilities yet.

Any update on this? I am happy to help test but can't seem to find where the build artifacts are

There are none.  Best use https://flathub.org/apps/io.github.mandruis7.xbox-cloud-gaming-electron for now

There is a flatpak at https://github.com/unknownskl/greenlight/actions/runs/7126053832 but I can't seem to install it

Thanks for the patience! Greenlight can now be found on Flathub 🎉 https://flathub.org/apps/io.github.unknownskl.greenlight


Errors after adding dependency

Hi, after adding adding dependency via UPM, bunch of errors pop up:
Library/PackageCache/com.pixeye.ecs@b0136155b5/Editor/Drawers/DrawerScene.cs(22,31): error CS0246: The type or namespace name 'SceneReference' could not be found (are you missing a using directive or an assembly reference?)
Library/PackageCache/com.pixeye.ecs@b0136155b5/Editor/Drawers/DrawerInfoBox.cs(10,34): error CS0246: The type or namespace name 'InfoBoxAttribute' could not be found (are you missing a using directive or an assembly reference?)
Library/PackageCache/com.pixeye.ecs@b0136155b5/Editor/Drawers/DrawerScene.cs(22,31): error CS0246: The type or namespace name 'SceneReference' could not be found (are you missing a using directive or an assembly reference?)
Library/PackageCache/com.pixeye.ecs@b0136155b5/Editor/Drawers/DrawerTags.cs(14,31): error CS0246: The type or namespace name 'TagFilterAttribute' could not be found (are you missing a using directive or an assembly reference?)
Library/PackageCache/com.pixeye.ecs@b0136155b5/Editor/Drawers/DrawerTags.cs(22,10): error CS0246: The type or namespace name 'FastString' could not be found (are you missing a using directive or an assembly reference?)
Library/PackageCache/com.pixeye.ecs@b0136155b5/Editor/SceneProcessors/PostHandlePools.cs(66,70): error CS0246: The type or namespace name 'Starter' could not be found (are you missing a using directive or an assembly reference?)
Library/PackageCache/com.pixeye.ecs@b0136155b5/Editor/Inspector/InspectorOverride.cs(279,11): error CS0246: The type or namespace name 'FoldoutGroupAttribute' could not be found (are you missing a using directive or an assembly reference?)
Library/PackageCache/com.pixeye.ecs@b0136155b5/Editor/Inspector/InspectorReordarable.cs(439,41): error CS0246: The type or namespace name 'ReorderableAttribute' could not be found (are you missing a using directive or an assembly reference?)

Hey @slimshader , what kind of dependency?

Actors dependency via
"com.pixeye.ecs": "https://github.com/dimmpixeye/actors.git"
to the packages of course ;)

@slimshader ye, I've messed with metafiles, sorry.
Try now to update. Also make sure your Pixeye.Source file got Pixeye.Actors lib

closing as there was no response for a long time.


Normal matrix working with only the inverse of model matrix

In the GraphicsComponent::render() function, the normal matrix is calculated using only the inverse of the model matrix; it should both be transformed and inverted. However, although this is mathematically wrong, it works as expected.

See commit message db4d429 for details.


Fix formatting of word

@hpsin,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Thanks @hpsin for your sharp eye!  The update should appear on the live site momentarily.


Note about C-states on XPS 9370.

This isn't a bug with the repo, but might be useful information to have for anyone passing by.
On my XPS 9370, I've been seeing a lot of kernel messages complaining about thermal throttling (package/core above temperature), despite it being only 40-50 degrees. One of the widgets in my window manager was reporting the CPU temperature as 90 degrees even though it wasn't.
For some reason, disabling C-states in the UEFI fixes this. I'm inclined to say it's a firmware bug.

This explains something. Are you on BIOS 1.5.1?
Disabling C-States will disable all the CPU powersaving features so frequency scaling won't work anymore. Is that correct?

I currently have 1.4.0, and 1.5.1 is just a few IME updates, so an update is unlikely to fix anything. According to the information in the UEFI, C-states are for additional power savings during system idle or hibernation. P-states are still working and it will underclock the CPU to save power. Functionally, I've seen no difference from disabling C-states, but it's resolved all of the problems I was having.

Thanks for sharing. I'll have an eye on this from now on if this also happens on my machine.

This also doesn't happen anymore when a someone does a cold boot (with C-States enabled).

Closing this. I think it happens with SpeedStep still for me, but not C-states. Weird stuff. I think the kernel messages can be ignored.


Improve discoverability of other nodes by using a signaling server

Just between browser nodes. I don't think connectivity to our gateway is an issue, since whenever I check swarm.peers this peer id of the gateway is in there. Thoughts?
Also, see https://github.com/fission-suite/webnative/issues/77#issuecomment-686537305 for my thoughts on debugging all of this reliability stuff 👀

Cool that's what I thought. Just making sure we were on the same page :ok_hand:
:eyes: checking out that comment now


ztest: shell: Ztest framework enhancement.

This pull request introduces two significant improvements to the ZTEST framework:
New Macro: ZTEST_P
Introduces the new macro, ZTEST_P, enabling the creation of parameterized tests. These tests can receive parameters at runtime.
Includes new tests located in tests/ztest/ztest_params to validate and ensure the correctness of the ZTEST_P macro.
Enhanced ztest_shell Subcommands
run-testcase and run-testsuite: Both subcommands now support an additional -r (repeat-iter) parameter, allowing specific test cases or test suites to be executed multiple times.
Expanded run-testcase command: Adds a new -p parameter to the run-testcase subcommand, enabling the passing of parameters to tests at runtime.

hey, this needs a rebase

hey, this needs a rebase

Thank you, WIP.

@nashif Please take a look, and merge if possible.


ERROR in Ng2Bs3ModalModule is not an NgModule - angular cli, angular 4

I'm on an angular-cli project with Angular 4.
Running ng serve gives this error :
Hash: 6941a848791c0fb318c5
Time: 48865ms
chunk    {0} main.bundle.js, main.bundle.js.map (main) 4.07 MB {3} [initial] [rendered]
chunk    {1} polyfills.bundle.js, polyfills.bundle.js.map (polyfills) 167 kB {4} [initial] [rendered]
chunk    {2} styles.bundle.js, styles.bundle.js.map (styles) 65.6 kB {4} [initial] [rendered]
chunk    {3} vendor.bundle.js, vendor.bundle.js.map (vendor) 7.06 MB [initial] [rendered]
chunk    {4} inline.bundle.js, inline.bundle.js.map (inline) 0 bytes [entry] [rendered]

ERROR in Ng2Bs3ModalModule is not an NgModule
webpack: Failed to compile.

in package.json
"dependencies": {
  "@angular/core": "4.0.0",
  "@angular/forms": "4.0.0",
  "@angular/http": "4.0.0",
  ...
  "bootstrap": "3.3.7",
  "jquery": "2.2.4",
  ...
  "ng2-bs3-modal": "0.8.1",
  ...
},
"devDependencies": {
  "@angular/cli": "1.0.0",
  ...
}

in app.module.ts
import {Ng2Bs3ModalModule} from 'ng2-bs3-modal';
...
@NgModule({
  imports: [
    ...
    Ng2Bs3ModalModule,
    ...
  ],
  declarations: [...],
  providers: [...],
  bootstrap: [AppComponent]

After some research I found this :
It might be related with AOT compilation.
See this issue https://github.com/angular/angular-cli/issues/3426
And may be the comments below, in this issue : angular/angular#11262
https://github.com/angular/angular/issues/11262#issuecomment-244472000
https://github.com/angular/angular/issues/11262#issuecomment-244489405
This might help : https://angular.io/docs/ts/latest/cookbook/aot-compiler.html#!#compile
#176 May be related but no information was given.

You might find a work around in #143 that works for you.

If I launch ng serve a first time and then I modify any file, webpack will recompile and will not give the error.
With https://github.com/dougludlow/ng2-bs3-modal/issues/143#issuecomment-277515953, it gives me the same error (is not a NgModule).
With https://github.com/dougludlow/ng2-bs3-modal/issues/143#issuecomment-290730273 I get this error :
ERROR in [...]/node_modules/ng2-bs3-modal/src/ng2-bs3-modal/components/modal-instance.ts (74,47): Operator '===' cannot be applied to types 'ModalResult.Close | ModalResult.Dismiss' and 'ModalResult.None'.

And if I try to correct the line in /modal-instance.ts/modal-instance.ts :
let result = (!this.result || this.result === ModalResult.None)

to
let result = (this.result === ModalResult.None)

I'm not getting compile error anymore.
Not suitable for my project as I'm not working alone on it.

Wow, I don't know why I didn't checked that before but the last version of ng2-bs3-modal is 0.10.4 and I was using 0.8.1
Updating the version resolved it...

Can happen :) Glad you got it figured out. If I remember well, I had the same issue with that error message as well.


Provide Auto-ML documentation link in user guide for running models

name
title
about
labels
assignees

Transparency Request
Provide Auto-ML documentation link

Describe the area of code that needs more transparency:
Provide Auto-ML documentation link in the user guide for running models
Describe the solution you'd like:
Describe the alternatives you've considered:
Additional context or comments:
If possible we should provide an easy way to expose deep links to the specific algorithms as part of our way to support Data Scientist making their work explainable

The auto-ML documentation link was included in the DXC-Industrialized-AI-Starter Notebook.


New: Add UI for subtotal requests

Description
Add subtotal UI buttons on column config panel to toggle rollup dimensions and grand total.
Proposed Changes

Create and wire up buttons to toggle rollup on dimension, datetime columns.
Create and wire up buttons to toggle grand total.
Buttons show up for data sources configured with the option: 'enableSubtotal'

Screenshots

License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@cythrawll when the sub-total is enabled does the background change like grand total? If so, can we change the sort enable/disable indicator to match?

@cythrawll when the sub-total is enabled does the background change like grand total? If so, can we change the sort enable/disable indicator to match?

Yeah i'll look at that. See screenshot for how it looks. I noticed i need to adjust the border-radius too.

@cythrawll does the screenshot above indicate that if sort is not enabled, the icon is grey? If so, can we make it blue like totals?

@kilroy no, the grey indicates that sort is not available for that column. it's disabled.
the not enabled look is blue just like subtotal icon.


Replace Carbon's exception with BadMethodCallException

Hey 👋
This PR proposes the replacement of Carbon's UnknownMethodException with PHP's native BadMethodCallException to catch unknown dynamic calls to BaseAssert instances.
The reason for this, is that this will most probably confuse users when they encounter this exception as the stack trace is going to contain "Carbon", but direct Carbon usage is nowhere to be found.
With BadMethodCallException, there is no confusion possible.

Spot on. Think I accidentally imported the carbon one from phpstorm.


Correct action_cooldown translation (french translation).

Old translation was "Encaisse" which means takes damages instead of takes time.

Thanks, @matheod!


[SPARK-36827][CORE] Fix perf issue in AppStatusListener.cleanupStages

What changes were proposed in this pull request?
This PR fixes a performance issue in AppStatusListener.cleanupStages. When there are large number of stages in store, this logic below runs like N*M order.
    val stageIds = stages.map { s =>
      val key = Array(s.info.stageId, s.info.attemptId)
      kvstore.delete(s.getClass(), key)

      // Check whether there are remaining attempts for the same stage. If there aren't, then
      // also delete the RDD graph data.
      val remainingAttempts = kvstore.view(classOf[StageDataWrapper])
        .index("stageId")
        .first(s.info.stageId)
        .last(s.info.stageId)
        .closeableIterator()
        ...

Instead of accessing the view for checking remaining task per stage, this change is to move the logic after removing stages. Then it only needs to access the view(kvstore.view(classOf[StageDataWrapper])) once.
Why are the changes needed?
When there are more than ideal number of stages kept inside the memory, the clean up process is unable to catch up with the speed of incoming stages because of this perf issue, that leads to a behavior which looks like a memory leak.  Eventually it causes OutOfMemoryError.
Does this PR introduce any user-facing change?
No
How was this patch tested?
The behavior should be identical before and after the change, and the existing tests should verify that. This change has been applied to the environment where constant memory leak was observed. With the same load, now services are running perfectly healthy.

Can one of the admins verify this patch?

@taroplus I was working on this as well yesterday.  https://github.com/apache/spark/pull/34092
If we have to pull all the stage data out from KVStore, we should avoid calling KVUtils.viewToSeq(view, countToDelete.toInt) which will copy the stage data and perform sorting.

in favor of
https://github.com/apache/spark/pull/34092


PY3 compatibility issue in scrapy-redis/src/scrapy_redis next_requests()

It works fine in PY2.
but as for PY3, it sucks.
2016-08-22 09:00:05 [scrapy] ERROR: Error caught on signal handler: <bound method RedisMixin.spider_idle of <RighticSpider 'rightic' at 0x7efe1de59390>>
Traceback (most recent call last):
  File "/home/eric/.virtualenvs/scrapy3/lib/python3.5/site-packages/scrapy/utils/signal.py", line 30, in send_catch_log
    *arguments, **named)
  File "/home/eric/.virtualenvs/scrapy3/lib/python3.5/site-packages/pydispatch/robustapply.py", line 55, in robustApply
    return receiver(*arguments, **named)
  File "/home/eric/.virtualenvs/scrapy3/lib/python3.5/site-packages/scrapy_redis/spiders.py", line 109, in spider_idle
    self.schedule_next_requests()
  File "/home/eric/.virtualenvs/scrapy3/lib/python3.5/site-packages/scrapy_redis/spiders.py", line 103, in schedule_next_requests
    for req in self.next_requests():
  File "/home/eric/.virtualenvs/scrapy3/lib/python3.5/site-packages/scrapy_redis/spiders.py", line 84, in next_requests
    req = self.make_request_from_data(data)
  File "/home/eric/.virtualenvs/scrapy3/lib/python3.5/site-packages/scrapy_redis/spiders.py", line 96, in make_request_from_data
    if '://' in data:
TypeError: a bytes-like object is required, not 'str'
2016-08-22 09:00:05 [scrapy] INFO: Closing spider (finished)
2016-08-22 09:00:05 [scrapy] INFO: Dumping Scrapy stats:
{'finish_reason': 'finished',
 'finish_time': datetime.datetime(2016, 8, 22, 1, 0, 5, 210158),
 'log_count/ERROR': 2,
 'log_count/INFO': 8,
 'start_time': datetime.datetime(2016, 8, 22, 1, 0, 4, 378904)}
2016-08-22 09:00:05 [scrapy] INFO: Spider closed (finished)

Consider to add decode() like this:
def next_requests(self):
        """Returns a request to be scheduled or none."""
        use_set = self.settings.getbool('REDIS_START_URLS_AS_SET')
        fetch_one = self.server.spop if use_set else self.server.lpop
        # XXX: Do we need to use a timeout here?
        found = 0
        while found < self.redis_batch_size:
            data = fetch_one(self.redis_key).decode()
            if not data:
                # Queue empty.
                break
            req = self.make_request_from_data(data)
            if req:
                yield req
                found += 1
            else:
                self.logger.debug("Request not made from data: %r", data)

        if found:
            self.logger.debug("Read %s requests from '%s'", found, self.redis_key)

Related with #49

@tyong920 you should not decode directly. While the spider start to run, if the start_urls is empty, here
fetch_one(self.redis_key)

will be None. So it will raise error if you decode a None.

@tyong920 My solution is #70, I change the position of data.decode()

Related: https://github.com/rolando/scrapy-redis/pull/71

@kingname It is better. Good job! Thanks!

Fixed in #71


Citation information/guidance

@patmarion Do you have a pre-prepared bibtex snippet on how to best cite the director? And would you like to add this citation information to the readme?
Thanks,
Wolf

No, I don't have bibtex for citing the director.  The closest thing that has been published might be the JFR paper on affordance based planning.
https://scholar.google.com/citations?view_op=view_citation&hl=en&user=BqV8LaoAAAAJ&citation_for_view=BqV8LaoAAAAJ:Zph67rFs4hoC
If you'd like to cite the source code, perhaps a cite to the github url?

I encourage you to have one recommended citation form for the Director (I'll use it). For example, Drake has the following:

Citing Drake:
If you would like to cite Drake in your academic publications, we suggest the following BibTeX citation:
@misc{drake,
author = "Russ Tedrake",
title = "Drake: A planning, control, and analysis toolbox for nonlinear dynamical systems",
year = 2014,
url = "http://drake.mit.edu"
}

I think you can do something similar using the github link.

Following the drake style citation, it could be:

@misc{director,
author = "Pat Marion",
title = "Director: A robotics interface and visualization framework",
year = 2015,
url = "http://github.com/RobotLocomotion/director"
}

I don't like that the citation gives me sole credit for the software since it has seen many contributors, but it's fair to say I am the primary author and maybe in the future there will be a paper to cite that could be used to update this.  What do you guys think?

In my view this works well! I'll be happy to use it.
It can be augmented when the paper is out (keeping the url).
Also, the git history shows the contributions.

I feel the same about drake.  It made more sense when i posted it, but now feels silly.

On Aug 10, 2015, at 12:12 PM, Pat Marion<EMAIL_ADDRESS>wrote:
Following the drake style citation, it could be:
@misc{director,
author = "Pat Marion",
title = "Director: A robotics interface and visualization framework",
year = 2015,
url = "http://github.com/RobotLocomotion/director"
}
I don't like that the citation gives me sole credit for the software since it has seen many contributors, but it's fair to say I am the primary author and maybe in the future there will be a paper to cite that could be used to update this. What do you guys think?
—
Reply to this email directly or view it on GitHub.


Fix Url serialization in strawberry shake

Change Uri serialization in strawberry shake.
Closes #4087

can you cherry pick the change to main as well? I can do a hot fix for that.


fix stepper input style

Fixes 90 .

Changes proposed in this Pull Request:

Fix stepper input style

Screenshots:

To Test:
Run yarn start
Click on...http://localhost:4200/material-components/navigation-components
stepper card and fill in input fields

Applying changes to the mat input styles is going to how all input fields look; here's a picture of before & after.
Before:

After:

Applying changes to the mat input styles is going to how all input fields look; here's a picture of before & after.
Before:
After:

Hi Evan, yes it affects every mat-input. Could you please review it again? I added it under mat-stepper-horizontal, .mat-stepper-vertical wrapper.


How do Quasar prebuilts and Quasar Source code builds compare

Do you keep updating the <IP_ADDRESS> version is releases or is it recommended to always upgrade from source code?

It is recommended to always use the latest version. I don't have the time to support older versions. Please check out the upgrade guide: https://github.com/quasar/Quasar/wiki/Updating-a-Client


The path is not right with query

my config is:
plugins: [
    libAssetsPlugin.default({
        name: '[contenthash].[ext]?[query]'
    })
]

when i import a image with query like that:
import xx from './assets/img/talos.png?base=cdn';

and the result is：
import xx from './assets/img/talos.png?base=cdn';

replacement failed

https://github.com/laynezh/vite-plugin-lib-assets/blob/ae559d4d898c50f4d80a326bcfaea6d4722c83c9/src/index.ts#L199

@BUPTlhuanyu I wasn't able to reproduce the issue you encountered, code. Could you provide a minimal reproducible example of the issue?


Some parameters are not compatible with RHEL6

Hi,
I have found that following parameters are causing a troubles with rsyslog-5.8.10-10.el6_6.x86_64 :
$imjournalRatelimitInterval
$imjournalRatelimitBurst
Those parameters are specified inside of templates/rsyslog.conf.erb:
<% if scope.lookupvar('rsyslog::im_journal_ratelimit_interval') and scope.lookupvar('rsyslog::im_journal_ratelimit_interval') != :undef -%>
$imjournalRatelimitInterval <%=scope.lookupvar('rsyslog::im_journal_ratelimit_interval') %>
<% end -%>
<% if scope.lookupvar('rsyslog::im_journal_ratelimit_burst') and scope.lookupvar('rsyslog::im_journal_ratelimit_burst') != :undef -%>
$imjournalRatelimitBurst <%=scope.lookupvar('rsyslog::im_journal_ratelimit_burst') %>
<% end -%>
This module should protect user from putting an invalid options and impacting the rsyslog service. It is not the cleanest idea to accomplish this due to defining undef in params.pp. This undef can be overloaded and cause impact. User should be protected by extra condition that will protect RHEL6 rsyslog config from containing those parameters no matter if variable is undef or not
Kind Regards,
Bart

That looks like a job for validate calls.  There seems to be no validation in this module.  Would you be able to create a PR, or at least what kind of data is expected there? Integer only?

Hi,
For RHEL6 we have rsyslog-5.8.10 but in RHEL7 ... rsyslog-7.4.7-. Somewhere in between imjournal module was added. I believe that depending on a rsyslog version those two parameters should not appear in a config file. This will apply not only for RHEL but also for other distros and OSes.
Above this version both parameters are optional and should be validated as integers >0 but i have not yet seen any documentation that confirms that for good.

I use this module with RHEL6 servers without problem. What you mean is that if someone sets a value to either $imjournalRatelimitInterval  or $imjournalRatelimitBurst, rsyslog will not start, right?

There is two things to blame in my environment:

hiera configuration

Efficiently i am stacking two files:
Rhel6/common.yaml (i can define everyting here)
common.yaml (i am not permitted to touch this one in our deployment)
The clue is that common.yaml contains definitions that are siuted for RHEL7.
$imjournalRatelimitInterval someint
$imjournalRatelimitBurst someint
So for RHEL6 i have do undefine the default hiera. Please correct me if i am wrong but this simply can't be done.

unfortunate conditionals inside of rsyslog.conf.erb

Since I cannot touch default hiera and cannot undefine options that was once defined (look for paragraph 1) i have no other way than editing the template.
No matter what hiera architecture i am forced to use - for RHEL6 rsyslog following parameters are invalid (and erb have to be set in a correct way to keep them out):
$imjournalRatelimitInterval someint
$imjournalRatelimitBurst someint
... And also following should be off:
Turn off message reception via local log socket;
local messages are retrieved through imjournal now.
$OmitLocalLogging off
My opinion is that module by default should prevent using invalid parameters and causing a service impact. Please let me know Your opinion since we may consider mitigation by implementing #266 as well.
Regards

According the the puppet 4 documentation (https://puppet.com/docs/puppet/4.10/lang_template_erb.html#scopevariable-or-scopelookupvarvariable) you should use nil to check for undef, not :undef. This module works fine on RHEL7 but for RHEL6 is adds the following section with blank values:
$imjournalStateFile
$imjournalIgnorePreviousMessages
$imjournalRatelimitInterval
$imjournalRatelimitBurst

If I change the code in rsyslog.conf.erb so it tests for nil instead of :undef, the imjournallines don't get added to the config file as expected. So for this module to work correctly (for me anyway) the :undef tests need to change to nil in the templates.
So this section:
# Settings for imjournal (If supported)
<% if scope.lookupvar('rsyslog::im_journal_statefile') != :undef -%>
$imjournalStateFile <%=scope.lookupvar('rsyslog::im_journal_statefile') %>
<% end -%>
<% if scope.lookupvar('rsyslog::im_journal_ignore_previous_messages') != :undef -%>
$imjournalIgnorePreviousMessages <%=scope.lookupvar('rsyslog::im_journal_ignore_previous_messages') %>
<% end -%>
<% if scope.lookupvar('rsyslog::im_journal_ratelimit_interval') != :undef -%>
$imjournalRatelimitInterval <%=scope.lookupvar('rsyslog::im_journal_ratelimit_interval') %>
<% end -%>
<% if scope.lookupvar('rsyslog::im_journal_ratelimit_burst') != :undef -%>
$imjournalRatelimitBurst <%=scope.lookupvar('rsyslog::im_journal_ratelimit_burst') %>
<% end -%>

Needs to change to:
# Settings for imjournal (If supported)
<% if scope.lookupvar('rsyslog::im_journal_statefile') != nil -%>
$imjournalStateFile <%=scope.lookupvar('rsyslog::im_journal_statefile') %>
<% end -%>
<% if scope.lookupvar('rsyslog::im_journal_ignore_previous_messages') != nil -%>
$imjournalIgnorePreviousMessages <%=scope.lookupvar('rsyslog::im_journal_ignore_previous_messages') %>
<% end -%>
<% if scope.lookupvar('rsyslog::im_journal_ratelimit_interval') != nil -%>
$imjournalRatelimitInterval <%=scope.lookupvar('rsyslog::im_journal_ratelimit_interval') %>
<% end -%>
<% if scope.lookupvar('rsyslog::im_journal_ratelimit_burst') != nil -%>
$imjournalRatelimitBurst <%=scope.lookupvar('rsyslog::im_journal_ratelimit_burst') %>
<% end -%>

@bojleros - you can undefine a previously set value in hiera using the ~ (tilda) character.
ie: rsyslog::im_journal_ratelimit_interval: ~ at a higher level in the hierarchy will undefine the value.


Corrected error and added logging

Fixed error from merge on Friday

Could you fix this log message so its indented consistently with others. Or vice versa.

The reason the previous log message is indented more is because it is inside of an If statement

And line 34-38?


final submit

Related Issue

Change UI of math calculator

Fixes: #[330]
Describe the changes you've made
all problem fixed
Checklist:

[x ] My code follows the style guidelines of this project.
[ x] I have performed a self-review of my own code.
[ x] I have commented my code, particularly in hard-to-understand areas.
[x ] I have made corresponding changes to the documentation.
[x ] My changes generate no new warnings.

Screenshots

Original
Updated

original screenshot
updated screenshot


[Bug] you can pipe items that are not the magic lamp into the dimensional mineshaft (with a pipe from other mods like i used from mekanism) and causing the game to crash

@boboop143 please provide a crashlog to diagnose the issue. Generally speaking input will likely not be restricted, as e.g. kubejs could create new miner items. Instead I'll try to make any input compatible/not cause the crash

@boboop143 please provide a crashlog to diagnose the issue. Generally speaking input will likely not be restricted, as e.g. kubejs could create new miner items. Instead I'll try to make any input compatible/not cause the crash

crash-2021-01-25_13.59.26-server.txt

crash-2021-01-25_13.59.26-server.txt

i is fixed but i think i forgot to tell that the game crashed only when the bar of the shaft filled up

i is fixed but i think i forgot to tell that the game crashed only when the bar of the shaft filled up


Add Fantour Token

Fantour Introduction:
Fantour is a celebrity-oriented NFT marketplace built on Polkadot Chain. We committed to fertilize the interaction between celebrities and fans, to increase the “co-creation of value” by gaining ownership of a unique piece of work that originally comes from the following celebrities or even makes a profit from reselling to other collectors. We are a decentralized platform that allowed users to buy, sell and trade any kind of celebrity-related products ( Digital Music EP, Concert Merch NFTs), especially NFT Online Event Tickets.
Fantour team:
CEO Shawn: Bachelor's Degree at the University of California, Los Angeles(UCLA); Senior IT consultant in big four accounting firm. Specialist in management consulting, strategic analysis, IT system implementation, risk management, and Audit.
CTO Joe: Master's Degree at London School of Economics; Senior blockchain developer; Senor IT consultant in big four accounting firm. Specialist in IT management, IT risk assessment, IT audit, IT and business coordination, business continuity management, and data governance services.
More Info:
Website: https://fantour.io/
Twitter: https://twitter.com/FantourOfficial/
Telegram: https://t.me/fantourofficial
Medium: https://fantour.medium.com/

Not ERC20-Token


array-callback-return

(array-callback-return)[http://eslint.org/docs/rules/array-callback-return]
If you're not returning on an array method callback, you're probably using it wrong.

Does this error on with the following:
const arr = [1,2,3]
const addOne = (i) => i + 1 // implicit return, shouldn't error
arr.map(addOne)

if example from @joshgillies passes, i'm up for it


small fixes for features2d tutorials

addtional Mask argument in detectAndCompute()
setMinHessian() -> setHessianThreshold()
cv::line is in imgproc nowadays

I think, minHessian is fine. It complements the method name to indicate that it's minimum hessian allowed for a captured feature. :+1:


Upload anchor mods made by: Deus Corvi && LeonZ, Update Change Log.

did you get perms from Crow and Leonz to upload them?


Fixes #376. Uses timeout to prevent events that trigger multiple even…

MDL version:
1.1
Browser:
Chrome, Firefox
Browser version:
Chrome 51.0.2704.103 , Firefox 47.0
Operating system:
OSX Yosemite
Operating system version:
10.10.5
URL, if applicable
Plnk
Youtube Demo
What steps will reproduce the problem:

Tap on any mdl button, using a Macbook Pro touchpad

What is the expected result?
Ripple Animation
What happens instead of that?
Nothing, and on occasion, short ripple.
Please provide any other information below, and attach a screenshot if possible.
Demo of this is provided

Thanks to sompylasar and Garbee for guidance. Based on conversation with sompylasar, chose not to use .bind(this) in this solution. Took inspiration from Angular Material ripple.js to capture this. ctrl chosen because couldn't find a shorter 4 letter abbreviation that made more sense (and don't like that).
window.setTimeout and window.requestAnimationFrame used in favor of setTimeout and requestAnimationFrame to fit with 1.1 use of the same.

I still on occasion see flashing animation, I think related to the use of clearTimeout.

I don't think this is ready to merge. This pr still has a race condition between mouseup and mousedown, which can lead to the ripple container being hidden prematurely. Can be triggered by a well timed double or triple click. I'm happy to take suggestions, would love to contribute, thanks for your time.

Hello there! We're currently doing some housecleaning on the repository to prepare for the big changes to v2, and part of this is to close the mdl-1.1 and mdl-1.2 branches, and move all 1.1 and 1.2 PRs to the mdl-1.x branch. Since it's not possible to target PRs at a new branch, we're closing this PR and asking you to reopen against mdl-1.x if you think it's still valid.
Thank you!

Ok, thanks for letting me know!


Refactoring - Change internal state

For resolving internal references it is used a stack of states, and it adds a state each time function goes into recursion. To find appropriate context, validator creates an object. This should be optimized at least to create a state only if necessary.

Refactor state stack mechanism.

Remove toFunction


openpose_editor_index 404

Describe the bug
Chrome report 404 error, the path https://my_stable_diffusion_domain/openpose_editor_index
{"detail":"Not Found"}

To Reproduce
Steps to reproduce the behavior:
After installation, only.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Environment

OS: [e.g. iOS] Windows (Server on Linux x64)
Browser [e.g. chrome, safari] Chrome

Additional context
Add any other context about the problem here.

See https://github.com/fkunn1326/openpose-editor/issues/127. Wrong repository.


[NTR] Removed the collapsibility of the advanced settings

Coverage remained the same at 41.591% when pulling 3978eee145a9051c08252b9a4deab450345db570 on NTR-safari-compatibility into efdd90a08592fe248bbf442e7291c1327a03a3ba on master.


Evaluate new Datomic changes

In particular:

Tempids and explicit partitions are now optional, simplifying code for the many programs that do not care about them.
Schema install and update are now implicit, and do not require explicit :db.install/attribute or :db.update/attribute datoms.

More: http://blog.datomic.com/2016/11/datomic-update-client-api-unlimited.html

This release of Datomic comes with a simple remote client API. It looks like they ran into the round-trip tempid problem, given the last sentence in this bit:

Starting with the current release of Datomic:

tempids are optional
when you need a tempid to coordinate the relationship between two entities, you can use an ordinary string instead of a tempid structure, and that string can be meaningful to readers of your code
the existing tempid data structure and API continue to be supported unchanged. Use them if you want them.

Clients will support string tempids only.


[feature/adding_toolbar_to_demo] Adding toolbar to the demo app

Adding a simple toolbar to the demo activity. It server two purposes:

Effect are easier to apply using fewer user actions
Demonstrating how a custom toolbar can be created

I agree wholeheartedly that switching to a toolbar model is the right long-term answer. However:

I do not want to change the main activity just yet. Having this sort of a toolbar on a second activity, as a separate demonstration, would be more reasonable.

I cannot accept pull requests of this magnitude. This is why I request, in the project README, to open an issue, not just send over a pull request, as I could have saved you some time.

Long term (by which I hopefully mean in a few months), I will be adding support for Toolbar and a workalike in the library itself (not just the demo app), and my focus will be on that.

If you would like me to point people to your version of the demo app with this feature, give me a stable URL, and I'll link to it from the README.


Social element: Padding-top/right/bottom/left not working

Describe the bug
Padding-top/right/bottom/left not working on a single social element. Normal padding and giving 4 values does work.
To Reproduce
Steps to reproduce the behavior:
Provided MJML:
<mj-social-element name="instagram-noshare" href="https://www.instagram.com/" padding-bottom="10px" background-color="#A1AEE0" border-radius="20px">
Received HTML:

Expected behavior
Not entirely sure where I should expect the padding-bottom (for example) to be.
MJML environment (please complete the following information):

I was testing this on the live Email Editor https://mjml.io/try-it-live/

Let me know if I need to provide more information for this but it should be easily reproduced in the live editor.
NOTE: padding="20px 20px 20px 20px" does work but not padding-top="20px" padding-right="20px" padding-bottom="20px" padding-left="20px"

It seems that they're not bound to the td that's why it doesn't work 😄 https://github.com/mjmlio/mjml/blob/master/packages/mjml-social/src/SocialElement.js#L150 feel free to open a PR about it 👍

Should be good in last version !


Create a pypi release

Once we have merged #115 , we will be able to have a poetry-only install which means a pypi release shouldn't be too hard. Then people can directly install with pip.

There seems to be a new concept for pypi "organizations". We should look into this.

@asidhu0 can you check if we can have an individual person host this on pypi and then later transfer it to the OFO org?

can have an individual person host this on pypi and then later transfer it to the OFO org?

A project can be transferred to any organization owned by the user, so the individual release must happen under @youngdjn account. @youngdjn may be able to add me as an owner of the organization but I'm not sure if the can do that if the organization hasn't been approved yet.

According to this post it seems that you can transfer ownership of a project ("name") to another user. So I believe that even if @youngdjn can't make you an org owner for some reason, you could just transfer the project to him and then he could add it to the org.
Given this discussion, how do you feel about releasing it to your pypi account? The actual steps should be fairly simple. I think I used this tutorial last time, specifically the How to Publish the Package section.


Trying localhost on browser not working

With a clean pull of this repo, when I start the containers and I try to access to the django app via browser it doesn't work.
If I try localhost:80 it results in a ERR_CONNECTION_REFUSED, no server in this adress
If I try localhost:8000 it results in a ERR_EMPTY_RESPONSE.
Any idea how to solve it?
PS: I'm using Docker on Mac
The lastest log in the web container is:
dsz01     | [2017-06-13 12:04:51 +0000] [9] [INFO] Starting gunicorn 19.6.0
dsz01     | [2017-06-13 12:04:51 +0000] [9] [INFO] Listening at: http://<IP_ADDRESS>:8000 (9)
dsz01     | [2017-06-13 12:04:51 +0000] [9] [INFO] Using worker: sync
dsz01     | [2017-06-13 12:04:51 +0000] [12] [INFO] Booting worker with pid: 12

I have same problem, how did you solve it?

me too , I think it`s not working ...

You needed to change some configurations in settings.py to make it working. But in new update, I have discarded everything. Now it should work fine and you should see a working page at localhost:8000.
Please make a fresh pull again and start from make build then make up


Fill Timestamp file for versionning

Could you integrate my modification? and publish this new version,
Thank you

@malys I reworked your https://github.com/malys/grunt-newer/commit/c82d53b6e9501ac41e02a42ec669e6748c806afe commit and published 1.1.0.
If you still need something like the second commit, please open a separate pull request describing the use case.
Regarding alternatives to time for comparing changes, I started some time ago on adding md5sum comparison (see 75e4947909bc9307a82cb537062dffbd6e1ecd25).  The hash generation and comparison functions are in lib/util.js.  If anybody wants to take a stab at hooking them up, feel free.  I was imagining adding support for a method option to the newer task.  By default, mtime would be compared.  Optionally, md5sum could be supported.

Many tanks. I will update my dependency and try it.


Dev to master

Split out NS visualization from validation and testing.  Incorporate changes from @audiefile on top of @eyim updates in master.  Incorporate @oskarpearson's #45.

Approving based on prior review. Still need some attention on the Visualization section for people to validate all the commands work for a from-scratch setup, and to better match the overall style of the rest of the docs, but fine generally content-wise as a starting place.


[README] add pairing instructions

I will move later the changes to the README.md in the directory tesla_ble_mqtt


Add E2B as a third_party example

Adding two examples with E2B Code Interpreter SDK and Codestral (one example in Python, and one in JS/TS).
The examples show a simple AI data analyst that is working with a CSV file and generates chart as a PNG file, based on the provided data. It's running code in the secure sandboxed environment by E2B.

Hi @tizkovatereza, thanks so much for the PR! There are some conflicts in your PR, could you help resolve? Also, would it be possible for you to ping package versions when installing packages?

Merged! Thank you so much @tizkovatereza!


CLI usage docs appear to be wrong/misleading

Gitea version (or commit ref): 1.12.6
Git version: 2.25.1
Operating system: Ubuntu 20.04.1 LTS
Installed from binary download
Running on the command line
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[x] No

Log gist: N/A

Description
I was looking to list all users at the command line, which (according to the docs ), should be as easy as running gitea admin user list. However, when I do that, I get No help topic for 'user'.
Running gitea admin --help only lists the following subcommands:

create-user
change-password
repo-sync-releases
regenerate
auth

Screenshots

This has changed in a later version, and the docs match that version. The PR where this has changed is: https://github.com/go-gitea/gitea/pull/10492


Make auth optional in withAuthRequired (withAuth ?)

The withAuthRequired helper is useful for pages which should only be accessed by authenticated users, but there is a use-case for pages which are public, but could still take advantage of a user server-side prop when a user is authenticated.
It would be great to do something along the lines of renaming withAuthRequired to withAuth, and make authRequired a boolean argument – if true, redirect if no user is authed, if false, continue but set user to null.
There are clearly other options re naming the arguments etc.

That's an interesting idea indeed, we'll discuss, thanks for suggesting!

I think this is a fantastic idea and hit this exact problem in a side project I was working on 💯

This is now possible via withPageAuth


Reputation from recovery again

Custom Barn Kit has the value "reputationKerbalRecovery = 25" which also applies to tourists at recovery giving too many reputation points compared to mission rewards. This makes reputation too easy to max out.

Fixed by d4d7b6b


update workflow files

Overview
A lot of this housekeeping PR is dealing with moving dependencies to Suggests:, following the guidance in this chapter.

From now on, we should not use @importFrom package function in roxygen, but instead use usethis::use_import_from("package", "function"), which will add the equivalent @importFrom() statement to gsm-package.R
A fair amount of reporting packages were moved to Suggests:, and rlang::check_installed() will see if the package is available, and if not, it will prompt the user to install the necessary packages.

On a system-level deployment/installation, as long as {gsm} is installed with dependencies = TRUE, there should be no issues.

Fix #1203
Fix #1468
Fix #1280

One other question - will check() determine whether a function is not namespaced?  Well, I guess all external functions  will be ::'d going forward.

One other question - will check() determine whether a function is not namespaced? Well, I guess all external functions will be ::'d going forward.

If we add a new function from {pkgFoo} and don't add it to the NAMESPACE, R CMD Check should throw an error like this:
❯ checking dependencies in R code ... WARNING
  '::' or ':::' import not declared from: pkgFoo


Docs should clearly elucidate the difference between prod and dev images

Specifically, I find this wording to be rather confusing (taken from https://www.balena.io/docs/reference/OS/overview/2.x/#dev-vs-prod-images):

Passwordless SSH into balenaOS on port 22222 as the root user.
Docker socket exposed on via port 2377, which allows balena local push to do remote Docker builds on the target device.

The production images have all of the above functionality disabled by default

To me this implies that ssh & a docker socket are generally disabled in prod, but what we mean specifically is that passwordless ssh is disabled, and an exposed docker socket is disabled.

The port number 2377, is it even correct? I thought it was 2375. I've definitely been using 2375... Maybe I'm missing out on 2377 features. :-)


Python program to check if the number is an Armstrong number or not using for loop method

i want to add armstrong number using for loop

This algorithm has been implemented already


Build crash. Requires fail

+ cargo build --release
    Updating crates.io index
error: failed to select a version for the requirement `clap = "^4.0.13"`
candidate versions found which didn't match: 3.2.22, 3.2.21, 3.2.20, ...
location searched: crates.io index

rmt 0.1.7
linux x86_64
cargo 1.59.0
rustc 1.59.0

Hi,
I built the project on my side and didn't find any issues.
Can we have more information on your system, please? 😄

Build in chroot containers


The tabs Bugs and Reports remain empty

Hello,
What is supposed to be shown under the bugs and reports section?
Now these remain empty while under the statistics tab there's reference on 7 reports.
Might it be related to uploading a mapping file?
Thanks!

Reports should always show all reports. Bugs is a bit more flexible, but show something. I think #89 is related to this. Are you running acrarium on tomcat?

I run it from docker-compose (behind Traefik) inside docker image: f43nde 1r/acrarium:latest
I don't know what is inside the docker image exactly.
Maybe that image it not in sync with the latest sources?

Found it! It's Safari related. Nice Bugs and Reports show up in Firefox and Brave!
Sorry for the confusion.

Ah well, not much can be done there. Although it is weird - vaadin lists safari as compatible https://vaadin.com/faq#what-technologies-does-vaadin-support


Kitchen Floor recipe only gives one block in 1.12?

fixed in next version

When does the next version come out? It’s been over three months since the last version of the mod.

You actually updated it. Wow. Thanks.

@blay09 Wow, you actually updated it. Thanks!


[opencypher compatibility][bug] keywords recognize error

If you need a set as a column name, try it this way
return 1 as `set`


more

zum Beispiel auf Citybuilds, Plots aushölen, minen, etc

I can't understand your message, transtators translating your comment too bad. Write it on english please.


Build.SourceBranchName does not include full name, if name includes forward slash

Agent version and platform
Version of your agent: 2.105.7
Windows Server 2012 R2
VSTS type and version
On-Prem TFS 2017
What's not working?
The Build.SourceBranchName variable does not include full branch name, if branch name includes forward slash like feature/mynewfeature or bug/bug1234.
If the branch includes a forward slash, then Build.SourceBranchName will only include the last segment: mynewfeature or bug1234.
Actual:

Build.SourceBranch
Build.SourceBranchName

refs/heads/feature/mynewfeature
mynewfeature

refs/heads/bug/bug1234
bug1234

Expected:

Build.SourceBranch
Build.SourceBranchName

refs/heads/feature/mynewfeature
feature/mynewfeature

refs/heads/bug/bug1234
bug/bug1234

Build scripts
You can reproduce by creating a branch called feature/something
and have a build definition with a singe powershell script:
Write-Output "BUILD_BUILDNUMBER = ${env:BUILD_BUILDNUMBER}"
Write-Output "BUILD_SOURCEBRANCH= ${env:BUILD_SOURCEBRANCH}"
Write-Output "BUILD_SOURCEBRANCHNAME= ${env:BUILD_SOURCEBRANCHNAME}"
Write-Output "BUILD_SOURCESDIRECTORY= ${env:BUILD_SOURCESDIRECTORY}"
Write-Output "BUILD_SOURCEVERSION= ${env:BUILD_SOURCEVERSION}"

Output
2017-03-07T12:17:43.4744817Z ##[section]Starting: PowerShell Script
2017-03-07T12:17:43.6463541Z ##[command]. 'C:\Users\TFSBUILD\AppData\Local\Temp\3ed8057f-da6d-4ee2-9e51-04fb192d1677.ps1'
2017-03-07T12:17:44.9782144Z BUILD_BUILDNUMBER = mybuild_07
2017-03-07T12:17:44.9782144Z BUILD_SOURCEBRANCH= refs/heads/feature/something
2017-03-07T12:17:44.9782144Z BUILD_SOURCEBRANCHNAME= something
2017-03-07T12:17:44.9782144Z BUILD_SOURCESDIRECTORY= D:\B\A1\_work\17\s
2017-03-07T12:17:44.9782144Z BUILD_SOURCEVERSION= 264c7662370f39ef0db9ab2c46489a686ac22724
2017-03-07T12:17:45.1344955Z ##[section]Finishing: PowerShell Script

Expected output
...
2017-03-07T12:17:44.9782144Z BUILD_SOURCEBRANCH= refs/heads/feature/something
2017-03-07T12:17:44.9782144Z BUILD_SOURCEBRANCHNAME= feature/something
...

@ChristophLindemann thanks for reporting, BUILD_SOURCEBRANCHNAME is a variable TFS/VSTS server set. I don't know why it set this way, i will see how can i fix it. :)

@TingluoHuang i'm not sure there is anything to do at this point. also this isnt an agent issue, the server sets. should we close the issue here?

We can't change the existing variable for compat reason, we can add a BUILD_SOURCEBRANCHFULLNAME if really needed. I will close the issue as Eric suggested.

@TingluoHuang & @ericsciple
The BUILD_SOURCEBRANCHFULLNAME solution would be really appreciated.
For example, we use the branch name to publish intermediate API doc releases to folders named the same as the branch. Now if two people or teams use a branch name that is equal in the last segment, the builds would override each other's output.
We also use it to drop artifacts in a common drop location, so testers can access build output, while developing features in different branches.
If it is not an agent issue, I kindly ask you to add it to the TFS on prem backlog (which is not public as far as I know)

Supporting GitFlow it can be useful to have the full branch name including the "prefix" feature/, hotfix/ and release/
+1

We would like to use full branch names to build linked template URIs for use with ARM templates
+1

@TingluoHuang & @ericsciple any chance of a workaround for this, if a feature is not made available?  I'm aware this isn't really in the wheelhouse of the agent, but we have no visibility of the workload for the VSTS project itself (as @ChristophLindemann has mentioned it's not public).  Some way of e.g. populating as a VSTS variable, that can be pushed through to the agent?  As others have said, this pretty much makes GitFlow unworkable as it stands unfortunately.

That would be really helpful to identify NuGet packages coming from features, hotfixes, etc. using semantic versioning

@gjonespf We have evaluated this in the past and made the determination not to change the existing variable. That’s not to say we won’t change it, but I imagine that likelihood to be very, very low especially given how many years this behavior has existed.
There are use cases for just the very last segment (e.g. releases/m123, and just the milestone component is required).
In your scenario it sounds, it sounds like the current solution would be to add a step that performs the string manipulation and sets the variable you desire. For example:
steps:

powershell: |
write-host "##vso[task.setvariable variable=branch]$($env:build_sourceBranch.substring($env:build_sourceBranch.indexOf('/', 5) + 1))"
script: set branch

I can't help but feel that the current functionality is simply wrong - if I create a branch called test/awesome-branch then the branch name is test/awesome-branch, not awesome-branch.
It's quite annoying to have a task group which works if they specify a branch without a slash in it, but breaks if it does.
What can we do to change your mind on this issue?

What is the status for this? Why has Build.SourceBranchFullName not been made available? What is the downside of adding this?
We would very much like to have this too, this not being the full branch name for git repos is useless so at least having a variable that is the full name should be added.

Has this issue been fixed in an upcoming version? The current behaviour is simply incorrect and renders the env var completely useless (and dangerous).

We use this variable for docker tags, and changing the behaviour of an existing variable will break our use. (e.g run docker tag on releases/*, tag using this variable to get repo/image:RelA for things from releases/RelA)
Adding a new variable is fine.

Agree with guys above. The current behaviour is incorrect. It is bug.

I've got the same frustrating problem today

I too, a few days ago was reading about the Team Foundation Build predefined variables and came across the Build.SourceBranchName variable and immediately realized it's severe shortcomings. I came here today quite by accident looking for information on something else entirely.
In any event, I was also looking at automating my version numbers and during my research I came across the following here: $(Build.SourceVersion.Replace('C','')) to get rid of the C prefixing the TFVC changeset ID. But, this string replacement on an MS Build variable is being performed from within an MSBuild script.
Remembering that I had seen string replacement performed on a variable, I was going to try something similar: $(Build.SourceBranch.Replace('$/TeamProjectName/','')) to get at anything after the Team Project name for TFVC. In Git, $(Build.SourceBranch.Replace('refs/*/','')), perhaps? But again, I'm not sure this would work as expected for modifying the Branch.SourceBranch variable, depending on whether or not you can use function calls on these like you can in MSBuild scripts. (I mean, I would think that the whole build is a giant MSBuild script, so, it might work?) If anyone knows off-hand whether or not this would work, or gives this a try before I get around to trying this myself, could you please report back here and mention me with the results?

I was also bitten by this bug... is there any variable with the correct branch name?

For reference, the issue was also reported/discussed here:
https://developercommunity.visualstudio.com/content/problem/578149/buildsourcebranchname-doesnt-handle-branches-with.html

BUILD_SOURCEBRANCHFULLNAME seems like an entirely reasonable solution to this. In my use case, it's primarily about consistency with other popular CI solutions; given the branch name iameli/example-branch, I'd get:

name
value

TRAVIS_BRANCH
iameli/example-branch

CIRCLE_BRANCH
iameli/example-branch

Build.SourceBranchName
example-branch

No need to rename the existing variable, but adding Build.SourceBranchFullName would make my life just a bit easier.

seems as if they are simply not listening...
:+1:

It was great to find this thread after wasting quite a bit of time trying to figure out why my branch name was 'merge' on all PRs. I am surprised Build.SourceBranchFullname is still not an option.
Unfortunately, in my case, I want to use this path as part of the 'ref' of a repository, which is parsed well before any script is run.

I use this code
- powershell: |
    # see also https://github.com/microsoft/azure-pipelines-agent/issues/838
    $SourceBranchLongName = switch ($env:Build_Reason) {
      'PullRequest' { $env:Build_SourceBranch.Replace('refs/pull/','').Replace('/merge','') }
      default { $env:Build_SourceBranch.Replace('refs/heads/','').Replace('refs/tags/','') }
    }
    Write-Host "##vso[task.setvariable variable=SourceBranchLongName]${SourceBranchLongName}"

to have set a SourceBranchLongName variable

It was great to find this thread after wasting quite a bit of time trying to figure out why my branch name was 'merge' on all PRs. I am surprised Build.SourceBranchFullname is still not an option.
Unfortunately, in my case, I want to use this path as part of the 'ref' of a repository, which is parsed well before any script is run.

Another vote for this. There are use cases where you must have the variable available before the possibility of running any scripts to work it out from other variables. For example, generating the build number/name. I place the branch name in my build number, but all PR builds just say "merge" which is utterly useless. I need to see "pull/12345/merge" or whatever the PR branch is called.
I agree with the others that this is a bug. If I have 2 branches as follows:
/difficult
/why/do/you/make/our/lives/so/difficult
Then according to the variable Build.SourceBranchName both of these branches are called difficult which is incorrect. It's not possible to differentiate, which is entirely the point of having a name.
Please introduce Build.SourceBranchFullName to allow us to get the actual branch name, not a substring of it.

Considering DevOps leaves you in multiple situations where you are on a Detached HEAD and GitFlow (and general folder paths in Git) are extremely popular, it's absolutely mind boggling that DevOps hasn't been updated to support a proper "branch name" strategy with variables. I understand that Microsoft has a bias for a release branching strategy, but real world scenarios at most companies have git flow like strategies. This is a large gap that should absolutely be solved.

I think 3 years is not enough for this feature.

I think 3 years is not enough for this feature.

There’s soo many things DevOps does well, and then there’s basic things like this...

@TingluoHuang @ericsciple  Do you know if there's another issue tracking the addition of a variable to get the full branch name or can we reopen this issue?
I believe this is still an issue and manually creating the full branch name as a variable via a script does not seem like a reasonable workaround for such a standard variable.

As a workaround for now I use Expressions so you can write something like:
name: $[ replace(variables['System.PullRequest.SourceBranch'], 'refs/heads/release/', '') ]

So you can get a build name 1.2.3 when building for a PR from realease/1.2.3 to master.
You can even do more complex things like this:
name: $[ variables['branchName'] ]

variables:
  ${{ if startsWith(variables['Build.SourceBranch'], 'refs/heads/') }}:
    branchName: $[ replace(variables['Build.SourceBranch'], 'refs/heads/', '') ]
  ${{ if startsWith(variables['Build.SourceBranch'], 'refs/pull/') }}:
    branchName: $[ replace(variables['System.PullRequest.SourceBranch'], 'refs/heads/', '') ]

trigger:
- master
pr:
- master

This way you can get the name of the source branch if it is a Trigger build or the name of the pull request source branch if that is a PR build.
This does not negate the fact that the shortcut-like Build.SourceBranchFullName feature is still needed.

I have the exact same issue. I need the branch name to communicate with the SonarQube API, but I'm missing the "feature/*" part which makes it impossible.

Same here. I'm not sure why this issue is closed, because it's not been resolved.

@TingluoHuang Can you please reopen this issue?
The solution would be to add a new variable that properly represents a git branch with slashes included and I think it's fair to resolve this issue AFTER that happens.

Do I read the comment chain correctly, there is still no solution for getting the full branch name? If so, to me this is a BUG, too!
Is there any feedback on further steps?

OK I found Build.SourceBranch which provides the info I need. Is this what the rest is looking for, too?

@ckolumbus I don't think so because that adds extra sutff like refs/heads/${fullBranchName}. It might work for some situations but not all

Well, this is still an issues as far as I can see. This baffles me.

Well, this is still an issues as far as I can see. This baffles me.

4 years down the line and this still hasn't been implemented.
Is there any update on this or do we have to use a workaround?

4 years down the line and this still hasn't been implemented.
Is there any update on this or do we have to use a workaround?

Is there any update on this or do we have to use a workaround?

I gave up on using Azure DevOps for CI on pull requests.

Is there any update on this or do we have to use a workaround?

I gave up on using Azure DevOps for CI on pull requests.

Still needing this.

Why this has been closed? The current value of $(Build.SourceBranch) is not different, but it's actually wrong.

In addition to @davidorbelian s excellent answer I just wanted to point out that the code can also be used in a compile-time expression, which works on any place of the pipeline: ${{ replace(variables['Build.SourceBranch'], 'refs/heads/', '') }}
My use case was that I wanted to get that value in a pipeline (step) template, where I wasnt allowed to define an additional variables block.

This is an issue for us also. Like a couple of others who have posted, we can't use string manipulation within a task because we need to use it right at the top of the pipeline, like this:
resources:
  pipelines:
  - pipeline: build
    source: Build
    branch: $(Build.SourceBranch)
    trigger:
      branches:
        include:
        - release/*

Neither $(Build.SourceBranch) or $(Build.SourceBranchName) will work in this scenario. There would appear to be no workaround, so we're stuck.
Adding an additional Build.SourceBranchFullName variable seems like a no-brainer.

Sorry @alxy but that expression will work only for named branch git references (for example not for tag references)

I use this code
- powershell: |
    # see also https://github.com/microsoft/azure-pipelines-agent/issues/838
    $SourceBranchLongName = switch ($env:Build_Reason) {
      'PullRequest' { $env:Build_SourceBranch.Replace('refs/pull/','').Replace('/merge','') }
      default { $env:Build_SourceBranch.Replace('refs/heads/','').Replace('refs/tags/','') }
    }
    Write-Host "##vso[task.setvariable variable=SourceBranchLongName]${SourceBranchLongName}"

to have set a SourceBranchLongName variable

This worked for me (didn't try with pull request yet).
VERY IMPORTANT: Change the $env variables to upper cases, or else it won't work on Linux/Unix.
$env:Build_SourceBranch => $env:BUILD_SOURCEBRANCH
$env:Build_Reason => $env:BUILD_REASON

OMG The issue is raised from 2021. Why close this issue and leave us here? Still need solution for the full branch name in 2021

As a workaround for now I use Expressions so you can write something like:
name: $[ replace(variables['System.PullRequest.SourceBranch'], 'refs/heads/release/', '') ]

So you can get a build name 1.2.3 when building for a PR from realease/1.2.3 to master.
You can even do more complex things like this:
name: $[ variables['branchName'] ]

variables:
  ${{ if startsWith(variables['Build.SourceBranch'], 'refs/heads/') }}:
    branchName: $[ replace(variables['Build.SourceBranch'], 'refs/heads/', '') ]
  ${{ if startsWith(variables['Build.SourceBranch'], 'refs/pull/') }}:
    branchName: $[ replace(variables['System.PullRequest.SourceBranch'], 'refs/heads/', '') ]

trigger:
- master
pr:
- master

This way you can get the name of the source branch if it is a Trigger build or the name of the pull request source branch if that is a PR build.
This does not negate the fact that the shortcut-like Build.SourceBranchFullName feature is still needed.

Good workaround to this bug. 10/10. Would use again. 👍

Such a simple fix (Build.SourceBranchFullName) for something that was clearly overlooked initially, and 5 years later the complaints keep coming and the bug just keeps on getting closed without a fix.

It's not a but @michielvanderros-tomtom, it's a feature :-)

Such a simple fix (Build.SourceBranchFullName) for something that was clearly overlooked initially, and 5 years later the complaints keep coming and the bug just keeps on getting closed without a fix.

is this feature to get Branch full name ever going to be released?

${{ replace(variables['Build.SourceBranch'], 'refs/heads/', '') }}

I don't think they will ever have this feature :(

As a workaround for now I use Expressions so you can write something like:
name: $[ replace(variables['System.PullRequest.SourceBranch'], 'refs/heads/release/', '') ]

So you can get a build name 1.2.3 when building for a PR from realease/1.2.3 to master.
You can even do more complex things like this:
name: $[ variables['branchName'] ]

variables:
  ${{ if startsWith(variables['Build.SourceBranch'], 'refs/heads/') }}:
    branchName: $[ replace(variables['Build.SourceBranch'], 'refs/heads/', '') ]
  ${{ if startsWith(variables['Build.SourceBranch'], 'refs/pull/') }}:
    branchName: $[ replace(variables['System.PullRequest.SourceBranch'], 'refs/heads/', '') ]

trigger:
- master
pr:
- master

This way you can get the name of the source branch if it is a Trigger build or the name of the pull request source branch if that is a PR build.
This does not negate the fact that the shortcut-like Build.SourceBranchFullName feature is still needed.

Good workaround to this bug. 10/10. Would use again. 👍

Is it possibile to use wildcards? So to remove everything after the first "/"
replace(variables['System.PullRequest.SourceBranch'], '/*', '') ]

@TingluoHuang why is this closed? This is still an issue?

@davidorbelian  @edenroz how does this look in a yaml file today? There is no name key word in the list of azure pipeline definitions https://learn.microsoft.com/en-us/azure/devops/pipelines/yaml-schema/?view=azure-pipelines where would that name go? Also the variables example doesn't follow any examples either.

How can this still be an issue? Please fix this now

Who's still experiencing this in 2024?
Feel like I'm in a YouTube comments section, full of elder millennials reminiscing about songs from their childhood.
Lets get this one fixed, yeah? :)


Editor unresponsive after undoing text changes

Describe the bug
Relatively similar to #519.
The image editor is mostly unresponsive after trying to undo text changes.
To Reproduce
Steps to reproduce the behavior:

Go to https://ui.toast.com/tui-image-editor (Or https://nhn.github.io/tui.image-editor/latest/tutorial-example02-useApiDirect)
Switch to text mode
Click on the canvas to insert a new text object.
Edit the default text.
Click 'Undo'. Text changes are not undone.

Javascript console throws an Uncaught TypeError: Cannot read property 'forEach' of null exception.

Image editor is mostly unresponsive afterwards:

Most commands fail with an Uncaught (in promise) The executing command state is locked. exception.
Free drawing seems to work though, but changes cannot be undone.

Expected behavior

Text changes are undone.
Image editor works after undoing text changes.

Desktop (please complete the following information):

OS: Mac OS
Browser: Chrome
Version: 88.0.4324.96 (Official Build) (x86_64)

Additional context
The problem does not seem to happen if you exit 'text edit' mode by clicking on the canvas after step 3, and then editing the text content.

@fjwong
Thank you for your detailed report. But, this issue cannot be reproduced.
As you explained, I edited the text without exiting 'Text Edit' mode after step 3, but it works fine when undo. Could you provide a gif?

@lja1018 Thank you for the response.
You can find a video of the problem below:
https://user-images.githubusercontent.com/1836719/107466032-c9d73700-6ba6-11eb-9407-6f61bebc1467.mov

As you explained, I edited the text without exiting 'Text Edit' mode after step 3, but it works fine when undo.

Please note that, as soon as the text element is created, it is already in 'edit mode' so you can start typing right away.
If you type something and then click 'Undo', the issue happens.
If after creating the text object you click on it, or click the canvas then click on it for editing it, the issue doesn't happen.

@lja1018 @fjwong
The same thing happens for me.
But in my case, the error is a bit different:
Steps To Reproduce:

Switch to text mode
Click on the canvas to insert a new text object.
Edit the default text.
Click 'Undo'. Text changes are undone as expected.
But the 'Undo' stack is still not empty as it should have been.
And now when I click 'Undo' again, javascript throws the error Uncaught (in promise) TypeError: Cannot read property 'set' of undefined
Image editor is mostly unresponsive afterwards:
Most commands fail with an Uncaught (in promise) The promise of undo command is reject. Because The executing command state is locked. error

Additional context

After editing the default text, if you click anywhere else on the canvas and then click 'Undo', everything works fine.

BTW, This issue also exists in the new version 3.13.0
Hoping this can be resolved. Thanks!!
PS: A similar issue https://github.com/nhn/tui.image-editor/issues/519 seems to have been fixed in 3.13.0


Please add Emacs package

https://www.gnu.org/software/emacs/
Scoop recipe: https://github.com/lukesampson/scoop-extras/blob/master/bucket/emacs.json

Please see https://github.com/appget/appget/issues/4

When it's possible, https://github.com/m-parashar/emax64 (homepage) might be what we want to package.


BeginTx init code check

Description
Fixes the soundness bug: There was no check for initialisation code for a contract creation tx (tx.to == None).
Issue Link
Closes https://github.com/scroll-tech/zkevm-circuits/issues/605
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Closing as more debugging to be done (init code vs deployed code)

Closing this. The commit was cherry-picked and new PR opened here: https://github.com/scroll-tech/zkevm-circuits/pull/610


Missing details for inputs

There are no details on what addSpnToEnvironment or useGlobalConfig do here in the docs
As an example for addSpnToEnvironment, the following is help text in the task repo: https://github.com/microsoft/azure-pipelines-tasks/blob/8d65f9c930fc6c88fe6eba4f3aa9bcdd3be8a78f/Tasks/AzureCLIV1/Strings/resources.resjson/en-US/resources.resjson#L19
"Adds service principal id and key of the Azure endpoint you chose to the script's execution environment. You can use these variables: $servicePrincipalId and $servicePrincipalKey in your script.\n\nThis is honored only when the Azure endpoint has Service Principal authentication scheme."
Can we get the missing properties added to docs so users don't have to read task source?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8de3304e-98f9-bac0-3ccc-c65f68a89e87
Version Independent ID: 8fb2f6a9-545d-dff1-ff86-974694a85054
Content: Azure CLI task - Azure Pipelines
Content Source: docs/pipelines/tasks/deploy/azure-cli.md
Product: devops
Technology: devops-cicd
GitHub Login: @RoopeshNair
Microsoft Alias: ronai

@pulkitaggarwl  for az cli

A look into the source show there is also the tenantId:
https://github.com/microsoft/azure-pipelines-tasks/blob/161f40de8cf062cb9c738d39f54237292e2b9255/Tasks/AzureCLIV1/azureclitask.ts#L70-L75


CPF-3177 Create FObjectPropertyFilterView

JIRA Ticket:

https://nanopay.atlassian.net/browse/CPF-3177
We need a FObjectPropertyFilterView so that we can search by toSummary of FObjectProperty

I'm really hesitant to support this; operations will grow to depend on it, but it's not scalable as it only operates on the client side.
If we do choose to support this perhaps we can move it nanopay side so not to pollute the foam waters with this hack of a search feature.

I agree with @jlhughes. I don't think loading the entire DAO on the client and searching it there is feasible for large DAOs. It will put significant strain on the server to serialize all of that data and the network response would be huge (several GBs for some DAOs).
Another reason I don't think this approach is desirable is because predicates, limit, skip, and order all get applied on the server-side, and in the correct order. Not only that, but searching is efficient on the server due to the way data is stored in memory, and it can take advantage of indexes. Separating this part of predicate out to the client-side doesn't fit in.

Commenting here for later so I don't forget: If this kind of functionality was added to searching (I'm guessing requiring changes to TreeIndex?) it may be useful if other values from properties (i.e. not just toSummary) are searchable as well

Closing - will not implement.


BUG: Websocket latest basket is used to update data when event is something other than message

eg. close. So going to bitcoin data, then back to generated data means that - as the websocket closes -  the last basket of live data is added to the end of the generated data causing one higher than usual point at the beginning of the series, which also is drawn as the last point of any line series, causing it to double back on itself

Resolved in #163


Rebuild example notebook and add CI to "test" the notebook (test  being - does it run from start to finish?)

also

update gitignore
envt update
wasn't sure why there are 2 notebooks so wanted to wait to delete the second one!
would be fun to add an action that simply builds the notebook with papermill

NOTE: i moved the workflow  from  numpy -->  pandas and  also  added a function that will allow processing of additional files.  We could then take that and  write tests for that  function.
Right now it just takes a path to a url so you could test  that th e  input was a  string
We could add  it returning a moving  average and specify the window  used - then a number would be required as a second parameter.

@gassmoeller i don't have merge super powers :) if you can merge please!


Use range-based for loop in examples

Lots of example code use this,
   cout << "L = ( " ;
   for ( Iter = L.begin( ) ; Iter != L.end( ) ; Iter++ )
      cout << *Iter << " ";
   cout << ")" << endl;

It's a perfect case to use range-based for loop here.
   cout << "L = ( " ;
   for ( const auto& item : L )
      cout << item << " ";
   cout << ")" << endl;

Is it a good idea to change it?

If it's appropriate, there's no objection from us if you want to edit some examples to adopt this style. We don't usually revisit working examples for stylistic changes to syntactic sugar, for reasons of time and priority. Do you have some specific examples in mind?

@corob-msft It's everywhere in the std algorithm documentation. Example code for  std::rotate use several raw loops.
for ( v1Iter1 = v1.begin( ) ; v1Iter1 != v1.end( ) ;v1Iter1 ++ )
   cout << *v1Iter1  << " ";

for ( d1Iter1 = d1.begin( ) ; d1Iter1 != d1.end( ) ;d1Iter1 ++ )
   cout << *d1Iter1  << " ";

Something else can be improved too. Here it declares variable i outside of for loop, but it's not used anywhere after the for loop. Isn't it better to put i inside for loop?
int i;
for ( i = -3 ; i <= 5 ; i++ )
{
   v1.push_back( i );
}

Cpp core guidelines recommend using range-based for loop whenever appropriate. If you don't object, I will send a PR later.

Closing without prejudice as won't fix, though new code examples will certainly use modern style. PRs to address this complaint can still be made.


Setting fields are cleared on relaunch, though settings are still saved

Saving this for later - use app ready function, inside the function that skips setup if already set up. Use same object as in settings save, setupfields. Delegate objects and each commands to new function and call from settings save and settings fill.


Refactor/1174/private state vars timed crowdsale

This is part of #1174
Requires #1277

[x] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[x] ✅ I've added tests where applicable to test my new functionality.
[x] 📖 I've made sure that my contracts are well-documented.
[x] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

This one escaped my previews sweep.

There was a weird duplicate function definition. @elopio can you review this now?


Calling cancel discovery multiple times crashes

Test DiscoverTests.CancelTestDiscovery is avoiding to call Cancel multiple times, because the test crashes otherwise.

True, but not an issue that anyone else reported.


feat: artifact saver

Adds artifact_savers to registry and the base class BaselineArtifactSaver along with an implementation of TaskDiskSaver that saves the task to disk.
Fixes #510

This might be relevant for #523, but closing this until we are ready to work on it. (The mention means it is automatically reference in #523).
Feel free to re-open if you disagree 👍


Update scalatest to 3.2.9

Updates org.scalatest:scalatest from 3.2.6 to 3.2.9.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalatest", artifactId = "scalatest" } ]

labels: test-library-update, semver-patch

Codecov Report

Merging #247 (49458dc) into master (87310ce) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   43.72%   43.72%
=======================================
  Files          25       25
  Lines         263      263
  Branches        6        5    -1
=======================================
  Hits          115      115
  Misses        148      148

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87310ce...49458dc. Read the comment docs.

Closed in favour of #277


Allow authorization code flow without passing scopes

I saw from looking at closed issues that this is by design: https://github.com/IdentityServer/IdentityServer4/issues/4254#issuecomment-609029124
I just wanted to bring another use case to see if you're willing to reconsider your stance.
I'm interested in using IS4 to authenticate an internal private terraform module directory. The "terraform login protocol" doesn't send a scope. Even if we ask them to update their application to include scope, and even if they accept it and release it, we wont be able to provide terraform modules until everyone updates their terraform client.
Some details terraform login:

https://www.terraform.io/docs/internals/login-protocol.html
https://www.terraform.io/docs/commands/login.html#protocol-v1

If we could allow authorization code flow without a scope, we could build a service that works with terraform login <our_service_hostname>, and all of our customers could use our modules using our existing authentication platform.
I'm sure its already been mentioned, but what im asking for is valid for Oauth2:

https://tools.ietf.org/html/rfc6749#section-4.1.1
https://tools.ietf.org/html/rfc6749#section-3.3

If the client omits the scope parameter when requesting
authorization, the authorization server MUST either process the
request using a pre-defined default value or fail the request
indicating an invalid scope.  The authorization server SHOULD
document its scope requirements and default value (if defined).

We know that omitting scopes in OAuth is valid - but not in OIDC. That's why we decided to always require a scope parameter at the authorize endpoint.
We can take this into future consideration.

We don't plan on implementing this. It's not trivial. Sorry.

For our use case, terraform accepted our PR to supply scopes. Thanks for reconsidering it though