Fixed #26933 -- Fixed an update_or_create test sometimes failing.

On Oracle I see:
======================================================================
ERROR: test_updates_in_transaction (get_or_create.tests.UpdateOrCreateTransactionTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tim/code/django/django/test/testcases.py", line 1101, in skip_wrapper
    return test_func(*args, **kwargs)
  File "/home/tim/code/django/django/test/testcases.py", line 1101, in skip_wrapper
    return test_func(*args, **kwargs)
  File "/home/tim/code/django/tests/get_or_create/tests.py", line 476, in test_updates_in_transaction
    if not lock_wait():
  File "/home/tim/code/django/tests/get_or_create/tests.py", line 463, in lock_wait
    if has_grabbed_lock:
NameError: global name 'has_grabbed_lock' is not defined

I am not sure why only Oracle is crashing when the tests pass otherwise, since this seems like something related to the Python code.  It seems like the main source of this is the fact that I have nested methods, and until Python 3 (https://www.python.org/dev/peps/pep-3104/) with the nonlocal keyword there was no good way to handle assigning to variables like I am trying to do with has_grabbed_lock.  I will go back to the dictionary method since it avoids all of this scoping mess.

Okay, it's working now. One issue that precedes this PR but seems caused by this test is this Oracle traceback at the end of the test suite:
Failed (ORA-01940: cannot drop a user that is currently connected
)
Traceback (most recent call last):
  File "./tests/runtests.py", line 483, in <module>
    options.exclude_tags,
  File "./tests/runtests.py", line 277, in django_tests
    extra_tests=extra_tests,
  File "/home/tim/code/django/django/test/runner.py", line 551, in run_tests
    self.teardown_databases(old_config)
  File "/home/tim/code/django/django/test/runner.py", line 526, in teardown_databases
    connection.creation.destroy_test_db(old_name, self.verbosity, self.keepdb)
  File "/home/tim/code/django/django/db/backends/base/creation.py", line 264, in destroy_test_db
    self._destroy_test_db(test_database_name, verbosity)
  File "/home/tim/code/django/django/db/backends/oracle/creation.py", line 183, in _destroy_test_db
    self._destroy_test_user(cursor, parameters, verbosity)
  File "/home/tim/code/django/django/db/backends/oracle/creation.py", line 249, in _destroy_test_user
    self._execute_statements(cursor, statements, parameters, verbosity)
  File "/home/tim/code/django/django/db/backends/oracle/creation.py", line 257, in _execute_statements
    cursor.execute(stmt)
  File "/home/tim/code/django/django/db/backends/utils.py", line 64, in execute
    return self.cursor.execute(sql, params)
  File "/home/tim/code/django/django/db/utils.py", line 94, in __exit__
    six.reraise(dj_exc_type, dj_exc_value, traceback)
  File "/home/tim/code/django/django/db/backends/utils.py", line 62, in execute
    return self.cursor.execute(sql)
  File "/home/tim/code/django/django/db/backends/oracle/base.py", line 481, in execute
    return self.cursor.execute(query, self._param_generator(params))
django.db.utils.DatabaseError: ORA-01940: cannot drop a user that is currently connected

It seems to be related to the use of threading. Any ideas? We can ping Oracle experts if needed.

I have to admit I know very little about Oracle databases.  The only thing I've been able to find that is somewhat related is this issue.

If a test opens a thread; and in that thread, uses the ORM; and nobody closes the connection when the thread ends -- then we "leak" a connection.
On Oracle there is no concept of "databases" as in PG -- a user is connected 1-to-1 with a schema. So, to run the tests in an isolated database, the test-runner has to create a test user -- and of course, unless run with --keepdb, it also has to drop that user when the run ends. But if a connection was leaked, and is still open as far as Oracle is concerned you get the error above.
Hope this helps.

I've added a connection.close() after the update_or_create.  Unfortunately I don't have an Oracle db to test on to know whether this is effective, but at the very least it doesn't break anything on my Postgres db.

buildbot, test on Oracle.


Emotion charts

PR Description
This pull request aims to provide a way to check the emotional state of the
user in a certain moment. The user must enter the '/emotions' command and
a menu with 5 possible options will be presented. The user must choose the
option which better describes how is it feeling in that moment.
Also, the command '/emotionschart' are available to present a chart that
shows the frequencies associated for each possible emotional state. The user
must have had used that option at least once in order to have a chart generated.
New Feature Submissions
To run tests locally, use make if you're on Mac or Linux.

[x] Does your submission pass all the tests?
[x] Have you lint your code locally prior to submission?
[x] Have you written proper tests to your added code?

New Dialog Submissions

User messages have - -, bot messages have   -

[ ] Does all your user messages have lower letters?
[ ] Have you lint your dialogs locally prior to submission?
[ ] Have you written proper tests to your added dialogs on test_dialogs?
[ ] Does your dialog have an existing category? If not, did you create it?

Changes to Core Features

[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests or modified old ones for your core changes, as applicable?
[ ] Have you successfully run tests with your changes locally?

@alexandrebarbaruiva feito!


Feature Requests: remove force CAP and add center align and icon color

Hi,
So I really dig this custom card! I used state-switch with custom button cards to create own tabs, but this card makes it a lot easier and manageable, great work! One thing I notice I hope to see changed is the labels. Everything is forced in CAPS while I want it to be case sensitive. Could you change it so the label is identical to the input? This way people can decide themselves if they want all caps, lower caps or start with a cap.
Also I notice the label and icon are not aligned in the center. It's now aligned at the top, which makes it look kinda messy.

Also, the style option only affects the text-color, but not the icon. Could you also provide a variable to alter the icon color?
Currently the text changes color, but the icon is hardcoded (the unselected tab). When I use a dark mode theme, the icon becomes invisible due to the hardcoded color.

Edit: the icon and text alignment seems to be browser based. On Desktop it shows like the screenshot, on mobile however it's aligned properly. Hard to say what the issue might be.


fetchnixpkgs: init

Motivation for this change
example
fetchnixpkgs {
  rev = "06271b6eba7ce754a305df1d90925de976b915d2";
  sha256 = "0w3mwggyc6ypjn07rsfcrmwlfmql96rvfz6436hm2vmnplpnylq3";
  patches = [ ./foo.patch ];
}

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Fits CONTRIBUTING.md.

I think the chosen name is too generic. I use myself something similar but with fetchTarball and a hash.  This function is for IFD, right? Maybe the name should reflect that.

I'd love to get this merged. @LnL7 what do you think about @FRidh's comment?

I'm not sure what would be a better name for it.

How about fetchNixpkgsForIFD. With Nix 1.12 this function can be written
with fetchTarball, however then it will require a different hash, which is
why I think it is important not to take the fetchNixpkgs name yet.
On Jul 16, 2017 23:00, "Daiderd Jordan"<EMAIL_ADDRESS>wrote:

I'm not sure what would be a better name for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NixOS/nixpkgs/pull/26802#issuecomment-315636906, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACB871668KbsI3dLnp-BqWue2sRtk2XLks5sOnoLgaJpZM4OEIRq
.

:-1: on ad hoc fetch functions like this. See my recent comment on fetchFromGitHub. It's also questionable whether we want to promote the use of IFD. And given that fetchTarball supports a similar use case, this function adds technical debt that we'll end up having to support forever.

I'm not entirely happy with this eithe, the main idea behind this was making it easier to apply patches on top of nixpkgs. What do you think of the idea of adding some sort of support for patches to nix-channel or nixpkgs itself?
I think it would we really nice if it was possible to do something like this, to apply some changes on top of a channel without having to maintain and rebase my own git branch.
curl -o ~/.nixpkgs/patches/pr-26802.patch https://github.com/NixOS/nixpkgs/commit/1fa8d8d87a55914bdae8a3e56166fcfb510afd94.patch

Closing because this won't go in.
Regarding the discussion on patching Nixpkgs. If you make it a Nixpkgs feature you end up with recursion like you've shown here so if we don't want that then I suppose the only option is to make it a Nix feature.

See #22058 for related work


Error Sending message on Real Device

While sending an sms from a real device having android 11 with having permission: SEND_SMS,
call to function
await telephony.sendSms(
   to: mobileNum,
   message: message,
   statusListener: onSendStatus,
 );

throwing an exception
E/flutter (22839): [ERROR:flutter/lib/ui/ui_dart_state.cc(198)] Unhandled Exception: PlatformException(failed_to_fetch_sms, Flutter Telephony: Error getting SmsManager, null, null)
E/flutter (22839): #0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:607:7)
E/flutter (22839): #1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:167:18)
E/flutter (22839): <asynchronous suspension>
E/flutter (22839): #2      Telephony.sendSms (package:telephony/telephony.dart:321:5)
E/flutter (22839): <asynchronous suspension>

Also having this issue

also Having this issue, any news about it?

me too... i cant send sms...
Unhandled Exception: PlatformException(failed_to_fetch_sms, Flutter Telephony: Error getting SmsManager, null, null)

did you find any solution ?

me too... i cant send sms... Unhandled Exception: PlatformException(failed_to_fetch_sms, Flutter Telephony: Error getting SmsManager, null, null)

did you find any solution ?

https://github.com/shounakmulay/Telephony/pull/153
The fix in this PR solved it for me

Facing this issue too. Can anyone have the solution for this?

facing same issue, i'm wondered this issue is open for 1 year

Facing this issue too...

#153
hope this help

for everyone who facing this issue and still have no idea how to fix this... you can temporarily use package from my repository by changing telephony package inside pubspec.yaml
  telephony:
    git:
      url: https://github.com/suhardik/s_telephony.git
      ref: develop

e: /Users/shanta/FlutterSetUp/flutter/.pub-cache/git/s_telephony-78a83137120ce23b252454825272624ff37a8e1b/android/src/main/kotlin/com/shounakmulay/telephony/sms/SmsController.kt: (27, 7): Redeclaration: SmsController
e: /Users/shanta/FlutterSetUp/flutter/.pub-cache/hosted/pub.dartlang.org/telephony-0.2.0/android/src/main/kotlin/com/shounakmulay/telephony/sms/SmsController.kt: (27, 7): Redeclaration: SmsController
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':telephony:compileDebugKotlin'.

Compilation error. See log for more details

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 14s
Exception: Gradle task assembleDebug failed with exit code 1

e: /Users/shanta/FlutterSetUp/flutter/.pub-cache/git/s_telephony-78a83137120ce23b252454825272624ff37a8e1b/android/src/main/kotlin/com/shounakmulay/telephony/sms/SmsController.kt: (27, 7): Redeclaration: SmsController e: /Users/shanta/FlutterSetUp/flutter/.pub-cache/hosted/pub.dartlang.org/telephony-0.2.0/android/src/main/kotlin/com/shounakmulay/telephony/sms/SmsController.kt: (27, 7): Redeclaration: SmsController
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':telephony:compileDebugKotlin'.

Compilation error. See log for more details

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 14s Exception: Gradle task assembleDebug failed with exit code 1

i think its different problem. you can try to run "flutter pub clean" and then run "flutter pub get", and finally, run "flutter run"

i have changed pubspec.yaml as you said. but yet i am facing the same issue.
i have ran flutter clean, flutter pub get
but yet the problem has not been resolved

also problem myself, it doesn't work on old devices

also problem myself, it doesn't work on old devices

yes i guess. minSdkVersion of this library is 23. so it means that this library only works on device with OS Android 6.0 and later

also problem myself, it doesn't work on old devices

yes i guess. minSdkVersion of this library is 23. so it means that this library only works on device with OS Android 6.0 and later

My sdk is 26 :(

Hello! Is there someone who solved this problem?Thanks

I changed plugin, I'm using this:
https://pub.dev/packages/background_sms

This problem still persist!

almost 1 year but still not getting merged. for anyone who still get this error, you can try this solution:
https://github.com/shounakmulay/Telephony/issues/149#issuecomment-1212695720
hope this help :)

almost 1 year but still not getting merged. for anyone who still get this error, you can try this solution: #149 (comment)
hope this help :)

This help boss, thank you


Auth0 invalid_request Error

Is this a common issue?

Running on windows 11 home with brave browser as default, shields down for auth0.

its still trying to access the old url when running upg login:

@yusuf-wadi The package has moved to @spellcraft/upg. We will soon ship binaries to homebrew and stuff and abandon NPM.


Obsolete LoggingConfiguration FileNamesToWatch and make new configuration assigned event

NLog v6 will not support FileNamesToWatch, so it should be obsoleted.
But FileNamesToWatch-getter is currently used by NLog.Extensions.Logging as signal that Configuration has been assigned to a LogFactory.
Could be nice with a proper internal / protected method that signals the Configuration as been assigned. Maybe also called when unassigned, then one could remove the "hack" about hooking into LogFactory.ConfigurationChanged-event-handler

Maybe use NLog v5.4 to mark FileNamesToWatch as obsolete, after completing #5577

Maybe consider to keep FileNamesToWatch as it would make it easier to implement an external file-watcher-nuget-package that automatically performs reload of active configuration for the LogFactory, when file-change was detected.

Obsolete
public static ISetupConfigurationTargetBuilder WriteToFile(this ISetupConfigurationTargetBuilder configBuilder, Layout fileName, Layout layout = null, System.Text.Encoding encoding = null, LineEndingMode lineEnding = null, bool keepFileOpen = true, bool concurrentWrites = false, long archiveAboveSize = 0, int maxArchiveFiles = 0, int maxArchiveDays = 0)


Fix IBM a100 ssh key

This VM has both stage and prod ssh key but the stage one is not available as a secret in the prod cluster.
This is causing the multi-platform-controller update task to fail for this node.

Can we get #4329 merged before this one so that I don't have to re-base it again?

Can we get #4329 merged before this one so that I don't have to re-base it again?

sure, I thought it would but I just saw that @arewm set hold label on that other one, we need to remove that label

it is there probably because it needed to wait for the MPC update that already landed, but we probably need @arewm to confirm

@ifireball https://github.com/redhat-appstudio/infra-deployments/pull/4349 is merged, can you /lgtm this one now

/lgtm


Do NOT merge: Add docs on updated SPA templates preview

In the next week or so, we'll be publishing a preview of the next version of the SPA templates (for Angular, React, and React+Redux). This documentation covers both how to get the preview release, and how to use it.
We should not actually merge this PR until the preview is released, though I can (hopefully) do that at the right time if this PR is approved. There is still a package name to be updated in these docs when the final preview package name is confirmed, which also I will do before merging.
Once the final SPA templates updates are released as RTM (hopefully in January) I'll submit a further update that removes all the statements about this being "preview", so this can become the final permanent SPA templates docs.
As a separate matter, we should remove a large portion of the existing "client-side development" content, because it's outdated - not just because of the changes this PR documents, but just because the industry as a whole has moved on.
Internal Review Pages:

Index Page
Angular
React
React w/ Redux

@Rick-Anderson @danroth27 Please see Steve's comment above regarding removal of client-side dev docs. Thoughts?

@SteveSandersonMS  can you give us a list of topics to remove? Once you give us the list I'll remove them.

@scottaddie  can you post a list of  client-side dev docs to remove then I'll get Steve to approve the list. We should be focusing on ASP.NET Core which is primarily server technology.

Thanks @scottaddie for the copyediting! I've also pushed a few further commits which updates this to the final state for the 2.0.0-preview1-final release.
Is this OK to be merged and published now? Since the 2.0.0-preview1-final template has now been published [1] it would be good to have the docs easily available.

Also, should these new docs be located under a new "Single-Page Apps" node in the TOC? Or should they live under the existing "Client-Side Development" node?

Not sure whether you were asking me or someone else, but I don't mind either way. Totally happy with you choosing how the content should be grouped.

can you give us a list of topics to remove? Once you give us the list I'll remove them.

Yes, if you could file a bug and assign it to me, I'll figure out a set of recommendations.
[1] Technically still waiting for NuGet.org to index it, but that should complete automatically in the next 30 minutes or so.

@SteveSandersonMS I've assigned https://github.com/aspnet/Docs/issues/4944 to you. Once we determine the appropriate TOC location, I'll update the associated files. Then this PR is ready to merge and publish.
@Rick-Anderson Do you have a preference for TOC location of these docs?

@scottaddie  No pref on TOC
@scottaddie  can you change each of the notes from
This documentation is not about the existing Angular project template. This documentation is about the next version of the Angular template which ships in early 2018.
To something like
This documentation is not about the released Angular project template. This documentation is about the preview version of the Angular template. We hope to ship the released version in early 2018.

Thanks for approving. Squashed and merged.

can you change each of the notes...

Done

@Rick-Anderson @scottaddie Can we get this to go live today? I'm guessing that happens when master is merged to live, but will leave that for one of you to do (or tell me I can do) in case you have any extra processes around this. Thanks!

@SteveSandersonMS Thank you for making the note changes. This will go live once https://github.com/aspnet/Docs/pull/4949 is merged, which should happen today. @Rick-Anderson Are you able to confirm that this PR will merge today?

@scottaddie  done


3.0.0

one day... (not pressuring take your time)

i saw

note to future self: use "current" rev of all commits up to here when resolving conflicts

not done yet, but ill finish on main branch


use mamba-org/provision-with-micromamba@main action and matrix strategy

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)
[ ] HISTORY.rst has been updated (with summary of main changes)

[ ] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

uses mamba-org/provision-with-micromamba@main action (with caching)
doctests and smoke tests are now in the same strategy matrix

Does this PR introduce a breaking change?
No.
Other information:
Caching is performed once daily for each build. This prevents unnecessary downloading of archives between runs of the same build, so long as dependencies are unchanged. This should speed up build time.

@RondeauG The justification for this change: Note the testing build times.


Provide examples with backgrounds

The examples shown in the README are easily readable on typst.app/universe, but not on GitHub with dark mode. Consider setting the fill of those examples to white explicitly.

Oh yeah that's not good. I always use light mode so I didn't notice.


Disk I/O overhead on mac silicon machine as compared to ubuntu/linux distro

Current Behavior
👋  I was benchmarking some of our task-groups using gradle-profiler on mac-machine vs the linux-ubuntu distro with local and remote cache enabled.
Notice, disk i/o overhead when unpacking artifacts on mac-runner as compared to the ubuntu-distro.
Linux distro (16 core)
Pack | 15 | 19.896s | 273.1 MiB
Unpack | 13334 | 28m 19.254s | 6.9 GiB
JDK - Java_Temurin-Hotspot_jdk/21.0.3-9.0.LTS
Mac studio 20 core M1 Ultra
Pack | 15 | 57.588s | 273.1 MiB
Unpack | 13334 | 2h 42m 42.171s | 6.9 GiB
JDK - Java_Temurin-Hotspot_jdk/21.0.3-9.0.LTS/arm64
Not sure, if it's relevant to gradle or if something can be done at gradle end to optimise the disk i/o for cache artifacts or if the mac-OS (arm machines) in general has disk i/o overhead as compared to linux (amd).
Expected Behavior
Unpacking of cache artifacts should be same or outperform on mac ssd disk.
Context (optional)
No response
Self-contained Reproducer Project

Take any project like https://github.com/android/nowinandroid
Enable local cache
Run benchmark or one single build taking advantage of local cache on mac machine and linux machine.

Gradle version
8.10.2
Build scan URL (optional)
No response
Your Environment (optional)
No response

Could you share a few more datapoints:

Explain what the shared numbers are? Some have units but could still be misunderstood.
How did you obtain those numbers? Your reproduction steps are very limited.
What are the disks on both machines? Technology, capacity, brand and free space

Without that information, reproducing those results will be a challenge. And having that information might help us match the performance testing we do internally.


Connection is being made but no video

Hello!
I'm using the v380 (C++) the connection is made but no video is being played by ffplay.
The video seems to be sending because the data is very similar to the data being sended when using the v380 pro android app.
I tried the nodejs implementation but it says that the password is invalid.
Also, if anyone find the problem that is happening and got the video playing, the video is kinda dark because the camera is in a place totally dark.
Wireshark dump: https://anonfiles.com/11n7K2V0xc/v380_video_dump_pcapng

Hi! Did you fix it?


Rename SPLUNK_CONTEXT_SERVER_TIMING_ENABLED

Description
GDI specification states: SPLUNK_TRACE_RESPONSE_HEADER_ENABLED
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X] This change requires a documentation update

How Has This Been Tested?

[X] Tested manually
[ ] Added automated tests

Checklist:

[X] Changelogs have been updated
[ ] Unit tests have been added/updated
[X] Documentation has been updated

Codecov Report

Merging #149 (fd0663c) into main (cfcd866) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   85.82%   85.82%
=======================================
  Files          12       12
  Lines         268      268
  Branches       61       61
=======================================
  Hits          230      230
  Misses         38       38

Impacted Files
Coverage Δ

src/options.ts
98.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcd866...fd0663c. Read the comment docs.


Wireless WS2801 for ambiant lightning

Hello, is it possible to make 2 (or more) WS2801 leds wireless. I want to recreate a 'Phillips Hue-like' effect. Maybe with some XBee modules?
My setup is right now 50 WS2801 leds behind theTV.
I don't know if theSPI signal can be passed thru the air...

we have now udp support, you can do it with a simple esp8266 now
can you close this issue? thanks


Add image summary

Support image summary.

Support basic feature of visualizing image for now. I would add more image APIs for understanding NN later.


Fix bug migrating tables with only a single record

What? Why?
I ran into a bug when running Lhm.change_table against a table with only a single record.
In this case, both the next_to_start and thelimit variables (in Chunker#execute) are the same thus never triggering the copy.
What should be tested?
You can properly migrate tables with only 1 record using Lhm#change_table.
Note: I forked off off tag v2.1.0 (which is what we are using right now). A bit busy to do it again for master but I can do so in a week or so.

@saimonmoore any chance you can do look at https://github.com/soundcloud/lhm/pull/78#issuecomment-66336088 so this can be merged? I ran into this edge-case last week

This should be already fixed on 2.2+ , see https://github.com/soundcloud/lhm/commit/ee071e97d29ced2aa7e970f19e4028a231d7ccd2

Thanks, btw for the PR


Spring session in a multidatasource environment

How to configure additional Datasource for Spring Session #96
https://github.com/spring-projects/spring-session-data-mongodb/issues/96
By default spring-session-data-mongodb assumes that the datasource in the project is exclusively used by spring session. If you have more than 1 dataSource, the very first bean gets elected to the primary Datasource for session. This is less than ideal. To account for this I've added an annotation to optionally elect the datasource of choice.
Expected behavior
The MongoTemplate annotated with SpringSessionMongoOperations will be chosen as the Session Datasource
Actual behavior
Currently the first Bean gets resolved as the MongoOperations of choice.
Steps to reproduce
https://github.com/visweshwar/spring-session-multiple-mongo can reproduce the issue.

This project has migrated from master to main as the "main" branch, thus causing your PR to close.
If you want to revisit this, please fetch and rebase your branch against main and you should be able to create pull request with all your commits.


Commenting function

Requirements

Able to disable / enable the comments from config
Disqus

Maybe this could be a good way to solve commenting? https://www.gatsbyjs.com/plugins/gatsby-plugin-disqus/

I'm not sure if I should add this plugin as a dependency since some may want to use different vendors.
(Same issue to mailchimp... This could be a nightmare...)

Hmm. True.. Optional? Option to turn it off in config?


Add ndarray variants AND inplace support in fallback_mode

EDIT:
I've fixed the bug associated with ndarray.__init__.
ORIGINAL:
This PR is related to #2066
This PR will support use of numpy.MaskedArray, numpy.chararray, numpy.recarray, numpy.matrix. Also, there will be some performance improvement when an ndarray is fallbacked consecutively.
And structure of fallback.ndarray is changed so that, it doesn't need to explicitly check for in-place updates. In-place changes to an ndarray will be confirmed before dispatching it for function execution (both cupy and numpy) including functions such as __repr__.
TO-DO:

Fix ndarray creation using cupy.ndarray.__init__, currently all attributes are returned as NoneType.

Recent changes caused this issue. Currently working to figure it out.

@Piyush-555 Any updates?

Is it already ready to review? If so, please remove [wip] label from the title of this PR.

Jenkins, test this please.

Jenkins CI test (for commit b648c2d3befb040be4a8aa1e52da2a75fb9a4156, target branch master) failed with status FAILURE.

@Piyush-555 Could you check Jenkins failures?

@asi1024 I was not able to reproduce the error for test_out_is_returned_when_not_fallbacked. But by the looks of it, it seems that the error is probably due to default dtype being float32 in testing.shaped_random.
Could you re-run the CI?

@Piyush-555 The random seed of shaped_random is fixed to 0 in default.

Jenkins, test this please.

Jenkins CI test (for commit 093d16305c30cde57b8f626c14de3b9e9d274e5b, target branch master) succeeded!

LGTM.


Complete re-write of minDistancePoints

Fixing several bugs reported in Octave in relation to faulty input argument detection and results when requesting three output arguments I decided to re-write the function and simplify it.
I think now the logic is simpler and there are two points where optimizations can be put in place:

Do not compute the symmetric square matrix of distances when a single array is given (save memory for sure, maybe save time...vectorizing is more complicated in this case)

Use sum, .^2 and sqrt for n == 2, instead of .^n and pow

Please let me know if something is not working in Matlab.

HI,
great, the code of this function was in need for refereshing for long time already...
I have pulled the modifs, an got some errors (missing "end" keyword), as well as some mlint warnings. I check quickly and see if it can be merged.

Oh, yes, I see the problem in line 144. I am using the endif keyword form Octave. I have fixed it.

Hi,
OK, I think I could merge it. (do not worry for displayed conflicts, it only concerns your second commit -> "endif").
I have added a new "vech" function, as it is not part of Matlab. I also updated the code to replace the "lookup" function (also not part of Matlab).
It seems porting from octave to matlab is not totally straightforward... But at least it can be done!
I have run the unit tests, and could pass all of them. I have not checked for perfs, but I suspect it should be better.
The MLint are some warnings shown by Matlab editor to highlight potential problems: code style, deprecated functions, non efficient code... Here it was complaining for missing comma when returning multiple arguments, but this was just a coding style question (at least for current versions).
regards!

Hi David,
Thanks, I will have this in mind. How did you get the functions vech and lookup?
They are probably part of matlab's toolboxes (linear-algrebra? and optim interp? respectively).
You can, of course, use the GNU Octave functions, you just need to adapt them, maybe. Just be careful with the license there as GNU Octave is GPLv3 trying to warrant freedom of use and port, and this conflicts with the limiting Terms of Use in the file exchange website (where it says that you can only use it with mathworks products).
I am curious on how did you get these functions?
GNU Octave is a superset of matlab language. The rule for the community is that all matlab code should run on Octave. We do not care about the other direction.

For vech, just found this link:
http://lasp.colorado.edu/cism/CISM_DX/code/CISM_DX-0.50/required_packages/octave/share/octave/2.1.50/m/linear-algebra/vech.m
I rewrote it for Matlab syntax.
For the lookup function I just did some reverse engineering from the doc!
You're right for the licence questions. I will check if possible to better integrate the vech function into minDistancePoints, this should solve the question.

Yeah, you also removed the original copyright header (I see the version you got is GPLv2). You should not do that.
Check 1. here https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html#SEC3 (btw,  2.a is what conflicts with file exchange, that's why we do not use that site).
Nota the your FreeBSD license also ask that the header should remain untouched (you can check that is the case in geometry).
You can get the latest and greatest version of the two functions here.
http://hg.savannah.gnu.org/hgweb/octave/file/35e3d199527c/scripts/linear-algebra/vech.m
http://hg.savannah.gnu.org/hgweb/octave/file/35e3d199527c/libinterp/corefcn/lookup.cc
lookup is in C++ code, but you could improve your implementation (if needed) by learning from that code. This is allowed by the license, you should just said that you based your function on that code.

All right, I'll update it.

Allright! It was finally quite simple to find a solution without using the vech function. So the problem disappear!


[Feature Suggestion] Wrench

Simple addition of a wrench with simple features:
Right click to rotate machine.
Shift+Right-click to pick up machine/cable.

the Configurator does everything you are asking.
On Sun, Aug 23, 2015 at 9:47 PM, Alexander H<EMAIL_ADDRESS>wrote:

Simple addition of a wrench with simple features:
Right click to rotate machine.
Shift+Right-click to pick up machine/cable.
—
Reply to this email directly or view it on GitHub
https://github.com/aidancbrady/Mekanism/issues/2926.

--
Brad

It does not instant pickup or rotate machines like wrenches from other mods

You have to set the mode, there are specific modes for 'wrench' and rotate

How do you change modes, Shift right-click and "Mek item mode switch" do not work

I believe it's actually sneak+ meka item mode switch

It is indeed sneak + mek item mode switch.

not to seem like a jerk here, but isn't shift the sneak key anyways?

It is the default sneak key, but he was trying sneak + rclick and the mek item mode switch alone, not the sneak + mek item mode switch.

No I tried "sneak+right click" and "mek item mode switch". "Sneak +mek item
mode switch" seamed redundant. It's working now.
On Tue, Aug 25, 2015, 04:55 ruifung<EMAIL_ADDRESS>wrote:

It is the default sneak key, but he was trying sneak + rclick and the mek
item mode switch alone, not the sneak + mek item mode switch.
—
Reply to this email directly or view it on GitHub
https://github.com/aidancbrady/Mekanism/issues/2926#issuecomment-134530690
.


[WIP] Add theme field to Account and modify the related APIs

Closes: #370
Closes: #371

Modified related APIs to accommodate the addition of theme field in Account
Added new APIs to retrieve and update the user's screen color theme selection

@div-seungha Thank you for your efforts on this PR. However, I believe we should align on when a PR is considered ready for review. From my perspective, this PR may not yet be ready for review, because the corresponding PR in review-database has not been merged into its main branch. The commit hash used in this PR does not look like it is from the main branch.
To ensure clarity, I suggest we discuss and agree on the appropriate timing for opening PRs. If needed, I’d be happy to join a clarifying session—please let me know.
Additionally, I recommend marking this PR as a draft or WIP for now. Alternatively, it might have been more preferable to delay pushing this PR until the review-database PR was merged. While this option is no longer applicable for the current PR as of now, I hope we can prioritize such an approach as our first choice in similar situations in the future.

@div-seungha Thank you for your efforts on this PR. However, I believe we should align on when a PR is considered ready for review. From my perspective, this PR may not yet be ready for review, because the corresponding PR in review-database has not been merged into its main branch. The commit hash used in this PR does not look like it is from the main branch.
To ensure clarity, I suggest we discuss and agree on the appropriate timing for opening PRs. If needed, I’d be happy to join a clarifying session—please let me know.
Additionally, I recommend marking this PR as a draft or WIP for now. Alternatively, it might have been more preferable to delay pushing this PR until the review-database PR was merged. While this option is no longer applicable for the current PR as of now, I hope we can prioritize such an approach as our first choice in similar situations in the future.

Your intentions have been fully conveyed and completely understood. The PR has been moved to the WIP state, and I will ensure it is ready for review as soon as the prerequisite PR of review-database is merged. @sophie-cluml


fix disable cast function to array type on origin exec engine.

Proposed changes
Issue Number: close #11592
Problem summary
Currently, we already support cast to array on vectorized engine, and most of the array functions only supported on vectorized engine.
but on origin exec engine, we only support cast varchar to array.
Any other type cast to array on origin exec engine will cause be core dump.
This commit disable cast to array type on origin exec engine, except cast varchar to array type.
Checklist(Required)

Does it affect the original behavior:

[x] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[x] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[x] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

LGTM


Update project timeline to address Verdant RITE project issues.

Update project timeline to address Verdant RITE project issues.
Issue emailed to team by Zach Barr and Sharon Kramer on 01/07/2021.

Neil Swanson responded for clarification:

Sharon and Zach responded:

Pasting text from images in thread above...

From: Sharon Kramer<EMAIL_ADDRESS>Date: Fri, Jan 8, 2021 at 9:55 AM
Subject: RE: MHK Toolkit Project Timeline RITE Project Update
My interpretation – they do not have a final license approved yet but FERC let them move ahead with deployment, which they did in late 2020, on a temporary (month to month?) basis (I note, I could not find anything from FERC stating month to month but just rather approval with conditions).  Rather than month to month, can we asterisk and then footnote as temporary approval or something like that?Interestingly, I could not find anything from FERC that has a start date 1/1/21, just this attachment.  So I am confused too.Not sure how helpful this is, I don’t like to question Verdant but trying to make their table jive with the FERC elibrary is not straightforward.

From: Zach Barr<EMAIL_ADDRESS>Sent: Friday, January 8, 2021 6:57 AM
Subject: RE: MHK Toolkit Project Timeline RITE Project Update
+Sharon for her to weigh-in/confirm. Yes, they will only apply to the RITE project (it may be easiest to use a different symbol rather than another triangle to show this on the timeline). I don’t know if Month to Month was a typo but I think if we want to describe it as Month to Month it should be put on the pin map when you click on their project you can see it described as such. Sharon, does that capture more or less what you were thinking?

From: Neil Swanson<EMAIL_ADDRESS>Sent: Thursday, January 7, 2021 4:15 PM
Subject: RE: MHK Toolkit Project Timeline RITE Project Update
Hi Zach, Before I make changes to the MHK project timeline, I want to make sure I understand this correctly.  I’ve included a screenshot of the current timeline figure for quick reference.  Sharon is requesting that we add four new symbol colors/legend items, which at this point will only apply to the RITE project – “Pilot License Issued”, “Draft Re-License App”, “Final Re-license App”, and “Re-license Issued”, correct?  Also, do you know what is meant by “Re-license issuedMonth to Month 1/1/21”?  I’m guessing the symbol should be set to 1/1/21 and the “Month to Month” was a typo?

From: Zach Barr<EMAIL_ADDRESS>Sent: Thursday, January 7, 2021 3:52 PM
Subject: MHK Toolkit Project Timeline RITE Project Update
Hi all, Please see below in Sharon’s latest email some changes we’d like to make to the Verdant RITE project timeline in the MHK Toolkit. Let me know if you have any questions.

From: Sharon Kramer<EMAIL_ADDRESS>Sent: Monday, January 4, 2021 10:36 AM
Subject: RE: water quality question
Zach I think maybe adding or changing these points

Add: Pilot license issued 1/23/2012
Change Draft and Final license application to Draft Re-License Application and Final Re-license Application
Add: Re-license issued Month to Month 1/1/21

From: Zach Barr<EMAIL_ADDRESS>Sent: Monday, January 4, 2021 9:23 AM
Subject: RE: water quality question
Right – and it may be confusing if other developers rely on that timeline if it is not the typical order things happen. Are there any updates we should make based on what he provided? I want to be as responsive as possible without having to redo or update everything if it isn’t warranted.

From: Sharon Kramer<EMAIL_ADDRESS>Sent: Monday, January 4, 2021 8:41 AM
Subject: RE: water quality question
No questions but its just too detailed.  For example, its odd to me that they submitted their DLA without the EA, which came a year later.  I think that level of detail is too much.

From: Zach Barr<EMAIL_ADDRESS>Sent: Monday, January 4, 2021 7:00 AM
Subject: RE: water quality question
Hi Sharon, I hope the surgery went well and you’re recovering in good spirits! Please find attached updates recommended by Verdant on the RITE Timeline. Is there any questions you have related to this? Thanks!Zach

From: Sharon Kramer<EMAIL_ADDRESS>Sent: Tuesday, December 15, 2020 12:58 PM
Subject: RE: water quality question
Thanks! Jonathan Colby was messaging me with questions about our source for the project timeline. I think there are dates for the RITE project that he thinks are incorrect. Do you know where we pulled those from? I thought we got them from Verdant…

From: Sharon Kramer<EMAIL_ADDRESS>Sent: Tuesday, December 15, 2020 12:44 PM
Subject: water quality question
Zach – BOEMs lease and FERCs license, and Corps permits, cannot violate regulations affecting water quality, so yes, clean water act is the statute for water quality, and all of the other permitting processes have to address it.  Sharon H. Kramer, Ph.D.

Pasting text from images in thread above...

From: Sharon Kramer<EMAIL_ADDRESS>Date: Fri, Jan 8, 2021 at 9:55 AM
Subject: RE: MHK Toolkit Project Timeline RITE Project Update
My interpretation – they do not have a final license approved yet but FERC let them move ahead with deployment, which they did in late 2020, on a temporary (month to month?) basis (I note, I could not find anything from FERC stating month to month but just rather approval with conditions).  Rather than month to month, can we asterisk and then footnote as temporary approval or something like that?Interestingly, I could not find anything from FERC that has a start date 1/1/21, just this attachment.  So I am confused too.Not sure how helpful this is, I don’t like to question Verdant but trying to make their table jive with the FERC elibrary is not straightforward.

From: Zach Barr<EMAIL_ADDRESS>Sent: Friday, January 8, 2021 6:57 AM
Subject: RE: MHK Toolkit Project Timeline RITE Project Update
+Sharon for her to weigh-in/confirm. Yes, they will only apply to the RITE project (it may be easiest to use a different symbol rather than another triangle to show this on the timeline). I don’t know if Month to Month was a typo but I think if we want to describe it as Month to Month it should be put on the pin map when you click on their project you can see it described as such. Sharon, does that capture more or less what you were thinking?

From: Neil Swanson<EMAIL_ADDRESS>Sent: Thursday, January 7, 2021 4:15 PM
Subject: RE: MHK Toolkit Project Timeline RITE Project Update
Hi Zach, Before I make changes to the MHK project timeline, I want to make sure I understand this correctly.  I’ve included a screenshot of the current timeline figure for quick reference.  Sharon is requesting that we add four new symbol colors/legend items, which at this point will only apply to the RITE project – “Pilot License Issued”, “Draft Re-License App”, “Final Re-license App”, and “Re-license Issued”, correct?  Also, do you know what is meant by “Re-license issuedMonth to Month 1/1/21”?  I’m guessing the symbol should be set to 1/1/21 and the “Month to Month” was a typo?

From: Zach Barr<EMAIL_ADDRESS>Sent: Thursday, January 7, 2021 3:52 PM
Subject: MHK Toolkit Project Timeline RITE Project Update
Hi all, Please see below in Sharon’s latest email some changes we’d like to make to the Verdant RITE project timeline in the MHK Toolkit. Let me know if you have any questions.

From: Sharon Kramer<EMAIL_ADDRESS>Sent: Monday, January 4, 2021 10:36 AM
Subject: RE: water quality question
Zach I think maybe adding or changing these points

Add: Pilot license issued 1/23/2012
Change Draft and Final license application to Draft Re-License Application and Final Re-license Application
Add: Re-license issued Month to Month 1/1/21

From: Zach Barr<EMAIL_ADDRESS>Sent: Monday, January 4, 2021 9:23 AM
Subject: RE: water quality question
Right – and it may be confusing if other developers rely on that timeline if it is not the typical order things happen. Are there any updates we should make based on what he provided? I want to be as responsive as possible without having to redo or update everything if it isn’t warranted.

From: Sharon Kramer<EMAIL_ADDRESS>Sent: Monday, January 4, 2021 8:41 AM
Subject: RE: water quality question
No questions but its just too detailed.  For example, its odd to me that they submitted their DLA without the EA, which came a year later.  I think that level of detail is too much.

From: Zach Barr<EMAIL_ADDRESS>Sent: Monday, January 4, 2021 7:00 AM
Subject: RE: water quality question
Hi Sharon, I hope the surgery went well and you’re recovering in good spirits! Please find attached updates recommended by Verdant on the RITE Timeline. Is there any questions you have related to this? Thanks!Zach

From: Sharon Kramer<EMAIL_ADDRESS>Sent: Tuesday, December 15, 2020 12:58 PM
Subject: RE: water quality question
Thanks! Jonathan Colby was messaging me with questions about our source for the project timeline. I think there are dates for the RITE project that he thinks are incorrect. Do you know where we pulled those from? I thought we got them from Verdant…

From: Sharon Kramer<EMAIL_ADDRESS>Sent: Tuesday, December 15, 2020 12:44 PM
Subject: water quality question
Zach – BOEMs lease and FERCs license, and Corps permits, cannot violate regulations affecting water quality, so yes, clean water act is the statute for water quality, and all of the other permitting processes have to address it.  Sharon H. Kramer, Ph.D.

So how to change symbology etc to incorporate this?

So how to change symbology etc to incorporate this?


Refactor the test suite to use the assert_column_equality method

@MrPowers : Can you share an example for what needs to be achieved in this issue?, I would like to give it a try .

This has been completed.


FR: Generate the Index like the MoC Plugin does

The MoC Plugin basically generates its index purely via wikilinks already existing in notes. The trick is to define a central note, and the MoC plugin then creates a hierarchy based on shortest path(s) of a note the that central note.
I think a similar approach could be implemented by Breadcrumbs as well. The major advantage for this would be that it requires far less setup. I was thinking of using breadcrumbs, but defining yaml frontmatter or an index note is so much work in a bigger vault, while using a network of already existing wikilinks is almost no work (only need to setup a central note from which all clusters in your graph are linked to). And knowing that you also did the graph Analysis plugin, you probably have the code for stuff like shortest path calculation anyway? :o

Haha Breadcrumbs is actually very well set up to do this already!
There is already a setting to define a "Central Note" 😋
I'll definitely work on this

@chrisgrieser perhaps for the time being, this feature and the one below it can fill the gap for you!
https://github.com/SkepticMystic/breadcrumbs/wiki/Alternative-Hierarchies#folder-indexes

could you add some documentation for BC-traverse-note to the wiki? It seems to be part of the public Breadcrumbs release, but isn't listed in the alternative structure yet.
As far as I can tell, there aren't any serious bugs anymore, and I'd like to dive into it, but I am not sure what exactly I can configure right now :)

I'll consider this closed now. I've added a section to the wiki for traverse notes :)


Add yml file configurations to the mdm service

We need to be able to be a lot more adaptive with the configurations.
The current env method is not sustainable especially with the addition of so many plugins including openid connect.
Therefore we shall

add a build.yml file which is loaded when the mdm image is built, this will allow a user to build a single image with the same config to be shared across multiple runtimes
add a runtime.yml file which is added via the docker-compose.yml file at runtime and will allow individual container/service customisation.

Notes
MDM config is hierarchical

System Properties
ENV
runtime.yml
build.yml
application.yml (included as part of the build and holds all the defaults)
plugin.yml (each plugin can define their own defaults to ensure if they're missed from application.yml they're still set)

See https://docs.grails.org/4.0.10/guide/conf.html#config for in-depth details

this has been done


org.ehcache.internal.store.disk.DiskStoreTest racy?

I've had testFlushingMakesMappingEvictableAgain fail spuriously.
I wonder whether when pushing the DiskStore, you shouldn't flush in order to make sure all "settled".

Test no longer exists


Move 'World Traveler' region to top

In Settings, can you move the "World Traveler (none)" region option to the top of the list and rename it to "None (Default)"?

This one is finished as of the next build to appear on testflight (609 or higher)


[help] query structure for find.

Hi, is the code a right query structure ? because when I tried it I got an error message.
"articles" is an array in "datastoreTopics" I want to get all the "topics" that have more than one article.
Code:
NSDictionary *query = @{@"articles" : @{@"$not" : @{@"$size":@1}} };
CDTQResultSet *result = [datastoreTopics find:query
skip:_pageIndex
limit:_pageSize
fields:fields
sort:sortDocument];
Error :
DB Error: 1 "near "?": syntax error"
DB Query: SELECT _id FROM "_t_cloudant_sync_query_index_basic" WHERE _id NOT IN (SELECT _id FROM "_t_cloudant_sync_query_index_basic" WHERE "articles" (null) ?);

Hi,
Yes that is the correct Query structure, our query grammar doc  provides the full grammar for query.
I am pretty sure this is a bug and your query should be working correctly. What version of CDTDatastore are you using and on which platform?

I am using  'CDTDatastore', '1.1.1'
on (iOS 9.0) objective-C application.

I've reproduced with 1.2.0

is there any alternative way to do it ?

Unfortunately I don't think there is an easy way of doing the same thing.

I figure out the problem, I was using "articles" as "ensureIndexed" I dont know what is the reason but when I delete it from the "ensureIndexed" and delete the app from the device and reinstall it, the query "@{@"articles" : @{@"$not":@{@"$size":@1}}}" worked fine.

Glad you've found a work around, but I'm sure this a bug with our operator handling, so I reopening.


Put an object to AWS S3 with server-side encryption

Is your feature request related to a problem? Please describe.
Currently, Quickwit doesn't upload objects to AWS S3 with the server-side encryption required by the security baseline on AWS.

Since 2023 By default, SSE is enabled on all buckets on S3.
https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingServerSideEncryption.html
I don't think anything needs to be done on Quickwit side. Closing the issue for the moment, but please comment if this is not what you meant.


Use 201 status code for put license

Scope & Purpose
Documentation mentioned two status codes (200 and 201) for put admin license. 201 is the correct code. This PR fixes the discrepancy.

[ ] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[x] Backport for 3.9: https://github.com/arangodb/arangodb/pull/16179
[ ] Backport for 3.8: (Please link PR)
[ ] Backport for 3.7: (Please link PR)

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

[ ] https://jenkins.arangodb.biz/view/Documentation/job/arangodb-ANY-examples/1945/


Add sys: module to expose platform and arch vars

Resolves #916

@xiaq Please take another look.

I posted a comment, but actually I think we need to think harder on how to name this module and what its scope should be.
I was considering modelling the module after Python's sys (and commented that I preferred it), or Go's runtime, but after thinking about it more, I think both make the mistake of mixing at least two kinds of things:

Things important to the runtime environment itself: Python has sys.path; Go has runtime.GOROOT.
Things related to the low-level environment: Python has sys.platform, Go has runtime.GOOS.

I think it's wise to separate both things, and the variables in this PR definitely belong to the second bullet. Your proposed name of os comes close to describing it, but I'm not enthusiastic about the name. Not because of the clash with Go's os, but because $os:os is too awkward.
Maybe platform is a good choice? Variable names $platform:os and $platform:arch make a lot of sense. It is slightly too long, though.
(I am inspired by Python's platform module, although the Python module makes the mistake of including information about the interpreter.)
It's probably also worth researching how other languages call such modules.

I think we need to think harder on how to name this module and what its scope should be.

Okay, but since it seems like we're still a ways away from a elvish 1.0 release it seems like doing something reasonable, if not ideal, is better than not doing anything and forcing people to use the uname command. As people use it and provide feedback we can refactor as appropriate.

Maybe platform is a good choice? Variable names $platform:os and $platform:arch make a lot of sense. It is slightly too long, though.

I'm not bothered by the length of those two example var names. However, I was thinking that builtins like chmod and umask which cannot be implemented in an OS agnostic fashion would be placed in the os: namespace. That, in fact, is what Python does. Perhaps we should start with a platform: namespace that exposes basic facts (e.g., the CPU architecture) then add an os: namespace for OS specific capabilities like umask.

@krader1961 I agree with what you said, so let's rename the module in this PR to platform and we are good to go.

@xiaq, Please take another look.


Make waiting for external process optional in RuntimeUtil

some processes get stuck if this is called:
process.waitFor();

Apparently the size of the STIO or STERR buffer is limited, and if a program writes a lot to it, and on the Java side we do not read it, we can have a deadlock on process.waitFor().
The fix needs to include reading STDIO and STDERR asynchronously and in a limited fashion, so as not to eat up all heap space if the child process goes crazy.


Design pluggable system for extending available transforms

We'd like to make it possible to extend Amaxa's transform system with simple pluggable modules.
Initial design sketch:

An operation could specify an import path to a callable
That callable is a factory, which accepts some metadata about the transform it's being asked to do (such as the field name and type)
It returns a dict of transform names and callables that Amaxa can then apply.

Genesis of this proposal is discussion between David and Kyle Crouse about the infrastructure needed to support 3rd-party data obfuscation capabilities.
See also #29.

See also #29: we should also support transform functions being parameterized with options that are set in YAML markup on a per-field basis.

I just merged in code that I think will hit this mark. It adds prefix and suffix transforms, as well as allowing for further extensibility in separate modules.


Feature1

Bug fix #564 - When publishing feature is enabled, subsite link override fails
Ravi & I fixed this bug by waiting for the page to load before the call to subsite_override takes place.

Thx Ken, appreciated,

Hi Ken,
could you please target this change to Dev branch. We only do master branch changes during our master merge so that we void any breaking changes like mentioned from the wiki post related on pull request handling at - https://github.com/OfficeDev/PnP/wiki/Preparing-a-contribution-and-letting-the-PnP-core-team-know-via-a-pull-request.
Missed the targeted branch during first merge, so sorry for that and thx for your contribution.

Done!  Thanks Vesa!


Allow minus sign at the start of a label

@bratseth @havardpe Are there any implications for the backend here?

yes, but I am working on supporting more relaxed labels in the back-end as well

this will allow labels to contain anything in the back-end (including '-'):
https://github.com/vespa-engine/vespa/pull/11524


Increase MAPPING_MAX_NUM and KEY_MAX_NUM to 1024

I would like to defined rules more.

Let's remove 1.9.2

Removed

Good to merge


added slide show snippets

https://github.com/Premkolte/AnimateHub/assets/110299021/f400c6f8-3d90-4ff2-8c70-4aa0f8315203
one is automatic and other is manual
@Premkolte assign me this

good. Merged. Keep up the good work.


A suggestion

Sorry for disturbing you, but I have a question.Through reverse engineering, I know that when registering, the client will send an exist request before sending the code request. I am a novice here, and I don’t know why this part is ignored by the province. Can this function be added to Cobalt. Make the registration part of Cobalt perfect.

Sorry for disturbing you, but I have a question.Through reverse engineering, I know that when registering, the client will send an exist request before sending the code request. I am a novice here, and I don’t know why this part is ignored by the province. Can this function be added to Cobalt. Make the registration part of Cobalt perfect.

i ignore it because if the number doesn't exist it will throw the same error as the exists method, so i saw no reason to add an additional request


Vahana and Orah 4i

how can I connect to Vahana directly by Orah 4i camera, and its four H264 streams grab directly through RJ45? it's the same ex company, isn't it in the source code?

It's possible to stitch the 4 streams from the camera with Vahana VR. The tricky part is getting the camera to start streaming. In hardware you would need a PoE injector to power the camera. In software you would need to setup a DHCP server, an RTMP nginx server for the camera to register with and then send some proprietary commands to the camera to start the streams at each power up. And maybe something else I'm forgetting. It's not my area of expertise, but a colleague has promised to have a look at how we can provide all the necessary information to get an Orah 4i running without the box.
Why do you ask, is your stitching box broken or do you wish to do a custom setup?

sorry for the delay, I have a 20x orah cam, I do live multicam streaming on it, it's not very comfortable to have a 20x stitching box, I use NGINX it wouldn't be a problem, I could handle DHCP for the cameras, I have PoE solved, I connect the camera via optics or radio to the box, I know that the camera will release 4x rtmp H264 stream, the only thing I don't know are those commands :-)

this is complete ORAH files from ex support webpage, if
would someone need https://www.dropbox.com/sh/tmw0871htsulmfr/AABBG90CImxooHLC7msPhn1La?dl=0

Hi,
sorry for the delay, but this camera is not in the scope of the open source project.
Anyway, we should quickly provide something to allow to start it and setup a conf to retrieve the streams.

Please have a look here :
https://github.com/stitchEm/camorah

Issue should be resolved, feedback and discussion can continue in the camorah repository.

Oh, this is spectacular, thank you very much I'm going to try :-)

Anyone here knows how to extract the camera firmware or get the box Linux for camera firmware flashing?

Just for the purpose of completeness I will post the link to the firmware here as well:
https://github.com/natecarlson/orah-4i-recovery


Blank Creative Tab

I disabled the Spawn Egg creative tab in the config, yet it is still there, just completely blank and without any spawn eggs. This irks me relentlessly, as the whole point of the mods I'm using is simplicity, which means no extra Creative Tabs. Can this be fixed?

This shouldn't be happening. I'll fix it as soon as I can.


Create Markdown style guidelines.

I went ahead and created some basic Markdown style guidelines to ensure consistency and readability throughout all of our Markdown files. Would love to hear any input from you guys.
@MaxWofford want to take lead on reviewing this/getting it merged?
/cc @jonleung @andreadeng @MaxWofford

Thanks @zachlatta! This is a good start. Happy to merge once comments are addressed.

ᐧ
@zachlatta lgtm

@MaxWofford alright, I've addressed your comments & squashed my commits.
Let me know if anything else :-).

@jonleung http://www.lgtm.in/


[BUG] Bloxstrap.Exceptions.HttpResponseException: Could not connect to https://clientsettingscdn.roblox.com/v2/client-version/WindowsPlayer/channel/zuadfrelease because it returned HTTP 401 (Unauthorized)

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[ ] My answer given in the checkbox above is a lie.

What problem did you encounter?

You're not using the latest version of Bloxstrap. https://github.com/pizzaboxer/bloxstrap/releases/latest


Add georgian (ka) localization

This pull request includes a

[ ] Bug fix
[ ] New feature
[x] Translation

The following changes were made

Added Georgian (ka) localization

@akalongman looks good, but it's failing the Travis build:
Running "jshint:code" (jshint) task
   src/js/select2/i18n/ka.js
     25 |      var message = 'თქვენ შეგიძლიათ აირჩიოთ არაუმეტეს ' + args.maximum + ' ელემენტი';
                                                                                ^ Line is too long.

Can you fix this?

@alexweissman done


Updated langdata

We need the updated langdata with the update unicharset specially for arabic language to be able to maintain the same accuracy in the new .traineddata
Thanks

I don't know if Ray plan to update these files.
Anyway, it seems that you can now extract the unicharset and the dawg files used by the new lstm engine from the traineddata.

Yes, using combine_tessdata is an easy way to get the unicharset and the dawg files from a traineddata file. In a 2nd step the word list can be made from those files using dawg2wordlist.
Then you can remove unwanted components, fix word lists and reverse the whole process to create your own new traineddata file.

Actually, I'm trying to fine tune and continue from the new Arabic.traineddata but the newly generated traineddata file can't keep the same accuracy as Arabic.traineddata.
Also, the current unicharset of landdata repo has around 2048 data but the generated from the new traineddata around 300 only is that logic?

Point taken. It needs updating. I was going to push until I discovered a bug with the RTL word lists.
Then I also need to integrate this issues list, that I haven't looked at in a while, and rerun training.

@theraysmith Is it ready for update now?

@jbreiden Do you have the files to update this repo for 4.0.0?
Alternately, should we try to reverse engineer files from tessdata_fast, they  will not be complete -  (config, wordlist, numbers, punc, unicharset).

Do you have the files to update this repo for 4.0.0?

No, I don't. But I have been (and continue to)  look into this.

Hmm. Sorry. I thought I had done this in September.
The Google repo is up-to-date apart from the redundant files that need to be deleted.
I'll work with Jeff to get this done.

Thanks!
Will the training process, tesstrain.sh and related scripts also need changes?

Also, what about the possibility of training from scanned images?

Also, what about the possibility of training from scanned images?

It is possible and seems to work pretty good, as I heard from @wrznr.

@stweil Do you know how the box files for the scanned images were created?
ASAIK tesseract makebox generated box files do not match the format of files from text2image.

@theraysmith

Since training depends on the fonts used, I suggest loading a file with fontlist used for training in every language and script in their own subdirectories. This file can then be referred to by tesstrain.sh/language_specific.sh.

Is it possible to use multiple languages to continue from for creating a 'script' type of traineddata by finetuning?

On Wed, Mar 21, 2018 at 1:28 AM Shreeshrii<EMAIL_ADDRESS>wrote:

@theraysmith https://github.com/theraysmith

Since training depends on the fonts used, I suggest loading a file
with fontlist used for training in every language and script in their own
subdirectories. This file can then be referred to by
tesstrain.sh/language_specific.sh.
Yes, I have a list of fonts used for each training, and can add that to
the langdata.

Is it possible to use multiple languages to continue from for creating
a 'script' type of traineddata by finetuning?
Unfortunately not. I did have an idea for a better multi-language
implementation that would cleanly use models from multiple languages at
once, but that depends on getting rid of the old code, and moving the
multi-language functionality into the beam search. Until the old code is
gone, that would be very messy.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/langdata/issues/83#issuecomment-374863461,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL056bXfAPBtr62lkf6Ma2WzI5Zv7CAVks5tgg8cgaJpZM4Otkog
.

--
Ray.

@Shreeshrii Your right, creating box files has been done by using an extra script. It is rather straightforward:

split your GT line into characters
print them ‘one-char-per-lien’ and add the coordinates of the whole line to each character
add a tab stop (as an EOL indicator) to the end of the line with line coordinates +1

related: https://github.com/tesseract-ocr/tesseract/issues/1276#issuecomment-358970736

@wrznr's method is similar but easier than my proposal.

@wrznr
Please share the script, if possible. I would like to test it for Indic/complex scripts. It will also be useful to many others who have been asking for this feature.
You could create a PR to put it in https://github.com/tesseract-ocr/tesseract/tree/master/contrib
Thanks!

It won't work well for complex scripts like the Indic scripts.

@theraysmith
@jbreiden
Any update regarding this???
On Tue 20 Mar, 2018, 8:52 AM theraysmith<EMAIL_ADDRESS>wrote:

Hmm. Sorry. I thought I had done this in September.
The Google repo is up-to-date apart from the redundant files that need to
be deleted.
I'll work with Jeff to get this done.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/langdata/issues/83#issuecomment-374460335,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE2_ozSnNQITRG_kE4gS1yHJgQXSJyKuks5tgHXcgaJpZM4Otkog
.

@Shreeshrii FYI: https://github.com/OCR-D/ocrd-train

@wrznr Thank you for the makefile for doing LSTM training from scratch. I will give it a try.
Do you also have a variant for doing fine tuning or adding a layer?

https://github.com/tesseract-ocr/langdata_lstm
has the updated langdata files fo LSTM training.
This issue can be closed.


cloud-nuke: Add version 0.1.8

It looks like CLI. It should be in Main bucket.

Moved to main bucket: https://github.com/ScoopInstaller/Main/pull/364


Can you noticify me when you'd reach generic programming on CPDT?

@lolisa Sorry, this isn't under active development. More generally, I'm not working with Coq or formal verification for the time being. If you have suggestions, though, I'm very interested to hear them.

@mmcco It's OK, I finished the book myself long ago


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

I change the isnumeric to isalpha and if its true it will return True if it false it will return False


More explicitly explain that permafrost data is only available for point locations

And only for Alaska point locations at that (sorry Canada)


[#141943157]Assessment schema generation

Story https://www.pivotaltracker.com/story/show/141943157
For now I decided not to follow the existing schema generation script's pattern (generating schemas for all known frameworks and sticking them in a target directory) and instead just generating the schema for a single framework (slug specified on cmdline) and outputting it to stdout. It's really the most flexible behaviour.

Looks good, sorry it's been so long before it got reviewed 😞
:+1:


Package listing

Noticed there was some missing functionality from the official API docs.
This branch adds in the functionality to list out packages within a repo and the ability to delete packages.

Thanks!


New GitHub User for authentication

We need to create a new GitHub user where we can add it to all organizations where we maintain open source code, from there we can generate a PAT token which has access to re-enable workflows in that organization.

Should be added to the https://github.com/orgs/invenia/teams/automatons group

Created the account https://github.com/InveniaBot.


Additional sfz files won't make sound.

I added additional sfz files and added the file names in the exsPresets array, but when I tap on the keyboard with those sfz files selected, no sound comes out.

AKSampler is not a full SFZ player. It supports only a very limited subset of the SFZ format, as described here:
https://github.com/AudioKit/AudioKit/blob/v4.2/Documentation/PreparingSampleSets.md

I used Wavepack to convert all wav files to wv. But still no sound. Any specs to tell what kind of samples can be played in ROMPlayer? Thanks.

The problem is from the .sfz itself. Why?
Please read my original reply above, where I said "AKSampler is not a full SFZ player" and gave a link to the exact format. That is "why".

Also, note you don't have to convert .wav to .wv. That's just a way to reduce app download size. If you get the ".sfz" format correct, you can use .wav files, or .aif files, etc.


Africa module split

r+

it's unfinished work: I'd like to cleanup unnecessary imports (print_function, and such)

Obsolete, will restart from scratch


All tiles piles on top of each other

Hi
I am trying to use this in CEWP. I added one tile it worked. Then when added other tiles, all pile on top of each other on topLeft. What could I have done wrong?

How did you add the other tiles? Can you show a screenshot? Can you export the list as an Excel file and attach it here?


BatchControl/BatchHeader inconsistency

I want to say thank you for putting this project on the internet.  it is a great timesaver for software engineers around the world.
I have two questions, related to the project:

Why serviceSlassCode in BatchHeader.java is String, but in BatchControl.java it is Integer?
Looks like companyIdentification  in BatchControl.java and companyID in GeneralBatchHeader.java are the same value, but why they are named differently?

Thank you very much!

@halytskyiv to be honest, I didn't create this inconsistency by myself. All those types and fields are from nacha spec and I agree, that sometimes they could look weird ¯_(ツ)_/¯

@afrunt Thank you for a quick response


Unable to confirm account since 'confirmed_at' attribute is nil

Rails - "<IP_ADDRESS>"
Devise - "3.4.1"
Before we have not configured confirmable for one of the model and just integrated to the particular model added
Step1: devise :database_authenticatable, :registerable, :recoverable, :rememberable, :trackable, :validatable, :confirmable
Step2: Added columns
# Confirmable
add_column :customers, :confirmation_token, :string
add_column :customers, :confirmed_at, :datetime
add_column :customers, :confirmation_sent_at, :datetime
add_column :customers, :unconfirmed_email, :string
After all this integration i am generating mail with the link but i am unable to confirm when i click that link it is redirecting to application index page and confirmed_at column is not updated so i am unable to confirm .
I am facing this issue from past one week so could any one can help me to fix this please.
Thank You

Can you post the corresponding logs?
I tried to create an example app, but i didn't get rails <IP_ADDRESS> to work.
Can you create an example app which reproduces this error?
Bests

Hello Flo ,
i am unable to find any exception in log . we have integrated devise gem for two active records  (users and customers) for customers we have configured with confirmable and confirmable token in the link sent to mail is different from which it is generated. once we are tryning to confirm it redirecting to user login without updating to the customer confimed at column. I have integrated working product. please flo i am struggling from last 15 days to fix it ..
Thank You

Can you post your log file?

After Sign Up
SmartMiles Load (0.3ms)  SELECT smart_miles.* FROM smart_miles LIMIT 1
Rendered /home/shivaprasad/.rvm/gems/ruby-1.9.3-p551/gems/devise-3.4.1/app/views/devise/mailer/confirmation_instructions.html.erb (1.0ms)
Sent mail to<EMAIL_ADDRESS>(4247.5ms)
Date: Tue, 03 Jan 2017 19:34:30 +0530
From<EMAIL_ADDRESS>Reply-To<EMAIL_ADDRESS>To<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>Subject: es-Confirmation instructions
Mime-Version: 1.0
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
Welcome<EMAIL_ADDRESS>You can confirm your account email through the link below:
Confirm my account
After clicking the confirmation link
Started GET "/customers/confirmation?confirmation_token=CgyjWdELJ7QUPX2GTgoX%22" for <IP_ADDRESS> at 2017-01-03 19:36:22 +0530
Processing by Devise::ConfirmationsController#show as HTML
Parameters: {"confirmation_token"=>"CgyjWdELJ7QUPX2GTgoX""}
"<IP_ADDRESS>" - Started PID: 4241 => Received "GET" to "http://www.orange.lvh.me:3000/customers/confirmation?confirmation_token=CgyjWdELJ7QUPX2GTgoX"" at 2017-01-03 19:36:23 +0530.
Travel Load (0.2ms)  SELECT travels.* FROM travels LIMIT 1
SQL (0.1ms)  SELECT name FROM travels
(0.2ms)  SELECT DATABASE() as db
TravelPref Load (0.2ms)  SELECT travel_prefs.* FROM travel_prefs LIMIT 1
CACHE (0.0ms)  SELECT travel_prefs.* FROM travel_prefs LIMIT 1
TravelPref Loaded  From Identity Map (id: 1)
Redirected to http://www.orange.lvh.me:3000/account/signin
Filter chain halted as :login_required rendered or redirected
"<IP_ADDRESS>" - Completed in 16.751552ms PID: 4241 => Received "GET" to "http://www.orange.lvh.me:3000/customers/confirmation?confirmation_token=CgyjWdELJ7QUPX2GTgoX"" at 2017-01-03 19:36:23 +0530.
Customer row itself is deleted from database after confirming.

The token in the confirmation link is always different, that's OK.
For me it looks like that your authentication doesn't allow this call and redirects.
Filter chain halted as :login_required rendered or redirected
And there is no customer loaded form the db.
Usually your log should look like this:
Started GET "/users/confirmation?confirmation_token=s_ZxfeF_GnU4TNfp5jiB" for <IP_ADDRESS> at 2017-01-03 15:46:21 +0100
Processing by Devise::ConfirmationsController#show as HTML
  Parameters: {"confirmation_token"=>"s_ZxfeF_GnU4TNfp5jiB"}
  User Load (0.1ms)  SELECT "users".* FROM "users" WHERE "users"."confirmation_token" = '06b4f7e8049654d45cf24479b1c493748cf5a0e7b0035f6a639477766045377b' LIMIT 1
   (0.0ms)  begin transaction
   (0.7ms)  UPDATE "users" SET "confirmation_token" = NULL, "confirmed_at" = '2017-01-03 14:46:21.663307', "updated_at" = '2017-01-03 14:46:21.663757' WHERE "users"."id" = 3
   (42.4ms)  commit transaction
Redirected to http://localhost:3000/users/sign_in

Check if your user are allowed to access this route

After adding below code also it is redirecting account/signin rather than customers/sign_in
class CustomersController < Devise::SessionsController 	 skip_before_filter :login_required
code goes here
end

Hi Flo,
i have just overriding the after_confirmation_path_for method of Devise::ConfirmationsController. it working fine.
Create a new confirmations_controller.rb in app/controllers directory:
class ConfirmationsController < Devise::ConfirmationsController
private
def after_confirmation_path_for(resource_name, resource)
your_new_after_confirmation_path
end
end
In config/routes.rb, add this line so that Devise will use your custom ConfirmationsController. This assumes Devise operates on users table (you may edit to match yours).
devise_for :users, controllers: { confirmations: 'confirmations' }


[Feat] Exploring AgentDelegation through Supervisor Agent

End-user friendly description of the problem this fixes or functionality that this introduces
Exploring if agents can achieve better outputs if they have supervision. This is a draft PR.

[ ] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions
We propose a hierarchical agent framework that introduces a "supervisor" agent responsible for overseeing the big picture of a given goal. This supervisor agent holds the overall objective and devises a plan comprising sequential steps to achieve it. Subordinate agents are assigned independent tasks, allowing them to focus on specific subtasks without being burdened by the overall complexity. The supervisor coordinates these agents, ensuring that their outputs align with the overarching goal.
Supervisor Agent

Big Picture Oversight: Maintains the overall goal and the plan to achieve it.
Task Delegation: Assigns independent tasks to subordinate agents.
Output Coordination: Determines which outputs are needed from agents to progress towards the goal.
Communication Hub: Acts as an intermediary for agents to pass outputs to the next agent.
Guidance and Intervention:

Provides clarifications and additional information when agents request it.
Monitors task progress and can interrupt agents if they take too long.
Offers guidance based on its comprehensive understanding and outputs from other agents.

Subordinate Agents

Focused Task Execution: Concentrate solely on their assigned tasks.
Independent Operation: Perform tasks without needing to manage the overall plan.
Output Submission: Provide results to the supervisor for coordination.
Feedback Loop: Can request clarifications or more information from the supervisor.

Communication Flow
Agents communicate with the supervisor for:

Task assignments.
Submitting outputs.
Requesting guidance or clarification.

The supervisor ensures outputs are appropriately routed to subsequent agents or integrated into the overall plan.
Asymmetric Model Scenarios

Advanced Supervisors:

Utilize sophisticated models (e.g., o1-preview, Claude 3.5 Sonnet) as supervisors.
Advantages: Better at solving complex issues and managing tasks.
Consideration: Higher operational costs due to model complexity.

Economical Subordinate Agents:

Employ smaller, cost-effective models (e.g., DeepSeek, o1-mini) for subtasks.
Advantages: Reduced costs while maintaining efficiency in task execution.

Link of any specific issues this addresses

Overall Feedback:
The introduction of the Supervisor Agent is a promising enhancement to the agent framework, providing a structured approach to task delegation and coordination. The design effectively outlines the roles of both the supervisor and subordinate agents, ensuring clarity in their interactions and responsibilities. The implementation appears to be well thought out, with a focus on maintaining the overall goal while allowing subordinate agents to operate independently.
Score: 90/100
Code Suggestions:

File: openhands/agenthub/supervisor_agent/prompt.py

Language: Python
Suggestion: In the adjust_milestones function, consider adding validation to ensure that the subtask dictionary contains the expected keys (task, suggested_approach, important_details) before attempting to access them. This can prevent potential KeyError exceptions if the dictionary is malformed.
Relevant Line: +    milestone_task = subtask['task']

The Supervisor Agent framework is a well-structured addition, enhancing task delegation and coordination. Here are some suggestions:

In adjust_milestones, add validation to ensure the subtask dictionary contains the expected keys to prevent potential KeyError exceptions.

@AlexCuadron anything that needs to be done here to move it forward? Are you looking for reviews? Or is this still in progress? There's been a month of no activity so just want to understand the status.

@AlexCuadron anything that needs to be done here to move it forward? Are you looking for reviews? Or is this still in progress? There's been a month of no activity so just want to understand the status.

It is still in progress, I work closely with @xingyaoww on this one, I have many changed on local. I need to make the more "ready" then I can update the PR.


the performance of process works not well

Hey, I am trying to use blinker to process events from the server.
As I subscribe to many contracts, blinker seems to process events too slowly.
So I want to ask you it can support thread or gevent ?

You can certainly use blinker with threads and gevent as makes sense for your use case. Blinker itself is extremely lightweight. For extreme performance it may make sense to roll your own approach with only the features you need.


fix:reduce-computations

Summary:
The pull request optimizes the canUseCachedMeasurement function in the Yoga library by reducing redundant computations, combining conditions where possible, and enhancing readability and performance. These changes aim to improve the efficiency of the function without altering its overall implementation or behavior.
Changelog:
[GENERAL][CHANGED] - Optimized the canUseCachedMeasurement function to reduce redundant computations and improve performance.
Test Plan:

Unit Tests: Ran existing unit tests to ensure the optimized function produces the same results as before.
Performance Tests: Conducted performance tests to measure the execution time of the canUseCachedMeasurement function before and after the optimization.
Code Review: Reviewed the changes to ensure they maintain the original logic and correctness of the function.

The tests confirmed that the optimized function is more efficient while producing the same correct outputs.

This seems sane, but I'm curious how performance was measured and what difference was seen here. My assumption would be that the compiler would reuse the same math here.

Could you please make this against the Yoga repo (https://github.com/facebook/yoga) instead of the React Native one? The two will sync when merged.

@NickGerleman  https://github.com/facebook/yoga/pull/1681 we can close this one 👍


Q: feasibility of substituting pgsql for sqlite?

More of a question than an issue.. but maybe it could turn into a PR :)
Is it easy/hard/impossible/a good idea/a bad idea to substitute postgres for sqlite? This looks really cool and promising but I'm interested in reducing external (or local -- this is going to be dockerized) dependencies
Thanks in advance!

Re feasibility: The main idea is to load data into the db with something_outputting_csv | psql_command_which_inputs_csv_into_db and to run pipelines as cat sql_file | psql ... to run sql commands on a db. As long as this is supported, I think it can be made to work with other DBs. It might be that some SQL commands are not available (e.g. UPSERT, needed for incremental loads), but that can probably be worked around.
That being said: currently a lot of internal stuff simply assumes that the backend is a postgresql DB. Lot's of internal stuff like incremental loading would need to be abstracted (e.g. similar to the copy_* stuff which uses @single_dispatch: https://github.com/mara/mara-db/blob/master/mara_db/shell.py).
I've no clue if the above requirements are possible in sqlite, but e.g. SQL Server does not really support piping csv into a DB.

There's two aspects to this:
1 .The ETL needs a number of book keeping tables

for run-time stats, run output and system statistics (https://github.com/mara/data-integration/blob/master/data_integration/logging/run_log.py)

for incremental loading from databases (https://github.com/mara/data-integration/blob/master/data_integration/incremental_processing/incremental_copy_status.py)

for incremental processing (https://github.com/mara/data-integration/blob/master/data_integration/incremental_processing/file_dependencies.py)

Making these tables work with SQlite is quite hard (SQlite doesn't have arrays) and I'd be also afraid of performance impacts.

For the actual ETL itself, any database can be used. As @jankatins explained, it boils down to extending https://github.com/mara/mara-db/blob/master/mara_db/shell.py

So the PostgreSQL dependency will stay for now, and we are working on dockerization.


Backround flickers on search

When typing a search query, less cards are shown and the background size is changed. I suggest that the background fits the width of the window regardless of how many cards are shown.

Solved here: https://github.com/oasisprotocol/playground/pull/49


Error looking for rxjs/operators.js

**RxJS version: 5.5.0 **
Additional information:
It looks like there is still one place using the old operators file (src/observable/dom/AjaxObservable.ts) line 7: import { map } from '../../operators';

Is this issue fixed?

We ran into this issue as well, and pinned RxJS to version 5.4.3. This made it work for us again.

Did the same as @gildebrand but hoping that is just a temporary change and they fix it in 5.5.1 real fast 😬

anyone mind sharing small repo to test out this failure? I'm trying to look into this now.

I would be willing to bet this is using SystemJS.
Internally we shouldn't be referring to rxjs/operators as it will work in development, but will fail with SystemJS.

@jasonaden that's correct that this occurs with SystemJS!

I have pushed fix, there'll be patch release once it's available.

Thanks version 5.4.3 worked for me.
From: Anton Gildebrand<EMAIL_ADDRESS>Sent: Wednesday, October 18, 2017 2:47 PM
To: ReactiveX/rxjs<EMAIL_ADDRESS>Cc: nagarajpatil<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [ReactiveX/rxjs] Error looking for rxjs/operators.js (#2971)
We ran into this issue as well, and pinned RxJS to version 5.4.3. This made it work for us again.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/ReactiveX/rxjs/issues/2971#issuecomment-337737871, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVopn1BQk0hRRMhSxfs-xWrnK7h_kICZks5stnHngaJpZM4P-Ha-.

I've also reverted back to 5.4.3 for now.
I had a similar but different error when I removed rxjs from SystemJS config and added ".../node_modules/rxjs/bundles/Rx.js" script tag to the page header.

Having the same problem as well.

I'm using webpack (Angular CLI), and all the operator functions are undefined at run-time for me with 5.5.0. Specifically, I'm getting an error when .first() is called on a BehaviorSubject.
Is this the same bug described here, or should I report it separately?

@buu700 I think this is a separate issue. If you could file an issue with a reproduction, that would be great.

Got it, thanks! Actually, upon further investigation, I'm not sure whether this is an rxjs or Angular bug, so I'll report the details in a ticket there and CC you.

I had this problem too (fixed by reverting the version) and I am using SystemJS.  Is only WebPack going to be supported in the future?

@shaycraft Nope. Just waiting for a 5.5.1 release. If you were on master SystemJS would be working right now.

This the file operators.js (zipped) that is necessary to temporarily add to node_modules/rxjs directory for RxJS 5.5.0 to enable it for using with SystemJS:
operators.zip

I maintain an automatic parallel package of RxJS, which produces a SystemJS bundle: https://www.npmjs.com/package/rxjs-system-bundle
...  and of course it the same problem. I worked around it:
https://github.com/OasisDigital/rxjs-system-bundle/commit/b0f714aa307cb89f14bc6097783c6453674e81d5#diff-0b83f9dedf40d7356e5ca147a077acb4R9
with a (hopefully very temporary) hack consisting of a single sed command:
sed -e "s/'\./'.\/operators/" <node_modules/rxjs/operators/index.js >node_modules/rxjs/operators.js

I don't recommend this, I just did it to keep producing a working bundle. Hopefully the need will evaporate with the upcoming 5.5.1.

@kylecordes I'm still seeing this issue with my SystemJS bundle on 5.5.1.

@pe8ter no i am seeing the same thing.  They are requiring "operators" which is a folder which isn't allowed.  Only webpack (or other bundler) allows import of folder where it assumes you mean the index.  There is no way for system.js in the client to do this.  This needs to be fixed as it is a breaking change.

@babeal What you're saying is true of the code as it is arrives from RxJS, but it is possible to work around it, and I have done so with an awful hack that I mentioned a few messages up.  My hack creates the missing operators.ts file. It is ugly but it does work fine. When I get a chance I will post a Plunkr demonstrating it.

@jasonaden ... did we understand wrongly that version 5.5.1 eliminates the problem with missing operators.js file (https://github.com/ReactiveX/rxjs/issues/2971#issuecomment-338316966)?

@kylecordes yea thanks.  I hear you it's easy to fix but I don't want to have to do that for the 15 projects I maintain so I will lock to 5.4.x until this is fixed.

@pe8ter @babeal @mlc-mlapis  Here are the changes in RxJS between 5.5.0 and 5.5.1; I don't think any of these are relevant to our SystemJS operators.ts problem here unfortunately. So I think the @kwonoj fix must have been about a different 5.5.0 glitch.
https://github.com/ReactiveX/rxjs/compare/9538a2024973d9a5c3cbeb26503cc8090dd6b806...0650c52c937cc5153a3d1cc23daf1a689dd921f4
Here is a plunkr which shows my SystemJS redistribution of RxJS in action (look at config.js). Take a look at app.ts to see the operator import.
https://plnkr.co/edit/4Y6KAJ28Wwua8RSVaV8A?p=preview

It looks to me like the issue was introduced here: https://github.com/ReactiveX/rxjs/commit/ba2f58686128c910a3391b0ace697b34d8542b78#diff-5fe03a9b5bb68d1a34618cf458d64e1c
Is anyone working on a pull request for this?

@kylecordes ... shouldn't be "rxjs/operators/*", added also?
bundles: {
<EMAIL_ADDRESS>[
      "rxjs",
      "rxjs/*",
      "rxjs/operator/*",
      "rxjs/operators/*",
      "rxjs/observable/*",
      "rxjs/scheduler/*",
      "rxjs/symbol/*",
      "rxjs/add/operator/*",
      "rxjs/add/observable/*",
      "rxjs/util/*"
    ]
}

@kylecordes ... you should also apply zone-patch-rxjs.js from zone.js because the problem with RxJS scheduler & zone is still not solved in RxJS.

@mlc-mlapis  I have updated the plunker to make available (although the example doesn't import anything that way), and to apply the zone-patch-rxjs patch (although the example run OK without it already). Hopefully having this plunker sitting here linked will help out any passerby who comes along and needs the new lettable operator syntax to work via SystemJS, between now and when a more official fix can be made.
(By the way, this is my favorite kind of open-source contribution... a temporary thing to help fix an interim problem, to be later made obsolete by an upstream project so I won't feel guilt to maintain it forever :-) )

So... SystemJS projects doesn't work in this moment? Is there a date to work? I need a solution as soon as possible.

@ViictorG1 ... RxJS doesn't work even as 5.5.2 ... still the same problem .... but you can use advises above ... it works without any problems using them.

@mlc-mlapis at this moment I'm insert operators.js inside dist/node_modules/rxjs but it's so wrong... What you advise to me do?

@ViictorG1 ... as a permanent solution of course but still working ... I suppose that RxJS 5.5.3 will be there very soon and it'll be the right one for the problem.

@mlc-mlapis Ok, thanks, let's wait for permanent solution as soon as possible.

I think inserting this line into SystemJS config should fix this problem:
'rxjs/operators'<EMAIL_ADDRESS>

workaround:
echo 'require('./operators/index.js');' > node_modules/rxjs/operators.js

I did this to make it work:
packages: {
    "rxjs/operators" {
         "main": "index.js",
         "defaultExtension": "js"
    }
}

@pitAlex That worked great for me on my Angular 5 app. It's nice to have a workaround that doesn't require editing anything in node_modules.
You're missing a colon after "rxjs/operators", BTW.

This issue is fixed in 5.5.3. All workarounds above can be ignored.

I'm getting an error getting operators/refCount.js. Not able to create a plnkr with Angular Material.

I had the error : "looking for rxjs/operators.js",
when loading an angular TS file : "....service.js" ,
line 3 containing : "import { catchError, map, tap } from 'rxjs/operators';"
line 1 containing : "import { Observable } from 'rxjs/Observable';". That line gives no error! (so rxjs is available)
I don't know how relevant this is, but the solution was not changing version (of rxjs), nor editing the file named "systemjs.config.js", (adding a seperated referal to rxjs/operators, as a post above suggested to do). That systemjs file contains  : "'rxjs': 'npm:rxjs',", which is explaining the availability of eg. rxjs/Observable in angular TS
SOLUTION for me was : changing line 3 in service file to : "import { catchError, map, tap } from 'rxjs/operators/index';"
EXPLAINED : When checking "./node_modules/rxjs" you won't find a file "operators.js", but you'll find a folder "operators". you could refer to the needed operators, or just all available (choosing for index.js)
Hopefully this solves and explains for others following same tutorials as I'm doing.

I am still having the same issue in Angular 6.0.0? does the issue still exists in latest version?

@ChandraTerli ... ??? it was the issue with RxJS itself and not with Angular.

Thank you! for the response, I tried your suggestion but got 403 error saying access to is forbidden.
Sent from my iPhone

On May 7, 2018, at 5:17 PM, Miloš Lapiš<EMAIL_ADDRESS>wrote:
@ChandraTerli ... ??? it was the issue with RxJS itself and not with Angular.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

this is what I is in my Package.Json... "rxjs": "6.1.0" and in SystemJs.Config..,
'rxjs/operators': {
'main': 'index.js',
'defaultExtension': 'js'
}

and I get this error..
http://localhost:41211/node_modules/rxjs/ 403 (Forbidden)

@ChandraTerli ... but the error is related to rxjs and not to rxjs/operators:
http://localhost:41211/node_modules/rxjs/ 403 (Forbidden)
Are you importing what when the error appears?

@ChandraTerli ... it looks that you use SystemJS in the project. Is it an older app? And you want to migrate to Angular 6 now? Then I recommend you to start with a fresh project and with Angular CLI and migrate you previous app step by step.

I'm having a similar issue since rxjs 6:

GET<EMAIL_ADDRESS>404 ()
previewer.483de356abd4ac4365bd.js:1 Error: (SystemJS) Error: XHR error (404) loading https://unpkg.com/rxjs/operators.js
at XMLHttpRequest.wrapFn (https://unpkg.com/zone.js@0.8.26/dist/zone.js:1188:39)
at ZoneDelegate.invokeTask (https://unpkg.com/zone.js@0.8.26/dist/zone.js:421:31)
at Zone.runTask (https://unpkg.com/zone.js@0.8.26/dist/zone.js:188:47)
at ZoneTask.invokeTask [as invoke] (https://unpkg.com/zone.js@0.8.26/dist/zone.js:496:34)
at invokeTask (https://unpkg.com/zone.js@0.8.26/dist/zone.js:1540:14)
at XMLHttpRequest.globalZoneAwareCallback (https://unpkg.com/zone.js@0.8.26/dist/zone.js:1566:17)
Error loading https://unpkg.com/rxjs/operators.js as "rxjs/operators" from<EMAIL_ADDRESS>

@ShinDarth did you find a fix for the error you posted? I am getting the same error with rxjs 6, angular 6. Appreciate your help if you can give me some pointers on how this can be fixed.

not yet

@ursseenu71 FYI: I've raised a question here: https://stackoverflow.com/questions/51288263/plunker-error-get-https-unpkg-com-rxjs6-2-1-operators-js-404
I'll post the solution there in case I find one.

@ShinDarth ... entry point for an operator is rxjs/operators ... not 'rxjs'.


[pipelines] Fix panic in KPI parsing

Explicitly handle when there is incomplete Run duration or Run latency data provided.

@kpouget Both the default test now passes, and when running with wait_for_run_completion passes. Good to merge from my end

great, thanks Drew, merging!


Please invite me to the community

Name
vickkie
Additional Context
Subject: Request to Join
My name is vickkie from Kenya, and I am reaching out to express my interest in joining the Organization on GitHub.
I have been following the work of afridevelopers Community for some time now, and I am deeply impressed by the projects and contributions that the team has made.
I believe that my skills and experiences align well with the goals and values of afridevelopers Community, and I am excited about the possibility of contributing to your ongoing projects and joining the team.

Welcome Vickkie
We look forward to collaboration with you and your input in the community