[Bug]: BCPT did not find any Docker Container

Describe the issue
I want to use the Business Central Performance Toolkit VSCode Extension with a docker container but it did not find any container.
This will fetch forever and to type it in, will also not work.

Expected behavior
List my Container.
Steps to reproduce

Create a Docker Container with Performance Toolkit in it
run "BCPT: Setup new Business Central Performance Tooolkit project" command in VS Code:

Select "Docker" and wait....

Additional context
Did I miss some needed setup?
I tries serveral container parameters:

OnPrem
SandBox as OnPrem
With Dev. License
Without Dev. License
and some others I forget.

I will provide a fix for a bug

[X] I will provide a fix for a bug

@m3koenig, can you give full details about the steps you followed, like how you got the docker image, version, parameters used to create a docker instance, etc, to help me repro the issue?
There are also few blogs that I hope you have already visited, if not please consider doing so. Fx. https://www.bertverbeek.nl/blog/2022/12/01/visual-studio-code-and-the-performance-toolkit/
https://demiliani.com/2023/09/05/dynamics-365-business-central-using-the-performance-toolkit-to-discover-performance-regressions/

First, with this container creation script, I create the container:
$containerName = 'MyBCPT'
$credential = Get-Credential -Message 'Using UserPassword authentication. Please enter credentials for the container.'
$auth = 'UserPassword'
$artifactUrl = Get-BcArtifactUrl -type 'Sandbox' -country 'de' -select 'Latest'

New-BcContainer `
    -accept_eula `
    -containerName $containerName `
    -credential $credential `
    -auth $auth `
    -artifactUrl $artifactUrl `
    -memoryLimit 8G `
    -includeTestToolkit `
    -includePerformanceToolkit -updateHosts

Then I open a VSCode BC Project (the code of an app) and run "BCPT: Setup new Business Central Performance Tooolkit project" command in VS Code:

Select "Docker" and then I waited:

+1 for this. No operation with Docker selected actually works (running either). Tried on two different machines, latest version of Docker used.

Same issue as #26799.

This seem to have been caused by change in the BCArtifactUrl. Needs a new version of vsix

I assume this was taken care of. Closing issue.

don't think it was taken care of....still not working....we are waiting for weeks now :'(

@ChethanT, could you check if this issue still is pending? Did we not resolve this?

We have updated the BCArtifactUrl. But after testing the docker story of bcpt is still broken because of some changes in Admin endpoint. We are actively working on this but need more time to solve it.
One option is using sandbox to run bcpt. It should work.

Hi @sweikelt @m3koenig @vjekob
We shall release a new version vsix to solve this.
But I have one question to double check with you: Could you help me check if your docker's port 7086 is available?

If it is not shown here, Consider to use this command to create the docker:
New-BcContainer
-accept_eula      -containerName $containerName
-credential $credential      -auth $auth
-artifactUrl $artifactUrl      -includeTestToolkit
-includePerformanceToolkit      -licenseFile $licenseFile
-updateHosts       -additionalParameters @('--expose 7086')
This should be able to help you get rid of the issue temporary.

@gggdttt,
i tried it with a fresh container exposing port 7086 (my older ones didn't expose this port).
Same like before - as Christian said

Thanks for testing.  Looks like it is necessary to update the vsix. Our release pipeline is freeze for holiday. I shall release a new version of vsix asap. (Around the beginning of Jan).


fix: react-native 0.76 build android

This fixes a react-native 0.76 build error on android.

nice! thx

Confirmed this works for me. Although there's a whole dance you have to do for local testing of this react native package (maybe this is more familiar to regular react native devs).
Clone this repo (I used shallow because tensorflow cloning as a submodule is extremely slow).
git clone --depth 1 --single-branch --recurse-submodules --shallow-submodules https://github.com/mrousavy/react-native-fast-tflite react-native-fast-tflite

Set up the local package. Make sure to use npm install --production or else a second react instance is installed and breaks rendering.
cd react-native-fast-tflite/
npm install --production
npm prepack
npm link
cd ..
npm link react-native-fast-tflite

I wonder if the local dev flow is worth documenting anywhere.


Configure remaining AWS resources without testing

What problem are you facing?
We will have contractors coming on board to increase coverage. Currently, we configure & test the resources but configuration requires some knowledge of Upjet and Crossplane that may be hard to get them used to, i.e. we may end up spending same amount of effort reviewing their configuration vs configuring on our own.
This ticket contains remaining resources till tf provider v 4.51.0
How could Official Providers help solve your problem?
Let's configure the remaining resources (158 CRDs) without testing and leave only the testing part to them. The exact set of API groups this issue targets will be listed below.

accessanalyzer

[ ] aws_accessanalyzer_archive_rule

acmpca

[ ] aws_acmpca_permission
[ ] aws_acmpca_policy

alb_listener

[ ] aws_alb_listener_certificate
[ ] aws_alb_listener_rule

appconfig

[ ] aws_appconfig_extension
[ ] aws_appconfig_extension_association

applicationinsights

[ ] aws_applicationinsights_application

apprunner

[ ] aws_apprunner_observability_configuration
[ ] aws_apprunner_vpc_ingress_connection

appsync

[ ] aws_appsync_type

auditmanager

[ ] aws_auditmanager_account_registration
[ ] aws_auditmanager_assessment
[ ] aws_auditmanager_assessment_report
[ ] aws_auditmanager_control
[ ] aws_auditmanager_framework

ce

[ ] aws_ce_anomaly_monitor
[ ] aws_ce_anomaly_subscription
[ ] aws_ce_cost_allocation_tag

cloudfront

[ ] aws_cloudfront_origin_access_control

cloudwatch

[ ] aws_cloudwatch_log_data_protection_policy

codepipeline

[ ] aws_codepipeline_custom_action_type

cognito

[ ] aws_cognito_risk_configuration

comprehend

[ ] aws_comprehend_document_classifier
[ ] aws_comprehend_entity_recognizer

connect

[ ] aws_connect_instance_storage_config
[ ] aws_connect_phone_number
[ ] aws_connect_user
[ ] aws_connect_vocabulary

controltower

[ ] aws_controltower_control

datasync

[ ] aws_datasync_location_object_storage

directory_service

[ ] aws_directory_service_radius_settings
[ ] aws_directory_service_region
[ ] aws_directory_service_shared_directory
[ ] aws_directory_service_shared_directory_accepter

dms

[ ] aws_dms_s3_endpoint

dx

[ ] aws_dx_macsec_key_association

dynamodb

[ ] aws_dynamodb_table_replica

ec2

[ ] aws_ec2_instance_state
[ ] aws_ec2_network_insights_analysis
[ ] aws_ec2_transit_gateway_policy_table
[ ] aws_ec2_transit_gateway_policy_table_association

efs

[ ] aws_efs_replication_configuration

emrserverless

[ ] aws_emrserverless_application

evidently

[ ] aws_evidently_feature
[ ] aws_evidently_project
[ ] aws_evidently_segment

fis

[ ] aws_fis_experiment_template

fsx

[ ] aws_fsx_file_cache

glue

[ ] aws_glue_schema

grafana

[ ] aws_grafana_workspace_api_key

identitystore

[ ] aws_identitystore_group
[ ] aws_identitystore_group_membership
[ ] aws_identitystore_user

inspector2

[ ] aws_inspector2_delegated_admin_account
[ ] aws_inspector2_enabler
[ ] aws_inspector2_organization_configuration

ivs

[ ] aws_ivs_channel
[ ] aws_ivs_playback_key_pair
[ ] aws_ivs_recording_configuration

ivschat

[ ] aws_ivschat_logging_configuration
[ ] aws_ivschat_room

kendra

[ ] aws_kendra_data_source
[ ] aws_kendra_experience
[ ] aws_kendra_faq
[ ] aws_kendra_index
[ ] aws_kendra_query_suggestions_block_list
[ ] aws_kendra_thesaurus

kms

[ ] aws_kms_custom_key_store

lakeformation

[ ] aws_lakeformation_lf_tag
[ ] aws_lakeformation_resource_lf_tags

lightsail

[ ] aws_lightsail_bucket
[ ] aws_lightsail_certificate
[ ] aws_lightsail_container_service
[ ] aws_lightsail_container_service_deployment_version
[ ] aws_lightsail_database
[ ] aws_lightsail_disk
[ ] aws_lightsail_disk_attachment
[ ] aws_lightsail_domain_entry
[ ] aws_lightsail_lb
[ ] aws_lightsail_lb_attachment
[ ] aws_lightsail_lb_certificate
[ ] aws_lightsail_lb_certificate_attachment
[ ] aws_lightsail_lb_https_redirection_policy
[ ] aws_lightsail_lb_stickiness_policy

location

[ ] aws_location_geofence_collection
[ ] aws_location_place_index
[ ] aws_location_route_calculator
[ ] aws_location_tracker
[ ] aws_location_tracker_association

macie2

[ ] aws_macie2_classification_export_configuration

medialive

[ ] aws_medialive_channel
[ ] aws_medialive_input
[ ] aws_medialive_input_security_group
[ ] aws_medialive_multiplex
[ ] aws_medialive_multiplex_program

msk

[ ] aws_msk_serverless_cluster

neptune

[ ] aws_neptune_global_cluster

networkfirewall

[ ] aws_networkfirewall_firewall

networkmanager

[ ] aws_networkmanager_attachment_accepter
[ ] aws_networkmanager_connect_attachment
[ ] aws_networkmanager_core_network
[ ] aws_networkmanager_site_to_site_vpn_attachment
[ ] aws_networkmanager_transit_gateway_peering
[ ] aws_networkmanager_transit_gateway_route_table_attachment
[ ] aws_networkmanager_vpc_attachment

opensearch

[ ] aws_opensearch_inbound_connection_accepter
[ ] aws_opensearch_outbound_connection

rds

[ ] aws_rds_export_task
[ ] aws_rds_reserved_instance

redshift

[ ] aws_redshift_authentication_profile
[ ] aws_redshift_cluster_iam_roles
[ ] aws_redshift_endpoint_access
[ ] aws_redshift_endpoint_authorization
[ ] aws_redshift_hsm_client_certificate
[ ] aws_redshift_hsm_configuration
[ ] aws_redshift_partner
[ ] aws_redshift_usage_limit
[ ] aws_redshiftdata_statement
[ ] aws_redshiftserverless_endpoint_access
[ ] aws_redshiftserverless_namespace
[ ] aws_redshiftserverless_resource_policy
[ ] aws_redshiftserverless_snapshot
[ ] aws_redshiftserverless_usage_limit
[ ] aws_redshiftserverless_workgroup

resourceexplorer2

[ ] aws_resourceexplorer2_index
[ ] aws_resourceexplorer2_view

rolesanywhere

[ ] aws_rolesanywhere_profile
[ ] aws_rolesanywhere_trust_anchor

route53

[ ] aws_route53_resolver_config

rum

[ ] aws_rum_app_monitor
[ ] aws_rum_metrics_destination

s3

[ ] aws_s3control_storage_lens_configuration

sagemaker

[ ] aws_sagemaker_servicecatalog_portfolio_status
[ ] aws_sagemaker_space

scheduler

[ ] aws_scheduler_schedule
[ ] aws_scheduler_schedule_group

schemas

[ ] aws_schemas_registry_policy

sesv2

[ ] aws_sesv2_configuration_set
[ ] aws_sesv2_configuration_set_event_destination
[ ] aws_sesv2_dedicated_ip_assignment
[ ] aws_sesv2_dedicated_ip_pool
[ ] aws_sesv2_email_identity
[ ] aws_sesv2_email_identity_feedback_attributes
[ ] aws_sesv2_email_identity_mail_from_attributes

sqs

[ ] aws_sqs_queue_redrive_allow_policy
[ ] aws_sqs_queue_redrive_policy

ssm

[ ] aws_ssm_default_patch_baseline
[ ] aws_ssm_service_setting

ssoadmin

[ ] aws_ssoadmin_customer_managed_policy_attachment
[ ] aws_ssoadmin_instance_access_control_attributes
[ ] aws_ssoadmin_permissions_boundary_attachment

transcribe

[ ] aws_transcribe_language_model
[ ] aws_transcribe_medical_vocabulary
[ ] aws_transcribe_vocabulary
[ ] aws_transcribe_vocabulary_filter

transfer

[ ] aws_transfer_tag

vpc_network

[ ] aws_vpc_network_performance_metric_subscription

Configurations will be done in scope of tickets: #470, #471, #472, #473, #474

It seems that, the related tickets were done. Closing.


How to get the handle of the Avalonia control？

I would like to get Avalonia control handle, such as Canvas handle, I want to put it into the cpp dll for some processing, in WPF I can use:
IntPtr hwnd = ((HwndSource) PresentationSource.FromVisual (uielement)). Handle;
But in Avalonia how to get it?

((TopLevel)control.GetVisualRoot()).PlatformImpl.Handle.Handle.
GetVisualRoot is extension method from Avalonia.VisualTree namespace

((TopLevel)control.GetVisualRoot()).PlatformImpl.Handle.Handle works in window but failed
Error in centOS: Unable to cast object of type 'Avalonia.X11.X11Window' to type 'Avalonia.Win32.WindowImpl'

Why are you casting it to Avalonia.Win32.WindowImpl?

Thanks kekekeks, I have created a project of Avalonia app with one window (xaml) and assigned the handle of this window to get a stream from an IP camera in below code and it is working in windows OS and got the casting error in centOS.
//login to camera
IntPtr loginID = NETClient.Login("cameraIp", 25001, "username", "password",EM_LOGIN_SPAC_CAP_TYPE.TCP, IntPtr.Zero, ref deviceInfo);
if (loginID != IntPtr.Zero)
{
// get the handle of current current
var handle = this.PlatformImpl.Handle.Handle;
             //passing this handle to update live streaming of camera
                IntPtr realHandle = NETClient.StartRealPlay(loginID, 0, handle, 0, m_RealDataCallBack, m_RealPlayDisConnectCallBack, IntPtr.Zero, 3000);
                if (realHandle != IntPtr.Zero)
                {

                }
            }

var toplevel = (TopLevel)this.GetVisualRoot();

var platformImpl = (WindowImpl)toplevel.PlatformImpl;

var handle = platformImpl.Handle.Handle;

Methods above don't work for me.
((TopLevel)control.GetVisualRoot()).PlatformImpl.Handle.Handle
gives error:
'ITopLevelImpl' does not contain a definition for 'Handle'
This code:
var toplevel = (TopLevel)this.GetVisualRoot();
var platformImpl = (WindowImpl)toplevel.PlatformImpl;
var handle = platformImpl.Handle.Handle;

gives error:
The type or namespace name 'WindowImpl' could not be found
I replaced WindowImpl with IWindowImpl, it gives error:
'IWindowBaseImpl.Handle' is inaccessible due to its protection level

https://docs.avaloniaui.net/docs/next/stay-up-to-date/upgrade-from-0.10#windows


An error when passing one child to a component

// in a `render` method
const Component = ({ children }) => r.div(children);
return r(Component, [r.span('foo')]);

console:
Warning: Invalid value for prop `$$typeof` on
 tag.
Either remove it from the element, or pass a string or number value to keep it in the DOM.
For details, see https://fb.me/react-attribute-behavior

Warning: Prop `_owner` did not match. Server: "null" Client: "[object Object]"

Warning: Invalid attribute name: `$$typeof`

DOM:

Changing number of children to 0 or more than 1 fixes this:
// in a `render` method
const Component = ({ children }) => r.div(children);
return r(Component, [
  r.span('foo'),
  r.span('bar'),
]);

If you apply this (pretty sane) patch to tests, 4 tests will fail revealing the same exact problem.

diff --git a/test/fixtures/create-component.js b/test/fixtures/create-component.js
index c441d6c..a5958f9 100644
--- a/test/fixtures/create-component.js
+++ b/test/fixtures/create-component.js
@@ -1,7 +1,6 @@
 'use strict';
 var extend = require('xtend');
 var createReactClass = require('create-react-class');
-var DOM = require('react-dom-factories');

 var r = require('../../');

@@ -15,7 +14,7 @@ function createComponent(properties) {
           r.h1(this.props.title),
           // This tests that children are passed down correctly to
           // components that use React.DOM directly (and don't warn)
-          DOM.div(null, this.props.children)
+          r.div(this.props.children)
         ])
       );
     }

Wait, is this just how React works (passing single element as a children prop)? Will handling this be a worthy addition anyway?


CoxModel in R and Python Differences

This is a question on Cox survival model in R and python differences. In R we have option for passing start and stop for an event whereas in python(lifelines Package) I could find only duration data can be passed.So required the equivalent in python to include start and stop fields as well instead of durations. Any other package or method which takes into account start and stop duration in python.
-- | --

I believe this isn’t too hard to add to both the coxph model and the time varying model. Probably won’t make it into v13 however

Thanks for the update cameron...so you mean to say this feature will be
added in the next version or this time varying concept is already present
in the existing lifeline package
On 22 Dec 2017 10:43 pm, "Cameron Davidson-Pilon"<EMAIL_ADDRESS>wrote:

I believe this isn’t too hard to add to both the coxph model and the time
varying model. Probably won’t make it into v13 however
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CamDavidsonPilon/lifelines/issues/376#issuecomment-353639563,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhKi7y2dYBesZPOvVOb6V1u0j0hP6zibks5tC-MpgaJpZM4RLO3W
.

V13 comes out shortly (which introduces cox time varying), so this request is more likely to come out in v14.

Thanks for the update cameron..So just want to know if there are any other
python packages  available as of now to handle this requirement.
Regards
Sandeep
On 22 Dec 2017 11:55 pm, "Cameron Davidson-Pilon"<EMAIL_ADDRESS>wrote:

V13 comes out shortly (which introduces cox time varying), so this request
is more likely to come out in v14.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/CamDavidsonPilon/lifelines/issues/376#issuecomment-353651426,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhKi7xp8p_2oUfTyXQP9l84sinPgOOuIks5tC_QHgaJpZM4RLO3W
.


Changes to support mPower2 ResearchStack Surveys

Depends on https://github.com/ResearchStack/ResearchStack/pull/485

@liujoshua fixed tests and ready to merge


Why am I being prompted to download the model even though I have already downloaded it?

I am unable to connect to huggingface.co. As a result, I have downloaded the complete model library in advance, including all model files, such as "small". I tried placing the downloaded model files in the "v1" directory of C:\Users\foo\AppData\Roaming\gabotechs\musicgptr, but when I execute the command, it still prompts me to download the model.
Here's the command I'm using:
F:\x86_64-pc-windows-msvc\x86_64-pc-windows-msvc> musicgpt.exe --model small
And here's the output:
[2024-11-21 07:43:48.596] INFO Some AI models need to be downloaded, this only needs to be done once
[2024-11-21 07:43:56.647] ERROR error sending request for url (https://huggingface.co/gabotechs/music_gen/resolve/main/small/config.json)

The directory structure is as follows:
C:\Users\foo\AppData\Roaming\gabotechs>tree /f

C:.
└─musicgpt
    └─v1
        ├─small
        │      config.json
        │      generation_config.json
        │      preprocessor_config.json
        │      special_tokens_map.json
        │      spiece.model
        │      tokenizer.json
        │      tokenizer_config.json
        │
        ├─small_fp16
        │      decoder_model.onnx
        │      decoder_with_past_model.onnx
        │      encodec_decode.onnx
        │      text_encoder.onnx
        │
        ├─small_fp32
        │      build_delay_pattern_mask.onnx
        │      decoder_model.onnx
        │      decoder_model_merged.onnx
        │      decoder_with_past_model.onnx
        │      encodec_decode.onnx
        │      text_encoder.onnx
        │
        └─small_i8
                decoder_model.onnx
                decoder_model_merged.onnx
                decoder_with_past_model.onnx

I am unable to connect to huggingface.co. As a result, I have downloaded the complete model library in advance, including all model files, such as "small". I tried placing the downloaded model files in the "v1" directory of C:\Users\foo\AppData\Roaming\gabotechs\musicgptr, but when I execute the command, it still prompts me to download the model.
Here's the command I'm using:
F:\x86_64-pc-windows-msvc\x86_64-pc-windows-msvc> musicgpt.exe --model small
And here's the output:
[2024-11-21 07:43:48.596] INFO Some AI models need to be downloaded, this only needs to be done once
[2024-11-21 07:43:56.647] ERROR error sending request for url (https://huggingface.co/gabotechs/music_gen/resolve/main/small/config.json)

The directory structure is as follows:
C:\Users\foo\AppData\Roaming\gabotechs>tree /f

C:.
└─musicgpt
    └─v1
        ├─small
        │      config.json
        │      generation_config.json
        │      preprocessor_config.json
        │      special_tokens_map.json
        │      spiece.model
        │      tokenizer.json
        │      tokenizer_config.json
        │
        ├─small_fp16
        │      decoder_model.onnx
        │      decoder_with_past_model.onnx
        │      encodec_decode.onnx
        │      text_encoder.onnx
        │
        ├─small_fp32
        │      build_delay_pattern_mask.onnx
        │      decoder_model.onnx
        │      decoder_model_merged.onnx
        │      decoder_with_past_model.onnx
        │      encodec_decode.onnx
        │      text_encoder.onnx
        │
        └─small_i8
                decoder_model.onnx
                decoder_model_merged.onnx
                decoder_with_past_model.onnx

same problem。。。


Prevent confd from running every 5 minutes

Confd is currently configured to run constantly, resetting changes each 5 minutes.
There is a 'onetime' flag that can be appended to the command line to ensure it only runs once and dies.
According to the 'base' image, it is running continuously on boot:
https://github.com/jhu-idc/idc-isle-buildkit/blob/main/base/rootfs/etc/services.d/confd/run

Addressed by #43


Optimize maps images

This PR includes optimisation of all the maps through svgo. This brings the size of the maps directory down from 4,35 GB to 1,54 GB, a saving of 2,81 GB or roughly two thirds. It's still a lot of space so it could be worth to check for unused files and delete them from the repository, as it would make checking out the repository much faster.

Gathering all of the maps was a bit of a pain; I’m leaving the dataset complete with unused assets as all tools for downloading Wikimedia files are currently broken.
If somebody needs all of the 16:9 maps from Wikipedia, they can do so from here.


How do I return a 404 Not Found error from a Python file?

I've made a Python API file for fetching a resource. If the resource doesn't exist, I want to return "404 Not Found". I have tried Flask's abort(404), but the NotFound error is caught at some point and I get a TypeError instead, resulting in a 500 Server Error from Zero. Here is the stack trace:

werkzeug.exceptions.NotFound: 404 Not Found: The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.
[2020-06-05 20:40:01,549] ERROR in app: Exception on /video/foobar/ [GET]
Traceback (most recent call last):
  File "/home/tomas/.local/lib/python3.8/site-packages/flask/app.py", line 2446, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/tomas/.local/lib/python3.8/site-packages/flask/app.py", line 1952, in full_dispatch_request
    return self.finalize_request(rv)
  File "/home/tomas/.local/lib/python3.8/site-packages/flask/app.py", line 1967, in finalize_request
    response = self.make_response(rv)
  File "/home/tomas/.local/lib/python3.8/site-packages/flask/app.py", line 2096, in make_response
    raise TypeError(
TypeError: The view function did not return a valid response. The function either returned None or ended without a return statement.

Is this a bug? Or is there a different way to do it?

And as usual, I finally figured it out myself right after posting the question:
from flask import make_response

def handler(name):
    if not VIDEO_PATH.joinpath(name).exists():
        return make_response("", 404)

    # ...

I still think abort(404) should work though, so I'll keep this open as a feature request / bug report.


I am curious what is the point of these lines?

https://github.com/webpack/tapable/blob/ffc660840d2814b00a3e5e00cecb09519136bd37/lib/Hook.js#L41
this.compile = this.compile;
this.tap = this.tap;
this.tapAsync = this.tapAsync;
this.tapPromise = this.tapPromise;

I am not very good at OOP and don't know its patterns, but it looks a bit redundant for me.

It is apparently

These lines are important for performance reasons. We later reassign these properties. To avoid keeping the v8 Hidden Map from changing during the lifecycle of the class we assign these properties in the constructor to initialize the Hidden Map correctly.

Oh, makes sense now, thanks for the clarification!


echo without newline to hash password

Otherwise the input to sha256sum will include the newline character

Ah, didn't realize this was fixed in master!


Question: Kotlin Interopability

It would be great to have this library follow the Kotlin Interoperability Guide.
I would love to submit a PR to fix any of these interoperability issues in this library, in the downstream gapic-generator, and also in the apiary client.
Of course maintaining Backwards Compatibility will be key, and if there's a situation where breaking BC is required, we'll handle those case-by-case.
Thoughts?

This would be non-trivial work for current libraries. We always welcome PRs but I'll let @garrettjonesgoogle decide whether we can do this at this moment.


Performance issue

Hi,
In case I have ~200 events, the calendar renders in about 10 seconds in month view.
Could it be improved?
I don't see any reason to this, since not all the events are displayed.

This is an example of 200 events within 15 days https://codesandbox.io/s/186-wkprs3
It take ~2s in my case, but I guess this definitely could be improved

Hi,
After upgrading I cannot see all of the events on month view.

Right, not sure why I was looking into a hack rather than dig into the real issue.
Try the next release 2.7.12. Here a sandbox for 400 events per month https://codesandbox.io/s/186-wkprs3
Month view now seems more smooth than week/day views. I believe the week/day views also could benefits from similar enhancment, I will do that soon hopefully

Looking smooth now, thanks great job!


[stable/influxdb] PR for adding optional support of enterprise

@jackzampolin
@aisuko
Would you be interested in a PR for adding in support for InfluxDB Enterprise and replications, perhaps building off of #17619?
Is your feature request related to a problem? Please describe.
I plan on writing a chart for this anyways, so it would likely make sense to build off of the existing chart, and be able to contribute it back.
Describe the solution you'd like
Adding in conditional support for meta servers, license configmap, and replication (probably other things)
Describe alternatives you've considered
Making a chart based on https://docs.influxdata.com/enterprise_influxdb/v1.7/install-and-deploy/production_installation/meta_node_installation/

You are welcome. Feel free to make the PR.

@Aisuko #19625 for your consideration


Integrating JPA and Guice

Hello
First of all, great work and congrats for the 1.0.0 release :+1:
I would like to integrate JPA (I know there any many more Kotlin friendly solutions) with Guice. Using the solution provided as https://github.com/google/guice/wiki/JPA, it was super easy to integrate it into Javalin.
Only problem is to resolve session per http request as described here https://github.com/google/guice/wiki/JPA#web-environments-session-per-http-request. How to integrate/change this to work with Javalin? Checking around I noticed https://github.com/rodolfodpk/spark-guice/blob/master/src/main/java/spark/servlet/SparkGuiceFilter.java which is for spark. Could this be changed to work with Javalin?
Any tips how to resolve this would be super useful.

Hi @FrEaKmAn. TheSparkGuiceFilter looks very foreign from Javalin, so I'm not sure it's much help. When you say you need to resolve the session per HTTP-request, what do you mean? You can get the session for any http-request by doing before { ctx -> ctx.request().session }, but maybe that's not enough?

Hello @tipsy. Maybe I express myself incorrectly regarding session. The idea is unit of work that needs to execute for each request
https://github.com/google/guice/blob/master/extensions/persist/src/com/google/inject/persist/PersistFilter.java#L92
I know Javalin supports before and after. Maybe this could work?
before { ctx -> unitOfWork.begin() }
after { ctx -> unitOfWork.end() }


NIFI-14077 Add ProcessGroup Performance Metrics to Prometheus

Summary
NIFI-14077

Add ProcessGroup Performance Metrics to Prometheus if performance metric collection is available
Add total task duration metric to each process group, not just the root process group
Add allowable values to the API docs for the producer and includedRegistries parameters so users know what there is to query without going to the source code.

Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[x] Apache NiFi Jira issue created

Pull Request Tracking

[x] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[x] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[x] Pull Request based on current revision of the main branch
[x] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[x] Build completed using mvn clean install -P contrib-check

[x] JDK 21

Licensing
(no new deps)

[x] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[x] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[x] Documentation formatting appears as expected in rendered files

I suspect the macos system test is flakey so I am rerunning it on my fork https://github.com/esecules/nifi/actions/runs/12285436758?pr=3

I suspect the macos system test is flakey so I am rerunning it on my fork https://github.com/esecules/nifi/actions/runs/12285436758?pr=3
EDIT: The run passed on my fork hopefully it does the same below (thanks for the speedy retry @exceptionfactory!)

You're welcome, I have recently noticed a couple flaky tests in the system-tests workflow.

Looks like the retry failed still 😔, however it's passing in my fork and my machine (MacBook).
Do these tests run in parallel and might interfere with each other?
Or the tests might be running on an underpowered server and the 60 second timeout isn't sufficient for GitHub Actions?

Looks like system tests passed on retry! Thanks for all the retries.


fix build in apps with no-srtp

srtp_profiles variable is defined when building with SRTP, keeping
the variable usage also under ifndef OPENSSL_NO_SRTP
alpn help option was kept under ifndef OPENSSL_NO_SRTP

+1

I guess I forgot to actually say +1

pushed, thanks.


Swift Package Manager issue

Hi, I'd love to use the library via SPM but I get the following error:
"The package dependency graph can not be resolved; unable find any available tag for the following requirements"
I tried in a fresh Xcode Project and got the same. Any ideas?
PS: Congrats on the great library 💯

Closed by #18, thanks for the report!


Path to On-Premises Azure DevOps Server 2019 -

At this location on the page:
https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/v2-windows?view=azure-devops-2019#authenticate-with-a-personal-access-token-pat
The path listed in "Step 1" for an on-premises path to create a Personal Access Token is listed as:
https://{your-server}:8080/tfs/
This URL will not work With Azure DevOps Server 2019 (I chose "Azure DevOps Server 2019" at the top left of the navigation menu to filter on this product).
It appears that almost any URL pointing to your on-premises Azure DevOps Server 2019 WILL work, but the path described in "Step 1" for on-premises (I'm assuming) is for older versions of TFS, not DevOps Server 2019. It seems one just needs to be able to access their "Profile" in the upper right-hand corner, which is easily accessible from many paths when on-premises, and would be available from the home page.
Could this URL for Azure DevOps Server 2019 be re-defined as:
https://{your-server}/DefaultHomePage
I am new to Azure DevOps Server 2019; I do not even know the default home page. I'm even new to the markdown procedures used in giving feedback on GitHub, so I ask for your patience in my description.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 43799c5d-2f13-cc76-a1c0-a3f850e16d4e
Version Independent ID: 97a5b73f-faf7-f9c0-9269-fc79984616d6
Content: Deploy a build and release agent on Windows - Azure Pipelines
Content Source: docs/pipelines/agents/v2-windows.md
Product: devops
Technology: devops-cicd
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Currently facing the exact same issue, trying to self host agent on locally deployed azure devops...

nvm, it wanted the complete url with the "collection" i create. once i put the collection in the path  as in

http://url:port/[collection-name]

it worked just fine

I'm also facing the same issue as @kkarakk.
Enter server URL > http://localhost/Collection
Enter authentication type (press enter for Integrated) > PAT
Enter personal access token > ****************************************************
Basic authentication requires a secure connection to the server.
Failed to connect.  Try again or ctrl-c to quit


Remove trailing slash from pagination links

Fixes #8231. The htaccess by default redirects trailing slashes which conflicts with the pagination links rendering everything with trailing slashes.
Note -- this is how links was in 4.2

Please send to 5.1. This is breaking.

@GrahamCampbell cheers. Before I do, I notice in Laravel 5 that it will routes with trailing slashes work. The trailing htaccess redirect has been around since day dot, is it even needed anymore? Just wondering what would be best/most likely accepted by Taylor...this PR or one for redirecting the trailing slash in htaccess?

This has been discussed before. Not why we didn't do anything. Ping @taylorotwell.


[Enhancement] Add Solution for KCL binaries downloaded from Github release pages on the macos operating system without permission.

Enhancement

Closed by 4d3ed863e40df72bd3bc01f56a70d3afc146930f


Make it compatible with never server

Fixes #1

I couldn't actually get this one to work! I've merged a subset of the changes into master now. #1 is still open pending test reports. Thanks for the PR!


Add specific OpenFin and Electron tests

It would be nice to be able to add a tag so that a test only runs for OpenFin or open runs for Electron.

There is already an environment variable set when running the tests - MOCHA_CONTAINER - which could be conditionally used to run tests. E.g.:
if (process.env.MOCHA_CONTAINER === 'electron') {
  it('should test something only in Electron', function() {
    // test
  });
}

I'm not sure how this might affect the test report though.


Fix invalid command GUI

Fixed the invalid command GUI. Now when User types in a invalid command, it is cleared and it outputs the command and indicates that it is invalid command

Can try to enable trailing whitespaces check and eof line break check inside IntelliJ.

Codecov Report

Merging #66 (994a12c) into master (91c5944) will increase coverage by 0.97%.
The diff coverage is 82.88%.

@@             Coverage Diff              @@
##             master      #66      +/-   ##
============================================
+ Coverage     72.15%   73.12%   +0.97%
- Complexity      399      426      +27
============================================
  Files            70       72       +2
  Lines          1232     1310      +78
  Branches        125      138      +13
============================================
+ Hits            889      958      +69
- Misses          311      316       +5
- Partials         32       36       +4

Impacted Files
Coverage Δ

src/main/java/coydir/MainApp.java
0.00% <0.00%> (ø)

src/main/java/coydir/commons/core/LogsCenter.java
78.37% <ø> (ø)

src/main/java/coydir/commons/core/Messages.java
0.00% <ø> (ø)

...rc/main/java/coydir/logic/commands/AddCommand.java
100.00% <ø> (ø)

src/main/java/coydir/model/person/Address.java
80.00% <ø> (ø)

...rc/main/java/coydir/model/util/SampleDataUtil.java
20.00% <0.00%> (ø)

src/main/java/coydir/ui/CommandBox.java
0.00% <0.00%> (ø)

src/main/java/coydir/ui/HelpWindow.java
0.00% <ø> (ø)

src/main/java/coydir/ui/PersonCard.java
0.00% <0.00%> (ø)

src/main/java/coydir/model/person/Position.java
80.00% <80.00%> (ø)

... and 12 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Error signing the specified account

I imported the app to Android studio and executed in my mobile. But I am getting "Error signing into specified account" when I try to do any operation. But there is no issue with my credentials, can you please help me to solve this issue?.

This error definitely indicates a problem with your credentials.  Try this

@madankb are you still having issues getting this sample to work?

Closing, please create new issue if it still exists.


[WIP] Vault Volume Driver Support

Add --save-on-attach CLI option so that save method can be called when updating Device string from volume driver return type.

LGTM


Updated example to have comment about libraries

@Dignifiedquire
Pull request for karma-runner/karma#1445

Thanks


feat: add CTA (Contact PM) to group about template

This PR introduces the following changes:

adds a CtaCard to GroupProfileAbout template
checks whether there's a Group as one or more leaders with the role "Project Manager", and if there's any show the Call to Action, providing the PM's email to the mailTo link
changes the signature of the createMailTo function, allowing for a single email (string) or a list of emails to be passed
extracts two functions from the above function, to create both a URL to a single email or a list of emails

Seeing as this has been in review for quite a while and there were still open points, I addressed the remaining points. I agree the implementation was excessively complicated for what could have been a plain join. The tests were mostly good though :+1: I also added a knob in Storybook to be able to preview the two different states


Add Discrete-Log Problem challenge in exercises

sure, on it

made the required changes, and added another exercise, please have a look, thank you


Node 20 is now deprecated

Hey @bigdaz, would it be possible to release v2 version with Node 20?
Right now we have to choose between using beta action or using an unsupported Node.

Changing to run with Node 20 is a breaking change, and so we won't update 2.x to use Node 20.
You can expect to see a v3.0.0 release that supports Node 20 in the next couple of weeks.

This is already fixed on the main branch.

Makes sense, thanks!


UI discrepancy between UIKit and SwiftUI

What area is the issue related to?
Checkout Sheet Kit
What version of Checkout Sheet Kit are you using?
2.0.1
Do you have a minimum reproducible example?
No response
Steps to Reproduce

Display sheet via Swift UI
Display sheet via UIKit
Compare navigation bars

Expected Behavior
Navigation bar on UIKit sheet to filled in on presentation, not just when the checkout scrolls down.
Actual Behavior
UIKit sheet displays a clear navigation bar on presentation which looks off. When you scroll down the on the UIKit sheet the navigation bar fills in. This feels a buggy and looks off which is not desired in a checkout flow.
Screenshots/Videos/Log output

Swift UI on present (looks good)

UIKit on present (looks off)

Storefront domain
No response

Thanks @joshgare. I'm updating our sample app in this PR to include an example of this flow. Would you say that the code here is similar to what you're doing?
The background color of the checkout sheet should be set to .systemBackground by default. Are you overriding the configuration at all?
You can explicitly set this in your application:
ShopifyCheckoutSheetKit.configure {
    $0.backgroundColor = .white
}

@markmur just coming back to this - we updated the SDK to 3.0.1 and added the following.
ShopifyCheckoutSheetKit.configure {
    $0.backgroundColor = .white
}

However we're still seeing the UI issue when presenting the modal via UIKit.
https://github.com/Shopify/checkout-sheet-kit-swift/assets/113687/cf81dc8b-3d7d-48b0-a8db-8ae8ed669895


Fixing SLURM environment parsing

This patch fixes parsing of the slurm environment in the presence of running
different SLURM steps with different number of tasks and nodes.

IIUC, there are situations where the SLURM_STEP_... are not set (depending whether salloc or srun have been used, possibly other criteria..., see here). I think we should always check the SLURM_... env variables if the SLURM_STEP_... variable is not set.

Am 11.09.2017 5:28 nachm. schrieb "Hartmut Kaiser"<EMAIL_ADDRESS>
:

IIUC, there are situations where the SLURM_STEP_... are not set (depending
whether salloc or srun have been used, possibly other criteria..., see here
https://groups.google.com/forum/#!topic/slurm-devel/3tLPgShGM9A). I think
we should always check the SLURM_... env variables if the SLURM_STEP_...
variable is not set.
On the slurm installations I checked, they are both set. The post you
linked to concerns the SLURM_JOB variables, which seem to be the same as
the ones without _JOB.
http://rostam.cct.lsu.edu/builders/hpx_gcc_7_boost_1_65_centos_x86_64_debug/builds/19
Shows that the assertion which was a symptom of the bug seems to be gone.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/STEllAR-GROUP/hpx/pull/2895#issuecomment-328565680,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADRl3m-J-2K9qawm1pR96WZuiEDP3hXks5shVGAgaJpZM4PTMXb
.

IIUC, there are situations where the SLURM_STEP_... are not set (depending whether salloc
or srun have been used, possibly other criteria..., see here). I think we should always check
the SLURM_... env variables if the SLURM_STEP_... variable is not set.

On the slurm installations I checked, they are both set. The post you
linked to concerns the SLURM_JOB variables, which seem to be the same as
the ones without _JOB.
The link is related to the _JOB_ variables, yes - but if you read it you'll see that for the same job the _STEP_ variables are not always present depending on the way things are run.
Would it be a problem to play it safe and to allow for a fallback in case the _STEP_ variables are not present?

http://rostam.cct.lsu.edu/builders/hpx_gcc_7_boost_1_65_centos_x86_64_debug/builds/19
Shows that the assertion which was a symptom of the bug seems to be gone.

I don't doubt that for our setup things work now. Other environments may still break.

No, shouldn't be a problem to add it as fallback to be on the safe side.

Am 11.09.2017 6:49 nachm. schrieb "Thomas Heller"<EMAIL_ADDRESS>No, shouldn't be a problem to add it as fallback to be on the safe side.
Reading through the post again I think what we have now is correct. The
occasions where there is no _STEP_ variable set is when you have an
allocation, but not actually started the actual parallel application. I
think what's missing is the detection of that case and a proper diagnostic
and single locality fallback.

I just checked the SLURM environments I have access to again. Having the fallback as you suggested would lead to similar failures. The PR is correct as is.


tsc --types does not support passing no types

TypeScript Version:  2.5.2
Code
$ touch ./test.ts
$ tsc ./test.ts --types
error TS6044: Compiler option 'types' expects an argument.
$ tsc ./test.ts --types=
error TS5023: Unknown compiler option '--types='.
$ tsc ./test.ts --types ""
error TS6044: Compiler option 'types' expects an argument.
$ tsc ./test.ts --types=[]
error TS5023: Unknown compiler option '--types=[]'.
$ tsc ./test.ts --types="[]"
error TS5023: Unknown compiler option '--types=[]'.
$ tsc ./test.ts --types
error TS6044: Compiler option 'types' expects an argument.
$ tsc ./test.ts --types []
error TS2688: Cannot find type definition file for '[]'.
$ tsc ./test.ts --types ,
error TS2688: Cannot find type definition file for ''.

Expected behavior:
I'm not sure of the exact syntax and no one seems to have done this online, but it should be possible to pass no types to the compiler without using tsconfig.json.
This matters because, as discussed in #11917, the default TypeScript 2.x behavior is to include everything in /node_modules/@types as typings, and this is undesirable behavior for a project of any meaningful size.
Actual behavior:
The compiler fails when passed --types with no arguments. I assume that it also fails with empty --lib, --typeRoots, and --rootDirs.
(Surprisingly, the last command above actually spits out a .js file, but it fails harder on a nontrivial codebase.)
This matters to me because I'm using grunt-ts which only supports the --types flag through specifying an additionalFlags string (edit: looks like it has undocumented support for types but it results in the same error TS6044: Compiler option 'types' expects an argument. error since the config just builds a string that gets executed on the command line.)

this a limitation in our commandline parser. it should however work if you have another argument after it. e.g. tsc --types --pretty.


Increase timout for waiting for deployment and pods

Description
Waiting for the Deployment is sometimes timing out even though there is no error, so it is just slower.
How Has This Been Tested?
Local cluster (where the current timeout was enough), PR check will also test it on OpenShift CI infrastructure.
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/retest

/retest

/retest

/test all

/test all


[State Sync] Prevent potential OOM attack and avoid redundant computation

Motivation
Note: this PR is based on: https://github.com/diem/diem/pull/8043. As such, only the last 2 commits are new. I'll rebase once https://github.com/diem/diem/pull/8043 has landed.
This PR makes 2 improvements to state sync. These improvements target security, performance and code clarity.

(Security, Performance and Code Clarity) Currently, state sync maintains a map of connected peers. Whenever a peer is disconnected, state sync simply marks the peer as alive = false, but keeps it in the map. This is redundant because state sync never uses these peers. Moreover, it causes two bad behaviours: (i) redundant computation when having to iterate through the map to filter for alive = true peers; and (ii) a bad actor may target this map as a way to perform a DOS or slow down attack (e.g., by connecting and disconnecting peers with random keys to cause an OOM error). Instead, disconnected peers should just be removed from the map. This simplifies the code. @gregnazario, should we (or I?) follow this PR up with a fix for mempool, too? As discussed, it seems like the same issue exists there: https://github.com/diem/diem/blob/76c8fba3a34bdea8779a1ec10f38a0600d40af09/mempool/src/shared_mempool/peer_manager.rs#L186
(Performance and Code Clarity) Currently, state sync maintains two maps for connected peers and their scores: (i) peers_and_scores, holds all peers and their respective scores; and (ii) eligible_peers, which holds all peers grouped by network level with weighted score indices. This is redundant: eligible_peers is calculated purely from peers_and_scores and doesn't need to be stored globally. Moreover, eligible_peers is also re-calculated every time a score is updated (e.g., on various chunk responses). This results in redundant computation. Instead, it only needs to be updated before sending a new set of chunk requests. This should help reduce response processing time and CPU usage.

Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
All tests pass.
Related PRs
This relates to: https://github.com/diem/diem/issues/6795

well, I dunno what the dos is here, but the fact that there is no gc is a bit concerning... and for that alone I'm inclined to support this...

Well, like you say, no garbage collection means someone could fill up these maps. @gregnazario pointed out that this is trivial if someone (e.g., a compromised VFN) keeps reconnecting with different keys.

I think the intent here was that a peer should have a (semi-)persistent score despite a connectivity issue. I think the reality is that this is basically useless in our current environment and would be better suited by an overlay.

Yeah, I saw that, too. But like you said, it doesn't really apply right now. So let's strip it out to keep things simple.

I noticed you bumped the logs on this from debug to info, will this result in spam?

This shouldn't. As I said above, this PR is based on https://github.com/diem/diem/pull/8043. The only logs we changed were important but infrequent logs (in the normal case). In the malicious case of a compromised node reconnecting with new connections, it'll log a single line per connect, but this shouldn't spam the logs too much because connections are rate limited. Moreover, it makes things a lot easier to debug, so the trade-off is probably worth it.

/canary

:boom: Tests timed-out

/canary

:sunny: Canary successful

Thanks @davidiw, @gregnazario 😄
/land


Server crashes when specific player who created the world goes offline.

crash-2022-08-26_19.27.53-server.txt
crash-2022-08-27_01.42.54-server.txt
crash-2022-08-27_18.52.48-server.txt
crash-2022-08-28_04.56.38-server.txt
MedievalMC 1.18.2 modpack + playerex + relicex + create - apotheos. PlayerEx was added to the world after it was played for a while in single player, then world got exported to the server.
Now each time player that created the world leaves the server, server goes offline. Issue does not happen for any other player.
I guess I could just wipe that player's data files, but I'd prefer not to as that character is a level 60 dwarf.

Hi there,
This is a duplicate of #1. Although you may not be triggering the crash through the same initial mechanism, the result is the same and the fix will also be the same. It is being worked on; for now, please see here.
Thanks.


UI Problem Trying to Remove a Permitted Number From the Permitted List

Ok, running the very latest here...
I have a number that got added to the permitted list after the caller pressed zero and called back. At that time, there was no name in the caller id - it showed the number as the name as well. And the same number has called back perhaps 10 times.
I went to give that number/caller a "real" name. Rather than search the permitted list from that page, I simply clicked on the number in the main dashboard page. From there I clicked Change and then I clicked Remove from Permitted List since there was no way, it seemed, to update the Name at that point. I was going to re-add to the permitted list with the correct name after the Remove was complete.
Sadly, doing the Remove somehow has caused a problem. I have clicked it several times now and perhaps that contributed. But I end up, after clicking Remove, with the UI not changing at all to reflect the Remove. It usually allows me to re-add immediately. And if I go back to the Dashboard main page and come in again, everything looks/acts the same.
But I have looked in the database white list and the number is no longer in there at all. So at some point, the DB got cleaned. It is not in the black list. But it is in the call log 10 times.
I decided to try something similar with a call that was previously blocked - by a regex pattern. From the dashboard, I click the number. On the Viewing Caller page, there is a button offering me to remove from the block list. And clicking that gets me the same result as above. Checking the DB the number is, of course, not in the block list. When a call is blocked by a regex, the number is not added to the blacklist, I think. The UI thinks that because it was blocked, there should be an entry in the block list DB. But there isn't one.
I know this is not quite the result I get above. But my theory is that my first Remove did actually perform the remove from the white list. Now the two cases are essentially the same. The UI thinks that because a call is permitted or blocked that there is a record in the white/black list. In this case, presenting the Remove from button confuses everything.
I hope I am being clear here.
Thanks
This seems to reveal an issue with the UI.

I noticed the record for the number in the 1st case above which was the very first time they called. It was screened in the call history. If I click the number in that THAT SPECIFIC row's number, I get shown this:

Note that there is both an add to permitted button AND an add to blocked button.
Seems to me that the add "makes sense" because this number is now no longer in the permitted or blocked lists after I deleted it earlier. But this is not the reason, I am sure, they is being offered. I think it is simply because the call was screened.

Your first comment indeed shows a UI problem being unable to differentiate between a caller on the PermitList and a caller permitted by "Permit Next Call" flag or a RegExp. I think there needs to be more than a simple change in the flow of the UI to allow correct behavior and displays. I think making it easier to change a caller NAME when changing the Permit/Block status of a caller needs to be done as well.
Your second comment shows the correct behavior and choices -- maybe the banner notice "This caller is ... " could be re-worded, but the operation wouldn't change. Again, allowing the NAME to be edited should be added.

I am sure that my meaning/message is here is not as clear as it should be. To summarize, it seems that the UI bases what it shows in terms of add/delete a number to/from permitted/blocked lists based upon the way a given call from that number was handled by CA's rules - found in the call log. I really think this makes no sense as the way a number is treated can/will vary over time. The ability to add/delete should, it seems to me, be governed by the following rules:

A given number logically cannot/should not be allowed in both permitted/blocked lists at the same time.
The UI's presentation of the button to add/delete should be based solely on the presence/absence of a number in a given list.
Subject to #1 above, if a number is in a list, it should offer the user to remove it. If it is NOT in a list, it should offer to add it.

Thanks and sorry for my rambling. It has taken some time to get this clear in my head.
Best and thanks for all.


PHMSA: fix to Part Q - fix the column names for the other materials (NOT MILES!)

Overview
This is an addendum to  #3280 which i learned i needed to do via @jdangerx  over in #3279
What problem does this address?
i previously labeled the fields where phmsa respondents are supposed to list other materials as _miles and generally didn't realize these were linked to the cram in the column labeled as "Other" w/ the lil footnote.
What did you change?
removed miles and standardized the column names so they are more mirrored w/ their brethren from the table above.
Testing
How did you make sure this worked? How can a reviewer verify this?
# To-do list
- [x] Make sure full ETL runs & `make pytest-integration-full` passes locally
- [ ] For major data coverage & analysis changes, [run data validation tests](https://catalystcoop-pudl.readthedocs.io/en/latest/dev/testing.html#data-validation)
- [ ] If updating analyses or data processing functions: make sure to update or write data validation tests
- [ ] Update the [release notes](../docs/release_notes.rst): reference the PR and related issues.
- [ ] Review the PR yourself and call out any questions or issues you have

he yes i just read ella's comment over there and was coming back to add _description. and yes these are all 192.619 because this table is broken out by the two regulation sections and only 192.619 has the "other" category.


Copied Protos from server

Copied proto files from server

Codecov Report
Base: 17.19% // Head: 84.94% // Increases project coverage by +67.74% :tada:

Coverage data is based on head (8e664e7) compared to base (0294220).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1106       +/-   ##
=============================================
+ Coverage     17.19%   84.94%   +67.74%
=============================================
  Files           278       59      -219
  Lines         44968     3089    -41879
  Branches       4693        0     -4693
=============================================
- Hits           7733     2624     -5109
+ Misses        36460      465    -35995
+ Partials        775        0      -775

Impacted Files
Coverage Δ

python/trinsic/trinsic_util.py
66.66% <0.00%> (-3.34%)
:arrow_down:

...rinsic/proto/services/trustregistry/v1/__init__.py
78.57% <0.00%> (-2.68%)
:arrow_down:

...thon/trinsic/proto/services/account/v1/__init__.py
79.51% <0.00%> (-2.59%)
:arrow_down:

...hon/trinsic/proto/services/provider/v1/__init__.py
78.57% <0.00%> (-2.44%)
:arrow_down:

...ces/verifiablecredentials/templates/v1/__init__.py
82.35% <0.00%> (-2.27%)
:arrow_down:

...roto/services/verifiablecredentials/v1/__init__.py
75.88% <0.00%> (-1.90%)
:arrow_down:

...nsic/proto/services/universalwallet/v1/__init__.py
72.91% <0.00%> (-1.60%)
:arrow_down:

python/trinsic/proto/sdk/options/v1/__init__.py
100.00% <0.00%> (ø)

python/trinsic/proto/services/options/__init__.py
0.00% <0.00%> (ø)

...n/trinsic/proto/trinsic/services/event/__init__.py
0.00% <0.00%> (ø)

... and 219 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Global time and directories

Test for https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/pull/899

pr this tests closed


Add ability to expire groups

Kapacitor has a similar issue to the InfluxDB TSI cardinality issue, where Kapacitor will remember tags forever. Kapacitor needs to ability to expire or remove tags, groups from the running tasks. This way the cardinality doesn't growth indefinitely in time.  See #610 for an initial implementation that will be to be reworked.

Instead of using the deadman, could use the barrier node. In this case, priority should be given to window nodes.


Does Steam Audio work in Unity Editor for ambisonic sounds?

I'm trying to get a simple ambisonic sound playing in Unity. I've followed the steps in the Getting Started guide but I can't seem to get ambisonics working at all in the editor (haven't tried a build yet--that's next). Does this plug-in work in the editor or is it expected that it doesn't?
It's also possible that the sound is playing ambisonic properly, but the effect is just difficult to notice. Can anyone recommend a source file that would make the effect very distinct--e.g. a distinct sound coming from only one direction?
Finally, I may be missing some settings. I've so far:

Set the Spatializer Plugin and Ambisonic Decoder Plugin to Steam Audio
Imported an AmbiX file and marked it as ambisonic
Attached the file to an Audio Source

Source is not marked Spatialize
Set Spatial Blend to full 3D

Beyond this I haven't changed any other settings. In particular I haven't added any of the Steam-specific components because from what I can tell the plugin should work without these.
If there are any other settings that might affect this please let me know!

I realize that the Spatial Blend is most likely supposed to be 2D for ambisonic? This un-3Ds the sound, but it still seems stuck to my head (I'm testing this in VR).

@ryan-motive - You are right. It should just work with the way you described it.
You can attach a Steam Audio Ambisonic Source component and toggle Apply HRTF to hear the difference. Reopen the issue if you still think you can't hear any difference or it is not what you expect. Also, please share Ambisonic file if possible in that case.

Ok can you please verify that attaching Steam Audio Ambisonic Source is required? I did not do that and the documentation makes it sound like it should work with a normal, unaltered audio source. This is an important distinction and I want to make sure I understand that this is a requirement because it will have an impact on how or if we decide to use this package.

It is not required. But you can attach and toggle Apply HRTF option to hear the spatialized and unspatialized Ambisonic audio. Let us know what you hear.


Flush STDERR when calling exit()

As of today only STDOUT is flushed, hence messages sent on STDERR may be
lost when calling exit(), which is a common pattern, for instance:
def usage
  STDERR.puts "Usage: #{PROGRAM_NAME} <args>"
  exit 1
end

In such a case chances are you won't see the error message in current
versions of crystal.

Thanks!


Naive merge of machine remediation code

There is scope to optimise the directory layout, but this should be enough to comment on

/hold
We're currently rethinking this plan to go with something simpler + implement the reboot functionality in the BaremetalHost straight away rather than start with a temporary implementation of that part here.

We are going to close the v1alpha1 branch in this repository, so I am closing open PRs that are no longer needed.
This PR has moved to https://github.com/openshift/cluster-api-provider-baremetal/pull/47 and a version will be brought up to the master branch in this repository later.


Port cc!records to v13

Given the command just works by calling cc!notes and cc!records, I don't think there's anything in that command itself that needs porting. That said, we should probably refactor this command (see quote from aedwardg below) but that's probably something that can wait until the v13 port is completed imo. More than happy to hear any other thoughts though!
From aedwardg:
As for the alternative way to fetch the infractions/notes, I think if multiple commands are going to use the same functionality then that functionality should live in its own module, which is designed to be reused and can be imported into the commands as necessary. This is a higher-level code structure preference, and I think it's fine to do it in a follow-up refactor PR. Your current solution works, and you did a great job keeping the code DRY, so let's just transition to the new name and then we can spec out a new issue for the modularization of the record fetching.

If cc!records works once the notes and infractions commands are done, I vote we save the refactoring for when we're changing the commands to slash commands.

cc!records now works as the underlying commands have been ported.


[nodejs] register_buffer() registers only first table

What happens?
register_buffer() function takes an ArrowIterable as argument for buffers to register. This implies that it's possible to register multiple of them under one table. However, when more than one is provided, only the first one is registered
To Reproduce
Example - following code outputs "3" rather than "6" as expected
import { tableFromArrays, tableToIPC } from 'apache-arrow';
import { Database } from 'duckdb';

const db = new Database(':memory:');
const sampleDataPart1 = tableFromArrays({
  a: [1, 2, 3],
});
const sampleDataPart2 = tableFromArrays({
  a: [4, 5, 6],
});

db.exec(` INSTALL arrow; LOAD arrow;`, (err) => {
  if (err) {
    throw err;
  }
  db.register_buffer(
    'sample_data',
    [tableToIPC(sampleDataPart1), tableToIPC(sampleDataPart2)],
    true,
    (err) => {
      if (err) {
        throw err;
      }
      db.all('select count(*) as total from sample_data', (err, res) => {
        if (err) {
          throw err;
        }
        console.log((res[0] as any).total);
      });
    }
  );
});

OS:
macos
DuckDB Version:
0.8.1
DuckDB Client:
NodeJS
Full Name:
Przemek Maciolek
Affiliation:
Motif Analytics
Have you tried this on the latest main branch?
I have tested with a main build
Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

[X] Yes, I have

I finally had the opportunity to spend some time on this issue myself. I originally thought that maybe it's something trivial to fix (like only the first array element is passed downstream) but realized that it's not the case. Finally, got into duckdb/arrow. Overall, found some interesting bits there, but maybe not directly related to this project (bringing these separately below)
TLDR, it looks like ArrowIterable must represent a single Arrow table. While all buffers are passed, after reading EOS no more batches seem to be added by the stream decoder. I think it's by design and changing it would be somewhat heavy. Perhaps two things should be changed then:

mention in the docs/API that ArrowIterable always represents a single Arrow Table
throw an exception when more batches after reading EOS

Side questions

While most of the projects refer to DuckDB core via git submodule, duckdb-node is using a tree copy.... Just wondering, is that a temporary thing?

It looks that arrow_scan_ipc.cpp is largely duplicating arrow.cpp in DuckDB core. I guess it might be an interim state, though if that's the case I wonder when this code is supposed to migrate?

Kind of a bummer for Node specifically, as this effectively means that there is a hard limit on the size of Arrow data that can be registered with DuckDB due to Node's limit on the max length of TypedArrays. So on a 64bit system the max size of Arrow data that Node DuckDB can work with is about 4GB. Anyone has found any workarounds for this?


use local serialization lib,  part-1

code-level reuse the serializer package from the apimachinery/serializer package.
the heavy meta data, such as multiple type, versioning conversion in the serializer package has been removed.

close this PR. new PR #107  has the changes


Phase change tested and working

Description of the problem

The phase change model was there, but it had never been used and never been tested. There was a bug in it that would make it blow up for constant temperatures
The Fluid dynamics physics was always solved for even when there is no fluid motion. This leads to matrix and rhs assembly that are not required

Description of the solution

Fix the bug by making the derivative of the enthalpy more robust
The multiphysics interface now always enables fluid dynamics, but if fluid dynamics is turned off, it's initial condition is set and the fluid dynamics is never solved for afterwards.

How Has This Been Tested?

An application test for the Stefan problem has been added

Documentation

Phase change properties have been added to the documentation
An example has been added for the Stefan problem.

Future changes

More test and more robustness

Comments

I'm not perfectly happy with the multiphysics interface change, but I think it's a step in the right direction.
Love how the thermal model is quite robust.

Nice example, I did not know that we supported that in Lethe. I have only some suggestions/comments for the documentation.

Yeah well, it was not supported before Wednesday, but it took an evening to wrap-up. The new physical properties manager enables crazy non-linear properties transparently... I also cheated a bit, because I wrote this Blais 2018 paper and I know all of this by heart. It is an easy problem to solve if you have a solution from memory.


初始化时，eslint检查报错，导致中断

Version
3.0.1
Node and OS info
node v9.2.1/npm v6.1.0/mac 0.13.6
Steps to reproduce

vue create project
select demo
5 errors,
Running completion hooks...error: Parsing error: The keyword 'import' is reserved at cli3-custom/src/main.js:1:1:
error: Parsing error: The keyword 'import' is reserved at cli3-custom/src/registerServiceWorker.js:3:1:
error: Parsing error: The keyword 'import' is reserved at cli3-custom/src/router.js:1:1:
error: Parsing error: The keyword 'import' is reserved at cli3-custom/src/store.js:1:1:
error: Parsing error: The keyword 'import' is reserved at cli3-custom/tests/unit/HelloWorld.spec.js:1:1:

but, the project can still run
when I commit, eslint check is trigged again, and the errors occur again
What is expected?
no eslint error
What is actually happening?
can't commit normally

yew,just now, I Encounter this problem

@cokeknight 请提供复现代码，仅一张报错截图并不能帮助排查问题。

@sodatea my vue version is 3.0.1
I just run command vue create hello-world
then

eslint is your custom preset which we don't know what the actual config is.
So please provide the content of ~/.vuerc.

just select demo presets

my  .vuerc content in home directory is:
{
  "packageManager": "npm",
  "useTaobaoRegistry": false,
  "presets": {
    "demo": {
      "useConfigFiles": false,
      "plugins": {
        "@vue/cli-plugin-babel": {},
        "@vue/cli-plugin-pwa": {},
        "@vue/cli-plugin-eslint": {
          "config": "standard",
          "lintOn": [
            "save",
            "commit"
          ]
        }
      },
      "router": true
    },
    "standard-vue-template": {
      "useConfigFiles": false,
      "plugins": {
        "@vue/cli-plugin-babel": {},
        "@vue/cli-plugin-pwa": {},
        "@vue/cli-plugin-eslint": {
          "config": "standard",
          "lintOn": [
            "save",
            "commit"
          ]
        },
        "@vue/cli-plugin-unit-jest": {}
      },
      "router": true,
      "routerHistoryMode": false,
      "vuex": true,
      "cssPreprocessor": "sass"
    }
  }
}

no other eslint config expect in package.json which is generated by default
"eslintConfig": {
    "root": true,
    "env": {
      "node": true
    },
    "extends": [
      "plugin:vue/essential",
      "@vue/standard"
    ],
    "rules": {},
    "parserOptions": {
      "parser": "babel-eslint"
    }
  },

I don't have global eslint, and I think vue-cli should read the config in package.json
what's wrong with configuration?


New event. CommandProcessEvent

I needed an event to handle the process of a command before and after that happen in the same tick. So I created this new event to handle that.
When some commands are fired by some players, I need to disable some functionalities. /help is one of them.
Currently there is only one event for when a command is send and it is SendCommandEvent. The commandResult isn't good.
https://github.com/SpongePowered/SpongeCommon/blob/bleeding/src/main/java/org/spongepowered/common/command/SpongeCommandManager.java#L258
SpongeCommon: https://github.com/SpongePowered/SpongeCommon/pull/888

Removed SendCommandEvent and moved the setters of CommandProcessEvent to CommandProcessEvent.Pre

So, posting here everything I have in mind

We already have SendCommandEvent. So we should just change that rather than creating a new event with almost the same functionality (apart from CommandProcessEvent.Post)  (kinda solved already)

Thiss is the question about when the event should be fired (I'm talking about CommandProcessEvent.Pre aka current SendCommandEvent)

First possibility. Event is fired right after the user presses enter before any processing at all. At this point we only have a string that the server got from the client and the only thing we can do is edit that string. That is what currently is being done I believe, but it seems extremely low level. For example, we can't really tell what CommandExecutor the command will fire, who is the owner of the original command, what arguments are we supposed to have.
Second possibility is firing the event right after Sponge parsed the command but before executor is fired. At this point in time we should have CommandMapping and CommandArgs available.
But here we have a problem. If we change a command at this point, god knows what will happen. Unless Sponge implementation feels like parsing a command once again...
Can be solved by introducing one more stage to the event (can't think of a name) and just not allow changing it there.
Also, while CommandArgs is a bit better than String, it's still essentially the same thing. CommandContext could be better, but we can't just get all arguments, we have to know the key. Also, we can't get to know what argument is supposed to represent (be it a player, a world or something else).
Here I'm hoping that someone else who has better knowledge about implementation could correct me and suggest better solution. Right now my only suggestion is creating a new intermediate object (maybe mutable)
PS. What about renaming the event from CommandProcessEvent to ProcessCommandEvent (coincides with SendCommandEvent)?

Also. I never thought about that, but there's no way to get CommandSender. Can you add that?

You can't always get CommandArgs. Some plugin use CommandCallable and there is no CommandArgs created.

We can check if CommandCallable is instanceof CommandSpec and if it's not, do
new CommandArgs(args, Collections.singletonList(new SingleArg(args, 0,args.length()-1)));
And if it is, do
new CommandArgs(arguments, ((CommandSpec)spec).getInputTokenizer().tokenize(arguments, false));
But problem still remains - it's just a wrapper around String. And unmodifiable one too.

We can check if CommandCallable is instanceof CommandSpec and if it's not, do
new CommandArgs(args, Collections.singletonList(new SingleArg(args, 0,args.length()-1)));
And if it is, do
new CommandArgs(arguments, ((CommandSpec)spec).getInputTokenizer().tokenize(arguments, false));
It just occurred to me that if we get CommandMapping from getCommand(), we could as easily parse the arguments ourselves.

So, after all that my only suggestions would be:

Replacing String with CommandMapping in getCommand() and setCommand()
Renaming the event from CommandProcessEvent to ProcessComandEvent
Maybe returning setResult(CommandResult) to Post

@zml2008
Need a judgement call on this one.

I think this event could be nice to have. We will know when a command is sent by a player before and after its execution.
If you want to merge it, I will recreate a pull request because I deleted the repositories for SpongeAPI and SpongeCommon. I could do that tonight. It will contains the same code.

Yeah, this functionality would be useful. Only issue I had was already mentioned by @ryantheleach. Once that's resolved this should be good to merge.
It should be relatively easy to recreate the changes -- GH keeps the commit even though its been deleted, so you can checkout the commit you already had from the SpongePowered/SpongeAPI repository.

@djxy I can't clone your repository to look at merging this PR as it's marked as "private" or "unknown".

I deleted the repository when I cleaned my account. I can recreate it if you want.

@djxy Is this still wanted?

@dualspiral Can you merge this into your commands PR (or decide how you want this)?

@Zidane Yep.


jsonschema2pojo creates java classes with underscores in case of same schema node in different schema file.

Hi, I am new to jsonschema2pojo.
I am using this plugin in my project to generate pojo classes. We have many json schema files and some schema nodes in the file are repetitive in more than 1 file with different attributes but same node name.
First time when it finds the node, java class created properly with "nodename".java but when it parses the same node in different file again  it creates the java class with "_"(underscore), And creates classes by appending more underscores for the next occurrences of same node.
Ex:
Action.java
Action_.java
Action__.java
Action___.java
Action_____.java
Problem i am having is, If schema is updated with same node or new schema is added in future, then the pojo classes gets generated differently with underscores, And i have to fix these compile errors in my source code.
I cant change the schema files as it is provided by 3rd party , I want the java class name to be created with json file name prefixing on it. How can i prefix filename to java class name ? Or is there any better solution to my problem.
Kindly help. Thank you.

I think what you need here is the patch that was submitted in #622. I'm not sure this patch can go into the core yet, but if you wanted to build your own version from this branch then you could solve your problem.
Another option is to add javaType to your Action objects so that they each get a permanent name that you decide. Much better to give your objects a canonical name that is unambiguous IMO.


Nuget Restore Fails when adding SignalR to .NET CORE APP (v2.0.3)

Hello,
I upgraded my dotnet core app to version 2.0.3 and added the latest SignalR package but Im getting the following error!

My .csproj file looks like this.

Could you share your full .csproj file, or even ideally a repro app on github?
cc @anurse

Hey @Sabdeth, I took an MVC app and updated Microsoft.AspNetCore.All to 2.0.3 and added a reference to Microsoft.AspNetCore.SignalR as you indicated, but I'm not seeing this error. It would be really helpful to see more of your csproj, to see if there are any other things that could be causing this error. If you'd rather not share it on GitHub, you can also email me directly at [my github user<EMAIL_ADDRESS>

@anurse I have sent an email to<EMAIL_ADDRESS>with my .csproj attached. Please let me know if you need anything else.

Attaching a

To update this thread. I'm working with @Sabdeth to try and work out the problem. At this point, it appears to be a problem with the machine configuration (NuGet caches, or versions or something), and not directly related to SignalR. I'd like to keep this issue open until we confirm that though.

Thanks to @anurse now I am able to restore my project. The problem was with my Nuget Cache. I ran dotnet nuget locals all --clear and it worked.


Update ApiController tests with StatusCodes class constants

Few of the ApiController test methods contain checks for certain status code that is being returned from controller (i.e. Ok, NotFound status).
The current commit updates assertion of few of the test methods to have constants instead of hard-coded status code (i.e. StatusCodes.Status200OK instead of 200).

Hi @AshrafAlam, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Hi @AshrafAlam we're generally looking for more substantial changes. Though the status codes were in some sense "hard coded," they'll always be the same value. If you have more value to add that is related to this change we could take this, but I'm not sure it's worth it for just this one change.


BigNumber fails to load in Electron apps

Not sure if you're familiar with Electron, but its a way of pacakging web apps as desktop apps. BigNumber fails to load in Electron apps due to this line:
https://github.com/MikeMcl/bignumber.js/blob/master/bignumber.js#L2685
Electron automatically creates a module object in the browser which makes bigNumber think its a node environment.
I'm not sure what the solution is here. Is there an alternative to detecting a node environment?

I've just tried it and you are right that the library does not load using, for example,
<script src="./bignumber.js"></script>

in an html page in an electron app.
But it does seem to load fine using require, so it's just a matter of instead using, for example,
var BigNumber = require('./bignumber');

within script tags in an html page, or within any .js files.


can't figure out how to make a custom recipe with infushion pedistal

i can't figure out how to make a custom recipe with infushion pedistal. i used the template but still cant figure it out.

did you figure it out?
I'm trying to add a recipe for a book with a modded enchantment
currently I've got an enchanted_book.json file - I've tried placing it in data/minecraft/recipes/, data/veinmining/recipes/ and data/custom-pack/recipes/, but it's not working
{ 	"type": "betterend:infusion", 	"input": "minecraft:book", 	"result": { 		"item": "minecraft:enchanted_book", 		"count": 1, 		"nbt": "{StoredEnchantments:[{id:\"veinmining:vein_mining\",lvl:1}]}" 	}, 	"time": 10, 	"catalysts": { 		"north":      "minecraft:diamond_pickaxe", 		"north_east": "minecraft:lapis_lazuli", 		"east":       "betterend:amber_gem", 		"south_east": "minecraft:lapis_lazuli", 		"south":      "minecraft:hanging_roots", 		"south_west": "minecraft:lapis_lazuli", 		"west":       "betterend:amber_gem", 		"north_west": "minecraft:lapis_lazuli" 	} }
also tried dirt.json with
{ 	"type": "betterend:infusion", 	"group": "infusion", 	"input": "minecraft:book", 	"result": { 		"item": "minecraft:dirt", 		"count": 1 	}, 	"time": 10, 	"catalysts": { 		"north":      "minecraft:diamond_pickaxe", 		"east":       "minecraft:hanging_roots", 		"south":      "minecraft:hanging_roots", 		"west":       "minecraft:hanging_roots" 	} }  - still nothing..

Example of simple and correct recipe:
{
	"type": "betterend:infusion",
	"input": {
		"item": "minecraft:apple"
	},
	"result": {
		"item": "minecraft:stone",
		"count": 1
	},
	"time": 10,
	"catalysts": {
		"north": "minecraft:apple",
		"south": "minecraft:apple",
		"east": "minecraft:apple",
		"west": "minecraft:apple"
	}
}


Pin kubernetes-mixin version in release-0.4

kubernetes-mixin master branch is only compatible with Kubernetes 1.18+, thus breaking this branch Kubernetes compatibility.
I pinned it according to what we have downstream: https://github.com/openshift/cluster-monitoring-operator/blob/release-4.4/jsonnet/jsonnetfile.json#L23-L29

Lgtm but would like another pair of eyes


[TextField] alignLabelWithHint does not have any effect when used with UnderlineInputBorder

Steps to reproduce

Run the code sample below
check the difference of behavior between UnderlineInputBorder and OutlineInputBorder

Expected results
When alignLabelWithHint is set to false with UnderlineInputBorder, the label should align the same way OutlineInputBorder does
Actual results
When alignLabelWithHint is set to false it still aligns with the hint
Code sample
Code sample

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: Scaffold(
        body: Center(
          child: TextField(
            decoration: InputDecoration(
              // border: const UnderlineInputBorder(),
              border: const OutlineInputBorder(),
              prefixIcon: Container(
                color: Colors.amber,
                width: 100,
                height: 48,
              ),
              labelText: 'My label',
              alignLabelWithHint: false,
            ),
          ),
        ),
      ),
    );
  }
}

Screenshots or Video
Underline

^ I can already achieve that behavior with alignLabelWithHint: true, for my personal use case I need to align it like the outline does below
Outline

Logs
No response
Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.16.9, on Microsoft Windows [Version 10.0.22631.3007], locale en-BE)
    • Flutter version 3.16.9 on channel stable at C:\dev\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 41456452f2 (10 days ago), 2024-01-25 10:06:23 -0800
    • Engine revision f40e976bed
    • Dart version 3.2.6
    • DevTools version 2.28.5

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\cedva\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Build Tools 2019 16.11.32)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools
    • Visual Studio Build Tools 2019 version 16.11.34301.259
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2023.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)

[√] VS Code (version 1.86.0)
    • VS Code at C:\Users\cedva\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.82.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22631.3007]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 121.0.6167.140
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 121.0.2277.98

[√] Network resources
    • All expected network resources are available.

• No issues found!

Thanks for filing this.
I can reproduce this on the latest master and stable channels.
stable, master flutter doctor -v

[!] Flutter (Channel stable, 3.16.9, on macOS 14.2.1 23C71 darwin-arm64, locale
    en-NG)
    • Flutter version 3.16.9 on channel stable at
      /Users/damilolaalimi/sdks/flutter
    ! Warning: `dart` on your path resolves to
      /opt/homebrew/Cellar/dart/3.1.5/libexec/bin/dart, which is not inside your
      current Flutter SDK checkout at /Users/damilolaalimi/sdks/flutter.
      Consider adding /Users/damilolaalimi/sdks/flutter/bin to the front of your
      path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 41456452f2 (11 days ago), 2024-01-25 10:06:23 -0800
    • Engine revision f40e976bed
    • Dart version 3.2.6
    • DevTools version 2.28.5
    • If those were intentional, you can disregard the above warnings; however
      it is recommended to use "git" directly to perform update checks and
      upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C65
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      17.0.6+0-17.0.6b802.4-9586694)

[!] Android Studio (version unknown)
    • Android Studio at /Users/damilolaalimi/Downloads/Android Studio
      Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build
      17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.86.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.78.0

[✓] VS Code (version 1.83.1)
    • VS Code at /Users/damilolaalimi/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.78.0

[✓] Connected device (5 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554                        •
      android-arm64  • Android 14 (API 34) (emulator)
    • Damilola’s iPhone (mobile)  • 00008110-001964480AE1801E            • ios
      • iOS 17.1.1 21B91
    • iPhone 15 Pro (mobile)      • 79E44FCE-BEA4-4C4B-9C1C-EFBD9964E172 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)
    • macOS (desktop)             • macos                                •
      darwin-arm64   • macOS 14.2.1 23C71 darwin-arm64
    • Chrome (web)                • chrome                               •
      web-javascript • Google Chrome 121.0.6167.139

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

[!] Flutter (Channel master, 3.20.0-1.0.pre.21, on macOS 14.2.1 23C71 darwin-arm64, locale en-NG)
    • Flutter version 3.20.0-1.0.pre.21 on channel master at /Users/damilolaalimi/fvm/versions/master
    ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/3.1.5/libexec/bin/dart, which is not inside your current Flutter SDK checkout at /Users/damilolaalimi/fvm/versions/master. Consider adding /Users/damilolaalimi/fvm/versions/master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 0b5cd5073a (7 hours ago), 2024-02-05 06:16:23 +0100
    • Engine revision f34c658b96
    • Dart version 3.4.0 (build 3.4.0-99.0.dev)
    • DevTools version 2.31.0
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/damilolaalimi/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/damilolaalimi/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15C65
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[!] Android Studio (version unknown)
    • Android Studio at /Users/damilolaalimi/Downloads/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] VS Code (version 1.86.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.78.0

[✓] VS Code (version 1.83.1)
    • VS Code at /Users/damilolaalimi/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.78.0

[✓] Connected device (6 available)
    • sdk gphone64 arm64 (mobile)     • emulator-5554                        • android-arm64  • Android 14 (API 34) (emulator)
    • Damilola’s iPhone (mobile)      • 00008110-001964480AE1801E            • ios            • iOS 17.1.1 21B91
    • iPhone 15 Pro (mobile)          • 79E44FCE-BEA4-4C4B-9C1C-EFBD9964E172 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-2 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64   • macOS 14.2.1 23C71 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin         • macOS 14.2.1 23C71 darwin-arm64
    • Chrome (web)                    • chrome                               • web-javascript • Google Chrome 121.0.6167.139

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

@justinmc
Summary
The use case looks valid to me (despite not being part of M3 spec) but it can not be achieved by relying on InputDecoration.alignLabelWithHint.
Explanation
The default value of InputDecoration.alignLabelWithHint is false.
So I don’t think this issue could be fix by expecting that alignLabelWithHint being false should not align the label and the hint horizontally, because it would be a huge breaking change : the default InputDecorator for filled text field won’t be compliant with the M3 spec (the compliant rendering would require InputDecoration.alignLabelWithHint to be set to true).
The reason is that alignLabelWithHint was initially intended for vertical alignment only. See https://github.com/flutter/flutter/pull/24993 which introduced alignLabelWithHint parameter.
Unfortunately, https://github.com/flutter/flutter/pull/115409 relied on this parameter for the horizontal alignment of outlined text field. In this case, it was not a breaking change because by default it is expected that label and hint are not aligned and defaulting to false was possible. After that PR, one can set alignLabelWithHint  to true if the non default alignment is expected. It works for outlined decoration but it can't work for filled decoration.
If we had InputDecorator.filled and InputDecorator.outlined constructors and users were relying on these constructors, it would have been possible to set different default values for alignLabelWithHint. But that’s not the case.
If we consider adding a new parameter it should reflect differently for filled and outlined text fields. It would have to be a parameter that reflects that the label could be aligned in a non compliant way, which means we could default to false for both filled and outlined.
Alternative
InputDecorator supports two different positioning logic for the label:

Filled text field: label painted inside the container above the input text
Outline text field: label painted on the container border

The implementation currently choose the positioning based on InputDecoration.border.isOutlined.
Currently a possible, hacky?, solution for this problem is to create a subclass of InputBorder with a positioning logic somewhat similar to the filled one but with InputBorder.isOutlined returning true.
See this comment and the associated code.


NetFlow5 Sampling Interval field should be split into Sampling Mode + Sampling Rate

Hi,
It seems that the NetFlow5 sampling_interval field is not decoded correctly when a Sampling Mode is set.
Based on this doc below, the sampling interval field should be parsed as "First two bits hold the sampling mode; remaining 14 bits hold value of sampling interval", but currently implement seems to be consider the whole field as sampling interval.

https://www.cisco.com/c/en/us/td/docs/net_mgmt/netflow_collection_engine/3-6/user/guide/format.html
Example
Example pcap with sampling mode: https://github.com/Graylog2/graylog-plugin-netflow/blob/master/src/test/resources/netflow-data/netflow5.pcap

The sampling_interval contains<PHONE_NUMBER>100100.
Currently, this is converted to sampling_interval: 16484
Instead of sampling_interval: 16484, sampling_mode:1

I can try to come up with a fix PR if we agree this is an issue to fix.

Hi @AlexandreYang
Good catch, I'm missing a bit operation there
https://github.com/netsampler/goflow2/blob/f77d8832051b7462998b7eb19d4088a5c1f4b1f4/producer/producer_nflegacy.go#L67
I will do the fix in v2 and this.
Thank you

Added in https://github.com/netsampler/goflow2/commit/d090ab3d7b59d98dd0ce6b39338809b2f849af5c
and #171


Add search mapping for G10

Probably for this trello card.
Includes an increased max_result_window. This is because we have over
20000 services for G10. Without this value being increased we would only
show that we had 20000 services.

I'm assuming this has an equivalent PR in the frameworks repo?

https://github.com/alphagov/digitalmarketplace-frameworks/pull/526


Linux Support

For the most part, we just need to fill in the platform-specific pieces. There may be some features not supported initially (e.g. there is no Linux-desktop common approach to view an SSL cert).

Initial version complete, but things like #23 persist


Question: Can kuzu embedded run in the browser?

Can the node.js client run from a browser (esm) context (similar to duckdb).   I couldn't find information about it.  I was wondering if i could run it from cloudflare workers using httpfs and s3 as a datasource.
from my understanding, duckdb uses a wasm import.  I see some references to wasm in your codebase, but i wasn't sure.
thanks,

Hi @ShravanSunder,
Thanks for your interest. I think you are referring to https://github.com/duckdb/duckdb-wasm, which support running DuckDB inside browser. I started some preliminary work on getting a wasm version of Kùzu on https://github.com/kuzudb/kuzu/tree/emcc-test, but it does not quite work right now as Kùzu’s current buffer manager uses memory mapping and requires support of MADV_DONTNEED, which is not available for wasm right now. Later this year, we may work on an alternative version of buffer manager which does not depend on memory mapping so that wasm can be supported. I will convert this issue into a discussion and let you know when wasm support is available.