How to keep the mbed-os version of mbed-os-example-mesh-minmal up to date

Recently I've cloned mbed-os-example-mesh-minial from github using "mbed import" command. As I know, the latest version of mbed-os is released as 5.13.4.  But when I compared mbed-os from https://github.com/ARMmbed/mbed-os with mbed-os from https://github.com/ARMmbed/mbed-os-example-mesh-minimal, source tree Is very different. I think it might be not same version of these mbed-os sources.

If it's right, could you tell me the corresponding git command?

Hi @JayJaehoonRhee
All Mbed OS example applications now follow the model where master branch is development branch, and might not follow Mbed OS releases.
For every feature release version, there is branch existing. So for Mbed OS 5.13 release, this application have mbed-os-5.13 branch.
You can follow this release by doing the mbed import normally, then cd <app>; mbed update mbed-os-5.13
This will do git-checkout of branch called mbed-os-5.13 and update all libraries toi point correct versions.

Hi @SeppoTakalo
Even though I followed as you commented, the source tree s of mesh-minimal-example is still different from https://github.com/ARMmbed/mbed-os.
Does "mbed update" command only update the libraries?
I just want to make the source tree of mbed-os 5.13.4 released the same as the source tree of mbed-os of mesh-minimal-example.

ARM Internal Ref: IOTCELL-2170

Hi @JayJaehoonRhee , sorry to keep you waiting for so long.
Not sure if that's the issue, but what you actually see when you go straight to https://github.com/ARMmbed/mbed-os and view the revision history is not any particular release, but simply the most recent master branch, as Seppo explained.
If you want to be in line with what you see there you need to run: mbed update master.

@JayJaehoonRhee , did you manage to solve this issue or is it still open?

@JayJaehoonRhee I am closing this issue, but if you can provide more information or need more support, feel free to reopen.


Rename @iopipe/iopipe to just iopipe

Closes https://github.com/iopipe/iopipe-js-core/issues/213

I think if we wanted to publish under both names that could be an acceptable compromise? I am a 👎  on this patch as it exists currently and agree we'd need more discussion on the right solution.

@ewindisch Going to close this as the thumbs down win it. We can discuss further in other channels.


Edit the value of variables at a breakpoint when debugging Dart

Debuging a Dart programme
Stopped at a break point
I want to be able to edit the value of a variable

Version: 1.81.0 (Universal)
Commit: 6445d93c81ebe42c4cbd7a60712e0b17d9463e97
Date: 2023-08-02T12:40:02.782Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.5.0

Dart SDK version: 3.1.2 (stable) (Tue Sep 12 16:26:23 2023 +0000) on "macos_arm64"

VS Code supports this but the Dart extension would need to implement this if it doesn't work


Adding Grammarly or something similar

Describe the feature you'd like
Hello
I really like to see Grammarly or something similar (better to be local and self hosted) checking my writing when I'm editing and writing a page inside the BookStack (E.g. at the top or right toolbar) for grammatical mistakes and misspellings.
Describe the benefits this would bring to existing BookStack users
It will decrease the time and effort one have to spend for proof reading a page after writing it.
Have you searched for an existing open/closed issue?

[X] I have searched for existing issues and none cover my fundemental request

How long have you been using BookStack?
0 to 6 months

@ssddanbrown
Thanks for your clarification and suggestion, I gave languagetool extension a try but it had too many false positive signals and since in order to work it need to send all of the texts and data to their servers I just remove it.
I wonder if there is any self hosted solution out there that can be add to BookStack.


PLT-5436: Render channel links in the channel header

Summary
Channel Header is now linked to the specific channel if the text following the (~) matches any of the display_names.
Ticket Link
issue-7257
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)
[ ] Has server changes (please link)
[ ] Has redux changes (please link)
[x] Has UI changes
[ ] Includes text changes and localization file (.../i18n/en.json) updates
[ ] Touches critical sections of the codebase (auth, posting, etc.)

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@panditsavitags Looks like there's a build failure. Can you help take a look?

Spinmint test server created at: http://i-08797493ae2317685.spinmint.com
Test Account 1: Email<EMAIL_ADDRESS>| Password: passwd
Test Account 2: Email<EMAIL_ADDRESS>| Password: passwd
Instance ID: i-08797493ae2317685

@jasonblais , Please can you paste the error? I am not able to check the details of the build faliure.

@panditsavitags It's just a style issue
$ eslint --ext ".jsx" --ignore-pattern node_modules --quiet .

/home/jenkins/workspace/mattermost-webapp_PR-387-2HIGC7TBLEDX57RY5YNGAT5NIC75Q437465WSNID364XJDUTNCXQ/mattermost-webapp/components/user_settings/user_settings_display.jsx
  462:13  error  'teammateNameSection' is assigned a value but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

@hmhealey , I have fixed the style error, please can you check what went wrong now?

Spinmint test server destroyed


proposal: log/slog: add ParseLevel

Proposal Details
Level and LevelVar have UnmarshalText methods, but there no direct way to parse a string into a Level.
UnmarshalText is fine if the level is a flag, but not if it's, say, a query param. For that one has to write the awkward code:
slogLevel.UnmarshalText([]byte(r.FormValue("l"))

Add ParseLevel(string) (Level, error).

Related Issues and Documentation

proposal: log/slog: add a method to convert a string to a Level #59416 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)


Switch suppression from @Mutable to @SuppressWarning("OOP.MethodChangesState")

Also, I suggest renaming the MethodChangesState class to something else

@l3r8yJ thank you for reporting this. I'll assign someone to take care of it soon.

@h1alexbel this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2024-01-13T11:00:26.935134.
Estimation here is 60 minutes, that's how much you will be paid.
Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.
If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.
If you don't have time or simply don't want to work on this, you can always resign.

Also, I suggest renaming the MethodChangesState class to something else

what about MethodChangesStateCheck? or MethodStateChangeCheck

@h1alexbel what about MutableStateCheck, wdyt?

@l3r8yJ I like MutableStateCheck, added to #113

@h1alexbel i'll close after #113

@l3r8yJ I think it can be closed

@h1alexbel thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.


Can't create task in home tab

Installed API: 0.22.0
Frontend Version: 0.22.0
Installed app: 0.1.2-beta
When I click on the + symbol on the home screen and want to create a new task, the following error message appears: Please select a default list in the settings.
However, I have set the default list. I have also run tests by changing the list. The change is saved in the database (I can see the changed default list on the server). No matter what I have selected, no tasks can be created via the home screen.
If you go to the project page, select a project and enter the task there, it works.

Oh yeah, you're right sorry about this. I didn't notice because even though it was getting the new default project from the API, it still used the old one in the device storage. Since you probably set up your app after the release came out or at least cleared the storage, it didn't work for you, but I didn't catch it during testing. I will publish a new release in a couple of hours with this fixed, please report back after you tried the new release!

It works now, thank you :)


Update recipe version to v0.11.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

We're merging this one without waiting for Travis to finish (which can take days!).


Modify exit code if cmd terminated by signal

Fixes: https://github.com/con/duct/issues/148
Currently does not implement suggestion from @jwodder

If we're talking about what exit code duct should print when the subprocess is killed by a signal, I think "Exit Code: {n}" should be forgone in such circumstances and be replaced by something like "Killed by signal: {signal_name}".

This would be a good interface, but given that the "Summary" output at the end is user-customizable, I think it adds more complexity than its worth. IMO though, that feature may have outlived its usefulness as duct is getting more complex; @yarikoptic if we are ok with dropping --summary-format, I'd feel more comfortable adding logic to the summary.

For this fix let's just fix the exit code value reporting . Let's discuss switch from format elsewhere (e.g. dedicated issue).


add new model to use

I want to add new model  as ASR_MODEL=base ,but I try to download the Belle-distilwhisper-large-v2  to the Model Path.But it can't run rightly ?

Any  update?

I actually have the same issue, I would prefer to use the "medium" model but when I use either of the following commands the webserver won't even open for me once the container starts.

docker run -d --net whispernetwork --name project_openai_whisper_asr_webservice -h whisperai -p 9000:9000 -e ASR_MODEL=medium -e ASR_ENGINE=openai_whisper -it onerahmet/openai-whisper-asr-webservice:latest
docker run -d --net whispernetwork --name project_openai_whisper_asr_webservice -h whisperai -p 9000:9000 -e ASR_MODEL=small -e ASR_ENGINE=openai_whisper -it onerahmet/openai-whisper-asr-webservice:latest

However running this command does work and the webserver starts immediately:

docker run -d --net whispernetwork --name project_openai_whisper_asr_webservice -h whisperai -p 8080:9000 -e ASR_MODEL=base -e ASR_ENGINE=openai_whisper -it onerahmet/openai-whisper-asr-webservice:latest

What I'd love to see would be a model-switcher so I can save whichever model(s) I want to use and then select it in the UI or specify the model to use in the endpoint

any update ？

@lewdon I will try to take a look at this, just chanced on this repo


Added directions link to pokemon popup

How do I update my Pokeminer? Isn't it an uneditable package?  Are you on windows, osx or linux? And did you clone this repo or downloaded a zip?
https://git-scm.com/book/en/v2/Getting-Started-Git-Basics

@paul30001 I don't understand what you're asking. I don't see anywhere to download Pokeminer not as source code.

Just a suggestion:
Maybe it's a good thing to write a tutorial on how to get this up and running on multiple platforms? A good place for this would be at the wiki ;)

This specific pull request that we are commenting on is very simple.
Just click 'files changed' above, and add/change the 3 lines in /templates/newmap.html

And I just noticed I derped
var lat = item.lon;
should obviously be
var lon = item.lon;

Thanks!


Timeout in larger environments

After the API call is sent it seems to time out after 60 seconds. I have a larger environment where I could be updating a static group with over 36k devices at a time. While the group does update after a few minutes it looks like Jamf does not respond quick enough and MUT says that it failed.
2021-02-02 09:46:51 [INFO  ]: Token has 805 seconds left to live. Proceeding with current token.
2021-02-02 09:46:51 [INFO  ]: Beginning CSV Parse - Scope update.
2021-02-02 09:46:51 [INFO  ]: Submitting a PUT to https://jamf.url/JSSResource/mobiledevicegroups/id/123
2021-02-02 09:47:52 [FATAL ]: The request timed out.

Unfortunately, there is not much that can be done here--I believe this is functionality of the API itself. If you are self-hosting, beef up your environment, and if you're cloud hosted, chat with Jamf Support and see if they can address the issue with cloud ops. :)


[4.x] use mongodb driver to check for dirtiness

Reopening of #1664

To check if a field is dirty we can simply use fromPHP() function of the mongodb driver. Besides, we shouldn't use the SQL-specific logic of Illuminate\Eloquent\Model::originalIsEquivalent()  for mongodb. In sql, fields keep their schema data types and changing  integer 1 to string '1' actually does nothing. However, in mongodb  fields accept their types as they are inserted/updated. Therefore, if we  change value of a field from (int)1 to (string)'1' we actually must regard it as dirty. This change is backward incompatible. Don't know if anyone likes the current behaviour more.
--

Codecov Report

Merging #1990 into develop will decrease coverage by 0.08%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #1990      +/-   ##
=============================================
- Coverage      82.80%   82.72%   -0.09%
+ Complexity       531      526       -5
=============================================
  Files             27       27
  Lines           1210     1204       -6
=============================================
- Hits            1002      996       -6
  Misses           208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b379bd3...9e7866a. Read the comment docs.

Codecov Report

Merging #1990 into develop will decrease coverage by 0.08%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop    #1990      +/-   ##
=============================================
- Coverage       82.8%   82.72%   -0.09%
+ Complexity       531      526       -5
=============================================
  Files             27       27
  Lines           1210     1204       -6
=============================================
- Hits            1002      996       -6
  Misses           208      208

Impacted Files
Coverage Δ
Complexity Δ

src/Jenssegers/Mongodb/Eloquent/Model.php
80.98% <33.33%> (-0.78%)
75 <0> (-5)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b379bd3...9e7866a. Read the comment docs.

@jenssegers Nice coverage tool. But I feel I decreased the source code complexity in terms of both lines of code and branches. I also added new tests. How come the coverage is decreased? I think the report is somehow wrong.

I see the report now. I didn't test for when exception is thrown. I don't quite remember. Maybe it has to do with my next pull request regarding unset field #1667

Closing in favor of #2515 after 3 years...
Thank you @halaei !


Setup utility not working properly when environment is set to dev

When the environment is set to dev, the setup utility isn't prompting the user for some needed values, namely DOMAIN, and therefore, nginx.conf isn't getting properly setup.
So server_name  {{DOMAIN}}; is getting set to server_name ; and therefore nginx fails to start.

Ignore this. My brain stopped for a moment there. Dev isn't supposed to be using nginx :)

https://github.com/psychok7/django-yadpt-starter/commit/cf1dd996e226e3fc2eac3487c13aebaf35e9074c


Error : ENOENT

Describe the bug
Error: ENOENT: no such file or directory, open 'C:\Users\adity\AppData\Roaming\npm\node_modules\udacimak\node_modules\youtube-dl\bin\details'
Expected behavior
I just wanted to render some JSON files. This is the first time doing this, I just installed udacimak using npm install udacimak, and the installation was completed perfectly/with no errors and I checked in AppData. The folder does exist. It is giving me the same error when I ask for version through udacimak --version.
Error: ENOENT: no such file or directory, open 'C:\Users\adity\AppData\Roaming\npm\node_modules\udacimak\node_modules\youtube-dl\bin\details'
    at Object.openSync (fs.js:440:3)
    at readFileSync (fs.js:342:35)
    at module.exports (C:\Users\adity\AppData\Roaming\npm\node_modules\udacimak\node_modules\youtube-dl\lib\get-binary.js:15:30)
    at Object.<anonymous> (C:\Users\adity\AppData\Roaming\npm\node_modules\udacimak\node_modules\youtube-dl\lib\youtube-dl.js:18:41)
    at Module._compile (internal/modules/cjs/loader.js:959:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:995:10)
    at Module.load (internal/modules/cjs/loader.js:815:32)
    at Function.Module._load (internal/modules/cjs/loader.js:727:14)
    at Module.require (internal/modules/cjs/loader.js:852:19)
    at require (internal/modules/cjs/helpers.js:74:18) {
  errno: -4058,
  syscall: 'open',
  code: 'ENOENT',
  path: 'C:\\Users\\adity\\AppData\\Roaming\\npm\\node_modules\\udacimak\\node_modules\\youtube-dl\\bin\\details'
}

Screenshots

Desktop (please complete the following information):

OS: Windows
Node version: (12.14.0)
npm version: (6.13.4)
Udacimak Version<EMAIL_ADDRESS>

Try to use npx. I was having some issues with npm but using npx it fixed it

Could you also try using yarn to install, too?
I've had a few weird issues with youtube-dl that I cannot replicate.

Hey @udacimak please help me to get through this!
(base) akshat@akshat-Inspiron-5570:~$ sudo udacimak login
fs.js:114
throw err;
^
Error: ENOENT: no such file or directory, open '/usr/local/lib/node_modules/udacimak/node_modules/youtube-dl/bin/details'
at Object.openSync (fs.js:443:3)
at readFileSync (fs.js:343:35)
at module.exports (/usr/local/lib/node_modules/udacimak/node_modules/youtube-dl/lib/get-binary.js:15:30)
at Object. (/usr/local/lib/node_modules/udacimak/node_modules/youtube-dl/lib/youtube-dl.js:18:41)
at Module._compile (internal/modules/cjs/loader.js:778:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
at Module.load (internal/modules/cjs/loader.js:653:32)
at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
at Function.Module._load (internal/modules/cjs/loader.js:585:3)
at Module.require (internal/modules/cjs/loader.js:692:17)

Try to use npx. I was having some issues with npm but using npx it fixed it

I have installed npx then what should I do ?

I am not getting the "bin" folder in my local machine
OS: Win 10

Try to use npx. I was having some issues with npm but using npx it fixed it

Could you please tell what needs to be done after installing "npx"

Try to run cmd in administrator mode，and then delete all udacimak files.Use npm list udacimak to reinstall udacimak.


When starting server it doesn't need args but joining session errors

Hi, following the guide for the first time was confusing until I saw the gif image.
Basically you use :InstantStartServer with no args, but InstantStartSession requires args otherwise I get a confusing error. To make it work, I had to use :InstantStartSession <IP_ADDRESS> 8080.
Consider changing the defaults or at least adding a line in the README, and making the error message more informative.
Thanks a lot for this amazing tool

Hi,
Thank you for the issue.
If you're still willing to help others, consider modifying the README so that it makes it more clear. I will merge it afterwards.


net: ip: Make struct in_addr::s_addr compatible with POSIX definition

From
http://pubs.opengroup.org/onlinepubs/7908799/xns/netinetin.h.html:
in_addr_t
An unsigned integral type of exactly 32 bits.
[] the in_addr structure [] includes at least the following member:
in_addr_t      s_addr
In other words, POSIX requires s_addr to be a single integer value,
whereas Zephyr defines it as an array, and then access as s_addr[0]
everywhere. Fix that by following POSIX definition, which helps to
port existing apps to Zephyr.
Jira: ZEP-2264
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

Fix for https://jira.zephyrproject.org/browse/ZEP-2264


Add Kafka OTEL receiver/ingester

Related to https://github.com/jaegertracing/jaeger/issues/2205
This PR adds Kafka OTEL receiver. This receiver will be used in OTEL ingester that will come in a follow-up PR.
PR for kafka exporter https://github.com/jaegertracing/jaeger/pull/2135

@rubenvp8510 or and @objectiser could you please review?

Main question, not for this PR, is how we work with/transition to a pure OTel/Kafka impl - would be better if using OTel model for kafka messages.

Yeah, this is not related to this PR, but it is definitely something on the roadmap.


Add support MongoDB Object ID's

The problem faced currently?
Right now when using a standard mongo collection and auto generated id's you cannot query that item later for e.g. updating since there's a mis-match with the data type.
How can we solve it?
Option 1: The client sdk's could have a method to generate an Object ID (new or with an string)
Option 2: The back-end automatically generates an Object ID on the _id parameter.

If you want this feature to be implemented, give it a thumbs up reaction, so that we can determine which features are important to you.
👍

This is an important one to be addressed. It holds true exclusively for MongoDB since it has a custom ObjectID type it assigns.

Seems like the MongoDB library exports a function to generate an Object ID from a string. Maybe look into that. https://www.tutorialspoint.com/mongodb/mongodb_objectid.htm

@didair I'm not quite sure how will we implement this. Space could can only speak json. So there is no ObjectID type it understands. Maybe we can incorporate this in the schema validation feature #78

@didair would it be okay if SC automatically generates an _id field which is string?

@YourTechBud since that is the workaround used by probably most people yes that would be an OK solution!

@sharadregoti you think we can add this in the schema validation module?

yes we can

This will be solved once we resolve #453

Added in v0.13.0


changedAttributes still return the dirty attributes until the record has been fully committed

When trying to upgrade to the latest version of ember-data-model-fragments I realised there was an issue inside the changedAttributes().
changedAttributes() is supposed to return all the dirty attributes until the record has been fully committed not just when calling the save method
In the test I show what we do, we use it to send only the dirty attributes

Looks like there's a linting issue

Released as v6.0.3


Feat: add new type "ALL"

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:

Codecov Report
Base: 10.61% // Head: 10.61% // No change to project coverage :thumbsup:

Coverage data is based on head (9d7d3b1) compared to base (ec68601).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           dev/0.9      #81   +/-   ##
========================================
  Coverage    10.61%   10.61%
========================================
  Files           11       11
  Lines          358      358
  Branches        64       64
========================================
  Hits            38       38
  Misses         315      315
  Partials         5        5

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Switch default transport to sockets

Currently, it is our goal by 2.1.0 to make sockets the default transport. We made the switch in early builds of 2.1.0 but reverted that for preview1 (https://github.com/aspnet/KestrelHttpServer/issues/2220) due to performance issues.
Motivations:

broad platform support. Wherever managed sockets are supported, Kestrel should work. Doesn't require recompiling libuv to bring up a new OS.
source-build. (https://github.com/dotnet/source-build). In current form, Kestrel packages can't be produced in a source-build environment
ecosystem. Helps to drive improvement to the .NET sockets implementation, which benefits anyone else using managed sockets.

/cc @halter73 @davidfowl @muratg

@halter73 shouldn't the announcement prefer Microsoft.AspNetCore.App over Microsoft.AspNetCore.All?

@Suchiman Your edit is correct. That's the main thing that makes the change breaking.

Do the managed sockets have similar performance compared to libuv?

@ondravondra yes that was the prerequisite for the switch and why preview1 still ships with libuv. I think it might even be.a little faster already

Just a heads up, the announcement has the tag 2.0.0-preview2, not 2.1.0-preview2

@nickalbrecht thanks for spotting that. I updated the milestone on the announcement.

Do the managed sockets have similar performance compared to libuv?

@ondravondra yes that was the prerequisite for the switch and why preview1 still ships with libuv. I think it might even be.a little faster already

Couple of months ago, it was indicated that performance regressed when switching to sockets https://github.com/aspnet/KestrelHttpServer/issues/2220. Are there any before/after performance measurements to bring about concreteness to the mix?

@kasper3
There is http://aka.ms/aspnet/benchmarks
If you navigate to page 1 with the pager at the bottom, there's a graph that shows Socket I/O by over a million RPS ahead of Libuv.
If you go to page 2 it looks differently so i don't really understand how to read them.


Transform Python Bindings Fix

Fixed pybind polymorphism issue where subclasses of Transform were cast as parent class due to missing type hooks declarations, for instance when iterating a GroupTransform. Included tests to avoid this issue when adding new Transforms in the future.

Another quick thought - I put the tests into a new file because the TransformsTest.py file didn't run successfully when I re-included it in the test suite I presumed this was because it was outdated, but curious what its history is and why it and other tests are being omitted. I think TransformsTest.py is the logical file to place this test in, however, so I'm wondering if we move it there and instead just @unittest.skip() the old failing test method.

Another quick thought - I put the tests into a new file because the TransformsTest.py file didn't run successfully when I re-included it in the test suite I presumed this was because it was outdated, but curious what its history is and why it and other tests are being omitted. I think TransformsTest.py is the logical file to place this test in, however, so I'm wondering if we move it there and instead just @unittest.skip() the old failing test method.

Thanks Frankie, this looks like solid work! Much appreciated.

Thanks Frankie, this looks like solid work! Much appreciated.

Thanks @zachlewis! Let me know if you have any thoughts regarding the ideal placement of the tests per my above comment as well.

Thanks @zachlewis! Let me know if you have any thoughts regarding the ideal placement of the tests per my above comment as well.

Thank you @frankieeder, it's great to have your participation on the project!
Regarding the TransformsTest.py file, it is largely redundant because the Transform children classes mostly already have more thorough tests in their own files.  We will clean up what's missing in another Python-related PR we have in progress.  If you want to delete the existing test in TransformsTest.py, put your test there, and enable it, that would be fine.

Thank you @frankieeder, it's great to have your participation on the project!
Regarding the TransformsTest.py file, it is largely redundant because the Transform children classes mostly already have more thorough tests in their own files.  We will clean up what's missing in another Python-related PR we have in progress.  If you want to delete the existing test in TransformsTest.py, put your test there, and enable it, that would be fine.

@frankieeder, we would need this finished by the end of the week in order to make it into the v2 release.  Thanks!

@frankieeder, we would need this finished by the end of the week in order to make it into the v2 release.  Thanks!

Thanks for the bump @doug-walker. I was able to get the code updated, but having issues getting my commit signs to register here and trigger the checks correctly. Not sure why, but something I did since @michdolan's approval seems to have un-signed my first commit so the check wont run.
See my local fork properly signed here vs the main repo
unsigned here:
Running git rebase HEAD~26 --signoff per the suggestion of the DCO check creates merge errors for every commit that isn't my own that I brought in using upstream pulls, even though this worked successfully previously.
Could use some help resolving this issue.

Thanks for the bump @doug-walker. I was able to get the code updated, but having issues getting my commit signs to register here and trigger the checks correctly. Not sure why, but something I did since @michdolan's approval seems to have un-signed my first commit so the check wont run.
See my local fork properly signed here vs the main repo
unsigned here:
Running git rebase HEAD~26 --signoff per the suggestion of the DCO check creates merge errors for every commit that isn't my own that I brought in using upstream pulls, even though this worked successfully previously.
Could use some help resolving this issue.

Sorry for the trouble @frankieeder . Might be easier to just start a fresh branch, pull your changes over, commit and sign them, and open a new PR. Detandling signing history can be a challenge.
Note that your tests are also failing in CI.

Sorry for the trouble @frankieeder . Might be easier to just start a fresh branch, pull your changes over, commit and sign them, and open a new PR. Detandling signing history can be a challenge.
Note that your tests are also failing in CI.

Good call, and noted. Should have that up later this afternoon.

Good call, and noted. Should have that up later this afternoon.

Closing this pull request in preference for correctly signed and much cleaner PR #1277. Thanks for the suggestion @michdolan. For reference if anyone searches for a similar error in the future, the error seems to have come from accidentally running the signing rebase on master instead of my feature branch. The easiest way to fix ended up being to clean up the fork and restart from the upstream branch entirely (similar to this).

Closing this pull request in preference for correctly signed and much cleaner PR #1277. Thanks for the suggestion @michdolan. For reference if anyone searches for a similar error in the future, the error seems to have come from accidentally running the signing rebase on master instead of my feature branch. The easiest way to fix ended up being to clean up the fork and restart from the upstream branch entirely (similar to this).


[BUG] invalid package ID 0x01. Must be in the range 0x7f-0xff..

Information

Apktool Version (apktool -version) - 2.5.0
Operating System (Mac, Linux, Windows) - Same on all 3, tested on Windows, Linux and Mac
APK From? (Playstore, ROM, Other) - Stock ROM for Alldocube iPlay 30

Stacktrace/Logcat
root@dMe:/mnt/e# java -jar apktool_2.5.0.jar d framework-res.apk --use-aapt2
I: Using Apktool 2.5.0 on framework-res.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...

root@dMe:/mnt/e# java -jar apktool_2.5.0.jar b framework-res --use-aapt2
I: Using Apktool 2.5.0
W: Could not find sources
I: Checking whether resources has changed...
I: Building resources...
W: error: invalid package ID 0x01. Must be in the range 0x7f-0xff..
brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_1733501279999439899848001132792844792.tmp, link, -o, /tmp/APKTOOL9797823588068534639.tmp, --package-id, 1, --min-sdk-version, 29, --target-sdk-version, 29, --version-code, 29, --version-name, 10, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, -x, -e, /tmp/APKTOOL1126151149898017191.tmp, -0, arsc, --manifest, /mnt/e/framework-res/AndroidManifest.xml, /mnt/e/framework-res/build/resources.zip]

Steps to Reproduce

java -jar apktool_2.5.0.jar if framework-res.apk
java -jar apktool_2.5.0.jar if mediatek-res.apk
java -jar apktool_2.5.0.jar d framework-res.apk --use-aapt2
java -jar apktool_2.5.0.jar b framework-res --use-aapt2

Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
framework-res.zip
mediatek-res.zip
APK
If this APK can be freely shared, please upload/attach a link to it.
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? Yes
If you are trying to install a modified apk, did you resign it? N/A
Are you using the latest apktool version? Yes

Not sure what is going on there. You don't have the proper aapt2 patch - You can see clearly in my version of aapt2 we ignore this at this diff - https://github.com/iBotPeaches/platform_frameworks_base/blob/master/tools/aapt2/cmd/Link.cpp#L2263
➜  2503 apktool d framework-res.apk
I: Using Apktool 2.5.1-d1c006-SNAPSHOT on framework-res.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
➜  2503 apktool b framework-res --use-aapt2
I: Using Apktool 2.5.1-d1c006-SNAPSHOT
W: Could not find sources
I: Checking whether resources has changed...
I: Building resources...
W: warn: invalid package ID 0x01. Must be in the range 0x7f-0xff. Ignoring....

Now I did add new binaries after 2.5.0 here - https://github.com/iBotPeaches/Apktool/commit/d1c006b260f79c56b07566402f8f8c5607ff734d, so I'm going to mark this as already resolved in upcoming 2.5.1 release.

Not sure what is going on there. You don't have the proper aapt2 patch - You can see clearly in my version of aapt2 we ignore this at this diff - https://github.com/iBotPeaches/platform_frameworks_base/blob/master/tools/aapt2/cmd/Link.cpp#L2263
➜  2503 apktool d framework-res.apk
I: Using Apktool 2.5.1-d1c006-SNAPSHOT on framework-res.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
➜  2503 apktool b framework-res --use-aapt2
I: Using Apktool 2.5.1-d1c006-SNAPSHOT
W: Could not find sources
I: Checking whether resources has changed...
I: Building resources...
W: warn: invalid package ID 0x01. Must be in the range 0x7f-0xff. Ignoring....

Now I did add new binaries after 2.5.0 here - https://github.com/iBotPeaches/Apktool/commit/d1c006b260f79c56b07566402f8f8c5607ff734d, so I'm going to mark this as already resolved in upcoming 2.5.1 release.

Thanks for the reply. I have tried apktool 2.5.1 from master and from d1c006b. It now skips this check, but fails on the next part:
C:\Users\dMe\Desktop\Apktool\brut.apktool\apktool-cli\build\libs>java -jar apktool-cli-all.jar d E:\framework-res.apk
I: Using Apktool 2.5.1-d1c006-SNAPSHOT on framework-res.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...

C:\Users\dMe\Desktop\Apktool\brut.apktool\apktool-cli\build\libs>java -jar apktool-cli-all.jar b framework-res --use-aapt2
I: Using Apktool 2.5.1-d1c006-SNAPSHOT
W: Could not find sources
I: Checking whether resources has changed...
I: Building resources...
W: warn: invalid package ID 0x01. Must be in the range 0x7f-0xff. Ignoring....
W: brut_util_Jar_32370141877314231238117774743100399466.tmp F 01-30 14:19:33  9636  5304 PrivateAttributeMover.cpp:84] Check failed: priv_attr_type->entries.empty()
brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = -1073740791): [C:\Users\dMe\AppData\Local\Temp\brut_util_Jar_32370141877314231238117774743100399466.tmp, link, -o, C:\Users\dMe\AppData\Local\Temp\APKTOOL3508680140808951272.tmp, --package-id, 1, --min-sdk-version, 29, --target-sdk-version, 29, --version-code, 29, --version-name, 10, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, -x, -e, C:\Users\dMe\AppData\Local\Temp\APKTOOL2945910705051605782.tmp, -0, arsc, --manifest, C:\Users\dMe\Desktop\Apktool\brut.apktool\apktool-cli\build\libs\framework-res\AndroidManifest.xml, C:\Users\dMe\Desktop\Apktool\brut.apktool\apktool-cli\build\libs\framework-res\build\resources.zip]

After doing some research, I found this issue https://github.com/iBotPeaches/Apktool/issues/1668 which seems to be the same problem, if I am not mistaken? Sorry for re-opening this issue, but wasn't sure if I should open up a new one. Do I have to rebuild aapt2 with some changes, for it to treat private attributes differently?

Thanks for the reply. I have tried apktool 2.5.1 from master and from d1c006b. It now skips this check, but fails on the next part:
C:\Users\dMe\Desktop\Apktool\brut.apktool\apktool-cli\build\libs>java -jar apktool-cli-all.jar d E:\framework-res.apk
I: Using Apktool 2.5.1-d1c006-SNAPSHOT on framework-res.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...

C:\Users\dMe\Desktop\Apktool\brut.apktool\apktool-cli\build\libs>java -jar apktool-cli-all.jar b framework-res --use-aapt2
I: Using Apktool 2.5.1-d1c006-SNAPSHOT
W: Could not find sources
I: Checking whether resources has changed...
I: Building resources...
W: warn: invalid package ID 0x01. Must be in the range 0x7f-0xff. Ignoring....
W: brut_util_Jar_32370141877314231238117774743100399466.tmp F 01-30 14:19:33  9636  5304 PrivateAttributeMover.cpp:84] Check failed: priv_attr_type->entries.empty()
brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = -1073740791): [C:\Users\dMe\AppData\Local\Temp\brut_util_Jar_32370141877314231238117774743100399466.tmp, link, -o, C:\Users\dMe\AppData\Local\Temp\APKTOOL3508680140808951272.tmp, --package-id, 1, --min-sdk-version, 29, --target-sdk-version, 29, --version-code, 29, --version-name, 10, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, -x, -e, C:\Users\dMe\AppData\Local\Temp\APKTOOL2945910705051605782.tmp, -0, arsc, --manifest, C:\Users\dMe\Desktop\Apktool\brut.apktool\apktool-cli\build\libs\framework-res\AndroidManifest.xml, C:\Users\dMe\Desktop\Apktool\brut.apktool\apktool-cli\build\libs\framework-res\build\resources.zip]

After doing some research, I found this issue https://github.com/iBotPeaches/Apktool/issues/1668 which seems to be the same problem, if I am not mistaken? Sorry for re-opening this issue, but wasn't sure if I should open up a new one. Do I have to rebuild aapt2 with some changes, for it to treat private attributes differently?

I'll take another look.

I'll take another look.

@dumle11 why are you using the old build d1c006 3 Dec 2020?
The patch that fixes the problem Check failed: priv_attr_type->entries.empty() published 4 Dec 2020 https://github.com/iBotPeaches/platform_frameworks_base/commit/dab7c3e0f7c499d7eb0c850dd937191d017fe379 .
Are you doing this on purpose?

@dumle11 why are you using the old build d1c006 3 Dec 2020?
The patch that fixes the problem Check failed: priv_attr_type->entries.empty() published 4 Dec 2020 https://github.com/iBotPeaches/platform_frameworks_base/commit/dab7c3e0f7c499d7eb0c850dd937191d017fe379 .
Are you doing this on purpose?

@dumle11 why are you using the old build d1c006 3 Dec 2020?
The patch that fixes the problem Check failed: priv_attr_type->entries.empty() published 4 Dec 2020 iBotPeaches/platform_frameworks_base@dab7c3e .

That would require me to re-build aapt2 binaries? I am building apktool from source and it includes pre-build binaries that don't have this patch. Is this correct?

@dumle11 why are you using the old build d1c006 3 Dec 2020?
The patch that fixes the problem Check failed: priv_attr_type->entries.empty() published 4 Dec 2020 iBotPeaches/platform_frameworks_base@dab7c3e .

That would require me to re-build aapt2 binaries? I am building apktool from source and it includes pre-build binaries that don't have this patch. Is this correct?

@dumle11
Yes, you're right, aapt2 is still used without this patch.

@dumle11
Yes, you're right, aapt2 is still used without this patch.

@pashamcr first of all, sorry for taking so long to reply. Didn't have time for the past 2 days and started downloading AOSP yesterday, but didn't finish.
I have tested the binaries you have provided and now I can confirm I can successfully rebuild the framework-res. Thanks a milion for your help and have a nice week guys!

@pashamcr first of all, sorry for taking so long to reply. Didn't have time for the past 2 days and started downloading AOSP yesterday, but didn't finish.
I have tested the binaries you have provided and now I can confirm I can successfully rebuild the framework-res. Thanks a milion for your help and have a nice week guys!

I also have the same situation as you, although I used the latest version of apktool (2.6.1), but the problem still occurs, can you provide me with the binary file that solves this problem


JSON: support custom encode/decode without intermediate objects

The current support for custom encoding (toEncodable param and supporting toJson on classes) and decoding (reviver) deal with JSON literal types (String, num, Map, List, etc) requiring intermediate representations be created for all complex objects.
Propose to add three members (see below) to dart:convert and then update the JsonCodec, JsonEncoder, JsonDecoder classes to support then as alternatives to toEncodable and reviver.
Note: I don't expect devs to hand-write implementations of these types. Instead, code generators – such as json_serializable – could be updated to target the new API.
typedef WriteJson = bool Function(Object source, JsonWriter writer);

// Inspired by SDK code
// https://github.com/dart-lang/sdk/blob/e7bd3edc9f/sdk/lib/convert/json.dart#L513
abstract class JsonWriter {
  void writeObject(Object object);

  void startMap();
  void writeKeyValue(String key, Object value);
  void endMap();

  void startList();
  void writeListValue(Object value);
  void endList();
}

// Note: already exists in the SDK sources
// https://github.com/dart-lang/sdk/blob/e7bd3edc/runtime/lib/convert_patch.dart#L79-L101
abstract class JsonReader<T> {
  void handleString(String value);
  void handleNumber(num value);
  void handleBool(bool value);
  void handleNull();
  void objectStart();
  void propertyName();
  void propertyValue();
  void objectEnd();
  void arrayStart();
  void arrayElement();
  void arrayEnd();
  T get result;
}

Related issues:

https://github.com/dart-lang/sdk/issues/29750
https://github.com/dart-lang/sdk/issues/32476

See https://github.com/kevmoo/json_alt

CC @sigurdm, @szakarias, this might be relevant when handling jspb in the protobuf package.

Yes - exciting - I think an event-based json-parser would enable us to improve protobuf json-decoding (especially on the web).

Try package:jsontool for something like this.

package:jsontool looks neat! I read the planets example and skimmed the JsonByteReader implementation, and the API makes a lot of sense.
For me the key ingredient I'd need before I could switch to it would be something to generate the readJson methods. (Extra helpful would be to do so from package:json_annotation annotations, or something very similar, to ease the migration.) For a whole fleet of classes with a bunch of fields each, I don't really want to write those methods by hand… and I definitely don't want to review PRs that write them by hand, or that manually keep them updated when modifying the types. So I'd love to see something that does that. Perhaps a macro?


Quote Indication for 11ty-generated Dendron sites

Is your feature request related to a problem? Please describe.

no quote indication
Describe the solution you'd like
Add quote indication on 11ty-generated Dendron site.
Describe alternatives you've considered
add custom css, but it's quite a troublesome
Additional context
Thanks!

I've run into the same problem. For clarification, for others stumbling upon this issue, this is in reference to using > in markdown. This generally should apply some kind of modified formatting to the output of the text, as seen here:
This is a test of things. _Italic here._ **Bold here.** _**Bold italics here.**_

> Special formatting, such as for **Note:** type messages, or quotes.

Which renders as:
This is a test of things. Italic here. Bold here. Bold italics here.

Special formatting, such as for Note: type messages, or featuring quotes.


Sep 23 - Take the Boring out of Forms with Vue and Azure Static Web Apps

Event Information

Category
Details

Reactor Topic
Cloud Development

Monthly Topic (if applicable)
Skill Up September

Weekly Topic (if applicable)

Stream Topic
<2-5 words describing the topic>

Stream Date
September 23, 2020

Stream Time
9:00 am PST

Stream Duration
60 mins

Title
Take the Boring out of Forms with Vue and Azure Static Web Apps

Description
99% of the applications written consist of a form on top of a database. But you never see those kinds of apps in demos for new technology. Why? Because people think they are boring! In truth, they are a quick, easy way to create forms. In this stream, we'll build a data entry form using the Vue framework, store the data in a Cosmos DB, and deploy it to Azure Static Web Apps.

Speaker
Burke Holland

Moderator
TBD

SharePoint ID
7872

Additional Resources:

Event Checklist
10 Weeks Prior

[X] Reactor Content Team (RCT) or Speaker opens a new issue for an upcoming stream filling in the Event Information table. Both RCT and Speaker are marked as assignees.
[X] RCT and Speaker discuss details of the event in the comments of this issue. RCT adds a confirmed-event label and global-twitch-event tag to the issue and adds event to the Global Live Streams project. Issue will appear in the Upcoming Streams column
[X] Speaker adds a ready-for-marketing-edit label so the RCT can review title and description

8 Weeks Prior

[ ] RCT does a review of title and description and removes the ready-for-marketing-edit label
[ ] RCT moves the issue to the Ready for SharePoint column
[ ] RCT informs the Reactor Marketing Team of the new event information
[ ] RCT provides speaker with assets (e.g. slides, overlays) and the survey data for the event
[ ] RCT moves the issue to the MONTH Streams Prep column (according to the month it will be streamed in)

2 Weeks Prior (Done in /microsoft/Reactors)

[ ] Speaker opens a PR with the new content for the stream on the customer-facing Reactor repository and adds the content-development and global-twitch-event tag to the PR.
[ ] Speaker adds to the same PR a modification to the Streaming README to include their stream information.
[ ] Speaker adds the RCT assigned to the issue as the reviewer when it is ready for review/merge
[ ] RCT reviews, approves, and merges the changes

1 Week Prior

[ ] Speaker and Moderator test setup for streaming (instructions coming soon)
[ ] RCT checks in with the speaker and moves the issue to the Ready to Stream column

During and After Stream

[ ] Speaker and Moderator run the stream
[ ] RCT submits recording to be uploaded to the Reactor YouTube and to be made available on LearnTV
[ ] RCT moves issue to the Stream Complete column

Somehow this didn't get cancelled when we cancelled all the streams this week.
Cancelling/closing now.

This was for a CA - did we cancel all CA events as well?

My understanding from Golnaz is MicrosoftDeveloper is dark during Ignite

I reached out to Burke to get it rescheduled.

Oh that's right :) Sorry!


Update release.json

What does this PR do?
Update release.json
Motivation
7.59.1 is out
Describe how you validated your changes

Possible Drawbacks / Trade-offs
Additional Notes

/merge


Review class and method visibility

This needs to be done across the project.  I've noticed a number of classes and methods marked public that really should have restricted visibility.  For example, if an overridden constructor only exists to facilitate unit testing it should probably have default, package access so it doesn't pollute the public API.

While I'm at it, I intend to update Javadoc for public classes and methods .


What tools for facilitating the creation of xarrays from NEMO output files?

we could think of using something similar to :
mpas xarray wrapper

another question : naming convention for netcdf files after computation, especially for multifiles.

we might need to test the netcdf format of the file, see this xarray issue

Naming conventions for output netcdf files are probably out of the scope of oocgcm. This is probably more a matter for nemo command line diagnostic tools based on oocgcm. oocgcm should a priori only provide use case examples using xarray save_mfdataset.
Example (copied from save_mfdataset docstring):
>>> years, datasets = zip(*ds.groupby('time.year'))
>>> paths = ['%s.nc' % y for y in years]
>>> xr.save_mfdataset(datasets, paths)


increase sleep timeout to get transacation processed in a rinkeby network

After running some tests i noticed that 180sec is a good fit for a rinkeby network.

Thank you!!


beam search

Hello, I wonder if this repo support beam search? Thanks!

Hey @syp1997, right now it doesn't support beam search :)

closing this


Can the script be run from cloudshell - maybe advise either way?

Can we download and run this script using powershell in a cloudshell frame?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7fa9ce74-4cf1-7539-5ecb-ce9e5f71c469
Version Independent ID: 1cdb8e5b-bc96-0caa-8665-faed92e394c3
Content: Upgrade public IP addresses attached to a VM from Basic to Standard - Azure Virtual Network
Content Source: articles/virtual-network/ip-services/public-ip-upgrade-vm.md
Service: virtual-network
Sub-service: ip-services
GitHub Login: @mbender-ms
Microsoft Alias: mbender

@mckenzm
Thanks for your feedback! We will investigate and update as appropriate.

@mckenzm
Yes, you can download and run the script using PowerShell in a Cloud Shell frame. The script provided in the documentation is a PowerShell script, and Cloud Shell supports both PowerShell and Azure CLI.
Here are the steps to download and run the script in Cloud Shell:

Open the Azure portal and navigate to the Cloud Shell pane.

Select PowerShell as the environment.

Run the following command to download the script:
Invoke-WebRequest -Uri https://raw.githubusercontent.com/Azure-Samples/public-ip-upgrade-vm/master/upgrade-public-ip.ps1 -OutFile upgrade-public-ip.ps1

Run the following command to execute the script:
./upgrade-public-ip.ps1

This will execute the script and upgrade the public IP address of the specified virtual machine.

Note that you will need to have the necessary permissions to execute the script and upgrade the public IP address. Also, make sure to replace the values in the script with the appropriate values for your environment.

@mckenzm
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation


www/nginx: adjust some core scripts to make it compatible with exteral JS

This PR provides the possibility to store some json data in hidden fields so data is exchanged without messing a lot with the core API.

@AdSchellevis all your change requested should be included.

@fabianfrz looks good, thanks!


Rename  variable to $callable

The $handler variable is called $callable everywhere else, so it seems to make sense to rename it for clarity.

Do the handlers have a specific call signature that is important (types, parameters, return types) that makes them more than any generic PHP callable?
That's generally my personal naming reason for naming a callable anything but callable
I'll often phpdoc mark the special callable's signature somewhere and then use that unique variable name everywhere a specific callable type is used.  If only php had delegates (callable definitions)

Maybe take advantage of that type hinting and say "handler of type callable".
map(...  callable $handler){...}

Consistency with the PSR is kept. We know it's a callable because of its type and we know it handles that route because it's called "handler".

@unguul we can't use the callable type hinting as we are still supporting Slim 2 style Class:method callables.

@l0gicgate Good point. Thank you!
This makes $handler an even better choice then as $callable suggests the parameter is expected to be a php callable when that's not the case.
I suggest the following: Route definitions have handlers which can be php callables or Class::method strings, container keys, etc.
We stick to the PSR and we remove some potential for confusion. Win win.

This PR is no longer relevant, please re-open with updated interfaces if you still believe this issue should be addressed.


Gradle build failed to produce an .apk file. It's likely that this file was generated under D:\Flutter\Bloc Pattern Api Call\MovieApp-master\build, but the tool couldn't find it.

Every time i try to build apk file

Hi @abhi-cureore
Please provide full of the error message. And also the result of flutter doctor -v

D:\Softwares\flutter\bin\flutter.bat doctor --verbose
[√] Flutter (Channel stable, 1.20.4, on Microsoft Windows [Version 10.0.18362.1082], locale en-US)
• Flutter version 1.20.4 at D:\Softwares\flutter
• Framework revision fba99f6cf9 (2 weeks ago), 2020-09-14 15:32:52 -0700
• Engine revision d1bc06f032
• Dart version 2.9.2
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at C:\Users\Cureore\AppData\Local\Android\sdk
• Platform android-30, build-tools 29.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
X Android license status unknown.
Try re-installing or updating your Android SDK Manager.
See https://developer.android.com/studio/#downloads or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions.
[√] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 49.0.1
• Dart plugin version 192.8052
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[√] Connected device (1 available)
• Redmi Note 5 Pro (mobile) • 7f8cdc40 • android-arm64 • Android 7.1.1 (API 25)
! Doctor found issues in 1 category.
Process finished with exit code 0

Issue resolved after adding flavor  to development in edit configuration


WIP Shallow water bottom topography from splines

This is a work in progress draft pull request to incorporate spline and b spline interpolation for bottom topographies into trixi.

I pushed all my examples to its own folder called thesis. This is just an interim solution, until the final decision is made where to put my code.

I think this PR can be deleted?

Closing this as per @maxbertrand1996 and @andrewwinters5000.


tracing: support SDS for extracting backend token on Apache SkyWalking

Signed-off-by: Shikugawa<EMAIL_ADDRESS>
Commit Message: tracing: support SDS for extracting backend token on Apache SkyWalking
Additional Description: This PR allows to extract backend token via SDS.
Risk Level: Low
Testing: Unit
Docs Changes: Required
Release Notes: Required
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]  https://github.com/istio/istio/pull/35972#issuecomment-964749046
[Optional Deprecated:]
[Optional API Considerations:]

@Shikugawa ping me when CI passes.

@lizan Could you take a look?

@lizan @Shikugawa is this ready for final review ?

@lizan @phlax Yes. It has been waiting for review...

/assign-from @envoyproxy/envoy-maintainers

/assign-from @envoyproxy/envoy-maintainers

/assign-from @envoyproxy/envoy-maintainers

/retest

@Shikugawa can you look into the lowered coverage and also do an empty/dummy push to trigger coverage rerun? Thanks.

/wait on testing/coverage


Add list, tuple type support to maya.imprint() and other two minor tweak

Hi, I made some tiny changes, here's short brief:
1) avalon.maya.lib.imprint() add list, tuple type support

Motivation
Thought that would be nice to have imprint to create enum type attribute for us.
Example use case, choosing cache format (abc, gpu, fbx...) to export with pointcache creator.

Implementation
Implemented with Maya's enum type attribute.

2) Change the type of avalon.pipeline.Creator.data from dict to OrderedDict

Motivation
After adding some custom attributes into creator.data, those attributes visualized in GUI (Maya Attribute Editor) without order is not very comfort to see, custom attributes often mixed in core attributes.
Implementation
Use OrderedDict.

3) Larger creator icon border padding

Motivation
Some icon still get cropped with 2 padding.
Implementation
Bump to 4. :smile:

Please let me know what you think, thanks !

I think this is great.
Does the read also correctly read the new Enum value? What does it return in that case? An index or the string value that was chosen by the user? Should it return the string?

Thanks, @BigRoy !
read() in this case, will return the menuItem index of the value chosen by user.

Should it return the string?

Good idea ! The implementation of this only require adding asString=True to this line, won't affect other value type of attribute query.
In my current use case, returning int or str doesn't matter, but could improve log reading.

If asString doesn't break other queries then I think that'll be it and sounds like the best returned output.
Sounds good to me.

Yes! Tested it out, work like a charm :)

Let's do this.


React Build Fails Using Bootstrap SCSS v5.3.2

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
It should be noted that this issue wasn't encountered when running in localhost, only when I attempted to make a product build. By running npm run build-dev (our build script for inserting dev environment variables, same issue replicated with prod), the following error was encountered:
alexfromsocal@Stevens-MacBook-Pro % npm run build-dev

> <project name and location>
> firebase use dev && env-cmd -f .env.development.json npm run build

Now using alias dev (<project environment>)

> <project name and location>
> react-scripts build

Creating an optimized production build...
Failed to compile.

./src/assets/scss/theme.scss
ParserError: Syntax Error at line: 1, column 29

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! <project name> build: `react-scripts build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<project name> build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/alexfromsocal/.npm/_logs/2023-09-15T00_23_25_256Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! <project name> build-dev: `firebase use dev && env-cmd -f .env.development.json npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the <project name> build-dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      /Users/alexfromsocal/.npm/_logs/2023-09-15T00_23_25_299Z-debug.log`

Based on the given issue and what I had read on some other Github Issues and Stackover Flow posts, it may have regarded SCSS syntax of #{$my-variable-name} wrapping, as opposed to $my-variable-name.
Reduced test cases
I combed through the initial theme.scss file, commenting out every import. As I uncommented each import, I further reduced it down to this import: @import "~bootstrap/scss/bootstrap";. By not including bootstrap, my builds would complete.
In this node module file bootstrap/scss/bootstrap, I further narrowed it down to to the _pagination.scss file. Again, commented out the file and the program built.
FIX:
I found that by changing line 75 margin-left: $pagination-margin-start; to margin-left: #{$pagination-margin-start};, react-scripts built the app successfully.
SUGGESTED FIX:
Wrap the variable so that _pagination.scss line 75 is now margin-left: #{$pagination-margin-start};
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Chrome, Firefox
What version of Bootstrap are you using?
v5.3.2

I feel like this has come up a few times depending on the compiler. 🤔

I still have the same issue... changing line 75 of pagaination.scss doeesn't do the trick ! Still a
ParserError: Syntax Error at line: 1, column 29


awkward.argsort does not return correct types for None lists

Version of Awkward Array
1.8.0
Description and code to reproduce
ak.argsort does not return an index-type in the case that the input list array is full of None values.
>>> import awkward as ak
>>> ak.__version__
'1.8.0'
>>> x = ak.Array([[13.2, 14], [67.8]])
>>> x
<Array [[13.2, 14], [67.8]] type='2 * var * float64'>
>>> masked = ak.mask(x, [False, False])
>>> masked
<Array [None, None] type='2 * option[var * float64]'>
>>> ak.argsort(masked)
<Array [None, None] type='2 * option[var * float64]'>

Therefore if the resulting array is used for slicing, we get the following ValueError:
>>> masked[ak.argsort(masked)]

ValueError: only arrays of integers or booleans may be used as a slice

The expected behavior is:
>>> ak.argsort(masked)
<Array [None, None] type='2 * option[var * int64]'>

so that ak.argsort(masked) can be used for slicing.

ak.argsort does not return an index-type in the case that the input list array is full of None values.

You're right about that qualifier: it does work if they're not all None:
>>> import awkward as ak
>>> x = ak.Array([[13.2, 14], [67.8]])
>>> masked = ak.mask(x, [True, False])
>>> masked[ak.argsort(masked)]
<Array [[13.2, 14], None] type='2 * option[var * float64]'>

Just if every value is None:
>>> masked = ak.mask(x, [False, False])
>>> masked[ak.argsort(masked)]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jpivarski/irishep/awkward-1.0/awkward/highlevel.py", line 991, in __getitem__
    tmp = ak._util.wrap(self.layout[where], self._behavior)
ValueError: only arrays of integers or booleans may be used as a slice

(https://github.com/scikit-hep/awkward-1.0/blob/1.8.0/src/libawkward/array/NumpyArray.cpp#L3136)

Moreover, this is something that version 2 gets right:
>>> import awkward._v2 as ak
>>> x = ak.Array([[13.2, 14], [67.8]])
>>> masked = ak.mask(x, [True, False])
>>> masked[ak.argsort(masked)]
<Array [[13.2, 14], None] type='2 * option[var * float64]'>
>>> masked = ak.mask(x, [False, False])
>>> masked[ak.argsort(masked)]
<Array [None, None] type='2 * option[var * float64]'>

But we're still fixing bugs in version 1, so I'm looking into it now.

Ah, I missed an important bit of information that you gave me:

>>> ak.argsort(masked)
<Array [None, None] type='2 * option[var * float64]'>

Since this is the output of an argsort, it should have integer type. I bet the original floating-point type got passed through because something (an array of non-Nones) was empty. We've been cracking down on such "optimizations" in v2 because they can get the types wrong, like this. (In v2, it comes up because it makes Dask predict the wrong type.)

@jpivarski this is linked to the case I mentioned the other day, where we have a fast-path in the return.

Could you link that here? I don't remember it and I don't want to miss an issue.
Fast-path returns are bad, especially now with the type-tracer.

I can't remember if we ever opened an issue for it, but it looks like you've found it :) https://github.com/scikit-hep/awkward-1.0/blob/80579c7b67d508ea0c916b7b62a7dfe5826fe981/src/libawkward/array/ListOffsetArray.cpp#L1931

That's that this PR fixes. So if that was causing problems elsewhere, they'll be gone now.


How to use arrow keys?

I still didn't get it, how to use arrow keys. can I activate them somehow or do I have to press special buttons?

If the HK is open, they just work.  If you need to open HK when there's no text input, try the Use Permanent Notification :ballot_box_with_check: setting, which allows to open HK anytime.

AFAIR, arrow/cursor keys are only available in full 5-row mode (choose in Input Settings).

yes thats actually the problem what is bothering me, I really would like to use arrow keys in the small mode as well...

This is precisely why there's a 5-row compact mode.…  Try it!

For me the 5 row compact layout is too small. So if I want to use the arrow keys in normal mode I have to rotate the device to landscape mode, which is not very comfortable and means slow down. Would be possible to add third, e.g. numeric keyboard layout with arrows, e.g. it could work the following way.:

tap 123 key for numeric layout (this is how it works now)
hold 123 key for just numeric keyboard layout with arrows and maybe some special keys

There could be different mechanism for switching instead of the 123 holding.

Maybe, perhaps, an option to convert current kb's Fn layout to have large arrows in place of F1-F12?

It seems there are no FN keys in the normal portrait layout (or I don't know how to activate them). It would be great to have the FN keys together with the arrows somehow accessible from the normal portrait layout.


new cleaned notebooks - optimized for IETF lists

Notebooks produced during IETF101 hackathon. These notebooks are an improvement of the summerschool notebooks, and which were already largely a consolidation of other notebooks. So this should largely tackle
#271.
Perhaps we can move the other notebooks that are replace by this to an archive folder?

I'm beginning to review this change.
My first observation: these changes make new notebooks in subdirectories of the examples directory: examples/network_analysis, examples/threads_analysis, and so on. I believe these are modified versions of the notebooks named SummerSchool* in the top level examples directory.
As part of the effort to "garden" the notebooks #271 , I think this pull request should remove the SummerSchool notebooks, which these new cleaner notebooks make redundant.

I notice that these notebooks use the data-loading style of the summer school notebooks, which involves hard-coding the archive directory path into the notebook.
While I don't think it should block the PR, I want to note that ideally all notebooks will be changed to use the configured archive directory. See #113 and #309

I am having trouble running some of the notebooks for the mundane reason that I don't seem to have the right data in the right format in the right location.
Are there any kind of setup instructions associated with these notebooks?
Would it be possible to include a link to that documentation in the notebook themselves? Or else to include it as a README in the examples file?
If such a thing already exists and I'm blind to it, please forgive me.

@sbenthall do you mean you don't have the 6lo list for instance in the archives folder? notebooks should work with every list in there.

@sbenthall Agree on removing summerschool notebooks, and probably move the notebooks that are now in folders to the examples directory and change their names a bit. Anyone wants to jump on a call and brainstorm different ordering/gardening strategies?

I'm about to get on a plane to a conference. Meeting before Thursday would
be hard. But a meeting then would be good. Can we coordinate by email?
But to remove the Summer School files from your branch and add that change
to the pull request, you can use these commands:
https://stackoverflow.com/questions/2047465/how-can-i-delete-a-file-from-git-repo
I think this change can be made independently of the new archive directory
configuration.
On Mon, Apr 9, 2018, 8:37 AM Niels ten Oever<EMAIL_ADDRESS>wrote:

@sbenthall https://github.com/sbenthall Agree on removing summerschool
notebooks, and probably move the notebooks that are now in folders to the
examples directory and change their names a bit. Anyone wants to jump on a
call and brainstorm different ordering/gardening strategies?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/datactive/bigbang/pull/317#issuecomment-379736851,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEMkLfDWny3laScXVWLw-q_mAs0sMamks5tm1YZgaJpZM4S8vfB
.

Can this be pulled now, or are the still issues?

Yes, OK, I see that #324 addressed the question of the summer school notebooks. I'll merge this now.


[DOCFIX] change the docs/en/basic/Command-Line-Interface.md

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/915/
Test PASSed.


Rupan/market actor tests

Summary of changes
Changes introduced in this pull request:

Updating some Market Actor Logic
Implementing some Market Actor Tests
Misc updates to fix small issues

TODO :
5 of remaining Market Actor Tests depend on Storage Miner, will not be able to complete those tests until Storage Miner functionality is available
Clean up Warnings
Reference issue to close (if applicable)

Closes
Other information and links

Market Actor Logic got updated and they removed a function called HandleExpiredDeals and added a function called CronTick. I'm not sure if these do they same thing, or if there is a fundamental difference between the two.

TODO :
Implement the 5 remaining Market Actor Tests that depend on Miner Actor Functionality. They should be ready to go, just a few small changes. Leaving them as fails right now, so the PR can't be mistakenly added
Implement serialize functionality for VerifyDealsOnSectorProveCommitReturn. After @timvermeulen's PR comes in, it should be super easy to do. After this happens make small changes to Market Actor methods that use this.
Despite these things left I believe the rest is ready for review, So I'm updating the label for this PR

The submodule change needs to be updated then I'm good with this :)


Initialization Error

Problem/Motivation
See errors during ADD-ON startup
`[cont-init.d] 00-banner.sh: executing...
Hass.io Add-on: Docker Enabler v0.3.0
Grants an add-on access to the Docker socket
parse error: Expected string key before ':' at line 1, column 4
[11:25:47-0500] ERROR ----> Unknown HTTP error occured
From:
parse error: Expected string key before ':' at line 1, column 4
[11:25:49-0500] ERROR ----> Unknown HTTP error occured
By:
armhf / HassOS 1.11 / HA 0.79.3 / SU 133 / stable`
Steps to reproduce
Startup of add-on with default settings

I have the same issue.

Due to recent changes to Hassio, the add-on can no longer be used.
It has been removed from the add-on store.


Mod refringe-customraidtimes package.json main property points to non-existing file

Discord Username
GameArea.cz
What happened?
Mod is not working.
SPT Version
3.8.0
Server Log
Mod refringe-customraidtimes package.json main property points to non-existing file

and when I go to game for example factory still 20 minutes. And I used the override for all to 360 minutes.

Can confirm that, installed as usual

UPD. @GameAreaCZ, package.json states that main is CustomRaidTimes.js but it's customRaidTimes.js instead so in case sensitive systems it will fail

Resolved in v1.7.0


Add webdriver info in README

Add instructions to setup web browser and webdriver in README.

can ignore the website-pull-request-screenshot (datcom-ci) failure for now. It needs to wait for https://github.com/datacommonsorg/website/pull/290


[Bug]: Internal Failure when I try to install.

All of the following criteria must be met

[X] All Requirements must be installed.
[ ] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[x] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[X] Tried restarting PC.
[ ] Was able to see the Start Screen.

Describe the issue.
Whenever I try to install MelonLoader on to BONEWORKS it just says internal failure and makes a .txt file in my downloads
MLInstaller_22-1-18_13-38-40.771.log
Did you attach your log file?

[ ] Yes, I attached my log file to the text box above.
[X] No, I could not find a log file at {Game_Directory}\MelonLoader\Latest.log

Make sure you are using the latest installer.

All of the following criteria must be met

[x]  All Requirements must be installed.
[ ]  Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[x]  Tried reinstalling the Game.
[x]  Tried reinstalling MelonLoader.
[x]  Tried restarting PC.
[ ]  Was able to see the Start Screen.

Describe the issue.
Whenever I try to install MelonLoader on to BONEWORKS it just says internal failure and makes a .txt file in my downloads MLInstaller_22-1-18_13-38-40.771.log
Did you attach your log file?

[ ]  Yes, I attached my log file to the text box above.
[x]  No, I could not find a log file at {Game_Directory}\MelonLoader\Latest.log

Is this solved?

If no response is given in the next 24 hours I am going to assume this is solved and close the post.


Question about the number of frameskip of Franka Kitchen environment compare to LEXA.

Hello,
First of all, thank you for your fabulous work in the field of unsupervised skill discovery.
I have a question about the frame_skip argument of Franka kitchen environment.
In LEXA, they use frame_skip as 16
self._env =  KitchenMicrowaveKettleLightTopLeftBurnerV0(frame_skip=16, control_mode = control_mode, imwidth=width, imheight=width)

link
But I guess you use frame_skip as 40 https://github.com/seohongpark/METRA/blob/e08e76290ca7db7ecd0b4a0752383a17a7a536e4/lexa/lexa_envs/kitchen.py#L17
Do you have any reasons for that?
Thank you for reading.
Kind Regards,
Dongyeong Kim

Hi Dongyeong,
Thanks for the question.
40 comes from the default value defined at this line. I remember I tested both 16 and 40 in some of my previous projects, found 40 to be better than 16 due to the reduced horizon at that time (though in a different setting), and used the same hyperparameter for METRA as well.
For our experiments in this work, we used the same frame_skip and maximum episode length (50) for all methods including LEXA to ensure a fair comparison.

Hello,
Thank you for your kind answer!
Kind Regards,
Dongyeong Kim


Update install.sh

Enhancements and new features in this advanced version:
Custom Repository Support: This script allows specifying a custom GitHub repository with the --repo option. This is helpful for installing binaries from forks or alternative versions hosted on different repositories.
JSON Parsing for Tag Name: Instead of using grep and cut, this script uses jq, a powerful JSON processor, to parse the tag name from GitHub's API response. This approach is more reliable and readable.
Improved Platform Detection: The platform detection now explicitly supports arm64 and x86_64 on both Darwin (macOS) and Linux. It also provides a clear error message for unsupported platforms.
Error Handling and Cleanup: The script includes better error handling and uses a trap to ensure temporary files are cleaned up even if the script exits prematurely.
Verbose Installation Message: Upon successful installation, the script outputs a message indicating the binary's installation location.
Remember to install jq before running this script, as it's used for JSON parsing. This version aims to be more adaptable, robust, and user-friendly for various use cases.

The install.sh script has to be manually tested, so I think we want to do these as individual smaller PRs, instead of one big one, since they'll be easier to review.
Comments about the individual features:

Custom Repository Support: This seems good.
JSON Parsing for Tag Name: We shouldn't use jq, since it's an additional dependency, and grep and cut are always installed.
Improved Platform Detection: This sounds good.
Error Handling and Cleanup: This sounds good.
Verbose Installation Message: This sounds good.


Filtering option in Analytic is not working at all

Related to Issue #1144
On doing any action...selecting value on dropdown, adding text in field, clicking link. Always alert appear saying table can't be initialized.

@frenchbread Your PR #1245 will fix this bug, right? Should the issue be connected to your PR?


[WIP] Add basic metrics using prometheus exporter

The specs don't work currently because of webmock. I can just remove the specs or maybe there's a way to contain webmock to only the specs that need it?

Any ideas re: specs @agrare ?

@carbonin what if we setup the metrics in the bin script instead of from the collector?  That way we don't have to pass it in for most of the collector specs and the specs where you're checking metrics you can instantiate the server and pass in the metrics object?
Something like
begin
  metrics = TopologicalInventory::Openshift::Collector::Metrics.new
  collector = TopologicalInventory::Openshift::Collector.new(args[:source], args[:host], args[:port], args[:token], metrics)
  collector.collect!
ensure
  metrics.stop_server
end

@agrare I'm fine with that, but I don't think it will solve the webmock problem though ... right?

Would you need to do anything with the webmocks if the collector specs weren't hitting the metrics endpoint?  Or is the issue that having webmocks in any spec file cause issue?

Ah okay I see, if there's not a way to conditionally use webmock in spec files (checking now) then we'd have to drop the metrics spec I guess

Okay, @agrare I bailed on trying to make metrics work in the collector specs and added a double.


Use the Charge service remove method to refund a charge

I noticed that there is a kind of “helper” method on the Transfer service that creates a TransferReversal when calling the remove method on that service, and that has been nice to use. When either a charge or a transfer are refunded/reversed, that refund/reversal info is available on the charge/transfer itself without having to explicitly lookup the actual refund or reversal. That makes it quite nice to deal with a charge/refund and a transfer/reversal within the same service.

Closed via #63


Vanilla javascript table example on main website not working

TanStack Table version
v8.20.5
Framework/Library version
Vanilla Javascript
Describe the bug and the steps to reproduce it
The attached image shows the issue when trying to view the example of using tanstack table with vanilla JavaScript.
https://tanstack.com/table/latest
I think it might not work because there is not a vanilla example in the GitHub repository. 2nd image shows all examples are there except for the vanilla JavaScript example.
Your Minimal, Reproducible Example - (Sandbox Highly Recommended)
https://github.com/tanstack/table/tree/main/examples/vanilla/basic
Screenshots or Videos (Optional)

Do you intend to try to help solve this bug with your own PR?
Yes, I think I know how to fix it and will discuss it in the comments of this issue
Terms & Code of Conduct

[x] I agree to follow this project's Code of Conduct
[x] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

I reported this a month ago, but @KevinVandy closed it as completed the day after - without any details of why. Seemed a bit premature, given that nothing was done, but I assumed a fix had already been merged somewhere else and was waiting to get published. Seems I was wrong?

2 vanilla examples have been contributed


You can only call finish() on a span once

I got this error:
JAEGER ERROR operation=a606ec7f53b3a4767a14fb134b648003-164176fd6fc21a2a.elb.us-east-1.amazonaws.com/api/v1/roles,context=6e8567e0b4adb68d:6e8567e0b4adb68d:0:1#You can only call finish() on a span once.

I got this error:
JAEGER ERROR operation=a606ec7f53b3a4767a14fb134b648003-164176fd6fc21a2a.elb.us-east-1.amazonaws.com/api/v1/roles,context=6e8567e0b4adb68d:6e8567e0b4adb68d:0:1#You can only call finish() on a span once.

every span need to be close by calling finish(),seems call more than one time.
can u paste ur code, lets check for it?

Nothing special about the code. I was just playing around with the code example in the README and it's similar to the one below:
import { NestFactory } from '@nestjs/core';
import { AppModule } from './app.module';
import {JaegerInterceptor} from '@chankamlam/nest-jaeger'
async function bootstrap() {
  const app = await NestFactory.create(AppModule);
  const config = {
    serviceName: 'service1-nest',
    sampler: {
        type: "const",
        param: 1
    },
    reporter: {
        collectorEndpoint: "http://localhost:14268/api/traces"
    },
};                                             // required
const options = { baggagePrefix: "-Johua-" };  // optional,you can let options={}

Could it be somehow related to this? https://github.com/opentracing-contrib/javascript-express/issues/16

Could it be somehow related to this? opentracing-contrib/javascript-express#16

[1]if u do not open a new span under master span which auto create by any requests do not have to call span.finish()
because package had auto called the finish() method for u, lets look at the source code below:
return next.handle().pipe(
  tap(() => {
    // handle respose callback
    if (this.res_cb) {
      this.res_cb(req, res);
    }
    //mark default tag of response
    req.jaeger.setTag("response.state", res.statusCode || UNKNOW);
    req.jaeger.setTag("response.result", res.statusMessage || UNKNOW);
    req.jaeger.finish();
    ///////////////////////////////////////////////////
  })
);

[2] if u manually create span which meant u need to call finish(),lets look at the code below
const childrenSpan = req.jaeger.create('childrenSpan')
childrenSpan.log("xxxxxx","xxxxxxxx")
childrenSpan.setTag("error",true)
childrenSpan.finish().                 // if did not call finish() that will have no record send to collector of jaeger

Could it be somehow related to this? opentracing-contrib/javascript-express#16

he is question is about using express to integrate with jaeger, this package is about nest-jaeger.


[LinkService] PUT /core-model-1-4:network-control-domain=cache/link={uuid} doesn't show correct error response for wrong requestBody (Lab)

When I try to put some link data with wrong requestBody, the link is not written to the cache, but instead of an error response I get a 204:

I observed this behaviour in the lab.
There should be an error response.
When I sent some requests in the last weeks for testcase creation I saw somehing like the following for the link-port service with an invalid requestBody (I would have excepted to see the same for the link service):

{
"code": "400",
"message": "request.body['core-model-1-4:link-port'][0] should have required property 'local-id', request.body['core-model-1-4:link-port'][0] should have required property 'link-port-direction', request.body['core-model-1-4:link-port'][0] should have required property 'logical-termination-point', request.body['core-model-1-4:link-port'][0] should match exactly one schema in oneOf",
"errors": [ ]

I retested this and now I see a 400, if the requestBody is invalid. I.e. issue solved.


Inode refactoring again

I took the bet that modifying the strings passed to Repr wouldn't break anything anywhere. I can always revert these strings to their former values. You tell me.
I will apply ocamlformat and squash the commits just before the merge.
Highlight
I renamed inode/Inode/inodes/Inodes to inode_ptr/Inhabited/branch/Branch.
I collapsed the Bin.node and Bin.inode constructors to a single Bin.v ~stable. The node/inode naming here didn't make much sense. Same in Compress.
I have added many _t suffixes on values of type Repr.ty.
I improved several strings passed to Repr.
Suggestions
If you're alergic to inhabited, I can do populated or occupied instead...
I could also have renamed entries to buckets and several occurences of values to leaves, but I felt it wasn't that critical.

I am not convinced by the new names. What are the issues with the existing ones?

I am not convinced by the new names. What are the issues with the existing ones?

(recap of what I said on slack)
As with the first refactoring PR where I renamed one of the Val modules to Val_impl, the goal of these renamings is to have fewer occurrences of the term inode.
The reason why I'm so eager to rename Inodes into something else is that what I informally call an inode is value of type Val_impl.t, not an Inodes tag. But that's up for debate!
The 3 renamings:

I found Branch in the Ethereum wiki https://eth.wiki/fundamentals/patricia-tree.
Val_impl.inode_ptr because it's a pointer to a Val_impl.t.
Inhabited, the least worst solution I've found.

(recap of what I said on slack)
As with the first refactoring PR where I renamed one of the Val modules to Val_impl, the goal of these renamings is to have fewer occurrences of the term inode.
The reason why I'm so eager to rename Inodes into something else is that what I informally call an inode is value of type Val_impl.t, not an Inodes tag. But that's up for debate!
The 3 renamings:

I found Branch in the Ethereum wiki https://eth.wiki/fundamentals/patricia-tree.
Val_impl.inode_ptr because it's a pointer to a Val_impl.t.
Inhabited, the least worst solution I've found.

Maybe also rename: seed into depth where that makes sense.

Maybe also rename: seed into depth where that makes sense.

AFAICT we are done here. Can someone experimented with Repr check that I didn't break anything?

AFAICT we are done here. Can someone experimented with Repr check that I didn't break anything?

I'll squash and merge in the afternoon

I'll squash and merge in the afternoon


Error when signal already aborted

Fixes #401

Excellent - thanks for the report and the fix. Will release now

Please, do you mind to publish in npm? apparently it's only released in github bot not in npm.

Failed linting on master for some reason. Will fix tonight

released this yesterday. Sorry, forgot to let you know


Ensure requirements and README.md is packaged

Should fix https://github.com/hammerlab/cohorts/issues/144 and avoid a error doing install about a missing README file

LGTM, nice!

Going to tag a 0.3.0 with all the updates and see if this was fixed, sound good? @tavinathanson @jburos

Sounds good to me!


Improving the Quickstart user experience

As I am drafting up the quickstart tutorial for O3DE, I'm noticing that there are quite a lot of steps. It would be great if we could condense them a little, but I'm not sure what's possible with the engine.
Here are the current steps involved in this getting started tutorial. As far as I know, they are all necessary or else highly recommended to be able to visualize terrain in the engine. Would be great to discuss what we might be able to pare down.
Step 1: Install the gem
This is the same as the developer setup on the readme of this repo. We could potentially exclude it from the Quickstart.

Clone the repo
Navigate to the External folder
Create a new folder called Build
Use CMake to build Cesium Native
Open the System Properties panel
Click on Environment Variables
Create a new User Variable with the filepath to your local cloned directory

Step 2: Create your project and add the gem

Open the O3DE Project Manager
Click the New Project… button and select Create New Project
Name your project
Click the Configure Gems button
Click the hamburger menu and select Add Existing Gem
Navigate to the directory you previously cloned
In the Gem Catalog, scroll down or search for the Cesium gem and enable it
Click Create Project
Rebuild project
Open project
Wait for the Asset Processor to finish

Step 3: Connect to Cesium ion

Click the Cesium icon
Click the connect to Cesium ion button
Log in to Cesium ion

Step 4: Set up your level

Create a new level
Hide or delete the “Ground” from the Atom Default Environment.
Click on the Level entity in the entity outliner. Add component - level coordinate transform
Right click on the level in the entity outliner, create a new entity
With the new entity selected, click on the quick add georeference component button in the cesium ion panel
Click on the new georeference. Change “Origin Type” dropdown from Cartesian to Cartographic.
Add the following coordinates:
Longitude: -105.25737
Latitude: 39.736401
Height: 2250.0
(This sets the georeference location to the same as the default in Cesium for Unreal)
Click the “Set as level georeference button”
Right click on the level in the entity outliner, create a new entity
With the new entity selected, click on the quick add CWT+bing in the Cesium ion panel. You will now see Cesium World Terrain.

Step 5: Adjust your camera
These steps are not necessary to visualize a tileset, but are still part of the quickstart so that users can learn the nuances of the interface.

Select the Camera object in the Entity Outliner
Set move speed to 100 (this is apparently the max)
Change the far clip distance to 100000000.0 m
Click “Be this camera”
Move around with WASD. Hold down the left shift key to move faster.

Where can we speed up this process? Some ideas:

Installation

Can we make builds of the gem so that users don't have to clone the repo, build Cesium Native, etc and the user can just download a zip?
Is there a way to avoid adding an environment variable?
Can we use the "Gem Repos" system?

Plugin functionality (please advise on whether or not these would be possible to do, I don't know so I'm just spitballing.)

Is there any way to add a Level Coordinate Transform automatically to the level entity? Maybe the first time we add something from the cesium panel, we could check to see if it exists, and if not, add it. As far as I know, every level with a cesium tileset will need it to work, so we should try to add it automatically.
Can we automatically delete the default ground plane? I think that would just save time, and I doubt many users will need it, plus it gets in the way of viewing the tilesets if you haven't figured out how to move the editor camera.
Can we have georeferences start with Cartographic coordinates by default, and include a default longitude/latitude/height? Otherwise, this adds more steps before users can visualize a tileset. Also, it makes it more in line with the Cesium for Unreal workflow, and teaches you how to view terrain without adding a location-specific tileset.
Can we automatically tweak camera settings, such as adjusting the move speed and changing the far clip distance? Those are settings that all users will likely want in order to see their tilesets.

Perhaps for all the plugin functionality steps we could add a button like "Use suggested level setup" that users could just press that would make all those changes automatically. This would significantly speed up the process. Is that something that would be possible?

Below is the plan to automate some of the steps:
For step 1 install the gem: 1->4 can be automated by downloading the binary from github CI similar to Unreal
For step 2: that's probably needed
For step 3: same as step 2
For step 4 Set up level:

cleaning up the unneeded entities (ground, shader ball etc) is probably needed by user.
Level georeference is replaced by Origin Shift, which I think I can automate it, so user doesn't need to add it to the level.
Add default value for Origin Shift
I can create an entity along with 3D Tiles component too, so the step for right clicking and add new entity probably isn't needed

@argallegos I think some of the improvement suggested above are in main now

For step 4, it should be just one step now by adding CWT and that's it.
For step 5, user only needs to adjust editor camera speed. Camera far clip is set to be very high by default
The plus button in quick-add will automatically create new entity, so right click and manually add a new entity is not longer needed


Quick update from main

⚠Warning! This diff contains changes in protected folders

⚠Warning! This diff contains changes in protected folders