CNF-14138: makefile: Fix bundle-build and catalog-build targets

/cc @donpenney @irinamihai

/lgtm


tagging code prevents compression with cite package

By default, the cite package prints consecutive references like "1-3". If the tagging code is loaded, it instead behaves like the options nocompress,nosort are loaded.
\DocumentMetadata
  {
    lang=en-US,
    pdfversion=2.0,
    pdfstandard=ua-2,
    testphase={phase-III,math,title,table,firstaid}, % comment this to compare
  }
\documentclass{article}

\usepackage[
  super,ref,
  ]{cite}
\usepackage[]{hyperref}

\begin{document}
text \cite{inbook-full,article-full,mastersthesis-full}

\cite[postfix]{inproceedings-full}

\citen{proceedings-full,phdthesis-minimal,inbook-full}

\bibliographystyle{plain}
\bibliography{xampl}
\end{document}

I think that makes it partially-compatible with some work to do


Issue with simple dropdown menu inside vertical menu

See: http://jsfiddle.net/rjx4qmsv/
Place your mouse cursor over "Tags" (h2), and then move it in a downward direction. The drop down menu will be displayed, because it has a border which is hidden with opacity: 0.
Does it not make more sense to use display: none?

Hi, 2.x branch does not show your issue with the ui menu rewrite.
http://jsfiddle.net/bhgbfshf/
In order for css opacity transitions to work they must occur from an element with already has display. This is why we place a simple dropdown offstage using left instead of using display: none

Thanks Jack! :smile:


Add AppCompat styles to default styles

Fixes the issue highlighted at the end of #130

Only concern is that android.R.attr.checkedTextViewStyle is a API 17 attr, but should compile fine since it is a constant as long as your compileSdkVersion is higher correct?

The attribute will compile. But as those classes can be accessed during lookup, If you didn't have the v7 lib, it will crash.

What it should really do is do a reflective lookup on start and add it to the default map if it can find the v7 stuff on the classpath (See how it does it with the toolbar check).

Will do, just saw the toolbar check as well. Thanks!

Do you think I should:

check each individual widget before adding it to the map
look for one of the specific AppCompatTextView and assume the rest are there
piggy-back off the Toolbar class check and assume the rest are there because they are contained within AppCompat

Not sure if I'm over thinking it and should just go with the last option and rename the method to be a more general AppCompat check (while still looking for just Toolbar).

I would check for one of the AppCompat* classes, probably AppCompatTextView as it would be a fairly safe assumption that the rest are there.
I can't remember if they were added at the same time, but I think AppCompat* were added after the Toolbar?

Should be good to go now.

Cool, much better, I would do the lookup inside the static method (for the cases where you might create multiple configs):
static {
 DEFAULTMAP.add....
 if (CalligraphyUtils.canAddV7AppCompatViews()) {
            addAppCompatViews(tempMap);//etc...
        }
}
``

Switched over into the static initialization.

Just pushed a 2.1.1 snapshot with this.


Fix example data ingest

fetch_mldata may need to be replaced with fetch_openml

BTB version: 0.2.5
Python version: 3.7
Operating System:   Ubuntu 18.04.1 LTS

Description
When trying to run some examples I ran into trouble with the MNIST download. It seems mldata.org has been down for quite a while and it's been replaced by openml.org.
I think sklearn.datasets.fetch_openml is meant to replace the old API.
What I Did
In running BTB\examples\random_forest.py
This is the code that is having trouble and a best guess at a fix
from sklearn.datasets import fetch_openml,fetch_mldata
#mnist = fetch_mldata('MNIST original')
mnist = fetch_openml('mnist_784')

Closed via #128


Add cypress tests for Gateway-Policy feature UI

Purpose
To enhance the quality and reliability of the Gateway Policy feature by introducing UI tests. These UI tests are designed to validate the functionality, user interactions, and edge cases within the Gateway Policy feature's user interface
Goal
Test the UI implementations related to: https://github.com/wso2/api-manager/issues/1710
Description

After fixing latest review comments:

For Reviewers, please note that the newly added test case is passing:


[enhancement]: add support for batch model adding and adding non-standard checkpoint models

Is there an existing issue for this?

[X] I have searched the existing issues

Contact Details
No response
What should this feature add?
1)in the model manager, after scanning a model folder, i should just be able to quick add all of them with 1 button instead of adding them 1 by 1.

it doesnt seem to be possible to add non-standard checkpoint models at all (Controlnet lora ipadapter etc), this makes it very difficult to use invokeai with models from other web ui

Alternatives

Additional Content
trying to import my models from a1111 webui and i dont want to waste disk space by copy pasting everything into my invokeai models folder.

Noted on Enhancement 1!
Re: 2 -- Invoke uses Diffusers models, and will convert your models directly into the Diffusers format in order to function. You'll have to live with dupe models (i.e., disk space) if you want them all in both systems.
CC: @lstein / @Millu  - Reported that local controlnets/ipadapters arent being converted. Wonder how we might solve for that in the model probe/conversion 🤔


Unable to overwrite default key bindings

Steps to reproduce the problem:

Enter the following into ~/.mitmproxy/keys.yaml, expecting the
effect to be that n gets bound to console.nav.down:
 -
   key: n
   cmd: console.nav.down

Start mitmproxy

Press n

Observe that n is still bound to console.command view.create get https://example.com/,
as per https://github.com/mitmproxy/mitmproxy/blob/master/mitmproxy/tools/console/defaultkeys.py#L61

Any other comments? What have you tried so far?
This seems to be a conflict between the implemented behaviour and the
expected behaviour (At least my expectations).
My motivation for this possibly unanticipated key binding is that I'd
like try and make bindings similar to the defaults of emacs dired
mode, which would make mitmproxy easier to use for me.
With a few hints on where to fix this and some guidance, I'd be happy to try and do it my self.
System information
Mitmproxy: 4.0.3 (+9, commit d08c9cf)
Python:    3.6.5
OpenSSL:   OpenSSL 1.1.0h  27 Mar 2018
Platform:  Linux-4.8.0-53-generic-x86_64-with-debian-stretch-sid

@kidmose Hello! Thanks for the report.
Yes, it seems, that key bindings from defaultkeys.py have priority over the key bindings from ~/.mitmproxy/keys.yaml.
I checked your key binding. It worked for all contexts except flowlist, since it is set by defaultkeys.py. The temporary solution is to set n key binding like:
 -
   key: n
   ctx: ["global", "flowlist"]
   cmd: console.nav.down

explicitly changing key binding for the context(s), which is set by defaultkeys.py.

Thanks for the temporary solution. I can confirm that it works.

I think user keybindings should overwrite defaultkeys, right?

fixed by #3340


[otbn] Document and implement (in the ISS) alerts for x1 underflows/overflows

This PR has three commits. The first is a tiny tidy-up, needed to get the mypy flow working for the ISS changes. The second commit slightly restructures our documentation for the GPRs, and tries to fully explain how x1 works. The final commit teaches the ISS to generate this sort of error and adds a couple of tests to make sure it works.
This is the first two parts of #3239.

Note: This conflicts with #4255 (the merge will be fine, but the links to JAL and JALR will be broken). We'll need to do a manual rebase to fix whichever PR lands second.

Force-push fixes links after rebasing over #4255.


Generated markdown must have same section structure

No matter what the order of the sections in the input is, the generated markdown should always present the same one.
For example,
# Name
# Summary
# Description
# Metadata
# Shape (or Entries)

Same thing with all entries in Metadata section

# Name
# Summary
# Description
# Metadata
# Shape (or Entries)

What all fields could be optional? To be specific, it is compulsory to have Summary/Description/... section in Classes and same for the Properties and Vocab ?

Yes, I'd think so...
At some point we need to have Summaries and Descriptions; otherwise, for example, ISO-formatted documentation will not be able to be generated.

We can start by having all sections mandatory and in order

This can be closed, it has been implemented for a while


Add support for post-assessment Webhook

What would you like to be added:
Add functionality to allow for calling a user defined endpoint for policy failures (possibly passes as well).
Not sure if the granularity should be a single global configuration for a MagTape installation, different endpoint per policy, etc.
should be bypassed if no config is provided
should have a timeout value and should not cause a failure in the policy assessment if the call to the endpoint fails
ideally this can happen asynchronous and be non-blocking to the end-user request
Why is this needed:
to allow for integration with existing systems for alerting/reporting

Would be nice if this could become a sort of pluggable interface allowing users to define the specific endpoint, a templates request, and expected response.
If this is done, the existing Slack alerts may be able to be migrated to this pluggable interface

In the past we'd talked about a gRPC-based sidecar service to enable offloading of the alerting work from the primary MagTape.

create a protocol buffer definition for message/alert "type" and service (proto3)
implement sidecar which implements the service (go?)
implement the python client functions to build a message/alert from a policy result and offload messaging to the gRPC service

If we still fancy exploring this route I think we can begin work on the protocol buffer piece and try to get an idea what the API's input and output may look like.

Sounds good. Assigning to you @ilrudie . Reach out whenever you want to sync on this.


How can I add contacts (owners and experts) to an asset?

Hi @wjohnson
We are trying to add some contacts to an asset, that we already know the expert and owner IDs.
Is there any way to do this? Our expectations is to add contacts as we can add classifications using "client.classify_entity".
I don't know, is there something like "client.add_contacts" and passing the list with experts and owners in parameters?
I'm doing like this:
input01 = AtlasEntity(
                name="MTCCARLT",
                typeName= "azure_sql_table",
                qualified_name= <qualifiedname>,
                guid= <guid>,
                contacts=asset["contacts"]
            )

This "asset["contacts"]" have this structure:
{'Expert': [{'id': 'assetid'}], 'Owner': [{'id': 'assetid'}]}
But it doesn't edit properly when I run client.upload_entities(input01)
This asset already exists on Purview, what I'm trying to do is add Owner and Experts on it.
Thank you very much!

@IagoFranco I think my internal notes are a bit confusing on this, sorry about that.  Take a look at the docstring and not the inline comment.
:param dict(str, dict(str, list(dict(strt,str)))), optional contacts:
        Contacts should contain keys Experts and/or Owners. Their values should
        be a list of dicts with keys id and info. Id is a microsoft graph
        object id. Info is a string of extra information.

If your assetid isn't a valid AAD object Id representing a user, it will fail to appear in the UI.
Please let me know if assetid is an object id and you're still not getting what you're looking for.
This is related to the work I want to get done on #86 but I haven't had the time to figure out the Microsoft Graph API calls :-(

Hi @wjohnson
Thank you so much for your support.
I'm actually copying from another asset that has contacts configured, so the ID for the user is valid.
I still can't make it work, please see if you can help me:
This is my code:
input01 = AtlasEntity(
                name= entityHom["attributes"]["name"],
                typeName= entityHom["typeName"],
                qualified_name= entityHom["attributes"]["qualifiedName"],
                guid= entityHom["guid"],
                contacts= prdAsset["contacts"]
            )

            result = client.upload_entities(input01)

The structure for "prdAsset["contacts"]" is:
{'Expert': [{'id': 'a4f441db-bb61-44f4-9ba8-d67eb127a112',
'info': 'Data Steward'}],
'Owner': [{'id': '5772e578-6c4a-4d51-8283-7c9b60e4a5e2',
'info': 'Data Steward'}]}
Am I doing something wrong? Could you give me an exemple of what I need to do?
Thank you!!

Here's a working basic example.  Your syntax looks right!  I'd ask for you to double check on those guids and be sure they're real object ids in AAD.  Maybe try creating an asset like the one below with those ids and if that fails, I'd suggest a support ticket unfortunately :(
_ae = AtlasEntity(
    "entitywithcontacts",
    "DataSet",
    "entitywithcontacts",
    guid=-1,
    contacts={
        "Expert":[{"id":"f123-xxx-yyy-zzz-123", "info": "This is Will"}],
        "Owner":[{"id":"f123-xxx-yyy-zzz-123", "info": "This is Will as an owner"}]
    }
)

results = client.upload_entities(_ae)

print(json.dumps(results, indent=2))

Hi @wjohnson
I'm doing like this:
input01 = AtlasEntity(
                name= entityHom["attributes"]["name"],
                typeName= entityHom["typeName"],
                qualified_name= entityHom["attributes"]["qualifiedName"],
                guid= entityHom["guid"],
                contacts={
                    "Expert":[{"id":"a4a841db-bb662-44n5-9aa8-d67eb127a112", "info": "This is Will"}],
                    "Owner":[{"id":"5772e488-6c6a-4d18-8253-7c9b60e4a5e2", "info": "This is Will as an owner"}]
                }
            )

            result = client.upload_entities(input01)

I've change with your suggestion, I just include the ID, the info is the same.
But I'm getting: {'mutatedEntities': {}, 'guidAssignments': {}}
It seems that this information is beeing ignored.
This supports for assets already created, because what I'm trying to do is updating an asset that is already scaned.
When I try to update "description" field, it works with this model, but not the contact information.
Do you have any thought on why this is happening?

Oof! What version of PyApacheAtlas are you running on?
The contacts attribute is only available on 0.5.0 and would silently ignore the contacts attribute in earlier versions.

@wjohnson
OMG, I can't believe it was exacly that!
I was running on 0.4.1 version :S
Now it's working, sorry about that hahah
Thank you very much!

Huzzah!  I'm glad it's working now!!!
Thank you for continuing to use the library!!


Feature/FE-10

Added the necessary functionality so that pages always open from the top when opened.
Improved @sinemKocoglu 's profile page skeleton as much as I could. The main changes I made are the following: changed the gallery grid system, made minor changes to the color palette, redesigned the bio and redesigned the whole page to be compatible with different screen sizes. See #241
Created reset password modal interface both for guest users and registered users. See #257 and #260
Created a settings page where registered users can edit their names, bios, locations and most importantly profile photos. Following crucial actions have been taken with @KarahanS.

Figured out how to do image preview.
Figured out reducing the sizes of images before sending them.
Figured out the connection between frontend and AWS S3 private bucket. (for image display)
Figured out base64 encoding before sending images.
Figured out how to send conditional data through JSON.

Note: I would like to thank @sinemKocoglu  for the profile page skeleton and @KarahanS  for helping me with all the problems I had with uploading images.

Looks good to me! Please notice that we have to configure the environment variables for production site as well.


Does not work with Hogwarts Legacy

Installing this does nothing. It does not work at all. Mods don't load. F10 does not open a console. Is this even updated? Has this even ever been functional? If so, please tell us how, because the descriptiuon you have is useless

Your issue report does nothing. It tells us nothing at all. The description of the problem you have is useless.

How do I install it? I have download all files and placed them in my steam game folder
It does not work. Why can't you just tell people how to install it? What do I need to do to make it work?


Create arangodb product

Let's see if we should add the database tag:

https://github.com/endoflife-date/endoflife.date/issues/4291

I think a db tag is created for the db category so it would be redundant to also add a database tag.
An alternative proposal could be to change db category to database instead, to avoid any confusion about the db acronym?  That would be a larger scope change outside of this PR though.

Found https://arangodb.com/subscriptions/end-of-life-notice/ to get exact EOL dates. Also added all releases from 2.8 to 3.9, and the auto config.
LGTM now, merging. Thanks a lot @rossmills99 for this contribution !

Great stuff, thanks


Replace SimpleMDE with custom editor

SimpleMDE, the library we're currently using to provide a markdown editor (ie: commands that insert md symbols and style hooks in codemirror) is incredibly bloated for our purposes. It comes with a wonky toolbar that we have to disable and stop it importing font awesome, it comes bundled with its own parser (for previews) which we don't use, and it's just generally a kitchen-sink when we only need the faucet.
Much better would just be to fork our the JS commands/plugins they've added to codemirror into our own thing. We've already got the toolbar and custom reading time status, would just be adding basic styles for formatted things.

Closing in favour of #18


Does not include .tsx deps when extension in import statement

Thanks for the tool - I'm trying to run this over a react/typescript project with many .tsx dependencies.
Unfortuantely it seems the tool misses out when we import a tsx file without specifying the extension.
E.g. we have a file called SurveyVideo.tsx, and another file that imports it:
// Does not include SurveyVideo.tsx in the dep graph
import * from "./SurveyVideo";

// Works
import * from "./SurveyVideo.tsx";

Can we get around this with the current config or is this a bug?

Hello, thanks for reporting the issue @amized !
It's indeed not a bug nor a configurable thing, it's just a part of module resolution spec that was not implemented yet 🤦🏻♂
TSX/JSX support from Skott is pretty new so there might be other issues, feel free to report them as well :)
By the way, I'm already working on a quick implementation to resolve that issue. This will be included in a patch release tonight or tomorrow.

@amized I just released a patch version 0.19.1 that should fix the module resolution problem.
Could you please try with it and let me know if that fixes the issue? Thanks

hi @antoine-coulon I just tried again, now it's not picking up any imports:
$ skott --fileExtensions=.ts,.tsx src/pages/_app.tsx

Hello @amized, could you please share a repro of your project or at least paste the content of your src/pages/_app.tsx?
I can't reproduce that behavior on a project I got locally running with Next.js and TypeScript
Thanks!

@amized
It could also be to a tsconfig issue if you're ever using path aliases. Could you also paste it there to make the troubleshooting easier?
You might also want to try skott --fileExtensions=.ts,.tsx src/pages/_app.tsx --trackThirdPartyDependencies to check if some alias are considered third-party by Skott (which might be the case when path aliases could not be resolved correctly)

Closing this as the problem should be outdated with latest releases. Feel free to re-open the issue if the problem persists


FlexSlider JS - directionNav shows even if there's only one slide

bug with FlexSlider? or our config?

This works correctly in a base install. Closing for now


zipfiles library does not work with Unicode.

Problem
zipfiles library does not work against a filename with Unicode(multibyte character).
(ex : 【αβγ★】.zip)
Temporary solution
I tried sending WideCString in nim and recieving wchar_t pointer in C at calling 'zip_open' in libzip_all.c library.
(have to fix zipfiles.nim, libzip.nim, and libzip_all.c)
It seems looks working fine.
But, this solution is maybe only valid in 'zipfiles.open' on Windows platform.
Permanent solution
How to comply with Unicode as a whole ?
Please give me a hand...

Is that even fixable on our side? Nim supports Windows Unicode filenames just fine, it must be in the C code. And wchar_t shouldn't be required.

Ok, understood.
So, in this case, who should i ask ?
Or should i write codes around opening zipfile with native Nim ?


Setup/configure GitHub pages deployment

Deploy the site!
Requirements

Configure the necessary DNS & CNAME records to deploy the site via GitHub pages
Create a GitHub action to deploy the site (npm run deploy) on merge. Split to #39

Resolved by manual action (DNS configuration & CNAME). Automation has bee split off into #39.


feat: default value in node config

Summary

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

Title should be docs: xxxx?


.Net Core 3.1 is incompatible

.Net Core 3.1, released 12/19, gives errors on the nuget install of:
Severity	Code	Description
Error	NU1202	Package Serilog.Formatting.Compact 1.0.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Serilog.Formatting.Compact 1.0.0 does not support any target frameworks.
Error	NU1202	Package Serilog.Sinks.PeriodicBatching 2.1.1 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Serilog.Sinks.PeriodicBatching 2.1.1 does not support any target frameworks.
Error	NU1202	Package Serilog.Sinks.File 4.0.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Serilog.Sinks.File 4.0.0 does not support any target frameworks.
Error	NU1202	Package Serilog.Sinks.Seq 4.0.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Serilog.Sinks.Seq 4.0.0 does not support any target frameworks.

Hi! Thanks for your report. This works for me, can you try running something like the commands below and let me know where your output differs? Thanks!
PS C:\Development\temp\test> dotnet --version
3.1.100
PS C:\Development\temp\test> dotnet new console
The template "Console Application" was created successfully.

Processing post-creation actions...
Running 'dotnet restore' on C:\Development\temp\test\test.csproj...
  Restore completed in 128.54 ms for C:\Development\temp\test\test.csproj.

Restore succeeded.

PS C:\Development\temp\test> dotnet add package serilog.sinks.seq
  Writing C:\Users\nblumhardt\AppData\Local\Temp\tmpD880.tmp
info : Adding PackageReference for package 'serilog.sinks.seq' into project 'C:\Development\temp\test\test.csproj'.     info : Restoring packages for C:\Development\temp\test\test.csproj...
info :   GET https://api.nuget.org/v3-flatcontainer/serilog.sinks.seq/index.json
info :   OK https://api.nuget.org/v3-flatcontainer/serilog.sinks.seq/index.json 784ms
info :   GET https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/serilog.sinks.seq/index.json
info :   GET https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-corefxlab/nuget/v3/flatcontainer/serilog.sinks.seq/index.json
info :   NotFound https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/serilog.sinks.seq/index.json 776ms
info :   NotFound https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-corefxlab/nuget/v3/flatcontainer/serilog.sinks.seq/index.json 651ms
info : Package 'serilog.sinks.seq' is compatible with all the specified frameworks in project 'C:\Development\temp\test\test.csproj'.
info : PackageReference for package 'serilog.sinks.seq' version '4.0.0' added to file 'C:\Development\temp\test\test.csproj'.
info : Committing restore...
info : Writing assets file to disk. Path: C:\Development\temp\test\obj\project.assets.json
log  : Restore completed in 3.72 sec for C:\Development\temp\test\test.csproj.

Hi and good morning,
It looks the issue is with the mvc template. To replicate the issue replace console with mvc:
Instead of:
dotnet new console
use
dotnet new mvc
Here's my output:
PM> dotnet --version
3.1.100
PM> dotnet new mvc --force
The template "ASP.NET Core Web App (Model-View-Controller)" was created successfully.
This template contains technologies from parties other than Microsoft, see https://aka.ms/aspnetcore/3.1-third-party-notices for details.
Processing post-creation actions...
Running 'dotnet restore' on C:\Users\k\source\repos\test2\test2.csproj...
Restore completed in 28.71 ms for C:\Users\k\source\repos\test2\test2.csproj.
Restore succeeded.
PM> dotnet add package serilog.sinks.seq
Writing C:\Users\k\AppData\Local\Temp\tmpEAC9.tmp
info : Adding PackageReference for package 'serilog.sinks.seq' into project 'C:\Users\k\source\repos\test2\test2.csproj'.
info : Restoring packages for C:\Users\k\source\repos\test2\test2.csproj...
info :   CACHE https://api.nuget.org/v3-flatcontainer/serilog.sinks.seq/index.json
error: Package Serilog.Sinks.Seq 4.0.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Serilog.Sinks.Seq 4.0.0 does not support any target frameworks.
error: Package Serilog.Formatting.Compact 1.0.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Serilog.Formatting.Compact 1.0.0 does not support any target frameworks.
error: Package Serilog.Sinks.File 4.0.0 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Serilog.Sinks.File 4.0.0 does not support any target frameworks.
error: Package Serilog.Sinks.PeriodicBatching 2.1.1 is not compatible with netcoreapp3.1 (.NETCoreApp,Version=v3.1). Package Serilog.Sinks.PeriodicBatching 2.1.1 does not support any target frameworks.
error: Package 'serilog.sinks.seq' is incompatible with 'all' frameworks in project 'C:\Users\k\source\repos\test2\test2.csproj'.
PM>

Thanks for the follow-up. It might be a problem with your .NET installation - what happens if you don't pass --force to dotnet new mvc?
The MVC template works with this package on my machine:
PS C:\Development\temp\mvcsss> dotnet new                                                                                PS C:\Development\temp\mvcsss> dotnet new mvc                                                                                The template "ASP.NET Core Web App (Model-View-Controller)" was created successfully.
This template contains technologies from parties other than Microsoft, see https://aka.ms/aspnetcore/3.1-third-party-notices for details.

Processing post-creation actions...
Running 'dotnet restore' on C:\Development\temp\mvcsss\mvcsss.csproj...
  Restore completed in 131.77 ms for C:\Development\temp\mvcsss\mvcsss.csproj.

Restore succeeded.

PS C:\Development\temp\mvcsss> dotnet add package serilog.sinks.seq                                                                                Writing C:\Users\nblumhardt\AppData\Local\Temp\tmp76AD.tmp
info : Adding PackageReference for package 'serilog.sinks.seq' into project 'C:\Development\temp\mvcsss\mvcsss.csproj'.
info : Restoring packages for C:\Development\temp\mvcsss\mvcsss.csproj...
info :   GET https://api.nuget.org/v3-flatcontainer/serilog.sinks.seq/index.json
info :   GET https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/serilog.sinks.seq/index.json
info :   OK https://api.nuget.org/v3-flatcontainer/serilog.sinks.seq/index.json 1013ms
info :   GET https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-corefxlab/nuget/v3/flatcontainer/serilog.sinks.seq/index.json
info :   NotFound https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-core/nuget/v3/flatcontainer/serilog.sinks.seq/index.json 883ms
info :   NotFound https://dotnetmyget.blob.core.windows.net/artifacts/dotnet-corefxlab/nuget/v3/flatcontainer/serilog.sinks.seq/index.json 891ms
info : Package 'serilog.sinks.seq' is compatible with all the specified frameworks in project 'C:\Development\temp\mvcsss\mvcsss.csproj'.
info : PackageReference for package 'serilog.sinks.seq' version '4.0.0' added to file 'C:\Development\temp\mvcsss\mvcsss.csproj'.
info : Committing restore...
info : Writing assets file to disk. Path: C:\Development\temp\mvcsss\obj\project.assets.json
log  : Restore completed in 5.24 sec for C:\Development\temp\mvcsss\mvcsss.csproj.

Thanks for your response. I'm wondering if it's a version difference with our development environment. I'm running VS 2019 16.4.0. I'm upgrading to the newest 16.4.2 this morning, just to be certain that isn't the issue.
Here's the output without --force
PM> dotnet new mvc
dotnet : Creating this template will make changes to existing files:
At line:1 char:1

dotnet new mvc

  + CategoryInfo          : NotSpecified: (Creating this t...existing files::String) [], RemoteException
  + FullyQualifiedErrorId : NativeCommandError

Overwrite   appsettings.Development.json
Overwrite   appsettings.json
Overwrite   test2.csproj
Overwrite   Program.cs
Overwrite   Startup.cs
Overwrite   Controllers/HomeController.cs
Overwrite   Models/ErrorViewModel.cs
Overwrite   Properties/launchSettings.json
Overwrite   Views/_ViewImports.cshtml
Overwrite   Views/_ViewStart.cshtml
Overwrite   Views/Home/Index.cshtml
Overwrite   Views/Home/Privacy.cshtml
Overwrite   Views/Shared/Error.cshtml
Overwrite   Views/Shared/_Layout.cshtml
Overwrite   Views/Shared/_ValidationScriptsPartial.cshtml
Overwrite   wwwroot/favicon.ico
Overwrite   wwwroot/css/site.css
Overwrite   wwwroot/js/site.js
Overwrite   wwwroot/lib/bootstrap/LICENSE
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap-grid.css
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap-grid.css.map
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap-grid.min.css
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap-grid.min.css.map
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.css
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.css.map
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.min.css
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap-reboot.min.css.map
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap.css
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap.css.map
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap.min.css
Overwrite   wwwroot/lib/bootstrap/dist/css/bootstrap.min.css.map
Overwrite   wwwroot/lib/bootstrap/dist/js/bootstrap.bundle.js
Overwrite   wwwroot/lib/bootstrap/dist/js/bootstrap.bundle.js.map
Overwrite   wwwroot/lib/bootstrap/dist/js/bootstrap.bundle.min.js
Overwrite   wwwroot/lib/bootstrap/dist/js/bootstrap.bundle.min.js.map
Overwrite   wwwroot/lib/bootstrap/dist/js/bootstrap.js
Overwrite   wwwroot/lib/bootstrap/dist/js/bootstrap.js.map
Overwrite   wwwroot/lib/bootstrap/dist/js/bootstrap.min.js
Overwrite   wwwroot/lib/bootstrap/dist/js/bootstrap.min.js.map
Overwrite   wwwroot/lib/jquery/LICENSE.txt
Overwrite   wwwroot/lib/jquery/dist/jquery.js
Overwrite   wwwroot/lib/jquery/dist/jquery.min.js
Overwrite   wwwroot/lib/jquery/dist/jquery.min.map
Overwrite   wwwroot/lib/jquery-validation/LICENSE.md
Overwrite   wwwroot/lib/jquery-validation/dist/additional-methods.js
Overwrite   wwwroot/lib/jquery-validation/dist/additional-methods.min.js
Overwrite   wwwroot/lib/jquery-validation/dist/jquery.validate.js
Overwrite   wwwroot/lib/jquery-validation/dist/jquery.validate.min.js
Overwrite   wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.js
Overwrite   wwwroot/lib/jquery-validation-unobtrusive/jquery.validate.unobtrusive.min.js
Overwrite   wwwroot/lib/jquery-validation-unobtrusive/LICENSE.txt

Rerun the command and pass --force to accept and create.
PM>

Upgrading didn't change anything. Here's my dotnet --info. Maybe that will show a difference from yours?
PM> dotnet --info
.NET Core SDK (reflecting any global.json):
Version:   3.1.100
Commit:    cd82f021f4
Runtime Environment:
OS Name:     Windows
OS Version:  10.0.18362
OS Platform: Windows
RID:         win10-x64
Base Path:   C:\Program Files\dotnet\sdk\3.1.100\
Host (useful for support):
Version: 3.1.0
Commit:  65f04fb6db
.NET Core SDKs installed:
1.1.12 [C:\Program Files\dotnet\sdk]
2.1.202 [C:\Program Files\dotnet\sdk]
2.1.504 [C:\Program Files\dotnet\sdk]
2.1.602 [C:\Program Files\dotnet\sdk]
2.1.604 [C:\Program Files\dotnet\sdk]
2.1.700 [C:\Program Files\dotnet\sdk]
2.1.801 [C:\Program Files\dotnet\sdk]
3.1.100 [C:\Program Files\dotnet\sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.All 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.All 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
Microsoft.AspNetCore.App 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 1.0.14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 1.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.8 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 2.1.14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download
PM>

Looks roughly the same. Since the package does correctly support/target .NET Core 3.x (we're using it extensively), I think this is a machine-specific tooling problem, unfortunately. Trying another machine might be your best bet. Sorry to not be of more help, it's really unlikely we can solve this via the package, though.

You are correct sir. I asked a co-worker to follow the same instructions and your package installed correctly on their machine. I apologize for taking up your time and thank you for the help!
Kirk

No trouble at all, thanks for the follow-up! 👍

Got a similar issue in azure pipeline today, that was because I was using Nuget 4.4.1
Fix: Update the nuget version to latest

I had this issue and as comment above mentioning I add the below task to my yml file
steps:
  - task: NuGetToolInstaller@1
    displayName: "Install specific version of Nuget"
    inputs:
      versionSpec: '5.11.0'


Fixed synced-feature-check workflow in CircleCI

Changes

Fixed synced-feature-check workflow in CircleCI

Related issue
N/A
Additional information and checks
Merged separate reactor builds with workspace-cached .m2 share into a single job sharing an .m2 repository.

Approved and "battle-tested" as a backport with Christians PR https://github.com/ehrbase/ehrbase/pull/807


SetAppearance is never called

Hey,
I've followed your example and created a custom renderer for my toolbar. Howeverl, the SetAppearance method is never fired/called. Why?
Sincerely,
Marcus

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b6242cd2-d96b-273b-d3c6-089cb170ba8d
Version Independent ID: 5c1a70be-0d94-bed3-ff9a-d46def91cfb3
Content: Xamarin.Forms Shell Custom Renderers - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/shell/customrenderers.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @Softtinn
I just checked my sample code and the SetRenderer method is getting called in Xamarin.Forms 4.1. There's nothing more to it than is explained in the doc: (1) create a shell renderer class that inherits from ShellRenderer that overrides CreateToolbarAppearanceTracker, and (2) create a toolbar tracker class that inherits from ShellToolbarAppearanceTracker and override SetAppearance.


[Refactor] - Refactored LoginTout classes to Kotlin

What

Refactored LoginToutViewModel, LoginToutActivity, and LoginToutViewModelTest to Kotlin.

Why

Trying to get our Kotlin percentages up in our codebase!

See

👋 shall we close this?


XRDP v0.9.22 - Session chooser (login) segfaults if I click on 'Session' - libcommon.so.0.0.0

Hi.
I have another issue (perhaps related to https://github.com/neutrinolabs/xrdp/issues/2682 ?)
Pretty sure this didn't occur before (when I just had KDE installed)
If I enter no password when logging in I get the XRDP login menu - where you choose session, user, pass.
If I click on the session drop down menu (i.e xorg, XVNC)  (at all) it crashes (100% on the time, on 2 different systems..)
e.g
[   44.044898] xrdp[1614]: segfault at 5643a003b6d8 ip 00007f7167d46fda sp 00007ffde329f8a0 error 4 in libcommon.so.0.0.0[7f7167d3c000+19000]
[   44.044941] Code: 49 ee 49 8b 3c 24 41 3b 4c 24 0c 74 4b 8d 41 01 41 89 44 24 08 83 f8 01 7e 22 83 e9 01 39 e9 72 1b 0f 1f 80 00 00 00 00 89 c8 <48> 8b 34 c7 8d 41 01 83 e9 01 48 89 34 c7 39 e9 73 ec 48 63 ed b8

It works otherwise as long as you do not click ...
i.e I can use tab key to enter the session drop down (and it doesn't crash)  - which seems like a really odd error.
Any ideas ?
edit: It appears to be connected to the new version (i'm using EPEL packages) - xrdp-0.9.22-4.el8.x86_64.rpm - this happens on - if I downgrade again to xrdp-0.9.21-1.el8.x86_64.rpm this issue is not there .

I can reproduce this on CentOS 8 and in my development environment.
As far as CentOS 8 goes, at the moment 0.9.22-4 is in testing, so I needed to install it (and xrdp-selinux) manually.
This looks like a problem with our stuff, rather than the EPEL build this time. It looks like 8810d46ff11795af2977c54a83d16e5cf1a2ad2a is missing from this release. If I cherry-pick that in, the session chooser is fine.
@bsmojver - I've raised https://bugzilla.redhat.com/show_bug.cgi?id=2208248
@metalefty - we'll need a <IP_ADDRESS> release. I'll look to see of anything else is missing.

There are quite a few things in the v0.9.22 release note which aren't in the tarball - see git log v0.9.22..v0.9 .

Thanks. I linked the two RH bugs now.

I also added a bug report -> https://bugzilla.redhat.com/show_bug.cgi?id=2208015

@matt335672 Thanks for the fix.
Guys, I will release a fixed version v<IP_ADDRESS> soon. Sorry for the inconvenience.

I suppose the breakage is caused by my mistakes during release process. Sorry for the breakage. This is not an official v0.9.22 release yet but should be a correct v0.9.22 tarball and will be re-released as v<IP_ADDRESS>.
@matt335672 @bsmojver Can you test this pre-release tarball?
xrdp-<IP_ADDRESS>-pre.tar.gz

I can definitely see the segrault patch in the diff, so that's good. I also see removals of g_malloc/free/memset/memcpy, which (from memory) was in release notes. And there is pamconfdir stuff too. There are also some other changes there, like audin. smartcard stuff etc. In summary, yeah - the pre tarball picked up more stuff, it seems.

I have released the correct tarball v<IP_ADDRESS>. Double-checked by me and @matt335672 .
https://github.com/neutrinolabs/xrdp/releases/tag/v<IP_ADDRESS>

Thanks! Building Fedora packages now.


translated the readme file into japanese not entirely sure how good i…

…t is though

Closed #252


Publish 8.1-rc-2

Publish 8.1-rc-2

@bot-gradle test and merge

Your PR is queued. See the queue page for details.


style: article thumbnail component

Description
Style article thumbnail component inside list
I will follow article thumbnail component inside article in another PR
SM:

MD:

LG:

Fixes # (link to Jira or GitHub issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I have updated the CHANGELOG
[x] I have requested at least 1 reviewer for this PR
[x] I have made corresponding changes to the documentation

from my point of view... there are two (visual) issues. first is hard-cutting the overflowed text
try to set height to avoid cutting the line (and test it for all breakpoints) - I think it might be possible second option is to apply "fade-out" with gradient (similar what used to seen on paywalls)
second issue is spacing. it simply doesn't follow the proposed design:
vs

I was thinking about this and there are simply too much variables:

Category is either there or not
Title is from 1 to 3 lines
and ofc the breakpoints
I pushed the fade out but will consult @memb

I've deployed the PR to test:
 dep deploy test --branch WEBUMENIA-1558-article-thumbnail-component

@ustengrav @igor-kamil , can you please take a look?

@eronisko Sorry you are right about the typograhpy on mobile I somehow missed it. Fixed it in new commit

Since don't have a home for this yet, I'd suggest closing this PR (but leaving the branch as is)


Make it easier to run testsuite with a custom toolchain.

The optimization added in #9206 to circumvent the rustup wrapper for rustc had a bad interaction when using a custom toolchain (like cargo +stage1 test).  It was using the rustc from where cargo is located, but custom toolchains often don't have cargo. This would instead use the nightly rustc (due to rustup's fallback).  This changes it to query rustup directly to ask it where the overridden rustc is located.

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

@bors: r+

:pushpin: Commit b67454c660db7af5647491dd4ffb8805ff9fa839 has been approved by alexcrichton

:hourglass: Testing commit b67454c660db7af5647491dd4ffb8805ff9fa839 with merge 197e657b5bef2964551a127f088da187ccacd30e...

:sunny: Test successful - checks-actions
Approved by: alexcrichton
Pushing 197e657b5bef2964551a127f088da187ccacd30e to master...


How to deal with global CSS import when used inside a lib in a Next.JS app

Summary
We currently maintain a React framework called react-admin, and we used @toast-ui/react-editor to build one of our components.
In this component we imported the toastui-editor.css file following the usage instructions in the package readme:
import<EMAIL_ADDRESS>
This works fine when used in an app created with create-react-app for example, but when using it in a Next.JS app we get the following error:
<EMAIL_ADDRESS>Global CSS cannot be imported from within node_modules.
Read more: https://nextjs.org/docs/messages/css-npm
Location<EMAIL_ADDRESS>
Which leads us to ask the question: what it the appropriate way to deal with this CSS import in our lib?
Are we doing it right and it's only a Next.JS config missing?
Or should we remove the import from our code and ask the users of our lib to import it globally in their code?
Or none of the above?
Thanks
Version
"@toast-ui/react-editor": "^3.1.5"

@slax57
Thank you for the issue. I'm glad you used our project.
I'm sorry, but we're not considering the Next.js environment yet. For now, I think it would be better to have the end user apply globally CSS.
Recently, the Next.js environmental issue has been opened, and we are going to check it, but there is no exact plan and milestone. Because We have to do various tasks besides TOAST UI. I'm sorry.


Better engage and recognize contributors

Disclaimer: This issue takes a lot of inspiration from the amazing job that @gatsbyjs is doing to engage and motivate its community.
Why
People who contribute to the code, to the design, to the translations or to the documentation are amazing. They add diversity to the way we build Open Collective and help us to improve ourselves by sharing their experiences and good practices.
We want to better recognize these people, to reward them when appropriate and to make contributing to Open Collective a pleasant experience so they'll be willing to contribute again.
What do we want to reward
All types of contributions should be rewarded. For us, it mostly includes:

Submitting code (features, bug fixes...etc)
Reporting security issues
Issues triage
Documentation
Design
Translations

How
1. Invite all contributors to a Contributor team

The idea is to have a common group for all people that made at least one contribution to the project in the past. Inviting people will be a public recognition of our gratitude and a way to stay in touch.
Github Teams seems the good place to do that, especially since it offers a "Discussion" page where we can start conversations or notify all past contributors about the latest news and bounties of Open Collective.
We will be able to assign people in this group to specific issues or pull requests and they will be allowed to edit labels on issues to help us with triage.
Finally, they will have the privilege to commit directly on Open Collective's repositories (except staging and master branches) which will be way more practical than having to maintain and sync a separate fork.
Process

Contribution to the project gets accepted/merged
Core contributors invite the person to the Contributors team and add a comment like this one:

On the behalf of the Open Collective community, I want to say thank you for being here and for contributing to the project. Open Collective is built by awesome people like you.
We would like to say "thanks" by inviting you to the Open Collective organization on Github. You'll be able to label issues, review pull requests and commit directly on our repository.
If you have any questions about that, come and join us on Slack.
Thanks again!

On a regular basis (1/week?) we publish updates and new counties to the team's discussion page (contributors will be notified by email).

2. Swags
This part is still a draft and ideas or experiences are more than welcome here.
The idea would be to have a store of swags (tshirts, hats, Open Collective gift cards...etc) where people can order Open Collective goodies and to provide discount and free items to contributors, based on their number of contributions.
As a reference, Gatsby is doing this: Holy buckets! Get your Gatsby swag here!
After one contribution, they allow you to order a simple item (socks, tshirts...) for free.
After five contributions, you can get a hoodie for free.

I like this. We could also invite those in Team to help us prioritize our roadmap using a simple voting tool

This is a great idea. We can also make it transparent by running expenses like swag through the Collective along with payments for Bounties, etc.

Just added a new section: 3. Mentions on social networks

@beetree can I help here?

@piamancini The experiment with (1) is going well, we progressively add contributors to Github teams so it's easier for them to participate and we have a way to reach them all if needed. We don't post bounties on the discussion page yet but they usually get picked up pretty quickly so there's not a strong need for it.
I tried to use the discussion page to thanks contributors two months ago: https://github.com/orgs/opencollective/teams/translators. I think it's a good thing to do and I'm preparing another one for this month to keep track of the progress. Maybe something similar for developers/bounties would be nice to do? Kinda like a "Bounty hunters monthly leaderboard"?
For (2. Swags) it progressively slept at the bottom of my TODO and I didn't take the time to look at it yet. I'm still willing to look at that, but if anyone has suggestions, wants to take the lead or pair on this I'm open to it.
For (3. Thanks on social networks) I didn't think about it for the last contributions, I'll try to see for future issues and PRs if there are interesting situations for this.

Great!
We can take the swag out of your plate. Let us know what you have in mind and we can work something out. @alanna

The only part of this issue that hasn't been explored yet is the "swag store" and it deserves an issue on its own. I think @xdamman was interested to lead this topic recently?
I'm closing this one for now, I may open more specific ones in the future.

As a follow up, we can discuss the "Open Collective ladder" idea in our upcoming retreat.

@znarf Great idea


Add a user

I can't find it in the documentation. Is there a way to blog using hubpress with multiple users? And if so how to add one?
Thank you!

Yes there is now: https://hubpress.gitbooks.io/hubpress-knowledgebase/content/write/multiple_authors.html


Update TSP function return statement

Changes
Aus programming challenge - Updated return statement template in TSP classical solution function for participants to align with the updates to the graders to make it clear to the participants what they should be returning for their function.

Hi @vabarbosa the small front-end change for the fixes we're going on problem 2.1 - thank you!


ignore option doesn't work

Specifying the ignore option in .template-lintrc.js has no effect.  Is this not supported by this addon?
I found this unanswered query as well:  https://discuss.emberjs.com/t/disable-template-linting-of-dummy-app/12873

Took me a while to figure out, but dont add the extension in the rule
eg. (your-app-name)/templates/trip.hbs
should be
(your-app-name)/templates/trip

Seems like we can probably fix this though.


Promise & Async Await & Generator

Promise & Async Await & Generator
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Using_promises
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Generator
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/GeneratorFunction
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function

https://repl.it/@xgqfrms1/asyncfunction

EventLoop

js execute order

https://developer.mozilla.org/en-US/docs/Web/JavaScript/EventLoop#Run-to-completion

Tasks, microtasks, queues and schedules
https://jakearchibald.com/2015/tasks-microtasks-queues-and-schedules/

https://github.com/javascript-tutorial/zh.javascript.info#readme


vioserial: Send VIRTIO_CONSOLE_PORT_OPEN (0) on port D0 exit

Virtio serial ports receive the D0 exit callback before the parent driver.
This is expected in this driver architecture of a parent bus driver and
ports modeled as children. It however causes issues because ports own their
respective queues and try to clean them up while VirtIO as a whole, to be
shut down by the master D0 exit callback, is still running.
As a result, D0 exit (caused by resource rebalance on CPU hot-plug for
example), may crash QEMU with errors similar to:
Looped descriptor
or
Guest moved used index from 253 to 176
because port D0 exits race with QEMU still pushing data to the queues.
This patch fixes it by sending the VIRTIO_CONSOLE_PORT_OPEN control message
with open=0, i.e. signaling to the host that the port is closed and should
not be receiving more traffic.
It would be nicer to address this on the VirtIO level but VirtIO 1.0
explicitly forbids the driver from shutting down individual queues:
<IP_ADDRESS>.2 Driver Requirements: Common configuration structure layout
[...]
The driver MUST NOT write a 0 to queue_enable.
Alternatively, the driver might be refactored so that all queues are owned
by the parent bus driver which would then be in charge of cleaning them up
following the correct protocol, i.e. only after the VirtIO device has been
reset. This would be a bigger and riskier change.
Link: https://github.com/virtio-win/kvm-guest-drivers-windows/issues/195
Signed-off-by: Ladi Prosek<EMAIL_ADDRESS>

No, I want the port to be reopened in VIOSerialPortEvtDeviceD0Entry so it needs to remember that it was open before the D0 exit.
If an actual file close comes in between, it will not even check the flag because Port->Removed will be true. So there should be no double-reporting of VIRTIO_CONSOLE_PORT_OPEN (0) either.


New theme for the protonmail web client

New Theme?
I made a theme for the protonmail web client, here is the link: https://github.com/Blisterexe/Dracula-Protonmail-theme
it is meant to be used with the stylus extension just like the official youtube theme.

Hey, very cool! ✨
I just sent you an invitation to join the organization.
I also cloned your repository for Dracula's organization, so you can go ahead and delete or archive yours:

Your repository.
New repository.

Thanks for building this! 🎉

thank you for accepting my theme! I am very honored!


Status of hipFFT

What features of cuFFT are actually implemented?
It's hard to say looking at header and source files.

There is a lot of commented code and empty switch cases, for example: https://github.com/ROCmSoftwarePlatform/rocFFT/blob/develop/library/src/hipfft.cpp#L224

hipfftExecC2C calls the same code for different directions (unlike hipfftExecZ2Z):
https://github.com/ROCmSoftwarePlatform/rocFFT/blob/develop/library/src/hipfft.cpp#L858

Functions always return HIPFFT_SUCCESS and ignore result of rocfft_* functions.

Will hipFFT be a wrapper around cuFFT? Or it's supposed to be used with rocFFT only (on both ROCm and CUDA).

hipFFT is a wrapper on top of rocFFT that was written to provide compatible interfaces. As you can see it is not fully done yet and is missing functionalities and has bugs; goal is to clean this out and get it tested well, unfortunately I don't have timeline on when that will happen


add script to list all the app proxy applications

Added script to list all the application proxy applications registered in the tenant

OPS Build status updates of commit e8d5ef4:
:clock10: Preparing: average preparing time is 1 min(s) 8 sec(s)

OPS Build status updates of commit e8d5ef4:
:clock10: Full build: average full build time is 1 min(s) 41 sec(s) [calculated from last 6 build(s)]

Note: A full build takes more time than an incremental build.  This is the expected behavior of the build system.

OPS Build status updates of commit e8d5ef4:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

azureadps-2.0-preview/AzureAD/Get-AzureADApplicationProxyApplication.md
:x:Error

Details

:x:Error

Details

azureadps-2.0-preview/AzureAD/Get-AzureADApplicationProxyApplication.md

[Error] Unable to load file: azureadps-2.0-preview/AzureAD/Get-AzureADApplicationProxyApplication.md via processor: AzureCliDocumentProcessor: :75:(270) '## To get a list of all the Azure AD Application P...'
Unexpected header name To get a list of all the Azure AD Application Proxy applications in the tenant

[Error] Markdown.MAML.Transformer.HelpSchemaException: :75:(270) '## To get a list of all the Azure AD Application P...'
Unexpected header name To get a list of all the Azure AD Application Proxy applications in the tenant
at Microsoft.DocAsCode.Build.Engine.SingleDocumentBuilder.GetInnerContexts(DocumentBuildParameters parameters, IEnumerable1 processors, TemplateProcessor templateProcessor, IHostServiceCreator creator) at Microsoft.DocAsCode.Build.Engine.SingleDocumentBuilder.BuildCore(DocumentBuildParameters parameters) at Microsoft.DocAsCode.Build.Engine.SingleDocumentBuilder.Build(DocumentBuildParameters parameters) at Microsoft.DocAsCode.Build.Engine.DocumentBuilder.BuildCore(DocumentBuildParameters parameter, IMarkdownServiceProvider markdownServiceProvider, BuildInfo currentBuildInfo, BuildInfo lastBuildInfo) at Microsoft.DocAsCode.Build.Engine.DocumentBuilder.Build(IList1 parameters, String outputDirectory)
at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument(BuildJsonConfig config, TemplateManager templateManager, String baseDirectory, String outputDirectory, String pluginDirectory, String templateDirectory)
at Microsoft.DocAsCode.SubCommands.DocumentBuilderWrapper.BuildDocument()

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit 67c489e:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: OPS Build is busy, click here to report any potential performance downgrade issues, or you could view OPS Portal for trend of build queue length.

  This is the expected behavior of the build system.

OPS Build status updates of commit 67c489e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azureadps-2.0-preview/AzureAD/Get-AzureADApplicationProxyApplication.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

  This is the expected behavior of the build system.

OPS Build status updates of commit e1a711f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azureadps-2.0-preview/AzureAD/Get-AzureADApplicationProxyApplication.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

#sign-off


Defensive decodeURIComponent express error?

What version of OpenTelemetry are you using?
<EMAIL_ADDRESS>What version of Node are you using?
16
What did you do?

we've been receiving requests to our express server that include invalid URLs that fail decodeURIComponent. we are seeing errors logged out that include otel in the stack so I'm not sure if its express or the instrumentation's middleware needing to handle this more gracefully.
URIError: Failed to decode param '%C0'
--
at decodeURIComponent (<anonymous>)
at decode_param (/home/node/node_modules/express/lib/router/layer.js:172:12)
at Layer.match (/home/node/node_modules/express/lib/router/layer.js:148:15)
at matchLayer (/home/node/node_modules/express/lib/router/index.js:585:18)
at next (/home/node/node_modules/express/lib/router/index.js:226:15)
at /home/node/node_modules/@opentelemetry/context-async-hooks/build/src/AbstractAsyncHooksContextManager.js:50:55
at AsyncLocalStorage.run (node:async_hooks:330:14)
at AsyncLocalStorageContextManager.with (/home/node/node_modules/@opentelemetry/context-async-hooks/build/src/AsyncLocalStorageContextManager.js:33:40)
at contextWrapper (/home/node/node_modules/@opentelemetry/context-async-hooks/build/src/AbstractAsyncHooksContextManager.js:50:32)
at arguments.<computed> (/home/node/node_modules/@opentelemetry/instrumentation-express/build/src/instrumentation.js:208:73)

What did you expect to see?
no errors
What did you see instead?
the above stack trace
Additional context

<EMAIL_ADDRESS>

The way how most OTel node.js instrumentations work is to wrap functions.
Once called these wrappers do something (e.g. extract some data from arguments, start a span,...), then call the original and once the original function returns they do again something (e.g. end a span, check return value,...).
That said it's quite clear that OTel instrumentations are often on a call stack and not automatically responsible for any problem which might happen later.
Are you sure that OTel is actually the cause for the invalid urls received by your server?

@Flarna its not responsible for the urls. i did not know if there was some sort of logging or other behavior in the instrumentation that could cause this error to leak out unintentionally

Ah ok, it's about the log not about the error.
I see no place in the express instrumentation where  logging to stderr is done.
In general OTel doesn't log to stderr, there is an diag api which is noop on default and user can configure it as needed.


Forward OpenCensus context to all methods

Signed-off-by: Justin Terry (VM<EMAIL_ADDRESS>

@jstarks - Can you review the interfaces where I added ctx and make sure you think that it makes sense. I still cant decide about having a ctx on Wait so that the caller can easily wait with a timeout. But I left it as is

I don't fully understand what this means. Are you just adding new context parameters to functions in hcsshim that didn't used to take one? Or is this doing more like forwarding context to the GCS?

I don't fully understand what this means. Are you just adding new context parameters to functions in hcsshim that didn't used to take one? Or is this doing more like forwarding context to the GCS?

Both. I commented where its forwarded to the guest.

Concerned about some of the new context parameters. I recognize that there is some tension in cases where we need to communicate with HCS, but I'd really like to avoid extreme context proliferation.

Said it on the response to ExitCode but I will summarize here. We have more than one implementation of cow.Process for example. One does use ctx and one doesn't. In cases like this should we favor the external bridge implementation or just allow the context to be used. In external bridge ctx is only used for logging in that model. If we remove it entirely then in hcs/*.go we will just create a background context and the time of invocation. Not sure either one is better to me.

I just want to make sure we have a consistent principle about when and why we are using logging instead of error returns. In this case is it because we want to consistently log all calls to the HCS?

Closing out. Will open a new one since much of this is in seperate PR's that is suited for just the OpenCensus work.


[BUG] Prev and Next Buttons in Testimonial Section

Description
Prev and Next Buttons can improve UX in testimonial sections
Screenshots

Any additional information?
No response
What browser are you seeing the problem on?
Chrome
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I have read the discussion tab thoroughly and got the project idea
[X] I am willing to work on this issue (optional)
[X] I am a GSSoC'23 contributor

@rohansx @k-deepak04 Please assign me this issue under GSSoC 23

@ManasMadan go for it
but still i will say please try to contribute towards adding some functionality

@rohansx Have created a PR #461, Merging that closes this issue


How to use the dropdown component in React

With working with these dropdowns: https://tailwindcss.5balloons.info/components/dropdown/
the components are using x-data sort of attributes (like alpine.js) which is not natively supported by react.
Make the component generalised to be used with any JS lib/framework.

@Siddhantsingh1230 This library does not support React / Vue components. This is copy and paste components built using pure tailwindcss or tailwindcss + alpinejs.


Work with serverless-offline plugin

The serverless-offline plugin has a large support for handling most of the emulation of API Gateway. It would be great if I could use this plugin with that one to get a great offline experience and the great processing experience I am having with this plugin.
Not sure if this is something you can work with the author of that plugin on.

It would be great so that this plugin could only be doing the compilation phase. serverless-offline doesn't seam to be released for v1 at this time tho. I'll check it out in the future

They have a branch where they are working at the moment. I would guess they will release close to when 1.0 is actually released.

which makes sense because keeping up with 1.0 betas/rcs timing is quite challenging xD

Follow PR #55 for updates on this


feat(338): add new pitchdeck slides to homepage

Description
This PR updates the homepage based on the latest figma guidelines (linked here).
Leaving as draft for @thansidwell and stakeholders to review — specific feedback requests include:

I copied some of the graphics directly from the figma, but I believe you meant some of them as placeholders for now — would love your feedback on the finalized versions of those section graphics?
I assumed the final "Get Started" link went to /map, but that was a shot in the dark.
I could use more direction on the mobile view sizes for the "three blue boxes" graphic.

Desktop (1980px)

Mobile (375px)

Closes #338

@paulhchoi I did a quick test using a screen reader to see how the list is read out, unfortunately it isn't favourable. It's confusing to have 3 lists that house only 1 item each.  I'm currently researching how to make the list appear the way we wanted to through CSS so we only have one list.
Another thing is I recommend hiding this image from screen readers since it's just a repetition of the list item, and not adding value to the meaning of this section. cc @bacitracin

@paulhchoi, great work on all this. Here's a few minor issues I found.

The headline and subheading don't align with the photos. Can you align them to 2/3 and 1/3 layout?  https://share.cleanshot.com/PfRHxtDN
On small screens lets hide these two photos. It's too many photos for such a small screen. https://share.cleanshot.com/CmQrg881
As the screen gets wide the gap between the text and graphics isn't centered. Can you try to center it? https://share.cleanshot.com/gfcYDnQ3
The buttons on the home page are different than the buttons elsewhere. https://share.cleanshot.com/tkKD8htP We have about 3 different-looking variants and I'm trying to unify them into one button style with several variations with this ticket. https://github.com/CodeForPhilly/vacant-lots-proj/issues/288  Not sure what button to use. The nav buttons in your preview look like the closest to what the design is.

@paulhchoi RE: https://github.com/CodeForPhilly/vacant-lots-proj/issues/338#issuecomment-1994673318
I did a quick screen reader pass to see how the nested list is announced. It doesn't make sense to have a 3 different lists that only have 1 item each, so it was confusing.

Video Demo
https://github.com/CodeForPhilly/vacant-lots-proj/assets/102739972/03be05dd-63a3-4631-b1e1-d8ca30863f6d

We can just drop the
, and make those 3 items straight
s. It's essentially just another heading, with number in the beginning.
That said, let's make this image a list, because it now assists the succeeding h3 headings - denoting that it's a 3 step process.

Details

use
,
  because Voice Over refuses to announce the list without explicit role of list/listitem
hide the icons from screen readers

cc @bacitracin

@thansidwell @marvieqa requesting a review, all feedback should've been applied — thanks for the feedback thus far.
@thansidwell thoughts on the coloring for the main cta button?:
https://github.com/CodeForPhilly/vacant-lots-proj/assets/8061917/54664f97-4c4a-4f93-809d-225fde0716d0

Thanks @paulhchoi! The experience is a lot better!
I ran into some small things:

The links found after the H3s (ex. Find Properties, Get Access and so on...) are not recognized as links when using a screen reader. It is announced incorrectly as buttons.
When user selects "Learn How" button, we scroll to the content which is a visual cue to start reading. But this doesn't translate to screen reader users. We should manage the focus to go to the first
 so SR announces it immediately after scroll as a cue for them that something has changed. If this is out of scope, let me know I'll write up a separate tix.

@marvieqa made the updates to the The links found after the H3s with some notes:

the tab-index="0" just comes prepackaged with the @next-ui/buttons, so I left it in as it wasn't effecting my screenreader during testing. There's also a ticket open to refactor all buttons on the site, so this fix may come for free.

I added the appropriate id to the
 so the screenreader drops to it when the Learn How button is clicked, but on testing, the screenreader wasn't reading the h2 text immediately. Opening another ticket would work.

@thansidwell I added the links to the copy of a couple of the sections and also added the default blue/darkblue/purple styling.

@thansidwell regarding the scroll down button, @marvieqa requested we link the
 anchor for screen-reader purposes. I'll revert back to adding the anchor id to the section itself, and @marvieqa, please add this as an acceptance criteria to the ticket you're opening — to ensure that the scroll action doesn't cut off the graphic on desktop viewports. Thanks!

@paulhchoi Interesting. The "Learn How" button is there to urge people to scroll down below the fold to read the other content. I'm not sure visually impaired people with screen readers behave the same way. @marvieqa, could we test what actually happens for screen readers when the ID is put on the section vs the heading? If it still need to be on the heading we can add a negative margin to make sure it doesn't go to far.

@paulhchoi I also notice that "This tool can empower..." disappears on mobile. https://share.cleanshot.com/kx293byC

@paulhchoi Interesting. The "Learn How" button is there to urge people to scroll down below the fold to read the other content. I'm not sure visually impaired people with screen readers behave the same way. @marvieqa, could we test what actually happens for screen readers when the ID is put on the section vs the heading? If it still need to be on the heading we can add a negative margin to make sure it doesn't go to far.

@thansidwell I checked both, when @paulhchoi had it on the section and when the ID is on
. But like Paul's experience, the screen reader did not announce it for me as well, so I'm making a separate ticket for it and do a bit of research, make recommendations from there ;).
When a screen reader user reaches "Learn How" button and activates it, there should be some form of announcement of what has changed, what did the button do. Otherwise, they will not know what has occurred, that we actually scrolled down to encourage further reading - so they are left confused. The easiest way to do this is to programmatically manage the focus to fall on something that a screen reader can announce. If the focus goes to the next heading, then they would be prompted that there are further contents to read in the page. This gives them an equitable experience as sighted users who get visual cue from the scroll action.

@thansidwell

Right now the navigation scrolls away, but it should be fixed, just like on the About and Take Action pages.
I also noticed that "This tool can empower..." disappears on mobile.

both are corrected

@thansidwell bump for a review of this please?

Looks great! Pass.

Looks great! Pass.

Thanks! Now requesting a review from either @thansidwell or @nlebovits


Benchmark current HBase performance

0.9.3 has been released and HBase is now officially supported by GeoWave!


Address Bar Becomes Unresponsive

Describe the bug
The address bar becomes unresponsive when attempting to tap it, the tab switcher also does nothing. The home, add tab and menu still work. This randomly happens and even when closing Kiwi and coming back in, it still doesn't work. While it doesn't happen every single time, it happens a lot.
To Reproduce
Seems to happen randomly while using it regardless of website, it happens enough where it's very easy for me to reproduce. Even browsing around I can usually reproduce it within a minute or so.
Expected behavior
I should be able to open my tab switcher and address bar.
Screenshots
Video attached
Smartphone (please complete the following information):
Galaxy S23 Ultra SM-S918U1
Additional context
I have tried disabling various settings, all extensions, fresh installs, reinstalling the app. This just started happening I would say within the last couple weeks. Happens both on play store build currently I have 116.0.5845.54 and dev build 116.0.5845.54 I have had problems with the last few versions. Never had an issue before that.
I have also tried moving address bar to top and back to bottom it happens in both places, driving me nuts.
https://github.com/kiwibrowser/src.next/assets/115195215/842e5587-5c6c-4987-ad55-bb5e1b418b03

I just noticed it seems to almost always happen when kiwi is opened from my Google discover page on my home screen.  I have it set to open links in the default browser which of course is Kiwi. I have been running it this way for a long time without issues until recently.
While it doesn't freeze the entire browser, it might as well since the tab switcher doesn't work and you can't search for anything or edit the URL. Super frustrating

I get the same on a Pixel 5 & Tab S8

Same behavior of address / action bar unresponsive in my tablet Samsung S6lite android 13 oneui 5.1 since I updated to kiwi v116, particularly when closing all tabs and the only way to get something out of the app is open a new tab via the 3 dots menu. No issues with the previous version at all.
Also, no problem at all with kiwi v116 in my phone, oneplus 5t w lineageos 20 (also android 13)
BTW, none of them show the new Action Toolbar button no matter what (tried "Based on usage" and "New tab")

Still an issue for me!

Same issue here on a Pixel 6 pro running up to date software.

Same issue, Note 20 Ultra, Android 13/One UI 5.1, Snapdragon version. Persists after a clean phone wipe and setup as a new device without restoring from backup. It seems that closing the app is the only fix, as the issue persists even if you leave the app and come back. It may only be happening when I have Bottom Toolbar enabled, as I haven't encountered it when I've switched back to top (but with a phablet that's quite inconvenient.)

I have the bar at the top and same thing.
I had to switch browser until this issue gets fixed.
Android 10, Huawei Matepad 10.4

Does anyone know the last version that doesn't have this issue? I've been living with this issue facing it daily for 3 months now and no fix in sight.
Going back to an older version and resetting everything seems like the only option.

@downloaderfan before 116

Is Kiwi essentially unmaintained at this point? Does anyone have a recommendation for what to move to?

@emezeske if you need extension support is either Firefox or Lemur

@mirko77 thanks for the tips! I hadn't heard of Lemur.

@emezeske If you are looking for an open source stable alternative with extension support, try iceraven.
It is firefox based & it supports hundreds of extensions more than the limited ones regular firefox supports.

I have been testing the latest dev release and I have not been able to reproduce the issue so far, seems good.
Generation<PHONE_NUMBER>

@mirko77 the issue is still present in the latest stable.

@mirko77 the issue is still present in the latest stable.

that's true.

I switched to Firefox on Android because of this, that supports ublock too
:)
ParanoidAndroid @.***> schrieb am Di., 2. Jan. 2024,
00:11:

@mirko77 https://github.com/mirko77 the issue is still present in the
latest stable.
that's true.
—
Reply to this email directly, view it on GitHub
https://github.com/kiwibrowser/src.next/issues/941#issuecomment-1873518454,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAANGLGH7UJJ6AZGRDNPOFTYMM7AHAVCNFSM6AAAAAA24PHYQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZTGUYTQNBVGQ
.
You are receiving this because you commented.Message ID: <kiwibrowser/src.
@.***>

@hackgrid Unfortunately, not all sites render well on Firefox engine and I find it a bit slower.

@hackgrid Unfortunately, not all sites render well on Firefox engine and I find it a bit slower.

Firefox is really slow, I have to agree.

Still a thing in 2024
Running on Poco F6 ( Android 14 )
Most of the time it happens when you try to share a link to the browser

Just use Firefox
Abdennour Meraghni @.***> schrieb am Do., 21. Nov.
2024, 19:02:

Still a thing in 2024
Running on Poco F6 ( Android 14 )
Most of the time it happens when you try to share a link to the browser
—
Reply to this email directly, view it on GitHub
https://github.com/kiwibrowser/src.next/issues/941#issuecomment-2490635599,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAANGLB7EUE23IV5WFA7CTD2BWVULAVCNFSM6AAAAABSGS6DEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJQGYZTKNJZHE
.
You are receiving this because you were mentioned.Message ID:
@.***>

I gave up and installed Cromite


todo: be explicit about push/pull rotation convention

Something we didn't talk about but that is worth being very explicit about is what we mean by 'rotate this image n degrees in this direction'
Right handed rotations in a right handed coordinate system are expected to behave a certain way. We are currently rotating coordinates then sampling at the rotated positions, which has the effect of applying the inverse rotation. c.f. https://en.wikipedia.org/wiki/Active_and_passive_transformation
I think we should explicitly invert this so that the rotation has the same effect on the image we view as applying the rotation matrix on a set of coordinates - what do you think?

Yes, absolutely. Good catch. I'll be thinking about how to implement this. The first thought I have is to just "invert" the angles (360-n) before rotating coords.

Yep! that works for 2D - for 3D you'll want to invert the rotation matrices. torch.linalg.inv() will work and is cheap, I like to use it because it's explicit. Technically more efficient to transpose the rotation matrix rather than inverting it because the transpose of a rotation matrix is its inverse

worth adding a note if you implement this to explain what you're doing, it's one of these things that isn't obvious when reading code


Convert flutter/packages local_test to a plugin tools command

flutter/packages has a shell script that runs a custom script command for every package that has it. It's still using the old bash copy of the change-detection logic, which a) we don't want to maintain, and b) is already strictly worse than the new Dart version.
We should convert it over to a new command in the tools package so that we have less code to maintain, the behavior is consistent (we can use all the same flags to control what it runs on, we get the same output format, tool changes re-run for all packages, etc.).
This would also be a good opportunity to rename it to something clearer, since I'm not sure what "local" means in this context, and ideally to clarify what it should (and shouldn't) be used for—we don't want to get into a situation where each package has its own complex, bespoke test control script rather than using specific commands from the tools package. (For instance: we have specific commands that know how to run iOS and Android unit tests; I'd like to understand whether Pigeon's test system really needs its own versions.)
/cc @gaaclarke

I just wrote this in a PR, it's apropos to this issue:

The idea for local_tests is that certain packages have more complex test harnesses, there isn't a generic wrapper for the whole repo that can run tests that have to do codegen and linting in different languages for example. Plus we have the problem that we don't want CI running tests in a different way as people are developing locally. We have to try to keep them as similar as possible.

The idea for local_tests is that certain packages have more complex test harnesses

It doesn't follow that if a package needs more complexity than other packages the only option is to write the entire test harness from scratch though. For instance:

there isn't a generic wrapper for the whole repo that can run tests that have to do codegen

Is needing to do codegen the only thing preventing you from using the existing commands for running iOS and Android unit tests? Because if so, it seems to me that adding a pre-test script hook to the existing commands (which other packages could use for other things, like, say, starting a local server) would be far better than having a second copy of all the logic for running native unit tests but with an extra step before. It's easier to maintain, it's more consistent across packages, it's more re-usable, etc.

Plus we have the problem that we don't want CI running tests in a different way as people are developing locally.

How do we have that problem? flutter_plugin_tools is intended for both CI and local development.

Crypto Solution has sent you an email via Gmail confidential mode:
[image: Gmail logo]Re: [flutter/flutter] Convert flutter/packages local_test to a plugin tools command (#85543) https://confidential-mail.google.com/msg/AG7J_YSQriZpNKAwuBoFrbZGtJK-UMCeuF9jj58-MkluKemE0CAjsbl5D_56odeHz3DIzz75aOU0xbDh9ry97SmjB99jFAXZ9d0ft3BHIZE9h486CL3jyQrxT9qogHZJG5YWNtjID40h88u4GcS78BwEcoE3fTsTlbSIhc7k0W3c5hwEAXZXxepBvyM-8u_3-87d0gaFHOao2dflYccU
This message was sent on Jun 29, 2021 at 11:09:47 AM PDT
You can open it by clicking the link below. This link will only work for @.***
View the email https://confidential-mail.google.com/msg/AG7J_YSQriZpNKAwuBoFrbZGtJK-UMCeuF9jj58-MkluKemE0CAjsbl5D_56odeHz3DIzz75aOU0xbDh9ry97SmjB99jFAXZ9d0ft3BHIZE9h486CL3jyQrxT9qogHZJG5YWNtjID40h88u4GcS78BwEcoE3fTsTlbSIhc7k0W3c5hwEAXZXxepBvyM-8u_3-87d0gaFHOao2dflYccU
Gmail confidential mode gives you more control over the messages you send. The sender may have chosen to set an expiration time, disable printing or forwarding, or track access to this message. Learn more https://support.google.com/mail/answer/7674059
Gmail: Email by Google
Use is subject to the Google Privacy Policy https://myaccount.google.com/privacypolicy?hl=en
Google LLC, 1600 Amphitheatre Parkway, Mountain View, CA 94043, USA
You have received this message because someone sent you an email via Gmail confidential mode.
[image: Google logo]

Nope, not just running codegen.  Outside of running dart unit tests the local_tests are also downloading and executing custom linters (like checkstyle) and executing platform specific test harnesses (like xcode unit tests).

are also downloading and executing custom linters (like checkstyle)

I understand that there are some parts of the current test that are going to be highly specific to Pigeon. But the options are not "don't have any custom test script" and "write absolutely everything from scratch without using any of the existing tools". Again, as a specific example:

and executing platform specific test harnesses (like xcode unit tests).

As I said in both of my comments above, we have commands that do exactly that in the tool package:

we have specific commands that know how to run iOS and Android unit tests
[...]
Is needing to do codegen the only thing preventing you from using the existing commands for running iOS and Android unit tests?

Another reason we need to do something about this: the bash logic for figuring out what packages to run is much cruder than the Dart logic in the tool, and it doesn't understand the concept of re-running all tests for repo-affecting changes. Notably, the new flutter->packages autoroller won't fail if it breaks local_test, because local_test.sh will determine that no packages need to have tests run.

The current set of tests:

flutter_image: runs a test server before running the test
flutter_lints: asserts that there is no Dart code outside of example/
pigeon: runs code generation, then does a bunch of tests (most or all of which are tests the tooling already knows how to run, except in subdirectories of the main package which is a complication)
rfw: makes coverage assertions

I think given the diversity here, we should just add a command for this to the tooling now, and then revisit eliminating the need for as many as possible (via additional tool functionality, such as pre/post run hooks for various types of tests) later.


[4.0] Swift Runtime Reporting: Change the ABI of the breakpoint function to stop using a boolean argument

Swift Runtime Reporting: Change the ABI of the breakpoint function to stop using a boolean argument (and replace it with uintptr_t 'flags'). There's apparently problems with retrieving boolean arguments via GetArgumentValues.  This cherry-picks 82ba3aa20f23726f5472f5dc8e8bd7064ee14bf5 into swift-4.0-branch.

@swift-ci please test

LGTM. Thanks Kuba!


Minor swedish translation update

Fixed som typos, and some initial instruction translations.

Thank you for the PR! Great stuff
I added some comments on small stuff that need to be addressed, let me know if there is anything I can do to help.

@Mr-Bajs Sorry i forgot to publish the comments


Convert to core_ml format?

Sorry, everyone, I am new to big projects such as alpha fold, and I am also a beginner at ml. Though, I wonder if it is possible to convert the alpha fold model to apple's core_ml model and take advantage of the headwear acceleration in both the intel and m1 models.


Oauth test load

https://github.com/fusor/cpma/issues/228

Looks good, I like this change. Will also be nice to get feedback from other folks.


pkg-config has not been configured for cross-compilation (external sys dependencies)

Hi, I'm sorry if this is not the right place to ask, but my application depends on libpulse-sys and causes the following error when I try to build it in the container. I understand that getting host system's libraries to link is not trivial, but I wonder if you can just compile and provide a cross-compiling pkg-config?
The following warnings were emitted during compilation:

warning: pkg-config has not been configured to support cross-compilation.

error: failed to run custom build command for `libpulse-sys v1.18.0`

Caused by:
  process didn't exit successfully: `/home/rust/src/target/release/build/libpulse-sys-0b539a63b06ecfcd/build-script-build` (exit code: 1)
  --- stdout
  cargo:rerun-if-env-changed=LIBPULSE_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS_x86_64-unknown-linux-musl
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS_x86_64_unknown_linux_musl
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG_ALLOW_CROSS
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-musl
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_musl
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-musl
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_musl
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=LIBPULSE_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS_x86_64-unknown-linux-musl
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS_x86_64_unknown_linux_musl
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG_ALLOW_CROSS
  cargo:rerun-if-env-changed=PKG_CONFIG_ALLOW_CROSS
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-musl
  cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_musl
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-musl
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_musl
  cargo:rerun-if-env-changed=TARGET_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR
  cargo:warning=pkg-config has not been configured to support cross-compilation.

                  Install a sysroot for the target platform and configure it via
                  PKG_CONFIG_SYSROOT_DIR and PKG_CONFIG_PATH, or install a
                  cross-compiling wrapper for pkg-config and set it via
                  PKG_CONFIG environment variable.
warning: build failed, waiting for other jobs to finish...
error: build failed

I'm happy to accept a PR implement it.

Toolchains and docker are not my thing but I can try and have a look! Thank you

Nevermind, turns out I can just set PKG_CONFIG_SYSROOT_DIR=/ and straight up build on my host with cargo build --target x86_64-unknown-linux-musl when I have that target installed.


Master

Codecov Report

Merging #1295 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1295      +/-   ##
===========================================
- Coverage    98.05%   98.05%   -0.01%
===========================================
  Files           45       45
  Lines         7413     7399      -14
===========================================
- Hits          7269     7255      -14
  Misses         144      144

Impacted Files
Coverage Δ

botocore/docs/bcdoc/style.py
95.22% <0%> (-0.14%)
:arrow_down:

botocore/model.py
97.46% <0%> (-0.02%)
:arrow_down:

botocore/docs/method.py
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 841804f...0aef7c3. Read the comment docs.