Waveshare-DSI-LCD can not display for yocto image with linux-raspberrypi 6.1.34 & 6.1.38

Hi
I post my issue here:
https://github.com/waveshare/Waveshare-DSI-LCD/issues/4#issuecomment-1662683896
in that page shows  if the kernel > 6.1.25  , it can support Waveshare-DSI-LCD,
I used meta-raspberrypi with yocto
commit dff85b9a9f66002856b9ed3b1aa3a384c0bc43d9
linux-raspberrypi-6.1: Update to 6.1.34 release
but it seems the kernel can not communicate with i2c,
so do I need to modify the default dtb(dts )file to enable i2c?
how can I do ? I want to know if the issue is about i2c communicate  or something else?
Thank you very much.

hi all ,
do you have any idea?
I have updated kernel to 6.1.38 and built the drivers in kernel, but it still can not  work for waveshare-dsi-lcd in yocto image. I do no know how to do now
and I tried to set "okay" in  dsi1 in dtsi ,but it not useful.
I want to know if ycoto image not support it ? but I think if ther kernel support it in raspbian image, it should support it.
I do not know why not work
any idea ?  @agherzan
Thanks
root@raspberrypi4-64:~# ls /dev/i2c*
/dev/i2c-0  /dev/i2c-1  /dev/i2c-10  /dev/i2c-20  /dev/i2c-21  /dev/i2c-22
root@raspberrypi4-64:~# modinfo panel-waveshare-dsi
name:           panel_waveshare_dsi
filename:       (builtin)
license:        GPL
file:           drivers/gpu/drm/panel/panel-waveshare-dsi
description:    Waveshare DSI panel driver
author:         Dave Stevenson<EMAIL_ADDRESS>root@raspberrypi4-64:~# modinfo goodix_ts
name:           goodix_ts
filename:       (builtin)
license:        GPL v2
file:           drivers/input/touchscreen/goodix_ts
description:    Goodix touchscreen driver
author:         Bastien Nocera<EMAIL_ADDRESS>author:         Benjamin Tissoires<EMAIL_ADDRESS>root@raspberrypi4-64:~# uname -a
Linux raspberrypi4-64 6.1.38-v8 #1 SMP PREEMPT Mon Jul 10 18:26:47 UTC 2023 aarx
root@raspberrypi4-64:~# ls /dev/i2c*
/dev/i2c-0  /dev/i2c-1  /dev/i2c-10  /dev/i2c-20  /dev/i2c-21  /dev/i2c-22
config.txt
dtparam=i2c1=on
dtparam=i2c_arm=on
enable_uart=1
dtoverlay=vc4-kms-v3d
dtparam=i2c_arm=on
dtoverlay=vc4-kms-v3d
dtoverlay=vc4-kms-dsi-waveshare-panel,8_0_inch
dtparam=i2c_vc=on

I am not sure how to guide you from here. I think the right way would be to ask, as you already did, on waveshare.

Here are the steps I used to get this working for me.
You do need to update the kernel version provided in meta-raspberrypi to a version that includes
the driver https://github.com/raspberrypi/linux/pull/5433.
I created a file called linux-raspberrypi_6.1.bbappend
LINUX_VERSION = "6.1.46"
SRCREV_machine = "e89e7655a197d28df49da2be7e2003436cf52197"

Then you need to add the driver dtbo file into /boot of the device for that you need to add
RPI_KERNEL_DEVICETREE_OVERLAYS += "\
  <... REPLACE THIS WITH ALL THE OVERLAYS YOU NEED ...>
  overlays/vc4-kms-dsi-waveshare-panel.dtbo \
"

For rest that you need I just used the default as a template and worked
from there. If you add this line to your local conf the built in one
does not apply anymore so beware.
You also need to enable i2c and configure the driver for you panel
KERNEL_MODULE_AUTOLOAD:rpi += " i2c-dev"

RPI_EXTRA_CONFIG = '\n \
# ----- CUSTOM OPTIONS SET IN local.conf ----------\n \
# Raspberry Pi 10_1 dsi \" display/touch screen \n \
dtparam=i2c_arm=on \n \
dtoverlay=vc4-kms-dsi-waveshare-panel,10_1_inch \n \
# ----- END CUSTOM OPTIONS SET IN local.conf ------ \n \
'

This was sufficient to get my 10" display working.
Hope this helps!

HI @omarhogni
thank you so much.
I did not do this step before :
RPI_KERNEL_DEVICETREE_OVERLAYS += "
<... REPLACE THIS WITH ALL THE OVERLAYS YOU NEED ...>
overlays/vc4-kms-dsi-waveshare-panel.dtbo
"
in my understanding , I am going to add this  line "overlays/vc4-kms-dsi-waveshare-panel.dtbo"  to file  conf/machine/include/rpi-base.inc ,  can  not add this line in build/conf/local.conf , right?
let me  try

@omarhogni
your solution works well 8" display
Thank you so much.

Here are the steps I used to get this working for me.
You do need to update the kernel version provided in meta-raspberrypi to a version that includes the driver raspberrypi/linux#5433.
I created a file called linux-raspberrypi_6.1.bbappend
LINUX_VERSION = "6.1.46"
SRCREV_machine = "e89e7655a197d28df49da2be7e2003436cf52197"

Then you need to add the driver dtbo file into /boot of the device for that you need to add
RPI_KERNEL_DEVICETREE_OVERLAYS += "\
  <... REPLACE THIS WITH ALL THE OVERLAYS YOU NEED ...>
  overlays/vc4-kms-dsi-waveshare-panel.dtbo \
"

For rest that you need I just used the default as a template and worked from there. If you add this line to your local conf the built in one does not apply anymore so beware.
You also need to enable i2c and configure the driver for you panel
KERNEL_MODULE_AUTOLOAD:rpi += " i2c-dev"

RPI_EXTRA_CONFIG = '\n \
# ----- CUSTOM OPTIONS SET IN local.conf ----------\n \
# Raspberry Pi 10_1 dsi \" display/touch screen \n \
dtparam=i2c_arm=on \n \
dtoverlay=vc4-kms-dsi-waveshare-panel,10_1_inch \n \
# ----- END CUSTOM OPTIONS SET IN local.conf ------ \n \
'

This was sufficient to get my 10" display working. Hope this helps!
Hey I am new to Yocto and the DTS stuff. Could you help me with explaining this in a little bit more detail. Especially where to edit what. Thanks

@bhaggenmiller

at you build folder conf/local.conf  to add the following:

RPI_EXTRA_CONFIG = '\n \
----- CUSTOM OPTIONS SET IN local.conf ----------\n \
Raspberry Pi 10_1 dsi " display/touch screen \n \
dtparam=i2c_arm=on \n
dtoverlay=vc4-kms-dsi-waveshare-panel,8_0_inch \n \
----- END CUSTOM OPTIONS SET IN local.conf ------ \n \
'

depend on  what git commit your are using meta-raspberrypi  because the solution is months ago

I am using  Author: Vivien Didelot<EMAIL_ADDRESS>Date:   Thu Aug 3 01:36:48 2023 -0400
anyway similarly
at folder meta-raspberrypi/recipes-kernel/linux  there was a latest linux version (at  a few month ago) .bb file  linux-raspberrypi_6.1.bb
so you
I created a file called linux-raspberrypi_6.1.bbappend
LINUX_VERSION = "6.1.46"
SRCREV_machine = "e89e7655a197d28df49da2be7e2003436cf52197"
when building, it will download the commit  of source code.   (maybe the currently master of  meta-raspberrypi  updated version already support DSI LCD, so you do not need this step
3, in file   meta-raspberrypi/conf/machine/include/rpi-base.inc to add  overlays/vc4-kms-dsi-waveshare-panel.dtbo
"
RPI_KERNEL_DEVICETREE_OVERLAYS += "
<... REPLACE THIS WITH ALL THE OVERLAYS YOU NEED ...>
overlays/vc4-kms-dsi-waveshare-panel.dtbo
"
and then, It will be :
overlays/vc4-kms-v3d-pi4.dtbo
overlays/vc4-kms-dsi-7inch.dtbo
overlays/w1-gpio.dtbo
overlays/w1-gpio-pullup.dtbo
overlays/wm8960-soundcard.dtbo
overlays/vc4-kms-dsi-waveshare-panel.dtbo
"
(same, maybe updated  master of  meta-raspberrypi  version  already added it, please have a look)
hope it  can help you

I have tried to create a custom yocto image on top of boot2qt. I am running into the following problems:

blank screen.
Qt app won't run as it says "No screens found" or "No DRM device found".

I tried to troubleshoot, but I am out of ideas.
Context:

I have a yocto custom boot2qt image that enables i2c via meta-raspberrypi settings.
My config has dtoverlay=vc4-kms-dsi-waveshare-panel,2_8_inch as waveshare's guide says.
I've tried every different variant of vc4-fkms-v3d and vc4-kms-v3d and vc4-kms-v3d-pi4

Output of lsmod | grep waveshare
root@b2qt-raspberrypi4-64:~# lsmod | grep waveshare
panel_waveshare_dsi    16384  0
backlight              24576  1 panel_waveshare_dsi

Output of ls /dev/dri
root@b2qt-raspberrypi4-64:~# ls /dev/dri/
by-path     card0       card1       renderD128

My entire config.txt file:
# Enable SPI bus
dtparam=spi=on
# Enable I2C
dtparam=i2c1=on
dtparam=i2c_arm=on

# Enable VC4 Graphics
# dtoverlay=vc4-kms-v3d # was causing problems with DSI display
# https://bugreports.qt.io/browse/QTBUG-106112
# https://forum.qt.io/topic/152160/official-7-raspberry-touch-screen-lcd-isn-t-working-with-boot2qt-6-6-for-raspberry-pi-4-64-bit/2
dtoverlay=vc4-fkms-v3d
# dtoverlay=vc4-kms-v3d-pi4

# Enable USB peripheral mode
dtoverlay=dwc2,dr_mode=peripheral
# Enable the onboard ALSA audio
dtparam=audio=on
dtoverlay=vc4-kms-dsi-waveshare-panel,2_8_inch

# enable both hdmi outputs
# max_framebuffers=2 # disabled to prevent conflict with DSI display

Linux kernel version:
root@b2qt-raspberrypi4-64:~# uname -a
Linux b2qt-raspberrypi4-64 6.1.54-v8 #1 SMP PREEMPT Wed Sep 20 14:13:53 UTC 2023 aarch64 GNU/Linux

Confirmed that I have waveshare overlay:
root@b2qt-raspberrypi4-64:~# ls /boot/overlays/ | grep waveshare
vc4-kms-dsi-waveshare-panel.dtbo
waveshare-can-fd-hat-mode-a.dtbo
waveshare-can-fd-hat-mode-b.dtbo

Note: I also tried using a compiled dtbo file from a linux kernel 6.6 /boot/overlays into my yocto image with a kernel of 6.1.54. This workaround doesn't load the module when querying: lsmod | grep waveshare.
Here is the dmesg error that repeats endlessly:
...
[  469.247935] Goodix-TS 10-0014: Error writing 1 bytes to 0x814e: -110
[  470.271888] i2c-bcm2835 fe205000.i2c: i2c transfer timed out
[  470.271936] Goodix-TS 10-0014: Error reading 10 bytes from 0x814e: -110
[  471.295900] i2c-bcm2835 fe205000.i2c: i2c transfer timed out
[  471.295949] Goodix-TS 10-0014: Error writing 1 bytes to 0x814e: -110
[  472.319893] i2c-bcm2835 fe205000.i2c: i2c transfer timed out
[  472.319944] Goodix-TS 10-0014: Error reading 10 bytes from 0x814e: -110
...

Problem: my screen is blank. My Qt app says "No screens available" or "No DRM device" depending on which vc4-* overlay I load.
Ahh, I'm out of ideas and lost. If anyone can give me any sort of hints that helped them, I'd appreciate it!
Could this be a faulty device that needs to be replaced?

Long couple days, but fixed.

Made sure to use 6.1.46 as noted in this thread. Don't know if this is absolutely necessary.
Another layer meta-boot2qt that I was building with enabled raspberry pi camera. From my research, I found other people had this problem of the DSI, GPIO, and camera i2c causing conflicts.
I made sure to adjust the KERNEL_MODULE_AUTOLOAD as noted in this thread as the meta-raspberrypi docs state a different method that is likely targeted for latest branches.

Thank you for the hints! I wonder if these problems never would have occurred if I updated the kernel to 6.6.x. I avoided this as I am a newbie when it comes to yocto and upgrading all layers seems daunting to me. Regardless, learned a lot of pieces from this debacle 😆

@bhaggenmiller
1. at you build folder conf/local.conf  to add the following:

RPI_EXTRA_CONFIG = '\n \
----- CUSTOM OPTIONS SET IN local.conf ----------\n \
Raspberry Pi 10_1 dsi " display/touch screen \n \
dtparam=i2c_arm=on \n dtoverlay=vc4-kms-dsi-waveshare-panel,8_0_inch \n \
----- END CUSTOM OPTIONS SET IN local.conf ------ \n \
'
2. depend on  what git commit your are using meta-raspberrypi  because the solution is months ago

I am using Author: Vivien Didelot<EMAIL_ADDRESS>Date: Thu Aug 3 01:36:48 2023 -0400
anyway similarly at folder meta-raspberrypi/recipes-kernel/linux there was a latest linux version (at a few month ago) .bb file linux-raspberrypi_6.1.bb so you I created a file called linux-raspberrypi_6.1.bbappend
LINUX_VERSION = "6.1.46" SRCREV_machine = "e89e7655a197d28df49da2be7e2003436cf52197"
when building, it will download the commit of source code. (maybe the currently master of meta-raspberrypi updated version already support DSI LCD, so you do not need this step
3, in file meta-raspberrypi/conf/machine/include/rpi-base.inc to add overlays/vc4-kms-dsi-waveshare-panel.dtbo " RPI_KERNEL_DEVICETREE_OVERLAYS += " <... REPLACE THIS WITH ALL THE OVERLAYS YOU NEED ...> overlays/vc4-kms-dsi-waveshare-panel.dtbo "
and then, It will be :
overlays/vc4-kms-v3d-pi4.dtbo overlays/vc4-kms-dsi-7inch.dtbo overlays/w1-gpio.dtbo overlays/w1-gpio-pullup.dtbo overlays/wm8960-soundcard.dtbo overlays/vc4-kms-dsi-waveshare-panel.dtbo "
(same, maybe updated master of meta-raspberrypi version already added it, please have a look)
hope it can help you
if master of meta-raspberrypi version is already added it (I forget from what kernel version , it already support DSI), so you do not need step 2 to download "6.1.46" and commit "e89e7655a197d28df49da2be7e2003436cf52197".
you only need step 1 and step 3 ,I think

Thanks for your help. The display is no working. Unfortunately the application is not working properly. It s a html5/js page which runs on localhost in cog webengine.   I used chromium to display page. you can use a regular hdmi screen to make sure you app can run well, and then switch to DSI screen. just guess

@bhaggenmiller Maybe your issue is not at DSI display, just at your APPs. I used chromium to display page. you can use a regular hdmi screen to make sure you app can run well, and then switch to DSI screen. just guess

Mhm on PI OS it works fine. Therefore i don t think the app is the problem.


User Authentication (Signup)

Use the collection.json from Release and import it to your Postman.
Use the predefined routes to test the APIs
Integrate the Signup feature

please assign this issue to me

Go ahead :) @theCodeCrusaderX

please provide collection.json file , i can not found

please provide collection.json file , i can not found

Check the release notes


Schedule via ASP.NET

Hi,
I tried to schedule the task via ASP.NET application running in IIS 7.5 in Windows 2008 R2 environment.
The error message is
*## Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))
**Description:
An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.
Exception Details: System.UnauthorizedAccessException: Access is denied. (Exception from HRESULT: 0x80070005 (E_ACCESSDENIED))
ASP.NET is not authorized to access the requested resource. Consider granting access rights to the resource to the ASP.NET request identity. ASP.NET has a base process identity (typically {MACHINE}\ASPNET on IIS 5 or Network Service on IIS 6) that is used if the application is not impersonating. If the application is impersonating via , the identity will be the anonymous user (typically IUSR_MACHINENAME) or the authenticated request user.
To grant ASP.NET access to a file, right-click the file in Explorer, choose "Properties" and select the Security tab. Click "Add" to add the appropriate user or group. Highlight the ASP.NET account, and check the boxes for the desired .***
I went to C:\Windows\System32\Tasks folder to give full permission to Network Service(the application pool that run the web application) but still having the same error above.  I also given full access to Everyone group but still not able to schedule.
Anybody having the same error?
Thanks.
Originally posted: 2012-04-16T00:53:53

Hi,
I have managed to resolve this issue.
Just create the TaskDefinition td = ts.NewTask() without assigning the user id and password.
Originally posted: 2012-04-16T04:53:32

Hi
TaskService ts = new TaskService();
Version ver = ts.HighestSupportedVersion;
bool newVer = (ver >= new Version(1, 2));
TaskFolder tf = ts.RootFolder;
This might works?
Ajay
Originally posted: 2012-07-16T07:12:39


persist subscriptions after broker restart

Hi,
When I do emqttd server restart,it looses all the existing subscriptions.Currently,I am using default configurations.Please help me in solving this issue.
Thank you..

check out the Redis plugin. It seems that it got the feature to remember the client subscriptions.


Darkening affects Journeymap minimap

Clicking the "dark mode" button results in the Journeymap minimap being darkened like the rest of the GUI, which makes it much more difficult to read. Another user mentioned the same problem on reddit. This is occurring for me on 1.19 and the ATM8 modpack.

Awesome mod!  Blackens everything and the automatic contrast adjustment for the gui names is a great idea BUT the darkening of the mini-map in Journeymap, definitely is an issue, I usually run it in Toasted Light Mode, so the map is still legible,  but any of the darker modes make it pretty much illegible.
Also, not major, but on the gui for the mod "Disenchantment Edit Table" (by ji_GGO) the "Disenchant" heading doesn't switch to white when in a dark mode, even though the "Inventory" heading does.  Names are for the screen and container are:

Screen:  "com.jiggo.editenchanting.client.gui.DisenchantmentScreen"
Container:  "com.jiggo.editenchanting.common.inventory,Disenchantment.Menu


No option to install to Visual Studio 2017

Installing to Visual Studio 2015 is the only option for me

Thanks for your report, will be fixed next update.
Duplicate of:  https://github.com/arjankuijpers/SpotifyRemote/issues/7

This issue is fixed. Please let me know if you still have issues installing for Visual Studio 2017.


Overview duplicate links

Sometimes when generating docs, we get more then one overview.

The issue is that SECURITY and CONTRIBUTING is getting the wrong slug. SECURITY can be filtered out since we now have a generic for everything. CONTRIBUTING should have a special case like CHANGELOG.

Solved by https://github.com/XenitAB/xenitab.github.io/pull/46


CSS in HTML

We ask that you please be patient as our team works through approving and publishing all articles/tutorials in a timely manner. Allow 1-3 days for a topic to be reviewed and/or approved - allow 3-7 days for an articles to be reviewed and/or published.
Be sure to visit our Resources Page for tools, resources, and example articles to go over.
NOTE: (Please ensure that you have only one open issue + linked pull request at a time. This will ensure that we complete the article in a timely manner from inception to publishing.)
NOTE: We tend to stray away or tend not to publish reviews/comparisons of commercial product offerings.
We're looking for the first 2-3 paragraphs of the article that appropriately summarize what your article will be about.
Proposed title of article
CSS in HTML
Introduction paragraph (2-3 paragraphs):
Adding styles to your webpage (HTML) is a given to give the look you actually desire. The language for adding styles to our webpage is called CSS (Cascading style sheet).
There are three approaches to adding CSS to your HTML page (s). This is a beginner centric tutorial teaching you how to add CSS to your HTML page (s). In this tutorial, you will learn when to use those different approaches and which approach is suitable for which condition. Basic knowledge of HTML and CSS is assumed.
Key takeaways:
Inline CSS
CSS in a single HTML page
External Stylesheet
References:
Please list links to any published content/research that you intend to use to support/guide this article.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

https://www.section.io/engineering-education/what-is-css/
https://www.section.io/engineering-education/embedding-a-video-into-a-webpage-using-html-and-css/

@WanjaMIKE my article goes more in-depth by showing the pros and cons of the approaches and when to use them

Not approved - @temitope-david
We have multiple articles/tutorials covering the topic very well.

Not approved - @temitope-david
We have multiple articles/tutorials covering the topic very well.

Please feel free to submit another topic for approval 🚀


Return correct subclass from relationship

I have a model with this design: Gene is located on either Chromosome or Contig. At the moment I'm solving this in the model by creating a class Feature from which both Chromosome and Contig inherit. The RelationshipTo is restricted to specifying a single class, so node I have code similar to:
class Feature(StructuredNode):
    name = StringProperty()
    location = RelationshipTo('Feature', 'LOCATED_ON', cardinality=One)

class Gene(Feature):
    description = StringProperty()

class Chromosome(Feature):
    pass

class Contig(Feature):
    pass

In the real model, Contig and Chromosome have different attributes. The problems that arise with this model are that:

A spurious label (Feature) is introduced into the database.
When querying for location (gene.location.all()) a Feature is returned, not the actual Chromosome or Contig that the gene is located on.

Inside the code the correct label is identified during querying but the actual object returned is of the superclass.

Hmm if you add abstract_node to Feature it will solve the issue. Presuming Feature is abstract? The behaviour is a bit strange though and needs to be fixed

There are a number of bugs related to this.

If you specify that Feature is an __abstract_node__ and then set a cardinality=One attribute on the location relationship, you get this error:

/home/pvh/anaconda3/bin/python /home/pvh/Documents/code/SANBI/neo4j_notebook/neo4j_experiments.py
Traceback (most recent call last):
  File "/home/pvh/Documents/code/SANBI/neo4j_notebook/neo4j_experiments.py", line 195, in <module>
    thing.location.connect(chrom)
  File "/home/pvh/anaconda3/lib/python3.5/site-packages/neomodel/cardinality.py", line 124, in connect
    if len(self):
  File "/home/pvh/anaconda3/lib/python3.5/site-packages/neomodel/relationship_manager.py", line 309, in __len__
    return self._new_traversal().__len__()
  File "/home/pvh/anaconda3/lib/python3.5/site-packages/neomodel/match.py", line 446, in __len__
    return self.query_cls(self).build_ast()._count()
  File "/home/pvh/anaconda3/lib/python3.5/site-packages/neomodel/match.py", line 220, in build_ast
    self.build_source(self.node_set)
  File "/home/pvh/anaconda3/lib/python3.5/site-packages/neomodel/match.py", line 231, in build_source
    return self.build_traversal(source)
  File "/home/pvh/anaconda3/lib/python3.5/site-packages/neomodel/match.py", line 275, in build_traversal
    rhs_label = ':' + traversal.target_class.__label__
AttributeError: type object 'Feature' has no attribute '__label__'

What is going on here is  that One is calling len() which calls __len__() on RelationshipManager which in turn calls _new_traversal() which ultimately leads to the error because in the definition of the traversal the target class is Feature which has no label.
If you don't use the cardinality attribute you're left with problem 2 mentioned above.

Thinking about this some more... I think the correct solution is that you need to keep the Feature labels to enable queries to work, but when you inflate the resulting objects from the data, you need to inflate to the subclass mentioned in the subclass label.

@robinedwards The idea behind #263 is to apply this logic:

If a node has multiple labels one of those labels might be a valid subclass of the class in the traversal's description.
We can find the subclasses of the class mentioned in the traversal's description by walking the correct Python datastructure. So we can build a list of these.
If one of these intersects with the list of labels, we should use that class as the class of node to create.
If more than one of  them intersects with the list of labels we don't know what to do. This is an error.

This logic works for me. I think it is valid in the general case.

Hey apologies my brain wasn't in gear yesterday.
We need to be a little bit careful as I think there is some existing functionality built around assuming abstract nodes dont have labels.. However your case above (relation to abstract node) should definitely raise a friendly error message in the current release of neomodel.
What you are trying to achieve is quite similar to #126
Now I am not opposed to changing the behaviour of inheritance in a major release of neomodel, the current situation is confusing at best. In fact the whole handling of 'abstract nodes' is hacky and unpythonic. One issue with the subclass behaviour is when someone wants to build a model which actually points to the super class (none abstract) it becomes tricky.

@pvanheus Can I please ask if you have tried version 3.3.1? The changes there would cover this use-case I wonder if this would be enough to close this issue (?).


Bad merge with language files

Describe the bug
The Chinese/tw language files were merged incorrectly see: https://github.com/b310-digital/teammapper/blob/422b2114c5ba558ad21b0d97d49165bfa5641f38/teammapper-frontend/src/assets/i18n/zh-tw.json#L169
Also the key MAP_COULD_NOT_BE_FOUND is not present in the error section as done in the other language files.

Partly fixed within https://github.com/b310-digital/teammapper/commit/7a0fee095214cfa02dd439418cb90b542b97cfad
but the MAP_COULD_NOT_BE_FOUND is still in the wrong place for these two language files @sorenjohanson


Added event filter UI

Ticket
Ticket Link
What is changed / added

Added filters
No internal logic added

Screenshots

@TheFatPanda97 ok


Servers can be limited in API by environment variable

Requirements

Server to which API is allowed to connect can be limited through an environment variable.

If no variable is specified, API will connect to any server
Environment variable will support a comma separated list of mail hosts to which it can connect

Not trusted servers are correctly blocked by API


Add absolute_import needed for python2

I'm not sure what the plan for python2 support is, but when using awkward array in python 2, the awkward.pandas module cannot be loaded, because there is a clash in the module name between pandas itself, and the awkward.pandas module.  The import that takes place internally for pandas.api.extension then fails:
$ python --version
Python 2.7.15

$ python -c "import awkward.pandas as mod;print(mod)"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/ben/projects/awkward-array/awkward/pandas.py", line 6, in <module>
    import pandas.api.extensions
ImportError: No module named api.extensions

This is addressed by insisting on absollute_imports, which is default in python3 and needs importing from __future__ in python2.

I've added a unit test to catch this issue although the test will be skipped since no testing environment currently includes pandas.  Would you be ok that we make pandas a dependency of the testing suite, @jpivarski?

Yes, Pandas can be added to the test_requires. You'd have to link the Pandas version to the Python version to get 2.7, though. I think the last Pandas version that worked in 2.7 was Pandas 0.23, released at the end of last year.
Also, I approve this PR and will merge it as soon as you give me the go-ahead (and tests pass).

Hmm, I'd understand if you don't want to add an explicit python 2 setup at this stage, given how close the end-of-life is for Python 2.  I could leave the pandas version unpinned in test_requires, which might be better than no pandas testing at all (and the test I've added literally just imports the module)? Or if you want to leave it out to avoid complicating things now that's reasonable to me, in which case this PR would be good to go.

Allow me to chip in: did we not agree within the org to (try and) provide a last major version of each package Python 2.7 compatible? Judging from the metadata in https://github.com/scikit-hep/awkward-array/blob/master/setup.py this is ensured at present, so it should be no problem to maintain 2.7 compatibility for a bit longer, right?

I'm willing to support Python 2.7. All we need is for the .travis.yml to put a constraint on the Pandas version when it loads, similar to this:
https://github.com/scikit-hep/uproot/blob/03072b07d22af4b6247ed99ead957d238daffaae/.travis.yml#L63
(Although in awkward's travis.yml, the variable is named $TRAVIS_PYTHON_VERSION.)
Leaving the pytest.importorskip in is a good idea. We do Apache Arrow the same way: it's not a dependency, but tested if it's possible to install, using a version that manages to be installed on the Python version in question.

Python 2.6 is where I draw the line: scikit-hep/uproot#402.

Makes sense. @benkrikler, will you then complete this PR yourself, as per the suggestions above? Seems the easiest.

This has turned into a bigger thread than I expected!
I see a 2x2 matrix of solutions:

Dimension 1: do I install via travis or within setup.py
Dimension 2: do I specify a pandas version (as a function of the python version) or leave the pandas version unpinned.

For dimension 2 there: unpinned has "risks" that our tests break on a future version of pandas.  For the test I've added here, I'm confident to say that should be literally impossible (in a test pipeline) since the test only checks for importability and any pip / conda installed version of pandas should be importable.  If this test is extended in the future then you could change the pinning, although by then python 2 support might be dropped anyway.
For dimension 1: installing from setup.py as a test_requires seems nicer and more general (e.g. if you switch to azure-CI in the future).  The downsides are 1) everyone running the tests needs to install pandas, although counter-argument: that's pretty quick and easy anyway, and probably already the case for most users that actually run tests.  Downside 2): if we want to define the pandas version as a function of the python version (dimension 2. above) then doing that in setup.py would be messy with environment variables and / or sys.
Anyway, without milking this more: can I add to test_requires of setup.py pandas, which has no version pinning?

Also, the last version of pandas to support python 2 officially was 0.24.2, based on the 0.24.0 release: https://github.com/pandas-dev/pandas/releases/tag/v0.24.0, so if I had to pin a version for python 2 that's what I'd use.

@benkrikler I've been pinning versions of NumPy and Numba in my Python 2.7 tests (and some old versions of Python 3, too). Since a final version is now known, I don't see any danger in it: Pandas 0.24.2 will always and forever be the best Pandas for Python 2.7.
I consider a user who runs the unit tests to be an expert user who can ensure that they have the right dependency versions. I think you can only run tests if you get the repo from GitHub—it's dropped from the PyPI/conda packages. Therefore, I worry a lot more about what goes into the requires than the test_requires. Even though the packages used in tests are included in the test_requires, each one of them is explicitly installed in .travis.yml because we want to be so careful about versions.
So don't worry about getting the version constraint right in test_requires; just say test_requires = [..., "pandas"], which would do the right thing for a sufficiently recent version of Python (or don't include it in the test_requires at all, since the test has an importorskip). But in the .travis.yml, run pip install "pandas<0.25" for Python 2.7 and pip install pandas for all other versions of Python (and maybe no Pandas at all for PyPy if it gives you trouble). Don't worry about AppVeyor.

Ok, I think it should all be good to go now for you, @jpivarski.

Thanks!


mandatory fields

[x] define list of mandatory fields (per page?)  SC
[x] check that FE implements the constraint  SK
[x] verify the DB situation SC
[x] implement a clear demarcation for mandatory fields (is the * enough? should we use another color for field name? change the bold settings, now applied to all fields?) SK

NB: at the moment, the repo manager enter just the study title and then let the submitter fill the rest. idem for DO. so we cannot enforce the constraint on the FE, (unless we can distinguish the role of user?). DB will stay as it is (also because sometime the field is missing from MDR).

rather minimal:
study: title, type, status, start year
DO: title, type  (enough? depending on type?)

if the fields in the previous comment are fine, we can just set default values for status, start year (studies) and type (DOs). could lead to wrong assignemets (but repo manager can check)

I can make conditional checks for the validation fields based on the role so it won't be an issue to make constrains in the FE

thank you @Swarnalathaa , perfect. i assign back to you for the implementation, i.e. mandatory fields in FE as defined previously
study: title, type, status, start year
DO: title, type
taking into account that RM will input only title for both.

tested as admin. TODO: as normal user.

the check of mandatory fields works fine with the normal user as well.
all the issues of the previous comment are still valid though: @Swarnalathaa could you please fix them so we can close this one?

the moving of the focus on the missing fields is done.
for the rest regarding wording in the fields/dropdown/headers will list them in another issue (see also doc in #47 )


Why does AFQueryStringPairsFromKeyAndValue() deal with value NSArray with @"%@[]"? This makes the URL params result like list[]=value, I think the URL params should be like list = [value]

That's a good question—I would actually expect them to look like foo[0]=bar&foo[1]=baz.


Empty DOM element converted to self closing tag

Hi, I got this issue where if I have an empty tag, your plugin will convert it to self closing tag. For example:

Will become:

<svg>svg content</svg>

And then in chrome it renders to:

  <svg>svg content</svg>

Is there a way to prevent this?

Hi @lusiakpurnama,
have you tried using XML mode?

@haensl seems the xml mode is true by default.
I just tried to set it to false, and it works.
Though now there is another issue I'm having. I'm using your plugin to embed svg to liquid templates for shopify.
But then if there is a liquid expression in any html tag, the plugin seems to try to "correct" the value. For example:

some div

It becomes:

some div

This is probably nothing to do with your plugin though cause I tried this plugin also does that:
https://github.com/viktorlarsson/gulp-inject-svg
Just want to mention, I probably cannot use your plugin for uncompiled html templates 😄

Hi @lusiakpurnama,

I probably cannot use your plugin for uncompiled html templates

Maybe your build flow allows for reordering so that templates are compiled before SVGs are inserted?

Hi @haensl,
I cannot do that. Since you are asking that I suppose you don't know Shopify?
It's an e-commerce CMS system, I think kind of like wordpress but for selling products.
And they have their own templating language called Liquid.
So what I'm working on is the theme for the shop, kind of like theme for wordpress.
What I'm doing currently is optimising the theme, reducing the stuff that Shopify need to compile, so I inject svg using gulp instead of using Liquid function to inject svg on compile in the store.

Hi there, I have a similar issue where I'm adding SVGs into Wordpress template files (which use PHP).
The actual embedding of the SVG works great, but the plugin is modifying the entire PHP page. So, for example:
<?php wp_head(); ?>
Becomes

Which makes the file unreadable by the server, especially when multiplied across all other php tags in the file.
Is there any way of running the plugin so it only touches the elements of the page within  tags, and leaves the rest of the page alone?
Thanks in advance!


Remove leading spaces of username when login

When we run docker login we will be asked to input our username.
Prior to this PR, "userA" and " userA" will be considered as two
diferrent user, which is not right.
Signed-off-by: Hu Keping<EMAIL_ADDRESS>

@HuKeping Actually hub is accepting logins with leading spaces :) But I'm with you that that's not cool.

LGTM

LGTM


Fix and enhance Linq feature

Fix and enhance Linq feature
This PR makes the following changes:

Make interface internal
Fix Save() method by not saving if XDocument.Root is null
Add IsRootXElementLoaded(this OpenXmlPart part) extension method
Rename interfaces and classes
Add unit tests

The new naming is based on the OpenXmlPartRootElement class. We are essentially dealing with XElement representations of OpenXmlPartRootElement instances that can be accessed directly via GetXElement() or indirectly via the containing XDocument that can be accessed via GetXDocument().

/azp run


Lp changes

Changes included a slight edit to one graphic, slight paragraph changes for clarity (where necessary), and grammar and typo fixes.

finished changes


HR-83 Adds app into microsoft team meeting room

Changed the manifest file to allow the app to be loaded into Teams meeting
Deleted the unused files
Set up app structure:

Added configuration page
Added capabilities for shared views

New icon and app name/description

Logo looks nice! Gj


Data type

I wonder why it doesn't support int and unsigned char?
I compile with nvcc -arch=sm_70 test.cu -o test

I wonder why it doesn't support int and unsigned char?
I compile with nvcc -arch=sm_70 test.cu -o test

Sorry, I'm not sure I understand your question.
Plz post your code and error message here.


Can't choose "remove" in hook generator

you cannot choose "remove" so you have to add these manually.
To reproduce simply run through the tutorial (sample chat app) and try
yo feathers:hook

Hmm. I can't reproduce. I am able to see it and select/deselect it by hitting spacebar. Maybe it is a terminal height issue? Anyone else able to reproduce this?

@willkessler What are your terminal line number settings? If it doesn't let you scroll down then we might escalate this as a Yeoman or Inquirer bug.

Ok going to close this for now. If it comes up again or @willkessler is still having issues then we can re-open.


Candidates repos for archiving and removing due to license mismatch

[ ] nomad has a license mismatch - https://github.com/flatcar/nomad-on-flatcar/issues/4
[ ] Grub is archived and read-only - could it be removed and change to use an upstream source? https://github.com/flatcar/grub
[ ] shim - https://github.com/flatcar/shim

Grub is archived and read-only - could it be removed and change to use an upstream source? flatcar/grub

The repo cannot be removed as it is still being used in LTS-2023, LTS-2022. Since LTS-2023 is recently branched out, the repo should be available for the tenure of the same.

shim - flatcar/shim
TODO

[ ] Once moved to flatcar-hub, change the urls and not rely on redirects.


Why procedure retrieves cannot resolve with a direct-reference code?

Addressed in 1.4.0 release. This was a combination of issues between the translator and the various retrieve implementations and has been addressed by other fixes.


Support for readiness probe options for pilot in the helm chart

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)
Describe the feature request
I see readiness probe options in the values for:
global:
   proxy:
      readinessPeriodSeconds: 2

I'd like to change the readiness probe values for the istiod deployment tho, am I missing something here? The reason I'm looking for this is because I'm trying to to use GKE multi-cluster-services and export the istiod service and Google is requiring that the TimeoutSeconds must be less than or equal to PeriodSeconds.
status:
  conditions:
  - lastTransitionTime: "2023-09-26T11:22:11Z"
    status: "True"
    type: Initialized
  - lastTransitionTime: "2023-09-26T21:12:24Z"
    message: '&ServicePort{Name:grpc-xds,Protocol:TCP,Port:15010,TargetPort:{0 15010
      },NodePort:0,AppProtocol:nil,} has error: invalid ReadinessProbe configuration:
      TimeoutSeconds must be less than or equal to PeriodSeconds;&ServicePort{Name:https-webhook,Protocol:TCP,Port:443,TargetPort:{0
      15017 },NodePort:0,AppProtocol:nil,} has error: invalid ReadinessProbe configuration:
      TimeoutSeconds must be less than or equal to PeriodSeconds'
    reason: ReadinessProbeError
    status: "False"
    type: Exported

I don't know if this a standard k8s deploy thing or something MCS is requiring specifically.
Describe alternatives you've considered
Patch deployment or extend chart.
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

Maybe it's fair to just request that the TimeoutSeconds should be less than or equal to PeriodSeconds?

Is this something that might be a good add to the chart or am I misunderstanding the current implementation?


Refactor Transaction to match spec

This PR refactors Transaction in the many-types module to match specification, as cited in https://github.com/liftedinit/many-rs/issues/207

Codecov Report

Merging #229 (2890c73) into main (e083d9f) will decrease coverage by 1.82%.
The diff coverage is 3.06%.

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
- Coverage   70.53%   68.71%   -1.83%
==========================================
  Files          81       83       +2
  Lines        9450     9707     +257
==========================================
+ Hits         6666     6670       +4
- Misses       2784     3037     +253

Impacted Files
Coverage Δ

src/many-types/src/blockchain.rs
72.41% <ø> (ø)

src/many-types/src/lib.rs
63.08% <ø> (ø)

src/many-types/src/request.rs
0.00% <0.00%> (ø)

src/many-types/src/response.rs
0.00% <0.00%> (ø)

src/many-modules/src/_1_blockchain.rs
97.06% <100.00%> (+0.04%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

If you want to eliminate many-protocol itself and move everything in many-types, that would make sense.

If you want to eliminate many-protocol itself and move everything in many-types, that would make sense.

Great, I can do that.

Hey,
WORKSPACE.bazel still references many-protocol, i.e., the Bazel build is broken.
README.md still references many-protocol
src/many-types/BUILD.bazel still references many-protocol

Ugh . . . I had these changes made locally, and thought that I pushed, but forgot to save those files.  I'll push them now.

Oh, and the Bazel build is still broken
➜  many-rs git:(oobi/transaction-impl-to-spec) ✗ bazel build //...:all-targets
ERROR: /home/fmorency/dev/many-rs/src/many-identity-dsa/BUILD.bazel:36:13: in rust_library rule //src/many-identity-dsa:many-identity-dsa-for-test: target '//src/many-types:many-types-for-test' is not visible from target '//src/many-identity-dsa:many-identity-dsa-for-test'. Check the visibility declaration of the former target if you think the dependency is legitimate
ERROR: /home/fmorency/dev/many-rs/src/many-identity-dsa/BUILD.bazel:36:13: Analysis of target '//src/many-identity-dsa:many-identity-dsa-for-test' failed
ERROR: Analysis of target '//src/many-identity-hsm:many-identity-hsm-for-test' failed; build aborted:
INFO: Elapsed time: 5.397s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (434 packages loaded, 10670 targets configured)

One last thing, we are using a fork model. Can you fork the repo and work on a branch on your fork, i.e., NOT a branch upstream?
@hansl it appears we can still push branches upstream. Can you disable that, please?

Closing to move to a branch of the fork, instead of having a pull off of the upstream branch


feat(button): adds icon control to buttons

Description
Allows for the creation of two new button types

Button with text and icon, with icon positioning via iconPosition property
Button with icon only, set up via iconButton property

Also contains a refactor of the stylesheet setup to match other components in the repository. I don't think those changes quantify as a breaking change, however it does remind me that we need to document this better.
I've configured the storybook knobs to allow users to try out all the different settings, while still keeping the short cuts to the primary variants to match the DSM. There are two storybook knob panels

properties which have a direct mapping to the component properties
content which provide some flexibility to control the content inside the story, but do not match to component properties.

Requirements
Storybook link: https://deploy-preview-19--legal-and-general-canopy.netlify.app/?path=/story/components-button--primary-button
Design link: https://legalandgeneral.invisionapp.com/share/A4X6XFIYKFV#/416751146_Button
Screenshot:

Checklist:

[x] The commit messages follow the convention for this project
[x] I have provided an adequate amount of test coverage
[x] I have added the functionality to the test app
[x] I have provided a story in storybook to document the changes
[x] I have provided documentation in the notes section of the story
[ ] I have added any new public feature modules to public-api.ts
[x] I have linked the new component to adobe DSM (if appropriate)

Design Review: Button - Icon Only
The button's not quite square, it should be 44x44px - it seems to be both fractionally too wide and too short. The Add icon also seems to be missing its rounded caps - do we have the right SVG uploaded or is it just rendering like that at that particular scale?

Design Review: Button - Icon + Label and Label + Icon
Both buttons seem to have an extra 4px padding on each side...

Button: Icon-only
Thanks for the fix, looks great 👍🏻

Button: Label + Icon
This seems to have gone the other way, now it’s 8px short either side, plus a pixel short between the label and the icon itself...

Button: Icon + Label
This one's also gone the other way, but it's 8px short on the left and 9px on the right.

Hi @james-hayden-ellis thanks for double checking, I had another crack at it. I haven't got the invision app downloaded to do the alpha fade test, but just to double check these are the spaces to run against?

Hi @thatguynamedandy - There should be 20px on the left, 8px between the label and the icon and 20px on the right, and that goes for both (icon left and icon right) going by our Canopy Sketch Library.


Add support for run constraints

This is the idea that Factotum should only execute if a "run constraint" specified on the CLI resolves to true.
This is a powerful feature (taken from Snowplow's internal executor), which lets you have the same Factotum invocation in the cron on multiple boxes, but only one box will execute the job.
Example cronfile:
BOX1=box1.acme.internal
BOX2=box2.acme.internal

/opt/factotum-0.4.0/factotum first-dag.factotum --constraint "host,${BOX1}"
/opt/factotum-0.4.0/factotum secnd-dag.factotum --constraint "host,${BOX2}"

To start with, we only allow one constraint, and the only allowed constraint is host, and the implied check is ==.

Hey!
This functionality can be reproduced like this:
{
    "schema": "iglu:com.snowplowanalytics.factotum/factfile/jsonschema/1-0-0",
    "data": {
        "name": "constraint demo",
        "tasks": [
            {
                "name": "box check",
                "executor": "shell",
                "command": "if [ \"{{box_name}}\" = \"1\" ]; then exit 1; else exit 0; fi",
                "arguments": [],
                "dependsOn": [],
                "onResult": {
                    "terminateJobWithSuccess": [ 0 ],
                    "continueJob": [ 1 ]
                }
            },
            {
                "name": "execute",
                "executor": "shell",
                "command": "echo",
                "arguments": [ "beta" ],
                "dependsOn": [ "box check" ],
                "onResult": {
                    "terminateJobWithSuccess": [ 3 ],
                    "continueJob": [ 0 ]
                }
            }
        ]
    }
}

and running like this:
factotum run ./noop_constraint.factfile --env '{"box_name": "1"}'

This may not be specific enough for this use-case, but I thought I'd mention this anyway

Hey @ninjabear - that's really neat. An emergent property of Factotum!
I think we need to keep this as a feature however, because otherwise we have to mutate all of our factfiles to add this check...


Quartus requires i686-linux to build on x86_64-linux

Strangely, quartus-prime-lite fails to build with this error on x86_64-linux:
$ nix-build -E "with import ./default.nix {}; pkgs.quartus-prime-lite"
these derivations will be built:
  /nix/store/wym8x12v6afz1aybfabk0ihbqf0x2ghs-freetype-2.10.1.drv
  /nix/store/qnjjxj5c17ngqkrlyy1l81a955m2i8v9-fontconfig-2.12.6.drv
  /nix/store/jsdivm9rzcdvsqv6rnqa76s1wzcm8niq-libXft-2.3.3.drv
  /nix/store/4zdv8s32x5g09grycmbjrw1c2jxlk0sq-quartus-prime-lite-usr-target.drv
  /nix/store/bcdck5l2s2n6g6s2j7c6yyvidb6imgi0-freetype-2.10.1.drv
  /nix/store/pdcm066b6fxr6wv2vw6lwjlrqgx5alwn-config-compat.patch.drv
  /nix/store/zsivw8p4mz11a437xb5jvi80nzjd4hzn-fontconfig-2.12.6.drv
  /nix/store/f3lbvp6h1cbrjqgvnb2gmf324rc5qs0y-libXft-2.3.3.drv
  /nix/store/8f3brj1lm8vfrdjxjq64003zrbsj52f0-quartus-prime-lite-usr-multi.drv
  /nix/store/dwzhr9216m7lqvqccqivzwgmw8lb5g01-quartus-prime-lite-fhs.drv
  /nix/store/6058iz60gpwglpryz4f44vzssii3xs0g-quartus-prime-lite-init.drv
  /nix/store/7iafhc9gijdn0l6418gj0iym7fj8asmz-quartus-prime-lite-unwrapped-<IP_ADDRESS>0.drv
  /nix/store/09yclccbazvibcw61zj3lrsg4zcq0zll-quartus-prime-lite.drv
these paths will be fetched (0.34 MiB download, 1.95 MiB unpacked):
  /nix/store/0p8g02awmk740mxpnqlnwjk4vghl59yq-freetype-2.10.1-dev
  /nix/store/1m9r729wa560srby0zwkcwyxnzp1a964-fontconfig-2.12.6-dev
  /nix/store/6hz7bdaxyrgm52j1xsc3vajy2iwmrf88-libpng-apng-1.6.37-dev
  /nix/store/9247j6yyly100wz7nmqfnb0bway08ny7-libpng-1.2.59-dev
  /nix/store/bmwf5mkrz5x3wgcbh4qrkzkcqc382fyz-libxslt-1.1.34-dev
  /nix/store/d4dwn44nsh4z170brf5f5c64hdmzb3sn-libxml2-2.9.10-dev
  /nix/store/m7zzxlw2r9gsin4yqmbffl6lqpn85rpb-fontconfig-2.12.6-bin
building '/nix/store/7iafhc9gijdn0l6418gj0iym7fj8asmz-quartus-prime-lite-unwrapped-<IP_ADDRESS>0.drv'...
error: a 'i686-linux' with features {} is required to build '/nix/store/pdcm066b6fxr6wv2vw6lwjlrqgx5alwn-config-compat.patch.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}

This issue seems to be coming from substiteAll used in fontconfig, but after digging for a while I wasn't able to work out how the platform was being set to i686-linux for substitueAll; seems a 32-bit bash is being used?
$ nix show-derivation /nix/store/pdcm066b6fxr6wv2vw6lwjlrqgx5alwn-config-compat.patch.drv
{
  "/nix/store/pdcm066b6fxr6wv2vw6lwjlrqgx5alwn-config-compat.patch.drv": {
    "outputs": {
      "out": {
        "path": "/nix/store/fm0ix13flkhvavccs85x2jvjj80gp78l-config-compat.patch"
      }
    },
    "inputSrcs": [
      "/nix/store/4vq3350zc6sqnibkqpgic2d6cvi1r9hq-substitute-all.sh",
      "/nix/store/nhfili4xslqbbrm2cw236vm2w3yqq2yc-config-compat.patch"
    ],
    "inputDrvs": {
      "/nix/store/15p06bmkvrkfqdv7dd9dj1nlm9zkkw6f-bash-4.4-p23.drv": [
        "out"
      ],
      "/nix/store/dx7lq49sagb9sh1ymcvryj2y2f8ly4ab-stdenv-linux.drv": [
        "out"
      ]
    },
    "platform": "i686-linux",
    "builder": "/nix/store/aikkh4qin26v6m645q35205zn7krmsz7-bash-4.4-p23/bin/bash",
    "args": [
      "-e",
      "/nix/store/4vq3350zc6sqnibkqpgic2d6cvi1r9hq-substitute-all.sh"
    ],
    "env": {
      "allowSubstitutes": "",
      "buildInputs": "",
      "builder": "/nix/store/aikkh4qin26v6m645q35205zn7krmsz7-bash-4.4-p23/bin/bash",
      "configVersion": "2.11",
      "configureFlags": "",
      "depsBuildBuild": "",
      "depsBuildBuildPropagated": "",
      "depsBuildTarget": "",
      "depsBuildTargetPropagated": "",
      "depsHostHost": "",
      "depsHostHostPropagated": "",
      "depsTargetTarget": "",
      "depsTargetTargetPropagated": "",
      "doCheck": "",
      "doInstallCheck": "",
      "name": "config-compat.patch",
      "nativeBuildInputs": "",
      "out": "/nix/store/fm0ix13flkhvavccs85x2jvjj80gp78l-config-compat.patch",
      "outputs": "out",
      "patches": "",
      "preferLocalBuild": "1",
      "propagatedBuildInputs": "",
      "propagatedNativeBuildInputs": "",
      "src": "/nix/store/nhfili4xslqbbrm2cw236vm2w3yqq2yc-config-compat.patch",
      "stdenv": "/nix/store/bmn8mag0r2r663fg5lvxr8cllq0bhb06-stdenv-linux",
      "strictDeps": "",
      "system": "i686-linux"
    }
  }
}

$ file /nix/store/aikkh4qin26v6m645q35205zn7krmsz7-bash-4.4-p23/bin/bash
/nix/store/aikkh4qin26v6m645q35205zn7krmsz7-bash-4.4-p23/bin/bash: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), dynamically linked, interpreter /nix/store/jcw4zh252f8ivragssh3809ndy0kvyf0-glibc-2.30/lib/ld-linux.so.2, for GNU/Linux 2.6.32, not stripped

Adding i686-linux to extra-platforms yields a working x86_64 Quartus. Very strange...

cc @kwohlfahrt .

Quartus does have 32-bit dependencies, and afaik these come from nixpkgs.pkgsi686Linux. I think the strange part is that you are unable to build them. Does the below work for you?
> cat /run/current-system/system
x86_64-linux
> nix build -f "<nixpkgs>" pkgsi686Linux.freetype
> file result/lib/libfreetype.so.6.17.1
result/lib/libfreetype.so.6.17.1: ELF 32-bit LSB shared object, Intel 80386, version 1 (SYSV), statically linked, not stripped

You can add --option builders "" --option subsituters "" to make sure the cache is disabled.

I don't think these are avoidable, since ModelSim is a 32-bit executable.

Yep, you're right, this is where the 32-bit dependencies come from. I was able to confirm that I can't build freetype:
[travis@stgmachine:~/sources/nixpkgs]$ git rev-parse HEAD
ed755a6557052d7d74fe8cd7a308302dc56d84b3
[travis@stgmachine:~/sources/nixpkgs]$ cat /run/current-system/system
x86_64-linux
[travis@stgmachine:~/sources/nixpkgs]$ nix-build -E "with import ./default.nix {}; pkgsi686Linux.freetype" --check
error: a 'i686-linux' with features {} is required to build '/nix/store/fxwwkj7k10ljr32k8522vyvhlklfyq8a-freetype-2.10.1.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}

This is without i686-linux in extra-platforms; I can build freetype just fine if I put it back.

Ok, I think I see what's happening. When Nix was complaining about i686-linux missing I had this in my nix.conf:
extra-platforms = aarch64-linux

If I remove extra-platforms entirely, I'm able to build i686 freetype. My guess is that Nix is treating the fact that x86_64-linux entails the ability to build for i686-linux by setting extra-platforms = i686-linux by default on that platform. By defining extra-platforms = aarch64-linux in my nix.conf, I'm overriding that default (rather than adding more platforms), so I can't build freetype.
Closing this, since it seems this is a Nix configuration quirk rather than a problem with the Quartus packages (thanks for adding those by the way!).


Doc

Codecov Report

Merging #607 (bfa9298) into main (47f9114) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #607      +/-   ##
============================================
- Coverage     92.96%   92.89%   -0.08%
+ Complexity     2477     2474       -3
============================================
  Files           254      254
  Lines          5162     5162
  Branches        580      580
============================================
- Hits           4799     4795       -4
- Misses          221      222       +1
- Partials        142      145       +3

Impacted Files
Coverage Δ

.../net/datafaker/providers/videogame/MarvelSnap.java
100.00% <ø> (ø)

...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java
92.59% <0.00%> (-3.71%)
:arrow_down:

...n/java/net/datafaker/providers/base/BaseFaker.java
87.82% <0.00%> (-0.87%)
:arrow_down:

...rc/main/java/net/datafaker/service/FakeValues.java
83.19% <0.00%> (-0.85%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


19/05/2023 - LeaderBoard Issue

Awesome code. your code is linter free and follows all good practice principles. well done champ.
A little issue is the use of innerHTML, this gives your code open to hackers.

I love how your page refreshes on its own when the submit button is clicked. Nice job Foga.

I have seen you have done an excellent work on this. UI is so good and the functionality is impressive.
It is better

if you can add some range to scores

Also rather than refreshing the page when you click on the refresh button you can refresh only dom elements.

Thank you guys for the reviews


navbar above grid

We should do something with long titles on mobile. Perhaps it's ok to hide the progress bar on small devices?

The Mark as completed text is colored white


Add GetTransactionResultByIndex endpoint

Add GetTransactionResultByIndex to the SDK that was implemented for Access API.
Related issue: https://github.com/onflow/flow-go-sdk/issues/751

Duplicate


Update URL to distutils configuration files docs

Summary
The existing URL 404s:
https://docs.python.org/3/install/index.html#distutils-configuration-files
...since the /3/ route now resolves to Python 3.12, where distutils has been removed:
https://docs.python.org/3.12/whatsnew/3.12.html#distutils
The Python 3.11 docs are the most recent where the page still exists:
https://docs.python.org/3.11/install/index.html#distutils-configuration-files
Test Plan
N/A

(I presume even though newer Python doesn't include distutils, the uv-virtualenv crate's distutils-patching behaviour inherited from gourgeist is still needed, since setuptools now bundles distutils?)

Not certain regarding your question, cc @konstin

I presume even though newer Python doesn't include distutils, the uv-virtualenv crate's distutils-patching behaviour inherited from gourgeist is still needed, since setuptools now bundles distutils?

The file is vendored from https://github.com/pypa/virtualenv/blob/main/src/virtualenv/create/via_global_ref/_virtualenv.py, iirc we still need it for setuptools.


(AB-644771) Add security section to multi-region web app

Prior to this change, the "Highly available multi-region web application" document did not include a security sub-section for considerations.
This change introduces a section to highlight security considerations and points the reader at the considerations enumerated in the "Scalable web app" document.

@michaeltlombardi, this PR is in draft form. If you are ready for it to be reviewed and merge, click the "Ready for review" button. Thanks, PR review team

Thanks @jborsecnik! It's not quite ready yet, I have a habit of putting up draft PRs while I work through items. I'll convert from draft when ready for final review.
This is being done as part of training, so I'll hold off until the reviewers identified in the work item requirements have had a chance to go through it to keep from stealing context from the normal reviewers.

Closing as I now understand this should have been opened in another repository instead.


Delay first pull of flight plans for a minute instead of 10 seconds

This means there's a forced minute wait when switching between check durations, e.g. a client connects and switches to every 15 seconds, there's a full minute before the first 15 second refresh happens.


Country select dropdown added

Purpose

The purpose of this PR is to fix #165
Goals

Add a country select dropdown instead of a input field
Screenshots

Checklist

[x] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
[x] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation

@anjula-sack I tested in the Database. country uuid is saving.


Merge into yj-focus-formfield - Don't use keycodes

@yjkimjunior Can we try and use the onSubmit prop on a <form>? I proposed here just one example on AccountName, but I think the same thing could work everywhere. I.e. don't add onSubmit on fields, but on the wrapping form. We could delete all usage of event.keycode too.
To be merged into #323

Hi @amaurymartiny, I agree it is hacky but I resorted to it because the enter key press behavior maps to the back button even while the input is in focus. This happens whenever the back button is present, i.e. when currentStep > 1. In a previous commit this behavior persisted even after explicitly calling blur() on the back button as well. So far what I could come up with has been to use the keycodes or to outright disable the back button...

hmm, I'm still reluctant to merge keycodes in. Have you tried this PR? It works on my machine, on the AccountName page the enter key goes to the next page.
Also, maybe tabindex=-1 on the back button might work?

yup, I tried pulling your change and it works on AccountName which is currentStep === 1 however it has the same problem behavior if I just manually set back button enabled on that page though. Just tried setting tabIndex=-1 on the back button to same behavior. Also tried setting tabIndex=1 to the next button which causes a page reload and doesn't hit the onSubmit handler. 😞

@yjkimjunior can you try again now?


Publish plugin to JetBrains repository

The plugin would be very helpful to us, but I don't see it available from within IntelliJ (Settings > Plugins). Installing it manually by first building the plugin and then adding to IntelliJ is quite tedious when you want to implement it in a team. Is it possible to get it published to JetBrains repository, so that it is easy to install?

Hey, thanks for the suggestion. I just uploaded a version. Jetbrains now wants to approve the upload within two business days :)

It's on! Thanks! 🥇 I gave it a go, but it is not doing what I expected. I expected it will use Detekt for inspection, and so whichever problems Detekt highlights should be also visible within IntelliJ. However, the smells reported by Detekt are not visible in IntelliJ. Is it just not working, or is not meant to do what I expected?

Have you enabled it in the settings?


Only use unix domain socket and named pipes for internal communication

crc and his components should not bind any ports.
It is a major security issue. Some security solutions deny it. Large corporation might be worried by that.
Current usage:

Hyperkit and libvirt drivers bind random ports when crc needs to talk with them
SSH port of the VM is opened although no user feature requires it (podman might in the future).

Hyper-V driver is already better with https://github.com/code-ready/machine/commit/af6c21be51dc2775397e2cad3e85cd17dd2255c1
vsock can help here:

Hyperkit will no longer need to run as root and therefore the driver can be built-in like Hyper-V driver
SSH can be done without exposing a port (by talking to a unix socket)

libvirt can be improved by using https://github.com/digitalocean/go-libvirt

libvirt can be improved by using https://github.com/digitalocean/go-libvirt

How does this relate to unix domain sockets/named pipes? crc uses qemu:///system for its libvirt interaction, which already goes through a unix socket.

Can we break down the platfforms as individual tasks and keep this as an overview task?

How does this relate to unix domain sockets/named pipes? crc uses qemu:///system for its libvirt interaction, which already goes through a unix socket.

Sorry for the lack of explanation: if we use digitalocean go-libvirt, we can statically compile the driver inside CRC and then, remove one more listening port (or we can use a unix domain socket).

Sorry for the lack of explanation: if we use digitalocean go-libvirt, we can statically compile the driver inside CRC and then, remove one more listening port (or we can use a unix domain socket).

The whole reasoning is - external drivers require the use of a listening port as the communication is not going through a unix domain socket. If we remove external drivers, we get rid of this listening port without needing to do the changes for unix domain sockets. However, the libvirt driver links with libvirt.so, so if we stop using an external driver, crc would start linking with libvirt.so. If we want to avoid this, one possible solution is to use digitalocean's libvirt implementation. Other ones are to dlopen the machine driver, or to help moving libvirt go bindings to transparently use dlopen.


Removed redundant default value for arguments.

For action='store_true' is default always False

Coverage remained the same at 92.936% when pulling aee4519168f55ab076143b805b64e2a434c1f712 on mimi1vx:clean into 9bcde91d5c29293454656833c77d7edfa3d9be55 on openSUSE:master.

Coverage remained the same at 92.936% when pulling aee4519168f55ab076143b805b64e2a434c1f712 on mimi1vx:clean into 9bcde91d5c29293454656833c77d7edfa3d9be55 on openSUSE:master.

Coverage remained the same at 92.936% when pulling aee4519168f55ab076143b805b64e2a434c1f712 on mimi1vx:clean into 9bcde91d5c29293454656833c77d7edfa3d9be55 on openSUSE:master.


STORM-2335 Fix broken Topology visualization with empty ':transferred' in executor stats

Also fix another bug: stream table and graph box was created for each 'Show Visualization' click.
Please refer description of STORM-2335 for more details.
This can be ported back to 1.x and 1.0.x branches via cherry-picking.

+1

+1

+1


Can you please help with likely ESC/POS (usually thermal) network printers?

Can you please help with likely ESC/POS (usually thermal) network printers?
I am kind of confused searching to buy any workable printer for test.
Thanks in anticipation.
Cheers

Hi,
I'm using a POS/ESC 80mm WiFi printer from Xprinter. It costs around $40-$50.
I've tested it to print in English and French (with special characters) and it's works well so far.
It seems that for some other languages such as Greek it's maybe not a good choice.
Hope it helps!

It really help but i am here in Nigeria Africa and i must get what i am buying in specific bcoz of cost of return and all that.
I have actually seen many of  POS/ESC 80mm WiFi printer (Xprinter brand) but please, can u share the Model of the Printer in question. Buying online can be very frustrated .
Thanks in anticipations.
Chris

Hi Chris,
Sure, the exact model is Xprinter XP-N160I.
Hope it helps !


Remove the gds-nagios-plugins package

We've moved everything that used to be here out of
alphagov/nagios-plugins and into the plugins directory of this repo.

This is draft because we need #10144 merged and deployed first.

Wait, we probably need to pip uninstall this otherwise it'll linger forever.

Good point. I removed the version constriaint.


KeyboardInterrupt error in waitingspinner

Description
What steps will reproduce the problem?

What is the expected output? What do you see instead?
Please provide any additional information below
File "/Users/Leo/anaconda/lib/python3.6/site-packages/spyder/widgets/waitingspinner.py", line 177, in rotate
def rotate(self):
KeyboardInterrupt
Version and main components

Spyder Version: 3.2.0
Python Version: 3.6.2
Qt Versions: 5.6.2, PyQt5 5.6 on Darwin

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.20.3 (OK)
numpy >=1.7      :  1.13.1 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
rope >=0.9.4     :  0.10.5 (OK)
jedi >=0.9.0     :  0.10.2 (OK)
psutil >=0.3     :  5.2.2 (OK)
nbconvert >=4.0  :  5.2.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.26 (OK)
qtconsole >=4.2.0:  4.3.0 (OK)
IPython >=4.0    :  6.1.0 (OK)
pylint >=0.25    :  1.7.2 (OK)

Thanks for reporting. We'll take a look at this in a future release.

I think this is caused because the waiting spinner is started in the creation of find in files, and never stopped (only the progress bar is hidden/shown) https://github.com/spyder-ide/spyder/blob/3.x/spyder/widgets/findinfiles.py#L784

Thanks for noticing @rlaverde! Should we stop it then after it's hidden?

Yes, start it when progress bar is shown and stop it when progress bar is hidden.
Although if you press Ctrl+C while it's shown and spinning (i.e. searching in files) the error will occur

Although if you press Ctrl+C while it's shown and spinning (i.e. searching in files) the error will occur

We should be able to prevent this

@goanpeca I'm not sure If that will work, the error occur when trying to kill spyder process (pressing Ctrl+C in the terminal that is running spyder).
I don't know if maybe another event raise this error, neither this issue or #5049, have steps to reproduce the error.

ahhh @rlaverde ok I understand. Actually I think that is a spyder bug, we should be able to kill spyder from the console.


Data Analysis and Visualization with AlgebraOfGraphics | Pietro Vertechi | JuliaCon 2022

Link to the talk: https://www.youtube.com/watch?v=XWzkj6ODJYk
AlgebraOfGraphics on Github: https://github.com/JuliaPlots/AlgebraOfGraphics.jl
AlgebraOfGraphics documentation: http://juliaplots.org/AlgebraOfGraphics.jl/stable/
00:16 Structure of the talk
00:56 From data to visualization: representing data graphically
02:47 Philosophy of AlgebraOfGraphics
03:59 Example usage: How does AlgebraOfGraphics work?
07:11 The AlgebraOfGraphics Gallery
08:16  Prototype GUI for AlgebraOfGraphics
08:44 Thank you!

I slightly tweaked your work.
Contents
00:00 Opening
00:16 Structure of the talk
00:56 From data to visualization: representing data graphically
02:47 Philosophy of AlgebraOfGraphics
03:59 Example usage: How does AlgebraOfGraphics work?
07:11 The AlgebraOfGraphics Gallery
08:16 Prototype GUI for AlgebraOfGraphics
08:44 Thank you!
AlgebraOfGraphics repository.
AlgebraOfGraphics documentation.

Thank you. Timestamps were added to the video, we will close this issue, when we get access rights to this GitHub repository.

We now can close the issue.


Add Qdrant score_threshold support.

Add Qdrant score_threshold support.
Edited method: similarity_search, similarity_search_with_score
Added parameter: score_threshold
You can now pass score_threshold parameter to QdrantClient, to filter out results with a low similarity score.
Refer to: https://qdrant.tech/documentation/search/#filtering-results-by-score
Thanks!

@dev2049

@hwchase17 high level changes look good to me, but I don't know which methods can be customized

@eyurtsev I have applied your suggestions from the code review, Please help to approve the pending workflow, Thanks!

@hwchase17 you'll need to take a look here, the code looks good to me. What I don't know is what API uniformity we care about. The redis search with threshold api looks different, do we care about making the apis look similar?

The reason why I added score_threshold in the existing method is that
Qdrant originally supports score_threshold parameter in QdrantClient.client.search(), unlike Redis vector store is filtering out low scores on the langchain side.
https://github.com/hwchase17/langchain/blob/master/langchain/vectorstores/redis.py#LL277C9-L277C9
So I think it just needs to pass the parameter to QdrantClient.client.search(), correct me if I am wrong.
Also please help me to fix the formatting error, I don't know why lint check is failing😢
Thank you.

The reason why I added score_threshold in the existing method is that
Qdrant originally supports score_threshold parameter in QdrantClient.client.search(), unlike Redis vector store is filtering out low scores on the langchain side.
https://github.com/hwchase17/langchain/blob/master/langchain/vectorstores/redis.py#LL277C9-L277C9
So I think it just needs to pass the parameter to QdrantClient.client.search()
Also please help me to fix the formatting error, I don't know why lint check is failing😢
Thank you.

to avoid overloading this function, is it possible to add a method similar to that on Redis, like similarity_search_limit_score that explicitly limits?

I don't quite understand what you mean by overloading, isn't it just passing the parameter, which it dropped before?
I can add a method similarity_search_limit_score to Qdrant and leave similarity_search unchanged if you want it to separate.
But should I do the filtering part on the langchain side?
and set the default score_threshold like in Redis?
because the default score_threshold on QdrantClient.client.search() is None.
Many thanks!

I don't quite understand what you mean by overloading, isn't it just passing the parameter, which it dropped before?
I can add a method similarity_search_limit_score to Qdrant and leave similarity_search unchanged if you want it to separate.
But should I do the filtering part on the langchain side? and set the default score_threshold like in Redis? because the default score_threshold on QdrantClient.client.search() is None.
Many thanks!

Hi @hwchase17
Do you have advice here?
Thanks!

Hi @hwchase17
Please help me with this if you are free.
Thanks.

@baskaryan Can we close that PR? It's already supported in Qdrant.


Add two LED strips on the same channel

Describe the problem
Hello, I am trying to add two 30 LED WS2812B strips onto the same channel (ledsChannel2)
Screenshots

Code changes
The code above complies and is able to be uploaded to my Arduino, pins 9 and 11 work, but no data comes out of pin 10.
If I use the LightingnodPro example and Define data pins as 9 and 10, it works fine.
System (please complete the following information):

OS: Windows 10
Board: Arduino Leonardo (https://wiki.dfrobot.com/Beetle_SKU_DFR0282)
Device: Lighting Node PRO
Version of IDE: Arduino IDE 1.8.20
Version of CLP: 0.15.0
Version of CLP Boards: 0.3.1

Not all pins on the Arduino Leonardo can be used with FastLED, check the documentation of FastLED and your Arduino Leonardo board to verify you use pins which are supported.
Your sketch itself is similar to https://github.com/Legion2/CorsairLightingProtocol/blob/dev/examples/MultipleFans/MultipleFans.ino, which also splits a channel into multiple strips and use these strips for led fans.

Thanks for the reference, was able to separate them into multiple channels.
Also was wondering if it would be possible to reverse the direction on a certain pin.
CLP::reverse will reverse the whole channel (ie ledsChannel1), but I only want a certain data pin to be reversed, (ie DATA_PIN_STRIP_2).
Thanks again!
`#include <CorsairLightingProtocol.h>
#include <FastLED.h>
#define NUMBER_OF_LEDS_PER_STRIP 30
#define DATA_PIN_STRIP_1 9
#define DATA_PIN_STRIP_2 10
#define DATA_PIN_STRIP_3 11
#define NUMBER_OF_LEDS_PER_FAN 4
#define DATA_PIN_FAN_1 A0
#define DATA_PIN_FAN_2 A1
#define DATA_PIN_FAN_3 A2
CRGB ledsChannel1[96];
CRGB ledsChannel2[96];
CorsairLightingFirmwareStorageEEPROM firmwareStorage;
CorsairLightingFirmware firmware(CORSAIR_LIGHTING_NODE_PRO, &firmwareStorage);
FastLEDControllerStorageEEPROM storage;
FastLEDController ledController(&storage);
CorsairLightingProtocolController cLP(&ledController, &firmware);
CorsairLightingProtocolHID cHID(&cLP);
void setup() {
//                          FAN_PIN           CRGB array            offset             number of leds per fan
FastLED.addLeds<WS2812B, DATA_PIN_STRIP_1, GRB>(ledsChannel1, NUMBER_OF_LEDS_PER_STRIP * 0, NUMBER_OF_LEDS_PER_STRIP);
FastLED.addLeds<WS2812B, DATA_PIN_STRIP_2, GRB>(ledsChannel1, NUMBER_OF_LEDS_PER_STRIP * 1, NUMBER_OF_LEDS_PER_STRIP);
FastLED.addLeds<WS2812B, DATA_PIN_STRIP_3, GRB>(ledsChannel1, NUMBER_OF_LEDS_PER_STRIP * 2, 36);
// normal strip on channel 2
FastLED.addLeds<WS2812B, DATA_PIN_FAN_1, GRB>(ledsChannel2, NUMBER_OF_LEDS_PER_FAN * 0, NUMBER_OF_LEDS_PER_FAN);
FastLED.addLeds<WS2812B, DATA_PIN_FAN_2, GRB>(ledsChannel2, NUMBER_OF_LEDS_PER_FAN * 1, NUMBER_OF_LEDS_PER_FAN);
FastLED.addLeds<WS2812B, DATA_PIN_FAN_3, GRB>(ledsChannel1, NUMBER_OF_LEDS_PER_FAN * 2, 88);
//FastLED.addLeds<WS2812B, DATA_PIN_CHANNEL_2, GRB>(ledsChannel2, 4);
ledController.addLEDs(0, ledsChannel1, 96);
ledController.addLEDs(1, ledsChannel2, 96);
}
void loop() {
cHID.update();
if (ledController.updateLEDs()) {
FastLED.show();
}
}`

If the built-in function do not fit your needs, you can write your own LED data manipulation functions, which you can customize to your needs. If you need hints how this works, have a look at the built-in functions and how they work.

Alright thanks, right now just using open RGB to change the position as needed.
Again, thanks for the advice and help!


feat: fix TrieSet.equals, add TrieSet.isEmpty, TrieSet.isSubset; add tests

Fix for #446 (TrieSet.equal)
Add isEmpty
Add isSubset
Optimize TrieSet.size (exploiting Trie.size())
Test existing and new operations on larger example.
(still missing: iter, make/singleton, examples, better doc)

@ggreif I think testing TrieSet was on your plate, but I've mostly done it. Feel free to extend of course ;->


Can't destroy the the terraform environment due to DependencyViolation

I'm trying to destroy the environment via terraform destroy but I'm getting this error message after multiple attempts:
│ Error: deleting EC2 Subnet (subnet-0926a18c09585dd05): DependencyViolation: The subnet 'subnet-0926a18c09585dd05' has dependencies and cannot be deleted.
│ 	status code: 400, request id: 53305f8a-addd-48de-a246-d0ade3cc432c
|
│ Error: deleting EC2 Subnet (subnet-01635dae617c6f131): DependencyViolation: The subnet 'subnet-01635dae617c6f131' has dependencies and cannot be deleted.
│ 	status code: 400, request id: 4f884fc5-f4ee-4503-9e29-7c8e995e6578
|
│ Error: deleting EC2 Subnet (subnet-00353977044e645d5): DependencyViolation: The subnet 'subnet-00353977044e645d5' has dependencies and cannot be deleted.
│ 	status code: 400, request id: 1bc4c253-2f86-4d2b-8b84-ff7a5ee97298
╵```

Trying to delete the network endpoint is also blocked in the attached VPC Endpoint hasn't been removed. Deleting the Endpoint manually unblocks the operation.

This cascading error usually means the ENI was not freed since the associated instance was not terminated successfully during the deletion on the EKS node group. When this happens, it is essential to check what hampers the instance termination.
I will see if I can replicate that on my side.

I can't get any errors by running destroy after apply except for one warning from Terraform:
Warning: EC2 Default Network ACL (acl-03a78b44033555299) not deleted, removing from state
, which was a false positive after I checked it on the AWS console. Between apply and destroy, did you run anything such as helmfile sync and what were they?

Interesting. No I didn't run any commands between apply and destroy as long as I can remember. I have had similar issue when creating and deleting clusters with eksctl in CloudFormation. Maybe it has something to do with our AWS environment but I'm not sure.
Feel free to close this issue if you don't think it can't be reproduced.

Alright. Closing this issue. If it reoccurs, feel free to open another one with logs on instance termination.


[SPARK-8937][TEST] A setting spark.unsafe.exceptionOnMemoryLeak  is missing in ScalaTest config.

spark.unsafe.exceptionOnMemoryLeak is present in the config of surefire.
        <!-- Surefire runs all Java tests -->
        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-surefire-plugin</artifactId>
          <version>2.18.1</version>
          <!-- Note config is repeated in scalatest config -->
...

<spark.unsafe.exceptionOnMemoryLeak>true</spark.unsafe.exceptionOnMemoryLeak>
            </systemProperties>
...

but is absent in the config ScalaTest.

Merged build triggered.

Merged build started.

Test build #36877 has started for   PR 7308 at commit 95644e7.

LGTM pending Jenkins.

LGTM

Test build #36877 has finished for   PR 7308 at commit 95644e7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Merging into master and branch-1.4.


Using .skip or .only inside .each test cases

I would like to skip a few tests inside an each block, or run only one of them. I was looking for some syntax along the following lines :
describe.each`
   year    | month | day
// ${2045} | ${11} | ${22}
// ${2046} | ${8}  | ${11}
   ${2047} | ${1}  | ${1}
// ${2048} | ${2}  | ${29}
`("date is $day / $month / $year", ({ year, month, day }) => {
	// my tests
})

Is there a way to do this somehow ?

I think it's a good idea to allow us specifying certain skip conditions. This is different from commenting them out that skipped test will still be reported and such input is very helpful on tracking todos. So, would be great if jest team would like to implement this!
CC: @SimenB

@aymericbouzy yup it sounds legit, but just feel not so elegant?... Imagine you have many test blocks inside describe.each that should be skipped for some values, you need to add one field for each of them? :joy:

@yxliang01 I know, that's why I'm asking for the proper feature in the first place 😉 I was simply suggesting an alternative for people googling this thread until there is an "elegant" solution.


Could not resolve "@inertiajs/vue3"

I follow all instruction regarding installation but after setup I get this error:
Could not resolve "@inertiajs/vue3"

node_modules/momentum-modal/dist/momentum-modal.js:2:42:
      2 │ import { usePage as E, router as I } from "@inertiajs/vue3";

I am using Laravel 9 and Vite 3.2 and this is my package.json:
{
    "private": true,
    "scripts": {
        "dev": "vite",
        "build": "vite build"
    },
    "devDependencies": {
        "@inertiajs/inertia": "^0.11.0",
        "@inertiajs/inertia-vue3": "^0.6.0",
        "@inertiajs/progress": "^0.2.7",
        "@tailwindcss/forms": "^0.5.3",
        "@vitejs/plugin-vue": "^3.0.0",
        "autoprefixer": "^10.4.12",
        "axios": "^1.2.0",
        "laravel-vite-plugin": "^0.7.0",
        "lodash": "^4.17.19",
        "postcss": "^8.4.18",
        "tailwindcss": "^3.2.1",
        "vite": "^3.0.0",
        "vue": "^3.2.41"
    },
    "dependencies": {
        "@headlessui/vue": "^1.7.5",
        "@heroicons/vue": "^2.0.13",
        "momentum-modal": "^0.2.1"
    }
}

The current version of momentum-modal does not support the latest version of Inertia.js which is v1.0.
We need an update.

The current version of momentum-modal does not support the latest version of Inertia.js which is v1.0.
We need an update.

But it's not Inertia 1.0

The current version does actually expects Inertia 1.0, so yo'll have to use a lower version of this package.


Should we use sized types instead of 'unsigned long' ?

There are a lot of unsigned long parameters, return values, etc., in the header files.  Should we move to sized types? Most of them could just be uint32_t  See #15145.  We are fixing that because we need more bits, but it might be worth
taking a look at the other API's. Most are probably okay with 32bit.  This is similar to the long-wanted int/size_t cleanup, but would only affect 'unsigned long' uses and could be done almost mechanically.

+1 for explicitly sized ints.

I would do that where it matters...  it doesn't always.

I would do that where it matters... it doesn't always.

Sure.  I'd expect to do one PR per header (or maybe related, like all ssl/tls in one)

We want to do this, we're not going to do it for 3.0.


Add support for K8s 1.6

k8s v1.6.x comes with a new Flex API. As a use I should be able to attach volumes when I am using k8s v 1.6.x
The new API is:
 getvolumename
 attach
 detach
 waitforattach
 isattached
 mountdevice
 unmountdevice
 mount
 unmount
The structure of the response expected by Kubelet:
{
"status": "<Success/Failure/Not supported>",
"message": "<Reason for success/failure>",
"device": "Path to the device attached. valid only for attach & waitforattach call-outs”
"volumeName": "Cluster wide unique name of the volume”
"attached": True/False}

@midoblgsm  i think you should move this ticket to waiting for testing. since u finish it


Basic struture for the rocket page created

Basic structure for the rocket page created. One more component added

Hi @baqar-abbas  ,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights
Linter checks ✔
Gitflow ✔
Basic structure as required in design ✔
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


Polybase Dependency mssql-zulu-jre-11 is not installable

When attempting to install mssql-server-polybase-hadoop on Ubuntu using this command, one of the dependencies cannot install:
sudo apt-get install mssql-server-polybase-hadoop
$ sudo apt-get install mssql-server-polybase-hadoop
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
mssql-server-polybase-hadoop : Depends: mssql-zulu-jre-11 but it is not installable
E: Unable to correct problems, you have held broken packages.
I attempted this on a fresh install of Ubuntu 18.04.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0547d262-0e0b-1c3c-66de-b45458fd40b3
Version Independent ID: b0f7235c-9439-7be5-eb18-f343861a0159
Content: Install PolyBase on Linux - SQL Server
Content Source: docs/relational-databases/polybase/polybase-linux-setup.md
Product: sql
Technology: linux
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@kentmaxwell thank you for contacting Microsoft. Please review this content specific to the error you are receiving.https://dba.stackexchange.com/questions/286759/polybase-with-sql-server-2019-on-linux-or-containers

@cawrites Thank you for the response.  I am familiar with this post on Stack Exchange because I made the post.  Ultimately, I also figured out the solution to the problem as well.  Thank you for following up.


Add stack implementation in java

I would like to work on this. Please assign this to me with hacktoberfest-accepted.

okay

I think you closed this, can you assign it to me please?


Auto corrected by following Lint Ruby Style/Proc

Auto corrected by following Lint Ruby Style/Proc
Click here to configure it on awesomecode.io

Coverage remained the same at 97.136% when pulling ba39f6cb3a10a7f3ec48cee6135a919719deefa8 on awesomecode-lint-ruby-style-proc-47701 into 6f35b6f068f62083f4838f749eb9caa708dec50f on master.

Coverage remained the same at 97.136% when pulling ba39f6cb3a10a7f3ec48cee6135a919719deefa8 on awesomecode-lint-ruby-style-proc-47701 into 6f35b6f068f62083f4838f749eb9caa708dec50f on master.


Fix iNotifyWatch timeout

Install Watch before we issue attach so that we don't miss it.
Testing (manual):
Without this change, docker volume create -d vsphere vol1 would consistently timeout with following logs;
2017-03-21 02:49:40.042231308 +0000 UTC [INFO] Attaching volume and creating filesystem name=tv6 fstype=ext4
2017-03-21 02:49:40.042930043 +0000 UTC [DEBUG] vmdkOps.Attach name=tv6
2017-03-21 02:49:50.463992516 +0000 UTC [WARNING] Exceeded timeout while waiting for device attach to completetimeout=10s device="/dev/disk/by-path/pci-0000:0b:00.0-scsi-0:0:2:0"

With this change, it succeeds;
2017-03-21 03:04:38.576935001 +0000 UTC [INFO] Attaching volume and creating filesystem fstype=ext4 name=tv1
2017-03-21 03:04:38.578020905 +0000 UTC [DEBUG] vmdkOps.Attach name=tv1
2017-03-21 03:04:38.940107037 +0000 UTC [DEBUG] event: "/dev/disk/by-path/pci-0000:0b:00.0-scsi-0:0:1:0": 0x100 == IN_CREATE
2017-03-21 03:04:38.940679315 +0000 UTC [INFO] Scan complete device="/dev/disk/by-path/pci-0000:0b:00.0-scsi-0:0:1:0" event="/dev/disk/by-path/pci-0000:0b:00.0-scsi-0:0:1:0": 0x100 == IN_CREATE

@pdhamdhere Do you have an issue for this PR? What is the problem the PR tries to fix?

Fixes #962

Aha ! Another race defeated :-)
Thanks for closing up on this one !


refactor(docker): make docker files easier to use during development.

During development it quite nice to have docker work with locally built code. This allows you to launch all services very quickly, with your changes, and optionally with debugging support.
Changes made to docker files:

Removed all redundant docker-compose files. We now have 1 giant file, and smaller files to use as overrides.
Remove redundant README files that provided little information.
Rename docker/ to match the service name in the docker-compose file for clarity.
Move environment variables to .env files. We only provide dev / the default environment for quickstart.
Add debug docker files to build minimal images with the idea that built files will be mounted instead.
Add a docker/dev.sh script + compose file to easily use the dev override images (separate tag; images never published; uses debug docker files; mounts binaries to image).
Added docs/docker documentation for this.

Testing:

Confirmed that running docker/quickstart.sh will just download images from the repo, assuming you don't have them.
Confirmed that docker-compose up --build will build all images from scratch, which takes a long time.
Confirmed that docker/dev.sh will build images with the :debug tag, so that they cannot be pulled. These can also be launched even if you have the :latest image, however it may require that you remove the container (even if stopped) with docker container prune.

TODO to get the dev stack working with frontend.
https://github.com/linkedin/datahub/issues/1760
Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable)

Confirmed that docker-compose up --build will build all images from scratch, which takes a long time.

I don't see a reason to support building quickstart images locally. It only causes more confusions when you have locally built :latest images.

Confirmed that docker-compose up --build will build all images from scratch, which takes a long time.

I don't see a reason to support building quickstart images locally. It only causes more confusions when you have locally built :latest images.

Actually I take that back. You do need the ability to rebuilt the latest images when debugging/developing the docker-compose files.

Confirmed that docker-compose up --build will build all images from scratch, which takes a long time.

I don't see a reason to support building quickstart images locally. It only causes more confusions when you have locally built :latest images.

Actually I take that back. You do need the ability to rebuilt the latest images when debugging/developing the docker-compose files.

Maybe we just ask people to manually rebuild in that case? I agree with your original comment :p

Confirmed that docker-compose up --build will build all images from scratch, which takes a long time.

I don't see a reason to support building quickstart images locally. It only causes more confusions when you have locally built :latest images.

Actually I take that back. You do need the ability to rebuilt the latest images when debugging/developing the docker-compose files.

Maybe we just ask people to manually rebuild in that case? I agree with your original comment :p

Without a nice docker-compose file, rebuilding using docker directly will be a PITA.

Tested by cleaning all docker stuff locally.
docker image prune
docker container prune
docker image list | grep datahub | awk '{print $3}' | xargs docker rmi -f
docker volume list | awk '{print $2}' | xargs docker volume rm

Then I ran quickstart.sh and verified it worked (so the currently published images, with these new environment files). Then I ran dev.sh and verified it also worked. Finally, I ran
COMPOSE_DOCKER_CLI_BUILD=1 DOCKER_BUILDKIT=1 DATAHUB_VERSION=locallatest docker-compose -p datahub up

to build our published images (with a distinct tag), and verified those images worked correctly.
Testing each app was done by just logging into DataHub's frontend.
Side note seems like our ingestion script is broken (specifically building the MCE avro files doesn't seem to do anything? or at least :metadata-models-ext:build doesn't do anything; I have to run the specific tasks... I'll make another issue).

Oh that may have been me; I guess :metadata-events:build does nothing, which makes some sense. since it isn't a module?

Also verified I can ingest data and the browse/search for it.

Please fix the broken GH Actions for building docker images: https://github.com/linkedin/datahub/actions


updated engine tag

Updated the package.json file to include NodeJS v12

What's the rationale?

What's the rationale? Why do we need to require Node v12+?

It would be helpful to have a minimum target version either in the docs or stated in package.json.
In my case, I use a Node version manager. So knowing what the project works well on is a plus.

@nathanfletcher: Thanks for the explanation, much appreciated.
I would like to ask you to make similar changes to the other repos, as you review and interact with them 🙏


TN-1163 updated test_assessment_engine.py for py3 compatability

Hello @John0Randolph! Thanks for updating the PR.

In the file tests/test_date_tools.py, following are the PEP8 issues :

Line 29:1: W293 blank line contains whitespace

Oh yeah, don't forget to add test_assessment_engine.py to tox.ini!
Just a heads up, I might switch the way we call py.test in tox.ini so the files that are tested are conditionally skipped, instead of explicitly included


feat: event to set a mission in progress

Changes

event to set a mission in progress

docs

event to set a mission in progress. docs in the file

https://legendaryum.atlassian.net/jira/software/projects/LE/boards/1?assignee=712020%3A71750ee7-8648-475c-99c7-c39c60a8e3fc&selectedIssue=LE-2136

@jym272 ready


Unable to compile Tink for CPP with Bazel

Trying to build Tink fpr CPP using Bazel : https://github.com/google/tink/blob/master/docs/CPP-HOWTO.md
Cloned the master branch, installed Bazel. Getting error message when running "bazel build -c opt cc:libtink.so":
ERROR: Failed to load Starlark extension '@tink_py_deps//:requirements.bzl'.
Cycle in the workspace file detected. This indicates that a repository is used prior to being defined.
The following chain of repository dependencies lead to the missing definition.

@tink_py_deps
This could either mean you have to add the '@tink_py_deps' repository with a statement like http_archive in your WORKSPACE file (note that transitive dependencies are not added automatically), or move an existing definition earlier in your WORKSPACE file.
ERROR: cycles detected during target parsing
INFO: Elapsed time: 0.126s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

Running on Windows 10 1909 x64.

We recently moved to individual WORKSPACEs for each language, but unfortunately that part of the documentation was not updated yet. You should be able to run "bazel build -c opt :libtink.so" inside the /cc directory, in order for the correct WORKSPACE to be used.

Thank you for yout quick reply :)
Unfortunately I got a new error now:
ERROR: C:/users/ar/source/repos/tink/cc/BUILD.bazel:678:1: Configurable attribute "linkopts" doesn't match this configuration (would a default condition help?).
Conditions checked:
//:linux_x86_64
//:mac_x86_64
Apparently Windows 10 is not supported?
Full error trace:
trace.txt

Yes sorry -- Windows 10 is not supported. Also, libtink.so will not be supported anymore -- I already modified this internally. Sorry about that.

:'(
Thanks for quick replies guys. The documentation was a bit ambiguous at that point; I was hoping that the 'linux and mac only' was only related to what was offered as percompiled files.


Include size and page query params on transactions endpoint

This PR includes :sizeand :pagequery params into all resources list services which can use them.
It will allow us to iterate over resources list pages and ask max resources per request.

Should we extend the corresponding spec?

Should we extend the corresponding spec?

@raulvillares you can check it here
Thanks