Fixed issue in TextureAtlas import of images with wrong size.

The fix seems to work fine, and I could reproduce the issue before applying it.

For the reference, last commit on this code was #39271 (@RandomShaper).

I checked and #39271 did not cause this issue though, it's already present in 3.2.1-stable.

I'm not sure this fix is totally correct. I think that if the <s are changed to <=s, the the - 1s applied to width and height - p_offset.y should be removed, since otherwise the cases where the right and/or bottom edges of the atlas are reached the last 1-pixel row or column would be left transparent.
However, I haven't tested it. and I'm not sure I'll have time reasonably soon. If one of you was able to test it, that'd help.

However, I haven't tested it. and I'm not sure I'll have time reasonably soon. If one of you was able to test it, that'd help.

It does solve the problem in #42057, but it would likely be worth testing on more configurations to see how it behaves.
This code is not the easiest to parse and indeed, it seems a good spot for having off-by-one errors here and there which might counterbalance each other.

@akien-mga can this PR be merged in 3.x branch? compiled it with 3.3.3-stable and it does solve #42057 issue.

Thanks!

Cherry-picked for 3.4.


Feature freeze for 0.1.0 release?

This isn't so much an issue as a question for @jeromekelleher:
Will there be a feature freeze before the 0.1.0 release (all PR merges between the freeze and the release would be for bug fixes only)? If so, when? And will there be an associated tag? Thanks!

Yes, good idea @macieksmuga. Let's call that freeze today (excluding documentation updates). I think we should try and tag 0.1.0a3 today so that we can test out installation and the docs. We should then tag 0.1.0b1 tomorrow, unless we hit any show stoppers.

Question answered, closing...

May I suggest create a release branch and not just tagging.
This is often SOP and makes it much easier to do parallel
development with a release and fix bungs in the release.
this is really exciting
Mark
Jerome Kelleher<EMAIL_ADDRESS>writes:

Yes, good idea @macieksmuga. Let's call that freeze today (excluding
documentation updates). I think we should try and tag 0.1.0a3 today so that we
can test out installation and the docs. We should then tag 0.1.0b1 tomorrow,
unless we hit any show stoppers.
—
Reply to this email directly or view it on GitHub.*

This is a good idea @diekhans -- I'm opening an issue to discuss future releases and development.


How to Write  one custom  CatalogAuthorizer

from the source code, I see current only support some build-in CatalogAuthorizer. how can I write one  custom CatalogAuthorizer （we can't directly access cloud IAM providers）

@harshach can we close this issue?

yes


Finally remove flatten()

Hi @ggalmazor,
a recent Twitter discussion with discussions with Brian Goetz has taught me better - we need to stay strict (see also this Gist).
Casting to anything will eventually lead to unpredictable behavior. This is not what we expect from robust Java programs.
I hope you don't mind if I finally remove flatten(). The workaround is flatMap(Function.identity()).
- Daniel

Note to myself: catch(ClassCastException) is a smell

I declare myself unable (yet) to fully understand that twitter conversation :P (It's clear that I have a long path ahead of me yet to be walked)...
I understand your position in this matter... I'll handle my unchecked's in my code :D

Thx!


Add support for dividends

Extension examples to the Black-Scholes formula under the assumption of continuous dividend yields
Note that adding support for dividends also should include implementation of the 1st order Greek Epsilon.

TODO:

Dividend yield formula for charm and veta, phi and color
Docs for all these (LaTeX formulas)

Done!


Building and publishing Windows images

Currently Ko is not able to build images for Windows (see https://github.com/google/ko/issues/361) and adding support for this is potentially a complicated problem to solve. In the interest of progressing development on Windows support for Tekton, I think it would be beneficial to investigate alternatives for building and publishing Windows images until this functionality is supported by Ko.
A possible workaround would be to build images using Docker. I have an example of a Dockerfile for the entrypoint binary which I have been using for testing here: https://github.com/TensorWorks/pipeline/blob/7286fc699d4585ecbf87eedc9e00688f7b0daf5c/images/windows/entrypoint/Dockerfile
Some pros:

This does not impact the current workflow for Linux development
Dockerfiles are easy to read and understand

Some cons:

Building Windows images will depend on Docker and a Windows host machine
There would be some additional upkeep required to maintain Windows images

I'm keen to get some feedback on this approach and also encourage others to share ideas if you think there might be a better alternative.
Related TEP: https://github.com/tektoncd/community/pull/383
Related Issue: https://github.com/tektoncd/pipeline/issues/1826

/kind misc

/close


WIP permissions: Adds permissions for CRUD operation

Closes #201, closes #219

Included in #239


support docusaurus 3.5.2

Change Summary
Support for Docusaurus 3.5.2
PR Checklist

[X] I have read and signed the Contributor License Agreement.

@jasonbosco any update on this PR? Sorry to ping you after a week, but I need this to upgrade Docusaurus :)

@fharper I just published this in 0.21.0-0. Could you give it a shot and let me know how it goes?

@jasonbosco not sure why this commit was missing part of the file (changed on my laptop, just not committed...), but you need to do another release with https://github.com/typesense/docusaurus-theme-search-typesense/pull/52 sorry

I included that commit in 0.22.0-1. I see it on npm in package.json: https://www.npmjs.com/package/docusaurus-theme-search-typesense/v/0.22.0-1?activeTab=code


error when destructuring props: Cannot read properties of undefined (reading '__bookshop_path')

I'm getting the following error in my astro project:
 error   Cannot read properties of undefined (reading '__bookshop_path')
This gives the error:
---
const test: any = undefined
---

Like this it works fine:
---
const test: any = undefined
---

And like this it works fine too:
---
const test: any = { test: 'test' }
---

The weird thing is that it only give the bookshop error, no astro error.
The Hero (parent component) is a bookshop component and rendered via the example in the Astro bookshop docs.
The child Section can be either a bookshop component or not, same error

Temporary fix:
const {
  section = {},
  segment = {},
  writeup,
  group = {},
  buttons,
  image,
} = Astro.props

Doest fix the main problem, the error handling, though

Hey Sil 👋
I'll have a dig into this tomorrow (with our peeps who know more about Astro's internals) and get you an answer 🙂

Hey Sil — a release has landed today which hopefully resolves things for you!
https://github.com/CloudCannon/bookshop/releases/tag/v3.8.2
Give that a crack and let me know if not 🙂

@bglw thats fast, great!
I don't see 3.8.2 published to NPM yet though, correct?

My bad! CI woes.
Published now :)

Problem seems to have disappeared 👍
Will let you know if something like this pops up again


Add task executor and priority features

Description
This PR adds the ability to specify a task executor preference and task priority. Note that the former is only available with Swift 6.
Additionally, a QueueExecutor implementation of TaskExecutor has been added that allows for Tasks to be executed with GCD while still retaining the benefits of using Swift concurrency (e.g. TaskLocal values).
Details
The run and execute APIs on AsynchronousUnitOfWork have additional parameters added to forward a taskExecutor and priority. Calling without any arguments is still supported. By providing these parameters, the work is executed with the specified parameters.
The addition of a QueueExecutor additionally allows for consumers to schedule work with GCD if necessary, while still using Swift concurrency as the main mechanism for execution.
This bit from the "Task Executor Preference" evolution doc I think helps explain the role of TaskExecutor types:

As an intuitive way to think about TaskExecutor and SerialExecutor, one can think of the prior as being a "source of threads" to execute work on, and the latter being something that "provides serial isolation" and is a crucial part of Swift actors. The two share similarities, however the task executor has a more varied application space.
Link

If it seems ill-advised to add a GCD-based type here, I'm open to leaving off the QueueExecutor type from this PR. However, I thought it was a useful exercise to demonstrate that we can have GCD-based scheduling used while still primarily relying on Swift concurrency. In particular, even though the executor is GCD-based, it is still forwarded when structured concurrency is used. Also note that we still have access to TaskLocal values as well.
E.g.
func doSomethingAsync() async {
  // this will be run on the background dispatch queue
}
Task(executorPreference: .globalQueue(qos: .background)) {
  async let work = doSomethingAsync()
  await work
}

This looks amazing! I'm going to need time to really dive into this one as well as check whether the sequence versions of things need an update.
Can you take a look at the Swift6 nightly toolchain build? Seems there's something breaking with this MR there.
I think I love the QueueExecutor. Seems like something people would really want to reach for

It looks like DispatchQoS.QoSClass doesn't conform to Sendable for Linux. Going to try adding @unchecked Sendable to see if that's enough to make it happy.

Looks like that did the trick!


How to build custom device payload?

How to build custom device payload?

The payload is constructed here in the source: https://github.com/helium/virtual-lorawan-device/blob/master/src/virtual_device/mod.rs#L237
There is currently no feature to allow the user to arbitrarily do that.


Many buttons break the server

The server shuts down without an error message if there are a lot of buttons in the form. Tell me, what are the actual limitations, and can you fix this error or somehow inform the developers about it?
command.register('testb', 'Buttons test').overload((param, origin, output)=>{
    const networkIdentifier = IdByName(origin.getName());
    const xuid = XuidById(networkIdentifier);
    let form = new SimpleForm("Test");
    for (let i = 0; i < 500; i++) {
        form.addButton(new FormButton(`${i}`));
    }
    form.sendTo(networkIdentifier, (data, networkIdentifier) => {});
}, {  });

Thanks for reporting it.
It seems it's an issue of bdsx.
and the limitation is 4095 JSON characters.
I fixed it on the latest commit.


Maybe support single markdown file

I am using reveal.js these days, I found it's hard to setup all configurations for reveal.js. So I decide to write a client tool. This tool is installed in the project, and within the package.json, if I just need to setup like:
{
  //..
  "scripts": {
    "ppt": "reveal --markdown ./ppt/presentation.md"
  }
}

And I find your project, which is pretty cool.
But I'd like to have the tool not generation any files within my project. If it could just read my markdown file, it would be every nice. So we are doing it in different approaches, maybe I'll start own project.

Yes, I understand what you mean. reveal.js supports markdown natively, so it's possible to render slides from markdown files directly, but the markdown file should be well formatted.
IMO, it's not a good idea, for these may sacrifice the flexibility of reveal.js.

简单的写了一个：https://github.com/vivaxy/node-reveal


Improve the errors generated by #[derive(AsChangeset)] when possible

This removes all uses of panic! or println! from derives2, and
instead using the nightly-only Diagnostic API when the nightly feature
is enabled. This does require a change in our structure, as anywhere
that we were relying on panic! halting, we either need to return some
"default" value, or use Result to halt instead.
Whether we actually want to halt or not for each case is actually not a
simple question. Ideally we only halt if continuing with a dummy would
result in nonsense errors. I've added UI tests for every single place
that previously panicked, and I'm reasonably happy with the error output
of every single one.

/cc @dtolnay you may find this one interesting too


Client code to handle serverRoot

Hi,
I try running pivot at /serverRoot but it is not dealt with properly.
In Server code:
https://github.com/implydata/pivot/blob/master/src/server/views.ts#L58
/serverRoot/pivot.js should be returned instead.
For the client side, the generated pivot.js and pivot-main.js does not handle serverRoot at the moment.
Thanks for looking into it.

For the background, we use pivot behind a nginx server. Nginx only forwards requests to pivot at the configured location /serverRoot. Therefore, the pivot js script need to append this path prefix to api path, or use relative url if possible.

Thank you, will fix later today.

Should be fixed in 0.8.35


Make sure the tree is published before the project has finished loading

Turn off asynchronous tree loading to bring the behavior of the project system in line with the legacy project system. This lets extensions query for project items after the project load event has fired and get correct results.
Make note, that the tree was being published anyway during load in variety of places anyway:

File -> New always published the tree due to wizards expecting the project to be done by the time they were called
The LanguageServiceHost would already publish not too much after the Project factory had "completed", so depending on the when the component looked, sometimes you'll get correct results, and sometimes you wouldn't. This is going to be removed as a part of https://github.com/dotnet/roslyn-project-system/issues/1655. This change makes it always consistent.

tag @dotnet/project-system @lifengl

What is the Perf implication here? Does CPS provide a lazy way to publish when someone queries for project items?

There are perf implications in that Load fires later than previously - but time to edit shouldn't have changed.
Yes CPS provides a lazy way to publish if they use CPS APIs, but not if you are going via DTE APIs - these extensions (an example is TestDriven.NET) expect to be able to consume the project immediately Open has fired.

Overall load time does increase.  When asynchronous load is enabled, it is quite often one project tree is initialized in the background when the next project is loaded in the front.  However that comes with a price that traditional client could be broken.
Sent from my phone
On Mar 23, 2017, at 4:07 PM, David Kean <notifications<EMAIL_ADDRESS>wrote:
There are perf implications in that Load fires later than previously - but time to edit shouldn't have changed.
Yes CPS provides a lazy way to publish if they use CPS APIs, but not if you are going via DTE APIs - these extensions (an example is TestDriven.NEThttp://TestDriven.NET) expect to be able to consume the project immediately Open has fired.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/dotnet/roslyn-project-system/pull/1832#issuecomment-288887331, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALGWwkojFN380Ec2q70GrbfGbhl61hR6ks5rovsagaJpZM4MmGNv.


Fix UMASK hardening

Updated regex replacements in bashrc umask hardening. Hard-coded replacement with UMASK results in runtime failure because UMASK (all caps) does not exist. Also, whitespace was not being preserved.

Hi @alewando
Thank you again for continuing to work through this, as we mentioned feedback is so important to pick up all the little pieces.
To explain the regexp in this searching with case insensitive and matches both upper and lower.
This would then set it with upper and one space as per the current way CIS request that it is carried out.
However the space could be an issue and changing the regexp to pick up different space layouts is a definite improvement.
So i would add a double change to this
e.g.
regexp: '^(?i)(\s+UMASK|UMASK)\s+0[0-2][0-6]'
and your change for replace to pick up the first group.
Hopefully that makes sense?
I am happy to add if you like or just amend your PR unless you see any issues with it?
Best regards as always
uk-bolly

I'm not sure I understand what you are saying about the upper case. Without this change, it produces the following in /etc/bashrc:
    if [ $UID -gt 199 ] && [ "`/usr/bin/id -gn`" = "`/usr/bin/id -un`" ]; then
UMASK 27
    else
UMASK 27
    fi

This is not valid. There is no uppercase UMASK command. If bashrc is left like this, when you have a interactive non-login shell, you get this:
# bash -ic "whoami"
bash: UMASK: command not found
root

As far as I can tell, this PR follows the guidance for /etc/bashrc and /etc/profile:
https://static.open-scap.org/ssg-guides/ssg-rhel9-guide-cis.html#xccdf_org.ssgproject.content_rule_accounts_umask_etc_bashrc
And it is what was done in your RHEL 8 playbook:
https://github.com/ansible-lockdown/RHEL8-CIS/blob/43a1938113fab5110d469d2f20df17af394020e5/tasks/section_5/cis_5.6.x.yml#L94
I think uppercase UMASK and no whitespace is necessary for /etc/login.defs, however, which is specified in the next rule.
But I don't see anything in this RHEL9 playbook for that rule. Maybe there was a mixup?
https://static.open-scap.org/ssg-guides/ssg-rhel9-guide-cis.html#xccdf_org.ssgproject.content_rule_accounts_umask_etc_login_defs

hi @alewando
Thank you once again for your very quick turnaround. We really appreciate the documents they do help a lot, I now have the context i missed and was myself confused with login.defs vs these files.
PR approval shortly
Best regards and thanks again
uk-bolly


Windows & wxWidgets platform

Hi there,
I've ported tangram-es to Windows during this weekend and I'd like to contribute changes, but I'm not quite certain how I should do this.
Although I've tried to keep it clean as possible, some changes may be breaking for other platforms. Unfortunately I don't have environment to test other platforms, so I guess direct merge to master would be inappropriate 'cuz I won't be able to fix everything by myself.
My windows branch is here: https://github.com/tehKaiN/tangram-es/tree/platform-windows
Also, I'd like to create tangram-es wxWidgets widget. After it's done, should I contribute it later to this repo as additional platform or keep it on separate repo?

Hey this looks great! 👏
Let's start with the Windows platform, I'll have more questions about wxWidgets I think.
I just created a branch in this repo called windows-platform: https://github.com/tangrams/tangram-es/tree/windows-platform. You should be able to make a pull request from the branch in your fork onto our branch. Then we can test it out and quickly adjust anything that might break other platforms :)
Question about your build configuration: It looks like you have CMake searching for libCurl using findpackage. As far as I know Curl is not typically installed on Windows, did you have to install Curl in a particular way for CMake to be able to find it?

Ok, here it is. As of curl, I've added it's path to CMAKE_PREFIX_PATH as findpackage uses it to find packages. :)

So I did some work on wxWidgets support. https://github.com/tehKaiN/tangram-es/tree/platform-wxwidgets
Perhaps it would be wise to just have DLL platform for use with any other framework/lib/whatever, but still linux/rpi platforms are more like app stubs to begin development with.
wxtangram.cpp/.h implements wxTangram widget which inherits from wxGLCanvas widget. Main file containing app startup and widget usage is yet to be commited. This is still far from complete 'cuz many basic event handlers analogous to glfwApp are missing. Honestly, IDK if they should be included or externally implemented by devs, but I guess it's not really gonna be immutable and read-only map control implementation, but just app stub.

So right now I'm trying to compile it using Windows ABI since I have to link my project with msvc-compiled DLLs. MSVC is too poor for compiling tangram-es, since it doesn't support many cpp features. Tested under build tools 2015 and 2017 (aka 14.0 and 14.1).
My current approach is under llvm/clang 5.0. I can't really force CMake to use clang on windows, since it tries to talk to it the same way as msvc's cl compiler when defined in CMAKE_C_COMPILER and CXX too. There is clang-cl which accepts same args as cl but I get lots of errors, especially in variant.hpp and geojscon-vt-cpp regarding access to private constructors. I guess clang fails to RVO them.
Also, css-color-parser dependency needed updating since latest commit fixes msvc builds with one missing #include.
I'm stuck at 76%. Right now stuff which is blocking me:
In file included from D:\prg\_git\tangram-es\core\src\data\clientGeoJsonSource.cpp:15:
D:\prg\_git\tangram-es\core\deps\geojson-vt-cpp\geojson.hpp\include\mapbox/geojson_impl.hpp(297,20):  error: no matching
      member function for call to 'PushBack'
            result.PushBack(operator()(vector[i]), allocator);
            ~~~~~~~^~~~~~~~
D:\prg\_git\tangram-es\core\deps\variant/include/mapbox/variant.hpp(339,16):  note: in instantiation of function
      template specialization
      'mapbox::geojson::to_coordinates_or_geometries::operator()<mapbox::geometry::geometry<double> >' requested here
        return f(unwrapper<T>::apply_const(v.template get_unchecked<T>()));
               ^
D:\prg\_git\tangram-es\core\deps\variant/include/mapbox/variant.hpp(317,51):  note: in instantiation of member function
      'mapbox::util::detail::dispatcher<mapbox::geojson::to_coordinates_or_geometries,
      mapbox::geometry::geometry<double>, rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator>,
      mapbox::geometry::geometry_collection<double, std::vector> >::apply_const' requested here
            return dispatcher<F, V, R, Types...>::apply_const(v, std::forward<F>(f));
                                                  ^
D:\prg\_git\tangram-es\core\deps\variant/include/mapbox/variant.hpp(317,51):  note: in instantiation of member function
      'mapbox::util::detail::dispatcher<mapbox::geojson::to_coordinates_or_geometries,
      mapbox::geometry::geometry<double>, rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator>,
      mapbox::geometry::multi_polygon<double, std::vector>, mapbox::geometry::geometry_collection<double, std::vector>
      >::apply_const' requested here
D:\prg\_git\tangram-es\core\deps\variant/include/mapbox/variant.hpp(317,51):  note: in instantiation of member function
      'mapbox::util::detail::dispatcher<mapbox::geojson::to_coordinates_or_geometries,
      mapbox::geometry::geometry<double>, rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator>,
      mapbox::geometry::multi_line_string<double, std::vector>, mapbox::geometry::multi_polygon<double, std::vector>,
      mapbox::geometry::geometry_collection<double, std::vector> >::apply_const' requested here
D:\prg\_git\tangram-es\core\deps\variant/include/mapbox/variant.hpp(317,51):  note: in instantiation of member function
      'mapbox::util::detail::dispatcher<mapbox::geojson::to_coordinates_or_geometries,
      mapbox::geometry::geometry<double>, rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator>,
      mapbox::geometry::multi_point<double, std::vector>, mapbox::geometry::multi_line_string<double, std::vector>,
      mapbox::geometry::multi_polygon<double, std::vector>, mapbox::geometry::geometry_collection<double, std::vector>
      >::apply_const' requested here
D:\prg\_git\tangram-es\core\deps\variant/include/mapbox/variant.hpp(317,51):  note: in instantiation of member function
      'mapbox::util::detail::dispatcher<mapbox::geojson::to_coordinates_or_geometries,
      mapbox::geometry::geometry<double>, rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator>,
      mapbox::geometry::polygon<double, std::vector>, mapbox::geometry::multi_point<double, std::vector>,
      mapbox::geometry::multi_line_string<double, std::vector>, mapbox::geometry::multi_polygon<double, std::vector>,
      mapbox::geometry::geometry_collection<double, std::vector> >::apply_const' requested here
D:\prg\_git\tangram-es\core\deps\variant/include/mapbox/variant.hpp(317,51):  note: in instantiation of member function
      'mapbox::util::detail::dispatcher<mapbox::geojson::to_coordinates_or_geometries,
      mapbox::geometry::geometry<double>, rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator>,
      mapbox::geometry::line_string<double, std::vector>, mapbox::geometry::polygon<double, std::vector>,
      mapbox::geometry::multi_point<double, std::vector>, mapbox::geometry::multi_line_string<double, std::vector>,
      mapbox::geometry::multi_polygon<double, std::vector>, mapbox::geometry::geometry_collection<double, std::vector>
      >::apply_const' requested here
D:\prg\_git\tangram-es\core\deps\variant/include/mapbox/variant.hpp(869,55):  note: in instantiation of member function
      'mapbox::util::detail::dispatcher<mapbox::geojson::to_coordinates_or_geometries,
      mapbox::geometry::geometry<double>, rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator>,
      mapbox::geometry::point<double>, mapbox::geometry::line_string<double, std::vector>,
      mapbox::geometry::polygon<double, std::vector>, mapbox::geometry::multi_point<double, std::vector>,
      mapbox::geometry::multi_line_string<double, std::vector>, mapbox::geometry::multi_polygon<double, std::vector>,
      mapbox::geometry::geometry_collection<double, std::vector> >::apply_const' requested here
        return detail::dispatcher<F, V, R, Types...>::apply_const(v, std::forward<F>(f));
                                                      ^
D:\prg\_git\tangram-es\core\deps\geojson-vt-cpp\geojson.hpp\include\mapbox/geojson_impl.hpp(390,19):  note: in
      instantiation of function template specialization 'mapbox::util::variant<mapbox::geometry::point<double>,
      mapbox::geometry::line_string<double, std::vector>, mapbox::geometry::polygon<double, std::vector>,
      mapbox::geometry::multi_point<double, std::vector>, mapbox::geometry::multi_line_string<double, std::vector>,
      mapbox::geometry::multi_polygon<double, std::vector>, mapbox::geometry::geometry_collection<double, std::vector>
      >::visit<mapbox::geojson::to_coordinates_or_geometries, mapbox::geometry::geometry<double>,
      rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator> >' requested here
        geometry::visit(element, to_coordinates_or_geometries { allocator }),
                  ^
D:\prg\_git\tangram-es\core\deps\rapidjson/document.h(1563,19):  note: candidate function not viable: no known
      conversion from 'mapbox::geojson::rapidjson_value' (aka 'GenericValue<UTF8<>, rapidjson::CrtAllocator>') to
      'rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator>::StringRefType'
      (aka 'GenericStringRef<char>') for 1st argument
    GenericValue& PushBack(StringRefType value, Allocator& allocator) {
                  ^
D:\prg\_git\tangram-es\core\deps\rapidjson/document.h(1586,5):  note: candidate template ignored: substitution failure
      [with T = rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator>]: no type named 'Type' in
      'rapidjson::internal::DisableIf<rapidjson::internal::OrExpr<rapidjson::internal::IsPointer<rapidjson::GenericValue<rapidjson::UTF8<char>,
      rapidjson::CrtAllocator> >, rapidjson::internal::IsGenericValue<rapidjson::GenericValue<rapidjson::UTF8<char>,
      rapidjson::CrtAllocator> > >, rapidjson::GenericValue<rapidjson::UTF8<char>, rapidjson::CrtAllocator> &>'
    PushBack(T value, Allocator& allocator) {
    ^

Any ideas & help would be appreciated ;)

So I've traced some problem with clang (not msvc compatible clang-cl), which doesn't occur with g++:
clang -c \path\to\tangram-es\core\src\data\clientGeoJsonSource.cpp <INCLUDES> -std=c++17 # not working
g++ -c \path\to\tangram-es\core\src\data\clientGeoJsonSource.cpp <INCLUDES> -std=c++17 # working

Includes as follows:
-I\path\to\tangram-es\platforms\common\glfw\include
-I\path\to\tangram-es\platforms\common
-I\path\to\curl-7.55.1\builds\libcurl-vc-x86-release-static-ipv6-sspi-winssl\include
-I\path\to\tangram-es\core\src
-I\path\to\tangram-es\core\include\tangram
-I\path\to\tangram-es\core\generated
-I\path\to\tangram-es\core\deps
-I\path\to\tangram-es\core\deps\glm
-I\path\to\tangram-es\core\deps\earcut\include
-I\path\to\tangram-es\core\deps\isect2d\include
-I\path\to\tangram-es\core\deps\hash-library
-I\path\to\tangram-es\core\deps\mapbox
-I\path\to\tangram-es\core\deps\pbf
-I\path\to\tangram-es\core\deps\rapidjson
-I\path\to\tangram-es\core\deps\sdf
-I\path\to\tangram-es\core\deps\SQLiteCpp
-I\path\to\tangram-es\core\deps\stb
-I\path\to\tangram-es\core\deps\miniz
-I\path\to\tangram-es\core\deps\geojson-vt-cpp\geometry.hpp\include
-I\path\to\tangram-es\core\deps\geojson-vt-cpp\geojson.hpp\include
-I\path\to\tangram-es\core\deps\geojson-vt-cpp\include
-I\path\to\tangram-es\core\deps\double-conversion\include
-I\path\to\zlib\zlib-1.2.11
-I\path\to\tangram-es\core\deps\duktape
-I\path\to\tangram-es\core\deps\css-color-parser-cpp
-I\path\to\tangram-es\core\deps\yaml-cpp\include
-I\path\to\tangram-es\core\deps\alfons\src
-I\path\to\tangram-es\core\deps\alfons\src\logger
-I\path\to\tangram-es\core\deps\alfons\src\linebreak
-I\path\to\tangram-es\core\deps\harfbuzz-icu-freetype\harfbuzz-generated
-I\path\to\tangram-es\core\deps\harfbuzz-icu-freetype\harfbuzz\src
-I\path\to\tangram-es\core\deps\harfbuzz-icu-freetype\freetype\include
-I\path\to\tangram-es\core\deps\harfbuzz-icu-freetype\harfbuzz\src\hb-ucdn
-I\path\to\tangram-es\core\deps\harfbuzz-icu-freetype\icu\common
-I\path\to\tangram-es\core\deps\harfbuzz-icu-freetype\icu\stubdata
-I\path\to\tangram-es\core\deps\harfbuzz-icu-freetype\icu\common\unicode
-I\path\to\tangram-es\core\deps\SQLiteCpp\include
-I\path\to\tangram-es\core\deps\SQLiteCpp\sqlite3

Interesting, this error doesn't look familiar to me. It looks like you're compiling with -std=c++17, have you tried -std=c++14? I don't think our code requires any c++17 features.
What was the problem with MSVC? If possible I'd rather tweak our code to work with Microsoft's tools, since most Windows users would prefer that to Clang.

Yup, tried with c++14, gnu++1y, gnu++1z, everything. C++17 makes some copy elision compulsory, which I thought will help clang, because there are lots of problems with returning by copy using private constructors - something that GCC optimizes away.
You don't want to make this code compatible with MSVC - their compiler is rotten, has it's own quirks, oh and forget about variadic templates. Even MS bundles clang with their build tools so that one may use it for compiling too new projects. They bundle old version though (3.8, llvm.org has 5.0).
I've spent 4 days trying to compile tangram-es using non-gcc so if you have any other questions - ask away, prob'ly been there. ;)

Hello,
I've tried to compile your code on 64bit Windows 7 using the following Mingw: http://mingw-w64.org/doku.php/download/mingw-builds
I get a lot of the following error while building it:

D:/projects/OSM_app/tangram-es-tehkain/tangram-es/core/deps/glm/glm/detail/type_
vec4_simd.inl:156:11: error: 'struct glm::tvec4<float, (glm::precision)5>' has n
o member named 'data'
Result.data = mm_mul_ps(a.data, mm_rcp_ps(b.data));
^~~~

Did you encounter anything like this while working on it?
Thank you in advance!

Hi there,
My project needed rebuilding of tangram dependency, but my working branches became nasty. Since my last contributions I've learned a bit more about git, I've gave it another go - this time I'll rebase it on latest master periodically until it gets merged.
Here's a branch based on most recent master. Sample app runs and I've even left a decent README with build instructions, but there's a problem - my app closes without any backtrace and error after 2s just in the middle of fetching fonts from the net - in the middle of urlClient logging, even if I enforce urlClient count to 1, thus it must be something else than curl. Any help would be appreciated. ;)

@tehKaiN Can you please put a Pull Request for your work on this? It will be good to review it using github's review system. Thanks

I've added #1812.

So I've run it in gdb and this time I've added break exit and I get this:
ader.cpp:1745: Can't find data source touch for layer touch
[Switching to Thread 5548.0xf5c]

Thread 10 hit Breakpoint 1, 0x760b5df5 in msvcrt!_exit () from C:\WINDOWS\System32\msvcrt.dll
(gdb) bt
#0  0x760b5df5 in msvcrt!_exit () from C:\WINDOWS\System32\msvcrt.dll
#1  0x760ab4d8 in msvcrt!abort () from C:\WINDOWS\System32\msvcrt.dll
#2  0x0073b9aa in uw_init_context_1 (context=context@entry=0x7dceef0, outer_cfa=outer_cfa@entry=0x7dcf0d0,
    outer_ra=0x977b9c <__cxa_throw+92>) at ../../../../../src/gcc-7.3.0/libgcc/unwind-dw2.c:1579
#3  0x0073bfbe in _Unwind_RaiseException (exc=0x715e228) at C:/mingw730/src/gcc-7.3.0/libgcc/unwind.inc:88
#4  0x00977b9c in __cxa_throw ()
#5  0x007f1b83 in YAML::as_if<bool, void>::operator() (this=0x7dcf15c)
    at C:/prg/_git/tangram-es/core/deps/yaml-cpp/include/yaml-cpp/node/impl.h:142
#6  0x007f0e58 in YAML::Node::as<bool> (this=0x7dcf314)
    at C:/prg/_git/tangram-es/core/deps/yaml-cpp/include/yaml-cpp/node/impl.h:162
#7  0x004580e8 in Tangram::getBool (node=..., value=@0x7dcf21f: false, name=0x0)
    at C:\prg\_git\tangram-es\core\src\util\yamlHelper.cpp:147
#8  0x00424ee6 in Tangram::SceneLoader::generatePredicate (_node=..., _key="type")
    at C:\prg\_git\tangram-es\core\src\scene\sceneLoader.cpp:1378
#9  0x004249d6 in Tangram::SceneLoader::generateFilter (_filter=..., scene=...)
    at C:\prg\_git\tangram-es\core\src\scene\sceneLoader.cpp:1345
#10 0x00427dbf in Tangram::SceneLoader::loadSublayer (layer=..., layerName="touch:line", scene=
    std::shared_ptr (count 6, weak 0) 0x71022e8) at C:\prg\_git\tangram-es\core\src\scene\sceneLoader.cpp:1710
#11 0x0042805c in Tangram::SceneLoader::loadSublayer (layer=..., layerName="touch",
    scene=std::shared_ptr (count 6, weak 0) 0x71022e8) at C:\prg\_git\tangram-es\core\src\scene\sceneLoader.cpp:1723
#12 0x004286d5 in Tangram::SceneLoader::loadLayer (layer=..., scene=std::shared_ptr (count 6, weak 0) 0x71022e8)
    at C:\prg\_git\tangram-es\core\src\scene\sceneLoader.cpp:1763
#13 0x0041af56 in Tangram::SceneLoader::applyConfig (_platform=std::shared_ptr (count 10, weak 0) 0x70a6958,
    _scene=std::shared_ptr (count 6, weak 0) 0x71022e8) at C:\prg\_git\tangram-es\core\src\scene\sceneLoader.cpp:264
#14 0x00419730 in Tangram::SceneLoader::loadScene (_platform=std::shared_ptr (count 10, weak 0) 0x70a6958,
    _scene=std::shared_ptr (count 6, weak 0) 0x71022e8, _updates=std::vector of length 1, capacity 1 = {...})
    at C:\prg\_git\tangram-es\core\src\scene\sceneLoader.cpp:78
#15 0x0040d5f7 in Tangram::Map::<lambda()>::operator()(void) const (__closure=0x710a520)
    at C:\prg\_git\tangram-es\core\src\map.cpp:269
#16 0x004114b1 in std::_Function_handler<void(), Tangram::Map::loadSceneAsync(std::shared_ptr<Tangram::Scene>, const std::vector<Tangram::SceneUpdate>&)::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...)
    at C:/prg/kompilatory/mingw-w64/mingw32/lib/gcc/i686-w64-mingw32/7.3.0/include/c++/bits/std_function.h:316
#17 0x0084af9a in std::function<void ()>::operator()() const (this=0x7dcfdcc)
    at C:/prg/kompilatory/mingw-w64/mingw32/lib/gcc/i686-w64-mingw32/7.3.0/include/c++/bits/std_function.h:706
#18 0x007917ed in Tangram::AsyncWorker::run (this=0x70beb40) at C:/prg/_git/tangram-es/core/src/util/asyncWorker.h:47
#19 0x0094f9cf in std::__invoke_impl<void, void (Tangram::AsyncWorker::*)(), Tangram::AsyncWorker*> (
    __f=@0x70bede8: (void (Tangram::AsyncWorker::*)(Tangram::AsyncWorker * const)) 0x791734 <Tangram::AsyncWorker::run()>, __t=@0x70bede4: 0x70beb40)
    at C:/prg/kompilatory/mingw-w64/mingw32/lib/gcc/i686-w64-mingw32/7.3.0/include/c++/bits/invoke.h:73
#20 0x0096cb63 in std::__invoke<void (Tangram::AsyncWorker::*)(), Tangram::AsyncWorker*> (
    __fn=@0x70bede8: (void (Tangram::AsyncWorker::*)(Tangram::AsyncWorker * const)) 0x791734 <Tangram::AsyncWorker::run()>, __args#0=@0x70bede4: 0x70beb40)
    at C:/prg/kompilatory/mingw-w64/mingw32/lib/gcc/i686-w64-mingw32/7.3.0/include/c++/bits/invoke.h:95
#21 0x008d86f2 in std::thread::_Invoker<std::tuple<void (Tangram::AsyncWorker::*)(), Tangram::AsyncWorker*> >::_M_invoke<0u, 1u> (this=0x70bede4)
    at C:/prg/kompilatory/mingw-w64/mingw32/lib/gcc/i686-w64-mingw32/7.3.0/include/c++/thread:234
#22 0x008d8736 in std::thread::_Invoker<std::tuple<void (Tangram::AsyncWorker::*)(), Tangram::AsyncWorker*> >::operator() (this=0x70bede4) at C:/prg/kompilatory/mingw-w64/mingw32/lib/gcc/i686-w64-mingw32/7.3.0/include/c++/thread:243
#23 0x008d805e in std::thread::_State_impl<std::thread::_Invoker<std::tuple<void (Tangram::AsyncWorker::*)(), Tangram::AsyncWorker*> > >::_M_run (this=0x70bede0)
    at C:/prg/kompilatory/mingw-w64/mingw32/lib/gcc/i686-w64-mingw32/7.3.0/include/c++/thread:186

So I get crash from this sceneLoader line: auto sublayer = loadSublayer(layer.second, name, scene); which gets into loadSubLayer() for touch:line which calls as_if<bool, void> and throws
template <typename T>
struct as_if<T, void> {
  explicit as_if(const Node& node_) : node(node_) {}
  const Node& node;

  T operator()() const {
    if (!node.m_pNode)
      throw TypedBadConversion<T>(node.Mark());

    T t;
    if (convert<T>::decode(node, t))
      return t;
    throw TypedBadConversion<T>(node.Mark()); // <---- HERE
  }
};

all of that using master's scene.yaml generated into bin folder.

@tehKaiN It's weird that tangram would be crashing at this point - as you can see from the line printed in the stack trace our code is explicitly catching an exception that encompasses the thrown exception (https://github.com/tangrams/tangram-es/blob/master/core/src/util/yamlHelper.cpp#L147). Maybe your compiler needs a flag to correctly support exception handling?

Okay, so exceptions support was a good trail. I've reinstalled mingw-w64 to i686-8.1.0-posix-sjlj-rt_v6-rev0 and it works - it looks like some kind of DWARF2 problem.

So I've added a bit of Windows support for main Makefile, but it made it ugly.
Windows cmd console behaves differently than everything else in terms of creating and deleting directories, so I had to add basic host detection and substitute mkdir/rm cmds with vars.
make clean-windows works, but it uses backslashed path (build\windows) since forward slash doesn't work well with rmdir. This is the reason why make clean doesn't work: rest of clean- targets use forward-slashed path. One way to overcome this is to replace slashes in host platform-dependent way. If you feel fine with such change, I'll try to apply it.
Another potential fix is to put notice in README.md that to successfully build you need linux cmd tools which come with MSYS2 or git-scm.
I guess such incompatibilities are one of the main reasons why CMake was invented. Perhaps it would be wise to scrap main makefile altogether and just instruct users to create build folder and call appropriate cmake .. from there.

I've dusted off my wxWidgets Tangram widget code - I'll create pull request after Windows gets merged.


[IOTDB-2334] Unreasonable debug log level of python client Session

It‘s inappropriate to use debug level when error occurs in verify_success method, I change it to error level.

Coverage increased (+0.003%) to 67.626% when pulling 6ecf65fb326290c5700990cdc80bc717bc75a659 on HeimingZ:IOTDB-2334 into 8a51c4245f24709d8629344d2b2cb051d2593759 on apache:master.


⚠ AtmoBunker01 Server has degraded performance

In e83e695, AtmoBunker01 Server ($ATMOBUNKER01) experienced degraded performance:

HTTP code: 200
Response time: 10253 ms

Resolved: AtmoBunker01 Server performance has improved in d6cba00 after 11 minutes.


Enhancement: show price graph with sparklines

It would be cool to have a little price graph like the one on coinmarketcap using sparklines. (sparkly)

Coinmarketcap.com does not provide graph data.  Also I am not sure where this would fit as the current table is already big on laptops.

Closing, you can submit a PR if you want.


RuntimeError: Forward order differs across ranks: rank 0 is all-gathering 0 parameters while rank 1 is all-gathering 1 parameters

System Info
torch 2.0.1+cu118
cuda 11.8
transformers: 4.31.0
Information

[X] The official example scripts
[ ] My own modified scripts

🐛 Describe the bug
I see this error when I run the finetuning script with FSDP + PEFT on 2 A100s. This error goes away when I set the environment variable  export NCCL_P2P_DISABLE=1. I wanted to confirm if this is the right way to go about this or if suppressing this error might lead to other bugs in training/finetuning.
Error logs
traceback : Traceback (most recent call last):
    File "/cluster/project/sachan/kushal/llenv/lib64/python3.8/site-packages/torch/distributed/elastic/multiprocessing/errors/__init__.py", line 346, in wrapper
      return f(*args, **kwargs)
    File "llama_ft.py", line 178, in main
      results, eval_preds = train(
    File "/cluster/project/sachan/kushal/llama-exp/llama_train_utils.py", line 89, in train
      outputs = model(**batch, labels=batch["input_ids"])
    File "/cluster/project/sachan/kushal/llenv/lib64/python3.8/site-packages/torch/nn/modules/module.py", line 1501, in _call_impl
      return forward_call(*args, **kwargs)
    File "/cluster/project/sachan/kushal/llenv/lib64/python3.8/site-packages/torch/distributed/fsdp/fully_sharded_data_parallel.py", line 739, in forward
      args, kwargs = _pre_forward(
    File "/cluster/project/sachan/kushal/llenv/lib64/python3.8/site-packages/torch/distributed/fsdp/_runtime_utils.py", line 409, in _pre_forward
      state._exec_order_data.record_pre_forward(handles, module.training)
    File "/cluster/project/sachan/kushal/llenv/lib64/python3.8/site-packages/torch/distributed/fsdp/_exec_order_utils.py", line 180, in record_pre_forward
      self._check_order(handles_key, is_training)
    File "/cluster/project/sachan/kushal/llenv/lib64/python3.8/site-packages/torch/distributed/fsdp/_exec_order_utils.py", line 243, in _check_order
      raise RuntimeError(
  RuntimeError: Forward order differs across ranks: rank 0 is all-gathering 0 parameters while rank 1 is all-gathering 1 parameters

Expected behavior
The code should run without the error while running distributed finetuning.

@kushalj001 I am not able to repro the issue on my end, can you pls make sure you are using PT nightlies in case of using FSDP+PEFT. Also pls share more details/ a repro.

@kushalj001 from issue #83 can you pls confirm if this issue is resolved?


Following start guide - how to view created resources in AWS console?

Apologies for the newbie question - I am learning about Agones, GameLift FleetIQ and plan to use AWS FlexMatch to create a game service for CSGO (source engine) - I plan to use a webhook autoscaler with AWS and write a wrapper for the game server.
I followed the guide to create a workspace and set up all the aws resources - all good managed to get to the end of the guide and proceed with the scaling up and replicas seeing the nodes - however it didn't ever scale up to 100 nodes stopping at 54 with 1 group and 60 with 2 groups. I'd like to understand more of this adapter and agones but I can't see any of these resources in my AWS account except for the GameLift groups. The EKS cluster does show up but doesn't display any nodes.
This isn't really an issue with the repo - I'd just like to learn more but I can't see any forum or slack channel/similar for this. I'd like to be able to work on the components of the solution architecture and visualise where I need to work on, if you guys can give any recommendations.
Thanks.

So it looks like you have 2 ASGs/game server groups:
--nodes=0:10:gamelift-gameservergroup-
--nodes=0:10:gamelift-gameservergroup-agones-game-server-group-02
It also looks like you're using the priority expander. I suggest deleting 1 of the 2 ASGs and using the least waste expander with auto discovery. Not sure why the guide has you create multiple game server groups. You should be able to get the capacity you need from a single ASG with diverse instance types that spans multiple AZs.

Thanks @jicowan I will look into deleting the groups. At this stage I am just testing agones and need to develop a wrapper and autoscaler - Ideally I'd like to run this for cheap or locally to avoid charges - following the guide with no mention of costs, I have accrued $200+ in charges! I just wanted to learn about the system.
Any advice?

How long has the environment been running? The EKS control plane costs 10 cents an hour which comes to about $70/mo. You also pay for the provisioned compute. A majority of that should be Spot which costs 40% less (on average) than the on demand cost. FleetIQ doesn't offer as steep a discount as Spot. If you're primarily interested in testing Agones, you can try using Kubernetes in Docker (kind) assuming you have a machine powerful enough to run your game + Kubernetes. Definitely appreciate you trying the solution. Happy to continue working with you to get it working in your environment.

You need to delete the game server group to delete the ASGs. You can't delete the ASGs directly because they are managed by FleetIQ.

Think its been running since May 7th, I'm in the GameLift game server group area on the console and have no options to delete, might be permissions. Are the some commands I could run in the Cloud9 dev environment?

aws gamelift delete-game-server-group --game-server-group-name
I think that'll do it.

Yeah that should do it, but I don't know how to force or shutdown the gameservers first?
ec2-user:~/environment $ aws gamelift delete-game-server-group --game-server-group-name agones-game-server-group-01

An error occurred (InvalidRequestException) when calling the DeleteGameServerGroup operation: Failed to SAFE_DELETE as there exists at least one UTILIZED game server
ec2-user:~/environment $ aws gamelift delete-game-server-group --game-server-group-name agones-game-server-group-02

An error occurred (InvalidRequestException) when calling the DeleteGameServerGroup operation: Failed to SAFE_DELETE as there exists at least one UTILIZED game server
ec2-user:~/environment $

No problem. Go to the ASG and set the min and desired count to 0 first.

Thanks - managed to set the ASG programatically with aws autoscale, but then I found the groups in the console anyway and have terminated the instances. Also found some ELBs. My services say I am still billed for EKS and some GameLift things but in those respective areas of the console I can't view anything to delete, even as the root user.
I've got a support case going on so they might be able to help me further.


I want to have codegen produce basic typings for all wrappers I import

types, functions

This should be completed now that we've revamped all app-bindings


raidboss: convert triggers to regex helpers

Now that #740 has landed, I think the next step is to convert as many triggers as possible to use this.  Maybe the bulk of this could be done with some crafty python scripts? I'm sure there will be some corner cases missing or maybe some new helper functions that are needed.  I would be supportive of changing one type at a time or one file at a time, or whatever piecemeal approach makes this easier to get done.  However, I think the direction is that I'd like cactbot to use these by default, and I will use them when writing new trigger files.  Patches are very welcome.
Finally, once this conversion is done, the next step is to use the translation properties that are currently only used for timelines to also be used for triggers.  This will likely need a little bit of care and attention as the regexes (even if automatically generated) are still manual and have received manual editing over time and so may not match the translation blocks any more.

Might take a stab at this over the holidays...
If I wanted to make a script as you were suggesting would util/ be where I toss it?

I think the easiest way to do it would be to just convert one type at a time (e.g. 14 starts casting).  I don't know that the script would necessarily need to get committed, since it's mostly a run once sort of thing, and future triggers can just be written correctly the first time.

Yeah, that's a good point.
I'll give the english ones a first pass and test in Trusts and then go from there. :)

Sounds great! Any conversion you get done would be much appreciated.  :)

Started working on this and a basic script that goes through it has caught a lot of the easy cases! Hopefully will have something to review before the end of Christmas but one question about how you'd like the triggers structured.
In the o5n.js update for #740 there's the following:
regex: / 14:28A3:Phantom Train starts using Doom Strike on (\y{Name})/, becoming
Regexes.startsUsing({ name: 'Phantom Train', id: '28A3' }),
Looking at the top of #740, there's also:
Regexes.startsUsing({id: ['1C7F', '1C90'], name: 'Deathgaze Hollow', ability: 'Void Death'})
Should the ability always be included or omitted? The ability is also in the trigger name usually so I can see the argument for dropping the ability, but maybe it's helpful for debugging to include it in the actual helpers still?

My feeling is that we should drop ability names, because they make for more translation work, and the id should be unique.  Ideally the ability name should be clear from the trigger id, and if it's not, then add a comment.  Probably the ability name should be removed anywhere that it's not needed (like that Void Death example).
See this for an example: https://github.com/quisquous/cactbot/blob/master/ui/raidboss/data/05-shb/ultimate/the_epic_of_alexander.js#L795

Question about the helpers (and let me know if you'd rather see this via a CL or just more comments in here).
For e4s my startsUsing replacements generate: regex: Regexes.startsUsing({id: '410C', source: 'Titan'}), which seems to work.
However, for Dohn Mehg I generate:
Regexes.startsUsing({id: '3DAA', source: 'Dohnfast Fuath'}) from / 14:3DAA:Dohnfast Fuath starts using Watering Wheel/ and none of these seem to work on DRK, but reverting back to the original does work.
Also looking at helpers for starts using $ability on $target, I assume there will also need to be a corresponding update to the matcher logic to also include some clause similar to the TEA Chastening Heat matching where it does get captured?

However, for Dohn Mehg I generate:
Regexes.startsUsing({id: '3DAA', source: 'Dohnfast Fuath'}) from / 14:3DAA:Dohnfast Fuath starts using Watering Wheel/ and none of these seem to work on DRK, but reverting back to the original does work.

Hmm, that's really surprising.  What is the log line where this is or isn't targetting?
If you play your network log where you ran this dungeon back in the raidboss emulator (ui/raidboss/raidemulator.html), does the trigger work properly?

Also looking at helpers for starts using $ability on $target, I assume there will also need to be a corresponding update to the matcher logic to also include some clause similar to the TEA Chastening Heat matching where it does get captured?

Yeah.  You'll need to change from matches[1] (or whatever index) to matches.target etc.  I think this should all end up more readable!

Yeah. You'll need to change from matches[1] (or whatever index) to matches.target etc. I think this should all end up more readable!

That worked! :)

Hmm, that's really surprising. What is the log line where this is or isn't targetting?

The raw log line:
20|2019-12-25T21:13:36.0650000-08:00|40011526|Dohnfast Fuath|3DAA|Watering Wheel|40011523|Dohnfast Anemone|10.70||2d769f48adaa17c244605c3bb71cd596

If you play your network log where you ran this dungeon back in the raidboss emulator (ui/raidboss/raidemulator.html), does the trigger work properly?

I'll grab a full run tomorrow once DF is out of maint, re-running my partial trust logs doesn't seem to work correctly in the raidboss emulator whereas my e4s runs did.

As an aside: #881 probably keeps me from doing the replay testing on that particular trigger. I can just continuously join and quit a trust to see about getting it to work in the future.


Fixed a few places where device sticky-ness was lost. Added FAQ

I have also added a new test (multi_device_test.test_computation_follows_data),
written more as part of the documentation. It is shorted than the
old test_computation_follows_data (which is still there, renamed
as test_computation_follows_data_old). I believe there is no
extra coverage in test_computation_follows_data_old w.r.t. all the
other tests we have.
Relates to #2564

I am wondering if jax.device_put without device makes sense for the end user, and if so, how would one specify its behavior? I believe that currently for data that is not on a device it puts it on the default device (uncommitted, unlike the other uses of device_put) or leaves the data and commitment as is if already on device.

@chr1sj0nes @tomhennigan do you think it makes sense to merge this FAQ description, basically of the device_put-based computation-follows-data policy we discussed? We could hold off if needed.

I made an update. I also updated the device_put docstring.


Create type-safe dependency injection container.

Summary
Closes #34.
Definition of Done

[x] Code is:

[x] written in idiomatic Rust
[x] commented where necessary
[x] documented where beneficial
[x] follows the project's coding standards, and
[x] is efficiently structured for maintenance and scalability.

[ ] Changes are benchmarked to ensure they do not degrade performance.
[x] Comprehensive unit tests cover new functionality and changes.
[ ] Integration tests cover features with user stories where possible.

Codecov Report
Attention: Patch coverage is 94.52055% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.71%. Comparing base (72712cf) to head (37ea978).

Files
Patch %
Lines

src/di/container.rs
91.83%
4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
+ Coverage   79.41%   89.71%   +10.30%
===========================================
  Files           2        5        +3
  Lines          34      107       +73
===========================================
+ Hits           27       96       +69
- Misses          7       11        +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Use double slash instead of triple slash in file header template

Motivation
Doc comment (triple slash) for a header can cause the VSCode tooltip to contain unnecessary information.

Desired solution
Use double slash instead of triple slash in file header template.
Alternatives considered
Ignore it.
Additional details
If there are import statements after the header, then the extra information is not shown.

And one more thing. Is there a reason why headers have a "tail" (empty ///)?
https://github.com/intel/rohd/blob/58584d2bc6ac0d7844dd92b2ecc85a5365bcfa5c/lib/src/simulator.dart#L8-L10

Well, and more about the template: is there a reason why you need to indicate the time of creation of the file and authorship if this data is stored in the version control system?

You're right, double slash seems more appropriate for the file headers.  I looked at some of the dart-sdk code and they use double slash on their file headers as well.
I think in some files we had put a single // between the header and the definition in order to avoid that extra doc stuff showing up in case there were no import statements.
The tail was just a style preference which I'm not that sure about anymore.  Originally, I think I used /* */ style block-comments at the top of files and had no comment content on the first and last lines.  Eventually there was some guidance to put copyright and license identifier information right at the top, so the blank head line got removed, but the tails didn't.  I'm not attached to the tails and wouldn't really object to removing them.
The creation time and authorship are nice to stick in a file header because even though within the repository there's version control tracking, when files get copied to other locations it leaves a breadcrumb about where they came from.  I admit that these become less relevant, accurate, and useful as the files get modified over time, especially in an open-source project.  I think I'm not really opposed to them being modified/removed over time as files go through meaningful changes or omitted when new files are created, but I'm also thinking it's perhaps unnecessary for any sort of "sweep" to remove existing ones all at once.  I'm open to other thoughts and opinions on the matter.
We should apply changes to https://github.com/intel/rohd-vf and https://github.com/intel/rohd-cosim as well.

I think the fix for this issue should also update guidelines in CONTRIBUTING.md

I'll make some other suggestions that come to mind:

Usually (in the same DartSDK) they use a small c: (c) Instead of (C). Can use it?
Can add a comma: Copyright (c) 2023, Intel Corporation?
Can the template be reformulated so that it is in the form of text (as in the DartSDK code) and not a list?
Can stop writing the year the file was last modified? Every year it creates a wave of little noise. In the same DartSDK, only the year the file was created is indicated.

Usually (in the same DartSDK) they use a small c: (c) Instead of (C). Can use it?
Can add a comma: Copyright (c) 2023, Intel Corporation?
Can the template be reformulated so that it is in the form of text (as in the DartSDK code) and not a list?

These formats on the copyright statement come from a standard template that Intel provided.  I think in this case consistency with Intel guidelines is preferable to consistency with the Dart SDK.  Unless there's some additional motivation?

Can stop writing the year the file was last modified?

From a bit of googling, it sounds like it's typical to update the copyright year each time it is modified/published so copyright protection expiration can be easily determined.  I'm not sure if it's necessary for us to update it each time, though.  I'll ask around if there's any specific Intel guidance on this.

These formats on the copyright statement come from a standard template that Intel provided. I think in this case consistency with Intel guidelines is preferable to consistency with the Dart SDK. Unless there's some additional motivation?

Of course, if there are established recommendations, then we use them. Just outlined some ideas, suddenly something can be reconsidered.

Sure, thank you for the thought and suggestions!  I appreciate the effort to make the codebase cleaner and more consistent.

I've received guidance to update the year in the copyright as files are updated as a best practice for open-source software.  Part of the reasoning is that open-source files can frequently appear outside of their original repos.

Thanks for the clarifications!
As a result (for now): what will be the updated template? If I understand correctly, it will be something like this:
// Copyright (C) 2021-2023 Intel Corporation
// SPDX-License-Identifier: BSD-3-Clause
//
// example.dart
// A very basic example of a counter module.

Or will the file name be omitted?
// Copyright (C) 2021-2023 Intel Corporation
// SPDX-License-Identifier: BSD-3-Clause
//
// A very basic example of a counter module.

You can shrink even more by removing the indentation.
// Copyright (C) 2021-2023 Intel Corporation
// SPDX-License-Identifier: BSD-3-Clause
// A very basic example of a counter module.

Personally, I like the file name in there and space between the boilerplate and interesting content (first option in your previous comment)
I think having original author and creation date doesn't hurt, but also is fine to make it not a requirement.  Removing/appending author and removing creation date after significant changes to a file I think would make sense.


Raster/VGA/Code page 437 font

It would be nice if the Terminal had the option to use raster fonts, or if there was an official TTF version of the VGA/Code page 437 font.
In the past people have created unofficial TTF versions of the Code page 437 font (Perfect DOS VGA 437 and More and Less Perfect DOS VGA) but in spite of their names they're not perfect.
I think users would want this because people who intentionally choose to use a console are the same people who would be nostalgic for the fonts of their youth.
An argument against it would be that Code page 437 doesn't contain characters for other languages/unicode/emojis.  Potentially these could be added for full compatibility (if that's possible in 8x16 pixels) or left as a known limitation that users would know they're opting in for by using the font.

This is gonna be a hard no. I am not the person qualified to rant on why we're not supporting raster fonts in the terminal, but needless to say it's a inconcievably complicated mess that we're just not going to add a compatibility layer for. I'd recommend finding a TTF that comes close to the right appearance for you.
@miniksa is the person who'll have a longer rant (if you're interested)

Raster fonts don't work in DirectX. Terminal uses a DirectX renderer.
I have a lot more to complain about in this space, but I have already wasted enough of my life to raster fonts that I'm going to just stop there and "Won't Fix" this.

Is that also a no on an official TTF version of the Code page 437 font?

Correct. That would cost money. To get money to recreate the font, I'd have to convince someone to pay for it. I don't think I can convince anyone to pay for it for nostalgia purposes.

I got it working perfectly by installing the attached files (Less Perfect has tighter kerning while More Perfect is easier on the eyes). Make sure to turn off anti-aliasing in your profile's appearance settings.
Originally obtained from here
RasterFonts.zip


Merge /v2 module suffix for import paths into Algorithm W branch

The master branch has been updated to use /v2 suffix for the module version. The algorithm w branch is a long lived branch at feat/use-algo-w. We need to merge in this change and resolve conflicts for the imports.

Fixed by #17624.


make (e=2): The system cannot find the file specified. "tmt.dll"

The commands "make" or "make mingw", generate the same error. The system cannot find the file specified.

It seems to try and use cc as C compiler, I think you need to fix that to what your actual compiler command is (maybe something like gcc or something mingw-related). I think you can do that by adding CC=gcc at the top of the Makefile, or setting the CC environment variable to gcc.
Also please be aware that the current version is kind of broken as far as I'm aware, I'm trying to fix it to use the Lite XL plugin API but there's some limitations in the current version. I hope I'll manage to get it working properly as soon as Lite XL 2.1.1 releases. It should also work on Lite XL built from the current master branch, but not sure; haven't looked at this plugin in a while. Otherwise you could try https://github.com/ColonelPhantom/lite-xl-tmt/commit/3b0f00e69ce46ca83e838c66fcdd79995a62abc8 but it also depends on Lite being built against the same Lua as TMT.
If you have Lite XL master and this plugin's current commit and it doesn't work, please let me know!
(I also did not write the Windows-related stuff of this plugin as I'm a Linux user, so if it's platform related I'm not sure how much I can help :/)

Hi @fabiomen10 I just set up some CI for this plugin and now have a somewhat end-user friendly release over at https://github.com/ColonelPhantom/lite-xl-tmt/releases/latest
To install it you just download the zip/tar for your platform, and drop the tmt folder inside into your plugins folder.
I assume this will fix your issue, but please let me know if it works for you!


DevTools opened after closing

https://u.biyori.moe/PWhqpSuK.gif
^Watch dis.

Not much i can do without a reproducibel test case.

Closing for now due to lack of feedback, feel free to reopen if needed.


[ViewData] does not exist

Documentation is wrong on [ViewData], it does not exist

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b6ab455d-e8ea-39ff-3577-8b6ddc23f7b7
Version Independent ID: 2ab43968-907a-78bf-6844-eaaf92d40da5
Content: Introduction to Razor Pages in ASP.NET Core
Content Source: aspnetcore/mvc/razor-pages/index.md
Service: asp.net-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

ViewData requires version 2.1. Check your version selector.
cc @scottaddie


Modified the equals method in all the Value type classes

Added check for null in all the equals methods in all the Value type classes

So, we have been handling null values inconsistently from what I can see. LongValue checks for null whereas the changed classes in this PR did not. The equals contract is to return false for obj.equals(null) but I think there are fair arguments for throwing NPE as well.
I think it's good to have it consistent in all Value classes. I'm in favor of your change, but it is essentially API breaking. There could be someone out there relying on the NPE. ;-)
Need more opinions on this, @tillrohrmann, @fhueske.

Well yes, my opinion is to use getClass in place of instanceOf , I didnt make the change yet , so in that case I think we need to have a check for null reference.

instanceOf being an operator will return false if its a null reference , but getClass being a method will give an exception(I think so), also use of getClass makes more sense since its a equals method and we want both the types to be identical(no sub types)

If there is someone out there relying on the NPE, i think it should be thrown.(throw)

I would not expect equals() to throw an exception, so this is a good fix in my opinion.

either way, it should be one of either getClass or instanceOf , it is inconsistent right now

Merging. Thanks for the PR. Going for getClass.


Failed to compile with hhvm 3.9.0

me@pc:/opt/newrelic_extension# git log
commit 78b4fedb01e3098dfea2845aaf6d9e52c29ba9e3
Author: Christian Stocker<EMAIL_ADDRESS>Date:   Mon May 25 11:09:20 2015 +0200

    adjust readme for 3.7

me@pc:/opt/newrelic_extension# hphpize
** hphpize complete, now run `cmake . && make` to build, `make test` to test

me@pc:/opt/newrelic_extension# cmake .
-- Configuring for HHVM API version 20150212
-- Configuring done
-- Generating done
-- Build files have been written to: /opt/newrelic_extension

me@pc:/opt/newrelic_extension# make
[ 50%] Building CXX object CMakeFiles/newrelic.dir/newrelic.cpp.o
/opt/newrelic_extension/newrelic.cpp:5:46: fatal error: hphp/runtime/ext/ext_hotprofiler.h: No such file or directory
 #include "hphp/runtime/ext/ext_hotprofiler.h"
                                              ^
compilation terminated.
make[2]: *** [CMakeFiles/newrelic.dir/newrelic.cpp.o] Error 1
make[1]: *** [CMakeFiles/newrelic.dir/all] Error 2
make: *** [all] Error 2

me@pc:/opt/newrelic_extension# hhvm --version
HipHop VM 3.9.0 (rel)
Compiler: tags/HHVM-3.9.0-0-ga047a8f8fca8c5a0dd9021867836373ec3e40372
Repo schema: fafdc6abbd9526735214b1d74b58289707518e4f

"hphp/runtime/ext/ext_hotprofiler.h" has been moved under "hphp/runtime/ext/hotprofiler/ext_hotprofiler.h".  You need to make the necessary changes in the newrelic.cpp file when including the header files.

I've made the necessary changes, confirmed that it works in my dev environment, and submitted a pull request: https://github.com/chregu/hhvm-newrelic-ext/pull/37

+1

+1

+1
Working on ArchLinux

I get:
Sep  9 10:53:11 web kernel: [10079347.903083] init: hhvm main process (7493) terminated with status 255
Sep  9 10:53:11 web kernel: [10079347.903096] init: hhvm main process ended, respawning

1 @craigcarnell

https://github.com/chregu/hhvm-newrelic-ext/pull/37 fix this. closing this issue. Let's move to https://github.com/chregu/hhvm-newrelic-ext/issues/45


Fixed missing placeholder issue

Fixes #124

Minor fix in CSS to make the placeholder visible.

@amaldinesh7 _a please review.

@AbhayVAshokan _a Please make the changes as discussed.

@amaldinesh7 _a please have a look.
These lines were accidentally removed by me while rebasing #97. Added the same back.


Manage Access Dialog Does not Change Inputted OIDs to UPNs

If a user enters and OID into the input box of the Manage Access dialog, we do not translate it to a UPN for the user. We leave it as an OID. The platform team has requested that we instead translate the OID into a UPN.

We'll now be showing friendly names for things already in the ACL!

Fix merged into master for 1.10.0


Moments drop

does this app already have auto claim moments? it's a kind of twitch drop, but it's relatively new

Hello o/
Right now, timed drops are the only ones supported. There's no plans to expand on this. However, this is a drops-focused application, and if I can ever figure out how to add them to the miner - sure, why not. The more drop kinds is supported, the better.

does this app already have auto claim moments? it's a kind of twitch drop, but it's relatively new

You can claim them with BTTV and many other extensions


Problems lauching node

Hey everyone, I have followed your instructions in the README, i have my own geth node on ETH listening to port 8545 8546 and 8551 (http / wss / auth) but its the same port as this node, i have tried to change it in docker-compose.yml and in geth-entrypoint and op-node-entrypoint but after I got some problems with the client running indefinitely and saying ''waiting for geth''' because i think i have changed too many ports
Can someone guide me on which port to change (only http/wss or auth/udp/tcp as well etc?) and in which files ? Perhaps if you have the time I would love to understand more about the 'why' of this + what represent the : in the docker compose like ports 7545:8545 ? (why is it two different port)
Thanks !

If you are experiencing a port conflict with an existing Geth node running on ports 8545 and 8546, you can change the first number on these two lines: https://github.com/base-org/node/blob/8690d2890381087881464b344b64e4ca5ada04b8/docker-compose.yml#L7-L8
The first number is the port on the local machine, and the second number is the port used by the binary running within the docker container. You can read more about this here: https://docs.docker.com/compose/networking/, in particular:

It is important to note the distinction between HOST_PORT and CONTAINER_PORT. In the above example, for db, the HOST_PORT is 8001 and the container port is 5432 (postgres default). Networked service-to-service communication uses the CONTAINER_PORT. When HOST_PORT is defined, the service is accessible outside the swarm as well.

Note that you do not have to change any of the configuration or entrypoint scripts, as the two containers communicate using docker DNS names, for example: https://github.com/base-org/node/blob/8690d2890381087881464b344b64e4ca5ada04b8/.env.goerli#L14

services:
  geth: # this is Optimism's geth client
    build: .
    ports:
      - 8555:8545       # RPC
      - 8556:8546       # websocket
      - 30304:30304     # P2P TCP (currently unused)
      - 30304:30304/udp # P2P UDP (currently unused)
      - 7301:6060       # metrics
    command: [ "sh", "./geth-entrypoint" ]
    env_file:
      # select your network here:
#      - .env.goerli
      - .env.mainnet
  node:
    build: .
    depends_on:
      - geth
    ports:
      - 7545:8545     # RPC
      - 9222:9222     # P2P TCP
      - 9222:9222/udp # P2P UDP
      - 7300:7300     # metrics
      - 6060:6060     # pprof
    command: [ "sh", "./op-node-entrypoint" ]
    env_file:
      # select your network here:
#      - .env.goerli
      - .env.mainnet

my geth node is running on port 8545 and 8546 but I get :
node-node-1  | t=2023-08-18T05:16:43+0000 lvl=info msg="Initializing Rollup Node"
node-node-1  | t=2023-08-18T05:16:43+0000 lvl=warn msg="Unknown env var"          prefix=OP_NODE env_var="OP_NODE_L2_ENGINE_AUTH_RAW=688f5d737bad920bdfb2fc2f488d6b6209eebda1dae949a8de91398d932c517a"
node-node-1  | t=2023-08-18T05:16:43+0000 lvl=info msg="Rollup Config"            l2_chain_id=8453 l2_network="unknown L2" l1_chain_id=1 l1_network=mainnet l2_start_time=1,686,789,347 l2_block_hash=0xf712aa9241cc24369b143cf6dce85f0902a9731e70d66818a3a5845b296c73dd l2_block_number=0 l1_block_hash=0x5c13d307623a926cd31415036c8b7fa14572f9dac64528e857a470511fc30771 l1_block_number=17,481,768 regolith_time="@ genesis"
node-node-1  | t=2023-08-18T05:16:43+0000 lvl=eror msg="Error initializing the rollup node" err="Post \"http://localhost:8545\": dial tcp <IP_ADDRESS>:8545: connect: connection refused"
node-node-1  | t=2023-08-18T05:16:43+0000 lvl=eror msg="Unable to create the rollup node"   error="Post \"http://localhost:8545\": dial tcp <IP_ADDRESS>:8545: connect: connection refused"
node-node-1  | t=2023-08-18T05:16:43+0000 lvl=crit msg="Application failed"                 message="Post \"http://localhost:8545\": dial tcp <IP_ADDRESS>:8545: connect: connection refused"

Did you solve it eventually?


Git watcher should ignore changes in files.exclude

VSCode Version: 1.46.0-insider
OS Version: macOS Catalina (10.15.4)

When a Meteor project is running, it creates a MongoDB database in the project directory under .meteor/local/db. MongoDB writes files in this directory about every ten seconds, which triggers some git calls and causes the clock badge to appear on the source control icon. A similar issue has been reported and fixed before (#43234) but the fix addressed a different cause.
Here's a video (including log output from code --verbose): https://streamable.com/asm3u0
Git output:
> git status -z -u
> git symbolic-ref --short HEAD
> git rev-parse master
> git rev-parse --symbolic-full-name master@{u}
> git rev-list --left-right master...refs/remotes/origin/master
> git for-each-ref --format %(refname) %(objectname) --sort -committerdate
> git remote --verbose
> git config --get commit.template

File watcher log output from code --verbose:
TRACE [File Watcher (chokidar)] [CHANGED] /Users/christian/vscode-bug/.meteor/local/db/diagnostic.data/metrics.interim
TRACE [File Watcher (chokidar)]  >> normalized  [CHANGED] /Users/christian/vscode-bug/.meteor/local/db/diagnostic.data/metrics.interim

The .meteor/local directory is included in .gitignore and the Files: Exclude setting in VS Code. Shouldn't it be ignored by the file watcher as well?
Steps to Reproduce:

Create a Meteor project with meteor create --bare test-project.
Create a Git repository for the project and push it to a remote.
Run meteor in the project directory.
The clock badge appears on the source control icon every ten seconds.

Does this issue occur when all extensions are disabled?: Yes

I just realized that this can easily be fixed by adding **/.meteor/local/** to the files.watcherExclude setting.


Normalise use of Nullable

Some places in the API use nullable (mostly inherited from the java.compiler API), and others use Optional.
Replace the optional usages with the nullable annotation for consistency.
Examples of places we do this:

https://github.com/ascopes/java-compiler-testing/blob/main/java-compiler-testing/src/main/java/io/github/ascopes/jct/diagnostics/TraceDiagnostic.java#L142
https://github.com/ascopes/java-compiler-testing/blob/main/java-compiler-testing/src/main/java/io/github/ascopes/jct/compilers/JctCompiler.java#L781
https://github.com/ascopes/java-compiler-testing/blob/main/java-compiler-testing/src/main/java/io/github/ascopes/jct/compilers/JctCompiler.java#L839
https://github.com/ascopes/java-compiler-testing/blob/main/java-compiler-testing/src/main/java/io/github/ascopes/jct/compilers/JctCompiler.java#L897

All of these should be able to be replaced with @io.github.ascopes.jct.annotations.Nullable and to just return potentially null values.

Closed by b7576deb264eaa3aa0083a2791dceb58687e90d1. I accidentally referenced the wrong issue. Oops.


[BUG] Lsp mode cannot be enabled on a javascript file without .js extension

Describe the issue
Editing a javascript file that has no .js extension will not enable lsp-mode for that buffer. The file (script) has a #!/usr/bin/env node header that should let the editor know what type of file it is what it does enable Javascript IDE mode which apparently is an extension of the js2-mode, but the language server (typescript-language-server) is not started. I get the following error:
LSP :: No LSP server for js2-mode(check *lsp-log*).
Steps to reproduce
To reproduce this, unzip the attached file lsp-problem.zip and open the bla/script file in emacs. Next set the cursor on the logSmth() function call and try to go to definition. You will get this stacktrace from tsserver in the messages buffer:
Error: No Project.
    at Object.ThrowNoProject (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:127999:23)
    at ProjectService.doEnsureDefaultProjectForFile (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:130936:131)
    at ProjectService.ensureDefaultProjectForFile (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:130931:75)
    at IOSession.Session.getFileAndProjectWorker (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:134484:87)
    at IOSession.Session.getFileAndProject (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:134467:29)
    at IOSession.Session.getDiagnosticsWorker (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:134159:31)
    at IOSession.Session.getSyntacticDiagnosticsSync (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:134285:29)
    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:133672:61)
    at /home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:135162:88
    at IOSession.Session.executeWithRequestId (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:135153:28)
    at IOSession.Session.executeCommand (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:135162:33)
    at IOSession.Session.onMessage (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:135185:35)
    at Interface.<anonymous> (/home/mihdin/.emacs.d/.local/straight/repos/tide/tsserver/tsserver.js:136500:27)
    at Interface.emit (events.js:198:13)
    at Interface._onLine (readline.js:308:10)
    at Interface._normalWrite (readline.js:451:12)
    at Socket.ondata (readline.js:165:10)
    at Socket.emit (events.js:198:13)
    at addChunk (_stream_readable.js:288:12)
    at readableAddChunk (_stream_readable.js:269:11)
    at Socket.Readable.push (_stream_readable.js:224:10)
    at Pipe.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)

On the flip side, if you rename the bla/script file to bla/script.js and re-open it in emacs, then the language server is properly started and everything works as expected.
System information

```
emacs   version    27.0.50
        features   XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD PDUMPER LCMS2 GMP
        build      okt 20, 2019
        buildopts  (--build=x86_64-linux-gnu --prefix=/usr '--includedir=${prefix}/include' '--mandir=${prefix}/share/man' '--infodir=${prefix}/share/info' --sysconfdir=/etc --localstatedir=/var --disable-silent-rules '--libdir=${prefix}/lib/x86_64-linux-gnu' '--libexecdir=${prefix}/lib/x86_64-linux-gnu' --disable-maintainer-mode --disable-dependency-tracking --prefix=/usr --sharedstatedir=/var/lib --program-suffix=-snapshot --with-modules=yes --with-x=yes --with-x-toolkit=gtk3 --with-xwidgets=yes 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs-snapshot-FTRCy_/emacs-snapshot-98972=. -fstack-protector-strong -Wformat -Werror=format-security' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro')
        windowsys  x
        daemonp    server-running
doom    version    2.0.9
        build      HEAD -> develop, origin/develop, origin/HEAD fac6eabd7 2019-10-04 17:29:02 -0400
system  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /usr/bin/zsh
        uname      Linux 5.0.0-31-generic #33-Ubuntu SMP Mon Sep 30 18:51:59 UTC 2019 x86_64
        path       (~/.local/bin /snap/bin /usr/local/bin/ ~/.local/bin /snap/bin /usr/local/bin/ ~/.nvm/versions/node/v10.16.0/bin ~/.local/bin /snap/bin /usr/local/bin/ ~/.local/bin /usr/local/sbin /usr/local/bin /usr/sbin /usr/bin /sbin /bin /usr/games /usr/local/games /snap/bin ~/.local/share/fzf/bin /usr/lib/x86_64-linux-gnu/emacs/27.0.50/x86_64-linux-gnu/)
config  envfile    envvar-file
        elc-files  2
        modules    (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo modeline nav-flash ophints (popup +all +defaults) treemacs vc-gutter window-select workspaces :editor (evil +everywhere) file-templates fold (format +onsave) multiple-cursors rotate-text snippets :emacs dired electric vc :tools ansible docker eval flycheck (lookup +docsets) lsp magit pass :lang common-lisp data emacs-lisp (javascript +lsp) markdown (org +dragndrop +ipython +pandoc +present) python sh :config (default +bindings +smartparens))
        packages   (n/a)
        elpa       (n/a)
```

it does enable Javascript IDE mode

I cannot reproduce this. node in the shebang line is associated with js2-mode by the :lang javascript module. When I open the bin/script I get js2-mode, which is what lsp is bound to (Doom doesn't use js-mode).
Check the value of interpreter-mode-alist (SPC h v interpreter-mode-alist). Is ("node" . js2-mode) higher in the list than ("node" . js-mode) (or on the list at all)?

which apparently is an extension of the js2-mode

It's the other way around. js2-mode is an extension of js-mode.

Error: No Project.

This is standard operating procedure for the two available javascript LSP servers I'm aware of (typescript-language-server and typescript-language-server). If a JS file isn't in a valid project, LSP will not start.
However, it would be puzzling if the exact same file in the same location, but with a .js extension, successfully spawns an LSP server. It's possible that LSP caches project roots.
I also notice your example in lsp-problem.zip has no package.json file or .git directory. These are two of the main markers that the projectile.el package uses to determine a project's root. If LSP can't determine the project correctly, you will also get this issue.

HEAD -> develop, origin/develop, origin/HEAD fac6eabd7 2019-10-04 17:29:02 -0400

It looks like your version of Doom is roughly a month old. Quite a bit has changed, so I suggest you update. In particular, there were improvements to the LSP module. i.e. it will prompt you to select a project if none was found. It will also log the detected project root in *Messages*, which makes it easier to determine if it succeeded at doing so or not.

Thank you for your detailed reply. I updated Doom and now the major mode for bla/script (without any .js extension) is js2-mode, but lsp stil doesn't want to behave.
I ran git init as well as npm init in the folder that I attached earlier and lsp is still complaining that it can't find a project root.

However, it would be puzzling if the exact same file in the same location, but with a .js extension, successfully spawns an LSP server. It's possible that LSP caches project roots.

Having both bla/script and bla/script.js in the same project and opening the roof of the project, these are the messages logs for opening both files:
bla/script
Loading /home/mihdin/.emacs.d/.local/cache/recentf...done
Note: js2-basic-offset, tab-width, evil-shift-width adjusted to 2
Package cl is deprecated
LSP :: No LSP server for js2-mode(check *lsp-log*).
sort: Args out of range: [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground ...], 19

(can't find any lsp-log buffer...)
bla/script.js
Loading /home/mihdin/.emacs.d/.local/cache/recentf...done
Note: js2-basic-offset, tab-width, evil-shift-width adjusted to 2
Package cl is deprecated
LSP :: Guessed project root is /tmp/testtypescript/
LSP :: Connected to [ts-ls:30229 status:starting].
sort: Args out of range: [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground ...], 19
LSP :: ts-ls:30229 initialized successfully

This is the part that I don't really get. Here's the project with both files and .git and package.json files included in the root: lsp-problem-new.zip

After some digging, I've learned that the lsp-mode configuration for both javscript lsp clients check for a file extension, and will refuse to carry on if one doesn't exist. These are the offending lines.
I've temporarily included a temporary fix for it in Doom, but please bring this up to the lsp-mode guys. I'll leave this issue open until they have addressed it or explicitly refused to.

So I logged a bug to lsp-mode and it looks like it's already fixed. All you guys move super fast. I love it :D

Great! Thanks for letting me know!


MINOR: reduce amount of verbose printing

ping @xvrl @guozhangwang

retest this please

Thanks for the quick fix @enothereska ! I think most of them are actually from my previous PR..
LGTM and merged to trunk.


Protocol Service - Unregister option

Based on TODO https://github.com/hyperledger/aries-framework-go/compare/5839b0f509b0932a67abd562fb6a05dc181f2e08..5dfa12128f1ba2867b1a8c7c47464e6f9b8c5b7a#diff-f761c91e753eba1c42a68076df06ce12R135

This has been implemented in the same PR - https://github.com/hyperledger/aries-framework-go/pull/240/files#diff-f761c91e753eba1c42a68076df06ce12R153


[5.8][CI] Disable early swift driver/syntax on Linux presets

Allow Linux builds on a host with Swift installed. This will allow us to PR test enabling the early swift driver/syntax builds (once the Linux docker images are updated).
(cherry picked from commit e82d860af983a66fee61184b2eb92f02a5abf875)

@swift-ci please smoke test

@swift-ci please test


package:flutter/src/painting/image_resolution.dart':Failed assertion: line 136 pos 15:'assetName != null': is not true.

What should I do here? If you guys know anything please help me, thank you!
The following assertion was thrown building IntroScreen(dirty, dependencies: [MediaQuery], state: IntroScreenState#acd0a):
'package:flutter/src/painting/image_resolution.dart': Failed assertion: line 136 pos 15: 'assetName != null': is not true.

Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
  https://github.com/flutter/flutter/issues/new?template=BUG.md

The relevant error-causing widget was:
  IntroScreen file:///Users/wonderlabs/AndroidStudioProjects/clipstream/lib/screen/camera.dart:218:21
When the exception was thrown, this was the stack:
#2      new AssetImage (package:flutter/src/painting/image_resolution.dart:136:15)
#3      new Image.asset (package:flutter/src/widgets/image.dart:641:12)
#4      IntroScreenState.renderListCustomTabs (package:clipstream/Pages/intro_page.dart:163:32)
#5      IntroScreenState.build (package:clipstream/Pages/intro_page.dart:252:36)
#6      StatefulElement.build (package:flutter/src/widgets/framework.dart:4744:28)`

@driczX
It seems to be an issue with how you have imported assets in pubspec.yaml. You need to check if the name given is correct and you are using the same name in your dart code.
Please see https://flutter.dev/community for resources and asking questions like this.
you may also get some help if you post it on Stack Overflow and if you need help with your code, please see https://www.reddit.com/r/flutterhelp/
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


added files for users gmail sign/signup with firebase

Description
Gmail signup/signin by using firebase
Please provide a short summary explaining what this PR is about.
Fixes # (issue)
How to test?
sign up in the registration page, /registration
npm run dev
Please provide a short summary how your changes can be tested?
Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] This PR is ready to be merged and not breaking any other functionality

Please check the lint errors

HI @bytewiz  Niels, i checked it, i have two errors, and i have a doubt authRedirect function, if possible i want to clarify with you,

Please check the lint errors

HI @bytewiz Niels, i checked it, i have two errors, and i have a doubts about them and  authRedirect function, if possible i want to clarify with you,


Enable InlinePanel commenting

Is your proposal related to a problem?
When https://github.com/wagtail/wagtail/pull/9649 is merged, commenting on InlinePanels will be disabled. This is a feature that was never intended to be enabled without further development, so had a number of issues: child models that aren't yet saved to the database do not have a stable way to identify them at present, causing issues tracking which child model a comment is attached to across revisions.
Describe the solution you'd like
We should enable commenting on InlinePanels. This could be by either:

Allowing comment contentpaths to vary by revision, using the order of an InlinePanel as the identifying part of the contentpath for child models (so the contentpath would be relation_name.0 for the 0th instance), and updating it using the InlinePanel js when positions are changed. Downside: this is more fragile, especially when content is updated/reordered programatically.
Coming up with some unique identifier (such a a uuid) for child models that have not yet been saved to the database, and using that as the identifying part of the comment's contentpath

Additional context
https://github.com/wagtail/wagtail/issues/9641

A few thoughts

We could do a partial solution by only allowing comments on items already in the database (however, this would be super confusing for users)
We should, when re-enabling, either ensure we consider what will happen to comments already in the DB from when this feature used to work-(ish)

I'm interested in this issue. Please, assign me this issue.

@SyedImtiyaz-1 feel free to read through this issue, the comments and related work.
However, I think this is not good first issue as it will take a lot of understanding of both the commenting system and the InlinePanel system. Both of which are quite complex.
Nonetheless, if you feel confident giving it a go - I suggest you get started on some ideas and write a comment when you are ready to present a proposed solution. Or a draft PR.
As noted on other issues, we do not really assign specific tasks outside of the core team.
If you haven't already, maybe introduce yourself in the Slack channel #new-contributors ping me and we can say hi and see how to get you started with a good first issue.


Replace S3 API with Website endpoints to fix access denied redirect

Fixes #1
S3 API does not work with redirects, replaced it with Website endpoints.
Website endpoints works with HTTP only and does not support authorization.
Root bucket is now public.

I'm using that method in other websites, but I wanted to avoid it here as people can directly access the S3 bucket HTTP URL (for SEO purpose, to avoid duplicate content). The goal of using the S3 API endpoint was to avoid that. I'll dig if I find another solution, otherwise I'll merge your suggestion.

As multiple persons have the issue and as I don't know how to fix it yet using Lambda@Edge, I'm moving back from the S3 endpoint (REST API endpoint) to the S3 website endpoint for now. I need to adapt additional blocks/resources in the code though.


Why not use goroutines when dispatch callbacks?

I see in the implementation of epoll.wait() and kqueue.wait() you use a iterative way to execute all the callbacks, why not use goroutines to concurrently execute them for more effitiency? I'm just a little confused about it. If you don't think this is neccessary, please tell me why, I will be very thankful.

that's a good question.in my opinion, go-routine should be created in your own handler if you needed . Otherwise that will cause go-routine uncontrollable. you can make routine-pool to limit it's max num if you want or just simple use  go func() in callback.


Allow configuring a shorter context to allow a shorter completion.

The completion API sets a limit on the length of (input + output). The longer the context, the shorter the completion must be.
There's a balance between passing a lot of context to summarize and getting a long result.
It should be possible to configure that split in ask.
Originally noticed while thinking about #14

[ ] Allow setting answer_length in sample.client.
[ ] Allow setting prompt_length in sample.client (sometimes you don't want to use the entire prompt; it's more expensive)

Consider tiktoken to measure token length.


Can't use Chatterino in any way, can't even interact with the window

Describe the bug
When lauching, it opens the normal window, but only during 2-3 seconds, and can't interact with anything. It just closes itself with no error or warning. Already uninstalled completly and installed again (with Revo Uninstaller), reseting the cache and the old settings during install. Already checked the  VC++ 2017 Redistributable, it is installed properly too.
To reproduce
For me, just opening the program, even in admin mode. Nothing makes the program run.
Screenshots
No images, the program doesn't show anything
Chatterino version
From the Chatterino page, i downloaded the 2.2.2 version
Operating system
Windows 10 Home
Additional information
Already tried to install 2.2.1 and 2.2.0, either won't work too.

Can you please try the portable version, for example on your desktop?

Same behaviour, no difference at all.
Probably doesn't matter, but I'm on a laptop, MSI GL63 8SD.

Since we can't really help you I'll close this.


[CLI] Add download support back for older models

The CLI Reference shows how it was possible to download and run older models such as Llama 2 with the CLI, but with a recent commit, it isn't possible to download any model older than the Llama 3.1 family. Can we get support re-added for downloading older models like Llama 2, Code Llama, etc?
I've opened https://github.com/meta-llama/llama-models/issues/83 as well because it seems to be where models are being sourced from now.

Thanks for the suggestion! Addressed in https://github.com/meta-llama/llama-models/commit/3214718f53deec534b9529266e860e84dfb60d2f.


AVRO-2885: [Java] better check int vs float value

What is the purpose of the change
AVRO-2885 : check non int value on JsonDecoder (accept only real int or float value as 1.0, when conversion to int doesn't modify the value.
Verifying this change
One new unit test TestJsonDecoder.testIntWithError; to ensure that value -1.2 to read an int will throw an error.
Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

Indeed, with binary decoder, it sends an AvroTypeException,  "Found float, expecting int".
With this JIRA; it's also the case for json decoder. Float value 1.2 generate an error when trying to put it in an avro int field; while 1 or 1.0 json value will succeed to be translated in 1 int value.


Check v1beta3 description on git commit

v1beta3 is no longer a special little snowflake

@bgrant0607

lgtm

LGTM, thanks!