2.2.9 cannot scan barcodes (QR is fine)

I recently added ZXing to my xamarin.iOS project as could successfully scan QR codes (default settings, no options provided). However, i was completely unable to scan any type of 1D barcodes (EAN8, EAN18). I downgraded to 2.1.47, and using the same code, i can now scan both QR and 1D barcodes.
I tried providing options for 2.2.9, allowing only 1D barcodes as PossibleFormats, but the only result of that was being unable to scan QR codes as well as 1D barcodes

Ive updated to the latest nuget packages in all three projects (PCL, iOS and Droid) - 2.2.9 but only iOS is working.
Android is able to show the camera but the QR code is not getting detected whereby, the OnScanResult is never getting called.
Ive downgraded the packages and yet its still not scanning any QR code on Android.
Please, please can someone please help me?
Regards

I am using it in my Xamarin.Forms project and have similar issue.
The 1D barcodes do not scan at all. However, when I turn my phone to landscape mode, it scans.
Probably the iOS one is not processing 1D scans in portrait mode.
It seems to work fine on Android though.
It is a blocker and would be helpful if this can be resolved early. Thanks.

@hemantksh Any chance you can share your code? I would like to compare with what I've written? Im happy to share the code that I've got (its the same code on James's blog on the Xamarin website).
I tried both landscape and portrait but the code is not getting scanned. The android app shows the camera and I can the see QR code but nothing is happening.

Nothing fancy. Pretty straight. This is Xamarin.Forms.
`
var options = new ZXing.Mobile.MobileBarcodeScanningOptions();
        options.PossibleFormats = new List<ZXing.BarcodeFormat>() {
            ZXing.BarcodeFormat.CODE_39,
            ZXing.BarcodeFormat.CODE_93,
            ZXing.BarcodeFormat.CODE_128,
            ZXing.BarcodeFormat.EAN_13,
            ZXing.BarcodeFormat.QR_CODE
        };

        zxing = new ZXingScannerView
        {
            HorizontalOptions = LayoutOptions.FillAndExpand,
            VerticalOptions = LayoutOptions.FillAndExpand,
            Options = options
        };

        zxing.OnScanResult += (result) =>
        {
            Device.BeginInvokeOnMainThread(async () =>
            {
                zxing.IsAnalyzing = false;  // stop analysis
                g.LastScanResult = result;
                await Navigation.PopAsync(animated: false);  // close view
            });
        };

`

I noticed if I use the same code from FragmentActivity (in the sample code), the camera works nice but no QR Code detected.
If I use the sample code for using it with Activity, it works great. It seems it doesn't recognize anything when I use a Fragment / FragmentActivity.

Native project (Xamarin.iOS / Xamarin.Droid)
Nuget package version : 2.2.9
Android API level 18 (not tested above)
iOS : not tested yet

I've got the same problem.
Everything works fine on Android but there are some problems on iOS.
The iOS varient only recognises linear codes in landscape mode.
Someone found a workaround or a solution for this?

it is the same bug https://github.com/Redth/ZXing.Net.Mobile/issues/544

@hemantksh Any chance you can share your code?

@hareshkainth why didn´t you share your code in the first place. That would simply help out

@hemantksh and @ahmedalejo Sorry all, I got busy looking at the source code and was trying to figure out how to fix the issue.
Below is my code, note, it works on iOS but on Android it doesn't scan anything.
var scanPage = new ZXingScannerPage();
var options = new MobileBarcodeScanningOptions
{
AutoRotate = false,
UseFrontCameraIfAvailable = false,
TryHarder = true,
PossibleFormats = new List<ZXing.BarcodeFormat>
{
ZXing.BarcodeFormat.QR_CODE
}
};
scanPage = new ZXingScannerPage(options)
{
DefaultOverlayTopText = "Align code within the frame",
DefaultOverlayBottomText = string.Empty,
DefaultOverlayShowFlashButton = true
};
scanPage.OnScanResult += (result) =>
{
// Stop scanning
scanPage.IsScanning = false;
// Pop the page and show the result
Device.BeginInvokeOnMainThread(() =>

{
// Do something.
};
};

I downgraded to 2.1.47 because of this bug, but it seems that 1D barcodes still take an awfully long time to be detected, if at all. That's on my cheap Android device, I've not checked iOS yet.
Any chance of a comment from the author? Perhaps there's a functionality change that isn't documented yet?

Hello, same problem, IOS does not analyzing in portrait mode, when I rotate 1D code vertically it get read. Pls help.

@pdonovan  The long time problem should be affected by the device. version 2.1.47 works fine for me. The author seems that does not review the issues on this project.

Its working in Landscape mode not portrait(iOS). how to fix it in Portrait mode?

Not working here either in portrait mode ... have downgraded to 2.1.47, which is working :-(

same story here 2.1.47 is the solution for now

wrote direct message to @Redth twitter (@redth), hope that he fix this issue asap

I've downgraded the plugin to version 2.1.47 for Android and I can confirm that my Android app can scan QR codes again.

Hi,
I downgraded to 2.1.47 and portrait mode is working. @kentfonager  Thanks man its working fine and my customOverlay not displaying. How to fix it ?

@shanmugasundharamselvadurai
The binding context of the ZXingDefaultOverlay  view was never set, so you will not see any your UI changes on it...
current solution of problem for me now is declaring ZXingDefaultOverlay  in behind code (or in viewmodel) and then we need to set BindingContext for the declared ZXingDefaultOverlay  to itself

Hi,
Seems like I have similar problems.
iOS 11, iPhone 7. Can scan QR-codes with no problems. But ean13 I only can scan if the code is vertical - not horizontal like I want! Look at images. Why why why??

Thanks for reporting this issue!  Unforunately it took me way too long to respond 😭.  Sorry, I apologize!  Recently the source code for this project was completely refactored to modernize it.  Many PR's were included in this effort, and many bugs were hopefully fixed.  Please try out the latest 3.x series of NuGet packages (currently in prerelease).  To try and make the project more maintainable in my spare time going forward, I've decided to close all existing issues to start with a clean slate.  If you're still experiencing this issue on the newest version, please open a new issue with as much detail as possible.  Thank you for your patience and understanding!  Happy scanning!

@hemantksh and @ahmedalejo Sorry all, I got busy looking at the source code and was trying to figure out how to fix the issue.
Below is my code, note, it works on iOS but on Android it doesn't scan anything.
var scanPage = new ZXingScannerPage(); var options = new MobileBarcodeScanningOptions { AutoRotate = false, UseFrontCameraIfAvailable = false, TryHarder = true, PossibleFormats = new List<ZXing.BarcodeFormat> { ZXing.BarcodeFormat.QR_CODE } };
scanPage = new ZXingScannerPage(options) { DefaultOverlayTopText = "Align code within the frame", DefaultOverlayBottomText = string.Empty, DefaultOverlayShowFlashButton = true };
scanPage.OnScanResult += (result) => { // Stop scanning scanPage.IsScanning = false;
// Pop the page and show the result
Device.BeginInvokeOnMainThread(() =>

{ // Do something. }; };
dear I used zxing in web it open camera scan from camera webcam but not scan from camera of mobile, what I have to do to make it scan from the mobile of tye phone


Run post commit CQ tests on LUCI as part of pre-commit

Currently this is achieved by adding "CQ+1" label to the PR. We wish to make it the default behavior for all the pull requests.
Requirements:

All pull requests should run the post commit tests as part of precommit. Since these have some Fuchsia tests and iOS tests that are not run as precommits.
No longer have the label CQ+1 as all tests are CQ+1.

cc: @cbracken , @dnfield

The only reason I had it this way was for capacity purposes.  We could change this pretty easily if we'r enot worried about capacity anymore.

@dnfield lets change it. If capacity becomes a bottleneck we can revert back to the old behavior.

@dnfield assigning it to you. It would be great if you can add me to the CL -- i'd like to know how this stuff is configured.

It's likely I won't be able to get to this until later in December or early January.  If that doesn't work we may want to find someone else.

I believe @godofredoc is working on this - see https://github.com/flutter/cocoon/pull/572

Woohooo!! Thanks @godofredoc !!

This will require a little bit more work. I fixed a NPE but still need to work on the pubsub topic.

I'm adding the capacity to enable running pre-commit tests.


Add DevelocityBuildLifecycleService

to expose a stable API to run some code for all projects.

The merge queue build has started. Click here to see all failures if any.


Can't allocate ordinary RAM and know its address

For passthrough devices to a VM, in the absence of an IO MMU, the guest Linux needs to know the physical addresses of its RAM so it can properly set up DMA.
In the examples so far, we've allocated at a fixed address, and tweaked the seL4 device tree to make the RAM at that address invisible to the kernel (so it is allocated as device-untyped).
That doesn't scale: it requires rebuilding the seL4 kernel and microkit tool for every new case.
Alternative solutions could be:

Allow a 1:1 mapping option when allocating normal RAM.  The VMM would then  have to adjust the device tree handed to the guest to reflect the actual RAM allocation (this could be done at build time, as the microkit tool outputs the actual addresses in the report file).  If you could do 'vaddr = paddr' in the virtual_machine clause it'd do the trick
When allocating a chunk with fixed address, if it's a normal (as opposed to device) memory region, just remove that region from the normal memory region (free space)  in the tool before regions where the address is not assigned are allocated.This requires the system designer to keep track of all memory when building the system XML file, and means that several places need updating every time one wants to change, e.g., the amount of RAM given to a guest.
Something else I haven't thought of.

So I tried a naive implementation of 2. above --- by marking real memory as device early on --- but it fails at run time because the list of caps from the kernel bootinfo doesn't match the calculated one.  Needs to be a but smarter...


Update README.md

Why I deleted Game Development section? Because most if not all BASIC could be used for this purpose, not only Cerberus X. The list already has many BASIC dialects specially designed for game development though, e.g: Dark Basic Pro, BlitzMax,... It's difficult to tell which should be on the Game Development section, which not. So, just abolish the Game Development section altogether.
Why I moved some BASIC compilers/translators from IDEs, Editors, Plugins, and Tools back to Dialects? Because most BASIC compilers/translators have their own dialects! For example, BCX is a BASIC translator, but it has it own BASIC dialect. The same is true for BaCon. Unless it's too clear that the tool is just a compiler/translator of an already known dialect like mono-basic to Visual Basic .NET, I think it's better to keep them on the Dialects section. I also think the Dialects list should be sorted alphabetically.

@JohnBlood

Looks good. Merging.


The “Error” popup is displayed after entering the valid mnemonic

Description
The “Error” popup is displayed after entering the valid mnemonic
Preconditions:

The site is opened

Steps to reproduce:

Click the “Already have a wallet?” button
Enter the mnemonic from the email:
mnemonic: hair cake region defense purchase paddle roof phone viable crack soon spot
email<EMAIL_ADDRESS>Click the “RECOVER MY WALLET” button

Actual result: The “Error” popup is displayed after entering the valid mnemonic
Expected result: The “Home” page is displayed after entering the valid mnemonic
Supporting data
Env https://goodqa.netlify.com
iPhone6 12.3.1, Safari
https://www.screencast.com/t/NbJLTpprhx

was able to reproduce once, but not again.
somehow the gundb username with same mnemonic came out different so it doesnt find the username
couldn't reproduce it after that first time.
@dariominones @kbardi @fernandomg can you try to reproduce this?

Checked on https://goodqa.netlify.com/
iPhone6 12.3.1, Safari
It still reproduced differently
https://www.screencast.com/t/u9PRHloP2
https://www.screencast.com/t/HjgfVah4Bxf
https://www.screencast.com/t/MhTYWiF4

@qatests1001
hmm can't really reproduce it
had no problem restoring
artefact inform asset swim music room kingdom noise pill width length raw
can you try to give exact steps on how to get an error?

@sirpy Reproduced after tapping more than 1 time on the "Recover" button
There was no "Loading" on the top of the screen - tapped twice on videos above
https://www.screencast.com/t/kAlx4hDTkGbn

ok this makes  sense, yes we need to disable the button.

Checked on https://goodqa.netlify.com
Still reproduced after double-tapping
https://www.screencast.com/t/tWySVab1

#330 fixed here wasn't merged yet.
should be ready for tomorrow

Checked on https://goodqa.netlify.com/
Fixed
https://www.screencast.com/t/hjDoibxTtbW

Checked on https://goodqa.netlify.com
Reproduced after double-tapping
https://www.screencast.com/t/leWlgaMWlaT

Checked on https://gooddev.netlify.com
iPhone X // iOS 12.4 Safari
The bug is reproduced
https://www.screencast.com/t/uHHZjbFW

@yaroslav-fedyshyn-nordwhale

@AnastasiiaOdnoshevna @sirpy I guess I found where is the problem. Trying to solve it.

Checked on https://gooddev.netlify.com
iPhone X // iOS 12.4 Safari
Fixed
https://www.screencast.com/t/Hwat5mqx


GSSoC'24: Flappy Bird Game using Face Detection

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like.
It is my implementation of flappy bird game which uses Python with packages OpenCV, and mediapipe. It belongs in Artificial_Intelligence/Basic section for using face detection.
Describe alternatives you've considered.
The following website consists of the demo: https://ml-integrations.onrender.com/
Instagram Filters -> Flappy Bird
The website is hosted on a free hosting server, so it may take 5-10 min to load initially. Furthermore, the rendering of the frames will be slow due to limited processing power of the free server.
I only aim to add the Python functionality and not the web integration.
Add any other context or screenshots about the feature request here.
No response

Steps I will be performing:

I will set up a development environment and install the necessary libraries like MediaPipe and a game development framework like Pygame.

I'll use MediaPipe to detect face movements or gestures to control the game, while also implementing the game mechanics such as the bird's movement and obstacles.

i’ll Implement the game logic, including collision detection between the bird and the pipes, scoring, and game over conditions.

I will be providing feedback to the player based on their face movements. For instance, you could display instructions or feedback on the screen based on how the player is moving their face.

It's a challenging project, but definitely doable with some coding skills and patience!
Why me?
I am GSSOC'24 Contributor With deep expertise in CNNs and computer vision, I am well-suited for this project. My experience encompasses theoretical understanding and practical application, as demonstrated by presentations and project work. Recently I contributed to a startup where my role centered around the areas of computer vision (image recognition, object detection and pose estimation) and large language models (hallucination mitigation, access control, RAG, fine-tuning, knowledge graphs, dynamic policy enforcement) making me confident in contributing effectively to this endeavor.

There will be many more tasks i'll implement here including Refinement, Optimisation, Deployment etc.
Please assign me this task and allow me to put a label of GSsoC24 in it.


Add Ankit's GSoC Final Report

@agriyakhetarpal @arjxn-py This is ready for merging. Thanks!

I promise the rest of the content is fine 🤞

Sorry, I didn't know you were reviewing, @arjxn-py! I merged it early in the interest of time, since we are (were) quite close to the deadline.

Totally no worries @agriyakhetarpal


ORG_ID in Anax configuration doucment

When the hub was set-up, a number of environment variables were set and persisted in $HOME/.bashrc. Therefore, is the step of setting up the environment variables in hub/04-configure-anax.md required?
The ORG_ID is set-up with the same value as HZN_ORG_ID. Also, the ORG_ID does not appear in the list of environment variables set-up and persisted when setting up the hub. So, what is the purpose of ORG_ID?

Yes.  The assumption is that the env vars persisted in the Hub Services setup are on a separate machine from the Anax service, hence both require env vars to be persisted.
I'm not sure.  Mosquito should know.  Let's ask him.

Joseph "Joe" Pearson

----- Original message -----From: haveroot<EMAIL_ADDRESS>edgexfoundry-holding/open-horizon-integration<EMAIL_ADDRESS>Subscribed<EMAIL_ADDRESS>[EXTERNAL] [edgexfoundry-holding/open-horizon-integration] ORG_ID in Anax configuration doucment (#34)Date: Sun, Mar 15, 2020 1:18 AM

When the hub was set-up, a number of environment variables were set and persisted in $HOME/.bashrc. Therefore, is the step of setting up the environment variables in hub/04-configure-anax.md required?        The ORG_ID is set-up with the same value as HZN_ORG_ID. Also, the ORG_ID does not appear in the list of environment variables set-up and persisted when setting up the hub. So, what is the purpose of ORG_ID?
—You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.

I need some more context to understand this question:

What task are you trying to perform?
What instructions are you following?
Where is this ORG_ID variable coming from?
I don't think there is any requirement to "persist" variables in ~/.bashrc (I never do this).


Add tray support to the application

This commit adds simple tray support to Ongaku. Clicking the close
button or the tray icon will hide the application. If hidden clicking
the tray icon will restore the application. The application can be
exited via the quit menu item.
This also adds templates for an app icon as one was needed to show the
tray icon.
Fixes #12

Thanks for the PR @coderjoe! 😄
Everything's perfect and in place! 👍
Just one minor thing that I'd prefer, can you create a separate tray.js file for handling tray operations, please? Also, add one more object in the context menu about Toggle show/hide if possible.

@anshumanv I've updated my code with your suggestions. Please let me know what you think.

Hey, @coderjoe thanks so much for the fix, everything's perfect and in place. 😄
Expecting more such quality PRs from you. 😆


Test runner crashes with VSTS Build

Description
I have a build which runs tests on several projects (9) that fails with the following message:
The active test run was aborted. Reason: Unable to write data to the transport connection: An existing connection was forcibly closed by the remote host.
Steps to reproduce
Run build on VSTS with several projects
"C:\Program Files\dotnet\dotnet.exe" test d:\a\1\s\tests\DependencyInjection.Core.UnitTests\DependencyInjection.Core.UnitTests.csproj -l trx;LogFileName=TestResults.trx
NetCoreApp 1.1
Expected behavior
Tests run and produce report on VSTS build
Actual behavior
Tests crach and hang with the above message
Environment
VSTS Build

@martincostello : Are you able to run this test on your local machine??
What is the version of dotnet you are using? I am interested in output of below two command
"C:\Program Files\dotnet\dotnet.exe" --info
"C:\Program Files\dotnet\dotnet.exe"  vstest --help

The second command will give a long output. Please provide us first 3 or 4 line of the result which will look similar to
Microsoft (R) Test Execution Command Line Tool Version 15.3.0-preview-20170502-03
Copyright (c) Microsoft Corporation.  All rights reserved.

I think you meant @martinfletcher.

@martincostello : Yes you are right. Thank you :)

Yes, these run fine locally. The issue is on the hosted build agent on vsts. I have spoken to a support engineer today via phone and he seems to think that the issue is with performance of the vsts hosted agent.

@martinfletcher : Ok.. let us know if something come from vsts hosted agent team.

Ok, so the issue is with the hosted agent.
After a long time on the phone with a support engineer, and after setting up a private agent to test on the problem seems to have been pinpointed.
Currently, the latest version of visual studio 2017 is 15.2. The hosted agents are running 15.1, and any project created with 15.2 does not work with the test agent.
I installed the agent tools on a machine with latest visual studio and setup as a private agent and builds worked fine. Just will not work on hosted agent with vs2017.
Hopefully this will be resolved soon, as we are now limited to just 240 build minutes for private agents if we want to run unit tests in our builds -far from acceptable!
If anyone knows who the right person to contact regarding the hosted agents, please send them my way or let me know so that I can contact them and get some kind of timeframe for when the hosted agents will be upgraded to 15.2.
Hope this puts anyone else having this issue at ease was it's not very obvious at all.

@nigurr  can help on test agent issue.
@martinfletcher what is the type of project(language, target framework etc) for which you are seeing the issue?

They are c# net standard 1.4 and 1.6

@martinfletcher @Faizan2304 I believe you meant "Running tests under hosted pool is failing"?

@nigurr Yes hosted 2017

@nigurr : did you get a chance to look into it?

@Faizan2304, This is nothing to do with Test Agent. This is purely vstest.console.exe in Hosted Pools.
If you need more info on Hosted Pool versions, I can share with you. But the issue seems to be vstest.console.exe issue as it's unable to run the tests of newer VS version

@Faizan2304 @DarqueWarrior Any ideas when vstset.console.exe will support VS2017 (15.2)?

@martinfletcher : Are u still facing the issue or it has been resolved?
If you are still facing the issue can you please share the repro project which I can use to create a local repro.

@Faizan2304 Yes. I can not share the project as its not OS.

@martinfletcher: Ok.
What is the target framework version of test project and product code for which you are facing the problem.

target framework is net standard 1.4, vs version is  VS 2017 Enterprise 15.2 (26430.6)

Test project with net standard as targetframework is not a supported scenario. Test project can have targetframework as netcoreapp (eg: netcoreapp1.0, netcoreapp2.0 etc) and .net framework (eg: net46 etc).
Will it be possible for you to collect log and share with us.
To collect log

run dotnet test with argument --diag vstestLogFile.txt
Add a Publish build artifact task in your build definition.
In Publish build artifact task publish all file with pattern `**/vstestLogFile.txt
Share with us all vstestLogFile.txt file

@Faizan2304 Appologies, the test project is targeting netcoreapp1.1. The project being tested is netstandard1.4

@martinfletcher Thanks for confirming. Please collect the log and share with us. It will help us to root cause the issue. Ideally project created in VS 15.2 should run in VS 15.1

@Faizan2304 That is the issue, the build never stops, not even after timeout period. Therefore, the logs never get generated.

@martinfletcher My assumption is that VS 15.1 doesn't have netcoreapp1.1 runtime installed. If you will change your test code to target netcoreapp1.0, I believe everything will work fine.

@Faizan2304 right OK i will try that. Any idea when 15.2 will be supported?

@Faizan2304 That is the issue, the build never stops, not even after timeout period. Therefore, the logs never get generated.

Its seems something wrong with those machine. Doesn't seems issue with vstest.

@Faizan2304 right OK i will try that. Any idea when 15.2 will be supported?

I don't know when they will update machine to 15.2. I don't know whom to contact for this.

hey @martinfletcher, as it doesn't seems problem with vstest but with hosted agent. I am closing issue here. Please revert back if u have any concern of query.


[ConstraintSystem] Record produced types incrementally

Allow type variable binding producer to record types as they
are being produced. Otherwise it could be possible to re-discover
already explored types during computeNext() which leads to
duplicate bindings e.g. inferring fallback Void for a closure
result type when Void was already inferred as a direct/transitive
binding.

@swift-ci please smoke test


ci: add toolchain id to cra-config

Description
add toolchain id to cra-config since this repo tests run in different account
Release required?

[x] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

@huayuenh @padraic-edwards Its now supported to add your toolchain ID here instead of the hack we had to add using a repo level secret. Need to know the toolchain ID in order to add to this PR

/run pipeline

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


#6156 Add external property support

web : -Dpinpoint.web.config.location=YOUR_PROPERTY_PATH
collector : -Dpinpoint.collector.config.location=YOUR_PROPERTY_PATH

Codecov Report

Merging #6188 into master will increase coverage by <.01%.
The diff coverage is 38.46%.

@@            Coverage Diff             @@
##           master    #6188      +/-   ##
==========================================
+ Coverage   39.67%   39.67%   +<.01%
==========================================
  Files        3032     3032
  Lines       91205    91214       +9
  Branches    11859    11859
==========================================
+ Hits        36184    36189       +5
- Misses      52015    52016       +1
- Partials     3006     3009       +3

Impacted Files
Coverage Δ

...rp/pinpoint/common/server/config/LoggingEvent.java
83.33% <ø> (ø)

...tor/config/GrpcAgentDataReceiverConfiguration.java
82.6% <ø> (ø)
:arrow_up:

...nt/collector/config/StatReceiverConfiguration.java
90% <ø> (ø)
:arrow_up:

...ctor/config/GrpcPropertiesServerOptionBuilder.java
100% <ø> (ø)
:arrow_up:

...tor/config/AgentBaseDataReceiverConfiguration.java
100% <ø> (ø)
:arrow_up:

...nt/collector/config/SpanReceiverConfiguration.java
92% <ø> (ø)
:arrow_up:

...point/collector/config/CollectorConfiguration.java
36.73% <ø> (ø)
:arrow_up:

...ollector/config/GrpcSpanReceiverConfiguration.java
83.87% <ø> (ø)
:arrow_up:

.../pinpoint/collector/config/FlinkConfiguration.java
0% <ø> (ø)
:arrow_up:

...npoint/common/server/config/AnnotationVisitor.java
100% <ø> (ø)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ab288...7c2c2d9. Read the comment docs.


Adding ClientFactory abstraction to allow alternate JAXRS implementations to be used

We use RESTEasy in most of our applications/tooling and because the docker client currently uses the standard JAXRS client api it's hard to control which implementation gets used and it's impossible to customize the client if Resteasy gets picked.  I've tested it with both Jersey and RESTEasy (not included) implementations and everything seems to work.
I also switched the JerseyClientFactory to directly use the JerseyClientBuilder so that it'll still use Jersey even if there's an alternate JAXRS implementation on the classpath.

Current coverage is 35.78%

Merging #340 into master will increase coverage by +0.07% as of f540f50

@@            master    #340   diff @@
======================================
  Files           65      66     +1
  Stmts         3144    3152     +8
  Branches       761     762     +1
  Methods          0       0
======================================
+ Hit           1123    1128     +5
- Partial        109     110     +1
- Missed        1912    1914     +2

Review entire Coverage Diff as of f540f50

Powered by Codecov. Updated on successful CI builds.

Great work! The PR looks quite good. There are a few remarks from my side (as a contributor, not maintainer).
It seems the code is still dependent on org.glassfish.hk2.api.MultiException and org.glassfish.jersey.internal.util.Base64. Besides that this implied that (at least some) glassfish dependencies are still required on the classpath, I think that exceptions may not be handled properly when another HttpClient implementation is used.
I would love to see a few additions:

Add resteasy-client (and its Jackson companion) as an optional and provided dependency:

<dependency>
	<groupId>org.jboss.resteasy</groupId>
	<artifactId>resteasy-client</artifactId>
	<version>3.0.16.Final</version>
	<scope>provided</scope>
	<optional>true</optional>
</dependency>

(In fact, this should also be done with the glassfish dependencies in my opinion, but that would be a breaking change for existing users, so lets stick to adding that as <exclusion> for now)

Alter the intergration tests in such as way (either through test class inheritance or for example JUnit theories or parameterized) that the same tests are ran for both the glassfish and resteasy-client. This would address my concern that some exception handling (or for example any timeout vs. non-timeout issues) are not working properly.
Some example usage of how to use another HttpClient can be used and specifically how the resteasy-client should be configured in practice would be nice!

ping @grexe

I can add the optional dependencies but I'm not sure if it really adds much value since the user still has to add those dependencies themselves anyway. Unless you're going to fully support multiple JAXRS implementations I'm not sure how much value there is in kinda-sorta supporting it. I mainly wanted to clear the roadblock preventing usage of anything else.
If you want to full on support multiple implementations I think ideally there should be a few more breaking changes like extracting the dependencies and factories into separate modules.
I'm happy to add an example usage of using RESTEasy with this, should that go in user_manual.md?

The dependencies should be included anyway in order to be able to test the Resteasy client. My opinion is still that this should be tested properly, including timeout and exception behaviour. So I would like to see the integration tests to be ran on both client implementations.
The optional inclusion would mostly be a cosmetic feature indicating it can be used with other clients.

fair enough, I'll make that change today.

Allright. I can have a look on Thursday to maybe add some tests if you'd like :)

I added the ResteasyClientFactory implementation as well as deps + docs. It turned out there was a few of the features that we were using (streaming stuff in particular) that was a bit of a pain to get working in RESTEasy but the integration tests are passing now. The Events stuff currently directly relies on jersey so it would be more difficult to get working so I just left it for now and documented that fact.

Whoa, great work! Will defenitely start using our fork 😄  Any idea on the last failing test case?

Tests in error:
testEventStreamWithUntilTimeresteasy: The supplied component "org.jboss.resteasy.client.jaxrs.ResteasyClient" is not assignable from JerseyClient or JerseyWebTarget.

that last test was failing because the events stuff doesn't work with resteasy so I needed to add
assumeThat(sut.getClient(), not(instanceOf(ResteasyClient.class)));
to all of those tests and missed one. Should be good now.

Great! Waiting on response from the maintainers then.

On 04 May 2016, at 17:32, Jeff Skjonsby <notifications<EMAIL_ADDRESS>wrote:
that last test was failing because the events stuff doesn't work with resteasy so I needed to add
assumeThat(sut.getClient(), not(instanceOf(ResteasyClient.class)));
to all of those tests and missed one. Should be good now.
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHubhttps://github.com/spotify/docker-client/pull/340#issuecomment-216903260

That test failure on 1.10.3 is caused by the same problem as #412. That issue (or at least the test that failed because of the issue) was fixed in #415. Rebase this PR on master and that issue should go away.

+1

Any updates on this?

I haven't had time to keep the branch up to date with master and I haven't heard anything from the maintainers so it appears this isn't a priority or not a direction the maintainers want to go it. We're still internally using this branch so it still works.

I am having trouble to use the library under Glassfish / Payara due to Jersey conflicts - this might be the solution.

+1, i'd like to use CXF and JSONB instead of jackson, using portable API is really important


NoMethodError: undefined method rvm_environment for #Chef::Provider::Package::RVMRubygems:0x00000000ece280

I am getting this error with chef-client 12.0.0.
Existing setup was working just fine.  Until we tried a new vagrant setup that bootstrapped with the latest chef-client 12.0.0. That errored out with NoMethodError: undefined method `rvm_environment' for #Chef::Provider::Package::RVMRubygems:0x00000000ece280.
After I forced the vagrant process to version 11.16.4-1, it again worked without this error.
I didn't see anything that would suggest this problem in the release notes for this version but perhaps I missed something.
Any help is greatly appreciated.
Here is the entire error output:
==> default: [2014-12-08T16:47:12+00:00] WARN: Current  rvm_gem[bundler]: /var/chef/cache/cookbooks/rvm/providers/global_gem.rb:48:in `gem_package_wrapper'
==> default:
==> default: ================================================================================
==> default: Error executing action `install` on resource 'rvm_gem[bundler]'
==> default: ================================================================================
==> default:
==> default: NoMethodError
==> default: -------------
==> default: undefined method `rvm_environment' for #<Chef::Provider::Package::RVMRubygems:0x00000000ece280>
==> default:
==> default:
==> default: Cookbook Trace:
==> default: ---------------
==> default: /var/chef/cache/cookbooks/rvm/libraries/rvm_rubygems_package.rb:129:in `block in install_package'
==> default:
==> default: /var/chef/cache/cookbooks/rvm/libraries/rvm_rubygems_package.rb:127:in `each'
==> default: /var/chef/cache/cookbooks/rvm/libraries/rvm_rubygems_package.rb:127:in `install_package'
==> default: /var/chef/cache/cookbooks/rvm/providers/global_gem.rb:57:in `gem_package_wrapper'
==> default: /var/chef/cache/cookbooks/rvm/providers/global_gem.rb:35:in `block (3 levels) in class_from_file'
==> default: /var/chef/cache/cookbooks/rvm/providers/global_gem.rb:34:in `each'
==> default: /var/chef/cache/cookbooks/rvm/providers/global_gem.rb:34:in `block (2 levels) in class_from_file'
==> default:
==> default:
==> default:
==> default: Resource Declaration:
==> default: ---------------------
==> default: # In /var/chef/cache/cookbooks/rvm/providers/global_gem.rb
==> default:
==> default:  48:   g = rvm_gem new_resource.package_name do
==> default:
==> default:  49:     ruby_string ruby_global_gemset
==> default:
==> default:  50:     source      new_resource.source if new_resource.source
==> default:  51:     options     new_resource.options if new_resource.options
==> default:  52:     version     new_resource.version if new_resource.version
==> default:  53:     gem_binary  new_resource.gem_binary if new_resource.gem_binary
==> default:  54:     user        new_resource.user
==> default:  55:     action      :nothing
==> default:
==> default:  56:   end
==> default:
==> default:  57:   g.run_action(exec_action)
==> default:
==> default: Compiled Resource:
==> default: ------------------
==> default: # Declared in /var/chef/cache/cookbooks/rvm/providers/global_gem.rb:48:in `gem_package_wrapper'
==> default:
==> default:
==> default: rvm_gem("bundler") do
==> default:   provider Chef::Provider::Package::RVMRubygems
==> default:   action [:nothing]
==> default:   retries 0
==> default:   retry_delay 2
==> default:
==> default:   default_guard_interpreter :default
==> default:   cookbook_name "rvm"
==> default:   ruby_string "ruby-2.1.1@global"
==> default:   user "vagrant"
==> default:   version "1.6.2"
==> default:   gem_binary "gem"
==> default:
==> default:   package_name "bundler"
==> default: end
==> default:
==> default:
==> default:
==> default:
==> default: ================================================================================
==> default: Error executing action `install` on resource 'rvm_global_gem[bundler]'
==> default: ================================================================================
==> default:
==> default:
==> default: NoMethodError
==> default: -------------
==> default: rvm_gem[bundler] (/var/chef/cache/cookbooks/rvm/providers/global_gem.rb line 48) had an error: NoMethodError: undefined method `rvm_environment' for #<Chef::Provider::Package::RVMRubygems:0x00000000ece280>
==> default:
==> default: Cookbook Trace:
==> default: ---------------
==> default: /var/chef/cache/cookbooks/rvm/libraries/rvm_rubygems_package.rb:129:in `block in install_package'
==> default: /var/chef/cache/cookbooks/rvm/libraries/rvm_rubygems_package.rb:127:in `each'
==> default: /var/chef/cache/cookbooks/rvm/libraries/rvm_rubygems_package.rb:127:in `install_package'
==> default: /var/chef/cache/cookbooks/rvm/providers/global_gem.rb:57:in `gem_package_wrapper'
==> default:
==> default: /var/chef/cache/cookbooks/rvm/providers/global_gem.rb:35:in `block (3 levels) in class_from_file'
==> default: /var/chef/cache/cookbooks/rvm/providers/global_gem.rb:34:in `each'
==> default: /var/chef/cache/cookbooks/rvm/providers/global_gem.rb:34:in `block (2 levels) in class_from_file'
==> default:
==> default: Resource Declaration:
==> default: ---------------------
==> default: # In /var/chef/cache/cookbooks/rvm/libraries/chef_rvm_recipe_helpers.rb
==> default:
==> default: 191:           rvm_global_gem gem[:name] do
==> default: 192:             user      opts[:user]
==> default:
==> default: 193:             [:version, :action, :options, :source].each do |attr|
==> default: 194:               send(attr, gem[attr]) if gem[attr]
==> default: 195:             end
==> default: 196:           end
==> default: 197:         end
==> default:
==> default:
==> default:
==> default: Compiled Resource:
==> default: ------------------
==> default: # Declared in /var/chef/cache/cookbooks/rvm/libraries/chef_rvm_recipe_helpers.rb:191:in `block in install_rubies'
==> default:
==> default:
==> default: rvm_global_gem("bundler") do
==> default:   action :install
==> default:   retries 0
==> default:   retry_delay 2
==> default:   default_guard_interpreter :default
==> default:
==> default:   cookbook_name "rvm"
==> default:   recipe_name "user"
==> default:   user "vagrant"
==> default:   package_name "bundler"
==> default: end
==> default:
==> default:
==> default:
==> default: [2014-12-08T16:47:14+00:00] INFO: Running queued delayed notifications before re-raising exception
==> default: [2014-12-08T16:47:14+00:00] ERROR: Running exception handlers
==> default: [2014-12-08T16:47:14+00:00] ERROR: Exception handlers complete
==> default: [2014-12-08T16:47:14+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
==> default: [2014-12-08T16:47:14+00:00] INFO: Sending resource update report (run-id: 02293aaf-dd56-4eb5-9da8-1052881199f8)
==> default: [2014-12-08T16:47:14+00:00] ERROR: rvm_global_gem[bundler] (rvm::user line 191) had an error: NoMethodError: rvm_gem[bundler] (/var/chef/cache/cookbooks/rvm/providers/global_gem.rb line 48) had an error: NoMethodError: undefined method `rvm_environment' for #<Chef::Provider::Package::RVMRubygems:0x00000000ece280>
==> default: [2014-12-08T16:47:15+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

@martinisoft, @nomadium  has confirmed that it will not break Chef 11 support in the PR.
It would be great to have the PR merged.

@akshah123 I'll look at merging the change today.

is this merged yet?

@mmahalwy Yes, it was merged recently.

Just ran into this issue and I was curious if there was any plan to cut a release with the fix? Obviously I am late to the chef 12 party, but it would be awesome to consume a tagged version of the cookbook :smiley:

And is there a Chef 12 fix yet, or just Chef 11?

Yeah, I just got burned by this too. It sounds from this thread like there's a fix but the cookbook hasn't been released for a while; is a release planned?

@martinisoft, as soon as master has some more issues, are you planning to release the patch for this issue to Chef Supermarket?

Is there a plan to release it on supermarket?

up, I need this fix!

what is best practice until the issue is fixed?

i am getting a below error, but sure if i am also being hit by the same bug. The version is Chef: 12.3.0

update content in file /etc/rvmrc from b7a449 to 57f6fe
--- /etc/rvmrc	2015-05-04 21:59:37.369581808 -0700
+++ /tmp/chef-rendered-template20150504-31986-zrq8o0	2015-05-04 22:23:31.064638259 -0700
@@ -6,5 +6,4 @@
export rvm_path="/opt/mount1/rvm"
export rvm_gem_options="--no-rdoc --no-ri"
-umask u=rwx,g=rwx,o=rx
- change mode from '0664' to '0644'

execute[install system-wide RVM] action run (skipped due to not_if)

execute[upgrade system-wide RVM to none] action run (skipped due to not_if)
Recipe: rvm::system

rvm_ruby[ruby-2.1.1] action install/home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/rvm_chef_user_environment.rb:32: warning: class variable access from toplevel
(up to date)

rvm_default_ruby[system] action create/home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/rvm_chef_user_environment.rb:32: warning: class variable access from toplevel
(up to date)

rvm_global_gem[bundler] action install/home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/rvm_chef_user_environment.rb:32: warning: class variable access from toplevel

execute[Add bundler to /opt/mount1/rvm/gemsets/global.gems] action run (skipped due to not_if)
[2015-05-04T22:23:32-07:00] WARN: Cloning resource attributes for rvm_gem[bundler] from prior resource (CHEF-3694)
[2015-05-04T22:23:32-07:00] WARN: Previous rvm_gem[bundler]: /home/ec2-user/chef-solo/cookbooks-2/123hp_jenkins/recipes/rubies.rb:4:in from_file' [2015-05-04T22:23:32-07:00] WARN: Current  rvm_gem[bundler]: /home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb:48:in gem_package_wrapper'

rvm_gem[bundler] action install
================================================================================
Error executing action install on resource 'rvm_gem[bundler]'
NoMethodError
undefined method `rvm_environment' for #Chef::Provider::Package::RVMRubygems:0x00000008d52610
Cookbook Trace:
/home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/rvm_rubygems_package.rb:129:in block in install_package' /home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/rvm_rubygems_package.rb:127:in each'
/home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/rvm_rubygems_package.rb:127:in install_package' /home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb:57:in gem_package_wrapper'
/home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb:35:in block (3 levels) in class_from_file' /home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb:34:in each'
/home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb:34:in `block (2 levels) in class_from_file'
Resource Declaration:
In /home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb
48:   g = rvm_gem new_resource.package_name do
49:     ruby_string ruby_global_gemset
50:     source      new_resource.source if new_resource.source
51:     options     new_resource.options if new_resource.options
52:     version     new_resource.version if new_resource.version
53:     gem_binary  new_resource.gem_binary if new_resource.gem_binary
54:     user        new_resource.user
55:     action      :nothing
56:   end
57:   g.run_action(exec_action)
Compiled Resource:
Declared in /home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb:48:in `gem_package_wrapper'
rvm_gem("bundler") do
provider Chef::Provider::Package::RVMRubygems
action [:nothing]
retries 0
retry_delay 2
default_guard_interpreter :default
declared_type :rvm_gem
cookbook_name :rvm
ruby_string "ruby-2.1.1@global"
gem_binary "gem"
package_name "bundler"
version "1.9.6"
end

================================================================================
Error executing action install on resource 'rvm_global_gem[bundler]'
NoMethodError
rvm_gem[bundler] (/home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb line 48) had an error: NoMethodError: undefined method `rvm_environment' for #Chef::Provider::Package::RVMRubygems:0x00000008d52610
Cookbook Trace:
/home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/rvm_rubygems_package.rb:129:in block in install_package' /home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/rvm_rubygems_package.rb:127:in each'
/home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/rvm_rubygems_package.rb:127:in install_package' /home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb:57:in gem_package_wrapper'
/home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb:35:in block (3 levels) in class_from_file' /home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb:34:in each'
/home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb:34:in `block (2 levels) in class_from_file'
Resource Declaration:
In /home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/chef_rvm_recipe_helpers.rb
191:           rvm_global_gem gem[:name] do
192:             user      opts[:user]
193:             [:version, :action, :options, :source].each do |attr|
194:               send(attr, gem[attr]) if gem[attr]
195:             end
196:           end
197:         end
Compiled Resource:
Declared in /home/ec2-user/chef-solo/cookbooks-2/rvm/libraries/chef_rvm_recipe_helpers.rb:191:in `block in install_rubies'
rvm_global_gem("bundler") do
action :install
retries 0
retry_delay 2
default_guard_interpreter :default
declared_type :rvm_global_gem
cookbook_name :rvm
recipe_name "system"
package_name "bundler"
end

Running handlers:
[2015-05-04T22:23:34-07:00] ERROR: Running exception handlers
Running handlers complete
[2015-05-04T22:23:34-07:00] ERROR: Exception handlers complete
[2015-05-04T22:23:34-07:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
Chef Client failed. 2 resources updated in 16.244196065 seconds
[2015-05-04T22:23:34-07:00] ERROR: rvm_global_gem[bundler] (rvm::system line 191) had an error: NoMethodError: rvm_gem[bundler] (/home/ec2-user/chef-solo/cookbooks-2/rvm/providers/global_gem.rb line 48) had an error: NoMethodError: undefined method `rvm_environment' for #Chef::Provider::Package::RVMRubygems:0x00000008d52610
[2015-05-04T22:23:34-07:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)
ERROR: RuntimeError: chef-solo failed. See output above.
~/workspace/123hp_utils [2.1.1@123_jenkins master*]
i am using the knife solo to bootstrap a node and this recipe is also a part of the run-list. How do i apply the workaround? i made the changes in the file as in this https://github.com/martinisoft/chef-rvm/pull/284/files  but whenever i do a `knife solo cook user@servername'  the cookbook apears to be re-downloaded and hence the changes are all gone

So, i rolled back the chef-client version to 11.16.4. And i don't have this issue.

Yup, that absolutely sounds like the same issue.

interestingly enough... I'm running into this same error with chef-client version: 11.6.0 and rvm cookbook version 0.9.2.
Error is similar

Confirmed that running same version of this cookbook (0.9.2) under Chef 11.16.4 does not give the error.  Running under 12.3.0 gives the same error.  Seems like a bug regression in Chef.

I got this same issue with the following versions:
Chef Development Kit Version: 0.5.1
chef-client version: 12.3.0
berks version: 3.2.3
kitchen version: 1.4.0

Is there a workaround or a fix?

Work around for knife solo users

overwrite the chef-client with an earlier version

During the bootstrap operation the chef-client is uploaded to the target system, typically the latest version currently 12.3 ish - rolling-back the client to an earlier version is one workaround:
Setting Chef-Client Bootstrap Version
knife solo bootstrap <ip-address | FQDN> --bootstrap-version 11.16.4

Example
knife solo bootstrap <IP_ADDRESS> --bootstrap-version 11.16.4

Maybe the same for knife bootstrap? But completely untested.
Rich

This bug has been fixed and merged in #284.  If you are comfortable with using Berkshelf, you can use the latest on the master branch from github, or lock to a specific commit id using ref.  Otherwise, the workaround mentioned by @RichardWigley by using an old version of Chef will allow you to keep using the old version of this cookbook until the new release makes it to Chef Supermarket.

I have tried it with latest chef-12.4.0 and berks to download the latest check however issue seems to persist.
================================================================================
Error executing action `install` on resource 'rvm_gem[bundle]'
================================================================================

NoMethodError
-------------
undefined method `rvm_environment' for #<Chef::Provider::Package::RVMRubygems:0x000000089200b0>

Cookbook Trace:
---------------
/var/chef/cache/cookbooks/rvm/libraries/rvm_rubygems_package.rb:129:in `block in install_package'
/var/chef/cache/cookbooks/rvm/libraries/rvm_rubygems_package.rb:127:in `each'
/var/chef/cache/cookbooks/rvm/libraries/rvm_rubygems_package.rb:127:in `install_package'

Resource Declaration:
---------------------
# In /var/chef/cache/cookbooks/rails_dep/recipes/default.rb

 99:   rvm_gem "bundle" do
100:     ruby_string "ruby-2.1.5@ruby_zicos"
101:     action      :install
102:   end
103: end

Compiled Resource:
------------------
# Declared in /var/chef/cache/cookbooks/rails_dep/recipes/default.rb:99:in `from_file'

rvm_gem("bundle") do
  provider Chef::Provider::Package::RVMRubygems
  action [:install]
  retries 0
  retry_delay 2
  default_guard_interpreter :default
  declared_type :rvm_gem
  cookbook_name "rails_dep"
  recipe_name "default"
  ruby_string "ruby-2.1.5@ruby_zicos"
  gem_binary "gem"
  package_name "bundle"
  version "0.0.1"
end

=============================================================================
It would be great if there is any fix. Or command to fetch the correct version of cookbook using berks.

I upgraded to the latest release of 0.9.4 and stopped having the problem. I pinned the version in my cookbook's metadata.rb

Going to close this issue as the 0.9.4 release included a back-ported Chef 12 patch to resolve the issue.


[Phase II]  telegram bot notification

[x] Update telegram token in User setting page
[x] New command telegramNotify

Notify content:

Done days so far this week (including today)
Total hours of the week (including today)
Streaking so far (after done #24)

[ ] New UI for generating subscribe JWT

Unsubscribe:
typing /unsub -> shows all the options with inline-keyboard buttons -> press the button -> unsubscribe

Set up notification time:
/set_notify_time xx:xx:xx -> check the time format, eliminating the seconds, if present -> update the database column


Embedded Wallets

Is your feature request related to a problem? Please describe. Feature
Ideally, at scale - it's not feasible in many cases to create a unique wallet for each agent per user
Describe the solution you'd like
A solution, where an embedded wallet is created for the agent, linked to a identity - can be a user's wallet address, or any field in database
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Just for reference purposes

https://passkeys.foundation/docs
https://privy.io/blog/introducing-server-wallets

Hey was just going through the code base and I saw that the wallet is being created from the private key Keypair.fromSecretKey(bs58.decode(private_key));, so where exactly are unique wallet for each agent are being created. From this code it will get the particular wallet from a given private key.

Hey was just going through the code base and I saw that the wallet is being created from the private key Keypair.fromSecretKey(bs58.decode(private_key));, so where exactly are unique wallet for each agent are being created. From this code it will get the particular wallet from a given private key.

Ig, its created on the browser

hey @Rudrakc - not sure what your question here is, and how it's related to embedded wallet

Hey @thearyanag ,
I have gone through the flow of creating wallets for the agents, and I see, we are taking in the private key of the users address, and then we make an embedded wallet for that private key
We can link this embedded wallet to a user's identity
We can do it in this way - (considering, we could also change the inputs):
Take in the users address as the input and provide the access to the private key for the embedded wallet - we can make it a child wallet which is approved by the parent wallet, in our case - its the user's address
Over here, I would also need access to the Database for more clarity
We can even abstract out most of the logic for approval and confirmations, as all of it could be delegated to the child-wallet
Let me know if we can go with this approach

Hey @thearyanag key idea is to streamline wallet interactions by allowing users to connect their own wallets directly to the agent. Once connected, the agent will interact seamlessly with the user wallet, which is linked to their identity (via wallet address or email address). The Solana-Agent-Kit will act as a single, unified framework for all users—staying consistent across the platform while still enabling personalized wallet usage.
1.	Agent Keypair: The agent will maintain its own unique keypair for processing and enhanced security, ensuring robust operation across all interactions.
2.	User Wallets: Each user connects their wallet to the agent for their transactions and actions. The agent does not create separate wallets for individual users, simplifying wallet management.

I was thinking, we can change the keypair being passed to something like wallet interface, which could be something like
{
 public_address : PubKey,
 sendTransaction(): => string,
 sendAllTransaction() => string,
}

this way we could use any embedded wallet, or private key
wdyt @0xNoushad / @skushagra9

@thearyanag Can we have 2 approaches?

The existing keypair method.
Passing the custom wallet object. (pubkey, signtx, sendtx, signandsendtx, sendalltx).

and a new parameter to choose the wallet method 1/2.


Add support of PropType checking in Vue 2

Thank you for very useful extension, it helps me a lot.
And it would be more helpful if you add PropType checking like when project uses vue 3.
Currently this feature doesn't support vue 2 projects :(

hi @Hope410, you already can use PropType form @vue/composition-api module. I'm not sure which part you are missing, so here is a example:
import { defineComponent, PropType } from '@vue/composition-api'

export default defineComponent({
  props: {
    foo: Object as PropType<AnyTypeYouWant>
  }
})

follow your pics, it seem your problem is the component can't infer BtnTheme correctly.
as I know defineComponent from vue2(@vue/composition-api) and vue3(@vue/runtime-dom) has different behavior. If you wan to the defineComponent from @vue/composition-api has follow @vue/runtime-dom behavior, you need to have a shim script:
declare module '@vue/composition-api' {
  export * from '@vue/composition-api/dist'
  export { defineComponent } from '@vue/runtime-dom'
}

hi @Hope410, you already can use PropType form @vue/composition-api module. I'm not sure which part you are missing, so here is a example:

I use PropType from vue import and don't use defineComponent from @vue/composition-api.

have you try defineComponent? as I know PropType only work for defineComponent, but not Vue.extend.

as I know PropType only work for defineComponent, but not Vue.extend.

PropType from vue works as well.
So, i used defineComponent, and prop type infered correctly, thanks. But could you add support of Vue.extend? It would be very helpful for vue2 + typescript users, i think most of them use Vue.extend

PropType from vue can only work for this type inside Vue.extend({ ... }), but not working for $props:
import Vue, { PropType } from 'vue';

const A = Vue.extend({
  props: {
    foo: String,
  },
});
const a = new A();

a.$props.foo // any

check the source code, Vue.extend seem do nothing for $props types infer: https://github.com/vuejs/vue/blob/dev/types/vue.d.ts#L34
I'm not sure dose they have plan to improve Vue.extend types or not, anyway this is upstream problem.

I understood, anyway, thank you!

Somehow, Prop checking worked for me in Vue 2 (Nuxt), while using Vue.extends({}):

The docs for Volar say this shouldn't work, no?,

@dynamite-ready The type inference provided by Vue.extend is very limited. For example, cross-component props type-checking is not supported.


Handle "maximum size reached" error

We are using typeahead with prefetch. And got uncatched exception
NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached

return ls.setItem(this._prefix(key), encode(val));

Typeahead should handle this kind of exceptions

Hi,
I am using typeahead prefetch like below.
prefetch:
ttl: 250000
url: '/employees.json'
filter: (employees) ->
$.map employees, (employee) ->
{ name: employee }
limit: 25
Here employees.json is huge in size. I am getting the storage error
NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached
Someone please help ASAP to resolve this.
Thanks in advance,


Allow aliasing of topics in the helpTopic command

After discussion in issue #70 (and further offline discussion), it's decided that we want to be able to provide aliases for commands in the config so that multiple phrases can be used for a command to get the helptext for that command.
e.g. it should be possible for both "Cadence help nowplaying" and "Cadence help now playing" to generate helptext for the nowplaying command.
example of possible config format for this feature
"helpTopics": {
    "nowplaying": {
        "internalKey": "nowplaying",
        "subtitle": ...,
        "lines": [...],
    },
    "now playing": {
        "alias": "nowplaying"
    }
}

I'm considering this closed by #86 (Issue fixes in dev-master are good enough...)

I'm considering this closed by #86 (Issue fixes in dev-master are good enough...)


Left Alignment of Placeholder Text?

The search icon and placeholder text are aligned center by default. Would be great if that could change to left-hand or right-hand alignment, depending on the use case. I.e. in Apple Maps, the search bar placeholder and icon is left-aligned:

+1

I am open to PRs - don't have time to develop my open source packages anymore =/


Open LG Connector web settings page (http://X.X.X.X:30020/settings)

I didn't quite understand what to do about it

Im not sure what the ip is or where i get it? is it a docker IP? if so where do i find it?
I cant seeme to acces LG connector at all. I must be putting in the wrong URL

If you are using the default host network then the IP will be the docker host ip. When you set up the container you need to make sure to expose port 30020, more info here
For reference, here is my docker run command
docker run -d \ --name lg-connector \ -p 30020:30020 \ -v /volume1/docker/lg-connector:/config fison67/lg-connector:0.0.3


subject matter editor bug on published data

https://user-images.githubusercontent.com/844306/129250819-15b3b5ed-5225-480e-819e-11b15a292169.mp4
The subject matter entry is blank when you go back into the metadata editor, but the entry is still there on the dandiset landing page

@mvandenburgh - is it possible that the ui is using the schemaVersion from the metadata instead of the infrastructure schema? in that sense 0.4.4 is definitely broken for vjsf.

@mvandenburgh - is it possible that the ui is using the schemaVersion from the metadata instead of the infrastructure schema? in that sense 0.4.4 is definitely broken for vjsf.

No, the UI uses the schema from the infrastructure repo (currently 0.5.1, just double checked it).

I can't reproduce this now, so perhaps it has been fixed. I'm going to close this, but @bendichter if you can still reproduce this please re-open and leave a note.


async/await - Parsing error: Unexpected token => (null)

export function loadThings (creds) {
  return async (dispatch, getState) => {
    try {
      const response = await fetch('http://localhost/api/things')
      return response
    } catch (err) {
      throw (err)
    }
  }
}

Totally unrelated but I couldn't help myself, you don't need to catch and then throw the same error. This function would be functionally equivalent:
export function loadThings (creds) {
  return async (dispatch, getState) => {
    return await fetch('http://localhost/api/things')
  }
}

@LinusU The code is actually out of context. Got it from a demo source and stripped it. But thanks for the advice.

Cool, I happened to press send a bit early, did you see the solution to your problem?

I did now :)
Thanks!


Confusion about client_id

If users get the job at the same time, will the client_id be repeated when the new shape is saved?
thanks,

@ShihJenYu ,
I'm not sure that I understand your question completely. Could you please elaborate a little bit?

Also I suggest moving the discussion to https://gitter.im/opencv-cvat.

Discussed on gitter.


Pin dependency versions using renovate

What needs to be done?
Update the renovate config to create less PRs so we can pin dependency versions to make the showcase image more reproducible.
Acceptance criteria

Update renovate config to create less PRs
Pin dependency versions using renovate

Creating per my discussion with @christophe-f

Updating only patch versions for now. Major and minor versions will be updated with the Backstage releases.


Fix requirements

setup.py missed two requirements:
"langchain-text-splitters==0.2.2", # typo in original
"aiohttp==3.9.5"

Agree with CLA

Good catch, thanks a lot!


[TASK] Benchmark of the replica rebuilding on the same node

What's the task? Please describe

Ref: https://github.com/longhorn/longhorn/issues/4105
Describe the sub-tasks

Additional context

v2 volume should have a similar capacity in the future.
https://github.com/longhorn/longhorn/issues/9109


Annotation of MAIT cells

Identification of MAIT cells based on conserved TCR alpha chains (could be done by identity or similarity).

This seems rather specific, so I'm not sure if this should be a dedicated function.
It is already pretty straightforward using sequence_dist.
But maybe this could be combined into a generic function together with https://github.com/icbi-lab/scirpy/issues/54.

Good idea! The list of invariant TCR alpha chain would be needed to annotate the cells with exact matches, but the clonotype network could then be used to link them to additional cell types with similar TCR.


[AERIE-2158] Refactor activity validation check

Tickets addressed: AERIE-2158
Review: By commit
Merge strategy: Merge (no squash)

Description
The function LocalMissionModelService#validateActivityInstantiations validates each activity in the provided map. Problematically, it was loading the mission model for each activity validated. This refactor simply changes it to load the mission model once. This should significantly reduce the latency in requesting simulation results.
Verification
Ran the e2e tests.
Documentation
None needed, no changes to system behavior.
Future work
None

The function LocalMissionModelService#validateActivityInstantiations validates each activity in the provided map. Problematically, it was loading the mission model for each activity validated. This refactor simply changes it to load the mission model once. This should significantly reduce the latency in requesting simulation results.

Oh, oof. Nice find.

🤦 Thanks Pat! Big oversight on my part.


Adding tagged builds for M1

Adding tagged builds for M1

@atalman @malfet FYI, it seems that the unit-tests are failing on M1. We haven't been able to pinpoint the Core commit that broke it but it looks less likely we will be able to release M1 binaries for TorchVision. We've added all the details that we know so far at #6142. Please let us know what you think.


Icon for SQL Server

Hey @ruicaramalho! Thanks for filing this issue. I seem to have a duplicate above this one that I've already labeled and whatnot so I'm going to close this one. Please take a look at #147 if you have any comments or concerns. Thanks for your contribution!


[Select] Items in menu of select field are hidden!

[ ] This is a v1.x issue (v0.x is no longer maintained).
[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Menu in select field should open
Current Behavior
Items in menu of select field are hidden and you can't choose anything!

Steps to Reproduce (for bugs)

Add select component
Add Menu items as children of select component
Try to open select field

Your Environment

Tech
Version

Material-UI
v1.0.0

React
v16.2.0

browser
chrome

I ran into this yesterday, and was about to file an issue! We traced it to being an issue with<EMAIL_ADDRESS>I'll try to get a working reproduce added here. The issue is that the calls Mui-hidden-{xx} is added to the modal that is injected into the dom - and I am not sure why.
I was able to reproduce it regardless of a theme provider / cssbaseline being used, so I am suspicious that it is related to an issue with context compatibility.


Improve cognitive ease of alert rules filename

Enhancement Proposal
Currently, the amalgamated alert rules filename that gets written to prom's filesystem looks like this:
juju_cos2_f2dc1aa0-de3b-4a7a-8636-2d56c0967dd8_am.rules

Specifically, the model name and app name are separated by the model uuid. This is inconvenient. It would be easier to read this if human-readable portions of the topology were next to each other, e.g. [prefix]_[uuid]_[model]_[app]:
juju_f2dc1aa0-de3b-4a7a-8636-2d56c0967dd8_cos2_am.rules

This way a human reader can get easily used to having the most valuable information payload at the end.

Are there any possible ripple-effects we might need to take into consideration here? I don't think we use the filename anywhere, but we should make sure that is the case

There is too little value in this change at the moment to warrant putting development time into it.


Fix guid logic for watchOS

The framework doesn't compile on watchOS, since UIDevice isn't available on watchOS.
Replaced the call with WKInterfaceDevice, the watchOS equivalent.

Hi @aboedo,
Thanks for the fix.
Just merged and updated cocoapods.
P


about training and test

Sorry to bother u,but i have some questions about  the implementation of  SiamRPN.When i use   zkisthebest's code,the performance is so bad ,so i tried to add ur code into his,but when i train the code,it alerts the error TypeError: batch must contain tensors, numbers, dicts or lists; found <class 'PIL.Image.Image'>.So i wonder whether u  can provide train.py and test.py

Thanks for your attention. Now this work is not yet  complete, some parts need to be modified and tested. I will update later, please pay attention to this work.

@songdejia Thank u so much！！！

We have just finished v1.0 on pytorch and tensorflow.
pytorch-version is available here [https://github.com/songdejia/siamese-RPN]
tensorflow-version is available here [https://github.com/makalo/Siamese-RPN-tensorflow.git]
@vincennnnt

@

@songdejia Thank u for ur great job！！


Style Guide for Code

Good.  I think your guide is easy to understand and very explicit.

Thank you for the positive feedback!


Attributes with array of objects produce incomplete schema

The following part of my text file:

Response 200 (application/json)

Attributes (object)

nodes (array[object])

id: 4 (number)
sname: Chromista  (string) - The scientific name
rank: Kingdom (string) - The taxonomic rank of the scientific name
authorship: noworms, 1603 (string) - Authorship information about the scientific name

Body
{
    "nodes": [
        {
            "id": "1",
            "sname": "Animalia",
            "rank": "Kingdom",
            "authorship": "noworms, 1603"
        },
        {
            "id": "2",
            "sname": "Archaea",
            "rank": "Kingdom",
            "authorship": "noworms, 1603"
        },
        {
            "id": "3",
            "sname": "Bacteria",
            "rank": "Kingdom",
            "authorship": "noworms, 1603"
        },
        {
            "id": "4",
            "sname": "Chromista",
            "rank": "Kingdom",
            "authorship": "noworms, 1603"
        },
        {
            "id": "5",
            "sname": "Fungi",
            "rank": "Kingdom",
            "authorship": "noworms, 1603"
        }
    ],
    "hasMore": 1
}

Produces this HTML:

The part of schema inside the ""nodes" is missing! Why?
I have also tried to use data structures but the schema remains incomplete.

@agougousis Can you try the following?
nodes (array[object], fixed)

Ok! Though I haven't found yet where this "fixed" world came from, now the schema is complete.
However, it seems that the produced schema is not right.
The schema produced is:

and the correct schema should be:

Am I wrong?

Can you try this?
+ nodes (array, fixed)
    + (object)
        + id: 4 (number)

Yeap! A lot better! I didn't think that "anonymous" objects can be defined!
I am not sure, but I think that the brackets marked in the following screenshot should not be there. What do you think?

@agougousis The brackets are correct as items is an array of possible types

I don't remember very well the rules, but in http://jsonschema.net/ (a quick and dirty solution that I use from time to time) when i give the json data as input it gives me the schema without these brackets.

Use a fixed-type for this:
+ nodes (array, fixed-type)
    + (object)
        + id: 4 (number)

+1 for the fixed-type
fixed - instance of this type structure and values are fixed. This attribute propagates to Nested Member Types.
fixed-type - instance of this type structure is fixed, value is not. This attribute does not propagate to Nested Member Types.
https://apiblueprint.org/documentation/mson/specification.html#353-type-attribute


proton-pass minimize and close argument no longer working

Describe the bug
When using home-manager for xdg autostart to have proton-pass launch at startup, I had --minimize set as an argument previously, and it would start the application minimized on OS boot, which is ideal. In one of the recent updates, this no longer works. When proton-pass launches on startup, it launches in the foreground, and I can't find any other way to force it to minimize.
Steps To Reproduce
Steps to reproduce the behavior:

Setup XDG autostart via home-manager for proton pass
Set the exec line with --minimize or even --close argument.
Reboot

Expected behavior
I expect to be able to use an argument in the exec line for xdg autostart entry that can force the app to minimize on startup.
Additional context
The argument used to work, but no longer works in recent updates.
Notify maintainers
@luftmensch-luftmensch
@massix
@SebTM

Hello,
could you please share a snippet of your home-manager configuration so that I can try to replicate it? I have never used such an option before.
Also, do you remember which version of proton-pass was working with the flags as you described?
Thanks!

Hi again,
don't worry :)
Unluckily, implementing that kind of behavior means heavily modifying the source code, and I don't feel like doing it, since we only have a "transpiled" version of it in the Electron's ASAR. You can open a discussion on Proton's forums and ask for the feature to be implemented, though :)
Have a nice day.


Force deletion of expired snapshots

Automatically respond to the prompt (are you sure: yes/no)

Thanks for contributing!

You may want to rollback this change, and just use the global "-q" flag, which defaults to "yes", so:
echo "$(gcloud compute snapshots delete ${SNAPSHOT_NAME} -q)"
Better to use built-in gcloud functionality, instead of a hack. 👍 @JoeAlamo @jacksegal


Simplify installation (instructions)

There are multiple installation methods and instructions: docker, conda, pip, hatch, with/without R dependencies, ...
Since #192 R dependencies are no longer called through rpy2 but simply a command line call. This should make springtime less entangled with its R dependencies, and could simplify the installation itself.
Also since #192, ML packages used in tutorial are no longer really part of the package.
Also the dependencies as specified in pyproject.toml are outdated.
In the documentation (and elsewhere), it might make sense to distinguish between the springtime python package and the springtime project environment.

Addressed in #210


feat(opendataset): add dataloader for PASCALContext open dataset

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 83.71%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5560

Relevant Lines:
6642

💛  - Coveralls


Bump crypto-browserify to ~3.8.0

Let's update crypto-browserify to the latest version that doesn't break https://github.com/webpack/node-libs-browser/issues/19

Realy need the latest version.

see #28


Gc stats

Codecov Report

Merging #2089 (9083814) into main (f3c5f06) will decrease coverage by 0.22%.
The diff coverage is 19.38%.

@@            Coverage Diff             @@
##             main    #2089      +/-   ##
==========================================
- Coverage   64.71%   64.48%   -0.23%
==========================================
  Files         132      132
  Lines       15658    15746      +88
==========================================
+ Hits        10133    10154      +21
- Misses       5525     5592      +67

Impacted Files
Coverage Δ

src/irmin-pack/unix/gc.ml
31.91% <0.00%> (-8.09%)
:arrow_down:

src/irmin-pack/unix/stats.ml
56.00% <37.50%> (-2.21%)
:arrow_down:

src/irmin-pack/unix/stats_intf.ml
47.36% <45.45%> (-2.64%)
:arrow_down:

src/irmin-pack/unix/io.ml
66.00% <83.33%> (+1.10%)
:arrow_up:

src/irmin-pack/unix/mapping_file.ml
92.41% <85.71%> (-0.40%)
:arrow_down:

src/irmin/watch.ml
80.98% <0.00%> (+2.11%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

gc.ml is abound 900 lines of code. I'd like to split it into Gc_utils (which would contain the new stats), Gc_worker and Gc at some point (not in this PR, after this PR is merged). @metanivek you did not fancy that solution last time we talked about this. WDYT now?

I usually think that "utils" are a general code smell. Sometimes they are warranted as a collection of utility functions, but I usually want to pause and think about what I'm actually trying to model by stuffing things into a "utils". I don't know if this translates well, but I see them as the junk drawer of code bases. :wastebasket:
As for gc specifically, I shied away from it previously because of the above utils issue, but also I didn't see a strong need to pull apart the module since it all works as one unit anyway (the almost identical Args module indicating this strongly to me). I'm also noticing that lots of OCaml code bases have large module files (sometimes in the thousands of lines), and I wonder if it is just more common to place more code into files with OCaml than other languages.
All that to say, I wouldn't be opposed to splitting the file, but I would just like to see a better modelling than a utils file. :wink:

This is now ready for review.

I'm done with this PR. I'll clean the commit history prior to merge, following approves


Transfer ownership to caskroom

@vitorgalvao, what do you think about transferring ownership of this repository to @caskroom? I would still be the primary maintainer, but help and feedback from @caskroom/maintainers would be more than welcome. It also just makes sense, given the narrow focus of the plugin.

Sure thing, whatever works best for you.

From the documentation on transferring a repository:

Users must have admin or owner rights within the receiving organization before they can transfer a repository that they individually own. If the user does not already have this level of access, a temporary admin team can be created with only the user. The user sending the repository is the only one who can perform the transfer.

Just as when transferring a repository between two organizations, when a repository is transferred from a user to an organization, the Owners team is the only group with read/write access to the repository, but they can choose to add other teams for further access. See "Permission Levels for an Organization" for more information.

So I'll need temporary admin access within the @caskroom organization.

So I'll need temporary admin access within the @caskroom organization.

Make it permanent. No reason you shouldn’t have it, anyway.

:tada:


Syntax error in Dockerfile

Severity

[ ] Critical/Blocker (select if the issue makes the application unusable or causes serious data loss)
[ ] High (select if the issue affects a major feature and there is no workaround or the available workaround is very complex)
[ ] Medium (select if the issue affects a minor feature or affects a major feature but has an easy enough workaround to not cause any major inconvenience)
[x] Low (select if the issue doesn't significantly affect the user experience, like minor visual bugs)

Describe the bug
There is a syntax error in the Dockerfile. On line 44 it says && /venv/bin/pip install --no-cache-dir setuptools>=65 \, but it should be && /venv/bin/pip install --no-cache-dir 'setuptools>=65' \ ?

Good catch, thank you!


Redesign applied to private embed view

Fixes #10604

CR @piensaenpixel cc @josecruz

Loving it @MariaCheca! Just one comment, can you move the icon 2-3px left, It might be centered on the circle but visually looks a bit misaligned
🙏

Ping @piensaenpixel 💋

two small comments the rest chachi piruli

@piensaenpixel I applied the changes :)

ping @piensaenpixel

👍


Feat/more screen

Issues Addressed
closes #19
closes #20
closes #21
closes #22
closes #23
closes #24

included in #43


refactor: prune socket before launching runtime-proxy

Signed-off-by: Jason Liu<EMAIL_ADDRESS>Ⅰ. Describe what this PR does
There might be a situation where runtime-proxy was killed by SIGKILL signal. In this case, defer os.Remove(options.RuntimeProxyEndpoint) won't have chance to be executed. So it's better to re-create socket file before launching runtime-proxy.
II. Special notes for reviews
None

/cc @honpey @ZYecho @cheimu

/lgtm

/lgtm

/approve


Use gcsa + xg in mapper

To comment on changes.

The failure: cannot align because node predecessors cannot provide seed seems to result from xg passing duplicate nodes into vg. This should be fixed in xg. I'll dig further tomorrow.

I'm working on this and I've some issues. I've got the mapper working.
However, xg is not threadsafe, for reasons I'm rather confused by, and the mapper only works single-threaded. Investigating.


[1.20.1] version 1.20-1.2.1 crashes dedicated server on launch

Installing the mod causes the server to crash on launch due to it trying to load client-side-only classes.
mc version: 1.20.1
forge version: 47.1.0
mod version: 1.20-1.2.1
logs:
crash-2023-07-07_14.43.28-fml.txt
latest.log
debug.log

Just pushed a 1.2.2 update that should fix this problem!


[Feature Request]: Token generator for security commands

Is your feature request related to a problem? Please describe.
Can we get a friendly az devops security token method to which I pass a bunch of things, so it can spit out the full token? I have to look up 3 guids and do a rearch&replace over my branch pointer. Who knows these things anyway?
Describe the solution you'd like
Additional context

Since most securables have an URI in Azure DevOps and since most json payloads have a _self link, it would make sense to allow me to pass one of those in.
It probably trumps having to supply all elements that make up the token, as these are different for each element. E.g. org, project, repo id, branch ref for a branch. And org, project, Team GUID for the Team Administrator.

If an option to pass in individual elements is considered, then please, please, please, allow us to pass in both name as well as ID. I'm slowly going crazy having to lookup 6 GUIDS, Descriptors, Tokens and other unreadable things in order to do what I need.

I'm looking for a command to generate a Personal Access Token with some scopes. (Basically a CLI replacement for https://dev.azure.com/strivr/_usersSettings/tokens ) Is that this?

@lukeschlather . There is no command to generate Personal Access token.
You will have to use UI only for this .
Also, this feature request talks about Security token (the tokens which are used in security permission commands) and not PAT.


Fix example position handling

In current implementation, we can't specify first example (0th position) and examples located in two or more digits position as arguements to --only or --skip.
In the former case, for example, the "first example of the second scenario" is represented as "1.0" (since cytorus uses 0-based number for positions), but the .0 part is dropped when cytorus converts the position from a string to a number at https://github.com/NaturalIntelligence/cytorus/blob/11fd6515789fe1ef066454f9172ac9b236c72a10/src/cli/ArgsReader.js#L46 or https://github.com/NaturalIntelligence/cytorus/blob/11fd6515789fe1ef066454f9172ac9b236c72a10/src/cli/ArgsReader.js#L48.  ("1.0" is converted to 1)
The latter is due to cytorus uses the result of (scenario position) + (example position) / 10 as the "position".
For example, following two different exmaples have same position of 1.1 and cannot be distinguished:

the position of the 11th example of the 0th scenario (0 + 11/10 = 1.1)
the position of the 1st example of the 1st scenario (1 + 1/10 = 1.1)

I don't know if the position being 0-based is by design or a bug, so in this PR, I only fixed the handling of the position of the the examples.

Thanks for your changes. Can you please remove package-lock from the PR?
I wanted to keep the position stating from 1 only. But not sure what I ended with. And the particular feature was well running. not sure about specific case. Will check that against your PR.

Can you please remove package-lock from the PR?

Done.

Changes merged. position needs to be 1-base index.


Access lowest shared Context from a SpanPair or other higher-arity candidate

@stephenbach Just getting better access to context from SpanPair- and vice versa- would be great to start (everything working without this, but some hacky bits)

So just a context attribute to start would be very helpful here


fix(policies): resolve the associated domain for a domain as the domain itself

Checklist

[x] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[x] Links to related issues (if applicable)
[x] Tests for the changes have been added/updated (if applicable)
[x] Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
[x] For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Solves https://github.com/datahub-project/datahub/issues/6430


How to create different CU NAV Server Instance on the same server?

Hi,
I need to create different NAV Server Instance of different CU NAV Version. I have installed on the server the NAV2018 CU5 and with the standard NAV cmdlet I create New NAV Server Instance with this command:"New-NAVServerInstance -DatabaseServer NAV2018 -DatabaseName "Demo Database NAV_2018_CU4" -ClientServicesPort 7146 -SOAPServicesPort 7147 -ODataServicesPort 7148 -ManagementServicesPort 7145 -DeveloperServicesPort 7149 -Verbose", but I cannot choose the CU Version and also I cannot choose the path of installation. I making sothing wrong? You have some suggestion/solution? With the installation of the web client will I have the same problem?
Thank you in advanced,
Roberto.

Please contact regular support channel. Your question is not related to Business Central nor to AL development.


fix(deps): do not list email-validator as a devDependency

Because it was listed as a devDependency it got removed during a container build process causing module not found error.
Description
Screenshot (if UI-related)
To-Dos

[ ] Successful build yarn build
[ ] Translation keys yarn i18n:extract
[ ] Database migration (if required)

Issues Fixed or Closed

Fixes #XXXX

Could you fix the lint issue?

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

v1.2.0
GitHub release

Your semantic-release bot :package::rocket:


Add .gitignore

To improve robustness of use of this repository, please add a .gitignore file. GitHub provides a collection of templates here: https://github.com/github/gitignore.

This may prove a useful starting point for a MATLAB repo:
https://github.com/github/gitignore/blob/main/Global/MATLAB.gitignore

Added Matlab gitignore file, as suggested!

Oh, I don't think git will consider the file MATLAB.gitignore, as far as I know it just looks at .gitignore. The provided files shows what to put in .gitignore to disregard common MATLAB binaries etc. Here you can simply move MATLAB.gitignore to .gitignore, since there was no previous .gitignore.

@ftessier Corrected!

Oh, I don't think git will consider the file MATLAB.gitignore, as far as I know it just looks at .gitignore. The provided files shows what to put in .gitignore to disregard common MATLAB binaries etc. Here you can simply move MATLAB.gitignore to .gitignore, since there was no previous .gitignore.

Correct.

@ftessier I moved content of Matlab.gitignore to .gitignore, on your advise.
I can now close the issue, if it looks good :)

@ftessier I moved content of Matlab.gitignore to .gitignore, on your advise. I can now close the issue, if it looks good :)

A quick review of the main branch looks good with the .gitignore

@aweinert-MIT Thanks Andrew! I will now close this issue. Please let me know if you have any other suggestions, and thanks for the star ;)

@aweinert-MIT Thanks Andrew! I will now close this issue. Please let me know if you have any other suggestions, and thanks for the star ;)

Already created pull request #21 to help with repo admin 😄

@aweinert-MIT And approved 😄


lineage graph is not working properlly

lineage graph is not working properly, on drag and drop of nodes multiple edges are creating, this might be due to duplicate index on node or edges. please refer bellow screenshot

Hi @12sachin95, lineage graph is generated now using elastic search. Have reindexed the elasticsearch.
Can you check if it's still reproducing ?

Now its working fine @karanh37


TypeError: req.toObject is not a function

I was trying to run a ldap server instance referred by the example provided by the ldapjs documentation with Node.js v20.
server.add('ou=users, o=myhost', pre, (req, res, next) => {
...
const entry = req.toObject().attributes;
...
}

Then I tried to invoke this handler by invoking the LDAPAdd provided by the OpenLDAP.
However, the requests fails. I tried to hook up the server with pino logger and this time it provides me with an error message.
{
"msg":"<IP_ADDRESS>:57282::1 uncaught exception: TypeError: req.toObject is not a function at Server.<anonymous>..."
}

Is this example out of date in v3 or did I miss something here?

Ok, I switch the version to v2 and it works correctly.

Is this example out of date

Yes. The current equivalent would be entry.pojo.attributes. But it would be better to use the object itself to access the attributes, e.g. entry.attributes.

The examples/inmemory.js does not work with V3
`server.add(SUFFIX, authorize, function (req, res, next) {
const dn = req.dn.toString()
if (db[dn]) { return next(new ldap.EntryAlreadyExistsError(dn)) }
db[dn] = req.toObject().attributes
res.end()
return next()
})`
does not work. In V3 there is no AddRequest object and no toObject function anymore.
Also the code in http://ldapjs.org/server.html#add is wrong for the same reason.


Sync OWNERS with ARO-RP CODEOWNERS

Modifying owners to reflect current FLs/RLs in ARO. Ref https://github.com/Azure/ARO-RP/blob/master/.github/CODEOWNERS

/cherry-pick release-4.10

/cherry-pick release-4.11


Display the user profile information on the page

https://github.com/sopra-fs23-group-32/SoPra23_Client/commit/583b3d793b3eaf7e9b1d47d6dd773935a120412a


add weather plugin

I would like to try my hand at implementing this.

ok, wunderground might be a help

will write this


Replace Lighttpd

Due to challenges with building from source or utilizing alternative repositories, replace Lighttpd with Apache HTTPd.
Apache HTTPD should be available from all core distro repositories.  Plan to use HTTPD 2.4 by default, older versions may require 2.2.

RHEL 6 / CentOS 6: Apache HTTPd 2.2.x
RHEL 7 / CentOS 7: Apache HTTPd 2.4.x
RHEL 8 / CentOS 8: Apache HTTPd 2.4.x

Due to challenges with building from source or utilizing alternative repositories, replace Lighttpd with Apache HTTPd.

I am a lighttpd developer and am curious what you mean by this.  Is there something that can be adjusted upstream to address your concern?  lighttpd is available as a package in many distros.

I am a lighttpd developer and am curious what you mean by this. Is there something that can be adjusted upstream to address your concern? lighttpd is available as a package in many distros.

Hi Glenn,
This is more of a poorly worded comment on my part.  As far as lighttpd itself, I had absolutely no issues building and getting it up and running.  It integrated quite nicely with my script and did exactly what its great at, serving static content at light speed!
The root of my removal is based on lighttpd not being included in the base repos of many distros; my biggest concern being RHEL specifically.  Certain customers where I have employed earlier versions can not utilize EPEL or other repos.  For pure simplicity sake and "mainline" compatibility I've decided to proceed with Apache HTTPD in current development.
I will likely include lighttpd as an alternative option, chosen at install in a future release.
Again, apologies for the poorly worded comment, sometimes you forget other people may actually be out there listening when you mumble to yourself! Really appreciate you reaching out, no action needed by lighttpd team at this point.


[Container] az container create: Add new parameters for container security context for confidential ContainerGroupSku

Related command

az container create
Description

This PR:
upgrades azure-mgmt-containerinstance to 10.1.0
Adds Container security context properties for confidential ContainerGroupSku:

privileged: run the container as a privileged container
allow-privilege-escalation: allow containers to be run with elevated privileges
run-as: run container process as a user
run-as-group: run container process as a user group
seccomp-profile: base64 encoded seccomp profile
add-capabilities: list of capabilities to be added
drop-capabilities: list of capabilities to be dropped

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Container

I tried recording the test test_tag_update_by patch under command_modules/resource by running azdev test test_tag_update_by_patch, but the test was failing with error "CLIError: Please run az login to setup account",  even after running az login, and also when I tried removing the recording so that the test is run during CI tests.

I looked at the context and found that a dummy context is being passed to the method, which has SubscriptionId=None.

@fnuarnav I cannot reproduce your issue locally. Can you try using az login  to login first, and then use az account show to check the subscription being used and then execute azdev test test_tag_update_by_patch --live to re-record the yaml file?

@fnuarnav Could you please fix these CI issues?

@fnuarnav Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 07-04)

I tried recording the test test_tag_update_by patch under command_modules/resource by running azdev test test_tag_update_by_patch, but the test was failing with error "CLIError: Please run az login to setup account", even after running az login, and also when I tried removing the recording so that the test is run during CI tests.

I found that the issue with recording tests was caused by PR #25689
class TagScenarioTest(ScenarioTest):

    def __init__(self, *arg, **kwargs):
        super().__init__(*arg, random_config_dir=True, **kwargs)

The random config_dir can result in the inability to find the corresponding subscription configuration when recording tests in live mode.

how did you work around the random_config_dir=True issue, by temporarily removing it?

@jiasli Yes, since it is not related to the business logic we are testing, so I removed it temporarily to quickly unblock our recording


Add GetRows to retrieve unformatted cell values

This allows converting to time.Time without goint throguh the formatting and parsing steps.
Use the stored floating point number insted.
The only remaining step is a helper that decides whether the cell is a date or not (sth. like File.Styles.CellXfs.Xf[cell.S].NumFmtID IN (14, 15, 16, 17, 22)).
Checklist

[x] My code follows the code style of this project.
[-] My change requires a change to the documentation.
[-] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[-] I have added tests to cover my changes.
[x] All new and existing tests passed.

Shall I update this? Is there any possibility that this may be merged or at least reviewed?

Hi @xuri, shall I update this?

Hi @tgulacsi, thanks for your PR. I need some time to review.

Codecov Report

Merging #621 into v2 will increase coverage by 1.11%.
The diff coverage is 85.18%.

@@            Coverage Diff             @@
##               v2     #621      +/-   ##
==========================================
+ Coverage   95.52%   96.63%   +1.11%
==========================================
  Files          31       30       -1
  Lines        8379     8948     +569
==========================================
+ Hits         8004     8647     +643
+ Misses        226      187      -39
+ Partials      149      114      -35

Impacted Files
Coverage Δ

date.go
95.91% <0.00%> (-4.09%)
:arrow_down:

lib.go
100.00% <100.00%> (ø)

rows.go
95.80% <100.00%> (+0.96%)
:arrow_up:

col.go
100.00% <0.00%> (ø)

hsl.go
100.00% <0.00%> (ø)

chart.go
100.00% <0.00%> (ø)

merge.go
100.00% <0.00%> (ø)

shape.go
100.00% <0.00%> (ø)

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89465f4...49602d3. Read the comment docs.

Hi @tgulacsi thanks for your PR, and sorry for my so late reply. I suggest adding an option for columns and rows iterator, to support specified if apply number format, instead of adding the new function RawColumns, so I'll close this.

Ok, I can add a "rawValues bool" to Cols, Rows, rowsXMLIterator & co. structs, but how to allow setting these parameters?
Export them, or add a "SetRawOption(bool)" method to them?

Hi @tgulacsi, I've added optional parameters for the  GetCellValue, GetRows, GetCols, Rows, and Cols, to support specific read cells with raw value, please try upgrade to the master branch. For example, disable apply number format on get rows:
rows, err := f.GetRows("Sheet1", excelize.Options{RawCellValue: true})

Thanks, that's perfect!


Bugfix: Recent CSM refactor was causing some metrics to not be emitted. Fixed -restore-time metric.

Addressed all comments.


Remove patching class ExpensiMark with an object

Currently, we need to patch expensify-common/lib/ExpensiMark.js to convert class ExpensiMark into a single object because Hermes does not support ES Classes (https://github.com/facebook/hermes/issues/685#issuecomment-1784172071).
In particular, we had to make the following changes:

Remove class keyword:

-export default class ExpensiMark {
+export const ExpensiMark = {

Rename constructor to initializer:

-    constructor() {
+    initializer() {

Add commas after method definitions:

-    }
+    },

It would be better to use a Babel plugin to automatically convert class ExpensiMark into something that Hermes can deal with.

Done in https://github.com/Expensify/react-native-live-markdown/pull/360


Is there a best way to create an instance of reqwest::Error?

I'd like to create an instance of reqwest::Error to get my code coverage up to 100% in unit tests.  Is there a "best" endpoint to do that?  I can't find any from-type functions that allow me to do this easily.

No, there isn't a public constructor. So far, that's been by design.

That's fine.  For future googlers, I did find a bad solution just now, request::Identity::from_pkcs12_der(&[], "").unwrap_err();.  This is not ideal, but it's fine for a unit test that just needs an object of that type to exist.

🙈