feat: dynamic config(override)

What is the purpose of the change
Refactor the full functionality of dynamic configuration with Go.
Brief changelog

Add override and dynamicConfig model definition.
Add override service interface and impl of CRUD, enable and disable.
Add corresponding controllers and routes.

Verifying this change
XXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

Codecov Report

Merging #1032 (80ac5c9) into refactor-with-go (b465a02) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1032      +/-   ##
====================================================
- Coverage             82.73%   82.42%   -0.31%
====================================================
  Files                    13       13
  Lines                   973      973
====================================================
- Hits                    805      802       -3
- Misses                  130      132       +2
- Partials                 38       39       +1

see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Clarify hypophosphorous acid example

Line 261  gives subavalence as 3. This should be a valence of 3 (2 + 1 = 3). Clean up the entire paragraph.

Closed by 245cffc46ddf21f0b86e48a1c251e3feddd9e36d


Fixed req.user null reference when route does not use restrict middleware

Related to #578

Ok, I've been looking at it and it seems good. I found a weird bug but it probably doesn't have to do specifically with this; so I'll write different issue for that.


Unable to load scene from LuxCoreUI

I am not able to open the Cornell scene that comes with the standalone package:
The following error is displayed:
LuxCoreUI v2.0 (LuxCore demo: http://www.luxcorerender.org)
[LuxCore][19.750] Configuration:
[LuxCore][19.766]   film.width = "512"
[LuxCore][19.766]   film.height = "512"
[LuxCore][19.766]   image.filename = "cornell.png"
[LuxCore][19.766]   scene.file = "scenes/cornell/cornell.scn"
[SDL][19.766] Reading scene: scenes/cornell/cornell.scn
RenderConfig loading error:
Unable to open properties file: scenes/cornell/cornell.scn
I am on Window 10 64 bits.

The file paths inside the scene files are set up to work with the following command:
./bin/luxcoreui scenes/cornell/cornell.cfg
If you load the scene from the menu, luxcoreui will unable to find the scenes/cornell/cornell.scn because the current directory is "scenes/cornell" instead of ".".


Updating model generates wrong SQL Query

I am using activerecord (5.1.4) and active_dynamic (0.5.8) and suddenly when updating/saving my model I get the following error:
ActiveRecord::StatementInvalid: PG::UndefinedTable: ERROR:  missing FROM-clause entry for table "attribute"
LINE 1: ..._dynamic_attributes"."customizable_type" = $2 AND "attribute...
                                                             ^
: SELECT  "active_dynamic_attributes".* FROM "active_dynamic_attributes" WHERE "active_dynamic_attributes"."customizable_id" = $1 AND "active_dynamic_attributes"."customizable_type" = $2 AND "attribute"."id" = $3 AND "attribute"."customizable_id" = $4 AND "attribute"."customizable_type" = $5 AND "attribute"."name" = $6 AND "attribute"."display_name" = $7 AND "attribute"."datatype" = $8 AND "attribute"."value" = $9 AND "attribute"."required" = $10 AND "attribute"."created_at" = $11 AND "attribute"."updated_at" = $12 LIMIT $13

As you can see, within the query it uses the table alias attribute instead of active_dynamic_attributes. The error does not appear on new records only on existing ones.

OK, I'm closing this to inactivity.


Include link to GitHub on homepage

This is already done it seems. (The 'fork me on github' thing)
This issue should have been closed.


Add support for data converters needed by attention RNN models

AFAICT, attention-based models (#10)  are using encodings not currently supported by magenta-js converters:

Melody attention_rnn uses a KeyMelodyEncoderDecoder with attack, ascending/descending, lookback, and a binary clock.
Drums RNN uses a one-hot multi-drum encoding with a binary clock

Adding appropriate DataConverters for these seems straightforward enough, but how can we also have the appropriate information in the model converter.jsons so the right ones will be picked?

How about we add something like nextInput to the DataConverters that
concats all the additional info. Would this work? I haven't had a chance to
look back at the old code.
On Sat, Apr 7, 2018, 7:44 AM Adam Roberts<EMAIL_ADDRESS>wrote:

Oh wow, yes I had forgotten about that.
I actually wonder if we should just retrain these without the special
inputs since they may not actually be all that important. I can try to do
that at some point this weekend.
If you don't think it's hard to implement, then you could go for it. We
can just change the converter.json file.
Sorry this is turning out to be more complicated than I'd thought!
On Sat, Apr 7, 2018, 3:47 AM Tero Parviainen<EMAIL_ADDRESS>wrote:

AFAICT, attention-based models (#10
https://github.com/tensorflow/magenta-js/issues/10) are using
encodings not currently supported by magenta-js converters:

Melody attention_rnn uses a KeyMelodyEncoderDecoder
https://github.com/tensorflow/magenta/blob/master/magenta/models/melody_rnn/melody_rnn_model.py#L169
with attack, ascending/descending, lookback, and a binary clock.
Drums RNN uses a one-hot multi-drum encoding
https://github.com/tensorflow/magenta/blob/master/magenta/models/drums_rnn/drums_rnn_model.py#L86
with a binary clock

Adding appropriate DataConverters for these seems straightforward
enough, but how can we also have the appropriate information in the model
converter.jsons so the right ones will be picked?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/magenta-js/issues/14, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCa6O1Q4mkf7Frxs8Rpf0VZmqcHCaUqks5tmJlagaJpZM4TLCJ1
.

If you don't think it's hard to implement, then you could go for it. We can
just change the converter.json file.

I'll try with the drums one as I'm already familiar with it. Just needs the 2^9 one-hot encoder and then the binary counter.

How about we add something like nextInput to the DataConverters that
concats all the additional info. Would this work? I haven't had a chance to
look back at the old code.

I think it should be possible to compose DataConverters similar to how encoders are composed in Python. Will need to try. Not sure how to express this in the converter.json though. Would need to specify either an array of converters, or then just introduce new types for each composed version e.g. MultiDrumOneHotBinaryCounterConverter :)

I see your point. One option could be to add a pipe character to the type
field in the spec and add an new ConverterArgs type that is composed of 2
different args.
The other is just to add these two specific converters and be done with it
since I don't foresee us adding others like this in the future.
On Sat, Apr 7, 2018, 8:46 AM Tero Parviainen<EMAIL_ADDRESS>wrote:

If you don't think it's hard to implement, then you could go for it. We can
just change the converter.json file.
I'll try with the drums one as I'm already familiar with it. Just needs
the 2^9 one-hot encoder and then the binary counter.
How about we add something like nextInput to the DataConverters that
concats all the additional info. Would this work? I haven't had a chance to
look back at the old code.
I think it should be possible to compose DataConverters similar to how
encoders are composed in Python. Will need to try. Not sure how to express
this in the converter.json though. Would need to specify either an array
of converters, or then just introduce new types for each composed version
e.g. MultiDrumOneHotBinaryCounterConverter :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/magenta-js/issues/14#issuecomment-379478805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCa6B3Bb959gkPjeSFrgdvfkPG0fpu2ks5tmN8xgaJpZM4TLCJ1
.

The current plan is to remove the case of having dependencies between the inputs and outputs aside from the one-hot sample. We will only allow an independent control sequence to be concatenated (#20).
I am going to try training an attention melody model without these dependencies to see how it compares.

I will add a

Covered by #11


Instagram Black Bar

Instagram has black bar when in light mode

This has been fixed in Version 1.5.0


Progress Indicator: Add vertical orientation

orientation="vertical"

New example file would be best. Add existing storybook story to this array and https://github.com/salesforce/design-system-react/blob/master/components/progress-indicator/docs/site-stories.js#L1

I am on it. @interactivellama

@pulkonet My designer is saying that the italics and bold text should be removed, too.


VM Demo Bug Fixes

Description
Fixes the following issues from this Doc:

The “All Entities” dropdown has duplicates for “Node Components” and “Image Components”
The columns in the tables should specify what CVE type it is
The Top Riskiest Images+Nodes Widget’s links still take you to the non-split CVEs table
Image CVEs page - click image components for a row -> fails - calling component count and not imageComponentCount
Node CVEs -> click a Node CVE -> click on Node Component related entity -> Breaks
Platform CVEs -> click on a Platform CVE -> Breaks UI
Image Components -> click an Image Component -> The Component Findings breaks
Images -> click an Image -> click an Image CVE in Image Findings -> Click on Image Components related entities -> Breaks

Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

Testing Performed
The “All Entities” dropdown has duplicates for “Node Components” and “Image Components”

The columns in the tables should specify what CVE type it is

The Top Riskiest Images+Nodes Widget’s links still take you to the non-split CVEs table

Image CVEs page - click image components for a row -> fails - calling component count and not imageComponentCount

Node CVEs -> click a Node CVE -> click on Node Component related entity -> Breaks

Platform CVEs -> click on a Platform CVE -> Breaks UI

Image Components -> click an Image Component -> The Component Findings breaks

Images -> click an Image -> click an Image CVE in Image Findings -> Click on Image Components related entities -> Breaks

Will feature flag the columns on Monday and double check everything works

/retest

@vjwilson @pedrottimark were these the tests you noticed that were failing? https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/stackrox_stackrox/2433/pull-ci-stackrox-stackrox-master-gke-ui-e2e-tests/1549500230712430592
I don't think this PR affects these, so I'll merge my changes


chore: added OpenSSF Scorecard badge

Added scorecard badge. Related to #235 implementation

Thanks for the contribution @UlisesGascon


Fix broken API unit tests

We've recently refactored a number of methods in the project and this has undoubtedly lead to some broken unit tests

I'll jump on this


scanning... iOS Bluetooth device name / advertisementData.localName may be incorrect...

This problem is for iOS only. I'm testing on iOS 14.0.1. Android gets the names correctly. Here is an example
2021-08-10 18:15:45 +0000 SwitchDiscovery.setScanResults/D:	ScanResult{device: BluetoothDevice{id: F72DE1B4-8E13-6EA3-475E-F8D93B6DF141, name: BlueZ 5.50, type: BluetoothDeviceType.le, isDiscoveringServices: false, _services: [], advertisementData: AdvertisementData{localName: AP-Texas-QA-4K-1.08-801, txPowerLevel: null, connectable: true, manufacturerData: {}, serviceData: {}, serviceUuids: []}, rssi: -65})
Note: The device name is BlueZ 5.50 and the  AdvertisementData localName is AP-Texas-QA-4K-1.08-801.
This is the debug output from Android.
ScanResult{device: BluetoothDevice{id: 34:C9:F0:83:16:04, name: AP-Texas-QA-4K-1.08-801, type: BluetoothDeviceType.le, isDiscoveringServices: false, _services: [], advertisementData: AdvertisementData{localName: AP-Texas-QA-4K-1.08-801, txPowerLevel: null, connectable: true, manufacturerData: {}, serviceData: {}, serviceUuids: []}, rssi: -68}
Note: Both the device name and the  AdvertisementData localName is AP-Texas-QA-4K-1.08-801.
We look at the device name to determine if it might one our network packet broker switches advertising over BLE.
Flutter 2.2.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision f4abaa0735 (6 weeks ago) • 2021-07-01 12:46:11 -0700
Engine • revision 241c87ad80
Tools • Dart 2.13.4
flutter_blue:
dependency: "direct main"
description:
name: flutter_blue
url: "https://pub.dartlang.org"
source: hosted
version: "0.8.0"
Here is snippet of how that output was created
  void setScanResults(AsyncSnapshot<List<ScanResult>> snapshot) {
    logger.d('enter ${snapshot.data?.length ?? 0} async $_inAsyncCall');
    for (ScanResult r in results) logger.i(r.toString());
  }

I will post more detailed ScanResults lists in two separate files (iOS and Android).

android scan.txt
This is the results of the scan on android

ios scan 1.txt
This is the results of a bad scan on iOS. The problem is intermittent (Maybe 50/50).

android scan.txt
This is the output from android.

ios scan 1.txt
This is the results of a bad scan on iOS.

Why does Android get the correct name but not iOS?

Is this the same as https://github.com/pauldemarco/flutter_blue/issues/524?

As a work around I am only using the advertisement localName instead of the device name to recognize our switches and show that name in our mobile app GUI. I am still clueless as to why the device name is what we expect on Android and not what we expect on iOS.

Is there any update about this issue? For a BLE device (esp32) I am using, the advertismentData.localName is always empty and device name cannot show properly the first time on the iOS.

@bruce-qingwu, same with me. I found the initial scanning result is name is empty and might be taking some milliseconds to fetch the name. This works for me you can check.
https://github.com/pauldemarco/flutter_blue/issues/524#issuecomment-1118866250


Move ARM swagger to subfolder

Which issue this PR addresses:
The PR prepares the ARORP ARM API for the inclusion of HCP RP in the ARM manifest folder.
It moves the files to openshiftclusters subfolder and updates automatic generation accordingly.
Fixes
What this PR does / why we need it:

Test plan for issue:

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?

/azp run ci

/azp run ci

Closing. This PR has been moved to #3805


Is there an option to bring two vertical crosshairs in the chart and set it in the chart ?

Is there an option to bring two vertical crosshairs in the chart and set it in the chart?
In Time Series Insights(MS Azure TSI - Time Series Insights), we have two vertical crosshairs which are set in the chart and displays the data points of two different time series in the same chart. Do we have any similar options here to set two vertical crosshairs in the chart?
Appreciate the assistance in advance. Thanks!

You would need a plugin for that such as https://github.com/abelheinsbroek/chartjs-plugin-crosshair


Changing the UI font

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


add page on apps

@dougoldenburg , @fourndo : can you take a look and see if this makes sense? I will merge to master quickly so it is live and you can see it from the web. Thanks!

I think it's great. Glad that you showed the Run All button, makes things easier for them


[BUG] Oban metric [:prom_ex, :plugin, :oban, :queue, :length, :count] is not fetching queue states when length is 0

Describe the bug
At my company when creating a chart for when some queue gets zero jobs executing after some time I faced that Oban is not sending when a queue state reaches the number 0
Running the same query that we run to fetch queues grouped by state I could see a pattern like this:
Example:
Queues: create_order and deliver_order
After creating an order the job gets completed and triggered to deliver, so the response of the query will be:
[
  {"create_order", "executing", 102},
  {"create_order", "completed", 16087},
  {"create_order", "discarded", 3030},
  {"deliver_order", "executing", 2535},
  {"deliver_order", "discarded", 116}
]

After some time my program will finish the creation and I'll have:
[
  {"create_order", "completed", 16187},
  {"create_order", "discarded", 3030},
  {"deliver_order", "executing", 2535},
  {"deliver_order", "discarded", 116}
]

So, I'm interested to understand when the queue create_order in the state executing gets 0 but it's not possible since this metric is implemented as last_value (implementation) and we are keeping the last value of the last pooling round (ex: 5 seconds before finishing the creation the value was 10).
To Reproduce
Steps to reproduce the behavior:

Add the following plugins to PromEx: Oban
Create some application with one queue at least (could be the queue default)
Create a job with a sleep of 5 seconds for this queue and trigger it once
After 15 seconds (to force overlap one polling window) check in the /metrics about the state of the queue default for the state executing and you will see the value 1 even the job has the state completed

Expected behavior
I expected that for all possible Oban Job states ([:scheduled, :available, :executing, :retryable, :cancelled, :completed, :discarded]) the PromEx Oban plugin sets as 0 if the state wasn't found into the database, avoiding the wrong value set into the last_value metric.
Environment

Elixir version: 23.2.3
Erlang/OTP version: 1.13.1-otp-23
Grafana version: Not needed
Prometheus version:  Not needed

Additional context

Suggesting a possible solution:
After fetching all queue states from the database, using the function Oban.states() for each queue we can set as 0 for states didn't find, for example, for the queue create_order we se the state executing as 0 after don't have any job executing.
I can open a PR if it's reasonable.


Get all available rooms?

Is there any way to get all the rooms that can be joined?
As far as I can see, you can only check the presense of a room if you already know the id. Is there a way to just get all joinable room id's? This would make it possible to create some kind of lobby for games using RTCMultiConnection.
If this is not possible, is there a reason why not? Otherwise it might be a good addition.

Please check this demo, which shows list of all public rooms:

https://rtcmulticonnection.herokuapp.com/demos/getPublicModerators.html


Added support for custom fonts

Thanks for a great library! One of my project's requirements was to customize the fonts. Thanks!

Hi @martinrybak
Thanks for this trying.
Firstly, I didn't see default values for all the 'fonts', which means [UIFont fontWithName:nil size:xx] might happen which we both know that shouldn't.
Secondly, I'd like to use UIFont or other more standard way, just hobbies.
Anyway, I really appreciate it. Thanks again.

Thanks for getting back to me! The reason why I went with string font name was to be compatible with the existing font size properties. Would you prefer me to replace them both with a combined font property?

The reason I didn't open the font property is that, if you choose a custom font, which might be a 'ttf' file, sometimes the font would not be 'centered' due to a bad 'baseline'. It doesn't usually happen, but I need to find a solution before adding the typeface property.

Ok. In the meantime, if I keep the font names as strings and return a default font in case they are not set, would that work for you?


Enable resource group location to be configurable by a configuration file

Similar to https://github.com/Azure/azure-cli/issues/4665 right?

Related.

Use #4665 as the main issue to track


Add container image

🎉 This PR is included in version 0.1.0 🎉
The release is now available here
Thank you for your contribution. ❤📦🚀


etcd3locker: Update formatting of docs; timeout -> ttl substitution

I saw that godoc didn't render my documentation within the code very well so I fixed up the formatting in the hopes that things look better now.
In addition, I saw various instances of timeout and ttl when it should be ttl so I did a quick correction of places that had sessionTimeout / timeout to make it all consistent.

Wow, thank you very much for the quick updates :)


Add try-catch, for, while, while do, and enum, and fix if

Hi! Was working on Helix support for the queries when I realized the grammar hadn't implemented these structures. Figured I'd have a go at it. First time playing around with treesitter so things probably aren't ideal but it mostly works. I still also need to get tests passing and write some tests

There's some odd behavior where  when trying to do the range operator on two ints, it think's it's a float:
1...5 would give (float) instead of ( (integer)  (integer))

I have also yet to figure out the best way to do array comprehension, accounting for while, do while and for, and also making sure that nested comprehension works as well

it may be worth looking into https://tree-sitter.github.io/tree-sitter/creating-parsers#external-scanners for the range operator, the regex for the floats would be hard to get right

"fixed" the range expression for now. Still really confused on how to deal with the conditional operator thing

Instead of having specific constructs for array comprehensions, perhaps for/while should be allowed as a generic "expression" element, and expressions should be allowed within [ ].

There's some odd behavior where when trying to do the range operator on two ints, the grammar thinks it's a float:
1...5 would give (float) instead of ( (integer) (integer))

Fixing this regex may solve the float problem:
https://github.com/vantreeseba/tree-sitter-haxe/blob/12e814cd9b0656b0eaa3e04b0036b3b6625cc0d7/grammar-literals.js#L12
Right now it accepts any number of . >= 1.


Security alert

I get security alert in my project on github

Vulnerable versions: < 4.0.0
Patched version: 4.0.0
In nodejs-mem before version 4.0.0 there is a memory leak due to old results not being removed from the cache despite reaching maxAge. Exploitation of this can lead to exhaustion of memory and subsequent denial of service.

Because 1.9.0 uses<EMAIL_ADDRESS>yargs > os-locale ><EMAIL_ADDRESS>

@dxvladislavvolkov This is an issue with mem. Would be better to open an issue there.
Also, I'm assuming this would only be an issue when running the cli (yargs parses cli args). The cli is not a long-running program, so a memory leak should not pose any real threat.

@dxvladislavvolkov The solution to this is to update yargs. Yargs no longer requires os-locale (even though mem has solved this issue in 4.0.0).

I have made a PR (#738) to fix this issue

Closes #728

Thank you. Merged and updated. New release 1.9.1 has the dependency updated.


Adjusted docker compose section

I switched the position of  ADMIN_USERNAME and ADMIN_PASSWORD.
For once it took me 2h to figure out that I changed the username and not the password.
For second it is now in the same schema as the other section where a compose file is shown.

@flippy1345

After tried with your changes  . I got the Exited(1) error.
Can you please tell me the steps to do configuration and also run docker ?
Also which docker version are you using?

@vipin-shrivastava

I adjusted the order of for ADMIN_USERNAME and ADMIN_PASSWORD in the README.md to match the in which order it is written in other section in the README.
I created a stack in portainer and deployed the container.
Docker version on my server:
:~$ docker version
Client:
 Version:           20.10.2
 API version:       1.41
 Go version:        go1.13.8
 Git commit:        20.10.2-0ubuntu1~20.04.2
 Built:             Tue Mar 30 21:24:57 2021
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

The error cannot be related to this simple change. Looks sensible to have username first then password! Good work!


Utilization: Add Disk Usage chart

and refactor prometheus queries for disk capacity so they
can be reused for utilization.
Depends on: https://github.com/kubevirt/web-ui-components/pull/322

Ceph metrics aligned with https://github.com/kubevirt/web-ui/pull/273


Random Error on ContentCodingSpec test

[error] ! order.eq antisymmetry (51 ms)
[error]  org.scalacheck.Gen$RetrievalError: Exception raised on property evaluation.
[error]  > ARG_0: ContentCoding(compress, org.http4s.QValue@3e8)
[error]  > ARG_1: ContentCoding(compress, org.http4s.QValue@3e8)
[error]  > ARG_2: <function1>
[error]  > Exception: org.scalacheck.Gen$RetrievalError: couldn't generate value (Gen.scala:57)

I think this is still an issue.  This run has this change.

That seems to be in another test, i’ll Check it


Fix non regular sequence movement

#223 Introduced a bug, by adding the branch condition to move_lower and move_higher, the order is still changed but if you are using a before save callback to spy on position change, the position for the second element is the same as the original due to a mistake in lib/acts_as_list/active_record/acts/list.rb:221
Previously:
# lib/acts_as_list/active_record/acts/list.rb:74
def move_lower
  return unless lower_item

  acts_as_list_class.transaction do
    if lower_item.send(position_column) == self.send(position_column)
      swap_positions(lower_item, self)
    else
      lower_item.decrement_position
      increment_position
    end
  end
end

This condition is checking that booth elements don't have the same position.
This changed behaviour not only for non regular sequence positions, but for all elements that don't have the same position, I argue this should only be entered for elements with a absolute distance between them bigger that 1.
Elements with a pair of positions [1,2] and  [1,5] will enter this condition, was this on propose?
swap_position doesn't do the same as the other part of the conditional branch for elements with positions 1 and 2.
# lib/acts_as_list/active_record/acts/list.rb:219
def swap_positions(item1, item2)
  item1.set_list_position(item2.send(position_column))
  item2.set_list_position(item1.send("#{position_column}_was"))
end

item1.send("#{position_column}_was") returns the same as item1.send(position_column) so my proposed solution it's to store item1 original position in a variable before we change it's position.

Hi @tiagotex, thanks for looking into this. Does assert_equal [5, 10, 15, 20], ListMixin.where(parent_id: 5000).map(&:pos) fail without your patch?
I must say I don't quite get the gist of your issue unless you're saying that our test coverage wasn't complete (not surprising! :smile:), and wasn't catching that _was wasn't returning what was required.
I'm happy to accept the change since it's fairly straightforward but would like to get a better understanding of what the problem was :)

@brendon  No,
assert_equal [5, 10, 15, 20], ListMixin.where(parent_id: 5000).map(&:pos)
is only to assert the initial state.
ListMixin.where(id: 2).first.move_lower
assert_equal [1, 3, 2, 4], ListMixin.where(parent_id: 5000).order('pos').map(&:id)
assert_equal [5, 15, 10, 20], ListMixin.where(parent_id: 5000).map(&:pos)
# before the change this would return [5, 11, 10, 20]

I think I digressed to much in my explanation.
The real problem that brought me to this discover was that my tests would fail because we hook into a before save callback and log the new position, and since item1.send("#{position_column}_was") was returning the same as item1.send(position_column) this would break the logs. I think it's easier if we look at code:
# when sending item1 with position 1 and item2 with position 2
def swap_positions(item1, item2)
  # item1.send(position_column)          => 1
  # item2.send(position_column)          => 2
  item1.set_list_position(item2.send(position_column)) # => item1.set_list_position(2)
  # item1.send(position_column)          => 2
  # item2.send(position_column)          => 2
  # item1.send("#{position_column}_was") => 2
  item2.set_list_position(item1.send("#{position_column}_was")) # => item2.set_list_position(2)
end

As you can see in item2.set_list_position we should send the previous position of item1 but we send the current position.
In the new implementation:
# when sending item1 with position 1 and item2 with position 2
def swap_positions(item1, item2)
  item1_position = item1.send(position_column) #=> 1
  # item1.send(position_column)          => 1
  # item2.send(position_column)          => 2
  item1.set_list_position(item2.send(position_column)) # => item1.set_list_position(2)
  # item1.send(position_column)          => 2
  # item2.send(position_column)          => 2
  # item1_position                       => 1
  item2.set_list_position(item1_position) # => item2.set_list_position(1)
end

I would like to do some more researching into acts_as_list to verify we don't have more inconsistencies but this patch could be merged for now, since I don't think I'm the only one who encountered this problem and this change in behaviour was introduced in a minor version unintentionally.

Thanks @tiagotex, that makes more sense. The strange part is why the _was isn't working as expected. I suspect that because the record is saved, the _was value goes away?
def set_list_position(new_position)
  write_attribute position_column, new_position
  save(validate: false)
end

Or is it something to do with (validate: false).
Anyway, there's no harm in caching the value locally instead of using the dirty functionality.
Just looking at the documentation, we should probably have accessed .previous_changes.


Don't use this plugin!

This morning we received an email directly from Google Play with this content

Better not to use this plugin anymore.

Yes I also face same issue and app is removed from the store don't use this plugin now ionic should have to remove this from their documentation as soon as possiable

Also an app I develop has been removed from the store for the same reason.
But I still need this plugin to autoupdate some custom devices running my app. I will install the App directly from a private Server and autoupdate from there.
So the plugin is still very useful.

Please use this, I need some stars :sweat_smile:
https://github.com/kolbasa/cordova-plugin-apkupdater

Wish I should have stepped in here before installing the plugin, it's too late my App is removed from the play store, not sure if they are going to listen to Appeals. Ionic should not have recommended this plugin for its users when such a violation is caught by bots why not caught during the build process, is that intentional? Very pathetic for App developers

Lucky for me, I found this link, I was already implementing it.
And as for cordova-plugin-code-push, will it also be blocked.

why do you guys need a plugin to update your app if you are already using play store?

Lucky for me, I found this link, I was already implementing it.
And as for cordova-plugin-code-push, will it also be blocked?

Hey can anyone here tell what worked for them . I need to implement auto app  update in ionic capacitor . Thanks in advance.

Shameless plug
Hey folks, not the plugin author, but if you're looking for alternatives that do not violate any google/apple app store policies, perhaps checkout Appflow.
https://ionic.io/appflow

Apparently the best option is to use the In-App Update API from this cordova plugin which allows both Flexible and Immediate updates from Play Store.

@andreszs can I use it to get the apk from my own server ?


update rc2.2

PTAL @iamxy @shenli

It seems that the failure of test_rpc_client is caused by using the latest PD which is already switched to gRPC.

LGTM

LGTM


Link method for RouterResponse

Description
Added link method for RouterResponse class.
Motivation and Context
IBM-Swift/Kitura#311
How Has This Been Tested?
Added a test in TestResponse.swift file that checks received Link header value for both single and multiple links.
Checklist:

[x] I have submitted a CLA form
[ ] If applicable, I have updated the documentation accordingly.
[x] If applicable, I have added tests to cover my changes.

Hey @naithar, sorry for the delay, we have been discussing this PR internally. The issue is that if you look at the spec for Link (https://tools.ietf.org/html/rfc5988) you can see that it can take in a lot more parameters than ref. After looking at the implementation of Link in JAX, and seeing some PRs for changing Link functionality in Express, we decided that we should support all options.
Therefore we propose that the Link function will instead take in one link at a time, and have all possible values for link be accepted as nil default optionals.
The new signature will be something like func link (_ link: String, rel: String? = nil, anchor: String? = nil, title: String? = nil, type: String? = nil, media: String? = nil)

@dfirsht, thanks for the info. I'll change the implementation then.

@dfirsht please review

Looks great! Thanks @naithar


Accept association-insertion-node as a function

The problems I found is,

Currently it's not possible to add partials to a arbitrary location in dom. Especially when the dom structure is complicated, or having deeply nested forms.

data-association-insertion-traversal is qute confusing as the issue #102 says.

This pull request adds a feature to let users pass a function as data-association-insertion-node, and let them specify whatever node they want to. Like this we don't need data-association-insertion-traversal anymore. (See updated README for an example)
Also added warning log when the specified data-association-insertion-node is not found, to make it bit more user friendly.
Please review and merge if it looks good :)

Nice work. However, I do not like the fact you did not make it backward compatible. I get why you would not, but why break the behaviour for current users? Your new behaviour could easily just be extra, as it is easy to see if the data-association-insertion-node is a function. If not: old behaviour, otherwise: use the function.

Agreed with the backward compatibility, and restored the data-association-insertion-traversal.
Also added an example case in README.
Please review.

Awesome work! Thanks!

I will release the gem this evening ;)

Thanks!

Either I'm missing something or this function option just not working?
The function being sent in association-insertion-node will always be considered a string, never a function
Using Jquery version 1.11.1
First getting the data attribute: cocoon.js line 47
insertionNode = $this.data('association-insertion-node')
meaning insertionNode is always a string!
Then inside function getInsertionNodeElem: cocoon.js lines 23-28
Check if it somehow turned into a function:
if (typeof insertionNode == 'function')
  // Never reach here

But typeof insertionNode was and will remain a string...

You have to set the association-insertion-node programmatically, as is demonstrated in the README. So to keep it simple let me re-iterate the example here:
$(document).ready(function() {
    $(".add_sub_task a").
      data("association-insertion-method", 'append').
      data("association-insertion-node", function(link){
        return link.closest('.row').next('.row').find('.sub_tasks_form')
      });
});

Or did you try that and it did not work?

I didn't try it. That must be it- Thanks.
Truth be told I didn't understand that part- I do now lol.
I suggest adding a link to in the following readme section, near the function reference:
Picture following text:
Picture example

Text example
So instead of
data-association-insertion-node : the jquery selector of the node as string, or a function that takes the link_to_add_association node as the parameter and returns a node. Default: parent node
Use this:
data-association-insertion-node : the jquery selector of the node as string, or a function (see below) that takes the link_to_add_association node as the parameter and returns a node. Default: parent node


feat(sdk): add update issue method

This method is needed for MD-6326 which involves change of responsible Adviser

@IamAbbey how about adding a unit test or is this code path already covered?

@IamAbbey how about adding a unit test or is this code path already covered?

Right now we're testing only get_* methods. Update methods are not covered because they return the same result as corresponding get_* method for the same type of object and have almost no logic inside.

@IamAbbey how about adding a unit test or is this code path already covered?

Right now we're testing only get_* methods. Update methods are not covered because they return the same result as corresponding get_* method for the same type of object and have almost no logic inside.

Well, maybe all the more reason to test both together - if they are almost equivalent this should be easy.

Well, maybe all the more reason to test both together - if they are almost equivalent this should be easy.

@IamAbbey Could you please add a test for update_issue similar to existing one for get_issue? The create a new PR to add missing tests for other methods.


Add Binder badge to the README

So it will be easier to try the extension in the browser.
Next step would be to add JupyterLite :)

Ah looks like the Binder does not build:

We can fix it separately, probably by adding a .binder/environment.yml with node=18 in it.

thanks!

unfortunately it is still not working on binder  #6


Remove version: Jackett.Jackett version 0.21.1832

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.21.1832/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 918)


[documentation] "duration_ms" is not working with trigger_mode: STOP_TRACING

Using 'duration_ms' config param will lead to immediate termination of trace session. But it's  mentioned in:

https://github.com/google/perfetto/blob/master/docs/concepts/config.md
compiled HTML version https://perfetto.dev/docs/concepts/config

So far it looks like that when stop trigger is used, duration is calculated as:
trigger_config.trigger_timeout_ms + trigger_config.triggers.stop_delay_ms
Please update the documentation, I've spent several hours to make stop trigger behave as intended ‼

Yes that looks wrong, will send a patch for that. Thanks!
Hector

@chromy btw, what is the best way to contribute? can I create a PR to this repo? (I'm a bit confused with its R/O state).

@bagobor The contribution instructions are at https://perfetto.dev/docs/contributing/getting-started :) We use a Gerrit instance for code reviews: https://android-review.googlesource.com/q/project:platform%252Fexternal%252Fperfetto+status:open

@chromy

contribution instructions are at https://perfetto.dev/docs/contributing/getting-started
thanks, "Pull requests through GitHub are not accepted." :)

This should now be fixed :)


btn-group with radiobuttons does not change checked state of radiobutton when clicking button

example found here: https://getbootstrap.com/docs/4.0/components/buttons/
when clicking a button it doesn't change the selected radiobutton (input type=radio) it represents, only the active state of the label=btn
<div class="btn-group" data-toggle="buttons">
  <label class="btn btn-secondary active">
    <input type="radio" name="options" id="option1" autocomplete="off" checked> Radio 1 (preselected)
  </label>
  <label class="btn btn-secondary">
    <input type="radio" name="options" id="option2" autocomplete="off"> Radio 2
  </label>
  <label class="btn btn-secondary">
    <input type="radio" name="options" id="option3" autocomplete="off"> Radio 3
  </label>
</div>

it seems the  'checked' attribute does not change on plain radiobuttons when inspecting in chrome/firefox
so I think you can close this issue

The checked attribute means checked by default. This attribute won't change when the radio/checkbox is clicked.

yes, the attribute (which you see in DevTools inspector) won't change. you'd want to check the actual checked property of the node (which does seem to work fine from testing the example in the docs).


ARTEMIS-4355 Update Curator to 5.5.0

Why were the test changes necessary?

There were compilation errors because getQuorumPeer removed

[INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 188.484 s - in org.apache.activemq.artemis.tests.smoke.quorum.ZookeeperPluggableQuorumPeerTest

FWIW I ran the earlier version of this (cd5887b0e8) through the full test suite in another CI env and it rather fell over in a heap, failing various tests (even though in various cases they seem to have done what was expected), and timing out and being terminated overall. I didnt bother to re-run it (in case it was a sporadic env issue) since the PR had changed singnificantly by that point, and has now again.
I ran c64e2e31a6 through the full suite today though and it seemed ok, even if I do still question some of the actual behaviour changes being made.

Still not that sure of some of the changes, but they dont seem to break the tests, and it is past time these were updated, so...in they go.


Rename "Layer" to "Job"

Contributes towards https://github.com/google/ground-android/issues/1114

@JSunde  PTAL?

/gcbrun

/gcbrun

Codecov Report

Merging #1142 (6e0c213) into master (b34d1ce) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1142      +/-   ##
============================================
- Coverage     27.48%   27.47%   -0.02%
  Complexity      792      792
============================================
  Files           300      300
  Lines          8161     8157       -4
  Branches        349      349
============================================
- Hits           2243     2241       -2
+ Misses         5807     5805       -2
  Partials        111      111

Impacted Files
Coverage Δ

...le/android/gnd/ui/home/AddFeatureDialogFragment.kt
0.00% <0.00%> (ø)

...gnd/persistence/local/room/RoomLocalDataStore.java
72.58% <0.00%> (ø)

...nce/remote/firestore/schema/LayerNestedObject.java

...gnd/persistence/local/room/entity/LayerEntity.java

gnd/com/google/android/gnd/model/layer/Layer.java

gnd/com/google/android/gnd/model/layer/Style.java

.../local/room/relations/LayerEntityAndRelations.java

...stence/remote/firestore/schema/LayerConverter.java

gnd/com/google/android/gnd/model/job/Style.java
100.00% <0.00%> (ø)

...d/gnd/persistence/local/room/entity/JobEntity.java
100.00% <0.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34d1ce...6e0c213. Read the comment docs.


rhel.10: Enable secureboot

What this PR does / why we need it:
The latest guest images can now boot with secure boot enabled so reflect this in the base amd64 preference.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

The `rhel.10` preference now enables secureboot

/cherry-pick release-1.1

/lgtm


Possible parser error on subquery when you use hash format of where clause

Hello,
Here's 2 forms of exactly the same query that returns different results but the only difference is the format of where clause used in the subquery in querybuilder
Main Query
        $query1=(new \yii\db\Query())
            ->select(['question.id'])
            ->from('question')
            ->innerJoin('option', 'option.question_id=question.id')
            ->where(['not exists', $subquery1])
            ->groupBy('question.id')
            ->all();

Subquery Option A:
        $subquery1 = (new \yii\db\Query())
            ->select(['label'])
            ->from('option')
            ->where(['option.question_id'=>'question.id', 'option.mark'=>1]);

Subquery OPTION B:
        $subquery1 = (new \yii\db\Query())
            ->select(['label'])
            ->from('option')
            ->where('option.question_id=question.id AND option.mark=1');

Option A Generates;
SELECT `question`.`id` FROM `question` INNER JOIN `option` ON option.question_id=question.id WHERE NOT EXISTS (SELECT `label` FROM `option` WHERE (`option`.`question_id`='question.id') AND (`option`.`mark`=1)) GROUP BY `question`.`id`

OPTION B Generates;
SELECT `question`.`id` FROM `question` INNER JOIN `option` ON option.question_id=question.id WHERE NOT EXISTS (SELECT `label` FROM `option` WHERE option.question_id=question.id AND option.mark=1) GROUP BY `question`.`id`

The only real difference is the where clause in Option where 'question.id' is enclosed in quotes.
Both Queries return data but only option B match raw SQL possible because the parser maybe treating 'question.id' as a string.
Is my observation correct or is there a different way to pass a value in the hash format of the where clause without enclosing it as a string?

I guess things behave like expected.
If you want to avoid escaping, you need to write this way:
 $subquery1 = (new \yii\db\Query())
            ->select(['label'])
            ->from('option')
            ->where(['option.question_id'=> new \yii\db\Expression('question.id'),
                     'option.mark'=>1]);

@CedricYii,
I think your review of this issue was a bit on the surface.
My concern is primarily the need for consistency in the interface, why is 'option.question_id' parsed properly even though it is in quotes like 'question.id' but the later needs escaping?
A


question: how to handle multipart file upload

I am using codegen with graphql as a client. I struggle with uploading files. graphql supports MultipartFile upload (https://pub.dev/packages/graphql#graphql-upload) but i dont understand how to integrate this with codegen. How can i specify the scalar for the Upload type?
Do I have to wrap it in my own class to link it in the build.yaml or can i reference it directly? If so, how would this be done?

build.yaml
targets:
  $default:
    builders:
      json_serializable:
        options:
          include_if_null: false
      graphql_codegen:
        options:
          includeIfNullOnInput: false
          clients:
            - graphql
          scalars:
            DateTime:
              type: DateTime
              fromJsonFunctionName: dateTimeFromJson
              toJsonFunctionName: dateTimeToJson
              import: package:yourapp/scalars.dart
            JSON:
              type: Map<String, dynamic>
            Upload:
              type: MultipartFile
              fromJsonFunctionName: fileFromJson
              toJsonFunctionName: fileToJson
              import: package:yourapp/scalars.dart

lib/scalars.dart
import "package:http/http.dart";
export "package:http/http.dart";

String dateTimeToJson(DateTime data) {
  return data.toIso8601String();
}

DateTime dateTimeFromJson(dynamic data) {
  return DateTime.parse(data);
}

MultipartFile fileFromJson(dynamic data) {
  return data as MultipartFile;
}

dynamic fileToJson(MultipartFile data) {
  return data;
}

in code..
Future<bool> uploadImage(String fileNameId) async {
  final ImagePicker _picker = ImagePicker();
  final XFile? image = await _picker.pickImage(source: ImageSource.gallery);
  if (image == null) return false;
  print(image.path);

  var result = await _client.mutateUploadUserFile(
    OptionsMutationUploadUserFile(
      variables: VariablesMutationUploadUserFile(
        file: MultipartFile.fromBytes(
          "",
          await image.readAsBytes(),
          filename: fileNameId,
          contentType: MediaType.parse(lookupMimeType(image.path)!),
        ),
      ),
    ),
  );
  if (result.hasException) {
    print(result.exception.toString());
    await Sentry.captureException(result.exception);
    return false;
  }
  print(result.parsedData!.toJson());
  return true;
}

This is the way

thank you very much for the fast and precise answer! In the end i figured out that the scalar Upload was not defined in the schema and thats why it could not work :)

"Upload" is scalar, that must be devlared in scheme
f.e.:
"""The `Upload` scalar type represents a file upload."""
scalar Upload

type Mutation {
  uploadUserFile(file: Upload!): Resource!
  uploadUserMultipleFiles(files: [Upload!]!): [Resource!]!
}

mutation uploadUserFile($file: Upload!){
    uploadUserFile(file: $file){
        filename
        id
        mimetype
        type
        url
    }
}


unwanted backslashes replacement

Type: Bug
I asked about regex including backslashes. Something like : const sep = '[/\\\\]'
The answer is polluted with unwanted replacements of double backslashes by the workspace name.
The answer includes sentences like : my_workspace_name: This is a string that represents two backslashes
Extension version: 0.22.2024100702
VS Code version: Code 1.94.1 (e10f2369d0d9614a452462f2e01cdc4aa9486296, 2024-10-05T05:44:32.189Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info

Item
Value

CPUs
12th Gen Intel(R) Core(TM) i7-1265U (12 x 2688)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
undefined

Memory (System)
15.69GB (5.20GB free)

Process Argv
--crash-reporter-id 23a84b8e-8851-431d-a1da-28e608c2f1af

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
0ee40948:31013168
a69g1124:31058053
dvdeprecation:31068756
dwnewjupyter:31046869
2f103344:31071589
impr_priority:31102340
nativerepl2:31139839
refactort:31108082
pythonrstrctxt:31112756
flighttreat:31134774
wkspc-onlycs-t:31132770
wkspc-ranged-t:31151552
cf971741:31144450
defaultse:31146405
iacca2:31150323
showbadge:31153266
5fd0e150:31146321

Do you mind just including a screenshot as well so I can visualize what is happening here

Hello, I added a screenshot to the initial post. Thanks!

I think this should be fixed. The issue was that we were treating \ as a path on windows
If you're still seeing this, please share the exact prompt you used and I'll take another look


tensor generic compute functions

Per design discussion in: https://github.com/cogentcore/cogent/discussions/324
The tensor.Indexed type provides the universal representation of a homogenous data type throughout all the packages here, from scalar to vector, matrix, and beyond, because it can efficiently represent any kind of element with sufficient flexibility to enable a huge range of computations to be elegantly expressed.  The indexes provide a specific view onto the underlying [Tensor] data, applying to the outermost row dimension (with default row-major indexing).  For example, sorting and filtering a tensor only requires updating the indexes while doing nothing to the Tensor itself.
The Vectorize function and its variants provide a universal "apply function to tensor data" mechanism (often called a "map" function, but that name is already taken in Go).  It takes an N function that determines how many indexes to iterate over (and this function can also do any initialization prior to iterating), a compute function that gets an index and a list of tensors, which is applied to every index, and a varargs list of indexed tensors.  It is completely up to the compute function how to interpret the index.  There is a Threaded version of this for parallelizable functions, and a GPU version.
All tensor package functions are registered using a global name-to-function map (Funcs), and can be called by name via tensor.Call or tensor.CallOut (creates the appropriate output tensors for you). Standard enumerated functions in stats and metrics have a FuncName method that appends the package name, which is how they are registered and called.
A Table automatically supplies a shared list of row Indexes for its Indexed columns, efficiently allowing all the heterogeneous data columns to be sorted and filtered together.
Added: tmath implements all standard math functions on tensor.Indexed data, including the standard +, -, *, / operators.  cosl then calls these functions.
Major cleanup of: stats, which implements a number of different ways of analyzing tensor and table data, including:
- cluster implements agglomerative clustering of items based on metric distance / similarity matrix data.
- convolve convolves data (e.g., for smoothing).
- glm fits a general linear model for one or more dependent variables as a function of one or more independent variables.  This encompasses all forms of regression.
- histogram bins data into groups and reports the frequency of elements in the bins.
- metric computes similarity / distance metrics for comparing two tensors, and associated distance / similarity matrix functions, including PCA and SVD analysis functions that operate on a covariance matrix.
- stats provides a set of standard summary statistics on a range of different data types, including basic slices of floats, to tensor and table data.  It also includes the ability to extract Groups of values and generate statistics for each group, as in a "pivot table" in a spreadsheet.

see bfff608e7 for some of the fixes from comments just resolved.

more: ec34572cb

This PR is superseded by #1229, which contains all of these changes and more.


Tab label font-size smaller on larger screens

The style for <Tab> labels https://github.com/callemall/material-ui/blob/v1-beta/src/Tabs/Tab.js#L81 is a smaller font-size at screens > 960px. This seems counterintuitive to me and I was wondering if this was intended or a typo?

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

font-size should increase at larger screen sizes
Current Behavior

font-size decreases at larger screen sizes

@gmaclennan It's not a typo. It's on purpose to follow the guidelines. You can find the same rule with the tooltip components.
I have my own theory about it. The visibility of a font tends to increase proportionally to the size of the screen. This font size change helps to keep the visibility constant.


Quiver of Colthannin doesn't refresh

Hi,
Endless Quiver of Colthannin never regains its ability to spawn arrows. I encountered this issue in Lost valley and a user campaign.

This isn't a mod content. Let Tactical Adventures know.


Eslint: no-non-null-assertion

Partially addresses #876

@webmaster128 Updated to include only that commit.

Could you update this?

Merged manually


[CI][Buildkite] An example test for Buildkite

Why are these changes needed?
The Buildkite infrastructure for KubeRay CI is ready (Thanks @krfricke!). This PR is used to test the infrastructure after it is merged.
Related issue number
#695

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[x] Manual tests
[ ] This PR is not tested :(

docker run -it golang:1.17

# Execute the following commands in the container.
git clone https://github.com/ray-project/kuberay.git
cd kuberay/ray-operator
make test

Nice, should I be able to see the test somewhere here?


Make the description more clear in "advanced-overload-literal"

Really enjoying going through this!
However, I thought the description for "advanced-overload-literal" could be a little more clear!

Thanks!
There's definitely a lot of room for improvements with many challenges' description 😂


i3wm.colorX in Xresouces

I'm trying to set the i3wm colors based on the readme, and to me it seems like wal does not generate the i3wm.color... values into the .Xresources. What is the correct way to generate those values?

wal doesn't modify your configuration files. It loads the colors straight into your X environment. These values are generated and applied, they just won't be saved in the file.


connect.tsx:40 Uncaught TypeError: s is not a function

🐛 Bug report
Current Behavior
Including cdn scripts for Formik causes this error
connect.tsx:40 Uncaught TypeError: s is not a function
    at x (connect.tsx:40)
    at FieldArray.tsx:374
    at formik.umd.production.min.js:1
    at formik.umd.production.min.js:1

Both these CDN scripts cause issues:
https://unpkg.com/formik/dist/formik.umd.production.min.js
https://unpkg.com/formik/dist/formik.umd.production.js
Expected behavior
No error should occur.
Reproducible example
Include the following HTML  on any page and you will see this error in the console:
    <script type="text/javascript"<EMAIL_ADDRESS>type="text/javascript"<EMAIL_ADDRESS>type="text/javascript"<EMAIL_ADDRESS>

Suggested solution(s)

Additional context
References to this exact error by other users in https://github.com/jaredpalmer/formik/issues/1463#issuecomment-624564924 and https://github.com/jaredpalmer/formik/issues/2108#issue-536498530
Your environment

Software
Version(s)

Formik
2.1.4

React
16.13

TypeScript
3.8.3

Browser
Chrome & Firefox (suspect all browsers)

npm/Yarn
6.13.0

Operating System
OSX

The issue seems to be an unmentioned dependency on hoist-non-react-statics. Including https://gist.github.com/kentcdodds/ea2fdfc82f79228a6be641c78dc0e1b9 resolves the issue for me


[feature] Colorizer

Colorizer would work by default and "i" command becomes the override. Due to the bigness of tables, create 1 file per game in the "colorizer" folder and do lookup there. Filename is first 8 chars of sha256 hash. SMB1 would be colorizer\fcb6a0ef.txt. And within that file is something like this:
//palettes
{
0,mario,00ffff,b53120,ea9e22,6b6d00
1,fire,00ffff,b53120,ffffff,ea9e22
2,turtle,00ffff,0c9300,ffffff,ea9e22
3,goomba,00ffff,000000,ffcec5,9c4a00
4,squid,00ffff,636363,ffffff,adadad
5,cloud,00ffff,ffffff,63adff,000000
6,mushroom,00ffff,ea9e22,b53120,000000
7,pipe,00ffff,8cd600,109400,000000
8,stone,00ffff,ffcec5,9c4a00,000000
9,coin,00ffff,ea9e22,9c4a00,000000
10,castle,00ffff,ffffff,adadad,636363
11,bridge,00ffff,ffffff,b53120,636363
12,axe,00ffff,ea9e22,9c4a00,636363
13,waterblock,00ffff,bdf4ab,109400,000000
14,seaweed,00ffff,b5217b,4242ff,ff6bce
15,watercoin,4242ff,ea9e22,00ffff,000000
}

//0
{
0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0
0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0
0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0
0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0
0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0
1,1,1,1,1,1,1,1,0,0,0,1,0,0,0,0
1,1,1,1,1,1,1,1,1,2,2,2,2,2,2,2
3,3,3,3,1,1,1,1,1,1,1,1,2,2,2,2
3,3,3,3,3,3,3,3,2,2,2,2,2,1,1,1
0,0,0,0,1,1,1,1,1,1,1,1,1,1,0,0
2,2,2,2,2,2,2,2,2,2,3,3,3,3,3,3
3,3,1,1,1,1,2,2,2,2,2,2,2,2,2,2
2,2,2,2,2,2,2,2,2,2,2,2,2,1,1,1
1,2,2,2,2,2,1,1,1,2,1,1,4,4,4,4
2,2,2,2,1,2,2,3,3,3,3,2,2,2,2,3
1,1,1,1,3,3,1,1,1,1,1,1,1,1,1,3

5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5
5,5,5,5,5,5,5,5,5,5,5,5,5,5,5,5
5,5,5,5,5,5,5,5,5,5,5,5,6,6,6,7
7,7,7,7,7,5,5,5,5,5,5,5,5,7,8,8
8,5,8,8,8,8,8,8,8,8,8,7,7,7,7,7
7,7,8,9,9,9,9,8,8,8,8,8,8,10,10,8
7,7,7,7,7,7,7,7,7,7,7,6,6,6,6,6
6,6,6,6,6,8,8,11,8,11,8,12,12,12,12,10
8,13,13,13,13,7,7,7,7,7,7,7,7,7,7,7
7,7,7,7,7,7,8,8,8,8,8,8,8,8,8,9
8,8,8,8,14,9,9,9,9,8,8,8,8,8,8,5
5,5,5,5,8,8,8,8,7,7,7,7,7,7,8,8
7,8,15,15,8,8,8,8,8,8,8,8,8,8,8,5
8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8
8,8,8,8,8,8,8,8,8,14,14,8,8,8,8,8
8,8,8,8,8,8,8,8,8,8,8,8,8,8,8,8
}

Fixed by 56c9326


Add note that INVAL is dangerous and should be FLUSH

and fix the bounds check text for INVAL

thsi is intended to fix https://github.com/riscv/riscv-cheri/issues/213


[Enhancement] #305: Add indication next to previous theme when running wal --theme

Regarding #305:

Prints (last used) next to last used theme when listing themes with --theme.

I couldn't decide on a symbol to use, so I just used text. If @ghost or someone else has a suggestion, feel free to let me know.
--
Closes #305

Can I see a screenshot of what this looks like? I like the idea. :+1:

Sure, e.g.:
...

...
Credit for the idea goes to @ghost

@ghost is a "dummy account" which acts as "blank information" after a user deletes their GitHub account.

Huh I never knew that. Thanks for the merge!


Hi, I have issues with updating my build tool step in android.

Bitrise Build Issue Report template
Description of the issue
Please describe the issue here
Environment:
Where did the issue happen?
If on Bitrise.io: which stack? If not on Bitrise.io: on what operating system? (Plus any other information you can share)
Which build Step causes the issue and which version of the step?
Reproducibility

Does a "Rebuild" help? (You can trigger a rebuild from the Build's page, by clicking the "Rebuild" button in the top right corner of a finished build) : YES/NO
Does a rebuild without caches help? (You can remove the Cache:Pull and Cache:Push steps temporarily to not to use the cache, or you can delete all the caches on the Settings tab of the app. : YES/NO
If you have multiple different build configurations (workflows), does the issue affect all/more than one? : YES/NO
If it's an issue which happens sporadically, what's the frequency? (e.g. Once a day ; about x% of the builds) :
Does upgrading the build Step to the latest version help? : YES/NO
When did the issue start? :

Linux/Android stack builds
Can it be reproduced by running the build locally, after doing a clean git clone (git clone the repository, into a new directory, somewhere on your Mac/PC) and running the build from there with the Bitrise CLI ( https://www.bitrise.io/cli )? If no, can it be reproduced with Docker (using the same docker images / environment we use on bitrise.io)? Related guide: https://bitrise-io.github.io/devcenter/docker/run-your-build-locally-in-docker/ .
Other stacks
Can it be reproduced by running the build locally with our CLI ( https://www.bitrise.io/cli ), after doing a clean git clone (git clone the repository, into a new directory, somewhere on your Mac/PC) and running the build from there with the CLI ( https://www.bitrise.io/cli )?
Build log
Please attach the build log (you can download the build log from the build's page,
once the build is finished, using the "Download log" button - floating at the bottom right corner of the log viewer),
or if you can't attach the whole log then send the full log through a private channel (e.g. email - https://www.bitrise.io/contact ), with a link to the related GitHub issue.

echo y

grep 'package installed'
android update sdk --no-ui --all --filter platform-tools
Done. 1 package installed.
echo y
grep 'package installed'
android update sdk --no-ui --all --filter extra-android-support
Error: Ignoring unknown package filter 'extra-android-support'
|                                                                              |
+---+---------------------------------------------------------------+----------+
| x | Update Android Extra packages (exit code: 1)                  | 14 sec   |
+---+---------------------------------------------------------------+----------+
| Issue tracker: https://github.com/bitrise-io/steps-script/issues             |
| Source: https://github.com/bitrise-io/steps-script                           |
+---+---------------------------------------------------------------+----------+

Thanks for reporting the issue!
You can find a description and a solution for this issue on our blog: http://blog.bitrise.io/2016/12/13/android-extra-android-support-no-longer-available.html
TL;DR; the extra-android-support android package is no longer available - you have to remove it from your build configuration if you have it in there.
Let us know if you need more info / help!


feat(docker): support centos6 build env

Ref-issue
https://github.com/apache/incubator-pegasus/issues/903

@acelyc111 I have fixed it and now can review it


[GraphQL] Add query logging when timing out

Description
This PR enables logging of queries that time out. The logging uses the error macro together with a new error code, REQUEST_TIMEOUT.
Note, that the timeout extension function was switched to parse_query + execute. Execute one takes care of the time, parse query takes care of stringifying up the query (including resolving any passed, fragments, etc).
Test Plan
Existing tests, manually checking for errors when setting a small (500ms) timeout.
2024-02-28T23:25:23.373001Z ERROR sui_graphql_rpc::extensions::timeout: Query: {
  transactionBlocks(first: 50) {
    nodes {
      digest
    }
  }
} query_id=97a7adca-52dc-4e4e-9cdc-bfdaaf1d65ae session_id=<IP_ADDRESS>:52232 error_code="REQUEST_TIMEOUT"

2024-02-29T02:35:24.740291Z ERROR sui_graphql_rpc::extensions::timeout: query_id=44d9f1ec-e4df-488c-bd2a-a0b31d5bb203 session_id=<IP_ADDRESS>:59043 error_code="REQUEST_TIMEOUT" query=query { a:transactionBlocks(first: 10) { nodes { digest } } b:transactionBlocks(first: 50) { nodes { digest } } }

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Changes now look good (pending CI going all green!) But do double check the order of operations on extensions before landing (that query limits happens before timeout).

Yes, we  (Will and myself) figured out that order of extensions matter. Query limits checker is before Timeout, so we're good here.
The CI issue was fixed too.


Add keyboard shortcut for mute

Original: #35 Added some great keyboard shortcuts, but I would love it if you could use m as mute/unmute. This is what youtube uses.
Thanks again for this wonderful site.
EDIT:

[x] Refactor keyboard shortcuts into a Redux middleware
[x] Add m shortcut for toggling mute

I checked to see what some other sites were doing and found Spotify uses Ctrl-Shift-Down (yuck) and Google Play Music doesn't even have a shortcut for this. I think m is a good choice. I'll do that unless someone thinks a different key would be better. Great suggestion, thanks!

For context: When you unpause/play a track it sometimes takes a little bit to "get going" again, so I'd like to use mute/unmute to quickly pause/unpause without interrupting the flow of the track that much.

I've been using this so much since it was added, really great suggestion! I do the same thing as you where I mute/unmute instead of stopping and restarting a piece, and this makes it that much easier.


bump kubebuilder to 3.15.0

Description of the change:
Bump the Kubebuilder dependency to 3.15.0, and fixup various scaffolding and generation bits to account for upstream scaffolding changes.
Motivation for the change:
Keep dependencies up-to-date.

Yeah, I know. But I don't think we really have an option, unfortunately. What are the alternatives?

@joelanford @acornett21 the bump to k8s 1.30 requires use of kubebuilder v4. Waiting for this to be merged before raising that PR so this is blocking https://github.com/operator-framework/operator-sdk/issues/6730
Can you look into what is needed to get this PR moving?

Closing infavor of

#90


YARN-11644. LogAggregationService can't upload log in time when application finished

Description of PR
JIRA: YARN-11644 LogAggregationService can't upload log in time when application finished.
Current implementation of AppLogAggregatorImpl is to do empty while loop until application finish.
If too many applications running, it will block the following applications upload logs.
Make AppLogAggregatorImpl return when application has not finished and resubmit itself to thread pool. It not only fixed the block issue but also shrink the thread pool size (default: 100).
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 11s

trunk passed

+1 :green_heart:
compile
1m 28s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 38s

trunk passed

+1 :green_heart:
mvnsite
0m 43s

trunk passed

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 25s

trunk passed

+1 :green_heart:
shadedclient
39m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
1m 24s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 24s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 29s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 4 new + 27 unchanged - 1 fixed = 31 total (was 28)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

-1 :x:
spotbugs
1m 42s
/new-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.html
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
49m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
2m 41s
/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-server-nodemanager in the patch failed.

+0 :ok:
asflicense
0m 26s

ASF License check generated no output?

158m 37s

Reason
Tests

SpotBugs
module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Should org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.LogAggregationService$StoreUnexecutedPolicy be a static inner class?  At LogAggregationService.java:inner class?  At LogAggregationService.java:[lines 485-497]

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6452/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6452

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 15c73e244ebc 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8c627730ed971d2ffdfddbbf0df829422e4fa62d

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6452/1/testReport/

Max. process+thread count
615 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6452/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  1s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 21s

trunk passed

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
0m 39s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 47s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 38s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 25s

trunk passed

+1 :green_heart:
shadedclient
38m 12s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 26s
/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: The patch generated 4 new + 27 unchanged - 1 fixed = 31 total (was 28)

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 33s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
0m 30s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
1m 25s

the patch passed

+1 :green_heart:
shadedclient
38m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
24m  4s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

166m 46s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6452/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6452

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d9c9bef4bd3d 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 19826d01ffafb3bd2d371ef27f8efe86739f666d

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6452/2/testReport/

Max. process+thread count
528 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6452/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@goiri @slfan1989 Would you mind help review this?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

_ Prechecks _

+1 :green_heart:
dupname
0m 00s

No case conflicting files found.

+0 :ok:
spotbugs
0m 01s

spotbugs executables are not available.

+0 :ok:
codespell
0m 01s

codespell was not available.

+0 :ok:
detsecrets
0m 01s

detect-secrets was not available.

+1 :green_heart:
@author
0m 00s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m 00s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
91m 32s

trunk passed

+1 :green_heart:
compile
5m 11s

trunk passed

+1 :green_heart:
checkstyle
4m 50s

trunk passed

+1 :green_heart:
mvnsite
5m 37s

trunk passed

+1 :green_heart:
javadoc
5m 10s

trunk passed

+1 :green_heart:
shadedclient
149m 06s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 01s

the patch passed

+1 :green_heart:
compile
2m 39s

the patch passed

+1 :green_heart:
javac
2m 39s

the patch passed

+1 :green_heart:
blanks
0m 01s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
2m 17s

the patch passed

+1 :green_heart:
mvnsite
3m 01s

the patch passed

+1 :green_heart:
javadoc
2m 40s

the patch passed

+1 :green_heart:
shadedclient
162m 24s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
5m 35s

The patch does not generate ASF License warnings.

426m 59s

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6452

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
MINGW64_NT-10.0-17763 8b443c886006 3.4.10-87d57229.x86_64 2024-02-14 20:17 UTC x86_64 Msys

Build tool
maven

Personality
/c/hadoop/dev-support/bin/hadoop.sh

git revision
trunk / 19826d01ffafb3bd2d371ef27f8efe86739f666d

Default Java
Azul Systems, Inc.-1.8.0_332-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6452/1/testReport/

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch-windows-10/job/PR-6452/1/console

versions
git=2.44.0.windows.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


add MatrixSparseTimeFunction to support multi-point sources

This adds a MatrixSparseTimeFunction class, which allows a single time-series of source data to be injected (with different weights) at, or sampled from, multiple physical locations in the grid.
The typical use case is to inject a dipole source, or sample a dipole receiver (where the weights are +1 for one injection point and -1 for the other).  This is used, for example, if one wishes to model ghosting-type behaviour without using a free surface, and without storing twice as much data to do so.

superseded by #1603


Overworld: Implement 2d-Scene to move around in

Motivation:

The overworld acts as linking element for more specific encounters.
we ought to navigate around every island ( that is available because the bridges have been built )
we have possibilities to "interact" with something
could be a tree
npc on a tile to talk to
maybe some special navigation

Implementation:

The  world is not randomly generated, we design it on our own
For this we are using Tilesets. This means we are given an amount of tiles, colliders and more that can then be placed on the world as desired by game design and more
Interacting with encounters ( person, resource gathering etc) are done with collision boxes that we can interact with ?

Further Issues to achieve this:
Below is a list of tasks that ought to be implemented to provide a base to work and itneract with further.

[x] #59
[x] #50
[x] #51
~issue 57 was moved to after prototype~

started development in prototype/overworld
most recent commit is 6c2ed12

I will provide a list of issues, changes, requirements that we ought to implement into our prototype.

[ ] use pattern matching to decide which action to take on a given interaction-area
[ ] create menu and implement a simple scene change
[ ] dummy inventory that is displayed on screen
[ ] refine structure of overworld prototype

closed, all issues finished

thx


FHIR converter Service - CCD to FHIR conversion - getting response message like Input data size: 182743B exceeds limit: 102400B.

When we process the entire CCD file to FHIR conversion using fhir-converter service, we are getting the response message like Input data size: 182743B exceeds limit: 102400B. This issue can reproduce using sample ccda "Transfer_Summary.ccda" file.
Please let me know any settings to process the entire CCD file in fhir-converter service.
FYI,
Response:
{
"error": {
"code": "InvalidRequestBody",
"message": "An error was found while validating the request body.",
"innerError": {
"code": "InvalidInputDataRequestValue",
"message": "Input data size: 182743B exceeds limit: 102400B."
}
}
}

Hello @Sathishsanro . Thanks for bringing this to our attention. The MCR Container Image includes request filtering that prevents input data larger than 100kb. Unfortunately this prevents the use of some sample data, as you've discovered. We are making changes on our end to increase this limit and roll it out in our next released image. I will update this thread when that occurs.
In the meantime please make use of any data underneath the 100k limit.

@Sathishsanro a new image has been released with the increase in the data size limit. This supports all sample data within our repo, so you should no longer have any issues. I've attached the relevant image tag below.
mcr.microsoft.com/healthcareapis/fhir-converter:1.0.8-preview
https://mcr.microsoft.com/en-us/product/healthcareapis/fhir-converter/tags


Use CURDIR instead of PWD

PWD is set by the shell, not make, and might not match.
For example, this broke the build through Homebrew, because
PWD stays at the directory where brew is ran.

Thanks! This was fixed once before a few years ago but I seem to have reintroduced it. Merging.

Thank you! There seem to be a few uses of PWD in litecross but they did not break my build, presumably because there is a shell in the middle.


DSHttpAdapter default $http config

I think it would be good if you could provide some default config for $http in the DSHttpAdapter.
So you can add stuff like interceptors if you want to handle certain errors etc, for example that the user is not authenticated with the api.
I was thinking about these changes to the DSHttpAdapterProvider
    var defaults = this.defaults = {
        /**
         * @doc property
         * @id DSHttpAdapterProvider.properties:defaults.queryTransform
         * @name defaults.queryTransform
         * @description
         * Transform the angular-data query to something your server understands. You might just do this on the server instead.
         *
         * @param {string} resourceName The name of the resource.
         * @param {object} params Params sent through from `$http()`.
         * @returns {*} Returns `params` as-is.
         */
        queryTransform: function(resourceName, params) {
            return params;
        },
        httpConfig: {}
    };

function HTTP(config) {
    var start = new Date().getTime();

    config = DSUtils.deepMixIn(this.defaults.httpConfig, config);
    return $http(config).then(function(data) {
        $log.debug(data.config.method + ' request:' + data.config.url + ' Time taken: ' + (new Date().getTime() - start) + 'ms', arguments);
        return data;
    });
}

Then one could add config to all $http requests that angular-data executes
DSHttpAdapter.defaults.httpConfig = {
    interceptor: /* ... */
};

The reason for not just configuring $http globally would be if you wanted to do other $http requests to other sources that is not your API

Sorry, can this be done or not? I see this was added in 0.10.5 (changelog)  / ffae052
Then there is the previous comment saying there is actually no API to do this. I still see the code for this in the source, but neither  DSHttpAdapter(Provider?).defaults.httpConfig  or  $httpProvider.interceptors.push(...) seems to have any effect on js-data-angular calls.

is there a way to make an interceptor which is specific to DS

No, not if you're going to use the http adapter that comes with js-data-angular (that's not how Angular's DI works).
However, you can load js-data-http which uses axios for http (instead of $http). You can add interceptors to axios via axios' api, which will not be used by $http.


Selectable buildings

Once a building is placed, you should be able to click it to and have an info box appear.
This info box can contain:

current / max HP
resource production
enemies destroyed
experience / level
upgrade options

It might make sense to start with a static area on the page to hold the info box.
Eventually, that box could be absolutely positioned near the building itself — depending on how this affects the UI.

Progress made on this issue via PR #41
Info box contains HP, XP, resource production.
Still needs enemies destroyed and upgrade options.


Updating my bio and profile.

Updating my bio and profile.

Docs Build status updates of commit 1e017c9:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/MicrosoftDocs/cloud-developer-advocates, working directory: W:\mlh3-s, target branch: master, target branch commit: cdc4cd65d5d6d6f6298c866921bd3849e7e93fcd, source commit: 1e017c9c528a7683a0cfcd307fe4065d98a7e5ad.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 40f1c5c:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

advocates/glaucia-lemos.yml
:x:Error

Details

advocates/index.html.yml
:warning:Warning

Details

advocates/map.yml
:warning:Warning

Details

advocates/toc.yml
:warning:Warning

Details

advocates/glaucia-lemos.yml

[Error] Unable to load file 'glaucia-lemos.yml' via processor 'Profile': glaucia-lemos.yml is not in supported format: (Line: 32, Col: 1, Idx: 1229) - (Line: 32, Col: 1, Idx: 1229): While scanning a simple key, could not find expected ':'.

advocates/index.html.yml

[Warning] Unable to find uid "advocates.glaucia-lemos".
Line 0: [Warning] Invalid file link:(~/tweets).
Line 0: [Warning] Invalid file link:(~/map).

advocates/map.yml

[Warning] Unable to find uid "advocates.glaucia-lemos".

advocates/toc.yml

[Warning] Unable to find file with uid "advocates.glaucia-lemos" referenced by TOC file "toc.yml"

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


hyperv: schema: better docs about parameters

What this PR does / why we need it:
Improve documentation of the HyperV tunables, to help consumer tune the settings
Special notes for your reviewer:
No code changes: only comments/docs updates
NONE

/cc @vladikr @slintes  - no code changes, only docs

/retest

/retest

/retest


refractored charging sparks and charging fire for enemies

fixed enemies: seth and harphy

https://github.com/MontyTRC89/TombEngine/pull/885 please test this before merging this branch to master


A11y_SQL Azure Data Studio_Import Extension - Specify Input File_ColorContrast: The color contrast of the tab focus on link 1 is below 3:1

“Check out Accessibility Insights! – Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags: #A11yWCAG2.1;#A11yTCS;#A11ySev2;#BM_SQLAzureDataStudio_Oct2020;#SQL Azure Data Studio;#Win10;#FTP;#DesktopApp;#WCAG1.4.11;#Benchmark;#ColorContrast;#AINotInScope;
Environment Details:
Application Name: SQL Azure Data Studio
Version 1.22.1 User Setup
Windows Version: Windows10
Repro Steps:

Launch Azure Data Studio Insiders application.
Tab to server drop down and tab again to button new connection press enter key and add the server details.
Tab to the connected server and press enter key, use down key and select any database keep_MDW Right click on/ open the context menu for a database and select Data-tier application wizard from the context menu
Tab to link 1
Open accessibility insights for desktop and check the ratio of the tab focus outline on link 1

Actual:
On navigating to link 1 with tab and checking the color contrast of the focus on link1 the ratio is 2.122:1.
Same issue observed in page:

Import Extension - Preview Data
Import Extension - Modify Columns
Import Extension - Summary

Expected:
The focus ratio on link 1 should be 3:1 or greater.
User Impact:
Low vision users will not be able to view the focus.
Attachment:

Closing the bug as the issue is not repro
Version: 1.42.0-insider(user-setup)

GithubTags:#Closed;


fix(install.md): encourage cloud-provided kubernetes clusters

@sgoings,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Fix build failure in credential_test.cc

Fixes the compilation error for #19032 as a result of a rollback I made, not the PR.

Thanks!


✨ Making StrictlyPositiveDouble comparable

📝 Description
We would like to make StrictlyPositiveDouble comparable by implementing the Comparable interface.
interface StrictlyPositiveDouble : Comparable<StrictlyPositiveDouble> {
    override fun compareTo(other: StrictlyPositiveDouble): Int
}

🔗 Dependencies
This issue is blocked by the following ones:

[x] #66

✅ Checklist

[ ] Make the type comparable, test its behavior with Kotlin and its compatibility with Java, update the public API binaries and the unreleased changelog.
[ ] Close this issue as completed and update tracking ones if present.

See #628 for more details on why we are not going to implement this issue for now.


Bumped Parlour version to 1.11.1-20160105030640-0ce6193

This parlour version incorporates the direct mode option.

@stephanh If this is good to merge. could you please merge this. I don't have write access to the repo.

@sibisasidharan @stephanh See the datahub gitter.

@sibisasidharan Looks fine.  :+1:   (No need for a formal PR for a version bump in future.)


Download link is not working in readme

It says 404 in bintray.

Thanks, I'll remove it. Opened an issue to publish to maven central directly (#177).

fixed, thanks!


Bruce/875 876 removing next optimize images

Reviewers
@.
Changes

Removing unnecessary libs

Definition of Done (from ticket)
QA steps (optional)
Known Issues

Will create a new branch for these changes


How to determine corresponding sql file during error on migration

Is there a way to indicate or determine the sql file responsible for an error during migration?
When there are migration errors (from using the vendor statement a lot), the exception shown is the correct sql error but when multiple sql files were added running the application, it can be a bit difficult to identify which file generated the error.
Example error

Good point, these should probably be wrapped in an outer exception containing the filename.

@rspeele What is the final decision on this? Is it to write the outer exception as indicated above or have you decided on some other approach?

Definitely outer exception as above and it's honestly a tiny change, I have just been completely unmotivated in the past couple months. Sorry!


[WIP] Add test-unit component

I'm going to finish off this pull request during the next week ;)

@padrino/core-members Could you review this pr?

FWIW looks good to me, adapted from the code for minitest component right. My question is (may be stupid) why would someone pick test/unit over minittest nowadays?

I'm thinking, test-unit is very promising because it has actively been developed for quite a while and it's having a lot of features not found in minitest.
Also currently, the gem is very popular in Japan.