Typings: data depending on error and loading

If there is no error and loading is false, is it even possible to have undefined data?
The example given in the Readme is not possible in typescript, because data might be undefined in the final return statement so we can't map over data.dogs.
It would be nice if the typings could reflect this.
const Dogs = () => {
  const { data, error, loading } = useQuery(GET_DOGS);
  if (loading) {
    return
Loading...
;
  };
  if (error) {
    return
Error! {error.message}
;
  };

  return (

      {data.dogs.map(dog => (

{dog.breed}

      ))}

  );
};

Not taking partials into account, i was thinking about something along these lines:
interface QueryHookStateLoading {
  data: undefined
  loading: true
  error: undefined
  networkStatus: NetworkStatus | undefined
}

interface QueryHookStateFailure {
  data: undefined
  loading: false
  error: ApolloError
  networkStatus: NetworkStatus | undefined
}

interface QueryHookStateSuccess<T> {
  data: T
  loading: false
  error: undefined
  networkStatus: NetworkStatus | undefined
}

type QueryHookState<T> =
  | QueryHookStateLoading
  | QueryHookStateFailure
  | QueryHookStateSuccess<T>

I think that data is always TData | {} in Apollo. Would it be best to do this too here?

@tleunen there is a case when data is undefined - when the query is skipped (it's implemented the same way in react-apollo).
@codepunkt unfortunately it couldn't be implemented that way - there is a case when loading is true and data is T - when fetchMore was invoked and hadn't finished loading additional data. Long term (when Suspense for data fetching will be ready) I'd change the API as described in https://github.com/trojanowski/react-apollo-hooks/issues/28#issuecomment-467191957 - it would solve the problem.

But only when skip is actually provided, isn't it?

As a note for this discussion. React Apollo returns undefined now instead of {}
See here: https://github.com/apollographql/apollo-client/pull/4356/files

I think that data is always TData | {} in Apollo. Would it be best to do this too here?

I'm using typescript but my IDE hinted me that the data type is TData | undefined. But in reality its TData | {}. Why useQuery gives me TData | undefined instead of TData | {}?

Because if the type would be TData | {}, you would have to declare a custom type guard for the type {} instead of just writing if(!data).

But isn't an empty object truthy not falsy so you can't really just write if (!data) ...?
const data = {};

if (!data) {
  console.log("no data");
} else {
  console.log("data exists"); // always the case
}

So code like this makes TypeScript happy but you actually get a runtime error, because initially data is {} and thus accessing name from undefined data.user gives error.
export const App: React.FC = () => {
  const { data } = useQuery<User>(GET_USER);

  if (!data) {
    return <LoadingView />;
  }

  return
Name: {data.user.name}
;
};

This would work if the data was actually undefined not an empty object (as undefined is falsy).

export const App: React.FC = () => {
  const { data } = useQuery<User>(GET_USER);

  if (!data) {
    return <LoadingView />;
  }

  return
Name: {data.user.name}
;
};

This is the perfect example. It won't work like this.
return
Name: {data.user.name}
;
This line is the problem, as the type for data is either {} or TData (so you define a union). Typescript will complain about the access to data.user, because data can be of type {} or TData. That is where you need typeguards in your code.
https://www.typescriptlang.org/docs/handbook/advanced-types.html#type-guards-and-differentiating-types
Please don't mix {} seen as a value and {} seen as a type. I think that is what you are doing here.

Not sure that I follow what is the correct way to handle this then?
The problem is that the typings and actual data are different right.
When loading, the actual data is an empty object {} but the typings say that it's either TData | undefined. So when I know check for undefined (or falsyness as shown in the example), TypeScript thinks it's safe to use properties from this object when in reality one would get a runtime error.
I understand that if the typings were fixed to match (TData | {}), one would need a cumbersome type guard.
Better fix would be to make the hook return undefined instead of an empty object so the typings would match reality and the falsyness check would work as expected.

Having trouble coming up with a suitable type guard for this?


[sw, ottf] Fix bug in the mepc computation.

Problem
The current implementation causes a crash in case of the mepc is holding an invalid address.
Proposed approach
The solution applied in this commit is to check the register mcause whether the exception code is an Instruction access fault, if so, return the mpec without computation.

I agree that this fixes the immediate issue but I'm not particularly convinced that this is the best way to fix the root cause.
In what circumstances is handler_exception (the caller of compute_mepc_on_synchronous_irq) called? Doesn't mtval already contain the faulting instruction? If so, we could avoid this whole dance in the IRQ handler. See https://ibex-core.readthedocs.io/en/latest/03_reference/cs_registers.html#machine-trap-value-mtval

I agree that this fixes the immediate issue but I'm not particularly convinced that this is the best way to fix the root cause.
In what circumstances is handler_exception (the caller of compute_mepc_on_synchronous_irq) called? Doesn't mtval already contain the faulting instruction? If so, we could avoid this whole dance in the IRQ handler. See https://ibex-core.readthedocs.io/en/latest/03_reference/cs_registers.html#machine-trap-value-mtval

To support concurrency (i.e., for the power virus test) and nested faults, the mepc must be saved to the stack, at the beginning of every ISR, and restored at the end. Moreover, if an IRQ is synchronous (i.e., for exceptions), the mepc needs to be incremented to point to the instruction after the trapped instruction. There are two ways to do said increment:

before the mepc is saved to the stack (on ISR entry)
when the mepc is popped from the stack and restored (on ISR exit).

The reason I originally decided to update it before it was saved to the stack (i.e., option 1), was because this allowed me to reuse the ISR exit asm subroutine (ottf_isr_exit) across all IRQ handlers (synchronous, handler_exception, and asynchronous, handler_irq_software, handler_irq_external, handler_irq_timer), since in all cases we just needed to pop the mepc and we are done.
We could do the call compute_mepc_on_synchronous_irq in the ottf_isr_exit subroutine, but this would require being able to differentiate if the IRQ that triggered was synchronous or asynchronous, which would require storing more information on the stack I believe. So I'm not certain that would be the most efficient. Thoughts?

@luismarques anything in particular you wanted me to look at (you request my review on this PR)? What's proposed looks sensible. Note that mtval only gives you the instruction in certain fault cases, not all so it can't replace the loading of the instruction from mepc here.

That was in fact what I had in my mind. To assess if it was feasible to use mtval, or do some other simplification. I was assuming that instruction skipping would only make sense in synchronous scenarios and that that hopefully matched when mtval would provide the instruction contents, but I hadn't had the opportunity to do a deep dive into the code. That was before @timothytrippel replied with further information. I'm on vacation right now, I'll look into this again when I can but it sounds like that's not possible (so don't be blocked on me).

I agree that this fixes the immediate issue but I'm not particularly convinced that this is the best way to fix the root cause.
In what circumstances is handler_exception (the caller of compute_mepc_on_synchronous_irq) called? Doesn't mtval already contain the faulting instruction? If so, we could avoid this whole dance in the IRQ handler. See https://ibex-core.readthedocs.io/en/latest/03_reference/cs_registers.html#machine-trap-value-mtval

To support concurrency (i.e., for the power virus test) and nested faults, the mepc must be saved to the stack, at the beginning of every ISR, and restored at the end. Moreover, if an IRQ is synchronous (i.e., for exceptions), the mepc needs to be incremented to point to the instruction after the trapped instruction. There are two ways to do said increment:

before the mepc is saved to the stack (on ISR entry)
when the mepc is popped from the stack and restored (on ISR exit).

The reason I originally decided to update it before it was saved to the stack (i.e., option 1), was because this allowed me to reuse the ISR exit asm subroutine (ottf_isr_exit) across all IRQ handlers (synchronous, handler_exception, and asynchronous, handler_irq_software, handler_irq_external, handler_irq_timer), since in all cases we just needed to pop the mepc and we are done.
We could do the call compute_mepc_on_synchronous_irq in the ottf_isr_exit subroutine, but this would require being able to differentiate if the IRQ that triggered was synchronous or asynchronous, which would require storing more information on the stack I believe. So I'm not certain that would be the most efficient. Thoughts?

I agree that the first option is by far better.
If you all agree, I would also suggest returning the ra value in the compute_mepc_on_synchronous_irq when the mcause == Instruction access fault(1u), so that the ottf_instr_access_fault_handler would work in these situations but also we would save some lines of code in the ottf_exception_handler for the sram_ctrl tests, and for the incoming ibex_address_translation test.

Could you elaborate here, I'm not sure I follow what you are suggesting? By ra do you mean the mepc?

I agree that this fixes the immediate issue but I'm not particularly convinced that this is the best way to fix the root cause.
In what circumstances is handler_exception (the caller of compute_mepc_on_synchronous_irq) called? Doesn't mtval already contain the faulting instruction? If so, we could avoid this whole dance in the IRQ handler. See https://ibex-core.readthedocs.io/en/latest/03_reference/cs_registers.html#machine-trap-value-mtval

To support concurrency (i.e., for the power virus test) and nested faults, the mepc must be saved to the stack, at the beginning of every ISR, and restored at the end. Moreover, if an IRQ is synchronous (i.e., for exceptions), the mepc needs to be incremented to point to the instruction after the trapped instruction. There are two ways to do said increment:

before the mepc is saved to the stack (on ISR entry)
when the mepc is popped from the stack and restored (on ISR exit).

The reason I originally decided to update it before it was saved to the stack (i.e., option 1), was because this allowed me to reuse the ISR exit asm subroutine (ottf_isr_exit) across all IRQ handlers (synchronous, handler_exception, and asynchronous, handler_irq_software, handler_irq_external, handler_irq_timer), since in all cases we just needed to pop the mepc and we are done.
We could do the call compute_mepc_on_synchronous_irq in the ottf_isr_exit subroutine, but this would require being able to differentiate if the IRQ that triggered was synchronous or asynchronous, which would require storing more information on the stack I believe. So I'm not certain that would be the most efficient. Thoughts?

I agree that the first option is by far better.
If you all agree, I would also suggest returning the ra value in the compute_mepc_on_synchronous_irq when the mcause == Instruction access fault(1u), so that the ottf_instr_access_fault_handler would work in these situations but also we would save some lines of code in the ottf_exception_handler for the sram_ctrl tests, and for the incoming ibex_address_translation test.

Could you elaborate here, I'm not sure I follow what you are suggesting? By ra do you mean the mepc?

By ra I mean the return address (register x1). I'm suggesting to do in the OTTF assembly what has been done here.
Let me know if that makes sense.


api.showFileDialog not working for Jupyter notebook

The api function showFileDialog is not working when called from a Python plugin running on a Jupyter notebook. Rather than listing the folder content a dialog with the message No file manager is available. is shown.
ImJoy version:  v.0.10.22
Chrome version:   79.0.3945.130
Jupyter launched with: jupyter notebook --NotebookApp.allow_origin='*' --no-browser
Error can be reproduced with following code snippet placed in  a Python plugin executed on a locally running Jypyter engine:
api.log(f'api.ENGINE_URL: {api.ENGINE_URL}')
ret = await api.showFileDialog(file_manager=api.ENGINE_URL)
api.log(f'{ret}')

Saving and running the plugin gives this plugin log
Loading plugin FileDialogTest_ng4ontdgv2 (TAG=undefined, WORKSPACE=fq-dev)
ENGINE_URL=http://<IP_ADDRESS>:8889/
Plugin connected.
Setting up plugin.
initialized
api.ENGINE_URL: http://<IP_ADDRESS>:8889/
{'path': './', 'file_manager': {}}

This is the console output
Plugin FileDialogTest_ng4ontdgv2: api.ENGINE_URL: http://<IP_ADDRESS>:8889/
vue.esm.js:1741 TypeError: this.selected_file_manager.listFiles is not a function
    at s.refreshList (FileDialog.vue:259)
    at s.<anonymous> (FileDialog.vue:336)
    at Array.<anonymous> (vue.esm.js:1837)
    at st (vue.esm.js:1758)
tt @ vue.esm.js:1741
et @ vue.esm.js:1732
Qe @ vue.esm.js:1721
(anonymous) @ vue.esm.js:1839
st @ vue.esm.js:1758
Promise.then (async)
nt @ vue.esm.js:1806
ht @ vue.esm.js:1850
an @ vue.esm.js:3068
cn.update @ vue.esm.js:3209
pe.notify @ vue.esm.js:697
set @ vue.esm.js:1014
ln.set @ vue.esm.js:3300
showFileDialog @ Imjoy.vue:2776
JailedSite._processMessage @ VM74:272
eval @ VM74:84
handle_data_message @ VM80:803
comm.onMsg @ VM80:770
_handleCommMsg @ VM78:10
_handleMessage @ VM78:10
eval @ VM78:10
Promise.then (async)
_onWSMessage @ VM78:10
FileDialog.vue:446 Uncaught (in promise) TypeError: t.selected_file_manager.listFiles is not a function
    at FileDialog.vue:446
    at new Promise (<anonymous>)
    at selectFileManager (FileDialog.vue:441)
    at FileDialog.vue:433
    at new Promise (<anonymous>)
    at showDialog (FileDialog.vue:344)
    at showFileDialog (Imjoy.vue:2804)
    at JailedSite._processMessage (eval at Je (app.d5429779.js:1), <anonymous>:272:29)
    at JupyterConnection.eval [as _messageHandler] (eval at Je (app.d5429779.js:1), <anonymous>:84:10)
    at JupyterConnection.handle_data_message (eval at Je (evilEngine.js:19), <anonymous>:803:18)
(anonymous) @ FileDialog.vue:446
selectFileManager @ FileDialog.vue:441
(anonymous) @ FileDialog.vue:433
showDialog @ FileDialog.vue:344
showFileDialog @ Imjoy.vue:2804
JailedSite._processMessage @ VM74:272
eval @ VM74:84
handle_data_message @ VM80:803
comm.onMsg @ VM80:770
_handleCommMsg @ VM78:10
_handleMessage @ VM78:10
eval @ VM78:10
Promise.then (async)
_onWSMessage @ VM78:10
jailed.js:979 Plugin FileDialogTest_ng4ontdgv2: {'path': './', 'file_manager': {}}

This should have been fix via https://github.com/imjoy-team/jupyter-engine-manager/pull/15
I also added a new api variable which maybe suits better api.FILE_MANAGER_URL: https://imjoy.io/docs/#/api?id=apifile_manager_url-constant
@muellerflorian could you please close this issue if you confirm this error is resolved, thank you.

Tried it on the new Jupyter-Engine-Manager (v0.3.19) and unfortunately, the behavior remains as before and no correct file-dialog is displayed (same output in the console, and plugin log).


add _cached_sleep attribute to init

resolves #18
submitted for review / comment

I'm willing to close the pr, based on feedback, as rejected, withdrawn, whatever.
I've attached the code.py I was simulating with, and on a pico, under both 7.3.3 and 8.00 B2 I got errors as follows:
code.py output:
]0;🐍code.py | 8.0.0-beta.2\in sleeping setter
sleep_enabled = False
Traceback (most recent call last):
File "code.py", line 221, in
File "code.py", line 75, in init
File "code.py", line 122, in sleeping
AttributeError: 'SHTC3' object has no attribute '_cached_sleep'
<EMAIL_ADDRESS>AttributeError | 8.0.0-beta.2
Code done running.
Also, I would point out that the Sensirion SHTC3 datasheet says that "Upon VDD reaching the power-up voltage level VPOR, the SHTC3 enters the idle state after a duration of tPU. After that,
the sensor should be set to sleep mode with the command given in Table 9".  According to the way the class is organized, we should be setting the sleep function to true in the init.  Otherwise it will remain 'not in sleep mode' until the first measurement is taken, at which time on exit it will be set to sleep.
still happy to forget the whole thing though....
1
sim code.zip

closed as CNR (see discussion)


Spin.js - Encapsulate code into a module

That code is for the library spin.js, so it is better to encapsulate it into a module Spin to avoid conflicts.

spin/spin.d.ts
to authors(@borisyankov @theodorejb). could you review this PR?
:+1: or :-1:?
check list

[ ] pass the Travic-CI test?

I fixed it, didn't know the Travis tests were written in the *-tests.js file. Ready to get merged.


Add a method in eventMouse class to detect the right click and where it click

please check #8 and make a code review.


add proc transport option

A use case for it is setting up a connection to AWS Elasticsearch.
According to elasticsearch-transport's readme one should pass a block to ::ElasticsearchClient#initialize which adds necessary authorization headers to each request. However this can't be done with chewy.
A possible hack as it was discussed in the issue #296 is to assign Thread.current[:chewy_client] somewhere (say, in Rails initializer) with a custom instance. But this would affect only the current thread.
With :proc option it becomes possible to pass a block to Elasticsearch::Constructor.
So an example initializer for AWS tuning looks like this:
require 'faraday_middleware/aws_signers_v4'

Chewy.configuration[:transport_options] = {
  headers: { content_type: 'application/json' },
  proc: -> (f) do
      f.request :aws_signers_v4,
                service_name: 'es',
                region: 'us-east-1',
                credentials: Aws::Credentials.new(
                  ENV['AWS_ACCESS_KEY'],
                  ENV['AWS_SECRET_ACCESS_KEY'])
  end
}

P.S. For the purpose of Content-Type header see issue https://github.com/toptal/chewy/issues/271.

Thanks!

o_O  am i on an incorrect version? or is there something fundamental i'm not understanding here?


Revert "Sort order image fix"

Reverts Kitware/dive#690
1A, 1B, 2A, 2B cannot be sorted.
https://viame.kitware.com/#/viewer/5f52a395683ae84c2a4f63cb

#715 should resolve this.


what is the difference between DDP and single-GPU for profiler?

📚 Documentation
I use DDP strategy with Pytorch profiler to record the trace. I use the following code, is there something different between DDP and single-GPU for profiler?
profiler=PyTorchProfiler(     on_trace_ready=torch.profiler.tensorboard_trace_handler("lightning_logs/profiler/version_0"),     schedule=torch.profiler.schedule(wait=1, warmup=1, active=5) ) tb_logger=pl.loggers.TensorBoardLogger('./lightning_logs',version=0,name='profiler') trainer=pl.Trainer(max_epochs=100,accelerator='gpu',devices=[0,1,2],                    profiler=profiler,                    strategy='ddp',                    callbacks=[early_stop_callback,model_checkpoint_callback],                    gradient_clip_val=1,log_every_n_steps=2,                    logger=tb_logger) trainer.fit()
And I found 6 files in my log folder, for every workers I found two spans, In the span 1, there's no traces at all. In the span 2, the trace is found, but only trace for validation_step in it. By the way, there is no problem in single-GPU training, the optimizer_step will be recorded.

cc @borda

@awaelchli


alias (caching) question

I have this (very ugly) alias to just quickly show my local IP adresses:
alias localip="
printf '%s\n' '========================';
printf '%s\n' 'en0: \"$(ipconfig getifaddr en0)\"';;
printf '%s\n' 'en4: \"$(ipconfig getifaddr en4)\"';
printf '%s\n' '========================';
"

which is just an alias for executing the commands:
➔ ipconfig getifaddr en0
➔ ipconfig getifaddr en4

Somehow, the alias does not update correctly when my IP address changes. It does report the correct IP addresses when I reload my shell. This leads me to think that there is some alias caching going on, somewhere? is it just regular terminal logic to do this, or is this something (oh-my-)ZSH does?

When you use double quotes, whatever subcommands ($() or ``) or variables inside it are expanded to contain the actual value when the string is defined. If you don't want that to happen you have to use single quotes. This behavior happens across most shells, including zsh and bash.
That said, your alias is complex enough that you're better off with a function. You can also use echo or print for an easier syntax:
localip() {
    echo ========================
    echo en0: \"$(ipconfig getifaddr en0)\"
    echo en4: \"$(ipconfig getifaddr en4)\"
    echo ========================
}

or using cat <<-EOF with tabs:
localip() {
	cat <<-EOF
		========================
		en0: "$(ipconfig getifaddr en0)"
		en4: "$(ipconfig getifaddr en4)"
		========================
	EOF
}

ah, thanks for the feedback!


When doing write without response it is added to value

Hi,
I'm seeing an unexpected behaviour when doing a write without response on a characteristic. When writing something this same data is received on the stream property "value".
I have used some other BLE libraries on React native, Cordova, Go, Javascript... and never seen a behaviour like this. On all of these you never receive notifications with the same data you have just written on a characteristic, no matter if writing with or without response.
I have checked the code and seen that it is done on then write method:
if (type == CharacteristicWriteType.withoutResponse) {
    _value.add(value);
    return result;
}

If there is a use case for this strange behaviour, maybe could it be configured to work like on the rest of BLE libraries with some option on write?

Same here, latest update on "write without response" seems bizarre

same for me with c.write(withoutResponse: false), i receive data on my listeners for c.value.listen()

The use case here is to assume that if the write platform call completed successfully, but was without response, to internally update the characteristic anyways, so that the example app showed the correct value in the UI.  I do believe this is leading to a duplicate notification when the user writes with response.

I understand the case of the example app, the problem is that this behaviour breaks a more typical use of characteristic to send and receive messages to a BLE device.
The typical example of this is sending messages to a device (serialized as JSON, msgpack...) writing to some characteristic and receiving its responses listening for notifications on it. So you can be sure that everything you read on that characteristic comes from the device.
Right now the current behaviour makes this difficult.
Also, as I mentioned I haven't seen this behaviour on other BLE libs so maybe it's better for users to try to behave in the same way everyone else works.
As for the example app maybe this should be done on its own code rather than on the lib?

The typical example of this is sending messages to a device (serialized as JSON, msgpack...) writing to some characteristic and receiving its responses listening for notifications on it. So you can be sure that everything you read on that characteristic comes from the device.

+1
At least, it should be possible to distinguish, what the cause for the notification was (a write from within the app or a response from the device), maybe carry a sender attribute or something if you want to support both use cases.

I agree with @soyangel and @khainke here. I think that to avoid confusion this feature should be turned off by default, if it's kept at all. Filtering the data you receive in notifications to ensure that values you receive are actually what you receive and not trying to write feels backwards and not something that you would expect to do.
At the minimum there should be an easy way to distinguish which notifications that comes from the write operation and the device itself.

I agree with others. Currently I'm forced to do a fork of your library just to comment out this line. Because of a specific of a protocol I use, sometimes I get a response from a previous send operation because of a _value.add(value); line. And it makes me cry.

Yikes, sorry this has taken me so long, fix coming tonight!


Title: A feature to check the accurate bmi

We can implement a fragment where we can take information and give an accurate BMI of the user.

Hey @Vrushali-anil-Chaudhari I want to work on this issue. please assign me this issue.

@Vrushali-anil-Chaudhari I will try my best

Hello, @Vrushali-anil-Chaudhari @ashutosh321607 i want to work on this issue. please assign it to me.

Yes @Vrushali-anil-Chaudhari, I am a beginner in this GSSOC'22, so please assign this task to me so that I can learn and complete this task.
Thanks!!

@Vrushali-anil-Chaudhari I intend to implement these two screens for the required fragment.
Formula that should be used for calculating BMI -> Weight (in KGs) / (Height in metres)^2
Also, trying to get the data for age specific calculations too. I am researching on that presently. When found, I also intend to add a 'Age' field in the first screen.
Fonts and colors will be according to the ones used in the project.
Please review these screens, and provide your valuable input as to what changes are required further.
Thanks!

Hi everyone, It's good to see your interest in the app. However, the issues are to be created by the mentors and the PAs only. Surely, we will consider your ideas, and for that reason, we have the discord channel active in GSSoC . For the issues that have been created up till now, we will have to close them.


[Snyk] Upgrade next from 13.3.4 to 13.4.4

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade next from 13.3.4 to 13.4.4.
As this is a private repository, Snyk-bot does not have access. Therefore, this PR has been created automatically, but appears to have been created by a real user.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 46 versions ahead of your current version.
The recommended version was released a month ago, on 2023-05-25.

Release notes

Package name: next

13.4.4 - 2023-05-25 Read more

13.4.4-canary.13 - 2023-05-25Misc Changes

makeDir should use func: #50136

Credits
Huge thanks to @ 05lazy for helping!

13.4.4-canary.12 - 2023-05-25Core Changes

Fix SWC loader options for files outside of RSC layers: #50341

Credits
Huge thanks to @ shuding for helping!

13.4.4-canary.11 - 2023-05-25Core Changes

do not apply sass loader on existing loaders: #50308
Add missing react-dom/client alias: #50324
Fix missing error when using Actions on the client layer without enabling the feature flag: #50257
remove allowlist, only use denylist, enable newly passing tests: #50325

Misc Changes

Fix middleware e2e deploy test: #50317
Parallelize Turbopack CI tests: #50292

Credits
Huge thanks to @ ijjk, @ sokra, @ huozhi, and @ shuding for helping!

13.4.4-canary.10 - 2023-05-25Core Changes

Alias next/server for edge runtime: #50268
[turbopack]: Serve _devMiddlewareManifest.json from router: #50241
Fix catch-all edge app route: #50313
land: Include charset=utf-8 with x-component Content-Type header: #50314

Credits
Huge thanks to @ huozhi, @ jridgewell, and @ ijjk for helping!

13.4.4-canary.9 - 2023-05-24Core Changes

Remove static analysis of process.env: #50260
Update next start listening to behave consistently: #50293
Update server invoke-request: #50296
Update unstable_cache key to include args: #50301
Add root detection utils: #50305
fix sass handling after refactoring: #50259

Credits
Huge thanks to @ javivelasco, @ ijjk, @ padmaia, and @ sokra for helping!

13.4.4-canary.8 - 2023-05-24Core Changes

feat(next-swc): Add CJS optimizer again: #50249
Fix edge case in the CJS optimizer: #50258

Credits
Huge thanks to @ kdy1 and @ shuding for helping!

13.4.4-canary.7 - 2023-05-24Core Changes

Revert "feat(next-swc): Implement CJS optimizer": #50247
Fix free port handling: #50248

Misc Changes

Fix metadata e2e deploy test: #50252

Credits
Huge thanks to @ ijjk for helping!

13.4.4-canary.6 - 2023-05-23Core Changes

feat(next-swc): Implement CJS optimizer: #49972
Fix alias for react-dom/server: #50238

Credits
Huge thanks to @ kdy1 and @ huozhi for helping!

13.4.4-canary.5 - 2023-05-23Core Changes

change static path to /_next/static/media: #50207
Add special route types to the link type declaration: #50066
fix: NODE_OPTIONS='--inspect' in next dev for debugging: #48019
enable more test cases for turbopack: #50154

Example Changes

Use correct casing in filenames: #50223

Credits
Huge thanks to @ sokra, @ shuding, @ padmaia, and @ Cow258 for helping!

13.4.4-canary.4 - 2023-05-23

13.4.4-canary.3 - 2023-05-23

13.4.4-canary.2 - 2023-05-23

13.4.4-canary.1 - 2023-05-22

13.4.4-canary.0 - 2023-05-19

13.4.3 - 2023-05-19

13.4.3-canary.3 - 2023-05-19

13.4.3-canary.2 - 2023-05-17

13.4.3-canary.1 - 2023-05-16

13.4.3-canary.0 - 2023-05-12

13.4.2 - 2023-05-11

13.4.2-canary.6 - 2023-05-11

13.4.2-canary.5 - 2023-05-11

13.4.2-canary.4 - 2023-05-10

13.4.2-canary.3 - 2023-05-09

13.4.2-canary.2 - 2023-05-08

13.4.2-canary.1 - 2023-05-08

13.4.2-canary.0 - 2023-05-08

13.4.1 - 2023-05-05

13.4.1-canary.2 - 2023-05-05

13.4.1-canary.1 - 2023-05-04

13.4.1-canary.0 - 2023-05-04

13.4.0 - 2023-05-04

13.3.5-canary.12 - 2023-05-04

13.3.5-canary.11 - 2023-05-04

13.3.5-canary.10 - 2023-05-04

13.3.5-canary.9 - 2023-05-04

13.3.5-canary.8 - 2023-05-04

13.3.5-canary.7 - 2023-05-03

13.3.5-canary.6 - 2023-05-03

13.3.5-canary.5 - 2023-05-03

13.3.5-canary.4 - 2023-05-03

13.3.5-canary.3 - 2023-05-02

13.3.5-canary.2 - 2023-05-02

13.3.5-canary.1 - 2023-05-01

13.3.5-canary.0 - 2023-05-01

13.3.4 - 2023-05-01

    from next GitHub release notes

Commit messages

Package name: next

26835bd v13.4.4
8c17a4b v13.4.4-canary.13
2b5205a makeDir should use func (#50136)
0c968b8 v13.4.4-canary.12
592f592 Fix SWC loader options for files outside of RSC layers (#50341)
3870abf v13.4.4-canary.11
187d1bf remove allowlist, only use denylist, enable newly passing tests (#50325)
25ce787 Fix missing error when using Actions on the client layer without enabling the feature flag (#50257)
8725b6c Add missing react-dom/client alias (#50324)
46369f5 do not apply sass loader on existing loaders (#50308)
06f505c Parallelize Turbopack CI tests (#50292)
3c67583 Fix middleware e2e deploy test (#50317)
831a1a9 v13.4.4-canary.10
e09efd5 land: Include charset=utf-8 with x-component Content-Type header (#50314)
027aa72 Fix catch-all edge app route (#50313)
12e22ed [turbopack]: Serve `_devMiddlewareManifest.json` from router (#50241)
1079c10 Alias next/server for edge runtime (#50268)
ed60646 v13.4.4-canary.9
e15eb2a fix sass handling after refactoring (#50259)
e257068 Add root detection utils (#50305)
a7a9777 Update unstable_cache key to include args (#50301)
1619a6a Update server invoke-request (#50296)
47546dd Update next start listening to behave consistently (#50293)
aa91de5 Remove static analysis of `process.env` (#50260)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

oppdatert i siste release


Space between icon and name missing for single node in HTML

Usually, the plugin renders a space between the icon and the name for a node:

You can see the default space between statusline elements at position 1, the icon at position 2 and a space at position 3
(Note: The icon extends to position 3 a little because I am using a not-strictly-monospace Nerdfont (CaskaydiaCove Nerd Font instead of CaskaydiaCove Nerd Font Mono) and there is space for it to do so.)
However, in HTML files, this space is missing when only a single node is displayed:

Here, position 1 is still the seperating space between statusline elements, position 2 is still occupied by the icon (now a little squeezed because it can't extend to more space on the side), and position 3 already starts the tag name.
Strangely, I've also done a quick test for other languages and wasn't able to replicate this behaviour there. Sadly, I can't access another installation right now to confirm this, so maybe someone else could chime in and confirm if this also happens for others.

I've quickly switched the font to the Mono variant of the CaskaydiaCove Nerd Font that forces the icons to use the same space as anything else to get some more images.
Normal behaviour with a space at pos3 (between icon and name):

And the single-node behaviour with the 'h' from the tag name at pos3:

The plugin is returning the same amount of spacing between the icon and the text in both the cases you mentioned. Rendering of nerdfonts properly is the job of the terminal emulator and it can be hit or miss sometimes.
I would suggest you could try changing terminal emulators and/or Font to see if this issue is fixed.
You could also append one more space to the tag icon or change the tag icon to something else.


Support different height maps

This PR adds an alternative height map for HeightMapWorldGenerator and introduces different WrapModes that define the area outside the heightmap. Here's an example based on the new "Opposing Islands" map with WrapMode "CLAMP" (border pixels are repeated, creating an infinite ocean).

Note that you will spawn in the ocean on that map. Configuring spawning positions is still an open issue (#1379).

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/35/
Hooray Jenkins reported success with all tests good!

Oooohhh that other noise type image of the opposing islands .... so pretty!
Merged in, reminded self of https://github.com/MovingBlocks/Terasology/pull/1651#issuecomment-85768901 which is still a thing (grass blocks start at a wrong level). We should probably throw that in a quick issue unless fixing soon so we don't forget again :-)

That should be fixed already. I found a piece of grass on the beach just one level above the water surface:

Maybe the grass density could be increased for the BEACH biome.

Oh that's a grass billboard they seem fine - look at the dirt blocks in the background. Those should likely be grass blocks which becomes very apparent in some "fields of dirt" you might normally expect to be plains :-)


msgpack can not pack my custom class

Hi,
I tried to switch to Pyro4 with zerorpc but one of my custom class instance can not be packed by msgpack. Here is the issue link: https://github.com/msgpack/msgpack-python/issues/96
Could we tell zerorpc to use pickle instead of msgpack?

@mauricioabreu So we use msgpack to serialize our custom classes. How do we implement this into zerorpc? Like @bombela said, this is implementing our own serialization layer (and he advices against it). I'm trying to use zerorpc with dockerpy and it's not gonna work because we can't serialize the Docker client class with msgpack.

You can absolutely implement your own serialization layer. I am not advising against it at all.
I wasn't clear enough, I am against using picke to serialize code to send it across the network. This sounds dangerous to me.
I don't think we can easily allow the integration of msgpack user defined type in zerorpc, and here's few reason why:

zerorpc is language agnostic.
zerorpc command line expect to be able to introspect everything, independent of the language used on the server.
zerorpc supports the notion of proxy, including proxy that are able to rewrite the serialization used (think for example, of a zerorpc proxy between websocket & json to/from zmq & msgpack.
zerorpc is not tied to msgpack.
zerorpc limits itself to json-like datatype for the above reasons.

To restate, you can absolutely serialize via msgpack with your custom type onto some binary blob that you then pass-trough zerorpc.
Now, for the technical bits and performances; I am pretty sure that adding another layer of serialization wont affect much.  Thanks for the hasty response man.


Add more information and structure on standards and certification

Aim of this PR is to get users of the docs page an overview and detail information about the certification involving the standards and the decision records. In order to understand it is important to expose the process and explain the concept with concise structure and vocabulary.

adding better structure, overview with tables and cross references of standards and their metadata such as state, versions, certification and decision records
implementing content from @alexander-diab and @mbuechse
adding first drafts of visualisations

This first version has a manually edited structure and content. Potential improvement could be to get a lot of this generated via the metadata/frontmatter within the standards.
closes #60 via User Experience
Preview Deployment: https://docs-staging.scs.community/standards

@anjastrunk I replaced subject by scope and also fixed the other typos you found: https://github.com/SovereignCloudStack/docs/pull/76/files/bd6f388ec97166d90d4b823743f8114d6a7e1de5..080cd241bdb72dce0f7729c8a03f86e0d8127058
Now on to the actual revision...


rectangle matmul with shared memory python

Shared memory 2D python rectangle matmul implementation fixes.
Mimic CUDA __syncthreads with python threading.Barrier.

Thanks Kerem! :D


data() is not available

Not sure this is on purpose, but it seems that
wrapper.data() is no longer valid.
Is it preferred to use the vm object directly?
It's still in the API docs of setData() that's why I'm asking.
I checked, and it's no longer in the source code, so I guess it was removed.
Should I update the documentation accordingly?

Yes it's preferred to use the vm.
Great catch 😄 , yes it would be appreciated if you could update the docs

This was taken care off in https://github.com/vuejs/vue-test-utils/pull/19

#19 was merged into master, which means it'll be overwritten when we release. This needs to be merged into the dev branch

I imagine it's my turn to close this 😆


fix; missing null declaration for ts serialization

follow up to #5106

additional context https://github.com/microsoft/kiota-samples/actions/runs/10378049975

additional context https://github.com/microsoft/kiota-samples/commit/26e8e214ba6d9f48d7e9d4468300888ba7df905c

additional context https://github.com/microsoft/kiota-samples/commit/a3e549dc94f5bfa7db5c5b3107975fe7d7d4030c


brew bundle install: circular reference error between aom & libavif regardless of formulae being installed

Asked about this in Discussions, but got no replies.
Description of issue
Circular reference error between aom & libavif when running brew bundle install regardless of what formulae you're trying to install.
Same error also occurs for brew bundle dump.
$ brew update
==> Updating Homebrew...
Already up-to-date.
$ brew uninstall --ignore-dependencies --force aom libavif
$ brew install aom libavif
## successful install, which includes `aom` dependency
$ echo 'brew "trash"' > Brewfile
$ brew bundle install
Error: Formulae dependency graph sorting failed (likely due to a circular dependency):
aom: ["brotli", "giflib", "highway", "imath", "jpeg-turbo", "libpng", "xz", "lz4", "zstd", "libtiff", "little-cms2", "libdeflate", "openexr", "webp", "jpeg-xl", "libvmaf"]
libavif: ["brotli", "giflib", "highway", "imath", "jpeg-turbo", "libpng", "xz", "lz4", "zstd", "libtiff", "little-cms2", "libdeflate", "openexr", "webp", "jpeg-xl", "libvmaf", "aom"]
Please run the following commands and try again:
  brew update
  brew uninstall --ignore-dependencies --force aom libavif
  brew install aom libavif

Output of brew config
HOMEBREW_VERSION: 4.4.9
ORIGIN: https://github.com/Homebrew/brew.git
HEAD: 2e780004c92f16a96036d3d43569c2924c4e54f5
Last commit: 20 hours ago
Branch: stable
Core tap HEAD: 4d73290de50e419551fec93274dcf90ec3a8c496
Core tap last commit: 7 hours ago
Core tap JSON: 03 Dec 16:49 UTC
Core cask tap HEAD: 83a256ee8d415704148a2464693eea10cbee8ad0
Core cask tap last commit: 7 hours ago
Core cask tap JSON: 03 Dec 16:49 UTC
HOMEBREW_PREFIX: /usr/local
HOMEBREW_CASK_OPTS: []
HOMEBREW_DISPLAY: /private/tmp/com.apple.launchd.leDjcUyI3t/org.xquartz:0
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 4
HOMEBREW_NO_ANALYTICS: set
HOMEBREW_SORBET_RUNTIME: set
Homebrew Ruby: 3.3.6 => /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/3.3.6/bin/ruby
CPU: quad-core 64-bit haswell
Clang: 14.0.0 build 1400
Git: 2.47.1 => /usr/local/bin/git
Curl: 8.7.1 => /usr/bin/curl
macOS: 12.7.6-x86_64
CLT: <IP_ADDRESS>.1.1668646533
Xcode: 14.2

Output of brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: You have unlinked kegs in your Cellar.
Leaving kegs unlinked can lead to build-trouble and cause formulae that depend on
those kegs to fail to run properly once built. Run `brew link` on these:
  cffi

Warning: You are using macOS 12.
We (and Apple) do not provide support for this old version.
It is expected behaviour that some formulae will fail to build in this old version.
It is expected behaviour that Homebrew will be buggy and slow.
Do not create any issues about this on Homebrew's GitHub repositories.
Do not create any issues even if you think this message is unrelated.
Any opened issues will be immediately closed without response.
Do not ask for help from Homebrew or its maintainers on social media.
You may ask for help in Homebrew's discussions but are unlikely to receive a response.
Try to figure out the problem yourself and submit a fix as a pull request.
We will review it but may or may not accept it.

Has nothing to do with brew bundle

@SMillerDev What creates the dependency graph?
Is there any way it can avoid circular dependencies causing a problem?
If not, is the only option to change the formulae to not have a circular dependency?


[README]: Add Relative GitHub Image URL Support to README.md

Related Problem
I would like to reuse my GitHub README.md in my NuGet package. I would like to use relative URL's for their simplicity but they are currently not supported.
The Elevator Pitch
If you see that my NuGet package source repository is GitHub and contains:
<RepositoryUrl>https://github.com/RehanSaeed/Serilog.Enrichers.Span.git</RepositoryUrl>

Then automatically prefix the relative URL e.g. /Images/Foo.png with https://github.com/RehanSaeed/Serilog.Enrichers.Span/blob/main.
Additional Context and Details
This could also work for relative links to files e.g. linking to CONTRIBUTING.md using a relative link could also work.

@RehanSaeed, thanks for suggestion. We do support use relative URL's to render your readme. It was our legacy readme workflow, it might be depercated in the future. If you already have embedded readme, we are not allowed to use legacy readme.

We now have embedded readme future, which is more user friendly. Please check details here about how to include your readme file in your package: https://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/

My suggestion is that NuGet allows relative URL's in embedded README.md files. In theory you have all the information needed in the package to work out the full URL's.

Hi @RehanSaeed,
I think this is a great idea, but there would be some complications I can think of.
When you pack a package with a README and repo URL, we have the following:

the relative path to the README from project file
the relative paths to the images from the README
the repo root URL

Unfortunately, we don't have the path to the project file - so we can't reliably figure the absolute URL to the image depending on the repo structure.
We the main branch also might not be named "main".
@loic-sharma @lyndaidaii What do you think? Anything I'm missing that could solve this issue? I imagine a lot of users have relative paths to images - so figuring this out could be pretty valuable.

I would also love to see this implemented. I love the idea of being able to reuse my repo README inside my NuGet package. That would make documentation updates so much easier. Unfortunately, this image issue is a pretty serious blocker to that workflow; in fact, it's the primary reason I haven't made the switch yet. My repo README has lots of screenshots to assist with setup, and they all use relative image URLs because that's one of the easiest ways to set up custom images in a GitHub repo. I see that nuget.org already trusts GitHub badges and raw.github.com (CDN) URLs. Why not support any GitHub URL? I assume there's some security-related reason, but I can't imagine why you wouldn't want to support images from the world's most popular open source host.

Related:

2021-05-06 https://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/

Due to security and privacy concerns, NuGet.org will only support badges and images from a trusted allow-list of sources. Unfortunately, links to local images won’t be supported at this time either. Consider hosting local images in one our trusted sources to produce a link to include in your NuGet.org README.

https://github.com/NuGet/NuGetGallery/issues/9610

https://github.com/NuGet/NuGetGallery/issues/9610#issuecomment-1751104402

It looks like many people (including Microsoft package owners) are trying this intentionally or perhaps unintentionally if they are just re-using their GitHub README.

This comment includes tables of packages re-using their GitHub readmes, resulting in the package readme's relative-path images not being displayed on nuget.org.

Chris brought up good points.
Should relative links resolve to images in the source commit in the source repository? This seems to be what "most" users desire. If an asset fails to resolve for whatever reason, should Nuget.org fail-over to to resolving to package assets?
If the source repository or commit is private, undefined, or is otherwise inaccessible, then relative paths can only resolve to a package asset or to an asset on a trusted domain.
If a public package's source repo is private, then its readme should use publicly-accessible absolute paths for its media. If the asset reflects changes in a release (e.g. an image of an app's UI), the absolute path should be namespaced or otherwise labelled for the release's version/commit. The package authors should run a script in the release pipeline to update the absolute path(s) and ensure assets are made available at those paths before the release completes successfully. If the release fails, the assets may need to be rolled back.
What if the repository isn't GitHub? An image in a repository pushed to both GitHub and GitLab will have more differences in their absolute path than just the domain and subdomain. Support for a given source repo host will need to be implemented explicitly.


CHanged status code on Unregister to no content

Normally a status code change would be considered a breaking change, but I don't think anyone is watching this status code for unregistering.

This is how the client code checks status
if resp.StatusCode >= 300 {


Create sk.json

new language created

Hi, thanks you for your contribution. But have you any reason to still use this component vs the Core component?

Thank you @misa1515! Unfortunately this custom component won't receive any new fixes. Please use the core integration for the latest version (including translations!).


resources: refactor to comply with latest implementation

... Note: Some tests still failing

Passing in devel https://travis-ci.org/github/inveniosoftware/invenio-drafts-resources/builds/731188312


phantomAdd.getNode() returning null

We are seeing an issue with editing in full offline mode. The workflow is as follows:

Open the app online
Next disconnect from wireless.
Next restart browser (so now in full offline mode)
Make an edit (add new feature). We have two feature layers offline enabled. One or other seems to be failing (no point feature added to map and no attribute inspector)

Looking at console we see .
Uncaught TypeError: Cannot read property 'setAttribute' of null
m.set	@	dojo.js:139
(anonymous function)	@	offline-edit.js:977
transaction.oncomplete	@	offline-edit.js:2500
With a breakpoint at line 977 in offline-edit.js we see phantomAdd.getNode() is returning null

Is there a chance you are accidentally running two instances of OfflineFeaturesManager, one for each feature layer?
There should be only one instance of OfflineFeaturesManager per application, and it can then extend() multiple feature layers. However, the library is behaving in a way that implies each of the two feature layers is running under a separate instance. For example, each new edit has a unique temporary id and I'm seeing duplication of that temp id between the layers. That would partly explain some of the odd behavior between the two.

Looks like that might be the problem Andy. I'm seeing two calls to new
O.esri.Edit.OfflineFeaturesManager().
On 20 August 2015 at 12:26, Andy<EMAIL_ADDRESS>wrote:

Is there a chance you are accidentally running two instances of
OfflineFeaturesManager, one for each feature layer?
There should be only one instance of OfflineFeaturesManager per
application, and it can then extend() multiple feature layers. However,
the library is behaving in a way that implies each of the two feature
layers is running under a separate instance. For example, each new edit has
a unique temporary id and I'm seeing duplication of that temp id between
the layers. That would partly explain some of the odd behavior between the
two.
—
Reply to this email directly or view it on GitHub
https://github.com/Esri/offline-editor-js/issues/407#issuecomment-133109227
.

--
Matt Sheehan | WebMapSolutions
Mobile:<PHONE_NUMBER> | Email<EMAIL_ADDRESS><EMAIL_ADDRESS>

Matt, did this solve the issue?

You can close it Andy. This is a bug in our implementation. Thanks.
On 1 September 2015 at 12:12, Andy<EMAIL_ADDRESS>wrote:

Matt, did this solve the issue?
—
Reply to this email directly or view it on GitHub
https://github.com/Esri/offline-editor-js/issues/407#issuecomment-136815574
.

--
Matt Sheehan | WebMapSolutions
Mobile:<PHONE_NUMBER> | Email<EMAIL_ADDRESS><EMAIL_ADDRESS>


postgres installed failed

Dear expert,
I'm trying to install the postgres db for gerrit, and use https://github.com/openfrontier/ci.git to install all of it. But it stucks in "waiting postgres ready.", can you please help on this?
After viewing the logs of pg-gerrit container, I get the following infomation:
root@csgle:/# docker logs pg-gerrit
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.
The database cluster will be initialized with locale "en_US.utf8".
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".
Data page checksums are disabled.
fixing permissions on existing directory /var/lib/postgresql/data ... ok
creating subdirectories ... ok
selecting dynamic shared memory implementation ... posix
selecting default max_connections ... 100
selecting default shared_buffers ... 128MB
selecting default time zone ... Etc/UTC
creating configuration files ... ok
running bootstrap script ... ok
performing post-bootstrap initialization ... ok
syncing data to disk ... ok
Success. You can now start the database server using:
pg_ctl -D /var/lib/postgresql/data -l logfile start

initdb: warning: enabling "trust" authentication for local connections
You can change this by editing pg_hba.conf or using the option -A, or
--auth-local and --auth-host, the next time you run initdb.
waiting for server to start....2020-04-18 06:34:14.702 UTC [46] LOG:  starting PostgreSQL 12.2 (Debian 12.2-2.pgdg100+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 8.3.0-6) 8.3.0, 64-bit
2020-04-18 06:34:14.930 UTC [46] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2020-04-18 06:34:15.155 UTC [47] LOG:  database system was shut down at 2020-04-18 06:34:12 UTC
2020-04-18 06:34:15.210 UTC [46] LOG:  database system is ready to accept connections
done
server started
CREATE DATABASE
/usr/local/bin/docker-entrypoint.sh: ignoring /docker-entrypoint-initdb.d/*
2020-04-18 06:34:33.440 UTC [46] LOG:  received fast shutdown request
waiting for server to shut down....2020-04-18 06:34:33.497 UTC [46] LOG:  aborting any active transactions
2020-04-18 06:34:33.500 UTC [46] LOG:  background worker "logical replication launcher" (PID 53) exited with exit code 1
2020-04-18 06:34:33.501 UTC [48] LOG:  shutting down
2020-04-18 06:34:34.235 UTC [46] LOG:  database system is shut down
done
server stopped
PostgreSQL init process complete; ready for start up.
2020-04-18 06:34:34.643 UTC [1] LOG:  starting PostgreSQL 12.2 (Debian 12.2-2.pgdg100+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 8.3.0-6) 8.3.0, 64-bit
2020-04-18 06:34:34.643 UTC [1] LOG:  listening on IPv4 address "<IP_ADDRESS>", port 5432
2020-04-18 06:34:34.643 UTC [1] LOG:  listening on IPv6 address "::", port 5432
2020-04-18 06:34:34.951 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
2020-04-18 06:34:35.199 UTC [64] LOG:  database system was shut down at 2020-04-18 06:34:34 UTC
2020-04-18 06:34:35.258 UTC [1] LOG:  database system is ready to accept connections
Here are the install infos:
root@csgle:/# ~/ci/run.sh
38c1f4a56602a5eb6c6561a0be32facba4436a0c40367c766290eefc48733a02
Create nexus volume.
57644346b0c2bac7e36c9e265342f3a4c6a080ad80e87680494174fb27f1a222
openldap-etc-volume
openldap-repo-volume
329f2917911e7ea5cb26bb893b5bc8ed22b5147bd50b168de7e47b95213442f5
Waiting openldap ready.
Waiting openldap ready.
Waiting openldap ready.
Waiting openldap ready.
Waiting openldap ready.
adding new entry "ou=gerrit,dc=example,dc=com"
adding new entry "ou=accounts,dc=example,dc=com"
adding new entry "cn=group,ou=accounts,dc=example,dc=com"
adding new entry "uid=admin,ou=accounts,dc=example,dc=com"
15435222f1a3f39de6e5a574b429f13b679500dd51bd65dce087bdc51e9a8484
pg-gerrit-volume
f30bd6093e151168ffb1a2beae72139c33d8ec3c60c7c0265068e735b6ac5f86
Waiting postgres ready.
Waiting postgres ready.
Waiting postgres ready.
Waiting postgres ready.
Waiting postgres ready.
...
...
Waiting postgres ready.
...
...

Waiting postgres ready. is message output from https://github.com/openfrontier/ci.git
As far as the container itself is concerned: LOG: database system is ready to accept connections means it's fully initialized and ready for work

Dears,
Thanks for your reply here. If it's fully initialized and ready for work, can you please help me know why it stucks in creating the postgres container?
From creatGerrit.sh file in https://github.com/openfrontier/gerrit-docker, it require a log infomation "autovacuum launcher started", but there is no such log in docker logs pg-gerrit, how to make the gp-gerrit container to output log ‘autovacuum launcher started’？
createGerrit.sh:
while [ -z "$(docker logs ${PG_GERRIT_NAME} 2>&1 | grep 'autovacuum launcher started')" ]; do
echo "Waiting postgres ready."
sleep 1
done

It seems Postgres doesn't have that log output after version 9
Similar to https://github.com/docker-library/postgres/issues/570 the postgres: autovacuum launcher process  is running but doesn't output in the logs that it is doing so.
I started containers for each version and checked for "vacuum" in the logs:
$ docker logs postgres8 2>&1 | grep -i autovacuum
LOG:  autovacuum launcher started

$ docker logs postgres9 2>&1 | grep -i autovacuum
LOG:  autovacuum launcher started
LOG:  autovacuum launcher shutting down
LOG:  autovacuum launcher started

$ docker logs postgres10 2>&1 | grep -i autovacuum

$ docker logs postgres11 2>&1 | grep -i autovacuum

$ docker logs postgres12 2>&1 | grep -i autovacuum

Checking the processes inside the containers for autovacuum
$ docker exec postgres8 ps aux | grep vacuum
postgres     53  0.0  0.0 113796  4436 ?        Ss   15:45   0:00 postgres: autovacuum launcher process

$ docker exec postgres9 ps aux | grep vacuum
postgres     59  0.0  0.0 287864  6332 ?        Ss   15:43   0:00 postgres: autovacuum launcher process

$ docker exec postgres10 ps aux | grep vacuum
postgres     59  0.0  0.0 288684  6632 ?        Ss   15:43   0:00 postgres: autovacuum launcher process

$ docker exec postgres11 ps aux | grep vacuum
postgres     60  0.0  0.0 289052  6260 ?        Ss   15:42   0:00 postgres: autovacuum launcher

$ docker exec postgres12 ps aux | grep vacuum
postgres     59  0.0  0.0 214396  6836 ?        Ss   15:45   0:00 postgres: autovacuum launcher

Thanks for your reply.
It looks to me that my server has pre-installed postgres default, can you please help me know how to modify the script file to use my default postgres?

I would try asking over at the Docker Community Forums, Docker Community Slack, or Stack Overflow. Since these repos aren't really a user-help forum
Going to close since this isn't an issue with the image


Update sln file with aggregates

VSCode workspaces expects the solution file to be in the first folder; it will then provide a Solution Explorer for the solution and intellisense will work correctly.
the vscodeAddServices.ps1 script will update the .sln file if it is in the .vssolution folder; if not, it will create it there first and then update it.

closing because we are not going to do this per discussion


Fixes for velcovgeodetic publishing and setting of antenna type

Fixes for velcovgeodetic publishing and setting of antenna type

Thank you for merging, Yes, I had to consult the reference guide again to find out about the "" needed for the antenna type :-)


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target/pull/773 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target.git

Docs Build status updates of commit a29c0ec:
Pending

Docs Build status updates of commit a29c0ec:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch Release_Archive_master_2021-02-02-09-12-47 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Move OrgnisationUser to UserPermission

Context
Changes proposed in this pull request
Guidance to review
Checklist

[ ] Make sure all information from the Trello card is in here
[ ] Attach to Trello card
[ ] Rebased master
[ ] Cleaned commit history
[ ] Tested by running locally

end of spike


It is hoped that parameters can be added to control the log output format.

The line-by-line output method is easier to be recognized by the monitoring program,
like this:
plot progress: 31%,time:00:38,eta:06:12
plot progress: 32%,time:00:39,eta:06:12
....
plot progress: 100%,time:06:39

I can add it to the next update, and output a log to file as well as the console UI.
Is there any extra information you want to see in the logs?

I did't need more information in the log,   the progress number update always in same line,that made my Java monitor program resolve the wrong string. it always return "redicted output returning" instead of correct log line information ”9% .........  00:38  06:12“
Progress          Time    ETA
9% \.........  00:38  06:12


[enhancement] ban runtime use of Python's property in sklearnex

Description
using property at runtime is un-pythonic and confusing.  This bans the practice (will require some refactoring of LinearRegression-derived classes).

Checklist to comply with before moving PR from draft:
PR completeness and readability

[x] I have reviewed my changes thoroughly before submitting this pull request.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
[x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
[x] I have added a respective label(s) to PR if I have a permission for that.
[x] I have resolved any merge conflicts that might occur with the base branch.

Testing

[x] I have run it locally and tested the changes extensively.
[x] All CI jobs are green or I have provided justification why they aren't.
[x] I have extended testing suite if new functionality was introduced in this PR.

Performance

[x] I have measured performance for affected algorithms using scikit-learn_bench and provided at least summary table with measured data, if performance change is expected.
[x] I have provided justification why performance has changed or why changes are not expected.
[x] I have provided justification why quality metrics have changed or why changes are not expected.
[x] I have extended benchmarking suite and provided corresponding scikit-learn_bench PR if new measurable functionality was introduced in this PR.

/intelci: run

/intelci: run


⚠ NGINX has degraded performance

In 63ab1b9, NGINX (https://web.sshcdn.com) experienced degraded performance:

HTTP code: 200
Response time: 27926 ms

Resolved: NGINX performance has improved in 7b73b2c.


Case looks closed, but spihelper thinks it's not

https://en.wikipedia.org/w/index.php?title=Wikipedia:Sockpuppet_investigations/Gordimalo&oldid=1023727341
If you run More/SPI-Archive, you get:
Purged Wikipedia:Sockpuppet investigations/Gordimalo
Done!
If you run the interactive script, "Archive case" is greyed out.  I assume there's something broken in the markup that's not letting it be parsed properly, but I can't spot it.

The case status was in the top-level section rather than the date-level section. I could add a check for this situation.

Duplicate of #40.


Reduce the size of tarball to continue ASF release

the reason can see in https://lists.apache.org/thread/rmp7fghlj0n7h9y2v3p8gkw9f9qbo6qt
the major change in this patch is:

Add module dolphinscheduler-task-all-prune only contain artifactId starting with dolphinscheduler-task- to reduce the third part library from task plugin, cause service api-server and master-server only need dolphinscheduler-task- to verify parameter(api-server), get local parameter and resource(master-server), so it does not need others third-party dependence
Remove some not use dependencies in api-server and master-server.
Module tools dynamic load libs from other servers in binary tarball.

the binary tarball size is reduced to ASF limit 950MB
- -rw-r--r-- 1.2G apache-dolphinscheduler-dev-SNAPSHOT-bin.tar.gz
+ -rw-r--r-- 860M apache-dolphinscheduler-dev-SNAPSHOT-bin.tar.gz

Codecov Report

:exclamation: No coverage uploaded for pull request base (3.2.0-release@ab306ce). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head d622843 differs from pull request most recent head 7366a15. Consider uploading reports for the commit 7366a15 to get more accurate results

@@               Coverage Diff                @@
##             3.2.0-release   #15004   +/-   ##
================================================
  Coverage                 ?   38.84%
  Complexity               ?     4679
================================================
  Files                    ?     1289
  Lines                    ?    44299
  Branches                 ?     4855
================================================
  Hits                     ?    17206
  Misses                   ?    25190
  Partials                 ?     1903

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Need to check docker and k8s way.

We need to modify the license file.

Need to check docker and k8s way.

@caishunfeng  could you help check k8s?

Need to check docker and k8s way.

Seems we already have K8S test in our CI


Migrate marketplace listing to IBM org on github

New repo is
github.com/IBM/azure-marketplace-arm-templates

Completed - refer to new repo https://github.com/IBM/azure-marketplace-arm-templates


Bug fix: ReadShapes creates some of shapes cannot be moved

ReadShapes creates some of shapes cannot be moved.

Perhaps dup of  #6.

Anyway fixed in v1.97b.


Javascript can't handle generated/analyzed json file (missing information)

The run_analyzer.cmd works now and I get a result json.
But the javascript cant handle it, because the json is missing a lot of information. (the whole "info" part)
Here is a part of the generated json that the analyzer created:
{
    "nodes": [
        {
            "name": "Disciple of the Unyielding",
            "passives": [
                "+1 to Minimum Endurance Charges",
                "5% chance to gain an Endurance Charge on Kill",
                "5% increased Damage per Endurance Charge"
            ],
            "type": "notable",
            "x": -0.08196721311475409,
            "y": 0.8337236533957846
        },
        {
            "name": "Dervish",
            "passives": [
                "+2% Chance to Block Attack Damage while Dual Wielding",
                "24% increased Weapon Damage while Dual Wielding",
                "6% increased Attack Speed while Dual Wielding",
                "Attack Skills deal 24% increased Damage with Ailments while Dual Wielding"
            ],
            "type": "notable",
            "x": 0.19437939110070257,
            "y": -0.5409836065573771
        },
        {
            "name": "Disciple of the Slaughter",
            "passives": [
                "+1 to Minimum Frenzy Charges",
                "5% chance to gain a Frenzy Charge on Kill",
                "5% increased Damage per Frenzy Charge"
            ],
            "type": "notable",
            "x": 0.30210772833723654,
            "y": 0.8337236533957846
        },
        {
            "name": "Vigour",
            "passives": [
                "+1 to Maximum Endurance Charges"
            ],
            "type": "notable",
            "x": -0.38875878220140514,
            "y": -0.06557377049180328
        }
      //   ....  {...} more notes
        ],
  "socket": {
        "index": 1,
        "name": "DuelistBelow"
    }
}

JS error:
viewer.js:27 Uncaught TypeError: Cannot read property 'type' of undefined
    at FileReader.<anonymous> (viewer.js:27)

      if(!jewels.hasOwnProperty(file.name)) {
                        $("#jewelsTable").append(`

                            ${json.info.type}

I think something still went wrong in the analyzer.py but I can't figure it out.
Here are the data files:
data.zip
I made two folders, one with the analyzed json and the other one with the files wich where analyzed.
If you need more information about my setup lmk.
Would be very kind of you if you can investigate it :)

The result .json files for the viewer are stored in result/, not in data/.


[network] refactor network README

This readme is very outdated, and this should give it some much needed
updates to be more like reality.  In addition, reworded some parts that
make it more straightforward or concise.
I'm looking for feedback into it, and my view on it doesn't have to be the only one.
See it here: https://github.com/gregnazario/libra/blob/readme/network/README.md

/land


Deletion indicators should go after line continuations

From @stuartpb on January 31, 2018 1:58
Description
"Deleted line" indicators in Atom are placed after the line number: if the lines are wrapped, these should go over the last line that the line of text has been wrapped to, instead of being placed after the first line (where the number ends).

Steps to Reproduce

Toggle Soft Wrap on (via "Toggle Soft Wrap" under the "View" menu).
Open a file with a long line followed by a deleted line (ie. in Git).
Narrow the window so that the long line preceding the deletion is wrapped to multiple lines.

Expected behavior: The deletion marker should be placed in the space between the end of the preceding line's content and the next line.
Actual behavior: The deletion marker is placed in the middle of the continued line, at the bottom of the first row of characters and before the rest of the continuation.
Versions
1.23.3
Copied from original issue: atom/atom#16656

This issue was moved to atom/atom#18005


[RESOLVED] Interface eth0(): High error rate (>2 for 5m)

Problem started at 09:15:29 on 2023.05.15
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Operational data: errors in: 3, errors out: 0
Original problem ID: 20615
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23483&eventid=20615

Problem has been resolved in 27m 0s at 09:42:29 on 2023.05.15
Problem name: Interface eth0(): High error rate (>2 for 5m)
Host: S100-Primario
Severity: Warning
Original problem ID: 20615


TBA App ID

Might not want to include your own TBA App ID if you are making this public. I would suggest making a function to set the ID

Is this something you're supposed to keep private? I agree it makes sense to make people use their own IDs, though.

No not private.

Yeah, I'll fix this in just a second.


Updating README.MD with CircleCI status badges

we moved our builds to circleci, so updating our badges too

Codecov Report

Merging #793 (f10c4af) into develop (da24444) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #793   +/-   ##
========================================
  Coverage    58.77%   58.77%
========================================
  Files           29       29
  Lines         3985     3985
========================================
  Hits          2342     2342
  Misses        1348     1348
  Partials       295      295

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da24444...f10c4af. Read the comment docs.


Properly support "end of stack" markers

In glibc, but possibly also other implementations, the _start entry point has an explicit DW_CFA_undefined: RIP rule which acts as an "end of stack" marker. (https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/x86_64/start.S;h=1b3e36826b8a477474cee24d1c931429fbdf6d8f;hb=HEAD#l60)
However, the breakpad ASCII syntax does not support this, but even if it would, rust-minidump code will just fall back to other methods of unwinding when the CFI unwinder reports "there is no caller frame".
This fallback then means that additional frames are being "hallucinated" past the end of the stack (aka _start).

even if it would, rust-minidump code will just fall back to other methods of unwinding when the CFI unwinder reports "there is no caller frame".

It would be nice to change the API so unwinders could return any of:

The caller frame
Unable to find a caller frame
Definitive end of call stack

The bits in question are not public API, which is nice:
https://github.com/rust-minidump/rust-minidump/blob/7080a729b41549b729050a9615f8c0026e1da53b/minidump-unwind/src/lib.rs#L654-L658
https://github.com/rust-minidump/rust-minidump/blob/7080a729b41549b729050a9615f8c0026e1da53b/minidump-unwind/src/x86.rs#L22-L25
I guess Symbolizer::walk_frame is public and would probably need to be changed:
https://github.com/rust-minidump/rust-minidump/blob/main/breakpad-symbols/src/lib.rs#L830-L834
Maybe change the return type to something like:
enum FrameResult {
  Found,
  NotFound,
  Complete,
}

That's an interesting idea, and I'd be game to extending Breakpad's sym format to include that bit of info. I don't mind breaking compatibility with Google's stuff if it's behind a pref.