Consider an "Unreleased" section

I liked this idea from http://keepachangelog.com:

Always have an "Unreleased" section at the top for keeping track of any changes.

This serves two purposes:

People can see what changes they might expect in upcoming releases
At release time, you just have to change "Unreleased" to the version number and add a new "Unreleased" header at the top.

Currently if I run conventional-changelog (technically grunt-conventional-changelog version 5.0.0) without a new git tag I get the latest release number repeated. Maybe the fallback if there's no tag could be "Unreleased" instead?
Example output from my project, note the repeated 0.3.2:

## [0.3.2](https://github.com/seriema/angular-apimock/compare/0.3.2...v0.3.2) (2015-10-27)

### Bug Fixes

* **npm:** `npm install` was failing because it ran bower as `postinstall` ([a696e14](https://github.com/seriema/angular-apimock/commit/a696e14))

## [0.3.2](https://github.com/seriema/angular-apimock/compare/0.3.1...v0.3.2) (2015-10-25)

I like the idea! But the module doesn't know if 0.3.2 has released or not.
Currently I can think of two ways of doing it

always change your version in package.json to something else (eg: '0.3.3-pre' or 'Unreleased' in your case) before you do a release.
manually give a version when you run the command.

The limitation of this module is it only generate changelog, but it doesn't read any previous generated changelog.

I'm guessing it reads the latest tag, to generate the header, and then somehow works out what commits to use for the changelog. How does it do that?
The generated sample above shows it's creating links to github:
https://github.com/seriema/angular-apimock/compare/0.3.2...v0.3.2
https://github.com/seriema/angular-apimock/compare/0.3.1...v0.3.2
The last part of those URL's are interesting: 0.3.2...v0.3.2 and 0.3.1...v0.3.2.  A naive idea would be "if they are the same, then set the version name to Unreleased".
Or basically any commits after the latest tag would work, but the changelog are picking them up now anyway so I'm not sure how it's calculating the diff.

if they are the same, then set the version name to Unreleased

hm... Maybe just don't generate it. Some people have problem with the workflow here so this might solve that problem.

You might see something like this with "Unreleased"

## [0.3.2](https://github.com/seriema/angular-apimock/compare/0.3.1...v0.3.2) (2015-10-27)

### Bug Fixes

* **npm:** `npm install` was failing because it ran bower as `postinstall` ([a696e14](https://github.com/seriema/angular-apimock/commit/a696e14))

## Unreleased

### Bug Fixes

* **npm:** `npm install` was failing because it ran bower as `postinstall` ([a696e14](https://github.com/seriema/angular-apimock/commit/a696e14))

The entry will appear again in the next release section. Thoughts?

Maybe it can be an option to include it or not?
Not sure what you mean with the example above. Why would I see my commit twice? It's not doing that now. It's generating the list correctly, it's just the header that's wrong.

if they are the same, then set the version name to Unreleased

So once you tag it with a different semver number, you would prepend the change log with the new release.

Oh, of course! Yeah maybe it's best to just not output it.


Remove CBOR instances for PLC

It's risky having two serialization instances for a type, there's a risk
that someone will use the wrong one and then have difficulty
deserializing. Moreover, we don't use the CBOR instance anywhere any
more, we're fairly committed to Flat. So we might as well just get rid
of it.
We could add a CBOR instance that mirrors the instance for Script,
i.e. emits a CBOR bytestring containing the Flat-encoded program.
However, I think it's better to hang that on the Script type: the
"true" serialization of a PLC program is the Flat version, and the
Flat-in-CBOR thing is really just for playing nice with the ledger,
and so it fits to hang it on Script.
Bonus changes:

The nofib exe had some commands for dealing with CBOR stuff, I
blindly changed those to be Flat
Deleted the CBOR-vs-Flat comparison benchmark, since there is no
CBOR implementation to compare against!
Deleted the handling for CBOR in the plc executables.

Pre-submit checklist:

Branch

[x] Commit sequence broadly makes sense
[] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages
[x] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

Pre-merge checklist:

[ ] Someone approved it
[ ] Commits have useful messages
[ ] Review clarifications made it into the code
[ ] History is moderately tidy; or going to squash-merge

I found a few more CBOR things. I put them in a PR to this PR.

Thanks!


feature: switch between grep_cword and live_grep_glob

I am thinking on the lines of how the newly added action grep_lgrep allows us to search for a string, then switch to lgrep to filter out files, then switch back for even more filtering and so on...
an action to switch between grep_cword and live_grep_glob would be useful, as it would allow us to search the current word, and then filter out  which files we want to look for it in: (much better than switching first then retyping search term:

here, I could switch to glob mode and filter out `.h` files easily, rather than
maybe a lgrep_glob and grep_glob (or maybe a combined action for any grep mode into glob mode)

unrelated:

how to remove that weird grey column above the > current entry. I have it even in normal terminal fzf.

an action to switch between grep_cword and live_grep_glob would be useful

I also use mainly live_grep_glob, I’ll think what is most intuitive way to do this, currently the ctrl-g switches to live grep, what if it’s as simple as an option  that makes it switch tolive_grep_glob instead? The only tricky part would be to maintain the iglob arguments when switching to regular grep, shouldn’t be a big deal.

how to remove that weird grey column above the > current entry. I have it even in normal terminal fzf for some reason?

That’s the gutter color, FzfLua knows how to translate neovim highlights to terminal ones, all you have to do is set it to Normal and it will disappear, below is my fzf_colors (from my setup):

you don’t need to specify all, only use the ones you wish to modify

  fzf_colors = {
    ["fg"] = { "fg", "CursorLine" },
    ["bg"] = { "bg", "Normal" },
    ["hl"] = { "fg", "Comment" },
    ["fg+"] = { "fg", "ModeMsg" },
    ["bg+"] = { "bg", "CursorLine" },
    ["hl+"] = { "fg", "Statement" },
    ["info"] = { "fg", "PreProc" },
    ["prompt"] = { "fg", "Conditional" },
    ["pointer"] = { "fg", "Exception" },
    ["marker"] = { "fg", "Keyword" },
    ["spinner"] = { "fg", "Label" },
    ["header"] = { "fg", "Comment" },
    ["gutter"] = { "bg", "Normal" },
  }

Btw, I’m happy to learn someone is actually using this new feature and understand it’s power :)

Added new option under grep, grep.rg_glob, when specified, glob parsing will be enabled and will also be considered when switching between grep and live grep with the ctrl-g action (grep_lgrep).
You can either set it up during setup or not at all, starting live_grep_glob or live_grep({ rg_glob=true })
(both are the same now) makes it so the ctrl-g action enables it for grep as well.
If you enable it during setup any grep call will use glob parsing:
require'fzf-lua'.setup {
  grep = {
    rg_glob = true,
  },
}

You can now use the default separator -- in any grep call, i.e.:
:lua require'fzf-lua'.grep({ search="pcall( -- *tree*", debug=true })

will result in:

And pressing ctrl-g will result in:

this works great with live_grep as it with this option set, it works exactly like live_grep_glob!!!!! It is not working with live_grep_native tho (neither does grep_lgrep work with it).
Also, this is new, I get error when I switch use grep_lgrep in tags with an empty query:
Error executing vim.schedule lua callback: ...te/pack/packer/opt/fzf-lua/lua/fzf-lua/previewer/fzf.l
ua:221: attempt to perform arithmetic on field 'line' (a string value)
stack traceback:
        ...te/pack/packer/opt/fzf-lua/lua/fzf-lua/previewer/fzf.lua:221: in function 'fn'
        .../nvim/site/pack/packer/opt/fzf-lua/lua/fzf-lua/shell.lua:121: in function 'fn'
        .../nvim/site/pack/packer/opt/fzf-lua/lua/fzf-lua/shell.lua:41: in function <.../nvim/site/p
ack/packer/opt/fzf-lua/lua/fzf-lua/shell.lua:40>

im not sure if this is a bug, so im not making a new issue:
I have to set tags.actions to set:
['ctrl-g'] = false,

otherwise, I see the <c-g> to live grep while in the tags command, using which doesn't make sense (because its already live grep) and also pressing <c-g> causes it to error out / glitch.
also, going from grep_cword -> grep_lgrep -> delete entered text -> grep_lgrep again causes this:
[Fzf-lua] fzf error 1: <null>

notification to be printed, its like a glitch but it remains functional.

It is not working with live_grep_native tho (neither does grep_lgrep work with it).

It’s not meant to work with the native version, as it’s name suggests it runs rg piped in the shell directly, it cannot do any processing this way.

in tags, using grep_lgrep causes this to be printed out:

What were you searching for? Is your tags file named 1? Is it possible you were searching for something that doesn’t exist as a tag?

furthermore, the query isn't carried when doing tags -> grep_lgrep. tags_live_grep -> grep_lgrep works fine as expected.

This is by design, tags have their own last_search variable, they aren’t the same and shouldn’t mix up IMO.

[Fzf-lua] fzf error 1:

This is harmless, the reason it’s there is because sometimes exit code 1 has a meaningful error, I’ll remove it when the message is empty.

[Fzf-lua] Unable to find pattern '0=unsorted, 1=sorted, 2=foldcase' in file '1'

This is printed when using the bat previewer with tags, this seems to be a non existent tag in a file named 1?
If you can print the selected line while this happens we can further investigate why this failed.

https://github.com/ibhagwan/fzf-lua/commit/c11cb21e9053a7e00b7a54e4c25216bc98283681:

[Fzf-lua] fzf error 1: <null>

Won't show up anymore when switching with empty queries.

[Fzf-lua] Unable to find pattern '0=unsorted, 1=sorted, 2=foldcase' in file '1'

Prepended the word preview to the warning message, if you believe this is wrong and the tag still exists can you send a screenshot of the selected line and the corresendponding tag it should go to and we'll find out why the tag grep failed.

furthermore, the query isn't carried when doing tags -> grep_lgrep. tags_live_grep -> grep_lgrep works fine as expected.

I think I understand what you're saying now, this is again, by design, when you're using tags you're just fuzzy matching it's not suppose to be carried to the live grep variant, live_grep is meant to limit the search by modifying the underlying rg grep string, the typed query when fuzzy matching shouldn't mean much, even in grep (not tags) the typed query never carries over to live_grep.
There might be a use case where the typed query in grep can carry over to live_grep when the original grep string is empty but I fear this might even cause more confusion to how this is supposed to work.

https://github.com/ibhagwan/fzf-lua/commit/0219921e4169ff25270f20efc7d709ab13df8acd - scrap the last comment, it will work how you want it now, when using an empty grep string with both tags and grep the last typed query will be considered the grep string, so now this should work:

start grep with an empty string (or grep_project or tags)
type a query: foo
press ctrl-g to switch to live_grep
the grep string should appear as foo

Note that past this point if you press ctrl-g again you'll actually perform grep({ search='foo' }) and any subsequent typing won't be included in the switch back to live_grep as it will switch back to modifying foo.

Note that past this point if you press ctrl-g again you'll actually perform grep({ search='foo' }) and any subsequent typing won't be included in the switch back to live_grep as it will switch back to modifying foo.

Yep! this is what I was talking about, it works as expected now. Thanks for working on this, I think the commands are more consistent in behavior now!

Prepended the word preview to the warning message, if you believe this is wrong and the tag still exists can you send a screenshot of the selected line and the corresendponding tag it should go to and we'll find out why the tag grep failed.

Okay, I think the new error message helped me narrow it down:

As you can see, I am seeing results from he top section of the ctags file generated using the cmd: ctags -R --excmd=combine
!_TAG_FILE_FORMAT	2	/extended format; --format=1 will not append ;" to lines/
!_TAG_FILE_SORTED	1	/0=unsorted, 1=sorted, 2=foldcase/
!_TAG_OUTPUT_EXCMD	combineV2	/number, pattern, mixed, or combineV2/
!_TAG_OUTPUT_FILESEP	slash	/slash or backslash/
!_TAG_OUTPUT_MODE	u-ctags	/u-ctags or e-ctags/
!_TAG_PATTERN_LENGTH_LIMIT	96	/0 for no limit/
!_TAG_PROC_CWD	/Users/viraat-chandra/.config/nvim/	//
!_TAG_PROGRAM_AUTHOR	Universal Ctags Team	//
!_TAG_PROGRAM_NAME	Universal Ctags	/Derived from Exuberant Ctags/
!_TAG_PROGRAM_URL	https://ctags.io/	/official site/
!_TAG_PROGRAM_VERSION	5.9.0	//
....
<tags start after this>

tags file ^^
this second I believe is supposed to be ignored when parsing the tags file.
This is where the 1 file error came from.

this second I believe is supposed to be ignored when parsing the tags file.
This is where the 1 file error came from.

You're correct, this issue only happens when running tags_grep (or ctrl-g) or tags_live_grep and not with plain tags -  when running tags the executed command is  rg -v '^!_TAG_' <ctag_file> which excludes these but when running the grep and live grep variants the command must search for the grep string and I couldn't find a way to add the -v ... part to exclude the ctag headers.
It didn't seem a big deal to me so I didn't bother searching for a way to exclude and include in the same rg search, I'll give it another shot.
Another option was to exclude it during processing but due to the way my external processor works (the multiprocess=true thingie) returning empty lines when I detect a tag creates excess empty lines, solving that would require a deeper intervention in the libuv.spawn.process_lines function which might be costly for performance (plus, it's working so well and everything depends on it now so I don't wanna mess with it):

As you can see below if I return empty strings when non-tag lines are detected the \n still remains:
https://github.com/ibhagwan/fzf-lua/blob/def8abf58667c4d2c9cabdaa5297c793e511a582/lua/fzf-lua/libuv.lua#L152-L158

https://github.com/ibhagwan/fzf-lua/commit/33dae2a6b94e1e58c08f265aacd0eae44c911ae5 - try now, I added a pipe command excluding the ctag headers  when using tags grep and live grep.

yep! All fixed now, amazing work @ibhagwan , as always :)!!!!!

yep! All fixed now, amazing work @ibhagwan , as always :)!!!!!

Ty <3

Cool, I'm using this :)


Backport "HBASE-25534 Honor TableDescriptor settings earlier in normalization (#2917)" to branch-2

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  7s
branch-2 passed

+1 :green_heart:
compile
3m 22s
branch-2 passed

+1 :green_heart:
checkstyle
1m 16s
branch-2 passed

+1 :green_heart:
spotbugs
2m 12s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 40s
the patch passed

+1 :green_heart:
compile
3m 21s
the patch passed

+1 :green_heart:
javac
3m 21s
the patch passed

+1 :green_heart:
checkstyle
1m 13s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 58s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 21s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

44m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3304/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3304

Optional Tests
dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile

uname
Linux e956efec7448 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 073f23e2bd

Default Java
AdoptOpenJDK-1.8.0_282-b08

Max. process+thread count
85 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3304/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 20s
branch-2 passed

+1 :green_heart:
compile
1m  7s
branch-2 passed

+1 :green_heart:
shadedjars
6m 54s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  1s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

+1 :green_heart:
shadedjars
6m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
133m 49s
hbase-server in the patch passed.

162m 31s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3304/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3304

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux aeaa90f03036 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 073f23e2bd

Default Java
AdoptOpenJDK-11.0.10+9

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3304/1/testReport/

Max. process+thread count
3942 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3304/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
branch-2 passed

+1 :green_heart:
compile
0m 57s
branch-2 passed

+1 :green_heart:
shadedjars
6m  6s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 22s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
shadedjars
6m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
141m 54s
hbase-server in the patch passed.

167m 33s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3304/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/3304

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux e6ea72e0d008 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 073f23e2bd

Default Java
AdoptOpenJDK-1.8.0_282-b08

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3304/1/testReport/

Max. process+thread count
3848 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3304/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


fix(deps): update gomod

This PR contains the following updates:

Package
Type
Update
Change

github.com/IBM/platform-services-go-sdk
require
minor
v0.41.0 -> v0.42.0

github.com/go-git/go-git/v5
require
patch
v5.8.0 -> v5.8.1

github.com/gruntwork-io/terratest
require
patch
v0.43.9 -> v0.43.11

Release Notes

IBM/platform-services-go-sdk (github.com/IBM/platform-services-go-sdk)
v0.42.0
Compare Source
Features

IAM Identity: Add support for IAM enterprise (#267) (d23f0fc)

go-git/go-git (github.com/go-git/go-git/v5)
v5.8.1
Compare Source
What's Changed

*: Bump dependencies by @pjbgf in https://github.com/go-git/go-git/pull/815

Full Changelog: https://github.com/go-git/go-git/compare/v5.8.0...v5.8.1

gruntwork-io/terratest (github.com/gruntwork-io/terratest)
v0.43.11
Compare Source
Modules affected

terraform

Description

Added function AssertTgPlanAllExitCode to validate output of terragrunt run-all plan

Special thanks

Special thanks to the following users for their contribution!

@bt-macole

Related links

https://github.com/gruntwork-io/terratest/pull/1323

v0.43.10
Compare Source
Modules affected

k8s

Description

Added support for passing custom logger when running kubectl

Special thanks

Special thanks to the following users for their contribution!

@retpolanne

Related links

https://github.com/gruntwork-io/terratest/pull/1325

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.10.14 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


TypeError: can't pickle Environment objects on Windows

I'm running under Windows 10, following along the instructions given by the readme document. When trying to retrain the model using this command
python nerTagger.py --dataset-type conll2003 train_eval
I ran into the following exception (right after compiling embeddings) - any tips?
Thank you for the wonderful work!
Compiling embeddings... (this is done only one time per embeddings at first launch)
path: d:\Projects\embeddings\glove.840B.300d.txt
100%|████████████████████████████████████████████████████████████████████| 2196017/2196017 [08:06<00:00, 4517.80it/s] embeddings loaded for 2196006 words and 300 dimensions
__________________________________________________________________________________________________
Layer (type)                    Output Shape         Param #     Connected to
==================================================================================================
char_input (InputLayer)         (None, None, 30)     0
__________________________________________________________________________________________________
time_distributed_1 (TimeDistrib (None, None, 30, 25) 2150        char_input[0][0]
__________________________________________________________________________________________________
word_input (InputLayer)         (None, None, 300)    0
__________________________________________________________________________________________________
time_distributed_2 (TimeDistrib (None, None, 50)     10200       time_distributed_1[0][0]
__________________________________________________________________________________________________
concatenate_1 (Concatenate)     (None, None, 350)    0           word_input[0][0]
                                                                 time_distributed_2[0][0]
__________________________________________________________________________________________________
dropout_1 (Dropout)             (None, None, 350)    0           concatenate_1[0][0]
__________________________________________________________________________________________________
bidirectional_2 (Bidirectional) (None, None, 200)    360800      dropout_1[0][0]
__________________________________________________________________________________________________
dropout_2 (Dropout)             (None, None, 200)    0           bidirectional_2[0][0]
__________________________________________________________________________________________________
dense_1 (Dense)                 (None, None, 100)    20100       dropout_2[0][0]
__________________________________________________________________________________________________
dense_2 (Dense)                 (None, None, 10)     1010        dense_1[0][0]
__________________________________________________________________________________________________
chain_crf_1 (ChainCRF)          (None, None, 10)     120         dense_2[0][0]
==================================================================================================
Total params: 394,380
Trainable params: 394,380
Non-trainable params: 0
__________________________________________________________________________________________________
Epoch 1/60
Exception in thread Thread-2:
Traceback (most recent call last):
  File "d:\Anaconda3\Lib\threading.py", line 916, in _bootstrap_inner
    self.run()
  File "d:\Anaconda3\Lib\threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "d:\Projects\delft\env\lib\site-packages\keras\utils\data_utils.py", line 548, in _run
    with closing(self.executor_fn(_SHARED_SEQUENCES)) as executor:
  File "d:\Projects\delft\env\lib\site-packages\keras\utils\data_utils.py", line 522, in <lambda>
    initargs=(seqs,))
  File "d:\Anaconda3\Lib\multiprocessing\context.py", line 119, in Pool
    context=self.get_context())
  File "d:\Anaconda3\Lib\multiprocessing\pool.py", line 174, in __init__
    self._repopulate_pool()
  File "d:\Anaconda3\Lib\multiprocessing\pool.py", line 239, in _repopulate_pool
    w.start()
  File "d:\Anaconda3\Lib\multiprocessing\process.py", line 105, in start
    self._popen = self._Popen(self)
  File "d:\Anaconda3\Lib\multiprocessing\context.py", line 322, in _Popen
    return Popen(process_obj)
  File "d:\Anaconda3\Lib\multiprocessing\popen_spawn_win32.py", line 65, in __init__
    reduction.dump(process_obj, to_child)
  File "d:\Anaconda3\Lib\multiprocessing\reduction.py", line 60, in dump
    ForkingPickler(file, protocol).dump(obj)
TypeError: can't pickle Environment objects

Okay - disabling lmdb in embedding-registry.json seems to make that exception go away. BUT now there's another exception:
__________________________________________________________________________________________________ Epoch 1/60 d:\Projects\delft\env\lib\site-packages\h5py\__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from floattonp.floatingis deprecated. In future, it will be treated asnp.float64 == np.dtype(float).type.   from ._conv import register_converters as _register_converters Using TensorFlow backend. d:\Projects\delft\env\lib\site-packages\gensim\utils.py:1197: UserWarning: detected Windows; aliasing chunkize to chunkize_serial   warnings.warn("detected Windows; aliasing chunkize to chunkize_serial") Traceback (most recent call last):   File "<string>", line 1, in <module>   File "d:\Anaconda3\Lib\multiprocessing\spawn.py", line 105, in spawn_main     exitcode = _main(fd)   File "d:\Anaconda3\Lib\multiprocessing\spawn.py", line 115, in _main     self = reduction.pickle.load(from_parent)   File "d:\Projects\delft\utilities\Embeddings.py", line 78, in __getattr__     return getattr(self.model, name)   File "d:\Projects\delft\utilities\Embeddings.py", line 78, in __getattr__     return getattr(self.model, name)   File "d:\Projects\delft\utilities\Embeddings.py", line 78, in __getattr__     return getattr(self.model, name)   [Previous line repeated 328 more times]

Hello! I haven't been able to reproduce the exception in Linux so it might be windows related. I'm trying to get a windows machine in order to try again. In the meanwhile, can you tell us a little more about your set-up? For instance, are you using a GPU? Did you use the requirements-gpu.txt files to set it up?
Thanks!

Hi sorry I wasn't very clear about my spec:

Windows: Windows 10
GPU: Tesla Quadro P4000; yes I did install requirements-gpu.txt
Python: 3.6.6 (via Anaconda).

By the way I also solved this error along the way: DLL load failed message when scikit-learn is imported.
The solution is to install numpy‑1.14.6+mkl‑cp36‑cp36m‑win_amd64.whl (depending on the arch and Python version) from https://www.lfd.uci.edu/~gohlke/pythonlibs/#numpy

Ok, we had some problems before with Python 3.6, I honestly don't think that the Python version is the problem, but if you have the time, can you try creating a Python 3.5 environment with conda conda create -n myenv python=3.5 and see if you encounter the same problems? As soon as I get to try DeLFT on Windows I'll get back to you.

Hello, I'm new to this. My specs are:

OS: Windows 10 Pro 64-bit
GPU: NVIDIA 1050Ti-mobile (4 GB) [I've already install tensorflow-gpu as mentioned in requirement.txt]
Python 3.7

And I want to ask for 2 things:

The first is: How to disable lmdb in embedding-registry.json?
The second is: I've already comment lines 77 & 78 in utilities/Embeddings.py but I encountered this problem:

Using TensorFlow backend.
D:\Anaconda3\envs\ULR\lib\site-packages\gensim\utils.py:1197: UserWarning: detected Windows; aliasing chunkize to chunkize_serial
  warnings.warn("detected Windows; aliasing chunkize to chunkize_serial")
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "D:\Anaconda3\envs\ULR\lib\multiprocessing\spawn.py", line 105, in spawn_main
    exitcode = _main(fd)
  File "D:\Anaconda3\envs\ULR\lib\multiprocessing\spawn.py", line 115, in _main
    self = reduction.pickle.load(from_parent)
EOFError: Ran out of input

I face the same issue as @Protossnam EOFError: Ran out of input.
Am on Windows 10 with py3.5. Any updates on this?

@davidlenz Sadly, I had to boot my laptop in Linux (Ubuntu) and run the tool. On Linux, I didn't face that issue. It's maybe the problem with Windows and I also looking forward to hear new update on this too

Hi all,
An easy workaround would be to disable multiprocessing when running on Windows
To do that you need to pass multiprocessing=False each time a new Sequence object in created in nerTagger.py
My 2 cts
Olivier

I have this issue when the download fails and the database is not correctly initialised I supposed:
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/site-packages/keras/utils/data_utils.py", line 744, in _run
    with closing(self.executor_fn(_SHARED_SEQUENCES)) as executor:
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/site-packages/keras/utils/data_utils.py", line 721, in pool_fn
    pool = get_pool_class(True)(
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/multiprocessing/context.py", line 119, in Pool
    return Pool(processes, initializer, initargs, maxtasksperchild,
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/multiprocessing/pool.py", line 212, in __init__
    self._repopulate_pool()
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/multiprocessing/pool.py", line 303, in _repopulate_pool
    return self._repopulate_pool_static(self._ctx, self.Process,
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/multiprocessing/pool.py", line 326, in _repopulate_pool_static
    w.start()
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/multiprocessing/process.py", line 121, in start
    self._popen = self._Popen(self)
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/multiprocessing/context.py", line 284, in _Popen
    return Popen(process_obj)
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/multiprocessing/popen_spawn_posix.py", line 32, in __init__
    super().__init__(process_obj)
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/multiprocessing/popen_fork.py", line 19, in __init__
    self._launch(process_obj)
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/multiprocessing/popen_spawn_posix.py", line 47, in _launch
    reduction.dump(process_obj, fp)
  File "/Users/lfoppiano/opt/anaconda3/envs/delft2/lib/python3.8/multiprocessing/reduction.py", line 60, in dump
    ForkingPickler(file, protocol).dump(obj)
TypeError: cannot pickle 'Environment' object

I have the same problem with MacOs. I tried to disable the multithreading by setting nb_workers = 0 in sequenceLabelling/wrapper.py but the error persists...
Then I found out that the nb_workers is also set in trainer.py: 172. if I add nb_workers = 0 there too, it works.
I think we need to revisit this part, perhaps making the nb_workers a parameter (at least setting to zero) and coordinate it with the multiprocessing variable?


Update metronome to 0.6.27

High-level description
What features does this change enable? What bugs does this change fix?
Bump Metronome to 0.6.23
Corresponding DC/OS tickets (required)

DCOS_OSS-5019 Improve secrets validation to only point out unprovided secrets.
DCOS-54879 Include taskids in job history.

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain.
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

@mesosphere-mergebot label Ready For Review


Compiled data bindings - missing example

I was reading through this, and I noticed that in the Compiled data bindings description, it says:
"You can also use x:Bind to bind to a method, like this: For typical binding scenarios, you can use x:Bind in place of Binding, and get improved performance and maintainability."
It seems like there's a missing example.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 785df148-f148-9823-0266-7fd8fed8a2c6
Version Independent ID: f4f7d0b8-ac9e-390f-1e62-1fa95ae8e019
Content: What's new in Windows 10 build 10240 - July 2015 - UWP apps
Content Source: windows-apps-src/whats-new/windows-10-build-10240.md
Product: uwp
Technology: whats-new
GitHub Login: @QuinnRadich
Microsoft Alias: quradic

That is a mistake, yes - it's an artifact of how that very first What's New page was put together.
We won't be adding an example here, but I'll go in and remove that line which suggests that one  should be there. Thanks for catching this.


Webpack build warning

Hello,
Thank you for the great lib. We are using it with a new angular 2 project and it works great. Only issue we have is a warning we get with Webpack at this point. It looks like your package.json points to umd.js instead of index.js.
Here is the error we get:
typescript-collections/dist/lib/umd.js
Critical dependencies:
21:121-128 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
Thanks,
TK

Hi @tilemachosk , thanks for using typescript-collections.
I'm not sure if I package.json'smain should point to raw index.js since applications written e.g. for node won't be able to use this library. That's what UMD is for.
I've found this https://github.com/webpack/webpack/issues/1617 but I'm not sure what should be changed.
Can somebody provide a solution to this?

Any update on this?

I think I know how to fix this. We need to make a separate dist directory for ES6 target build and point to it via jsnext:main in package.json.

A similar option is to use the module entry in package.json and add a module build configuration that can be shared with webpack/ts-loader for exporting
"main": "build/main/index.js",
"module": "build/module/index.js",

then control the build target compilations via:
"build:main": "tsc -p tsconfig.json",
"build:module": "tsc -p config/exports/tsconfig.module.json",

and a top-level tsconfig.json
{
  "extends": "./config/tsconfig.flexible", // also available: "./config/tsconfig.strict"
  "compilerOptions": {
    "target": "es6",
    "outDir": "build/main",
    "rootDir": "src",
    "moduleResolution": "node",
    "module": "commonjs",
    "declaration": true,
    "importHelpers": true,
    "inlineSourceMap": true,
    "listFiles": false,
    "traceResolution": false,
    "pretty": true,
    "lib" : [
      "es6"
    ],
    "types" : [
      "node"
    ],
    "baseUrl": ".", // required for "paths"
    "paths": {
      "typescript-collections": ["src/index.ts"] // write tests without relative paths
    }
  },
  "include": [
    "src/**/*.ts"
  ],
  "exclude": [
    "node_modules/**"
  ],
  "compileOnSave": false
}

and a tsconfig.module.json in /config/exports to extend for the module
    {
      "extends": "../../tsconfig",
      "compilerOptions": {
        "outDir": "../../build/module",
        "rootDir": "../../src",
        "module": "es6",
        "declaration": false
      }
    }

Closing this because of old age. If the issue persists, please let me know.


NODE_PATH and "Required module not found"

I run my project with:
$ NODE_PATH=src babel-node src/index.js
works

But flow complains:
$ flow check
src/index.js:2
  2: import Foo from 'lib/Foo';
                     ^^^^^^^^^ lib/Foo. Required module not found

Found 1 error
$ flow version
Flow, a static type checker for JavaScript, version 0.18.1

File layout:
./src/index.js
./src/lib/Foo.js
./.flowconfig

src/index.js
/* @flow */
import Foo from 'lib/Foo';
console.log('works');

./src/lib/Foo.js
export default class Foo {}

.flowconfig
[ignore]

[include]
src/

[libs]

How can flow be taught about the concept of NODE_PATH ?

I think this is a dupe of #48. The comments there have a workaround

Agreed. @mfn, please let me know if the solution in #48 is insufficient for your use case.


Clean up the Firewall rules for maestro-prod SQL server

The maestro-prod SQL server has multiple firewall rules set up for IP addresses outside the corpnet (usually to be able to access the BAR database from a home office). It'd be great to clean up the rules.
We have a documentation that describes how to add the firewall rule Accessing-the-BAR-(BuildAssetRegistry)-database and it has "Delete the firewall rule once you're done for increased safety".
Discussed with @ilyas1974 .

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description
Not release notes worthy

FWIW some tooling, like SSMS, will add this firewall exception on behalf of the user. This is convenient, but it does hide what actually happens so it becomes easy to forget to remove the exception afterwords.

I've removed all firewall exceptions.


Large number of files remain after uninstalling the program

Starting from 10.9.x, after executing the uninstaller, although it shows “Uninstallation Complete”, there are still a lot of program files left in the folder.  （从10.9.x开始，执行卸载程序后，虽然显示“卸载完成”，但文件夹内仍然残留大量程序文件。）
Steps To Reproduce

Go to 'Applications and Functions'
Click on 'Jellyfin → uninstall'
Go to 'C:\Program Files\Jellyfin\Server'
The Server folder still contains a large number of uninstalled program files: 2937 files, 22 folders.

System (please complete the following information):

Platform: [Windows10]
Browser: [Chrome]
Jellyfin Version: [10.9.1-10.9.5]

Hrm. This is definitely unintended. Thanks for the report, I'll look into it further.


Object and named parameter

Hi,
Is there a war to have named parameter when calling an object for a defined route ?
Flight::route('/api/@version/@name', array('MyApi', 'render'));

I want to retrieve : $version & $name
I can wrote this :
Flight::route('/api/@version/@name', function ($version, $name){
$a = new MyApi();
$a->render($version, $name);
});

But that's not what i want :(
Thx

It should work with your class as well
class MyApi {     public static function render($version, $name) {         // Do awesome stuff     } }

Oh yeah sorry :) Thx
I was trying with an extend of my object with same named function (with no parameter)
parent::render()
Thx


Webserver

Hi there
Your Webserver works great on Raspberry Pi with Windows 10 IoT but not on my development PC where I have Windows 10. Am I doing something wrong or is this the way it is?
Thanks!

@ThomasVilliger, you can follow the steps from this request to start Restup Server locally.


How would you handle updating custom field in contact?

I have a integration page, where people can come in and integrate their ATS with Salesforce, to transfer contacts. Some of them will have linkedIn URL added as a custom field in Salesforce's contact object, but others won't.
I can pass Linkedin URL to salesforce from their ATS, but if there is no field named LinkedIn URL, then Salesforce throws error in response. How to handle this scenario? I want to update all fields available in salesforce Contact object and ignore any extra fields.

Hello 👋. I created this project but no longer own the repo. There are a few different ways to achieve what you want, so I created the code snippet below to show two of those approaches.
import { SObject, SalesForceConnection } from 'sobject';
import callSomeExternalApiToGetPropertyName from 'callSomeExternalApiToGetPropertyName';

const connection = new SalesForceConnection({
  loginUrl: 'https://test.salesforce.com/services/oauth2/token',
  clientId: '3MVG9lKcPoNINVBJSoQsNCD.HHDdbugPsNXwwyFbgb47KWa_PTv',
  clientSecret: '5678471853609579508',
  username<EMAIL_ADDRESS>  password: 'I❤SalesForce'
});

runExample();

async function runExample() {

  const contact = {
    accountId: 'xxxxxxxxxxx',
    firstName: 'Paula',
    lastName: 'PureCloud',
    email<EMAIL_ADDRESS>    linkedInUrl: 'https://www.linkedin.com/example'
  };

  await insertContactWithApproach1(contact, 'LinkedInUrl__c');
  await insertContactWithApproach2(contact);
}

/**
* Here's a function where you can pass in the contact information and the
* name of the salesforce LinkedIn url property name if it exists.
*
* @param {Object} contact
* @param {string} contact.accountId
* @param {string} contact.firstName
* @param {string} contact.lastName
* @param {string} contact.email
* @param {string} [contact.linkedInUrl]
* @param {string} linkedInUrlPropertyName - The SalesForce custom property name (example: `LinkedInUrl__c`)
*/
function insertContactWithApproach1(contact, linkedInUrlPropertyName=null) {

  const propertyMap = {
    id: 'Id',
    accountId: 'AccountId',
    firstName: 'FirstName',
    lastName: 'LastName',
    email: 'Email',
    // add any other fields you know will be present
  };

  if (linkedInUrlPropertyName) {
    propertyMap.linkedInUrl = linkedInUrlPropertyName;
  }

  const contactStorage = new SObject({
    connection,
    objectName: 'Contact',
    propertyMap
  });

  return contactStorage.insert(contact);
}

/**
* Like the first approach, except SObject is subclassed and the property map is
* determined dynamically. This will only work for you if you have some external
* way to look up the property name dynamically within the subclass.
*/
function insertContactWithApproach2(contact) {

  class ContactStorage extends SObject {

    get objectName() {
      return 'Contact';
    }

    async getPropertyMap() {
      const propertyMap = {
        id: 'Id',
        accountId: 'AccountId',
        firstName: 'FirstName',
        lastName: 'LastName',
        email: 'Email',
      };

      const linkedInUrlPropertyName = await callSomeExternalApiToGetPropertyName();
      if (linkedInUrlPropertyName) {
        propertyMap.linkedInUrl = linkedInUrlPropertyName;
      }
      return propertyMap;
    }
  }

  const contactStorage = new ContactStorage({ connection });
  return contactStorage.insert(contact);
}


DISTMYSQL-208: Orchestrator GUI incorrectly shows recovery option for intermediate database in chained replication

https://jira.percona.com/browse/DISTMYSQL-208
Problem:
If we've got replication chain A->B->C, and C is down, GUI shows 'Recover' dropdown for node B, but there is no possible recovery action available in such a case.
The problem is well visible on upstream and Percona Orchestrator up to version v3.2.6-3. For next versions it is still there, but is hard to reproduce.
Cause:
The cause for hard reproduction on versions > v3.2.6-6 is caused by fix for DISTMYSQL-182. In case of the instance being unreachable, it causes skip of instance.Key storing, which is later needed for Orchestrator's backend update. This caused that 'last_checked' and 'last_seen' timestamps were updated incorrectly.
The root cause of the main problem is the analysis logic in Analysis_dao.go:GetReplicationAnalysis(). The condition for setting AllIntermediateMasterReplicasNotReplicating does not check if there are any replicas reachable. So the case when all replicas are dead (no recovery action possible) and the case when some replicas are still reachable, but are not replicating (recovery action possible) are undistinguishable.
Solution:

Move instance.Key assignment before Ping
Improve the analysis logic. Report AllIntermediateMasterReplicasNotReplicating only if all replicas are not replicating, but there are still some reachable replicas.

https://ps80.cd.percona.com/job/mysql-orchestrator-pipeline/36/


Previous / Next chapter navigation not working on clicking right / left side of the screen in full screen for epub's

Setup or portable version of the app?
Portable
Steps to reproduce

Open any epub.
Enter full screen.

Click left / right side of page to go to previous / next chapter.
It's not working.
Exit full screen and go to 100%.
Now click left / right of page, it works now, but not in full screen.

✔ Expected Behavior
To go to previous / next chapter when left / right side of the screen is clicked like it works for manga, and when epub is not in full screen.
❌ Actual Behavior
Navigation using mouse click on the left / right side of the screen does not work in full screen.

Unable to reproduce.

From my test it is still working. Is it only for this specific epub?


Fix libtommath linking with MSVC

What does your PR fix? Fixes linking with MSVC-built libtommath, see.

Which triplets are supported/not supported? *-windows[-static], uwp not tested, but this can only improve, not worsen.

Have you updated the CI baseline? No need.

Does your PR follow the maintainer guide? Hopefully.

Should affect only MSVC builds.

Please bump the port version. See documentation.

But 1.2.0 is the latest. And it is very old, releases are rare for libtom* libs.

@andrew-boyarshin Add Port-Version: 2 and remove -1 here:
https://github.com/microsoft/vcpkg/blob/5dc53211caedebf4387d590155ed53ee44161f10/ports/libtommath/CONTROL#L2

Pinging @andrew-boyarshin  for response. Is work still being done for this PR?

Not really. I can patch vcpkg port file myself when I need to, creating different patches for latest release and HEADREF + adding relevant CMake logic is too much of a hassle to do when you don't really need that. I don't mind if someone picks this PR up, of course.

Close this PR and wait for other contributors to take over.


Can this framework use encrypted training data to train network models? Are there any relevant cases to learn from?

@dikjstra You can first check whether this example helps in your case. It uses data that is shared by one party.
Otherwise, you might have to clarify what encrypted training data you mean. Is it something that is already secret shared? We can definitely add more use cases if necessary. But from our experience, data is always initially owned and encrypted (secret shared) by someone.

I see, there is one more question, is there a way for me to view the data transmitted from the client on the server side? Is it PondPrivateTensor?

@dikjstra It is PondPrivateTensor if you use the Pond protocol. Internally, it represents two pieces of shares on two servers respectively.

@dikjstra You can first check whether this example helps in your case. It uses data that is shared by one party.
Otherwise, you might have to clarify what encrypted training data you mean. Is it something that is already secret shared? We can definitely add more use cases if necessary. But from our experience, data is always initially owned and encrypted (secret shared) by someone.

For example, three hospitals want to use their data to train a model, but they don't want to disclose their medical data. Can the framework implement the training of a model with their three-party encrypted data? I see the example is using the trained model to make predictions on encrypted data

@dikjstra The link I provided includes training, not predictions. Please check the details. And it solves the scenario you describe.

@dikjstra The link I provided includes training, not predictions. Please check the details. And it solves the scenario you describe.

What should I do if I want to encrypt and aggregatethe data of multiple clients to the server, and how should I configure the code of the client and server, just like this example

@dikjstra Check the example at this line. Inside the class TrainingClient, it would load data from a device named training-client and encrypt (secret share) the data onto three servers (server0, server1, server2) that are specified in this file. It would help your understanding if you also take a look at how input is processed in the protocol implementation here.

Hello, when I run the "b - Secure Model Serving.ipynb" of this example, the following error occurs：

My environment configuration：pyhton=3.6 tensorflow=2.2 tf-encrypted=0.8.0


fix shellcheck error about install minikube

In PR #8668, ignored the vm-driver error, so fix it

/ok-to-test

@stewart-yu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
230250048eb31deb34f8225eb975fd07db2ae247
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

just do simple test, works:
no export VM_DRIVER in my environment(ubuntu), run tests/e2e/local/minikube/setup_host.sh, part of output like this:
Using kvm2 as VM for Minikube.
tests/e2e/local/minikube/setup_host.sh: line 27: minikube: command not found
Starting Minikube.

after export export VM_DRIVER=test-vm in environment(ubuntu),  run tests/e2e/local/minikube/setup_host.sh, part of output like this:
Using test-vm as VM for Minikube.
tests/e2e/local/minikube/setup_host.sh: line 27: minikube: command not found
Starting Minikube.
sudo: minikube: command not found

The error for that not install minikube, but we can see that the VM_DRIVER take effect

@stewart-yu
Seems you failed to install minikube. Did you check your network and install minikube manually?

/lgtm
/assign @hklai
for final review and approval.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: m1093782566
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: gargnupur
If they are not already assigned, you can assign the PR to them by writing /assign @gargnupur in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m1093782566: changing LGTM is restricted to assignees, and only istio/istio repo collaborators may be assigned issues.

In response to this:

/lgtm
/assign @hklai
for final review and approval.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

not intall minikube in my local, so the error are normally. Thanks for your review @m1093782566 :upside_down_face:

@stewart-yu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
230250048eb31deb34f8225eb975fd07db2ae247
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
042f3bea94d870c6a20f93bc51b40aa99eeb4bea
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

prow/istio-unit-tests.sh

/test istio-unit-tests

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: GregHanson, m1093782566
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai
If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Let me try to approve this PR.
/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: GregHanson, m1093782566
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai
If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: GregHanson, m1093782566
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: hklai
If they are not already assigned, you can assign the PR to them by writing /assign @hklai in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m1093782566: changing LGTM is restricted to assignees, and only istio/istio repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

may be the robot are unhappy:wink:

@stewart-yu Can you try to assign this PR to me?

/assign @m1093782566

@stewart-yu: GitHub didn't allow me to assign the following users: m1093782566.
Note that only istio members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @m1093782566

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

The robot response so stranger
/cc @hzxuzhonghu

Probably I need to join istio-hacker team.
@rshriram,, am I right?

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: GregHanson, m1093782566
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/e2e/local/OWNERS [m1093782566]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Seems I can make the ci-robot happy now :)
@stewart-yu Thanks for catching this!


New process for /resetPassword

Instead of generate a new password automatically for the user, we want to display a form where the user will be able to set its new password directly. This should clearly simplify the process and avoid some errors.

@boissonnat yo ! if you have some spare time between 2 RoR apps (hu hu hu) could you please try this and tell me if it's ok ? I'd like to do some housekeeping in the backlog... Thx dude !


Fails on Ubuntu 20.04.2 LTS

When running
sudo ansible-playbook playbook.yml
the following issue happens
TASK [basics : Initializing kubernetes] **************************************************************************************
fatal<EMAIL_ADDRESS>FAILED! => {"changed": true, "cmd": "kubeadm init --pod-network-cidr=<IP_ADDRESS>/16 --ignore-preflight-errors=NumCPU", "delta": "0:00:03.119896", "end": "2021-08-08 13:05:34.995954", "msg": "non-zero return code", "rc": 1, "start": "2021-08-08 13:05:31.876058", "stderr": "\t[WARNING NumCPU]: the number of available CPUs 1 is less than the required 2\nerror execution phase preflight: [preflight] Some fatal errors occurred:\n\t[ERROR Mem]: the system RAM (981 MB) is less than the minimum 1700 MB\n\t[ERROR Swap]: running with swap on is not supported. Please disable swap\n[preflight] If you know what you are doing, you can make a check non-fatal with --ignore-preflight-errors=...\nTo see the stack trace of this error execute with --v=5 or higher", "stderr_lines": ["\t[WARNING NumCPU]: the number of available CPUs 1 is less than the required 2", "error execution phase preflight: [preflight] Some fatal errors occurred:", "\t[ERROR Mem]: the system RAM (981 MB) is less than the minimum 1700 MB", "\t[ERROR Swap]: running with swap on is not supported. Please disable swap", "[preflight] If you know what you are doing, you can make a check non-fatal with --ignore-preflight-errors=...", "To see the stack trace of this error execute with --v=5 or higher"], "stdout": "[init] Using Kubernetes version: v1.22.0\n[preflight] Running pre-flight checks", "stdout_lines": ["[init] Using Kubernetes version: v1.22.0", "[preflight] Running pre-flight checks"]}

.


Replace fromstring() with frombuffer() to fix a DeprecationWarning

I only tested this with a couple of images, but it appears that frombuffer() is a drop-in replacement to fromstring() in this case.
This fixes issue #11.

Thanks!


Task lists (also referred to as checklists and todo lists) is not working

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:1.59.1
OS Version:Darwin x64 20.6.0

Steps to Reproduce:
1.Create a task list in a README.md file
2.Check in preview mode if its working or not

/duplicate
For instance, see #138845


support gather_facts: false; support setup-snapshot.yml (#52)

Some users use gather_facts: false in their playbooks.  This changes
the role to work in that case, by gathering only the facts it requires
to run.
CI testing can be sped up by creating a snapshot image pre-installed
with packages.  tests/setup-snapshot.yml can be used by a CI system
to do this.

Thank you, @richm. Updated the pr. If it looks ok, I'm making the two commits into one.

lgtm

Thank you, @richm. Two commits are merged into one, now.


Support override of top-level exception message

According to the docs

it is possible to globally set an error message for a certain exception

The docs then show an example of customising a nested error message when a @NotBlank constraint is violated. However, it does not appear to be possible to override the top-level message. Referring to this same example:
{
  "code": "VALIDATION_FAILED",
  "message": "Validation failed for object='exampleRequestBody'. Error count: 1",
  "fieldErrors": [
    {
      "code": "REQUIRED_NOT_BLANK",
      "property": "name",
      "message": "The property should not be blank",
      "rejectedValue": "",
      "path": "name"
    }
  ]
}

As far as I can tell, it's not possible to customise the top-level message

Validation failed for object='exampleRequestBody'. Error count: 1

It would be useful if I could do this both for my own exceptions and exceptions in library classes

I can add this. Do know that the overridden message will be a static message just like all other overrides. You are not able to add the error count when overriding the message. Is this ok? See linked PR for implementation.

Do know that the overridden message will be a static message just like all other overrides. You are not able to add the error count when overriding the message

I realise that, but I think it's more useful to be able to override with a static message than not being able to override at all.

See linked PR for implementation.

Looks good, thanks for implementing this so quickly. I left a review comment on the PR


a3 re-submission

Something's wrong.  You have many terminating status codes of 301 -- why aren't you following the redirects?  You're not posting the program that you use to generate the HTTP sessions, so I can't see what's wrong with it.


Minor typos

Docs Build status updates of commit 31c96db:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/MoodleInstructions.md
:white_check_mark:Succeeded

msteams-platform/concepts/task-modules/task-modules-bots.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Thanks!


Remove mover image config from m4d-config

This PR fixes #500 and make the standard image configurable in the m4d module and not any more as a global configuration in the m4d-config configmap.

LGTM. Consider setting "ghcr.io/mesh-for-data/mover:latest" as a common const in the code (though it might be removed with controller-tools 0.5.0 so not that important).


Request for License

This repo looks to be quite useful, however currently it is unlicensed. I would recommend adding a license (perhaps MIT, BSD, or whichever you find best suits your needs) to allow others (including myself) to use it in their projects. Thank you for your consideration.
Edit: Looking at gitinfo2 (which includes the example hook), it is under the The LATEX Project Public License 1.3, so that may be a good option for license if you choose to add one.

Thanks a lot for your suggestion.
Let's use the LaTeX project public license (LPPL), version 1.3c


Non-ROS build

Hi again!
Have you considered separating the core logic and the ROS code such that this library can be used in a non-ROS context?
At the moment, it's not possible to use this library without ROS due to catkin in the CMakeLists.txt file. (Except by manually copying the source files into the non-ROS project, ugh).
Here is an example of how to setup pure/plain CMake + catkin package.
I can take a look at this (with perhaps some testing and feedback) if you approve of this change.

Okay to me. @Timple: What do you think?

Sounds good to me!
There are multiple examples of packages available that can be compiled without ROS:
https://github.com/Neargye/magic_enum
https://github.com/RoboSense-LiDAR/rslidar_sdk
https://github.com/introlab/rtabmap
I would not advice to include the plain_cmake dependency as per your link. Because this cannot be resolved by rosdep (it's missing from this database: https://github.com/ros/rosdistro/search?q=plain_cmake
So this would either need to be added there, or a different approach should be followed such as the packages I mentioned.


chore: Fix the typos

Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?

If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

Hello, thank you for you submission, could you please rebase from main to make all checks pass?


refinements to time comparison toggle behavior

addresses feedback under this section: https://www.notion.so/rilldata/Design-Rev-on-Display-percent-of-total-metrics-in-dashboards-2bbf36511ff9452d949286c5a996205e?pvs=4#f086979733b8484ebaccfb41e37b7878 (except for tooltip string change, which is in #2388)

@AdityaHegde requesting your review on this.
Also may need some help getting it over the line with the state serialization in the protobufs. I tried just following what you did in https://github.com/rilldata/rill/pull/2772 since that PR was so straightforward, but when I tried to regenerate the bindings I got a ton of changes in several files, not just the small set of changed you got in web-common/src/proto/gen/rill/ui/v1/dashboard_pb.ts in #2772. I'll keep looking into it (might be down to a different version of buf on my system), but if I can't get it sorted out I might ask you to finish up that last bit.

It looks like it's not just the version of buf, but also orval.  I think it's probably not smart for me to spend more time on this since I'm not familiar with this and don't want to break anything -- I thought I'd try to do it if I could just replicate what you got in #2772, but since it's turned out to be more than trivial to wire up the URL state, I'd be most appreciative if you could take that part @AdityaHegde. I suspect it will be quick for you :-)

Hey @AdityaHegde, I updated this PR to follow your suggestion of using an enum, so it should be ready for you to take if from here for the URL state. One note: changing to an enum involved touching a few extra bits of code, so please pay close attention to make sure the behaviors are still sensible and desired when doing your QA pass for the URL part. Thanks!

@AdityaHegde this PR is getting stale, can you fix the conflicts and merge?
for dashboard-stores, the updated section should be:
  // user selected timezone
  selectedTimezone?: string;

  // flag to show/hide time comparison based on user preference.
  // This controls whether a time comparison is shown in e.g.
  // the line charts and bignums.
  // It does NOT affect the leaderboard context column.
  showComparison?: boolean;

For LeaderboardDisplay, we can take the new code from main
(I tried to do this myself, but I cannot resolve just those merge conflicts without committing conflicted versions of the other files)
This is a soft blocker for #2826.


bug in reachable

reachable has a bug:

backend='numpy'
nodes = [
  tn.Node(
      np.random.rand(2, 2, 2, 2),
      backend=backend,
      name='Node{}'.format(n),
      axis_names=[
          'node{}_1'.format(n), 'node_{}_2'.format(n),
          'node_{}_3'.format(n), 'node_{}_4'.format(n)
      ]) for n in range(4)
]
_ = [nodes[n][0] ^ nodes[n + 1][1] for n in range(3)]
subset = [nodes[0],nodes[1]]
print([b.name for b in tn.reachable(subset)]) #this should always print out all node names; however, sometimes it doesn't (you have to run it several times).

The problem is this:
def _reachable(nodes: Set[BaseNode]) -> Set[BaseNode]:
  if not nodes:
    raise ValueError("Reachable requires atleast 1 node.")
  node_que = collections.deque()
#==========bug===========
  seen_nodes = nodes #this should be an empty set
#============================
  node_que.append(list(nodes)[0])
  while node_que:
    node = node_que.popleft()
    for e in node.edges:
      for n in e.get_nodes():
        if n is not None and n not in seen_nodes:
          node_que.append(n)
          seen_nodes.add(n)
  return seen_nodes

*edit: it should be this
def _reachable(nodes: Set[BaseNode]) -> Set[BaseNode]:
  if not nodes:
    raise ValueError("Reachable requires atleast 1 node.")
  node_que = collections.deque()
  initial_node= list(nodes)[0]
  seen_nodes = {initial_node}
  node_que.append(initial_node)
  while node_que:
    node = node_que.popleft()
    for e in node.edges:
      for n in e.get_nodes():
        if n is not None and n not in seen_nodes:
          node_que.append(n)
          seen_nodes.add(n)
  return seen_nodes

The problem with only having seen nodes be one of the given nodes is when the two given nodes are from disconnected graphs. One would assume it would give a set of all of the nodes from both graphs. The "fix" you have wouldn't allow for that.
Though having a flaky and non-deterministic behavior is also bad. I'm more curious as to why that happens.

yes you're right, I actually realized that yesterday in bed :). The que initially has to hold all input nodes. The reason it breaks now is the following (I'll use numbers to distinguish different nodes):
assume you have  [`Node0, `Node1`, `Node2`] where `Node1` connects to `Node2` and `Node2` to `Node3`. if you do
reachable([Node0, Node1`])

then the original code in _reachable has nodes={Node0, Node1} (because reachable converts the input to a set) and seen_nodes = {Node0, Node1}. Sometimes, list(nodes)[0] returns Node0 into the deque. The algorithm then looks at all nodes connected to Node0 and puts them into seen_nodes and the deque, if they are not yet there. However, Node1 is already in seen_nodes and is thus never added to the deque, even though it should be added because we haven't yet checked all of its connections

Yes that fix looks good. Be sure to add a test!


Use option structs instead of arguments

With the recent addition of additional arguments with v2 the functions became very hard to use (or rather, even worse than before).
Without advanced IDE support that shows the parameter names inline (only GoLand for now) it's very hard to identify the arguments, especially when omitting a lot of them. A common pattern in Go is using a struct as a single argument, that then contains the different options. It has several advantages over the current approach:

shorter method signature
optional arguments can simply be omitted
used arguments are easy to identify as you have to put the attribute name in front of them
easy to expand with further attributes without breaking changes

for example:
hostRecord, err = objMgr.CreateHostRecord(true, false, deviceFQDN, networkView, "default."+networkView, subnet.String(), "", "", "", "", "", false, 0, "", make(ibclient.EA), nil)

could become
hostRecord, err = objMgr.CreateHostRecord(CreateHostRecordOptions{
	NetworkView: networkView,
	DNSView: "default."+networkView,
	EnableDNS: true,
	IPv4CIDR: subnet.String(),
})

The latter is a lot easier to read and understand quickly. While it would be another breaking change in a short time, it's a worthy improvement in my opinion.
Also, if you would've used this approach before, a lot of the breaking API changes with v2 wouldn't have been breaking changes.

Thank you for your report. Yes, there is such a problem. There were reasons to move to the form of passing parameter values as a literal list. But this was considered as a temporary solution.
Now we are on the way of reconsidering the API of the Go-client for WAPI and stabilizing it to avoid possibilities of breaking  changes in the future as much as possible. And your proposal is one of the main points. Thank you again.


adds correct content-type header for doi draft creation

corrects Content-Type header for DOI draft creation

@sephirothkod This change looks good!  I suspect the failing tests are due to the network request stubs in the tests being incorrect (and possibly too strict).  The tests might go green if you make the same change on this line:
https://github.com/samvera-labs/hyrax-doi/blob/main/spec/support/datacite_api_stubs.rb#L17


perf: store packuments in memory as gzip

Issue type

[ ] bug report
[x] idea
[ ] question
[ ] other

:tada: This issue has been resolved in version 1.32.3 :tada:
The release is available on:

v1.32.3
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


assert hit on PM_IDLE exit in subsys/pm/pm.c:133

Describe the bug
Starting with commit b9d4b9d9aba0489cd31b687afd9f7a7883230d78 ("pm: Remove CURRENT_CPU macro"), SOF public test have started failing with
ASSERTION FAIL [!z_smp_cpu_mobile()] @ ZEPHYR_BASE/subsys/pm/pm.c:133
[  220.790855]  os: print_fatal_exception:  ** FATAL EXCEPTION
... the system is running active use-case on core0 and the assert happens when SOF releases the IDLE state lock with
"pm_policy_state_lock_put(PM_STATE_RUNTIME_IDLE, PM_ALL_SUBSTATES);" and allow Zephyr to enter RUNTIME_IDLE on core0.
To Reproduce
Steps to reproduce the behavior:

build SOF with Zephyr for Intel MTL target
run sof-test case: TPLG=/lib/firmware/intel/development/sof-mtl-nocodec.tplg MODEL=MTLP_RVP_NOCODEC SOF_TEST_INTERVAL=5 ~/sof-test/test-case/check-playback.sh -d 10 -l 1 -r 1

Expected behavior
Test passes.
Impact
Loss of audio on end-user system.
Logs and console output
https://sof-ci.01.org/sofpr/PR8901/build3107/devicetest/index.html?model=MTLP_RVP_NOCODEC&testcase=check-playback-10sec
See the "mtrace" tab to see Zephyr log.
Environment (please complete the following information):

OS: Linux
Toolchain: XCC / cadence
commit:  v3.6.0 tag (also tested with v3.6.0 plus 672c21d1db68678b171729caf746d9ddf1427548 )

Additional context
With the identified Zephyr commit revert, the same test passes reliably with no other failures seen in the test.

We did have an earlier discussion about this in https://github.com/zephyrproject-rtos/zephyr/pull/68234 . The consensus back then was that the case I originally reported was fixed by https://github.com/zephyrproject-rtos/zephyr/pull/67863 . We are however seeing this assert hit again, even with #67863 part of the tree.

Notable Kconfig settings used that affect the PM state transitions:
CONFIG_ADSP_POWER_DOWN_HPSRAM=y
CONFIG_ADSP_IMR_CONTEXT_SAVE=y
CONFIG_ADSP_IDLE_CLOCK_GATING=y
CONFIG_PM_POLICY_CUSTOM=y
CONFIG_PM_DEVICE=y
CONFIG_PM_DEVICE_POWER_DOMAIN=y
CONFIG_PM_DEVICE_RUNTIME=y

Still hit the error with Zephyr main of today (commit 0d5a670f4f073ff2185221b76afc1998a08a4074 ). Needed some HWMv2 work to make SOF build again.
The issue does not happen on every run, so reproduction is not 100% but with enough repeats, I still get it. The crash looks similar, so interrupt state is unexpected when system resume is done:
[37076.296076] <inf> ipc: ipc_cmd: rx   : 0x48000000|0x12
[37076.380685] <inf> ll_schedule: zephyr_domain_thread_fn: ll core 0 timer avg 1627, max 2743, overruns 0
[37077.404685] <inf> ll_schedule: zephyr_domain_thread_fn: ll core 0 timer avg 1840, max 2279, overruns 0
[37078.428685] <inf> ll_schedule: zephyr_domain_thread_fn: ll core 0 timer avg 1841, max 3378, overruns 0
ASSERTION FAIL [!z_smp_cpu_mobile()] @ ZEPHYR_BASE/subsys/pm/pm.c:133
[37079.232761] <err> os: print_fatal_exception:  ** FATAL EXCEPTION
[37079.232770] <err> os: print_fatal_exception:  ** CPU 0 EXCCAUSE 63 (zephyr exception)
[37079.232775] <err> os: print_fatal_exception:  **  PC 0xa0065773 VADDR (nil)
[37079.232780] <err> os: print_fatal_exception:  **  PS 0x60020
[37079.232798] <err> os: print_fatal_exception:  **    (INTLEVEL:0 EXCM: 0 UM:1 RING:0 WOE:1 OWB:0 CALLINC:2)
[37079.232803] <err> os: xtensa_dump_stack:  **  A0 0xa0063e08  SP 0xa010b290  A2 0x4  A3 0xa010b2a0
[37079.232808] <err> os: xtensa_dump_stack:  **  A4 0xa010b280  A5 0x4  A6 0xfffbfff0  A7 0x4
[37079.232815] <err> os: xtensa_dump_stack:  **  A8 0xa0063d52  A9 0xa010b220 A10 0xa00d9451 A11 0xa010b2a0
[37079.232820] <err> os: xtensa_dump_stack:  ** A12 0xa010b280 A13 0x4 A14 (nil) A15 0xffffffff
[37079.232826] <err> os: xtensa_dump_stack:  ** LBEG 0xa0062e3b LEND 0xa0062e48 LCOUNT 0xa003669e
[37079.232831] <err> os: xtensa_dump_stack:  ** SAR 0xc
[37079.232836] <err> os: xtensa_dump_stack:  **  THREADPTR 0xa00da203

Backtrace:0xa0065770:0xa010b290 0xa0063e05:0xa010b2a0 0xa0036c6c:0xa010b2c0 0xa0037107:0xa010b2f0 0xa00847d3:0xa010b310 0xa0063ddb:0xa010b330

[37079.232910] <err> os: z_fatal_error: >>> ZEPHYR FATAL ERROR 4: Kernel panic on CPU 0
[37079.232918] <err> os: z_fatal_error: Current thread: 0x4010e030 (unknown)
[37079.234985] <err> coredump_error: coredump_mem_window_backend_start: #CD:BEGIN#
[37079.235156] <err> coredump_error: coredump_mem_window_backend_end: #CD:END#
[37079.235273] <err> zephyr: k_sys_fatal_error_handler: Halting system

@kv2019i does it happens using https://github.com/zephyrproject-rtos/zephyr/pull/68493/commits/a38649367b1c9b15b2d55c2f02bd07547dd4bafc ? The reason to see this problem is because intel_adsp/ace power management is unlocking interruptions before the pm subsystem calling pm_state_exit_post_ops.

@ceolin wrote:

@kv2019i does it happens using a386493 ? The reason to see this problem is because intel_adsp/ace power management is unlocking interruptions before the pm subsystem calling pm_state_exit_post_ops.

In local test this at least affects the reproduction rate. I now scheduled a larger test plan with SOF CI infra at https://github.com/thesofproject/sof/pull/8928 .. will update results here

Incredibly stupid, Github auto-close anti-feature: https://github.com/orgs/community/discussions/23476
The tentative fix is in a different repo and not even part of sof/west.yml yet!
Issues should be closed when tests are passing again and never before.

@marc-hb We do have a separate bug in SOF to track this issue https://github.com/thesofproject/sof/issues/8908 , so I think we can close this bug on Zephyr as I've tested the fix. We can use the SOF bug to track integration of the fix into SOF (but that's outside Zephyr). Let's keep open for 24h as we complete more testing.

Sorry I confused this with https://github.com/thesofproject/sof/issues/8908


Using the pakchunkEarly for the patch always gives the platform restriction error on every version

Idea of how to fix it: rename it to something else 🤯 (pakchunkEarlyTest-Switch_P?)

nope


[$500] Clicking on room name while loading crashes the app

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.39-0
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @getusha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1707493474003029
Action Performed:
1.Go offline
2.Open a workspace
3.go to announce room
4.make sure the loading skeleton is shown
5.Press on the room header
Expected Result:
Opens details page
Actual Result:
App crashes
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/e8cc9d0c-d132-4dc0-8e05-17912c2bb810

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cd42193c8752a37e
Upwork Job ID:<PHONE_NUMBER>032115200
Last Price Increase: 2024-02-09

i have solved this problem countless times in my own android app so i know the solution

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~014ae4361b802854c6

I think it is fixed here

Regression from issue https://github.com/Expensify/App/issues/25195 , PR https://github.com/Expensify/App/pull/35153 (merged 2h ago).

Regression from issue #25195 , PR #35153 (merged 2h ago).

@ikevin127 you mean fixed by #25195?
Seems like that PR fixed crash, not caused crash

@ZhenjaHorbach if you find the case of report being undefined or null, we can continue this issue.
Otherwise can be closed.

Regression seems to be from https://github.com/Expensify/App/pull/34150 and https://github.com/Expensify/App/issues/25195 fixed the crash.

yes, Onyx values are optional and agree that we should use optional chaining everywhere.

https://github.com/Expensify/App/pull/35153 hit staging.
Now crash doesn't happen on staging.

@ZhenjaHorbach thoughts on https://github.com/Expensify/App/issues/36271#issuecomment-1936320722?

ok @dylanexpensify let's close as fixed


Use quaternions instead of rotation matrixes as much as possible

The advantages would be:

Quaternions are more computationally efficient
Quaternions don't have singularities
The code gets better structured and therefore easier to understand: instead of having quaternions + rotation matrixes + euler angles we only have quaternions for computation and euler angles for interpretability

A disadvantage might be that quaternions are tricky to understand. But with good functions / documentation this should be fine.

Well, there are not many conversions that are really required. The main conversion function is calc_heading(). Feel free to write a version of this function that uses quaternions. But it is not time critical, because it is called only once per timestep and not in the callback of the DAE solver.


⚠ ClamAV has degraded performance

In 5c02b09, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 69 ms

Resolved: ClamAV performance has improved in 3414ccc.


Implement pebble health checks

Description
Implement pebble health checks

Ran into this today - workload is reporting errors but the charm reports Active/Idle
Can be reproduced by:
juju deploy oidc-gatekeeper
kubectl logs oidc-gatekeeper-0 oidc-authservice -f

# (truncated the start of the logs)
# ...
2024-01-18T21:08:29.496Z [oidc-authservice] time="2024-01-18T21:08:29Z" level=error msg="OIDC provider setup failed, retrying in 10 seconds: Get \"http://test-url/dex/.well-known/openid-configuration\": dial tcp: lookup test-url on <IP_ADDRESS>:53: no such host"

Regarding the health check's implementation, when oidc-authservice cannot start, it logs what was mentioned in the previous comment. Trying to curl the service port (8080) from inside the pod, this returns a 503 request with message OIDC Setup is not complete yet..
╰─$ kubectl -n kubeflow exec oidc-gatekeeper-0 -c charm -- curl localhost:8080

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    31  100    31    0     0  31000      0 --:--:-- --:--:-- --:--:-- 31000
OIDC Setup is not complete yet.%

adding -I results in:

HTTP/1.1 503 Service Unavailable
Content-Type: text/plain
Date: Fri, 02 Feb 2024 12:56:49 GMT
Content-Length: 31

When the OIDC setup is complete and the svc is working, curling the same port, results in a successful 302 request
╰─$ kf exec oidc-gatekeeper-0 -c charm -- curl localhost:8080
(svc ip)

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   367  100   367    0     0   179k      0 --:--:-- --:--:-- --:--:--  179k
<a href="http://<IP_ADDRESS>.nip.io/dex/auth?client_id=authservice-oidc&redirect_uri=%2Fauthservice%2Foidc%2Fcallback&response_type=code&scope=openid+profile+email+groups&state=MTcwNjg3NzQ5MXxOd3dBTkZwS05WQldOVVZPVEZST1FrdEVSVnBHTmpkQk5EVTNORk0wVmt4RlIwUktTekpSTjBOVFYwZE1UazFaUjBwYU5sTk1XRUU9fCd1dGAKv6VgobwzUaKugEVwxTAhYm_TtuhbejMc5Aqf">Found.

adding -I results in:

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0HTTP/1.1 302 Found
Content-Type: text/html; charset=utf-8
Location: http://<IP_ADDRESS>.nip.io/dex/auth?client_id=authservice-oidc&redirect_uri=%2Fauthservice%2Foidc%2Fcallback&response_type=code&scope=openid+profile+email+groups&state=MTcwNjg3ODY5MHxOd3dBTkRkWU4xZE9SREpZVjFWWVREZEtORXBNU2tKVVYwTkxWVU0yU1VWQ1FVdGFWMUJGVUZJMVRsaFlORXRZV2xwRU4wWlBSMUU9fOOsNXPYQ1GM4dr1tagMW-aWgVvOTaFK_XuJdDBl8hn-
Set-Cookie: oidc_state_csrf=MTcwNjg3ODY5MHxOd3dBTkRkWU4xZE9SREpZVjFWWVREZEtORXBNU2tKVVYwTkxWVU0yU1VWQ1FVdGFWMUJGVUZJMVRsaFlORXRZV2xwRU4wWlBSMUU9fOOsNXPYQ1GM4dr1tagMW-aWgVvOTaFK_XuJdDBl8hn-; Path=/; Expires=Fri, 24 Jul 2054 13:51:39 GMT; Max-Age=1200000000000
Date: Fri, 02 Feb 2024 12:58:10 GMT

Thus, we will base the health check's implementation on this workload's behaviour and implement it like that:
...
                    "on-check-failure": {self._health_check_name: "restart"},
                }
            },
            "checks": {
                self._health_check_name: {
                    "override": "replace",
                    "period": "10s",
                    "timeout": "3s",
                    "http": {"url": f"http://localhost:{self._http_port}"},
                }
            },

Charm handling
In order for the charm reflect the failed health check, it has to:

explicitly check the health check status
if the check is down, act upon it in order to reflect it in its status

Following what admission-webhook-operator does, this check will happen on update-status events. If down, the charm's status will be set to Maintenance(with workload failed health check).

Reiterating on that (see https://github.com/canonical/oidc-gatekeeper-operator/pull/134#pullrequestreview-1888166557), at the moment, as stated above, Pebble does not offer a mechanism to reflect in the charm's status the workload's health check.
Pebble notices
As of Pebble 1.7 (included in Juju 3.4), Pebble offers custom notices mechanism (discourse post). These allow a workload to use pebble notify and essentially wake up the charm so it can act on it (e.g. update status, raise an error etc).
In order to implement that, we would need to add a script that would be added to the workload's container. This would be responsible for checking periodically the workload's health check's status.
The conerns with this is that:

We first need to migrate to Juju 3.4 to use pebble notices (we will need to do that anyway very soon)
No other teams are likely using Pebble notices yet (random conversation in MM)
This would require manual process while Pebble team is working at the moment on a feature (matrix conversation) they plan to deliver before May 2024, which will introduce automated pebble notices for health check failures. Essentially, it will give the ability to wake up the charm when a check fails or changes state, without having to manually add any script to the workload.


Quickly start AppServers till minimum number

This PR makes AppScale more reactive to the user wishes: we start (or
try to start) as many AppServer we can till we reach the desired minimum
number. We then let the autoscaler to work as usual.


Create an issue template for bugs

Description
Create an issue template for bugs
Acceptance criteria

The right balance between details and not scaring the user from opening issues has been found

Tasks

[ ]

Story Points

We did really well by keeping it limited to:
Steps to reproduce

Do this
Click here

Expected result

Button is blue

Actual result

Button is green

Besides that, Mozilla has a really solid guide.


Improve documentation for insert statement

in the insert statement connection.query( 'insert into table set ? ',obj,function(){}) if all the fields of obj is not matched it not showing up any error it just doesnt insert .

Hi @avmadhukiran I don't see that line anywhere in our README. Can you point to where it is?

var post  = {id: 1, title: 'Hello MySQL'};
var query = connection.query('INSERT INTO posts SET ?', post, function(err, result) {
// Neat!
});
console.log(query.sql);
this part

Gotcha :) So you're asking that I add a if (err) throw err; line inside the function like all the others, correct? Would you be willing to make a pull request?

yes


Filter operations

I am particularly interested in understanding if the project includes support for implementing filtering operations. I would like to know if there are built-in mechanisms or guidelines within the project to facilitate the implementation of filters for entities.
If filtering is already supported in the project, I would greatly appreciate any instructions, documentation references, or examples that could assist me in implementing this feature effectively.

@konyilwin I'm sorry I missed this comment. Are you still interested in this feature?


With Bootstrap 3.3.6 collapse script. Uncaught TypeError: Cannot read property 'height' of undefined

metismenu - v2.5.0

Hi I'm using with bootstrap.
When BS collapse script fired. I got below error.
Uncaught TypeError: Cannot read property 'height' of undefined
I remove metisMenu.js temporary.
The error disappeared.
thanks.

I have mine working on bootstrap 3.3.6

@jondavis0787
OK. I seems to depend on my env.
I'll check other situation. thanks.

If you upgrade to metismenu - v2.5.2, then the problems disappears 👍


Add meeting details like cadence, etc.

Recommending these details (in pull request) be added to the "Meetings" section of the README file for better clarification to newcomers to this repo, that would like to get involved.  Listening in on the publicly open segments is a good way to get started.

Done!

Cleaned up!  Btw, nitpicks are welcomed!  👊🏼 Incidentally, in this case, for me, it was more about getting the details in there to help newcomers quickly ramp up on how to get involved, etc.--especially since I kinda ran into that myself.  😉

Going to merge this. Thanks for your contribution @cdnadmin 💥


SAK-45406 CM SampleDataLoader not loading because of exceptions

The issue with SampleDataLoader not finishing is fixed, however I've uncovered some other issues that were muted.
Making this as a Draft for now as I've got more to fix.

Thank for looking at it, looks like good changes! Was going to test this but it doesn't compile yet. I'll wait for it to be moved out of draft.

Yeah it's not ready just yet ;)


docs: add note about spin-up time to README

Signed-off-by: Tyler Slaton<EMAIL_ADDRESS>

I'm not sure if we want to include this documentation or solve this in-code (#328).
Overall though, if a user is installing from a release, I think we could provide a quick script that ensures the installation is up and ready? This seems like a good candidate for the rukpak CLI tool potentially

I agree with you on all of this. I think my preference would be to solve it in code but we can have this as a back-up if we don't feel that the code implementation is quite right.

@exdx I suggested this approach to Tyler because I figured it'd be pretty easy to forget updating that script or instruction if we:

added or removed a thing that needed to be waited on
changed the name or namespace of something that needed to be waited on.


Heavy SSAO artifacts when distant from world center

In the Physics example (bsfExamples), the spheres exhibit heavy artifacts once having left the plane on which you spawn (and moving 100-200m further away).

RTX 2080
Windows 10 1809
Game Ready Drivers 430.39

Thanks for the report, I'm able to reproduce the issue. This might be related to some of the features we have planned for increasing rendering precision, so it might take me a while to investigate this properly.


[AutoPR-contoso]E2E User Experience of Onboarding Service to CADL

Create to sync https://github.com/Azure/azure-rest-api-specs/pull/22223

/azp run prepare-pipelines

/azp run java - contoso - ci

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-template-contoso


time: invalid duration issue with 1.20.0

Bug description
Updated from 1.19.2 to 1.20.0 and portainer can't start
Expected behavior
Portainer should start
Steps to reproduce the issue:
No ideas at all.
This seems to be related to host job schedule, which looks new in 1.20.0.
Technical details:

Portainer version: 1.20.0
Docker version (managed by Portainer): 18.06.0-ce
Platform (windows/linux): linux
Command used to start Portainer: docker run -d -p 9000:9000 --name portainer --restart always -v /var/run/docker.sock:/var/run/docker.sock -v /mnt/zfs/deadpool0/docker/portainer:/data portainer/portainer:1.20.0
Browser: N/A

Additional context
The log only shows:
2018/12/12 07:34:48 Migrating database from version 14 to 15.
2018/12/12 07:34:50 Templates already registered inside the database. Skipping template import.
2018/12/12 07:34:50 Failed to parse duration @every : time: invalid duration
2018/12/12 07:34:51 Templates already registered inside the database. Skipping template import.
2018/12/12 07:34:51 Failed to parse duration @every : time: invalid duration
...

Same here upgrade from 1.19 to 1.20
2018/12/12 07:50:12 Migrating database from version 14 to 15.
2018/12/12 07:50:13 Templates already registered inside the database. Skipping template import.
2018/12/12 07:50:13 Failed to parse duration @every : time: invalid duration

Same issue here:
2018/12/12 05:25:09 Migrating database from version 14 to 15.
2018/12/12 05:25:09 Templates already registered inside the database. Skipping template import.
2018/12/12 05:25:09 Failed to parse duration @every : time: invalid duration

Ok, we're investigating this one.

@rhaamo @Nightbr @dovab could any of you try the following image and tell us if it solves your issue?
portainerci/portainer:fix2542-empty-snapshot-interval

@deviantony looks ok
root@oignon:/mnt/zfs/deadpool0/docker/portainer# docker run -d -p 9000:9000 --name portainer --restart always -v /var/run/docker.sock:/var/run/docker.sock -v /mnt/zfs/deadpool0/docker/portainer:/data portainerci/portainer:fix2542-empty-snapshot-interval
Unable to find image 'portainerci/portainer:fix2542-empty-snapshot-interval' locally
fix2542-empty-snapshot-interval: Pulling from portainerci/portainer
d1e017099d17: Already exists
803b519af3d4: Pull complete
Digest: sha256:0f0e9260b7bf983a198e3f8037f78b065f21b049ac3271c6bf151224958156aa
Status: Downloaded newer image for portainerci/portainer:fix2542-empty-snapshot-interval
af31733300c06540f6957fdaf143f5570abb1e1791eec514a6bc4dc3ce454708
root@oignon:/mnt/zfs/deadpool0/docker/portainer# docker logs portainer
2018/12/12 08:10:26 Migrating database from version 15 to 16.
2018/12/12 08:10:26 Templates already registered inside the database. Skipping template import.
2018/12/12 08:10:26 Starting Portainer 1.20.0 on :9000

Works!

Works for me aswell!

ok thanks for your report, will push ASAP.

Fix is now publicly available.


[DO NOT MERGE]Update no visa outcome for countries in EEA and Ireland

Trello

Hi @edwardkerry. Do we still need this PR, or can we close it?

There is a chance that this PR will still be used in the future, so I am re-opening it. As soon as I receive final confirmation I will merge or close as appropriate 👍

@edwardkerry Any update on this PR? Can we close it for now if it's been merged soon?

@theseanything yes we believe this is now superseded by #4952.


note that this is for applications, not libraries

also link to the temporary home of the showcase

r? @therealprof
(rust_highfive has picked a reviewer for you, use r? to override)

bors r+