HDFS-17130. Blocks on IN_MAINTENANCE DNs should be sorted properly in LocatedBlocks.

Description of PR
Blocks on IN_MAINTENANCE DNs should be sorted properly in LocatedBlocks.
How was this patch tested?
Unit Test
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Public signup for this instance is disabled, After submitting the application, it was rejected, so that I did not apply for a jira account.
This PR supplements the in_maintenance status of DN when sorting LocatedBlocks in ClientProtocol#getBlockLocations

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 29s

trunk passed

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 45s

trunk passed

+1 :green_heart:
mvnsite
0m 56s

trunk passed

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 59s

trunk passed

+1 :green_heart:
shadedclient
22m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 46s

the patch passed

+1 :green_heart:
compile
0m 47s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 47s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 33s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 50 unchanged - 0 fixed = 52 total (was 50)

+1 :green_heart:
mvnsite
0m 46s

the patch passed

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  6s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 56s

the patch passed

+1 :green_heart:
shadedclient
22m 23s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
194m 26s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

290m 34s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5879

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 6ee51bc55ce3 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b7e79dda916a53449a4d1ea62261e0416f473aaa

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/1/testReport/

Max. process+thread count
3599 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn Could you help review this when you have time? And solved the problem that some jira accounts could not be applied for, Thanks!

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 54s

trunk passed

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 50s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 45s

trunk passed

+1 :green_heart:
mvnsite
0m 54s

trunk passed

+1 :green_heart:
javadoc
0m 51s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 12s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
2m  0s

trunk passed

+1 :green_heart:
shadedclient
22m  8s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 45s

the patch passed

+1 :green_heart:
compile
0m 48s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 48s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 33s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 50 unchanged - 0 fixed = 53 total (was 50)

+1 :green_heart:
mvnsite
0m 47s

the patch passed

+1 :green_heart:
javadoc
0m 36s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  2s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 55s

the patch passed

+1 :green_heart:
shadedclient
21m 59s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
196m 56s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

291m 32s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5879

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux ff25472109ed 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 836519f90ef3f272c8c1573ed6adf183f70c592c

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/2/testReport/

Max. process+thread count
3486 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Public signup for this instance is disabled, After submitting the application, it was rejected, so that I did not apply for a jira account, So much so that it's impossible to create a ticket.

Thanks for your contribution. Please try again, and attach this PR and other reasons together.

Public signup for this instance is disabled, After submitting the application, it was rejected, so that I did not apply for a jira account, So much so that it's impossible to create a ticket.

Thanks for your contribution. Please try again, and attach this PR and other reasons together.

Thanks for your review. I will try again.

It isn’t letting me approve either:

Submit a request again after 24 hrs have past the rejection, if still it doesn’t work, lemme know, will try to figure out whats wrong

It isn’t letting me approve either:
Submit a request again after 24 hrs have past the rejection, if still it doesn’t work, lemme know, will try to figure out whats wrong

Thanks for your reply. It may have been over 24 hours. I think I should change my email and reapply as required（<EMAIL_ADDRESS>）

Thanks @Hexiaoqiao @ayushtkn, I have applied for a Jira account and modified the commit information for this PR.

In DatanodeManager, there is a comment on line 545 that needs to be modified.

For striped blocks, it will only move decommissioned/decommissioning/stale/slow

should be

For striped blocks, it will only move decommissioned/in_maintenance/decommissioning/stale/slow

Thx, bro!

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
44m 38s

trunk passed

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 37s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
35m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  0s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 50 unchanged - 0 fixed = 53 total (was 50)

+1 :green_heart:
mvnsite
1m 17s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 19s

the patch passed

+1 :green_heart:
shadedclient
37m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
222m 56s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

366m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5879

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux bf455918b98c 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 72f7a40a9cc9457dc15f47c6079c0a8be3cd24d8

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/4/testReport/

Max. process+thread count
3599 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 20s

trunk passed

+1 :green_heart:
compile
1m 32s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 26s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 19s

trunk passed

+1 :green_heart:
mvnsite
1m 36s

trunk passed

+1 :green_heart:
javadoc
1m 17s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 54s

trunk passed

+1 :green_heart:
shadedclient
41m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 21s

the patch passed

+1 :green_heart:
compile
1m 27s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 27s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 50 unchanged - 0 fixed = 53 total (was 50)

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 32s

the patch passed

+1 :green_heart:
shadedclient
41m 54s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
219m 42s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

379m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5879

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a1cb7183f18c 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a530a808e178342bbb974d29692dfe48d7b0641a

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/5/testReport/

Max. process+thread count
3304 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 36s

trunk passed

+1 :green_heart:
compile
1m 29s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 24s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 46s

trunk passed

+1 :green_heart:
shadedclient
41m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 21s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  8s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 50 unchanged - 0 fixed = 53 total (was 50)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
javadoc
1m  2s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 38s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 37s

the patch passed

+1 :green_heart:
shadedclient
39m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
224m 59s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

384m 36s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5879

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d29ac836f9c4 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1cb62fd9d105ee356a73d214b017239d741539f8

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/6/testReport/

Max. process+thread count
3096 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
45m 17s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 38s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 30s

trunk passed

+1 :green_heart:
shadedclient
37m 46s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 59s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 3 new + 50 unchanged - 0 fixed = 53 total (was 50)

+1 :green_heart:
mvnsite
1m 21s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 33s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 31s

the patch passed

+1 :green_heart:
shadedclient
38m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
140m 27s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
asflicense
0m 48s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

287m  0s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestReconstructStripedFileWithValidator

hadoop.hdfs.TestErasureCodingExerciseAPIs

hadoop.hdfs.TestDistributedFileSystemWithECFile

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.TestMaintenanceWithStriped

hadoop.hdfs.TestDFSStorageStateRecovery

hadoop.hdfs.TestSetrepIncreasing

hadoop.hdfs.TestFileChecksum

hadoop.hdfs.TestClientProtocolForPipelineRecovery

hadoop.hdfs.TestDistributedFileSystem

hadoop.hdfs.TestFileAppend

hadoop.hdfs.TestStripedFileAppend

hadoop.hdfs.TestReadStripedFileWithDecoding

hadoop.hdfs.TestParallelShortCircuitReadNoChecksum

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5879

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux b9f14bcfdce6 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 463b464c564f52e0bafda63a84bdf9e57ddef2fe

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/7/testReport/

Max. process+thread count
2904 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m  1s

trunk passed

+1 :green_heart:
compile
1m 27s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 24s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 22s

trunk passed

+1 :green_heart:
shadedclient
44m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  3s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 50 unchanged - 0 fixed = 51 total (was 50)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 27s

the patch passed

+1 :green_heart:
shadedclient
42m 46s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
244m  9s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

403m 59s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5879

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e3489edf81a6 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 03b8306a2c98c1db171e474bba04e7e58175c15e

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/8/testReport/

Max. process+thread count
2096 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

This UT is not related to this change.
Hi @Hexiaoqiao @ayushtkn , If you think this PR no problem, could you help merge it to trunk ? Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 20s

trunk passed

+1 :green_heart:
compile
0m 54s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 49s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 44s

trunk passed

+1 :green_heart:
mvnsite
0m 54s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 58s

trunk passed

+1 :green_heart:
shadedclient
22m 20s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 47s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 33s

the patch passed

+1 :green_heart:
mvnsite
0m 48s

the patch passed

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  7s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 50s

the patch passed

+1 :green_heart:
shadedclient
22m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
195m 33s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

288m 58s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5879

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux a0c0823dca96 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 295be16375515c28dae27461eee9693a6aabcba3

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/9/testReport/

Max. process+thread count
3964 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 53s

trunk passed

+1 :green_heart:
compile
1m 30s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
1m 18s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
1m 17s

trunk passed

+1 :green_heart:
mvnsite
1m 32s

trunk passed

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 30s

trunk passed

+1 :green_heart:
shadedclient
41m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 20s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  7s

the patch passed

+1 :green_heart:
mvnsite
1m 25s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
3m 29s

the patch passed

+1 :green_heart:
shadedclient
36m 39s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
220m 10s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

373m 37s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5879

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 68ed23ee6d74 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d0c188edea29767e968f0a37805de2af265f88c9

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/10/testReport/

Max. process+thread count
3425 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 34s

trunk passed

+1 :green_heart:
compile
0m 56s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
compile
0m 48s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
checkstyle
0m 44s

trunk passed

+1 :green_heart:
mvnsite
0m 57s

trunk passed

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 58s

trunk passed

+1 :green_heart:
shadedclient
22m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 45s

the patch passed

+1 :green_heart:
compile
0m 46s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javac
0m 46s

the patch passed

+1 :green_heart:
compile
0m 43s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
javac
0m 43s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 36s

the patch passed

+1 :green_heart:
mvnsite
0m 48s

the patch passed

+1 :green_heart:
javadoc
0m 38s

the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1

+1 :green_heart:
javadoc
1m  8s

the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

+1 :green_heart:
spotbugs
1m 52s

the patch passed

+1 :green_heart:
shadedclient
22m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
189m 13s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

282m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5879

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9bafcc5c606e 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / df79c4ec7da571017caf3739890c7c25a1c08c16

Default Java
Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~20.04-b09

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/11/testReport/

Max. process+thread count
3922 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5879/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @Hexiaoqiao Could you help review this when you have time?

@huangzhaobo99 Thanks to involve me here, but I am not fans of this feature. Let's wait if other folks are interested to it. Thanks again.

@huangzhaobo99 Thanks to involve me here, but I am not fans of this feature. Let's wait if other folks are interested to it. Thanks again.

@Hexiaoqiao Thanks, actually this is not a new feature, it's just that the status of dn is missing some judgment.

@tomscut Could you help review this when you have time?


RANSAC

Found an example where the results aren't symmetric , i.e., the result of aligning an image A to  image B works fine, but  aligning  B to A isn't converging. RANSAC is involved in the stacktrace error. Doing some research about RANSAC found this package scikitimage where it uses RANSAC and seems quite tested. Is there a way to test the results of ransac from here vs RANSAC from sickitimage.

This may have to do with #7

Yes, in fact I already made a push, modifyng some options to align_image,
so now it can receive the desired number of sources used for reference and
test.
This once properly settled performs well. (In fact I obtained a great
alignation).
Things like this now are valid:
´´´
mlaligned = astroalign.align.align_image(ml, mr, n_test_src=50,
n_ref_src=50, px_tol=2.)
´´´
2016-04-21 12:24 GMT-03:00 Martin Beroiz<EMAIL_ADDRESS>
This may have to do with #7
https://github.com/toros-astro/astroalign/issues/7
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/toros-astro/astroalign/issues/13#issuecomment-212971119


Why is there 'classList', but don`t have className?

Why is there 'classList', but don`t have className?

Because className is supported pretty much universally, including in IE6.

Added at http://caniuse.com/#search=classname


fix documentation

I'm submitting a

[ ] bug fix
[ ] feature
[x] documentation addition

What is the current behaviour?
The documentation has an person passing in VERSION as an environment variable for pinning a specific version of comtrya correctly.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
#494
What is the expected behavior?
A person can use the curl and piped to bash script to get a specific version of comtrya.
What is the motivation / use case for changing the behavior?
#494

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 26.99%. Comparing base (b574682) to head (6866eba).
Report is 63 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   28.59%   26.99%   -1.61%
==========================================
  Files          85       86       +1
  Lines        2301     2434     +133
==========================================
- Hits          658      657       -1
- Misses       1643     1777     +134

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore(deps): bump phlex to 2.0.0.rc

Let me know if this is of interest, it seems phlex 2.0 removes the deferred renderer but this should do almost the same thing. I have a couple of tweaks more but was hoping for some initial feedback so that I don't waste anyones time.
A couple of tests are not passing, there are warnings about onlick attribute not being safe but this should save you a bunch of figuring out.

Hey @mhenrixon, this is awesome! Thanks for taking the time to dig into this, truly a time saver 🙌🏼
I ran locally and things look good, a few things on the failed specs:
For the button_spec, I think we can:

Remove the specs that have the comment TODO: Not needed once Phlex 2.0 is released., since the failures are legit when using onclick without safe and the final HTML is properly escaped.
Fix the PhlexyUI::Button passing :modal option renders it correctly which only has spec attributes out of order, it's pretty harmless.

This should make the whole Button suite pass.
Other than that, I think it's only a matter of a bug in Phlex 2.0.0rc that is dasherizing attributes passed in as symbols with underscores, e.g. id: :my_id becomes id="my-id", I've opened an issue here https://github.com/phlex-ruby/phlex/issues/827.
I think that should fix all failing specs!
Let's wait a bit for Joel to answer on that issue, see if it's going to be fixed or if we'd need to update the specs on this side.

Regarding the vanish changes, it's a bit mysterious, but hey it works! I'd probably add a comment on each usage explaining why we use it. I have asked Joel on bsky to see if that's going to be documented.
When you say "almost the same thing", what do you mean? Do you know some caveats?

Regarding the view helper, hopefully we'll see https://github.com/phlex-ruby/phlex/pull/809 merged to get the Phlex::Testing::ViewHelper in without having to define it ourselves, but in the meantime, good to have it!

Thanks again! Excited to see people interested in Phlexy UI 😄.
Looking forward to the additional tweaks you mentioned you had in mind.

Ahh, from this discussion seems like Phlex 2.0 is dasherizing attributes by default, so we'd have to change our specs to pass the attribute as a string, e.g. "my_id".

Also, Joel answered on bsky. For those components that had Phlex::DeferredRender I think we should use the simpler form:
def view_template(&)
  yield(self) if block_given?
  # ...

Instead of:
def before_template(&)
  vanish(&)
  super
end

Since in the former, it's clearer what's happening and you don't have to wonder what that vanish method is doing.
Nice digging from you to find out about using vanish though!

A hundred percent with you and I'll update the code today

Hi @davidalejandroaguilar, thanks for your work on this. I love the library and am happy that I could contribute something ❤

Awesome, thank you, everything looks good! :first_place_medal:
Appreciate you taking the time to contribute and also the kind words :pray::skin-tone-3:
Feel free to contribute again, there are plenty of components that’d be awesome to have. Otherwise, there are some components that need documentation, so you can always pick one of those if you want.
Thanks again!


Key Vault Secrets Samples  improvement

Issue Description:
Using a string like "<your-key-vault-url>" as a parameter to an Azure service is not convenient for automated test, detail Code Link

Suggestion:
Get the parameters of Azure Service from environment variables. For examples:

Update "<your-key-vault-url>" to CONFIGURATION.get("AZURE_KEYVAULT_URI")

@joshfree, @heaths, @pallavit and @vcolin7 for notification.

@vcolin7 PTAL

@hongli750210 why are the sample snippets being used in automated tests? At least for some languages, snippets are extracted from live tests that already run nightly. The values here are merely placeholders for users to replace. If we use real resource names, I fear it will confuse customers who just copy/paste the code.

@heaths I agree with your idea. We do this just to facilitate automated testing, we will not be making changes for these samples at this time. We will close this issue.

we will not be making changes for these samples at this time. We will close this issue.

Let's talk about this more offline. We already have a very robust, language-agnostic method of testing that might be good to incorporate into your plans. I'd be happy to walk you through it. /cc @weshaggard @maririos


support regenerate for chatbot

Description
Regenerate api for chatbot, memory_id and regenerate_interaction_id is needed
POST /_plugins/_ml/agents/<agent_id>/_execute

{
 "parameters": {
  "memory_id": "<memory_id>",
  "regenerate_interaction_id": "<regenerate_interaction_id>"
 }
}

{
 "inference_results": [
  {
   "output": [
    {
     "name": "memory_id",
     "result": "CjJIqowBPJb9bj-RF685"
    },
    {
     "name": "response",
     "result": "Thought: Let me check the index sizes"
    },
    {
     "name": "response",
     "result": "\nObservation: health\tstatus\tindex\tuuid\tpri\trep\tdocs.count\tdocs.deleted\tstore.size\tpri.store.size\nyellow\topen\t.plugins-ml-memory-message\tPpjdHagoTeu-6e0cV_XPMQ\t1\t1\t18\t0\t37.9kb\t37.9kb\ngreen\topen\t.plugins-ml-model-group\tG3WmQfOOQKu5wjFMNxZ5Ww\t1\t0\t1\t0\t5.6kb\t5.6kb\nyellow\topen\t.plugins-ml-memory-meta\tHM_eIsqbShaJrf3hhgPesw\t1\t1\t1\t1\t12.9kb\t12.9kb\ngreen\topen\t.plugins-ml-config\tPmv5mywfToGcy9J_EEq80w\t1\t0\t1\t0\t3.9kb\t3.9kb\ngreen\topen\t.plugins-ml-model\tuOxxq_g7SLuPoIV2gQCFRw\t1\t0\t1\t1\t32kb\t32kb\ngreen\topen\t.plugins-ml-agent\tNwRqlaDUQO-u5jY1grJsJQ\t1\t0\t2\t0\t26.5kb\t26.5kb\ngreen\topen\t.plugins-ml-task\tdY3Ie4YUTfuOY4639AE0Bg\t1\t0\t3\t2\t28.6kb\t28.6kb\ngreen\topen\t.plugins-ml-connector\tb9cc8YjOTjWg4lDijk9DtQ\t1\t0\t1\t0\t21.7kb\t21.7kb\n"
    },
    {
     "name": "response",
     "result": "Now I know the final answer"
    },
    {
     "name": "response",
     "result": "Based on the index information provided, the smallest index is .plugins-ml-memory-message, which has a store size of 37.9kb and primary store size of 37.9kb."
    },
    {
     "name": "QuestionSuggestor",
     "result": "[\"Could you please explain what each field in the index information represents like health, status, store size, etc?\",\"Are you able to check index sizes for other time periods like last hour or last day?\"]"
    }
   ]
  }
 ]
}

Issues Resolved
pick from #1709
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

create an issue https://github.com/opensearch-project/ml-commons/issues/1817 to fix coverage issue for org.opensearch.ml.model.MLModelCacheHelper, in this PR i have add it to exclude list


CTRL + Tab, + up or down arrow buttons, no longer work

Issue Type: Bug
I can use the CTRL + Tab feature, but can no longer use the up and down arrows to navigate the list of open files.
VS Code version: Code 1.44.1 (a9f8623ec050e5f0b44cc8ce8204a1455884749f, 2020-04-11T01:48:12.622Z)
OS version: Windows_NT x64 10.0.18363
Extensions (11)

Extension
Author (truncated)
Version

bracket-pair-colorizer-2
Coe
0.0.29

beautify
Hoo
1.5.0

Angular-BeastCode
Mik
8.1.2

vscode-typescript-tslint-plugin
ms-
1.2.3

team
ms-
1.161.0

debugger-for-chrome
msj
4.12.6

quicktype
qui
12.0.46

csharp2ts
raf
0.0.24

code-spell-checker
str
1.8.0

vscodeintellicode
Vis
1.2.6

json
Zai
1.0.4

Please update to 1.44.2 and test again.


Fix variable typo: Number to number

I fixed a typo in the variable name. The original variable name was 'Number,' which is incorrect, and I've changed it to the correct name 'number.'

thanks!


How to use in a Xamarin.ios project

How can I use the sqlcipher library in a shared project?
I'm not sure which references to add to my xamarin.ios project?
could you give me a heads up maybe, many thanks

Part of the answer to this question is to add SQLitePCLRaw.bundle_sqlcipher.
The rest of the answer depends on what sqlite wrapper you are using?  sqlite-net?  Microsoft.Data.Sqlite?


Fix some incorrect comments in  image

- What I did
Fix some incorrect comments in  image
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: yuexiao-wang<EMAIL_ADDRESS>

can you combine this PR with https://github.com/docker/docker/pull/29345 because it's in the same files? Combining them will save some time reviewing and running tests. I'll close this PR


Ignore some doc tests which "Broken MIR" ICE occurred

cc https://github.com/rust-lang-nursery/futures-rs/issues/1657

cc @cramertj @Nemo157 @seanmonstar
Could you review/merge this? (unblocking other PRs)


Ergonomic RollTo

Description of proposed changes:
Originally I thought I was going to need to implement roll_to for a tuple of Pallet<T>s. In the end, it has not been necessary yet. Nevertheless, I think this PR is a minor QoL improvement.
Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

#896

Codecov Report

Merging #925 (c85e7e3) into dev (dc257f1) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

:exclamation: Current head c85e7e3 differs from pull request most recent head af2c796. Consider uploading reports for the commit af2c796 to get more accurate results

@@            Coverage Diff             @@
##              dev     #925      +/-   ##
==========================================
- Coverage   78.28%   78.15%   -0.13%
==========================================
  Files          68       68
  Lines       10903    10896       -7
==========================================
- Hits         8535     8516      -19
- Misses       2368     2380      +12

Impacted Files
Coverage Δ

pallets/offchain-task-scheduler/src/ocw/nonce.rs
99.37% <100.00%> (ø)

pallets/offchain-task-scheduler/src/ocw/tests.rs
100.00% <100.00%> (ø)

primitives/src/vrf.rs
89.02% <100.00%> (-5.04%)
:arrow_down:

runtime/src/tests.rs
100.00% <100.00%> (ø)

test/runtime-utils/src/lib.rs
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[HW]

Name: George Emmanuel Thomas
Email<EMAIL_ADDRESS>Linkedin Profile: https://www.linkedin.com/in/george-emmanuel-thomas-518060202/
Attach the homework step I screenshots below:

Attach the homework step II screenshots below:

-- images removed by team --

Hey George Emmanuel Thomas, great job! Congrats!  Please delete your token from the Astra UI to ensure there are no security issues. Thank you. :)

Ok sir, thanks a lot :)


i cant open the module.exe file.

I cant do that and i have a question how do you create a dump file of halo 5?

Module.exe crashes on starting

It doesn't crash, you need to drag a module file onto it or else it will close immediately because it's a command-line program. I don't provide help with dumping the game, sorry, but if you look around you can probably figure something out.


Failed to fetch jwt public key

I've had this setup working once but now I can't reproduce it from a clean minikube. Authentication is not accepted. From istio-pilot logs with debug enabled I see:
2018-11-11T18:34:20.351443Z	error	model	Failed to fetch pubkey from "http://demo-keycloak-http.keycloak/auth/realms/demo/protocol/openid-connect/certs": Get http://demo-keycloak-http.keycloak/auth/realms/demo/protocol/openid-connect/certs: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
2018-11-11T18:34:20.351509Z	warn	Failed to fetch jwt public key from "http://demo-keycloak-http.keycloak/auth/realms/demo/protocol/openid-connect/certs"
2018-11-11T18:34:51.100239Z	error	model	Failed to fetch pubkey from "http://demo-keycloak-http.keycloak/auth/realms/demo/protocol/openid-connect/certs": unsuccessful response from "http://demo-keycloak-http.keycloak/auth/realms/demo/protocol/openid-connect/certs"
2018-11-11T18:34:51.100450Z	warn	Failed to fetch jwt public key from "http://demo-keycloak-http.keycloak/auth/realms/demo/protocol/openid-connect/certs"

However I can exec into the pod and curl the addresses shown.

I run this setup on GKE and it worked fine but I had to use a public IP for issuer and jwks fields.

11d0de3


chore(main): release 1.5.0

:robot: I have created a release beep boop
1.5.0 (2024-12-04)
🚀 Features

set rounding tolerance per scene (#143) (dd4448f)

🐛 Bugfixes

do not restore attributes when the state to restore is "off" (#145) (3567fd1)
force store entity state when turning on (#145) (3567fd1)
move imports source in config_flow.py (e7c8af8)
non-blocking file reading for scenes configuration (#141) (07e09d5)

🔨 Code Refactoring

scene file importing improvements (#144) (e1ee6d4)

🔧 Miscellaneous Chores

deps: bump astral-sh/setup-uv from 3 to 4 (#138) (8d152ad)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.5.0
:sunflower:


Random file locks renaming folders

Folders are randomly locked and cannot be renamed. This only happens periodically and seemingly at random. Sample test output of error shown below.
                          __
  ____  ____  ____  _____/ /
 / __ \/ __ \/ __ \/ ___/ /
/ /_/ / /_/ / /_/ (__  )_/
\____/\____/ .___/____(_)
          /_/
{ [Error: EPERM: operation not permitted, rename 'C:\Code\douglampe\codetender\test\output\test-replace\noReplace-folder\sub' -> 'C:\Code\douglampe\codetender\test\output\test-replace\noReplace-folder\folder']
  errno: -4048,
  code: 'EPERM',
  syscall: 'rename',
  path:
   'C:\\Code\\douglampe\\codetender\\test\\output\\test-replace\\noReplace-folder\\sub',
  dest:
   'C:\\Code\\douglampe\\codetender\\test\\output\\test-replace\\noReplace-folder\\folder' }

This is likely due to antivirus scanning so needs to be handled with retry. Should be able to just pass promise into retry function. Since file renames are now one at a time, should be able to just requeue the rename of a single file.


About performance of indexBuffer & drawElements.

recently , I try to create some examples about shader (just for studying), so I don't use PIXI.
I use a simple webgl wrapper igloojs at https://github.com/skeeto/igloojs
And I found a strange thing :
When I just render  thousands of sprite (use same texture , so they're batch) ---- no motion , no animation, no transform, no shader ,no filter ,no any effect, just "stand & still" , the igloojs is faster than pixi very much , very very very much , at least 3x.
Even I try to use  PIXI.glCore directly to render texture (similar to  http://dev.goodboydigital.com/client/goodboy/million/ , but no physics, no particles shader), the igloojs is still faster very much.

So I read the code , I found the biggest difference is that igloojs use drawArrays(TRIANGLES...) , and no indexBuffer , I have to set the 6 vert manually.
And I found use  drawArrays(gl.TRIANGLES...) is faster than gl.drawElements(gl.TRIANGLES...).

Is  indexBuffer & drawElements the hotspot of performance ?

I refactor http://dev.goodboydigital.com/client/goodboy/million/  , create a new version  with drawArrays http://fatidol.com/million-draw-arrays  .
You could find it's as fast as use glPoint.

wow! thats really cool @finscn 👍
Do you think its worth refactoring sprite renderer to use drawArrays?

var indices = new glCore.GLBuffer.createIndexBuffer(gl, indices);

Try this one:
var indices = glCore.GLBuffer.createIndexBuffer(gl, indices, gl.STATIC_DRAW);
``

Also I see that number of bunnies on those two examples is different. I dont know why, please find it.

I found when use drawElements , there is a limitation of sprites count in batch .  detail : https://github.com/pixijs/pixi.js/issues/91
But when use drawArrays , no this limitation.
So,  @GoodBoyDigital  , maybe we should consider  use drawArrays.

I think instancing will give more than that. Try instancing approach too.

Lets not add drawArrays before we research everything and take into account multi-texturing and instancing.

upd: we've concluded that limit is not on drawElements but because of fboSize.

@ivanpopelyshev  , the limit ( 16384 )  is not because of fboSize ,  the fboSize (int the code I give you) is  200 , the limit is 400000.  the 16384 is because of  #91  & indexBuffer(maybe)

that seems like a pretty big performance disparity, shouldn't drawArray and drawElements be very similar in speed, with elements being much faster w vertex reuse (uses less bandwidth)
drawArray = sizeof(vertex) * # of triangle * 3
drawElements = sizeof(vertex) * nb of vertex + sizeof(indice) * nb of triangles * 3
without vertex reuse drawArray doesn't have indexing overhead, so is faster

I'm getting 32k bunnies on finsc's links and both show the same FPS (2016 macbook, chrome)


Blender 3.0 breaks everything and really really quickly.

I had moved to 3.0 for my world creation stuff for vrchat and because the tools were way better for it. But i decided to go back to a project i had open on 2.9 and it worked that was a avatar model. Except for a small few errors. So re opened a new project and clicked fix model and it says there was a error and shut down my blender. Now i cant do anything with cats it just shuts down blender if i click any of its buttons.
And i would just revert to blender 2.9 but i do not have it anymore and Blender website will not allow me to down load it. I can only down load 3.0 from blenders site. So now i have a project that i spent so much time on that i can't touch as it will just close blender with a error.

This is what happens Dev or normal cats

Fixed in commit c01cfffbaf68104001324f09d5c5f758266e40ac

And merged 👍


gyp: update gyp.el to change case to cl-case

Checklist

[x] commit message follows [commit guidelines]

Description of change
‘case’ is an obsolete alias (as of 27.1); use ‘cl-case’ instead.

this file is managed by https://github.com/nodejs/gyp-next and vendored in here without modification so you'd best file this issue over there (although I'm not sure that file is actively used by anything)

this file is managed by https://github.com/nodejs/gyp-next and vendored in here without modification so you'd best file this issue over there (although I'm not sure that file is actively used by anything)


[CAMEL-15891]ByteArrayBodyGenerator for String body

The issue is due to a mistake done by async-http-client team.
Commit : https://github.com/AsyncHttpClient/async-http-client/commit/d47c56e7ee80b76a4cffd4770237239cfea0ffd6#diff-5247ce5d437efdde629533d6239bf0c24358bdf0157fa204050e908c48a8c1f3
They made the ByteArrayBodyGenerator constructor package level.
Due to this change, camel had to adapt and for String type of body, they changed their implementation from ByteArrayBodyGenerator to InputStreamBodyGenerator.
In InputStreamBodyGenerator, the content length is by default set to -1.
Since, content length was less than 0, NettyRequestFactory in async-http-client was using Transfer-Encoding header instead of Content-Length header.
Solution :
Async-http-client team corrected their mistake in the following commit :
https://github.com/AsyncHttpClient/async-http-client/commit/4469c30f7d54352865ff321b0de0148f9698c9b5#diff-208f8952b67ba2a28d2cb2d6881485f8fc1b2b5df53a841d4a4a48b2ed8aded0
However, the change was not reverted in camel, and hence, this regression has happened.
The change needs to be reverted in camel as well. This is causing regression when we are migrating from lower camel versions to higher versions.
The change to inputStreamBodyGenerator was introduced with the following commit.
https://github.com/apache/camel/commit/684ef5786838e051cece2f510d9dafabdc310d02#diff-4d41a9fe212a88af9bc5cddb7e348f8031f39ceaf2263d7275fc4b6dd09e0867

@davsclaus : will it be possible to add this change in 2.x versions as well?

Then you need to provide a PR against the camel-2.25.x branch

Thanks !
Created PR for camel-2.25.x and camel-2.24.x branch
https://github.com/apache/camel/pull/4680
https://github.com/apache/camel/pull/4679


Change appveyor log level to info

Purpose
Change appveyor log level to info

Codecov Report

Merging #15181 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15181   +/-   ##
=========================================
  Coverage     53.97%   53.97%
  Complexity     3103     3103
=========================================
  Files           320      320
  Lines         18046    18046
  Branches       3273     3273
=========================================
  Hits           9741     9741
  Misses         7050     7050
  Partials       1255     1255

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39edb4f...40acb48. Read the comment docs.


Workaround (temporarily) ScriptServer mutex issues

This is an intended workaround to some issues due to some underlying MinGW bug coupled with #84657. #85039 aims to address them for good, but so late in the release cycle we need a compromise solution.
Fixes #78734.
Fixes #85105.

Test build made with mingw-gcc of 4.2.rc1 + this PR applied:
https://downloads.tuxfamily.org/godotengine/testing/Godot_v4.2-rc1_mingw-mutex-fixup.exe.zip

Can't reproduce #78734, but I can't reproduce it anymore prior to any of the fixes, so I can't tell for sure.

Unfortunately, https://github.com/godotengine/godot/issues/85105 doesn't appear to be fixed. I can still trigger the crash exactly the same way, although I did get it to hang and then proceed successfully once. So, better? But ultimately, no, doesn't fix it.

In further testing, I'm also able to reproduce https://github.com/godotengine/godot/issues/78734 now. It's very consistent, although it doesn't always unravel the same way. Sometimes it loads just fine, sometimes it hicks up and crashes immediately, and sometimes it goes for many frames before giving up. Although sometimes it makes it through, very very slowly. Probably just a freakishly low chance, but sometimes dice roll in your favor 🙃
With this fix the behavior is consistent with what I've described in the previous comment. The crash is still there, but sometimes it hangs and tries to slowly process something. And the visual indication of the hang is exactly the same here as in https://github.com/godotengine/godot/issues/85105 with this PR. Every second or so there is a spinning indicator on the cursor which quickly disappears. So like it processes for half a second and waits, processes and waits.

The https://github.com/godotengine/godot/pull/85039 PR consistently resolves the issue again, the loading in https://github.com/godotengine/godot/issues/78734 happens as expected.

Superseded by #85039.


RC-1145 - fix version discrepancy

Checklist

[x] Up to date with main
[ ] All the tests are passing

[ ] Delete all resources created in tests

[x] Prettier
[x] Spectral Lint
[x] npm run bundle outputs nothing suspect
[x] npm run postman outputs nothing suspect

Changes
Aligns package version 1.19.34 with next release version 1.19.34

Closed as other PR will be bumped and can go in the release together


Deselect atoms does not work

Selecting an atom again does not de-select it; this is a bug from weas.

fixed in https://github.com/superstar54/weas/pull/2


Network giveup

Adds a counter to the loop and gives up if ping fails 30 times. I would have done time math, but the device may update its time/etc and I didn't want to depend on system time for this.

I think when it gets to the NEOS update check it will still hang forever if there is an update (and you don't have a network connection).  Maybe you need to make it a little smarter?

Ah I see your point. If this tree is updated, the reboot may trigger the neos check because /VERSION may require something higher than 4. Meh - this whole thing needs to be refactored, tbh.

Fixed in new version


F-Droid inclusion

As you might have missed notifications from GitLab: can you please check here? There's a minor mis-spelling that needs to be fixed before your app can be included. Would be a pity if that keeps it from being listed :wink:

Thanks a lot! Now we just need to get the build recipe ready (see "over there") and then a correponding merge request can be opened with the YAML.

Out of interest, why is this the only dalihaOS app on F-Droid?

Currently, Calculator is the most complete app in our lineup. The other issue limiting the availability of our apps on other platforms is that a ton of them are Linux platform specific, the only way to get them running would be to effectively rewrite them for Android using its APIs.


added no-legacy-stdTx  flag

Related issues:
Legacy endpoint /txs with stargate v0.44 keplr transaction fails with basic send-token
Signing transactions with Keplr error

@marinhoarthur does this PR fixes https://github.com/tendermint/vue/issues/128?

@fadeev yes


feat(papiv2): retract pipettes before shaking or opening latch

Closes #11210, closes #11209
Closes #RSS-39
Overview
Implements the PAPIv2 side of the above tickets.
Changelog

added _prepare_for_shake and _prepare_for_latch_open methods to HeaterShakerContext. They will execute a pipette retraction before shaking and latch opening respectively
added helper functions in HeaterShakerGeometry to check if pipettes are parked over restricted slots around the heater-shaker
Made necessary changes to clear current_well if appropriate after shake & open latch in protocol engine.  Added missing test cases

Review requests

Check that code and tests look good.
Make sure that I have accounted for all possible cases of possible pipette locations
Test it on a robot and see that pipettes retract under the right conditions

Risk assessment
Medium. Affects (intended to improve) pipette motion safety

We can solve (1) with something like what @mcous did for deck slot conflicts, moving both "directions" of the conflict-checking into the same place.
We might be able to solve (2) by making the conflict-checking code abstract enough that it can be shared between PAPIv2 and Protocol Engine.
If others agree, can we make a tech-debt ticket for this?

Definitely a tech-debt ticket is required.
I anticipate (2) would be much easier to implement than (1) because unlike deck conflict check, these restrictions rely on a combination deck state & module state + module command intention & pipette state + pipette move intention.

Tested this protocol and verified that pipettes retracted when over restricted slots and didn't when they were away:
def run(context):
	# Load Heater-shaker module
	hs_mod = context.load_module("heaterShakerModuleV1", "1")

	# Load adapter + labware on module. Available labware:
	hs_plate = hs_mod.load_labware("opentrons_96_flat_bottom_adapter_nest_wellplate_200ul_flat")

	p300_tiprack = [context.load_labware('opentrons_96_tiprack_300ul', 2)]
	p300 = context.load_instrument('p300_single', 'right', tip_racks=p300_tiprack)

	reservoir = context.load_labware('agilent_1_reservoir_290ml', 5)

	hs_mod.close_labware_latch()
	p300.pick_up_tip()

	hs_mod.open_labware_latch()    # Should retract pipettes before this

	p300.aspirate(10, reservoir['A1'])

	hs_mod.close_labware_latch()

	p300.dispense(10, hs_plate['A1'])

	hs_mod.set_and_wait_for_shake_speed(rpm=500)	# Should retract pipettes before this

	context.delay(minutes=1)
	p300.drop_tip()

	hs_mod.deactivate_shaker()
	hs_mod.open_labware_latch()    # Should NOT retract pipettes before this


Forgot Password

Need page to change password

Waiting for this feature to be implemented within the Java API (or .NET Api)


Cant get information - please check ADB connection

I am trying this with the new Google Chromecast with Android TV. Adb installed, home bridge authorized for adb
In the log i see only this:
[22/12/2020, 14:37:00] [HomebridgeADB] <IP_ADDRESS> - Connected
[22/12/2020, 14:37:00] [HomebridgeADB] --------------------------------------------------------------
[22/12/2020, 14:37:00] [HomebridgeADB] <IP_ADDRESS> - Can't get information from Chromecast
[22/12/2020, 14:37:00] [HomebridgeADB] <IP_ADDRESS> - Please check you ADB connection
[22/12/2020, 14:37:00] [HomebridgeADB] --------------------------------------------------------------
[22/12/2020, 14:37:05] [HomebridgeADB] <IP_ADDRESS> - Chromecast power is true
Any ideas?

Hey. Can you run this command manually from your computer?  And share the result.
My guess is the device is reachable but the adb command can’t be executed.
adb -s your-device-ip shell "getprop ro.product.manufacturer"
adb -s your-device-ip shell ”dumpsys power | grep mHoldingDisplay | cut -d = -f 2”

@dwaan I have tried what you suggested and here is the log of what happened.
pi@homebridge:~ $ adb -s <IP_ADDRESS>  shell "getprop ro.product.manufacturer"
Google
pi@homebridge:~ $ adb -s <IP_ADDRESS> shell ”dumpsys power | grep mHoldingDisplay | cut -d = -f 2”
cut: invalid field value '\342\200\235'
Try 'cut --help' for more information.
/system/bin/sh: ”dumpsys: inaccessible or not found
pi@homebridge:~ $ adb shell
sabrina:/ $ dumpsys power | grep mHoldingDisplay
mHoldingDisplaySuspendBlocker=true
sabrina:/ $ dumpsys power | grep mHoldingDisplay | cut -d = -f 2
true
For some reason dumpsys power is not accessible via adb, but is accessible with shell. I don't know if that helps

@dwaan I have tried what you suggested and here is the log of what happened.
pi@homebridge:~ $ adb -s <IP_ADDRESS> shell "getprop ro.product.manufacturer"
Google
pi@homebridge:~ $ adb -s <IP_ADDRESS> shell ”dumpsys power | grep mHoldingDisplay | cut -d = -f 2”
cut: invalid field value '\342\200\235'
Try 'cut --help' for more information.
/system/bin/sh: ”dumpsys: inaccessible or not found
pi@homebridge:~ $ adb shell
sabrina:/ $ dumpsys power | grep mHoldingDisplay
mHoldingDisplaySuspendBlocker=true
sabrina:/ $ dumpsys power | grep mHoldingDisplay | cut -d = -f 2
true
For some reason dumpsys power is not accessible via adb, but is accessible with shell. I don't know if that helps

Thank you. That’s help a lot. There was similar problem like your. Still looking out a way to fix it.

Do you mind to check if the new version fix this bugs?

Just installed. I can confirm it is working ok now with the new Chromecast with Google TV.
Thanks


User can collect data present in the website and store in an Excel file

My making use of web scraping. We can make a feature in which user can collect required data from a website and convert it into a CSV file. This can be achieved using Beautiful Soup and Pandas Library.
-- Contributor in GSSOC22 Sanya Gera
Please have a look at it @Umesh-01

@SanyaGera what kind of data you want to collect using Web Scraping??

@Umesh-01 suppose someone is reviewing property for rent on sites like nobrooker, so they can collect all that data and get it in an excel file.


Issue in demo example - Capital tool is not invoked

with reference to this example
https://github.com/langroid/langroid/blob/01832b823071191584aea6cccc9ebd06b11d3962/examples/chainlit/chat-tool.py#L47
I'm using google vertexAI and gemini pro model
llm_cfg = lm.OpenAIGPTConfig( # or OpenAIAssistant to use Assistant API
any model served via an OpenAI-compatible API
chat_model='litellm/gemini-1.5-pro', # or, e.g., "ollama/mistral"
)
os.environ['GOOGLE_CLOUD_PROJECT'] =
os.environ['VERTEXAI_PROJECT'] =
os.environ['VERTEXAI_LOCATION'] =
os.environ['PYTHONIOENCODING'] =
I'm getting the following error -
2024-09-23 00:19:23 - This event loop is already running
Traceback (most recent call last):
File "G:\projects\jerin\first-step\nenv\Lib\site-packages\chainlit\utils.py", line 44, in wrapper
return await user_function(**params_values)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "G:\projects\jerin\first-step\nenv\Lib\site-packages\chainlit\callbacks.py", line 118, in with_parent_id
await func(message)

before trying out a chainlit example, does a basic cli example work with your vertex-ai configs?

yes, it is working in cli

attached the code, the log statement 'good' is getting printed multiple times.

does this chainlit example work for you with a simpler LLM setup, e.g. OpenAI or ollama/... ?

after adding following snippet it worked.
import nest_asyncio
nest_asyncio.apply()

Also with recent update in chainlit, the output does not look good.

Note that in langroid we pin chainlit to a specific old version.
We haven't tested with their new updates, and I'm not surprised that recent versions are not good.


documentation with Documenter.jl

I updated the repository for generating documentation with Documenter.jl as we discussed.
I think the documentation has already been generated.
But the documentation has to be published as a GitHub page for it to be available online.

And only the owner has the capability to do it by following Configuring a publishing source for your GitHub Pages site and choosing Branch: gh-pages as  the source of the GitHub Pages site in CFMG repository settings GitHub Pages, so that GitHub would actually serve the contents as a website.
For testseml.jl, it is

I'll take care of this - now


Added support for flake-ctl firecracker pull

Added support for flake-ctl firecracker pull
Added the pull command for the firecracker engine to download and register remote firecracker images into a local storage location below /var/lib/firecracker/images.
This Fixes #83

For testing please try
sudo flake-ctl firecracker pull \
    --kis-image http://repos.ebgroup.elektrobit.com/nautilos:/2.0:/sdk:/devel/images/FireCracker-Box.x86_64-1.22.04-BuildFireCracker.tar.xz \
    --name ubuntu

or in the open
sudo flake-ctl firecracker pull \
    --kis-image https://download.opensuse.org/repositories/home:/marcus.schaefer:/delta_containers/images/firecracker-basesystem.x86_64.tar.xz \
    --name leap

Thanks


Add init.py for cifar example

The cifar example does not run on Python 2 without this PR.

Thanks. I added an __init__.py file when developing the example but then somehow forgot to check it in. LGTM.


Update custom json files

This pull request adds custom board.json files, custom device.json files and updates already existing device.json files to match with the board.json files as with the Mobiflight-CustomDevices reposority.

Wrong branch as basis


Sample: Developers can ask for help online

We need some forum where users can ask for help with this library. Are GH issues the right way? Stack overflow? Mailing list? All of the above? Something else?

I think creating GH issues is all that is needed, so marking this closed.


comment hide/moderate API (and comment list changes)

To support moderation on claims owned by a channel, a new API will be created to allow the channel owner to mark comment ids as moderated. These will be marked as such on the comment server. For the longer term blockchain solution, this would require the channel owner to create a transaction to hide them (can probably do these in batches). Their other option is to disable comments so they aren't shown in the GUI.
New:
comment hide/moderate (which one is better longer term?):
Param: comment ids (one or more, array)
Sends signature to comment server for validation
Updates:
comment list

[ ] should return how many moderated comments there are in its response. This will allow the app to show a warning / allow users to see the comments if they wanted.

[ ] do not return moderated comments by default

[ ] parameter to return moderated comments only / along with other comments (this would be good for threading/replies to show where the moderated comments are).

I'm not completely sure about this. As described, this would cause a bit of discrepancies in the API.
Naming the Function comment_moderate
Referring to the comments as being 'moderated' would imply that this is an official process in which LBRY Inc. or some other entity would be in charge of reviewing flagged content. Since the comments are just being marked as 'hidden' by the channel owner, this would be misleading.
Including the Moderated Comment Count In The Response
This would mean adding a new field moderated_count into the paginated response, and thus having a function that returns a field that isn't going to be there 100% of the time.
This also implies the default functionality is including non-moderated comments. What happens if I ask only for the moderated comments; would moderated_count disappear, or be set to 0?
It would also be weird for the API to have this field exist in this one specific function, but not for others. Thus creating an inconsistent API.
Removing Hidden Comments From comment_list by Default
Each comment being returned will have a boolean field is_hidden. If I did comment list "Eiffel Tower" I would expect to get a list of all the comments on the Eiffel Tower. I'm expecting this to represent all the comments being returned.
If I want to filter out the comments being hidden, I would do comment list --filter-hidden "Eiffel Tower".
Since the original list provides all the comments and their attributes, I can do the filtering myself. The flag just simplifies the process.
Proposed Changes
Create new comment_hide function
This function would be in charge of allowing the user to set comments as hidden on their claim. The function should take a claim_id and a list of comment_ids placed under the given claim_id
Add --filter_hidden flag to comment_list
This flag should do as the name implies, and filter hidden comments. It should be off by default.

For the comment_hide function, there should be a flag --unhide defaulted to false. This way, there is a clear understanding what's being done to all the comment_ids, so duplicate entries don't have their flag flipped.

comment hide is fine then

function that returns a field that isn't going to be there 100% of the time. - return it all the time with 0, or false.

This also implies the default functionality is including non-moderated comments. - no, it doesn't, it just tells the user running it there are some moderated ones so they know if they need to run with the hidden flag to see them.

What happens if I ask only for the moderated comments; would moderated_count disappear, or be set to 0? - it would return the same number, or true.

comment list --filter-hidden "Eiffel Tower". fine as long as the api returns whether or not they were filtered (see above). The app would use this by default.

Why do I need a claim id if I already know what comment I'm hiding - the server should figure out if this is allowed or not based on the claim id of the comment / if I'm the channel owner of that claim id. What if we allow a comments console where I may want to hide 10 comments across 5 claim ids?

There needs to be a way to return all moderated comments only, not along with others. This would be the case of a user wanting to see them anyway.

don't understand the whole unhide concept - once something is hidden, it can't be unhidden.  Comment hide already tells you it's hiding it.

@eukreign can comment on any other specifics.

If it works for the app team then I think this is fine. I expect we'll review the API in much greater detail when we decide to move to a blockchain solution.

To point 2; this is fine, but it shouldn't go with the rest of the paginated info.
E.g, you're asking for this:
{
  "items": [...],  # information about the raw content, appears everywhere in API
  "page_size": 10,
  "total_items": 1,
  "total_pages": 1
  "hidden_items": 0  # Information about a subset of the content, appears in this one function
}

comment list --filter-hidden "Eiffel Tower". fine as long as the api returns whether or not they were filtered (see above). The app would use this by default.

If the default functionality is to return all comments, then there's no need to specify whether or not a filter was applied to it in the output, this is already known by the original call.

Why do I need a claim id if I already know what comment I'm hiding - the server should figure out if this is allowed or not based on the claim id of the comment / if I'm the channel owner of that claim id. What if we allow a comments console where I may want to hide 10 comments across 5 claim ids?

Because the call to the server itself needs to be signed by the channel that owns the content. If the server gets a list of just random comment IDs, then it's unknown if they're on the same claim, or if the caller even owns the claim. This is information that is needed which the SDK can easily obtain before making the call to the server.

There needs to be a way to return all moderated comments only, not along with others. This would be the case of a user wanting to see them anyway.

Exactly, which is exactly how you would use filters. To get only the non-hidden functions you would do --filter-hidden=hide, and to get only the hidden you would do --filter-hidden=show.

don't understand the whole unhide concept - once something is hidden, it can't be unhidden. Comment hide already tells you it's hiding it.

What if you didn't mean to hide it and want to revert it?

That's exactly what we want, but it doesn't have to do a count...just return "has_hidden_comments" true/false

" then there's no need to specify whether or not a filter was applied to it in the output, this is already known by the original call." - goes with #1 - the app needs to know if there are ANY hidden comments from a single call.

I never said it shouldn't send the signed data for the comment ids...yes, of course, this needs to happen. It's up to the server to decide if it's a valid request because the server also knows if the channel requesting them has permission to do so based on the comment id alone. If passed a comment id that's not valid, disregard it. Passing claim id is not necessary, just like it's not for comment delete.

filter-hidden=hide/show don't make sense to me. Try to stick to one functionality to parameter, or don't use the term filter-hidden if it's going to actually show them.

let's not worry about unhiding for now.

For #3, the delete function is already having to make 2 requests to the server, the first being to figure out which channel the comment id is linked to. Doing it the proposed way would require having to do the same but with even more redundant information and queries that could just be fixed by providing the claim_id.

It seems like a good signature for comment_hide would be:
Usage:
     comment_hide  <comment_ids>...

Returns:
    (list) containing the comment_ids successfully hidden

closing since comments are outside sdk


interp2d is depreciated

We have to move away from interp2d, use one of ours instead

removed usage of interp2d


New control: Toast

Again, need this on almost every project.  If these are not in scope, just close it.
See reference: https://materializecss.com/toasts.html

Not going to implement. A simple wired-card would suffice


chore: removes unused code (v1) from the worker

Should also improve build times, as libgit2 and sqlite are no longer dependencies.
Closes mergestat/internal#164

@riyaz-ali FYI...

looks good! we can go ahead with this if we want to deprecate older syncs and move ahead with a container-only approach 👍

@riyaz-ali The main thing I see missing with this PR is a migration to drop the table that are no longer needed. Can you please add this.

Let's add that migration in another PR? I want to ensure that the changes made here in this PR are working before making any destructive / data-loss operation.


Properly handle non-ASCII chracters in containers.

When InternalClient returns a list of containers, it calls
json.load(), which returns unicode strings. We should attempt to
decode them before using in the ContainerCrawler container processing
code.

LGTM, I tested by removing the fix and the unit tests fail as expected.


enum validation

accidentally left tests commented out
add tests for enum validation
validate enum values

@joshuaslate once this goes into the services you should start seeing them work better with the status values. This will allow both short and long enum names to be acceptable, and will actually return an error if a value is used that doesn't match to a name.