Tests should be marked and reported as skipped if not applicable to the platform

We would really like to have our tests be reported as skipped if they are not applicable to a given platform.
Code which looks like this:
if ($IsWindows) {
$script:catalogPath = ""
Describe "Test suite for NewFileCatalogAndTestFileCatalogCmdlets" -Tags "CI" {
    #compare two hashtables
    function CompareHashTables
    {
        param
        (
          $hashTable1,
          $hashTable2
        )
        foreach ($key in $hashTable1.keys)
        {
        . . .

this means that these tests will only be reported on when run on a windows system. We won't be able to compare test counts across systems.
Steps to reproduce
inspect test/powershell/Modules\Microsoft.PowerShell.Security\FileCatalog.Tests.ps1
Expected behavior
Each test should be reported as skipped during a test run if it is not applicable to the system.
Actual behavior
Tests are not reported at all

Desire is to have the same number of tests run on any platform (although skipped tests are expected to be different) as this makes it easy to see that all tests were run.  We should fix this sooner so other people don't copy this as an acceptable pattern.

> $a=dir *.ps1 -Recurse | select-string -Pattern 'if.*\(.*\$IsWindows.*' -List
> $a

powershell\engine\ETS\CimAdapter.Tests.ps1:13:    if ( ! $IsWindows ) {
powershell\engine\Help\HelpSystem.Tests.ps1:112:        if ($IsWindows)
powershell\engine\Module\ModulePath.Tests.ps1:5:        if ($IsWindows)
powershell\engine\Remoting\SessionOption.Tests.ps1:2:    if ( ! $IsWindows ) {
powershell\Host\Base-Directory.Tests.ps1:12:            if ($IsWindows) {
powershell\Host\HostUtilities.Tests.ps1:59:        if ($IsWindows) {
powershell\Host\Read-Host.Tests.ps1:6:            if ($IsWindows) {
powershell\Language\Parser\RedirectionOperator.Tests.ps1:5:        if ( $IsWindows ) {
powershell\Language\Scripting\NativeExecution\NativeLinuxCommands.Tests.ps1:19:    It "Should not redirect standard
input if native command is the first command in pipeline (1)" -Skip:$IsWindows {
powershell\Modules\CimCmdlets\CimInstance.Tests.ps1:2:    if ( ! $IsWindows ) {
powershell\Modules\CimCmdlets\CimSession.Tests.ps1:2:    if ( ! $IsWindows ) {
powershell\Modules\CimCmdlets\Get-CimClass.Tests.ps1:3:    if ( ! $IsWindows ) {
powershell\Modules\Microsoft.PowerShell.Diagnostics\Get-WinEvent.Tests.ps1:3:        if ( ! $IsWindows )
powershell\Modules\Microsoft.Powershell.Host\Start-Transcript.Tests.ps1:59:        if ($isWindows) {
powershell\Modules\Microsoft.PowerShell.Management\Clear-EventLog.Tests.ps1:1:if ($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\FileSystem.Tests.ps1:171:            if ($IsWindows) {
powershell\Modules\Microsoft.PowerShell.Management\Get-ChildItem.Tests.ps1:57:        It "Should give .sys file if the
fullpath is specified with hidden and force parameter" -Skip:(!$IsWindows){
powershell\Modules\Microsoft.PowerShell.Management\Get-ComputerInfo.Tests.ps1:1127:    if ($IsWindows)
powershell\Modules\Microsoft.PowerShell.Management\Get-Content.Tests.ps1:110:    if ($IsWindows) {$expected =
"World3`r`nHello4,","World4`r`n"
powershell\Modules\Microsoft.PowerShell.Management\Get-EventLog.Tests.ps1:1:if ($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\Get-PSDrive.Tests.ps1:29:        if ($IsWindows)
powershell\Modules\Microsoft.PowerShell.Management\Get-Service.Tests.ps1:6:    if ( -not $IsWindows ) {
powershell\Modules\Microsoft.PowerShell.Management\New-EventLog.Tests.ps1:1:if ($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\Registry.Tests.ps1:7:        if ($IsWindows -eq $false) {
powershell\Modules\Microsoft.PowerShell.Management\Remove-EventLog.Tests.ps1:1:if ($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\Set-Location.Tests.ps1:4:    if ($IsWindows)
powershell\Modules\Microsoft.PowerShell.Management\Start-Process.Tests.ps1:6:    if ($IsWindows) {
powershell\Modules\Microsoft.PowerShell.Management\TimeZone.Tests.ps1:17:if ($IsWindows) {
powershell\Modules\Microsoft.PowerShell.Security\ExecutionPolicy.Tests.ps1:36:# tests only run if ($IsWindows -eq
$true)
powershell\Modules\Microsoft.PowerShell.Security\FileCatalog.Tests.ps1:6:if ($IsWindows) {
powershell\Modules\Microsoft.PowerShell.Security\SecureString.Tests.ps1:8:        if ( ! $IsWindows ) {
$PSdefaultParameterValues["it:pending"] = $true }
powershell\Modules\Microsoft.PowerShell.Utility\Environment-Variables.Tests.ps1:12:     if ($IsWindows)
powershell\Modules\Microsoft.PowerShell.Utility\Export-Alias.Tests.ps1:95:              if ( $IsWindows )
powershell\Modules\Microsoft.PowerShell.Utility\Invoke-Item.Tests.ps1:50:        if ($IsWindows) {
powershell\Modules\Microsoft.PowerShell.Utility\Write-Stream.Tests.ps1:92:           if ($IsWindows)

Found 35 files. Really need fix much less. I could do this.
And related question about skipping test guidance: why do we use global scope to restore defaults? $global:PSDefaultParameterValues = $originalDefaultParameterValues
Some tests use local scope.

I scanned the file list. Really need fix 9:
powershell\engine\Help\HelpSystem.Tests.ps1:112:        if ($IsWindows)
powershell\Modules\Microsoft.PowerShell.Management\Clear-EventLog.Tests.ps1:1:if ($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\Get-ComputerInfo.Tests.ps1:1127:    if ($IsWindows)
powershell\Modules\Microsoft.PowerShell.Management\Get-EventLog.Tests.ps1:1:if ($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\New-EventLog.Tests.ps1:1:if ($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\Registry.Tests.ps1:7:        if ($IsWindows -eq $false) {
powershell\Modules\Microsoft.PowerShell.Management\Remove-EventLog.Tests.ps1:1:if ($IsWindows -and !$IsCoreCLR) {
powershell\Modules\Microsoft.PowerShell.Management\TimeZone.Tests.ps1:17:if ($IsWindows) {
powershell\Modules\Microsoft.PowerShell.Security\FileCatalog.Tests.ps1:6:if ($IsWindows) {

Do we need to fix this?
powershell\Modules\Microsoft.PowerShell.Utility\Implicit.Remoting.Tests.ps1:39:            return

The reason I chose the global scope was to be sure that it got reset it back to it's original state. Pester creates quite a number of scopes, and I wanted to be sure that I reset the value as high in the scope chain as I could.
WRT: Implicit.Remoting.Tests.ps1 - this looks fine, the tests should report regardless of platform. the return after setting $skiptest is proper as the BeforeAll shouldn't continue to execute.
WRT: HelpSystem.Tests.ps1cd - the architecture of these tests is going to make this a bit tricky. Pester doesn't have a way to skip a test based on the contents of a testcase (although that would be a cool thing). This may need to be deconstructed into a foreach loop

@JamesWTruher Thanks for clarification!

I reset the value as high in the scope chain as I could.

It seems Pester's scopes are bit tricky. However, wouldn't it be more correct to restore the value in the same scope where the change was made?

Today we have 4609 Travis test and 4681 Appveyor test. So we "lost" 72 tests. Need a way to catch them.

yep. FWIW, even if the numbers are the same, it may be that different tests are running. We need more tooling to compare the test runs across platforms

Yes. It is more common so I open new Issue.


Scopes Validator

Some Tool, that will check all components, and their behaviours/views/systems etc, to ensure if they used only in those contexts in witch they're actually registered

second thought: maybe there may be mismatch between context-component only in boilerplate code :thinking:
which means, that #32 may fix this issue as well

Resolved by #49


Part of PDF document momentarily shows and jumps around

The PDF file from here is not properly displayed:
http://www.maptive.com/wp-content/uploads/Maptive-Information-Sheet.pdf
Parts of the document briefly shows and disappears. It seems that the rendering process jumps around the page, with black boxes shows briefly and disappears. Finally a blank page is shown, no matter which zooming percentage is set.
I am using the latest GIT checkout, and using make server to create the viewer. It is running under Nightly on Linux:
Mozilla/5.0 (X11; Linux x86_64; rv:13.0a1) Gecko/20120215 Firefox/13.0a1 ID:20120215031155

Can also confirm when it is running on Windows.
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120221 Firefox/13.0a1 ID:20120221031301


Allow attaching warnings/errors to types, and then only emit those if the type actually gets emitted

See https://github.com/Azure/k8s-infra/pull/134#discussion_r436416475
The basic problem is that sometimes when we want to log a warning about a type we don't actually know if that type is going to be emitted or not (it may be filtered later). Ideally we would only warn about types that were emitted.

This is done now


Update CLI to handle longer commit messages

This PR updates the command-line interface (CLI) for generating AI commit messages to handle longer messages when the --long or --verbose flag is set. And also set to generate short, concise messages by default, but now users can request more detailed descriptions of their changes. (#29)
Changes Made:

Added support for the --long and --verbose flags to generate longer commit
Updated the documentation to reflect the new functionality

I hope that helps! Let me know if you need any further assistance.

Not sure if an issue - but looks like you changed the indentation from tabs -> 2 spaces. Make the diff look a lot bigger than it actually is


Is it a good idea to add statistical sampling method in this crate like "pytorch"?

I am new to this crate, and I do appreciated that it so compact but useful like pytorch, but just one thing missing: the distribution feature, like this.
By the way, I am using https://github.com/LaurentMazare/tch-rs with another Ad-hoc distribution crate, And here, Do you think it preferred to add this kind of features directly in  neuronika ?  Personally, I prefer add this feature as an "addiitonal" feature for this project/crate, so that user can decided whether to use it or not by easy configuration  in toml.

Yes, we can add it as another member of the workspace in the new major release. I'm not a sampling expert and I'm currently working on GPU support so I may not focus on in for some time. Ideas & PRs welcome.


[PWA] Make use of the Window Controls Overlay feature to display menus in the title bar area

The Window Controls Overlay PWA feature is coming out of origin trial and is shipping with Chrome/Edge 98.
To learn more about it, here are a few resources:

https://alistapart.com/article/breaking-out-of-the-box/
https://developer.mozilla.org/en-US/docs/Web/API/Window_Controls_Overlay_API
https://docs.microsoft.com/en-us/microsoft-edge/progressive-web-apps-chromium/how-to/window-controls-overlay
https://web.dev/window-controls-overlay/

In short, it allows PWAs installed on desktop OSes to regain control of the area normally reserved for the standard title bar. With it, the maximize/minimize/close/pwa buttons appear as overlays on top of the web content, and the rest of the title bar is gone.
It comes with a JS API and some CSS variables that help PWA make efficient use of the regained space.
Using this, the VS Code PWA could display its title bar at the top of the window, just like in its native version.
The hamburger menu version of it could still be used when the title bar area is too narrow (which is easy to detect with the ongeometrychange event).

Pinging @digitarald who, I think, is looking at the PWA features right now.

Fyi @sbatten

Very much aligned with @sbatten's work of adding UI to the titlebar; and eventually optimizing that work for PWA.

Any new information about this? WCO support would be amazing!

Related: https://github.com/microsoft/vscode/issues/127449

I did a quick test. With only a little code change it already looks and works great. It really gives the feeling of native applications, if not seeing the two extra buttons at top-right added by the browser.
One remaining issue is that the title bar height is hardcoded now, it needs to be retrieved at runtime but I don't know how.

Wow nice 👏

One remaining issue is that the title bar height is hardcoded now, it needs to be retrieved at runtime but I don't know how.

You can use the new CSS environment variables for this. In particular env(titlebar-area-height). I wrote some docs about this here:  https://developer.mozilla.org/en-US/docs/Web/API/Window_Controls_Overlay_API#css_environment_variables
In fact, if you use these variables, you'll be able to position your menubar and other elements correctly across operating systems (including on Mac where the close/min/max buttons are on the left side).

It really gives the feeling of native applications, if ignoring the two extra buttons at top-right added by the browser.

Yeah, these buttons are annoying when you want to achieve a "native" look. There's work going on right now about this. @diekus will surely be interested in this feedback as I know he's thinking about ways to get rid of the "chevron" icon.

WCO also needs to be enabled in the browser. At least in edge, they are disabled by default.

It's coming very soon. Hope to have some news to share in some days! Once we have a timeframe, I am more than happy to help in any way to bring WCO to the the code PWA.

@yume-chan curious, what was the change you did in https://github.com/microsoft/vscode/issues/140694#issuecomment-1144427460 to make it work?

My branch is at https://github.com/yume-chan/vscode/tree/pwa-wco (it's not conflicting with main).

This is now enabled on https://insiders.vscode.dev. In Edge, make sure you enable the Desktop PWA Window Controls Overlay flag by visiting edge://flags/#enable-desktop-pwas-window-controls-overlay.

@sbatten Should this look a little bit better?

That's incredible news! Window Controls Overlay is now on by default in Chromium 105, so no flag needed! Congratulations @joaomoreno and team!

@joaomoreno, yep, I thought I resolved this but I will force the title bar on and move the compact menu when in PWA mode as mentioned here

Looking good:

This is great to see! Amazing progress.
Just one detail:
I unfortunately forgot to grab a screenshot before dismissing it, but there's a notification banner that appears at the top of the window when you first install the app (it contains link to download VSCode, read the terms, etc.). This banner can't be closed after opting-in to WCO. Its close button is likely hidden behind the control buttons overlay.
You might want to position it using the env(titlebar-area-*) variables.

Beautiful! small issue in mac but x100 better

@captainbrosset i have a fix going in today that should move the banner below the titlebar (like it is in desktop) when the WCO are shown.

Seems to not work on linux (fedora 36)

While this is generally done, macos web still has issues, so moving to December to resolve

Loving the work on this feature. I'm running into some issues on the latest Insider Preview
Running on Chrome/ChromeOS 107.0.5304.110
Screen recording 2022-12-01 12.21.24.webm

What happened to this issue? It looked close to shipping but never did?

It's live for me! On Chrome, look for an "up" Chevron near the window controls

I don't see anything:

This is on Windows 10 with Chrome 122.0.6261.95. Is it possible I've got something configured incorrectly?

Oh, I do see it in Edge on Windows 11. Must be a local configuration difference!

you have to zoom in to make it look even

@leifwalsh this is a very good catch, looks like we are missing to set "display_override": ["window-controls-overlay"] in that case. A fix will be pushed today and should be available in insiders tomorrow.

Awesome, thank you! Looking forward to the extra couple lines of editor space! :)

@leifwalsh with todays insider, this landed. Can you maybe verify?

yep, we see it, thank you!


Reporting a Vulnerability

To whom it may concern,
I am a student researching a security vulnerability and may have identified one in your application.
What is your prefered way of disclosing the vulnerability?
Cheers,
lbettels

Hi lbettels,
Thanks for sharing your finding of a potential vulnerability on our project
code.
We thank your insight and suggest a video conference with the other
contributors (Diogo, Francisco and Isaak), so that you can explain where
the attack vulnerability is, and best ways to fix it.
If you're not comfortable with a video conference, you can perhaps explain
the issue in text through email, using this communication channel, making
sure you copy all contributor emails added.
Al the best
Nuno
On Sat, 24 Aug 2024 at 13:22, lbettels @.***> wrote:

To whom it may concern,
I am a student researching a security vulnerability and may have
identified one in your application.
What is your prefered way of disclosing the vulnerability?
Cheers,
lbettels
—
Reply to this email directly, view it on GitHub
https://github.com/cenoteandoDB/cenoteando/issues/97, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS7TU4I4LCS7HMNKNQ2VDLDZTB3HJAVCNFSM6AAAAABNBRR47WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ4DINJVGAYDGNI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Nuno Simoes Ph.D.
UMDI-Sisal, Facultad de Ciencias, UNAM
Sisal, Yucatán, México
http://www.bdmy.org.mx http://www.bdmy.org.mx
piecemo.sisal.unam.mx http://piecemo.sisal.unam.mx/
http://www.cenoteando.com
http://www.sisal.unam.mx/

Hey mfanito,
I apologize for the delay, the last weeks have been really busy for me.
I will gladly send you an Email explaining the vulnerability, as a video conference does not suit me at the moment.
Also, I was only able to find Diogo's mail on his profile.
Is it fine with all of you if I send the Mail to him?
Cheers!
lbettels

Hi
Yes, please. Send the mail to Diogo.
All the best
Nuno
On Tue, 3 Sept 2024 at 13:45, lbettels @.***> wrote:

Hey mfanito,
I apologize for the delay, the last weeks have been really busy for me.
I will gladly send you an Email explaining the vulnerability, as a video
conference does not suit me at the moment.
Also, I was only able to find Diogo's mail on his profile.
Is it fine with all of you if I send the Mail to him?
Cheers!
lbettels
—
Reply to this email directly, view it on GitHub
https://github.com/cenoteandoDB/cenoteando/issues/97#issuecomment-2326434178,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS7TU4N22RX2JGG74LNCI5LZUWVQFAVCNFSM6AAAAABNBRR47WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRWGQZTIMJXHA
.
You are receiving this because you commented.Message ID:
@.***>

--
Nuno Simoes Ph.D.
UMDI-Sisal, Facultad de Ciencias, UNAM
Sisal, Yucatán, México
http://www.bdmy.org.mx http://www.bdmy.org.mx
piecemo.sisal.unam.mx http://piecemo.sisal.unam.mx/
http://www.cenoteando.com
http://www.sisal.unam.mx/

I just sent the Mail.
I hope the description is helpful, if any questions arise feel free to contact me.
Cheers,
lbettels


nearly all time out in windows 10

Hello, I am sure my proxy network is normal.
I used v2ray to open a proxy on port 33001 locally, but I cannot use TUN to access the Internet normally through your program.
I used this tool to open TUN before. Although it can work, the speed is very slow, and it even times out and reports errors most of the time.
My startup command is as follows：
tun2proxy --proxy socks5://<IP_ADDRESS>:33001

I'm very confused and have no idea what to do. Thank you very much for your help.

tun2proxy --proxy socks5://<IP_ADDRESS>:33001 --bypass your_remote_server_ip

Oh, thanks a lot. I skipped this because I'm running on Windows.
It now occasionally loads, but there are two new problems.
One is that it still frequently times out (but on the web page instead of the console)

The other is that the console is scrolling at a very high speed

so, use my proxy app https://github.com/ShadowsocksR-Live/overtls instead.

OK, thanks.
I'll do some more research, maybe there's something wrong with my configuration.

Great, it's working now! It turns out that I remembered the bypass ip wrong.
This is a really cool project, thanks, it deserves a star


Account

Phone is often empty
when it is selected in the left bar, show all the account. If a single Account is selected show only it in the details panel

Fixed, see commit e144370.


Not clear what is needed to export summarized data

Hi Team!
This sentence in "Limitations and considerations" is confusing for me:
"To export the data from a visual, you need to have Build permission for the underlying dataset."
because in this article: https://docs.microsoft.com/en-us/power-bi/connect-data/service-datasets-build-permissions
you write:
"Users also need Build permissions to work with the data outside Power BI:
To export the underlying data."
Also here: https://powerbi.microsoft.com/pl-pl/blog/change-to-summarized-data-export-behavior-with-build-permission/
"We are adjusting our approach based on your feedback.  Specifically, we will allow users with the Read permission to export summarized data from a visual.  This change will be rolling out over the next week."
So as I understand, you DO NOT NEED Build permission to "export the data from a visual".
You need it to export underlying data specifically. This is not needed to export summarized data.
Hopefully I got this right :)
Cheers,
Adam

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c87c556b-b1da-0b24-606b-89c371c6bae8
Version Independent ID: 20141574-acfa-f5f8-b6cf-6b32b3c55b4f
Content: Export data from a Power BI visualization - Power BI
Content Source: powerbi-docs/visuals/power-bi-visualization-export-data.md
Service: powerbi
Sub-service: pbi-visuals
GitHub Login: @mihart
Microsoft Alias: mihart

Hi, @Heniekwpracy -- yes, you've got that right! We can update the articles to be clearer that you only need Build permission to export the underlying data, and not the summarized data in the visual itself.

Hi @Heniekwpracy,
Yes, I believe you got it right and that this issue was resolved in the documentation.
Thanks,
Kesem


What's the performance of this method, how much time and computing resources does it require per inference?

Could you please provide details on the performance overhead, required computational resources, and the average time consumption for running the experiments described in your paper? Specifically, I am interested in:
The hardware configuration used (e.g., CPU, GPU, RAM).
The average runtime for each experiment.
Any significant performance bottlenecks encountered.
Thank you.

Thank you for your interest in our work. We used a vanilla NeRF MLP model, which needs longer training times compared to current advanced NeRF models but requires minimal hardware. The minimal GPU requirement is 1080ti. Our experiments were conducted using 2080ti. For the average runtime, ABC-NEF_Edge Dataset: ~3 hours per object, Replica and DTU Datasets: ~12 hours per scene.


DPG:  Handle Non-standard special headers for client-Request-Id and return-Client-request-Id

Based on the discussion:  Azure.Core has a policy to append return-client-resquest-id and client-request-id.
So Codegen will automatically add this policy to pipeline in client constructors and remove those two head parameters from method signature.

Needed for Batch


Display more assets to make default page occupied...

add ttoken smart contract of hte list of most important asset
https://docs.etherlink.com/building-on-etherlink/tokens


Update init.py

A hidden input form has been added to the challenge which means the library currently getting and adding this 's' value fixes the library and allows us to bypass challenge.

Tested, works just fine, nice job :+1:

Works, closes #198


Update s3, sdk-core, sqs to 2.17.34

Updates

software.amazon.awssdk:s3
software.amazon.awssdk:sdk-core
software.amazon.awssdk:sqs

from 2.17.33 to 2.17.34.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "software.amazon.awssdk" } ]

labels: library-update, semver-patch

Superseded by #287.


Making Reals erasable, and providing a reflection API for real literals

Our FStar.Real module did not make much sense, in that it supported decidable operations (like equality) over arbitrary reals, and a total of_string operation to make a real from a string (although this was uninterpreted logically, so not unsound, but it also did not have a runtime implementation).
This PR makes the real type erasable, and removes the of_string operation and the extraction rules for reals (which would never be triggered now).
It also adds them to the vconst view that Meta-F* exposes.

This will help in using literal real permissions in pulse, replacing half_perm (half_perm full_perm) by 0.25R, etc. In fact, just using coercions between reals and perms almost does the trick, except that it requires many more rewrites since Pulse will not unify real_to_perm 1.0 and full_perm (though it may soon, if we make it call the unifier).

Updated to put the comparison operations in prop instead of GTot bool. Conceptually, putting them in GTot bool would make use of the strong excluded middle axiom, which a user may want to avoid. Though with the current interface it does not really make a difference (one can only construct rational combinations of 1 and sqrt(2), so it could in fact be decidable).
But, with more ways to construct reals (if we do not restrict to a computable subset, which I expect we won't as we are using Z3's real theory), it may be that one can recover the strong excluded middle from these GTot bool operations. I have a hard time thinking how such a proof would go... but using prop feels like the right thing to do.
It does impact Pulse slightly, the following patch would be needed:
diff --git a/lib/pulse/core/PulseCore.FractionalPermission.fst b/lib/pulse/core/PulseCore.FractionalPermission.fst
index 5ec4d7e2..b5d61535 100644
--- a/lib/pulse/core/PulseCore.FractionalPermission.fst
+++ b/lib/pulse/core/PulseCore.FractionalPermission.fst
@@ -31,4 +31,4 @@ noeq type perm : Type0 =
 /// A reference is only safely writeable if we have full permission
-let writeable (p: perm) : GTot bool =
-  MkPerm?.v p = one
+let writeable (p: perm) : prop =
+  MkPerm?.v p == one

@@ -43,6 +43,6 @@ let sum_perm (p1 p2: perm) : Tot perm =
 /// Helper to compare two permissions
-let lesser_equal_perm (p1 p2:perm) : GTot bool =
+let lesser_equal_perm (p1 p2:perm) : prop =
   MkPerm?.v p1 <=.  MkPerm?.v p2

-let lesser_perm (p1 p2:perm) : GTot bool =
+let lesser_perm (p1 p2:perm) : prop =
   MkPerm?.v p1 <.  MkPerm?.v p2
diff --git a/lib/pulse/lib/Pulse.Lib.FractionalAnchoredPreorder.fst b/lib/pulse/lib/Pulse.Lib.FractionalAnchoredPreorder.fst
index 4b44db28..069d4332 100644
--- a/lib/pulse/lib/Pulse.Lib.FractionalAnchoredPreorder.fst
+++ b/lib/pulse/lib/Pulse.Lib.FractionalAnchoredPreorder.fst
@@ -137,6 +137,2 @@ type knowledge (#v:Type) (#p:preorder v) (anchors:anchor_rel p) =

-let b2p (b:bool)
-  : prop
-  = b == true
-
 /// Fractional permissions are composable when their sum <= 1.0
@@ -147,4 +143,4 @@ let perm_opt_composable (p0 p1:option perm)
     | Some p, None
-    | None, Some p -> b2p (p `lesser_equal_perm` full_perm)
-    | Some p0, Some p1 -> b2p (sum_perm p0 p1 `lesser_equal_perm` full_perm)
+    | None, Some p -> p `lesser_equal_perm` full_perm
+    | Some p0, Some p1 -> sum_perm p0 p1 `lesser_equal_perm` full_perm

diff --git a/lib/pulse/lib/Pulse.Lib.PCM.Fraction.fst b/lib/pulse/lib/Pulse.Lib.PCM.Fraction.fst
index f0a04952..83a4f271 100755
--- a/lib/pulse/lib/Pulse.Lib.PCM.Fraction.fst
+++ b/lib/pulse/lib/Pulse.Lib.PCM.Fraction.fst
@@ -45,3 +45,3 @@ let mk_frame_preserving_upd_none

-let perm_ok p : prop = (p.v <=. one == true)
+let perm_ok p : prop = p.v <=. one

diff --git a/share/pulse/examples/by-example/PulseTutorial.Ref.fst b/share/pulse/examples/by-example/PulseTutorial.Ref.fst
index 92593edb..45b082c1 100755
--- a/share/pulse/examples/by-example/PulseTutorial.Ref.fst
+++ b/share/pulse/examples/by-example/PulseTutorial.Ref.fst
@@ -207,3 +207,3 @@ ensures
 fn max_perm #a (r:ref a) #p anything
-requires pts_to r #p 'v ** pure (not (p `lesser_equal_perm` full_perm))
+requires pts_to r #p 'v ** pure (~(p `lesser_equal_perm` full_perm))
 returns _:squash False`

Seems not too bad... thoughts?

Downstream PRs:

https://github.com/FStarLang/steel/pull/170
https://github.com/FStarLang/pulse/pull/50

Will merge once we confirm Steel & friends are not badly broken by this


Would love to hear your feedback.

Weeell, my feedback is that no-gnu path is not worth it. It is a great academic exercise to implement and have fun with, but in real life I use GNU compilers exclusively anyway. I could potentially care about sdcc which is not GNU fully. I do not care about MSVC. So either way, the gnu path is what should be really cared about.
Your code seems to care about MSVC - great! I believe there will come wrappers for MSVC. The comments from gcc source code implementation of _builtin*_overflow helped me a lot in implementation available here: https://github.com/gcc-mirror/gcc/blob/16e2427f50c208dfe07d07f18009969502c25dc8/gcc/internal-fn.c#L724 .
I really like the idea of dynamic dispatch with a switch https://github.com/jart/jtckdint/blob/master/jtckdint.h#L435 . I see superb potential in it, as it will be optimized out anyway with very low optimizations settings. I never liked the _Generic(a, _Generic(b, _Generic(r approach - it takes too long and too much memory to compile, and nested ckd_add(ckd_add(1, 2), 3) generate millions of lines of code from the preprocessor. However, I do not like __ckd_uintmax_t and operations on it. I specifically wanted not to use intmax_t (or int128_t for that matter).
So that's my feedback. Nothing really with substance.

Thanks!

I made some changes in my fork to make it work with MSVC verifiably. I'm not sure I'm going to upstream it, because the test now uses a 22.4 MB corpus as reference instead of the GCC builtins. I also removed the C++ path, because I only need this for C for now and I wanted to only focus on that codepath.

How was the corpus generated?

 The license doesn't require you do this, but I'd encourage you to add yourself to the copyright header and mention the improvements and other changes you made. That way people will know what added value and tradeoffs your fork your fork has to offer compared to the original.

I don't feel that's necessary, becase I only made meaningful changes to the test and I removed the C++ path, as Boost is serving me well there and I only needed this for C.

How was the corpus generated?

By writing the result of the builtins after a successful check to a file when the C11 impl is used https://github.com/friendlyanon/jtckdint/commit/c257a77c08f35cdaed72ed1725c428d52dbbfd0e

To give you an example, I once took Intel's disassembler Xed and ravaged it down from being a gigantic enterprise codebase to just 700 lines of code. So I added stuff like this to let anyone know it's not the official Xed.
https://github.com/jart/blink/blob/222064a6c325248ccbe5f61f7359dd91ebc29bac/blink/x86.c#L37


Incorrect variable in setter

https://github.com/terjeio/ioSender/blob/614115d80c1f6c792112371e94f73741558cc407/CNC Controls/CNC Controls/OverrideControl.xaml.cs#L104
This setter for GrblEncoderMode EncoderMode sets the MinusOnlyProperty.
I don't know how it actually affects the application but it certainly confuses the VS XAML designer.  Lol!

Oops, a copy paste error. I am using VS2015 since I have a professional license - and it does not complain about it...
Will fix in next commit.


Support version

Hi,
The iOS version supported by most App is below iOS 12. Can you degrade the supported version of WXNavigationBar?

Maybe iOS 11 cloud be supported. I will
check it out.

Hi,
The iOS version supported by most App is below iOS 12. Can you degrade the supported version of WXNavigationBar?

iOS 11.0 is supported now.

Hi,
The iOS version supported by most App is below iOS 12. Can you degrade the supported version of WXNavigationBar?

iOS 11.0 is supported now.

Thanks,maye iOS 9 or iOS 10.What do you think?

WXNavigationBar now support iOS 9.0 + since version 2.0.0.
If there is any adaptation problem, feel free to open an issue. :D


Fix #1011

This fixes issue #1011, should be ready to merge.

Amazing @zbuttram, thanks for your time on this! I think you can switch it to just process.env.HOME || process.env.HOMEPATH 😄

Requested change is in now, still works and much clearer now. Thanks for catching that @matheuss, sometimes I get too ternary happy. ;)

Thank you @zbuttram 🙌

This should use require('os').homedir(), which is much more dependable than environment variables.


Elastic Effect (Enhancement)

http://codepen.io/suez/pen/emjwvP

Code it at your own
You can make a plugin

Cool effect i'll admit but it's complex to implement and isn't really part of the iOS or Material design patterns

Still, it is so sexy! I will just make a plugin if Vladmir (i think thats how you spell it) doesn't implement it @nolimits4web what do you think? Should i just make a plugin or will you implement it in?

Please write a plugin. He's really busy with developing his own features and doesn't hear to the issue and suggestions.

It is svg it is not really possible with the current Side Panels in framework7, although i might be able to find an elastic javascript effect?


document logging levels for Operator and Metrics Server

Document logging levels for Operator and Metrics Server and small minor info on local deployment operator-sdk cli.
Fixes https://github.com/kedacore/keda/issues/618

Thanks!


Feature: Full featured vanillajs example

I tried the vanilla-js example which works fine except there is no toolbar.
To bring lexical to .net platform and other platforms with ease, I suggest lexical would have a fully working vanillajs example so it could be migrated to any platform easily with a common api.

Hi!
Thanks for the input here. I think toolbar and all other components really depend on React for UI rendering, so while it's possible to do similar UI in vanilla JS - it may be quite suboptimal.
Can you pls elaborate on why you can't use React within .NET apps?
I think we can do potentially preact (smaller React), but you do need some library to handle DOM outside of Lexical conveniently.

Blazor has its own way to access dom and it is as big as react. Using both
libraries would make it overcomplicated and big.
A pure javascript lexicon would not only be beneficial for blazor lexicon
development but also be good for having an abstraction to build on all
languages
On Fri, 26 Apr 2024, 01:12 Vlad Fedosov, @.***> wrote:

Hi!
Thanks for the input here. I think toolbar and all other components really
depend on React for UI rendering, so while it's possible to do similar UI
in vanilla JS - it may be quite suboptimal.
Can you pls elaborate on why you can't use React within .NET apps?
I think we can do potentially preact https://preactjs.com/ (smaller
React), but you do need some library to handle DOM outside of Lexical
conveniently.
—
Reply to this email directly, view it on GitHub
https://github.com/facebook/lexical/issues/5964#issuecomment-2078257947,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACHVYK6HAP7IAUARLWHUUTY7F5ULAVCNFSM6AAAAABGZTCUWCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYGI2TOOJUG4
.
You are receiving this because you authored the thread.Message ID:
@.***>

Can you provide some example of Lexical/Blazor integration? W/o toolbar of course.
If it can be an interactive sandbox - would be awesome.

Also pls elaborate on how usage of preact here (3kb of code) would be worse then some custom written JS to manipulate DOM

Blazor integration does not seem possible without addin react over blazor. Blazor is not js, it is webassembly and it can call javascript functions from c# code. I dont know much about preact but I guess it also has its own dom access layer like react


Add este in 1 minute to the readme

I'm quite interested in feedback! The idea is to simply show how we to use Este, it doesn't aim to explain how it works (that will go in the wiki). It's really simple, but it can make a good entry point for people, and having people feeling comfortable when searching for a project is definitely a good thing!

Finally someone did it! Thank you :-)

Too bad this is no more relevant since Redux is used. But a new such starter is still in dire need.

Write it.

I know. I'll try my best.


Upgrade to EasyMock class extension 2.5

From<EMAIL_ADDRESS>on May 25, 2009 13:01:12
Update the EasyMock extension API to use EasyMock 2.5
Original issue: http://code.google.com/p/powermock/issues/detail?id=109

From<EMAIL_ADDRESS>on September 07, 2009 12:23:37
Summary: Upgrade to EasyMock class extension 2.5
Labels: -Milestone-Release1.3 Milestone-Release2.0

From<EMAIL_ADDRESS>on July 20, 2010 15:11:31
Upgraded to EasyMock 3
Status: WontFix


derive_where(Debug) compile error if there's a struct parameter named f

use std::marker::PhantomData;
use derive_where::derive_where;

#[derive_where(Debug)]
pub struct Problematic<T> {
    f: String,
    _marker: PhantomData<T>,
}

results in
error[E0308]: mismatched types
    --> src/lib.rs:5:1
     |
5    | #[derive_where(Debug)]
     | ^^^^^^^^^^^^^^^^^^^^^^
     | |
     | types differ in mutability
     | arguments to this function are incorrect
     |
     = note: expected mutable reference `&mut Formatter<'_>`
                        found reference `&String`

The reason is that the expanded macro is trying to use a symbol __f in two conflicting ways: once for the struct member f, and once for the second argument to Debug::fmt. cargo expand shows that the example above expands to:
impl<T> ::core::fmt::Debug for Problematic<T> {
    fn fmt(&self, __f: &mut ::core::fmt::Formatter<'_>) -> ::core::fmt::Result {
        match self {
            Problematic { f: ref __f, _marker: ref ___marker } => {
                let mut __builder = ::core::fmt::Formatter::debug_struct(
                    __f,
                    "Problematic",
                );
                ::core::fmt::DebugStruct::field(&mut __builder, "f", __f);
                ::core::fmt::DebugStruct::field(&mut __builder, "_marker", ___marker);
                ::core::fmt::DebugStruct::finish(&mut __builder)
            }
        }
    }
}

The first argument to debug_struct is our String, f, where it was meant to be the &mut Formatter.

This shoud be relatively quick to fix, by using too different prefixes or using something like __derive_more_formatter instead.
maybe this could also be circumvented by using different "sites".

@daxpedda this feels like a general problem with our approach, a field called builder would also break.  I think we need to either have a separate prefix for our internel variables, or not use destructuring.

Thanks for the quick fix!


No Feedback on Plugin Activation

The plugin seems to not provide us with user feedback like "Welcome to the JCasC Plugin".
Seems like the the onActivation function does not get called properly.

Can you let me know In which file the Activation function was coded?

https://github.com/jenkinsci/jcasc-vscode-extension/blob/master/src/extension.ts#L13

I would like to work on this issue , please assign it to me


DocService gRPC repeated fields are not collapsible

The childFieldInfos are not correctly populated in repeated fields, I think it would be useful to see child fields of the repeated fields instead of needing to click and visit another page.

@ikhoon regarding the table becoming too large, how about lazy loading child properties? Maybe not in the scope of this change. I haven't seen such big endpoints in my use-case yet.
Also assuming fields in map can be a little tricky because maps have two parameters. Maybe it is best to keep it this way. My motivation was using the debugForm without needing to navigate through lots of different pages. Beceause I suppose you loose your debug form template when you navigate to a different page.

My motivation was using the debugForm without needing to navigate through lots of different pages.

I agree with your opinion. But I heard @chris-ryan-square manages large protos.
https://line-armeria.slack.com/archives/C1NGPBUH2/p1665528225754379?thread_ts=1665526584.427749&cid=C1NGPBUH2
As you said, lazy loading could be a possible solution.

@ikhoon Is there a community slack channel for armeria? I thought link you sent was a community channel but I can't really get in 😆


chore: update README to reflect change to Datatonic

This PR updates the README to reflect the change in Sponsors from Montreal Analytics to Datatonic. The following changes were made:

The MTLA logo was deleted from images and replaced with the Datatonic (blue) logo
The Montreal Analytics description was repointed to the Datatonic.com homepage and the description revised.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fcfca2b) 98.45% compared to head (04013d5) 98.45%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   98.45%   98.45%
=======================================
  Files          47       47
  Lines        2330     2330
  Branches      309      309
=======================================
  Hits         2294     2294
  Misses         21       21
  Partials       15       15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feedback for "Subscribe to SAP Business Application Studio" - Details on required quota / entitlement

https://help.sap.com/products/SAP Business Application Studio/9d1db9835307451daa8c930fbd9ab264/6331319fd9ea4f0ea5331e21df329539.html?locale=en-US&version=Cloud
Doc says this "Note
If you don't see the SAP Business Application Studio tile in the results, check the entitlement configuration for your subaccount. See Configure Entitlements and Quotas for Subaccounts." and links to a general guide on what are entitlement and quotas, but there is no information what quota / or entitlement is required. Please add that information.

Thanks for your feedback! I agree that the information about which entitlement is required should be added.
I have updated the note to include information about the required entitlement and the change should appear with our next release.
Note: If you don't see the SAP Business Application Studio tile in the results, make sure that there's an entitlement for SAP Business Application Studio in your subaccount. See Configure Entitlements and Quotas for Subaccounts.


Render demo templates in repo branches

🐞 Problem
As discussed in private meetings, it would be very advantageous to have some rendered version for each template that this tool provides.
💡 Solution
The devised solution was to render each template in its own dedicated branch, so users and developers can have a quick reference on how the baked project structure looks like.

See workflow_run directive. This will be useful for making sure that the release process is only executed when all workflows succeeded.

Also, check download workflow artifact for downloading artifacts created by other workflows.


The function put_embed(changeset,:field, nil) does not work, is keeping the previous value

Environment

Elixir version (elixir -v):

Erlang/OTP 22 [erts-10.4] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [hipe]
Elixir 1.8.2 (compiled with Erlang/OTP 20)

Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.):

Postgres 10.4

Ecto version (mix deps):

ecto 3.1.7
ecto_sql 3.1.6

Database adapter and version (mix deps):

postgrex (Hex package) (mix)
locked at 0.15.0 (postgrex) dd534916

Operating system:

macOS High Sierra
Current behavior
When updating the ecto, this code snippet that worked, stopped working:
changeset
|> put_embed(:location, nil)
|> put_change(:location_accuracy, nil)
|> put_change(:location_info, nil)

the location field has an embed, and I want to set it to nil. It used to work normally, now it doesn't work anymore.
In this link I verified that there is a test for this case, but it seems that it only worked because the embed field was created with nil
https://github.com/elixir-ecto/ecto/commit/18c0373e0577eeed2f45a14648e2490073052221#diff-42554520b76127438f8d5d47052a0cb2L762
Expected behavior
When I make a put_embed setting nil, the value is really null, today is keeping the previous value.
It worked until version Ecto 3.1.5

Can you please try out the v3.1 branch? I can do a new release afterwards. Thanks!

I will test and give a return until monday.

Ok, please let me know and we can ship a fix.


Made compatible with new Autogluon version

Issue #2:
Autogluon now uses TabularDataset and TabularPredictor instead of TabularPrediction. I fixed a couple quick lines to make them compatible. This now works in my hands. Not totally ideal to have to pull a binary, so I can pull the .py file if you'd prefer.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@azdaly Make sure to also update autogluon-tab-with-test.py :)


ISPN-12823 JGroups retransmission requests are too frequent and overlap

https://issues.redhat.com/browse/ISPN-12823
Increase xmit_interval and reduce max_xmit_request_size

Would this affect the bundler results under load ?

@tristantarrant even under load, I don't think there should be many dropped messages that need to be retransmitted, unless there is a very long GC pause. In that case, the sender could send 4MB worth of messages (UFC.max_credits), which could mean 4000 messages of 1KB or maybe 40000 messages of 100B each.
To make the computation easier, I updated the PR to make both xmit_interval and max_xmit_request_size 200. In the extreme case of 40000 backlogged messages, it would take 200 XMIT requests to cover all of them, or 40 seconds, which I think is reasonable for a one-time event. For a more common scenario of only 4000 backlogged messages, it would take only 4 seconds to catch up.
I could make max_xmit_request_size a little higher, but I'm not sure, because it would cause an increase in duplicate retransmission requests if the destination is "alive" enough to request retransmission every xmit_interval, yet doesn't have the capacity to actually process the messages at the rate they are retransmitted.

Please rebase

Rebased

LGTM. Please add a note to the upgrading guide about these new defaults.

I added a note @tristantarrant.

Merged, thanks

run performance tests please

Hi @danberindei
we look only for PR that is opened

That's fine @diegolovison, you can ignore it.


Remove the problematic bunload! on BufWinLeave

See #51

I'm not using vim, so I can't comment with a test result.
Bute the analysis is thorough, and even if the fix is wrong, it is easily undone ;)
Thank you!


Simplify filterContentsByType

No need to call values(), since Arr::fetch already does that.

If it ain't broke...


Document HTTP Basic Auth in QuestDB OSS

From original @jerrinot PR:
This PR documents the new properties to enable HTTP Basic Auth in QuestDB Open Source.
Besides this, it also:

Document the new nm option introduced in https://github.com/questdb/questdb/pull/4639 - it's unrelated to security, but it's a tiny change so I squeezed it into this PR.
Potentially controversial: Removes the guide on configuring ILP@TCP - the thing with jose, jq and what not. We recommend ILP@HTTP for new users. Authentication in ILP@TCP in QuestDB OSS is convoluted. With the introduction of HTTP Basic Auth in QuestDB there is no good reason why anyone should use ILP@TCP.

I feel we are still missing a guide on "security hardening": Explaining how to secure QuestDB for production usage, the difference between OSS and EE, etc.
src: https://github.com/questdb/questdb.io/pull/2352/

@jerrinot Yes! Minor edits took place in transit. 💥


Login and signup modal: some text not showing, CSS improvement suggestion

Some text in the login and signup modal is not showing as it is in white color.
May I make it black color?
I suggest adding borders to the input boxes. I can work on that, too.
Would you assign it to me, please?

@younghyunlee22 yes please fix them.


Should we detect DimensionMismatch sooner?

For example, that A.shape == B.shape in A.ewise_add(B), or that A.ncols == B.nrows in A.mxm(B).
Now that delayed expressions are getting nicer reprs, it may be nice to detect these upon first creating the delayed expression.  Otherwise, it feels weird to look
The main downsides are a tiny performance hit and that our error message may be different from what people are used to from the underlying implementation.  A positive is that we'd have a consistent error message independent of implementation.

How wide-spread would the dimension checking be? Are we checking mask shape, output shape? What about indexes for assign and extract?
I'm not opposed to doing this, but we should decide just how complete we want the solution to be and whether that amount of checking becomes a performance hit.

I suspect there's enough overhead already that adding A.ncols == B.nrows check will be insignificant.  If overhead becomes a bigger concern, then I think Cython is a viable option.
My current thinking is that we should limit this to quick checks for things that are obviously bad when creating delayed expressions such as mxm.  It's jarring to be able to view a nice repr of an expression that's clearly invalid, since it seems to imply everything is okay when it obviously isn't.
I don't (yet) want to check whether op (and accum) are valid based on the relevant domains, because this isn't nearly as obvious (and, who knows, maybe some implementations will define special coercion rules).  I don't think we should check index values either (too slow).


runtime: missing stackmap when calling Go function from asm function

What version of Go are you using (go version)?

$ go version
tip

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/home/hostname/.cache/go-build"
GOENV="/home/hostname/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/hostname/gopath/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/hostname/gopath"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/hostname/go-master"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/hostname/go-master/pkg/tool/linux_arm64"
GCCGO="/usr/bin/gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build729455799=/tmp/go-build -gno-record-gcc-switches"

What did you do?
The test case is extracted from gvisor project.
There are three files for the following test case, since the files can't be uploaded on Github, I've posted them all on the page below.
https://play.golang.org/p/kGuVWkQnjwg
Run the test,
$ go test
What did you expect to see?
Test pass
What did you see instead?
runtime: frame asmCallGo/time.muldiv64 untyped locals 0x40027e0e80+0x38
fatal error: missing stackmap
I have also tested this case on linux/amd64 and the same error will occur. Note that the count value in the test is very large, this is set intentionally, and cannot be reproduced when the value is small.

runtime stack:
runtime.throw(0x146d6e, 0x10)
/home/erifan01/go-in-use/src/runtime/panic.go:1116 +0x54
runtime.getStackMap(0x4001321bb0, 0x4001321cd8, 0xfac00, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0)
/home/erifan01/go-in-use/src/runtime/stack.go:1239 +0x6d8
runtime.scanframeworker(0x4001321bb0, 0x4001321cd8, 0x40000eae98)
/home/erifan01/go-in-use/src/runtime/mgcmark.go:901 +0x54
runtime.scanstack.func1(0x4001321bb0, 0x0, 0x2366a0)
/home/erifan01/go-in-use/src/runtime/mgcmark.go:736 +0x38
runtime.gentraceback(0xffffffffffffffff, 0xffffffffffffffff, 0x0, 0x4006273980, 0x0, 0x0, 0x7fffffff, 0x4001321cc0, 0x0, 0x0, ...)
/home/erifan01/go-in-use/src/runtime/traceback.go:334 +0xd78
runtime.scanstack(0x4006273980, 0x40000eae98)
/home/erifan01/go-in-use/src/runtime/mgcmark.go:739 +0xf4
runtime.markroot.func1()
/home/erifan01/go-in-use/src/runtime/mgcmark.go:226 +0x9c
runtime.markroot(0x40000eae98, 0x271d)
/home/erifan01/go-in-use/src/runtime/mgcmark.go:199 +0x300
runtime.gcDrain(0x40000eae98, 0x3)
/home/erifan01/go-in-use/src/runtime/mgcmark.go:999 +0x10c
runtime.gcBgMarkWorker.func2()
/home/erifan01/go-in-use/src/runtime/mgc.go:1940 +0x70
runtime.systemstack(0x0)
/home/erifan01/go-in-use/src/runtime/asm_arm64.s:237 +0xa0
runtime.mstart()
/home/erifan01/go-in-use/src/runtime/proc.go:1041

cc @avagin

/cc @cherrymui @randall77 @ianlancetaylor

Thanks for the report.

Does this issue reproduce with the latest release? Yes

Do you know if this reproduces with Go 1.13 too?

TEXT ·muldiv64(SB),NOSPLIT,$40-33
//    GO_ARGS
FUNCDATA $0, ·muldiv64·args_stackmap(SB)

This function has a non-empty frame, so it needs stack maps. GO_ARGS only covers arguments. You still need a stack map for locals, for which the macro NO_LOCAL_POINTERS will do.
Also, please use the macro GO_ARGS instead of hand-written FUNCDATA.
See https://golang.org/doc/asm for more information.

@cherrymui Sorry for commenting a closed issue, just wondering if it's feasible to have 'go vet' check and issue warnings against such usage?

@shawn-xdji I think you can open an issue and let vet maintainers decide. Thanks.


Tupple item leading zeroes #470

What was wrong?
issue #470
Leading zeros in tuple indexes should not be allowed.
How was it fixed?
Check for leading zeros in tuple indexes (like item00 or item001). Small change in expressions.rs + tests.
To-Do

[ ] OPTIONAL: Update Spec if applicable

[ ] Add entry to the release notes (may forgo for trivial changes)

[ ] Clean up commit history

@andy-ow Looks great, thanks! Could you add a simple newsfragments/510.bugfix.md describing what was fixed? (Add a trailing newline on that file, or the lint check will reject it, btw)
There's also a minor conflict with the master branch now that I've merged #509. Would you mind rebasing?

@andy-ow I handled the chores I mentioned above; you weren't taking too long, I'd just like to get this PR merged in prior to #468, which would have caused a lot more merge conflicts


fixed bug in time units in pythom cmor utilities

classic Python cockup - @tomaslovato u may want to fix this in #942 as well and whoever propagated this into version2_development owes me a :beer:

You owe it to yourself then, according to git blame :smile:

gah good thing it's pub day today then :grin:


Content scale and performance data report for archiving team

Trello: https://trello.com/c/eOO9oPQD/787-content-scale-and-performance-data-for-archiving-team
In order to explore options for retaining all content on GOV.UK and
automatically down weighting low value, out of date and ephemeral
content, we would like to try and get an understanding of the scale and
spread of content with no views or minimal views
This change provides the following queries results:

Number of content items with no views (in the last 6 months)
Number of content items with less than 10 views
Number of content items with no views categorised by format
Number of content items with no views that have never been updated
(in the last 6 months)
Number of content items with no views categorised by department

It can be run from the console with rake report:content_items

@mgrassotti Thank you for your work on this PR.
I would prefer to track these queries in the Trello card so we can get back to hem if needed.  In case this information is requested at intervals of times, we will then prepare a way to automate them.


Proto-repl should allow you to do the opposite of cmd-opt-o

When you use cmd-opt-o to open something, proto-repl should allow you to close the file and go back to the calling function, or at least display a path you took to get there.

You can close the file and go back to the calling function using Atom's built-in cmd-w keyboard shortcut.

cmd-w closes the current tab. That will work if you opened a var in another namespace which opened a new file. If you opened a var in the same namespace cmd-w will just close the current tab and you won't see the code at which your were previously looking.

I think we could support this by keeping an internal stack of the current cursor location when cmd-opt-o is triggered successfully and popping the stack when you hit a keystroke to go back. This would be a pretty easy feature to add.

I use cursor-history when I just want to go back without closing the current tab.
Are you thinking of a "smart back" that would close or not the current tab depending on if it was opened through cmd-opt-o?


mistyping of a behaviors property caused output window to open and display error

I was just starting to type in this snipped of code
      _toggleListFull: function(e) {
        if (this.user.isManager) {

        }
      }

And was in this the body of the iff statement and trying to type when the following error was triggered
[Error - 09:43:36] Error: Expected to find at most one behavior with id PAS.User but found 2.
    at InlineDocument.getOnlyAtId (/home/alan/.vscode/extensions/polymer.polymer-ide-0.1.2/server/node_modules/polymer-analyzer/lib/model/document.js:156:19)
    at _getFlattenedAndResolvedBehaviors (/home/alan/.vscode/extensions/polymer.polymer-ide-0.1.2/server/node_modules/polymer-analyzer/lib/polymer/polymer-element.js:123:40)
    at getFlattenedAndResolvedBehaviors (/home/alan/.vscode/extensions/polymer.polymer-ide-0.1.2/server/node_modules/polymer-analyzer/lib/polymer/polymer-element.js:118:5)
    at resolveElement (/home/alan/.vscode/extensions/polymer.polymer-ide-0.1.2/server/node_modules/polymer-analyzer/lib/polymer/polymer-element.js:105:34)
    at ScannedPolymerElement.resolve (/home/alan/.vscode/extensions/polymer.polymer-ide-0.1.2/server/node_modules/polymer-analyzer/lib/polymer/polymer-element.js:67:16)
    at InlineDocument.resolve (/home/alan/.vscode/extensions/polymer.polymer-ide-0.1.2/server/node_modules/polymer-analyzer/lib/model/document.js:102:48)
    at ScannedInlineDocument.resolve (/home/alan/.vscode/extensions/polymer.polymer-ide-0.1.2/server/node_modules/polymer-analyzer/lib/model/inline-document.js:41:24)
    at Document.resolve (/home/alan/.vscode/extensions/polymer.polymer-ide-0.1.2/server/node_modules/polymer-analyzer/lib/model/document.js:102:48)
    at Analyzer._makeDocument (/home/alan/.vscode/extensions/polymer.polymer-ide-0.1.2/server/node_modules/polymer-analyzer/lib/analyzer.js:154:18)
    at Analyzer.<anonymous> (/home/alan/.vscode/extensions/polymer.polymer-ide-0.1.2/server/node_modules/polymer-analyzer/lib/analyzer.js:132:39)

PAS.User is a behavior that had been html imported once at the top of the file and included correctly as a behavior
      behaviors: [
        PAS.DateUtils,
        Polymer.NeonSharedElementAnimatableBehavior,
        Polymer.IronResizableBehavior,
        PAS.User
      ],

It provides a user object, but also provides amongst other things the property isManager;
The mistake I made here is that that if statement should have been
      _toggleListFull: function(e) {
        if (this.isManager) {

        }
      }

ie isManager is a property of this and not this.user
Once I had the error I report above, any typing in the iff statement or even having the mouse pass over the text -caused the output window to pop up.  I could only get stable enough to edit the code by shutting down vscode (which is what I am using) and starting it up again.

Re-opening because this original issue is now transferred and canonical again.


ppc64le bundle generation

I've tried it to see how far I could go, and it turns out snc almost works fine on ppc64le. Issues I had:

missing ppc64le build for quay.io/crcont/hostpath-csi-driver

I disabled the call to create_pvs to avoid the issue
when it's built in the same way as the other container images, this will be resolved

missing ppc64le build for gvisor-tap-vsock

I used https://quay.io/repository/teuf/gvisor-tap-vsock?tab=tags&tag=latest which has a ppc64le build

some minor issue with virsh shutdown, I had to run virsh destroy manually to be abe to move forward when createdisk.sh wants to shut down the VM

One important note, qemu-kvm is not available in rhel9. I ran this test on rhel8.

One important note, qemu-kvm is not available in rhel9. I ran this test on rhel8.

Is it deprecated or just not available as of now?

I don't think they have plans to add it, I'd consider it deprecated.


MINOR: Prevent creating partition.metadata until ID can be written

Currently the partition.metadata file is created when the log is created. However, clusters with older inter-broker protocols will never use this file. This PR moves the creation of the file to when we write to the file.
This PR also deletes the partition.metadata file on startup if the IBP version is lower than 2.8.
I will be looking at benchmarks to see how these changes affect LISR request processing.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Yes. I will want this on the 2.8 branch. I'll check the failed tests. I've also had trouble with building at least one of the three JDKs, but it seems like it is not the same one each time.

MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync() seems to be flaky (is failing on other open PRs)
ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() seems to be unrelated. I also ran locally and it passed.

@jolshan : Thanks. For those transient failures, could you file a jira if it's not tracked already?
Are the JDK 8 failures also transient?

I had 2 JDK 11 failures previously. I also noticed JDK failures on other PRs. I'll check JIRA for these issues

Looks like one was already created.
https://issues.apache.org/jira/browse/KAFKA-12284
https://issues.apache.org/jira/browse/KAFKA-12319

@jolshan : Thanks. Were the JDK 8 tests ok too?

@junrao On the previous commit JDK8 built and only MirrorConnectorsIntegrationSSLTest.testOneWayReplicationWithAutoOffsetSync() failed. (The only difference between this commit and the most recent was the javadoc change. Before that, all JDK8 tests passed.

@jolshan Could you rebase the PR for trunk? Also, I am not sure if the PR ports to 2.8 cleanly, if not, could you submit a separate PR for 2.8? Thanks.

@jolshan : Do you have any benchmark results that you want to share?

Sure. Using the LeaderAndIsrBenchmark (and the async profiler) LISRbench.zip
from https://github.com/apache/kafka/pull/10071 I had these results:
Benchmark                                                          (partitionCount)  (topicCount)  Mode  Cnt        Score       Error  Units
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       10            10  avgt   15    50920.020 ±  6450.121  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       10            20  avgt   15    81505.310 ±  3821.451  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       10           100  avgt   15   451907.331 ±  2157.775  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       20            10  avgt   15    75708.157 ±  4316.357  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       20            20  avgt   15   136747.799 ±  3886.797  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       20           100  avgt   15   980846.811 ±  4017.757  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       50            10  avgt   15   156896.027 ±  4952.014  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       50            20  avgt   15   318294.323 ±  4729.402  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       50           100  avgt   15  2904827.652 ± 74264.592  ns/op

I took a look at the flame graph for these tests and the file I/O impact seemed to be very minimal
This was trunk before the changes:
Benchmark                                                          (partitionCount)  (topicCount)  Mode  Cnt        Score        Error  Units
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       10            10  avgt   15    53887.240 ±   5645.067  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       10            20  avgt   15    83015.916 ±   3560.633  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       10           100  avgt   15   481109.947 ±  18767.713  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       20            10  avgt   15    75932.544 ±   6528.281  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       20            20  avgt   15   148323.073 ±   6009.839  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       20           100  avgt   15  1146604.372 ±  54073.673  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       50            10  avgt   15   171529.923 ±   9940.990  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       50            20  avgt   15   327926.279 ±   9292.803  ns/op
LeaderAndIsrRequestBenchmark.testHandleLeaderAndIsrRequest                       50           100  avgt   15  3512983.407 ± 570652.231  ns/op

@jolshan : It seems this PR can't be applied cleanly in 2.8. Could you submit a separate PR for 2.8? Thanks.

@junrao  https://github.com/apache/kafka/pull/10100


Let a user skip the root warning in bin/flutter - podman

There is a check for the file /.dockerenv to see if it is running in a container in order to suppress the warning, but in podman it is found in /run/.containerenv

https://github.com/flutter/flutter/issues/10529
https://github.com/flutter/flutter/pull/10535

extra
i put this in my entrypoint.sh and works fine!
if [[ -f /run/.containerenv ]] && ! [[ -f /.dockerenv ]]; then
   ln -s /run/.containerenv /.dockerenv
fi

The line that checks this can be found in
https://github.com/flutter/flutter/blob/2ed0df8405a2d5c7d369a4ccdaa002475e03b138/bin/internal/shared.sh#L213-L219
Labeling as a proposal

What exactly is the proposal? Also, it seems like an easier solution here in your entrypoint.sh would just be touch /.dockerenv.
Given this logic lives in bash land, I'm not sure we want to keep extending this logic to check for every possible config file or env variable. Should we instead update the warning to say its ok to run as root if you're on CI?

What exactly is the proposal? Also, it seems like an easier solution here in your entrypoint.sh would just be touch /.dockerenv.
Given this logic lives in bash land, I'm not sure we want to keep extending this logic to check for every possible config file or env variable. Should we instead update the warning to say its ok to run as root if you're on CI?

Using only touch may cause bad behavior, as it is a file created at runtime by the docker engine. My proposal as in PR #140380 is to silence podman and kubernets just as it already exists in docker.

Using only touch may cause bad behavior, as it is a file created at runtime by the docker engine.

Can you explain more what bad behavior touching the file may cause? Are you worried podman will do the wrong thing if it detects a /.dockerenv file, or the state of the container environment will be corrupted, or something else?

My proposal as in PR #140380 is to silence podman and kubernets just as it already exists in docker.

I understand your proposal. In https://github.com/flutter/flutter/issues/140330#issuecomment-1863250880, I describe my reservations that would have to be addressed before I approve a pull request.

@christopherfujino

Using only touch may cause bad behavior, as it is a file created at runtime by the docker engine.

Can you explain more what bad behavior touching the file may cause? Are you worried podman will do the wrong thing if it detects a /.dockerenv file, or the state of the container environment will be corrupted, or something else?

the file /.dockerenv must be created dynamically by docker engine in runtime that's container's environment vars, another programs mayable require the content of this file.
so putting a touch /.dockerenv may not be a solution.
but that's a matter for whoever is building the container image. That's show the ln -s /run/.containerenv /.dockerenv is  paleative solution to specifically serve my container image.

My proposal as in PR #140380 is to silence podman and kubernets just as it already exists in docker.

I understand what you're proposing, it's just not clear to me that that is the best change to make. In #140330 (comment), I describe my reservations that would have to be addressed before I approve a pull request.

I also don't think it's a good approach to just increase conditions, it works, but a different approach or defining a single environment variable for this would be better.

the file /.dockerenv must be created dynamically by docker engine in runtime that's container's environment vars, another programs mayable require the content of this file.
so putting a touch /.dockerenv may not be a solution.

I'm not sure exactly what you're saying here, but if you're worried that touch will affect the behavior of other applications if the file already exists, touch will not change the contents of a file that exists, only update it's last modified stamp.

some like flutter config --disable-warn-root songs great!

This would not work as this warning is printed from bash, before we even get to the dart code that controls the flutter config subsystem.

I'm sorry but I don't think we would implement this, even if someone put out a PR for it, due to the cost of maintaining more bash logic and the fact that this can easily be worked around with touch /.dockerenv in a Dockerfile.

I'm sorry but I don't think we would implement this, even if someone put out a PR for it, due to the cost of maintaining more bash logic and the fact that this can easily be worked around with touch /.dockerenv in a Dockerfile.

I have already solved my specific problem, the point is that using touch is a bad practice and paleative , as it will cause a duplication of truth sources. There may be another file with the real content of environments being ignored.
Maybe then instead of $CI, $BOT and $CONTINUOUS_INTEGRATION it could be a flutter-exclusive environment variable $FLUTTER_IGNORE_ROOT_WARN or similar, and give greater control to the user than maintaining bash
@christopherfujino @danagbemava-nc


Tv watched time count

Hi :v:,
One of the few things I still see as possible upgrades is the tv watched time.
As the comment on the actual code states, it is a "guesstimate".
After digging around trying to understand the codebase, I think the problem lies on the db not storing the runtime of each episode of every added show.
Because of that, in order to calculate the precise time count, watcharr would need to call the TMDB API for all of it, every time the user goes to /profile, which would be a terrible use of the API, as well as pretty slow.
I imagine not storing all of this information was a deliberate decision.
Are there any plans to improve the count?
I realize this isn't a priority, so I would try to implement a solution given here myself, but I do lack the expertise to do so :expressionless:.
Therefore, this issue serves only to appease my curiosity.

Hey @oPisiti, you are right. It mostly goes full guestimation mode because of a change with TMDB, they started to remove "usual" runtimes from shows when we request the show details (some shows still return usual runtimes I think, but most popular/new additions to the db won't).
The runtimes were moved to the individual episodes, so if we wanted to get a more accurate estimate we would probably have to get all episode runtimes manually then possible store a total_runtime in our db, then use that for the calculation.
Not sure if there's a nice way we could do that with tmdb, without needing a bunch of extra api requests. #62 seems loosely related, we'd probably need a recurring task that can update our cached version of the show to get new runtimes incase a show was updated.
Thanks for bringing this up, hopefully your curiosity is appeased!


Custom path for package

Let's say I have:
"extra": {
		"installer-paths":{
			"public/wp": ["wordpress/wordpress"]
		}
	},
"repositories": [
		{
			"type": "package",
			"package": {
				"name": "wordpress/wordpress",
				"version": "4.8.1",
				"dist": {
					"url": "https://github.com/WordPress/WordPress/archive/4.8.1.zip",
					"type": "zip"
				},
				"require":{
					"composer/installers": "~1.0"
				}
			}
		}
	]

But it doesn't install WordPress in public/wp or composer/installers and installer-paths don't work with type: package?
I thougt every package that requires composer/installers can be installed to defined location.

If you are consuming a package that uses the composer/installers you can override the install path with the following extra in your composer.json

Resolved by using any type on that package, for example:
"type": "wordpress-plugin"


Minor fixes to free memory in test code.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@cc0d6e1). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   74.23%
=========================================
  Files             ?        5
  Lines             ?      361
  Branches          ?       71
=========================================
  Hits              ?      268
  Misses            ?       52
  Partials          ?       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0d6e1...be276eb. Read the comment docs.


Considers list item marker part of the sentence

The algorithm considers -  part of the sentence: - Here's to the crazy ones. The misfits.
I am not sure you are willing to add this type of check as part of the library. From my biased point of view I think it's worth it.

Well, it is, if you’re dealing with natural language?
Looks like you have markup/markdown. Can you use remark?

Yes, we have a markdown editor. By using remark do you mean parsing the content and excluding markers from it?

Remark is like this project, but for markdown. So it understands all the markdown syntax. And it integrates with retext, which in turn uses this project, so you could also access this syntax tree!

That will work. Thanks! Feel free to close this if you decide is out of scope.

Yeah, I think that’s what I’m going with. I feel it’s syntax, and that that’s something for other projects.
Good luck!


Something's off. Most of the links on the website lead to: Apologies, but this page hasn't been created yet.

I just discovered https://hotwire.io/ and tried to click around to see what's it all about. But most of the pages take me to:

Apologies, but this page hasn't been created yet.

For example: https://hotwire.io/documentation
5 out of 8 links on that page lead to 404.
I've seen similar just clicking around the rest of the website links such as footer links.

Hey @vfonic, most of the pages aren't created yet, as the page suggests. It's a lot of effort to write and coordinate documentation. The idea is that this website is sort of seen as a Wiki, so the community can write documentation and best practices together. If you have some ideas or want to write the content for some of these pages it'd be more than welcome!

Ah got it! It's a work-in-progress. I assumed that something with the link generation was broken.


Spectators support.

At the moment, spectators are supported on server side, but not on client side.


[FIX] sap.ui.test.actions.Action: Use target element's offset for MouseEvent

jQuery's offset function returns a map with "left" and "top", UI5 expected "x" and "y".

Fixes https://github.com/SAP/openui5/issues/1671

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This pull request is related to GitHub Issue https://github.com/SAP/openui5/issues/1671 and internal ticket #1770346464.
Further updates will be posted in the GitHub issue.

Hello Johann,
Thank you for finding and fixing this bug!
Could you please also add a unit test for the mouse event offsets?

Hi Tsvetelina,
honestly, I believe that it'd be better if your team provided a unit test.

Hi Johann,
After testing this pull request we concluded that the MouseEvent coordinates logic is not entirely correct. Currently we don't need to set the MouseEvent client, screen or page coordinates and we rely solely on specifying the DOM ref. Setting them even causes issues with controls that are insensitive on paddings and borders (e.g. RatingIndicator) We will remove this unneeded code for now and think of a more general approach to event coordinates in the future.
Thank you for helping us find this issue!
Regards,
Tsvetelina


Generated dart code for JSON wire format is too proprietary!

I hope this does not fall on deaf ears. Thanks for working on Dart support for protobufs!
When using JSON as the wire-format, why does the generated Dart code use so much protobuf specific code like GeneratedMessage,  PbList, ExtensionRegistry, etc? JSON deserialization is already part of the Dart standard library, doesn't it seem kinda unnecessary to generate so much non standard code?
I understand JSON is probably not the focus of this protobuf library, but there are good use cases! For example, trying to remove the protobuf runtime dependency in Flutter Blue Plus. See: https://github.com/boskokg/flutter_blue_plus/issues/236
It would be awesome if this was improved.
syntax = "proto3";
message User {
  int64 id = 1;
  string name = 2;
  string email = 3;
}

// Generated by the protocol buffer compiler. DO NOT EDIT!
// source: user.proto

import 'dart:core' show int, bool, double, String, List, override;
import 'package:protobuf/protobuf.dart';

class User extends GeneratedMessage {
  static final BuilderInfo _i = BuilderInfo('User')
    ..aInt64(1, 'id')
    ..aOS(2, 'name')
    ..aOS(3, 'email')
    ..hasRequiredFields = false;

  User() : super();
  User.fromBuffer(List<int> i,
      [ExtensionRegistry r = ExtensionRegistry.EMPTY])
      : super.fromBuffer(i, r);
  User.fromJson(String i, [ExtensionRegistry r = ExtensionRegistry.EMPTY])
      : super.fromJson(i, r);
  User clone() => User()..mergeFromMessage(this);
  BuilderInfo get info_ => _i;
  static User create() => User();
  static PbList<User> createRepeated() => PbList<User>();
  static User getDefault() {
    if (_defaultInstance == null) _defaultInstance = User._();
    return _defaultInstance;
  }

  static User _defaultInstance;
  static void $checkItem(User v) {
    if (v is! User) checkItemFailed(v, 'User');
  }

  int get id => $_getI64(0);
  set id(int v) {
    $_setInt64(0, v);
  }

  bool hasId() => $_has(0);
  void clearId() => clearField(1);

  String get name => $_getS(1, '');
  set name(String v) {
    $_setString(1, v);
  }

  bool hasName() => $_has(1);
  void clearName() => clearField(2);

  String get email => $_getS(2, '');
  set email(String v) {
    $_setString(2, v);
  }

  bool hasEmail() => $_has(2);
  void clearEmail() => clearField(3);
}

Reading your links, it seems like this is about getting rid of the runtime dependency to the protobuf library and not about JSON wire format, right?
Generated class for a message is not wire-format specific, it support the binary wire format, a custom JSON format, and the proto3 JSON format. Without a runtime dependency parsers for each of these formats would have to be generated, which would certianly be too much duplicate code generated when you have more than a few messages. Also, every message supports unknown fields and extensions, so the data structures for those are also shared with a shared runtime dependency. PbList and PbMap types are needed to allow freezing messages, which are also shared.
So generating stand-alone code with no deps other than the SDK would not be possible for this particular protobuf library.

The parser imo should just be the json parser, that already ships with dart.
And then a small class per message to read the parsed json and validate.
Handling unknown fields seems pretty simple, just provide access to the parsed json returned from dart:convert.


Add Python/MicroPython dict output format

Format expected:
pinout = { 'pin_name' = pin_number, ... }

Done in https://github.com/CGrassin/kicad-pinout-generator/commit/93539d6f3f9ca889a7a9bbc74e58360083d81059


tinyws for commonJS

is there a way to use tinyws in commonJS. I got some legacy code.

I guess transpiling node_modules is a way

You suggest to modify my code :-).

I try to investage hybryd npm packahe looking at https://www.sensedeep.com/blog/posts/2021/how-to-create-single-source-npm-module.html. But not enough skills on my side

@franckOL that's a different topic. the article is about module creators. you're a module user
so there are two ways:

running code through cjstoesm
doing some magic to transpile node_modules

@talentlessguy Is there any particular reason not to provide both CJS and ESM versions in your published module, to ease adoption?

@fwouts providing both versions adds maintenance burden, increases chance to get CJS-specific bugs and also CJS is not a JavaScript standard


Inventory Items as Entities

Describe the problem related to your feature request.
The current inventory API has a couple problems (among others):

Using ItemStack directly is not very pleasant. It's fine when the type and count of items need to be accessed, but working with enchantments, lore, and other metadata requires interfacing with the loosely-typed NBT compound.
It's difficult to associate custom data with items because Option<ItemStack> is not open for extension. The data must be stored outside the inventory. This is important for UI elements and other things with unique behaviors.

What solution would you like?
Make every item an entity in the ECS. We could have the following components on items, with some being optional:

InventoryRef(Entity)
A pointer back to the inventory this item is a part of. Needed so that update systems know what inventory to mark changes in.
Slot(u16)
The slot index of the item. Needed so that update systems know what slot to mark as modified (we could replace this with a linear search for this item's Entity in the inventory?).
Count(u8)
ItemKind
Nbt(Compound)
Typically modified indirectly through Damage, Enchantment, Lore, etc. but also left exposed as an escape hatch. (TODO: store this in binary form for faster transmission?)
Damage
Enchantment
Lore

Then, the Inventory slot array would be a Box<[Option<Entity>]>. We rely on change detection in the components to send changes to clients.
Challenges

How do we ensure that invariants are not broken accidentally when moving and deleting items? Bevy currently lacks "archetype invariants" and "relations" so this is very difficult to enforce.
One possibility is to require all slot changes to be made through Commands. This way, changes are performed atomically when the system buffers are applied. Another option is to require use of a helper type containing the inventory and query of items.

What alternative(s) have you considered?
We could keep things as they are and work to make ItemStack more convenient by adding various helper methods.
But continuing the trend of making everything an entity (like chunks and block entities) would be more consistent.
Additional context
Part of #257. May also help with #307.

How do we make sure users can't create >1 item stacks for the same slot?

Closing for the reasons mentioned in #257.


Bluetooth

@valnoxy sorry for disturbing you again but, bluetooth keeps on crashing. In sys pref I get the notification saying: Could not load bluetooth preference pane and bluetooth doesn't work off the menu bar either. its probably a bug but can you try to get it fixed? Thanks :D

lol...

I use airportlwm, and it work fine.


Error with Data size larger than 1M, will not write to zk. Data (first 1k)

This is not critical but shows some problems worth investigating.
Our QA cluster is having trouble with some accumulated data. It has 10k+ real time segments in place, data are not too much.
In logs we see something like below:
2021/11/04 20:31:34.166 ERROR [ZkClient] [HelixTaskExecutor-message_handle_thread] Data size larger than 1M, will not write to zk. Data (first 1k): {
  "id" : "point_entry_REALTIME",
  "simpleFields" : {
    "BATCH_MESSAGE_MODE" : "false",
    "BUCKET_SIZE" : "0",
    "SESSION_ID" : "30069443a0581e1",
    "STATE_MODEL_DEF" : "SegmentOnlineOfflineStateModel",
    "STATE_MODEL_FACTORY_NAME" : "DEFAULT"
  },
  "mapFields" : {
    "point_entry__0__0__20211030T0056Z" : {
      "CURRENT_STATE" : "OFFLINE"
    },
    "point_entry__0__100__20211102T0746Z" : {
      "CURRENT_STATE" : "OFFLINE"
    },
    "point_entry__0__101__20211102T0817Z" : {
      "CURRENT_STATE" : "OFFLINE"
    },
    "point_entry__0__102__20211102T0909Z" : {
      "CURRENT_STATE" : "OFFLINE"
    },
    "point_entry__0__103__20211102T0946Z" : {
      "CURRENT_STATE" : "ONLINE",
      "END_TIME" : "1636056441791",
      "INFO

In the current version of helix that we use in Pinot, data over 1M is automatically compressed by Helix before writing to the zookeeper. I think your compressed data is exceeding this limit (helix provides only one limit in 0.9.x, we have requested to have two limits and they will provide it in 1.x)
https://github.com/apache/helix/blob/master/zookeeper-api/src/main/java/org/apache/helix/zookeeper/datamodel/ZNRecord.java#L63:27
The best way is to remove some segments or set your segment size to be larger so that less number of segments are made.

I just realized that it is probably because I have 192 partitions and "replication": "2" setting, while I have only 4 hosts to process them. I believe the real time servers is trying to go online for all the 192*2/4 segments at the same time (in one message) which generates a very large JSON file that exceeds the 1MB size.
Right now if I add more hosts it should solve the problem for me.


JSON format support for container logs

What is the problem you're trying to solve
Currently containerd uses supports text format for logs.
For example for /var/log/containers/coredns-*, the text log output would typically be in the format:
2020-01-10T18:10:40.01576219Z stdout F [INFO] plugin/reload: Running configuration MD5 = 4665410bf21c8b272fcfd562c482cb82
Describe the solution you'd like
I'd like the ability to configure containerd to write container logs using JSON format instead.
Re-using the example above of /var/log/containers/coredns-*, the JSON log format would be:
{"log":"[INFO] plugin/reload: Running configuration MD5 = 4665410bf21c8b272fcfd562c482cb82\n","stream":"stdout","time":"2020-01-10T17:22:50.838559221Z"}
Ideally, I'd like to use the configuration file at /etc/containerd/config.toml to switch between Text and JSON format for logs.
Additional context
This is for easy parsing by 3PP tools such as Elasticsearch and Splunk.

Hello,
With an adapter pattern you can achive this :
Using Regular Expression Parser of fluentbit for example your can  convert your text logs on structured format that can be Consumed by ES very easy.
In most cases, the log processing is the responsability of sidecars dependency which will process logs on specific  format like JSON


[S] Update ORCS Number of Park

This ticket is to resolve the data issue identified through connecting A&R to the data register.
Change 3883 ORC in A&R to 0281 for any park with 3883, remove 3883 as that is not a park.
This will enable updating A&R from the data register for the new name and it should read Tsutswecw Park instead of Roderick Haig-Brown Park for all years in A&R (can validate this by checking standard export report).
Acceptance Criteria:

3883 number is replaced with 0281 for Tsutswecw park in A&R
No data is affected other than ORC number is updated and Park Name can now be updated via data register

@JLWade @Christopher-walsh22 For clarification here: Do we need to preserve all of the records in the database that are within ORCS 3883, ie, a record for 3883 becomes a record for 0281? If so, that would necessitate a migration which will be a little more complicated than just creating a new park.
The other option is to leave 3883 as is and create a new park for 0281 (and all of its child subareas) which will capture all new records. All existing subareas will be locked against further editing. If I remember correctly, this is what we have done in the past when this occurs, though I cannot remember fully right now.

@cameronpettit this one is tricky - all records under 3883 need ot be moved to 0281. Is there a way to just change the orc number in the database?
All subareas need to follow suit as well. We had this park under the wrong ORC (data register revealed this issue) so will need ot basically move everything to the correct number.
Does that help?

@JLWade possible but not easily done. @Christopher-walsh22 you will need to write a migration that does the following

collect all parks, subareas, activity records, config objects and variances associated with ORCS 3883
duplicate all the records collected in step 1 with the correct ORCS 0281, then reinsert them into the database
delete all of the records collected in step 1 from the database
Update all permissions related to 3883 in Keycloak to use 0281
Verify that variance tracking still works properly

thanks Cam!

Leave accents in the park name - they did not translate via email well to this ticket

During code review @marklise noticed that in the data register park 0281 is named 'Tsútswecw' instead of  'Tsutswecw'. I have confirmed with @JLWade  that is the proper spelling for park 0281.

Tested on TEST: Passed

Verified that the ORCS number has been corrected on Dunamodb and it reflects on the A&R test admin site
Verified that the name be updated without errors from the TEST data register.
Pending deployment to PROD.
@JLWade  I will assign this to you for PO review, after approval I will deploy to PROD.

Thanks @manuji  - looks good - lets deploy this change to prod.
Might be a migration to run to get all past ORCs for this park to update too - @Christopher-walsh22?
following cams instructions above:
collect all parks, subareas, activity records, config objects and variances associated with ORCS 3883
duplicate all the records collected in step 1 with the correct ORCS 0281, then reinsert them into the database
delete all of the records collected in step 1 from the database
Update all permissions related to 3883 in Keycloak to use 0281
Verify that variance tracking still works properly

This ticket wont require a deployment. I will just need to run the migration against PROD. I can manage to do that his morning at some point.
@JLWade  @manuji

@manuji I have run the migration in PROD

Thanks @Christopher-walsh22 , I verified that this change has been done on PROD by checking the A&R Admin site, AWS DynamoDB, and DataRegister PROD instances.
Passing this to PO review. @JLWade

thanks all!
@manuji confirming that this change affected any historical or past year records as well for this ORC/Park? Ie. in the report this park shows the new orc for 2022 and 2023

Hi @JLWade , yes the report shows the new ORC in the report. There is one error I am seeing when trying to add data to the "Historical" sub areas in the park, I will report a new ticket for that.


Missing Add-AzureADServicePrincipalPolicy equivalent for the Azure CLI?

I need to associate a custom claims mapping policy with an application and am not seeing an equivalent to PowerShell's Add-AzureADServicePrincipalPolicy in the documentation. Am I missing it?

@jiasli for awareness

Add-AzureADServicePrincipalPolicy is from AzureAD PowerShell module calling Azure Active Graph API.
az ad command module from Azure CLI is not designed to cover all Azure Active Graph APIs - it is only designed to facilitate the usage of Azure Resource Manager.
You may use az rest to directly invoke Microsoft Graph follow examples provided by https://github.com/Azure/azure-cli/issues/12946.

@jiasli, I haven't been able to find any information identifying which endpoint Add-AzureADServicePrincipalPolicy is calling. Am I looking in all the wrong places?


[10.x] Removed unnecessary condition in migrate:status command

The in_array($migrationName, $ran) is redundant. I am aware that this also could be solved like below. But I decided against it because of my follow up PR https://github.com/laravel/framework/pull/47397.
$status = in_array($migrationName, $ran)
    ?  '['.$batches[$migrationName].'] <fg=green;options=bold>Ran</>'
    :  '<fg=yellow;options=bold>Pending</>';

If code is working it is fine for now. Thanks.


Use sort-keys module.

Use sort-keys module. No need to reimplement this in assert-http!

👍  Much better than a handrolled implementation.


chore: Skip uploading artifact when bigger than 2.5MB

What this does
Adds client-side max request body size checking.
Notes for the reviewer
CLI output when he hit this check will look like:
Captured Terraform states: []
An error occured: error capturing Terraform state 'terraform.tfstate': unable to upload artifact: filtered state is bigger than the allowed maximum, skipping upload
exit status 1

More information

Jira ticket CTX-545

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Js registration in FancyBoxAsset.php

Hi, why do you register the Js file using registerAssetFiles in FancyBoxAsset?
public function registerAssetFiles($view) {
        $this->js[] = 'jquery.fancybox' . (!YII_DEBUG ? '.pack' : '') . '.js';
        parent::registerAssetFiles($view);
    }

and not doing something like:
public $js = ['jquery.fancybox' . (!YII_DEBUG ? '.pack' : '') . '.js'];

The reason I ask is that using registerAssetFiles doesn't play well with Combining and Compressing Assets Using the asset Command (at the bottom of: http://www.yiiframework.com/doc-2.0/guide-structure-assets.html)
Thanks!

This is indeed problematic. +1


Initial commit for CUDA fault injection tool

This PR is the initial version of CUDA fault injection tool to explore and test for correctness of CUDA error handling in fault-tolerant CUDA applications.
The tool is designed with automated testing and interactive testing use cases in mind. The tool is a dynamically linked library libcufaultinj.so that is loaded by the CUDA process via CUDA Driver API cuInit if it's provided via the CUDA_INJECTION64_PATH environment variable.
As an example it can be used to test RAPIDS Accelerator for Apache Spark.
Local Mode
CUDA_INJECTION64_PATH=$PWD/target/cmake-build/faultinj/libcufaultinj.so \
FAULT_INJECTOR_CONFIG_PATH=src/test/cpp/faultinj/test_faultinj.json \
$SPARK_HOME/bin/pyspark \
  --jars $SPARK_RAPIDS_REPO/dist/target/rapids-4-spark_2.12-22.08.0-SNAPSHOT-cuda11.jar \
  --conf spark.plugins=com.nvidia.spark.SQLPlugin

Distributed Mode
$SPARK_HOME/bin/spark-shell \
  --jars $SPARK_RAPIDS_REPO/dist/target/rapids-4-spark_2.12-22.08.0-SNAPSHOT-cuda11.jar \
  --conf spark.plugins=com.nvidia.spark.SQLPlugin \
  --files ./target/cmake-build/faultinj/libcufaultinj.so,./src/test/cpp/faultinj/test_faultinj.json \
  --conf spark.executorEnv.CUDA_INJECTION64_PATH=./libcufaultinj.so \
  --conf spark.executorEnv.FAULT_INJECTOR_CONFIG_PATH=test_faultinj.json \
  --conf spark.rapids.memory.gpu.minAllocFraction=0 \
  --conf spark.rapids.memory.gpu.allocFraction=0.2 \
  --master spark://hostname:7077

When we configure the executor environment spark.executorEnv.CUDA_INJECTION64_PATH we have to use a path separator in the value ./libcufaultinj.so with the leading dot to make sure that dlopen loads the library file submitted. Otherwise it will assume a locally installed library accessible to the dynamic linker via LD_LIBRARY_PATH and similar mechanisms. See dlopen man page
Fault injection configuration
Fault injection configuration is provided via the FAULT_INJECTOR_CONFIG_PATH environment variable. It's a set of rules to apply fault injection when CUDA Drvier or Runtime is matched by function name or callback id with a given probability.
There are currently three types of fault injection:

launch a kernel with the PTX trap instruction
launch a kernel with a device assert
replace the return code for the CUDA Runtime call

Example config:
{
    "logLevel": 1,
    "dynamic": true,
    "cudaRuntimeFaults": {
        "cudaLaunchKernel_ptsz": {
            "percent": 0,
            "injectionType": 0,
            "injectionType_comment": "PTX trap = 0, C assert = 1",
            "interceptionCount": 1
        }
    },
    "cudaDriverFaults": {
        "cuMemFreeAsync_ptsz": {
            "percent": 0,
            "injectionType": 2,
            "injectionType_comment": "substitute return code",
            "substituteReturnCode": 999,
            "interceptionCount": 1
        }
    }
}

Signed-off-by: Gera Shegalov<EMAIL_ADDRESS>

build

mythrocks approved these changes 9 minutes ago
...
Review required
At least 1 approving review is required by reviewers with write access.

Notice that my :+1: is ignored here. :]

There might be future iterations where we might make C++-related changes. E.g. RIAA for mutex locking, std::mutex and threads instead of pthreads primitives. But we needn't bother with those now.

Thanks for the review @mythrocks
absolutely, once the PR is merged I'll file an epic for these improvements

build