Normalize URL passed to ContainerRegistry

This MR adds methods for normalizing the URL passed to ContainerRegistry.
These changes were added mainly so that the special registry hostnames would be correctly replaced even when the passed registry URL contains a scheme or a port number.

@Allda ptal

@KristianTkacik Code changes look good.
Can you please follow the commit message guidelines so this change can be automatically released to Pypi? https://www.conventionalcommits.org/en/v1.0.0/
Thank you!

@KristianTkacik Code changes look good.
Can you please follow the commit message guidelines so this change can be automatically released to Pypi? https://www.conventionalcommits.org/en/v1.0.0/
Thank you!

@Allda thanks for the review! I reworded the commit message.

@KristianTkacik Thanks for the contribution. The new version is already available on Pypi https://pypi.org/project/coregio/0.5.2/


CFP: Strict mode for transparent encryption

Cilium Feature Proposal
With Wireguard node-to-node encryption landing soon, adding a further 'strict mode' to the transparent encryption functionality would allow better protection against spoofing attacks, by giving users the option to drop any unencrypted traffic within a Cilium cluster.
This is a stub feature proposal, to be expanded into a full CFP after more investigation.
CC @0xmilkmix and @anfernee, who raised the possibility of such attacks and helped us identify this approach as a solution.

I think the following PR already adds this feature (at least for some use-cases):

#21856
While there is no CFP, there is a draft blog post about this here: https://github.com/cilium/cilium.io/pull/179


Maybe Enum initialize with 1 will be more useful

TypeScript Version:  1.8.0 / nightly (2.0.0-dev.201xxxxx)
Code
enum SomeType {
 a,
 b,
}

function doSth(key:any):SomeType {
 ... do something
}

// the number 0 will make things complicated
if (doSth('value')) {
  ... do something
}

// so i have to change all enums in my project
enum SomeType {
 a = 1,
 b,
}

Expected behavior:
enum SomeType {
 a,
 b,
}
SomeType.a === 1 // true

Actual behavior:
SomeType.a === 0 // true

We definitely can't change this behavior now; it would break thousands of projects in subtle and terrible ways. Maybe there's an interesting historical debate about whether 0 or 1 would have been the better starting choice, but at the time we decided to do what pretty much every other language with enums did.


Fix polling in AccountTrackerController

Forgot to update this Controller in #77

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #79   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          21     21
  Lines        1250   1252    +2
  Branches      153    155    +2
=====================================
+ Hits         1250   1252    +2

Impacted Files
Coverage Δ

src/AccountTrackerController.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c357a04...0fa8e3f. Read the comment docs.


[1.12.2] The Faster the bow/crossbow the less XP i get.

Tinkers: 1.12-<IP_ADDRESS>
Mantle: 1.12-<IP_ADDRESS>
T. Tool Leveling: 1.12.2-1.1.0
For some reason my bow is only gaining 1 XP per kill the bow is made of Plastic, Dragon Bones, Regular String, and paper, the bow + arrow is a hit kill weapon to a standard 20 hp character but for some reason it only gain 1 xp per kill, to test this i made a full Dragon Bone bow witch is gaining 13~14 XP per kill but has a much longer draw speed.
The first image is the "fast" bow that only gain 1xp
The second is the slow bow that gain regular XP

Yes, bows get xp for shooting things, but not the damage dealt (the arrows get that). To balance out bows they get xp relative to their drawspeed.

Is there a way for me to add more xp gain?  Or tweaking the mod script will be necessary ?

Having it fire 1 arrow per second is probably optimal for leveling.. other than that you can always change the configs for it to require less xp.


[Enhancement] Class defines a computed serialVersionUID that doesn't equate to the calculated value[ConsumerGroupTopicConf]

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/consumergroup/ConsumerGroupTopicConf.java line 36,38
analysis and explanation:

There is no usage log.
This serializable class defines a serialVersionUID that appears to be a computed value, however the value does not match the computed value, and thus losses it's value as version indicator.

Describe the solution you'd like
1, Delete the log code.
2. recompute the serialVersionUID using your IDE.
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

@Ishaan29 Yes, it seems to be fixed due to a code update, I will close this issue.


neon extension: add neon_pgdump_schema function

Adds neon_pgdump_schema function
It can be used to execute pg_dump utility in the containerized environment of compute

I'd suggest putting this in compute_ctl instead. The Rust code and compute_ctl HTTP API seems nicer to work with.

We decided to go with a different approach, because we can't rely on extension functions during read-only time travel


[6.4.x] Use canonical URLs for Maven deploy repositories

Backport of #187

Merging as it was approved for master and is only build-related (and we really need it to get the SNAPSHOTs working again).


Use of Array.prototype.find breaks unit tests in browsers that do not support this.

Version
1.0.0-beta.13
Reproduction link
Run Test in IE10
Steps to reproduce

Create unit test using test-utils, use mount command.
Run test in IE10
Test will fail due to TypeError: Object doesn't support property or method 'find'

What is expected?
Test should pass
What is actually happening?
Test is failing.

I think if this is a issue to resolve and this issue is resolved by reverting #462,
#462 should be reverted.

Yes, I also think we should run tests in Phantom to stop this in the future. Currently we run in headless chrome, but we Phantom has less support for features.

I think this is resolved by using core-js.


exactOptionalPropertyTypes failing on ParametersBuilder

These are failing in a more strict mode which expects:
        description?: string;

But in the index.d.ts distribution the methods of declare class ParametersBuilder are defined with:
        description?: string | undefined;

This issue is somewhat inherited from https://github.com/colinhacks/zod/issues/635


[PE-D][Tester D] Adding Task to new application does not display task in left window under new application

Step 1: Add new application with the following data:
Company: Microsoft; Position: cleaner; Status: Progress; Email: popo@m1; Website: http://asdas; Salary: $11; Tasks:  Remark:
Step 2: Select the above application
Step 3: Add the following task: poop at 12-01-1023 15:30

Expected Behaviour:Displays poop at 12-01-1023 15:30 in the left window under tasks
Actual Behaviour: Displays No upcoming tasks

Labels: severity.Medium type.FunctionalityBug
original: rgonslayer/ped#6

Duplicate of #189


Implement XFS quota for overlay2

- What I did
Everybody wants to set disk quota limits on their containers.
Devicemapper got support for --storage-opt size, then zfs
and btrfs.
This pull request adds support for --storage-opt size to overlay2.
The semantics of the size parameter are slightly different then those of devmapper/zfs/btrfs.
For the latter, it means total size limit of composite base image + diff.
For overlay, it means size limit for the diff directory.
I chose to use the same parameter to simplify things a bit.
- How I did it
The overlay2 driver (just as well as overlay and aufs) uses directories
to store the file differences from base image.
XFS supports the project quotas feature, which allows setting a disk quota
for a sub directory and its descendants when the directory is created.
The --storage-opt size option to overlay2 utilizes XFS project quotas to
set a hard limit on the disk usage of a container directory.
The option is therefore applicable only when backing fs is xfs and
only when it was mounted with the 'pquota' mount option to enable
project quota support.
Why only overlay2?
Same support could be added to aufs, but it seems to belong to the past,
so I left it there.
overlay (1) cannot use project quotas, because hardlinks are not allowed across
directories that are assigned to different project quotas.
Why only xfs?
XFS has had project quotas for a long time. Ext4 is gained project quota support
in kernel v4.5 and the quota control API has been generalized to fit
both XFS and Ext4.
When these kernels get to distributions, the specific XFS project quota code can
be amended to serve overlay2 over both xfs and ext4 backing fs.
Known issues

Driver ignores the /etc/projid configuration file, so it does not coordinate container project id's with the xfs_quota tool.
Project quota entries are not cleared when container is removed.

- How to verify it

# grep xfs /etc/fstab
/dev/mapper/test-xfs /var/lib/docker xfs pquota 0 0

# mount | grep xfs
/dev/mapper/test-xfs on /var/lib/docker type xfs (rw,relatime,attr2,inode64,prjquota)

# dockerd --storage-driver=overlay2 -D&
# docker run --storage-opt size=5g -t -i ubuntu /bin/bash
...
root@3812172791eb:/# df -h .
Filesystem      Size  Used Avail Use% Mounted on
overlay         5.0G   12K  5.0G   1% /

- Description for the changelog

Adds support for --storage-opt size to overlay2 over xfs.
- A picture of a cute animal (not mandatory but encouraged)

Wow pretty cool, thanks for working on this!

Moving to code review, sorry for the delay.
@amir73il can you rebase this on master?

Excellent work, this is really cool to see.
From a code layout perspective, I would like to see the xfs specific logic go into a separate file. Ideally we could define an interface for quota management which could apply the quotas on create and be initialized by the storage options. The storage option parsing should be moved to one location, the xfs. prefixed options could be collected together and used to initialize the xfs quota manager.
With the possibility of supported ext4 in the near future, how similar to do you think the interface to apply the quotas will be? Having less xfs-specific logic in the main overlay file should help make adding support for other backing fs in the future cleaner if the usage is going to differ significantly.

@dmcgowan I fully agree with the code layout comments. Just wanted to put
the code out there before sorting everything out.
Ext4 project quota feature is going to be the same as xfs project quota.
The kernel ABI will be new and common to both ext4 and xfs, but xfs
specific  ioctls will still be needed to support older kernels.
@albamc, can you take the task of moving xfs code to common files and
integrate it with your overlay patch?
I do suggest that you use your inode number approach and drop my projid
assignment code for start.
On Aug 12, 2016 10:02 PM, "Derek McGowan"<EMAIL_ADDRESS>wrote:
Excellent work, this is really cool to see.
From a code layout perspective, I would like to see the xfs specific logic
go into a separate file. Ideally we could define an interface for quota
management which could apply the quotas on create and be initialized by the
storage options. The storage option parsing should be moved to one
location, the xfs. prefixed options could be collected together and used to
initialize the xfs quota manager.
With the possibility of supported ext4 in the near future, how similar to
do you think the interface to apply the quotas will be? Having less
xfs-specific logic in the main overlay file should help make adding support
for other backing fs in the future cleaner if the usage is going to differ
significantly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/docker/docker/pull/24771#issuecomment-239545786, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAbppNR0-Ta3HGn0Z_x0hOTkIIkTo74zks5qfNE8gaJpZM4JPFUv
.

@crosbymichael rebased to master. Sorry for the delay.
@dmcgowan I addressed your code review comments about code layout.
Left a TODO comment for adding ext4/xfs project quota for kernels >= v4.5.
Many thanks to @albamc for factoring out the project quota bits into a separate class
and for making the project id allocator persistent.

I was able to test this and verify the quotas work as expected. The detection of the feature does not seem to be working. Might be helpful to print the error on quota ctl creation at debug level as well.

@dmcgowan thanks for the review. I addressed most of the comments by adding more documentation in the code. Regrading your statement that  "The detection of the feature does not seem to be working", I am not sure what you mean. overlay2 driver automatically detects if pquota is enabled at Init() and prints a debug message with the boolean value of 'projectQuotaSupported'. If projectQuotaSupported is true, then --storage-opt can be used when creating containers. Otherwise (either because not xfs or not pquota), an error is generated on container create:
--storage-opt is supported only for overlay over xfs with 'pquota' mount option
What you described is how it was intended to work. Please let me know if I am missing something.

@amir73il did another round of testing. The issue I ran into only occurred when I mounted the device with pquota option, then re-mounted without it. When I used a freshly formatted device I did not run into the issue. I thought I tested yesterday I tried with a fresh device, but since my testing today shows it working I don't see it is a problem.

I did a few more rounds of testing and created a script to help capture the results. Note I am using a loopback device to do the testing and fresh xfs created with default options.
My test script test_24771.sh can be found here https://gist.github.com/dmcgowan/a64d67a6ac067f40598a3ce9473c0823
Without pquota mount option (expected projectQuotaSupported=false)
# ./test_24771.sh t1
meta-data=/dev/loop0             isize=512    agcount=4, agsize=32768 blks
         =                       sectsz=512   attr=2, projid32bit=1
         =                       crc=1        finobt=1, sparse=0
data     =                       bsize=4096   blocks=131072, imaxpct=25
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0 ftype=1
log      =internal log           bsize=4096   blocks=855, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=1
realtime =none                   extsz=4096   blocks=0, rtextents=0
/dev/loop0 on /tmp/tmp.8VQNWZEUOc type xfs (rw,relatime,seclabel,attr2,inode64,noquota)
... removed irrelevant output ...
DEBU[0001] [graphdriver] trying provided driver: overlay2
DEBU[0001] getMaxProjectID(/tmp/tmp.8VQNWZEUOc/overlay2) = 1
DEBU[0001] backingFs=xfs,  projectQuotaSupported=true

$ docker run -it --storage-opt "size=30MB" alpine /bin/sh
... removed irrelevant output ...
docker: Error response from daemon: Failed to set quota limit for projid 1 on /tmp/tmp.idgFjJZAS7/overlay2/backingFsBlockDev: function not implemented.

With pquota mount option (works as expected)
# ./test_24771.sh t2 -o pquota
meta-data=/dev/loop0             isize=512    agcount=4, agsize=32768 blks
         =                       sectsz=512   attr=2, projid32bit=1
         =                       crc=1        finobt=1, sparse=0
data     =                       bsize=4096   blocks=131072, imaxpct=25
         =                       sunit=0      swidth=0 blks
naming   =version 2              bsize=4096   ascii-ci=0 ftype=1
log      =internal log           bsize=4096   blocks=855, version=2
         =                       sectsz=512   sunit=0 blks, lazy-count=1
realtime =none                   extsz=4096   blocks=0, rtextents=0
/dev/loop0 on /tmp/tmp.Ovy1vkiAi6 type xfs (rw,relatime,seclabel,attr2,inode64,prjquota)
... removed irrelevant output ...
DEBU[0001] [graphdriver] trying provided driver: overlay2
DEBU[0001] getMaxProjectID(/tmp/tmp.Ovy1vkiAi6/overlay2) = 1
DEBU[0001] backingFs=xfs,  projectQuotaSupported=true

$ docker run -it --storage-opt "size=30MB" alpine /bin/sh
... removed irrelevant output ...
/ # dd if=/dev/zero of=testfile bs=1M count=64
dd: writing 'testfile': No space left on device
31+0 records in
29+1 records out

@dmcgowan I see, so I will need to try to set a quota on a temp dir for a correct test of pquota support.
I think I also ran my test after remount and not after a fresh mkfs it did passed, strange...
Thanks for the test script. I will look into it

@amir73il it was happening on non-temp directories prior to making the script, didn't know if using a loopback had an effect. I would also be ok with an overlay2.allowquota options or something like that to explicitly turn it on through the daemon storage options if there is no fast and simple way to detect the flag on Init.

Oops! Good catch :/

@dmcgowan I rather not have options that the user doesn't need to know about (i.e. overlay2.allowquota)
I pushed a fix with proper detection by setting quota on a test dir. Also addressed your other review comments and tested with your test script. Thanks!
I also ran some tests trying to mount -o remount,pquota and it seems to be impossible to effectively turn pquota on while xfs is mounted. Even when mount options seem to have changed on remount on my host, the mount options inside my docker development container are still 'noquota'.
The only way I could get quota support is by mounting xfs with pquota to begin with and then running docker daemon (like your test script does).

Latest change looks good and working now as I would expect. Before approving 2 more questions...

Is it possible to have a reserved project id (maybe 1) for testing whether pquota is supported? The benefit would be saving the need figure out the next project id and could just assume that 1 is always available for testing.
Can the project id only be set on a directory or could it also be set on backingFsBlockDev? This only real benefit of this would be so a this test directory which no other use doesn't show up in the logs.

@crosbymichael any other changes you would like to see?

@dmcgowan I did "reserve" a special project id (1) for the test. But it is only reserved in the docker project id allocation range. In the example I wrote in the comment above NewQuotaCtl, /var/lib/docker/overlay2 is assigned the id 999. Then on every daemon start it will create quotatest dir and assign it to projid 1000 and set quota for projid 1000. All container will use projid > 1000.
This can be documented in the system's /etc/projid file, e.g.:
docker:999
dockertest:1000
>1000 reserved for docker containers
There is no real way to actually reserve a projid so others won't use it,
but since the most common way to configure project quotas is by xfs_quota tool,
"reserving" in its /etc/projid configuration file seems good enough.
Furthermore, it is possible to set a quota for projid X regardless if there are any directory
assigned to this id at all and directories can be assigned to project id X later on.

@dmcgowan to answer your second question, no there is no need to create the testdir. I can test set the quota on minProjectID+1 on the blockdev without creating testdir. there is really no need for it.

Awesome! Any chance we get the ext4 version of this in 1.13, too?

@domdom82 what's the rush to get the ext4 version in 1.13? ext4 project quota support has only been merged since kernel version 4.5 and has had some stability fixes in following releases. The newest LTS kernel version used by distros in 4.4. So who is to gain from this?

@amir73il yes, I believe I saw the most recent fixes on ext4 prj quota in 4.8 here https://github.com/domdom82/linux/commit/079788d01e7ba9d7366d7bd2a0db9cab5944e85b
However given that the logic in Docker should be fairly similar for both fs and the widespread use of ext4 and the growing demand for that feature I figured it'd be great to get it early on. But I agree we should not rush it and sacrifice stability so 1.13 may be a bit too early indeed.

ping @crosbymichael PTAL!

anything still blocking this?

LGTM

This broke compilation on Fedora (24 for me)

# github.com/docker/docker/daemon/graphdriver
.gopath/src/github.com/docker/docker/daemon/graphdriver/projectquota.go:20:8: error: redefinition of 'struct fsxattr'
 struct fsxattr {
        ^~~~~~~
In file included from .gopath/src/github.com/docker/docker/daemon/graphdriver/projectquota.go:17:0:
/usr/include/linux/fs.h:155:8: note: originally defined here
 struct fsxattr {
        ^~~~~~~
cp: cannot stat 'bundles/latest/dynbinary-client/docker': No such file or directory
cp: cannot stat 'bundles/latest/dynbinary-daemon/dockerd': No such file or directory
now call sudo systemctl restart docker

@amir73il PTAL

@runcom sorry for that breakage. Please try this patch and let me know if it fixes your problem.
https://github.com/aquasecurity/docker/commit/4de24fedea8f99230789d56a9c8c7b0c278a039a

Fixes build for me (Fedora 23 4.7.6)

Sent PR #27459

This broke manpages generation.  The daemon/graphdriver package is (indirectly) imported from cli/command. Previously the client package did not require linux/fs.h to compile.
I think we should add the man page generation as a build to CI to catch these problems. That will be much easier with something like #27359.
For now, can we move daemon/graphdriver/projectquota.go to either daemon/graphdriver/overlay2/ or daemon/graphdriver/quota ?

Hi, have the known issues solved?

Both issues are not relevant for systems that do not use xfs project quotas
management.
Both issues can be addressed using the following instructions
(from the comment in projectquota.go):
xfs_quota tool can be used to assign a project id to the driver home
directory, e.g.:
echo 999:/var/lib/docker/overlay2 >> /etc/projects
echo docker:999 >> /etc/projid
xfs_quota -x -c 'project -s docker' /
In that case, the home directory project id will be used as a "start
offset" and all containers will be assigned larger project ids (e.g. >=
1000). This is a way to prevent xfs_quota management from conflicting with
docker.

Got it. Thanks!

This sounds very useful.
I guess something like this might be useful for limiting volume size also.

Would Docker be able to use storaged for configuring quotas, if it were available? All the file systems have different quota features and interfaces, it'd be nice to see their overlapping quota support abstracted so Docker can use (project/directory/subvolume) quotas regardless of filesystem.

@amir73il https://github.com/amir73il Is it needed to consider removing
quota settings when the layer is removed?
Eventually that should be considered so project IDs could be reused
efficiently. There are only 32bit of projid by default in xfs.
However, current implementation doesn't have a smart proij allocator. It
always uses max projid of existing layers +1 for new layer.
Note that if all layers are removed (or all new layers since projid x) then
on next daemon start those removed layers projids will be reused.

I would like to have a question regarding the content of this request: am I right that the implemented change only adds overlay2fs size quota capability to the docker create and docker run interfaces?
Or the same option is available even as a dockerd storage-driver option?
I guess not, because the dockerd documentation page still only mentions "override_kernel_check" as the only overlayfs2 specific parameter.
Is it considered to make this option generic, so cluster administrators do not need to separately specify the quota parameter for each and every container creation command? If we consider that the direct docker create/run interfaces are sometimes "hidden" in an orchestrated cluster -e.g. in a K8 cluster-, the only way to impose generic, cluster-wide quotas would be through the configuration of dockerd itself (like with devicemapper).

@Levovar you are right that this PR only adds storage-opt size to create/run commands.
IMO, it should not be a problem to add a dockerd generic storage-opt default_size so any create/run command that don't specify storage-opt size should use this default size (but I am not volunteering to implement it).
However, this requirement is not specific to overlay2 storage driver.
There is no such feature for btrfs (btrfs.min_space is quite different).
You may think that dm.basesize option is the same as default_size, but it is not.
dm.basesize is more like max_size, because you cannot create any container with
storage size larger then dm.basesize.
So default_size option may be useful for devicemapper as well, for example,
when you want to set the maximum container size to 50G, but set a default quota
for containers that are created without specifying storage size.

@amir73il I had asked for something similar here https://github.com/docker/docker/issues/30491

@amir73il I was planning to have a PR and would love to have your eyes on the changes. PR would be to fix https://github.com/docker/docker/issues/30491 and which fits in line with your comment above.


Confusion in = You need to download dlib model. Put it in assets as sp68.dat file. The file is heavy ~70 Mbytes.

Confusion on this part. The link provided by you has multiple files. Which files are we supposed to download and out in asset

Added description:
https://github.com/oleg-sta/FaceMaskExample/commit/291afc4053ee844d9fee7ce42dab1d3a84c8a216

Added description:
https://github.com/oleg-sta/FaceMaskExample/commit/291afc4053ee844d9fee7ce42dab1d3a84c8a216


Blue link

added a blue link global variable in the App.css file and an .env.example file

My bad, I haven't updated my master branch for a while, could you please resend to see if this was really the problem?


[BEAM-13228] fix data race in metrics.store

Fixes data race when accessing store.stateRegistry.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.


Update requirements

Update requirements
Description
Fix syft requirement to 0.2.5
Fixes # (issue)
Type of change
Please mark options that are relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist:

[ ] I did follow the contribution guidelines
[ ] New Unit tests added
[ ] Unit tests pass locally with my changes

@IonesioJunior , this is exactly the same PR than in GridNode (I do not  know why build phase is not triggered)


JIT with constant folded inputs is broken

after constant folding was fixed in https://github.com/tinygrad/tinygrad/pull/1227, adding .contiguous() to inputs of JITed functions was suggested as a fix for passing around 1-D tensors as inputs
but this creates another problem where there is always an extra kernel because of .contiguous() which isn't part of JIT

using the example doc method, in foo1 does work but needs to create a 2-D tensor. there should be a better way

Which also relates to current CIFAR training speed variation


Issue in instantiating node-horseman

Within express app when I tried to create instance of Horseman globally its working correctly without any errors.But when I try the same within the function it throwing the following error
node: ../src/node_http_parser.cc:387: static v8::Handlev8::Value node::Parser::Execute
(const v8::Arguments&): Assertion `!current_buffer' failed.
Aborted (core dumped)
When I do the same thing within sails my code hangs at the line where I instantiate the instance of Horseman.
The same thing works fine when I do it normally without using it with sails or express
The following code block creates a simple express app which requires node_horseman_test_2.js where I instantiate node horseman.
node_horseman_test_1.js
 |--------------------------------------------------------------------------
 | Global Imports
 |--------------------------------------------------------------------------
 */

var express = require('express');
var Promise = require('bluebird');
var path = require('path');
var bodyParser = require('body-parser');
var nodeHorseman = require('./node_horseman_test_2.js');

/*
 |--------------------------------------------------------------------------
 | Create our Express application
 |--------------------------------------------------------------------------
 */

var app = express();

app.use(bodyParser.urlencoded({
    extended: true
}));

app.all('/*', function(req, res, next) {
    // CORS headers
    res.header("Access-Control-Allow-Origin", "*"); // restrict it to the required domain
    res.header('Access-Control-Allow-Methods', 'GET,PUT,POST,DELETE,OPTIONS');
    // Set custom headers for CORS
    res.header('Access-Control-Allow-Headers', 'Content-type,Accept,X-Access-Token,X-Key');
    if (req.method == 'OPTIONS') {
        res.status(200).end();
    } else {
        next();
    }
});

// Use environment defined port or 8888
var port = process.env.PORT || 8888;

// Create our Express router
var router = express.Router();

// Register all our routes with /api
app.use('/api/v1/', router);

// Initial dummy route for testing
router.get('/', function(req, res) {
    res.json({ message: 'Test message' });
});

//Add productMatching router here
var test = router.route('/test');

//Get request here calls scraper to find matches
test.get(function(req, res) {
    nodeHorseman.instantiate(req.query).then(function(results) {
        res.send(results);
    }).catch(function(err) {
        if(err) res.send(err);
        //LOG ERROR HERE
        else res.send('Match failed. Check connection.');
    });
});

// If no route is matched by now, it must be a 404
app.use(function(req, res, next) {
    var err = new Error('Not Found');
    err.status = 404;
    //LOG ERROR HERE
    next(err);
});

// Start the server
app.listen(port);
console.log('Send match searches to ' + port);

node_horseman_test_2.js
var Horseman = require('node-horseman');
var userAgent = 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.122 Safari/537.36';
var Promise = require("bluebird");

exports.instantiate = function() {
  	return new Promise(function(resolve, reject) {
		var horse = new Horseman();
		horse
	    .userAgent(userAgent)
	    .open("http://www.google.com");
		console.log(horse.url());
		horse.close();
	});
};

I know we discussed this via email a bit before and I was stumped, but I decided to start from scratch and try again.  I stood up a new Express 4.0 app
express --ejs newfolder
I installed horseman npm install node-horseman --save
I npm installed everything.
npm install
I modified routes/index.js to look like this:
var express = require('express');
var router = express.Router();
var Horseman = require('node-horseman');

/* GET home page. */
router.get('/', function(req, res) {
	var horseman = new Horseman();
	var url = horseman
		.open('http://www.google.com')
		.url();
	res.json({url:url});
	horseman.close();
});

module.exports = router;

Ran the server, and it works fine. The index page shows {"url":"http://www.google.com/"}.
So I'm not sure what's causing the bug, but maybe recreate what I did and then slowly add to it until you either get the bug, or are able to move forward.

@viveksrinivasanss not sure if this is the issue but You aren't resolving your promise anywhere, so it will never go to .then()
exports.instantiate = function() {
    return new Promise(function(resolve, reject) {
        var horse = new Horseman();
        horse
        .userAgent(userAgent)
        .open("http://www.google.com");
        console.log(horse.url());
        horse.close();
    });
};

@petecoop  actual problem happens in third line itself where I instantiate the node-horseman instance...I missed adding that resolve line...Its not working  even after adding that line...

@johntitus Thanks for the solution...Its working fine now in express ...I am using older version of express ...Once I updated to 4^ version of express its started working....Might be some dependency which I missed before....
But the hanging issue in sails framework still exist...if you want I can post some examples here

If upgrading express fixed it, then I'm going to just blame sails and close this issue ;)


Fix Skybox star colors

The Skybox star colors were appearing generally pinkish due to endianness ordering with Color_RGBA8_u32
typedef union {
    struct {
#ifdef IS_BIGENDIAN
        uint8_t r, g, b, a;
#else
        uint8_t a, b, g, r;
#endif
    };
    uint32_t rgba;
} Color_RGBA8_u32;

To fix this I've added designator field names so that the values are explicitly tied to the correct field regardless of the machines native endianness.
I would've preferred a macro solution as a wrapper around all these variables, but I couldn't come up with something elegant due to the initializer brackets. Anything to get around that was equally as invasive as adding these designators, but less readable.

Fixes #570

Build Artifacts

2ship-mac.zip
2ship-linux.zip
2ship-windows.zip

Would another solution just be to use Color_RGBA8 instead?

Color_RGBA8_u32 is a union with u32. That u32 value is what gets passed to gDPSetColor
Color_RGBA8 does not have that union type, so we would then have to bitpack all the individual values back together for gDPSetColor, or switch to using gDPSetPrimColor which handles the packing inside.

@garrettjoecox heres what RGBA8 with bitpacking could look like https://github.com/Archez/2ship2harkinian/commit/2010595561e30afe8a1d70ff22747e6ec2eaab3f
Or gDPSetPrimColor https://github.com/Archez/2ship2harkinian/commit/e8f1ff4cbd3c7d05279605cf520c2fd574fae25a
Thoughts? (and of course adding 2S2H style comments)

@garrettjoecox heres what RGBA8 with bitpacking could look like Archez@2010595 Or gDPSetPrimColor Archez@e8f1ff4
Thoughts? (and of course adding 2S2H style comments)

I think I prefer either of these to the designators. Are we going to run into this issue anywhere else? Or is this a fairly isolated issue?

I think I prefer either of these over the designators. Are we going to run into this issue anywhere else? Or is this a fairly isolated issue?

This issue only occurs when an initializer list is used with Color_RGBA8_u32 which these two instances are the only ones in the code base.

Updated for the alternate solution


FIX: Inline math collide

This PR changes the MathJax font size setting. Rather than using CSS we now set relative size (92%) using JS in the MathJax config. This is to hopefully fix the Safari rendering issue, where the element size was smaller than the rendered equation - causing overlaps (https://github.com/QuantEcon/lecture-python.myst/issues/117).

Will do extensive cross-browser testing as this is a major tweak across all lectures.

thanks @DrDrij -- let me know how you go with the cross-browser testing.
@AakashGfude can you please update the pre-commit failure.

@mmcky the following PR should fix it https://github.com/QuantEcon/quantecon-book-theme/pull/99 . we can update this branch after merging?

thanks @AakashGfude

@AakashGfude please go ahead and merge in main to update this branch. Thanks.

thanks @AakashGfude for tidying this up. @DrDrij can you let me know when you're ready with the cross-platform checks. Thanks.

@DrDrij I might merge this today and then do some testing on python.quantecon.org. It would be nice to have this fixed as the site is now live.


arrays of arbitrary size in gfx_parameters! are causing errors

As per https://gist.github.com/olsonjeffery/8d32b855c667c5981fec . On rust beta and OSX Yosemite.
Interestingly, if I change char_map: [0.0f32; 16384] to char_map: [0.0f32; 4], in the declaration and instantiation, it will compile. Is this an issue with standard derived traits being implemented for arrays of small sizes, but not arbitrarily large ones? Is there any workaround for this?

Fixed size vectors in the uniform parameters are only for shader vectors, not arrays. So their size is expected to be 2,3, or 4, not 16384.
If you need this much storage, use a buffer. See shadow example for some reference code.

great, thanks!


CI: Review, ensure automated testing of support for Mongo v6

Note: Mongo is a core technology. We need to update our codebase to support Mongo v6 by October 17, 2022*
The mongo:latest tag now points to MongoDB v6. The use of v6 has broken Mongo tests for Ruby 2.2, 2.3, and 2.4, so we have pessimistically locked down our CI system to using a MongoDB v5 tag for now.
We should determine the root cause of Mongo v6 incompatibility so that we can incorporate automated CI tests against Mongo v6.

If the older Rubies are only incompatible with Mongo 6 simply because they are the only ones being used to test very old versions of the mongo gem, then we should see if it's possible to drop support for those versions and set the CI back to tagless.
If we need to retain support for old Rubies and/or old mongo gems, then we should devise a way to also incorporate Mongo v6 into our testing. Perhaps we could spawn both a v5 and a v6 container and dynamically have the tests switch between targetting them.

MongoDB v 6.0.0 was released on July 19, 2022

Mongo v6 is compatible with Ruby 2.5+: https://msp-greg.github.io/mongoid/file.compatibility.html


Automate package release with Travis

Currently Travis isn't doing anything in this repo. We should use it to publish to NPM instead of doing it manually.
Ideally, we should also migrate this library to use semantic-release.

Fixed in #56


Fix abstract column type for unsigned primary key

Q
A

Is bugfix?
yes (in documentation)

New feature?
no

Breaks BC?
no

Tests pass?
n/a

Fixed issues

Merged. Thanks!


How to download from Baidu link?

@leofansq I am not able to access pre-trained weights from the Baidu link. Please guide regarding it. i am not able to create account on the Baidu portal as I dont have Chinese phone number.

@leofansq I am not able to access pre-trained weights from the Baidu link. Please guide regarding it. i am not able to create account on the Baidu portal as I dont have Chinese phone number.

We will upload some pretrained weights to GoogleDrive :)

You can download the dataset from OneDrive following the guidance of CPS.
https://github.com/charlesCXK/TorchSemiSeg/blob/main/docs/getting_started.md#data-preparation

Thanks, I'll check it out.
On Wed, Apr 26, 2023 at 6:47 AM Siqi Fan @.***> wrote:

You can download the dataset from OneDrive following the guidance of CPS.
https://github.com/charlesCXK/TorchSemiSeg/blob/main/docs/getting_started.md#data-preparation
—
Reply to this email directly, view it on GitHub
https://github.com/leofansq/CPCL/issues/2#issuecomment-1522625876, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A5BU5TCPZRCOJPBW4CC3QBDXDBZRDANCNFSM6AAAAAAXJFUTJE
.
You are receiving this because you authored the thread.Message ID:
@.***>

@rst1991 We have uploaded several representative pretrained models (data partition = 1/8) to GoogleDrive, and the links in README is updated.


Change with slicing instead of using underscored prefix variable

I merged this without paying adequate attention to the diffs on the fine-tune book. @szha, can you take a look for an after-the-fact review? If I merged in error, we can add it to the million coffees I owe you. Thanks!

Looks fine to me.

Thanks @szha and @astonzhang!


add fileName to options object

I'm using this plugin in a few different tasks, for example building an images filetree, as well as an html filetree. I wanted an easy way to configure the output file, rather than rename the output afterwards.
I kept tree.json as the default filename, updated the readme, and added tests to spec.

Hi,
looks good.
However, would you have any qualms about moving this functionality to the emitTree option.
i.e.
{
  emitTree: true
}

would output the tree under the default tree.json file name.
{
  emitTree: 'other-file-name.json'
}

would output the tree under the given other-file-name.json file name.
If you want I can do this myself after excepting the pull request, just wondered what your thoughts were.

That seems sensible.
Looking forward to it.
On 20/07/2015 10:12 pm, "Iain McDonald"<EMAIL_ADDRESS>wrote:

Hi,
looks good.
However, would you have any qualms about moving this functionality to the
emitTree option.
i.e.
{
emitTree: true
}
would output the tree under the default tree.json file name.
{
emitTree: 'other-file-name.json'
}
would output the tree under the given other-file-name.json file name.
If you want I can do this myself after excepting the pull request, just
wondered what your thoughts were.
—
Reply to this email directly or view it on GitHub
https://github.com/iamcdonald/gulp-file-tree/pull/1#issuecomment-122865722
.

I had a look over the changes I was going to make last night with regards to this and sort of realised that, in doing so, I'd nuke all your incoming changes. So I ended up not taking the pull request and just making the changes on the head. Sorry dude.
Anyway, I've released up so 0.4.0 should be now be available on npm and allow you to specify a file name on the emitTree option.
Let me know if it acts out of place or whatever, should be fine though.

No problem. The functionality was what I was after. I threw the PR together
in just a few minutes anyway.
On 22/07/2015 2:24 am, "Iain McDonald"<EMAIL_ADDRESS>wrote:

I had a look over the changes I was going to make last night with regards
to this and sort of realised that, in doing so, I'd nuke all your incoming
changes. So I ended up not taking the pull request and just making the
changes on the head. Sorry dude.
Anyway, I've released up so 0.4.0 should be now be available on npm and
allow you to specify a file name on the emitTree option.
Let me know if it acts out of place or whatever, should be fine though.
—
Reply to this email directly or view it on GitHub
https://github.com/iamcdonald/gulp-file-tree/pull/1#issuecomment-123391974
.

Closing - option integrated under emitTree


Audit Publishers.Multicast for thread safety

Also, fix the semantics of Inner.

Fails

:no_entry_sign:

Sources/OpenCombine/Publishers/Publishers.Multicast.swift#L90 - Lines should not have trailing whitespace. (trailing_whitespace)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/MulticastTests.swift#L196 - Arguments should be either on the same line, or one per line. (multiline_arguments)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/MulticastTests.swift#L200 - There should be no space before and one after any comma. (comma)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/MulticastTests.swift#L201 - There should be no space before and one after any comma. (comma)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/MulticastTests.swift#L202 - There should be no space before and one after any comma. (comma)

:no_entry_sign:

Tests/OpenCombineTests/PublisherTests/MulticastTests.swift#L203 - There should be no space before and one after any comma. (comma)

  Generated by :no_entry_sign: Danger Swift against 6ad3fb83a170008bb925dcf32a8cf7cbd7b9a7dd

LGTM

  Generated by :no_entry_sign: Danger Swift against c0a3e407be08621ada1c4efaf3f997dfc2f51617


"use strict" and other linty fixes

Note: DO NOT MERGE UNTIL THIS ISSUE IS RESOLVED.
That will likely generate merge conflicts that I'll need to resolve on my end.
Fixed in #1674.

Fixes #1670

I set "strict" to ["error", "global"] for everywhere, and fixed everything accordingly.
I also changed .eslintignore to ignore far fewer files, and fixed them accordingly.
I edited the .gitignore to include .eslintcache (a file generated locally by ESLint).

Note: this is blocked on this issue being resolved.

I strongly dislike the changing of template literals to double-quoted strings with escaping. It adds a lot of visual noise.
I understand why we don't want template literals in the main library but there's nothing wrong with them in the tests. Issues like that are presumably why test files were excluded from being linted previously.

@tivac I can edit that rule. I just used ESLint's auto-fixing tool rather blindly. Since I changed so many files, could you leave a comment on the relevant lines so I know where to look?

Oh, and some of the tests had undeclared variables absorbed by try-catch blocks.

https://github.com/lhorie/mithril.js/pull/1671/files#diff-65a9ca1b5b773a0aa6697735a249f6f7
You can fix it by using single quotes inside, for example, or by allowing single quoted strings when it avoids escapes (there's an option in ESLint for the latter IIRC).

By the way, the template literal issue was because the "avoid-escape" positional value for "quotes" is deprecated, with support removed. I'm reverting all the relevant changes to that.

@isiahmeadows While I welcome a seasonal cleanup, I wouldn't want to have the linter breathing down my neck when I write tests/debug Mithril...

@lhorie The reasons I commented out a lot of code is because in many cases, it clearly implemented some sort of functionality, but nothing was actually being done. I felt leaving the code commented out was better than just removing it, so if someone decided to finish implementing it, they'd at least have somewhere to start.

@pygy FWIW, I personally find it easier to avoid buggy code when the linter is strict, since you can avoid numerous errors without even running a single test (similar benefits to static typing). Also, until this patch, the tests would've had syntax errors in IE 9 (our baseline). I only modified two rules (enable strict mode and migrate a deprecated attribute), but the only other major thing I did was enable the linter in most places. If you look at the diff, you'll notice a few other issues:

It was ignoring directories that didn't exist (archive and coverage).
It was erroneously ignoring potential subdirectories (hence the new preceding / throughout).
It was ignoring all of ospec and the bundler.
It was ignoring the docs build scripts.
It was ignoring the complex test mocks (if those break, the tests themselves could break).

But enabling it for the tests, too, it does two things:

Better ensures people adhere to the existing style.
Ensures there are fewer obvious errors in the tests leading to false positives. (An unused variable could easily be an unchecked value.)

Pushed some fixes for the quote escape issues.

@isiahmeadows coverage is created if you run npm run cover. I suppose I can npm-run ospec rather than npm run test...

@pygy I missed that. Will fix.

ugh there's some conflicts now

@lhorie I expected conflicts would periodically arise, and directed #1682 to go through despite it causing some conflicts.

Nothing to worry about here.


Support of tap mode?

I encounter a problem when trying to run namespace-OpenVPN in dev tap
When I run dev tun, It works just fine. Can you add support for tap mode ?
Traceback (most recent call last):
  File "/root/namespaced-openvpn/namespaced-openvpn", line 399, in <module>
    sys.exit(main())
  File "/root/namespaced-openvpn/namespaced-openvpn", line 370, in main
    return route_up(sys.argv[1:])
  File "/root/namespaced-openvpn/namespaced-openvpn", line 186, in route_up
    have_ipv4 = assert_all_or_none(
  File "/root/namespaced-openvpn/namespaced-openvpn", line 163, in assert_all_or_none
    raise ValueError(message, *variables)
ValueError: ('Bad ipv4 options pushed from server', '<IP_ADDRESS>', None)

Thanks for the report. I'd have to look deeper into what kind of environment variables openvpn publishes for a tap adapter. However, a lot of the existing code is specific to layer 3 (e.g., adding the IP address and the routes), so I suspect that for tap, it may be easier to write a separate script altogether.


Params in GET and DELETE requests

Is not possible to attach params to GET and DELETE requests directly from the package API. I think they're really handy when testing specific filters when getting data.
Obviously is not a big deal when we need to pass data we can use directly the method call() as the get() method does.
It was nice if we can pass as second param an optional array with the data to send with the request. I can make a PR if you would like have it too :)

There are two PRs that should take care of your issue.
https://github.com/laracasts/Integrated/pull/80
https://github.com/laracasts/Integrated/pull/67

Oh thanks, sorry i didn't look at it


Prometheus Query Exemplars

Description
This PR introduces new capability of querying exemplars in prometheus connectors.
Documentation Link with sample request and response:  https://github.com/vamsi-amazon/sql/blob/query_exemplars/docs/user/ppl/admin/prometheus_connector.rst#prometheus-connector-table-functions
Sample Request:
####
POST http://localhost:9200/_plugins/_ppl
content-type: application/json

{
    "query" : "source=my_prometheus.query_exemplars(query='prometheus_http_requests_total', starttime=1686694425, endtime=1686700130)"
}

Sample Response
"schema": [
    {
      "name": "seriesLabels",
      "type": "struct"
    },
    {
      "name": "exemplars",
      "type": "array"
    }
  ],
  "datarows": [
    [
      {
        "instance": "localhost:8090",
        "__name__": "test_exemplar_metric_total",
        "service": "bar",
        "job": "prometheus"
      },
      [
        {
          "labels": {
            "traceID": "EpTxMJ40fUus7aGY"
          },
          "timestamp": "2020-09-14 15:22:25.479",
          "value": 6.0
        }
      ]
    ],
    [
      {
        "instance": "localhost:8090",
        "__name__": "test_exemplar_metric_total",
        "service": "foo",
        "job": "prometheus"
      },
      [
        {
          "labels": {
            "traceID": "Olp9XHlq763ccsfa"
          },
          "timestamp": "2020-09-14 15:22:35.479",
          "value": 19.0
        },
        {
          "labels": {
            "traceID": "hCtjygkIHwAN9vs4"
          },
          "timestamp": "2020-09-14 15:22:45.489",
          "value": 20.0
        }
      ]
    ]
  ]

Issues Resolved
https://github.com/opensearch-project/sql/issues/1750
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Is explain supported to this type of query? If not, please, add an IT. If yes, please, add an IT too (and maybe doctest too).

Do we want to release it now?
This is experimental and might change in the future. https://prometheus.io/docs/prometheus/latest/querying/api/#querying-exemplars

Yes for 2.9..These APIs are being used in other big projects even though they are experiments. But will double check on it from AWS and other Cloud Offerings.

Please, add IT

ITs for this is little tough we don't have a mechanism to load exemplar metric data into prometheus. Need to figure out a way.

BWC failures are unrelated.


Adds upgrade blocked messages, one with docs, one without

Adds generic cluster upgrade blocked messages.

/lgtm

/approve


Adding Woe

The Pull Request resolves Issue #699
Description:
Adding the word Woe

Looks like Travis is expecting it to be labeled interjunction instead of interjection.

Hey @kennycoc
Updated schema.json to accept Interjection
Thanks for contributing!


Stream descriptions get cut off at the bottom in subscriptions page if they have gs in them

This is presumably a minor CSS issue:

Submitting a quick PR

It seems to work fine here:

@jajodiaraghav try changing the zoom in your browser and seeing if you can reproduce?  I'm using Chrome on Linux, in case it matters.

I've confirmed the issue is problem that appears basically only at 90% zoom. :(.
@brockwhittaker FYI :)

I made a quick fix if you want to apply it @jajodiaraghav:
.stream-row {
    padding: 15px 10px 14px 10px; /* instead of padding: 15px 10px */
}

.stream-row .sub-info-box .description {
    line-height: 1.1; /* instead of line-height: 1; */
}

Thanks @brockwhittaker
Submitting patch in a moment. :)


ImportError: cannot import name 'reconstruct_completion' from 'weave.monitoring.openai.util'

There doesn't seem to be a corresponding method in the weave package.
If you have a version that specifies it, please let me know.
at backend/openui/ollama.py
from weave.monitoring.openai.util import (
    reconstruct_completion,
)

same issue :(

It seems reconstruct_completion has been removed in the latest release (https://github.com/wandb/weave/commit/7157c82c59536981918f668a2be03009114a3f74#diff-30840bac4fcdf610b7bfff00b61ada36f17f92620172f41c31bf4a12bf33d5e4).
Uninstall weave package and install 0.44.0 version.


Option to remove color and prefixed "?"

Would be nice for single confirmations

You should be able to do this currently. See the examples in prompt-base. If something doesn't work there please let me know.
fwiw I have a bunch of docs to push up (and a site) as soon as I have some time. A lot of this stuff will be explained there. and the experience and customizability will be really nice once the state/context stuff is done. You'll be able to easily change the appearance in different positions, based on status/state.

Cool, thanks. I created an issue there for the prefix. How would we remove color from the answer and bold from the message?

try doing something like this:
var prompt = new Prompt([...]);

prompt.renderMessage = function() {
  // customize `this.prefix` and `this.message` and return the message string
};

I believe that should work. let me know if you have any issues

@stevenvachon were you able to get this working?

It worked just fine. Thank you.


New-Label -ExternalSharingControlType broken

Creating new labels via PowerShell results in failures when trying to set the ExternalSharingControlType to ExternalUserAndGuestSharing as per documentation.
Encountered exception: Microsoft.Exchange.Management.UnifiedPolicy.InvalidSiteLabelSettingValueException: SiteLabel setting key 'ExternalSharingControlType' has an invalid value 'externaluserandguestsharing'
   at Microsoft.Office.CompliancePolicy.Validators.LabelValidator.ValidateContainerLabelSiteSettings(LabelAction action, OrganizationId organizationId, UnifiedPolicyCmdletLogger cmdletLogger, Boolean isUnm
anagedDeviceAccessSet, Boolean isE5Tenant, List`1 protectionLevels)
   at Microsoft.Office.CompliancePolicy.Validators.LabelValidator.ValidateSiteSettings(LabelAction action, OrganizationId organizationId, UnifiedPolicyCmdletLogger cmdletLogger, Boolean isE5Tenant, List`1
protectionLevels, Nullable`1 isEnableValidationsOfContainerLabelProtectSite, Nullable`1 isNewLabelActionValidationsEnabled)
   at Microsoft.Office.CompliancePolicy.Tasks.NewLabel.InternalValidate()

We have the same issue at one of our customers. We confirm this behavior also on the development tenant.

@mhupfauer, @LudwigVanGysel your best bet is to open a support case. If this is a transient problem, then no updates to documentation are required. If the support case reveals something that should be noted in the documentation, report back here.

@mhupfauer  Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


IG:dm | cannot login

hi! I can not log in to the GI: dm. my account does not have two verification steps and even informing in the instagram application that the access is mine, it continues giving error. can you help me? thanx!

happens to me as well


chore(readme): add badges for size

:tada: This PR is included in version 1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add support for hex map on non mobile devices

closes
Prerequisites:

[x] Unless it is a hotfix it should be merged against the dev branch
[x] Branch is up-to-date with the branch to be merged with, i.e. dev
[x] Build is successful
[x] Code is cleaned up and formatted

Summary
when the US is shown, it shows on non-mobile devices by default a hex grid map with the option to show a county choropleth map instead:

on mobile it will always use a choropleth map (state vs county)

Desktop looks great.  As discussed in slack, I'd like to get a version of the hexmap in mobile as well, but we can tackle that in another PR.

click on map to select a state:

mobile beehive:

Looks great!  Did we loose padding on mobile?  Other than that I think this is ready to go:


no token EN message typos

This issue is imported from pivotal - Originaly created at Oct 11, 2019 by Thijs Kinkhorst
Feedback from testing team about the no suitable token error:
EN mist 'the' voor token (regel 3) enheeft spatie achter 'low' (ook regel 3). Belangrijker: De aangekondigde link ontbreekt

(Thijs Kinkhorst - Oct 11, 2019)

I've added a php5.6 label to this issue so we could fix this combined with other php5.6 issues to prevent the overhead of switching php versions while developing. (bstrooband - Oct 11, 2019)

I think we can retract the 5.6 label @bstrooband this should land in 6.0 (Michiel Kodde - Nov 13, 2019)

@thijskh I\'ve fixed the typos but I was wondering what you\'d expect in order to fix the missing link for EN. For NL this is:

Lees meer over het registratieproces.
I saw that the url 'https://support.surfconext.nl/stepup-noauthncontext-**en**\' isn't working, but could I still use:
Read more about the registration process. (bstrooband - Nov 13, 2019)

Tested the link and it works like a charm! (bstrooband - Nov 13, 2019)


Approver Request

xtreme-vikram-yadav
Requirements

[x] I have read the contributor guide
[x] I have enabled 2FA on my GitHub account
[x] I have joined the Kubernetes Slack workspace and the #octant channel
[x] I am actively contributing to Octant
[x] I have two sponsors that meet the sponsor requirements listed in the community membership guidelines
[x] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application

Sponsors

@wwitzel3
@GuessWhoSamFoo

List of contributions to the Octant project

PRs reviewed / authored: #2045  #2099 #2140 #2244 #2257 #2258 #2275 #2325 #2165 #2222 #
Issues responded to: #1513 #1750 #1952 #2063 #2211 #2303 #2305 #2042 #1721

/approve
Way overdue!

/approve
🎉


Add daemon flag --enable-secrets.

This flag (--enable-secrets) is enabled by default. It allows subscription-manager inside the containers to use subscriptions available on the host.
Signed-off-by: Shishir Mahajan<EMAIL_ADDRESS>

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1400228.
ping @rhatdan

@shishir-a412ed could you add the BZ this commit is fixing in the commit message? This will allow us to keep track of why we changed what and when.

@rhatdan @runcom PTAL.
Shishir

LGTM thx @shishir-a412ed

I'll port this patch to 1.13 and other branches (no worry)

@shishir-a412ed did you handle the unmounting secrets parts of the code?

@rhatdan I think that should already be handled by the code.
Without this flag --enable-secrets the host secrets were getting mounted and unmounted.
Now with this flag:
a) When --enable-secrets=false: No mounting will happen.
b) Default: --enable-secrets=true: It will append the mount point to the data structure (ms) containing other mount points. And it will unmount everything in the end.
I ran a container and I was able to see the secrets mounted at /run/secrets and I was able to exit the container gracefully. WDYT ?
Shishir

LGTM


Cypress Execution on Firefox

we are disabling web security while running application in local containerized environment. As a result, firefox does not support execution of Cypress script and displays cross origin error. Following is the cypress issue ticket.
https://github.com/cypress-io/cypress/issues/6629
We also tried by disabling chromewebsecurity and security.fileuri.strict_origin_policy to false but still getting the same error

needs rnd still.


Add Github topics to the repository

Hi, can you add the following topic to this repository?

https://github.com/topics/ing-diba

Thanks!

Done!

Thank you!


Cannot instantiate abstract class

Your docs and code don't match up from what I can tell. You have a constructor in an abstract class and you docs say to instantiate that abstract class. Something is missing.
I am happy to submit a PR unless it is me who is missing something.

 That would be my bad. If you're willing to submit a PR, go for it!
Are you interested in using the SDK? I haven't had anyone even look at it much so far. This actually came from a prototype project in PHP. We needed an SDK for PHP, but there wasn't one, so we wrote one in-house. Afterwards, we decided to open-source it. Feel free to suggest any improvements or new features that might be useful if you're interested in using it.

Ditto on this, the documentation as it stands is incorrect. From what I can see, removing the abstract off ApiClient would work? Not sure why it needs to be abstract.
Thanks for making the SDK, it helps!

@connorjburton You can't instantiate ApiClient directly since the Edmunds API is actually divided up into multiple different APIs. For example, if you want to use the Vehicle API, you would create an instance of VehicleApiClient, which extends ApiClient. As of right now, that is the only API implemented, but it wouldn't be too difficult to implement some of the other Edmunds APIs.
As it stands, the documentation is indeed a little confusing on this.

Okay that makes sense, I guess just removing that section from the documentation is the best bet at the moment then, and just have the VehicleApiClient section.


Unicode flag in email validation

Hi,
I noticed that the assertion made by Assertion::email() does not allow Unicode characters. Since 2012, Unicode characters above U+007F encoded as UTF-8 are allowed in the local part.
PHP 7.1 added the flag FILTER_FLAG_EMAIL_UNICODE that can be used with FILTER_VALIDATE_EMAIL to accept those Unicode characters.
filter_var($value, FILTER_VALIDATE_EMAIL, FILTER_FLAG_EMAIL_UNICODE)

A simple test with two emails allows to check the difference:

<EMAIL_ADDRESS><EMAIL_ADDRESS>
I can submit a PR to add the flag with an extra argument but maybe you would prefer to add a new method so I prefer to discuss it here before.
Regards

@gaelreyrol yes, this seems like a bug we should fix.


Web3Modal + Wagmi v2 Example in Next.js App Router

Waiting for Wagmi v2.3 for cookies fix*

is the test supposed to fail? cc @arein @ganchoradkov


[PDI-18678] In rare situation's getStatusServlet down with NPE error

Additional fixes for same error in other carte code

:white_check_mark: Build finished in 37m 50s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!
Tests run: 3643, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 31m 15s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!
Tests run: 3643, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 31m 1s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!
Tests run: 3643, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

@mkambol need your review and merge, if is possible.

:warning: Build finished in 31m 37s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:no_entry: Failed Tests
:cloud_with_lightning_and_rain: 2 test(s) failed:
org.pentaho.di.trans.steps.databasejoin.DatabaseJoinTest.testStopRunningWhenStepIsNotStoppedNorStepDataInterfaceIsDisposedAndDatabaseConnectionIsValid (click to expand)
${result.errorDetails}

org.pentaho.di.trans.steps.databasejoin.DatabaseJoinTest.testStopRunningWhenStepIsNotStoppedNorStepDataInterfaceIsDisposedAndDatabaseConnectionIsNotValid (click to expand)
${result.errorDetails}

Tests run: 3643, Failures: 2, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 31m 30s
Build command:
mvn clean verify -B -e -Daudit -amd -pl engine

:ok_hand: All tests passed!
Tests run: 3643, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


useStateWithHistory doesn't pass current value to callback style setState

What is the current behavior?
Using useStateWithHistory's callback style setState will receive no arguments.
const [state, setState] = useStateWithHistory(0);
setState(val => val + 1); // val is undefined

Steps to reproduce it and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have extra dependencies other than react-use. Paste the link to your JSFiddle or CodeSandbox example below:
See example above.
What is the expected behavior?
Expected callback style setState to receive the current value as the first argument.
A little about versions:

OS: NA
Browser (vendor and version): All (Chrome)
React: 17
react-use: 13.3.0
Did this worked in the previous package version? No

:tada: This issue has been resolved in version 17.2.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Interactive mode when asking for AWS or GCP resource IDs

Hello @reliablyhq/developers, can someone please review this?

I can't really comment on golang PR but I'm excited by this feature :)


Shortcut keys

Hello,
I am very satisfied with Stash's powerful cleaning function, but whenever I play a video, my old CPU on my PC is overworked, so I was looking for a way to play it on a local player such as Potplayer. Thank you for developing a good program.
If there is one suggestion, it would be nice if you could put a shortcut key in Play Current Scene/Movie/Gallery/Images or set it up
Thank you again.^^

OK, thanks for the kind words and suggestion. I will implement this shortcut very soon.


Documentation - Meetings

Acceptance criteria

POs create orderen meeting notes inside the wiki

Definition of done (DoD)

Added only after week 5
The same for all features
Here goes the project specific part

DoD general criteria

Feature has been fully implemented
Feature has been merged into the mainline
All acceptance criteria were met
Product owner approved features
All tests are passing
Developers agreed to release

To be done: have plain-text meeting notes.

Solved by creating a custom sidebar for having meeting notes in the TOC format.
https://github.com/amosproj/amos2024ss04-building-information-enhancer/assets/46463790/b8668f6a-e7bc-4028-b8d4-026e57f79142


[DSL] Add prettier DSL error

Goes hand in hand with https://github.com/CocoaPods/Core/pull/226.

This is great! Instead of saying "invalid Gemfile", can we keep the error message closer to the original? Something like "There was an error while parsing the Gemfile:". It's a small change, but keeping error messages as human-friendly as possible is important.

This should finally be green! It turns out, different rubies have really different ideas on how to report that } is an invalid ruby file :)


Resident IDP's home realm identifier does not support multi-values

In Resident IPD's basic configuration, the tool tip for home realm identifier specifies that it can be a comma-separated multi valued list [1]. This is not supported in IS

https://wso2.org/jira/browse/IDENTITY-6926

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Fix lerna related issues

Many of us have been facing different issues while using lerna. We are currently using version ~3.3.2, but the latest version is currently 3.11.0. Based on their changelogs, there were multiple bug fixes, so I'd try upgrading it to the latest version as a first step.
Besides, this is the list of some of the issues I've been facing recently:

Cleaning fails: running npx lerna clean fails the first time, but it succeeds if you try again.
I've faced missing property 0 of undefined while installing lerna in the root dir
Lib test script fails erratically due to not finding Truffle's module (see this example)
Bootstrap for the integration tests fails erratically while bumping a new version (see here)
We need to run lerna bootstrap more than once to make sure deps are found by the CI (this may be a Travis issue - see travis.yml root file)
Releasing is cumbersome: running lerna version does not update all the package-lock files. I need to update them using npm or re-running lerna bootstrap to make sure those are updated correctly. Thus, I never release using lerna automatically.

Please feel free to comment/edit if some of you faced other issues.

lerna bootstrap --scope=integration-test-workdir does not symlink zos and zos-lib dependencies, since it only symlinks to projects in scope. It's fixed for now by removing the scope, but it seems that running lerna link would be more efficient (though it does not prepare the dependencies).


Adding notes about exe file generation  ?

Would you mind adding the instruction on  how  windows and Linux got generated ?

They are generated using pyinstaller automatically via the GitHub actions workflow:
https://github.com/fox-it/log4j-finder/actions
More specifically:
https://github.com/fox-it/log4j-finder/blob/main/.github/workflows/pyinstaller.yaml
For the release we download the generated artifacts manually and attach it to the release page

@yunzheng , can you add info about using pyinstaller to compile .py into exe manually without github action ?
This will allow users to compile their own exe and push out binary to their systems with more confidence.

Use "pyinstaller ". That works a charm (Python 3.10 used)

@jkommeren , Thanks for the note.

Here is the note  for rocky8 (RHEL 8 downstream)

[me@rocky8t01 github]$ cat /etc/redhat-release
Rocky Linux release 8.5 (Green Obsidian)
[me@rocky8t01 github]$ pip -V && python -V
pip 21.2.4 from /usr/local/lib/python3.9/site-packages/pip (python 3.9)
Python 3.9.8
[me@rocky8t01 github]$ pip install pyinstaller
<snipped>
[me@rocky8t01 github]$ which pyinstaller
~/.local/bin/pyinstaller
[me@rocky8t01 github]$
[me@rocky8t01 github]$ git clone https://github.com/fox-it/log4j-finder.git
[me@rocky8t01 github]$ cd log4j-finder
[me@rocky8t01 log4j-finder] pyinstaller log4j-finder.spec
<snipped>
[me@rocky8t01 log4j-finder]$ dist/log4j-finder -h
usage: log4j-finder [-h] [-v] [-n] [-b] [PATH ...]

Find vulnerable log4j2 on filesystem (Log4Shell CVE-2021-4428)

positional arguments:
  PATH             Directory or file(s) to scan (recursively) (default: ['/'])

optional arguments:
  -h, --help       show this help message and exit
  -v, --verbose    verbose output (-v is info, -vv is debug) (default: 0)
  -n, --no-color   disable color output (default: False)
  -b, --no-banner  disable banner (default: False)

Files are scanned recursively, both on disk and in Java Archive Files
[me@rocky8t01 log4j-finder]$

Thanks for the great feedback and suggestion.
The instructions has been added. Not as detailed as yours @tjyang but I think it should be ok :)


Link to instructions on how to upgrade?

When you run the reliably command and there is a newer version available, the link takes you to the release page on GitHub. This is not bad per se, but it would be so much better if it was a link to that release page and perhaps a link to the instructions to upgrade the reliably CLI itself.
Also there were no obvious instructions as to how to upgrade the Reliably CLI that I could see in the docs, but I'll raise a separate issue for that.
This was prompted by using version 0.7.0 of the CLI, so there may already be some improvement when I upgrade to 0.12.0. Checking that now.

@russmiles - how about this for an upgrade message something like:

a quick one @gtfisher , seen from gcloud cli, I would add the space before "to upgrade run: " not after, and add a couple spaces and $ to emphasis on shell command:
A new release ...

To upgrade run:
  $ curl -L ...


Fix base_dir in TargetFinder#find_files()

dir variable in TargetFinder#find_files() doesn't exist:
undefined local variable or method `dir' for

I think it was just a misprint.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[ ] Feature branch is up-to-date with master (if not - rebase it).
[ ] Squashed related commits together.
[x] Added tests.
[ ] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Nice! Can you add a changelog entry?

Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

FYI, the CircleCI Pipeline error may be resolved by re-authenticating with CircleCI because your GitHub OAuth token may have expired.
https://support.circleci.com/hc/en-us/articles/360051228052-How-to-Perform-a-Re-Authentication

Thanks!


Create Request from globals / Fixes #35

Get the request from the container if it was registered or in a service provider, else it will create a request object from globals.
Should I add the $vars in the attributes part of the request automatically too?

I'll pull this in and tidy manually


Suggestion: give better error message on SaveChanges method

Code
table
CREATE TABLE [dbo].[Department](
    [IntPK] [int] PRIMARY KEY,
    [DepartmentName] [nvarchar](50) NOT NULL
) ON [PRIMARY]

Model class
[Table("Department")]
public class Depertment {
  [Key]   // Key annotation without DatabaseGenerated option
  public int IntPK {get; set;}
  public string DepartmentName {get; set;}
}

Description
Primary key coloumn isn't identity and Key annotation without DatabaseGenerated option.
So, When I will call SaveChanges method, exeception will be thrown.
But It is difficult to understand the error message
when inserting an int type primary key column.
Please give better error message on SaveChanges method.
Expected behavior
I want a message that the DatabaseGenerated option should be changed.
Actual behavior
"Can not insert value NULL in column 'IntPK ' of table 'DBName.dbo.Depertment' This column does not allow NULL values INSERT fails. The statement has been terminated. "
(I can't find original message. So, I transrate message Japanese to English)

@YuichiNukiyama There are a few problems with doing this:

Understanding from the error that this was really what the application intended is difficult--the same kind of exception can happen for multiple reasons
The fix is not necessarily the same depending on why the error is happening, so suggesting to use DatabaseGenerated is not necessarily the correct thing to do.
Doing any of this requires provider-specific interception of database exceptions, which is something that adds complexity and generally has no value.

For these reasons, this is something we are not planning to do in either EF6 or EF Core.


Integrate with nvim-neo-tree for AST

https://github.com/nvim-neo-tree/neo-tree.nvim
I don't use it myself, so someone who uses it can do this
See https://github.com/p00f/clangd_extensions.nvim/blob/c556bcd3a7799cf0ae05a6ca67e73dbc7ec22671/lua/clangd_extensions/ast.lua#L57-L77

meh


Google doc viewer as offline

hi.. i installed rainloop on local machine with local network . the only pc can get internet is the local server which have rainloop on it.
.
enabled google viewer integration .
but the docs wouldn't get previewed what ever i try ..
any solution for that?
waiting your replay . ty
as a local server.. it cant have a public domain. so it doesnt have .com or ,net or or or...
and by that.. i cant do integration with google.
how ever i got an online server .. diff from this one.
any one can help plz?
ty
if all that not possible.. is there an alternative for google docs viewer that i can host localy and integrate it with rainloop?

Unfortunately, it is Google viewer limitation.
it works only with external web sites.
I didn't hear about solutions that work locally.

U might use google extention in google chrom..
https://chrome.google.com/webstore/detail/office-editing-for-docs-s/gbkeegbaiigmenfmjfclcdgdpimamgkj?hl=en
It works offline.. u need to open file using google chrom.. but how to tell the view to auto open it there ?.


Added denon media player controls via denonavr library

Description:
Added support of the Denon http interface to control receivers which is providing some more options than the telnet interface like album covers and is supporting more than one simultaneous connections.
The interface handling is done in an own library called denonavr >>> https://github.com/scarface-4711/denonavr
So far I tested it on my own Denon AVR-X4100W receiver, but it should also support other Denon AVR receivers using that web interface.
This pull request is successor of my previous request home-assistant/home-assistant#4260 as I was obviously not able to handle git correctly ;-)
Related issue (if applicable):
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#1411
Example entry for configuration.yaml (if applicable):
media_player:
  - platform: denonavr
    host: IP_ADDRESS
    name: Denon receiver

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

How can I fix the requirements error mentioned by Travis CI check for python 3.4.2?
The script/gen_requirements_all.py already run and I included the changed requirements_all.txt to this pull request.

@fabaff: you forgot to mention that on the release notes


constrainWidth false forces dropdown to have narrow ul

If a dropdown has constrainedWidth set to false, the object does not span the width of the content it contains.
Expected Behavior

If a user doesn't want to constrain the width of an object it's typically because we want the object to span with the content it contains.

Steps to Reproduce (for bugs)

var options = {
    coverTrigger: false,
    constrainWidth: false,
};

var elem = document.querySelector('.dropdown-trigger');
var dropdown = new M.Dropdown(elem, options);

Context

Wanted a dropdown UL to span the width of the longest item in the list
Your Environment

Laravel 5.5 / Homestead / Webpack
"materialize-css": "^1.0.0-alpha.1",

Version used: ^1.0.0-alpha.
Browser Name and version: Chrome / FF/ Safari
Operating System and version (desktop or mobile): MacOS
Link to your project (if appropriate):

Not able to recreate: https://codepen.io/Dogfalo/pen/YYKXjo
Please create a codpen with the issue and I will reopen this.


Review state-of-the art of document layout analysis

[ ] Do an systematic review of academic writing about document layout analysis
[ ] Contact key people (librarians, researchers) that can propose solutions
[ ] ...

Candidate papers:

[ ] NDocBank: A Benchmark Dataset for Document Layout Analysis

Candidate papers:

[ ] NDocBank: A Benchmark Dataset for Document Layout Analysis

After review we have decided to use PDFBox.


Email/Pw for Simpos

how to login ? what Email/pw ?

Hi @CentZek,
Please try to log in again
Email<EMAIL_ADDRESS>Password: 12345678
Sorry for the late reply, I was busy for a different project https://github.com/hieuhani/techgoda
Thank you,


don't run normal workflows when dependabot is making the update

Supports #86.

Would love to be able to auto release on these sorts of updates, I'll have to noodle on it

@RyKilleen not recommended to auto-release on Dependabot updates due to the potential for supply chain attacks.

@RyKilleen though to be clear, you can set up auto-merge on the PRs themselves, where it'll merge as soon as the builds complete successfully.


Issue 3746 - Misleading error message "OP has no effect in expression XXX), in void function

Better error message when returning an expression with no side effects from a void function.
After semantic, re-run checkSideEffect while gagged and use global.errors to determine if the expression had side effects.
http://d.puremagic.com/issues/show_bug.cgi?id=3746
The patch in https://github.com/D-Programming-Language/dmd/pull/174 would make this unnecessary.

Not needed as pull #174 has been merged.


Level '???' is incorrectly displayed on map

Parts of the non-terrain regions of the map of level '???' are not displayed on the map.

Created an issue on the Delver side of things.


Run it without gulp or npm

Any way to run this as a "node server.js" app?

I think you can compile first with gulp and then try running node bin/server/server.js

Yes, thank you!


Fix python reentry in filtercatalog threaded runs

This makes a change to allow thread initializers to be called when the filter catalog threaded runner spawns threads.
In C++ land, this does nothing.
In python land, this allows us to have a PyGILStateHolder initialized to allow reentry into pure python code.

Found a better solution...


Text files not recognised by magic

Somehow plaintext files are not recognised:
irb>> MimeMagic::VERSION
=> "0.3.2"
irb>> file = '/tmp/foo'
=> "/tmp/foo"
irb>> File.write(file, 'This is a text file')
=> 19
irb>> MimeMagic.by_magic(file)
=> nil

I've got the same problem.

It appears to only detect text files by magic if the files begin with the strings:

This is TeX,; or
This is METAFONT,

Needless to say, this would only appear to cover a minimal subset of text files.

I have a proposed PR for testing for CSVs: #75

Is it possible to test via file extension and then via magic? This should handle the tex, json, css, csv cases.

If you want to be able to match and be mostly sure, you have to parse at least part of the file. I'm not sure with the current setup that you actually can correctly check for CSVs, JSON, CSS, and etc. You can check by extension, but I can do that without the library.

Has any movement been made on this? I just ran into this problem on a project I'm working on and could really use a solution.

Invalid, this should be fixed in the shared-mime-info database upstream.

Invalid, this should be fixed in the shared-mime-info database upstream.


Webhook pagination

Summary
Adds pagination and toggling functionality so that all incoming and outgoing webhooks can be viewed in the integrations page, and be enabled/disabled.
Ticket Link
https://mattermost.atlassian.net/browse/MM-40546
https://mattermost.atlassian.net/browse/MM-40692
Related Pull Requests

Has server changes (https://github.com/mattermost/mattermost-server/pull/21183)

Screenshots

Incoming and Outgoing Webhooks view - in contrast to the original, there is a new page navigation view with next and previous page buttons at the bottom. Each page is 10 entries by default, and clicking the buttons (when enabled) navigates to the next/previous page, in contrast to listing up to 200 hooks as done previously.
Release Note
Added paginated viewing and toggling to incoming and outgoing webhooks

The files .circleci/config.yml, Makefile are in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

The files .circleci/config.yml, Makefile are in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

The files .circleci/config.yml, Makefile are in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

@WilliamLongKing can we also get a design review on this? Some elements seem misaligned

@nevyangelova I actually have been discussing design with Matt Birtch, here's an update on what it currently looks like (the icon colors may change).

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@WilliamLongKing is there anything we can help with to get this PR over the finishing line?

Heads up that as part of our efforts to move to a monorepo, we're closing out a number of older pull requests like this one to help streamline the effort.
If you'd like to preserve these changes -- even if you're not the original author! -- feel free to resubmit the pull request against the monorepo once it's ready. You can subscribe to mattermost-server-issue-22420 for status updates on this effort.


Breaks entire Angular setup in IE11 because of the usage of "class" keyword.

It's apparently fixed in this version. Was using the old version.


tools: Update api docs publishing to publish for all repo packages

Publish all API docs instead of just those specified in api-rollup-data. This does not change which packages we surface through the website's navigation UI, it simply guarantees that all of our API docs are published in place such that cross-package links (etc.) work as expected.
Publishing all of our docs required updating our fork of api-documenter to fix a bug with respect to how namespaces are handled, and how links to certain concepts are handled. This PR updates @tylerbu/custom-api-documenter to pick up the following changes:

https://github.com/tylerbutler/custom-api-documenter/pull/4
https://github.com/tylerbutler/custom-api-documenter/pull/6
https://github.com/tylerbutler/custom-api-documenter/pull/7
https://github.com/tylerbutler/custom-api-documenter/pull/8

Some of the broken links in the report seem valid.

I haven't yet, but I'll do so.

Alright, so the issue seems to be with the way namespaces are treated in our api-documenter fork, resulting in links that assume namespaces get their own pages, when they currently don't. I am working on a fix now, but this PR will have to wait on that.

@tylerbutler The remaining link issues are strange. The warnings are all with regards to missing headings, but I have verified that they are indeed correct. And the 1 remaining 404 references a link that does not exist in the generated output.
The error references: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cyclic, but the actual link (in both the code and the generated markdown output) is: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Cyclic_object_value#examples.
I'm wondering if this is an issue with the link checking tooling. Wondering if you have any insight here?


REPORT module requires weasyprint

I run the ml module with a numerical csv file, an at the end it didnt create the pdf, the module is already install, I try it several times.

Can you provide me with more information about your operating system and confirm if you followed the exact instructions from the ReadTheDocs webpage (https://robert.readthedocs.io/en/latest/Install/installation.html)?
Specifically, did you complete this step:
conda install -c conda-forge -y glib gtk3 pango mscorefonts


add session name to config

addition to the new print command

I don't know how to fix this test.

Thanks, I'll check the test tonight

@mipmip here's a diff for the test:
diff --git a/smug_test.go b/smug_test.go
index aeb9da1..ae91c8f 100644
--- a/smug_test.go
+++ b/smug_test.go
@@ -349,7 +349,7 @@ func TestStartStopSession(t *testing.T) {

 func TestPrintCurrentSession(t *testing.T) {
        expectedConfig := Config{
-               Session: "test",
+               Session: "session_name",
                Windows: []Window{
                        Window{
                                Name:   "win1",
@@ -366,6 +366,7 @@ func TestPrintCurrentSession(t *testing.T) {
        }

        commander := &MockCommander{[]string{}, []string{
+               "session_name",
                "id1;win1;layout;root",
                "root\n/tmp",
        }}

Can you please apply it, and update the pr?

:+1:


This plugin is broken.

1 - app is slowered, need to click button couples times before it reacts
2 - app closing itself time to time!?|
3 - app opens itself (hide and open, go to background and foreground)
4 - breaks other plugins! For example  that returns always 0 steps with called  backgroundmode.enable() or set true(but it is never enabled)
  initialize () {
            window.onload = () => {
                document.addEventListener(
                    'deviceready',
                    this.onDeviceReady.bind(this),
                    false
                );
            };
        },

        onDeviceReady () {

            try {
               / this.initBackgroundMode();
            }
        initBackgroundMode () {
          console.info(`backgroundMode is enabled: `, cordova.plugins.backgroundMode.isActive());
            console.log(`Cordova.plugins.backgroundMode :`, JSON.stringify(cordova.plugins.backgroundMode));
            if(cordova.plugins.backgroundMode.isActive()){
                console.info(`backgroundMode is enabled!`);
                return;
            }

            cordova.plugins.backgroundMode.on('activate', function() {
                cordova.plugins.backgroundMode.disableWebViewOptimizations();
            });

            // DOCS  https://github.com/katzer/cordova-plugin-background-mode
            cordova.plugins.backgroundMode.enable();
            cordova.plugins.backgroundMode.overrideBackButton();
            cordova.plugins.backgroundMode.setDefaults(
                {
                    title:   'SGX',
                    text:    'Counting steps',
                    // icon:    'icon' // this will look for icon.png in platforms/android/res/drawable|mipmap
                    // color:   String // hex format like 'F14F4D'
                    // resume:  Boolean,
                    hidden:  false,
                    bigText: false,
                }
            );
            console.info(`backgroundMode is enabled after: `, cordova.plugins.backgroundMode.isActive());
            console.log(`Cordova.plugins.backgroundMode :`, JSON.stringify(cordova.plugins.backgroundMode));
        },
            catch (err) {
                alert(`Something went wrong, please contact support`);
                alert(`initBackgroundMode: `, JSON.stringify(err));
            }

from this code

backgroundMode is enabled:  false

d2f717a319988a4e2c3f.js:1 Cordova.plugins.backgroundMode : {"_listener":{},"_isEnabled":false,"_isActive":false,"_defaults":{"title":"App is running in background","text":"Doing heavy tasks.","bigText":false,"resume":true,"silent":false,"hidden":true,"icon":"icon"},"_isAndroid":true}

d2f717a319988a4e2c3f.js:1 Cordova.plugins.backgroundMode : {"_listener":{},"_isEnabled":false,"_isActive":false,"_defaults":{"title":"SGX","text":"Counting steps","bigText":false,"resume":true,"silent":false,"hidden":false,"icon":"icon"},"_isAndroid":true}

d2f717a319988a4e2c3f.js:1 backgroundMode is enabled after:  false

4fc373cfb34d709d48c1c.js:1 steps:  0 <<< --- always with installed but "inactivate"  plugin.

1 - it does not work in background, mode is always inactive even if activated
2 - it has no notifications as it says cordova.plugins.backgroundMode.setDefaults( does not work
3 - if(cordova.plugins.backgroundMode.isActive()){ always false
4 - catch catches some errors, but loggin empty object JSON.stringify(err)
Error message  in app
"[app title] keeps stopping" -> close app. The end. Because now app is broken, stopped or run again, only removal helps to reset it is satate. Otherwise user get very wrong data, like app is working, but it does not. Eg timer is ON, but it does not count time.

Either of methods do not work
cordova.plugins.backgroundMode.enable();
         cordova.plugins.backgroundMode.setEnabled(true);
cordova.plugins.backgroundMode.setDefaults(
             {

totally broken and breaks app and it is other plugins.

it seems dead,  would not suggest using it. Can not make it work for half of the day

some possible alternatives here:
https://github.com/EinfachHans/cordova-plugin-advanced-background-mode
https://bitbucket.org/TheBosZ/cordova-plugin-run-in-background/src/master/
the bitbucket's one is working for me, although both are a little bit outdated :-/
you can install them after cloning them in a local repository, by:
cordova plugin add /path/to/repository

cheers