[WIP][AIRFLOW-1960] Add support for attach secrets in kubernetes operator

Make sure you have checked all steps below.
JIRA

[x] https://issues.apache.org/jira/browse/AIRFLOW-1960

Description

[x] This add the ability to attach secrets with kubernetes-operator:

s = Secret('volume', '/test', 'airflow-secrets', 'key')

k = KubernetesPodOperator(namespace='default',
                          image="ubuntu:16.04",
                          cmds=["bash", "-cx"],
                          arguments=["echo", "10"],
                          labels={"foo": "bar"},
                          name="airflow-test-pod",
                          in_cluster=True,
                          task_id="task",
                          get_logs=True,
                          secrets=[s],
                          dag=dag
                          )

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[ ] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3271 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3271   +/-   ##
=======================================
  Coverage   75.78%   75.78%
=======================================
  Files         197      197
  Lines       14699    14699
=======================================
  Hits        11140    11140
  Misses       3559     3559

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67c0099...5c58b03. Read the comment docs.


Fixed newly introduced bar width bug

Introduced a bug in #1545, the width variable is used again later and shouldn't be overridden.

Happy to merge when the tests pass.


[binary] GET /services/{service_id} returns 404 on localhost

Testing the binary branch as Docker/web environment on localhost.
GET http://localhost:54321/v1/services/
=> 200
GET http://localhost:54321/v1/service/vicuna-7b-q4
=> 400 Not found
Steps to reproduce:
Prem Daemon, main branch
docker build -t premd .
docker run -it -v /var/run/docker.sock:/var/run/docker.sock -p 54321:8000 --name premd -e PREM_REGISTRY_URL=https://raw.githubusercontent.com/premAI-io/prem-registry/main/manifests.json --rm premd

Prem App

No env vars, all commented
yarn dev

@Janaka-Steph wrong url. You should point to /v1/services/{service_id}. You are missing an s.


scripts: patch: modify Interface Protocol to UVC1.5 for D555e

D555e is UVC1.5, modify manual patch for metadata format D4XX.

Can you please update the version here too?
We do have a version number for manual patches right?
For each distro?

@dmipx I now see this was not merged.
Can you please increase the version so we can close it?

@dmipx I now see this was not merged. Can you please increase the version so we can close it?

we have no versioning in manual patches.


Allows user to mark attendance of students

=== Still checking for bugs ===
New commands added

attendance <index>: navigate to session page of the group located at index, allowed at GROUP_PAGE
add session <session name>: add new session under current group, allowed at SESSION_PAGE
delete session <index>: deletes session located at index, allowed at SESSION_PAGE
mark <index>: mark student located at index as present, allowed at SESSION_STUDENT_PAGE
unmark <index>: mark student located at index as absent, allowed at SESSION_STUDENT_PAGE
back navigation from SESSION_PAGE and SESSION_STUDENT_PAGE

Let me know if you have idea on a better name for the commands!! :)
Implementation details

Session only has a sessionName and a hashmap Map<Student, Integer> attendance for marking attendance
Adding new students in Group will be propagated to Session under it
-Note: Deletion will NOT propagate yet (Should we?)
I removed students field from Session at the end since I realized it can be obtained from keySet of attendance
JsonAdaptedSession is unused class (but I only realized after writing it)
Keys and values of HashMap for attendance is stored separately, which might cause bug in the future. I'm still trying to find a better way to store it.
For example: (John, 0), (Alice ,1), (Bob, 0) will be stored as Keys: John, Alice, Bob and Values: 0, 1, 0

Here's how the json file will look like for a course cs2103 with 1 group T01 and a session tut1 under that group
{
  "courses" : [ {
    "courseCode" : "cs2103",
    "groups" : [ {
      "groupName" : "T01",
      "students" : [ {
        "name" : "John Doe",
        "phone" : "98765432",
        "email"<EMAIL_ADDRESS>        "studentId" : "A1234567X",
        "remark" : ""
      } ],
      "sessions" : [ {
        "sessionName" : "tut1",
        "keys" : [ {
          "name" : "John Doe",
          "phone" : "98765432",
          "email"<EMAIL_ADDRESS>          "studentId" : "A1234567X",
          "remark" : ""
        } ],
        "values" : [ 0 ]
      } ]
    } ]
  } ]
}

Closes #85
Closes #89


Elasticsearch

elasticsearch support for the app

Can we move these onto one line?
Instead of cursor: grab (which is used to indicate that you can drag items around), use cursor: pointer for the icons

What is "Show database options"? It doesn't seem to do anything when I click on it.

Nice! Works with https, http, locally, and remotely

I noticed that the descriptions don't show up unless you click on them. I don't think that behaviour is clear, especially considering that the user's first step didn't require them to click.
Can we just keep them expanded and remove their toggle-ability? I know it's verbose but that's better than people missing some critical set-up steps.

We can update this link to be https://plot.ly/alpha/workspace/?upload=sql now

For some reason, the app completely collapses when I try to connect to it

For some reason, the app completely collapses when I try to connect to it

I think we should make this a little bit more crystal clear that the user needs to enter https://connector.plot.ly:5000 or http://connector.plot.ly into this input box. Perhaps we can include it in the instructions?

Query data by clicking on 'import data' from plotly workspace and choose the SQL option. Enter https://connector.plot.ly:5000 into the input box.
Remember to keep this app running while you are making queries!

I think we should expand these placeholders a bit.

it's not totally obvious that username and password is their DB username and password and not their plotly username and password
they're also optional, but that's not necessarily clear
host sometimes includes http but sometimes it doesn't.

I think we should make these adjustments:

Add Elasticsearch Settings to the top of the form.
username => username (optional)
password => password (optional)
host => host e.g. http://localhost
port => port

looking good! a handful a minor things :)

[x] https://github.com/plotly/plotly-database-connector/pull/104#issuecomment-253102350
except extend the line across the top of the page
[x] https://github.com/plotly/plotly-database-connector/pull/104#issuecomment-253103419
[] https://github.com/plotly/plotly-database-connector/pull/104#issuecomment-253104202
[] https://github.com/plotly/plotly-database-connector/pull/104#issuecomment-253104400
[] https://github.com/plotly/plotly-database-connector/pull/104#issuecomment-253105135
[] https://github.com/plotly/plotly-database-connector/pull/104#issuecomment-253106616


Using AtomDisplay with Makerfabs 1920x480 IPS display with MIPI-HDMI Driver

Recently got a number of these displays link but cannot get them to work with the M5Stack AtomDisplay though I do see some artefacts displayed on the screen when I run some test code with Arduino IDE.  I know that they are 60Hz with a pixel clock of 66280000.  I can drive them with other HDMI sources such as my development Mac, embedded computers etc but not with the AtomDisplay.  I'm not a display kinda guy, I write industrial control and state machine code :-). Just wondering if these will work with the AtomDisplay and if so, any pointers to getting them to work?  Really appreciate any help + apologies if this is not the right place to post this question.
I'm using the AtomDisplay with PSRAM though I know this makes no difference so the controller is an ESP32 PICO-V3
Mark

Hello, @Daqaco .
I don't have that display, but presumably the correct resolution is 480 (width) x 1920 (height).
Try the following...
#include <M5AtomDisplay.h>

M5AtomDisplay display ( 480, 1920, 60, 480, 1920, 1, 1, 66280000 );

void setup(void)
{
  display.init();

// Set the display orientation
// 0 = 270 deg / 1 = normal / 2 = 90 deg / 3 = 180 deg / 4~7 = upside down
  display.setRotation(1);

  display.setTextSize(5);
  display.printf("Hello, ATOM Display !");
}

Have been in dialog with the supplier of the display and got some specs from them on the display and the HDMI-MIPI interface but no joy in getting an output.  I had read that the limit is 55,296,000 and 1920 x 480 x 60 is 55,296,000.  I'm going to source a couple of other interface boards to try out but for now I'll continue the development I need to do using a standard HDMI monitor which work really well with the M5Stack AtomDisplay.  Thanks for the help though!


NON-369 Prevent calling search when no non-associations are found

I'll add some tests in another PR

rather than forbidding calling a few functions with empty collections, i think it's much simpler to just return an empty response from the offender search service. how about this instead (including tests)?
#378


Unable to Match Regex since 3.4

FFXIV Patch 3.4 introduced ability tagging in the chat log (seen below)

Unfortunately, as a result, the log detection for triggering timers no longer works.
I've tried to define wildcards in my regex, but this does not resolve the issue.
Here's an example of a trigger I have setup. This worked without issue until patch 3.4

From patch3.4 now tooltip symbol is added to the front of the skill name.
Therefore, you must change the pattern of the regular expression.
Please try the following pattern.
You lose the effet of [.]{0,3}Spire Dawn.
パッチ3.4からはスキル名の前にツールチップ用の記号が追加されるようになりました。
したがって、それに合わせて正規表現のパターンを変更しなければなりません。
下記のパターンを試してみてください。
ツールチップ用の記号は文字ではありません。したがって、[a-zA-Z]ではマッチしないのです。

Hello.
I've had the same problem and tried that but it still doesn't seem to be working.
Any idea why?

Nevermind doing
You lose the effect of .*Spire Drawn
fixed it

Was able to resolve using:
You lose the effect of .* Drawn
Thank you

That's good !


[V1.1] Ensure in optimistic mode propagate is turned off

Problem
Ensure in optimistic mode propagate is turned off, SpokeConnector will not accept it and transaction will revert.
Impact
Reduce cost and have reliable operation of the the system in V1.1 Op Mode
Proposed Solution
Checks and retries to ensure both system mode is detected accurately
Acceptance Criteria
From an end user perspective, the below criteria must be met to consider this done:

[ ] LH Propagate makes the op mode check using subgraph data
[ ] LH Does not propagate when in op-mode

Merged into https://github.com/connext/monorepo/issues/4995
For better organization and sequencing of tasks


Feature/landing page

Summary
This PR introduces the landing page update. It also fixes the link issues when the the website deployed on custom base_url such as quadra/
Type of Change

Documentation update

Checklist
Please confirm that the following tasks have been completed:

[x] I have tested my changes locally and they work as expected. (Please describe the tests you performed.)
[ ] I have added unit tests for my changes, or updated existing tests if necessary.
[x] I have updated the documentation, if applicable.
[x] I have installed pre-commit and run locally for my code changes.

We need to review the selected logo, an issue on the home page with the firefox browser has been detected, we'll decide how important is to fix it as we don't have a huge frontend knowledge 😓


Add callbacks in file manager

On top of #1867

@zshipko If you're working on the dict problems. This PR implements some missing features that will surely help


[SW-106]  Accounts card

Adding tests.

the fixup commit contatins of this changes:

adjust border radius of a card
use proper tags
removed duplicate typography variables
adjusted weight and font-sizes
add letter-spacing for truncatedAddress
addjusted AeBalance component height and margins
remove link from a Account ${number} to a Register name page, not a link anymore
removed unused logic with customNames, shift of a background, colors
removed unused svgs
set actual links to the Transfer and Receive pages
set a cursor pointer for the whole card

if I choose a long name, then the darkening of the borders of the name will be visible on the account card. Is this ok, @paolomolo?

if I choose a long name, then the darkening of the borders of the name will be visible on the account card. Is this ok, @paolomolo?

Truncation of long .chain-names should be improved in another story. So it is ok like that for now. Thanks

This will also speed up the initialization.


Fix Macho Heather Mammoth - AccessControlFacet doesn't have ability to set admin for the role

Security audit reference issue:
https://github.com/sherlock-audit/2023-12-ubiquity-judging/issues/90

Let me tackle this one first.

but only submit the PR that will be reference to the issue on the audit judging repo

I thought we agreed to resolve the ones on the judging repository, as I understand that we are still deciding which ones are valid etc. Why are we making copies here? It can make things out of sync if issues are still being decided on.
I think we should only mirror the issues once they are closed as completed for archival purposes.


X.L.MultiToggle: Add function to query toggle state

I'm entirely aware that the approach I have taken here is pretty hideous, and as such will probably never be accepted into xmonad-contrib. The thing is that no matter how hard I tried I could not figure out another way to provide this functionality. I'm putting this here in the hopes that someone can come up with a better way, or perhaps to get confirmation that there is no real way around the gross hack that I've added here.

You're right that there's currently no good way to query a layout and I've done ugly hacks in my copy of xmonad-contrib to work around it too, e.g.: https://github.com/liskin/xmonad-contrib/commit/3b4ada866a0a6c20adf356e3b7f0b54ac16f9729
But in this particular case you only need one bit of information and you could possibly get that by using handleMessage directly:
sendQueryMessage :: Message a => a -> X Bool
sendQueryMessage a = do
    w <- W.workspace . W.current <$> gets windowset
    ml' <- handleMessage (W.layout w) (SomeMessage a) `catchX` return Nothing
    return $ isJust ml'

Don't export this function, though, as it throws the modified layout away and is thus only safe if the message did nothing interesting in the X monad. Then, in X.L.MultiToggle handleMessage, return if i == currIndex mt then Just mt else Nothing.

But in this particular case you only need one bit of information and you could possibly get that by using handleMessage directly:

Clever, but as you point out, this sort of code is also an abuse of handleMessage, is it not? I'm not necessarily sure that I think its any less hacky.
Shouldn't there be a nice way to query layouts in general?

Yes it's a horrible hack, too. :-)
There should be a nice way to query layouts, I think. I'm not sure if we should add something to LayoutClass or do it entirely in xmonad-contrib by creating an additional type class for querying and defining instances for ModifiedLayout, Choose, NewSelect, etc.

@pjones Do you want me to close this? I think that something definitely SHOULD be done about this, but I'm not really sure what the best approach is.

@IvanMalison closing it is up to you.  I haven't read enough about this issue to know what the right way of doing it is.  Perhaps open an issue and reference this PR before you close it.  That way it doesn't get forgotten.

I still think something ought to be done about this. I might file an issue, but am wondering if it should go against contrib or against xmonad itself. I think the cleanest solution would involve changes in xmonad.

I've done something in the general direction of this: https://github.com/xmonad/xmonad/pull/242, https://github.com/xmonad/xmonad-contrib/pull/398
It's already usable for querying the outermost ModifiedLayout, in my case WorkspaceDir: https://github.com/liskin/dotfiles/commit/6ea6c52aac4d39fa5a788372e005954715cb6d9a
If we wanted to dig deeper inside the tree of ModifiedLayouts and Chooses, we'd probably need to add another function to LayoutClass. I don't need that right now, but I think it'd be okay to do it.

A month passed and I have some additional progress:
XMonad.Layout.Inspect, a class for inspection of layouts and layout modifiers. Example of usage in X.L.WorkspaceDir and X.L.SubLayouts.
The relevant bits in my config are:
https://github.com/liskin/dotfiles/blob/a4140660ab0d83c7dc24378485ed7d8bda90d742/.xmonad/xmonad.hs#L406
https://github.com/liskin/dotfiles/blob/a4140660ab0d83c7dc24378485ed7d8bda90d742/.xmonad/xmonad.hs#L417
Also, I think your ugly trick with ExtensibleState can be made way less ugly by using IORef wrapped in a message: the query function creates an IORef, wraps it in a message, calls sendMessageWithNoRefresh, the layout handles the message by writing to the IORef, and then the query function reads the result and returns it. No need for permanent extensible state. It's still a bit ugly and it may not work with hacky layouts like SubLayouts that queue messages and process them later, and there are other things the layouts can do to break it, but it's simple. :-)

@liskin What is the status of this? Could we merge Xmonad.Layout.Inspect any time soon?

@IvanMalison I haven't managed to get to this since December so it's still more of a proof-of-concept than anything. The plan was to get back to it once the 0.17 release is out. It doesn't even have MultiToggle inspection at this point, but that should be like 5 more lines or something, I guess I can try to hack on that bit next week so that you can at least test it or something.

@IvanMalison I haven't managed to get to this since December so it's still more of a proof-of-concept than anything. The plan was to get back to it once the 0.17 release is out. It doesn't even have MultiToggle inspection at this point, but that should be like 5 more lines or something, I guess I can try to hack on that bit next week so that you can at least test it.

I'm happy to work on it myself. Just wondering what the state is/how much work is needed.

I'm happy to work on it myself. Just wondering what the state is/how much work is needed.

Even better :-)

(if you want to discuss something quickly, I'm<EMAIL_ADDRESS>or @liskin:matrix.org)

Also, I think your ugly trick with ExtensibleState can be made way less ugly by using IORef wrapped in a message: the query function creates an IORef, wraps it in a message, calls sendMessageWithNoRefresh, the layout handles the message by writing to the IORef, and then the query function reads the result and returns it.

Yeah, actually this seems like a pretty reasonable solution to me. Would you have a problem with merging something like that?

Would you have a problem with merging something like that?

Seems like a reasonable thing to do. The inspection stuff won't be ready for a while and you only export a function the implementation of which can be swapped any time. I'll take a closer look later today, hopefully.

Aligned the indent with the rest of MultiToggle and added docs/changelog. Will merge later in case you need to change something else.

Aligned the indent with the rest of MultiToggle and added docs/changelog. Will merge later in case you need to change something else.

Thanks!


tests: integration: test building flit_core

flit_core uses an in-tree backend
Signed-off-by: Filipe Laíns<EMAIL_ADDRESS>

On top of #81

Rebased on #81


Fixed typo

@er-knight Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@er-knight Thank you for signing the Contributor License Agreement!


fix requires for rpm

use lsb-core-noarch to avoid qt3 dependency
if we dependent on lsb. at CentOS7, it will require redhat-lsb, which require qt3(redhat-lsb -> redhat-lsb-desktop -> qt3).
In atom, they require lsb-core-noarch instead of lsb, which work on CentOS, Fedora and OpenSUSE.
use libXss.so.1 as dependency to install at OpenSUSE
If we dependent on libXScrnSaver, kitematic cannot installed at OpenSUSE(cause Problem: nothing provides libXScrnSaver needed by Kitematic......).
So we use require libXss.so.1 instead of libXScrnSaver.

@adomenech73  @bdharris08  PTAL :)


Migrating from Eric's to this one

https://github.com/ericleb010/hassio-addons
Hey, I was hoping to migrate to this version of the addon since it is a newer version. So I removed Eric's addon and installed this one. I can login to the oauth and see my devices on the network. I really didn't have to change my config entry. But now hassio doesn't see the media players as online at all.
Thoughts?

Did you use the matching custom component or are you still on the old one by ericleb010 ?
The process got changed in the term that hassio-addon and custom component need to be installed separately.

that seems to have fixed it. thanks. I deleted the custom component and added yours from HACS.


I don't  have the environment to reproduce the test anymore. I can reopen later if someone reports the same issue in the future.

I don't  have the environment to reproduce the test anymore. I can reopen later if someone reports the same issue in the future.
Originally posted by @nlgranger in https://github.com/NVIDIA/libnvidia-container/issues/48#issuecomment-632851411
#1546

ignore


"See Also" contains a broken link

The link for "Managed Service Accounts: Understanding, Implementing, Best Practices, and Troubleshooting" no longer works. I believe the correct link is: <https://docs.microsoft.com/en-us/archive/blogs/askds/managed-service-accounts-understanding-implementing-best-practices-and-troubleshooting>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 344b210a-650f-4f12-dd1c-4a20f6cf46eb
Version Independent ID: 176eade9-04bd-a656-fc2c-ba04c1c0aab2
Content: What's New for Managed Service Accounts
Content Source: WindowsServerDocs/security/group-managed-service-accounts/what-s-new-for-managed-service-accounts.md
Product: windows-server
Technology: security-gmsa
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

Thanks for the feedback. This link was corrected.
#please-close


feat(compiler-sfc): support defineAttrs macro

RFC

https://github.com/vuejs/rfcs/pull/477

Is there any difference between this PR and #7444?

Is there any difference between this PR and #7444?

If I understand correctly, this PR is for typed/inferring attrs with macro in <script setup> (SFC)
and this PR https://github.com/vuejs/core/pull/7444 is the same but for defineComponent or functional components (TS/TSX)

Is there any difference between this PR and #7444?

@sxzz This PR adds the defineAttrs macro to define attrs in the setup script, while another PR adds the attrs option to define attrs.

#7444 did the same thing (defineAttrs macro) before my review. As my review comment in #7444, I don't think it's necessary to introduce a new macro for attrs. Reusing useAttrs is enough for declaring types.
In you PR, defineAttrs will be replaced with useAttrs. So why not use it directly, without any transformation?
const attrs = defineAttrs<{
	bar?: number
}>()

Let's discuss in #7444 since they're basically doing the same feature.

Sorry, I was misled and thought these two PRs belonged to two different authors. (P.S hope to have a more detailed PR description in the future :P )
Compared to defineSlots, you're right. However, we need only one generic support, which means maybe adding a macro defineAttrs is enough. For non <script setup>, users can reach attrs by args of setup function, which already has the right type declaration.
defineComponent({
  setup(_, { attrs }){}
})

Sorry again! I should discuss this with you before giving review suggestions. Please hold on, I will discuss it with Evan for a final decision.

After discussion, we decided to do something similar to defineSlots.
useAttrs will not be changed, but add a defineAttrs<T>() macro.

I think this PR and #7444 can be combined into one. WDYT?

Of course. Thanks for your hard work


Linux Mint Cinnamon - Failed to load module "xapp-gtk3-module"

Occurs when launching Obliteration after freshly installing the flatpak, leading to the application to being on light mode instead of following the gtk theme.

@ultimaweapon Just saying, FTP worked properly on Mint! No limit error.

Try https://askubuntu.com/a/1417077.

The following packages have unmet dependencies:
 xapp : Depends: libxapp1 (= 2.2.8-1) but 2.6.1+victoria is to be installed
E: Unable to correct problems, you have held broken packages.

With #1140 this problem should automatically fixed.


Feat/comp styling

Adds ability for designers to describe fills/strokes on Component itself.

NOTE: this PR may fail tests since there are changes that need to be merge in PBDL first. See https://github.com/Parabeac/pbdl/pull/76 for more info.

TODO: Forgot to add testing for the other components I added into the Figma file for styling.


Breaks some shape keys

Uncertain as to why but every time I install the keyboard it scuffs out specific shape keys on the body mesh but not every shape key.

At this time the KAT system is setup with write defaults disabled. Unfortunately, avatar creators will need to design their animators with write defaults off. The technical reason for this is to eliminate the need to copy parameters using the animator itself, reducing the animator complexity greatly (by over 200x less animator transitions) which greatly improves in-game performance.
If VRChat developers implement a way to copy one parameter to another, I will create an option to have write defaults enabled.
The solution for now is to design your avatar with write defaults off in mind. This means you need to reset your avatar's facial blend shapes by setting them back to 0 after a facial animation is complete. I have attached an example animator for facial expressions.
FXLayer_WriteDefaultsOff_Example.zip

The new SDK has implemented the ability to copy parameters. This is now planned for implementation.


GridView not visible in GUI when Visibility of first GridViewItem is set to collapsed

Describe the bug
I am currently struggling with a bug or an unexpected default behaviour of the GridView in Cpp/WinRT. A minimal working example is given below. This code does not show the GridView at all.
Steps to reproduce the bug
XAML:
<Page
    x:Class="GridViewTest.MainPage"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:local="using:GridViewTest"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    mc:Ignorable="d">

    <Grid>
        <GridView x:Name="PartGrid" Loading="initGrid" Loaded="initGridGeometry" HorizontalAlignment="Center" VerticalAlignment="Center">
            <GridView.ItemTemplate>
                <DataTemplate>
                    <Rectangle Margin="20" Fill="Black"/>
                </DataTemplate>
            </GridView.ItemTemplate>
        </GridView>
    </Grid>
</Page>

Cpp-Header:
#pragma once

#include "MainPage.g.h"

namespace winrt::GridViewTest::implementation
{
  struct MainPage : MainPageT<MainPage>
  {
    MainPage();
    void initGrid(Windows::UI::Xaml::FrameworkElement const& sender, Windows::Foundation::IInspectable const& args);
    void initGridGeometry(winrt::Windows::Foundation::IInspectable const& sender, winrt::Windows::UI::Xaml::RoutedEventArgs const& e);
  private:
    const size_t numRows = 2;
    const size_t numCols = 2;
    std::vector<bool> gridVisibility = { false, true, true , true };
  };
}

namespace winrt::GridViewTest::factory_implementation
{
    struct MainPage : MainPageT<MainPage, implementation::MainPage>
    {
    };
}

Cpp-Code:
#include "pch.h"
#include "MainPage.h"
#include "MainPage.g.cpp"

using namespace winrt;
using namespace Windows::UI::Xaml;

namespace winrt::GridViewTest::implementation
{
  MainPage::MainPage()
  {
      InitializeComponent();
  }

  void MainPage::initGrid(FrameworkElement const& sender, IInspectable const& args)
  {
    std::vector<IInspectable> elements(numRows * numCols);
    auto partGridElements = single_threaded_observable_vector<IInspectable>(std::move(elements));
    PartGrid().ItemsSource(partGridElements);
    PartGrid().UpdateLayout(); // needed to initialize ItemsWrapGrid?
  }

  void MainPage::initGridGeometry(IInspectable const& sender, RoutedEventArgs const& e)
  {
    auto geom = PartGrid().ItemsPanelRoot().as<Controls::ItemsWrapGrid>();
    if (geom)
    {
      //define geometry: rows/cols
      geom.MaximumRowsOrColumns(numCols);
      geom.Orientation(Controls::Orientation::Horizontal);

      //define geometry: make grid elements invisible
      uint32_t k = 0;
      for (uint32_t i = 0; i < numRows; ++i)
      {
        for (uint32_t j = 0; j < numCols; ++j)
        {
          auto item = PartGrid().ContainerFromIndex(k).as<Controls::GridViewItem>();
          if (item)
          {
            if (!gridVisibility[k])
              item.Visibility(Visibility::Collapsed);
          }
          ++k;
        }
      }
    }
  }
}

Expected behavior
The idea is to be able to collapse some of the grid elements to create different patterns on this GridView. If one changes the vector gridVisibility = { false, true, true , true }; to gridVisibility = { true, false, true , true }; everything works perfectly and the corresponding grid element is collapsed. It seems that anytime the first GridViewItem is not visible, the whole grid disappears. Any help or suggestions would be highly appreciated. Thanks in advance!
Version Info
NuGet package version:
Microsoft.Windows.CppWinRT 2.0.200316.3

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)
Yes

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

@SynChLa
you should not have to call UpdateLayout on initGrid.
You can also set the ItemsWrapGrid properties in Markup
<GridView.ItemsPanel>
   <ItemsPanelTemplate>
       <ItemsWrapGrid Orientation=.. MaxRowsOrColumns=..  />

The issue is that you are trying to set the visibility of the container. ContainerContentChanging might be a better event to handle that because that will get called when containers are recycled.
Depending on what you are trying to achieve ItemsRepeater might provide you a simpler option because there is no container as part of it, so you can just bind the visibility to the data in that case or use the ElementPrepared event.

@ranjeshj
Thank you for the quick response. The number of columns and rows and the GridViewItem visibility are set flexible (by a user/file/server) during execution time. Therefore i can not define this information in XAML. As far as I understood your answer, you are suggesting a work around? Could you present further details on this? What should be handled on ContainerContentChanging? Does an ItemsRepeater offer the same functionality as a GridView. Can I set the number of rows/columns? It is essential that there are invisible (non-select able) grid elements between visible ones in a grid with defined number of rows and columns. Additionally scrolling in the grid is required.
In any case I would like to now if this is a bug or the expected default behavior.

The likely reason why you are seeing thing disappear is because you are setting visibility during initialize which gets called once, but the GridView recycles its GridViewItems, so it will not stay up to date when items are recycled. You will also need to set the visibility of GridViewItems in ContainerContentChanging event which gets called during recycling.
ItemsRepeater is more of a building block so it does not provide all the features of GridView, so it depends on what you need. UniformGridLayout has a MaxRowsOrColumns which might be what you need to use with ItemsRepeater. ItemsRepeater does not support selection out of the box, so you will have to do some work there.

@ranjeshj
I just added the ContainerContentChanging event. The behavior does not change and the problem remains.
Please note that the solution stated in the beginning works in all cases except those where the first item is set to collapsed. To me this definitely looks like a bug or an unexpected default behavior.
If possible i would like to stick with the GridView instead of implementing a separate solution. Otherwise i would basically just reimplement the GridView functionality by hand without knowing if this actually solves the problem.
So the questions remains: Is the GridView intended to behave like this or not?

Just tried the repro. The issue seems to be that you set visibility of the first item to false. ItemsWrapGrid uses the size of the first item to size all its items. Can you try setting  ItemsWrapGrid.ItemWidth/Height properties so that ItemsWrapGrid uses that to size its items instead of the first item ?

@ranjeshj
Thank you for the repro. I just tested your suggestion. Setting the ItemsWrapGrid.ItemWidth/Height in XAML does not work for me. But if I set it in the the Cpp Code it works. I just added the lines:
geom.ItemHeight(60);
geom.ItemWidth(60);
Of course I will have to add an extra resource in XAML to make the size settable there. Your suggestion will work for me as a work around. Thank you very much!
However i am still unsure if this default behavior is reasonable. Fixing the item size will work for me, but may not always be a possible solution. Maybe you can decide on that and close the issue if you don't think further work is necessary.

@SynChLa glad to hear that worked. ItemsWrapGrid sizing all its items based on the first item's size (by default) when ItemWidth/ItemHeight is not provided is by design.
Looking at the documentation for ItemsWrapGrid, that information is not clear. @anawishnoff can you please help update the docs here ?
https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml.controls.itemswrapgrid?view=winrt-19041
If your ItemWidth/ItemHeight is only available at runtime, setting it in code seems reasonable. If it is a constant or a resource, then setting it from markup should give you the same behavior.


feat(Blockbook): Removing support for Blockbook indexer

:tada: This PR is included in version 4.3.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add ER Diagram .dot file to src Directory

[x] We should commit the ER diagram's source file to the src directory so we have a copy and can edit it as the project changes.

[ ] We should also create a build command that builds the image and dumps it into the bin directory.  This'd probably do:
neato -Tpng -Goverlap=prism src/er-diagram.dot > bin/er-diagram.png

I posted the source file in the src directory.  I'm not sure how to do the build command, so I'll just update the image file using GraphViz whenever I change the source for now.

Run src/createErDiagram.sh to rebuild the ER diagram in the bin directory.
If you're okay with this, we can remove the diagram picture from the root directory.


Algebra issue#7 - String parsing

I added the parser and the lexer modules and exposed a method 'parse' in the algebra.js object to support string parsing in the suggested way:
var algebra = require("algebra");
var eqn = alegbra.parse("12x + 5 = 7");

Edit: The parser also allows decimal numbers as input. However the short notation for decimals between 0 and 1 i.e. '.5' for '0.5' is not supported.

Thank you, this is a great addition. And thank you for the tests. :+1:


*: several Notary subsystem adjustments, part 2

Waiting for the final decision on constants/limits.
Depends on #2378.
TODO:

[ ] Update interop dependencies right before the merge.

Can we rebase it to see the current list of remaining changes?

Can we rebase it to see the current list of remaining changes?

Yes, but I found one more bug in snapshot isolation and trying to test it for the C# node. After that I'll rebase it.

Speaking of valuable constants:

P2PNotaryRequestType payload type is still set to 0x50 (https://github.com/neo-project/neo/pull/2661#discussion_r810020207)
P2PNotary node role is still set to 128 (https://github.com/neo-project/neo/pull/2661#discussion_r810248536 and https://github.com/neo-project/neo/pull/2661#discussion_r880057682).

Speaking of the PR logic:

Notary deposit withdrawal is performed in two steps (Mint + Burn) (https://github.com/neo-project/neo/pull/2661#discussion_r824504252).

valuable constants:

Yeah, these can be very problematic long-term even though they're trivial to set once and forget. Thanks for raising this once again.

Notary deposit withdrawal is performed in two steps (Mint + Burn)

I'm sure it can and should be fixed. But it's not critical for long-term compatibility at the same time.


add a demo with no build requirement

Description of the feature request:
Nothing here inherently requires any build at all. we could simply host a folder, and be done, with any code edits directly applying just by saving the file.
There is no need for typescript/tsx/scss/react.     They are not making the project shorter, easier, or anything. They are just a legacy chain of dependencies forcing a 'build' for no reason.
If you really want fancy 'components' you can use a library that is based on modern HTMLElement components which don't need a build.
What problem are you trying to solve with this feature?
the problem is this app completely obscures the absolute simplicity of using the google api with a crufty old legacy buildchain.  The front end in particular should just be plain es modules and at most 3rd party component library that doesn't require build could be included.  As it is, it requires extra dependency and knowlege of React, Typescript, Scss, none of which are actual native web technology and none of which are providing significant value.  Sure a React/Typescript app may be populare, but a Javascript app is more appropriate as a demo and starting point for a wider variety of end results.
Any other information you'd like to share?
No response

Hi!
I understand the appeal of development using normal javascript modules, no build system and using web components; in fact I did release a small project for Gemini built that way - right here, usable here in AI Studio.
For this particular project, we determined that react/typescript/npm was the approach we wanted to move forward with. If you would like to build your own Multimodal Live API - Web Console without any of this, I would encourage you to do so and it would be really cool to see it!
cheers!

@AwokeKnowing, YAAYYY!!! Here you go: I did it!

@hapticdata, Sorry, can I ask a question? I implemented this in vanilla js but used this repository as a reference. I hope that I don't have to change my MIT license to APACHE 2.0 and then add a massive license chunks in every file as in your repo?

I did it!

this is amazing: cloned your repo, and ran it without any issue in 20 sec -:)


range queries for multiple clustering columns possible with Achilles?

First, thank you @doanduyhai for your work!
While writing a dsl().select() query for a table with multiple clustering columns, Achilles
suggested me a method that could range-query my 2 clustering columns:
manager
            .dsl()
            .select()
            .allColumns_FromBaseTable()
            .where()
            .partitionKey().Eq(2)
            .clustering1_And_clustering2().Gt_And_Lt(clustering1_Gt, clustering2_Gt, clustering1_Lt, clustering2_Lt)
            .getList();

which was surprizing because i've always been told that a such query is not possible.Indeed, while trying it, Cassandra and/or Achilles didn't take into account the 2nd clustering key, without getting any warning or exception from Achilles.
So my question is: is it a bug or is it here because it will possible to do such queries in a future release of Cassandra? Thx in advance
config:
Achilles 5.2.0
Cassandra driver 3.1.3
Cassandra 3.10

Look at the generated Javadoc on the method Gt_And_Lt ().
clustering1_And_clustering2().Gt_And_Lt(...) translates to
SELECT .. FROM ... WHERE partitionKey=2 AND (clustering1,clustering2) > ? AND (clustering1,clustering2) < ?
The tuple notation is allowed in Cassandra since a while

I was not aware of that "tuple" query. That's why I misinterpreted it like a multiple range query.
Thx for the clarification


add acme.sh and rename certbot to ssl_cert

Type of Change
Something Else: Added acme.sh commands to steps 3 & 6 as an alternative option to certbot for EN flow (If good international version will be committed afterwards)
What issue does this relate to?
resolves #277
What should this PR do?

Add acme.sh to steps 3 & 6 of ssl certification
Rename all instances of certbot to sslCert or ssl_cert in EN version.

What are the acceptance criteria?

Acme.sh commands work on local machine
Added UI elements still make the ssl_cert section look appealing and keep instructions not confusing

this should work. Furthermore acme.sh changed default CA to zerossl. We should probably add the parameter --server letsencrypt to force the use of letsencrypt.

i think it would be more userfriendly to take the bullet points near "Certification type" and choose weather you wanna have acme.sh, certbot or own certificate. That would reduce the overall shown information and in my opinion better user experience.

Sorry for the late response. I was away from my computer for a few days!
@xopez yeah I felt something like that might be better as well. Do you mean like making a row of buttons that allows the user to click which method they would like and display that certification flow?

@xopez yeah I felt something like that might be better as well. Do you mean like making a row of buttons that allows the user to click which method they would like and display that certification flow?

This is exactly what I meant 🙂

Hi y'all!
I think I am getting close resolving some of the issues and ideas brought up. But just a few questions!

Is adding the button flow idea proposed here in the scope of the issue? I love the idea, but just making sure that is okay to work on?
Is my git etiquette good so far? Sorry that I am bringing this up in a PR, but just want to know for future fixes and feature adding.

Sorry for the super delayed response, completely missed this!

Is adding the button flow idea proposed here in the scope of the issue?

I think for now, in this PR, we should stick to just adding the alternate acme.sh instructions. This can be augmented with a different flow in a later PR, but feels like this'd introduce scope creep and further complexity to this PR.

Is my git etiquette good so far?

Seems fine 👍 (Mine's evidently worse for missing your questions)

👋 Hey @fish-dango, any update on this?


Typo in parameter for html directory output

Simple mismatch in docs vs code

Thanks Vidar, I have completed the patch by fixing the typo in pgbadger usage() and rebuild the README with commit 2a1ece4.


requirements.txt: Move the six dependency into the general requirements

We've just noticed that deploying Nautilus with ceph-ansible stable-4.0 on Ubuntu Bionic breaks with:
Unexpected Exception, this is probably a bug: No module named 'six'

The fix looks pretty simple so here's a PR. :)
config_template.py relies on six, which isn't listed in the default requirements.txt. This previously frequently wasn't a problem, because six used to be a standard package being installed into a venv, and lots of other projects depended on it.
It also does get installed for unit and integration tests via tests/requirements.txt, so any broken dependency on six wouldn't be detected by tox runs.
However, as other projects and distributions have phased out Python 2.7 support the dependency on six becomes less common. To complicate matters further, some versions of virtualenv do install six automatically, others do not. To fix that ambiguity, as long as ceph-ansible does require it for config_template.py, add it to the base requirements.
This PR is for master but if accepted, it would probably make sense to cherry-pick this commit into the stable-* branches.

jenkins test centos-non_container-switch_to_containers

Hmmm... from the centos-non_container-switch_to_containers job log:
+ vagrant global-status --prune
Vagrant failed to initialize at a very early stage:

There was an error loading a Vagrantfile. The file being loaded
and the error message are shown below. This is usually caused by
a syntax error.

Path: /home/jenkins-build/build/workspace/ceph-ansible-prs-centos-non_container-switch_to_containers/Vagrantfile
Line number: 0
Message: Errno::ENOENT: No such file or directory @ rb_sysopen - /home/jenkins-build/build/workspace/ceph-ansible-prs-centos-non_container-switch_to_containers/vagrant_variables.yml
Build step 'Execute Scripts' marked build as failure
Archiving artifacts
Setting status of ebddbe5c1c443738d3e20ee2ac8890e0f33311c8 to FAILURE with url https://2.jenkins.ceph.com/job/ceph-ansible-prs-centos-non_container-switch_to_containers/2445/ and message: 'FAIL - centos-non_container-switch_to_containers
 '
Using context: Testing: centos-non_container-switch_to_containers
Finished: FAILURE

@guits: is it correct to assume that that failure is unlikely to have been caused by my change?

jenkins test jenkins test centos-non_container-switch_to_containers

jenkins test centos-non_container-switch_to_containers

Hmmm... from the centos-non_container-switch_to_containers job log:
+ vagrant global-status --prune
Vagrant failed to initialize at a very early stage:

There was an error loading a Vagrantfile. The file being loaded
and the error message are shown below. This is usually caused by
a syntax error.

Path: /home/jenkins-build/build/workspace/ceph-ansible-prs-centos-non_container-switch_to_containers/Vagrantfile
Line number: 0
Message: Errno::ENOENT: No such file or directory @ rb_sysopen - /home/jenkins-build/build/workspace/ceph-ansible-prs-centos-non_container-switch_to_containers/vagrant_variables.yml
Build step 'Execute Scripts' marked build as failure
Archiving artifacts
Setting status of ebddbe5c1c443738d3e20ee2ac8890e0f33311c8 to FAILURE with url https://2.jenkins.ceph.com/job/ceph-ansible-prs-centos-non_container-switch_to_containers/2445/ and message: 'FAIL - centos-non_container-switch_to_containers
 '
Using context: Testing: centos-non_container-switch_to_containers
Finished: FAILURE

@guits: is it correct to assume that that failure is unlikely to have been caused by my change?

that's correct, this is unrelated to your patch.

Ack, thanks. :)


Lazy compilation can fail when switching "routes" quickly

Bug report
What is the current behavior?
When using the experimental lazy compilation feature (in Storybook), when you change stories quickly (thus triggering many different lazy compilation jobs), sometimes the HMR for the lazy update can fail in various ways, which can lead to react-refresh errors or simply the whole app having to reload itself.
If the current behavior is a bug, please provide the steps to reproduce.
It is not entirely predictable, and I have not managed to reproduce outside of Storybook (yet), but this is a very very simple Storybook project and I think it is quite obvious the bug is in Webpack, but I am ready to be corrected ;)
https://github.com/tmeasday/storybook-lazy-compilation-webpack -- see the instructions from the repo.
The key point in this reproduction is that when a bunch of lazy updates are created on the server, the browser, which is otherwise doing nothing, will sometimes 404 on a hot-update.json request:

Note we have seen other (less reproducible) issues around HMR and lazy compilation, that you might see if you play with this repository, including:

Sometimes the storybook fails to load initially with a HMR error. This definitely seems to be a timing issue with when the auto-launched browser loads relative to the initial entries compilation (it happens maybe 10% of the time or less when I simply run rm -rf node_modules/.cache/ && yarn storybook and let the browser launch).

You can also trigger a bug by changing stories in the sidebar directly quickly while lazy compilation is going on (i.e. start SB, open up, change stories as fast as you can (you can use option-down and option-up to do this). However I cannot make this happen reliably enough to create a reproduction that would be useful. If you'd like to see what I mean I can likely get a screen recording of it happening at least.

What is the expected behavior?
Lazy compilation should be fairly transparent to the consumer, beyond import() requests taking a little longer than they otherwise might. If updates come over the wire from compilations triggered by other browsers, they should not fail.
Other relevant information:
webpack version:  5.70.0
Node.js version: 14.18.1
Operating System: MacOS
Additional tools: Storybook 6.5.0-alpha.48
NOTE
The tool we are using here to trigger the bug is the Storybook test runner, which opens the Storybook up in 4 separate, concurrent playwright instances, each of which will trigger a different dynamic (and thus lazy-compiled) import() statement.

do you using output.clean=true ?

No, I don't think so. You can see the full webpack config SB generates with yarn storybook --debug-webpack.

OK, I simplified the repro a lot and brought it out of Storybook!
https://github.com/tmeasday/webpack-lazy-compilation-repro-simple

yarn webpack serve
Open browser, ensure "preserve log" is on
Run all()
Notice logs:

GET http://localhost:8080/main.01ce74ce55d820aed88a.hot-update.json 404 (Not Found)
[HMR] Cannot find update. Need to do a full reload!
[HMR] (Probably because of restarting the webpack-dev-server)

@tmeasday still does not work with latest webpack?

@vankop I am not quite sure what happened 6 days ago in my comment above, but I came back to this today and tried it again, and it the reproduction above definitely does occur in 5.72.0.
It is a pretty simple reproduction so hopefully it should make the problem clear :)

@vankop I dug into this a bit and I think I have some more context on what is going wrong here, in case it helps. Apologies in advance for my lack of understanding of how HMR stuff works in detail.
So, just to reiterate, what's happening in the failing repro above is that we are import()-ing three files with a very small delay between each import.
Actually the issue can happen even when even importing two files with a delay, but it doesn't happen every time. It's interesting to see what happen when it does work vs when it does.

When the lazy compilation works, on the terminal (with all logging turned on), I see:
[webpack-cli] Compiler is watching files for updates...
[LazyCompilationBackend] /Users/tom/GitHub/Repros/webpack-lazy-compilation-repro-simple/a.js is now in use and will be compiled.
[LazyCompilationBackend] /Users/tom/GitHub/Repros/webpack-lazy-compilation-repro-simple/b.js is now in use and will be compiled.
[webpack-cli] File 'null' was modified
[webpack-cli] Changed time is Wed Feb 13 54385 03:50:43 GMT+1100 (Australian Eastern Daylight Time) (timestamp is<PHONE_NUMBER>843)
[webpack-dev-middleware] Compilation starting...
[webpack-cli] Compiler starting...
[webpack-cli] Compiler is using config: '/Users/tom/GitHub/Repros/webpack-lazy-compilation-repro-simple/webpack.config.js'
[webpack-cli] Compiler finished
[webpack-dev-middleware] Compilation finished

Notice in particular the two messages .... is now in use and will be compiled. that come in around the same time. This message is logged right before the lazyCompilationBackend calls compiler.watching.invalidate().
The two modules do not actually get "used" at the same time, there is a 2ms gap between them, but for whatever reason the new compilation triggered by the invalidate hasn't actually started yet.
On the client, on the HMR socket we see a really straightforward set of messages for a single HMR update and it all works fine:

When it doesn't work, it is because the compilation starts before the second invalidation:
[webpack-cli] Compiler is watching files for updates...
[LazyCompilationBackend] /Users/tom/GitHub/Repros/webpack-lazy-compilation-repro-simple/a.js is now in use and will be compiled.
[webpack-cli] File 'null' was modified
[webpack-cli] Changed time is Sun Feb 10 54385 23:26:14 GMT+1100 (Australian Eastern Daylight Time) (timestamp is<PHONE_NUMBER>174)
[webpack-dev-middleware] Compilation starting...
[webpack-cli] Compiler starting...
[webpack-cli] Compiler is using config: '/Users/tom/GitHub/Repros/webpack-lazy-compilation-repro-simple/webpack.config.js'
<w> [LazyCompilationBackend] Error: read ECONNRESET
<w>     at TCP.onStreamRead (internal/stream_base_commons.js:209:20) {
<w>   errno: -54,
<w>   code: 'ECONNRESET',
<w>   syscall: 'read'
<w> }
[LazyCompilationBackend] /Users/tom/GitHub/Repros/webpack-lazy-compilation-repro-simple/b.js is now in use and will be compiled.
[webpack-cli] File 'null' was modified
[webpack-cli] Changed time is Sun Feb 10 54385 23:26:32 GMT+1100 (Australian Eastern Daylight Time) (timestamp is<PHONE_NUMBER>192)
[webpack-cli] Compiler starting...
[webpack-cli] Compiler is using config: '/Users/tom/GitHub/Repros/webpack-lazy-compilation-repro-simple/webpack.config.js'
[webpack-cli] Compiler finished
[webpack-dev-middleware] Compilation finished

In this case, notice the "Compilation starting..." message is logged before the "...b.js is now in use and will be compiled." message. Ultimately this leads to the following messages over the websocket:

(Here's where I get a bit more hazy) -- what this means is that there are actually two "changes" in compilation -- we go from an initial hash, to a second hash with a.js, to a third hash with a.js and b.js. However, the HMR mechanism tries to fetch the hot-update.json based on the initial hash, after the compilation of the third hash, and it no longer exists in the dev server.
I am not sure exactly what the root problem is. I suspect that maybe the lazy compilation backend shouldn't (or shouldn't be able to) invalidate the compilation while it is compiling. Perhaps somewhere in the pipeline there should be a queue of invalidations that blocks on previous compilations?

@vankop FYI I implemented a workaround on SB's end by putting some pipelining/throttling in our client side code to avoid overlapping import() calls: https://github.com/storybookjs/storybook/pull/18432
To be clear, I don't think this is a great solution because
(a) it feels like it's the wrong place for the fix (it's crude as it doesn't really know when the compilation is done, it probably slows things down).
(b) it doesn't help if there is >1 client, which is the scenario from the original reproduction on this ticket (and is still an issue for us).
I wonder if the right solution is to add a similar throttle to this requestListener so that incoming requests are queued up and not handled until the compilation triggered by this invalidation is complete?
I tried it out and it did resolve the problem, although I did need to put a little delay in (>10ms <100ms) between one compilation finishing and the next one starting (I think because otherwise the HMR update gets invalidated before the browser has a chance to grab it, although I didn't dig in too much). I'm really unsure if this is the right approach or not (plus how I'd go about adding a test to webpack for it).

As a note we are still working around this problem in Storybook in a way which probably isn't ideal for performance: https://github.com/storybookjs/storybook/blob/15dd0ad6891e964f807a22e3e3827c0e7f599a1b/code/lib/core-webpack/src/to-importFn.ts#L50-L55

Something which I am facing too in my repo. Issue: https://github.com/storybookjs/storybook/issues/22706

same problem here with storybook 8

@emiliegervais we put some code into Storybook to work around the issue https://github.com/webpack/webpack/issues/15541#issuecomment-1374645955 -- is that code not working in your case?

@emiliegervais we put some code into Storybook to work around the issue #15541 (comment) -- is that code not working in your case?

I don't think that it is related to "switching routes quickly", more related to https://github.com/storybookjs/storybook/issues/22706 I guess.
I commented in this issue because the video in this comment is exactly what's happening : https://github.com/webpack/webpack/issues/15541#issuecomment-1562930837

@emiliegervais let me reopen that issue and we can discuss there.

@tmeasday Can you provide a reproducible test repo without webpack, I want to ensure it is a problem on our side, thank you

@alexander-akait

Can you provide a reproducible test repo without webpack, I want to ensure it is a problem on our side, thank you

When you say "without webpack" do you mean "without Storybook"?
I did create this repro a while back: https://github.com/webpack/webpack/issues/15541#issuecomment-1098860467 -- I haven't retested but can if it's helpful.

When you say "without webpack" do you mean "without Storybook"?

Yeah, sorry :smile:

I did create this repro a while back: https://github.com/webpack/webpack/issues/15541#issuecomment-1098860467 (https://github.com/tmeasday/webpack-lazy-compilation-repro-simple) -- I just retested it with<EMAIL_ADDRESS>and the bug remains.

Thank you I will look soon

Should we reopen this issue? We are having the same problem.


Login interface on https://coffea.casa is not available anymore

Authentification error is coming back from https://cmsaf-jh.unl.edu/hub/oauth_callback?xxx:
400 : Bad Request

OAuth state missing from cookies

cc: @clundst @jthiltges

Update: now it is just not available anymore, before going to production we probably need to switch to use https://coffea.casa and https://coffea-dev.casa

Fixed by @jthiltges, now login interface is available back, even if it is not working:
400 : Bad Request
OAuth state missing from cookies

We need in some moment switch to coffea.casa domain (authentication settings) and redirect users using https://cmsaf-jh.unl.edu to https://coffea.casa/: https://github.com/CoffeaTeam/coffea-casa-config/issues/42


[PHPStan] Prepare for PHPStan 1.6.x-dev

PHPStan 1.6.0 will remove parent, next, previous attribute from node on bleedingEdge feature toggles, while it only disable when bleedingEdge enabled, it may possibly be removed in the future, so I think it is better to prepare early.
We used the previous attribute check on CheckUseStatementsAfterLicenseRule for it:
https://github.com/codeigniter4/CodeIgniter4/blob/622d50aa2976b85f7cb1479faec7558cd9ec2341/utils/PHPStan/CheckUseStatementsAfterLicenseRule.php#L60
This PR is for draft and can be updated to use ^1.6 when PHPStan 1.6 released.
References:

https://github.com/rectorphp/rector/issues/7088
https://github.com/rectorphp/rector-src/pull/2014

Checklist:

[x] Securely signed commits

Thanks for being ahead of this!

PHPStan 1.5.6 released and backward compatible already conditionalTags on NodeConnectingVisitor already added.

PHPStan github action green 🎉 ref https://phpstan.org/blog/preprocessing-ast-for-custom-rules for config reference on PHPStan 1.6.0 that the compat can be configured via conditionalTags

I am merging it ;). Refs for same example applies:

https://github.com/symplify/symplify/pull/4029
https://github.com/rectorphp/rector-src/pull/2014


Array-like structure in forms implemented via FormArray extension

please also add appropriate section to readme

Demo files are untouched by this change. Please, recheck.

Then please add swagger definition that will generate the new structure in the demo app.


performance problem

I am making a chat application and use chatbubble with listview.builder, but the performance is very bad. In the emulator the performance is very nice but when i run the app in a rial device the performance is desastrous. Im use devtools to see a performance in device.
the device is a samsung galaxy j7 prime, (is my minimal device target).
This test was performed in a default application with only one Listview.Builder with 20 chatBubbles.

Do you still have this problem?

Yes, major performance issue

Yes, major performance issue

I created the chat widget in flutter. You can easily modify it. https://arkapp.medium.com/chat-bubble-widget-for-flutter-95d3bb82ddd8


Improve startup performance related to workspaceContains activation event

Related to https://github.com/microsoft/vscode-azurefunctions/issues/2654, we have to search the whole workspace or debugging could fail. As the VS Code team put it:

Using workspaceContains:**/... will start a search across the user's full workspace which may use a lot of CPU. And, if this search takes longer than 5s, the search will be canceled and your extension will be activated anyway.

Ideally we find a better way to activate. Some new activation events that could help from VS Code:

An event based on a VS Code setting (probably "azureFunctions.projectSubpath") - already tracked in https://github.com/microsoft/vscode/issues/55299
An event based on the task provider, in our case "func"

Alternatively, could the depth be limited? We use this technique for VSIX extensions in Visual Studio for manifest discovery. IIRC, the max depth is 3 which made a huge difference. Perhaps the max depth could be specified by the extension, with a user-specified/default max.

@heaths I think maybe you meant to comment on a VS Code issue? This repo is for an extension for VS Code, not VS Code itself. Our issues and the Rust issue are definitely related, but we can't fix it for y'all haha
Fwiw, you might be able to replicate a depth-limit yourself by listing multiple activation events like:
workspaceContains:*/example.txt
workspaceContains:*/*/example.txt
workspaceContains:*/*/*/example.txt

You're right. 🤦♂ I saw microsoft/vscode and failed to read the rest. But, yes, that might be a good workaround.

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!


HARP-5371: DataSource exposes getter/setter for storage level offset.

This allows to update and read this property via MapView and thus
control level offsets in demo app.
WebTileDataSource should use default level offset set to -1 which
corresponds to 512 tile sizes used.
Signed-off-by: Krystian Kostecki<EMAIL_ADDRESS>

@heremaps-bot ok to test


Enable BMW component to be unit system aware

Description:
Allow BMW component to convert units to imperial or metric depending on what is passed in to the component config.  If nothing is passed in to the component's config then the HA config's unit_system will take effect.
Pull request in home-assistant.io with documentation (if applicable): https://github.com/home-assistant/home-assistant.io/pull/6560
Example entry for configuration.yaml (if applicable):
bmw_connected_drive:
  name:
    username: user_email
    password: user_password
    region: north_america
    unit_system: imperial

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[X] Documentation added/updated in home-assistant.io

what is a use case for this?

what is a use case for this?

@balloob the API that is used in this component returns data in metric.  This PR enables the ability to change those values to imperial units if the use desires.  I like being able to see my data in gallons and miles like I'm used to instead of Liters and Kilometers.

If that's the case, we should not make it configurable but just use the Home Assistant configured unit system.

@balloob That's what I did at first and then saw that components like NOAA
had a unit_system in their config and then if it wasn't provided they
fell back to the Home Assistant config.
I can change it back to just the Home Assistant config if that's more
suitable.
On Mon, Oct 8, 2018 at 8:38 AM Paulus Schoutsen<EMAIL_ADDRESS>wrote:

If that's the case, we should not make it configurable but just use the
Home Assistant configured unit system.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/17197#issuecomment-427816122,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABATkNrJ-2lIIGG3p_kFAS_xjDYKyTYNks5ui0csgaJpZM4XLebF
.

Let's start with just the HA config.

@balloob removed component's config and now relying only on HA unit_system config

@balloob all ready for another review.


Update digital subscriptions banner copy

What does this change?
The task was a simple copy update of the banner heading and first paragraph to match the banner that is currently live.
When I was comparing the banner to the designs, it was clear that the image sizing wasn't correct across all breakpoints and that it was a bit hard to manage, so I have refactored it to make it easier to tweak in future.
Link to trello card
Link to designs
Images

Hi @lucymonie, it looks like the copy in the PR isn't the latest copy that was released last weekon frontend: https://github.com/guardian/frontend/pull/22811

@lucymonie, it looks like the copy in the PR isn't the latest copy that was released last week on frontend: guardian/frontend#22811

😱  Thanks for flagging.


Does not work on Firefox mobile

Hello !
firstable thank you for your tremendous job, it really help.
Unfortunatly it seems that firefox mobile doesn't catch the width and height the same way the other browsers do.
does anybody have the same problem ?
thanks for helping !

@precu did you resolve this issue and is it still relevant?

i presume this is solved now. FF mobile surely doesnt need the polyfill.


Make triggerAsyncCaching best effort

Codecov Report

Merging #13064 (38091b1) into master (f5a5ea7) will decrease coverage by 0.06%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master   #13064      +/-   ##
============================================
- Coverage     43.80%   43.74%   -0.07%
+ Complexity     8851     8828      -23
============================================
  Files          1348     1348
  Lines         77378    77377       -1
  Branches       9394     9394
============================================
- Hits          33892    33845      -47
- Misses        40616    40643      +27
- Partials       2870     2889      +19

Impacted Files
Coverage Δ
Complexity Δ

.../java/alluxio/client/file/AlluxioFileInStream.java
75.82% <50.00%> (+0.47%)
40.00 <2.00> (ø)

...mmon/src/main/java/alluxio/underfs/UfsManager.java
68.18% <0.00%> (-13.64%)
0.00% <0.00%> (ø%)

...on/src/main/java/alluxio/collections/LockPool.java
73.40% <0.00%> (-7.45%)
14.00% <0.00%> (-1.00%)

...va/alluxio/master/AbstractLocalAlluxioCluster.java
72.65% <0.00%> (-3.13%)
24.00% <0.00%> (-1.00%)

...c/main/java/alluxio/proxy/AlluxioProxyProcess.java
62.79% <0.00%> (-2.33%)
8.00% <0.00%> (-1.00%)

.../main/java/alluxio/underfs/AbstractUfsManager.java
61.36% <0.00%> (-2.28%)
12.00% <0.00%> (-1.00%)

.../src/main/java/alluxio/underfs/UfsStatusCache.java
93.25% <0.00%> (-2.25%)
25.00% <0.00%> (ø%)

...on/src/main/java/alluxio/util/JvmPauseMonitor.java
76.92% <0.00%> (-2.20%)
19.00% <0.00%> (ø%)

...va/alluxio/underfs/UnderFileSystemWithLogging.java
20.70% <0.00%> (-1.76%)
19.00% <0.00%> (-1.00%)

...in/java/alluxio/worker/block/BlockLockManager.java
77.52% <0.00%> (-1.69%)
39.00% <0.00%> (-1.00%)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5a5ea7...38091b1. Read the comment docs.

alluxio-bot, merge this please


Support for macOS 12

Hello,
Could you please modify the script so that it can run on macOS 12 as well? Unless there is a limitation that wouldn't allow this to run on macOS 12 that I do not know of?
Thank you

Hey! Currently testing macOS Monterey support in my environment and will update the script once I've validated it works as expected. If you'd like to help test it, feel free to adjust the macOS version checks in a local copy of the script; relevant bits are here. Let me know how that goes!

Closing as duplicate of #72, but macOS Monterey support is on track to be implemented in the next release.


Update Gradle Plugins

In this PR we make 3 changes:

introduce the dependency for the AppEngine Gradle plugin;
remove the generate-descriptor-set plugin;
introduce the test output plugin.

The AppEngine plugin is commonly used all in the framework examples and tests, thus should be declared once.
The descriptor set file generation is now configured by the model compiler for out projects and for the Spine clients.
Test output plugin is a configuration of the Gradle test task. With its help, we make sure that the failed tests are properly logged. This ad-hoc solution should exist until Gradle has a proper support for the JUnit 5 test output.
Also, in this PR we mark the maps declared in dependencies.gradle in order to satisfy the IDEA check.

@armiol, PTAL.


copy -> strong ?

@interface AFStreamingMultipartFormData ()
** @property (readwrite, nonatomic, copy) NSMutableURLRequest *request; **
@property (readwrite, nonatomic, assign) NSStringEncoding stringEncoding;
@property (readwrite, nonatomic, copy) NSString *boundary;
@property (readwrite, nonatomic, strong) AFMultipartBodyStream *bodyStream;
@end
**copy -> strong

Dupe of #3916, I believe.


Add Zeioth/garbage-day.nvim

Repo URL:
https://github.com/zeioth/garbage-day.nvim
Checklist:

[x] The plugin is specifically built for Neovim, or if it's a colorscheme, it supports treesitter syntax.
[x] The lines end with a .. This is to conform to awesome-list linting and requirements.
[x] The title of the pull request is Add/Update/Remove `username/repo`  (notice the backticks around `username/repo`) when adding a new plugin.
[x] The description doesn't mention that it's a Neovim plugin, it's obvious from the rest of the document. No mentions of the word plugin unless it's related to something else.
[x] The description doesn't contain emojis.
[x] Neovim is spelled as Neovim (not nvim, NeoVim or neovim), Vim is spelled as Vim (capitalized), Lua is spelled as Lua (capitalized), Tree-sitter is spelled as Tree-sitter.
[x] Acronyms should be fully capitalized, for example LSP, TS, YAML, etc.

Thanks for the PR!


Walkthrough 1a

@witmicko Looks like there is merge conflicts with this PR now.

@dlabaj this is ready for review if you have some time.

@JameelB @aidenkeating addressed comments and squashed, that had dismissed your reviews


Add type hints for primitive functions

Fixes #230
I'm interested if you have any feedback on this @TomNicholas

I'm going to merge this as it's a big improvement, even though there's more to do.


Update max width for main container

This pull request updates the max width for the main container to ensure that the content is displayed properly on larger screens. Fixes issue #36

This is kinda what we wanted, but the background for the header bar as well as the footer should continue from side to side, with only the content being restricted in screen estate width.

Oh whoops lol
ok let me know which you like best and i'll push the changes
option 1

option 2

option 3

option 4


invalid configuration: kind and apiVersion is mandatory information that needs to be specified in all YAML documents

invalid configuration: kind and apiVersion is mandatory information that needs to be specified in all YAML documents

created master node using vagrant
logged in to master
"su -"
/vagrant/scripts/kubeadm-setup-master.sh
It asked for Oracle ID/pw, all good.
.......
Login Succeeded
./kubeadm-setup-master.sh: Setup Master node -- be patient!
./kubeadm-setup-master.sh: kubeadm-setup.sh did not complete successfully
Last lines of kubeadm-setup.log:
Checking br_netfilter module ...
Checking sysctl variables ...
Enabling kubelet ...
Created symlink from /etc/systemd/system/multi-user.target.wants/kubelet.service to /etc/systemd/system/kubelet.service.
Check successful, ready to run 'up' command ...
Waiting for kubeadm to setup master cluster...
Please wait ...

[ERROR] kubeadm init failed
invalid configuration: kind and apiVersion is mandatory information that needs to be specified in all YAML documents

Apologies for this.
We have merged a fix (#110) to support Kubernetes 1.12.6 which should have been published by now. Unfortunately the release has been delayed due to a new K8s CVE.
We haven't reverted the this fix as  Kubernetes 1.12.7 should be released any time soon.
I just added the k8s-1.12.5 branch in the repo before the #110 merge, if you refresh your local copy you can switch to this branch with
git checkout k8s-1.12.5

alternatively if you start from scratch you can directly clone that branch:
git clone https://github.com/oracle/vagrant-boxes.git --branch k8s-1.12.5

Let us know if this works for you

Superb, it worked like a charm. Thanks for quick response.


issue with importing

When i was importing it got an error. I have installed yeoman globally and tested another generator of it and works. It says "Cannot find module '../../lib/BotkitGreeting" when doing "yo botkit"

Hi @luisdiogo2071317,
You can use Botkit CLI instead to scaffold out a new project.

im just testing some bot templates from yeoman and that's the only one that got an error


"actin fusion focus assembly" missing parent

GO:1990819    actin fusion focus
Cellular Component
Definition
A focus at the mating projection tip where the cell wall is degraded during conjugation with cellular fusion. Actin filaments form an aster-like structure from this location. PMID:25825517
therefore
actin fusion focus assembly (GO:1904600)
Definition | Parents
The aggregation, arrangement and bonding together of a set of components to form an actin fusion focus.
should be part of
"conjugation with cellular fusion"
?

HI Harold,
could you add
GO:0000747    conjugation with cellular fusion
as a  part_of parent of
actin fusion focus assembly (GO:1904600)

done


Incorrect spreadsheet formatting

Both Bom and CPL files are compressed into a single column with all the information, makes this impossible to use

Disregard. Double checked some settings and it's fine

For future people: Make sure to tell the spreadsheet software to use "," as a delimiter when opening the BOM :)


[WIP]: ENH/TST: Integrate pytest plugin for enhanced doctesting

Work-in-progress, DO NOT MERGE
Reference issue

This PR is part of my ongoing internship at Quansight Labs, where I was tasked with building a reusable pytest plugin that provides enhanced doctesting for PyData libraries, specifically Scipy and Numpy.
It builds on the work done by @ev-br to split the refguide-check doctesting utility into a separate package: https://github.com/scipy/scipy/pull/16391.
What does this implement/fix?

This PR introduces a pytest plugin that facilitates the execution of doctests within Scipy's public modules through dev.py.
To execute doctests, you can run the following commands on the Scipy shell:
python dev.py doctest to run all doctests
python dev.py doctest -s {submodule} for running individual doctests within specific submodules.
Additional information

Pending Work

filter out all deprecation warnings
handle failures due to output formatting
handle syntax errors in numpy ufuncs
...

Looks like a great start @Sheila-nk !
Here's what I think next steps should be:

[ ] make sure doctesting run on CI
[ ] make sure the plugin collects a superset of refguide-check log; IOW that we are not missing objects
[ ] there are lots of doctest failures locally. This PR is currently missing filters and other customization from gh-16391, these may help somewhat. Other failures need investigating.
[ ] at least locally, I still need the env var, $ PY_IGNORE_IMPORTMISMATCH=1  python dev.py doctest
.
The external dependency on scpdt:
[ ] needs to get a better name (doctest_sp, doctest_scipy, scipy_doctest, something else?)
[ ] needs to get out of my GH
[ ] we need to decide on the way to use it: git submodule or optional test dependency
[ ] the noise in $ python dev.py shell && pytest --pyargs scipy needs filtering out

The CI failure is likely due to https://github.com/scipy/scipy/pull/18631 which has just landed. The failure is in refguide-check, so I wonder why it did not fail in the PR.
Anyhow, just pip install threadpoolctl or what else it needs.

The CI failure is likely due to #18631 which has just landed. The failure is in refguide-check, so I wonder why it did not fail in the PR. Anyhow, just pip install threadpoolctl or what else it needs.

Correct.
That PR adds threadpoolctl to the pip install command on config.yml:80, hence why it passes CI there. Pulling main should fix the issue here.

Now that the CI is actually testing things (yay!), can work through failures. Quickly looking at several of them:

Why is array event picked up here? It is not in the public API, so should not be even looked at with strategy="api".

 [doctest] scipy.datasets._fetchers.array ___________________
EXAMPLE LOCATION UNKNOWN, not showing all tests of that example
??? >>> np.array([1, 2, 3])
UNEXPECTED EXCEPTION: NameError("name 'np' is not defined")
Traceback (most recent call last):
  File "/home/circleci/.pyenv/versions/3.9.18/lib/python3.9/doctest.py", line 1334, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest scipy.datasets._fetchers.array[0]>", line 1, in <module>
NameError: name 'np' is not defined
/home/circleci/.pyenv/versions/3.9.18/lib/python3.9/site-packages/numpy/__init__.py:None: UnexpectedException

I would compare the runs with pytest and manual, to see what's going wrong.

This is legit: need to use raw strings, r"Standard normal cumulative distribution function $\Phi$, to shield backslashes:

  File "<doctest scipy.stats._qmvnt.phi[8]>", line 1
    ax.set_title("Standard normal cumulative distribution function $\Phi$")
                 ^
SyntaxError: invalid escape sequence \P

This is also an error in the docstring, which now need an explicit import numpy as np:

142         Sample spacing (inverse of the sampling rate). Defaults to 1.
143
144     Returns
145     -------
146     f : ndarray
147         Array of length `n` containing the sample frequencies.
148
149     Examples
150     --------
151     >>> signal = np.array([-2, 8, 6, 4, 1, 0, 3, 5], dtype=float)
UNEXPECTED EXCEPTION: NameError("name 'np' is not defined")

This one needs parse_namedtuples=True in the DTConfig, needs investigating why it is False:

E   NameError: name 'DescribeResult' is not defined

is easiest: the function itself is deprecated, add to the filter

Maybe try copy-pasting the exact output?

Is it really legal python? Try running the example in a python shell.

Browsing through the CI log, I really like this one:
211 Construct a 1000x1000 `lil_array` and add some values to it:
212
213 >>> from scipy.sparse import lil_array
214 >>> from scipy.sparse.linalg import spsolve
215 >>> from numpy.linalg import solve, norm
216 >>> from numpy.random import rand
217
218 >>> A = lil_array((1000, 1000))
219 >>> A[0, :100] = rand(100)
220 >>> A[1, 100:200] = A[0, :100]
UNEXPECTED EXCEPTION: NotImplementedError('We have not yet implemented 1D sparse slices; please index using explicit indices, e.g. `x[:, [0]]`')
Traceback (most recent call last):
  File "/home/circleci/.pyenv/versions/3.9.18/lib/python3.9/doctest.py", line 1334, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest scipy.sparse[12]>", line 1, in <module>
  File "/home/circleci/repo/build-install/lib/python3.9/site-packages/scipy/sparse/_lil.py", line 150, in __getitem__
    return IndexMixin.__getitem__(self, key)
  File "/home/circleci/repo/build-install/lib/python3.9/site-packages/scipy/sparse/_index.py", line 53, in __getitem__
    self._raise_on_1d_array_slice()
  File "/home/circleci/repo/build-install/lib/python3.9/site-packages/scipy/sparse/_index.py", line 40, in _raise_on_1d_array_slice
    raise NotImplementedError(
NotImplementedError: We have not yet implemented 1D sparse slices; please index using explicit indices, e.g. `x[:, [0]]`
/home/circleci/repo/build-install/lib/python3.9/site-packages/scipy/sparse/__init__.py:220: UnexpectedException

So this looks like a genuine glitch in the documentation, which adverteses something not yet implemented?

I have been able to filter out DeprecationWarnings and somehow the Syntax errors from numpy ufuncs fixed themselves with the merging of this PR: https://github.com/ev-br/scpdt/pull/103
I will now focus my efforts on the output formatting errors.

I still see the DeprecationWarnings locally with this version, should we pull in https://github.com/ev-br/scpdt/pull/103 to this PR? (I also edited the PR description to list the correct incantation for accuracy.
@Sheila-nk please let me know if you need help with anything here!

I still see the DeprecationWarnings locally with this version, should we pull in https://github.com/ev-br/scpdt/pull/103 to this PR? (I also edited the PR description to list the correct incantation for accuracy.

Hmm, I wonder if it could be that you need to install the most recent version of scpdt since we have not listed the plugin as a scipy requirement so for now you might need to install it manually:
pip install git+https://github.com/ev-br/scpdt.git@main

please let me know if you need help with anything here!

Yes, I wonder if the current approach to manually change the tabs to spaces is fine, I remember you and @ev-br had mentioned something about a sphinx extension?

For tabs->spaces I would very much recommend a low-tech solution. Just change them manually once and be done with it.

Looks like you need to merge and update the git submodules. This worked for me locally:
git checkout main
git submodule update
git checkout integrate-plugin
git merge main
cd scipy/_lib/unuran
git merge 1d315c6
cd ../../..
git add scipy/_lib/unuran
git commit

Thanks @lucascolley 😄 it worked!

hmm these CI errors are strange, it looks like your branch has some discrepancies with main in terms of e3bbb6b15752681532e48af769e52f401cd55c14 - I think something has gone wrong when resolving merge conflicts.

Thank you @lucascolley for the review. Seems the refguide-check failures were due to the merge conflicts.

@lucascolley maybe you can help with the NameErrors?
I am unfamiliar with the functions and therefore do not know what the values of the variables could be.

___________ [doctest] scipy.stats._continuous_distns.reciprocal_gen ____________
8740
8741     %(example)s
8742
8743     This doesn't show the equal probability of ``0.01``, ``0.1`` and
8744     ``1``. This is best when the x-axis is log-scaled:
8745
8746     >>> import numpy as np
8747     >>> import matplotlib.pyplot as plt
8748     >>> fig, ax = plt.subplots(1, 1)
8749     >>> ax.hist(np.log10(r))
UNEXPECTED EXCEPTION: NameError("name 'r' is not defined")
Traceback (most recent call last):
  File "/home/circleci/.pyenv/versions/3.11.7/lib/python3.11/doctest.py", line 1353, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest scipy.stats._continuous_distns.reciprocal_gen[3]>", line 1, in <module>
NameError: name 'r' is not defined
/home/circleci/repo/build-install/lib/python3.11/site-packages/scipy/stats/_continuous_distns.py:8749: UnexpectedException

_______________ [doctest] scipy.stats._discrete_distns.zipf_gen ________________
1284            https://en.wikipedia.org/wiki/Zeta_distribution
1285
1286     %(example)s
1287
1288     Confirm that `zipf` is the large `n` limit of `zipfian`.
1289
1290     >>> import numpy as np
1291     >>> from scipy.stats import zipf, zipfian
1292     >>> k = np.arange(11)
1293     >>> np.allclose(zipf.pmf(k, a), zipfian.pmf(k, a, n=10000000))
UNEXPECTED EXCEPTION: NameError("name 'a' is not defined")
Traceback (most recent call last):
  File "/home/circleci/.pyenv/versions/3.11.7/lib/python3.11/doctest.py", line 1353, in __run
    exec(compile(example.source, filename, "single",
  File "<doctest scipy.stats._discrete_distns.zipf_gen[3]>", line 1, in <module>
NameError: name 'a' is not defined
/home/circleci/repo/build-install/lib/python3.11/site-packages/scipy/stats/_discrete_distns.py:1293: UnexpectedException

maybe you can help with the NameErrors?
I am unfamiliar with the functions and therefore do not know what the values of the variables could be.

Hmm I could find values that work but not sure what the ideal values would be, probably best to ping @andyfaff as codeowner / @mdhaber

superseded by gh-20127 (thanks Sheila!)


⭐ Added number of stars to readme

Here is a small script that embeds actual star count into readme generation.
I found it quite useful to see, how popular the library is.
Enjoy! ⭐

          1 Warning

:warning:
Please rebase to get rid of the merge commits in this Pull Request

  Generated by :no_entry_sign: Danger

@skywinder Looks very interesting, I'll review it in next few days. Thank you so much! 🚀

hello. is there any updates on this feature?

@skywinder We should think about moving this to a separate job(which we will run daily or weekly). I don't think it is a good idea to put it to CI job. Could you please think about possible solutions?

Im not familiar with CI. So I think you can leave this script aside and use it along with yml generation


Code Working Autonomous

We need to be able to place in the baskets and park in auto to be competitive. Preloading needs apriltags and a field wall that can take a beating to do so.

And april tags actually aligned

Update -> Logan is trying out Roadrunner, will keep posted as developments fall into place

https://www.youtube.com/watch?v=s7j_ja_DWQw

https://www.youtube.com/watch?v=rnrzQfSrHpo
Tuning guide if a video is wanted

Update: Preloading is tuning roadrunner, ran into a bump that needs to be looked at closer tommorow

Update. Retuning Roadrunner, hopefully should have most of the kinks sorted out tommorow. Then auto programming can properly start.

Update: Unflipped encoder, resulting in a proper auto that runs to 0,0. Will make basic parking auto before attempting more advanced auto after our meet

Will want different Auto such as
-> Blue Basket
-> Blue Obv Zone
-> Red Basket
-> Red Obv Zone
For ease of use + can test on one path so not all paths are compromised/ broken. Keeps the code cleaner as well


Child/children node streams optimisations

This PR fixes an issue that caused static nodes to be destroyed/re-inserted when the first child/children element was emitted.
It also ensures that no Seq.empty[VNode] is emitted at the beginning of the children stream  when a single children stream is present in the node (the common case).

Good that you noticed, fixed and provided tests to prevent these issues in the future. When the minor changes in the comments are addressed, I will approve. :+1:

Rebased and squashed commits.

LGTM. Thank you for working on this!


feat(sol): CW-20066 fix sign version transaction signature issue

Checklist:

README.md includes:

[ ] The details of signing data and transaction data, this includes parameters.
[ ] Official docs or white paper.
[ ] Website or api can query assets and broadcast transaction.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Task linked: CW-20066 Support SOL versioned transaction


capacity filter not working with incorrect format pk

Description
Some of the twins have an old incorrect format pk as '0x,' which does not work with deploying or capacity filtering and does not update like a null pk.

a fix is done on the rmb direct client. it will be applied on weblets once it's released

Verified on Devnet,
I used twin with ID 291 which have a wrong pk as 0x.

Once I logged into weblets and applied capacity filter, it works fine.

And pk was updated to correct value.


c11_atomics: Reduce the loopcounter for sequential consistency tests

Reduce the loop from 1000000 to 500000 since the former value makes the test run too long and cause system issues on certain platforms

Merging as discussed in the December 12th teleconference.
It would be good to create an issue to determine what the appropriate value for this counter is.  Could it be made even smaller?


Running the CLI inside of a Github action triggers an stdin warning

See the run here.

Run npx prettier --write .
Error:  UndefinedParserError: No parser could be inferred for file "stdin".
Error: Process completed with exit code 1.

Looks like something is falsy around this detection of TTY on GitHub runners (we've ran into other odd issues with that but I am struggling to find a quick fix).

Looks like this pull request fixes it - based off of this GitHub Actions thread.

I'm seeing this on my computer as of the last version update.

Does anyone have a repro that I can try locally? 🤔 "npx prettier --write ." doesn't do it for me.

This commit should fix it in the next release.

@fabiospampinato happy to help test this fix. Is there a pre-release available on npm yet?

@mareksuscak not yet, but I've asked the maintainers to make a new release, it shouldn't take too long.

@mareksuscak alpha10 just got released

@mareksuscak could you check if this fixes the issue for you? Thanks.


We've missing UINT16 & UINT8 macros.

          We've missing UINT16 & UINT8 macros.

Which means they're also missing from the testing suites.
Originally posted by @Ulrond in https://github.com/rdkcentral/ut-core/pull/29#discussion_r1587660765
Also missing assert test to support the new functionality
tests/src/ut_test_kvp_assert.c
static UT_test_suite_t *gpAssertSuite2 = NULL;
static UT_test_suite_t *gpAssertSuite3 = NULL;

void test_ut_kvp_assert_uint32(void)

fixed by cbf4224d7d476783cf4936bace814601a4d4c787 merged as part of the 2.1.2 release. #45


For a 0.3.6 release

#71

Codecov Report

Merging #72 into master will increase coverage by 7.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   91.70%   99.04%   +7.33%
==========================================
  Files           9        9
  Lines         205      209       +4
==========================================
+ Hits          188      207      +19
+ Misses         17        2      -15

Impacted Files
Coverage Δ

src/model_def.jl
100.00% <100.00%> (ø)

src/equality.jl
100.00% <0.00%> (ø)

src/metadata_utils.jl
100.00% <0.00%> (ø)

src/model_traits.jl
100.00% <0.00%> (+41.37%)
:arrow_up:

src/parameter_inspection.jl
100.00% <0.00%> (+50.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab2762...594e8c6. Read the comment docs.