Azure Service Bus Issue - The operation cannot be performed because the brokered message has already been consumed

I've been getting this exception on a daily basis:
[System.InvalidOperationException] Message: The operation cannot be performed because the brokered message '8b040000ff5a000319d808d4d38a3219' has already been consumed. Please use a new BrokeredMessage instance for the operation
I have dug a bit on the MassTransit codebase and found out that there is a retry policy when sending messages to the azure service bus (MassTransit.AzureServiceBusTransport.Transport.TopicSendClient).
One of the retried exception is the TimeoutException which looking at the documentation (https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-messaging-exceptions) does NOT guarantee that the process actually failed and the message was not delivered.
So, in the case we get this exception but the message was actually delivered, this brokered message already consumed would make sense, since the message was delivered the first time.
I'm not sure this is the origin of the issue, but that's my only guess at the moment.
A quick fix would be to force the new BrokeredMessages on each retry, but I'm not sure if that would be the best solution for the current design.
EDIT: Having another look at this: we can't blindly new BrokeredMessage again otherwise we may be sending the same message more than once. Not really sure how to proceed here. On our end, we're ignoring this exception since we know the message was delivered, but we're just hiding some issue.
Please let me know what you think or if someone has already had this issue.
Anyway, I'm happy to fix it on a PR if we agree on a solution.

Ran into this as well.  From my non-expert point of view, @andrefaceira's solution seems appropriate: catch and ignore the exception.  If the message actually got delivered, that counts as success IMO.
Here's a stack trace of the exception (MassTransit 3.5.6):
System.AggregateException:
System.InvalidOperationException:
   at Microsoft.ServiceBus.Messaging.MessagingUtilities.ValidateAndSetConsumedMessages (Microsoft.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at Microsoft.ServiceBus.Messaging.MessageSender.BeginSend (Microsoft.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at Microsoft.ServiceBus.Messaging.MessageSender.BeginSend (Microsoft.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at Microsoft.ServiceBus.Messaging.MessageSender+<>c.<SendAsync>b__40_0 (Microsoft.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncImpl (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at System.Threading.Tasks.TaskFactory.FromAsync (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at System.Threading.Tasks.TaskFactory.FromAsync (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at Microsoft.ServiceBus.Common.TaskHelpers.FromAsync (Microsoft.ServiceBus, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at MassTransit.Policies.PipeRetryExtensions+<Attempt>d__3`1.MoveNext (MassTransit, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b8e0e9f2f1e657fa)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at MassTransit.Policies.PipeRetryExtensions+<Retry>d__1.MoveNext (MassTransit, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b8e0e9f2f1e657fa)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at MassTransit.AzureServiceBusTransport.Transport.ServiceBusSendTransport+<MassTransit-Transports-ISendTransport-Send>d__5`1.MoveNext (MassTransit.AzureServiceBusTransport, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b8e0e9f2f1e657fa)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at MassTransit.AzureServiceBusTransport.Transport.ServiceBusSendTransport+<MassTransit-Transports-ISendTransport-Send>d__5`1.MoveNext (MassTransit.AzureServiceBusTransport, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b8e0e9f2f1e657fa)
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification (mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089)
   at MassTransit.Transports.PublishEndpoint+<MassTransit-IPublishEndpoint-Publish>d__7`1.MoveNext (MassTransit, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b8e0e9f2f1e657fa)
   at MassTransit.Transports.PublishEndpoint+<MassTransit-IPublishEndpoint-Publish>d__7`1.MoveNext (MassTransit, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b8e0e9f2f1e657fa)

Seems like the retry policy should filter out this exception.

Added a try/catch on this one, hope it helps.

I was wondering, is there a way to backport this fix to MassTransit v3.x using some public extensibility point? Maybe implement a custom IRetryConfigurator?

Sorry, let me rephrase. I'm not looking for a new MT v3 release. Instead, I'm trying to implement the same fix from 7b363315ce34bf2d60f599b4d570965ff69f0747 using public extensibility point provided by MassTransit. Thanks!

I see what you're asking now. I'm not sure the transport code is pretty low level, it would be hard to cut into it.

@phatboyg Did you find a good solution for this?


Fix PINDiskCache byteCount tracking

Decrease byteCount by file's previous byteCount if updating object already in cache.

Awesome! Thank you for this fix! Do you mind writing a test for this?

No problem.  Hopefully the test i've submitted is sufficient.

Yup! Thanks!

No trouble at all! Thanks!


Make DataFusion a reliable foundation for building query engines

from https://datafusion.apache.org/

DataFusion is an extensible query engine written in Rust that uses Apache Arrow as its in-memory format. DataFusion’s target users are developers building fast and feature rich database and analytic systems, customized to particular workloads. See use cases for examples.
“Out of the box,” DataFusion offers SQL and Dataframe APIs, excellent performance, built-in support for CSV, Parquet, JSON, and Avro, extensive customization, and a great community. Python Bindings are also available.

ibid.

DataFusion features a full query planner, a columnar, streaming, multi-threaded, vectorized execution engine, and partitioned data sources. You can customize DataFusion at almost all points including additional data sources, query languages, functions, custom operators and more. See the Architecture section for more details.

The two passages indicate dual nature of DataFusion
First, it's a complete query engine, with which users can interact e.g. using datafusion-cli (or dfdb proposed in https://github.com/apache/datafusion/issues/11979) or DataFusion's SQL and DataFrames frontends.
Second is what @alamb often refers to as DataFusion being "LLVM for query engines", a building block for other applications, where components are re-usable.
(See also https://datafusion.apache.org/user-guide/faq.html#how-does-datafusion-compare-with-xyz, https://datafusion.apache.org/contributor-guide/architecture.html and https://docs.rs/datafusion/latest/datafusion/index.html#architecture)
A query engine may implement a dialect of SQL that is identical with DataFusion SQL, or different.
DataFusion doesn't need to know the details of the query engine being implemented (it is extensible rather than being union of all the query languages). DataFusion needs to allow expressing different query languages, providing a reliable and dialect-agnostic foundation for applications building on top of DataFusion.
A query engine and a query language have certain attributes

language: syntax
language: scope resolution rules
language: type system, including coercion rules
language: function repertoire
engine: data sources
engine: access control
engine: observability

Internally, such a query engine transforms user queries (according to syntax, scoping, typing rules) into relational algebra operations, optimizes and executes them. Sounds simple, but in reality this is super complex and this is where DataFusion really shines.
This epic issue is a collection of tasks important for achieving this goal. Its description should be expected to be a living document.
On the high level, it aims at separation of concerns. The two roles DataFusion has -- an implementation of DataFusion SQL, a particular SQL dialect along and being reusable building block -- they should be clearly separated so that dialect-specific behavior isn't implicitly inherited by components needed to be dialect-agnostic.
Goals and Overview
As a result DataFusion should have the following layers
Frontend
DataFusion frontend includes DataFusion SQL - DataFusion's implementation of SQL.  DataFusion frontend also includes the DataFrame API.
It provides the following functionality

SQL frontend, with the syntax supported being a subset of syntax supported by the sqlparser crate that DataFusion SQL uses
the type system (currently Arrow data types (DataType) but that should change in https://github.com/apache/datafusion/issues/11513)
a repertoire of builtin functions
coercion rules required  to make the language useufl (i.e. the coercion rules that exists today)
performs function resolution (taking function repertoire, their signatures and coercion rules into account)
the frontend remains extensible e.g. by adding more functions or providing table sources.
it may support extending the type system (https://github.com/apache/datafusion/issues/12644)

DataFusion main
DataFusion "main" or "core" represents a dialect- and syntax-agnostic execution query engine library, for building query engines.
It serves as an API for all query engine implementors that decide to build on top of DataFusion.
It provides the following functionality

type system: a simplified version of Arrow DataType (https://github.com/apache/datafusion/issues/11513)

it is currently assume that allowing extension types (https://github.com/apache/datafusion/issues/12644), or totally different data types, is not necessary at this layer. The applications building on top of DataFusion will have to translate their type systems to that of DataFusion main
it should support annotating the DataFusion types with additional attributes or traits, so that custom optimizer rules can reason about them, or DataFusion type system gets reacher

for example, for a language with a constrained varchar type, a correct implementation of UnwrapCastInComparison for input CAST(a_number AS varchar(4)) > '1234' should check whether a_number can safely be represented in 4 characters (would the cast fail?). it clearly can't fail for eg int8 type, and clearly can fail for int32 type

plan IR (intermediate representation) with strict typing rules and no implicit coercions (e.g. for a = b types of a and b match exactly)
does not perform type coercions
does not use function signatures (the formal signatures of functions inserted into the plan must match exactly)
does not have a function repertoire (doesn't need it, since function resolution already happened), but may provide implementations of functions that are reusable by the Frontend layer, or by applications building on top of DataFusion
has simple (stripped down) expression language. For example is doesn't have to discern between IS NULL and IS UNDEFINED or have a Wildcard expression, since those things are handled by the frontend layer.
optimizers which take the the IR plan and produce an equivalent better IR plan
since it doesn't do scope resolution, it doesn't need a concept of aliases, but needs to preserve output field names externally assigned (e.g. by the frontend layer)
the DataFusion main remains extensible e.g. by adding custom optimizer rules, or custom plan nodes

DataFusion execution
It provides the following functionality

physical planning (ExecutionPlan, PhysicalExpr)
type system: a simplified version of Arrow DataType (https://github.com/apache/datafusion/issues/11513)

using Arrow DataType directly is also an option, but would prevent runtime-adaptive execution, see https://github.com/apache/datafusion/issues/12720, so simplified types would be strongly preferred, https://github.com/apache/datafusion/issues/11513

has no coercion rules
executes queries and produces results

Tasks
(Tasks to be added here once they are discovered and defined.)

[ ] as part of https://github.com/apache/datafusion/issues/12357, clearly document project goals (Work “out of the box” + Customizable everything)
[ ] introduce new simple DataFusion types: https://github.com/apache/datafusion/issues/11513
[ ] allow functions to accept types according to new simple DataFusion types (relates to https://github.com/apache/datafusion/issues/12635, but that issue goes far beyond that)
[ ] remove sqlparser dependency from all crates except datafusion-sql and datafusion-cli (it is OK to use for tests)
[ ] move analyzer out of optimizer and into the SQL frontend - analyzer plays supportive role towards a particular SQL dialect implementation and as such is part of the SQL frontend. It should not live inside the optimizer crate
[ ] separate implicitly typed expressions from explicitly typed expressions. The DataFrame API creates expressions directly and by its very frontendish nature they are not strictly typed, i.e. coercions are necessary. The IR layer needs expressions that have no implicit typing rules. The best approach would be to separate those expression hierarchies into two separate trees see also https://github.com/apache/datafusion/issues/12604.
[ ] split SessionState into "frontend SessionState" and "core SessionState": the layers build on each other, so every layer is concerned with runtime-relevant attributes such as RuntimeEnv, but only the frontend needs to know the function repertoire for example (https://github.com/apache/datafusion/issues/12550 seems related)
[ ] triage existing issues, cataloging them into frontend and core/main
[ ] split datafusion/core into frontend part and reusable part. the public crate name is datafusion which is perfect from a ready to consume frontend component, so maybe we could introduce core as datafusion-core crate
[ ] extend DataFusion core type system to better support building on top of it (see UnwrapCastInComparison example above) -- this is clearly vague and needs further specification
... surely much more ...

cc @alamb, @andygrove, @jayzhan211, @ozankabak, @notfilippo, @comphead, @sadboy, @milevin, @wizardxz

Thanks @alamb for your feedback! For https://github.com/apache/datafusion/issues/12644 i started to prototype a new type system that DataFusion could adopt, with assumptions that all types should be first-class citizens (so a trait Type rather than a enum Type). This obviously leads to type providers having to negotiate the coercion rules, but also makes creating core optimizer rules harder -- it would mean  the optimizer doesn't know actual types at all! I am pretty sure this is viable approach, but also pretty complicated. And it doesn't solve all the problems on its own, since at some point we need for "physicalize" the types into some common denominator. This remaining thing being exactly what this issue is about. Building a solid common denominator.

Let's put the exact mechanics (Tasks) aside, would be awesome to have agreement on the two things first:

do we want DataFusion to be a reliable building block for building query engines?
if yes, do we want to introduce an architecture supporting that goal?

do we want DataFusion to be a reliable building block for building query engines?

Well, I don't think there is / will be much debate about this goal as it is the same as the current goal, in my mind (or maybe I don't understand if it is meant to be different than the current goal)

if yes, do we want to introduce an architecture supporting that goal?

I look at it a little differently, which is "what features / extension points are missing to allow more building with DataFusion" -- like in my mind the current architure already supports this goal, though it has areas that could be improved (e.g. etendibel coercion, user defined types, etc)

I think #12622 is important if we want a nice function signature and coercion rule.

Thank you @alamb @jayzhan211 for your comments!

do we want DataFusion to be a reliable building block for building query engines?

Well, I don't think there is / will be much debate about this goal as it is the same as the current goal, in my mind (or maybe I don't understand if it is meant to be different than the current goal)

I do think this is the current goal.
However "an extensible query engine" != "LLVM for query engines". The current official documentation uses the former term. The latter is a bit more ambitious, requiring more predictable semantics.

I look at it a little differently, which is "what features / extension points are missing to allow more building with DataFusion" -- like in my mind the current architure already supports this goal,

Not fully. For example, the DF coercion rules are anywhere. The function signatures are consulted at various phases of the planning. Thus is someone wants to build a system without "everything is coercible to string" behavior, current architecture doesn't allow that.
It is probably easy to fix (conceptually) by defining the layers. The frontend layer (SQL parsing, analysis, creation of the initial plan) is responsible for function resolution and coercions. Beyond that layer we do not repeat same questions.

(e.g. etendibel coercion, user defined types, etc)

I think https://github.com/apache/datafusion/issues/12622 is important if we want a nice function signature and coercion rule.

yes to both! plus https://github.com/apache/datafusion/issues/12644
but even if we do all of that, we still run on top of Arrow for execution (which is not a bad thing), so we need a layer at which the (simplified) arrow types is the type system (simplified to allow https://github.com/apache/datafusion/issues/12720). The physical plans could be the only such layer, but it's a missed optimizations reuse opportunity, they are too physical already. Thus we need a logical plan layer where engines can integrate.
TL;DR
yes, i believe the goal here is inline with project goal.
let's have agreement that we want to invest in code structure / layers making DataFusion reuse reliable and with predictable semantics.

However "an extensible query engine" != "LLVM for query engines". The current official documentation uses the former term. The latter is a bit more ambitious, requiring more predictable semantics.

I think in my mind the goal is to be an extensible query engine and an LLVM for data intensive systems. Perhaps that is subtlety different 🤔

Thus is someone wants to build a system without "everything is coercible to string" behavior, current architecture doesn't allow that.

Pedantically I would probably phrase this as "the current code doesn't allow that" -- I think that by adding a suitable API it would be straightforward to allow user defined coercion rules. There may be different opinions on if that would be an architectural change, but I would say it isn't.

let's have agreement that we want to invest in code structure / layers making DataFusion reuse reliable and with predictable semantics.

It seems to me like there is broad agreement that:

More flexible (aka user defined) coercion rules would be good.
Support extension types  https://github.com/apache/datafusion/issues/12644 is good
Finding a way to support runtime DataType adaptivity https://github.com/apache/datafusion/issues/12720 would be good

Maybe we can treat these as three different features
At least one good next step is probably file a ticket describing what "user defined coercion rules" would look like

I don't want this ticket to be about flexible (aka user defined) coercion rules.
I believe this is necessary ingredient for https://github.com/apache/datafusion/issues/12644, but can also be tracked separately. My point is that for things like Extension Types (https://github.com/apache/datafusion/issues/12644) we need a lower layer which is stripped of those extension types. I don't think it's just physical layer, it would be missed optimizations opportunities cost.
So, with this issue my goal is not to take away any functionality, or forbid adding any functionality. Quite contrary, to allow more functionality to be added, with less breaking changes for downstream consumers, we need some form of "contracts." for various APIs we provide.
Highest level layer should provide all the bells & whistles. Lowest layer is Arrow vectors and kernels. Let's incrementally define the middle layer, as it will make reasoning about the code easier.
I hope there is no disagreement that more code structure, simpler code flow and well defined contracts is a good thing.

https://github.com/apache/datafusion/pull/13028 change  is a great supporting example for this initiative.
We have a language feature we want to expose in DataFusion (https://github.com/apache/datafusion/issues/9821), and due to how logical plan construction works today, this mostly-syntax-sugar feature affects logical plan structure, but it has no practical impact on logical plan expressibility, so from LP user perspective, it's a breaking change with no added value.
If we had clear frontend vs core separation -- as being proposed here -- downstream LP consumers would be not be affected by such changes.


Support for the Firefox >=48

Hello,
From the protractor docs, I see the statement 'For the moment, we recommend testing against FireFox 47.'
When can we expect protractor to support higher versions of Firefox?
In the interim, can protractor be used with any higher version of Firefox, if there are issues with the latest.

Closing this issue. This has been resolved a while ago. Also responded to the stackoverflow thread. https://stackoverflow.com/questions/57506688/protractor-support-for-the-firefox-48/57514513#57514513

The documentation still needs to be updated.


Gate.power()

A method on the Gate class to raise it to a power.
The base implementation is easy. Corner cases:
1 -> self
0 -> Identity (I'm not sure about this as identity currently implies wait).
-1 -> inverse
-2 -> inverse().power(2)
0.5 -> square root of gate

power(2) means returning a decomposable instruction, right?

power(2) means returning a decomposable instruction, right?

yep.

In that case, for the sake of type consistency, I think would be better to always return an instruction.

Supporting rational exponentiation requires root method. So, if #2811 is merged, this issue will be on hold, blocked by #2810.


Optional Typing support

Is there a plugin or a way to get this to work when using typing.  I write Angular2 in ES6/7 and have code that looks like this:
class MyComponent {
    constructor(el:ElementRef) { // not supported
     }
}

Ask on https://github.com/millermedeiros/esformatter. This is just a plugin for it.


Fix definition and parentage Ino80 complex (GO:0031011)

Definition |
A multisubunit protein complex that contains the Ino80p ATPase; exhibits chromatin remodeling activity ~and 3' to 5' DNA helicase activity~.
reason: Ino80 is a ATP-dependent chromatin remodelled, but not a helicase.
also remove  is_a
DNA helicase complex (GO:0033202)
@colinlog
@bmeldal
@pgaudet

Acc to PMID:10952318, Fig 3, it has GO:0043138 3'-5' DNA helicase activity.

I think it probably has in vitro, but it isn't now considered to be a helicase. @colinlog  is that correct?

10952318 Nature 2000, shows (weak?) helicase activity for the complex, but they do not pin it down to one of the ATPases (INO80, Rvb1 or Revb2). So, Birgits helicase annotation is a fine representation of the biochemistry performed by the INO80 complex (although it is perhaps a dubious report / an artifactual helicase assay activity documentation), but, I would defintely not use this paper to annotate Rvb1/2 nor Ino80 ATPases as possessing [intrinsic/physiologically relevant] helicase activity.
From https://elifesciences.org/articles/63042 (PMID:33205750) it is clear that no helicase activity is detected for Rvb1/2. Rather, Ruvb1 and RuvB2 appear to be protein complex shakers/assembly chaperones. One quote from the intro is "RUVBL1 and RUVBL2 are essential constituents of several large complexes. In various chromatin-remodeling complexes such as INO80 and SRCAP, these ATPases form a scaffold that organizes the architecture of other subunits in the complex (Aramayo et al., 2018; Eustermann et al., 2018; Feng et al., 2018). RUVBL1 and RUVBL2 also interact with RPAP3 and PIH1D1 proteins to form the R2TP complex, a HSP90 co-chaperone involved in the assembly and maturation of some large complexes including RNA polymerase II and members of the Phosphatidylinositol 3-kinase-related kinase (PIKK) family such as ATR, ATM, SMG1, and mTOR (Houry et al., 2018; Martino et al., 2018; Maurizy et al., 2018; Muñoz-Hernández et al., 2019; Rivera-Calzada et al., 2017). ". Altogether, at this point in time I do not know of other papers than the 2000 Nature paper by Carl Wu that demonstrated helicase activity either for Ino80 SNF2-type DEAD/H ATPase or for the Rvb1/2 AAA+ ATPase rings.
A chaperone/protein complex (dis)assembly activity that I would colloquially term 'protein complex shaking' is very likely for the Rvb1/2 rings.

So, in a nutshell, although there's weak in vitro evidence that a INO80 complex might have helicase activity it's not generally accepted to have it in vivo.
If that's the case, I'd happily remove it from the complexes.

That would be the careful conclusion, unless data to the contrary is found in the literature.

Ok, helicase annotations removed. Can always be added again if new evidence emerges.

The paper to look at for Rvb1/2 (Tip49a/b) helicase activity (and hexameric ring formation!) is PMID:18234224. What puzzles me is that in that paper the 5' to 3' helicase activity is strongest whilst in the other papers (including the Nature paper from 2000 PMID:10952318 as well as in PMID:10428817 and PMID:10336418 it was 3' to 5' activity that was highlighted and 5' to 3' that was considered weak. For sure, in PMID:18234224 the 3' to 5' helicase activity is weaker, and neither the Tip49 a only nor the Tip49b only reactions show any helicase activity.
All in all, I am still unsure what helicase activity to annotate, but from this paper (PMID:18234224), the Rvb1/Rvb2 (aka Tip49a/b) complexes would be 5' to 3' helicases.

How about "A multisubunit protein complex that contains the Ino80p ATPase; exhibits chromatin remodeling activity and in some species there is evidence for DNA helicase activity." ?
and remove the DNA helicase parentage.

I don't know so I asked  Rob DeBruin whose lab works on Ino80.
SGD description of Ino80 is
ATPase and nucleosome spacing factor; subunit of complex containing actin and actin-related proteins that has chromatin remodeling activity and 3' to 5' DNA helicase activity in vitro; promotes nucleosome shifts in the 3 prime direction; has a role in modulating stress gene transcription
It seems that the in vivo role is clearly nucleosome sliding rather than DNA unwinding.

I am assigning you, let me know if you want a different edit.

OK the person that I thought works on this complex does not.
But none of the high profile newer papers even mention a helicase role....
e.g.
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC8163841/

The most recent pombe paper that really digs into the function in vivo also does not mention helicase.
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5597579/
The Ino80 complex mediates epigenetic centromere propagation via active removal of histone H3
We should go with the current consensus.


Don't fill up to any old length of cache

Fixes #185
@maartenbreddels , could you please test?

That's OK, I don't think many people are suffering from this, especially since you can already turn off cache-filling.

@maartenbreddels , I am minded to merge this, what do you think?


au/countrywide updated for aug2018 release

Thanks a million for keeping this up to date @andrewharvey!


Add configuration suggestion to 'druid.indexer.storage.type'

Description
During the discussion of #11140 , we found that some users configured druid.indexer.storage.type to local in their production environment. This is not we expect.
Although all example configurations have set druid.indexer.storage.type to metadata, there's no configuration suggestion in the doc to describe which one should be used.
So this PR adds some text in the doc to give explicit messages to users which one should be used in production.
This PR has:

[X] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Overruling Travis - this is just a doc change


Add GitHub Pullrequest documentation

Fix: https://github.com/updatecli/updatecli/issues/488
I didn't introduce the concept of action as discussed here as it's not been implemented yet.
Signed-off-by: Olblak<EMAIL_ADDRESS>

Good job 👏


Include reporter templates in the wheel

Description
Fixes https://github.com/fonttools/fontbakery/issues/4479
Checklist

[ ] update CHANGELOG.md
[x] wait for the tests to pass
[x] request a review

thanks, @khaledhosny


[Bugfix] el-select multiple with vuex

Please makes sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

Fixing issue #2231

Thanks for contributing.
https://github.com/ElemeFE/element/blob/dev/packages/select/src/select.vue#L464
https://github.com/ElemeFE/element/blob/dev/packages/select/src/select.vue#L464
I think these two lines also need to be fixed. Could you take a look?

@Leopoldthecoder Both link points to the same line. Was the other line, 602?
https://github.com/ElemeFE/element/blob/dev/packages/select/src/select.vue#L602

@Phillys You're right. I made a mistake.


Put environment variables into own file

With the current docker-compose file to run it locally i have to alter files which are managed by git.
This creates some hazzle when i want to update to the latest version via git pull, which results in some merge effort.
I'd suggest to solve this by putting all the environment variables which need to be changed into an own file which is not managed by git.
I'd use a file called valheim.env which needs to be created before the first successful start.
We could also think about just having a standard .env file which is automatically used by docker-compose but that would mean that those variables are also set for the odin container which i deemed to be a downside.

[todo] I added one or multiple labels which best describes this PR.
[X] I have tested the changes locally.
[?] This PR has a reviewer on it.

Ok, downside is this now does not work in the tests.
If this change would be accepted in general, what would you suggest how to solve this?

Creating an empty valheim.env during those build checks?
Use a .env instead with the downside that those variables are also set for ODIN then?

Why dont you create a file called docker-compose.prod.yml for yourself to use?

could also be a way, yes, but still this would require some effort when upstream docker-compose file changes in keeping it up to date.
i'd just wanted to suggest this change, if you do not like it, i'm also fine, just wanted to make this as a proposal to maybe have it easier myself and also for others who use this repo for running their own valheim server.

There shouldnt be many changes to the base docker-compose outside of adding additional functionality 0.o
Btw if you are on a fork, you can use git stash to stash your changes before pulling the latest changes and then use git stash pop

I use a separate commit and then regularly do a t git fetch && git rebase origin
But ok, I then will find another way locally for me to minimize the adaptions.
Thank you for providing the containers in the first way!


Unable to use WezTerm as externalTerminal

Type: Bug
I'm trying to debug a terminal app written in Dart using WezTerm as the external terminal.
I've configured a launch.json file with a "console" set to "externalTerminal", see full config:
{
	"version": "0.2.0",
	"configurations": [
		{
			"name": "myApp",
			"request": "launch",
			"type": "dart",
			"program": "bin/myApp.dart",
			"console": "externalTerminal",
			"args": []
		}
	]
}

I've changed the external terminal to use on OSX to "WezTerm.app" in settings. The vscode/settings.json shows the following:
"terminal.external.osxExec": "WezTerm.app"

When i try to run the app i get:
Unable to start debugging: 'WezTerm.app' not supported

I originally created an issue in the WezTerm repo here, but i guess this is an issue with how you start the terminal.
Any help is appreciated.
Thanks!
VS Code version: Code 1.74.3 (97dec172d3256f8ca4bfb2143f3f76b503ca0534, 2023-01-09T17:05:47.808Z)
OS version: Darwin arm64 22.2.0
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Apple M1 (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
2, 2, 2

Memory (System)
16.00GB (1.45GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (18)

Extension
Author (truncated)
Version

vscode-monokai-seti
adi
0.0.7

multi-cursor-case-preserve
Car
1.0.5

dart-code
Dar
3.57.20230104

flutter
Dar
3.56.0

vscode-eslint
dba
2.2.6

copilot
Git
1.67.7944

copilot-labs
Git
0.7.632

haskell
has
2.2.2

pubspec-assist
jer
2.3.2

language-haskell
jus
3.6.0

dart-import
lua
0.3.1

rainbow-csv
mec
3.5.0

rose-pine
mvl
2.5.0

color-highlight
nau
2.5.0

vscode-yaml
red
1.11.0

even-better-toml
tam
0.19.0

ayu
tea
1.0.5

vim
vsc
1.24.3

(4 theme extensions excluded)

We would need to know the right args to use to launch this particular terminal, and I'm not sure we should hardcode that knowledge for every third-party terminal app.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Numpy implementation of both linear and nonlinear models

@C16Mftang,
I have added a directory named np_implementation, which contains modules related to numpy implementation of temporal PC for both linear and tanh functions. Additionally, I added three scripts that are relevant to reproducing plots in figures 5 and 6 of the paper.
Also, I made tiny changes to some of your bits hope that's OK.
Note: I refactored my code quite a bit to make it consistent and easier to follow. Also, I changed my plotting which is now similar to your plots. Tomorrow, I will update the figures in the manuscript with these new plots.
P.S. I plan to build an interactive web app containing the simulations and some useful notes. I will share the GitHub repository with you. In that repo, I will import this library to generate interactive plots and push them to the web.
Please let me know if you need anything.

Hello Mahyar thank you sooo much for doing this!!! Really appreciated that you made things consistent and it's looking really good now. I'm happy to merge now, just one tiny little thing to clarify: I noticed that you removed the importing of pytorch dependencies in scripts/tracking_inf_steps.py and src/models.py - why do we want to do this? Looks like we still need torch dependencies in these two files :)

Hello Mahyar thank you sooo much for doing this!!! Really appreciated that you made things consistent and it's looking really good now. I'm happy to merge now, just one tiny little thing to clarify: I noticed that you removed the importing of pytorch dependencies in scripts/tracking_inf_steps.py and src/models.py - why do we want to do this? Looks like we still need torch dependencies in these two files :)

Great, thanks Mufeng.
The reason I removed the imports in those files was because of this import from src.utils import * which is importing pytorch modules and functions from that file; thus importing again is redundant. If you try the files, you will see they work just fine :)

Thanks Mahyar! Sorry for missing those - will merge now


fix: beforeBreadcrumb hook

for some reason the beforeBreadcrumb calls inside the option extensions got swallowed somewhere

for some reason the beforeBreadcrumb calls inside the option extensions got swallowed somewhere

can we actually understand why its not working properly?

@marandaneto I meant that somewhere during a merge in the past those lines of code were removed. probably an oversight from my side.

@marandaneto I meant that somewhere during a merge in the past those lines of code were removed. probably an oversight from my side. (edited the original comment for clarity)

gotcha.


Missing raw_process.ipynb file

Hi, @PeterGriffinJin
Thanks a lot for the awesome work! We find your paper very interesting and the benchmark is really valuable to the community.
I am trying to run your benchmark following README. I downloaded the raw data, but cannot find raw_process.ipynb file as instructed. Would you mind sharing this file or sometime in future?
Thanks!

Hi there,
Thank you so much for your interest!
We have uploaded the raw_process.ipynb for each domain and modify the readme in https://github.com/PeterGriffinJin/Graph-CoT/tree/main/data.
If you want to run models on GRBench directly, you can refer to the instruction here (no need to run raw_process.ipynb):

If you are interested in how GRBench is constructed, you can go through the following sections.
Please feel free to let me know if you have any other questions!
Best,
Bowen

Thank you Bowen for uploading the processed graph data and the scripts!

An additional suggestion is maybe it is more convenient to also provide the reference solution paths for each question-answer pair, although it can be generated from the notebook with the processed graph files (which is huge). Thanks!


Fix canvas inspector exception with screen space canvases

Overview
Removed some duplicated canvas inspector code which was causing exceptions in some cases due to reflection. The vast majority of the code removed is now handled by asking Unity to create an editor instance for the canvas, which makes this code more robust to future Unity changes as well. Some MRTK-specific code was previously inserted in-line (mostly around disabling / not displaying certain fields in certain cases), which is no longer possible, but additional inspector warnings and context-specific configuration buttons were added for those cases (world space only for MRTK canvases and no camera should be set).
Changes

Fixes: https://github.com/microsoft/MixedRealityToolkit-Unity/issues/7522

/azp run


Added support for custom fields(username and password)

Please review this changes, I added support for SuperLogin custom login fields(username and password)

Part of the release 0.7.2


Only the head node has access to ssh.key.

This patch silence an harmless error in the logs.

OCD run https://ocd.appscale.com:8080/job/Daily Build/1353/

OCD run https://ocd.appscale.com:8080/job/Daily Build/1384/

Can we do a multinode cluster demo on this one?


Kanban board setup

Hello reviewer, thank you for taking time to review our project. Your feebacks and remarks are welcomed. Here are some steps we took to complete the project:

Here is the link to our project Catalogue_of_my_things Project
There are three members in our team: Manezeu Patricia, Fidelis Afimia and Mohamad Yaser
Here is the repartition of team members:

Team member 1 is @MohammadYaser
Team member 2 is @Izebiafe
Team member 3 is @patriciachrysy

Happy review

Hi @patriciachrysy, @Izebiafe and @MohammadYaser,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request

Kindly specify the link to the kanban project.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.

Hi @patriciachrysy, @Izebiafe and @MohammadYaser,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request

Kindly specify the link to the kanban project.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.

project link updated in the review

STATUS: APPROVED 🟢
Hi team,

Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
(Highlights) Good Points: :+1:

You documented your work professionally. ✔
The tasks have fairly been distributed between the team members. ✔
All tasks have a corresponding card with a clear description. 🎉 🎉 🎉 ✔

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


SAK-42762 Samigo: Latex question text alignment issue

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy


Feature request: URL for each page/artboard

Hi there,
The new UI is great, thanks for all the effort you’re pouring into this!
In the old UI, multiple HTML-files were generated per artboard. We generated Sketch Measure exports for all artboards on each page, page by page. We used this to our advantage by linking to specific artboards so that our dev team could easily reference specific parts of the UI.
In the new UI, it’s easy to generate exports for the full document. This great and saves us a lot of time and minimises the potential for errors. However with only one index.html file exported, we lost the ability to reference a specific artboard on a specific page by linking to it directly.
I fully understand that this way of exporting is much more efficient, but is there a way to add the ability to link to a specific page and/or artboard in de new UI? Perhaps by using anchor links and window.location.hash to trigger the selection of an artboard?

我也觉得，界面漂亮，好用。这个新版我一直没正式使用，没发现这个问题，多页测试了下，发现只生成一个文件，这样不方便以后替换单独页面，如果文件有100页，修改一页后又要全部导出一次，这样影响效率。再次感谢 utom 开发的产品！

Added and I close it

I notice now that when using the hash in the link, the left panel to switch artboards is hidden by default.  However, when you go to index.html, the panel expands by default.  Is there a way to fix that?


Adding page not working

Adding new page in notion database and publishing not working?
how to add new page ? or reorder the the pages ?

Could you provide more info on how you set the properties of your posts in Notion? For example, what is the value of the status property?
Nobelium respects the order of pages in the Notion Database. You can reorder your posts by reordering them in Notion.


No description provided

Added the new file

Added the new file

Files changes

Files changes

I created a branch, created a file and made a commit, and opened a pull request.

I created a branch, created a file and made a commit, and opened a pull request.

I created a branch, created a file and made a commit, and opened a pull request.

I created a branch, created a file and made a commit, and opened a pull request.

: created a branch, created a file and made a commit, and opened a pull request

: created a branch, created a file and made a commit, and opened a pull request


Specto Download to NAS Issue

Thank you for creating Specto !  And thank you for keeping the Favorites, My Specto!!
I haven't seen a topic about this, so I thought I'd better let you know about this.
On both Kodi Isengard and Jarvis, when setting the download location for Specto to my NAS (SMB Share), I can browse to it and select the share, but then it fails with 'Failure: Check Logs'.... At this point you cannot even launch Specto any more.
Once I get back into the addon settings again, through video addons, and set downloads to default, it works again.
Is this something that will be addressed in the near future? I'm anxious to get rid of Genesis altogether.

Also happens on mine :(

I know fixes can take time, but it would be great if I could just know that this has been seen, so I can wait for the fix.
Thanks

I've just posted a workaround for this. Hope it helps you as I was in the same situation. Mine is working fine now.

Resolved in #290


Complex Recipe Search

Hey, David from spoonacular here. Just wanted to let you know that we have a more thorough documentation now https://spoonacular.com/food-api/docs and the complex recipe search endpoint has been revisited. There are quite some new functionalities that you might find worth checking out and maybe adding to this project: https://spoonacular.com/food-api/docs#Search-Recipes-Complex (e.g. search within title)

Thanks for the heads up, David! The updated documentation looks really good. I'd be happy to add support for the new endpoints, I'll try to make time this week to update the package.

@ddsky the PR #7 switches to the Spoonacular API and adds support for the search recipes complex method. Thanks for letting me know about the changes!


Fix turbo config following a new turbo version

Turbo upgraded to a new version and made changes to its config file, we now use tasks instead of pipeline.
https://github.com/vercel/turbo/pull/8157
This upgrade fails PR builds as CI uses latest turbo version while locally we still use the old version.
This PR upgrades turbo and adjusts the config file.

I think we should also pin the major version of turbo, so there's never a mismatch in the future :)


test: add document replication test

link: #1457

kept all the smaller classes in a single test called replicatorMiscTest
link: #1858


SubprocessTest fails on Windows because it tries to execute ls command of bash

I should change Tests so that the check the type of OS (Mac/Windows) and switch bash/CMD as appropriate

v0.2.2 fixed this


Addon subtitle to video file name matching

Hi,
It has been almost a year since your issue to Stremio:
https://github.com/Stremio/stremio-addon-sdk/issues/221
I've wanted to know if this situation is still the same (filename is not present in Extra Paraemeters), or do you know if something has changed since then?
https://github.com/Stremio/stremio-addon-sdk/blob/master/docs/api/responses/stream.md
If not, then subtitles from Ktuvit/Wizdom addon are sorted in a different order than by matching to video file name?
Thank you!

Hey @TwilightMercy !
The Stremio devs haven't updated anything on their documentation so we can't really tell if anything changed for better or worse.
Since the last time this happened, the docs claimed one thing and in reality, something else was happening, we can't really know the situation until we check for ourselves.
Last time I had to resort to sniffing the packets from each client to find the difference between requests.
Let's hope we won't have to do that this time.
Either way, the logic to sort the subtitles by filenames is still present. If we get the filename then it works as expected, if not, well the user receives back an unordered list of subs.

Great to hear!


Investigating torch==1.10

Runs ok locally; let's check the pipeline.

Codecov Report

Merging #554 (94a9e4f) into main (72a3130) will decrease coverage by 5.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   90.61%   84.72%   -5.89%
==========================================
  Files          78       78
  Lines        4538     4538
  Branches      938      938
==========================================
- Hits         4112     3845     -267
- Misses        239      500     +261
- Partials      187      193       +6

Flag
Coverage Δ

unittests
84.72% <ø> (-5.73%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ummingbird/ml/containers/sklearn/tvm_containers.py
17.24% <0.00%> (-75.87%)
:arrow_down:

...mmingbird/ml/operator_converters/sparkml/linear.py
42.85% <0.00%> (-57.15%)
:arrow_down:

...bird/ml/operator_converters/sparkml/discretizer.py
52.94% <0.00%> (-35.30%)
:arrow_down:

.../ml/operator_converters/_linear_implementations.py
75.55% <0.00%> (-22.23%)
:arrow_down:

...ird/ml/operator_converters/onnx/one_hot_encoder.py
62.50% <0.00%> (-18.75%)
:arrow_down:

hummingbird/ml/_topology.py
67.79% <0.00%> (-17.38%)
:arrow_down:

hummingbird/ml/convert.py
65.40% <0.00%> (-16.59%)
:arrow_down:

hummingbird/ml/containers/_input_containers.py
87.50% <0.00%> (-12.50%)
:arrow_down:

...ml/operator_converters/sparkml/vector_assembler.py
90.00% <0.00%> (-10.00%)
:arrow_down:

...perator_converters/_discretizer_implementations.py
90.32% <0.00%> (-9.68%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a3130...94a9e4f. Read the comment docs.

Ok generating the new model with static dims makes the tests pass locally, but the test still hangs locally (meaning it prints the "warnings" summary",  and also hangs in the pipeline.
Ex:
test_extra_conf.py ........sssss............ssssssssssss                                                                                [100%]

========== warnings summary ===========================================
../../.local/lib/python3.7/site-packages/onnx/mapping.py:27
  /home/kasaur/.local/lib/python3.7/site-packages/onnx/mapping.py:27: DeprecationWarning: `np.object` is a deprecated alias for the builtin `object`. To silence this warning, use `object` by itself. Doing this will not modify any behavior and is safe.
  Deprecated in NumPy 1.20; for more details and guidance: https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations
    int(TensorProto.STRING): np.dtype(np.object)

../../.local/lib/python3.7/site-packages/sklearn/experimental/enable_hist_gradient_boosting.py:17
  /home/kasaur/.local/lib/python3.7/site-packages/sklearn/experimental/enable_hist_gradient_boosting.py:17: UserWarning: Since version 1.0, it is not needed to import enable_hist_gradient_boosting anymore. HistGradientBoostingClassifier and HistGradientBoostingRegressor are now stable and can be normally imported from sklearn.ensemble.
    "Since version 1.0, "

-- Docs: https://docs.pytest.org/en/stable/warnings.html
======= 20 passed, 17 skipped, 2 warnings in 7.08s =========================================

and then......hangs....forever. That was a new one.
I am not sure what to try next.  It only behaves this way for torch==1.10 on onnx tests on linux/mac.  Passes everything on Windows.  Passes everything if torch <1.10.

Adding
    @unittest.skipIf(
        sys.platform != "windows" or LooseVersion(torch.__version__) >= LooseVersion("1.10.0"),
        reason="See issue #554",
    )

to the tests also makes the 3 onnx symbolics all pass, but still hangs indefinitely, so there are some other problems here as well.


Support sync between docstring and readthedocs

What theme are we going to use? RST or Google? Actually, some existing doctstring are in RST style. Can we use both?


Fix type hints of parse_obj and similar methods

Change Summary
Methods like BaseModel.parse_obj() or BaseModel.copy() have their return type specified as BaseModel. Because of that, valid code like this:
from pydantic import BaseModel

class User(BaseModel):
    id: int
    name: str

u = User.parse_obj({
    'id': 11,
    'name': 'Acedia',
})

print(u.id, u.name)

does not type check:
example.py:12: error: "BaseModel" has no attribute "id"
example.py:12: error: "BaseModel" has no attribute "name"

This PR fixes that.
Related issue number

Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[x] HISTORY.rst has been updated

if this is the first change since a release, please add a new section
include the issue number or this pull request number #<number>
include your github username @<whomever>

Done.

awesome. Thank you very much.
I'll fix another thing and deploy in a day or two.


bug: Consecutive Buttons with ng-click, second button uses first buttons' ng-click

Type: bug
Platform: mobile webview
I'm having the exact same issue found here: http://forum.ionicframework.com/t/ng-click-not-working-with-two-consecutive-buttons/8123
Just creating an issue here for it. I'm using  v1.0.0-beta.14
http://codepen.io/anon/pen/cqKkI
Copied text from linked forum post:

I'm using two buttons with ng-click calling separate functions.
The first button works as expected, but when I click the second button, the first function is called. If you keep the second button clicked, you can see that both are down. Am I doing something wrong? I'm tested in both Chrome and Mozilla, both show this behaviour.
UPDATE: If you change to ng-mouseup it works. It appears ng-click is bound to the parent div. I'm actually using it inside a item-button so this might mess up (intentionally or not) with the events. Anyway, it would be nice to have ng-click working in this case but I'm glad ng-mouseup works (both in desktop and mobile).

Greetings, @kylethielk!
We are now requiring all issues to be submitted through our custom issue form so that we have all of the information necessary to fix them as quickly as possible.
Your progress on this issue has been saved at the following url:
link to Ionic issue form
This issue will be closed if not resubmitted through the form. Please fill out the rest of the form so that we may assist you.
Thank you for allowing me to assist you.

Just an update. I was able to work around this by wrapping each button in a

@kylethielk Don't keep the buttons inside the label for GENDER. label should be closed before the div which contains your buttons. This will cause the buttons to come in the next row, not side by side of the label. But putting the buttons div in the same row can be done using CSS.

@pulakb  They are not inside Gender's label. See here: http://codepen.io/anon/pen/rajJjQ

Greetings @kylethielk!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.

Hello! I'm getting the same issue as reported using IONIC 1.
This is the html template causing the issue:
        <button type="submit" class="button button-positive" ng-click="takePicture()">Take Picture</button>              <button type="submit" class="button button-positive" ng-click="browsePicture()">Open Gallery</button>
In fact the second button fire the same function as th first.
I managed to debug this and thank's to this post this is the solution: putting the two ng-click into two differents scopes.
       <button type="submit" class="button button-positive" ng-click="takePicture()">Take Picture</button>                        <button type="submit" class="button button-positive" ng-click="browsePicture()">Open Gallery</button>


Fix typo on TemplateSpec.md

TemplateSpec.md mentions that the developer should use ImplementsTemplateSpec. There is a typo here, as Implements should be singular as can be seen here.
This fixes the issue.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


Improve Discoverability of ADRs: Reference more ADR documentation

Is your feature request related to a problem? Please describe.
During some recent conversations with coworkers, ADRs were mentioned as a practice that plenty of crews use, but that they weren't sure whether this content was in the playbook.
It is, but the fact they didn't know means that we could probably do more to make this content more visible.
Describe the solution you'd like
I think the ADR section should get more attention at lower (and more) levels of the playbook. I'd like to add text recommending them wherever there is guidance around making technical decisions, especially in the documentation section.
Furthermore, during these discussions, there were some useful references:

The ADR organization github.
A sample provided.
A great initial resource.

The first seems like a great addition, the latter two could also be useful.
Describe alternatives you've considered
If we don't adopt this change, people will remain unaware of ADRs in the playbook. It's possible this will improve visibility of ADRs.
Additional context
N/A

just going through old issues and noticed this @zmmille2 is this something you want to PR or do you want someone else to add this, I'm happy to do it if you wont


Reset button state

Methods to support reset button disabling when there in no changes in editor

merged to dev


Emmet next/prev edit point should start with a verb

VSCode Version: Code - Insiders 1.13.0-insider (c2a17a7929259d3d2643cb3f98478e994a39605b, 2017-05-30T05:12:15.312Z)
OS Version: Linux x64 4.10.0-21-generic
Extensions:

Extension
Author
Version

EditorConfig
EditorConfig
0.9.3

lorem-ipsum
Tyriar
1.0.0

sort-lines
Tyriar
1.3.0

theme-sapphire
Tyriar
0.2.1

vscode-svgviewer
cssho
1.4.1

tslint
eg2
0.15.0

git-project-manager
felipecaputo
1.3.2

md-navigate
jrieken
0.0.1

vscode-scss
mrmlnc
0.6.2

seti-icons
qinjia
0.1.3

#27316
All other commands start with verbs, next/prev edit point start start with "Go to "

This wasn't fixed, I think you need to edit the strings inside the nls.localize too


Jukebox Songs 2 electric boogaloo

About the PR
Even more songs, not just Fallout ones this time. No shitposts
Why / Balance

Technical details

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: Hmeister
tweak: Jukebox now has even more songs!

me when I break the law
this is an insane amount of copyright infringement @Hmeister-real .....

me when I break the law
this is an insane amount of copyright infringement @Hmeister-real .....

We aren't upstream, this is the equivilant of someone modding terreria with uh Nintendo characters. Copyright laws do not apply to us

You sometimes could add copyrighted material in your own projects for private personal use, but Goob Station is a public open source github repository and free game. Just because we are a fork of WizDen's Space Station 14 does not mean copyright laws no longer apply to us. Unauthorized use of another's copyrighted work is copyright infringement.

We aren't upstream, this is the equivilant of someone modding terreria with uh Nintendo characters. Copyright laws do not apply to us

Whoever is modding terreria with Nintendo characters almost certainly doesn't have permission to use their characters and could get in big trouble from Nintendo. Also, it isn't like terreria is the one adding copyrighted Nintendo characters to their game, compared to here where we are indeed adding copyrighted music to the game. Imagine playing copyrighted songs as a musician versus if we add that copyrighted music directly to the game, that is a big difference.
Also, every song you have listed you wrote as being under the copyright CC-BY-NC-SA-3.0 yet there some quite clearly closed license songs such as "The Office Main Theme" or "Bloons TD 5 Deluxe". As well as all your sources are incorrect, it is just the Goob Station forums...
While I am not a lawyer or anything, I am 100% certain we can get in trouble for using copyrighted music and improperly licensed and credited music.

Closed due to yes, that reason. Might as well revert your other PR.


Fix the broken NuGet packages.

Our NuGet packages have been broken due to this PR:
https://github.com/microsoft/MixedRealityToolkit-Unity/pull/4858
Which updated assembly names, but didn't also update the corresponding nuspec files to ensure that they would continue to get copied over.
Thankfully, there was also this pretty sweet migration guide which makes it super clear where things moved: https://microsoft.github.io/MixedRealityToolkit-Unity/Documentation/UpdatingToGA.html

Thanks to @andreiborodin for fixing this - I'm just shepherding this in.

/azp run


Added network similarity types

Docs Build status updates of commit fa27f48:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

academic-services/graph/network-similarity.md
:white_check_mark:Succeeded

academic-services/graph/reference-data-schema.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


MicroPython

Is there any way to run it in MicroPython

Unfortunately I don't think so due to the dependencies tinytuya requires; PyCryptodome is the first one that comes to mind, and there may be others.

I had a TODO to look at the library ucryptolib but haven't had time yet. I don't know if it would work and/or how difficult it would be to support.

From a quick glance it seems to have the same issue as pyaes: no GCM support.  As I have yet to see a v3.5 device in the wild I don't think this would be a problem for most people, but it's something to keep in mind.
My bigger question is: run what, exactly?  Are people wanting to run the wizard and scanner under MicroPython too?  That would be interesting.

From a quick glance it seems to have the same issue as pyaes: no GCM support. As I have yet to see a v3.5 device in the wild I don't think this would be a problem for most people, but it's something to keep in mind.
My bigger question is: run what, exactly? Are people wanting to run the wizard and scanner under MicroPython too? That would be interesting.

In a distributed network environment with multiple “Tuya” smart devices placed across various locations, centralized control through a private server is essential. This necessitates the employment of an intermediary hardware module, such as an Arduino, which interfaces with the private server and manages the operation of all smart devices within its local network domain.
Moreover, it is feasible to execute Micropython on Arduino platforms, enabling the programming of Arduino hardware with Python syntax and libraries. This integration allows for the streamlined development of control scripts and the flexibility of Python's programming paradigms in hardware interactions.

Interesting use case @xp2110 - Would an alternative be to place low cost readonly Raspberry Pi Zero W in these various locations?

Raspberry Pi Zero W cost 10 times the a Arduino

I made Arduino Code Template for Tuya Communication
#include <WiFi.h>
#include <WiFiClient.h>
// WiFi network details
const char* ssid = "YOUR_WIFI_SSID";
const char* password = "YOUR_WIFI_PASSWORD";
// Tuya device details
const char* deviceID = "YOUR_DEVICE_ID";
const char* localKey = "YOUR_LOCAL_KEY";
const char* deviceIP = "DEVICE_IP_ADDRESS";
float protocolVersion = 3.3;  // Tuya protocol version
void setup() {
Serial.begin(115200);
// Connect to WiFi
WiFi.begin(ssid, password);
while (WiFi.status() != WL_CONNECTED) {
    delay(1000);
    Serial.println("Connecting to WiFi...");
}
Serial.println("Connected to WiFi");

// Additional setup code...

}
void loop() {
// Get device status
String status = getDeviceStatus();
Serial.println("Device Status: " + status);
// Add more loop code as needed...
delay(10000); // Delay between status checks

}
String getDeviceStatus() {
// Generate payload based on Tuya protocol version
String payload = generatePayload();
// Send payload to Tuya device and receive response
String response = sendReceivePayload(payload);

// Process and return the response
return processResponse(response);

}
String generatePayload() {
// Implement payload generation based on protocol version
// This will involve constructing a correctly formatted and encrypted message
String payload;
// Payload construction logic...
return payload;
}
String sendReceivePayload(String payload) {
// Implement the logic to send the payload to the Tuya device and receive its response
// This will involve establishing a TCP connection and handling the response
String response;
// Communication logic...
return response;
}
String processResponse(String response) {
// Implement response processing logic
// This might involve decrypting and parsing the response
String processedResponse;
// Response processing logic...
return processedResponse;
}

Raspberry Pi Zero W cost 10 times the a Arduino

Unless you factor in the time required to code the cyprto libraries for the Arduino? ;)
As @uzlonewolf mentioned, there may be a way to get it to work on MicroPython if you remove the Tuya 3.5 device support.

I made Arduino Code Template for Tuya Communication

Building a C++ library for interfacing with local Tuya devices is an interesting idea. I did a quick search and didn't find one (but there may be one so I would suggest checking first). It's a non-trivial task to be sure.

While I do find it interesting and think we should support it if it just requires a crypto library addition, it feels like we're getting into "can" vs. "should" territory and I suspect the end result is going to be disappointing.  Using an IoT device just to talk to another IoT device makes me ask "why??"  Just have the server talk to the Tuya device directly, or use something like a Raspberry Pi as a hub/gateway for the entire network.
The changes in #423 should make it easy to add ucryptolib if someone wants, or pyaes should work already since it's pure Python (with the performance to match).

I agree. I'm in favor of the PR based on the flexibility it gives the library to accommodate other crypto libraries. I have other comments I'll drop in the PR.

I mostly agree, but I want to point out something about using an IoT device instead of a server. For example, if I have several branches, each with many Tuya devices like temperature and humidity sensors, power meters, and light switches, it would be expensive to have a server in each branch. However, if one ESP chip can do a similar job to a regular server ( scanning local devices ), it would be cheaper. This would also ensure data security and allow a central server to gather and process all the data, no matter where it is. I hope this example makes my point clear.

@xp2110 - Feel free to try the latest release (v1.13.0) as mentioned by @uzlonewolf .

If you're going to try it, doing import tinytuya.core as tinytuya instead of just import tinytuya will help reduce the dependencies as it avoids loading all the cloud stuff.

I tried running it, but it didn't work. I think it might be necessary to look into implementing the same idea in C++. If it's possible to shorten the Python code so that it only serves to determine the device's status, I will then convert it to C++ to make it work on Arduino.
I know that the project is not small, but this will be useful for everyone.

I think it might be necessary to look into implementing the same idea in C++

Thanks @xp2110 . That would be outside the scope of this project (python library). However, I encourage anyone interested in that effort to join you in helping.
If I have time I'll see if I can get the micropython version to work on my Arduinos.

I started getting it to work on the Unix port of MicroPython, but stopped at the point it needed a crypto library.  Basically I just had to comment out the colorama stuff and "mip install" some dependencies.  If I can find time I'll see about getting the crypto library patched in.

If it's possible to shorten the Python code so that it only serves to determine the device's status

Basically 90% of the complexity is handling the different protocol versions.  If you only wanted to handle 1 (say, 3.3) it would greatly simplify everything.

Yes, I specifically want to deal with version 3.3 of the protocol. Focusing on this single version will significantly streamline the process, reducing the complexity involved in managing multiple versions and enhancing the stability and efficiency of my application.

I made Arduino Code Template for Tuya Communication
#include <WiFi.h>
#include <WiFiClient.h>

// WiFi network details
const char* ssid = "YOUR_WIFI_SSID";
const char* password = "YOUR_WIFI_PASSWORD";

// Tuya device details
const char* deviceID = "YOUR_DEVICE_ID";
const char* localKey = "YOUR_LOCAL_KEY";
const char* deviceIP = "DEVICE_IP_ADDRESS";
float protocolVersion = 3.3;  // Tuya protocol version

void setup() {
    Serial.begin(115200);

    // Connect to WiFi
    WiFi.begin(ssid, password);
    while (WiFi.status() != WL_CONNECTED) {
        delay(1000);
        Serial.println("Connecting to WiFi...");
    }
    Serial.println("Connected to WiFi");

    // Additional setup code...
}

void loop() {
    // Get device status
    String status = getDeviceStatus();
    Serial.println("Device Status: " + status);

    // Add more loop code as needed...
    delay(10000); // Delay between status checks
}

String getDeviceStatus() {
    // Generate payload based on Tuya protocol version
    String payload = generatePayload();

    // Send payload to Tuya device and receive response
    String response = sendReceivePayload(payload);

    // Process and return the response
    return processResponse(response);
}

String generatePayload() {
    // Implement payload generation based on protocol version
    // This will involve constructing a correctly formatted and encrypted message
    String payload;
    // Payload construction logic...
    return payload;
}

String sendReceivePayload(String payload) {
    // Implement the logic to send the payload to the Tuya device and receive its response
    // This will involve establishing a TCP connection and handling the response
    String response;
    // Communication logic...
    return response;
}

String processResponse(String response) {
    // Implement response processing logic
    // This might involve decrypting and parsing the response
    String processedResponse;
    // Response processing logic...
    return processedResponse;
}

Hello. I'm looking for a library to use on an esp32-arduino. I want to do a direct communication exercise between an esp32 and a tuya device on the local network. My programming skills are basic. This template you created is just what I need. Have you been able to communicate with a device of yours?

If it's of any interst, I created a small Arduino Code Program to test direct access to Tuya devices running on a ESP8266..
https://github.com/FrBerger83/EspTuya

Thanks @FrBerger83 ! Adding to my "try this" list. :)

Thanks @FrBerger83


Asking for confirmation before proceeding with deployment

Q
A

Issue Type
Question

Deployer Version
3.3.0

Local Machine OS
macOS El Capitan

Remote Machine OS
Ubuntu 14.04

Question
As an additional control mechanism I'd like to add an additional step to my deployment that displays a message and asks for confirmation.
In one of my projects I have a certain prerequisit to be met in order for the deployment to succeed. I'd like to display a message á la "Did you make sure to do XYZ (yes|no)" and only proceed with deployment if "yes" is entered.
Is there a way to achieve this?

Try use this:
askConfirmation(string $message[, bool $default = false])

Could you give code example, I'm having hard time figuring out how to ask for confirmation AND if user answers no -> cancel deploy.

Something like this:
task('ask', function() {
    if(!askConfirmation('Deploy app?')) {
        die('Ok, no deploy then.');
    }
});

before('deploy', 'ask');

Thank you!


ERR_CONNECTION_CLOSED in local development?

Hi,
First of all thanks for all your hard work on this project. It's a really great tool.
While developing locally, I'm getting this error when I call WebFont.load({ ... }):
GET https://localhost:3001/undefined net::ERR_CONNECTION_CLOSED
w @ webfontloader.js:2
(anonymous) @ webfontloader.js:10
It seems to come and go. When I push my app to production, the error goes away. Do you know what this request is and why there might be an error?
Thanks,
Eric

Closing this as it was due to an issue unrelated to webfontloader.


composer.lock not up to date with composer.json in shopware/recovery

PHP Version
8
Shopware Version
v<IP_ADDRESS>
Expected behaviour
I expected composer.lock to be up to date with composer.json in shopware/recovery :D
Actual behaviour
https://github.com/shopware/recovery/commit/1ec09446a1b1b2b2abdf02dd19a57cb8f0fd5784
How to reproduce
...

I will close this as duplicate of https://github.com/shopware/production/issues/168


good looking code

Now the code looks better!

Closing for now. Thanks for coming to the workshop!


[AIRFLOW-1929] Pass ExecutionDate In TriggerDagRunOperator

This allows passing an execution date in the
TriggerDagRunOperator.
Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX

Description

[x] Here are some details about my PR, including screenshots of any UI changes:
The TriggerDagRunOperator was not configurable to pass the execution_date of the dag being triggered. This change adds another field to the TriggerDagRunOperator and uses the experimental API method trigger_dag used in the cli utility. This can help in avoiding code deduplication.

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3152 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3152      +/-   ##
==========================================
- Coverage   73.57%   73.56%   -0.01%
==========================================
  Files         191      191
  Lines       14346    14341       -5
==========================================
- Hits        10555    10550       -5
  Misses       3791     3791

Impacted Files
Coverage Δ

airflow/operators/dagrun_operator.py
96.29% <100%> (-0.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e1861...47146b2. Read the comment docs.

@sreenathkamath This seems to be the same issue as AIRFLOW-1674, and I've already submitted a PR as #2678. But I think your solution is better because:

it leverages common function and improves maintenanceability.
it's bw-compatible while mine is not.

So I hope your PR will be merged. Would you also fix example_trigger_controller_dag.py to work?
@bolkedebruin do you have any advice?

@sekikn I have made the suggested changes.

@Fokko  can you please take a look

Can someone please take a look at this PR. At least suggest the changes that are required to get it merged?


Update jhub-profiles-configMap.yaml

With python3.11 + jupyterlab v4 and rucio jupyterlab extension latest version

nice, lgtm


Update to v1.0.0rc1.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


kio-gdrive: init at version 1.2.7

I had to add signon, signon-ui, kaccounts-integration and providers
packages to be able to build kio-gdrive ( one of the packages from #62168 )
Package works well on my laptop. Signond daemon is probably not able to find it's plugins installed into user profile. However, it doesn't affect kio-gdrive itself.

Motivation for this change
Add google drive integration to KDE dolphin and other kio aware apps.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

accounts-qt5 is inside buildInputs, so the error is seems weird to me. And it works in my environment... Would you kindly give me more information so I could try to reproduce it?

Ah, on last thing: before merging I would squash all the "refactor" commits.

Hello @rnhmjoj , thank you for your advices. I hope I did exactly what you asked for.

Not exactly, sorry. I meant moving the new changes to the respective package: init at version.
You can do this by doing

a soft reset to HEAD~,
committing each change separately,
interactive rebase (git rebase -i) in which you reorder the commits and use the fixup action to merge the new change with the package: init commit.

The idea is that the history of a PR (like fixing mistakes) shouldn't be preserved when merged into master.

Is there anything else I can do to help the merge happen?

Sorry, I forgot about this PR: unfortunately github doesn't send notification on new commits.
The commits look good now.

@jonringer can you finish your review?

@konstantinous Are you still working on this?  I would like to help you get this merged.

Hoever it needs a rebase and most probably an update of the mentioned components.

I believe in the kio-gdrive was added in #122040, so perhaps this is obsolete now.


hello world

Codecov Report
This is an empty upload
Files changed in this PR are testable or aren't ignored by Codecov, please run your tests and upload coverage. If you wish to ignore these files, please visit our ignoring paths docs.

Welcome to Codecov :tada:
Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Make constants version specific in specs

[tangent] we don't have to figure this out in this PR but I wonder if it would make sense to include the app version that a constant is applicable for in this table. For example, I think some of these params could be modified to be different in different app versions and at that point it's not immediately obvious if this table should reflect the original or updated value. Perhaps both with a new column for app version?
Originally posted by @rootulp in https://github.com/celestiaorg/celestia-app/pull/3094#discussion_r1530503420

Documenting the value of a versioned constant for each applicable app version makes sense to me.
PS: if a constant becomes dependent on the app version, it likely needs to remain versioned indefinitely, making all future app versions applicable. So, considering this, the value of the constant needs to be recorded for all app versions, but not a subset of them.

On second thought, I don't think this issue is strictly necessary.
If we want to differentiate versioned parameters, one idea is:

Add a new table to https://celestiaorg.github.io/celestia-app/specs/params.html for Versioned Parameters
Add versioned params (SquareSizeUpperBound, SubtreeRootThreshold ) into that new table

I don't think we should move minfee.GlobalMinGasPrice from the existing Module Parameters table to the VersionedParameters table because it's governance modifiable and specific to the minfee module.


Airnode reference version selection is invisible in dark mode

On desktop. Confirmed with 2 browsers.
Dark mode:

Light mode:

@dcroote - I am getting the text in my overlay. I'm wondering if this is a Windows thing. @Ashar2shahid @vanshwassan can you check this out, I believe you are on Windows.

Code here: https://github.com/api3dao/vitepress-docs/blob/main/docs/_components/reference/VersionPicklist.vue

@wkande - correct, I've updated my original comment


Include ansible-playbook --syntax-check as part of the linting process

Please include ansible-playbook --syntax-check as a first stage of the linting process, and output its result using pep8 format, so it can be later consumed by other tools.

I just released a linter for ansible syntax checking.  That should hopefully satisfy your needs.

I'd use my 'Please use the Issue Template' canned response here, but probably easier to mark this wontfix.


Should we require two dagger packages to be imported?

I think that requiring two packages to be imported instead of a single one (which we had before #1866) doesn't sit right:

Could we simplify this so that only a single package would need to be imported?

Follow-up to https://github.com/dagger/dagger/pull/1866 cc @helderco @shykes

I think we're in good shape with the new docs page added this week. In particular:

Core Actions Reference
Dagger Actions


inline create redirect url error

Bug report
What I did
Trying to use inline_create on relationship field
        CRUD::addField([
            'type' => 'relationship',
            'name' => 'provider_id',
            'entity' => 'provider',
            'attribute' => 'name',
            'ajax' => true,
            'inline_create' => [
                'entity' => 'providers'
            ]
        ]);

What I expected to happen
User is able to inline create related rows and have that new item be added to the select2 box.
What happened
Results in an error when inline creating "could not create related entity"
in console I was able to see the ajax request returning a 500:
ErrorException: Undefined variable $redirectUrl in file C:\xampp\htdocs\pathos\husa-middleman\vendor\backpack\crud\src\app\Library\CrudPanel\Traits\SaveActions.php on line 352
For references my ProvidersCrudController is pretty run-of-the-mill
<?php

namespace App\Http\Controllers\Admin;

use App\Http\Requests\ProvidersRequest;
use App\Models\Provider;
use Backpack\CRUD\app\Http\Controllers\CrudController;
use Backpack\CRUD\app\Http\Controllers\Operations\CreateOperation;
use Backpack\CRUD\app\Http\Controllers\Operations\DeleteOperation;
use Backpack\CRUD\app\Http\Controllers\Operations\ListOperation;
use Backpack\CRUD\app\Http\Controllers\Operations\ShowOperation;
use Backpack\CRUD\app\Http\Controllers\Operations\UpdateOperation;
use Backpack\CRUD\app\Library\CrudPanel\CrudPanel;
use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade as CRUD;
use Backpack\Pro\Http\Controllers\Operations\InlineCreateOperation;

/**
 * Class ProvidersCrudController
 * @package App\Http\Controllers\Admin
 * @property-read CrudPanel $crud
 */
class ProvidersCrudController extends CrudController
{
    use InlineCreateOperation;
    use ListOperation;
    use CreateOperation;
    use UpdateOperation;
    use DeleteOperation;
    use ShowOperation;

    /**
     * Configure the CrudPanel object. Apply settings to all operations.
     *
     * @return void
     */
    public function setup()
    {
        CRUD::setModel(Provider::class);
        CRUD::setRoute(config('backpack.base.route_prefix') . '/providers');
        CRUD::setEntityNameStrings('providers', 'providers');
    }

    /**
     * Define what happens when the List operation is loaded.
     *
     * @see  https://backpackforlaravel.com/docs/crud-operation-list-entries
     * @return void
     */
    protected function setupListOperation()
    {
        CRUD::column('name');
        CRUD::column('code');
        CRUD::column('notes');
        CRUD::column('created_at');
        CRUD::column('updated_at');
    }

    /**
     * Define what happens when the Update operation is loaded.
     *
     * @see https://backpackforlaravel.com/docs/crud-operation-update
     * @return void
     */
    protected function setupUpdateOperation()
    {
        $this->setupCreateOperation();
    }

    /**
     * Define what happens when the Create operation is loaded.
     *
     * @see https://backpackforlaravel.com/docs/crud-operation-create
     * @return void
     */
    protected function setupCreateOperation()
    {
        CRUD::setValidation(ProvidersRequest::class);

        CRUD::field('name');
        CRUD::field('code')->hint('Example: B360 or HUSA-EX');
        CRUD::field('notes');
    }
}

What I've already tried to fix it
unsure how to proceed
Is it a bug in the latest version of Backpack?
Yes
PHP VERSION:
PHP 8.1.6 (cli) (built: May 11 2022 08:55:59) (ZTS Visual C++ 2019 x64)
Copyright (c) The PHP Group
Zend Engine v4.1.6, Copyright (c) Zend Technologies
LARAVEL VERSION:
v10.1.3@12256504186326a9d02b2ab3b43a4031a59b52d1
BACKPACK PACKAGE VERSIONS:
backpack/crud: 5.5.2
backpack/generators: 3.3.16
backpack/permissionmanager: 6.0.16
backpack/pro: 1.6.3

It was the order of traits listed!
Should be like so, with create first, then inlinecreate:
    use ListOperation;
    use CreateOperation;
    use UpdateOperation;
    use DeleteOperation;
    use ShowOperation;
    use InlineCreateOperation;

Thanks for getting back @afagard 🙏  Happy you found the solution.
Indeed, that's a requirement, I just went ahead and checked in the docs if we added it there, we could have missed that info 🤷

It's there ... so we should be good !
Cheers


Bug? SummaryBarCards stuck together

Did you intend to combine memory used and garbage collection together?  They're both selected when I mouse click but I have tab through both as opposed to one when using the keyboard.

Closing this issue, as this behavior is no longer present in the new JSON-backed dashboard model.