Can not find mpi.h

I am trying to run this action on some C++ code which uses MPI.
I am using the build_commands.json generated by CMake as an input to this Action, but I still get an error:
'mpi.h' file not found [clang-diagnostic-error]
Locally, I get this error when the build_commands.json is not given to clang-tidy.
Do you have any idea, why clang-tidy can not find mpi.h in the current setup?
This is what my action looks like:
(the CMAKE_EXPORT_COMPILE_COMMANDS ON is set in the CMakeLists.txt)
jobs:
  compile:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3

      - uses: mpi4py/setup-mpi@v1
        with:
          mpi: 'intelmpi'

      - name: Compile code
        run: |
          cmake .
          make

      - uses<EMAIL_ADDRESS>        id: review
        with:
          config_file: .clang-tidy
          lgtm_comment_body: ""
          split_workflow: true

There's a (seemingly) similar problem in chatterino:
clang-tidy failed with return code 1 and error:
81416 warnings and 2 errors generated.
Error while processing /github/workspace/src/providers/seventv/SeventvBadges.cpp.
Suppressed 81415 warnings (81413 in non-user code, 2 due to line filter).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).

Output was:
warning: optimization flag '-fno-fat-lto-objects' is not supported [clang-diagnostic-ignored-optimization-argument]
/github/workspace/src/common/Aliases.hpp:3:10: error: 'QHash' file not found [clang-diagnostic-error]
#include <QHash>
         ^~~~~~~

Took: 0:00:08.269470

There are other cases where clang-tidy returned with 'boost/optional.hpp' file not found even though the build succeeded.
I think the root issue here is that this action runs in docker, and thus can't find files set-up before. In your case it's mpi.h and in chatterino's case it's Qt and boost.

Hi @christian512, very sorry for it's taken me a long time to reply! This action runs in a separate container to the rest of the workflow, which means it doesn't have access to the same packages. There's an apt_packages argument that you can use to pass in a list of packages to install inside the container. I guess you most likely want:
jobs:
  compile:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3

      - uses: mpi4py/setup-mpi@v1
        with:
          mpi: 'intelmpi'

      - name: Compile code
        run: |
          cmake .
          make

      - uses<EMAIL_ADDRESS>        id: review
        with:
          config_file: .clang-tidy
          lgtm_comment_body: ""
          split_workflow: true
          apt_packages: "python3-mpi4py"

Hope that helps!


Improve Logging Security to Prevent Log Forging Attacks

Currently, Macaw Framework logs the headers, body, and parameters of every request. While we have some sanitization in place, it may not be sufficient to prevent log forging attacks. To enhance the security of our logging system and protect against log forging, we should consider implementing additional measures.
Here are some suggestions for improving logging security:

Apply consistent encoding: Ensure that a specific encoding (e.g., UTF-8) is consistently applied when writing data to the logs. This can help prevent issues related to mixing different character sets.
Escape or remove control characters: Control characters (e.g., newline, carriage return) can be used in log forging attacks to manipulate log entries. We should remove or escape control characters from user-provided data before logging them.
Limit the length of logged data: Define a maximum length for each logged field (e.g., header, parameter, body) and truncate any user-provided data that exceeds this limit. This can prevent excessively long log entries and mitigate potential denial-of-service attacks.
Consider logging a hashed or encoded version of sensitive data: If we need to log sensitive information (e.g., passwords, API keys), we should consider hashing or encoding this data before logging it to prevent accidental exposure.

To address these concerns, we can create a separate method for sanitizing data specifically for logging purposes. This method should handle the points mentioned above and should be called whenever we log headers, body, or parameters.
By implementing these practices, we can significantly reduce the risk of log forging attacks in our web framework. We should prioritize this issue to enhance the overall security of the project.
Please let me know if you have any questions or require further clarification on the proposed changes.

While the commit #47 solves this issue, I used some features that are not supported by Ruby 2.7, and had to raise minimum Ruby version from 2.7 to 3.0. I will think about if i will keep this solution or revert and redo it in order to keep supporting Ruby 2.7.


No release available that is compatible with Symfony 3.X

Thanks for this bundle 👍
Would you mind tagging a release now that you have made compatibility with Symfony 3.X possible?

+1
@AhmedSamy could you create a new tag? Thx 👍

+1
@AhmedSamy any news about it? :)


GCP provider: support in-place property updates on the machine

This issue was moved to kubernetes-sigs/cluster-api#95


Release-plz reads the config, but the release PR does not contain the changelog as it is configured

Bug description
At cargo-generate I'm trying out release-plz, and have configured the git-cliff to look a bit different than usual. As from the CI Run you can see that release-plz does read the config file AND the right git-cliff config file. (You'll notice the emojis in the convential commit categories)
So far so good, however the release-pr that is created does not contain the CHANGELOG changes.
I was able once to get a CHANGELOG change in the PR, but this one did not correctly utilize the configuration provided by the git-cliff config in the repo.

Would you like to work on a fix? yes, but I have no idea where to look at.

To Reproduce
Steps to reproduce the behavior:

create a release-plz config like this
create a git-cliff config like this (as above)
create a simple GH Pipeline like this
see that the PR does not contain a CHANGELOG

Expected behavior
I would expect the CHANGELOG.md is updated and the change is in the release-pr.
Screenshots

Environment

OS: ubuntu-latest on GithubActions
release-plz version: release-plz-v0.3.33/linux-x64

Removing previous.version from the changelog works. We should populate this field and pass it  to git-cliff somehow.

It's also bad that we are panicking:
thread 'main' panicked at crates/release_plz_core/src/changelog.rs:69:14:
cannot update changelog: TemplateRenderError("Variable `previous.version` not found in context while rendering 'template'")

Also, you can use release-plz update to test locally if you don't want to push commits

We can set previous here:
https://github.com/MarcoIeni/release-plz/blob/986bbc4c187258eb644f6b6361e3d25168975550/crates/release_plz_core/src/changelog.rs#L152

Thanks a lot for the swift reply and taking action.

Hey Sven, I just released a new version of release-plz.
I tested release-plz on it. The only issue I found is that the git tag link unfortunately doesn't work:
## [0.18.6] 2023-12-13

[0.18.6]: <REPO>/compare/0.18.5...0.18.6

For the default changelog, I set it manually:
https://github.com/MarcoIeni/release-plz/blob/6c1feea3f53caf4ba9247c7fc9f0cf364b426c14/crates/release_plz_core/src/changelog.rs#L115
Unfortunately, release-plz doesn't support git-cliff to 100% yet.

Thank you so much Marco,
looks already pretty good. I changed the body template a bit so that It accommodates for the missing link.

https://github.com/cargo-generate/cargo-generate/pull/1080/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR3
There is only and interesting (unrelated) issue with the diff of the CHANGELOG.md where the top header # Changelog is being appended in the diff at the bottom.
That is strange, but I will have a look and see if I can find the bug myself.

and BTW:

Also, you can use release-plz update to test locally if you don't want to push commits

This works, but it does not produce the same release version as it does on CI. Specifically it does not detect the breaking change and bumps the maj. version number, only the patch version number. Not sure if that is intended.

For that, you need to install cargo-semver-checks locally


Welcome page experience for extensions

Hi, it would be great if there was an "onExtensionInstalled" activation event that would trigger when a VS Code extension is first installed.
Our use case for this activation event, is that we would like to display a welcome page for our VS Code extension when the user first installs the extension.

Same here and exactly the same use case. Using "*" for this would be absolutely horrible. Best I can think of right now is to use onView with an extension's view if it has one.
(Good work on vscode BTW!)

I do not think such an activation event will help because we do not always activate an extension immediately after installing. Unfortunately there is no way for extension to hook into for showing welcome page.
@kieferrm FYI

I agree that for my case the real issue is "welcome experience". There's another issue that also falls into this category but is more about convenience of the extension developer. We're currently just using a markdown preview for our "welcome" document, but this has some drawbacks that could be addressed by adding some features to the markdown preview:

A way to set the title on the tab to something custom rather than "Preview welcome.md"
A way to set the security policy on the view so that command: URIs can work (for jumping to the settings panel, etc.)

Again I know I can just use a webview for this but I don't really need the full capabilities of a webview and it would be kind of nice if the markdown preview could be used like a webview. (Maybe there's a way to obtain a reference to the webview used by the markdown preview but if so I don't know what it is.)
Anyway, just something else to think about.

@rjstone Can you please file a separate issue for markdown preview issues?

Will do

See #84886
It seems as though duplicate functionality would be needed to enable a simple markdown type welcome experience as the markdown preview module is unsuitable.

Ok, well to start over, the end goal is to make sure the user is not totally lost after installing a new extension and get some initial configuration done. They might need some pointers on what needs to be configured for example, or even offered up some settings to configure. The way many people solve this now (take GitLense for example) is open a "welcome" page in a webview, then they just provide some quickstart howto instructions.
As for how to do it in the future I'm not sure.
But basically what I was attempting to solve is: user installs extension, seems lost and tells me "yea I installed it but don't know what to do" or "I installed it but  doesn't work". So usually they either don't know something or they didn't configure a setting that was needed for what they expected.
Something better than just opening a HOWTO file would of course be great.

I see your point, but we open ReadMe of the extension when user installs the extension and expect this as a guide for the user given the extension author provides necessary information there.
The welcome experience what other extensions like gitlens does is helpful given that it requires user interaction to configure it which is not so easy to be surfaced in ReadMe.
But as said all your concerns are so valid and we will consider them when looking into this.

Regarding the readme, the main dilemma with the readme is that since it's the main thing people see in the extension marketplace, there's a desire to prioritize "marketing" or feature overview information there and only put docs at the bottom of the readme. So someone could have to scroll through a few pages of screenshots to get to the documentation and might miss it. (I was somewhat confused by this when I first started using Atom.) Some things can alleviate this like linking to the lower section at the top but nevertheless some extensions have felt the need to display separate documentation in some manner.
I guess it's more of a new vscode user issue since eventually people learn to start looking toward the bottom of the readme for docs.
Anyway it's pretty minor stuff but something to think about I guess.

This should also account for when extensions are installed automatically via Settings Sync (https://github.com/microsoft/vscode/issues/86285). Extensions should be able to differentiate between a first install and an automatic install.

Assigning to May for exploration

I'd also really like this feature so I can provide a guided welcome experience for new users.
My extension is a language server for a video game scripting language. Most users have never used an IDE before, so they're brand new to VS Code. Further complicating this is that the scripting language requires some manual configuration and uses .txt files so requires a fiddly activation sequence.
As above, I can't make the README a detailed troubleshooting document as I need to convince amateur modders that they need VS Code instead of Notepad++!

@misolori I remember you are working on mock ups for extensions welcome experience, hence assigning to you. Feel free to close this as duplicate if there is another issue. Thanks.

From @alexdima:
IMHO, I think extensions have been using a pattern where they show a welcome screen on activate by checking for a memento and then saving the memento once the Welcome screen is shown. This worked well, but worked well only on a single machine.
I like the idea to introduce explicit API like e.g. ctx.canShowWelcome. Given the deep connection with settings sync and command line installation (e.g. extension installed due to devcontainer.json), I think you would be a natural fit to own this API. You would know better than me, perhaps this could be implemented straight-forward with global state syncing.
A special API that is provided by vscode has the benefit that we could explicitly set ctx.canShowWelcome to false when we really don't want to show welcome screens, like e.g. when using vscode as a git commit message editor, or reviewing a PR in codespaces, etc.

Additionally, it would be very nice (but largely out of scope for my specific ask here), would be provide the activation event (e.g. the reason) the activate method is getting called. For example, if you are getting activated because of a command, you might change your startup behavior.

This has been requested before in #44711 . See https://github.com/microsoft/vscode/issues/44711#issuecomment-369183434 for more background on why it might not be desireable to define a closed set of activation reasons, since those reasons might grow over time. (2a, 2b were added later)

I like the idea of providing some context for extensions while activating them. Instead of talking about welcome experience in the context, I would provide last activated version of that extension as the context for eg: ctx.getLastActivatedVersion. Based on that extension can control their welcome notifications. While following up with extensions with welcome pages or notifications, I have seen most of the extensions are using previous version to control welcome/update experience.
canShowWelcome might not be complete without having an API to show welcome also it will not cover updates experience that some extensions need.
CC @eamodio

We now have the getting started API that extensions can use and activate on install via the onWalkthrough:walkthroughID event. See the Python extension as an example:


Cherry pick NavigationBar ink ripple fixes

Pick for: https://github.com/flutter/flutter/issues/119554
Main goal to cherry pick: https://github.com/flutter/flutter/pull/117473
Required pulling in already cherry picked: https://github.com/flutter/flutter/pull/117500
There were some conflicts based on a lot of changes in this file over the last month, some cherry picked, others not, can you check me on this @TahaTesser?
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks
This looks alright to me.

Umm I did a rerun of the presubmit tests but seem like they are still failing

Yeah I am not sure what the issue is, there are a number of errors that have to do with unnamed library?
01:00 +1000 ~1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/calendar_date_picker_test.dart: CalendarDatePicker Can select a day
test/material/navigation_bar_theme_test.dart:8:8: Error: The 'unnamed-libraries' language feature is disabled for this library.
Try removing the package language version or setting the language version to 2.19 or higher.
library;

I am not used to cherry picking, I'll try to take another look later today.

We will probably save this cp for the next hotfix, since we are about to release tomorrow morning

Thanks, should be fixed with latest commit

Landing with customer_testing failures as they are not expected to pass consistently on release candidate branches.


[gardening] remove redundant optional nil assignment in stdlib source

since this appears to be the convention followed elsewhere in the code base.

@swift-ci please smoke test and merge.

My bad.  "And Merge" comes later.

⛵


want to add to library bundle?

hi - this is a great library! please add to our community bundle, it will get automatic releases so people can easily find it :)
https://github.com/adafruit/CircuitPython_Community_Bundle

Whoa! Hello! :smile:
Sure! Now that I cleaned it up some more, made it easier to use and satisfied the CI, I can make a release and then PR it in. :)
Didn't expect all this attention for a simple library I made while playing with Arturo's Serpente. :)

awesome :) thanks! let us know if you need any help

Done! :)


SPIKE: Investigate deploying ensemble models using InferenceGraphs

Kserve allows model chaining via InferenceGraphs.
The Kserve documentation has some examples of InferenceGraphs :
https://github.com/kserve/kserve/tree/master/docs/samples/graph
https://kserve.github.io/website/master/modelserving/inference_graph/image_pipeline/
We need to figure out how to support InferenceGraphs using Kserve in ODH and provide the correct documentation for the creation of the InferenceGraph as well as documentation for how to do rest inferencing against the graph

Migrated to https://issues.redhat.com/browse/RHOAIENG-2950
/close


Notification error when CSCC notification is enabled.

When I enable the CSCC notification, and run the notifier,  I get the server error message.  I see that CSCC notification has started in the log, but didn't see any output.
server_message: "Error occurred during the notification process."

Another issue here is that I also didn't get the following inventory summary, which runs after the CSCC notifier.  So, we need to make this more robust, so that if one notifier doesn't work, the following notifiers should still run.


[TACHYON-1712] Added the docs for setting up Tachyon with NFS

https://tachyon.atlassian.net/browse/TACHYON-1712

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8518/
Test PASSed.

LGTM, thanks for adding both versions!


Bound LOD radius to quality settings

Currently, the configuration of LOD0, LOD1 levels is hardcoded. In the debug menu it can be changed, but only the LOD1 threshold.
Also, LOD0 is never used for SDK scenes.
The behaviour should be similar as the following:

Change the concept of LOD thresholds to LOD radius
Add the concept of SDK Scene radius
LOD 1 radius does not need to be defined as it goes as far as the scene load radius allows.
Radius determine the number of parcels of distance from the previous LOD level.
Values are bound to quality settings, and different per quality.

As an example, if we define:
SDK Radius: 3
LOD0 Radius: 6
It will mean that from 0 to 3, it will load SDK scenes or LOD0 in the case of SDK6
From 4 to 6, it will load LOD0
From 7 to Scene load radius, will load LOD1
Quality settings values:
High

SDK scene radius: 3
LOD0 radius: 10
Scene Load Radius: 100

Medium

SDK: 2
LOD0: 4
Scene Load Radius: 50

Low

SDK: 1
LOD0: 2
Scene Load Radius: 20

On debug menu, instead of showing LOD threshold, we will have the following parameters

SDK radius
LOD0 radius
Scene Load Radius

Similar/Duplicate of #446


Trying to create server on <IP_ADDRESS> throws exception

I'm not sure if this is something I'm doing wrong, but I get an exception when trying to:
var server = new MetricServer("<IP_ADDRESS>", 10000);  server.Start();
The exception is:
System.ObjectDisposedException: Cannot access a disposed object. Object name: 'System.Net.HttpListener'.    at System.Net.HttpListener.CheckDisposed()    at System.Net.HttpListener.Stop()    at Prometheus.MetricServer.StopInner() in C:\MyData\dev\prometheus-net\prometheus-net.shared\MetricServer.cs:line 74    at Prometheus.MetricHandler.Stop() in C:\MyData\dev\prometheus-net\prometheus-net.shared\MetricHandler.cs:line 38
Is this something I'm doing wrong or is it a bug?
Thanks in advance,
Marcelo.

Actually the exception above is wrong. The original exception is:
System.Net.HttpListenerException (0x80004005): The request is not supported
at System.Net.HttpListener.AddAllPrefixes()
at System.Net.HttpListener.Start()
at Prometheus.MetricServer.StartLoop(IScheduler scheduler)
at Prometheus.MetricHandler.Start(IScheduler scheduler)
Trying to listen on the "*" host gives me access denied instead (something typical of HttpListeners).


Clap doesn't allow a short last argument

Rust Version
1.19.0
Affected Version of clap
2.25.1
Expected Behavior Summary
I want to accept one of the following command lines:
./my_app -l foo -l bar -- pacman -S rust

./my_app -l foo -l bar pacman -S rust

There may be 0,1,2,... -l arguments.
So I did
    let matches = App::new(APP)
        .version(VERSION)
        .author(AUTHOR)
        .about("about")
        .arg(
            Arg::with_name("library")
                .short("l")
                .required(false)
                .takes_value(true)
                .multiple(true)
                .last(true),
        )
        .get_matches();

Actual Behavior Summary
This panicks with
thread 'main' panicked at 'Flags or Options may not have last(true) set. library has both a short and last(true) set.', /home/marcin/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-2.25.1/src/app/parser.rs:210

It's unclear to me why the library dislikes flags having a last option. I could not find another way of achieving the command line I want to parse.
When I found out how to do this, I'll contribute documentation. :)
Sample Code or Link to Sample Code
https://play.rust-lang.org/?gist=659376caba48dcc6eae0cb3f7fb3854e&version=stable
(couldn't try compiling it, playground is currently out of memory)
Debug output
No new output appeared.

I got it. I'll contribute an example so that other can avoid that pitfall.

I'm seeing this issue but with no last(true) setting
   Compiling clap v2.26.0
   Compiling pt v0.2.2 (file:///Users/tylerthrailkill/Dropbox/rustup/cli)
    Finished dev [unoptimized + debuginfo] target(s) in 31.36 secs
     Running `target/debug/pt start -g -i -s -b`
error: Found argument '-b' which wasn't expected, or isn't valid in this context

USAGE:
    pt start --gateway <BRANCH> --iam-service <BRANCH> --server <BRANCH>

For more information try --help

cargo run start -- -g -i -s --blah
    Finished dev [unoptimized + debuginfo] target(s) in 0.0 secs
     Running `target/debug/pt start -g -i -s --blah`
works here....✔


Skip compile when transforming

Proposed changes
As per title. This let's us simplify and fuse much more than if we transform over the compiled primitive directly.
Here are a few examples:
Compile compiled functions
@mx.compile
def fun(x):
    @mx.compile
    def inner(y):
        return mx.abs(mx.exp(y))

    return inner(inner(x))
mx.export_to_dot("graph.dot", fun(mx.array([1.0, 2.0])))

Now produces a single fused primitive:

Grad compiled functions
@mx.compile
def fun(x):
    return mx.exp(mx.exp(x))

x = mx.array(1.0)
out = mx.compile(mx.value_and_grad(fun))(x)
mx.export_to_dot("graph.dot", out)

Also now produces a single primitive with no duplicate work since the VJP reuses the exp's.

Sorry for breaking your tests 😬


picture for calendar

All we had to do was download from Overland website. It's a jpeg, but that's okay


Scav overview tab on ANY map causes scav character to not appear and softlocks tabs

General information:
Project issue is for:
Server
Expected result:
Selecting the overview tab in a scav raid will show your scav's character
Actual result:
Tabs no longer work and scav character does not appear.
Happens at random?? Could be caused by picking up gear from corpses or killing somebody.
Looting takes you back to the gear screen, but tabs still don't work.
How to reproduce:

Play as a scav
Go into overview tab
Attempt to press another tab

Screenshots:
Didn't work in the raid I was in.
Happened multiple times before.

Attachments

server-2023-09-16-18.log (2 KiB)
2023.09.16_20-25-34_<IP_ADDRESS>.26215 traces.log (368 KiB)
image.png (1219 KiB)
image.png (1532 KiB)

Originally written by MissinginAction

Attachments

image.png (662 KiB)

Originally written by MissinginAction

EXCEPTION: System.FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list.
  at System.Text.StringBuilder.AppendFormatHelper (System.IFormatProvider provider, System.String format, System.ParamsArray args) [0x000ff] in <eae584ce26bc40229c1b1aa476bfa589>:0
  at System.String.FormatHelper (System.IFormatProvider provider, System.String format, System.ParamsArray args) [0x00023] in <eae584ce26bc40229c1b1aa476bfa589>:0
  at System.String.Format (System.String format, System.Object[] args) [0x00020] in <eae584ce26bc40229c1b1aa476bfa589>:0
  at EFT.UI.LocalizedText.SetFormatValues (System.Object[] values) [0x00014] in <d690c65031ef480c8fc42adeb7274508>:0
  at EFT.UI.LocalizedText.method_1 () [0x0002d] in <d690c65031ef480c8fc42adeb7274508>:0
  at EFT.UI.LocalizedText.set_LocalizationKey (System.String value) [0x00007] in <d690c65031ef480c8fc42adeb7274508>:0
  at EFT.UI.OverallScreen.method_4 () [0x00101] in <d690c65031ef480c8fc42adeb7274508>:0
  at EFT.UI.OverallScreen.method_3 (UnityEngine.Object toggle, System.Boolean value) [0x002aa] in <d690c65031ef480c8fc42adeb7274508>:0
  at EFT.UI.OverallScreen.Show (EFT.Profile profile, InventoryControllerClass inventoryController) [0x00020] in <d690c65031ef480c8fc42adeb7274508>:0
  at EFT.UI.OverallScreen+GClass2850.Show () [0x00000] in <d690c65031ef480c8fc42adeb7274508>:0
  at Tab.Select (System.Boolean sendCallback) [0x00015] in <d690c65031ef480c8fc42adeb7274508>:0
  at GClass2855.SelectTab (Tab tab, System.Boolean sendCallback) [0x00009] in <d690c65031ef480c8fc42adeb7274508>:0
  at GClass2855+Class2556+Struct854.MoveNext () [0x00070] in <d690c65031ef480c8fc42adeb7274508>:0

Originally written by CWX

Attachments

image.png (50 KiB)

Originally written by CWX

can you attach your profile please @MissinginAction

Originally written by CWX

consolidating to older issue ticket

Originally written by CWX


Question about setup

Hi,
Some help would be greatly appreciated to get this package to work.

Credentials

At the time of writing, Google prefers you to authenticate using a service account. It will throw a warning otherwise, which you can (but probably should not) disable by setting SUPPRESS_GCLOUD_CREDS_WARNING=true

What is "it"? Where will any warning be thrown? In the local logs? On Google Console?

Service account

Create a service account with the appropriate roles attached to it and add it to your project. Make sure not to commit this file to git, because of security. You can then specify the path to the service account JSON file in the keyFilePath or in the STACKDRIVER_KEY_FILE_PATH environment variable.

What are the appropriate roles for each functionality of this package?
I tried adding these 3 to get logging on Google:

Cloud Trace Admin
Logging Admin
Error Reporting User

Log channel
The plugin has a separate configuration where we can enable and disable the Stack Drive logging, but how does it integrate with the Laravel logging channel?
Our app being doesn't have write permission, therefore we would like to use Stack Driver as the only logging channel. Is it possible? Is enabling Stack Driver supposed to disable other logging channels?

How to make it work?
After installing the package, and adding a configuration nothing happens:
 STACKDRIVER_ENABLED=true
 STACKDRIVER_LOGGING_ENABLED=true
 STACKDRIVER_TRACING_ENABLED=false
 STACKDRIVER_ERROR_REPORTING_ENABLED=true
 STACKDRIVER_KEY_FILE_PATH=storage/keyfile.json

Nothing appears in the Google Cloud Console, current logging channel is still used, and no error related to this package appears in there. When the key file path is wrong, there are no errors either.

See: https://github.com/googleapis/google-auth-library-php/blob/cccae18e0ef9d156e0971087a2580f0e3c232896/src/Credentials/UserRefreshCredentials.php#L89

Required roles is dependent on your setup/environment. Google lists the available roles on these pages:

https://cloud.google.com/error-reporting/docs/iam
https://cloud.google.com/trace/docs/iam
https://cloud.google.com/logging/docs/access-control

At the very minimum, you'd want to add the writer roles.

Right now, our logging system doesn't integrate with Laravel's default logging system. Potentially we could change this, but I currently don't have much time to look at that. Maybe you could shoot in a PR if you're interested in looking at this.

Otherwise, in your case, it should be possible/suffice to just disable the default Laravel logger.

This seems like a weird issue. Potentially environmentally related. Having said that, I personally have not used this repo in a while. I'll quickly check it out and see if I can still get it to work.

So I had a look, and I can still get everything to work. Some pointers if you don't see anything appear in GCP:

Disable the batching features (for instance, by default, logs are sent in batches of 50)
Select the correct resources when looking for logs/traces in GCP
I made a service account with the following three roles:

Thank you for checking on your side. I followed your instructions, it still doesn't work, but at least the package is loaded and reacts to configuration changes.
The problem was the cache of composer and Laravel. After clearing them, I now get errors when the keyfile does not exist:
composer dump-autoload
php artisan config:clear

But there is still nothing on the Google Console.
Maybe I do not understand how this plugin is supposed to work.
My controller has a log command and I expect to see this log message on Stackdriver :
\Log::debug('New log entry!');
This is my .env:
STACKDRIVER_ENABLED=true
STACKDRIVER_LOGGING_ENABLED=true
STACKDRIVER_TRACING_ENABLED=false
STACKDRIVER_ERROR_REPORTING=true
STACKDRIVER_PROJECT_ID=my-project-name
STACKDRIVER_KEY_FILE_PATH=../storage/key.json

The readme doesn't say anything about that, but I also tried replacing stack config by:
LOG_CHANNEL=stackdriver

Disable the batching features (for instance, by default, logs are sent in batches of 50)

I suppose it is irrelevant if I did not set up the batch daemon?

I think the readme can/should be more clear about the batch daemon. Regardless of whether you have it running, everything is send to Google's APIs in batches. The Google Stackdriver docs explains why:

The PSR-3 logger sends the logs synchronously. This means that whenever you emit a log, it will add RPC latency to the user request. Especially if you emit multiple logs in a single request, the added latency will be significant. You probably want to avoid that.

Hence, I decided to set batchEnabled to true by default (check your stackdriver.php config).
Now, about the daemon, I tried looking for detailed docs on why this is recommended/what it does exactly, but I couldn't find anything right now. Maybe have a look at this directory:
https://github.com/googleapis/google-cloud-php/tree/master/Core/src/Batch
What I remember from implementing this a while back is that despite the batching, once every X requests would still be delayed due to the traffic to and from the google servers. This is where the daemon comes in. I think it takes care of the batching and talking to Google, allowing your application to run without delays.
Finally, I advise you to look at how the logger client is set up:
https://github.com/GlueDev/laravel-stackdriver/blob/develop/src/Stackdriver.php#L39-L51
Then, check out Google's docs:
https://googleapis.github.io/google-cloud-php/#/docs/google-cloud/v0.118.0/logging/psrlogger
I should make this more clear in the docs of this package, and I will do so when I find the time for that :).


Deprecation warning cannot be silenced

Normal use of IceCube leads to annoying deprecation warning with no apparent remedy:
> schedule = IceCube::Schedule.new(Time.now)
=> #<IceCube::Schedule:0x007fc546c83aa8 @start_time=2014-07-31 13:13:12 -0500, @all_recurrence_rules=[], @all_exception_rules=[]>
> yaml = schedule.to_yaml
=> "---\n:start_time: &1 2014-07-31 13:13:12.818231000 -05:00\n:start_date: *1\n:rrules: []\n:rtimes: []\n:extimes: []\n"
> IceCube::Schedule.from_yaml(yaml)
IceCube: :start_date is deprecated, please use :start_time at: /Users/markmceahern/.gem/ruby/2.1.1/gems/ice_cube-0.12.1/lib/ice_cube/parsers/hash_parser.rb:11:in `to_schedule'
=> #<IceCube::Schedule:0x007fc5417ae488 @start_time=2014-07-31 13:13:12 -0500, @all_recurrence_rules=[], @all_exception_rules=[]>

Does IceCube.compatibility = 12 disable features? I am getting the spurious deprecation message as well, but I don't want to disable features I am dependent on.

Looks ok in the source.

I'm having the same error in the ice_cube-0.13.0. Is this issue still persisting? Does this fix work for later versions of IceCube?

Followed @m5rk suggestion and added an initializer with IceCube.compatibility = 12  and it fixed the error. Thanks!


Added fix cf. to breaking changes in #2251

Closes: #2262
Description

PR author checklist:

[ ] Added changelog entry, using unclog.
[ ] Added tests: integration (for Hermes) or unit/mock tests (for modules).
[ ] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

There is also the script scripts/init-hermes which uses the old key-name flag for hermes keys add which uses the old flag -n instead of the new -k. Should the change be made in this PR as well ?

Should the change be made in this PR as well ?

Please feel free to do it, thank you!


Allow nodepool deletion when hcluster is gone

Currently, nodepool deletion will fail if the hostedcluster doesn't
exist anymore which means that if nodepool deletion is too slow, we will
deadlock. This fixes that.
Note that this introduces an backwards-incompatible change to how
machinedeployments are named. This means that the hypershift operator
will create a new machinedeployment for existing nodepools when
upgraded. The same goes for cleanup, the machinedeployment will be
deleted transiently by the garbage collector controller, however the
same goes for the capi pods, hence cleanup might not work automatically.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

This lgtm but I'd like @enxebre to tag it since I don't have knowledge of any downstream impacts within CAPI

Currently, nodepool deletion will fail if the hostedcluster doesn't
exist anymore which means that if nodepool deletion is too slow, we will
deadlock. This fixes that.

@alvaroaleman I'm +1 to this PR to keep programatic decoupling but I think is independent from the problem in the description: Atm HC deletion just triggers all NodePools deletion and moves on, I think we should also keep the finaliser and block HC deletion until NodePools are actually gone.

Thanks!
/lgtm
/hold
feel free to unhold.
I'll follow up to add a mechanism to block HC removal from etcd until all nodePools are gone.

/hold cancel

/retest-required


Causeway 3428

My intention is to merge CAUSEWAY-3428 into spring6.
There should be ~ three files chnanged.
The UI irritates me a bit - please cross check.

I just merged latest changes from master into spring6. So this PR is no longer valid and can be closed. I'll close so we don't merge by accident.


UTF-8 (i'm using the 1.0.8-hotfix)

obfuscated:
https://prnt.sc/10kq64r
https://prnt.sc/10kq8ce
https://prnt.sc/10kq80e
without obfuscation:
https://prnt.sc/10kqawa

Okay, this should hopefully be fixed. Can you test the latest release?

Okay, this should hopefully be fixed. Can you test the latest release?
It's working!


Update for Frequency 1.4.0 and DSNP 1.2.0

Problem
Needed to add the schemas for the upcoming DSNP 1.2.0 release.
Change summary:

Updated the DSNP schemas for 1.2.0
Updated to Frequency 1.4.0 (still at rc3)
Cleaned up the deploy and read logic and made it easier to add new DSNP Schemas

Steps to Verify:

Run Frequency 1.4.0 locally
npm run deploy
npm run read
See that they all deployed and are working!

I see we're adding a "Private Follows" schema, which is similar to "Private Connections", but without prids. Are we sure about that? I realize we don't need PRIds for messaging with follows, but wouldn't they still be useful for proof-of-follow?

@JoeCap08055 I think we need to keep them out for now. The DSNP Spec doesn't specify it and I think proof of following needs to be investigated separately.


Logcat monitor

The code could probably do with some cleanup, but I wanted to get some feedback before investing too much time into it.
This was made due to a need to parse logcat with lines that can come out of order. Furthermore, most of the logcat parsing done in LISA was copy-pasted from one workload to another, so I wanted to centralize that.
The idea here is to have a thread that reads from logcat, and it can also look for certain regexps (by default '.*', so every line will be logged). We can then search for all the lines matching a given regexp. The general use case is:
# All regexps that will be used during the workload execution
my_regexps = [...]

logcat = target.logcat_monitor(my_regexps)
logcat.start()

my_workload.run()

logcat.search(WORKLOAD_START_REGEXP)
print "workload started !"

logcat.search(WORKLOAD_END_REGEXP)
print "workload ended !"

logcat.stop()

@setrofim Thanks for the feedback !
I wanted to add something regarding the regexp matching: my initial 'pitch' was that, since we know in advance the regexps we're going to try to find in logcat, we can feed that to the monitor and reduce the amount of lines to collect - and in fine reduce the amount of lines to go through for individual line matching.
As such, I think the regexp(s) should be a mandatory parameter. Now, there is the problem of overhead - continuously running unoptimised regexps on the device could noticeably impact the test/benchmark we're running, but I was under the impression that sending every single line via ADB to the host machine (for later regexp matching on the host) would be just as inefficient if not worse. What do you think ?

You're making the following assumption:

since we know in advance the regexps we're going to try to find in logcat

This may be valid for your use case, but it won't always be in general. Logcat contains a wealth of information about the activity in the system and our strategy is often to collect all of it. Even if the primary goal is to extract specific information from it, we want the rest in cause we need to debug some issue.

As such, I think the regexp(s) should be a mandatory parameter

It isn't in your current implementation -- you're giving it a default, so it's not mandatory for the user.

but I was under the impression that sending every single line via ADB to the host machine (for later regexp matching on the host)

Well, you'd be transmitting more data, but doing less on-target processing on it. Whether or not this will result in lighter or heavier processing load, I would not want to guess without doing some profiling. But this is moot -- you're missing my point.
You're defaulting the regex to '.*' which matches every line, so this will return everything anyway. My proposal is to, by default, not use regex. That will be functionally equivalent -- returning every line, but without the pointless matching of '.*' on every line.

This may be valid for your use case, but it won't always be in general. Logcat contains a wealth of information about the activity in the system and our strategy is often to collect all of it. Even if the primary goal is to extract specific information from it, we want the rest in cause we need to debug some issue.

Fair enough, I'll go with logging everything by default then.

Here's what's new:

No regexp matching by default
New lines are added to a queue, and queue is flushed to a file either

If queue size reaches a threshold
Whenever a user requests data from the monitor (e.g. call to get_log() or search())

And here are my comments:

At this point it's pretty much an implementation of TraceCollector, so I was wondering if I shouldn't just move the code from utils/android to trace/logcat ?
For now the log file is a tempfile that is never destroyed. I might change it a bit to fit get_trace() of TraceCollector - I'd prefer to avoid forcing the user to work with a file for very simply use cases (which covers a good bunch of what I'll do once this is merged).

As I've mentioned in an earlier comment, there should be a TraceCollector implementation for this. I don't have a strong opinion right now on whether it is better to turn this into a TraceCollector subclass directly, or whether to create a TraceCollector wrapper for the monitor.

For now the log file is a tempfile that is never destroyed.

This should be done in TraceCollector's reset().

I'd prefer to avoid forcing the user to work with a file for very simply use cases (which covers a good bunch of what I'll do once this is merged)

Sure, that makes sense. There is nothing to stop you from adding other methods, in addition to those defined by the TraceCollector's API, that implement the semantics you need. As long as the API is fully implemented.
It might also be worth considering extending the API to handle these sorts of use cases. Though we'd need to make sure it is sufficiently detailed to be implementable by all trace collectors.

As I've mentioned in an earlier comment, there should be a TraceCollector implementation for this. I don't have a strong opinion right now on whether it is better to turn this into a TraceCollector subclass directly, or whether to create a TraceCollector wrapper for the monitor.

I created a trace/logcat.py file and moved the LogcatMonitor there. I added the LogcatCollector wrapper in there as well. I think it's cleaner but if you disagree I can have it split over trace/logcat and utils/android
I also removed the getter in target since this is all in trace/logcat, but again I could add it back if it makes more sense.

As far as I can tell, the LogcatCollector will be used to simply record what is going on a device, whereas the LogcatMonitor will be used when you're looking for specific things within logcat.

Since the monitor is not not itself a TraceCollector, I don't think it should be under trace/ and I would move it back to utils/android. Other than that, looks good.

@setrofim I think this version addresses all of your comments

It is valid for reset to be called prior to the initial run, so just return here, rather than raise an error.
Done


Fix/lint errors

closes #5

now passes colcon test locally
while fixing these I made a new msg_types.hpp header to be the single using ImageMsg in the package

closes #6

oh oops this also as the fixes from the other PR open right now....I can rebase once that ones merged

also just an FYI to @MatthiasKillat, in order to pass the typical ROS 2 CI I ran ament_copyright --add-missing and added your name as the Copyright holder to add that to each header file....hope thats OK.

Your input is much appreciated. I had no real time to work on this and it was was just some small experiment to check the benefits of zero-copy under somewhat real conditions. I will further work on this once I get time and refine a plan for a real pipeline controlled by an executor.


[SPARK-21188][CORE] releaseAllLocksForTask should synchronize the whole method

What changes were proposed in this pull request?
Since the objects readLocksByTask, writeLocksByTask and infos are coupled and supposed to be modified by other threads concurrently, all the read and writes of them in the method releaseAllLocksForTask should be protected by a single synchronized block like other similar methods.
How was this patch tested?
existing tests

Can one of the admins verify this patch?

ok to test.
cc @JoshRosen

add to whitelist

Test build #78539 has started for PR 18400 at commit 5cdd328.

Test build #78539 has finished for PR 18400 at commit 5cdd328.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78539/
Test FAILed.

retest this please

Test build #78555 has started for PR 18400 at commit 5cdd328.

Test build #78555 has finished for PR 18400 at commit 5cdd328.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78555/
Test FAILed.

Merged build finished. Test FAILed.

I actually asked @liufengdb to submit this PR after he spotted this problem while debugging a test.
I did a bit of digging and spotted where this bug was introduced: in https://github.com/JoshRosen/spark/commit/b9d6e181db0c7293b0b00b3a679716f652df936f, an intermediate commit in an old PR, this was introduced when refactoring one map from a thread-safe LoadingCache (where entires were implicitly created) to an explicit map with explicit registration (which used synchronization). In making this change I incorrectly preserved a bad synchronization pattern which was unnecessarily fine-grained.
Therefore this looks like the right change to me so I'm going to retest and merge.

jenkins retest this please

Test build #78571 has started for PR 18400 at commit 5cdd328.

Test build #78571 has finished for PR 18400 at commit 5cdd328.

This patch fails PySpark pip packaging tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78571/
Test FAILed.

retest this please

Test build #78585 has started for PR 18400 at commit 5cdd328.

Test build #78585 has finished for PR 18400 at commit 5cdd328.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78585/
Test FAILed.

retest this please

Test build #78909 has started for PR 18400 at commit 5cdd328.

Test build #78909 has finished for PR 18400 at commit 5cdd328.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78909/
Test PASSed.

LGTM. Merging to master. Thanks!


Uniwill not initializing on Intel Whitebook qc7

Expected Behaviour
Keyboard lighting should work as shown in Aurora. Uniwill should be renamed to Komplett/XMG/etc as in version 7.2 beta posted here:
https://www.notebookchat.com/index.php?topic=105082.0
Actual Behaviour
I can select Uniwill 550 (ISO) and nordic layout and it shows as my keyboard. when typing the colors change in Aurora but not on the actual keyboard. Uniwill doesn't get Initialized. It should?
I've got a PS4 controller working but not the keyboard.
Reproduction steps
I have the latest Control Center <IP_ADDRESS>, latest Aurora Build and drivers installed. I choose my keyboard in Devices and Wrappers. Tried reinstalling Windows.
Frequency
Every time. I have never got it to work.
Aurora Version:
I've tried several different versions. Now running 0.8.1
Previously an Issue?
Don't know.
Log
[INFO] 19:50:19:
Operation System: Windows 10 Pro
System Architecture: 64 bit
Environment OS Version: Microsoft Windows NT 6.2.9200.0
System Directory: C:\WINDOWS\system32
Executing Directory: C:\Program Files\Aurora
Launch Directory: C:\Program Files\Aurora
Processor Count: 12
SystemPageSize: 4096
Environment Version: 4.0.30319.42000
Is Elevated: True
Aurora Assembly Version: <IP_ADDRESS>
Aurora File Version: 0.8.1
[INFO] 19:50:20: [ASUS] Could not find Asus Aura SDK, please install version v1.07.71
[INFO] 19:50:20: Loading Configuration
[INFO] 19:50:20: Loading Plugins
[INFO] 19:50:20: Loading KB Layouts
[INFO] 19:50:21: Loading Input Hooking
[INFO] 19:50:21: Loading RazerSdkManager
[INFO] 19:50:21: RazerSdkManager loaded successfully!
[INFO] 19:50:21: Loading Applications
[INFO] 19:50:24: Fetching latest pointers
[INFO] 19:50:24: Loading Device Manager
[INFO] 19:50:24: Loading LGS DLL
[ERROR] 19:50:24: Logitech LED SDK could not be initialized. (LogiLedSetTargetDevice or LogiLedSaveCurrentLighting failed)
[INFO] 19:50:24: Device, Logitech, was not initialized
[ERROR] 19:50:24: RGB.NET device (Corsair), Exception! Message: Error in the application.
[INFO] 19:50:24: Device, Corsair, was not initialized
[INFO] 19:50:24: Razer device, Initialized
[INFO] 19:50:30: Device, Razer, was initialized
[ERROR] 19:50:30: Roccat device, Exception! Message:System.Exception: No devices connected
at Aurora.Devices.Roccat.RoccatDevice.Initialize() in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\Roccat\RoccatDevice.cs:line 213
[INFO] 19:50:30: Device, Roccat, was not initialized
[ERROR] 19:50:30: Clevo device, Exception! Message:System.Exception: Could not connect to Clevo WMI Interface
at Aurora.Devices.Clevo.ClevoDevice.Initialize() in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\Clevo\ClevoDevice.cs:line 71
[INFO] 19:50:30: Device, Clevo Keyboard, was not initialized
[INFO] 19:50:30: No Cooler Master devices successfully Initialized!
[INFO] 19:50:30: Device, Cooler Master, was not initialized
[ERROR] 19:50:30: SteelSeries GameSense SDK could not be initialized: System.IO.FileNotFoundException: Core Props file could not be found at "C:\ProgramData/SteelSeries/SteelSeries Engine 3/coreProps.json"
at SteelSeries.GameSenseSDK.GameSenseSDK.init(String sseGameName, String sseGameDisplayname, Byte iconColorID) in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\SteelSeries\GameSenseSDK.cs:line 58
at Aurora.Devices.SteelSeries.SteelSeriesDevice.Initialize() in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\SteelSeries\SteelSeriesDevice.cs:line 55
[INFO] 19:50:30: Device, SteelSeries, was not initialized
[INFO] 19:50:30: No Wooting devices successfully Initialized!
[INFO] 19:50:30: Device, Wooting, was not initialized
[INFO] 19:50:30: Device, SoundBlasterX, was not initialized
[INFO] 19:50:30: Device, LightFX, was not initialized
[ERROR] 19:50:30: Drevo Radi SDK could not be initialized.
[INFO] 19:50:30: Device, Drevo, was not initialized
[ERROR] 19:50:30: Device YeeLight encountered an error while connecting. Exception: System.Net.Sockets.SocketException (0x80004005): The requested address is not valid in its context <IP_ADDRESS>:55443
at System.Net.Sockets.Socket.DoConnect(EndPoint endPointSnapshot, SocketAddress socketAddress)
at System.Net.Sockets.Socket.Connect(EndPoint remoteEP)
at System.Net.Sockets.Socket.Connect(IPAddress address, Int32 port)
at Aurora.Devices.YeeLight.YeeLightDevice.Connect(IPAddress lightIP, DoWorkEventArgs token) in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\YeeLight\YeeLightDevice.cs:line 157
at Aurora.Devices.YeeLight.YeeLightDevice.Initialize() in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\YeeLight\YeeLightDevice.cs:line 48
[INFO] 19:50:30: Device, YeeLight, was not initialized
[INFO] 19:50:30: Device, Asus, was not initialized
[INFO] 19:50:30: Vulcan device not initialized
[INFO] 19:50:30: Device, Vulcan, was not initialized
[INFO] 19:50:32: Device, Uniwill, was not initialized
[INFO] 19:50:32: Device, Ducky, was not initialized
[INFO] 19:50:32: Starting GameStateListener
[INFO] 19:50:32: Retrying Device Initialization
[INFO] 19:50:32: Listening for game integration calls...
[INFO] 19:50:32: Loading ResourceDictionaries...
[INFO] 19:50:32: [IPCServer] Pipe created 34739275
[INFO] 19:50:32: [AuroraCommandsServerIPC] Pipe created 44644735
[INFO] 19:50:32: Loaded ResourceDictionaries
[INFO] 19:50:32: Loading ConfigUI...
[DEBUG] 19:50:33: Trying to get game path for: 209870
[DEBUG] 19:50:33: Trying to get game path for: 730
[DEBUG] 19:50:33: Trying to get game path for: 570
[DEBUG] 19:50:33: Trying to get game path for: 239140
[DEBUG] 19:50:33: Trying to get game path for: 219150
[DEBUG] 19:50:33: Trying to get game path for: 232090
[DEBUG] 19:50:33: Trying to get game path for: 49470
[DEBUG] 19:50:33: Trying to get game path for: 43160
[DEBUG] 19:50:33: Trying to get game path for: 241930
[DEBUG] 19:50:33: Trying to get game path for: 200010
[DEBUG] 19:50:33: Trying to get game path for: 270450
[WARN] 19:50:33: Could not find an AutoNode getter method for field '_ParsedData' of type 'JObject'. It will not be automatically populated.
[DEBUG] 19:50:33: Trying to get game path for: 41070
[DEBUG] 19:50:33: Trying to get game path for: 257510
[DEBUG] 19:50:33: Trying to get game path for: 200510
[ERROR] 19:50:55: Logitech LED SDK could not be initialized. (LogiLedSetTargetDevice or LogiLedSaveCurrentLighting failed)
[INFO] 19:50:55: Device, Logitech, was not initialized
[ERROR] 19:50:55: RGB.NET device (Corsair), Exception! Message: Error in the application.
[INFO] 19:50:55: Device, Corsair, was not initialized
[INFO] 19:50:55: [ASUS] Could not find Asus Aura SDK, please install version v1.07.71
[INFO] 19:51:06: Retrying Device Initialization
[ERROR] 19:51:06: Roccat device, Exception! Message:System.Exception: No devices connected
at Aurora.Devices.Roccat.RoccatDevice.Initialize() in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\Roccat\RoccatDevice.cs:line 213
[INFO] 19:51:06: Device, Roccat, was not initialized
[ERROR] 19:51:06: Clevo device, Exception! Message:System.Exception: Could not connect to Clevo WMI Interface
at Aurora.Devices.Clevo.ClevoDevice.Initialize() in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\Clevo\ClevoDevice.cs:line 71
[INFO] 19:51:06: Device, Clevo Keyboard, was not initialized
[INFO] 19:51:06: No Cooler Master devices successfully Initialized!
[INFO] 19:51:06: Device, Cooler Master, was not initialized
[ERROR] 19:51:06: SteelSeries GameSense SDK could not be initialized: System.IO.FileNotFoundException: Core Props file could not be found at "C:\ProgramData/SteelSeries/SteelSeries Engine 3/coreProps.json"
at SteelSeries.GameSenseSDK.GameSenseSDK.init(String sseGameName, String sseGameDisplayname, Byte iconColorID) in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\SteelSeries\GameSenseSDK.cs:line 58
at Aurora.Devices.SteelSeries.SteelSeriesDevice.Initialize() in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\SteelSeries\SteelSeriesDevice.cs:line 55
[INFO] 19:51:06: Device, SteelSeries, was not initialized
[INFO] 19:51:06: No Wooting devices successfully Initialized!
[INFO] 19:51:06: Device, Wooting, was not initialized
[INFO] 19:51:06: Device, SoundBlasterX, was not initialized
[INFO] 19:51:06: Device, LightFX, was not initialized
[ERROR] 19:51:06: Drevo Radi SDK could not be initialized.
[INFO] 19:51:06: Device, Drevo, was not initialized
[ERROR] 19:51:06: Device YeeLight encountered an error while connecting. Exception: System.Net.Sockets.SocketException (0x80004005): The requested address is not valid in its context <IP_ADDRESS>:55443
at System.Net.Sockets.Socket.DoConnect(EndPoint endPointSnapshot, SocketAddress socketAddress)
at System.Net.Sockets.Socket.Connect(EndPoint remoteEP)
at System.Net.Sockets.Socket.Connect(IPAddress address, Int32 port)
at Aurora.Devices.YeeLight.YeeLightDevice.Connect(IPAddress lightIP, DoWorkEventArgs token) in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\YeeLight\YeeLightDevice.cs:line 157
at Aurora.Devices.YeeLight.YeeLightDevice.Initialize() in C:\projects\aurora\Project-Aurora\Project-Aurora\Devices\YeeLight\YeeLightDevice.cs:line 48
[INFO] 19:51:06: Device, YeeLight, was not initialized
[INFO] 19:51:06: Device, Asus, was not initialized
[INFO] 19:51:06: Vulcan device not initialized
[INFO] 19:51:06: Device, Vulcan, was not initialized

Nvm. Found the fix in your discord! 👍

@Djerii how did you fix this?

@Djerii how did you fix this?

Check their discord and search for tongfang. You will need a .dll to get it working.
My rgb's glitches and haven't found a fix for it. So let me know if you get the same result and resolve it :)

Thanks! I found, it, and also talked to DrMeteor who wrote that plugin. They pushed the source code up and I've been playing with it, I think I've found the bug that causes the flickering! I'll let you know if I can get it polished up and working smooth

Np.
Nice! Thanks! Would really appreciate it!
Merry Christmas 🎅


debian repo cannot start, update is needed from a site which is blocked

packet: 0.2.9-3~bpo8+1 amd64
In Turkey the domain torproject.org is blocked.
when trying to start torbrowser-launcher it freezes in downloading.
so the download doesnt start from url:
https://aus1.torproject.org/torbrowser/update_3/release/Linux_x86_64-gcc3/x/en-US

Yup, you should be able to download from a mirror. You can also possible install tor on your system first, and then in the settings you can choose to download Tor Browser anonymously over tor.


Android Websocket errors on closed connections and attempting to send

We have ben seeing a lot of errors on Android using WebSockets with the below error coming through from Google Play.
It seems to be not handled correct when the connection is closed but it's not a error we can easily reproduce.
java.lang.RuntimeException:
at com.facebook.react.modules.websocket.WebSocketModule.send(WebSocketModule.java:221)
at java.lang.reflect.Method.invoke(Native Method:0)
at com.facebook.react.bridge.BaseJavaModule$JavaMethod.invoke(BaseJavaModule.java:319)
at com.facebook.react.cxxbridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:158)
at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method:0)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
at android.os.Looper.loop(Looper.java:154)
at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:196)
at java.lang.Thread.run(Thread.java:762)

React Native version: 0.39.1 (We have also tested this on 0.44 with the same issue)
Platform: Android
Development Operating System: MacOS

I'm afraid that without clear reproduction steps, this issue may not get resolved.

Thanks, unfortunately this is something we are struggling with ourselves as we cannot replicate it no matter what we do, but we seeing tons of issues via the app store.

Thanks for opening the issue! It does not appear like a community member will be able to reliably reproduce this issue. This may be for several reasons; perhaps it affects a particular app but a minimal repro has not been provided, or the issue may be sporadic. As it happens, we need a concrete set of steps that can demonstrably reproduce the issue as this will allow your fellow community members to validate a fix. We'll close the issue for now, but feel free to submit a new issue once you're able to reliably reproduce the issue locally. Thanks for your understanding!

@ddolheguy any luck resolving this issue? We are having this exact same issue and it's being reported daily by our users in the Google Play Store. Unfortunately, I cannot offer any reproduction steps either.
Details
react native:  0.42.0
platform: android
development operating system: macos


Should --generate-hashes imply --allow-unsafe?

Some packages, such as pytest and Markdown, include minimum versions of setuptools in their requirements. Running pip-compile --generate-hashes without --allow-unsafe for those packages creates a requirements.txt file that doesn't work with pip install. This creates a bug that is easy to miss until deployment. Should --allow-unsafe be the default behavior for --generate-hashes?
Environment Versions

OS Type: macOS 10.14.4
Python version: Python 3.5.3
pip version: pip 19.1
pip-tools version: pip-compile, version 3.6.2.dev19+g8a1a8ef

Steps to replicate

New virtualenv:

$ pyenv virtualenv 3.5.3 piptest
$ pyenv local piptest
$ pip show setuptools
Name: setuptools
Version: 28.8.0

Require Markdown, which requires a newer version of setuptools:

$ echo "Markdown" > requirements.in
$ $ pip-compile --generate-hashes
#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile --generate-hashes
#
markdown==3.1 \
    --hash=sha256:fc4a6f69a656b8d858d7503bda633f4dd63c2d70cf80abdc6eafa64c4ae8c250 \
    --hash=sha256:fe463ff51e679377e3624984c829022e2cfb3be5518726b06f608a07a3aad680

Attempt pip install:

$ pip install -r requirements.txt
Collecting markdown==3.1 (from -r requirements.txt (line 7))
  Using cached https://files.pythonhosted.org/packages/f5/e4/d8c18f2555add57ff21bf25af36d827145896a07607486cc79a2aea641af/Markdown-3.1-py2.py3-none-any.whl
Collecting setuptools>=36 (from markdown==3.1->-r requirements.txt (line 7))
ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
    setuptools>=36 from https://files.pythonhosted.org/packages/ec/51/f45cea425fd5cb0b0380f5b0f048ebc1da5b417e48d304838c02d6288a1e/setuptools-41.0.1-py2.py3-none-any.whl#sha256=c7769ce668c7a333d84e17fe8b524b1c45e7ee9f7908ad0a73e1eda7e6a5aebf (from markdown==3.1->-r requirements.txt (line 7))

Expected result
Successful install of Markdown.
Actual result
Install fails because setuptools==41.0.1 is not pinned.
Discussion
Seems like it would be good to do one of the following:

Print a warning to use --allow-unsafe when --generate-hashes is provided and there are unsafe package requirements.
Treat --generate-hashes as implying --allow-unsafe, maybe with a different comment in the generated requirements.txt.

I don't know why pip-compile chooses not to include setuptools or why pip chooses to require it, so I'm not sure what the correct thing to do is, but it seems like pip-compile has all the info it needs to recommend whatever that thing is.
(FWIW this is easy to miss and create latent bugs -- I did pip install Markdown first, which upgraded setuptools and masked the error, and then things broke a few days later when another dev tried to recreate their virtualenv.)

Hello @jcushman,
Thank you for the very detailed report and good catch!

I don't know why pip-compile chooses not to include setuptools

See this comment: https://github.com/jazzband/pip-tools/blob/8a1a8efaf0d4b3d17e57ea69d41b86373264a8f4/examples/protection.in#L1-L2

or why pip chooses to require it

The pip uses setuptools to install packages in editable mode (i.e. setuptools "develop mode"), see:
$ pip uninstall setuptools -y
Uninstalling setuptools-41.0.1:
  Successfully uninstalled setuptools-41.0.1

$ pip install -e git+git@github.com:jazzband/pip-tools.git#egg=pip-tools
Obtaining pip-tools from git+git@github.com:jazzband/pip-tools.git#egg=pip-tools
  Cloning git@github.com:jazzband/pip-tools.git to ./.venv/src/pip-tools
  Running command git clone -q git@github.com:jazzband/pip-tools.git /apps/pip-tools/.venv/src/pip-tools
    ERROR: Complete output from command python setup.py egg_info:
    ERROR: Traceback (most recent call last):
      File "<string>", line 1, in <module>
    ModuleNotFoundError: No module named 'setuptools'
    ----------------------------------------
ERROR: Command "python setup.py egg_info" failed with error code 1 in /apps/pip-tools/.venv/src/pip-tools/

Seems like it would be good to do one of the following:

Print a warning to use --allow-unsafe when --generate-hashes is provided and there are unsafe package requirements.

Sounds good to me. I'd rather to print a warning, instead of implying --allow-unsafe with  --generate-hashes, since it may cause conflicts with the pip. Let a user to decide.

The pip uses setuptools to install packages in editable mode

But that's because the package you're installing is importing setuptools -- not because pip is importing setuptools. pip vendors setuptools and doesn't care what version you have installed locally. You can't break pip itself by pinning setuptools -- you should only have a problem if a target requirement relies on an incompatible version. But that's no different from any other incompatible sub-dependency, and can be resolved the same way.

pip vendors setuptools and doesn't care what version you have installed locally.

It's not vendored, look at here. Pip only calls subprocess setuptools, see this block. But you are right - pip doesn't care the version.

You can't break pip itself by pinning setuptools -- you should only have a problem if a target requirement relies on an incompatible version. But that's no different from any other incompatible sub-dependency, and can be resolved the same way.

It may be some legacy reason to consider the setuptools unsafe.  Insights from creators @nvie @vphilippon @alekzvik would be very helpful.

It's not vendored, look at here.

It's partially vendored. :) From your link, "setuptools is completely stripped to only keep pkg_resources", which is the part of setuptools that pip imports rather than calling as a subprocess.
This discussion leads me to think that --allow-unsafe might actually be safer to use than not use. If you have pytest in your requirements.in then all your deployments will end up with different versions of setuptools based on the time of installation, because pytest will upgrade setuptools for you when it's installed. If you use --allow-unsafe then you end up with identical deployments starting from an identical base image, which sounds safer.

It's partially vendored. :) From your link, "setuptools is completely stripped to only keep pkg_resources", which is the part of setuptools that pip imports rather than calling as a subprocess.

Yes, only pkg_resources.
FTR unsafe packages are also used in pip-sync to ignore uninstall those packages.

I'll close this in favour of #814. Feel free to reopen if there's something to say.

Yep, thanks for closing this! I'm starting to think it might make sense to deprecate --allow-unsafe and make it the default behavior, but that would be as a separate issue/PR for discussion.

hello pleas help what the hash is hier ???????
[18:21:27] [WARNING] there has been a problem while writing to the session file ('OperationalError: attempt to write a readonly database')
[18:21:30] [INFO] retrieved: 07b1e0439ba077bc7bdfbbf2341b1d1f:dc
[18:21:30] [DEBUG] performed 249 queries in 380.19 seconds
[18:21:30] [INFO] retrieving the length of query output
[18:21:30] [INFO] retrieved: 21
[18:23:18] [DEBUG] performed 10 queries in 107.48 seconds
[18:23:18] [DEBUG] starting 8 threads
[18:24:14] [INFO] retrieved: o_i________________ 2/21 (9%)

@jcushman

Yep, thanks for closing this! I'm starting to think it might make sense to deprecate --allow-unsafe and make it the default behavior, but that would be as a separate issue/PR for discussion.

FTR, this topic on StackOverflow reminds me that we should file an issue and discuss it.


It's possible to Set a Tab as a "default tab"? (except the first one, obviusly)

Hello, you find a solution?

Just wanted to check if any update on this or we need to check for other alternative solutions available if any. Thanks.


Define fallback behaviour in {Calendars,Collations,HourCycles,NumberingSystems,CharacterDirection,WeekInfo}OfLocale

This issue is similar to #47.
TimeZonesOfLocale is currently defined to return an empty Array object when no time zones are in use for a specific region. This matches the behaviour of ICU4C. (See also #47)
The other abstract operations ({Calendars,Collations,HourCycles,NumberingSystems,CharacterDirection,WeekInfo}OfLocale) don't define their fallback behaviour. To match the ICU4C behaviour, the description should be updated to say that the locale "und-001" is used as the fallback when the input locale is unsupported. (At least I think that's the default fallback behaviour in ICU4C.)
For example in CalendarsOfLocale, change step 4 from:

Let list be a List of 1 or more unique canonical calendar identifiers, which must be lower case String values conforming to the type sequence from UTS 35 Unicode Locale Identifier, section 3.2, sorted in descending preference of those in common use for date and time formatting in locale.

To something like:

Let list be a List of 1 or more unique canonical calendar identifiers, which must be lower case String values conforming to the type sequence from UTS 35 Unicode Locale Identifier, section 3.2, sorted in descending preference of those in common use for date and time formatting in locale. When no calendar information for locale is available, use the calendar identifiers in common use for the locale "und-001".

For example returning ["gregory"] for new Intl.Locale("tlh").calendars doesn't match the actual calendar used in tlh, but instead reflects that the fallback locale und-001 is used.
There isn't a way for a user to detect when the fallback locale is used instead of the input locale, but that's a pre-existing issue in this proposal.

I do not think we need to define the fallback behavior. The fallback is just part of the locale. Conceputally every locale has a value, the fact that the resource data in ICU does not explicit define them are just a memory optimization strategy to not duplicate the information when that information are the same as the fallback value. The fallback are just an implementation detail that CLDR define based on that data model. Conceptually each locale has every values, either explicitly encoded in the resources or implictly getting from the fallback.

@sffc @zbraniecki @ben-allen @gibson042 - any opinion?

TimeZone is exceptional because it impacts the rendered value of the data. The others are all preference-related, so it makes sense to use a CLDR fallback algorithm (which may do something such as looking up a value from likely subtags).

When no calendar information for locale is available, use the calendar identifiers in common use for the locale "und-001".

This situation, "when no calendar information for locale is available", is still fuzzy. The calendar is defined in CLDR by region, but it may be reasonable for th, not just th-TH, to infer the Buddhist calendar.

TimeZone is exceptional because it impacts the rendered value of the data. The others are all preference-related, so it makes sense to use a CLDR fallback algorithm (which may do something such as looking up a value from likely subtags).

When no calendar information for locale is available, use the calendar identifiers in common use for the locale "und-001".

This situation, "when no calendar information for locale is available", is still fuzzy. The calendar is defined in CLDR by region, but it may be reasonable for th, not just th-TH, to infer the Buddhist calendar.

The input may not be a recognised locale, for example consider new Intl.Locale("xyz") (there isn't an ISO 639 code for xyz) or if no CLDR data is available (new Intl.Locale("egy-Egyh"), for Egyptian in Hieratic script). Most implementations will likely return "ltr" for new Intl.Locale("egy-Egyh").getTextInfo().direction, even though the correct answer should be "rtl".
So for bogus inputs or if no corresponding locale data is available, spec steps like:

[...] sorted in descending preference of those in common use for formatting numeric values in locale.

can't be applied, because neither the preference nor the common use can be determined.

Maybe there was a misunderstanding when I mentioned "fallback"? I didn't mean "fallback" to refer to some locale inheritance scheme, but instead what values should be used as the fallback when no data is available at all.

TG2 discussion: https://github.com/tc39/ecma402/blob/main/meetings/notes-2024-12-19.md#define-fallback-behaviour

This issue is similar to #47.
TimeZonesOfLocale is currently defined to return an empty Array object when no time zones are in use for a specific region. This matches the behaviour of ICU4C. (See also #47)
The other abstract operations ({Calendars,Collations,HourCycles,NumberingSystems,CharacterDirection,WeekInfo}OfLocale) don't define their fallback behaviour. To match the ICU4C behaviour, the description should be updated to say that the locale "und-001" is used as the fallback when the input locale is unsupported. (At least I think that's the default fallback behaviour in ICU4C.)
For example in CalendarsOfLocale, change step 4 from:

Let list be a List of 1 or more unique canonical calendar identifiers, which must be lower case String values conforming to the type sequence from UTS 35 Unicode Locale Identifier, section 3.2, sorted in descending preference of those in common use for date and time formatting in locale.

To something like:

Let list be a List of 1 or more unique canonical calendar identifiers, which must be lower case String values conforming to the type sequence from UTS 35 Unicode Locale Identifier, section 3.2, sorted in descending preference of those in common use for date and time formatting in locale. When no calendar information for locale is available, use the calendar identifiers in common use for the locale "und-001".

For example returning ["gregory"] for new Intl.Locale("tlh").calendars doesn't match the actual calendar used in tlh, but instead reflects that the fallback locale und-001 is used.
There isn't a way for a user to detect when the fallback locale is used instead of the input locale, but that's a pre-existing issue in this proposal.


Upgrade deploy board to py3

Summary
Deploy board is still in py2, this is the last py2 codebase in our systems. Upgrade to py3 so that we can have a better codebase and we can have security updates moving forward
Test plan
Tested locally and on dev1
Together with configs change.

Can we use absolute imports instead of relative?

nit: thoughts on absolute imports vs relative?
just converted some existing py2 imports using relative import in py3. We can convert some relative to absolute for better readability. There are cases where relative one is more convenient though. Most of the time, I would prefer absolute if it's not too lengthy.


Switch to tracing for logging

Switches from the log crate to tracing and adds a bit more logging in some places. This makes some logging in places cleaner with spans and future integration. In the future, we can use a custom subscriber to create a dashboard for a dioxus application

Sweet!! Excited for the custom subscriber.


Adding actors at required (x,y,z) coordinates in Unreal Editor

Hello,
I'm new to carla.
I'm modifying XML config file and trying to add (x,y,z) configuration value to place the ego vehicle and other vehicles in the map. Its really taking lot of time in trial and error to place the actors at positions and do not feel it as convenient way.
I have read in one solution as we can open our map in Unreal editor and place the vehicles at the required positions and then place the configuration values in XML file, I tried to do it but could not find the way.
Please suggest as how to open any one of the map given by carla in UE editor and place the actors at the positions.

For the Unreal editor @glopezdiest might be the best to answer. However, you can also use any OpenDRIVE viewer, get the x-y coordinates, invert the sign of y, and you have your coordinates.

Hey @tecena. Are you working with the packages or from source? In order to open the CARLA maps with Unreal you have to build CARLA from source. From there, you do a make launch to run Unreal which will open up the default town .

On the left you can see an Empty Actor. You can drag into the scene to create that object. On the right, you'll see its transform (in cm, not meters!).

@fabianoboril @glopezdiest
Thank you,
I'm using the Carla from source.


Profiling tool add wholestagecodegen to execs mapping, sql to stage info and job end time

fixes https://github.com/NVIDIA/spark-rapids/issues/5515
We add more information to the profiling tool for multiple things:

add job start and end times
Add the mapping of SQL queries to stage ids. This tables includes the stage duration and the mapping to specific SQL node names(node ids). This will help to quickly see longest stage and see associated nodes and sql query. Note this new table is specifically sorted by the stage time, which is different than all the others..  Note that not all exec nodes have mappings to stage ids so this isn't perfect
Add a mapping of the wholestage code gen id to the actual execs contained in it. This is useful for timings and looking a the metrics to see what was included in each of the wholeStage code gen execs
Add stage ids to the sql plan metrics table

These features were requested to be able to do some post processing on the profile logs to gather more insight into which execs are taking longest and what types of speedup between cpu and gpu runs.  For this is needs to map wholestagecodegen into the node types and try to determine how much time each node is taking to compare to the gpu nodes.
New tables look like:
Job Information:
+--------+-----+---------+-----+-------------+-------------+
|appIndex|jobID|stageIds |sqlID|startTime    |endTime      |
+--------+-----+---------+-----+-------------+-------------+
|1       |0    |[0]      |null |1622846402778|1622846410240|
|1       |1    |[1,2,3,4]|0    |1622846431114|1622846441591|
+--------+-----+---------+-----+-------------+-------------+

SQL to Stage Information:
+--------+-----+-----+-------+--------------+--------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|appIndex|sqlID|jobID|stageId|stageAttemptId|Stage Duration|SQL Nodes(IDs)                                                                                |
+--------+-----+-----+-------+--------------+--------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------+
|1       |0    |1    |1      |0             |8174          |Exchange(9),WholeStageCodegen (1)(10),Scan(13)                                                                                |
|1       |0    |1    |2      |0             |8154          |Exchange(16),WholeStageCodegen (3)(17),Scan(20)

SQL Plan Metrics for Application:
+--------+-----+------+---------------------+-------------+-------------------------+-----------+----------+--------+
|appIndex|sqlID|nodeID|nodeName             |accumulatorId|name                     |max_value  |metricType|stageIds|
+--------+-----+------+---------------------+-------------+-------------------------+-----------+----------+--------+
|1       |0    |0     |WholeStageCodegen (6)|91           |duration                 |3          |timing    |4       |
|1       |0    |1     |HashAggregate        |92           |number of output rows    |1          |sum       |4       |
|1       |0    |1     |HashAggregate        |95           |time in aggregation build|3          |timing    |4       |

WholeStageCodeGen Mapping:
+--------+-----+------+---------------------+-------------------+------------+
|appIndex|sqlID|nodeID|SQL Node             |Child Node         |Child NodeID|
+--------+-----+------+---------------------+-------------------+------------+
|1       |0    |0     |WholeStageCodegen (6)|HashAggregate      |1           |
|1       |0    |3     |WholeStageCodegen (5)|HashAggregate      |4           |
|1       |0    |3     |WholeStageCodegen (5)|Project            |5           |
|1       |0    |3     |WholeStageCodegen (5)|SortMergeJoin      |6           |
|1       |0    |7     |WholeStageCodegen (2)|Sort               |8           |

build


Configurable labels for Form element and Form section on Create New button

Tried to update the labels for Form element and Form section on Create New button, but didn't find the solution yet.
It would be good to configure the labels Form element and Form section on Create New button or (better?) hide that section of the builder.

I'm trying to solve a similar issue.
I'm wondering if I can reuse some of the non-FormBuilder components, such as Card, Add, etc., if they are exported, so I can implement FormBuilder myself.

Closed by #455


metric-windows-network.rb empty output

The network metric script outputs no metric despite the typeperf command providing information.
This seems to be caused by the leading \n in the typeperf output which prevents the CSV.parse function from extracting the headers from the first line.

C:\WINDOWS\system32>metric-windows-network.rb.bat

C:\WINDOWS\system32>

Any chance you could open a PR with that?


Change C code encoding from Latin-1 to UTF-8

I don't think there's a reason to produce plain ASCII in comments, as long as the actual C code (including string literals) that we generate is ASCII.

The only risk I see is that we lose the validation that non-comment lines are plain ASCII. Being able to embed file paths may be worth this downside though.


Add custom events and annotations to graphs

I don't know if this is possible using Rickshaw: define custom events and annotations, and add them to graph. I mean something like this: http://www.flotcharts.org/flot/examples/annotating/index.html
What I'm looking for is the ability to define an event for a given value of X and/or Y. So, this event can be shown in the graph, like the example above.
Many thanks anyway

Hi, you can add annotations by providing an x-axis value and a message as described here:
http://code.shutterstock.com/rickshaw/#annotations
With annotations in place, you should be able to use CSS to achieve a presentation similar to what shows in your example. Good luck!

Link is now a 404


How to snapshot on special iOS version?

SnapshotTesting uses GitHub issues for bugs. For more general discussion and help, please use GitHub Discussions.
Hi @stephencelis @mdiep @gohanlon @ChristopherRogers @heckj
I want to snapshot of a special iOS device and a special iOS OS version, but I find I only can do is set the special iOS device, but I can't set the special iOS OS version.
        assertSnapshots(                 of: hostingController,                 as: [                   "ipad": .image(on: .iPadPro12_9),                   "iphoneSe": .image(on: .iPhoneSe),                   "iphone8": .image(on: .iPhone8),                   "iphoneMax": .image(on: .iPhoneXsMax),                 ])
I got above this from the Demo, But I haven't found any OK solution for adding the special OS version.
Could you give me some advice so that I can set up the special OS version?
Thank you very much.

Hi @davidhu001, this is not an issue with the library and so I am converting it to a discussion.


Failed to resolve component - Would need $ngVueProvider.component

I have a rather special case, but i hope you can help me.
I built an WYSIWG editor with bootstrap components and i am currently porting the HTML result (frontend-user's view) to vue components.
To understand the problem i have a compile-html directive in angular and now as a vue component:
AngularJS:
/**
 * Used to make uib-accordion work inside ng-bind-html
 */
export default function compileHtml($compile) {
  return {
    restrict: 'AE',
    link: function (scope, element, attr) {
      attr.$observe('ngBindHtml',function(){
        if(attr.ngBindHtml){
          $compile(element[0].children)(scope);
        }
      });
    }
  };
};

Vue3:
<script>
// IMPORTANT: you must import `compile` from this file! Standard Vue builds won't work
import { compile } from 'vue/dist/vue.esm-bundler.js'

export default {
  props: {
    html: String,
  },
  setup(props) {
    // convert to BootstrapVueNext
    return compile(props.html.replace(/uib-accordion/g, 'b-accordion')
      .replace(/div b-accordion-group=""/g, 'b-accordion-item class="card"')
      .replace(/<\/div><\/b-accordion/g, '</b-accordion-item></b-accordion')
      .replace(/<b-accordion-heading/g, '<template #title')
      .replace(/b-accordion-heading/g, 'template')
      .replace(/is-open="isOpen"/g, ':title="$t(\'courses.open.reveal\')"')
      .replace(/uib-tabset/g, 'b-tabs')
      .replace(/uib-tab/g, 'b-tab')
      .replace(/<b-tab-heading/g, '<template #title')
      .replace(/b-tab-heading/g, 'template')
      .replace(/uib-popover-html/g, 'v-b-popover.click.blur.html')
      .replace(/viewbox/g, 'viewBox')) // fix SVGs viewbox
  },
}
</script>

The bootrap components do work because i use $ngVueProvider.use(BootstrapVueNext); and $ngVueProvider.directive('bPopover', vBPopover);. The problem now is, i have some custom components that also need to be compiled and that does not work because i cannot tell ngVueProvider to have a global component.
Adding
$ngVueProvider.component('videojs', Videojs); // need this for compileHtml.vue

would solve my problem, because that works in a standalone Vue app. But unfortunately i get the following error: $ngVueProvider.component is not a function

:thinking: I don't think there is a solution to this currently. The NgVueProvider will need to add a feature to facilitate this as it doesn't actually expose the vue app instance directly. Each instance of a vue component in angular via ngVue is it's own app instance so the provider actually acts like a global store of plugins/directives/injectables for each instance we create. We would also need to store global components for this to work as well.
It should be fairly easy to implement as it would likely just follow the same pattern as directives. I can try and take a look at this later today.

wow thanks for the quick fix :) 👍🏻  that helps a lot!


Compile MXNet error: no matching function for call to ‘std::vector<unsigned int*>::push_back

For bugs or installation issues, please provide the following information.
The more information you provide, the more likely people will be able to help you.
Environment info
Operating System:  ubuntu 16.04
Package used (Python/R/Scala/Julia): python
MXNet version: mxnet (0.10.1)
i am  using python package ,
when i do this:
cd ${MXNET_ROOT}
make -j $(nproc) USE_OPENCV=1 USE_BLAS=openblas USE_CUDA=1 USE_CUDA_PATH=/usr/local/cuda USE_CUDNN=1
there are some error:
g++ -std=c++11 -c -DMSHADOW_FORCE_STREAM -Wall -Wsign-compare -O3 -I/home/cs/mxnet/mshadow/ -I/home/cs/mxnet/dmlc-core/include -fPIC -I/home/cs/mxnet/nnvm/include -Iinclude -funroll-loops -Wno-unused-variable -Wno-unused-parameter -Wno-unknown-pragmas -Wno-unused-local-typedefs -msse3 -I/usr/local/cuda/include -DMSHADOW_USE_CBLAS=1 -DMSHADOW_USE_MKL=0 -DMSHADOW_RABIT_PS=0 -DMSHADOW_DIST_PS=0 -DMSHADOW_USE_PASCAL=0 -DMXNET_USE_OPENCV=1 -I/usr/include/opencv -fopenmp -DMSHADOW_USE_CUDNN=1  -I/home/cs/mxnet/cub -DMXNET_USE_NVRTC=0 -MMD -c src/operator/custom/ndarray_op.cc -o build/src/operator/custom/ndarray_op.o
In file included from src/operator/custom/native_op.cc:7:0:
src/operator/custom/./native_op-inl.h: In member function ‘virtual bool mxnet::op::NativeOpProp::InferShape(std::vectornnvm::TShape, std::vectornnvm::TShape, std::vectornnvm::TShape) const’:
src/operator/custom/./native_op-inl.h:204:36: error: no matching function for call to ‘std::vector<unsigned int>::push_back(nnvm::dim_t)’
shapes.push_back(iter->data());
^
In file included from /usr/include/c++/5/vector:64:0,
from /home/cs/mxnet/dmlc-core/include/dmlc/logging.h:13,
from src/operator/custom/./native_op-inl.h:10,
from src/operator/custom/native_op.cc:7:
/usr/include/c++/5/bits/stl_vector.h:913:7: note: candidate: void std::vector<_Tp, _Alloc>::push_back(const value_type&) [with _Tp = unsigned int; _Alloc = std::allocator<unsigned int>; std::vector<_Tp, _Alloc>::value_type = unsigned int]
push_back(const value_type& __x)
^
/usr/include/c++/5/bits/stl_vector.h:913:7: note:   no known conversion for argument 1 from ‘nnvm::dim_t* {aka long int*}’ to ‘unsigned int* const&’
/usr/include/c++/5/bits/stl_vector.h:931:7: note: candidate: void std::vector<_Tp, _Alloc>::push_back(std::vector<_Tp, _Alloc>::value_type&&) [with _Tp = unsigned int*; _Alloc = std::allocator<unsigned int*>; std::vector<_Tp, _Alloc>::value_type = unsigned int*]
push_back(value_type&& __x)
^
/usr/include/c++/5/bits/stl_vector.h:931:7: note:   no known conversion for argument 1 from ‘nnvm::dim_t* {aka long int*}’ to ‘unsigned int*&&’
In file included from src/operator/custom/ndarray_op.cc:7:0:
src/operator/custom/./ndarray_op-inl.h: In member function ‘virtual bool mxnet::op::NDArrayOpProp::InferShape(std::vectornnvm::TShape, std::vectornnvm::TShape, std::vectornnvm::TShape*) const’:
is anyone here,can help me to deal with it?

I am having the same issue when trying to compile MX-Net 0.1.0 for FGFA https://github.com/msracver/Flow-Guided-Feature-Aggregation
I simply followed the procedure from the FGFA github but it still does not work smoothly.
Note: I manually updated the cub module to its former location (https://github.com/NVlabs/cub), so I should get the version 0.1.0 with all the correct submodules right?
Which version of gcc and cuda, cudnn libraries do you recommend for that particular version?
Thanks

@ElPatou I installed FGFA without problem follow the instruction except when build mxnet with GPU
make -j 4 USE_OPENCV=1 USE_BLAS=openblas USE_CUDA=1 USE_CUDA_PATH=/usr/local/cuda USE_CUDNN=1
I am using cuda 8 + cudnn 6

@selinachenxi  Thanks, I also installed that way using instructions from MXNet website. My issue was with OpenCV: make -j4 USE_OPENCV=0 USE_CUDA=1 USE_CUDA_PATH=/usr/local/cuda USE_CUDNN=1

@sxjscience  can you please remove "Need Triage" label and add "Build" "Question" labels.


Is No more of 10k supported

I 😢😢😢😢 im sad becus 10k
not suppported
[2022-01-08 17:52:27] [WARN] Key count more than 9, returning 10...
And i want blue entrateiment 10k

you can add your algorithm for 10k in options.json


Zone is not defined with Angular 2 beta 0

If I clone https://github.com/AngularClass/angular2-webpack-starter.git and then update the package.json to Angular 2 beta 0 by updating dependencies like so:
    "angular2": "2.0.0-beta.0",
    "rxjs": "5.0.0-beta.0",
    "zone.js": "0.5.10"

Then test the website with npm start and navigating to http://localhost:3000/, angular fails to load and I get an error in the console of:
Uncaught ReferenceError: Zone is not defined
NgZone._createInnerZone @ ng_zone.js:325NgZone @ ng_zone.js:117createNgZone @ application_ref.js:52PlatformRef_.application @ application_ref.js:153bootstrap @ browser.js:101main @ bootstrap.ts:20run @ core.js:96zoneBoundFn @ core.js:69

Any ideas?

can you download the latest changes to the starter repo? I pushed a fix to this any a few others last night

Sorry @gdi2290, you're absolutely right - the latest runs perfectly, thank you!
Incidentally, doing a fresh clone and npm install gave me this:
npm ERR! peerinvalid The package<EMAIL_ADDRESS>does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer<EMAIL_ADDRESS>wants<EMAIL_ADDRESS>
I downgraded to 0.33.3 thought and it's fine... is that the correct thing to do?

Angular2 needs to update their repo to accept anything higher than 0.33.3 tbh. Can you make a pull request to lower the version so we won't see the warning

Done.
One more thing, I noticed in Angular's angular2-seed project they do import 'angular2/bundles/angular2-polyfills'; to handle their polyfills:
https://github.com/angular/angular2-seed/blob/master/src/vendor.ts#L1
I tried changing your vendor.cs polyfills section to use that and it seems to work fine, so might be a nice simplification.  I can do a PR if you agree.

I did the PR for the one in that repo :p there is more benefit if we manually do it (sourcemaps)

Ha, ok, makes sense!


MinLength is not really minimum

    func validate(value: String) -> Bool {
        return countElements(value) > DEFAULT_MIN_LENGTH
    }

So if the minimum is 6, and I have 6 characters, it should be valid, but isn't. Only 7 is valid in this example.
The correct should be to use >=.
Parallel: the minimum wage is $7.25, so the least you can legally pay someone is $7.25, not $7.26.

Thanks!


feat: support format json

<EMAIL_ADDRESS>支持使用 prettier 格式化 json 文件

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.15 :tada:

Comparison is base (5049e1a) 77.75% compared to head (0e843da) 77.91%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
+ Coverage   77.75%   77.91%   +0.15%
==========================================
  Files          32       32
  Lines         980      987       +7
  Branches      196      197       +1
==========================================
+ Hits          762      769       +7
  Misses        215      215
  Partials        3        3

Impacted Files
Coverage Δ

packages/generate-project/src/formatFileContent.ts
100.00% <ø> (ø)

packages/generate-project/src/ejsRenderDir.ts
96.29% <100.00%> (+1.29%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


delete Secret for external RHCS

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2089446
delete rook-ceph-external-cluster-details Secret as a part of SS deletion.
Signed-off-by: sanjalkatiyar<EMAIL_ADDRESS>

@iamniting @umangachapagain PTAL.

/cherry-pick release-4.12


fix test for segmented control

cc @nataliesampsell
The current test intermittently fails because it's not awaited on the golden file comparison.  It'd done right a few lines above, just making this one consistent.

Well, looks like it still fails - is the golden file correct?

This got fixed.


[CLI] Include Github CLI gh from homebrew repository by default

Github CLI is published on homebrew repositories, include in dockerfile layer by default.
https://github.com/DigitalTransformation/vs-code-container-with-ssl/blob/215a095e51d3cfd17d45d223d1d4084f24a7cbf2/dockerfile#L75-L76

Resolved. Merge upstream changeset 937c82681edc39746aca45f9a1d818aa35fe82ca