Please add simple example of what you mean in "Why do my tests take so long to compile? page".

You say to have a single file with #define CATCH_CONFIG_MAIN and #include "catch.hpp", but I don't understand where the tests would be. Are you saying that you would have foo.cpp foo_test.cpp and catch.cpp (with the two lines) all compiled together. Then you might have bar.cpp so you would compile bar.cpp, bar_test.cpp and catch.cpp together for testing bar code? Then if you had foobar.cpp (that depends on foo and bar) you would compile foo.cpp, foo_test.cpp, bar.cpp, bar_test.cpp, foobar.cpp, foobar_test.cpp, and catch.cpp all together?
You do a great job of explaining why it is slow but don't explain very well what a solution would look like other than saying a single cpp file with the two lines. I think the simple example (of a real world situation) would make everything clear.
Thanks,
SLDR
(Stephen L. De Rudder)
URL: https://github.com/philsquared/Catch/blob/master/docs/slow-compiles.md
PS: Call it best practices if you don't want everyone just blindly doing it this way, but for people with large projects that don't want to blaze their own path or reinvent the wheel; an example for many c++ modules with dependencies would get them off the ground quick.
PSS: My $0.02 worth.

Compile all test files, including catch.cpp which contains the two lines, into their object files, like catch.o, test_bar.o, test_foo.o, and link them together, along with the library you want to test against, into one executable.  Any build system will normally do this.  For CMake, that will be 3:
file(GLOB tests_srcs tests/*.cc)   # let's say your test_*.cc files are under "tests" folder
add_executable(run ${tests_srcs})  # and the test executable is "run"
target_link_libraries(run your_library_target)
add_test(testall tests/run)        # and the executable also lies under "tests" folder

Or see my gist, CATCH - Small complete multi-file example.

I think it would be instructional to include simple compilation commands with examples, like
Compile file with main once:
g++ -c tests-main.cpp

Subsequently use above object file:
g++ -o tests-main tests-main.o tests-factorial.cpp && tests-main

@martinmoene How about changing the last paragraph to this?

After compiling tests-main.cpp once, by doing g++ -c tests-main.cpp, it is enough to link the resulting object file with separately compiled tests-factorial.cpp, like so g++ tests-main.o tests-factorial.cpp -o tests. This means that adding more tests to tests-factorial.cpp, will not result in recompiling Catch's main and the resulting compilation times will decrease substantially.

The text nicely explains it. Adding a commandline (in some form) may make it easier to quickly see the point.

My suggestion comes from how we scan-read (web) pages to find the information we need. Just like titles, a command line stands off from the main text and draws our attention helping find what we need and determine if we need/want to read the nearby text any further.
In general, I think it's helping a reader to present examples with compilation command and output. Doing so obviates the need for the reader to guess what's not there (even if that may seem obvious for the writer) and it reassures the reader they are understanding the matter at hand.

Ok, I expanded the section a bit more yet.

@horenmar Now even better that I imagined 😄
PS I think the first line of the final command set can/should be removed.

That was not supposed to be there!


DX: DocumentationGenerator - no need to re-configure Differ

follows #5585 ,
@kubawerlos , we have actually a FullDiffer class ready for exact case how use configured the differ

Coverage remained the same at 91.848% when pulling d0382cebda5b6fa9d9651a2b69dae9c30332ffef on keradus:2.18_follow_5585 into 8e8778b75cdff96254b3a7c97192b78f3fc41f5e on FriendsOfPHP:2.18.


TypeError: object of type 'ImageDataGenerator' has no len()

Hi all!
I have an error when I am trying to use ImageDataGenerator with flow_from_directory function for transfer learning of NasNet model from keras.applications.
OS: ArchLinux
Tensorflow version: 1.12.0
Keras version: 2.2.4 (updated from master)
GPUs: GeForce GTX 1080 Ti
CUDA version: 9.0.176-4
CUDNN version: 7.0.5-2
My code:
from keras.preprocessing.image import ImageDataGenerator
from keras.models import Model
from keras.layers import Dense, GlobalAveragePooling2D
from keras import backend as K
from keras.optimizers import SGD, Adam
from keras.callbacks import ModelCheckpoint

TRAIN_SAMPLES = 2081
TEST_SAMPLES = 904
BATCH_SIZE = 32

TRAIN_DATA_DIR = './train'
TEST_DATA_DIR = './test'

# create the base pre-trained model
base_model = NASNetMobile(weights='imagenet', include_top=False)

# add a global spatial average pooling layer
x = base_model.output
x = GlobalAveragePooling2D()(x)
# let's add a fully-connected layer
x = Dense(1024, activation='relu')(x)
# and a logistic layer -- let's say we have 200 classes
predictions = Dense(200, activation='softmax')(x)

# this is the model we will train
model = Model(inputs=base_model.input, outputs=predictions)

# first: train only the top layers (which were randomly initialized)
# i.e. freeze all convolutional InceptionV3 layers
for layer in base_model.layers:
    layer.trainable = False

# prepare train dataset
train_gen = ImageDataGenerator(rescale=1. / 255,
                               shear_range=0.2,
                               zoom_range=0.2,
                               horizontal_flip=True)

train_gen.flow_from_directory(directory=TRAIN_DATA_DIR,
                              target_size=base_model.input.shape[1:3],
                              class_mode='categorical',
                              batch_size=BATCH_SIZE,
                              shuffle=True)

# prepare test dataset
val_gen = ImageDataGenerator(rescale=1. / 255)

val_gen.flow_from_directory(directory=TEST_DATA_DIR,
                            target_size=base_model.input.shape[1:3],
                            class_mode='categorical',
                            batch_size=BATCH_SIZE)

# compile the model (should be done *after* setting layers to non-trainable)
model.compile(optimizer=Adam(lr=0.00001), loss='categorical_crossentropy')

checkpoint = ModelCheckpoint(filepath="./NasNet_mobile_model_weights.h5",
                             monitor=["acc"],
                             verbose=1,
                             mode='max')

# train the model on the new data for a few epochs
model.fit_generator(train_gen,
                    steps_per_epoch=TRAIN_SAMPLES//BATCH_SIZE,
                    epochs=50,
                    validation_data=val_gen,
                    validation_steps=TEST_SAMPLES//BATCH_SIZE,
                    callbacks=[checkpoint],
                    verbose=2,
                    workers=4
                    )

Output I get:
Using TensorFlow backend.
2019-02-01 10:07:40.704532: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1432] Found device 0 with properties:
name: GeForce GTX 1080 Ti major: 6 minor: 1 memoryClockRate(GHz): 1.582
pciBusID: 0000:02:00.0
totalMemory: 10.91GiB freeMemory: 10.76GiB
2019-02-01 10:07:40.856400: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1432] Found device 1 with properties:
name: GeForce GTX 1080 Ti major: 6 minor: 1 memoryClockRate(GHz): 1.582
pciBusID: 0000:03:00.0
totalMemory: 10.92GiB freeMemory: 10.76GiB
2019-02-01 10:07:41.022663: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1432] Found device 2 with properties:
name: GeForce GTX 1080 Ti major: 6 minor: 1 memoryClockRate(GHz): 1.582
pciBusID: 0000:82:00.0
totalMemory: 10.92GiB freeMemory: 10.76GiB
2019-02-01 10:07:41.204602: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1432] Found device 3 with properties:
name: GeForce GTX 1080 Ti major: 6 minor: 1 memoryClockRate(GHz): 1.582
pciBusID: 0000:83:00.0
totalMemory: 10.92GiB freeMemory: 10.76GiB
2019-02-01 10:07:41.206764: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1511] Adding visible gpu devices: 0, 1, 2, 3
2019-02-01 10:07:42.265616: I tensorflow/core/common_runtime/gpu/gpu_device.cc:982] Device interconnect StreamExecutor with strength 1 edge matrix:
2019-02-01 10:07:42.265657: I tensorflow/core/common_runtime/gpu/gpu_device.cc:988]      0 1 2 3
2019-02-01 10:07:42.265663: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1001] 0:   N Y N N
2019-02-01 10:07:42.265667: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1001] 1:   Y N N N
2019-02-01 10:07:42.265670: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1001] 2:   N N N Y
2019-02-01 10:07:42.265674: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1001] 3:   N N Y N
2019-02-01 10:07:42.266421: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1115] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:0 with 10401 MB memory) -> physical GPU (device: 0, name: GeForce GTX 1080 Ti, pci bus id: 0000:02:00.0, compute capability: 6.1)
2019-02-01 10:07:42.266867: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1115] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:1 with 10403 MB memory) -> physical GPU (device: 1, name: GeForce GTX 1080 Ti, pci bus id: 0000:03:00.0, compute capability: 6.1)
2019-02-01 10:07:42.267168: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1115] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:2 with 10403 MB memory) -> physical GPU (device: 2, name: GeForce GTX 1080 Ti, pci bus id: 0000:82:00.0, compute capability: 6.1)
2019-02-01 10:07:42.267448: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1115] Created TensorFlow device (/job:localhost/replica:0/task:0/device:GPU:3 with 10403 MB memory) -> physical GPU (device: 3, name: GeForce GTX 1080 Ti, pci bus id: 0000:83:00.0, compute capability: 6.1)
Found 2081 images belonging to 15 classes.
Found 904 images belonging to 15 classes.
Traceback (most recent call last):
  File "/home/smirnvla/PycharmProjects/keras-nasnet/train.py", line 118, in <module>
    verbose=2
  File "/usr/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper
    return func(*args, **kwargs)
  File "/usr/lib/python3.6/site-packages/keras/engine/training.py", line 1418, in fit_generator
    initial_epoch=initial_epoch)
  File "/usr/lib/python3.6/site-packages/keras/engine/training_generator.py", line 133, in fit_generator
    if len(validation_data) == 2:
TypeError: object of type 'ImageDataGenerator' has no len()

Process finished with exit code 1

I tried to debug the code and seems like in this line https://github.com/keras-team/keras/blob/e59570ae26670f788d6c649191031e4a8824f955/keras/engine/training_generator.py#L110 if statement is false due val_gen == False. In the code above variable val_gen could be initialized as False because generator has no next or next functions.
Is it normal behavior?

@Dref360 already answered in #10186. Please look closely at the examples in the documentation. flow_from_directory returns the object you are looking for. Though I believe that the best would be to have a more meaningful error message.
PR welcome for a better error message.


⚠ SolarOscp has degraded performance

In 683e5bd, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 333 ms

Resolved: SolarOscp performance has improved in 8573017 after 16 minutes.


have LRO support rest requests and responses

i haven't started out with a changelog, since it's not quite public, how I'm able to do LRO polling

/azp run python - eventhub - ci

/check-enforcer override


[$500] IOS -  Bottom of Preference page is not transparent

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Action Performed:

Login with any account on iPhone X and above
Go Settings => Preferences
Scroll up and down, observer the bottom of the page.

Expected Result:
Bottom of the Preference page should be transparent
Actual Result:
Bottom of the Preference page is not transparent
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[x] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/8e806bd0-14fc-499b-badd-4c7d53d1225f

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694676966334599
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01687aa628faa714e2
Upwork Job ID:<PHONE_NUMBER>682669568
Last Price Increase: 2023-09-15

Proposal
Please re-state the problem that we are trying to solve in this issue.
Bottom of Preference page is not transparent
What is the root cause of that problem?
We're adding bottomPadding here which make the bottom isn't transparent with the case we didn't have footer component.
https://github.com/Expensify/App/blob/d68263ad664d8a8a81ca859147696df8abfcd480/src/components/IllustratedHeaderPageLayout.js#L59
What changes do you think we should make in order to solve the problem?
Solution 1
We only need the padding if we have the footer so we should update the condition:
 !isOffline ? safeAreaPaddingBottomStyle : {}
to
!isOffline && !_.isNull(footer) ? safeAreaPaddingBottomStyle : {}
Solution 2:
Remove  !isOffline ? safeAreaPaddingBottomStyle : {} and update style of the FixedFooter:
const safeAreaMarginBottom = StyleUtils.getSafeAreaMargins(insets);

{!_.isNull(footer) && <FixedFooter style={[!isOffline ? safeAreaMarginBottom : {}]}>{footer}</FixedFooter>}

What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
Bottom of the Preference page is not transparent
What is the root cause of that problem?
One condition is missing and it should be the first to check in order safeAreaPaddingBottomStyle to work and bottom of the preference page to be transparent ie. we did not have the footer component
https://github.com/Expensify/App/blob/2427a06ed24f0649e55c14dbf4ae1a2a9ebe2109/src/components/IllustratedHeaderPageLayout.js#L62
What changes do you think we should make in order to solve the problem?
First thing first we need check if we have footer:
!_.isNull(footer) && !isOffline ? safeAreaPaddingBottomStyle : {}
What alternative solutions did you explore? (Optional)
NA
###Result:

Hi @hungvu193 @PiyushChandra17! Thank you both for your proposals. After careful consideration, it's evident that both of you have accurately identified the root cause of the issue, and your proposed solutions are quite similar. Due to the timing, I'm inclined to go with @hungvu193's proposal as it was the first one. Regarding the solution, I'm leaning towards the first option as it seems more descriptive, but I'm open to further discussion on this.
🎀 👀 🎀 C+ reviewed

Does anyone know why github won't let me assign @hungvu193? He just will not appear in the dropdown for assignees.

Bumped @hungvu193 in Slack too :)

@robertKozik Sure, we need to check footer first and it's different from what @hungvu193 proposed, it's the vital check first going forward with this one.
Also @laurenreidexpensify if he is unavailable, i can take this going forward :)

Payment Summary:

External issue reporter @hungvu193 $50 payment issued in Upwork
Contributor that fixed the issue @hungvu193  @500 payment issued in Upwork
Contributor+ that helped on the issue and/or PR @robertKozik agency worker, no payment issued

@robertKozik please advise on regression steps in checklist above, thanks

[X]  [@robertKozik] The PR that introduced the bug has been identified. Link to the PR: Cannot trace any particular PR which introduced this behaviour
[X]  [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[X]  [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[X]  [@robertKozik] Determine if we should create a regression test for this bug. I don't think the regression test is needed here. It's visual bug which don't interfere with any user flow
[X]  [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

tldr; I don't think the regression test is needed here. It's visual bug which don't interfere with any user flow


Question about preprocessing Scannet

Dear author,
I have a question about preprocessing scannet data in preprocee/scannet_to_objsdfpp.py:
Based on my understanding, it tries to normalize a scene to unit cude with center at origin, and the scale_mat is the transformation of the unit cube to the original scene. But why scale_mat[:3, 3] = -center. I think it should be scale_mat[:3, 3] =+ center. Please help me clarify this. Thanks!

Hi,
I think you can understand it in this way:
before line 152, the scale_mat would be a matrix with
[s1,   0 ,  0, -s1*t1,
   0, s2,   0, -s2*t2,
   0,   0, s3, -s3*t3,
   0,   0,   0, 1]

Its inverse matrix is (the real scale_mat used in calculation).
[1/s1,   0 ,  0, t1,
   0, 1/s2,   0, t2,
   0,   0, 1/s3, t3,
   0,   0,   0, 1]

The physical meaning of this scale_mat can be understand as a conversion from a 3D point in [-1,1]^3 to the world coordinates centered at [t1,t2,t3]. Therefore, it can be used to normalize everything into a unit cube if you play with the scale parameters and center.


5.0.4 introduces stepfunctions related files in very deep path which don't install on standard Windows configuration

Hello, the recent 5.0.4 version of moto introduces some stepfunctions related files (parser state management) which fail to install on Windows because they live in a very deep file hierarchy, and on my machine the install files with FileNotFound because of the MAX_PATH_LENGHT on Windows.
I know that length can be increased, but requires a registry edit which can't be performed on corporate environment without admin rights.
Any chance that might be flattened a bit?

• Updating moto (5.0.3 -> 5.0.4): Failed

  FileNotFoundError

  [Errno 2] No such file or directory: 'C:\\Users\\rdibattista\\AppData\\Local\\pypoetry\\Cache\\virtualenvs\\app-tGjm5KPq-py3.11\\Lib\\site-packages\\moto\\stepfunctions\\parser\\asl\\component\\state\\state_execution\\state_map\\item_reader\\resource_eval\\resource_output_transformer\\resource_output_transformer_csv.

@bblommers

Hi @rdbisme, sure - sorry about that.
It looks like, given the path that you've provided, there are only three files with a length > 256, and the max is 265 chars long - so it doesn't need much trimming to make it work. And there are definitely some paths/files that can be shortened without an impact on readability, so that shouldn't be a problem.

@bblommers Ehi, no need to be sorry about anything :). Thanks for the quick response.

Hi @rdbisme, the source tree is now flattened quite a bit with moto >= 5.0.5.dev13.
Are you able to upgrade and verify this now works for you?

Thanks @bblommers! Indeed it works. Thanks for the prompt response :)


Fix a few settings UI bugs

[x] 4775efa0 Add padding to the bottom of Settings
[x] ce0379f9 Fixes the block/mute button being cut off

          1 Warning

:warning:
Please provide a linked tracker story for this PR in the description

  Generated by :no_entry_sign: danger


Updated a release variable in the pipeline with API call. The updated value is not available in the subsequent tasks/jobs/stages of release.

Question
Enter Task Name: PowerShell Task

Agent - Private:
Private : Windows - VS2017/VS2019

Issue Description

I updated a release variable in the pipeline with API call. But unable to access the updated value in subsequent tasks/jobs/stages of the release.

How can I access the updated pipeline variables in the same release?

To start with I have 3 pipeline variables

I allowed the agent to access oAuth token
I set the pipeline variables to be settable during release
I updated to allow editing release in security

Here is an inline script I'm using in a PowerShell Task to update the release variables with API call.
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
write-host "*****************Authenticate to Azure Devops with API and get Release Definition *****************"
$url = "https://vsrm.dev.azure.com/{Org}/{Project}/_apis/Release/definitions/$($env:RELEASE_DEFINITIONID)?api-version=5.0"
Write-Host "URL: $url"

$ba = (":{0}" -f $env:SYSTEM_ACCESSTOKEN)
$ba = [System.Text.Encoding]::UTF8.GetBytes($ba)
$ba = [System.Convert]::ToBase64String($ba)
$header = @{Authorization=("Basic{0}" -f $ba);ContentType="application/json"}

$pipeline = Invoke-RestMethod -Uri $url -Headers $header
write-host "***********************Pipeline Variable before update***************************"
$pipeline.variables

#**************************Update Pipeline Variables ******************************
$pipeline.variables.'pipeline.variable.1'.value = "Variable1-Updated"
$pipeline.variables.'pipeline.variable.2'.value = "Variable2-Updated"
$pipeline.variables.'pipeline.variable.3'.value = "Variable3-Updated"

#************************** update the modified object ***************************
$json = @($pipeline) | ConvertTo-Json -Depth 99
$updatedef = Invoke-RestMethod -Uri $url -Method Put -Body $json -ContentType "application/json" -Headers $header

write-host "**************************updated pipeline variables************************************"
$updatedef.variables

write-host "***********************print pipeline variables - same task******************************"
write-host "$(pipeline.variable.1)"
write-host "$(pipeline.variable.2)"
write-host "$(pipeline.variable.3)"

During the execution of PowerShell script I can see that the variables are getting updated in the release pipeline.
I printed the variables before and after update.

At the end of the script, I Printed pipeline variables in same task. It still prints old variable values.

I tried to get the pipeline variables in a different task in the same job, and in a new job. It still prints old variables values.

I then tried to get the pipeline variables in a new stage. It still prints the old variable values.

But after the pipeline execution is complete, I see that the pipeline variables are updated to the new values when I reopen it.

One thing I noticed was that even after updating the release definition with API, the 'Initialize Job' task in the subsequent tasks/jobs/stages in the release still shows old values of the variables. May be that's why I'm unable to access the updated value of the pipeline variable??

Please let me know how to resolve this and access the updated release variable in the same release.

Figured it out!
I was updating the release definition with the below endpoint. This was updating the release definition, and the updated variables could only be accessed in subsequent releases.
https://vsrm.dev.azure.com/{Org}/{Project}/_apis/Release/definitions/{definitionId?api-version=5.0
What I needed was the below endpoint, where I could update the current release and use the updated variables with in the same release.
https://vsrm.dev.azure.com/{organization}/{project}/_apis/release/releases/{releaseId}?api-version=5.1
Closing the issue.


A little correction I guess

The note in CreateMove hook is wrong, sort of.
Because we are hooking the CreateMove from ClientModeShared, and it will get called from here. As the code stated in engine, if we return false at here, then the SetViewAngles function will not get called by the game engine itself, which leads to the "silent aimbot". To fix that problem I think you should return the original CreateMove.

im called this manually to fix it here:
https://github.com/rollraw/qo0-base/blob/a439eff1699b64db38e2792705ae19e35a5b1732/base/core/hooks.cpp#L232-L238
then it doesn't makes sense what we returning at end.
also i've already tested most of things with base, aimbot & silent including, and all works fine.
kind regards

only one thing still isn't fixed in createmove, it is mousedelta, but there is already enought public info about it

Ahhhh I didn't notice the "manually fix" note, my bad!


[PlayerDialogAdditions] "Do you know this person" option is broken

I get this error when selecting "Do you know this person?" option. Clicking on the portraits does nothing. This is on experimental build 37.09, mods and BepInEx installed through Thunderstore.
Exception: System.NullReferenceException: Object reference not set to an instance of an object.
   at DialogAdditions.PhotoSelectButtonController_OnLeftClick.DoYouKnowThisPersonAdditions(Human speaker, Human askTarget, List`1 askTargetKeys) in D:\Game Modding\ShadowsOfDoubt\_Mods\ShadowsOfDoubtMods\DialogAdditions\PhotoSelectOverrides.cs:line 257
   at DialogAdditions.PhotoSelectButtonController_OnLeftClick.Prefix(PhotoSelectButtonController __instance) in D:\Game Modding\ShadowsOfDoubt\_Mods\ShadowsOfDoubtMods\DialogAdditions\PhotoSelectOverrides.cs:line 34
   at DMD<PhotoSelectButtonController::OnLeftClick>(PhotoSelectButtonController this)
   at (il2cpp -> managed) OnLeftClick(IntPtr , Il2CppMethodInfo* )

Have you got procedural murders turned off?

Have you got procedural murders turned off?

Yes.

Fixed in v0.11.4


Kanban Board: Recipe app

Highlights
The following people are assigned to each task.
@Mutai-Gilbert
@atok624
Github Project Link
Note: We are two in a team.

Hi @Mutai-Gilbert @atok624 👋,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights

All team members info provided 👍
Link to Kanban board works 👍
Cards shared evenly 👍

Required Changes ♻

Kindly add the missing column (in review ) as its required

Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @davidsoky007 in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Done.

Hi 👋 @Mutai-Gilbert, and @atok624,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights
👍 You did well to add the column which was missing as required by the previous reviewer.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Fix dead link to host bindings proposal overview

The latest commit seems to have invalidated the link. It also seems like the repository was renamed? At least I get re-rerouted to the webidl-bindings repo when clicking on the link from the blog post.
Please tell me if there are any guidelines that I have missed or feel free to correct the link, if this is the wrong document.

Thanks!


Rename MACOSX_NOTES.md as a README_

Have been meaning to rename this for awhile.
I always forget this file exists, because i'm looking in the directory for a README.
Today is not the first time i've fumbled around for an hour reading and trying various readmes that don't quite work, wondering where I read the updated macosx stuff.

coverage: 93.495%. remained the same
when pulling 4cca0cd2f3bdb34c572b03989d40350cfccaafce on rename-macosx-notes
into 936729371b650fc23260843aa98eaa6d80827c1c on main.


Fix issue with LOD selection when Camera is inside Meshes AABB

Fixed an issue where the LOD was selected only based of the Meshes AABB support points although the Camera being inside the AABB.

@0010200303 Hey there! Did you intend to close this PR?

@YuriSizov Heyy thanks for checking. Yeah i intented to close this because it had a bad clang format and i didn't how to fix it so i just created a new one.

I see, https://github.com/godotengine/godot/pull/79590 supersedes this.
In future, you can just push to the same branch, including force-pushing and rewriting entire history, to update your PR. I also recommend not using your master branch and creating a feature branch from it, so resolving these issues is easier in the future.


upgrade to support dbt-core v1.8.0

Background
Minor version v1.8 is targeted for final release within dbt Core on May 9, 2024.
As a maintainer of a dbt adapter, we strongly encourage you to release a corresponding minor version increment to ensure users of your adapter can make use of this new minor version.
As of dbt-core v1.8.0, we no longer need to encourage you to release a new minor version anytime we do. After following the linked upgrade guide, we guarantee your adapter will be forward compatible with all future minor versions of dbt-core (at least until v2.0 which is not yet planned).
Another major win: you can now make your adapter truly SemVer compliant, as you can release new versions of your adapter without needing to wait for a new dbt-core release. You can actually follow
How to upgrade
https://github.com/dbt-labs/dbt-core/discussions/9798 is an open discussion with more detailed information. If you have questions, please put them there!

@Jrmyy I know that the ground work is done, but let's leave it open till we officially support a stable release of dbt-core=~1.8.0

also chiming in to say that we should keep this open until at dbt-core 1.8.0 is out. Which is still at least a few weeks away :)

Yes sorry closed automatically by my PR ... 😬

dbt-core v1.8.0 has been released! Any blockers on merging the release candidate?

@jeancochrane we will make the final release next Monday :)

Closing this as it's implemented, @jeancochrane https://github.com/dbt-athena/dbt-athena/releases/tag/v1.8.1 see release notes.


Dont truncate sidenav titles

📚 Context
This PR fixes an issue reported by @MathCatsAnd, where right navigation titles would truncate, something we don't want them to do.
🧠 Description of Changes

Removed the truncate Tailwind directive from floatingNav.module.css;
Added a bit of padding right to ensure content does not overflow.

Revised:

Current:

💥 Impact

Size:

[x] Small
[ ] Not small

🌐 References

https://www.notion.so/snowflake-corp/Don-t-truncate-titles-on-right-navigation-aa67c75b61ba4205a39d13b2ae3f9c89?pvs=4

Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Thanks @sfc-gh-jgarcia!


setup issue

Describe the bug
Currently, you are trying to source the current SHELL rc in the update_requirements.sh script.
Example:
RC_FILE="${HOME}/.$(basename ${SHELL})rc"
source $RC_FILE

a.k.a.
source ~/.bashrc

However, it is not possible to do this sort of action: see explanation.
The current setup could potentially work for an working version of an openpilot dev environment. However, for greenfield users, running the setup for the first time, this results in an error:
WARNING: seems you still have not added 'pyenv' to the load path.

# Load pyenv automatically by appending
# the following to
~/.bash_profile if it exists, otherwise ~/.profile (for login shells)
and ~/.bashrc (for interactive shells) :

export PYENV_ROOT="$HOME/.pyenv"
command -v pyenv >/dev/null || export PATH="$PYENV_ROOT/bin:$PATH"
eval "$(pyenv init -)"

# Restart your shell for the changes to take effect.

# Load pyenv-virtualenv automatically by adding
# the following to ~/.bashrc:

eval "$(pyenv virtualenv-init -)"

pyenv update ...
/home/jeroen/openpilot/update_requirements.sh: line 35: pyenv: command not found

OS Version
Ubuntu 20.04
openpilot version or commit
No response
Additional info
No response

Also..
If you execute the ubuntu_setup.sh for a second time, this error will not occur. You might think the issue is now fixed, however...
jeroen@phoenix:~/openpilot$ poetry shell
Spawning shell within /home/jeroen/.cache/pypoetry/virtualenvs/openpilot-eYl9iItR-py3.8
jeroen@phoenix:~/openpilot$ . /home/jeroen/.cache/pypoetry/virtualenvs/openpilot-eYl9iItR-py3.8/bin/activate
(openpilot-py3.8) jeroen@phoenix:~/openpilot$ scons -u -j$(nproc) # executing scons as advertised..
scons: Reading SConscript files ...

scons: warning: Calling missing SConscript without error is deprecated. # whoops! Error...
Transition by adding must_exist=False to SConscript calls.
Missing SConscript 'cereal/SConscript'
File "/home/jeroen/openpilot/SConstruct", line 357, in <module>

scons: warning: Ignoring missing SConscript 'rednose/SConscript'
File "/home/jeroen/openpilot/SConstruct", line 394, in <module>

scons: warning: Ignoring missing SConscript 'cereal/SConscript'
File "/home/jeroen/openpilot/SConstruct", line 408, in <module>

scons: warning: Ignoring missing SConscript 'body/board/SConscript'
File "/home/jeroen/openpilot/SConstruct", line 408, in <module>

scons: warning: Ignoring missing SConscript 'panda/board/SConscript'
File "/home/jeroen/openpilot/SConstruct", line 408, in <module>

scons: warning: Ignoring missing SConscript 'opendbc/can/SConscript'
File "/home/jeroen/openpilot/SConstruct", line 408, in <module>

scons: *** Import of non-existent variable ''libkf''
File "/home/jeroen/openpilot/selfdrive/locationd/SConscript", line 1, in <module>
(openpilot-py3.8) jeroen@phoenix:~/openpilot$


Post array params

I have problem when I try to post an array parameters.
Example, my data when I created at HTML form like this:
<form method="POST">
<input name="field[]" value="field1" />
<input name="field[]" value="field2"/>
<input name="other" value="other_field"/>
<button>Submit<button>
</form>

So my correct data is: field[]=field1&field[]=field2&other=other_field
But in Guzzle (using http_build_query function), the data will be:
`field[0]=field1&field[1]=field2&other=other_field
I read PHP Function manual, a contributor suggested fix this problem by follow code:
$query = http_build_query($query);
$query = preg_replace('/%5B[0-9]+%5D/simU', '%5B%5D', $query);

For now you need to build this array yourself manually. It's possible some kind of helper functionality will be added back into Guzzle, but nothing has been decided.
Closing a duplicate of https://github.com/guzzle/guzzle/issues/1196


[5pt] Add bankfull detection to the src_full_crosswalk.csv

Create new post-processing method to estimate bankfull stage in each SRC by using the NWM retrospective 1.5yr flows.
Input: src_full_crosswalked.csv & recurr_1_5_cms.csv
Output: src_full_crosswalked_bankfull.csv

Example plot output:

Another example:


Speed up CI runs by only cargo checking for docs

Running cargo check --features testing_only_docs will catch missing doc
comments, and we can avoid doing a full build.
r? @emilio

@bors-servo r+

:pushpin: Commit d792af6 has been approved by emilio

:hourglass: Testing commit d792af6702580776e8c26a500d69aacb79a8500e with merge 87bd3b9d7d9ea503c3b45a2947d5485eeb836737...

:sunny: Test successful - status-travis
Approved by: emilio
Pushing 87bd3b9d7d9ea503c3b45a2947d5485eeb836737 to master...


ARROW-16361: [Dev][Archery] Add link to static page for nightly build report notifications

@kszucs  what do you think about adding to both the chat (Zulip) and email notifications a link to the new page with info about the Nightlies?
https://crossbow.voltrondata.com/

Sounds great!


Search with "files to include" asks to "narrow down results"

Issue Type: Bug
Steps to reproduce:

Work on a project with lots of files, like the linux kernel
Use find in files and fille in an include path like "/path-to-project/**/bcm203"
Search for a common keyword like "string"
You will get an error such as "The result set only contains a subset of all matches. Please be more specific in your search to narrow down the results."

When you explicity narrow the search results like this, the search would ideally only search those files. Instead it seems like the search is searching all the files and then filtering the results based on the "files to include" field. It's very annoying when you are in a huge project and cannot use the search box for common terms.
VS Code version: Code 1.40.2 (f359dd69833dd8800b54d458f6d37ab7c78df520, 2019-11-25T14:54:40.719Z)
OS version: Linux x64 4.15.0-72-generic

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E5-1650 v2 @ 3.50GHz (12 x 3491)

GPU Status
2d_canvas: unavailable_softwareflash_3d: disabled_softwareflash_stage3d: disabled_softwareflash_stage3d_baseline: disabled_softwaregpu_compositing: disabled_softwaremetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: disabled_offrasterization: disabled_softwareskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: disabled_softwareviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
2, 2, 3

Memory (System)
31.36GB (6.94GB free)

Process Argv
--no-sandbox --unity-launch

Screen Reader
no

VM
0%

It seems like a temporary work around is to add "./" to files to exclude. This seems to have the desired behavior, but is not intuitive.

You will get that message whenever the search returns 10,000+ results. You should see the first 10,000 results and that message. If this doesn't explain what you are seeing, please include more details.

That does not explain what I am seeing. I did not say that I was seeing 10,000+ results. I am trying to include only a handful of files, using wildcards and the include field. I should see results for only 1 file using my example above, but instead I get the error.
Again, as I explained above, it seems to me that the search is performed first on ALL OF THE FILES and then the filter is applied. Wheres, I think it would be much better and faster if it first applied the filter and then searched only those files. And again, as I explained above, if you use the exclude filter on all files, it seems to be a workaround. But only after this frustrated me for several hours.

I have also installed the insiders edition, and the workaround does not work in that version. It seems to me, than in that version the exclude filter is applied after the include filter. I do not get the "The result set only contains a subset ..." error unless I remove the exclude filter.

The workaround only works when you have file opened. So there is no practical workaround for this issue currently.

So you are seeing results in files that don't match the glob pattern? Does it work if you use a glob pattern that isn't an absolute path like your example above? Assuming that you have the relevant folder open.

I am seeing, 0 results returned. I assume this is because the file isn't in the first 10,000 results and therefore, the order of operations matters. Search then filter returns 0 results. Unless I have the file open in my editor, then it seems to get bumped up in the search priority and gets searched before the 10,000 limit is hit.
I have tried both absolute paths and relative paths, with the same result. I have the folder open in my workspace. I have also loaded the insiders version and get the same results.

If I limit the glob pattern further like ./linux/drivers/bluetooth/**/bcm203*, then it works. So it seems like the include filter is partially applied before the search is performed, but as soon as a wildcard is encountered, it stops and applies the rest of the filter post search.

I assume this is because the file isn't in the first 10,000 results and therefore, the order of operations matters.

That isn't how it works, only results that match the query will be considered.
I cloned the linux sources, can you tell me which files you expect to match? Should I be on a certain branch?

If your workspace is at the linux source directory, then the include needs to be ./drivers/bluetooth/**/bcm203*
BUT, doing this myself, it seems to work fine. My specific example is that I have a yocto build open in my workspace. So my file count is actually closer to 8 million. I loaded a new vscode instance, limited to just the linux source folder and it seems to be ok. So I'm not sure at what point it breaks. But in my specific example the globs are:
Search term: "static"
./build/workspace/sources/linux//bcm203* -> Returns 0 results
./build/workspace/sources/linux/drivers//bcm203* -> Returns 0 results
./build/workspace/sources/linux/drivers/bluetooth/**/bcm203* -> Returns 1 result
But like I said, this might be a bit more of a corner case than I thought. If I point my workspace to ../build/workspace instead, then things seem to be ok.

I am not sure how to produce that build so I can't run the same scenario. Can you give an example of a path that should be matched, but isn't?


chore: bump busybox for CVE fix

What type of PR is this?

What this PR does / why we need it:
CVE fix
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.069%

Totals

Change from base Build<PHONE_NUMBER>2:
0.0%

Covered Lines:
2572

Relevant Lines:
3619

💛  - Coveralls

1.36 is missing from this repo in MCR


refactor: use jinja2 instead of cookiecutter

Closes #739

:tada: This PR is included in version 5.30.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix: system webhooks API bug

Fix the bug about admin/hooks API that GET /admin/hooks can only fetch system_hooks, POST /admin/hooks can only create default_hooks.

CI fail is related.

Dismiss my change request, but I sill have the question about whether it (is_system_webhook) needs to be documented somewhere.

@wxiaoguang is this PR ready to be merged or not?

@wxiaoguang is this PR ready to be merged or not?

Just nit, no block from my side.


rename tool to reflect purpose

let's discuss further, but maybe:
audit-tool
simple-audit-tool
simple-file-system-auditor

So I like describing a tool as simple (until it isn't simple), but would suggest not putting it in the name. Is "audit-tool" OK?

absolutely, audit-tool


Python2 testbugs

Coverage increased (+0.9%) to 97.426% when pulling 3696e38f648b64db9f0c569b2df6732f978a4c4b on arcondello:python2_testbugs into bb41b32e332d01867c405a565401d3ab5af7dae0 on dwavesystems:1.0.0.


snet: Reconnector constantly tries to reconnect

When the dispatcher dies, the reconnector of the infra services constantly tries to reconnect.

My guess is that https://github.com/scionproto/scion/blob/117b424a62f37525b3b9cbacecf4d512d87d3602/go/lib/sock/reliable/errors.go#L76 does not cover the error that is seen

False alarm, this was caused by #2753. WAI


⚠ MBKM has degraded performance

In 3f3051f, MBKM (https://mbkm.unmer.ac.id/) experienced degraded performance:

HTTP code: 200
Response time: 21600 ms

Resolved: MBKM performance has improved in fac51cd after 12 minutes.


WIP fix(docs): correct element template bindings for outputParameter

Which issue does this PR address?
Came up during https://github.com/camunda/camunda-modeler/issues/1933 but doesn't solve it.
An camunda:outputParameter element-template binding requires to have source set. The documentation should reflect this.
Acceptance Criteria

[ ] Corresponds to the concept
[ ] Corresponds to the design

Definition of Done

[ ] corresponds to the design principles
[ ] corresponds to the code standards
[ ] passes Continuous Integration checks
[ ] available as feature branch on GitHub

[ ] contains the cleaned up commit history
[ ] commit messages satisfy our commit message guidelines
[ ] a single commit closes the issue via Closes #issuenr

Will handle this using https://github.com/camunda/camunda-modeler/issues/1936


NIFI-13525 Remove unused classes from nifi-security-crypto-key

Summary
NIFI-13525 Removes unused classes from nifi-security-crypto-key supporting key derivation functions with bcrypt and scrypt that are no longer necessary following the removal of DecryptContent and DecryptContentCompatibility Processors.
The remaining Argon2 and PBKDF2 key derivation classes support sensitive property encryption.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[X] Build completed using mvn clean install -P contrib-check

[X] JDK 21

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

ahh very nice.  Will take care of merge.  I need to up my finding dead code game


Make transform stateless

This follows up on @tivac's suggestion in https://github.com/rollup/rollup/pull/658 – rather than tracking which CommonJS features are used and injecting them haphazardly using the intro hook, modules import commonjsHelpers. This is cleaner, and will allow the results of the transformation to be cached.
There is a wrinkle however: the synthetic ID used for the helpers goes through the same resolution process as any other ID. Since in this case that frequently means rollup-plugin-node-resolve, we end up passing trying to resolve whatever ID we use with the Node resolution algorithm, which will obviously fail.
So I'm proposing we adopt the following convention: plugins that generate synthetic helper modules, like this one, should use the null character (\0) in the ID. Plugins that implement resolveId should ignore IDs with the null character. (The reason I'm suggesting NUL is that it's invalid in filenames on both *nix and Windows.)
I've already taken the liberty of updating createFilter and node-resolve.
Any thoughts @rollup/collaborators?
Apologies for the bad git discipline, I managed to roll some extra stuff in here 😕

Neat! Prepending a module name with NUL is a decent hack. I'll update TypeScript accordingly.


Is there a way to pull Change and % Change info for tickers?

I am using the following code to pull market data in python:
msg = yf.Ticker("QQQ")
msg2 = msg.info['regularMarketPrice']
However I did not notice any change or %change in the JSON file, so I can't really read it. Any idea where it is?

Bad idea to get price data from info[], use history() or download() instead.


performance adjustments

access room daos on io context
refactored dao rxjava code to flows
ksp <--> kapt
will update soon....

Some of this needs to be reworked after : https://github.com/code-payments/code-android-app/pull/7


Noisy log message: "Settings Sync: Updating due to change in sessions"

This seems like too much for an 'info' level log message, my logs end up full of this
2024-01-03 11:12:22.837 [info] Settings Sync: Updating due to change in sessions
2024-01-03 11:17:54.349 [info] Settings Sync: Updating due to change in sessions
2024-01-03 11:31:35.510 [info] Settings Sync: Updating due to change in sessions
2024-01-03 12:00:57.421 [info] Settings Sync: Updating due to change in sessions
2024-01-03 12:04:34.218 [info] Settings Sync: Updating due to change in sessions
2024-01-03 12:13:40.339 [info] Settings Sync: Updating due to change in sessions
2024-01-03 12:48:34.543 [info] Settings Sync: Updating due to change in sessions
2024-01-03 12:54:57.770 [info] Settings Sync: Updating due to change in sessions
2024-01-03 13:10:02.100 [info] Settings Sync: Updating due to change in sessions
2024-01-03 13:31:54.328 [info] Settings Sync: Updating due to change in sessions
2024-01-03 13:52:38.277 [info] Settings Sync: Updating due to change in sessions
2024-01-03 13:55:00.085 [info] Settings Sync: Updating due to change in sessions
2024-01-03 14:26:53.533 [info] Settings Sync: Updating due to change in sessions
2024-01-03 14:43:46.508 [info] Settings Sync: Updating due to change in sessions
2024-01-03 14:52:33.364 [info] Settings Sync: Updating due to change in sessions
2024-01-03 15:38:10.241 [info] Settings Sync: Updating due to change in sessions
2024-01-03 15:38:10.352 [info] Settings Sync: Updating due to change in sessions
2024-01-03 15:38:10.388 [info] Settings Sync: Updating due to change in sessions
2024-01-03 16:24:09.070 [info] Settings Sync: Updating due to change in sessions
2024-01-03 16:28:52.270 [info] Settings Sync: Updating due to change in sessions
2024-01-03 16:36:34.215 [info] Settings Sync: Updating due to change in sessions
2024-01-03 17:23:52.242 [info] Settings Sync: Updating due to change in sessions
2024-01-03 17:50:21.547 [info] Settings Sync: Updating due to change in sessions
2024-01-03 18:27:17.588 [info] Settings Sync: Updating due to change in sessions

I am not seeing this entry. This is shown only when authentication session changes. Hence it is logged as info.

I definitely wasn't signing in and out. I'll see if it keeps showing up though

It got printed all night while my macbook was asleep and doing stuff in the background. Maybe not high priority still but in case it tells you anything:
2024-01-08 00:17:33.997 [info] Settings Sync: Updating due to change in sessions
2024-01-08 00:20:42.194 [info] Settings Sync: Updating due to change in sessions
2024-01-08 00:26:36.746 [info] Settings Sync: Updating due to change in sessions
2024-01-08 01:22:11.914 [info] Settings Sync: Updating due to change in sessions
2024-01-08 01:22:11.941 [info] Settings Sync: Updating due to change in sessions
2024-01-08 01:33:31.231 [info] Settings Sync: Updating due to change in sessions
2024-01-08 02:18:14.630 [info] Settings Sync: Updating due to change in sessions
2024-01-08 02:18:14.833 [info] Settings Sync: Updating due to change in sessions
2024-01-08 02:24:15.529 [info] Settings Sync: Updating due to change in sessions
2024-01-08 03:16:01.664 [info] Settings Sync: Updating due to change in sessions
2024-01-08 03:16:01.762 [info] Settings Sync: Updating due to change in sessions
2024-01-08 03:16:02.750 [info] Settings Sync: Updating due to change in sessions
2024-01-08 04:29:05.234 [info] Settings Sync: Updating due to change in sessions
2024-01-08 04:29:05.469 [info] Settings Sync: Updating due to change in sessions
2024-01-08 04:29:05.599 [info] Settings Sync: Updating due to change in sessions
2024-01-08 05:11:07.189 [info] Settings Sync: Updating due to change in sessions
2024-01-08 05:30:56.648 [info] Settings Sync: Updating due to change in sessions
2024-01-08 05:30:56.758 [info] Settings Sync: Updating due to change in sessions
2024-01-08 06:01:02.099 [info] Settings Sync: Updating due to change in sessions
2024-01-08 06:22:19.647 [info] Settings Sync: Updating due to change in sessions
2024-01-08 06:22:19.684 [info] Settings Sync: Updating due to change in sessions
2024-01-08 07:00:10.091 [info] Settings Sync: Updating due to change in sessions
2024-01-08 07:34:56.994 [info] Settings Sync: Updating due to change in sessions
2024-01-08 07:34:57.029 [info] Settings Sync: Updating due to change in sessions
2024-01-08 07:54:14.894 [info] Settings Sync: Updating due to change in sessions
2024-01-08 08:20:00.828 [info] Settings Sync: Updating due to change in sessions
2024-01-08 08:35:47.542 [info] Settings Sync: Updating due to change in sessions
2024-01-08 08:36:59.612 [info] Settings Sync: Updating due to change in sessions
2024-01-08 09:05:04.319 [info] Settings Sync: Updating due to change in sessions
2024-01-08 09:31:14.444 [info] Settings Sync: Updating due to change in sessions
2024-01-08 09:31:14.467 [info] Settings Sync: Updating due to change in sessions
2024-01-08 10:09:46.731 [info] Settings Sync: Updating due to change in sessions
2024-01-08 10:21:59.374 [info] Settings Sync: Updating due to change in sessions

Do you see any activity in Microsoft or Github accounts output? This might be causing this.


Error following symlink

I'm getting an error during the npm-install task on jenkins.
It does not happen on my laptop.
Is it related to the creation of symlinks by kotlin-frontend-plugin or does it have to do with the sshpk package?
> Task :project-name:npm-install
 This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/****/.npm/_logs/2018-09-11T13_02_07_770Z-debug.log

> Task :project-name:npm-install FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Failed to capture snapshot of output files for task ':project-name:npm-install' property 'nodeModulesDir' during up-to-date check.
> Could not list contents of '/home/****/workspace/branch-name-FACF4TVG7P6H2BWZ6GEOOHEHVOLEGAOYJLNDTNB4TPXH5I4QBIZA/project-name/build/node_modules/.bin/sshpk-conv'. Couldn't follow symbolic link.

It looks a little bit like this:
https://github.com/srs/gradle-node-plugin/issues/202

There is a PR for that ... as quick fix you can fork this plugin and apply the changes: https://github.com/Kotlin/kotlin-frontend-plugin/pull/97


Pandas library

Skill Name
Pandas
Why?
Popular data science library
Reference Image

hi @Satwik-uppada if you want to use the pandas icon, you can find it on the newest version of the repository (here), because the maintainer did not show up in months

@LelouchFR I believe I've mentioned this to you before, but please do not link to your project on this repo at all from now on, and definitely not on every single issue here that is created. It creates a lot of spam and is arguably self-promotion. Your repo is not "the newest version of the project", it's a fork that is maintained. While I see where you're coming from and can understand from a positive side why you are doing this, you're breaking GitHub's Community Guidelines in the ways in which you are doing it. Comments on issues/PRs should be productive and relevant to this repo only.
Because of these reasons, I'm issuing a block of your account from this repo. I'm really glad you've helped keep it maintained, but I do not appreciate your borderline unfeeling/unkind comments and assumptions towards me without knowing anything about my personal situation. Best of luck from here on!

Sorry for the inconvenience from my side, i just used it for my profile
readme. That's it
On Fri, Jul 12, 2024 at 11:08 AM Thijs @.***> wrote:

@LelouchFR https://github.com/LelouchFR I believe I've mentioned this
to you before, but please do not link to your project on this repo at all
from now on, and definitely not on every single issue here that is created.
It creates a lot of spam and is arguably self-promotion. Your repo is not
"the newest version of the project", it's a fork that is maintained. While
I see where you're coming from and can understand from a positive side why
you are doing this, you're breaking GitHub's Community Guidelines in the
ways in which you are doing it. Comments on issues/PRs should be productive
and relevant to this repo only.
Because of these reasons, I'm issuing a block of your account from this
repo. I'm really glad you've helped keep it maintained, but I do not
appreciate your borderline unfeeling/unkind comments and assumptions
towards me without knowing anything about my personal situation. Best of
luck from here on!
—
Reply to this email directly, view it on GitHub
https://github.com/tandpfun/skill-icons/issues/1029#issuecomment-2224742844,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV6SC5JW2QWX44KAIJIF44LZL5TW5AVCNFSM6AAAAABKWIRKG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRUG42DEOBUGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


protein-translation: Codon Protein Table is not rendered correctly on the HTML page

https://exercism.io/my/solutions/f55a4cdbc7d4451f85836299ffccd057
I see a markdown table embedded inside paragraph tags

Codon
Protein

AUG
Methionine

UUU, UUC
Phenylalanine

UUA, UUG
Leucine

UCU, UCC, UCA, UCG
Serine

UAU, UAC
Tyrosine

UGU, UGC
Cysteine

UGG
Tryptophan

UAA, UAG, UGA
STOP

Thank you for this great learning tool.
🐼

Thanks for reporting this @ehom.
This needs some more research to work out if it is a problem with the markdown in the readme or Exercism's markdown renderer, (or both).
Rendered version can be found here: https://exercism.io/tracks/ruby/exercises/protein-translation/solutions/b24e3d641e5e4b0095b65982f64ac1e8
(if you click on "instructions")
Readme source can be found here: https://github.com/exercism/ruby/blob/master/exercises/protein-translation/README.md
(Renders fine in github.)
If it's the renderer you will need to investigate the website code: https://github.com/exercism/website
Or raise an issue here: https://github.com/exercism/exercism/issues

Update. This is the current rendering on the Instructions page. Looks good to me. Can we close this?

Looks fixed.


Possible overaggressive, unwanted, dropping of features at low zoom levels?

I think tippecanoe is dropping way too many features at low zoom levels.
I create vectortiles for WaterwayMap.org, a QA site. It's very beneficial for it to show many features are low zoom levels, so people can spot mistakes from far away.
I have a ~45MiB GeoJSONSeq file, each entry a MultiLineString. (It's from OSM and the waterway's that have loops for  WaterwayMap.org/Loops).
On z4, there is on feature in Galicia (northwest Spain, north of Portugal).
. But on z3 there is nothing

(there are other examples of this happening)
The input data is planet-loops.geojsons (~40 MiB), and created with:
tippecanoe -zg --cluster-distance=2 --cluster-densest-as-needed --force --no-feature-limit --no-tile-size-limit --accumulate-attribute num_nodes:sum --accumulate-attribute length_m:sum -y root_nid -y num_nodes -y length_m -l loops -o planet-loops.pmtiles planet-loops.geojsons

This feature is not in the z3 tile (3/3/2). The following command gives nothing.
tippecanoe-decode planet-loops.pmtiles 3 3 2  | grep 297016103

But it's in the z4 tile (4/7/5):
$ tippecanoe-decode planet-loops.pmtiles 4 7 5  | grep 297016103
{ "type": "Feature", "properties": { "num_nodes": 30, "root_nid": 297016103 }, "geometry": { "type": "LineString", "coordinates": [ [ -7.624512, 43.048820 ], [ -7.624512, 43.044805 ] ] } }

The Protomaps PMTiles VIewer tells me tile 3/3/2 is only 83 kB in size. This is well below the 250 KiB tippecanoe default. I am using --no-tile-size-limit --no-feature-limit. the z4 tile is (4/7/5) is 69 kB.
I'm not sure what's going on with tippecanoe, but it seems like it's dropping this feature from z3 without good reason. Is this a bug in tippecanoe? or can I tell it to store lots of data at z3 (and other low zoom levels?) Or have I misunderstood something?
The actual tippecanoe command used for WWM.org is: on that github. I have noticed similar “over-agressive dropping?” for the WaterwayMap.org/Ends map.

I'm investing this dataset with other MVT generation tools (tilekiln from pnorman), and I see the same “dropping” of features. Further investigation shows the features are very small, and PostGIS's ST_AsMVT() function turns the small linestrings to NULL.
I suspect tippecanoe is doing the same thing here. It's probably “not wrong” to do this. However I think one should probably simplify it to a point, rather than drop it.


generation error for paging operation

Python SDK generation fails in https://github.com/Azure/azure-rest-api-specs/pull/25292.
Log:
Azure_25292_azure-sdk-for-python_logs.txt

There is only @items and no @nextLinkName in @pagedResult so python emitter fails. Actually swagger has similar case, so python emitter shall be able to compatible with it.


What License is this under?

Please clarify your licensing.

MIT

Thanks.  How about mentioning that in the README or adding a LICENSE file, as is the convention?


Assign IDs to available names and store them in hidden input

Hi,
is there a way to assign IDs to data : names? So that we could collect all mentions in hidden input. Because if we have multiple "RokSiEu" names I can't grab the right user from database so that I could notify him.
I would like to have something like this
id:1, name: "RokSiEu"

$('.note-editable').on("inserted.atwho", function($li, query) {
   console.log($li); //here I would like to fill hidden input with IDs that were mentioned

This can get the data of the item:
$li.data('item-data')

Are you sure? My $li.data is undefined (error in code bellow)
   $(function(){
    var jeremy = decodeURI("J%C3%A9r%C3%A9my") // Jérémy
    var names = ["Jacob","Isabella","Ethan","Emma","Michael","Olivia","Alexander","Sophia","William","Ava","Joshua","Emily","Daniel","Madison","Jayden","Abigail","Noah","Chloe","你好","你你你", jeremy];

    var names = $.map(names,function(value,i) {
      return {'id':i,'name':value};
    });

    var at_config = {
      at: "@",
      data: names,
      displayTpl: "<li>${name}</li>",
      limit: 200
    }

    $('.note-editable').atwho(at_config);
    $('.note-editable').on("inserted.atwho", function($li, query) {
        console.log($li.data('item-data')); //ERROR: $li.data is not a function
    });
  });

oh. I'm sorry. the first argument is a jQuery Event object, the second one is the $li .
I'm going to update the wiki.

hnnn. the wiki is correct.


RPC connection closed by Zebra during lightwalletd tests

Motivation
The sending_transactions_using_lightwalletd test occasionally fails with a "connection closed" or "connection refused" error:

{"app":"lightwalletd","error":"Post "[http://<IP_ADDRESS>:39183](http://<IP_ADDRESS>:39183/)": read tcp <IP_ADDRESS>:37352-\u003e<IP_ADDRESS>:39183: read: connection reset by peer","level":"fatal","msg":"error zcashd getbestblockhash rpc","time":"2023-06-08T01:52:28Z"}

https://github.com/ZcashFoundation/zebra/actions/runs/5205948564/jobs/9392912256?pr=6842#step:8:384
Zebra just seems to keep on running, without logging any errors.
We could try adding extra logs or extra waits when the zebrad or lightwalletd processes in these tests fail?
This might be tricky because we're seeing a test panic, rather than a test error.
We could also remove this error from the lightwalletd error list, and see if the test passes. (It probably won't, because lightwalletd says it's a fatal error. But it might give us more time to see Zebra's logs.)
Complex Code or Requirements
This is probably a zebrad RPC concurrency bug or a test harness concurrency bug.
Testing
This is going to be very tricky to reproduce and test.

Hey team! Please add your planning poker estimate with Zenhub @arya2 @dconnolly @oxarbitrage @teor2345 @upbqdn

@mpguerra we've only seen this happen once every few weeks, maybe it should be a low priority? (Feel free to switch it back.)

that's fine, we should use the opportunity that we'll be working on lightwalletd RPC methods to try to fix this if it comes up. Otherwise I will un-schedule if it's not finished by the time we're done with our RPC changes.

This failed again in the merge queue in PR #6992:
https://github.com/ZcashFoundation/zebra/actions/runs/5305905415/jobs/9603454438?pr=6992#step:8:547

We haven't seen this happen since PR #7103 was merged, so I'm going to assume it was fixed by that PR.

PR #7229 might also have had this happen.

un-scheduling and closing for now


feat(model): Remove 'omitempty' tag (AEROGEAR-XXXX)

Motivation
disabledMessage property should be returned to the client even when empty.
What
Removed the omitempty tag from the disabledMessage property.
Why
This property is used client-side to populate a text input, so it is important for tracking the dirty state of the input that the initial value is an empty string instead of undefined.
Verification Steps
<!-- Add the steps required to check this change. Following an example.

1. View the data from the API for one of the apps at `/api/apps/{id}`. For example: http://localhost:3001/api/apps/0890506c-3dd1-43ad-8a09-21a4111a65a6
2. For this app, ensure at least one of its versions has no value set for the `disabled_message` column in the database.
3. The corresponding app version in `deployedVersions` should have an empty string for the `disabledMessage` property.

## Checklist:

- [x] Code has been tested locally by PR requester
- [ ] Changes have been successfully verified by another team member

## Progress

- [x] Finished task
- [ ] TODO

Coverage remained the same at 93.836% when pulling 8509845bb065f636219ec4b1902eccb08bab7b61 on craicoverflow:return-empty-string-as-default into e8bea93f960c43b9b19d1b88a466aea2302b7220 on aerogear:master.


Observable: Invalid module

Would be great to be able to use this module on http://observablehq.com/.

you can use science =<EMAIL_ADDRESS>


Remove intermediate variable to shave 12B off of localeFormat()

177B → 165B. Should I also modify package.json?
As a bonus, this makes the file more consistent. (shortWeekday was the only intermediate variable.)

Yeah, you can modify it :smile: Thanks for this change!


Increase the default request timeout

And make it configurable

It's already possible to configure the timeout through
ApiClient client = new ApiClient();
client.getHttpClient().setReadTimeout(60, TimeUnit.SECONDS);

Connect, write and read timeout available.


UI Error hardfail for named strings SPFResult

For the past few days, I've been encountering a recurring error for the email domain redacted.com within the UI popup on http://<IP_ADDRESS>/admin/#domains/redacted.com/dmarc:
Error: result[0].Records[0].AuthResults.SPF[0].Result: unknown value hardfail for named strings SPFResult
The overview http://<IP_ADDRESS>/admin/#dmarc/reports lists for redacted.com DMARC "quarantine"/"reject": 0/1, DKIM "fail": 1, SPF "fail" 3
Investigation:

I've compared configurations with other functioning email domains on the same mox server and with historical configurations for redacted.com.
The only identifiable difference is a recent DMARC report received from one counterparty with whom no prior communication has occurred.
At first glance, the exported DMARC report (from the webmail interface) appears to have no syntax errors. It refers to a unknown IP address (which is exptected)
mox in version v0.0.10 is used

Possible Cause:

It's unclear whether the received DMARC report is directly causing the error. I don't know any other way to check the underlying functionality.
Could the source code be making an unintended assumption about the relationship between DMARC reports and SPF lookups?

The error message is coming from the typescript code that verifies the fields in the report against the types. "hardfail" is not a valid SPF result. If a remote server sends it, the Go code will accept it (that's how these types work in Go), but the typescript code will fail on it.
I think it's not helpful for the Go code to reject the report too. It isn't very harmful, and other valid values could be defined in future RFC's. It's better to make sure the typescript code doesn't fail on these values. Right now, all frontend code is strictly typechecking all incoming data from mox api's. Making an exception isn't great. I'll investigate if we can simply represent the SPFResult type (and similarly for dkim and dmarc results) as strings instead of a typescript enum.

@RobSlgm the commit just now rewrites the not-quite-Go-enums into untyped strings so the runtime-type-checking code of the typescript api doesn't try to enforce valid enum values. the same applied to tls reports. i think i got all the not-quite-enums in the dmarc & tls reports.

Fixed in v0.0.12


Docker installation on a Raspberry Pi 3B

I'm facing this error when trying to build the image on a Raspberry Pi 3B:
[...]
Step 33/43 : RUN go run make.go --sqlite=true -v
 ---> Running in 14e0ee5e1d98
/bin/sh: 1: go: Exec format error
The command '/bin/sh -c go run make.go --sqlite=true -v' returned a non-zero code: 2

I tried to set ENV GOOS linux ENV GOARCH=arm and ENV GOARM=7 in the Dockerfile before the buggy line but it doesn't change anything.
I'm running Raspbian Stretch 9.4 and Docker 18.05.0-ce.

The Dockerfile assumes linux/amd64 a few lines up from there:
RUN wget -O go.tgz https://dl.google.com/go/go1.10.2.linux-amd64.tar.gz

That's why you're seeing "Exec format error". Your ARM kernel doesn't like the x86 "go" binary running "go run make.go".
Want to send a fix?

Oh thanks, didn't see that. I'll look into it and send a PR.

For some reason, Go couldn't compile on the Raspberry Pi so I used the golang image directly.

Not enough memory, maybe ?

Or test timeouts.
Did you run all.bash or make.bash?

@mpl I eventually faced this problem but solved it by freeing some memory.
I think the problem was that the sources for 1.10.2 are only available for armv6l and arm64 and not armv7, which is somehow available in the official golang image. I moved on after the installation and forgot what it was exactly.

@raphaelyancey, the "source" downloads of Go aren't for any platform at all.. they're just source and you can compile wherever. Are you talking about binary downloads? But you said above "Go couldn't compile on the Raspberry Pi".

@bradfitz My bad, I meant the binaries. Replacing with armv6l binary in the original Dockerfile didn't make it, and I failed building go from source on the Pi (first because of the free memory requirement, then for something else I don't remember). Then I quickly moved on with the official image that is working and didn't dig deeper into the problem.

@raphaelyancey I lost track. Is the issue fixed for you now?

@mpl Yes we can close, thanks. Not really fixed but bypassed.


fixed bad alloc and added missing unix lv_interop function loading

I am working on some changes to the C++ build tooling and dll linkage (see #144) and noticed that the memory size allocation in OccurServerEvent function is likely 1 byte too big on 32-bit platforms and 3 bytes too small on 64-bit platforms (dependant on the LV array/string byte-packing) . You would have to be pretty unlucky to have something important allocated in the bytes that get "borrowed" on 64-bit systems but it seemed worth fixing.
As we are trying to create a LabVIEW-string from a std::string we can use the existing SetLVString function to allocate and copy the std::string into something we can use to call PostUserEvent.
Clean-up of the handle is done with DSDisposeHandle
Strangley, InitCallbacks function only gets the address of DSDisposeHandle on Windows so I added the code so both platforms load the same functions.
Finally - I removed the call in InitCallbacks which would make the LabVIEW IDE or the RTE exit on a shared-library load error on Linux platforms. It is better to rely on LabVIEW's rudimentary shared-library call fault handling than to just make the whole IDE/Application exit with little indication to the user as to what happened but I am happy to discuss if you feel differently
Cheers

Sorry that the tests need to be rerun. I force pushed a commit with --signoff as per the contribution guide update

Hello - it would be great to get this reviewed or some more information if there is something I can do to help this happen?
I appreciate NI making this open source and I understand if your aren't in a position to accept community PRs but it would be great to know. I would also be happy if this was just fixed by one of the maintainers.


Resource sould be imported from nova, not from app

The app should depend packages, but a package should not be dependent from the app.
...
namespace Bolechen\NovaActivitylog\Resources;

use Laravel\Nova\Resource;
...

thx, fix at next version.


Result Summaries

Feature request
Tracking issue for implementing TEP-0088 - Result Summaries

/priority important-longterm


[Feature] Exclude contributors

🥰 需求描述 Description of Requirement
I would like to use create-comment but don't do that when an issue is created by someone who is already a contributor in this repository.
🧐 解决方案 Solution
Add new option: except-for with an array of following options:

@codeowners
@contributors
user123

OK i will support

@pkuczynski
I thought about it, this create-comment will keep purely functional.
You can use https://github.com/actions-cool/check-user-permission to check if a user is contributor.
And according to check-result to decide what to do next.
If have any questions comment below.

@Shinigami92


Set DVV explicitly in riak_test execution

Before this commit, sibling_benchmark succeeded with the help of
DVV but it was accidental because of a bug [1]. The bug was fixed
by [2] between riak 2.1.1 and (coming, hopefully) 2.1.2 and DVV
should be set explicitly, no surprises.
[1] https://github.com/basho/riak/issues/759
[2] https://github.com/basho/riak_core/pull/765

Probably, https://github.com/basho/riak_cs_multibag/pull/32 is necessary to run r_t :hear_no_evil:

Tested with https://github.com/basho/riak_cs_multibag/pull/32 and it worked.

No release note needed as this is a test code fix.

@borshop merge

For release ntoe : no need to mention, just a test fix.


chore: generate applyconfigurations for custom resources

I think the migration to SSA in this project made the code harder to read/understand. 😉 While the support for SSA in the controller-runtime client is limited at present, ref. https://github.com/kubernetes-sigs/controller-runtime/issues/347, I am convinced that we can do better.
Generating applyconfigurations with controller-gen is in the making, ref. https://github.com/kubernetes-sigs/controller-tools/pull/818 and https://github.com/kubernetes-sigs/controller-tools/pull/536, but it's a complex task that still needs some work.
In the meantime, I suggest generating applyconfigurations using the upstream generator that we can use in our controllers. I also suggest exporting the generated applyconfiguration types, even if I think client types should be available without depending on the operator module - creating a potential dependency-hell. This has been a long-standing issue in cert-manager that I hope can get some progress soon.
/cc @inteon @SgtCoDFish

/hold let's not merge this before the v0.7.0 release

/retest

/test pull-trust-manager-verify


Added support for CPC200-CCPA

My device identifier was slightly different. This adds a second check for my device's ID.

Thanks for the PR :)


[BUG] Personal best times need to be kept for each qualifying segment individually

Discussed in https://github.com/theOehrly/Fast-F1/discussions/164

Originally posted by blakehinsey April 26, 2022
Has anyone noticed the behaviour of the pick_fastest() with Imola data for Qualifying?
I've looked into the code, and the only_by_time=True helps.

Does this mean that Q1 and Q2 laps were not counted as personal bests? It is a strange one as Q1/2 were dry and Q3 times were wet.
I will admit, my coding is not excellent, so maybe I have goofed something up.
It's "BRRRAKE" from Twitter btw!

The API resets personal best for every quali section. Only a reference to the last received personal best time is kept in the API parser. Therefore, Q3 overrides Q2 here despite the times being slower. This could actually happen in some dry sessions too, which is not good at all.
Working around this is non-trivial.The API parser needs to keep track of the order of personal best times to kind of create a ranking of official best times, while still detecting lap time deletions. Additionally, it needs to be possible to split the laps in session.laps into Q1, Q2 and Q3 laps.

Seeing as no one has picked this up, I'm going to take a look at it.

it seems like the issue is that after each Qualifying session, the personal bests are reset. So, even if a time in Q2 was faster, .pick_fastest() will return the fastest time from Q3, correct? In this case the lap_time may actually not be the fastest "legal" lap time set.

Yes, exactly. The API provides the current personal best lap time for each driver, but without any reference to the lap number. That's a bit problematic. Currently, the API parser code only keeps the last personal best time that is ever received, which will be the last personal best in Q3 (or Q2/Q1 if a driver is eliminated earlier). Therefore, the information is lost for any drivers earlier Q sessions. Then the each drivers lap times are compared with the last received personal best time and the first lap that matches the personal best time is marked as fastest lap.
Generally, a new personal best is only received from the API if a driver goes faster than their previous time. Or, if a personal best lap is deleted, the personal best time from before that is sent again. For example, if we receive as personal best times
1:16:150
1:16:050
1:15:900  < deleted
1:16:050

we can assume that the third personal best time was deleted. We have no information about deleted laps, if they were not personal best lap times. (In theory, we could try to extract that information from race control messages. I'm not sure how reliable that would be)

If we set .pick_fastest(only_by_time=True) does that return the fastest lap, regardless of whether it was a legal lap or not?

Yes, it simply returns the lap with the minimum time without any further logic being involved.

Thank you, that cleared up a lot. Is there any documentation on the internal attributed, for example - what is isAccurate in the lap object?

https://github.com/theOehrly/Fast-F1/blob/e4b3778215a3e80ce9154b1a6e1d0ccb2fb5e42e/fastf1/api.py#L601
It seems this is the line of code or logic, where we get the raw lap data for each driver, and figure out the personal best time. I see that we override the personal_best_lap_time everytime we get a new entry which has a BestLapTime.  However, I don't see any identifier in the resp dictionary that could help us identify which session it is (Q1, Q2, Q3 etc.) - any ideas?

Yes, this is a bit challenging. We likely won't be able to determine the individual qualifying sessions from the data here. I was thinking of creating a ranking of personal best times, maybe. Like fastest, second fastest, ... and so on. But not based on the lap time value, but the order in which the personal best values were received.
The individual qualifying sessions can then be separated at a later point using the session status data.

I am still iterating the best approach, but for now I have added an additional column to the data -> AllPersonalBests, so we can keep track of the personal best time.

We can get the Time value for rows corresponding to AllPersonalBests.
The session_status df looks something like this -

I am assuming (couldn't find definitions in the docs) that 'Finished' indicates when a Qualifying (Q1, Q2) session has finished - and for Q3 this is marked by Finalized (classifications complete). We can get the bounds of Qualifying times and then split the AllPersonalBests times by Qualifying. Is this what you were alluding to?
I also looked into whether we can use the race control messages, but I was confused by the Time column there. It's not in pd.timedelta format, and the time doesn't seem to match the session start time for Qualifying which was 17:00, it looks like the times here start from 15:00. Any idea about this? (Screenshot below). Thank you for taking the time to answer my Qs, this is a lot of work you have put into this project!

We could simply keep a track of all the "personal bests" and return the fastest personal best when calling session.laps.pick_fastest(). That way we don't have to split the laps by Qualifying. That can be a separate feature, to get the fastest lap for a particular Qualifying session. What do you think? @theOehrly

I think adding a separate column like you did with the AllPersonalBests is good. I was thinking more like numbering them instead of duplicating the lap time into that column. But your way might probably make it easier to work with the data.

We could simply keep a track of all the "personal bests" and return the fastest personal best when calling session.laps.pick_fastest(). That way we don't have to split the laps by Qualifying. That can be a separate feature, to get the fastest lap for a particular Qualifying session.

Agreed. That's what I more or less had in mind.
We could (potentially as a separate issue/feature) add another column that indicates Q1/2/3 for each lap. And a ready made method to select all laps from a specific quali section.
There is no further information given about the session status data in the docs. I haven't analyzed it in detail and written down how it works (should probably). It's fairly self explanatory though usually.
Regarding the timestamps of the race control messages, I need some time to look at that.
Whenever you want me to take a look at your code, feel free to open a PR, maybe as draft.

I created a PR for only the "return fastest legal lap" change, since it was only a small change. I'll work on the feature for returning laps by Qualifying session in a different PR.

Hey, I have seen this issue now and it looks pretty interesting. I don't know what's exactly the situation now, if you guys have found out how to return the personal best of each qualifying round. If not, maybe I can have a look, I don't have a lot of experience with Python but I'm ready to learn.

I believe this is still an open issue. I'm not going to have some free time soon to complete this, so feel free to work on it! There's lot of discussion in this thread that maybe helpful.

Thanks! I have a little question by the way. If I have  downloaded the source code, and  have made changes to the core.py file, how can I test those changes that I have made locally?
I mean, in a normal script, If I use import fastf1 the original module of fastf1 is loaded, without my changes on core.py
I know it sounds weird but I'm not familiar with github etc so...

@hash55 please try to read through the contribution guidelines: https://theoehrly.github.io/Fast-F1/contributing/index.html.
You're questions will probably at least partially be answered there.
If you have any further questions after that, please open a separate discussion. Then I can try to help you with whatever is still unclear.

Hi! I have made a Pull Request with the changes I've done on my forked repo. It was really my first pull request, so let me know if there is any mistake.
About the changes:
-pick_fastest() (without arguments) now returns the oficially fastest lap of the driver, no matter the qualifying round.
If you really want to know which was the fastest of Qn round, you can call pick_fastest("Q1") so the fastest lap of only that round would be returned, since that is the only round that would be taken into account.
-To verify that the lap was not deleted I created the method Lap.isValid() that compares that lap with the race control messages and checks if it was deleted due to track limits
-I was able to get qualifying rounds (Q1,Q2 and Q3) thanks to the session status data. The method Session.get_quali_rounds() returns a dictionary with the timestamps of beginning and end of each Q1 Q2 and Q3
I don't know if this was exactly what you were looking for, but as far as I am concerned it works pretty decent, but some tests need to be made.
I left appart the isPersonalBest attribute since I didn't figure out how it worked.
I know that the code  have been written in a more "correct" way, but this is just the beginning.
Please, feel free to have a look at it and tell me what you think about it!

I have now implemented this feature and it will be included in the next major release. Thank you for the very constructive discussion through which all relevant parts had already been discussed. This made it much easier now to actually implement this.


Container keeps exiting

Running the docker container, it seems to download a few files then exit.
Nothing really in the logs that would indicate an error. All I see is:
librofm-downloader-1  | 2024-12-27 01:47:41.684 [main] TRACE i.k.c.plugins.HttpRequestLifecycle - Cancelling request because engine Job completed
librofm-downloader-1  | Exception in thread "main" kotlinx.coroutines.JobCancellationException: Parent job is Completed; job=SupervisorJobImpl{Completed}@644abb8fg

could you enable VERBOSE logging and see what it spits out?

yeah.. just tried that. Unfortunately since it also outputs the binary content it's a bit hard to read :D
The issue does not occur in "dry run" mode. I suspect some error gets thrown but then is swallowed by Kotlin.. but can't confirm that

just to confirm: are you running this via docker-compose? I dont think it'll change anything but just interested in the run environment

@burntcookie90 Indeed I am.

i'll try and poke around and see what i can come up, even if its something to help log better.

ive pushed a few changes to the container, feel free to pull main or latest and see if its maybe fixed by side effect? 😅

Unfortunately not. @burntcookie90
But you never know.. was worth a try 😄

Darn. My one last request would be to try and run it with a new data directory bind so that it can start clean. Otherwise I'll try and get a custom image up with some better/smarter logging to try and debug a bit in the new year.

Tried that already but I just did it again just in case... no luck.
Smarter logging sounds like a good idea. Thanks for the efforts!!!

I found the issue!!
My Kotlin was a bit... rusty... but when debugging I noticed that it would ALWAYS fail after the first book (whereas when running it standalone it was a bit random when exactly would fail).
After a bit of randomly peaking and poking at things (at first I thought it was an exception that cancelled the main thread.. then I thought it was a concurrency issue of some sort) I realized that the HTTPClient was "closed" from there I read up on the http client and bingo!
it's this line: https://github.com/burntcookie90/librofm-downloader/blob/d80da0d83e7256c171f64693380d010b33f46154/server/src/main/kotlin/com/vishnurajeevan/libroabs/libro/LibroFmClient.kt#L88
httpClient.use{} autocloses the http client which then fails when reused!
See https://ktor.io/docs/client-create-and-configure.html#close-client

Oh wow, thanks for digging! I'll have sometime mid week to try and make some fixes. I wonder why I hadn't run into this

#25 might be related as well

can you try and pull from the main tag and lemme know if its working on your end? I'll cut a new release after so latest can be updated

Wow.. that was quick! @burntcookie90
Works. I was able to download my entire library (started from a clean state just to be safe) and now the webserver is running.
Tested the /update endpoint and it works too without crashing

Fantastic! Thanks again for locating the bug, saved me a bunch of time.

You're welcome. Thank you for the project.


How to implement a login page using a separate template page instead of sharing a layout with other pages

How to implement a login page using a separate template page instead of sharing a layout with other pages

You can create a new layout component in the src/WordDaze.Client/Features/Layout/ folder, for example, called LoginLayout.
Then in your login component, you just need to update the @layout MainLayout directive to be @layout LoginLayout.

Alternatively, you could just remove the @layout directive from the login page component. It would then not inherit any layout at all and you could code it however you wish.


envoy: Update Envoy to e792008a

Pulls in https://github.com/envoyproxy/envoy/pull/21908, which is needed to build the
xDS integration tests in Envoy Mobile.
Signed-off-by: Ali Beyad<EMAIL_ADDRESS>

/cc @alyssawilk

/retest


[WIP] Add Organization Membership API methods

Description
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b83b201) 97.13% compared to head (2378599) 97.13%.

Files
Patch %
Lines

lib/workos/organization_membership.rb
95.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   97.13%   97.13%
=======================================
  Files          52       54    +2
  Lines        1220     1255   +35
=======================================
+ Hits         1185     1219   +34
- Misses         35       36    +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


New Game: Space Invaders Game

Space Invaders is a classic game commonly found at any retro-based arcade
I would love to work on this plz assign .

Hi @nikhilkumar50 , I assigned this issue to you, please complete you work within a week. Good luck nikhil.

Assign me this issue under GSSoC'23 label


TargetType default value for sampleData

Is there a reason why sampleData  in TargetType protocol does not have a default value? It's a great feature but would love to get rid of return "".data(using: String.Encoding.utf8)! when not testing.

You can return Data() too. We don’t offer defaults so the implementation is always clear (see the Vision document)

Thanks


Make Ardulink compilable on Windows

Introduces a thin abstraction layer in serial_dev.h using a serial_dev_t structure.
Compile-time switches in native Windows or Posix (Linux, Mac) functions while keeping the return value meanings unchanged.
Succesfully compiles for Windows now, test is outstanding.

caaaan you test?

Absolutely, doing some improvements and tests right now, just opened "prematurely" to raise awareness that I'm working on this.

Works!

Woah, what's going in here? The TargetReset function pointer is set in ardulink.c, but minichlink.c never uses it? As such, the init() method will activate reset (1) but noone ever pulls the chip out of reset. I don't imagine that that is how it worked previoiusly.

Okay, so https://github.com/cnlohr/ch32v003fun/commit/785ce78340cba2966fe34093f1c899c178a83cef removed the call to pull reset down to 0 again and thus broke ardulink.
How should this be handled @cnlohr? Should the init function not touch the reset line, or should the call to reset (0) be added back in, provided the reset function exist?

This is fine.

Uuhh hmm... there are conflicts...  Any chance you could pull again?  I realized I had another tree with other adjacent changes.

I've resolved the merge conflicts
I've re-added the reset code again with a null check so that Ardulink works when RESET is connected. Should not affect other programmers.

Since it was heavily bugging me that the Ardulink COM port wasn't selectible via a command argument switch, I've now added in this functionality. Please carefully inspect https://github.com/cnlohr/ch32v003fun/pull/180/commits/fbab6c28e763dfd0aeb0765133ffc4ebc88d4fc9.
It adds the concept of initialization hints for the init functions, the first member of which is the serial port. That could be in the future be expanded with more like VID/PIDs to search for, an explicit USB path to use if multiple programmers are connected to a computer, etc.
This does break the binary compatibility in the ABI because it adds one more parameter to the init function. If this is unwanted, I can revert.

@maxgerhardt What is the purpose of TargetReset?  Everything should be 100% done via the SWIO pin, unless I'm missing something?

I only restored what was there before (in a non-crashing way), @BlueSyncLine designed it with the reset line.
I also experienced it worked without connecting NRST, but if it's connected, it must be controlled, because the Arduino Uno firmware by defaults sets its pin as output and drives it low, holding the processor in reset.


LE Audio: Update CCP API with new naming scheme

Is your enhancement proposal related to a problem? Please describe.
Apply the new naming scheme from https://github.com/zephyrproject-rtos/zephyr/issues/40920 to the CCP implementation and API.
This is related to https://github.com/zephyrproject-rtos/zephyr/issues/41214 and may either depend on or implement that as part of this solution.
Describe the solution you'd like
N/A
Describe alternatives you've considered
N/A
Additional context
N/A

We will use MICP as the pilot for this change in https://github.com/zephyrproject-rtos/zephyr/issues/45558 as that is by far the simplest profile. Once we have agreed on the details, we can use that to complete this issue;

The idea will be to add a CCP API on top of TBS, rather than replacing it.
The CCP API will be created from scratch, one functionality at a time to reduce the size of PRs. Each iteration will be complete with unit tests, bsim tests, samples and shell commands.
The data storage will be moved from TBS to CCP, so that TBS only defines the structures and handles the GATT stuff, but CCP will be responsible for the data. The data in CCP may be handled by higher layers. This approach allows other profiles to use TBS only as a service, and not as a full implementation (splitting the service from the profile). It is still TBD whether or not the tests for TBS shall remain, as they will be covered by the CCP tests.
It is still TBD whether the same functionality shall be handled in both the CCP Server and CCP Client at the same time, or if the CCP server shall be completed before work on the CCP client is started.


[SSO][Recaptcha] Recaptcha is not displayed after the user account is locked and the email notification is not sent

Describe the issue:
When account locking (5 attempts) and Prompt reCaptcha after max failed attempts (3 attempts) enabled, recaptcha is prompted after the max failed attempts exceeded. However, if the user keeps on entering incorrect passwords, recaptcha prompt is disabled after the account is locked.
How to reproduce:
(Checked with IS resident IdP)

Enable Lock user accounts on maximum failed attempts - max failed attempts: 5
Enable Prompt reCaptcha after max failed attempts - max failed attempts for recaptcha: 3
Start IdP initiated SSO flow to a SP, use a valid username and provide incorrect password

Actual outcome:

Recaptcha is prompted after 3 failed attempts
Recaptcha prompt is not displayed after 5 failed attempts
Try with a different account on the same window, recaptcha is prompted again after 3 failed attempts
FE Error message states Login failed! Please check your username and password and try again., no mention about the account being locked
Warning (see comment 1) logged

Expected behavior:

Recaptcha should continue to be prompted after the failed attempts

Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: IS 5.12 Alpha 13
OS: Windows 10
Database: MySQL
Userstore: JDBC
Browser: Firefox 97

Optional Fields
Related issues:

Suggested labels:

Warnings:
[3dd423b0-baf3-4d7d-aec8-99369a053ab7]  WARN {org.wso2.carbon.identity.captcha.filter.CaptchaFilter} - Captcha validation failed for the user. Cause : reCaptcha response is not available in the request.
Screen capture:
https://user-images.githubusercontent.com/37894306/156716443-79b9df05-0a1c-48a1-ba34-fa36499f3da8.mp4

Have you following this https://is.docs.wso2.com/en/latest/learn/setting-up-recaptcha/ and configure recaptcha keys?

I tried with below configurations, and the flow is worked as expected.

Configuration :

Enable Lock user accounts on maximum failed attempts -> max failed attempts: 5
Enable Prompt reCaptcha after max failed attempts -> max failed attempts for recaptcha: 3

Expected behavior is, reCaptcha is prompted after 3 failed attempts and account is locked after 5 failed attempts. And after the 5 failed attempts, user cannot log in until user is unlocked. Then reCaptcha is not required to prompt after 5 failed attempts because the users cannot login.

Regarding to Account lock notification email is not received when the account is locked --> If email is configured in user profile of user,  notification email is received  when the account is locked.

Regarding to FE Error message states Login failed! Please check your username and password and try again -->

Common Auth failure message is showed in the login page even user is locked.
If we want to show the actual Auth failure message in login page , it is required to configure below in the deployment.toml

[authentication.authenticator.basic.parameters]
showAuthFailureReason = true
showAuthFailureReasonOnLoginPage = true

But the expected behavior, "Not required to prompt reCaptcha after max failed attempts to lock user account because user cannot login after the account is locked" is not clearly mentioned in the documentation. https://is.docs.wso2.com/en/latest/learn/configuring-recaptcha-for-single-sign-on/

@sandushi Can you please create a doc issue and link here?


Overlay doubleclick prevents from closing modal

Like described in the title

Maybe, you should open this issue in material-ui? We have just reused controls, so it seems to be the bug from material-ui side :)

@dmtrKovalenko Not really, look at this line. It shouldn't toggle it should close. Simple fix really, @michalpokojski Can you take care of it? 😅