helm install is not idempotent

After follow this guide: https://gateway.envoyproxy.io/v0.4.0/user/quickstart.html, pods in gateway-system are not removed.
k get pod -n gateway-system
NAME                                           READY   STATUS      RESTARTS   AGE
gateway-api-admission-jv26k                    0/1     Completed   0          2m1s
gateway-api-admission-patch-bt6ss              0/1     Completed   0          2m1s
gateway-api-admission-server-f95c4df77-dlw6d   1/1     Running     0          2m1s

cc @arkodg @Xunzhuo

should we add an extra clean up step saying Delete gateway-system and make it opt in, because there will be one validation webhook controller, but multiple GW API controllers in the cluster ?

@arkodg Yes, that is why we put gwapi resources in crds/ , since there might be not only one gateway providers.
We use intall.yaml before, but if we clean it up with delete -f intstall.yaml, we might delete gwapi resources wrongly if other providers are using too.

we could add more steps such as
kubectl delete namespace gateway-system

But the CRDs still remain in the cluster
Another option I was playing with was using helm template
helm template eg oci://docker.io/envoyproxy/gateway-helm --version v0.4.0 -n envoy-gateway-system --include-crds | kubectl delete -f -

This correctly deletes everything, but leaves helm confused, if I run helm install again after this
$ helm install eg oci://docker.io/envoyproxy/gateway-helm --version v0.4.0 -n envoy-gateway-system --create-namespace
Pulled: docker.io/envoyproxy/gateway-helm:v0.4.0
Digest: sha256:6dd5be285169065d6e1d3e2167984dcf1ae06e2f87bc37c1414becce0a733e45
Error: INSTALLATION FAILED: cannot re-use a name that is still in use

there's two ways to manage crds in helm:

Let helm Do It For You
Separate Charts

even use method-1, IMO you should remove adminission server resources out of crds folder

@zirain if the admission server out, we might accidentally delete it if there are multiple EG running in the same cluster and we want to delete some of them, but not all

this's supre odd, use independent install/uninstall step for gateway-api installation?

I would strongly vote for a separate CRDs chart that's manually installed. Don't do it as a dependent chart, just let the user install the CRDs, then the Envoy Gateway control plane. (This is the way Linkerd does it.)

should be fixed with https://github.com/envoyproxy/gateway/issues/1721


[Question]Is there a feature that allows me to pause and continue tracing

Our services involve account login and switch user. For security reasons, we expect to pause tracing(like page.pause()) during login  and then continue tracing.Now, only the start and stop APIs are available.

You can use startChunk/stopChunk methods which are available since v1.16 and pause the tracing whenever you like.


is there a way to suppress the initial console output if workers are more than 1?

I see this when workers is not the default value:
Starting type checking and linting service...
Using 3 workers with 4096MB memory limit
Watching: /Users/kelly/tock/admin/dashboard/src

is there an option to suppress this sort of stuff and only log out any TS or TSLint errors?

Have you tried using silent?

silent disabled all logging of errors. I want the errors to be displayed, just not the other stuff. maybe a log_level setting or something would be nice?

Yeah possibly - ts-loader has similar. Would you consider putting together a PR?

Will take a look.


New error with read_qza for table.qza?

Hi,
First, thank you for this package, I've used it a lot in the past and it's saved me a ton of time.
I'm having an issue with the read_qza function when I try to read an ASV table. I'm using qiime2-2020.2 and the latest version of qiime2R. This is a table that I'm generating within R and importing into qiime2. I don't get any issues within qiime, and I recall being able to run this command without issue last time I used this package (months ago), so hopefully this is something we can clear up!
Here's the error:
> SVs <- read_qza("asv_table.qza")
Error in dimnamesGets(x, value) :
  invalid dimnames given for “dgCMatrix” object
Calls: read_qza ... colnames<- -> dimnames<- -> dimnames<- -> dimnamesGets
Execution halted

Here's my session info:
               _
platform       x86_64-pc-linux-gnu
arch           x86_64
os             linux-gnu
system         x86_64, linux-gnu
status
major          3
minor          6.2
year           2019
month          12
day            12
svn rev        77560
language       R
version.string R version 3.6.2 (2019-12-12)
nickname       Dark and Stormy Night
> library(qiime2R)
> session.info()
Error in session.info() : could not find function "session.info"
> sessionInfo()
R version 3.6.2 (2019-12-12)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Red Hat Enterprise Linux Server 7.7 (Maipo)

Matrix products: default
BLAS:   /usr/lib64/libblas.so.3.4.2
LAPACK: /usr/lib64/liblapack.so.3.4.2

locale:
 [1] LC_CTYPE=en_US.utf8       LC_NUMERIC=C
 [3] LC_TIME=en_US.utf8        LC_COLLATE=en_US.utf8
 [5] LC_MONETARY=en_US.utf8    LC_MESSAGES=en_US.utf8
 [7] LC_PAPER=en_US.utf8       LC_NAME=C
 [9] LC_ADDRESS=C              LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_US.utf8 LC_IDENTIFICATION=C

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] qiime2R_0.99.33

loaded via a namespace (and not attached):
 [1] Biobase_2.46.0      tidyr_1.0.2         jsonlite_1.6.1
 [4] splines_3.6.2       foreach_1.5.0       Formula_1.2-3
 [7] assertthat_0.2.1    stats4_3.6.2        phyloseq_1.30.0
[10] latticeExtra_0.6-29 yaml_2.2.1          pillar_1.4.3
[13] backports_1.1.5     lattice_0.20-40     glue_1.4.1
[16] digest_0.6.25       RColorBrewer_1.1-2  XVector_0.26.0
[19] checkmate_2.0.0     colorspace_1.4-1    htmltools_0.4.0
[22] Matrix_1.2-18       plyr_1.8.6          pkgconfig_2.0.3
[25] zlibbioc_1.32.0     purrr_0.3.3         scales_1.1.0
[28] jpeg_0.1-8.1        htmlTable_1.13.3    tibble_3.0.0
[31] mgcv_1.8-31         IRanges_2.20.2      ggplot2_3.3.0
[34] DT_0.13             ellipsis_0.3.0      nnet_7.3-13
[37] BiocGenerics_0.32.0 cli_2.0.2           survival_3.2-3
[40] magrittr_1.5        crayon_1.3.4        fansi_0.4.1
[43] nlme_3.1-145        MASS_7.3-51.5       foreign_0.8-76
[46] truncnorm_1.0-8     vegan_2.5-6         tools_3.6.2
[49] data.table_1.12.8   lifecycle_0.2.0     stringr_1.4.0
[52] Rhdf5lib_1.8.0      S4Vectors_0.24.3    munsell_0.5.0
[55] cluster_2.1.0       Biostrings_2.54.0   ade4_1.7-15
[58] compiler_3.6.2      rlang_0.4.5         rhdf5_2.30.1
[61] grid_3.6.2          iterators_1.0.12    biomformat_1.14.0
[64] rstudioapi_0.11     htmlwidgets_1.5.1   igraph_1.2.5
[67] base64enc_0.1-3     gtable_0.3.0        codetools_0.2-16
[70] multtest_2.42.0     reshape2_1.4.3      R6_2.4.1
[73] gridExtra_2.3       knitr_1.28          dplyr_0.8.5
[76] Hmisc_4.4-0         permute_0.9-5       ape_5.3
[79] stringi_1.4.6       parallel_3.6.2      NADA_1.6-1.1
[82] Rcpp_1.0.4          vctrs_0.2.4         zCompositions_1.3.4
[85] rpart_4.1-15        acepack_1.4.1       png_0.1-7
[88] tidyselect_1.0.0    xfun_0.12

Would you be willing to send me your artifact so I can debug? I changed the method of biom import to avoid another bug in biomformat. I'm wondering if there could be some odd character in your sample names, or perhaps it could be something along the lines of sample names are numbers?

There are underscores and periods in the sample names, but that hasn't been a problem in the past. Also I'm still able to import older projects which have similar sample names. Can I send the artifact to you over email?

That would be great! Please send to<EMAIL_ADDRESS>

fixed in update


Add support for node.js and commonjs

Uses an extra global variable but it should allow the script to be loaded into specific contexts so its not a total loss. I tested client-side and server-side with the TV Show example and both work. I have added an example for the server but am pretty sure it isn't a great way to show how the library works. I have not minified the file, only updated the file in the source folder.

Would be good to add this to npm too if we can use it server side!
Would this create security vulnerabilities on my express server due to {{js "expression"}}?
Like if someone added {{js "print(process.env.AWS_KEY)" }}?

It would possibly be bad if you didn't sanitize your inputs but otherwise there aren't any inherent risks. If you don't feel like sanitizing your inputs for whatever (likely misinformed) reason, you could also remove the part of the library that runs JS functions.


Fix data race setting default_DSO_meth

The global variable default_DSO_meth was potentially set multiple times by different threads.  It turns out that it could only be set to a single value so the race is harmless but still better avoided.  The fix here simply removes the global and accesses the value it was set to via the DSO_METHOD_openssl() call.
Problem discovered via #16970, but this does not resolve that issue because there are other concerns.

[ ] documentation is added or updated
[ ] tests are added or updated

This pull request is ready to merge

Merged to 3.0 and master.  Thanks for the review.


Survey: which terraform-libvirt conf files are for  you important used in PROD or everyday etc?

this is a survey:
i would like that you can post your tf.files  that you use in your Project, production or in your daily work flow.  ( without any sensitive data of course :dancer: :robot: ).
The terraform files or use-cases that you care about.
Having this kind of files could help us to see also the usage and if we cover more or less all scenario with our testacc. ( if this tf files are to much complicated to execute with our testacc we can try to schedule them on a release basis)

https://github.com/moio/sumaform/tree/master/modules/libvirt

https://github.com/kubic-project/automation/blob/master/caasp-kvm/cluster.tf.erb

https://github.com/openshift/installer/blob/5373f16f2322b243cad7ccb616368847d6516500/steps/masters/libvirt/main.tf

i am closing it because nobody answered really m anyway is ok was an experiment :sun_with_face:


freopen_s is C11

According to http://en.cppreference.com/w/c/io/freopen, freopen_s is C11, and it is only available on certain compilers, and if you request C11 using __STDC_WANT_LIB_EXT1__. On MinGW miniz generates a compiler warning for this currently.
Would you consider either

declaring the appropriate macros to request C11, and document that miniz requires C11, or
using freopen instead?

Thanks!

This is a special case for MSVC/mingw64

@uroni It is indeed, but still, freopen_s is only surely available if you test for STDC_LIB_EXT1 and define __STDC_WANT_LIB_EXT1__.
So maybe you could do this on MSVC and MinGW64?
And, since the current implementation does not work on older MinGW versions, maybe it would be better to fall back to freopen?

I've just run into this issue (not compiling on Mingw64 due to freopen_s). It can be fixed by editing miniz_zip.c as follows:
Putting this here in case anyone else comes across this issue via the google machine
static FILE *mz_freopen(const char *pPath, const char *pMode, FILE *pStream)
{
    FILE *pFile = NULL;
    //if (freopen_s(&pFile, pPath, pMode, pStream))
     //   return NULL;

	pFile = freopen(pPath, pMode, pStream );
    return pFile;
}


Passes credentials through to Set-ADGroup and Move-ADGroup cmdlets

Fixes #106

This change is

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

Tests/Unit/MSFT_xADGroup.Tests.ps1, line 493 [r1] (raw file):

            }

            It "Calls 'Set-ADGroup' with credentials when 'Ensure' is 'Present' and the group exists (#106)" {

What does #106 refer to?

Comments from Reviewable

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.

Tests/Unit/MSFT_xADGroup.Tests.ps1, line 493 [r1] (raw file):
Previously, narrieta (Norberto Arrieta) wrote…
> What does #106 refer to?

OK - Issue #

Comments from Reviewable

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable


Updated to Minecraft 1.20.2

Fix unable to load worlds with names which don't match world folder name saved on disk (fixes #4 & #7)
Bump version to 1.2.3
Build: https://github.com/TheMrEngMan/continue-button/releases/tag/1.2.3

I dont accept pull requests that bump the version as it breaks my release workflows. Thanks for doing it though - but please let me update mods in my own time.


Contact details of authors

@jsteyn Can I add your orcID and email to the first slide?

Sure thing: https://orcid.org/0000-0002-0231-9897


[BUG] ReAct Agent for LLMs couldn't invoke tool.

Describe the bug
ReAct Agent for LLMs couldn't invoke tool.
To Reproduce
Steps to reproduce the behavior:

Create a "ChatFlow".
Add "React Agent for LLMs" Node.
Add "ChatOpenAI" Node or "OpenAI" Node.
Add "Custom Tool" and Select a NO Args tool.

Expected behavior
return current time in my case
Screenshots

Flow
If applicable, add exported flow in order to help replicating the problem.
Setup

Installation pnpm start
Flowise Version 2.0.2
OS: macOS
Browser chrome

Additional context

await this.schema.parseAsync(arg) throw a exception when arg is a empty string.

No tool call in langsmith

If you want to invoke tool, try using Tool Agent

If you want to invoke tool, try using Tool Agent

Yes, tool agent is ok.
What confuses me is that the ReActAgent also has allowed tools, but I’m unable to use them. Is this due to a known bug or some other reason?

I see. cuz no function call in ReAct Agent. so, input params can not parse to object.


Add functionality to AsyncProgressWorker::Execute to schedule future call to itself

I have a very particular usecase which goes as follows,
I have a node app running HTTP server and has a C++ bindings for some video related work. The resources served by the server hook to NAN APIs of C++ code which start infinitely long running tasks. e.g. NAN API to startProcessing will read video from an RTP source and process it until stopped. This uses gstreamer and its running on a thread outside node threadpool.
I also have requirement to know status update on this operation and so pass a JS callback to the API startProcessing(onStatusUpdateCb).
I am making use of AsyncProgressWorker at the moment to achieve this long running and multiple async callback relation between C++ and JS. I queue the worker using AsyncQueueWorker() which runs Execute on one of the available worker threads (correct me if I am wrong).
my Execute function keeps monitoring a global queue for any status updates from my gstreamer thread in a while(1) loop and calls Send when the queue is not empty.
This makes one worker thread always blocked in a while (1) loop. Is there any better way to implement my requirements? or else it would be very handy to have an API in AsyncProgressWorker to schedule future calls to Execute with a timeout. This will remove the need for while(1) loop and will also relinquish the worker thread permanently held for monitoring.
Feel free to point out any obvious mistakes in the design.
Regards,
Ameya

hi @kkoopa. Can you please suggest any alternatives to above problems?

There ought to be a better way to implement said requirements, but I do not really know how. My initial guess would be using libuv directly to devise something which requires less busy waiting.
Perhaps the gstreamer thread could call uv_async_send to notify an event loop that there is something to process in the queue.


Adding files to zip fails when using AES

Steps to reproduce
Hi everyone, i've got this code
public static void CreateZipPackage(string zipName, Dictionary<string, byte[]> files)
{
    using(FileStream zip = File.Create(zipName))
    {
        using(ZipOutputStream zipStream = new ZipOutputStream(zip))
        {
            foreach (KeyValuePair<string, byte[]> kv in files)
            {

                // Compress the entry in the package
                ZipEntry entry = new ZipEntry(kv.Key);
                entry.AESKeySize = 256;
                //Add an entry
                zipStream.PutNextEntry(entry);
                // Set the compression level 1~9
                zipStream.SetLevel(5);
                zipStream.Password = "PASSWORD";
                //write
                zipStream.Write(kv.Value, 0, kv.Value.Length);

            }
        }
    }
}

I noticed that i can view the content of the files in the ZIP even if it's password protected, so i've decided to add "entry.AESKeySize = 256;" to encrypt the files
But then i received the Error: Buffer cannot be null - parameter name: array (when closing the ZipOutputStream)
Expected behavior
I want to zip and encrypt multiple files in c#
Actual behavior
Error: Buffer cannot be null - parameter name: array
Version of SharpZipLib
<IP_ADDRESS>

Hm, you are setting the password after the entry has been added, that probably doesn't work. Try moving the
                // Set the compression level 1~9
                zipStream.SetLevel(5);
                zipStream.Password = "PASSWORD";

to before the foreach loop.
Also, are you sure about that error message? It doesn't seem right.
If you can give me the full exception I can look into what is going on...

I tried turning off the password in one of the zip output stream unit tests and got
  Message:
    System.ArgumentNullException : Buffer cannot be null.

Looks to be because some of the logic goes off entry.AESKeySize being set to a non-zero value (deciding whether to write the AES extra data etc), but them some of it goes off Entry.IsCrypted being true, which is only done automatically if a password has already been specified when the entry is added, so some of the other crypto bits get skipped.
Gets itself in a bit of a mess basically.
Possibly PutNextEntry should throw if you try to add an entry with AESKeySize set, but no password set?

Yeah, that's basically what I figured was going on. It should definitely throw there, the error messages of the type x cannot be null (where x is not from a public parameter) is not particularly helpful for consumers.
I think the original problem was caused by the same problem

I noticed that i can view the content of the files in the ZIP even if it's password protected
non-AES encryption should still work (even though it's weak and I'd recommend you use AES when possible), but you need to set the password before adding the entries.


PD: Create Thermal cycling profile steps

Background
As a user I would like to add steps to my profile
Acceptance Criteria
Clicking the [+ Step] button generates a row of form fields
Row contains:

A number that is +1 from the row number above
A temperature form field
Two time form fields (min and s)
A delete button outside the border
A border

Note: form does not need to save
Design
https://zpl.io/VxZW8Qk

Closed via #5795


Error with multiple merge bases

Report
What did you do?
Run Danger on a PR from a Jenkins build.
What did you expect to happen?
Danger runs without crashing.
What happened instead?
In some scenarios, Danger crashes with an error remarkably similar to the error in #904.
Your Environment

Running in Jenkins
Running on v5.5.5# please paste here, with 2-space identation, thank you!
xcov.report(
   scheme: ENV["FL_XCOV_SCHEME"],
   workspace: ENV["FL_XCOV_WORKSPACE"],
   skip_slack: ENV["FL_XCOV_SKIP_SLACK"],
   derived_data_path: ENV["FL_XCOV_DERIVED_DATA"],
   only_project_targets: true
)
xcode_summary.ignored_files="Pods/**"
xcode_summary.report(ENV["FL_XCS_REPORT"])

Not exactly the right Dangerfile but I don't think it's important.  If it is, I'll sanitize it and update.
Food For Thought
My best guess for how this ended up happening is related to this line, specifically the fact that the call is for merge-base --all which has the chance of providing multiple merge bases.
In most cases there should be a single merge base returned because the incremental fetch starts out very small.  However if the incremental fetch size increases because a merge base was not found, it may end up becoming large enough that multiple merge bases are returned at once.  The result (multiple lines of text) isn't sanitized so the error ends up getting displayed.
This normally ends up sorting itself out as a merge base eventually appears closer to the tip of the branch and only one result is found again, making it harder to debug.  I think this happens to me more often because I am using shallow cloning - the merge base isn't found right away and a larger fetch is often required.
Is there a reason to include the --all flag?  If I'm right removing that would easily solve this and provide a much better explanation for #904 than not using a puts statement.

Hi @raymondhoagland
I've created the patch at https://github.com/danger/danger/pull/967
BTW, I've fixed it by chnaging a way to fetch the repositories like this
git init
git remote add origin <some origin>
git fetch origin <base_branch> --depth 1
git fetch origin +refs/pull/<pr_number>/merge
git reset --hard FETCH_HEAD

It's inspired by Travis-CI
Regards.

Fixed with #967


change all uid validation or types

All uid will be change to snowflake.

If proto definition use as public then uid type keeps string, but validate condition need to be updated.
If proto definition use as internal rpc calls then change types to int64.
If one proto definition use in both ways (public and internal) then split it to two pb definition then re-check step 1~2


Cannot connect to local Cloud Foundry deployment when behind proxy

I cannot set my api endpoint when I am behind my corporate proxy. I am following the Cloud Foundry deployment steps in the readme, but whenever I run the command cf api --skip-ssl-validation https://api.<IP_ADDRESS>.xip.io, I get this error:
 $ cf api --skip-ssl-validation https://api.<IP_ADDRESS>.xip.io
 Setting api endpoint to https://api.<IP_ADDRESS>.xip.io...
 FAILED
 Error performing request: Get https://api.<IP_ADDRESS>.xip.io/v2/info: read tcp <my ip>: connection reset by peer`

My vagrant VM is running, and bosh cck shows no errors and both my http_proxy and https_proxy vars are set. I have tried setting my no_proxy as well, as instructed from the readme:
 $ printenv
 ...
 no_proxy=<IP_ADDRESS>,*.xip.io

However, if I disconnect from the company's network and use my own network connection at home, then I do not get the error. Is there something else I need to do to be able to work behind a proxy?

Hi @mhlandry,
Most likely when connected to the company network, whatever client you are using for that has updated your routes to send network traffic over that link first.
If you haven't already done so, run the bin/add-route script from the bosh-lite repository.
If that doesn't work, you might need to adjust your routes table in some other way to force the traffic to be routed to the Vagrant VM
The CF Runtime Team,
@jpalermo && @DanLavine

Hi @DanLavine,
Thanks for the reply.  I did add the route but I still have the same issue.  If I turn on CF_TRACE, I wind up getting:
Error performing request: Get https://api.<IP_ADDRESS>.xip.io/v2/info: read tcp x.x.x.x:80: connection reset by peer

where x.x.x.x:80 is an IP address on my company's internal network.
But if I curl the URL, I get a good response:
{"name":"vcap","build":"2222","support":"http://support.cloudfoundry.com","version":2,"description":"Cloud Foundry sponsored by Pivotal","authorization_endpoint":"http://login.<IP_ADDRESS>.xip.io","token_endpoint":"https://uaa.<IP_ADDRESS>.xip.io","min_cli_version":null,"min_recommended_cli_version":null,"api_version":"2.27.0","logging_endpoint":"wss://loggregator.<IP_ADDRESS>.xip.io:443"}%

So it seems to me that the cf cli is ignoring my proxy settings somewhere along the line...

Hi @mhlandry,
The problem with using xip.io is that it requires external network activity. You might want to take a look at their documentation. Unless you do something to force traffic to your bosh-lite deployment, unfortunately we don't think there's a workaround for this.
As an aside, we noticed that you might want to target api.10.244.xip.io instead of https://api.10.244.xip.io once you've sorted that out (the cli doesn't require you to include the protocol when targeting an api).
Hope that helps,
@DanLavine && @utako, CF Runtime Team

Hello @DanLavine and @utako.  I don't think the problem is with my external network activity or xip.io.  From the same terminal that I run the cf api command, I can successfully curl the target.  Doesn't this eliminate network connectivity and xip.io as potential culprits?

Hi @mhlandry
It definitely looks like an issue in the way the cli is attempting to communicate with your bosh lite inside the corporate network. That being the case, I'm not sure Runtime can help you much. I'm adding @goehmen (CLI Project Manager) to this conversation to try and sort this out.
Sorry for the continued confusion,
@zaksoup + @wendorf CF Runtime Team

Hi @mhlandry,
It looks like you also opened an issue on the (cli)[https://github.com/cloudfoundry/cli/issues/464]. Our investigation so far indicates that the CLI is indeed the more informed team on this matter, so we've decided to close this issue and migrate the conversation to that thread.
@Quintaminant && @DanLavine, CF Runtime Team

Thanks @Quintaminant and @DanLavine.  I wasn't sure where to create the issue.  Thanks for pointing me in the right direction!

Can you try a no_proxy env variable for the xip.io address and test?
export no_proxy="localhost,<IP_ADDRESS>,localaddress,.xip.io"
Then run cf api api.<IP_ADDRESS>.xip.io --skip-ssl-validation?

@sparameswaran Does it matter if no_proxy is capitalized or lowercase?  If it does not matter, then from above my no_proxy is currently <IP_ADDRESS>,*.xip.io

Dont put * in front of the .xip.io (leave it as .xip.io), and no_proxy is
in small case.
-Sabha
On Thu, Jun 18, 2015 at 3:09 PM, Matthew Landry<EMAIL_ADDRESS>wrote:

@sparameswaran https://github.com/sparameswaran Does it matter if
no_proxy is capitalized or lowercase? If it does not matter, then from
above my no_proxy is currently <IP_ADDRESS>,*.xip.io
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry/cf-release/issues/679#issuecomment-113302310
.

@sparameswaran I have tried without the * as well but I got the same result.

Can you have CF_TRACE=true cf api ... and see if its still trying to go
over your proxy or not?
-Sabha
On Thu, Jun 18, 2015 at 3:23 PM, Matthew Landry<EMAIL_ADDRESS>wrote:

@sparameswaran https://github.com/sparameswaran I have tried without
the * as well but I got the same result.
—
Reply to this email directly or view it on GitHub
https://github.com/cloudfoundry/cf-release/issues/679#issuecomment-113304478
.


Remove Findfmt.cmake

Description
fmt provides cmake config files since at least version 7.0.0, which is the minimum version supported.
Fixed some variable names, so the provided config can be used.
The previous variable names were missing, if the library was installed in a custom location,
like in case of manual build or provided by conan.

Tests

Checklist:

[x] I have read the contribution guidelines.
[ ] I have updated the documentation, if applicable.
[ ] I have ensured that the change is tested somewhere in the testsuite
(adding new test cases if necessary).
[x] If I added or modified a C++ API call, I have also amended the
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
[x] My code follows the prevailing code style of this project. If I haven't
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.

Conan still does not like this solution:
CMake Error at src/include/CMakeLists.txt:77 (file):
  file COPY cannot find
  "/home/domin144/.conan2/p/b/openi2b837708c2554/b/src/src/include/$<$<CONFIG:Release>:/home/domin144/.conan2/p/b/fmt8d14cec70a06c/p/include>/fmt/core.h":
  No such file or directory.

Not really proud of the changes, but it should work now.

Sorry for the delay, I've been travelling (still am, but had a little time today to catch up here).
Conceptually, it's fine with me to get rid of Findfmt.cmake since our minimum fmt no longer requires it, and then cleaning up what remains.
Looks like the changes as they stand are failing most of the CI tests, though.
CMake Error at src/cmake/externalpackages.cmake:354 (add_library):
  add_library called with IMPORTED argument but no library type.

I'll merge once that gets cleaned up.

Another attempt. If this does not work, I will have to get back to this next week.

It took some tries, but it finally passes.


Separate thread pools for different kinds of zio tasks

The proposal:

Introduce new method, IO.blocking(a: => A): IO[Nothing, A], equivalent so sync
All the blocking computations  should be scheduled to a separate thread pool with high upper boundary and short queue
As well we may support scala's blocking and schedule such tasks to that thread pool (proposed by @kaishh in several discussions)
We may create one more thread pool inteded to serve all the internal waits. This pool should have low upper boundary and relatively long queue
Primary ZIO thread pool upper boundary should be intended for computations only and limited to core_number + 1 threads. Queue size should be set to zero.

You may find the detailed motivation here: https://github.com/scalaz/scalaz-zio/pull/295#issuecomment-428927804
Related problem (ZIO computations should be terminated when thread pool rejects a task):  https://github.com/scalaz/scalaz-zio/issues/277#issuecomment-427916988

Introduce new method, IO.blocking(a: => A): IO[Nothing, A], equivalent so sync
All the blocking computations should be scheduled to a separate thread pool with high upper boundary and short queue

So ZIO will maintain multiple pools as part of its RTS or will there be a single pool per RTS? Will this discourage users from creating their own pools?

Primary ZIO thread pool upper boundary should be intended for computations only and limited to core_number + 1 threads.

If your processor supports hyperthreading on its cores, core_number * 2 would yield a higher throughput. Do we want to take advantage of this by default, or would users be encouraged to optimize their own pool for such things?

Queue size should be set to zero.

If all threads are busy in a fixed pool with a SynchronousQueue, submission of another task will fail or block at best (dictated by a rejection handler). I imagine we wouldn't want to discard tasks, and if we block, there is a potential of a deadlock (a thread on the pool attempts to submit another task but it is blocked because all other threads are busy). I think an unbounded queue is necessary when using fixed pools where threads can submit tasks back to their own pool.

So ZIO will maintain multiple pools as part of its RTS or will there be a single pool per RTS?

Two pools (plus timers pool)

Will this discourage users from creating their own pools?

Yes

I imagine we wouldn't want to discard tasks, and if we block, there is a potential of a deadlock

If we hit the limit of blocking pool (and get rejection exception), computation should be Terminated I think. It's better to set the limit instead of spawning thousands of threads effectively killing the OS scheduler (IMO). The limit itself is still discussable though I think that quadratic/qubic one is fine enough.

If your processor supports hyperthreading on its cores, core_number * 2 would yield a higher throughput.

When I said "core number" I meant "hardware threads number".

If we hit the limit of blocking pool (and get rejection exception), computation should be Terminated I think.

I was talking about the primary ZIO fixed pool for computation you mentioned in the OP. If you have 8 threads running fibers in a fixed pool of size 8 and one of them submits a task to a saturated queue, should the entire computation fail? Adding to work queue only spawns new threads if the current number of live threads is fewer than maximum and the work queue is full.

I've updated my comment.
I think you may make both the upper boundaries configurable. Primary pool should have cores+1 by default, and blocking pool should have pow(cores, 2) by default.
RTS.maximumBlockingOps : Option[Int] = Some(cores * cores)
RTS.maximumCPUOps : Option[Int] = Some(cores + 1)

UPD: I've misread your comment a bit. So, regarding the primary pool. The configuration (cores+1) already assumes that the pool takes the maximum computational throughput. So in case we got a rejection - most likely the queue would continue growing and at the end the app will die or computations will terminate. So, there is no real need (IMO) to set non-zero queue for computational pool. In case it's being overscheduled - in almost all the cases nothing may save us (this is not true only for apps with specific load profile, which are idle almost all the time but have peaks of high CPU intensity)

The purpose of a fixed pool is to prevent CPU overscheduling while still being productive. Those threads in the pool will pull and execute tasks to completion. If you submit a task and all threads are currently busy, the task is queued in memory. Whenever a thread finishes its task, it will begin processing the next one. This offers a means of graceful degradation: latency for a task may increase slightly, but it will eventually be processed. If the pool has to queue a task, chances are the task must only wait <1 ms before being picked up.
However, it is conceivable that at some point the work queue will become so large that latencies become exceptionally high and it may be a good idea to fail. If an unbounded queue isn't used, then a pool with a high upper boundary should be used (depends on hardware of course).
The queue size is also dependent on your workloads and SLAs. Workloads can change over time: for a web server, sometimes it may experience high traffic and sometimes it may experience low traffic. If all the threads in a web server's pool are busy and a new request comes in, should that request really be failed? It depends, but if another thread finishes soon after, it can pick the new one up (ties back to graceful degradation).

This offers a means of graceful degradation: latency for a task may increase slightly, but it will eventually be processed.

Depends on load profile. In case you produce more than you can consume - the app/machine will die anyway.

If the pool has to queue a task, chances are the task must only wait <1 ms before being picked up.

You may set a short queue but it wouldn't change anything, really. In case you are producing faster than consuming - you have a problem. And your effective consumption speed is limited by number of cores. Plus one thread to fill the scheduling gaps.

If an unbounded queue isn't used,

Unbounded queue is the worst thing I can imagine, honestly. It's a way to complete degradation of the app/machine KPIs/OOMs/etc.

The queue size is also dependent on your workloads and SLAs.

True. I've proposed "sane defaults" (based on my own experience) but my point was and is: we should allow the user to configure these things.

Workloads can change over time: for a web server, sometimes it may experience high traffic and sometimes it may experience low traffic.

True. Actually, if you use the defaults I've proposed - it's very unlikely you may get rejections. Again - you can't consume cpu-bound tasks faster than it can be done by cores+1 threads. And in case your tasks are being scheduled faster - you are in trouble. Short queue may work well for some load profiles - but wouldn't change much in general. Though I'm not agains short queue. I'm against unbounded pool sizes and queues.

the threads in a web server's pool are busy and a new request comes in, should that request really be failed?

Don't forget about NIO queue.

should that request really be failed?

Better fail than freeze :)

It depends, but if another thread finishes soon after, it can pick the new one up (ties back to graceful degradation).

cores + 1 should be already at max CPU throughput.

It's totally reasonable to have separate threadpools for IO vs CPU bound tasks. The question is -- do we want to introduce one more thread pool for blocking stuff into any RTS or maybe we would like to have separate RTSs for different types of workload and allow users to explicitly shift onto RTS of his choosing if needed? IIRC the latter was considered here https://github.com/scalaz/scalaz-zio/issues/36
I'm also all for back-pressure, but just putting bounds on those pesky queues doesn't seem enough. There should be a way for a user to specify exactly how they want to handle task rejections. Java ExecutorServices provide RejectedExecutionHandlers, but do we have a ZIO-style abstraction for this?

Java ExecutorServices provide RejectedExecutionHandlers, but do we have a ZIO-style abstraction for this?

We do. Terminated :)

The question is -- do we want to introduce one more thread pool

I guess it a question for @jdegoes . I would vote for just one RTS.

We do. Terminated :)
@pshirshov not sure I follow. Terminated is an exit status that signals either interruption or unhandled exception during execution. Do you suggest using it for flow control as well?

I like the idea of having multiple RTS that each capture an evaluation mechanism. It would be useful for the SyncIO data type (or other interesting subsets like ParIO 😋): we could enforce a composed RTS to have the ability (or lack thereof) to evaluate IO actions that may contain SyncIOs. The JS RTS would not have that ability and so trying to run a SyncIO in JS would fail at compile-time.

I thought that having RTS contain every type of pool seemed a bit at odds with the goal of having multiple composable RTS. If every RTS has a dedicated pool, should each also have a dedicated timer pool (what it looks like right now), or should a separate type be developed for that?


Unable to authenticate with OpenStack Newton project

I have provided my auth_url, username and key for Newton OpenStack and I am getting 400 bad request. I have provided the following as my auth url http://<IP_ADDRESS>:5000/v3/tokens somehow it is saying unexpected token auth in the url in OpenStack log file.  Could anyone help me out on this.

As you can see from the documentation:
 :openstack_auth_url => 'http://YOUROPENSTACK-CLOUD:5000/v2.0/tokens',

Right now this is only tested against v2 of the API. There is a strong possiblity something has changed. If you are willing to debug and make the changes I'd love to see the PR.

No movement, if you'd like to help I'd love to see PR, but I'm closing this due to no support.


Please add a LICENSE

and thanks!

There already is a license. Please see https://github.com/webpack/tapable/blob/master/package.json#L6

Ideally there would be a LICENSE file, so that https://developer.github.com/v3/licenses/ worked. Automated processes to comply with your license requirements depends on Github's API being able to find and return license information. The way the license is currently mentioned breaks Github's License API.

@naterkane It is not enough for MIT license to refer to it just by its name. See the #70 description.


update the game over message

update the game over message so people know how to play again!

looks fantastic


Update oauth.adoc

[FINERACT-1145: Instructions in connecting Mifos to an identity server(Keycloak). For Fineract backend to be able to recognize the token passed to it.

@oyinig Please follow the required PR and commit message pattern:
FINERACT-XXXX: Short description
FINERACT-XXXX: is the story id which this PR is relates to.

The pull request comment has been adjusted as requested


Vis-UI: Allow for custom skin files with x2 skin scale

Currently the VisUI class only allows for loading of a high-DPI skin via a preconfigured SkinScale enum which loads the default skin. It would be useful to be able to specify our own skin files along with an "x2" scale value.
This could be fixed by either adding a function to set a size name for the currently loaded skin, or by making the SkinScale constructor public so that we can create a SkinScale instance with a custom skin path and size name.
Let me know if I'm missing something and this can be configured from within the Skin JSON.

My mistake on this issue - I thought that VisUI would render differently with a SkinScale value set to x2, but it seems when LibGDX is properly set to use HDPI mode, it works correctly even with a custom skin.


Draining the pool after releasing connections may cause write to destroyed stream

Using
pool.release();
pool.drain();

May (not necessarily) result in the error below
Connection lost - Cannot call write after a stream was destroyed
The pool.release methods calls the connection.reset method. This methods executes SQL queries to reset to the initial state of the connection. pool.release does not use promises, so pool.drain in the above example is immediately called afterwards. pool.drain closes the connections. If one of these connections still have a request connection pending (or any other request!) it results in the above mentioned error.
I will provide a PR containing a fix soon.

Pull Request: https://github.com/tediousjs/tedious-connection-pool/pull/59

Is there any update on this?

@nul The PR was an example fix for this problem, it's up to the maintainer of this repo if our example should be used to fix this. (But the example I provided does work, so I suggest to fork this repo and apply the fix yourself using the PR since this repository is not actively maintained anymore)


🌱 Implement advanced linting

What this PR does / why we need it:
Right now, we're running just a few of the linters available by default in golangci. This PR enables additional linters that will improve the quality of the code.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@Fedosin Sorry for the delay, I was out on PTO. Thanks for updating, it looks good except for a couple tiny points.

@Jont828 I was on PTO too 😄

@Fedosin Sounds good, please squash your commits I think we should be good to merge!

Great work!
/lgtm
/approve


Fix "Cannot use EventToCommandBehavior for Page.Appearing event"

Description of Change
Allow using behaviors with VisualElements (Pages)
Bugs Fixed

Fixes #583

API Changes
None
Behavioral Changes
None
PR Checklist

[X] Has tests (if omitted, state reason in description)
[ ] Has samples (if omitted, state reason in description)
[X] Rebased on top of main at time of PR
[X] Changes adhere to coding standard
[ ] Updated documentation

A new build for this PR has been completed. As a result a NuGet has been created which allows you to verify this fix or try out the new feature! Download here

LGTM!

Thanks :)


Create Export packages for OpenGeoMetadata

[ ] Create documentation on how the JSONs should be organized
[ ] Test current export crosswalk to ensure all of the fields are present
[ ]

Here is my initial thoughts on how an export of JSONs could be accessed and organized:

User selects a group of items as usual
User chooses Export - any of the JSON options
The resulting file is a ZIP with items structured in this kind of directory:

Provider

Resource Class (first value only)

full-id.json

How should we differentiate JSON formats here?
Does this suffice?

full-id.gblv1.json
full-id.aardvark.json

New structure:

Resource Class

Code

id.json

Released in v0.9.0


Update sealed-enum to 0.5.0

Codecov Report

Merging #455 (c27063e) into main (dff9ac1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   75.42%   75.42%
=======================================
  Files          83       83
  Lines        4338     4338
  Branches      954      954
=======================================
  Hits         3272     3272
  Misses        391      391
  Partials      675      675

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


enumerate user flows

we need to enumerate a comprehensive set of user flows to ensure all use cases are covered before cutting a prax release. Our current checklist is insufficient and lacks comprehensive testing coverage.
cc @grod220

Link to current deployment checks to update


⚠ Samsung has degraded performance

In 5ec0c4f, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2824 ms

Resolved: Samsung performance has improved in 15ab694.


Configurable ways of matching

Hi,
see at the match_subsequence branch. You can select the old way of matching (match head), the new way (treat pattern as subsequence) and append another type of match. What do you think about merging it into master?
setMatchType() is still left as public because I tried to use it by rpcrequest(), but I have not tested it against pcntl_fork().

Would you like to use the YouCompleteMe plugin? With YouCompleteMe, the completion will be automatically tiggered after you enter ::, ->, and PHPCD will return all items. And then, YouCompleteMe will filter these items by the pattern we typed. And the matching is very smart.

I still use YCM but it is huge, depends on many other packages and require building binaries. I consider to replace it with any smaller tool.
YCM's filter mechanism does not conflict with the proposed patch. You can still for example get full list of methods from PHPCD (after "semantic triggering" by ->) and use YCM's mechanism to filter this list without calling additional requests to completion daemon (the log file is useful to check it). But this completion does not work if I try to start completion when some part of string already exists (YCM has  to trigger by this way).
With  or without YCM I have only "head matching".
Another argument: filtered list is smaller :)

Merged :)

Merged :)


Add fisher_diag option, as well as option to make state.hessian a sparse COO matrix

Allows the libsvmdata finance dataset to run without memory issues. However, the sandwich product is still very slow, so we are looking into other methods (e.g. less precise Hessian calculation, first-order instead of second-order).

fisher_diag=True means that the entire Hessian is never stored at one time; instead, we calculate the Hessian rows "on demand," using each row before overwriting it. This leads to more operations being done, but it saves on memory.

This PR has been split into two: one focused on the use_sparse_hessian feature, and another focused on the diag_fisher feature.


articles to add in design

http://www.creativebloq.com/illustration/how-draw-basic-shapes-31619534

http://www.omnicoreagency.com/essential-social-media-design-sizing-cheat-sheet/


Uppercase letters

Hi,
I like your tool and it works fine so far. But it seems that it is not able to detect removed functions written in uppercase letters (I don't know why someone would do this, but the developer did this in the project I have to upgrade).
For example: mysql_connect() is recognized, MYSQL_CONNECT() is not.
Is there any workaround I could try? Thanks for any suggestions.

Thank you for your report, @natertec. The master branch was updated to detect removed function names in any case.


update to version 0.0.17

@shri3k thank you for the quick merge! Please consider new release to version 0.0.17 so npm/yarn installs are updated too

Okay, it should be up.


delete some obsolete legacy code

Coverage remained the same at 0.0% when pulling b1c4d44dc2e767eb5c3eb474c98a2279eac2977c on theseyi:delete-dead-legacy into be383ab0e2d32564963727e75515d46f05940817 on linkedin:linkedin.


[Suggestion] Remove `example_SPE.R

If you need an example Visium data with only one sample, you can simply use STexampleData via spe <- Visium_humanDLPFC().
You can put STexampleData as Suggests in your DESCRIPTION file.
The reasons are

Loading all DLPFC samples using spatialLIBD could take a lot of memory space and time
You package will depend on spatialLIBD which will depends on all packages that spatialLIBD depends on which is a lot, and you won't need them.

Done


Emmanuel

Added some English words.
These are based on monitoring my client's app.

Thanks for your contribution, Emmanuel, and welcome to GitHub! This project will be a valuable addition to your resume :)

You're welcome. And thank you for the warm welcome.


Fix for clearing enteprise flag bit

Fix too incorrect clearing of enterprise flag.

Nice, thanks! I added more comments and parentheses for better understanding of the operation.
The usage of enterprise fields might need some better unit tests..


bug: updating journal !!

http://ege-tarimsal-arastirma-enstitusu.beta.dergipark.gov.tr/admin/journal/120/update

probably this issue fixed can you re-test and if there is an bug dump the scenario below. ping @beyzakokcan

i am closing this issue according to my tests. if error resumes anyone can re-open.


Airbnb API key

Hi,
Is there any way I can get an API key from Airbnb? The website says they are not accepting any requests at the moment. :(
Thanks.
Josh

The example.config has a small guide on how to find the API key:
API Key
To collect an API key using Chrome as your browser:
- In your browser, go to the Airbnb web site
- From the menu button at the top right, open More Tools >  Developer Tools
- Click the Network tab
- In the Developer Tools, click the stop sign to clear the list of requests
- Click XHR (this is the kind of event we want)
- Move the map to generate a new search
- Find a request with explore_tabs in the name, right click it to show
the URL in a new pane.
- Find the key= part of the URL and add it here
Haven't had a chance to test if the key works, but the url does contain a key

The example.config has a small guide on how to find the API key:
API Key
To collect an API key using Chrome as your browser:

In your browser, go to the Airbnb web site
From the menu button at the top right, open More Tools >  Developer Tools
Click the Network tab
In the Developer Tools, click the stop sign to clear the list of requests
Click XHR (this is the kind of event we want)
Move the map to generate a new search
Find a request with explore_tabs in the name, right click it to show
the URL in a new pane.
Find the key= part of the URL and add it here

Haven't had a chance to test if the key works, but the url does contain a key

Thanks man!

Thanks @ARiisgaard .

Hello
You should create developer account
Then you can get API secret key


Pass backend - store key silently fails

env
Linux 4.15.0-96-generic
go1.14
Ubuntu 18.04.4 LTS
pass v1.7.1
issue
Hi, it seems when using colon in ServiceName name like abcd:abcd, the keys is not saved in the backend.
package main

import (
  "fmt"
  "github.com/99designs/keyring"
)

func Store(sname string) {
  ring, _ := keyring.Open(keyring.Config{
    ServiceName: sname,
  })
  fmt.Println(ring)
  _ = ring.Set(keyring.Item{
  Key: "foo",
	Data: []byte("secret-bar"),
  })
}

func GetKey(sname string) {
  ring, _ := keyring.Open(keyring.Config{
    ServiceName: sname,
  })
  i, _ := ring.Get("foo")
  k, _ := ring.Keys()
  fmt.Printf("%s", i.Data)
  fmt.Println(k)
}

func main() {
  name := "abcd"
  Store(name)
  GetKey(name)

}

go run test.go
&{abcd 0xc000182040 0xc000202f40 0xc000202000}
secret-bar[foo]

ServiceName changed to abcd:abcd
go run test.go
&{abcd:abcd 0xc000182040 <nil> 0xc000182980}
[]

Thiis pattern is used in a friend's app and works under MacOS

pebcak issue, nothing was stored anyway
I assumed the pass store was used, it wasn't, no idea which one was [secret-service kwallet pass file]
Now after a proper pass init and explicit use of it, it works
  ring, _ := keyring.Open(keyring.Config{
    ServiceName: sname,
    AllowedBackends: []keyring.BackendType{"pass"},
  })


Proposal: Use PlatformIO Python in colcon build

Regarding the execution of 'colcon build' within library_builder.py:
In my local environment, the 'cmake' command within 'colcon build' in library_builder.py seems to find and use the system's Python instead of the Python version bundled with PlatformIO. Consequently, if I use a virtual environment like pyenv, 'colcon build' fails.
I can make PlatformIO use its bundled Python version by setting the -DPython3_EXECUTABLE option in --cmake-args.
This appears to be the desired behavior, for the following reasons:

extra_script.py installs required packages such as 'colcon' into PlatformIO's environment.
The PlatformIO environment is activated prior to executing the 'colcon build' command.

In fact, setting this option allows all builds to be completed using PlatformIO's Python version, which works well in a pyenv environment.
However, I believe that executing the build on a system with ROS already installed is also a correct approach.
While I'm not fully versed in this library to make a definitive call, I thought it pertinent to raise this issue and have therefore submitted this PR.

Would be great if this was merged as the computer I am building the micro-ros part is not the one running ros2


[Test-Proxy] Enhance Default Sanitizers

We need add the following BodyKeySanitizers to defaults

$..access_token
$..refresh_token

In the actual request body it could be a JSON OR it could be www-url-encoded. Like here
.NET containerregistry
We have to sanitize both.

This is done.


Click on line number or filename to go to the file

This PR lets the user click on filenames (in the header of that file's patch) and on line numbers (only line numbers in the new file) to open that file (on that line), which works well for git diffs.

Thank you @caponetto , good comments as usual; this time I may not get back to this until the weekend so please don't hold your breath. 8-)

Take your time, @jacekkopecky! I really appreciate your help. :)

Hi @jacekkopecky,
I'm planning to do a refactoring on the entire repo. There are some things to fix, update and improve.
This will likely conflict with the work you've been doing on this PR.
So should I wait for you to conclude this PR or can I move forward?
I can even include the code that you are proposing on this PR as part of this refactoring.

Please don't wait @caponetto , I won't mind doing it again, it's good exercise. 8-) I'm busy vacationing now anyway. Please @ me when done.

Great! Enjoy your time off @jacekkopecky :)

Hey @jacekkopecky, I just merged https://github.com/caponetto/vscode-diff-viewer/pull/48. As you can see in the description, it includes a few improvements. :)
I also took the opportunity to implement the "Click on line number or filename to go to the file" feature because it is a nice use case for the new message exchange mechanism. I used most of the code from this PR (thanks for that). So I'm closing this PR.
If you find any issues, please let me know.
BTW, please open a Discussion regarding the "save viewed state in the diff file" feature and explain your ideas before starting to work on it. :)

Thanks @caponetto, that's great! I've opened the discussion item: #50


Android Basics: change-app-icon

https://developer.android.com/codelabs/basic-android-kotlin-training-change-app-icon?return=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-2-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-change-app-icon#2
In Unit 2: Layouts, Step 7: Change the app icon, there is a spelling mistake in the last Note: "closet", which should be "closest"
Otherwise this is great work!

Thank you so much for reporting this issue. This is fixed and will be published soon.


Update link to eCompass calibration note

Fixes #240

r? @ryankurte
(rust_highfive has picked a reviewer for you, use r? to override)


Class names & parameters not being rendered after updating to 0.23.0

Describe the bug
I have a project that has been using mkdocsstrings for a while, but the recent update to v0.23.0 caused aspects of the API definition to not appear:

Class names are missing
Method docstrings include the parameter text instead of being shown in a table

To Reproduce
Steps to reproduce the behavior:

Clone this repository
Create a virtualenv and install all of the requirements*.txt files
Run mkdocs build --strict
Open site/api/index.html in a browser.

Expected behavior

Class names should appear before the "Bases" are listed
Parameters should appear in a table after the docstring summary section.

References

CI pipeline that produces expected output using griffe-0.36.0 mkdocstrings-0.22.0 mkdocstrings-python-1.6.0
CI pipeline that produces incorrect output using griffe-0.36.0 mkdocstrings-0.23.0 mkdocstrings-python-1.6.0

Information (please complete the following information):

OS: Linux
Browser: chrome, firefox
mkdocstrings version: 0.23.0

Hi @plannigan, thanks for the great report, will investigate now.

OK, that's probably because you are still using the selection and rendering keys, instead of the options one. They have been deprecated for more than a year now. The release notes and changelog mention the removal: https://github.com/mkdocstrings/mkdocstrings/releases/tag/0.23.0.

This simple patch will do the trick:
diff --git a/mkdocs.yml b/mkdocs.yml
index 6a9b6c7..23ebcb3 100644
--- a/mkdocs.yml
+++ b/mkdocs.yml
@@ -36,9 +36,8 @@ plugins:
   - mkdocstrings:
       handlers:
         python:
-          selection:
+          options:
             docstring_style: "sphinx"
-          rendering:
             heading_level: 3
             show_root_heading: True
             show_source: False

Thanks for looking into this. I guess since mkdocstrings has been a thing that "just works" for a while, I didn't read the changelog close enough.


Error: no matching manifest for linux/arm64/v8 in the manifest list entries

[Info]              Starting build for helium-controllino2, user gh_pixelcatcher
[Info]              Dashboard link: https://dashboard.balena-cloud.com/apps/2013860/devices
[Info]              Building on arm01
[Info]              No suitable previous release for caching, skipping cache pull
[Info]              Uploading images
[Success]           Successfully uploaded images
[Error]             Some services failed to build:
[Error]               Service: diagnostics
[Error]                 Error: no matching manifest for linux/arm64/v8 in the manifest list entries
[Info]              Built on arm01
[Error]             Not deploying release.

How are you pushing to the fleet?

Reopening as pyhelper is failing currently

Closed by https://github.com/NebraLtd/helium-miner-software/pull/616

Seems to be working https://github.com/NebraLtd/helium-rak/issues/19#issuecomment-1418259072

If you are finding our open source software useful than please consider sponsoring our efforts at https://github.com/sponsors/NebraLtd
And please share to others as well 🙂
We have lots of cool features coming up!


2.28.0 performance related issues

What happened:
Hello! After the 2.28.0 release the napari project is having some dask performance related issues, including timeout fails of some of tests that now take significantly longer. Changing the dask config did not recover the old behavior as I would have expected based on the docs.
A more detailed investigation can be found in the napari issue tracker here https://github.com/napari/napari/issues/1656 but I will reproduce a minimal example below.
What you expected to happen:
I didn't expect such large slow downs with the new release.
Minimal Complete Verifiable Example:
import dask.array as da
import numpy as np
import time

data = da.random.random(
    size=(100_000, 1000, 1000), chunks=(1, 1000, 1000)
)

idxs = [(0,), (50_000,), (99_999,)]

t0 = time.time()
reduced_data = np.min([np.min(data[idx]) for idx in idxs])
t1 = time.time()
print(t1 - t0)

On 2.27.0 this takes about 0.13 seconds to run, on 2.28.0 this takes 4.3 seconds to run.
Anything else we need to know?:
Looking at the 2.28.0 release notes I saw #6665 and think this maybe related to that. I noticed the note on efficiency which suggested there may now be some additional overhead, but I didn't expect the slow down to be so large (note while the above is just a toy example, the slowdown is quite noticeable for real-world examples too).
I tried using
with dask.config.set({"array.slicing.split-large-chunks": False}):
    data = da.random.random(
        size=(100_000, 1000, 1000), chunks=(1, 1000, 1000)
    )

    idxs = [(0,), (50_000,), (99_999,)]

    t0 = time.time()
    reduced_data = np.min([np.min(data[idx]) for idx in idxs])
    t1 = time.time()
    print(t1 - t0)

but I saw no difference between having the setting True or False in both this toy example, or in the real config inside napari if I added it to napari here. If I could get the config working as expected then I can just change the default value and we would be fine.
Environment:

Dask version: 2.28.0
Python version: 3.7
Operating System: MacOS
Install method (conda, pip, source): pip

Sorry about the slowdown, and thanks for opening an issue.
My hope is that #6665 isn't to blame here. It should only apply at graph construction time, but it seems like the slowdown is in compute.
# Dask 2.27.0
In [4]: %timeit data[(0,)]
239 µs ± 24.3 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

# Dask master
In [7]: %timeit data[(0,)]
251 µs ± 37.4 µs per loop (mean ± std. dev. of 7 runs, 1000 loops each)

# Dask 2.27.0
In [3]: %timeit a.compute()
34.3 ms ± 16.8 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

# Dask master
In [3]: %timeit a.compute()
669 ms ± 113 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

Right now my guess is that our new graph culling is to blame, but I'll bisect that now.

Seems that f0b2ac29d (https://github.com/dask/dask/pull/6510) is the culprit.
# b72593b62
In [3]: %timeit a.compute()
21.6 ms ± 2.55 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

# f0b2ac29d
In [3]: %timeit a.compute()
495 ms ± 35.4 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

@madsbk are you able to take a look? The full reproducer is
import dask.array as da
import numpy as np
import time

data = da.random.random(
    size=(100_000, 1000, 1000), chunks=(1, 1000, 1000)
)

a = data[(0,)].min()
a.compute()

Thanks for looking in @TomAugspurger and identifying the commit!! It's much appreciated.

@madsbk in case it helps narrow things down further, I notice that the slowdown is just in the optimization stage.
# b72593b62
In [10]: %timeit _ = dask.optimize(a)
5.14 ms ± 254 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

# dask master
In [15]: %timeit _ = dask.optimize(a)
370 ms ± 6.31 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)

snakeviz suggests that we're spending a bunch of time (roughly 2/3rds) in dask.core.keys_in_tasks.

snakeviz suggests that we're spending a bunch of time (roughly 2/3rds) in dask.core.keys_in_tasks.

Yes, did a quick profile and in master we are calling keys_in_tasks() 100012 times whereas 2.27.0 only calls in 14 times!

I think I understand the issue.  In Layer.cull() we find the dependencies of all keys even though cull() might only traverse a few keys.
We need to make HLG support a get-dependencies-of-a-single-key. I am happy to implement this but I am out-of-office must of tomorrow so it will have to wait till Monday :/

Thanks for looking!
I believe that we're scheduled to have a release tomorrow. If we want to "fix" this regression for that release we could consider reverting https://github.com/dask/dask/pull/6510 for that release, and restoring it shortly after. It reverts cleanly, I haven't run the tests so I'm not sure what else that would necessitate reverting (maybe 782733024, and it would block work by others like Rick's ShuffleStage PR).
cc @jrbourbeau as well, if you have a preference for how to proceed.

I haven't run the tests so I'm not sure what else that would necessitate reverting (maybe 7827330, and it would block work by others like Rick's ShuffleStage PR).

Reverting is fine with me, it shouldn't effect https://github.com/dask/dask/commit/782733024e808bebfeae69cce494b1499d83bc2c but yes it will block Rick's ShuffleStage and my follow up HLG work: #6689 and #6693.

cc @rjzamora (for vis)

After looking at this briefly I think that @madsbk fix will be fine, however I think it makes more sense logistically to revert in this case, release, let things settle over the weekend, and then go on a merging spree (there is a lot of interesting work in both dask/dask and dask/distributed).
@jrbourbeau are you still planning to handle the release today?  If not I'm happy to do it.

I've just tested #6699 and confirmed it fixes the performance regression for me. I also asked a question about adding timing based tests that might actually be better for this thread rather than the PR. In napari we use the pytest.mark.timeout(n) decorator in a few places to catch major performance regressions - see this test for example, which was very helpful for us identifying this performance regression - we saw it on our CI right away on the 2.28.0 release, and I'm wondering if some/ more rough tests like that might be helpful for dask too?


Support writing weights of type bool

This makes the converter able to dump weights of dtype bool

This change is

Is this in response to issue #550 ?


Add species attributes to CSV (candy, optimal number to transfer, optimal number to catch)

I plan on synchronizing CSV values with selected table stats. This is dependent on #86


New lints: Safe items inside unsafe extern

A new feature in Rust 1.82+ is the ability to define safe items inside an unsafe extern block:
https://blog.rust-lang.org/2024/10/17/Rust-1.82.0.html#safe-items-with-unsafe-extern
unsafe extern {
    pub safe static TAU: f64;
    pub safe fn sqrt(x: f64) -> f64;
    pub unsafe fn strlen(p: *const u8) -> usize;
}

Making a previously-safe item become unsafe is a major breaking change, since it now requires unsafe at the point of use.
At least two lints, and possibly more:

[ ] safe extern static became unsafe
[x] safe extern fn became unsafe

I believe we'll also need additional schema in the adapter to model extern items and show which items are safe vs unsafe. This shouldn't be too difficult to add, though it's an extra step compared to "just writing a lint." For folks new to contributing to Trustfall, I'd recommend first writing another lint that doesn't need this extra step before moving to this issue.

rustdoc-json doesn't model functions declared in extern blocks differently to normal functions: https://github.com/rust-lang/rust/pull/131517. If you handle functions changing safety, then you handle extern functions as-well.

rustdoc-json doesn't model functions declared in extern blocks differently to normal functions: rust-lang/rust#131517. If you handle functions changing safety, then you handle extern functions as-well.

Neat, TIL -- thank you!
We might still want a separate lint for the two cases so we can offer a more specific diagnostic message in each case. I'll make a test crate and see what happens currently, and go from there.

Relatedly, you probably want a lint for changing pub static X: i32 = 0; to pub static mut X: i32 = 0, as the latter is unsafe to access.

Nice catch! I think it might already be on a to-do list somewhere, but I'll make sure of it :)

I decided the current lint for safe -> unsafe fn is fine here, and just added test cases here and in the adapter:
https://github.com/obi1kenobi/cargo-semver-checks/pull/1003
https://github.com/obi1kenobi/trustfall-rustdoc-adapter/pull/611
Leaving this issue open until we can lint for safe -> unsafe transitions in extern static.
Thanks again @aDotInTheVoid!

For the extern static case, you'll need the (not yet merged) https://github.com/rust-lang/rust/pull/133715 for rustdoc-json to have safety information for statics.
Also worth noting: static's are safe by default, so going from static X: i32 to extern { static X: i32 } is much more likely than unsafe extern { safe static X: i32 } to unsafe extern { unsafe static X: i32 }

Awesome, thanks for putting the PR together! I'll hold the next cargo-semver-checks release until that's merged and available in rustdoc-types so the new release can support the new format.

Also worth noting: static's are safe by default, so going from static X: i32 to extern { static X: i32 } is much more likely than unsafe extern { safe static X: i32 } to unsafe extern { unsafe static X: i32 }

Oh good call! We definitely want to lint for that.


Add support for Kafka datasources

Description
Add highlighting for KAFKA_ options on datasource files.
Current behaviour:

Technical details
I've splitted oneliner_meta element into oneliner_meta, oneliner_meta_engine and oneliner_meta_kafka for better maintainability.
It's just a suggestion, feel free to modify it to you liking 😀

Thank you for the regex refactor Alejandro!
Feel free to suggest anything you miss from the highlighter in the future.


Added cast_template to allow non-explicit cast in custom fields.

While working on https://github.com/laymonage/django-jsonfield-backport/pull/2, I noticed that I'm unable to define custom templates for casting custom model fields. This fixes it by adding another mapping like cast_data_types, but for templates. I think this also looks better as this gives better separation between Cast and model fields.

I am not sure about adding a new ops method for a single database function 🤔 we have as_vendor() methods for such purposes.

I am not sure about adding a new ops method for a single database function :thinking:

@felixxm
Well, we already have cast_db_type, so it's not entirely new.

we have as_vendor() methods for such purposes.

I may have missed it, but how do I use it if I want Cast() to work with a custom model field?

I may have missed it, but how do I use it if I want Cast() to work with a custom model field?

You can always create a custom subclass of Cast.

I may have missed it, but how do I use it if I want Cast() to work with a custom model field?

You can always create a custom subclass of Cast.

That's what I thought, but seeing that we already have cast_data_types, I thought this wouldn't hurt.
Well, if you disagree, I'll just do that. Thanks :v:


Custom Table Component

@caitmich thoughts on triaging for now (at least until we hit this in one of our apps)? I'm not exactly clear on how this would work in terms of the actual calculation?

@krsyoung yeah I'm fine with that- this would give a user the ability to create a custom component?

Not sure, @suvasan19 can remind us when his ✈ lands??

Similar to Custom Card Component. Allow users to enter a hash with any keys and numerical values that would be displayed in a table

Thanks @suvasan19. p.s. we miss you!


Update styles.css

Description

closes #1129
Related Issues

Closes #1129

Type of PR

[ ] ()

Screenshots / videos (if applicable)

Checklist

[ ] I have gone through the contributing guide
[ ] I have updated my branch and synced it with project main branch before making this PR
[ ] I have performed a self-review of my code
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[ ] I have commented my code, particularly in hard-to-understand areas.

Additional context:

please merge PR @Anishkagupta04  @varshith257 tommorow is last day to contribute


https://github.com/jenkinsci/okhttp-api-plugin missing permissions

Reproduction steps
as per https://github.com/jenkinsci/okhttp-api-plugin/pull/125 and https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-okhttp-api.yml#L11
I am a member of cloudbees-developers but am missing write access to this repo.
Can the cloudbees-developers group please be added here please.
Expected Results
I can merge PRs to the plugin
Actual Results
I can not merge PRs to the plugin
Anything else?
(similar to https://github.com/jenkins-infra/repository-permissions-updater/issues/2939)

done


Add targeting for SSE4.1

Not sure if this interests you at all (if not, feel free to close this request), but I added support for targeting SSE4.1 in addition to AVX2, so that it can run on more CPUs.
There's no dynamic dispatch - it's a compile time switch only for now, so the build script uses -march=native instead of specifically targeting AVX2.
Currently this will compile to work on CPUs with SSE4.1+POPCNT+PCLMUL minimum. The POPCNT requirement should be easy to remove, and I might include an alternative CRC32 implementation to remove the PCLMUL requirement.
Most of this was a quick find & replace style modification, so hopefully I got everything right.
Feel free to let me know what you think, and thanks for this awesome project!

First of all, thank you for the contribution!
I gave a quick look at the patch and the general direction seems good to me, I'll do a more in-depth review later.
Just a couple of high-level questions:

How did you test the SSE4.1 version? (and that the AVX2 version did not break)
Did you happen to benchmark the SSE4.1 version?
Out of curiosity, since I assume you wrote this patch because you intend to use this code for something -- what would be your intended usecase?

Appreciate the response!
This project doesn't seem to have any test cases that I could find, so I just picked two random images to test with.
Compiled under AVX2, the generated images are bit identical to the original code. Under SSE4.1, they aren't, but converting the outputs to BMP and comparing, they are identical. I'm not sure of the reason the SSE code generates something different - maybe the deflate implementation generates different results if it's being invoked more frequently?
As for performance, SSE4 is undoubtedly going to be slower than AVX2 - this is just done for compatibility reasons. Using the supplied test on the second image above, I get:
i7-12700K AVX2
   244.678 MP/s
    10.787 bits/pixel
i7-12700K SSE4
   171.628 MP/s
    10.770 bits/pixel

Ryzen 3900X (VM) AVX2
   156.358 MP/s
    10.787 bits/pixel
Ryzen 3900X (VM) SSE4
    92.838 MP/s
    10.770 bits/pixel

Atom C2350 SSE4
    10.159 MP/s
    10.770 bits/pixel

Interest in this project came from finding out PNG encoding in Python's PIL library is surprisingly slow.
I was surprised at the lack of a fast PNG encoder despite how old the format is.  It seems that this and fpng are the only PNG implementations with SIMD for encode.
I suppose a curiosity with most encoders may be with PNG's filtering being quite simple, one might expect most of the time would be spent on zlib deflate. However my quick testing seems to indicate otherwise - setting zlib compression to 0 doesn't seem to speed up encode all that much, compared to zlib level ~3, so filtering does seem to play a role.
As for the original PIL implementation of PNG, I'm not sure why their code seems to be slower than libpng, but I'm sure fpnge is much faster regardless.
As for the CLA check, it seems to require a Google account, which I don't have or want to create. My code can be freely used by anyone for any purpose, so if this cannot be accepted, anyone can resubmit under their name if desired.

Having looked at this more, I think the SSE code gives different output due to RLE being invoked more frequently (which also explains the minor compression benefit).
Anyway, looks like I messed up the BSF intrinsic for MSVC. Oh well.
I ended up removing that code in my updated branch as the check doesn't actually require the bitscan. Also worth mentioning that the neighboring run + bytes_per_32 >= 16 check actually doesn't really do anything - for most loop iterations, bytes_per_32 equals 32, so run + 32 >= 16 is always true. When bytes_per_32 is less than 32 (i.e. the last vector of a line), next0run == bytes_per_32 won't ever be true, due to next0run = __builtin_ctzll(0x100000000UL |  being on the 32nd bit. My guess is that 0x100000000UL was meant to be 1 << bytes_per_32.
Not sure if you want to still merge this, or you'd be more interested in the other branch.

All the commits seem quite interesting, although I'd probably rather not merge everything in a single PR...
(Of course all this being conditional on me figuring out the CLA situation)

Update on the CLA situation: I have received an exception to the CLA requirement for this specific PR (I imagine I'll be able to obtain the exception again for future contributions from you as long as you keep being willing to basically release the code in the public domain, but IANAL, and this will probably introduce some amount of per-PR delay).
So we can go forward here :)

Thanks for going to the effort to get an exemption, and apologies for complications caused.
I'm not particularly interested in red tape and such, so if it helps, I'm happy to have all commits to be rewritten to yourself, or you can just copy parts you're interested in from my branch without attribution, or whatever you think will satisfy the CLA.

Thank you for your contribution!

Thanks for reviewing + merging!
I'm not sure if/how you want to proceed with further changes.
I've currently got two branches which currently don't have your requested changes, but I'll merge them in:
https://github.com/veluca93/fpnge/compare/main...animetosho:api
https://github.com/veluca93/fpnge/compare/main...animetosho:optimizations
If you want to merge any of these, I'm fine with whatever approach. If you'd prefer me to create pull requests, let me know how you want to proceed, particularly with the second branch and how you'd like the commits to be split up.

Giving it a quick look, I'd say that ~3 PRs with the


Godot is not responding when it gives error.

Godot version:
3.0.6
OS/device including version:
Windows 8.1
Issue description:
When my server .exe is opened, and when client .exe is giving an error, the client stops responding. When I open two windows together, one of them is the server, and one of them is the client, when I do something wrong with the client, it doesn't print the error. How do I know it gives an error? Because when I do the same thing without opening the server, it prints some error(just coding related error). You will say that shut down the server and try the reproduce the error with the client, but no. When I shut down the server, client disconnects and shuts down too. How can I see the error without opening server? Some .tscn scenes of my game doesn't check if it's disconnected or not. It's complicated, I tried to explain but I may be failed. Sorry about that. Is there any error log file that Godot writes to?
Steps to reproduce:
Code your server and client.
Connect client to server.
Do something wrong with the client.
When it gives error, it will stuck.

@Sphynxinator Can you share an example project to make it easier to reproduce the issue locally? Thanks in advance :slightly_smiling_face:

Can anyone still reproduce this bug in Godot 3.2.3 rc3 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

godot-online.zip
Sorry, I totally forgot about this when I switched to Node.js for the server. I prepared a minimal reproduction project. I added explanation to the project codes, but I want to tell how you can produce the bug.

First, open the both server and client projects.
Run the client alone. Client will give an error about a nonexistent function.
Close the client.
Run the server. If it prints some increasing numbers, and the float that is sent from the client, it works.
Run the client while server is running, client won't give any error.

I don't know if it's an error though.

CC @Faless

Sounds really weird, are you running 2 editor instances? Can be simply
related to the fact that only one editor can debug at each time.
On Sat, Aug 8, 2020, 22:18 Tomek<EMAIL_ADDRESS>wrote:

CC @Faless https://github.com/Faless
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/23099#issuecomment-670969819,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAM4C3QZNDLRIWLJ5KQ2RP3R7WXKPANCNFSM4F454L3A
.

Yep, it only happens with two editor instances.

Yeah, it also gives some debug port error before running the two instances together. Simply switching to another platform for server usage(like I switched to Node.js or Java back then) fixes the problem, but I don't know if an engine user will plan to use the Godot Engine for server too.
Is there any way other than using the two editor instances together if anybody will use Godot Engine for both as a server and as a client?

Is there any way other than using the two editor instances together if anybody will use Godot Engine for both as a server and as a client?

You can run the project without opening editor. Just run Godot inside the project directory (e.g. from command line).

I didn't know Godot also runs without opening the editor. I tried to add the Godot directory to the PATH and changed the name of the exe to "godot" and yeah, it worked.

Automatic port assignment for the debugger was implemented in 3.x via #37067 and 4.0 via #53241


Add search to doc

Description
Probably will come for free with the Jekyll migration

Add #601

Not fixed yet?


Request for training follow

Can I know more details about how you train your model?

what file do you use to train your model? Is it under the guided diffusion folder?
What input do you take for this model? You mentioned that 'we randomly select FBP or RLS reconstructed using θmax ∈ {60◦
, 90◦, 120◦} as the conditional input', what do you mean by 'conditional input' here? Have you used full-view datasets as inputs of this model in training?
What hyperparameter is in your training of diffusion models?

I would appreciate it if you could communicate with me.

Hi @JiamingLiu-Jeremy and @GreameLee ,
do the train code is under fp16_util.MixedPrecisionTrainer ? or do we need to create new code following this repository https://github.com/openai/improved-diffusion/blob/main/improved_diffusion/train_util.py ?
Thanks!

As for the input
According to the paper and some clues scattered in current version of code (listed below), the "conditional input" should simply be the images reconstructed by flitered backprojection or regularized least squares.

clues for the data format (gt, img_reconstructed_by_fbp, img_reconstructed_by_rls):

https://github.com/wustl-cig/DOLCE/blob/8420348409073bf2db4be235a14929478f97859c/guided_diffusion/image_datasets.py#L128-L129

clues for data processing:

https://github.com/wustl-cig/DOLCE/blob/8420348409073bf2db4be235a14929478f97859c/limited_ct_sample.py#L68-L72
https://github.com/wustl-cig/DOLCE/blob/8420348409073bf2db4be235a14929478f97859c/guided_diffusion/gaussian_diffusion.py#L343
https://github.com/wustl-cig/DOLCE/blob/8420348409073bf2db4be235a14929478f97859c/dataFidelities/CTClass.py#L141

As for the training code
The author stated that the training can be run using OpenAI's script.
However, this is largely unfeasible if you couldn't guess the training loop defined by the author well, since the script requires a training_losses method defined within the diffusion model, which is missing in DOLCE/blob/main/guided_diffusion/gaussian_diffusion.py. This might be reproduced, but it would take great pains for the reproducer if he/she does not fully follow the authors' mind and have as much experience on the LEAP packages as the authors (thereby may not be able to reproduce the same results reported in the paper).
This is an interesting work; For both the benefit of the community and the credibility of the paper, we do hope the authors could release the training details soon.

For sampling process, the input is a conditional input based on a back projection method. For training process, most of models such as DPS,  will train an unconditional diffusion model using clear CT images.  But the paper said the training is also conditional , making it confusing.
I try this data consistency in other diffusion but the performance is not good as this model.

For sampling process, the input is a conditional input based on a back projection method. For training process, most of models such as DPS, will train an unconditional diffusion model using clear CT images. But the paper said the training is also conditional , making it confusing. I try this data consistency in other diffusion but the performance is not good as this model.

DOLCE benefits from using pre-trained DPMs that take FBP or RLS as extra inputs during the reverse sampling process.

As for the input
According to the paper and some clues scattered in current version of code (listed below), the "conditional input" should simply be the images reconstructed by flitered backprojection or regularized least squares.

clues for the data format (gt, img_reconstructed_by_fbp, img_reconstructed_by_rls):

https://github.com/wustl-cig/DOLCE/blob/8420348409073bf2db4be235a14929478f97859c/guided_diffusion/image_datasets.py#L128-L129

clues for data processing:

https://github.com/wustl-cig/DOLCE/blob/8420348409073bf2db4be235a14929478f97859c/limited_ct_sample.py#L68-L72
https://github.com/wustl-cig/DOLCE/blob/8420348409073bf2db4be235a14929478f97859c/guided_diffusion/gaussian_diffusion.py#L343
https://github.com/wustl-cig/DOLCE/blob/8420348409073bf2db4be235a14929478f97859c/dataFidelities/CTClass.py#L141

As for the training code
The author stated that the training can be run using OpenAI's script.
However, this can't be smoothly done for now, since the script requires a training_losses method defined within the diffusion model, which is missing in DOLCE/blob/main/guided_diffusion/gaussian_diffusion.py (I guess it is similar to DDPM training, but not sure if there is some customed q-sampling strategies). It might be reproduced, but it would take great pains for the reproducer if he/she does not fully follow the authors' mind and have as much experience on the LEAP packages as the authors (thereby may not be able to reproduce the same results reported in the paper).
This is an interesting work; For both the benefit of the community and the reproducibility of the paper, we do hope the authors could be so kind to release the training details soon.

Hi @Masaaki-75,
We are working on the Leap toolbox to make it easier to run. We have tested different training settings based on OpenAI's improved diffusion and guided diffusion (training losses, mini-batch size, learning rate, etc.), and the performance between each setting is similar. For general conditional training of DPMs, we recommend starting with the original OpenAI settings and fine-tuning the model empirically based on your specific application.


Revert "enhancement PODArray replaces MemPool in PredicateColumn (#17800)"

This reverts commit 17d1c1bc7f6cc95eecd224eaa219c976b60fa17e.
Since it introduces bugs.
Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.29 seconds
stream load tsv:          463 seconds loaded<PHONE_NUMBER>9 Bytes, about 154 MB/s
stream load json:         23 seconds loaded<PHONE_NUMBER> Bytes, about 97 MB/s
stream load orc:          74 seconds loaded<PHONE_NUMBER> Bytes, about 14 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230317110529_clickbench_pr_116014.html


Fennel loader?

Hello,
I would like to write tests in Fennel. My understanding is that this would be possible by implementing a Fennel runner. Looking at the source code it seems like the files under busted/modules/files implement loaders for Lua, Moonscript and Terra. A loader is a table with two functions load and match, but there is no explanation as to what interface these two functions must implement.
I would like to try my hands at writing a Fennel runner. Is there some explanation, or can someone here please elaborate on the protocol that needs to be implemented?

I have made some progress, but it's not yet there.
local path = require 'pl.path'
local ok, fennel = pcall(require, 'fennel')

local ret = {}

local getTrace = function(filename, info)
  -- TODO
  return info
end

local rewriteMessage = function(filename, message)
  -- TODO
  return message
end

ret.match = function(busted, filename)
  return ok and path.extension(filename) == '.fnl'
end

ret.load = function(busted, filename)
  if not ok then
    error 'unable to load Fennel.'
  end

  local err = nil
  local file = function()
    return fennel.dofile(filename, {env = _G})
  end
  -- TODO: Check if filename exists and is readable
  if not file then
    busted.publish({ 'error', 'file' }, { descriptor = 'file', name = filename }, nil, err, {})
  end
  return file, getTrace  -- rewriteMessage
end

return ret

This lets me at least load Fennel tests, but they won't work because the it function cannot be found.
Error → ...phish/Developer/busted/luarocks/share/lua/5.3/fennel.lua @ 3590
suite test/arithmetic_spec.fnl
test/arithmetic_spec.fnl:3:1: Compile error: unknown identifier: it

(it "Adds two numbers"
* Try looking to see if there's a typo.
* Try using the _G table instead, eg. _G.it if you really want a global.
* Try moving this code to somewhere that it is in scope.
* Try binding it as a local in the scope of this code.

What kind of magic is busted using to make it and related function globally available at runtime? I can seen in the Lua loader that it is using loadfile to create a thunk which will load the test code. Fennel does not have its own loadfile, so I wrap dofile inside an anonymous function. Could this be the problem?

OK, I think I got it working using a custom loadfile function for Fennel.
local function loadfile_(fname, ...)
  local file, err = io.open(fname)
  if not (file) then
    return nil, err
  end
  local text = assert(file:read("*a"))
  file:close()
  local lua = fennel.compileString(text)
  return (loadstring or load)(lua)
end

Now that I have a working minimum example I can start making the code good.


Font size of region lines will be smaller.

Now it behaves more or less like I hate regions (except changing settings in the UI.).

To be honest I am not a fan of this change, so I will go with the initial release. I use regions as Method Groupers in my class files, so having regions reducing my font size is really impractical and annoying. Personally I would've made this change a new branch.


SSL peer certificate or SSH remote key was not OK

Problem
I have these dependencies in Cargo.toml:
[dependencies]
futures = "0.3"
reqwest = "0.11"

when running "cargo check" I get this:
error: failed to download from `https://crates.io/api/v1/crates/base64/0.13.0/download`

Caused by:
  [60] SSL peer certificate or SSH remote key was not OK (schannel: SEC_E_UNTRUSTED_ROOT (0x80090325) - The certificate chain was issued by an authority that is not trusted.)

Steps

Create new project
Add futures = "0.3" in [dependencies] section
Run cargo check

Possible Solution(s)
No response
Notes
Some dependencies work and some others don't, for example:
This works when running cargo check
[dependencies]
native-windows-gui = "1.0"

This does not work when running cargo check, (gives SSL error)
[dependencies]
futures = "0.3"

Version
cargo 1.64.0 (387270bc7 2022-09-16)
release: 1.64.0
commit-hash: 387270bc7f446d17869c7f208207c73231d6a252
commit-date: 2022-09-16
host: x86_64-pc-windows-msvc
libgit2: 1.4.2 (sys:0.14.2 vendored)
libcurl: 7.83.1-DEV (sys:0.4.55+curl-7.83.1 vendored ssl:Schannel)
os: Windows 10.0.22621 (Windows 10 Pro for Workstations) [64-bit]

Today I was able to download crates and compile code, I didn't configure/touch anything It worked by itself. weird!
Glad It's working now :)

Today I was able to download crates and compile code, I didn't configure/touch anything It worked by itself. weird! Glad It's working now :)

Glad to hear that!
I am going to close this as it doesn't seem to related to Cargo. If the thing happens again, don't hesitate to post a reproducible example here, and we can reopen it. Thank you!

This is devastating, the problem is back today and I can't compile the project!
cargo check
    Updating crates.io index
error: failed to download from `https://crates.io/api/v1/crates/simplelog/0.12.0/download`

Caused by:
  [60] SSL peer certificate or SSH remote key was not OK (schannel: SEC_E_UNTRUSTED_ROOT (0x80090325) - The certificate chain was issued by an authority that is not trusted.)

When I open that link in the browser https://crates.io/api/v1/crates/simplelog/0.12.0/download it redirects to https://static.crates.io/crates/simplelog/simplelog-0.12.0.crate and downloads the file fine "simplelog-0.12.0.crate" to me this means the problem is in cargo, maybe the curl lib it uses or something!

post a reproducible example here, and we can reopen it.

// main.rs

fn main() {
    println!("Hello, world!");
}

#cargo.toml

[package]
name = "example"
version = "0.1.0"
edition = "2021"

[dependencies]
simplelog = "0.12.0"

@weihanglo

This question on Stack Overflow is the most alike issue I found so far. Basically, it means the remote SSL certificate is not in the CA store. Some browsers have their own CA store so far as I know, so it might work but command line tools don't. Do you have any proxy setup? Or maybe the certificate got some temporary problem and is being fixed right after few minutes.
I still doubt that it's a bug in Cargo or curl, as you said it serf-recovers without any change. Could you try curl or other command line tools to request those failed links?

@weihanglo thank you for reply and that link.
What a random problem, it's working now, I don't have any proxy/vpn, I never had this problem before, last week I upgraded to Windows 11 22h2. maybe it's related to the problem, I might have to downgrade if this persists.


Make the behavior of attemptsMade configurable.

The behavior of attemptsMade is different for bull and bullmq. I'm using the latest versions of bullmq and bull-board, and it shows attempt #2 for the first run.
Source: https://github.com/taskforcesh/bullmq/issues/1002

Weird, I'm using bullmq as well, I haven't saw this behaviour.
Can you make a reproduction repo?

I am actually using the pro version - @taskforcesh/bullmq-pro.

It doesn't matter pro or not, it is in the base...
Let me check this.
For meanwhile can you make sure that for some season your job not runs twice? (Console.log inside a worker will do that)

It's 1 from the very beginning.
My libs:
"bullmq": "3.11.0"
"@taskforcesh/bullmq-pro": "^5.2.2"
"@bull-board/express": "^5.1.1"

I've checked the code, and seems that we've aligned it already in https://github.com/felixmosh/bull-board/issues/386
The UI expects attempsMade to start from 1 (as it is in bullMQ).
So, I'm not sure what is the problem in your case.
If you will be able to share a repo that reproduces this, it will help me to investigate this issue.

I'll try to debug those places tomorrow and let you know.

It is incremented in the getJobs method.

Problem solved: https://github.com/felixmosh/bull-board/issues/322#issuecomment-1524949197
Was using wrong adapter.


Fix default wire mapping and QPU program compilation and add support for parallel execution

This addresses #123 in a 3 ways:

Default wire mapping behavior

By default, we were using [0, n) as the wire numbers for an n-qubit device, but qubits on a real QPU aren't always addressed in this way. Instead, we let pyQuil tell us what the qubits on the device are and build the wire map from that. By default, the user wire labels will map to a device wire label 1-to-1, that way users who want to address them, can do so using the values directly from the our QPU topology metrics and diagrams.

Qubit measurement

Measurements will now use the wire mapping to generate MEASURE statements for every Qubit to readout instead of assuming [0, n). Like (1), this is important for real QPUs, which don't always address qubits sequentially.

Use protoquil for program compilation targeting QPUs

By default a program compiled by quilc will use the full quil spec to generate native quil. However, not everything in the quil spec is supported by our QPUs, so quilc also supports building a program using protoquil, a subset of quil that is compatible with a QPU.
Our QPU devices now set the protoquil flag when compiling to avoid generating a program that might not run on a real QPU.
This also adds support for parallel execution using threadpools to run jobs in parallel. This works for both the QVM and QPU device and can greatly improve execution speed.

Per offline discussion, closing this in favorite of separate PRs for the wire mapping fix and the parallel processing improvement.