Celo Governance Call 19 | July 14th, 2022

Celo Governance Call 19

When: July 14th, 2022. 12 PM ET / 9 AM PT 60 minutes max
Where: meet.google.com/oxy-ujnk-upm (Dial-in: (US) +1<PHONE_NUMBER>; PIN: 114 093 197#)
Agenda
To be added
Please post all relevant proposals below that should be discussed and evaluated

We would like to discuss CGP 58 in Governance Call 19

@sissnad great, just added to the agenda

We would like to add CGP 59 as it is also related to cREAL liquidity

@sissnad sounds good, just added

Dear Celo team,
I mistakenly sent Cusd from private wallet address to Cusd contract address.
Ask the Celo team to help you with the refund of the improperly sent money.
This is my wallet address: 0xa00cdDE1A3bE699D373b9973602B10f649d49E65.
Thanks and Best Regards,
Quoc Khanh

Hi @Khanhle102,
Sorry to hear about this situation - we'd be happy to discuss this question on the call, so I'll add it to the agenda.

Hi @willkraft
My English is not good, if there is any feedback, please notify me.
Thanks !

Hi @Khanhle102, could you join and discuss the issue?

Hi @Khanhle102, could you join and discuss the issue?

I can john, but my english is pretty bad so cannot discuss face to face.
If there feedback on my problem,please comment back.
Thanks

Hi @Khanhle102, got it, that makes sense - it'd be great if you could join, and we'll try to discuss to the extent possible

I am joining just to hear and learn how works the governance calls because i want to make a new proposal to introuce the Colombian Peso Stable Coin cCOP to the Celo reserve.

Hi all, please see notes from yesterday's call here. The recording can be found here.


[WIP] Fix failing to open swagger page

:white_check_mark: Build AElf <IP_ADDRESS>00 completed (commit https://github.com/AElfProject/AElf/commit/43f27fb878 by @jason-hoopox)


High CPU use even when idle

Hi,
I'm trying ferdi, comparing it to other electron app around.
It's a really pleasant product but I noticed some weird CPU use.
More precisely:

linux box with decent cpu (core i7 from 2018)
ferdi configured with only one service (google chat if you wanna know)
using ferdi 5.5.0
no todos
disabled telemetry (to eliminate potential background task)
display in systray
dont quit on close
'close' to reduce in systray
wait a bit

There are constantly 2 processes eating up 2 to 3 % cpu each.
To do ... nothing or barely.
/opt/ferdi/ferdi --type=renderer and /opt/ferdi/ferdi --type=gpu-process
When window is not minimized (but not in foreground either : masked by another window), it eats around 25% cpu constantly
I understand that the underlying service is a pain itself : having google chat own electron app or inside chrome tab is also 'heavy' on resources, but not as much.
A bare electron app dedicated to this service, in hidden mode, would eat 1-2%
I also tried the 'hibernate' feature : it has absolutely no effect.
Even if electron and nodejs are not known not be energy efficient, when compared to something like visual code that does lots of things, it feels like there's room for improvement on ferdi side.
I would be glad to help anyhow,
thanks for reading

Universal Dark Mode (Settings > Appearance > Enable universal Dark Mode) is known to cause this with some services (in conjunction with some Electron versions). See https://github.com/getferdi/ferdi/issues/62 for more details.
Note that hibernation only suspends the services that are not currently selected, even if Ferdi is minimized. So you may try to disable the service manually to make sure it's unloaded even if selected in the sidebar (for testing purposes only, of course, as this would be unworkable for prolonged use).
The upcoming Ferdi 5.6.0 with updated Electron might alleviate some of these issues.

Thx !
indeed : univsersal dark mode seems to be the one to blame.
Now it's "on par" with my other electron app, great news.


Added request logging

Added logging of all requests in the following form $DATE - $METHOD - $URL of level INFO e.g.
2014-09-05 22:36:24 - GET - http://www.reddit.com/

Addresses #17.
Not sure if this is ready to merge.

Thank you, Heinrich!  I do not believe in security by obscurity and thus will consider to include this in Debian.

@leggewie if you include this in Debian, make sure you protect against buffer overflows in really_do_log_time.

I've changed my mind.  Reopening.  (But please fix the issues with your patch.)

Can you elaborate on the buffer overflow issue? I can not see a problem there.

This is awesome, addresses part of my logging desires for .  Two requests:

Can you add in the response code?
(Wishful thinking) Can you add in cache HIT/MISS to the line?

I understand 2 may be additional work and understand if you cannot add it.  I may take up that work and submit a PR for the cache HIT/MISS.
Thanks for this PR, I merged them in to my local and they are working great.

Sorry for the late reply. I'll look into this at the weekedn.

@HeinrichHartmann please check the result of strftime, and use strncat rather than relying on getting the size of the buffer right.  Oh, and sizeof(char) is guaranteed to be 1.

Any progress on including this on debian?
Built polipo from source swapping files like for like didn't work, although compiled without errors, run ok but got connection refused from polipo.


Spawning an entity on chunk load causes deadlock

I am currently running
Minecraft: 1.16.5
SpongeAPI: 8.0.0-SNAPSHOT
Sponge: 1.16.5-8.0.0-SNAPSHOT
SpongeVanilla: 1.16.5-8.0.0-RC935
JVM: 16.0.1/64-bit (Oracle Corporation)
OS: Windows 10/10.0 (amd64)

Plugins/Mods:
Custom plugin that spawns a villager on chunk load

Issue Description
@Listener
public void onChunkLoad(final ChunkEvent.Load event) {
    ServerLocation location = ServerLocation.of(event.worldKey(), 0, 100, 0);
    Villager villager = location.createEntity(EntityTypes.VILLAGER.get());
    location.spawnEntity(villager);
}

Teleport to 0 100 0 -> crash
Crash log https://gist.github.com/masagameplay/d97f7260904fe6c67a4d0b9ba8ddd1a1

I mean, Chunks are loaded asynchronously, so you're trying to perform world modifications on a chunk asynchronously here. The API docs should mention that ChunkEvent.Load is asynchronous so world modifications should be scheduled via a Task.


(Question) Is there a way to get data back from the modal window

I am using the modal dialog to catch the users' input.
So I am wondering if angular2-modal supports binding custom buttonOnClick functions to the buttons at the bottom of the modal.
Any information and suggestions are highly appreciated.

Angular version: 2.0.1
Browser: [all]

With some digging into the demo page i found it.
The .open() function returns some sort of promise wich you can use like this :
let mod = this.modal.alert()
            .size('lg')
            .showClose(true)
            .title('A simple Alert style modal window')
            .body('modal content')
            .open();

mod.then((resultPromise) => {
            resultPromise.result.then((result) => {
                this.result = result;
            }, () => this.result = 'Rejected!');
        });

In case you are using custom modals component there is an exemple here : https://github.com/shlomiassaf/angular2-modal/blob/master/src/demo/app/bootstrap-demo/bootstrap-demo-page/custom-modal-sample.ts
You can use 2 fonctions to return your input result :
beforeDismiss(): boolean {
    return 'your value';
  }

  beforeClose(): boolean {
    return 'your value when closing';
  }

Hope it helps.

Dear Gbacc,
I am struggling with this same issue with custom modals.
I am calling my custom modal in a similar fashion as in Shlomi Assaf's example Plunker.
 openCustom(){     this.modal.open(CustomModal);   }
You mentioned you can return a result from the modal in the dialog close:
this.dialog.close('my result');
My question is how can you refer to this returned result from the component that calls the custom modal? How does the calling component know when the custom modal has returned the result?
Thanks in advance! I am sorry if this something obvious, I am very new to Angular 2.

Hello again,
I made an exemple here from the exemple Plunker.
Custom modals returns the same result as normal one.
this.modal.alert()....open() returns a promise wich you can use with the angular .then() operator.
Not sure if i'm clear.

Thank you Gbacc, for putting your solution on plunker !
That answers my question.


IP addresses are truncated by 1 digit

Minor cosmetic issue: on TwisterOS, at least, the IP addresses, both v4 and v6, are truncated by 1 digit in the network view. Here's a comparison on CommanderPi and ifconfig:

Note that both IPs are truncated but the MAC is not.

Fixed.


[RFC] Support for username and password with vault

Is your feature request related to a problem? Please describe.
Dynaconf currently does not support connecting to Hashicorp Vault using username and password.
Describe the solution you'd like
I suggest adding support for username and password.
Describe alternatives you've considered
Additional context
hvac already supports username and password and I've tested an implementation locally and could provide pull request if you like the approach.

Thanks for the contribution @hansharhoff !


Swa deploy fails with an unknown exception has occurred

Describe the bug
When running swa deploy to deploy a frontend app without an API, it fails with the error "An unknown exception has occurred"
To Reproduce

Configure the following environment variables;

AZURE_REGION_LOCATION
AZURE_RESOURCE_GROUP
AZURE_SUBSCRIPTION_ID
SWA_CLI_APP_NAME
SWA_CLI_DEPLOYMENT_TOKEN

Type in command 'swa deploy'

Expected behaviour
The app is deployed to the configured location.
Verbose Log

Welcome to Azure Static Web Apps CLI (1.0.2)

Getting config file options from swa-cli.config.json...
Config file does not exist at C:\Users\Joe\Development\external\dist\swa-cli.config.json
Deploying front-end files from folder:
  C:\Users\Joe\Development\external\dist

Deployment token found in Environment Variables:
 - SWA_CLI_DEPLOYMENT_TOKEN: <hidden>

Deploying to environment: preview

Trying to read workflow config with values:
 - appLocation: C:\Users\Joe\Development\external\dist
 - outputLocation: C:\Users\Joe\Development\external\dist
 - apiLocation: <undefined>
No workflow config folder found at C:\Users\Joe\Development\external\dist\.github\workflows
Validating user workflow config (BEFORE):
 - appLocation: C:\Users\Joe\Development\external\dist
 - outputLocation: C:\Users\Joe\Development\external\dist
 - apiLocation: <undefined>
Validating user workflow config (AFTER):
 - appLocation: C:\Users\Joe\Development\external\dist
 - apiLocation: <undefined>
 - outputLocation: C:\Users\Joe\Development\external\dist
Loading staticwebapp.config.json schema...
Schema loaded successfully from https://json.schemastore.org/staticwebapp.config.json
Compiling schema...
Reading content from staticwebapp.config.json...
Parsing staticwebapp.config.json...
Validating staticwebapp.config.json...
File validated successfully. Continuing with configuration!
Content parsed successfully

Found configuration file:
  C:\Users\Joe\Development\external\dist\staticwebapp.config.json

Deploying project to Azure Static Web Apps...
Fetching release metadata for version: stable. Please wait...
 - version: stable
 - buildId: 1.0.019361
 - publishDate: 2022-04-20T15:35:50.4947355Z
- files:
 - linux-x64:
   - url: https://swalocaldeploy.azureedge.net/downloads/1.0.019361/linux/StaticSitesClient
   - sha: 24baa1cedd45b7b029f3ee502265de940383fab940e0bed75842cbf7f9030080
 - win-x64:
   - url: https://swalocaldeploy.azureedge.net/downloads/1.0.019361/windows/StaticSitesClient.exe
   - sha: 66c529754df158761523aeffcc5f278d14205f6b51afec913ba113edc3caa681
 - osx-x64:
   - url: https://swalocaldeploy.azureedge.net/downloads/1.0.019361/macOS/StaticSitesClient
   - sha: ec26ca4e7a12f46cee93b5d0b2128f79f18a3ff9875d7276a837ca94c16be854
Local client binary is up to date. Skipping download.
Deploying using<EMAIL_ADDRESS>Deploying using the following options:
- env:
  - SWA_CLI_DEBUG: silly
  - SWA_RUNTIME_WORKFLOW_LOCATION: <undefined>
  - SWA_RUNTIME_CONFIG_LOCATION: C:\Users\Joe\Development\external\dist
  - SWA_RUNTIME_CONFIG: C:\Users\Joe\Development\external\dist\staticwebapp.config.json
  - SWA_CLI_VERSION: 1.0.2
  - SWA_CLI_DEPLOY_DRY_RUN: false
  - SWA_CLI_DEPLOY_BINARY<EMAIL_ADDRESS>  - DEPLOYMENT_ACTION: upload
  - DEPLOYMENT_PROVIDER: swa-cli-1.0.2
  - REPOSITORY_BASE: C:\Users\Joe\Development\external\dist
  - SKIP_APP_BUILD: true
  - SKIP_API_BUILD: true
  - DEPLOYMENT_TOKEN: <hidden>
  - APP_LOCATION: C:\Users\Joe\Development\external\dist
  - API_LOCATION: <undefined>
  - CONFIG_FILE_LOCATION: C:\Users\Joe\Development\external\dist
  - VERBOSE: true
  - DEPLOYMENT_ENVIRONMENT: preview
ℹ DeploymentId: da6fb4cc-1baf-4ba2-b72c-698a2a43d1b3
ℹ
ℹ Verbose logging enabled
ℹ Build timeout not specified, defaulting to 15 minutes
ℹ App Directory Location: 'C:\Users\Joe\Development\external\dist' was found.
ℹ No Api directory specified. Azure Functions will not be created.
ℹ config_file_location: config file 'C:\Users\Joe\Development\external\dist\staticwebapp.config.json' was found.
ℹ Looking for event info
ℹ Event info parsed from action options.
ℹ Could not get repository branch. Proceeding
ℹ Could not get repository url. Proceeding
ℹ Skipping step to build C:\Users\Joe\Development\external\dist with Oryx
ℹ Didn't find Oryx manifest file under location: C:\Users\Joe\Development\external\dist\ss-oryx\app-manifest\oryx-manifest.toml
ℹ Determined default file to be: index.html
ℹ Using 'staticwebapp.config.json' file for configuration information, 'routes.json' will be ignored.
ℹ Either no Api directory was specified, or the specified directory was not found. Azure Functions will not be created.
ℹ Zipping App Artifacts
ℹ App Zip will be created from directory: C:\Users\Joe\Development\external\dist
✖ An unknown exception has occurred
ℹ
ℹ For further information, please visit the Azure Static Web Apps documentation at https://docs.microsoft.com/en-us/azure/static-web-apps/
ℹ If you believe this behavior is unexpected, please raise a GitHub issue at https://github.com/azure/static-web-apps/issues/

Desktop (please complete the following information):

OS: Windows
Version 11

Hey @joebell1329 ,
Have you tried following the steps mentioned in the official doc here?
Our recommendation for running applications without an api is to first build it and then try the swa deploy <build folder>
Let us know if this works fine in your case?

Hi @Reshmi-Sriram,
The app is already built and I am running the swa deploy command from within the build output folder.

Got it! Thanks for clarifying, we will investigate this further!
Meanwhile could you please confirm if swa deploy ./dist  (Option 2 in the doc) does not work either??
Also, much appreciated if you could share your project (without sensitive content) so that we could try reproducing it on our ends. Sorry for the experience!

I was having the same problem and moving up a working directory did work as a work around for me.
Thank you

Yep, moving to the parent directory and running swa deploy ./dist worked for me too. Thanks!

Thanks for the confirmation! Looks like there is a bug, related to #514
Closing this issue and continuing the bug fix in the other issue. Thanks!


Prevent Bogus Link Embed Cards being generated

Is your feature request related to a problem? Please describe.
Currently, when you paste a URL on the post composing box, a link embed card is generated automatically, which can be useful for easier linking.
However, this also happens when you type text that could be interpreted as a URL, meaning bogus link embed cards get generated. For example:

Composing a text with a misspelling converts it to link embed card automatically. Notice it displays an Error

Deleting the link embed card still keeps the bogus link clickable

Post with misspelled text generated as link and displating link embed card

The original post that made me research this behavior further. The poster wanted to say "Appealing, so" but made a misspelling (presumably "appealing.so"), corrected it but the bogus link embed card remained in the post.

Describe the solution you'd like
More obvious controls when link embed cards are generated, and when they are generated.
Describe alternatives you've considered
Editing the text to erase the bogus link should also remove the embed;
Prevent generation of such links when it detects Errors.
Additional context
There are other issues pertaining to link embed card behavior, but this one is caused by honest mistakes during common communication (no copy and pasting of links are actually involved). This could be exploited by bad users who can fashion malicious URLs that are easier to be typed during conversation via accident.

I agree that this is a problem as I've seen this happening quite a few times.
For example 2, however, since .so is a valid ccTLD (for Somalia), hello.so is a valid possible domain name (without getting into the specifics of what domain names the .so registry allows).
So even though examples like that might be annoying, I'm not sure what a better result in that case would be, as being able to link to websites by just typing the domain name – without having to include https:// – is a very useful feature.
For link cards, I can think of one straightforward fix which would hopefully be easy to implement: if a user types or pastes a link and Error: Unable to generate link preview is encountered because the website is not an actual website (or there's some other issue), the link card should automatically be deleted after a short delay (maybe 2 seconds?)

I agree that example 2 specifically is a tough nut to crack, but I do believe that most people notice they typed an "accidental link" the moment the link embed card appears, and correct right away (as per example 4).
The bulk of the problem to me is that even when they correct the typo, the card remains, which could be frustrating to users who managed to fix the text but still got the link on it anyway (which happened in example 4)

For link cards, I can think of one straightforward fix which would hopefully be easy to implement: if a user types or pastes a link and Error: Unable to generate link preview is encountered because the website is not an actual website (or there's some other issue), the link card should automatically be deleted after a short delay (maybe 2 seconds?)

I like this idea, it would help reduce the number of such cards


Automatically pruning unused colors

Hi @brattonross - Love the project!
I was wondering if it's possible to prune the CSS variable to just the subset that's being used automatically, without having to specify them by hand via the config.
One thought I have while reading the tw source code, is to utilize the matchUtility lifecycle for any color-related class (text, bg, border, etc...):
https://github.com/tailwindlabs/tailwindcss/blob/master/src/corePlugins.js#LL1603C18-L1603C18
Then, inside that match Utility, we construct an array of all the radix colors in use.  (Actually, this array should be moved into a top-level variable so we can use it for both the theme extends and our plugin).
Then, after the matchUtilities call are done, invoke the addBase function with the constructed list of radix color found?
I suppose one draw-back of this approach is that the intelisense might foobar :d.... but I wonder how does tw do it?

Pruning unused variables without having to manually specify colors would be great. I haven't really spent any time investigating how to do this, but your idea seems promising

Hi @louisgv and @brattonross,
I played around a bit trying to get this to work and managed to prune unused colors and apply opacity modifiers to the colors, but the opacity only works in the light theme (or the default theme), see the generated CSS in the playground.
Do you have any idea how to make the opacity modifiers work when the prefers-color-scheme is dark? or any other theme.
Tailwind Play

I gave this idea some thought during the recent v2 rewrite, so I now better understand the kind of trade-off we'd be making by implementing something like this. Tl;dr the downside of using matchUtilities is that we'd have to disable the default Tailwind color palette.
The main negative of continuing to generate all colors is that it increases the output CSS file size by around 125 kB (26 kB gzipped). Running Lighthouse on the demo site homepage gives a good performance score, but obviously warns that there is CSS that could be removed.

If we decided to add colors via matchUtilities, it would mean that this library must be updated if Tailwind ever decides to release new color utilities, whereas right now the colors just work with any color utility, even if it is brand new.
This isn't a massive downside, however; Tailwind is unlikely to release new color utilities often, and if this plugin is written well enough, I imagine updating would just mean something like adding an entry to some array of properties to generate. I think I'm okay with making that trade-off.
I've already started to hack around to see what a solution might look like, and found that in order to use matchUtilities, we'd need to disable the various Tailwind core plugins that handle color utilities. If these core plugins are left enabled, then Tailwind will complain that there are multiple matchers found.
The question then becomes are we okay with disabling the core color plugins (i.e. removing the ability to use Tailwind's default color palette)? Personally, I'm fine with this, but not sure how folks that use this plugin might feel about that.
Potentially there is also a nice upside to this implementation as well -- I could see it being possible to remove the need for the opacitySupport option, and have opacity just work.
I'm going to keep hacking around with this to see if I can get something working. Stay tuned :)


stdm: add possibility to get multiple urls for a single build

Signed-off-by: Alessandro Comodi<EMAIL_ADDRESS>This PR allows returning different results based on input parameters:

--get_build_number: returns the latest build number
--get_all_urls: returns a list of dictionaries. The dictionary contains also the name of the artifact, so that to correctly name the latest link (e.g. in symbiflow-arch-defs GH actions)

{'name': 'symbiflow-arch-defs-install-05bd35c7.tar.xz', 'url': 'https://www.googleapis.com/download/storage/v1/b/symbiflow-arch-defs/o/artifacts%2Fprod%2Ffoss-fpga-tools%2Fsymbiflow-arch-defs%2Fpresubmit%2Finstall%2F1049%2F20201123-030526%2Fsymbiflow-arch-defs-install-05bd35c7.tar.xz?generation=1606156380577163&alt=media'}
{'name': 'symbiflow-xc7a100t_test.tar.xz', 'url': 'https://www.googleapis.com/download/storage/v1/b/symbiflow-arch-defs/o/artifacts%2Fprod%2Ffoss-fpga-tools%2Fsymbiflow-arch-defs%2Fpresubmit%2Finstall%2F1049%2F20201123-030526%2Fsymbiflow-xc7a100t_test.tar.xz?generation=1606156383271653&alt=media'}

--get_single_url: returns one URL only (this is enabled by default)

https://www.googleapis.com/download/storage/v1/b/symbiflow-arch-defs/o/artifacts%2Fprod%2Ffoss-fpga-tools%2Fsymbiflow-arch-defs%2Fpresubmit%2Finstall%2F1049%2F20201123-030526%2Fsymbiflow-arch-defs-install-05bd35c7.tar.xz?generation=1606156380577163&alt=media

If @kgugala is happy, then go ahead.


Continued increasing coverage

Addressing #358

Current coverage is 84.76% (diff: 100%)

Merging #360 into master will decrease coverage by 0.03%

@@             master       #360   diff @@
==========================================
  Files            35         35
  Lines          4311       4320     +9
  Methods           0          0
  Messages          0          0
  Branches        389        395     +6
==========================================
+ Hits           3656       3662     +6
- Misses          615        616     +1
- Partials         40         42     +2

Powered by Codecov. Last update 143cbff...5adf82a

👍


COU missing charm glance-simplestreams-sync

glance-simplestreams-sync is an openstack principal charm that is currently not supported by COU. It has openstack channels like ussuri/stable and it seems that is normally deployed on production clouds. The charm does not have workload version.

Closed by #156


Publish to PyPI via OIDC

How can I publish using PyPI trusted publishers / OIDC ?
I tried using a separate action to get a token, that runs without a problem ,
but publishing still fails on auth with HTTP Error 403: Invalid or non-existent authentication information.
name: Python package to pypi via OIDC
on:
  push:
    tags:
      - "v*.*.*-*"
      - "v*.*.*"
  workflow_dispatch:
jobs:
  publish_pypi:
    runs-on: ubuntu-latest
    # environment: release
    permissions:
      # IMPORTANT: this permission is mandatory for trusted publishing
      id-token: write
      contents: read
    steps:
      - uses: actions/checkout@v3

      - name: Mint token
        id: mint
        uses<EMAIL_ADDRESS>
      - name: Build and publish to pypi
        uses<EMAIL_ADDRESS>        with:
          pypi_token: "${{ steps.mint.outputs.api-token }}"

accoding to the pypi docs
the username is supposed to be "token", but I cannot find how to make this work with this action
          repository_username: "__token__"
          repository_password: "${{ steps.mint.outputs.api-token }}"

also fails
logs >

Honestly, I don't know if there are some boundaries when using OIDC. Maybe try wikh the suggested action: pypi-publish

hmm, I adopted poetry just because I did not want to keep a shack full of different tools up-to date for different steps in the same process.
and I think its quite achievable
The simple for of the question is : is it possible to configure this action to use the poetry arguments
  -u, --username=USERNAME        The username to access the repository.
  -p, --password=PASSWORD        The password to access the repository.

and assuming so , and how to I provide the values to that ?
T
I tried to follow though/reverse engineer the logic, but I get lost

Ok, I think I see what was the issue with your first try with repository_username and repository_password.
It was the right approach, but adding username and password also requires adding the repository name and url. Check here. I assume your action fails, because you don't provided the repository information and it is expected. Please try to specify all the four values:

repository_name
repository_url
repository_username
repository_password

Please share your results when you try this :relaxed:

Did it solve your issue?

Hey @Josverl  :)
I checked OIDC a bit deeper, and here are my findings:

what I said in the previous message was not right, you can't just pass repository_username and repository_password for OIDC to work
it's currently not supported by this action and won't be for some period. Reasons:

it's only supported by default github action: https://github.com/marketplace/actions/pypi-publish
if you want to implement it manually, you need to etrieve an OIDC token from the OIDC identity provider, submit that token to PyPI, which will return a short-lived API key and use it as API key. In the docs, this way is strongly discouraged.

instead of this, I'd recommend using the normal token instead if you don't want to use the action suggested in the docs

Check the details here: https://docs.pypi.org/trusted-publishers/using-a-publisher/ under The manual way section.
Closing this issue since there won't be any development regarding it until pypi releases another (and recommended) way of using OIDC as a third party.


chore: identify each type of notice

closes #709
closes #472
closes #417
Summary:
This PR suggests a category for each specific notice.
Expected behavior:
🚩Tests are broken for now. They will be fixed once we agree on the category of each notice.
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Run the unit tests with gradle test to make sure you didn't break anything
[x] Format the title like "feat: -new feature short description-" (PR title must follow the conventional commit specification)
[x] Linked all relevant issues
~[ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)~

@barbeau
I did this first categorization of notices, what do you think about that?
Also:

🚩Tests are broken for now. They will be fixed once we agree on the category of each notice.

That would increase the amount of job for me. I see that you set severity of DuplicateKeyError and DuplicatedColumnNotice to INFO while they are ERRORs. That will lead to incorrect validation reports and to errors in the core code. Please let me set the priorities because I know what they should be and what we actually have in the production feeds in the world.

Thanks @barbeau just updated this PR. I will wait for @MobilityData/transit-specs to confirm the comments I left unresolved.

@barbeau this PR is now ready for review. Thanks @timMillet !

@lionel-nj Could you resolve the conflicts here, and change DuplicatedColumnNotice to ERROR?
If you do that, and update the notices merged in https://github.com/MobilityData/gtfs-validator/pull/756 (just the Javadocs, I think, to match those in this PR), then I think this should be ready to merge!

That is a big contribution, Lionel. Thank you!
I left some comments mostly based on the real production feeds.

Hi @lionel-nj
Please can you remove FieldParsingError.java file that resurrected in this PR?
Thanks!

Sure @aababilov! It's done in https://github.com/MobilityData/gtfs-validator/pull/775/


RPMs are missing dependency on proj-devel package.

Some fusion operations are failing because gdal has a soft dependency on proj-devel.  It should be included as a dependency and automatically installed.

From the perspective of rpm linting (#862) having a devel package dependency is considered an error.  I am not sure if we should re-open this and try for a different solution or not.

@tst-dsugar I'm torn on this. If GDAL needs it for fusion operations, then that's not really a development dependency. But, it might be worth looking into whether it's really needed. If we want to fix the lint error, let's write a new ticket rather than reopen this one.


feature: jump to start/end of any visible TS node

Did you check the docs?

[X] I have read all the flash.nvim docs

Is your feature request related to a problem? Please describe.
Current treesitter mode can jump to start or end, but the position must be decided beforehand.
Also, it would be nice to jump to deeper nodes from the current one, not just go upwards in the tree.
Describe the solution you'd like
Offer a treesitter_jump mode, which would operate on the following basis:

different label for end or start of a node - or select a node and then select to go to start or end
all visible nodes would be jumpable, not just upwards through the tree
a possibility to filter node types (operator, name/value...)

Describe alternatives you've considered
I couldn't get treesitter_search to not be in range selection but just on end or start.
I on selection doesn't move to beginning of selection but beginning of line when selection is just part of a single line, though that is fixable by vim.keymap.set("v", "I", "o<Esc>i").
Using treesitter_search with space can highlight all nodes, but cannot filter them.

I think you can try adapting the treesitter_search matcher to create labels at the start and end of the nodes.
https://github.com/folke/flash.nvim/blob/967117690bd677cb7b6a87f0bc0077d2c0be3a27/lua/flash/plugins/treesitter.lua#L140
all visible nodes being labelled is unlikely to work, there are just too many nodes, you need the search to prefilter like treesitter_search does.

You're right. I was sure what I thought of already exited, so I kept trying to find a way to make it work like I wanted and indeed almost did.
I think in the end the only feature I mentioned, but didn't find a way to use is the treesitter node type filtering - nvim-treesitter-textobjects does basically that, but doesn't allow simpler jumping in between. On the other hand, filtering for bigger blocks also doesn't make much sense, because the majority of the blocks won't fit into the screen -> I'm going to try nvim-navbuddy for that feature.


xWebAppPool doesn't fail on state mis-match or reset running state when resetting state

Details of the scenario you tried and the problem that is occurring
I've setup xWebAppPool resources with "State" set to "Started" if the AppPool is stopped Test-DscConfiguration doesn't show the pool as non-compliant, if I Reset-DscConfiguration it doesn't restart the AppPool, but if I Start-DscConfiguration with the same resource it'll start the AppPool
Verbose logs showing the problem
when I disable FLW.LessorPortal AppPool and then Test-DscConfiguration -Verbose, teh following is shown:
VERBOSE: [W1QVWB1077]: LCM:  [ Start  Resource ]  [[xWebAppPool]FLW.LessorPortal_AppPool]
VERBOSE: [W1QVWB1077]: LCM:  [ Start  Test     ]  [[xWebAppPool]FLW.LessorPortal_AppPool]
VERBOSE: [W1QVWB1077]:                            [[xWebAppPool]FLW.LessorPortal_AppPool] Application pool "FLW.LessorPortal" was found.
VERBOSE: [W1QVWB1077]:                            [[xWebAppPool]FLW.LessorPortal_AppPool] The "State" property of application pool "FLW.LessorPortal" does not match the desired state.
VERBOSE: [W1QVWB1077]:                            [[xWebAppPool]FLW.LessorPortal_AppPool] The "autoStart" property of application pool "FLW.LessorPortal" does not match the desired state.
VERBOSE: [W1QVWB1077]:                            [[xWebAppPool]FLW.LessorPortal_AppPool] The target resource is not in the desired state.
VERBOSE: [W1QVWB1077]: LCM:  [ End    Test     ]  [[xWebAppPool]FLW.LessorPortal_AppPool] False in 0.0630 seconds.
VERBOSE: [W1QVWB1077]: LCM:  [ End    Resource ]  [[xWebAppPool]FLW.LessorPortal_AppPool]
Suggested solution to the issue
Looking at the code, I'm not seeing a check performed to test or reset the state, I'm not 100% sure how to update code since I'm new to DSC, and not super great at PowerShell just yet.
The DSC configuration that is used to reproduce the issue (as detailed as possible)
I'm ForEach'ing through a list of sites that need to be created on the node, the xWebAppPool config section in that loop is below
            xWebAppPool "${_}_AppPool"
            {
                Ensure = 'Present'
                Name = "$_"
                State = 'Started'
                AutoStart = $true
                StartMode = 'AlwaysRunning'
                Credential = $Credentials
                ManagedPipelineMode = "Integrated"
                ManagedRuntimeVersion = "v4.0"
                IdentityType = 'SpecificUser'
                LoadUserProfile = $true
                IdleTimeout = (New-TimeSpan -Minutes 120).ToString()
                ShutdownTimeLimit = (New-TimeSpan -Seconds 300).ToString()
                RapidFailProtectionMaxCrashes = 50
                RestartSchedule = @()
                RestartTimeLimit = (New-TimeSpan -Seconds 0).ToString()
                LogEventOnRecycle              = 'Time,Requests,Schedule,Memory,IsapiUnhealthy,OnDemand,ConfigChange,PrivateMemory'
                DependsOn = '[WindowsFeature]Web-WebServer'
            }

The operating system the target node is running

OsName               : Microsoft Windows Server 2016 Standard
OsOperatingSystemSKU : StandardServerEdition
OsArchitecture       : 64-bit
WindowsBuildLabEx    : 14393.3686.amd64fre.rs1_release.200504-1524
OsLanguage           : en-US
OsMuiLanguages       : {en-US}
Version and build of PowerShell the target node is running

Name                           Value

PSVersion                      5.1.14393.3471
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.3471
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
Version of the DSC module that was used
xWebAdministration 3.1.1

It seems like the problem only occurs if the IIS Management Console is up and running when the Restore-DscConfiguration is run.  Closing this issue out since this seems to be a known issue.


Group 9: Tic Tac Toe

Group 9:
Jessica Ngo &
Matthew Panebianco &
Sam Braun

Looks great!
Some comments/tips:

Very nice _position_is_valid ;P (What you did there is called Duck typing in case you didn't know.)
In _is_winning_combination, big conditionals are generally undesirable as they can cause a lot of headache in the future.
In _is_winning_combination, you copy pasted all the combinations. It's fine once, but copy-pasting is most of the time a sign that things could be changed for the better. (For example in this case, move the variable out somewhere).
You never make use of game["winner"]. If you made use of it, there would be no need for logic in get_winner, just a simple one line return.


[FEATURE] Allow Docker to accept user arguments

Is your feature request related to a problem? Please describe.
Noppers
In words, describe the components of the feature.
Update the Docker configuration to accept user arguments while also not impacting local/dev deployment.
This can be broken into a couple of points:

[x] Update the Dockerfile to use the Rscript command rather than an entrypoint bash script
[ ] Update the argparse code to accept a user defined output directory
[ ] Update the file paths for consistency
[ ] Revise the deployment GH action, local bash script to implement the changes

 Features

 Docker


feat: None values for angles

This PR enables None values for the inclination and obliquity of a surface, enabling loads of optimizations when preforming its rotation.

By mistake, this contains the code from #212  and #217 ...


Cannot add helm repository

I am trying to add a helm repository as follows:
$ helm repo add traefik-helm-chart "git+https://github.com/containous/traefik-helm-chart@?ref=master"
Error: unknown command "home" for "helm"
Run 'helm --help' for usage.
Error: looks like "git+https://github.com/containous/traefik-helm-chart@?ref=master" is not a valid chart repository or cannot be reached: plugin "helm-git" exited with error

I understand that this problem may be in the helm-git plugin, but my version of that plugin has not changed, and this used to work up until quite recently.
I don't see any helm home command, so I'm assuming this is coming from the plugin.  Since this used to work, did helm recently remove a home subcommand?
Output of helm version:
$ helm version
version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"}

$ helm plugin list
NAME    	VERSION	DESCRIPTION
diff    	3.1.1  	Preview helm upgrade changes as a diff
helm-git	0.5.0  	Get non-packaged Charts directly from Git.
registry	0.7.0  	This plugin provides app-registry client to Helm.
    	       	usage:
    	       	  $ helm reg...

Output of kubectl version:
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.4", GitCommit:"8d8aa39598534325ad77120c120a22b3a990b5ea", GitTreeState:"clean", BuildDate:"2020-03-12T23:41:24Z", GoVersion:"go1.14", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.9-eks-502bfb", GitCommit:"502bfb383169b124d87848f89e17a04b9fc1f6f0", GitTreeState:"clean", BuildDate:"2020-02-07T01:31:02Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
AWS EKS 1.14

From the sounds of it, the helm-git plugin is not compatible with Helm 3.
closing in favour of https://github.com/aslafy-z/helm-git/issues/77. Please follow up with the plugin maintainer. Thanks.


File type check not working

In the example code in the readme there is a accept="image/*" but it is never actually used by the react component.

All props are passed down to the underlying <input type="file"> here: https://github.com/odysseyscience/react-s3-uploader/blob/master/ReactS3Uploader.js#L59
In this case, accept is specific to the file input, which is who uses it.
Reopen if there is something else I'm not seeing.  Thanks!


Add load tests as part of nightly pipeline

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Secrets Store CSI Driver version: (use the image tag):
Azure Key Vault provider version: (use the image tag):
Kubernetes version: (use kubectl version):
Cluster type: (e.g. AKS, aks-engine, etc):

Closed with #219


Add HuggingFace embedding consistent with cloud service

I've added HuggingFace models to the embeddings options in outlines.
Some things:

There would be less code if we just used sentence_transformers, but this is consistent with what happens in cloud right now (a light re-write of that code. Ben's argument for doing manual pooling is to reduce dependency bloat.)
It adds a batch_size parameter to the generated function, in the case where you want to do batching. The default processes the input all in one batch. Would it be better for the default to do batches of 1?
I haven't tested it with a gpu, but it should be lowered properly if a gpu is available
I've written some tests that all pass. ~But for some reason, a lot of the other tests are failing on my machine.~ It turns out I was using Python 3.11, which explains all of this.
It's been through the pre-commit circus.

lmk what you think needs changing etc.

There would be less code if we just used sentence_transformers, but this is consistent with what happens in cloud right now (a light re-write of that code. Ben's argument for doing manual pooling is to reduce dependency bloat.)

Not an expert, but it looks like the sentence-transformer repos contains much more code than just a pooling function. With what models is the code in this PR compatible?

This code is specially built for the sgpt implementation. I would actually vote for moving to `sentence-transformers in the long-term, so I think it's reasonable to do it here (assuming there aren't any reproducibility problems

It adds a batch_size parameter to the generated function, in the case where you want to do batching. The default processes the input all in one batch. Would it be better for the default to do batches of 1?

Has Ben found that chunking batches was necessary? At what scale?

Batch size really depends on hardware and the model that is being used. I think it's probably fine to set a default batch size of 128 or larger since most embedding models are pretty small, but I wouldn't really want to commit to any numbers without more information.


Attach activation layer

Changes proposed in this PR:

strip activation function related members in layer
init activation property as activation_layer

Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [ ]Passed [X]Failed [ ]Skipped (conv::forward test need change)

Signed-off-by: Jihoon Lee<EMAIL_ADDRESS>

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #205. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

:octocat: cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/205-202006192133470.94245409965515-5180def0a64c4c6f4d20c8590d0a8a1718397354/.

:octocat: cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/205-202006192234350.080940008163452-5196ed41989a83b3330f87ab513967e4e0e337b4/.

:octocat: cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/205-202006192258500.96726703643799-9e35319f9432d1adbfce4c5b0ca4f1aa2ab00d9c/.

:octocat: cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/205-202006221115330.47899293899536-d3a55c502d97da7d6f042017254a8c1c1beaadbe/.

:octocat: cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/205-202006221155170.93917298316956-4108cc9065d1028af9e3cbeb6cee843db0d5a030/.

:octocat: cibot: @zhoonit, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/205-202006221251210.60638189315796-4108cc9065d1028af9e3cbeb6cee843db0d5a030/.


[Enhancement] Additional edge padding for Warning Screen body text

The problem
Current Warning Screens use the standard GUIConstants.EDGE_PADDING for the left and right limits for the body text. But the pulsing yellow or red warning edges fill that edge padding. Depending on the line breaks, text can potentially directly touch the pulsing warning edges.
The fix
Double the default edge padding for Warning Screens.

Before / After
(unfortunately we can't currently render the yellow/red warning edges, so just imagine the edges being filled in)

This change affects all Warning Screens, so you must regenerate screenshots to see the changes.

Additional changes

Adds a screenshot for the generic ErrorView
Pulls the more general errors out into their own section at the end of the screenshot generator output
Renames the example SettingsQR since "factory reset" terminology only makes sense for a retail product.

Follow-up steps
If merged, generate new screenshots and update https://github.com/SeedSigner/seedsigner-screenshots

ACK Tested


Screen refresh rate slows to a crawl AFTER using Telecine

On a rooted LG G3 DUAL (LG-D858HK, LRX22G) Android 5.0, if I run Telecine, record a video and stop the video then turn off the screen (either manually or let it timeout), then after the screen is turned back on, and after some more time (variable, but usually minutes), the screen refresh rate becomes very jerky, gradually gets worse and the only way to get back to normal is to reboot the device. Force Stop on Telecine does not help.
Interestingly, if the screen goes off while the device is being charged, then the problem does not occur.
If I run the app while plugged in and Force Stop while still plugged in, then unplug, the refresh issue is still a problem.
Take Bug Report not working on this device, unfortunately, and I don't have access to the device generally.
Any ideas what could be causing this?

My guess would be an Android operating system bug that causes problems when the MediaProjection API is used. Telecine doesn't really do all that much when it comes to recording... we really just hook up Android's media recorder to its media projector and point it at a file.
There are a few other screen recording apps in the Play Store which use the same technique. I would suggest trying one and seeing if the same thing happens. I don't know one off-hand because, well, I use Telecine!

Yeah, my app also exhibits the same problem. But so far, only on that device. So I agree it's probably a bug specific to that device. Having said that, it's passed CTS and it running Google Play, so it should work. Just curious if you have any ideas what it might be?  The "plugged in" difference might indicate it's to do with whether the device goes to a deeper stand by mode, for example.

I'm not sure if we have the device, I'll have to check. Even in that case, the problem is surely buried in the native code which deals with rendering to the real and fake displays which are likely nearly impossible to debug. I'll check this week though which at least might allow me to confirm the bug's existence by reproduction.

it's passed CTS

I think you are over-estimating CTS! It's pretty awful what OEMs can get away with breaking. The word "Samsung" comes to mind...

Cool, thanks. FWIW I added the issue to the main tracker: https://code.google.com/p/android/issues/detail?id=181207

Closing the issue, but following the reported one. Thanks.


bug: missing infos for the useRunDetails hook

Provide environment information
System:
OS: macOS 14.2.1
CPU: (10) arm64 Apple M2 Pro
Memory: 227.30 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
Yarn: 1.22.21 - ~/.nvm/versions/node/v20.10.0/bin/yarn
npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
bun: 1.0.25 - ~/.bun/bin/bun
Describe the bug

data.subtasks are in the typescript but the hook doesn't spit them out
status are not showing WAITING... haven't tested the others

Reproduction repo
https://discord.com/channels/1066956501299777596/1066956844553207828/1200203785457377390
To reproduce
basically
  const {data, error} = useRunDetails(runId)
  return  <pre>{JSON.stringify(data, null, 2)}</pre>

and this job
https://trigger.dev/docs/documentation/concepts/tasks#extracting-common-tasks
Additional information
No response

@wladpaiva to get subtasks in the result you need to pass subtasks: true in the options.
const { isLoading, isError, data, error } = useEventRunDetails(id, { subtasks: true });


updates for workshop ami and requirements

Issue #69 and N/A:

Updated AWS AMI to Rancher Manager v2.7.9, Rancher Kubernetes Engine 2 v1.25.15, and Cert-Manager v1.13.2

Tested and verified comparability with the workshop environment on two accounts in us-east-1 and us-west-2

Updated Workshop Requirements to add clarity for users at AWS Events and Outside AWS Events

Feedback received from users at the most recent AWS Event

Minor updates to AWS CloudFormation template to have the same formatting and configuration

Linted and formatted (with prettier) CloudFormation template

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hey @evdevr, please review/comment/approve!


Fix/open book error

This PR fixes #11369
OpenBook should not be used to open a folder of notebooks. So the error in the above issue is a valid error.
But to address the missing way to open a folder with notebooks, updated the OpenNotebookFolder to accept a folder path to open (which if absent, prompts user to select a folder).

Coverage increased (+2.2%) to 39.953% when pulling f2569a63f00a2bf3fb0ee3c63caa01ee3f78cab8 on fix/openBookError into 921beebd79b09f7f0ec036e8c63249750a97a8f2 on main.


Blaming still open and deleted file crashes the extension

Issue Type: Bug
Extension Name: gitblame
Extension Version: 2.8.0
OS Version: Darwin x64 18.6.0
VSCode version: 1.36.0-insider

{
	"messages": [],
	"activationTimes": {
		"startup": true,
		"codeLoadingTime": 43,
		"activateCallTime": 1,
		"activateResolvedTime": 15,
		"activationEvent": "*"
	},
	"runtimeErrors": [
		{
			"name": "Error",
			"message": "ENOENT: no such file or directory, watch #PATH_TO_FILE'"
		}
	]
}

Hey dmitriismitnov.
Thank you for the report.
Where you looking at a file that was removed from the disk when this error occurred?

Thank you for your report. A fix will be uploaded to the marketplace shortly.


Improve SDK and Notebook user experience of ray cluster local interaction

Investigate how to call these methods in cluster.up() because users should not need to explicitly call them.
generate_cert.generate_tls_cert(cluster_name, namespace)
generate_cert.export_env(cluster_name, namespace)

cc @MichaelClifford

resolved by PR#100


Error handling in tool module

[ ] #386
[x] #387
[x] #388

Closing this now  - only issue needs to be resolved #386


Add missing doc and tests for multi-key commands

Issue #, if available:
N/A
Description of changes:

Add cross-slot notice for multi-key commands - which can handle it and which can not
Add tests
For all clients

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I wanted to emphasize hash slot, but then we decided not to do that in python client, so I removed it everywhere. Thank you for catching that.

Should be merged after #1390

@shohamazon please, review and merge if it is OK for you.


Error - Unauthorized action or expired link after login

Code of Conduct

[X] I agree to follow this project's Code of Conduct.

Submission validity

[X] This is not a personal support request, that should be posted on discussions community.
[X] I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

[X] I've read the documentation and made sure to follow it.
[X] I've read the troubleshooting first steps guide.

Version
1.8.2
Description
I updated to version 1.8.2 and now a get a message "Error - Unauthorized action or expired link" every time I log in. After I hit "login" it prints this error. In the log of my webserver I see a line "Error | 403 | POST /admin/ HTTP/1.0". When I enter domain.tld/admin I'm in the backend. So login is successful but the post method throws an error. I activated debug mode but there wasn't any hint what could be the problem.
This happens on two installations of Yourls. I use PHP 8.0.11 and MySQL 8.0.26, tested with Chrome and Edge on Windows 10 and 11.
Expectation
Successful login without error message
Reproduction steps
No response
Context
No response

You're absolutely right. I thought it must be a problem with the core functions because it's there since the update of the yourls core files. Now I deactivated all plugins I have on both installations and found out, that the problem is linked to the sleeky backend plugin. I updated it to version 2.5.0 but still the same error message appears.
I will contact the author of this plugin, perhaps he has any ideas what causes this.
Thanks for your help.

I had exactly the same problem. Thankfully I found this thread here and did try it with the plugins in my installation.
After deactivating:
"Don't Track Admins" / "Don't Track Admin Clicks" (1.2) by dgw the problem was solved.
Just wanted to leave a note here for others finding it by an internet search like I did...

@issteve The error message comes from authentication handling—specifically the nonce check, which predates the existence of my plugin (but used to live in a different core file; see 970936e5744c177deba69374a0669a4c7a8cded1).
My plugin doesn't touch any of that. It's supremely simple code, really, and I suspect you've mistaken a temporal correlation for causation. But if there really is a bug in my plugin after all this time, a patch would be welcome.

@dgw I did check it multiple times back and forth with the same result.
Just changing "yourls_is_valid_user" into "yourls_is_admin" did stop the error too (but it doesn't do any longer what it should and did before ;-) ). I have no idea what else could be used somehow instead of "yourls_is_valid_user".
Anyhow I didn't say there is any bug in your plugin, but deactivating helps and it still does.
So I guess something in Yourls changed around October 2021 regarding "yourls_is_valid_user" which is also in the plugin gehwissenlos had a problem with, but I'm not into php to really judge it.

I think there was a change in yourls_is_valid_user because in the issue I opened in this plugin somebody wrote that the deleted the line "if (yourls_is_valid_user() != 1)" and it works. So perhaps there was a bigger change under the hood and that's the reason why several plugins have this error.

@issteve Sounds good, thanks for testing it.
Would be worth trying to replace if( yourls_is_valid_user() === true ) { (in my plugin) with if( defined( 'YOURLS_USER' ) {. That's set by auth validation functions and checking it doesn't require calling the validation again. YOURLS itself uses that constant to decide whether it should show a logout link.
https://github.com/YOURLS/YOURLS/blob/master/includes/functions-html.php#L752-760

I did check your suggestion after I figured out that there was one bracket missing. So I tried:
if( defined( 'YOURLS_USER' ) ) {
... and it didn't work that well. So, yes, I was able to activate it and the login-error was gone but it did count some clicks anyway. Yes, "some" so not everyone, but with all my tries at least the first one after the login. But some others as well, but not all...

Only "some" being logged might be due to caching of 301 redirects, rather than anything the plugin is (not) doing.
Upon further review, I don't think YOURLS defines that constant if it isn't already checking auth itself for some other reason—a request for something that requires auth, for example. Near as I can tell that never happens during a shortlink redirection.
So I'm back to square one on eliminating the issue from my plugin. If I can't call yourls_is_valid_user() safely, I don't know how else to check if the request came from someone who's logged in. :/

@dgw I'll have a look at the plugin & this issue next week-end. I don't see why a plugin would not be able to check yourls_is_valid_user()

You're absolutely right. I thought it must be a problem with the core functions because it's there since the update of the yourls core files. Now I deactivated all plugins I have on both installations and found out, that the problem is linked to the sleeky backend plugin. I updated it to version 2.5.0 but still the same error message appears. I will contact the author of this plugin, perhaps he has any ideas what causes this. Thanks for your help.

Just as FYI, for anyone who ends up here looking for a fix Re: the Sleeky Back end, the issue has not been addressed but someone over there came up with a fix that I will post below. Both as a way to save people time but also to elucidate the likely issues with and why some extensions may have with Yourls.
Cheers.

This seems to have worked for me...
Near the bottom of user/plugins/sleekly-backend/plugin.php, change the line:
if (yourls_is_valid_user() != 1) {
to
if( defined( 'YOURLS_USER' ) ) {

Link to original post:
https://github.com/Flynntes/Sleeky/issues/127#issuecomment-1586014710


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

This link is only accessible to employees of RelationalAI.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/75545

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/75948

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/82966

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/84291

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/90598

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/114461


TPC-H Query 14

Note: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11527
CASE WHEN expressions are not coerced yet, query fails with error "false_values downcast failed"
{{thread 'tokio-runtime-worker' panicked at 'false_values downcast failed', datafusion/src/physical_plan/expressions/case.rs:216:30}}

The issue can also be closed @alamb

:tada: good work @xudong963 !

Thanks again @xudong963


[Flaky Test] E2E Test: credentials-rotation

How to categorize this issue?

/area testing
/kind flake
Which test(s)/suite(s) are flaking:
https://github.com/gardener/gardener/blob/833e5f89b48079922d39ac43f60a3d853e802f43/test/e2e/shoot/create_rotate_delete.go#L40
CI link:
https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/6570/pull-gardener-e2e-kind/1565631458054246400
https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/6587/pull-gardener-e2e-kind/1565751885468536832
Reason for failure:
  Expected
      <int>: 503
  to equal
      <int>: 200
  In [It] at: /home/prow/go/src/github.com/gardener/gardener/test/e2e/shoot/internal/rotation/observability.go:61

Anything else we need to know:

Two more occurrences:

https://prow.gardener.cloud/view/gs/gardener-prow/logs/ci-gardener-e2e-kind/1565790237840379904
https://prow.gardener.cloud/view/gs/gardener-prow/logs/ci-gardener-e2e-kind/1566273427218632704

More occurrences:

https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/6632/pull-gardener-e2e-kind/1567049874501799936

Another another one: https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/6640/pull-gardener-e2e-kind/1567430919764054016

/assign

In all the three cases I checked, I can see some events like these:
17m         Normal    Scheduled                      pod/grafana-users-d665ff7db-sv5j4                        Successfully assigned shoot--local--e2e-rotate/grafana-users-d665ff7db-sv5j4 to gardener-local-control-plane
17m         Normal    SuccessfulCreate               replicaset/grafana-users-d665ff7db                       Created pod: grafana-users-d665ff7db-sv5j4
17m         Normal    Created                        pod/grafana-users-d665ff7db-sv5j4                        Created container grafana
17m         Normal    Started                        pod/grafana-users-d665ff7db-sv5j4                        Started container grafana
17m         Normal    ScalingReplicaSet              deployment/grafana-users                                 Scaled up replica set grafana-users-d665ff7db to 1
17m         Normal    Pulled                         pod/grafana-users-d665ff7db-sv5j4                        Container image "grafana/grafana:7.5.16" already present on machine
16m         Normal    Sync                           ingress/grafana-users                                    Scheduled for sync
16m         Normal    Sync                           ingress/grafana-users                                    Scheduled for sync
16m         Normal    Sync                           ingress/grafana-users                                    Scheduled for sync
13m         Warning   FailedScheduling               pod/grafana-users-d665ff7db-b2s6m                        0/1 nodes are available: 1 Insufficient cpu. preemption: 0/1 nodes are available: 1 Insufficient cpu.
13m         Warning   FailedScheduling               pod/grafana-users-d665ff7db-b2s6m                        0/1 nodes are available: 1 Insufficient cpu. preemption: 0/1 nodes are available: 1 Insufficient cpu.
13m         Normal    SuccessfulCreate               replicaset/grafana-users-d665ff7db                       Created pod: grafana-users-d665ff7db-b2s6m
13m         Normal    Preempted                      pod/grafana-users-d665ff7db-sv5j4                        Preempted by extension-provider-local-xrpk2/gardener-extension-provider-local-68df7f4f67-5h2hl on node gardener-local-control-plane
13m         Normal    Killing                        pod/grafana-users-d665ff7db-sv5j4                        Stopping container grafana
12m         Warning   FailedMount                    pod/grafana-users-d665ff7db-b2s6m                        MountVolume.SetUp failed for volume "grafana-datasources" : failed to sync configmap cache: timed out waiting for the condition
12m         Warning   FailedMount                    pod/grafana-users-d665ff7db-b2s6m                        MountVolume.SetUp failed for volume "grafana-dashboards" : failed to sync configmap cache: timed out waiting for the condition
12m         Warning   FailedMount                    pod/grafana-users-d665ff7db-b2s6m                        MountVolume.SetUp failed for volume "grafana-dashboard-providers" : failed to sync configmap cache: timed out waiting for the condition
12m         Normal    Scheduled                      pod/grafana-users-d665ff7db-b2s6m                        Successfully assigned shoot--local--e2e-rotate/grafana-users-d665ff7db-b2s6m to gardener-local-control-plane
11m         Normal    Created                        pod/grafana-users-d665ff7db-b2s6m                        Created container grafana
11m         Normal    Pulled                         pod/grafana-users-d665ff7db-b2s6m                        Container image "grafana/grafana:7.5.16" already present on machine
11m         Normal    Started                        pod/grafana-users-d665ff7db-b2s6m                        Started container grafana

The reason for the preemption and re-scheduling can only be that the gardener-extension-provider-local pod which serves the node webhook is down. In this case, the kubelet will be able to revert the Nodes resource capacity again which can cause the preemption and "0/1 nodes are available" events.
In fact, I see that the gardener-extension-provider-local pod was evicted by VPA and scaled every now and then:
LAST SEEN   TYPE      REASON              OBJECT                                                    MESSAGE
22m         Warning   Unhealthy           pod/gardener-extension-provider-local-68df7f4f67-cpsjj    Readiness probe failed: Get "http://<IP_ADDRESS>:8081/readyz": dial tcp <IP_ADDRESS>:8081: connect: connection refused
22m         Normal    SuccessfulCreate    replicaset/gardener-extension-provider-local-68df7f4f67   Created pod: gardener-extension-provider-local-68df7f4f67-cpsjj
22m         Normal    Started             pod/gardener-extension-provider-local-68df7f4f67-cpsjj    Started container gardener-extension-provider-local
22m         Normal    Scheduled           pod/gardener-extension-provider-local-68df7f4f67-cpsjj    Successfully assigned extension-provider-local-xrpk2/gardener-extension-provider-local-68df7f4f67-cpsjj to gardener-local-control-plane
22m         Normal    ScalingReplicaSet   deployment/gardener-extension-provider-local              Scaled up replica set gardener-extension-provider-local-68df7f4f67 to 1
22m         Normal    Pulling             pod/gardener-extension-provider-local-68df7f4f67-cpsjj    Pulling image "localhost:5001/eu_gcr_io_gardener-project_gardener_extensions_provider-local:v1.54.0-50-g30ccfa27f@sha256:5a3ef9094ba8322fc3a4fa42bf99fafde069fbd9ddecacb640bbe5ed112af348"
22m         Normal    Pulled              pod/gardener-extension-provider-local-68df7f4f67-cpsjj    Successfully pulled image "localhost:5001/eu_gcr_io_gardener-project_gardener_extensions_provider-local:v1.54.0-50-g30ccfa27f@sha256:5a3ef9094ba8322fc3a4fa42bf99fafde069fbd9ddecacb640bbe5ed112af348" in 613.290735ms
22m         Normal    Pulled              pod/gardener-extension-provider-local-68df7f4f67-cpsjj    Container image "localhost:5001/eu_gcr_io_gardener-project_gardener_extensions_provider-local:v1.54.0-50-g30ccfa27f@sha256:5a3ef9094ba8322fc3a4fa42bf99fafde069fbd9ddecacb640bbe5ed112af348" already present on machine
22m         Normal    LeaderElection      lease/provider-local-leader-election                      gardener-extension-provider-local-68df7f4f67-cpsjj_dfe5a6a4-596d-48b7-8406-59890377a5c3 became leader
22m         Normal    Created             pod/gardener-extension-provider-local-68df7f4f67-cpsjj    Created container gardener-extension-provider-local
21m         Normal    LeaderElection      lease/provider-local-leader-election                      gardener-extension-provider-local-68df7f4f67-cpsjj_c7ab44fa-1c94-419b-a0d9-e4e305c9e6c1 became leader
20m         Warning   FailedScheduling    pod/gardener-extension-provider-local-68df7f4f67-vvfjc    0/1 nodes are available: 1 node(s) didn't match pod anti-affinity rules. preemption: 0/1 nodes are available: 1 node(s) didn't match pod anti-affinity rules.
20m         Warning   FailedScheduling    pod/gardener-extension-provider-local-68df7f4f67-vvfjc    0/1 nodes are available: 1 node(s) didn't match pod anti-affinity rules. preemption: 0/1 nodes are available: 1 node(s) didn't match pod anti-affinity rules.
20m         Normal    SuccessfulCreate    replicaset/gardener-extension-provider-local-68df7f4f67   Created pod: gardener-extension-provider-local-68df7f4f67-vvfjc
20m         Normal    Scheduled           pod/gardener-extension-provider-local-68df7f4f67-vvfjc    Successfully assigned extension-provider-local-xrpk2/gardener-extension-provider-local-68df7f4f67-vvfjc to gardener-local-control-plane
20m         Normal    Killing             pod/gardener-extension-provider-local-68df7f4f67-cpsjj    Stopping container gardener-extension-provider-local
20m         Normal    EvictedByVPA        pod/gardener-extension-provider-local-68df7f4f67-cpsjj    Pod was evicted by VPA Updater to apply resource recommendation.
19m         Warning   Unhealthy           pod/gardener-extension-provider-local-68df7f4f67-vvfjc    Readiness probe failed: HTTP probe failed with statuscode: 500
19m         Normal    Started             pod/gardener-extension-provider-local-68df7f4f67-vvfjc    Started container gardener-extension-provider-local
19m         Normal    Pulled              pod/gardener-extension-provider-local-68df7f4f67-vvfjc    Container image "localhost:5001/eu_gcr_io_gardener-project_gardener_extensions_provider-local:v1.54.0-50-g30ccfa27f@sha256:5a3ef9094ba8322fc3a4fa42bf99fafde069fbd9ddecacb640bbe5ed112af348" already present on machine
19m         Normal    LeaderElection      lease/provider-local-leader-election                      gardener-extension-provider-local-68df7f4f67-vvfjc_d4556fee-adb0-4d84-9c07-76fd1546772a became leader
19m         Normal    LeaderElection      lease/provider-local-leader-election                      gardener-extension-provider-local-68df7f4f67-vvfjc_94ed3e4f-9f22-4def-9b3a-9e9b1223c6c2 became leader
19m         Normal    Created             pod/gardener-extension-provider-local-68df7f4f67-vvfjc    Created container gardener-extension-provider-local
13m         Warning   FailedScheduling    pod/gardener-extension-provider-local-68df7f4f67-5h2hl    0/1 nodes are available: 1 node(s) didn't match pod anti-affinity rules. preemption: 0/1 nodes are available: 1 node(s) didn't match pod anti-affinity rules.
13m         Warning   FailedScheduling    pod/gardener-extension-provider-local-68df7f4f67-5h2hl    0/1 nodes are available: 1 Insufficient cpu. preemption: not eligible due to a terminating pod on the nominated node.
13m         Warning   FailedScheduling    pod/gardener-extension-provider-local-68df7f4f67-5h2hl    0/1 nodes are available: 1 Insufficient cpu. preemption: not eligible due to a terminating pod on the nominated node.
13m         Warning   FailedScheduling    pod/gardener-extension-provider-local-68df7f4f67-5h2hl    0/1 nodes are available: 1 Insufficient cpu.
13m         Normal    SuccessfulCreate    replicaset/gardener-extension-provider-local-68df7f4f67   Created pod: gardener-extension-provider-local-68df7f4f67-5h2hl
13m         Normal    Killing             pod/gardener-extension-provider-local-68df7f4f67-vvfjc    Stopping container gardener-extension-provider-local
13m         Normal    EvictedByVPA        pod/gardener-extension-provider-local-68df7f4f67-vvfjc    Pod was evicted by VPA Updater to apply resource recommendation.
12m         Normal    Started             pod/gardener-extension-provider-local-68df7f4f67-5h2hl    Started container gardener-extension-provider-local
12m         Normal    Scheduled           pod/gardener-extension-provider-local-68df7f4f67-5h2hl    Successfully assigned extension-provider-local-xrpk2/gardener-extension-provider-local-68df7f4f67-5h2hl to gardener-local-control-plane
12m         Normal    Pulled              pod/gardener-extension-provider-local-68df7f4f67-5h2hl    Container image "localhost:5001/eu_gcr_io_gardener-project_gardener_extensions_provider-local:v1.54.0-50-g30ccfa27f@sha256:5a3ef9094ba8322fc3a4fa42bf99fafde069fbd9ddecacb640bbe5ed112af348" already present on machine
12m         Normal    LeaderElection      lease/provider-local-leader-election                      gardener-extension-provider-local-68df7f4f67-5h2hl_5d7442b0-ccf4-4db3-b18b-8d87d3a8a206 became leader
12m         Normal    Created             pod/gardener-extension-provider-local-68df7f4f67-5h2hl    Created container gardener-extension-provider-local

This obviously creates some unnecessary noise. If it happens at an unfortunate time (when the assertion in the rotation test is made) then it can clearly lead to the flakes we observe here.

With https://github.com/gardener/gardener/pull/6573, we have set the failure policy of the webhook to Ignore. Together with the timeoutSeconds=1, this is quite risky for the seed nodes.


MINOR: [C++][CI] Unpin CMake

CMake >=3.22.3 fixes the error causing us to pin the CMake version
(see https://gitlab.kitware.com/cmake/cmake/-/issues/22524).

@github-actions crossbow submit test-conda

It seems the turbodbc tests keep failing on this PR while they succeed on git master.
To be honest, based on the error, this seems to be a problem in turbodbc itself. @xhochy Have you already seen this?
/turbodbc/cpp/turbodbc/Test/tests/field_translator_test.cpp:31:2:   required from here
/opt/conda/envs/arrow/include/boost/optional/optional.hpp:1596:3: error: static assertion failed: If you want to output boost::optional, include header <boost/optional/optional_io.hpp>
 1596 |   BOOST_STATIC_ASSERT_MSG(sizeof(CharType) == 0, "If you want to output boost::optional, include header <boost/optional/optional_io.hpp>");
      |   ^~~~~~~~~~~~~~~~~~~~~~~

The turbodbc errors were also reported in ARROW-15997


Init flake.nix developer environment

Closes #73
Initializes a nix flake for a reproducible developer environment, which is derived from the derivation of the workspace packages. This means that all system dependencies and build dependencies are managed by nix, abstracting it away from the user. These derivations can then be bundled and published, as well as tested locally and in CI.

Closing for now since this is getting stale. May come back around and complete it later or feel free to pick up where I've left off 🙂


Update the crate to edition 2018

update to the edition 2018
update dependencies to the latest
upgrade the MSRV to 1.36 (required by unicode-normalization 0.1)
make clippy happy

Signed-off-by: koushiro<EMAIL_ADDRESS>

@stevenroose PTAL

I'v been doing a series of changes in other PRs that are awaiting review. I'll look at this afterwards and see if I can incorporate some of the things. But I definitely don't want to bump the MSRV above the one of rust-bitcoin, which currently is 1.29.

Why you don't want to bump the MSRV?
The current MSRV is 1.29, which was released in 2018, now it's 2020.
Is there any environment that needs to be compatible with 1.29?

Well that's something up for rust-bitcoin to decide, feel free to join our IRC channel #rust-bitcoin on Freenode. Especially in an ecosystem like Bitcoin it's not trivial for companies to publicly disclose the Rust version they are using.

Relevant issue: https://github.com/rust-bitcoin/rust-bitcoin/issues/510


ebreak mtval

According to the RISC-V privileged spec:

When a hardware breakpoint is triggered, or an instruction-fetch, load, or store address-misaligned, access, or page-fault exception occurs, mtval is written with the faulting effective address.

Ibex does not update mtval to the current PC on ebreak, it instead clears it:
https://github.com/lowRISC/ibex/blob/668233699df9ec2a40413e69e0de0a5b10185980/rtl/ibex_controller.sv#L780-L784
A simple (verifiable) fix is to have
end else begin
  exc_cause_o = ExcCauseBreakpoint;
  csr_mtval_o = pc_id_i;
end

According to the privileged spec version 20240411, Section 3.1.16 Machine Trap Value Register says the following:

If mtval is written with a nonzero value when a breakpoint, address-misaligned, access-fault, or page-
fault exception occurs on an instruction fetch, load, or store, then mtval will contain the faulting
virtual address.

So writing zero is a legal behavior here.


stranded libraries

I am using Hisat2/Stringtie to assemble a set of reference annotations from multiple libraries. I am following the procedure laid out on the Stringtie website.
Some of the libraries were created with stranded prep chemistry. I mapped those libraries with hisat2 using the --rna-strandness FR along with the --dta flag.
Will Stringtie take into account the libraries with strand information during the merge step?

StringTie does not get (hence does not use) this library-level information directly -- though this information should be reflected in the spliced-alignment strand info of the alignments generated by HISAT2 --dta (the "XS"  tag) which of course StringTie uses when it assembles the read alignments into transfrags.


Merge gitian and release-process documentation updates from bitcoin/bitcoin

I cherry-picked commits related to the gitian build and release process to bring hivemind up to date with the development in bitcoin/bitcoin. Hopefully a good starting point for Hivemind's own deterministic builds. Following this process, I was able to build a Gitian binary to run on OS X.

Going through this right now

Looks awesome! Those docs needed some love and cherry picking with git is not very fun :) We should probably start using the merge request peer review system that Bitcoin uses, unless someone comes up with a better system. My suggestion would be a simple REJECT or APPROVE message but in spirit of maintaining compatibility with Bitcoin in as many ways as possible,
ACK

Thanks! And +1 to sticking as close as possible to bitcoin/bitcoin's processes.
I certainly got comfortable with cherry-picking... On that topic, just opened this: https://github.com/bitcoin-hivemind/hivemind/issues/66


Why the session remains active after the user closes and reopens the browser on B2C if we do NOT have “Keep me signed-in” feature enabled it.

Hi,
This page does not explain the behavior for when you have "Keep me signed-in" disabled it.
The normal behavior without turn on the functionality "Keep me signed-in" is the session is NOT active after the user closes and reopens the browser. if this is the normal behavior then azure B2C has a bug right now, I tested it with IEF files from the starter pack for "SocialAndLocalAccounts"  and the Session remains active after close and reopens the browser (Tested it on Chrome, Firefox, and Edge)
Our Configuration on azure for the session:
Session scope= Tenant
Session life time= 1440 minutes
Session expiry type= Rolling
The Keep me signed-in feature Disabled it.
I already opened an incident on Microsoft Support also.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5761bd51-2480-33fe-0e82-c8e7b58fdcd5
Version Independent ID: 59194957-7c80-9c86-d903-18b15022adde
Content: SSO sessions in Azure Active Directory B2C
Content Source: articles/active-directory-b2c/session-overview.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@glomaga Thanks for reaching out. We will investigate and update the thread accordingly.

Hi @glomaga
Thanks for reaching out! I'd be more than happy to help you. Couple of questions

Have you checked the issue with local account, or social?
If you sign-in with a social account, on the second time when you reopen the browser and click sign-in, do you get a token immediately, or have to click on a social account, such as "Facebook"?
It would be helpful if you provide the steps to reproduce the issue?

Yoel

Hi Yoel
All my configuration is with local accounts.
The steps are :

login with your local account
2)close the browser
open the browser
navigate to your app
you are login to your app without need to enter the credentials again

FYI
I tested it with the startedpack for socialandlocalaccounts without any custom code
I tested it with opendid and SAML protocol.
Sent from my iPhone

On Oct 22, 2020, at 3:48 AM, Yoel Horvitz<EMAIL_ADDRESS>wrote:

Hi @glomaga
Thanks for reaching out! I'd be more than happy to help you. Couple of questions
Have you checked the issue with local account, or social?
If you sign-in with a social account, on the second time when you reopen the browser and click sign-in, do you get a token immediately, or have to click on a social account, such as "Facebook"?
It would be helpful if you provide the steps to reproduce the issue?
Yoel
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

This issue should be fixed now. I would be grateful if you check the flow again.

Hi, @yoelhor  I tested it on Chrome, Edge, Mozilla, and now is working correctly. Thanks

Thanks @glomaga, glad to hear. Thanks for bringing this issue to our attention.
#please-close


Use @vaadin/vaadin-component-dev-dependencies

The same as https://github.com/vaadin/vaadin-element-skeleton/pull/156

This change is

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Doesn't write valid ComicInfo.xml

I was testing out the Metron plugin for ComicTagger this afternoon, and noticed CT doesn't write valid ComicInfo v1 or v2. Not sure if you were aware or not, so figured I'd open a bug on it.
bpepple@frodo ~/Git/metron-tagger (main) $ metron-tagger --validate ~/Storage/Downloads/today/dc/Silver\ Surfer\ Rebirth\ -\ Legacy\ v1\ \#001\ \(2023\).cbz

Validating ComicInfo:
---------------------
'Silver Surfer Rebirth - Legacy v1 #001 (2023).cbz' is not valid

I tested this with the latest dev branch (as of submitting this bug) commit https://github.com/comictagger/comictagger/commit/f72c0c82243e9e4edd43ddc19068b63a09963397
The ComicInfo (changed the extension so the file could be attached):
ComicInfo.txt

Can you explain? I don't see anything that is obviously wrong. I don't really care for trusting the output of an arbitrary tool with no explanation or reason as to why it's invalid

The schema's are incorrect. See https://github.com/anansi-project/comicinfo/issues/10

Well, that's debatable since it sorta defeats the purpose of schema if it can't be used to actually validate an xml, but that's really beside the point,  you will need to handle mapping the AgeRating metadata from Metron to make it compatible with the Anansi projects, since the two projects use different enumerations.  Something like this when mapping the metadata should fix that:
        def map_ratings(rating: str) -> str:
            age_rating = rating.lower()
            if age_rating in {"everyone", "cca"}:
                return "Everyone"
            if age_rating in {"teen", "teen plus"}:
                return "Teen"
            return "Mature 17+" if age_rating == "mature" else "Unknown"

Age rating is a free text field. https://web.archive.org/web/20161229183519/http://comicrack.cyolito.com:80/forum/7-general/709-using-comicinfo-xml-in-other-viewers#852

I don't believe ComicRack ever produced files that would actually pass validation

I guess my thinking is if I'm writing out the ComicInfo, I want to make sure it's actually valid and can be used by any consumer that wants to (which I thought was the general mission statement for the Anansi Project).
Now, not all projects care if it's valid or not, but I'm aware of at least one project that does validate before reading the file (which makes sense since they worked on the Linux Desktop & fdo).
Anyway, just thought I'd bring this to your attention.

What project is that? I haven't noticed any projects that actually validated it before

It hasn't been released yet (I think the code is sitting on the Fedora infra), a bunch of Fedora/GNOME folks have been working on it in their free time.


Unable to verify JWT

Attempts to verify a jwt (that was created using the same package result in a strange error that i cant decipher. Any help/insight into the matter would be much appreciated.
const jwt = require("jsonwebtoken");
const config = require("../config/index.js");

module.exports = {
    jwtLogin: function(req, res, next){
        "use strict";
        const token = req.headers.authorization || req.headers.Authorization;
        if (token){
            const decoded= jwt.verify(token, config.secret);
            console.log(decoded);
            next();
        }else{
            return res.status(403).send({
                success: false,
                message: "No token provided"
            });
        }
    }
};

The error in question:
Error
    at Object.module.exports [as verify] (.../node_modules/jsonwebtoken/verify.js:97:17)
    at jwtLogin (points to the line where verify is used)

Hello sir, let's try console.log in your jwt.verify'scallback
jwt.verify(token, config.secret', function(err, decoded) {
 if(err){
     console.log(err)
 }else{
     console.log(decoded)
 }
})

Sorry for the extended leave. As requested I added the callback function and decided to take a screenshot

In short
error:  { Error
    at Object.module.exports [as verify] (/home/utibe/Desktop/server_projects/api/node_modules/jsonwebtoken/verify.js:97:17)
    at jwtLogin (/home/utibe/Desktop/server_projects/api/controllers/authentication.js:171:32)

Note: i also ensured that the request for the secret is fullfilled. I've deleted node_modules a few times and started anew, and it seems to have had no effect.

I accidentally closed this, please can it be reopened?

I accidentally closed this, please can it be reopened?

This is the error raised: https://github.com/auth0/node-jsonwebtoken/blob/master/verify.js#L97
You can try in https://jwt.io to with one token and the secret you provide to the verify function, in case something funny is happening with the token or your secret.
BTW when you don't provide a callback the errors are raised via throw.

Thanks!


Missing K8s RBAC

OSD-13910 This PR addresses two K8s RBAC errors relating to AVO:
The first is from Prometheus pods (openshift-monitoring/prometheus-k8s-*) that cannot scrape AVO metrics which seemingly was mistakenly removed in #42:
ts=2023-01-22T13:37:34.598Z caller=klog.go:108 level=warn component=k8s_client_runtime func=Warningf msg="github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:541: failed to list *v1.Endpoints: endpoints is forbidden: User \"system:serviceaccount:openshift-monitoring:prometheus-k8s\" cannot list resource \"endpoints\" in API group \"\" in the namespace \"openshift-aws-vpce-operator\""

and the second is from AVO itself where it cannot create events, which was new functionality in #95:
E0124 21:26:46.400514       1 event.go:267] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"demo.173d5bd4e5cc747e", GenerateName:"", Namespace:"openshift-aws-vpce-operator", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), DeletionTimestamp:<nil>, DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ManagedFields:[]v1.ManagedFieldsEntry(nil)}, InvolvedObject:v1.ObjectReference{Kind:"VpcEndpoint", Namespace:"openshift-aws-vpce-operator", Name:"demo", UID:"a9f108f0-3df7-4b3f-b06c-006288f2fcb3", APIVersion:"avo.openshift.io/v1alpha2", ResourceVersion:"261614085", FieldPath:""}, Reason:"Created", Message:"Created Private Hosted Zone: /hostedzone/Z00130803CFL9MAWW3OUI", Source:v1.EventSource{Component:"VpcEndpoint", Host:""}, FirstTimestamp:time.Date(2023, time.January, 24, 21, 26, 46, 398268542, time.Local), LastTimestamp:time.Date(2023, time.January, 24, 21, 26, 46, 398268542, time.Local), Count:1, Type:"Normal", EventTime:time.Date(1, time.January, 1, 0, 0, 0, 0, time.UTC), Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'events is forbidden: User "system:serviceaccount:openshift-aws-vpce-operator:aws-vpce-operator" cannot create resource "events" in API group "" in the namespace "openshift-aws-vpce-operator"' (will not retry!)

After validating both of these changes on stage clusters, Prometheus can scrape metrics again + events show up!
0s          Normal    Created               vpcendpoint/demo                                           Created security group: sg-0d77efb8a7982f542
0s          Normal    Created               vpcendpoint/demo                                           Created VPC endpoint: vpce-05181b93c2dee36ea
0s          Normal    Created               vpcendpoint/demo                                           Created Private Hosted Zone: /hostedzone/Z054667117956EYAG3OYG

/hold
Will be moving the RBAC to the deploy/ directory

/unhold

/lgtm
/approve

/lgtm


Update README.md.

What this PR does / why we need it:

Fix multiple typos.

Format the document to adhere to Markdown conventions.

Release note:

Update README.md

@petersutter let me know if you have any more suggestions. Thanks.


feedback on harfbuzz updates

Hey guys, any particular issue on https://github.com/Microsoft/vcpkg/commit/0aa1bfe293454874eeae33ce80f2469ea28edb59 ? I can not access you CI log so felt asking so would be best.
Also I am changing upstream to use GNUInstallDirs https://github.com/harfbuzz/harfbuzz/pull/665 can you check if the change is OK to vcpkg? Thank you

@ebraminio I tried building harfbuzz  with the latest release 1.7.4 and it fails. I tried building it with the latest master and it still failed. Were you able to build it successfully in vcpkg?

What errors it gives? HarfBuzz has a Windows CI which uses vcpkg itself for pulling dependencies so it should be some issue from vcpkg side I guess.

The error should still be the same as #2276. I will double check again. However one thing I noticed in the harfbuzz Appveyor CI is that it only checks compilation on Visual Studio 2015 and not Visual Studio 2017. I am on Visual Studio 2017 and I am not sure if that's the reason compilation fails.

@ebraminio Just checked. It's the same error message as #2276.

Oh, on the newest change you are using the project source rather than a distribution and that needs "ragel" tool from vcpkg be installed (vcpkg install ragel I guess). So there it two solution for this, use distributions releases as the old versions, or add "ragel" to the dependencies of harfbuzz.

@ebraminio It is actually as simple as adding ragel as a dependency to solve this... I will submit a PR in a bit

It is actually as simple as adding ragel as a dependency to solve this... I will submit a PR in a bit

I was also saying that :P That would be great, can you however test the build-ability of master also for me separately?

@ebraminio Current master compiles for me

Excellent :)


feat: add nixd

a nix language server supported by nix-community
by the way, rnix-lsp has archived

@plokid I would love to have the possibility to install nixd through Mason. Do you have any plans to address the comments, or would you be fine with me sending a new PR?

Hey and thanks for the PR! Custom build scripts are being deprecated because of difficulty in maintaining them over time and their common reliance on system dependencies that Mason cannot detect. You can always host your own registry if you'd like to manage it through Mason, see https://github.com/williamboman/mason-registry-playground/ for a starting point


Providing the libsecret dbus api (secret-service-srv-rs?)

Hi. I want to modify https://github.com/cole-h/passrs to have a passrs libsecret command that would run a service providing the libsecret dbus service. This would require what I believe is the  the compliment to this project.
Is this something you have worked on, or are aware of someone working on?

Hi! Sorry, I have not worked on a vault implementing the secret-service api. I only know of Gnome and KDE implementations which you may already be aware of: https://github.com/GNOME/gnome-keyring, https://github.com/KDE/kwallet


ucpc-solutions:0.1.0

I am submitting

[x] a new package
[ ] an update for a package

Description: ucpc-solutions is the template for solutions editorial of algorithm contests, used widely in the "Baekjoon Online Judge" users community in Korea. The original version of ucpc-solution is written in LaTeX(ucpcc/2020-solutions-theme), and this is the port of LaTeX ver. This contains content-generating utils for making solutions editorial and "solved.ac" difficulty expression presets, a rating system for Baekjoon Online Judge's problems.

I have read and followed the submission guidelines and, in particular, I

[x] selected a name that isn't the most obvious or canonical name for what the package does
[x] added a typst.toml file with all required keys
[x] added a README.md with documentation for my package
[x] have chosen a license and added a LICENSE file or linked one in my README.md
[x] tested my package locally on my system and it worked
[x] excluded PDFs or README images, if any, but not the LICENSE

[x] ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

Thank you for the reviews!

Thank you for taking them into account (and for the package submission) :)


Filecoin Calibration (testnet)

Chain Name
Filecoin - Calibration testnet
Chain ID
314159
RPC URL
https://rpc.ankr.com/filecoin_testnet
Block Explorer URL
https://calibration.filscan.io/
Deployment Funds
Yes

I tried myself but couldn't make not legacy tx - legacy is not supported there

Done, thanks!


Fix add local scopes

This encloses all "JS experiment" implementation files in braces to isolate them into their own block scopes thus avoiding some name collisions.

@soapdog thanks for submitting these changes. I'm afraid they're likely breaking a type-checker (since export / import statements need to be in top level scope), which made me realize we could enable at least that in test automation.
I'll try to enable https://travis-ci.org/ and hope it will point out all the issues here. What I suspect will require changes are:

Interface definitions like  src/FileSystem/FileSystem.js don't need changes as they aren't actually loaded anywhere, it's just for a type-checker.
I think blocks should not enclose type comments like here https://github.com/mozilla/libdweb/pull/30/files#diff-e3f736821481a5d5c796ea73fe0b8d25L2 to keep imports in a top scope.

@soapdog if addressing all this is too much hassle, I don't mind taking over that.

I have closed / reopened this pull to trigger CI

Close this in favor of #42


Convert Appendix A Tests from Anton’s Haskel Code to Scala

typo corrected for probabilityLattice method;
andPr bug is fixed: originally partially applied function was returned;
Haskell tests from AvS webpage are converted.

Thanks :)


Scaffold

PR dev branch for activity RoR capstone project.
The RoR Capstone project is a personal budget mobile app called Budget App.
The following video shows a brief explanation of the app features: https://www.loom.com/share/18271cf949f34ea58e85f124fc50449e
*According to the project requirements, when a user visits the "splash" page, it shows the app name, logo, and links to sign up and sign in.
*If this is the first time for a user, he or she will need to register using the Signup link:
*For already registered users, they can click the Login link:
*When the user gets logged in, the app shows a new nav-bar, which includes links for navigating backward, for logging out, updating the account profile, and "Current user" info with the name of the logged user.
Also, the app shows the user's category list, with the total amount of payments the user has registered in the listed categories:
*The user can create a new category using the "New Category" link shown above. When this link is clicked, the user will see the form for creating a new category, and a list of suggested icons to associate with the new category:
*If the user navigates to the new category, it is possible to create new payments for that category:
*The newly created payment is shown, with name, amount, and date & time of creation:
*The main root page presents now the list of categories, including the new category with the total amount of payments done for that category:
*Finally, when the user logs out, the app shows the "splash" page again:
image
Thank you in advance for your review.

thanks for the suggestions I already fix those details