Make an optional launch arg for RViz, document it in README

This adds an argument for RViz launching and updates the README about it.
Also, I changed some numbers in the README to bullet points since they don't really need to be traversed in order anymore.

Great idea! I only moved the argument to the end of the arguments list, to start with UR-related arguments.


API does not includes object translations

Is your feature request related to a problem? Please describe.
Currently the detail viewsets for Article and Category include original object (if any) but does not indicate available translations for original object.
Describe the solution you'd like
A new serializer field available_translations should be added to Article and Category serializers. It should be filled with possible translation objects like it is already done in the HTML frontend.

Also it misses the recent Category tree features.

Done in v0.9.1-pre.5


Help and support view

A new view about library list (closed by default) with a tree list to make things a bit smoother for users:

Get started - Opens the docs
Become a patron - Open GitHub Sponsors page
Review issues - Open GitHub issues
Raise an issue - Open GitHub issue creation with prefilled info about the system<EMAIL_ADDRESS>Get premium support - Open GitHub Sponsors page


Running command: cmake --build Debug

I'm probably missing some basics. When I do :CMakeBuild mytarget the plugin runs cmake --build Debug mytarget, which is basically the wrong command line parameters for running CMake. I'm expecting something like this: cmake --build <build-directory> [--target <target>]

Hi, this is not the expected behavior indeed. But I can't reproduce your issue without additional context and info. Can you please provide the following?

Steps to reproduce the issue
Observed behavior, with a screenshot if necessary
OS
Vim/Neovim version
Vim-CMake version (:echo cmake#GetInfo().version)
CMake version (cmake --version)

Closing due to inactivity


[SPARK-11476] [DOCS] Incorrect function referred to in MLib Random data generation documentation

Fix Python example to use normalRDD as advertised

Merged build triggered.

Merged build started.

Test build #45261 has started for PR 9529 at commit ee5c6e2.

Test build #45261 has finished for PR 9529 at commit ee5c6e2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

This seems like such a straightforward doc fix that I'm going to merge it.

Merged to master/1.6/1.5


Nullify users foreign key on delete for timeline_entries

This change alters what happens when a user is deleted. Previously, a
user could not be deleted if they had timeline_entries. Now, users_id
gets set to null on deletion of a user.
This enables us to remove users from the system without having errors
related to database relations.

Yep it got me! & I've now made the migration reversible.


Improve release data shortcode

Fix HTML for release-data shortcode

Add support for a releaseDate field for minor versions, allowing us to publish a release date even when no patch releases are out

Implement localizable date formats for release data.
A localization can now customize release_date_format to set the Golang date format string appropriate for their locale.

[preview]
/area web-development
/sig release

Thank you, @sftim! This looks good to me!
/lgtm

/approve


Shopping cart

This looks really good.  The only big complaint I have is they're all in one feature.  Divide them up a bit.  Quantity adjustment isn't the same "feature" as shipping estimates, etc.  No resubmission necessary.


Azure.Core feature template

Proposed Issue template for Azure.Core features.

@annelo-msft I think you can switch the view in the review pane and see that rendered markdown for this PR.

I think it looks good!

Thank you @AlexGhiondea!!

/enforcer override

/check-enforcer override


(GH-170) Globalisation/Localisation

moving all neccessary strings to resx.
(translation from English to other languages in follow-up issues)

the automatic language selection / some kind of dropdown for language selection (maybe in settings?) is still missing - open for any Ideas how / where to implement.

Should we default to the current user Locale, with an option to change?

I'd say that's the preferred way, yes

German localization on the way: https://github.com/mwallner/ChocolateyGUI/tree/feature/localization_de - where should we set the 'CultureInfo' ?

CultureInfo should get pulled automagically from the user's machine. It shouldn't, in theory, need to be set. There are ways to override an applications culture on startup if we want to add a manual override though.

For more deets: https://msdn.microsoft.com/en-us/library/system.globalization.cultureinfo.currentuiculture(v=vs.110).aspx

I'll make sure I add strings for all future work, as well as go through and make sure all error messages have Resx sources.


[MODEL EVALUATION REQUEST] ReBatch/Reynaerde-7B-Instruct

Model ID
ReBatch/Reynaerde-7B-Instruct
Model type
Decoder model (e.g., GPT)
Model languages

[ ] Danish
[ ] Swedish
[ ] Norwegian (Bokmål or Nynorsk)
[ ] Icelandic
[ ] Faroese
[ ] German
[X] Dutch
[ ] English

Merged model
Not a merged model

Results live on the leaderboards now!


Add ability to auto-detect ACM certificates by best-match

Start from the Use-case
I would like to use lift to expand my existing backend repository running on Serverless/Bref to include my frontend webpack SPA as well. Currently, I use a combination of shell scripts and serverless plugins to make this happen. However, I would like to be able to utilize Lift to reduce my dependence on pre-existing cloudfront distributions, route53 records, and ACM certificates. This would decrease the footprint of infrastructure not currently covered by code significantly and pull more of that into a single solution, the serverless framework. I use the serverless-certificate-creator plugin to create custom ACM certificates. However, when referencing the output of the plugin in the construct for my frontend application, I recieve the following error:
Invalid configuration for the static website 'frontend': if a domain is configured, then a certificate ARN must be configured in the 'certificate' option. See https://github.com/getlift/lift/blob/master/docs/static-website.md#custom-domain
service: myService
plugins:
  - serverless-certificate-creator
  - serverless-lift

constructs:
  landing:
    type: single-page-app
    path: ${param:frontendDist}
    domain: ${param:domainName}
    certificate: ${certificate(${self:custom.customCertificate.certificateName}):CertificateArn}

params:
  default:
    domainName: ${self:service}.${sls:stage}.acme.com
    frontendDist: vendor/myService-frontend-Repo/myService-frontend/dist
  dev:
    frontendDist: ${env:FRONT_END_DIST, "vendor/roundingwell/care-ops-frontend/dist"}

custom:
  customCertificate:
    certificateName: ${param:domainName}
    hostedZoneNames: ${param:domainName}
    subjectAlternatives:
      - '*.${param:domainName}'

I think a very simple workaraound for this would be copying the style of the serverless-domain-manager plugin certificateName parameter which attempts to make a best effort assumption about which certificate to use based on the domain name based on the closest match by default.

The name of a specific certificate from Certificate Manager to use with this API. If not specified, the closest match will be used (i.e. for a given domain name api.example.com, a certificate for api.example.com will take precedence over a *.example.com certificate).Note: Edge-optimized endpoints require that the certificate be located in us-east-1 to be used with the CloudFront distribution.

Example Config
landing:
    type: single-page-app
    path: ${param:frontendDist}
    domain: ${param:domainName}

Implementation Idea
This is copied directly from the serverless-domain-manager plugin source
 private async getCertArnByCertName(certificates, certName): Promise<string> {
        // note: we only check DomainName, but a future enhancement could
        // be to also check SubjectAlternativeNames
        const matches = certificates.filter((certificate) => (certificate.DomainName === certName));
        for (const certificate of matches) {
            const certificateArn = certificate.CertificateArn;
            const details = await throttledCall(
                this.acm,
                "describeCertificate",
                {CertificateArn: certificateArn},
            );
            const currNotAfter = details.Certificate.NotAfter;
            if (Date.now() < currNotAfter) {
                Globals.logInfo(
                    `Selecting cert with ARN=${certificateArn} with future expiry (${currNotAfter.toISOString()})`
                );
                return certificateArn;
            }
            Globals.logInfo(
                `Ignoring cert with ARN=${certificateArn} that is expired (${currNotAfter.toISOString()})`
            );
        }
    }

👍  that would indeed be a great improvement! Feel free to send a pull request. If you do copy code from the plugin, remember to add a @copyright annotation in jsdoc.


[C++][Parquet]  ScanFileContents reports wrong row count for nested columns

Reporter: Uwe Korn / @xhochy
Assignee: Uwe Korn](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=uwe) / @xhochy
PRs and other links:

GitHub Pull Request #457

Note: This issue was originally created as PARQUET-1272. Please see the migration documentation for further details.

Antoine Pitrou / @pitrou:
Is this the same as PARQUET-1269 ?

Uwe Korn / @xhochy:
Yes, it is. I did miss that when looking for similar issuses.

Uwe Korn / @xhochy:
Issue resolved by pull request 457
https://github.com/apache/parquet-cpp/pull/457


Update grammar in PR documentation #45170

Updated the Grammar in PR Documentations as mentioned  in below issue :
https://github.com/freeCodeCamp/freeCodeCamp/issues/45170
Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Here i made changes of below  issue :
Congratulations! is being parsed as a separate sentence. This is grammatically incorrect anyway and i update it.

Hey @Jagroop2000
This PR seems to make similar changes as the existing PR #45174. As such, we are going to close this as duplicate.
If you feel you have additional changes to expand upon this PR, please feel free to push your commits and request this PR be reopened.
Thanks again! 😊

If you have any questions, feel free to ask questions on the 'Contributors' category on our forum or the contributors chat room.


Forc deploy should support (and enhance the userflow while) using proxy contracts

We have an rfc: https://github.com/FuelLabs/sway-rfcs/pull/39 that describes the desired behaviour.  Basically we want forc-deploy to be aware of contracts with proxy contract requirements and support deploying a proxy contract automatically if it is enabled. If no proxy contract was already deployed for the contract we will deploy a new "default" proxy implementation. Otherwise we will update the already deployed proxy contract.

Blocked on fuel-core 0.27 upgrade in sway

Blocked on https://github.com/FuelLabs/fuels-rs/pull/1396

closed by #6069


Unable to login with the new experience

Describe the bug
I updated from 2.0.35 to 2.0.40 and now the az login behaves differently and is unable to sign me in.
I run az login, the browser is being opened, I select my account and see the success message:
You have logged into Microsoft Azure!
You can close this window, or we will redirect you to the Azure CLI documents in 10 seconds.

However in the terminal I see an error:
❯ az login
Note, we have launched a browser for you to login. For old experience with device code, use "az login --use-device-code"
[3186:3186:0702/202752.046404:ERROR:sandbox_linux.cc(378)] InitializeSandbox() called with multiple threads in process gpu-process.
Created new window in existing browser session.
Get Token request returned http error: 401 and server response: {"error":"invalid_client","error_description":"AADSTS70002: Error validating credentials. AADSTS50012: Invalid client secret is provided.\r\nTrace ID: c0834499-922a-445c-87f8-f88d70282700\r\nCorrelation ID: b3e6c2b1-c381-4f1f-aa84-f794c2894056\r\nTimestamp: 2018-07-02 18:27:56Z","error_codes":[70002,50012],"timestamp":"2018-07-02 18:27:56Z","trace_id":"c0834499-922a-445c-87f8-f88d70282700","correlation_id":"b3e6c2b1-c381-4f1f-aa84-f794c2894056"}

What kind of client secret is it talking about?
Luckily the old experience is still present, and when I use az login --use-device-code, I am able to successfully log in.
Environment summary
OS: Latest Arch Linux
Shell: zsh
Install method: AUR/python-azure-cli with AUR/python-azure-git

The output of az --version
❯ az --version
azure-cli (2.0.40)

acr (2.0.28)
acs (2.1.2)
advisor (0.5.1)
ams (0.1.1)
appservice (0.1.36)
backup (1.1.2)
batch (3.2.4)
batchai (0.3.1)
billing (0.1.8)
cdn (0.0.14)
cloud (2.0.15)
cognitiveservices (0.1.13)
command-modules-nspkg (2.0.1)
configure (2.0.17)
consumption (0.3.1)
container (0.2.0)
core (2.0.40)
cosmosdb (0.1.21)
dla (0.1.0)
dls (0.0.22)
dms (0.0.1)
eventgrid (0.1.12)
eventhubs (0.1.3)
extension (0.1.0)
feedback (2.1.3)
find (0.2.11)
interactive (0.3.24)
iot (0.1.21)
keyvault (2.0.23)
lab (0.0.22)
maps (0.2.0)
monitor (0.1.8)
network (2.1.5)
nspkg (3.0.2)
policyinsights (0.1.0)
profile (2.0.27)
rdbms (0.2.5)
redis (0.2.14)
reservations (0.2.1)
resource (2.0.32)
role (2.0.26)
servicebus (0.1.2)
servicefabric (0.0.12)
sql (2.0.27)
storage (2.0.35)
vm (2.0.35)

Python location '/usr/bin/python'
Extensions directory '/home/maximbaz/.azure/cliextensions'

Python (Linux) 3.6.5 (default, May 11 2018, 04:00:52)
[GCC 8.1.0]

Legal docs and information: aka.ms/AzureCliLegal

CLI doesn't really support Arch Linux(at least we never maintained and tested it).
This error means the adal is too old that it still puts none secret in the token request payload instead of omitting it for public clients. Please let the Arch Linux maintainer update the "python-azure-cli" to use newer version.
At the same time, there are nothing we can do, so I am closing this.
//CC: @troydai

Thank you!
The biggest challenge with maintaining Arch Linux package for azure-cli is the amount of dependencies to keep track of (they all should be published as separate packages, e.g. now I marked python-adal as outdated), and at the same time there are no packages yet for modules within azure-sdk (currently only python-azure-git exists, which is a hack, it clones the entire repo and installs everything from master branch.
Currently the Arch Linux packages are all being maintained by @optlink (their account contains email address for communication). If you are considering to provide official support, I've seen other companies just adopting the existing AUR packages for their products (basically getting write permissions), and I recommend doing the same — I'm sure @optlink will be happy to assist. That way, you are only left with just bumping the versions in time (package + dependencies), which would be a great help to the community (and for bonus points, if you split python-azure-git into multiple packages that also follow official releases instead of master branch, that would be even more awesome).
I can also help if you need anything.


Edit

Description
enhanced dark as well as white UI.
(Write your answer here.)
Checklist

[x] I am making a proper pull request, not spam.
[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
(Write your answer here.)
Add relevant screenshot or video (if any)
https://user-images.githubusercontent.com/103804567/195982965-8f692089-ffb4-4200-a800-e1aee15d217c.mov
(Add here)

@wasimreja I've tried to enhance the UI light as well as dark please check it out.

leave it. many changes need to de done. color palette is not quite up to par


File format restriction

Hi,
I have to restrict dropzone to accept only specific file formats instead all formats. I'm not able to find any option or props that says only accept these file formats.
Can anyone please help to resolve this?
Appretiate your help in advance

You can specify it in the configuration object https://www.dropzonejs.com/#config-acceptedFiles


Add CI/CD workflows.

Workflows have been created for the following purposes:

Build package and test with different Python versions and systems
Lint code and check coding styles
Analyse static code with SonarCloud

Workflows to be added:

documentation
citation
publishing


Unable to open CTRL/F2 menu in Microsoft Flight Simulator

Unable to open CTRL/F2 menu
Unable to change settings
OpenXR layer active
Runtime : VarjoOpenXR.json
MSFS2020 : activated in openXR toolkit
Modifyer : CTRL
LogFile:
[OXRTK] 2023-02-23 15:26:04 +0100: OpenXR Toolkit - GA-2 (v1.2.4)
[OXRTK] 2023-02-23 15:26:04 +0100: dllHome is "C:\Program Files\OpenXR-Toolkit"
[OXRTK] 2023-02-23 15:26:04 +0100: OpenXR-Toolkit layer is active
[OXRTK] 2023-02-23 15:26:04 +0100: Bypassing OpenXR Toolkit for application 'FS2020', engine 'Zouna'
End...
System :
MB : Gigabyte Aorus Master
Processor : I9-13900k
Memory : 32GB
Graphics card : Gigabyte RTX 4090 Gaming OC
VR  : Varjo Aero

That doesn't look like the full log. Can you please upload the entire log file?

Sorry, I misread the bit you paste.

[OXRTK] 2023-02-23 15:26:04 +0100: Bypassing OpenXR Toolkit for application 'FS2020', engine 'Zouna'

This means you disabled OpenXR toolkit in the Companion app.
The checkbox for "FS2020" must be checked, not unchecked.

Thank you for your reply,Issue solved.Grts. KeesKees @.*** 27 feb. 2023 om 10:32 heeft Matthieu Bucchianeri @.***> het volgende geschreven:
Sorry, I misread the bit you paste.
[OXRTK] 2023-02-23 15:26:04 +0100: Bypassing OpenXR Toolkit for application 'FS2020', engine 'Zouna'
This means you disabled OpenXR toolkit in the Companion app.
The checkbox for "FS2020" must be checked, not unchecked.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>


I have paused and resumed the schedule. after resuming a schedule using jobScheduler.resumeJob(new JobKey(schedule.getName(), groupId))  I am getting two entries i.e. one of autorun and one of misfired  even though there were number of triggers available between pause and resume. I already tried updating the start time and nextFireTime. So what can be the solution to resolve this issue, so that I must get the nextFireTimeTriggers only which are after the current time?

Hi @newujwalagit, I am not a developer of this project (just a user like you) but could you edit your issue so that it has a short title and a descriptive description? Thank you!


Paper

Hi RNAbioco team,
There is a general concern comparing scRNA and bulk RNA data, because of their very different nature (either on different laboratory protocols, different normalizations, etc). I have tried clustifyR and it works fine for me - I can compare the two types of data, successfully. However, this software operates as a black box for me, and so I was wondering if there is any paper associated with clustifyR, to clarify some ideas.
Thank you

Hi, thank you for your interest. We have finally put out a preprint, here:
https://www.biorxiv.org/content/early/2019/11/26/855064.full.pdf
In short, it is doing ranked correlation on cluster average expression. For general use, it works decently.
Please let us know if you have other comments and suggestions.


Fixed Capsule Implementation

Summary
Modified past version of the "cifar10_cnn_capsule.py" so that it works with the latest version. TF/Keras changed the batch_dot implementation, so this version skips batch_dot in favor for an included "caps_batch_dot" function.
Related Issues
Relies on tf.matmul, because K.dot modifies the dimensions, due to the Numpy implementation.
PR Overview

[ n  ] This PR requires new unit tests [y/n] (make sure tests are included)
[ y (examples) ] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[ y ] This PR is backwards compatible [y/n]
[ n ] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

Added comments broke documentation rendering.


This is awesome

No issue to report, just want to say thanks for releasing this project. This thing is awesome, super helpful.

Glad you like it! Thanks for commenting. :smile:


Update vpn-gateway-radiuis-mfa-nsp.md

Typos.

@marcelodiiorio : Thanks for your contribution! The author(s) have been notified to review your proposed change. @ahmadnyasin

Verified the updates.

@marcelodiiorio - Thanks for the fixes.


Create tap device virt handler with tap library

What this PR does / why we need it:
Currently, libvirt is responsible for creating & configuring the tap devices that will be used by the kubevirt VMs. As such, virt-launcher pods require the NET_ADMIN capability.
This PR moves the tap device creation / configuration stage to the virt-handler pod, which will create / configure the tap devices on behalf of the virt-launchers (and in their netns).
To allow a non-privileged libvirt to consume a pre-configured tap device, the kubevirt's VM domxml specification has to be updated.
Which issue(s) this PR fixes :
Partially fixes #3085
Special notes for your reviewer:
Will use this PR to tinker an alternative to #3290
WIP
Expected to fail; the tun_socket is being created w/ the spc_t socket, which will trigger libvirt relabeling.
Release note:

NONE

@maiqueb is this one still needed?

Abandoning since #3290 is the preferred option.

It triggers this issue:
https://github.com/kubevirt/kubevirt/issues/4088
Is that a bug? Or kubevirt slave node should configure SELinux to permissive or enforcing?


Cache data in a singleton class not on the node

Avoid polluting the node with more junk.
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

@lamont-granquist This passes the kitchen tests locally, but let me know if this is what you had in mind for the caching.

Closing this since we removed the resource from the cookbook


Fix precommit example

Codecov Report
Base: 96.65% // Head: 96.65% // No change to project coverage :thumbsup:

Coverage data is based on head (ea0103d) compared to base (32d4a74).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #768   +/-   ##
=======================================
  Coverage   96.65%   96.65%
=======================================
  Files          24       24
  Lines        3197     3197
=======================================
  Hits         3090     3090
  Misses        107      107

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


embed-environment-variables is not available

When running npx embed-environment-variables as stated in the Dockerfiles in this repo https://github.com/garronej/cra-envs-demo-app, I got the following error:

Thank you for reporting

Hi @mrtruongminh,
I attract your attention over the fact that you can only run npx embed-environment-variable if cra-envs is present is installed wether globally or locally.
When it is run in the entrypoint it works because it have been previously installed globally.
If you want to run it in a single line you can do:
npx -y -p<EMAIL_ADDRESS>embed-environment-variables
however, be sure to enforce that you use the same version of cra-envs in your code (import { ... } from "cra-envs") and when you run npx embed-environment-variables.
Best regards


Do not put if on the same line as match arm

cc https://github.com/rust-lang-nursery/fmt-rfcs/issues/61, #1791.
Please feel free to keep this open and umerged if necessary.

@nrc Do you have any thoughts on this PR?

Hmm, I'm not sure, and I don't think we really decided on the style team.  @rust-lang-nursery/style what do you think? (I found it useful to look at the second commit to get a feel for the change).

Honestly, both approaches seem fine to me. I don't have a problem with the previous formatting, and in shorter cases it looks better to me, while in longer cases it doesn't.
I think this ties back into some of the discussions about when to fold things onto the same line, regarding issues like prefixes and suffixes, and ease of scanning.

For me, the previous formatting is in some cases definitely nicer and more concise. The new formatting is obviously more verbose and induces unfortunate rightward drift, but at the same time I find it to be a clear win when it comes to readability and writeability.
Readability
The following, in my opinion, is quite unreadable. I've been living with this style for quite a while now, and still haven't been able to get accustomed to it.
match part {
    NumberPart::OpenParen => if c != '(' {
        return IssueClassification::Bad(issue);
    } else {
        part = NumberPart::Pound;
    },
    NumberPart::Pound => if c == '#' {
        part = NumberPart::Number;
    },
    NumberPart::Number => if c >= '0' && c <= '9' {
        part = NumberPart::CloseParen;
    } else {
        return IssueClassification::Bad(issue);
    },
    NumberPart::CloseParen => {}
}

When quickly skimming over the code, my mind just can't decide which lines are pattern-matching, and which lines are else if/else blocks. Even this example is not that bad because it doesn't have too much code, but when pattern-matching over the current state in a complex state machine, it easily gets out of hand.
On the other hand, simpler cases (e.g. those with a single if without else) are perfectly readable, though:
match lorem {
    Lorem::Ipsum => if ipsum {
        println!("dolor");
    },
    Lorem::Dolor => println!("amet"),
}

This looks better than the newly proposed style (concise and no rightward drift!). However, I think it is still a net loss because it impairs writeability. Hear me out.
Writeability
Suppose that we want to print the value of ipsum before the if:
match lorem {
    Lorem::Ipsum => {
        debug!("Matched on the Ipsum case. ipsum = {}", ipsum);
        if ipsum {
            println!("dolor");
        }
    },
    Lorem::Dolor => println!("amet"),
}

This a lot of manual work to add just a single debug! statement, not to mention the sudden visual change. You have to manually add braces, make sure you don't mess up the comma (the closing if-brace had a trailing coma before, but now it doesn't!), and reindent the code (either manually or by hitting Ctrl+S or whatever to make rustfmt kick in).
However, if we had started with what this pull request is proposing, adding a simple debug statement would be a trivial visual change and a trivial change when it comes to typing code:
match lorem {
    Lorem::Ipsum => {
        if ipsum {
            println!("dolor");
        }
    }
    Lorem::Dolor => println!("amet"),
}

Ergonomics and formatting
With all the exciting ergonomics improvements that are coming to Rust this year, I die a little inside when a simple formatting rule adds unnecessary friction to quick debugging and prototyping. :)
While it's clearly visible how this pull request affects readability of code, please also consider the angle of writeability. Rustfmt is an important tool in making Rust easier to write, and I think this pull request will push it a little bit further in that direction.

I rebased and resolved conflicts. As @stjepang nicely stated in the comment, I think the benefit outweighs the verbosity here.

Hmm, I'm still not convinced by the arguments in favour of this change. In particular the change from a non-block to a block match arm happens all the time with lots of different expressions, and this just tackles one kind of those expression, and not one which is particularly common, so I don't put much weight on that.
So this comes down to whether we find the compressed version or brace-happy version more readable. Here, I agree with @stepancheg I think this change makes large blocks better, and small ones worse. I personally come down weakly on the side of not making the change, but that is pure subjective opinion. So, let's and this for now and see how we feel about it in practice (I often feel better once I'm familiar with a new style, and/or others may like it less).

@nrc

In particular the change from a non-block to a block match arm happens all the time with lots of different expressions, and this just tackles one kind of those expression, and not one which is particularly common, so I don't put much weight on that.

It's definitely subjective - hard to say why, but the match { pattern => if condition { combination is the only one that I personally find uncomfortable in practice. It could just be the codebases I work with, dunno (it's crossbeam-epoch in particular).
I feel I might have come off somewhat strongly opinionated on this particular formatting style, so apologies if I'm getting tiresome. Just to fully clarify, I'd be okay with some kind of compromise if you decide to revert this style in the end. But if there is one thing I'm really strongly against, it would be this:
match foo {
    pattern => if cond {
        // ...
    } else {
        // ...
    }
}

Everything else is tolerable. Even this example would look okay without the else block, as far as I'm concerned.
Thanks for giving this style a shot!


Update SyncLists.md

Cleaned up type list and indentations / formatting
Added comment about using OnStartClient vs Start

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[3.x] Implement file provider capabilities

The previously used file sharing api was restricted after Android N causing the engine to crash whenever used on devices running Android N or higher.
main version

Thanks!

Cherry-picked for 3.5.3.


Add notifications for crafting items using the Forge or Assembler

This PR adds a new feature which will notify you when your items have finished crafting.
This adds an icon in the server list when things are ready:

A popup once it finishes and you are online on MCC Island

And a command /crafting to show the time remaining on all your crafts!

For the most part this feature is done, just needs some more testing and it's ready to merge!

Is the last image still up to date? The "Completed" time shouldn't be red imo

ngl i don't know why i didn't put it in another colour lmao, i'll fix that rq


Make Bash completions POSIX compliant

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

Update Bash completions to make them compatible with POSIX mode.
Related to #14643

Technically, the most straightforward solution that works in POSIX and non-POSIX modes without the "while" beauty is:
COMPREPLY=($(compgen -W "${list}" -- "${cur}"))

But brew style complains about ☝🏻:
^-- SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting).

Word splitting is exactly what we want, so we don't want to "quote" anything. The former of the suggested solutions (mapfile) is not available in Bash 3.2. So, below is a (the?) solution that uses read -a and, in my tests, works in POSIX mode. Though, to be fair, I tested in Bash 5 only.
IFS=$'\n' read -r -d '' -a COMPREPLY <<< "$(compgen -W "${list}" -- "${cur}")"

Review period will end on 2023-02-17 at 18:54:27 UTC.

Review period ended.

@maxim-belkin Is this still needed?

@maxim-belkin Is this still needed?

Well, I'd love to say "definitely yes", but, unfortunately, I cannot be the sole judge of the merit of the change since I am the one proposing it. I believe it is worth discussing whether Homebrew can support POSIX-compliant interactive Bash shells. Given the infrequent updates to these files, I do not anticipate it would pose any burden on maintainers.

I believe it is worth discussing whether Homebrew can support POSIX-compliant interactive Bash shells.

Ok, if this is the only scope here: given we already handled the bug I think the answer is a clear "no". Thanks anyway!


Double Check Wrapping Behavior of Timers

Several functions include blocking behavior or generally deal with timers - double check them for the wrapping behavior of the timers
Also note that the timers on different targets have different bit-widths

We are now using esp_hal::time::current_time under the hood which should wrap earliest every 7 years (depending on the target). There is still some code to cleanup but I guess we can close this


Use SourceSets alone to configure input .java files

Need to do PR #109 first.
Use SourceSets alone to configure input .java files

Translation takes main and test java sourceSets
Translation can be filtered using j2objcConfig.translatePattern
Test takes test java sourceSet
Test execution can be filtered using j2objcConfig.testPattern
Cycle finder is analogous to translation.
Also makes translation dependent on all possible input files.
Prohibits incremental translation with --build-closure.

Fixes #57
Fixes #52
Fixes #95

alright, after this PR goes in, I think I'm done with basically important stuff I'm responsible for at the milestone.  grouped various fixes here for my ease.

Also @confile  and @brunobowden please test this thoroughly esp. the cycleFinder and xcode tasks (I don't use them at all).  translation, compile, and test all seem to be pretty solid, with incremental builds, up-to-date checks, etc. etc.

Hi @advayDev1,
Thanks for all these changes. It's wonderful to get so much of this cleaned up. I've done my initial round of comment which I think should be pretty comprehensive.

Thanks @brunobowden - some changes completed, some changes replied to.
If you merge in #109, I'll rebase/squash this one to make changes clearer.

oh cool, you did merge #109 - one second while i do the rebase/squash...

great, ptal

@advayDev1 - please respond to this last round of comments and then I'll merge it in

@brunobowden  ptal


Redirect user to home upon sign out from lock screen

Right now they remain on the lock screen which is inconsistent with having no session anymore

Just ran into this, and if you try to sign out again you get this error...


Deps optimization at build time did not tree-shaking

Describe the bug
When i using deps optimization at build time, looks like it was not tree-shaking
Reproduction
https://github.com/windsonR/my-vue-app
Steps to reproduce
In reproduction, i use ant-design-vue to reproduce this.
Run pnpm install then pnpm build
Then, in dist/index.*.js search AInput or ATable
System Info
System:
    OS: macOS 13.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 92.09 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 16.20.2 - ~/.n/bin/node
    Yarn: 1.22.19 - ~/.n/bin/yarn
    npm: 9.8.1 - ~/.n/bin/npm
    pnpm: 8.6.10 - ~/.n/bin/pnpm
  Browsers:
    Firefox Nightly: 118.0a1
    Safari: 16.6
  npmPackages:
    @vitejs/plugin-vue2: ^2.2.0 => 2.2.0
    vite: ^4.4.5 => 4.4.5

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

I see rollup and esbuild don't tree-shaking either, may be this issue is not related to vite.
a fork with rollup and esbuild


[PE-D][Tester A] Multiple as/ keywords allowed in apply command

When multiple as/ are added, only the last one is taken and the rest are ignored. I think this should be mentioned in the user guide for users to see if it is the intended behavior. But, I think this was not the intended behavior so it may confuse the users as they may think that they can add multiple statuses together.
Eg. apply 1 n/ rl d/appliedddd!!  as/rejected as/oa as/accepted
Screenshot 2024-11-08 at 3.25.42 PM

Labels: severity.Medium type.FunctionalityBug
original: Raghava-Chittidi/ped#15

Duplicate of #235


Increase movement player range

Player movement range is limited to around 30 degrees of the circle and the ball sometimes gets stuck bouncing where neither player can reach it. To fix this, we need to increase the player movement range and the goals to 90-120 degrees.

I think this will likely fix this issue: I think this is a better alternative: https://github.com/L2CS/smol-untitled-pong-game/issues/18


are we london fork ready?

Is your feature request related to a problem? Please describe.
with London fork on the horizon, are we ready for the fee API change?
if I understand it correctly. we just need to add two new API s to set the base fee and tip fee. right?

Need #265 for the new transaction type.

Closing, dup of #265


Cannot upload in laravel

When i upload image in laravel 5.4  it say TokenMismatchException
What to do?

http://unisharp.github.io/laravel-filemanager/integration#option-1-ckeditor
Integrate with csrf tokens.

thanks it works


Your requirements could not be resolved to an installable set of packages.

composer create-project --prefer-dist yiisoft/yii2-app-basic basic
Installing yiisoft/yii2-app-basic (2.0.0)

Installing yiisoft/yii2-app-basic (2.0.0)
Loading from cache

Created project in basic
Loading composer repositories with package information
Installing dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Installation request for yiisoft/yii2 * -> satisfiable by yiisoft/yii2[2.0.0].
- yiisoft/yii2 2.0.0 requires bower-asset/jquery 2.1.@stable | 1.11.@stable -> no matching package found.
Problem 2
- Installation request for yiisoft/yii2-bootstrap * -> satisfiable by yiisoft/yii2-bootstrap[2.0.0].
- yiisoft/yii2-bootstrap 2.0.0 requires bower-asset/bootstrap 3.2.* | 3.1.* -> no matching package found.
Problem 3
- Installation request for yiisoft/yii2-gii * -> satisfiable by yiisoft/yii2-gii[2.0.0].
- yiisoft/yii2-gii 2.0.0 requires bower-asset/typeahead.js 0.10.* -> no matching package found.
Problem 4
- yiisoft/yii2 2.0.0 requires bower-asset/jquery 2.1.@stable | 1.11.@stable -> no matching package found.
- yiisoft/yii2-faker 2.0.0 requires yiisoft/yii2 * -> satisfiable by yiisoft/yii2[2.0.0].
- Installation request for yiisoft/yii2-faker * -> satisfiable by yiisoft/yii2-faker[2.0.0].
Potential causes:

A typo in the package name
The package is not available in a stable-enough version according to your minimum-stability setting
see https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion for more details.

Read http://getcomposer.org/doc/articles/troubleshooting.md for further common problems.

@samdark The guide doesn't mention composer global require "fxp/composer-asset-plugin:1.0.0-beta4"
but just 1.0.0.
The current version 1.0.1 is fine.

it does not really matter but guide should be updated.


fix: Cannot access 'renderer' before initialization. (#420)

The value of 'authjs' was hard coded in the file at :
@sidebase/nuxt-auth/dist/runtime/server/services/authjs/nuxtAuthHandler.mjs generating an error whenever auth.provider.type = 'local' was used.
This fork's aim is to fix this issue.

The typecheck failed to execute itself on codes not related to the issue.
It means that someone, somehow, pushed an un-typechecked code...
Making this merge request, difficult to proceed.
https://github.com/sidebase/nuxt-auth/actions/runs/5724583013/job/15514116059?pr=490
... Do I attempt to refactor the following files:
1  src/runtime/composables/commonAuthState.ts:36
2  src/runtime/helpers.ts:31
3  src/runtime/middleware/auth.ts:51
2  src/runtime/plugin.ts:16
5  src/runtime/server/services/authjs/nuxtAuthHandler.ts:23
2  src/runtime/server/services/utils.ts:19
1  src/runtime/utils/url.ts:56

Or do I wait for someone else to do it?

@Eternal-Grace,
I have managed to identify the issue! When you added support for different provider types, the useConfig() function could either return the authJS or local schema. The local schema, however does not include properties such as trustHost, leading to the type issues.
I assume you would need to add some checks to ensure that the code for authJS only runs when the selected providor is authjs.
See example here: https://github.com/GenitusTech/nuxt-auth/blob/main/src/runtime/server/services/authjs/nuxtAuthHandler.ts#L80

@zoey-kaiser
Ok, it is done. Can you approve, so that we can proceed?
( https://github.com/sidebase/nuxt-auth/pull/490/commits/8a1866d6fc9f4857cf128433ffb69b14c17344e7 )

Lets see if the two changes I recommended would work!

Thanks for the changes. Now, let's hope this "Bug Arc" comes to an end at last =_=)

Danm! This is beyond stressful: https://github.com/sidebase/nuxt-auth/actions/runs/5870155610/job/15938032936?pr=490
Job failed, once again. -_-')
Any suggestions @zoey-kaiser ?

Danm! This is beyond stressful: sidebase/nuxt-auth/actions/runs/5870155610/job/15938032936?pr=490 Job failed, once again. -_-') Any suggestions @zoey-kaiser ?

Ill have to play around with it a bit myself! I don't have time today, but ill try and give it a shot tomorrow.

@Eternal-Grace, please see my comment https://github.com/sidebase/nuxt-auth/issues/420#issuecomment-1757373955 on how we can continue working on your problem.
For now, I will close this PR, as I think we approached this issue incorrectly! If you are still interested in working with me to resolve this, please open a new issue with more details about the issue you ran into + logs and I will look into another solution!


Various unit tests

Codecov Report

Merging #245 (bd824d4) into main (cd7bc94) will increase coverage by 0.29%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   59.91%   60.20%   +0.29%
==========================================
  Files          75       75
  Lines         676      676
  Branches      200      200
==========================================
+ Hits          405      407       +2
+ Misses        258      256       -2
  Partials       13       13

Impacted Files
Coverage Δ

.../lib/features/like-episode/api/favourites-table.ts
100.00% <0.00%> (+25.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd7bc94...bd824d4. Read the comment docs.


Switch to github container registry

Upload/use the container images to/from the project-wide registry. This also removes the Gitlab configuration since it becomes obsolete.

Seems to work as expected. See CI jobs in acts-project/acts#460.


Deploy workflow queued, not starting

Workflows should take a minute, not for ever:

https://github.com/frdedynamics/hvl_robotics_website/actions
Looks like there will be some queue today:

https://www.githubstatus.com/
Alternative: self-hosted runners, probably not worth the extra maintenence.

green again

github status not green yet, will close when green there also.


npm test & open demo page 404 error

Hi ,
When I try to build the project as follow steps and occur an issue as the screenshot.

npm run install & npm run build
npm test
visit demo/lint.html page then occur the error as follow

Do npm install, not npm run install.

Hi marijnh,
Do npm install && npm run build also occur the error(404). I think it's not the reason cause the issue.

Works for me. Though note that the error has absolutely nothing to do with you visiting demo/lint.html, and I am wondering why you described it that way. That looks like output from npm test.
Which node/npm version are you on?

Sorry~~, demo/lint.html  just for an example page, others pages under demo folder also occur the issue. Actually i also can show the page normally but after visit the page the node server throws the  404 error which make the node server crashed...

Node version: v7.0.0

npm test runs the test suite, it doesn't start a server you can use from your browser. To view test pages, just open them using the file: protocol.

 Sorry for wasting your time and thanks for your patient reply.


Create vouchers with custom name

Is there a way to use custom naming to vouchers? I tried using with character but it's shuffling the input character and also tried voucher generate but it is not creating voucher and throwing Call to a member function create() on string

@735l4 yes, you can create a voucher using the model directly:
$voucher = Voucher::create(['code' => 'FREEPIZZA2021']);

That's great didn't knew it was there would be helpful if you included this readme because it is very essential feature imo.

@735l4 sure thing, I'll add that to my list of tasks :)

How do I add amount to it and also I'm confused on how redeem works too I checked the model and I don't see fillable for amount. I checked the docs and only the Facades docs are clear to me. Sorry if it's too obvious i'm just confused

@735l4 can you explain to me what you want to achieve, and how you want to use the vouchers?
Then I'll try my best to explain it to you, or note what documentation I'm missing.

I'm trying to make an food delivery app voucher campaign so I want to generate custom vouchers with start and expiry date and given amount so users should be able to redeem it within the given time frame. Also would be helpful if the vouchers are in polymorphic relation to category product and restaurant.

Okay, so you want multiple users to be able to redeem the same voucher? Should they be able to redeem the same voucher more than once? The amount you can store using the metadata property, and related entities can be added using Voucher::addEntities()
You would be able to do something like this:
$restaurant = Restaurant::whereName('PZ1')->first();
$voucher = Voucher::make([
    'code' => 'PZ1-MAY21-100',
    'starts_at' => Carbon::parse('2021-05-01 00:00:00'),
    'expires_at' => Carbon::parse('2021-05-31 23:59:59'),
    'metadata' => ['amount' => 100],
]);
$voucher->owner()->associate($restaurant)->save();
$voucher->addEntities(...Category::where('name', 'LIKE', '%pizza%')->get());

Thanks dude. yea I want multiple user to redeem the voucher but user should be able to redeem it only once

@735l4 I just updated my example to handle the use case, so if you can just test it out and provide feedback, that'll be great :)

It's throwing undefined method exception.
Call to undefined method FrittenKeeZ\Vouchers\Models\Voucher::owner()
Also i'm confused about the event handling. how do i use it

It's throwing undefined method exception.
Call to undefined method FrittenKeeZ\Vouchers\Models\Voucher::owner()
Also i'm confused about the event handling. how do i use it

I fixed it by upgrading the package but still I'm confused with event handling thing. how do i redeem the coupon from the controller.

@735l4 that's explained here


Drive: Rclone doesn't sync Google Docs

Attached is a screen capture of my G Drive showing all the folders and some of the files.

Below is what:
rclone lsd GD: | sort -k 5
shows:
      -1 2014-06-28 09:18:09        -1 CNASALERC
      -1 2013-04-28 17:12:33        -1 Drive Sync Images
      -1 2013-03-20 08:38:03        -1 HandWrittenNotes
      -1 2014-07-03 08:23:16        -1 Health
      -1 2015-04-09 14:01:41        -1 Kathalina
      -1 2015-03-03 00:35:17        -1 LESTp
      -1 2014-08-20 17:11:08        -1 LEV
      -1 2013-03-27 07:53:36        -1 My Tracks
      -1 2014-07-13 07:36:47        -1 PhD_UNSW
      -1 2015-02-21 02:00:25        -1 SMSs
      -1 2014-06-05 08:02:51        -1 Writing
      -1 2015-04-22 11:31:58        -1 video

ie ALL the folders.  Below is what:
rclone copy GD:/ ./
gives:
drwxrws---   3 phil phil      4096 Apr 24 14:05 Drive Sync Images
drwxrws---   2 phil phil      4096 Apr 24 14:10 HandWrittenNotes
drwxrws---   2 phil phil      4096 Apr 24 14:02 Kathalina
drwxrws---   2 phil phil      4096 Apr 24 14:05 LEV
drwxrws---   2 phil phil      4096 Apr 24 14:06 My Tracks
drwxrws---   2 phil phil      4096 Apr 24 14:05 PhD_UNSW
drwxrws---   2 phil phil      4096 Apr 24 14:05 SMSs
drwxrws---   6 phil phil      4096 Apr 24 14:06 Writing
-rw-rw-r--   1 phil phil    151613 Feb 15  2014 AguadoSec02No10_gnote2_3_24pt.pdf
-rw-rw-r--   1 phil phil     44509 Feb 15  2014 JulioSalvadorSagreras_1_p07.pdf
-rw-rw-r--   1 phil phil    123555 Feb 12  2014 Julio_Salvador_Sagreras_Las_Primeras_Lecciones_de_guitarra.xml
-rw-rw-r--   1 phil phil       139 Feb 13  2014 Julio_Salvador_Sagreras_Las_Primeras_Lecciones_de_guitarra_p10_w7.mid
-rw-rw-r--   1 phil phil       652 Feb 12  2014 Julio_Salvador_Sagreras_Las_Primeras_Lecciones_de_guitarra_p2.mid
-rw-rw-r--   1 phil phil   2319437 Feb 20  2012 Report20209_1.png
-rw-rw-r--   1 phil phil   1688514 Feb 20  2012 Report20209_2.png
-rw-rw-r--   1 phil phil       933 Mar  7 14:18 SajeCrt.txt
-rw-rw-r--   1 phil phil     36164 Apr 24 17:45 Screenshot-042415-17:43:36.png
-rw-rw-r--   1 phil phil       602 Feb 16  2014 ssh-dss.txt
-rw-rw-r--   1 phil phil       240 Feb  3 15:19 t.csv
ie missing folders and files.
So between the lsd and the copy commands, something goes wrong . . ideas?
Thanks,
Phil.

Did rclone copy produce any errors?  Drive is a little unreliable sometimes, so you might need to run the copy again.  rclone won't attempt to copy any files it has copied already, so this should be nice and quick.
rclone only copies files at the moment, it doesn't copy google documents as these aren't stored as files in drive (even though they look like they are) - that probably explains the missing things.  rclone won't create local directories it isn't creating any files, but they will show up on rclone lsd.

No - no errors at all. In fact I renamed a Drive file and reran rclone and it only copied the renamed file but nothing else ie it continued to ignore the dirs and files it missed the first time.  I am wondering if this is related problem to a Drive issue that sometimes occurs on Chrome - which makes it look like dirs and files are missing on Drive but are clearly visible either from FireFox or G Drive for Android - but I don't think it is really . .

rclone only copies files at the moment, it doesn't copy google documents as these aren't stored as files in drive (even though they look like they are) - that probably explains the missing things. rclone won't create local directories it isn't creating any files, but they will show up on rclone lsd.

Ah . . that is probably it . . I will check - that will be a problem though of course . . is there a way around that?

There are a couple of problems with rclone downloading google documents.  These are

These files don't have md5sums so the integrity checking rclone does won't work
* possibly could be worked around though by doing a HEAD request on the exportLink
These files can be downloaded using the exportLinks which are exported in the files resource, however they are exported in multiple formats
* should rclone just pick a format to download?

if so how?  User preference?

* The file name is missing its extension - should rclone add a file version with the extension?
* Should rclone download all the formats?
* A quick test indicates that for a document it offers `docx, odt, rtf, html, txt, pdf` formats for export

A quick test indicates that for a document it offers docx, odt, rtf, html, txt, pdf formats for export

If it was me, I would probably default it to ODT - but I guess it would be nice for it to be user configurable.

That should be "OD?" I guess . .

Another thought:
Downloading multiple files or directory(ies) via the Drive I/F automatically invokes zipping up the files / folders - could this be implemented as an interim measure for backing up via rclone? - ie it would be nice to have a scriptable backup procedure for Drive.
Thanks!

Implementing the option to download converted google documents and have them recognized as such on a reverse sync would be a great option (especially for backing up google docs).
Google already has an API for Drive that allows you to specify a file type to download the various google documents:
https://developers.google.com/drive/web/manage-downloads#downloading_google_documents
This has already been implemented in an open source google drive mounting program:
https://github.com/astrada/google-drive-ocamlfuse/wiki/Exportable-formats
I hope this helps...Thanks again for a nice copy program.

Server side copy / move needs to work with docs also

+1 vote for this enchanement
Since I'm just duplicationg data from my Google Drive to local folder, for me would be great at least to
download google documents in any format.

+1 for this feature

FWIW, I just spent about 20 minutes trying to figure out why rclone wasn't working for me. It "wasn't working for me" because all of the things that appear in Google Drive for me are actually from Google Docs. Perhaps this information should be added to the man page, and maybe in the "-v" output?

@mikecentiq both good ideas - I made a ticket about it #250. Sorry for the frustrating time! -- Nick

+1 for Google Docs copy down to txt/pdf/docx/odt, etc.

Hiya - Tim Watts from Kings College (University of) London here.
Really really like rclone - it's a nice "unix way" implementation. Pity about the Google Docs lack of support. My opinion for what it's worth:

I suggest to pick an export format, any format and run with that as soon as possible. That should at least solve 90% of the use cases (I want to back up my Drive etc).

Perhaps adding a config option later to choose a preferred format would be very neat, but I suspect most people would be happy to have something by way of a backup. eg a manual Download bundles a zip with MS compatible files - this is sensible. LibreOffice would also be perfect sensible (as anyone can make use of those files if needs must).

I am not sure how to handle the sync-right followed by sync-left problem (converting file formats to and from a foreign format is bound to break any attempt to checksum) but having a good one way copy would be most awesome!
Bad form on Google IMHO - if they'd made their Drive interface orthogonal, then the action of getting a Google Doc would cause a transparent export to at least a default format and the action of putting it would do the same as "Upload" in the web interface (which is a preference to auto convert or not).
All the best and good luck :)
Tim

Thanks @TimJWatts for getting me out of analysis paralysis!  I have made an implementation which I'll put into the next release unless anyone finds any serious problems with it!
Here is a link to a beta to try
http://pub.rclone.org/v1.26-50-geb8c1b1β/
Note that this doesn't address server side copy or move...
And here are the docs
--drive-formats
Google documents can only be exported from Google drive.  When rclone
downloads a Google doc it chooses a format to download depending upon
this setting.
By default the formats are docx,xlsx,pptx,svg which are a sensible
default for an editable document.
When choosing a format, rclone runs down the list provided in order
and chooses the first file format the doc can be exported as from the
list. If the file can't be exported to a format on the formats list,
then rclone will choose a format from the default list.
If you prefer an archive copy then you might use --drive-formats pdf, or if you prefer openoffice/libreoffice formats you might use
--drive-formats ods,odt.
Note that rclone adds the extension to the google doc, so if it is
calles My Spreadsheet on google docs, it will be exported as My Spreadsheet.xlsx or My Spreadsheet.pdf etc.
Here are the possible extensions with their corresponding mime types.

Extension
Mime Type
Description

csv
text/csv
Standard CSV format for Spreadsheets

doc
application/msword
Micosoft Office Document

docx
application/vnd.openxmlformats-officedocument.wordprocessingml.document
Microsoft Office Document

html
text/html
An HTML Document

jpg
image/jpeg
A JPEG Image File

ods
application/vnd.oasis.opendocument.spreadsheet
Openoffice Spreadsheet

ods
application/x-vnd.oasis.opendocument.spreadsheet
Openoffice Spreadsheet

odt
application/vnd.oasis.opendocument.text
Openoffice Document

pdf
application/pdf
Adobe PDF Format

png
image/png
PNG Image Format

pptx
application/vnd.openxmlformats-officedocument.presentationml.presentation
Microsoft Office Powerpoint

rtf
application/rtf
Rich Text Format

svg
image/svg+xml
Scalable Vector Graphics Format

txt
text/plain
Plain Text

xls
application/vnd.ms-excel
Microsoft Office Spreadsheet

xlsx
application/vnd.openxmlformats-officedocument.spreadsheetml.sheet
Microsoft Office Spreadsheet

zip
application/zip
A ZIP file of HTML, Images CSS

Hi Nick
I've just got around to trying the beta today, and it's not transferring
the google docs.
Maybe I'm doing something wrong... I've tried with and without specifying
drive-formats:
rclone -v  sync drive: S3:bucket --drive-formats pdf
rclone -v  sync drive: S3:bucket
Both commands do not export drive docs.
Regards
David
On 31 January 2016 at 18:10, Nick Craig-Wood<EMAIL_ADDRESS>wrote:

Closed #49 https://github.com/ncw/rclone/issues/49 via 558bc2e
https://github.com/ncw/rclone/commit/558bc2e132688f21f7142be3c42ed697c5cc136f
.
—
Reply to this email directly or view it on GitHub
https://github.com/ncw/rclone/issues/49#event-533228583.

--
David White
07525 807295

I’m experiencing the same with 1.27 - I’ve had it work but now it seems to skip over Google Docs.
MPT

On Feb 2, 2016, at 06:11, dolabriform<EMAIL_ADDRESS>wrote:
Hi Nick
I've just got around to trying the beta today, and it's not transferring
the google docs.
Maybe I'm doing something wrong... I've tried with and without specifying
drive-formats:
rclone -v sync drive: S3:bucket --drive-formats pdf
rclone -v sync drive: S3:bucket
Both commands do not export drive docs.
Regards
David
On 31 January 2016 at 18:10, Nick Craig-Wood<EMAIL_ADDRESS>wrote:

Closed #49 https://github.com/ncw/rclone/issues/49 via 558bc2e
https://github.com/ncw/rclone/commit/558bc2e132688f21f7142be3c42ed697c5cc136f
.
—
Reply to this email directly or view it on GitHub
https://github.com/ncw/rclone/issues/49#event-533228583.

--
David White
07525 807295
—
Reply to this email directly or view it on GitHub https://github.com/ncw/rclone/issues/49#issuecomment-178514125.

@dolabriform @michaelthwaite Curious - it works for me.

$ rclone ls drive:GDocs
     5570 Drawings.svg
     4297 Docs.docx
     3516 Sheets.xlsx
    27579 Slides.pptx

$ rclone copy drive:GDocs /tmp/adfsf
2016/02/02 14:06:16 Local file system at /tmp/adfsf: Building file list
2016/02/02 14:06:17 Local file system at /tmp/adfsf: Waiting for checks to finish
2016/02/02 14:06:17 Local file system at /tmp/adfsf: Waiting for transfers to finish

Transferred:        40962 Bytes (  14.49 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            4
Elapsed time:        2.7s

$ ls /tmp/adfsf/
Docs.docx  Drawings.svg  Sheets.xlsx  Slides.pptx

$ rclone copy drive:GDocs /tmp/adfsf
2016/02/02 14:06:33 Local file system at /tmp/adfsf: Building file list
2016/02/02 14:06:35 Local file system at /tmp/adfsf: Waiting for checks to finish
2016/02/02 14:06:35 Local file system at /tmp/adfsf: Waiting for transfers to finish

Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 4
Transferred:            0
Elapsed time:          2s

Can you post a log with rclone -v of what happens?

Hi Nick
I think I've worked out the problem....
If I do an ls from the root of drive, ie:
rclone ls drive:
It doesn't show any google docs but it does show all other file types in
the root and all sub folders
However if I do an ls with a folder name, ie
rclone -v ls drive2:test
It lists all the google docs files!
rclone -v ls drive2:test
2016/02/02 14:48:40 Google drive root 'test': Modify window is 1ms
2016/02/02 14:48:40 Google drive root 'test': Finished reading
 4306 test-doc.docx

 3589 test-sheet.xlsx

Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:        1.2s
2016/02/02 14:48:41 Go routines at exit 15
I hope that helps
Regards
David
On 2 February 2016 at 14:17, Nick Craig-Wood<EMAIL_ADDRESS>wrote:

@dolabriform https://github.com/dolabriform @michaelthwaite
https://github.com/michaelthwaite Curious - it works for me.
[image: gdocs]
https://cloud.githubusercontent.com/assets/536803/12751690/8ba730c6-c9b6-11e5-9bd0-463fd3e5068f.png
$ rclone ls drive:GDocs
5570 Drawings.svg
4297 Docs.docx
3516 Sheets.xlsx
27579 Slides.pptx
$ rclone copy drive:GDocs /tmp/adfsf
2016/02/02 14:06:16 Local file system at /tmp/adfsf: Building file list
2016/02/02 14:06:17 Local file system at /tmp/adfsf: Waiting for checks to finish
2016/02/02 14:06:17 Local file system at /tmp/adfsf: Waiting for transfers to finish
Transferred:        40962 Bytes (  14.49 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            4
Elapsed time:        2.7s
$ ls /tmp/adfsf/
Docs.docx  Drawings.svg  Sheets.xlsx  Slides.pptx
$ rclone copy drive:GDocs /tmp/adfsf
2016/02/02 14:06:33 Local file system at /tmp/adfsf: Building file list
2016/02/02 14:06:35 Local file system at /tmp/adfsf: Waiting for checks to finish
2016/02/02 14:06:35 Local file system at /tmp/adfsf: Waiting for transfers to finish
Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 4
Transferred:            0
Elapsed time:          2s
Can you post a log with rclone -v of what happens?
—
Reply to this email directly or view it on GitHub
https://github.com/ncw/rclone/issues/49#issuecomment-178593725.

--
David White
07525 807295

Nick,
On 2016-02-03 01:17, Nick Craig-Wood wrote:

@dolabriform [1] @michaelthwaite [2] Curious - it works for me.
[3]
$ rclone ls drive:GDocs
5570 Drawings.svg
4297 Docs.docx
3516 Sheets.xlsx
27579 Slides.pptx

None of those are native GDs are they? (GDs native files don't show
extensions in the GDs environment).  I can only clone non-GD . .
P.

$ rclone copy drive:GDocs /tmp/adfsf
2016/02/02 14:06:16 Local file system at /tmp/adfsf: Building file
list
2016/02/02 14:06:17 Local file system at /tmp/adfsf: Waiting for
checks to finish
2016/02/02 14:06:17 Local file system at /tmp/adfsf: Waiting for
transfers to finish
Transferred:        40962 Bytes (  14.49 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            4
Elapsed time:        2.7s
$ ls /tmp/adfsf/
Docs.docx  Drawings.svg  Sheets.xlsx  Slides.pptx
$ rclone copy drive:GDocs /tmp/adfsf
2016/02/02 14:06:33 Local file system at /tmp/adfsf: Building file
list
2016/02/02 14:06:35 Local file system at /tmp/adfsf: Waiting for
checks to finish
2016/02/02 14:06:35 Local file system at /tmp/adfsf: Waiting for
transfers to finish
Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 4
Transferred:            0
Elapsed time:          2s
Can you post a log with rclone -v of what happens?
--
Reply to this email directly or view it on GitHub [4].

Links:
[1] https://github.com/dolabriform
[2] https://github.com/michaelthwaite
[3]
https://cloud.githubusercontent.com/assets/536803/12751690/8ba730c6-c9b6-11e5-9bd0-463fd3e5068f.png
[4] https://github.com/ncw/rclone/issues/49#issuecomment-178593725

--
Philip Rhoades
PO Box 896
Cowra  NSW  2794
Australia
E-mail<EMAIL_ADDRESS>

dolabriform,
On 2016-02-03 01:49, dolabriform wrote:

Hi Nick
I think I've worked out the problem....
If I do an ls from the root of drive, ie:
rclone ls drive:
It doesn't show any google docs but it does show all other file types
in
the root and all sub folders
However if I do an ls with a folder name, ie
rclone -v ls drive2:test
It lists all the google docs files!
rclone -v ls drive2:test

That does not fix the problem for me . .
P.

2016/02/02 14:48:40 Google drive root 'test': Modify window is 1ms
2016/02/02 14:48:40 Google drive root 'test': Finished reading
4306 test-doc.docx
3589 test-sheet.xlsx
Transferred: 0 Bytes ( 0.00 kByte/s)
Errors: 0
Checks: 0
Transferred: 0
Elapsed time: 1.2s
2016/02/02 14:48:41 Go routines at exit 15
I hope that helps
Regards
David
On 2 February 2016 at 14:17, Nick Craig-Wood
<EMAIL_ADDRESS>wrote:

@dolabriform https://github.com/dolabriform @michaelthwaite
https://github.com/michaelthwaite Curious - it works for me.
[image: gdocs]

https://cloud.githubusercontent.com/assets/536803/12751690/8ba730c6-c9b6-11e5-9bd0-463fd3e5068f.png

$ rclone ls drive:GDocs
5570 Drawings.svg
4297 Docs.docx
3516 Sheets.xlsx
27579 Slides.pptx
$ rclone copy drive:GDocs /tmp/adfsf
2016/02/02 14:06:16 Local file system at /tmp/adfsf: Building file
list
2016/02/02 14:06:17 Local file system at /tmp/adfsf: Waiting for
checks to finish
2016/02/02 14:06:17 Local file system at /tmp/adfsf: Waiting for
transfers to finish
Transferred: 40962 Bytes ( 14.49 kByte/s)
Errors: 0
Checks: 0
Transferred: 4
Elapsed time: 2.7s
$ ls /tmp/adfsf/
Docs.docx Drawings.svg Sheets.xlsx Slides.pptx
$ rclone copy drive:GDocs /tmp/adfsf
2016/02/02 14:06:33 Local file system at /tmp/adfsf: Building file
list
2016/02/02 14:06:35 Local file system at /tmp/adfsf: Waiting for
checks to finish
2016/02/02 14:06:35 Local file system at /tmp/adfsf: Waiting for
transfers to finish
Transferred: 0 Bytes ( 0.00 kByte/s)
Errors: 0
Checks: 4
Transferred: 0
Elapsed time: 2s
Can you post a log with rclone -v of what happens?
—
Reply to this email directly or view it on GitHub
https://github.com/ncw/rclone/issues/49#issuecomment-178593725.

--
David White
07525 807295
Reply to this email directly or view it on GitHub [1].

Links:
[1] https://github.com/ncw/rclone/issues/49#issuecomment-178610025

--
Philip Rhoades
PO Box 896
Cowra  NSW  2794
Australia
E-mail<EMAIL_ADDRESS>

dolabriform,
GitHub is stuffing up the formatting of the previous note - trying
again:
On 2016-02-03 01:49, dolabriform wrote:

Hi Nick
I think I've worked out the problem....
If I do an ls from the root of drive, ie:
rclone ls drive:
It doesn't show any google docs but it does show all other file types
in
the root and all sub folders
However if I do an ls with a folder name, ie
rclone -v ls drive2:test
It lists all the google docs files!
rclone -v ls drive2:test

That does not fix the problem for me . .
P.
--
Philip Rhoades
PO Box 896
Cowra  NSW  2794
Australia
E-mail<EMAIL_ADDRESS>

@dolabriform I can confirm that google docs aren't showing up properly when you list from the root.  I've made a ticket for it #336.  I suspect the fix for that will fix @philiprhoades problems too.
Any more comments about this to issue #336 please and I'll post a beta there when I've got to the bottom of it!
@philiprhoades wrote:

  5570 Drawings.svg
  4297 Docs.docx
  3516 Sheets.xlsx
 27579 Slides.pptx

None of those are native GDs are they? (GDs native files don't show
extensions in the GDs environment).  I can only clone non-GD..

They are exported versions of the native google docs - that is why
they have extensions.

I found a work-around --drive-full-list=false should fix it....

I can confirm that works :)
On 2 February 2016 at 17:05, Nick Craig-Wood<EMAIL_ADDRESS>wrote:

I found a work-around --drive-full-list=false should fix it....
—
Reply to this email directly or view it on GitHub
https://github.com/ncw/rclone/issues/49#issuecomment-178690711.

--
David White
07525 807295

People,
On 2016-02-03 04:23, dolabriform wrote:

I can confirm that works :)

This works - correctly displaying a single PDF:
rclone --drive-full-list=false ls gd:ABiC
None of these work to display two Writer files:
rclone -v --drive-full-list=false ls gd:CNASALERC
rclone --drive-full-list=false ls gd:CNASALERC
rclone --drive-full-list=true ls gd:CNASALERC
rclone --drive-full-list=false ls gd:CNASALERC/
P.

On 2 February 2016 at 17:05, Nick Craig-Wood
<EMAIL_ADDRESS>wrote:

I found a work-around --drive-full-list=false should fix it....
—
Reply to this email directly or view it on GitHub
https://github.com/ncw/rclone/issues/49#issuecomment-178690711.

--
David White
07525 807295
Reply to this email directly or view it on GitHub [1].

Links:
[1] https://github.com/ncw/rclone/issues/49#issuecomment-178699311

--
Philip Rhoades
PO Box 896
Cowra  NSW  2794
Australia
E-mail<EMAIL_ADDRESS>

@philiprhoades wrote

None of these work to display two Writer files:
rclone -v --drive-full-list=false ls gd:CNASALERC

Can you make sure you have permission to export these files? Right click on them in the drive web interface and select download and see if that works.
Also you say "Writer file" are these "Google Docs" files or something different?
If you can tell me how to reproduce the problem that would be really helpful!
Thanks
Nick

Nick,
On 2016-02-04 00:55, Nick Craig-Wood wrote:

@philiprhoades [1] wrote

None of these work to display two Writer files:
rclone -v --drive-full-list=false ls gd:CNASALERC

Can you make sure you have permission to export these files? Right
click on them in the drive web interface and select download and see
if that works.

Yes, they are all my files and I can download all of them.

Also you say "Writer file" are these "Google Docs" files or something
different?

Native Google Writer files - I just used the word "Writer" to
differentiate them from Calc files etc.

If you can tell me how to reproduce the problem that would be really
helpful!

Sorry, my fault - I was using 1.26 from another bin - updated and now I
correctly get this:
rclone --drive-full-list=true ls gd:CNASALERC
4523 0_ChromeForceReDisplay.docx
9202 PotentialForCollaboration_PHR_SSA.docx
Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:        2.8s
If I download - can I specify converting to ODT instead of DOCX?
Thanks!
Phil.
Philip Rhoades
PO Box 896
Cowra  NSW  2794
Australia
E-mail<EMAIL_ADDRESS>

All syncing correctly now with --drive-full-list=false
MPT

On Feb 3, 2016, at 11:46, philiprhoades<EMAIL_ADDRESS>wrote:
Nick,
On 2016-02-04 00:55, Nick Craig-Wood wrote:

@philiprhoades [1] wrote

None of these work to display two Writer files:
rclone -v --drive-full-list=false ls gd:CNASALERC

Can you make sure you have permission to export these files? Right
click on them in the drive web interface and select download and see
if that works.

Yes, they are all my files and I can download all of them.

Also you say "Writer file" are these "Google Docs" files or something
different?

Native Google Writer files - I just used the word "Writer" to
differentiate them from Calc files etc.

If you can tell me how to reproduce the problem that would be really
helpful!

Sorry, my fault - I was using 1.26 from another bin - updated and now I
correctly get this:
rclone --drive-full-list=true ls gd:CNASALERC
4523 0_ChromeForceReDisplay.docx
9202 PotentialForCollaboration_PHR_SSA.docx
Transferred: 0 Bytes ( 0.00 kByte/s)
Errors: 0
Checks: 0
Transferred: 0
Elapsed time: 2.8s
If I download - can I specify converting to ODT instead of DOCX?
Thanks!
Phil.
Philip Rhoades
PO Box 896
Cowra NSW 2794
Australia
E-mail<EMAIL_ADDRESS>—
Reply to this email directly or view it on GitHub https://github.com/ncw/rclone/issues/49#issuecomment-179337211.

Here is a beta which should work without the --drive-full-list=true work-around: http://pub.rclone.org/v1.27-1-g5dd387fβ/

Nick,
Looks good!
Thanks!
Phil.
On 2016-02-07 03:44, Nick Craig-Wood wrote:

Here is a beta which should work without the --drive-full-list=true
work-around: http://pub.rclone.org/v1.27-1-g5dd387fβ/
--
Reply to this email directly or view it on GitHub [1].

Links:
[1] https://github.com/ncw/rclone/issues/49#issuecomment-180808036

--
Philip Rhoades
PO Box 896
Cowra  NSW  2794
Australia
E-mail<EMAIL_ADDRESS>

Nick
I'm finding RClone very useful. Many thanks for your work on it. I'm using v1.27 release binaries on ubuntu trusty. Im posting this here because it seems connected to this issue but maybe is a new thing.
There seem to be some inconsistencies on the --drive-formats selection of export format for google docs IF the sync is started at root - as the following set of dry runs hope to illustrate. The "How we can help" Drive file is variously exported as odt or docx, seemingly ignoring the --drive-formats option if the sync is started from root (the behaviour differs between syncs, possibly at random) but seems to always be exported as requested as odt if the sync is started in a lower level directory.
Hope this helps
Rob
terminological@yoda:~$ rclone -n --drive-full-list=false --drive-formats "ods,odt" sync drive: ./GDrive/
2016/02/12 10:43:20 Local file system at /home/terminological/GDrive: Building file list
2016/02/12 10:43:28 Local file system at /home/terminological/GDrive: Waiting for checks to finish
2016/02/12 10:43:28 Waiting for deletions to finish
<snip>
2016/02/12 10:43:28 company/marketing/How we can help.docx: Not copying as --dry-run
2016/02/12 10:43:28 Local file system at /home/terminological/GDrive: Waiting for transfers to finish
2016/02/12 10:43:28 Local file system at /home/terminological/GDrive: Waiting for deletes to finish (during+after)

Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                38
Transferred:            9
Elapsed time:        8.3s

terminological@yoda:~$ rclone -n --drive-full-list=false --drive-formats "odt,ods" sync drive: ./GDrive/
2016/02/12 10:44:49 Local file system at /home/terminological/GDrive: Building file list
2016/02/12 10:44:55 Local file system at /home/terminological/GDrive: Waiting for checks to finish
2016/02/12 10:44:55 Waiting for deletions to finish
<snip>
2016/02/12 10:44:55 company/marketing/How we can help.odt: Not copying as --dry-run
<snip>
2016/02/12 10:44:55 Local file system at /home/terminological/GDrive: Waiting for transfers to finish
2016/02/12 10:44:55 Local file system at /home/terminological/GDrive: Waiting for deletes to finish (during+after)

Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                38
Transferred:            9
Elapsed time:        6.6s

terminological@yoda:~$ rclone -n --drive-full-list=false --drive-formats "odt,ods" sync drive: ./GDrive/ | grep company
2016/02/12 10:45:52 Local file system at /home/terminological/GDrive: Building file list
2016/02/12 10:45:57 Local file system at /home/terminological/GDrive: Waiting for checks to finish
2016/02/12 10:45:57 Waiting for deletions to finish
<snip>
2016/02/12 10:45:57 company/marketing/How we can help.docx: Not copying as --dry-run
<snip>
2016/02/12 10:45:57 Local file system at /home/terminological/GDrive: Waiting for transfers to finish
2016/02/12 10:45:57 Local file system at /home/terminological/GDrive: Waiting for deletes to finish (during+after)

Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                38
Transferred:            9
Elapsed time:        6.3s

terminological@yoda:~$ rclone -n --drive-full-list=false --drive-formats "ods,odt" sync drive:/company/marketing ./GDrive/company/marketing
2016/02/12 10:46:52 Local file system at /home/terminological/GDrive/company/marketing: Building file list
2016/02/12 10:46:53 Local file system at /home/terminological/GDrive/company/marketing: Waiting for checks to finish
2016/02/12 10:46:53 Waiting for deletions to finish
2016/02/12 10:46:53 How we can help.odt: Not copying as --dry-run
2016/02/12 10:46:53 Local file system at /home/terminological/GDrive/company/marketing: Waiting for transfers to finish
2016/02/12 10:46:53 Local file system at /home/terminological/GDrive/company/marketing: Waiting for deletes to finish (during+after)

Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 8
Transferred:            1
Elapsed time:        1.7s

terminological@yoda:~$ rclone -n --drive-full-list=false --drive-formats "odt,ods" sync drive:/company/marketing ./GDrive/company/marketing
2016/02/12 10:47:04 Local file system at /home/terminological/GDrive/company/marketing: Building file list
2016/02/12 10:47:05 Local file system at /home/terminological/GDrive/company/marketing: Waiting for checks to finish
2016/02/12 10:47:05 Waiting for deletions to finish
2016/02/12 10:47:05 How we can help.odt: Not copying as --dry-run
2016/02/12 10:47:05 Local file system at /home/terminological/GDrive/company/marketing: Waiting for transfers to finish
2016/02/12 10:47:05 Local file system at /home/terminological/GDrive/company/marketing: Waiting for deletes to finish (during+after)

Transferred:            0 Bytes (   0.00 kByte/s)
Errors:                 0
Checks:                 8
Transferred:            1
Elapsed time:        1.7s

terminological@yoda:~$

I've tested the beta without the work around and it's working for me.
Thanks for all your hard work on this Nick!
On 6 February 2016 at 16:44, Nick Craig-Wood<EMAIL_ADDRESS>wrote:

Here is a beta which should work without the --drive-full-list=true
work-around: http://pub.rclone.org/v1.27-1-g5dd387fβ/
—
Reply to this email directly or view it on GitHub
https://github.com/ncw/rclone/issues/49#issuecomment-180808036.

--
David White
07525 807295

@robchallen wrote

There seem to be some inconsistencies on the --drive-formats selection of export format for google docs

I've fixed this in #336 - there is a beta on that ticket for you to try - comments there please :-)

Nick,
On 2016-02-13 00:59, Nick Craig-Wood wrote:

@robchallen [1] wrote

There seem to be some inconsistencies on the --drive-formats
selection of export format for google docs

I've fixed this in #336 [2] - there is a beta on that ticket for you
to try - comments there please :-)

Using rclone-v1.27-linux-amd64.zip from the web site (I presume this is
the correct one? - on a previous download unzipping gave a dir:
rclone-v1.27-1-g5dd387f#U03b2-linux-amd64 - so at least I could tell
there was a difference), with this command:
rclone -v sync --drive-full-list=false --drive-formats "ods,odt" gd: .
mostly it worked with od[st] files produced but I still got a few .docx
and .xlsx files - not sure why, they seem to be a roughly even spread of
date age stamps . .
Thanks,
Phil.
Philip Rhoades
PO Box 896
Cowra  NSW  2794
Australia
E-mail<EMAIL_ADDRESS>

@philiprhoades Try the binary from here: http://pub.rclone.org/v1.27-1-g5dd387fβ/ - that should be the right one. - Can you put coments #336 about that please? Thanks Nick

Nick,
On 2016-02-15 04:02, Nick Craig-Wood wrote:

@philiprhoades [1] Try the binary from here:
http://pub.rclone.org/v1.27-1-g5dd387fβ/ - that should be the
right one.

I'm confused - that has an old date on it "2016-02-06 16:41:35" - I
thought there had been another change since then?
Also, clicking on that file to save it gives a file name "download"
instead of the file name.

Can you put coments #336 [2] about that please? Thanks

Will do.
P.
Philip Rhoades
PO Box 896
Cowra  NSW  2794
Australia
E-mail<EMAIL_ADDRESS>

@philiprhoades sorry for the confusion.  That link should link to the right code to try.
A beta's link on the website is a good idea - I'd need to make the beta's a bit differently though as at the moment I make them with individual branches of code I want people to check.

and then compared the .odt and .ods files that DID work with the previous version and although they both open OK, the files have different cksums - not sure why they converted differently but still open OK .

Google seems to convert the files on the fly each time, and they are sometimes different - I don't know why!  Maybe they have a timestamp in or something like that.

I just wanted to say: thanks @ncw for a very elegant implementation. This might just cost one of the online "we backup Google" services a sale! (We only really use GDocs so that's what we care most about).

I'd like to second that!
On Monday, 15 February 2016, Tim Watts<EMAIL_ADDRESS>wrote:

I just wanted to say: thanks @ncw https://github.com/ncw for a very
elegant implementation. This might just cost one of the online "we backup
Google" services a sale! (We only really use GDocs so that's what we care
most about).
—
Reply to this email directly or view it on GitHub
https://github.com/ncw/rclone/issues/49#issuecomment-184349552.

--
David White
07525 807295


Basic test case: tests

This test case is triggered automatically by our validation script.
- job: copr_build
  trigger: pull_request
  metadata:
    targets:
    - fedora-all

- job: tests
  trigger: pull_request
  metadata:
    targets:
    - fedora-all

/packit build

/packit build

/packit test

/packit build

/packit test

/packit test

/packit build

/packit test

/packit test

/packit build

/packit build

/packit build

/packit test

/packit test

/packit test

/packit build

/packit build

/packit build

/packit build

/packit build

/packit build

/packit test

/packit build

/packit test

/packit build

/packit build

/packit build

/packit build

/packit build

Replaced by #648.


incorrect docs

in the deploy section, the instructions reference:
run nr1 credentials:list
which is not valid.

Good catch. Thanks @x-dan-x. Will resolve asap.

:tada: This issue has been resolved in version 0.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ClassCastException on moving to mysql-connector-java version 8.0.23

Environment
Liquibase Version:
3.6.3
Liquibase Integration & Version:
spring boot
Liquibase Extension(s) & Version:
Database Vendor & Version:
mysql  Ver 14.14 Distrib 5.7.28, for osx10.14 (x86_64)
mysql-connector-java version 8.0.23
Operating System Type & Version:
All
Description
While trying to move from mysql-connector-java version 8.0.18 to 8.0.23, getting an ClassCastException on bootup.
Caused by: java.lang.ClassCastException: java.time.LocalDateTime cannot be cast to java.lang.String 	at liquibase.changelog.StandardChangeLogHistoryService.getRanChangeSets(StandardChangeLogHistoryService.java:324) 	at liquibase.changelog.AbstractChangeLogHistoryService.upgradeChecksums(AbstractChangeLogHistoryService.java:66) 	at liquibase.changelog.StandardChangeLogHistoryService.upgradeChecksums(StandardChangeLogHistoryService.java:293) 	at liquibase.Liquibase.checkLiquibaseTables(Liquibase.java:1221) 	at liquibase.Liquibase.update(Liquibase.java:193) 	at liquibase.Liquibase.update(Liquibase.java:179) 	at liquibase.integration.spring.SpringLiquibase.performUpdate(SpringLiquibase.java:353) 	at liquibase.integration.spring.SpringLiquibase.afterPropertiesSet(SpringLiquibase.java:305) 	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1830) 	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1767) 	... 108 common frames omitted
Steps To Reproduce (CLI)
Add the mysql-connector 8.0.23 jar to your lib directory and attempt to run liquibase operations against a mysql database.
Steps To Reproduce (Spring Boot)
List the steps to reproduce the behavior.
this is the pom.xml used,

<dependency>
	<groupId>mysql</groupId>
	<artifactId>mysql-connector-java</artifactId>
	<version>8.0.23</version>
</dependency>

<dependency>
	<groupId>org.liquibase</groupId>
	<artifactId>liquibase-core</artifactId>
	<version>3.6.3</version>
</dependency>
<dependency>
	<groupId>org.liquibase.ext</groupId>
	<artifactId>liquibase-hibernate5</artifactId>
	<version>3.6</version>
	<exclusions>
		<exclusion>
			<groupId>org.hibernate.javax.persistence</groupId>
			<artifactId>hibernate-jpa-2.0-api</artifactId>
		</exclusion>
	</exclusions>
</dependency>

Liquibase Internal QA Requirements

Manually validate the fix with the CLi.
Locally execute all functional MySQL tests.

+1 here

Hi @ashwin-nutanix Thanks for making us aware of this issue.  We will add it to our list of issues to process.  Does this happen with other versions of Liquibase?

Hi @ashwin-nutanix Thanks for making us aware of this issue.  We will add it to our list of issues to process.  Does this happen with other versions of Liquibase?

@molivasdat I can't speak to older versions of LB beyond what @ashwin-nutanix reported, but this is a problem for me as well on the latest version: 4.2.2

@molivasdat I can't speak to older versions of LB beyond what @ashwin-nutanix reported, but this is a problem for me as well on the latest version: 4.2.2

@molivasdat I did try upgrading to 3.7.0. I was still getting the same exception.

@molivasdat I did try upgrading to 3.7.0. I was still getting the same exception.

This bug in mysql-connector-java sounds very much like it is the reason for this exception: https://bugs.mysql.com/bug.php?id=102321

This bug in mysql-connector-java sounds very much like it is the reason for this exception: https://bugs.mysql.com/bug.php?id=102321

@pioneer2k the status of the bug is verified. Doesn't  it mean that its been fixed ?

@pioneer2k the status of the bug is verified. Doesn't  it mean that its been fixed ?

I am not an expert, but I don't think so.

I am not an expert, but I don't think so.

Thanks @pioneer2k .  It looks like the bug is in the mysql jar file and not with Liquibase.  Closing this as not in Liquibase.  @markkolich @ashwin-nutanix , please follow the MySQL jar bug reference from @pioneer2k above.

Thanks @pioneer2k .  It looks like the bug is in the mysql jar file and not with Liquibase.  Closing this as not in Liquibase.  @markkolich @ashwin-nutanix , please follow the MySQL jar bug reference from @pioneer2k above.

@molivasdat wait a second!

It looks like the bug is in the mysql jar file and not with Liquibase.

I completely disagree.
If I understand the thread correctly, I think @pioneer2k was saying that the changes made under https://bugs.mysql.com/bug.php?id=102321 which shipped in mysql-connector-java:8.0.23 is the cause of the bug in LB. MySQL changed the contract a bit, and therefore, LB needs to update too.
It appears to me that the LB code in StandardChangeLogHistoryService needs to be updated to now also handle a LocalDateTime as returned from the MySQL connector instead of blindly casting the tmpDateExecuted to a String:
https://github.com/liquibase/liquibase/blob/6986dffb9f67c613db89f2aee72ad82a71a68d26/liquibase-core/src/main/java/liquibase/changelog/StandardChangeLogHistoryService.java#L317-L328
LB is already checking for instanceof Date so I think it needs to do the same for returned objects of type LocalDateTime.

@molivasdat wait a second!

It looks like the bug is in the mysql jar file and not with Liquibase.

I completely disagree.
If I understand the thread correctly, I think @pioneer2k was saying that the changes made under https://bugs.mysql.com/bug.php?id=102321 which shipped in mysql-connector-java:8.0.23 is the cause of the bug in LB. MySQL changed the contract a bit, and therefore, LB needs to update too.
It appears to me that the LB code in StandardChangeLogHistoryService needs to be updated to now also handle a LocalDateTime as returned from the MySQL connector instead of blindly casting the tmpDateExecuted to a String:
https://github.com/liquibase/liquibase/blob/6986dffb9f67c613db89f2aee72ad82a71a68d26/liquibase-core/src/main/java/liquibase/changelog/StandardChangeLogHistoryService.java#L317-L328
LB is already checking for instanceof Date so I think it needs to do the same for returned objects of type LocalDateTime.

My suggestion would be to use 8.0.22 until MySQL fixes this especially if there is nothing critical in 8.0.23 that is not in 8.0.22.

My suggestion would be to use 8.0.22 until MySQL fixes this especially if there is nothing critical in 8.0.23 that is not in 8.0.22.

As written in the mysql connector j change log , they changed the contract of getObject:

Also, with the implementation of the new mechanism, a getObject(columnIndex) call on a DATETIME column returns a LocalDateTime object now instead of a String. To receive a String like before, use getObject(columnIndex, String.class) instead.

So, i assume, they do not consider this as a bug, but as a new feature or at least as a changed implementation detail. In order to get Liquibase working properly with mysql connector 8.0.23 and onwards, liquibase code must be changed either to include an "instanceof LocalDateTime", or to call the getObject(..., String.class) variant.

For me too, it looks like Liquibase needs to adapt its call.
The MySQL changelog states that the change in Connector/J was as intended.
https://dev.mysql.com/doc/relnotes/connector-j/8.0/en/news-8-0-23.html
Functionality Added or Changed
Important Change:
Also, with the implementation of the new mechanism, a getObject(columnIndex) call on a DATETIME column returns a LocalDateTime object now instead of a String. To receive a String like before, use getObject(columnIndex, String.class) instead.
MySQL says "Not a Bug" in Connector/J! Refer to issue https://bugs.mysql.com/bug.php?id=102435

Thanks all for the feedback.  We have reopened this issue and are looking at how and where we can fix it.  It looks to be an intentional change on the latest MySQL Connector/J as of 8.0.23.

Hopefully this will this be fixed also for the earlier versions also

We are just finishing up 4.3.0, so the fix will go out in 4.3.1 for sure. We're talking about whether to do a 3.10.4 release with it or not as well.

hey @ashwin-nutanix  -- You would have to upgrade to 3.10.4. what version are you on?

@mariochampion  We are on 3.6.3 . Can you confirm if there will be a fix for this version ?
Are there any breaking changes to upgrade 3.10.4  ?

when would 3.10.4 be released?

hey @ashwin-nutanix and @jasontrublu -- we just released 4.3.0 yesterday, and are wrapping some of these related issues into 4.3.1 aimed for two weeks from now. i see desire for getting this backported into 3.10.4 as well, so let me go check with the team, and i ll get you a date estimate. thanks!

Hello, are there plans for a 3.10.4 with the fix?

ALTER TABLE DATABASECHANGELOG MODIFY COLUMN DATEEXECUTED VARCHAR(27) NOT NULL;

Seems to be an easy workaround


Can't find the proper output node name

Hi Zehaos,
First of all, thanks for sharing your works!
In order to run this model on iOS device, I was trying to use freeze_graph.py to freeze your ckpt files, but I can not find the right name of the output node.
Do you have any idea that what output node I should use to freeze your ckpt file?
Many thanks!

Hi,
Thanks for using my code.
You can use tensorboard to inspect nodes in the graph (run train first to get a initial summary), I think the output nope should be 'clone_0/MobileNet/Predictions/Softmax'.
Could you report the inference time if success? Thanks in advance.


[RELAY][OP] conv2d, ShapeExpr->IndexExpr

Changed ShapeExpr->IndexExpr as it is mostly used for index
port conv2d from nnvm spec, with the following changes:

kernel_size, channels are no longer mandatory
layout->data_layout
kernel_layout -> weight_layout(to be consistent with the weight, data argument name)
bias is no longer attached to conv2d

Port layout.h into relay with minimum modification

This PR represents what is generally need to be done to port an NNVM operator to relay, most of the logic remains the same

Implement the TypeRelation function

The shapes represented by IndexExpr(symbolic integer)
User reporter->Assign to set the inferred result
Use reporter->AssertEQ to assert symbolic integer equivalence

It will return false if there is an unsatisfied constraint

Use tvm::Attrs to replace of dmlc::Parameter
We switch to directly create python wrappers by calling into positional functions so that the operator signature is explicit in python.

Examples
Although I am not completely happy with the current python DSL API(relay.ir_builder). The example test case does show some interesting improvement over what we can do previously, for example,  we can already do limited symbolic inference with batch dimension as symbolic
def test_conv2d_infer_type():
    # symbolic in batch dimension
    ib = relay.ir_builder.IRBuilder()
    n, c, h, w = tvm.var("n"), 10, 224, 224
    x = ib.param("x", relay.ty.TensorType((n, c, h, w), "float32"))
    w = ib.param("w", relay.ty.IncompleteType())

    with ib.function(x, w) as func:
        ib.ret(relay.nn.conv2d(x.var, w.var,
                               kernel_size=(3, 3),
                               padding=(1, 1),
                               channels=2))
    ib.ret(func)
    func = relay.ir_pass.infer_type(ib.env, func.to_func())
    ftype = func.checked_type()
    assert ftype.ret_type == relay.ty.TensorType(
        (n, 2, 224, 224), "float32")
    assert ftype.arg_types[1] == relay.ty.TensorType(
        (10, 2, 3, 3), "float32")

    # infer by shape of w, mixed precision
    ib = relay.ir_builder.IRBuilder()
    n, c, h, w = tvm.var("n"), 10, 224, 224
    x = ib.param("x", relay.ty.TensorType((n, c, h, w), "int8"))
    w = ib.param("w", relay.ty.TensorType((2, 10, 3, 3), "int8"))
    with ib.function(x, w) as func:
        ib.ret(relay.nn.conv2d(x.var, w.var, out_dtype="int32"))
    ib.ret(func)
    func = relay.ir_pass.infer_type(ib.env, func.to_func())
    ftype = func.checked_type()
    assert ftype.ret_type == relay.ty.TensorType(
        (n, 2, 222, 222), "int32")

cc @jroesch @zheng-da  @merrymercy @yzhliu @ZihengJiang @zhiics

Rushing for an exam. Will check it out tomorrow evening.

@MarisaKirisame @zhiics  Thanks for the comments, i have fixed them

@tqchen Seems some test cases failed. Please fix them.

Thanks @srkreddy1238 's comment uncovering the problem of alpha eq, this leads to a few more problems to be uncovered. It is a good reminder for us to have good test coverage, in light of that. I have added more test cases for conv2d including the layout transformation.
@zhiics @srkreddy1238 @MarisaKirisame please review again

Thanks @junrushao1994 @srkreddy1238 @zhiics @MarisaKirisame this is now merged. I agree with @junrushao1994 that we might want to list common options here, maybe not all of them


Add support for weights for non-hook artifacts

closes #8439 #3635
What this PR does / why we need it:
It adds the capability to order manifests. It uses a functionality very similar to helm.io/hook-weight. It adds helm.io/order-weight.
Ueses the following logic to support any CR.
Have an annotation by the name "helm.sh/weight", which takes an Integer value (-ve or +ve). This a concept that Helm anyway uses for hooks ("helm.sh/hook-weight").
We retain the InstallOrder. We install CRs which have a negative weight in ascending order before those in InstallOrder. Then those with InstallOrder, and then Install those with +ve weights in ascending order.
If anyone specifies a weight for a resource in Install order, which is +ve or -ve, it goes with that batch.
If the weight is 0, then it happens just before those in the install order. So if there is a resource which in InstallOrder, but has a weight of 0, it will be applied before any other resource.
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

I like this PR, it gives users more flexibilities to define resources install/uninstall order.

If the weight is 0, then it happens just before those in the install order. So if there is a resource which in InstallOrder, but has a weight of 0, it will be applied before any other resource.

How can I differ setting the weight=0 from not setting weight hook(Weight default value is 0)?

@liuming-dev Thanks! Good point. While implementing I realised that hook-weight does not differentiate between weight 0 and no weight. So modelled order-weight too same way. Will modify the proposal above.

@ashokponkumar Do you mind rebasing with master? You seem to be out of sync and pulling in changes to this PR which are already merged.

sure @hickeyma. Am new to this process. Guess I am messing things up a bit. I tried following the suggestions by DCO tool. Now am trying to follow this. Do you have any document on how to pull changes after a PR is raised without adding the new commits in master being shown as part of the pull request. Am trying myself too and will try to create a new pull request.

@ashokponkumar Have a look at GitHub docs on git rebase: https://docs.github.com/en/github/using-git/about-git-rebase

@ashokponkumar Have a look at GitHub docs on git rebase: https://docs.github.com/en/github/using-git/about-git-rebase

Thanks! Will look into it.

Have created a new pull request #8446 . Hence closing this. @hickeyma Would much appreciate if you can have a look at #8446 and let me know if more changes are required.


Updated apple pay sdk script version

Updated apple pay sdk version for availability on ApplePaySession in window object to complete payment.
https://github.com/johan44co/apple-pay-button/issues/1#issue-2492589303

@vikrantuk nice catch, I will merge your PR, sorry for the late response. A new version will be merge soon including this fix


"Convert to guard return" fails on mutable variables

When running the "Convert to guard return" function, the rust analyzer language server panics, when determining the name of a mutable variable.

Reproducible example:
fn main() {
    let variable_name: Result<u8, Box<dyn std::error::Error>> = Ok(1);

    if let Ok(mut variable_name) = variable_name {
        variable_name = variable_name + 1;
        println!("{}", variable_name);
    }
}

Language server panic:
thread '<unnamed>' panicked at 'Failed to make ast node `syntax::ast::generated::nodes::Name` from text mod mut variable_name;', crates/syntax/src/ast/make.rs:518:13
stack backtrace:
   0: _rust_begin_unwind
   1: std::panicking::begin_panic_fmt
   2: syntax::ast::make::name
   3: ide_assists::assist_context::Assists::add
   4: ide_assists::handlers::early_return::convert_to_guarded_return
   5: ide_assists::Assist::get
   6: base_db::CheckCanceled::catch_canceled
   7: ide::Analysis::assists
   8: rust_analyzer::handlers::handle_code_action_resolve
   9: <F as threadpool::FnBox>::call_box
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

The problem is this line https://github.com/rust-analyzer/rust-analyzer/blob/9d691530d556bdc40262585383a1b18d3a1de07e/crates/ide_assists/src/handlers/early_return.rs#L147
The ident pattern is being turned into a name here, this includes ref and mut tokens which shouldn't be part of the name.

I am working on this.