Adding dependencies compile-time, test-time, run-time

I really like how the seed project here helps me getting started on new projects. :+1:
A typical task is to add an external library to my code (based on this project). Last week I burned my fingers twice, since I neglected to see there were many places I had to add the dependency.
Given you use the dependency in a test, you have to add it to the following

package.json as a dependency
karma.conf.js for loading during test
test-main.js also for test purposes (not sure I can explain exactly when or why this is needed)
tools/config.ts which is adding runtime to the main index.html page

It has bitten me twice last week alone. And my problem is I can add at 1 and 2, and my tests are happy. If I forget 3, I get a compile error. But if I forget 4, i will get no error at all.
Forgetting number 4 simply gives me a runtime error, which I will never see compile-time or test-time.
I had a look at how number 4 is used. The files listed in tools/config.ts are used in the main app/index.html file and injected JavaScript files. One per line. This is pretty much the same functionality I have seen in Wiredep module earlier.
Problem 1: Speed and rankings
I have one big problem with adding individual files to my page: Individual javascript files require individual HTTP requests (at least until HTTP2/SPDY is widespread), and it affects my SpeedIndex results, and my Google rankings.
The common solution is to add one or two concatenated, prebuilt files (minified).
Sometimes this is not done in 'developer mode', in order to ease debugging which can be harder in minified files (Ruby on Rails or Grails frameworks are examples for that).
Now, after Sourcemaps are working in all modern browsers, I see no problem with this. We can have the minified files, and easily debug with the help of sourcemaps.
Next problem: Not catching errors before runtime
The three lists in the three different files represent a potential problem for people like me that neglect to add the dependencies in all the files. I would really like us to be able to catch that last error before runtime, since runtime requires tedious, repeated, manual testing.
One suggestion:
I don't know exactly how, but I would really like to use the same list of files in all three places. Can you help me figuring out how this should be done?

Make use of same dependency list in karma.conf.js, test-main.js, app/index.html
Build and minify a javascript bundle – minified, concatenated (could be implemented separately)

This would have the obvious advantage of catching the error earlier and having no differences between compiled and served. Perhaps we could use the concatenated, minified js version in the tests as well?
I really love to hear your thoughts on this, since I think this is an area where errors can be easily made.
And also hard to discover. Please share your thoughts :)
/cc @larsthorup

Thanks for your inputs @jesperronn
I'm actually still working on improving the build and config. Will for sure consider your suggestions.

:+1:

Running
npm install postal --save
npm run tsd install postal

seem to install to module and typings, and updates package.json

Lets close this one.


Marketplace VM solution - update Deployment Manager Suggested Next steps page

As a data provider, I need to know how to apply my custom domain to the GKE cluster and enable TLS on that domain as well after Datashare is deployed to my GCP environment.
Update the Deployment Manager suggested next steps page to include the following:

Instructions on how to apply a custom domain to the Datashare API deployed in GKE
Enable TLS on that custom domain

This task is now complete.

This is already completed.


/nllp doesn't auto complete names

Is this cross-shard or just shard local or neither?

nllp doesn't even take a player name as an argument so I probably got confused when making this issue with another command.

Ok, I'll close this then. Open a new one if you find the impacted command. Thanks!


feat(client): move client to hyper-util

Closes https://github.com/hyperium/hyper/issues/2860
Move client (and its parts) to hyper-util.

Made some progress, but client::conn requires the use of hyper::proto which is private.

@tomkarw Ah, I had been planning to do this when I have the time, but didn't get the chance to. Please do go ahead and take over if you want to.
IIRC, there's some part of hyper::h2 that is private and is used in hyper::proto. I was looking for alternative to copying this

The hyper repo is not the one you last saw 😉. I'll see what needs to be done.

The hyper repo is not the one you last saw 😉. I'll see what needs to be done.

That's fair 😄


Fix jquery.plugin-base event listener removal

Description
Please describe your pull request:

Why is it necessary?
The jquery.plugin-base _off function used wrong parameters in one of the $.each function callbacks, resulting in wrong behaviour. Under certain cirumstances this even resulted in the loss of all event listeners attached to the specified element.
What does it improve?
The PR fixes the parameters in the $.each function callback so that only the passed event is removed as a listener from the element.
Does it have side effects?
No.

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?
http://issues.shopware.com/issues/SW-17258

How to test?
Add some event listeners to an element using plugin._on and remove one using plugin._off. Check event listeners on the element using $._data(element)

Thanks for the PR. I agree with @screeny05 on his comment.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/#/issues/SW-17285.
Please use this issue to track the state of your pull request.

@r-wettstaedt thanks for your contribution :+1:


NaN value in bar card

Since the 1.5.0 version, my hassio version sensor in the bar-card no longer wants to show the value, but NaN appears. While if I click on it, I will just see the correct value and if I put the entry somewhere else in my lovelace config it goes fine too.

Running Hassio: 0.97.2
Also tested release 1.5.2 and same problem
The lovelace code I used can be found here

Don't know why but for some reason the bar-card works fine, so I will close this issue ✅

Reopen my issue. The same problem now occurs on my 2nd home assistant installation and also with the installation of a friend of mine 🤔

.Same problem, here also/

It's because of: https://github.com/custom-cards/bar-card/blob/1a9ffb1b3a845300b6982ea62f563006a9a2c742/bar-card.js#L1018
The state "0.97.2" is NaN

I have installed the new version and removed the cache but the problem persists.

Same

This should really be fixed in 1.5.4.

If it's not working for you please check your console log to make sure you're running the latest version.

I have checked my console log but it still indicates 1.5.2, weird because I did do an upgrade in HACS to the 1.5.4 version. How can I solve this?

I've been having issues with HACS as well where it won't update/clear my cache. Reinstalling the plugin worked for me.

I have completely removed the bar-card, reinstalled it and removed the cache. I can now confirm that the problem has been solved 🎉


print HelloWorld in Java using Custom ClassName

Print Hello World using my Name instead of System Class

If you merge my pull request, please put labeled as "hacktoberfest-accepted"

please merge my pull request and labeled as "hacktoberfest-accepted".


[AutoRelease] t2-resource-2022-11-18-83562(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/3445
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1025
BuildTargetingString
azure-mgmt-resource
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/3445


Bfp market natspec refactor

Two minor things, otherwise looks good. I guess we need to figure out the storage dump too though

Got it to regenerate correctly 😑


Support font name (#29)

Supported font name in an element as implementation of Issue #29. I chose the pattern A, adding fontName property under text property, described in the issue.

@Pstoppani, would you merge this PR if it looks good?

Merged this PR because the spec is agreed in #29, and the implementation is small and simple.


[0.26.2] KOGITO-8959: Take screenshots of failed VSCode extension integration tests

Backporting the capability of taking screenshots of failed IT tests of VSCode extension from #1554 to 0.26.2

Hello @zdrapela , could you please update the cherry-picked commit message with [0.26.2] too? Thanks!

Hey @LuboTerifaj , sure, no problem :+1:

Love the label! <3


parallel xval with clone

NOT merge ready

I tried this for svm, krr, multiclassliblinear, KNN.

a simple #pragma omp parallel for around runs too is segfaulting for now

Cool.
What about a unit test that ensures that a single thread version produces the same as a multithreaded version and there are no memory errors?

Question: Do we always wants this to go for clone and parallel or make it user defined ?
e.g when I test parallel+clone vs normal output ?

Single core computation should not clone anything, i.e. set machine=m_machine

You can ask Shogun for the number of cores used via CParallel
I think currently this mechanism kind of ignores openmp
@lambday can you send a fix for develop?

@karlnapf sure. I'll do that tomorrow. Gotta add a HAVE_OPENMP check in the cmake for that.

What does valgrind say to this? unit test?

can you squash the commits after the rebase?

abalone7
Multiclassliblinear
Data size: (2785 11) , Single Threaded: 3155 , MultiThreaded: 973

KNN
Data size: (2785 11) , Single Threaded: 2489 , MultiThreaded: 2089

The benchmark should go to ryancurtins framework btw

We can merge as soon as you address the comments on the unit tests.
Also, if you write more benchmarks, put them in as unit tests as well.
Let's get this merged by tomorrow early ok?

The times are interesting, I guess KNN is already multicore that is why doing multiple of them doesnt help?

Dont think KNN is multicore.
libSVM
Data size: 1000 , Single Threaded: 40792 , MultiThreaded: 25174
Ok will add this to framework.

Ok one other thing I have to mention here cross->parallel->get_num_cpus() returns 1 for me always.
So   set_num_threads(cross->parallel->get_num_cpus()) wasnt actually running in parallel here. So for the numbers I used set_num_threads(3).

As discussed

unit test should manually set number of threads to 3 (and still be memory clean with valgrind)
update @brief of the x-validation class: say that it runs with the current number of threads, and that it duplicates all objects (might be changed later)
update NEWS
squash commits

updated :)

Great!
This is good to go once travis is green
We will re-visit for

parallel across runs
sharing feature matrices (needs some const cleanups)

Ok. Great!
This is a nice improvement.....we should get back to the shared features at some (later) point


keymapper: 4.6.0 -> 4.8.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/houmain/keymapper/releases.
meta.description for keymapper is: Cross-platform context-aware key remapper
meta.homepage for keymapper is: https://github.com/houmain/keymapper
meta.changelog for keymapper is: https://github.com/houmain/keymapper/blob/4.7.0/CHANGELOG.md
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.7.0 in filename of file in /nix/store/l1y1p7i1fhhaasbjbsq66k0hb5pjs8d8-keymapper-4.7.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

keymapper

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l1y1p7i1fhhaasbjbsq66k0hb5pjs8d8-keymapper-4.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A keymapper https://github.com/r-ryantm/nixpkgs/archive/74fdcad6275d313b0ddc1ad9363dd12f95131dc2.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/74fdcad6275d313b0ddc1ad9363dd12f95131dc2#keymapper

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l1y1p7i1fhhaasbjbsq66k0hb5pjs8d8-keymapper-4.7.0
ls -la /nix/store/l1y1p7i1fhhaasbjbsq66k0hb5pjs8d8-keymapper-4.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

keymapper

Maintainer pings
cc @dit7ya @spitulax for testing.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/houmain/keymapper/releases.
meta.description for keymapper is: Cross-platform context-aware key remapper
meta.homepage for keymapper is: https://github.com/houmain/keymapper
meta.changelog for keymapper is: https://github.com/houmain/keymapper/blob/4.7.2/CHANGELOG.md
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.7.2 in filename of file in /nix/store/fy37lpa8gr15ah5rm2xfd0i2yx42vr4x-keymapper-4.7.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

keymapper

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fy37lpa8gr15ah5rm2xfd0i2yx42vr4x-keymapper-4.7.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A keymapper https://github.com/r-ryantm/nixpkgs/archive/fe847d303695165f8f8d37c79b76c86d4226fafd.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/fe847d303695165f8f8d37c79b76c86d4226fafd#keymapper

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fy37lpa8gr15ah5rm2xfd0i2yx42vr4x-keymapper-4.7.2
ls -la /nix/store/fy37lpa8gr15ah5rm2xfd0i2yx42vr4x-keymapper-4.7.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

keymapper

Maintainer pings
cc @dit7ya @spitulax for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/houmain/keymapper/releases.
meta.description for keymapper is: Cross-platform context-aware key remapper
meta.homepage for keymapper is: https://github.com/houmain/keymapper
meta.changelog for keymapper is: https://github.com/houmain/keymapper/blob/4.7.3/CHANGELOG.md
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.7.3 in filename of file in /nix/store/fl6kyzkghsxib6fc8r06an4mp3sw389f-keymapper-4.7.3

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

keymapper

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/fl6kyzkghsxib6fc8r06an4mp3sw389f-keymapper-4.7.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A keymapper https://github.com/r-ryantm/nixpkgs/archive/8afee9c72b6517c1d43abd39a2a62ac6087d4a36.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/8afee9c72b6517c1d43abd39a2a62ac6087d4a36#keymapper

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/fl6kyzkghsxib6fc8r06an4mp3sw389f-keymapper-4.7.3
ls -la /nix/store/fl6kyzkghsxib6fc8r06an4mp3sw389f-keymapper-4.7.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

keymapper

Maintainer pings
cc @dit7ya @spitulax for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/houmain/keymapper/releases.
meta.description for keymapper is: Cross-platform context-aware key remapper
meta.homepage for keymapper is: https://github.com/houmain/keymapper
meta.changelog for keymapper is: https://github.com/houmain/keymapper/blob/4.8.2/CHANGELOG.md
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 4.8.2 in filename of file in /nix/store/3bfvhd0sks1w3n51gj8wl37rlx508xan-keymapper-4.8.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

keymapper

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/3bfvhd0sks1w3n51gj8wl37rlx508xan-keymapper-4.8.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A keymapper https://github.com/r-ryantm/nixpkgs/archive/f5b62a54775e154392e9d23696ae9897033e675b.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/f5b62a54775e154392e9d23696ae9897033e675b#keymapper

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/3bfvhd0sks1w3n51gj8wl37rlx508xan-keymapper-4.8.2
ls -la /nix/store/3bfvhd0sks1w3n51gj8wl37rlx508xan-keymapper-4.8.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

keymapper

Maintainer pings
cc @dit7ya @spitulax for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.


Add how to remove the per-user MFA settings

This is a feedback from David Belanger. I am adding the removed part with some modifications.

@juntakata : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@MicrosoftGuyJFlo
Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Expand example to show passing parameters

Fixes #29228
Thanks @sulmar! 🚀 ... How about we just expand the existing example, as I have on this PR, to show it? I add a NOTE at the end about passing an empty ParameterView for the no params case.
... and btw ... I didn't think the EditorRequired attribute was required ... is that what you're seeing there?

Internal previews

📄 File
🔗 Preview link

aspnetcore/blazor/components/render-components-outside-of-aspnetcore.md
Render Razor components outside of ASP.NET Core

Hold on a sec ... I need to make an update to this. There's a 🪲 in the code. Stand-by ........................

Yes, good idea - usually a component has a parameter. The EditorRequired attribute is not required, well it can be omitted for clarity.

Cool ... thx ... I'll ask Mackinnon on the product unit to review the updates.

I have yet another proposal - example how to add razor component to console app.
Currently I created a separate project with using RazorClassLibrary template. It's very efficient solution. May be useful hint for developers.

I think that works OOB tho without much fuss. We have a lot of RCL coverage in the article dedicated to that subject. I think it would useful to call out any deltas from that guidance or 😈 gotchas 😈, but I don't think that there are any ... well ... that I've heard about.

@guardrex yes, you are right.

When Mackinnon looks at this, he might spot something missing from the coverage. This particular document went in without much review because I was 🏃🏃🏃🏃🏃😅 on a bunch of things at the time.

I propose to add the following comment:
Update your console app project to use the Razor SDK:
<Project Sdk="Microsoft.NET.Sdk.Razor">
...
</Project>

based on https://devblogs.microsoft.com/dotnet/asp-net-core-updates-in-dotnet-8-preview-3/comment-page-2/?nsl-notice=1#render-razor-components-outside-of-asp-net-core

The article already covers that. It's about the fifth paragraph down.

Thanks @MackinnonBuck ... Yes, I will find a good spot to call out required. I'll update the PR as advised before merging. I'm OOF for a few hours but will get it wrapped up by EOD.

Ok ... ready to go.
Thanks again, @sulmar! 🚀

Thanks, too. I'm very happy that I could help.


Installation unsuccessful and overlay does not start

Hello. My English is not the best so I use the Google translation tool. Sorry if something is wrongly expressed.
I followed the installation as in the instructions and got the following error at the end, which can be seen in the screenshot:

And with the overlay installation it looks like this:

Then the browser opens with a few errors:

Would be great if you could help me

okay I found a mistake and the first part is running but the error with the overlay remains

Can be closed here. I fixed the problem with the following settings:
npm remove react-dev-utils
npm i<EMAIL_ADDRESS>


botocore.exceptions.ClientError: An error occurred (AccessDenied) when calling the CreateBucket operation: Access Denied

As per Readme.md I have done all the things mentioned over there still error exists.
Here is my ~/.aws/credentials (credentials are double checked with amazon user) :
[default]
aws_access_key_id = 'AKIAIWX3MVLXSxxxxTQ'
aws_secret_access_key = 'CqERo84v2X9M0OyR8I2T+wEA0hi/siIxxxxxx'

changed bucket name getting created by sample python script to jimish
@ Amazon console : user has access of AmazonS3FullAccess
Issue is still there. Please help

I confirm. Issue is still here. I can list buckets, I can upload to buckets. But I can't create a bucket. I'm also getting this error.

Might not be related, but I just resolved an Ansible task using boto by running the script with sudo permission. The "Access denied" you get could be a local 'access denied'?


Provide a shipperctl command to refresh webhook secret

Right now, there is no way of refreshing the secret for the webhook without downtime. This command would generate a new secret and replace it with the current secret. This allows operators to refresh a secret before it expires.

Another way to do this could be to add a controller to Shipper that actively watches and refreshes the webhook secret before it expires. This is something for us to look into.


Admin docs patch 1

This is to merge the work I've done with the admin documents.
As I said in our Planning Meeting, we should ignore my Readme contributions altogether and instead use Bhavin's in the Main branch.

I merged the changes from Bhavin into my version of the Readme file.


feat: add support beneficiary option

Changes
Summary of changes you made.

Add constants for referral amount and beneficiary amount & account.
Update invite text to use variables for percentage and number of days.
Include opt-out option in the editor to add Busy as beneficiary.

Demo

@Sekhmet and @jm90m Check this: https://github.com/busyorg/busy/issues/2188


Devices in Homebridge available but not in iOS Home app

Hello, I use Homebridge version 1.8.4 and this plugin in version 4.0.18. I see in the logs the configured OpenWebIf device (Vu+) and see also in the Homebridge > Device the switch button for each channel, volume or other buttons for OpenWebIf but I don't see any buttons / device in the iOS Home app.
All other plugins / devices works fine and I can control this in the iOS Home App.
How can I add the OpenWebIf "devices" in the iOS Home app or in Automations?

https://github.com/grzegorz914/homebridge-openwebif-tv/wiki#adding-to-homekit


[IR] Rename Value.consumers() to Value.uses()

A second renaming PR, hopefully more stable afterward...

The consumer() naming is not as accurate as it can be, because while a Node is a consumer/user, a (Node, index) is a "use". At the same time ONNX C++ IR (https://github.com/onnx/onnx/blob/c459890aa266d74ca612f334d0f3e869dcdbb597/onnx/common/ir.h#L288) as well as torch fx (https://github.com/pytorch/pytorch/blob/ea61c9cb299b6dfebc57dc9d8821c34321d568ab/torch/fx/node.py#L226) both uses the user / use concept. FX calls it user because it is a Node-Node relationship. We have a Node-(Node (user), index) relationship.

Speaking of other terminology: the concept of def-use is common in compiler analysis: eg: https://en.wikipedia.org/wiki/Use-define_chain


Parsing transactions : key 64

Hello
First thank you so much for this parser !
In result.get("additional_purpose","").replace("\r\n"," ") key ?64 is missing. It's a part of the address. Could it be added in "additional_purpose" field ?
And for those address related keys, could spaces be added between each key (for example write something like result[key60] = f"{result[key60] or ''} {value}" instead of result[key60] = (result[key60] or '') + value ) in order to facilitate future address parsing ?
Thank you in advance for your work,
Elisa

The additional_purpose gets parsed by the transaction_details_post_processor:
https://github.com/WoLpH/mt940/blob/ecb8c9fb31267a90780a279c40c2af1ea8c95d1e/mt940/processors.py#L198-L214
If you would add an extra post processor in post_transaction_details you could get it parsed. It's probably something specific for your bank:
import mt940
import pprint

mt940.tags.BalanceBase.scope = mt940.models.Transaction

# The currency has to be set manually when setting the BalanceBase scope to Transaction.
transactions = mt940.models.Transactions(processors=dict(
    post_transaction_details=[
        <your processors>
    ],
))

with open('filename.sta') as f:
    data = f.read()

transactions.parse(data)

for transaction in transactions:
    print('Transaction: ', transaction)
    pprint.pprint(transaction.data)

Hi
Thanks for your quick answer.
Sorry I realised I pasted the wrong thing in my message yesterday. I meant in the method _parse_mt940_details there is a test elif key in ('61', '62', '63') but when I read some documentation related to mt940 extended format, I see that for tag 86 "information to account owner" it goes from 60 to 65. I read that in multine doc but it's only available in french. Other banks documentation also talk about thoses keys.
So I believe subkeys ?64 and ?65 are not parsed. So data is missing for the key additional_purpose in my parsed Transactions() object.
To do the parsing, I use the parse method from Transactions model.
Do you think it's possible to fix that, since I don't think it's specific to my bank but to mt940 extended format ? I think it's somehow the same problem as for this PR : #48

I've created a new release that has this fix. Can you check if it works for you @elisaprio?
Sorry for the slow response, I've been really busy so it's hard to find time

Thank you so much ! This will work for me. Do you think it would  be also be possible to add a blank space before adding the new value ? Or is it unwise ?
Something like : result[key60] = f"{result[key60] or ''} {value}" instead of result[key60] = (result[key60] or '') + value
And sorry for the late reply too ! So no problem for the time =)

The problem is (and with the entire standard in general) that nearly every bank has its own interpretation of the standard. While it might fix it for your bank, it will breakt it for some others.
I can add it as a configurable option though, from what I see in my tests there's not single testfile that currently has a format where it makes a difference though. Do you have an example file by any chance?

Looks like there was actually 1 file that used this (and doesn't need the space).
You can use the version with spaces like this: https://github.com/WoLpH/mt940/blob/2e3669f9f0fd77abd5f4d5e58fe26b27f7620b40/mt940_tests/test_processors.py#L93-L97

Thank you so much ! It works perfectly for me !!
Here is the file I use for my tests :
CCPM940EB20191025_215418_158_MULTILIE191025.dat_12_70855463.zip

Looks like there was actually 1 file that used this (and doesn't need the space).
You can use the version with spaces like this:
https://github.com/WoLpH/mt940/blob/2e3669f9f0fd77abd5f4d5e58fe26b27f7620b40/mt940_tests/test_processors.py#L93-L97

I realise this is a "How to use python" question, but how do I get at the results of the post_transaction_details?
import mt940
import pprint

# https://github.com/WoLpH/mt940/issues/85
transactions = mt940.parse('1591139129348.STA', processors=dict(
   post_transaction_details=[
        mt940.processors.transaction_details_post_processor,
   ],
))

for transaction in transactions:
    pprint.pprint(transactions.post_transaction_details)

results in
Traceback (most recent call last):
  File "mt940-test.transaction_details.py", line 16, in <module>
    pprint.pprint(transactions.post_transaction_details)
AttributeError: 'Transactions' object has no attribute 'post_transaction_details'


[Wave8] [Simplified Collect] [Workflows] Create Approval page

We've recently merged the main workflows page.
The task here is to create the Approval page present under the main worfklows page.
It will appear when we click on the > icon under the Add approval menu item:

Expected mockup below:

Technical details can be found here.

@rushatgabhane will be doing the implementation.
Assigning @allroundexperts as the reviewer.
For context please see discussion here

Wahoo! Let's do it.

Discussion here for real time - https://expensify.slack.com/archives/C02NK2DQWUX/p1709028046898869?thread_ts=1709017652.394349&cid=C02NK2DQWUX

PR is in staging

I feel like this should have double the bounty since this was a feature that took much more time than what a normal bug would take to fix. What do you think @rushatgabhane?

Sure, I think that's fair in this case.

We discussed this internally with the team and we'll keep the bounty at $500 for this one. We understand that there'll inevitably be differences between the level of effort required for each issue, but we think that the current bounty is pretty generous across the board. We appreciate you both working on high value items like this one.

Confirming the payment summary is correct. Both of you can go ahead and request on NewDot. Closing!

$500 approved for @allroundexperts

$500 approved for @rushatgabhane


Regenerate device identity keys

It is possible to programatically update/regenerate device identity keys? Are ever device identity keys can become out of date and regenerate automatically?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ba49531b-359f-ab37-6eb6-af6e9e9307a0
Version Independent ID: 805bbabb-d81b-bc3e-39e4-340d1a8f2289
Content: Get started with Azure IoT Hub module identity and module twin (.NET)
Content Source: articles/iot-hub/iot-hub-csharp-csharp-module-twin-getstarted.md
Service: iot-hub
GitHub Login: @chrissie926
Microsoft Alias: menchi

@klucyszy Thanks for the feedback. We are actively investigating and will get back to you soon.

@chrissie926 Can you assist with answering this question? The documentation does not cover this scenario so I am not sure if it is not supported or not needed. Thank you, Mike.

Please refer to this article on how to generate device id keys automatically in c-sharp: https://github.com/MicrosoftDocs/azure-docs/blob/master/includes/iot-hub-get-started-create-device-identity-csharp.md
Let me know if you need other languages. They are all supported.

@klucyszy please let me know if this answers your question. @Mike-Ubezzi-MSFT please help resolve this issue. Thanks!

Hello,i've tried this code and everything work perfectly,
the problem is when i want to send a message ,i get an "exception" : Connection Status changed to disable:the reason is client_close
Can you help me plz


Application Fingerprinting: Usability Testing UX Work

Collaborate with @weikanglim to refine the experience of his "Application Fingerprinting" prototype in time for our March user testing sessions.

Create decision tree/flow for the app fingerprinting experience. [ @Austinauth / @weikanglim ]
Refine flow and prompt text into something suitable for testing with end users. [ @Austinauth / @weikanglim / @savannahostrowski / team ]
Capture questions and assumptions to validate in user testing sessions. [ @Austinauth / Irina / Team]

Outdated, closing for now. Will create a new issue if necessary.


chore: add bare example/react-native project

See https://github.com/ivanhofer/typesafe-i18n/discussions/352.
Added example usage like https://github.com/ivanhofer/typesafe-i18n/pull/522, but for bare react-native project.
Project generated with npx react-native init AwesomeTSProject --template react-native-template-typescript
Important parts start from there: https://github.com/ivanhofer/typesafe-i18n/pull/531/files#diff-34c05d48499a8d0600f5472677019d00e90f4224b03119ebefe3e90a690a2da5
Steps to integrate in your project
Extra steps to work with this library described in README.md:

Install polyfills for mobile

yarn add @formatjs/intl-getcanonicallocales @formatjs/intl-locale @formatjs/intl-pluralrules

Copy-paste polyfill folder in your project

Do import './polyfill' in entry point

Patch metro.config.js to allow .cjs extension

Before submitting the PR, please make sure you do the following

[x] It's really useful if your PR references an issue where it is discussed ahead of time.
[x] Prefix your PR title with [feat], [fix], [chore], or [docs].
[x] This message body should clearly illustrate what problems it solves.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint

Hi @whalemare, thanks for the PR.
I'm having trouble testing it. What is the default port the web application is running in the browser?
I have also questions regarding the ios and  android folders. For me those files look like generated. Should they be committed to the repo?

What is the default port the web application is running in the browser?

Not tested for web. Bare react native supported out of the box only android and ios

those files look like generated

Yes, it's generated by npx react-native init AwesomeTSProject --template react-native-template-typescript. When project start, it always generated by this command and should be committed to repo, because it's not Expo. Main difference between Expo and Bare react native, it's Expo - manage all for you. In Bare react native you should manage all environment by yourself, so we need this generated template in repo


refactor(Algebra/Homology): remove single₀

This PR removes the special definitions of single₀ for chain and cochain complexes, so as to avoid duplication of code with HomologicalComplex.single which is the functor constructing the complex that is supported by a single arbitrary degree. single₀ was supposed to have better definitional properties, but it turns out that in Lean4, it is no longer true (at least for the action of this functor on objects). The computation of the homology of these single complexes is generalized for HomologicalComplex.single using the new homology API: this result is moved to a separate file Algebra.Homology.SingleHomology.

After this, the plan is to refactor CategoryTheory.Abelian.RightDerived so as to use the new homology API.

retrying:
bors merge


Style: Use semantic linefeeds in markdown files

Is your feature request related to a problem?
The docs directory contains some markdown files that will be used to generate the documentation.
The formatting of these is not ideal as they sometimes use very long lines that are cumbersome to read (and especially edit).
Also, long lines lead to larger diffs reported by git if we just change a small part of the line.
Desired solution
Markdown generally does not care about (single) line breaks. It parses 2 consecutive line breaks as a "new paragraph", and 2 trailing spaces at the end of a line as "insert linbreak".
This means we are free to insert single line breaks wherever we want, without affecting the look of the resulting HTML page.
A recommended style for markdown is thus to use "semantic linefeeds", i.e. place (unparsed) single line breaks after each sentence and between different logical parts / "chunks" within a sentence.
My suggestion is to add this to our style guide and update existing bad-formatted markdown code accordingly.
Possible alternatives
An alternative solution would be to decide that we do not want to adopt this idea.

we chose to not want to adopt the idea


Creating main/welcome page

Main page's summary profile and results

[ ] Profile picture on top left (refer to the wireframe in discord) [tapping on picture leads to "Profile page"
[ ] Contain name, Age
[ ] Contain cognitive status summary: either Healthy /or/ Recommended for doctor visit --> If Recommended for doctor visit - sugggest why based on test performance ex. "Your scores in working memory domain is relatively low."
[ ] Contain big buttons that link to other pages including

[ ] Cognitive tests page
[ ] Survey questions page
[ ] Other tests page
[ ] Wearable data page (Last priority if we can get to here)
[ ] Clinical site page (This page will be mostly blank, just for future feature)
[ ] MD connect page (This page will be mostly blank, just for future feature)

@Lucas-ZX-W  I remember you want it to be notification based, which is a great idea, but could you add a feature to defer the tests in case the user is not ready?

@Lucas-ZX-W I remember you want it to be notification based, which is a great idea, but could you add a feature to defer the tests in case the user is not ready?

The things that the user needs to look out for taking any test would be displayed both in the notification on the home screen and on the test itself in the tasks view, suggesting the user to delay the test if they're not ready. I'd imagine that when the user selects the task it would ask another time if the user is ready to take it. If not, we assign the test a different time (to take) and the organization of the test and notification should take care of its new time by placing it elsewhere in the stack accordingly.

Yup, what you imagine is right. I agree.


wip: Attempt again to solve some pinning errors

Motivation

Fixes #649
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_OYohat7te1Ltd4
→ https://go/builds/bui_OYohfykOvaOe0R
→ https://go/builds/bui_OYohcNUDEgufz3


Add descriptions to additional subprojects

Fixes #19038

Assignments: https://docs.google.com/spreadsheets/d/1g11HoRZrOp6x13P87aspLInq8Yq8T5YH9QUOF136sII/edit#gid=0

@bot-gradle test QFL

OK, I've already triggered QuickFeedbackLinux build for you.

@bot-gradle test and merge

No milestone for this PR. Please set a milestone and retry.

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


[WIP]Returned epoch instances in functions. Fix #2801.

Returned self in case of equalize_event_counts and epochs_list in case of equalize_epoch_counts.
However in issue #2801, it was explicitly mentioned to return self in case of equalize_epoch_counts while that is not a class method, just a function. What exactly is meant by self there?
Lastly I am new to mne and this is my first PR, so please go easy on me!
Thank you!

I guess it means equalize_epochs_counts should also return the list of epochs objects, although I'm not perfectly sure we should do that.

sorry, I think it is a false alarm. my issue should have been closed. if copy=False, epochs=self, and epochs is returned. if actions are being done in-place, then it's all good.

I think the existing logic is "preserve old behavior", which makes for ugly
package consistency but better backward compatibility. In other words, many
functions had implicit (or explicit) default copy behavior in their first
implementation (as method or function), and we generally stuck with
whatever behavior originally existed going forward.
That said, I think the trend has been for new implementations to be methods
(assuming heavy enough anticipated use) with default copy=False.

@jasmainak @jona-sassenhagen @teonlamont @Eric89GXL if I understand correctly from above discussions, the current behavior is expected and the issue was a false alarm?
What really seems to be the issue is the with the inconsistency of the default value of copy, which could be opened as a separate issue. Should we close this PR then?

yeah, it was a false alarm. however, like @Eric89GXL mentioned, we should make an issue, or PR to address the copy behavior. This PR can be closed

@teonlamont Alright! Closing!


Is it possible to use Self-hosted Mysql or MariaDB?

Is it possible to use Self-hosted Mysql or MariaDB?  Due to some concerns of my company, we would like to be able to use our internal DMBS if possible.

Yes, PlanetScale uses MySQL so you should be able to use your own database if you like.


Access image report information

In ecli slide info, would be good to have report information, if any.

With ecli slide info --report. Flag ignored is no report available for that slide, otherwise set a "report" entry in the JSON reply.

Instead of adding the report data into the slide's JSON data, the --report flag may return report data only. So a slide with no report data would return an empty string.
@lalmei What do you think?


Update Composer dependencies (2023-12-10-00-08)

Visual regression test passed!
View the visual regression test report


Incorrect declaration of sockaddr_in

This code incorrectly declares sockaddr_in, which is actually struct sockaddr_in. This leads to the following compile failures on the Microsoft C++ compiler:
serv.c(25): error C2065: 'sockaddr_in': undeclared identifier
serv.c(25): error C2146: syntax error: missing ';' before identifier 'RecvAddr'
serv.c(25): error C2065: 'RecvAddr': undeclared identifier
serv.c(32): error C2065: 'sockaddr_in': undeclared identifier
serv.c(32): error C2146: syntax error: missing ';' before identifier 'SenderAddr'
serv.c(32): error C2065: 'SenderAddr': undeclared identifier
serv.c(33): error C2065: 'SenderAddr': undeclared identifier
serv.c(51): error C2065: 'RecvAddr': undeclared identifier
serv.c(51): error C2224: left of '.sin_family' must have struct/union type
serv.c(52): error C2065: 'RecvAddr': undeclared identifier
serv.c(52): error C2224: left of '.sin_port' must have struct/union type
serv.c(53): error C2065: 'RecvAddr': undeclared identifier
serv.c(53): error C2224: left of '.sin_addr' must have struct/union type
serv.c(55): error C2065: 'RecvAddr': undeclared identifier
serv.c(65): error C2065: 'SenderAddr': undeclared identifier

However, changing to struct sockaddr_in for each declaration makes it compile with no errors:
>cl serv.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27032.1 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

serv.c
Microsoft (R) Incremental Linker Version 14.16.27032.1
Copyright (C) Microsoft Corporation.  All rights reserved.

/out:serv.exe
serv.obj

@jweinst1 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Bug for Flutter 2.2.2 - When I add android_intent and build Android, it will create build dir at android/app/build.

Use case

When I add android_intent and build Android, it will create build dir at android/app/build.
Proposal

Hi @v7lin
Please read the [this(https://pub.dev/packages/android_intent#deprecation-notice) and use android_intent_plus
For issues related to android_intent_plus, please file on their dedicated GitHub repository.
Closing


Radar cluttertest doesn't consider no clutter

On occasion, the radar clutter test raises an error due to no clutter being generated leading to len(detections) == 1.
See:
https://github.com/dstl/Stone-Soup/blob/31b5ff296dee2eff5732dd6fe6804c8d12384010/stonesoup/sensor/radar/tests/test_radar.py#L675

Good point! A quick fix could be to increase the clutter rate in the test. But since it is Poisson distributed, there could still be no clutter (but it would happen more rarely). What if I added an attribute to the clutter model that would be True if it generated clutter at the current time step, and False if it didn't? I'm thinking before line 72 in clutter.py. Then the test could use that attribute to adjust the assertion. Is that overkill?

A fix seed could also be used? Or the test could loop over measure, say 3 times, appending measurements, and check that number of measurements is greater than 3.

Actually, looking at the clutter model, it may be worth adding an option for a seed to be set, such that runs in general can be reproduced. Can then use this to get reproducible test as well.
Example here with Gaussian Models: https://github.com/dstl/Stone-Soup/blob/31b5ff296dee2eff5732dd6fe6804c8d12384010/stonesoup/models/base.py#L207-L215
Or in simulator: https://github.com/dstl/Stone-Soup/blob/31b5ff296dee2eff5732dd6fe6804c8d12384010/stonesoup/simulator/simple.py#L93-L98 https://github.com/dstl/Stone-Soup/blob/31b5ff296dee2eff5732dd6fe6804c8d12384010/stonesoup/simulator/simple.py#L122-L124
(Side note: I think line 98 in sim should be same as 215. Might be bug there)

That is a good idea! I will work on that.
I agree with your side note. If the seed is None, that might cause a problem on line 98.

I started implementing this change. I made a seed parameter and a RandomState object.
    seed: Optional[int] = Property(         default=None,         doc="Seed for random number generation")
def __init__(self, *args, **kwargs):
    super().__init__(*args, **kwargs)
    self.random_state = np.random.RandomState(self.seed)`

We can use self.random_state.poisson() to randomly determine how many clutter points to create. But I'm not sure how to make it work when we call the distribution function parameter. This function gets passed in by the user and is responsible for actually generating the random points where clutter will be. Do you know how to make the RandomState object call a function where all we have is a pointer to the function? We could just set a numpy seed, but the documentation says to try to avoid that and use RandomStates instead. I'm a little stuck on how to do this.
Here is the line where we call self.distribution
https://github.com/dstl/Stone-Soup/blob/31b5ff296dee2eff5732dd6fe6804c8d12384010/stonesoup/models/clutter/clutter.py

I'm not sure how to make it work when we call the distribution function parameter. This function gets passed in by the user and is responsible for actually generating the random points where clutter will be. Do you know how to make the RandomState object call a function where all we have is a pointer to the function? We could just set a numpy seed, but the documentation says to try to avoid that and use RandomStates instead. I'm a little stuck on how to do this. For reference, we call self.distribution on line 73 https://github.com/dstl/Stone-Soup/blob/main/stonesoup/models/clutter/clutter.py

I guess it's possible to pass something like np.random.RandomState(self.seed).uniform for the distribution if there is need for a fixed seed?


Confusing negative forms in config descriptions

Hi there, and thanks a lot for making this project!
There is a small issue though: in https://github.com/crate-ci/cargo-release/blob/master/docs/reference.md#config-fields I can see that the description of some boolean flags might cause confusions about what true/false actually mean:
https://github.com/crate-ci/cargo-release/blob/2df2af97709106c5c8d6f8695bb4b291db34b350/docs/reference.md?plain=1#L113
https://github.com/crate-ci/cargo-release/blob/2df2af97709106c5c8d6f8695bb4b291db34b350/docs/reference.md?plain=1#L121
https://github.com/crate-ci/cargo-release/blob/2df2af97709106c5c8d6f8695bb4b291db34b350/docs/reference.md?plain=1#L127
https://github.com/crate-ci/cargo-release/blob/2df2af97709106c5c8d6f8695bb4b291db34b350/docs/reference.md?plain=1#L133
https://github.com/crate-ci/cargo-release/blob/2df2af97709106c5c8d6f8695bb4b291db34b350/docs/reference.md?plain=1#L134
The list might not be exhaustive but I believe the point has been made.
IMHO it's a bit dangerous to use "don't" in such descriptions, although I have little idea about what to do to fix this either 🤔

I think this is documentation that went stale with #340.


Dataloaders for ECL and Weather

Hello everyone,
first of all, thank you for your amazing paper!
We are currently trying to reproduce your results and want to run the experiments on the weather and ECL datasets. Would it be possible for you to also publish the two data loaders you used for those particular datasets to keep the preprocessing consistent.
Thanks a lot in advance!

Thanks for your attention to this work!
Since we have provided the customized data loader in the colab examples, it should be enough for guys in reproducing our results. Besides, we also keep the same preprocessing trick as the original data provider. We think it may be inappropriate to provide these datasets and data loaders through us. I hope you could understand.

If you do have problems with these data loaders, you can contact us through email. And I will close this issue now.


SDM845 Media1: ASoC: no backend DAIs enabled

dmesg is full of errors:
[   23.308596]  SDM845 Media1: ASoC: no backend DAIs enabled for SDM845 Media1
[   23.308811] q6asm_audio_client_buf_alloc_contiguous: buffer already allocated
[   23.308888]  SDM845 Media1: ASoC: no backend DAIs enabled for SDM845 Media1
[   23.309090] q6asm_audio_client_buf_alloc_contiguous: buffer already allocated
[   23.309166]  SDM845 Media1: ASoC: no backend DAIs enabled for SDM845 Media1
[   23.309318] q6asm_audio_client_buf_alloc_contiguous: buffer already allocated
[   23.309434]  SDM845 Media1: ASoC: no backend DAIs enabled for SDM845 Media1
[   23.309530] q6asm_audio_client_buf_alloc_contiguous: buffer already allocated
[   23.309645]  SDM845 Media1: ASoC: no backend DAIs enabled for SDM845 Media1
[   23.310102] q6asm_callback: cmd = 0x10bcd returned error = 0x1
[   23.310187] __q6asm_cmd: DSP returned error[ADSP_EFAILED] opcode 68557

When this occurs, sound jumps to max volume. For test, start youtube video, pause, start again. If errors will show up, volume will be on max

Fixed the log messages by https://github.com/sailfishos-sony-tama/droid-config-sony-tama-pie/commit/052b7d7df88d939913b3cbac416a87e84d7106c7 . Volume issue is still there. Closing this and treating volume issue separately.


SSL Certification Error

deep_translator version: 1.9.1
Python version: 3.9
Operating System: Win 11

Description
Error:
ERROR out: HTTPSConnectionPool(host='translate.google.com', port=443): Max retries exceeded with url: /m?tl=pt&sl=en&q=my+name+is+python(Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate in certificate chain (_ssl.c:1129)')))
My Code:
from deep_translator import GoogleTranslator
translator = GoogleTranslator(source='en', target='pt')
data = 'my name is python'
translator.translate(data)

@souravkrpathak This looks like an issue with your system. It is not related to deep-translator.
Make sure that your system is configured correctly, you can find many examples about this error online.
I guess, I can allow arguments to be passed to deep-translator under the hood as a hack (specifically the verify=False argument), but this is not a good idea for security reasons. So the best option would be from your side to verify your configuration.

Thanks @nidhaloff for your response


docs: More TypeScript previews

Codecov Report

Merging #2357 (2497600) into master (eebf32f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2357   +/-   ##
=======================================
  Coverage   98.22%   98.22%
=======================================
  Files         128      128
  Lines        2030     2030
  Branches      310      310
=======================================
  Hits         1994     1994
  Misses         19       19
  Partials       17       17

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Allow account selection when creating new content

If I have multiple micropub accounts configured within Indigenous, it would be nice to be able to select which one to use to create new content when I go to create that content.
As it is now, I need to go to the settings, switch accounts, go back, then start to create content.
Can the new post screen show a drop-down of accounts (defaulting to the default account)?

Thanks! Definitely something that I’d like to add. I have something similar in the Share Sheet in Safari


Better transactional handling in sqlite

With my application I found many "IntegrityError: column key is not unique" errors. This is because the select statement inside of __setitem__ wasn't in a transaction with the insert/update. So some other process could come along and add the key between the two statement. Rather than use a transaction I switched to using the "insert or replace into" statement which handles both cases effectively. Also updated __delitem__ since that one could suffer from a similar problem.

Thank you!


Framework vs Library

What is the difference between framework and library?

A software framework is a re-usable design for a software system (or subsystem). A software framework may include support programs, code libraries, a scripting language, or other software to help develop and glue together the different components of a software project. Various parts of the framework may be exposed through an API..read more


Add support for Star Wars FFG Game System

Not sure if this is a feature request or a bug: Creating a PDFoundry_PDF isn't an option in the SWFFG game system.

Hi @AtreidesGhola - PDFoundry no longer uses items for PDFs, and has not for many months. Please update your version and you will see the button to create PDFs appear in the journal entries tab. Thanks!

Thanks @Djphoenix719  - I haven't used Foundry in quite some time - I installed 0.7.9, and hit update all on the Add-Ons page.  I assumed I was running the current version.
Lol, don't I feel sheepish.


Security scan workflow probe

Description
This probe checks whether the workflow defined in jenkins-infra/jenkins-security-scan/.github/workflows/jenkins-security-scan.yaml is configured in the plugin repository.
Closes #257

Testing done

Unit test cases in progress.

Submitter checklist

[x] If an issue exists, it is well described and linked in the description
[x] The description of this pull request is detailed and explain why this pull request is needed
[x] The changeset is on a specific branch. Using feature/ for new feature, or improvements ; Using fix/ for bug fixes ; Using docs/ for any documentation changes.
[ ] If required, the documentation has been updated
[x] There is automated tests to cover the code change / addition or an explanation why there is no tests in the description.

Just a small bunch of really small indentation/style issues I noticed, but after that the PR should be all good to go, nice job :muscle:


fake-bootstrap snippet should escape certain characters

let run cmd args dir =
    let pinfo = ProcessStartInfo(cmd,args)
    pinfo.WorkingDirectory <- dir; pinfo.UseShellExecute <- false; pinfo.RedirectStandardOutput <- true
    let proc = Process.Start(pinfo)
    proc.StandardOutput.ReadToEnd() |> printfn "< %s >
%s" cmd; proc.WaitForExit()

run @".paketpaket.bootstrapper.exe" "" ""
run @".paketpaket.exe" "restore -f" ""

Notice the inadvertent linebreak after > in the last line of run, as well as no backslashes in the two path arguments to run.

looks like backslashes are escaped \\\\ in the snippets
will be fixed in the next release https://github.com/ionide/ionide-fake/pull/5


add 'no coordinates' to the Transarctos Unified Reporting Directive

Source
https://github.com/ArctosDB/arctos/issues/7760
Summary
Make the TURD even better.
User Interface Changes
new report
Data Structure Changes
nope

prioritizing for @mkoo


feat: compute func deps in logical plan

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


docker rmi "image@digest" should not "untag" digests

(relates to https://github.com/docker/docker/pull/23996, https://github.com/docker/docker/pull/23649)
While working with 1.12-rc4, I noticed some UX inconsistencies;
Pulling an image looks good (much improved);
docker pull hello-world
Using default tag: latest
latest: Pulling from library/hello-world
Digest: sha256:0256e8a36e2070f7bf2d0b0763dbabdd67798512411de4cdcf9431a1feb60fd9
Status: Downloaded newer image for hello-world:latest

Looking good:
docker images --digests --no-trunc hello-world
REPOSITORY          TAG                 DIGEST                                                                    IMAGE ID                                                                  CREATED             SIZE
hello-world         latest              sha256:0256e8a36e2070f7bf2d0b0763dbabdd67798512411de4cdcf9431a1feb60fd9   sha256:c54a2cc56cbb2f04003c1cd4507e118af7c0d340fe7e2720f70976c4b75237dc   13 days ago         1.848 kB

However, when trying to remove an image, using the digest;
docker rmi hello-world@sha256:0256e8a36e2070f7bf2d0b0763dbabdd67798512411de4cdcf9431a1feb60fd9
Untagged: hello-world@sha256:0256e8a36e2070f7bf2d0b0763dbabdd67798512411de4cdcf9431a1feb60fd9

It's only removing the digest. This is confusing:
REPOSITORY          TAG                 DIGEST              IMAGE ID                                                                  CREATED             SIZE
hello-world         latest              <none>              sha256:c54a2cc56cbb2f04003c1cd4507e118af7c0d340fe7e2720f70976c4b75237dc   13 days ago         1.848 kB

I don't see any practical use for just removing the digest.
Using the image-id, on the other hand:
docker rmi sha256:c54a2cc56cbb2f04003c1cd4507e118af7c0d340fe7e2720f70976c4b75237dc
Untagged: hello-world:latest
Untagged: hello-world@sha256:0256e8a36e2070f7bf2d0b0763dbabdd67798512411de4cdcf9431a1feb60fd9
Deleted: sha256:c54a2cc56cbb2f04003c1cd4507e118af7c0d340fe7e2720f70976c4b75237dc
Deleted: sha256:a02596fdd012f22b03af6ad7d11fa590c57507558357b079c3e8cebceb4262d7

Actually deletes the image.
Similar, in a situation where the image is tagged under two names;
docker pull hello-world
….
docker tag hello-world hello-world:2

docker images --digests --no-trunc hello-world
REPOSITORY          TAG                 DIGEST                                                                    IMAGE ID                                                                  CREATED             SIZE
hello-world         2                   sha256:0256e8a36e2070f7bf2d0b0763dbabdd67798512411de4cdcf9431a1feb60fd9   sha256:c54a2cc56cbb2f04003c1cd4507e118af7c0d340fe7e2720f70976c4b75237dc   13 days ago         1.848 kB
hello-world         latest              sha256:0256e8a36e2070f7bf2d0b0763dbabdd67798512411de4cdcf9431a1feb60fd9   sha256:c54a2cc56cbb2f04003c1cd4507e118af7c0d340fe7e2720f70976c4b75237dc   13 days ago         1.848 kB

docker rmi hello-world@sha256:0256e8a36e2070f7bf2d0b0763dbabdd67798512411de4cdcf9431a1feb60fd9
...

REPOSITORY          TAG                 DIGEST              IMAGE ID                                                                  CREATED             SIZE
hello-world         2                   <none>              sha256:c54a2cc56cbb2f04003c1cd4507e118af7c0d340fe7e2720f70976c4b75237dc   13 days ago         1.848 kB
hello-world         latest              <none>              sha256:c54a2cc56cbb2f04003c1cd4507e118af7c0d340fe7e2720f70976c4b75237dc   13 days ago         1.848 kB

Also, just the digest is removed
Expected result
I expect the digest to work similar to using the image-id, so, delete the image if possible, or produce an error if not. But don't remove just the digest.

ping @dmcgowan @stevvooe @dnephin
I added this to the 1.12 milestone, as this was improved in 1.12

I think this is correct. The digest is working the same way as a tag.

I think the difference is that I cannot "re-tag" an image with a different digest (unless the content changes), so from a user perspective, its an immutable identifier. Removing that identifier feels kinda "weird", and I'm not sure why we would do that.

You can always re-pull to get the digest again.
This behaviour hasn't changed since 1.11:
$ docker version
...
 Version:      1.11.0-rc4
$ docker pull redis
...
Digest: sha256:b50f15d427aea5b579f9bf972ab82ff8c1c47bffc0481b225c6a714095a9ec34
Status: Downloaded newer image for redis:latest

$ docker pull redis@sha256:b50f15d427aea5b579f9bf972ab8
...
$ docker rmi redis@sha256:b50f15d427aea5b579f9bf972ab82ff8c1c47bffc0481b225c6a714095a9ec34
Untagged: redis@sha256:b50f15d427aea5b579f9bf972ab82ff8c1c47bffc0481b225c6a714095a9ec34

I agree that it's probably working as designed, but I would think that the digest is more part of the image, rather than a tag that can be removed.
I don't really want to see some special case in the code, but I am not sure what the right answer is.
The behavior is surprising in my opinion.

I expect the digest to work similar to using the image-id, so, delete the image if possible, or produce an error if not. But don't remove just the digest.

I think this is a reasonable expectation. We are trying to have the behavior of the digest be similar to image id, which up until this release has not been at all. Considering this is not a regression I would not give it a high priority, but I will work on a patch for it.

One thing to keep in mind is that an image may have multiple digests associated with it. It would be very surprising if untagging one of two digests removed a tag and deleted the image. Given that removing one of two digests probably shouldn't remove the image, I'm not sure we should introduce another special case where removing the single digest will remove the tag and delete the image.
I think before moving forward with this, we should agree on a complete matrix showing the expected behavior of deleting a tag, digest, or image ID when there are 0, 1, or 2 tags and 0, 1, or 2 digests.

What is going on here? Why are we "untagging" digests?
This is not even close to working as designed.

@stevvooe "untagging" is misleading. We currently do treat digests as references which can be removed as references. As part of this change we should discuss what the behavior should be as Aaron mentioned. Unlike image ids, images can have multiple manifest digests. However we can always just treat them as image ids and remove in mass, the confusion comes if the "intended use" is to remove a digest. I think I agree that removing a digest form an image id does not need to and maybe should not be supported.
Current docker rmi behavior

Remove by
Tags
Digests
Removed references
Image deleted

tag
1
0
1 tag
yes

tag
1
1
1 tag, 1 digest
yes

tag
1
2+
1 tag, all digests
yes

tag
2+
any
1 tag
no

id
0
any
all digests
yes

id
1
0
1 tag
yes

id
1
1
1 tag, 1 digest
yes

id
1
2+
1 tag, all digests
yes

id
2+
any
fails
no

digest
0
1
1 digest
yes

digest
any
2+
1 digest
no

digest
1
1
1 digest
no

digest
2+
1
1 digest
no

The rows in question are the last 3, sounds like the desire behavior to make it more like image id would be.

Remove by
Tags
Digests
Removed references
Image deleted

digest
0
any
all digests
yes

digest
1
any
1 tag, all digests
yes

digest
2+
any
fails
no

I think @dmcgowan's proposed behavior looks right. One thing I'm a bit confused by is "multiple digests"; can you give an example when a single image has multiple digests (and how?), and what that would look like from a user perspective?

Multiple digests can occur when pulling an image from multiple repositories which had layers with different digests. A different layer digest can occur anytime a layer ends up getting pushed, rather than mounted via cross repository mounted or skipped because it already exists. The formation of the tar should now be stable but we cannot guarantee the gzip algorithm will produce the exact same artifact digest, and therefore the same manifest digest. An example would be a user pulling down the image ubuntu, building an image from that image, and pushing it to a private repository. A new digest could be created during that push if any of the layers produce a different digest than what is pulled. We try to avoid it, but it is currently out of our control without having the original artifact to send to the private registry.

Thanks for explaining! Wouldn't the image id be different in that case as well?

Negative. The image ID is not affected by compression of artifacts.

I made a change to update the behavior and it feels right so far. The case where the image is tagged in multiple repositories is already handled by the multiple tag check (see below). In this case -f will force remove even across named repositories, which I think makes sense as well.
$ docker rmi something@sha256:661f2e4c9470e7f6238cebf603bcf5700c8b948894ac9e35f2cf6f63dcda723a
Error response from daemon: conflict: unable to delete a180b24e38ed (must be forced) - image is referenced in one or more repositories
$ docker rmi -f something@sha256:661f2e4c9470e7f6238cebf603bcf5700c8b948894ac9e35f2cf6f63dcda723a
Untagged: dmcgowan/something:latest
Untagged: something:latest
Untagged: something@sha256:661f2e4c9470e7f6238cebf603bcf5700c8b948894ac9e35f2cf6f63dcda723a
Deleted: sha256:a180b24e38eddf9e2133d07e9dc4c2ce7e74cb5adfe5bd34968a2b38f9685856
Deleted: sha256:da1ce37cb92a2d4704c21d44feb788b4b7312dc748ff086c093751b0a5e5434b
Deleted: sha256:5a56aca1dc3762f9080b27f4a38d08db26a59a0ea9b2c29cdcea7d5e00f7dbc6
Deleted: sha256:fbe47db404463ff45764edfd9e7a7d1b281e74284101cffd3b12bf6e5c33d9d7

Need to get some tests updated but have a work in progress branch here https://github.com/dmcgowan/docker/tree/rmi-manifest-digest-like-image-id, will cleanup and submit on wednesday when back from PTO.

Is this really a 1.12 issue? Is this not present since 1.10?

@cpuguy83 the behavior was changed for 1.12 to always store the digest; not sure if it's 1.12 specific, but would be good to have the behavior right

In earlier versions, an image either had a digest, or a tag, but never both

In earlier versions, an image either had a digest, or a tag, but never both

Not true. It could have both, but a user would have had to explicitly pull by digest to get both, which was very rare.

Is this really a 1.12 issue?

No, it is not. I showed in https://github.com/docker/docker/issues/24688#issuecomment-232993537 that the issue is there in 1.11. It's just more prevalent with the changes in 1.12.

@dnephin this is the behavior in 1.11;
docker pull alpine:latest
docker pull alpine@sha256:3dcdb92d7432d56604d4545cbd324b14e647b313626d99b889d0626de158f73a

docker images --digests

REPOSITORY          TAG                 DIGEST                                                                    IMAGE ID            CREATED             SIZE
alpine              latest              <none>                                                                    4e38e38c8ce0        3 weeks ago         4.799 MB
alpine              <none>              sha256:3dcdb92d7432d56604d4545cbd324b14e647b313626d99b889d0626de158f73a   4e38e38c8ce0        3 weeks ago         4.799 MB

That's right. We changed the list output, but that is still a single image (4e38e38c8ce0) with both a tag and a digest.

From a user perspective, they're two images, and in the 1.11 situation, "untagging" made sense, because the "image" I referred to disappears;
docker rmi alpine@sha256:3dcdb92d7432d56604d4545cbd324b14e647b313626d99b889d0626de158f73a
Untagged: alpine@sha256:3dcdb92d7432d56604d4545cbd324b14e647b313626d99b889d0626de158f73a

docker images
REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
alpine              latest              4e38e38c8ce0        3 weeks ago         4.799 MB

IMO this change should not be present in 1.12 as it didn't even make the feature freeze -  both referenced PRs were merged as part of 1.12-rc3. This should be deferred to 1.13.


Remove the "CREDIT CARD" from STORE payment option. It does not work.

Marc.
Having the option for two credit cards creates confusion. Please remove it and have only one option in the store to run a credit card.

Think I got all the places Credit Card was mentioned.


feat: insert into sqlite tables

This is close, but the test fails with a common error from SQLite on
the insert statement (e.g. attempt to write a readonly database). I'm pretty sure that this isn't due to the python sqlite
library which creates the db and sets things up, but something with
how we (probably?) create the sqlite client object.
Wanted to put this up so @vrongmeal could take a quick look and make
sure there isn't something specific to the rest of our implementation
that I missed.

This is close, but the test fails with a common error from SQLite on
the insert statement (e.g. attempt to write a readonly database). I'm pretty sure that this isn't due to the python sqlite
library which creates the db and sets things up, but something with
how we (probably?) create the sqlite client object.

Yeah, we do create the client in "read-only" mode: https://github.com/GlareDB/glaredb/blob/9c27dd0289481bcca895b4a3764002682d7d8e16/crates/datasources/src/sqlite/wrapper.rs#L32-L36


Code injection plugin/module system

Current state
Currently, we are shipping a "monolithic" binary with patches for common use-cases, which imposes the following problems:

Users can't selectively enable or disable patches, so if a patch causes issues, the only option is to disable code injection entirely.
Adding custom functionality is difficult and annoying, users have to fork this repo and build their own binary to make changes. If users want to include upstream changes in their forks, they have to merge the changes manually.

Implementation
Instead of shipping code in one binary, hyperbeam should act as a "plugin manager" which loads other NROs and provide some useful functionality for patches. Skyline can be used as a reference on how to implement this: https://github.com/skyline-dev/skyline/blob/master/source/skyline/plugin/PluginManager.cpp
Challenges

Code hooking is currently implemented by patching the binary by generating an IPS file (see https://github.com/tech-ticks/hyperbeam/blob/master/patches/codehook.slpatch). This will no longer be possible because plugins can be dynamically loaded. Instead, dynamic runtime hooks can be used (see https://github.com/skyline-dev/skyline/blob/master/source/skyline/inlinehook/And64InlineHook.cpp#L645)
Functions from the game binary need to be called in a different way. The symbols are currently linked with a linker script, e.g. PegasusActDatabase_ActorData_get_Name = 0x061F1A0 - 0x5caf000;. This works because we know where both the game binary and the hyperbeam binary are loaded in memory. Some ideas on how to work around it:

Research whether absolute jumps can be used in linker scripts (easiest option; should work because the game binary is always loaded in the same address)
Attempt to re-export the symbols in the "main" hyperbeam binary to make them accessible in plugins via dynamic linking. Preferred option because it would allow most plugins to work on all game versions without compiling them twice
Generate a header file with function pointers to absolute addresses
Keep the current linker script approach with relative jumps and "move" every plugin to the same specific address in memory when its code is executed, e.g. by reordering the virtual memory pages. Complicated and error-prone, probably a bad idea

API proposal
Callbacks for common hooks, e.g. when the game starts or on every frame, should be provided. After a plugin was loaded, an initialization function of the plugin is called, which should return a struct with information like the plugin name. There are separate callbacks when plugins are enabled or disabled to allow users or plugin developers to dynamically enable and disable plugins in the future. A simple plugin could look like this:
#include <hyperbeam/plugin.h>

extern "C" hb::PluginInfo hbPluginOnInit(void* reserved) {
  return hb::PluginInfo {
    .id = "authorname.exampleplugin",
    .name = "Example plugin",
    .author = "Author name",
    .version = hb::Version(1, 0, 0), // 1.0.0
    .flags = hb::PluginFlags::SOME_FLAG | hb::PluginFlags::SOME_OTHER_FLAG,
    .result = hb::Result::OK // Allows returning errors if initialization failed
  }
}

void onUpdate(float deltaTime) {}
void onDungeonUpdate(float deltaTime) {}
void onSpecialFunc(int specialFuncId) {}

extern "C" hb::Result hbPluginOnEnable(void* reserved) {
  if ((hb::registerCallback(hb::Callbacks::UPDATE, onUpdate) != hb::Result::OK) // Every frame
    return hb::Result::ERROR;
  if ((hb::registerCallback(hb::Callbacks::DUNGEON_UPDATE, onDungeonUpdate) != hb::Result::OK) // Every frame in dungeons
    return hb::Result::ERROR;
  if ((hb::registerCallback(hb::Callbacks::SPECIALFUNC, onSpecialFunc) != hb::Result::OK) // When SpecialFunc is called in a script
    return hb::Result::ERROR;
  // ...

  // Custom hooks that are not supported through callbacks can be added with A64HookFunction(), see the link above
  return hb::Result::OK;
}

extern "C" hb::Result hbPluginOnDisable(void* reserved) {
  return hb::Result::OK;
}

Integration in DreamNexus
Plugins should not be directly supported in the DreamNexus UI; instead, the existing mod system should be leveraged to create "wrapper mods" that simply copy the plugin file to the expected directory at build time. Additional files that are required by the plugin can also be generated in the mod.

This will lead to a rewrite based on https://github.com/skyline-dev/skyline since it provides most of the required functionality.
Blocked by https://github.com/yuzu-emu/yuzu/issues/6076 and https://github.com/Ryujinx/Ryujinx/issues/2230
Ryujinx PR: https://github.com/Ryujinx/Ryujinx/pull/2451


Fix script for other cohorts e.g. 2013-2014

Base url for downloads updated to reflect year of the dataset e.g. 'https://wwwn.cdc.gov/Nchs/Nhanes/2013-2014'
Leading and trailing spaces removed from infodict value.

many thanks!


check before calling coqtail#stop on QuitPre

There might be multiple windows showing the current buffer. So calling coqtail#stop might be called even if I don't intend to stop the coq process. Using BufDelete seems to be a better for this type of functionality.

Looks good, thanks.


Stacker class

Overview
Adds a class to handle groups of Stack instances needed for taskcat test commands. For this purpose the Stacker class was rewritten created. It takes a Config instance as an input and can either create_stacks or import from_existing (to support decoupled/stateless use of taskcat in the future). Should additional deployment mechanisms (not cloudformation) be added in the future, they would need to implement only the public API's of Template and Stacker classes and should work as drop in replacements to the cloudformation implementation.
Operations that involve use of cloudformation API's are grouped into concurrency groups to ensure the highest level of concurrency while minimizing the risk of throttling. Stack properties and calls to events/resources/children use a cache (default ttl 1min) to make repeated calls fast and reduce api load.
Testing/Steps taken to ensure quality
manual testing for now, would like to get some feedback and a taskcat test implementation done before spending effort on unit tests for what's likely to see a fair amount of short-term churn.
Notes
There are some minor changes to other parts of taskcat included in this pr that were needed for functional testing to work.
Testing Instructions
setup a config:
from pathlib import Path
from taskcat import Config

c = Config(
    project_config_path=Path('./tests/data/nested_fail/ci/taskcat.yml'
                             '').resolve(),
    project_root=Path('./tests/data/nested_fail/').resolve()
)

create the stacks:
from taskcat._cfn.threaded import Stacker
from taskcat._s3_stage import stage_in_s3

stage_in_s3(c)
s = Stacker(c)
s.create_stacks()

Check the status:
s.status()

Out[1]:
{'IN_PROGRESS': {},
 'COMPLETE': {},
 'FAILED': {'arn:aws:cloudformation:us-west-2:...': 'The following resource(s) failed to create: [ChildStack]. ',
  'arn:aws:cloudformation:us-east-1:....': 'The following resource(s) failed to create: [ChildStack]. '}}

hmm, both stacks failed, let's look at what/why:
for resources in s.resources(status='CREATE_FAILED').values():
    for resource in resources:
        print(f'{stack_id} resource {resource.logical_id} of type {resource.type} failed')

arn:aws:cloudformation:us-east-1:.... resource ChildStack of type AWS::CloudFormation::Stack failed
arn:aws:cloudformation:us-west-2:... resource ChildStack of type AWS::CloudFormation::Stack failed

Notice the filter being applied with s.resources(status='CREATE_FAILED') any property of an Stack, Event or Resource can be used as a filter. If multiple filters are passed they work as AND conditions.
...more usage examples to come...

Also see this:

https://github.com/aws-quickstart/taskcat/issues/318

Also see this:

aws-quickstart/taskcat#318

not importing requests from botocore anywhere in this pr, only remaining imports are from legacy parts of the code-base due for replacement


GCE to also get hostname

For our usecase, we're running on GKE and would love to also have hostname of GCE requested and populated to otel-collector. Currently, the HostName returns InstanceName instead of hostname:
https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/ca90414cd9c87f4babe529bdaf7241810d7336db/detectors/gcp/gce.go#L41-L44
I just wonder if there's any reason blocking adding it? If not, I can open a PR for this.

That seems reasonable to me.  Feel free to add it as GCEHostHostname or GCEHostname.  As a note, GCE attributes are not accessible on GKE if you are using workload identity (or autopilot, which uses workload identity).

@dashpole as a side note, should we deprecate GCEHostName and use GCEInstanceName`? IMO, it'll avoid ambiguous; however this change will break downsteam project.

I just realized they changed the host name attributes recently: https://github.com/open-telemetry/opentelemetry-specification/pull/838.  It appears we can only have either the name of the host, or the hostname of the instance as a semantic convention.
I assume hostname and instance name are generally significantly different"

In this case I think they are not that much of the difference. Actually, exposing GCE hostname would leave users with a more flexible of choices: why GCE on GKE expose hostname instead of instance name, users can use gcp detector to get the hostname, or system detector to get instance name of hostname command.
In resourcedetection processor we can add a fallback from instance name to hostname, wdyt?

The system detector doesn't use GCE metadata server, it picks the hostname locally if used with hostname_sources: ["os"] which is actually the instance.name metadata. So users can choose to use system detector or gcp detector's fqdn hostname for host.name, that's the flexible I mentioned before.

Thanks for the PR @nhamlh. We'll try to get this reviewed and merged soon

I agree with mx-psi above.  I would prefer to see this added to the specification before adding it to the resource detector.

To summarize, we can't change the value of host.name in the collector because that would be breaking. But, we can add 2 new gcp specific labels gcp.instance.name and gcp.instance.hostname in the resource detection processor.
The change in #515 alone won't break anything, because that's just adding the new method to the detector. For that reason, I think we could go ahead and merge #515 without any spec changes, but adding the new labels by default in the collector processor should have the spec change first. Does that sound right to everyone?

Opened https://github.com/open-telemetry/opentelemetry-specification/pull/3384 upstream to add gcp.gce.instance.name and gcp.gce.instance.hostname

With https://github.com/open-telemetry/semantic-conventions/pull/15 merged, we will be using the 2 new attributes mentioned above (once a new semconv release is published)
@nhamlh, are you still interested in working on #515 ?

Opened https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/pull/669


Allow right stick to control pointer speed, map right click to ZL

This should improve the right stick pointer control. The pointer should move faster the further the stick is actuated.
To change the overall pointer speed, the variable "slowdown"  here https://github.com/rsn8887/devilution-nx/blob/4c5cc1d55cfa543ad6a0708e0cc735be7a6f3639/SourceX/miniwin/misc_msg.cpp#L439
can be adjusted:
I cannot test the code here, because I get a compilation error "3rdParty/StormLib/src/StormPort.h:137:12: fatal error: sys/mman.h: No such file or directory". Maybe the compilation instructions are missing a step?

I also added the "Map right click to ZL" functionality. And I moved the heal potion to A button (unused before).


Fix blocking event subscription in transactAndHold (develop)

Same as: #266 for develop

FIPF, same hotfix as applied on master in #266


[Improve] function name optimization

finsh_block to create_block , create_block seems to be more suitable, it's just a small idea of mine, if it doesn't fit please let me know and I'll close this pr out

@skyzh hi, excuse me. if you have time, could you review my pr? I can close this pr if there is a problem

I don't feel there's a strong reason to change finish_block -> create_block...? given we are actually finishing up the block by appending metadata in the implementation.

thank your review and advice


[scss] relative path locations wrong when using @use

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.68.1
OS Version: Windows 10 21H2 - 19044.1766

Steps to Reproduce:

Open project with sass-files using @use
Ctrl-Click on the @use-paths to see that VS Code can't find the existing and working paths in the following situations:

issue 1
@use '../globals/colors'; // path is perfectly valid in scss and works so VS Code should go on a click to one folder up and search for 'globals/colors.scss' there, but instead searches on some non-existing absolute path 'globals/colors'.

issue 2
@use 'globals/colors'; // should find relative path as './globals/colors', but searches for 'node_modules/globals/colors.scss' instead (it works when using `./globals/colors` tho, but this is problematic as the sass migration tool auto-generates this path without a `./`

The paths in the examples above are perfectly fine Sass and do work fine with dart-sass too. Only VS Code handles the paths differently/not according to the sass rules.
These issues weren't there AFAIK when using @import. But @import is deprecated for a long time now and it is expected to get removed this year from the language, so we need to move to @use.
[edit] Another issue in VS Code resolving on scss files: webpack aliases aka aliases inside jsconfig.json aren't respected by VS Code. They work just fine and are perfectly valid by the Scss language/compiler, but a ctrl-click on an aliased link in a @use doesn't work in VS Code.
@use scssGlobals/color should be resolved to in this order (according to the sass docs):

relative path starting with scssGlobals if it exists
module scssGlobals if it exists (a starting ~ is optional nowadays)
webpack alias scssGlobals if it exists

Just updated the issue as there seems to be another issue with VS Code not resolving paths as the scss format describes.
Copy of edit to keep things organised here:
Another issue in VS Code resolving on scss files: webpack aliases aka aliases inside jsconfig.json aren't respected by VS Code. They work just fine and are perfectly valid by the Scss language/compiler, but a ctrl-click on an aliased link in a @use doesn't work in VS Code.
`@use scssGlobals/colors' should be resolved to in this order (according to the sass docs):
relative path starting with scssGlobals if it exists
module scssGlobals if it exists (a starting ~ is optional nowadays)
webpack alias scssGlobals if it exists

When searching for a solution online on Sass imports resolving (scss) in VS Code I see lots of people having the same request and same issues and didn't find a solution either. Without good support for imports in scss files IMO the editor is quite lacking.
Isn't it an idea to add a similar construction for scss as there is for Javascript (jsconfig.json) and typescript (tsconfig.json)? IMO  having a scssconfig.json with a construction like this would make sense and would solve the alias-problems:
{
    "include": ["src/scss/*"],
    "compilerOptions": {
        "paths": {
            "scss/*": ["src/scss/*"],
            "scssGlobals/*": ["src/scss/globals/*"],
            "scssIncludes/*": ["src/scss/includes/*"],
        }
    }
}

If something like scssconfig.json exists and is standard, then VS Code should support it. But VS Code should not come up with such a file. It's just an editor.

If something like scssconfig.json exists and is standard, then VS Code should support it. But VS Code should not come up with such a file. It's just an editor.

I understand. Eventhough Microsoft 'invented' the tsconfig.json?!
Why not add it to the settings.json instead?

We can looking some settings, though.
If you are interested into fixing the issue and improving the import lookup story, the code is at https://github.com/microsoft/vscode-css-languageservice/blob/main/src/services/scssNavigation.ts

Eventhough Microsoft 'invented' the tsconfig.json and jsconfig.json?!

:smile: The Typescript compiler team invented and maintains tsconfig.json, not VS Code.

These issues weren't there AFAIK when using @import. But @import is deprecated for a long time now and it is expected to get removed this year from the language, so we need to move to @use.

Just adding that this issue applies to @import statements as well.

This looks like a duplicate of issue 142836
Some things to note:

Issue doesn't occur in VSCode 1.63.2
Issue occurs only if package.json exists at project root


Python agents are not working after non-MPI support branch merged

Describe the bug
I tried to create a report with the python agent tutorial and I expected correct data instead all fields were zero.
When using the python agents, it is recommended that the legacy-dev branch be used until this issue is resolved in the dev branch.
GEOPM version
28e1581c5b2df12bc2ab7404a2d03f386ff7ff46
Expected behavior
No regressions in test_tutorial_python_agents.py assertions
Actual behavior
Test is failing and report has no timing or sampled data.
Error messages produced
======================================================================
FAIL: test_frequency_limit_report (integration.test.test_tutorial_python_agents.TestIntegration_tutorial_python_agents)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/test/geopm/integration/test/test_tutorial_python_agents.py", line 91, in test_frequency_limit_report
    places=0)
AssertionError: 5 != 0 within 0 places

======================================================================
FAIL: test_monitor_report (integration.test.test_tutorial_python_agents.TestIntegration_tutorial_python_agents)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/test/geopm/integration/test/test_tutorial_python_agents.py", line 64, in test_monitor_report
    places=0)
AssertionError: 5 != 0 within 0 places

======================================================================
FAIL: test_package_energy_report (integration.test.test_tutorial_python_agents.TestIntegration_tutorial_python_agents)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/test/geopm/integration/test/test_tutorial_python_agents.py", line 74, in test_package_energy_report
    places=0)
AssertionError: 5 != 0 within 0 places

Additional information
When bug is fixed, please also revert skip decorator added here:
b2628e82bd6a835c7076d4f98fa6dc45bbb41efc

Python agent feature is removed for 3.0 release.  May take a different form in future release now that non-MPI applications are supported by the C++ runtime.


QuantityValue.slot_usage.has_numeric_value.range: Float -> Double

We just have to pick one here

According to Claude:
The main differences between an XSD (XML Schema Definition) float and double are:

Precision:

float: An XSD float is a single-precision 32-bit floating-point number. It has a precision of approximately 7 decimal digits.
double: An XSD double is a double-precision 64-bit floating-point number. It has a precision of approximately 15 decimal digits.

Range:

float: The range of values that can be represented by an XSD float is approximately ±3.4 × 10^-38 to ±3.4 × 10^38.
double: The range of values that can be represented by an XSD double is approximately ±1.7 × 10^-308 to ±1.7 × 10^308.

Memory Usage:

float: An XSD float occupies 4 bytes of memory.
double: An XSD double occupies 8 bytes of memory.

Accuracy:

float: XSD floats are less accurate compared to doubles due to their lower precision. They are more prone to rounding errors and may not be suitable for computations that require high accuracy.
double: XSD doubles provide higher accuracy and are suitable for most numerical computations that require precision.

In summary, XSD doubles have higher precision, a wider range of representable values, and occupy more memory compared to XSD floats. Doubles are generally preferred when precision is important, while floats can be used when memory is a constraint, and the required range and precision are within the limits of a single-precision floating-point number.
It's important to note that both XSD floats and doubles follow the IEEE 754 standard for floating-point arithmetic, which defines their representation and behavior.

I don't see why we need double here

^ I guess I was thinking in terms of huge ranges at the cost of memory footprint
there was also some discussion about using decimal
does one of those preserve prettier/more faithful string representations?


Flexible file router API

Extracted from #2146,
Hilla should provide an API around createBrowserRouter with more flexibility and additional features:

builtin support for protectRoutes
merging layouts from client side with server routes
allow the user to remove unused route sources in case of using client/server-side only routes

The API usage could look like this in routes.tsx:
import { RouterBuilder } from '@vaadin/hilla-file-router';
import serverRoute from 'Frontend/generated/flow/server-route.js';

const routerBuilder = new RouterBuilder()
  .withReactRoutes([
    { path: '/login', element: <Login />, handle: { title: 'Login' } },
  ]);
  .withFileRoutes(fileRoutes)
  .withServerFallback(serverRoute)
  .protect();

export const routes = routerBuilder.routes;

export default routerBuilder.build();

I don't think it can be this easy:
  .with(fileRoutes)
  .with(serverRoutes)

The reason for this is that we want layouts to (by default) be "inherited" also to Flow views. If I have views/foo/$layout.tsx, then I would want a Flow view with @Route("foo/bar") to be rendered inside that layout. This in turn means that a separate /* catch-all that delegates to the server would be needed on every level in the config that has a layout. serverRoutes doesn't know which parts of fileRoutes has layouts and with doesn't know that serverRoutes should be applied in a different way compared to fileRoutes.

There's one thing that is not clear to me based on that example: what mental model should I use to understand whether '/login' will be wrapped in side views/$layout.tsx and how should I change the code if I want to make it work in the opposite way?

There's one thing that is not clear to me based on that example: what mental model should I use to understand whether '/login' will be wrapped in side views/$layout.tsx and how should I change the code if I want to make it work in the opposite way?

Good question. I'd suggest that it is not wrapped by default, unless explicitly declared so:
const routerBuilder = new RouterBuilder()
  .withReactRoutes([
    {
      element: <Layout />,
      children: [{ path: '/login', element: <Login />, handle: { title: 'Login' } }],
    }
  ]);

This way creates feels less magic to me, hopefully more flexible and easier to understand.

That's with an explicitly defined <Layout /> component. How about making manually defined routes render inside views/$layout.tsx.

I think there should be some kind low-level API that allows making arbitrary changes to the data structure that will eventually be converted into a React Router configuration. It should be possible for expert users to do those kinds of changes at any point during processing (i.e. before or after any of the default steps that are shown in the current code example). All high-level API that we introduce (e.g. withFileRoutes) would then just be shorthands on top of that generic operation. The key point is just that the generic operation also needs to be exposed and documented.
Another thought is that withServerFallback might be a weird name from a semantic point of view. The point with is just that it's a fallback that is applied in all cases when no explicitly defined route matches while still following intermediate layouts. In that way, it's a "universal" fallback but not in any way specific to "server" (except maybe some support for asynchronous resolving but that can also be seen as a universal feature).

By the way, will this new implementation of file route register an empty route always as previously? Seems like it shouldn't, so as to avoid issues like not being able to use AtRoute("") in Flow.


C:\Users\User\Stacknet\models\rjpt72fbrn75uj59unhgkvecdf0.pred(sysmtem can not find files)

Hello @kaz-Anova , have you ever met this issue (system can not find files for several models, which i guess maybe caused vide value of several columns for datasettwo_test files) when you run program? any ideas how to deal with this? thanks.

Could you put verbose:true on these algorithms?
You could show me the parameter line of this algorithm that it fails?
Generally this issue has to do when you run something really large ...

thank i'll try that way. but when i check the number of columns in datasettwo_test1 file, which is not equal to the number of my models i used, so i'm not sure which one does not work, weird.

@ahbon123
If you have added classifiers, then yes, they produced more columns than just one . Each classifier will output as many columns as you set bins in the command.

I encountered the same issue as well while adding more feature in xgboost. I saw the same issue posted here. Using the verbose option, I can see that the xgboost itself was completed, but there is no .pred file created (was it suppose to be created)?

Hi iFe1er,
Could you please copy/paste the full stack trace when verbose is set to True, so that we can have a look at what's happening?
Thanks, Olivier.

i run into the same issue here,any ideas?

I think it was caused by memory limitation but not for sure. When I upgraded RAM of my desktop from 8GB to 12GB, problems just disappeared.