bump version number to reflect next release

Current tornado version_info still reports (2,1,1).  I think it is customary to bump the dev version to the next release, so that it is identifiable as newer than the released code.
If you do want to continue with the current pattern ('2.1.1git' means code after 2.1.1), then I suppose the check for "code at or older than 2.1.1" would be:
tornado.version_info <= (2,1,1) and tornado.__version__ != "2.1.1git"

The reason this is relevant to me is we need exactly this quantity in IPython, because we ship the tiny websocket 426 bugfix (#385), so that we can still work with released tornado.
Of course, do reject if this is your style of choice, but I would like confirmation that the above code is 'the right way' to check for tornado versions before changing the checks in our code, in case it was a simple oversight.

The reason I decided to tag the version as post-2.1.1 instead of pre-2.1.2 is that when 2.1.1 is released, I don't know whether the next release is going to be 2.1.2, 2.2, or 3.0.  (and if the next release is in fact 2.1.2, it will presumably be branched directly off 2.1.1 and not include any of the commits marked pre-2.1.2, which is especially weird).  I also considered adding a field to version_info to indicate this state but decided against it because 2.1.1git actually identifies a range of commits (not even a linear range due to forks etc), and you can't really use it to tell whether the fix you want is present or not.  I added the "git" suffix for human consumption rather than machines (since pip puts the version in the path it shows up in stack traces, which is a lot of help with bug reports). Maybe it would still be useful to have that one bit of information though, so you can be optimistic if you find yourself between versions.

I think that's quite sensible.  The principal case of value, I think, is that there is some measure by which current dev evaluates as greater than the latest release, which is not possible with a single measure, currently.  Updating version_info to include (2,1,1,'git') would certainly address this.  I've changed the PR to do that, but if you just want to stick with the current model, I will change IPython to double-check on both version_info and __version__, so it doesn't confuse release 2.1.1 with post-2.1.1.
Another example: PyZMQ uses __version__='2.1dev' and version_info=(2,1,inf), thus dev always evaluates as newer than any 2.1.X release. (inf instead of 'git', because Python 3 removes str-int comparison).


file not found

Hello,
I was trying to test. But the file seqvec_goa_2017.npz (mentioned in config.txt as an example) is not found in the data directory. Could you please update or Suggest how to get/create that file.  Thanks.

Hi, you can download the pre-computed embeddings from here: ftp://rostlab.org/goPredSim (As stated in the README). I updated the config to explicitly also state it in there.


get expunged VM data for job result

Description
This PR...

Fixes: #9946

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[x] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

How did you try to break this feature and the system with this change?

@blueorangutan package

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el8 ✖ el9 ✖ debian ✖ suse15. SL-JID 11584

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el8 ✖ el9 ✔ debian ✖ suse15. SL-JID 11587

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-11787)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46612 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9949-t11787-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_01_secure_vm_migration
Error
417.73
test_vm_life_cycle.py

test_02_unsecure_vm_migration
Error
472.87
test_vm_life_cycle.py

test_03_secured_to_nonsecured_vm_migration
Error
387.36
test_vm_life_cycle.py

@blueorangutan test

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-11795)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47739 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9949-t11795-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File


Add public_bookcase type and address field

Add public_bookcase type field based on wiki page https://wiki.openstreetmap.org/wiki/Key:public_bookcase:type and the address field for public bookcases with location=indoor.

@ToastHawaii I'm okay with adding the Type field, but I'm not sure about adding all those explicit options. Most of them don't have very much usage. How about leaving them off so the suggestions will just be the most-used options from Taginfo? That way mappers can create new ones and the list can grow organically.

@ToastHawaii Great, thanks! Can you also change the field name to just "Type"? This is how other type fields are named.

Thanks for the tip. I removed te explicit options.

@ToastHawaii Thanks for your patience! This will be in the next release, probably next week.

Thanks for the good work.
Always a pleasure.


Typescript definition file

Dear guys,
After deleting arangojs and reinstalling it via npm, I figured out that the typescript definition file is not part of it. I would like to suggest that the arangojs.d.ts file is added to the the npm respository and the package.json. It is also possible to transfer the file into the lib folder (for better consistency rename it to index.d.ts in this case) and prepend the lib folder to all corresponding paths within the package.json accordingly, e.g. typings: "lib/index.d.ts".

Thanks for the fix. Leaving the file in place and adding it to the whitelist seems like the best option.

Good :) And do you plan to release a new version for npm?
When i am trying to pull the master repo via npm (arangodb/arangojs) I only get those files that are referenced within the files array. There is no way to run npm install properly then as all needed files are missing. That's why I am asking for an updated npm version, so I can pull the built files right away.


Move applications logic from controllers to adapters

A few of TriggerMesh components have their application (init) logic running as a part of the controller reconciliation cycles. We should move application-specific code to the adapters leaving the controllers as simple as possible.

I suppose we need this to be able to run the adapters in a stand-alone manner

I am moving on a re-write of koby that does not use Knative libraries to avoid loading Knative Serving even if it is not being used.
I started porting the functionality that creates CRDs but will be halting it since the ideal scenario is to re-use existing CRDs. Generating CRDs is still valuable for adding extensibility but that is not the focus for this stint.
The most challenging task is converting existing CRDs to environment variables, which might need some hints at registration or at CRD annotations.


Feature/rollover event sourcing cherry picked

This is most of the work that @thomaseizinger did in #966, but applied on top of #1014.
I tried to throw away anything that was no longer relevant.

Changes already applied on top of #1014.


Catch RuntimeException instead of IllegalStateException

Task/Issue URL: https://app.asana.com/0/414730916066338/1152880752098009
Tech Design URL:
CC:
Description:
During the slow rollout of this, we noticed some SecurityExceptions being thrown. So that's now IllegalStateException and SecurityExceptions thrown that we've observed when trying to connect to the library. Since this is non-crucial, I'd rather play this code safe and use a wider net to catch exceptions.
Steps to test this PR:

Check the change to catching a more general exception type is acceptable

Internal references:
Software Engineering Expectations
Technical Design Template

Requesting retrospective review for this as I want to push out a fix

Looks good to me! 👍


Menu bar icons for muted and unmuted mic have different width (~ 1px?) which results into jumpy icons upon toggle

Menu bar icons for muted and unmuted mic have different width (~ 1px?) which results into jumpy icons upon toggle.
That's a very tiny issue, but still.
p.s.: thanks for your program!

Thanks! The new version indeed has the fix for this issue 👍


Bundling output Location for skeleton-typescript-aspnet5

Hey there.
I'm using the  skeleton-typescript-aspnet5 with is amazing  by the way, and I've come across some bundling issues.
ENOENT, no such file or directory 'path-to-project\dist\app-build.js'. I think this should point to  'path-to-project\wwwroot\dist\app-build.js' but I cant find where to change the output dir for bundle
Please help

Ah good catch.  I thought the output would be specified in the paths file but I just checked and the bundler expects dist to be in the same directory as the src is here
I'll open an issue on the bundler.

Tracking here - https://github.com/aurelia/bundler/issues/62

@alfkonee Quick fix - adjust this path here to wwwroot/dist/app-build as well as the one right below that for the framework.  I'll PR this fix in a minute.

I just went through this and I had to change it in multiple places:
in bundle.js  changed
baseULR: 'wwwroot'
configPath: './wwwroot/config.js
in bundles.json changed both bundles paths to
"wwwroot/dist/app-build"
"wwwroot/dist/aurelia"
After that gulp bundle completed w/o error and I have an bundled file.

@ahmedshuhel Can you review this and advise?

But then the actual bundle file has 404 on a nested file path:
http://localhost:49849/dist/wwwroot/dist/aurelia-37327dd584.js

We have a new release for bundler v0.3.0. We now need to add [*.js] explicitly in the bundle config. Please install this version and let us know.

This works.
It still requires changing the bundle.js file to use wwwroot:
baseURL: 'wwwroot',
configPath: './wwwroot/config.js',
But the path to the bundled files in the generated config.js file are now correct: "aurelia-8ab7158a56"
Thanks!
The jquery issue was separate and was successfully addressed here: https://github.com/aurelia/bundler/issues/21


Remove wine dependency

Wine is needed to run the VTFCmd tool, which is only available for windows. The source code is available here and I will likely fork and port it to linux.

[x] Port to cmake
[ ] Port to linux/make platform independent code

Initial cmake and linux foundations are being laid.

VTFLib now builds successfully under linux but is likely non working and is also very sloppy.


Warning appeared after updating node version

Discussed in https://github.com/webpack/webpack/discussions/18022

Originally posted by dushajni January 29, 2024
Hi.
I'm using Module federation on CRA react projects. I have one parent and one child app as micro frontend. After updating node version from v16.x.x to v20.11.0, removing node modules and running npm install, I started getting this warning in console for the parent app (local environment):
The generated code contains 'async/await' because this module is using "external script".
However, your target environment does not appear to support 'async/await'.
As a result, the code may not run as expected or may cause runtime errors.

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

WARNING in external "remote@http://localhost:3002/remoteEntry.js"
The generated code contains 'async/await' because this module is using "external script".
However, your target environment does not appear to support 'async/await'.
As a result, the code may not run as expected or may cause runtime errors.
webpack compiled with 1 warning

I'm importing external component like this:
const ChildComponent = React.lazy(() => import('remote/ChildComponent'));
I tried several things, tried  // eslint-disable-next-line above the line I just pasted, but warning is still present.
Is there any way to solve this?

Please don't duplicate, close due https://github.com/webpack/webpack/issues/18026


Add osb-starter-pack and osb-broker-lib to gettingStarted.md

:)

LGTM

LGTM

LGTM

LGTM

LGTM


Give Message Class a ctor

Self explanatory :p
For easier usage
The Azure OpenAi package has this too

Impl. in https://github.com/awaescher/OllamaSharp/pull/16


:sparkles: Remove docs to download kantra from container image

Now that we publish binaries no need to have these docs. It's confusing and doesn't specify the multi-arch bits.

+1 on moving instructions to developer docs


Un-clickable checkbox and radio buttons when building HTML form

I have an issue with the Liebling theme when building my own HTML form
Here is the HTML form with the default ghost theme

And here is this form with Liebling theme.
Not only are radio buttons look wield, but also un-clickable.

Thanks for the heads up! This is already fixed in the latest version.


Function node not resolve "new RegExp()" method

Current Behavior
Hello, i'm usign the function node.
I want transform a string in a regex.
To make it simple  i wrote a simple code:
var asd='d(b+)d+';
var myRe = new RegExp(asd);
msg.debug=myRe;
return msg;

I have a debug in the end of this simple function but it return to me msg.debug as an empty object.
I'm wondering why it don't get me the regex i espect
Expected Behavior
I expect msg.debug is evaluated with /d(b+)d+/
Steps To Reproduce
Create a funcion node and isert the code above
Example flow
[{"id":"8cd32cd6d9e7af5e","type":"function","z":"11a5b37a8e32f9b5","name":"","func":"var asd='d(b+)d+';\nvar myRe = new RegExp(asd);\nmsg.debug=myRe;\nreturn msg;","outputs":1,"noerr":0,"initialize":"","finalize":"","libs":[],"x":1620,"y":2760,"wires":[["614062c4e48bb49c"]]},{"id":"d9e8223b4bc37d9d","type":"inject","z":"11a5b37a8e32f9b5","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":1470,"y":2760,"wires":[["8cd32cd6d9e7af5e"]]},{"id":"614062c4e48bb49c","type":"debug","z":"11a5b37a8e32f9b5","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":1780,"y":2760,"wires":[]}]

Environment

Node-RED version: 2.0.6
Node.js version: v14.17.6
npm version: 6.14.15
Platform/OS: Alpine Linux v3.11
Browser: chrome
Node-red is running in a docker container

I'm not sure what you are trying to actually achieve here.
If you add a second function node with the following after your function node with the following and wire it up to a debug node
var string = "dbbbbbdddddd";
msg.payload = string.match(msg.debug)
return msg;

The second debug node gives the correct output of the evaluated regex.
In your example there is nothing to output because the regex has not been applied to any input string. It's rendered as an empty object in the debug sidebar because it has no keys to show.
[{"id":"8cd32cd6d9e7af5e","type":"function","z":"11a5b37a8e32f9b5","name":"","func":"var asd='d(b+)d+';\nvar myRe = new RegExp(asd);\nmsg.debug=myRe;\nreturn msg;","outputs":1,"noerr":0,"initialize":"","finalize":"","libs":[],"x":1620,"y":2760,"wires":[["614062c4e48bb49c"]]},{"id":"d9e8223b4bc37d9d","type":"inject","z":"11a5b37a8e32f9b5","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":1470,"y":2760,"wires":[["8cd32cd6d9e7af5e"]]},{"id":"614062c4e48bb49c","type":"debug","z":"11a5b37a8e32f9b5","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","statusVal":"","statusType":"auto","x":1780,"y":2760,"wires":[]}]

The issue is that Debug doesn't have any special handling of RegExp type objects, so they are handled as regular objects and don't have any enumerable properties.
The question then is whether we should add RegExp as a supported type in debug.


Support $PROJECT in smoke test gen.

Support $PROJECT_ID token in the smoke test config
Add InitValue class which adds support of variable names in the init fields

@michaelbausor could you do the first pass?

Current coverage is 81.59% (diff: 91.11%)

Merging #702 into master will increase coverage by 0.04%

@@             master       #702   diff @@
==========================================
  Files           282        283     +1
  Lines         10616      10739   +123
  Methods           0          0
  Messages          0          0
  Branches       1397       1420    +23
==========================================
+ Hits           8657       8762   +105
- Misses         1578       1594    +16
- Partials        381        383     +2

Powered by Codecov. Last update 7c4c04e...baf1097

@michaelbausor PTAL

Rebased and addressed feedback. PTAL.

LGTM - let @garrettjonesgoogle take a look

LGTM


Create 1.3.3 Release

Fixes #3993; Closes #3994
/cc @jridgewell create a git tag and npm release when merged

Getting some errors.

Thats not related to this PR though should be looked into
https://travis-ci.org/jashkenas/backbone/builds
On Mon, Mar 28, 2016 at 4:55 PM, Justin Ridgewell<EMAIL_ADDRESS>wrote:

Getting some errors.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/jashkenas/backbone/pull/3998#issuecomment-202577258

Looks like the first failure was https://travis-ci.org/jashkenas/backbone/builds/90800675

Yo Justin, whats the hold up here? Travis failing here is irrelevant to the changes in this patch

Still need to merge over to gh-pages, update index.html, etc.

Should we npm deprecate 1.3.0 through 1.3.2 now?

@akre54: Can you do the gh-pages stuff?


"Authentication credentials were not provided." error

Hi,
I have set up a REST API with django-rest-auth and an Angular client application for making requests to it.
My REST API was configured for TokenAuthentication.
My client application could login successfully and then save the token into localstorage, but on every subsequent request to the API it got the following error in the response:
"Authentication credentials were not provided."
That seemed strange, since I programmed my client application to provide the Authorization header with the token in it, it should've worked. Moreover, making the same request, but sending it with Postman to the API, does work.
I found a solution on StackOverflow for my problem: including the following in my settings.py:
REST_FRAMEWORK = {
    'DEFAULT_AUTHENTICATION_CLASSES': (
        'rest_framework.authentication.TokenAuthentication',
    ),

I'd like to ask you if you can put this in the documentation, I think other developers will struggle with this too.
Also I'd like to understand why a client like Postman can make the request without problems, whereas the Angular client cannot. This seems strange to me.*
FYI, I'm running the following versions:

django: 2.0.2
djangorestframework: 3.7.7
django-rest-auth: 0.9.3
Angular: 5.2.2
Postman:  5.5.2

Doing this worked for me. Was getting the same error.

Same here! Had been going nuts because was sending 'Authorization Token' plus an space and then the token and I kept getting 'Credentials were not provided'. Added the code you suggested (plus the final '}') in settings.py and now its working:
REST_FRAMEWORK = {
    'DEFAULT_AUTHENTICATION_CLASSES': (
        'rest_framework.authentication.TokenAuthentication',
    ),
}


totally black theme

it helps the battery a lot on some types of screens (they just turn off the pixels in completely black places)
https://github.com/Darkempire78/OpenCalc already did that

@Wjxfi I understand the situation, its called amoled theme. Some apps provide this such as discord, etc. yetCalc will support this in the future and this feature has been requested before, See: #22


Feat: Style the details section on home page

Describe the feature
Style the details section on home page to match it to the original flipkart website. Styling the font as well as the background.
Add ScreenShots
Flipkart_Clone:

Original Flipkart:

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I would like to work on this issue. Please assign this issue to me @anishpujari


homepage at docker links to non existing /pycsw/csw.py

when starting the latest docker (8014385e0352)
the homepage opens fine
but any link to other location throws 404
it is because the links are prepended with /pycsw/csw.py, removing this from the link gives a correct page
eg: http://localhost:8000/pycsw/csw.py/collections -> http://localhost:8000/collections
Is it this configuration causing it? https://github.com/geopython/pycsw/blob/44bfd9532f306e3ba3a8713dd21603bf5be592c4/default-sample.cfg#L32, can the image be prepopulated with a correct path configuration?

Thanks for reporting and fixing @pvgenuchten! 💪 🚀


base.aepps.com broken on iphone < 8

I ran some tests with older iPhones. iPhone 6 + 7 had some issues while 8+ was fine.
Configurations:
iPhone 6s Plus, iOS 9.3, Safari 9.0:
Base Aepp is not loading. Error:

iPhone 7, iOS 10.2, Safari 10.0:
Base Aepp is loading but a password can not be set. The click on continue produces the following error:

i was not able to reproduce either of these issues in the iOS simulator with an iPhone 6s Plus and iOS 12.1. i would say this is not a priority for the moment. we will revisit in the future. thanks for flagging!

I have reproduced these issues on iOS 9.3 Simulator. In #511 I have fixed transpilation issues, but I can't find compatible polyfill for WebCrypto API that is used for secrets encoding.

"I can't find compatible polyfill for WebCrypto API that is used for secrets encoding." @davidyuk you are referring to the 2nd part of the issue? Should we create a separate issue for that and close this one (after somebody reviews the fix for the 1st part)?

@davidyuk will create a new issue for the remaining work and close this one.


Printing code128 barcode

Hi,
can anyone tell me how to print code128 barcode ? always I get blank paper!
Thanks in advance

Have you tried ensuring your paper is flipped the correct way? As thermal paper typically only can be printed on one side, can you print normal text or use the printers 'test' button?
On 26 Oct 2019 18:47, toumir<EMAIL_ADDRESS>wrote:
Hi,
can anyone tell me how to print code128 barcode ? always I get blank paper!
Thanks in advance
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/lukevp/ESC-POS-.NET/issues/31?email_source=notifications&email_token=ACZ5VSYP2VCYQSZU5CUA6LDQQR7CZA5CNFSM4JFOGEO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HURWKYQ, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACZ5VS5LBZIW37XFMBI3SFLQQR7CZANCNFSM4JFOGEOQ.

Hi,
thank you Sir for the quick reply,
Yes I can Print QrCode ,EAN13, ITF, CODE39, EAN8, UPC_A, UPC_E,  Only the Code128 codebare not working for me!
Can you Help?
thanks in advance

FYI : I send three codes to the printer: CODE39, CODE128,CODE39, always I get a blank line, see the attached image

@toumir This is a bug in the CODE128 support that I've just pushed a fix for.  Check out the latest release candidate on release/1.0 branch and let me know if test case #4 works for you! This should print all valid code types that are defined in the ESC/POS standard.

Are you sure your printer supports this encoding? Try to check any printer documentation you can find, what printer are you using?
Are you able to capture the response from the printer when you send it that barcode that does not print?
On 26 Oct 2019 21:14, toumir<EMAIL_ADDRESS>wrote:
FYI : I send three codes to the printer: CODE39, CODE128,CODE39, always I get a blank line, see the attached image
[20191026_210243]https://user-images.githubusercontent.com/10366325/67625382-e0d10900-f83d-11e9-8c8c-e40efd0c892e.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/lukevp/ESC-POS-.NET/issues/31?email_source=notifications&email_token=ACZ5VSYO24J4LLX7JL5JRPLQQSQLXA5CNFSM4JFOGEO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKQAJQ#issuecomment-546635814, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACZ5VS7LXYTLDFNX77FAGTLQQSQLXANCNFSM4JFOGEOQ.

This is what the new test case looks like when printed.

Hi @lukevp @ThrowingSpoon Thanks for your help and for your time,
Problem Solved :), some code not printed because my printer not support those encoding (Self-Test attached)
Thank you

That's great! I will include these fixes in the 1.0 release on Nuget as
soon as I am done preparing it!
On Sat, Oct 26, 2019, 4:05 PM toumir<EMAIL_ADDRESS>wrote:

Hi @lukevp https://github.com/lukevp @ThrowingSpoon
https://github.com/ThrowingSpoon Thanks for your help and for your time,
Problem Solved :), some code not printed because my printer not support
those encoding (Self-Test attached)
Thank you
[image: 1]
https://user-images.githubusercontent.com/10366325/67625938-14636180-f845-11e9-8c03-8898eb823129.png
[image: 2]
https://user-images.githubusercontent.com/10366325/67625939-14fbf800-f845-11e9-82e9-1440a040e92b.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lukevp/ESC-POS-.NET/issues/31?email_source=notifications&email_token=AAJRNSHEWDGF46DMENGEFTDQQSWLLA5CNFSM4JFOGEO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKQ4JI#issuecomment-546639397,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJRNSAKMC75LS536YWXWBLQQSWLLANCNFSM4JFOGEOQ
.


Review download code

Fixes #1399
Description of the changes being introduced by the pull request:
This PR builds on top of #1408 and will remain a draft until its merge.

simplify download code, remove average download speed check
wrap the download functionality in FileDownload class
simplify RequestsFetcher.fetch()
add type annotations

Please verify and check that the pull request fulfills the following
requirements:

[ ] The code follows the Code Style Guidelines
[ ] Tests have been added for the bug fix or new feature
[ ] Docs have been added for the bug fix or new feature

Looks great at first glance.
This maybe a dumb question but is there something that prevents us from putting the new FileDownload functionality directly into FetcherInterface?
Are the RequestsFetcher improvements dependent on the other changes or just included in same PR for convenience?

This maybe a dumb question but is there something that prevents us from putting the new FileDownloader functionality directly into FetcherInterface?

Only me not thinking enough about it ... :roll_eyes:

Are the RequestsFetcher improvements dependent on the other changes or just included in same PR for convenience?

No, they are not dependent, I just consider fetcher as part of the download code.
I do like the idea of simplifying further and keeping only a single download/fetcher module instead of the two. How should we do it? Build on top of this PR, a separate PR or I can rewrite these commits here and directly move download.py functions into FetcherInterface?

I do like the idea of simplifying further and keeping only a single download/fetcher module instead of the two. How should we do it? Build on top of this PR, a separate PR or I can rewrite these commits here and directly move download.py functions into FetcherInterface?

I think merging a PR that adds a new object would be weird if we intend to remove it soon in a followup PR... otherwise whatever works for you I think

Rewrote part of the commits here. Now the simplified download functions are made part of FetcherInterface and the download.py module is removed.

I don't know what is blocking GitHub actions here?

quite strange. It never actually started the action (https://github.com/theupdateframework/tuf/actions) so I can't even restart it.

I think all suggestions are added with 959ab5a.

Rebased on latest changes in develop.

Amended the last commit 0eff004 with the suggestion.


Check for empty container roles set.

JIRA Ticket: https://jira.duraspace.org/browse/FCREPO-2961
What does this Pull Request do?
Check for empty container roles set.
What's new?
If there are no container roles, skip trying to call addAll() on the Shiro principal set, since an empty set causes Shiro to throw an exception. Updated the test authentication filter to have the user "noroles" be authenticated but have no container roles, for use in integration tests.
How should this be tested?
The usual mvn clean verify should exercise the included unit and integration tests.
Additional Notes:
None.
Interested parties
@whikloj, @dbernstein, @fcrepo4/committers

@peichman-umd if you can try removing some of the configuration changes, or if you want I can try if you don't have time.

@whikloj It looks like most of them are necessary. I tried backing them out, but kept getting 500 errors in the IT because of classes not found and similar errors.


Publish recent updates to crates.io

The latest version of bytes on crates.io (v0.2.8) does not appear to include this commit which looks like it fixes the build error I'm seeing from Cargo:
/home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/bytes-0.2.8/src/alloc/mod.rs:67:18: 67:32 error: mutating transmuted &mut T from &T may cause undefined behavior,consider instead using an UnsafeCell, #[deny(mutable_transmutes)] on by default
/home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/bytes-0.2.8/src/alloc/mod.rs:67         unsafe { mem::transmute(self.bytes()) }
                                                                                ^~~~~~~~~~~~~~
/home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/bytes-0.2.8/src/str/bytes.rs:117:18: 117:32 error: mutating transmuted &mut T from &T may cause undefined behavior,consider instead using an UnsafeCell, #[deny(mutable_transmutes)] on by default
/home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/bytes-0.2.8/src/str/bytes.rs:117         unsafe { mem::transmute(self.obj()) }

Bumped. Thanks for the ping: https://crates.io/crates/bytes/0.2.9


D435 stops working and SDK hangs

Required Info

Camera Model
D400

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win10

Kernel Version (Linux Only)

Platform
PC

SDK Version
FRAMOS-librealsense2 2.29.8

Language
C++

Segment
others

Description
Hi there,
I have a production system running with a couple of FRAMOS D435e cameras (which is actually the Intel D435 with GigE interface and industrial casing). I have some software stability issues but I don't know if they are caused by the original Intel SDK, the SDK modifications made by Framos or my own implementation. I have been able to reproduce the problem with a D435 USB camera also.
The problem is twofold:

The cameras sometimes stop sending data. Then poll_for_frames and wait_for_frames does not work, even if the software can find the device.
The software freezes in a SDK function call when disconnecting or re-connecting. This happens most frequently in the pipeline.stop() method, but also in context.query_devices() and perhaps some other calls.

I suspect that the problem might be related to the fact that there are two cameras. The implementation is loosely based on the rs-multicam example, but instead of having everything in one big main and a rs2::pipeline vector, I have two instances of a class which has a rs2::pipeline member. The class has a Connect method which uses context.query_devices() to search for the correct camery (by serial number) and calls the pipeline.start() method if it is found.
I haven´t found any actual documentation on how to deal with disconnects, so I don't know if my method is correct, but it works if I test it by manually disconnecting and connecting cameras. It does not work however when the data streaming stops like described above. This is how I do it:

if pipeline.start() has been called: call pipeline.stop() (this usually hangs, if not always)
call my Connect() method:
a) prepare the config:

        rs2::config cfg;
        cfg.enable_stream(RS2_STREAM_DEPTH, Par.DepthModule.resWidth, Par.DepthModule.resHeight, RS2_FORMAT_ANY, Par.DepthModule.frameRate);
        cfg.enable_stream(RS2_STREAM_COLOR, Par.RpgModule.resWidth, Par.RpgModule.resHeight, RS2_FORMAT_RGB8, Par.RpgModule.frameRate);

b) Try to find the correct camera using the serial number (sometimes hangs in query_devices()). p_ctx is a pointer to rs2::context passed to the class constructor such that the two cameras have the same context as in the rs-multicam example.
bool RealSenseCom::GetDevice()
{
    //rs2::context ctx;

    if (Stopping) return false;
    try {
        rs2::device_list devices = p_ctx->query_devices();

        for (rs2::device d : devices) {
            string serial = d.get_info(RS2_CAMERA_INFO_SERIAL_NUMBER);
            if (Par.Device.SerialNumber.compare(serial) == 0 || (Par.Device.SerialNumber.compare("ANY") == 0)) {
                device = d;
                return true;
            }
        }
        string msg = string("Device with serial number not found\t " + Par.Device.SerialNumber);
        std::cerr << msg << endl;
        LogInfo(msg);
        numConnectionAttempts = 0;
        return false;
    }
    catch (exception & e) {
        std::cerr << "RealSense " << Par.Device.DeviceID << ": GetDevice() exception: " << e.what() << endl;
        string msg = "GetDevice() : exception caught\t " + string(e.what());
        LogInfo(msg);
        return false;
    }
}

c) Start streaming:
        cfg.enable_device(device.get_info(RS2_CAMERA_INFO_SERIAL_NUMBER));
        auto profile = pipe.start(cfg);

Note that the software usually runs for hours without problems and sometimes days, but I need it to run infinitely because it is used on a production line.
Thanks.

Hi @EinarBjorn
Could you please attach call-stack of the hang? If building from source, just hit Pause in the debugger and capture the stack-trace. If using binary SDK from our site, there is an option to install debug symbols with the SDK. With symbols loaded for realsense2.dll, you should be able to see meaningful stack-trace even when not building from source. I don't know how this would work with Framos version, but you mentioned that you can reproduce these problems with regular D435 as well, right?

Hi @dorodnic
Thank you for replying on a Sunday!  :)
The actual production system with the Framos cameras does not have a VS or other debuggers installed. Also, since it is a running production I use another software to monitor and reboot the software when it becomes unresponsive, so it can be tricky to catch the actual hang. Perhaps I can have it create a core dump on exit, but I don't know if the Framos version has the debugging option. I will investigate this.
Worth mentioning: The production system currently has only one camera because the other one is broken. The software attempts to find the missing camera every 1000ms. The system was more stable when bother cameras were operational, although not perfect.
I have very rarely seen the same behavior with the USB camera, where the connected camera stopped streaming and the software hanged in pipeline.stop() method.
However, the software frequently hangs in query_device() on my laptop when I have one USB camera connected but the software expects two cameras and periodically checks for the other one. I will trigger this and post the stack trace.

This is all I got. I guess the debug symbols are missing in the Framos version

I managed to build the Framos-librealsense SDK with debug info and dig a little deeper:

Here is what happens:

The software expects two cameras and has a pipeline for each one. Only one is connected.
The main thread tries to find the missing camera every 1000ms
Worker threads are started by a callback function (triggered by PLC) for each camera every 5-10 seconds (can be quite random):

If the camera is connected, the newest frameset from the pipeline is fetched and processed.
If the camera is not connected, the worker thread stops immediately

This can run for hours. Then this occurs:

The main thread hangs when trying to find the missing camera (see image 1).
The other pipeline still delivers data for a while (perhaps until the framequeue is empty?). Then there is no data available.
A worker thread attempts to disconnect and hangs in pipeline.stop() method (see image 2).
Now the software is unresponsive.

@dorodnic any update on this?

The implementation is loosely based on the rs-multicam example
I am curious if this can also be reproduced with SDK's rs-multicam with only 1 D435 connected to the host.
Thank you.

Is this issue still relevant with RealSense D435 using latest SDK and firmware? If so, it may be better to open another issue to focus on multiple RealSense D435 cameras with the most updated sw/fw combo. Please also file the ticket with Framos if this is specific to the sw/fw combination used in the Framos camera.
Please note this ticket will be closed in 7 days if there's no further update. Thank you

It is still relevant with the latest Framos SDK and firmware. I don't know how far behind they might be lagging Intel though.
I have also been in contact with their service and provided core dump months ago.
Neither Intel or Framos has commented on this for 2 months since I posted the detailed descriptions and screenshots so I am surprised by this response. It looks like a multi thread problem in the SDK to me because there are several threads waiting for the same mutex. It would be nice to have your opinion on that at least before you close the ticket.
I wonder if it is worth the bother to open another issue.

It seems like the latest Framos software suite, which was released about a month ago, is based on librealsense v2.33.1. Our current SDK is at pre-release v2.37.0 and rs-multicam sample has not yet been able to reproduce the issue.
It is very crucial to be able to duplicate this issue with one of RealSense family cameras using latest SDK build to allow us to further investigate. Thank you for your understanding.
Please note this ticket will be closed in 7 days if there's no further update. Thank you

@RealSenseSupport I find it odd that you auto-closed this issue without resolving it, especially since it affects an industrial product with a company you are partnered with.

@lucbettaieb, I agree. The service from their partner Framos  is even worse. I provided detailed information with screenshot, code and core dump but I don't think they even bothered looking into it.


Image after Download is Incomplete!

Hi Guys  ,
i used Last version but in iOS and Safari my image after Download is incomplete sometimes,
this is complete after download :

But this is sometimes is iOS Safari download:

I have the same problem. Can you solve it?

try this
    window.pageYOffset = 0;
    document.documentElement.scrollTop =0;
    document.body.scrollTop=0;

try this
    window.pageYOffset = 0;
    document.documentElement.scrollTop =0;
    document.body.scrollTop=0;


storybook demo upgrade ng

Changes proposed in this Pull Request:

Update storybook demo to use angular 11
Remove old karma reporter
Add karma-coverage
Upgrade pxblue packages

Screenshots:

storybook demo having issues-
ERROR in<EMAIL_ADDRESS>Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
ValidationError: Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema


Indirect usage of BinaryFormatter via WinForms ImageList causes compiler warnings

Type of issue
Missing information
Description
After updating my WinForms application to .NET 8, I'm now getting MSB3825 compiler warnings saying that BinaryFormatter is deprecated and will be removed in a future version.
This article recommends that I "migrate away from BinaryFormatter due to its security and reliability flaws."
But this isn't helpful. I never opted into using BinaryFormatter. I added other WinForm components, and apparently they are using this type. In my case, it appears that an ImageList control is using it.
So does this mean I need to stop using ImageList? How can I migrate away from something that is being used behind the scenes by WinForms? None of this information helps me to resolve the issue.
Page URL
https://learn.microsoft.com/en-us/dotnet/core/compatibility/serialization/8.0/binaryformatter-disabled
Content source URL
https://github.com/dotnet/docs/blob/main/docs/core/compatibility/serialization/8.0/binaryformatter-disabled.md
Document Version Independent Id
5048d220-6e5c-3130-b1db-ead1efbf7c36
Article author
@gewarren
Metadata

ID: 0eba416b-f96c-6684-b54e-1c765f0c6efe
Service: dotnet-fundamentals

@merriemcgaw Could you advise on this issue?

@JeremyKuhne @lonitra I'll let you two advise. @gewarren - I think we'll want some official guidance in the docs specific to WinForms.

@JeremyKuhne -- I've renamed this issue to describe the issue better. I'm tempted to transfer this issue over to dotnet/winforms so we can track it against the 9.0.0 milestone there. What do you think?

@jeffhandley  - how that BinaryFormatter is not used to deserialize resources at the runtime, we don't need this warning, who do we work with on it?

Duplicate of - https://github.com/dotnet/msbuild/issues/11185

I was able to find an error in my markup.
It was the following block. Note the two double quotes at the end of the form-check form-switch
.

@ViewData["Title"] (@truckCount)

            <input class="form-check-input" type="checkbox" id="auto-refresh">
            Auto Refresh

Okay, would be nice if the editor could flag this somehow, but it's due to my error. Apologies, and thanks for looking.


Adding fedora docs

Adding documentation for building HPX on a Fedora system. Based off of Patrick's blog post linked in the document.

LGTM

@aserio Why have you closed this?

@hkaiser apparently I had created this off of release. When you delete the branch GitHub automatically closes the pull request.


Fix error message

that occurs with certain parametrized queries.
uint8_t is interpreted as char by the formatter routines. Are there other enums that are mapped to an uint8_t internally?

Thanks for the PR. I think as a fix, rather than casting to an integer, it would be better to change the %d to %s. The exception messages don't use printf but rather use variadic templates (see exception.hpp and exception_format_value.hpp). The problem here is that there is a template specialization on PhysicalType that creates a string value from a PhysicalType:
template <> ExceptionFormatValue ExceptionFormatValue::CreateFormatValue(PhysicalType value) {
	return ExceptionFormatValue(TypeIdToString(value));
}

I assume the error here comes from using %d with a string value, and hence %s should be used instead.

Thanks. I can't comment on that, I suspect the easiest way to find out is to write a small test that triggers the exception. I'm not familiar enough with the code base to do this in a reasonable amount of time.

Thanks. I can't comment on that, I suspect the easiest way to find out is to write a small test that triggers the exception. I'm not familiar enough with the code base to do this in a reasonable amount of time.

I meant in this PR I suggest changing %d to %s instead of casting type to an integer, as follows:
 throw ConversionException("Invalid PhysicalType %s", type);

Apologies if that was not clear.

I meant in this PR I suggest changing %d to %s instead of casting type to an integer, as follows:
 throw ConversionException("Invalid PhysicalType %s", type);

Apologies if that was not clear.

How can we test that the message is really correct?

How can we test that the message is really correct?

We can't. This code is never meant to be executed. You can verify it by putting the exception in the main body of the function to verify that it works as intended but you cannot (or rather; should not be able to) create a SQL test that triggers it.

We can't. This code is never meant to be executed. You can verify it by putting the exception in the main body of the function to verify that it works as intended but you cannot (or rather; should not be able to) create a SQL test that triggers it.

Done.

Done.

Thanks!

Thanks!


pubsub does more pubs

finally got around to redoing #189 with the stuff we do for plugins now and hopefully not all the file edit issues.

Code looks good, but there needs to be a way for the user to quickly know if its a yes or no. It takes a second of scanning through this to see if its on sale.
The old plugin just bolded not


feat(utabs): add badge component to UTabs

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
This PR introduces a badge component to the UTabs feature. The badge is intended to provide users with visual indicators (e.g., notifications or counts) on tab elements.
Key changes include:

Implementation of a badge element within UTabs.
Updated styling and logic to support badge integration without impacting existing tab functionality.

📝 Checklist

[ ] I have linked an issue or discussion.
[x] I have updated the documentation accordingly.

@maxsteinwand,
Thank you for your feedback! I see that it's possible to customize the label using the default slot, as shown in your example. However, my proposed feature aims to enhance the user experience and streamline the implementation process.


Fix failing build step, part 2: mermaid compilation

When merging to main, the compile-mermaid script fails: https://github.com/usds/justice40-tool/actions/runs/936516201

I see this in the github build console:
Warning: Unexpected input(s) 'GITHUB_TOKEN', valid inputs are ['ssh-key', 'token',
'branch', 'folder', 'target-folder', 'commit-message', 'clean', 'clean-exclude', 'dry-run',
'git-config-name', 'git-config-email', 'repository-name', 'workspace', 'single-commit', 'silent']
Run<EMAIL_ADDRESS>
I think it's related to the github_token: ${{ secrets.GITHUB_TOKEN }}
here in compile_mermaid.yml
But I'd like @NatHillardUSDS to confirm because GITHUB_TOKEN is used in one other place (Deploy to Github Pages)

Maybe we move this away from Github actions?

This seems to be working now: https://github.com/usds/justice40-tool/actions/workflows/compile_mermaid.yml


On Release dashboard a multi-run test (e.g. rolling upgrade) is marked as not planned, even though it was scheduled and started, but all runs are failed

A multi-run test (e.g. rolling-upgrade) is marked as not-run on Release dashboard, if all runs of the test are failed.
When investigating test results of a release it may seem that such a test was not planned. The assignee would notice that the test was actually executed (and failed) only when checking My Jobs page.
Example of such a not-run test on a release dashboard:

And actual rub for the release in question:

The reason here is that the submitted test has the version set as 2024.1.12, but your dash version is set to 2024.1.13. If this behaviour should be handled as part of a set of tests I can set it aside for rolling upgrade improvements/fixes we have lined up in the future.

This screenshot is for one of 2 failed runs in this multi-run #32 in Argus. The run is for 2024.1.13 release but 2024.1.12 version is the base version before upgrade here. It is just not clear why it is marked as Scylla version on Details tab, as on a successful run it would be marked as Base scylla version.
For instance the second failed run in #32 is marked with Scylla version: 5.4.9-20240703.fdcbbb85adcd on Details tab.

This is the overview of the main pipeline of that run:

Pipeline tasks for versions 2022.2 and 2023.1 failed, so that the Argus runs were not even created for them. But Argus runs for 5.4 and 2024.1 were successfully created

I see, in this case it is a planned feature to support base versions without a succesful upgrade, currently there's no way to tell which version is the base and upgraded one without upgraded one being submitted

in this case it is a planned feature to support base versions without a succesful upgrade,

@k0machi
Do we have maybe a ticket raised already for this?
Or maybe we can label current one as an enhancement


adding dependencies

What: The website is broken, perhaps due to the dependencies not present in package.json
Why: Website is broken
How: Added dependencies into package.json

Not sure if this PR is necessary? When I pulled from master, the dependencies weren't there but when I compare the diff, it looks like they are?

I guess they are there.


More cadence-proxy tweaks

New message properties:

[x] WorkflowExecuteChildRequest also adds ScheduleToStartTimeout.

[x] ActivityExecuteRequest also adds ScheduleToStartTimeout.

[x] The Test_EndToEnd.LocalActivity_WithResult test is failing because you're checking the ScheduleToCloseTimeoutSeconds options property which is not necessary (or passed) for local activities.  Local activities are passed only ScheduleToCloseTimeout.  Local activities also don't support heartbeats so we're not passing HeartbeatTimeout either.

DONE


upgrade junit4 to junit5

Hi @xXNurioXx ,
just create a PR for upgrading junit4 to junit5.
as it's my first PR on github, i may falsely changed the code structure,
like moved annotation and abstract things to a new package.
sorry for the inconvenience, it's not my intension to change it without your permission.

Hi @qigao, I will review your PR and apply some changes if needed this afternoon.
Thanks for your contribution!


Bump isn't working on Gnosis.

Describe the bug
Bump function isn't working properly for Gnosis chain.
Bug: Requested data is not available.
Additional context
TX ID: https://connextscan.io/tx/0x857bacaff6c8be712cf3f5f2eac52c8470d539aeef0d74660bd6379c39a44d44

Describe the bug
Bump function isn't working properly for Gnosis chain. (wrong relayer fees)
Bug: Reverted 0x5361666545524332303a206c6f772d6c6576656c2063616c6c206661696c6564 - cannot estimate gas; txn may fail or may require manual gas limit
Relayer fee was underrated and now he cant bump it
Additional context
TX ID: https://connextscan.io/tx/0xf60031bd699a6e133e71fd6def38bd11a138f080548c4ad3cd4a3f8dae670631
(ticket 1186)
User sent more txns after that one and they were successful.
https://connextscan.io/address/0xbd73cf5baf12f120ee3f6c4ad82df9a12649e578

Can the user bump USDT?

Can the user bump USDT instead of xDAI?
The first user (slippage) looks to have completed

Sorry forgot to attach the snapshots
He is trying to bump USDT

Worth mentioning one more issuen that me and user sdraste noticed: when choosing xDAI for increasing the fee, it's showing 0, but for USDT it's ~0.8
Txid:
https://connextscan.io/tx/0xf60031bd699a6e133e71fd6def38bd11a138f080548c4ad3cd4a3f8dae670631

yea

Can the user bump USDT instead of xDAI?
The first user (slippage) looks to have completed

Sorry forgot to attach the snapshots
He is trying to bump USDT

replicating this with the transacting asset.... mm

fee bumps were refactored on the backend for all transacting assets here: https://github.com/connext/monorepo/actions/runs/4931773952
this looks like a frontend problem, let me see if I can repro

@pjenviri do you have more context on this one? this looks to be more frontend

closing, stale.
can reopen if issue persists


[Android][Hermes][Sourcemaps][Release] Fix for sourcemap-output external configuration breaks bundling

Summary
This is a fix for the issue  Setting --sourcemap-output in extraPackagerArgs in project.ext.react breaks bundling #32239
This bug only affects Hermes with Android on release builds.
Hermes sourcemaps are generated as part of a multistage process for release builds combining the intermediate hbc compiler and packager maps  to produce the final bundle map using the compose-sourcemap scripts.
Overriding the sourcemap-output parameter, breaks the intermediate destination of Hermes packager sourcemaps.
This fix corrects the intermediate/final destination for the final sourcemap-output as specified by the user without changing the intermediate destinations permitting the maps to build without a hitch.
Note that
1 the sourcemap-output build destination must pre-exist or be  re-generated as part of the usual bundle process.
2 sourcemaps are only generated for release build variants and not other variants.
Changelog
[ANDROID][FIXED][HERMES][RELEASE][SOURCEMAPS] - Setting --sourcemap-output in extraPackagerArgs in project.ext.react breaks bundling
Test Plan
Create a new project with npx react-native init
Enable Hermes in app/build.gradle
Modify the following configuration section to app/build.gradle
def bundleAssetName  = "test_hermes_with_extraargs.index.android.bundle"
project.ext.react = [
    enableHermes: true,  // clean and rebuild if changing
    // the name of the generated asset file containing your JS bundle
    bundleAssetName: "${bundleAssetName}",
    // supply additional arguments to the packager otherwise use defaults
    extraPackagerArgs: ["--sourcemap-output", "${buildDir}/${bundleAssetName}.map"]
]

run cd android && ./gradlew assemblerelease
Retry with other combinations of enableHermes: false/true and with/without extraPackagerArgs sourcemap-output overrides and check if the source map corresponding to the bundle are generated as expected in the user specified destination override OR in the default build locations when override not specified.

Hey @joe-sam,
Thanks for the PR.
I'm trying to understand why this is even needed. I would rather allow customizing the sourcemap location rather than doing all the CLI parameter handling you're doing.

Sorry for the late response @cortinico my internet went down for more than a few days due to inclement weather.
I would recommend my way for the reasons below.

The current approach seems to be trying to get Hermes to be the default engine.
As such millions of devs like me will be migrating to Hermes with the enableHermes flag set (default is false) to try before opting in. My guess is that 0.68.2 will be one of the last  couple of such releases with the flag.

To ensure a smooth and seamless transition I would not introduce a new config option  for a minor release such as 0.68.2, as has been done by the patch as millions of devs would miss such a breaking change, until it shows up too late at a maintenance/debug phase on an integration like Sentry or Bugsnag etc. I caught mine more than a month after release after migrating to Hermes and was confounded by the enigmatic stack trace till I stumbled on this issue.
This may be okay  to do for a major release such as 0.69  although I would expect exactly the same results, since most devs would not read the docs about config vars and miss that change till too late.

I'm not an expert in gradle (fortunately it seems to be vaguely JVM based) and there may be a much cleaner way to swap out those defs,  without that horrendous if-else block, however I have tried the complete test plan matrix against it and nudged it until I satisfied myself that it works.
But it seems really fortunate to me that the CLI parameters were designed to be put in an array in order just to enjoy those benefits such as to allow CLI parameter handling and any de-duplication checks.
Therefore I have also extended this logic by coalescing all the arguments together into a single argument for any such future eventuality.

I caught mine more than a month after release after migrating to Hermes and was confounded by the enigmatic stack trace till I stumbled on this issue.

Thanks for the detailed response @joe-sam, but it still doesn't answer my original point: why is this change even needed in the first place? You should be fine by overriding the sourcemap location instead, rather than manipulating the CLI parameters

Thanks for the detailed response @joe-sam, but it still doesn't answer my original point: why is this change even needed in the first place? You should be fine by overriding the sourcemap location instead, rather than manipulating the CLI parameters

Yes that should work perfectly fine as well ,I misunderstood your original question, and is certainly cleaner  implementation.  I certainly have no issues if you wish to implement it that way. I was trying to avoid adding in new configurations and use one CLI override for extraPackagerArgs which I assumed was standard behaviour. If I have understood you right then instead of the CLI override, you will now require two extra config objects specifying the intermediate and final paths defined in project.ext.react array for example [config.OutputSourceMapFile, config.PackagerSourceMapFile] defined in project.ext.react one for the which can override the defaults.
and then in app/build.gradle
 project.ext.react = [
    enableHermes: true,  // clean and rebuild if changing,
    OutputSourceMapFile: "${buildDir}/${bundleAssetName}.map"
    PackagerSourceMapFile: "${buildDir}/${bundleAssetName}.packager.map"
]

and in react.gradle
       def jsPackagerSourceMapFile = config.PackagerSourceMapFile?config.PackagerSourceMapFile:file("$jsIntermediateSourceMapsDir/${bundleAssetName}.packager.map")
       def jsOutputSourceMapFile = config.OutputSourceMapFile?config.OutputSourceMapFile:file("$jsSourceMapsDir/${bundleAssetName}.map")
If this is more on the lines of what you meant I can close this and submit a new PR to resolve the issue.

You should be fine with:
project.ext.react = [
    enableHermes: true,
    bundleAssetName: "mycustomname.bundle"
]

This allows you to customize the bundle name and the sourcemap filename.
It should be sufficient to offer some degree of customization.
Customizing the sourcemap location is not possible at the moment, and I still haven't fully understood what's the use case for it.

Alright since there is no use case for custom sourcemap location I will close this pull request.


Feature Request: Label Spawn Positions

First off, I love this tool!
Here is my enhancement request:
When searching for particular A/B hunts, it is helpful to know which spawn points are associated with which hunt. I would think having a way to label the spawn points with which hunt they are associated with would be a major boon to this already fantastic tool. Maybe color code the dots? Maybe actual text labels? I'll leave that design up to you.
Thank you very much!

I don't plan on adding this as lots of hunts spawn the same positions and IMO it would make things unnecessarily visually busy.
If you check the spawn data here, http://cablemonkey.us/huntmap2/
You'll see each individual hunt (A, B, and S) have a lot of cross-over spawn spots.


Improve error on broken config

Perhaps there is a better way to handle it.
closes #83

Another (probably even better) would be returning a descriptive / "good" error and or providing a fn that automatically falls back, so this can be impl in impl Config rather than main.

Honestly didn't get this idea, but I hope now it's better?
[zhiburt@zhiburt cargo-spellcheck]$ cargo spellcheck --cfg README.md
Error: Syntax of a given config file(README.md) is broken

Caused by:
    unexpected character found: `!` at line 3 column 2

Another (probably even better) would be returning a descriptive / "good" error and or providing a fn that automatically falls back, so this can be impl in impl Config rather than main.

Honestly didn't get this idea disappointed_relieved, but I hope now it's better?
[zhiburt@zhiburt cargo-spellcheck]$ cargo spellcheck --cfg README.md
Error: Syntax of a given config file(README.md) is broken

Caused by:
    unexpected character found: `!` at line 3 column 2

I completely missed your response, sorry for that.
Can you paste all 3 variants?

config with "good" toml
non existant toml file
config file exists, but contains invalid toml

All 3 of them should work flawlessly and yield an error description, which one case use to triage and address the issue.

non existant toml file

[zhiburt@zhiburt cargo-spellcheck]$ cargo spellcheck --cfg README1.md
Error: No such file or directory (os error 2)

Caused by:
    Failed to open file README1.md

good one

[zhiburt@zhiburt cargo-spellcheck]$ cargo spellcheck --cfg ~/.config/cargo_spellcheck/config.toml
error: spellcheck(Hunspell)
  --> /home/zhiburt/proj/cargo-spellcheck/src/checker/mod.rs:5
   |
 5 |  algorithms again and again, i.e. tokenization.
   |                                   ^^^^^^^^^^^^
   | - autoionization or ionization
   |
   |   Possible spelling mistake found.
   |

....

Very nice!


Updated serde to v0.9

WIP. I needed this because I'm testing 0.9 for my own crate that has an indirect dependency on serde_urlencoded, so I figured I'd share it.
Done:

Compiles :D
Tests pass.

TODO:

Thanks for your contribution! I didn't want to merge it as is because I didn't want to reuse Self for all the top-level associated types, and I ended up changing some stuff and some abstractions in #9. I'm not merging it immediately so you can take a look at it if you want.

That's totally fine!


Address whitespace issue from review. Throw IOException in unit tests.

.

Merging to fix the build.


Error while accessing 'X-MS-TOKEN-AAD-ID-TOKEN'

followed every instruction above for auth token input binding but still having an error in the log saying Error while accessing 'X-MS-TOKEN-AAD-ID-TOKEN'. even after being logged in manually with https://<function_name>.azurewebsites.net/.auth/login/aad/callback, I can't seem to trigger any functions related to graph api. Any suggestions?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 81cb62b5-7d3d-82ac-cbf9-cf8ec72da034
Version Independent ID: 69f0b334-acba-8dde-51d5-eb6bc9f85d5e
Content: Microsoft Graph bindings for Azure Functions
Content Source: articles/azure-functions/functions-bindings-microsoft-graph.md
Service: functions
GitHub Login: @mattchenderson
Microsoft Alias: mahender

@fiyazbinhasan Thanks for the question! We are investigating and will update you shortly.

@mattchenderson can you take a look into this one?

@mattchenderson I no longer having this issue after selecting Login with Azure Active Directory from the dropdown. But I'm facing this new issue now when I try to trigger the ProfilePhotoAPI template - Input id_token cannot be used as 'urn:ietf:params:oauth:grant-type:jwt-bearer' grant.

This was a change in AAD behavior that we missed, but will go into a future release. In the meantime, the workaround is to set the field oauth2AllowImplicitFlow in the Application Manifest to true.

@ConnorMcMahon works like a charm! However, the default ProfilePhotoAPI triggers successfully but showing this error message on the browser,
{
  "error": {
    "code": "UnknownError",
    "message": "",
    "innerError": {
      "request-id": "30539517-e62d-466b-9881-0833e6729849",
      "date": "2018-05-07T18:36:41"
    }
  }
}

I checked the xhr in the devtools; it says unauthorized 401!

Hmmm... Did you sign into you application at https://. azurewebsites.net/.auth/login/aad first?

@ConnorMcMahon Maybe it's some sort of authentication/permission issue with the photo API, https://graph.microsoft.com/v1.0/me/photo/$value. The me API works great https://graph.microsoft.com/v1.0/me/ on the other hand. Closing this issue as of now.

@ConnorMcMahon Sorry to comment on an already closed issue, recently I am still facing the error AADSTS240002: Input id_token cannot be used as 'urn:ietf:params:oauth:grant-type:jwt-bearer' grant when keeping the   oauth2AllowImplicitFlow with default value false.
About the workaround is to set the field oauth2AllowImplicitFlow in the Application Manifest to true from your comment, is that still a must or it can be some other issue in my configuration? Thanks.

setting up oauth2AllowImplicitFlow in the Application Manifest to true WORKED !! Thanks

Hi, have the same issue.

oauth2AllowImplicitFlow: true
spring-boot-starter-parent: 2.0.3.RELEASE
azure-active-directory-spring-boot-starter: 2.0.4

2018-11-21 13:58:22.342 ERROR 24068 --- [pool-1-thread-1] c.m.aad.adal4j.AuthenticationContext     : [Correlation ID: ee0f00f6-c593-433e-9c49-5c95aadfeed5] Request to acquire token failed.

com.microsoft.aad.adal4j.AuthenticationException: {"error_description":"AADSTS240002: Input id_token cannot be used as 'urn:ietf:params:oauth:grant-type:jwt-bearer' grant.\r\nTrace ID: b08981a6-7a83-4ae9-9238-2a0fb34a3700\r\nCorrelation ID: ee0f00f6-c593-433e-9c49-5c95aadfeed5\r\nTimestamp: 2018-11-21 12:58:22Z","error":"invalid_request"}
	at com.microsoft.aad.adal4j.AdalTokenRequest.executeOAuthRequestAndProcessResponse(AdalTokenRequest.java:120) ~[adal4j-1.3.0.jar:1.3.0]
	at com.microsoft.aad.adal4j.AuthenticationContext.acquireTokenCommon(AuthenticationContext.java:880) ~[adal4j-1.3.0.jar:1.3.0]
	at com.microsoft.aad.adal4j.AuthenticationContext.access$100(AuthenticationContext.java:68) ~[adal4j-1.3.0.jar:1.3.0]
	at com.microsoft.aad.adal4j.AuthenticationContext$1.call(AuthenticationContext.java:176) [adal4j-1.3.0.jar:1.3.0]
	at com.microsoft.aad.adal4j.AuthenticationContext$1.call(AuthenticationContext.java:165) [adal4j-1.3.0.jar:1.3.0]
	at java.util.concurrent.FutureTask.run(FutureTask.java:266) [na:1.8.0_181]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_181]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_181]
	at java.lang.Thread.run(Thread.java:748) [na:1.8.0_181]

Removing wildcards in Reply URLs fixed the issue for me

This was a change in AAD behavior that we missed, but will go into a future release. In the meantime, the workaround is to set the field oauth2AllowImplicitFlow in the Application Manifest to true.

@ConnorMcMahon Is there an issue we can follow or other way of being notified when this workaround won't be needed? I may be misunderstanding something, but changing an app's authorization flow to implicit when it could/should be using auth codes seems to have security implications and I don't think I'm comfortable with using it long-term if I don't have to. There seems to be a lot of advice against using implicit grants at all, let alone when the use case doesn't demand it for technical reasons.

hi， Implicit grant is not be allowed in my security policy. Is there any other workaround or plan to fix this issue?

Take a look in Authentication code with PXCE. It can be useful if you are dealing with authentication for SPAs.


Error in building RVC app example through gn-build.sh

Feature area
Building
Platform & package versions
EndeavourOS (linux 6.10.2.arch1-1)
gcc 14.1.1+r309+gbb34b7eda1f-1
ninja 1.12.1-1
Version used (commit number)
c7f5f65
Error description
Trying to build the whole source code from scratch via gn-build.sh, I get the following output from ninja:
FAILED: standalone/obj/examples/rvc-app/rvc-common/src/chip-rvc-app.rvc-service-area-delegate.cpp.o
g++ -MMD -MF standalone/obj/examples/rvc-app/rvc-common/src/chip-rvc-app.rvc-service-area-delegate.cpp.o.d -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wundef -Wno-deprecated-declarations -Wno-missing-field-initializers -Wno-unknown-warning-option -Wno-unused-parameter -Wno-cast-function-type -Wno-psabi -Wno-maybe-uninitialized -fdiagnostics-color -fno-strict-aliasing -fmacro-prefix-map=../../= -I/usr/include/gio-unix-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/sysprof-6 -std=gnu++17 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -DCHIP_MINMDNS_USE_EPHEMERAL_UNICAST_PORT=1 -DCHIP_MINMDNS_HIGH_VERBOSITY=0 -DCHIP_MINMDNS_DEFAULT_POLICY=1 -I../../examples/rvc-app/linux/include -I../../examples/rvc-app/rvc-common/include -I../../examples/platform/linux -I../../src/include -I../../src -Istandalone/gen/include -I../../config/standalone -I../../zzz_generated/app-common -I../../third_party/nlassert/repo/include -I../../third_party/nlio/repo/include -I../../third_party/nlfaultinjection/include -I../../third_party/inipp/repo/inipp -Istandalone/gen/examples/rvc-app/rvc-common -Istandalone/gen/examples/rvc-app/rvc-common/zapgen -I../../third_party/jsoncpp/repo/include -c ../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp -o standalone/obj/examples/rvc-app/rvc-common/src/chip-rvc-app.rvc-service-area-delegate.cpp.o
In file included from ../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:19:
../../examples/rvc-app/rvc-common/include/rvc-service-area-delegate.h:38:10: error: ‘vector’ in namespace ‘std’ does not name a template type
   38 |     std::vector<ServiceArea::LocationStructureWrapper> mSupportedLocations;
      |          ^~~~~~
../../examples/rvc-app/rvc-common/include/rvc-service-area-delegate.h:24:1: note: ‘std::vector’ is defined in header ‘<vector>’; this is probably fixable by adding ‘#include <vector>’
   23 | #include <cstring>
  +++ |+#include <vector>
   24 | #include <utility>
../../examples/rvc-app/rvc-common/include/rvc-service-area-delegate.h:39:10: error: ‘vector’ in namespace ‘std’ does not name a template type
   39 |     std::vector<ServiceArea::MapStructureWrapper> mSupportedMaps;
      |          ^~~~~~
../../examples/rvc-app/rvc-common/include/rvc-service-area-delegate.h:39:5: note: ‘std::vector’ is defined in header ‘<vector>’; this is probably fixable by adding ‘#include <vector>’
   39 |     std::vector<ServiceArea::MapStructureWrapper> mSupportedMaps;
      |     ^~~
../../examples/rvc-app/rvc-common/include/rvc-service-area-delegate.h:40:10: error: ‘vector’ in namespace ‘std’ does not name a template type
   40 |     std::vector<uint32_t> mSelectedLocations;
      |          ^~~~~~
../../examples/rvc-app/rvc-common/include/rvc-service-area-delegate.h:40:5: note: ‘std::vector’ is defined in header ‘<vector>’; this is probably fixable by adding ‘#include <vector>’
   40 |     std::vector<uint32_t> mSelectedLocations;
      |     ^~~
../../examples/rvc-app/rvc-common/include/rvc-service-area-delegate.h:41:10: error: ‘vector’ in namespace ‘std’ does not name a template type
   41 |     std::vector<ServiceArea::Structs::ProgressStruct::Type> mProgressList;
      |          ^~~~~~
../../examples/rvc-app/rvc-common/include/rvc-service-area-delegate.h:41:5: note: ‘std::vector’ is defined in header ‘<vector>’; this is probably fixable by adding ‘#include <vector>’
   41 |     std::vector<ServiceArea::Structs::ProgressStruct::Type> mProgressList;
      |     ^~~
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual uint32_t chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetNumberOfSupportedLocations()’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:108:34: error: ‘mSupportedLocations’ was not declared in this scope; did you mean ‘AddSupportedLocation’?
  108 |     return static_cast<uint32_t>(mSupportedLocations.size());
      |                                  ^~~~~~~~~~~~~~~~~~~
      |                                  AddSupportedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:108:34: note: maximum limit of 1000 namespaces searched for ‘mSupportedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetSupportedLocationByIndex(uint32_t, chip::app::Clusters::ServiceArea::LocationStructureWrapper&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:113:21: error: ‘mSupportedLocations’ was not declared in this scope; did you mean ‘aSupportedLocation’?
  113 |     if (listIndex < mSupportedLocations.size())
      |                     ^~~~~~~~~~~~~~~~~~~
      |                     aSupportedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:113:21: note: maximum limit of 1000 namespaces searched for ‘mSupportedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetSupportedLocationById(uint32_t, uint32_t&, chip::app::Clusters::ServiceArea::LocationStructureWrapper&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:130:24: error: ‘mSupportedLocations’ was not declared in this scope; did you mean ‘aSupportedLocation’?
  130 |     while (listIndex < mSupportedLocations.size())
      |                        ^~~~~~~~~~~~~~~~~~~
      |                        aSupportedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:130:24: note: maximum limit of 1000 namespaces searched for ‘mSupportedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::AddSupportedLocation(const chip::app::Clusters::ServiceArea::LocationStructureWrapper&, uint32_t&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:150:9: error: ‘mSupportedLocations’ was not declared in this scope; did you mean ‘AddSupportedLocation’?
  150 |     if (mSupportedLocations.size() < kMaxNumSupportedLocations)
      |         ^~~~~~~~~~~~~~~~~~~
      |         AddSupportedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:150:9: note: maximum limit of 1000 namespaces searched for ‘mSupportedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:154:43: error: ‘mSupportedMaps’ was not declared in this scope; did you mean ‘AddSupportedMap’?
  154 |         listIndex = static_cast<uint32_t>(mSupportedMaps.size()) - 1; // new element is last in list
      |                                           ^~~~~~~~~~~~~~
      |                                           AddSupportedMap
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:154:43: note: maximum limit of 1000 namespaces searched for ‘mSupportedMaps’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::ModifySupportedLocation(uint32_t, const chip::app::Clusters::ServiceArea::LocationStructureWrapper&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:170:40: error: ‘mSupportedLocations’ was not declared in this scope; did you mean ‘AddSupportedLocation’?
  170 |     if (modifiedLocation.locationID != mSupportedLocations[listIndex].locationID)
      |                                        ^~~~~~~~~~~~~~~~~~~
      |                                        AddSupportedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:170:40: note: maximum limit of 1000 namespaces searched for ‘mSupportedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:178:5: error: ‘mSupportedLocations’ was not declared in this scope; did you mean ‘AddSupportedLocation’?
  178 |     mSupportedLocations[listIndex] = modifiedLocation;
      |     ^~~~~~~~~~~~~~~~~~~
      |     AddSupportedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:178:5: note: maximum limit of 1000 namespaces searched for ‘mSupportedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::ClearSupportedLocations()’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:184:10: error: ‘mSupportedLocations’ was not declared in this scope; did you mean ‘AddSupportedLocation’?
  184 |     if (!mSupportedLocations.empty())
      |          ^~~~~~~~~~~~~~~~~~~
      |          AddSupportedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:184:10: note: maximum limit of 1000 namespaces searched for ‘mSupportedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual uint32_t chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetNumberOfSupportedMaps()’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:204:34: error: ‘mSupportedMaps’ was not declared in this scope; did you mean ‘AddSupportedMap’?
  204 |     return static_cast<uint32_t>(mSupportedMaps.size());
      |                                  ^~~~~~~~~~~~~~
      |                                  AddSupportedMap
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:204:34: note: maximum limit of 1000 namespaces searched for ‘mSupportedMaps’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetSupportedMapByIndex(uint32_t, chip::app::Clusters::ServiceArea::MapStructureWrapper&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:209:21: error: ‘mSupportedMaps’ was not declared in this scope; did you mean ‘aSupportedMap’?
  209 |     if (listIndex < mSupportedMaps.size())
      |                     ^~~~~~~~~~~~~~
      |                     aSupportedMap
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:209:21: note: maximum limit of 1000 namespaces searched for ‘mSupportedMaps’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetSupportedMapById(uint8_t, uint32_t&, chip::app::Clusters::ServiceArea::MapStructureWrapper&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:225:24: error: ‘mSupportedMaps’ was not declared in this scope; did you mean ‘aSupportedMap’?
  225 |     while (listIndex < mSupportedMaps.size())
      |                        ^~~~~~~~~~~~~~
      |                        aSupportedMap
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:225:24: note: maximum limit of 1000 namespaces searched for ‘mSupportedMaps’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::AddSupportedMap(const chip::app::Clusters::ServiceArea::MapStructureWrapper&, uint32_t&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:245:9: error: ‘mSupportedMaps’ was not declared in this scope; did you mean ‘AddSupportedMap’?
  245 |     if (mSupportedMaps.size() < kMaxNumSupportedMaps)
      |         ^~~~~~~~~~~~~~
      |         AddSupportedMap
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:245:9: note: maximum limit of 1000 namespaces searched for ‘mSupportedMaps’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::ModifySupportedMap(uint32_t, const chip::app::Clusters::ServiceArea::MapStructureWrapper&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:264:30: error: ‘mSupportedMaps’ was not declared in this scope; did you mean ‘AddSupportedMap’?
  264 |     if (modifiedMap.mapID != mSupportedMaps[listIndex].mapID)
      |                              ^~~~~~~~~~~~~~
      |                              AddSupportedMap
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:264:30: note: maximum limit of 1000 namespaces searched for ‘mSupportedMaps’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:272:5: error: ‘mSupportedMaps’ was not declared in this scope; did you mean ‘AddSupportedMap’?
  272 |     mSupportedMaps[listIndex] = modifiedMap;
      |     ^~~~~~~~~~~~~~
      |     AddSupportedMap
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:272:5: note: maximum limit of 1000 namespaces searched for ‘mSupportedMaps’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::ClearSupportedMaps()’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:278:10: error: ‘mSupportedMaps’ was not declared in this scope; did you mean ‘AddSupportedMap’?
  278 |     if (!mSupportedMaps.empty())
      |          ^~~~~~~~~~~~~~
      |          AddSupportedMap
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:278:10: note: maximum limit of 1000 namespaces searched for ‘mSupportedMaps’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual uint32_t chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetNumberOfSelectedLocations()’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:292:34: error: ‘mSelectedLocations’ was not declared in this scope; did you mean ‘IsSelectedLocation’?
  292 |     return static_cast<uint32_t>(mSelectedLocations.size());
      |                                  ^~~~~~~~~~~~~~~~~~
      |                                  IsSelectedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:292:34: note: maximum limit of 1000 namespaces searched for ‘mSelectedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetSelectedLocationByIndex(uint32_t, uint32_t&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:297:21: error: ‘mSelectedLocations’ was not declared in this scope; did you mean ‘aSelectedLocation’?
  297 |     if (listIndex < mSelectedLocations.size())
      |                     ^~~~~~~~~~~~~~~~~~
      |                     aSelectedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:297:21: note: maximum limit of 1000 namespaces searched for ‘mSelectedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::AddSelectedLocation(uint32_t, uint32_t&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:312:9: error: ‘mSelectedLocations’ was not declared in this scope; did you mean ‘IsSelectedLocation’?
  312 |     if (mSelectedLocations.size() < kMaxNumSelectedLocations)
      |         ^~~~~~~~~~~~~~~~~~
      |         IsSelectedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:312:9: note: maximum limit of 1000 namespaces searched for ‘mSelectedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::ClearSelectedLocations()’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:327:10: error: ‘mSelectedLocations’ was not declared in this scope; did you mean ‘IsSelectedLocation’?
  327 |     if (!mSelectedLocations.empty())
      |          ^~~~~~~~~~~~~~~~~~
      |          IsSelectedLocation
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:327:10: note: maximum limit of 1000 namespaces searched for ‘mSelectedLocations’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual uint32_t chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetNumberOfProgressElements()’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:341:34: error: ‘mProgressList’ was not declared in this scope
  341 |     return static_cast<uint32_t>(mProgressList.size());
      |                                  ^~~~~~~~~~~~~
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:341:34: note: maximum limit of 1000 namespaces searched for ‘mProgressList’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetProgressElementByIndex(uint32_t, chip::app::Clusters::ServiceArea::Structs::ProgressStruct::Type&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:346:21: error: ‘mProgressList’ was not declared in this scope
  346 |     if (listIndex < mProgressList.size())
      |                     ^~~~~~~~~~~~~
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:346:21: note: maximum limit of 1000 namespaces searched for ‘mProgressList’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::GetProgressElementById(uint32_t, uint32_t&, chip::app::Clusters::ServiceArea::Structs::ProgressStruct::Type&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:363:24: error: ‘mProgressList’ was not declared in this scope
  363 |     while (listIndex < mProgressList.size())
      |                        ^~~~~~~~~~~~~
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:363:24: note: maximum limit of 1000 namespaces searched for ‘mProgressList’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::AddProgressElement(const chip::app::Clusters::ServiceArea::Structs::ProgressStruct::Type&, uint32_t&)’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:383:9: error: ‘mProgressList’ was not declared in this scope
  383 |     if (mProgressList.size() < kMaxNumProgressElements)
      |         ^~~~~~~~~~~~~
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:383:9: note: maximum limit of 1000 namespaces searched for ‘mProgressList’
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp: In member function ‘virtual bool chip::app::Clusters::ServiceArea::RvcServiceAreaDelegate::ClearProgress()’:
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:405:10: error: ‘mProgressList’ was not declared in this scope
  405 |     if (!mProgressList.empty())
      |          ^~~~~~~~~~~~~
../../examples/rvc-app/rvc-common/src/rvc-service-area-delegate.cpp:405:10: note: maximum limit of 1000 namespaces searched for ‘mProgressList’
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-unknown-warning-option’ may have been intended to silence earlier diagnostics
[10918/11742] c++ standalone/obj/zzz_generated/app-common/app-common/zap-generated/attributes/rvc-common.Accessors.cpp.o
ninja: build stopped: subcommand failed.

real    49m22,965s
user    334m56,918s
sys     23m0,151s

As per compiler's tip, I tried to add
#include <vector> to rvc-service-area-delegate.h
and the build completes flawlessly with no errors.
I'm currently a newcomer in Matter code understanding, but I think the build shall succeed without this addition. May this be an oversight in the example code.
Thank you in advance for any help. Feel free to ask more details if needed

We did think that this needed #include <vector>, but it was working without it, probably due to some convoluted include magic, so we opted to leave this out. I'll add it in as I'm still submitting PRs to update this example to match the latest spec.

I have added this as part of this PR.

Closing as a PR was merged for this.


Arbitrary Extension Objects

Awesome work with the library, I really love it. I want to be able to read arbitrary Extension objects in the format of map[string]interface{}. Arrays too :) Do you have some ideas about where should I start, what would be the best approach that would fit in the whole idea of the architecture? Maybe you even have some code snippets? Thank you.

We would also make use of such functionality. Do you know if anyone has every done any further work on enabling it?


Cypress/E2E: Fix public links and channel mode

Summary
Fix public links and channel mode
Ticket Link
none, failed on daily run
Screenshots

Release Note
NONE

/update-branch


⚠ File access has degraded performance

In e2012fa, File access (https://fyle.uk/file/fish) experienced degraded performance:

HTTP code: 200
Response time: 2929 ms

Resolved: File access performance has improved in 130f54a after 17 minutes.


Update nscplugin, sbt-scala-native to 0.5.1

About this PR
📦 Updates

org.scala-native:nscplugin
org.scala-native:sbt-scala-native

from 0.4.17 to 0.5.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-native" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-native" }
}]

labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

Superseded by #23.


Include sentiment annotations

PlWordNet 4.2 comes with a supplementary file (słownik_anotacji_emocjonalnej.csv) containing sentiment annotations for lexical units. Users should be able to load and access sentiment data.

Done


Color issue on Dark mode

Describe the bug
When switched to dark mode, text color is not changing to any of the light color so that it become visible, cards are very bright and would look better if they are more suited to dark mode like grey shade etc, text color in about us can be changed to a better color, like a dark one so that it becomes readable
To Reproduce
Steps to reproduce the behavior:

Go to 'website landing page'
Click on 'dark mode'
Scroll down 'till the end'
See errors

Expected behavior
Text colors can be changed so that they are better suited for dark mode and are readable by the user, the cards can be made less bright in the dark mode so that they also suit best in it
Screenshots

Desktop (please complete the following information):

OS: Windows 11
Browser: Chrome
Version: 105.0.5195.127

Additional context
I believe I can fix this issue can you please Assign it to me under the tag Hacktoberfest.

I want to solve these isssue.

please assign this issue to me


Remove redundancy in main.py for matching models

Thanks for your contribution.
I checked you committed version and everything worked fine.


Set Custom Offline Message

Hello,
Firstly, there is a method for showing offline status: showOfflineMessage()
I think it's default value should be "true", it is false now and I missed 3 hours before I found this function.
I set business hours on Panel and expected to see any message on my app about non-business hours.
And also, there is customization support for Android with "livechat.messages.offline" key, but there is no support to change it on iOS. If there is a function for setOfflineMessage on Flutter, that will be great.
Thanks,

Hello @ibrahimdevs, with regards to the showOfflineMessage API, the offline banner is enabled by default if the chat waiting time for the brand is not set to infinite. If the chat waiting time for the brand is set to infinite, the banner is disabled by default.
However, we provide you the option to override the defaults and enable(or)disable the offline banner as per your preferences using this API.
With regards to the string customization for the offline banner message, we currently do not have a dart API for the same.
For Android, you can continue using the livechat.messages.offline key in the strings.xml file.
For iOS, this can be achieved by following the below steps;
Within the AppDelegate.swift file, import Mobilisten by adding the import Mobilisten statement below the existing module imports. Within the application(_:didFinishLaunchingWithOptions:) method, you can add the below snippet of code to customize the string for example.
ZohoSalesIQ.Chat.setOfflineMessage("We are currently offline. We will get in touch with you shortly.")

We request you to try this out and let us know.

We hope our response was helpful to you. Please feel free to get back to us in case you have further queries.
Thanks.


feat: handlebars custom annotation messages

This add support for custom error messages using Handlebars.
closes #79
closes #100

Codecov Report

Merging #104 into main will increase coverage by 0.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   71.50%   72.50%   +0.99%
==========================================
  Files           6        6
  Lines         193      200       +7
  Branches       31       33       +2
==========================================
+ Hits          138      145       +7
  Misses         54       54
  Partials        1        1

Impacted Files
Coverage Δ

src/annotate.ts
94.73% <100.00%> (+0.79%)
:arrow_up:

src/config.ts
96.00% <100.00%> (ø)

src/rules.ts
100.00% <100.00%> (ø)

src/schema.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7178394...9add0a3. Read the comment docs.

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Custom fields tinymce language should be the current locale

Just what the subject says :)

great!

Welcome, and congrats on your great work.
Finally a rails CMS that i can work with and extend :)
If you don't mind i'll send you an email later this week regarding the
locale selection for the first request. I think it could be "smarter" (
based on the browser accepted languages ) and it should be
overloadable/overridable
Thanks again
Bruno
On Thu, Sep 3, 2015 at 12:32 AM Owen Peredo Diaz<EMAIL_ADDRESS>wrote:

great!
—
Reply to this email directly or view it on GitHub
https://github.com/owen2345/camaleon-cms/pull/50#issuecomment-137273325.