more reasonable default expiry

default is 600 = 10 minutes, which is a pretty short amount of time, for example when using lnbits fundingsource inside lnbits itself it would fail if you do a submarine swap or anything involved with hold invoices
i think 3600 = 1 hour should not make a difference in performance and is a way more reasonable default expiry

ACK
also changed the default in .env.example

Codecov Report

Merging #1825 (aa625b7) into main (153e22f) will decrease coverage by 0.79%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   55.47%   54.68%   -0.79%
==========================================
  Files          47       47
  Lines        7265     7265
==========================================
- Hits         4030     3973      -57
- Misses       3235     3292      +57

Impacted Files
Coverage Δ

lnbits/settings.py
87.55% <100.00%> (ø)

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add support for images on Notes

When creating notes on the go, you often times want to add an image to the note. StreetComplete has a solution for that, having an image server that the app uploads the image and then links the images there in the note.
Maybe, if we asked nicely, they'd allow EveryDoor to use their image server as well?

Duplicate of https://github.com/Zverik/every_door/issues/184


RFC templates: customizable html templates

Some html templates existing in invenio are still demosite-specific. I can mention here the home page of invenio, and the main frame layout with navigation bar layout at page_base.html.
Such pages pulls always some specific css. On the other hand they are going to be almost always overwritten by an overlay, so the css required by them is going to interfere with overwritten templates. This issue is a topic of the following PR: https://github.com/inveniosoftware/invenio/pull/2028
Html snippets like a search-bar, deposit form, and similar are always welcome to have in invenio, as they have high probability of being reused.

Most of the base templates has been modified to fit various use-cases (latest related PR #2789).


Question getting Orders Continuous

Hello,
So I have a question.
I have a WPF application and I want to get continuous TradeHistory so if it goes to a price I can buy or sell.
What would be the best way to do this? Create a method and call
ProductsService.GetTradesAsync
every 1 second?
I have never created an application to get continuous data.
Thank you (I wasn't sure where to post this)

@ExceedingLife for continuous data I would recommend looking into using the websocket feed. please refer to the documentation here: https://docs.pro.coinbase.com/#websocket-feed and the Getting Started thread https://github.com/dougdellolio/coinbasepro-csharp/issues/118 for code examples. thanks


Feature/restructure meta project

added language wrappers as submodules
updated readme
added language examples as submodules

Looks good! I just noticed that when in cuvis.sdk you see the links for the various language submodules eg. "cuvis.cpp". Now if you go in the examples folder, again the link shows "cuvis.cpp" but the link gets you to "cuvis.cpp.examples". Is this on purpose?

Regarding the names, yes this is on purpose, because all subfolders are already in the folder examples


text not synced if pasted into wysiwyg

in collab (affects E+ too):

enter wysiwyg editor
paste text that's in font and code range that aren't currently already rendered on canvas
the text element is not synced to other client (even after confirmation)

/cc @Mrazator

I've also faced this problem when using Excalidraw with my own colab server.
This would also cause problem when user just type one char and click other places so the wysiwyg editor would first sync a 0 text length element then sync out another with the one action pasted text, which I guess is the cause of the problem (sending out empty text text element first.)
I tested a simple temporary fix for this problem with my own colab server, and it's working now.
Not sure what would be the best way to solve this, but the temporary fix is like this:
https://github.com/killkli/excalidraw/commit/e4c8a222397cea1755ec311f234eda0e6a1fff76
Hope guys could come up with better ways to solve this~


Perf/full http response

Codecov Report

Merging #703 (ada6674) into response-refactoring (d2ff02d) will increase coverage by 0.64%.
The diff coverage is 81.13%.

@@                   Coverage Diff                    @@
##           response-refactoring     #703      +/-   ##
========================================================
+ Coverage                 48.15%   48.79%   +0.64%
========================================================
  Files                        68       69       +1
  Lines                      2033     2041       +8
  Branches                     48       48
========================================================
+ Hits                        979      996      +17
+ Misses                     1054     1045       -9

Impacted Files
Coverage Δ

...io-http/src/main/scala/zhttp/service/Handler.scala
46.66% <33.33%> (-7.34%)
:arrow_down:

...erver/content/handlers/ServerResponseHandler.scala
84.61% <84.61%> (ø)

zio-http/src/main/scala/zhttp/http/HttpData.scala
50.00% <100.00%> (ø)

zio-http/src/main/scala/zhttp/service/Server.scala
53.06% <100.00%> (+1.99%)
:arrow_up:

...io-http/src/main/scala/zhttp/service/package.scala
100.00% <100.00%> (ø)

...http/service/server/ServerChannelInitializer.scala
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ff02d...ada6674. Read the comment docs.

Fixed in #711


[Dropdown] Display sub menu on the left when if cannot fit screen

Fixes issue #4112

This change is

Looks good, I'll try to review sometime soon.

Cool, that would be great

Comments from Reviewable

LGTM

@jlukic Any updates on this? Can we expect it included in a release anytime soon?

In my testing it appeared after leftward was set it would reset to rightward on every other open because it would then pass the is.fitWidth (now `can.openRightward) function.
I've fixed this, and also modified the css to move the pointer with pointing dropdown menu when opening leftward

@jlukic Thanks.


Hive Gateway subscriptons not working

Issue workflow progress

Progress of the issue based on the
Contributor Workflow

[ ] 1. The issue provides a reproduction available on
Github,
Stackblitz
or
CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.
Please make sure Mesh package versions under package.json matches yours.

[ ] 2. A failing test has been provided
[ ] 3. A local solution has been provided
[ ] 4. A pull request is pending review

Describe the bug
Graphql subscriptions do not work. If i try to run the subscription through GraphiQL, the response is 404

The OpenTelemetry logs are as follows:
{
resource: {
attributes: {
'service.name': 'Gateway',
'telemetry.sdk.language': 'nodejs',
'telemetry.sdk.name': 'opentelemetry',
'telemetry.sdk.version': '1.25.1',
'process.pid': 6,
'process.executable.name': 'node',
'process.executable.path': '/usr/local/bin/node',
'process.command_args': [ '/usr/local/bin/node', '/serve/bin.mjs', 'supergraph' ],
'process.runtime.version': '22.8.0',
'process.runtime.name': 'nodejs',
'process.runtime.description': 'Node.js',
'process.command': '/serve/bin.mjs',
'process.owner': 'node',
'host.name': 'hive-gateway-external-66984f7fd-5w5hb',
'host.arch': 'amd64'
}
},
instrumentationScope: { name: 'gateway', version: undefined, schemaUrl: undefined },
traceId: '5a5a8607eaa73a972e9cf13cb7f104e7',
parentId: undefined,
traceState: undefined,
name: 'GET /gateway/graphql',
id: 'a2a1816dfb7b25ec',
kind: 1,
timestamp:<PHONE_NUMBER>069000,
duration: 2460.951,
attributes: {
'http.method': 'GET',
'http.url': 'http://localhost/gateway/graphql?query=subscription+test%7BinventoryEvents%7B...on+CabinetStatusChangedEvent%7BeventId+cabinetId+previousStatusId+currentStatusId%7D...on+CageStatusChangedEvent%7BeventId+cageId+previousStatusId+currentStatusId%7D%7D%7D&operationName=test&extensions=%7B%7D',
'http.route': '/gateway/graphql',
'http.scheme': 'http:',
'net.host.name': 'localhost',
'http.host': 'localhost',
'http.client_ip': '<IP_ADDRESS>',
'http.user_agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:130.0) Gecko/20100101 Firefox/130.0',
'http.status_code': 404
},
status: { code: 2, message: 'Not Found' },
events: [],
links: []
}

Queries for the same subgraph that provides this subscription work correctly.
Subscribing directly to subgraph works correctly

**To Reproduce** Steps to reproduce the behavior:

Run Hive Gateway with at least one subgraph implementing subscriptions using websocket transport.
Configure Hive Gateway with endpoint:

gateway.config.ts: |
import {defineConfig, type WSTransportOptions, createStdoutExporter} from '@graphql-hive/gateway'
export const gatewayConfig = defineConfig({
  transportEntries: {
    // use "*.http" to apply options to all subgraphs with HTTP
    '*.http': {
      options: {
        subscriptions: {
          kind: 'ws',
          location: '/graphql'
        } satisfies WSTransportOptions
      }
    }
  },
  openTelemetry: {
    exporters: [
      // A simple output to the console.
      // You can add more exporters here, please see documentation below for more examples.
      createStdoutExporter()
    ],
    spans: {
      http: true, // Whether to track the HTTP request/response
      graphqlParse: true, // Whether to track the GraphQL parse phase
      graphqlValidate: true, // Whether to track the GraphQL validate phase
      graphqlExecute: true, // Whether to track the GraphQL execute phase
      subgraphExecute: true, // Whether to track the subgraph execution phase
      upstreamFetch: true // Whether to track the upstream HTTP requests
    }
  }
})

**Expected behavior**

Subscriptions work correctly

**Environment:**

- OS:
- Hive Gateway Docker

Could you give more details about your subgraphs?
Do they use graphql-ws protocol? Or maybe they use the legacy subscriptions-transport-ws?

There is only one subgraph serving subscriptions. It is based on graphql-ws protocol
https://docs.spring.io/spring-graphql/reference/transports.html#server.transports.websocket
But it seems like the gateway is not even trying to call it

I tried making a request with Postman GraphQL client.
There is says that gateway responded with incorrect response code

Here are the logs from this request
{
resource: {
attributes: {
'service.name': 'Gateway',
'telemetry.sdk.language': 'nodejs',
'telemetry.sdk.name': 'opentelemetry',
'telemetry.sdk.version': '1.25.1',
'process.pid': 6,
'process.executable.name': 'node',
'process.executable.path': '/usr/local/bin/node',
'process.command_args': [ '/usr/local/bin/node', '/serve/bin.mjs', 'supergraph' ],
'process.runtime.version': '22.8.0',
'process.runtime.name': 'nodejs',
'process.runtime.description': 'Node.js',
'process.command': '/serve/bin.mjs',
'process.owner': 'node',
'host.name': 'hive-gateway-external-7664cc5d55-89g5m',
'host.arch': 'amd64'
}
},
instrumentationScope: { name: 'gateway', version: undefined, schemaUrl: undefined },
traceId: '4fce12dacd20a8c23d04f77f0cdddbf9',
parentId: undefined,
traceState: undefined,
name: 'GET /gateway/graphql',
id: 'c16e61a8e3b4aaaf',
kind: 1,
timestamp:<PHONE_NUMBER>615000,
duration: 732.977,
attributes: {
'http.method': 'GET',
'http.url': 'http://localhost/gateway/graphql',
'http.route': '/gateway/graphql',
'http.scheme': 'http:',
'net.host.name': 'localhost',
'http.host': 'localhost',
'http.client_ip': '<IP_ADDRESS>',
'http.user_agent': 'PostmanClient/undefined (AppId=6217ee3f-4ef9-4f3d-b10a-c0582107b1ea)',
'http.status_code': 200
},
status: { code: 1, message: undefined },
events: [],
links: []
}

Can you give me an example of correct curl for querying subscription on gateway?

curl 'http://localhost:4000/graphql' \
  -H 'accept: text/event-stream' \
  -H 'content-type: application/json' \
  --data-raw '{"query":"subscription OnProductPriceChanged { productPriceChanged { name price reviews { score } } }","operationName":"OnProductPriceChanged"}'

You can initiate an SSE connection as in here with curl.
Regarding the error in the screenshots you shared above;
In there, you are trying to connect the gateway via WebSockets not SSE.
We only support the actively developed graphql-ws only not deprecated subscriptions-transport-ws .
I am not sure which one Postman uses there.

Hi, I tried forming the request like in the curl you described.
This resulted in error:
event: next
data: {"errors":[{"message":"Cannot find package '@graphql-mesh/transport-ws' imported from /node_modules/.chunk/createGatewayRuntime-DfdVdZl2.mjs","locations":[{"line":1,"column":20}],"path":["inventoryEvents"]}]}

event: complete
data:

And in the logs:
[2024-09-13T09:21:43.876Z] DEBUG vdc-inventory-service - 430ed7d622f261c84c120254f2868472 subgraph-execute {
query: 'subscription test2{inventoryEvents{__typename ...on CabinetStatusChangedEvent{eventId}}}',
variables: {}
}
[2024-09-13T09:21:43.876Z] DEBUG Loading transport "ws" for subgraph vdc-inventory-service
[2024-09-13T09:21:43.877Z] HOOKS Trying default resolve for "@graphql-mesh/transport-ws"
[2024-09-13T09:21:43.879Z] DEBUG Processing GraphQL Parameters done.
[2024-09-13T09:21:43.878Z] HOOKS Trying default resolve for "@graphql-mesh/transport-ws" failed; trying alternatives
[2024-09-13T09:21:43.878Z] HOOKS Trying<EMAIL_ADDRESS>
This likely means two things:

The docker image is missing the transport-ws package
The GraphiQL provided with the Gateway is not compatible with how the Gateway handles subscriptions


[HOLD for payment 2022-12-22][$500] Bug: Old dot link without ‘www.’ prefix ( expensify.com/inbox) does not auto signin to old dot reported by @sobitneupane

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Login to new dot expensify.
Send old dot link without ‘www.’ prefix (example: expensify.com/inbox)
Press the link.

Expected Result:
You are automatically signed in to old dot.
Actual Result:
You are prompted to enter password.
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.2.14
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/195652418-0de43661-52fa-4eab-9290-7553df8d2252.mov
Expensify/Expensify Issue URL:
Issue reported by: @sobitneupane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665568331616469
View all open jobs on GitHub
https://user-images.githubusercontent.com/43996225/195652444-18c7006d-2fae-4355-8b01-6c5ab9894113.mp4
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~011559e465b3832421
Upwork Job ID:<PHONE_NUMBER>330884096
Last Price Increase: 2022-12-23

Didn't get to this before I went OoO, reassigning!

Reproduced in prod in an incognito window.

Can be worked externally

Proposal
Problem
In https://github.com/Expensify/App/blob/d6baba0be2da93beee72d8f21a6ee83e297fdd1a/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js#L28-L48
we check attrHref.startsWith(CONFIG.EXPENSIFY.EXPENSIFY_URL) to detect it's expensify url or not, but EXPENSIFY_URL = https://www.expensify.com/
Solution
In https://github.com/Expensify/App/blob/d6baba0be2da93beee72d8f21a6ee83e297fdd1a/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js
We'll remove www. in attrHref and expensifyUrl before we check attrHref.startsWith(CONFIG.EXPENSIFY.EXPENSIFY_URL).

+    const attrHrefWithoutW3 = attrHref.startsWith('www.')? attrHref.replace('www.',''):attrHref;
+    const expensifyUrlWithoutW3 = CONFIG.EXPENSIFY.EXPENSIFY_URL.replace('www.','');
+    const conciergeUrlWithoutW3 = CONFIG.EXPENSIFY.CONCIERGE_URL.replace('www.','');

    const internalNewExpensifyPath = (attrHref.startsWith(CONST.NEW_EXPENSIFY_URL) && attrHref.replace(CONST.NEW_EXPENSIFY_URL, ''))
        || (attrHref.startsWith(CONST.STAGING_NEW_EXPENSIFY_URL) && attrHref.replace(CONST.STAGING_NEW_EXPENSIFY_URL, ''));
-    const internalExpensifyPath = attrHref.startsWith(CONFIG.EXPENSIFY.EXPENSIFY_URL)
-                                    && !attrHref.startsWith(CONFIG.EXPENSIFY.CONCIERGE_URL)
-                                    && attrHref.replace(CONFIG.EXPENSIFY.EXPENSIFY_URL, '');
+    const internalExpensifyPath = attrHrefWithoutW3.startsWith(expensifyUrlWithoutW3)
+                                    && !attrHrefWithoutW3.startsWith(conciergeUrlWithoutW3)
+                                   && attrHrefWithoutW3.replace(expensifyUrlWithoutW3, '');

https://user-images.githubusercontent.com/113963320/198528098-8234dfc1-f9b4-4c9a-a3e9-fd64741e0295.mp4

Thanks for the proposal @tienifr Good catch. Let's improve your solution. It would be great to create a common function that matches any two domains. I think simple rules will be.

Create a function that takes two params A and B with type url.
Exclude the parts after domain segment from URLs.
Return true when domains A and B are exact matches.
Return true when domains A and B  and their subdomains are a match. (if no subdomain is passed use www or if www subdomain is passed, ignore it)
3 Ignore protocol part https or http.
Return false for all other cases.

Update Proposal
@parasharrajat I updated my solution in here: https://github.com/tienifr/App/pull/18. Pls help to check, thanks.

@conorpendergrast Thanks for your review. I realized that new URL not work on native, so I changed to use url libs. Pls help check: https://github.com/tienifr/App/pull/18

@MonilBhavsar Are we fine with package url? https://github.com/Expensify/App/issues/11810#issuecomment-1298209880

Hmm, This looks good. But I'm not sure about the process of using new package. Let's post this in channel and get thoughts from the team?

@parasharrajat let's discuss this in slack about adding and using a new package. Do you mind opening a conversation with the context you have?

Asked in https://expensify.slack.com/archives/C01GTK53T8Q/p1667833896505429. Please chime in.

@tienifr Is it possible to use regExp or something to get rid of url package from your solution?

@parasharrajat I've updated my PR to use regExp: https://github.com/tienifr/App/pull/18. Pls help check again. Thanks

const reURLInformation = new RegExp([
    '^(https?:)//', // protocol
    '(([^:/?#]*)(?::([0-9]+))?)', // host (hostname and port)
    '(/{0,1}[^?#]*)', // pathname
    '(\\?[^#]*|)', // search
    '(#.*|)$', // hash
].join(''));

I am not sure how good these are you will have to improve them during tests. try with different possible URLs. e.g https://github.com/Expensify/App/issues/7853
Also, the purpose of creating this function is to replace all usages of manual URL matching. Both internalNewExpensifyPath and internalExpensifyPath should be replaced with this.
Also, a better name for the function would be getURLObject. We can drop the unnecessary parts e.g. hash search as they are not needed for this.
Rest, @tienifr 's proposal looks good to me.
cc: @MonilBhavsar
:ribbon: :eyes: :ribbon:  C+ reviewed

@parasharrajat Thanks for your review. I've updated my sample PR: https://github.com/tienifr/App/pull/18

Proposal looks good to me 👍

@tienifr left some comments on your proposal/PR after initial review

Hi @parasharrajat  @MonilBhavsar  I just fixed your comments and created PR on the Expensify repo. Please help to review it. Thanks

I just realized the UpWork job was not posted, so I finished that — https://www.upwork.com/jobs/~018c4bbda06b5c47e0.
Was prompted to double it, so set it at $500.

@CortneyOfstad we already hire a contributor for this job so it should not be doubled.

Sorry about that! Changing it back now!

In review.

Thanks @CortneyOfstad, I've applied to the job

@tienifr @parasharrajat @sobitneupane I sent over the contract details in UpWork. Let me know if you have any questions!

Not overdue

Were required to change expensify-common lib
That PR is merged, and expensify-common lib version is updated in App repo.
Now onto the final App PR

Reviewing PR's

Discussing in PR

^^ Same, Discussing in PR

@MonilBhavsar @parasharrajat @tienifr Sorry for the delay on this — I'm wondering about the payment. Does this need to be made at this point since a fix has not yet been implemented? TIA!

No payments yet. Please reset the title and let's wait for the final PR to be merged.
I would also request a bonus for @tienifr because it required working on multiple PRs and we asked them to create a more generalized solution.

PR in review. Discussing there

👋 Nice! C+ approved, over to you Monil. This is an oldie, excited to get it over the line!
Also, friendly reminder to label the issue as Reviewing when the linked PR is in review. Thanks!

Heading OoO for two weeks starting now, so reassigning 👍

Issue not reproducible during KI retests. (First week)

Ah, the final PR was merged and has already passed a week since it was deployed.
We're fine to issue the payment and close this

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.40-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/12701

If no regressions arise, payment will be issued on 2022-12-22. :confetti_ball:
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@MonilBhavsar @parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@MonilBhavsar @parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@MonilBhavsar @parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@sonialiap] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

@sonialiap can we please issue the payments and close this issue

Reviewing label kept this from going overdue.  @sonialiap can you please ensure all payments are made and also complete the regression test steps?

On it 🖖

Following this SO, posted regression test proposal in slack

Created new regression test oldDot links clicked in newDot automatically log user into oldDot

Regression test GH issue https://github.com/Expensify/Expensify/issues/256201

@parasharrajat can you help me identify which PR caused this issue?

Not a regression, I think. We missed this case initially while implementing this

@sonialiap is issuing payment

Offer sent to @sobitneupane for reporting issue

@tienifr please apply for this job:
https://www.upwork.com/jobs/~01af93adacf3d34f62
@parasharrajat I believe I found your profile on Upwork and invited you to the job, offer sent :)

I would also request a bonus for @tienifr because it required working on multiple PRs and we asked them to create a more generalized solution. cc: @MonilBhavsar

@MonilBhavsar @parasharrajat I'd like to confirm on the bonus mentioned here
This issue requires many PRs, a generalized solution, with 70+ lines of code added and a new ~250 lines test file.
https://github.com/Expensify/App/pull/12701
https://github.com/Expensify/expensify-common/pull/475

@tienifr thanks for bringing that up! Please apply for https://www.upwork.com/jobs/~01af93adacf3d34f62 and I'll include the bonus

@sonialiap should we align on the bonus amount on this thread first, similar to in here?
@parasharrajat @MonilBhavsar what do you think?

@tienifr yes, good idea. Do you have thoughts of how much the bonus should be on this issue?
(Rajat, I am going to hold of sending a bonus payment until we figure out the bonus amount)

@sonialiap I think $500 bonus would be reasonable considering the amount of changes made are rather huge compared to a regular issue.
But I'm all good with any decision made by @parasharrajat here.
I've applied to the job, thanks.

Sound good @tienifr. @MonilBhavsar, can you please confirm via a comment that you're cool with this and I'll issue payment?

I think $250 is fine for the additional PR as 50% bonus.
Adding tests and clean up is considered part of work. It may not be needed for some PRs but it doesn't count as additional work.

I agree with Rajat's reasoning here and $250 bonus

@sonialiap can we please issue the payment and bonus here

@sonialiap is ooo

Bonused Rajat $250.  Paid @sobitneupane $250 for reporting.
@tienifr can you please accept the job and reply here once you have? You'll get paid $750 total
https://www.upwork.com/jobs/~01af93adacf3d34f62

@mallenexpensify accepted, thanks!

Paid @tienifr $750
I added this to the testing guidelines we're working on, since it doesn't make sense (to me) to have a test case for it.
As for the other regression checklist items, I don't remember this ever working correctly before, does anyone?

@mallenexpensify thanks!

since it doesn't make sense (to me) to have a test case for it.

I think we should have a test for this in chat messages list. We discussed here https://expensify.slack.com/archives/C01SKUP7QR0/p1673918731715469
Regarding regression, I believe it is like this since beginning, as we missed this case.

oooh, I didn't know we had an area for OldDot Transition in TestRail, that sounds like the best place for it.  Thanks @MonilBhavsar

Thanks @mallenexpensify!

Looks like everyone are paid.
we can close this once we have requested to add this to regression testing. cc @sonialiap

Was just following up on the regression GH. Looks like all is set on this one, everyone's paid and the regression test is set up. We can close 👍

Thanks!


create a plugins-all package

NB: Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue on opentelemetry-specification first.
Is your feature request related to a problem? Please describe.
Would like an easy way to install plugins that would help to autoinstrument my app that would be sending opentelemetry traces.
Describe the solution you'd like
A plugins-all package that would instal the kitchen sink from opentelemetry-js-contrib.
Describe alternatives you've considered
Possible alternatives:

Manual instructions for the user to find the package and install themselves.
Utility tool to detect what npm package is already in the system and echo to the user a suggested npm command to run to install plugins that would help to auto-instrument.

Additional context
Talked about on 2020-04-22 agenda

Per sig, I will create it with name @opentelemetry/plugins-all-node

This has been implemented since then (https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/metapackages/plugins-node-core-and-contrib) so i'm closing this


Error as soon as the miner receives first job: missing field job_id

Trying to run the grin-miner alongside the node, not sure where the bug actually lies. It's spitting out an error as soon as it receives its first job. Happy to test any fixes and provide any info I can. Running on debian amd64.
This is the error from the grin-miner:
Jul 11 16:47:53.008 DEBG Received message: {"id":"Stratum","jsonrpc":"2.0","method":"job","params":{"difficulty":1,"height":3803,"pre_pow":"00010000000000000edb05784f3b370b9a5aa5dfa2$

Jul 11 16:47:53.009 DEBG Received request type: job
Jul 11 16:47:53.064 ERRO
thread 'client_controller' panicked at 'called `Result::unwrap()` on an `Err` value: Error("missing field `job_id`", line: 0, column: 0)': libcore/result.rs:945stack backtrace:
   0:     0x5642be930b6c - backtrace::backtrace::trace::hcb6d74f522eafe9d
   1:     0x5642be930192 - backtrace::capture::Backtrace::new::h5075cb690ef81509
   2:     0x5642be81f54f - grin_miner_util::logger::send_panic_to_log::{{closure}}::h8dea98af9827d598
   3:     0x5642be943ac5 - std::panicking::rust_panic_with_hook::h55e258944e31bc6d
                        at libstd/panicking.rs:467
   4:     0x5642be94360c - std::panicking::begin_panic_fmt::ha93d510596c1ce0e
                        at libstd/panicking.rs:350
   5:     0x5642be9435d1 - rust_begin_unwind
                        at libstd/panicking.rs:328
   6:     0x5642be99a302 - core::panicking::panic_fmt::h48a9dc276960b80c
                        at libcore/panicking.rs:71
   7:     0x5642be7bc07d - core::result::unwrap_failed::h94a0a4510ca2aa22
   8:     0x5642be786839 - grin_miner::client::Controller::run::h82ee6a9c68de931c
   9:     0x5642be794cec - std::sys_common::backtrace::__rust_begin_short_backtrace::he9e665643ab55f7b
  10:     0x5642be769217 - std::panicking::try::do_call::h7ad9e58f3a95d8ae
  11:     0x5642be960aa9 - __rust_maybe_catch_panic
                        at libpanic_unwind/lib.rs:105
  12:     0x5642be7a7030 - <F as alloc::boxed::FnBox<A>>::call_box::h41bcb4ab274a4a07
  13:     0x5642be954d6a - <alloc::boxed::Box<alloc::boxed::FnBox<A, Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::h9ad684$
                        at /checkout/src/liballoc/boxed.rs:648
                         - std::sys_common::thread::start_thread::h2698ca233d3cb229
                        at libstd/sys_common/thread.rs:24
  14:     0x5642be943fb5 - std::sys::unix::thread::Thread::new::thread_start::h80e954ec963e7e56
                        at libstd/sys/unix/thread.rs:90
  15:     0x7fc795442493 - start_thread
  16:     0x7fc794f6dace - __clone
  17:                0x0 - <unknown>

and this is the error from the grin node:
Jul 11 16:52:36.050 WARN (Server ID: StratumServer) Failed to parse JSONRpc: JSON error - []
Jul 11 16:52:36.101 WARN (Server ID: StratumServer) Dropping worker: 0

Hi, I think you just need to ensure you're running the latest Grin code (from the master branch now) as well as the lastest grin miner.

Can confirm this was just a grin node issue. The build docs specified checking out of testnet3 but master was actually needed.


[lakeFSFS] First steps in supporting Unity

Support DataBricks Unity Catalog tables in lakeFS.
DoD: One table defined on lakeFS that can be defined and read from DB Unity.

First challenge: Authentication and authorization
Cannot use the S3 gateway!
Unity uses IAM roles to authenticate.  This will not work with the S3 gateway for multiple reasons, each of which is enough to block this.    Unity is configured with an AWS IAM role, which assumes the AWS customer role.  This won't work with the S3 gateway because:

There is no shared identity provider between Unity and lakeFS.  So Unity cannot prove to lakeFS that it managed to assume the desired customer role.
Even suppose we added STS assume-role support to lakeFS (this is #3919).  Without changes on the DB side, Unity would have no way of proving to lakeFS that it is Unity, so lakeFS would have no way of authorizing Unity to assume some lakeFS-side role.

lakeFSFS doesn't work
Attempting to read fails to initialize the underlying filesystem, see attached stacktrace.  The important lines appear to be:
Caused by: shaded.databricks.org.apache.hadoop.fs.s3a.AWSClientIOException: doesBucketExist on lakefs-sample-us-east-1-staging: com.amazonaws.AmazonClientException: No AWS Credentials provided by AwsCredentialContextTokenProvider : com.amazonaws.SdkClientException: Unable to load AWS credentials from any provider in the chain: [com.databricks.backend.daemon.driver.aws.AwsLocalCredentialContextTokenProvider@1da3ba5a: No role specified and no roles available., com.databricks.backend.daemon.driver.aws.ProxiedIAMCredentialProvider@75b4975c: User does not have any IAM roles]: No AWS Credentials provided by AwsCredentialContextTokenProvider : com.amazonaws.SdkClientException: Unable to load AWS credentials from any provider in the chain: [com.databricks.backend.daemon.driver.aws.AwsLocalCredentialContextTokenProvider@1da3ba5a: No role specified and no roles available., com.databricks.backend.daemon.driver.aws.ProxiedIAMCredentialProvider@75b4975c: User does not have any IAM roles]
	at shaded.databricks.org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:207)
	at shaded.databricks.org.apache.hadoop.fs.s3a.Invoker.once(Invoker.java:120)
	at shaded.databricks.org.apache.hadoop.fs.s3a.Invoker.lambda$retry$3(Invoker.java:274)
	at shaded.databricks.org.apache.hadoop.fs.s3a.Invoker.retryUntranslated(Invoker.java:333)
	at shaded.databricks.org.apache.hadoop.fs.s3a.Invoker.retry(Invoker.java:270)
	at shaded.databricks.org.apache.hadoop.fs.s3a.Invoker.retry(Invoker.java:245)
	at shaded.databricks.org.apache.hadoop.fs.s3a.S3AFileSystem.verifyBucketExists(S3AFileSystem.java:679)
	at shaded.databricks.org.apache.hadoop.fs.s3a.S3AFileSystem.initialize(S3AFileSystem.java:519)
	at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2669)
	at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:94)
	at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2703)
	at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2685)
	at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:373)
	at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
	at io.lakefs.storage.SimpleStorageAccessStrategy.createDataInputStream(SimpleStorageAccessStrategy.java:82)
	at io.lakefs.LakeFSFileSystem.open(LakeFSFileSystem.java:198)
	at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:769)

#4923 is probably this problem but for writing, or hopefully similar; different messages appeared in the stacktrace.

@arielshaqed can you share the steps to reproduce this error? the more the detailed the better.
Additionally, if we do require Unity to add support for something in order for this integration to work, we'd need a detailed explanation of what that something is... (once we have an idea, of course)

Continued elsewhere.


Ugrade phpstan to ^1.3

Phpstan 1.0.0 was released in november.
This PR use last version !
We may also add @deprecated annotation on getUsername methods . It's deprecated in UserInterface since sf 5.3 in favor of getUserIdentifier()

With no use of deprectaed getUsername method coverage is now bellow 99%
Code coverage is 98.87%, which is below the accepted 99%
Should I add an unit test on getUsername ?

Should I add an unit test on getUsername ?

Yes please (in fact, this coverage is mainly for checking open source PR) ... or you can also lower it to 98% :shrug:

Big thanks @alamirault :beers:


JCL-394: Issued At javadoc

The issuance date is already supported by AccessCredential subtypes, but the base class is missing a javadoc.

I saw this part of the issuance date.
But isn't the issue(..) method supposed to have a final Instant issuanceDate in its call such that the request, for example, can be requested for a future date?


Updates for working with 1.9 version

Some of these changes are actually from 1.8 but the warnings were silenced

Neat, many thanks for this!


Different amount of tests on different platform

@esttorhe, while you were creating targets you told us that both OS X and iOS will use the same test target. Could you explain something to me? (I have no idea how it works)
Right now, when I run tests on iOS I get:

Which was fine until I switched to OS X and run tests again which produced something different:

I wonder if it's normal that different targets shows us different test coverage? If you'll tell me that this is totally normal I'm fine... I just have no experience in this matter and that made me thinking 😉

I saw the same thing yesterday. Just go through all the files in the test target and make sure that they are all contained in both the OS X and iOS test targets. The way XCTest works is that it pulls all contained XCTestCase subclasses in the project and runs them. If you leave one out, it will still compile just fine, it just won't run those tests.


Responsive JSMpeg Player Sizing

Hi All -
I'm looking for help creating a responsive JSMpeg player that can adapt to resizing of the browser window.  I've tried using CSS to set the width of the video player's canvas to 100%; however, JSMpeg seems to change the size of the canvas as soon as it begins playing the video.  From what I can tell digging through the code, it appears JSMpeg uses MPEG1.decodeSequenceHeader() to read the width and height of the incoming frame and then adjusts the canvas to match.  Is it possible to scale the output based on the browser's size?
<canvas data-dojo-attach-point='videoNode' id='video-canvas' class='FMV_videoPanel'></canvas>
.overwatch-f-m-v FMV_videoPanel {     position: relative;     width: 100%;     height: auto;     top: 0px;     left: 0 px;     background-color: blue; }
A bit more about my configuration....I'm using ffmpeg to stream a previously recorded .TS file in its native resolution (1080x720p) to a Node.js server.  In turn, this server creates a websocket connection to a web application running the JSMpeg player.  I envision users accessing this web application from multiple platforms / browsers, and thus desire the scaling of the video to be responsive to their specific configuration.
What am I doing wrong?  Thank you in advance for the help.

If you create the Player in JS using new JSMpeg.Player() and attach it to a existing Canvas, it will not change the Canvas' style, but just the internal resolution. I.e. it will set width and height but not style.width or style.height, so you should be able to specify these yourself. I'm not sure why it isn't working for you. Do you have an example online somewhere?
Have a look at the JSMpeg demo page - I believe this does what you want. It just specifies width:100%; for the #video Canvas element


collisionShape.make_convex_from_brothers() doesnt work.

There is a problem with convex and concave physic shapes.
I tried a lot but I couldn´t get it working. It changes the shape and it applies the right array to it but the physic engine still uses the shape settings I applied in the editor.

Well, this is the code of this method (it was always almost the same):
https://github.com/godotengine/godot/blob/a940b4cf640930b2decb356d395ac4cd89beefaf/scene/3d/collision_shape.cpp#L45-L65
Looks like it sets the shape from each of the sibling Meshes, effectively setting it to the last one.


v0.14 : KeyNotFoundException: The given key was not present in the dictionary.

I receive a key not found at https://github.com/colyseus/colyseus-unity3d/blob/master/Assets/Plugins/Colyseus/Serializer/Schema/ReferenceTracker.cs#L51
KeyNotFoundException: The given key was not present in the dictionary.
System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) (at <9577ac7a62ef43179789031239ba8798>:0)
Colyseus.Schema.ReferenceTracker.Remove (System.Int32 refId) (at Assets/Plugins/Colyseus/Serializer/Schema/ReferenceTracker.cs:51)

Fields generated by the last version of c# generator (original version)
Version :
colyseus server : 0.14.4
colyseus unity : 0.14.2
schema : 1.0.6

I'm getting the same issue, and then next time I try to update the same object I end up with:
Exception: refId not found: 6
Colyseus.Schema.Schema.Decode (System.Byte[] bytes, Colyseus.Schema.Iterator it, Colyseus.Schema.ReferenceTracker refs) (at Assets/Plugins/Colyseus/Serializer/Schema/Schema.cs:226)
Colyseus.SchemaSerializer`1[T].Patch (System.Byte[] data, System.Int32 offset) (at Assets/Plugins/Colyseus/Serializer/SchemaSerializer.cs:31)
Colyseus.Room`1[T].Patch (System.Byte[] delta, System.Int32 offset) (at Assets/Plugins/Colyseus/Room.cs:351)
Colyseus.Room`1+<ParseMessage>d__37[T].MoveNext () (at Assets/Plugins/Colyseus/Room.cs:310)

I have a large object (containing a bunch of MapSchema's) that I replace when this happens. Generally the first replacement will cause this but seem to work, while the second one doesn't.
I also tried instead of placing this object in a Map itself, deleting the old one and adding the new one in a new key - but it still causes the exact same issue.
For me this is breaking - this object contains the building blocks for user-created maps, and without being able to update them & replace them I am completely stuck.

Hi @soile1991 and @lee-orr, thanks for reporting, and sorry for the delay to answer. (I was on vacation the last few weeks)
It is likely that ArraySchema's decoder is the cause of this (C# client-side). Would you mind providing a minimal reproduction scenario where I can reproduce this? I've tried but failed to reproduce.
Ideally, if you can fork this project colyseus-unity3d and adapt the example to output this error in question would help a lot!
Thanks!

Hi @soile1991 and @lee-orr, thanks for reporting, and sorry for the delay to answer. (I was on vacation the last few weeks)
It is likely that ArraySchema's decoder is the cause of this (C# client-side). Would you mind providing a minimal reproduction scenario where I can reproduce this? I've tried but failed to reproduce.
Ideally, if you can fork this project colyseus-unity3d and adapt the example to output this error in question would help a lot!
Thanks!

I just spend a couple hours trying to find a minimal repro, but haven't really been able to do so... as least so far. I'll give that another try when I have the time.

I just spend a couple hours trying to find a minimal repro, but haven't really been able to do so... as least so far. I'll give that another try when I have the time.

Hey, @endel I made a fork from colyseus-unity3d and implemented the behavior to trigger the bug.
it's a card game you start with 52 cards and every time you click to play the cards button it plays 1 to 3 cards randomly if you hit it many times (e.g. once per second) it will trigger the bug before the remaining cards hit zero.
Repo:
forked repo (card game)
Thanks!

Hey, @endel I made a fork from colyseus-unity3d and implemented the behavior to trigger the bug.
it's a card game you start with 52 cards and every time you click to play the cards button it plays 1 to 3 cards randomly if you hit it many times (e.g. once per second) it will trigger the bug before the remaining cards hit zero.
Repo:
forked repo (card game)
Thanks!

Thanks for providing a reproducible example @soile1991 🥳
I've spent some time debugging it, and there were a few small issues decoding ArraySchema.
Could you confirm if copying the latest version of ArraySchema.cs into your project fixes the issue @soile1991 @lee-orr? If it does I can push a new version
Cheers!

Thanks for providing a reproducible example @soile1991 🥳
I've spent some time debugging it, and there were a few small issues decoding ArraySchema.
Could you confirm if copying the latest version of ArraySchema.cs into your project fixes the issue @soile1991 @lee-orr? If it does I can push a new version
Cheers!

I'll take a look in the morning! Thanks.
Lee-Orr

I'll take a look in the morning! Thanks.
Lee-Orr

@endel I think that fixed the bug.
I tried it many times and I didn't encounter it once.
Thank you 🙏

@endel I think that fixed the bug.
I tried it many times and I didn't encounter it once.
Thank you 🙏

When I first tested it it looked like the issue was resolved, but after continuing to work a little I ran into it again...

When I first tested it it looked like the issue was resolved, but after continuing to work a little I ran into it again...

In my case I'm changing a MapSchema rather than an ArraySchema - let me see if I can replicate your changes there...

In my case I'm changing a MapSchema rather than an ArraySchema - let me see if I can replicate your changes there...

Unfortunately I don't understand the changes well enough to know exactly how to replicate them on a MapSchema... I can try to give you access to my project, but it's an early-phase prototype with many moving parts, so I don't think it'll be easy to understand...

Unfortunately I don't understand the changes well enough to know exactly how to replicate them on a MapSchema... I can try to give you access to my project, but it's an early-phase prototype with many moving parts, so I don't think it'll be easy to understand...

@lee-orr I added a MapScema on my fork and it works ok (clear set delete) what is the operation you do when you run into the bug?

@lee-orr I added a MapScema on my fork and it works ok (clear set delete) what is the operation you do when you run into the bug?

@lee-orr can you try this version and see if works for you? https://gist.github.com/endel/ace4cf759161cb94ffbe07f0552af1f9
The problem on ArraySchema was because GetByIndex() was returning default(T) instead of null for non-existing entries. It's likely to be the same problem for MapSchema.

@lee-orr can you try this version and see if works for you? https://gist.github.com/endel/ace4cf759161cb94ffbe07f0552af1f9
The problem on ArraySchema was because GetByIndex() was returning default(T) instead of null for non-existing entries. It's likely to be the same problem for MapSchema.

@endel - Unfortunately, it seems like it's not resolved by bringing that file in... I'm still getting the same errors:
System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) (at <9577ac7a62ef43179789031239ba8798>:0)
Colyseus.Schema.ReferenceTracker.Remove (System.Int32 refId) (at Assets/Plugins/Colyseus/Serializer/Schema/ReferenceTracker.cs:51)
Colyseus.Schema.ReferenceTracker.GarbageCollection () (at Assets/Plugins/Colyseus/Serializer/Schema/ReferenceTracker.cs:78)
Colyseus.Schema.Schema.Decode (System.Byte[] bytes, Colyseus.Schema.Iterator it, Colyseus.Schema.ReferenceTracker refs) (at Assets/Plugins/Colyseus/Serializer/Schema/Schema.cs:471)
Colyseus.SchemaSerializer`1[T].Patch (System.Byte[] data, System.Int32 offset) (at Assets/Plugins/Colyseus/Serializer/SchemaSerializer.cs:31)
Colyseus.Room`1[T].Patch (System.Byte[] delta, System.Int32 offset) (at Assets/Plugins/Colyseus/Room.cs:351)
Colyseus.Room`1+<ParseMessage>d__37[T].MoveNext () (at Assets/Plugins/Colyseus/Room.cs:310)```
&
```Exception: refId not found: 6
Colyseus.Schema.Schema.Decode (System.Byte[] bytes, Colyseus.Schema.Iterator it, Colyseus.Schema.ReferenceTracker refs) (at Assets/Plugins/Colyseus/Serializer/Schema/Schema.cs:226)
Colyseus.SchemaSerializer`1[T].Patch (System.Byte[] data, System.Int32 offset) (at Assets/Plugins/Colyseus/Serializer/SchemaSerializer.cs:31)
Colyseus.Room`1[T].Patch (System.Byte[] delta, System.Int32 offset) (at Assets/Plugins/Colyseus/Room.cs:351)
Colyseus.Room`1+<ParseMessage>d__37[T].MoveNext () (at Assets/Plugins/Colyseus/Room.cs:310)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at <9577ac7a62ef43179789031239ba8798>:```

Is there anywhere I should place breakpoints to track what is happening?

@soile1991 - I am replacing an object that contains a bunch of MapSchema's (and some of the child types also contains MapSchema's) with another object with the same structure. So it's basically a mass clear & many sets.

@endel - Unfortunately, it seems like it's not resolved by bringing that file in... I'm still getting the same errors:
System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) (at <9577ac7a62ef43179789031239ba8798>:0)
Colyseus.Schema.ReferenceTracker.Remove (System.Int32 refId) (at Assets/Plugins/Colyseus/Serializer/Schema/ReferenceTracker.cs:51)
Colyseus.Schema.ReferenceTracker.GarbageCollection () (at Assets/Plugins/Colyseus/Serializer/Schema/ReferenceTracker.cs:78)
Colyseus.Schema.Schema.Decode (System.Byte[] bytes, Colyseus.Schema.Iterator it, Colyseus.Schema.ReferenceTracker refs) (at Assets/Plugins/Colyseus/Serializer/Schema/Schema.cs:471)
Colyseus.SchemaSerializer`1[T].Patch (System.Byte[] data, System.Int32 offset) (at Assets/Plugins/Colyseus/Serializer/SchemaSerializer.cs:31)
Colyseus.Room`1[T].Patch (System.Byte[] delta, System.Int32 offset) (at Assets/Plugins/Colyseus/Room.cs:351)
Colyseus.Room`1+<ParseMessage>d__37[T].MoveNext () (at Assets/Plugins/Colyseus/Room.cs:310)```
&
```Exception: refId not found: 6
Colyseus.Schema.Schema.Decode (System.Byte[] bytes, Colyseus.Schema.Iterator it, Colyseus.Schema.ReferenceTracker refs) (at Assets/Plugins/Colyseus/Serializer/Schema/Schema.cs:226)
Colyseus.SchemaSerializer`1[T].Patch (System.Byte[] data, System.Int32 offset) (at Assets/Plugins/Colyseus/Serializer/SchemaSerializer.cs:31)
Colyseus.Room`1[T].Patch (System.Byte[] delta, System.Int32 offset) (at Assets/Plugins/Colyseus/Room.cs:351)
Colyseus.Room`1+<ParseMessage>d__37[T].MoveNext () (at Assets/Plugins/Colyseus/Room.cs:310)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at <9577ac7a62ef43179789031239ba8798>:```

Is there anywhere I should place breakpoints to track what is happening?

@soile1991 - I am replacing an object that contains a bunch of MapSchema's (and some of the child types also contains MapSchema's) with another object with the same structure. So it's basically a mass clear & many sets.

@lee-orr can you share a snippet of the code deals with those operations and a snippet of your object with map schemas? If we can it will be easier for @endel to fix the bug on MapSchema

@lee-orr can you share a snippet of the code deals with those operations and a snippet of your object with map schemas? If we can it will be easier for @endel to fix the bug on MapSchema

It's complex - but here's the best explanation I can give:
We have a MapSchema of GameMap objects - each of which has a property called sdfOperators of type OperatorList. This is that type:
export class OperatorList extends Schema {
    @type(['string'])
    roots = new ArraySchema<string>();

    @type({ map: SimpleSDF })
    sdfs = new MapSchema<SimpleSDF>();

    @type({ map: FloorBuilder })
    floorBuilders = new MapSchema<FloorBuilder>();

    @type({ map: WallBuilder })
    wallBuilders = new MapSchema<WallBuilder>();

    @type({ map: PortalBuilder })
    portalBuilders = new MapSchema<PortalBuilder>();

    @type({ map: RoomBuilder })
    roomBuilders = new MapSchema<RoomBuilder>();

    @type({ map: ObjectPlacer })
    objectPlacers = new MapSchema<ObjectPlacer>();

    @type({ map: BlockBuilder })
    blocks = new MapSchema<BlockBuilder>();
}

And here's one example of an object in the maps contained inside:
export enum SDFPrimitive {
    Cube = "cube",
    Sphere = "sphere",
    Cylinder = "cylinder",
    Torus = "torus",
    Curve = "curve"
}

export enum OperationType {
    Add = "add",
    Remove = "remove",
    PaintMaterial = "paintMaterial"
}

export class SimpleSDF extends Schema {
    @type('string')
    id: string;

    @type('string')
    primative: SDFPrimitive;

    @type(Transformable)
    transform = new Transformable();

    @type('string')
    operation: OperationType;

    @type('float32')
    blend: number;

    @type(Color)
    color = new Color();

    @type({ map: 'float32' })
    parameters = new MapSchema<number>();

    @type(['string'])
    children = new ArraySchema<string>();

    static CreateOperation (params) : SimpleSDF {
        let sdf = new SimpleSDF();
        ///setting the contents
        return sdf;
    }
}

When changes are made to the map, a new OperatorList is generated and replaces the sdfOperators field in the GameMap like so:
const list = new OperatorList();
// processing some inputs to generate the operators, using the CreateOperation function for each type -
// and getting an object containing each operation
for (let i in result.sdf) list.sdfs.set(i, result.sdfs[i]); // same thing for all the other types of operations

// Set the new list as the current list for the map we're in
map.sdfOperators = list;

I have tried a couple of other options - such as creating an empty operator list, and replacing it later (so that it clears the content of the game map), populating the list after a timeout, or setting the "map.sdfOperators" first, and setting the list's properties later. I've also tried re-using the existing object, and just clearing each of the MapSchema/ArraySchema properties on it. None of those seemed to make a difference.
So far - I haven't been able to isolate what portion of the process actually causes the issues... Though I'll keep trying to do so.

It's complex - but here's the best explanation I can give:
We have a MapSchema of GameMap objects - each of which has a property called sdfOperators of type OperatorList. This is that type:
export class OperatorList extends Schema {
    @type(['string'])
    roots = new ArraySchema<string>();

    @type({ map: SimpleSDF })
    sdfs = new MapSchema<SimpleSDF>();

    @type({ map: FloorBuilder })
    floorBuilders = new MapSchema<FloorBuilder>();

    @type({ map: WallBuilder })
    wallBuilders = new MapSchema<WallBuilder>();

    @type({ map: PortalBuilder })
    portalBuilders = new MapSchema<PortalBuilder>();

    @type({ map: RoomBuilder })
    roomBuilders = new MapSchema<RoomBuilder>();

    @type({ map: ObjectPlacer })
    objectPlacers = new MapSchema<ObjectPlacer>();

    @type({ map: BlockBuilder })
    blocks = new MapSchema<BlockBuilder>();
}

And here's one example of an object in the maps contained inside:
export enum SDFPrimitive {
    Cube = "cube",
    Sphere = "sphere",
    Cylinder = "cylinder",
    Torus = "torus",
    Curve = "curve"
}

export enum OperationType {
    Add = "add",
    Remove = "remove",
    PaintMaterial = "paintMaterial"
}

export class SimpleSDF extends Schema {
    @type('string')
    id: string;

    @type('string')
    primative: SDFPrimitive;

    @type(Transformable)
    transform = new Transformable();

    @type('string')
    operation: OperationType;

    @type('float32')
    blend: number;

    @type(Color)
    color = new Color();

    @type({ map: 'float32' })
    parameters = new MapSchema<number>();

    @type(['string'])
    children = new ArraySchema<string>();

    static CreateOperation (params) : SimpleSDF {
        let sdf = new SimpleSDF();
        ///setting the contents
        return sdf;
    }
}

When changes are made to the map, a new OperatorList is generated and replaces the sdfOperators field in the GameMap like so:
const list = new OperatorList();
// processing some inputs to generate the operators, using the CreateOperation function for each type -
// and getting an object containing each operation
for (let i in result.sdf) list.sdfs.set(i, result.sdfs[i]); // same thing for all the other types of operations

// Set the new list as the current list for the map we're in
map.sdfOperators = list;

I have tried a couple of other options - such as creating an empty operator list, and replacing it later (so that it clears the content of the game map), populating the list after a timeout, or setting the "map.sdfOperators" first, and setting the list's properties later. I've also tried re-using the existing object, and just clearing each of the MapSchema/ArraySchema properties on it. None of those seemed to make a difference.
So far - I haven't been able to isolate what portion of the process actually causes the issues... Though I'll keep trying to do so.

Do you have any suggestions/ideas of where to look in the library itself to see if I can help debug it?

Do you have any suggestions/ideas of where to look in the library itself to see if I can help debug it?

Right now I'm working on some alternative approaches for this project - just because I haven't been able to debug it and need to get this done. But once I have some time again, I'll attempt to reduce this thing down to a minimal reproduction to the best of my ability. Sorry for the delay with that @endel - I don't want to take up more of your time on my specific project - so I'll resolve things differently for now and will get back to you when I have something that doesn't involve 2 separate node servers (colyseus + a rest API), a web based UI layer & and a unity based 3D display...

Right now I'm working on some alternative approaches for this project - just because I haven't been able to debug it and need to get this done. But once I have some time again, I'll attempt to reduce this thing down to a minimal reproduction to the best of my ability. Sorry for the delay with that @endel - I don't want to take up more of your time on my specific project - so I'll resolve things differently for now and will get back to you when I have something that doesn't involve 2 separate node servers (colyseus + a rest API), a web based UI layer & and a unity based 3D display...

I'm having an issue with that as well.
KeyNotFoundException: The given key was not present in the dictionary.
System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) (at <437ba245d8404784b9fbab9b439ac908>:0)
Colyseus.Schema.ReferenceTracker.GarbageCollection () (at Assets/Plugins/Colyseus/Serializer/Schema/ReferenceTracker.cs:70)
Colyseus.Schema.Schema.Decode (System.Byte[] bytes, Colyseus.Schema.Iterator it, Colyseus.Schema.ReferenceTracker refs) (at Assets/Plugins/Colyseus/Serializer/Schema/Schema.cs:471)
Colyseus.SchemaSerializer`1[T].Patch (System.Byte[] data, System.Int32 offset) (at Assets/Plugins/Colyseus/Serializer/SchemaSerializer.cs:31)
Colyseus.Room`1[T].Patch (System.Byte[] delta, System.Int32 offset) (at Assets/Plugins/Colyseus/Room.cs:351)
Colyseus.Room`1+<ParseMessage>d__37[T].MoveNext () (at Assets/Plugins/Colyseus/Room.cs:310)
--- End of stack trace from previous location where exception was thrown ---
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () (at <437ba245d8404784b9fbab9b439ac908>:0)
System.Runtime.CompilerServices.AsyncMethodBuilderCore+<>c.<ThrowAsync>b__6_0 (System.Object state) (at <437ba245d8404784b9fbab9b439ac908>:0)
UnityEngine.UnitySynchronizationContext+WorkRequest.Invoke () (at <58a34b0a618d424bb5fc18bb9bcdac20>:0)
UnityEngine.UnitySynchronizationContext:ExecuteTasks()

This happens when calling .splice() on the server on an ArraySchema instance held by the room state, but only if stuff is removed in at least two separate patches in a row - after that, it's thrown on every single state patch regardless of anything else. That does not happen when alternating between adding and removing a single item each time.
The weirdest thing is that so far it seems to have not actually prevented anything from working properly, or at least no cases of broken functionality can be observed. Still, it's pretty alarming.
Was this by any chance fixed in the recent Unity SDK release? If so, I could consider migrating, which otherwise I would prefer not to do, as I have limited a deadline to meet and would rather not waste time on non-essential adjustment.

@Unelith I will try to look into this soon but if it was fixed in the update it was done incidentally, so I wouldn't begin migrating your project on that hope quite yet. I will try to set up a good repro case locally and test with the updated SDK to confirm one way or the other

@mitchLucid Perhaps extra details could be useful then:

This ArraySchema holds instances of a Schema, whose definition is as follows:

export class AreaSettings extends SettingsGroup {
	@type('int32')
	distanceCalculationMode: number = 0;

	@type('int32')
	gridWidth: number = 10;

	@type('int32')
	gridHeight: number = 10;

	@type('string')
	distanceUnit: string = 'ft';

	@type('float64')
	gridSquareSideLength: number = 5.0;
}
export class AreaState extends Schema {
	@type('string')
	id: string;

	@type('string')
	name: string;

	@type( AreaSettings )
	areaSettings: AreaSettings = new AreaSettings();
}

On the client, having retrieved an AreaState schema instance from either OnAdd or OnRemove listener attached to the ArraySchema, I do pass it around quite a lot, for instance:

room.State.areas.OnAdd += emitter.HandleAddArea;

public void HandleAddArea(AreaState _area, int _idx) {
    onAddArea.Invoke(_area, _idx);

    _area.OnChange += (_changes) => {
        HandleAreaChanges(_area, _idx, _changes);
    };
}

emitter.onAddArea.AddListener(delegate (AreaState _area, int _idx) {
    CreateAreaListEntryObject(_area);
});

_refs.deleteAreaButton.onClick.AddListener(delegate {
    HandleRemoveAreaButton(_area);
});

Which in turn calls this:
public async void RemoveArea(AreaState _area) {
    await colyseusClientController.CallService("deleteArea", new {
        areaId = _area.id
    });
}

Thank you, @Unelith this is helpful info!


The Road to GA - BigQuery Updates

These changes help us prepare for a GA release of BigQuery. For more details on the work, please refer to the following PRs which have been aggregated here:
https://github.com/GoogleCloudPlatform/google-cloud-php/pull/604 - Run query and wait for it to complete
https://github.com/GoogleCloudPlatform/google-cloud-php/pull/634 - Add support for etags on bigquery tables and datasets
https://github.com/GoogleCloudPlatform/google-cloud-php/pull/640 - Switch to standard SQL by default
https://github.com/GoogleCloudPlatform/google-cloud-php/pull/642 - Implement waitUntilComplete and block while waiting for query results
https://github.com/GoogleCloudPlatform/google-cloud-php/pull/643 - Generate BigQuery Job ID on client side with optional prefix
/cc @tswast @michaelbausor

@tswast updated based on our discussions in the comments. PTAL when you have a moment, :)


LNDg: CSRF verification failed.

I installed LNDg from the RaspiBlitz Menu v1.10.0 (upgraded from V.1.9.0)
After installation, the login page is accessible, but after entering lndg-admin:password the following error occurs:
Forbidden (403)
CSRF verification failed. Request aborted.
More information is available with DEBUG=True.

I tried after removing the /app-data directory on the HDD, and reinstalling, but without success.
Any idea?

see #4418 - LNDg will be deactoivated for repair in next release.

Might put out a bounty for repair.

Please wait for release v1.11.0 ... if LNDg still does not work on that version please write here.

OK looks like we got lndg fixed as part of v1.11.0 - closing for final release.


updated ms.author

Docs Build status updates of commit 33bf372:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/scale.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Connecting to live share: "Unable to connect to the host" error

Issue Type: Bug
I'm trying to join a live share session

Example URL: https://prod.liveshare.vsengsaas.visualstudio.com/join?08BFB5F55CE921AAB8D94731AAE42211CBCB
Started around 02:30 UTC on 2020-05-29

It indicates "Opening remote session" in the bottom right, and then throws an error message: "Unable to connect to the host. Verify both you and the host are online." The error reliably reproduces with this URL.
Extension version: 1.0.2236
VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:33:47.663Z)
OS version: Darwin x64 19.4.0
Extension logs:
Live Share logs.zip

System Info

Item
Value

CPUs
Intel(R) Xeon(R) W-3235 CPU @ 3.30GHz (24 x 3300)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
48.00GB (1.68GB free)

Process Argv

Screen Reader
no

VM
0%

Hi,
Thanks for reporting this issue. Can it be that the host has already ended the session and that's why you cannot join it? If you ask the host to start a new session, wait for you, and join, will this work?
Another possible reason may be network conditions. Check out Connectivity Troubleshooting for a possible solution.

Can it be that the host has already ended the session and that's why you cannot join it? If you ask the host to start a new session, wait for you, and join, will this work?

That seems unlikely; I was on a call (IRL) with the host and we were actively trying to make this session work (i.e. the host kept the session open while I tried connecting several times).
I'll check connectivity settings later today!

Hi @IlyaBiryukov,
As it turns out, in this case it seems likely the issue was with my host's session. He had a long-running LiveShare session (and URL) that seems to have stayed alive on his end across multiple days, putting his computer to sleep, etc. It seems like, on his end the session thought it was active, but the network connection had (reasonably) disconnected in the meantime. Starting a new session on his end fixed it!
I'll close this out, but let me know if that should be reported as a separate issue (i.e. the host should detect when a long-running session isn't actually active anymore and terminate it and/or prompt to create a new one).

The long running session issue is separate. It may be deemed low priority though, given we have many other more impactful issues. @fubaduba I think we should document this if not documented already.


Edit hdinsight-monitor-use-ambari-api.md

Edit complete

Hi @ClarityQueen, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-diree). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Pagination getUserByUsername

Hi
I use getUserByUsername method, But this method and anothers methods cant pagination posts.
const instagram = await client.getUserByUsername({ username: 'instagram' })
Is there a way to read other pages?

@parsakafi , Use
await client._getPosts({ userId, perPage = 12, nextPageToken })

@k-miras
Returns a 403 for me. I don't have a solution for this but I've observed that:

the query_hash may be outdated. The one I see on IG now is 6305d415e36c0a5f0abb6daba312f2dd
the request requires a x-instagram-gis header

@hirokiosame I've checked client._getPosts({ userId, perPage = 12, nextPageToken }) . Current query_hash is df16f80848b2de5a3ca9495d781f98df and this request works fine with this._getGis()


Extract docs from strict/unpacked constructor args

This fixes #836 by matching the GHC changes in https://phabricator.haskell.org/D4727.
The GHC diff fixes the parse error around strictness annotations by moving the HsDocTy into the HsBangTy (if there is one). This patch correspondingly teaches Haddock to look into HsBangTy for docstrings.

Sorry for my bad repo management lately, I have a new job and an constantly under fire.


Move major service entry & cli into keylime/cmd

This includes verifier, registrar, agent, tenant, etc.
@lukehinds This is a minimum change to paint an idea, provider related code is not changed for it seems they are not maintained atm.

Calling this[1] will fail, the argument number doesn't match, this make me think the platform_* might not be used or at lease not covered in the tests.
https://github.com/keylime/keylime/blob/master/keylime/provider_registrar.py#L34

@kaifeng found an issue with keylime_ca (not looked into it yet)
/usr/local/bin/keylime_ca
Traceback (most recent call last):
  File "/usr/local/bin/keylime_ca", line 6, in <module>
    from keylime.cmd.ca_util import main
ModuleNotFoundError: No module named 'keylime.cmd.ca_util'

@lukehinds Oops, the ca_util was renamed to ca but not changed in the script directive, thanks for verifying, looks like not covered by ci :(

Yep, we should really add the keylime_ca to CI.


L2+ testing todos

After an initial round of testing with L2+ feature, here is a list of todos to consider:

Adding a doc on who, how is invoking cross messages calls. Because there were some assumption/requirements not properly documented yet, all the components needed to ensure correct functioning.
Currently, there is missing a debug tool for cross message calls. It would be really helpful to have a tool, maybe external, that tracks the lifecycle of the cross network messages, i.e. where the message submitted, which subnet is the message now, is the message committed into the postbox and etc... This would help debug cross network message execution.
Checking subnet.circSupply. Not sure if this variable is tracked correctly. This value is deducted by IPCEnvelop.value regardless message type? But only increased (after bootstrap) when message is Transfer.
There should be a debug tool to check if the message execution is successful or failed. If failed, should be possible to show the error.
Consistent way to encode ret bytes. The way that encodes the error is using encodeWithSelector, but for L2+ error is just encode, it's kind of confusing for debugging to tell which decode method to use.
Events will not be filtered due to not triggered from cometbft, need manually inject filters, similar to how activity rollups are done.
Subsequent nonce seems to be off and causing error execution. Need further examination and debugging to see why.

100% agree. I will work on it today.
I think we could use https://thegraph.com/cs/ for this
This looks like a bug. Will fix today.

Because of https://github.com/consensus-shipyard/ipc/issues/1225, the current approach of scanning events emitted from postbox will not work. There will be missing events.

The nonce handling is incorrect. Only the first xnet message will work, subsequent ones will fail.
The scenario is sending TWO cross network message from L1 to L3. This is the first ever L1 topdown message, so for the cross message itself, the nonce is 0.
On L2, topdown finality will have the message applied. It gets committed with appliedNonce increase by 1. Then the committed message in postbox is propagated. Internally it calls commitValidatedCrossMessage and appliedNonce is incremented again by 1.
The overall effect is one xnet message from L1 to L3 will increase the applied nonce by 2.

Potential double nonce increment.
Similar to the above, the appliedNonce is incremented first here. But subsequently, it also call sendReceipt. Internally, it will increment the appliedNonce by 1 as well. This will lead to one message increasing the nonce by 2.


server post not working after validation success

Once validation is successful I was unable to submit my form data through http method,there is no action is happening, should I need to trigger? any help appreciated.
Two screenshots attached for uglifying presentation of my code here

my form data like this
`<form id="responseInput" action="#" @submit.prevent="edit ? updateResponse(response.id) : submit()">

Select a Category
AUTHENTICATION
VALIDATION

Submit
Update
`

I don't think this is related to the validator. In the following code:
this.$validate().then(function (success) { ... });

You are trying to use this.$http in the function, but this is not binded to the currently Vue instance, so it will fail.

Thanks mate, it works with laravel side validation and fetching it's responses.


Add gRPC routes to evm and axelarnet module

To simplify our integrations we add more routes to gRPC, and try to move us away from legacy json. We thought this would help upstream too. Let me know what you think. Thanks

@milapsheth If it helps, I can do the same for all modules? What do you think of this

thanks, makes sense. Can you add an error wrapper similar to the multisig module?
types.RegisterMsgServiceServer(grpc.ServerWithSDKErrors{Server: cfg.MsgServer(), Err: types.ErrMultisig, Logger: am.keeper.Logger}, keeper.NewMsgServer(am.keeper, am.snapshotter, am.staker, am.nexus))

can you run make generate to update generated files?


make compatible with new sklearn versions

just tested with scikit-learn==0.23.2 it throws warnings but it should work fine for inference

but the cleanest way will be to re-train the models with new scikit-learn versions

but this is though to maintain since we'd need to do this for every patch version


Show all of a user's organization memberships on the profile management 'Bio' page

Currently, we only show the first organization membership that was imported from Pure for each user.
What we'd like to do is show all of the user's memberships, and allow the user to push each one to ORCID separately.

Related to #21


Add form validation with preload param #43 #86

@quentinjunior I have updated code with the tests we just done on marchant
cc @nicolaschenet

ok


docs: navigate in property types

Documentation Feedback
I'd like to propose that for "known" property types have a link to it, like in angular.io:

Here we can go to FormControl in NgModel docs.

... bringing the example to here, in MatRadio, by example, we could click in MatRadioChange and it'll point to its class:

Also, not sure it should be better to open another issue, but I'd like to see a button to go to the source code directly as in the angular.io. Sometimes we need to take a look in some implementation and we have to do it "manually".


[CI RUN] apiext: set minimum tls version to 1.3

DO NOT MERGE:
CI Run for #5248

Can we retry?  Seems like an unrelated error
E   AssertionError: query[1]: https://hostcrdmanualcontextcrl.default.svc.cluster.local/: expected error to contain any of 'tls: revoked certificate'; got 'Get "https://hostcrdmanualcontextcrl.default.svc.cluster.local/": write tcp <IP_ADDRESS>:57848-><IP_ADDRESS>:443: write: connection reset by peer' instead

Can we retry? Seems like an unrelated error
E   AssertionError: query[1]: https://hostcrdmanualcontextcrl.default.svc.cluster.local/: expected error to contain any of 'tls: revoked certificate'; got 'Get "https://hostcrdmanualcontextcrl.default.svc.cluster.local/": write tcp <IP_ADDRESS>:57848-><IP_ADDRESS>:443: write: connection reset by peer' instead

Yeah, it is a known flakey test we need to address. Everything looks green.

Merged, so closing CI run PR.


improve configs

improve configs

Codecov Report
Patch coverage has no change and project coverage change: -2.08 :warning:

Comparison is base (18d1cbd) 31.84% compared to head (0b4d228) 29.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
- Coverage   31.84%   29.76%   -2.08%
==========================================
  Files         376      106     -270
  Lines       42868    13630   -29238
  Branches    13690     2479   -11211
==========================================
- Hits        13650     4057    -9593
+ Misses      28968     9448   -19520
+ Partials      250      125     -125

Flag
Coverage Δ

adapter
24.07% <ø> (+0.03%)
:arrow_up:

admin-domain-service
52.40% <ø> (ø)

backoffice-domain-service
50.29% <ø> (ø)

devportal-domain-service
31.52% <ø> (ø)

idp-domain-service
?

runtime-domain-service
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 271 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


#57 Fixed brush view drawing cache not being invalidated resulting in…

… inconsistent saved images.
I was experiencing the same issue where after saving an image with only a sticker, the brush lines added later would not be saved.
After some debugging I noticed that this happens whenever the image was saved without using the brush at all - so saving the image without anything drawn on the brush view canvas.
After some more debugging I noticed that the bitmap we get from the getDrawingCache call in the saveAsFile and saveAsBitmap methods is also missing the brush strokes. This led me to believe that this has something to do with the brush view drawing cache and indeed it had. It turned out that the brush view drawing cache was not invalidated when the setDrawingCacheEnabled(false) method was called.
I figured if I manually destroy the drawing cache, it would be recreated next time the parent cache is generated and that seemed to be the case. After adding the lines included in this PR, the issue was fixed.
I have tested with and without the fix on the demo app (included in the project) and the brush strokes were saved in the last step.
Since this is a very old issue I doubt it will be of use to @ervinod, but it will save trouble for future users of the (very cool) library. So please, @burhanrashid52 if you have a bit of spare time, check if this indeed fixes the issue and maybe create a patch release? :)

Thanks for the detail investigation. I will review the PR and update it soon.


Addition of dependabot.yml file

We need to add dependabot.yml file as it helps us to keep our dependencies up to date. Every day, it checks your dependency files for outdated requirements and opens individual PRs for any it finds.
@pranjay-poddar  please assign me this issue under gssoc'23.

It is already present


Do not escape lines in email notifications

It's very common to add some html formatting to the line.
For example : bold text, colored text, a link ...
I know that it's possible to publish the blade file but, It's better to have this as a default.

I don't know what people are passing into these lines. They could be passing user input. If you don't want to escape it then export it.


Scroll anchoring update

@jpmedley @PaulKinlan
Post on the scroll anchoring flag in Chrome Dev.

@PaulKinlan I need you to be done reviewing before I can start my copy edit.

I believe I left some comments in the gDoc about answering some common questions that developers will have about scrollevents etc that I would like to see in the article.

I won't be able to get demos done until next week to test that, will close the PR for now.


column does not exists (when an alias)

Version
1.14.0
What happened?
the above query does not compile using sqlc generate.

Linux
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

I am also having this issue. :)

Same here but for table alias.
I run the querry in the postgres database  and it works without any issue.
When i try to generate Go code for the query using the sqlc generate command i get the following error:
table alias "upd" does not exist
system: Fedora Linux 37 64-bit
go version: go1.19.4 linux/amd64
postgres version: PostgreSQL 15.1

I am running v1.15.0 and have the same problem

having the same issue,
this query :
CREATE TABLE "coupons" (
  "id" bigserial PRIMARY KEY,
  "couponCode" varchar NOT NULL,
  "valid_till" timestamptz NOT NULL DEFAULT (now()),
  "discount_percentage" int,
  "max_discount_amount" int NOT NULL
);

-- name: CreateCoupon :one
INSERT INTO coupons(
    couponCode,
    discount_percentage,
    max_discount_amount
) VALUES (
    $1, $2, $3
)
RETURNING *;

returns:
sqlc generate failed.

# package db
query.sql:11:5: column "couponcode" does not exist

someone please test the same here: https://play.sqlc.dev/p/d24769ff48755a1d32d5972fcac9e8966d475c3e22c4e508d8bfd9568554ba6c

@tiklup11 your issue is unrelated to this one. Please read the description properly.
As for your issue, if you remove the (") double quotes from your CREATE TABLE query you should get the generation working just fine (https://play.sqlc.dev/p/2031703f27cf4cae5b142d8a33fccd90016c43159d3d451fae2968edc7e54b17)

@milosgajdos sorry mb, thanks for your help.

This is fixed in v1.23.0 by enabling the database-backed query analyzer. We added a test case for this issue so it won’t break in the future.
You can play around with the working example on the playground


dtNavMeshQuery::raycast enters an infinite loop.

Hi,
DetourNavMeshQuery.cpp, dtNavMeshQuery::raycast.
Line 2517, when n == hit->maxPath, status changed, but not return.
In my case, nextRef like A->B->C->A.

same


Added Kinto

I'd recommend that you also go through and make all of your links relative paths so that others can fork and contribute to your repo more easily as it took me a few tries to get the markdown correct and wasn't possible to test against static links.
e.g.
https://github.com/themagicalmammal/howtopopbuntu#graphic-tools
turns into just
#graphic-tools
Also my tool could have gone under programming but it's more of productivity type tool that appeals to all sorts of mac users I'd presume so it didn't really seem to fit any where else.

Can you explain a bit more?


Don't pollute the source lib folder during ivy retrieval in test

The IvyRetrieveBuildFileTest triggers a Ant project build during the test case and issues a ivy:retrieve through the build file. The retrieve ends up putting these test files (some of which are dummy files) into the ${lib.dir} of the project source and causes issues like the one noted in https://github.com/apache/ant-ivy/pull/36

I found out that JUnit tests polute run.classpath by placing an empty jar in /lib, which breaks eg javadoc. Any ideas which test may do that?

The commit in this PR fixes that issue to use a test build specific directory to retrieve these test specific artifacts.

Thanks, could this PR be merged? Then I'll clean up #36

:+1:


Put a cap on window names

Description
It turns out qutebrowser will place an entire data: URL in _NET_WM_NAME, up to at least 389K characters including newlines and possibly binary characters.
Clamping window titles to the first line, and to 2K chars because defaultShrinker is quadratic in the title length.
Closes #809
Checklist

[x] I've read CONTRIBUTING.md

[x] I've considered how to best test these changes (property, unit,
manually, ...) and concluded: tested in my harness

[ ] I updated the CHANGES.md file — shouldn't be necessary

[19 15:36:26] <L29Ah> hmm xmonad hangs for a few secs even with this patch
[19 15:36:50] <L29Ah> but that's good enough i guess
[19 15:44:27] <geekosaur> seemed pretty quick here
[19 15:45:21] <L29Ah> i7-8550U laptop here
[19 15:45:35] <geekosaur> mine is an older i5
[19 15:45:50] <geekosaur> and I'm running it in a xephyr in a test harness
[19 15:47:57] <L29Ah> i guess that might be due to the fact i have several such tabs in my qutebrowser
[19 15:48:09] <L29Ah> and it blinks them
[19 16:06:42] <geekosaur> what I'm actually seeing is qutebrowser hangs for a second or two. that's not under xmonad's control; drawing is solely between the client and the X server, xmonad can't even know it's happening without e.g. taking a couple of screenshots and comparing them

Probably. It would also partially avoid problems like splitting ligatures (flags, etc.). But I feel like that's beyond me.


Quectel GNSS: read ephemeris offline

The offline ephemeris is not parsed or used from the quectel GNSS module, so laikad needs internet to get a location fix when using the quectel GNSS. This should be fixed so laikad works online and offline with the quectel GNSS.

https://github.com/commaai/openpilot/pull/25931


Add feedback form to portfolio

Got the form and a set of radio buttons working from the week 2 walkthrough - will try to get the stuff from the other walkthroughs done tomorrow

Need some help getting comments to display from a Datastore database - storing functionality is complete, but I couldn't get displaying the comments to work.
Continuously got this error:
com.google.cloud.datastore.DatastoreException: No such property comment
which pointed to line 35 of CommentDisplayServlet.java
Any code review would be appreciated.
Also implemented the two changes you requested - not sure how to unblock merging afterwards.

Somehow fixed the "No such property comment" error, but still unsure of how to get the comments to display using JavaScript.

Glad you got it at least partially working! Before I take a closer look I'm going to ask you to split this PR up first. Move the Data store related commits to a new branch and create a new PR from that branch. It might be a little tricky, but there's plenty of resources online to figure out how to do it (make sure you make a backup branch too before doing this just in case!)
Similar to how doing multiple small commits is helpful to understand what each set of changes is really doing, using a different PR for each new feature, bug fix, etc. is a good way to compartmentalize things. It also helps with code reviews since it limits the scope of the things your reviewer should look over.


Integers in attribute arguments are always passed as Fields

Aim
#[foo(32)]
comptime fn foo(_f: FunctionDefinition, i: u32) {
    println(std::meta::type_of(i));
}

fn main() {}

Expected Behavior
u32 to be printed
Bug
Field is printed, and if we use i in an operation with a u32, e.g. i == x we'll get an error that we can't perform an equality on a Field and a u32.
To Reproduce

Workaround
None
Workaround Description
No response
Additional Context
No response
Project Impact
None
Blocker Context
No response
Nargo Version
No response
NoirJS Version
No response
Proving Backend Tooling & Version
No response
Would you like to submit a PR for this Issue?
None
Support Needs
No response

I'm not sure what's the best way to solve this.
Right now we check that the types unify, but the value we pass doesn't change. So if we pass a Value::Field it remains a Field.
We could cast that value to the target type, though that would only work for primitive types. That said, you can't pass an array in an attribute because right now it doesn't parse... but I guess we'd eventually want to support that.

@asterite I'm not sure on a good way either. I suppose we'd have to pass down an expected type when creating the attribute arguments to begin with.


Poetry doesn't need author email.

I have the following line in my pyproject.toml.
[tool.poetry]
authors = ["myname"]

This extension will show
Pattern that matches Name <email> like 'King Arthur' or 'Miss Islington<EMAIL_ADDRESS>
and
"myname" does not match "^(?:\S+?\s)+?(?:<(?:[a-z\d!#$%&'*+/=?^_`{|}~-]+(?:\.[a-z\d!#$%&'*+/=?^_`{|}~-]+)*|"(?:[\x01-\x08\x0b\x0c\x0e-\x1f\x21\x23-\x5b\x5d-\x7f]|\\[\x01-\x09\x0b\x0c\x0e-\x7f])*")@(?:(?:[a-z\d](?:[a-z\d-]*[a-z\d])?\.)+[a-z\d](?:[a-z\d-]*[a-z\d])?|\[(?:(?:25[0-5]|2[0-4][\d]|[01]?[\d][\d]?)\.){3}(?:25[0-5]|2[0-4][\d]|[01]?[\d][\d]?|[a-z\d-]*[a-z\d]:(?:[\x01-\x08\x0b\x0c\x0e-\x1f\x21-\x5a\x53-\x7f]|\\[\x01-\x09\x0b\x0c\x0e-\x7f])+)\])>)?$"

although poetry doesn't require an author email since v0.9.0: python-poetry/poetry@5b14bd10e078dd8a8aa03732ee34ef9e65646021

Fixed upstream.

Thank you very much!


fix unescaped em tags

Fixed issue https://github.com/nyphilarchive/PerformanceHistory/issues/9 of unescaped em tags in 4 lines of complete.xml

Due to bad movement parsing. Fixed in source data in 7e0a18a.


Search Statistics Across Assets in Multiple Collections Fails

I have two collections: ["opera-loss", "nlcd"] that I want to mosaic assets from and run some statistics via Titiler.
I register a search via POST /searches/register
{
        "collections": ["opera-loss", "nlcd"],
        "filter": {
            "op": "OR",
            "args": [
                {
                    "op": "AND",
                    "args": [
                        {
                            "op": "eq",
                            "args": [{"property": "collection"}, "opera-loss"]
                        },
                        {"op": "eq", "args": [{"property": "datetime"}, "2024-11-11"]}
                    ]
                },
                {
                    "op": "AND",
                    "args": [
                        {"op": "eq", "args": [{"property": "collection"}, "nlcd"]},
                        {"op": "eq", "args": [{"property": "datetime"}, "2021-01-01"]}
                    ]
                }
            ]
        }
    }

And validate the assets are found via GET /searches/<SEARCHID>/-98.5795,39.8283/assets:
[
  {
    "id": "-230400_1843200__2024-11-11",
    "bbox": [
      -98.73314824304305,
      39.580039124827444,
      -97.8050728162776,
      40.28159660136621
    ],
    "assets": {
      "opera_loss": {
        "href": "s3://***/opera_weekly/-230400_1843200/2024-11-11/-230400_1843200__2024-11-11.tif",
        "type": "image/tiff; application=geotiff; profile=cloud-optimized",
        "roles": [
          "data"
        ],
        "title": "opera_loss",
        "proj:epsg": 5070,
        "description": "",
        "raster:bands": [
          {
            "nodata": 255,
            "sampling": "area",
            "data_type": "int8",
            "spatial_resolution": 30
          }
        ]
      }
    },
    "collection": "opera-loss"
  },
  {
    "id": "-230400_1843200__2021",
    "bbox": [
      -98.73314824304305,
      39.580039124827444,
      -97.8050728162776,
      40.28159660136621
    ],
    "assets": {
      "nlcd": {
        "href": "s3://***/cogs/-230400_1843200/2021/nlcd.tif",
        "type": "image/tiff; application=geotiff; profile=cloud-optimized",
        "roles": [
          "data",
          "labels",
          "labels-raster"
        ],
        "title": "NLCD Land Cover",
        "proj:epsg": 5070,
        "description": "",
        "raster:bands": [
          {
            "nodata": 0,
            "sampling": "area",
            "data_type": "uint8",
            "spatial_resolution": 30
          }
        ]
      },
     "collection": "nlcd"
  }
]

But when attempting to run POST /searches/<SEARCHID>/statistics with params:
assets=[ "opera_loss", "nlcd" ]
asset_as_band=true
expression="opera_loss + nlcd"

I get the error:
{
  "detail": "Invalid band/asset name 'nlcd'"
}

Changing to expression=opera_loss I get:
{
  "detail": "Could not find any valid assets in 'opera_loss' expression. Assets are: ['nlcd']"
}

And expression=nlcd I get:
{
  "detail": "Could not find any valid assets in 'nlcd' expression. Assets are: ['opera_loss']"
}

Is this a misguided use of the /searches endpoint, or should this sort of query across different collection-assets be possible?
I can work around this by adding the appropriate assets from the nlcd collection to the opera-loss collection or creating a new collection with the assets from both and registering a single-collection search + statistics, but it's not as elegant as being able to do cross-collection mosaicing.
PgSTAC version 0.8.5
Titiler version 0.1.0
Thanks for any insights here!

Hi @bransonf :wave:! Unfortunately it is not possible to use an expression that combines assets from items in different collections.
titiler-pgstac attempts to create an array out of every STAC item in the search results, and it fails when it finds an item that does not have all of the requested assets.
In the case you have presented half of the items are missing nlcd and other half are missing opera_loss, so the query is doomed :skull_and_crossbones:.
This is a feature that I would like to support someday, though! Keep an eye on https://github.com/stac-utils/titiler-pgstac/discussions/189 for further discussion.

You might be able to do this be it will involve customization of the backend methods
https://github.com/stac-utils/titiler-pgstac/blob/d2129699a989a81230b3988266ef540668c74b97/titiler/pgstac/mosaic.py#L322-L357
The idea would be to avoid passing the expression to the reader method https://github.com/stac-utils/titiler-pgstac/blob/main/titiler/pgstac/mosaic.py#L351-L355 but use them to return image for assets and then apply the expression on the result, It's not guarantee that it will work but that's at least a track to explore


add offset to reported build

coveralls is not supporting merging reports from different services.
to achieve it, we need to provide offset option that will adjust build number gathered from CI env to make it equal to build number from other CI.

Does it have to be the build number or can we just set the commit / PR as build number?

PR number is not a way to go, as there could be builds for different commits inside same PR
commit SHA is also a possibility, yet we need to check they are all available for supported CIs.
eg Travis for push-builds doesn't take the commit as-is, but apply it on top of current target branch (by rebase, patch, whatever), then we need to be sure we will get original commit SHA instead of one after rebase

closing as abandoned
please, feel free to raise new issue or even a PR if you find this problem struggling you.


Reading Shapefile

❓ Questions & Help

Hello,
I have spatial data as polylines and polygons, is there a best practice to load GIS data into the module?
Thanks

There is no best practice. Use any tool you like to convert your data into PyTorch tensors :)


v4.0.0

Closes #54

Codecov Report

Merging #85 (3da3ff2) into master (b51cfb8) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   96.43%   96.40%   -0.04%
==========================================
  Files           4        4
  Lines         421      417       -4
  Branches       59       63       +4
==========================================
- Hits          406      402       -4
  Misses          4        4
  Partials       11       11

Impacted Files
Coverage Δ

src/lineage/__init__.py
94.58% <100.00%> (+0.11%)
:arrow_up:

src/lineage/individual.py
100.00% <100.00%> (ø)

src/lineage/resources.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b51cfb8...3da3ff2. Read the comment docs.


Failed to find VClient018 interface.

I selected Manual Map and it gave this error.

And the game is over.
(Sorry im use translate)

What injector do you use?

Inject when you're in menu

ExtremeInjector

Error comes in main menu

Use xenox injector

Use xenox injector

or csghost


Lw updated rlos

RLOS Pro and ArcMap updates to the models

@topowright @dhagens Something go wrong here?
Dan posted a some issues, and I'm seeing RLOS gone from the 10.3 toolbox.

I'm seeing some of the stuff left over from testing in the dialog in Pro:

And in the model:


Paloma Bug: panic recovered in PrepareProposal Server Panic.  invalid memory address or nil pointer dereference

What is happening?

Section description
Provide as much context as you can. Give as much context as you can to make it easier for the developers to figure what is happening.

{"_msg":"panic recovered in PrepareProposal","height":55,"level":"error","module":"server","panic":"runtime error: invalid memory address or nil pointer dereference","time":"2023-05-02T21:35:20.932410068Z","ts":"2023-05-02T21:36:20.567421864Z"}
PrepareProposal is in BaseApp
https://github.com/palomachain/paloma/blob/master/app/app.go#L300
Paloma and pigeon versions and logs

Section description
Write down paloma version.
Write down pigeon version.
Copy and paste pigeon config file as well as relevant ENV variables.

Master Paloma and Pigeon
How to reproduce?

Section description
Please write detailed steps of what you were doing for this bug to appear.

Paloma running in master with 3-node network.
What is the expected behaviour?

Section description
If you know, please write down what is the expected behaviour. If you don't know, that's ok. We can have a discussion in comments.

No panic in PreparProposal

resolved with https://github.com/palomachain/paloma/pull/824