Plan for tauri/playwright e2e tests

From https://github.com/KittyCAD/modeling-app/issues/833#issuecomment-1784873072
While we're still trying to get tauri-driver to behave on Windows, we can try to leverage the Linux one to test things up to #625. Web-only playwright tests could cover from there. It's a much more robust platform that is being used for other repos here.
Three parallel threads:
### Linux tauri e2e tests
- [ ] #684
- [ ] #968
- [ ] https://github.com/KittyCAD/modeling-app/issues/1182
- [ ] https://github.com/KittyCAD/modeling-app/issues/1190
- [x] Open, check filesystem related settings, close (done in #1190)

### Windows tauri e2e tests
- [x] Get msedgedriver and tauri-driver to talk to each other on Windows
- [ ] https://github.com/KittyCAD/modeling-app/issues/2393
- [ ] https://github.com/KittyCAD/modeling-app/issues/2547
- [ ] https://github.com/KittyCAD/modeling-app/issues/2658

### Web playwright e2e tests
- [ ] https://github.com/KittyCAD/modeling-app/issues/1038
- [x] Validate that the stream picks up, and that valid codes gets it to render the expected view (done at https://github.com/KittyCAD/modeling-app/pull/1167)
- [x] Point-and-click code gen and stream snapshot validation (done at https://github.com/KittyCAD/modeling-app/pull/1136)
- [ ] https://github.com/KittyCAD/modeling-app/pull/1125
- [ ] https://github.com/KittyCAD/modeling-app/pull/1139
- [x] Cover web Auth/Signin (low-prio if we get tauri)
- [ ] https://github.com/KittyCAD/modeling-app/issues/1112
- [ ] https://github.com/KittyCAD/modeling-app/issues/1116
- [ ] https://github.com/KittyCAD/modeling-app/issues/1111

These all looked closed to me 🏆

Thanks for closing @Irev-Dev !


added HRP address validation to osmosis

Hello,
This change is an attempt to solve the issue https://github.com/terra-money/bridge-web-app/issues/106. I added an additional validation check for the human readable part of the address when sending to osmosis. Hopefully an additional check to avoid the mistake of people sending to their cosmos address instead of osmosis.
Let know about any feedback.

Thanks, fixed by #108


How to specify OTP token when calling "gcli auth create"? (MFA)

Hello!
Thank you for this great tool!
However, is there a way to specify OTP token when calling gcli auth create? I'm using two-factor authentication on my GitHub account.
Here's the related documentation from GitHub:
Using the OAuth Authorizations API with two-factor authentication
Thanks!

Hi Slava,
Thanks for your interest in this gem. The github_cli hasn't been released in years and I have just recently finished rewriting it. Unfortunately, 2FA isn't supported in this gem as of yet. I'd be really happy to accept PR implementing it. You can use Two Factor as a starting point. Thanks!

@piotrmurach thank you for your effort. As much as I would like to help, I'm not familiar with Ruby. I hope someone more suitable for this stack would be able to lend a hand here.


Use ArgumentResolver instead of ControllerResolver

This lets us use the standard ControllerResolver and provides
more flexibility by letting users register additional ArgumentResolvers
which could be shared by FrameworkExtra bundle etc.
This obviously needs symfony/symfony#14971 to be merged first.
Additional stuff to add.
Use the psr-7 bridge for auto converting requests.

I think i adressed the different issues :)


micro_ros_setup uses old driver of I2C. Important function missing.

I2C Function missing (i2c_master_write_read_device)

Hardware description: ESP32
RTOS: FreeRTOS
Installation type: micro_ros_setup
Version or commit hash: foxy

Steps to reproduce the issue
Following the steps described in the official documentation lead to this part:
ros2 run micro_ros_setup create_firmware_ws.sh freertos esp32
which creates the folder firmware in microros_ws which contains esp-idf and its components. The folder driver contains the files i2c.c and i2c.h.
Before implementing micro-ros, I had developed software for the ESP32 using the latest stable version of esp-idf (4.4.2).
Expected behavior vs Actual behavior
When porting my code to use micro-ros, it turns out that one of the basic functions of I2C i2c_master_write_read_device is not available in the esp-idf version used by micro_ros_setup. I checked the file comments and the i2c.c file installed by micro_ros_setup has a date of 2019 whereas the current one is from 2021. Needless to say that my code doesn't work when I try to use micro-ros.
Solutions I tried
I tried overwriting the old driver files with the new files but because of its dependencies, it affected other files that suddenly couldn't find certain macros. I went on to replace every file that had an issue with a "missing definition" or function. It's a rabbit hole with too many dependencies and replacing all possible files didn't solve the issue either.
Question
Before I attempt to rewrite my code with a legacy version of i2c.c, I'd like to ask if there is a simple way to update the I2C driver that micro_ros_setup uses. If you know of any other solution, I'm open to hearing (reading) it.
Thanks everyone for your help.
Note: I know that the recommended method is to use this component. Since I am using Foxy, I've had problems making it work as described here at the end and here. So for now, I am using micro_ros_setup, at least until I update the whole system to Humble and hopefully, that allows me to use the component. For now, that is unfortunately not possible as the whole team uses Foxy.

I guess that you can modify the IDF version here: https://github.com/micro-ROS/micro_ros_setup/blob/67a7cdb5fdea4bf09e396680ebf2b6d72397746e/config/freertos/esp32/create.sh#L6
As you mention, micro_ros_setup is just a tool for creating boilerplate projects, if you need the newest version, move to the micro-ROS module for ESP-IDF.
Could you provide some more details about your project?

In any case I'm closing since this is not related to micro-ROS

I guess that you can modify the IDF version here:
https://github.com/micro-ROS/micro_ros_setup/blob/67a7cdb5fdea4bf09e396680ebf2b6d72397746e/config/freertos/esp32/create.sh#L6

Hi, thank you for your suggestion. Unfortunately, when I update the version in create.sh file and then run
ros2 run micro_ros_setup create_firmware_ws.sh freertos esp32
Followed by
ros2 run micro_ros_setup configure_firmware.sh sensor_data_publisher --transport serial
and ros2 run micro_ros_setup build_firmware.sh
I get this error :
microros_ws/firmware/toolchain/esp-idf/export.sh: line 16: IDF_EXPORT_QUIET: unbound variable

As you mention, micro_ros_setup is just a tool for creating boilerplate projects, if you need the newest version, move to the micro-ROS module for ESP-IDF.

If I understood correctly from this, my problem with the micro-ROS module lies in using Foxy instead of Humble. So at the moment, I cannot use it until we update to Humble.

Could you provide some more details about your project?

It's a mobile robot. We want to use the ESP32 to handle multiple distance sensors through I2C, an IMU, lights, motors and an RC receiver. Ideally, multitasking should be implemented with the help of FreeRTOS and the robot communicates to a laptop running ROS2-Foxy.

Let's move to the issue with Foxy and ESP-IDF. As far as I know, Foxy shall be working properly with ESP-IDF, I'll check.


add missing semi-colon

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change
Added a missing semi-colon on line 3 of go.less

Alternate Designs
I considered leaving it without a semi-colon, but I felt ugly after, and reassessed - I ended up going with the decision to add the missing semi-colon.

Benefits
Consistency.

Possible Drawbacks
none that I'm aware of maybe an extra byte added to package size?

Applicable Issues
none.

Consistency.

Always a good reason. 👍  Thanks.


Hover/focus not being applied to dropdown list

Expected Behavior
I've downloaded and installed v1.3.0.
When I try the dropdown list selector in navbar, the hover/focus is not being applied so the background color on the list item is not changed.  I see this is working on the live demo though.
Steps to Reproduce
Downloaded v1.3.0 zip
$ npm install
$ npm start
select components dropdown list
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

Device: Macbook Air
Operating System: Mac OSX / 10.14
Browser and Version: Chrome 70.0.3538.77

Strange, it's started working again.  I'll close this and re-open it again if it reoccurs.


There is an offset in the pickup position after zooming in and out, as is the case with the official website demo

放大缩小图表后，表格定位位置不准，右键悬浮窗位置不准

There is an offset in the pickup position after zooming in and out, as is the case with the official website demo

@yuanY2 好的，稍后我们会对缩放引起的BUG进行集中处理

Cannot use 'in' operator to search for 'bg' in 黑龙江            点击表格就报这个错

@yuanY2 我们已经在最新的release版本中新增了缩放功能，可以尝试使用内置缩放功能对表格进行缩放，这种做法不会引起鼠标点击位置的错误


Figure out the float or np.ndarray signatures

Related #57

https://stackoverflow.com/questions/35673895/type-hinting-annotation-pep-484-for-numpy-ndarray

Maybe ufuncs?

https://numpy.org/doc/stable/user/basics.ufuncs.html#ufuncs-basics
https://numpy.org/doc/stable/reference/ufuncs.html


Changed Kustomize version to latest to get rid of Test errors on Mac …

Fixed an error for Mac OS with M1. Therefor I changed the version of Kustomize to the newest (4.5.7)

so the unit tests break, because make create-install-files makes the git state dirty. This is because newer versions of kustomize rely on a version of go-yaml that incurred a breaking change.
https://github.com/kubernetes-sigs/kustomize/issues/947
There has been a request to fork the project but the fix is still not in kustomize: https://github.com/kubernetes-sigs/yaml/issues/72
The thing is that newer versions of kustomize are MUCH faster. If we use it, this will speed up local development plus end to end tests. To this end, I vote to merge this PR after we validate that the new YAML files work.
@stefanvo78, the only change needed in this PR is to run make create-install-files at the root folder. Thank you!

Closing as change was included in #419


Add directory copy for docker flexible staging

The pkg might be weird, but otherwise trying to enable us to copy directories without commons-io. Only enabled the change on the flexible staging step

@patflynn @meltsufin @etanshaul

:ship:


Setup detects toolkit download and extraction

Resolves #701

Coverage remained the same at 76.791% when pulling 64372de126d573fb1d1c71442f8b42c0c0b4a9ba on toolkit-no-redownload-for-setup into 4cdd97c8ccc7c18f578b958a2268fbcf5c2a368a on master.


Crash - Statement.swift line 211

After including SQLite in my project, I saw this crash:
SQLite/Statement.swift:211: Fatal error: 'try!' expression unexpectedly raised an error: disk I/O error (code: 10)
It looks like it's coming from here:
extension FailableIterator {
public func next() -> Element? {
// swiftlint:disable:next force_try
try! failableNext()
}
}
Issue 1028 mentions a fix was merged last year, but it looks like the code is still the same. Would you please check on it?
Thanks very much!

Please see #1075. It shows how you need to catch the error. Also, feel free to open a Pull Request to update the documentation to make it clearer.


hessian sparsity for urchin example

Rewrite using Finite differences to see if we recover the true param values.

finite differencing sometimes leads to logdet calls that produce nonsensical results (e.g. log(-1)). Try an example with fewer random effects (smaller pop size) and see if it works.

Compare Hessian in R to the one from FiniteDiff and the AD derived Hessian, as a further sanity check


How to know what exactly happens by Relay-IR and llvm code ?

I'm using TVM 0.6 on CPU host. When I wrote a simple tensor computation and build it with TVM, I get a tvm schedule object. Then I can get its Realy IR representation and llvm source code.
My problem is the llvm code are too confusing to read (they can easily be over thousands of lines).
The relay IR is simple though, it seems unreal to me. For example, when I use vectorize method, sometimes I get 1024-bit instruction, which doesn't exit on any CPU arch.
Thus I want to know how to know what exactly happens when TVM models run on CPU?

Please open a new thread in https://discuss.tvm.ai/


Preview Audio files for training

Hi @keunwoochoi ! Great work on this repo! Seriously amazing.
I was just wondering how it is possible to get the short preview clips for the tracks in the MSD. I know that, in one of your repos, you stated that there are currently only 2 options: crawling the web or "crawling your colleagues"
But I just wanted to ask, do you know some place where I can get them, so that I can retrain the network on my own. If I am not mistaken, I need the preview clips to retrain the network, right? (The 7Digital API recommended by MSD to get the preview audio files is not working, so I do no know how to "scrape" the preview files from the internet? How were you able to get access to the preview audio files?
Thanks!

Hi, could you please email me? Thanks.

Hi @keunwoochoi , thanks for your reply. Is your email<EMAIL_ADDRESS>

yes. or without the suffix.

@keunwoochoi , as per your suggestion, I have sent you an email. Thanks for taking the time to help!


Fix issues identified by automated audit

This pull request was created by a tool: Cake.AddinDiscoverer version 3.14.0
Resolves #85

This has been taken care of in another PR.


Rendering to textures

It would be good to add support for rendering to textures, e.g. to improve performance when scrolling through complex scenes, or to apply post-processing effects to a rendered image.

@QuantumBadger any progress on this one?

Not yet, but it's on my to-do list when I get some free time!


Compiling draco with newer versions of emscripten leads to various errors (memory out of bounds)

Connected to https://github.com/google/neuroglancer/pull/317 but didn't want to clog up that discussion
trzeci/emscripten is currently deprecated in favor of emscripten/emsdk but I tried to find the latest version of trzeci/emscripten that I could get to work since I don't have a good understanding of WASI and also how you generated the imports object. I added empty stub functions for various wasi calls which silenced a lot of errors but eventually I ran into memory out of bounds.
The current code currently only compiles, at least on my end, using build.sh by tagging trzeci/emscripten to sdk-tag-1.38.30-64bit. It will compile up to trzeci/emscripten:sdk-tag-1.38.45-64bit by changing WebAssembly.Table initial and maximum from 368 to 374.
sdk-tag-1.38.45 is the first version that gives me a memory out of bounds error as well as an error code 1 from neuroglancer_draco_decode
Also, if you decide to try various versions of trzeci/emscripten, you will run into issues using the upstream and fastcomp versions since there was a pwd change that wasn't fixed until 1.39.2. This causes /emsdk/entrypoint: ./build_wasm.sh: not found
Figured you might have more luck than me, especially since I'm not sure how you generated/chose values for the imports object.

This is related to the wasm issues described here: https://github.com/google/neuroglancer/pull/318
The existing content in index.ts was derived from the js file auto-generated by emscripten, but with unnecessary code removed in order to significantly reduce the size.  However, it does seem that resulted in some constants that may be dependent on the compiler version and code being compiled being hard coded.
I will look into how to fix this to compile with the newer toolchain and avoid hard coding constants.

STANDALONE_WASM was added in 1.38.46 which seems like it should be relevant.


Scoreboard for streamers

Sometimes you want to display your wins/loses/total in a scoreboard that is yours alone. It would be nice if you could just click on a button and check what the score is from a certain moment.
Requirements:

hide/show functionality
persistent across page reloads
position has to be changeable (drag it, perhaps outside the current window/screen? To ask someone who actually does this :D )
a way to reset the counters
take into account if games are rated or not?

No one seems to be interested in this. Marking it dubious.


Feat: replace yup with joi for cleaner validation

Motivation
Replace yup with joi since joi provide better validation options out of the box
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
The existing test should be sufficient

It seems one test is failing.
Otherwise Joi seems nice. Probably more powerful and widely used than Yup so I'm not against switching
Gatsby uses it internally to validate its configuration

joi has different wording for the error so the snapshot test are failing.

Then you can update the snapshots so that I can check the new error messages are decent :p and merge the PR

@anshulrgoyal should we merge this before your other pr? can you resolve conflicts?

Yes I can

@slorber fixed merge conflict

thanks :)


[Bug] Access Denied When Exporting To PDF (Self-Hosted Docker)

Is there an existing issue for this?

[X] Yes, I have searched the existing issues and none of them match my problem.

Product Variant
Self-Hosted
Current Behavior
Getting the below error message when clicking the Export To PDF button:
I am not using any proxy or other middleware software
<Error>
  AccessDenied
  <Message>Access Denied.</Message>
  <Key>resumes/clpiiwkmu0003h69ugw0fj139.pdf</Key>
  <BucketName>clpiivuar0000h69ucr044fhi</BucketName>
  <Resource>
    /clpiivuar0000h69ucr044fhi/resumes/clpiiwkmu0003h69ugw0fj139.pdf
  </Resource>
  <RequestId>179BD4E8929888A2</RequestId>
  <HostId>
    7987905dee74cdeb212432486a178e511309594cee7cb75f892cd53e35f09ea4
  </HostId>
</Error>

Expected Behavior
A PDF file is generated and downloaded
Steps To Reproduce
No response
What browsers are you seeing the problem on?
Firefox
What template are you using?
Nosepass
Anything else?
Docker File:
In this line, PUBLIC_URL: http://home.lan:3000 resolves to the IP of my docker host
version: "3.8"
services:
  # Database (Postgres)
  postgres:
    image: postgres:15-alpine
    restart: unless-stopped
    volumes:
      - postgres_data:/var/lib/postgresql/data
    environment:
      POSTGRES_DB: postgres
      POSTGRES_USER: postgres
      POSTGRES_PASSWORD: postgres
    healthcheck:
      test: ["CMD-SHELL", "pg_isready -U postgres -d postgres"]
      interval: 10s
      timeout: 5s
      retries: 5

  # Storage (for image uploads)
  minio:
    image: minio/minio
    restart: unless-stopped
    command: server /data --address :9001
    ports:
      - 9001:9001
    volumes:
      - minio_data:/data
    environment:
      MINIO_ROOT_USER: minioadmin
      MINIO_ROOT_PASSWORD: minioadmin

  # Chrome Browser (for printing and previews)
  chrome:
    image: browserless/chrome:1.61.0-puppeteer-21.4.1
    restart: unless-stopped
    environment:
      TOKEN: chrome_token
      EXIT_ON_HEALTH_FAILURE: true
      PRE_REQUEST_HEALTH_CHECK: true

  # Redis (for cache & server session management)
  redis:
    image: redis:alpine
    restart: unless-stopped
    command: redis-server --requirepass password

  app:
    image: amruthpillai/reactive-resume:latest
    restart: unless-stopped
    ports:
      - 3000:3000
    depends_on:
      - postgres
      - minio
      - redis
      - chrome
    environment:
      # -- Environment Variables --
      PORT: 3000
      NODE_ENV: production

      # -- URLs --
      PUBLIC_URL: http://home.lan:3000
      STORAGE_URL: http://home.lan:9001

      # -- Printer (Chrome) --
      CHROME_TOKEN: chrome_token
      CHROME_URL: ws://chrome:3000

      # -- Database (Postgres) --
      DATABASE_URL: postgresql://postgres:postgres@postgres:5432/postgres

      # -- Auth --
      ACCESS_TOKEN_SECRET: access_token_secret
      REFRESH_TOKEN_SECRET: refresh_token_secret

      # -- Storage (Minio) --
      STORAGE_ENDPOINT: minio
      STORAGE_PORT: 9001
      STORAGE_REGION: us-east-1 # Optional
      STORAGE_BUCKET: default
      STORAGE_ACCESS_KEY: minioadmin
      STORAGE_SECRET_KEY: minioadmin
      STORAGE_USE_SSL: false

      # -- Cache (Redis) --
      REDIS_URL: redis://default:password@redis:6379
      DISABLE_EMAIL_AUTH: false

volumes:
  minio_data:
  postgres_data:

@My-Random-Thoughts this is a simple fix. Change your Storage URL from http://home.lan:9001 to http://home.lan:9001/default. The URL should include the bucket name if you are using Minio.

Thank you @AmruthPillai , that fixed it.

I encounter the same. this should be good-first-issued label


add dask.array.compress

Requested  https://groups.google.com/a/continuum.io/d/msg/blaze-dev/Xkj1r2MrGHE/1D7x6VCCCwAJ by @alimanfoo

Merging soon if no comments


Add Issues to ISSUES.md

Issue(s):

Add hover effect to reset button
Map event listeners to trigger state change

Repository:
hardeepnarang10/keyboard-pro
Tech stack:
Issue #1: CSS
Issue #2: JavaScript

[x] is it a beginner-friendly issue?
Yes.

Thanks @hardeepnarang10 for the PR.


Autolink urls

There is a way that we can use autolink like prism plugin? It would be nice.

This is out of scope for a syntax highlighter. However, highlight.js would play nice with any custom markup, so you can use any other solution to enrich your code with links and then apply highlighting on top of that.


Unchecked Return Values

Description
Multiple functions return a value which is not checked or used in the calling function. e.g.:
• withdrawFrom in _withdrawBorrowAmount.
• transfer and withdraw in _transferCollateral.
• deposit in _repay.
• transferFrom in _depositCollateralFromSavingsAccount and _repayFromSavingsAccount.
Integrations Checklist

[ ]  Have any function signatures changed? If yes, outline below.
[ ]  Have any features changed or been added? If yes, outline below.
[ ]  Have any events changed or been added? If yes, outline below.
[ ]  Has all documentation been updated?

Changelog

Removing unwanted returns from the function transferFrom from the SavingsAccount.sol

Event Signature Changes
Function Signature Changes
Features
Events

Codecov Report

Merging #225 (d1da67f) into master (6aaf59a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   15.95%   15.96%
=======================================
  Files          16       16
  Lines        1736     1735    -1
  Branches      321      321
=======================================
  Hits          277      277
+ Misses       1459     1458    -1

Impacted Files
Coverage Δ

contracts/SavingsAccount/SavingsAccount.sol
9.84% <ø> (+0.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aaf59a...d1da67f. Read the comment docs.


Use string literal instead of function name pointer for xstate entry

Reproduced locally by building a production webpack build and running it with a local python server at port 3055 in place of a webpack dev server for the wallet. This change fixed the issue we're seeing on production.
@andrewgordstewart said there are other usages of <function>.name, we should change those too.

To be honest, I think we'd be better off just turning minification off. It gets us negligible performance benefits at the cost of your above points and hobbyist dev debugging in their browser (which we want to encourage, not prohibit).

To be honest, I think we'd be better off just turning minification off. It gets us negligible performance benefits at the cost of your above points and preventing hobbyist devs from debugging in their browser (which we want to encourage, not prohibit).

I'm on board.

Closing in favor of https://github.com/statechannels/monorepo/pull/1699


implements sys.privileges system table

table will only be available if enterprise.licence is enabled and is only accessible by a superuser

retest this please


Add dummy switch to Phoscon-GW

Hi ebaauw,
I've connected my deconz gateway and in the home app there's now a accessory 'Phoscon-GW'. Can you maybe expose a dummy Stateless Programmable Switch service on this accessory so I can unfavourite it? Just like you did for homebridge-p1: https://github.com/ebaauw/homebridge-p1/releases/tag/v1.1.3
Thanks in advance,
Wendel

Already have; set linkButton to enable it.

Amazing, thanks! Wasn't clear to me because the description only mentioned the hue link button. Thanks anyway!

Yeah, I changed that when Apple broke the favourite setting for unsupported accessories.


Add fixtures

How do user provide fixtures ?
They should just implement an interface with two single methods that deal with domain objects.

setup(Vertx vertx)
tearDown(Vertx vertx)

User is responsible for creating and saving their domain objects, (since we can't do it for them, because of cascade relationships etc.)
In conf.json, the user should specify wich fixtures are run.
"fixtures" : [
    "com.mycompany.fixtures.fixtures.MyUsers",
    "com.mycompany.fixtures.fixtures.MyAccessRoles"
]

Then in VertxMVC.bootstrap() scan for fixtures through vertx.config() and execute them.

The fixture interface could have just 2 methods :

startUp
tearDown

We have to provide a Vertx instance, so that user can access the vertx, and the eventBus eventually.
Also, keep in mind that some async stuff could be done by the end-user in fixtures, so we should return a Future.
public Future<Void> startUp(Vertx vertx)
public Future<Void> tearDown(Vertx vertx)

Fixtures should be loaded after vertx-mvc has been bootstrapped (obviously) but before doing anything else.

Done


Loading DLL within a Callback call, breaks callback functionality

What version of gRPC and what language are you using?
C++, grpc 1.43.0
What operating system (Linux, Windows,...) and version?
Windows 10
What runtime / compiler are you using (e.g. python version or version of gcc)
MSVC
What did you do?

Created a service that capitalizes a string, this service implements grpc::Service

Created a callback service method as follows
extension7::stringValue request;
extension7::stringValue response1, response2;
request.set_stringcontent("helloworld");
 ::grpc::internal::CallbackUnaryHandler< ::extension7::stringValue, ::extension7::stringValue>* callbackHandler
     = new grpc::internal::CallbackUnaryHandler< ::extension7::stringValue, ::extension7::stringValue>
     ([service](::grpc::CallbackServerContext* context, const ::extension7::stringValue* request, ::extension7::stringValue* response) { return service->Capitalize(context, request, response); });
 grpc::internal::RpcServiceMethod* serviceMethod = new grpc::internal::RpcServiceMethod("/extension7.ExtensionDll/Capitalize", grpc::internal::RpcMethod::RpcType::NORMAL_RPC, callbackHandler);
 serviceMethod->SetServerApiType(grpc::internal::RpcServiceMethod::ApiType::CALL_BACK);
 service->AddServiceMethod(serviceMethod);

Registered service as an 'inproc' service
grpc::ServerBuilder builder;
builder.RegisterService("inproc", service);

Created an 'inproc' channel

Created a client unary reactor for the service, the client reactor uses a TemplatedGenericStub and runs the following code
stub->PrepareUnaryCall(context, methodName, grpc::StubOptions(), request, response, this);
StartCall();
Its OnDone callback, prints out a success or failure message based on the obtained Status

The service implementation loads a DLL that exports a factory to create an object that implements the method.
The callback is successfully called on the completion of the call, only if the DLL is loaded before the actual call and not within the call.
What did you expect to see?
The callback to get successfully invoked upon completion of the service call.
What did you see instead?
The callback is invoked before the actual call gets completed, with a 'Transport Closed' status error.
Anything else we should know about your project / environment?

I understand the concept of what you're trying to do, but unfortunately, our codebase is really not very tuned for this. DLLs on Windows have issues with regards to how memory is allocated and how global objects are accessed, and we take really no care in our C++ surface API to cater for this specific usage case. I doubt this is something we'll ever be able to fix properly, yet alone maintain.
This should work if everything is built statically. Please re-open a new issue if this isn't the case.


Stop loading img in display:none

Hi, dear
This PR stops loading img which is not displayed ( display:none ).
The function getBoundingClientRect, which is used in inViewport can't take correct position when the node is in invisible element, can it?
So I added a check in inViewport to know whether it's displayed.
Please tell me if I did anything wrong.
Thanks.
best regards,

+1 for this


Forms: DatePickerDialog scaling

Summary of changes
Fixes the improper scaling of DateTimePickerDialog on devices that are narrower than the minimum width needed to fit the DatePicker. This is 360dp as mentioned here.
The fix is to scale down the Dialog using the extension Modifier.scaleIfNarrow(minWidth: Dp) if the available screen width is less than required. Hence it will not effect devices that have sufficient width.
Since this effect occurs only in portrait mode, the extension Modifier.widthWithOrientation(width: Dp) is provided that sets the width constraint accordingly.

Before
After

Thanks @sorenoid, merging.


User Control cannot live in project subfolder

Windows target: 19041 / 17734
cppwinrt: 200729

Add a blank cppwinrt user control in a subfolder in the project (e.g. Views)
Build

Expected
everything works
Actual
Build break because the generated code expects the header to live in the root folder and if it doesn't exist, it won't include it meaning that you will get errors for undefined symbols:

MyControl1.g.h:

the workaround is to add AdditionalIncludeDirectories but this seems wrong as well as fragile...

Unfortunately the location is based on the namespace of the class and cannot be changed as the Xaml compiler relies on this naming scheme.

@kennykerr could we then update the VSIX to not let you create a control in a sub folder? And update the docs?

I don't know how the VSIX works and whether that's possible, but feel free to contribute a PR.


Changes to be committed: Added Cheesy Pick-up lines Play

new file:   src/plays/cheesylines/Cheesylines.js
new file:   src/plays/cheesylines/Readme.md

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Fixes #1534
#HACTOBERFEST
Pull Request Title: Add Cheesy Lines Randomizer Feature to Display Random Pick-Up Lines

Description:
This pull request addresses the issue of implementing the Cheesy Lines Randomizer feature. The play is a React-based interactive web application that generates random cheesy pick-up lines when a button is clicked.

Key Features:

Randomizer Functionality:

A random pick-up line is generated and displayed from a predefined collection when the user clicks the "Get Cheesy Line" button.

React Concepts Used:

State Management (useState): Manages the currently displayed pick-up line.
Event Handling: The onClick event on the button triggers the randomizer function.
Component Rendering: Updates the displayed line in real-time based on the current state.
JSX Layout: Structurally displays the lines and button in a clean, interactive design.

UI/UX:

A responsive and minimalist interface designed to work on different screen sizes, featuring an eye-catching button and neatly formatted display of pick-up lines.

How to Test:

Clone the repository and switch to the branch containing this feature.
Run npm install to install all dependencies.
Start the application by running npm start.
Interact with the app by clicking the "Get Cheesy Line" button to display random pick-up lines.

Linked Issue:
This pull request addresses and closes Issue #[#1534] - "Add Cheesy Lines Randomizer to Display Random Pick-Up Lines".

Checklist:

[x] Implemented the randomizer function.
[x] Styled the user interface for an engaging experience.
[x] Verified that the randomizer works and updates the displayed line dynamically.
[x] Tested responsiveness across different devices and screen sizes.

Feel free to reach out on Discord for further discussions or feedback on this feature!
Screenshots

it is absolutely fine.

hey, I have changed the css please verify!

can anyone tell me what's wrong with the code..? please

can anyone tell me what's wrong with the code..? please

now it's ok


TCP Command not getting sent

I am using 4.5.6
Trying to send out a TCP command to a mochad server  -
I have set the device type to TCP device
set the map type to TCP device
Target item is set to "tcp://<IP_ADDRESS>:1099/rf a1 on" - without quotes
I don't see the command being received on the mochad side -
this is what I get in the log
 2017-10-07 18:51:44,911 [main] DEBUG com.bwssystems.HABridge.upnp.UpnpListener - Sending notify packet for upnp. 2017-10-07 18:51:44,921 [main] DEBUG com.bwssystems.HABridge.upnp.UpnpListener - Sending notify packet for upnp. 2017-10-07 18:51:50,529 [qtp20725117-16] DEBUG spark.webserver.MatcherFilter - httpMethod:put, uri: /api/130eb90d32ec4d7589625d6d01c5217a/lights/1/state 2017-10-07 18:51:50,533 [qtp20725117-16] DEBUG spark.Request - get params 2017-10-07 18:51:50,536 [qtp20725117-16] DEBUG spark.Request - get splat 2017-10-07 18:51:50,540 [qtp20725117-16] DEBUG com.bwssystems.HABridge.hue.HueMulator - HueMulator PUT called on api/* with request <<</api/130eb90d32ec4d7589625d6d01c5217a/lights/1/state>>>, and body <<<{"on":true}>>> 2017-10-07 18:51:50,544 [qtp20725117-16] DEBUG spark.Request - get params 2017-10-07 18:51:50,547 [qtp20725117-16] DEBUG spark.Request - matchedPart: :userid = 130eb90d32ec4d7589625d6d01c5217a 2017-10-07 18:51:50,550 [qtp20725117-16] DEBUG spark.Request - matchedPart: :id = 1 2017-10-07 18:51:50,553 [qtp20725117-16] DEBUG spark.Request - get splat 2017-10-07 18:51:50,557 [qtp20725117-16] DEBUG com.bwssystems.HABridge.hue.HueMulator - hue state change requested: 130eb90d32ec4d7589625d6d01c5217a from <IP_ADDRESS> body: {"on":true} 2017-10-07 18:51:50,560 [qtp20725117-16] DEBUG com.bwssystems.HABridge.BridgeSecurity - validateWhitelistUser: found a user <130eb90d32ec4d7589625d6d01c5217a> 2017-10-07 18:51:50,563 [qtp20725117-16] DEBUG com.bwssystems.HABridge.hue.HueMulator - Decode Json for url items: [{"item":"tcp://<IP_ADDRESS>:1099/rf a1 on","type":"tcpDevice"}] 2017-10-07 18:51:50,567 [qtp20725117-16] DEBUG com.bwssystems.HABridge.plugins.tcp.TCPHome - executing HUE api request to TCP: tcp://<IP_ADDRESS>:1099/rf a1 on 2017-10-07 18:51:50,574 [qtp20725117-16] DEBUG com.bwssystems.HABridge.hue.DeviceDataDecode - Request <<rf a1 on>>, not done: false

Fixed - the command needed to be "tcp://<IP_ADDRESS>:1099/rf a1 on \n" without quotes
BTW this was sending an X10 command to mochad - may help someone else who stumbles on this thread


Cannot run admin tools (getbotlink, adminme) from Docker image

The Docker image doesn't have package.json, which is necessary for npm, nor does it have any of the JavaScript files from the tools/ directory, so you can't run npm run-script getbotlink or npm run-script adminme as described in the docs.

@turt2live ?

You should be able to run the tools directly through node, i.e. as node ./build/tools/adminme.js. The Dockerfile should perhaps put these tools on the PATH though to make them more convenient to use (e.g. docker exec $container_name adminme.
So far as I can tell the Docker image contains build which is where the executable form of the tools resides (tools is a TypeScript source code directory)

This seems to be one of the cases that I simply forgot about when contributing the docker image in the first place. Personally I use different tooling to do the tasks that the scripts provide, and forgot that they existed in the project :(
although, I do seem to have forced the container to ignore the folder for some reason: https://github.com/Half-Shot/matrix-appservice-discord/blob/develop/.dockerignore#L15

#208 has been merged, closing.


Update the tutorial https://patchthecode.github.io/MainTutorial/

The tutorial is outdated. Are there any possibilities of editing the tutorial so it can be done in latest Swift?
Regards,
Erik

The tutorial there for is both for version 6 and version 7 -> https://patchthecode.github.io/
Scroll to the bottom to see the version 7 Links.
Does this work for you?

Thanks for your reply.
I can create a calendar swiftly using the tutorials for version 7. However the tutorial I linked created a calendar with a CellView.xib-file which is what I am interested in.

@Eriknng yes. Those tutorials you linked to were for version 6.
Many people are still using versio 6, so i left it there until i remove it.


Document that 16bit images are expected to be in big-endian

Reader::next_frame actually mentions it, but it's not really highlighted. And the writer should mention this too.

Duplicate (or supplement?) of #203. PR with comments on all the interfaces you've noticed is still appreciated.

Duplicate (or supplement?) of #203. PR with comments on all the interfaces you've noticed is still appreciated.


Removing cookies missing the '.' prefix

Perhaps I am misunderstanding what need to happen, if so please let me know.
Ultimately, my website is running under the url:
https://randomstring.cloudfront.net/
Another service sets a cookie with the domain randomstring.cloudfront.net. My website which runs under randomstring.cloudfront.net directly, needs to be able to delete this cookie.
This works fine when the domain set in the cookie is .randomstring.cloudfront.net. But not when the domain of the cookie is randomstring.cloudfront.net (effectively, without the '.' prefix).
Using this library, the code below sets a cookie with the domain value .randomstring.cloudfront.net, despite the fact that the domain below is specified to not include that full stop prefix.
cookies.set('test', 'test', {
    domain: 'randomstring.cloudfront.net',
    path: '/',
});

Deleting the cookie with those same options (again, without the explicitly specified full stop prefix), deletes this cookie fine (despite the fact that I am not including the full stop prefix in the options, but the set cookie does include that prefix).
The same code won't delete the cookie if that same cookie does not explicitly have that full stop prefix in the domain.
I am confused, because the documentation both for setting and removing the cookie has:
domain (string): domain for the cookie (sub.domain.com or .allsubdomains.com)

Should I then not be able to specify which I want? I tried changing the various settings related to sameSite, but it didn't seem to have any effect. The code works fine so long as the cookie set includes that full stop prefix (irrespective of whether the cookie is set locally or externally).

Just cleaning up old bugs, let me know if it's still an issue.


I can't find responsive images?

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ x] Feature request
[ ] Documentation issue or request
[ ] Support request

Current behavior

N/A
Expected behavior

I was reading the documentation and it's nice, but hard to follow if you don't start with the examples and demos. However, is there a way for responsive images for the PlainGallery mode and grids?
Minimal reproduction of the problem with instructions

My official live example on StackBlitz (based on https://stackblitz.com/edit/angular-modal-gallery-v5) is:
What is the motivation / use case for changing the behavior?

So that the pictures can resize and also resize on mobile like Bootstrap responsive images.
Environment (the most important section to fill very carefully)

- Node version: X.X.X
- npm version: X.X.X
- Operating System and version:
- Angular version: X.Y.Z
- angular-cli version (or SystemJS/Webpack): X.Y.Z
- I'm using Server Side Rendering with angular-universal: YES/NO
- I'm compiling with mode: DEBUG / PROD / PROD with AOT

Browser:
- [x ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [x ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

Others:

Plain gallery is made to show small images and clicking on one of their you'll see the modal image in full screen. Why would you show a plain image in a responsive way filling the screen horizontally?
However, as in my official demos, for instance on stackblitz, you can draw your custom plain gallery iterating over images with an ngfor using your css.

PS: do you have any suggestions to improve the doc?
Feel free to propose your ideas, don't be shy :)

Hi, first, thanks very much for making this library! It's for the mobile part when the images get smaller, that's why, it just bothers me that the photo is small and doesn't fill up space. I looked at stackblitz for example Z4, Z5, and Z6, is it possible to add a style class to it? When you define the Layout:
something like:
layout: new LineLayout({ width: 'flex', height: 'auto' }, { length: 4, wrap: true }, 'img-responsive'),
Also in mobile, the slideshow isn't great on mobile, but you probably know that. I'll use an ngif on ngtemplate for that if detect on mobile to switch templates.
I was wondering in the documentation you can add drop-down menu for your Features like PlainGallery has a dropdown and the features inside that instead of clicking and scrolling and looking. Also an example code, that refers to the feature as an example (it takes the time out of scrolling through the stackblitz and reading and looking for what the code does).

I was wondering in the documentation you can add drop-down menu for your Features like PlainGallery has a dropdown and the features inside that instead of clicking and scrolling and looking.

Yes this is a good idea, I'll add it in my schedule for next releases.
Also an example code, that refers to the feature as an example (it takes the time out of scrolling through the stackblitz and reading and looking for what the code does).

I don't understand this, are you saying to add a link to the related demo for that particular feature? If yes, it's also a good idea (some examples are cross-features, so It will be dificult, but I can try it)
Also in mobile, the slideshow isn't great on mobile, but you probably know that. I'll use an ngif on ngtemplate for that if detect on mobile to switch templates.

Do you have an idea of how to improve it or do you want to contribute proposing a new layout? If you don't want to write code, I'll accept also sketches and mocks in paint :)...but I prefer contributions, in particular this Spring, because I'm really busy :(.
Hi, first, thanks very much for making this library! It's for the mobile part when the images get smaller, that's why, it just bothers me that the photo is small and doesn't fill up space. I looked at stackblitz for example Z4, Z5, and Z6, is it possible to add a style class to it? When you define the Layout:
something like:
layout: new LineLayout({ width: 'flex', height: 'auto' }, { length: 4, wrap: true }, 'img-responsive'),

I really don't understand this. Plain gallery is used to show many images on the screen (you can choose the size), not to show it in full screen like modal gallery.
I don't want to add something like bootstrap images in plain gallery, because the purpose of plain gallery is totally different. Modal gallery shows images in full screen, but plain gallery not.
Z4, Z5 and Z6 are completely custom so you can use you classes as you prefer. When you use custom plain gallery you have to use AdvancedLayout, not LineLayout that is build to be very basic.
As you can see in my code the plain gallery is configured in this way:
customPlainGalleryRowDescConfig: PlainGalleryConfig = {
    strategy: PlainGalleryStrategy.CUSTOM,
    layout: new AdvancedLayout(-1, true)
  };

but the gallery appears thanks to this code:

    <ng-container *ngFor="let img of images; let i = index">
      <div *ngIf="i <= 2">
         +{{images.length - 2 - 1}} more

        <ng-template #noThumb>

        </ng-template>

    </ng-container>

As you can see you can write the layout and the behaviour that you prefer, because I'm using my classes (like 'my-app-custom-plain-container-column', 'my-app-custom-image-column'...) . Feel free to be creative.

I saved on a private to list some info about this issues, so I can close it right now.
Thanks


⚠ Samsung has degraded performance

In 9b748bb, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2204 ms

Resolved: Samsung performance has improved in b6c01e5.


Sprint challenge

Completes self-study questions
Adds missing navigation and header to home page
Adds background color to home page boxes
Create about page
Add media Query to make pages responsive

Chinedu You did great job on todays sprint challenge. Your code is clean and concise. You reached the MVP without any trouble and  media querys to the paroject. Your layout resembles design files.
You also managed to add media querys to the project, really nice work.
What’s more, Your git workflow is very fluid and You are able to provide frequent and descriptive commit messages.
General overview:
Great answers
MVP reached
Completed one stretch goal
Clean codebase
Fluid git workflow
Amazing job overall

Thank you @SorinC6 for the kind words. I hope to do better next week by attempting more stretch goals.


Bug 557 : Components>Shipping Address >Invalid Placeholder And Phone Number Validation.

Description

Invalid placeholder:

Personl Info
Shipping Address

Make the changes to rds-comp-personal-info.tsx and rds-comp-shipping-address.tsx file.

Invalid placeholder and Add Phone No Validation.

Screenshots :

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Changes Reviewed and PR Approved


My extensions didn't work

Type: Bug
Just open visual studio code and no one of my extensions worked like before
VS Code version: Code 1.79.2 (695af097c7bd098fbf017ce3ac85e09bbc5dda06, 2023-06-14T08:57:04.379Z)
OS version: Windows_NT x64 10.0.19044
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 5700G with Radeon Graphics          (16 x 3793)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
7.40GB (3.06GB free)

Process Argv
--crash-reporter-id d5e84df6-a5f8-466c-a7b2-ab284d842aa5

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

better-comments
aar
3.0.2

html-end-tag-labels
ant
1.0.0

auto-close-tag
for
0.5.14

auto-rename-tag
for
0.1.10

vscode-gutter-preview
kis
0.30.0

vscode-css-peek
pra
4.2.0

trailing-spaces
sha
0.4.1

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30610678
2e4cg342:30602488
pyind779:30671433
f6dab269:30613381
pythonsymbol12:30671437
2i9eh265:30646982
showlangstatbar:30737416
vsctsb:30748421
pythonms35:30701012
03d35959:30757346
pythonfmttext:30731395
pythoncmvfstrcf:30756944
fixhidewlkth:30730051
pythongtdpath:30769146
dh2dc718:30770000

Try running the Help: Start Extension Bisect command to see if one of your extensions is identified as a problem.

Try running the Help: Start Extension Bisect command to see if one of your extensions is identified as a problem.

It said that it didn't find the problem, I tried with uninstall and install Visual Studio Code too but it didn't work too

Consider attempting a reinstallation of your extensions.

Consider attempting a reinstallation of your extensions.

I did it too and didn't work

I recommend reverting to the previous update, as it seems that the new update is the likely cause of this problem.

Just open visual studio code and no one of my extensions worked like before

Can you please explain exactly what is not working?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Relax nokogiri gem dependency so 1.6/1.7 can be used

Hi, I'm trying to upgrade rbvmomi from 1.6 to 1.9.4, but I can't because our app is using the newest version of Nokogiri. Is there any specific reason 1.5 is pinned?
Bundler could not find compatible versions for gem "nokogiri":
In Gemfile:
nokogiri (~> 1.6.8)
rbvmomi (~> 1.9.0) was resolved to 1.9.0, which depends on
  nokogiri (~> 1.5.11)

It's pinned to ~> 1.5 here which should allow using anything >= 1.5 and < 2.0. I'm not sure why you're having that issue. How are you going about trying to upgrade rbvmomi?

Hum, I see. I was under the impression "~> 1.5" would allow "1.x" too.
I'm just doing: "bundle update rbvmomi" after I've set the version in our Gemfile to "gem 'rbvmomi', '~> 1.9.0'"
Let me set that to 1.9.4 just to be sure and try again.

I see that in 1.9.0 that it was pinned to "~> 1.5.11"
https://github.com/vmware/rbvmomi/blob/cd942ec1f0d08dd76a98ba583b7906f15b4f17f4/rbvmomi.gemspec
Putting this in the Gemfile instead of "~> 1.9.0" worked (which is a tiny bit strange):
gem 'rbvmomi', '~> 1.9.4'
Thanks for the quick reply!


Include logs of init-containers

Note: this issue was imported from https://github.com/wercker/stern/issues/68, but it was originally created by hsychla...
The output does not currently include the logs of init-containers.
Could those be added?
Thanks for this awesome tool!

Note: this comment was imported, but it was originally made by cknowles...
Resolved by https://github.com/wercker/stern/pull/67 if that could be merged.

Note: this comment was imported, but it was originally made by hsychla...
ah, cool, did not look into merge requests before opening this.

Note: this comment was imported, but it was originally made by prune998...
It's still not working for me (see https://github.com/wercker/stern/pull/67#issuecomment-489055221)

Note: this comment was imported, but it was originally made by prune998...
OK, I finally got it working...
I DO see the init containers logs now. sorry for the noise


bs=128 to bs=32 in configure.sh

Following notes from the end of https://www.crowdsupply.com/sutajio-kosagi/novena/updates/1598

You might also want to do this github search to find other repos with this issue:
https://github.com/search?q="bs%3D128"+fpga&type=Code&utf8=✓

This bubbled up in the forums recently, would be good to fix: http://www.kosagi.com/forums/viewtopic.php?id=307


Simplify "code style" guide where we could be using the linter instead

I read our code style guidelines (docs/code-style.md) for the first time in a while recently, and determined that most of it is obsolete with the linter and then deleted; that's a much better way to manage this stuff.
To starthese items from our style guide could easily be converted to lint rules:

Don't use the style= attribute in HTML. Instead, define logical classes and
put your styles in external files such as zulip.css.

Don't use inline event handlers (onclick=, etc. attributes) in HTML. Instead,
attach a jQuery event handler
($('#foo').on('click', function () {...})) when the DOM is ready
(inside a $(function () {...}) block).

Use
$(function () { ...

rather than
$(document).ready(function () { ...

(Just lint for document.ready)

Scripts should start with #!/usr/bin/env python3 and not
#/usr/bin/python (the right Python may not be installed in
/usr/bin) or #/usr/bin/env python (we require Python 3
compatibility).  Don't put a shebang line on a Python file unless
it's meaningful to run it as a script. (Some libraries can also be
run as scripts, e.g. to run a test suite.)

(For this, I think a good strategy would be to ban shebang lines in .py files, and to add a lint section for files without an extension, and require that those shebang lines follow these rules).

Scripts should be executed directly (./script.py), so that the
interpreter is implicitly found from the shebang line, rather than
explicitly overridden (python script.py).

This is hard to lint for, but we can at least ban hardcoded paths of the form /srv/zulip/...

When selecting by id, don't use foo.pk when you mean foo.id.

This is easy to do with linting for  [.]pk, we've got like a dozen violations we can fix.

Probably most of the whitespace stuff can be deleted, but requires some testing.

@derAnfaenger this is probably a good issue for you.

@zulipbot claim

I just merged another batch of changes to clean up the code style guide.  I think probably the next useful step here is some reorganization.

@derAnfaenger I think the original project we had in mind is done.  It might make sense to open another issue for further general cleanup to our code style guide, though; it still feels kinda hard to read.


ReaderCheckpointHook failure (FLINK-6606)

Problem description
The reader fails at job initialization, due to an issue with the classloader as described in FLINK-6606.
The exception is:
2017-05-12 15:07:15,227 ERROR org.apache.flink.runtime.jobmanager.JobManager                - Failed to submit job a7535f3f9bdfc06ec89f57e4683aed68 (anomaly-detection)
io.pravega.shaded.io.grpc.ManagedChannelProvider$ProviderNotFoundException: No functional channel service provider found. Try adding a dependency on the grpc-okhttp or grpc-netty artifact
    at io.pravega.shaded.io.grpc.ManagedChannelProvider.provider(ManagedChannelProvider.java:126)
    at io.pravega.shaded.io.grpc.ManagedChannelBuilder.forTarget(ManagedChannelBuilder.java:77)
    at io.pravega.client.stream.impl.ControllerImpl.<init>(ControllerImpl.java:91)
    at io.pravega.client.admin.stream.impl.ReaderGroupManagerImpl.<init>(ReaderGroupManagerImpl.java:49)
    at io.pravega.client.admin.ReaderGroupManager.withScope(ReaderGroupManager.java:39)
    at io.pravega.connectors.flink.ReaderCheckpointHook.<init>(ReaderCheckpointHook.java:62)
    at io.pravega.connectors.flink.FlinkPravegaReader.createMasterTriggerRestoreHook(FlinkPravegaReader.java:276)
    at org.apache.flink.streaming.api.graph.FunctionMasterCheckpointHookFactory.create(FunctionMasterCheckpointHookFactory.java:43)
    at org.apache.flink.runtime.executiongraph.ExecutionGraphBuilder.buildGraph(ExecutionGraphBuilder.java:262)

Problem location
The root cause is that grpc uses the thread context classloader (TCCL) to locate a transport plugin (i.e. grpc-netty), but Flink isn't setting the TCCL to facilitate that.
Suggestions for an improvement
A patch has been submitted to Flink, ideally for inclusion in 1.3.  As a workaround, the ReaderCheckpointHook could set the TCCL in its constructor, e.g.:
Thread.currentThread().setContextClassLoader(this.getClass().getClassLoader());

Good news, the patch for FLINK-6606 was accepted into 1.3.0 and should be in RC2.  It is also on master.

I reopened this because I think we should add the workaround mentioned above.


Rename nID to namespace where applicable

Context
https://github.com/celestiaorg/celestia-node/blob/c77f6db35fe57ccef4110d0c7815e53a24921948/share/get.go#L52
Problem
In a few locations in this repo, nID: namespace.ID is used when I think a namespace is being passed (i.e. version + ID).
Proposal

Rename nID to namespace or ns where applicable.
Replace the usage of the NMT type namespace.ID with celestia-app type Namespace

Re 2. We want to move on Namespace from the app once it becomes a single slice. IIRC, with aligned on that in sync. When and how can we do it? Node team can help there

I don't think celestia-app can make this change in the short-term b/c it's breaking and we've already cut celestia-app v1.0.0-rcs.

That's fair. The good thing is the change is not consensus-breaking, so we can still do it. Adding it to my list of things to take during share pkg extraction.
Meanwhile, cleaning up and defining the type in celestia-node makes total sense. Assigning this on me.

@rootulp, thinking about this more, the namespace in NMT should be called just the namespace then as well because NMT commits to the version as well thus, it operates over namespaces rather than IDs. I am not sure anymore it is worth renaming in celestia-node only without nmt


Delete old page https://de.serlo.org/muenchen

-> https://de.serlo.org/pages

I do not have access on this page :-) For the future: Such delete requests shall address Serlo admins?

@kulla I looked it up, you need to be langadmin of the specific tenant (in this case the german_langadmin) to delete the pages. So the request should adress one of them (currently Renate, inyono, wolfgang, Nish, Knorrke, Helly, peterjaumann, tobi_serlo, Rebi, metzgaria, kathongi, Flora_Jana, Niggo, tobias_lausser) or the community support.


⚠ Ixtanet SAT has degraded performance

In 5dab850, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20755 ms

Resolved: Ixtanet SAT performance has improved in b28d42d.


Improve sampling of tiles

For other nowcasting applications, such as precipitation, the training data is usually sampled so that rainfall exists or is above some threshold in every, or nearly every input sample. This ensures that, while most the time there  is no rainfall in a given area, the model will learn what happens when there is. For forecasting clouds and cloud movement, something similar should probably be done.

One idea for sampling is to focus on tiles where clouds appear from nothing, instead of just moving across. These are rarer, and would be something where optical flow methods would have a very difficult time, but ML models might be able to predict?

Also, we could make a sampler that shows whatever fraction of different topographic/time of year/etc. inputs to the model, so that the model sees a wide variety of different topologies and evenly throughout the year.


Fix type-related bug in DCEGM

Recent versions of numpy became more strict with respect to data types. Particularly, np.NaN is no longer accepted in integer arrays. This was causing a crash in the DCEGM code whenever it was used with numpy 1.2.0 (which the binder instances do). For instance the DCEGM DemArk binder link crashes.
This PR fixes the issue.

[ ] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[ ] Updated documentation of features that add new functionality.
[ ] Update CHANGELOG.md with major/minor changes.

I have not updated the change-log because I'm not sure what the next release will be and what format you'd like to have (no changes have been recorded since 0.11).

Let's assume that there will be a 0.12.0 release with data TBD
Then you can fill out the changelog accordingly.
If we wind up doing a 1.0 instead of a 0.12.0 we can update it before the release.

Is this the same thing as #988 looks like it?

Is this the same thing as #988 looks like it?

It is, yes. Any of the two solutions should work.

Changelog updated. This is now ready to merge (Alan's solution would also work).


Enforce correctness of self-dependencies

Summary
As far as I can tell, this was added in https://github.com/astral-sh/uv/pull/319, but it seems incorrect to ignore these.
Closes https://github.com/astral-sh/uv/issues/9693.

Hm I'm a little worried about the implications of this. Will it break people with dynamic versions?

Why would it break people with dynamic versions?

(This only affects packages that declare dependencies on themselves, which is itself almost always a mistake.)

I'm imagining you have a self-dependency with a version constraint that.. works in production but fails locally due some weird dynamic development version scheme? Perhaps I'm overthinking it. Dynamic versions stood out to me as a case where there are weird local versions, but I don't think that's the only case where there could be a mismatch.
More broadly, what happens with a self-dependency in production i.e. published to PyPI?

More broadly, what happens with a self-dependency in production i.e. published to PyPI?

Can you expand on this? If you install the package from PyPI, and it declares a dependency on itself, they will just resolve to the same package. The same is true if you clone the package and install it locally. Both would work fine.
The case we would fail is: you declare a self-dependency, but at a version that is incompatible with the current package version. I think that should fail! Check out the linked issue where we silently succeed with a broken resolution.
(I don’t know that there’s even a real, valid use-case for a self-dependency.)

I did read the linked issue :) just trying to understand the problem more broadly since it turns something that's currently allowed into a firm error.

The case we would fail is: you declare a self-dependency, but at a version that is incompatible with the current package version. I think that should fail!

I guess the clarifying question is: would this fail at publish or install time from PyPI? (entirely separately from uv)

By “publish time”, do you mean, if you ran uv lock locally prior to publishing?

I mean.. if you weren't using uv at all, i.e., some lower-level tools like python -m build and twine.

Hmm, none of those tools have to resolve dependencies though. There’s no dependency validation. They just have to construct the metadata. They don’t have to solve the graph.

Yeah so then when you install with pip later what would happen? Perhaps there would be a failure then?

Yeah it would fail then. Though I think that’s the same as if, e.g., the package declared dependencies on both flask==3.0.0 and flask==2.0.0? It would fail on install, but not on publish.

Okay, thanks for going through it with me. I'm not quite sure where this change could cause problems 👍

(I don’t know that there’s even a real, valid use-case for a self-dependency.)

I guess it'd let you declare a default extra that.. you can't turn off? 😬

Just want to check this doesn't break the real use case of using extras to depend on other extras of your own project? e.g.
[project]
name = "spam-eggs"
version = "2020.0.0"
requires-python = ">=3.8"

[project.optional-dependencies]
tests = ["pytest"]
dev = ["pdb", "memray"]
all = [
  "spam-eggs[tests]",
  "spam-eggs[dev]",
]

No, that remains totally fine.

It would error if you did:
[project]
name = "spam-eggs"
version = "2020.0.0"
requires-python = ">=3.8"

[project.optional-dependencies]
tests = ["pytest"]
all = [
  "spam-eggs[tests]==2021.0.0",
]


[Bitbucket Local] Add new API call to get the current BitBucket Server user details

This adds a new API call for BitBucket Server (local) to get the user details from the username provided to use in creating a valid git user for the platform if possible.
Changed GetCurrentUser to use the actual user details if they can be read out instead of username and empty email which was causing it to always revert to using the git config
:sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Enhancement to use the user details from the user provided for BitBucket Server integration.
:arrow_heading_down: What is the current behavior?
Currently only provides the username when creating a user for a commit signature, but this fails (since no name or email) and falls back to using the git config.
:new: What is the new behavior (if this is a feature change)?
It will now attempt to lookup the user in BitBucket to get the name and email. If it cannot find the user, it will still fallback to the existing behaviour.
:boom: Does this PR introduce a breaking change?
This will break any integrations which rely on it using the git config for the user that creates the commits and if this user is different to the username provided in the command line.
No impact on any other integrations or BitBucket Cloud.
:bug: Recommendations for testing
:memo: Links to relevant issues/docs
:thinking: Checklist before submitting

[x] All projects build
[x] Relevant documentation was updated

Implements #973

Hi @AnthonySteele and other maintainers, what is the best way to progress this?  I'm not sure if have any BitBucket Local specific developers who should review this.

Add a check to resolve an issue where libgit2 was creating symbolic links and it was causing issues in test cleanup where tests did a checkout and tried to clean up.

For the libgit2 issue, after confirming with @AnthonySteele , I've upgraded to the preview version which doesn't have the bug. So we don't need the workaround in this ticket.
As for BitBucket maintenance/features, @MarcBruins could you perhaps take a look please?


Unable to uninstall

9:46:52 AMyarn remove v1.22.10
9:46:52 AM[1/2] Removing module homebridge-ewelink...
9:46:52 AMerror This module isn't specified in a package.json file.
9:46:52 AMinfo Visit https://yarnpkg.com/en/docs/cli/remove for documentation about this command.

I ended up ditching HOOBs and configured Homebridge….
I still have my HOOBs SD Card unchanged though…

—
Reply to this email directly, view it on GitHub https://github.com/bwp91/homebridge-ewelink/issues/331#issuecomment-1005390573, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHXXDLHF22IVCRYRCTM5D23UUPIERANCNFSM5LHYAMTQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.

Ah, is it working okay on homebridge?

Haven’t installed on HomeBridge yet. At this point I don’t plan on installing it…
Sent from my iPhone

On Jan 5, 2022, at 12:49 PM, Ben @.***> wrote:

Ah, is it working okay on homebridge?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.


xWebConfigKeyValue throws error updating key in v<IP_ADDRESS>

In the latest release to the gallery, xWebConfigKeyValue now throws a Cannot add duplicate collection entry of type 'add' with unique key attribute 'key' set error when attempting to update an existing app setting:
VERBOSE: Perform operation 'Invoke CimMethod' with following parameters, ''methodName' = SendConfigurationApply,'className' = MSFT_DSCLocalConfigurationManager,'namespaceName' = root/Microsoft/Windows/DesiredStateConfiguration'.
VERBOSE: An LCM method call arrived from computer XENAPP with user sid S-1-5-21-2461450134-1015871363-2610986777-500.
VERBOSE: [XENAPP]: LCM:  [ Start  Set      ]
VERBOSE: [XENAPP]:                            [DSCEngine] Importing the module C:\Program Files\WindowsPowerShell\Modules\xWebAdministration\DscResources\MSFT_xWebConfigKeyValue\MSFT_xWebConfigKeyValue.psm1 in force mode.
VERBOSE: [XENAPP]: LCM:  [ Start  Resource ]  [[xWebConfigKeyValue]ServiceAutoDiscovery_xenapp.lab.local]
VERBOSE: [XENAPP]: LCM:  [ Start  Test     ]  [[xWebConfigKeyValue]ServiceAutoDiscovery_xenapp.lab.local]
VERBOSE: [XENAPP]:                            [[xWebConfigKeyValue]ServiceAutoDiscovery_xenapp.lab.local] Importing the module MSFT_xWebConfigKeyValue in force mode.
VERBOSE: [XENAPP]: LCM:  [ End    Test     ]  [[xWebConfigKeyValue]ServiceAutoDiscovery_xenapp.lab.local]  in 1.1720 seconds.
VERBOSE: [XENAPP]: LCM:  [ Start  Set      ]  [[xWebConfigKeyValue]ServiceAutoDiscovery_xenapp.lab.local]
VERBOSE: [XENAPP]:                            [[xWebConfigKeyValue]ServiceAutoDiscovery_xenapp.lab.local] Importing the module MSFT_xWebConfigKeyValue in force mode.
Filename:
Error: Cannot add duplicate collection entry of type 'add' with unique key attribute 'key' set to 'Service.AutoDiscoveryAddresses'
    + CategoryInfo          : NotSpecified: (:) [], CimException
    + FullyQualifiedErrorId : System.Runtime.InteropServices.COMException,Microsoft.IIs.PowerShell.Provider.AddConfigurationProperty
   Command
    + PSComputerName        : localhost

There is a logic error in Set-TargetResource after the refactor between v<IP_ADDRESS> and v<IP_ADDRESS> that tries to add a key - rather than updating it. v<IP_ADDRESS> had the following logic on line 77:
if((!$IsAttribute -and ($existingValue -eq $null)) -or ($IsAttribute -and ($existingvalue.length -eq 0)))

After the refactor in the v<IP_ADDRESS> release, the -not logic has changed to:
if((-not($IsAttribute -and `
                ($null -eq $existingValue)) -or `
                ($IsAttribute -and `
            ($existingValue.Length -eq 0))))

Changing the logic to this fixes the problem:
if ((-not $IsAttribute -and ($null -eq $existingValue)) -or `
    ($IsAttribute -and ($existingValue.Length -eq 0)))

Looking through the outstanding PRs, this looks to be covered in https://github.com/PowerShell/xWebAdministration/pull/160, but has not yet been merged in.

Hi, this is actually mess up as White Paper introduce it to use for Windows Server 2012 R2, but will fail every time.
https://github.com/PowerShell/Whitepapers/blob/master/PullServerCPIG/PullServerCPIG.md#advanced-configuration-for-windows-server-2012-r2
        xWebConfigKeyValue CorrectDBProvider
        {
            ConfigSection = 'AppSettings'
            Key = 'dbprovider'
            Value = 'System.Data.OleDb'
            WebsitePath = 'IIS:\sites\PSDSCPullServer'
            DependsOn = '[xDSCWebService]PSDSCPullServer'
        }

Anyone check this issue? Or should I send PR?

cc @mgreenegit for the whitepaper issue

This issue was fixed by #160 and doesn't occour anymore in version <IP_ADDRESS>. Shouldn't it be closed?


GoogleCloudStorage, object->exists throws exception instead of returning false

I'm trying to check if an object already exists inside of a bucket, before generating an upload url. The bucket has "fine grained access control" enabled. The check fails with "Forbidden" instead of returning false.
Environment details

OS: Ubuntu 18.04.4 LTS
PHP version: PHP 7.3.14-6+ubuntu18.04.1+deb.sury.org+1
Package name and version: google/apiclient 2.4.0

Steps to reproduce

see code below

Code example
$bucket = $client->bucket('mybucket');
$bucket->object('exists')->exists(); // returns true
$bucket->object('doesnotexist')->exists(); // expected: returns false, but throws exception

it throws this exception instead of a "NotFoundException":
^ Google\Cloud\Core\Exception\ServiceException^ {#504
  -serviceException: GuzzleHttp\Exception\ClientException^ {#512
    -request: GuzzleHttp\Psr7\Request^ {#499
      -method: "GET"
      -requestTarget: null
      -uri: GuzzleHttp\Psr7\Uri^ {#526
...

Client error: GET https://storage.googleapis.com/storage/v1/b/...?fields=name resulted in a 403 Forbidden

Probably because it returns with status code 403 instead of 404.
Thanks!

If the account you are authenticating with does not have permissions on the bucket, you will see this error.
To test this, I created a bucket and uploaded a file. I granted Owner permissions on the file to a different service account than the one with bucket permissions, then called exists() on that object. I got the expected true result. Then I called exists() on a non-existent object and received a 403 exception.
If you are unsure whether your service account has reader permission at the bucket level, you should catch the ServiceException.


small validation set doesnt work

data.iter_valid_records() doesn't yield anything if the validation set is smaller than batch_size.
Adding a final block as follows works:
if len(batch['query_id']) > 0:
  yield _pack_n_ship(batch)

This also means that the final validation % batch_size documents are omitted from validation.
I suspect data.iter_train_pairs() has exactly the same issue.

Good catch! The data.iter_train_pairs is not affected by this because _iter_train_pairs iterates indefinitely.


Refactor simulation initialisation

Moved most of the initialisation implementation to AMRSimulation.hpp + user should implement preInitC and setInitC funcs. The user should also specify what physics modules the simulation uses (variables are only defined if physics module is used).

Moved most of the initialisation implementation to AMRSimulation.hpp + user should implement preInitC and setInitC funcs. The user should also specify what physics modules the simulation uses (variables are only defined if physics module is used).

As we discussed, let's split this into three separate pull requests:

Physics_Traits, indexing changes, turning off radiation/hydro with if constexpr, etc.
Changes to how we set the initial conditions for simulations
Face-centered MultiFabs

Changing state_new_ to state_new_cc_ etc. could go in either 2 or 3, whichever is easier.

FYI- I've added code development guidelines for Quokka here: https://github.com/BenWibking/quokka/blob/development/CONTRIBUTING.md

Thanks for linking me the contribution guideline-doc, Ben!
I will separate those changes into different branches and then make a pull-request for each.
Cheers, Neco
On 19 Jun 2022, 10:52 AM +1000, Ben Wibking @.***>, wrote:

FYI- I've added code development guidelines for Quokka here: https://github.com/BenWibking/quokka/blob/development/CONTRIBUTING.md
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Use a workflow based on lint-staged for CI linting

This PR uses a new type of workflow that uses lint-staged --diff to operate only on files that differ between the current PR and main using lint-stage's glob-based config to run all linters with --fix, then pushes the result to the branch/PR in question if there are any changes or fails if there are issues that can't automatically be fixed.

@yathomasi @rogermparent folks, what else is missing here?

This was mostly an experiment which I'm unsure would be a straight upgrade unless there's a need to reduce the amount of Actions minutes used on websites' CI as well as replace Restyled by using the --fix versions of all commands and committing any post-CI differences to the branch.
To wrap this up, the steps are:

Merge main, this could clear up the diff
Address an issue where the commit added by the workflow doesn't re-run CI checks and, while technically harmless, looks pretty bad. Maybe could be fixed by manually adding passed checks to the new sha in the workflow?
Roll out to other sites if desired

@rogermparent thanks! how is it related to unifying linters, etc?

and committing any post-CI differences to the branch.

does it mean that we would have it for every PR enabled (including forks?)? A new commit comes on top of the history?

Address an issue where the commit added by the workflow doesn't re-run CI checks and, while technically harmless, looks pretty bad. Maybe could be fixed by manually adding passed checks to the new sha in the workflow?

could you clarify please?

I have updated the PR with main so that diff is clear.
I am also a little out of context here and I assume we are trying to replace restyled with our own version but I am unsure of the reason behind this. cc: @rogermparent

@rogermparent thanks! how is it related to unifying linters, etc?

The successful result of this PR builds onto the unified linters project and makes the PR lint workflow more targeted, as well as allowing the whole new pipeline to to be used in Restyled. Since I found Restyled only handles a limited amount of linters, the only one we use being Prettier, I tried out a GHA-based replacement to do the same functionality with more features.

does it mean that we would have it for every PR enabled (including forks?)? A new commit comes on top of the history?

This PR's workflow runs on the same hooks as the current workflow, which I believe currently excludes forks. On the PRs it does run it, it does add a new commit on top of the PR's history.

Address an issue where the commit added by the workflow doesn't re-run CI checks and, while technically harmless, looks pretty bad. Maybe could be fixed by manually adding passed checks to the new sha in the workflow?

could you clarify please?

It's a bit of a weird issue so I'll outline what happens:

User pushes commit that needs linting
Workflow runs on user commit, displaying results as usual
Workflow detects changes and commits them to the current branch
Workflow-created commit appears on GitHub, and does not run checks because anything created with the GitHub Actions built-in key cannot trigger further GH Actions
User sees the latest commit is the workflow-created commit, and does not see any CI runs at the bottom of the page. The only way this happens is if all issues in the previous (user-created) commit were automatically fixed, so the code is actually working well even though the check doesn't show up on the latest commit.

I am also a little out of context here and I assume we are trying to replace restyled with our own version but I am unsure of the reason behind this. cc: @rogermparent

That's one aim of this PR: the reason for replacing Restyled is because Restyled can only run prettier while this setup runs the whole CI pipeline.
The other aim of this PR (why I mentioned run hours) is to have the PR pipeline only run CI on files that have changed instead of running it on every file in the repo.

Thanks, @rogermparent for the detailed descriptions. I really liked the Idea and the approach and we need to do a few improvements before we proceed.
IMO, PR based approach would be best for these changes than committing on top of PR and we can definitely use cml for this. We can see the changes clearly on both sides CI will fail on PR and if there are any changes that can be fixed, they will be available on the new PR and all CI tests will be done there.
But, if we don't want to create PR, then I don't see any other option than committing on top of the PR but it should not have a side effect, also the new push should trigger the CI checks. That's important I guess.
Regarding priority at the moment, I think it's p2-nice-to-have as major contributors' changes are on docs which means markdown files and a few parts of other codebases, for which Restyled should be enough for now.
I realized Restyled is not working for the iterative.ai project most probably that project being a private repo so this will be helpful there as well.

I'm going to close this since I don't see it being completed, but feel free to use this as inspiration for future CI pipelines! I think lint-staged is more powerful than people give it credit for and can replace quite a few external serviced.


Add checker functions

Add checker function to check user input, some examples:

check ip/fqdn => Verify that the input is a valid ip or fqdn (only the syntax)
check port => Verify that the input is a valid port (port range + int type)

close on MR #89


About .json to .npy

Thank you for your excellent work!
The code fbx2joints3d.py convert .fbx files into .json format.
But only .npy format files could be recognized in the code preprocess.py and also the subsequent process.
So how can I prepare my own dataset?
Or how can I convert json files to npy files like you did?

Thanks for this issue!
I forgot to upload that script. Now I add a function json2npy in fbx2joints3d.py to convert .json to .npy. Please check if that works since I haven't test it. Feel free to let me know if there is any problem.

Thanks a lot!


tweak tensor core heuristic

meh it's faster for mac but slower for tinybox. really need tensor core in search


Typo in Zone Name

Under the section, Review your endpoint's DNS settings, there is a typo in one of the zones: there's a hypen instead of a dot.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2d8413ef-386c-50ee-8f72-2be280d10201
Version Independent ID: ccd4143d-d5df-bb9f-5df4-80b049998473
Content: Configure your private link - Azure Monitor
Content Source: articles/azure-monitor/logs/private-link-configure.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @guywi-ms
Microsoft Alias: guywild

@SteveColegrove
Thanks for your feedback! We will investigate and update as appropriate.

@SteveColegrove We have verified and updated the document as required. The update will go live in less than 24 hours. Thanks again!


V2: add LinkApp and LinkAdmin to shortcut links

Describe your changes
Add two new components :

LinkApp: Link that prefix href with APP_PATH
LinkAdmin: Link that prefix href with ADMIN_PATH

Checklist

[x] I performed a self review of my code
[x] I ensured that everything is written in English
[x] I tested the feature or fix on my local environment
[x] I ran the yarn storybook command and everything is working

Because of many conflicts after V2 release on master, I close this PR and I created a new one here : https://github.com/BearStudio/start-ui-web/pull/439


Camera will change from IR sometimes.

Sometimes the camera howdy uses will switch to the normal camera, and then after a few days it will switch back to the IR camera. I have no idea what could be causing this, I imagine it's something to do with the laptop firmware itself?
I'm using a HP Envy x360 13.3 with a Ryzen 2500u.
It's done this under the Pop!_OS and Linux Mint under the Linux Kernel 4.17 and 4.18

Pop!_OS
Latest as of this post

Could your run ls /dev/ | grep video for me?

I get:
video0
video1
video2
video4

It's just happened again, the IRCamera is now video2.
I haven't really checked but I'm pretty sure it only happens between reboots.

I'm guessing your webcam is connected internally as an USB webcam, and USB devices can be assigned device IDs in almost random order. This could be fixed by using the hard coded ID from the USB interface instead, i'll look into it.

The last release changed the way Howdy picks a camera, and now uses the PCI id of the USB device to determine which camera to use. This should fix your problem.
When upgrading from 2.3.1 to 2.4.0 the installer will automatically convert your old device_id to a device_path, but you might want to replace that path with the correct camera in /dev/v4l/by-path/.


[otp/rom] Add entropy_src health OTP settings.

This change adds OTP settings for the entropy_src health tests. These settings must be loaded into OTP before enabling ROM execution otherwise the entropy source will trigger a health test alert.
fixes #9492

@alphan this change unconditionally loads words from OTP before enabling the entropy source. I am not sure if it makes sense to also add a separate configuration word to enable/disable all these writes. If we keep it as is, it may still be possible for the ROM to boot when with uninitialized OTP settings, but the entropy health check alert would have to be disabled. I will do some testing in parallel to check this.

@alphan this change unconditionally loads words from OTP before enabling the entropy source. I am not sure if it makes sense to also add a separate configuration word to enable/disable all these writes. If we keep it as is, it may still be possible for the ROM to boot when with uninitialized OTP settings, but the entropy health check alert would have to be disabled. I will do some testing in parallel to check this.

I was wondering about the same thing, thanks for pointing this out @moidx. We skip alert configuration in TEST_UNLOCKED* so we should be able to boot with default OTP values as long as entropy_src is ok with all zeroes. This definitely introduces a dependency between these OTP items that I should capture in the manufacturing doc.

This reminds me: we should probably add a simple boot test with all default OTP values in TEST_UNLOCKED.

Hi @alphan, can you take another look? I ended adding the ROM checks to this PR. You can focus on the 2nd commit if you are satisfied with the resolution of the previous comments. Thanks!

Hi @alphan, gentle ping.

requested a re-run since the log is not available anymore (at least for cw310 rom tests)

@moidx 👋🏼

Thanks @moidx and apologies for the delay. Just some nits. Also, CREATOR_SW_CFG_RNG_EN is currently used for gating entropy usage in countermeasures. Do you think we should gate the config in rom_start.S and check in the rnd driver with it or are we confident that the test & alert mechanism will work fine?

Hi @alphan, I think we are ok here, but will add a top-level test to confirm the behavior.

Hi @alphan, I think we are ok here but will add a top-level test to confirm the behavior.

Thanks @moidx! Just one failure in cw310 tests:
//sw/device/silicon_creator/rom/e2e:rom_e2e_default_otp_bootup_fpga_cw310_rom FAILED in 2 out of 2 in 16.7s

I guess the OTP image that this test uses needs to be updated.


cmd/link: regression on some distros for ppc64le with CL 130316

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
upstream tip
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
ppc64le Debian 9
What did you do?
Built golang using all.bash
What did you expect to see?
All tests passed
What did you see instead?
~/golang/test/go/src$ go tool dist test testso
../misc/cgo/testso
./main.exe: error while loading shared libraries: R_PPC64_ADDR16_HA re113298fa4 for symbol `' out of range
2018/09/04 19:10:02 Failed: exit status 127
This does not fail in the go 1.11 branch, and I tracked it down the commit 6417e91.
The commit mentioned above is dropping the -no-pie option, which is the cause of the failure.
commit 247b034:
go tool dist test testso

##### ../misc/cgo/testso
# command-line-arguments
HEADER = -H5 -T0x11000 -D0x0 -R0x10000
 0.00 deadcode
 0.01 pclntab=247478 bytes, funcdata total 46718 bytes
 0.01 dodata
 0.01 dwarf
 0.02 symsize = 0
 0.03 reloc
 0.04 asmb
 0.04 datblk
 0.05 sym
 0.05 elfsym
 0.05 symsize = 32880
 0.05 symsize = 33312
 0.06 header
 0.17 host link: "gcc" "-m64" "-o" "/tmp/go-build620912334/b001/exe/a.out" "-rdynamic" "-Wl,--compress-debug-sections=zlib-gnu" "/tmp/go-link-627000385/go.o" "/tmp/go-link-627000385/000000.o" "/tmp/go-link-627000385/000001.o" "/tmp/go-link-627000385/000002.o" "/tmp/go-link-627000385/000003.o" "/tmp/go-link-627000385/000004.o" "/tmp/go-link-627000385/000005.o" "/tmp/go-link-627000385/000006.o" "/tmp/go-link-627000385/000007.o" "/tmp/go-link-627000385/000008.o" "/tmp/go-link-627000385/000009.o" "/tmp/go-link-627000385/000010.o" "/tmp/go-link-627000385/000011.o" "/tmp/go-link-627000385/000012.o" "/tmp/go-link-627000385/000013.o" "-g" "-O2" "-L/home/boger/golang/test/go/misc/cgo/testso" "-lcgosotest" "-g" "-O2" "-lpthread" "-no-pie"
 0.27 cpu time
23451 symbols
26908 liveness data

ALL TESTS PASSED (some were excluded)

commit 6417e91:
go tool dist test testso

##### ../misc/cgo/testso
# command-line-arguments
HEADER = -H5 -T0x11000 -D0x0 -R0x10000
 0.00 deadcode
 0.01 pclntab=247478 bytes, funcdata total 46718 bytes
 0.01 dodata
 0.01 dwarf
 0.02 symsize = 0
 0.05 reloc
 0.05 asmb
 0.05 datblk
 0.06 sym
 0.06 elfsym
 0.06 symsize = 32880
 0.06 symsize = 33312
 0.07 header
 0.22 host link: "gcc" "-m64" "-o" "/tmp/go-build377553058/b001/exe/a.out" "-rdynamic" "/tmp/go-link-215391806/go.o" "/tmp/go-link-215391806/000000.o" "/tmp/go-link-215391806/000001.o" "/tmp/go-link-215391806/000002.o" "/tmp/go-link-215391806/000003.o" "/tmp/go-link-215391806/000004.o" "/tmp/go-link-215391806/000005.o" "/tmp/go-link-215391806/000006.o" "/tmp/go-link-215391806/000007.o" "/tmp/go-link-215391806/000008.o" "/tmp/go-link-215391806/000009.o" "/tmp/go-link-215391806/000010.o" "/tmp/go-link-215391806/000011.o" "/tmp/go-link-215391806/000012.o" "/tmp/go-link-215391806/000013.o" "-g" "-O2" "-L/home/boger/golang/test/go/misc/cgo/testso" "-lcgosotest" "-g" "-O2" "-lpthread"
 0.29 cpu time
23451 symbols
26908 liveness data
./main.exe: error while loading shared libraries: R_PPC64_ADDR16_HA re10f2f8fa4 for symbol `' out of range
2018/09/05 09:53:14 Failed: exit status 127

We've seen similar problems in the past related to the use of the -pie option. In some distros, gcc uses -pie by default, so golang should be passing -no-pie to the external linker.
There were similar error messages with issue #21954.

@cherrymui @rsc @mdempsky @ianlancetaylor @mwhudson

Hmm this doesn't reproduce for me on Ubuntu 18.04. I can't really see why that commit would break things here, I guess one would need to dump out the command line the linker is using to test compat and see why it fails...

Hmm this doesn't reproduce for me on Ubuntu 18.04. I can't really see why that commit would break       things here, I guess one would need to dump out the command line the linker is using to test compat and see why it fails...

As I show above, before this commit, gcc was passing -no-pie to the external linker but after this commit it does not. At some point gcc started passing -pie by default to ld so golang had to pass -no-pie to override it.

Please use the go tool's -x option so that we can see exactly how cmd/link is being invoked, specifically so that we can see what the -extldflags option is.
CL 130316 was not supposed to change whether we pass -no-pie or not, it was just supposed to do a more accurate test of whether the external linker supports the option.  Clearly that is breaking something for you, but we need to find out what is breaking and why.

Distros with binutils 2.29 or later don't fail. Debian 9 is the only one I found with 2.28. Perhaps a fix went in after 2.28 to fix a problem. I will try to track that down further.
This CL removes the -no-pie when invoking the external linker. Is that the correct/expected behavior?

The only effect of CL 130316 that apparently caused this problem was to add the value of -extldflags to the external linker when testing whether -no-pie is supported.  The code calls linkerFlagSupported to test whether -no-pie is supported.  If it is, it is passed.  CL 130316 changes linkerFlagSupported.
In the comment above you are quoting the old code.  That's not what the linker code looks like now or in 1.11.
Can you change linkerFlagSupported to print exactly how it is invoking the external linker and what the linker is printing?  Thanks.

When linkerFlagSupported was changed to pass extra linker options when linking trivial.c, this happens on Debian 9/binutils 2.28:
linkerFlagSupported: gcc flags: [-g -O2 -L/home/boger/golang/bad/go/misc/cgo/testso -lcgosotest -g -O2 -lpthread -no-pie trivial.c] out: /home/boger/golang/bad/go/misc/cgo/testso/libcgosotest.so: undefined reference to `goCallback'
collect2: error: ld returned 1 exit status

So that causes linkerFlagSupported to return false for -no-pie since it contains the undefined string and -no-pie doesn't get added to the list of flags for ld.
I don't know why the linker error message from within linkerFlagSupported does not occur for other distros/binutils,. It is passing the same options to linkerFlagSupported on another system I tried.

@laboger Thanks.  Working on a patch.


New Release with commits from 2020

UIPasteboardOption.expirationDate is deprecated. Please create a new release with the recent commits. Thanks

I will see If I manage to make some time to take a look on this repo.


API Project

Laura please check.

left you some changes, please address them as there are more

I am merging it but we may want to re-examine afterwards


Cannot read property hasAttribute of undefined

this.$dialog.notify.info("Test notification", {
        position: "top-right",
        timeout: 5000
      });

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

Hi, @wimil, this bug is in vuetify 2.3.5, I already opened issue: https://github.com/vuetifyjs/vuetify/issues/11903, and the fixed it and will be at next version, just temporary rollback to 2.3.4


[NearestNeighbors] Avoid changing the signature of "_fit" and move kneighbor API to the model class

Revised the PR.
The revised version got run_test.sh tested and all tests passed. Also got "pytest -ra --runslow --durations=10 tests" tested and all tests passed.

Finished the 2nd round revision on the PR.
Got run_test.sh tested and all tests passed.

@eordentlich Thanks! I have just fixed the typo and the wording.

Make sure run_tests.sh still passes before merging.
👍

Yeah. run_tests.sh had been passed. I just rebased and run_tests.sh got passed again with no problem. Need approval again because of the rebase.


The Open Changes button not displayed as disabled for files without any changes

VSCode Version: 1.12.1
OS Version: OS X EI Capitan 10.11.3
Steps to Reproduce:

Open some project from GitHub.
Open a file A.cs which has no fresh changes at all.
Stay on the editor of A.cs, and notice the button of Open Changes on the top right corner above the editor doesn't display as disbled! Clicking it has no effect of course, but it should display as disable in this case just like what in the old versions.

Can't fix without #21131, closing for now.

since it connot be fixed without #21131, should this be kept open and linked to #21131 then?

Sure.

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.
Thanks for your understanding. Happy coding!

Hoping to re-open this because I got this as a feedback item from a few CS educators. They notice their students clicking it accidentally and being confused when there is no apparent action.

I think this has regressed, I now miss this button when a file is staged.

Fixed regression with https://github.com/microsoft/vscode/commit/323237921b889eaedb02d4a58af2d766bde59ce7

There is another regression (#131739), so I will be reverting this fix for this, and will refactor it.


[flutter_tools] remove getFlutterRoot usage in test

Fixes https://github.com/flutter/flutter/issues/120284

We're using a memory file system and creating the files ourselves, so getFlutterRoot is pointless


added Dockerfiles

This PR adds the docker file, requirements, and setup files to be needed to run docker.

Wrong PR.


sectionList sticky section header not recalculate position when rerender

[ ] Review the documentation: https://facebook.github.io/react-native
[ ] Search for existing issues: https://github.com/facebook/react-native/issues
[ ] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment:
OS: macOS High Sierra 10.13.5
Node: 9.4.0
npm: 5.6.0
Android
Packages: (wanted => installed)
react: 16.4.0
react-native: 0.55.2
Description
First step： scroll the list
Second Step: rerender the list
the sectionList  section header keep relative position with list , not in the section in the head 。
Then scrolled, back to normal

who can resolve it?