Add Clarifications to Use This Template in the README

Description
This PR is to make the process of using this template smoother for beginners in open source. It added details and clarifications. What have done here:
Details and Clarifications:

Added steps to clarify where and how to work on progress track.
Added code examples to clone, create a branch, commit, and push changes from local to remote environment.
Added steps to update the Table of Contents.
Update the headings and the wordings.

New:

Added a section about creating a new repository using the template.
Added link to the Markdown basic syntax docs.

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[ ] 🐛 Bug Fix
[x] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
Closes #7

Mobile & Desktop Screenshots/Recordings

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[x] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

@BekahHW this PR is ready for review.
But I threw a couple of question here.
Please let me know if I should fix anything before it merges.
Thank you! 😀


Renders pile on top of each other when navigating between screens on iOS

Issue
When navigating back and forth between screens (using React Navigation), new layers of the Canvas contents are rendered on top of the previous layer.
Reproduction
(the blurred element becomes increasingly dominant)
https://user-images.githubusercontent.com/11300079/152666148-dba0ce8b-1059-46f2-b4d1-45a209c7d5c3.mov
The component
import React  from 'react';
import { Pressable } from 'react-native';
import {
  Canvas,
  Paint,
  LinearGradient,
  vec,
  BlurMask,
  RoundedRect,
  Group,
} from "@shopify/react-native-skia";

const SkiaCategoryMEMO = ({onPress}) => {
  console.log('[skiaCategoryMEMO]: render')

  return (
    <Pressable
      onPress={onPress}
      style= {{
        marginVertical:2,
        width: 115,
        height: 145,
        alignItems: 'center',
        justifyContent:'center',
    }}>
      <Canvas
        style={{
          flex: 1,
          width: 125,
          height: 120}} >

        <Paint>
        <BlurMask sigma={20} style="outer" />
          <LinearGradient
            start={vec(60, 0)}
            end={vec(256, 120)}
            colors={['white', "black"]}
          />
        </Paint>
        <RoundedRect
            x={10}
            y={12}
            width={105}
            height={120}
            rx={25}
          />
        <Group>
          <Paint>
            <LinearGradient
              start={vec(0, 0)}
              end={vec(60, 60)}
              colors={['white', '#EBECF0']}
            />
          </Paint>
        <RoundedRect
            x={10}
            y={12}
            width={105}
            height={120}
            rx={25}
          />
      </Group>

      </Canvas>
    </Pressable>
  );
};

export default React.memo(SkiaCategoryMEMO)

Platform

[ ] Android
[x] iOS
[ ] Web

Environment

package
version

react-native
0.67.2

@shopify/react-native-skia
0.1.103 alpha

Yeah, that's a common problem using React Navigation - have you tried enabling react-native-screens? It removes previous views from being rendered when they're not visible in the navigation stack. We've successfully testet previous versions of react-native-skia with this and verified that views will stop animating and rendering when removed.

@chrfalch To my knowledge, React Navigation v6 should enable  react-native-screens by default. However, actually disabling react-native-screens on the Bottom Tabs Navigator by adding detatchInactiveScreens={false} as a parameter, solved the issue. I am not sure how viable the solution is as it disables memory optimizations, but it seems to be a workaround for now.

Update: the issue persists when navigating through the Stack Navigator screens.

@m2llar we would be interested to investigate it further. Our example app is using react-navigation. Could you add a small example that would reproduce the issue? It would be extremely helpful to understand how to reproduce the bug.

@wcandillon  Hi, I will aim to provide an example for the reproduction of the bug within the next few days.  Sorry for a late-ish reply! :)

Hi @m2llar - we're still interested in a small project that shows this behaviour for testing purposes, so I you have the opportunity we'd be super happy!

Hi @wcandillon  & @chrfalch, apologies for not getting back earlier. Really appreciate the work you guys are doing!!
Here's the example which  is condensed into a single App.js file.
It showcases the rendering behaviour with
(1) @react-navigation/bottom-tabs (switching back and forth between tabs);
(2) @react-navigation/native-stack (pressing on the SkiaContainer).
For bottom-tabs, detatchInactiveScreens={false} solves the issue, however, the solution is not ideal as it affects the screen transition animations.
Reproduction
App.js
import React from 'react';
import { Text, View, Pressable, StyleSheet} from 'react-native';
import { NavigationContainer } from '@react-navigation/native';
import { createBottomTabNavigator } from '@react-navigation/bottom-tabs';
import { createNativeStackNavigator } from '@react-navigation/native-stack';
import {
  Canvas,
  Paint,
  LinearGradient,
  vec,
  BlurMask,
  RoundedRect,
  Group,
} from '@shopify/react-native-skia';
import { useNavigation } from '@react-navigation/core';

const SkiaContainer = () => {
  const navigation = useNavigation();
  const onPress = () => navigation.navigate('Container');

  return (
    <Pressable
      onPress={onPress}
      style={styles.pressable}>
      <Canvas
        style={styles.canvas} >

        <Paint>
          <BlurMask blur={50} style="outer" />
          <LinearGradient
            start={vec(60, 0)}
            end={vec(256, 120)}
            colors={['white', 'black']}
          />
        </Paint>
        <RoundedRect
          x={10}
          y={12}
          width={105}
          height={120}
          r={25}
        />
        <Group>
          <Paint>
            <LinearGradient
              start={vec(0, 0)}
              end={vec(60, 60)}
              colors={['white', '#EBECF0']}
            />
          </Paint>
          <RoundedRect
            x={10}
            y={12}
            width={105}
            height={120}
            r={25}
          />
        </Group>

      </Canvas>
    </Pressable>
  );
};

const Stack = createNativeStackNavigator();

function HomeScreen() {
  return (
    <SkiaContainer />
  );
}

function ContainerScreen() {
  return (
    <View style={styles.screen}>
      <Text>Further details</Text>
    </View>
  );
}

function HomeStack() {
  return (

      <Stack.Navigator screenOptions={{headerShown: false}}>
        <Stack.Screen name="HomeStack" component={HomeScreen} />
        <Stack.Screen name="Container" component={ContainerScreen} />
      </Stack.Navigator>

  );
}

function SettingsScreen() {
  return (
    <View style={styles.screen}>
      <Text>Settings tab</Text>
    </View>
  );
}

const Tab = createBottomTabNavigator();

export default function App() {
  return (
    <NavigationContainer>
      <Tab.Navigator>
        <Tab.Screen name="Home" component={HomeStack} />
        <Tab.Screen name="Settings" component={SettingsScreen} />
      </Tab.Navigator>
    </NavigationContainer>
  );
}

const styles = StyleSheet.create({
  screen: {
    flex:1,
    justifyContent:'center',
    alignItems:'center',
  },
  pressable: {
    width:400,
    height:400,
    alignItems:'center',
    justifyContent:'center',
  },
  canvas: {
    width:130,
    height:150,
    alignItems:'center',
    justifyContent:'center',
  },
});

Platform

[ ] Android
[x] iOS
[ ] Web

Environment

package
version

react-native
0.67.4

@shopify/react-native-skia
0.1.108 alpha

@react-navigation/native
6.5.2

@react-navigation/bottom-tabs
6.2.0

@react-navigation/native-stack
6.5.2

@react-native-safe-area-context
4.2.2

@react-native-screens
3.13.1

Hi @wcandillon  & @chrfalch, apologies for not getting back earlier. Really appreciate the work you guys are doing!!
Here's the example which  is condensed into a single App.js file.
It showcases the rendering behaviour with
(1) @react-navigation/bottom-tabs (switching back and forth between tabs);
(2) @react-navigation/native-stack (pressing on the SkiaContainer).
For bottom-tabs, detatchInactiveScreens={false} solves the issue, however, the solution is not ideal as it affects the screen transition animations.
Reproduction
App.js
import React from 'react';
import { Text, View, Pressable, StyleSheet} from 'react-native';
import { NavigationContainer } from '@react-navigation/native';
import { createBottomTabNavigator } from '@react-navigation/bottom-tabs';
import { createNativeStackNavigator } from '@react-navigation/native-stack';
import {
  Canvas,
  Paint,
  LinearGradient,
  vec,
  BlurMask,
  RoundedRect,
  Group,
} from '@shopify/react-native-skia';
import { useNavigation } from '@react-navigation/core';

const SkiaContainer = () => {
  const navigation = useNavigation();
  const onPress = () => navigation.navigate('Container');

  return (
    <Pressable
      onPress={onPress}
      style={styles.pressable}>
      <Canvas
        style={styles.canvas} >

        <Paint>
          <BlurMask blur={50} style="outer" />
          <LinearGradient
            start={vec(60, 0)}
            end={vec(256, 120)}
            colors={['white', 'black']}
          />
        </Paint>
        <RoundedRect
          x={10}
          y={12}
          width={105}
          height={120}
          r={25}
        />
        <Group>
          <Paint>
            <LinearGradient
              start={vec(0, 0)}
              end={vec(60, 60)}
              colors={['white', '#EBECF0']}
            />
          </Paint>
          <RoundedRect
            x={10}
            y={12}
            width={105}
            height={120}
            r={25}
          />
        </Group>

      </Canvas>
    </Pressable>
  );
};

const Stack = createNativeStackNavigator();

function HomeScreen() {
  return (
    <SkiaContainer />
  );
}

function ContainerScreen() {
  return (
    <View style={styles.screen}>
      <Text>Further details</Text>
    </View>
  );
}

function HomeStack() {
  return (

      <Stack.Navigator screenOptions={{headerShown: false}}>
        <Stack.Screen name="HomeStack" component={HomeScreen} />
        <Stack.Screen name="Container" component={ContainerScreen} />
      </Stack.Navigator>

  );
}

function SettingsScreen() {
  return (
    <View style={styles.screen}>
      <Text>Settings tab</Text>
    </View>
  );
}

const Tab = createBottomTabNavigator();

export default function App() {
  return (
    <NavigationContainer>
      <Tab.Navigator>
        <Tab.Screen name="Home" component={HomeStack} />
        <Tab.Screen name="Settings" component={SettingsScreen} />
      </Tab.Navigator>
    </NavigationContainer>
  );
}

const styles = StyleSheet.create({
  screen: {
    flex:1,
    justifyContent:'center',
    alignItems:'center',
  },
  pressable: {
    width:400,
    height:400,
    alignItems:'center',
    justifyContent:'center',
  },
  canvas: {
    width:130,
    height:150,
    alignItems:'center',
    justifyContent:'center',
  },
});

Platform

[ ] Android
[x] iOS
[ ] Web

Environment

package
version

react-native
0.67.4

@shopify/react-native-skia
0.1.108 alpha

@react-navigation/native
6.5.2

@react-navigation/bottom-tabs
6.2.0

@react-navigation/native-stack
6.5.2

@react-native-safe-area-context
4.2.2

@react-native-screens
3.13.1

Thanks so much for providing us with this example - will test it a bit later.
The only thing I'm thinking of (before testing it) is the fact that you are not clearing/filling the screen with any colour - and the Skia Canvas renders as transparent as default (to be able to co-exist with other React Native Views with transparency). Could you try first to add the <Fill color="white" /> component in the Canvas and see if this solves anything?

Thank you for testing it out!
The fill colour really only provides a cosmetic fix, which is probably fine for most use cases. However, when rendering a bunch of those elements, the performance also seems to be impacted because of the piling. Say the application has a Flatlist/map of those items, if the user navigates back and forth, the experience gradually worsens.

After measuring what's going on it is clear that there are no extra views rendered on top of each other - the problem is purely cosmetic and caused by React Native Screens handling stopping/starting rendering of views that have been removed - and the view does have a transparent background.
When adding some logging we can see what's happening, this is the output when going to the settings tab from the home tab and back:
2022-03-27 19:59:16.426898+0200 RNSkia[76909:8142356] RNSkDrawView::~RNSkDrawView <- clicking Settings
2022-03-27 19:59:17.408502+0200 RNSkia[76909:8142356] RNSkDrawView::RNSkDrawView <- Clicking Home
2022-03-27 19:59:17.408820+0200 RNSkia[76909:8142356] RNSkDrawView::setNativeId - 1000

So first the Skia view is removed (by React Native Screens), then the view is recreated and the same ID is set (meaning that it represents the same view as the previous time it was visible - and hence keeps the state it had.
So from my point of view this seems to be working as designed :)

After measuring what's going on it is clear that there are no extra views rendered on top of each other - the problem is purely cosmetic and caused by React Native Screens handling stopping/starting rendering of views that have been removed - and the view does have a transparent background.
When adding some logging we can see what's happening, this is the output when going to the settings tab from the home tab and back:
2022-03-27 19:59:16.426898+0200 RNSkia[76909:8142356] RNSkDrawView::~RNSkDrawView <- clicking Settings
2022-03-27 19:59:17.408502+0200 RNSkia[76909:8142356] RNSkDrawView::RNSkDrawView <- Clicking Home
2022-03-27 19:59:17.408820+0200 RNSkia[76909:8142356] RNSkDrawView::setNativeId - 1000

So first the Skia view is removed (by React Native Screens), then the view is recreated and the same ID is set (meaning that it represents the same view as the previous time it was visible - and hence keeps the state it had.
So from my point of view this seems to be working as designed :)

This has been fixed part of 0.1.120


Upgrade to yaml v3

One less dependency to manage.

Upon further review, this would be a risky change to merge. The reason being is that the yaml library is no longer maintained. Kubernetes is looking into forking it, but until then, this would be a breaking change.
Here's why: v2 serializes an object such as:
array:
- map
    key1: value1

While v3 would serialize the same object as:
array:
  - map
      key1: value1

Both are valid YAML and there is no way to customize this on the library-level.
If the user does absolutely nothing, this may break a user's scraping completely. For example, if this change brings the user's config over the 1 MiB limit for ConfigMaps, the user will have to enable compression if they even realize their scraping broke.


Bionic LTS upgrade breaks LXD due to apparmor missing

Hello
Upgraded today on a test system from Ubuntu 16.04 LTS to 18.04 LTS using the recommended upgrade guide link
LXD version before upgrade: 2.21 after upgrade: 3.0.0
I noticed during the upgrade that it removed apparmor. After succesful system upgrade and a reboot, I cannot start my containers and the log shows:
Name: testdukat
Remote: unix://
Architecture: x86_64
Created: 2018/04/26 12:52 UTC
Status: Stopped
Type: persistent
Profiles: webdockssd50

Log:

lxc<PHONE_NUMBER>0532.366 ERROR    lxc_lsm - lsm/lsm.c:lsm_process_label_set_at:167 - No such file or directory - Failed to set AppArmor label "lxc-container-default-cgns"
lxc<PHONE_NUMBER>0532.366 ERROR    lxc_apparmor - lsm/apparmor.c:apparmor_process_label_set:243 - No such file or directory - Failed to change apparmor profile to lxc-container-default-cgns
lxc<PHONE_NUMBER>0532.366 ERROR    lxc_sync - sync.c:__sync_wait:57 - An error occurred in another process (expected sequence number 5)
lxc<PHONE_NUMBER>0532.437 ERROR    lxc_container - lxccontainer.c:wait_on_daemonized_start:824 - Received container state "ABORTING" instead of "RUNNING"
lxc<PHONE_NUMBER>0532.437 ERROR    lxc_start - start.c:__lxc_start:1866 - Failed to spawn container "testdukat"
lxc<PHONE_NUMBER>0532.449 WARN     lxc_commands - commands.c:lxc_cmd_rsp_recv:130 - Connection reset by peer - Failed to receive response for command "get_cgroup"

Is this just a matter of waiting till apparmor releases compatible packages for 18.04 ?

We had a similar report before. I'm not sure why apparmor would get removed from your system on upgrade, this seems like a potential security problem...
I'd recommend you file a bug at https://launchpad.net/ubuntu/+source/apparmor/+filebug to track down why apparmor is getting removed.
As for LXD, the other reporter was able to fix things with:

sudo apt install apparmor
systemctl restart lxd

The next LXD upload to Ubuntu will add a Recommends of apparmor to the package, hoping this may somehow prevent this from happening until someone figures out why apparmor is getting removed for some users.

Closing as not a LXD issue by itself, apparmor comes with ubuntu-standard, neither of those packages should get removed on upgrade...

@stgraber Ok yeah that is interesting indeed. Especially since this was a completely vanilla 16.04 install which I made just today to test this upgrade path. As in, completely up to date, and no weird config before upgrading. So this should be easily reproducible.
I can confirm that after reinstalling apparmor and restarting the daemon my containers come up immediately (impressively fast - love it!)
I'll file a report with apparmor :+1:

@Kramerican how did you do the upgrade? Was that with do-release-upgrade?

@stgraber Yes I did a do-release-upgrade -d as indicated on wiki.ubuntu.com

Just did an upgrade test with a clean 16.04 with LXD 2.0.11, resulting upgrade still had apparmor installed.
Repeated this time with LXD 2.21 from backports, same result, apparmor still present post upgrade.
Any extra details on what could have caused a different result for you?

That is ... Interesting. All I can think of is that the base system is set up using Hetzners (hetzner.de) Ubuntu 16.04 minimal image. They might have messed around with the base image - although my impression was that their image was squeaky-clean.
I really have no explanation for this. Looking at the packages we install post-base system install, I see we are not installing apparmor, so it is already present in the Hetzner image.
In any case, let's hope this issue can help others who might run into the same.

Does that base image come with ubuntu-standard installed? If not, I can see how the upgrade script may remove some of those packages.

Just run into the same, upgrading from a completely vanilla 16.04.4 to 18.04, I had to do 'do-release-upgrade -d' to get it to actually upgrade though.
Glad this issue is here or I would have been chasing it forever.


upload image

When running the 'upload_logo' request from the folder, I encounter an error. However, the request works fine when run individually.
I expected the 'upload logo' request should work the same way when run from the folder as it does individually.
The error message I receive when running the request from the folder is "TypeError: Cannot read properties of undefined (reading 'value')"
Screenshots for more context:
When running the request individually it works fine.

But if I run the request by running from the folder, I get an error.

This is the error I got.

This is what I set in the body of the request.

I'm not sure whether this issue is due to a bug or if I made an error in my setup. Any guidance or suggestions would be greatly appreciated.

Hey @Imran2805,
Thank you for reporting this bug. However, I don't think it's caused by Bruno. I noticed that you've added the value (which is the image in this case) without a key. Could you please provide a key for the value and try again?
PS: If this resolves your issue, kindly close this.

This might help with testing multipart form image upload:
Sample .bru:
meta {
  name: abc
  type: http
  seq: 7
}

post {
  url: https://api.upload.io/v1/files/form_data
  body: multipartForm
  auth: bearer
}

auth:bearer {
  token: free
}

body:multipart-form {
  fileKey: @file(C:\Users\codex\Downloads\wallpaper.png)
}

I've made some changes to match exactly like the sample but still show the same error. I did add some tests in the test section, for example checking the status code, etc.
However, when the tests section of the request is empty, I can run the request from the folder perfectly fine with no error and getting the '200 OK' status, but just without any tests to validate the responses.

Hey @Imran2805,
I think I understand your issue better now. Since you have tests with errors, your responses are also breaking. I was able to reproduce that as well. We will update a fix for this.
PS: For now, to get your request running, try fixing your test script first.

Hi @Imran2805,
Would you be able to share the collection that’s causing this issue? It would help us better understand the exact problem you’re encountering. Please feel free to send it over after removing any sensitive information.
Thanks!

Hi @anusree-bruno,
test.zip
My issue is when I run the test folder that has the request shows this error,  '(request failed)
TypeError: Cannot read properties of undefined (reading 'value')'. However, when running the request individually instead of running the folder the error is no longer there.

Hi @Imran2805,
Thanks for sharing the request! Could you check if there are any folder-level scripts or tests? It’s possible they might be failing, which could be causing this issue. Let me know!

Hi @anusree-bruno,
There isn't any folder-level scripts or tests, its empty.


Add DescribeDBClusters permission for inspec

Add the rds:DescribeDBClusters permission to the inspec user, running continuous guardrails scanning.
Will send a PR soon to the other repository, listing database clusters and making sure that deletion protection is always enabled. Submitting this PR in advance to make sure we have the required permissions when the CI will be updated.
This is an incident action item.

Previous PR was https://github.com/cds-snc/notification-terraform/pull/147


[Technical Question] How to add a new certificate authority using this SDK ?

Hello,
I've been searching on how to provision a new certificate authority using the SDK.
I don't see any mentions of this point in the documentation here or in Azure, is this a planned feature or impossible to do ?
I'm using the certificate authority to authenticate all the device I run on my IoTHubs and I need to update it at some point.
I'm searching for an automated way of doing it.
Thanks for you help !

We do not yet support this feature. Right now, you would have to shut down the client, and make a new client with the new certificate authority.
We do plan to support this in the future however, and have scheduled implementation for this feature in the next few months.

Management Plane Carter mis-spoke above.  To accomplish adding a CA you want to use the linked management plane SDK.


Cannot import character sheet | "Cannot set properties of undefined (setting 'type')"

Describe the bug
I'm currently trying to import a character into Foundry. This character has been imported before, but once I updated to 3.4.75 I've encountered an error stating that it "Cannot set properties of undefined (setting 'type'). I've turned off all modules and it still shows up. Other characters can be imported just fine and when I try to make a new actor for this sheet, I get the same error.
I assume this an error with the character sheet itself or data in the world, but any help could be appreciated.
To Reproduce
Steps to reproduce the behavior:

Go to the character sheet on DDB and obtain the URL
Return to Foundry and go through the process of importing a character with a new actor on
Set the settings to the preferred method and click 'Start Import'
The Resource Selection will appear, any button click will show the error
See the error

Expected behavior
As I've stated this character sheet never used to give me issues and I haven't added anything to it since I first imported it into Foundry. I expected the import to go smoothly, but everything I try doesn't help.
Screenshots

Environment:

Chrome
Foundry Version 11.311
5e System Version 2.3.1
Module Version 3.4.75
Does this behaviour occur with other modules disabled: Yes

Additional context
Add any other context about the problem here.

Here's a link the character sheet:
https://www.dndbeyond.com/characters/91519651

THis is due to the renaming of Waterskin to Waterbottle, and there are some special rules applied to the parsing of Waterskins. A fix is in the next release out this weekend.


Can't get all tokens

Code is:
from dotenv import load_dotenv
import os

from pathlib import Path
from pprint import pprint

from uniswap import Uniswap

env_path = Path('.') / '.env'
load_dotenv(dotenv_path=env_path)

ADDRESS = os.getenv("ADDRESS")
PRIVATE_KEY = os.getenv("PRIVATE_KEY")

uniswap_wrapper = Uniswap(ADDRESS, PRIVATE_KEY, version=1)

eth = "0x0000000000000000000000000000000000000000"
bat = "0x0D8775F648430679A709E98d2b0Cb6250d2887EF"
dai = "0x89d24A6b4CcB1B6fAA2625fE562bDD9a23260359"

pprint(uniswap_wrapper.get_all_tokens())

Error:
uniswap.uniswap.InvalidToken: Invalid token address: 0x9f8F72aA9304c8B593d555F12eF6589cC3A579A2

The get_all_tokens method isn't really supported (it accidentally slipped into a commit) and I have no plans to make it work reliably.
Most likely the contract at that address doesn't follow the ERC20 spec. If you turn on logging you should get better output:
import logging
logging.basicConfig(level=logging.INFO)

I'm sorry to say it, but you're on your own. Feel free to submit a PR if you fix it.


config: resmon: simplify excludelist

Remove the nested excludelist structure: a simpler type alias is sufficient. Besides the internal API change, no intended change of behavior. The tests will ensure so.
Depends on #122

LGTM


New SAM CLI

This workshop is not working with the new AWS SAM introduced at AWS re:Invent 2020.
It would also be nice to have the workshop rewritten to support the new CDK Pipelines construct.

Hi @imyrvold , thanks for creating this issue. We have updated the instructions according to the new SAM CLI. Can you please confirm if this is what you are referring to?
You can check out the updated instructions here: https://cicd.serverlessworkshops.io/javascript/sam/init.html


Atlassian Confluence Audit (Preview) and Atlassian Jira Audit (Preview) not working

Describe the bug
I have deployed both azure cloud functions for Atlassian Confluence Audit (Preview) and Atlassian Jira Audit (Preview) but unfortunatelly the data isn't being picked up by Azure Sentinel.
Is this known ? Is someone working on the problem already ?
To Reproduce
Steps to reproduce the behavior:

Go to 'Azure Sentinel | Data connectors'
Click on 'Atlassian Confluence Audit (Preview) or Atlassian Jira Audit (Preview)'
Follow the instructions and Install
See the strange behaviour of not uploading to Azure Sentinel any data even when the function isn't failing.

Expected behavior
To be able to follow the installation instructions and to have it working :).
Screenshots

Additional context
Jira:
2021-07-06T17:40:01Z   [Information]   Starting program 2021-07-06T17:40:01Z   [Information]   Request URL: 'https://jiraauditasaos6pfikrhq.file.core.windows.net/funcstatemarkershare/funcstatemarkerfile' 2021-07-06T17:40:01Z   [Information]   Request method: 'GET' 2021-07-06T17:40:01Z   [Information]   Request headers: 2021-07-06T17:40:01Z   [Information]       'Accept': 'application/xml' 2021-07-06T17:40:01Z   [Information]       'x-ms-version': 'REDACTED' 2021-07-06T17:40:01Z   [Information]       'x-ms-range': 'REDACTED' 2021-07-06T17:40:01Z   [Information]       'User-Agent': 'azsdk-python-storage-file-share/12.3.0 Python/3.8.10 (Linux-5.4.81-microsoft-standard-x86_64-with-glibc2.2.5)' 2021-07-06T17:40:01Z   [Information]       'x-ms-date': 'REDACTED' 2021-07-06T17:40:01Z   [Information]       'x-ms-client-request-id': '2fe3bf8a-de81-11eb-aabf-00155daab4e0' 2021-07-06T17:40:01Z   [Information]       'Authorization': 'REDACTED' 2021-07-06T17:40:01Z   [Information]   No body was attached to the request 2021-07-06T17:40:01Z   [Information]   Response status: 206 2021-07-06T17:40:01Z   [Information]   Response headers: 2021-07-06T17:40:01Z   [Information]       'Content-Length': '20' 2021-07-06T17:40:01Z   [Information]       'Content-Type': 'application/octet-stream' 2021-07-06T17:40:01Z   [Information]       'Content-Range': 'REDACTED' 2021-07-06T17:40:01Z   [Information]       'Last-Modified': 'Tue, 06 Jul 2021 17:30:00 GMT' 2021-07-06T17:40:01Z   [Information]       'Accept-Ranges': 'REDACTED' 2021-07-06T17:40:01Z   [Information]       'ETag': '"0x8D940A3AE8B30D1"' 2021-07-06T17:40:01Z   [Information]       'Server': 'Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0' 2021-07-06T17:40:01Z   [Information]       'x-ms-request-id': '8f12fa97-801a-002a-4a8d-72fd75000000' 2021-07-06T17:40:01Z   [Information]       'x-ms-client-request-id': '2fe3bf8a-de81-11eb-aabf-00155daab4e0' 2021-07-06T17:40:01Z   [Information]       'x-ms-version': 'REDACTED' 2021-07-06T17:40:01Z   [Information]       'x-ms-type': 'REDACTED' 2021-07-06T17:40:01Z   [Information]       'x-ms-server-encrypted': 'REDACTED' 2021-07-06T17:40:01Z   [Information]       'x-ms-lease-status': 'REDACTED' 2021-07-06T17:50:00Z   [Information]   Executing 'Functions.JiraAuditAPISentinelConnector' (Reason='Timer fired at 2021-07-06T17:50:00.0054282+00:00', Id=80638a37-93a6-4ce5-9417-0f6e314c595f)
Confluence:
2021-07-06T16:30:00Z   [Information]   Starting program 2021-07-06T16:30:00Z   [Information]   Request URL: 'https://conflauditybvqggfho66me.file.core.windows.net/funcstatemarkershare/funcstatemarkerfile' 2021-07-06T16:30:00Z   [Information]   Request method: 'GET' 2021-07-06T16:30:00Z   [Information]   Request headers: 2021-07-06T16:30:00Z   [Information]       'Accept': 'application/xml' 2021-07-06T16:30:00Z   [Information]       'x-ms-version': 'REDACTED' 2021-07-06T16:30:00Z   [Information]       'x-ms-range': 'REDACTED' 2021-07-06T16:30:00Z   [Information]       'User-Agent': 'azsdk-python-storage-file-share/12.3.0 Python/3.8.10 (Linux-5.4.81-microsoft-standard-x86_64-with-glibc2.2.5)' 2021-07-06T16:30:00Z   [Information]       'x-ms-date': 'REDACTED' 2021-07-06T16:30:00Z   [Information]       'x-ms-client-request-id': '68765092-de77-11eb-a2ae-00155d0e03a4' 2021-07-06T16:30:00Z   [Information]       'Authorization': 'REDACTED' 2021-07-06T16:30:00Z   [Information]   No body was attached to the request 2021-07-06T16:30:00Z   [Information]   Response status: 206 2021-07-06T16:30:00Z   [Information]   Response headers: 2021-07-06T16:30:00Z   [Information]       'Content-Length': '20' 2021-07-06T16:30:00Z   [Information]       'Content-Type': 'application/octet-stream' 2021-07-06T16:30:00Z   [Information]       'Content-Range': 'REDACTED' 2021-07-06T16:30:00Z   [Information]       'Last-Modified': 'Tue, 06 Jul 2021 16:20:00 GMT' 2021-07-06T16:30:00Z   [Information]       'Accept-Ranges': 'REDACTED' 2021-07-06T16:30:00Z   [Information]       'ETag': '"0x8D94099E73FEB6A"' 2021-07-06T16:30:00Z   [Information]       'Server': 'Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0' 2021-07-06T16:30:00Z   [Information]       'x-ms-request-id': 'f13344cd-c01a-002b-7484-7257d3000000' 2021-07-06T16:30:00Z   [Information]       'x-ms-client-request-id': '68765092-de77-11eb-a2ae-00155d0e03a4' 2021-07-06T16:30:00Z   [Information]       'x-ms-version': 'REDACTED' 2021-07-06T16:30:00Z   [Information]       'x-ms-type': 'REDACTED' 2021-07-06T16:30:00Z   [Information]       'x-ms-server-encrypted': 'REDACTED' 2021-07-06T16:30:00Z   [Information]   Logs not founded. Time period: from 2021-07-06T16:10:00Z to 2021-07-06T16:19:00Z. 2021-07-06T16:20:00Z   [Information]   Executing 'Functions.ConfluenceAuditAPISentinelConnector' (Reason='Timer fired at 2021-07-06T16:20:00.0068173+00:00', Id=fee6a8e0-351e-453b-a8a3-b6f193eb475e)

Getting error 'extend' operator: Failed to resolve table or column expression named 'Jira_Audit_CL'
If issue persists, please open a support ticket. Request id: 8dcb27fd-3ec4-4702-9121-eccf61503e93
when we try to run the parser based kusto function called ConfluenceAudit

This data connector depends on a parser based on a Kusto Function to work as expected. Please create the Kusto functions alias, Jira_Audit : https://raw.githubusercontent.com/Azure/Azure-Sentinel/master/Parsers/JiraAudit/JiraAudit
Confluence_Audit : https://raw.githubusercontent.com/Azure/Azure-Sentinel/master/Parsers/ConfluenceAudit/ConfluenceAudit.txt

Got it to work. Not sure what has been changed but managed to receive data into the connector.


Typos

Thanks for all these! I assume there are more coming?

Richard Zach writes:

Thanks for all these! I assume there are more coming?

Not for the moment.

Not for the moment.


[Idea: ScrollView] Add getScrollResponder to ScrollView for composition

This is a proposal to add getScrollResponder to all ScrollView-like components, including ListView. This allows multiple higher-order scroll views to be composed while allowing the owner of the top-level scroll view to call scrollableView.getScrollResponder().scrollTo(...) regardless of whether scrollableView is a ScrollView, ListView, InvertedScrollView, etc.

I think I need a little more context about how this is used. Do you have an example implementation you can point me to?

I'll start with some background to paint a complete picture: I'm building "higher-order" scroll views that have some extra functionality. For example, an infinite scroll view invokes a callback to fetch more data when the scroll position approaches the end. This could look like:
class InfiniteScrollView extends React.Component {
  scrollTo(destY, destX) {
    this.refs.scrollView.scrollTo(destY, destX);
  }

  render() {
    return (
      <ScrollView
        {...this.props}
        ref="scrollView"
        onScroll={(event) => {
          if (this._shouldLoadMoreContent(event)) {
            this.props.onLoadMore();
          }
        }}>
        {this.props.children}
      </ScrollView>
    );
  }
}
// * this could be a mixin, but there are other advanced scroll views that require
// a new component class

Now I'd like to use a different kind of scroll view, like a ListView, ReversedScrollView, etc. so I add a prop like this.props.scrollViewClass and use to create the component returned from render(). This works well and so far I'm happy with the flexibility from this style of composition.
The one snag is implementing methods like getInnerViewNode, scrollTo, and scrollWithoutAnimationTo. In the core classes, these methods are implemented only on ScrollView, while ListView defines getScrollResponder() which returns the underlying ScrollView. So I came up with two approaches:

Implement getScrollResponder() on every ScrollView-like component class. This lets you get the underlying ScrollView and then you can call scrollTo, etc. on it. By adding this method to ScrollView itself, you can indiscriminately call scrollComponent.getScrollResponder().scrollTo(0, 0) regardless of the actual type of the scrollable component. This PR implements this approach.

Implement scrollTo, scrollWithoutAnimationTo, and getInnerViewNode on every ScrollView-like component class. This makes it convenient to call scrollComponent.scrollTo(0, 0) regardless of the scroll component's type. This is implemented in #755.

I prefer the first approach because if ScrollView's methods are added/removed/renamed, the code for all other scrollable components doesn't need to be updated. It's a little more verbose with the getScrollResponder() call but I believe that can be papered over with a mixin.
ScrollableMixin = {
  scrollTo(destY, destX) {
    invariant(this.getScrollResponder, 'Scrollable components must implement getScrollResponder');
    this.getScrollResponder().scrollTo(destY, destX);
  }
};

Thank you for the detailed explanation. That makes a lot of sense to me. @vjeux?

I add a prop like this.props.scrollViewClass and use it to create the component returned from render()

I've been meaning to do something similar for a while in order to support both iOS and Android specific list views but a single ListView/InfiniteScrollView/RefreshableScrollView...
We've been moving away from passing a class as props to passing a function. This way the call site can pass props and the implementation can cloneElement to pass props as well.
<InfiniteScrollView renderScrollView={() => <ScrollView style={{paddingTop: 50}} />} />

@vjeux good idea with the function. Just wondering, is there a reason the prop takes a function instead of a component instance directly? Maybe how the ref owner is determined?

More about future proofing the api, i can almost guarantee you that you're going to want to pass arguments computed from within the extended scroll view component at some point

Thought about it some more - the function also lets us do nested composition e.g.
<ScrollViewA
  renderScrollView={() =>
    <ScrollViewB renderScrollView={() => <ScrollViewC/ >} />
  }
/>

We have a nice end-to-end test, so not sure if still relevant - @frantic: can you either close out or review if you want it?

Oops, wrong PR.

@facebook-github-bot import


UTXOs tab forgets the sort column

In macOS (Intel) Sparrow 1.7.8, after the application is closed then re-opened, the 'UTXOs' section loses the column sort (the 'Transactions' section remembers the column sort). Each time the user re-opens the application, they must select the appropriate UTXOs column sort. Could you update this so the wallet file remembers the UTXO column sort?

Duplicate of #328.


[libdjinterop] Update to 0.22.1 for 2.4

Cherry picked from https://github.com/microsoft/vcpkg/pull/41251

We are already passed the 2.4.2 and 2.5.0 deadline. This PR requires and update of the macOS build environment requiring a whole world rebuild. Not sure if this is worth the effort or risk.
How important is fixing https://github.com/mixxxdj/mixxx/issues/13695 in 2.4.2?
If we desice for it we need to backport the two CI commits from: https://github.com/mixxxdj/vcpkg/pull/146

All green. That's good. unfortunately we have no experience yet with the macOS update, because the changes are not yet part of the 2.5 beta.
Is this a risk?

Isn't this the same as https://github.com/mixxxdj/mixxx/pull/13296 ? If there is a macOS 12 problem, we're affected in 2.4.2 anyway.


[PowerToys Run] does not respect localisation (can't calculate with decimal comma 3,14*10)

Environment
Windows build number: Microsoft Windows [Version 10.0.18363.904]
PowerToys version: Release v0.19.0
PowerToy module for which you are reporting the bug (if applicable): PowerToys Run
system locale: de;Deutsch (Deutschland)

Steps to reproduce
Try to calc 3,14 * 10
Expected behavior
31,4
Actual behavior
nothing
Screenshots

vs.

+1 on this issue ticket.

Tracked in #3367


Add helper Servlet for Faces in webapps

Pages has one, and it'd be good to do for Faces too.

I've been tinkering with this, but I think it's probably not really worth doing. There's a lot of fiddliness around ClassLoaders that makes it tricky, and realistically what would probably be best would be to have an example webapp that packages MyFaces or Mojarra itself and uses maven-bundle-plugin to make it compatible with Domino.


[Chapter 2] Error: "Module 'urllib' has no attribute 'request'"

For anyone who runs into this problem.
Just add  import urllib.request.

Thanks a lot

Thanks @nguyenhaison1999 . Older versions of Python would automatically import urllib.request when importing urllib, but it's not the case anymore, which is why it's now necessary to import urllib.request instead of urllib.


Automatically add anchor links to header tags

Dgeni automatically adds anchor tags to members and sections in the v2 API docs. Lets automatically add anchor links to all header tags inside docs. This will probably need to be via a Kramdown plugin. The trick is to add this in a way that doesn't break other parts of the site (ID CSS name collision, links in non-docs parts of the site).

@perrygovier, this sounds amazing. I think it would greatly improve the usability of our site. Can we revisit this?
Thanks,
Dan


Add GitHub actions

[x] Run tests
[ ] Deploy project

Created #7 to add the API calls (needed for deployment) in the workflow


feat: trejs starter

Starter for TresJS @sulco

Thanks @alvarosabu! Can't wait to get this one to our platform! 😍


HADOOP-18172: backport of HADOOP-18172 for branch-2.10

Description of PR
backport of HADOOP-18172 for branch-2.10
How was this patch tested?
mvn install -DskipTests

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
11m 20s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.10 Compile Tests _

+1 :green_heart:
mvninstall
17m 25s

branch-2.10 passed

+1 :green_heart:
compile
14m 12s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
compile
11m 18s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
checkstyle
0m 40s

branch-2.10 passed

+1 :green_heart:
mvnsite
1m 17s

branch-2.10 passed

+1 :green_heart:
javadoc
1m 15s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
0m 57s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

-1 :x:
spotbugs
2m 23s
/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html
hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 45s

the patch passed

+1 :green_heart:
compile
13m 19s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javac
13m 19s

the patch passed

+1 :green_heart:
compile
11m 16s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
javac
11m 16s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 35s

the patch passed

+1 :green_heart:
mvnsite
1m 13s

the patch passed

+1 :green_heart:
javadoc
1m 11s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
spotbugs
2m 11s

the patch passed

_ Other Tests _

-1 :x:
unit
10m 33s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

107m 54s

Reason
Tests

Failed junit tests
hadoop.fs.sftp.TestSFTPFileSystem

hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

hadoop.io.compress.TestCompressorDecompressor

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4144

JIRA Issue
HADOOP-18172

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 7ca82a1b867f 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-2.10 / 0db60da461f9132df1a5e33c1bf330766846119b

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Multi-JDK versions
/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/1/testReport/

Max. process+thread count
1761 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@xinglin can you add a comment to why checks are failing.

/patch-unit-hadoop-common-project_hadoop-common.txt

the spotbugs/unit test failures for FTP/compresors have already been there for a while. No new test failures from this patch.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
8m  6s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.10 Compile Tests _

+1 :green_heart:
mvninstall
17m 53s

branch-2.10 passed

+1 :green_heart:
compile
13m 17s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
compile
11m 31s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
checkstyle
0m 42s

branch-2.10 passed

+1 :green_heart:
mvnsite
1m 19s

branch-2.10 passed

+1 :green_heart:
javadoc
1m 24s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
1m  6s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

-1 :x:
spotbugs
2m 33s
/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html
hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 47s

the patch passed

+1 :green_heart:
compile
12m 32s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javac
12m 32s

the patch passed

+1 :green_heart:
compile
11m 36s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
javac
11m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 38s

the patch passed

+1 :green_heart:
mvnsite
1m 16s

the patch passed

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
1m  4s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
spotbugs
2m 20s

the patch passed

_ Other Tests _

-1 :x:
unit
9m 37s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

104m 48s

Reason
Tests

Failed junit tests
hadoop.fs.sftp.TestSFTPFileSystem

hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

hadoop.io.compress.TestCompressorDecompressor

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4144

JIRA Issue
HADOOP-18172

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ad83aeff0fd1 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-2.10 / 98d3adadeeffdb2ae36836b447332b7dca83e1b7

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Multi-JDK versions
/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/2/testReport/

Max. process+thread count
1379 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/2/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.10 Compile Tests _

+1 :green_heart:
mvninstall
17m 48s

branch-2.10 passed

+1 :green_heart:
compile
13m 39s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
compile
11m 36s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
checkstyle
0m 42s

branch-2.10 passed

+1 :green_heart:
mvnsite
1m 23s

branch-2.10 passed

+1 :green_heart:
javadoc
1m 22s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
1m  0s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

-1 :x:
spotbugs
2m 28s
/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html
hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 46s

the patch passed

+1 :green_heart:
compile
12m 35s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javac
12m 35s

the patch passed

+1 :green_heart:
compile
11m 34s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
javac
11m 34s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 36s

the patch passed

+1 :green_heart:
mvnsite
1m 24s

the patch passed

+1 :green_heart:
javadoc
1m 17s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
spotbugs
2m 17s

the patch passed

_ Other Tests _

-1 :x:
unit
9m 28s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

97m 24s

Reason
Tests

Failed junit tests
hadoop.fs.sftp.TestSFTPFileSystem

hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

hadoop.io.compress.TestCompressorDecompressor

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4144

JIRA Issue
HADOOP-18172

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ea3f48a45c53 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-2.10 / 98d3adadeeffdb2ae36836b447332b7dca83e1b7

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Multi-JDK versions
/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/3/testReport/

Max. process+thread count
1390 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/3/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Same unit test failures, due to failures in SFTP/compression related stuffs. these failures are already there. not related with this patch.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.10 Compile Tests _

+1 :green_heart:
mvninstall
17m 41s

branch-2.10 passed

+1 :green_heart:
compile
14m 21s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
compile
11m 31s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
checkstyle
0m 57s

branch-2.10 passed

+1 :green_heart:
mvnsite
1m 37s

branch-2.10 passed

+1 :green_heart:
javadoc
1m 36s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
1m 16s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

-1 :x:
spotbugs
2m 42s
/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html
hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 50s

the patch passed

+1 :green_heart:
compile
13m 19s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javac
13m 19s

the patch passed

+1 :green_heart:
compile
11m 30s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
javac
11m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 32s

the patch passed

+1 :green_heart:
javadoc
1m 38s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
1m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
spotbugs
2m 46s

the patch passed

_ Other Tests _

-1 :x:
unit
11m 11s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 19s

The patch does not generate ASF License warnings.

105m 26s

Reason
Tests

Failed junit tests
hadoop.io.compress.TestCompressorDecompressor

hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

hadoop.fs.sftp.TestSFTPFileSystem

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4144

JIRA Issue
HADOOP-18172

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 8b4cf0bcff82 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-2.10 / b7b1f6d89472ba9eebc0727c863be1eeeff716b0

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Multi-JDK versions
/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/4/testReport/

Max. process+thread count
1512 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/4/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2.10 Compile Tests _

+1 :green_heart:
mvninstall
17m 45s

branch-2.10 passed

+1 :green_heart:
compile
14m  1s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
compile
11m 28s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
checkstyle
1m  9s

branch-2.10 passed

+1 :green_heart:
mvnsite
1m 43s

branch-2.10 passed

+1 :green_heart:
javadoc
1m 46s

branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
1m 27s

branch-2.10 passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

-1 :x:
spotbugs
2m 52s
/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html
hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 55s

the patch passed

+1 :green_heart:
compile
13m 25s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javac
13m 25s

the patch passed

+1 :green_heart:
compile
11m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
javac
11m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

the patch passed

+1 :green_heart:
mvnsite
1m 42s

the patch passed

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

+1 :green_heart:
spotbugs
2m 48s

the patch passed

_ Other Tests _

-1 :x:
unit
9m 43s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m  5s

The patch does not generate ASF License warnings.

105m  2s

Reason
Tests

Failed junit tests
hadoop.fs.sftp.TestSFTPFileSystem

hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

hadoop.util.TestBasicDiskValidator

hadoop.io.compress.TestCompressorDecompressor

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4144

JIRA Issue
HADOOP-18172

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux da3a85423e71 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-2.10 / a3f7683741b96d8ed7d6d5395f0b90d6c0601b5e

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Multi-JDK versions
/usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/5/testReport/

Max. process+thread count
1389 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4144/5/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Failures in the yetus run are not related. Committing this.


Add MARC 610 subjects from Sierra

first indicator 0
-----------------
Concept [-- Concept ]-- Place -- Period
a       [-- b       ]-- c     -- d

first indicator 1 or 2
----------------------
Organisation [-- Concept ]-- Place -- Period
a b          [-- b       ]-- c       -- d

Proposal:
  /* Populate wwork:subjects organisation. Rules:

For all bibliographic records use "marcTag": "610".

Populate platform "label" from "610" concatenated with subfields a", "b", "c", "d", "e"  type as "Subject".

Populate platform "concepts" "label" with subfield "a" and "b" type as "Organisation"

If subfield 0 contains a value use it to populate "identifiers". For orgnisations the "identifierType" will be lc-names.

*{

"subjects": [
{

 "label": "Wellcome Trust, sponsor.",

 "type": "Subject",

 "concepts": [

   {

     "id": "hd2891f",

     "label": "Wellcome Trust.",

     "type": "Organisation",

     "identifiers" : [

         {

         "indentifierType":

            {

            "id" : "lc-names" ,

            "label" : "Library Of Congress Names" ,

               "type" : "IdentifierType"

         } ,

         "value": "n81290903210",

         "type": "Identifier"

         }

   ]

   }

 ]

}
]
*}
*/

This is live! Example here:
https://search.wellcomelibrary.org/iii/encore/record/C__Rb1128518?marcData=Y&lang=eng
https://api.wellcomecollection.org/catalogue/v2/works/ecdebckk?include=identifiers,subjects


maintenance handlers that disable entities should also call notify_topology_update()

Any change on enabled should also call notify_topology_update() since pathfinder relies on the full graph to rebuild it.  For instance, here's a switch being disabled but without notifying kytos/topology.updated through notify_topology_update()

Landed on https://github.com/kytos-ng/topology/pull/136


I candidate myself for LOCALIZATION_CONTRIBUTORS

Summary
Details and comments

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you for your interest in contributing to Qiskit translations. Please go ahead and follow steps 4, 5 and 6 in the Contributing to Qiskit documentation.

@arbiter1elegantiae Please go ahead and follow steps 4, 5 and 6 in the Contributing to Qiskit documentation section.
This PR will be closed if we don't receive joining request in CrowdIn.

@arbiter1elegantiae I don't see your request to join the Qiskit translation project on Crowdin.
Please go ahead and follow steps 4, 5 and 6 in the Contributing to Qiskit documentation.
If we don't receive your request in Crowdin by February 1, 2020, this pull request will be closed and you will need to open a new one.

I see you're waiting for Italian to be added. We are still waiting for a proofreader to volunteer before this project is opened on Crowdin.
Putting this PR on hold
https://github.com/Qiskit/qiskit/issues/600


Add .nasm extension for Assembly files.

There is exactly one file with the .nasm extension hosted ad GitHub, so feel free to close this if it's too insignificant.  On the other hand, Assembly do have "nasm" as an alias and search term, so it's not too far fetched to add the extension.

Ping @arfon @bkeepers
I'll totally close this if you make that call.,

This is now live on github.com.

Thanks! :+1:

Either usage has exploded, or the search index now includes many more .nasm files.
https://github.com/search?q=extension%3Anasm+NOT+slartibartfast


Naming empty blocks and refactoring sessions

Firstly, this project's ideas are really neat! I find that I often start editing code, only to forgot what I was doing. My idea is the ability to name empty sections of code (I know Unison has a word for placeholders, but I forgot it) and refactoring sessions. That would make things a bit easier!

Yes, we will definitely support this stuff in some fashion. I'm going to close this issue for now, though. Feel free to stop by the gitter channel if you have other ideas for stuff. :)


Versioneer is not compatible with Python 3.12

The used Versioneer package uses SafeConfigParser, which was deprecated in Python 3.2 and removed in 3.12.
Please update to the newest version of Versioneer or remove it entirely to be compatible with Python 3.12.

Seconded. For reference, here's an example error when attempting to pull si-prefix with Python 3.12:
Collecting si-prefix==1.2.2 (from videojitter)
  Downloading si-prefix-1.2.2.tar.gz (64 kB)
     ---------------------------------------- 64.9/64.9 kB ? eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'done'
  Getting requirements to build wheel: started
  Getting requirements to build wheel: finished with status 'error'

PIP STDERR
----------
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [31 lines of output]
      C:\Users\etien\AppData\Local\Temp\pip-install-s5_pges4\si-prefix_a5e1a90705c34c81b28d4b587ba49811\versioneer.py:421: SyntaxWarning: invalid escape sequence '\s'
        LONG_VERSION_PY['git'] = '''
      Traceback (most recent call last):
        File "C:\Users\etien\AppData\Local\pipx\pipx\shared\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 353, in <module>
          main()
        File "C:\Users\etien\AppData\Local\pipx\pipx\shared\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 335, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\etien\AppData\Local\pipx\pipx\shared\Lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 118, in get_requires_for_build_wheel
          return hook(config_settings)
                 ^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\etien\AppData\Local\Temp\pip-build-env-0nm0e61l\overlay\Lib\site-packages\setuptools\build_meta.py", line 325, in get_requires_for_build_wheel
          return self._get_build_requires(config_settings, requirements=['wheel'])
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\etien\AppData\Local\Temp\pip-build-env-0nm0e61l\overlay\Lib\site-packages\setuptools\build_meta.py", line 295, in _get_build_requires
          self.run_setup()
        File "C:\Users\etien\AppData\Local\Temp\pip-build-env-0nm0e61l\overlay\Lib\site-packages\setuptools\build_meta.py", line 480, in run_setup
          super(_BuildMetaLegacyBackend, self).run_setup(setup_script=setup_script)
        File "C:\Users\etien\AppData\Local\Temp\pip-build-env-0nm0e61l\overlay\Lib\site-packages\setuptools\build_meta.py", line 311, in run_setup
          exec(code, locals())
        File "<string>", line 11, in <module>
        File "C:\Users\etien\AppData\Local\Temp\pip-install-s5_pges4\si-prefix_a5e1a90705c34c81b28d4b587ba49811\versioneer.py", line 1480, in get_version
          return get_versions()["version"]
                 ^^^^^^^^^^^^^^
        File "C:\Users\etien\AppData\Local\Temp\pip-install-s5_pges4\si-prefix_a5e1a90705c34c81b28d4b587ba49811\versioneer.py", line 1412, in get_versions
          cfg = get_config_from_root(root)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "C:\Users\etien\AppData\Local\Temp\pip-install-s5_pges4\si-prefix_a5e1a90705c34c81b28d4b587ba49811\versioneer.py", line 342, in get_config_from_root
          parser = configparser.SafeConfigParser()
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'?
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

Also for reference, the issue on the Versionner side is python-versioneer/python-versioneer#375

I took the liberty of sending a PR to upgrade versioneer in #12.

Hi,
Any update on that? Is there any way to manually fix the issue ?
Best
Tom


SCRUM-516 SCRUM 1537 create getEntityType() method to select and display the auto-complete list, auto-complete for DA table

@cmpich instead of having specific code in the auto complete editor can we pass in a function that does the display for that field. valueDisplay function?

Could we accept this PR and continue working on it? I'd like to get feedback from Chris early on.

@chris-grove can we get a story to refactor the autocomplete component to use a valueDisplay function vs if else statements.


feat: rename universal triage team to openedx-triage

Description
Formerly, the universal triage team was named community-pr-triage.
Axim decided that we'd like to grant triage access to everyone in the org, not just PR triagers.
So, we choose the name openedx-triage, per https://openedx.atlassian.net/wiki/spaces/COMM/pages/3555852316/GitHub+Team+Naming+Conventions
Other small changes:

docs: link to original terraform-github source in docstring
fix: generated PRs should link here, not terraform-github

After merging

Rename the team in the GitHub UI
Run repo_checks -c RequireTriageTeamAccess to ensure it's a no-op.
Either:

Open an issue for adding a new type of check (a TeamCheck??) which would ensure that every org member is on the team, automatically.
Go the manual route:

add everyone to openedx-triage by hand
update our process docs to include adding new org members to openedx-triage

I think we can get rid of RequireProductManagersAccess - as long as we put all the PMs in the other group before we get rid of it.


Improve contrast ratio of some links when the design is ready

Describe the bug
Running lighthouse report on "Inclusion Challenges" page and News and Views post pages will report low contrast ratio on:

“Nomination form” and "contact form” links on “Inclusion Challenges” page. They are currently blue on white;
All tags (“AI”, “Inclusion” and “Smart Cities”) in the “Tags” sections on post pages. They are currently blue on orange;
All links in the main article on “Learn” page and "Initiatives" page. They are currently blue on white;

To Reproduce
Steps to reproduce the behavior:

Go to these pages and run lighthouse report;
Check accessibility section for reported issues.

Expected behavior
These links should have higher contrast ratio.

@cindyli  @greatislander
hi i am facing this problem when i add this COMMAND "NPM RUN START" plz anyone tell me how i run this project in my local plz help,
see in the screenshot for the better understanding....

@cindyli @greatislander
hi i am facing this problem when i add this COMMAND "NPM RUN START" plz anyone tell me how i run this project in my local plz help,
see in the screenshot for the better understanding....

@Raunaksingh100, did you hit the problem at running npm run start on a Windows platform? Did you use Powershell or Windows traditional CMD? If it's on Windows, try this sequence of commands instead of using npm run start:
npm run clean
SET ELEVENTY_ENV=development
npx eleventy --serve --port=3000 --config=eleventy.config.js

hi i am facing this problem when i add this COMMAND "NPM RUN START" plz anyone tell me how i run this project in my local plz help,
see in the screenshot for the better understanding....

@Raunaksingh100, did you hit the problem at running npm run start on a Windows platform? Did you use Powershell or Windows traditional CMD? If it's on Windows, try this sequence of commands instead of using npm run start:
npm run clean
SET ELEVENTY_ENV=development
npx eleventy --serve --port=3000 --config=eleventy.config.js

I add this all in which poweshell ?
npm run clean

SET ELEVENTY_ENV=development
npx eleventy --serve --port=3000 --config=eleventy.config.js

??

hi i am facing this problem when i add this COMMAND "NPM RUN START" plz anyone tell me how i run this project in my local plz help,
see in the screenshot for the better understanding....

@Raunaksingh100, did you hit the problem at running npm run start on a Windows platform? Did you use Powershell or Windows traditional CMD? If it's on Windows, try this sequence of commands instead of using npm run start:
npm run clean
SET ELEVENTY_ENV=development
npx eleventy --serve --port=3000 --config=eleventy.config.js

For npm start we have to change the start command  in package.json
Is this correct or wrong ???
Or simpley  add this commands in poweshell
??

For npm start we have to change the start command in package.json
Is this correct or wrong ???
Or simpley add this commands in poweshell
??

You don't need to change package.json. Just run these commands in Powershell.

thanks its works @cindyli thanks a lot

After implementing the design changes suggested in #322 to improve the visual appearance of the We Count website all of the contrast ratio issues mentioned still persist and now additionally includes the Tag Filter tags on Views page.
To reproduce this:

Go to the deploy preview of PR #334
Navigate to the Views page
Expand Tag Filters and select one or more tags
Click "Apply Filters" button
Run lighthouse
See referenced contrast ratio issues in the accessibility section of the lighthouse report

@uttaraghodke, @lliskovoi: following @TeddTech's comment about the persistence of the contrast ratio problem, we discussed this in an email thread before and @jobara's research result gave a good summary:
In WCAG 2.1, it defines [the minimum contrast ratio](https://www.w3.org/TR/WCAG21/#contrast-minimum) to be 4.5:1 except for the case of Large Text (contrast ratio 3:1), incidental and logotypes.

**What is Large Text?** [Large scale text](https://www.w3.org/TR/WCAG21/#dfn-large-scale) is defined as 18 point or 14 point bold.

**What is a point (pt) on a digital device?** Well that’s confusing. (See: [wcag issue #181](https://github.com/w3c/wcag/issues/181)). That discussion lead to an update to [Understanding WCAG 2.1](https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum) document; which uses the CSS calculation and is based off a 16px base font if I’m not mistaken. 1pt = 1.333px, 14pt ≈ 18.5px and 18pt ≈ 24px.

The cause of the problem still persists after the design change that increases the article font size from 16px to 18px for the desktop layout because the size of the large text in WCAG 2.1 spec is 24px. Moreover, the changed font size for the mobile layout is even smaller.
I wonder if it would be more reasonable to increase contrast ratios by picking dark font colors or lighter background colors.

hi iam facing this problem in windows while comminting in your IDRC project see in the screnshot for the better undertanding
PLZ HELP ME  @cindyli @gtirloni

At today's meeting, the link colors are decided to change to:

Link text when the background is white: 5879A0
Link text when background is yellow (tags and link hover/focus): 4D6B8D

At today's meeting, the link colors are decided to change to:

Link text when the background is white: 5879A0
Link text when background is yellow (tags and link hover/focus): 4D6B8D

Is there Gitter group of this organisation if then plz.share the link

At today's meeting, the link colors are decided to change to:

Link text when the background is white: 5879A0
Link text when background is yellow (tags and link hover/focus): 4D6B8D

I will do it , but this do only for 1 link or for all the link ??? See in the screenshot given above


dt0 is mandatory even for solvers that support adaptive time stepping

Running the following script:
from diffrax import diffeqsolve, ODETerm, Dopri5
import jax.numpy as jnp

def f(t, y, args):
    return -y

term = ODETerm(f)
solver = Tsit5()
y0 = jnp.array([2., 3.])
solution = diffeqsolve(term, solver, t0=0, t1=1, dt0=None, y0=y0)

leads to the following exception:
ValueError: Constant step size solvers cannot select step size automatically; please pass a value for `dt0`.

That's because diffeqsolve uses constant step sizes (equal to dt0) by default. If you want adaptive time stepping then pass in an adaptive step size controller: diffeqsolve(..., stepsize_controller=PIDController(rtol=..., atol=...)).
Adaptivity and choice of solver are two different things, despite being commonly conflated.

Great, thank you so much for clarification. It makes absolute sense.


No method to identify if the graph processing is still happening or is complete?

Describe the feature you'd like to request
Currently in x6 v2, since it's async by default and since all the frozen methods are removed, right now there is no way to know if the graph processing is still happening or complete.
Can we have two methods to serve this purpose?

It'll be helpful if we have a util method to identify if the graph is still being processed
Method to stop interactions in the graph until the first one is false

Describe the solution you'd like
A method to check if the graph processing is complete or still in process
A method to freeze and unfreeze the graph interaction
Describe alternatives you've considered
None so far.
Your Example Website or App
No response
Screenshots or Videos
No response

We recommend driving view updates based on data. If you need to get the view to complete mounting, you can use these two events.


⚠ Ixtanet SAT has degraded performance

In da98c4a, Ixtanet SAT ($MEDIA_SAT) experienced degraded performance:

HTTP code: 200
Response time: 20600 ms

Resolved: Ixtanet SAT performance has improved in b80661a after 293 days, 23 hours, 10 minutes.


Normalize git+ssh links with ':' after host to '/' instead

@Raynos @kriskowal

If it works; then #cool story


[Testing] NFC: Do not conflate ObjC interop with Darwin

This is a followup to #20780.

@swift-ci please smoke test

👍


Getting Started Guide for gRPC

Signed-off-by: Dan Wendlandt<EMAIL_ADDRESS>Here is a first version of a gRPC getting started guide, including some of the files needed to create the associated demo app container images (not required for running the demo).

@tgraf thanks.  addressed comments.  Since we want this live soon, probably best to push soon and fix up other errors as we get more reviews.   Thx.

Backported into release


Add imagePullSecretes to the Helm chart

Signed-off-by: Armin<EMAIL_ADDRESS>What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area helm
What this PR does / why we need it:
Adding the imagePullSecrets to the Helm deployments to allow authenticated Docker registries.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign leogr
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @arminc! It looks like this is your first PR to falcosecurity/charts 🎉

/cc @Issif

/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Issif
To complete the pull request process, please assign leogr
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 628c7b473a613947cf1e708b9332a1b20ddcda9b

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Issif
To complete the pull request process, please assign leogr
You can assign the PR to them by writing /assign @leogr in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold

Too late, I will fix it in a new PR eventually


Fix memory leak reported by ASAN in NNVM to ONNX conversion

Description
Fix memory leak reported by ASAN in NNVM to ONNX conversion of a constant.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Fixed a memory leak in NNVM to ONNX constants conversion code. The shared_ptr, as written, does not call delete[] on a dynamically allocated array.

Comments

@larroy isn't it consistent with the existing naming system?
That is, to call the instance of that class as the corresponding data pointer.

Not really, in those cases you want a semantic name, even if you are wrapping your Cat in a pointer you want to name it:
unique_ptr cat = make_unique()
And not
unique_ptr unique_ptr = make_unique().
Semantic naming is important, we have already type information from the compiler and we are in a statically typed language, no need to name a pointer _ptr. And definitely not "data" for the name of a variable, this is a code smell.

Gotcha! Makes sense!

@kevinzh92 Could you please address the review comments?

Sorry guys. Things have been busy at work and this fell off my radar. @larroy, I hope I addressed all of your concerns.

Looks like there's still a compiler issue:
/work/mxnet/src/operator/subgraph/tensorrt/nnvm_to_onnx.cc:567:54: error: reinterpret_cast from type 'const short unsigned int*' to type 'int32_t* {aka int*}' casts away qualifiers

                   reinterpret_cast<int32_t&>(constant));

I also have concerns about this line:
                  reinterpret_cast<int32_t&>(constant));

Hi, I update this code to use T[] as the template type of shared_ptr.
Thank @kevinzh92 for pointing out this issue.

Please rebase

Merged.
It is a tiny change to change the template type, and keep the original variable name.
We can modify the semantic name in another PR.
std::vector is not suitable in this PR, since it will allocate extra capacity.
Thank you!


Change signing interface to return promise

To allow for async signing, for example over a network, the signing
function is changed to return a promise

Thanks for the contribution<EMAIL_ADDRESS>has been published.

Awesome


Add beanstalkd for Laravel queues

BEANSTALKD

In docker:
apt-get update
sudo apt-get install -y beanstalkd
Start beanstalkd
sudo service beanstalkd start
Start listing to queue tasks
php artisan queue:listen
Ctrl C - to close

Composer.json require
"pda/pheanstalk": "2.0.*"
composer update
app/config/queue.php
default => beanstalkd
Tutorial for Queue
http://glenntaylor.co.uk/laravel/laravel-queues-with-beanstalkd#.VE9MuPmG_QE

Fixed in 1.1.0.


Change the syntax of Thm?

Use something like
Thm X in A by [ ... ]

or
Thm X : A by [ ... ]

instead of
Thm X : [ A ] by [ ... ]

The second one is probably alright!

@favonia I'm experimenting with a bracket-free notation in my PR #650... It seems much more elegant.


Cache getnext/getbulk oids and use get cmd for following calls

What does this PR do?
Cache response oids from GETNEXT/GETBULK call and use only GET for following calls.
TODO:

[x] Make refresh_oids_cache_interval disabled by default
[x] Document possible edge cases:

If device OIDs changes, they will only be picked up when oids are refreshed according to the refresh interval.
In auto discovery, if the same ip is assigned to a different device with different OIDs, the OIDs will be refreshed only according to the refresh interval

TODO after this is merged:

[ ] Add refresh_oids_cache_interval as Agent Autodiscovery Listener options
[ ] Add  oid_batch_size as Agent Autodiscovery Listener options

Motivation

2.5-3x performance increase (tested with f5 profile). See benchmark.
Reduce network calls/load

Benchmark
Before:

------------------------------------------------------------------------------------------ benchmark: 5 tests -----------------------------------------------------------------------------------------
Name (time in ms)               Min                   Max                  Mean              StdDev                Median                 IQR            Outliers     OPS            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_profile_f5[256]       788.5081 (1.0)        874.2618 (1.02)       841.0530 (1.00)      33.1901 (1.35)       839.4019 (1.0)       40.4000 (1.07)          2;0  1.1890 (1.00)          5           1
test_profile_f5[128]       801.5452 (1.02)       861.0580 (1.0)        838.6744 (1.0)       24.6202 (1.0)        841.2880 (1.00)      37.7400 (1.0)           1;0  1.1924 (1.0)           5           1
test_profile_f5[64]        852.0091 (1.08)     1,080.4954 (1.25)       950.2730 (1.13)      89.5681 (3.64)       925.3836 (1.10)     130.8482 (3.47)          2;0  1.0523 (0.88)          5           1
test_profile_f5[32]        952.4476 (1.21)     1,043.2906 (1.21)       984.6544 (1.17)      35.9119 (1.46)       982.1770 (1.17)      43.6623 (1.16)          1;0  1.0156 (0.85)          5           1
test_profile_f5[10]      1,263.3687 (1.60)     1,730.6666 (2.01)     1,454.3859 (1.73)     201.0621 (8.17)     1,416.5154 (1.69)     345.1202 (9.14)          1;0  0.6876 (0.58)          5           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

After:

------------------------------------------------------------------------------------- benchmark: 5 tests -------------------------------------------------------------------------------------
Name (time in ms)             Min                 Max                Mean             StdDev              Median                 IQR            Outliers     OPS            Rounds  Iterations
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_profile_f5[128]     275.4361 (1.0)      347.8396 (1.05)     313.8686 (1.03)     25.6864 (2.48)     315.7393 (1.03)      19.2686 (2.13)          2;1  3.1860 (0.97)          5           1
test_profile_f5[256]     286.0071 (1.04)     331.2724 (1.0)      305.8882 (1.0)      17.5271 (1.69)     305.7626 (1.0)       25.3360 (2.80)          2;0  3.2692 (1.0)           5           1
test_profile_f5[64]      287.8199 (1.04)     528.3658 (1.59)     373.7749 (1.22)     95.1384 (9.19)     373.7813 (1.22)     113.8305 (12.58)         1;0  2.6754 (0.82)          5           1
test_profile_f5[32]      327.1754 (1.19)     352.2649 (1.06)     334.0993 (1.09)     10.3484 (1.0)      331.3403 (1.08)       9.0451 (1.0)           1;1  2.9931 (0.92)          5           1
test_profile_f5[10]      459.6404 (1.67)     579.4572 (1.75)     510.8282 (1.67)     52.3034 (5.05)     501.2674 (1.64)      92.6139 (10.24)         1;0  1.9576 (0.60)          5           1
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Local optimal configuration:

use oids cache
use large enough oid_batch_size e.g. 128 or 256

This lead to 4.75x (3.2692/0.6876) perf increase compared to default configuration (no oids cache and oid_batch_size of 10)

@florimondmanca Thx for the feedbacks.

I don't know if a user-defined flag makes sense. (How can a user be confident whether they should turn it on or off?) Ideally any caching should be automatic when it's safe to do.

The caching have some drawbacks listed here: https://github.com/DataDog/integrations-core/pull/7110/files#diff-6aab5e08bf2d3d9817d6d0a77e3ac4b3R384-R388
Some users might not want the caching enabled by default in case they have tables that are very dynamic.
The idea is also to test that feature first and then possibly have it enabled by default.

There seems to be a significant drawback for table OIDs (essentially, I understand we'd keep fetching the same rows but some may be added/removed). It doesn't seem clear yet how we are handling it?

This is one of the caveats, but I suspect it's not an issue for majority of cases (talked about this with @naaltman ).
Note that we already have a "natural refresh interval" that is the agent check run interval. Any rows that's added/remove is subject to that interval.
With this caching feature, the refresh time can be much higher to benefit the performance gain.
I'm not sure we can "handle it", higher refresh time to be aware of added/removed rows is a direct consequence of the caching.

So maybe an alternative could be: cache single OIDs (i.e. "non-table OIDs") only, and leave that on by default (or maybe don't provide a flag at all?). (OIDs for eg sysName are static and they can't change, so it should be safe to cache them for a while?)

The caching is mainly benefiting table OIDs. For single OIDs the gain is quite minimal, we prevent trying to retrieve OIDs that might not exist.
For tables, the caching helps reducing the number of calls (especially combined with high enough oid_batch_size).  Currently, for a table, we need at least n GETNEXT calls, with n the number of rows of the table. This is not the case using the caching provided by this PR.

A couple of other thoughts:

I like the "scalar OIDs" terminology. We could probably merge a separate PR to adopt this terminology first (essentially all_oids -> scalar_oids). It looks like a positive change regardless of any caching implementation.

Yes, can be possibly a separate PR.

I think the OidsConfig (OIDConfig?) model class makes sense,

Using the plural is mainly because it's a kind of OIDs manager, but the term OidsManager is a bit too generic hence the term OidsConfig.

and I'm wondering if we could not also already create an initial implementation for it, mostly with just scalar_oids, next_oids and bulk_oids,  and the .has_oids() (.empty()?) helper.

Yes, could be separated as initial impl.

Maybe it should be in models.py though?

Not sure about this, since it's still a "Config" of some kind so, having it in config.py seems ok.

Use OIDConfig, keep in config.py
Split PR into 3:

scalar oid naming
OIDConfig class
Caching

Keep cache config disabled by default for now (possibly enabled by default later)


Revamp Coordinate constructors

Add constexpr
Remove explicit
Use list initialization
Disallow omitting y and z arguments (breaking change)

Looks good, but will have to delay until next "release" due to breaking change :+1:


Unable to enter multi-byte characters in Windows console

I entered multi-byte characters directly in Windows Console.
But I can't get the correct byte data from stdin.
sample code:
import 'dart:io';

void main() async {
  await for (var i in stdin) {
    print(i);
  }
}

In Powershell 7(code page 65001),
I typed 'あ'(U+3042, utf-8: 0xE38182=[227 129 130]).
Direct input -- Bad:
> dart .\bin\main.dart
あ
[0, 13, 10]

Pipe -- OK:
> echo あ | dart .\bin\main.dart
[227, 129, 130, 13, 10]

I expected the results of direct input to be the same as the pipe version.
Dart VM version: 2.7.2 (Mon Mar 23 22:11:27 2020 +0100) on "windows_x64"
Windows 10 Pro(1909)
Powershell 7.0.0

Any update? This makes it impossible to type Chinese characters as console input to a Dart program.

Any update? seems stdin now only work with Ascii characteristics

I have a same issue. holp to support.


List Component

Hello,
Please, this is more of a question: Is work still on-going on the List component? I noticed it was commented out in the demo app and it threw errors when I tried to uncomment and run the app with it.
And please is it normal native behaviour for the drawer to be available on every view, even child views? It feels like an anti-pattern, what do you think? Thanks

Hello, yeah it'll be in the next release, see the 0.4

Thanks for the quick reply @Ehesp. Not quite sure how the drawer 'should' behave myself - I think it's not so opinionated, even there are disparities in its behaviour across apps by Google e.g GMail follows your pattern (drawer is available globally) but on Hangouts (drawer is not available in child views). On most apps though, the back button would only exit app when you are on the landing or initial view.

Also with the List view, I need some way of having a global wrapper for TouchableNativeFeedBack and also Ripple, instead of doing the whole if(!isCompatible... scenario every time. Will sort that somehow.
Yeah, there's all sorts of inconsistency with Google really, some of the apps "sort of" follow Material Design too, which is annoying.
The demo app uses the Navigate class, which by default only quits the app if you're on a top level parent. It wouldn't be too much hassle to customise it for your needs - every app is different, just hard to make a fits all solution.

Thank you and you are right, your library can be easily customised.


Fix TOCTOU Bug in ament_tools helper.py

Description

On my machine, the parallel build (src/ament/ament_tools/scripts/ament.py build --symlink-install --parallel) consistently breaks with an error similar to:

Traceback (most recent call last):
  File "/home/jp.samper/sketch_ws/ros2_ws/src/ament/ament_tools/ament_tools/verbs/build/cli.py", line 381, in process_in_parallel
    result = done_future.result()
  File "/usr/lib/python3.5/concurrent/futures/_base.py", line 398, in result
    return self.__get_result()
  File "/usr/lib/python3.5/concurrent/futures/_base.py", line 357, in __get_result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/jp.samper/sketch_ws/ros2_ws/src/ament/ament_tools/ament_tools/verbs/build_pkg/cli.py", line 280, in main
    return run(opts, context)
  File "/home/jp.samper/sketch_ws/ros2_ws/src/ament/ament_tools/ament_tools/verbs/build_pkg/cli.py", line 339, in run
    deploy_prefix_level_setup_files(context)
  File "/home/jp.samper/sketch_ws/ros2_ws/src/ament/ament_tools/ament_tools/verbs/build_pkg/cli.py", line 307, in deploy_prefix_level_setup_files
    deploy_file(context, context.build_space, name[:-3])
  File "/home/jp.samper/sketch_ws/ros2_ws/src/ament/ament_tools/ament_tools/helper.py", line 282, in deploy_file
    os.symlink(source_path, destination_path)
FileExistsError: [Errno 17] File exists: '/home/jp.samper/sketch_ws/ros2_ws/build/ament_cmake_pyflakes/local_setup.sh' -> '/home/jp.samper/sketch_ws/ros2_ws/install/local_setup.sh'

Basically, the OS tries to create a symlink, but it finds that the symlink already exists, even though just a few lines above, it had checked that it didn't exist.
The same thing happens in line 272, when the script tries to remove a file that doesn't exist, even though few lines above it had checked that it did exist.

How to test

As with all race conditions, it may be hard to reproduce the bug on other machines, but I can consistently reproduce it in mine, and this fix consistently prevents it.

Fix

I think it's safe to pass on the os.remove error -- who cares if you can't delete a file that doesn't exist anyway
I'm not sure what the best approach is for the symlink: Do we pass on the exception? Or do we delete the existing symlink and try again?

I guess the reason why none of us is running into this problem is that we usually build with --isolated. In that case each package has a different install prefix and therefore none of these file operations overlap.
I am fine with merging the patch as-is if it resolves your problem. For the symlink case I don't see what else we could do. In general I think in the case of a non-isolated install the various deploy calls to drop files into the shared install prefix should be protected by a mutex. But I don't think it makes sense to spend effort implementing this for ament_tools.