MRJobLauncher adds jobState props to each WorkUnit

The following block in MRJobLauncher causes all jobState properties to be duplicated across all WorkUnits
if (workUnit instanceof MultiWorkUnit) {
	List<WorkUnit> flattenedWorkUnits =
    JobLauncherUtils.flattenWorkUnits(((MultiWorkUnit) workUnit).getWorkUnits());
    for (WorkUnit flattenedWorkUnit : flattenedWorkUnits) {
    	flattenedWorkUnit.addAllIfNotExist(this.jobState);
    }
    this.workUnits.addAll(flattenedWorkUnits);
} else {
	workUnit.addAllIfNotExist(this.jobState);
    this.workUnits.add(workUnit);
}

This is problematic since these WorkUnits will eventually be serialized to a temp file and read into memory by the driver. The duplicate jobState props are not necessary and removing them can save a significant amount of memory.
The WorkUnit still needs access to props in the jobState but it shouldn't need a full copy of them. The code should be changed so that each WorkUnit only has a pointer to the JobState.

I'm also removing dupes while writing the data to the history store.


Use zkProgram for P2P proof validation

This PR introduces the following changes:

A zkProgram that's used by both players to validate each other's hidden object's positions.
Refactors the code so it uses data structures from the zk3d package, instead of custom ones.
Adds unit testing for all code used in the zkProgram.
Deprecates the use of the HotnCold smart contract.

nice :))))))))


Kiali helm charts are out of sync with istio/installer

istio/installer is newer than istio/istio.

Duplicate of https://github.com/istio/istio/issues/18790


Code signing remark still valid for labconfig

See #609
https://github.com/microsoft/MSLab/releases/tag/v24.11.1
From the changelog I understood that signing got removed @machv, can we remove instructions in readme.md?

This change, I hope, is only temporary until I resolve needed changes on the build infrastructure. But as Windows Server 2025 has recently been released, I didn't want to further block MSLAB new release.

Thanks!
So only labconfig.ps1 was or will remain unsigned in future? I mean this one needs to be edited and then Re-signed anyway.


Ui

Can't play the current version anymore. Please merge!

Added a prefernece to show flat buildings on the map (just the map):

1. light in the buildings is inconsistent.

This is also affecting the coloured buildings. The problem is that the color filter applies to grey base building, and the before the majority of the building is not the primary color, which is impacting the ability to distinguish the faction on the map, especially on mobile. In the final building we have a darker color, a color close to the faction color, and a lighter color, difficult to distinguish in small screens

2. bold lines
There are a lot of different bold ones that are confusing instead of helping

Suggestion: move to a thin consistent line for resources, tiles, building. I would start with the one we are using for qics

tile. icons alignment
Icons are not aligned and also overlapping the victory point icon. Move them aligned bottom.

action tiles position
This is inconsistent with the boardgames, and also wasting precious space for the map.
Move it to the bottom horizontally and maximise the board

I cannot relate the red hexagon to the end turn

6. highlight buildings on map
Instead of the bold lines only, can we evaluate something like this?


[libradb] fix get_ledger_info and rename to get_nearest_epoch_change_…

…ledger_info
Motivation
The current implementation name is confusing.
JsonRpcError { code: -32000, message: "Server error: DB corruption: the last ledger info of epoch 1 is missing next epoch info", data: None }

libradb::get_ledger_info(v) has a flaw: when v is in the latest epoch it raises the above error
Have you read the Contributing Guidelines on pull requests?
Y
Test Plan
add new test plan

Overlap with #4511


Init tests for httprox

For retrieving the artifacts, generic proxy service needs to access indy REST first and then stream the result back, the pr I try to use the PipedOutputStream in ProxyResponseHelper to transit it from Indy response to client. Not sure if this is right, please help to review. And there are two tests in HttpProxyTest for it.

Thanks, since this is just partial of the proxy stuff, will merge it and continue.


more linkage for the user to follow.

This description was among the better ones that I have seen here,  The issue that would make it and all of your other help pages better would be to  link every one of the usages of KEY words, TYPES, Objects, methods, and so on, back to their definition Pages and to expound on those with more examples where they, the examples are thoroughly explained would help a lot.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 54711c82-54da-7530-eb5b-0541b5dd0b19
Version Independent ID: 47013abf-144d-bd31-0344-3adad9b53032
Content: Property Set Statement
Content Source: Language/Reference/User-Interface-Help/property-set-statement.md
Product: office
GitHub Login: @o365devx
Microsoft Alias: o365devx

@poundjd Thanks for the feedback. I am going through a clean-up of the VBA site, and will consider your request as I'm making updates.

Please ensure that you understand that some of us are using this resource to LEARN VBA and VB as well as object coding as well.  So the more info the better, especially the examples.

@poundjd Thanks again for the feedback. I can't help with the examples, but as I'm scrubbing the documentation, I'm adding links where I can.


Keybindings flexibility

Remove support of virtual keys that don't have corresponding KeyCode.
Add F13-F30 keys support.

[not yet ] Added an entry to CHANGELOG.md if this change could be valuable to users

Implementation discussion may be held here. While concept/logic discussion is preferred in the issue https://github.com/lapce/lapce/issues/2636

For what reason are F13+ keys added?

@panekj While being relatively rare those keys are completely valid keycodes. You can assign them to any layer/button on QMK keyboards in VIA. There are some (older) keyboards that have them physically.

@victorcrimea Is there an ETA regarding this PR?

@victorcrimea Is there an ETA regarding this PR?

Last time I was working on this problem. I found that it is necessary to get the keyboard layout from the system. And there was no cross-platform way of doing this and I wan't brave enough to dive into os-specfic libraries. I'll try to look around again, maybe something is improved.

@victorcrimea Is there an ETA regarding this PR?

Last time I was working on this problem. I found that it is necessary to get the keyboard layout from the system. And there was no cross-platform way of doing this and I wan't brave enough to dive into os-specfic libraries. I'll try to look around again, maybe something is improved.

No, we're still waiting for https://github.com/rust-windowing/winit/issues/2678

@panekj I just realized that in the meanwhile we can just make it a setting in lapce. Basically a choice between:
Azerty
Qwerty
Qwertz
[maybe other layouts as well]
Not ideal but solves peoples problems

@panekj I just realized that in the meanwhile we can just make it a setting in lapce. Basically a choice between:
Azerty
Qwerty
Qwertz
[maybe other layouts as well]
Not ideal but solves peoples problems

Imo that's a good compromise in the meantime since besides reassigning all the shortcuts to your layout lapse is not usable on other layouts than qwerty

Hi, another idea:
don't use keycodes, physical key locations etc. Just use the Character value from winit:
Character(Str)

A key string that corresponds to the character typed by the user, taking into account the user’s current locale setting, and any system-level keyboard mapping overrides that are in effect.

The keymaping implementation and config then should ignore the Shift-modifier (AltGR is already ignored by winit).
So instead of defining a keybind like this in the config:
Ctrl + SHift + a

it would be
Ctrl + A

as the Shift modifier is implicit (a user have to type Shift+a to get the A)
Another example: A keybind could be defined as
Ctrl + /

in the config.
A user using a ANSI QWERTY layout would just press Ctrl+/. Another user using a ISO-De QWERTZ layout knows that to get the /char has to press Shift+7so the user just presses Ctrl + Shift + 7to execute the command bound to the keybind Ctrl + /.
This way the application does not need to know anything about the layout of the keyboard.

@sorcerersr This make editor unusable to those who use latin AND non-latin keyboard layouts. Because Lapce will only handle keybinding if it is pressed in latin layout.
P.S. This was the original problem I tried to solve. And at the very end I realized the problem with QWERTY/QWERTZ/AZERTY.

I'm a DVORAK user, but my physical keyboard is a QWERTY. I'm also affected by the issue since lapce is detecting the physical keys instead of the virtual ones (if I press "." lapce is reading "e" because it's the physical key). I don't know if this help, but before the refactor using Floem, the keyboard was working fine

@iltumio This is just a coincidence. It has nothing to do with Floem/druid

@iltumio BTW, just curious. You as DVORAK user, do you also have QWERTY layout setup in your system?
The reason I'm asking this is because if we make keyboard layout a setting, it is not obvious how to handle scenarios when user has BOTH qwerty and non-qwerty latin layouts.

@victorcrimea have you considered supporting this use case by allowing more than one keybind per command in keymaps.toml?
Hardcoding keyboard layouts or mappings of one layout to another into an application seems to me like reinventing the wheel. On my Linux system there are about 100 Layouts to choose from (not counting variants).

@sorcerersr VSCode does exactly this in browser link
I'm not sure what do they use to extract keyboard layout from the OS. Most likely it is chromium that does the os-specific heavy-lifting to get the keyboard layout.

@iltumio BTW, just curious. You as DVORAK user, do you also have QWERTY layout setup in your system?
The reason I'm asking this is because if we make keyboard layout a setting, it is not obvious how to handle scenarios when user has BOTH qwerty and non-qwerty latin layouts.

I use DVORAK layout (on querty phisical keyboards) 99% of the time. I still keep the option to switch layout to the Italian Querty one for some very rare use cases that have nothing to do with coding (therefore is not relevant for lapce in my case).
Do you think we can have a look at Tauri implementation? I'm not 100% sure, but they should have addressed the issue somehow
https://github.com/tauri-apps/tao/blob/dev/src/keyboard.rs


Android Basics: Load and display images from the Internet

name: Android Basics Unit 4 issue
about: Report problems with the Android Basics Unit 4 codelabs
title: 'Android Basics Unit 4 issue:'
labels: ''
assignees: ''

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-internet-images?authuser=1&continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-4-pathway-2%3Fauthuser%3D1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-internet-images#2
In which task and step of the codelab can this issue be found?
Step 3
Describe the problem
In this step there is an image that should show a text "First Mars image URL : http://mars ...", but this image shows "Failure Unable to resolve ...", this text is not applicable to example.
Steps to reproduce?

Go to URL
Go to step 7 in Update the ViewModel
See error image

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

Duplicate of #82, #74, #70, #56


mvsim: 0.4.3-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository mvsim to 0.4.3-1:

upstream repository: https://github.com/ual-arm-ros-pkg/mvsim.git
release repository: https://github.com/ual-arm-ros-pkg-release/mvsim-release.git
distro file: noetic/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.4.2-1

mvsim
* add names to gl objects (useful to debug)
* configurable gui open timeout
* GUI: new button Editor->Export 3Dscene file
* Add a warning if using a physics timestep is incompatible with the sensor periods
* FIX: more accurate simulation of timesteps; more mutexes
* automatic determination of timestep; FIX bug: constant offset in simul time
* fix FBO api for mrpt 2.5.6
* fix build against mrpt 2.5.6; fix infinite loop while hitting quit button
* refactor TCLAP objects to avoid global object initialization fiasco crashes
* handle old and new versions of tf_geometry_msgs
* mvsim cli new command: topic hz
* Fix ROS2 obsolete header
* fix build for u18.04
* fix for older zmq versions
* fix newest zmq deprecated warnings
* FIX: DAE file error to load on newer version of assimp
* provide cmake config types for gcc sanitizers
* fix zmq API in bionic
* avoid zmq_message_t ctor; more parallel threads for ZMQ
* make the get_pose() service to answer immediately without needing to acquire the main simulation mutex
* fix escaping
* more portable makefile comparison for libbox2d version
* d/rules: auto detection of system libbox2d version
* Contributors: Jose Luis Blanco-Claraco

Holding for Noetic sync


Jenkins: Vagrant boxes for AWS and Virtualbox

Outcome
Vagrant .box files for

AWS
Virtualbox

Packer templates and Vagrantfiles for the same.
Purpose

Create reusable environment for workshops
Enable easier setup by IT guys preworkshop
Use this as post-workshop practice environment

Contents
The box will contain the following:

Jenkins
Ansible
Vagrant
Docker
Maven
Git

This issue is basically fixed; waiting for testing of Packer box.

Packer-built boxes for Virtualbox and AWS are tested; closing.


Why do you use both layer_norm for embedding and pre-norm at the same time?

Hi,
this is great work that makes BERT pre-training more transparent. Here I have a question about your architecture.
In https://github.com/princeton-nlp/DinkyTrain/blob/main/run_efficient_mlm_recipe.sh, you set the following two flags:
--arch roberta_large
--encoder-normalize-before

I understand you want to use pre-norm BERT. However, the default setting for roberta_large is with --layernorm-embedding=True, which means you will use two layernorm layers continuously after the word embedding layer. I think you also need to set --layernorm-embedding=False.

Actually, it matters, but in a good way. From my result, pre-norm + embedding normalization outperforms pre-norm only, with about 0.8% improvement on MNLI.
Your residual connection argument makes sense.


Consider refactoring  not to use children prop for column specification

I'm working on a datatable implementation which is based off (forks) <Table /> code.
I think <Table /> code itself could be simplified (and even be more performant probably) if it uses columns prop (being an array column specifications, just POJSO objects) instead of children with pseudo-React elements.
For example all those calls to React.Children.forEach/map will go away. What do you think?

Another problem with <Column /> is that it doesn't adhere to standard React composition semantics: what if I do <MyFancyColumn /> and pass it into <Table />? It will break (good we have a warning for it).

This is a reasonable suggestion. Personally, I like declaring the columns as children vs a props-array, but that's just a subjective thing.
I wish this issue had been filed before version 8 was released. As it is, I don't think it warrants another major release and I don't think I want to add forks to support both. (Hope you understand.)
The MyFancyColumn scenario you mention is supported, just not via JSX syntax. Instead you could make a factory method that would work something like this:
function MyFancyColumn (columnProps) {
  // Do whatever makes your column fancy
  return (
    <Column {...columProps} />
  )
}

function renderTable () {
  return (
    <Table {...tableProps}>
      <Column {...column1Props} />
      {MyFancyColumn(column2Props)}
    </Table>
  )
}

I'm going to go ahead and close this issue for now because I don't plan on taking immediate action on it and doing so helps me keep the backlog somewhat maintainable. But we can continue to discuss the topic here. 😄

Makes sense. Totally does warrant another major release alone.
On Fri, 23 Sep 2016 at 17:23, Brian Vaughn<EMAIL_ADDRESS>wrote:

This is a reasonable suggestion. Personally, I like declaring the columns
as children vs a props-array, but that's just a subjective thing.
I wish this issue had been filed before version 8 was released. As it is,
I don't think it warrants another major release and I don't think I want to
add forks to support both. (Hope you understand.)
The MyFancyColumn scenario you mention is supported, just not via JSX
syntax. Instead you could make a factory method that would work something
like this:
function MyFancyColumn (columnProps) {  // Do whatever makes your column fancy  return (
<Column {...columProps} />
)
}
function renderTable () {  return (
<Table {...tableProps}>
<Column {...column1Props} />
{MyFancyColumn(column2Props)}

)
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bvaughn/react-virtualized/issues/414#issuecomment-249206599,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB3grAxY2tZCR0vo3yyXs5VQaRy6642ks5qs-DegaJpZM4KE3Ru
.

Er... I mean't "doesn't warrant another major release".

lol, no worries. I understood what you meant. 😄

It is a reasonable suggestion though. I'll think on it a bit more. If you'd like to toss up a PR with a suggested implementation in the meanwhile- (one that maintains backwards compat)- I'd be happy to look over it and further consider.


Collecting leftover hotfix / missed code from master into develop

@hyi, @pkdash, @alvacouch
Please validate this is indeed code intended for use in develop
It's mostly commit history information, but does look like 4 files are different.

I'll defer to @pkdash or @alvacouch for this since the changes are mostly incurred by an additional user parameter in update_science_metadata(), which perhaps was patched to master due to some coverage code change? I thought merging release 1.11 back to develop should have covered this since master should have the same code as release 1.10, so I am a bit confused about the differences shown in this PR.

@mjstealey @hyi and @alvacouch It seems this line in master should not be there.
https://github.com/hydroshare/hydroshare/blob/master/hs_core/hydroshare/resource.py#L700. We may do a hotfix to master first and then update this PR accordingly.


[Docs]: Example for app directory + cookie / header based locale switching

Link to page
No response
Describe the problem
The App directory example only contains for router based localese, it would be nice to have a "best practice" example for doing a header (accept language) + cookie (NEXT_LOCALE) based, user preference based local switching.

Are you referring to an example that doesn't use an i18n routing setup? The corresponding setup guide links to two examples at the bottom.


Normalization and BatchNormalization layer does not rescale or normalize inputs, am I missing something?

I opened a same issue in tensorflow, but I found it could be keras probelm.
System information
colab with tf-2.8
old-tf_env.txt

Describe the current behavior
Normalization and Batch Normalization layer does not rescale or normalize inputs as excepted, the inputs barely not changing.

Standalone code to reproduce the issue
Tensorflow:
Normalization layer
tfdata = np.array([[1,2,3,4,5]],dtype=float)
print("tfdata:" ,tfdata)
print("avg: ", np.average(tfdata))
print("var: ", np.var(tfdata))

tfdata: [[1. 2. 3. 4. 5.]]
avg:  3.0
var:  2.0

normalization_layer = tf.keras.layers.Normalization(axis=-1)
normalized_data = normalization_layer(tfdata)
print(normalized_data.numpy())
print("normalized avg: ", np.average(normalized_data.numpy()))
print("normalized var: ", np.var(normalized_data.numpy()))

output:

[[1. 2. 3. 4. 5.]]
normalized avg:  3.0
normalized var:  2.0

This output is unchanged
BatchNormalization layer

batch_normalization_layer = tf.keras.layers.BatchNormalization(axis=-1,scale=True,center=True)
batch_normalized_data = batch_normalization_layer(tfdata)
print(batch_normalized_data.numpy())
print("batch normalized avg: ", np.average(batch_normalized_data.numpy()))
print("batch normalized var: ", np.var(batch_normalized_data.numpy()))

output:

[[0.9995004 1.9990008 2.9985013 3.9980016 4.997502 ]]
batch normalized avg:  2.9985013
batch normalized var:  1.9980018

This output still unchanged!
Torch:
LayerNorm
tdata = torch.tensor([[1,2,3,4,5],[6,7,8,9,10]],dtype=torch.float32)
normalization_layer=torch.nn.BatchNorm1d(num_features=5)
normalized_data = normalization_layer(tdata).detach().numpy()
print(normalized_data)
print("normalized avg: ", np.average(normalized_data))
print("normalized var: ", np.var(normalized_data,))

output

[[-0.9999992  -0.99999917 -0.9999991  -0.9999993  -0.9999992 ]
[ 0.99999917  0.9999992   0.9999993   0.9999991   0.99999917]]
normalized avg:  1.7881394e-08
normalized var:  0.9999984

At first, I thought it could be different implementation, so I checked the code.
The call method is quite short, looks like mean and variance are never calculated.
I debugged this code and verified my guess.
https://github.com/keras-team/keras/blob/v2.8.0/keras/layers/preprocessing/normalization.py#L300-L306
  def call(self, inputs):
    inputs = self._standardize_inputs(inputs)
    # The base layer automatically casts floating-point inputs, but we
    # explicitly cast here to also allow integer inputs to be passed
    inputs = tf.cast(inputs, self.compute_dtype)
    return ((inputs - self.mean) /
            tf.maximum(tf.sqrt(self.variance), backend.epsilon()))

https://github.com/keras-team/keras/blob/v2.8.0/keras/layers/preprocessing/normalization.py#L244-L298

@jayagami
When using tf.keras.layers.Normalization you must .adapt() before !!!
normalization_layer = tf.keras.layers.Normalization(axis=-1)
layer.adapt(tfdata)
normalized_data = normalization_layer(tfdata)
print(normalized_data.numpy())
print("normalized avg: ", np.average(normalized_data.numpy()))
print("normalized var: ", np.var(normalized_data.numpy()))

@jayagami
When using tf.keras.layers.Normalization you must adapt it (.adapt()) before !!!
More info here: https://keras.io/api/layers/preprocessing_layers/numerical/normalization/
normalization_layer = tf.keras.layers.Normalization(axis=-1)
layer.adapt(tfdata)
normalized_data = normalization_layer(tfdata)
print(normalized_data.numpy())
print("normalized avg: ", np.average(normalized_data.numpy()))
print("normalized var: ", np.var(normalized_data.numpy()))

The BatchNormalization calculate mean and varience only in training mode !!! You must train it before using in prediction manner.
batch_normalization_layer = tf.keras.layers.BatchNormalization(axis=-1,scale=True,center=True)
batch_normalized_data = batch_normalization_layer(tfdata, training=True)
print(batch_normalized_data.numpy())
print("batch normalized avg: ", np.average(batch_normalized_data.numpy()))
print("batch normalized var: ", np.var(batch_normalized_data.numpy()))

batch_normalized_data = batch_normalization_layer(tfdata, training=False)
print(batch_normalized_data.numpy())
print("batch normalized avg: ", np.average(batch_normalized_data.numpy()))
print("batch normalized var: ", np.var(batch_normalized_data.numpy()))

Thanks for your explanation!
I re-checked the documentation and found it right in front of me, surprised I hadn't noticed this paragraph before.
I understand the need for this design, which is very different from torch. I should have paid more attention to these details.

@fchollet  I solved it for Keras.


Remove dead code and increase test coverage

Many functions in utils.py and file_path.py are no longer called and should be removed. This will increase our test coverage percentage.

Closed by #224


[release-1.14] Update to make prow/release-commit.sh executable after sed

This is an automated cherry-pick of #41846

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio_release-1.14
f62d5dac807e1935640f2f0c24a1a4d3de0234ec
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio_release-1.14
f62d5dac807e1935640f2f0c24a1a4d3de0234ec
link
unknown
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster


Support for referencing local vars in default value expressions of object fields

Following code should work without an issue. Related to #20851
public function main() returns (error?){
   int x = 20;
   object {
       string name;
       int age = x;

       public function __init(string name) {
           self.name = name;
       }

   } person1 = new("pubudu");
}

@Kishanthan @riyafa please take note.

@pubudu91 this will be a blocker for SL. I think we need to look into this.

I think @KRVPerera is planning on looking in to this. Will check and see.

Working on closure support for object-type-descriptors via issue : https://github.com/ballerina-platform/ballerina-lang/issues/9144.

Fixed via https://github.com/ballerina-platform/ballerina-lang/issues/9144


Canvas II Remote in Control Center Not Showing Up

Hi
First of all, great job on the plugin. Works with my Canvas II in the Home app. On/Off Brightness control all working from Home app’s TV accessory. However I’m not sure if it’s because of Canvas II or the fact that i have multiple HomeKit TVs in Home app and Control Center widget but for whatever reason Control Center widget for my Canvas II isnt showing up in Control Center. Any pointers as to why that might be happening? Many thanks!

My set up is the same as yours (Canvas II and multiple HomeKit TVs) -- and I get a Meural option in the control center remote widget. Have you learned anything else since you opened this issue?

Hi
While the Canvas does show up as Remote in CC, as well as in Home app, what is weird is that it no longer is controller through Home app. Just shows “No Response” whenever i try to power it on or off. Works fine from official Meural app, of course. This is v2 of Meural so not sure how can you make it work but it used to work previously so really hoping you are able to get it to work again. Thanks

Hi,
I have a canvas II as well. Comes ls not available in control center, unless I’m missing something. Everything else is pretty stable. Thanks


Split implementation without FastTokenizer (to master)

Ticket: CVS-136469

PR is ready for review. @apaniukov please take a look


Cannot connect to PBM after v1.10.0

Running a simple script to connect to PBM fails after v1.10.0 with the following error:
lib/rbvmomi/connection.rb:262:in method_missing': undefined method PbmServiceInstance' for RbVmomi::VIM:Class (NoMethodError)
Using this test script reproduction steps are:
git bisect start v1.11.2 v1.9.0
git bisect run bundle exec ruby ./pbm.rb  --host=$HOST --user=$USER --password=$PASSWORD

Bisect points to 34a754ceb85db8b6f43e1af6f6771bd97f4fe037 as the first bad commit
It looks like VIM::PbmServiceInstance was dropped from the vmodl.db while upgrading to 6.5

I apologize that it took me so long to get to this! Can you test from the fix-113 branch and see if that fixes the issue for you?

Hey, no problem at all.  Yes that fixes the issue for me.

Thanks @jrgarcia !

I just released v1.11.3 with this fix so you can update your Gem rather than pulling in a branch from Git.


Fix compile error

@jbakermd FYI

Thanks for this one. It's strange how npm will keep on going even with a compile error.


Remove stray word.

This article includes the word "Security" beneath its top-level description. It has no context or further information so I assume is a typo.

@markingmyname - can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Cache character position in bytebuffer

Provide better performance for mapping bytes to characters

@klokane where is this going to be used?

snowcrash, firstly make character map, later will use for generate SourceMaps instead of compute it on raw bytes.

There is optional solution, connect character index with, ByteBuffer together.

In this case we will need no make any changes to snowcrash

I am OK with this :+1:


Enable rollup as dim for new uwsgi metrics

Makes possible filtering by rollup (expecially in SignalFx side)

+1


Fix Sage Intacct entity is not shown on Connections card

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/45935
PROPOSAL: N/A
Tests

Head to Workspace settings
Head to Accounting
Connect to Sage Intacct
Verify that Top level is shown as entity
Try changing entity and veirfy that it works

Offline tests

QA Steps

Same as tests
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/0eff28b4-f008-45b2-96ee-30b8bcd5c7da

Android: mWeb Chrome
https://github.com/user-attachments/assets/636fde57-2d94-48e0-816c-339827ed2b6e

iOS: Native
https://github.com/user-attachments/assets/801b3235-2997-4fe4-9683-c2892f9fc2eb

iOS: mWeb Safari
https://github.com/user-attachments/assets/ed2970ca-f163-4450-96f2-7f79f763e156

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/6c1f220a-e29f-4747-80fe-9324f1973046

MacOS: Desktop
https://github.com/user-attachments/assets/e0a6a7c0-4498-49ae-87b6-c59960da919b

@hungvu193 since you have context, can you take a look? 🙏

Sure 👍

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/4a15d196-5d45-4bf2-83a1-4fac02ae1ba1

Android: mWeb Chrome

https://github.com/user-attachments/assets/20f13570-e415-4b6f-8ea8-6aa8f7f1b998

iOS: Native
https://github.com/user-attachments/assets/6168e066-6122-4b84-97dc-a60f23f0c265

iOS: mWeb Safari

https://github.com/user-attachments/assets/52ab93d2-7c9b-4ca6-ba09-636219a35907

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/e3062731-7459-436e-825a-c1554e1c8784

MacOS: Desktop

https://github.com/user-attachments/assets/97ba8010-57e2-4d97-82c2-7f6523dd305c

All yours @tgolen

+1 @SzymczakJ do you have a reason for this one?

It's because of typescript and a rule that requires a switch to have a default:. I've defined a case for every possible entry, so typescript knows that stage type is never, and this cannot be part of string template.

But when BE will return some new string, then we will need that default case.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.17-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Attachment base64 image

Hi, if more than one image as base64 in an array want to be shared through email there only one attachment file is showed in received mail.
And all attachment files created in the same name for each other

Hi, are you refering to shareViaEmail on Android?

Yes, i meant exactly that here is i fixed it on my code
SocialSharing.java :318
String fileName = "file"+nthFile+"." + imgExtension;

Hi, nicely found, please try the 4.3.15 version which works per your suggestion.


eslint doesn't ignore generated files from template

Note: If your feature-request is regarding the AWS Amplify Console service, please log it in the
official AWS Amplify Console forum

Is your feature request related to a problem? Please describe.
#3278 resolved files from code generator.
As well generated files also from template file should include /* eslint-disable */.
Describe the solution you'd like
Append /* eslint-disable */
Describe alternatives you've considered
Additional context

@akgm3i Which files are you specifically referring to? Cloudformation templates?

I'm referring to files generated from amplify api gql-compile command.
like mutations.ts, queries.ts, subscriptions.ts.
I'm sorry for the confusion.

those files are generated by codegen, not gql-compile

// eslint-disable just disable only one line.
disable whole file needs /* eslint-disable */.
and I had forgot aws-exports.js, amplify-config.js.


Update the README.md with information about the route

Before:
"Then you can navigate to the newly exposed route, something similar to "http://nodejs-rest-http-crud-boosters.<IP_ADDRESS>.nip.io/", this will probably be different based on your Openshift IP address"
After:
Run the following command to show the newly exposed route that you can navigate:
oc get route nodejs-rest-http-crud
NAME                    HOST/PORT                                        PATH   SERVICES                PORT   TERMINATION   WILDCARD
nodejs-rest-http-crud   nodejs-rest-http-crud-opentel.apps-crc.testing          nodejs-rest-http-crud   8080                 None

https://github.com/nodeshift-starters/nodejs-rest-http-crud/pull/367


Add support for WiiMote

Add support for the original (AliExpress wiimotes don't have bluetooth) WiiMotes so bluetooth connected wiimotes for each team can change the scores next to the already existing keyboard support

Was able to connect the wiimote to the pc and implemented logic to see key presses, but after restarting the PC the wiimotes are not connected anymore. Several attemps, but it seems a known unresolved issue. So the support will not be implemented.


fix bug with small SHARE partition

A small fix to avoid ES quitting with "floating point error" when SHARE partition is less than 1GB

thanks dude


Downloading PHP files instead of Executing them.

Hey fideloper,
I've been playing around with ansible for a bit and I'm using your playbooks. I'm using this playbook as well as your PHP playbook.
I ran the playbooks successfully today, so I have the most recent code. My site it working as expected except when it comes to a PHP script. Rather than being executed, the file is being downloaded.
I haven't made any other customizations (except for the server / sitenames) to any of the scripts. Not sure if maybe you were getting the same issue and solved it somehow.
Thanks!

I actually just changed the location of the php block inside my nginx config and all is well.
location ~ \.php$ {
    fastcgi_split_path_info ^(.+\.php)(/.+)$;
    fastcgi_pass <IP_ADDRESS>:9000;
    fastcgi_index index.php;
    include fastcgi.conf;
    fastcgi_param DOCUMENT_ROOT /{{ domain }}/public;
    fastcgi_param SCRIPT_FILENAME /{{ domain }}/public$fastcgi_script_name;
    fastcgi_param APPENV {{ app_env }};
}

Thanks for making all this stuff available! It's been extremely helpful while learning Ansible.
ps:
I love the Chrooting PHP stuff.

Hey! I didn't know anyone was paying attention to these :D
These are slowly getting more specific for my use case (for better of
worse) - and I e been hacking away at them this weekend. The Ansible-php
repository here will go in conjunction with it. Note that it does some
pretty specific things for chroot (when I push it up :D), now including
ensuring the /Dev/random stuff is available, and some files related to
timezone settings
(Chroot is turning out to be a major PITA, but when it comes together,
it'll be pretty nice!)
I push up the php stuff shortly as well. I have a PostgreSQL Ansible role
to publish too...
Glad it's been useful!
On Sat, Feb 21, 2015 at 19:39 veroarts<EMAIL_ADDRESS>wrote:

Closed #1 https://github.com/Servers-for-Hackers/ansible-nginx/issues/1.
—
Reply to this email directly or view it on GitHub
https://github.com/Servers-for-Hackers/ansible-nginx/issues/1#event-239693920
.

Sorry for the terrible English, typing on ios is the worst :P
On Sat, Feb 21, 2015 at 20:29 Chris Fidao<EMAIL_ADDRESS>wrote:

Hey! I didn't know anyone was paying attention to these :D
These are slowly getting more specific for my use case (for better of
worse) - and I e been hacking away at them this weekend. The Ansible-php
repository here will go in conjunction with it. Note that it does some
pretty specific things for chroot (when I push it up :D), now including
ensuring the /Dev/random stuff is available, and some files related to
timezone settings
(Chroot is turning out to be a major PITA, but when it comes together,
it'll be pretty nice!)
I push up the php stuff shortly as well. I have a PostgreSQL Ansible role
to publish too...
Glad it's been useful!
On Sat, Feb 21, 2015 at 19:39 veroarts<EMAIL_ADDRESS>wrote:

Closed #1 https://github.com/Servers-for-Hackers/ansible-nginx/issues/1
.
—
Reply to this email directly or view it on GitHub
https://github.com/Servers-for-Hackers/ansible-nginx/issues/1#event-239693920
.


Add GO111MODULE=on to readme

Discovered via https://github.com/urfave/cli/issues/957 and the research I did for https://github.com/urfave/cli/issues/952, GO111MODULE=on is required for some users when downloading v2.

To be honest, perhaps we should specify the go version required.

Perhaps we should specify the go version required

We do, but the wording makes it a bit easy to miss IMO. Here's the readme right now =>

Make sure you have a working Go environment. Go version 1.10+ is supported. See the install instructions for Go.

I think I'll take a pass on updating it for visibility.


fix: remove account check for tx serialization [APE-921]

What I did
There was a problem for me that happens when i am using sender as impersonated accounts like in the feature of contract calling another contract. If the gas tracking is on with tests, this check i deleted causing failed gas calculation. I looked up the address it gave me with signature and it is not known, it is not a contract/unlocked account/test account.

fixes: #
How I did it

How to verify it

Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

it is probably better at least for now to handle signature error during the gas tracking stuff

it is probably better at least for now to handle signature error during the gas tracking stuff

it would basically ignore any tx related with those then? currently deleting there on spot actually including them which is better imo

would be consider this one instead: https://github.com/ApeWorX/ape/pull/1428 ?
cc @fubuloubu wondering your thoughts on because you have other use-cases for needing this

would be consider this one instead: https://github.com/ApeWorX/ape/pull/1428 ?
cc @fubuloubu wondering your thoughts on because you have other use-cases for needing this

Yeah, basically the node doesn't enforce signature checks, so neither should we

closing in favor of https://github.com/ApeWorX/ape/pull/1428

@bilbeyt let us know if #1428 doesn't solve your problem somehow

@bilbeyt let us know if #1428 doesn't solve your problem somehow

It is working for me thanks, although i wasnt expecting to see some negative gas usage on table, i dont know the reason.

@bilbeyt let us know if #1428 doesn't solve your problem somehow

It is working for me thanks, although i wasnt expecting to see some negative gas usage on table, i dont know the reason.

gas usage is a complicated topic, on occasion the refund rules could make certain functions cost a negative amount (although the whole transaction is still net positive in terms of gas use)


Spawn a process for each file in a directory

I'm running into some scalability issues using the following approach:
{
    "scripts": {
      "mass": "concurrently \"npm:accounts/*\"",
      "accounts/1": "ts-node src/index.ts --settings %npm_lifecycle_event%.json",
      "accounts/2": "ts-node src/index.ts --settings %npm_lifecycle_event%.json",
      "accounts/3": "ts-node src/index.ts --settings %npm_lifecycle_event%.json"
    }
}

Note: %npm_lifecycle_event% evaluates to the name of the npm script (e.g. accounts/1)
Ideally, I would like to be able to just specify the directory, then have concurrently spawn a new process for each file in that directory, passing the path to the file to the underlying script.
Is there a way to do this? Currently, I need to add a new script for each account file manually.

Was about to suggest exactly this! 👍 Thanks for reporting back!


[branch-2.9] Fix no durable cursor leak problem

Motivation
There exists potential non-durable cursor leak problem, if deleteCursor called but without deactive this cursor.
Master branch has fix this issue by #17273
Modifications
Deactive cursor  in deleteCursor
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
https://github.com/gaozhangmin/pulsar/pull/2

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Hook does NOT work with DebugLevel and TraceLevel

The last 2 lines in the function main will not display 2 logging messages in the terminal.
// WriterHook is a hook that writes logs of specified LogLevels to specified Writer
type WriterHook struct {
	Writer    io.Writer
	LogLevels []log.Level
}

// Fire will be called when some logging function is called with current hook
// It will format log entry to string and write it to appropriate writer
func (hook *WriterHook) Fire(entry *log.Entry) error {
	line, err := entry.String()
	if err != nil {
		return err
	}
	_, err = hook.Writer.Write([]byte(line))
	return err
}

// Levels define on which log levels this hook would trigger
func (hook *WriterHook) Levels() []log.Level {
	return hook.LogLevels
}

func main() {
	logger := log.New()
	logger.SetOutput(ioutil.Discard)
	logger.SetFormatter(&log.TextFormatter{
		ForceColors: true,
	})
	writerHook := &WriterHook{ // Send logs with level higher than warning to stderr
		Writer: os.Stdout,
		LogLevels: []log.Level{
			log.PanicLevel,
			log.FatalLevel,
			log.ErrorLevel,
			log.WarnLevel,
			log.InfoLevel,
			log.DebugLevel,
		},
	}
	logger.AddHook(writerHook)

	logger.WithField("function", "main").Warn("Start ...")

	for i := 0; i < 10; i++ {
		logger.WithFields(log.Fields{
			"animal": "walrus",
			"number": 1,
			"size":   10,
		}).Info("A walrus appears")
		time.Sleep(time.Second)
	}

	logger.WithField("function", "main").Debug("Debug stop ...")
	logger.WithField("function", "main").Trace("Trace stop ...")
}

Your log level if default, as I know the default level is info.
try to logger.SetLevel(log.TraceLevel) then don't forget to add LogLevels in WriterHook

@adzimzf : Thanks. It works well.

@adzimzf : Thanks. It works well.


View Records 🎉 🚀 ✔

View Records 🎉 🚀 ✔

Used preprocessed HTML file with embedded Ruby code.
Used layouts and templates for shared content.
Use methods.

Hi @Nizamuddin4493 👋
I appreciate your efforts in the code, and I want to highlight a few crucial points that may have been overlooked in my initial review. I regret not bringing these to your attention earlier, as the subsequent reviewer also missed them due to my oversight. I sincerely apologize for any confusion this may have caused.
To enhance the overall quality of your project, I suggest addressing the following areas:
user#show Page Title:

[ ] On the user#show page, the displayed title is 'hello', was used in place of the expected text description. Let's ensure the text description is accurately presented to enhance the user experience. 🙏

Incorrect Navigation for 'See all Post' Link:
The See all Post link is intended to navigate users to the posts#index page. However, in your current implementation, it redirects to a post#show page; it appends the id of the user to the post#index page URL. Let's rectify this to ensure the correct navigation behavior.
Incomplete Display on posts#index Page:
The posts#index page should display all posts, but your current implementation is not achieving this. Let's work on refining the post#index page to accurately showcase all posts as intended.
Your attention to these points will contribute significantly to the project's improvement. Thank you for your dedication to enhancing the codebase. Let me know if you have any questions or need further clarification. 👍"
Cheers! 😃


GDPR / Data protection questions

Wow, this is great work, thank you!
I would love to test this in my live environment, but unfortunately our customer data is very sensitive and we are based in the EU where GDPR regulations apply.
My questions are:

Which data will leave our server / will be sent to ChatGPT Servers?
Only the received message from the customer or also his name / email adress etc.?

When will it be sent to them? Only if I want to (manually) generate a ChatGPT response proposal or immediately after the customer has sent his message to us?

Do you know what OpenAI will do with our data? Will any humans on their side be able to read it? Will they be allowed to train their AI models with it?

Do you think there might be an alternative AI API with Servers based in Europe available in the near future and you might support it with your plugin also?

Thank you very much for your efforts!
Would love to help you with testing etc.

I would love if there were private LLMs that could be used as well. The Ollama project by Meta is interesting, but currently not hosted in the cloud as far as I know, but that could be something someone could throw up on a VPS and possibly rewrite the code in this module to interact with.
Either way, OpenAI's API blog suggests that they do not use data to train on unless you give it express permissions in your account settings:
https://openai.com/policies/terms-of-use

Hello, sorry for the late response, I've been very busy lately. Thank you for your kind words!

Depends on the module settings. By default, only the text of the message is sent, but in the settings you can enable sending of the customer’s name, email and conversation subject.
Only when you request ChatGPT response. In the future, I plan to automatically generate responses when a new message arrives from a client, but this will also be configured in the module settings.
Sorry, unfortunately I don’t know.
I don’t know about the appearance or existence of such an API, but if something similar exists, I will be happy to add integration with such an API to the module.
ruess gave examples of such APIs, if necessary, I can add integration with them.


fix(value): improve value setting workflow #58

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #58, #56, #42, #60
Summary:
Significant changes to the workflow for setting the value. This corrects issues where the logic was previously recursive and causing the wrong values to end up in the input. This also corrects the behavior where a required datepicker was completely broken and no value could be set.
This also adds correct validation when setting the value of the datepicker.
Type of change:
Please delete options that are not relevant.

[x] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

test/auro-datepicker.test.js:

 ❌ auro-datepicker > handles the required state being set
      AssertionError: expected null to equal 'valueMissing'
        at o.<anonymous> (test/auro-datepicker.test.js:59:53)

 ❌ auro-datepicker > respects maxDate setting
      AssertionError: expected null to equal 'valid'
        at o.<anonymous> (test/auro-datepicker.test.js:86:53)

 ❌ auro-datepicker > respects minDate setting
      AssertionError: expected null to equal 'valid'
        at o.<anonymous> (test/auro-datepicker.test.js:104:53)

Chrome: |██████████████████████████████| 1/1 test files | 4 passed, 3 failed

Code coverage: 88.78 %
Coverage for branches failed with 69.04 % compared to configured 80 %
View full coverage report at coverage/lcov-report/index.html

Finished running tests in 4.3s, failed to meet coverage threshold.

ERROR: "test" exited with 1.

None of these tests fail when properly linking the head of the dependent auro-input PR.
Please check your work and try again.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


failed vs. completed

I'm seeing this behavior where a job will sometimes show up as "failed" and othertimes show up as "completed" (even though it has both failedAt and failedReason values)
I realized what caused this difference:
agenda.define('...', (job, done) => {
   // this job will show up in the "completed" bucket
   done('Something went wrong')
})

agenda.define('...', (job, done) => {
   // this job will show up in the "failed" bucket
   job.fail('Something went wrong')
})

In the above 2 examples both jobs appear to have the same attributes:

There's a couple things I can't figure out -

How does Agendash determine if the job is "failed" or "completed" if the attributes of the job look exactly the same? (I tried to find this difference in the source, but I couldn't quite figure it out)
Even though both these jobs have "nextRunAt" times that are in the past, they are not be run again, this might be more of an issue with agenda or how I'm using agenda, but maybe it is related.

Thanks!

This was easily the most difficult part of creating this project. The rules were made mostly by trial and error and guesswork.
In this case, it is definitely a timing issue with Agenda.
The lastRunAt is set to new Date() here: https://github.com/rschmukler/agenda/blob/master/lib/job.js#L180
and failedAt is set to new Date() here: https://github.com/rschmukler/agenda/blob/master/lib/job.js#L169
I think Agenda should be able to ensure those are the same value. It would be difficult, though.

For reference, here is the logic I wrote:
https://github.com/joeframbach/agendash/blob/master/lib/agendash.js#L234-L263
completed: if lastFinishedAt exists, and lastFinishedAt > (failedAt or zero)
failed: if lastFinishedAt exists, and failedAt exists, and lastFinishedAt === failedAt
running: if lastRunAt exists, and lastRunAt > lastFinishedAt.
scheduled: if nextRunAt exists, and nextRunAt >= now
queued: if nextRunAt exists, and nextRunAt < now, and nextRunAt >= lastFinishedAt
repeating: if repeatInterval exists and is not null

Thank you, mystery solved! Wow, looking at it more closely, in my example the times are not ===. The times are off by 1 millisecond.

While we're at it, do you happen to know why both of these jobs are not getting re-tried? They both have a value for nextRunAt which makes me think they would be run again.
Thank you again for the quick reply!

@dylanjha I remember seeing some issues or pull requests regarding this at Agenda repo: https://github.com/rschmukler/agenda/issues (which is sadly not very well maintained at the moment)

@dylanjha there's a PR exactly for this: https://github.com/rschmukler/agenda/pull/433

thank you so much @simison

A simple fix for this until rschmukler/agenda#433 gets merged is:
agenda.on('fail', function (error, job) {
  job.attrs.lastFinishedAt = job.attrs.failedAt
  job.save()
})


@stylistic/max-len not enabled when extending from plugin:@stylistic/all-extends?

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Describe the bug
With the following .eslintrc.cjs...
module.exports = {
    extends: [
        "eslint:all",
        "plugin:@typescript-eslint/all",
        "plugin:@stylistic/disable-legacy",
        "plugin:@stylistic/all-extends",
    ],
    parser: "@typescript-eslint/parser",
    parserOptions: {
        project: ["./tsconfig.json"],
    },
    plugins: [
        "@typescript-eslint",
        "@stylistic"
    ],
    root: true,
};

... when I issue the following command:
npx eslint --print-config .eslintrc.cjs >eslint-config.json

The json produced does not include @stylistic/max-len, why?
Packages:
    "@stylistic/eslint-plugin": "^1.5.1",
    "@typescript-eslint/eslint-plugin": "^6.14.0",
    "@typescript-eslint/parser": "^6.14.0",
    "eslint": "^8.55.0",

This works as expected with the 1.4.1 version.
Reproduction
npx eslint --print-config .eslintrc.cjs >eslint-config.json
Contributes

[ ] I am willing to submit a PR to fix this issue
[ ] I am willing to submit a PR with failing tests

It's mentioned here: https://eslint.style/guide/config-presets#enable-all-avaible-rules
We are not including non-fixable rules from it as we want to keep the produced code error-free.

It's mentioned here: https://eslint.style/guide/config-presets#enable-all-avaible-rules
We are not including non-fixable rules from it as we want to keep the produced code error-free.

Not quite what I was expecting but sounds reasonable. Is there a list of non-fixable rules I can extend from then?
Thanks, so going by this reasoning the all list would neither include no-mixed-operators and a few other useful rules. I don't quite understand what problems/conflicts would arise from including them?


Added test case for using RequestDumpingHandler

Added test case for using RequestDumpingHandler into integration tests; test implementation for RFE EAP7-428

Can one of the admins verify this patch?

this is ok to test

Windows Build 2005 is now running using a merge of 2bffe33f9556ebf7c6320ba1bcc5cfb3f4f92352

Linux with security manager Build 1828 is now running using a merge of 2bffe33f9556ebf7c6320ba1bcc5cfb3f4f92352

Linux Build 6930 is now running using a merge of 2bffe33f9556ebf7c6320ba1bcc5cfb3f4f92352

Linux with security manager Build 1828 outcome was FAILURE using a merge of 2bffe33f9556ebf7c6320ba1bcc5cfb3f4f92352
Summary: Tests failed: 1 (1 new), passed: 865, ignored: 311 Build time: 0:06:15
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.web.handlers.RequestDumpingHandlerTestCase.testReqDumpHandlerOn: <no details avaliable>

Windows Build 2005 outcome was SUCCESS using a merge of 2bffe33f9556ebf7c6320ba1bcc5cfb3f4f92352
Summary: Tests passed: 2912, ignored: 372 Build time: 0:47:57

Linux Build 6930 outcome was FAILURE using a merge of 2bffe33f9556ebf7c6320ba1bcc5cfb3f4f92352
Summary: Tests failed: 63 (63 new), passed: 2778, ignored: 370, muted: 3 Build time: 0:58:26
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.web.handlers.RequestDumpingHandlerTestCase.testReqDumpHandlerOn: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.web.SimpleWebTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.registry.RegistryTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.dispatcher.CommandDispatcherTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.singleton.SingletonServiceTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredQueue: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredTopic: <no details avaliable>

org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutToBackupNotRelayed: <no details avaliable>

org.jboss.as.test.multinode.transaction.TransactionInvocationTestCase: org.jboss.as.test.multinode.ejb.timer.database.DatabaseTimerServiceMultiNodeExecutionDisabledTestCase: <no details avaliable>

org.jboss.as.test.multinode.transaction.TransactionInvocationTestCase: org.jboss.as.test.multinode.ejb.timer.database.DatabaseTimerServiceMultiNodeTestCase: <no details avaliable>

##### there are 53 more failed tests, see build details

Linux Build 6947 is now running using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f

Windows Build 2022 is now running using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f

Linux with security manager Build 1845 is now running using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f

Linux with security manager Build 1845 outcome was FAILURE using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f
Summary: Tests failed: 1, passed: 865, ignored: 311 Build time: 0:06:27
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.web.handlers.RequestDumpingHandlerTestCase.testReqDumpHandlerOn: <no details avaliable>

Thanks Tomaz for your review!
I have rewritten test according to your proposes - used ServerSetupTask for server configuration preparation and also used separate logger for dumping messages.
I am not sure why this test failed for wildfly-ci as it is working for me on my local machine... lets try again...

Windows Build 2022 outcome was SUCCESS using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f
Summary: Tests passed: 2913, ignored: 372 Build time: 0:47:53

Linux Build 6947 outcome was FAILURE using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f
Summary: Tests failed: 88 (29 new), passed: 2664, ignored: 370, muted: 4; org.wildfly:wildfly-testsuite-integration-domain Build time: 0:54:45
Build problems:
Failed tests detected
Process exited with code 137
Failed tests
org.jboss.as.test.integration.ws.wsse.signencrypt.EJBSignEncryptTestCase.encryptedAndSignedRequest: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLIDPInitiatedTestCase.testPostOriginalRequest: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLRedirectBindingWithSignaturesTestCase.testFederationWithGlobalLogout: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLRedirectBindingWithSignaturesTestCase.testFederationWithLocalLogout: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.RestoreOriginalRequestTestCase.testPostOriginalRequest: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.RestoreOriginalRequestTestCase.testPostOriginalRequestWithParams: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.RestoreOriginalRequestTestCase.testRedirectOriginalRequest: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLRedirectBindingTestCase.testFederationWithGlobalLogout: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLRedirectBindingTestCase.testFederationWithLocalLogout: <no details avaliable>

org.wildfly.test.integration.security.picketlink.core.PartitionManagerProducerTestCase: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLPostBindingWithSignaturesTestCase: org.wildfly.test.integration.security.picketlink.federation.SAMLMetadataTestCase.testFederationWithGlobalLogout: <no details avaliable>

##### there are 78 more failed tests, see build details

Linux Build 6952 is now running using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f

Linux Build 6952 outcome was FAILURE using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f
Summary: Tests failed: 73 (9 new), passed: 2762, ignored: 370, muted: 3 Build time: 0:58:18
Build problems:
Failed tests detected
Process exited with code 1
Failed tests
org.jboss.as.test.manualmode.ws.WSAttributesChangesTestCase.testWsdlHostChanges: <no details avaliable>

org.jboss.as.test.manualmode.ws.WSAttributesChangesTestCase.testWsdlPathRewriteRuleChanges: <no details avaliable>

org.jboss.as.test.manualmode.ws.WSAttributesChangesTestCase.testWsdlPortChanges: <no details avaliable>

org.jboss.as.test.manualmode.ws.WSAttributesChangesTestCase.testWsdlUriSchemeChanges: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLPostBindingWithSignaturesTestCase: org.wildfly.test.integration.security.picketlink.federation.SAMLRedirectBindingWithSignaturesTestCase.testFederationWithGlobalLogout: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLPostBindingWithSignaturesTestCase: org.wildfly.test.integration.security.picketlink.federation.SAMLRedirectBindingWithSignaturesTestCase.testFederationWithLocalLogout: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLPostBindingWithSignaturesTestCase: org.wildfly.test.integration.security.picketlink.federation.RestoreOriginalRequestTestCase: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLPostBindingWithSignaturesTestCase: org.wildfly.test.integration.security.picketlink.federation.SAMLRedirectBindingTestCase: <no details avaliable>

org.wildfly.test.integration.security.picketlink.federation.SAMLPostBindingWithSignaturesTestCase: org.wildfly.test.integration.security.picketlink.federation.SAMLMetadataTestCase: <no details avaliable>

org.jboss.as.test.integration.ws.wsse.signencrypt.EJBSignEncryptTestCase.encryptedAndSignedRequest: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.web.SimpleWebTestCase: <no details avaliable>

##### there are 63 more failed tests, see build details

Linux Build 6988 is now running using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f

Linux Build 6988 outcome was FAILURE using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f
Summary: Tests failed: 2 (1 new), passed: 2916, ignored: 341, muted: 2 Build time: 0:51:12
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.timerservice.mgmt.PersistentCalendarTimerManagementTestCase.testResourceExistence: <no details avaliable>

org.jboss.as.test.integration.ws.wsse.signencrypt.EJBSignEncryptTestCase.encryptedAndSignedRequest: <no details avaliable>

test fails seems unrelated...

retest this please

Windows Build 2070 is now running using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f

Linux with security manager Build 1892 is now running using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f

Linux Build 7015 is now running using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f

Linux with security manager Build 1892 outcome was FAILURE using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f
Summary: Tests failed: 1, passed: 872, ignored: 280 Build time: 0:06:33
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.web.handlers.RequestDumpingHandlerTestCase.testReqDumpHandlerOn: <no details avaliable>

Windows Build 2070 outcome was SUCCESS using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f
Summary: Tests passed: 2946, ignored: 344 Build time: 0:49:33

Linux Build 7015 outcome was FAILURE using a merge of 5df143976eb3682b37954c74567ee4b8f078d16f
Summary: Tests failed: 3 (3 new), passed: 2941, ignored: 344, muted: 2 Build time: 0:50:44
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.web.handlers.RequestDumpingHandlerTestCase.testReqDumpHandlerOn: <no details avaliable>

org.jboss.as.test.integration.ejb.client.descriptor.EJBClientDescriptorTestCase.testClientPropertiesReplacementInConfig: <no details avaliable>

org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testConcurrentFailover: <no details avaliable>

Linux Build 7032 is now running using a merge of 18b5e98ddf0aeab457ac613dc11e0ac94c3b7a4e

Windows Build 2087 is now running using a merge of 18b5e98ddf0aeab457ac613dc11e0ac94c3b7a4e

Linux with security manager Build 1907 is now running using a merge of 18b5e98ddf0aeab457ac613dc11e0ac94c3b7a4e

Thanks for retesting!
I am no sure why exactly this test: RequestDumpingHandlerTestCase.testReqDumpHandlerOn has failed as on my machine this test and even ALL others are successfully passing.
I added sleep loop when searching for data in log file as I am suspecting that there was not enough time for system to write data down into log file which is examinate. Next test run will show...

Linux with security manager Build 1907 outcome was FAILURE using a merge of 18b5e98ddf0aeab457ac613dc11e0ac94c3b7a4e
Summary: Tests failed: 1, passed: 872, ignored: 280 Build time: 0:07:29
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.web.handlers.RequestDumpingHandlerTestCase.testReqDumpHandlerOn: <no details avaliable>

Windows Build 2087 outcome was FAILURE using a merge of a420323c5f844c43696837a6527799dd636ea8e6
Summary: Tests failed: 91 (80 new), passed: 2778, ignored: 341, muted: 2 Build time: 0:59:52
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.smoke.mgmt.datasource.DataSourceOperationsUnitTestCase.testXaDsWithSystemProperties: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredQueue: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredTopic: <no details avaliable>

org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutToBackupNotRelayed: <no details avaliable>

org.jboss.as.test.manualmode.ejb.client.outbound.connection.RemoteOutboundConnectionReconnectTestCase.testRemoteServerRestarts: <no details avaliable>

org.jboss.as.test.manualmode.ejb.client.outbound.connection.RemoteOutboundConnectionReconnectTestCase.testRemoteServerStartsLate: <no details avaliable>

org.jboss.as.test.manualmode.layered.LayeredDistributionTestCase.testLayeredProductVersion: <no details avaliable>

org.jboss.as.test.manualmode.layered.LayeredDistributionTestCase.testLayeredDeployment: <no details avaliable>

org.jboss.as.test.manualmode.parse.ParseAndMarshalModelsTestCase.testEAP610StandaloneJtsXml: <no details avaliable>

org.jboss.as.test.manualmode.parse.ParseAndMarshalModelsTestCase.testEAP620StandaloneHornetQCollocatedXml: <no details avaliable>

org.jboss.as.test.manualmode.parse.ParseAndMarshalModelsTestCase.test720StandaloneMinimalisticXml: <no details avaliable>

##### there are 81 more failed tests, see build details

Linux Build 7032 outcome was FAILURE using a merge of a420323c5f844c43696837a6527799dd636ea8e6
Summary: Tests failed: 94 (76 new), passed: 2772, ignored: 341, muted: 4 Build time: 0:59:57
Build problems:
Failed tests detected
Process exited with code 1
Failed tests
org.jboss.as.test.integration.ejb.remote.suspend.EjbRemoteSuspendTestCase.testSuspendedCallRejected: <no details avaliable>

org.jboss.as.test.integration.ws.wsse.signencrypt.SignEncryptMultipleClientsTestCase.encryptedAndSignedRequestFromJohn: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredQueue: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredTopic: <no details avaliable>

org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutToBackupNotRelayed: <no details avaliable>

org.jboss.as.test.manualmode.ejb.client.cluster.EJBClientClusterConfigurationTestCase.testServerToServerClusterFormation: <no details avaliable>

org.jboss.as.test.manualmode.ejb.client.outbound.connection.RemoteOutboundConnectionReconnectTestCase.testRemoteServerRestarts: <no details avaliable>

org.jboss.as.test.manualmode.ejb.client.outbound.connection.RemoteOutboundConnectionReconnectTestCase.testRemoteServerStartsLate: <no details avaliable>

org.jboss.as.test.manualmode.layered.LayeredDistributionTestCase.testLayeredProductVersion: <no details avaliable>

org.jboss.as.test.manualmode.layered.LayeredDistributionTestCase.testLayeredDeployment: <no details avaliable>

org.jboss.as.test.manualmode.parse.ParseAndMarshalModelsTestCase.testEAP610StandaloneJtsXml: <no details avaliable>

##### there are 84 more failed tests, see build details

Linux Build 7036 is now running using a merge of a420323c5f844c43696837a6527799dd636ea8e6

Linux with security manager Build 1912 is now running using a merge of a420323c5f844c43696837a6527799dd636ea8e6

Windows Build 2091 is now running using a merge of a420323c5f844c43696837a6527799dd636ea8e6

Linux with security manager Build 1912 outcome was SUCCESS using a merge of a420323c5f844c43696837a6527799dd636ea8e6
Summary: Tests passed: 873, ignored: 280 Build time: 0:06:38

Windows Build 2091 outcome was SUCCESS using a merge of a420323c5f844c43696837a6527799dd636ea8e6
Summary: Tests passed: 2946, ignored: 344 Build time: 0:51:12

Linux Build 7036 outcome was FAILURE using a merge of a420323c5f844c43696837a6527799dd636ea8e6
Summary: Tests failed: 92 (1 new), passed: 2775, ignored: 342, muted: 3 Build time: 0:59:25
Build problems:
Failed tests detected
Process exited with code 1
Failed tests
org.wildfly.test.integration.security.picketlink.federation.SAMLPostBindingWithSignaturesTestCase: org.wildfly.test.integration.security.picketlink.federation.SAMLIDPInitiatedTestCase.testPostOriginalRequest: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.web.SimpleWebTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.registry.RegistryTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.dispatcher.CommandDispatcherTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.singleton.SingletonServiceTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredQueue: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredTopic: <no details avaliable>

org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutToBackupNotRelayed: <no details avaliable>

org.jboss.as.test.multinode.transaction.TransactionInvocationTestCase: org.jboss.as.test.multinode.ejb.timer.database.DatabaseTimerServiceMultiNodeExecutionDisabledTestCase: <no details avaliable>

org.jboss.as.test.multinode.transaction.TransactionInvocationTestCase: org.jboss.as.test.multinode.ejb.timer.database.DatabaseTimerServiceMultiNodeTestCase: <no details avaliable>

##### there are 82 more failed tests, see build details

Failed tests seems unrelated, retest this please.

Linux Build 7039 is now running using a merge of a420323c5f844c43696837a6527799dd636ea8e6

Windows Build 2094 is now running using a merge of a420323c5f844c43696837a6527799dd636ea8e6

Linux with security manager Build 1915 is now running using a merge of a420323c5f844c43696837a6527799dd636ea8e6

Linux with security manager Build 1915 outcome was SUCCESS using a merge of a420323c5f844c43696837a6527799dd636ea8e6
Summary: Tests passed: 873, ignored: 280 Build time: 0:06:57

Windows Build 2094 outcome was SUCCESS using a merge of a420323c5f844c43696837a6527799dd636ea8e6
Summary: Tests passed: 2946, ignored: 344 Build time: 0:49:29

Linux Build 7039 outcome was FAILURE using a merge of a420323c5f844c43696837a6527799dd636ea8e6
Summary: Tests failed: 1 (1 new), passed: 2942, ignored: 344, muted: 3 Build time: 0:51:26
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.mdb.cdi.MDBRAScopeCdiIntegrationTestCase.testMe: <no details avaliable>

Failure seems unrelated...

Windows Build 2268 is now running using a merge of f7a73e75761d8a65ab7cdc5f0e6b0648600f3e22

Linux Build 7213 is now running using a merge of f7a73e75761d8a65ab7cdc5f0e6b0648600f3e22

Linux with security manager Build 2084 is now running using a merge of f7a73e75761d8a65ab7cdc5f0e6b0648600f3e22

Added test checking basic dumped values in log when request from HTTPS is performed and test when http upgrade to websockets is performed. Code is now splitted into two files to preserve readibility.
Could some of admins review it please?

Linux with security manager Build 2084 outcome was SUCCESS using a merge of f7a73e75761d8a65ab7cdc5f0e6b0648600f3e22
Summary: Tests passed: 880, ignored: 281 Build time: 0:06:29

Linux Build 7213 outcome was SUCCESS using a merge of f7a73e75761d8a65ab7cdc5f0e6b0648600f3e22
Summary: Tests passed: 2960, ignored: 353 Build time: 0:46:44

Windows Build 2268 outcome was SUCCESS using a merge of f7a73e75761d8a65ab7cdc5f0e6b0648600f3e22
Summary: Tests passed: 2958, ignored: 354, muted: 1 Build time: 0:47:50

Thanks for review and merge Jason!


Setting targetColor, toneId do not work via mqtt until manual set in UI or server restart

I've uncovered this scenario for both RGB bulbs and the Aeotec Siren.
Immediately after pairing these devices do not respond if I set these values via mqtt.  No error, simply no response.
I found that setting these values via mqtt does begin working in these two scenarios.
Once I manually set a value on these properties via the zwavejs built in UI, the devices begin responding properly to mqtt commands.
Once I restart the zwavejs service the devices begin responding properly to mqtt commands.
Not sure if we've overlooked something in the documentation, or if there is some other command we need to send to make this work, so I thought I'd ship a question out for support.

Thanks for the quick reply, I can confirm that my issue is resolved with the latest version.  I had believed that I tested it but was mistaken.
Regards


Failed to resolve reference '' to type 'User'

Describe the bug
I recently added a lot of users and their annotations using the API, however, when I tried to view the data in the project, I get a blank screen and the following error in the console:
Failed to resolve reference '77' to type 'User' (from node: /taskStore/list/24/annotators/0/user)

Where the error is repeated multiple times but the reference number is different.
To Reproduce
Steps to reproduce the behavior:

Create a user via the API
Get their token
Create a task and annotation using their token
Try to view the project and am greeted with a blank screen.

Expected behavior
The tasks should show up in LS.
Screenshots

Environment (please complete the following information):

OS: Amazon Linux 2
Label Studio Version: 1.2.0

I fixed this by manually assigning the users to the organization via the DB.
It seems that the organization ID must be specified in order to avoid this error, despite the docs stating that it can be nullable.
This should be documented somewhere.

@smoreface


Can not add Card

Hi TECH7Fox,
"Click on add card and scroll down to and choose Custom: SIP Card"
This is not possible. There is no card "Custom: SIP Card" that i can choose.
I also have the asterisk integration from you. Is this maybe the problem?
I want the ha-sip card also.
Thanks in advance

Hi @dernassesmart,
Yes, this is because of the integration. I am almost done with the card and then I will continue with the integration.
For now I recommend disabling the integration until the next update, also because there are some bugs which will break the sensors over time.

Thank you very much for the very quick help! I will Test is today.
Best Regards
dernassesmart


binary_sensor.easee_home_#####_online not disconnected?

Hi. Is this sensor reporting the connection between the integration to Easee's servers or the connection between Easee's servers and the charger? My Easee mobile app reports the chager as being offline (as I have pulled the circut braker) but the binary sensor reports claims it's online. The other sensors work as expected. It would be cool if this could report on the charger being offline as I would like to use this as a way to notify me if the charger trips the circut braker or goes offline and stops charging the car.

The intention is that sensor should change to offline state when the charger (I assume you are talking about a charger) has not sent any updates for 17 minutes independent of the reason. You should be able to see the time when the last update known as "latestPulse" was received if you look at the attributes of the sensor. It is updated every time some new data is received from the cloud servers.
What you are saying seems strange, a charger that has no power should not be able to send updates. But maybe it is just a question of waiting 17 minutes?

Please close the issue if this solved your problem.

Closing due to lack of further activity.


Group imports together with imports_granularity results in non-idempotent formatting

When group_imports = "StdExternalCrate" is combined with imports_granularity = "Module", rustfmt can format a file in a non-idempotent way, i.e. running rustfmt twice in a row results in a different formatting.
Reduced from a case in the stdlib (https://github.com/rust-lang/rust/issues/126394).
Minimal repro:
# rustfmt.toml
version = "Two"
group_imports = "StdExternalCrate"
imports_granularity = "Module"

$ rustfmt --version
rustfmt 1.7.0-nightly (72fdf91 2024-06-05)

# file.rs
use a::c;
// foo
use a::b;
use a::d;

First run (rustfmt file.rs):
// foo
use a::b;
use a::{c, d};

Second run (rustfmt file.rs):
// foo
use a::{b, c, d};

Removing the group_imports or imports_granularity options removes the issue. The problem seems to be caused by the comment, without it it works fine.

I would argue that the second run shouldn't change anything -- that the comment on use a::b; should prevent it being merged with use a::{c, d};. This is how things behave with an attribute, as in this example:
use a::c;
#[cfg(windows)]
use a::b;
use a::d;

which ends up like this (even after multiple rustfmt invocations):
#[cfg(windows)]
use a::b;
use a::{c, d};

Yeah, I also like that better. In any case, any second run shouldn't change anything, that's a bug. Let's hope that it won't be occuring more often in the rustc codebase.


Fix hu/validation

Thanks, but can you help us to translate dimensions and file ?

Sorry, I didn't notice they were untranslated. Done.

Thanks


PrePublishSquashPlugin: Always store metadata of a image tarball

Resolves: #163

Closing this after discussing on IRC.

To elaborate a bit. With current codebase, this can't work because when the image is loaded, there is no way to do the metadata; we would need to

export the image and do the metadata
or never let squash tool load the image & do the metadata & load it back to engine ourselves

So basically this is a RFE.


AC unit is discovered and added but nothing work

Hi All,
I added without issue to the HA Comfree 7000 but device is not receiving any command from HA.
Ha is showing a set temperature and current room temperature but when you try to change it nothing happened.
Can you help me to solve it?
Thank you
Dimitrije

Closing as investigation is ongoing in#72


[docs] Support inject dynamic theme

[x] I have followed (at least) the PR section of the contributing guide.

Closes #41391

I aim to have the documentation site expose a function in the window, such as getInjectTheme. This function will merge with the current docs theme and can be mounted on the window by a Chrome extension. Upon execution, getInjectTheme will return my custom theme options. Additionally, it is necessary to expose the React and MUI instances, as my compiled custom-theme.js depends on them.

Replied here: https://github.com/mui/material-ui/issues/41391#issuecomment-2225926016

For which part of your code needs to get access to react? When looking at the code sample you provide, I see no reference to it.
For material, I see classeNames, which I assume could be replaced by their values, and types which will disappear when transformed to a js code.
Do you already have an implementation of the extension to see how it would work, and to test if it behaves as expected

For which part of your code needs to get access to react? When looking at the code sample you provide, I see no reference to it.
For material, I see classeNames, which I assume could be replaced by their values, and types which will disappear when transformed to a js code.
Do you already have an implementation of the extension to see how it would work, and to test if it behaves as expected

Yes, I have implemented this Chrome extension. Here are some examples I can provide.

After consideration, we can not depend on MUI, we can compile to js code just like you said. But we still need react & react-jsx, because we override some components' default icons, it is ReactNode type, and after compile will need jsx to do the creation. As for the React, we have some custom compennts, need use some hooks API from React, like useForwardRef

@Vxee Can you provide the extension for us to test it?

@Vxee I changed the property to window.MaterialUI to match the branding.

@siriwatknp Thanks a lot! Here is the demo.