New package: K1JT.wsjtx version v2.6.1

[ ] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/111637&drop=dogfoodAlpha

@microsoft-github-policy-service agree

Thanks for the thorough review! Please take another look.


Overhaul build system

This PR overhauls the build system, updating it to use modern CMake and simplifying it in the process.

[ ] Compiles on Manjaro
[x] Compiles on Mac OS ARM architecture
[ ] Compiles on Niagara
[x] Compiles on Beluga
[ ] Compiles on Narval

@paulapatience next time, please make the PR from a branch that is a branch from the lethe repository instead of a fork, this makes testing on multiple machine easier (instead of having to reclone and redo everything anew). This PR will require compilation on a few machines to test if everything is ok.

@paulapatience next time, please make the PR from a branch that is a branch from the lethe repository instead of a fork

Sorry about that. I just need you to invite me to the repository, as I don't currently have write access.

@paulapatience next time, please make the PR from a branch that is a branch from the lethe repository instead of a fork

Sorry about that. I just need you to invite me to the repository, as I don't currently have write access.

No biggie. Added you

@paulapatience  Can you rebase with master? There were some missing includes that prevented compilation on the latest manjaro rolling release. Once this is rebased, I can finish testing on all platforms.


Why is change_plan_swin deleted?

Thanks for your extraoridinary work!
It took me some time to figure out the train-test split in the paper and your code correspondingly.
Until I saw the following issue:
Why all test samples appear in training dataset for Synapse?
However the file was somehow deleted in 9 Oct 2021, the following version committed on 2 Sep 2021 seems right.
Update change_plan_swin.py
Did you deleted it accidently by commit?
best,

I'm sorry for the inconvenience the manner brings to you.  The change_plan_swin.py is not used now, because I think modifying the plan files is cumbersome and you need to run the change_plan_swin.py each time you modify the parameter.
Now, we change the division of the training set and validation set directly in the trainer file as the code below.
https://github.com/282857341/nnFormer/blob/d48aaeb05612a09538f70c38a2357149ea3a7ac0/nnformer/training/network_training/nnFormerTrainerV2_nnformer_synapse.py#L338-L340
And we change the batch size and patch size in the code below:
https://github.com/282857341/nnFormer/blob/d48aaeb05612a09538f70c38a2357149ea3a7ac0/nnformer/run/default_configuration.py#L61-L67

Sorry I am still confused.
It looks like the splits will not change varing to fold (when fold is smaller than 5)?
Because you alter it after loading the pickle file. If nnUNet_plan_and_preprocess is run, the len(splits) would be 5 and the following branch would always be true.
https://github.com/282857341/nnFormer/blob/d48aaeb05612a09538f70c38a2357149ea3a7ac0/nnformer/training/network_training/nnFormerTrainerV2_nnformer_synapse.py#L341-L345
Does it mean that we only need to run one fold in this circumstance?
The only branch splits varing to the fold is that
It exists a splits_final.pkl that contains less fold than the fold than we ask for.
Which goes branch Line322
https://github.com/282857341/nnFormer/blob/d48aaeb05612a09538f70c38a2357149ea3a7ac0/nnformer/training/network_training/nnFormerTrainerV2_nnformer_synapse.py#L332-L335
and
https://github.com/282857341/nnFormer/blob/d48aaeb05612a09538f70c38a2357149ea3a7ac0/nnformer/training/network_training/nnFormerTrainerV2_nnformer_synapse.py#L346-L358

Yes, we only need to run one fold and we do this because we need to follow the split of other methods for each dataset.
If you need to run the cross-validation, you can load the splits from the original plan file.


[X11] Fix Godot stealing focus on alternative window managers

This is taking the changes from https://github.com/Mequam/funky-godot/tree/mequam/feat/xfce4_focus_grab and turning them into a PR (as @Mequam, the original author, requested on https://github.com/godotengine/godot/issues/74378)
Unfortunately, these changes don't fix the issue I am experiencing, but since others (including the original author) wanted to see these changes as a PR, I've gone ahead and created one. :-) It's my understanding that these changes do fix some of the problems from that issue.

Thanks for the review!

This looks reasonable to me (have not tested it so far). I guess it can be combined with https://github.com/godotengine/godot/pull/86671, to only grab re-focus if it's not already focused and some other window of the same app have focus

Yes, I don't think the two PRs should conflict functionality-wise (there may end up being a Git conflict after one of them is merged, because of the proximity of the changed lines) although logically they are working in kind of inverse directions of each other.
Personally, when I test this PR on i3, it doesn't fix any issues for me, but it also doesn't appear to break anything.

Thanks!

Cherry-picked for 4.2.2.

@YuriSizov God's work cherry picking this commit before 4.3. Thank you!!


[Playground] Load categories from BEAM_EXAMPLE_CATEGORIES in checker.py

This resolves issue with checker.py CI/CD failing when adding new examples as it was not loading the list of permitted categories.
resolves #24899

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

LGTM

R: @damccorm


Less verbose

I'm a developer and don't like to see your console.log messages when debugging my sites
[FediAct] Request to http://localhost/api/v1/instance failed.
[FediAct] Does not look like a Mastodon instance.
[FediAct] Will not process this site.
Could you please disable these?
(excellent plugin BTW!)

Hi, you're right, should be disabled. Will be so in the next update. Cheers!

Fixed with https://github.com/Lartsch/FediAct/commit/db33da9d564c4b479907a63a2fa7b0919eed4744 / v<IP_ADDRESS>


Are import statements supported?

I have an index.js with
import utils from 'util'

and  a blank util.js
results in
panic: SyntaxError: index.js: Line 7:1 Unexpected reserved word [recovered]
        panic: Panic at 3: SyntaxError: index.js: Line 7:1 Unexpected reserved word [recovered]
        panic: Panic at 3: SyntaxError: index.js: Line 7:1 Unexpected reserved word

I'm playing with trying to get hubot script running from  a Go application
I've included the load() function from goja/main.go, which seems to work with a simple load('util.js')

Import statements are part of the ES6 standard, not ES5.1 so I'm assuming that this is not implemented yet.

Import statements are not implemented as they are not part of ES5.1 spec. It would be quite easy to replicate node's require() functionality, in fact I've already got a working code which just needs a few touches after which I may add it here.
Supporting import statements would require significantly more effort as it involves extending parser and compiler, there is no plan to add those any time soon, although I'm open to PRs.

@dop251 This might be a funny idea, but maybe you could use Babeljs to transpile ES6 code into ES5 so it can be interpreted through Goja VM?

@iam4x It's not a funny idea at all, this is the recommended way to run ES 2016 code in goja. Unfortunately with imports this also requires some runtime support. I've created a new repo (https://github.com/dop251/goja_nodejs) for nodejs compatibility modules and added a basic support for require(). Give it a go, let me know if there is any problem.


STORM-1060. Serialize Calcite plans into JSON format.

This PR provides an implementation to serialize the results of Calcite to JSON strings. The JSON strings will be passed down to the optimizers and code generators to generate the Storm bolts or Trident functions.

+1


Class Hierarchy feature could coallesce identical implement mixin superclasses

It would be nice if the Observatory "Class Hierarchy" feature merged sibling implicit superclasses created when using mixins.
Right now, if you have two classes Foo and Bar:
class A { } class B { }
class Foo extends A with B { }
class Bar extends A with B { }

...you end up with a tree like this:
 A
 |
 +-- A&B
 |    |
 |    +-- Foo
 |
 +-- A&B
      |
      +-- Bar

...but what you really want to see is:
 A
 |
 +-- A&B
      |
      +-- Foo
      |
      +-- Bar

Actually this might be an artifact of #24964 - since the generic types aren't mentioned, it's not obvious that these are actually different.
The specific case I'm dealing with is the render object hierarchy in Flutter. Run a Flutter app, then go to the class hierarchy, and open up AbstractNode. Under RenderBox it's a bit of a mess. Maybe #24968 combined with #24964 (demangling the names one "with" per level, then adding the generic types) would make this clearer. Then you could merge any sibling branches that are identical.


Two RGB stream recording

Required Info

Camera Model
{ D435 }

Firmware Version
(<IP_ADDRESS>)

Operating System & Version
{Ubuntu 20.04}

Kernel Version (Linux Only)
(5.10.104-tegra)

Platform
NVIDIA Jetson

SDK Version
{ legacy / 2.53.1 }

Language
{N/A}

Segment
{NA }

Issue Description
This is more like a question than a issue.
I want to know if it is possible to record video streams from both RGB camers?

Ah Okay. Thank you for the quick reply. :)
I am closing this.

Ah okay. Understood. Thank you so much for the quick reply. :)
I am closing this.

I have another question. Is it possible to record a video of RGB frame and point cloud from SDK?

You are very welcome, @Aki1608    :)
You could not record a point cloud, but what you could do is record a bag file of the RGB and depth streams and then use that bag file as the data source in a script instead of a live camera and generate a pointcloud from the stored individual stream data in real-time.
Individual depth and RGB streams can also be saved as non-interactive .avi video files, like in the Python script for doing so at https://github.com/IntelRealSense/librealsense/issues/2731#issuecomment-529938267

Okay.  Thank you. :)


Bug in Sample code in creating-satellite-assemblies-for-desktop-apps.md

[Enter feedback here]
The example under 'Satellite Assemblies: An Example' is incorrect. The instructions say to create resx (or text) files named Greeting.resx, etc.
The C# source creates a resource manager with:
ResourceManager rm = new ResourceManager("Example.Greetings",
typeof(Example).Assembly);
The file name 'Example.Greetings' should be 'Example.Greeting', e.g.
ResourceManager rm = new ResourceManager("Example.Greeting",
typeof(Example).Assembly);
Alternatively, you can change the resx file names to Greetings.resx, Greetings.fr-FR.resx, etc. to match the ResourceManager constructor.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6d3ff457-56ee-b368-af21-d37bdea825b2
Version Independent ID: 96d617db-6ad2-594e-643a-4006188de390
Content: Creating Satellite Assemblies for Desktop Apps
Content Source: docs/framework/resources/creating-satellite-assemblies-for-desktop-apps.md
Product: dotnet-framework
GitHub Login: @adegeo
Microsoft Alias: adegeo

Thank you for opening this issue. I'll add it to the backlog. If you would like to contribute, you can submit a fix by editing the original article. Click on the Content Source link at the bottom of your original comment. To learn how to edit, see the Editing files in a repository article from GitHub.
Thanks again!


POI Creation

create a question type that creates a POI with attribute questions.

Duplicate with #31, closing


SubQueries in where() not working properly

I would like to do something like this:
$query = QB::table('my_table2')->select('id')
         ->where('table_id', QB::subQuery($subQuery)))

It produces good working code with rawSql() but don't work itself.
To fix this problem I need to do workaround like this:
$query = QB::table('my_table2')->select('id')
          ->where(QB::raw('table_id = ' . QB::subQuery($subQuery)))

I wanted to but I couldn't reproduce your case.
I checked and in my opinion it works.
Could you give us all query?
[Pixie v2.0, Mysql]


use SymfonyStyle for command output

I started to implement SymfonyStyle to the commands, I will follow up with the other commands if you like this.
Here are some screenshots:

More Screenshots here:
https://github.com/doctrine/doctrine2/pull/6655#issuecomment-326205417
Is the branch the correct one or shall I switch?
Cheers, Oskar

fyi @javiereguiluz ;-)

@OskarStark just a remark, please make sure you send test updates too.

Ok, lets check the build 😄

Hmm, this is a bit strange.
on my local machine, all tests are running, if my shell is big, if i minimize it it delivers the same error results like travis:
5) Doctrine\Tests\ORM\Tools\Console\Command\ClearCacheEntityRegionCommandTest::testClearCacheEntryName
Failed asserting that '\n
 // Clearing second-level cache entry for entity                                \n
 // "Doctrine\Tests\Models\Cache\Country" identified by                         \n
 // "1"                                                                         \n
\n
' contains " // Clearing second-level cache entry for entity "Doctrine\Tests\Models\Cache\Country" identified by".

The SymfonyStyle add line breaks if needed.
any idea @Ocramius @javiereguiluz ?

I found this: https://stackoverflow.com/questions/39190610/how-to-test-console-command-output-when-terminal-widths-differ/40347595#40347595
putenv('COLUMNS=80'); or 120?
WDYT?

lets check if https://github.com/doctrine/doctrine2/pull/6655/commits/142055cf68bb2133680f68b45365fdac00ccab6a makes travis happy 🎉

oskar.stark:~/dev/misc/doctrine2 (symfony-style)$ env COLUMNS=10 php -d memory_limit=-1 vendor/bin/phpunit --group=test
PHPUnit 6.4-ga1b5663a4 by Sebastian Bergmann and contributors.

/Users/oskar.stark/dev/misc/doctrine2/tests/Doctrine/Tests/ORM/Tools/Console/Command/ClearCacheCollectionRegionCommandTest.php:79
FAILURES!
Tests: 2, Assertions: 6, Failures: 1.
oskar.stark:~/dev/misc/doctrine2 (symfony-style)$ env COLUMNS=120 php -d memory_limit=-1 vendor/bin/phpunit --group=test
PHPUnit 6.4-ga1b5663a4 by Sebastian Bergmann and contributors.
Runtime:       PHP 7.1.8
Configuration: /Users/oskar.stark/dev/misc/doctrine2/phpunit.xml.dist
..                                                                  2 / 2 (100%)
Time: 474 ms, Memory: 40.00MB
OK (2 tests, 6 assertions)
oskar.stark:~/dev/misc/doctrine2 (symfony-style)$

Looks like 2 builds are still failing.... I don't know why.
Scrutinizer tests pass, after setting the COLUMNS env in .scrutinizer.yml

https://github.com/doctrine/doctrine2/pull/6655/files#diff-354f30a63fb0907d4ad57269548329e3R12 fixes most of the travis builds, but 7.1 and 7.2 builds are still failing and I don't know why 😕 ❗

I rebased my branch, but don't know if travis is working now

The 7.1 and 7.2 are failing if there is a custom MYSQL_VERSION set.
Looks like the COLUMNS env var is ignored, do you spawn any sub commands or sth like this, where the COLUMNS env var is not used anymore?
At the start of the build, the COLUMNS env var is exported

any news?

Not a single comment/feedback since the end of august, that makes me sad.... 😞
If you don't like it I will close the PR, otherwise I need some help how to fix it

Other similarity between failing jobs: sudo: required

Possible solution: https://stackoverflow.com/questions/36133265/unable-to-get-env-variable-value-in-a-before-install-script-with-travis#36161645

damn, nothing is working 👎

You could try to add sudo: required to another build to see if this it what causes the problem

updated

Looks like it is! That's progress 👍

Looks like it is! That's progress 👍

yeah, we are happy, that we have more failing builds than before 😆

yeah, we are happy, that we have more failing builds than before

Sometimes you need to break things before you can fix them 🤣

We are happy that we know more about the failure and what to google :P

@OskarStark a stupid question: have you tried to set that environment variable in the phpunit configuration? I think that would be ideal also to ensure that the tests will not fail randomly for contributors with different configuration, what do you think?

 :P

@greg0ire because he probably already tried it?

@Ocramius @lcobucci this should be ready to merge, please let me know if I should change something!

there are some parts of the code that are not being covered by tests, can you please check that? https://scrutinizer-ci.com/g/doctrine/doctrine2/inspections/cf59ead0-6eb9-4a28-b114-91d5328ba6e0/code-structure/test-coverage might be helpful

I will have a look

You're formatting some parts of the code in the same commit of your changes, that's a bit confusing to review (specially via mobile 😂), can you please revert those changes or split them into a different commit?

damn, i did before, but squashed all commits, thought this was already done 😞
Shall I rework the PR and split everything in different commits?

there're some additions that don't follow our code standards (like the spacing before and after the negation operator), can you please check that?

ofc, I will check, do you have a tool for that like StyleCi or a PHP-CS-Fixer config?

I think you forgot to define the constant in phpunit.xml.dist

done

Shall I rework the PR and split everything in different commits?

I think it's fine to have 2 commits one that formats the old code and one that introduces SymfonyStyle, it should be simple to do that with reverting (soft) your commit and using git add -p but if I can help you on that later.

ofc, I will check, do you have a tool for that like StyleCi or a PHP-CS-Fixer config?

Yes, we use phpcs but we haven't configured it for the ORM yet 😭

I think it's fine to have 2 commits one that formats the old code and one that introduces SymfonyStyle, it should be simple to do that with reverting (soft) your commit and using git add -p but if I can help you on that later.

don't worry, I will do it, but how to proceed with Scrutinizer? set COLUMNS or not?

Yes, we use phpcs but we haven't configured it for the ORM yet 😭

ok, i checked for the space before and after !

don't worry, I will do it, but how to proceed with Scrutinizer?

@OskarStark I've merged the scrutinizer config to not run the tests there, please rebase your branch to sync with master

set COLUMNS or not?

Don't change anything on scrutinizer config =)

@OskarStark I've merged the scrutinizer config to not run the tests there, please rebase your branch to sync with master

done

@OskarStark thanks a lot for not giving up on this and sorry about the huge delays. We'll probably get this 🚢  by the end of the day!

@OskarStark thanks a lot for not giving up on this and sorry about the huge delays. We'll probably get this 🚢 by the end of the day!

sounds good 😄

[ ] I added 2 tests for InfoCommand in a separate Command
[ ] I switched from $this->assert* to self::assert* in a separate commit
[ ] I removed all setDefinition() calls and replaced them by addOption() and addArgument() in a separate commit
[ ] I will now write a test for GenerateRepositoriesCommand

In the meantime you could give me another review if you find some time.
Cheers 🍾

I will keep the separate commits, let me know if I should squash some of them together! 👍

@OskarStark 🚢!
Thanks a lot for your contribution (and patience)!!

Yeah, finally 😃 🎉 🍾
Thank you for your detailed feedback!

It's a shame I never got a reaction for PR #5651, posted over two years ago. I saw this PR via Twitter only today.


BUG: Does not work with no_std under 1.29 (MSRV)

rust-bitcoin does not work with rust 1.29 under a no_std environment. This could be considered a bug. However, no_std support is a recent addition and this is likely not breaking anyone's builds.
A decision needs to be made, either no_std MSRV is the current stable version while keeping the std MSRV as 1.29, or it needs to be fixed.
This pr adds no_std to the 1.29 test suite.
This came as I try to get rust-bitcoin/rust-miniscript#277 working and got stuck on the issue of testing no_std under 1.29.

I believe it's intentional as no_std is generally not well-supportd in old versions of Rust. But indeed, it does conflict with:

This library should always compile with any combination of features on Rust 1.29.

In README.md

@Kixunil Maybe my first report was not clear enough. As it stands, rust-bitcoin is broken because it does not compile under Rust 1.29 with no_std enabled.
My suggestion to fix it is to maintain 2 different MSRVs: 1.29 for std and the current stable version (1.57) for no_std.

As it stands, rust-bitcoin is broken because it does not compile under Rust 1.29 with no_std enabled.

That's exactly what I said. However it also may be that the documentation is outdated and it was intended to be an exception.

My suggestion to fix it is to maintain 2 different MSRVs: 1.29 for std and the current stable version (1.57) for no_std.

I agree. However we plan to switch to 1.36 after the Taproot release. Maybe it'll be enough? Could you check?
@apoelstra what do you think about an exception from MSRV for no_std stuff?

https://github.com/mcroad/rust-bitcoin/runs/4553927944
Still broken under Rust 1.36.

rust-lightning's no-std MSRV is 1.47. It would be nice if rust-bitcoin could match that (that is also core2's MSRV).

Oops, yes, we should have an exception. I didn't realize there wasn't already one. (I'm sure if you read the initial no_std PRs you will find some agreement on this.)
Targeting 1.47 sounds good to me. I believe the current situation is "no MSRV for nostd" which isn't great.

All tests pass under 1.47. PR is ready to be merged.
https://github.com/mcroad/rust-bitcoin/runs/4613143768?check_suite_focus=true
While I have your attention: any idea when a new version will be released? I am waiting on #637 to be relased to finalize rust-bitcoin/rust-miniscript#277.
Thanks for the input everyone.

@mcroad we'll have a release once https://github.com/rust-bitcoin/rust-bitcoin/issues/503 is done

I think it's appropriate. Doesn't fundamentally change the code so no problem for RC.

@mcroad the overall diff looks great. Can you squash all the commits, or otherwise clean them up?

 PR is ready.

Is there anything else I need to do on my end to get the PR merged?

It looks like CI is failing -- it looks like https://github.com/rust-bitcoin/rust-bitcoin/pull/590 broke the 1.47 MSRV.
I guess we should just merge this and fix the MSRV in a separate PR.

@apoelstra perhaps we should merge this PR since its docs and CI bug fix.

If you decide to remove the trailing whitespace perhaps rebase on master at the same time and see if it fixes the CI fail?

Still broken. Caused by std::fmt::DebugStruct#finish_non_exhaustive used in src/util/bip32.rs which was stabilized in Rust 1.53.0
See the CI output https://github.com/mcroad/rust-bitcoin/runs/5951955343?check_suite_focus=true
Without more changes 1.47 will not work as a no_std MSRV.

@mcroad yeah, I noticed earlier and opened #947

Pushed a fix for #947 sticking with 1.47 as no_std MSRV. Please re-run CI checks.

This PR has a merge commit in it, can you rebase please.

Cleaned up commit history and rebased on master.

ACK 60003f687291ea06c9cbd905fd24daa83eb61990

@tcharding looks like you forgot to hit GitHubs approve.

Merged #964.

Rebased again. Now including #964

Thanks for your patience  @mcroad, this still has PIN_VERSIONS env var being set in the CI job, can you remove that please as the variable is longer used now it got removed from test.sh in #964. Cheers

Unneeded PIN_VERSIONS var is the only issue I can see.

Fixed PIN_VERSIONS issue.

Sure, though we'll need to do a backport already.

https://github.com/rust-bitcoin/rust-bitcoin/pull/986


remove get_stacktrace / make cowboy debuggable under OTP 23 / runnable unto OTP 24

get_stacktrace/0 will be remove in OTP 24, but its use is already a problem for debugging in OTP 23.
Starting with OTP 23 get_stacktrace/0 always returns [], this leads to very uninformative error messages like
2020-09-27T14:54:13.849015+00:00 <0.16052.0> error: Ranch listener ergw_http_listener, connection process <0.16052.0>, stream 1 had its request process <0.16053.0> exit with reason function_clause and stacktrace []
2020-09-27T14:54:43.852343+00:00 <0.16069.0> error: crasher: initial call: cowboy_stream_h:request_process/3, pid: <0.16069.0>, registered_name: [], error: {function_clause,[]}, ancestors: [<0.16068.0>,<0.1207.0>,<0.1206.0>,ranch_sup,<0.1137.0>], message_queue_len: 0, messages: [], links: [<0.16068.0>,#Port<0.1192>], dictionary: [], trap_exit: false, status: running, heap_size: 4185, stack_size: 28, reductions: 2986352; neighbours:

It was removed in 3a7232b019f975a594a696eace46abcbfeec5b2e.

argh, sorry for the noise. I thought I was locking at master, but was really still using 2.7.

Oh I actually released a version 2.8 that contains the fix! I thought I didn't. So the situation is not as bad as I was thinking.


Update flags in alloy-deployment.yaml

Pod fails to start while running the sandbox. The pod error shows
flag provided but not defined: -store
flag provided but not defined: -controller-mode
flag provided but not defined: -config

Remove -controller-mode and -enable-pprof
Update -store=serverservice to -asset-source=serverService
Update -config to config-file

@Alva8756 thanks for the fixes,
You'll need to make sure the commits are signed,

install Gitsign using https://docs.sigstore.dev/gitsign/installation#installing-gitsign
add the below config following in .gitconfig
re-commit these changes (git commit --amend)

[commit]
    gpgsign = true
[gitsign]
    connectorID = "https://github.com/login/oauth"

@joelrebel
Thanks so much for the suggestions and it is working for me now.
Closed this PR and created this new one since your change is already merged.
https://github.com/metal-toolbox/sandbox/pull/22


D435i: IMU timestamps are repeating

Hi all,
A while ago I opened an issue about uniting the imu messages, including a hacky fix how I managed to fix it, at least for my datasets: #544. Today I wanted to try the sensor again, and since I noticed that the feature of uniting the imu messages has been added to the repo now, I switched back to the development branch.
However I couldn't get our VIO to run on the sensor anymore. When I had a closer look at the IMU data i noticed that the timestamps of the IMU are broken and it looks like they are repeating/cycling through the same range (?). Here is a plot of the IMU timestamps:

So I switched back to my branch that worked last time, but kept librealsense the same and the issue was there as well. So I guess it's a problem of librealsense?
Does anyone else see this issue?
Any help on how to fix it or which version of librealsense/realsense provides working IMU messages would be appreciated. Thanks!
Info:

I used the rs_rgbd.launch file and only added  <arg name="unite_imu_method" value="linear_interpolation"/>
ROS melodic, Ubuntu 18.04
branch: development

@mfehr I met the same problem in Ubuntu 18.04, with librealsense2 the version 2.19.2 and the development branch (https://github.com/intel-ros/realsense/commit/eea5b1592d6889817c500b22179c1fe1da60cde4).
It seems that the timestamps of the default IMU outputs without unite_imu_method are also repeated.
Did you have any updates about this problem?

I managed to get it working again, by setting librealsense to one specific version and realsense to another + replacing the official unite imu logic with my own hacky version again. The new  (linear interpolation) unite imu logic didn't work with maplab for me and when I checked at what frequently the united msgs are published it I noticed that the 450hz gyro signal and the 250 hz accel signal were combined into a 490hz signal. So it's probably trying to interpolate both the slow onto the fast and the fast onto to slow signal. My logic only does fast to slow interpolation.
I created a repo with these specific branches of the realsense repos as submodules and some documentation so that we have a version that works with maplab and it is easy to find and install. I made it public just now:
https://github.com/ethz-asl/realsense_D435i

Thanks @mfehr. I've tried your ROS wrraper with librealsense version 2.19.1. It works!

@mfehr , what firmware are you using? what is the scale of x-axis in your graph?
Just making sure - The new realsense2_camera (what version) with librealsense 2.19.1 also didn't work for you? What was the problem in that case?

@doronhi don't know the firmware version, I can check, but I don't have the sensor atm. The plot is timestamp [s] vs message number from a short rosbag I recorded. When I reported this issue, I did a fresh install of librealsense and realsense2_camera both on the development branch, didn't work (that's where the plot is from), then tried the realsense2_camera version I was using before (December 18 version, I think), also didn't work. Then after a quick look at the new imu unite logic (linear interpolation) I decided to check out the latest tagged release of both librealsense and realsense2_camera and re-integrate my alternate unite imu logic (version and changes are described in the meta repo I shared). That worked, but I can't say for sure if was just the right combination of releases or whether my changes had any effect on it. I mainly switched to the other unite imu logic, because I thought it was weird that the united imu message has a higher frequency than the individual signals and I didn't have time to debug/investigate :) Did you do a check on you side if the IMU timestamps with the most recent branches?
With the version I linked above I can run maplab (VIO) quite ok, it is not super stable though and when I'm calibrating the sensor with kalibr, the IMU errors/biases are looking unhealthy. I used the official realsense imu calibration tool and also tried calibrating IMU intrinsics with kalibr, but didn't help. So I'm still not sure whether there is a flaw in my imu unite logic, my calibration skills, the ros wrapper, librealsense or it's just the limit of the BMI055. So if anyone has ideas or a good source for IMU sigmas for the BMI055, I'm all ears.

Apparently there is a issue concerning the timestamps of the IMU in librealsense since v2.19.2.
Work is in progress.

A bug was fixed in librealsense. It is merged but not yet released. It involved IMU timestamps in Linux.
If in hurry, you can check out the master branch of librealsense

Thx @doronhi, I quickly checked but couldn't find a matching PR, would it make sense to link the PR here?

@doronhi I tested it using rs_camera.launch with linear_interpolation enabled for the imu.

librealsense master branch + realsense 2.2.3 -> bug still there
librealsense development branch + realsense 2.2.3 -> timestamp bug is fixed
Thanks, as far as I'm concerned this issue can be closed.

You are right, my bad. This is the link to the PR: https://github.com/IntelRealSense/librealsense/pull/3726
Glad it worked out for you :)

Thank you, I face the same problem, I tried to compile the development and it worked just fine. Do you know, when it will be released?

Hopefully early next week.

Hi, is this something that is fixed on the latest release? Thanks!

Just an update. I now went back to SDK 2.23 and the behavior improved and I get an average frequency of around 500 Hz when running with linear interpolation roslaunch realsense2_camera rs_camera.launch unite_imu_method:=linear_interpolation. However, looking at the timestamp interval, it oscillates between 1.5, 2 and 2.5 ms, so an average of 2 ms, which is not the expected behavior. I will continue to go down until SDK 2.21 and check the behavior.


Add support for chocolatey

Hi,
I think it would be great if we can install filebeat from chocolatey.
Are you open to PR on this subject ?
The first step to do this is to create a variable like use_chocolatey which should be default to no as this will not affect current behaviour.
What do you think ?

Sorry for the delay.
I'd love to support chocolatey, but I don't know enough about it or have access to a place to test to write it myself. All of the Windows support here is from PRs, so feel free to send something along if you have the time.
Thanks!


Develop

added endpoint to get all reported offers and strikes

we'll just use this as our develop branch


Allows for specifying the maxBatchSize

Closes #35

Coverage remained the same at 100.0% when pulling 2c3165e2142e41425c900ec99386feb5a4ae4424 on bonsaico:mshim/maxBatchSize into 68a2a2e9a347ff2acc35244ae29995ab625b2075 on facebook:master.

Thanks for this contribution!
I'm curious if it makes sense to include this in the core library, or if it makes more sense to suggest that users of this library do this themselves. I can see arguments for keeping the library simple, but also can see how leaving this up users of the library may lead to less clear code.

Let's go with it.


⚠ Processors has degraded performance

In 56f7fb9, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 39 ms

Resolved: Processors performance has improved in e105025.


publish '@odf-console/shared' version 'beta12'

/override ci/prow/odf-console-e2e-aws
only publishing new version of the shared library, no need to run CI...


Refactored controls animation duration

Changes

Refactored duration of animations. Now we have controlsAppearanceAnimationDuration and controlsDisappearanceAnimationDuration;
Both of them are now public;
Appearance duration is 0.25, disappearance - 0.35;
0.35 duration will be applied only if all controls become hidden. If only one or few views disappear, the duration will be - 0.25.

Demo

To discuss

Duration time
Need for timing functions (linear or curve)

Merge restricted - until we decide if we are ready to turn on animations for the next release.
@aol-public/mobile-sdk-team: Ready for review.
JIRA Issue

@AndriiMoskvin what is the point to merge it right now? We're not sure if animations will be in the next release. And if they won't, people will get an animationsDuration value that doesn't change anything.

Why it is merge restricted - these changes will not affect UI with animations disabled.

Because of making these values public. Or, I can remove public changes from this PR.

@RomanTysiachnik Please, fix above comments and we will merge it.


replace AsyncTask with AsyncTaskLoader

Hello, I'm doing research on Android async programming. Some articles (for example this article) mention that AsyncTask leads to memory leak and losing task result when there's a configuration change (such as orientation change). Android docs recommend AsyncTaskLoader (require API level 11), which avoid the problems in AsyncTask.
I try to replace one AsyncTask with AsyncTaskLoader in ChatSecureAndroid in this pr (you don't have to merge). Do you think AsyncTaskLoader will work better for ChatSecureAndroid? I found that you already use CursorLoader at some places. Do you also want to replace all AsyncTask with AsyncTaskLoader?

It might be helpful, but for now we are still committed to supporting Android SDK 9 and up.

AsyncTaskLoaders are quite useful.  This needs to use the android-support-v4 version of AsyncTaskLoader in order to support versions of Android older than API android-11: https://developer.android.com/reference/android/content/AsyncTaskLoader.html

oops, I meant this one:
https://developer.android.com/reference/android/support/v4/content/AsyncTaskLoader.html


(Update) Build and Push

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________  JPMC required additional clarifications in the documentation.
Jira/GitHub Issue numbers (if any): ___________.  https://harnesssupport.zendesk.com/agent/tickets/73024
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

@dewan-ahmed
Looks like it's good now.  Not sure where the error was.  I added a line break between this section and the rest, but I don't see this section in most other documentation, so not sure what it's for.
import Tabs from '@theme/Tabs';
import TabItem from '@theme/TabItem';

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://67326a32f78634b6d8f67dad--harness-developer.netlify.app

Hi @jamie-harness .  I spoke with Nofar, and she asked me to have you review this document change I've made


io.github.dweymouth.supersonic - Update exceptions.json

needs access to xdg-config/pipewire:ro for pipewire client config

The maintainer is supposed to request exceptions cc @anarcat
Does --filesystem=~/.config/pipewire:ro work? Or you need it to be xdg-config specifically?

Yes, I was requesting access for the convenience of the maintainer
~/.config/pipewire works for my configuration, but the pipewire docs are explicit about the general case being $XDG_CONFIG_HOME/pipewire/ for user configurations.
https://docs.pipewire.org/page_man_pipewire-client_conf_5.html

Then switch it to that and you'll need no exception.
If someone keeps xdg-config on a different location, they are on their own to make changes to the sandbox.

Well OK then
I'm just trying to follow standards and make things easy
If you really object, I'll go back to the project and do the "mostly works" solution

Also static permissions and sharing config from host, should be reduced as much as possible. There is very few people with custom pipewire and pulseaudio configs as most will just use distro defaults.
You can keep that as an override for yourself instead of introducing it for everyone.


Promise.wait() blocks setTimeout

I wasn't sure what to type for the subject as this isn't quite a bug or an enhancement request. It's just a behavior that could be changed perhaps.
var {Deferred} = require( 'ringo/promise' );

var deferred = new Deferred();

setTimeout( function () {
    deferred.resolve( 'hello world' );
}, 1000 );

var value = deferred.promise.wait( 5000 );

print( 'Value: ' + value );

When executed, the above code prints out "Value: undefined" after a 5 second pause. I was expecting it to print out "Value: hello world" after a one second pause.
My expectation is that the deferred.wait() would be interrupted by the deferred.resolve() in the setTimeout handler. But instead deferred.wait() blocks the setTimeout countdown timer because it is also on the main event thread.
The following code illustrates the affect I was hoping to achieve.
var {Deferred} = require( 'ringo/promise' );

var deferred = new Deferred();

function newTimeout( f, delay ) {
    new java.lang.Thread( new java.lang.Runnable({
        run: function() {
            java.lang.Thread.sleep(delay);
            f.call(this);
        }
    }) ).start();
}

newTimeout( function () {
    deferred.resolve( 'hello world' );
}, 1000 );

var value = deferred.promise.wait( 5000 );

print( 'Value: ' + value );

There would be issues with this naive replacement for setTimeout, particularly the fact that the concept of 'this' is changed. Calling new Timeout like this would solve that problem:
newTimeout( function () {
    deferred.resolve( 'hello world' );
}.bind(this), 1000 );

So, I'm not particularly suggesting an enhancement or pointing out a defect. There may be very good reasons why setTimeout has to be run on the main event loop.
The inclusion of Promise.wait() is a very nice option when blocking is required, so I am glad to have it available, even if it requires some additional knowledge regarding its use.

I’m closing this issue because it has been inactive for a long time. This probably means that it is not reproducible or it has been fixed in a newer version. If it’s an enhancement and hasn’t been taken on for so long, then it seems no one has the time to implement this / there is no interest in it.
Please reopen if you still encounter this issue with the current master version or there is a need to address this issue.


where can we get i3d_pretrained_400.pt

Hi, thank you very much for your code. I would like to know where I can download the i3d_pretrained_400.pt weights mentioned in the code.
thank you!

https://github.com/npurson/fid-metrics/releases/tag/v1.0


When editing existing address, country does not have default value from backend

Describe the bug
When you click on edit button on existing address to edit the address, all input fields are filled except the Country/Region select. For that reason also the Province input is showed and its only hiding when you change the country. Please see the screenshot
To Reproduce
Steps to reproduce the behavior:

Go to addresses inside user account area
Add address
Click on "Edit" address to edit it
See error, Country/Region select is not filled and the Province is shown. Province also always shows Canadas provinces.

Expected behavior
Address should be filled and Province should be shown only if default country needs it or have it already.
Screenshots

Desktop (please complete the following information):

OS: OSX latest
Browser: All
Version: Latest

@marioloncarek Thanks for this. I know what this is, and I'll get a fix pushed up ASAP!


Allow many image layers with per-image transformation

Display many (tens of thousands) imagery layers on the same view with transform matrices.

Combining into #6531.


Spotify Initial Volume

Spotify connect uses the 'SYSTEM_OUTPUT_VOLUME' variable as initial volume.
If this volume is set to 100% it means that when i connect to Spotify-connect, my naeghbours and family members are blown away :). (I am using a raspberry pi 3's with Hifi Berry Amp).
If I set the SYSTEM_OUTPUT_VOLUME to like 25%, the maximum volume for the soundcard is set to 25% but Spotify also drops down to 25%. which means that it now starts at 25% of the 25%. If i turn up the volume to 100% on the spotify connect app, the soundcard will play at 25%.
This volume level is (re)set whenever the Spotify service is restarted.
I have fixed this by adding a new variable called SPOTIFY_INITIAL_VOLUME to the start.sh in the Spotify folder.
This variable is then used when starting the service.
I don't know (yet..) how to make a branch or request of how to implment this, so i'm hoping that a kind soul could help with this.
Here is the code for start.sh in the Spotify folder (balena-sound-master\spotify):
#!/usr/bin/env bash

#Check for incompatible multi room and client-only setting
if [[ -n $DISABLE_MULTI_ROOM ]] && [[ $CLIENT_ONLY_MULTI_ROOM == "1" ]]; then
  echo “DISABLE_MULTI_ROOM and CLIENT_ONLY_MULTI_ROOM cannot be set simultaneously. Ignoring client-only mode.”
fi

#Exit service if client-only mode is enabled
if [[ -z $DISABLE_MULTI_ROOM ]] && [[ $CLIENT_ONLY_MULTI_ROOM == "1" ]]; then
  exit 0
fi

# Set the device broadcast name for Spotify
if [[ -z "$DEVICE_NAME" ]]; then
  DEVICE_NAME=$(printf "balenaSound Spotify %s" $(hostname | cut -c -4))
fi

# Set the system volume here
SYSTEM_OUTPUT_VOLUME="${SYSTEM_OUTPUT_VOLUME:-75}"

# Set the Initial volume here
SPOTIFY_INITIAL_VOLUME="${SPOTIFY_INITIAL_VOLUME:-10}"

# Set the Spotify username and password
if [[ ! -z "$SPOTIFY_LOGIN" ]] && [[ ! -z "$SPOTIFY_PASSWORD" ]]; then
  SPOTIFY_CREDENTIALS="--username \"$SPOTIFY_LOGIN\" --password \"$SPOTIFY_PASSWORD\""
  printf "%s\n" "Using Spotify login."
fi

# Use pipe backend if multi room is enabled
# Don't pipe for Pi 1 family devices since snapcast-server is disabled by default
if [[ -z $DISABLE_MULTI_ROOM ]] && [[ $BALENA_DEVICE_TYPE != "raspberry-pi" ]]; then
  SPOTIFY_BACKEND="--backend pipe"
  SPOTIFY_DEVICE="--device /var/cache/snapcast/snapfifo"
fi

# Start raspotify
exec /usr/bin/librespot --name "$DEVICE_NAME" $SPOTIFY_BACKEND --bitrate 320 --cache /var/cache/raspotify --enable-volume-normalisation --linear-volume --initial-volume=$SPOTIFY_INITIAL_VOLUME $SPOTIFY_CREDENTIALS $SPOTIFY_DEVICE

@gtihubuser you could have achieved this too by setting System output volume for each service via the the device service variable tab. I think we have to  larify for every user that this is a option.

Oh. I did not know that. I'll play with this right away :)
Thanx @AlexProgrammerDE
So the SYSTEM_OUTPUT_VOLUME in the Device Variables if for the 'soundcard'?
And the SYSTEM_OUTOUT_VOLUME ind the Device Service Varibles Is for the specific 'Service'. Nice :D
Like this i guess:

Yeah, it could be a good idea to show or list down the options somehow. ;)

Yeah its like that. Device variable sets it for every service and service variables for every service individually. I will make later a PR which adds it to the documentation.

Great!
I think we can close this one then?

I will open a PR and link it with this issue. It closes it automaticly when its merged.

This was addressed with the release of 3.0 last year. Volume is now controlled by the audio block, can be edited at runtime visiting http://balena.local or at startup via env var SOUND_VOLUME


run own stats

Use Cube and Cubism
Original issue by @bmesuere on Thu May 22 2014 at 15:17.
Closed by @bmesuere on Wed May 20 2015 at 18:32.

stathat works fine for now.
Original comment by @bmesuere on Wed May 20 2015 at 18:32.


fix(extra715): Change lower case from bash variable expansion to tr

Context
Bash variable expansion doesn't work on old bash version from macOS
Description
Change lower case transformation from bash variable expansion to tr '[:upper:]' '[:lower:]' command.
Fix issue #1058
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

extra715
extra780
extra785
extra7101
check_sample

Thanks for all !! @lazize


Identify query param serialization method for arrays

https://swagger.io/docs/specification/serialization/
Related discussion on the serialization of nested objects: https://github.com/OAI/OpenAPI-Specification/issues/1706
See automatically generated preview doc for this PR.
Problem
Here is an example filter object passed as query parameter when fetching a page of challenges:
"filter": {
  "tagIds": [
    "tag1",
    "tag2"
  ]
}

This query parameter currently uses the following serialization options:
style: deepObject
explode: true

This configuration generates the follow request URL:

http://localhost:8080/api/v1/challenges?limit=10&filter%5BtagIds%5D=tag1&filter%5BtagIds%5D=tag2
http://localhost:8080/api/v1/challenges?limit=10&filter[tagIds]=tag1&filter[tagIds]=tag2 (same URL but more readable)

The error returned by the API service is: "'tag1' is not of type 'array'...
Solutions
It seems that there is no easy solution for serializing deep objects. See https://github.com/OAI/OpenAPI-Specification/issues/1706. Ideally we want to continue to leverage the automatic generation of the API service and customize its code only if required.
The easiest solution seems to flatten the query by removing the filter level and instead specify directly a query parameter named tagIds, for example.
      - description: Array of tag IDs
        explode: true
        in: query
        name: tagIds
        required: false
        schema:
          items:
            $ref: '#/components/schemas/TagId'
          type: array
        style: form

Example of query with explode: true: http://localhost:8080/api/v1/challenges?limit=10&tagIds=tag1&tagIds=tag2
Example of query with explode: false: http://localhost:8080/api/v1/challenges?limit=10&tagIds=tag1,tag2

Data received by the challenge controller when using style: form and explode: false (default behavior for query parameters) or explode: true.
tag_ids ['tag1', 'tag2']

Notes

The use of explode: true enables value to include a "comma" since the comma is not used as separator in this mode. This could be useful for free text search (in this case it's probably better to send the entire string and let the API service tokenize the string using space, for example).
Using explode: true and the use of the plural form for the variable (here tagIds, the query parameter being an array) leads to a slight naming inconsistency as in tagIds=tag1&tagIds=tag2. This inconsistency disappear when using explode: false => tagIds=tag1,tag2.
The CERN dataset and tool registry uses the singular form for the query parameter, for example https://opendata.cern.ch/search?page=1&size=20&type=Dataset&subtype=Collision&subtype=Derived&subtype=Simulated. Note that their queries break easily and so their implementation should not be used as a reliable reference.
URL should never be longer than 2,048 characters. Shorter URLs are also faster. explode: false contributes to make URL shorter.

Solution 1
Keep the object ChallengeFilter for now for properties that represent a single value. The following properties that were in ChallengeFilter are not single values and so are made individual query parameters:

tagIds
platformIds

Other properties my follow (e.g. organizers) and potentially lead to completely dropping the ChallengeFilter object and other {schema}Filter.
Solution 2
Keep ChallengeFilter and make ChallengeFilter.tagIds a single string value. The client is responsible for concatenating multiple values using a delimiter, e.g a comma. All clients and the API service must then use the same delimiter. This issue with this approach is that the OpenAPI specification can not enforce this requirement. At best this can be capture in the description of the query parameter.
Because the resulting URLs are less standard than in Solution 1, the following pain point may be introduced for the web client: when someone bookmark or share a URL that include parameter, the ideal behavior is that UI of the filters on the page is initialized based on the values of the query parameters. Similarly to the extra code that we would add in Solution 2 to concatenate multiple values, we would need to write code that un-concatenate values of query parameters when the page load.
Conclusion
I propose to adopt Solution 1, which will be implemented in this PR.
EDIT: Since most of the parameters in ChallengeFilter are meant to take arrays, I may just drop ChallengeFilter.
Tagging @vpchung @rrchai for comments
Update

This PR proposes to define query parameters in their own file.
The name of a query parameter file matches the name of an object property when applicable.
I removed ChallengeFilter.

Related discussion on the serialization of nested objects: https://github.com/OAI/OpenAPI-Specification/issues/1706

Note on filtering by challenge status
Current query parameter:
name: status
description: Array of challenge status used to filter the results
in: query
required: false
schema:
  type: array
  items:
    $ref: ../../../components/parameters/ChallengeStatus.yaml

The Swagger UI knows that this parameter can take an array as value but the UI component does not allow to specify more than once status.

Note on text search
MongoDB has a convenient feature to search for terms among multiple properties. I'm heading toward enable the user to specify multiple search terms as a single string, which will be passed to MongoDB to search challenges that have these terms in Challenge.name and Challenge.description.


fix(branch overview): allow email as author

The branch overview screen crashes if there is a commit with an e-mail address as author in the commit history.
This change fixes that.

thanks :+1:


[SPARK-15416][SQL]Display a better message for not finding classes removed in Spark 2.0

What changes were proposed in this pull request?
If finding NoClassDefFoundError or ClassNotFoundException, check if the class name is removed in Spark 2.0. If so, the user must be using an incompatible library and we can provide a better message.
How was this patch tested?

Run bin/pyspark --packages com.databricks:spark-avro_2.10:2.0.1
type sqlContext.read.format("com.databricks.spark.avro").load("src/test/resources/episodes.avro").

It will show java.lang.ClassNotFoundException: org.apache.spark.sql.sources.HadoopFsRelationProvider is removed in Spark 2.0. Please check if your library is compatible with Spark 2.0

Test build #58898 has started for PR 13201 at commit f92ce1f.

Test build #58898 has finished for PR 13201 at commit f92ce1f.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class IncompatibilityException(CapturedException):

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58898/
Test PASSed.

There are many space changes. Please use this link https://github.com/apache/spark/pull/13201/files?w=1 to review.

Test build #58902 has started for PR 13201 at commit b99fac8.

Test build #58902 has finished for PR 13201 at commit b99fac8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58902/
Test PASSed.

cc @marmbrus @yhuai

Test build #58917 has started for PR 13201 at commit 0db5d20.

Test build #58917 has finished for PR 13201 at commit 0db5d20.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58917/
Test PASSed.

Merged build finished. Test PASSed.

Thanks!  Merging to master and 2.0


fix: fix server-proxy-uri config

Thanks for jumping in and submitting a fix!

no problem hope i can give back even more at least with docs (Haskell isn't my thing :) ). We are deploying to production 2 instances of postgrest next week at my company, so we have some knowledge we can share like ansible roles, nginx confs etc.


fix: allow second argument to be undefined

Thanks! Any chance I can get a 4.0.1? We'd love to upgrade, but would need this first

I want to wait a day or so to fix other discovered bugs.
you can use {} as workaround today.


add rwlock on userInfoManager

Codecov Report

Merging #74 (d575225) into main (aad7d3d) will increase coverage by 0.34%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   60.00%   60.34%   +0.34%
==========================================
  Files          12       12
  Lines        1245     1271      +26
==========================================
+ Hits          747      767      +20
- Misses        401      407       +6
  Partials       97       97

Impacted Files
Coverage Δ

pkg/kafsar/kafka_impl.go
48.74% <78.57%> (+1.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad7d3d...d575225. Read the comment docs.


Installing pillow: "E: Unable to locate package libwebpmux3"

When I try to install pillow using the command provided:
sudo apt install libwebp6 libtiff5 libjbig0 liblcms2-2 libwebpmux3 libopenjp2-7 libzstd1 libwebpdemux2
I get the error message:
"E: Unable to locate package libwebpmux3"

Which debian version are you using?
libwebpmux3 is only available on buster and later.

I think you can probably safely leave libwebpmux3 out, unless you are one of the few people who uses WepB...

That worked -thanks!


Please help, I have install Filterizr with npm

Hi. I'm struggling the last hour with one issue that unfortunately am not able to determine since i don't get any any error from my webpack.  After clicking on the data-filter categories nothing is change. I even move the filterizrSetup() outside of the class and try to run it as a manualy import but I'm getting error message ".filterizr is not a function" it seems like I miss something check the codee below.

Inside App.js i have include the followings.

import filterizr from 'filterizr'; import Filterizr from './modules/Filterizr';

My Filterizr.js includes the following code:

import $ from 'jquery
class Filterizr {
  constructor() {
    this.menu = $("#navItems");
    this.filterizr = $(".filtr-container__row");
    this.filterizrMenu();
    this.filterizrSetup();
  }
    filterizrMenu() {
      this.menu.on('click', 'li', function() {
        $(this).addClass("filtr-active").siblings().removeClass("filtr-active");
      });
    }
    filterizrSetup() {
      this.filterizr.on('load', function() {
          var filterizd = $(this).filterizr();
      });
    }
  }

export default Filterizr;

Hello there,
when you do the default import from 'filterizr', bare in mind that it will import for you the jQuery object, extended with the Filterizr plugin.
Your Filterizr.js should look like this:
import $ from 'filterizr'; // Imports jQuery object extended with .filterizr function

class Filterizr {
  constructor() {
    this.menu = $("#navItems");
    this.filterizr = $(".filtr-container__row");
    this.filterizrMenu();
    this.filterizrSetup();
  }
    filterizrMenu() {
      this.menu.on('click', 'li', function() {
        $(this).addClass("filtr-active").siblings().removeClass("filtr-active");
      });
    }
    filterizrSetup() {
      this.filterizr.on('load', function() {
          var filterizd = $(this).filterizr();
      });
    }
  }

export default Filterizr;

now inside your App.js you simply need to import and instantiate your class like this:
import Filterizr from './modules/Filterizr';
...
new Filterizr();

if the controls are still not working there must be a problem with the selectors you're using and you might have to show me your HTML

Hi. Thank you for your quick anwser. :)
I have attached the error included with home section. Please note that i have also updated constructor() id and change it to class. ( I thought that cause the problem but) am new with ES5/ES6 and I have confused...
I would appriciated if you could help me :)

Error message:
Uncaught TypeError: (0 , _filterizr2.default) is not a function     at new Filterizr (App.js:11198)     at Object.<anonymous> (App.js:10466)     at __webpack_require__ (App.js:20)     at App.js:63     at App.js:66 Filterizr @ App.js:11198 (anonymous) @ App.js:10466 __webpack_require__ @ App.js:20 (anonymous) @ App.js:63 (anonymous) @ App.js:66 18:59:59.978

Home Section:
`

All
Residential
Restoration
Commercial
Industrial
Landscape
Research
Feature

`

Based on your HTML structure you're instantiating filterizr on the wrong html element it should be this.filterizr = $(".filtr-container"); and not this.filterizr = $(".filtr-container__row");

@giotiskl  I tried to connect as you advised, but the error 'is not a function' still exists

I just had the same issue. While it worked fine using webpack 3 I now got this error message using webpack 4 for bundling. I was able to solve the issue importing Filterizr like that:
import filterizr from 'filterizr/dist/jquery.filterizr.min.js'


Add semconv classes from 1.23.1 for compatibility

The classes have almost been copied as-is with a few minor modifications:

@Deprecated annotation to both classes and all their direct fields and inner classes
add deprecation warning at class level

Replaced by a PR directly on the upstream repo: https://github.com/open-telemetry/semantic-conventions-java/pull/62


NO-ISSUE: Bump express version to 4.19.2

Fixes https://github.com/advisories/GHSA-rv95-896h-c2vc

@tiagobento I'll check it

@tiagobento Removed.


Locking mechanism

Certain jobs like config-parquet-and-info write to a repository and may have concurrency issues (see e.g. https://github.com/huggingface/datasets-server/issues/1349)
For config-parquet-and-info we need to lock the job at the dataset level, so that no other job of the same type for the same dataset write at the same time.
This can be implemented using mongodb

lock the job at the dataset level

indeed, because all the configs share the same git branch, and we don't want to interleave commits.


mdbook-pdf: 0.1.5 -> 0.1.6

Description of changes
Manual update. Unlike in the past, don't know why @r-ryantm failed to bump this version.

Things done
Rust version update

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Build is failing on all platforms: https://github.com/NixOS/nixpkgs/pull/232225/checks?check_run_id=13517857268

Build is failing on all platforms: https://github.com/NixOS/nixpkgs/pull/232225/checks?check_run_id=13517857268

Ah, now I know why r-ryantm didn't schedule a version bump. It looks like it's related to https://github.com/rust-headless-chrome/rust-headless-chrome/issues/355 Will try to investigate and come back later,

Now it should be ready.


Sema: Targeted fix for bad interaction between resilience checks and -enable-testing [v2]

Fixes rdar://problem/32592973.

@swift-ci Please smoke test

@swift-ci Please smoke test


Visible Yes / No Options

I'm going to throw a request in here to just simply have Yes / No option for Visible when adding a New page (remove Auto):

In the end the only options are Enabled / Disabled, so I think this would be best really.

This was actually  added to to an issue where people wanted to be able to more easily add new pages and have the wizard modal (this window) know if the other pages added for this parent were predominantly visible or not.


JDK7 build does not work because BouncyCastle 1.66 dependency requires Java 16

When using org.scorexfoundation:scrypto_2.11:2.1.10 dependency, the build on Android fails:
Reason: IllegalArgumentException, message: Unsupported class file major version 59
It is needed to use org.bouncycastle:bcprov-jdk15to18:1.66 instead.

@MrStahlfelge please create a PR with the necessary changes.

Unfortunately, I cannot come up with an own PR because I am not familiar with the Scala Build Tools used here.
When fetching the lib with Gradle, I can workaround the problem with the following dependency declaration:
    implementation ('dependencyusingscrypto') {
                exclude group: 'org.bouncycastle', module: 'bcprov-jdk15on'
            }
      implementation "org.bouncycastle:bcprov-jdk15to18:1.66"

This way everything works as expected.


[Feature Request] Make sure multiple concurrent speculative tasks aren't discarded

Apparently server might send multiple speculative WFTs at once if there are concurrent updates. If it does, make sure that works.

To clarify the spec, I believe that if multiple concurrent speculative tasks are sent by the server it will end up discarding all but the last one. It is important on the SDK  side we don't let these concurrent tasks effect each other by say running in parallel or corrupting  the cached state of a workflow execution

To clarify the spec, I believe that if multiple concurrent speculative tasks are sent by the server it will end up discarding all but the last one. It is important on the SDK side we don't let these concurrent tasks effect each other by say running in parallel or corrupting the cached state of a workflow execution

Riight, ok I remember our conversation better now. That definitely doesn't happen and isn't an issue.
So, what this really says is, like normal WFT, there is not any reason for me to buffer more than one of these at a time. Sounds like I'll need a 1-size buffer for non-query-only WFTs, and a longer buffer for query-only WFTS

Server might have only (no more than) one scheduled/started WFT at any given moment of time. It doesn't matter if it is normal or speculative. If update comes while WFT is running on the worker it will be sort of buffered on server and waiting for WT to complete.
There is some sort of edge case though. If shard was moved (or pod restarted) during speculative WFT execution, server will lost information about it. And if new update comes in, server will create new WFT and will dispatch to the worker. Worker will get WFT with the same ScheduledId. We added protection on server and it now compares also timestamps of WFT. So when first WFT will be responded back to server as Completed, server will reject (return NotFound) because actual running WFT (from server prospective) has another timestamp.

Forgot to close this a while back when I changed buffering behavior.


[top / ast] tooling improvements for long term ast integration

[x] create a tlgen / topgen method of forwarding a tlul connection out of the top.  This particular point may be somewhat related to the subsystem idea that has to be done long term for always on modules.
[ ] create a clkmgr / rstmgr templating method to directly create resets / clocks needed by ast without hard coding or forwarding through another module.  The forwarding doesn't work well because it restricts clock groups and power domain information.
[x] add _i/_o suffixes to 'ext' intermodule
[x] Also allow custom name definition (instead of concatenated names) for 'ext' intermodule

@eunchan has already finished most of these items... just one more left for me :)


Please use a friendlier GUID format for COM GUID identifier

The GUID format at the top of the page for WinRT COM interfaces is in an extremely non-standard comma-delimited big integer format, rather than the typical hexadecimal GUID format that Microsoft/COM uses everywhere else.
For example:
[Windows.Foundation.Metadata.Guid(4224269862, 41290, 19279, 130, 176, 51, 190, 217, 32, 175, 82)]

This is ungoogleable and not even greppable given the code base.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9061f282-f1c0-9b73-660a-48a79b237abc
Version Independent ID: 062bf2c8-baaf-a5f6-517f-2a1e6b2f06c1
Content: ILaunchActivatedEventArgs Interface (Windows.ApplicationModel.Activation) - Windows UWP applications
Content Source: winrt-api-build/xml/Windows.ApplicationModel.Activation/ILaunchActivatedEventArgs.xml
Product: uwp
Technology: winrt-reference
GitHub Login: @mikben
Microsoft Alias: mikben

Thanks for submitting your feedback and we apologize for the delayed response. I see that updates have not been made since the creation of this Issue, so I went ahead and created an internal work item to engage with our engineering folks to discuss this docs concern. The part of the document you're concerned about is not human-authored. It is generated by the publishing system. We will see if the system can be improved to change the GUID display. The timeline for this may vary, so I will go ahead and close this and circle back when the changes are live.
Though the Issue will be marked as Closed, we will monitor any replies that come afterwards so treat this like an open Issue. Many thanks!


Add clickXY which lets you click arbitrary coords.

I found a stackoverflow which suggested you can run
document.elementFromPoint(x,y) to get an element.
This followed by click() should do the right thing.
I added a unit test just to prove it.

Hi, thanks for your PR everything looks fine, however I would like your opinion of what do you think about merging clickXY into click?
something like:
browser.click("#my-id", 1) // click given element
browser.click(2,2); // clicks coorditantes

Because a selector will never be a Number, we could modify the behaviour (clicking a private method _clickXY) if click is called with numbers
I feel this may be a better approach for end user, what do you think?

I like to keep my method signatures clean.  But I'm willing to humor the other approach

Thanks @joeheyming , the CI failed due to a server error, I restarted it, as soon as it finish I'll merge this.

I manually merged this to the dev branch instead of master so I'll close this PR as it doesn't detect it as merged
thanks for your help


Group Issues

Hey,
When I try to set 1 light it's fine but when I try to set a group (philipsHue.setGroupLightState(0, state);), I get an error:
                throw e;
                ^
Api Error
    at HueApi._getGroupLightStateOptions (/Users/phineas/Desktop/dev/projects/node/parahouse/node_modules/node-hue-api/hue-api/index.js:1075:29)
    at HueApi.setGroupLightState (/Users/phineas/Desktop/dev/projects/node/parahouse/node_modules/node-hue-api/hue-api/index.js:366:24)
    at Object.<anonymous> (/Users/phineas/Desktop/dev/projects/node/parahouse/src/home.js:20:12)
    at Module._compile (module.js:573:32)
    at Object.Module._extensions..js (module.js:582:10)
    at Module.load (module.js:490:32)
    at tryModuleLoad (module.js:449:12)
    at Function.Module._load (module.js:441:3)
    at Module.runMain (module.js:607:10)
    at run (bootstrap_node.js:382:7)```

The line you have hit is
deferred.reject(new ApiError("RGB state is not supported for groups yet"));

If you captured the error message, it would have been more clear. The problem is that RGB is not an easy thing to implement as it requires knowledge of the lights that are in group, as the RGB coordinates have to be converted for each different type of light into a HSL value.
Due to the fact you can combine things like a white light, and any number of different coloured hue devices, this would be a very thing to do as you have to make many calls to the Hue Bridge to be able to do this. It would be unlikely that you achieve this in a time frame where it would not be noticeable to the user, and each type of light would have to be activated differently.
To properly achieve this, the Hue APIs and applications tend to use scenes to achieve this type of activity, or try to use a HSL value instead, as that will be transformed by the bridge to the closest value that the light can handle, although I think you will still hit errors if there is a white light in the group.


where to get the dataset ?

Hi guys,
I'm new to BaM and currently I can run the array benchmark on my machine successfully.
So I'm going to run the BFS benchmark but I'm wondering how to get the dataset (graph raw dataset) firstly ?
Appreciated if anyone could share the dataset to me :-)
Thanks.

Hi @LiangZhou9527 ,
We still haven't figured out what to do for sharing the datasets. There are two key problems:

Licensing - which we do not have full control.
Size - cost of hosting the dataset over time and payment for each egress requests.

Both of these are not easy to solve sustainably.
Our current recommended approach which most people who are using BaM have taken is to follow the dataset generation principle laid out in our EMOGI GitHub repo (https://github.com/illinois-impact/EMOGI#dataset)
Let us know if that works for you. If not, we will have to spend time on figuring the 1 and 2 out.


Proposal for fix-typed recursive array

Motivation: while this works in crystal...
a = [1,2,3,[4,5]]

... the following does not work (but does in ruby):
a = [1,2,3]
a.push([4,5,6])
a.push(7)
p a # -> => [1, 2, 3, [4, 5, 6], 7]

Moreover, both is not available in a flexible way in crystal for instance/class variables since they need to have a fixed type.
So I tried to come up with something generic. Since this is not absolutely straightforward to me and to my knowledge not yet available in the crystal lib, maybe you want to add something like this?
class RecursiveArray(Type)
    property value : Type | Array(RecursiveArray(Type))

    def initialize # empty
        @value = [] of RecursiveArray(Type)
    end
    def initialize(value : RecursiveArray(Type))
        @value = value.value
    end
    def initialize(value : Type | Array(RecursiveArray(Type)))
        @value = value
    end
    def initialize(value : Array(Type)) # syntactic sugar, supports e.g. RecursiveArray(Int32).new([1,2,3])
        @value = value.map {|el| RecursiveArray(Type).new(el).as(RecursiveArray(Type))}
    end
    def initialize(value) # syntactic sugar; supports e.g. RecursiveArray(Int32).new([1,[2,3]])
        @value = from_a(value).value
    end
    # push always pushes only _one_ element (vs. concatenation of arrays)
    def push(el : RecursiveArray(Type))
        if v = @value.as?(Array(RecursiveArray(Type)))
            v.push(RecursiveArray(Type).new(el.value))
        end
    end
    def push(el : Type | Array(RecursiveArray(Type)))
        if v = @value.as?(Array(RecursiveArray(Type)))
            v.push(RecursiveArray(Type).new(el))
        end
    end
    def push(value : Array(Type)) # syntactic sugar
        if v = @value.as?(Array(RecursiveArray(Type)))
            v2 = value.map {|el| RecursiveArray(Type).new(el).as(RecursiveArray(Type))}
            v.push(RecursiveArray(Type).new(v2))
        end
    end
    def [](index : Int32)
        if v = @value.as?(Array(RecursiveArray(Type)))
            v[index]
        else
            raise("foo")
        end
    end
    private def from_a(value)
        if value.is_a?(Type)
            res = RecursiveArray(Type).new(value)
        else
            res = RecursiveArray(Type).new
            value.each {|el| res.push(from_a(el))}
            res
        end
        res
    end
end

Some tests:
class MyTest
    @x : RecursiveArray(Int32)
    def initialize
        # basic
        @x = RecursiveArray(Int32).new(1)
        @x = RecursiveArray(Int32).new([RecursiveArray(Int32).new(2),RecursiveArray(Int32).new(3)])
        p @x[0].value # -> 2

        # RecursiveArray
        @x = RecursiveArray(Int32).new([RecursiveArray(Int32).new(1), RecursiveArray(Int32).new([RecursiveArray(Int32).new(2),RecursiveArray(Int32).new(3)])])
        @x.push(4)
        @x.push([RecursiveArray(Int32).new(5)])
        p @x[1][0].value # -> 2

        # sugar
        @x = RecursiveArray(Int32).new([1,2,3])
        @x.push([4,5,6]) # very much like ruby
        @x.push(7) # dito
        # p @x.value # #value is best to access _leaf_ values
        p @x[3][2].value # -> 6

        @x = RecursiveArray(Int32).new
        @x.push(1)
        @x.push([2,3,4])
        p @x[0].value # -> 1
        p @x[1][1].value # -> 3

        @x = RecursiveArray(Int32).new([1,2,3,[4,5]])
        p @x[3][1].value # -> 5
    end
end

MyTest.new

BTW: first I tried something based on alias (https://crystal-lang.org/reference/syntax_and_semantics/alias.html) but then I learned on the one hand side they might get thrown out again (#5155) and on the other had some troubles on my first experiment based on the provided example.
Another note: I also tried to implement the complementary method to_a. But then I realized this is not possible with crystal as it is since this already makes the compiler break:
def x
    res = [1]
    1.times do # this loop already breaks compilation
        res = [1, res]
    end
    res
end

p x

As for use cases: I use the arbitrary ruby arrays e.g. for trees or tree like data structures.

@Blacksmoke16 (https://github.com/crystal-lang/crystal/issues/10461#issuecomment-788323116 above): since in ruby this is part of the language the shard idea somehow was a blind spot to me.
So if you don't see a general merit in it, I will probably follow your idea then.

I use the arbitrary ruby arrays e.g. for trees or tree like data structures.

Kay, that's a use case but IMO not a good one. Using generic, nested arrays for this isn't really a good idea. Neither in Crystal nor Ruby, but Ruby lets you get away with it. Maybe that's okay for Ruby.
But in Crystal you're way better of just using a special data type to represent an actual tree.  But I don't think it belongs in stdlib. There are many ways to implement such a data structure and different use cases ask for different implementations. Unlike Array which is for very broad use cases, any tree implementation is more specific and less commonly useful.


Add \set-default command to change the default value of settings

One of the user case is to replace the default font of the document. Since the default font is hard-coded into the script. Everytime when execute SILE.settings.reset, we will go back to that font. This behavior
is not desired when you are using book class with footnotes and folio.
For example, with the following piece of code, the master frame would be set to Source Han Serif font, while the footnotes and folio frames are still the default Gentium Plus (on my computer, it is fallback to simsun):
\begin[class=book, papersize=100mm x 100mm]{document}
\script[src=packages/lorem]
\set[parameter=font.family, value=Source Han Serif CN]
\lorem[words=10]\footnote{\lorem} \lorem[words=10]
\end{document}

After applying this patch, we added a \set-default command, which can change the default value for all following codes. So the following code:
\begin[class=book, papersize=100mm x 100mm]{document}
\script[src=packages/lorem]
\set-default[parameter=font.family, value=Source Han Serif CN]
\lorem[words=10]\footnote{\lorem} \lorem[words=10]
\end{document}

will generate this:

Coverage decreased (-0.03%) to 92.352% when pulling d92bc228a336c48fc6d2ca70de63f90a575271a0 on harrysummer:set_default into 257b581b61c7e6cd21bd891d0fad5b2ab592dd52 on simoncozens:master.

Thanks for addressing this issue. I've run into it before. I have some questions about this implementation. Something doesn't feel quite right, but the problem it addresses definitely does need fixing. I'll give it a bit of a review when I get a chance and compare to how I've worked around this in the past.

I don't understand why all the smoke and mirrors with a parallel set of "dirty" queues is necessary. Why not just set the value in SILE.settings.defaults and be done with it?

@alerque My original thinking was just adding a command to change the default settings. However, when I tried to implement it, I found that only changing the default value might not be sufficient.
For example, assuming we have a package implementation which uses a new set of settings by calling:
SILE.settings.pushState()
SILE.settings.reset()
-- typesetting code of the package
SILE.settings.popState()

And we assume that in the outer environment, we didn't call any SILE.setings.set() to chang e the setting value. Then, what if we call \set-default inside the package? (This might not very common though, but I just want to make the setting system robust and complete for all cases) The natural behavior is to change the current value of the outer environment too, because it wan't been detained. This is where is dirty queue come from. When we are poping through the state stack, we will replace the setting value if the value is not detained. (I missed some part in the pop function though) Hope this can help you understand my design decisions.
I agree that your idea of implementing as  a flag in existing \set command is brilliant. I think I will go with that by adding a default boolean option in \set command.

The scenario you outline is an edge case I hadn't considered, but I'm not sure I agree with your desired output. If I call popState() in my package I would expect it to revert to the state that was pushed even if that state was the default at the time but no longer is. I don't think monkeying with that is actually an improvement. If a package monkeys with the defaults it shouldn't be doing so after a reset in a temporary typesetter anyway.
Note if you rework this to be part of set(), be sure to use SU.boolean() like this to check the flag so false and nil values get handled correctly:
local makedefault = SU.boolean(options.makedefault, false)

I agree with alerque: temporary changes (even to defaults) should be temporary. Consider the case where you're actually typesetting two documents in parallel. (Yes, this does happen.) The two sets of settings should be isolated.

Updated. Handled default value changing as makedefault boolean option of \set command.
Now I can write
\begin[class=book]{document}
\set[parameter=font.family, value=Source Han Serif CN, makedefault=true]
Hello\footnote{Hello}
\end{document}

And both master frame and footnote will be the same font.


Azure Data Studio Version in E1T3

Exercise 1, Task 3 mentions in steps 4 and 5 to download a specific version of Azure Data Studio, but the version that it lets you download no longer supports the version of Windows Server we are using in the VM.
Instead, if learners accidentally update their version of Azure Data Studio, they should uninstall it and install the version in this GitHub repository: https://github.com/microsoft/TechExcel-Securely-migrate-Windows-Server-and-SQL-Server-workloads-to-Azure/tree/main/Hands-on lab/resources/tools
The Solution for E1T3 should be updated to reflect this--or, if there is a content refresh, we should use newer versions of VMs (e.g., Windows Server 2016) that will not experience this issue for some time.

This has been addressed in the latest refresh with PR #27.


refactor: install cmd section

About this PR
This PR enhances/refactors the installation section. It gets the installer based on the users current OS.
Current change was inspired from the Rust website and it provides convenience to  the end-users.
Deno.build.os was mainly utilized to make this & the Shell installer will be defaulted to if user not running Windows/Darwin while still providing the option to see other installers.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Limitations on Filegroups on SQL Express

Can I kindly request that more information is added to this article with regards to the possible limitations there are when using SQL Express, specifically when it comes to the 10Gb limit. Do FILESTREAMS form part of the 10Gb data limit?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8bd7807f-5dde-795d-56b9-3d4b9c4187cb
Version Independent ID: 61ca2613-e6fe-b3c2-e4d4-fbf264bbc20d
Content: FILESTREAM (SQL Server) - SQL Server
Content Source: docs/relational-databases/blob/filestream-sql-server.md
Product: sql
Technology: filestream
GitHub Login: @douglaslMS
Microsoft Alias: douglasl

Hi @JasonLoKiSmith , thanks for bringing this to our attention! Let me do some research and get back to you. Thanks!

Hi @JasonLoKiSmith , thanks again for contacting Microsoft! It looks like the 10gb limitation does NOT include filestream: https://docs.microsoft.com/en-us/sql/relational-databases/blob/filestream-compatibility-with-other-sql-server-features?view=sql-server-2017#SQLServerExpress
I hope that helps and please let me know if we could be of further assistance. Thanks!

Hi @JasonLoKiSmith , thanks again for reaching out! As it's been some time since we've heard from you, we'll assume the information provided was sufficient, and proceed with closing out this Git Issue. Please feel free to reply should you need anything further. Thanks!

Hi guys,
Yes you can close this, thank you so much for your assistance!
Regards
Jason
On Tue, Apr 30, 2019 at 7:55 PM Masha at MSFT<EMAIL_ADDRESS>wrote:

Hi @JasonLoKiSmith https://github.com/JasonLoKiSmith , thanks again for
reaching out! As it's been some time since we've heard from you, we'll
assume the information provided was sufficient, and proceed with closing
out this Git Issue. Please feel free to reply should you need anything
further. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/sql-docs/issues/1980#issuecomment-488051206,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHZZDDFGOELPIPUERPLUR63PTCBZBANCNFSM4HIAQ26Q
.


Parameter Verification

Hi,
I had q quick look through the docs but apart from generating a "filter", i.e "integer", I didn't find any way to define the required type of options.
For example, if I specify option "n" as an integer, I'd ideally like an automated error message during parsing if the user specifies something that can't be parsed as an integer. I'd also like the integer requirement to be stated in the auto-generated documentation.
Is this possible at the moment?

Error messages have to be generated by the developer. You can check, if parsing fails, either per parameter (see here) or by analyzing the parsing result (see here).
At the moment, I dont't have any default error handling facility included. The requirements vary a lot and I'd only like to include something truly canonical.
However, the debug namespace contains a function for quick analysis:
using namespace clipp;
auto cli = ( /* ... */);
auto result = parse(argc, argv, cli);
if(!result) debug::print(std::cout, result);

Also the filter does only check, if an argument can be matched and not why it couldn't be matched.

I had another look at this... As an example, I'm trying to add an option that takes a mandatory integer argument:
Option 1:
int max;
(option("-m") & value("max=1", max)) % "Maximum value",
If specifying an argument that can't be parsed as an integer, this will set 'max' to zero and I haven't been able to figure out if there is even a way to detect that something went wrong.
Option 2:
int max;
(option("-m") & integer("max=1", max)) % "Maximum value",
This will at least filter out any non-integer arguments, and I can detect that something went wrong by going through res.missing(), as well as checking the vector of unknown arguments populated by using the "any_other" catch-all parameter. But this all seems a little bit too complicated and ambiguous.
I guess the type information for the argument is already specified by passing an int ('max') as the second argument of the value parameter. What I'd like is some convenient way of detecting if the argument couldn't be parsed into the destination variable specified ('max' in my case).
Maybe something like this:
for(const auto& m : res.parse_errors()) {
cout << "Parameter parse error after index " << m.after_index() << ':' << m.parse_error_msg() << '\n';
}
Maybe this is all possible already and I just don't know how do achieve what I want. How would you currently implement what I'm trying to do?


1.2.1 enhancement

Coverage decreased (-2.7%) to 88.336% when pulling e8fb29dbfd2bcd551b32536ca952083a193135be on ZhangH795:1.2.1_Enhancement into 5c16b63cec4280447e75e595df6ed77179242b32 on CS2103AUG2017-W09-B3:master.

Coverage decreased (-3.3%) to 87.69% when pulling c42b79f5411621b7e7b15c0d122ec03580422aa2 on ZhangH795:1.2.1_Enhancement into 5c16b63cec4280447e75e595df6ed77179242b32 on CS2103AUG2017-W09-B3:master.

Coverage decreased (-1.9%) to 89.119% when pulling c412ab072abec18adc94762ea8ace087dc754456 on ZhangH795:1.2.1_Enhancement into 5c16b63cec4280447e75e595df6ed77179242b32 on CS2103AUG2017-W09-B3:master.

Coverage decreased (-1.5%) to 89.527% when pulling 5d4e2f4b366ad196d5e83ad9431e73fdf9aa8cd7 on ZhangH795:1.2.1_Enhancement into 5c16b63cec4280447e75e595df6ed77179242b32 on CS2103AUG2017-W09-B3:master.

Coverage increased (+0.1%) to 91.181% when pulling 43e4e1e853c565750228bc6fa08448d58d815183 on ZhangH795:1.2.1_Enhancement into 5c16b63cec4280447e75e595df6ed77179242b32 on CS2103AUG2017-W09-B3:master.


Removes unsed function: ssl_bad_method()

Typo in commit message : unsed

I don't know the history of this function: is it something that is no longer used, or might it still want to be included much like a 'NOP' or abort() function, to be used as a placeholder?

I don't know the history of this function: is it something that is no longer used, or might it still want to be included much like a 'NOP' or abort() function, to be used as a placeholder?

As far as I can tell this has been dead code for a long time and no one noticed. I see its use being removed in commit 01a9792f05a2 in 2005!!

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged to the master branch. Thank you for your contribution.


Fix chunk for plotly

Pull request not relevant anymore, as the import('plotly.js/dist/plotly.min.js') was removed in previous commits
see: https://github.com/eea/volto-plotlycharts/pull/123/commits/c9f1f3856f9d04826aba10dca154e9be2cb9996c#diff-8c0288c21bcbe1ea5772cfef279a35faab0659db58ee05b920d565ff7047702dL159


NSI GPKG Reader

I am proposing code to add a GPKG reader for a local NSI file. A few notes:

I was not able to fully test the code, as I wasn't behind the firewall.
I am trying to have the application recognize when we are behind the firewall or not. I tested my code for GetByFipsStream and that works, but I was unable to test for GetByFips (so I have commented those edits out for now). The error checking cases for both might need to be more robust though.
The NSI location is set to the working directory under an NSI file for FIPS 29. I wonder if we could prompt the user for this location so its not hard-coded.

Thanks!
Sam

@sacohen11 I took a stab at the changes on the master branch. I did not get quite finished - but i think it is a start. In order to bring this together I think we need to add an interface for structureprocessor or structure provider so that we can implement it on NSI and the gpk one I copied from you. Then i think we need to refactor the compute to work off of a struture provider and a hazard provider. then i think we have the code in a much improved and stable place for the future

Closing this, the code was manually migrated into gpk-structure-provider and converted to use gdal instead of sqlite3 as a dependency.


RE patterns: consider Rubifying the syntax

The RE syntax is the same as it is in LPeg and so is influenced by Lua syntax. For example, pattern repetition is patt^n, even though the similar in first-class RPeg would be patt ** n.
Reconsider this. Should we use syntax that is closer to Ruby?

It would fit better with the rest of RPeg.
But as things stand, re patterns from LPeg can be used as-is with RPEG::RE.

Does this matter?

The current, LPeg-style is also somewhat closer to regex and much closer to the theoretical PEG format https://en.wikipedia.org/wiki/Parsing_expression_grammar

so it's probably best to leave it as it is.

Leave it as it is:

closer to regex
close to PEG-in-theory format


How to get the text inside delimiter?

Markwon version: 4.5.0

I have similar problem like in #140  , i tried SimpleExtPlugin, but i don't know how to get the text inside the delimiter.
I'm using these as opening and closing delimiters [[ and ]]
I want to get the text inside delimiters and convert it to link.
For example [[My Example]], will be rendered as My Example
Could please advice some pointers?

Hello @rshah ,
you can obtain clicked text using technique from the sample (check the ClickSelfSpan and its linkTitle method)

Thank you for the sample @noties .
Actually i want to get the text My Example from [[My Example]] and convert it to any other span, for example link or just change the foreground color.
I tried with SimpleExtPlugin like this:
Markwon.builder(view.context)
     .usePlugin(SimpleExtPlugin.create {plugin ->
             plugin.addExtension(2, '[', ']') { configuration, props ->
                    ForegroundColorSpan(Color.RED)
              }
      })

But it will not be rendered as red color also the text still have delimiters [[My Example]]

I tried change the delimiter as in your simple-ext @ and $, it's work.
So i guess these delimiters [[ cannot be used in SimpleExtPlugin.
May be i should follow something like reddit spoiler sample, but how to remove the delimiter instead of hide it/make it transparent i want to remove the delimiter completely.

I managed to get the text My Example using these:

Create plugin from AbstractMarkwonPlugin and replace [[ with other delimiters
Create inline processor to parse replaced text above and return Text node when matched.

Not sure if this is the good way.

Hello @rshah ,
yes, [ character is considered a special one and thus won't be used when creating own delimiter or inline processors. For inline you could disable OpenBrackerInlineProcessor but this would disable markdown links also, so it might not be a good solution.
Anyway, if you have found a solution that works for you - I think it is good enough 😄


Fire event on window and not document.

I assume this is needed in case you are loading a page which is slow to load over the network. In my case I was not receiving events on the document object. This works, though I'm not entirely sure why.

I'm starting to work on this. I think I should have something by end of today.

I'm starting to work on this. I think I should have something by end of today.

For this one, or #8?


Fix darker workflow

Switching to main branch broke the darker action. This PR fixes that,

Codecov Report

Merging #175 (d1138c7) into main (9b9ad7d) will decrease coverage by 0.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
- Coverage   79.10%   78.48%   -0.62%
==========================================
  Files          16       16
  Lines        2407     2338      -69
==========================================
- Hits         1904     1835      -69
  Misses        503      503

Impacted Files
Coverage Δ

broadbean/element.py
82.23% <0.00%> (-1.60%)
:arrow_down:

broadbean/broadbean.py
60.24% <0.00%> (-1.56%)
:arrow_down:

broadbean/sequence.py
69.54% <0.00%> (-0.42%)
:arrow_down:

broadbean/blueprint.py
88.94% <0.00%> (-0.24%)
:arrow_down:

broadbean/tests/test_awgfilegeneration.py
95.58% <0.00%> (-0.13%)
:arrow_down:

broadbean/tests/test_forging.py
96.55% <0.00%> (-0.08%)
:arrow_down:

broadbean/tests/test_element.py
100.00% <0.00%> (ø)

broadbean/tests/test_sequence.py
100.00% <0.00%> (ø)

broadbean/tests/test_blueprint.py
100.00% <0.00%> (ø)

broadbean/tests/test_subsequences.py
100.00% <0.00%> (ø)

... and 1 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


feature/handle Ctrl+C and Ctrl+D

Features I added:

handle Ctrl + C

if user pressed it two times, it will hint how to exit the program

handle Ctrl + D

exit the program

Thanks @karastift, Even when GmailBruter isn't under development support right now. I love your code style and the way you explained the code with comments along with really clean code. Changes gonna be accepted