Add Slang language documentation

The Slang language needs documentation.
Motivation
Our high degree of compatiblity with existing HLSL code means that many programmers can (and do) rely on documentation for the HLSL langauge, but this has several draw-backs

It doesn't help in the cases where Slang extends HLSL with new features (e.g., generics)
It doesn't help in the cases where Slang intentionally deviates from an existing HLSL feature (e.g., not including the pervasive "splatting" behavior)
Many programmers are not pleased with the quality of the existing HLSL documentation

The best solution to the problem is for us to develop some better documentation of the Slang language itself, which exists separate from other similar languages.
Scope
This issue is specifically about better documentation of the Slang language, and not the "standard library" code or the Slang compiler API.
Documenting library code is often best done through automated tools (e.g., doxygen and its ilk), so the work required to document the Slang standard library is qualitatively different from that required to document the language. We should track requirements and plans for library and/or API documentation separately.
In practice there are certain features of Slang that are technically library code, but that a user is likely to think of as part of the language (e.g., the bool type). A language reference will likely need to introduce these types, even if it leaves some aspects of their documentation to other references.
Open Questions
Specification, reference, or guide?
There are many different categories of documentation we could aspire to write, with different levels of formality. To clarify what I mean by these terms:

The C++ specification tries to pin down the exact syntax and semantics of the language as little ambiguity and "wiggle room" as possible, even if doing so makes the document hard for anybody but an expert to follow.

The Rust reference attempts to introduce all the elements of the language using a taxonomic top-down organization. It doesn't try to formalize things, but it is also more concerned with covering all the details than with providing a gentle ramp.

The first major section of The Swift Programming Language is a language guide that tries to teach aspects of the language in a good order for learning, by way of many examples.

There is some wiggle room on these terms (e.g., I'd claim that the GLSL "specification" is really a reference, but that's just me), but hopefully the examples make some of the differences clear.
Given that we are unlikely to have bandwidth to produce multiple documents describing the Slang language right away, we need to pick which level of formality to aim at first.
My personal take is that a good reference-level document on the language is the most important thing to have. A specification is really only valuable if there are going to be multiple implementations of the language, and guide-level documentation is not as important when most programmers coming to Slang will already be familiar with C/C++, HLSL/GLSL, or other similar languages and won't need a very gentle ramp.
Presentation
When somebody goes to read this documentation, what should they be faced with? A few option that seem reasonable to me:

The language reference could just be presented as some Markdown (or similar) files under the docs/ directory in GitHub, such that people can browse them easily while looking at the repository.

We could try to produce a PDF language reference that gets exported as part of the deployment process, so that ever binary package of Slang includes a self-contained reference document

We could try to export language reference information to be readable via GitHub Pages (which could be driven using HTML or any GitHub-supported markup)

It might be that multiple of these can be achieved, but each involves some level of effort. The first option, which could amount to just checking in some Markdown files in the existing repository, might be a good starting point.
Authoring
The choice of how to author the documentation intersects heavily with the choice of how to present it. LaTeX might be a reasonable choice if we primarily care about PDF output, but it seems far more likely that we'd want to use a GitHub-friendly markup format.
While Markdown is often the natural choice (being one of the most humane markup formats), it also might be more limited than other options if we do want to collate things into a nicely formatted PDF. Formats like AsciiDoc and ReStructured Text are seemingly better suited to complex documents.
Summary
I'm creating this issue in the hopes of fostering discussion about how to proceed with some better documentation of the Slang language. Hopefuly we can agree on an initial plan and get started building out the skeleton of what we want to see.

PR #1279 represents a first step toward a language reference under our docs/ directory.

We have a user-guide now.


React Player won't render in Chrome 70

After Chrome 70 rolled out, the React Player won't render. The wrapper still shows up on the page but the player itself doesn't show. We are just playing MP3's hosted in S3 and this works in other browser fine.

The mp3 example in the demo page works for me on Chrome 70. Do you have any more details about what exactly is going wrong? Any error logs? Does the <audio> element appear in the DOM?

Good to know – thanks Joe. Possibly something around height: 100% and audio tags differing across browsers. I'll close this off as it seems to be an issue with styling and not a problem with ReactPlayer.


P dispersion

Implement p-dispersion model for GSoC '22

Addressing #269.

Oops, just saw this after fixing the plot, but your code is much cleaner.
I'll play with implementing your solution a bit later, thanks!
On Fri, Aug 19, 2022 at 3:33 PM Germano Barcelos @.***>
wrote:

@.**** commented on this pull request.
I just have this comment and it looks nice to me. Again, you are doing an
awesome job @erinrolson https://github.com/erinrolson.
In notebooks/facloc-disperse-real-world.ipynb
https://github.com/pysal/spopt/pull/268#discussion_r950506058:

"    legend_elements.append(_patch)\n",

"\n",
"    if 'predefined_loc' in facility_points.columns:\n",
"    \n",
"        pre_fac = facility_points[facility_points.predefined_loc == 1]\n",
"        for i in range(len(pre_fac)):\n",
"            pre_fac.iloc[[i]].plot(ax=ax,\n",
"                        marker="*",\n",
"                        markersize=200 * 3.0,\n",
"                        alpha=0.8,\n",
"                        zorder=4,\n",
"                        edgecolor="red",\n",
"                        facecolor=pre_colors[i])\n",
"\n",
"        other_fac = facility_points[facility_points.predefined_loc == 0]\n",
"        for i in sited_facilities:\n",

Aha! Gotcha! This is a super tricky thing.
In this case:
fac_sites = [0, 3, 5, 6, 7, 11]
sited_facilities = [0, 1, 2, 3, 4, 5]
other_fac contains stores sites, except predefined ones and it has 16
rows (index ranging from 0 to 15), so when you index with sited_facilities
you are using the right indexes but in a dataset that doesn't correspond to
the facilities chosen. So, it will print more stores than expected 9 in
this case instead of 6.
I recommend taking a look at this gist
https://gist.github.com/gegen07/32f961686f4b339870a72291ae32c322 I did
which makes it simpler and less repetitive. It also solves the issue of
printing more facilities than expected.
—
Reply to this email directly, view it on GitHub
https://github.com/pysal/spopt/pull/268#pullrequestreview-1079279907,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJKDQOXG32IVDTY2TENQJFLVZ7OQDANCNFSM56IWR6IA
.
You are receiving this because you were mentioned.Message ID:
@.***>

congrats on another successful PR @erinrolson! :tada:

Thank you!
On Fri, Sep 9, 2022 at 4:00 PM James Gaboardi @.***>
wrote:

congrats on another successful PR @erinrolson
https://github.com/erinrolson! 🎉
—
Reply to this email directly, view it on GitHub
https://github.com/pysal/spopt/pull/268#issuecomment-1242406295, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AJKDQOWXBVBOEPXCZGEMKDLV5OJOBANCNFSM56IWR6IA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Added basic styling to product page and a few fixes to main.css

styling looks better. need to fix allergen styling thoo


Added JENKEM Logo

Added the logo for the upcoming JENKEM token on Avalanche

Please open a PR with just your token image

Please open a PR with just your token image

Hey! Thanks for the reply sir! Will have another try at this. Sorry about that.


understanding response for update method

Hi again,
In my update method, I have:
    @project.update_attributes(params[:project])
    respond_with @project, :api_template => template

My specs pass on statuses for valid and error cases.
But the response body is empty when update went well. Why? (I'd expect the object to be returned)

It appears to be the default Rails behavior...
Sorry for false alert.


Using local file?

I havent found anything in the docs to use a local file, is this possible, and if so, how?

ok nvm its just that i needed to use error and converted inside the call back.


A problem about dubbo.tag

Hello everyone! The thing is the request of my dubbo comuser with empty tags goes to the providers with tags.  Is there anyone encountered the same problem, or knew how to save this problem.

Please describe your question clearly according to the template. The current content is invalid. It is difficult for us to understand your question. We will close it first, please submit it again.


Set up Continuous Integration

Acceptance criteria:

CI process is set up
Binary build are available to download from github

Was not successful with with current code base and Travis-CI


Create Cloud Application Development (Intern)

create a folder with name cloud computing , inside the folder add readme file and then add your details  you can add it on main page readme file


Add Keane to AUTHORS

@keaneokelley Can you give me a thumbs up/down if you'd like this merged?

Gah, messed up my git branches.  I'm only really asking for your permission to add you to the AUTHORS file!
v0.2.1 is up on PyPI now.


Custom fine-tune model

Is there currently any way of fine-tunning on a different model than the default one? (like passing a .ht file to the recognizer)
Also is there any way of training the recognizer with multiple gpus?
Thank you :)

Hi @tfilip!

Can I train a different model? In order to supply all the convenience functions, there are a lot of constraints that the architectures must satisfy. You can modify the recognizer and detector architectures somewhat using the keyword arguments (see API documentation and examples). For example, on the recognizer, you can select different RNN layers, number of filters, etc. If you wish to submit an amendment to the architecture, please open an issue to discuss your specific change.
Can I train the recognizer with multiple GPUs? A multi-GPU example is provided here.


Adds MulMulMul custom kernel

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.75%. Comparing base (b73a71c) to head (efb6046).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   84.75%   84.75%
=======================================
  Files          58       58
  Lines        7051     7051
=======================================
  Hits         5976     5976
  Misses       1075     1075

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[BugFix] Fix NoopResetEnv behavior when trials exceeded.

Description
When the _MAX_NOOPS_TRIALS were exceeded the transform was calling a final rand_step() without a step_mdp().
This PR add the step_mdp() call and

Improves the error message.
Adds tests to test for the edge case behaviors of the transform.
Fixes the documentation of the tranform.

Some things could be discussed. I left a TODO in front, which we will remove before merging.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I have read the CONTRIBUTION guide (required)
[x] I have updated the tests accordingly (required for a bug fix or a new feature).
[x] I have updated the documentation accordingly.

Yes. I also think a single reset is arbitrary and would lead to issues. That was the original behavior, I just fixed a bug in it.
I will refactor the transform so that it becomes simpler to parse and has less edge cases.

With this, the transform raises an error whenver its consistently not possible to ally the noops (1). We could also just raise a warning and not do any noop at reset (2).
Both options are valid in my opinion, and maybe the first one is better as it will nudge to user to be more careful when using the transform. E.g.
With (1) the user cannot get away by setting a high noops and `random=True` that may fail occasionally. With (2) they could get away with it at the env will just not receive noops occasinally.


Design a comment section for spectators to interact.

A spectator should be have a space to drop comments as they watch the game.

https://www.figma.com/file/5mZjRNojKB4vtatKlahMbu/Team-Tesla?node-id=1602%3A53377
Bombos


[Issue] incorrect parameters value in Configure role assignments for the VM

Regrading  https://docs.microsoft.com/en-us/azure/virtual-machines/linux/login-using-aad
Section  : Configure role assignments for the VM
In Azure CLI example there is a mistake in the position of the parameters.
instead of placing the $ at the beginning it's after the verb which is causing an exception :
username=$(az account show --query user.name --output tsv)
vm=$(az vm show --resource-group myResourceGroup --name myVM --query id -o tsv)
it should be :
$username=(az account show --query user.name --output tsv)
$vm=(az vm show --resource-group myResourceGroup --name myVM --query id -o tsv)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bb8e2623-1f79-aee3-bd97-8b5f647b6980
Version Independent ID: 6346b54d-cc8d-0b79-a6b8-f9144cfa2459
Content: Log in to a Linux VM with Azure Active Directory credentials
Content Source: articles/virtual-machines/linux/login-using-aad.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

Thanks for the feedback! We are currently investigating and will update you shortly.

@tzachie The two CLI commands that you are referring in the issue are for assigning the outputs of az cli commands to the variables. These are valid variable assignments.
If we run this $username=(az account show --query user.name --output tsv), then we will get error as the terminal will not understand to execute the az cli, please check below screenshot.

username is a variable for which the output value of the command az account show --query user.name --output tsv is assigned after it is executed. Similar is with vm variable.
Both the variable values are used in the az role assignment create command for VM role assignment.
I reproduced the issue for understanding the exception you mentioned while configuring role assignment to VM, but I did not get any exception. Please find below screenshots for reference, I have successfully configured role assignments to the VM following the document.

Did you follow all the steps in the document to configure role assignments for VM? Can you please share the exception error screenshot to have a look and understand the issue.

@tzachie I am closing the issue for now, you should be able to run the commands in bash terminal. Please reopen the issue if you still see issues on this.
Thanks.


Migrate logs to structured logging

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:

Thanks @eatjeff for attemting this.

You would need to fix the CI failure. We already are aon klog/v2 and you are trying to include klog again.
You don't need to raise an individual PR for each line of change. Please merge them into 1.
It would be great if you can also provide a brief about the improvement.


Move phone and tablet properties to ResponsiveMixin

Connected to #62
The goal here is to reduce bundle size and demonstrate how to use and annotate mixins. Also removed a few GestureEventListeners  usages to keep formatting nice.

This change is

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

src/responsive-mixin.html, line 10 at r1 (raw file):

   * @return {HTMLElement}
   */
  ExpenseManager.ResponsiveMixin = subclass => class ResponsiveMixin extends subclass {

BTW we could actually propagate tablet and phone using this mixin too, instead of using template bindings. Not a blocker, just an idea.

Comments from Reviewable

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

Reviewed 1 of 6 files at r1, 8 of 8 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Display currently used raiden versions in light client

User Story
As a light client user I want to know the raiden and raiden contract version the light client is currently compatible with.
Related to #226
Acceptance criteria

[ ] Raiden version should be displayed in the UI
[ ] Raiden contract version should be displayed in the UI

Tasks

I'm hard coding the contract version for now, as it's currently not possible to determine them dynamically (https://github.com/raiden-network/raiden-contracts/issues/1287)


[Python] test failure in io.rst

make pytest gives me the following error:
**********************************************************************
File "io.rst", line 511, in default
Failed example:
    import pyarrow as pa
    import pyarrow.dataset as ds

    ds.write_dataset(data, "./partitioned", format="parquet",
                     partitioning=ds.partitioning(pa.schema([("year", pa.int16())])))
Exception raised:
    Traceback (most recent call last):
      File "/home/antoine/miniconda3/envs/cookbook/lib/python3.9/doctest.py", line 1336, in __run
        exec(compile(example.source, filename, "single",
      File "<doctest default[0]>", line 4, in <module>
        ds.write_dataset(data, "./partitioned", format="parquet",
      File "/home/antoine/miniconda3/envs/cookbook/lib/python3.9/site-packages/pyarrow/dataset.py", line 878, in write_dataset
        _filesystemdataset_write(
      File "pyarrow/_dataset.pyx", line 3408, in pyarrow._dataset._filesystemdataset_write
      File "pyarrow/error.pxi", line 99, in pyarrow.lib.check_status
    pyarrow.lib.ArrowInvalid: Could not write to ./partitioned as the directory is not empty and existing_data_behavior is to error
**********************************************************************

cc @amol-


Fix compilation error in cli

Description of Change
Fixup the missing initialization of the score variable in the CLI code to resolve the compilation failure (variable score might not have been initialized)
Have test cases been added to cover the new functionality?
no

@jeremylong please review and merge, as this issue makes every PR workflow run into error


Add release notes for v2 runtime and opts

Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

Codecov Report

Merging #2553 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
+ Coverage   44.59%   44.62%   +0.02%
==========================================
  Files          95       95
  Lines       10007    10007
==========================================
+ Hits         4463     4466       +3
+ Misses       4822     4820       -2
+ Partials      722      721       -1

Flag
Coverage Δ

#linux
48.4% <ø> (ø)
:arrow_up:

#windows
41.58% <ø> (+0.03%)
:arrow_up:

Impacted Files
Coverage Δ

gc/scheduler/scheduler.go
68.75% <0%> (+1.44%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f13ff3...7ec9744. Read the comment docs.

LGTM


adding catchments to sewerhydraulics schema

Added new catchment schema as a basic analytical element
added a relationship to relate the catchment schema to a node
minor fix to the display label for the structure diameter.

/azp run iModelNativeTests


Make ConfigsExportServiceTest support windows

What's the purpose of this PR
Make ConfigsExportServiceTest support windows.

@nobodyiam My fault, fixed.


icons mjs, cjs, pug, ejs

Added .mjs .cjs for both nerdicons and nonicons.
Added .ejs .pug for nerdicons.

After checking nvim-nonicons nonicons can support some other icons (Ex: .ejs) BUT using the old way not the new one (the mapping).
And i noticed a lot of icons that can be supported is there any better way of handling icons ?

Could you bump the plugins' versions?


added v5().Execution().GetExecutionList() method

I tried to add v5().Execution().GetExecutionList(params) method getting /v5/execution/list endpoint data

Thank you for your contribution!


fix null bytes

Removes null bytes from strings going into postgres

Codecov Report

Merging #203 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #203      +/-   ##
========================================
+ Coverage   92.96%    93%   +0.04%
========================================
  Files         135    135
  Lines        2388   2389       +1
  Branches      129    125       -4
========================================
+ Hits         2220   2222       +2
+ Misses        168    167       -1

Impacted Files
Coverage Δ

sql/src/main/scala/hydra/sql/JdbcDialect.scala
85% <ø> (ø)
:arrow_up:

sql/src/main/scala/hydra/sql/AvroValueSetter.scala
91.8% <100%> (ø)
:arrow_up:

sql/src/main/scala/hydra/sql/PostgresDialect.scala
94.33% <100%> (+0.1%)
:arrow_up:

...ala/hydra/kafka/services/TopicBootstrapActor.scala
100% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1b5d6...c035b28. Read the comment docs.


Guide to Mozilla localization communities

We need to create a guide to Mozilla l10n communities.

@gueroJeff what should the guide contain? Do we have something similar on MozillaWiki?

I realize this is really vague, haha. I think this had to do with describing how community localization works, roles within the community, responsibilities and expectations for those roles, motivators, etc. We currently don't have anything written on it, but parts of it we're working on with the Open Innovation team as part of our Mission Driven Mozillians project with them. We'll continue to develop this with our intern this summer too.

I think this has been covered in the new addition to the documentation covering Community/Roles and Community/Feedback


Components/Input

ADDED containerStyle prop to Input, which allows custom styling for Input's container
FIXED Other linting errors
FIXED Typo in CONTIRBUTING.md

@palingheorghe Any chances of this getting merged? I literally have had to keep my own fork alive just because of this prop


include model-type in normalizeCreateRecordResponse

I believe I may have found a bug in the serializer normalizeCreateRecordResponse method.
NOTE: I'd consider myself a mid level dev.. I've been working with ember for several years but I haven't done a lot of open source contributing.
Add tests (if applicable)
not sure how to test this w/o adding miragejs or some kind of mock api.
Sign our CLA
Done and done
-->
Description
and
Code sample:
I'm getting an error when creating a record. I believe it's because ember expects a model name as a string in the data passed to the normalizeCreateRecordResponse hook. I'll link some code here:
ember's didSaveRecord is called with the serialized data and that data is passed as dataArg here:
https://github.com/emberjs/data/blob/ad7f28459f5d4e9a3d8a164a69eca4f27b519536/packages/store/addon/-private/system/core-store.ts#L2536
which, if there's data and we're not deleting a record calls cache.updateRecordIdentifier and passes data as the second arg here:
https://github.com/emberjs/data/blob/ad7f28459f5d4e9a3d8a164a69eca4f27b519536/packages/store/addon/-private/system/core-store.ts#L2555
which calls detectMerge here:
https://github.com/emberjs/data/blob/972c811431c9e31764f012b75045b8d63958b546/packages/store/addon/-private/identifiers/cache.ts#L328
which, if we are creating a new record with an existing model calls normalizeModelName and passes data.type here:
https://github.com/emberjs/data/blob/972c811431c9e31764f012b75045b8d63958b546/packages/store/addon/-private/identifiers/cache.ts#L534
data.type is undefined at that point because it's not set in the normalizeCreateRecordResponse
here:
https://github.com/firebase/emberfire/blob/0c7b67fd1fd2922e6969f81d4c1f3e57181f4066/addon/serializers/realtime-database.ts#L31
it winds up erring here as it is passed through as str:
couldn't find this code... must be in a third part lib that gets included in ember source
var DECAMELIZE_CACHE = new _utils.Cache(1000, str => str.replace(STRING_DECAMELIZE_REGEXP, '$1_$2').toLowerCase())

@camnicklaus Thanks for your time, research, and sharing the solution. Hope your fix will be merged soon, until we can override these methods in ApplicationSerializer.
./app/serializers/application.js
import RealtimeDatabaseSerializer from 'emberfire/serializers/realtime-database';

export default class ApplicationSerializer extends RealtimeDatabaseSerializer {

  // eslint-disable-next-line no-unused-vars
  normalizeCreateRecordResponse(_store, _primaryModelClass, payload, id, _requestType) {
    return { data: { id: id || payload.ref.key, attributes: payload.data, type: _primaryModelClass.modelName }};
  }
}

@camnicklaus Thanks for your time, research, and sharing the solution. Hope your fix will be merged soon, until we can override these methods in ApplicationSerializer.
./app/serializers/application.js
import RealtimeDatabaseSerializer from 'emberfire/serializers/realtime-database';

export default class ApplicationSerializer extends RealtimeDatabaseSerializer {

  // eslint-disable-next-line no-unused-vars
  normalizeCreateRecordResponse(_store, _primaryModelClass, payload, id, _requestType) {
    return { data: { id: id || payload.ref.key, attributes: payload.data, type: _primaryModelClass.modelName }};
  }
}

no problem, glad to help.. but actually we should hold on this as I'm still having issues... the ember data store is not updating correctly. not sure why but I suspect it had to do with what is returned even though this adds the model name.
I will try to dig in farther when i get some time

Thanks for digging in on this. Happy to merge once it proves stable. Will do some testing myself come Tuesday.

Can this please be reviewed and merged in :) Currently this addon is in an unusable state for even the simplest usage.

so sorry for the delay... got swamped at work. hoping to find some time to better understand what's happening here in the next week or two 😬

Thanks @camnicklaus! Currently I'm using a modified version of the serializer from above.

@Alonski I'm glad it's working for you.. I was having issues with the update that happens in the ember client store after returning a saved record... don't actually remember exactly what I was seeing but the thought I remember having was that ember was losing it's reference to the record after the network returned it, post update
so I guess just watch out for that?

Thanks again I'll keep my eyes open for that.

What version of ED did this start with?

@knownasilya it would have started around 3.16 when Identifiers landed, we began more strictly enforcing type. It appears in the past that we were not as strict as we should have been for payloads received for an update. The payload needs to be in JSON:API format which means it needs both type and id as members of the primary data object located on the top-level of the response object.
I'd note though that recent fixes will soon make it possible to pass back just the lid instead of type and id if desired, which may be a useful feature to firebase.

I think my recommendations will fix the tests, but I could be mistaken.

@camnicklaus think you could make the recommended changes?

@camnicklaus think you could make the recommended changes?

please feel absolutely free to push any changes you think will help/work. I'm so sorry I haven't had time to revisit this issue! The app I was building with it has been sitting untouched for months. I hope to get back to it at some point but not sure when :(


chore: refactor mouse and keyboard event handlers

mouse and keyboard event handlers should turn events into accepted suggestion items
https://github.com/grafana/influxdb-flux-datasource/blob/master/src/editor/FluxQueryField.tsx#L205

not relevant in 7x


CIDRGroup references metric should count live references only and not count nonexistent CIDRGroups

The cilium_cidrgroup_policies metric counts all references of CIDRGroups inside a CNP even if the CIDRGroup doesn't exist (i.e. reference points to a nonexistent object).

hi, i'm willing to take this, assign please

hi, sorry to bother, I'm new to Cilium, need make some sure about this issue.
in this issue, I need do some works in here:
https://github.com/cilium/cilium/blob/191b672af20feda6e43f52fa1c429f1639cb50fd/pkg/k8s/watchers/cilium_network_policy.go#L257
to make sure that in this function, the empty rule.CIDRGroupRef needs to be skipped,
https://github.com/cilium/cilium/blob/191b672af20feda6e43f52fa1c429f1639cb50fd/pkg/k8s/watchers/cilium_cidr_group.go#L187-L194
so the final implementation will be something like:
		if len(rule.Cidr) == 0 {
			if len(rule.CIDRGroupRef) == 0 {
				cidrGroupRefs = append(cidrGroupRefs, string(rule.CIDRGroupRef))
			}
		}

I believe this can be closed?


Add year in license

Current license text: https://github.com/NIRALUser/NeuroRuler/blob/35c41ba52c4c1aef41c88eb5b00d01a26cd98a7e/LICENSE#L3
According to OSI and SPDX, MIT license should have <year> and <copyright holders>, but we don't have <year> in it.

840e89b


Some changes

Bug #20 fixed
Allow to search multiple keywords, see #18

I hope this helps :)

sorry, I made a typo on a commit description

new deps:

promise (this probably will be necessary when using ES6)

promise (this probably will be unnecessary when using ES6)

validator

Looks great! By the way try to use git rebase next time to fix "bad" commit descriptions. Also I think it will be good if we fix/squash commits into 1 when submit a pull request since this way it is easier to roll back if something went wrong. But I'm going to merge it anyway.

Ok. I will be more careful next time and will be waiting for more updates and see in what else can I contribute :)

@carloscarcamo I merged my changes which move this project to webpack and ES6 (latest JavaScript). I think my next step is to move it to Redux from Flux but it should not effect things much at this point. Are you still interested in contributing? I have a list of things I can assign to you - some of them should be simple (I hope).

I very interested in contributing, you can assign me some task and I will try to help :)
By the way, I would like to know from where or how do you get the Tweets database, is there any project which collect those tweets?

@anvk I'm very interested in contributing, you can assign me some tasks and I will try to help :)
By the way, I would like to know from where or how do you get the Tweets database, is there any project which collect those tweets?

@carloscarcamo here is a tiny issue if you want to help https://github.com/JaredHawkins/TweetGeoViz/issues/50
Also you can try to build the page on your computer and let me know if it worked for you.
I was thinking to have a meeting next week in Slack to discuss our next step for the project development. Are you interested to join?
To answer your question: just like it is mentioned in the README file, this tweets sample is courtesy of HealthMap. @JaredHawkins who is the brain behind this project has access to HealthMap tweets, so he managed to get a sample set we can work with. But in theory you could create the data set yourself using any data from any sources you have.

@anvk, yes I'm interested to join in the Slack discussion, just tell me the day and hour :)
I asked about the tweets db because, we would like to use this project in another one to collect information about the use of open source projects around the world.

Hi all,
My apologies on the delay - I have been out of town at a conference and have had limited email access.
So glad this project is moving along.  Thanks for your interest Carlos!  I would be happy to chat.  I can be available asynchronously on Slack this week, but if you want a dedicated time next week will be better.
As for the Tweets, I run about a dozen or so research projects using Twitter data here @ Boston Children’s Hospital.  Everything is obtained via the free public API.  The Tweets in this sample database are explicitly for this Mozilla project, however, and should not be used/referenced in any other projects.
Thanks!
-Jared

On Jan 6, 2016, at 7:11 PM, Carlos Cárcamo<EMAIL_ADDRESS>wrote:
I very interested in contributing, you can assign me some task and I will try to help :)
By the way, I would like to know from where or how do you get the Tweets database, is there any project which collect those tweets?
—
Reply to this email directly or view it on GitHub https://github.com/JaredHawkins/TweetGeoViz/pull/43#issuecomment-169505194.

@JaredHawkins
no problem. Right now we have a plan to iron out some of the known bugs and add newest tech to the project before we move along with new features. I think that next week will be better for me as well. If @carloscarcamo is avail too we can chat next week about our next steps.

I think I will have time, just tell me the day and hour...


PBI Desktop - Error HTTP/500: Internal Server Error

Bravo is unable to open a PBIX on desktop. Receive an internal server error message.
Error HTTP/500: Internal Server Error.
Object reference not set to an instance of an object.
Trace Id: 00-5b79c90ceeb88b4bb58e34f0ddb4e53a-211b843988072b43-00
Version: 0.9.0 (0.9.8121.26944)

Thanks for reporting this. I'm closing this issue as a duplicate of #213.

Fixed in 0.9.1


feat: Add ecommerce mock api

Adds ecommerce cart mock endpoint.
Calculates coupon, tax & postage amounts into subtotal to get cart total price.
Closes #62

Hi @alexjharrison
This is fantastic work. Before I merge there is two little changes if possible.

In app.ts there we import the route files, can you add your routes file as an import please.
Do you know how to update the swagger file to include your endpoints, if so can you update this file as well.

Hey @ageddesi
Does this count as importing the router file?
https://github.com/ageddesi/Mocked-API/pull/74/files#diff-84dd6a83459413d5bb638cd885f20ef0dbebf2ebf10d0f35d1c9ca424b0ca06aR15
Also, I'm not sure how to update the swagger api using any tooling short of just writing it into to the swagger.json file manually.  If that's how to do it I can get that in. Just was curious if there's a shortcut.

@all-contributors please add @alexjharrison  for code
Thank you @alexjharrison for your contribution to the codebase. Happy Hacktoberfest


[python] tests for plot tree functions and module_INSTALLED variables

Added tests for plotting tree functions and moved all checks of installed modules to compat.py.
Refer to #261.

I can review in 3 days.


[Docs] Add example to demonstrate how to use skinning and morph with custom vertex shaders

How can Bevy's documentation be improved?
I was writing a custom shader for an animated model. It continued to throw errors about the VERTEX[5] input buffer. After intense searching I discovered a vertex shader file in a community project, which offers some help: https://github.com/komadori/bevy_mod_outline/blob/master/src/outline.wgsl
After reading it I went to realize that bevy attempts to store the data about animation at position 5, which is not defined in my custom vertex shader.
An example about how to leverage animation data and morph target data in custom vertex shaders should be added. It should be noted that the skinning system uses position 5 and 6 as the joint buffer. The example should further demonstrate the way to handle skinning and morphing in vertex shader.

This won't be necessary any more if #7502 is implemented and similar support for morph targets are added.  😄


feat: Add parser support for Rust unit test generation

feat: Add parser support for Rust unit test generation
Overview
This pull request introduces support for parsing Rust code to extract relevant information for unit test generation.
Changes

Key Changes:

Added a new RustParser class to the parsers module.
Updated the unit_test.py file to include Rust as a supported language.

New Features:

The RustParser can now extract the following constructs from Rust code:

Module
Struct
Function
Impl block
Enum

Refactoring:

No significant refactoring changes were made.

✨ Generated with love by Kaizen ❤

Original Description
Changelog:
- Added code for parsing and extracting definitions from Rust code
- The `RustParser` class extracts the following constructs:
        -  `Module`
        - `Struct`
        - `Function`
        - `Impl` block
        - `Enum`
Please let me know if anything more needs to be added

Hey @MashyBasker, thanks for this pr, It looks great!
Merging it; I do have another thing you might be able to help with. We want to execute these unit tests and would like to incorporate that functionality for Kaizen!

@MashyBasker can you fix the linting issues? we will add some feature so that this check happen early!

Sure @sauravpanda, I'll start working on the test execution feature.
I've added a commit to address the linting issue in my previous commit.


Use with Diffusers pipeline?

Hey. I tried this thing and it works fine. I even made a Docker image for this
My question is how to do the same export for pure Diffusers? I tried with optimum :
onnx_pipeline = ORTStableDiffusionPipeline.from_pretrained(onnx_model_id, export=True)
onnx_pipeline.save_pretrained("onnx-model")

It worked, but the speed slowed down by few times (i did not forget to move to CUDA), whereas with your method the inference is faster.
So I was wondering how could I combine the speed of your TensorRT export method with a lightweightness of Diffusers...
Could you help please?

If you're interested in building your own pipeline based on diffusers I would highly recommend checking out: https://github.com/NVIDIA/TensorRT/tree/release/9.2/demo/Diffusion
This is also what has been used as the baseline for this extension and is maintained well.

@contentis wow, thank you very much


Regarding the currently not available of MicrosoftDefenderForEndpoint in Virtual Network tags

Regarding the currently not available of MicrosoftDefenderForEndpoint in Virtual Network tags.
Some of my customers are asking the release notification of the above in Azure.
Can it be shown in this place?
https://azure.microsoft.com/en-us/updates/
Or customers have to manually refresh this doc to see the release?
Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 08217244-82bb-13b5-46f7-454801d8f865
Version Independent ID: 4a8b0a32-bf57-7544-c60d-6b7f250c4477
Content: Azure service tags overview
Content Source: articles/virtual-network/service-tags-overview.md
Service: virtual-network
GitHub Login: @asudbring
Microsoft Alias: allensu

@Paul-Lo Thanks for your feedback.
I don't think service tags update will be available in Azure Updates Blog.
Once the service tag is generally available, we shall update this document to reflect it.

@Paul-Lo we shall close this thread as there are no active discussions going on. Should you have any follow-up query, please tag me and we shall reopen the issue and work with you


Update ready for release v3.1.0

Overview/Summary
This PR updates the module in preparation for release v3.1.0, including updates to examples and other references relating to the current release.
This PR fixes/adds/changes/removes
n/a
Breaking Changes
n/a
Testing Evidence
n/a
As part of this Pull Request I have

[x] Checked for duplicate Pull Requests
[x] Associated it with relevant issues, for tracking and closure.
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[x] Performed testing and provided evidence.
[x] Updated relevant and associated documentation.
[x] Updated the "RELEASE" page with details needed for when this code change is released.

Lol - linter being too clever :)

/azp run unit

/azp run update

/azp run e2e


Clean up all direct calls to the facade in root.

The preferred way of calling facades is using the fully namespaced facade, not the root namespaced one. Clean up the code to match this best practice.

No longer valid in 3.x


Allowing two tags to have the same value

The following change would remove the check that's preventing two tags from having the same value (as described at https://github.com/kenguest/Services_Openstreetmap/issues/14 )

This then doesn't explain why the following works, could you provide sample [node] values and code that proves that the issue your pull request solves, is an actual RL problem please?...
$ php example3_genericdemo.php
/home/kguest/dev/code/Services_Openstreetmap/examples/example3_genericdemo.php:28:
array(5) {
'barrier' =>
string(9) "lift_gate"
'bicycle' =>
string(3) "yes"
'foot' =>
string(3) "yes"
'motorcar' =>
string(3) "yes"
'motorcycle' =>
string(3) "yes"
}
/home/kguest/dev/code/Services_Openstreetmap/examples/example3_genericdemo.php:30:
array(6) {
'barrier' =>
string(9) "lift_gate"
'bicycle' =>
string(3) "yes"
'foot' =>
string(3) "yes"
'motorcar' =>
string(3) "yes"
'motorcycle' =>
string(3) "yes"
'horse' =>
string(3) "yes"
}
$ cat example3_genericdemo.php

 * @license  BSD http://www.opensource.org/licenses/bsd-license.php
 * @version  CVS:
 * @link     osmx.php
 */

$version = '@package_version@';
if (strstr($version, 'package_version')) {
    set_include_path(
        dirname(dirname(__FILE__)) . PATH_SEPARATOR . get_include_path()
    );
}

require_once 'Services/OpenStreetMap.php';

$osm = new Services_OpenStreetMap();

$node = $osm->getNode(401839334);
var_dump($node->getTags());
$node->setTag('horse', 'yes');
var_dump($node->getTags());

Please provide sample code that proves the flaw that your pull request addresses does actually happen - I still can't reproduce it. See below:
$ php test.php
/home/kguest/dev/code/Services_Openstreetmap/examples/test.php:28:
array(5) {
  'barrier' =>
  string(9) "lift_gate"
  'bicycle' =>
  string(3) "yes"
  'foot' =>
  string(3) "yes"
  'motorcar' =>
  string(3) "yes"
  'motorcycle' =>
  string(3) "yes"
}
/home/kguest/dev/code/Services_Openstreetmap/examples/test.php:30:
array(6) {
  'barrier' =>
  string(9) "lift_gate"
  'bicycle' =>
  string(3) "yes"
  'foot' =>
  string(3) "yes"
  'motorcar' =>
  string(3) "yes"
  'motorcycle' =>
  string(3) "yes"
  'horse' =>
  string(3) "yes"
}
$ cat test.php
<?php
$version = '@package_version@';
if (strstr($version, 'package_version')) {
    set_include_path(
        dirname(dirname(__FILE__)) . PATH_SEPARATOR . get_include_path()
    );
}

require_once 'Services/OpenStreetMap.php';

$osm = new Services_OpenStreetMap();

$node = $osm->getNode(401839334);
var_dump($node->getTags());
$node->setTag('horse', 'yes');
var_dump($node->getTags());

Closing, given the conflicts and no feedback


Don't create View instances for each request

View.as_view creates a function that instantiates the class every request. This seems inefficient for no real gain.
class DeleteView(View):
    methods = ['DELETE']

    # this only needs to happen once
    def __init__(self, model):
        self.model = model
        # imagine if we did something expensive here
        # like generating a form based on the model

The only argument I could think of for instantiating every request is if the constructor does something different based on the request. That seems like bad design, but any use that I can think of for that could be accomplished with properties instead.
Yes, there are ways to make it less expensive, like generating more ahead of time and passing more arguments, but that is not intuitive, and makes the class just a more complicated view factory.

I don't see how this can safely be changed without risking to break people's code if they store stuff on self e.g. because they call other methods in the same class and pass some thing via attributes instead of arguments.
Besides that, instantiating a class is quite cheap...

It's not cheap if you do something expensive in the constructor, which until I dug into the implementation was my intuition of how to use them.

Storing things on self from the views is equivalent to storing globals, which would break for the usual reasons.

only if an instance is reused for more than one request. as long as the instance is request-scoped, storing stuff on self is like setting a local variable in a normal view function

Ah, I see. I wonder how common that is? Or at least how many are written in such a way that they would break with a single instance.

Maybe add a every_request=True variable, and issue a deprecation warning that it will change to False in the future.

If we add this I would rather go for this thing to always be configurable or even better add a SingletonView base class that is instantiated once. Like this you can pick what suits you more instead of having

I'll have to think on how we could do SingletonView without copying the View.as_view code, which would be harder to maintain. But I'm ok with it in principal, assuming we change the docs to push it as the normal choice and View as a more advanced choice.

g is something to use across the code (e.g. for stuff like the current user). Putting application data into g that is used within a single class seems pretty ugly to me.

@davidism

I'll have to think on how we could do SingletonView without copying the View.as_view code, which would be harder to maintain. But I'm ok with it in principal, assuming we change the docs to push it as the normal choice and View as a more advanced choice.

I'd be okay with this, as View allows you to do stuff like request based DI into a view (e.g. make this instance if X otherwise make that one), plus self is cheap storage if the view class has multiple methods.
This call here can be modified in the SingletonView to create the instance and store the reference onto the class, something like:
class SingletonView(View):
    instances = {}

    @classmethod
    def as_view(cls, name, *class_args, **cls_kwargs):
        view = super().as_view(cls, name, *class_args, **kwargs)

        def singleton_view(*cls_args, **cls_kwargs):
            view_inst = cls.instances.get(name)
             if not view_inst:
                 view_inst = cls.instances[name] = cls(*cls_args, **cls_kwargs)
             return view_inst

        view.view_cls = singleton_view

That's just a rough draft idea, but something along those lines would not create a new instance for each request and allow the view class to be created for multiple end points.

What about object pooling?
This way no such code change will be required to benefit from such an improvement.

You'll need to explain what you mean.

This was done intentionally because people can stuff state on self between functions. It matches the behavior in Django.

@davidism thing is that I have used the fact that self is fresh from request to request myself plenty of times. The allocation of the class instance is insignificant compared to what else happens on request dispatching.

Changing this now will break a lot of code since this is also explicitly documented behavior:

The way this works is that whenever the request is dispatched a new instance of the class is created and the dispatch_request() method is called with the parameters from the URL rule.

@mitsuhiko would you be ok with a new SingletonView subclass?

@davidism i could imagine a lifetime attribute on the view that the generic as_view function internally references. It could be 'request' which means it lives for the single request only, 'application' which binds it to the application instance or 'global' which makes it an actual singleton that then cannot have state.
Generally the only values I think make sense are 'request' and 'application' though.


tests: kernel: timer behavior tick alignment on the first timer

In the testcase we're missing a tick alignment on the first timer. So with this change, Just before starting the test case, the first scheduled timer is aligned to the tick to avoid the one timeout occurring shorter than the rest.
As recommended to fix https://github.com/zephyrproject-rtos/zephyr/issues/57285
thanks to @teburd

Please check the linked issues to see if this fixes all of them @hakehuang @FRASTM

This problem has been already fixed by https://github.com/zephyrproject-rtos/zephyr/pull/63210 (and that's why there is a merge conflict here now).

This problem has already been fixed by #63210 (and that's why there is a merge conflict here now).

@FRASTM can you please check if this is fixed already in your case and close this PR?

Why wasn't this one merged prior to the other one given this solved the problem a week ago? Confusing. I didn't even get a chance to look at the other one as a timer collaborator.

Closing this PR and issues
https://github.com/zephyrproject-rtos/zephyr/issues/57285
https://github.com/zephyrproject-rtos/zephyr/issues/57288
--> fixed by https://github.com/zephyrproject-rtos/zephyr/pull/63210   (already merged)


polymer-build remove comments

Currently the polymer build tool leaves all comments in. If the user specifies js: minify, I believe comments should be removed. This could be achieved here:
https://github.com/Polymer/tools/blob/1fe1c22bfb81ad9195c99fa31ac24c675d15700c/packages/build/src/js-transform.ts#L286
by passing {presets, plugins, comments: false}

"minify"

Even supplying bundle.stripComments on polymer.json doesn't actually strip comments away, at least on Polymer 1.0 projects. It's driving me nuts.


Some minor fixes in tilemap rendering and changes to RectInt

RectInt previously didn't have the intersecting and contains functions, which it does now. Tilemap rendering used to crash past a certain bound and not properly cull tiles outside the screen rect, which it does now.

Since no one is using this branch yet and the changes can be undone I'm going to merge this for now.


FileNotFoundError in newest release

Current State
Getting the following error in my virtualenv when trying to create a random address with dad_tool.random_address. Uninstalling and reinstalling the dad_tool package seems to result in the same error.
FileNotFoundError: [Errno 2] No such file or directory: '/Users/smarston/.local/share/virtualenvs/python-oWvDs7ZO/lib/python3.9/site-packages/dad_tool/dad/src/addresses/united-states/ut-addresses.min.json'

I've viewed the site-packages/dad_tool folder on my machine and it seems I do not have site-packages/dad_tool/dad.

Expected State
Package should install the dad submodule to prevent the error

Found the culprit, the command to initialize the submodule was removed when switching from Makefile to Justfile in the releasing process so it never gets included.
This is fixed in https://github.com/Justintime50/dad-python/commit/bb6f68baece2f1294058eab6929165f873175ba5


Build failure: appstream cross

Steps To Reproduce
from nixpkgs repo, on master branch: nix build .#pkgsCross.aarch64-multiplatform.appstream
Build log
https://gist.github.com/danielbarter/8bc524d3154ff46a1f97584e7cb3eb6d
Relevant part is
Message: Native appstream required for cross-building
Additional context
This should be relatively easy to fix, but I am not sure how to refer to the native version in the context of the function, without creating infinite recursion
Notify maintainers
Add a :+1: reaction to issues you find important.

https://github.com/NixOS/nixpkgs/pull/305241 maybe fix this

We should keep open before https://github.com/NixOS/nixpkgs/pull/305241 merged


Some improvements to the simulator run step

This PR makes several improvements to the simulation run step:
Summary:

Add ANSIBLE_STDOUT_CALLBACK=yaml to make user-friendly the output of the simulator (simulation result)
Remove the last step of the aether-onramp/deps/gnbsim/roles/simulator/tasks/start.yml because it will always fail. The gnbsim process will finish/end by itself as soon as the simulation completes so, the last step will always result in error because the process no longer exists
An additional improvement is about what output to print such that the user can easily see whether the simulation successfully completed or not and this is achieved by removing irrelevant information/output (i.e., remove category=Summary component=GNBSIM
Print output in green (as default in Ansible) when the simulation successfully completes and print the output in red when the simulation fails

Details
1. Add ANSIBLE_STDOUT_CALLBACK=yaml to make user-friendly the output of the simulator (simulation result).
Before:
TASK [simulator : debug] ***********************************************************************************************
ok: [node1] => {
    "gNbsimPod.stdout_lines": [
        "time=\"2024-09-13T17:56:28Z\" level=info msg=\"Profile Name: profile1 , Profile Type: register\" category=Summary component=GNBSIM",
        "time=\"2024-09-13T17:56:28Z\" level=info msg=\"Ue's Passed: 5 , Ue's Failed: 0\" category=Summary component=GNBSIM",
        "time=\"2024-09-13T17:56:28Z\" level=info msg=\"Profile Status: PASS\" category=Summary component=GNBSIM"
    ]
}

Now:
TASK [simulator : debug] ***********************************************************************************************
ok: [node1] =>
  gNbsimPod.stdout_lines:
  - 'time="2024-09-13T17:42:23Z" level=info msg="Profile Name: profile1 , Profile Type: register" category=Summary component=GNBSIM'
  - 'time="2024-09-13T17:42:23Z" level=info msg="Ue''s Passed: 5 , Ue''s Failed: 0" category=Summary component=GNBSIM'
  - 'time="2024-09-13T17:42:23Z" level=info msg="Profile Status: PASS" category=Summary component=GNBSIM'

2. Remove the last step of the roles/simulator/tasks/start.yml because it will always fail. The gnbsim process will finish/end by itself as soon as the simulation completes so, the last step will always result in error because the process no longer exists
Before:
TASK [simulator : force stop gnbsim] ***********************************************************************************
fatal: [node1]: FAILED! => {"changed": true, "cmd": "pkill -9 -f /gnbsim/bin/gnbsim\n", "delta": "0:00:00.044992", "end": "2024-09-13 10:56:40.856013", "msg": "non-zero return code", "rc": -9, "start": "2024-09-13 10:56:40.811021", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}
...ignoring

Now:
There is no error :-)

3. An additional improvement is about what output to print such that the user can easily see whether the simulation successfully completed or not and this is achieved by removing irrelevant information/output (i.e., remove category=Summary component=GNBSIM.
Before (after item 1. above is accepted/merged):
TASK [simulator : debug] ***********************************************************************************************
ok: [node1] =>
  gNbsimPod.stdout_lines:
  - 'time="2024-09-13T19:07:53Z" level=info msg="Profile Name: profile1 , Profile Type: register" category=Summary component=GNBSIM'
  - 'time="2024-09-13T19:07:53Z" level=info msg="Ue''s Passed: 5 , Ue''s Failed: 0" category=Summary component=GNBSIM'
  - 'time="2024-09-13T19:07:53Z" level=info msg="Profile Status: PASS" category=Summary component=GNBSIM'

Now:
TASK [simulator : debug] ***********************************************************************************************
ok: [node1] =>
  msg:
  - 'time="2024-09-13T19:01:10Z" level=info msg="Profile Name: profile1 , Profile Type: register"'
  - 'time="2024-09-13T19:01:10Z" level=info msg="Ue''s Passed: 5 , Ue''s Failed: 0"'
  - 'time="2024-09-13T19:01:10Z" level=info msg="Profile Status: PASS"'

4. Print output in green (as default in Ansible) when the simulation successfully completes and print the output in red when the simulation fails
When simulation successfully completes (green)

When simulation fails (red)

@llpeterson @mbilal92 please review this PR. Thanks!

LGTM. I want to make sure it also works with the integration tests that run on Jenkins -- and make SUCCESS/FAILURE decisions based on the output they see -- but based on a cursory look, it should. (We can always change the Jenkins jobs, if necessary, so this is not a blocker.)

Jenkins is happy. So am I.


Color in tables

Hi! I'm making a table, and I'd like to put a background color on it, but when I upload it to GitHub I can't see the color.
I used the following code:
|===
|Slack
{set:cellbgcolor:blue}
|===

This converter does not supported named colors. You must use a hex value instead, such as {set:cellbgcolor:#0000FF}.

I used the code, but no color appeared in GitHub.

This converter does not supported named colors. You must use a hex value instead, such as {set:cellbgcolor:#0000FF}.

I used the code, but no color appeared in GitHub.

I don't know what you mean by "no color appeared on GitHub". Could you be more specific? Are you saying the PDF doesn't display properly on GitHub? Can you point to an example?

My question is: What if I view an adoc file in GitHub do I see the colors or does it have to be in PDF format to see the colors?

I don't know what you mean by "no color appeared on GitHub". Could you be more specific? Are you saying the PDF doesn't display properly on GitHub? Can you point to an example?

We have no control over how an AsciiDoc file is displayed on GitHub. It's going to display with whatever generic styles GitHub applies to documents. This has nothing to do with PDF or this converter. If you want to see the file rendered as a PDF on GitHub, then you can add the PDF to the repository.


Cellery hub details page of the cell image title should be changed to /:

Currently the title and version is separated with '-'. Eg: wso2cellery/pet-be-zero-scale-cell - latest
But generally in the syntax, and cellery commands we use wso2cellery/pet-be-zero-scale-cell:latest which is separated by ':'. Therefore, it will be better to adjust the title of that page accordingly to be consistent.

Fixed with https://github.com/wso2-cellery/cellery-hub/pull/96/commits/7c8357c1579e2d74d7486301262d38476199bfb4


cc-wrapper: Fix standalone gcc

This refactors changes to add-flags.sh introduced in #27672 to ensure that all salted variables are defined even if the wrapped program is invoked outside nix-build environment to address https://github.com/NixOS/nixpkgs/pull/27672#issuecomment-320763781 .
This pull request incorporates #28012 .
Currently I'm testing if this can build kdeFrameworks.kidletime on Linux.

Please don't merge yet.. this won't fix it btw.. but no idea what the issue is..

@globin Have you tested with the latest commit that fixed ld? My current build in progress has advanced far beyond building llvm.

I have just built kdeFrameworks.kidletime with this pull request.

doesn't build: https://hydra.mayflower.de/log/lfx45ymp527msaaxz8w0ib9yic61d5fh-qjackctl-0.4.5.drv

I do not understand this fully yet, but this failure is caused by https://github.com/NixOS/nixpkgs/pull/27657#issuecomment-318161946 . I assumed that files used from /nix/store during compilation do not disappear after compilation, but this is not the case when building qt5.qttools: it seems that there is /nix/store/…-qttools-5.9.1/lib/libQt5Xml.so during compilation, so ld-wrapper is content to add an rpath for qttools without adding an rpath for qtbase, then this symlink disappears, and finally patchelf --shrink-rpath deletes now useless rpath for qttools…

Currently (at least when qt5.qttools is already built) nix-shell '<nixpkgs>' -A qt5.qttools fails with mkdir: cannot create directory ‘/nix/store/…-qttools-…/bin’: Read-only file system here. If this could be fixed by not using /nix/store for temporary files (deleted here), this will also fix building qjackctl.
Nevertheless, should I revert the aforementioned change (https://github.com/NixOS/nixpkgs/pull/27657#issuecomment-318161946), or shall we fulfill its assumption that used libraries are not deleted from /nix/store, or both?


Plan cross-team meetings

@SWE574-Fall2023-Group1/all We need every team to hold their final meetings and document them on the wiki. (It's okay if you just create a page for the notes, I can handle the sidebar and wiki integration)
Also we need each team to present a brief overview of their work to the remaining members, both for clarification and exam preparation. We could also note things down on the wiki later on.
Due Date: Final Milestone Submission

Thanks to @ckertam for the backend and devops presentations 🙏 Now we only need to present the mobile and frontend teams' work.

Meetings are over, closing issue. Thanks everyone! 😄


Pin trim-newlines sub-dependency

Resolve GitHub Advisory

Didn't work the way I hoped it would (still produces advisory warnings for the consuming package). Closing.


moveto deletes file when trying to do a case-sensitive rename.

What is the problem you are having with rclone?
When using the moveto command to rename the file by changing it's case, the file gets deleted instead of renamed in some environments.
What is your rclone version (output from rclone version)
v1.46.0-112-g1c301f9f-beta
Which OS you are using and how many bits (eg Windows 7, 64 bit)
Windows 7, 64 bit
Which cloud storage system are you using? (eg Google Drive)
Windows Local, Jottacloud
The command you were trying to run (eg rclone copy /tmp remote:tmp)
rclone moveto R:\test.bin R:\TEST.bin
A log from the command with the -vv flag (eg output from rclone -vv copy /tmp remote:tmp)
2019/04/08 19:02:14 DEBUG : rclone: Version "v1.46.0-112-g1c301f9f-beta" starting with parameters ["[...]\\rclone.exe" "moveto" "R:\\test.bin" "R:\\TEST.bin" "-vv"]
2019/04/08 19:02:14 DEBUG : Using config file from "[...]\\rclone.conf"
2019/04/08 19:02:14 DEBUG : test.bin: Size and modification time the same (differ by 0s, within tolerance 100ns)
2019/04/08 19:02:14 DEBUG : test.bin: Unchanged skipping
2019/04/08 19:02:14 INFO  : test.bin: Deleted
2019/04/08 19:02:14 INFO  :
Transferred:            0 / 0 Bytes, -, 0 Bytes/s, ETA -
Errors:                 0
Checks:                 2 / 2, 100%
Transferred:            0 / 0, -
Elapsed time:       200ms

2019/04/08 19:02:14 DEBUG : 2 go routines active

Thanks for reporting this - I've verified the problem.
This needs a bit of extra logic to detect if the source and destination files are the same in a case insensitive way (if the fs supports it) and not do the delete here.
https://github.com/ncw/rclone/blob/1c301f9f7ab8bf00d04331acc26b5195820ed1cf/fs/operations/operations.go#L400-L407

I'm assuming this will be just a matter of checking if the remote is case insensitive then check if the name is the same in a case insensitive way. I'll make a pull request.


RuntimeError: Error building extension 'evoformer_attn'

Hello, there! I am trying to implement the multimer module of OpenFold by using pre-computed MSAs. As a proof of concept, I am using the protein provided as an example in the tutorial, as well as its corresponding MSA. At the beginning, the MSA are apparently detected, since the output states:
INFO:/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/utils/script_utils.py:Successfully loaded JAX parameters at openfold/resources/params/params_model_1_multimer_v3.npz...
INFO:/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/run_pretrained_openfold.py:Using precomputed alignments for 6KWC at /nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/All_positives/msas...
INFO:/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/run_pretrained_openfold.py:Using precomputed alignments for 6KWC at /nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/All_positives/msas...
INFO:/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/run_pretrained_openfold.py:Using precomputed alignments for 6KWC at /nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/All_positives/msas...
INFO:/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/run_pretrained_openfold.py:Using precomputed alignments for 6KWC at /nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/All_positives/msas...
INFO:/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/utils/script_utils.py:Running inference for 6KWC-6KWC-6KWC-6KWC...

I think that the issue starts here:
Using /homes/agustin/.cache/torch_extensions/py310_cu121 as PyTorch extensions root...
Detected CUDA files, patching ldflags
Emitting ninja build file /homes/agustin/.cache/torch_extensions/py310_cu121/evoformer_attn/build.ninja...
/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py:1967: UserWarning: TORCH_CUDA_ARCH_LIST is not set, all archs for visible cards are included for compilation.
If this is not desired, please set os.environ['TORCH_CUDA_ARCH_LIST'].
  warnings.warn(
Building extension module evoformer_attn...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
Traceback (most recent call last):
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 2107, in _run_ninja_build
    subprocess.run(
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/subprocess.py", line 526, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

And the final error is:
The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/run_pretrained_openfold.py", line 493, in <module>
    main(args)
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/run_pretrained_openfold.py", line 334, in main
    out = run_model(model, processed_feature_dict, tag, args.output_dir)
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/utils/script_utils.py", line 160, in run_model
    out = model(batch)
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/model.py", line 568, in forward
    outputs, m_1_prev, z_prev, x_prev, early_stop = self.iteration(
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/model.py", line 325, in iteration
    template_embeds = self.embed_templates(
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/model.py", line 142, in embed_templates
    template_embeds = self.template_embedder(
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/embedders.py", line 969, in forward
    t = self.template_pair_stack(
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/template.py", line 461, in forward
    t, = checkpoint_blocks(
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/utils/checkpointing.py", line 85, in checkpoint_blocks
    return exec(blocks, args)
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/utils/checkpointing.py", line 72, in exec
    a = wrap(block(*a))
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/template.py", line 308, in forward
    single = self.tri_att_start_end(single=self.tri_mul_out_in(single=single,
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/template.py", line 223, in tri_att_start_end
    self.tri_att_start(
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/triangular_attention.py", line 131, in forward
    x = self._chunk(
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/triangular_attention.py", line 77, in _chunk
    return chunk_layer(
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/utils/chunk_utils.py", line 299, in chunk_layer
    output_chunk = layer(**chunks)
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
    return forward_call(*args, **kwargs)
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/primitives.py", line 531, in forward
    o = _deepspeed_evo_attn(q, k, v, biases)
  File "/nfs/research/agb/research/agustin/2024/Mycoplasma_pneumoniae_proteome/OpenFold/openfold/openfold/model/primitives.py", line 692, in _deepspeed_evo_attn
    o = DS4Sci_EvoformerAttention(q.to(dtype=torch.bfloat16),
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/deepspeed/ops/deepspeed4science/evoformer_attn.py", line 106, in DS4Sci_EvoformerAttention
    return EvoformerFusedAttention.apply(Q, K, V, biases[0], biases[1])
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/autograd/function.py", line 598, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/deepspeed/ops/deepspeed4science/evoformer_attn.py", line 71, in forward
    o, lse = _attention(q, k, v, bias1_, bias2_)
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/deepspeed/ops/deepspeed4science/evoformer_attn.py", line 24, in _attention
    kernel_ = EvoformerAttnBuilder().load()
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/deepspeed/ops/op_builder/builder.py", line 480, in load
    return self.jit_load(verbose)
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/deepspeed/ops/op_builder/builder.py", line 524, in jit_load
    op_module = load(name=self.name,
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1309, in load
    return _jit_compile(
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1719, in _jit_compile
    _write_ninja_file_and_build_library(
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 1832, in _write_ninja_file_and_build_library
    _run_ninja_build(
  File "/nfs/research/agb/research/agustin/software/localcolabfold/colabfold-conda/lib/python3.10/site-packages/torch/utils/cpp_extension.py", line 2123, in _run_ninja_build
    raise RuntimeError(message) from e
**RuntimeError: Error building extension 'evoformer_attn'**

What can it be? I installed OpenFold according to the tutorial.

Dear all,
I solved the issue. It was related with the cuda and/or cudann libraries I was loading. At the beginning, I was loading these two ones:
module load cuda/11.8.0
module load cudnn/<IP_ADDRESS>-11.8

However, the issue get solved when I also loaded these other three modules:
module load cudnn-<IP_ADDRESS>-11.1-gcc-9.3.0-bbr3kjv
module load ant-1.10.0-gcc-9.3.0-xzxbcc6
module load gcc/11.2.0

Dear all,
I solved the issue. It was related with the cuda and/or cudann libraries I was loading. At the beginning, I was loading these two ones:
module load cuda/11.8.0
module load cudnn/<IP_ADDRESS>-11.8

However, the issue get solved when I also loaded these other three modules:
module load cudnn-<IP_ADDRESS>-11.1-gcc-9.3.0-bbr3kjv
module load ant-1.10.0-gcc-9.3.0-xzxbcc6
module load gcc/11.2.0


Terminal: Cannot rename task terminal

testing #31784
ubuntu 16.04
Version 1.15.0-insider
Commit f39385b8326671dc6389f21f8c2e2f6afdb352a1
Date 2017-08-01T05:10:12.703Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0
Architecture x64
Start a task that runs in a terminal
cmd+p then Terminal: switch active terminal
Hover over the terminal that has a task
Click on the gear
result: nothing happens
I would expect to be able to rename it since it shows up in the list and I can rename the others.

I think this is related to this https://github.com/Microsoft/vscode/issues/31859 .

Fixed by https://github.com/Microsoft/vscode/pull/31865


[trainer] fix missing test failures and improve junit format

duplicate of #20105
original PR description
——-
Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
Bringing changes from https://github.com/fastlane-community/trainer/pull/40 by @robnadin and improving the junit format.
This is from the original PR:

Fix xcpretty_naming for xcresult
Add test result object hierarchy
Refactored group and name parsing function

These fixes came about due to the way the test result format has changed between Xcode 10 and 11, and how the logic to parse xcresult bundles in Trainer was not finding any of our failing tests.
In our use case, we were finding that test failures were not being parsed correctly because we were grouping our tests from a collection of other test suites like so:
class AllTests: XCTestCase {

    override class var testCaseClasses: [XCTestCase.Type] {
        return [
            TestsA.self,
            TestsB.self,
            TestsC.self,
        ]
    }

    override class var defaultTestSuite: XCTestSuite {
        let testSuite = XCTestSuite(forTestCaseClass: self)
        let testCases = testCaseClasses.flatMap { testCaseClass in
            testCaseClass.testInvocations.map { testCaseClass.init(invocation: $0) }
        }
        testCases.forEach(testSuite.addTest)
        return testSuite
    }
}

...

class TestsA: XCTestCase {

    func testFoo() {
        XCTAssertTrue(false)
    }
}

This results in find_failure incorrectly comparing AllTests/testFoo to TestsA/testFoo and returning false due to the identifier and sanitized_test_case_name values not matching in the test metadata.
Instead we should call xcresulttool get --format json and pass it the id we get from the summary reference in the metadata to get an accurate representation of the test failure summary. The benefit of this approach is that we also get explicit file name and line number information that we are able to format in exactly the same way as Trainer has been doing with the older test_result bundles in Xcode 10 and earlier.

Description
In addition to the changes from the PR described above, I updated the junit template because the current template produces a file name within the failure message which, isn't using the correct convention of how a file path and line number should be defined in junit format and therefore breaks our reporting on GitHub CI to report on the correct line number.
Testing Steps
Run trainer against an xcresult file with failures and expect the correct file and line numbers reported. These numbers should match what is seen in Xcode if you open the xcresult in Xcode directly as shown below for the test file.

@joshdholtz is there anything I can do to help move this along?

Is there any planned movement on this?
Based on my own missing test failure issue I ended up opening https://github.com/fastlane/fastlane/pull/21565, which is a much less ambitious fix

It seems that @joshdholtz found some issues with this PR last time we merged it: https://github.com/fastlane/fastlane/pull/20105#issuecomment-1094370238
Not sure what those issues are/were 😬 @joshdholtz could you shed some light? Maybe we can work on a fix?

I've just merged latest master in here and resolved merge conflicts 🙏


bundle generation move with config

Description
Added the config file back for bundle generation and updated the wrapper script accordingly
Related Issue
https://issues.redhat.com/browse/ACM-8296

/lgtm


Vm/healthcheck envoy

Currently we only check application health. This expands this to also
perform the same health checks that k8s gets on the agent. These are
aggregated with AggregateProbe.

Depends on https://github.com/istio/istio/pull/29426

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all


Added dev args to wrangler.toml

Fixes #1282

doesn't seem to work?

wrangler.toml
name = "worker"
type = "javascript"
route = "averyharnish.com/test"

[dev]
ip = "[::1]"
port = "9000"

console
$ wrangler dev
💁  JavaScript project found. Skipping unnecessary build!
👂  Listening on http://<IP_ADDRESS>:8787
💁  watching "./"


remove special __MigrationHistory workaround for mysql

QUSMA used a workaround to fix an issue with MySQL and Entity Framwork and utf8, see here: http://stackoverflow.com/questions/20832546/entity-framework-with-mysql-and-migrations-failing-because-max-key-length-is-76
In the same site, KingPong describe an easier way to solve this issue. This should be used instead the additional mysql specific hack - see EntityData/Migrations/DataDBContextConfiguration.cs

I removed the old code. Verification needed:
Test Plan:

start QDMS with an empty MySQL database - when the __MigrationHistory is createated without error, the ticket can be closed


Training config and log

Hi,
I cannot replicate the results in the paper using your paper's parameter. The performance is pretty low. Could you provide training logs and detailed config for reproducibility? Thanks!

Hi,
Thanks for the great work. Is kitti_example.yaml the config file you use for the paper?

Hi @yama514 , this repo is a little different from the code we use in the original paper, and I noticed the accuracy of this repo is unstable.  I update the code to make the performance stable and some new features have been added to achieve better performance.  @AndersonStreedd @yama514  you can try it now.

Thanks！


Fix: Java 1.9+ versions require jaxb as separate dependency

Without explicit jaxb dependency the maven plugin cannot be built with java 1.9+

Hi @b-gyula !
I just conditioned another PR you submitted, happy to see this submission as well.  I will try and get this into the same sprint.
Ronak

Assessed as a Low risk, adding the dependency should be easy to test.


question about source code

I am reading the source code of matter-lab/zksync to understand it better and then join you guys to build this project.
But I have some questions.
I want to know which branch is more suitable for reading and learning, master branch or dev branch, can you tell me the difference between them?
Can you explain this to me?
And another issue, there is a few information about zksync source code, so I think the solution is to encourage more people write articles to explain how exactly zksync works

@popzxc @StanislavBreadless

Hi! Thanks for your interest in zkSync.
This is a public mirror of the private development repository, so you can consider it to be a "snapshot" of the actual code that is being updated from time to time. We publish changes to the master branch normally. There is some information about source code architecture in the docs folder, for example the architecture overview.
While we appreciate contributions, most of the development is being coordinated in the team internally, so keeping it in sync with the public repo may be hard at times. Additionally, most of our focus is on developing the 2.0 version right now.
That being said, being more open to the developer community is one of our focuses for the 2.0 -- I hope the processes will be better there.

Hi! Thanks for your interest in zkSync.
This is a public mirror of the private development repository, so you can consider it to be a "snapshot" of the actual code that is being updated from time to time. We publish changes to the master branch normally. There is some information about source code architecture in the docs folder, for example the architecture overview.
While we appreciate contributions, most of the development is being coordinated in the team internally, so keeping it in sync with the public repo may be hard at times. Additionally, most of our focus is on developing the 2.0 version right now.
That being said, being more open to the developer community is one of our focuses for the 2.0 -- I hope the processes will be better there.

Thanks for the reply, it sounds like the dev branch is more stable and better to read.
I think there may be 1000+ rollups in the future, and many may be application-specific rollups, I think these rollups can be used as L3 deployed on zkSync L2.
So I want to develop a tool/protocol that is convenient for developers to write and deploy a rollup based on zkSync.
Can you review my idea and tell me what's missing.

Thanks for the reply, it sounds like the dev branch is more stable and better to read.

Actually, it just was not updated for a longer period of time. You can read and use it if you find it more convenient -- just keep in mind that it doesn't represent the current state of zkSync.

Can you review my idea and tell me what's missing.

L3s are actually a hot topic right now, as well as limitless scalability in general. This sounds however that it would be more relevant for zkSync 2.0, since zkSync 1.0 is not general purpose rollup yet. The testnet for zkSync 2.0 is public, you may want to try it (though the server code is not open sourced just yet -- but will be, just later).
You may also want to read about zkPorter -- another our take on the topic.

Yes, I tried EVM compatible with zksync v2 and the experience was very good.
I'm looking forward to reading the v2 source code and seeing the full zkEVM moduled.
I'm a little confused, can you tell me which commit of the master branch is stable, for me to read better.

In addition, I want to make it clear that the current core team focus is zksync v2? So zksync will not have many updates?
As far as I know, the major feature of zkSync v2 is EVM compatibility (zkEVM), so is the current team's v2 focus on zkEVM?

Thanks for the reply, it sounds like the dev branch is more stable and better to read.

Actually, it just was not updated for a longer period of time. You can read and use it if you find it more convenient -- just keep in mind that it doesn't represent the current state of zkSync.

Can you review my idea and tell me what's missing.

L3s are actually a hot topic right now, as well as limitless scalability in general. This sounds however that it would be more relevant for zkSync 2.0, since zkSync 1.0 is not general purpose rollup yet. The testnet for zkSync 2.0 is public, you may want to try it (though the server code is not open sourced just yet -- but will be, just later). You may also want to read about zkPorter -- another our take on the topic.

I'm a little confused, can you tell me which commit of the master branch is stable, for me to read better.

The most recent commit (from 3 days ago) should work just fine.

In addition, I want to make it clear that the current core team focus is zksync v2? So zksync will not have many updates?

Yes, we primarily work on v2. zkSync 1.0 receives stability & security updates, but from a feature set we consider it to be complete, meaning that we don't plan any big features on the protocol level. We still working with many projects on integrations though, like wallets, exchanges and offramp/onramp solutions.

so is the current team's v2 focus on zkEVM?

zkEVM is absolutely the central part of v2, but obviously it's not the only component -- we also need to prepare the new server that is web3 compatible, compiler and plugins for it, etc. But again, yes, everything revolves around zkEVM :)

Thank you so much! You answered many of my doubts.
Looking forward to seeing the code for v2 and looking forward to doing some interesting things for this project.

I'm a little confused, can you tell me which commit of the master branch is stable, for me to read better.

The most recent commit (from 3 days ago) should work just fine.

In addition, I want to make it clear that the current core team focus is zksync v2? So zksync will not have many updates?

Yes, we primarily work on v2. zkSync 1.0 receives stability & security updates, but from a feature set we consider it to be complete, meaning that we don't plan any big features on the protocol level. We still working with many projects on integrations though, like wallets, exchanges and offramp/onramp solutions.

so is the current team's v2 focus on zkEVM?

zkEVM is absolutely the central part of v2, but obviously it's not the only component -- we also need to prepare the new server that is web3 compatible, compiler and plugins for it, etc. But again, yes, everything revolves around zkEVM :)


USBView incorrectly prints out bType of unknown capability descriptor

It prints out the length twice instead. There is a typo in display.c:2897.

Thanks for the quick response. However, it would be more useful to have it print the value of the bDescriptorType field which I believe was the original intention.
Thanks.


Discussion List is not Updated after Delete

Describe the bug
The discussion list does not update after deleting a comment.
To Reproduce

Make a comment
Open the discussion list
delete the comment

Expected behavior
I expect the deleted comment to disappear from the discussion list. However, unlike with adding replies or editing comments, the discussion list does not update to reflect that the comment has been deleted.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]

Should be fixed. Please let me know if not.

Hmm, now this is happening when I create a comment after opening and closing the discussion_list:
Error executing vim.schedule lua callback: ...l/share/nvim/lazy/gitlab.nvim/lua/gitlab/discussions.lua:184: BufWinEnter Autocommands for "<buffer=11>": Vim(append):Error executing lua callback: ...h
/.local/share/nvim/lazy/nui.nvim/lua/nui/split/init.lua:235: Invalid 'group': 'nui_5_hide'
stack traceback:
  [C]: in function 'create'
  ...h/.local/share/nvim/lazy/nui.nvim/lua/nui/split/init.lua:235: in function <...h/.local/share/nvim/lazy/nui.nvim/lua/nui/split/init.lua:234>
  [C]: in function 'nvim_buf_set_lines'
  ...l/share/nvim/lazy/gitlab.nvim/lua/gitlab/discussions.lua:184: in function 'callback'
  ...ch/.local/share/nvim/lazy/gitlab.nvim/lua/gitlab/job.lua:25: in function ''
  vim/_editor.lua: in function ''
  vim/_editor.lua: in function <vim/_editor.lua:0>
stack traceback:
  [C]: in function 'nvim_buf_set_lines'
  ...l/share/nvim/lazy/gitlab.nvim/lua/gitlab/discussions.lua:184: in function 'callback'
  ...ch/.local/share/nvim/lazy/gitlab.nvim/lua/gitlab/job.lua:25: in function ''
  vim/_editor.lua: in function ''
  vim/_editor.lua: in function <vim/_editor.lua:0>

Yeah I'm probably not going to address that issue with the last comment. I'm aware of what's happening with the first issue and can try to address soon. Are you closing the buffer with :bd rather than :q perchance? I think the issue is that the buffer itself has been destroyed when we try to refresh the tree -- will take a look at this later tonight

This should be fixed, was able to replicate and just merged in a fix @mnbroatch


Weapon Detection System

Title: Weapon Detection System
Description:
We need a Weapon Detection System project to enhance the current capabilities of our security and safety. This feature will involve detecting various types of weapons in images or video feeds using AI/ML techniques. The detection system should be able to recognize common weapon types such as guns, knives, etc., and provide real-time alerts when a weapon is detected.
Tasks:
Research and select suitable datasets for weapon detection.
Develop or integrate a pre-trained model capable of detecting weapons in real-time.
Implement a solution using [insert tech stack like Python, TensorFlow, OpenCV, etc.].
Create a user interface to display results (if applicable).
Test and evaluate the system for accuracy and performance.
Document the workflow, model architecture, and any other relevant information in the repository.
Expected Outcome:
A functional weapon detection system integrated into the project, capable of identifying weapons with high accuracy in real-time scenarios.

Sure @venkat-2811, go ahead! Do mention the estimated time that you require for this.

I will be completing this by tomorrow sir.

@venkat-2811, updates?


Window Snapping Does Not Work

Win + Left/Right doesn't work. Have to drag the window to the edge of the screen. It's odd this doesn't work.

Windows snapping does work, if you click on any part of the SuperPuTTY window surrounding each terminal.
The reason is that superputty loads up instances of "putty.exe" for each individual terminal tab, and these instances do not pass the Win+Left/Right commands up to the parent SuperPuTTY process.

With the current build even dragging doesnt work.

After much investigation this relates to https://github.com/dockpanelsuite/dockpanelsuite/issues/110
Unfortuantely unless @jimradford wants to use a different docking library or fix that one there isnt a huge amount that can be done.


fix: move decrypt key to after dependency install

Need to move this to after the dependency install. It works though. Promise.

bors r+


[ENH]: make get_range() a lazy Stream

Description of changes
Enables a usecase from @Sicheng-Pan (scanning up to a given limit with an application filter) and makes some current operations slightly more efficient.
Test plan
How are these changes tested?

[x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3009  👈
#2936
#2935
#2934
#2921
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @codetheweb and the rest of your teammates on  Graphite

What is the context for this change?

What is the context for this change?

See updated PR description, I think you might have written your comment before I updated it haha

Merge activity

Nov 4, 1:28 PM EST: A user started a stack merge that includes this pull request via Graphite.


Inconsistent PrettyPrinting

scala> val rawJson = """{"hello": "world", "age": 42, "nested": { "deeper": { "treasure": true }}}"""
rawJson: String = {"hello": "world", "age": 42, "nested": { "deeper": { "treasure": true }}}

scala> rawJson.asJson.noSpaces
res24: String = "{\"hello\": \"world\", \"age\": 42, \"nested\": { \"deeper\": { \"treasure\": true }}}"

scala> decode[HelloWorld](rawJson).map(_.asJson.noSpaces).getOrElse("")
res25: String = {"hello":"world","age":42,"nested":{"deeper":{"treasure":true}}}

res24 is not parsable because of "\"

I think it's not a bug. res24 is a simple json string. Not a json object.

rawJson.asJson does not parse the rawJson string into the AST, it creates a single JsonString value that has rawJson as its content, hence the escaping. You have to use decode or parse to get the Json AST.
@ import io.circe._
@ import io.circe.parser._
@ import cats.data.Xor

@ val rawJson = """{"hello": "world", "age": 42, "nested": { "deeper": { "treasure": true }}}"""
rawJson: String = """
{"hello": "world", "age": 42, "nested": { "deeper": { "treasure": true }}}
"""
@ val Xor.Right(json) = decode[Json](rawJson)
json: Json = {
  "hello" : "world",
  "age" : 42,
  "nested" : {
    "deeper" : {
      "treasure" : true
    }
  }
}
@ json.noSpaces
res7: String = """
{"hello":"world","age":42,"nested":{"deeper":{"treasure":true}}}
"""

By res24 isn't parsable I meant this:
scala> decode[HelloWorld](res24)
res32: cats.data.Xor[io.circe.Error,HelloWorld] = Left(DecodingFailure(Attempt to decode value on failed cursor, List(El(DownField(hello),false,true))))

This is because res24 isn't a string that contains json object, it is a string rendering of a json string. I don't think rawJson.asJson produces what you want.

So how can I parse rendered json string? Or more precisely, why that rendered string contains \\ (escaped backslash)?
I disagree about asJson. You can clearly see that it returns io.circe.Json which is AST

https://github.com/travisbrown/circe#transforming-json

scala> Decoder[HelloWorld].apply(parse(res24).getOrElse(Null).hcursor)
res58: io.circe.Decoder.Result[HelloWorld] = Left(DecodingFailure(Attempt to decode value on failed cursor, List(El(DownField(hello),false,true))))

And second question is still in place: why nospaces (and other pretty printers) puts "\" in one case and doesn't do it in the other one. It's the same nosapces. I didn't explicitly ask for '\- I don't even know why would I need it (as this is not actual escaping - like"- it's\"`).

To be more precise. I can "parse" res24, but I still can't decode it to a case class.
And I actually can't work with it:
scala> parse(res24).getOrElse(Null).hcursor.downField("hello").withFocus(_.mapString(_.reverse)).top
res61: Option[io.circe.Json] = None

Compare to res25:
scala> parse(res25).getOrElse(Null).hcursor.downField("hello").withFocus(_.mapString(_.reverse)).top
res62: Option[io.circe.Json] =
Some({
  "hello" : "dlrow",
  "age" : 42,
  "nested" : {
    "deeper" : {
      "treasure" : true
    }
  }
})

There are two ways to get to a Json AST. The first is from a serialized/wire representation, such as a string by means of parsing. The second is from your domain types and entities by means of encoding.
There are also two ways to go from the Json AST, one is to the serialized/wire representation by means of (pretty-)printing, the other is by means of decoding. asJson is only for the second way, so it treats your rawJson in the same way it would do with HelloWorld or other case class. The resulting AST ist a single JsonString containing complete rawJson, not a JsonObject. The printer (spaces2 in toString or the explicit noSpaces) is then rendering this Json AST, the single JsonString as a string. That means, if you parse the result (res24), you would only get a String back, not a case class. What you want is parse the rawJson, not the res24. This step will give you the Json AST that you can use to decode into your case class.

Ok, now I understand, sorry for trying to force it as a bug :).
As I understand, you've meant not getting a Json String back - you mean I'll get a io.circe.Json.String back. I just didn't read it careful enough.
It actually a common misunderstanding - I was trying to make this example work, as the author claimed that it doesn't: http://manuel.bernhardt.io/2015/11/06/a-quick-tour-of-json-libraries-in-scala/. I believe the author faced the same problem.
Maybe you should add more examples to README.
Thanks, and sorry again :)