ez_setup.py incorrectly detect charset

The problem is reproduced when I am trying to init buildout by run bootstrap:
python bootstrap-buildout.py
Traceback (most recent call last):
  File "bootstrap-buildout.py", line 119, in <module>
    ez['use_setuptools'](**setup_args)
  File "<string>", line 160, in use_setuptools
  File "<string>", line 375, in _resolve_version
  File "D:\bin\python35\lib\codecs.py", line 998, in getreader
    return lookup(encoding).streamreader
TypeError: lookup() argument must be str, not None

The bootstrap get latest ez_setup.py from https://bootstrap.pypa.io/ez_setup.py and try to exec it.
The real problem in the _resolve_version in ez_setup.py:
def _resolve_version(version):
...
    resp = urlopen(meta_url)  # https://pypi.org/pypi/setuptools/json
...
        try:
            charset = resp.info().get_content_charset()   #  returns None
        except Exception:
            # Python 2 compat; assume UTF-8
            charset = 'UTF-8'
        reader = codecs.getreader(charset) # fail here because charset is None

Possible last days Content-Type header was changed for https://pypi.org/pypi/setuptools/json.
Also I don't found repository for ez_setup.py. Only changelog contains info that it was removed from this repo, but there are no info about new location.

Same issue here: https://travis-ci.org/kdeldycke/meta-package-manager/jobs/186461490#L243

ez_setup.py can be found in the bootstrap branch of setuptools.

This issue is easily fixed by passing the fallback parameter to get_content_charset.

Let me know if that doesn't fix the issue.

I confirm https://github.com/pypa/setuptools/commit/044375318681ee22638271b9fab32225ec23a3ae is fixing the issue. Proof: https://travis-ci.org/kdeldycke/meta-package-manager/jobs/186547684#L246
Thanks @jaraco for the quick fix! 👍


jdom docs: correct usage of defineProperties

@erezcohen thanks, would you be able to rebase this on the command line, so there's no merge commits?


Add var and std to weighted computations

[x] Tests added
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst
[x] New functions/methods are listed in api.rst

This follows https://github.com/pydata/xarray/pull/2922 to add var, std and sum_of_squares to DataArray.weighted and Dataset.weighted. I would also like to add weighted quantile, eventually.

Is there an appetite to add a weighted quantile method as well ?

I would be strongly interested in this capability!

@dgilford I have worked on it: https://github.com/pydata/xarray/pull/6059, but unfortunately the PR is currently stuck in limbo, for technical reasons.


[BUG] Touch events not working on the map

I tried to use the app on my Windows 10 tablet and the map its unresponsive to the touch events, menu and all other other elements are working fine

@jabj88 Is this still an issue with the latest release(0.2.1)?


ADD: Deep-link QR code

During testing, some users do not open Voltix first, they go straight to QR code, which goes to website
use deep-linking to be smart
https://developer.apple.com/ios/universal-links/

Add the path to switch to the Vault when tapped on Switch Vault.
In case of the wrong vault is selected for the Keysign flow.


Query reduction throughout the application

There is a lot of information that is being pulled in from the database on various pages.
At the moment, this information is queried at a relatively low level - that is, queried close to the component where it is used. Conceptually, we would be querying X in each component in the diagram below.

If we query the same information in each component, we have a total of 3 queries. If we would query in the page, and pass the information to each component, we would reduce the queries to 1.
This is happening throughout the application and may affect the performance, depending on the scale at which this happens.
Todo

[ ] Create a full inventory of queries for the various pages (e.g., using draw.io)
[ ] Find common queries within a page across components
[ ] Identify which queries can be "promoted" to higher level components to reduce queries
[ ] Implement

An initial assessment.

It seems like the main gain here is related to the workspace and user queries. Elevating those up in the page and passing it down to individual components like Navbar and chldren, may reduce the number of queries necessary.
In that sense, this may relate to #33 as well, if that can make certain queries superfluous to begin with.


Add support for private container registries

The operator should support private container registries as documented in the Operator Certification CI Pipeline Instructions.
https://github.com/redhat-openshift-ecosystem/certification-releases/blob/main/4.9/ga/ci-pipeline.md#required-step-will-be-optional-soon---if-using-a-private-container-registry

Key to be used in CR should be docker-registry when creating the secrete, since this is the value the pipeline uses.

/assign

This appears to already work as long as the user creates the registry-dockerconfig-secret and runs the following command:
tkn pipeline start operator-ci-pipeline \   --param git_repo_url=$GIT_REPO_URL \   --param git_branch=main \   --param bundle_path=$BUNDLE_PATH \   --param env=prod \   --param pin_digests=true \   --param git_username=$GIT_USERNAME \   --param git_email=$GIT_EMAIL \   --param registry=$REGISTRY \   --param image_namespace=$IMAGE_NAMESPACE \   --workspace name=pipeline,volumeClaimTemplateFile=templates/workspace-template.yml \   --workspace name=kubeconfig,secret=kubeconfig \   --workspace name=ssh-dir,secret=github-ssh-credentials \   --workspace name=registry-credentials,secret=registry-dockerconfig-secret \   --showlog
we can check if the secret exists and log this in the operator but since we aren't creating secrets in the operator itself there isn't a lot for the operator to do

That seems reasonable to me. So the work required for this would be to simply output a message in the log if the secret is present. Does anyone have any problem with that?

I'll open that PR right now so folks can see it.


build(devtools): Update package namespaces to @fluidframework in preparation for upcoming 2.0 beta

Renames the packages from the @fluid-experimental namespace to the @fluidframework namespace in preparation for the upcoming 2.0 release candidate.
Note that while only the devtools package will be advertised publicly, it depends on devtools-core, so both really need to move. devtools-view is (for now) private to the repo, so a rename isn't strictly needed, but doing so keeps all of these packages scoped the same, and its current namespace @fluid-internal is misleading, as we do not publish it for internal use.

nit: npm calls them "scopes," not namespaces.

nit: npm calls them "scopes," not namespaces.

I've seen both terms in different contexts. But I've updated to "scopes" here.

Changing devtools-view to @fluidframework breaks our policy check, which asserts that @fluidframework packages not be private. This seems like something we should rethink in the future, but for now I've reverted the changes to devtools-view. Only devtools and devtools-core (the 2 packages we publish) are updated.

Should this PR also update packages/service-clients/odsp-client? Currently @fluid-experimental.


Carpet Disappears

Hello =D
fabric-loader 0.14.12-1.19.2
carpet-layers-1.0.1.jar
When I place another color of carpet on top of a single layer of carpet it replaces the existing carpet and the old carpet disappears.
Hope this helps, cool mod btw

fixed in 1.1.0


ARMADA-900 Add documentation to prepare release action

What
Add documentation to prepare release action.
Why
In order to keep the documentation's version in sync with all other sub-projects (API and CLI).
Task: https://app.clickup.com/t/18022949/ARMADA-900

Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.

Task linked: ARMADA-900 Make sure that Jobbergate documentation is correctly published and publicly visible


gir1-ostree version is wrong on Debian stable

See original issue on GitLab
In GitLab by [Gitlab user @adds68] on Apr 17, 2018, 17:11
When i try to install Buildstream, it reports that the ostree version (with python bindings) is too old to be used.
I have seen this error occur multiple times, and the fix suggested in the error message does not fix the problem:
OSTree is too old.\n    BuildStream requires OSTree >= v2017.8 with Python bindings. Install it using your package manager (usually ostree or gir1.2-ostree-1.0).\n"    OSTree is too old.", "    BuildStream requires OSTree >= v2017.8 with Python bindings. Install it using your package manager (usually ostree or gir1.2-ostree-1.0).", "
However gir1.2-ostree-1.0 on Debian 9 installs 2016.15-5, which means i still not can not install Buildstream.

In GitLab by [Gitlab user @adds68] on Apr 17, 2018, 17:11
changed the description

In GitLab by [Gitlab user @jjardon] on Apr 17, 2018, 17:16
changed the description

In GitLab by [Gitlab user @jjardon] on Apr 17, 2018, 17:20
[Gitlab user @adds68] indeed, you need to enable the stretch-backports, which include 2018.2-1: https://packages.debian.org/stretch-backports/ostree
Follow the instructions from https://buildstream.gitlab.io/buildstream/install.html#stretch

In GitLab by [Gitlab user @jjardon] on Apr 17, 2018, 17:20
closed

In GitLab by [Gitlab user @adds68] on Apr 17, 2018, 17:22
[Gitlab user @jjardon] I feel like this error message should link to the docs instead of mentioning the package needed to be installed, as the solution in the error message doesn't work on Debian stable?

In GitLab by [Gitlab user @jjardon] on Apr 17, 2018, 17:51
[Gitlab user @adds68] mmm, maybe you are rigth, more info to the user can't hurt; mind providing a patch? :)

In GitLab by [Gitlab user @jjardon] on Apr 17, 2018, 17:51
reopened

In GitLab by [Gitlab user @tpollard] on Jul 18, 2018, 15:35
This error message was removed with from setup.py with commit 1f8b4aa290a908a697f008a29ea143a9320dd639 with the removal of the OSTree based artifact cache. The issue & install documentation for host depedencies will need changing to reflect this

In GitLab by [Gitlab user @cs-shadow] on Oct 10, 2019, 14:52
OSTree plugin now lives in bst-plugins-experimental. Issues related to it should go there moving forward.

In GitLab by [Gitlab user @cs-shadow] on Oct 10, 2019, 14:52
closed


Multi user

Hi,
A feature that would be nice is to be able to add several DELUGE_RPC accounts and connect to them on the web interface for several users.

@JamesDAdams Would that be the ability to switch between multiple deluge containers through a drop-down option perhaps?
How do you envision it?

For my user, i have multiple account in my single deluge container for multiple user, and an option for connecte to deluge account in the web interface and not the docker env it's would be realy good.

What is it you use multiple users for? Do your different users have different access rights?

What is it you use multiple users for? Do your different users have different access rights?

Yes, i have a multiple user for multiple person.


Weird normalization of inline w.r.t. extraction

jonathan@chartreuse:/tmp $ cat test.fst
module Test

inline let t b = if b then int else string
let u b = if b then int else string
let vrai = true
let faux = false

let main (x: t faux) (y: u vrai) (z: t true) =
  ()

let op_Bang x = not x
jonathan@chartreuse:/tmp $ fstar --codegen OCaml test.fst && cat Test.ml

open Prims
# 3 "test.fst"
type 'Ab t =
Obj.t

# 4 "test.fst"
type 'Ab u =
Obj.t

# 4 "test.fst"
let vrai : Prims.bool = true

# 5 "test.fst"
let faux : Prims.bool = false

# 6 "test.fst"
let main : Obj.t  ->  Prims.unit u  ->  Prims.int  ->  Prims.unit = (Obj.magic ((fun x y z -> ())))

Notice how the first Obj.t should be string

My bad: faux should've been marked as inline.
However, we do want to support the following scenario:
let main (x: t faux) (y: u vrai) (z: t true) =
  let _ = if faux then 0 else 1 in
  IO.print_string "done"

where the if disappears. For that, we need to enable a normalization step that reduces pure computations inside of effectful terms; and call that step before extraction.

Yep, working on it today

Cf. 021d994


Update requirements/develop.pip with missing pyopenssl library

Just add library which were missing when I tried to install repo locally

I just installed from develop.pip on a fresh virtualenv (python3.7) and did not have any issue running nameko run croquemort.http 🤔
Does the error appear when doing something else (using the API...)?
What OS are you on ?

nameko run croquemort.http and nameko run croquemort.crawler work after installation but the problem is appearing when you try to do some http POST or GET request once these two services are launched.
When I try http :8000/check/one url="https://www.data.gouv.fr/fr/" I have the following error in crawler output : Error with https://www.data.gouv.fr/fr/: wrap_socket() got an unexpected keyword argument '_context'  and I can't retrieve correct response after that.
After pip install pyopenssl, the error disappear

Tested both on Debian and Ubuntu env

Got it, thanks, good catch.
I think this belongs in install.pip rather than develop.pip.
Also can you add an entry to CHANGELOG.md, something like "Add pyOpenSSL requirement for python3.7 compatibility" (this seems specific to py3.7) ?
Thanks!

Done!

@geoffreyaldebert great, thanks!


REPO IS NO LONGER MAINTAINED AND DOES NOT SUPPORT JUPYTERLAB>=3.0.0

I just spent quite a while setting up an environment and troubleshooting different issues, when I realized that this repo is no maintained and does not support any recent version of jupyterlab.

I recommend IPYDataGrid (https://github.com/bloomberg/ipydatagrid) as a working alternative to QGrid.

It lacks documentation, but it does work with current versions of Python, Jupyter Lab, and IPYWidgets.

Nice UX, but much slower to load big dataframes :-(

Nice UX, but much slower to load big dataframes :-(

Is it just the initial loading that is slow for you? I fixed a bug on this recently that made initialising much faster.
https://github.com/bloomberg/ipydatagrid/pull/395

I assume that by "loads dataframes lazily" you mean that it doesn't add DOM elements for the rows/columns that are out of view?
If yes, ipydatagrid doesn't actually use the DOM elements to represent its structure but uses a canvas element on which of course it only draws the rows/columns that are currently in view.
Out of interest, what were the symptoms of slowness that you observed? Might be worth an issue on the ipydatagrid repo.

I takes ~11sec to load 200k rows dataframe, while QGrid loads instantly (and ipyaggrid takes 7sec).

I've created a new repo QgridNext to continue maintaining Qgrid for future Jupyter versions.
QgridNext is now compatible with recent releases of Jupyter:

QgridNext
JupyterLab
Notebook
Voila

v2.0.0
v3 - v4
v5 - v7
v0.2 - v0.5

Now it works as a prebuilt extension (introduced in JupyterLab 3), hence JupyterLab 1/2 are no longer supported. I've reorganized documents, readme, test environments and demos for a fresh start for the new repo. Your feedback, issues and PRs are welcomed and highly appreciated!


npm ERR! Error: EACCES: permission denied, access '/app'

`
Step 8/10 : RUN npm config set registry https://registry.npm.taobao.org && npm install --production
---> Running in aa8a7d9d1786
npm WARN checkPermissions Missing write access to /app
npm WARN<EMAIL_ADDRESS>No description
npm WARN<EMAIL_ADDRESS>No repository field.
npm WARN<EMAIL_ADDRESS>No license field.
npm ERR! code EACCES
npm ERR! syscall access
npm ERR! path /app
npm ERR! errno -13
npm ERR! Error: EACCES: permission denied, access '/app'
npm ERR!  { [Error: EACCES: permission denied, access '/app']
npm ERR!   stack: 'Error: EACCES: permission denied, access '/app'',
npm ERR!   errno: -13,
npm ERR!   code: 'EACCES',
npm ERR!   syscall: 'access',
npm ERR!   path: '/app' }
npm ERR!
npm ERR! The operation was rejected by your operating system.
npm ERR! It is likely you do not have the permissions to access this file as the current user
npm ERR!
npm ERR! If you believe this might be a permissions issue, please double-check the
npm ERR! permissions of the file and its containing directories, or try running
npm ERR! the command again as root/Administrator.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kube-dingtalk/.npm/_logs/2019-11-12T09_01_09_427Z-debug.log
The command '/bin/sh -c npm config set registry https://registry.npm.taobao.org && npm install --production' returned a non-zero code: 243
`
chown $user:$user /app

The error has been fixed


Tobin gh535 image cleanup

Fix for #535 as well as new tests to hit new checks and some general image layer cleanup.

+1

cherry-picked and pushed to master


[clang-format] Mismatch between clang-format on workstation and on CI

The topgen and make_new_dif utils autogenerate some pieces of device SW and they run clang-format. This runs on the user's workstation, which may have a different version of clang-format than what runs in CI. This may result in intermittent CI failures reporting that the generated sources are stale.
A quick fix is to run topgen (i.e. make -C hw top) from within the OpenTitan docker image. The other option is to always ensure that the clang-format on the user's workstation always matches what runs in CI.
The latter needs a bit more investigation, considering Google corp workstations come with Google's version of clang-format.
The PR #8592 was made to address the CI symptom, but really, the source of the problem needs to be fixed. Filing issue for further discussion.

The following steps work:
$ sudo apt-get install clang-format-6.0 # same ver as CI
$ sudo mv /usr/bin/clang-format /usr/bin/clang-format.old
$ sudo ln -s /usr/bin/clang-format-6.0 /usr/bin/clang-format
$ clang-format --version # should show 6.0


How to use OpenCV Mat instead of file string

Hi Team,
We are evaluating the Dynamsoft-Barcode-Reader Linux C/C++ interface for our work. We want to do some pre-processing before passing to Barcode reader interface so How to use OpenCV Mat with ReadMultiBarcodes example?

Jegathesan S

Assue you have read an image file to Mat:
cv::Mat mat;

    int w = mat.cols;
    int h = mat.rows;
    int c = mat.channels();
    unsigned char *data = (unsigned char *)mat.data;
    int index = 0;
    for (int y = 0; y < h; ++y) {
        for (int k = 0; k < c; ++k) {
            for (int x = 0; x < w; ++x) {

                image_buffer[index] = data[index];
                index++;
            }
        }
    }

Then you can invoke decodebuffer() method:
int errorCode = DBR_DecodeBuffer(barcodeReader, data, width, height, width * channel, format, "");

@yushulx Thanks, It worked.


terraforming kmsk throws an exception

C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.10.40/lib/seahorse/client/plugins/raise_response_errors.rb:15:in call': arn:aws:kms:us-east-1:925458006158:key/0132c156-85d0-4c60-b7a8-afd73a6f6c8b origin is EXTERNAL which is not valid for this operation. (Aws::KMS::Errors::UnsupportedOperationException)         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.10.40/lib/aws-sdk-core/plugins/jsonvalue_converter.rb:20:in call'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.10.40/lib/aws-sdk-core/plugins/idempotency_token.rb:18:in call'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.10.40/lib/aws-sdk-core/plugins/param_converter.rb:20:in call'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.10.40/lib/seahorse/client/plugins/response_target.rb:21:in call'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.10.40/lib/seahorse/client/request.rb:70:in send_request'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/aws-sdk-core-2.10.40/lib/seahorse/client/base.rb:207:in block (2 levels) in define_operation_methods'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/terraforming-0.14.0/lib/terraforming/resource/kms_key.rb:68:in key_rotation_status_of'
from (erb):6:in block in apply_template'         from (erb):1:in each'
from (erb):1:in apply_template'         from C:/Ruby23-x64/lib/ruby/2.3.0/erb.rb:864:in eval'
from C:/Ruby23-x64/lib/ruby/2.3.0/erb.rb:864:in result'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/terraforming-0.14.0/lib/terraforming/util.rb:4:in apply_template'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/terraforming-0.14.0/lib/terraforming/resource/kms_key.rb:19:in tf'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/terraforming-0.14.0/lib/terraforming/resource/kms_key.rb:7:in tf'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/terraforming-0.14.0/lib/terraforming/cli.rb:250:in tf'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/terraforming-0.14.0/lib/terraforming/cli.rb:237:in execute'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/terraforming-0.14.0/lib/terraforming/cli.rb:129:in kmsk'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in run'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in invoke_command'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in dispatch'
from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/thor-0.19.4/lib/thor/base.rb:444:in start'         from C:/Ruby23-x64/lib/ruby/gems/2.3.0/gems/terraforming-0.14.0/bin/terraforming:5:in <top (required)>'
from C:/Ruby23-x64/bin/terraforming:22:in load'         from C:/Ruby23-x64/bin/terraforming:22:in '

Currently KMS external key is not supported by Terraform (terraform-provider-aws). There is a patch to add aws_kms_external_key resource, but it haven't been merged yet.
According to this, KMS external key should be ignored by kmsk command. I'll make a patch.
Thanks!


the rolling problem

Hello,
I've been learning your implementation and noticed that you utilized torch.rolling to shift the token sequence, which results in the front group_size/2 tokens being positioned behind the future tokens. I'm curious to know, does this approach potentially introduce information leakage during the CLM pre-training task? I'd appreciate your insights on this.
Thank you for your time and effort on this project!

Hi,
This is a very good question. It is true that it potentially introduce leakage, but because we use standard attention during inference, this issue does not exist during inference. Thus, we actually did not observe performance degradation because of this. During training, based on my understanding, what we do is actually to fine-tune the model to fit the new position embedding. It requires only limited iterations to converge, which is much less compared to the pre-training stage. Thus, its effect is limited.
In addition, we have realized this potential issue. The reason we do rolling is to introduce different group partition. Thanks to the new flash-attention version, we modify the implementation to avoid torch.rolling and partition groups without rolling. Please refer to the function below.
https://github.com/dvlab-research/LongLoRA/blob/76790130443d2f9a9bf5af5de4bf867f38136dc4/llama_attn_replace.py#L22
Regards,
Yukang Chen


Create command to check if a minecraft server is blocked

wiki.vg doesn't properly document how the check works, so implementation may be different from what you would expect with the information on there.
Seemed like a fun thing to add since it can be nice to see if a server is blocked by mojang. Would have used mcsrvstat.us, but their implementation is done like how wiki.vg describes it, which is unforunately wrong (they dont include an initial check to *.(whateverip) on domain checks so they didn't flag, for example, jes.earth as blocked because the blocked ip is *.jes.earth.) Just seems like the sort of thing that could be helpful.

LGTM


ADAPT-5488 | Add IDEAL category to areas to support page

READY FOR REVIEW
Summary

Add Diversity, Equity, + inclusion category to areas to support page (in the filter), and that the user can add a card under the Diversity, Equity, + inclusion category as well.
Fix a weird double scroll bar bug that I see on the Areas to support page

Review By (Date)

Sooner the better so we can get this into PROD for Giving Tuesday

Review Tasks
Setup tasks and/or behavior to test

Go to https://deploy-preview-300--adapt-giving.netlify.app/areas-to-support/
Confirm that you see the Diversity, Equity, + inclusion category button
Click on it, and it should show the only one card which is in this category
The URL should update with the #dei hash as well
You shouldn't see any weird double vertical scroll bar like on
https://giving.stanford.edu/areas-to-support/
If you click on Athletics for example

Affected Projects or Products

Does this PR impact any particular projects, products, or modules?

Associated Issues and/or People

ADAPT-5488

@sherakama Just heard from Dena that Alexis would like a wording update, so I'll likely push up another round of changes

@sherakama Just heard from Dena that Alexis would like a wording update, so I'll likely push up another round of changes

@sherakama Ok, it is now ready for your eyes (no rush)
FYI, Alexis is ok with the taller button on

mobile

Just checked on my iPhone and things look ok there too - it actually fits on one line in the button on the real phone so 😄 I'm going to merge this into dev. I've made the changes to the components on PROD storyblok and will cut a release tomorrow or Monday.


Any software including this should have a copyright license

Any software including this should have a copyright license, if not users rights are necessarily limited by what the law allows (very little and very different from country to country), and contributions are less likely to appear, because contributors are likely to be confused about what's to be expected regarding copyright.

Thanks for reminding us. I just slabbed an MIT licence on it, assuming that would generally work for people. Closing this, but feel free to reopen if you have further comments.


Running dart doc does't put items into the correct category when there isn't an import statement.

If you run dart doc and have a class that doesn't contain an import statement in it the file will not get put into the category assigned to it on the generated doc pages.
Example:
/// {@category Helper Classes}

class SomeClassName {
}

will not get put into the documentation Helper Classes category.  But if I add an unused import statement like:
/// {@category Helper Classes}

import 'dart:io';

class SomeClassName {
}

the documentation will put the file into the correct category.
Dart Info:

Dart 3.1.1 (stable) (Tue Sep 5 12:20:14 2023 +0000) on "macos_x64"
on macos / Version 13.5.2 (Build 22G91)
locale is en-US

The comment, as written, is documenting the class declaration, and that's probably why the dartdoc to forurene look for library tags on it.
(But they may want to complain about the library tag being applied to a class declaration.)
Even documenting the import is really a hack, since the comment refers to the library itself.
If you always add a library; declaration and put the doc-content on that, it should work. And should also be "more correct".

That worked, thank you.


GPU support

This toy model can be a prototype for offloading to GPU. This is easily achievable in MATLAB since every kernel operation is vectorized. It would take me more effort to achieve this in Julia, but definitely worth the attempt for future large projects.

#8

KernelAbstractions.jl


Pin to specific tier, phase 2

In this phase, we address the problem that some blocks may not be at the pinned desired medium.
This PR roughly includes:

Updates to blockMaster to include medium information and dirIndex so that we can reconstruct a BlockStoreLocation as the source location of the moveBlock command
Logic to determine which candidate to move to satisfy the pinning constraint

TODO:
Actually call the moveBlock function

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3687/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3694/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3703/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3724/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3725/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3726/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3730/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3735/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3736/
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3746/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3747/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3748/
Test FAILed.

jenkins, test this please

@calvinjia Addressed comments, PTAL, thanks.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3749/
Test PASSed.

@yuzhu Thanks for the update, I left some more comments.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3772/
Test PASSed.

alluxio-bot, merge this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3774/
Test PASSed.


which version of Detectron2 for detection to use?

hi, thank you for your job.
Could you please provide software version which you used for this job, such as torch, torchvision, detectron2, python, ...
Thanks!

For sure, here they are

Python - 3.7
PyTorch - 1.5.0 with torchvision - 0.6.0
Detectron2 -  Tree - 369a57d333

I have added these to README. Thanks very much.

For sure, here they are

Python - 3.7
PyTorch - 1.5.0 with torchvision - 0.6.0
Detectron2 -  Tree - 369a57d333

I have added these to README. Thanks very much.


All notes are gone. Where does note-taker store notes?

Question
All notes in note-taker are gone. I need to know the storage location to restore them from a backup.
I don't know when this happened because I didn't look for the notes for quite a while.
This #36 closed issue does not solve mine.
The problem with vanished notes is also mentioned a few times in the feedbacks on AMO.

Hello,
I'm very sorry that you lost your notes! Note Taker stores notes using the Webextension Storage API. The actual data on disk is stored in [firefox profile folder]/storage/default/moz-extension+++[extension uuid]^userContextId=4294967295/idb/3647222921wleabcEoxlt-eengsairo.sqlite (1). It should be noted that this SQLite file is compressed, so unless you know what you're doing you can't edit it directly. You should be able to restore from a backup, though.
If you don't know your Firefox profile location, you can find it listed on about:support. To find Note Taker's uuid, go to about:debugging, switch to the "This Firefox" tab, and find Note Taker on the list. The value you want is labeled "Internal UUID".


website: link to release history from the download page

https://golang.org/dl/ this page should have a link to release history page
https://golang.org/doc/devel/release.html

Is the too hard to implements? several days gone, not any more updates?

This is nobody's highest priority.

Can i make a pull request?
Just put one more line in the footer of the dl page. is that ok?
Please guide me, i would like to do this.

I am sorry, i can not find the source code of that page.

Reading the contributing documentation. We don't use Github Pull Requests, but we do take contributions happily. Unfortunately I think only @adg can fix this one. In the golang/tools repo, cmd/godoc/dl.go is a stub.

Thanks. I know it.

How about things going on? any update ?

Just spent 20 or so minutes looking through the various repositories for this file. It looks like it's not public. @adg, all yours.

This is done and will be live soon.

God, not more wait for two month, you guys awesome.


Grid: frozen selection column

The Java API is currently lacking an easy-to-use way of freezing a grid's selection (checkbox) column.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Update changelog for Release 2.2

Can one of the admins verify this patch?

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1824/
Test PASSed.


[Adjust Rule] SIM111 - Detect if another statement comes after the loop

Desired change

Rule(s): SIM111
Adjustment: Detect if another statement comes after the loop

Explanation
The below code is flagged with SIM111, but if I would would use the suggested code, the call_method call would be lost.
Example
for a in my_list:
  if a == 2:
    return False
call_method()
return True

Sorry that this took so long. I'll make a release with this fix today :crossed_fingers:


sha256 vs keccak

Why do you use sha256 instead of keccak256?

Bonded ECDSA keeps, in their first incarnation, are pretty strongly oriented towards backing tBTC deposits, so they're built with BTC parameters in mind. As a result, we sha256 preimages to get the digest for signatures. Bitcoin uses double-sha256, but to maintain a little more generality, ECDSA keeps use single sha256, and let the caller produce the preimage from the first sha256 external to the keep itself.
Supporting different digest functions for preimages is something we want to explore in future versions, particularly if we have specific use cases in mind, so we'd love to hear it if you have one!

Closing this issue due to inactivity. Please feel free to reopen if followup is needed.


Design main dashboard layout

MVP for design layout is done.
Adding and querying data from db is done.


cilium: Add knob for local address to be considered host id in ipcache

See commit msg.

/test

Seems that some mishap occurred with the review comments on this PR, but the gist of the thread is still here regarding the interface we're exposing to users: https://github.com/cilium/cilium/pull/19513/files#r855298767
I agree that if we have an option, both ways (string + int as backup) is better, but even better is not needing the configuration in the first place. This may need a bit more work internally though. We could potentially hide this and limit to just the advanced users who need it.

I think asking the user for the ENUM strings rather then the integer values on the CLI would be more intuitive to indviduals who don't know the mapping, but do know about RT_SCOPE. More of a nit, so approved.

Added both options (well-known string or number). And made it hidden now, too.

/test

/test

/test-1.23-net-next

GH action failures hit: https://github.com/cilium/cilium/issues/19526

GH action failures hit: #19526

Same also for Jenkins tests e.g.: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.22-kernel-4.19/1138/

(backported hf image build: https://github.com/cilium/cilium/pull/19531)

/test

(AKS conformance test currently known to fail)

(good to merge, travis seems stuck but has been green before with this change & nothing changed code-wise from commit itself)

@borkmann Unfortunately this broke ginkgo runs from macOS, as the netlink constants are only defined for Linux:
$ ginkgo --focus="Runtime" --tags=integration_tests -v
Failed to compile test:

# github.com/cilium/cilium/pkg/defaults
../pkg/defaults/defaults.go:18:24: undefined: netlink.SCOPE_LINK
# github.com/cilium/cilium/pkg/ip
../pkg/ip/ip.go:867:14: undefined: netlink.SCOPE_UNIVERSE
../pkg/ip/ip.go:869:14: undefined: netlink.SCOPE_NOWHERE
../pkg/ip/ip.go:871:14: undefined: netlink.SCOPE_HOST
../pkg/ip/ip.go:873:14: undefined: netlink.SCOPE_LINK
../pkg/ip/ip.go:875:14: undefined: netlink.SCOPE_SITE

Ginkgo ran 1 suite in 29.37218284s
Test Suite Failed

By the looks of it seems the test code is pulling in both pkg/defaults and pkg/ip, which now both only compile for Linux :-(
I was able to run my tests by reverting this commit first, but that is not a good solution long term. Not sure how this should be fixed.

I was able to run my tests by reverting this commit first, but that is not a good solution long term. Not sure how this should be fixed.

This can be fixed by moving the platform specific code to ip_linux.go, similar to other packages?

I was able to run my tests by reverting this commit first, but that is not a good solution long term. Not sure how this should be fixed.

This can be fixed by moving the platform specific code to ip_linux.go, similar to other packages?
Changes that this PR introduced in ip.go -> ip_linux.go.

Given these are UAPI constants maybe we can just manually define them instead of using netlink. @jrajahalme I can do a PR, but I don't use MacOS for development, so would need to rely on you for testing the PR.

@borkmann Heads up, you can use GOOS=darwin go build ... to validate the build on Linux, cf https://github.com/cilium/cilium/pull/15355

@borkmann Heads up, you can use GOOS=darwin go build ... to validate the build on Linux, cf #15355

Thanks, was not aware of this, could we have this as a GH action for CI? :)

SGTM. I think only test/ builds successfully on darwin today? But we can start with that, and if we get to a point where we make the main cilium-agent codebase buildable on darwin then we can extend the GH action to build that too.

/cc @Weil0ng for visibility.


[Clean] Removed await keyword where not required "The rewarder" test

Since attach here returns a Contract instance, not a promise, so, there is no need to use await.

Thanks, should be solved in v3 following your suggestion!


Use custom Mailer class for running tests

What steps will reproduce the problem?
I'm overriding Mailer class with my own and use it to create queue of emails.
When I run tests, it seems to be using another class (Codeception\Lib\Connector\Yii2\TestMailer).
What is the expected result?
Use custom Mailing class.
What do you get instead?
Exception with message for each test where mailing class with custom method myOwnMathod() is used:
[yii\base\UnknownMethodException] Calling unknown method: Codeception\Lib\Connector\Yii2\TestMailer::myOwnMathod()

Where myOwnMethod() is defined in my overriten mailer class, but as in tests it is using \yii\swiftmailer\Mailer, which certainly is missing that method.
Is there a way to set-up custom mailing class for tests?

Q
A

Yii version
2.0.12

PHP version
5.5+

Operating system
Ubuntu 14.04

I have the same problem https://github.com/Codeception/Codeception/issues/4011 when running the functional case, DavertMik mark it not a problem . so I temporary add the class in the $allowedOptions to use my own mailer class.

@bologer, you can use something like this Yii::$app->set('mailer', $mockMailer); in your test and codeception hardcoded version will not be called.

@bologer  you can try to  redefine the malier's class before the test case start
maybe in the _before function of the cest file
public function _before(CpdfapiTester $I){
\Yii::$app->set('mailer', 'app\common\components\Mailer');
\Codeception\Lib\Connector\Yii2::$mailer= \Yii::$app->get('mailer');
}
or you can new a extention file to listen the case start . http://codeception.com/docs/08-Customization
then do the redefine class in the beforeTest
the Extension file
 'beforeTest',
    );

    public function beforeTest(\Codeception\Event\TestEvent $e) {
        print_r('beforeTest call -----------------');
        \Yii::$app->set('mailer', 'app\common\components\Mailer');
        \Codeception\Lib\Connector\Yii2::$mailer= \Yii::$app->get('mailer');
    }
}

@JunelanMe this is nice, but it is kind of a work around.
@cebe , @samdark is there solutiuon Yii-like way to define custom mailing class for tests only?

@JunelanMe there is no need in both two lines in beforeTest method, each of the line gives the expected result but in a different way.
@bologer This is one of the way how you use DI containers, you're able to substitute implementations where you need it, in test environment, for example. So imho it will be preferable way.
Yii::$app->set('mailer', $mockMailer);

@StalkAlex, alright, when I try to make the following:
public function __before() {
    Yii::$app->set('mailer', 'common\models\mailer\Mailer');
}

I get the following error:
[ModuleException] Yii2: Mailer module is not mocked, can't test emails

I get the same error message if I put this:
Yii::$app->set('mailer', 'common\models\mailer\Mailer');

Inside of the test methods that use mailing class.
Any idea what is wrong with it?

@bologer here's green test:
class TestTest extends Unit
{
    public function _before()
    {
        Yii::$app->set('mailer', ['class' => 'tests\codeception\_extensions\TestMailer']);
    }

    public function testIntanceIsValid()
    {
        $test = Yii::$app->get('mailer');
        expect_that($test instanceof TestMailer);
    }
}

Exception says that there is a problem with you configuration. In yii module there are different parts that can be included: init, orm, email and fixtures. Check those. I'm using last Codeception and Yii2 versions.

@StalkAlex, thank you very much! It worked.

hello


Add missing CTYPES imports

The ctypes.patch file breaks the check function by removing several
imports, add them back in. Also add a test to check CF compiance of a
file (over OPeNDAP to avoid downloading data)

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

The failure in Travis appears to be from udunits getting an incorrect units file - degC and degrees_east are both valid units in https://github.com/Unidata/UDUNITS-2/blob/master/lib/udunits2-common.xml. I don't have access to a Mac to debug further

It is quite odd that the units tests  are passing on Linux and failing on OS X. But the bigger problem is that segfault at the end :confused:

Closing in favor of #5


[TCGC]: make sure discriminator is the 1st property

Clear and concise description of the problem
Moving discriminator to the beginning of properties array could bring benefits in performance and code simplicity for backend services. See the discussion in this issue: https://github.com/Azure/autorest.csharp/issues/4439
Sequence of properties defined in TCGC will impact the JSON payload sent by SDKs. For backend services, the JSON frameworks they use might require discriminator is always the 1st property. Otherwise, a custom deserializer is required.
Checklist

[X] Follow our Code of Conduct
[X] Check that this issue is about the Azure libraries for typespec. For feature request in the typespec language or core libraries file it in the TypeSpec repo
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

.net confirmed with customer that they will not do that explicitly. so also close for tcgc.


0153 m retry with clipped rate on exchange change limit exceeded

Related issue(s):
Closes #150, #151, #152, #153, #154
Summary of the change:
ERT on exchange change limit exceeded now tries to do a weighted mean of the calculated rate [Goal rate] and the rate that the network is working with.
Retry mechanism has been reworked.
Applicable documentation

[x] Javadoc
[x] tests
[x] README

Please, set up a build for this project in circleci and add SonarQube

Please, set up a build for this project in circleci and add SonarQube

Thanks for the review @cesaragv. Circle CI is setup for this here


Enable hermetic sandbox

With the sandboxroot, we should now - in theory - be able to turn on --experimental_use_hermetic_linux_sandbox, which starts with an empty mount namespace instead of mounting the sandbox dirs on top of the host directories.
This is currently thwarted by a rules_go bug:
https://github.com/bazelbuild/rules_go/issues/1910

I was getting go: cannot find GOROOT directory: /usr/local/go and I debugged a bit further.
Turns out this is because Go needs a GOROOT, and it either runtime find one, or falls back to /usr/local/go. The runtime detection relies on reading /proc/self/exe, and in our experimental hermetic builds we simply weren't mounting /proc.
Adding --sandbox_add_mount_pair=/proc:/proc gets us further on this.


test pr

For reference this was to test what permissions are necessary to change the base branch of a PR. See https://discord.com/channels/691052431525675048/745355529777315850/867485393523572757 on the bevy discord.


Running nvidia-smi multiple time is causing to hanging for GPU

Hello, Thank you for the great work.
First of all this not a bug report! It's related with Nvidia drivers and I'm just informing.. The story is,
We are using tool for a while. After last nvidia update unfortunately we are facing some troubles. No problem with the newer GPU's but the old ones hanging after calling nvidia-smi. Is anyone faced this weird problem in these days?
GPU: RTX Titan, driver version 450.80.02 and kernel is modules/5.4.0-124-generic

Hi, thank you for using the tool and for the information.
I haven't heard about this issue until now. I'll keep this issue open for a while so that it has some visibility. In the meantime, if you have new findings, they are the most welcome.

I think it is time to close this one. Feel free to share if you have some findings.

Hi again Utku. After I while I back to suggest one thing. I relalized not matter what the linux kernel is provided nvidia driver causing some hanging on GPU if we call nvidia-smi multiple times in a minute. So I'm wondering maybe we can add option to set the scrape interval here. From my observation x4 Titan RTX with driver 525 and  RTX  3090 with driver 530 causing the problem. Also realized that a5000 is okay with 525 from my testings.
If anyone wants to simulate the issue, do this, while running an training on GPU try to run nvidia-smi with watch command.

Hi, the exporter itself does not do any nvidia-smi calls by itself. Scraping is done externally - you can configure it on prometheus side. At each request to /metrics (a scrape), nvidia-smi will be called.

That's great, I'll set related opiton on prometheus side, if it solve the issue I'll update the issue again. Thank you so much Utku


Incorrect 'build a bot' & 'SDKs' redirection link

In this page, please update below yellow marked hyperlinks to proper document,

build a bot: https://learn.microsoft.com/en-us/microsoftteams/platform/bots/what-are-bots
SDKs: https://learn.microsoft.com/en-us/azure/bot-service/bot-service-overview?view=azure-bot-service-4.0
Additionally in this page also we suggest to update the SDKs hyperlink to this below:
https://learn.microsoft.com/en-us/azure/bot-service/bot-service-overview?view=azure-bot-service-4.0

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0f624483-2f5e-3f44-ed7c-10819221fd34
Version Independent ID: 0f624483-2f5e-3f44-ed7c-10819221fd34
Content: Build extensible conversation for meeting chat - Teams
Content Source: msteams-platform/apps-in-teams-meetings/build-extensible-conversation-for-meeting-chat.md
Service: msteams
GitHub Login: @v-sdhakshina
Microsoft Alias: v-sdhakshina

Hi @surbhigupta12 - Could you please help here to update the doc as mentioned?


Konflux update test-component-pac-hcssmd

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-hcssmd-on-pull-request has successfully validated your commit.
Namespace: build-e2e-okxw-tenant
PipelineRun: test-component-pac-hcssmd-on-pull-request-lhdg2

Task Statuses:

StatusDurationName

✅ Succeeded
5 seconds
init

✅ Succeeded
23 seconds
clone-repository

✅ Succeeded
57 seconds
build-container

✅ Succeeded
18 seconds
sast-snyk-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
57 seconds
clamav-scan

✅ Succeeded
19 seconds
deprecated-base-image-check

✅ Succeeded
23 seconds
apply-tags

✅ Succeeded
17 seconds
push-dockerfile

✅ Succeeded
19 seconds
sbom-json-check

✅ Succeeded
25 seconds
ecosystem-cert-preflight-checks

✅ Succeeded
10 seconds
show-sbom

✅ Succeeded
23 seconds
show-summary

Pipelines as Code CI/test-component-pac-hcssmd-on-pull-request has successfully validated your commit.
Namespace: build-e2e-okxw-tenant
PipelineRun: test-component-pac-hcssmd-on-pull-request-27g6b

Task Statuses:

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
14 seconds
clone-repository

✅ Succeeded
25 seconds
build-container

✅ Succeeded
18 seconds
sbom-json-check

✅ Succeeded
7 seconds
push-dockerfile

✅ Succeeded
23 seconds
ecosystem-cert-preflight-checks

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
9 seconds
sast-snyk-check

✅ Succeeded
19 seconds
apply-tags

✅ Succeeded
9 seconds
deprecated-base-image-check

✅ Succeeded
14 seconds
clair-scan

✅ Succeeded
7 seconds
show-sbom

✅ Succeeded
16 seconds
show-summary


msp_random_template.pkl is missing

I am trying to run the training code , msp_random_template.pkl file is not in the dataset directary. It is looking for sentences which are not in other .pkl files. Please guide me in this regard

you can generate it by using MSP60K_Benchmark_Dataset/LLM-PAR/PAR_Template_Scripts


Disjoint Union not working when variant portion of union type is seperated

I'm having an issue with Disjoint Unions, I can reproduce the issue on v0.30 and v0.31. Think its a bug but maybe I'm doing something dumb. Any help would be awesome!
I here is a generalised/contrived version of the code that I'm trying to typecheck
type Bicycle = {
  wheels: 2;
};

type Unicycle = {
  wheels: 1;
};

type Car = {
  wheels: 4;
};

type Vehicle =
  | Bicycle
  | Unicycle
  | Car;

type WheelCount =
  | 1
  | 2
  | 4;

const wheels: WheelCount = 1;
const vehicle: Vehicle = {
  wheels
};

However I get the following flow error
 26: const vehicle: Vehicle = {
                              ^ object literal. This type is incompatible with
 26: const vehicle: Vehicle = {
                    ^^^^^^^ union: Bicycle | Unicycle | Car
  Member 1:
   16:   | Bicycle
           ^^^^^^^ Bicycle
  Error:
   27:   wheels
         ^^^^^^ number literal `1`. Expected number literal `2`, got `1` instead
    4:   wheels: 2;
                 ^ number literal `2`
  Member 2:
   17:   | Unicycle
           ^^^^^^^^ Unicycle
  Error:
   27:   wheels
         ^^^^^^ number literal `2`. Expected number literal `1`, got `2` instead
    8:   wheels: 1;
                 ^ number literal `1`
  Member 3:
   18:   | Car;
           ^^^ Car
  Error:
   27:   wheels
         ^^^^^^ number literal `1`. Expected number literal `4`, got `1` instead
   12:   wheels: 4;
                 ^ number literal `4`

If I change the line const wheels: WheelCount = 1; to const wheels = 1; it type checks ok.
However I want WheelCount as a seperate type so that I can type check this part of the code without needing a full vehicle object

You're intuition here is good. The reason this is an error is due to the invariance of object property types.
Here's a smaller example that might make the problem clearer:
/* @flow */
var p: 0 | 1 = 0;
var o: { p: 1 } = { p }

3: var o: { p: 1 } = { p }
                       ^ number literal `0`. Expected number literal `1`, got `0` instead
3: var o: { p: 1 } = { p }
               ^ number literal `1`

When I say that object properties are invariant, I mean that for any two object types O1 = { P: P1 } and O2 = { P: P2 }, then O2 <: O1 if P2 <: P1 and P1 <: P2.
If objects were covariant, then O2 <: O1 if P2 <: P1 only. And if they were contravariant then O2 <: O1 if P1 <: P2 only.

@samwgoldman thanks for the response!
I understand why our example doesn't type check but shouldn't the following type check?
var p: 0 | 1 = 0;
var o: { p: 0 } | { p: 1 } = { p }

 59: var o: { p: 0 } | { p: 1 } = { p }
                                  ^^^^^ object literal. This type is incompatible with
 59: var o: { p: 0 } | { p: 1 } = { p }
            ^^^^^^^^^^^^^^^^^^^ union: object type(s)
  Member 1:
   59: var o: { p: 0 } | { p: 1 } = { p }
              ^^^^^^^^ object type
  Error:
   59: var o: { p: 0 } | { p: 1 } = { p }
                                      ^ number literal `1`. Expected number literal `0`, got `1` instead
   59: var o: { p: 0 } | { p: 1 } = { p }
                   ^ number literal `0`
  Member 2:
   59: var o: { p: 0 } | { p: 1 } = { p }
                         ^^^^^^^^ object type
  Error:
   59: var o: { p: 0 } | { p: 1 } = { p }
                                      ^ number literal `0`. Expected number literal `1`, got `0` instead
   59: var o: { p: 0 } | { p: 1 } = { p }
                              ^ number literal `1`

Have also tried using the new $PropertyType but it produces the same error
/* @flow */
type O = { p: 0 } | { p: 1 };
type P = $PropertyType<O, 'p'>;

var p: P = 0;
var o: O = { p };

I think what happens is that flow tries to choose a single branch in such cases, but no branch matches


Table of contents: TOC selection bar does not stick to top of the page.

Detailed description
On Mobile & tabs
On react-staging, NextJS pages
Issue: Table of contents, selection bar does not stick to top of the page.
Additional information

This looks like a duplicate and @kennylam closed it in this issue


Bookshelf should accept query for book

And return the correct book instance.

My branch now contains the "getBookTitlesByKeyword" which accepts a string parameter.  The keyword is not case sensitive.  Cities = cities

Yeah, I looked at it. I am just making these feature issues as we go, so that we can close them and track completion of milestones with nice graphs :+1:
I will close it now.


Update PR template to add documentation-related checks

I updated the PR template to include various documentation-related checks on the checklist.

Looks great, @altheaden!  Merge once CI passes.


BUG: Time series Line chart has broken

Make sure these boxes are checked before submitting your issue - thank you!

[ x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[x ] I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version
0.28.1
Expected results
Should able to visualize
Actual results
blank page
in Log file:
2019-03-06 17:13:09,123:ERROR:root:'__timestamp'
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/superset/views/core.py", line 1149, in generate_json
payload = viz_obj.get_payload()
File "/usr/local/lib/python3.6/site-packages/superset/viz.py", line 371, in get_payload
payload['data'] = self.get_data(df)
File "/usr/local/lib/python3.6/site-packages/superset/viz.py", line 1212, in get_data
df = self.process_data(df)
File "/usr/local/lib/python3.6/site-packages/superset/viz.py", line 1132, in process_data
values=self.metric_labels)
File "/usr/local/lib/python3.6/site-packages/pandas/core/frame.py", line 5303, in pivot_table
margins_name=margins_name)
File "/usr/local/lib/python3.6/site-packages/pandas/core/reshape/pivot.py", line 86, in pivot_table
grouped = data.groupby(keys, observed=False)
File "/usr/local/lib/python3.6/site-packages/pandas/core/generic.py", line 6665, in groupby
observed=observed, **kwargs)
File "/usr/local/lib/python3.6/site-packages/pandas/core/groupby/groupby.py", line 2152, in groupby
return klass(obj, by, **kwds)
File "/usr/local/lib/python3.6/site-packages/pandas/core/groupby/groupby.py", line 599, in init
mutated=self.mutated)
File "/usr/local/lib/python3.6/site-packages/pandas/core/groupby/groupby.py", line 3291, in _get_grouper
raise KeyError(gpr)
KeyError: '__timestamp'
Steps to reproduce
Time series line chart was used to work and able to visualize the data. With released version, none of time series line char works. The database is Snowflake. It always throws the following
2019-03-06 17:13:09,123:ERROR:root:'__timestamp'
Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/superset/views/core.py", line 1149, in generate_json
payload = viz_obj.get_payload()
File "/usr/local/lib/python3.6/site-packages/superset/viz.py", line 371, in get_payload
payload['data'] = self.get_data(df)
File "/usr/local/lib/python3.6/site-packages/superset/viz.py", line 1212, in get_data
df = self.process_data(df)
File "/usr/local/lib/python3.6/site-packages/superset/viz.py", line 1132, in process_data
values=self.metric_labels)
File "/usr/local/lib/python3.6/site-packages/pandas/core/frame.py", line 5303, in pivot_table
margins_name=margins_name)
File "/usr/local/lib/python3.6/site-packages/pandas/core/reshape/pivot.py", line 86, in pivot_table
grouped = data.groupby(keys, observed=False)
File "/usr/local/lib/python3.6/site-packages/pandas/core/generic.py", line 6665, in groupby
observed=observed, **kwargs)
File "/usr/local/lib/python3.6/site-packages/pandas/core/groupby/groupby.py", line 2152, in groupby
return klass(obj, by, **kwds)
File "/usr/local/lib/python3.6/site-packages/pandas/core/groupby/groupby.py", line 599, in init
mutated=self.mutated)
File "/usr/local/lib/python3.6/site-packages/pandas/core/groupby/groupby.py", line 3291, in _get_grouper
raise KeyError(gpr)
KeyError: '__timestamp'

This has been fixed quite a while ago, the 0.31 release candidate works well with Snowflake.

@villebro: Thanks. Please, can you let me know the PR for this fix?

@mmuru The main fix was #5827 which is in the 0.31 RC.

@villebro I tried out 0.31 RC It still has the same __timestamp bug when using Snowflake with Time-series bar charts. This is the detailed error report:
Traceback (most recent call last):
  File "/home/superset/superset/views/base.py", line 114, in wraps
    return f(self, *args, **kwargs)
  File "/home/superset/superset/views/core.py", line 1229, in explore_json
    samples=samples,
  File "/home/superset/superset/views/core.py", line 1160, in generate_json
    payload = viz_obj.get_payload()
  File "/home/superset/superset/viz.py", line 375, in get_payload
    payload['data'] = self.get_data(df)
  File "/home/superset/superset/viz.py", line 1223, in get_data
    df = self.process_data(df)
  File "/home/superset/superset/viz.py", line 1143, in process_data
    values=self.metric_labels)
  File "/usr/local/lib/python3.6/site-packages/pandas/core/frame.py", line 5303, in pivot_table
    margins_name=margins_name)
  File "/usr/local/lib/python3.6/site-packages/pandas/core/reshape/pivot.py", line 86, in pivot_table
    grouped = data.groupby(keys, observed=False)
  File "/usr/local/lib/python3.6/site-packages/pandas/core/generic.py", line 6665, in groupby
    observed=observed, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/pandas/core/groupby/groupby.py", line 2152, in groupby
    return klass(obj, by, **kwds)
  File "/usr/local/lib/python3.6/site-packages/pandas/core/groupby/groupby.py", line 599, in __init__
    mutated=self.mutated)
  File "/usr/local/lib/python3.6/site-packages/pandas/core/groupby/groupby.py", line 3291, in _get_grouper
    raise KeyError(gpr)
KeyError: '__timestamp'

That's very strange, I will check what's going on. @mmuru were you able to get Snowflake timeseries working on 0.31 RC?

@villebro: I tested it with master and worked as expected. I did not test against 0.31 RC branch.

Thanks for the help @mmuru. @yuguang, I was unable to reproduce the error on release--0.31 branch; tested Time Series Bar Chart, Line Chart and Area Chart and all worked fine both with and without timegrains.

@yuguang do check that you're on a fresh version of snowflake-sqlalchemy. There was a regression in 1.1.2 I believe that was fixed around 1.1.4(I think) which messed with forced quoting, and would produce a similar error.

@villebro I am on snowflake-sqlalchemy==1.1.11. I will try to reproduce the bug again on 0.31 RC and check the version there.

The dataframe being returned from the queries had uppercase column names, __TIMESTAMP was one of them. I was able to fix the 0.31 RC code by checking for the uppercase column name.

Can you check if the __timestamp alias has quotes around it on the query? If not then I can't really think of any other explanation than the superset installation not being 0.31 or something being wrong with the snowflake-sqlalchemy version.

@villebro The query does have quotes around __timestamp. I made a screen recording which shows the error and also the snowflake-sqlalchemy version:

Hmm, very strange indeed. Make sure you have updated versions of all libraries, especially snowflake-connector-python. Also copy the query from Superset and run it via the Snowflake web UI to check what case is returned for the __timestamp column. Quotes around the alias should ensure that the result has case sensitive headers: https://community.snowflake.com/s/article/faq-when-i-retrieve-database-schema-table-or-column-names-why-does-snowflake-display-them-in-uppercase

I have the latest libraries, snowflake-connector-python-1.7.9 and snowflake-sqlalchemy-1.1.11. When I run the query in the Snowflake web UI, it returns the columns in all caps. __TIMESTAMP is one of them. I have a fix for this, so I will make a pull request for 0.31. The bug was not reproducible on master.
The query generated is
SELECT DATE_TRUNC('DAY', CHECK_IN_TIME) AS "__timestamp",
       COUNT(DISTINCT "INSTANCE3") AS "COUNT_DISTINCT(INSTANCE3)"
FROM
  (SELECT *
   FROM emory.public.raw_er) AS expr_qry
WHERE "CHECK_IN_TIME" >= '1919-03-27 00:00:00'
GROUP BY DATE_TRUNC('DAY', CHECK_IN_TIME)
ORDER BY "COUNT_DISTINCT(INSTANCE3)" DESC
LIMIT 1000;

I did a quick search, it seems your account has been set to ignore case sensitive column names even if they are quoted:

https://docs.snowflake.net/manuals/sql-reference/identifiers-syntax.html#label-identifier-casing
https://docs.snowflake.net/manuals/sql-reference/parameters.html#label-quoted-identifiers-ignore-case

While this isn't perhaps something that I would recommend doing, there are a few ways around this, but the universal solution would be to just force labels to UPPERCASE similarly to how Redshift forces everything to lowercase. This doesn't affect the user experience in Superset in any way (metrics etc will still support MixedCase), only slightly changes how the query is rendered.

Thanks! You mean that setting QUOTED_IDENTIFIERS_IGNORE_CASE to False is the recommended solution?

Since other people also reported this bug with __timestamp, can I add a blue note box in the documentation for Snowflake about this?

Did changing the parameter work? I think there are two options:

Add a note to the documentation that QUOTED_IDENTIFIERS_IGNORE_CASE needs to be set to False. This is what I believe the majority of users are doing anyway.
Change the spec for Snowflake to always uppercase column labels.

I'm kind of leaning towards the second option, as it makes Snowflake "just work" out of the box in both cases, has no adverse effects (other than making the labels in queries look VERY_LOUD), and makes it easier to get Superset working. Thoughts?

If option 2 is implemented, would the chart building UI be showing all upper case columns?

No, beyond what is seen in the query window everything remains unchanged. Were you able to change the parameter value and solve your immediate problem?

@yuguang btw, if you don't want to change the settings in your SF account you can disable the setting for your Superset session by adding the following in the Extra field in your database settings:
"engine_params": {"connect_args": {"session_parameters": {"QUOTED_IDENTIFIERS_IGNORE_CASE": false}}}

The code change I made in the pull request fixed the issue for us. I would rather not set the session parameters for 16 different Snowflake databases

Ok. I think you will run into the same problem using at least the NVD3DualLineViz and PairedTTestViz visualizations, as they also perform a pivot using DTTM_ALIAS. A slightly more generic solution (in addition to my proposal above) would be to add the following method to SnowflakeEngineSpec in db_engine_specs.py:
    @staticmethod
    def mutate_label(label):
        return label.upper()

This should solve all symptoms of using QUOTED_IDENTIFIERS_IGNORE_CASE=True. As stated, the above is no longer necessary in forthcoming versions after 0.31, so it doesn't make sense to merge it to master, but might make your installation work better.

Thanks. Do you want to make a pull request for 0.31, since you are more familiar with the code?

Given that the need for this change is the result of having explicitly disabled regular quoting functionality on account/user/session level, and can be re-enabled in Superset by adjusting engine_params, I'm not sure this needs to go into the 0.31 branch. But if there is a more general need for this I can certainly make a PR for it.

I think, it should rebase with master to get latest since this ain't an issue anymore in master.

On Apr 2, 2019, at 6:39 AM, Ville Brofeldt<EMAIL_ADDRESS>wrote:
Given that the need for this change is the result of having explicitly disabled regular quoting functionality on account/user/session level, and can be re-enabled in Superset by adjusting engine_params, I'm not sure this needs to go into the 0.31 branch. But if there is a more general need for this I can certainly make a PR for it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


GitHub Authenticator identification

Dev Home version
<IP_ADDRESS>
Windows build number
10.0.23466.1001
Other software
OS Build Version: 10.0.23466.1001.amd64fre.ni_prerelease.230522-1422
.NET Version: .NET 6.0.16
Steps to reproduce the bug
When I connected my GitHub account I authenticated using the authenticator on my phone.  The authentication flow asked me on my iPhone to enter the number shown in the browser on my PC.  The authentication dialog identified itself incorrectly.
Expected result
It feels like the authentication request phone popup should have been more on-brand.
Actual result
Phone prompt dialog said something like "Sudo" account...  I understand what it meant, but I worry a less experienced developer might be scared off by it.
Included System Information
CPU: 11th Gen Intel(R) Core(TM) i9-11900H @ 2.50GHz
Physical Memory: 15.73GB (3.27GB free)
Processor Architecture: x64
Included Extensions Information
Extensions:
Microsoft.Windows.DevHome_<IP_ADDRESS>_x64__8wekyb3d8bbwe
Microsoft.Windows.DevHomeGitHubExtension_<IP_ADDRESS>_x64__8wekyb3d8bbwe

It probably said "sudo mode" which just means that you give devhome some more capabilites to make certain things.

Yes, I think that was it...  I would have expected it to have some kind of clear indication/reference that it was related to connecting to Dev Home. Without the clear ref, I momentarily worried that this might be some kind of MitM concern.

@GraniteStateHacker I believe that is GitHub's own authentication UI. See https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/sudo-mode

Agreed this sounds out of the control of Dev Home.


Align X and Y margins same to chat

Tasks

[ ] main,translate画面のmarginをchat画面に合わせる

Writing the Issue

[x] Write each task for this issue using checkboxes
[x] Write all verbal instructions as tasks

Before Working on the Issue

[x] Assign yourself
[x] Share your screen on Discord
[x] Write which issue you are starting on Slack
[ ] Git: Fetch the latest main
[ ] Git: Create a branch with the name of the issue

Pre-PR Checks

[ ] Insure that changes include only what is necessary for this PR
[ ] Implement necessary Unit tests
[ ] Implement necessary E2E tests
[ ] Perform functionality checks

#1019


Fix/smap da soil temp bug fix

Soil Temperature Bias in Soil Moisture Data Assimilation
In soil moisture data assimilation (DA), we remove biases from soil moisture, which include biases arising from perturbed forcing and perturbation of state variables (soil moisture). However, biases may still persist in other states.
Our investigation shows that the bias in soil temperature is due to state perturbation.
In the DA code, if DA does not occur, we remove the bias from soil moisture. However, we need an additional check to prevent perturbing the state variables if the DA flag (i.e., frozen ground) prevents assimilation. This is particularly important for higher latitudes where the ground freezes during cold seasons. Without this new flag, perturbations in soil moisture can propagate to soil temperature, even when DA does not occur due to frozen ground conditions. Consequently, although we remove the bias from soil moisture since DA does not take place, the bias in soil temperature remains. Therefore, it is crucial to check the frozen ground condition before applying perturbations.
Replace this text with a concise description of what was changed and why.
Resolves #1356
Testcase
Test case for Noah39
/discover/nobackup/projects/usaf_lis/mnavari/AF/SoilMoisture_DA/testcases/pr/noah39/sim
lis.config.da.af.frozen.soil.check
job.DA.frozen.soil.check
Matlab code to plot the results
/discover/nobackup/projects/usaf_lis/mnavari/AF/SoilMoisture_DA/testcases/pr/noah39/analysis/Matlab_code
Read_LIS_2d_ensemble_gridspace_plot_TS_SoilT_Check.m

Test cases for other LSMs are under development.
Test case for NoahMP401
Test case for Jules50
Test case for Noah36

Pending Mahdi's and Armaghan's final testing.
This should be merged into the master branch - not support/lisf-557ww-7.5.

Hi Jim,
It should be merged into the support branch. Because it also affects the Jules50.
Thanks
Mahdi
From: James Geiger @.>
Reply-To: NASA-LIS/LISF @.>
Date: Wednesday, July 19, 2023 at 11:49 AM
To: NASA-LIS/LISF @.>
Cc: "Navari, Mahdi (GSFC-617.0)[UNIV OF MARYLAND COLLEGE PARK]" @.>, Author @.***>
Subject: [EXTERNAL] [BULK] Re: [NASA-LIS/LISF] Fix/smap da soil temp bug fix (PR #1385)
CAUTION: This email originated from outside of NASA.  Please take care when clicking links or opening attachments.  Use the "Report Message" button to report suspicious messages to the NASA SOC.
Pending Mahdi's and Armaghan's final testing.
This should be merged into the master branch - not support/lisf-557ww-7.5.
—
Reply to this email directly, view it on GitHubhttps://github.com/NASA-LIS/LISF/pull/1385#issuecomment-1642341067, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKNKXD6YDCM3DIPDZBOKW6DXQ76WPANCNFSM6AAAAAA2PK4P5Q.
You are receiving this because you authored the thread.Message ID: @.***>

Thanks Mahdi.  The lis/surfacemodels/land/jules.5.0/da_soilm/ files are also in the master branch and keep up to date with the files in the support/lisf-557ww-7.5 branch.

Here are the results for:
########################################
Test case for Noah36
/discover/nobackup/projects/usaf_lis/aabedelm/AF/SoilMoisture_DA/testcases/pr/noah36/sim
lis.config.da.af.frozen.soil.check
job.DA.frozen.soil.check
Matlab code to plot the results
/discover/nobackup/projects/usaf_lis/aabedelm/AF/SoilMoisture_DA/testcases/pr/noah36/analysis/Matlab_code
Read_LIS_2d_ensemble_gridspace_plot_TS_SoilT_Check.m

########################################
Test case for JULES5
/discover/nobackup/projects/usaf_lis/aabedelm/AF/SoilMoisture_DA/testcases/pr/jules5/sim
lis.config.da.af.frozen.soil.check
job.DA.frozen.soil.check
Matlab code to plot the results
/discover/nobackup/projects/usaf_lis/aabedelm/AF/SoilMoisture_DA/testcases/pr/jules5/analysis/Matlab_code
Read_LIS_2d_ensemble_gridspace_plot_TS_SoilT_Check.m

########################################
Test case for noahmp401
/discover/nobackup/projects/usaf_lis/aabedelm/AF/SoilMoisture_DA/testcases/pr/noahmp401/sim
lis.config.da.af.frozen.soil.check
job.DA.frozen.soil.check
Matlab code to plot the results
/discover/nobackup/projects/usaf_lis/aabedelm/AF/SoilMoisture_DA/testcases/pr/noahmp401/analysis/Matlab_code
Read_LIS_2d_ensemble_gridspace_plot_TS_SoilT_Check.m

Summary of the works:
Upon reviewing Armaghan's results and test cases, I've noticed that the results for Noah39 are not accurate. Even after the second bug fix, there are still some residual biases in the SM field.
Regarding Jules, unfortunately, she did not run any DA. In the DA config file, she set the data assimilation instant to zero (no DA), and she did not generate the CDFs. Her DA runs are actually OL (in the 2D ensemble space). This is the reason she reported an exact match between soil moisture and soil temperature before and after the bug fix.
================================================================================
Three bug fixes were applied to address issues observed in the NoahMP401 and Noah39 SM DA results:
1- A soil temperature check was implemented to prevent updating the state variable if the ground is frozen.
2- The ensemble flag issue was resolved.
3- A condition was added to compute the delta (sum of the difference between unperturbed ensemble and other ensembles) using total soil moisture (smc) if the ground is frozen, instead of the liquid part of soil moisture (sh2o).
Results for NoahMP401

Spatial Mean of Soil Moisture for the 1st soil layer.

Spatial Mean of Soil Temperature for the 1st soil layer.

Temporal Mean of Soil moisture for Ensemble #12 (left panels), Ensemble Mean (middle panels), and difference (right panels) for DA test cases: Before Bug Fix (top row), After Soil Temperature Check Bug Fix (middle row), After Soil Temperature and Ensemble Flag Bug Fix, and Applying 3rd bug fix (bottom row).

Temporal Mean of Soil Temperature for Ensemble #12 (left panels), Ensemble Mean (middle panels), and difference (right panels) for DA test cases: Before Bug Fix (top row), After Soil Temperature Check Bug Fix (middle row), After Soil Temperature and Ensemble Flag Bug Fix, and Applying 3rd bug fix (bottom row).
Results for Noah39

Spatial Mean of Soil Moisture for the 1st soil layer.

Spatial Mean of Soil Temperature for the 1st soil layer.

Temporal Mean of Soil moisture for Ensemble #12 (left panels), Ensemble Mean (middle panels), and difference (right panels) for DA test cases: Before Bug Fix (top row), After Soil Temperature Check Bug Fix (middle row), After Soil Temperature and Ensemble Flag Bug Fix, and Applying 3rd bug fix (bottom row).

Temporal Mean of Soil Temperature for Ensemble #12 (left panels), Ensemble Mean (middle panels), and difference (right panels) for DA test cases: Before Bug Fix (top row), After Soil Temperature Check Bug Fix (middle row), After Soil Temperature and Ensemble Flag Bug Fix, and Applying 3rd bug fix (bottom row).
Test cases
1- NoahMP401
/discover/nobackup/projects/usaf_lis/mnavari/AF/SoilMoisture_DA/testcases/pr/noahmp401/sim
lis.config.da.af.3bug_fix
job.DA.3bug_fix
Matlab code to produce figures
/discover/nobackup/projects/usaf_lis/mnavari/AF/SoilMoisture_DA/testcases/pr/noahmp401/analysis/Matlab_code/Read_LIS_2d_ensemble_gridspace_plot_TS_SoilT_Check_ens_flag_fix_sh2o2smc_fix.m
2- Noah39
/discover/nobackup/projects/usaf_lis/mnavari/AF/SoilMoisture_DA/testcases/pr/noah39/sim
lis.config.da.af.3bug_fix
job.DA.3bug_fix
Matlab code to produce figures
/discover/nobackup/projects/usaf_lis/mnavari/AF/SoilMoisture_DA/testcases/pr/noah39/analysis/Matlab_code/Read_LIS_2d_ensemble_gridspace_plot_TS_SoilT_Check_ens_flag_fix_sh2o2smc_fix.m

This is ready for review.  We will also have to cherrypick/rebase to target for LISF 7.6

Hi @LIS-navari
I do not have read permission for lis.config.da.af.3bug_fix for NoahMP, nor for Noah.  Can you please update the file permissions to give us access?

Hi @emkemp
Sorry for that. Please try now.

Thanks @LIS-navari
I'm running the two test cases now on the Milan nodes.

Update:  My noah39 run timed out before completing the full range of data in the evaluation.  I saved the output and am rerunning with a longer runtime.
The NoahMP run covers the full period. I will work today on learning how to run the Matlab script.

@LIS-navari
I'm having trouble running your noahmp matlab script.  (I actually copied and renamed it to change the work directory.) I do get time series plots, but when the script starts plotting the maps of Alaska it throws an error:
Error using load
Unable to find file or directory 'coast'.
Error in matlab (line 370)
load coast ; geoshow(lat,long,'DisplayType', 'line','Color','k','linewidth', 1.5)
Error in run (line 99)
evalin('caller', strcat(script, ';'));
Any suggestions for a workaround?  I'm using module matlab/R2023b.

Hi @emkemp,
I utilized MATLAB/R2020a. If it doesn't work, feel free to comment out that line. It plots the border.

An update:  I'm continually running into a problem with insufficient licenses for the MAP_Toolbox.  I can make timeseries plots at the two locations specified in script provided by @LIS-navari, but the surface cross-sections are never drawn.
So far I have partial results for NoahMP.  I'm going to pivot to Noah.

Hi @LIS-navari
My latest attempt at creating surface plots failed for a new reason:  I do not have read permission to /gpfsm/dnb33/mnavari/my_projects/matlab/functions/b2r.m.  Can you please update the permissions?

Hi @emkemp,
Please give it another try. I've granted permission to all Matlab functions now.
Thanks!

Thanks @LIS-navari
The scripts run now.  I'm studying the plots.

Hello @jvgeiger
Yes, I used them for print statements. you can delete those lines.
Thanks,
Mahdi


check frequency boost support on Arm

Signed-off-by: Bin Lu<EMAIL_ADDRESS>

@balajismaniam
Hi,
Plz check it. Git rebase done.

@marquiz
Done.
Plz check it.
Thanks.

@marquiz
WOW~~~~
Thanks for your reminder, and sorry to bother you.
Please check it.
Thanks.

@marquiz
Is it OK ?
Thanks.

Looks good to me, now. Ping @balajismaniam

I think we could merge this. @lubinsz: please rebase on latest master

@lubinsz, please rebase and I'll merge this

@marquiz
Rebase was done, please check it.
Thanks.

Thanks! Merging was delayed because of my vacation


Asset manager raises a critical error reading the home controller

ovehub-ove-asset-manager_1       | crit: OVE.Service.AssetManager.Controllers.HomeController[0]
ovehub-ove-asset-manager_1       |       Read Index page

fixed in https://github.com/ove/ove-asset-services/pull/36


rapidly opening and closing /pfs/out in a spout can cause it to miss data

What happened?:
I wrote a spout that doesn't open /pfs/out until it sees one datum, then writes the datum, closes /pfs/out, and processes the next datum until the queue is empty. When the datums would come in at a rate of less than 100ms apart or so, the spout started missing data.  This was particularly a problem on launch, if there was data in the queue.  Adding a delay after closing /pfs/out of over 150ms seemed to solve the issue.
What you expected to happen?:
I expected data to be processed at speed correctly.
How to reproduce it (as minimally and precisely as possible)?:

Create a spout that reads a data source one line time, opening /pfs/out, writing the line of data to a file, and closing /pfs/out. (Mine read a kafka queue, source attached along with various logs).
Add data to the file more rapidly than one line per 100ms.
Datums will be missed.

Anything else we need to know?:
My script for creating the cluster, my spout code, and logs are attached.  I'm going to check all my source into examples/spouts/go-kafka-spout as a PR for @JoeyZwicker to review.
Environment?:

Kubernetes version (use kubectl version): 1.13
Pachyderm CLI and pachd server version (use pachctl version): 1.9.8
Cloud provider (e.g. aws, azure, gke) or local deployment (e.g. minikube vs dockerized k8s): AWS (see script)
OS (e.g. from /etc/os-release):
Others:
cluster.txt

main.go.txt

@adelelopez @jdoliner reraising attention on this.  Note that the kafka-spout example has a delay built into its message loop because of this issue; this bug number is referenced there.

@pappasilenus just to double-check, did you confirm that this wasn't an issue on the kafka-side? e.g. if you print messages as they're read from kafka, they're all there?

That was the first thing I checked.


fix: remove inaccurate BlobSharesUsed

While investigating https://github.com/informalsystems/audit-celestia/issues/14 I noticed that the BlobSharesUsed helper still exists. It should be removed because it assumes blobs are prefixed with varints (no longer the case) and doesn't differentiate between the first and continuation shares in a sparse share sequence. The helper SparseSharesNeeded should be used instead.

Codecov Report

Merging #1147 (d20d72f) into main (8226479) will increase coverage by 0.06%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   48.26%   48.32%   +0.06%
==========================================
  Files          71       70       -1
  Lines        3999     3975      -24
==========================================
- Hits         1930     1921       -9
+ Misses       1899     1884      -15
  Partials      170      170

Impacted Files
Coverage Δ

app/process_proposal.go
0.00% <0.00%> (ø)

app/estimate_square_size.go
95.74% <100.00%> (ø)

app/write_square.go
92.98% <100.00%> (ø)

pkg/shares/share_merging.go
81.42% <100.00%> (ø)

pkg/shares/share_splitting.go
73.56% <100.00%> (ø)

pkg/shares/utils.go
50.00% <100.00%> (-2.00%)
:arrow_down:

x/blob/keeper/keeper.go
81.48% <100.00%> (ø)

x/blob/types/payforblob.go
80.35% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

whooops wait could this be the reason for the flake in #1146?

TBH unclear if it's the cause of the flake b/c minimal debug logging here


Add tags for versions according to required Caddy version

Since building Caddy with plugins requires the right version of plugin it would be nice if some versions of this module would be tagged for more convenient build.
For example instead of:
--with github.com/mholt/caddy-l4@38bd801

it would be:
--with<EMAIL_ADDRESS>
It would actually be good if all Caddy plugins followed this approach.

It doesn't make sense to version this module against caddy's versions because there isn't a hard dependency on a specific Caddy version. The dependency listed in go.mod typically points at the minimum version necessary for a module, but not the absolutely required version. Ideally a module specifying a lower version should work with a higher version if the dependency is within the same major version. For example, if the go.mod file lists caddy v2.5.0 as dependency, you could build the module with Caddy v2.6.4 and should build fine.
Life isn't perfect, and breakage occurs, which is why we'd have to increase the minimum version listed in go.mod. Plus, dependabot is ridiculous and doesn't understand these semantics.
You probably just need tags for this module rather than tagging it the same tag as caddy. That we can probably do, especially after resolving a few of the raised issues/PRs.

@mohammed90
Your suggested build command does not work since:
41.74 go: github.com/mholt/caddy-l4@upgrade (v0.0.0-20230809152347-4e8aaac46581) requires<EMAIL_ADDRESS>not<EMAIL_ADDRESS>
Without using @ syntax it defaults to the main branch if there are no tags which uses version 2.7.3 now it making incompatible with 2.6.4.
I had the same confusion in the past with acme-dns since without @ syntax it defaulted to v0.2.0 tag not main branch, so I had to do:
--with github.com/caddy-dns/acmedns@main

I understand that this plugin is in development and there might be breaking changes.
Still I think it would beneficial to newer users of Caddy like myself if those confusions could be avoided with all plugins, not this specific one. Also because searching for the last commit SHA compatible with older version of Caddy is inconvenient.

That happens for me too.
I realize the inability to build with old Caddy versions may be frustrating, but this plugin is fairly tightly coupled with Caddy's exported API so it's best to use the latest Caddy version (even then, it's always a good idea to use the latest stable Caddy version).
As for the tagging proposal, that's something we won't be doing, for multiple reasons discussed here: https://github.com/caddy-dns/cloudflare/issues/58
Thanks for understanding!

Without using @ syntax it defaults to the main branch if there are no tags which uses version 2.7.3 now making it incompatible with 2.6.4.

Sorry, I was typing in a hurry. I meant to use the latest Caddy tag, v2.7.4. The point is, you can still build the latest Caddy regardless of the tag of this module, unless the module depends on a caddy version that's higher than the latest Caddy (e.g. HEAD). We're at the mercy of the Go compiler and module resolution rules.


Mike/5844 tests bulk upload results fhir

BACKEND PULL REQUEST
Related Issue

Closes #5844

Changes Proposed

Adds performance test for the bulk uploader on a large csv file
Adds regression test for bulk uploader that checks whether the evaluated bundle matches the expected FHIR json data
Refactors FhirConverter as a Spring component instead of a static utility class. This improves the testability of the converter by allowing easier mocking.
Adds mockable wrappers for random UUID generation, Date generation, and handling timezones with various FHIR datetime objects

Additional Information

Some recent data discrepancies with dates might be caused by the HL7 FHIR package relying on the system's default time zone. Currently the csv data for the bulk uploader does not handle time zones so we'll need to address this.
For example, if a row of data refers to 6/9/2023 at 15:00 and lacks time zone info, there is no way to determine whether that refers to 3pm eastern or 3pm pacific even if the machine running the bulk uploader is always using UTC. Unless we require a csv column that specifies time zone, we could potentially base it on other data such as testing facility location.

Testing

Review the code changes and verify the backend tests work correctly on your machine

I'll create an additional PR for this story that bases the uploaded data's time zone on the testing facility location

Deployed on Dev7 for testing

yes to supporting time zones for bulk upload! one thing I was thinking about is I think we were talking about the separate bulk upload experience having no concept of facility. so inferring time zone from facility would make that tricky if we ever decide to go back to implementing that. one other thing I thought about was making time zone a setting on the Manage org page

any thoughts on explicitly setting the time zone for the values in our fhir bundle so the behavior is predictable regardless of the system time zone? e.g. provenance.getRecordedElement().setTimeZone(TimeZone.getTimeZone("utc"));

Yeah I think it would be good for us to always set it as UTC, then I can remove some of those ugly changes I made in the FhirConverter since in the tests we wouldn't have to use a mock to update those fields with setTimeZoneZulu(true).
I'm currently working on handling time zones for the bulk uploader and here's some of what I have so far. This should preserve the time if it is included in test_result_date and hopefully be able to use the correct local zone offset from UTC. So with the following code, here is what the results would be:
Previously - "12/20/2021 14:00" in Central Time (UTC-5) gets converted to "2021-12-20T00:00:00Z", so it was losing the time value and using the system's default time zone so that for Central Time it ends up being 5 hours later at "12/20/2021 19:00"
Updated - "12/20/2021 14:00" in Central Time (UTC-5) gets converted to "2021-12-20T19:00:00Z" which is still in UTC by default but now is the correct instant of time from the uploaded data
But even with all of that, I think there would be some edge cases we'd need to figure out like if a lab already uses UTC for its data by default, in which case basing the time zone off their address might not be accurate. So then we either fall back to UTC or possibly a user time zone setting like you mentioned.
    var testResultDateTime = LocalDate.parse(row.getTestResultDate().getValue(), dateTimeFormatter).atStartOfDay();

    if (row.getTestResultDate().getValue().contains(":")) {
      testResultDateTime = LocalDateTime.parse(row.getTestResultDate().getValue(), dateTimeFormatter);
    }

    var zoneOffset = ZoneOffset.UTC;
    try {
      TimezoneInfo testResultTimezoneInfo = addressValidationService.getTimezoneByAddress(
              row.getTestingLabStreet().getValue(),
              row.getTestingLabStreet2().getValue(),
              row.getTestingLabCity().getValue(),
              row.getTestingLabState().getValue(),
              row.getTestingLabZipCode().getValue()
      );
      zoneOffset = ZoneOffset.ofHours(testResultTimezoneInfo.utcOffset);
    } catch (InvalidAddressException exception) {
      log.error("Unable to find timezone by testing lab address");
    }
    var dateTested = Date.from(testResultDateTime.toInstant(zoneOffset));

    var diagnosticReport =
        fhirConverter.convertToDiagnosticReport(
            mapTestResultStatusToFhirValue(row.getTestResultStatus().getValue()),
            testPerformedCode,
            testEventId,
            dateTested,
            dateGenerator.newDate());


Add CMake

#3

[x] Windows
[x] Linux

@skaarj1989 This is a wonderful commit and great help. I like the changes to use string_view in the logger.
This was a huge fix thank you so much.
Approved!


Add the guidance on controlling pipeline dependencies.

Adds the guidance on controlling pipeline dependencies with lessons learned from https://s.apache.org/beam-python-dependencies-pm and relevant content of the https://s.apache.org/python-dependency-management-beam-summit-2023 talk.
fixes: https://github.com/apache/beam/issues/25656

R: @AnandInguva


Player | PlaybackListener | RCTJSONStringify parse error (Invalid numeric value (NaN))

Please use the

Version of react-native-audio-recorder-player
3.0.3
Platforms you faced the error (IOS or Android or both?)
iOS
Expected behavior
Do not throw RCTJSONString parse error (Invalid numeric value NaN)
Actual behavior
Throws RCTJSONStringify() encountered the following error: Invalid number value (NaN) in JSON write when a listener is attached to the player every even call. (second, fourth, etc.)
Steps to reproduce the behavior
How the player is invoked.
...
    audioPlayer = new AudioRecorderPlayer();
    audioPlayer.addPlayBackListener((e) => {
        const playtime = Math.floor(e.currentPosition);
        const duration = Math.floor(e.duration);

        // Update UI
        if(delta(playtime, duration, 10)) {
            setPlayTime(DEFAULT_TIME_DISPLAY);
            setPlaying(false);
        } else {
            setPlayTime(formatTimeWithoutHours(playtime));
            setDuration(formatTimeWithoutHours(duration));
            setPlaying(true);
        }
    });

    // Start reading
    await audioPlayer.startPlayer(source.uri);
...

Swift file (RNAudioRecorderPlayer.swift)
    func addPeriodicTimeObserver() {
        let timeScale = CMTimeScale(NSEC_PER_SEC)
        let time = CMTime(seconds: subscriptionDuration, preferredTimescale: timeScale)

        timeObserverToken = audioPlayer.addPeriodicTimeObserver(forInterval: time,
                                                                queue: .main) {_ in
            self.sendEvent(withName: "rn-playback", body: [
                "isMuted": self.audioPlayer.isMuted,
                "currentPosition": 0,
                "duration": 0,
            ])
        }
    }

Setting currentPosition and duration to 0 prevented RCTJSONString error to show up.

Could you compare your project with one in Example? I am not sure how to dig this issue beforehand.

have the same issue，only happen on iOS sometimes，i have test version 3.0.8 and 3.0.9

I encounter the same issue, but apparently after start playing an audio and pause it, I use startPlayer() again. So I changed it to resumePlayer(), and  now on my side it is working as expected.

@hyochan  I have the same issue like @Maering. Could you please help us solve it??

@hyochan I believe the issue relies in this line:
https://github.com/hyochan/react-native-audio-recorder-player/blob/c5d3e66a3e9dffc833871fc0f16664ddd779bb08/ios/RNAudioRecorderPlayer.swift#L296
Changing that line to this seems to return the duration and not a NaN
"duration": self.audioPlayerItem.asset.duration.seconds * 1000

@efstathiosntonas tested and seems you're right. Cloned here
https://github.com/borg/react-native-audio-recorder-player

Thanks for the PR @borg, I’ve been using this small fix on production since Aug 21 and had 0 issues

For me, I still get duration: NaN although using latest library (3.3.4)

Version of react-native-audio-recorder-player
5.0.3
Platforms you faced the error (IOS or Android or both?)
iOS
With duration parameter. The output of
await audioRecorderPlayer.addPlayBackListener((e: PlayBackType) => { console.log(e) })
is {"currentPosition": 10000, "duration": NaN, "isMuted": false}
Could you please help us solve it.Thanks

This still happen on latest version. Please fix. @hyochan


Show diagnostics for the line under the cursor.

Is there a way to show the diagnostic for the line under the cursor without using a "jump to next" or "jump to previous"?

You can actually create your own command for this. This is what you could do:
command! CurrentLineDiagnostic lua require'jumpLoc'.openLineDiagnostics()

But it would be better to have it builtin in the plugin I guess, since the lua call is not really documented afaik.

That'd be good, yeah!
On Thu, 5 Nov 2020, 18:03 Benoit de Chezelles<EMAIL_ADDRESS>wrote:

You can actually create your own command for this. This is what you could
do:
command! CurrentLineDiagnostic lua require'jumpLoc'.openLineDiagnostics()
But it would be better to have it builtin in the plugin I guess, since the
lua call is not really documented afaik.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nvim-lua/diagnostic-nvim/issues/71#issuecomment-722544360,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAETWG35S7YZLJ4EQH4S3YLSOLSIZANCNFSM4TLOBZPA
.

It might be good if the current line diagnostic was automatically displayed also.


🌱 pin distroless/static:nonroot, and bump golang to 1.19.9

Pin distroless/stiac:nonroot to a sha digest.
Bump golang to 1.19.9.

/test-ubuntu-e2e-integration-release-1-4

/cherry-pick release-1.3


[REF-2764] dep update 0.5.0

Bump gunicorn dep to 22.0.0
Relock dependencies for CI testing
Upgrade pip for docker test to resolve backtracking issue
Filed #3244 since i couldn't upgrade fastapi

hmm definitely hitting pre-commit issues with this change... looking into it

Ah okay, we weren't running the linters with pydantic v2 installed prior to this patch.

@picklelo i think this one is good to go now, after fixing up a few issues with pyright running on pydantic v2.
just waiting for the last few slow CI runs to finish


Horizontal Rule not getting printed correctly

I'm trying to print horizontal rule but instead it's printing some other special characters. I've tried printing both 'single' and 'double' style.
encoder.initialize()
.rule({ style: 'double' })
        .line("Hello World!")
        .rule({ style: 'single' })
        .encode()

It looks like your printer is set to double byte mode by default. What type of printer are you using?

Thanks for the help. The codepage was set to CP437, but the byte mode was double. I changed it to single-byte mode, and then the horizontal rule printed correctly. However, I'm curious why normal text prints correctly with CP437 in double-byte mode, but the horizontal rule does not.


Buildings heat network costs should be updated

Last week I received input from Greenvis about new heat network costs / capacity in buildings. This should be updated on BETA!

@marliekeverweij can we do this next week (after the deploy) and push a mini-deploy of these values and updated biomass values to both BETA and PRODUCTION?

Yes good idea!