Make a custom cursor for the vs.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Added a new package called Link tiles

Motivation and Context
Custom component required by legalaid - it has a nice, simple UI and can be reused by other projects in the future.
Options for the component:

choice between a row or a grid view
choice to hide the icons (when present in props)
sidebar boolean - the grid view will remain at 2 cols (i.e. tablet layout) when sidebar is present and the container width reduces.

JIRA issue: no ticket
Changed

Added LinkTiles under packages
Updated the generated docs
Added unit tests
Updated CONTRIBUTING.md as new-package is not a valid command - it has been replaced by new-component

Screenshots
Mobile design:

Desktop design:

How Has This Been Tested?

unit tests
manual test for UI in storybook

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

[x] I've added relevant changes to the documentation.
[x] I have added tests to cover my changes (if not applicable, please state why)
[ ] My change requires a template update for create-ripple-app.
[ ] I have added template update script for next release.

@anfilimon closing in favour of #980


AzureStack Could Not Find Member 'enableCrossZoneUpgrade' and 'prioritizeUnhealthyInstances'

Describe the bug
We are getting bad request error running Azure CLI version 2019-03-01-hybrid in an Azure Stack environment. The following is the error:
az : ERROR: Deployment failed. Correlation ID: e436a4a0-c388-4834-aecf-ada3f8cf5c56. {
At C:\test\Workloads\DeveloperExperience\CLI\Workloads.Tests.CLI.ps1:759 char:23
+ ...   $result = az vmss create -g $vmssRgName -n $vmssName --admin-userna ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (ERROR: Deployme...ada3f8cf5c56. {:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

  "error": {
    "details": [
      {
        "message": "Could not find member 'enableCrossZoneUpgrade' on object of type 'RollingUpgradePolicy'. Path
'properties.upgradePolicy.rollingUpgradePolicy.enableCrossZoneUpgrade', line 1, position 338.",
        "target": "vmss.properties.upgradePolicy.rollingUpgradePolicy.enableCrossZoneUpgrade"
      },
      {
        "message": "Could not find member 'prioritizeUnhealthyInstances' on object of type 'RollingUpgradePolicy'. Path
'properties.upgradePolicy.rollingUpgradePolicy.prioritizeUnhealthyInstances', line 1, position 374.",
        "target": "vmss.properties.upgradePolicy.rollingUpgradePolicy.prioritizeUnhealthyInstances"
      }
    ],
    "code": "BadRequest",
    "message": "The request message is invalid."
  }
}

To Reproduce

Install Azure CLI.
Register:

            az cloud register --name $TntAdminEnvironmentName `
                 --endpoint-resource-manager $asEndpoints.ResourceManagerEndpoint `
                 --suffix-storage-endpoint $asEndpoints.StorageEndpointSuffix `
                 --suffix-keyvault-dns ("." + $asEndpoints.AzureKeyVaultDnsSuffix) `
                 --endpoint-vm-image-alias-doc https://raw.githubusercontent.com/Azure/azure-rest-api-specs/master/arm-compute/quickstart-templates/aliases.json `
                 --profile 2019-03-01-hybrid

Run the following command:

az vmss create -g $vmssRgName -n $vmssName --admin-username $vmssAdminUserName --admin-password $vmssAdminPassword --image $imageName --authentication-type password --upgrade-policy-mode $upgradeMode

Expected behavior
Should not throw bad request error.
Environment summary
We are using the nightly builds:
https://aka.ms/InstallAzureCliWindowsEdge
Additional Context
I have an internal email open with @qwordy. We can provide additional information in the email or here if requested.

compute

This issue was introduced in this PR. I raised my concern of this issue during PR review.

Hi @TheOnlyWei, This error happened because your request's api version is old.
If you feel it urgent to fix the problem, the workaround is to use az cloud set -n <cloud name> --profile latest to update your CLI cloud profile.
Otherwise you have to wait for it be fix in next CLI release.

@zhoxing-ms  We need to update following code. Add if statement of each parameter to check whether it is None.
https://github.com/Azure/azure-cli/blob/716b10f107c2e410967d7e09e21a0225c78e3cc8/src/azure-cli/azure/cli/command_modules/vm/_template_builder.py#L932-L939

@zhoxing-ms We need to update following code. Add if statement of each parameter to check whether it is None.
https://github.com/Azure/azure-cli/blob/716b10f107c2e410967d7e09e21a0225c78e3cc8/src/azure-cli/azure/cli/command_modules/vm/_template_builder.py#L932-L939

@qwordy Yes, that's what I thought~


Code and tooling improvements

Small PR to start with. The main points are:

isort should now be run by travis
test results should be upload to codecov from travis
E302 inconsistencies fixed.

Looks great! Though we need to use a tool to generate code coverage. codecov just looks for the .coverage file and uploads it to the servers. Since it doesn't exist, coverage isn't working.
  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                                0db33a1
==> Travis CI detected.
(root) .
==> Running gcov (disable via -X gcov)
  -> gcov in .
==> Searching for coverage reports
    Found 1 reports.
**> Python coverage not found
**> No coverage report found.

In other words, http://coverage.readthedocs.io/en/coverage-4.0.3/ will probably need to be incorporated.

I'm working on it at the moment actually. The issue I'm coming up against now is that now I'm integrating it with tox it's also being run when you run tox locally. This only causes the below message to be displayed for each testenv but it's by no means ideal.
py27-1.9.x runtests: commands[1] | codecov -e TOXENV

      _____          _
     / ____|        | |
    | |     ___   __| | ___  ___ _____   __
    | |    / _ \ / _  |/ _ \/ __/ _ \ \ / /
    | |___| (_) | (_| |  __/ (_| (_) \ V /
     \_____\___/ \____|\___|\___\___/ \_/
                                    v2.0.3

==> Detecting CI provider
  -> Got branch from git/hg
  -> Got sha from git/hg
==> Preparing upload
Error: Missing repository upload token

Tip: See all example repositories: https://github.com/codecov?query=example
Support channels:
  Email<EMAIL_ADDRESS>  IRC:     #codecov
  Gitter:  https://gitter.im/codecov/support
  Twitter: @codecov

I'm fine putting the codecov logic in tox, though I think it would also be okay to leave it in the Travis CI file since we only want it to upload to their servers in the CI environment.

@frewsxcv It should now be ready for merging. I have added the coverage and build buttons to the README.rst, vastly simplified the tox.ini and coverage.io is finally working.
I'm happy to rebase the branch and create a new pull request if you'd prefer to keep the history clean (or indeed "squash and merge" may be appropriate).

This is great! Just left one comment, but then this should be good to go! 🎊

Thanks for your contribution!

My pleasure :smile:


Set testnet fee rate to Phoenix testnet wallet

Currently the miner fees in testnet are higher than in mainnet. Phoenix testnet has always had mainnet values as a reference to establish fees. But right now it makes testing with Phoenix wallet testnet difficult for educational purposes. Could fees be adjusted for testnet? Or even be able to use the wallet with testnet4?

We do plan to use testnet4. We are waiting for https://github.com/bitcoin/bitcoin/pull/29775 to be merged and the update formalised, then we'll switch.

Regarding the feerate, it's been fixed with commit 081e5898. You can download the APK here:
https://acinq.co/pub/phoenix/phoenix-testnet-latest.apk
@robbiehanson The iOS app will keep using the mainnet feerate in some places (cf MempoolRecommendedResponse) so let's keep this issue open as a reminder for now, until the iOS app has also been updated.

Thank u. The new apk works well in testnet3


feat: Instrument PreBlocker latency [BLO-791]

In This PR

I finish [BLO-791] by implementing the e2e latency metric for the Preblocker

lgtm - just some merge conflict

Meant to stack diffs my b


Fix checkstyle violations in 11 modules

After a short break, again some work on #2238

statistics-export-service-impl
statistics-provider-influx
statistics-service-api
statistics-service-impl
statistics-service-remote
termination-state-aws
termination-state-impl
smil-impl
runtime-info
live-schedule-impl
authorization-xacml

Your pull request should…

[x] have a concise title
[x] close an accompanying issue if one exists
[x] be against the correct branch
[x] include migration scripts and documentation, if appropriate
[x] pass automated tests
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits

Since Lars approved, I'm gonna merge this before I procrastinate the review anymore and hold everything up ;)


Support more than one statistic for summarizing time lists

This commit switches code for computing averages to using numpy.
This is a first step towards supporting more than one statistic for summarizing lists of times for state change of issues. #84
Averages are easy to compute but sensitive to outliers. In particular when thinking of SLAs for times for first responses it is often more helpful to look at median, quartiles or even 90th percentile.
Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] run make lint and fix any issues that you have introduced
[x] run make test and ensure you have test coverage for the lines you are introducing
[x] Label as either bug, documentation, enhancement, infrastructure, or breaking

Not yet configurable, but a first run through the code of where changes would be needed to move to more than one statistic. At a first glance, the table doesn't look that bad.
At least me, I always look at more than one statistic (I believe I started that back when I discovered the possibility to create "describe" stats with R when starting to look at series of numbers). The question here is which stats exactly to look at.
As for the state of the change:

there are still references to "average" in some of the function names that really should be stats
going through making these changes I was wondering if it would make sense to pull some of the stats computation out of time_to_first_response, time_to_close etc.

In the latest commit I replaced references to averages where in reality they already are a combination of median, average, 90th percentile.

@MaineC @zkoppert I noticed some changes introduced by this that might not have been intended.
Tried my best to capture them in #144.


Duplicate Reviews

User theButterZone reports that one of their listings shows duplicate reviews.

I've also seen this only once on alpha version. After a purchase, I could click two times on the button to send a review.

It's been six weeks and no one else has reported this. I'm closing as not reproducible. If it pops up again we could re-open (hopefully with some reproducible steps :)


Add crash reporter using sentry

FYI, the crash reporter doesn't collect windows crash dump.

Cool, let's open a follow-up issue for Windows?

We're currently investigating backtrace.io and they have a free plan for OSS projects: https://backtrace.io/open-source/


Potential memory region size mismatch

Describe the bug
There was a bug that I fixed that involved mapping memory regions of a certain size (BYU-PCCL/holodeck-engine#175). The code would try and create the shared memory file, but if it already existed, it would just use the existing one (CreateFileMapping). Then it would try and map that file to a memory region of a fixed size (MapViewOfFile). That second call would occasionally fail because the size of the file mapping and the size passed into MapViewOfFile differed apparently (I couldn't verify this - I couldn't find a way to see how large a CreateFileMapping was if it was already created)
The fix was to change the MapViewOfFile call to not specify a size (0 as the last parameter) and use the size it already was. This appears to work, but doesn't explain why the sizes didn't match (the Python code had already created the memory region)
To Reproduce
Look in the log for this message
HolodeckSharedMemory:: Unable to create MemFile! The path %s already exists. Hopefully it is the correct size...

Expected behavior
The memory regions should be the same size, and we should be able to pass the size of the memory into MapViewOfFile

This really looks like it could be related to https://github.com/BYU-PCCL/holodeck-engine/pull/220/files.


Please support List( Map<IPacket,IPacket>,...) in zfoo protocol

I think zfoo protocol already have it. And I've used it for months. This is a simple example using existed IPacket children in tests - ObjectA, ObjectB, ObjectC:
// ObjectD.java - this is the file contains List<IPacket> and Map<IPacket, IPacket>
@Protocol(id = 122)
public class ObjectD implements IPacket {
  public List<ObjectA> list = List.of(new ObjectA(), new ObjectA());
  public Map<ObjectB, ObjectC> map = Map.of(new ObjectB(), new ObjectC());
}

// GenerateGdTest.java - this is the test file to generate protocols
public class GenerateGdTest extends TestCase {

  @Test
  public void testGenerateGd() {
    var op = GenerateOperation.NO_OPERATION;
    op.getGenerateLanguages().add(CodeLanguage.GdScript);
    op.setProtocolPath("out");
    ProtocolManager.initProtocol(Set.of(ObjectA.class, ObjectB.class, ObjectC.class, ObjectD.class), op);
  }
}

And run it using junit, it works fine.
Maybe you forgot to register the IPacket children in List/Map in the GenerateOperation.
If I wrong, please correct me. Thanks.

It is not my problem, I want to use List in ObjectD class

Gocha! Sorry for my misunderstanding. Your topic is very interesting. I'll try to implement it later.

if you use kotlin as language for server-side, please take a look at this MSerialization, it use ksp for code generation and of course it support JS and Gdscipt

Custom generic class such as List are not supported in all languages，for example golang and cpp.

I think he wanted to say list of abstract class.
For example: List<AbstractPacket> with AbstractPacket is an abstract class and implements IPacket. I think it's possible, isn't it?

It is easy to support List or List in java, but very difficult in other languages such as golang and cpp

I think if we implement this feature, it will be interesting. However, as @godotg said, it's very difficult to implement in golang and cpp. I think I can implement it in other languages as java, c#, js and godot. Can we support it for these languages, if GenerateOperation.generateLanguages contains other languages, we will throw an exception?

Custom generic classes are prone to performance and parsing problems in many frameworks, and are not supported in all languages.
According to the current protocol format,this feature can not be supported.


docs.angularjs.org is down

The https://docs.angularjs.org/ site is currently not functioning.  Seems like it is not loading the Angular library.

This error is up again..

yup, it's not working right now

a fix is being worked on, it was an accident, regular expressions are complicated and scary =)

should be fixed (for now), you'll likely need to disable cache temporarily though

still down

justified necro +1

down again

Getting 'ERR_TIMED_OUT' on 'docs.angularjs.org' document

#16205 Issue is live here, go here to find links to active docs


Provide a SequenceJsonProvider to help preserving order of events emitted during the same millisecond

Timestamps have a precision up to the millisecond, meaning that sorting events on the timestamp does not necessarily preserve the sequence and, depending on the sorting algorithm, we may end up with event 2 appearing before event 1.
To solve that issue we added a custom SequenceJsonProvider that outputs an additional seq field in the JSON output. That field is basically a counter that is reset every milliseconds (to keep the value small and optimise storage on the backend store).
That strategy obviously depends on the configured timestamp format: if user opts for a format with a precision up to the second, the counter must be reset every second instead of milliseconds. An alternative is to use an ever-increasing counter... (but what would happen when it reaches the maximum and is reset to zero?)
I was wondering if other people would be interested in such feature and if it is worth to be included in the library...
What do you think ?
BTW: would it be possible to schedule a "live" chat together one of these days? I have other features and design issues I'd like to discuss with you. A chat can sometimes be easier that exchanging "emails" through the GitHub issues.
/Bertrand

Hey Bertrand,
logstash-logback-encoder has a SequenceJsonProvider that uses an increasing long counter, starting from 0.  Rollover is not a concern since if the application logs a message every micro second, it will take close to 300 thousand years before it rolls over.
Email me at logstash dot logback dot encoder at gmail dot com, and we can set up a live chat.

Hey Bertrand,
logstash-logback-encoder has a SequenceJsonProvider that uses an increasing long counter, starting from 0.  Rollover is not a concern since if the application logs a message every micro second, it will take close to 300 thousand years before it rolls over.
Email me at logstash dot logback dot encoder at gmail dot com, and we can set up a live chat.

I missed that one...
Rollover is indeed not an issue. Only the size of the sequence number may be an issue for some people... But I don't think it is worth to implement another solution. If the need arise, one can implement is own provider and/or file an issue.
If you agree, you can close the issue.

I missed that one...
Rollover is indeed not an issue. Only the size of the sequence number may be an issue for some people... But I don't think it is worth to implement another solution. If the need arise, one can implement is own provider and/or file an issue.
If you agree, you can close the issue.


[WIP] Build script updates

Major improvements to build.py:

Now compatible with Python 3
Now uses Python argparse for cleaner handling of arguments
Now uses Python logging
Added function documentation
Removed a few unneeded functions
Updated nightly logic to increment minor version
Added support for building from specific branch or commit
Added a --release flag, default package output will now contain the commit hash in the version number
Static builds are now listed as an architecture (and can be built with --arch=all)

@rossmcdonald Overall this looks great! I am going to play around with it locally for a bit.

@rossmcdonald  What is the motivation for?

default package output will now contain the commit hash in the version number

@rossmcdonald Is it because the --release flag removes the commit hash and so builds not marked as release are easily identifiable?

So here are some example versions generated from the builds.
non-release version:  0.12.0-a10b80f-0
release version:  0.12.0-1
nightly version: 0.13.0~n201604151656
If my understanding is correct than the version order should be:
non-release < release < nightly
This works for rpm but the Debian version comparison fails for non-release < release:
$ dpkg --compare-versions 0.12.0-a10b80f-0 lt 0.12.0-1 && echo true || echo false
false

But if we switch to using ~ like we do  for the  nightlies is works:
$ dpkg --compare-versions 0.12.0~a10b80f-0 lt 0.12.0-1 && echo true || echo false
true

Also when is a non-release version used as opposed to the nightly builds? I am not quite sure I understand the purpose of the git sha in the version yet...

Is it because the --release flag removes the commit hash and so builds not marked as release are easily identifiable?

Yes, that's part of it. The idea is that we are going to start uploading all Circle builds to S3 so that developers and testing team can have easy access to packaged builds. I wanted to add a unique identifier for non-release build artifacts so that we didn't have any collisions when uploading and are easy to spot. I also eventually want to automate the entire release process, so this is the first step in that direction.
Regarding the version comparisons, I assumed that the non-release builds will only be used for testing and development purposes (and maybe installed on a one-off basis to verify hotfixes, etc). I think that changing it to fit the nightly naming convention (with a ~) is a great idea, though. That way anyone will always be able to upgrade from non-release to release to nightly without any issues.
I'm also open to any thoughts or ideas you may have (or if you think the whole idea should be scrapped).

We will have an archive of all builds, sounds good. +1
Since CircleCI manages the releases for Kapacitor can you add the --release flag to the circle.yml file for the deployment section? Thanks.
Also when you are ready to start testing automation pieces let me know. Kapacitor is fully automated already but just uses CircleCI so we can't do things like sign the packges etc. Should be simple to migrate to a more trusted system.


Application name needs to be updated to Experiment name in search space API

Application name needs to be updated to Experiment name in search space API to keep it consistent

Closing this, as this is fixed now.


[9.x] Add explode() to Collection

Hi :-)
This pull request propose the addition of an explode() (echoing the presence of implode() method) to the Collection object.
This try to answer 2 cases I often see:
1- Need to generate Collection from exploded string, in code we see:
collect(explode(',', 'apple,pear'))->...

2- Need to generate Collection form list of literal lists:
collect(['apple,pear', 'banana,peach']))->map(fn($list) => explode(',', $list))->flatten(1)->...

With the new explode method we can have an efficient way to do:
collect('apple,pear')->explode(',')->...
// Generate ['apple', 'pear']

collect(['apple,pear', 'banana,peach']))->explode(',')->...
// Generate ['apple', 'pear', 'banana', 'peach']

It even support multi separators (which seem to be a pain every time...) as:
collect(['apple,pear', 'banana;peach']))->explode([',', ';'])->...
// Generate ['apple', 'pear', 'banana', 'peach']

IMHO explode is more of string function rather than of array (see Str).

Hi @chu121su12 ,
thanx for your feedback, I can see your point... maybe I can make it even more 'generic' by having a 'value' parameter like 'implode' to select wich value we want to explode in a list of array/objects like:
collect([['name' => 'a,b,c', 'name' => 'd,e,f']])->explode('name', ',');
//collect('a', 'b', 'c', 'd', 'e', 'f'])

Now support behaviour:
collect([
   ['person' => ['names' => 'taylor,foo']],
   ['person' => ['names' => 'dayle;bar']]
])->explode('person.names', [',', ';']);

// Will return: collect(['taylor', 'foo', 'dayle', 'bar']);

I think the example 1 is solved with @chu121su12 's comment, and the example 2 is a very specific use case from your codebase.
If you have to do the map(explode)->flatten logic too often, I'd recommend to have a macro

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


Problem of using semantic retrieval

I am experimenting the semantic retrieval according to the tutorial, while got the corruption when starting run_server as follows:
E0100 00:00:00.000000  9225 dual_dict_wrapper.cpp:38] RAW: can't find dict_type:String2RecallItemAdapter
I0100 00:00:00.000000  9225 dual_dict_wrapper.cpp:64] RAW: load dict file:./example/conf/./faq_json.index
I0100 00:00:00.000000  9225 dual_dict_wrapper.cpp:65] RAW: dict file state: Wed Jul 11 10:25:55 2018

Program received signal SIGSEGV, Segmentation fault.
0x00000000007c6cd8 in anyq::DualDictWrapper::reload (this=0x5021ff0) at /root/AnyQ/src/dict/dual_dict_wrapper.cpp:68
68	        if (tmp_dict->release() != 0) {

The error happens due to the plugin of String2RecallItemAdapter has not been registered. However, there does not exist such definition within the project, where could I find it within the project?

I'm sorry that I made a mistake in  this tutorial. Please replace 'String2RecallItemAdapter' with 'String2RetrievalItemAdapter' in example/conf/dict.conf.  Thank you for pointing out our mistake.

thank you, it works now

关于anyQ源码细节研读，请加我微信15821444815，一起研究研究！


Hard Tabs

People are allowed to have opinions on how much visual indentation they want in their code. When I first started coding I found 4-space indentation to be really helpful when I would easily get lost in my code. After a few years I preferred 2-spaces. So there is an argument to be made about accessibility.
People have debated endlessly about tabs vs spaces, and ultimately most of people's opinions are just a bit silly. There is only one consequential difference between the two:
Tabs allow individuals in the same codebase to select their indentation widths across every tool (yes including GitHub using either the .editorconfig or a user-style with tab-size), and spaces do not (at least not across every tool).
As such, I think we should switch to hard tabs for everything in Rome.
I'm gonna make a request that people refrain from flooding this thread with subjective opinions about if 2-space width code is better than 4-space width code. You are welcome to have your personal preference, that is the entire reason for choosing hard tabs.

One change I'm going to work on now is making sure that tabs render correctly in buildMessageCodeFrame. We should render \t as   and make sure the pointer aligns.

Just to confirm the accessibility issue: https://www.reddit.com/r/javascript/comments/c8drjo/nobody_talks_about_the_real_reason_to_use_tabs/

coworkers who unfortunately are highly visually impaired, and each has a different visual impairment:

one of them uses tab-width 1 because he uses such a gigantic font-size
the other uses tab-width 8 and a really wide monitor
these guys have serious problems using codebases with spaces, they have to convert, do their work, and then unconvert before committing

Thank you for sharing this. I had never thought/considered the accessibility concerns of using spaces

Merged #439. I'll make the indentation change once I've merged the outstanding PRs.

Opened #443 to switch us to hard tabs. I also opened #442 to discuss switching to double quotes.


improve example: take hex-encoded seed instead of WIF in bip32 example

This is my understanding of what we want to fix the confusing bip32 example. Apologize in advance if I misunderstand it.
Closes #748

ACK 1bd54ab
This looks perfect, thanks!

Thanks. just rebased master and fix test in contrib/test.sh


Transfer labels to another repo

From @lfunkhouser on March 28, 2016 19:25
Copied from original issue: Esri/coordinate-conversion-addin-dotnet#86

This issue was moved to ArcGIS/visibility-addin-dotnet#49

This issue was moved to ArcGIS/military-tools-for-arcgis#5

This issue was moved to ArcGIS/air-c2-cop#1

Thanks @lfunkhouser

This issue was moved to ArcGIS/military-tools-for-arcgis-build#8


An error occured during upscaling

Hi
I have all my attachements, 32gb of ram and a 3060rtx gpu
everytme i launch an upscale after 0.2sec it says " An error occured during upscaling"
do you know what could be the problem ?
cheers !

Have you tried changing the AI network? (Its the setting in the top left of the screen, a little ways above model selection.) I've found the middle choice (ESRGAN (ncnn)) has the best compatibility, and RealESRGAN has a massive speedup but you have to use a 4x model, no bigger no smaller.


[Engine] Restart Skia roller when safe

Was turned off while working on roll cl/238091196

Issue found to be #28919. Turning roller back on.


Warnings should not be treated as errors

What happened?
I don't have a clear idea about what happens but seems that if the command output has warnings these are treated as errors and, the first time, the pulumi command fails...but the the real command launched succeeds.
For example in this case I triggered an azure container registry quick task with a command like this:
var azAcrBuildAndPush = Output.Format($"az acr build -t $IMAGENAME -r $REGISTRY -f $DOCKERFILE --build-arg PAT={Output.Unsecret(dockerConfig.RequireSecret("adospat"))} --platform linux/amd64 $CONTEXT");
and was successful but the pulumi command resource failed the first time

Expected Behavior
Do not make the pulumi command fail if the command launched is successful
Steps to reproduce
Not sure what to do...you can try the same I did for example
Output of pulumi about
Pulumi              3.54.1
Pulumi.AzureAD      5.37.0
Pulumi.AzureNative  1.102.0
Pulumi.Command      0.5.2
Pulumi.Docker       4.2.0
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @andrekiba - thank you for filing this issue. It's looking like there's a discrepancy between our diagnostics output and the actual behavior.
To be clear, I don't see a failure on your screenshot - can you help us understand what you mean by

and, the first time, the pulumi command fails...but the the real command launched succeeds.

Do you mean this pops up as an error on pulumi preview?
Finally, if you can help us out by providing a minimal repro of this behavior, that would be awesome.

Since we haven't received a repro since about three months ago, and the problem isn't quite clear either, I'll go ahead and close the issue for now. Please open a new open with a clear repro program if it still persists.

@mikhailshilkov I'm sorry for my delay on this but I think the problem is still present, I'll try to create an example as soon as possible. Here the images in which you can see that the pulumi command fails but the az acr build completed successfully


fix(*): change noop function return type from undefined to void

I modify the return type of noop function from () => {} to noop():void for type consistency.
[AS-IS]

noop function returns undefined while methods in query-core return Promise<void>
Methods using promise.catch(noop) have inconsistent return types with their declarations
#executeFetch method has the same issue where Promise<TQueryData | undefined> meets promise.catch(noop)

[TO-BE]

Explicitly type noop function to return void
Replace promise.catch(noop) with promise.catch(() => undefined) in #executeFetch to match its return type
Apply noop():void to other promise chains in query-core where return type is Promise<void>

didn’t you just literally change the same thing @manudeli ?

https://github.com/TanStack/query/pull/8294

I’m confused

didn’t you just literally change the same thing @manudeli ?

refactor(*): unify & use noop #8294

I’m confused

@kangju2000 check this comment  https://github.com/TanStack/query/pull/8294#discussion_r1843688199 please

Sorry for not checking PR https://github.com/TanStack/query/pull/8294#discussion_r1843688199.
I tried to change it to void for semantic clarity of "no operation", but as discussed there, we need undefined for practical type safety in Promise chains. I agree with keeping noop(): undefined.
What do you think about adding this JSDoc comment to help future contributors understand the design decision? @TkDodo @manudeli
/**
 * No-operation function that returns undefined for type safety in Promise chains
 */
function noop(): undefined {
  return undefined
}

@TkDodo Since noop returning void and functions returning undefined are widely used in all packages,
How about providing both function noop(): void {} and function returnUndefined(): undefined {} in @tanstack/query-core and using them in all packages such as @tanstack/react-query?

That's fine if TypeScript likes it everywhere 👍

If that makes typescript unhappy, we may just let it be inferred ..
export function noop(): {
  return undefined
}

up to you guys 😅

@TkDodo Separate noop and returnUndefined functions as reflected in f2820ac3774472949a606f6b07e314a96eeb7649

@TkDodo Separate noop and returnUndefined functions as reflected in f2820ac

Looking at this comment(https://github.com/TanStack/query/pull/8294#discussion_r1843688199), it seems that TkDodo did not want to implement noop and returnUndefined separately and include them in the package bundle since they are the same implementation in JavaScript.
So, how about implementing it as follows?
// @tanstack/query-core
export function noop(): void {}
export const returnUndefined = noop as () => undefined

// @tanstack/react-query
import { noop, returnUndefined } from '@tanstack/query-core'

// @tanstack/vue-query
import { noop, returnUndefined } from '@tanstack/query-core'

// @tanstack/svelte-query
import { noop, returnUndefined } from '@tanstack/query-core'

Thank you for the good suggestion! From a bundle size optimization perspective, type re-assertion seems better. I'll try changing it to export const returnUndefined = noop as () => undefined as suggested, and if there are any readability issues, we can consider rolling back to the previous approach.
Additionally, these utility functions seem to fall outside the core responsibilities of @tanstack/query-core and would be better handled through dedicated utility libraries.

it doesn’t work. please make sure locally that everything compiles properly.

@kangju2000 You have to run script test:types https://github.com/TanStack/query/blob/main/package.json#L22 in root

@TkDodo
Sorry for the hassle. I've added type overrides for noop only where necessary. Using the overridden noop in the following code causes errors, so I kept it unchanged in solid-query.
// packages/solid-query/src/createQueries.ts:309
let unsubscribe = noop
createComputed<() => void>((cleanup) => {
  cleanup?.()
  unsubscribe = isRestoring() ? noop : subscribeToObserver()
  return () => queueMicrotask(unsubscribe)
})


make it a real python module

This is something with a couple stuff you might want to change in setup.py, you also might want to change the directory structure. but this makes it a real python module that you can upload to pypi later.

Thanks for the work you did but i already use data from python-weather which in itself is an API wrapper so i dont think this will be a good idea. So for now im closing the PR, if you have any other suggestions or if you can help me turn into a linux pkg please let me know.

you removed the if name == "main" part, how will people now run it as a terminal command?

by using the entry point defined in setup.py. you run it by doing pip install . and then just running the built richeweather. You could also do if name name == "main" then call the main function

Alright then I'll change the author name and in the setup file, add the if name main thing and merge it. Tysm for the contribution!

Thanks a lot for contributing to richweather! I'm very happy to see your changes working perfectly.


Disable editing the "Others" icon in UI (only in advanced mode)

Related to: #12683

Cartodb.js PR: https://github.com/CartoDB/cartodb.js/pull/1726
Disable editing the "Others" icon

For acceptance:

Create a map with a layers of points
Style the layer by value, using a string column.
Check "Others" item.

NOTE: using CartoCSS in advanced the "Others" icon can be set (this is a hack) and the legend works as expected.

@rochoa Are you OK with this change (empty url like url('')) ?

Not a big fan of this approach. We are relying on a hack, using an empty URL.
Turbo-Carto ramps are not intended for these scenarios. If you want a more granular control over "others", you need to handle that logic in CartoCSS itself and filter the categories already in use to assign the "others" file. An example:
#layer {
  marker-width: 20;
  marker-fill: ramp([sov_a3], (#5F4690, #1D6996, #38A6A5, #0F8554, #73AF48, #EDAD08, #E17C05, #CC503E, #94346E, #6F4070, #666666), ("USA", "RUS", "CHN", "BRA", "CAN", "AUS", "IND", "MEX", "ARG", "IDN"), "=");
  marker-fill-opacity: 1;
  [sov_a3 != "USA"][sov_a3 != "RUS"][sov_a3 != "CHN"][sov_a3 != "BRA"][sov_a3 != "CAN"][sov_a3 != "AUS"][sov_a3 != "IND"][sov_a3 != "MEX"][sov_a3 != "ARG"][sov_a3 != "IDN"] {
    marker-file:  url('https://s3.amazonaws.com/com.cartodb.users-assets.production/maki-icons/park2-18.svg');
  }
  marker-file: ramp([sov_a3], (url('https://s3.amazonaws.com/com.cartodb.users-assets.production/maki-icons/parking-18.svg')), ("USA"), "=");
  marker-allow-overlap: true;
  marker-line-width: 1;
  marker-line-color: #FFF;
  marker-line-opacity: 1;
}

The issue with this method is that the "default" value does not appear in the rules used for the legends:

Ok, these are the conclusions:

UI can not allow the "Other" image to be set
But legends are ready to display the "Others" image if it is set in advance mode

So let's update the ticket's name.
Thank you guys!
cc @xavijam @rochoa

Thanks to you majo!

Looks good!

It's being deployed at ded02 for the next 'accepter'.

Working as expected! :shipit:


Too many time to resolve localhost domain

Hi,
Versions:

amphp/dns v1.2.2
amphp/http-client v4.4.0
PHP 7.4.5 (cli) (built: Apr 23 2020 02:25:56) ( NTS )

Steps to reproduce:

Run php web server php -S localhost:3001 -t / (or something else). Files are optional.
Create file like index.php with following contents:

use Amp\Loop;
use Amp\File;

require __DIR__ . '/vendor/autoload.php';

Loop::run(function () {
    $client = \Amp\Http\Client\HttpClientBuilder::buildDefault();
    $request = new \Amp\Http\Client\Request('http://localhost:3001/', 'GET');
    $response = yield $client->request($request);
    echo yield $response->getBody()->buffer();
});

Run curl time curl http://localhost:3001/
Run time php index.php

roquie@roquies-MacBook-Pro:~/google_drive/projects/spacetab-io/github/gotenberg-sdk-php$ time php index.php
"""
<!doctype html><title>404 Not Found</title>\n

Not Found

The requested resource / was not found on this server.

"""

real    0m10.096s
user    0m0.059s
sys     0m0.031s

DNS can't be resolve less than 10 seconds.
$ cat /etc/resolv.conf

nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>
nameserver <IP_ADDRESS>

If you use <IP_ADDRESS>:3001 instead of localhost:3001 always works fine.

localhost should never be sent to any nameserver for resolution.

That right. But I don't know why it resolving 10 seconds. Did you reproduce this?

No, I can't reproduce it: 0,09s user  0,03s system  91% cpu  -  0,124 total

@roquie Could you check which IP Curl is using with curl -v http://localhost:3001/? Might be some IPv4 vs. IPv6 issue. And also check which IP the PHP web server is actually listening on?

Oh, I forgot about this issue 😨
Curl output:
*   Trying ::1...
* TCP_NODELAY set
* Connected to localhost (::1) port 3001 (#0)
> GET / HTTP/1.1
> Host: localhost:3001
> User-Agent: curl/7.64.1
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Host: localhost:3001
< Date: Tue, 28 Jul 2020 16:26:49 GMT
< Connection: close
< Content-Type: text/html; charset=UTF-8
< Content-Length: 533
<
{ [533 bytes data]
100   533  100   533    0     0  88833      0 --:--:-- --:--:-- --:--:--  104k
* Closing connection 0

I updated composer packages to latest versions. I can still reproduce this.

If you try it with Amp, do [::1] and <IP_ADDRESS> work equally?

I'm closing this due to lack of feedback.


The latest rrnDB files are too big

Delete already rrnDB files version 5.8 and replace with rrnDB files version 5.6

closes d64bd5f

closes #d64bd5f

closes d64bd5f


Revamp

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fixes #
Test URLs:

Original: https://www.sunstar-foundation.org/

Before: https://main--sunstar-foundation--sunstar-foundation.hlx.live/

After: https://revamp--sunstar-foundation--sunstar-foundation.hlx.live/

[ ] New Blocks introduced in this PR
If yes, please provide details below

Block Name
Documentation

For e.g. cards
doc-link

[ ] New variations introduced in this PR

Variation Name
Documentation

For e.g. cards (grid)
doc-link

Yes I am going through these blocks and fixing the styling.


feat: Export stats type to allow for easier usage as a library

This will export some internal types, so that the usage as a library gets easier.
Resolves #17

Hello @s32x,
any chance you take a look? With kind regards 🙂

Hey! Sorry for taking so long to look at this. The last few months have been hectic for me. Of course - I'll merge this now.

Thanks @s32x and no worries 😉


fix(parser): fix comment typos

#3036  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


!latex command for anyone to convert text to latex in #maths channel

We are in need of a latex command to be used primarily in our #maths channel<PHONE_NUMBER>16099072), which should take text input and send an image showing the LaTeX equivalent to make it easier for members to visualise equations.
The bot should not permanently save images on the server that hosts the bot in order to save storage.
Ideal Format:
!latex 3+7
You can refer to our previous bot's source code for reference. Please note that it may be difficult to navigate through due to its poor scalibility. Additionally, this command was not completed in the previous bot.

Finished this!

is this still in need, or has it been completed and not closed yet?

Does not apply anymore


chore: remove redundant covariance instances

I noticed that the following code is surprisingly slow.
import Mathlib

count_heartbeats in
example {n : ℕ} : CovariantClass (Fin (n + 1)) (Fin (n + 1)) (· + ·) (· < ·) := by
  try infer_instance
  sorry

This PR removed some redundant instances. However I found Lean4 still made some redundant attempts, after that I saw https://github.com/leanprover-community/mathlib4/issues/6646#issuecomment-1691792488.

!bench

!bench

I'm changing it to awaiting-author because it's marked as a draft PR and as a WIP. If it's ready for review, then please change it from draft to a normal PR and adjust the labels.

!bench


Unauthenticated login causes error trying to retrieve repositories

Using the new
[OCTUser userWithRawLogin:@"login" server:[OCTServer dotComServer]];

then calling
RACSignal *request = [self.client fetchUserRepositories];
[request subscribeNext:^(OCTRepository *repository) {}]

to pull the repositories will cause an error at
- [OCTClient - (RACSignal *)enqueueUserRequestWithMethod:(NSString *)method relativePath:(NSString *)relativePath parameters:(NSDictionary *)parameters resultClass:(Class)resultClass]

since the line
path = [NSString stringWithFormat:@"users/%@%@", self.user.login, relativePath];

has self.user.login returning nil, and the rawlogin property contains the appropriate username.

Not sure if this is related to this bug of not. But seem to me in the  OCTClient+Search.m file, braces should be added after "if (orderBy.length > 0)" to include all calls related

(RACSignal *)searchRepositoriesWithQuery:(NSString *)query orderBy:(NSString *)orderBy ascending:(BOOL)ascending {
NSParameterAssert(query.length > 0);
NSMutableDictionary *parameters = [NSMutableDictionary dictionary];
parameters[@"q"] = query;
if (orderBy.length > 0)
{ // <--- here
parameters[@"sort"] = orderBy;
parameters[@"order"] = ascending ? @"asc" : @"desc";
NSMutableURLRequest *request = [self requestWithMethod:@"GET" path:@"/search/repositories" parameters:parameters notMatchingEtag:nil];
[request<EMAIL_ADDRESS>forHTTPHeaderField:@"Accept"];
} // <--- and here
return [[self enqueueRequest:request resultClass:OCTRepositoriesSearchResult.class fetchAllPages:NO] oct_parsedResults];
}

So anyone know how to actually get OctoKit to work?

Sigh, ended up just using a token and the authenticated client vs unauthenticated one.


add default configs for flutter go python and unity

Amplitude Developer Docs PR
Description
Describe your changes.
Deadline
When do these changes need to be live on the site?
Change type

[ ] Doc bug fix. Fixes #[insert issue number]. Amplitude contributors include Jira issue number.
[ ] Doc update.
[ ] New documentation.
[ ] Non-documentation related fix or update.

PR checklist:

[ ] My documentation follows the style guidelines of this project.
[ ] I previewed my documentation on a local server using mkdocs serve.
[ ] Running mkdocs serve didn't generate any failures.
[ ] I have performed a self-review of my own documentation.

@amplitude-dev-docs

Updates are super helpful. Thanks @yuhao900914!


Error displayed when putting task in complete status

Describe the bug
Error displayed when putting task in complete status
To Reproduce
Steps to reproduce the behavior:

Go to task details
Click on Action - 3 dots
Select mark as completed
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: [e.g. iOS] - Windows 10
Browser [e.g. chrome, safari] - Chrome
Version [e.g. 22] - latest

turns out it is a bug on server side, note should be optional


[8.x] Ignore tablespaces in dump

Less likely to hit permissions issues in newer versions of MySQL. See https://github.com/laravel/sail/issues/250

@driesvints

I wonder what changed to Sail that's causing this.

Nothing. MySQL changed the permissions required for a user to read certain information off of the INFORMATION_SCHEMA tables in a patch version (8.0.21). See here and here.

The PROCESS privilege also enables use of the SHOW ENGINE statement, access to the INFORMATION_SCHEMA InnoDB tables (tables with names that begin with INNODB_), and (as of MySQL 8.0.21) access to the INFORMATION_SCHEMA FILES table.

mysqldump requires at least the SELECT privilege for dumped tables, SHOW VIEW for dumped views, TRIGGER for dumped triggers, LOCK TABLES if the --single-transaction option is not used, and (as of MySQL 8.0.21) PROCESS if the --no-tablespaces option is not used.

Since Sail uses the MySQL 8.0 image, once you update to 8.0.21, break.
Like I said, if anything, this change helps the framework mitigate someone else's non-semver, BC-breaking change.


UI: Fix hypervisor list after zone validation when registering a template

Description
This PR fixes an error on the hypervisor menu when registering a template and the zone validation triggers

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6382 (SL-JID-1558)