Leading zero

Hi,
I use the rule Leading Zero with "exclude_zero". So I want to write .5 for 0.5.
But the beautifier breaks that rule, because it adds the 0. Can I configure that behavior? It would be nice, if it removes an zero if one is there.
If the beautifier doesn't support it yet, could you add it?
Thank you.

I've been looking into this because I ran into the same issue.  I'm not seeing it happen in every case, though.  For example, with this snippet
h1 {
    margin: .4em;
    -webkit-transform: scale(.9);
    transition: -webkit-transform .1s;
}

It gets transformed to
h1 {
    margin: .4em;
    -webkit-transform: scale(0.9);
    transition: -webkit-transform .1s;
}

Notice that the middle line -webkit-transform is the only one that gets the 0 added on.  Not sure why that is...


Enforce Mutable Return Types

This is a follow up to @RebeccaStevens' https://github.com/eslint-functional/eslint-plugin-functional/issues/153 which described the issue very well:

Enforce Mutable Return Types
If the return type has to immutable then something very non-functional is going on. What happens to the data after it is returned by a function should be of no concern to the function itself. Mutable return types are more compatible with 3rd-party non-function code as readonly types can not be given as mutable types in TypeScript (while mutable types can be given as either a mutable or readonly type).
An option to enforce this behaviour should be added to the rule (whether this is the default behavior or not is currently undecided).

That issue was mostly solved (and marked as solved) by https://github.com/eslint-functional/eslint-plugin-functional/pull/480, but as far as I can tell, there isn't yet a way to enforce mutable return types with the new prefer-immutable-types rule.
Maybe a solution could add a "Mutable" option to the available settings for returnTypes.enforcement?
type Options = {
  // ...
  returnTypes?: {
    enforcement: "Mutable" | "None" | "ReadonlyShallow" | "ReadonlyDeep" | "Immutable";
    ignoreInferredTypes: boolean;
    ignoreClasses: boolean | "fieldsOnly";
    ignoreNamePattern?: string[] | string;
    ignoreTypePattern?: string[] | string;
  };
  // ...
};

Am I missing another way in which this feature was added? Thanks!

This was researched and tested out, but the reason why this never made it in is because in practice, enforcing everything to be deeply mutable results in extremely inefficient code and has little to no benefit, and can even be a detriment.
For example, take this snippet of code:
type Foo = { hello: number };
type Bar = { world: number };

function addBar(foo: Readonly<Foo>) {
  return {
    foo,
    bar: { world: 2 },
  };
}

const foobar = addBar({ hello: 1 });

Here the return type of addBar is shallowly mutable, but it's not deeply mutable as its foo property is immutable. To make it mutable, we'd need to deeply clone the contents of foo. If the rest of the codebase is also written in a functional way, this cloning then becomes wasted effort as foo was never going to be mutated anyway.
Requiring shallow mutability instead of deep mutability may have some benefits but what is "shallow mutability" in this context? Should every top-level property be required to be mutable? Or do only some need to be?
In practice, I've found that with regard to return type immutability, it best not to enforce any level of mutability. Some function may need to use a certain level, but in general it seems to be something that shouldn't be enforced.
I'm open to feedback on this.

Thanks for the response! This makes a lot of sense.
I've been requiring immutable function parameters and simply re-casting particular items as mutable prior to returning them (so no deep cloning, just some additional type syntax). After going back over most of my current usage, I don't think I'm really getting much value out of this extra syntax beyond what's already being accomplished by functional/immutable-data.
So I think I agree, in my case (a library written in a functional style) it makes sense to just cut out enforcement around mutability in parameter or return types.
I'll go ahead and close this issue, thanks!


Feature/credentials filter

Changes

This PR is related to https://github.com/tektoncd/pipeline/issues/3373. The issue was closed by your bot but the topic is still relevant to us.
It solves the problem that secret values are printed to the output log. All secrets contained in the namespace of the pod will be redacted. The pod needs a service account token with permissions to read out all secret in the namespace from the api server.
I added a credential filter to the runner app of tekton steps. It reads out all secrets from the namespace of the pod and redacts them from the output log.
This is currently a draft, I would be happy to polish it if you have interest in adopting this approach.
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Docs included if any changes are user facing
[ ] Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including
functionality, content, code)
[ ] Release notes block below has been filled in
(if there are no user facing changes, use release note "NONE")

Release Notes

Any interest in this feature?

/ok-to-test

Thanks @Useurmind for your PR!
I think there is interest in the feature, it may be something that we let user control via a feature flag?
I'm sorry about the slow response - between KubeCon and cdCon it's a busy conference time :D
/cc @imjasonh @vdemeester

Then I will start implementing a feature toggle for it and will see that I add some tests.

So I started looking into this feature and implementing a feature flag for it. Currently I am not sure how a feature flag may be best implemented for this.
I have found the following points:

feature flag config map is only read and used in controller
but credential filtering is done in the entrypoint binary during task runtime
credentials filter needs a service account token that can read secrets and that is something which needs to be ensured when a pipeline is run

Point 1 and 2 could be solved handing down an argument or setting an environment variable to the entrypoint from the controller.
Point 3 probably must be solved by documenting the requirements for the credentials filter, so that pipeline creators can pay attention to it.
Does that approach make sense or is there an easier way?

The pod needs a service account token with permissions to read out all secret in the namespace from the api server.

This part worries me a bit. Does this feature require that all TaskRun pods now have more permissions than before, to be able to tell what to redact? That seems valuable, but it also may mean that TaskRuns that, e.g., execute kubectl get secrets will now be able to get all those secrets, unless we take extra steps to stop them.
Could this somehow query "all accessible secrets" instead, and redact whatever it can find, instead of requiring new access to all secrets in its namespace?
I wonder if this could also lead to more load on the API server, since every TaskRun would start by fetching all secrets in its namespace, which for clusters running lots of TaskRuns could cause problems.
Not saying we shouldn't do this -- redacting secrets would be great -- just curious about some of the implications around limiting access and being mindful to reduce API traffic.

Some more things to consider:
I would advice to extend this in the future so multiple secret detection algorithms can be used. Secrets have so many sources meanwhile that it becomes hard to configure one that works for everyone. This is a rather simple approach to read all secrets from the namespace. Others could be:

Read all secrets referenced in environment variables of your pod
Read all secrets referenced in volume mounts via csi drivers (this could depend on the csi secret provisioner)
Read secrets from secret parameter values of the task itself
... more?

Should we consider implementing one of those? Then the pod would only need access to its own resource and could detect the secrets from files and environment variables. But I am not sure it is as complete as the approach above. It is also more complicated to implement.

I thought about the implenentation again over the weekend. If there is currently no contact between tekton pipeline run pods and the API server it would be a grave error to require this in the future. It makes the whole design of the pipelines more complicated and the behaviour less stable and harder to predict.
Therefore, I would suggest the following approach, similar to my previous post but not the same:

The controller knows the created pods ressources exactly, he does not even need to contact the API server to read it
The controller can extract information about which secrets are linked into the pod, examples (not the actual secrets, just the locations):

environment variables: based on the secret ref value in the pod
files: based on CSI providers and secret refs volumes

This information is handed to the entrypoint which can extract the secrets from the locations and use them to redact them from the output

Much more complicated than the current implementation, but more in line with the current design and easier to reason about regarding the permissions because the pipeline pod will not need any new permissions.

Btw. as far as I understand the permission concept in k8s a user can either see all secrets in a namespace or none. If you want to hide resources from a user only partially, you need to put them in different namespaces. Seeing can be limited to listing or reading them. But in the end its all or none.

You can grant access to only certain Secrets in a namespace, e.g.:
apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
  namespace: my-ns
  name: only-this-secret-binding
rules:
- apiGroups: [""]
  resources: ["secrets"]
  resourceNames: ["only-this-secret"]
  verbs: ["get"]

In this case, I believe listing secrets for the namespace will only return only-this-secret, as you say, and like we want, so no additional permissions are required. It does mean that if the value of some-other-secret snuck into logs, it wouldn't be redacted, but I think that's fine and pretty well expected.

[...] This is a rather simple approach to read all secrets from the namespace. Others could be:
Should we consider implementing one of those? Then the pod would only need access to its own resource and could detect the secrets from files and environment variables. But I am not sure it is as complete as the approach above. It is also more complicated to implement.

I think what we have here is better than any more complicated solution that does more work to discover associated secrets. More complexity means more opportunity for bugs. 🐛

If there is currently no contact between tekton pipeline run pods and the API server it would be a grave error to require this in the future. It makes the whole design of the pipelines more complicated and the behaviour less stable and harder to predict. [...]

👍 Thanks for considering this! I think we should try to avoid contacting the API server if we can avoid it, but having the controller (that already knows secrets) pass them down to the entrypoint also has issues, namely, that the secret values must be passed via Pod spec, and now anybody who has pods.get permissions in that namespace can also read secrets 😢.
There are probably steps we could take to encrypt them and decrypt them using an entrypoint-only secret, but this sure is getting complex quickly 😅.
I'd be interested to hear what other folks think about this approach. @vdemeester @afrittoli @lbernick any concerns with just listing all accessible namespaced secrets, or do you think we should do more to discover them on the controller-side and securely pass them down?

Today I implemented the code to tell the pod where to find secrets, it has access to.
The controller looks for secret refs in volumes and env and also for CSI volumes referencing secrets. It saves the information in form of the names of environment variables and paths to files with secrets. The pod can then read those values and redact them.
I see opportunity for bugs but I also think it is simpler to configure and run.
This design does not transmit actual secrets. Only the places where the pod can find secrets it has attached to it. And those are the secrets that need to be redacted. Because only those can be used in the corresponding pipeline step.
What do you think of that?

The controller looks for secret refs in volumes and env and also for CSI volumes referencing secrets. It saves the information in form of the names of environment variables and paths to files with secrets. The pod can then read those values and redact them.
[...]
This design does not transmit actual secrets. Only the places where the pod can find secrets it has attached to it. And those are the secrets that need to be redacted. Because only those can be used in the corresponding pipeline step.
What do you think of that?

Oh gotcha, that's great, thanks for doing that!
So in this model, the entrypoint doesn't have to list secrets at startup, and only gets information from the controller about where to find secret values in env vars, directory paths, etc. That seems like the best possible way to do this. 👍

Yes the only thing remaining is the documentation and some testing, manually to convince myself and fixing one of the pipelines that does not work. Btw I am clueless what the problem of that pipeline is.

Btw I am clueless what the problem of that pipeline is.

That error is just (badly) telling you you need to gofmt that file. You can do that with gofmt -w pkg/credentials/filter/secret_extraction.go.

Ok in principal I am done with the code and have validated that it works on a test instance of tekton.
But I am fighting with the build pipeline here. Seems the integration tests and coverage jobs fail (it feels random).
What formal requirements should I fullfill for this feature? I have added some docs.

/test pull-tekton-pipeline-go-coverage

/test pull-tekton-pipeline-integration-tests

/test pull-tekton-pipeline-build-tests

Ok in principal I am done with the code and have validated that it works on a test instance of tekton.
But I am fighting with the build pipeline here. Seems the integration tests and coverage jobs fail (it feels random).
What formal requirements should I fullfill for this feature? I have added some docs.

Ok I fixed the bug in the integration tests. Now I need feedback.

Ping

Thanks for the updates and sorry for getting late on this @Useurmind

Shall we clean up the commit messages by squashing and coming up with a more descriptive one as the current one seems outdated and not compatible with what comes out from the discussion with Jason?
Can we have the commits rebased after the fixes?

Also some questions:

Do we need a TEP file to consolidate the discussions for the previous open questions?

Thanks for the updates and sorry for getting late on this, please let us know if you're still willing to work on the current issue @Useurmind

Shall we clean up the commit messages by squashing and coming up with a more descriptive one as the current one seems outdated and not compatible with what comes out from the discussion with Jason?
Can we have the commits rebased after the fixes?

Also some questions:

Do we need a TEP file to consolidate the discussions for the previous open questions?

I can do the grunt work.
Regarding the TEP: I dont know what requires a feature to provide a TEP. This feature does not require any changes to the CRDs so far, if that is a reason to create one.

I can do the grunt work. Regarding the TEP: I dont know what requires a feature to provide a TEP. This feature does not require any changes to the CRDs so far, if that is a reason to create one.

Thank you for continuing to work on this, and I'm sorry this didn't get a response for a while! Please also update the PR title and description to reflect the commit message.
In terms of whether to write a TEP: There's some detail here on when we find it useful to have a design proposal. It's a bit subjective, but it seems like some design-related questions were tackled during code review which is a sign it might have been helpful to have a TEP. I'm a bit confused about the responsibilities of each of the different components and it would be helpful to see some examples, plus this change has some discussion going on re: secrets access so we want to be a bit careful. I think it would be OK not to have a TEP, but having one would give a bit more clarity on how secrets are detected, how the PR controller and entrypoint are communicating, and make sure we've thought through things like whether we only want to redact secrets coming from Workspace bindings or whether we want to handle any kinds of volumes. (TBH, I'm a bit confused about how we would detect secrets coming from e.g. a CSI volume as is stated in the docs for this change?) It's a bit more work ahead of time, but makes it a lot easier as a reviewer to say confidently that this PR should be merged.

In terms of whether to write a TEP: There's some detail here on when we find it useful to have a design proposal. It's a bit subjective, but it seems like some design-related questions were tackled ...

So I had a look at this and when looking at your questions and how to answer them a TEP is probably the best solution to do so. Therefore I started writing one. Will get back to you once I have something ready.

I created a TEP for this in: https://github.com/tektoncd/community/pull/866

/retest

I am done changing the code to adapt it to the concept in the TEP.
Any more comments on this or can we merge it?


no 'dist' folder created when running 'npm install arcgis-to-geojson-utils' on commandline

why is npm run bundle called for arcgis-to-geojson-utils after its installed via the dependency here, but the same script is not run when the package is installed via the commandline?
$ npm install arcgis-to-geojson-utils

i haven't been able to figure out how to use the module when its still native ES6.

Looks like I need an empty .npmignore file otherwise the .gitignore removes dist from the published version.
I'm doing these a little differently then Esri Leaflet. In Esri Leaflet we ship ES 6 with directions for every compiler/toolchain/whatever on how to compile it. This was a great experiment and I'm glad it worked but it is in general a total mess. It is way easier to do what I am doing here and ship compiled code with a special jspm directive for ES 6.

:bulb: makes a lot more sense now.

In Esri Leaflet we ship ES6 ... it is in general a total mess

agreed!

try running npm pack before publishing to confirm that the .zip is gone and the distvv is there.

Looks like we should be good now.

confirmed.  thanks!


Sort within group on ecosystem page: https://developer.algorand.org/ecosystem-projects/

The current state
It is getting harder to "read" the page  with so many new entries now that we are accepting new submissions thru the portal. They are not alphabetical within each group. There is not an easy way to rearrange them when entering and/or displaying. Group headers could be sorted as well.
The proposed state
Automatically sort alphabetical in each category.  Snapshot attached showing order is the way they were entered. Sort categories as well would make sense too.
Provide any additional context
Maybe add a sort by field w order number within group when entering the new tools here, as well as an order number on the category list headers.  https://developer.algorand.org/cp/community/ecosystemprojectcategory/

This was completed to what seems to be a long time ago. Closing.


Create the obj-c extractor. [phab:D1038]

Created by salguarnieri at 2016-09-06 21:40:36:
This is a small diff on the cxx extractor.

salguarnieri wrote at 2016-09-06 21:45:56:

make scripts executable

zarko wrote at 2016-09-06 23:34:30:
Is it possible to include a unit test that runs the extractor on a hello, worldish example?
Do we need to put the Bazel-owned scripts in third_party?

salguarnieri wrote at 2016-09-06 23:41:35:

! In (earlier comment), zarko wrote:
Is it possible to include a unit test that runs the extractor on a hello, worldish example?

I'll see if I can add one. I didn't see one for the cxx bazel extractor, should I create one for that also or did I miss it?

Do we need to put the Bazel-owned scripts in third_party?
Maybe. I carved apart a single script from them (https://github.com/bazelbuild/bazel/blob/master/src/tools/xcode/xcrunwrapper/xcrunwrapper.sh) so I'm really unsure what is the right thing to do.

zarko wrote at 2016-09-07 00:00:33:

! In (earlier comment), salguarnieri wrote:

! In (earlier comment), zarko wrote:
Is it possible to include a unit test that runs the extractor on a hello, worldish example?

I'll see if I can add one. I didn't see one for the cxx bazel extractor, should I create one for that also or did I miss it?

You're right; it doesn't look like we have that hooked up. (I'd initially thought that cc_verifier_test uses it, but reality differs.) It would be better to keep this diff ObjC-only and to consider adding one of the cxx extractor separately.

Do we need to put the Bazel-owned scripts in third_party?
Maybe. I carved apart a single script from them (https://github.com/bazelbuild/bazel/blob/master/src/tools/xcode/xcrunwrapper/xcrunwrapper.sh) so I'm really unsure what is the right thing to do.

We've already got some stuff in third_party/bazel; you could move the scripts there and nore in the README.google that you extracted them from xcrunwrapper (at a specific SHA, not master). Maybe fromberger would know a better thing to do.

salguarnieri wrote at 2016-09-07 01:14:29:

! In (earlier comment), zarko wrote:

! In (earlier comment), salguarnieri wrote:

! In (earlier comment), zarko wrote:
Is it possible to include a unit test that runs the extractor on a hello, worldish example?

I'll see if I can add one. I didn't see one for the cxx bazel extractor, should I create one for that also or did I miss it?

You're right; it doesn't look like we have that hooked up. (I'd initially thought that cc_verifier_test uses it, but reality differs.) It would be better to keep this diff ObjC-only and to consider adding one of the cxx extractor separately.

Will do. I was hoping that you'd magically say there was something I could copy and paste, but no such luck :) I'll create a ticket for a cxx test as well so I/we don't forget.

Do we need to put the Bazel-owned scripts in third_party?
Maybe. I carved apart a single script from them (https://github.com/bazelbuild/bazel/blob/master/src/tools/xcode/xcrunwrapper/xcrunwrapper.sh) so I'm really unsure what is the right thing to do.

We've already got some stuff in third_party/bazel; you could move the scripts there and nore in the README.google that you extracted them from xcrunwrapper (at a specific SHA, not master). Maybe fromberger would know a better thing to do.

Moved to third_party bazel and updated readme

salguarnieri wrote at 2016-09-07 01:15:03:

move xcode helper scripts

salguarnieri wrote at 2016-09-08 22:28:20:
switch to re2, put objc extractor helper functions into their own file to make testing easier, add unit tests, add an integration test for objc bazel extractor.

salguarnieri commented inline (context lost during migration) at 2016-09-08 22:31:56:
note that we won't run this in presubmit

salguarnieri commented inline (context lost during migration) at 2016-09-08 22:31:56:
note that we won't run this in presubmit

salguarnieri wrote at 2016-09-08 22:31:56:

! In (earlier comment), salguarnieri wrote:

! In (earlier comment), zarko wrote:

! In (earlier comment), salguarnieri wrote:

! In (earlier comment), zarko wrote:
Is it possible to include a unit test that runs the extractor on a hello, worldish example?

I'll see if I can add one. I didn't see one for the cxx bazel extractor, should I create one for that also or did I miss it?

You're right; it doesn't look like we have that hooked up. (I'd initially thought that cc_verifier_test uses it, but reality differs.) It would be better to keep this diff ObjC-only and to consider adding one of the cxx extractor separately.

Will do. I was hoping that you'd magically say there was something I could copy and paste, but no such luck :) I'll create a ticket for a cxx test as well so I/we don't forget.

Do we need to put the Bazel-owned scripts in third_party?
Maybe. I carved apart a single script from them (https://github.com/bazelbuild/bazel/blob/master/src/tools/xcode/xcrunwrapper/xcrunwrapper.sh) so I'm really unsure what is the right thing to do.

We've already got some stuff in third_party/bazel; you could move the scripts there and nore in the README.google that you extracted them from xcrunwrapper (at a specific SHA, not master). Maybe fromberger would know a better thing to do.

Moved to third_party bazel and updated readme

Added tests, should be ready for review now.

zarko commented inline (context lost during migration) at 2016-09-09 22:16:22:
nit: these global functions should start with a capital letter.

zarko commented inline (context lost during migration) at 2016-09-09 22:16:22:
nit: 2016 (here and elsewhere)

zarko commented inline (context lost during migration) at 2016-09-09 22:16:22:
What does this function do when the script dies due to an error?

zarko commented inline (context lost during migration) at 2016-09-09 22:16:22:
Is there something in llvm::StringRef you could use for this?

zarko commented inline (context lost during migration) at 2016-09-09 22:16:22:
Also add the "manual" tag.

salguarnieri wrote at 2016-09-09 22:43:34:

address comments

salguarnieri commented inline (context lost during migration) at 2016-09-09 22:44:07:
Thankfully yes

salguarnieri commented inline (context lost during migration) at 2016-09-09 22:44:07:
The function should return the empty string in that case.

salguarnieri wrote at 2016-09-12 22:44:29:

Make script +x

zarko wrote at 2016-09-12 23:26:29:
Note #1385 (which this appears to tickle). Checking over the rest now.

zarko commented inline (context lost during migration) at 2016-09-12 23:44:14:
nit: you probably want ".objc.kindex" here and on line 39

zarko commented inline (context lost during migration) at 2016-09-12 23:44:14:
There doesn't appear to be a dependency between this rule and objc_lib.{m,h}. Since I expect adding a direct dependency on objc_lib would be very inconvenient, consider adding objc_lib.{m,h} as data for this test.

zarko commented inline (context lost during migration) at 2016-09-12 23:44:14:
There are no assertions in either of the source files, so it's not clear that the entries ever hit the verifier. If I add a broken assertion (//- bad) to objc_lib.m, :objc_lib_test still succeeds.

zarko commented inline (context lost during migration) at 2016-09-12 23:52:56:
Aha, you're actually running the verifier on the .xa:
cat objc_lib_test
#!/bin/bash -e
set -o pipefail
gunzip -c kythe/cxx/extractor/testdata/objc_lib_test.compilation/kythe/cxx/extractor/testdata/objc_lib.xa.entries.gz | kythe/cxx/verifier/verifier --ignore_dups kythe/cxx/extractor/testdata/objc_lib.xa

This should probably be run on the .m and the .h. Maybe the .xa should be the data and the test source should be the srcs?

salguarnieri commented inline (context lost during migration) at 2016-09-13 00:23:38:
Added assertions

salguarnieri commented inline (context lost during migration) at 2016-09-13 00:23:38:
updated to do that. Let me know if I understood you correctly.

salguarnieri wrote at 2016-09-13 00:24:06:

Address comments
Update xa file for objective c.

salguarnieri wrote at 2016-09-13 00:45:45:

swap c++ for objc in strings

zarko wrote at 2016-09-13 00:50:49:
Thanks for hitting all the comments.

zarko accepted this revision at 2016-09-13 00:50:49

salguarnieri closed via commit 455429c993582f05f59e46891b737cb82cf5497c at 2016-09-13 00:55:29


[stdlib] Deprecate CommandLine.arguments setter

This is based on @natecook1000 's previous PR https://github.com/apple/swift/pull/69981 to deprecate CommandLine.arguments setter and fully obsolete it in Swift 6.0. This adds a nonisolated(unsafe) on the new _arguments static var to silence the warning when -strict-concurrency=complete. Note that this is actually unsafe is not correct because we do not synchronize access to this storage 🙂

@swift-ci please test

Do we not want to take Nate's original PR? :)

This caused a lot of innocuous looking code in the compiler build to start emitting diagnostics. For example:
/Users/allan/Projects/swift/swift-project/swift/stdlib/private/StdlibUnittest/StdlibUnittest.swift:1743:17: warning: setter for 'arguments' is deprecated: Do not modify CommandLine.arguments. It will become read-only in a future version of Swift.
1741 │     i += 1 // Skip the name of the executable.
1742 │     while i < CommandLine.arguments.count {
1743 │       let arg = CommandLine.arguments[i]
     │                 ╰─ warning: setter for 'arguments' is deprecated: Do not modify CommandLine.arguments. It will become read-only in a future version of Swift.
1744 │       if arg == "--stdlib-unittest-in-process" {
1745 │         runTestsInProcess = true

It's fairly clear that this is incorrectly diagnosed since let arg = CommandLine.arguments[i] should not invoke the setter for arguments, but we're going to need to fix this diagnostic.


[Dashboard] Improve ordering by size performance

Context
Ordering datasets by size take a huge amount of time to apply
Steps to Reproduce

You need an account with hundreds/thousands of datasets
Click in order by size
Wait until it finishes

Current Result
Now it takes, in my test account, either ~47seconds or a timeout error
Expected result
Reduce that amount of time considerably
// @alonsogarciapablo

Here are some examples of the time spent calling the endpoint with order by size:
Timeout

Finished but after ~47 seconds

Update
I've made a couple of PoC to check if there is any improvement:

I've made a new function in our PostgreSQL extension that I'm going to use in order to gather all the tables information
I've changed the orderer class to include a call to that new function instead of using the .size attribute which makes a call to the user database in order to retrieve the size of the table.

The results is the following:
Current performance

Improved performance

As you can see there is a huge improvement using that new function, a magnitude order with accounts having a great number of tables.
What's next?
Well, there is a lot to do:
Be sure if we want to go on with this improvement because we need to spend more time here and   implies multiples parts (@alonsogarciapablo / @javitonino ). If we decide to go on we have to:

Finish the PostgreSQL function, there are some problems yet, fix the tests, test it and put into production
In the rails app part, we have to figure out how to include this new way of order some types (size, mapviews, etc) and possibly made a refactor in our query_orderer

WOW. That looks like a huge improvement @ethervoid! Does it only help with "ordering by size" or with retrieving maps / datasets in general?

@alonsogarciapablo this would help in the ordering part for calls to the api/viz endpoint. In our dashboard is done by the order part but if we ask for visualizations orderer by size this improvement applies.
What do you mean for retrieving maps/datasets?

I was basically asking if this will only help when ordering by size, or also in other calls to /viz (eg: when loading latests maps and datasets for the home page).

This will only help for the ordering part

Hey @ethervoid! How is this going? Are we still working on it? Thank you! 🙇

This has been stopped. There were still a lot of work to do and there is no backenders working on the dashboard as of now.

Closing for now. Let's reopen is this becomes an issue.


check stream is closed??

check stream is closed??

check stream is closed??

@dreamwk
well it is just, too hard to do.


[PP-1456] Add loan count column to audio book playback time reports.

Description
As the title indicates, this PR adds a loan count column to the audio book playback time reports.
When playback time data comes in through the API,  the code attempts to resolve the loan associated with the audio book and patron.  If the loan cannot be found (ie because it was purged) we use the user's patron id.  Then we create a sha1 of the loan or patron ID in order to uniquely identify the loan.
Then on the reporting side, we perform a count of the unique loans within the time range and join that count to the seconds summation query.
The default value for the loan_identifier is an empty string.  Since we don't have a way of associating loans or patrons with existing playtime records, I don't see a good way of counting old playtime entries and summaries.  Once the start date of the reporting window passes the date of the release of this update to production the loan counting will be correct.
Before that, it will be one loan per unique isbn, collection, library.
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-1456

How Has This Been Tested?
Updated the existing tests and added addition assertions.

Checklist

[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.

@tdilauro :  I've made updates to the PR to address the issues you raised.


Can not render text behind a container in a ListView.

Steps to Reproduce

It seems render correctly if text write before the red container.

But if the text write behind the red container, all the blue container dismiss.

The bug dismiss if I remove the transition animition of this page.

Can you provide the source code of a short application that demonstrates this problem?
I don't understand exactly what you mean.

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Add BytesFilterCollector to support filtering based on a bytes fast field

We ran into #1333 today and after implementing a specialized filtering collector for our use case, I thought it might be a nice community service if fewer people would have to copy & paste this code in the future by providing a variant of FilterCollector specialised to work on a bytes fast field.
This seems especially useful as this has gotten a bit more complicated since the introduction of Columnar and BytesColumn. (I am not sure if I have used to API optimally myself.)
I also tried to boy-scout the existing FilterCollector a little bit while I was working on the module.

(The example is silly of course, but I was unable to come up with something nicer on the spot. In our use case, we have serialized geometry stored in that bytes fast field which I think would be too involved for the example here.)

Codecov Report

Merging #2075 (b6c2ce3) into main (4b7c485) will increase coverage by 0.00%.
The diff coverage is 96.34%.

:exclamation: Current head b6c2ce3 differs from pull request most recent head 4480b3d. Consider uploading reports for the commit 4480b3d to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main    #2075   +/-   ##
=======================================
  Coverage   94.38%   94.38%
=======================================
  Files         319      319
  Lines       60041    60088   +47
=======================================
+ Hits        56670    56715   +45
- Misses       3371     3373    +2

Impacted Files
Coverage Δ

src/collector/mod.rs
54.63% <ø> (ø)

src/collector/filter_collector_wrapper.rs
94.57% <96.34%> (-0.55%)
:arrow_down:

... and 1 file with indirect coverage changes

@adamreichold The filter collector semantics were a bit obsolete now that we handle any cardinality for doc values. I tweaked it a little. (not your BytesFilterCollector, the original one too)
Can you have a look at my commit?
Also, are you using this in production? The BytesCollector is now using dictionary encoding...
I wouldn't be surprised if you experience a strong performance with the new Columnar implementation.
Let me know if this is used for something "serious", in which case we should offer the possibility to have a different encoding for Bytes fields.

@adamreichold The filter collector semantics were a bit obsolete now that we handle any cardinality for doc values. I tweaked it a little. (not your BytesFilterCollector, the original one too)
Can you have a look at my commit?

Are you sure you pushed this somewhere? I cannot see any new commits on the PR here or on the main branch. The last change to this module appears to be bd5eea98527e74d7f57dd39d62e4ab25ce8a5e5b on which this PR is based.

Also, are you using this in production? The BytesCollector is now using dictionary encoding... I wouldn't be surprised if you experience a strong performance with the new Columnar implementation. Let me know if this is used for something "serious", in which case we should offer the possibility to have a different encoding for Bytes fields.

Well, we are using the equivalent functionality for Tantivy 0.19 in production. (We cannot upgrade to 0.20 until #2085 is resolved.)
I think for now, I can work around this because our geometry is simple enough (just bounding boxes, i.e. uniformly four floats) that I can replace the serialization of the geometry by just pulling out the individual coordinates of a multi-valued f64 fast field.
This still means I cannot use FilterCollector but rather have to write a bespoke collector to handle the cardinality and this approach breaks down when the geometry becomes an arbitrary feature collections which cannot be encoded as just a list of coordinates.

@adamreichold oops sorry i just saw you already reported the perf regression.
I opened #2090 accordingly.
Apprarently I cannot push, so I created issue/2075-bytes-filter-collector

I opened https://github.com/quickwit-oss/tantivy/issues/2090 accordingly.

Thanks for considering this.

Apprarently I cannot push, so I created issue/2075-bytes-filter-collector. Note it does not solve your performance problems at all.

Strange, I did check that box:

Will pull the commit into this PR manually...

Will pull the commit into this PR manually...

I pulled the commit in. I also fixed some nits throughout the code base as the Clippy build was getting somewhat noisy.
Finally, I took the liberty of adding one more commit adding a CONJUNCTION const parameter to the two collectors which determine whether they use any (as in your commit) or all semantics (by constructing the filter via new_conjunction instead of new).
The changes does make the type signatures even more unwieldy and the complexity might be confusing. So let me know what you think I can just drop that commit from the PR if it is too much.

@adamreichold I invited you to the tantivy-dev org, so you can push PR to tantivy-search in the future.

Finally, I took the liberty of adding one more commit adding a CONJUNCTION const parameter to the two collectors > > which determine whether they use any (as in your commit) or all semantics (by constructing the filter via
new_conjunction instead of new).

The changes does make the type signatures even more unwieldy and the complexity might be confusing. So let me
know what you think I can just drop that commit from the PR if it is too much.

Can we remove the conjunction stuff?

Can we remove the conjunction stuff?

Sure enough, I put it into separate commit because I was not sure whether it was a good thing to add myself.


Camera2Video record with overlay

I am using the Camera2Video sample. I can record a basic camera preview output using this sample.
However, I want to draw something on top of the preview and then include that overlay in the final video captured in realtime (no post-processing). Is there a method to do this?

Essentially, this is what the HDR example does.

My phone camera does not have the minimum capabilities.  But I was able to get it to work.
It does not record anything to a file though.
Is there a sample where I can capture the camera output with say a watermark image overlaid on top of it?
So in realtime camera records with the watermark and then we can directly play the recorded video from the disk.

@patolax this might be a better question for StackOverflow.
Here's an example of an activity which overlays some graphic on top of the camera feed, although it uses CameraX: https://github.com/owahltinez/androidx-camera-activity

I think you misunderstood. I want the overlay to be included in the capture. Your sample crops the capture. Regardless I want to capture video. Photos can be done easily using a canvas.
I have been searching for two weeks now, unfortunately, did not find anything yet. Yet, TikTok and Snapchat have done it years ago. Maybe it requires a big engineering team to do it.
My scenario is simple, capture a video with a filter or with an extra dynamic graphic drawn on it.

I think cameraX not support add watermark realtime
we need to add features


More than one device being logged in and in charge

Hi all,
I think I noticed that if you are logged in with more than one device, the system gets confused.
I drove my bot today into the toolsbay, everything was properly programmed, not obvious problems so far. But I guess because I am programming the sequences on a desktop PC inside and then going outside and starting the testsequence on my iPhone something gets mixed up. There is not difference between firefox or chrome on the mobile.
Is there something how I could help you to debug? Hard to do that if the log is not working at all...

@Klimbim1 FarmBot OS does not support multiple user sessions right now. I recommend logging out of one account before starting a new session in a different device, and also making sure to push the "SYNC" button after saving changes.

@RickCarlino: wouldn´t it be an idea to intercept the problems arising through these multiple sessions if you intercept multi log ins? Just tell that you are already logged in another device?
The problem is, I guess many people are using some sort of PC inside and something mobile outside... They would need to know that it is currently not supported. Otherwise they are having interesting things going on like me, but don´t know that they are related to multiple user sessions...

It's a very good idea, @Klimbim1 and we hope to support multi-user bots in the future. Right now, the system was designed with the assumption that there is only one active user session per bot. There are no tracking mechanisms for sessions at this time, which is why I recommend not controlling the bot from two different user sessions. In the mean time, I may add version locking to a future release to hopefully clear up confusion about this.
With regards to your question about syncing, the bot avoids changing local records (sequences, regimens, plants, etc) without pressing the "SYNC" button first. There were a number of factors we had to consider when we made this decision, but ultimately we decided that it is better to not change the data on the device unless the user explicitly presses the "sync" button.
To answer your question though, yes, if you make changes to sequences or regimens you will need to push the "SYNC" button before logging out. You could also "save", log out and then "sync" from another device as well.


[Help] More drive and folder

How to add more drive and folders kindly help me and how to configure drive and folder name in GDindex

There is no such feature


Multiple cleanups

what

Partly revert #236 (see discussion below)
Allow explicitly naming parameter group
Use full name of engine for reserved DB instances
Implement and close #197
Implement and close #199
Implement and close #230
Implement and close #237
Implement and close #239

why

Closes #241
Closes #225
Instance engine should match cluster engine
Consolidate PRs

discussion: why revert #236
PR #236 enhanced the random_pet that determines part of the name of the DB instances so that the name would change whenever the instances would need to be recreated. Unfortunately, as a side-effect, that causes all instances created with earlier versions of this module to be replaced.
Upon further investigation, it was determined that all the "keepers" added by the PR would also force the cluster to be replaced. Unlike replacing an instance, replacing the cluster results in data loss. Also, unless you change the name of the cluster, the module both before and after the PR would fail, because it would try to create a new cluster with the same name before destroying the old cluster.
We prefer this failure mode, requiring the user to explicitly destroy the cluster before creating the new one, because it puts the user on notice about the potential data loss. So given that the changes in the PR did not make something work that did not work before, and it did cause disruption, we reverted the change to the keepers.

/terratest

Appreciate this! Thanks for maintaining this module @Nuru 🙌

Ahhh I totally forgot about that. Thanks for pointing that out!
On Sun, Dec 8, 2024 at 00:40 Nuru @.***> wrote:

@.**** commented on this pull request.
In main.tf
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/242#discussion_r1874619548
:

reserved_instance_engine = split("-", var.engine)[1]

reserved_instance_engine = var.engine

The product description is supposed to match the engine exactly.
aurora-mysql and mysql are separate available engines.
—
Reply to this email directly, view it on GitHub
https://github.com/cloudposse/terraform-aws-rds-cluster/pull/242#discussion_r1874619548,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIR4SQYTV6JKUNUB6CD7OED2EPLVJAVCNFSM6AAAAABTG3O2Q2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOBWG4ZTIOBTHA
.
You are receiving this because you commented.Message ID:
@.***
com>


ENGDOCS-231: update the intro statement

Fixes https://docker.atlassian.net/browse/ENGDOCS-231

Deploy preview for docsdocker ready!
Built with commit 29eb61f22841f3e192f9a55641d9dc1508e92bae
https://deploy-preview-9735--docsdocker.netlify.com

@traci-morrison Could you PTAL?


updated jenkins plugin (credentials) to v2.1.17 to fix current test-j…

…enkins job failure

monitoring structs v1.14 (as credentials dependency states structs v1.17 (which we cannot currently find))


Bring team member up to speed on services where they are the backup

This issue is to spend some time with the backup team member for KT so they can support said services.

Met with Yuhan to talk her through the remomounte and get her involved in the GitHub initiative.


Fix liquid-syntax error parsing

Why:
https://github.com/github/docs/actions/runs/9506483722/job/26203752861#step:5:14
> lint-content
> node src/content-linter/scripts/lint-content.js --print-annotations --paths data/reusables/actions/jobs/matrix-used-twice.md content/actions/using-jobs/using-a-matrix-for-your-jobs.md

- Running content linter

file:///home/runner/work/docs/docs/src/content-linter/lib/linting-rules/liquid-syntax.js:[8](https://github.com/github/docs/actions/runs/9506483722/job/26203752861#step:5:9)0
      const range = [columnNumber, line.slice(columnNumber - 1).length]
                                        ^

TypeError: Cannot read properties of undefined (reading 'slice')
    at Object.GHD018 [as function] (file:///home/runner/work/docs/docs/src/content-linter/lib/linting-rules/liquid-syntax.js:80:41)
    at invokeRuleFunction (/home/runner/work/docs/docs/node_modules/markdownlint/lib/markdownlint.js:735:51)
    at forRule (/home/runner/work/docs/docs/node_modules/markdownlint/lib/markdownlint.js:746:7)
    at Array.map (<anonymous>)
    at lintContent (/home/runner/work/docs/docs/node_modules/markdownlint/lib/markdownlint.js:813:44)
    at lintContentWrapper (/home/runner/work/docs/docs/node_modules/markdownlint/lib/markdownlint.js:866:[12](https://github.com/github/docs/actions/runs/9506483722/job/26203752861#step:5:13))
    at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read/context:68:3)

The error message had:
unexpected token "", value expected, line:29, col:65'

And splitting on , does not result in a happy world

What's being changed (if available, include any code snippets, screenshots, or gifs):
Fix the pattern to have a better chance of extracting line and col.
Check off the following:

[ ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[ ] For content changes, I have completed the self-review checklist.

@jsoref Apologies for the delay - thanks so much for opening a PR! I'll get this triaged for review ✨

@jsoref Hello! 👋 After review from our team, we will need to address this issue internally given this involves our src files. Thanks for raising the flag on this issue, and your willingness to assist 💛 I'll go ahead and close out this issue.


Fix internet based personalities (gpt4internet & low)

Resolved issues listed here https://github.com/ParisNeo/lollms-webui/issues/480
The rest of the personalities still need to be tested.
The most useful one that I fixed was GPT4Internet.

@ParisNeo Please review and approve.
Also please look at the rest of the personalities being called by the old run_workflow definitions and update.

Thanks for your contribution

I will update the old personas. With the new format.

I will update the old personas. With the new format.

You're welcome
@ParisNeo I just looked through the code and found 3 that need to be changed:
Thinking_methodologies/tree_of_thoughts (which you already did)
Additionally:
Thinking_methodologies/chain_of_thoughts
data/database_maker
data/text2bulletpoints
After these are done, I can close this issue iA


Update tocbox

Commit Summary:

New feature

tocbox

Minor Update

change default device size (media query)
<h4> is no more allowed in main post

Merge branch 'master' into rbss
Is it mistake or it's intentionally done?

Accidently pulled master branch.
I found no errors yet, but I'll be careful not to let this happen again.


vivaldi: 2.0.1309.29-2 -> 2.1.1337.36-1; vivaldi-ffmpeg-codecs: 69.0.3497.73 -> 70.0.3538.77

Motivation for this change

Update vivaldi to version vivaldi to version 2.1.1337.36-1
Update vivaldi-ffmpeg-codecs to version 70.0.3538.77

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: vivaldi, vivaldi-ffmpeg-codecs
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: vivaldi, vivaldi-ffmpeg-codecs
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: vivaldi-ffmpeg-codecs
The following builds were skipped because they don't evaluate on x86_64-linux: vivaldi
Partial log (click to expand)
[613/613] python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libffmpeg.so" --tocfile="./libffmpeg.so.TOC" --output="./libffmpeg.so" -- g++ -shared -Wl,-Bsymbolic -L gen/third_party/ffmpeg -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -m64 -Wl,-O2 -Wl,--gc-sections -rdynamic -o "./libffmpeg.so" -Wl,-soname="libffmpeg.so" @"./libffmpeg.so.rsp"
glibPreInstallPhase
installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/my46nnpf2a2zmphkg5nm85fi677w2x9k-vivaldi-ffmpeg-codecs-70.0.3538.77
shrinking /nix/store/my46nnpf2a2zmphkg5nm85fi677w2x9k-vivaldi-ffmpeg-codecs-70.0.3538.77/lib/libffmpeg.so
patching script interpreter paths in /nix/store/my46nnpf2a2zmphkg5nm85fi677w2x9k-vivaldi-ffmpeg-codecs-70.0.3538.77
checking for references to /build in /nix/store/my46nnpf2a2zmphkg5nm85fi677w2x9k-vivaldi-ffmpeg-codecs-70.0.3538.77...
/nix/store/my46nnpf2a2zmphkg5nm85fi677w2x9k-vivaldi-ffmpeg-codecs-70.0.3538.77


Release to Maven Central

Deploy linter to maven central so that it can be used as a dependency in other maven/gradle projects.
It's ok to be able to deploy from a local env as a first step. The goal is to be able to deploy from Travis builds on the master branch.

The Sonatype user account already exists. Ask me for Sonatype username and password
Our GroupId is com.github.jpmorganchase.*

Uploaded linter project to maven central from local.
Please check at https://repo1.maven.org/maven2/com/github/jpmorganchase/lint-assert/core/0.1.7/

done.


Multiple outputs for Rmarkdown scripts

As discussed on the course, it would be great to be able to run Rmarkdown scripts with multiple outputs so that both the html and data objects could be generated from the same file e.g.
rule all:
input:
"res/dds_star.RDS",
"res/report.html"
rule tidy_star:
input:
counts="file1.RData",
phenotypes="file2.RData"
output:
html="res/report.html",
dds="res/dds_star.RDS"
script:
"workflow/scripts/tidy_star_output.Rmd"
Would it be possible to remove the restriction on only having one output for .Rmd files?
Many thanks,
Mary-Ellen

this is my workaround
    shell:
#     # snakemake removes all single quotation marks from a command therefore we use triple
#     # quotation for the outside string
        """R -e 'wd = getwd(); \
                  rmarkdown::render( "{input[0]}" \
                                  , output_file = normalizePath( paste0( wd,"/" ,"{output[0]}" ) ) \
                                  , params = list(in = "{input[1]}"  \
                                                  , out = "{output[1]}" ) \
                                  , knit_root_dir = getwd() \
                                  , envir = new.env() )' \
        """


Getdeck is causing issues on MacOS

When building the Tooler container image for the user it says
[CRITICAL] There was an error running Deck: The command '/bin/sh -c addgroup -g {GROUP_ID} ... returned a non-zero code: 1

It seems that it is not possible to run the function
https://github.com/Getdeck/getdeck/blob/d941d6940d551841b136f3cf598203866e0c08c4/getdeck/sources/tooler.py#L75-L103
without an error.

This should be solved in version 0.7.1


Neo4jrb errors refactors

@subvertallchris
I tried to improve a bit errors, referring to #1104
I cherry-picked some ideas from ActiveRecord and MongoMapper. Any suggestion is welcome!

I like this a lot. Do you think any of it should be moved into https://github.com/neo4jrb/neo4j/blob/master/lib/neo4j/errors.rb? ActiveRecord uses one errors.rb, https://github.com/rails/rails/blob/master/activerecord/lib/active_record/errors.rb, though I'm not sure if that's for all of their errors or just some.

I found a few errors of ActiveRecord that are not in errors.rb, but they are just a couple:
https://github.com/rails/rails/blob/a461dbd637791d3bd399007f234a1ca5c919e199/activerecord/lib/active_record/associations.rb#L17
https://github.com/rails/rails/blob/428d47adfed8d6aa7b21aec2bf5ad890961c9de3/activerecord/lib/active_record/validations.rb#L13
So we can assume that all "main" errors in active record are in the errors.rb file.
I'm not sure how to deal with this. I think I don't have a complete knowledge about all neo4j errors, so please help me with this.
For example:

I can't find any reference about this error:
https://github.com/neo4jrb/neo4j/pull/1114/files#diff-dfd59f2a8fc368af1d19efadf9411bb8R23
Is it an old entry?

All children of Neo4j::InvalidParameterError may be replaced with the more generic Neo4j::InvalidParameterError. Example:
https://github.com/neo4jrb/neo4j/pull/1114/files#diff-c2bb410db73f7a12d959186c21eb7bd3R4

Instead UnsetRelatedNodeError can stay there, since it's quite specific: https://github.com/neo4jrb/neo4j/pull/1114/files#diff-fcd30cb21891b2b381a6385f88287956R7

Finally, I'm not sure how to deal with this: https://github.com/neo4jrb/neo4j/pull/1114/files#diff-d883afb716d52a87e075fde8d7dbe1f7R12 . Should it be a child of Neo4j errors or not?

That first one, InvalidQueryError, came from https://github.com/neo4jrb/neo4j/commit/c7b964c8e4da4722c025540282def1f49272869a. It looks like it was for a very specific condition which no longer exists, so I think we can axe it.
The second one can probably be moved into Errors and they can all use that one definition.
:+1: where UnsetRelatedNodeError is concerned.
UndefinedPropertyError should be a child of Neo4j errors, if to identify it as coming from us if nothing else.
How's this sound? Thanks again for looking into all this, it's a huge help.

Ok, I fixed everything you said.
I also merged with master, since there were a few conflicts!
Please take a look :mag:

Thanks from me as well!  This looks great!

This is coooool! Would you just throw details about the changes into the CHANGELOG and we can roll with it?

Done. Maybe it's a bit verbose...

I don't think you will ever hear me or Brian complain that something is verbose. ;-)
I'll do the merge once Travis signs off.

I can't believe how long Travis takes now. WTF.

Hrmm, I imagine we don't need to check every version of Ruby against every version of Neo4j.  Or maybe there would be a way to have build priorities so that certain jobs are required to pass and the other ones can run whenever.  It would be particularly nice if those required jobs took priority over jobs from previous builds which haven't been pulled up yet.

Regarding the errors, I hate to bring things up semi-last minute, but this is something that people might start depending on and so I wanted to talk about what I was thinking.
The definition of "Neo4j.rb" has wavered somewhat.  In the past I think in referred to the neo4j gem, though it always made sense to be to call the various gems that we maintain (like neo4j, neo4j-core, and neo4j-rake_tasks most importantly) the Neo4j.rb project.  So in this case I'm not sure if Neo4jrbError makes sense.
I could see perhaps Neo4j::StandardError.  Alternatively as part of my refactoring I created a Neo4j::ActiveBase module which deals with logic that is global to ActiveNode and ActiveRel, so maybe it could be in there?
Thoughts?

Regarding travis, this might be something to consider:
https://docs.travis-ci.com/user/customizing-the-build/#Fast-Finishing
Also, of course, my idea was not original:
https://github.com/travis-ci/travis-ci/issues/2566

@cheerfulstoic
Some random thoughts, maybe they could be useful:
I understand what you mean... but I really don't like Neo4j::StandardError. I think it's a confusing to have an error name for a gem that have the name of the most general error in ruby.
In MongoMapper, for example, they simply use MongoMapper::Error. Maybe we can follow the same convention.
https://github.com/mongomapper/mongomapper/blob/master/lib/mongo_mapper/exceptions.rb
Neo4j::ActiveBaseError instead, could be ok, but the term ActiveBase is not (yet) in the "vocabulary" of a neo4jrb user, so it's kind a "unknown" word.

Yeah, that's a good point.  I'm not sure what I was thinking with StandardError ;)
I'm fine with Neo4j::Error, actually.  Does that work for you?

For me it's ok. I'll rename them all and fix conflict, if you're all agree!

Yep, if you made that change I would be :smiley: !

Done! Take a look :wink:

LGTM, thanks!  @subvertallchris I'm :+1: to merge this.  Feel free to click the big green button if you're good too

Rad, I'll check it out when I get to the office.
On Thursday, January 28, 2016, Brian Underwood<EMAIL_ADDRESS>wrote:

LGTM, thanks! @subvertallchris https://github.com/subvertallchris I'm [image:
:+1:] to merge this. Feel free to click the big green button if you're
good too
—
Reply to this email directly or view it on GitHub
https://github.com/neo4jrb/neo4j/pull/1114#issuecomment-176209917.

Pulling the trigger. @ProGM, great work!


Cviebrock/eloquent-sluggable drops support for php < 7.0

Our signature in https://github.com/Laravel-Backpack/CRUD/blob/master/src/ModelTraits/SpatieTranslatable/SluggableObserver.php
protected function generateSlug(Model $model, $event)

His signature in https://github.com/cviebrock/eloquent-sluggable/blob/master/src/SluggableObserver.php
 protected function generateSlug(Model $model, string $event)

Typehinting a string.
Dropping support for php 5.6 is a big decission. But until we do we are stuck with version 4.2.5 of his package.
To install laravel 5.5 you need php >= 7.0 anyway.
The fix is simple, but we should drop the suport for 5.6 in travis.
What do you think ?

Dropping support for PHP 5.6 is almost certainly a breaking change and something that @tabacitu at least should review.
On a personal note (taking my hat off here as a maintainer), I do wish customers and others would upgrade their PHP and Laravel but sometimes there are very compelling reasons for them not to do so.

Laravel is always pretty progressive with it's requirements, adopting new technologies as fast as they come out.  If a Laravel package is going to keep up, I'd say you want to bump to PHP7, or this type of thing will keep happening.

Hi guys,
Yup, totally agree on this one. Dropping PHP <7 support is a big decision, but I think the time has come. I myself am in the same boat - I have laravel/backpack apps that would be a pain to upgrade, but I think we shouldn't sacrifice security and maintainability for the sake of lazyness.
The plan is for the next backpack version (base 1.0.0 and crud 3.3.x) to only support Laravel 5.5, which requires PHP 7+. You can already see that happening on the Backpack\Base upgrade brach.
I know not everyone will agree with this decision, but this should:

eliminate conditional behaviour depending on PHP version;
allow us to rewrite a lot of the codebase using the cool new features in PHP 7;
make it sooo much easier to maintain the packages;
help backpack developers use the latest versions of the dependencies; @gotrecillo you mentioned sluggable, but there are plenty others - namely everything from spatie that already require PHP 7+;
still provide a working version for developers who can't upgrade; just no new features;

I'll close the issue as the decision, in my mind, is already taken. But please let me know if you agrees/disagree - I make mistakes all the time and I'm happy to take back decisions if new information surfaces.
Cheers!


Screenshot

Would be nice if you could add an screenshot 🙂

added a screenshot in the same way that I saw in another module

👍 Now your modules look also nice in the new module list: https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/.


Issue Downloading symbols from Cloud Sandbox

Before logging a new issue please make sure to:

Read the FAQ
Search if there is an existing issue for what you want to log. If it's closed you can reopen it and add your comments.
Use the latest Developer Preview release both the server part and the AL Language extension in VS Code (listed on the repository home page)
If you're not using the latest released version (or are using a private build drop that is newer) please provide the version number in the issue

To help us reproduce the issue and find the root please try to:
A) Attach a minimal set of AL code that causes the issue
B) If the error occurs on the server - copy/paste the server stack trace from the Event Viewer

The online sandboxes have been recently updated. Could you please try again to download the symbols?
In case it still does not work, please also consider to reset the sandbox environmet.


Update about some latest stuff

After creator update, some latest feature is missing in this article

@greg-lindsay,
Can you review and let me know if I can merge it?

Yes you can.
On Tue, Aug 14, 2018, 11:03 PM Patti Short<EMAIL_ADDRESS>wrote:

@greg-lindsay https://github.com/greg-lindsay,
Can you review and let me know if I can merge it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/windows-itpro-docs/pull/1466#issuecomment-412953679,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ajvuu3dZV0O9kfZ6kUcU4YjRIw1AurKSks5uQwnsgaJpZM4V811N
.


Update the UI for the variable when it is attached to a deliverable

Update the UI for the variable when it is attached to a deliverable

Update the rest of the variable UI to match Figma

#2876  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nickgraz and the rest of your teammates on  Graphite

Merge activity

Jul 18, 5:37 PM EDT: @nickgraz started a stack merge that includes this pull request via Graphite.


Question - Does notifee support pendingIntent?

I want to create local notification based on "Download" button inside react native app. Sure I can get the uri/path to the file, but is it possible when user tap the notification it will open particular app based on file extension?

This is not a very complete use case description, I'm not sure exactly what you want
https://stackoverflow.com/help/how-to-ask
Sounds like you want to wire up a notifee event handler that responds to the notification interaction and then uses these APIs https://reactnative.dev/docs/0.69/linking#send-intents-android ? (or uses https://github.com/react-native-share/react-native-share)


[Feature]: Hiding category

Describe the feature
The ability to hide item categories is useful for

"I always need this item in my bag but the effect is passive" (dark moon faire book, WoD pickaxe/herbalism gloves) or
"I use this item a lot and won't ever move it out of bags, but I have the effect bound somewhere" (teleport items, goblin gliders)

Describe the implementation
A checkbox in the category options, or a "visibility" sub-menu on the bag button. A context menu on the category won't work for toggling visibility back on. The sub-menu is likely better UX since it allows for rather quick toggling instead of having to crawl through options in a separate window.

This is the only reason I'm still on Adibags, and have been checking this issue regularly for any changes so figured I'd make a comment.
I don't think users in general realize the scope of the advantages this bring so I get it's not a priority.
When I open my bags i only see what I actually need to see, which aren't really that many.
How I hide stuff:
I've got a number of custom [Categories] I often keep hidden.  Right now I've got 29 different items over maybe 35 slots that generally are hidden in my Bag-view.

[1. Hide] ~10 items like Hearthstone, Jeeves, Wrap of X, Gnomish Army Knife etc  - Always hidden unless adding new item etc.
[2. Flask/Lxr/Pot] ~5 different liquid consumables also bandages. - Toggle on visibility when managing stacks.
[3. Misc. C] ~10 items like Flares, Drums, Vanishing Powder. - Toggle as above.
[4. Tabards] ~3 - Toggle only when switching.
And some more like the above. The estimated number is in the Bag-view but in the Bank I often got more.

I also hide the junk and add items as junk as I play. I auto-sell everything there.
Thank you for putting in the work of developing a great addon.

This is definitely being worked on -- the last little bit of UI changes needed to make this happen are finishing up now. It's going to be part of the new category sort menu that was just released. Sit tight.

Categories can be hidden as of v0.1.71. Right click on the category in the Configure Categories slideout menu to hide the category.


Add option for simple text or numbers on markers

That kind of support was added to the extra markers plugin:
https://github.com/coryasilva/Leaflet.ExtraMarkers
But clearly vector markers are the way to go-

It's not that difficult to implement this for yourself. I achieved this by modifying few lines of code somewhere around line 182 . Modify this according to your needs.
div.innerHTML = '<svg width="' + options.iconSize[0] + 'px" height="' + options.iconSize[1] + 'px" viewBox="' + options.viewBox + '" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><path d="' + pin_path + '" fill="' + options.markerColor + '"></path><text x="'+ options.iconTextPosition[0]+'" y="'+ options.iconTextPosition[1] +'" style="font-weight: 600" text-anchor="middle" font-family="\'PT Sans\'" font-size="'+ options.iconTextSize +'" fill="white">'+ options.iconText +'</text></svg>';
and at line 140 you will find var iconOptions. again modify this according to your needs.
var iconOptions = { 	  iconSize: [30, 50], 	  iconAnchor: [15, 50], 	  popupAnchor: [2, -40], 	  shadowAnchor: [39, 45], 	  shadowSize: [54, 51],       iconText: '',       iconTextPosition: [15, 25],       iconTextSize: 12, 	  className: 'vector-marker', 	  prefix: 'fa', 	  spinClass: 'fa-spin', 	  extraIconClasses: '', 	  extraDivClasses: '', 	  icon: 'home', 	  markerColor: 'blue', 	  iconColor: 'white', 	  viewBox: '0 0 32 52' 	};

I failed trying a similar modification; I want to add a  directive to the innerHTML by adding an option svgDefs at line 140 and using options.svgDefs in line 182. I added the svgDefs option on creating the Icon:
					icon: L.VectorMarkers.icon( 						{ 							iconSize: [35,50], 							icon: 'bank' , 							prefix: 'fa', 							markerColor: 'red', 							iconColor:  '#278c11', 							svgDefs: '<defs><radialGradient  + 								' r="70%" fx="50%" fy="30%">' + 								'<stop offset="0%" stop-color="white" />' + 								'<stop offset="100%" stop-color="black'" /></radialGradient></defs>'						 						})
but the options.svgDefs ist not defined. What is missing?

Problem solved! It worked that way, I had only a build problem. I'll fork the project to imnplement the changes.

Good to know it worked for you.


Support immediate writing in WDB

The WDB writedown works by periodically checking if the count of records in tables exceeds a configured rowcount, and writing down if so. If a user wishes to savedown every time the check runs, the obvious solution is to set the rowcount to 0 so that the check is always true and writedown always occurs.
However, this rowcount is also used during log replay https://github.com/DataIntellectTech/TorQ/blob/4a26653710e329a385e754c5872e8f12c3945402/code/processes/wdb.q#L551
which will lead to WDB writing to disk for every message in TP log if rowcount is set to 0. This will lead to a very slow recovery, so we should implement some logic to set the rowcount to zero only after replay

TorQ_679


[Enhancement] Possible to extends PickPhotoAsync to PickPhotoAndVideoAsync?

My situation is I need to pick both of photo and video. I just see only two methods arr PickPhotoAsync and PickVideoAsync not both. Can you implement it, I think it will be cool.

I do not plan on making any new APIs to this library.


Expose API to manage lifecycle of the cluster root CA material

During the lifecycle of a swarm it is desirable to be able to manage the root CA material to perform tasks such as explicit rotation or changing between internal CA and external CA .  The material would ideally be encrypted to prevent leakage of the root key.

We have root CA rotation now, which supports switching between internal and external CAs as well. Closing.


Elevate navigation buttons and change mouseover cursor to pointer for all buttons

What was changed
Improve navigation bar affordance through:
1.) Elevation for navigation buttons
2.) Cursor change on mouseover for all buttons to pointer
3.) Disable Buttons without Route
Before:

After

@sven1103 I addressed the code smell by rewriting the component using our css styles which simplifies it greatly 🥳


refactor: unify error related tasks

The current error handling logic is a mess. We have code that tries to
fetch information about errors in different places throughout the
application, and its incredibly hard to ensure certain types of error
get decent human friendly error messages.
This commit groups, improves, and tests all error related functions in
lib/shared/errors.js.
Here's a summary of the changes, in more detail:

Move the HUMAN_FRIENDLY object to shared/errors.js
Extend HUMAN_FRIENDLY with error descriptions
Add ENOMEM to shared/errors.js
Group CLI and OSDialogService mechanisms for getting an error title
and an error description
Move error serialisation routines from robot to shared/errors.js
Create and use createError() and createUserError() utility
functions
Add user friendly descriptions to many errors
Don't report user errors to TrackJS

Fixes: https://github.com/resin-io/etcher/issues/1098
Change-Type: minor
Changelog-Entry: Make errors more user friendly throughout the application.
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

@jhermsmeier Any updates on this one?

Only a minor niggle, but I wouldn't classify this as Fixes: #1098 as it only improves the error-reporting, it doesn't reduce the memory-usage of Etcher ;)

With all refactoring done here, I wonder what the 'overlap' now is between shared/errors.js and shared/messages.js? Should they be merged, or left separate? Are there any new strings that ought to be added to shared/messages.js?

Only a minor niggle, but I wouldn't classify this as Fixes: #1098 as it only improves the error-reporting, it doesn't reduce the memory-usage of Etcher ;)

Not sure. I feel that the referenced ticket concluded that improving the error messages should be enough for now. Maybe we can create a new one to track reducing memory consumption, and have this PR close the referenced one?

With all refactoring done here, I wonder what the 'overlap' now is between shared/errors.js and shared/messages.js? Should they be merged, or left separate? Are there any new strings that ought to be added to shared/messages.js?

Yeah, that needs to be unified as well, but I'll probably to do in another PR, once this is merged.

I feel that the referenced ticket concluded that improving the error messages should be enough for now.

I've edited the title of #1098 so I'm now happy for this PR to 'fix' that issue :-)

Looks like the new angular-mocks is now breaking the CI tests! :-/
I dunno if that's the fault of angular-mocks though, or if our code is doing something it shouldn't be?

Hm, it looks like its a dependency indeed. The shrinkwrap file doesn't lock development dependencies, so either angular-mocks or electron-mocha is causing this.

Neither module was upgraded. package.json is already declaring the latest versions. On top of that, the issue only seems to happen in GNU/Linux and Windows, and I can't reproduce on OS X.

I eventually got to the bottom of it. See https://github.com/resin-io/etcher/pull/1168


feat: improve ui blank page

Now when no content has been added the page is very empty. Instead showing some instructions or uring the user to add something could improve the UX.

Fixed in 1b817e360ac7c6e7398136e70715f3e6740efa6f


Questions about ProvideBuffers

I'm writing some io_uring examples and I'm currently playing with multishot requests and ProvideBuffers. I have some questions:

Recently io_uring moved from io_uring_prep_provide_buffers to ring mapped buffers, as explained here. I don't see this change reflected in the API of this crate, am I wrong?
When I use ProvidedBuffers, how do I signal that some buffers inside a buffer group are ready to be reused? ATM I mark the whole group as available, but is there maybe a way to have more granularity?

Regarding your second question, AFAIU you can give the buffers back to the ring using ProvideBuffers.  Currently, you always give back all the buffers (since you set number of buffers to 4, and bid to 0). Instead, you can return individual buffers by setting the number of buffers to 1, and bid to the respective buffer index.


Adapt machine readiness probe to node-agent

What this PR does / why we need it:
Adapt machine readiness probe to node-agent.
Gardener node agent does not download kubectl anymore to /opt/bin/kubectl. Therefore, the readiness probe of machines in the local setup should no longer refer to this binary. Fortunately, the node image already comes with kubectl in /usr/bin/kubectl, which works for the readiness probe.
Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
After enabling gardener node agent in the local setup, all machines pods stay non-ready. This does not block creation/deletion of shoot clusters. It is not clear what the effect of it is, but it is safer to just use the correct binary.
Release note:

Machines in the local setup work with gardener node agent and report proper readiness

/lgtm


Add Flippers to Collection

A useful metric would be to see people entered into the collection and for much they actually sold. It would work as a collection hyper-local leaderboard/rank.
Hence in current holders, we can't show people who sold as it would be a bit of noise, adding the next tab Flippers would work.
Add there same table where

headers will be following User, Amount, Bought, Sold, Last Activity
on unfolding you can see each NFT there which you can inspect

To do

Forking Holders in collection
Adjusting table instead of Sale (LIST event) there will be Sold (BUY from that user)
Probably we would need to write Rubick resolver for this so it's fast?

ht @thefvk

Hi, I will have a try.


fix: dont use reserved 'global' for variable name

Hopefully this does not have any strange side-effects, but the tests still pass.
Closes https://github.com/nats-io/node-nats-streaming/issues/104

Coverage remained the same at 93.737% when pulling a49eed7e6ec17bbbdfcfa51d5e1b463977df5360 on egilsster:global_reserved into d7a3cdc758c1c8a7f08f5aa8d8311fd5f189c6dd on nats-io:master.

Just noticed this is a generated file, guess this wont work..

@egilsster unfortunately this is not an acceptable fix because next time the protobufs are updated and the code is regenerated the change will be lost. Second, global is not a reserved word in javascript. If you can find a way that is more resilient to apply this type of fix, let me know, but here we are at the mercy of the protobuf compiler.


tcell test cannot run with TERM=""

➜  tcell git:(5430f4d) TERM= go test
--- FAIL: TestNewTerminalColorMode (0.01s)
--- FAIL: TestNewTerminalColorMode/default_options (0.01s)
tcell_test.go:52: newTerminal => unexpected error:
exit status 1
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x5bf350]
goroutine 157 [running]:
testing.tRunner.func1.1(0x5f3180, 0x83b370)
/usr/lib/google-golang/src/testing/testing.go:941 +0x3d0
testing.tRunner.func1(0xc0001e6ea0)
/usr/lib/google-golang/src/testing/testing.go:944 +0x3f9
panic(0x5f3180, 0x83b370)
/usr/lib/google-golang/src/runtime/panic.go:967 +0x15d
github.com/mum4k/termdash/terminal/tcell.TestNewTerminalColorMode.func1(0xc0001e6ea0)
/usr/local/google/home/yaseenh/go/src/github.com/mum4k/termdash/terminal/tcell/tcell_test.go:56 +0xc0
testing.tRunner(0xc0001e6ea0, 0xc0001d2f30)
/usr/lib/google-golang/src/testing/testing.go:992 +0xdc
created by testing.(*T).Run
/usr/lib/google-golang/src/testing/testing.go:1043 +0x357
exit status 2
FAIL	github.com/mum4k/termdash/terminal/tcell	0.040s

tcell.NewScreen returns nil in this case.

Yep.  If you don't have a term, then we can't create a screen because we have no idea how to render that.
Arguably the tests should probably detect this and just Skip those tests.

Looking at this, it doesn't seem to be an issue.  I can't reproduce it.  I also don't seem to have your specific commit in my history.


[Task] desensitization of main fields in logs #3861

reslove conflict

Codecov Report

Merging #4012 (3ee5167) into master (ef3c72d) will decrease coverage by 0.42%.
The diff coverage is 41.84%.

@@             Coverage Diff              @@
##             master    #4012      +/-   ##
============================================
- Coverage     70.21%   69.78%   -0.43%
+ Complexity     6692     6672      -20
============================================
  Files           923      927       +4
  Lines         25163    25286     +123
  Branches       2269     2280      +11
============================================
- Hits          17667    17647      -20
- Misses         6119     6247     +128
- Partials       1377     1392      +15

Impacted Files
Coverage Δ

...u/plugin/logging/common/AbstractLoggingPlugin.java
0.00% <0.00%> (ø)

...ogging/common/constant/GenericLoggingConstant.java
0.00% <ø> (ø)

...plugin/logging/common/entity/ShenyuRequestLog.java
96.61% <ø> (ø)

.../plugin/logging/console/config/DataMaskConfig.java
0.00% <0.00%> (ø)

...logging/common/body/LoggingServerHttpResponse.java
47.44% <6.81%> (-18.52%)
:arrow_down:

...u/plugin/logging/console/LoggingConsolePlugin.java
43.20% <43.90%> (-1.97%)
:arrow_down:

...logging/common/datamask/DataMaskByCharReplace.java
78.57% <78.57%> (ø)

.../plugin/logging/common/datamask/DataMaskByMD5.java
100.00% <100.00%> (ø)

...u/plugin/logging/common/datamask/KeyWordMatch.java
100.00% <100.00%> (ø)

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
68.75% <0.00%> (-31.25%)
:arrow_down:

... and 44 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Getting (0 , react__WEBPACK_IMPORTED_MODULE_0__.createContext) is not a function  Error when using Radix Scroll Area

Bug report
Current Behavior
Getting this error when adding Scroll Area to next@14 application

Expected behavior
The error shouldn't happen.
Reproducible example
repo example
Suggested solution
This error could be solved by adding 'use client' directive, however this was never mention in Scroll Area Docs, the docs code snippet doesn't help either when the component of the code snippet doesn't have any interactives hooks, which mildly suggest user doesn't need 'use client' when using the radix components.
Solutions:

Update the documents to tell users need to add 'use client' when using radix components,
Or Fix the component itself so no need to add 'use client'.

Additional context
This possibly happenning with many radix components as well, including dropdownmenu that mentioned in this issue
Your environment

Software
Name(s)
Version

Radix Package(s)
scroll-area
^1.0.5

React
n/a
^18

Browser
all common browser
n/a

Assistive tech
n/a
n/a

Node
n/a
20.11.0

npm/yarn
pnpm
9.0.6

Operating System
windows
11

All components that need 'use client' now have that built-in in the latest RC versions


🛑🛑🛑Please contact customer support🛑🛑🛑

This GitHub repository is dedicated to handling issues and feedback for the latest Developer Preview releases of the AL development tools for Dynamics 365 Business Central.
We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
You can open Support Request to CSS through PartnerSource portal or contact your Service Account Manager (SAM) in the local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also step by step direct you how to open a support request or how to get credentials if this is the first time for you / your company.

Hi, it seems EncryptionManagement.Decrypt was broken overnight.  We have customers on BC 22.4 and 22.5 having the same issue.  However, our BC23 test codeunits all ran fine with this function and our docker instance does not have the same behavior.  None of our customers can open their employee cards since this Decrypt function is used to show some of the private employee information to the user.  Please update us as soon as possible as to when there will be a fix out.


Is it possible for me to extend the model by adding an image using Active Storage 6.0.0?

Is it possible for me to extend the model by adding an image using Active Storage 6.0.0?
For activestorage 5.2.3, I did like this:
ActsAsTaggableOn::Tag.class_eval do
    extend ActiveStorage::Attached::Macros
    has_one_attached :image
end

yes.

yes.

Does not work!
https://github.com/rails/rails/issues/37126

So it happened:
ActsAsTaggableOn::Tag.class_eval do
    include ActiveStorage::Reflection::ActiveRecordExtensions
    ActiveRecord::Reflection.singleton_class.prepend(ActiveStorage::Reflection::ReflectionExtension)
    include ActiveStorage::Attached::Model
    has_one_attached :image
end


Test Stories endpoints with camelCase keys

Pull Request Test Coverage Report for Build 3036

4 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 95.194%

Totals

Change from base Build 3033:
0.008%

Covered Lines:
1129

Relevant Lines:
1186

💛  - Coveralls


Removing vertical line from neovim

Hi, I noticed a vertical line seems to be present whenever I open Neovim regardless of the file type. Is there a good way to remove this line?

This vertical line is not from vim-jukit. this is cause of your config.
In you config set the value of vim.opt.colorcolumn = {}, to remove that line


[Design] Kiota TypeScript generation for REST-based clients

I believe this is a duplicate of #1925, closing


Support objc_import

https://bazel.build/reference/be/objective-c#objc_import

I'm pretty sure we already support this, and just need an example in the fixtures. Would you like to do that @maxwellE?

Isn't this covered by this example already? https://github.com/buildbuddy-io/rules_xcodeproj/blob/e1c0f4f3aa32c5679a888714a2b40f512beed3a2/examples/integration/CommandLine/external/BUILD.tpl#L19-L24

This one is, thanks!


Snap Sidebar To Width

Description

Added CodeEditSplitViewController which handles all snap logic.
NavigatorSidebarToolbarTop wrapped in GeometryReader. Now, HStack can react to width changes and choose appropriate space between items.
Add unit tests for CodeEditSplitViewController.

Related Issue

#856

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] I documented my code
[x] Review requested

Screenshots

Great work @yapryntsev! Would you mind posing a short screen video of resizing the sidebar? Also, could you fix the proportions if the symbols in the sidebar dock?

@austincondiff, I'll update PR later tonight

https://user-images.githubusercontent.com/18378212/210349529-5d791407-17fd-4226-a07c-af1845d24c29.MOV

@allcontributors add @yapryntsev for code

@yapryntsev It seems your tests are very inconsistent as they regularly but randomly fail.
Please test this out yourself by running the tests repeatedly for 100 times and create a follow-up PR referencing this one.
These are the tests in question:

When running it for 100 times, it will fail about 5-10 times.


Fix some FAB behavior

FAB shows when scrolling up and when a card collapses if the user can still scroll down.

:+1:


Llama-Index examples in Jupyter notebook format

Jupyter notebooks added

LlamaIndex_Local-Models.ipynb
LlamaIndex_Local-Models_L4T.ipynb

Documented in docs.md accordingly.

Thanks @tokk-nv - merged these doc updates live into master, and rebuilt/pushed the llama-index container images for JP5/JP6 👍


[Searchable Snapshot] Understand and document the current file system and directory structure for snapshots

Remote Storage will function as a primary or secondary data store in the future based on the cluster configuration
We need documentation on the current file system and directory structure of how snapshots are currently structured
This will enable us to work backwards in designing and optimizing the Store structure for Remote Storage

@kotwanikunal : Is there any documentation you compiled as part of this issue ? Will be super useful for users and will assist in understanding design of remote searchable snapshots.

@kotwanikunal : Is there any documentation you compiled as part of this issue ? Will be super useful for users and will assist in understanding design of remote searchable snapshots.

This is what I expected when I read the title. was expecting a document:)

@kotwanikunal : Is there any documentation you compiled as part of this issue ? Will be super useful for users and will assist in understanding design of remote searchable snapshots.

This is what I expected when I read the title. was expecting a document:)

@dreamer-89 This issue was related to the current mechanisms of OpenSearch snapshots. I do have compiled notes and previous documents which do cover the underlying files and actual snapshot process within OpenSearch.
@AmiStrn I'll try to find the right location to publish it and put this out soon.

@AmiStrn @dreamer-89 The post is out here.


Support Python E2E test remote call from main build

Issue #, if available:
Description of changes:
Support Python E2E test remote call from main build in aws-otel-python-instrumentation
Test workflow:
main build: https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/8804702307
python EC2 canary: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8805912573
python EKS canary: https://github.com/aws-observability/aws-application-signals-test-framework/actions/runs/8806000543
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Could we also test if the python-canary workflow runs properly with this change?

Could we also test if the python-canary workflow runs properly with this change?

Sure, tested and updated in the PR overview.


Bugs when running t2b in root with -u option

Config files does not belong to the user so he cannot modify them.

Fix in commit 4509f4406b35022064190c5e1aa8751f163bde95


[go_router] in redirection, How to cancel routing

in redirection, How to cancel routing?
If user is not premium user, Try to not allow to move to target routing.
For example, like below.
redirect: (BuildContext context, GoRouterState state) {
  if (AuthState.of(context).isNotPremiumUser) {
   // cancel routing
  } else {
    return null;
  }
},

In other framework Angular, it has router guard
"return true" means like "return null" in Go_router,
"return false" means cancel routing and leave so do not move.
How to do "return false" with go_router?

@byungjuJin
I think this open proposal will cover your use case as well, so I suggest you to follow-up in that issue for further updates.
Meantime, for a workaround, you may ask this question on support channels like StackOverflow.
Closing this issue from here. If you disagree, write in comments and I'll reopen it.


test: error on hint for unacknowledged update/delete on server < 3.4

Description
NODE-2430 - update
NODE-2535 - delete
What changed?
Added new spec tests from SPEC-1651.
Are there any files to ignore?

Closed in favor of #2301


developer alert overflows into doc sidebar

Have a screen

How do I access this page?

you can see this at /docs/human-interface-guidelines on a development branch.


Dynamic URL feature

Closes #63
Description
This PR are for dynamic URL feature proposal.
Dynamic URL are feature to give custom parameter in our short URL to access specified website URL with dynamic URL query / path.
Currently multiple param and nested path (param contains slash "/") are not supported.
How its look compared to regular link:

Regular
Dynamic

Short URL
ksana.in/slug
ksana.in/slug/param

Destination
domain.com
domain.com/param

What inside this PR

[x] Add new field to database
[x] Add option to form with validator
[x] Update README

How to use:
https://user-images.githubusercontent.com/14371119/158523043-ad87f954-c0da-4dfe-a357-f74ed7e369fe.mp4
Demo:
https://user-images.githubusercontent.com/14371119/158523078-001237f8-16d3-47ff-a42b-e7851e35729f.mp4


Fixed release/5.4's update-checkout swift-format.

It was main but should be swift-5.4-branch.

@swift-ci please smoke test


AddJwtBearer not configured properly when using custom DI causing socket IO errors

On request of @Tratcher copied from https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/1078
For .net core 2.1.x and 2.2.x
When using the AddJwtBearer extension with custom DI such as Unity, the "options" lambda is called on every request instead of just startup.. According to @Tratcher this is not the expected behaviour. Eventually, in my web app, this causes two subsequent issues:

Socket exhaustion on HTTP Client when using the default settings for ConfigurationManager causing web site instability and performance issues
Continued invoking of the .well-known/openid-configuration endpoint incurring additional load on the host of that service

When using the inbuilt DI this problem does not occur.
The Unity team investigated this error and discovered a difference in behaviour between the resolution tree between Unity and the default DI - as identified  https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/issues/1078#issuecomment-457292191.
They then ran the same test app with the latest compiled branch from https://github.com/aspnet/Extensions and found the error did not occur therefore they believe the issue is in the .net code itself and closed their issue. Unity team investigations are found at https://github.com/unitycontainer/microsoft-dependency-injection/issues/34
Therefore it appears that there is a difference in the way the AddJwtBearer logic handles dependencies in the 2.1 and 2.2 versions that is not in the 3.0 versions.
To Reproduce
A test app is available at https://github.com/grahambunce/unityinjectionjwtbearer configured to use Unity but it can be changed to use default DI via minor commenting out of one line.
Expected behavior
In the 2.1 (LTS) and 2.2 versions the AddJwtBearer lambda should only be called on startup instead of on each api request

@muratg Any update on this? It looks a bit like it's being passed around with nobody really taking it up?

@HaoK was there any change in how JwtBearerOptions is initiated that may have caused this? (See @pakrym's suspicion above.)

We periodically close 'discussion' issues that have not been updated in a long period of time.
We apologize if this causes any inconvenience. We ask that if you are still encountering an issue, please log a new issue with updated information and we will investigate.


Support latest clang-tidy 18 version

Upgrade clang-tidy to 18.1.8.

I've noticed that the current version doesn't handle the check readability-convert-member-functions-to-static well; therefore, it might be useful to bump its version.

Duplicate of #134


Improve device add UX, login state logging, timeouts

This patch should help clear up confusion when people run device add on a yet-to-be-provisioned device.  It displays some text before doing anything explaining that device add should only be run on existing devices.
Starting `device add`...

(Please note that you should run `device add` on a computer that is
already registered with Keybase)

Then there is a new special error for LoginState timeouts, and when that happens the user will see:
Sorry, but it looks like there is another login or device provisioning
task currently running.

We only run one at a time to ensure the device is provisioned correctly.

 You need to run it on an
existing computer that is already reqistered with Keybase.)

In addition to this, I improved the LoginState request logging so that the logs should be easier to parse when these issues come up.

cc @malgorithms if you want any changes to the text

ran tests locally, they passed.  CI is down for the count...


ThrottlingException

We have a lot of external secrets and suffer from this problem:
{"level":50,"time":1601036577581,"pid":18,"hostname":"kube-external-secrets-kubernetes-external-secrets-6c6585b94xc58","message":"Rate exceeded","code":"ThrottlingException","time":"2020-09-25T12:22:57.581Z","requestId":"65f25e35-0f4c-47db-a0b8-93a322551064","statusCode":400,"retryable":true,"stack":"ThrottlingException: Rate exceeded\n    at Request.extractError (/app/node_modules/aws-sdk/lib/protocol/json.js:51:27)\n    at Request.callListeners (/app/node_modules/aws-sdk/lib/sequential_executor.js:106:20)\n    at Request.emit (/app/node_modules/aws-sdk/lib/sequential_executor.js:78:10)\n    at Request.emit (/app/node_modules/aws-sdk/lib/request.js:683:14)\n    at Request.transition (/app/node_modules/aws-sdk/lib/request.js:22:10)\n    at AcceptorStateMachine.runTo (/app/node_modules/aws-sdk/lib/state_machine.js:14:12)\n    at /app/node_modules/aws-sdk/lib/state_machine.js:26:10\n    at Request.<anonymous> (/app/node_modules/aws-sdk/lib/request.js:38:9)\n    at Request.<anonymous> (/app/node_modules/aws-sdk/lib/request.js:685:12)\n    at Request.callListeners (/app/node_modules/aws-sdk/lib/sequential_executor.js:116:18)","type":"Error","msg":"failure while polling the secret wp-example/wp-example-wordpress"}

Is it possible to use some configurable update interval which just updates each secret every x minutes?

You can increase the intervall, but if all secrets update at the same time that won't really help

I have changed the interval from 10s to 60s. This does not help.
We have about 30 external secrets containing 6 parameters.
It looks like every 60s external secret tries to fetch 180 parameters.
I think we would need some feature like this:

fetch new secrets once they appear or they are updated every x seconds
update existing secrets after x seconds
limit fetch at max x secrets per run

Parameters could look like:

POLLER_NEW_INTERVAL_MILLISECONDS
POLLER_UPDATE_INTERVAL_MILLISECONDS
POLLER_MAX_PER_RUN