wingtips-zipkin: NumberFormatException in WingtipsToZipkinSpanConverterDefaultImpl

I have been trying out Wingtips with Zipkin today. I love the docs and overall simplicity of use. I created simple client-server app. Client is written using Cujojs-rest Zipkin instrumentation and Server is created in Spark web framework. When I make request from client to server, and Wingtips tries to convert strings extracted from headers to long it always ends in NumberFormatException in WingtipsToZipkinSpanConverterDefaultImpl in nullSafeLong() method. The solution I found working was to add this:
protected Long nullSafeLong(String str) {
        if (str == null)
            return null;

        long longString = new BigInteger((str), 16).longValue();
        return longString;
    }

Thanks for the report @jpiechowka ! Can you copy/paste an example of one of the values being sent by the Cujojs-rest Zipkin instrumentation that is failing with the NumberFormatException in Wingtips? I'm pretty sure I know what it will look like, but I'd rather be 100% sure than assume.
We definitely want to support receiving propagation headers from Zipkin, so we'll have to come up with a solution that supports both Wingtips and Zipkin headers.

And just to make sure I'm clear on the desired outcome here: (1) Cujojs-rest (Zipkin) -> (2) Spark (Wingtips) -> (3) Zipkin server for collecting, and the failure is happening when (2) is trying to send spans to (3)? Is that correct?

This is my application with my fix applied in nullSafeLong(): wingtips-cujojs-spark-example.

Can you just copy/paste the full NumberFormatException message? i.e. java.lang.NumberFormatException: For input string: "[unparseable value]". I need to see an example of one of the [unparseable value] that you're seeing.

@nicmunroe Sure! Here it is:
java.lang.NumberFormatException: For input string: "ac65beda7e31487a"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Long.parseLong(Long.java:589)
	at java.lang.Long.parseLong(Long.java:631)
	at com.nike.wingtips.zipkin.util.WingtipsToZipkinSpanConverterDefaultImpl.nullSafeLong(WingtipsToZipkinSpanConverterDefaultImpl.java:72)
	at com.nike.wingtips.zipkin.util.WingtipsToZipkinSpanConverterDefaultImpl.convertWingtipsSpanToZipkinSpan(WingtipsToZipkinSpanConverterDefaultImpl.java:30)
	at com.nike.wingtips.zipkin.WingtipsToZipkinLifecycleListener.spanCompleted(WingtipsToZipkinLifecycleListener.java:97)
	at com.nike.wingtips.Tracer.notifySpanCompleted(Tracer.java:664)
	at com.nike.wingtips.Tracer.completeAndLogSpan(Tracer.java:547)
	at com.nike.wingtips.Tracer.completeRequestSpan(Tracer.java:470)
	at SparkServer.lambda$main$1(SparkServer.java:44)
	at spark.RouteImpl$1.handle(RouteImpl.java:58)
	at spark.webserver.MatcherFilter.doFilter(MatcherFilter.java:162)
	at spark.webserver.JettyHandler.doHandle(JettyHandler.java:61)
	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:189)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:119)
	at org.eclipse.jetty.server.Server.handle(Server.java:517)
	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:302)
	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:242)
	at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:245)
	at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:95)
	at org.eclipse.jetty.io.SelectChannelEndPoint$2.run(SelectChannelEndPoint.java:75)
	at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.produceAndRun(ExecuteProduceConsume.java:213)
	at org.eclipse.jetty.util.thread.strategy.ExecuteProduceConsume.run(ExecuteProduceConsume.java:147)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:654)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:572)
	at java.lang.Thread.run(Thread.java:745)

If you need anything more please feel free to ask. But I need to go to sleep. I will be available in couple of hours.

@nicmunroe so I've been thinking about making a b3-java or b3-propagation-java project as this is a fairly common type of bug/misunderstanding. Ex. sometimes people are trying to read the hex ids as integers etc.

@jpiechowka Thanks, that's exactly what I was looking for. We'll get on this ASAP - should hopefully be a quick fix.
@adriancole Yeah that's what's happening here. Is @jpiechowka 's suggestion of new BigInteger(zipkinHexString, 16).longValue() the correct way to solve this in Java 7? I tried simply doing a Long.parseLong("ac65beda7e31487a", 16) with the example given and it failed. Java 8's Long.parseUnsignedLong("ac65beda7e31487a", 16) works, and gives the same answer as the BigInteger solution. So without looking at how zipkin is generating the hex strings it seems safe to assume they are unsigned longs and the BigInteger solution should work. But since you're here I figure it's better to double check - will the BigInteger solution create the long so it gets reported to the zipkin server correctly, or is there other massaging that needs to happen?
Context for why this bug exists - Wingtips just passes around decimal longs as strings rather than hex-encoded even when serializing to JSON, so I never considered this case. And Zipkin -> Wingtips -> * HTTP header propagation would work fine since Wingtips stores the IDs as strings internally rather than longs so it would pass through without issue. This particular case of Zipkin -> Wingtips -> Zipkin reporter fails though because the wingtips reporter assumes decimal encoded longs.

Zipkin has a hipster hex to unsigned long parser which profiles well. Main
thing different than some is it tolerates less than 16 characters.
https://github.com/openzipkin/zipkin/blob/master/zipkin/src/main/java/zipkin/internal/Util.java
On 18 Aug 2016 12:22, "Nic Munroe"<EMAIL_ADDRESS>wrote:

@jpiechowka https://github.com/jpiechowka Thanks, that's exactly what I
was looking for. We'll get on this ASAP - should hopefully be a quick fix.
@adriancole https://github.com/adriancole Yeah that's what's happening
here. Is @jpiechowka https://github.com/jpiechowka 's suggestion of new
BigInteger(zipkinHexString, 16).longValue() the correct way to solve this
in Java 7? I tried simply doing a Long.parseLong("ac65beda7e31487a", 16)
with the example given and it failed. Java 8's Long.parseUnsignedLong("ac65beda7e31487a",
16) works, and gives the same answer as the BigInteger solution. So
without looking at how zipkin is generating the hex strings it seems safe
to assume they are unsigned longs and the BigInteger solution should
work. But since you're here I figure it's better to double check - will the
BigInteger solution create the long so it gets reported to the zipkin
server correctly, or is there other massaging that needs to happen?
Context for why this bug exists - Wingtips just passes around decimal
longs as strings rather than hex-encoded even when serializing to JSON, so
I never considered this case. And Zipkin -> Wingtips -> * HTTP header
propagation would work fine since Wingtips stores the IDs as strings
internally rather than longs so it would pass through without issue. This
particular case of Zipkin -> Wingtips -> Zipkin reporter fails though
because the wingtips reporter assumes decimal encoded longs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Nike-Inc/wingtips/issues/14#issuecomment-240620441,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD612GtnlW2Ex5Ev8XkmFA4qgMRp2Cnks5qg94VgaJpZM4Jm98J
.

@adriancole perfect! Thanks for the pointer. I only see one problem at this point - my naive initial approach to solving this problem was going to be to attempt decimal long parsing first, and if that failed with a NumberFormatException fall back to hex long parsing. But a service could serve both zipkin and wingtips clients at the same time, and there are hex encoded longs that have only digits in them, so a zipkin span could be incorrectly parsed as a decimal long without error.
I ran a quick test with 100 million randomly generated longs, and about 1 in every 2000 falls into this category where the hex string could be successfully parsed as a decimal encoded string.
So at this point I'm thinking maybe you just have to tell the Wingtips-to-Zipkin-span-converter whether you expect hex or decimal encoded IDs, and supporting both at the same time won't be a supported use case? Or is a 0.05% incorrect ID rate an ok tradeoff? WDYT?

Just to clarify, are you saying in wingtips that only the reporting does ids as numbers, or also header propagation? If the latter, it certainly won't be compatible with B3, which means the problem is bigger than span reporting.
The impact of not using hex ids is pretty big.. this means that B3 traces that start before wingtips won't propagate compatibly into wingtips. Similarly, outbound, if a wingtips user calls a ruby app or c# B3 instrumented app, they won't join properly.
My suggestion would be to phase in a change to wingtips to encode in B3 (lowerhex fixed width) by default. For example, start traces that way, and assume fixed-width 16 char ids are hex.
I ack that this cleanup is dirty in the brown field. One way is to propagate a special header that knows about this change and eventually remove it once internal wingtips deployments are converged. While a punch, a punch like this is certainly better earlier than later because when B3 works the same was here as outside, users can get access to the whole ecosystem compatibly.
There's probably other approaches, too. these are just my thoughts.

Unfortunately it is the latter, but good news is cleanup shouldn't be too bad. Since wingtips uses strings for the internal model, zk -> wt -> * propagation should work fine - wingtips just passes IDs through as strings without any change. The only problem comes in when wingtips does the ID creation since wingtips-created decimal IDs won't be joined properly by a hex ID B3 tracing system.
The way we collect and aggregate spans internally shouldn't be affected by changing to hex IDs so I don't think we need a phased migration strategy. I think it's just band-aid ripping time.

Ok, I've created a new issue for switching to hex IDs for proper B3 compatibility: #15 .
@jpiechowka the issue you raised here should be solved as part of the work for #15 .

:clap:
On Fri, Aug 19, 2016 at 11:41 PM, Nic Munroe<EMAIL_ADDRESS>wrote:

Ok, I've created a new issue for switching to hex IDs for proper B3
compatibility: #15 https://github.com/Nike-Inc/wingtips/issues/15 .
@jpiechowka https://github.com/jpiechowka the issue you raised here
should be solved as part of the work for #15
https://github.com/Nike-Inc/wingtips/issues/15 .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Nike-Inc/wingtips/issues/14#issuecomment-241053886,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAD61zrCIxjIlZRBCQJXsKYmnM8weTRfks5qhc7DgaJpZM4Jm98J
.

@nicmunroe Great work! :+1:


Add #region to specify Linker Work-Around

Problem
The Xamarin.CommunityToolkit contains a few work-arounds to prevent the Linker from accidentally removing platform-specific code. One example can be found here: https://github.com/xamarin/XamarinCommunityToolkit/pull/674/files/492d4f0908e84b9141deeb05dc19e3e5878ea105#r576375815
Typically, this code looks like it can be removed because it is "not used", but it is indeed required to tell the linker to keep the code in the compiled binary.
The concern is that future devs may remove this "unused code", accidentally causing a breaking change.
Solution
As discussed here, let's wrap this linker-specific code in a #region and a comment that alerts future devs to its purpose, like so:
#region Required work-around to prevent linker from removing the platform-specific implementation

#if __ANDROID__
			if (System.DateTime.Now.Ticks < 0)
				_ = new Xamarin.CommunityToolkit.Android.Effects.LifeCycleEffectRouter();
#elif __IOS__
			if (System.DateTime.Now.Ticks < 0)
				_ = new Xamarin.CommunityToolkit.iOS.Effects.LifeCycleEffectRouter();
#elif UWP
			if (System.DateTime.Now.Ticks < 0)
				_ = new Xamarin.CommunityToolkit.UWP.Effects.LifeCycleEffectRouter();
#endif

#endregion

Bugs Fixed

Fixes #910

API Changes
None
Behavioral Changes
None

There is a warning SA1123	Region should not be located within a code element. when using regions like that.
Should it be suppressed around those regions or should its severity be reduced?

There is a warning SA1123 Region should not be located within a code element. when using regions like that.
Should it be suppressed around those regions or should its severity be reduced?

In order to try and minimize our warnings this seems like a good idea. @brminnick thoughts?


Add support for other clock sources in timer driver

Currently, we are using only apb_clock in General-purpose timers implementation. The https://github.com/esp-rs/esp-hal/pull/77 added other options for the clock source.

After discussion with @bjoernQ it seems it's not that straightforward.
In ESP-IDF the user can set the clock source but also manually choose the divider etc - it's a much lower level API.
Do we want to have an additional low-level constructor that takes the clock source and divider? Then the user will want to use ticks for e.g start function - probably going to be a lot of effort.
Also would be a general design decision since if we offer a low-level version here why don't we have it everywhere?
For now, let's turn this issue into a discussion of how we want to deal with this in the future.
What is your opinion @bjoernQ, @jessebraham, @MabezDev?

ABP has served us well and I'm not aware of any current issues with TIMG being driven from it, therefore I'm going to close this for now.


Fixes

See the commit comments for details.

Thanks for the fixes! I've made changes to handlebars.go so I can't merge this automatically. I will include this in another commit.


[DEVREG-59] Retire sprint board for DEVREG

Which area/kind this issue is related to?

/kind task
Issue Description

With project tracking done on Devfile Project and DEVREG issues now being referenced on the project, there is no need to upkeep the sprint board on DEVREG.
DEVREG-58 (devfile/api#1486) will now allow us to upkeep the referencing of issues we need to track on our GitHub board while not exposing any sensitive information.
Full issue: https://issues.redhat.com/browse/DEVREG-59

Decided to leave DEVREG sprint board in place, see comment under full issue for details: https://issues.redhat.com/browse/DEVREG-59

Leaving closed as not planned.


Could you please provide license file for this repo/project ...

I found your tutorial very helpful. I intend to customize a few things for my purposes. Would you mind providing license file for this repo/project? Thank you,

fixed by https://github.com/nosequeldeebee/blockchain-tutorial/commit/26e06bc06785253025ad1b31f80788bd13765e92


Navigation Color Editor Settings Do not Work

Godot version:
3.1 beta4
OS/device including version:
Windows 7 Pro 64bit, GTX 1060 6GB, AMD Ryzen 5 1400
Issue description:
The editor's Navigation Edge/Solid/Disabled settings appear to have no or very little effect, rendering them nearly white. This makes it difficult to see in bright scenes.

Seems partially fixed in beta5. Now the navigation gets colored, but it seems to use the disabled color regardless of whether the NavigationMeshInstance is enabled, and the colors only update when a project is closed and reloaded.

The colors not updating until the project is reloaded is expected, that's how gizmos work.
Relevant code for anyone trying to fix this is in the NavigationMeshSpatialGizmoPlugin: https://github.com/godotengine/godot/blob/0fa3b808509dc0a86ab986320e601c12b988c205/editor/spatial_editor_gizmos.cpp#L3586
The "navigation_material" strings are probably a copy-paste mistake and should be unique every time, then the posterior calls to get_material() need to be updated to use the correct material name.


Dynamically create a firewall rule for test.

fixes #94

one minor suggestion, otherwise LGTM

Thanks! I will merge once the test passes.

Oops it hangs with:
gcloud compute firewall-rules delete ${FIREWALL_NAME} || /bin/true
The following firewalls will be deleted:
 - [travis-test]
Do you want to continue (Y/n)?

I should add CLOUDSDK_CORE_DISABLE_PROMPTS=1 envvar. I will update the PR.

good call

The test failed. Very weird.
Created [https://www.googleapis.com/compute/v1/projects/getting-started-php/global/firewalls/travis-test].
NAME        NETWORK SRC_RANGES        RULES     SRC_TAGS TARGET_TAGS
travis-test default <IP_ADDRESS>/32 tcp:27017          mongodb

There was 1 error:
1) Google\Cloud\Samples\Bookshelf\DataModel\MongoDbTest::testDataModel
MongoDB\Driver\Exception\RuntimeException: No suitable servers found (`serverselectiontryonce` set): [Failed connecting to '<IP_ADDRESS>:27017': Connection timed out]

$ testing/test_cleanup.sh
ERROR: (gcloud.compute.firewall-rules.delete) Some requests did not succeed:
 - The resource 'projects/getting-started-php/global/firewalls/travis-test' was not found

It is confusing, possible interpretation is that the creation somehow failed, but gcloud reported success.

I found this
gcloud compute firewall-rules delete ${FIREWALL_NAME} || /bin/true
Deleted [https://www.googleapis.com/compute/v1/projects/getting-started-php/global/firewalls/travis-test].

Just before the creation call above. Another interpretation is that those 2 calls were conflicting each other, or executed in the reverse order. I added a sleep call after the deletion.

Just a record, failure log is available at:
https://travis-ci.org/GoogleCloudPlatform/getting-started-php/jobs/109977272

I came up with more possible hypothesis. It is possible that there were some stale build which execute the deletion code. I think this is true because even when there is no travis build running (at least travis UI said so), I saw a firewall travis-test existed on the developers console.
I will add timestamp to the firewall name.

The hypothesis in https://github.com/GoogleCloudPlatform/getting-started-php/pull/95#issuecomment-185447635 seems correct. The firewall travis-test magically disappeared now.

hmm, very interesting. We have them only allowing one build at a time, so I wonder how this could have happened. In any case, nice work.

Alright, merging


RegEx Filters

Are there plans to implement RegEx filters via the web interface?
I run two dockers (1 for the bot, 1 for the web interface) and try to keep the configuration to a minimal with only environment variables set. The documentation provides how to enter them with configuration settings but having the ability to enter them through the web interface would be great.
Thank you for all the work done.

Unfortunately not in the foreseeable future - the priority atm is placed on features that benefit all users on the public bot. Regex is not available without manual intervention for safety concerns, and overcoming this with convenience and security in mind requires significant effort on both the bot and the web to make it available for the public


Suppress clang-analyzer-cplusplus.NewDeleteLeaks

Description

GitHub Issues

Help with #267

thanks for this patch!


404 error after login

Environment

Spring boot starter:

active directory spring boot starter

OS Type: MacOS
Java version:

1.8

Summary
Created an app in Azure with all the configuration mentioned in the doc (https://docs.microsoft.com/en-us/java/azure/spring-framework/configure-spring-boot-starter-java-app-with-azure-active-directory?view=azure-java-stable). I was successfully getting the login page and got authenticated. But i am getting 404 error page after logging in.
Reproduce steps
Run the app with the configurations set. The app redirects to Whitelabel Error Page
azure-spring-boot-starter (v2.1.2)
Expected Results
Message "Hello world" should print after logging in.
Actual Results

Thanks for issue this, could you please have a try from newest version 2.1.6 with spring boot 2.1.x ?


fix(video): ensure minimumFileSizeForCompress is still used even if 0

Previously if a value of 0 was passed for minimumFileSizeForCompress, the parameter would be ignored, as it would evaluate falsy and appear as nonexistent.  This adds an explicit check for undefined, and adds a test to ensure it gets properly passed along.

@GrandPoohBear can you add only test case and remove other things from this PR so i can merge it?

Hi @nomi9995 - the other pieces are necessary for yarn test to actually run!  I'll add some comments to the PR explaining more.


highlighting selected and key navigation

Merging with a small fix. There seems to be an issue with clicking at the top or bottom edge not selecting the issue, but let's deal with that later.


test: TimezoneSelector on daylight saving time

SUMMARY
Another take on #19148, fixing the tests with jest.isolateModules instead of making the component to get current time every time it is mounted.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION

[x] Has associated issue: #19148
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Managed to fix the tests with jest.isolateModules instead. I think this is good to go.
cc @suddjian

A Cypress test is consistently failing. I don't think it is related to my changes because this PR only changes a unit test file. Will investigate nonetheless

@rusackas Let's see if the new commit mitigate it. If not, I'll just skip it.


Refactor MemoryPool passing for ExchangeClient

Summary: Setter methods make it difficult to reason about the state of the object. Setters are removed and MemoryPool is fed in through creation methods.
Differential Revision: D39058083

Yeah those will be taken care of before merging


Bug: ccxt is not optional as per the documentation.

This is not exactly a bug but still causes an error and inconsistent with the documentation. The documentation mentions that ccxt is an optional dependency in the Installation section. However, if ccxt is not installed, an error is produced when importing SimulatedExchange.
Running:
from tensortrade.exchanges.simulated import SimulatedExchange

Gives:

...
ModuleNotFoundError: No module named 'ccxt'

I'm still getting this error wih tensortrade 0.2.0b2.
ModuleNotFoundError                       Traceback (most recent call last)
 in
1 import ccxt
----> 2 from tensortrade.exchanges.simulated import SimulatedExchange
3
4 df = pd.read_csv('data/Coinbase_BTCUSD_1h.csv', skiprows=1)
5 exchange = SimulatedExchange(data_frame=df, base_instrument='USD', pretransform=True)
ModuleNotFoundError: No module named 'tensortrade.exchanges.simulated'

Getting the same error too.


Kms provider doc

issue# 7399, Create KMS-provider.md and update encrypt-data.md

This change is

How do we make "Using a KMS provider for data encryption" (and "Developing a KMS Provider gRPC Plugin") as separate children under "Encrypting Secret Data at Rest"?
Such a grouping would keep all KMS/Encryption related content together.

@kksriram could you please target this PR against the release-1.10 branch rather than master? We collect together all the content for the 1.10 release into that branch to lock into the main docs at release time, where anything against master goes against the “current live” documentation.
I’ve also applied the 1.10 milestone to this to track the PR for release time...

/assign

@kksriram it looks like you did manage to retarget the base, but then it was switched back to master? Could you double check and set this again to the release-1.10 branch and we'll get it merged

/approve
/hold
hold is pending retargeting to the release-1.10 branch

@heckj I will rebase the source branch and target to 1.10 today.

@heckj I Rebased source branch to release-1.10 and targeted the pull to release-1.10

/hold cancel

@tengqm I think it's pretty much ready to go, please take a look and add an '/lgtm' comment if you're good with the updates.
/assign @tengqm

/lgtm
Agree to kick this in and leave the plugin development doc separation to future work.

Fixes #7399


Clean up of the instruction to install

Hi,
I got several issues after applying the 2021.8 update.
And the Ferroamp integration doesn't work anymore.
And when I cleaned out the custom_component and follows your guide it doesn't match

I cant start listening and are getting info in the MQTT broker , But no entities are displayed in HA

Now it found everything.. Quite slow.. Not sure if its my environment or something else.

Depending on what hardware you have discovery can take up to a minute. Other than that it shouldn't be slow I would say.

If there are things in the documentation that is incorrect we welcome a PR with updates. 😊

Closing this for now since you got it running.


HA blueprint not listening to frigate/events/summary

Hi,
It seems the ha blueprint isn't subscribing to the frigate/events/summary topic, and therefore not getting the updated notifications.

Hi! Did you follow this part in the doc to (re-)import the blueprint? https://github.com/mhaowork/amblegpt#frigate-notifications-via-home-assistant-blueprint
If so, can you share your HomeAssistant logs like this?

Yes, I followed the guide and copied the file. But I can't find anything in it related to frigate/events/summary topic. not even the one you link to.

 Now, the default main branch should have my changes aka https://github.com/mhaowork/HA_blueprints/blob/main/Frigate Camera Notifications/Stable.yaml

that did the trick.


:zap: Feat: Optimize executeCall

Description
Concise description of proposed changes
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

#1497  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Add support for word durations.

Just a note on conventions: durations are used for a sequence of integers
describing the duration of some underlying unit (e.g. phoneme, grapheme)
whereas alignment is used to describe a matrix (often a binary matrix) with
the time scales on each axis.
I think in this case, durations is probably right.
On Tue, Sep 5, 2023, 20:31 zachoverflow @.***> wrote:

@.**** approved this pull request.
In src/lmnt/api.py
https://github.com/lmnt-com/lmnt-python/pull/1#discussion_r1316667648:

@@ -95,12 +123,79 @@ async def synthesize(self, text, voice, **kwargs):
form_data = aiohttp.FormData()
form_data.add_field('text', text)
form_data.add_field('voice', voice)

form_data.add_field('seed', kwargs.pop('seed', 0))
form_data.add_field('format', kwargs.pop('format', 'wav'))
form_data.add_field('speed', kwargs.pop('speed', 1.0))

form_data.add_field('seed', kwargs.get('seed', 0))
form_data.add_field('format', kwargs.get('format', 'wav'))
form_data.add_field('speed', kwargs.get('speed', 1.0))

is_multipart_response = False
extras = ''

has_duration = kwargs.get('durations', False)

I think I would go with "alignment" instead of "durations"?
In src/lmnt/api.py
https://github.com/lmnt-com/lmnt-python/pull/1#discussion_r1316669454:

   word_durations = self._transform_to_word_durations(response['duration'], response['phonemes'])

   return {

     'durations': word_durations,

     'audio': response['audio']

   }

 else:

   await self._handle_response_errors(resp)

   return await resp.read()

def _transform_to_word_durations(self, durations, phonemes):
if not durations or not phonemes or len(durations) != len(phonemes):

 raise ValueError("Invalid word transformation input data.")

result = []
temp_phonemes, temp_durations = [], []

nit: acc instead of temp? since we're accumulating
In src/lmnt/api.py
https://github.com/lmnt-com/lmnt-python/pull/1#discussion_r1316669893:

def _transform_to_word_durations(self, durations, phonemes):
if not durations or not phonemes or len(durations) != len(phonemes):

 raise ValueError("Invalid word transformation input data.")

result = []
temp_phonemes, temp_durations = [], []
total_duration, start = 0, 0

for index, (dur, phon) in enumerate(zip(durations, phonemes)):

 temp_phonemes.append(phon)

 duration_samples = dur * _SAMPLES_PER_FRAME

 temp_durations.append(duration_samples)

 total_duration += duration_samples

 # Break words at any whitespace phoneme.

super nit: remove phoneme since whitespace isn't technically a phoneme
In src/lmnt/api.py
https://github.com/lmnt-com/lmnt-python/pull/1#discussion_r1316671683:

def _transform_to_word_durations(self, durations, phonemes):

if not durations or not phonemes or len(durations) != len(phonemes):

 raise ValueError("Invalid word transformation input data.")

result = []
temp_phonemes, temp_durations = [], []
total_duration, start = 0, 0

for index, (dur, phon) in enumerate(zip(durations, phonemes)):

 temp_phonemes.append(phon)

 duration_samples = dur * _SAMPLES_PER_FRAME

 temp_durations.append(duration_samples)

 total_duration += duration_samples

 # Break words at any whitespace phoneme.

 if phon == " " or ((index < len(durations) - 1) and phonemes[index + 1] == " "):

I think we can eliminate the peek and simplify this if we move before line
163?
e.g.
for all the phones:

if current is whitespace:

emit current accumulation if anything accumulated
emit current current whitespace token

else:

accumulate

and then after the for, make sure to emit any remaining accumulation (to
catch case if last is not whitespace)
In src/lmnt/api.py
https://github.com/lmnt-com/lmnt-python/pull/1#discussion_r1316673088:

@@ -16,12 +16,15 @@
import aiohttp
import json

+from loguru import logger
I don't see the logger used in this change, so remove?
—
Reply to this email directly, view it on GitHub
https://github.com/lmnt-com/lmnt-python/pull/1#pullrequestreview-1612329121,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAC7OXBA5STFP6SGFFXIZI3XY7VBDANCNFSM6AAAAAA4MSQOH4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Just a note on conventions: durations are used for a sequence of integers describing the duration of some underlying unit (e.g. phoneme, grapheme) whereas alignment is used to describe a matrix (often a binary matrix) with the time scales on each axis. I think in this case, durations is probably right.

LOL, I didn't see this in time -- will put it back, no problem.


Shade

Alaska Airlines Pull Request
Fixes: #14
Summary:
This PR adds the new shade feature to the auro-accordion custom element.
See example: https://accordion-shade.surge.sh/components/auro/accordion
Type of change:
Please delete options that are not relevant.

[x] New capability
[ ] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

[Yesterday 11:19 AM] Tom Bauer

Would it be possible to get it coded with "Elite benefits" section as an <h4> (18/20) and the supporting copy as <p> (14/24)?
Can we push the carrot over to be right-aligned?
Can the <p> copy have a left margin so it aligns with the <h4> headline?
Can we have the alert collapse when the user clicks elsewhere on the page or scrolls down?
Can we have a second color combo added with background #01426A, text #FFFFFF, and icon/bottom bar #00CFF0?

Status update:

Would it be possible to get it coded with "Elite benefits" section as an <h4> (18/20) and the supporting copy as <p> (14/24)?

See updated demo https://accordion-shade.surge.sh/components/auro/accordion

Can we push the carrot over to be right-aligned?

justifyLeft and justifyRight are both supported inline with the other Accordions

Can the <p> copy have a left margin so it aligns with the <h4> headline?

Not sure what this means?

Can we have the alert collapse when the user clicks elsewhere on the page or scrolls down?

This would need to be a separate feature added to the Accordion

Can we have a second color combo added with background #01426A, text #FFFFFF, and icon/bottom bar #00CFF0?

Current DS standards that are supported are information, warning, and error as illustrated in the Alerts / Messaging section of https://auro.alaskaair.com/color/digital-palette. This new use case would need to be defined in that space first.
I have concerns about that use as that fails a color contrast ratio, similar to this issue http://lockup-issue3.surge.sh/

@blackfalcon the design looks great! A couple functionality items that I'm not sure made it into the code (or are possible given you made this from existing patterns.)

Could we have the alert close when clicking elsewhere on the page and/or have it collapse when the user scrolls.
Not exactly sure we're on the same page about dark alert. I referenced the auro style "auro-auro-color-alert-notification-on-dark" when I put the mock together. I just ran the color combo through an accessibility analyzer again and it passes with a color contrast ratio greater than 4.5:1.


prompts "not installed" after succesfull installation on sbc

DETAILS
system: dietpi
sbc: orange pi lite
there is dedicated wifi-hotspot software in dietpi-software, but from unknow reasons it can't find repository of  it. Hotspotd installed succesfully, but it still think that it is not  #installed
COPY OF CONSOLE LOG
root@sbc:/path/hotspotd-0.1.4# sudo hotspotd configure
Verifying connections
Wifi interface found: wlan0
No network nic could be found on your deivce to interface with the LAN
Enter an IP address for your ap [<IP_ADDRESS>] :
Enter SSID [joe_ssid] :
Enter 10 digit password [1234567890] :
created hostapd configuration: run.conf
{'wlan': 'wlan0', 'SSID': 'joe_ssid', 'ip': '<IP_ADDRESS>', 'netmask': '<IP_ADDRESS>', 'password': '1234567890', 'inet': ''}
Configuration saved
root@sbc:/path/hotspotd-0.1.4# sudo hotspotd configure
Verifying connections
Wifi interface found: wlan0
No network nic could be found on your deivce to interface with the LAN
Enter an IP address for your ap [<IP_ADDRESS>] :
Enter SSID [joe_ssid] :montesque
Enter 10 digit password [1234567890] :KRACKcity874!
created hostapd configuration: run.conf
{'wlan': 'wlan0', 'SSID': 'montesque', 'ip': '<IP_ADDRESS>', 'netmask': '<IP_ADDRESS>', 'password': 'KRACKcity874!', 'inet': ''}
Configuration saved
root@sbc:/path/hotspotd-0.1.4# sudo hotspotd start
hostapd executable not found. Make sure you have installed hostapd.
root@sbc:/path/hotspotd-0.1.4# python setup.py install
running install
running build
running build_py
running build_scripts
running install_lib
running install_scripts
changing mode of /usr/local/bin/hotspotd to 755
running install_egg_info
Removing /usr/local/lib/python2.7/dist-packages/hotspotd-0.1.4.egg-info
Writing /usr/local/lib/python2.7/dist-packages/hotspotd-0.1.4.egg-info
root@sbc:/path/hotspotd-0.1.4# hotspotd configure
Verifying connections
Wifi interface found: wlan0
No network nic could be found on your deivce to interface with the LAN
Enter an IP address for your ap [<IP_ADDRESS>] :
Enter SSID [joe_ssid] :zaq12wsxcde3
Enter 10 digit password [1234567890] :1234567890wertyuiop
created hostapd configuration: run.conf
{'wlan': 'wlan0', 'SSID': 'zaq12wsxcde3', 'ip': '<IP_ADDRESS>', 'netmask': '<IP_ADDRESS>', 'password': '1234567890wertyuiop', 'inet': ''}
Configuration saved
root@sbc:/path/hotspotd-0.1.4# hotspotd start
hostapd executable not found. Make sure you have installed  hostapd.
root@sbc:/path/hotspotd-0.1.4# python hotspotd configure
Verifying connections
Wifi interface found: wlan0
No network nic could be found on your deivce to interface with the LAN
Enter an IP address for your ap [<IP_ADDRESS>] :
Enter SSID [joe_ssid] :raressid
Enter 10 digit password [1234567890] :secret_pass
created hostapd configuration: run.conf
{'wlan': 'wlan0', 'SSID': 'raressid', 'ip': '<IP_ADDRESS>', 'netmask': '<IP_ADDRESS>', 'password': 'secret_pass', 'inet': ''}
Configuration saved
root@sbc:/path/hotspotd-0.1.4# python hotspotd start
hostapd executable not found. Make sure you have installed hostapd.
root@sbc:/path/hotspotd-0.1.4# cd ..
root@sbc:/path# python hotspotd start
python: can't open file 'hotspotd': [Errno 2] No such file or directory
root@sbc:/path# hotspotd start
hostapd executable not found. Make sure you have installed hostapd.
root@sbc:/path# what's your problem?

It only means that the underlying hostapd component couldn't be found on your linux machine. Try running which hostapd to locate the executable, and install the package if necessary. This program (hotspotd) depends on it.

@Sarverott

Looks like configuration was not able to detect the interface which connect to the "internet" as 'inet' value is empty

 No network nic could be found on your deivce to interface with the LAN

and
{'wlan': 'wlan0', 'SSID': 'zaq12wsxcde3', 'ip': '<IP_ADDRESS>', 'netmask': '<IP_ADDRESS>', 'password': '1234567890wertyuiop', 'inet': ''}

You also need to find a way to install hostapd on Orange Pi
I see that a binary is placed under  /usr/local/bin/hotspotd. Can you try,

python /usr/loca/bin/hotspotd start


[DNM][RFC]libc: move to using C typedef from GCC

See what warnings we get when we move to using the types from the
toolchain.
Signed-off-by: Kumar Gala<EMAIL_ADDRESS>

Codecov Report

Merging #9121 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9121   +/-   ##
=======================================
  Coverage   52.45%   52.45%
=======================================
  Files         200      200
  Lines       25121    25121
  Branches     5244     5244
=======================================
  Hits        13178    13178
  Misses       9822     9822
  Partials     2121     2121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c384631...e73b24c. Read the comment docs.


Pass glob kwargs to super class from local fs

Proposed solution to https://github.com/intake/filesystem_spec/issues/283

Thanks @masda70!


[Bugfix] Pass PYTORCH_ROCM_ARCH to FA build

The Dockerfile layer that builds flash attention uses the PYTORCH_ROCM_ARCH argument.  But since we don't have ARG PYTORCH_ROCM_ARCH under the FROM for that layer, the argument isn't actually in scope and therefore isn't set.  This causes flash attention to try to build with the default list of targets (a much longer list than the two architectures we use by default in our PYTORCH_ROCM_ARCH, and the default list is currently failing for the ck_tile branch of FA).

A few comments:

Dockerfile layer that builds flash attention uses the PYTORCH_ROCM_ARCH argument
It actually uses the PYTORCH_ROCM_ARCH environment variable, which is set in the base image layer. Unfortunately, Dockerfile syntax is a bit confusing and, that said, it also doesn't help that we use it both as a environment variable and a build argument.

This causes flash attention to try to build with the default list of targets (a much longer list than the two architectures we use by default in our PYTORCH_ROCM_ARCH, and the default list is currently failing for the ck_tile branch of FA).
I'm not actually seeing this happen on ROCm/vllm commit 50dd2561, i.e. MLPerf branch before this change. I'm using command docker build -f Dockerfile.rocm --target build_flash_attn . --build-arg "FA_BRANCH=ck_tile" --progress=plain. It's building ck_tile for arches gfx90a;gfx942, as expected.

ck_tile FA takes a really long time to build. The workaround we've done in upstream vLLM that will soon be making its way to the ROCm fork is to pre-build the ck_tile flash-attn wheel and save it as a release in ROCm/flash-attention. We then download it in the Dockerfile instead of building it, if possible. Note that you won't be able to use this wheel for ROCm/vllm directly without installing the appropriate version of torch (more details in the linked release wheel above).

In short, this change shouldn't be necessary.

Thanks for checking it over, @mawong-amd .  After further testing, I agree this change isn't necessary and can be reverted.
It appears the issue that some users were running into were attempting to build without docker-buildx.  With buildx it works properly; without buildx flash attention complains:

AssertionError: One of GPU archs of ['gfx900', 'gfx906', 'gfx908', 'gfx90a', 'gfx1030', 'gfx1100', 'gfx1101', 'gfx940', 'gfx941', 'gfx942'] is invalid or not supported by Flash-Attention

Looking forward to the streamlined flash-attention install instead of waiting for it to build!


Ensure that code uses its packaged libgl drivers

This PR fixes #110564

Hi @joaomoreno, could you please have a look at this? It looks like @Tyriar is away. Thanks!

Closing per https://github.com/microsoft/vscode/issues/110564


dev/Common/Utils.js isNormal() not needed

In JavaScript null == undefined.
Therefore the isNormal() check for null and undefined is not needed.
Instead, just (null != value) is sufficient for (null != value && undefined != value).
Secondly the pString() already checks for null != value, so checking two times is not needed.

My branch is far ahead of RainLoop master.
Only 1 commit should be with this request:
https://github.com/the-djmaze/rainloop-webmail/commit/90529d621d1e980d255afa11daa48963e5d1c0dc


ui-template How to get a flow variable?

Hi noob here, in node red we can get a flow or global variable by using flow.get("blah"), however it seems inside ui-template I can't read or get a flow value, currently I have to use function node to read a flow variable and then pass that variable as a msg.blah to template node. So my question is, how exactly I can read flow variable directly inside a ui-template ? Thanks guys!

Here, we assign msg.payload (could be anything) to a value from the global/flow stores
Thanks for the explaination. If I understanding correctly, when a value is updated and passed to ui-template node, it will cause the entire dashboard to re-render (assuming db is build only with ui-template node), is it correct?

it will cause the entire dashboard to re-render (assuming db is build only with ui-template node), is it correct?

Not necessarily, it'll just update the components using the msg. properties in ui-template.

OK thank you for your explaination.


Correction of torch.symeig according to pytorch recommendation: https…

This corrects the use of torch.symeig (deprecated) by replacing it with torch.linalg.eigh, in compliance with pytorch recommendation. It removes several warnings when using xitorch.linalg.symeig.
https://pytorch.org/docs/stable/generated/torch.symeig.html

Thanks, @danmlr. The development is moved to https://github.com/xitorch/xitorch/ could you please make the pull request there?


New feature: JMESPath filter on results

It would be really useful if you could pass an argument to httpie that would filter the results of the JSON it received using a JMESPath expression (http://jmespath.org/). This would be similar to how the AWS CLI works with the --query option (http://docs.aws.amazon.com/cli/latest/userguide/controlling-output.html).
If there is interest in this and people think it would be worthwhile I might look into it and submit a pull request when I have some time.

@jeremyplichta advanced content manipulation is not really something httpie should itself. You can, however, easily use httpie in with other tools, such as jq.

Thanks, wasn't aware of that tool at the time but have since found it!
On Fri, Sep 11, 2015 at 7:06 AM Jakub Roztočil<EMAIL_ADDRESS>wrote:

Closed #367 https://github.com/jkbrzt/httpie/issues/367.
—
Reply to this email directly or view it on GitHub
https://github.com/jkbrzt/httpie/issues/367#event-407050181.


bazel: 0.24.0 -> 0.26.0

Motivation for this change
A few new versions of Bazel have been released. This bumps to 0.26.0 to stay recent.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@grahamcofborg build bazel

Please give it another try @matthewbauer
I still can't get it building on Darwin, but I enabled sandbox to get past the Skydoc error, so I think it may get a bit further on Linux.
My Darwin error is:
In file included from src/main/cpp/blaze_util_darwin.cc:24:
/nix/store/mffyf74zc4h2wic5lwx0kyx7gvwif0c5-Libsystem-osx-10.12.6/include/pthread/spawn.h:65:34: error: unknown type name 'qos_class_t'; did you mean 'au_class_t'?
                                 qos_class_t __qos_class);
                                 ^
/nix/store/mffyf74zc4h2wic5lwx0kyx7gvwif0c5-Libsystem-osx-10.12.6/include/bsm/audit.h:176:19: note: 'au_class_t' declared here
typedef u_int32_t       au_class_t;
                        ^
In file included from src/main/cpp/blaze_util_darwin.cc:24:
/nix/store/mffyf74zc4h2wic5lwx0kyx7gvwif0c5-Libsystem-osx-10.12.6/include/pthread/spawn.h:88:34: error: unknown type name 'qos_class_t'; did you mean 'au_class_t'?
                                 qos_class_t * __restrict __qos_class);
                                 ^
/nix/store/mffyf74zc4h2wic5lwx0kyx7gvwif0c5-Libsystem-osx-10.12.6/include/bsm/audit.h:176:19: note: 'au_class_t' declared here
typedef u_int32_t       au_class_t;
                        ^
2 errors generated.

Build succeeds on Linux, but tests are failing with:
src/main/tools/process-wrapper-legacy.cc:58: "execvp(external/remote_java_tools_linux/java_tools/ijar/ijar, ...)": No such file or directory

Here's a fix for the Darwin issue:
diff --git a/pkgs/development/tools/build-managers/bazel/default.nix b/pkgs/development/tools/build-managers/bazel/default.nix
index 3b23ca395e8..3a880541228 100644
--- a/pkgs/development/tools/build-managers/bazel/default.nix
+++ b/pkgs/development/tools/build-managers/bazel/default.nix
@@ -160,6 +160,9 @@ stdenv.mkDerivation rec {
         src/tools/xcode/realpath/BUILD \
         src/tools/xcode/stdredirect/BUILD \
         tools/osx/BUILD
+
+      # nixpkgs's libSystem cannot user pthread headers directly, must import GCD headers instead
+      sed -i -e "/#include <pthread\/spawn.h>/i #include <dispatch/dispatch.h>" src/main/cpp/blaze_util_darwin.cc

       # clang installed from Xcode has a compatibility wrapper that forwards
       # invocations of gcc to clang, but vanilla clang doesn't

Legend! Thanks @uri-canva I'll kick off a local test now. I think I'll have to fetch the java_tools_javac10_darwin-v3.1.zip as well.
I think I understand what is happening during the installCheckPhase. I've got it working if I build on Linux without Nix. Bazel downloads java_tools_javac10_linux-v3.1.zip when building the interface jars for junit4 used in the tests.
This is failing under Nix. I'm not 100% clear on how or if this should be fixed. I wonder if the whole approach to these tests may fail, given that Bazel can fetch rules remotely.

@GrahamcOfBorg build bazel

Success on Darwin, failure on Linux. Must be a first! 😂
I'm looking into the Linux errors. I didn't have sandbox enabled locally, so I'll do that for Linux which will hopefully help track down errors.

@uri-canva Thanks! Opened this issue to track what's going on: https://github.com/NixOS/nixpkgs/issues/62555

@matthewbauer Any chance you can kick off another build. Linux only. I'm unable to run sandboxed builds in a Docker container at the moment. I've fixed the previous error with rules_sass in https://github.com/NixOS/nixpkgs/pull/62336/commits/f1a511a86a02295e2385da96180e3481d68b26d5

I suspect the Bazel tests fail on Linux because of the network sandboxing. The way the building of the tests should be done to account for that is the same way buildBazelPackage does it: first run bazel fetch as a fixed output derivation with networking enabled, then run bazel test with networking disabled.
We could rewrite the whole derivation to split it in two: first build the bootstrap bazel, then use boostrap bazel with buildBazelPackage to build and test Bazel. That also mirrors what compile.sh does.
It's a lot of work though, we might want to skip testing java on Linux in the meantime.

@Profpatsch This is now ready for review. Please kick off a build to confirm.
I expect it to pass on Darwin. Fail on Linux. I'm able to reproduce the Linux failure on my local VM.

We could rewrite the whole derivation to split it in two: first build the bootstrap bazel, then use boostrap bazel with buildBazelPackage to build and test Bazel. That also mirrors what compile.sh does.

Yes, I think given the way Bazel works, this is the only sensible solution. I think I understand what is necessary. Will that second inside buildBazelPackage be cached in the Nix store?

Yes, the deps derivation is separate from the build derivation and they get cached separately.

So we’re skipping 0.25 alltogether? https://github.com/NixOS/nixpkgs/pull/61097

So we’re skipping 0.25 alltogether? #61097

The Bazel release cycle is too frequent to do 1:1 Nix releases. I certainly don't have time to do it. The functionality I want is in 0.26. In a week or 2 there will 0.27....

@GrahamcOfBorg build bazel.tests

The linux test fails.

The linux test fails.

@Profpatsch Yes, thanks, it is expected. We just wanted to confirm if it fails on CI with the same error as we get locally. It does, so that's great, we can hopefully fix it.
The failure is due to the sandbox blocking network access during the tests. Bazel isn't very good to test in this way, as rules can go and download other rules at runtime. What are your thoughts to fixing it?

What are your thoughts to fixing it?

By now I’m tempted to disable the checkPhase (doCheck = false;) and rely on the manual tests we run afterwards.

The problem now is that the fetch arbitrary binaries (external/remote_java_tools_linux/java_tools/ijar/ijar) and try to execute them, we must patch those first or add their dependencies to the test environment.

The java tools currently live here: https://github.com/bazelbuild/bazel/tree/master/src/java_tools, but they'll move them to https://github.com/bazelbuild/java_tools eventually. We can build them from source in the nix derivation using the bootstrap bazel that should be possible to build without network access.

Sorry I'm just commenting and not helping much on the PR this time, I don't have enough time to dedicate to it at the moment.

We can also patch out some of the remote files as long as we delete the references to them: I cannot believe the rules_sass and rules_nodejs are needed for building Bazel itself, they're probably used to render the documentation.

@Profpatsch

By now I’m tempted to disable the checkPhase (doCheck = false;) and rely on the manual tests we run afterwards.

I agree that this is the best course of action for now. PR updated to reflect this. Passing locally on my Linux VM.
I'll try to find some time to submit an additional PR to change the approach of the Bazel derivation as @uri-canva is suggesting.

@GrahamcOfBorg build bazel

@GrahamcOfBorg build bazel bazel.tests

Why the heck is the builtin rule py_binary downloading external libraries.

I opened an upstream issue https://github.com/bazelbuild/bazel/issues/8575

@GrahamcOfBorg build bazel.tests

@GrahamcOfBorg build bazel.tests

@GrahamcOfBorg build bazel.tests

@GrahamcOfBorg build bazel.tests

@GrahamcOfBorg build bazel.tests

I very much appreciate the help here @Profpatsch
0.26.1 has been released. If you are able to get 0.26.0 working, it might be worth giving one shot to the 0.26.1 since we're in the trenches anyway. I'm happy to help and / or prepare it. I can dig up all the hashes etc. Equally, I'd totally understand if you'd rather not.

Sure, but tomorrow. I think it’s building now (I’m pretty sure caching the bazel extraction for tests was not worth the effort lol).

@GrahamcOfBorg build bazel.tests

Great! Seems to have passed. I'll try a quick bump to 0.26.1 sometime today.

The build works locally for me on Darwin (no sandbox) and a NixOS VM (sandbox = true).
I'll update the title, description and squash the commits.

Is it okay if we leave the commits as-is? I’d only squash in the fixup commits (git rebase --autosquash).

Is it okay if we leave the commits as-is? I’d only squash in the fixup commits (git rebase --autosquash).

Apologies, I think I'm too late and I've squashed it all down.  Maybe that's not standard across the whole repo or is more nuanced and can be more than a single commit.

Normally multiple commits for separate changes are not a problem. I’ll force-push the split commits.

Okay, I rebased to master & autosquashed the fixup commits. Will merge once it’s green again.

Ah, I’m sorry, I didn’t see the bump to 0.26.1.

I'm putting a quick PR together for 0.26.1.

Thanks @Profpatsch @kalbasit

I just noticed that this changed the hash of the fetch phase of dm-sonnet. We probably have to be more careful with bazel updates in the future if we're using it in fixed output derivations.

I just noticed that this changed the hash of the fetch phase of dm-sonnet. We probably have to be more careful with bazel updates in the future if we're using it in fixed output derivations.

Uuuuuuuuuuuuuuugh, I suggest we just don’t.
@timokau But for the while being, can you add a tests.downstreamPackages = { inherit <list of packages that use fetchbazel>; }?

Don't do what? Don't be careful seems like a bad idea to me ;) And we're already using it in fixed output derivations, I don't see how we could avoid that when building bazel packages.
Would that actually help? Since they're fixed output, they will just be fetched from the binary cache and therefore pass the tests even though they're broken.

@timokau you can probably override one of the phases of the fetcher to invalidate it's input, and force it to compile. Something like echo ${version} should do.

Interesting idea! I feel like there is a bit of a "just because you can doesn't mean that you should" going on here, but here we go: https://github.com/NixOS/nixpkgs/pull/63645
I have created a separate attribute for the derivation instead of a list, because a list wouldn't get built with nix-build -A bazel.test.

Don't do what? Don't be careful seems like a bad idea to me ;) And we're already using it in fixed output derivations, I don't see how we could avoid that when building bazel packages.

Don’t ever use fixed output derivations.

How else should we fetch bazel dependencies?
I'd expect the fetch output to become deterministic between releases once bazel is stable. If it still isn't, we can look into how they differ between releases and clean up the fetch result accordingly (similar to what we do with fetchpatch).

How else should we fetch bazel dependencies?

We do it like with all other (well-behaved) package managers and generate nix expressions for WORKSPACE dependencies. I already wrote a mockup hack for updating bazel proper: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/build-managers/bazel/update-srcDeps.py
But really, bazel devs should pull the stick out of their asses, provide a reasonable interface and become a nice player in the open source world.

Yeah Bazel is really really biased towards monorepos with full vendoring.
I think something good integration-wise can be done with resolved workspaces and provided external repositories, but both mechanisms are very much in their infancy and it's unclear how well supported they are:
https://blog.bazel.build/2018/07/09/bazel-sync-and-resolved-file.html
https://github.com/bazelbuild/bazel/issues/5252

Ah, yes, that’s the better way tbh. It’s a skylark file, so we should be able to cheat our way by evaling it in a python interpreter.


Avoid reconciles without any meaningful changes when the workload controller checks PodsReadyTimeout

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In the current approach, the workload controller always checks not ready workload even if the workload already has been inactive or had Evicted=true condition.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?

NONE

/assign @alculquicondor

/lgtm
/approve

/cherry-pick release-0.5


Nuget 2.0.275-beta, FSharp.core reference missing assembly

Hi, I m currently working with Nuget beta package to use new simplified API.
I do not use FSharp, and all works fine when I build from Visual Studio.
I need to include my tool in a company project, and must provide it as single exe file.
So I used ILMerge to include dll into a single exe file, but here an error occurs:

Unresolved assembly reference not allowed : FSharp.Core

After few research I have found issue #319.
To make my ILMerge work I have to clone project, and build it with SKIP_FSHARP preprocessor variable (or add FSharp.core to my project).
How is this managed in Nuget stable package?

The stable package doesn't have a dependency on FSharp - between 1.x and 2.x the library was completely rewritten.

Sorry, my question was poorly formulated, it is about future release.
I don't want to embed it as it increase my tool x 2 (and CommandLine x 7).
I understand this is a special case, ILMerge is checking for assemblies references and fail to merge. In many cases you just have to not add FSharpCore.dll.
I just want to now if I need to stop use NuGet and work with repository instead for future release.
Thanks.

Ah, no there are no plans to remove FSharp.core from the NuGet package. If you need it gone, you'll have to compile it yourself with the SKIP_FSHARP flag

Ok, thanks.
And thanks again for your library,really good job!


feat: Implementation of css animation for added by div

Fix #58
This PR will implement smooth text lift-up animation on added by text container. This will improve user experience by making smooth animation effects.
https://github.com/Shariar-Hasan/QuoteVerse/assets/99007146/6a7ee3de-6b3d-451a-b11c-8730c4dd2719
Thanks,
Jenish

Well done bro 🎇 💥💥
excellent work.
PR merged ✅🆗


Spacewar

Only shows Spacewar when I open the app. How can ı fix this?

put the game id of the game you want to work with into the text box

If it's only showing Spacewar then that usually means SAM failed to download the list of games that have achievements/stats from my server. Generally an intermittent problem that should be resolved now.


HDDS-9687. Add a handle delete with non-ratis.

What changes were proposed in this pull request?
Add a handle delete with non-ratis
Currently, deleting directory data will not be deleted in non ratis mode
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-9687

Thanks @z-bb working on this, let's waiting ci passed.

@aswinshakil can you please review?

Thanks @z-bb for the patch, @aswinshakil, @guohao-rosicky for the review.


Fix isValid function

The isValid function return not correct, this caused re-rendering the whole TextField when value prop received.

@quangbuule Thanks for opening this PR. I'm not really sure what the issue is.
For this type of fix, could you add a unit test? (for inspiration https://github.com/callemall/material-ui/blob/master/test/checkbox-spec.js). Or, could you explain us how to reproduce the issue?

I use Portal of react-overlays, It internally use React.unstable_renderSubtreeIntoContainer to render it into another DOMNode (outside React root DOMNode).
Here is my code:
import ReactDOM from 'react-dom';

import React, { PropTypes } from 'react';
import { TextField } from 'material-ui';
import { Portal } from 'react-overlays';

export default class Comp extends React.Component {

  constructor(props) {
    super(props);
    this.handleInputChange = ::this.handleInputChange;
  }

  componentWillMount() {
    this.setState({
      inputText: ''
    });
  }

  render() {
    const { inputText } = this.state;

    return (

        <Portal container={() => document.querySelector('#container')}>

            <TextField value={inputText} onChange={this.handleInputChange} />

            <input value={inputText} onChange={this.handleInputChange} />

        </Portal>

    );
  }

  handleInputChange(e) {
    this.setState({
      inputText: e.target.value
    });
  }
}

ReactDOM.render(<Comp />, document.querySelector('#root'));

And I found that the isValid function cause the UX bug as a GIF below.

And I found that the isValid function cause the UX bug as a GIF below.

What's the bug?

Sorry for not clarifying the bug. In the example above, when I type "Ipsum", every's fine, after that, I move the cursor to the begin of the text and begin to type "Lorem", and the bug is TextField always make my cursor to go to the end of it every time I press a key. And you can see, the bare input element didn't cause the UX bug like that.

I see. That's weird, this is working correctly on material-ui as far as I have tested id.
How is this solving the issue?
I think that a unit test for this would be really valuable (prevent to break in the future, that's tricky)

It hard for me to find out why it acting weird like this. I dived into TextField source and try to eliminate state change when onChange trigger, and I found that state.hasValue is always changed (to the input value - not an true/false boolean as expected) when I change the input value. So the Boolean(...) fix my problem :D.
Notice that this is caused only when using with React.unstable_renderSubtreeIntoContainer.
It's always nice to have tests, but I am not familiar with this kind of test and currently busy with the work project, so that's pity.

state.hasValue is always changed (to the input value - not an true/false boolean as expected)

I'm happy with this, let's fix it :+1:.

@quangbuule Thanks!


Is this wallet affected (as Copay was) by the NPM exploit found in the event-stream package?

https://github.com/bitpay/copay/issues/9346

Only packages with the words "A Secure Bitcoin Wallet" as package description will trigger the malicious payload. This isn't the case with this package here.

The above description from Copay states the versions affected, I think you would need to know which versions have been released over time and which users are running any affected ones in order to tell. I was looking here where it would appear the versions over time came straight from copay (I could be wrong) l:https://github.com/Bitcoin-com/Wallet/blob/master/package.json Could you provide any reference to the quoted description you provided such as links?

The quoted trigger-word string comes from the analysis done by myself and a few other people over at the original issue at https://github.com/dominictarr/event-stream/issues/116, if you're brave enough to venture over this centithread.

Thanks, I saw that thread earlier but didn't dive into it that much, will check to see your contribution there! So does the hotfix 5.2 that Bitcoin.com made three days ago contain the same security patch as the 5.2 update that Copay mentioned? https://github.com/bitpay/copay/issues/9346#issuecomment-441844283

I have no idea about what kind of patches have been applied to where, unfortunately.

Only packages with the words "A Secure Bitcoin Wallet" as package description will trigger the malicious payload. This isn't the case with this package here.

According to Ematiu, lead copay dev, the above comment is correct.


fix: Adjust navigator usage within Flutter

Using useRootNavigator flag was fragile, because it assumed that
GoRouter will always remain be the top navigator.
This has changed with introducing BetterFeedback (similar issue would have
been observed with Firebase Analytics, if we merged that already).
By selecting a navigator in dialog windows that was above GoRouter we could not access it as we only had access to the parent context.
Allow specifying global navigators directly if needed (e.g. when they need to be
on top of the widget stack) by referring to their keys.

Merging because we need this for testing!


when I try to fine tune

Traceback (most recent call last):
File "/root/LMFlow/new/LMFlow-main/examples/finetune.py", line 70, in
main()
File "/root/LMFlow/new/LMFlow-main/examples/finetune.py", line 55, in main
model = AutoModel.get_model(model_args)
File "/root/LMFlow/new/LMFlow-main/examples/lmflow/models/auto_model.py", line 16, in get_model
return HFDecoderModel(model_args, *args, **kwargs)
File "/root/LMFlow/new/LMFlow-main/examples/lmflow/models/hf_decoder_model.py", line 148, in init
model = AutoModelForCausalLM.from_pretrained(
File "/root/anaconda3/envs/lmflow/lib/python3.9/site-packages/transformers/models/auto/auto_factory.py", line 471, in from_pretrained
return model_class.from_pretrained(
File "/root/anaconda3/envs/lmflow/lib/python3.9/site-packages/transformers/modeling_utils.py", line 2709, in from_pretrained
) = cls._load_pretrained_model(
File "/root/anaconda3/envs/lmflow/lib/python3.9/site-packages/transformers/modeling_utils.py", line 3087, in _load_pretrained_model
raise RuntimeError(f"Error(s) in loading state_dict for {model.class.name}:\n\t{error_msg}")
RuntimeError: Error(s) in loading state_dict for LlamaForCausalLM:
size mismatch for model.embed_tokens.weight: copying a param with shape torch.Size([49954, 5120]) from checkpoint, the shape in current model is torch.Size([32000, 5120]).
size mismatch for lm_head.weight: copying a param with shape torch.Size([49954, 5120]) from checkpoint, the shape in current model is torch.Size([32000, 5120]).
You may consider adding ignore_mismatched_sizes=True in the model from_pretrained method.

Thanks for your interest in LMFlow! Looks like the input model doesn't match the llama structure. Could you please provide the commandline arguments so we may check that for you? Thanks 😄

This issue has been marked as stale because it has not had recent activity. If you think this still needs to be addressed please feel free to reopen this issue. Thanks

@shizhediao Hi, I got the same error with this model, while this error would not appear with 7b-model.

We do not know what these models are as they are provided by someone else.
If you want to use lora, you can download our trained lora checkpoints here https://github.com/OptimalScale/LMFlow#5-model-release
Thanks!


Update coverage badge in README with pull requests

coverage: 95.463%. remained the same when pulling a5397c11b08447344213259740d57ebf768996f3 on feature/update-coverage-badge into d173638cd0dd082ebd6b2108c568f62a3e634233 on main.


No response or delay in response

From a few hours earlier, there is no response or sometimes delay in response
attaching the debug log
https://paste.ubuntu.com/p/3bTZhw5yr8/

Try new version #99


fix completion reopen after focus loss bugs

fix completion reopen after focus loss bugs: ISE for non-text cell, no action for text cell

Good Job!


Request: damselfly photo gallery

Can you make damselfly photo gallery addon for HA.

Hi, I've already 2 specific addons for photo gallery, plus nextcloud that can be used as such. Is there a specific added value of this one? BTW I couldn't find it on Google. Best regards

Is there a specific added value of this one?
Yes.
Read this: link

You are asking me to freely, out of my own time, create an addon for a tool for which you are the only requester. Afterwards, I'll do updates, maintenances, and support. All that out of my free time, and in addition to my family and full time job.
The least you could do is take the time to summarize me the need, instead of providing a github page for me to go through.


How do I create a node that links to a route with several parameters

If I use the RouteValues property, the values get added as query string parameters. Is it possible to have RouteValues added as part of the route?
Basically, I have a route that takes 4 parameters. It looks something like this:
http://url/locations/ny/nyc/sky/234
How would I get the breadcrumb to link to that?

SmartBreadcrumbs just uses IUrlHelper methods and passes RouteValues to them, so the problem is most likely not the library.
How do you define your RouteValues? are they named properties? What about your method/action?

The RouteValues are working. But they're just being appended to the url as QueryString parameters.
Looking through the source, I realized I really need a URL generated by UrlHelper.RouteUrl rather than urlHelper.Action. I would submit a PR with this feature. My question is if it makes sense to make a new class (i.e. MvcRouteBreadcrumbNode) that would take a route name in the constructor instead of controller and action or rather just make another constructor for MvcBreadcrumbNode. Depending on which parameters are filled in (controller and action or routename), the GetUrl method would either call urlHelper.Action or urlHelper.RouteUrl. I think having separate classes makes more sense.

I just tested this in my project and it works. If this approach makes sense to you, I'll submit a PR.

Can it just be a parameter (property) in the Node? Would that work? I think that would make it easy to configure, but I still don't fully understand the solution, do you pass an actual route instead of action/controller?
I always thought UrlHelper.Action fills route values too.

This is the signature of the action:
`
[Route("locations/{state?}", Name = "locations-state")]
public IActionResult State(string state)
`
And this is how I add this route to the breadcrumbs:
            var childNodeState = new MvcRouteBreadcrumbNode("locations-state", response.Response.ParentLocation.Name)             {                 RouteValues = new {state=state}             };

To answer your question better, yes, I pass in the actual route name. The example I posted only takes one parameter. I can technically fake out the route by passing "location" as the controller and the value for state as the action. But once I have more parameters, there's no way to specify them all as part of the url. As I mentioned earlier, RouteValues don't get appended to the actual url but are added as QueryString parameters. Working with the actual route allows me to use a route name and pass in as many parameters as needed. The UrlExtensions.RouteUrl will automatically build the correct url.

Fixed by #40
A NuGet package will be available once another issue gets fixed, thank you!


The sync hangs after it returns to Mint with the black splash screen

I start the sync and a tab is opened in Mint which then moves to Robinhood and back to Mint. It never completes this last step and just hangs there with the text "Syncing Mint and Robinhood... This window will automatically close when the sync is complete".

Are you still experiencing this issue with the latest release?

Hi George.
I actually uninstalled the plug-in since I couldn't get it to work and
furthermore, Robinhood seemed to start supporting native sync with Mint (or
vice versa).
Dan
On Thu, 10 Oct 2019 at 21:58, George W. Walker<EMAIL_ADDRESS>wrote:

Are you still experiencing this issue with the latest release?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pkmnct/robinhood-mint-sync-chrome/issues/2?email_source=notifications&email_token=ALCNRJTSQ25EN7I3XRLDQHTQN7TV7A5CNFSM4GOPV462YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA6SVDA#issuecomment-540879500,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALCNRJWJ2M22N6ZHJYVTS3LQN7TV7ANCNFSM4GOPV46Q
.


Fix 'Wall of Fire' duration

By the book, it's 'Concentration + 1 round/level', rather than 'Concentration up to 1 round/level'. Basically you can cast it as a 'fire and forget' spell, but maintaining concentration extends it further.
Includes some spell_utils additions to facilitate these sorts of  spells.

Thanks. Are you looking into wall spells?

Actually it was the 'concentration + X' that I wanted to hash out, since I've seen other spells, and then noticed it applied to this one.
I thought about walls a little, but it seems like most of them would require spawning something to actually block movement, and that seems more complicated than I want to dig in to right now. Like, I assume it would be complicated by either having to know of the right proto that already exists, or creating an appropriate one with all the 'what about other modules' complications that entails.
Actually, even this spell does not technically match the SRD (even ignoring the alternate shapes). It seems like the wall part is almost supposed to be a 2D plane, and then one side of the wall blasts out to a distance of 20ft (with lower damage 10-20 ft, higher 0-10 ft, and the highest for actually going through the 2D part). But I think implementing that would significantly complicate the targeting options, and probably isn't worth it for this one spell.
I guess the 'radius' could also be increased. Making it 20ft makes it hard to even use in a lot of places, though. It gets hung up on level geometry really easily. You can basically fill an entire temple corridor with fire, and it'd be ridiculous on the fire node with double size.


fix(sinsp): plugin capture listen capability exception

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

fix(sinsp): plugin capture listen capability exception

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mrgian
Once this PR has been reviewed and has the lgtm label, please assign molter73 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.18.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 861c6c1c90e6e4e25ecaa42c9811c17872703f88

/hold

New changes are detected. LGTM label has been removed.

LGTM label has been added.  Git tree hash: 5d5cb6853a473bddf00e545c9c6c5076fbf1026c

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, mrgian
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold


How make $batch execute continue on errors

Hi there,
How make $batch to execute continue when error occurred?
for example.
I want to use $batch to get 2 account and 3 contact  in one request.
so I built the requests in turn. e.g.
account-1
account-2
contact-1
contact-2
contact-3
if all records exists in environment, it works perfect. but if there is one record does not exist, let's say contact-1 does not exist. then I only got 3 response (account-1,account-2 and a "404 not found response" for contact-1)
what I want is to get all responses for the 5 records, how this can be done in WEB API. I know it can be done in Organization Service through ExecuteMultipleRequest  and set ContinueOnError to true
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: af14071e-83a5-8dde-6346-d158b4d5d66a
Version Independent ID: 8fb0f4fb-17ff-7491-d057-a1edf9242bc8
Content: Execute batch operations using the Web API (Common Data Service) - Power Apps
Content Source: powerapps-docs/developer/common-data-service/webapi/execute-batch-operations-using-web-api.md
Service: powerapps
GitHub Login: @JimDaly
Microsoft Alias: jdaly

@Flex-Xuan If you want a quick answer would be better asking your question in the community forums at https://community.dynamics.com/crm/f/microsoft-dynamics-crm-forum .

@bthompson-365  Okay, thank you.

I found the answer at https://docs.microsoft.com/en-us/odata/webapi/batch
close this.

Re-opening this because people should be able to find this information here.

@Flex-Xuan Thanks for the feedback. I added a link to the topic that provides more information about continuing on batch errors


Attestation inclusion is slow on Medalla

Description
As a staker, I want my attestations included quickly so that I make maximum reward.
beaconcha.in has implemented an Attestation Effectiveness metric based on this model. This surfaces the detailed analysis of rewards and penalties I did on Altona.
Where identifiable, Prysm and Lighthouse validators seem to be consistently in the 80-90% effective range, whereas Teku validators are consistently around 40-50%. This appears to be solely due to delays in getting attestations included, not due to missing attestations.
Example. Click Attestations to see the inclusion distance (0 distance means in the slot immediately after the block).
Acceptance Criteria

Attestation effectiveness at least as high as Prysm and Lighthouse

#2637 is likely to help improve the attestation inclusion rate.  Deployed to our validators and will watch to see the results.

#2637 did significantly improve things but #2661 really won't be helping this.

Last enhancement to put in was flood publishing which went in with #2717.  Attestation effectiveness is now looking really good and any further ideas on improving it can be done in their own tickets.


unit test failure not captured by CI

What happened:
go test ./pkg/usage/... -v -count=1 -cover -timeout=5m -coverpkg=./pkg/usage/... -coverprofile=mutest-cov.out

What you expected to happen:

fix the test
check why the test failure is not captured by CI.

How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?
Environment:

JuiceFS version (use juicefs --version) or Hadoop Java SDK version:
Cloud provider or hardware configuration running JuiceFS:
OS (e.g cat /etc/os-release):
Kernel (e.g. uname -a):
Object storage (cloud provider and region, or self maintained):
Metadata engine info (version, cloud provider managed or self maintained):
Network connectivity (JuiceFS to metadata engine, JuiceFS to object storage):
Others:

May be related to #3252

Cannot reproduce panic but the test result is success.


zgui: Add icon font support for text icons.

Small issue, but I was hoping to use font-awesome icons in zgui, similar to how Prime31 did with zig-upaya. For any interface it would be nice to have access to icons.
It looks like here is a good start.

It looks like this is also a useful issue, I'm trying to use cozette which has some icon glyphs, but it looks like I need to be able to expand the default range using a config passed to zgui.io.addFontFromFile to make that work.

I think that all we need here is: zgui.io.addFontFromFileWithConfig() which is similar to zgui.io.addFontFromFile() but additionally takes config and `range'. And then the user should be able to use any glyphs from any font.
To make this happen we need to expose: ImFontConfig struct. Do you want to give it a try? As an example you could take a look at zgui.InputTextCallbackData.

Sure thing! I actually already got this change working locally and it all seems fine, I'll PR it soon, really appreciate it!

Is there an example on how to use addFontFromFileWithConfig? I don't understand how to set the ranges.
I'm just trying make ˚ renderable in additional to the default text range.

https://github.com/foxnne/pixi/blob/main/src/pixi.zig#L185

Thanks! That worked for me. I loaded the font with the default range, then merge in the additional range I want.
_ = zgui.io.addFontFromFile(
    content_dir ++ "Roboto-Medium.ttf",
    math.floor(20.0 * scale_factor),
);
{
    var config = zgui.FontConfig.init();
    config.merge_mode = true;
    const ranges: []const u16 = &.{ 0x02DA, 0x02DB, 0 };
    _ = zgui.io.addFontFromFileWithConfig(
        content_dir ++ "Roboto-Medium.ttf",
        math.floor(20.0 * scale_factor),
        config,
        ranges.ptr,
    );
}


fix: brits imputation test device mismatch

attempt to fix #10

By the way, may I suggest using code autoformatter named black? :grin:

Hi Maciej, thank you for your patience! I'm sorry for my delayed response. I have run the test cases and the results look fine. I only have one comment for your PR 😉 When you try to fix a bug, please only modify the code that is related to the bug because this can help the reviewer quickly understand what you are working on.
And BTW, what do you mean by 'using code autoformatter named black'? Sounds like a configuration of repository settings on GitHub.
Last but not least, many thanks for your PR! 😃

Hi Wenjie, thank you for reviewing the PR!
Your insight is on point. I really shouldn't have tinkered with the code that does not concern the issue at hand, especially when it is just cosmetics, as it makes analysing code more difficult. I am sorry for being overzealous :grin:
What I do mean about 'using code autoformatter named black': there's this thing called black. It is a python autoformatter, that obides the pep8 code style. It can be used as a standalone program run on *.py files. In that regard it is similar to python linters like pylint. As it can be used in a  standalone manner, I guess it is possible to include it in your GitHub workflows. I think it would either create a new commit on top of what is being pushed to the branch, or ammend the last commit. It can also be used as part of your IDE / text editor while first writing the code - I know it is a no-brainer to setup with VSCode. My colleague, who uses Eclipse, had to tinker with it for a while.
Anyway, black makes the indents right, the quotes consistent, the function arguments neatly organised and so much more! It can be parametrised a bit, and the config is just a file that you can keep in the repo, so people automatically use the code style you ask them to, as long as they use black.. Its greatest advantage is that anyone working with the code shares the same style without ever giving it a single thought.
On the other hand, when one party does not use black, and the second party does, the thing that happened to the two of us happens - me, not realising how convoluted my PR will appear to a reviewer, had black configured to run on-file-save, so whenever I hit that CTRL+S shortcut, the python file gets formatted for me. This produces a lot of "file changed" messages on github, all of them just cosmetic.
I swear I am not being payed for advertising black :stuck_out_tongue:
I should not have interfered with good code, which does not concern the issue, just for cosmetics sake. I apologise.

Merged. Regarding your recommendation for using black, I will also give it consideration. Thanks for letting me know about this formatting tool. 😊


Add missing new modals

Fixes #4683

@xavijam please code review
@josecruz @saleiva please review visuals/copy

Not much to say about code :es:, about the style, i feel the description is the last two dialogs are too long.

Yeah, could be, but they're the same texts as on the old ones :sob:
Any suggestions for more brief texts that still convey the same info?

Or at least, make those elements shorter.

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

@saleiva Would this one need a bit of love?

Create an issue, but don't block this because of that. Too minor

So that's a "good to go"?

Yup for me:+1:

retest this please

Frontend tests were OK :+1: (details)


Need help troubleshooting board

I built 3 units using the "ratgdo open source D1 Mini_schem_v6.png" schematic.
I loaded them up with the a esphome yaml, and installed them.
Door 1 and 3 work as expected. Door 2 is RX only. I started digging into it, and saw there was a yaml for 2.5i. I also saw where I had built the firmware files for a d1 lite, but I actually used a d1 mini 4.0.0 usb-c. I have not modified or touched Door 1 & 3 in anyway.
On Door 2:

I dropped an OTA firmware on it, and then pushed a full 2.5i firmware on it.
Factory reset the GDO. (Hold yellow button down 3 times)
Built a node red flow to cycle the light trying to find a rolling code that would work.
Reseated the cables.

I'm reading all i can about the issue, but it seems there isn't a definitive troubleshooting guide.
Can I assume that since I can get door state, motor status, and light status, that my wiring is okay?
What might make it so that I can receive states and not send commands?
If this is likely a rolling code issue, is there way to just start over at 1 and see if they will sync?
I can post my yaml if it might be helpful.

Thanks for the explanation. I fiddled with the board I made and eventually lost RX.
I built an entire new board (still with the 2 2n7000s) and as of right now, its working.


error in Flutter 3.7.7  file windows/runner/win32_window.cpp

windows/runner/win32_window.cpp ?????
after splite the function CreateAndShow() to Create() + Show()
The app no longer works on Windows most time
->
the app create process but not show window
After closing and opening app several times several times
In older versions it was more stable
im test add this code but exist peoblem
// add this function above CreateAndShow
bool CheckOneInstance()
{
HANDLE  m_hStartEvent = CreateEventW( NULL, FALSE, FALSE, L"Global\yourpackage" );
if(m_hStartEvent == NULL)
{
CloseHandle( m_hStartEvent );
return false;
}
if (GetLastError() == ERROR_ALREADY_EXISTS) {
CloseHandle( m_hStartEvent );
m_hStartEvent = NULL;
// already exist
// send message from here to existing copy of the application
return false;
}
// the only instance, start in a usual way
return true;
}
bool Win32Window::Create(const std::wstring& title,
const Point& origin,
const Size& size) {
//Add the check
if( !CheckOneInstance()){
return false;
}
Destroy();
.......

@amr-lounis thank you for submitting this issue, I can confirm the same thing is happening for me, any work around this issue?

@amr-lounis It seems you have modified the Windows platform source code.
Could you confirm the issue only happens after this modification? If so, please point out the changes and the completed and minimal reproducible code sample so that we may verify this. And you should take a look at the console and check if there is any exception/stack trace if any.
Also, please provide the output of flutter doctor -v as well. Thanks!

Hi @huycozy, I can confirm this issue to reproduce:
1- Since this issue occurred on Windows 10 try be on the same system.
2- Start new flutter app and make sure to use routing (I tried routing with go_router, beamer ,and Getx all same issue), the fastest way is to use get_cli the bootstrapped app has the issue.
3- make sure to run it on release mode as the debug mode doesn't have this issue.
flutter doctor -v command output
$ flutter doctor -v
[√] Flutter (Channel stable, 3.7.7, on Microsoft Windows [Version 10.0.19044.1288], locale en-US)
    • Flutter version 3.7.7 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ad6cd72c0 (6 days ago), 2023-03-08 09:41:59 -0800
    • Engine revision 1837b5be5f
    • Dart version 2.19.4
    • DevTools version 2.20.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at C:\Users\Coder\AppData\Local\Android\sdk
    • Platform android-33-ext4, build-tools 33.0.1
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.11.23)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.11.33214.272
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)

[√] VS Code (version 1.76.1)
    • VS Code at C:\Users\Coder\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.60.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19044.1288]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 110.0.5481.180
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 110.0.1587.69

[√] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

@oSethoum I checked this with go_router example but didn't see this issue. Can you please share a completed and minimal reproducible code sample so that we may verify this? (It's recommended you use go_router as it's Flutter 1st package which is in the Flutter's package system). Thank you!

I meet the same problem, in release mode flutter_controller_->engine()->SetNextFrameCallback([&]() {         this->Show();     });
show() will not be callback, and i add code this-> Show() after the code window can be show;

temporary solution
Run the application from the console
I think the problem is in the threads, where collisions occur sometimes
The problem does not appear when the spacing between periods of operation and when running the application from the console

@amr-lounis In order to address the issue properly, please provide a sample code so that we may verify this. Thanks!

example :
using console or power shell
..\app\build\windows\runner\Release> .\app.exe
It works after many attempts without problems
if running using Explorer after the open close  open close open close open many times
the process create without window  in Task manager

@amr-lounis I tried above steps on a default Flutter project but can't see the issue.
Have you modified win32_window.cpp file? Can you share the file content?


438| Find All Anagrams in a String| C++

Find All Anagrams in a String -
What will change -
Adding a solution to the problem : Find All Anagrams in a String
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Hi, can you assign me this issue?


feat: addition of the new dedicated command to select ocm cluster

This is still not completed but what is still needed is listed via TODOs in the code.
I'm just looking to see reviews on what I've done thus far
Verification Steps

An OCM cluster is needed to verify this so I'll need to hop on to verify with the reviewer

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation change
[ ] Other (please specify)

Thanks for the progress made on this @dimakis @rkpattnaik780
I am happy to sync if anything will be needed from API side.

@dimakis can we close this


Regression

Fixes regression issues found in https://github.com/dendrodocs/dotnet-tool/pull/22
Type of change

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

More unit tests

Checklist:

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

36 of 39 (92.31%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.4%) to 97.604%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/DendroDocs.Shared/Descriptions/DocumentationCommentsDescription.cs
36
39
92.31%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.4%

Covered Lines:
561

Relevant Lines:
569

💛  - Coveralls


Objective C/C++ support

I'm not sure if this is in a shape where you'll accept it as-is. Honestly I'm hoping there's actually a much better way to do this - but the Objective-C/C++ rules don't seem to provide an equivalent to target.cc.compile_flags. It's further complicated by the fact that the only thing that knows the Xcode SDKROOT is XcodeLocalEnvProvider, and I could not find a way to access the environment it sets.

Sorry for the delay in my response.
I have pushed an update to run the latest buildifier on the files, and also made the tests pass on bazel 0.22.0. Can you please rebase your branch?
I think your changes are fine. Can you refactor such that the logic for cc_ and objc_ rules are in two separate functions? Just for readability.
After you are done, I may push a commit to your branch before merging, for minor formatting nits.
Thank you for your contribution.

Will do - may take me a few days.

@siddharthab more than the few days I promised, but I've rebased and factored out the handling of cc_ and objc_ rules into separate functions.

Thank you! The code looks clean now.
I could not do a thorough review of the ObjC portion because I have never worked with it. I trust that you have tested these changes. Ideally, a unit test would be nice but I am happy to add the unit test as a separate merge.


Add option to create Dataverse in a Collection from scratch

Create a new record from scratch (Create a Dataset in a Dataverse Collection)

[ ] Add functionality to create the empty Dataverse record
[ ] Add a check to not create a second empty Dataverse record for the same repository (some for of check)


Gem includes 13MB test log

I was looking at my rails app's disk usage today and noticed that my vendored version of devise 2.0.0 was using over 13 megabytes of disk space!
Digging in, I discovered:
test/rails_app/log/test.log

is the culprit.
Doing a fresh gem install into an empty gemset confirmed it.
This file doesn't appear in the git repo, so it's probably getting generated as part of the gem build process prior to hosting on rubygems.org.

Woah, this is lame. Thanks for reporting.

You're welcome.  Thanks for being up at 2am to check it out :)
On 2/9/12 2:03 AM, José Valim wrote:

Woah, this is lame. Thanks for reporting.

Reply to this email directly or view it on GitHub:
https://github.com/plataformatec/devise/issues/1632#issuecomment-3884851

New gem released.


Feature Request: expose renderers for wilder-nvim plugin

          It would be nice to expose the renderer option via nixvim...

Originally posted by @s1341 in https://github.com/nix-community/nixvim/issues/466#issuecomment-1621061994

I addressed that in #639.
My solution is basic but at least quite flexible.
The user can insert any lua code to define the renderer.