question about flash_attn_varlen_func

Hi, lately I am confused about flash_attn_varlen_func
if have attention mask below
attention_mask = torch.tensor(
    [
        [1,1,1,0,0],
        [1,1,0,0,0],
        [1,1,1,1,1],
    ],device='cuda:0'
)

according to llama model,
indices=[ 0,  1,  2,  5,  6, 10, 11, 12, 13, 14]
cu_seqlens=[ 0,  3,  5, 10] #which will be cu_seqlens_q pass to flash_attn_varlen_func
max_seqlen_in_batch=5

my implementation of attention mask is a little different
attention_mask = torch.tensor(
    [
        [0,2,3,torch.nan,torch.nan],
        [0,2,torch.nan,torch.nan,torch.nan],
        [0,5,torch.nan,torch.nan,torch.nan],
    ],device='cuda:0'
)

it means that if I have 2 sample(a,b) in batch 1,  2 tokens for a, 1 token for b.  And I do not want b noticeawhen calculate attention
so I write my packing_attention_unpad below
def packing_attention_unpad(attention_mask:torch.Tensor):
        cu_seqlens_k = attention_mask.clone()
        for i in range(1,cu_seqlens_k.size(0)):
            cu_seqlens_k[i,:] += max(cu_seqlens_k[i-1])
        cu_seqlens_k = cu_seqlens_k[...,1:]
        cu_seqlens_k = cu_seqlens_k[torch.where(~torch.isnan(cu_seqlens_k))].to(dtype=torch.int32)
        cu_seqlens_k = torch.nn.functional.pad(cu_seqlens_k,(1,0))

        tmp = attention_mask[~torch.isnan(attention_mask)].flatten()
        max_seqlen_in_batch_k = 0
        for i in range(1,tmp.size(0)):
            max_seqlen_in_batch_k = max(max_seqlen_in_batch_k ,tmp[i]-tmp[i-1])

        indices_k = []
        seq_length = attention_mask.size(1)
        for i in range(attention_mask.size(0)):
            max_num = max(attention_mask[i,...])
            indices_k.extend([j + i*seq_length for j in range(int(max_num.item()))])
        indices_k = torch.tensor(indices_k, dtype=torch.int64,device=attention_mask.device)

        return indices_k, cu_seqlens_k, max_seqlen_in_batch_k

result:
indices=[ 0,  1,  2,  5,  6, 10, 11, 12, 13, 14]
cu_seqlens=[ 0, 2, 3,  5, 10] #which will be cu_seqlens_q pass to flash_attn_varlen_func
max_seqlen_in_batch=5

am I doing right? I test it with llama, seems when batch_size=1 ,model works fine, but when batch_size>1, nan loss and non logits start coming at step 2..... why does that happen ?
according to cu_seqlens_q , cu_seqlens_q should have shape(batch_size+1,) my cu_seqlens have shape (batch_size+2,)  , it did not give me error,  so how it works?

Thanks in advance.

If this is the attn mask (3 queries and 5 keys):
attention_mask = torch.tensor(
    [
        [1,1,1,0,0],
        [1,1,0,0,0],
        [1,1,1,1,1],
    ],device='cuda:0'
)

Then it's not supported by FlashAttention.

@tridao thanks, solved.


Switch the oci.Runtime structure to a Go interface

Following the high level issue #1945, and now that #1946 has been merged, we need to define the Runtime as an interface so that we can define the current runtime implementation as v1. This will allow for new implementations (particularly v2) in the future, without breaking the core of CRI-O.

:+1: this is indeed the first step towards supporting multiple runtimes, thanks!


Add Best Practices Document

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

[X] You have updated the .github/CODEOWNERS file according to your changes.
[X] You have registered new documents to /sidebars.js if any.

I wonder if we could unify this with https://internetcomputer.org/docs/current/developer-docs/security/general-security-best-practices ?

Thanks a lot @jennifertrin for working on best practices, I think that's very valuable!
I'm a bit hesitant about changing the general security best practices docs/developer-docs/security/general-security-best-practices.md to become "General best practices" and removing the security focus: I wrote these best practices with a strong focus on security and now it feels like the document is "weakened" a bit by making the scope very broad and less focused. With this I fear that the security best practices become somewhat hidden and might be missed among some other general best practices. Would it be an option to do one of the following?

It looks to me like the best practices you add also have security aspects. So I'm open if you want to embed those into the security best practices, but keep the focus on security on the existing page (title, overview, etc.) as it was so far. In that case I'd suggest putting those at the bottom of the page and stick to the existing structure "Security Concern" - "Recommendation".
Another option could be to split our best practices into "Security" and "Developer", i.e. have a separate document for the developer best practices. An advantage of this could be, in case those grow more, that security wouldn't be code owner and someone else could own and approve them more flexibly.

Let me know what you think. Also happy to discuss 1:1 if that helps.

Hello Robin, I'm leaning towards the second option. I'll revert to Option 2 (which was the original). Thank you for the feedback!


Implemented voting using django-vote

The rating was implemented using the package django-vote.
django-vote was used since it's an easy to use package which satisfies all the requirements of this issue.
Comments and posts can be liked and disliked.
Resolves #15
Screenshot to show the implementation:

I added the screenshot to the pull request as requested. I also cleaned the code a little in the second commit.


bundle 'Add' type:wysiwyg -> error

Getting this error when trying to 'Add' a new set using bundles:
functions.js:251 Uncaught TypeError: Cannot read property 'replace' of undefinedfunctions.js:251 (anonymous function)load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,plupload,json2&ver=3.9.1:2 n.extend.eachload-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,plupload,json2&ver=3.9.1:2 n.fn.n.eachfunctions.js:195 (anonymous function)load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,plupload,json2&ver=3.9.1:3 n.event.dispatchload-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,plupload,json2&ver=3.9.1:3 n.event.add.r.handle
new_item.find('tr').each(function() {
Uncaught TypeError: Cannot read property 'replace' of undefined
tinyMCEPreInit.mceInit[new_id].elements = tinyMCEPreInit.mceInit[new_id].elements.replace( last_id_regexp, new_id );

That is the problem with wysiwyg. We create new element with some hacks because WP doesn't have a API for that. What version of WP you are using? We need to know that because there are fundamental changes across a versions.

Error is fixed in v3


Edit korean translation

Changed awkward expression and edit non grammatical syntax which was made by computer translation bot.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: CXZ7720 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


react-scripts: fix leftover issue from #106; bump @babel/core to fix visitor issue

react-scripts:
Fix #106 left a case where copyPluginPatterns was an empty array, which is an invalid value for the CopyPlugin's patterns option in webpack configuration.
Fix an issue where babel would report You gave us a visitor for the node type ClassAccessorProperty but it's not a valid type when encountering a class accessor (contained in @itwin/browser-authentication in this case). See: https://github.com/babel/babel/issues/15765 for similar reports.

Could you bump the patch version manually?

Yes, forgot when I learned I needed to fork.

@aruniverse that's done. I assume the builds are a bit flaky? I see past PRs merged with a few failing checks.


ObservableAsPropertyHelper not on dispatcher by default

The documentation of ObservableAsPropertyHelper (file ReactiveUI/ObservableAsPropertyHelper.cs) mentions the following regarding the scheduler parameter:
The scheduler that the notifications will be provided on - this should normally be a
Dispatcher-based scheduler (and is by default)
However, in the constructor code you have
scheduler = scheduler ?? CurrentThreadScheduler.Instance;
which is not the the main thread scheduler. Therefore, the ToProperty() method is not guarantueed to be executed on the dispatcher.
Is the documenation misleading or wrong or the behaviour of ObservableAsPropertyHelper to be changed?
I checked the source code of 6.5.0 and the 7 master branch. It's in both sources the same.

@dhintermann can I ask why you closed? If what you're saying is true, I would agree that either the code or docs need to be changed.

@kentcb I thought it's a bit an insignificant issue compared to the rest in the open issue list, but I think you're right, it would be worth fixing. I reopen this.


Clean-up a warning on the Node code for Hello World quickstart.

Description
Clean-up a warning since express is defined to be greater than v4.16.0 on the package.json definition.
Issue reference
No reference issue. This is a minor tidy up of the example source code.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] The quickstart code compiles correctly
[x] You've tested new builds of the quickstart if you changed quickstart code
[ ] You've updated the quickstart's README if necessary

Could you please merge from the master branch? It looks like I don't have permission to update your branch to the latest master.

Hello @wcs1only, I updated per your instructions.  Let me know if you need other changes.
Thanks


UnknownEntityReference for HTML entities

Great work! Thank you for building this.
I am trying to parse XML that contains HTML entities like ′, but I am getting:
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: UnknownEntityReference("prime", TextPos { row: 450, col: 3724 })', src/libcore/result.rs:997:5

Is there any way in particule you'd recommend I handle this?

XML that contains HTML entities like ′

It's not a valid XML.
Here is lxml output:
<e>&prime</e>

Yeah, I thought that could be the issue. Is there any way to hook into your crate to say "if there's this error then just treat it like a string"?

No. You should fix you XML. If you can modify it, than just add this to the top:
<!DOCTYPE name [
    <!ENTITY prime '′'>
]>

We can't ignore invalid entities, because it may lead to other errors.

Okay, thank you!


Listings page draft

Simple mockup UI of all listings page, implement basic page structure,
make

card component to display each listing
layout all the cards nicely,
Stretch feature: try implementing scrolling with mock data

done


Update feature availability for dns-pod-service

Removed the outdated availability section and add feature state
shortcode.
This is for issue #28059

Page preview:
https://deploy-preview-28131--kubernetes-io-master-staging.netlify.app/docs/concepts/services-networking/dns-pod-service/
/kind cleanup

Thanks @chenxuc .
/lgtm
/approve


Add JUnit Format output option

Hi,
Wondering if would be possible to have an option to output the results into a JUnit format so it can be used with CI systems like Jenkins?
Thanks.

Unfortunately not. This linter is deprecated and we won’t add new features.


Ported to 1.11

Very simple port to 1.11. Only had to fix mappings and accepted Minecraft versions. (Should work on any future 1.11 versions)
Bumped mod version, so it should be ready to be build right away :)

Thanks! I'll hopefully have a chance to build it today or tomorrow, then upload to Curse. Really appreciate you taking the time to keep this mod up to date!

@samvbeckmann any update on this ? :)

Sorry it took so long.


how do we get luma 2.0?

 I would like to know how to get luma 2.0 because everywere i look it says to use luma but then i get on here and it says i need 2.0 but i dont understand how to get it when it says that the lastest version is what 1.4.2?... It would be great if someone could help, thanks. ( :

It's recommended you update to boot9strap. If you follow the guide, you'll be prompted to download and install my fork of Luma Updater, which is v2.0+.


Enable snapshot ensemble

Description
Checklist

[ ] Added link to Github issue or Trello card
[ ] Added tests

I am closing this for now and will reopen when I will get back to it.


DROOLS-6477: Collections Data Objects can be filled with expressions only.

This is a BACKPORT of https://github.com/kiegroup/drools-wb/pull/1503, required to keep scesim repos syncrhonized.
The changes involves RULE test scenario only.

@danielzhe Could you please take a look at this PR? :)


Update pipeline & add features & update deps

/cc @TomSmith27 what do you think of this PR?

Yep that all looks good to me


EnvironmentCredential with ClientSecretCredential support

Closes #79

@RickWinter Thank you for the approval. As I said, if we come to another conclusion regarding const, I will create another PR to update this place and some others.


Delete duplicates

The description seems to be duplicated.

@yoichinak : Thanks for your contribution to the Azure documentation! The author, @edmacauley, has been notified to review your proposed change.

Hi @yoichinak great catch, thank you for the edit.  #sign-off


add footer-nav

Please makes sure these boxes are checked before submitting your PR, thank you!

[ ] Make sure you follow Element's Contributing Guide.
[ ] Rebase before creating a PR to keep commit history clear.
[ ] Add some descriptions and refer relative issues for you PR.

@baiyaaaaa @QingWei-Li @csvwolf

lgtm

lgtm


🐛 [OFFICIAL] Generated Issue: ConnectionTimeoutException

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
The API has returned an error:
MongoDB\Driver\Exception\ConnectionTimeoutException
Status code: 13053
Message: No suitable servers found (`serverSelectionTryOnce` set): [socket timeout calling hello on '<IP_ADDRESS>:27017']
Trace: /var/www/jikan-rest/vendor/mongodb/mongodb/src/functions.php on line 487
Expected Behavior
The API should have returned a successful response with data.
Steps To Reproduce
Http Request: `GET /v4/top/anime
Environment
OS: Windows
Browser: Google Chrome

Anything else?
No response

Resolved, thanks for reporting. Please re-open the ticket if it occurs again.


Newsletter 45: April 2023

Newsletter 45: April 2023
tags: newsletter
Editors: @ozkriff, @AngelOnFira, @scirin
Another month has gone by, so it's time to put together the Rust Gamedev newsletter with April's news!
Current Schedule
The soft deadline for all section PRs is 2023.05.07.
We may still accept PRs that are submitted later than this, as long as they're ready before the newsletter's release, but this isn't guaranteed. If you want your section to be included, don't leave it till the last minute!
How to Contribute
If you want to help writing the newsletter:

Read CONTRIBUTING.md.
Choose one or more of the "🆓 free" sections listed below, and leave a comment letting us know you want to work on them.

The links in brackets (like "1, 2, 3") are suggestions of links to include in the section. Feel free to add more!
The username listed next to the section (like "@ozkriff?") is a suggestion of who may want to pick up the work (usually the project's developer, or someone who has expressed interest in the past).
You are not obligated to write a section if you're tagged or your project is listed! You're welcome to ask someone else to write the section, or to ask for your project to be excluded from this month's post.
Extra sections not listed in the plan are welcomed - just leave a comment and open a PR!

Write a short overview in the newsletter's Markdown file, making sure to follow the style guidelines (see below).
Send a PR to the source branch (example: #336).
Mention this issue in your PR's description to link it all together.

Style Guidelines
The full style guide is in CONTRIBUTING.md, but here are the most important rules:

Write in third-person perspective.
Each line must be 80 characters or less, for ease of reviewing/diffing.
Only one image per section is allowed.

The maximum size is 300kb for static images and 2.5mb for GIFs.
The image should come before the text, and must have alt text for accessibility.
Prefer static images to GIFs, to keep the page load times down.

Each section should be under 1000 characters, and under 6 paragraphs.

This only applies to the rendered text, not the markup.

Keep formatting minimal - no bold/italics/etc.
Avoid long/nested bullet point lists - no changelogs!

Please use these templates as a starting point:
Games/apps/libraries:
### [Game name]

![alt text](img)
_optional image label_

[Game name] ([GitHub], [Discord], [Twitter]) by [@nickname]
is... {short project description in one sentence}.

{An overview of the recent updates with links to more details}.

_Discussions: [/r/rust_gamedev](link), [Twitter](link), [etc](link)_

[Game name]: http://example.com

Articles/blog posts/videos/etc:
### [Article name]

![alt text](img)
_optional image label_

[@nickname] published an [article] about...
{overview what the resource is about}.

_Discussions: [/r/rust_gamedev](link), [Twiter](link), [etc](link)_

[Article name]: http://example.com

Current Structure & Status
Below is our current planned structure for the newsletter, and the status of each PR (which we'll try to keep updated).
This is not an exhaustive list - if you have your own project that you want to write about, just make a comment on this issue and open a PR!

Rust Gamedev Meetup

[ ] Monthly Meetup - 🚧 WIP by @AngelOnFira
[ ] Bevy Jam 3 Results (1, 2) - 🆓 free (@cart @alice-i-cecile?)

Game Updates

[x] CyberGate - ✔ done by @cybersoulK
[ ] Veloren - 🚧 WIP by @AngelOnFira
[ ] Combine And Conquer (1) - 🆓 free (@I3ck?)
[ ] Logic RPG (1, 2) - 🆓 free (@mwbryant?)
[ ] Digital Extinction (1, 2) - 🆓 free (@Indy2222?)
[ ] Stellar Cortex (1) - 🆓 free (@atbentley?)
[ ] Hydrofoil Generation (1, 2) - 🆓 free (@kunos?)
[ ] Blox Stockholm (1, 2) - 🆓 free (@Elttob?)
[ ] Idu (1, 2, 3) - 🆓 free (@johann2?)
[ ] Tiny Glade (1, 1, 2) - 🆓 free (@anopara @h3r2tic?)
[ ] exocave (1) - 🆓 free (@bcarruthers?)
[ ] maginet (1) - 🆓 free (@evrimoztamur?)
[ ] Railroad Scheduler (1) - 🆓 free
[ ] l1t (1) - 🆓 free (@alex-laycalvert?)
[x] Jumpy (1) - ✔ done by @zicklag
[x] Thetawave - ✔ done by @cdsupina
[x] Way of Rhea - ✔ done by @MasonRemaley

Learning Material Updates

[x] Bevy <3 GA - ✔ done by @Leinnan
[ ] PhaestusFox’s Bevy videos (1) - 🆓 free (@PhaestusFox?)
[x] Exploring Bevy GoL shader (1, 2, 3) - ✔ done by @lecoqjacob
[x] Bevy roguelike tutorial (1, 2) - ✔ done by @maciekglowka
[ ] Katamari for the BevyJam3 (1) - 🆓 free (@whoisryosuke?)
[ ] 3D MIDI Piano Using Bevy (1) - 🆓 free (@whoisryosuke?)
[x] TDD in Rust GameDev w. Bevy (1) - ✔ done by @donedgardo
[ ] Building scripting solution w. Intuicio (1) - 🆓 free (@psichix?)
[ ] DOOM maps to SVG to laser cutter (1) - 🆓 free (@theor?)
[ ] Making A Strategy Game (1) - 🆓 free (@srodrigo?)
[ ] rs-football-3d (1, 2) - 🆓 free (@UnravelSports?)
[ ] rust-flappy-bird-ai (1, 2) - 🆓 free (@bones-ai?)

Engine Updates

[x] godot-rs (1) - ✔ done by @Bromeon
[ ] alkahest-rs (1 - 🆓 free (@AnthonyUtt?)
[ ] Strolle (1) - 🆓 free (@Patryk27?)
[ ] ggez (1) - 🆓 free (@PSteinhaus?)
[x] ambient - ✔ done by @philpax

Tooling Updates

[x] rustracer (1) - ✔ done by @KaminariOS
[ ] Graphite - 🆓 free (@Keavon?)
[ ] Image Maniac (1) - 🆓 free (@AllenDang?)
[ ] IronBoy (1) - 🆓 free (@nicolas-siplis?)
[x] Luminol (1) - ✔ done by @Speak2Erase

Library Updates

[ ] faer (1, 2) - 🆓 free (@sarah-ek?)
[ ] kayak_ui (1, 2) - 🆓 free (@StarArawn?)
[x] backpack (1) - ✔ done by @Vrixyz
[ ] virtual_joystick (1) - 🆓 free (@SergioRibera?)
[ ] png (1) - 🆓 free (@Shnatsel?)
[ ] blend (1) - 🆓 free (@lukebitts?)
[ ] bitcode (1) - 🆓 free
[ ] wgpu (1) - 🆓 free (@cwfitzgerald?)
[ ] lox (1) - 🆓 free (@LukasKalbertodt?)
[ ] egui_graphs (1) - 🆓 free (@blitzarx1?)

Other News

[ ] Bullet points of any interesting news that doesn't have its own section - by @ozkriff

Discussions

[ ] "Well, we're a little more game" (1)
[ ] "Really frustrated" (1)

Jobs
Publishing Steps

[ ] Final review - by everyone
[ ] Publish - by @ozkriff
[ ] Post on /r/rust, /r/rust_gamedev, /r/gamedev, URLO, twitter.com/rust_gamedev - by @ozkriff
[ ] Pin thread on Twitter - by @ozkriff
[ ] Add comment links - by @ozkriff
[ ] Add a draft of next month's newsletter - by @ozkriff

Can I add Luminol?

@Speak2Erase sure! added to the plan

We (Ambient) are planning on releasing our next update in the next two days - would we be able to sneak that into the April update, or would we have to wait for next month?

FWIW most of the hard work on png has been done by @fintelia, I'm mostly just the messenger, with comparatively minor contributions (added roundtrip fuzzing and did lots of testing).

I could do godot-rust 🙂

Hey there good folks of the Rust GD! I'm Maginet's developer indeed and the game is actually open source over at https://github.com/evrimoztamur/maginet if anybody wants to check the setup out. Currently working on release updates and an Electron deployable (for Steam/desktop) over at https://github.com/evrimoztamur/maginet-deploy.

Back in April, I wrote a small article about using Github Actions to publish games written in bevy on Github Pages. Does it fit into Learning Material Updates?  Link to article: http://mevlyshkin.com/blog/bevy-github-actions

I have some updates for Thetawave. Could I write a section on it?

I'm not sure why I'm assigned to rustracer, but since the author is @KaminariOS, it seems more natural for him to be assigned instead.

I can do that.

Thanks for including Image Maniac

I'm taking Intuicio tutorial :3

Thanks for including my tutorial (Bevy roguelike) - I am gonna take it.

I'm taking Jumpy

Thanks for including my attempt at visualizing 3D football data! If you're interested, you can include my PySport talk I gave about the subject too (https://www.youtube.com/watch?v=VwatoPOKIl8).
Also, yes my twitter handle is correct the way you have it, so you can remove the questionmark :)

IronBoy dev here, happy to take it!

Thanks for the ping on Stellar Cortex, I didn't quite have time to get around to this but am looking forward to contributing something for later editions

Same, thanks for pinging - I don't have enough time now to prepare anything, but I'll try to scramble some next time 🙂

Also thanks for the ping, I missed this - have been busy myself. I'm happy to help out next time though :)

Thanks for ping,
I'll be sure to keep an eye out for the next newsletter

Hi! Sorry, I'm a bit late to the party. Is there a chance we could include my article (and another two followups I published this month) on the next newsletter?

same ! thank you for the ping

I'll finally have time to carve out of my schedule to finish the Graphite entry when I wake up in ~8h. I'll get that done first thing in the morning.

Hey 👋 I see help wanted, is there anything I can do to help?

Hi, that one is from April, right? I would add a little PR with some *quad updates, but I guess for the next issue, for May, right?

(this can be closed)


Add support for PKCS12 truststores

This adds support for PKCS12 truststores, which together with https://github.com/cert-manager/trust-manager/pull/122 closes https://github.com/cert-manager/trust-manager/issues/17. A million thanks to @aidy for https://github.com/cert-manager/trust-manager/pull/122 - this PR contains copy-modified tests from https://github.com/cert-manager/trust-manager/pull/122. 🎉
I am suggesting password-less PKCS truststores as the default (currently hard-coded), as this is the new default truststore format from Java 18, ref. https://bugs.openjdk.org/browse/JDK-8275252.
IMO we should review the API around target ConfigMap keys. The code, and especially the tests are becoming complex and somehow redundant. E.g. we could use API mechanisms more to validate unique keys in the target configmap.

/ok-to-test

/retest


gitlab-runner: 17.2.0 -> 17.5.3

Changelog:
https://gitlab.com/gitlab-org/gitlab-runner/blob/v17.5.3/CHANGELOG.md
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356040

aarch64-darwin

:x: 1 package failed to build:

gitlab-runner

Mentioning https://github.com/NixOS/nixpkgs/pull/349268. A newer version has been released, some of the dependencies in 17.2.0 contain known vulnerabilities.
cc @zimbatm @globin @krav @talyz @yayayayaka

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356040
aarch64-darwin
❌ 1 package failed to build:

Not sure why nixpkgs-review is failing to build when nix-build directly on the package.nix worked as expected. Investigating now

Thank you for your contribution!
In #359329 we update to 17.6.1, then we can also continue here. Can you please update this PR to 17.6.0 and then we should be able to merge this then :)

17.6.0 or 17.6.1?

AFAIK there is no gitlab-runner 17.6.1 release, so 17.6.0 should be fine.

Updated to version 17.6.0

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356040

x86_64-linux

:white_check_mark: 1 package built:

gitlab-runner

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356040

aarch64-darwin

:x: 1 package failed to build:

gitlab-runner

@bkp5190 : Some strange test fails:
       >              Error Trace:    /build/source/helpers/homedir/homedir_test.go:44
       >                                                       /build/source/helpers/homedir/homedir_test.go:82
       >               Error:          Target error should be in err chain:
       >                                   expected: "homedir variable is not set"
       >                                in chain:
       >              Test:           TestFix/HOME_variable_is_not_set_and_homedir_value_is_empty
       > FAIL
       > FAIL gitlab.com/gitlab-org/gitlab-runner/helpers/homedir     0.005s
       > FAIL
       For full logs, run 'nix-store -l /nix/store/yg45yixbwa94mql6n0jxvvyrgzk9n13d-gitlab-runner-17.6.0.drv'.

on linux x86... do these passthru test work on your machine?

@bkp5190 : Some strange test fails:

       >              Error Trace:    /build/source/helpers/homedir/homedir_test.go:44

       >                                                       /build/source/helpers/homedir/homedir_test.go:82

       >               Error:          Target error should be in err chain:

       >                                   expected: "homedir variable is not set"

       >                                in chain:

       >              Test:           TestFix/HOME_variable_is_not_set_and_homedir_value_is_empty

       > FAIL

       > FAIL gitlab.com/gitlab-org/gitlab-runner/helpers/homedir     0.005s

       > FAIL

       For full logs, run 'nix-store -l /nix/store/yg45yixbwa94mql6n0jxvvyrgzk9n13d-gitlab-runner-17.6.0.drv'.

on linux x86... do these passthru test work on your machine?

Yes they do, the other run is attached from linux x86


chore: remove the characters limit for features

Remove the limit in the Standard to allow each presentation level (ie. websites / catalogs / search engines) decide if and how to truncate them.
Fix #58.

Thanks for your contribution :pray:
This is now marked as a minor-change proposal to the standard,
this means that old versions of publiccode.yml will still be valid with this change.
Example of minor changes are additions of new keys or making keys optional.
The Chair will eventually pick up this proposal and start the voting procedure using @yaml-9000 vote-start
cc @ruphy @publiccodeyml/steering-committee

:page_facing_up: Voting procedure | :page_facing_up: Working Group Charter | :robot: bot commands

@yaml-9000 vote-start

Voting is now open on this proposal!
If you are a member of the Steering Committee you can now vote!
The polls will stay open for 14 days, until Wed, 27 Apr 2022 13:05:23 GMT.
At the end of that period the Chair (@ruphy) will mark the voting period as over using @yaml-9000 vote-end
Leave a :+1: (thumbs up) on this comment to accept the proposal or a :-1: (thumbs down) to reject it.
cc @publiccodeyml/steering-committee

:page_facing_up: Voting procedure | :page_facing_up: Working Group Charter | :robot: bot commands

@yaml-9000 vote-end


Remove a specific field on new suggest strategy

I am currently implementing the newest version of the SBA for a customer, and I am having troubles with the new strategy for the autocomplete.
When using the autocomplete, if no suggestions are returned, a new suggestion query is sent using only the last word.
This works fine, but it then returns suggestions for the last word in all fields of my suggestions service, including the Title field.
The Title field is not really a good fit for this kind of autocompletion, and I would like to remove it from my suggestion results, but I couldn't find a way to do that.
I have tried the following changes in the get(suggestQuery: string | undefined, text: string, fields?: string | string[], query?: Query, maxCount = 10) of the suggestions.service.ts but none of them worked.
Add a filter() on the suggests results
else {
  // Fall back to a strategy of autocompleting only the last token
  const i = text.lastIndexOf(" ")+1;
  if(i > 0) {
    const prefix = text.substring(0, i);
    return this.suggestQueryWebService.get(sugQuery, text.substring(i), ccquery).pipe(
      tap(suggests => suggests?.filter(suggest => suggest.category.toLowerCase() !== "title").forEach(s => s.display = prefix + s.display))
    );
  }
}

Add the kinds parameter when fetching the suggestions
else {
  // Fall back to a strategy of autocompleting only the last token
  const i = text.lastIndexOf(" ")+1;
  if(i > 0) {
    const prefix = text.substring(0, i);
    return this.suggestQueryWebService.get(sugQuery, text.substring(i), ccquery, "concepts").pipe(
      tap(suggests => suggests?.forEach(s => s.display = prefix + s.display))
    );
  }
}

Hi Guillaume,
Not sure why the second approach doesn't work, but for the first approach, you can replace tap() with a map()  (and the forEach() also needs to be replaced):
return this.suggestQueryWebService.get(sugQuery, text.substring(i), ccquery).pipe(
      map(suggests => suggests?.filter(suggest => suggest.category.toLowerCase() !== "title").map(s => ({...s, display: prefix + s.display})))
    );

Hi Eric,
map() instead of tap() did the trick. Thank you.
Not sure why the second approach doesn't work either though.
I did set the kinds in my Suggestion Lexicon and I do see the kinds parameter being sent correctly as a parameter in the network tab.


Author/gravatar inconsistancy

Drone will report the opening of a pull request by putting the pull request author's github alias in the author field.  When drone reports the MERGING of a pull request, or generally just any direct commit to master, it puts the committer's email address in the author field, rather than their github alias.
When the email address is used for the author field, the gravatar hash will indeed point to the gravatar for that email address.  When the github alias is used for the author field, a different gravatar hash will appear, one that invariably displays the system default gravatar.  Presumably this is a gravatar generated from that alias, rather than an email address.
What this means is that a single user opening pull requests and merging others will appear in Drone results as two people, sometimes with their email address and correct gravatar, and other times with their github alias and a system default gravatar.  This is problematic when attempting to track activity in a user-centric fashion.
I'm not sure if this is something that can be changed on the drone side, or if it's a fundamental github issue, but hopefully there's a resolution here that will allow consistent email-address usage for all drone builds, so people can be tracked and gravatars can be relied upon.

closed in 0.4 branch. we now persist the avatar url

Nice!
@scottferg fyi


Migration to Swift 5.0

Expected Behavior
To keep up to date, the project should be migrated to Swift 5.0.
Current Behavior
The project is currently being compiled against Swift 4.0, which is some way behind.
Possible Solution
I've ran the migration from XCode 11.2, there's only one required change which is pretty straight forward.
There is an issue that needs addressing, which may well be the reason this hasn't happened yet. After updating the BitcoinKit dependancy to their latest release (1.1.0) that introduces Swift 5.0 support, not all of the test cases succeed.
The issue comes from a rewrite of the file 'BitcoinPrivate' from Objective-C to Swift, which changes the behaviour of the private key validation. Previously, a 33 byte private key hex would successfully generate a public key. The Swift version validates the byte length is 32 bytes, which for this test case it does not work.
This means the latest 1.1.0 release cannot be used. Either this project continues to use an old version, or a fork of the dependancy is made to fix the issue.
Steps to Reproduce (for bugs)
An isolated test to recreate the issue using BitcoinKit 1.1.0.
func testBitcoinKit() {         let hex = "034151a3ec46b5670a682b0a63394f863587d1bc97483b1b6c70eb58e7f0aed192"         let privateKey = PrivateKey(data: Data(hex: hex)!)         let publicKey = privateKey.publicKey()     }
Your Environment

Version used: [https://github.com/ArkEcosystem/swift-crypto/commit/65fd178839d12f826efc59cd79a27f082de46818](Latest Source)
Environment name and version: XCode 11.2, Swift 5.0
Operating System and version: MacOS Catalina 10.15.1

Thanks for opening this issue! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.
If no reviewer appears after a week, a reminder will be sent out.


ConcurrentModificationException occurs when dispatch message to consumers

Describe the bug
java.util.ConcurrentModificationException: null
	at java.util.ArrayList$SubList.checkForComodification(ArrayList.java:1241) ~[?:1.8.0_265]
	at java.util.ArrayList$SubList.size(ArrayList.java:1050) ~[?:1.8.0_265]
	at org.apache.pulsar.broker.service.Consumer.lambda$sendMessages$0(Consumer.java:267) ~[org.apache.pulsar-pulsar-broker-2.6.0-sn-12.jar:2.6.0-sn-12]
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) [io.netty-netty-common-4.1.48.Final.jar:4.1.48.Final]
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) [io.netty-netty-common-4.1.48.Final.jar:4.1.48.Final]
	at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:387) [io.netty-netty-transport-native-epoll-4.1.48.Final-linux-x86_64.jar:4.1.48.Final]
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) [io.netty-netty-common-4.1.48.Final.jar:4.1.48.Final]
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) [io.netty-netty-common-4.1.48.Final.jar:4.1.48.Final]
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [io.netty-netty-common-4.1.48.Final.jar:4.1.48.Final]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_265]

To Reproduce
It's hard to reproduce.
Expected behavior
Keep the list operation safely.
Additional context
Add any other context about the problem here.

Move this issue to 2.7.0.

move to milestone 2.8.0

Move this to the next release.

Move this to the next release.

@codelipenghui - removing the 2.7.4 label. I'm not sure that we'll do a 2.7.5 release. We'll determine which branches to cherry pick to when this is completed/merged.

Closed as stale. Please create a new issue if it's still relevant to the maintained versions.
The codebase has been changed a lot, and if we cannot reproduce the failure stably, leaving the issue open can starve.


Civil war champions question from nexus

User asked
“Wish there's a Creation Club option/patch of making Civil War champions into their CC armor instead of vanilla armor in this mod. The CC Champions Quest can co-exist with the Civil War, just need the Civil War champions to wear those armors during the conflict.”

Full disclosure I am keeping some people in the loop on the nexus page, and answering questions about the version currently available on nexus, if it is a bug I am sure hasn’t been patched or if someone suggests things I forward it to you
I am sorry if this makes you upset

This is definitely on my TODO list. I like the Imperial Champions but the one with Ebony armor can use a makeover. https://trello.com/c/MjS3CMwk/44-support-for-cc-content


feat: Add cli options for generation

Per our discussion on the fediverse.
I took the parameter descriptions from the gpt4all python docs and copied the structure from the llm-llama-cpp plugin
Does this work? Any other changes that I should make?

Test are failing with NameError: name 'Field' is not defined - I think there's a missing import.

Ty, added the imports from llama-cpp.

Tested out with llm install ./ which worked out. The options seem to be getting passed in.

Tweaking params didn't make the replit model perform well enough to be useful to me sadly :P

With this PR checked out, llm models --options included:
gpt4all: all-MiniLM-L6-v2-f16 - SBert, 43.76MB download, needs 1GB RAM (installed)
  max_tokens: int
    The maximum number of tokens to generate.
  temp: float
    The model temperature. Larger values increase creativity but decrease
    factuality.
  top_k: int
    Randomly sample from the top_k most likely tokens at each generation
    step. Set this to 1 for greedy decoding.
  top_p: float
    Randomly sample at each generation step from the top most likely
    tokens whose probabilities add up to top_p.
  repeat_penalty: float
    Penalize the model for repetition. Higher values result in less
    repetition.
  repeat_last_n: int
    How far in the models generation history to apply the repeat penalty.
  n_batch: int
    Number of prompt tokens processed in parallel. Larger values decrease
    latency but increase resource requirements.
gpt4all: orca-mini-3b-gguf2-q4_0 - Mini Orca (Small), 1.84GB download, needs 4GB RAM (installed)
  max_tokens: int
  temp: float
  top_k: int
  top_p: float
  repeat_penalty: float
  repeat_last_n: int
  n_batch: int
gpt4all: mistral-7b-instruct-v0 - Mistral Instruct, 3.83GB download, needs 8GB RAM (installed)
  max_tokens: int
  temp: float
  top_k: int
  top_p: float
  repeat_penalty: float
  repeat_last_n: int
  n_batch: int

$ llm -m mistral-7b-instruct-v0 'hello' -o max_tokens 2
 Hello!
$ llm -m mistral-7b-instruct-v0 'hello' -o max_tokens 10
 Hello! How can I help you today?

Documentation preview: https://github.com/simonw/llm-gpt4all/blob/624b75bbb3d9736e00c931d4de3eef2de80c5e72/README.md#model-options


Update selective-unit-tests.md

Updated the H1 to include branding which I missed in the previous PR, sorry.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

The only change I can see here it's in the description. I don't think we want to add brand suffix to H1.


Version 1.1.0rc2

Codecov Report

Merging #284 (b76cb73) into main (3030eb4) will not change coverage.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   76.08%   76.08%
=======================================
  Files         154      154
  Lines        8249     8249
  Branches     1324     1324
=======================================
  Hits         6276     6276
  Misses       1783     1783
  Partials      190      190

Impacted Files
Coverage Δ

orchestrator/db/__init__.py
92.00% <ø> (ø)

orchestrator/__init__.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


drivers: can: mcan: sjw not initialized when CAN_FD_MODE is enabled

Describe the bug
The mcan driver does not initialize the timing.sjw variable in CAN_FD_MODE configuration.
This causes undefined behavior and might trigger a assert that checks the valid range of this parameter.
Expected behavior
The synchronization jump width should be initialized with the parameter configured.
Impact
Undefined behavior might lead to synchronization problems.

Fix: #35738


Fix broken build

I made a small change right before merging #527 to better support the work that #523 will need to rebase on top of, but I rushed it and didn't wait for tests to pass. This fixes the build on master.

I will not merge without waiting for tests to pass
I will not merge without waiting for tests to pass
I will not merge without waiting for tests to pass


Performance hints output contains excess commas

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Performance hints output contains excess commas
WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (250 kB). This can impact web performance.
Entrypoints:
  entry0 (725 kB)
      ./build/entry0.js
,
  entry1 (725 kB)
      ./build/entry1.js

If the current behavior is a bug, please provide the steps to reproduce.
I created a repo with reproduction https://github.com/gribnoysup/webpack-perf-output.git
git clone https://github.com/gribnoysup/webpack-perf-output.git
cd webpack-perf-output
npm i
npm run build

What is the expected behavior?
No excess commas in output
Please mention other relevant information such as the browser version, Node.js version, webpack version and Operating System.
node 6.9.4
npm 3.10.10
webpack 2.2.1

This happens because of a small bug in this file https://github.com/webpack/webpack/blob/ecc2adbbfac51776355add90c24481a42f0cb519/lib/performance/EntrypointsOverSizeLimitWarning.js#L18, entrypointList and entrypoint.files are joined without parameter.
I know this is small, but so annoying 😭  I can submit a pull request with a fix if you want

Might have fixed this but I don't know how to test.
Can you tell me how to test or what my code should look like.
Sorry, it is my first contribution and I don't even know too much js.
Thanks.

test it with test\statsTests

Tests pass but how do I test against the webpack-perf-output?

Do you want to add a new test scenario or do you want to test your version against the webpack-perf-output repo?

I am hoping to test my version against the webpack-perf-output repo.


Restyle example formatting for Style/TrailingUnderscoreVariable cop.

This is only document change.
This PR is a change of document format for Style/TrailingUnderscoreVariable cop.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Thanks!


How to include Body Tracking SDK without using NuGet

I am working on a project on Visual Studio
In previous version I include the sdk by following the Azure Kinect DK DOCs using NuGet
But in this version the change log tells that "[Breaking Change] No NuGet install."
It seems that previous method doesn't work anymore?
but also add "[Feature] Verified samples compile with Visual Studio 2019 and updates samples to use this release."
However I have no idea how it work, maybe this is not even a problem to others, but I'm a junior developers without many experiences.  Looking forward to hear the solution from request, it will help a lot, thanks you very much.

Same here, have you found a solution? Thx.

Yes, Thank you
Mark Yu @.***>於 2021年4月1日 週四，下午2:12寫道：

Same here, have you found a solution? Thx.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/Azure-Kinect-Sensor-SDK/issues/1550#issuecomment-811670942,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKFYTW2VS5V7EQ54BEE224DTGQFFFANCNFSM4Z4SFR4Q
.

Hi @Kevin0811, can you share how you managed to make it work? I have installed the Body Tracking API 1.1.0 seperately and add the corresponding headers, libraries, and DLLs to my VS2017 project. I can build and run the simple_3d_viewer example but the fps seems much smaller than the provided simple_3d_viewer.exe.

if anyone has insight on how to install without NuGet that would be much appreciated

if anyone has insight on how to install without NuGet that would be much appreciated

Yes I have figured it out. It's pretty simple actually. Just download the sdk and unzip it. Then in your VS project's property settings, add the "include" path to C/C++->Additional Include Path; add the "lib" path to Linker->Addtional Library Path; add "k4abt.lib" (along with "k4a.lib", "k4arecord.lib" if needed) to Linker->Input->Additional Dependencies. Then it should be OK to run.


Add values_fill docs to pivot_wider

These changes were already made as part of your other PR, so I'm closing this PR. Many thanks!


ISO 19107

Some elements of the harmonized model reference ISO 19107:2019 elements rather than 19017:2003. The result is that we have a mixture of 2003 and 2019 elements in the model.

should be cite both the 2003 and 2019 standards as normative references?
should we add a short explanation of the issue?

Can you give an example, where an element from ISO 19107:2019 is used? Because in the EAP project there is only an ISO 19107:2003 package from which geometries were taken.

The EAP also includes the 19107 Draft International Standard (which I believe became 19107:2019).  An interesting example is GM_Point. GM_Point is defined in 19107:2003. But it has an association with Point which is defined in the 19107 DIS. Clearly the issue lies with the TC211 Harmonized Model. But the disconnect shows up in our conceptual model. Since someone is bound to notice, do we want to address it now?
BTW: the definition for Point starts "GM_Point (figure 9) is the basic---".

I understand now what you mean. That is a very specific issue coming from the TC211 Harmonized Model and which we cannot influence. Thus, I would rather suggest to not address this now.


WSL2: Terminal does not open in working directory - open again

Could you please inform how can resolve this issue?
Opening the terminal for a WSL2 instance (Ubuntu 20.04 in this case: code .) defaults to the path mounted at /mnt/c/users/carlos/AppData/Local/Programs/Microsoft VS Code instead of the working directory.
Related unresolved issue: https://github.com/microsoft/vscode/issues/116135

@mojodna @meganrogge @doudou @threeve

can you share your settings.json?

{
"workbench.colorTheme": "Default Dark+",
"scm.alwaysShowActions": true,
"scm.alwaysShowRepositories": true,
"editor.inlineSuggest.enabled": true,
"github.copilot.enable": {
"*": true,
"yaml": true,
"plaintext": false,
"markdown": false
},
}

and what happens if you set terminal.integrated.cwd explicitly?

I set that and nothing is happens. I tried with
terminal.integrated.cwd= "."
terminal.integrated.cwd= "${workspaceFolder}"
and the settings is ignored!.

Can you share a screenshot of the whole window, including the explorer sidebar?

@Tyriar
if i put a wrong folder I am checking that the terminal is not opening but the path is correct. I think that the path is changed after terminal in vscode is executed.

Another information

@mojodna @meganrogge @doudou @threeve @Tyriar

@ctellechea2001 please stop tagging arbitrary people. That I’ve had a single PR accepted in this project (a typo fix!) does not mean I can help you.

sorry for that! Could you help me?

same issue here

Remove the terminal.integrated.cwd setting, that's meant to be an absolute or relative path.


[WIP] Update desktop nav height and logo

https://artsyproduct.atlassian.net/browse/BUY-136
(Takes the place of #2293)

makes header 60px tall
replaces logo with 40px svg with adjusted line weights
adjusts whitespace around logo

          1 Warning

:warning:
Please assign someone to your PR

  Generated by :no_entry_sign: Danger


add isAudioOnly to Playback and use in Html5Audio playback

@tjenkinson
/home/travis/build/clappr/clappr/test/plugins/poster_spec.js
  75:42  error  Strings must use singlequote  quotes

Coverage increased (+0.01%) to 71.862% when pulling c3f1a2df865d854cd56a1601d12df36d66f0ae0e on add-isAudioOnly-to-playback into 21f180a12777ff11ff1ffbe1936bdcd7d13decd6 on master.

@clappr/core the law 👮  says at least two reviewers ...


vimPlugins.yazi-nvim: init at 2024-06-01

Description of changes
https://github.com/DreamMaoMao/yazi.nvim

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Awesome!
Could you also add mikavilpas/yazi.nvim please? It's basically a fork of DreamMaoMao/yazi.nvim with more features

Awesome!
Could you also add mikavilpas/yazi.nvim please? It's basically a fork of DreamMaoMao/yazi.nvim with more features

I can point the plugin at that one if that's the main version of yazi-nvim. I didn't know about that one.


canImport(UIKit) vs os(iOS)

It seems to me that replacing occurrences of os(iOS) with canImport(UIKit) would make this package usable in iPadOS, Mac Catalyst and tvOS, from each version equivalent to iOS 15.
UIKit

iOS 2.0+
iPadOS 2.0
Mac Catalyst 13.0+
tvOS 9.0+
watchOS 2.0+

UITextField

iOS 2.0+
iPadOS 2.0+
Mac Catalyst 13.1+
tvOS 9.0+

UIViewRepresentable

iOS 13.0+
iPadOS 13.0+
Mac Catalyst 13.0+
tvOS 13.0+

See bce989434147dc067cf1b5decbcf40fa2175f6f4, 7014e9031fad357cc16583217a98a92fb55b813b, c4265b9fd0903dd43e509d169b0fc9b14c925f77.


Use @rpath instead of @loader_path for dynamic libraries

The Problem:
Using @loader_path requires all project dependencies be in the same location. Considering this isn't always the case, using a more dynamic solution that allows for searching multiple paths is recommended.
The Solution:
It's recommended to create "Run-Path Dependent Libraries" that use the @rpath directive in order to allow consumers of your library to locate their dependencies dynamically at runtime. Here's more info from Apple on this topic and why it's the recommended solution vs something like @loader_path - https://developer.apple.com/library/mac/documentation/DeveloperTools/Conceptual/DynamicLibraries/100-Articles/RunpathDependentLibraries.html. Here's the Man Page describing both @loader_path and @rpath in more detail - https://developer.apple.com/library/mac/documentation/Darwin/Reference/ManPages/man1/dyld.1.html.
Additional Benefits:
With the use of @rpath you will be providing support for https://github.com/Carthage/Carthage. Not everyone likes CocoaPods and how it makes changes to your .xcodeproj and then forces you to use a .xcworkspce. Carthage is a far easier and less intrusive solution to dependency management.
Tests:
I did  not write any new code for this PR so no new tests were added. However, I did run the tests to verify everything is still passing with the proposed changes. All tests pass.
Test Suite 'All tests' passed at 2016-03-28 15:02:17.883.
	 Executed 61 tests, with 0 failures (0 unexpected) in 0.304 (0.365) second

Please consider this update. Thanks.

Aside - Re Carthage - PRs welcome.  We held off a while on pods trying to figure out what could be done to support as many folks as possible, but it ended up seeming like we sorta have to just add support for each system on their own.  :(  I can't say I have any direct experience with it, so we'll need suggestions from folks.

@thomasvl Regarding Carthage. The nice thing about Carthage, is that all you need to do to support it is use @rpath, for the reasons described above, and create tags for each release of your lib. That's it. Anyone, like myself, who'd like to use this library with Carthage simply adds github "google/google-api-objectivec-client" ~> 1.0 to their Cartfile and runs $ carthage update. This clones the projects and builds the framework so you can just drop it into your project.
I use Carthage as my dependency manager so in order to get this library to work with Carthage I had to fork it, make the updates proposed in this PR, create a tag and push it to my fork. I then added github "atljeremy/google-api-objectivec-client" ~> 1.0 to my Cartfile and everything works great now. I created this PR so that I don't have to worry about maintaining my own fork. I'd love to just be able to point my Cartfile to your repo and let it pull in updates as they become available.
Thanks.

So there isn't anything extra needed to pick up the SessionFetcher as a dep?  Do you just get it via the deps directory submodule and the Xcode project here then?  What if something else you needed also depended on the GTMSessionFetcher, would that cause a conflict/duplicate symbols?

So there isn't anything extra needed to pick up the SessionFetcher as a dip?

No, Carthage will automatically resolve submodule dependencies as well as other Carthage dependencies if there is a Cartfile in the project.

Do you just get it via the deps directory submodule and the Xcode project here then?

Yes. Carthage will resolve and clone any submodules and make sure they are in the final built framework.

What if something else you needed also depended on the GTMSessionFetcher, would that cause a conflict/duplicate symbols?

Being that these are self contained .framework's that are being built, no, there wouldn't be any duplicate symbols if a project had dependencies that all had the same sub dependency.


Add support for running builds within an QEMU emulation

- Description for the changelog

Add support for QEMU, enable building ARM/ARM64 binaries on Intel build machines
- What I did
Add feature to overwrite the build target arch DOCKER_ENGINE_OSARCH=, so we can easily build binaries for a CPU architecture which is different from the arch the Docker Engine is running on. Assuming that the Docker host is enabled with QEMU binfmt kernel module to build binaries for the requested arch.
- How I did it
Adding a new optional ENV variable QEMU_OSARCH which represents the target arch (in GOARCH syntax, like linux/arm64).
- How to verify it / Prerequisites
It's important that the Docker host where is build is running has to meet some basic requirements and is enabled to run QEMU. Testing is done on a Mac running Docker4Mac (Beta31 or later) which has a Linux kernel 4.8.x running. The new QEMU interpreters have to be registered before you can run a successful build. And it's recommended the test if ARM and ARM64 are emulated within the build environment first.
Registering QEMU interpreters:
$ docker run --rm --privileged dieterreuter/poc-qemu:register --reset

Testing for ARM:
$ docker run --rm -ti armhf/debian:jessie uname -a
Linux 3ef3a2872778 4.8.10-moby #1 SMP Mon Nov 21 22:02:05 UTC 2016 armv7l GNU/Linux

Testing for ARM64:
$ docker run --rm -ti aarch64/ubuntu:wily uname -a
Linux ba12abc64594 4.8.10-moby #1 SMP Mon Nov 21 22:02:05 UTC 2016 aarch64 aarch64 aarch64 GNU/Linux

- Detailed description and example usage
With this change we can run a Docker build in QEMU and build ARM or ARM64 binaries directly on an Intel build machine. This feature already supports building within Docker4Mac (Beta31). So it's easy for a developer to compile and test the Docker binaries locally on his dev machine w/o the need of the target hardware. Another use case would be to run builds on a cloud CI like Travis to get an instant feedback loop for PR's, all on a common Intel platform w/o the need to set up the CI system on the real target hardware.
Usage: build static Docker binaries for ARM 32-bit (uses Dockerfile.armhf)
$ QEMU_OSARCH="linux/arm" make binary

Usage: build static Docker binaries for ARM64 aka AARCH64 (uses Dockerfile.aarch64)
$ QEMU_OSARCH="linux/arm64" make binary

Signed-off-by: Dieter Reuter<EMAIL_ADDRESS>

Ping @justincormack

Note that D4M/D4W master wont yet build these due to missing qemu patches, planning to fix this soon, but you can use the container linked above.

Also note you need a 4.8 kernel to do this... (possibly 4.7).

:tada:


Adds the JSX transformer

The JSX transformer is designed to transform JSX-specific syntax into compatible JavaScript when the --jsx react compiler option.
Related Pull Requests:

#6892 - Adds the visitor API foundation for tree transformations.
#6983 - Adds the Transform Flags concept for tree transformations.
#6986 - Adds the transformFiles API for tree transformations.
#6987 - Adds a simplified pretty printer for tree transformations.
#7191 - Adds the TypeScript transformer.
#7192 - Adds the JSX transformer.
#7193 - Adds the ES7 transformer.
#7194 - Adds the ES6 transformer.

Am I reading this correctly that there are zero baseline changes?

@RyanCavanaugh With only these transformations, the emitter isn't far enough along to run the tests and capture baseline changes. Those will come after I submit the last PR containing the module transformer.

:+1:


Need more direction

Regarding the comment "This user is synchronized with your local Active Directory. Some details can be edited only through your local Active Directory".  I had this issue.  The problem is that the on-prem DC does not have any Exchange options for me to add primary or alias emails.  If you can add a bit more instructions on how to do that using on-prem AD, that would be great,
Thanks.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 94754a91-ac3b-9b1c-ded9-3fdab2dd229c
Version Independent ID: 517f9726-1861-8b1c-fe9d-6c50047e16d3
Content: Add another email alias for a user - Microsoft 365 admin
Content Source: microsoft-365/admin/email/add-another-email-alias-for-a-user.md
Service: microsoft-365-business
GitHub Login: @KwekuA
Microsoft Alias: kwekua

@thatbeingsaid3 Thank you for your feedback. This document pertains only to adding information on the M365 admin center.
There are multiple ways to add an alias to a user in AD. https://learn.microsoft.com/en-us/answers/questions/260810/how-i-can-add-mail-alias-second-address-for-o365-a.html
IF you still cannot add an alias, Please create a support ticket via the need help section on the admin center so that a support engineer can assist you.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @thatbeingsaid3 Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Updates to the Render datasource

The main feature added in this PR is support for multiple scales in the Render datasource. When loading data from a Render server, neuroglancer will now compute a resolution hierarchy (levels 0 to n) where the nth level corresponds roughly to the user specified tilesize (default 1024) in the largest dimension. If Render is properly configured and mipmaps have been generated, this configuration should result in the best performance.
In addition, this PR adds a fix to ignore render stacks not in the COMPLETED state (render will fail to return images for these stacks) and a json utility function to verify an optional Int (used to parse the user specified tilesize parameter mentioned above).

Looks like there's a merge conflict relating to the change in CancellationToken mechanism. Should I try to resolve on my end?

Yeah, perhaps you can try to resolve it yourself, but feel free to ask if you have any questions about it.

Turned out it was pretty easy.


Loading strongly typed views from external assemblies which are loaded runtime

Hi,
We are currently working on an application which needs to load external asssemblies containing strongly typed views and models which are to be used in a generic controller. We've gotten as far as loading the assemblies using a custom AssemblyProvider, and we're able to load the views using either a custom file provider loading the views from the database or using the new EmbeddedFileProvider, but we are having issues when the views are compiled runtime - the model classes isn't being resolved.
It is a requirement that new class libraries / models should be made available without having to restart the application.
What are we missing? After adding the AssemblyProvider for loading assemblies from a custom directory we are able to resolve the type when creating an instance of the dynamically loaded model, but the type is still not resolved during runtime compilation of the razor views.
Any input is very much appreciated

There's no real nice way to plug this in in RC1, we added an API to do it in RC2.

@pranavkm - can you provide an example of how to configure the Razor compilation assemblies?

There's a callback on RazorViewEngineOptions that lets you configure the Roslyn compilation context:
var previous = options.CompilationCallback;
options.CompilationCallback = (context) =>
{
    if (previous != null)
    {
        previous(context);
    }

    var references = myAssemblies.Select(Assembly.Load).ToArray();
    context.Compilation = context.Compilation.AddReferences(references);
};

That's RC2 the RC1 way is well, super hard 😄

btw does this actually work?

var references = myAssemblies.Select(Assembly.Load).ToArray();

If it's a sequence of AssemblyName instances, it should. Essentially what we do during controller discovery.

The references are roslyn metadata references not assemblies.

Oops, fixed the sample.

Thank you very much for the responses. I've now implemented this using the callback described above and it works mostly as I'd expect it to. The issue I'm seeing is that the compilation fails as soon as there is a dependency version conflict between an assembly referenced by the assembly loaded runtime and the running application. This is the error message I'm getting:
Assembly 'CoreSampleService' with identity 'CoreSampleService, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' uses 'System.Collections, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' which has a higher version than referenced assembly 'System.Collections' with identity 'System.Collections, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
Not sure if this is the correct place to ask these questions, but I thought I'd give it a shot


added the params

Just FYI for future PRs, you should probably use a more detailed title. This title is a bit vague, it would be unclear what's actually being changed or added if this was a larger PR, or if you came across it a while down the road


🐛 BUG: Remote dev always tries to generate exchange on root of zone, even if using a subdomain, and can therefore fail if the domain has no DNS records

Which Cloudflare product(s) does this pertain to?
Workers/Other
What version of Wrangler are you using?
2.8.1
What operating system are you using?
macOS
Describe the Bug
WRANGLER_LOG=debug wrangler dev --log-level=debug

name = "my-worker"
account_id = "xyzabc123"
compatibility_date = "2023-01-24"
main = "src/index.ts"
routes = ["subdomain.example.com/*"]

https://github.com/cloudflare/wrangler2/blob/416babf050ed3608e0fd747111561a4c7207185e/packages/wrangler/src/create-worker-preview.ts#L121-L123
I think these lines are requesting an exchange on the root zone (e.g. example.com) which may not have any DNS set up.
I see the following error:
-- START EXCHANGE API REQUEST: GET https://example.com/cdn-cgi/workers/preview/?s0=$TOKEN
-- END EXCHANGE API REQUEST
✘ [ERROR] Error while creating remote dev session: TypeError: fetch failed

      at fetch10
  (./node_modules/wrangler/wrangler-dist/cli.js:13582:17)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async createPreviewSession
  (//node_modules/wrangler/wrangler-dist/cli.js:124985:28)
      at async start
  (./node_modules/wrangler/wrangler-dist/cli.js:127446:9)
  {
    cause: Error: getaddrinfo ENOTFOUND example.com
        at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:107:26) {
      errno: -3008,
      code: 'ENOTFOUND',
      syscall: 'getaddrinfo',
      hostname: 'example.com'
    }
  }

Possibly related #2018, #2581

@GregBrimble Could you check if https://github.com/cloudflare/wrangler2/pull/2651 fixes this?

Fixed in https://github.com/cloudflare/workers-sdk/pull/2651


The user should be able to view the modules/plugins menu in mobile view also. if the user adds any module.

Steps To reproduce--
1. log in as a user
2. Add any module/plugin.
3. Try to see the related modules/plugins menus in mobile view.
Actual result: The user is not able to view the modules/plugins menu in mobile view. if the user adds any module. Please find the below screenshot.
Expected result:  The user should be able to view the modules/plugins menu in mobile view also. if the user adds any module.

@akhtarkhan1
As we discuss this is not an issue. so I am closing this issue.

@devansh-webkul
Now, this issue is fixed. so I am closing this issue.
And I have attached a screenshot for future reference.


Pauli spin blockade or readout with a resonator

Hi,
I am looking at the notebook 'Simulation of Elzerman readout' under 'Example notebooks/analysis'.
At the last part, it shows an example of the Pauli spin blockade readout to detect 'singlet' or 'triplet'. However, I am confused that  the triplets transfer to singlets after some time and then be detected.
Could you describe more specifically what kind of resonator it is and how's the system initialised?
The whole repository is great. Looking forward to hearing from you.
Thanks.

@mattcu64 Triplets decay to singlets on a typical timescale of T1 which is 3 milisecond in this example.
Note that this is a pure simulation, so there is no resonator involved.
The initialization for each trace is random (e.g. the argument initial_state=[0.5,0.5])


⚠ ClamAV has degraded performance

In 69cfc3a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 475 ms

Resolved: ClamAV performance has improved in d03a99e.


Update schema displays

Description of changes
Small fixes to schema Displays, which are visible via the CLI's translate-schema command.

Added some additional newlines to the display impl for the Cedar schema format to change

action "edit" appliesTo {  principal: [User],
  resource: [Photo],
  ...

to
action "edit" appliesTo {
  principal: [User],
  resource: [Photo],
  ...

Updated the display impl for the Cedar schema format to omit empty attribute fields, changing entity UserGroup  = {  }; to entity UserGroup;
Added skip_serializing_if annotations to default JSON fields (resolving #776)

Issue #, if available
#776, #682
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[X] A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

[X] Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

[X] Does not require updates because my change does not impact the Cedar formal model or DRT infrastructure.

Running schema roundtrip DRT targets locally now. Will update if I find any failures.

 Probably worth adding a line to the changelog


OpenCvSharp.CPlusPlus not available anymore?

Hi everyone,
I am trying to recover an old project I had where I used an old, already deprecated, version of OpenCvSharp. There, I could easily write
using OpenCvSharp.CPlusPlus;
and use many structures from opencv. However, in this newer version there seems not no be a CPlusPlus namespace and I am confused as to how to proceed then. How do I access to structures such as Point2f or CvPoint in this newer version?
Thanks in advance,
Ana.

OpenCvSharp.CPlusPlus has been renamed OpenCvSharp, because the native OpenCV C API is almost obsolete, and the C++ API has become more common.

OpenCvSharp 2.x
OpenCvSharp 3.x and later

OpenCvSharp
(deleted)

OpenCvSharp.IplImage
(deleted)

OpenCvSharp.CvPoint
(deleted)

...
...

OpenCvSharp.CPlusPlus
OpenCvSharp

OpenCvSharp.CPlusPlus.Point2f
OpenCvSharp.Point2f

OpenCvSharp.CPlusPlus.Mat
OpenCvSharp.Mat

...
...

Thanks a lot! I had been struggling with that for a couple of days and now the answer makes a lot of sense.
I tried and it seems to work just fine. I'll change the code then the entire code to the new C++ API then, which seems to be the main problem here.


feat(Http): Expand support for request on local files

This expands support to load local app files when using Angular's Http core request method. Many apps use the basic request api to construct their api calls. This allows the local file request initially implemented here to work the same for calls to request.

run ci

@dtopuzov the travis failure appears to be related to android build step?  Shouldn't be related to these changes. Anyway you can get this all green and ready?

Hey @NathanWalker, can you rebase your PR on top of master? It should fix the travis build

@sis0k0 Thank you, rebased now 👍


feat: add support for initial user officer role assignment

Description
This PR introduces the feature of assigning the initial user officer role based on the email address.
Motivation and Context
This change was required to automate the process of assigning roles to users upon their first login, specifically the user officer role. It solves the problem of manually assigning the user officer role to the first-time users.
Changes

Added a new environment variable INITIAL_USER_OFFICER_EMAIL to hold the email address of the initial user officer.
Implemented logic in OAuthAuthorization to assign the user officer role for the first-time user with the email address matching INITIAL_USER_OFFICER_EMAIL.
Updated the test suite to cover the new functionality.

How Has This Been Tested?

Fixes Jira Issue
https://jira.esss.lu.se/browse/
Depends On

Tests included/Docs Updated?

[ ] I have added tests to cover my changes.
[ ] All relevant doc has been updated

Do you want STFC eyes on this?

Do you want STFC eyes on this?

@Scott-James-Hurley STFC is not affected, but if you have time to review it, I would appreciate it.


Parse unknown identifiers for lambda expressions

This is a very helpful feature, but when used against expressions with lambdas e.g. list.Any(x => x == null) - x here is an unknown identifier.
So I'm note sure whether this is an expected behaviour, because from expression inputs perspective - yes it's unknown, however it won't raise any compilation errors (since I enabled lambdas) and it's more likely a runtime variable rather than an unknown input identifier.

Repro example:
var target = new Interpreter(InterpreterOptions.Default | InterpreterOptions.LambdaExpressions);
target.SetVariable("list", new List<string>());
target.DetectIdentifiers("list.Any(x => x == null)").Dump();

Results:
{
  "UnknownIdentifiers": [
    "x"
  ],
  "Identifiers": [
    {
      "Name": "list",
      "Expression": {
        "Type": "List<string>",
        "NodeType": "Constant",
        "Value": [],
        "CanReduce": false
      }
    },
    {
      "Name": "null",
      "Expression": {
        "Type": "object",
        "NodeType": "Constant",
        "CanReduce": false
      }
    }
  ],
  "Types": []
}

x is detected as an unknown identifier.
@halamah that's an oversight on my part, I didn't think of that when I implemented the lambda expression support.


Not valid when inferring return value types from function parameters of nested array types

Bug Report

A function that passes in a custom schema that constrains the values of the properties of the returned object.
But when the parameters are nested arrays, the type constraint does not take effect.
🔎 Search Terms

nested array, nested tuple, type Inference, type constraints
🕗 Version & Regression Information

v4.6.4
⏯ Playground Link

Playground link with relevant code
💻 Code

function pickFunc<T extends DemoO, U extends ToSchemaType<T>>(
  obj: T,
  schema: U
): PickBySchema<T, U> {
  throw "not yet implemented";
}

const res = pickFunc(post, ["id", "body"]);
res.id;
// The message "title does not exist" was successfully displayed
res.title;
res.body;

// When using nested schema, the type constraint does not take effect
const res = pickFunc(post, ["id", ["tags", ["name"]]]);
res.id;
// Expect an error message
res.title;
// Expect an error message
res.tags[0].id
res.tags[0].name

I created the PickBySchema type to generate attribute field constraints for the object.
It is effective when used alone.

type PickBySchema<T extends DemoO, U extends ToSchemaType<T>> = {
  [K in U extends (infer U1)[]
    ? U1 extends string
      ? U1
      : U1 extends [infer U2, SelectSchemaType]
      ? U2 extends string
        ? U2
        : never
      : never
    : never]: T[K] extends string
    ? T[K]
    : T[K] extends (infer O)[]
    ? O extends DemoO
      ? PickBySchema<O, GetNestedSchema<U, K>>[]
      : never
    : never;
};

type PostOnlyId = PickBySchema<Post, ["id", ["tags", ["id", "name"]]]>;

🙁 Actual behavior
When passing nested arrays in function parameters, the return value does not get the expected type constraints
🙂 Expected behavior
When passing a one-dimensional array or a nested array as a function parameter, the return value is expected to be bound by the specified field

That's quite a long reproduction; could you demonstrate the issue with less code?
I think this might be related to #30680; the compiler is inferring wider array/string types than you want.

This repro is long enough that it's unlikely to represent a bug in TypeScript. If you can provide a shorter one (5-10 lines is sufficient to reproduce almost any defect) we can investigate, but we don't have the resources to dig in to things this large.

First of all, thank you very much for your replies, and I apologize for providing a slightly longer reproduction. Since this problem was discovered during debugging nested arrays, I'll close the issue before I provide a parsimonious reproduction.


GUI OS Bugs

UI should work now on Windows better(?)- not sure why by the GUI was rendering differently in different OS (I'm on mac). Just hardcoded the dimensions explictly to make sure that the fields are where we want them to be (hopefully it'd work).
Also realised the error message for the AddIteration window was a little misleading when no image is selected (says the home directory isn't a file) so I fixed that too.

macOS (before)Windows (before)

macOS (after)Windows (after)

Can someone help to test this out too to make sure there are no other UI bugs on Windows/ Linux? Thanks!

Codecov Report

Merging #132 (d31d77e) into master (4652a13) will increase coverage by 1.34%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #132      +/-   ##
============================================
+ Coverage     59.74%   61.08%   +1.34%
- Complexity      734      778      +44
============================================
  Files           129      131       +2
  Lines          2859     3030     +171
  Branches        300      334      +34
============================================
+ Hits           1708     1851     +143
- Misses         1066     1088      +22
- Partials         85       91       +6

Impacted Files
Coverage Δ

...n/java/seedu/address/commons/core/GuiSettings.java
69.23% <ø> (ø)

...n/java/seedu/address/ui/CommissionDetailsPane.java
0.00% <ø> (ø)

.../main/java/seedu/address/ui/IterationListItem.java
0.00% <ø> (ø)

.../address/ui/command/window/AddIterationWindow.java
0.00% <0.00%> (ø)

...edu/address/ui/command/window/IterationWindow.java
0.00% <0.00%> (ø)

.../logic/commands/iteration/AddIterationCommand.java
88.09% <0.00%> (-0.80%)
:arrow_down:

.../seedu/address/logic/parser/AddressBookParser.java
69.81% <0.00%> (-0.56%)
:arrow_down:

...rc/main/java/seedu/address/logic/LogicManager.java
57.81% <0.00%> (-0.33%)
:arrow_down:

...c/parser/iteration/EditIterationCommandParser.java
100.00% <0.00%> (ø)

...logic/commands/iteration/EditIterationCommand.java
90.41% <0.00%> (ø)

... and 1 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Cleanup man pages.

podman does not support nocopy so we need to remove it from man pages.
podman build now supports --isolation, so we need to document it.
https://bugzilla.redhat.com/show_bug.cgi?id=1613074 points this out.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

@mheon Updated to remove nocopy and added --isolation documentation.
@mheon @giuseppe @TomSweeneyRedHat @umohnani8 PTAL

LGTM

@rh-atomic-bot r=TomSweeneyRedHat


Paths are not converted correctly

A simple function like fn or([false] false, [false] false) -> [false] false; is converted to
FnRef(16),
FnRef(7),
FnRef(7),
OpRef(9),

The function name is treated as a declaration of a new function instead of mapping to the parent function.
The path instructions are missing from the arguments.

When printing out the parsed syntax as JSON the paths are missing.


Add GetVirtualNetwork to network samples

Not sure if wanted, but have been working w/ VirtualNetwork objects and noticed the samples was lacking the get method.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: snimmagadda1 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Wider dropdowns for filters

Please make the dropdowns fit the largest string! Sometimes the filter names are longer and the box is rather small. Maybe the issues dropdown could be a little longer or maybe wrap the title. Not sure how hard it would be! Would really appreciate this change!

Sure thing - I'll have a look at this :-)

Just to be sure - we are talking about the drop-down box in the bottom of the window - right? The other drop-down boxes are already as wide as the parent window.

Yeah! And also on the other dropdowns, is it possible to wrap the issue
title?
Sent from my Moto G
On Mar 10, 2016 12:15, "Carsten Gehling"<EMAIL_ADDRESS>wrote:

Just to be sure - we are talking about the drop-down box in the bottom of
the window - right? The other drop-down boxes are already as wide as the
parent window.
—
Reply to this email directly or view it on GitHub
https://github.com/carstengehling/jirastopwatch/issues/8#issuecomment-194774570
.

Maybe - I implement my own drawing code on the dropdown already. So it might be possible

This request is turning out to be more difficult than I first thought. I have trouble making the dropdown area becoming the right height, when one or more (but not all) summary are wrapped.
I don't know if you are proficient in C# and WinForms yourself, but I've made a feature-branch so that you or anyone else can pitch in: https://github.com/carstengehling/jirastopwatch/tree/cbjirawordwrap

@carstengehling
Personally, I don't have that kind of knowledge, but maybe someone else will be able to look at it!
I appreciate your time and effort on this! You make my life so much easier with this tool!

Well I'm happy that I do. The idea for the application also came from trying to make things easier for myself. So I'm glad when other people get the same result.

@evladutoiu I haven't been able to make the word-wrap work, so only the wider dropdown in the bottom has been included in the latest release:
https://github.com/carstengehling/jirastopwatch/releases/tag/1.6.0


rewind and fix bug in MieQuery.H (use a shape of a not present variable)

I would like rewind Issue #93 at this moment. There are many hard-coded variable names that need to be changed. This PR addresses the issue #129 . Also a bug in MieQuery.H is fixed.  We should have a separate PR to address #93

closed. PR  #138 can address this issue


Pi build and initial ArmCompute library support

What changes were proposed in this pull request?
Pi build and initial ArmCompute library support

Maxpool2d
Avgpool2d

How was this patch tested?
unit tests
Quick checklist
The following checklist helps ensure your PR is complete:

[x] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
[x] Reviewed the Contributing Guidelines and followed the steps within.
[x] Created tests for any significant new code additions.
[x] Relevant tests for your changes are passing.

BTW, MKL-DNN/DNNL/oneDNN now support ARM:

oneDNN CPU engine is used to execute primitives on Intel Architecture Processors, 64-bit Arm Architecture (AArch64) processors, and compatible devices.

https://github.com/oneapi-src/oneDNN/

Ye, it says

    WARNING

    Arm 64-bit Architecture (AArch64) support is experimental with limited testing validation.

So one day it'll become a viable option we hope.

@sshepel we need two things:

Add ARM Compute Library into CI docker image
Try CI with -h armcompute switch, that'll enable ARM CL helpers


c# scripts cannot be deleted - compilation error (HTML5)

Godot version
3.3.3 stable
System information
Windows 10, GLES2
Issue description
After removing C# script exporting was broken. In *.csproj no reference to this script, in scene no reference, I foud one in scripts_metadata.editor_player, but in is not repeat in new project. Problem probably related to Rider, when i remove .idea fron the project something changed, but the project still doesn't build for HTML.
Something like "ERROR: Unable to start HTTP server. At: platform/javascript/export/export.cpp:699"
Steps to reproduce
create a node
add a script to it
delete the script from the file system
delete the script from the object
run it in the BROWSER mode
Minimal reproduction project
Platformer.zip

Seems to be a duplicate of #56758, this one is older but as the other one seems to be a bit more detailed I'll close this one.
As a workaround, if you don't have any C# scripts in your project deleting the .csproj and .sln files should make exporting work.


"search" functionality

Being able to search keywords on the table. Just like the other react-bootstrap-table where you only need to add "search" in the BootstrapTable component.

Hi @andela-mekwenugo:
This is the roadmap for the upcoming feature but it was a little delayed. We will implement the search ASAP. Thanks.

duplicated with #239

Implement on<EMAIL_ADDRESS>and<EMAIL_ADDRESS>https://react-bootstrap-table.github.io/react-bootstrap-table2/docs/basic-search.html


Unify deployment target between SPM and cocoapods

Currently, the iOS deployment target in the podspec file is set to iOS 12. The SPM specification does not point to an iOS version. This PR tries to unify the minimum deployment targets across SPM and cocoapods. This allows users of the SDK to offer the same minimum version for SPM and cocoapods.

If you prefer I can switch the PR to not specify a minimum deployment version for both
package manager.


Footnotes and citation in The Lost Dao

The Lost Dao chapter needs footnotes and citations throughout, roughly 1-2 per paragraph. If the process turns up incorrect claims in the text, please submit an issue and tag @pluralitybook.

Added sources:
Stafford Beer business cybernetics:
Dickson, Paul. “Sputnik’s Impact on America.” NOVA | PBS, November 6, 2007. https://www.pbs.org/wgbh/nova/article/sputnik-impact-on-america/.
Deming’s 14 Points:
UTHSC. “Deming’s 14 Points,” May 26, 2022. https://www.uthsc.edu/its/business-productivity-solutions/lean-uthsc/deming.php.
Sputnik impact on US technology policy:
Dickson, Paul. “Sputnik’s Impact on America.” NOVA | PBS, November 6, 2007. https://www.pbs.org/wgbh/nova/article/sputnik-impact-on-america/.
Man-Computer Symbiosis:
J. C. R. Licklider. “Man-Computer Symbiosis,” March 1960. https://groups.csail.mit.edu/medg/people/psz/Licklider.html.
Douglas Engelbart Augmentation Research Center:
“Douglas Engelbart Issues ‘Augmenting Human Intellect: A Conceptual Framework’ :  History of Information,” October 1962. https://www.historyofinformation.com/detail.php?id=801.
The Computer as a Communication Device:
Ritchie, Hannah, Edouard Mathieu, Max Roser, and Esteban Ortiz-Ospina. “Internet.” Our World in Data, April 13, 2023. https://ourworldindata.org/internet.
The mother of all demos:
Engelbart, Christina. “Firsts: The Demo - Doug Engelbart Institute.” Doug Engelbart Institute, n.d. https://dougengelbart.org/content/view/209/.


Ability to generate multiple pages

The webpack configuration currently is tailored to creating a single page. Allowing users to set up multiple pages right away, or at the very least, provide documentation on how to add multiple pages, would be useful.

npm install html-webpack-plugin raw-loader --save-dev
...
const HtmlWebpackPlugin = require('html-webpack-plugin');
const fs = require('fs')
function generateHtmlPlugins(templateDir) {
const templateFiles = fs.readdirSync(path.resolve(__dirname, templateDir));
return templateFiles.map(item => {
const parts = item.split('.');
const name = parts[0];
const extension = parts[1];
return new HtmlWebpackPlugin({
filename: ${name}.html,
template: path.resolve(__dirname, ${templateDir}/${name}.${extension}),
inject: false,
})
})
}
const htmlPlugins = generateHtmlPlugins('./src/html/views')
module.exports = {
module: {
...
{
test: /.html$/,
include: path.resolve(__dirname, 'src/html/includes'),
use: ['raw-loader']
},
]
},
plugins: [
...
].concat(htmlPlugins)
};

This feature has now been merged. Thanks @aalekseenkov for the code snippet.


Not really an issue...

@JeffreyWay Hi,
Like I said, this is not an issue is lack of understanding, but laravel-mix doesn't feel  natural, intuitive like I felt with elixir. .styles no longer exists..., mix breaks my assets structure creating new folders for images an fonts... it throws allot of fs.js error messages... with elixir everything was more natural and intuitive.
I repeat like I said this is NOT an issue.
what I did was yarn remove laravel-mix then yarn add laravel-elixir... now every thing works ok again.
Thanks.

Like I said, this is not an issue is lack of understanding

It somewhat is.

.styles no longer exists

Mix.combine() is the equivalent, and does the same thing. I have a task to add Mix.styles() back in, but it will simply be an alias for Mix.combine().

mix breaks my assets structure creating new folders for images an fonts

This is a feature of Webpack's, and is entirely dependent upon how you write your CSS. If you're referencing relative paths to assets, it'll copy those assets to your public directory.

it throws allot of fs.js error messages

You can create an issue here with the exact error message, and we can figure out what the problem is.

@JeffreyWay Hi,
hanks for you fast answer, right now I have what I  need running, I with my time really tight so I will not create that issue, but I have a little project of my own and as some as possible I will give it a try again.
I don´t now if this is the proper channel, to best communicate with you, sorry if not.
Once again thank you.


feat: Add feature to allow config-ssh value overrides

Fixes https://github.com/coder/coder/issues/6826


fixes issue where json needed to be in single quotes

T: patch
Fixes an issue where amp-ads json attribute didn't work properly without using single quotes.

@orrybaram LGTM


Remove core-js reference from oauth-service.d.ts

In short: the reference is not needed and causes conflicts with lib-es6.d.ts
Scenario:

Follow the Angular2 Webpack sample to create an Angular2 app that builds with Webpack
Add the angular-oauth2-oidc package and use it to protect the AppComponent
Attempting to build the application fails because oauth-service.d.ts references core-js, which wasn't installed -- so install core-js via npm install @types/core-js --save-dev
Attempting to build the application fails because core-js conflicts with lib-es6.d.ts (duplicate identifier 'PropertyKey')
Uninstall core-js via npm uninstall @types/core-js --save-dev
Open oauth-service.d.ts and delete the line /// <reference types="core-js" />
Building the application now succeeds

I agree, could not build project unless deleted line with reference to core-js.

Thanks for this info. I've removed this dependency and published a new version of the library.

Thank you, but it looks like it's still there. My original post should've mentioned to remove the reference from dist/src/oauth-service.d.ts

Can you please double check this? This files doesn't contain this reference anymore. Or did I understand sth wrong?

I pulled down the latest and I can confirm that the issue I reported is fixed, thank you.


css-loader fails to parse npm linked modules correctly

Referencing a CSS file from a node_module package within my webpack config works fine
const CSS_PATHS = [
  config.paths.demo,
  path.join(ROOT_PATH, 'style.css'),
  path.join(ROOT_PATH, 'node_modules', 'chopstrap', 'dist', 'chopstrap.css'),
];
...

module: {
      loaders: [
        {
          test: /\.css$/,
          loaders: ['style', 'css'],
          include: CSS_PATHS
        },
...

but if I link to a local package with npm link I receive the error
ERROR in ../chopstrap/dist/chopstrap.css
Module parse failed: C:\Users\jelewis1\Desktop\work\chopstrap\dist\chopstrap.css Unexpected character '@' (1:0)

It seems that the loader isn't interpreting valid CSS correctly when referenced through a symlink.

Are you using postcss-loader?

Of course as usual it was me.  Choking on sass that I wasn't processing correctly with extractTextPlugin.  Sorry for the wasted time.


elixir_1_6: remove

Additionally removed the now obsolete rebar build dependency for elixir.
Was only necessary till v1.6.
Motivation for this change
As Elixir v1.11 will be released soon - Elixir v1.6 will then be deprecated.
But my main motivation to do it now is to get rid of the rebar build dependency.
It seems that rebar won't build with Erlang v23 anymore.
Erlang v23.1 is already released and in my opinion should get soon the default Erlang version within nixpkgs.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 98649 1

5 packages built:

elixir (elixir_1_10)
elixir_1_7
elixir_1_8
elixir_1_9
rabbitmq-server

Hello, so i got hit today by the fact that on nixos-20.09 we allow erlang 23, but also have not put this patch in nixos-20.09. and rebar does not compile for all kind of broken reasons
Would it be possible to merge this in 20.09 too. I know it means we lose 1.6 which would need a patchnote, but this is an old version not supported anymore and this break everyone trying to run elixir on otp23 on 20.09, which we allowed


Bug fix: Change n to total_n post read syscall

This PR fixes a minor bug in desock.c. The bug is that, a correct read was being incorrectly flagged as EOF due to a mix-up between locals n and total_n. total_n should be used.

Thanks!


RNG-137: Add StableSampler

Re-implemented the StableRandomGenerator from Commons Math random
package.
Uses a translation of the Fortran RSTAB program from Chambers et al
(1976).
Add a JMH benchmark to demonstrate speed of the RSTAB routine verses a
alternative implementation that is discontinuous as alpha approaches 1.
The sampler checks the distribution support and corrects invalid
samples.
Uses a fast tan(x) / x function approximation.

Coverage increased (+0.03%) to 99.603% when pulling 28dea5b26b1d3d5b9f40c164d72ed1ea5ba373fe on aherbert:feature-RNG-137 into 897bbc93399105d1856d71400255fb40f910e864 on apache:master.


[General] Rebuild the async version

Are you in the correct repository?

[x] Yes

Request
Rebuild the async version, as there are too many errors that I found during testing. I will spend a few days changing the code and fixing it.

I realized that the rebuilding didn't take as long as I expected, so I changed the target date to today

Nevermind, it still needs to be rebuilt

I feel really dumb, I forgot to use await in my testing program


[bugfix] add "|Invalid" to regex in utils

Updated regex so that the input's "onInvalid" attribute matches and actually get's passed to component.

Cheers! Can you add a change log entry please? Also it’d be good to expand this test to make sure that everything stays this way :) https://github.com/styled-components/styled-components/blob/master/src/utils/test/validAttr.test.js

Sure mate! Oversaw it! I’ll add a change log and adapt the tests! 👍🏻

Thank you so much for helping us improve styled-components! Based on our Community Guidelines every person that has a PR of any kind merged is offered an invitation to the styled-components organization—that is you right now!
Should you accept, you'll get write access to the main repository. (and a fancy styled-components logo on your GitHub profile!) You'll be able to label and close issues, merge pull requests, create new branches, etc. We want you to help us out with those things, so don't be scared to do them! Make sure to read our contribution and community guidelines, which explains all of this in more detail. Of course, if you have any questions just let me know!

Thank you so much for the quick fix 👏


[Bug] Wait for SQL: Passing date row results to pipeline

The Pipeline Transformator seems to have an issue starting with version 2.2 in the following constellation:
Step

"Wait for SQL" with "Custom SQL", "Add Rows to Resultset" and a column of date(time)
Followinging a Pipeline within the workflow
Step "Get Rows From Result" within the pipeline (Data Type date)

2 possible outcomes for me:
(a) I receive directly the error in the pipeline: SAMPLEDATE None : Unknown type 0 specified.
(b) The pipeline does run completely and without a problem. However, if the workflow picks up the processing again, the following error appears (starting with hop 2.2):
SAMPLEDATE  Timestamp : There was a data type error: the data type of java.lang.String object ['2023-02-27T13:00:00.000'] does not correspond to value meta [Timestamp] (through reference chain: org.apache.hop.execution.ExecutionData["rowsBinaryGzipBase64Encoded"])

what is the database type?

Tested with a MS SQL Server/ Database
It does work, if I pass the result as a string (or rather if I grab it in the pipeline as a string via Get rows from result).

It seems a very weird behaviour. I continued testing with this issue since I got similar effects in other occasions. It doesn't seem to be dependent on the Wait for SQL step and rather indicates an issue how string and date values are in general passed to the variables of a workflow or pipeline.
I do have a pipeline, where I write a date value (system date), which was altered to a string (Select values), to the variables of the workflow above. This step fails with version (b) from above. However, if I put in a delay row step of 1sec, it runs smoothly without any errors. Seems to be an issue of the engine imho.
works

doesn't work

could you add a sample (you have to zip it as GitHub does not accept our file types). It will make debugging this a bit faster for us.
As far as variables go, they are all strings... Which are cast to the type you select in the Get Variables transform

could you add a sample (you have to zip it as GitHub does not accept our file types). It will make debugging this a bit faster for us. As far as variables go, they are all strings... Which are cast to the type you select in the Get Variables transform

added above