[LLVMCPU] Enable vectorization for pack ops.

It introduces SplitFullPartialTransferPass to hook up upstream VectorTransferFullPartialRewriter pattern. The pattern splits a vector.transfer operation into an in-bounds (i.e., no out-of-bounds masking) fastpath and a slowpath. This needs to be applied before converting to LLVM dialect.
Verified that we're getting 2x-3x performance improvements from Tracy.
For LHS packing, i.e.,
lhs_4d = iree_linalg_ext.pack %lhs
  inner_dims_pos = [0, 1]
  inner_tiles = [8, 8]
  into %lhs_4d_init
  : (tensor<256x256xi8> tensor<32x32x8x8xi8>) -> tensor<32x32x8x8xi8>

The performance is improved from 32.59 us to 10.01 us.
For RHS packing, i.e.,
%rhs_4d = iree_linalg_ext.pack %rhs
  outer_dims_perm = [1, 0]
  inner_dims_pos = [1, 0]
  inner_tiles = [8, 8]
  into %rhs_4d_init
  : (tensor<256x256xi8> tensor<32x32x8x8xi8>) -> tensor<32x32x8x8xi8>

The performance is improved from 32.35 us to 16.11 us.
Fixes https://github.com/iree-org/iree/issues/10889

@chelini @nicolasvasilache FYI that we have tiling and vectorization working e2e in IREE for pack ops.

I am trying to understand why we need the fast and slow path. I'd assume we are always on the fast path. Maybe we just need to adjust the inner tile size on x86?

We're not always on fast path (i.e., unmasked case) because it can be padding mode. We'll read an incomplete tile and pad it to inner_tile sizes.
One of the options in the pass can convert them into unmasked transfer_read (i.e., guaranteed that all the reads are in bound) with some costs.
side note that we're not able to convert masked transfer_read to LLVM dialect. We need to split the masked transfer_read/write ops for making it work e2e.

I am trying to understand why we need the fast and slow path. I'd assume we are always on the fast path. Maybe we just need to adjust the inner tile size on x86?

We're not always on fast path (i.e., unmasked case) because it can be padding mode. We'll read an incomplete tile and pad it to inner_tile sizes.

Is there an analysis that makes sure we dont generate the slow path if we statically know that we dont need it.... This is a branch in the innermost loop which is not great. We might need it in full generality, but maybe able to avoid it in some cases?

One of the options in the pass can convert them into unmasked transfer_read (i.e., guaranteed that all the reads are in bound) with some costs.
side note that we're not able to convert masked transfer_read to LLVM dialect. We need to split the masked transfer_read/write ops for making it work e2e.

Is there an analysis that makes sure we dont generate the slow path if we statically know that we dont need it.... This is a branch in the innermost loop which is not great. We might need it in full generality, but maybe able to avoid it in some cases?

It's already happening. We avoid the branch when we know we don't need it. I.e., when the padding is not needed. If the padding is not needed, a transfer_read op is created; all the values of in_bounds attribute are true. The pass is a no-op in this case. See the IR before and after the pass: https://gist.githubusercontent.com/hanhanW/599a82cc70545a28026340bf34e355e8/raw
If padding is needed, the transfer_read will have at least one false value in in_bounds attribute. In this case, the pass has a couple options to handle it. The linalg-copy option allocates a stack buffer and copies over the data if it's incomplete tile. Otherwise it takes a subview of the complete tile. See IR:
// -----// IR Dump After SplitFullPartialTransfer (iree-codegen-split-full-partial-transfer) //----- //
func.func @_dynamic_pack_pad_large_dispatch_1() {
  %c231104 = arith.constant 231104 : index
  %c131072 = arith.constant 131072 : index
  %c42_i32 = arith.constant 42 : i32
  %c0 = arith.constant 0 : index
  %c1 = arith.constant 1 : index
  %c32 = arith.constant 32 : index
  %c16 = arith.constant 16 : index
  %alloca = memref.alloca() {alignment = 32 : i64} : memref<32x16xi32>
  %0 = hal.interface.constant.load[0] : i32
  %1 = hal.interface.constant.load[1] : i32
  %2 = hal.interface.constant.load[2] : i32
  %3 = hal.interface.constant.load[3] : i32
  %4 = arith.index_castui %0 : i32 to index
  %5 = arith.index_castui %1 : i32 to index
  %6 = arith.index_castui %2 : i32 to index
  %7 = arith.index_castui %3 : i32 to index
  %8 = hal.interface.binding.subspan set(0) binding(0) type(storage_buffer) offset(%c231104) alignment(64) : memref<?x?xi32>{%4, %5}
  memref.assume_alignment %8, 64 : memref<?x?xi32>
  %9 = hal.interface.binding.subspan set(0) binding(1) type(storage_buffer) offset(%c131072) alignment(64) : memref<?x?x32x16xi32>{%6, %7}
  memref.assume_alignment %9, 64 : memref<?x?x32x16xi32>
  %workgroup_id_x = hal.interface.workgroup.id[0] : index
  %workgroup_count_x = hal.interface.workgroup.count[0] : index
  %workgroup_id_y = hal.interface.workgroup.id[1] : index
  %workgroup_count_y = hal.interface.workgroup.count[1] : index
  %10 = affine.apply affine_map<()[s0] -> (s0 * 64)>()[%workgroup_id_y]
  %11 = affine.apply affine_map<()[s0] -> (s0 * 64)>()[%workgroup_count_y]
  scf.for %arg0 = %10 to %6 step %11 {
    %12 = affine.min affine_map<(d0)[s0] -> (-d0 + s0, 64)>(%arg0)[%6]
    %13 = affine.apply affine_map<()[s0] -> (s0 * 64)>()[%workgroup_id_x]
    %14 = affine.apply affine_map<()[s0] -> (s0 * 64)>()[%workgroup_count_x]
    scf.for %arg1 = %13 to %7 step %14 {
      %15 = affine.min affine_map<(d0)[s0] -> (-d0 + s0, 64)>(%arg1)[%7]
      %subview = memref.subview %9[%arg0, %arg1, 0, 0] [%12, %15, 32, 16] [1, 1, 1, 1] : memref<?x?x32x16xi32> to memref<?x?x32x16xi32, strided<[?, 512, 16, 1], offset: ?>>
      %16 = affine.min affine_map<(d0, d1)[s0] -> (d1 * -32 + s0, d0 * 32)>(%12, %arg0)[%4]
      %17 = affine.min affine_map<(d0, d1)[s0] -> (d1 * -16 + s0, d0 * 16)>(%15, %arg1)[%5]
      %18 = affine.apply affine_map<(d0) -> (d0 * 32)>(%arg0)
      %19 = affine.apply affine_map<(d0) -> (d0 * 16)>(%arg1)
      %subview_0 = memref.subview %8[%18, %19] [%16, %17] [1, 1] : memref<?x?xi32> to memref<?x?xi32, strided<[?, 1], offset: ?>>
      scf.for %arg2 = %c0 to %12 step %c1 {
        scf.for %arg3 = %c0 to %15 step %c1 {
          %20 = affine.apply affine_map<(d0) -> (d0 * 32)>(%arg2)
          %21 = affine.min affine_map<(d0, d1) -> (32, d0 - d1 * 32)>(%16, %arg2)
          %22 = affine.apply affine_map<(d0) -> (d0 * 16)>(%arg3)
          %23 = affine.min affine_map<(d0, d1) -> (16, d0 - d1 * 16)>(%17, %arg3)
          %subview_1 = memref.subview %subview_0[%20, %22] [%21, %23] [1, 1] : memref<?x?xi32, strided<[?, 1], offset: ?>> to memref<?x?xi32, strided<[?, 1], offset: ?>>
          %24 = arith.cmpi sge, %21, %c32 : index
          %25 = arith.cmpi sge, %23, %c16 : index
          %26 = arith.andi %24, %25 : i1
          %27:3 = scf.if %26 -> (memref<?x?xi32, strided<[?, 1], offset: ?>>, index, index) {
            scf.yield %subview_1, %c0, %c0 : memref<?x?xi32, strided<[?, 1], offset: ?>>, index, index
          } else {
            linalg.fill ins(%c42_i32 : i32) outs(%alloca : memref<32x16xi32>)
            %30 = affine.min affine_map<(d0, d1, d2) -> (d0 - d1, 32)>(%21, %c0, %c32)
            %31 = affine.min affine_map<(d0, d1, d2) -> (d0 - d1, 16)>(%23, %c0, %c16)
            %subview_2 = memref.subview %subview_1[%c0, %c0] [%30, %31] [1, 1] : memref<?x?xi32, strided<[?, 1], offset: ?>> to memref<?x?xi32, strided<[?, 1], offset: ?>>
            %subview_3 = memref.subview %alloca[0, 0] [%30, %31] [1, 1] : memref<32x16xi32> to memref<?x?xi32, strided<[16, 1]>>
            memref.copy %subview_2, %subview_3 : memref<?x?xi32, strided<[?, 1], offset: ?>> to memref<?x?xi32, strided<[16, 1]>>
            %cast = memref.cast %alloca : memref<32x16xi32> to memref<?x?xi32, strided<[?, 1], offset: ?>>
            scf.yield %cast, %c0, %c0 : memref<?x?xi32, strided<[?, 1], offset: ?>>, index, index
          }
          %28 = vector.transfer_read %27#0[%27#1, %27#2], %c42_i32 {in_bounds = [true, true]} : memref<?x?xi32, strided<[?, 1], offset: ?>>, vector<32x16xi32>
          %29 = vector.broadcast %28 : vector<32x16xi32> to vector<1x1x32x16xi32>
          vector.transfer_write %29, %subview[%arg2, %arg3, %c0, %c0] {in_bounds = [true, true, true, true]} : vector<1x1x32x16xi32>, memref<?x?x32x16xi32, strided<[?, 512, 16, 1], offset: ?>>
        }
      }
    }
  }
  return
}


Update element-uap-visualelements.md

AppListEntry="none" should be better documented for entry points that do not need start menu tiles

@dianmsft : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"


Now able to use styles independently.

If the need comes for needing a separate stylesheet then it's possible to use one.
Still works without including it, this is just something that can be used.
I'm working on making a card component for Angular 2, but the styles wont be able to be set unless the script is imported into the head of the website using it. So it's not very inline with how Angular 2 should work.
With this though, the styles for the component can just import the card styles from the npm module, and it wont have to worry about not having the latest styles.

+1


Back-to-back commands cause erratic behavior

Hi there,
Really enjoying this plugin and appreciate your work to stabilize it over the last few releases!
When creating scenes that result in multiple commands to set shade positions, they often don't yield expected results. I have found in most cases that sending more than 1 shade position command at a time seems to freak out the Platinum Gateway.
Might I make a suggestion? In some of my previous scripts I wrote to control these shades, I implemented a queue to process the commands to the Platinum Gateway and rate-limit the shade position commands that could be sent to the gateway to only 1 command every (approx) 5 seconds. This excluded commands used to check status ($dat, etc). Note this didn't delay the first command sent by 5 seconds, but only delayed subsequent shade position commands so that only 1 was sent in a 5 second window.
What are your thoughts about making a rate-limit duration a configurable item in this plugin's configuration? Like I mentioned, 1 shade position change within a 5 second window seemed to work best in the past when executing scenes that spanned multiple rooms.

Thanks. I did put in a delay (setPositionDelayMsecs) when setting a single blind (or the virtual room blind), but haven't tried using scenes, which would definitely bypass that logic.
I currently have some logic that attempts to refresh values after setting a new position, could potentially be causing a race condition caused when using scenes. Might be worth trying to change that logic to not explicitly refresh.
 I also currently just create a new connection on each set so as to not worry about dealing with stale connections, etc, which probably exacerbates the problem.
I'll try and poke around with it in between work breaks.

Thanks for considering @schemers! HD makes so many different types of products and users have them setup in so many different configurations that I can appreciate the difficulty in trying to capture all those cases in this plugin. I think some of the stuff we're talking about could definitely be beneficial if configurable in the config.json. That might help me debug as well. I'd offer to poke through the code to see if I could contribute, but unfortunately I'm not that well-versed with nodejs. Would definitely help in any way I'm able, even if just debugging and bouncing ideas around.

I did some testing by creating a scene that sets four shades to 90%, 80%, 70%, 60%, and it failed immediately.
I added throttling in between sending set commands (5 secs), and it consistently worked.
I released 1.3.0 with the new setPositionThrottleRateMsecs option that defaults to 5000 msecs.
please let me know if it works

btw, as I was implementing, I realized what I can should probably do instead is combine setPositionDelayMsecs and setPositionThrottleRateMsecs into a single option that basically batches up all blind changes (setPositionDelayMsecs is basically doing that for a single blind-id), and then when the delay expires, make a single connection and then do all the sets at once (this is basically how the virtual blind works, it is setting all the blinds in a room at the same time within a transaction).
this would get all the blind moving a lot quicker without the 5s pause between each blind.
I'll probably work on optimizing at some point

After installing 1.3.0 it's working great. Scenes are consistently behaving.
I think where things are now is actually perfect. If only firing a single command it fires very quickly (whatever delay is set in setPositionDelayMsecs) and if firing a bunch of commands they are throttled by setPositionThrottleRateMsecs. To me, that's the best combo rather than having a single throttle/delay. I feel like a single setting might unnecessarily delay commands from being sent in cases where only 1 command needs to be sent (instead of several in a scene).
GREAT work!

glad to hear. I did try to optimize things by batching up multiple sets and attempting to do them one after the other (on the same connection) and found it to be very erratic unless the position of all shades being set was exactly the same, which explains why the virtual room shade is working fine but anything else requires a delay.
I'm going to play around with it a little more this weekend, but will most likely leave the behavior as-is since it does appear to be very stable, and I agree that both settings make sense.

That sounds consistent with what I've seen in the past.
One thing to note - a couple of my scenes include setting virtual room shades for multiple rooms at the same time. That is also now working perfectly with a 5 second delay between each room, so the throttle is not only beneficial for individual shades, but also for the virtual room shades.


Materials: normal map amount is not applied

The amount parameter for material normal maps is parsed and set as a uniform (normalAmount), but it is not actually applied in the shader (material.glsl).

@blair1618 This also appears to be the case in ES, though for good reason since the material.glsl is (near?) identical to the JS version.


Network connection interruption causes sensu-server to hang and process keepalive storm

We had some network connection issues in our environment. This causes the 3x sensu-servers to reconnect to redis & rabbitmq. Redis also reelected a new master at that time as well. 2x of 3x sensu-servers reconnected properly, the other one kept hanging and didn't executed any tasks. This caused a keepalive storm (couple thousand mails) triggered by random clients. Restarting this server process hanged as well and we used sigkill. After starting it back everything went back to normal.
Please see the LOG below of the misbehaving server:

{"timestamp":"2018-01-04T15:36:01.514381+0700","level":"info","message":"determining stale clients"}
{"timestamp":"2018-01-04T15:36:07.132487+0700","level":"info","message":"updated server registry","server":{"id":"a0087e65-82ec-4313-8fcd-b713e0f97463","hostname":"server1","address":"<IP_ADDRESS>","tasks":["client_monitor"],"metrics":{"cpu":{"user":51802.09,"system":6243.27}},"sensu":{"version":"1.0.2","settings":{"hexdigest":"9e857b0091e3997e2f1423d9d6e296089114f1bf9f1031c9c6aeab756bda1330"}},"timestamp":1515054941}}
{"timestamp":"2018-01-04T15:36:07.134287+0700","level":"info","message":"updated server registry","server":{"id":"a0087e65-82ec-4313-8fcd-b713e0f97463","hostname":"server1","address":"<IP_ADDRESS>","tasks":["client_monitor"],"metrics":{"cpu":{"user":51802.09,"system":6243.27}},"sensu":{"version":"1.0.2","settings":{"hexdigest":"9e857b0091e3997e2f1423d9d6e296089114f1bf9f1031c9c6aeab756bda1330"}},"timestamp":1515054951}}
{"timestamp":"2018-01-04T15:36:07.134487+0700","level":"info","message":"updated server registry","server":{"id":"a0087e65-82ec-4313-8fcd-b713e0f97463","hostname":"server1","address":"<IP_ADDRESS>","tasks":["client_monitor"],"metrics":{"cpu":{"user":51802.1,"system":6243.27}},"sensu":{"version":"1.0.2","settings":{"hexdigest":"9e857b0091e3997e2f1423d9d6e296089114f1bf9f1031c9c6aeab756bda1330"}},"timestamp":1515054961}}
{"timestamp":"2018-01-04T15:36:07.313510+0700","level":"warn","message":"reconnecting to redis"}
{"timestamp":"2018-01-04T15:36:07.313643+0700","level":"warn","message":"unsubscribing from keepalive and result queues"}
{"timestamp":"2018-01-04T15:36:07.313879+0700","level":"warn","message":"relinquishing server task","task":"client_monitor"}
{"timestamp":"2018-01-04T15:36:07.321407+0700","level":"error","message":"transport connection error","error":"rabbitmq channel error"}
{"timestamp":"2018-01-04T15:36:07.321467+0700","level":"warn","message":"reconnecting to transport"}
{"timestamp":"2018-01-04T15:36:10.335029+0700","level":"info","message":"reconnected to transport"}
{"timestamp":"2018-01-04T16:57:07.731659+0700","level":"warn","message":"received signal","signal":"TERM"}
{"timestamp":"2018-01-04T16:57:07.731853+0700","level":"warn","message":"stopping"}
{"timestamp":"2018-01-04T16:57:07.731898+0700","level":"warn","message":"unsubscribing from keepalive and result queues"}
{"timestamp":"2018-01-04T16:57:07.732052+0700","level":"info","message":"completing work in progress","in_progress":{"check_results":470452,"events":0}}
{"timestamp":"2018-01-04T16:58:05.735155+0700","level":"warn","message":"loading config file","file":"/etc/sensu/config.json"}
{"timestamp":"2018-01-04T16:58:05.735301+0700","level":"warn","message":"loading config files from directory","directory":"/etc/sensu/conf.d"}

LOG of a server which worked after the reconnect:

{"timestamp":"2018-01-04T15:36:07.233654+0700","level":"warn","message":"reconnecting to redis"}
{"timestamp":"2018-01-04T15:36:07.233811+0700","level":"warn","message":"unsubscribing from keepalive and result queues"}
{"timestamp":"2018-01-04T15:36:07.234761+0700","level":"warn","message":"relinquishing server task","task":"check_request_publisher"}
{"timestamp":"2018-01-04T15:36:08.237319+0700","level":"info","message":"reconnected to redis"}
{"timestamp":"2018-01-04T15:36:09.238992+0700","level":"info","message":"updated server registry","server":{"id":"05945c92-2f02-4527-8478-8078800e7635","hostname":"server3","address":"<IP_ADDRESS>","tasks":[],"metrics":{"cpu":{"user":47554.98,"system":7564.95}},"sensu":{"version":"1.0.2","settings":{"hexdigest":"9e857b0091e3997e2f1423d9d6e296089114f1bf9f1031c9c6aeab756bda1330"}},"timestamp":1515054969}}
{"timestamp":"2018-01-04T15:36:09.240448+0700","level":"info","message":"i am now responsible for a server task","task":"client_monitor"}
{"timestamp":"2018-01-04T15:36:19.239095+0700","level":"info","message":"updated server registry","server":{"id":"05945c92-2f02-4527-8478-8078800e7635","hostname":"server3","address":"<IP_ADDRESS>","tasks":["client_monitor"],"metrics":{"cpu":{"user":47554.98,"system":7564.95}},"sensu":{"version":"1.0.2","settings":{"hexdigest":"9e857b0091e3997e2f1423d9d6e296089114f1bf9f1031c9c6aeab756bda1330"}},"timestamp":1515054979}}

Expected Behavior
Not sure what was happening in the server process but letting it die if something unexpected happened would be easier to catch.
Your Environment

Sensu version used: 1.0.2
Active Sensu extensions: defaults + opsgenie handler
Operating System and version: CentOS 7
Transport and runtime versions: RabbitMQ 3.6.9, Erlang 19.2.3

Hi @chrisontoure, thanks for providing these additional details.
From reviewing your redis-sentinel.conf it looks like you have configured at least some of your sentinels to run on the same hosts where you are running Redis. I cannot fully account for the architecture or topology of your Sensu implementation, but I think it's worth noting the following from the Redis Sentinel Documentation

Fundamental things to know about Sentinel before deploying

You need at least three Sentinel instances for a robust deployment.
The three Sentinel instances should be placed into computers or virtual machines that are believed to fail in an independent way. So for example different physical servers or Virtual Machines executed on different availability zones.

I am under the impression that you have three Sentinels (per your Sensu configuration) but they do not appear to adhere to fundamental #2 as described above. This may explain, at least in part, why one of your three systems wasn't able to return to service without manual intervention.

Closing due to lack of updates on this issue. Please let us know if you have an ongoing problem after addressing the Sentinel deployment issues described in this thread.


After I stop a task with shared panel presentation, it can't run the task again because it throws an error -> Terminal with ID 1 does not exist (has it already been disposed?)

Issue Type: Bug
After I stop a task with which has
"presentation": {
                "panel": "new"
            },

I can't run the task again because it throws an error -> Terminal with ID 1 does not exist (has it already been disposed?)
Terminal with ID 1 does not exist (has it already been disposed?)
VS Code version: Code 1.22.1 (950b8b0d37a9b7061b6f0d291837ccc4015f5ecd, 2018-04-06T02:26:57.615Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-2630QM CPU @ 2.00GHz (8 x 1995)

Memory (System)
7.98GB (2.38GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

code-gnu-global
aus
0.2.2

code-runner
for
0.9.3

cpptools
ms-
0.16.1

csharp
ms-
1.14.0

cmake
twx
0.0.17

This works for me using the following task
{
    // See https://go.microsoft.com/fwlink/?LinkId=733558
    // for the documentation about the tasks.json format
    "version": "2.0.0",
    "tasks": [
        {
            "label": "echo",
            "type": "shell",
            "command": "echo Hello",
            "presentation": {
                "panel": "new"
            }
        }
    ]
}

Any additional steps on how to reproduce this?

Actually it's when the panel is shared, I copied the wrong task, my bad.

This works for me as well for "shared" tasks. Any additional steps you can provide. Best would be a GitHub repository that I can clone that demos the problem.


Feature/311 modal   regular takeover and slidein

👋 Thanks for creating a pull request! 🚀 Checkout the storybook we created for it here.


Improve operator/pkg/object code coverage

Part of https://github.com/istio/istio/issues/21870
pkg/object	                        30.6%  --> 40.0%
[X] Test and Release
[X] Does not have any changes that may affect Istio users.

@kebe7jun: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
e6d1c16bccd9a6b0e70d2e1b6da792b244be1071
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
e6d1c16bccd9a6b0e70d2e1b6da792b244be1071
link
/test lint_istio

gencheck_istio
e6d1c16bccd9a6b0e70d2e1b6da792b244be1071
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
e6d1c16bccd9a6b0e70d2e1b6da792b244be1071
link
/test gencheck_istio

lint_istio
d154a701e4e86f2fb243d4f7eb80a50ee88dcb6d
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
d154a701e4e86f2fb243d4f7eb80a50ee88dcb6d
link
/test lint_istio

gencheck_istio
d154a701e4e86f2fb243d4f7eb80a50ee88dcb6d
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
d154a701e4e86f2fb243d4f7eb80a50ee88dcb6d
link
/test lint_istio

gencheck_istio
b88be1011500fbcfe2fd9625f71448d83edc972f
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
b88be1011500fbcfe2fd9625f71448d83edc972f
link
/test gencheck_istio

lint_istio
b88be1011500fbcfe2fd9625f71448d83edc972f
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

lint_istio
b88be1011500fbcfe2fd9625f71448d83edc972f
link
/test lint_istio

gencheck_istio
99668c07bc3243fdf6342278b64509ebf34f5151
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
99668c07bc3243fdf6342278b64509ebf34f5151
link
/test gencheck_istio

lint_istio
99668c07bc3243fdf6342278b64509ebf34f5151
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kebe7jun: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-multicluster-tests_istio
f4374f4209e9b807059a64dc476079e3ca795e94
link
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-multicluster-tests_istio

@kebe7jun: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
f4374f4209e9b807059a64dc476079e3ca795e94
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-mc-k8s-tests_istio

@kebe7jun: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-telemetry-mc-k8s-tests_istio
f4374f4209e9b807059a64dc476079e3ca795e94
link
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-mc-k8s-tests_istio


Update session-host-update.md

Remove a known issue, add a known issue

@dknappettmsft
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


add jq and terraform tool

Hi,
Ref. #136
This PR is proposal to add terraform tool in VSTS Agent Ubuntu Docker Images. It is very popular tool and we currently use it alot in VSTS pipelines for deploying Azure infrastructure. This PR also adds jq tool for convenience, since it's also very popular and used to help determine current terraform version in this proposal.
FYI both kubectl and helm is already included in the image, but also have supported deploy and tool tasks in VSTS. Terraform currently don't have any official VSTS task yet. This is justification for adding the tool to the image. Thanks for your consideration,

Hi @joakimhellum-in.  Thanks a lot for contributing this.  I just discovered that jq is already installed through this base dockerfile.  So I think it can be removed from this PR.
Also, PR #133 is adding lots of other tools and should get merged very soon.  Please let me know if you'd rather I just include your Terraform installation script in that PR.  I tested your script and it works great.
Thanks,
David

@DavidStaheli Sorry I missed jq. Yes, agree it's probably better to just include this in PR #133, since I was not able to properly run the update.sh scripts etc. for this PR, because of what was added in #132.  Thanks alot.

All looks fine to me. The PR linked by @DavidStaheli now carries Terraform and jq is not needed
I will probably be moving away from requiring updates to the template and running update.sh. It is there to support easily building both 14/16 base images, but I am not sure anyone is preferring to use 14 over 16, so it may go away soon and thus we wont need to update multiple files. Thats a separate issue though.


Add/fix some tests, plus some cleanup and formatting

Add two simple tests per suggestion from @chriscoey

Looks good, thanks Jian!

thanks, but not sure why two tests are failing. attempted to fix with issetequal() but still not working. all tests are passing on my local.
Test Summary:                      | Pass  Total  Time
SolverAPI                          |   43     43  0.9s
test                             |   43     43
test/solve_tests.jl            |   43     43
solve                        |    7      7  0.5s
feas_range                 |    1      1  0.1s
min_range                  |    1      1  0.0s
tiny_min                   |    1      1  0.0s
tiny_feas                  |    1      1  0.1s
tiny_infeas                |    1      1  0.1s
simple_lp                  |    1      1  0.0s
n_queens                   |    1      1  0.1s
print                        |    6      6  0.0s
validate                     |   30     30  0.0s
feas_with_obj              |    2      2  0.0s
min_no_obj                 |    2      2  0.0s
unsupported_sense          |    2      2  0.0s
obj_len_greater_than_1     |    2      2  0.0s
incorrect_range_num_params |    2      2  0.0s
incorrect_range_step_not_1 |    2      2  0.0s
vars_is_not_str            |    2      2  0.0s
vars_is_not_arr            |    2      2  0.0s
objs_is_not_arr            |    2      2  0.0s
cons_is_not_arr            |    2      2  0.0s
missing_vars               |    2      2  0.0s
missing_cons               |    2      2  0.0s
missing_objs               |    2      2  0.0s
missing_sense              |    2      2  0.0s
missing_version            |    2      2  0.0s

This is done, but marking as draft so we don't merge before https://relationalai.atlassian.net/browse/RAI-16251 is fixed.
after this, to run JuliaFormatter, you just do format(".") (it uses the new JuliaFormatter.toml to keep things consistent). we could add a CI run to check the format before merging, like we do over at CSP2SAT.jl

Sorry to squeeze in multiple changes in one PR - got a little carried away 😄


Added Support For .resource Files

Do you intend to add a new feature or change an existing one?

Suggest your change by creating an issue (unless one exists already) on the issues page and start writing code.

Existing Issue present at:
https://github.com/tomi/vscode-rf-language-server/issues/47#issue-436560293

Open a new GitHub pull request with the patch.

Ensure the PR description clearly describes the problem and solution. Include the relevant issue number if applicable.

Problem:
Extension does not currently support .resource files, which are parsed identically to .robot files.
Solution:
Add .resource to parser list with .robot parser

Before submitting, please ensure that
The code has been formatted and passes linting (npm run lint)

:heavy_check_mark:

A test case has been added and it passes (npm run test)

:heavy_check_mark:

Hi and thank you for your PR. All contributions are highly welcomed! I will merge this PR, but there few other configurations that are still needed (mainly on the client) for full support of .resource files. I'll add those and publish a new version.


Not Issue

Hi
First of all thank you for this tool, it's amazing!
I just want to ask you what is the best way to update?
I apologize if I wrote in the wrong place
Cheers

Hi there, the best to update is to simply run the command gem update aquatone. This will pull down the latest version from rubygems.org.
Cheers


Enabling SSIL causes error spam in scenes with SubViewport when SubViewport.size is too small

Tested versions
Reproducible in 4.2.1 stable
System information
Godot v4.2.1.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1650 SUPER (NVIDIA; <IP_ADDRESS>17) - AMD Ryzen 5 1600 Six-Core Processor (12 Threads)
Issue description
Under certain conditions the editor starts spamming error messages:
Too many mipmaps requested for texture format and dimensions (6), maximum allowed: (5).
  drivers/vulkan/rendering_device_vulkan.cpp:8627 - Attempted to name invalid ID: 0
  servers/rendering/renderer_rd/storage_rd/render_scene_buffers_rd.cpp:75 - Condition "p_named_texture.texture.is_null()" is true.
  drivers/vulkan/rendering_device_vulkan.cpp:3317 - Parameter "src_tex" is null.
  servers/rendering/renderer_rd/storage_rd/render_scene_buffers_rd.cpp:419 - Condition "named_texture.texture.is_null()" is true. Returning: RID()
  Texture (binding: 0, index 0) is not a valid texture.
  ./servers/rendering/renderer_rd/uniform_set_cache_rd.h:129 - Condition "rid.is_null()" is true. Returning: rid
  drivers/vulkan/rendering_device_vulkan.cpp:7970 - Parameter "uniform_set" is null.
  Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
  Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
  Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
  Uniforms were never supplied for set (3) at the time of drawing, which are required by the pipeline
  servers/rendering/renderer_rd/storage_rd/render_scene_buffers_rd.cpp:419 - Condition "named_texture.texture.is_null()" is true. Returning: RID()
  Image (binding: 0) should provide one ID referencing a texture (IDs provided: 0).

Conditions seem to be:
WorldEnvironment is present and SSIL is enabled
SubViewport (with Camera attached) is present and both x and y values of Subviewport.size property are smaller than 32 px (so for example 1x32 px will work fine, 1x31 will not).
Steps to reproduce
Create new project and build this hierarchy:
Node3D
    ┠╴WorldEnvironment
    ┖╴SubViewport
       ┖╴Camera3D

Add default environment, enable SSIL. Go to SubViewport, set both x and y values of size property to be smaller than 32 px. Errors should start to appear even without running the project.
Minimal reproduction project (MRP)
SSILbug.zip

This is likely because viewport mipmaps are generated, but the operation fails if the viewport size is too low (presumably because the engine always tries to generate 5 mipmaps: 1×1, 2×2, 4×4, 8×8, 16×16).

I've encountered this same error spam when SSAO is the only enabled option. GridContainer and FlowContainer seem to handle the SubViewportContainer strangely, so it was getting crushed to 1x1 without me realizing and causing debug build to hang.

On older hardware, I have encountered the same sort of errors if SSIL is enabled when the project is first opened. No errors if enabled after the project has been opened.


i18n(de): update translation overriding-components

Description
Translation of guides/overriding-components.mdx into German language.
Participating in Hacktoberfest!

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

de
guides/overriding-components.mdx
Localization added, will be marked as complete.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.


Added edgeBasePath to config docs

@vfalon @srhoades-adobe This PR is ready for review and merge. Thanks!

Closing the PR and merging from the internal repo.


Mole Fraction Calculator

Hey @Srijita-Mandal , I would like to open this issue under JWOC. I wish to add a calculator to calculate mole fraction given by the formula:
amount of a constituent in moles / total amount of all constituents in a mixture in moles
Kindly assign 😀

@ritika728 go for it.


(3) Adding Second Layer of SDK Functionality

Following the step two - we can decide on what is the best layer to add following that is beneficial as a VIM user to pair with the Pieces Copilot, or the Save a reuse functionality around snippets with another set of tools in Pieces OS Client.

[ ] Select Second layer of functionality
[ ] Add second set of functionality to the VIM plugin
[ ] Add documentation to the readme with new additions made
[ ] Add simple tests
[ ] Record a Video of the VIM plugin in action
[ ] Write an article about your build experience

If I could make a recommendation for two feature requests:

Please add the capability to add as a Telescope extension for Neovim. Telescope's fuzzy searching capability w/previews would work well with Pieces' snippet search and preview functionality.
Add the ability to autocomplete snippets using nvim-cmp.


Salute & Query

Hello, congratulate for your work in AAAI 2022, and could you offer the code of "STDEN: Towards Physics-guided Neural Networks for Traffic Flow Prediction" because i want to use the newest state-of-art work to be the baseline of the future work. I will appreciate it very much if it can be offered.

Sorry for the late reply, we are collating the code and will get back to you with the link after the open source. You can follow the first author of the paper Echo-Ji .


[BUG] Games aren't downloading

Describe the bug
I went to download skyrim and the download was not always at 0%
Steps to Reproduce
It doesn't have
Expected behavior
It doesn't have
Screenshots

Operating System
windowns 10
Hydra Version
latest
Additional Information
No response

In steamdeck same problem since Leviticus

Also have the same issue in Linux Mint

Same, win 11

Same, win 11

I am having the same problem, win 11

win 10 tiene el mismo problema

Same issue on steam deck after leviticus update

i dont know if this will work for you guys, but i uninstalled the hydra and reeinstaled for all users on my PC, when i start the launcher i start as admin and it works perfectly. i hope this help tou guys!!!

i dont know if this will work for you guys, but i uninstalled the hydra and reeinstaled for all users on my PC, when i start the launcher i start as admin and it works perfectly. i hope this help you guys!!!

Didn't help(

Could you attach your logs? They are located in "%appdata/hydra/logs"


pip install conflict

I encountered this from 'pip install -r requirements'.
ERROR: Cannot install -r requirements.txt (line 41) and SQLAlchemy==2.0.12 because these package versions have conflicting dependencies.
The conflict is caused by:
The user requested SQLAlchemy==2.0.12
langchain 0.0.142 depends on SQLAlchemy<2 and >=1
Any idea on how to resolve the conflict between langchain 0.0.142  and SQLAlchemy 2.0.12 ?

Ciao,
you can try to install the latest version of Langchain
pip install langchain==0.0.193

or remove SQLAlchemy from the requirements.txt
It will choose the compatible version (unless is going to use the cached wheel on your pc...)
keep me updated

Thanks.  This resolved the conflict.


Helm 3.x on Windows does not provide any output

Output of helm version: nothing (should display 3.0.2)
Output of kubectl version: Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.0", GitCommit:"e8462b5b5dc2584fdcd18e6bcfe9f1e4d970a529", GitTreeState:"clean", BuildDate:"2019-06-19T16:40:16Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"windows/amd64"}
Installing an using Helm3 on Windows does not return any output. (i.e. version, help, list, etc.)
Using Helm2 it works and displays output accordingly.
Could you please help.
Thanks
Best regards
miracle152004

helm 3.02 linux-amd64 on linux is also not providing any input. i tried version, help etc...

possibly related to https://github.com/helm/helm/issues/6863.

What happens if you add the --debug flag?

yeah is the same issue:
D:\Temp>helm3.exe --debug
helm.go:71: [debug] error loading config file "[Userdirectory]/.kube/config": yaml: line 6: found a tab character that violates indentation

Thank you, that was essentially the issue. Running with --debug got me "permission denied"
on my kubeconfig file. So almost the same thing. I woulda never guessed permission denied since I thought that would show up for sure. I thought the binary was just being unresponsive.

closing as a duplicate of #6863.


Support for Contenteditable

I want to combine Rivets.js with something like Hallo.js to create an editor based on Contenteditable.
After some research it doesn't seem enough to create a custom binding as suggested by @mikeric here: http://stackoverflow.com/questions/12302131/rivets-js-and-contenteditable
That's because the code directly goes to the adapter.publish instead of the proper (?) binding.publish, resulting in things as view-to-model formatters (https://github.com/mikeric/rivets/pull/90) not being called.
Perhaps a better way (please keep in mind my knowledge with Rivets is 1 day old) would be to adapt the 'getInputValue'-funciton in Rivets to check for Contenteditable?

@terrancesnyder Tried your solution, but does not seem to work: the binder function is never executed (breakpoint not hit when in debugger), though the binder seems to be available when having a look at the rivets.binders array.
Should it work with the latest rivets version?

Here is a full example : https://jsfiddle.net/jccazeaux/be2meL8g/


Intermittent test failure: test_read_region_cpu_memleak[testimg_tiff_stripe_4096×4096_256_deflate]

I am seeing an error message regarding cpu memory usage:
https://github.com/rapidsai/cucim/actions/runs/6698898284/job/18202421711?pr=620

It is likely that it is intermittent issue (may need to increase the threshold ><PHONE_NUMBER> -<PHONE_NUMBER> = 50540544).

Originally posted by @gigony in https://github.com/rapidsai/cucim/issues/620#issuecomment-1786179731

Addressed by https://github.com/rapidsai/cucim/pull/623
Closing this.


Text inside copy button not properly visible

I think the color of the text " Copy" Inside button should be white, and not blackish.

Sorry for the huge delay on replying.. Yes, I agree. Can you make the changes and submit a PR? @ajayanuragi

Yes, I will

Yes, I will

Thank yiou.

@ajayanuragi Any update? also the text is actually black when you hover over it

fixed in #22


MassTransit subsciber fails to consume messages published by a publisher build with native azure service bus api

Is this a bug report?
YES

Can you also reproduce the problem with the lastest version?
YES
Environment
Operating system: Windows 10 Enterprise
Visual Studio version: Professional 2017 v15.6.2
Dotnet version: NET4.7.1

Operating system: Windows 10 Enterprise
Visual Studio version: Professional 2017 v15.6.2
Dotnet version: NET4.7.1

Steps to Reproduce

(Write your steps here:)

download attached project : https://github.com/JakubSurfer/MassTransit-AzureServiceBus-pub-sub
fill in connection string to your azure service bus ( AzureServiceBusConfiguration.cs)
Run MassTransitDemo.ASBPublisher and MassTransitDemo.Registration.Service

Expected Behavior

MassTransitDemo.Registration.Service should consume messages sent by ASBPublisher but it fails.
If you run MassTransitDemo.Publisher (It is publisher based on Mass Transit) and MassTransitDemo.Registration.Service , the messages are consumed by a subscriber properly.
Actual Behavior

MassTransitDemo.Registration.Service should consume messages sent by MassTransitDemo.ASBPublisher but it fails with such exception :
MassTransit.AzureServiceBusTransport.Transport.Receiver Error: 0 : Received faulted: 43d2f132ea034115ac6916fce77206a6, System.ArgumentException: The remote server returned an error: (400) Bad Request. The specified HTTP verb (GET) is not valid. -> System.Net.WebException: The remote server returned an error: (400) Bad Request.
Reproducible Demo

Here is a repo with project : https://github.com/JakubSurfer/MassTransit-AzureServiceBus-pub-sub

You need to either support the message format required by MassTransit, and format your message appropriately, or write your own message deserializer.
http://masstransit-project.com/MassTransit/advanced/interoperability.html

@phatboyg How do you setup the customer deserializer? Looking for a good example, so far unable to find any...

I have added my own deseriliazer and messages are getting received by the consumer, however I can't get message content from consumer context (apparently it is not getting deserialized properly).

It sounds like your deserializer isn't properly handling the various message types, that would be my guess.


Latest master commits not on crates.io

Hello and thank you for the hard work you have put into this crate!
I noticed that the latest commits to the master branch are 8 months old and have not yet been released on crates.io. The new_custom() method has been added to the various digests since the last release, and I think it would be useful to have this method available via downloads from crates.io.
Would it be possible to create a new release? I would be more than happy to help out in anyway possible if there are outstanding issues that need to be resolved first.
On a related note, would you be okay with me opening a pull request to address clippy lint warnings? The changes necessary to resolve the warnings are very minimal and shouldn't require much effort to review.

Thanks for the note. I'm looking into getting #42 merged. Please feel free to help review or open PR for the warnings. Look forward to making a release afterwards.

Excited to release a crate using new_custom and am also eagerly awaiting a release. Thanks for the excellent crate.

#42 landed in a state that requires major version bump and some v2 API changes are still in discussion. Released the commit before as v1.9.0 which includes some new APIs. Sorry for the delay and hope it's still useful.

Sorry to see 1.9 yanked but obviously understand. Any chance of a 1.8.2 with new_custom?

Unfortunately the change that adds new_custom contains a breaking change on update func. Maybe your use case could pin to git & sha instead of cargo release?

@mrhooray, is it worth pushing the new_custom and #42 changes as 2.0.0?
The v2 API being discussed in #48 will probably take quite a bit of time to materialize. Also, I think it's better to wait for const generics and const fns to land in stable Rust before considering significant API changes.

Or let's identify a subset of the v2 API changes that can easily be implemented (such as using core::hash::Hasher trait, separating Algorithm and Crc).
A generics-based API can be pushed to v3.

Or let's identify a subset of the v2 API changes that can easily be implemented (such as using core::hash::Hasher trait, separating Algorithm and Crc).
Great idea to enable full customization sooner.

A generics-based API can be pushed to v3.
Is that mainly due to const fn/generics considerations? If so, would you consider developing Algorithm and Crc based API with generics first, and then add support for it when required language features stablize?

If so, would you consider developing Algorithm and Crc based API with generics first, and then add support for it when required language features stabilize?

That could work. I'll open a [WIP] PR in a couple days.


Initial refactoring to enable Azure cloud environment awareness

Which issue this PR addresses:
Fixes 7361254
What this PR does / why we need it:
No-op change to replace hardcoded, Azure cloud environment-specific domains with configurable ones.
Test plan for issue:
Run existing unit and E2E tests.
Is there any documentation that needs to be updated for this PR?
No

/azp run e2e

/azp run e2e

/azp run ci

/azp run ci

@jim-minter I think this is ready for another look


Sc-6975: improve reauthentication feature

Scope of changes
Sc-6975: improve reauthentication feature
Type of change

[x] bug fix
[ ] new feature
[ ] documentation
[x] improvement

Acceptance criteria
Describe how reviewers can test this change to be sure that it works correctly. Add a checklist if possible
Author checklist

[ ] I have manually tested the change and/or added automation in the form of unit tests or integration tests
[ ]  I have updated the dependencies list
[ ]  I have recompiled and included new protocol buffers to reflect changes I made
[ ]  I have added new test fixtures as needed to support added tests
[ ]   Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
[ ]  I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

[ ] Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.

Codecov Report

Merging #626 (bb4065d) into main (a859adc) will decrease coverage by 7.90%.
 Consider uploading reports for the commit 4ade14d to get more accurate results

@@            Coverage Diff             @@
##             main     #626      +/-   ##
==========================================
- Coverage   46.00%   38.10%   -7.91%
==========================================
  Files         550      155     -395
  Lines       16162     2433   -13729
  Branches     1201      615     -586
==========================================
- Hits         7435      927    -6508
+ Misses       7597     1330    -6267
+ Partials     1130      176     -954

Impacted Files
Coverage Δ

...s-user-ui/src/application/routes/LandingOutlet.tsx

...s-user-ui/src/application/routes/PrivateOutlet.tsx

...ds-user-ui/src/components/NeedsAttention/index.tsx

...b/gds-user-ui/src/components/Sidebar/MobileNav.tsx

...omponents/TestnetProgress/CertificateStepLabel.tsx

web/gds-user-ui/src/hooks/useAuth.ts

web/gds-user-ui/src/hooks/useCertificateStepper.ts

web/gds-user-ui/src/hooks/useCustomAuth0.ts

web/gds-user-ui/src/layouts/DashboardLayout.tsx

.../gds-user-ui/src/layouts/SimpleDashboardLayout.tsx

... and 385 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a859adc...4ade14d. Read the comment docs.


Support 1.21.1

Attempting to launch this mod using 1.21.1 Fabric results in the following error
Incompatible mods found!
net.fabricmc.loader.impl.FormattedException: Some of your mods are incompatible with the game or each other!
A potential solution has been determined, this may resolve your problem:
	 - Replace 'Minecraft' (minecraft) 1.21.1 with version 1.21.
More details:
	 - Mod 'Inverse Phantoms' (inverse_phantoms) v1.1.0+mc1.21 requires version 1.21 of 'Minecraft' (minecraft), but only the wrong version is present: 1.21.1!
	at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:51)
	at net.fabricmc.loader.impl.FabricLoaderImpl.load(FabricLoaderImpl.java:196)
	at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:146)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)

This can be replicated with only this mod and fabric loader 0.16.2 installed
Ignore the above, I misread the error and version. Would you be interested in updating the mod for 1.21.1?

yea, this should be rlly easy actually, ill do it rn

its fixed with the most recent commit, ill update it on modrinth !

uploaded here https://modrinth.com/mod/inverse-phantoms/version/WpzUHfTZ !


Allow OR in rules

e.g.
  var commands = {
    'show||display tps report': function() { $('#tpsreport').show(); }
  };

+1

+1

Version 2.0.0 released yesterday supports regular expressions which should allow for all the cases described above.
@BoKu , @alanjames1987 , @Glavin001 , @gitnik  - I would love your feedback on the new feature - https://github.com/TalAter/annyang/releases/tag/v2.0.0

Awesome, regex support is great! Thanks!

@TalAter That is a great way to add these and many more features. Thank you.

:+1: Awesome.


mounter(ticdc): do not report error is verify old value checksum v1 failed

What problem does this PR solve?

Issue Number: close #11468
What is changed and how it works?

if verification on the old value checksum v1 failed, just skip it, print some logs to warn it.

Check List
Tests

Unit test
Integration test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
`None`

/retest


Will _unicodefun._verify_python3_env be removed in v8.0.0?

Hi all,
Not sure why, but pip grabbed v8.0.0a1 (pre-release) from PyPI as a dependency for another package. That package is using _unicodefun._verify_python3_env - which seems to be removed from v8.0.0a1. Reverting to version 7.1.2 fixed the problem for me for now, but will this function not be present in v8.0.0a1 - or maybe it has been moved?
Thanks!

If you pulled 8.0.0a1 without asking, you have a very old version of pip and you should upgrade, or you used easy_install and you should use pip.
The function you're referring to is still present, I'm not sure why you're seeing otherwise. I just confirmed it's importable with 8.0.0a1 installed. That said, you should never be interacting with that module or function directly, it's marked internal.

If you pulled 8.0.0a1 without asking, you have a very old version of pip and you should upgrade, or you used easy_install and you should use pip.
The function you're referring to is still present, I'm not sure why you're seeing otherwise. I just confirmed it's importable with 8.0.0a1 installed. That said, you should never be interacting with that module or function directly, it's marked internal.


Enable bf16 in ernie3.0

PR types

New features
PR changes

Models
Description

Adds the possibility to use the bfloat16 datatype in the ernie3.0 model.

@jczaja Please review

@jiangjiajun , @Aganlengzi please start your review

@yeliang2258  Could you please approve this PR. This adds Ernie-3.0 bf16 option.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@piotrekobi Thanks for your contributions!


Deleting a horizontal rule from editor doesn't work properly or at all

The behaviour around deleting a horizontal rule in the editor doesn't work that well. What I would expect is that when you insert a
 tag using insertHTML('
'), you can use backspace to delete the HTML, but this behaviour doesn't really work as expected. The only way I can really seem to get it to delete would be to highlight everything and try and get rid of it that way.

+1
@neilj Is the logic hidden in keyHandlers.backspace method?

So i tested it a little bit and have some results. I've used the following code implement it:
editor.insertHorizontalLine = function () {         const horizontalRule = this.createElement('HR');         this.insertElement(horizontalRule);     };

you can't delete HR by pressing backspace when it is the first element of contenteditable. So the code block would be

. In such case you can delete if only If you select all text and press backspace
you can delete HR when it's not the first element of contenteditable, but you should press twice to delete it, because of the BR element, which is placed right after HR block. HTML block is
some text

@neilj Hi! Have you had a time to take a look?


README update

AC

[x] There is typo in this section pointing different repo https://github.com/steemit/devportal-tutorials-js#to-run-one-of-the-tutorials
[x] List missing new tutorials

Closed in other stories.


Disabling announcements feature

I tried to disable the announcement feature with https://github.com/getferdi/ferdi/commit/1a6017c81d3a8fc385b0f637ce5a7417ee768e9a (until we have our own announcements coming from our own server), but it is still making requests to the announcements API. Moreover, it seems to be making the request every time I switch services, which can slow things down.

Just as an information: Ferdi will always fetch the announcements from the server you select - we do already have announcements coming from api.getferdi.com, e.g. I created an announcement for 5.4.0.

I think it's preferable to get the announcements from the Ferdi API then as to not cause confusion to Ferdi users with Franz API announcements?

Yes, I think your idea is better.

I just looked into this: You havn't actually disabled announcements with 1a6017c:
You only disabled the local default settings. These settings will be overwritten by the server's settings in the store. The ferdi-server will enable announcements again.
You could add an option to the settings store to disable announcements on the client side.

@vantezzen Understood, thanks for the explanation; I reverted and let it enabled in the local default settings now the announcements are always coming from Ferdi's API.


Run tests in parallel with vsts-task and Selenium Grid

Hello,
I'm using TFS on-premises.
I have an agent installed on a machine with 2 processors.
I use a build definition to run selenium webdriver tests in parallel over a Selenium Grid setup. The step to run the tests is Visual Studio Test version 1.
The problem is that no matter the number of nodes on Selenium Grid, only 2 tests will run at a time (the tests are sent, randomly,  to all the nodes, but maximum 2 at a time).
Is there a setting that i'm missing or is there a limitation of the vsts-task to send only 2 dll's (equal with the number of processors of the host agent machine) to the selenium grid?

@azarj Currently there's a limitation on the parallelism possible with vstest runner. It is limited to the number of processors.

I'm new working with the tfs, I'm trying to run tests from tfs in selenium grid, but I don't know if this is possible.


refresh with code flow

When useHttpBasicAuth is set to true, refreshToken() doesn't consider this flag and it always appends client-id and client-secret to params instead of headers in BasicAuth.
Thanks

will work with version 9 which lands soon. Please recheck after that.

Hi, thanks so much. I will test when it is updated.


dribbble_config_play.properties (系统找不到指定的文件。)

the same issue

编译时报错，Error:(66, 0) dribbble_config_play.properties (系统找不到指定的文件。)
Open File

@LegendBMKill  how do you solve this issue

Sorry, it's my fault. I only tested deleting the dribbble_config_play.properties within the original project, but not a clean repo cloned from GitHub.
I've updated the project. You should be good to go now.


Bad kerning in SourceSansVariable-Italic.ttf

I'm getting bad kern pairs when building the variable TTF version of Source Sans Pro italic with fontmake version 1.7.4. The CFF2 version built from the same source files does not have this problem.

SourceSansVariable-Italic.ttf.zip
SourceSansVariable-Italic.otf.zip
The source files are at https://github.com/adobe-fonts/source-sans-pro/tree/fontmake
The build command used was
fontmake -m Italic/Masters/SourceSansVariable-Italic.designspace -o variable --output-path SourceSansVariable-Italic.ttf

I traced this back to changes introduced in ufo2ft v2.0.0 https://github.com/googlei18n/ufo2ft/issues/280

please refer to my explanation in googlei18n/ufo2ft#280


vscode should warn on bad tslint.json format

A miss-placed comma in the json file cost my an hour of debugging. Perhaps vscode could pass on the error generated:
 ./node_modules/.bin/tslint -c tslint.json --project .
Failed to load client/tslint.json: Unexpected string in JSON at position 699 in client/tslint.json

/needsMoreInfo
Could you please provide example of wrong JSON content?
VSCode warns about invalid JSON (even in JSON with comments)

The below offending tslist.json file:
{
    "defaultSeverity": "error",
    "extends": [
        "tslint:recommended",
        "tslint-sonarts",
        "tslint-consistent-codestyle"
    ],
    "jsRules": {},
    "rules": {
        "arrow-parens": [true, "ban-single-arg-parens"],
        "curly": [true, "ignore-same-line"],
		"max-classes-per-file": { "options": 1 },
        "member-ordering": false,
		"member-access": false,
        "no-console": false,
		"no-empty": false,
        "object-literal-sort-keys": false,
        "ordered-imports": false,
		"radix": false,
        "prefer-for-of": false,
        "max-line-length": [true, 130],
        "cognitive-complexity": [true, 12],
        "array-type": [true, "array"]
        "naming-convention": [
            true,
            { "type": "default", "format": "camelCase" },
            { "type": "property", "modifiers": ["public", "static"], "format": "UPPER_CASE" },
            { "type": "class", "format": "PascalCase" },
            { "type": "interface", "format": "PascalCase" },
            { "type": "enum", "format": "PascalCase" },
            { "type": "variable", "modifiers": ["global", "const"], "format": ["camelCase","UPPER_CASE"] }
        ]
    },
    "rulesDirectory": []
}

Works as expected from me for both JSON and JSON with Comments types of file

Is it reproducible without extensions?
You can try this with F1 and >Developer: Reload Window With Extensions Disabled

I am afraid you misunderstood the problem :oD. The tslint extension fails silently because of a bad tslint.json config file.

tslint extension fails silently

This is the first mention of extension that causes problems.
Please report against extension that you use (most likely it is https://github.com/Microsoft/vscode-typescript-tslint-plugin/issues)
/causedByExtension


Allow specifying the base url

Allow overriding the URL where packages are stored (useful for e.g. when using internal package repositories)

It can be usefull, Thanks.


Many to Many Issue And batch size issue

Hi I am using cql 3.0 version.
I have Persmission and role table with many to many relationship. When i try to insert persmission and role is creating records successfully.
But While inserting role_permission table automatically "key" cloumn added in the insert query.
Ex:
BEGIN BATCH INSERT INTO "role_permission" (key, "persmission_id", "role_id") VALUES('1c7877e0-72df-11e7-af70-39f553d29ed4ROLE', 1c7877e0-72df-11e7-af70-39f553d29ed4, 'ROLE');
I dnt know where kundera taking key as cloumn. I didn't create any cloumn as key.
And then when i add the batch query size in persistence-unit role_persmission insertion not happening.
Please help me on this.
Thanks,
Prasanth

Hi @prasanthdreamjava,
Please share your sample POJO class and persistence.xml along with Kundera and Cassandra version.
-Dev


chore: workflows/check run on the workflow_dispatch event

Which issue does this PR close?
Closes #
Rationale for this change
To run a workflow manually, the workflow must be configured to run on the workflow_dispatch event.

What changes are included in this PR?
Modify workflows/check.yml to run on the workflow_dispatch event.
Refer to https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow.

Are there any user-facing changes?
No.

How does this change test
No need.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@a66e067). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #119   +/-   ##
=======================================
  Coverage        ?   39.80%
=======================================
  Files           ?       29
  Lines           ?     3432
  Branches        ?        0
=======================================
  Hits            ?     1366
  Misses          ?     1882
  Partials        ?      184

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


AttributeError: 'HtmlResponse' object has no attribute 'data'

yield scrapy_splash.SplashRequest("https://example.com", self.parse,
endpoint='execute',
args={'lua_source': script, 'wait':60})
Lua script returns:
return {
html = splash:html(),
cookie = cookies

}
But parse, only read response.body. I tried with render.json (not execute), iframes, response.data['cookie'] (AttributeError: 'HtmlResponse' object has no attribute 'data')
I have tried to save from Lua script the data to windows filesystem, but the file doesn't appear.
Inside of Lua script there is redirecting, perhaps it produces differences between reponse.body and the tool from http://localhost:8050 (left html output).
Another question is the format png, it is a white page, but i have website has changed by har, could it be a not full load of javascript or redirecting again?
Any solution?
i see something as
https://github.com/scrapinghub/splash/blob/master/splash/tests/test_response_tracking.py
 -> resp = self.request_lua("""

I would like something similar from response, with yield scrapy_splash.SplashRequest and the callback parse
Sorry, if that is not a technical question.
Regards.
Javier Ruano.

@JavierRuano Have you had any luck so far?

any news?


enable tests on RN 0.71

I think that there is an issue with Detox and RN 0.71, and my next step is to reproduce it in as close to the upstream testing environment as I can. I will open an issue for this if the test fails in the way that I expect that it will. I apologize for the PR noise!

Description

This pull request addresses the issue described here: (none)

In this pull request, I have enabled tests against React Native 0.71.

For features/enhancements:

[ ] I have added/updated the relevant references in the documentation files.

For API changes:

[ ] I have made the necessary changes in the types index file.

I will now close this. Evidently, my local testing was incomplete, as one of the 0.71 apps passed…
Thank you all for Detox!


Adding Dice_Combination Problem

ISSUE NUMBER- #1565
LINK-> #1565

cannot solve multiple issues in same PR.


Support for String ValueMap on columns

First thank you for the great plugin.
it would be great to have a column styling option like in grafanas original table.

Hi @peynman , Thanks for the feedback.
Could you provide more details about your requirement?
Boom table has all the "column style" features in "Patterns" tab. You can set, thresholds, do transformations, Set  column header, set type,  set unit, set decimal, Set decimals, etc but only for Numbers.
This panel doesnt support "strings and date" yet.  I couldn't see any solid use case for this. If you provide more details about your use case, I am happy to help

I am rending some stats on product categories and these stats are stored in graphite with their Ids in app database, so when rendering these reports I need to either use graphite alias function ( which I cant since I have too many categories and if I use alias for all of them I ran out of space in my query ) or use a string value map on my metrics column.
Do you think it would be possible to attach column styles from default table to Boom table.
I am facing the same problem with pie charts too :/

Suppose your metric is A.B.C.XXXXX.YYYYYYY.ZZZZ.aaa.bbb.somemetric  assuming XXX , YYY and ZZZ are unique columns,
and if you need your output like Product XXXX (aaa) Product type ZZZ as your row names, then specify Product _3_ (_6_)  Product type  _5_ in the row name in pattern tab. here 3 , 6 and 5 represents the index of metric name delimited by dot.
If my understanding is correct, above method will help. Feel free to revert back if this didnt solve or you are not convinced. Happy to help.

it would be helpful to find solution if you give some screenshots /mock.

my metric keys are like:
com.example.1.metric.something
com.example.2.metric.another
com.example.3.metric.someother
...
and those numbers are product ids in a mysql table with titles, I want to replace the numbers with those titles.

Hi @peynman . It seems this can be done if the title is part of the metric. Otherwise not possible with the current implementation. ( If you have few metrics, thats possible ). If you are using graphite 1.1+, you can use tags to achieve this.

Hi @peynman  - Have you checked latest version?  We have a feature called "Transform value overrides". This is something similar to what you are looking for. ( But still does transformation only on values. Not on row and col names)
https://github.com/yesoreyeram/yesoreyeram-boomtable-panel#transform-value-overrides

since I am displaying my Grafana panels over a proxy(iframe) in my admin panel,
I have solved this issue by overriding column names in the proxy server (I changed the response from Grafana and displayed my version of response to the user!)
But still it would be nice to have a "String ValueMap" functionality like the original Grafana table

I have used this panel with zabbix datasource, where is very powerful to pivot and align data as a table.
The only limitation is when you try to show a cell  with text where the text is not part of content metric name ( zabbix concept ) but a value.
Ex: Metric is "TOP SQL CPU" and value from metric can be "select ..." . In this case another item would be the value from CPU.
For this reason, i think would be cool have support for another data types in this case String.

rodrigo.. thanks for the feedback. Sorry I don't know anythig about zabbix. If you provide more details i will try my best to tell u the workaround or provide solution. (Btw, if you don't know this plugin only for pivoting timeserires data. For the other types default table should be sufficient i guess ) correct me if I am wrong.

Am I reading this right, that there is no intent to be able to display string data within a column (unless that string is contained in the metric name, surrounded by delimiters)? Error messages, ip address, place names?
The use case that brought me here is admittedly funky, but we have been able to build distributed applications using it that we have been super happy with - we just wanted to move to boomtable instead of the standard table so that we could have more control over look/feel/behaviour.
With how advanced the granularity is on options for boomtable, I never would have guessed that it would have so much trouble supporting what we thought was a pretty simple thing.
Use Case:
We currently use the standard table plugin to provide an interface with clickable URL's that mix tag data and value data from different columns (using the grafana table $__cell_n notation and [[tag_x]] references)
I.E we build a clickable link in the following format, using the table 'render value as link' button:
http://foo.bar/api_call?ip_address=[[tag_ip_address]]&name=[[tag_name]]&change_ip=${__cell_10:raw}&change_value=${__cell_7}
We want to use boomtable to rebuild this, since we would have much more control over the look/feel/behaviour of this panel as the application behind it evolves. It was a bit crushing to find out how difficult this was going to be due to the lack of string value support (we could just write the url as a field and reference that)
I can get the string column data by putting it into the series name, and then applying that as the row name & then referencing that, but it seems like we have zero way to do the following:

have a string in a column to show the name of the location you are changing (since we 'used up' the one string field we have, the 'row name'
combine this row name with numerical values contained in the same row, in other columns.

I suppose I should open an issue maybe for the $__cell_n syntax? I think with this (and by giving up on having a row name?) we could rebuild what we have in the standard table plugin.

This is the edge case I'm working on right now - but we certainly have many tables set up I was hoping to pivot and dress with this - but without the ability to put string data in columns the use case for this plugin seems very limited in the telco world?
Can you give me an idea if I'm reading this wrong? This plugin is intended for pivot of tables containing no strings and no dates, unless extracted from series name?

Thanks for writing your feedback. When this plugin was developed initially, it was designed with graphite db in mind.  But, String value map , time parser are reasonably good feature to have in this panel. Surely I will consider this in next releases.  ( Not anytime soon sorry. Any PR / contributions are welcome )


Add support for translations

Lot of user interface strings are directly in HTML templates. All UI strings should be in resx files to support translations.

Resolved by #126


SPA Fallback Middleware

Is your feature request related to a problem? Please describe.
We need to add a SPA fallback middleware for SPA development
Describe the solution you'd like
Ideally we need to make sure this is the last middleware in the chain so we don't break existing functionality that requires some routes to fail (like compiling js/ts/tsx on the fly)
Describe alternatives you've considered
Nothing so far
Additional context
This came up when I was trying to use a client side router with hash disabled

I've used https://github.com/khellang/Middleware#spafallback- in the past for this scenario.
I can try it out when I find time and send a PR if you like.

If you have a chance and want to take a stab at this you can try to add this middleware somewhere in Server.fs
https://github.com/AngelMunoz/Perla/blob/dev/src/Perla.Lib/Server.fs#L480


issues with text starting with [.*] when detect_json true

From postgres(9.4.6) to elasticsearch(2.3.1) using elasticsearch-jdbc-<IP_ADDRESS>, I am indexing records that have text and json fields. detect_json is enabled. Unfortunately,  titles that start with a pattern [.*] are indexed as an array. ES mapping still shows the field as  string type. I am not sure how this is happening.
One such example title is [7](3,5)TROPONOPHANES AND [9](3,5)TROPONOPHANES AND THE CORRESPONDING HYDROXYTROPYLIOPHANES This shows up as "title" : [ 7 ] in the ES _source field unless you add a quotation or replace the first character somehow.
Any idea how to debug or work around this?

My guess is this is coming from the logic in PlainKeyValueStreamListener.java
with scala repl:
import org.elasticsearch.common.xcontent.json.JsonXContent
val s="[7](3,5)TROPONOPHANES AND [9](3,5)TROPONOPHANES AND THE CORRESPONDING HYDROXYTROPYLIOPHANES"
val parser = JsonXContent.jsonXContent.createParser(s);
val token=parser.nextToken()
parser.list()
java.util.List[Object] = [7]

I don't want to do any special formatting in general but as a quick fix I added an extra character at the beginning of the titles that could potentially parsed as array or map (which is the case if the text starts with something like {8:9}).

Strings with [ or { and correspondent closing braces ] or } pass the JSON parser and are indexed as JSON when detect_json is enabled. If you don't want this, you must disable detect_json

I understand that but won't you agree that the text in my example is not a valid json to begin with? There is a loss of information. I'd expect it to default to indexing the value as text.

[7] is a valid JSON list. I agree that this data is non-sense in JSON. But JSON parser can not make an opinion about that, sorry.


add gitlab to social parameters

This PR simply adds GitLab to the social icons at the top of the site.  It works exactly like the GitHub version of the icon and will only appear if the user defines a link to their GitLab profile in the site's config.toml.

I made a few changes to update the documentation and to put this in the examplesite for testing purposes.

Cool, just FYI that I'll submit a few more PRs that I think could benefit other users of the theme, stay tuned 👍

No worries! I'll hold off on cutting a release for a while then, if there's more stuff incoming.


qglv_toolkit: 0.1.6-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository qglv_toolkit to 0.1.6-0:

upstream repository: https://github.com/yujinrobot/qglv_toolkit.git
release repository: https://github.com/yujinrobot-release/qglv_toolkit-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.20
previous version for package: 0.1.5-0

qglv_extras
* legacy support on old versions is 203xx, not 20304.

qglv_gallery
* legacy support on old versions is 203xx, not 20304.

The doc job is now failing: http://build.ros.org/job/Idoc__qglv_toolkit__ubuntu_trusty_amd64/6/console It looks like you changed the branch names recently. Please fix the doc and source entry.


[SG14] Add new port

https://github.com/WG21-SG14/SG14
https://repology.org/projects/?search=sg14
BTW, is wg21-sg14 a better package name?

It's a bit of hassle to type, bug I do prefer wg21-sg14 as the package name.

Hi! @vicroms Thanks! I will rename it to wg21-sg14.

Thanks!


databricks.sql.exc.RequestError when inserting more than 255 cells via pandas.to_sql.

The following example works with databricks-sql-connector version 2.9.3, but fails with version 3.0.1:
import numpy as np
import pandas as pd
from sqlalchemy import create_engine

sqlalchemy_connection_string = f"databricks://token:{access_token}@{host}?http_path={http_path}&catalog={catalog}&schema={schema}"
engine = create_engine(sqlalchemy_connection_string)
shape = (50, 16)
random_df = pd.DataFrame(
    data=np.random.standard_normal(size=shape),
    columns=[f"col{i}" for i in range(shape[1])]
)
table_name = "pandas_sqlalchemy_insert"
random_df.to_sql(table_name, engine, if_exists="replace", index=False, method="multi")

The error is: OperationalError: (databricks.sql.exc.RequestError) Error during request to server
With setting chunksize in random_df.to_sql to any value which is 15 or lower (to make the number of table cells inserted less than 256), the insert runs without issue.
What I have tried

Instead of  random_df.to_sql(table_name, engine, if_exists="replace", index=False, method="multi") used:

with engine.connect() as conn:
    random_df.to_sql(table_name, conn, if_exists="replace", index=False, method="multi")

-- the observed behavior is the same in all cases.

Various other DataFrames and chunksizes. Anything under 256 cells works, anything with 256 or more cells fails with the described exception.

Versions
Not working: databricks-sql-connector==3.0.1, sqlalchemy==2.0.23, pandas==2.1.4
Working:  databricks-sql-connector==2.9.3, sqlalchemy==1.4.50, pandas==2.1.4

Seems to be related to how the Databricks SQLAlchemy dialect constructs queries, where  databricks-sql-connector = ~3 uses parameters instead of directly injecting values into the INSERT statement, which version 2.9.3 did.

Thanks for your question. As of databricks-sql-connector==3.0.0 there is a major difference to how parameters are handled. This change (and the limitation of 255 parameters per query) is documented extensively here.

Possibly related to how the Databricks SQLAlchemy dialect constructs queries, where databricks-sql-connector = ~3 uses parameters instead of directly injecting values into the INSERT statement, which version 2.9.3 did?

This is pretty close. SQLAlchemy hasn't changed its approach, but the connector has. There are now two ways that the connector can send parameters: native and inline. Native is enabled by default and currently there is a limit at the server of no more than 255 parameters per query.  While the older inline approach doesn't have this limitation, as documented here, the SQLAlchemy dialect in connector version 3 and above will only work with the native approach.
Unfortunately, the only workaround for this is to modify your to_sql call with a chunksize that guarantees that any individual request will not exceed 255 parameters. We are working with the server team to increase the limit of 255 parameters per request.

Thank you for the answer.

We are working with the server team to increase the limit of 255 parameters per request.

Is the limit on the number of parameters a limitation on the Databricks SQL endpoint side? Do you happen to know of any public information or information you can share (e.g. ETA) on this?

Yes the limitation is at the SQL warehouse. Still waiting to hear internally when this will be increased.

Hi Team. I work at Procore Technologies and am coming across the same issue. I found that I had to set my particular query to a chunksize of 28 rows, which now makes sense due to the 255 cell limit.
This dramatically slows down the process of writing to Databricks, to the point where our intended use case may not work.
I also haven't seen anywhere in the docs where it shows examples of creating a SQL Alchemy Engine and using pd.to_sql / read_sql. Our code looks just like the code at the beginning of this thread, and it would be great if it was clearly documented somewhere how to use pd.to_sql / read_sql.
Alternately, it would be great if Databricks provided an optimized version of these functions with the connector. As an example, Snowflake offers the following functions with their connector: fetch_pandas_all, fetch_bandas_batches, write_pandas.
We'd like to use SQLAlchemy 2.0+, which I believe requires that we use the Databricks-sql-connector 3.0+, so here's a +1 to sorting this out quickly. Thanks!

I also haven't seen anywhere in the docs where it shows examples of creating a SQL Alchemy Engine and using pd.to_sql / read_sql.

It's part of the sqlalchemy documentation in this repository: https://github.com/databricks/databricks-sql-python/blob/main/src/databricks/sqlalchemy/README.sqlalchemy.md#usage-with-pandas

Alternately, it would be great if Databricks provided an optimized version of these functions with the connector.

Thanks for registering your support for this. Can you send an email to<EMAIL_ADDRESS>so we can follow-up with you?

Thanks for the link to the docs! I would recommend you link to that page on the main docs page here, as I assumed they would include everything I needed to know.
I'll shoot an email to that address.

Those docs are being updated as we speak :)

Update for you all: we're re-classifying this as a regression in the latest version of databricks-sql-connector and working to implement a fix that doesn't rely on the server supporting > 255 params. More details soon.

Hi team, any progress on this?

Hi, we're also facing the same issue. Could someone please provide an update on this? @susodapop

Hi @akshay-s-ciq, since I'm no longer maintaining this repository I'd recommend contacting Databricks support directly to get the current status.


Create an index for workload parameters in Opensearch for persistence.

To keep track of workload parameters, create a separate index for which workload parameters are specified for training.

Create an index: model-training-parameters for storing the most recent workload parameters for training a Deep Learning model.


Major issue with heartbeat, random crashes

There is a major issue with the heartbeat being moved to a separate thread.
It updates inventory, player data and fort timeout concurrently to other tasks. It causes random crashes.
Simple scenario:
Main Thread: Transfer Pokemon
Timeout Thread: Refresh Inventory
Main Thread: inventory.remove(pokemon_id) <- exception
```

I have trigger several scenario like that so far. The update of data structures should be moved out of the heartbeat.

What's your proposed solution?

Must be done in main thread to avoid modifying objects that a tasks is currently using. But does the phone application do that anyway ? (requesting inventory, player data etc.. regularly)

Not sure if the app does it, but we need to in order to make sure our information is 100% accurate and avoid other silly errors (like trying to discard stuff we don't have, trying to nickname a pokemon that isn't there etc.)
If every single piece of code that does something inventory-related could be guaranteed to always update inventory/stats, wouldn't be an issue, but... I wouldn't make that guarantee :)

#4605 show which api is being requested for any request

    def add(self, pokemon):
        if pokemon.unique_id <= 0:
            raise ValueError("Can't add a pokemon without id")
        if pokemon.unique_id in self._data:
            raise ValueError("Pokemon already present in the inventory")
        self._data[pokemon.unique_id] = pokemon

This now occurs because of heartbeat being moved to thread, HOWEVER... why on earth are we raising an exception/crashing because of this? Should just print a debug message and move on.

Ugh, yes this is a major headache. Why did heartbeat get threaded? It's not as if it was significantly holding up bot execution or anything.

@Gobberwart since heartbeat should be sent periodically, and some of the tasks might prevent this to be done. Say, if you are evolving a whole bunch of pokemon, the heartbeat will not be called until all the tasks are done.

@rawgni ok cool thank you. So... why does that matter? Trying to replicate the app behaviour?

I'm having lots of crashes because of this, I believe.
Mainly pokemon already in inventory and trying to remove an item I don't have. Is this problem related to this issue?

Yes. PR coming.

#5347 should fix this

@Anakin5 does this resolve your issue?

I'm going to say yes, and close this. Reopen if not fixed.


[alert_handler] D2(S) Signoff

Description
Ensure D2(S) signoff criteria are still maintained (this is not a focus area block).

Thanks for the analysis @andreaskurth.
The idea for this exercise was to double check that the IP fulfills the PROD.M2 exit criteria which is D2S/V2S.
Given that there were no changes, and that the Hjson still claims D3, I am fine with leaving it at D3:
https://github.com/lowRISC/opentitan/blob/2714197f3235f1737937ad20421a3f32ff4a7030/hw/ip_templates/alert_handler/data/alert_handler.hjson.tpl#L18-L22


*: remove unnecessary async blocks to save memory

What is changed and how it works?

Issue Number: Close #16540
Cc #16234

What's Changed:
*: enable linters about async and futures
  We should be pedantic about writing async code, as it's easy to write
  suboptimal or even bloat code.
  See: https://github.com/rust-lang/rust/issues/69826

*: remove unnecessary async blocks to save memory
  This commit favors FutureExt::map over async blocks to mitigate
  the issue of async block doubled memory usage. Through the sysbench
  oltp_read_only test, it was observed that this adjustment resulted
  in approximately 26% reduction in memory usage.
  See: https://github.com/rust-lang/rust/issues/59087

Check List
Tests

[x] Unit test
[x] Manual test

Run sysbench oltp_read_only on a single-node tikv cluster.
Configs and test commands

TiKV config:
[readpool]
[readpool.unified]
# Unlimited concurrent running tasks.
max-tasks-per-worker =<PHONE_NUMBER>

Injects a fail points to TiKV so that all tasks on read pool are blocked.
TiDB config:
# Do not limit concurrent transcations.
token-limit = 100000000
[txn-local-latches]
enabled = false

Sysbench command:
while true; do { \
    sysbench --db-driver=mysql --mysql-host=<IP_ADDRESS> --mysql-port=31825 --mysql-user=root \
        --mysql-db=test1 --tables=1 --table-size=100000000 --create_secondary=false \
        --time=5 --skip_trx=true --range_selects=false  --threads=1000 ./oltp_read_only run & \
    pid=$!; sleep 8; kill $pid; \
} done

Test results:

Nightly vs This PR  4.47GB vs 3.28GB

Release note

None

I think it's worth to cp this change to 7.5 7.1 and 6.5.

/merge


fix: BLE Scanner not working on devices with API < 21

This fixes issue #165 I reported myself about plugin being broken on really old android devices.
For a strange reason, if TypeScript class LeScanCallbackImpl is compiled into a JavaScript function using "NativeClass" decorator just like all classes, it fails to actually extend native class.
My approach was to keep LeScanCallbackImpl as a class after compile procedure using the power of ES2017. Additionally, super call needs an implementor that contains 'onLeScan' method, as an argument. That is probably because 'onLeScan' was originally an abstract method in Android SDK.
JavaScript class after compile with the power of ES2017:

Here are few device details regarding tests after fix.
Device: ZTE Blade A450
OS: Android 4.4 KitKat (API 19)
Bluetooth enabled during test: Yes
As a start, applications that initialized Bluetooth object stopped crashing.
Additionally, method 'startScanning' had proper and smooth functionality using the above scenario:
Inside phone's scan range, there was an HP laptop that supported BLE. Phone detected laptop with total success and displayed its UUID.
My approach looks more like a hack than a fix and I have my doubts whether it will cause any possible runtime issues in the future, but unfortunately I couldn't find any nicer working solution.
Hope this is useful in resolving this issue. :)

@DimitrisRK awesome as usual! Weird issue. And actually what you did should not work :) es6 native class extend can't really work . will look at it. At least now we know what s happening. I leave that open to see what s the best solution

@DimitrisRK awesome as usual! Weird issue. And actually what you did should not work :) es6 native class extend can't really work . will look at it. At least now we know what s happening. I leave that open to see what s the best solution

I suspect it might be working now because NS moved to a newer version. Isn't ES6 supposed to be older than ES2017?
Here is what I found in NativeScript blog https://nativescript.org/blog/nativescript-7-announcement/:
One of the attractive (and fun) features with NativeScript is its ability to extend native platform classs directly in JavaScript. However JavaScript has no way of knowing how to extend a native class on it's own. **When you wrote class MyClass extends android.os.class and it was compiled to ES5, the runtimes used the __extends function to handle the behavior. In ES2017, extends is supported natively and thus is compiled "as-is" leaving out the __extends needed for the runtimes.**
Still, this needs clarification as it might not be a clear statement about class syntax being supported.

@DimitrisRK actually that paragraph is weird now that i read it :D You do need @NativeClass when using es6 syntax! I know as i did write the @NativeClass decorator :D
If you want we can chat on slack (or discord if you prefer).

@DimitrisRK after reading you code again, it works! awesome


custom field limit should be 500 instead of 100

This note need to be updated: the limit should be 500
In the Preview, you are limited to 100 custom fields in your workspace. This limit will be expanded when this feature reaches general availability.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df0f4a1f-0c45-d4c4-a751-01f38c6fd237
Version Independent ID: a7687863-1ac0-3efb-c671-393d824b8c77
Content: Custom fields in Azure Monitor (Preview) - Azure Monitor
Content Source: articles/azure-monitor/logs/custom-fields.md
Service: azure-monitor
Sub-service: logs
GitHub Login: @bwren
Microsoft Alias: bwren

@MSNina123456 Thanks for your feedback.
Assigning to content author @bwren for review.

@MSNina123456 I can follow up with engineering team. Have you verified that this was changed to 500?

@MSNina123456 I can follow up with engineering team. Have you verified that this was changed to 500?

Yes, it should 500, kindly help on it


Any way to edit project/context names?

I could not find a way to edit the name of an existing project or context. While this can be done through search/replace using an external editor, IMO requiring the user to use one, defeats the purpose of this app.

The app is very promising, I like the general feel, functionality. But being able to edit in-app is essential.