Unable to run runqlat.bt

Running sudo runqlat.bt on NixOs system fails with following error:
❯ sudo runqlat.bt
WARNING: Could not find kernel headers in  or . To specify a particular path to kernel headers, set the env variables BPFTRACE_KERNEL_SOURCE and, optionally, BPFTRACE_KERNEL_BUILD if the kernel was built in a different directory than its source. To create kernel headers run 'modprobe kheaders', which will create a tar file at /sys/kernel/kheaders.tar.xz
definitions.h:2:10: fatal error: 'linux/sched.h' file not found

Note that on the same machine it is possible to run runqlat from bcc

What reproduces the bug? Provide code if possible.
This repository contains:

instruction how to create VM to reproduce (requires nix - not NixOs, any distribution will do)
automated test that reproduces the issue

bpftrace --info output
❯ sudo bpftrace --info
System
  OS: Linux 6.6.33 #1-NixOS SMP PREEMPT_DYNAMIC Wed Jun 12 09:13:03 UTC 2024
  Arch: x86_64

Build
  version: v0.20.4
  LLVM: 17.0.6
  unsafe probe: no
  bfd: yes
  libdw (DWARF support): yes

Kernel helpers
  probe_read: yes
  probe_read_str: yes
  probe_read_user: yes
  probe_read_user_str: yes
  probe_read_kernel: yes
  probe_read_kernel_str: yes
  get_current_cgroup_id: yes
  send_signal: yes
  override_return: no
  get_boot_ns: yes
  dpath: yes
  skboutput: yes
  get_tai_ns: yes
  get_func_ip: yes
  jiffies64: yes

Kernel features
  Instruction limit: 1000000
  Loop support: yes
  btf: yes
  module btf: yes
  map batch: yes
  uprobe refcount (depends on Build:bcc bpf_attach_uprobe refcount): yes

Map types
  hash: yes
  percpu hash: yes
  array: yes
  percpu array: yes
  stack_trace: yes
  perf_event_array: yes
  ringbuf: yes

Probe types
  kprobe: yes
  tracepoint: yes
  perf_event: yes
  kfunc: yes
  kprobe_multi: no
  uprobe_multi: yes
  raw_tp_special: yes
  iter: yes

I'm guessing that this is caused by #3156. We removed the automatic unpacking of kernel headers in v0.20.4 as it was the cause of some security issues. BCC still does the old auto-unpacking logic as far as I know.
If you try manually unpacking kernel headers does that resolve the issue? I think it's something like this:

modprobe kheaders
tar -xf /sys/kernel/kheaders.tar.xz
BPFTRACE_KERNEL_SOURCE="/path/to/unpacked/headers" bpftrace runqlat.bt

ps. We should probably add a step to the instructions in the bpftrace warning to run "tar -xf"
pps. Maybe we should update the runqlat tool to #define the values it needs instead of relying on kernel headers?

+1 to what @ajor said.

ps. We should probably add a step to the instructions in the bpftrace warning to run "tar -xf"

I think I originally had this in the warning message and took it out because I thought it was overkill but I guess I should add it back.
I can look into fixing up runqlat to use #define.

Just to confirm - you are absolutely right:
❯ sudo BPFTRACE_KERNEL_SOURCE=/tmp/headers runqlat.bt
Attaching 5 probes...
Tracing CPU scheduler... Hit Ctrl-C to end.
^C

@usecs:
[0]                36794 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@|
[1]                32925 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@      |
[2, 4)             30695 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@         |
[4, 8)             24858 |@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                 |
[8, 16)             5677 |@@@@@@@@                                            |
[16, 32)            1305 |@                                                   |
[32, 64)             295 |                                                    |
[64, 128)            132 |                                                    |
[128, 256)            36 |                                                    |
[256, 512)             9 |                                                    |
[512, 1K)              7 |                                                    |
[1K, 2K)               1 |                                                    |
[2K, 4K)               1 |                                                    |

Thanks for the support <3 Is there anything additional I could provide to help with this issue?

Glad to hear it! I think we've got everything we need here, thanks. I'll just keep this issue open until until we've clarified the instructions in the error message so that others don't get blocked by this in the future.

Amazing, thank you! :muscle:

huh actually I spoke too fast, glibc's header doesn't load:
$ ./result/bin/runqlat.bt
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:93:2: error: unknown type name '__aligned_u64'
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:94:2: error: unknown type name '__aligned_u64'
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:95:2: error: unknown type name '__aligned_u64'
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:96:2: error: unknown type name '__aligned_u64'
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:97:2: error: unknown type name '__aligned_u64'
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:98:2: error: unknown type name '__aligned_u64'
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:99:2: error: unknown type name '__aligned_u64'
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:100:2: error: unknown type name '__aligned_u64'
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:101:2: error: unknown type name '__aligned_u64'
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:102:2: error: unknown type name '__aligned_u64'
/nix/store/fwh4fxd747m0py3ib3s5abamia9nrf90-glibc-2.39-52-dev/include/linux/sched.h:103:2: error: unknown type name '__aligned_u64'
ERROR: Include headers with missing type definitions or install BTF information to your system.

So yeah, I guess we ought to just define TASK_RUNNING like we've done for tcp as a stop-gap..


Improve paralellization and logging

Changes:

Improve efficiency when running multiple preprocessing tasks in parallel by creating temporary file indicating that a slide is already being processed
Fix crash caused by OpenSlide "empty input file" error
Improve readability of logged information during preprocessing
Log more information about the used config during preprocessing
Remove dead code

Could you include the open issue into this PR? Thanks!


update file paths to work with windows machine

this will require using os.path.join() for most file path creation and removing hard-coded slashes (except for urls)

This will also include updated fetch_file(), etc to handle paths of the form "C:\ ..."

server doesn't run windows; for now we do not need to support this.


Update blog pages to add page metadata

Table Header: Metadata
Sample: col1 | col2
Template | Blog-Article
Author | David Gruen, MD, MBA, FACR and Antonia Wells
AuthorImage  | https://main--adobe-franklin-demo--amol-anand.hlx.page/media_186e54b87f1e5549899cd1b0dfb215eb219aaf704.png
Category | Enterprise Imaging
Audience | Provider, Health Plans, Life Sciences
Topic | Healthcare Providers, Healthcare Technology
ReadTime | 6 min read
@kunwarsaluja please add any other metadata that you depend on here so we capture it and update all the blog articles with it.

I updated topics/audiences and featured article in all the blog pages earlier this afternoon.

The descriptions are not correct for all the pages. The index is automatically pulling the author info because that's the first text in the blog article page. so we need to update the page metadata with the description instead for all blog pages. @kunwarsaluja

@amol-anand  Do we need a new metadata property Description that would have 2 line content for the blog home ?

yes. I see you've already put that in. can we close this issue?


Added Bitwarden to Password Managers

Based on unanimous feedback from this Tweet discussing LastPass alternatives.

https://github.com/trimstray/the-book-of-secret-knowledge/pull/205


Descriptions of Dataverse installations missing from map

The old map had descriptions of Dataverse installations. @raprasad mentioned that we intend the new map to have these as well.

Descriptions should be there now. You mean this these, right?:

Yes! They must have been added since I opened this issue. Thanks! Closing.


Delete press-kit.md

Deleting the press kit page, its very out of date, inaccurate, and if there is a refresh for this page coming it will need the branding document finished.
Is there anything this is going to break that jumps out at you @kauffj ?

There's additional logic that needs to be deleted, as-is this will result in the page erroring.
I'll delete the whole thing, though.

Sounds good, thanks. Is there a place in KB I can read up on the additional logic so I know better how these pages interact with the site?

@robvsmith not really. The press-kit logic is pretty custom, it takes all of the team bios and stuffs them into a zip, along with the images located in img/press.
The logic is here but I wouldn't expect you to understand or find that.

I'd like to see this information updated on lbry.io. Not sure if all of it needs to live on this particular page (I'm not against deleting the page and moving info elsewhere), as the brand kit will be downloaded from the new brand guidelines & assets page. It is a good thing to have big news articles in a place where folks can see them as it gives credibility to the project.

The press-kit page has been replaced with a prompt to contact Brinck: https://lbry.io/press-kit
I think @Feanor78 has been maintaining a sheet with press mentions, but let's not have this conversation on this PR.
A press-kit and sharing this information publicly has a lot of merit, but having a page up as outdated as this one was was clearly wrong.


Update OSX installation README

Hopefully this will help alleviate some of the pains, had a lot of help referring to the issues section of the project. Thanks for the awesome project 🎉

Thanks.  I have removed this file in #63 because it is not necessary to have separate instructions for OSX.


UnsatisfiedLinkError: isMinimalRequirementsMet()

Issue Description
Build error:
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.401 sec <<< FAILURE!
org.nd4j.jdbc.hsql.HSqlLoaderTest  Time elapsed: 1.4 sec  <<< ERROR!
java.lang.UnsatisfiedLinkError: 'boolean org.nd4j.nativeblas.Nd4jCpu.isMinimalRequirementsMet()'
at org.nd4j.nativeblas.Nd4jCpu.isMinimalRequirementsMet(Native Method)
at org.nd4j.linalg.cpu.nativecpu.CpuNDArrayFactory.createBlas(CpuNDArrayFactory.java:95)
at org.nd4j.linalg.factory.BaseNDArrayFactory.blas(BaseNDArrayFactory.java:71)
Version Information
Please indicate relevant versions, including, if relevant:
2019-10-08 git version 50b13fadc81a780b3f062c8db7fb6d78ec3ff3c7 branch master
Ubuntu 19.04
OpenJDK 11.0.4
Maven 3.6.0
gcc 8.3.0
mvn clean package -P testresources

It says that you hadn’t built libnd4j, so ND4j can’t find the method it expects to be available.
On Oct 8, 2019, 20:16 +0300, michaelmalak<EMAIL_ADDRESS>wrote:

Issue Description
Build error:
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.401 sec <<< FAILURE!
org.nd4j.jdbc.hsql.HSqlLoaderTest Time elapsed: 1.4 sec <<< ERROR!
java.lang.UnsatisfiedLinkError: 'boolean org.nd4j.nativeblas.Nd4jCpu.isMinimalRequirementsMet()'
at org.nd4j.nativeblas.Nd4jCpu.isMinimalRequirementsMet(Native Method)
at org.nd4j.linalg.cpu.nativecpu.CpuNDArrayFactory.createBlas(CpuNDArrayFactory.java:95)
at org.nd4j.linalg.factory.BaseNDArrayFactory.blas(BaseNDArrayFactory.java:71)
Version Information
Please indicate relevant versions, including, if relevant:
2019-10-08 git version 50b13fa branch master
Ubuntu 19.04
OpenJDK 11.0.4
Maven 3.6.0
gcc 8.3.0
mvn clean package -P testresources
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

libnd4j is built in libnd4j/target/libnd4j-1.0.0-SNAPSHOT-linux-x86_64.zip
Is there a manual step I need to perform to have that library installed so that the rest of the build can succeed?

Probably outdated snapshots, this isn't a build issue.
New snapshots are online, so this shouldn't be a problem anymore.


Remove pkg sockets and tlsconfig.

Use the ones provided by docker/go-connections, they are a drop in replacement.
Remove pkg/sockets from docker.
Keep pkg/tlsconfig because libnetwork still needs it and there is a
circular dependency issue.

Signed-off-by: David Calavera<EMAIL_ADDRESS>

prettyyyy

LGTM

LGTM


[BUG] Error due to unavailability of telescope?

Describe the bug
I do not use Telescope and currently see an error being thrown because of
Error detected while processing /home/core/dotfiles/nvim/.config/nvim/after/plugin/auto-session.lua:
E5113: Error while calling lua chunk: ...t/auto-session/lua/auto-session/session-lens/actions.lua:1: module 'telescope.actions.state' not found:
        no field package.preload['telescope.actions.state']
        no file './telescope/actions/state.lua'
        no file '/home/core/GitSources/neovim/.deps/usr/share/luajit-2.1.0-beta3/telescope/actions/state.lua'
        no file '/usr/local/share/lua/5.1/telescope/actions/state.lua'
        no file '/usr/local/share/lua/5.1/telescope/actions/state/init.lua'
        no file '/home/core/GitSources/neovim/.deps/usr/share/lua/5.1/telescope/actions/state.lua'
        no file '/home/core/GitSources/neovim/.deps/usr/share/lua/5.1/telescope/actions/state/init.lua'
        no file './telescope/actions/state.so'
        no file '/usr/local/lib/lua/5.1/telescope/actions/state.so'
        no file '/home/core/GitSources/neovim/.deps/usr/lib/lua/5.1/telescope/actions/state.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
        no file './telescope.so'
        no file '/usr/local/lib/lua/5.1/telescope.so'
        no file '/home/core/GitSources/neovim/.deps/usr/lib/lua/5.1/telescope.so'
        no file '/usr/local/lib/lua/5.1/loadall.so'
stack traceback:
        [C]: in function 'require'
        ...t/auto-session/lua/auto-session/session-lens/actions.lua:1: in main chunk
        [C]: in function 'require'
        ...tart/auto-session/lua/auto-session/session-lens/init.lua:2: in main chunk
        [C]: in function 'require'
        ...e/pack/paqs/start/auto-session/lua/auto-session/init.lua:3: in main chunk
        [C]: in function 'require'
        ...dotfiles/nvim/.config/nvim/after/plugin/auto-session.lua:13: in main chunk

To Reproduce
Steps to reproduce the behavior:
Just open neovim in a directory for which session exists, auto-session will try to restore an existing session for the current cwd and then throws the above error.
Expected behavior
No error without telescope.
Screenshots
If applicable, add screenshots to help explain your problem.
Baseline (please complete the following information):

Result of set sessionoptions?: buffers,curdir,tabpages,winsize
OS. e.g uname -a: Linux core-endeavour 6.2.12-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 20 Apr 2023 16:11:55 +0000 x86_64 GNU/Linux
Neovim version nvim --version: NVIM v0.10.0-dev-188+g9f0762f1f
URL to your current config (if public)

Additional context
Is telescope mandatory now?.

I just ran into this myself. I use fzf.lua and after my latest sync I had to remove auto-session.

temporary fix:
{
      "rmagatti/auto-session",
      commit = "63984ed9c0fb7eae61eb1c2982bc1147e202d23e",
      -- ...
}

Ah, the idea was that it should work without telescope but I apparently forgot to handle a few cases. I'll drop a PR to fix this up soon!

Thanks, @3rd for the workaround hint. Anyway, I had to use commit "51b5ca4ff3200b875bb0e36416f9a6bccb0e1967" in order for the auto-load of a standard session to be performed. with later commits, there was still no auto-load at start-up.

@nnako I don't think you're having the same issue as everyone else in this thread?
For everyone else, mind testing the branch of the PR linked above to see if this fixes your issue? 😊

@rmagatti works great for me! thanks for the fix :tada:

Hi, indeed, the fix seems to fix the error connected with the telescope availability. But, unfortunately now, auto-session does not load any session at startup. the screen stays empty as if no session file was present within the respective folder. And further, when trying to exit nvim from this empty screen, I am prompted to confirm leaving nvim, which is not usually the case.

@3rd are you experiencing anything similar to @nnako?

@rmagatti no issues on my side, my current config for reference: https://github.com/3rd/config/blob/master/home/dotfiles/nvim/lua/modules/workflow/sessions.lua

@nnako I don't think this is related to what you're experiencing. Maybe there's something special about your config?


Request for Additional Keybindings

Hi. I'm currently using Spyder with spyder-vim, and pleased to have such an excellent plugin.
Many thanks for releasing this plugin and helping all vim and spyder users around the world.
I found it is somewhat incomplete, however, as it lacks some essential keys.
For example, many vim users type 'ctrl-[' instead of the real escape key, which is way more convenient to type on modern qwerty keyboards. Without this keybinding, it is not that comfortable to actively switch between normal and insert modes and make the most of the advantages of vim. I think adding this is the top priority of the others.
Second, currently supported keymaps are not sufficient to scroll the page effectively. I personally use ctrl-e and ctrl-y a lot to adjust the window, and when I want to scroll the screen just one line down, I'm forced to do something like <s-l>j<s-m>kkk or <s-m>jzz4k (kkk to go back to where the cursor was). It's a pain, and I'd rather get my hand off the keyboard to touch the mouse than hit all those more than five awkward keystrokes.
Third, though someone may not think this is essential, I find the } and { keys are helpful when navigating a paragraph since we normally separate code blocks with cr. The ctrl-o and ctrl-i keys are also nice ones, which allow us to get back to the previous cursor position in case we temporarily moved far from the main section.
I'd be more than content if only the spyder-vim supported the first one(ctrl-[).
Thanks again for your effort in maintaining this wonderful plugin.

Hey @renormalization2, thanks for reporting. You said:

Hi. I'm currently using Spyder with spyder-vim, and pleased to have such an excellent plugin.
Many thanks for releasing this plugin and helping all vim and spyder users around the world.

Thanks for your kind words! We're really glad to know you find this plugin is useful.

For example, many vim users type 'ctrl-[' instead of the real escape key, which is way more convenient to type on modern qwerty keyboards. Without this keybinding, it is not that comfortable to actively switch between normal and insert modes and make the most of the advantages of vim. I think adding this is the top priority of the others.

Ok, good to know. I'll try to implement this keybinding for our next release (0.2.0). I can't commit to add the others because I have very little time available, but this one seems simple enough for me to do it.


[Fix #5534] remove empty line after Style/EachWithObject autocorrect

See #5534

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

@Drenmi updated

The change looks good to me. There are some RuboCop failures on the code.

@Drenmi @rrosenblum fixed failures

@Drenmi @rrosenblum the test failure is caused by rebasing master branch.

master branch's failure will be resolved by #5575.

@Drenmi @rrosenblum @koic test failures are fixed


bump sigs.k8s.io/karpenter

Fixes #N/A
Description
bump sigs.k8s.io/karpenter
How was this change tested?
NA
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.805%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
5430

Relevant Lines:
6979

💛  - Coveralls


MUI Drawer help method

I noticed that antd has a helper for the drawer component, but MUI don't. Is there a reason for this?

using muiDialogV5 for MUI Drawer worked. Maybe I missed something in the readme.


Update ruby 2.6.5-alpine3.11 image

It doesn't have to be merged to the 0.80 channel. Just wanted to upgrade both Ruby and alpine.
If you will remember to upgrade the image with 0.81 channel release, we can closed this one.

Let's keep this open. Updated the channel, so when we actually have a 0.81 we make this part of the upgrade plan.

Can you rebase with that branch when you get a chance?

My branch is up-to-date with channel/0-80 but channel/0-81 is behind channel/0-80, so you need to rebase and push channel/0-81.

Ok, I just dropped the commit with 0.80.1 update.


Difference between date and createdAt

Hi, @mirasnag,
I was looking through the Transaction data type (apart from another issue I opened), I was curious about the fields inside the Transaction data type.
Especially, date and createdAt, it is not really clear to me what the difference is between them?
The description for date says:

The date of the transaction

The description for createdAt says:

The date and time when the transaction was created

I am looking forward to hearing from you!
Thanks for your cooperation!

Hello,
The date field represents the actual date of the transaction—the day it occurred. On the other hand, createdAt is the timestamp of when the user entered the transaction data, which may differ if the transaction is logged later. This setup allows us to differentiate between when a transaction took place and when it was recorded.
Let me know if you have any further questions! Thanks again for your attention to detail.


delete kui-proxy-scc via  uninstall & nuke scripts

Description of the change:
Delete kui-proxy-scc object via nuke script
Motivation for the change:
The Canary builds are reporting that kui-proxy-scc object was not getting cleaned up on uninstall, and subsequent installs are failing. Ref: https://github.com/open-cluster-management/backlog/issues/2878

@tpouyer @TheRealHaoLiu  I think these deletions have a place in nuke.sh but probably not uninstall.sh.  Given that 2.0 promises a clean uninstall/reinstall, do we want to add this deletion or make sure that the uninstall works cleanly?  Basically, this brings up the question about how we ensure that we mark failures to remove resources as canary failures.
Moving forward, we'll have installer install/uninstall tests that actually check the install/uninstall process.  My opinion is that a canary should:

Clean the environment (if the environment is being reused from a previous canary) using uninstall.sh and hack/nuke.sh.
Run the installer "install" test <- testing the install on a "clean" environment
Run the installer "uninstall" test <- testing an uninstall from a "clean" install
Re-run the installer's "install" test <- testing an install from an env that has had ACM installed and then uninstalled, testing this customer scenario
Run squad tests
Check cluster back into pool for re-use.

This lets us make sure we tear down cleanly for a reinstall, especially because that's a promised feature in 2.0, but also make sure that if we find a canary failure that leaves stuff around, we won't pollute any following canaries.


Remove the force flag from pod_delete job that should not force delete

Signed-off-by: xkbarkar<EMAIL_ADDRESS>What this PR does / why we need it:
The current FORCE flag in pod_delete experiment is pointless as pods will be force deleted either way
Which issue this PR fixes *
#1507
Checklist

[ ] Does this PR have a corresponding GitHub issue?
[ ] Have you included relevant README for the chaoslib/experiment with details?
[ ] Have you added debug messages where necessary?
[ ] Have you added task comments where necessary?
[ ] Have you tested the changes for possible failure conditions?
[ ] Have you provided the positive & negative test logs for the litmusbook execution?
[ ] Does the litmusbook ensure idempotency of cluster state?, i.e., is cluster restored to original state?
[ ] Have you used non-shell/command modules for Kubernetes tasks?
[ ] Have you (jinja) templatized custom scripts that is run by the litmusbook, if any?
[ ] Have you (jinja) templatized Kubernetes deployment manifests used by the litmusbook, if any?
[ ] Have you reused/created util functions instead of repeating tasks in the litmusbook?
[ ] Do the artifacts follow the appropriate directory structure?
[ ] Have you isolated storage (eg: OpenEBS) specific implementations, checks?
[ ] Have you isolated platform (eg: baremetal kubeadm/openshift/aws/gcloud) specific implementations, checks?
[ ] Are the ansible facts well defined? Is the scope explicitly set for playbook & included utils?
[ ] Have you ensured minimum/careful usage of shell utilities (awk, grep, sed, cut, xargs etc.,)?
[ ] Can the limtusbook be executed both from within & outside a container (configurable paths, no hardcode)?
[ ] Can you suggest the minimal resource requirements for the litmusbook execution?
[ ] Does the litmusbook job artifact carry comments/default options/range for the ENV tunables?
[ ] Has the litmusbooks been linted?

Special notes for your reviewer:

Thanks for the PR @xkbarkar !! Let me get back with review shortly!

Thanks @xkbarkar for the PR!


Change the Date to UK Format

Hi,
Is it possible to change the date on the Card to UK Fromat, See below;

See the Due Date, can this be 28/02/2018 instead of 02/28/2018

It will be possible once the rewrite is completed.


Blink GraphQL API integration  (WIP)

Blink Wallet API Integration - WIP
Note: the test script is not in proper pytest format, will convert after I get the main part working.
Referencing https://github.com/lnbits/lnbits/issues/2227

Note Please don't edit this branch until it is ready for review. thanks.

Waiting for Galoy/Blink Devs to write in a new method to their GraphQL endpoint in order to complete this integration.
Will take a few days.
cc: @openoms

Not sure if this is the right way to do the unit test, but I tried as a first pass.
Also graphql is really long seems to break the formatter.

If someone can please run and test, that'd be appreciated.
cc: @openoms, @pretyflaco

I will fix the conflicts in the am...

Thank you for this great PR @bitkarrot, it looks very close to completion!
Been setting up server running this branch and tested successfully:

[x] adding a Blink API key and switching funding source
[x] send over LN
[x] receive over LN
[x] send intraledger (Blink to Blink)
[x] receive intraledger

Extensions tried:

[x] LNURLw vouchers works
[x]  Bolt card works
[x] TPoS works

One thing I noticed so far that if I just simply top up a wallet with the RECEIVE button on the bottom left the payment does not get picked up live. Need to close the invoice and refresh the screen to see the balance change.
Tested this with switching the funded source to another LNbits and on another instance backed by CLN - there the payment is picked up live.
Note the TPOS is getting the instant feedback with the green checkmark.
Could this be solved?
Please anyone else testing, this is the best time for any feedback.

@openoms i'm looking into how we can get the websocket part going for the receive issue.

putting websocket method on hold.
requesting review from @prusnak  and @dni when possible.
cc: @openoms

Updated branch to resolve conflicts and make format.
CI is failing on i18n files, appears unrelated to branch

I rebased and squashed this PR into a new PR https://github.com/lnbits/lnbits/pull/2477
I suggest we continue there


[PCM-829] Fixup logging for webrtc sdk to be more effective

and more secure

Valve tests passing


fix(ui): Fix various problems with refreshing etc.

What this PR does 📖

Enables keycheck for tesseract which fixes tesseract being unlocked with any pin
Saves whether the user is currently logged in or not in the current session (tab). This prevents needing to login again if you e.g. refresh the page.
Solves the problem if unable to login after refresh (though with the point above this is not noticable anymore)

Which issue(s) this PR fixes 🔨

Resolve #268

Hey @Flemmli97  I noticed the following issues in your pr branch:

When creating a new account, after choosing a new pin and clicking on confirm button, an error is displayed in console from chrome devtools "Uncaught (in promise) Error: RayGun extension unavailable. I kept doing the regular steps to create account and got redirected to chats page. Then, I refreshed and got redirected to Enter Pin. After entering the correct Pin, I cannot log back in to the app:

https://github.com/user-attachments/assets/7ca5b8fc-5d3e-44c0-a1f0-f8003f930f39

I was able to reproduce bug #268 in this branch (the uncaught error recursive use of an object...), so apparently is not fixed yet:

https://github.com/user-attachments/assets/6bbabc64-6ee2-4922-89e1-aaceeb090558

one note: it seems raygun events are not received meaning both creating and deleting chat doesn't update things on web end for the other user. (warp works). should be addressesd in a different pr though as this pr is already sidetracking by a lot

Both of these issues can be created into tickets if you'd like just let me know and I will write up!

If I clear the url and retype in Localhost it doesn't bring me to the expected pin page instead it takes me to account creation

Screen.Recording.2024-07-19.at.11.47.50.AM.mov

If the user refreshed the webpage any friends name will be displayed as unknown user for about 30 seconds then the username will re-appear

Screen.Recording.2024-07-19.at.11.52.03.AM.mov

hmm first issue i cant reproduce. when i do it it takes me to pin enter page.
2. is i think the part from lucas. as we update user profiles via a polling loop

i would say we should prob create new issues for those


Import/Export of JSON for model is not working

What is wrong?
Export/Import functionality of the library is not working, the JSON is not in the correct format to be considered JSON.
Where does it happen?
Windows 10 node version 8
How do we replicate the issue?
`const brain = require('brain.js);
var net = new brain.recurrent.RNN();
net.train([{input: [0, 0], output: [0]},
{input: [0, 1], output: [1]},
{input: [1, 0], output: [1]},
{input: [1, 1], output: [0]}]);
var output = net.run([0, 0]);  // [0]
output = net.run([0, 1]);  // [1]
output = net.run([1, 0]);  // [1]
output = net.run([1, 1]);  // [0]
console.log(net.toJSON()) // JSON is in incorrect format, am i missing something?
`
How important is this (1-5)?
4 - love this library but can't use it for Production use cases until i can export/import
Expected behavior (i.e. solution)
JSON is exported in valid format
Other Comments
N/A - love this Library tho

Very important issue.  We unit tests here: https://github.com/BrainJS/brain.js/blob/d7508dd706d82a1d864cb74ae52fa4df6070a486/test/recurrent/rnn.js#L323
Will look at this on my lunch break.

Ah ok, I see: https://jsfiddle.net/robertleeplummerjr/zwyhxL8f/6/
The json for a recurrent network brain.recurrent.RNN and the json from a feed forward neural network brain.NeuralNetwork are simply different.  The above reproduces the functionality and should clarify.  I don't believe this to be a bug.

Thanks for the code.
I've tried it and your version works, when you pass the stored json from the variable in the previously trained network to the new one, however, when i try and read in the json from a file and parse it, it has a problem reading it?
CODE:
const brain = require('brain.js');

var net = new brain.recurrent.RNN();

net.train([{input: [0, 0], output: [0]},
{input: [0, 1], output: [1]},
{input: [1, 0], output: [1]},
{input: [1, 1], output: [0]}],
{logPeriod:1, log:true, iterations:2000});

console.log(net.run([0, 0])); // [0]
console.log(net.run([0, 1])); // [1]
console.log(net.run([1, 0])); // [1]
console.log(net.run([1, 1])); // [0]

var json = JSON.stringify(net.toJSON());
console.log(json) // JSON is in different format
var net = new brain.recurrent.RNN();
net.fromJSON(JSON.parse("input-output-trainedmodel.json"));

console.log(net.run([0, 0])); // [0]
console.log(net.run([0, 1])); // [1]
console.log(net.run([1, 0])); // [1]
console.log(net.run([1, 1])); // [0]

ERROR:
index.js:143
var matrix = new Matrix(json.rows, json.columns);
TypeError: Cannot read property 'rows' of undefined
Is there a trick to reading it in from an external source?

Also, I think either the README needs to change to specify that the exported JSON model needs to be stringified before use, or the return function needs to stringify it before it returns the JSON.

net.fromJSON(JSON.parse("input-output-trainedmodel.json"));

May be the problem.  JSON.parse reads a string in, you want to pass the string of the source of input-output-trainedmodel.json

Is there a trick to reading it in from an external source?

Yea, just use
const fs = require('fs');

and then later:
console.log(json) // JSON is in different format
fs.writeFileSync("input-output-trainedmodel.json", JSON.stringify(json));
var net = new brain.recurrent.RNN();
net.fromJSON(
  JSON.parse(
    fs.readFileSync("input-output-trainedmodel.json").toString()
  )
);

Yes you are correct. Thanks so much! Sorry, I knew that the reading in was a javascript issue not a brain js issue I just didn't know how to achieve it. I'm a .NET developer by trade so little rusty with the ol' JS side of things.
Thanks again.

No problem!  Always a pleasure to have a visitor from .net.  I started there, and began to dabble a little.  You'll be surprised how fast you go from "little rusty" to a well oiled machine.
chow!

I recommend stringify before save and then just read file, parse it using JSON, as I did here:
Save: https://github.com/mubaidr/image-parsing/blob/master/src/index.js#L76
Read: https://github.com/mubaidr/image-parsing/blob/master/scripts/test.js#L10


Responsive Designon an iPhone (Safari, latest version).

Description: Verify the website's responsive design on an iPhone (Safari, latest version).
Preconditions: The website https://oportunitatisicariere.ro/ is live and accessible.

Step 1 : Open Safari on an iPhone.
Expected Result: The website layout should adjust appropriately in both portrait and landscape modes without breaking.

Step 2 : Rotate the device between portrait and landscape modes.
Expected Result: The website layout should adjust appropriately in both portrait and landscape modes without breaking.

Step 3 : Observe the layout and content adjustments.
Expected Result: The website layout should adjust appropriately in both portrait and landscape modes without breaking.


Update rn-get-started.md

Update command to working version for listing keys for an app.

@CyberMew : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@CyberMew : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Updating ResourceDictionary in code behind doesn't fire change notification

XAML Version: System XAML
Scenario: When doing Hot reload in React Native, some styling needs to change as a response to the user changing app code out from under the app
  void SetResources(const xaml::FrameworkElement& fe, const JSValueObject& dict) {
    auto rd = ResourceDictionary();

    for (auto const& entry : dict) {
      const auto& name = entry.first;
      const auto& value = entry.second;
      auto brush = ColorUtils::SolidColorBrushFrom(value);

      rd.Insert(winrt::box_value(winrt::to_hstring(name)), brush);
    }
    fe.Resources(rd);
  }

Running through this code the first time correctly sets the value and it renders.
The second time this code runs through, the control does not re-render.
Removing the element from the ResourceDictionary does not fix it either

This is expected and by design. {StaticResource}'s resource lookup logic only runs once, when the parser processes the markup (in this case, the template for the underlying native XAML control, e.g. Button). No mechanism exists for forcing the logic to run a second time to reflect changes to the ResourceDictionary hierarchy short of literally recreating the element using the {StaticResource}.

tagging @MikeHillberg, let's discuss this and the motivation behind this as a feature request :)

FYI @bartekk8

A StaticResource in markup is just like doing an assignment in code; to update it you need to re-execute it. Implicit styles and data binding are dynamic though, maybe we could use those as a mechanism here.

My expectation on how this should work, based on nothing but common sense :D :

The Resources property says nothing about it being a static resource.
This gets confounded by the fact that this seems like it just works in WPF but not uwp xaml
First attempt was to set a new value in the ResourceDictionary. That should fire a notification on the children to re-evaluate. Nope!
Ok, maybe I need to remove the element from the dictionary and set it again. Nope.
Ok, maybe I destroy the dictionary and add a new one. Nope.

Agree that the main problem is the lack of a mechanism for children to be notified of an ancestor's ResourceDictionary changing.
Do you have thoughts on how we can use data binding and implicit styles to achieve this? I'm looking at using ResourceDictionary in RNW to implement lightweight styling that can interface or at least be analogous with FURN

My expectation on how this should work, based on nothing but common sense :D

Agreed. The developer expectation is that these should be dynamic. WPF had DynamicResource and that doesn't exist in the StaticResource/ThemeResource system of system XAML and WinUI. It feels like a gap and one we need to resolve in the resource system design eventually.

Internal tracking: http://task.ms/39897009


Support qemu-ansible-core-2.13

please also add testenv:container-ansible-core-2.13

please also add testenv:container-ansible-core-2.13

To src/tox_lsr/config_files/tox-default.ini as well as to tests/fixtures/test_tox_merge_ini/result.ini?

please also add testenv:container-ansible-core-2.13

To src/tox_lsr/config_files/tox-default.ini as well as to tests/fixtures/test_tox_merge_ini/result.ini?

yes - note that you can use UPDATE_RESULT_INI=true tox -e py310-tox30 to automatically update tests/fixtures/test_tox_merge_ini/result.ini (but you'll still have to visually inspect it to make sure it looks ok)


improve a bit the DX on vscode

Summary:
This is highly subjective, it's just some of the settings that make me more productive so I thought I'd share. Feel free to close if you don't like it tho.

[x] add some recommanded extensions (prettier, eslint, flow and 2 extensions to clean up: add a new line at the end of the file and remove the empty indents)
[x] enable flow
[x] enable eslint
[x] format the file with prettier when saving it (instead of having to wait for the pre-commit hook)

Here's a potential solution to the formatOnSave problem: https://github.com/Microsoft/vscode/issues/37519#issuecomment-344414444
You'll still have an untracked file in your local repo, but at least it won't conflict with any tracked files.


Don't mutate .spec.config if its a management cluster app

Towards https://github.com/giantswarm/giantswarm/issues/14163
For the app-operator app CR we don't want to default .spec.config.configMap.
$ k -n 6z2ik get app app-operator-6z2ik -o yaml | k neat

apiVersion: application.giantswarm.io/v1alpha1
kind: App
metadata:
  annotations:
    chart-operator.giantswarm.io/force-helm-upgrade: "false"
  labels:
    app-operator.giantswarm.io/version: 0.0.0
    app.kubernetes.io/name: app-operator
    config-controller.giantswarm.io/version: 0.0.0
    giantswarm.io/cluster: 6z2ik
    giantswarm.io/managed-by: cluster-operator
    giantswarm.io/organization: giantswarm
    giantswarm.io/service-type: managed
  name: app-operator-6z2ik
  namespace: 6z2ik
spec:
  catalog: control-plane-catalog
  kubeConfig:
    inCluster: true
  name: app-operator
  namespace: 6z2ik
  version: 4.0.0

Checklist

[x] Update changelog in CHANGELOG.md.

Tested on gauss.

Are we doing this because we are storing the app config from this repository?

No its because the app CR gets created by cluster-operator. The configmap gets defaulted because it exists e.g. 6z2ik-cluster-values. For unique app CRs in the giantswarm namespace there is no cluster values configmap.
Good to mention the config repo though. We should migrate our stuff at some point. It might be something to include in the next cycle. My idea was to try it with app-exporter first. WDYT?

Thanks for the clarification, yes, I think it makes sense to move our configs at some point, I will be creating a new ticket on our board today.


Wait until the pbench agent daemonsets are ready

Although the wait time is usually negligible there is the potential to start a
test before the pbench agent daemonsets are up and running.  This p/r adds a
task to wait until the daemonsets are ready.  Additionally, there is a task
added to wait for scale-ci-tooling task deletion to complete.

Looks good, same comment as https://github.com/openshift-scale/workloads/pull/6 :+1:

/lgtm

Thanks, will one of you merge it?

@akrzos can we increase the delay to something more than 1 sec like @sjug mentioned?

Sure what delay and retry combo do you all suggest?

Do we need to increase the delay?  Isn't the call blocking anyway?  Is 1s too much?

The agents come up pretty quick for me at least within 1-2s, but maybe I should try and clear the images first and see how long it typically takes for them to be pulled and started.

I think the agents will come up quickly like @akrzos mentioned. It should be the case even when we don't the image pulled down to the node as the image size has been drastically reduced.

Ok with a cluster without the scale-ci-workload image took 10 attempts before the playbook found the daemonset up and running.  On a "warm" cluster it took 2 attempts.  The task Wait until scale-ci-tooling project is deleted took the longest time on the warm cluster so I figured best here to just increase the delay from 1s to 2s so we have a 2 minute window for both of those waiting tasks.  Do note that the 2 minute window is the minimum amount of time and connection overhead will lengthen this a tiny bit (unless you have a connection with greater than "normal" latency)

2s delay sounds good, merging the PR.


README.md: add missing closing parenthesis

Coverage remained the same at 99.315% when pulling 6b9cf9630f99e32a8cbc6b4f21e128f6de9d73ab on kenyon:patch-1 into 9c36a308b798e00ba2c0c03942e58c0e38383b27 on mcanevet:master.

Thanks @kenyon !


Prompt to sign messages #2497

Closes #2497

https://example.walletconnect.org

oh, i see. Missed that.

BTW, https://danfinlay.github.io/js-eth-personal-sign-examples/ seems a little broken recently. In case you were testing with it and thought it's our bug. The confirmation doesn't seem to pop up correctly, but the request to sign etc should still work.

Remember to buzz me again if it's ready

@hboon for me it doesn't even appear, for this service,
https://danfinlay.github.io/js-eth-personal-sign-examples/

seems a little broken recently. In case you were testing with it and thought it's our bug. The confirmation doesn't seem to pop up correctly, but the request to sign etc should still work.

Just tested it, it works fine, all popus appear as needed.

@vladyslav-iosdev does 81d9761 work for you? No popups appear for me, including https://xcontract.herokuapp.com/sign

@hboon i am a little bit confused, first time i opened link in dapp browser, it worked ok.
https://danfinlay.github.io/js-eth-personal-sign-examples/
now it doens't work (pop up does't appear) even browser callback doesn't get called.

Force pushed after changing commit message from

Prompt to sign messages #2497

to:

Update prompt to sign messages to use actionsheet-style #2497

More intention revealing :)


NuGet Packages Breaking Change Report

I'm querying NuGet packages and then generating a report to show breaking changes from the corresponding minor and major versions. So for example if the current version of something is 6.2.3, it would discover breaking changes from 6.20...6.2.3 and 6.0.0...6.2.3.
One test does this for the top 25 popular NuGet packages (that have .NET sources) and the other does it for our NServiceBus packages.
I needed to change the ViewModel for the API compare to static types so I could use them more easily from other code, and expand them to count breaking changes, but functionality should be unchanged. I also had to take a dependency on NuGet.Core in the Backend Tests.
@ParticularLabs/apicomparer please review.

Sample reports:

Popular NuGets
NServiceBus Packages

all this looks ok to me. however it seems a few of the tests are not really tests but helpers for you to generate some ad-hoc reports. is this correct? if so there is nothing wrong with this but can you make them explicit and comment them as such so in the future they can be cleaned up

Mods based on Simons comments. Most importantly made these two tests explicit since they aren't really tests in the truest fashion.

@DavidBoike is this PR dead or you'll work on it?

Forgot about this. As far as I'm concerned it's mergeable, unless it conflicts with the other data model changes @andreasohlund had in progress.

They are similar but not conflicting


pages:extend pages i18n remove layout from extend pages

Environment

Operating System: Windows_NT
Node Version:     v20.11.1
Nuxt Version:     3.11.2
CLI Version:      3.11.1
Nitro Version:    2.9.6
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      experimental, hooks, ssr, devtools, nitro, vite, css, pwa, spaLoadingTemplate, app, modules, eslint, i18n
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction
https://stackblitz.com/edit/bobbiegoede-nuxt-i18n-starter-jskhtw?file=pages%2Ftest.vue
Describe the bug
When I add a page using hooks pages:extend:
  hooks: {
    'pages:extend'(pages) {
      pages.push({
        name: `testExtend`,
        path: `/testExtend`,
        file: '~/pages/test.vue',
      });
    },
  },

i18n changes the layout to the default, even though on the same page it was not the default..
try open /test and /testExtend They are the same file
https://stackblitz.com/edit/bobbiegoede-nuxt-i18n-starter-jskhtw?file=pages%2Ftest.vue
/test :

/testExtend

Additional context
No response
Logs
No response

This happens without i18n as well, you'll have to pass meta like so:
    'pages:extend'(pages) {
      pages.push({
        name: `testExtend`,
        path: `/testExtend`,
        meta: { layout: 'trans' },
        file: '~/pages/test.vue',
      });
    },

Not sure if definePageMeta should work on pages added this way, I suggest opening an issue on the Nuxt repo if that is the expected behavior.

This happens without i18n as well, you'll have to pass meta like so:
    'pages:extend'(pages) {
      pages.push({
        name: `testExtend`,
        path: `/testExtend`,
        meta: { layout: 'trans' },
        file: '~/pages/test.vue',
      });
    },

Not sure if definePageMeta should work on pages added this way, I suggest opening an issue on the Nuxt repo if that is the expected behavior.

sorry, thanks


Please add a helper/hint label

vaadin-text-field doesn't have a helper or hint label which makes it difficult to guide users' through forms etc.
The error-message slot could potentially be used for this purpose (when the field is not invalid).
Placeholders are simply not good enough.

For future reference, there’s some research suggesting that a description/help text should be placed below the label, above the field. Example
The same research suggest the same for error messages as well (place error messages above the field), linking to another research.

Regardless of placement, this would be super useful as an alternative to placeholders, tooltips etc, especially for mobile where tooltips are not accessible. (I've done at least a couple of custom implementations of this feature in the last three years.)

@jouni for what it's worth, I agree with you regarding the helper placement.

Fixed by #410 available in v2.6.0-alpha1


Admin sub-menus don't open with 2.6

Version 2.6 breaks the opening of the sub-menus in the admin interface (settings, custom menus) other than the main Pages tree menu, which opens and slides correctly.
Browser console doesn't give any JavaScript errors.
Wagtail version 2.5.2 works fine.
Technical details

Python version: 3.7.3
Django version: 2.2.3
Wagtail version: 2.6
Browser version: Firefox 68.0.1 and Chromium 75 on Kubuntu 18.04

Hi @TravellerSam,
The menus definitely work here - opening the settings menu to check the version number is one of the first things we test when packaging up a new release. Have you tried clearing your browser cache?

Hi @gasman,
The caches in all browsers are clean, any blockers turned off. I also used the Firefox Developer Edition, with same effect. I find it very strange that only the sidebar sub-menus don't show up, as the pages and user account slide out correctly. Can't access any non-Linux system at the moment.
The URL on these links gets an # on click.

Is this happening on a newly-created project, or one you've upgraded?

On upgraded (two different installations).

Could you try with a fresh project, please? I'm wondering if there's some sort of customisation (or third-party add-on) in place which is incompatible with 2.6.

It sure works perfectly on a fresh installation :/

Pip packages I use in affected projects:
django_compressor~=2.2 csscompressor~=0.9 django-newsletter==0.8b1 django-flags~=4.1 wagtail-flags~=4.0 wagtail-modeltranslation==0.10 Markdown~=3.1

Will close as unable to replicate - happy to reopen if you can track this down to a regression in Wagtail itself. If the issue is in one of the add-on packages, I'd expect that there'll be a new release with Wagtail 2.6 support in the next few days.

Your question about clearing cache was somehow right: after running collectstatic on the server the interface got the fresh javascript and the menus are working again.

Thanks for the issues. I get the same and the collectstatic + clean browser cache solve the issue.
thanks

@gasman Maybe it would be worthwhile to mention the need of running collectstatic and clearing the browser cache in the upgrade notes of the changelog.

@TravellerSam collectstatic and clearing cache are mentioned in the general upgrading instructions.

I have this exact issue even after clearing cache and running collectstatic, both on Firefox and Chrome.
Here's my requirements.txt:
django>=2.2,<2.3
dj-database-url
sentry-sdk
gunicorn
whitenoise
psycopg2
wagtail>=2.6.1,<2.7
django-storages
boto3
pyyaml

An error is thrown in the JavaScript : TypeError: "i.e.EDIT_PAGE is undefined".


Button to delete a channel looks like it should merely close the window

The button to delete a channel is a small "x" in the upper right corner of the dialog box.  In most windowing systems, an X button there would only close the window.  You should change the  button to say "delete" and possibly adjust it's location to avoid confusion.   It would also be nice to have it pop up a "Are you sure you want to delete this channel?" confirmation dialog, since there is no way to undo the deletion.

Or change it from an X to a trash can icon.

It's not on the window frame though (the light grey), but in the darker grey area directly associated with the  channel info.  Also, really no Minecraft GUI has a close button so that doesn't make much sense for expectations.

It got me several times.  Nothing worse than configuring some complex channel and then deleting it all.


add CloudLab profile

[x] For CloudLab to be able to fetch this file, it should be at the root of the default branch. But we probably don't want it to be in the main branch. A quick workaround is to let sosp-ae be the default branch during the AE process. Thoughts? @tylergu

This is addressed by moving all CloudLab- and Ansible-related stuffs to a separate repo: https://github.com/xlab-uiuc/acto-cloudlab

[x] I ran it last night. It turns out the startup script is run by the nonhuman user geniuser. So the tmpfs and cloned acto repository are now in /users/geniuser. I'm figuring out the solution.

See comment below

[x] A bit docs are needed.

@whentojump , does the profile have to be in the repo? I have experience of creating profiles from the CloudLab UI and the profile seems can be self-contained xml file.
I am referring to the Upload files, Create topology here.

Although I am not sure if these can be expressive enough

Importing from a repository comes with a benefit that, the repository is automatically cloned at /local/repository.
I'll try if there are issues with direct upload

I see, I don't think that benefit is very necessary. Feel free to create a separate repo only containing the ansible script and the profile, we can just use that repo for bootstrap

Feel free to create a separate repo only containing the ansible script and the profile

Will do that

Regarding the second item of the task list

It turns out the startup script is run by the nonhuman user geniuser. So the tmpfs and cloned acto repository are now in /users/geniuser.

Several workarounds I'm thinking of, from easy to hard:

Simply let reviewers run sudo su - geniuser at the very beginning

Create a neutral user like acto-runner in the script. Basically the same as 1 except a for different name

There're some hacks that can find out who is instantiating this particular run of the experiment.
experiment_creator=$( geni-get user_urn | rev | cut -d '+' -f -1 | rev )

We can then let an "outer" script (always called by geni-user) call an "inner" script on behalf of $experiment_creator.
It magically works, just looks not so reliable...

I have been looking at geni-lib docs to see if there's a way to learn the creator during Python execution but so far got no luck

I plan to work on 3. Any comments are appreciated! @tylergu

I'm closing this PR because CloudLab- and Ansible-related stuffs are now here out-of-tree: https://github.com/xlab-uiuc/acto-cloudlab
@tylergu If you have time, can you walk it through and fit the content of that README into proper locations of sosp-ae branch? Thanks!


Add links to talks in README

Could be helpful

Will merge in a few days if there are no objections


Convert JsonSerializers and JsonDeserializers to Utility Methods

As part of reducing the usage of Jackson Databind in azure-core JsonSerializer and JsonDeserializer implementations should be transitioned to utility methods either on the class that the serializer/deserializer was implemented for or as a static utility method elsewhere.
A potential way to determine where the serialization/deserialization code should live is based on whether to type was annotated with @JsonSerialize or @JsonDeserialize. In cases where the class was annotated with either of the annotations, it meant that Jackson Databind could implicitly hook into the custom JsonSerializer or JsonDeserializer. In cases where the class wasn't annotated with either of the annotations, it meant that the Jackson Databind ObjectMapper would need to add the JsonSerializer or JsonDeserializer as a module, and if the serializer/deserializer was in implementation it meant that it was for internal use only.

Closing as no JsonSerializers or JsonDeserializers will have utility methods created for them


Solution added in p4_longestPrefix.cpp

Hello @Akash88585 !!
Please verify the solution.
Thanks!!

Great @Alok5102R


Commit message losing focus

Issue Type: Bug
Recently the commit message input started to loose focus while I'm typing the message, usualy  right after I add the files to the commit. If I keep typing it start to filter the files filter. It's pretty annoying :)
VS Code version: Code - Insiders 1.43.0-insider (5996fb81591e92fd0c547dc45e3f0350026d5962, 2020-03-06T23:17:52.931Z)
OS version: Windows_NT x64 10.0.19041

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz (8 x 1992)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
19.82GB (6.56GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (5)

Extension
Author (truncated)
Version

tslint
eg2
1.0.44

dotenv
mik
1.0.1

vscode-docker
ms-
1.0.0

remote-wsl
ms-
0.42.3

vscode-scss-formatter
sib
1.4.3

Same issue experienced since the latest update.
It happens when adding a file using the + and starting to type the commit message.
Focus get lost when the Git view is done with the refresh.

Same issue.
Version: 1.43.0 (user setup)
Commit: 78a4c91400152c0f27ba4d363eb56d2835f9903a
Date: 2020-03-09T19:47:57.235Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

To specify how the bug actually occurs:

Add files into staging
Before files are shown in the staging area, start typing the commit message, because it is already in focus for typing
after the files are added into staging, the focus gets lost and the typed in text is used for search in the commitable files

Same to me.
Version: 1.43.1 (user setup)
Commit: fe22a9645b44368865c0ba92e2fb881ff1afce94
Date: 2020-03-18T07:01:20.184Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

@DonPavlov yes - these are the exact steps that cause it for me too on:
Version: 1.43.0 (system setup)
Commit: 78a4c91
Date: 2020-03-09T19:47:57.235Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363

This appears to be a duplicate of #92401. And I agree, it's mildly infuriating.

Same here. It's the most annoying thing in history!!! Fix it please....

I also have this problem. I've noticed it happening since version 1.43.0. Before that, I could type my commit message without it ever losing input focus on the message box.

Bug report template

VSCode Version: 1.43.2 (system setup)
OS Version: Windows_NT x64 10.0.18363
Commit: 0ba0ca52957102ca3527cf479571617f0de6ed50
Date: 2020-03-24T07:38:38.248Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0

Steps to Reproduce:

Launch Code in a directory with a git repository
Make a change i.e. add a new file or edit a file
Open the source control tab
Stage the changed file
Click inside the commit message box
Begin typing a commit message before Code has detected the file been staged
Observe focus switching to the Changes panel and an active filter now present

Does this issue occur when all extensions are disabled?: Yes

Yes, this is a duplicate of #92401. Please go :+1: that one so this gets noticed.

IS it fixed or not? or will we have to live with this for the rest of our lives?

@joelharkes This is fixed in the latest (March) release.


Fixed security risk from terminate package

Explanation of Bugfix/Feature/Modification:
terminate depends on event-stream, which depends on flatmap-stream which introduced a security risk for crypto related libraries.
see https://github.com/dominictarr/event-stream/issues/116 for more information.
ran yarn upgrade terminate which upgraded the yarn.lock

Yeah, strange. The key is definitely still there in Travis. I'll go ahead and admin merge this since it still works locally.


Handling Lazy Loading Routes when offline

As Lazy Loading Routes is a part of Nuxtjs and is enabled by default, my questions are:

How can we handle app behavior when app is no longer online and trying to navigate to route that is not loaded yet? By default I see "Loading chunk %n failed." error. What approaches are possible here show user message about offline status etc?
Is it possible to disable to disable splitting app.js build on pages for production? That could be usefull for small apps that doesn't need this.

Thanks for help!

I would also like to know if this is possible. My previous config before switching to Nuxt didn't use code splitting since my routes were < 10k each. I believe this is causing my server rendered page to get out of sync with my client rendered one.

You could use prerendering/prefetching together with an PWA to cache other routes after main route has been loaded, so they can be used offline :relaxed:


Any style guide about comment in Swift?

Not really. We use this style guide to codify things specific to Swift, and there’s simply nothing novel about commenting in Swift. Write good documentation; be happy.


Add Back Market in the USERS list

Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[x] Are you a user of Cilium? Please add yourself to the Users doc
[x] Thanks for contributing!

Add Back Market in the list of users

Thanks for the addition @NitriKx ! Would you be interested in doing a case study about why you chose Cilium? We would just need 30 minutes for an interview. You can see some examples here https://www.cncf.io/case-studies?_sft_lf-project=cilium


Set ReadOnly during function create and update

Description

Set the ReadOnlyRoot option in the function container
Fix broken secrets test

Create slice of secret names found in Swarm
Use %v to fix a type issue in the error message format string

Update vendored version of faas

Motivation and Context

This enforces that the function container is created with a read-only filesystem at /

Tests were failing because the %s was not allows for the array of Secrets

This version of the faas dependency is required for the ReadOnlyRootFilesystem property in the CreateFunctionRequest

I am not sure why so much of it is vendored, but it is what dep ensure created

[X] I have raised an issue to propose this change (required)

Closed openfaas/faas#590
How Has This Been Tested?

Getting this posted so that others can check it out, I will be testing it soon with its companion PR for the faas-cli openfaas/faas-cli#439
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[X] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

It occurs to me that I did not add writable mount for /tmp when the ReadOnlyRootFilesystem is true.  I assume that tmpfs is probably the most appropriate, perhaps someone with more experience or an opinion on Swarm can let me know?
	if request.ReadOnlyRootFilesystem {
		spec.TaskTemplate.ContainerSpec.Mounts = []mount.Mount{
			{
				Type:   mount.TypeTmpfs,
				Target: "/tmp",
			},
		}
	}

Per the docs https://docs.docker.com/storage/tmpfs/#specify-tmpfs-options, this should create a world writable folder with unlimited size.  Perhaps we need an additional flag to allow a max size to be set?

@LucasRoesler  Regarding an additional flag for max size. As far as I know for the K8S implementation we use the emptyDir and I'm not aware of a way how to limit an emptyDir so this could cause for differences in the behavior.

Just checked, prune is not enabled.  I will create a PR for that and then rebase once it is merged.

I have rebased and I have bumped the version of faas again

Merged, thanks @LucasRoesler for working on this.


typst-cli watch panic: thread 'main' panicked at 'span does not point into this source file'

Description
One should try following action repeatedly to trigger this bug, because it is not quite stable. To reproduce it:

randomly edit the line in file https://github.com/Myriad-Dreamin/typst-book/blob/5ff6fa4e14c2dbc6563a5eb1e71addb1fac1d74a/contrib/typst/i18n.typ
assert(flow_nodes.len() >= 1, message: "no id to translate")

Reproduce state:

I can reproduce it by v0.7.0/typst-x86_64-pc-windows-msvc/typst.exe
I can reproduce it on webapp
I can reproduce it by typst preview plugin.

Related issue: https://github.com/Enter-tainer/typst-preview/issues/105
The output of v0.7.0/typst-x86_64-pc-windows-msvc/typst.exe
watching .\github-pages\docs\locale\zh_CN\format\book-meta.typ
writing to .\github-pages\docs\locale\zh_CN\format\book-meta.pdf

[12:45:55] compiling ...

thread 'main' panicked at 'span does not point into this source file', D:\a\typst\typst\crates\typst\src\lib.rs:102:1
stack backtrace:
   0:     0x7ff6bf85a041 - <unknown>
   1:     0x7ff6bf51deab - <unknown>
   2:     0x7ff6bf855249 - <unknown>
   3:     0x7ff6bf859deb - <unknown>
   4:     0x7ff6bf85d5d9 - <unknown>
   5:     0x7ff6bf85d2b2 - <unknown>
   6:     0x7ff6bf85dabe - <unknown>
   7:     0x7ff6bf85d9b5 - <unknown>
   8:     0x7ff6bf85b889 - <unknown>
   9:     0x7ff6bf85d6a4 - <unknown>
  10:     0x7ff6bff8bc25 - <unknown>
  11:     0x7ff6bff8bbe2 - <unknown>
  12:     0x7ff6bfe6c329 - <unknown>
  13:     0x7ff6bfb6f924 - <unknown>
  14:     0x7ff6bfcbbc45 - <unknown>
  15:     0x7ff6bfd1997d - <unknown>
  16:     0x7ff6bfe0e56a - <unknown>
  17:     0x7ff6bfe0cf6f - <unknown>
  18:     0x7ff6bfc02206 - <unknown>
  19:     0x7ff6bfa69f28 - <unknown>
  20:     0x7ff6bfaf21f9 - <unknown>
  21:     0x7ff6bfae167c - <unknown>
  22:     0x7ff6bfaf1da9 - <unknown>
  23:     0x7ff6bfae167c - <unknown>
  24:     0x7ff6bfa7f0c3 - <unknown>
  25:     0x7ff6bfaec39c - <unknown>
  26:     0x7ff6bfae14db - <unknown>
  27:     0x7ff6bfa21dbe - <unknown>
  28:     0x7ff6bfa640bc - <unknown>
  29:     0x7ff6bfde8c69 - <unknown>
  30:     0x7ff6bfac4937 - <unknown>
  31:     0x7ff6bfce3b79 - <unknown>
  32:     0x7ff6bfce3c5f - <unknown>
  33:     0x7ff6bfce3fd9 - <unknown>
  34:     0x7ff6bfce3bd5 - <unknown>
  35:     0x7ff6bfce3c5f - <unknown>
  36:     0x7ff6bfce3fd9 - <unknown>
  37:     0x7ff6bfce3c5f - <unknown>
  38:     0x7ff6bfd9ace8 - <unknown>
  39:     0x7ff6bfc1dc40 - <unknown>
  40:     0x7ff6bfb38cf8 - <unknown>
  41:     0x7ff6bfb3b6a8 - <unknown>
  42:     0x7ff6bfbb1c9b - <unknown>
  43:     0x7ff6bfb9bccc - <unknown>
  44:     0x7ff6bfb556c6 - <unknown>
  45:     0x7ff6bf84e032 - <unknown>
  46:     0x7ff6bfbbc24c - <unknown>
  47:     0x7ff6bff89d2c - <unknown>
  48:     0x7ff9725126ad - BaseThreadInitThunk
  49:     0x7ff9730eaa68 - RtlUserThreadStart

The output of the webapp:

The output of typst-preview.exe (which uses typst compiler):
[2023-08-29T03:38:06Z INFO  typst_ts_compiler::service::diag] \github-pages\docs\locale\zh_CN\format\book-meta.typ: compiling ...
thread '<unnamed>' panicked at 'span does not point into this source file', C:\Users\[hidden]\.cargo\git\checkouts\typst-15b90983aa0184a9\706d64f\crates\typst\src\lib.rs:102:1
stack backtrace:
   0:     0x7ff63deda19c - std::sys_common::backtrace::_print::impl$0::fmt
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\sys_common\backtrace.rs:44
   1:     0x7ff63df0244b - core::fmt::rt::Argument::fmt
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\core\src\fmt\rt.rs:138
   2:     0x7ff63df0244b - core::fmt::write
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\core\src\fmt\mod.rs:1094
   3:     0x7ff63ded4a6f - std::io::Write::write_fmt<std::sys::windows::stdio::Stderr>
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\io\mod.rs:1714
   4:     0x7ff63ded9f4b - std::sys_common::backtrace::_print
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\sys_common\backtrace.rs:47
   5:     0x7ff63ded9f4b - std::sys_common::backtrace::print
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\sys_common\backtrace.rs:34
   6:     0x7ff63dedca1a - std::panicking::default_hook::closure$1
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\panicking.rs:269
   7:     0x7ff63dedc66f - std::panicking::default_hook
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\panicking.rs:288
   8:     0x7ff63dedd0ce - std::panicking::rust_panic_with_hook
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\panicking.rs:705
   9:     0x7ff63dedcfbd - std::panicking::begin_panic_handler::closure$0
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\panicking.rs:597
  10:     0x7ff63dedade9 - std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure_env$0,never$>
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\sys_common\backtrace.rs:151
  11:     0x7ff63dedccc0 - std::panicking::begin_panic_handler
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\panicking.rs:593
  12:     0x7ff63df4eb35 - core::panicking::panic_fmt
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\core\src\panicking.rs:67
  13:     0x7ff63df4eaf2 - core::panicking::panic_display
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\core\src\panicking.rs:150
  14:     0x7ff63df4eaf2 - core::panicking::panic_str
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\core\src\panicking.rs:134
  15:     0x7ff63df4eaf2 - core::option::expect_failed
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\core\src\option.rs:1952
  16:     0x7ff63dcd0db2 - typst_syntax::source::Source::range::h772764d002cace7b
  17:     0x7ff63d2af6c8 - typst::World::range::hd4986400e0d5b667
  18:     0x7ff63dbab5b5 - comemo::cache::memoized::{{closure}}::h9f8a4a98177ad8ad
  19:     0x7ff63dba43ec - comemo::cache::memoized::{{closure}}::h9f8a4a98177ad8ad
  20:     0x7ff63db99de9 - comemo::cache::memoized::h75291853097e0632
  21:     0x7ff63db52fff - typst::eval::func::Func::call_vm::hd5941fd5c92d433d
  22:     0x7ff63d474a0d - typst::model::Vt::delayed::hba39e1e20d9d999b
  23:     0x7ff63d5f4839 - <typst_library::meta::context::LocateElem as typst::model::realize::Show>::show::hd8b31ecaa459a231
  24:     0x7ff63daed4ce - typst::model::realize::realize::h86036e8219255b5b
  25:     0x7ff63d5ea290 - typst_library::layout::define::h69e9238461ecef7f
  26:     0x7ff63d5ea437 - typst_library::layout::define::h69e9238461ecef7f
  27:     0x7ff63d5ea4b0 - typst_library::layout::define::h69e9238461ecef7f
  28:     0x7ff63d5ea3c6 - typst_library::layout::define::h69e9238461ecef7f
  29:     0x7ff63d5ea437 - typst_library::layout::define::h69e9238461ecef7f
  30:     0x7ff63d5ea4b0 - typst_library::layout::define::h69e9238461ecef7f
  31:     0x7ff63d5ea437 - typst_library::layout::define::h69e9238461ecef7f
  32:     0x7ff63d5f27ab - typst_library::layout::realize_root::h25fd89773881bde4
  33:     0x7ff63d603398 - comemo::cache::memoized::h85b99e09fb39f8bc
  34:     0x7ff63d43aaed - <typst::model::content::Content as typst_library::layout::LayoutRoot>::layout_root::hbde5354b8ddd0d43
  35:     0x7ff63d3f2e50 - http::uri::scheme::Scheme::empty::h6e81c139f1cb2b86
  36:     0x7ff63db94d44 - comemo::cache::memoized::h139c00ab40234037
  37:     0x7ff63dadd6a4 - typst::model::typeset::h8e037222030d0fa1
  38:     0x7ff63dad5262 - typst::compile::h2a9993dd28be9b32
  39:     0x7ff63d2af8c5 - <C as typst_ts_compiler::service::DiagObserver>::with_compile_diag::h4859ad321f3293b0
  40:     0x7ff63d28d0eb - typst_preview::actor::typst::TypstActor::new::h88ebe99ffbaf6a36
  41:     0x7ff63d27d0e9 - std::sys_common::backtrace::__rust_begin_short_backtrace::h8e70adff2028f5ed
  42:     0x7ff63d27ef5f - core::fmt::Write::write_fmt::h4d1472d0999b2b2a
  43:     0x7ff63deeadac - std::sys::windows::thread::impl$0::new::thread_start
                               at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library\std\src\sys\windows\thread.rs:57
  44:     0x7ff9725126ad - BaseThreadInitThunk
  45:     0x7ff9730eaa68 - RtlUserThreadStart

Need more investigation to locate the reason why it panics.
Reproduction URL
https://typst.app/project/rSpwBj23HTcKvYkOPCG3bE
Operating system
Windows
Typst version

[X] I am using the latest version of Typst

Possibly related to https://github.com/nvarner/typst-lsp/issues/241

I think I have an idea what's going on here: The range method is comemo-tracked (even though it doesn't need to be) and it panics on wrong spans instead of returning an option.
What's probably happening is that comemo tries to validate some cached results against a new world. But in that world, the span is meaningless and panics. I will push a fix soon, switching to returning options and maybe moving the range function into an extension trait.
This will also fix CLI panics for detached spans. The CLI will rather unhelpfully print the error without any location information then, buts that's better than panicking. Errors on detached spans are very rare anyway, just unfortunately not prevented on the type-system level.
It is very possible that this is also the problem in Typst LSP.

Should be fixed by https://github.com/typst/typst/commit/a71a2057f286677b5bf2e064fea05024aeca0dd2


Convert the program for Mac OS?

Can run it on mac using wine.
https://www.reddit.com/r/pokemonrng/comments/7f0qu3/running_3dsrngtool_on_mac_and_linux/

Wine has broke 32bit support, and thus 3DSRNGTool can no longer work with wine. Could this issue be reopened?
Application could not be started, or no application associated with the specified file.
ShellExecuteEx failed: Internal error.


Prefix namespaces: PhpParser -> Microsoft\PhpParser

Currently we clash with https://github.com/nikic/php-parser, which prevents both libraries from being used at the same time. Plus this appears to be consistent w/ general best practices.

That would be great


Quick Access table node doesn't display as broken when removing the Azure account

Storage Explorer Version: 1.22.0-dev
Build Number: 20211016.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Big Sur 11.6
Architecture: ia32\x64
How Found: From running test cases
Regression From: Not a regression
Steps to Reproduce

Expand one storage account -> File Shares.
Select one file share -> Add it to quick access.
Go to 'ACCOUNT MANAGEMENT' panel -> Remove the account.
Go to 'EXPLORER' panel -> Check whether the QA file share displays as broken.

Expected Experience
The QA file share displays as broken.
Actual Experience
The QA file share displays well.
Additional Context

This issue doesn't reproduce for blob containers.
Related issue: 3176.

@v-xianya I have added the expected behavior for file shares. Can you please confirm that you are now seeing that behavior?

@MRayermannMSFT This issue has been fixed for file shares.

Awesome, thank you for confirming! I'm going to edit this title and move to 1.23 where we can do table and queue part of the work.

Verified this issue on the build main/20220212.2. Fixed.

Still occurring, because I didn't show table nodes as broken if other credentials were present.

Verified this issue on the build main/20220214.5. Fixed.


Refactor PageRegistration to separate registries/interfaces

Currently we have single PageRegistration that does too many things. We should split this, for example:

GlobalPageRegistration for global pages
ClusterPageRegistration for in-cluster pages
ClusterMenuRegistration for registering in-cluster menus

@jakolehm what is "in-cluster menu"? I don't see that current page-registry related to that somehow.. or is it something totally new?

@jakolehm what is "in-cluster menu"? I don't see that current page-registry.ts related to that somehow.. or is it something totally new?

With "in-cluster menu" I meant something similar to CLUSTER = "cluster-view-scope".


Fixes for various RHEVM fleecing issues.

Fix for RHEV 3.5 - ovf file no longer on NFS share.
Fix for NFS permission problem - uid changed when opening files on share.
Fix for environments with both, NFS and LUN based storage.
https://bugzilla.redhat.com/show_bug.cgi?id=1202895
https://bugzilla.redhat.com/show_bug.cgi?id=1024033

@Fryguy @jerryk55 Please review.

@roliveri I think I follow what's going on here but do we have fleecing tests that cover any of these higher level changes?  If not, the small query methods should have unit tests and maybe the bigger methods can be extracted so we can have more test coverage.

Much of the new code in this PR requires direct interaction with the host environment - mounting and accessing NFS, accessing block devices, etc. Even unit tests at that level you suggest, would require mocking the oVert interface. As you point out, changes like this require integration tests. We do plan on providing integration tests for fleecing, but that's a complicated undertaking - requiring the mocking of various interfaces and interactions - and is beyond the scope of this PR.

@jrafanie So, is this ok to merge in your opinion or are there still unresolved discussion items?

@jerryk55 @movitto I'm good with these changes provided the issues above, can you ack/nack?  I'm not really familiar with this code.

I've put in my minor 2 cents and followed the discussion live and in person so I am good with this.

Thanks! :smile:


App deployment Fixing

Your current app deployment is not working on vercel. Can i work on fixing that ?

@NOOB-3301 after SWOC 2025 Coding period starts will start assigning the issues to contributors


Update README.md

The two dev link at line 5 redirect to error 502, remove both link or update them

Thanks, but thats just a temporary issue that effects everyone using that badge 😅


Set Files as the default file manager doesn't work

Description
After updating to v2.1.24 (Preload) and later (I tried 2.1.25, 2.1.26 and 2.1.27 preview version), it is not possible to set Files as the default file manager any more.
Turning on the option will make the changes to the registry, but when I try opening a folder, the following error appears:

This file does not have an app associated with it for performing this action. Please install an app or, if one is already installed, create an association in the Default Apps Settings page.

This happens for every action that regards opening File Explorer, maybe the registry keys are pointing to the wrong location(?)
Steps To Reproduce

Open Files
Go to the settings page and enable "Set Files as the default file manager"
Try something that requires the opening of File Explorer
The error will be shows

Expected behavior
Files should set correctly as the default file explorer.
Files Version
Versione <IP_ADDRESS> OS Version: 10.0.22000.556
Windows Version
Windows 11 21H2 22000.556
Relevant Assets/Logs
debug_fulltrust.log
debug.log

Maybe it's the same issue as #8707, but I decided to report it just to be sure.

@yaichenbaum nope, the issue still persists. The option applies the changes to the registry and reverts them back correctly.
But looking at the changes I can see that the file that some registry keys mention doesn't actually exist.
For example this one: [HKEY_CLASSES_ROOT\Folder\shell\explore\command] ->"%LOCALAPPDATA%\Files\FilesLauncher.exe" "%1"

@gave92 can you help with this?

Hi, it would be a huge help if you could check the following (using Files 2.1.27):

Run the reg file linked by Yair above to revert registry changes and "start clean" -> File Explorer should open as default
Open a file explorer window and leave it open, just in case. You'll be able to navigate with it by using the address bar or by right-clicking a folder and choosing "open in new window"
Toggle the setting to enable Files as default from Settings > Experimental -> Do you get the request for admin access? Does the toggle stay "on" after granting it?
Verify that the following registry key was applied: [HKEY_CLASSES_ROOT\Folder\shell\explore\command] ->"%LOCALAPPDATA%\Files\FilesLauncher.exe" "%1"
Verify that the following file exist: %AppData%\Local\Packages\Files_1y0xx7n9077q4\LocalState\FilesOpenDialog
Verify that the following file exist: %AppData%\Local\Files\FilesLauncher.exe"

Feel free to reach us on our Discord channel if you have questions or if you get stuck. Thanks!

@gave92 OK, I did everything that you asked.
I run the file to revert registry changes and reinstalled the latest preview version of Files.
When I click the option, it does trigger UAC, and it stays on after I approve the request.
The registry key is added correctly.
%AppData%\Local\Packages\Files_1y0xx7n9077q4\LocalState\FilesOpenDialog\FilesLauncher.exe exists.
The folder %AppData%\Local\Files\ does not exist.

%AppData%\Local\Files\ is also missing on my laptop, where I have installed Files for the first time. (Release 2.1.24, sideloaded)

Waait could be because you username has spaces in it?

The username is indeed identical on both machines, with a space in between.

Could you also check what happens if you give the following commands to Powershell? Does the missing file/folder get created? What does it print to console?
$destFolder = [System.Environment]::ExpandEnvironmentVariables("%LocalAppData%\Packages\Files_1y0xx7n9077q4\LocalState\FilesOpenDialog")
Write-Host $destFolder
$dataPath = [System.Environment]::ExpandEnvironmentVariables("%LocalAppData%\Files")
Write-Host $dataPath
New-Item -Force -Path $dataPath -ItemType Directory
Copy-Item -Filter *.* -Path "$destFolder\*" -Recurse -Force -Destination "$dataPath"

Note: when you get tired and just want to make it work you can just manually copy the file "FilesLauncher.exe" to %AppData%\Local\Files ;)

Ouch ok should be working now but I fail to understand what the problem is -.- The above is the command we execute i Files to copy the files over.

Now that the files actually exist, it does work properly.

So, manually it works but when it should do that automatically it doesn't, do I understand that right?

OK, thanks to your help, I managed to get Files working properly on both of my machines.
The only thing left to do now is finding the cause of this odd behaviour.
Do I have to leave this issue open, so you can keep track of it, or I should close it?
Just one more thing:
I commented on an issue (bug) that was closed because there was information missing.
Could you please tell me if it has been noticed and if it's been taken care of? #8569

Odd i get this too. I tryed doing what was said above and just get the windows error sound with no message. I did try runing the .exe myself (I presume this is suppost to open files) but i get this

Confirmed that this is due to usernames with a space

This issue should be resolved in main.

It seem this has not fully been fixed as - and potentially other special charater still have the issue. As soski has said in the discord server (https://discord.com/channels/725513575971684472/725514946112127057/959156418336927814)


Add error handling in stf_task_receiver

Currently, if we get an error in stf_task_receiver, stf_task_receiver will exit, and the tee-worker will no longer be able to enter stf_task_receiver.
We need to add error handling so that stf_task_receiver does not panic if an error occurs during processing, and also need to send extrinsic to parachain to let parachain know that an error has occurred
https://github.com/litentry/tee-worker/blob/49061fb037fdbede76041079018ff98c32cf2532/litentry/core/stf-task/receiver/src/stf_task_receiver.rs#L35-L57

Reopened, as this is not yet fully completed, in the end the errors should be propagated to the parachain and visible to the F/E.
https://github.com/litentry/tee-worker/blob/8a2c6e4f8a13fe065b093d41d4188e477582573a/litentry/core/stf-task/receiver/src/stf_task_receiver.rs#L40


Extract feature from DINOv2 with resolution 448 * 448 or downsample feature of DiT, which is better?

Hi, I'm wondering if i want to work with image with resolution 512 * 512. How should I align resolution of DINOv2 and DiT? Extract feature from DINOv2 with resolution 448 * 448 or downsample feature of DiT from 32 * 32 to 16 * 16, which is better?

Hi, thanks for your interest. I haven't tried, but I expect 448x448 to be a better choice as it might contain more high-frequency details.


Deploy to staging

Link to JIRA ticket
JIRA ticket
Describe this PR
Deploy to staging

to be replaced with another PR


Supporting Scoped Packages

I have the following scoped package:
https://www.npmjs.com/package/@mattdesl/raf
But the following gives me an error:
https://wzrd.in/standalone/@mattdesl/raf@latest
Cannot GET /standalone/mattdesl/raf@latest

+1

Ignored?

Insofar as I don't realistically have time to implement all feature requests? Sure. But feel free to make a pull request and I'd be happy to review.

It looks like the registry isn't listing the metadata from the registry for scoped packages.

where
status
url

Non-scoped
found
http://registry.npmjs.org/color

Scope
not found
http://registry.npmjs.org/@tatumcreative/color

Tarball
found
<EMAIL_ADDRESS>

I might try and find where this is in the registry code...

Got it! http://registry.npmjs.com/@tatumcreative%2Fcolor

https://wzrd.in/standalone/@mattdesl%2Fraf@latest still doesn’t work though.

#112 resolves this and adds scoped module support.

Thanks @TatumCreative ! I'm experimenting with the http://openopensource.org thing so you're a collaborator now. Cheers!

Oh sweet, I've been thinking about trying that out myself.

Wooohooo! Great news!
:dancers: :dancers: :dancers:


TST: Adhoc holidays in CFEExchangeCalendar

Thought of this after pulling latest master & looking at https://github.com/quantopian/zipline/pull/1698

Coverage remained the same at 87.485% when pulling ca9da830fd6e3b53065edf071675aab0ae9fc2ed on adhoc-cfe-calendar-test into 759fc5bdffab47508a014b9dfa2656c27693afd1 on master.

Talked off of GitHub. Gonna merge this 😃


Permalinks for retrieving results

Give users the ability to save their lists to a unique permalink. That way they could be more easily shared / adapted.
Saving to a permalink would have to send all the table data back to the server where it would be stored in a database and assigned a unique ID.

This has been solved actually by allowing users to save results as a pagepile. It doesn't allow for re-loading a past query into the interface but that would pose many more challenges (e.g., saving the seed and articles that were removed from the list). Closing this issue and I'll open a new one for that more comprehensive solution if I see a clear need


(DCOS-447) Sequence authentication attempts

In order:
- validate existing ACS token (if found)
- validate OAuth token (if specified)
- validate username/password (if specified)

tested and LGTM!  ship-it


better way to signal that there's no usable ICU package installed in the system

Describe what happened:
tried every way to start a live collaboration session and it doesn't work.
using the > Live Share: Start Collaboration Session (Share) yields a dialog that says 'liveshare.start' not found
What was your system configuration?
Product and Version [VS/VSCode]:
Version: 1.68.0
Commit: 4af164ea3a06f701fe3e89a2bcbb421d2026b68f
Date: 2022-06-08T11:49:57.055Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.19.2-1-default
OS Version[macOS/Windows]: openSUSE Tumbleweed
Live Share Extension Version: v1.0.5695
Target Platform or Language [e.g. Node.js]: node.js
Steps to Reproduce / Scenario:

Open a project
try to live share

Please attach logs to this issue:
*You can access them via the Live Share: Export Logs command from the command palette (ctrl + shift + p) and attach them to this issue
liveshare-logs.zip
*

https://docs.microsoft.com/en-us/visualstudio/liveshare/reference/linux#tips-for-community-supported-distros for openSUSE Leap says it should be fixable by installing libopenssl1_0_0 gnome-keyring and that the prerequisite install script supports it yet it doesn't work. I'm on Tumbleweed but I have those packages installed and I don't think there'd be a great difference if they're named the same (specially libopenssl1_0_0)

We’ve made improvements in this area since this issue was filed (i.e. the vsls-agent process and associated .NET/Linux dependencies have been removed). We believe this may have improved your experience and are closing this issue. If this issue still persists for you, please comment on the issue and let us know. Thank you.


[Feature Request] Use hardware accelerators for base64 operations

The OTA agent uses base64 decoding when downloading a file. This function is a pure software implementation. More often, microcontrollers have hardware accelerators that offer this functionality.
Possible Solution
The structure OtaInterfaces_t can be extended to set the interface for base64 operations. To support microcontrollers that do not have this possibility, the structure member could be set to NULL.
In function where the base64Decode() is called, the structure member is checked. If it is not NULL, use hardware accelerator API, else use the software implementation in the OTA SDK
Alternatives
The base64_decode function in the SDK could be configured as a WEAK function, offering the possibility to the application to implement a strong function (using hardware accelerators).

Thanks for the feature request - we'll put it in our input queue and prioritize accordingly.

No further development will be performed on this library. See the readme.


The spark-submit command is still running after the tpcds exception exit

use --stop  to stop and clean the TPC-DS


Oracles: unbounded feed values vector

The current oracle's extrinsic feed_values() allows an unbounded Vec as an input parameter. This would allow a member to act badly generating a huge list of values that fill the block computation time for free, because the member is not paying fees under success.
Even if all OracleKey possible values are limited, the vector can still contain duplicates that must be iterated, consuming, in the worst case, the entire block available time.
We think the solution to this is as simple as making this Vec bounded. If you agree, I can add a PR with this change.

I agree. It is usually a good idea to make vec bounded anyway.


Running gives AssetNotFound("index.html")

I am trying to get the plugin to work with my app.
I have followed the instructions in the README, emptied the windows array in the Tauri configs, and added the code in the main.rs.
I can compile and everyone is happy but when the app starts I get these errors:
Asset `index.html` not found; fallback to index.html.html
Asset `index.html` not found; fallback to index.html/index.html
Asset `index.html` not found; fallback to index.html
AssetNotFound("index.html")

And then an empty white window is displayed.
I had a look at the vanilla example and my index.html is available at the same location (src/public/index.html).
I am confused why it's not working.

You don't necessarily need to copy the structure of the example. This plugin serves the frontend files the same way the built-in custom protocol does. So what you need is a index.html file in the root of your configured distDir

You don't necessarily need to copy the structure of the example. This plugin serves the frontend files the same way the built-in custom protocol does. So what you need is a index.html file in the root of your configured distDir

I haven't changed any of the default configs. In my tauri.conf.json I have "distDir": "../build" configured and I can see there is an index.html in that location.

After looking at the vanilla example, I modified the devPath to also match the distDir:  "devPath": "../build" and it's now able to serve the files

Actually @FabianLars I also tried to point to ../public so I didn't have to npm run tauri build every time to see the changes in dev but I am getting these logs and then nothing starts:
Asset `%PUBLIC_URL%/manifest.json` not found; fallback to %PUBLIC_URL%/manifest.json.html
Asset `%PUBLIC_URL%/manifest.json` not found; fallback to %PUBLIC_URL%/manifest.json/index.html
Asset `%PUBLIC_URL%/manifest.json` not found; fallback to index.html

Well normally you can ignore these logs, since manifest.json should be useless (in tauri apps) i think?
But yeah pointing to public won't work if ../build is your actual build output :)

Well normally you can ignore these logs, since manifest.json should be useless (in tauri apps) i think?
But yeah pointing to public won't work if ../build is your actual build output :)

Does this mean that using this plugin prevents the app from reloading the changes when the files have been changed on the frontend side of things?
Right now I need to run npm run tauri build every time and restart to see the new changes.

I'd suggest reverting the devPath change and putting the plugin behind a cfg flag to enable it only in actual builds so that tauri dev works as it used to.
that's what i mean with the flag:
#[cfg(dev)]
{ do_plugin_stuff() }

@FabianLars Silly question, what other cfg flag can I use for build instead? I tried #[cfg(build)] without success.

dev is the only custom flag tauri sets, other than that there's only the cargo-native stuff: https://doc.rust-lang.org/reference/conditional-compilation.html


Correct Readme file

In line number 145 of the readme file the directory funwithphysics is wrongly written and might give error upon running.

I want to correct this.

@VATSAL-IIT its already corrected by someone.

u can work on something else

okay