Question about initializing collections

I'm initializing the same collection with different where clauses like so:
const account = await repo.findOneOrFail({ user });
const invoices = await account.transactions.init({ where: { status: 'invoice' } });
const transactions = await account.transactions.init({ where: { status: 'accepted' } });

But when I log invoices I get this output:
Collection {
      '0': Transaction {
        id: '49b8faa0-c98e-11ea-bbc1-2d10c0dbd922',
        account: Reference { entity: [Account] },
        status: 'accepted',
        amount: 10000,
      },
    }

What am I doing wrong?

Even the queries are right:
select `e0`.* from `transaction` as `e0` where `e0`.`status` = 'invoice' and `e0`.`account_id` = 'e511b4d0-c752-11ea-ad44-8f0b636e4844' order by `e0`.`id` asc

select `e0`.* from `transaction` as `e0` where `e0`.`status` = 'accepted' and `e0`.`account_id` = 'e511b4d0-c752-11ea-ad44-8f0b636e4844' order by `e0`.`id` asc

Let's put it this way:

What am I doing wrong?

You are initializing the same collection with different where clauses.
There is always only one instance of entity, therefore one instance of the collection. By calling the second init method, you override the results of the first one. Don't use Collection.init() here (in general one should not do partial collection loads for this very problem). The method is for initializing the collection, so it is changing the state, it's not about returning the results.
Do this instead:
const account = await repo.findOneOrFail({ user });
const invoices = await em.find(Transaction, { account, status: 'invoice' }); // guessing the column name is `account` here
const transactions = await em.find(Transaction, { account, status: 'accepted' });

Oh, Ok.
Thanks very much.


tightvnc: Add version 2.8.11

What is difference between tightvnc.net and tightvnc.com?
.com hash newer version listed and https compatible
.net is only http and have 2.8.11 version

Applied changes

I don't know :/

Thanks again for the support!


Add dayjs-nuxt to nuxt.config.ts modules, then typescript not working

reproduction zip:
test-typescript.zip
I just create a new nuxt3 app, and add only one module(dayjs-nuxt), then I auto import a const from nuxt.config.ts like the code below
nuxt.config.ts
export default defineNuxtConfig({
  compatibilityDate: "2024-04-03",
  devtools: { enabled: true },
  modules: ["dayjs-nuxt"],
  imports: {
    dirs: ["constants/others"],
  },
  typescript: {
    typeCheck: true,
  },
})

and make the typescript not working

package.json
{
  "name": "nuxt-app",
  "private": true,
  "type": "module",
  "scripts": {
    "build": "nuxt build",
    "dev": "nuxt dev",
    "generate": "nuxt generate",
    "preview": "nuxt preview",
    "postinstall": "nuxt prepare"
  },
  "devDependencies": {
    "@nuxt/devtools": "latest",
    "dayjs-nuxt": "^2.1.9",
    "sass": "1.77.6",
    "sass-loader": "^13.3.2",
    "typescript": "^5.5.4",
    "vue-tsc": "^2.0.29"
  },
  "dependencies": {
    "nuxt": "^3.12.4",
    "nuxt-viewport": "^2.1.5",
    "vue": "latest"
  }
}

If I remove "dayjs-nuxt" from nuxt.config.ts modules, then typescript intellisense works fine

@boss006133 same issue for me, i tried really hard to solve it but couldn't, so i just reverted to using dayjs package directly,
i created project/utils/dayjs.ts:
import dayjs from 'dayjs'
import relativeTime from 'dayjs/plugin/relativeTime.js'
import utc from 'dayjs/plugin/utc'
import timezone from 'dayjs/plugin/timezone'
import isBetween from 'dayjs/plugin/isBetween'
import duration from 'dayjs/plugin/duration'
import 'dayjs/locale/ar'

dayjs.extend(relativeTime)
dayjs.extend(utc)
dayjs.extend(timezone)
dayjs.extend(isBetween)
dayjs.extend(duration)

export const $dayjs = dayjs

this will make $dayjs(...) available in both template and script to use,
am sure this is not the best way to do it, but until this package is fixed this should do.


Euclidean GCD [CPP]

This issue is about Euclidean GCD

[x] Issue Title is in form Euclidean GCD [CPP].
[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[x] This Algo/DS is worth adding to this repository.
[x] Assign this issue to me (I want to work on this).

[x] I ensure that I am not already assigned to 2 or more issues.

[x] I will send my PR only after I'm assigned to this issue by any maintainer.
[x] I understand that I will be unassigned from this issue if I fail to send a PR for this within a week.

GFI @dharmikjethva30


Update tropy to 1.1.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

This can be bumped to https://github.com/tropy/tropy/releases/tag/1.1.1

Closed for https://github.com/caskroom/homebrew-cask/pull/44163


Ship 4.0.0

Before closing out 3.x:

[x] Merge https://github.com/substack/watchify/pull/199 (blocked by https://github.com/substack/module-deps/pull/80)
[ ] Some version of https://github.com/substack/watchify/pull/197 (blocked by https://github.com/substack/node-browserify/pull/1222)

4.0.0:

[ ] Handle ignore logic inside watchify instead of delegating to chokidar. Essentially some form of https://github.com/substack/watchify/pull/202#issuecomment-93072063. This will bring the semantics of ignoring inline with browserify.
[ ] Drop watchify.args (see https://github.com/substack/watchify/pull/204). Sharing caches is a bad idea for most users. Turning off the cache, or using your own cache will be an opt-in.

@jmm I think the 4.x line will be the last one before the row biz is figured out. So 5.0 is hopefully where we reconcile browserify + watchify + module-deps w.r.t. to the row api.

:+1:
Just so I'm clear, the following will still work in 4.x correct?
var b = browserify({ cache: {}, packageCache: {} });
var w = watchify(b);

@mattdesl It will. But it I can't actually get rid of having to pass a { cache: {}, packageCache: {} } somehow into browserify like I wanted in https://github.com/substack/watchify/pull/204#issuecomment-93529664.

@zertosh What's the upshot of that -- will watchify.args be sticking around in some form?

@jmm The cache object gets passed to module-deps when a pipeline is created (grep mopts). By the time watchify is applied to browserify, a pipeline already exists. So I'd have to dig into b.pipeline get module-deps, and modify its options object. Not cool.
But we need some form of watchify.args that creates new cache objects - like your PR.  Unless we do something like:
watchify.args = function() {
  return { cache: {}, packageCache: {} };
};
xtend(watchify.args, watchify.args());

But if users have to change from watchify.args to watchify.args() (or something else), maybe we should leave it as it. Instead change the documentation here, gulp, etc. to explicitly pass {cache:{}, packageCache:{}}.

@zertosh Ok, thanks, I figured that's what the issue was. I posted some ideas in https://github.com/substack/watchify/pull/204#issuecomment-94877114.

Closing this out for now since things still need to be figured out in browserify regarding path matching.


Fix test breakages

[x] leiden/louvain tests are fixed by 71fbae4 circumventing pandas-dev/pandas#31499
[x] test_read_10x[mtx_path1-h5_path1] fixed by theislab/anndata#313
[x] test_plotting.test_clustermap is caused by seaborn mwaskom/seaborn#1953

@flying-sheep, I made two small changes:

The 10x readers should no longer return views, fixing test_read_10x
Slightly cleaner providing of categories for leiden/ louvain code.

For the clustermap test, it's not clear to me that the problems are even related to pandas, though the cause might be: https://github.com/pandas-dev/pandas/issues/18720.
There are two images which are compared in this test. I'll post the comparisons here:
master_clustermap.png
I believe the difference is just the margin, so we should be good to just change the test image.
Expected

Actual

master_clustermap_withcolor.png
This one looks worse, but I'm not sure how to fix it. @fidelram might know better?
Expected

Actual

What dependency causes those? locally the image comparisons succeed.

Whats the timeline here? When will there be a release that includes this fix? Or should I downgrade pandas in the meantime?

You can just use scanpy master if you need this fix ASAP.
Otherwise I think we should release a new version pretty soon after merging #1036.

Great! Thanks a lot, Philipp!


Allowed memory size error caused by the package

Hi. I just added the package to my project and it looks really awesome. Thanks for the such a good tool 🔥
I have only one problem, when I open log viewer, it triggers an error. PHP memory_limit is 128MB, and chunk size in config is set to 50MB.

How can we deal with this?

Hey @centerdevs , thanks for the kind words!

 Is it possible to get a screenshot of the file list on the left?
It's hard to tell when exactly this memory exception occurs. Can you explain a bit what actions are you taking before this exception occurs? Does it happen when first opening up the log viewer? Does it happen when navigating to a big file? Does it happen when searching? etc etc. Exact steps, so I can reproduce it.

Thanks!

I have logs/laravel.log that is always lightweight ( up to 1mb ). And i have larger logs files stored in subfolders, ex. logs/*/big.log - some of big are 150-200mb in size, and my total log folder size is 8 GB.

When i open log-viewer, by default no one file selected, and the error almost instantly occurs by itself, like i see it - it indexing the whole log folder and because of total logs/* size there some problem. What is important, when i open any of "big" 100-200MB logs file - it's absolutelly fine i can explore them without any problem, this happening just with "background" indexing proccess.

BTW, an error occurrs 3-4 times ( 1 error per one log-viewer page refresh in browser ) and after it stops to occurring. It feels like indexing proccess was finished and it will be repated after some time, it's not triggered anymore. After 5 min when i open log-viewer - the error is already triggered :)

I've temporary commented out the code in the the following files - IsScanRequiredController, ScanFilesController.
So now i'll have no errors triggered by the files scanner and the most important - i'll have no scanning of 8GB logs, that i don't really need to scan. It's "cold" logs with some important historical information.

Hey @centerdevs , thanks for helping debug the issue!
I've tagged a new release, v1.8.0 which allows you to disable this eager scanning done at the beginning. I understand not everyone needs this, so this setting makes perfect sense.
Just added some info about it in the docs as well - https://log-viewer.opcodes.io/docs/configuration/managing-indices
Let me know if resolves the issue!

Updated and it works awesome now! thanks a lot !


Add an extra layer of testing using @babel/generator

Test cases can be faulty (this actually happened with the getters and setters PR) and the AST produced by this library may be invalid. The only real way to test if the AST is valid is to use @babel/generator to try to generate code from it.

I made this kind of testing with the help of eslint, counting fatal/unfixable errors in the code generated by @babel/generator. I assume if there are fatal errors the ast generated was invalid

That’s and interesting idea!

One problem is that typescript doesn't quite work with this

I think I have a working implementation of this. Should I make a PR?

Yes, it would be great

I simplified things a bit:

added a new operator compile;
used print from putout and just check if it can be generated or not;
I think we can check things without ESLint for now;

Thanks a lot for ideas! With your help tests looks much simpler :)

I simplified things a bit:

added a new operator compile;
used print from putout and just check if it can be generated or not;
I think we can check things without ESLint for now;

Thanks a lot for ideas! With your help tests looks much simpler :)
I just don't know your testing framework and this putout tool so I just solved it with the tools I know. They seem like really interesting tools that I could definitely use in future projects.

How do you use swc-to-babel by the way :)?

Well it started with the idea I wanted to make compilation times fast in react native. Metro transformers need to return a babel ast so I needed some kind of conversion and I found swc-to-babel. While trying to make this work I discovered all of those bugs.

The print function from putout never seems to throw an exception even if an ast is invalid in a node known to babel.  Since all the files are formatted according to putout rules doing an equals assertion would make this actually work completely as it should

What if generate will be used from putout?

What if generate will be used from putout?

generate was the same behaviour

What AST are you trying?

What if we use parse(print(ast)) and check that printed is the same ast :)?

What if we use parse(print(ast)) === ast and check that parsed is the same ast :)?

It is still not a solution because the ast in the test may not match the source in the first place. I don't there is a great solution on this


Can the page of  "Span Info" be expanded manually?

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[x] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

I wanna check for the exceptions of the "Span Info",  I can't see the full information  because the page so small, is it possible to expand manually?

This is good improvement. Contributions are welcome.

Can you describe the requirements in detail?If you can, please take a screenshot, thank you!

ok, I will finish.

I think manual extension is not convenient. It is better to add a button to pop up a dialog box large enough. What do you think?
@zhaoxunyong

I think manual extension is not convenient. It is better to add a button to pop up a dialog box large enough. What do you think?
@zhaoxunyong

or  Or add a button that automatically changes the box to the size of the content and retracts to its original size.

@x22x22 I remembered the previous version has a right arrow on the top right corner, I can expand it manually.

I think manual extension is not convenient. It is better to add a button to pop up a dialog box large enough. What do you think?
@zhaoxunyong

I think manual extension is not convenient. It is better to add a button to pop up a dialog box large enough. What do you think?
@zhaoxunyong

I remembered the previous version has a right arrow on the top right corner, I can expand it manually.

I remembered the previous version has a right arrow on the top right corner, I can expand it manually.

I think manual extension is not convenient. It is better to add a button to pop up a dialog box large enough. What do you think?
@zhaoxunyong

Or add a button that automatically changes the box to the size of the content and retracts to its original size.

It's good idea~

@zhaoxunyong see https://github.com/apache/skywalking-rocketbot-ui/pull/152

@zhaoxunyong see apache/skywalking-rocketbot-ui#152

Great, you're so efficient!

I just tag this as the last feature PR in 6.4.0, if this could get approve by @TinyAllen


why my {data-src} in  doesn`t work even less a warning

Issue description

version #4.8.0
components: Media

Steps to reproduce issue
-- bootstrap version ^3.3.7

 <Media
    object
    data-src="http://localhost:3600/avatar/0009"
    alt="Generic placeholder image">
</Media>

This library is for bootstrap v4. You should use react-bootstrap if you need bootstrap v3 support.

    <img src="http://localhost:3600/avatar/0009" alt="avatar"/>//works
    <Media
       object
       data-src="http://localhost:3600/avatar/0009"
       alt="Generic placeholder image" />
    </Media>//not

well, I updated my bootstrap to ^4.0.0-beta, it still failed... with my offset went to mess :(

Bootstrap v3 and v4 are drastically different, especially when it comes to spacing thanks to the change from floats to flexbox. Media itself now relies on the new flexbox and spacing utility within bootstrap 4. There is an open an issue to determine how to better address this within reactstrap, but for now just like bootstrap itself, you have to apply those classes yourself. As for the image, just use src. The docs use placeholder.js which uses the data-src to add the fake images. We probably need to not use that or at least not show it being used in the example code which displays.

Nice~ it works!!  I love your avatar very much! @TheSharpieOne


fix: layout conversion for git apps by getting actual page list from current list and dynamic binding path fix

Description
This PR provides a fix by checking the page list from current branch before converting the pages in git connected apps.
This PR also changes dynamic binding paths verification logic to use lodash's get instead of directly accessing key to cater for nested paths
Fixes #22698
Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/build-deploy-preview env=release

/ok-to-test

/build-deploy-preview env=release

/ok-to-test

/build-deploy-preview env=release

/ok-to-test

/ok-to-test

/ok-to-test

/ok-to-test


fix: use "_" as path separator

What kind of change does this PR introduce?
Fix
What is the current behaviour?
#188
What is the new behaviour?
Use _ as path separator
Does this PR introduce a breaking change?
Yes, filenames (especially path schemas) containing special characters could be generated under a different path. Eg: | occurrences replaced by _.
Other information:
Please check if the PR fulfills these requirements:

[X] Tests for the changes have been added
[X] Docs have been added / updated
[X] Relevant Changeset has been added

coverage: 100.0%. remained the same
when pulling 0f6f8e06eeb93c2d77b090b3f2d55d435d426c95 on fix-path-separator
into 74616579b3e1c86a1710f3a5bfba5069b91745c9 on master.

Can confirm it seems to be workin. At least the fastify-integration-plugin example.


Enhancement and Test Suite for pdf printer

Added tests in the pdf.go file and update the Score function to handle invalid scores.
Overview

/describe

/describe


(eval):1: can't change option: zle

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[x] Linux
[ ] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
$ source "$HOME/.fzf/shell/key-bindings.zsh"

(eval):1: can't change option: zle

This occurred when starting zsh in a script using zsh -i. I've changed this to zsh and the error has gone away.


Lists of Enums that are assigned values through the editor have incorrect values at runtime

Godot version
3.3.3
System information
Windows 10
Issue description
I have a list of enum values that is exposed through the editor via the [Export] attribute. At runtime, the first entry in that list has an incorrect value that doesn't correspond to any member of the enum.
I've repro'd the problem in a stripped down project that only contains the following script assigned to a single Node2D.
using Godot;
using System;
using System.Collections.Generic;

public class NodeWithEnumList : Node2D
{

	[Export]
	public List<TestEnum> EnumVals {get; set;}

	// Called when the node enters the scene tree for the first time.
	public override void _Ready()
	{
		foreach(var enumVal in EnumVals)
		{
			Console.WriteLine($"You have an enumVal of {enumVal}");
		}
	}

	public enum TestEnum
	{
		firstVal,
		secondVal
	}

}

Here's what's configured for that Node2D in the editor.

And here's what gets printed out in the console.

Steps to reproduce
Repro steps are included in the 'Issue Description' above, but here's a quick summary of how to repro with the project attached.

Start up the project and make sure that the 'Enum Vals'  property on the Node2D has at least 1 entry assigned to it.
Play the project (you may want to have a debugger attached and a breakpoint in the _Ready() function in NodeWithEnumList.cs)
Look at the console output, or use the debugger to inspect the value of the EnumVals variable.

Minimal reproduction project
EnumBugTest.zip

Duplicate of https://github.com/godotengine/godot/issues/42926.


PR body is blank

Currently, body isn't included in the stuff that gets POSTed to the GitHub API. Even if we fix it, I have a similar issue to the last error where only the first word in the body is sent. I think the solution to this issue or #6 is to either use jq (full disclosure: this is based on one google search) in the shell or switch to a more expressive language like JS. Personally, I think the latter would make this more maintainable but jq would probably work

How would jq help? It's meant to parse json output, not post.
I've successfully used python to read in a file and then send with requests, this might be a more reasonable idea so the user doesn't need to think about how to escape the envar. We could change the post to be done in a similar way, would that work?

My impression was jq could help compose json - looks like I was wrong.
I think that would work? I'm not really an expert on shell files but that sounds reasonable.

I won't be able to take a look until tomorrow, but in the meantime could you please share your main.workflow and the output from the log in your Google action? I will need it to debug further.

https://github.com/VandyHacks/fisherman/runs/132861567
It's all in that repo. Note that I slightly altered the version of the action that that repo runs: https://github.com/bencooper222/pull-request-action/commit/72248aa34f85ae3b74f1862fb5811cb8d87cfb62

All fixed :) See the PR here https://github.com/vsoch/pull-request-action-test/pull/3 and the associated workflow for that repo:
workflow "Create Pull Request" {
  on = "push"
  resolves = "Create New Pull Request"
}

action "Create New Pull Request" {
  uses = "vsoch/pull-request-action@master"
  secrets = [
    "GITHUB_TOKEN"
  ]
  env = {
    PULL_REQUEST_BRANCH = "master"
    PULL_REQUEST_DRAFT = "true"
    PULL_REQUEST_TITLE = "This is the title of the PR"
    PULL_REQUEST_BODY = "This is the body of the PR"
  }
}

The body was missing from the data, and quotes fixed the missing title, etc.

Thanks!


remove truboframes

Description of change
Look at removing turboframes to simplify the back button issue

Trying to look at this on dev and there's no claims? I thought this shared the same store as normal dev?

@elken it does... but it only loads clains created after it was deployed....
if you log into the submit backend and run TestData::NsmBuilder.new.build(min: 220, max: 220) it will create a application with 220 work items abnd 110 disbursements
shout and I can walk you through it.. :)

@elken it does... but it only loads clains created after it was deployed....
if you log into the submit backend and run TestData::NsmBuilder.new.build(min: 220, max: 220) it will create a application with 220 work items abnd 110 disbursements
shout and I can walk you through it.. :)

Can look at it tomorrow then sure 😄


tabsize is always 2, setting ingored. applies when using prettier as well

Issue Type: Bug
I configured tabsize wherever i can to 4. i used prettier but even when i disable prettier (and certainly reload) then the setting
"editor.tabSize": 4
is totally ignored, for all file types.
VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 6.3.9600

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz (8 x 3392)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.70GB (17.27GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (24)

Extension
Author (truncated)
Version

vscode-backtix
adi
1.1.1

Bookmarks
ale
9.0.3

spellright
ban
2.5.32

npm-intellisense
chr
1.3.0

githistory
don
0.4.1

vscode-npm-script
eg2
0.3.5

vscode-highlight
fab
1.2.2

color-scheme-selector
hen
0.2.0

output-colorizer
IBM
0.1.2

Ionide-fsharp
Ion
3.22.2

theme-rusty-icons
ion
0.0.1

vscode-icon-theme
jtl
1.6.2

vscode-position
jtr
1.0.1

favorites
kdc
1.9.1

vscode-typescript-ast-explorer
kri
1.0.0

vscode-simple-icons
Lau
1.8.3

xml-format
mik
1.0.0

csharp
ms-
1.15.2

vetur
oct
0.12.5

vscode-code-outline
pat
0.2.1

vscode-versionlens
pfl
0.21.1

easy-compile
ref
1.1.2

highlight-words
rsb
0.0.7

preact-preact-router-snippets
sar
0.1.2

(21 theme extensions excluded)

more information:
when i acreate a new file, then the tabsize setting is correctly applied. but that size sticks to the document. so the tabsize for a document is freezed at creation time. weird!!!
history:
no document reacts to changing tab size in settings
all files use tabsize 2
create a new file myfile.ts  WHILE tabsize is 7
formatting in myfile.ts uses tabsize 7
formatting in other files NOT
change tabsize setting to 5
formatting in myfile.ts stil uses tabsize 7
all other files still use tabsize 2

Prettier has completely stopped working recently in VSCode. It's like there's a new internal VSCode formatter installed for Javascript which takes precedence, or something is broken entirely. This is a pretty nasty bug since it affects all commits and if we're not careful to manually format exactly like Prettier would've done we're now introducing so much whitespace and formatting noise... Would be nice if there was added some tests for prettier integration so that this does not regress in the future.


releases

#613 got me thinking a little bit about how what we consider this project to be. since probot apps can both be apps but also dependencies for other probot apps i'm a little conflicted on which way to treat this app as far as dependency pinning goes. i typically follow the renovate recommendation to pin all dependencies for apps, but leave definitions as ranges for libraries.
we dont currently publish versioned releases, but we definitely have users running their own instances. @gr2m, you do a good job of handling releases for your probot apps, like https://github.com/wip/app/releases, so i'm curious about your thoughts on this. also, it feels a little odd to start versioning at v1.0.0 now since the app has been around for a while, but i don't have a better suggestion than that either 🤷🏼

I don't see a benefit in publishing an npm package for an app?

no, i agree. i wasnt clear with what i was referring to, partly because i think i've always been a little confused by it myself. i guess i was referring more to the idea of Combining Apps. In that situation, this "app" is less of an app and more of a dependency.
for the common cases of our hosted deployment and others simply running their own instance as an independent app, i fully agree with treating the project as an app. semantic versioning makes less sense to me for projects that are only used as apps, though, since the semantic impact to the consumer really only matters if the project is used as a dependency.
so, those are the ideas that i'm considering when trying to decide if it would be worth publishing releases that are semantically versioned, or approaching the communication of changes in a different way that better suits an app type project. since probot projects can sort of be both, i'm interested in your thoughts to consider how we could communicate changes more effectively.

I have yet to run into a situation where I'd like to combine different probot apps into one. So I can't share much insights myself. Do you know of someone who imports the settings app as an npm package to combine it with others or to use it in their own?
When in doubt, I'd treat it as an "It's a problem when it's a problem" and not publish any npm package, until someone asks for it

Do you know of someone who imports the settings app as an npm package to combine it with others or to use it in their own?

we've seen requests come in to enable some of the functionality in library form, but i consider that as different than how the app is versioned.

When in doubt, I'd treat it as an "It's a problem when it's a problem" and not publish any npm package, until someone asks for it

i agree about not publishing to npm. that wasnt really what i was thinking about anyway at this point. more just trying to think through whether semantic versioning made sense if we decide to publish release notes or better communicate changes in some way. since i knew you used semantic-release for wip releases, thats more the part i was curious about.
it sounds like we agree that we should focus on this project being an app rather than a dependency for others. i'm just not sure what to think about versioning if we improve our communication about changes.

I'd say it's a breaking change when configuration format changes, or any other kinds of interactions with the app. If something used to work and stopps working, that's a breaking change.

thats probably the perspective i wasnt considering. i was thinking more from the perspective of settings as a dependency, but config file compatibility is another interface that changes impact. no disagreement that the types of changes you mention are breaking. versioning for that interface makes sense to me.
thanks for straightening out my thoughts 😄


Can we allow Tabs to be hidden instead of re-rendering?

Question
I'm using Tabs https://www.radix-ui.com/docs/primitives/components/tabs. Whenever changing tab, Content will be re-render. Is there any way to keep it in DOM (only need hide it)? Please help to support. Many thanks!

Closing as duplicate of #1155


Cross compile

This gets everything to cross compile between 2.11 and 2.10. There are a few changes needed:

Some type inferences (multiple levels) don't work in 2.10, so I manually put them in
Yaml.scala caused 2.10 compiler to fail with a NullPointerException, so it is currently not available in 2.10
Due to the case class parameter count limitations in 2.10, I moved RDS and RedShift support to only 2.11

We might be able to accomplish it in other ways - this is a first stab at solving the problem.
Addresses #86

Coverage increased (+0.5%) to 50.578% when pulling d4c90c8be82be406cbe8770d63227f4e6e142c31 on tylersouthwick:cross-compile into c446b80a33df733e031b5639f8edfa7d78020308 on MonsantoCo:master.

This is great. I was going to play around with manually implementing the case class functionality due to the parameter count limitation in 2.10 (I'm not sure whether that's really feasible or not, but I thought it would be worth a shot), but you've made a huge amount of progress.

@tylersouthwick: While this one isn't compiling yet I noticed you made some changes recently. Is this something you still want to get in?

I merged master into it, but not sure if there is value in pursuing this.
Scala 2.12 will make this more difficult.
On Tue, Jan 3, 2017 at 9:50 AM T.J. Corrigan<EMAIL_ADDRESS>wrote:

@tylersouthwick https://github.com/tylersouthwick: While this one isn't
compiling yet I noticed you made some changes recently. Is this something
you still want to get in?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MonsantoCo/cloudformation-template-generator/pull/92#issuecomment-270176371,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjICHaOmLJt9EdBJzStoxDoKTJgXgQbks5rOopagaJpZM4IS8_-
.

FWIW, I was the original requestor, and I agree that this isn't super valuable anymore. We wanted 2.10 support originally to include this library in an sbt plugin, but we've worked around that successfully already. Thanks for your time and effort on it, though!

FWIW, we do have 2.12 support (and still support 2.11) now!

Thanks, closing this then.


[HOTFIX] Set default header for load data in legacy enviroment

Why is this PR needed?
The old code has been commented, this PR will revert the code.
What changes were proposed in this PR?
Set default header for load data in legacy enviroment
Does this PR introduce any user interface change?

No

Is any new testcase added?

No

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/1274/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/2993/

LGTM


No "protected" field in example

https://github.com/erdtman/cose-js/blob/6bade143df9f9a2351c84fa94a6da11e3656258f/test/sign1-tests.js#L14
The "protected" field mentioned in this line is not present in the file   loaded by jsonfile.readFileSync('test/Examples/sign1-tests/sign-pass-01.json") (but it is present in pass-02 and pass-03).

Thanks, I just removed it


Component restructure + add @react-navigation/native

Introduce beginnings of how we want to structure our components and screens and such
Introduce @react-navigation/native and @react-navigation/native-stack for the beginnings of navigation in the app

sorry i had to force push after rebasing the three o.g. commits with main, i was depending my commits on the changes in #7 so i can minimize conflicts because there is a lot of restructuring that happens here

settings this as ready for review despite the lack of proper typing on the navigation prop, will tackle that later because i'd really like to get the navigation bones in


Income From Last Month Incorrect

Invents numbers for prior months with no transactions (prior to starting with YNAB), which throws off all subsequent calculations.

Duplicate of #234


fatal error: 'BridgeAPI/FBSDKBridgeAPIProtocol.h' file not found

Hello,
I have a strange problem with the library and the iOS build.
Every time I try to build the Flutter app, I have this error:
In file included from /Users/g123k/IdeaProjects/untitled/ios/Pods/FBSDKCoreKit/FBSDKCoreKit/FBSDKCoreKit/FBSDKAccessToken.m:21:
    In file included from /Users/g123k/IdeaProjects/untitled/ios/Pods/FBSDKCoreKit/FBSDKCoreKit/FBSDKCoreKit/Internal/Network/FBSDKGraphRequestPiggybackManager.h:19:
    /Users/g123k/IdeaProjects/untitled/ios/Pods/FBSDKCoreKit/FBSDKCoreKit/FBSDKCoreKit/Internal/FBSDKCoreKit+Internal.h:24:9: fatal error: 'BridgeAPI/FBSDKBridgeAPIProtocol.h' file not found
    #import "BridgeAPI/FBSDKBridgeAPIProtocol.h"
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    4 warnings and 1 error generated.

How to reproduce the bug:

Create a new Flutter app with Objective C for the iOS build
Add the following dependency in the pubspec.yaml : flutter_facebook_login: "^1.1.1"
Run the app

I have tried to change the Podfile, but the error is still the same:
# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

def parse_KV_file(file, separator='=')
  file_abs_path = File.expand_path(file)
  if !File.exists? file_abs_path
    return [];
  end
  pods_ary = []
  skip_line_start_symbols = ["#", "/"]
  File.foreach(file_abs_path) { |line|
      next if skip_line_start_symbols.any? { |symbol| line =~ /^\s*#{symbol}/ }
      plugin = line.split(pattern=separator)
      if plugin.length == 2
        podname = plugin[0].strip()
        path = plugin[1].strip()
        podpath = File.expand_path("#{path}", file_abs_path)
        pods_ary.push({:name => podname, :path => podpath});
      else
        puts "Invalid plugin specification: #{line}"
      end
  }
  return pods_ary
end

target 'Runner' do
  use_frameworks!

  # Prepare symlinks folder. We use symlinks to avoid having Podfile.lock
  # referring to absolute paths on developers' machines.
  system('rm -rf Pods/.symlinks')
  system('mkdir -p Pods/.symlinks/plugins')

  # Flutter Pods
  generated_xcode_build_settings = parse_KV_file('./Flutter/Generated.xcconfig')
  if generated_xcode_build_settings.empty?
    puts "Generated.xcconfig must exist. If you're running pod install manually, make sure flutter packages get is executed first."
  end
  generated_xcode_build_settings.map { |p|
    if p[:name] == 'FLUTTER_FRAMEWORK_DIR'
      symlink = File.join('Pods', '.symlinks', 'flutter')
      File.symlink(File.dirname(p[:path]), symlink)
      pod 'Flutter', :path => File.join(symlink, File.basename(p[:path]))
    end
  }

  # Plugin Pods
  plugin_pods = parse_KV_file('../.flutter-plugins')
  plugin_pods.map { |p|
    symlink = File.join('Pods', '.symlinks', 'plugins', p[:name])
    File.symlink(p[:path], symlink)
    pod p[:name], :path => File.join(symlink, 'ios')
  }
end

post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      config.build_settings['ENABLE_BITCODE'] = 'NO'
      config.build_settings['SWIFT_VERSION'] = '3.2'
    end
    # workaround for https://github.com/CocoaPods/CocoaPods/issues/7463
    target.headers_build_phase.files.each do |file|
      file.settings = { 'ATTRIBUTES' => ['Public'] }
    end
  end
end

Thanks for reporting.
Could you:

paste the output from flutter doctor here
see what's the output from pod install command run from the ios folder?

I couldn't debug this on a fresh project on the latest Flutter beta since the pod install command failed due to some CocoaPods error.

Hmm.
I'll look into resolving this when I have the time, can't promise anything currently. Hopefully, you can develop on Android for a while.

Yes the dependency is in the dependencies block

After digging a little bit, if I use the Podfile from the example/ios folder, the app will compile again.
However it means that with the latest beta of Flutter your package should not build.

That's really useful information, thanks a lot!
I'll try to:

Fix the problem, hopefully by just updating the Podfile or something similar
Incorporate a "will it build with latest Flutter version" test for Android & iOS with Travis

Still no ETA when I'm able to fix it, hopefully soon.

Having the same issue. I tried looking into the Podfile but I couldn't do anything because of my lack of knowledge about it. So, it would be really helpful if you could look into this sooner, @roughike? Thank you for the amazing plugin.

Since there's now at least two reports regarding this issue, I'm giving this higher priority. I'll try to fix it ASAP.

Not able to reproduce on a fresh project created with Flutter v0.2.8 and flutter_facebook_login version v1.1.1. @g123k @Samaritan1011001 are you able to repro with a fresh new project created with v0.2.8 of Flutter?

Having the same issue :'(

@Ajit121
When did you create your project? Does it use Swift or ObjC for iOS code?

Created one day ago and used swift. Its working fine for android (Kotlin) but unable to build in ios because of this error.

Oh! this issue is happening for flutter project for using swift only.. Working fine for the project using Objective C. Please fix this issue ASAP.

This has been an issue with Swift projects before, and IIRC, it's not particularly related to this plugin, but more of a Flutter issue.
I can help you debug once I get home. Meanwhile, could you run "flutter --version" and paste the output here?

I had the same issue, so I thought I would detail the steps that worked for me in case someone else lands on this issue too.
Background: My project is a Swift project created quite a few months ago, with a change added to Podfile to deal with Swift plugin issue (so firebase plugin could work). Flutter on dev channel, v0.5.4
Steps that worked for me:

Upgrade cocoa to 1.5  (command line)
Run pod setup  (command line)
Delete Pod folder and Podfile.lock file (project was open in XCode when I did this but I did this using IntellijIDEA)
flutter clean  (command line)
Edit my Podfile file so it matches the latest from flutter for Swift project https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/cocoapods/Podfile-swift  (project was open in XCode when I did this but I did this using IntellijIDEA)
flutter run (command line)
Error message about Bolts/BFURL.h not found in Bolts/BFURL_Internal.h
Quit XCode
flutter run (command line)

It worked! I have no idea why step 9 worked when step 6 didn't, except maybe for step 8 (building for iOS is a bit of a mystery to me, I'm an Android developer)

I can confirm the above works, at least with y setup and xCode 9.3. + Pod 1.5.3. Basically, just do 'pod clean' followed by changing your Podfile to match https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/cocoapods/Podfile-swift and then re-build using xCode. No need to make any manual changes to Podfile


Great work! A question about sampler_method.

When I choose DDIM as sampler method, the results are bad. The results from PNDM sampler method are great.
I want to know the scheduler configs when using DDIM sampler method.

DDIM Inference results, very strange.

That's a good question we'd like to know too./(ㄒoㄒ)/~~

请问你们在训练的时候，Scheduler的设置是什么，有没有可能是训推没对齐？

It seem that it is a bug in diffusers. We should add clip_sample=False to DDIMScheduler and DDPMScheduler.

It seem that it is a bug in diffusers. We should add clip_sample=False to DDIMScheduler and DDPMScheduler.

好的，感谢哈，我尝试一下是不是这个问题。

我打印了decoder的sample范围，大概在-4，4. 如果clip_sample了，那么范围就在-1，1了。这个是不是因为你训练VAE的时候，没有预处理视频的原因？或者是 casual 3d vae 就是会导致这种情况？


Output result to stdout instead of file when setting values

Would be nice to have an option to output the changes to stdout instead of overwriting the file with the changes.

I'm not related to the project, but you can render the AST out using editor.Bytes() and do whatever you want with the bytes: output to stdout, diff against the original version, etc.


Resolving hydra ${now:...} syntax when tuning not working.

When the hydra config is copied over to spawned ray tune processes, resolvers may not work as anticipated. ${now:...} specifically does not work.

This is resolved by pull request #103 as we handle converting the time_output_dir from a string to a Path object in a task_wrapper decorator, which uses the ${now:...} hydra resolver prior to spawning ray tune processes.


Modify ExecuteComputation to create status_RECEIVED file when request is received

Summary
Modify ExecuteComputation to create status_RECEIVED file when request is received
Purpose
Because executing GetComputationResult before the status file is generated will result in an exception of any status file not found
This exception should be raised by a request with a non-existent jobUUID
Contents
Add a new status, RECEIVED
Add function to {create,delete} status_RECEIVED
Add function to request other parties to {create,delete} status_RECEIVED
Modify existing tests
Add test
Testing Methods Performed
CI
Execute GetComputationResult immediately after the job request

@arukuka
Thanks for the review!
I have corrected the points you mentioned.
Please check it

@arukuka
Please check it again.


Support of JOINs in repository calls

Is your feature request related to a problem? Please describe.
As of now, including a related model in the repository calls results in two DB hits, there should be a way to avoid this using joins.
Describe the solution you'd like
There should be an optional parameter that when provided should fetch the related models using JOINS instead of separate DB calls -
repo.find({include: [{relation:'child', join:true}]});
Describe alternatives you've considered
Other options that were considered were contributing to the loopback connector repo, but that would be time consuming, so  could try an extension for repositories instead.

need to change interface for calling the join based provider

Closing as @loopback/sequelize serves the purpose.


Cybersource:  Adds ability to have stored ACH purchases.

It was noticed that the cybersource gateway was interpreting all transactions as stored credit cards, when it was possible to encounter stored ACH payment sources.
This change simply passes in what kind of transaction it is, 'check' or 'credit_card', whenever a tokenized operation is performed (Because if all you have is a token, you cant tell what kind of operation it is).  This information is included in the options hash under the key  :source_type.
The stubbed xml responses for store and purchase where taken directly from the chargify store and purchase raw gateway logs.
The soapfault message change was done to fix a broken test, not sure how long it has been broken, but its not related at all to this change.
There is a remote tax test that fails, but this appears to be related to configuration in the backend merchant account and is not relevant.

I suppose, in order to submit this for inclusion in upstream AM, we would have to figure out what account those tests are running against, and get that account configured for ACH?  This has some company-specific details in it.

@wsmoak @speric  https://github.com/chargify/active_merchant/pull/60/commits/a01842e7983231d1cd7ed244d24da1bffdbf05ef


sphinx-build dependency missing

I've installed sphinx-autobuild through pip on Fedora 29.
After running sphinx-autobuild -z <codesourcepath> "<docspath>" "<outputpath>" I'm getting:
+--------- manually triggered build ---------------------------------------------
Traceback (most recent call last):
  File "/usr/bin/sphinx-autobuild", line 11, in <module>
    sys.exit(main())
  File "/usr/lib/python2.7/site-packages/sphinx_autobuild/__init__.py", line 312, in main
    builder.build()
  File "/usr/lib/python2.7/site-packages/sphinx_autobuild/__init__.py", line 175, in build
    subprocess.Popen(args, stdout=slave)
  File "/usr/lib64/python2.7/subprocess.py", line 394, in __init__
    errread, errwrite)
  File "/usr/lib64/python2.7/subprocess.py", line 1047, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
make: *** [Makefile:18: livehtml] Error

By further investigation I found out that I'm missing sphinx-build executable. I believe this should be marked as dependency. Or at least improve the error message.

the args contained ['sphinx-build', '-v', '-T', '<valid path>', '<valid path>']

And it would be nice to have a command line flag for manually specifying sphinx-build executable location.

Hah. That's a good point. :)
And, the related request seems to be for #58.


docs: 'pip install' commands should use lower case 'moderngl'

Description
The docs and examples contain a few 'pip install' commands that show the older:
pip install ModernGL

I changed them to use the latest lower-cased:
pip install moderngl

I'm just assuming that all the docs and examples still work correctly on v5.x. It could be that I've updated things that should have remained as they are.
Thank you for the invitation to add myself to the README but my contributions are all so tiny that I don't feel worthy. Hugs!

Than you! It is more consistent to install and import "moderngl"


Adding MIT license to the gemspec.

I'm working on VersionEye and my goal is to build up a license db for RubyGems which is complete. To reduce the manual work I'm doing currently it would be awesome if this gemspec would contain the license information in future. Many Thanks.

Merged, thanks!


review all early aborts

We might have some ordering issues, where an early abort hides UB or produces the wrong error.

In terms of "wrong error", often it is just not clear what the right error is when multiple error conditions apply -- like deallocating a pointer with the wrong size and alignment (and maybe even non-0 offset from the allocation base).

Things have been refactored several times since this issue was opened, is there still something actionable about this issue? I think we are now checking the alignment properly for all zero-sized accesses, and that was the main concern here if I recall correctly.


2.15 release notes

Description
Notes, generated with my script
Issues Resolved
No notes
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

i did something similar a long time ago but based on copied text from github web

I almost ended up going this route because the API doesn't have a built-in way to see what the original PR is -- in GH web it's easy to find the source PR for a backport but with the API you need to infer it by pattern matching. It's still not perfect, the notes have a few backports in there, but it correctly finds the majority of the PRs (and I'm not actually sure what factors cause it to fail to find the original, it seems pretty random).


Dev test merge

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Cancelling, was testing some dev/main manipulation to publish a docs-only "release"


Cleanup references to unsent JadeServer methods

Running ClassOrganizer new sentButNotImplementedReport one sees numerous entries for JadeServer methods that are unsent on the server. While some are still being called from the Jadeite client, many are obsolete and should be removed.
Full list is here:
20200702 sentButNotImplemented.txt

Not going to impact anything but server tests. Still we should clean this up before the 3.6 release. Labeling as Critical so it won't get lost.

Actually, the server tests will be run against an extent without Rowan installed, so it isn't as critical as it once was ... OTOH, it should be cleaned up before we start work on 3.7 ... I would prioritize V2.0 GUI ahead of the SNI ...

The list is very long; it would be good to do a pass for cleanup.

I've made a pass at removing methods. Here's the new unsent methods report.
20220825_newNotImplemented_after_JadeServer_mass_purge.txt

Still more cleanup needs to be done, so not sure why this was closed. I don't suppose it's urgent for first release, though.

The original (unwritten) request was to shorten the list of unsent methods that (I think) showed up in lint.  That was done. While more work can be done, it didn't seem there was an immediate need to do more and "cleanup" is a never ending task so closing seemed appropriate.


Packages with comments in spago.yaml might break

We are trying to parse spago.yaml using fromYAML but the latter only supports the skeletal syntax that spago.lock uses.
https://github.com/thomashoneyman/purescript-overlay/blob/c7d9df1e916aa976125f4459d1bc2a480b75e43b/nix/build-spago-lock.nix#L188
For now we should probably just emit 0.0.0 until there is a better solution. I'm not holding my breath for this PR but it seems the be the right way of doing things.
https://github.com/NixOS/nix/pull/7340

From what I have read, the IFD feature is a performance and DX footgun. It could block parallelized building on the single-threaded evaluator (references below). This means that using purescript-overlay in bigger projects might result in meh developer experience. IMHO a project needs a very compelling reason to use IFDs and emitting the right version number in the nix store path doesn't cut it.
Even more so, I stumbled upon this because as part of my work on running spago tests, I found a need to get the name of the main module of a test, which is present in spago.yaml but not spago.lock. Not being able to parse the YAML using pure nix means that in general case the user has to pass the name of the main module of the test explicitly, which means duplication. Even this I find preferable to using IFDs.
Alternatives
If a pure-purescript implementation of yaml parsing existed maybe we could have used it via PureNix, but the only one I found is using FFI.
References:

A comment from edolstra from 2017 about IFDs
A blog post about IFDs


K3s Service CrashLoop After Reboot on armhf

Environmental Info:
K3s Version: k3s version v1.20.2+k3s1 (1d4adb03)

Node(s) CPU architecture, OS, and Version: Linux w1 5.3.8-aml-OC-BonusCloud #6 SMP Mon Nov 11 18:32:45 PST 2019 armv7l GNU/Linux

Cluster Configuration:

1master,4workers
Describe the bug:

worker status is aways not ready after reboot worker and master
Steps To Reproduce:

Installed K3s: curl -sfL https://get.k3s.io | K3S_URL=https://k1:6443 K3S_TOKEN=TOKENXXX sh -

Expected behavior:

worker status ready
Actual behavior:

worker status notReady
Additional context / logs:

syslog.txt

after run the script /usr/share/agnostics/sdtest.sh result:
sh /usr/share/agnostics/sdtest.sh
Run 1
prepare-file;0;0;14945;29
seq-write;0;0;13727;26
rand-4k-write;0;0;5685;1421
rand-4k-read;11943;2985;0;0
Sequential write speed 13727 KB/sec (target 10000) - PASS
Random write speed 1421 IOPS (target 500) - PASS
Random read speed 2985 IOPS (target 1500) - PASS

Your kernel appears to be missing many critical modules. Can you run k3s check-config and verify that you have all the required modules?
Feb  9 19:08:02 localhost k3s[1216]: W0209 19:08:02.179764    1216 iptables.go:564] Could not set up iptables canary mangle/KUBE-PROXY-CANARY: error creating chain "KUBE-PROXY-CANARY": exit status 3: modprobe: ERROR: ../libkmod/libkmod.c:586 kmod_search_moddep() could not open moddep file '/lib/modules/5.3.8-aml-OC-BonusCloud/modules.dep.bin'
Feb  9 19:08:02 localhost k3s[1216]: modprobe: FATAL: Module ip_tables not found in directory /lib/modules/5.3.8-aml-OC-BonusCloud
Feb  9 19:08:02 localhost k3s[1216]: iptables v1.6.0: can't initialize iptables table `mangle': Table does not exist (do you need to insmod?)
Feb  9 19:08:02 localhost k3s[1216]: Perhaps iptables or your kernel needs to be upgraded.
Feb  9 19:08:02 localhost k3s[1216]: I0209 19:08:02.181693    1216 conntrack.go:103] Set sysctl 'net/netfilter/nf_conntrack_max' to 131072
Feb  9 19:08:02 localhost k3s[1216]: F0209 19:08:02.182980    1216 server.go:495] open /proc/sys/net/netfilter/nf_conntrack_max: no such file or directory

Your kernel appears to be missing many critical modules. Can you run k3s check-config and verify that you have all the required modules?
Feb  9 19:08:02 localhost k3s[1216]: W0209 19:08:02.179764    1216 iptables.go:564] Could not set up iptables canary mangle/KUBE-PROXY-CANARY: error creating chain "KUBE-PROXY-CANARY": exit status 3: modprobe: ERROR: ../libkmod/libkmod.c:586 kmod_search_moddep() could not open moddep file '/lib/modules/5.3.8-aml-OC-BonusCloud/modules.dep.bin'
Feb  9 19:08:02 localhost k3s[1216]: modprobe: FATAL: Module ip_tables not found in directory /lib/modules/5.3.8-aml-OC-BonusCloud
Feb  9 19:08:02 localhost k3s[1216]: iptables v1.6.0: can't initialize iptables table `mangle': Table does not exist (do you need to insmod?)
Feb  9 19:08:02 localhost k3s[1216]: Perhaps iptables or your kernel needs to be upgraded.
Feb  9 19:08:02 localhost k3s[1216]: I0209 19:08:02.181693    1216 conntrack.go:103] Set sysctl 'net/netfilter/nf_conntrack_max' to 131072
Feb  9 19:08:02 localhost k3s[1216]: F0209 19:08:02.182980    1216 server.go:495] open /proc/sys/net/netfilter/nf_conntrack_max: no such file or directory

Thank you brandond.
k3s check-config helps me find the kernel problem.


Cordon zeus22/issue1997

Describe your changes
Add a SubStat filter to the weapon page in archives.
Should I add a filter for no-substat ?
Issue or discord link

Close #1997

Testing/validation

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

[x] I have commented my code in hard-to understand areas.
[x] I have made corresponding changes to README or wiki.
[x] For front-end changes, I have updated the corresponding English translations.
[x] I have run yarn run mini-ci locally to validate format and lint.
[x] If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

"no substat" is only for 1*/2* weapons, so I think leaving them out is fine imo.

So filtering them out if the substat filter is used ?

So filtering them out if the substat filter is used ?

yes, that should work.

I can't request a review


Problem: Typos in variable names left during some conflict resolution

Solution
Fix var names.
Fixes #2363

Codecov Report

Merging #2364 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2364   +/-   ##
=======================================
  Coverage   83.07%   83.07%
=======================================
  Files          38       38
  Lines        2245     2245
=======================================
  Hits         1865     1865
  Misses        380      380


direction: set font-size in placeholder to 14px

Description
Need to confirm if this is the expected value on desktop too

It seems it's the expected value on desktop according the the mockups. I'm going to merge this one.


Command not showing any result

Hi,
In Shell copied the command
After 3 sec it returns to prompt without installing anything.
I have a "dummy" VM installed.
I'm stucked.
What could go wrong?
Thank you

Solved - DNS issue.
Sry for fake issue.


gnome3 enables networkmanager, which disables useDHCP, which breaks initrd network

Issue description
On a system with initrd networking configured with DHCP, if you change services.xserver.desktopManager.gnome3.enable to true, suddenly

nixos/modules/services/x11/desktop-managers/gnome3.nix defaults networking.networkmanager.enable to true,
so nixos/modules/services/networking/networkmanager.nix forces networking.useDHCP to false,
so nixos/modules/system/boot/initrd-network.nix refuses to run udhcpc,
so the initrd environment has no networking.

You might agree that this is a surprising consequence of enabling a desktop environment.
Technical details

system: "x86_64-linux"
host os: Linux 4.14.81, NixOS, 18.09.1373.50fb6820759 (Jellyfish)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.1.3
channels(root): "nixos-18.09.1373.50fb6820759"
channels(anders): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

.useDHCP can be set per-interface: networking.interface.$name.useDHCP = true
and initrd-network understands it since https://github.com/NixOS/nixpkgs/pull/46459 (not sure if it was backported to 18.09)
networking.useDHCP = true means that interface names are unknown at the configuration time and DHCP is to be tried on all the interfaces.

@volth #46459 was not backported to 18.09. (The scenario I’m describing really happened to my 18.09 system, it’s not hypothetical.)

I agree, NetworkManager enabled as a side effect of enabling a desktop manager is surprising to say the least. To me, this was especially confusing as I was enabling and configuring dhcpcd and configuring for appropriate interfaces - which was working up until I enabled gnome3 for another user.
I'm not positive how exactly, but it would seem as though the config's intent to configure another network "utility/daemon/manager" could result in NetworkManager /not/ being enabled.

Just came across that when trying to add SSH LUKS unlocking to a machine that uses NetworkManager.


TextFormField is not focused when tapping it again after entering Japanese characters without pressing done but closing keyboard

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce

Add a Japanese Keyboard to your iPad
Run the below code sample
Enter あいう (these are Japanese characters) on TextFormField A
Tap the right bottom button on the keyboard
Tap TextFormField A again
Enter あいう (but nothing reflects on TextFormField A)

I am testing this on iPad Air third generation on iPad OS 16.6.1.
Expected results
Without even tapping the done button on the keyboard, any Japanese characters can be reflected after opening the keyboard again.
Actual results
Any Japanese characters cannot be reflected on TextFormFiled after hiding the keyboard from the right bottom button.
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: HomePage(),
    );
  }
}

class HomePage extends StatefulWidget {
  const HomePage({super.key});

  @override
  State<HomePage> createState() => _HomePageState();
}

class _HomePageState extends State<HomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: ListView(
        padding: const EdgeInsets.all(16),
        children: [
          TextFormField(
            decoration: const InputDecoration(labelText: 'TextFormField A'),
          ),
          TextFormField(
            decoration: const InputDecoration(labelText: 'TextFormField B'),
          ),
        ],
      ),
    );
  }
}

Screenshots or Video

Screenshots / Video demonstration
https://github.com/flutter/flutter/assets/125345277/475d5f22-56eb-4655-a6aa-f2efab296f8b

Logs
No response
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.13.9, on macOS 13.4.1 22F770820d darwin-x64, locale ja-JP)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.84.2)
[✓] Connected device (3 available)
[✓] Network resources

@dam-ease
Thanks for trying this issue if it can reproduce.
When I tried this case on the Simulator, there was no problem. But when I use the physical device, it happens.
Could you please try not on the Simulator but the physical device if you have any?

Thanks for testing on the physical device but iPhone.
I also tested on my iPhone X but it seems that the issue happens only on the physical iPad device.
I really hope that anyone who has a physical iPad device could test this case.
Thanks.

/cc @LongCatIsLooong to repro on a physical iPad.

Thanks for testing on the physical device but iPhone. I also tested on my iPhone X but it seems that the issue happens only on the physical iPad device.
I really hope that anyone who has a physical iPad device could test this case. Thanks.

I also encountered this issue, my device is an iPad (9th generation) #141546

I have encoutered this too in https://github.com/flutter/flutter/issues/142294 and https://github.com/flutter/flutter/issues/142437;
and operate sequence is exactly the same;  when reproduce you should use the bottom-right key instead of the done/enter key;
it can be reproduced with iPad of 15.X and 16.X using flutter 3.13 and above ;  flutter 3.10 had no such problem;
iPad 17 had no such problem;

@huycozy @dam-ease @danagbemava-nc I hope you can find a physical device to help reproduce it; and hope we can make some progress;
Please!

I tested this issue on Flutter 3.19.2 but could not reproduce so it might be fixed through Flutter upgrade.
@wanjm I hope you can test the same issue where it could be reproduced and report the result.

The same problem can be reproduced in flutter 3.19.2. Please check and respond.
https://github.com/flutter/flutter/issues/144768

@shm40 @dam-ease
This problem is currently being reproduced in flutte 3.19.2.
It can be reproduced on the actual iPad device.
The keyboard can be reproduced by setting it to Japanese (romaji).
If this problem occurs once, the app will malfunction from then on until you run the app again.
As an example, even after moving to another screen, the keyboard is displayed when you touch the screen.
The problem is serious. Once this happens, it becomes difficult to use the App anymore.
It definitely needs correction.
I hope this will be fixed in the next version of Flutter.
Please respond to the issue.

I was able to reproduce it by pressing the hide button at the bottom right of the iPad software keyboard.

I was able to reproduce it by pressing the hide button at the bottom right of the iPad software keyboard.

you're right. Same in my case.
This was reproduced when I pressed the keyboard down button located at the bottom right of the keyboard.

@hohoins @sanghyuk-nam @shm40 please thumbs the first post, and try to make it be noticeable;

https://github.com/flutter/flutter/assets/3438181/29e00bf0-0c84-4601-b817-2ef90422b4fa

@hohoins
Thanks for your reports.
I tested this issue with your sample code on iPad Airt 3rd gen with iPad OS 17.3.1 but could not reproduce it.
It seems that your iPad OS Version is older than me.
Could you please test the issue again after upgrading the iPad OS version?
https://github.com/flutter/flutter/assets/125345277/c3cd72be-d52d-4a16-8148-0ae4e5ca0f9f

@hohoins Thanks for your reports. I tested this issue with your sample code on iPad Airt 3rd gen with iPad OS 17.3.1 but could not reproduce it.
It seems that your iPad OS Version is older than me. Could you please test the issue again after upgrading the iPad OS version?
b8a3584d-74ec-4753-9932-f4f87867f09e.mp4

Thank you for your interest in this bug.
I will try to reproduce it again by updating iPad OS.
I will contact you.
thank you
👍👍👍👍👍👍👍

@shm40
I upgraded to iOS 17.4.1 on my iPad.
After the upgrade, it seems that it cannot be reproduced by simply opening and closing the keyboard.
👍👍👍👍👍
But if I change the way I reproduce it, it's still possible.
If you need to register a new issue, please contact me.
A reproduction video is attached.
How to reproduce:

Enter a few characters of text in TextField
Select a letter by long pressing it in the TextField
Press the back button on the keyboard to delete a letter
Close the keyboard with the down button at the bottom right of the keyboard.
TextField does not respond when touched

If reproduction is not possible, repeat the above process.
In my case, it was possible to reproduce it within 10 times.
If I put my mind to it, I can 100% reproduce it.
https://github.com/flutter/flutter/assets/3438181/5c3d5f83-677c-4f7e-a3eb-62eb7bee71ed

I tried this on a device with an older version of iPadOS (13.3), and iOS17.2 simulator. The bug is not reproducible on either of them. It looks like this isn't reproducible on iOS 17+ devices so I'll close this one as not reproducible anymore.
@hohoins I'm not able to reproduce the other bug either, could you create a new issue for this?

@LongCatIsLooong @shm40
The issue has been closed.
But it didn't solve the TextField issue.
This issue is still reproducible in the latest version.
It even has nothing to do with keyboard language settings.
I plan to register this phenomenon as a separate issue.
thank you

@hohoins  where is your new issue;

wanjm

Thank you for contacting me.
The newly created issue is here.
https://github.com/flutter/flutter/issues/145751


Make check_visibility() a documented API

Spotted this while working on:

#1677

https://github.com/simonw/datasette/blob/e627510b760198ccedba9e5af47a771e847785c9/datasette/utils/__init__.py#L1005-L1021

Documentation: https://docs.datasette.io/en/latest/internals.html#await-check-visibility-actor-action-resource-none


coccinelle: Add script to find cases of unsigned < 0

Unsigned expressions cannot be less than zero and presence
of such practices very likely indicates a bug.
Signed-off-by: Himanshu Jha<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3200914). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #11132   +/-   ##
=========================================
  Coverage          ?   53.11%
=========================================
  Files             ?      218
  Lines             ?    26868
  Branches          ?     5952
=========================================
  Hits              ?    14271
  Misses            ?    10162
  Partials          ?     2435

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3200914...cce9808. Read the comment docs.

+1 for this patch, this is useful for Misra-c :)

What virtual org does?

doc/application/coccinelle.rst ;)
org generates a report in the Org mode format of Emacs.
Virtual rules:
http://coccinelle.lip6.fr/docs/main_grammar001.html
virtual keyword is used to declare virtual rules. Virtual rules may be subsequently used as a dependency for the rules in the SmPL file. Whether a virtual rule is defined or not is controlled by the -D option on the command line.

So, for example you add virtual org in a script then you run:
$ spatch -D org --sp-file foo.cocci test.c
or
$ ./scripts/coccicheck --mode=org --cocci=foo.cocci test.c


Added getBloodGlucoseSamples

@ksetrin  Can you also include Typescript definition if you know how to do it, before I test it out tomorrow (it's midnight now).

@aboveyunhai Typescript definition for what?
I already added some here to index.android.d.ts

@ksetrin  My bad, I accidently take it as PR for both read/write. It's not the right time for me to review code anyway. Good Night.

@aboveyunhai added write BloodGlucose

@aboveyunhai all done

@aboveyunhai all done
LGTM.
leave me some time for me to test through it.

@ksetrin
the reading part works correctly but only return partial data (FIELD_BLOOD_GLUCOSE_LEVEL) as far as from the testing.
TLDR: I could accept this PR since the main value works correctly, and if the feature is really important for your case.
But I will overwrite some of codes (parts of code are still using deprecate) and add all the optional fields, enum etc. in the future.
To give you a idea, the processData() used internally is more of a general approach in the past but lacks of options field to handle different types of Fintess data.
This is one of the annoying part of this project, if you ever had a chance to read through other files. They all have their own process data function due to datatype, field datatype difference.
The current processData() ignore all options fields from the blood_glucose.
Similar issue exists for saving, all the optional fields are missing, Ideally, we may/may not include them depending on the user input. As well as creating Enum to allow user the pass those int to represent each optional field. There are some datatype cases need to be address otherwise it will crush app.
https://developers.google.com/fit/scenarios/write-blood-glucose-data?hl=en
https://developers.google.com/fit/datatypes/health#blood_glucose

We need blood glucose now in the project. It will be good to use from the library from main repo instead of fork
But I'm not Java developer, and for me it will be good to have a consultation opportunity.
Let's merge what we have right now and improve it over time


Question about util.project_xy()

Hi,
First, Thank you for the excellent work!
I've been trying to understand the work done in src/ncltpoles
util.poject_xy()
I have a question regarding the function util.project_xy(). I don't really understand what transformation it's achieving ?
ncltpoles.save_local_maps()
Also, in the function ncltpoles.save_local_maps(), I don't understand why we need to do
T_w_mc = util.project_xy(session.T_w_r_odo_velo[imid[i]].dot(T_r_mc))
Couldn't we simply have done
T_w_mc = session.T_w_r_odo_velo[imid[i]].dot(T_r_mc)  ?
And why T_m_r couldn't simply be T_m_r = T_m_mc.dot(T_mc_r) ?
Thanks,

Hello, sorry for the late response.
util.project_xy() is used to project the original 3-dim transformation to the 2-dim since our work only focuses on localization in 2D space.
Yes, we can calculate T_m_r = T_m_mc.dot(T_mc_r) as in https://github.com/PRBonn/pole-localization/blob/96f15f8125e8b78da8282c4be127385ada3410a0/src/ncltpoles.py#L29.
But in save_local_maps() we use T_m_r = np.matmul(T_m_w, T_w_r)  because the calculation of T_m_w and T_w_r is more straightforward.


fix(trace): fixing runner duration bug

:tada: This PR is included in version 1.23.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Button "Share logs file" => Error. Error Talker Wrapper.

I don`t have folder /data/data/com.example.spez_bud(default folder when App is installed).

this is an emulator (Android API 30)
I think this is why an error.

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to TalkerScreen Page
Navigator.of(context).push(                        MaterialPageRoute(                          builder: (context) => TalkerScreen(talker: talker),                        )                    );
Click on three lines button (menu button), at the right corner
Click on "Share logs file" Button
Error

talker_flutter: ^4.4.0
E/flutter (11483): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: PlatformException(Share failed, Failed to find configured root that contains /data/data/com.example.spez_bud/cache/share_plus/talker_logs_2024-08-28 21 23 53.935457.txt, java.lang.IllegalArgumentException: Failed to find configured root that contains /data/data/com.example.spez_bud/cache/share_plus/talker_logs_2024-08-28 21 23 53.935457.txt
E/flutter (11483): 	at androidx.core.content.FileProvider$SimplePathStrategy.getUriForFile(FileProvider.java:867)
E/flutter (11483): 	at androidx.core.content.FileProvider.getUriForFile(FileProvider.java:467)
E/flutter (11483): 	at dev.fluttercommunity.plus.share.Share.getUrisForPaths(Share.kt:188)
E/flutter (11483): 	at dev.fluttercommunity.plus.share.Share.shareFiles(Share.kt:96)
E/flutter (11483): 	at dev.fluttercommunity.plus.share.MethodCallHandler.onMethodCall(MethodCallHandler.kt:46)
E/flutter (11483): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:267)
E/flutter (11483): 	at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:292)
E/flutter (11483): 	at io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$io-flutter-embedding-engine-dart-DartMessenger(DartMessenger.java:319)
E/flutter (11483): 	at io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)
E/flutter (11483): 	at android.os.Handler.handleCallback(Handler.java:938)
E/flutter (11483): 	at android.os.Handler.dispatchMessage(Handler.java:99)
E/flutter (11483): 	at android.os.Looper.loop(Looper.java:223)
E/flutter (11483): 	at android.app.ActivityThread.main(ActivityThread.java:7656)
E/flutter (11483): 	at java.lang.reflect.Method.invoke(Native Method)
E/flutter (11483): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
E/flutter (11483): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)
E/flutter (11483): , null)
E/flutter (11483): #0      StandardMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:648:7)
E/flutter (11483): #1      MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:334:18)
E/flutter (11483): <asynchronous suspension>
E/flutter (11483): #2      MethodChannelShare.shareXFiles (package:share_plus_platform_interface/method_channel/method_channel_share.dart:108:20)
E/flutter (11483): <asynchronous suspension>
E/flutter (11483): #3      downloadFile (package:talker_flutter/src/utils/download_logs/download_nonweb_logs.dart:13:3)
E/flutter (11483): <asynchronous suspension>
E/flutter (11483): #4      TalkerViewController.downloadLogsFile (package:talker_flutter/src/controller/talker_view_controller.dart:67:55)
E/flutter (11483): <asynchronous suspension>
E/flutter (11483): #5      _TalkerViewState._shareLogsInFile (package:talker_flutter/src/ui/talker_view.dart:215:5)
E/flutter (11483): <asynchronous suspension>
E/flutter (11483):

Hello @Callemul !
Please explain on which device did you try to perform this action and is the error being repeated now?

sorry, the problem is not actualy now. Don`t need check "is it solved"... But Your library very useful for us in Terminal for us!


replace U64 fields with primitive u64

Describe the feature
we have a lot of U64 fields, in this file:
https://github.com/paradigmxyz/reth/blob/ead753db4c96f5f9f0fd2867106d88ef6d312405/crates/rpc/rpc-types/src/mev.rs#L37-L38
this should be replaced with u64, Option<u64> and and a serde attribute [serde(with = "alloy_rpc_types::serde_helpers::num::u64(_opt)_via_ruint")]
Additional context
No response

Can i take it?
for this, after we replace U64 with u64 from primitives we have to replace/add the assigned serde attribute with the one you mentioned right?

we have to replace/add the assigned serde attribute with the one you mentioned right?

yeah for Option it's u64_opt_via_ruint and for U64 it's num::u64_via_ruint


32 bit build fix

std::mem::transmute needs source and destination types to have exactly the same size.  On 32 bit systems sizeof(void *) != sizeof(u64) so this fails to compile.  The bindings define godot_rid as (a newtype of) [u8; u8size] so transmuting to usize should always work.

I wonder if there's an easy way to set up a 32 bit compilation target on travis. I guess this could be done in a separate PR.
Thanks you for this! :blue_heart:


Okd 4.2 with update clusterup

What this PR does / why we need it:
This PR is the okd-4.2 branch rebased on slintes:update-clusterup.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Add okd-4.2 with okd-4.x stabilization fixed

/test pull-kubevirt-e2e-okd-4.2

@slintes @cynepco3hahue et al, I've rebased my PR on the okd 4.1 stabilisation PR #2623. We'll see how it goes. Looking good so far (at least for the okd 4.2 lane)

/test pull-kubevirt-e2e-okd-4.2

@slintes now, what do you think about the latest test results?

@slintes now, what do you think about the latest

well... not great, but good enough? Not sure.
I would say: let's merge, run always, but keep optional for now. That way we get some stats for flaky tests, but it does not block tide yet
@rmohr @cynepco3hahue  wdyt?

Optional sounds good to me.

Optional sounds good to me.

Taking it back. I don't think that we have the capacity in CI to run it if we don't stop running one or two other lanes.

OK, IIUC I'll wait for merge #2623, then rebase this one. OTOH we can merge  kubevirt/kubevirtci#150 then, so that I can use the git hash from master.
@slintes @rmohr @cynepco3hahue makes sense?

/test pull-kubevirt-e2e-okd-4.2

/test pull-kubevirt-e2e-okd-4.2

/test pull-kubevirt-e2e-okd-4.2
AFAIU I need to rebase my kubevirtci branch on master also, will do that. In the meanwhile still running the tests to see whether it gets better.

/test pull-kubevirt-e2e-okd-4.2

/test pull-kubevirt-e2e-okd-4.2

/test pull-kubevirt-e2e-okd-4.2

/test pull-kubevirt-e2e-okd-4.2

/test pull-kubevirt-e2e-okd-4.2

Closing this PR as thjere is no way of provisioning the OKD-4.2 cluster any more.


use internal modifiers for constructor

closes #75

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ

contracts/BNBPartyFactory.sol
100.00% <100.00%> (ø)

contracts/BNBPartyFee.sol
100.00% <ø> (ø)

contracts/BNBPartyManageable.sol
100.00% <ø> (ø)

contracts/BNBPartyModifiers.sol
100.00% <100.00%> (ø)

contracts/BNBPartyState.sol
100.00% <100.00%> (ø)


How to do typed queries multiple levels deep such as findOne(RootObject::somefield::name eq "x")

How do I write typed queries similar to:
collection.findOne("{ 'somefield.name' : 'MYID' }")

I've been trying a lot:
        println("x0 = ${collection.findOne(RootObject::somefield::name eq "MYID")}")  // doesnt compile
        println("x1 = ${collection.findOne(eq(RootObject::somefield.name, "MYID"))}") // null
        println("x3 = ${collection.findOne(eq(RootObject::somefield.name.json, "MYID"))}") // null
        println("z = ${collection.findOne("{ 'somefield.name' : 'MYID' }")}")  // works as expected

I've debugged by printing the query:
        println((RootObject::somefield::name eq "MTID").json)  // {"name": "MYID"}

And it makes sense that the property doesn't know the path from the Root downto the child property, but is there a way to write such queries? If not, then what is the recommended equivalent?

You wan write RootObject::somefield / FieldClass::name . See also https://litote.org/kmongo/typed-queries/#nested-properties & https://litote.org/kmongo/typed-queries/#kmongo-annotation-processor
HTH


rocmPackages: fix deprecation notices for miopengemm, add deprecation notice for mivisionx-opencl

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Closing as duplicate of https://github.com/NixOS/nixpkgs/pull/300220


Handle unsupported python/ruby versions in a better way

Describe the bug you encountered:
Pyroscope-rs let's you install on unsupported python and ruby versions and then swallows the fact that it cannot upload the profiles silently
What did you expect to happen instead?

Document explicitely which python/ruby versions you support
Add these requirements in the python and ruby libraries so that it will throw an error in installation time
If you see that you cannot upload the profiles please write a warning

Look here for many bugs:
https://github.com/grafana/pyroscope-rs/issues/168
https://github.com/grafana/pyroscope-rs/issues/173
https://github.com/grafana/pyroscope-rs/issues/80
My use case is that the ruby sdk works in 3.1.4 but not in 3.1.5 and i get absolutely no error message. It is the same as https://github.com/grafana/pyroscope-rs/issues/173 If i would have get an error in the installation time i would have considered waiting with the upgrade to 3.1.5 .
...
How did you install pyroscope-rs?
with bundle

pyroscope-rs version and environment

hi @grafana/pyroscope-rs I could take care of restricting pyroscope-rs for the python versions 3.7 to 3.11 and look how to do this in ruby. The question is if PRS are welcome. The repo looks a bit quiet in the last months.

We don't need restrictions for old versions. We need support for new versions.

That's a valid point but there will be always a gap between when a new python version is released and this project supports this new version. The same goes for ruby. From my experience i installed python 3.12 and then got an error while using the sdk forcing me to use ebpf.
In ruby it was even more weird. My colleague upgraded the ruby version from 3.1.4 to 3.1.6 and i got no warning or error message. The profiles just disappeared silently.
So the best would be to get a failure in the installation phase instead of getting the error anyway later
So either :

This project starts to support ruby and python versions while there are still in the rc phase.
They have in the requirements file (either gemfile or setup.py) which python versions they support.
You have a different dependency which supports newer versions of python/ ruby transparently
Of all options i would prefer 3 but i am not sure this is possible, afterwards 1.
I agree the 2 is not great but it is better than the current situation.

WDYT?

I think we don't need restrictions for old versions. We need support for new versions.

That's great. I am waiting for python 3.12 support but in 0.512 it is not supported.
There is nothing which hinders you to install pyroscope-rs on an unsupported version including python 3.12.
And the new release apparently won't support python >= 3.13
Regarding the limitation this is not my invention. Here are two high starred libraries which do the same thing.
https://github.com/robotframework/SeleniumLibrary/blob/master/setup.py#L44
https://github.com/tensorflow/privacy/blob/master/setup.py#L48
Anyway this is your project so if you disagree, then just close the issue. Just bear in mind that the current lack of support for newer python and ruby versions plus the fact that they don't fail in the installation phase cause lots of agony.
Thanks,
David

cause lots of agony
I understand and agree.

@korniltsev may you please share your plans how you are going to achieve support for new versions. This is especially hard in the case of pyroscope as there is no official api of the languages themselve. This is not like go which has pprof as part of its sdk

I don't know for sure

I am not going to work on this in the near future.


Unity 2020 openVR_api crashes with URP

Hi Community,
since we are using URP together with SteamVR (OpenVR_API) Unity crashes at Start!
The Standalone Build also.
Does anybody know anything about that?
It's something with the XR plugin but how to fix it?
Thanks a lot,
Greetings, Matthias

Can you give me exact versions of everything? SteamVR Unity Plugin (SteamVR/readme.txt), Unity editor, if you're using Unity XR, URP package. Also the crash log would be helpful

Hi,
I am probably having the same issue while using:
Unity 2020.1.14f1
SteamVR Plugin v2.6.1
Open VR XR Plugin v1.0.1
Editor.log

Opening Simple Sample scene included in SteamVR plugin didn't end in Unity crash but only failed to initialize SteamVR because of  DllNotFoundException: XRSDKOpenVR
Full stack trace:
Log.txt

I was finally able to fix the issue.
I had to remove OpenVRAutoUpdater folder from within SteamVR folder. Than I reimported OpenVRXrPlugin (like 10 times) and now it finally works.


Field ranges

I think it'd be a boon to usability if we could specify ranges of fields similarly to the shell tool cut.  Especially for something like this:
tsv-select -f 1,2,3,4,5,6,7,8,9,10,12,13,14,15,16,17,$(seq -s, 19 49)

It would be more familiar and more readable to be able to render it like so:
tsv-select -f 1-10,12-17,19-

This becomes especially nice when you have a lot of columns.
And there's the hat trick. ;)

This is actually next on my todo list, for all the reasons you mention

Oh really?  Great!  A thought I had: it may be useful to have something like opDollar (e.g. so we can easily express ideas like "all but the last two of however many columns this is"), but I'm not sure how to make it not-super-ugly in the shell.

Added support for field ranges anywhere a list of fields can be entered. A field range is a pair of field numbers separated by a hyphen: 3-7. Reverse order is supported as well: 7-3. A field list is a sequence of field numbers and ranges. e.g: 1,7-14,30-25,9. Some examples:
tsv-select --fields 1,2,17-33,10-7  data.tsv
tsv-summarize --group-by 3-5 --median 7-17
tsv-uniq --fields 7-10 data.tsv

I decided not to support incomplete ranges like 3-. This is a significant complication when files have different line lengths, and involves changing the inner loop of any tool supporting it. (Even ignoring variable length rows it would have involved significantly more work.) Note that this is not an issue for Unix cut, as it does not support re-ordering fields. It can always print to the end of the line when an incomplete range is involved.


Please add strong name to nuget

We use your assembly in UnitTest projects. Our tested projects have a strong name.

@kvvinokurov thank you for your contribution. sorry for delay in merging, I was out for few days.


persist MovieSort in AppStorage

Closes #44
Closes #31
I haven't really tested this, I think it will likely work, since its the same as what we did for instances

got rid of some boilerplate

converted to draft, needs work

Wow that RawRepresentable was a pain, I can understand why you left the task to me 😀 I have an uncofirmed theory that apple recently broke the way we were adding rawrepresentables to AppStorage by optimizing Codable internally. the default encode(to:) implementation of something that is rawRepresentable with a String RawValue will just call rawValue on itself instead of encoding itself normally. I was able to fix this by explicitly implementing encode(to:) for Movie Sort.
I also abandoned the generic solution I briefly had. Now I feel it could work again, but we would be at risk of runtime crashes if we forgot to implement encode(to:) for some type. So doing everything manually seems like the way to go.

Note that #31 was added to this PR.

@tillkruss this is ready. It was a huge pain but manual Codable conformance solves this. We should be mindful of this, since there's potential for runtime crashes if we don't implement it manually. Then again, we'll probably find such crashes in testing early (they should be deterministic)


Net error

This may be a duplicate of #2282
[wire-master] Trying to send an overflowed net message!
1. FlushQueue - addons/wire-master/lua/wire/wireshared.lua:609
 2. func - addons/wire-master/lua/wire/wireshared.lua:626
  3. internal_call - lua/includes/modules/hook.lua:409
   4. unknown - lua/includes/modules/hook.lua:428

The queue seriously doesn't have any protection against overflow.
https://github.com/wiremod/wire/tree/master/lua/wire/wireshared.lua#L604


Fixing Tables failing live tests

This fixes the failing live tests for Tables.
Live tests previously failed from credential being null.

/azp run java - tables - tests

API change check
API changes are not detected in this pull request.


doc: Modernize steps to be followed after release

Remove old references to sourceforge, add what actually should be done and provide some more details.

Better?

:)


Is something else needed for absolute imports to wrok?

First off thanks for this repo! It's been an incredible resource so far. I'm building a project based on its guidelines at the moment and I'm having an issue setting up the absolute imports as you described in the absolute imports section. When I run the project I get the following below error in the terminal, as well as for any other file that imports something using the @/something syntax. VS code correctly suggests imports using the syntax after updating the tsconfig.json and adding tsconfig.paths.json but I just want to make sure there wasn't any other config that I needed to add to get it working.
The error
ERROR in ./src/features/auth/components/SignInPage.tsx 10:0-41
Module not found: Error: Can't resolve '@/components/Button' in '/Users/nathan/projects/react/merchant-portal/src/features/auth/components'

In SignInPage.tsx I've imported the Button component using
import Button from '@/components/Button';

and the Button component is the default export from the file found at ./src/components/Button.tsx.
tsconfig.paths.json
{
  "compilerOptions": {
    "baseUrl": ".",
    "paths": {
      "@/*": ["./src/*"]
    }
  }
}

tsconfig.json
{
  "compilerOptions": {
    "target": "es5",
    "lib": ["dom", "dom.iterable", "esnext"],
    "allowJs": true,
    "skipLibCheck": true,
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "strict": true,
    "forceConsistentCasingInFileNames": true,
    "noFallthroughCasesInSwitch": true,
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "isolatedModules": true,
    "noEmit": true,
    "jsx": "react-jsx"
  },
  "include": ["src"],
  "exclude": ["node_modules"],
  "extends": "./tsconfig.paths.json"
}

Hey there,
You have to configure webpack alias in craco config if you haven't already:
https://github.com/alan2207/bulletproof-react/blob/8d4c3fb7a5bdb61e4557c2d3ea6eb7d6aaa817a1/craco.config.js#L4

And if I'm not using craco, but the regular react-scripts? I'm using tailwind 3 and create-react-app v 5+

You will need craco in order to override webpack configuration. I found this repository that includes both tailwind 3 and CRA v5 with alias configuration. It appears you do not need tsconfig.paths.json for CRA v5, you can define paths directly in tsconfig.json.

Alright thanks !


[GPII-4003]: Fix :test task to properly destroy locust resources

Existing implementation of :test task was a little backwards, destroying locust resources before instead of after the test, which caused various CI issues in case module and TF state was not destroyed separately.

What about fixing the issue with rotating encryption keys (and not updating the locust state)?

Does this change mean we will leave locust lying around until the next run?

@mrtyler Nope, all locust resources get destroyed after the test.

Does this mean that if a run fails in some unexpected way, the next run will be impacted because we don't clean up locust before starting?

This implementation catches locust exit status, cleans up everything and then exits with locust exit status if it is non-zero.

What about fixing the issue with rotating encryption keys (and not updating the locust state)?

@stepanstipl Locust module and its state gets destroyed after the test, so there is nothing to rotate.

@stepanstipl Locust module and its state gets destroyed after the test, so there is nothing to rotate.

Thanks @natarajaya, I'm just thinking that instead of relying on the absence of a state, it might be better to fix the underlying issue with rotating encryption keys. It seemed to me that it might be as simple as adding rake rotate_tfstate_key['locust'], or changing the default behaviour of the command to rotate both k8s and locust states, but I agree that if it's complicated fix it's not worth it since we plan to move away from current encryption solution.
Otherwise lgtm.


Do you store imported file real name?

When we upload files with the same name, Label studio add some random text at the end of the file name.
Is there a way from which I can get the file's original name?

As far as I remember LS addes postfix to your original filename, e.g.: you imported src.png => src_ZoqW18z.png, so, you can split your filename with _ and get your original filename:
ls_filename = 'src_ZoqW18z.png'
original_filename = '_'.join(ls_filename.split('_')[:-1]) + '.png'

Yes, but if the original filename is  'src_ZoqW18z.png', I split the file name with '_' will give me 'src.png' the wrong name.

I think the target name will be src_ZoqW18z_anotherHash.png. So, my linea should work ok

Suppose I imported 3 images: 'abc_def.png', 'ijk.png', 'ijk.png'.
Label studio will store them as 'abc_def.png', 'ijk.png', 'ijk_someHash.png'
then how will I get original names of images.

https://github.com/heartexlabs/label-studio/pull/1426
Sorry for late answer, but hope this helps.