ui_update: Use same @ symbol everywhere.

This PR updates the @ icon across various locations in the app to ensure consistency.
Icon used :
<i class="zulip-icon zulip-icon-at-sign" aria-hidden="true"></i>.

Tasks completed:

[ ] Replace @ character in mention pills
[x] Update @ in /#settings/notifications
[x] Update "Copy mention syntax" icon in user popovers
[x] Standardize unread mentions indicator icon in the left sidebar
[x] Update @ indicator for the topics in conversation view.

Note

The @ before "Mention" in the sidebar did not require any changes. It already has the required updates.
The @ character for mention pills needs some extra work and can be fixed in a separate PR.

Screenshots

Before
After

 /#settings/notifications

 Copy Mention Syntax

 Left Sidebar @ Indicator

 @ indicator for topics in conversation view

Partially Fixes : #22816 .

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Hey @alya , the PR is ready for review. Can you take a look?

hey @alya , the PR is ready for a review. Can you take a look?

Hey @karlstolley , I have made some changes. Could you please take a look?
Please tell if I am mistaken somewhere.
Thanks!

Hey @karlstolley , I have made some changes. Could you please take a look?
Please tell if I am mistaken somewhere.
Thanks!

Hey @karlstolley , I have made some changes in the code and addressed your review comments. Could you please take a look?

Hey @karlstolley , I have removed the font-size for the @ symbol before "all". Could you please take a look?

Hey @karlstolley, could you please take a look ?

I don't know what you expect me to review. I keep getting notifications from you to review this PR, and you still have not addressed my feedback by fixing your code. There is no way we're merging a bunch of positioning stuff here or overly generic CSS selectors.

Hey @karlstolley , sorry for the delay. I have updated the code as per your reviews and suggestions. This time I haven't used any kind of positioning and offsets.
Could you please take a look?

Everything looks good except for the alignment of the @ icon in the topics sidebar. I am unable to figure out how to fix it. Could you suggest a way to resolve this?

Hey @karlstolley, could you please review the PR again? This time, I have made sure to address and adhere to all of your comments. I have used divs instead of offsets and positioning to position the icon.

@karlstolley , the PR is ready for the next review.

Hey @karlstolley , could you please take a look?

Have you updated your screenshots up at the top of the PR since your latest rounds of changes, @whilstsomebody? That'll make this much easier to finish reviewing.

@karlstolley , updated the screenshots in the description. Please take a look.

Hi @karlstolley, it has been a while since the PR has not been reviewed. Could you please review it?
Thanks!


Create 5.2.1 Release Notes

This includes adding links to the new release notes from the other release notes pages and index.html.

Done in #732


zeus crash on start in ruby 2.5.0

[ready] [crashed] [running] [connecting] [waiting]
boot
└── default_bundle
    ├── development_environment
    │   └── prerake
    └── test_environment
        └── test_helper

Available Commands: [waiting] [crashed] [ready]
zeus console (alias: c)
zeus server (alias: s)
zeus generate (alias: g)
zeus destroy (alias: d)
zeus dbconsole
zeus rake
zeus runner (alias: r)
zeus test (alias: rspec, testrb)
exit status 1```

Zeus crash on start in ruby 2.5.0.

gem update --system worked for me

Running the following in the terminal worked for me:
export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES


1.4.2 Vortex Deployment Issue Still There

Keep getting the following on v.0.1.0-rc9
error: failed to install symlink err=EINVAL: invalid argument, symlink '<path>\AppData\Roaming\Vortex\mountandblade2bannerlord\mods\Community Patch - e1.4.2 and up-186-v0-1-0-rc9-1592274894\Modules\CommunityPatch\src\CommunityPatch\.idea\.idea.CommunityPatch\.idea\runConfigurations\GeneratePatchTargetHashes__No_Build_.xml' -> '<path>\steamapps\common\Mount & Blade II Bannerlord\Modules\CommunityPatch\src\CommunityPatch\.idea\.idea.CommunityPatch\.idea\runConfigurations\GeneratePatchTargetHashes__No_Build_.xml'
Troubleshooting Steps:

Disable all mods and try to install again. (Same issue)
Manually copy he problem file to destination. (Deploy still fails, mod not seen as active by Vortex)
Manual install of Vortex version. (Same issue).

When I can, I'll download an IDE and see if I can build it from GH, but thought I'd post this just in case it's an easy fix.

My guess is that the path is too long for Windows to handle.
This works:
Get-Item 'C:\Users\xxxxxxxxxx\AppData\Roaming\Vortex\mountandblade2bannerlord\mods\Community Patch - e1.4.2 and up-186-v0-1-0-rc9-1592274894\Modules\CommunityPatch\src\CommunityPatch\.idea\.idea.CommunityPatch\.idea\runConfigurations\GeneratePatchTargetHashes.xml'
This fails:
`'C:\Users\xxxxxxxxxx\AppData\Roaming\Vortex\mountandblade2bannerlord\mods\Community Patch - e1.4.2 and up-186-v0-1-0-rc9-1592274894\Modules\CommunityPatch\src\CommunityPatch.idea.idea.CommunityPatch.idea\runConfigurations\GeneratePatchTargetHashes__No_Build_.xml'

Windows hard limit is 260, so that is a good suspect.

Great idea. I can confirm that I can create that failing Symlink using the long-path designator using a PowerShell command.


unknown annotation kind 'notation_info' from lean.js (emscripten build)

Dear @leodemoura,
I was updating Lean.js and found this problem. An minimal example is the following line:
import data.set

and it generates the message "unknown annotation kind 'notation_info'". Do you have any clue where it comes from? I tried to reproduce the problem without using emscripten (i.e. DMULTI_THREAD=OFF) but couldn't find a way.
BTW, I had another problem building the latest version of it and had to make a patch: https://github.com/soonhokong/lean/commit/a25b43f1e80fecaf8d00f08e75926d6fc13de0d0

@leodemoura This broke the version of Lean used for my course (students have an assignment due tomorrow), but for now @soonhokong  reverted to the previous version (avoiding an emergency).

Just to provide more information, 4 Sep 2015 version of lean.js is running now.

Have you recompiled the standard library?
This is the kind of error we get when we try to load an old version of the library using a new version.
Thanks,
Leo

Maybe just a "make clean-olean"?

No, this is a fresh VM and I made sure that it's using the up-to-date library.
I'm experiencing something very strange.

I have an example file test.lean whose contents is a single line import standard. When I run lean.js over it, I have the following errors:

import_module:1:0: error: unknown annotation kind 'notation_info'
./test.lean:1:0: error: unknown annotation kind 'notation_info'
```

Then, I added debug-prints at register_annotation and mk_annotation functions in library/annotation.cpp to see what's going on.

void register_annotation(name const & n) {
std::cerr << "register_annotation: " << n << std::endl;
...
expr mk_annotation(name const & kind, expr const & e, tag g) {
std::cerr << "mk_annotation: " << kind << std::endl;
```
Strangely, the problem goes away after adding these two lines. Now, it generates the following trace:
```

register_annotation: have
register_annotation: show
register_annotation: @
register_annotation: as_atomic
register_annotation: as_is
register_annotation: !
register_annotation: by
register_annotation: by+
register_annotation: innaccessible
register_annotation: no_info
register_annotation: extra_info
register_annotation: notation_info
mk_annotation: no_info
register_annotation: calc
register_annotation: begin-end
register_annotation: begin-end-element
mk_annotation: have
mk_annotation: have
...
```
without any unknown annotation kind error.

This is super weird. Are you using a new version of emscripten?

Yes, I'm using 1.35.4 which is pretty new. I also think that this is a compiler issue (emscripten), let me try an older version.

Did you try to remove the two lines and try again?

Did you try to remove the two lines and try again?

Sure :-), and then I have unknown annotation kind  again.

BTW, I simply followed the standard installation procedure. emsdk install latest && emsdk activate latest. It installed this version 1.35.4...

I will try to build it tomorrow using the desktop in my office.
I tried with my home machine, but the VM is freezing :-(

I'll test another version of Emscripten as well. Unfortunately, building a version of Emscripten takes 1 - 2 hours.. I'll keep you posted.

Hmm.. it seems that the problem is related to the Emscripten optimization flags. Removing -Oz solves the problem (at least for the simple import standard). But it increase the size of lean.js from 14MB to 70MB, which is very bad.. I'll try different options.
Reference: https://kripken.github.io/emscripten-site/docs/tools_reference/emcc.html#arguments

It seems that emscripten-1.30.6 is generating a correct lean.js code. It passes many tests so far. Once I finish the testing, I'll update one at https://leanprover.github.io/lean.js/lean.js and close this issue.

@avigad, I just updated https://leanprover.github.io/lean.js/lean.js file which are used by the tutorial and logic_and_proof.
There are some test failures with logic_and_proof. But it's reproducible with the native Lean, so I assume that it's not a problem of lean.js.
FYI, here are a couple of them:
Chapter 6
import standard
import data.nat
open nat

-- BEGIN
example : ∀ n m : ℕ, m ∣ n → n ∣ m → n = m
take m n,
assume `n ∣ m` `m ∣ n`,
obtain k `m = n * k`, from `n ∣ m`,
obtain l `n = m * l`, from `m ∣ n`,
or.elim (eq_zero_or_pos n)
(assume `n = 0`,
show m = n, from calc
m = n * k : `m = n * k`
... = 0 * k : {`n = 0`}
... = 0     : zero_mul
... = n     : `n = 0`)
(assume `n > 0`,
have n * 1 = n * (k * l), from calc
n * 1 = n         : mul_one
... = m * l       : `n = m * l`
... = (n * k) * l : {`m = n * k`}
... = n * (k * l) : mul.assoc,
have 1 = k * l,
from eq_of_mul_eq_mul_left `n > 0` `n * 1 = n * (k * l)`,
have k = 1,
from eq_one_of_mul_eq_one_right (eq.symm `1 = k * l`),
show m = n, from calc
m = n * k : `m = n * k`
... = n * 1 : {`k = 1`}
... = n     : mul_one)
-- END

Error
06_Existential_Quantifier.org.6.lean:6:27: error: function expected at
  ∀ (a : m ∣ n) (a_1 : n ∣ m),
    n = m

Chapter 8
import standard
variables {X Y Z : Type}

definition compose (f : Y → Z) (g : X → Y) : X → Z :=
λ x, f (g x)

infixr  ` ∘ ` := compose

definition id (x : X) : X :=
x

-- BEGIN
lemma left_id (f : X → Y) : id ∘ f = f := rfl

lemma right_id (f : X → Y) : f ∘ id = f := rfl

theorem compose.assoc (f : Z → W) (g : Y → Z) (h : X → Y) : (f ∘ g) ∘ h = f ∘ (g ∘ h) := rfl

theorem compose.left_id (f : X → Y) : id ∘ f = f := rfl

theorem compose.right_id (f : X → Y) : f ∘ id = f := rfl
-- END

Error
ERROR executing 08_Functions.org.3.lean, for in_code_block block starting at 705, produced output:
FLYCHECK_BEGIN ERROR
08_Functions.org.3.lean:17:31: error: unknown identifier 'W'
FLYCHECK_END

@soonhokong Thanks for catching these errors; they are fixed now. Thanks even more for getting the online version of Lean working again.


Fix handling of helpers with 5 parameters on Windows

Changes:

Permit passing additional metadata about the extension/helper function.
Interpreter - Correctly invoke helper function by type (fix case where function accepts 5th parameter).
Interpreter - Honor "unwind-on-success" flag.
Jitter - Windows x64 - Spill 5th parameter to stack.
Jitter - Windows x64 - Allocate stack space for home registers.
Jitter - Honor "unwind-on-success" flag

Signed-off-by: Alan Jowett<EMAIL_ADDRESS>

Note:
Draft until I can complete testing on Windows x64.

Spilling R5 to the stack has no negative effects on Windows x64, so to simplify, always spill R5 to the stack.

Rebased on to correct master branch.

Can you please rebase this on the latest master? The first 4 commits of this PR have already been merged, so only the last one is really new.
Also, can you make the commit message more descriptive and explain why this is change is being done? The reasoning given on the linked issue makes sense, but it is very useful and convenient to have all of that information in the commit message, without having to jump through links and reading PR messages


Tokens leak?

Issue
While checking the token consumption of the application I am writing (because it uses the LLM model), I noticed something strange. Over 11,000 tokens for a small change assigned to Aider. So I called /tokens and it showed 1792 tokens. As a test, I told Aider to make a simple change. And Aider sent 11301 tokens?

Version and model info
Aider v0.43.5-dev
Models: openrouter/anthropic/claude-3.5-sonnet with diff edit format, weak model openrouter/anthropic/claude-3-haiku
Git repo: .git with 46 files
Repo-map: using 2028 tokens
Added .aider.memory.md to the chat.

Thanks for trying aider and filing this issue. It looks like you have identified a bug. The /tokens command is not showing the tokens used by the repo-map. I'll get this fixed.

The --map-tokens is a guideline, not a hard limit.
Sorry, I am unable to reproduce this. Are you able to make this happen again? If so, can you share the announce lines that aider prints on launch as well as the /tokens output from that same session?
Are you sure that the screenshot you shared of /tokens is from the same session as usage lines you highlighted in the openrouter screenshot?
Because the openrouter usage lines look like they were from a session where you used aider without adding any files to the chat and while operating inside a git repo. And the /tokens screenshot looks like you have added a file and are running aider without an active repomap because maybe you are not inside a git repo.

Are you sure that the screenshot you shared of /tokens is from the same session as usage lines you highlighted in the openrouter screenshot?

yes

Because the openrouter usage lines look like they were from a session where you used aider without adding any files to the chat and while operating inside a git repo.

It seems that I have still this session open.
so let's delve into it
aider start and first task
after I saw how many tokens it used, I called /tokens

so I repeated with another small change

/ls from this session

I did another test now. In the same session.
on the beginning /tokens and you see repo-map
than remove a file
adding the same file from this ticket
small change
there is no repo
and high token usage despite small file

when I drop this file, it is on the list printed by /ls

I closed the session, updated to the latest version of Aider.
Aider v0.45.1
Models: openrouter/anthropic/claude-3.5-sonnet with diff edit format, weak model openrouter/openai/gpt-4o-mini
Git repo: .git with 46 files
Repo-map: using 2028 tokens
Added .aider.memory.md to the chat.
There is still no repo-map for this file.

I've also ran into a similar issue. I can clear chat history and start a new session, and the first prompt immediately says it's using a million tokens. From my .aider.chat.history.md:
#### Example_File.ipynb for how coding could be improved. For example, could the plotting function be summarized and called instead of writing the full code each time?

To improve the coding in `Example_File.ipynb`, we can focus on refactoring the plotting function to avoid repeating the full code each time. The most likely file that needs to be edited is:

- `Research\Example_File.ipynb`

Please add `Research\Example_File.ipynb` to the chat so I can propose specific changes.

>
>
> Model deepseek/deepseek-coder has hit a token limit!
> Token counts below are approximate.
>
> Input tokens: ~1,204,876 of 128,000 -- possibly exhausted context window!
> Output tokens: ~0 of 4,096
> Total tokens: ~1,204,876 of 128,000 -- possibly exhausted context window!

I also notice that neither .aider.chat.history.md nor .aider.input.history are actually empty files after I cleared chat history in the browser button. .aider.chat.history.md is quite big, 76 Kb. Could this be relevant to the issue? Is it trying to send the entire .aider.chat.history.md in the prompt?

@mr-september you should run /tokens to see what's using that 1M tokens. Did you add those .aider... files to your repo and to the chat?

@ErykCh any chance you can share that specific file with me? Wondering if it is somehow causing the repo map to crash in the tokens display.

@paul-gauthier How/where do I run /tokens? I am currently running with python -m aider.main --model deepseek/deepseek-coder --browser , through Windows/VS Code. The terminal in VS code is not available for manual inputs, while running /tokens in the chat just seems to ask the LLM a question.
I think those .aider... files were prompted after installing aider-chat, maybe on the first time I tried to run it.

This is expected when you are running with no added files. Aider uses a larger repo map, so that the LLM can thoroughly understand your code base. Since you haven't added any files, the LLM is encouraged to suggest which files need to be edited based on your chat requests. To make good suggestions, it helps to have a larger repo map.

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


[setup.py] Update setup.py

Description

Checklist
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented
[ ] To the best of my knowledge, examples are either not affected by this change,
or have been fixed to be compatible with this change
[ ] Related issue is referred in this PR

Changes

How can I compile or setup with CUDA? Is there any command or any changes by myself?


leaflet-measure not working with Leaflet 1.0 beta 2

Tried out this plug-in with Leaflet 1.0.0-beta.2 (99a48a5), but one only gets a dot, it does not create polylines or polygons nor does it report lat/lon.
This might be related to:
https://github.com/Leaflet/Leaflet.draw/issues/455
https://github.com/Leaflet/Leaflet/issues/4018
Windows 7 OS, Chrome Version 46.0.2490.86 m

I'm also using leaflet 1.0 beta 2. Leaflet measure plugin works as expected
in chrome on my android tablet and my iPhone 4 (don't laugh), but not in
any browser on any desktop OS I've tried.
On Saturday, 21 November 2015, Dr. YSG<EMAIL_ADDRESS>wrote:

Tried out this plug-in with Leaflet 1.0.0-beta.2 (99a48a5), but one only
gets a dot, it does not create polylines or polygons nor does it report
lat/lon.
This might be related to:
Leaflet/Leaflet.draw#455
https://github.com/Leaflet/Leaflet.draw/issues/455
Leaflet/Leaflet#4018 https://github.com/Leaflet/Leaflet/issues/4018
—
Reply to this email directly or view it on GitHub
https://github.com/ljagis/leaflet-measure/issues/15.

Fixed at commit 5f0ead9
The original implementation added a polygon overlay covering the full map to receive clicks and add measure points. This keeps getting in the way, including this issue. Removed completely. Now, new points are added to the measurement with clicks handled on the map directly.

Also.. A new example page using Leaflet 1.0.0 Beta 2 was added


enable-cd changes

This PR is created with reference to enabling CD for the simplify-qa-connector-plugin.
Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Committed all suggested changes

Committed all suggested changes

And change <version> field to <version>${changelist}</version>

Why are you confident that all suggested changes have been applied when this has been left out?

Committed all suggested changes

And change <version> field to <version>${changelist}</version>

Why are you confident that all suggested changes have been applied when this has been left out?

Applied these changes now, in the latest commit.


TensorRT Plugin

I've see your https://github.com/NVIDIA/TensorRT/pull/3859
Is it possible to have on trt10?
I'm working on jetson agx Orin and now is compatible with cuda 12.5, cudnn 9.1.1 and tensorrt <IP_ADDRESS>.
Also, is it compatible with yolov8?

Yes, it can be easily implemented on TRT 10 and for any version of YOLO since v4.
I will try to find some free time and implement it on 8.5 and 10.0

Yes, it can be easily implemented on TRT 10 and for any version of YOLO since v4, because it's same implementation as End2End Efficient NMS but add a new layer det_indices.
I will try to find some free time and implement it on 8.5 and 10.0

https://github.com/NVIDIA/TensorRT/pull/3859#issuecomment-2125899520

@johnnynunez   Check this out.
https://github.com/levipereira/ultralytics -- Added Support for TRT Plugin YoloNMS on Yolov8 for Instance Segmentation and Object Detection
I have tested/validated on deepstream with yolov8n --  https://github.com/levipereira/deepstream-yolov9
from ultralytics import YOLO
# model = YOLO("yolov8n-seg.pt")
model = YOLO("yolov8n.pt")
model.export(format="onnx_trt")

awesome! but maybe still I have to do the predict compatible.
These guys did it: https://github.com/nkb-tech/ultralytics

@johnnynunez Check this out. https://github.com/levipereira/ultralytics -- Added Support for TRT Plugin YoloNMS on Yolov8 for Instance Segmentation and Object Detection
I have tested/validated on deepstream with yolov8n -- https://github.com/levipereira/deepstream-yolov9
from ultralytics import YOLO
# model = YOLO("yolov8n-seg.pt")
model = YOLO("yolov8n.pt")
model.export(format="onnx_trt")

@levipereira also can you create a PR to ultralytics?

@johnnynunez

@johnnynunez
With Triton Server and Triton Client, we can easily perform inference and evaluation on any YOLO Series model. Check out the evaluation results of YOLOv8 models using YOLO_NMS_TRT at the link below:
YOLOv8 Evaluation Results
Implementing inference using the TensorRT API and Custom Plugin within the Ultralytics project involves a significant amount of work. I may consider implementing it in the future.
Using Triton Server, we can build and test any model without additional effort.
For more information, visit:

Triton Client for YOLO
Triton Server for YOLO

@levipereira also can you create a PR to ultralytics?

Will implement end2end  with EfficientNMS and YOLO_NMS_TRT  and open a PR.

@levipereira do you have lower mAP with efficient_nms in COCO eval?

@levipereira do you have lower mAP with efficient_nms in COCO eval?

No, I did not get a lower mAP. The results were consistent with the baseline evaluation.

@johnnynunez  https://github.com/levipereira/triton-server-yolo?tab=readme-ov-file#evaluation-test-on-tensorrt


AutoPr-ComputerVision-toothache-REST Spec PrNumber 5721

The latest change in Ocr swagger removes mode parameter from BatchReadFile operation, and thus is a breaking change. We need to modify corresponding tests file.

I fixed broken tests via 303e86d. Should I create a manual PR for this change?


I tried your notebook and got an error

I tried your notebook and got the following error:

Charles

Ah, not sure why that error shows up. Can you try running the notebooks again to see if it works? I just tried and it worked for me https://mybinder.org/v2/gh/microsoft/dowhy/master?filepath=docs%2Fsource%2F

I tried your link and selected several notebooks.  This time it worked.  Must have been a gremlin!
From: Amit Sharma<EMAIL_ADDRESS>Sent: Wednesday, March 4, 2020 8:56 AM
To: microsoft/dowhy<EMAIL_ADDRESS>Cc: Charles Brauer<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/dowhy] I tried your notebook and got an error (#116)
Ah, not sure why that error shows up. Can you try running the notebooks again to see if it works? I just tried and it worked for me https://mybinder.org/v2/gh/microsoft/dowhy/master?filepath=docs%2Fsource%2F
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/microsoft/dowhy/issues/116?email_source=notifications&email_token=AAKBS4X5VVHR7OI7EKPEAXTRF2B3ZA5CNFSM4LBMAURKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENY4NTQ#issuecomment-594659022 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKBS4T6QWZLU2MWHQSGJFLRF2B3ZANCNFSM4LBMAURA .  https://github.com/notifications/beacon/AAKBS4V2VOGIFGFDXPZIGJTRF2B3ZA5CNFSM4LBMAURKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENY4NTQ.gif


Add explosion-bot workflow

This PR adds the explosion-bot workflow for spacy-llm so that we can run some CI via an issue comment. One ideal use for this is to have explosion-bot run a BuildKite pipeline for external tests, something like:
@explosion-bot please test_external

In order to run external tests (i.e., tests that interact with a third-party API) in Pull Requests (so that we can double-check if external tests pass in any machine).
TODOs:

[x] Create buildkite pipeline for test_external (it must follow the external tests set-up, i.e., pytest spacy_llm/tests --external)
[ ] Add EXPLOSIONBOT_TOKEN and BUILDKITE_SECRET to spacy-llm's Github actions

Types of change

Chore, CI
Checklist

[x] I confirm that I have the right to submit this contribution under the project's MIT license.
[ ] I ran all tests in tests and usage_examples/tests, and all new and existing tests passed. This includes

all external tests (i. e. pytest ran with --external)
all tests requiring a GPU

[x] My changes don't require a change to the documentation, or if they do, I've added all required information.

Should be ready for review! Shall we test and check? cc: @rmitsch

Looks decent to me, but I don't have experience with the ExplosionBot setup. I added a secret for EXPLOSIONBOT_TOKEN (BUILDKITE_SECRET was already in the repo).
How do you propose to test this?

Oh I just saw this! Locally, there's a way to test this in the explosion-bot repo readme (don't want to link internal repo in the public forum). I think I might need help doing this because I don't have access to the tokens. :/


Can customShellRenderer make the shell immsersive?

there is a bug in xamarin.forms shell that the android can not be immersive.
if write a customshellrenderer can do it?
make the android immersive?

i have no clue..
but as this is not related to this repo, ill close this issue


Undefined function: 'ST_GeomFromWKT'

Hi,
We are getting an error..
Undefined function: 'ST_GeomFromWKT' This function is neither a registered temporary function nor a permanent function registered in the database 'default'
We have imported all the packages (import org.apache.spark.sql.geosparksql.expressions
import org.datasyslab.geosparksql.UDF)  yet we are getting the same error .
The following is our scala code for creating a polygon dataframe from a wkt file stored in hdfs
`var sparkSession = SparkSession.builder()
.appName("readTestScala") // Change this to a proper name
.config("spark.serializer", classOf[KryoSerializer].getName)
.config("spark.kryo.registrator", classOf[GeoSparkKryoRegistrator].getName)
.getOrCreate()
GeoSparkSQLRegistrator.registerAll(sparkSession.sqlContext)
var polydf = sparkSession.read.format("csv").option("delimiter", ",").option("header", "true").load("hdfs:///gis/COE6418/mumbaibldgwkt.csv")
polydf.createOrReplaceTempView("polydf")
var polygonDf = sparkSession.sql(
"""
|SELECT ST_GeomFromWKT(polydf.SHAPE) AS shape
|FROM polydf
""".stripMargin)
polygonDf.createOrReplaceTempView("polygons")`
we are able to create a datframe, but when we try to use ST_GeomFromWKT or any other functions we are getting the same error as above. (in .printSchema() and .show() methods)
We also tried to register the udf's manually by
FunctionRegistry.builtin.registerFunction("ST_GeomFromWKT", ST_GeomFromWKT) but we get No Value found ST_GeomFromWKT
Kindly request you to help us
Settings
GeoSpark version = ?
1.1
Apache Spark version = ?
2.1
JRE version = 1.8?
1.8.0_151
API type = Scala or Java?
Scala

@SrinivasRIL Can you try GeoSparkSQL template project? https://github.com/jiayuasu/GeoSparkTemplateProject
I just tested the sql template project with Spark version 2.1.2. It works fine.

Hi, How do you solve this problem?


Sanitizing nested list from tiptap JS leads to superfluous paragraph

When creating a nested list inside tiptap JS, you get the following example HTML:

test

test

When you sanitize this input with tiptap-php, an extra p-tag is added. This leads to a broken layout when saving the resulting HTML and loading it back into tiptap JS:
use Tiptap\Editor;
use Tiptap\Extensions\StarterKit;

$editor = new Editor(['extensions' => [new StarterKit]]);
echo $editor->sanitize('

test

test

');
// result =

test

test

Can we make sure that output remains identical when it is considered safe?

I'm closing this since the issue seems to lie within the JS component here. It creating nested p-tags inside the li-tag causes this issue. This library just uses PHP's DOMDocument to perform the parsing, which seems to be correct.


New package: BitSAD v0.1.1

Registering package: BitSAD
Repository: https://github.com/UW-PHARM/BitSAD.jl
Created by: @darsnack
Version: v0.1.1
Commit: d2d4c1fa5f5a4532383465e1b32c93ac3f4bd444
Git reference: master

Block


monopolar mitotic  spindle /synonym

lethal mutations lead cells into mitotic arrest with characteristic V-shaped monopolar spindles at the restric- tive temperature (Hagan and Yanagida, 1990, 1992).
add "V-shaped spindle"
as a related synonym (I think a later phenotype , bent spindle can also look V-shaped?)

done
edit file: 93104261e59ada1a9ca056bfb1465ae158adaad7
release: 01b274219f5c6c1f7bf21ded74d8089f1094439d

is this in definitely. I searched on "V-shaped" and it didn't show...

Yes, it's been in for a week, and does show up in the Canto autocomplete for me. If it's not showing up in the website search, that's one for Kim.


output-layout: don't expose outputs without a mode

Fixes #1242

What does this do for e.g. the wayland backend?

Thanks!


Fixing build stalls on OSX by using latest XCode

The sort order of the packages, modules and scripts must be stable across OSes

Coverage increased (+0.07%) to 81.972% when pulling 5dfac506e5e0a54092de1654625e06792f3fd99b on arcivanov:osx_image_stall_fix into 0c63d5234478fb34ae7a345ae9726ae0ca7ae4a8 on pybuilder:master.


[FLINK-31860] Ignore Event creation errors during cleanup

What is the purpose of the change
The current logic tries to create Kubernetes events even during cleanup steps, failing to create them leads to a retry loop and a stuck delete operation on the CR.
However in many cases it's not possible to create events at this stage such as when a namepsace deletion triggered the CR deletion. Currently this means that namespace deletion will be blocked by the stuck cleanup/delete operation.
This PR addresses this by allowing us to ignore event creation errors during the cleanup phase.
Brief change log

Use FlinkResourceContext in the event recorder
Add flag to resource context to allow ignoring errors
Add tests

Verifying this change
New tests added for the FlinkDeployment and FlinkSessionJob controllers
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changes to the CustomResourceDescriptors: no
Core observer or reconciler logic that is regularly executed: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

I still need to test this on minikube and make sure that ignoring event errors is enough during namespace deletion or whether we also need to handle status updates the same way

Unfortunately this still doesn't address the original issue. Even if we ignore all errors (event creation and others we still get the following JOSDK error)
[ERROR][flink/basic-example] Error during event processing ExecutionScope{ resource id: ResourceID{name='basic-example', namespace='flink'}, version: 1791281} failed.
io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: PUT at: https://<IP_ADDRESS>:443/apis/flink.apache.org/v1beta1/namespaces/flink/flinkdeployments/basic-example. Message: Forbidden!Configured service account doesn't have access. Service account may have been revoked. flinkdeployments.flink.apache.org "basic-example" is forbidden: User "system:serviceaccount:default:flink-operator" cannot update resource "flinkdeployments" in API group "flink.apache.org" in the namespace "flink".
    at io.fabric8.kubernetes.client.KubernetesClientException.copyAsCause(KubernetesClientException.java:238)
    at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.waitForResult(OperationSupport.java:546)
    at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.handleResponse(OperationSupport.java:566)
    at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.handleUpdate(OperationSupport.java:369)
    at io.fabric8.kubernetes.client.dsl.internal.BaseOperation.handleUpdate(BaseOperation.java:712)
    at io.fabric8.kubernetes.client.dsl.internal.HasMetadataOperation.lambda$replace$0(HasMetadataOperation.java:172)
    at io.fabric8.kubernetes.client.dsl.internal.HasMetadataOperation.replace(HasMetadataOperation.java:177)
    at io.fabric8.kubernetes.client.dsl.internal.HasMetadataOperation.replace(HasMetadataOperation.java:88)
    at io.fabric8.kubernetes.client.dsl.internal.HasMetadataOperation.replace(HasMetadataOperation.java:39)
    at io.javaoperatorsdk.operator.processing.event.ReconciliationDispatcher$CustomResourceFacade.updateResource(ReconciliationDispatcher.java:387)
    at io.javaoperatorsdk.operator.processing.event.ReconciliationDispatcher.conflictRetryingUpdate(ReconciliationDispatcher.java:343)
    at io.javaoperatorsdk.operator.processing.event.ReconciliationDispatcher.handleCleanup(ReconciliationDispatcher.java:297)
    at io.javaoperatorsdk.operator.processing.event.ReconciliationDispatcher.handleDispatch(ReconciliationDispatcher.java:87)
    at io.javaoperatorsdk.operator.processing.event.ReconciliationDispatcher.handleExecution(ReconciliationDispatcher.java:62)
    at io.javaoperatorsdk.operator.processing.event.EventProcessor$ReconcilerExecutor.run(EventProcessor.java:414)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.base/java.lang.Thread.run(Unknown Source)
Caused by: io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: PUT at: https://<IP_ADDRESS>:443/apis/flink.apache.org/v1beta1/namespaces/flink/flinkdeployments/basic-example. Message: Forbidden!Configured service account doesn't have access. Service account may have been revoked. flinkdeployments.flink.apache.org "basic-example" is forbidden: User "system:serviceaccount:default:flink-operator" cannot update resource "flinkdeployments" in API group "flink.apache.org" in the namespace "flink".
    at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.requestFailure(OperationSupport.java:701)
    at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.requestFailure(OperationSupport.java:681)
    at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.assertResponseCode(OperationSupport.java:628)
    at io.fabric8.kubernetes.client.dsl.internal.OperationSupport.lambda$handleResponse$0(OperationSupport.java:591)
    at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(Unknown Source)
    at java.base/java.util.concurrent.CompletableFuture.postComplete(Unknown Source)
    at java.base/java.util.concurrent.CompletableFuture.complete(Unknown Source)
    at io.fabric8.kubernetes.client.http.StandardHttpClient.lambda$completeOrCancel$5(StandardHttpClient.java:120)
    at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(Unknown Source)
    at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(Unknown Source)
    at java.base/java.util.concurrent.CompletableFuture.postComplete(Unknown Source)
    at java.base/java.util.concurrent.CompletableFuture.complete(Unknown Source)
    at io.fabric8.kubernetes.client.http.ByteArrayBodyHandler.onBodyDone(ByteArrayBodyHandler.java:52)
    at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(Unknown Source)
    at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(Unknown Source)
    at java.base/java.util.concurrent.CompletableFuture.postComplete(Unknown Source)
    at java.base/java.util.concurrent.CompletableFuture.complete(Unknown Source)
    at io.fabric8.kubernetes.client.okhttp.OkHttpClientImpl$OkHttpAsyncBody.doConsume(OkHttpClientImpl.java:135)
    ... 3 more

Closing this for now, there seem to be a bigger underlying problem outside the flink operator . More details here: https://github.com/java-operator-sdk/java-operator-sdk/issues/1876


thanks

I think It works better than the most stars one，it have more useful fields for user-agent, thanks for the author!

Thank you. I have just released new version which is 20% faster in parsing user agent strings.


Publish test results task links tests with build but not release

Hello,
I am using VSTS task to publish build results during build and release process.
The publish during build process works just fine, but release process associates tests with the build which triggered release, not the release itself.
It would be nice to have those tests associated with both: release and build to better see testing applied during certain release flow.
Is there a way to fix it?

Hi @sshumakov
I tried this with the vstest task and the publish test results task on my vsts account and was unable to repro.
Can you share more details on the task that you are using and the input parameters for the same?

Hi Allen,
We use publish test results with cmd which runs xunit tests on dotnet core.
The steps are the following:

Run cmd which runs tests and outputs report files in xunit format
Run Publish Test Results task which publishes previous reports, params are:

Test result format: Xunit
Test result files: $(System.DefaultWorkingDirectory)\our_project_name\TEST-*.xml
Merge Test results: yes
Test Run Title: our title
Platform: any cpu
Configuration: release
Upload Test Attachments: yes
Enabled: yes
Continue on error: yes
Always run: yes
Timeout: yes

Do we try to associate task with build or release or both? For me build association works fine, just release has this issue.

Hi Sergii,
We are looking into this issue and will get back to you with the findings. Thanks.

Hi Sergii,
This issue is fixed with the latest core-clr agent. Are you using some other agent? Can you verify your scenario now?

Hi Prawal,
I confirm that this issue has been fixed and I see results of tests associated with release.
Is there any way to configure task to associate test results with both: build and release?

Hi Sergii,
Currently you cannot associate test results with both build and release. Thanks for verifying.

Hi Prawal,
For the on-prem tfs, should we expect fix to be available with upcoming tfs "15" release. Test results are not getting associated with Release. We are on on-prem tfs 2015 update 2.

Hi @himanshubshah ,
Yes the fix will be available in Dev15 release. For now you can also try using the latest core-clr agent with your server.


AIE

Does it work well?

Does it work well?

Yeap, I've checked train/inference functionality. :) I'll investigate all the functionality today and  upload workspace files on this branch.


pkg/client/client.go: Add fallback connection information query

This PR adds a "fallback" query to the connection Info() function in pkg/client/client.go.
This "fallback" query is invoked when specific managed postgresql hosts deny queries to specific inet_* postgres functions, such as inet_client_addr(), inet_client_port(), inet_server_addr(), and inet_server_port(). The "fallback" query does not include any network information and is generally safe to run on all postgres environments.
This PR closes https://github.com/sosedoff/pgweb/issues/574 by enabling support for bit.io (see screenshots below). We suspect that this PR may also unblock other users of pgweb who are trying to connect pgweb to a postgresql instance with restricted function support (e.g. postgres as a service platforms).
This PR is a rather small delta and should not change any current functionality of pgweb, although if there are any design concerns please let us know.

cc @sosedoff 😁

Do you have any local setup instructions for postgres to emulate permissions?

Also, make sure to run go fmt on your branch

Any update on this?

Hello @sosedoff, you can replicate the permissions locally by revoking execution permissions on public schema of a database, here's how I did:
postgres=# create user testuser with password 'secret';
CREATE ROLE
postgres=# create database testdb owner testuser;
CREATE DATABASE
postgres=# \c testdb
You are now connected to database "testdb" as user "postgres".
testdb=# REVOKE EXECUTE ON FUNCTION inet_client_addr() FROM PUBLIC;
REVOKE
testdb=# REVOKE EXECUTE ON FUNCTION inet_client_port() FROM PUBLIC;
REVOKE
testdb=# REVOKE EXECUTE ON FUNCTION inet_server_addr() FROM PUBLIC;
REVOKE
testdb=# REVOKE EXECUTE ON FUNCTION inet_server_port() FROM PUBLIC;
REVOKE

After this any attempt to execute any of these functions will result in a permission denied error like this:
testdb=> select inet_client_addr();
ERROR:  permission denied for function inet_client_addr

See that even with those restrictions in place I'm still able to connect using my version of pgweb:

but current version fails with:

Is there anything else I can do so you can safely test my changes?

In that case your code should be checking for presence of permission denied for function in the error message before trying to use your simplified statement. It does not make sense to just retry without knowing the cause of the error in a first place. An additional unit test might be handy here if you're up to it.

hey @sosedoff, I have updated this PR with your suggestions. My go knowledge is limited and that impacted on the quality of the original implementation. Thanks for your patience!

Any chance you guys can finish off this PR this week?

The superseding PR #635 has been merged, with your contributions. It works with bit.io now.


python36Packages.fido2: 0.3.0 -> 0.4.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.6-fido2/versions.
meta.description for python36Packages.fido2 is: '"Provides library functionality for FIDO 2.0, including communication with a device over USB."'.

Checks done (click to expand)

built on NixOS

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.4.0 with grep in /nix/store/87xjrcx6frgm1dw4sjijzzp82ffzj0ij-python3.6-fido2-0.4.0

directory tree listing: https://gist.github.com/4f91ee8494fcaae9523bad51bdcde940

du listing: https://gist.github.com/33953632f5aa955e9a8a15c653cd5966

Outpath report (click to expand)

Outpath difference report
16 total rebuild paths
4 package rebuilds
4 x86_64-linux rebuilds
4 i686-linux rebuilds
4 x86_64-darwin rebuilds
4 aarch64-linux rebuilds
First ten rebuilds by attrpath
gen-oath-safe
python27Packages.fido2
python36Packages.fido2
yubikey-manager

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/87xjrcx6frgm1dw4sjijzzp82ffzj0ij-python3.6-fido2-0.4.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A python36Packages.fido2 https://github.com/r-ryantm/nixpkgs/archive/6cb7d25090d84f86bc7a0a18ef59703cd2794b14.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/87xjrcx6frgm1dw4sjijzzp82ffzj0ij-python3.6-fido2-0.4.0
ls -la /nix/store/87xjrcx6frgm1dw4sjijzzp82ffzj0ij-python3.6-fido2-0.4.0/bin

Success on x86_64-linux (full log)
Attempted: python36Packages.fido2
Partial log (click to expand)
Installing collected packages: fido2
Successfully installed fido2-0.4.0
/build/fido2-0.4.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/87xjrcx6frgm1dw4sjijzzp82ffzj0ij-python3.6-fido2-0.4.0
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/87xjrcx6frgm1dw4sjijzzp82ffzj0ij-python3.6-fido2-0.4.0/lib
patching script interpreter paths in /nix/store/87xjrcx6frgm1dw4sjijzzp82ffzj0ij-python3.6-fido2-0.4.0
checking for references to /build in /nix/store/87xjrcx6frgm1dw4sjijzzp82ffzj0ij-python3.6-fido2-0.4.0...
/nix/store/87xjrcx6frgm1dw4sjijzzp82ffzj0ij-python3.6-fido2-0.4.0

Success on aarch64-linux (full log)
Attempted: python36Packages.fido2
Partial log (click to expand)
Installing collected packages: fido2
Successfully installed fido2-0.4.0
/build/fido2-0.4.0
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fgqaicxfpqy990khmq36b4sdkjn4p4gv-python3.6-fido2-0.4.0
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fgqaicxfpqy990khmq36b4sdkjn4p4gv-python3.6-fido2-0.4.0/lib
patching script interpreter paths in /nix/store/fgqaicxfpqy990khmq36b4sdkjn4p4gv-python3.6-fido2-0.4.0
checking for references to /build in /nix/store/fgqaicxfpqy990khmq36b4sdkjn4p4gv-python3.6-fido2-0.4.0...
/nix/store/fgqaicxfpqy990khmq36b4sdkjn4p4gv-python3.6-fido2-0.4.0

Success on x86_64-darwin (full log)
Attempted: python36Packages.fido2
Partial log (click to expand)
Requirement already satisfied: cffi!=1.11.3,>=1.7 in /nix/store/qdgzqbwjp926yf8hkv7pdrl6p1ds39dr-python3.6-cffi-1.11.5/lib/python3.6/site-packages (from cryptography>=1.0->fido2==0.4.0) (1.11.5)
Requirement already satisfied: pycparser in /nix/store/2gwhdxbcic1qdplkshh8z542zp1c4fng-python3.6-pycparser-2.18/lib/python3.6/site-packages (from cffi!=1.11.3,>=1.7->cryptography>=1.0->fido2==0.4.0) (2.18)
Installing collected packages: fido2
Successfully installed fido2-0.4.0
/private/tmp/nix-build-python3.6-fido2-0.4.0.drv-0/fido2-0.4.0
post-installation fixup
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/knxv5xn6akrrsiy7bhbzr90y61z9dn4x-python3.6-fido2-0.4.0/lib
patching script interpreter paths in /nix/store/knxv5xn6akrrsiy7bhbzr90y61z9dn4x-python3.6-fido2-0.4.0
/nix/store/knxv5xn6akrrsiy7bhbzr90y61z9dn4x-python3.6-fido2-0.4.0


⚠ Spryr has degraded performance

In 2737014, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 6435 ms

Resolved: Spryr performance has improved in c0c49df after 9 minutes.


RAM Problem

When the new colab was updated (11-27) i solve the error of ram, but today im getting the same issue with the updated notebook

google decided not to let free colab run SD2

https://colab.research.google.com/github/amrrs/stable-diffusion-v2-colab-ui/blob/main/How_to_use_Stable_Diffusion_2_0_with_Diffusers.ipynb
Here is working for free

https://colab.research.google.com/github/amrrs/stable-diffusion-v2-colab-ui/blob/main/How_to_use_Stable_Diffusion_2_0_with_Diffusers.ipynb Here is working for free

is any colab free automatic 1111 working on

Forking and patching the stablediffusion repository of Stability-AI will bring it within 12 GB.
https://github.com/ddPn08/automatic1111-colab/commit/27484525d2aaf98b8ba75ce955dd553dc2eb3ab3
Here is a similar Issue.
https://github.com/ddPn08/automatic1111-colab/issues/16
https://github.com/camenduru/stable-diffusion-webui-colab/issues/21

There is no RAM error, that issue is fixed, and if you're loading a 5Gb+ model, just tick the box "large_model"

Sorry.
I have confirmed that Google Drive and SD2 work.


immich-go: 0.16.0 -> 0.17.0

Changelog: https://github.com/simulot/immich-go/releases/tag/0.17.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I guess the idea is that it is easier for a reviewer to know that meeging it won't break anything else?

Yes, and since you've built the package locally, and the package has no reverse dependencies, I guess you don't need to run nixpkgs-review yourself.


Use constructor member instead of statically depend on Stream

replace:
new Stream()

with:
new this.constructor()

So that highland can be inherited.

This is covered by extensibility in 3.0 (#337). If you want to give it a try, you can install from my branch with npm install quarterto/highland#extensibility.

Thanks, @quarterto but how can use it to extend highland? There seems to be no documentation, and this fix only makes it "work" as it should, right?

Documentation will be coming, it's only a dev branch :smile: main interface is _.use, which creates a new extended Highland environment:
var sub = _.use({
  foo: function() {
    return this;
  }
});

sub([]).foo() //⇒ Stream
typeof _([]).foo //⇒ "undefined"

The extensibility branch also includes the equivalent of this pull request (in the form of  Stream.prototype.create, which uses a configurable version of _).
Hope this helps!


KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively

This issue is related to an optimization for offset fetch logic.
When a user calls Consumer.poll(), among other things, the consumer performs a network request to fetch any previously-committed offsets so it can determine from where to start fetching new records. When the user passes in a timeout of zero, it's almost always the case that the offset fetch network request will not be performed within 0 milliseconds. However, the consumer still sends out the request and handles the response when it is received, usually a few milliseconds later. In this first attempt, the lookup fails and the poll() loops back around. Given that this timeout is the common case, the consumer caches the offset fetch response/result from the first attempt (even though it timed out) because it knows that the next call to poll() is going to attempt the exact same operation. When it is later attempted a second time, the response is already there from the first attempt such that the consumer doesn't need to perform a network request.
The existing consumer has implemented this caching in PendingCommittedOffsetRequest. The new consumer has implemented it in CommitRequestManager. The core issue is the new consumer implementation is clearing out the first attempt's cached result too aggressively. The effect being that the second (and subsequent) attempts fail to find any previous attempt's cached result, and all submit network requests, which all fail. Thus the consumer never makes any headway.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@kirktrue Should we rename the title of the PR/Jira now that we understand the root cause?

@kirktrue Should we rename the title of the PR/Jira now that we understand the root cause?

Done 👍

One concern on comment above about how we identify this situation (inflight fetch requests that we shouldn't delete too soon).
Another one about where to consider the situation. Inflight requests are removed in 2 places: direct call to fetch (handled in this PR), but also from the commit manager poll. The commit manager (as other managers) has logic for removing all expired requests in its poll loop, when calling failAndRemoveExpiredFetchRequests. Shouldn't we consider that too?

Did we consider the approach of simply decoupling the request timeout from the application event timeout? We could issue the fetch request without a time boundary (max value probably), and get the application event result with the time boundary (here).
Expressing the intention when creating the request and event seems clearer and brings what we want: fetch requests would remain in the background thread until they get a response or timeout, so they could be reused by a following fetch application event (for the same partitions). Then we could keep the manager logic simple and consistent around how inflights are maintained (removed when they get a response or expire, as it is now). I may be missing something, thoughts?

Thanks for the review, @lianetm. Agreed on all your points. This PR is a draft because it's a PoC and more thought and tests are needed.

Hey @kirktrue , this is the simple integration test I was suggesting on the other timeout PR, that should be an easy way to ensure that we're being able to fetch offsets and make progress on continuous poll(ZERO), which is what this PR should unblock I expect (just as guidance, needs tweaks to ensure TestUtils polls with 0). Leaving it here in case it helps validate the changes:
  // Ensure TestUtils polls with ZERO. This fails for the new consumer only.
  @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
  @MethodSource(Array("getTestQuorumAndGroupProtocolParametersAll"))
  def testPollEventuallyReturnsRecordsWithZeroTimeout(quorum: String, groupProtocol: String): Unit = {
    val numMessages = 100
    val producer = createProducer()
    sendRecords(producer, numMessages, tp)

    val consumer = createConsumer()
    consumer.subscribe(Set(topic).asJava)
    val records = awaitNonEmptyRecords(consumer, tp)
    assertEquals(numMessages, records.count())
  }


fix(papyrus_network): add NetworkError::BroadcastChannelsDrop and ignore it in test utils

fix(papyrus_network): revert "avoid panicking if the messages to broadcast sender was dropped"
fix(papyrus_network): add NetworkError::BroadcastChannelsDrop and ignore it in test utils

This change is


exported method Endpoint.Init should have comment or be unexported

Codacy detected an issue:
Message: exported method Endpoint.Init should have comment or be unexported
Currently on:

Commit:  dc4a09c4cc8ff7ce9eff537ce18a389f84579377
File:    doc/integrations/drp/DRP-go/drpold/drpclient.go
LineNum: 26

For the convenience of the Seagate development team, this issue has been mirrored in a private Seagate Jira Server: https://jts.seagate.com/browse/CORTX-30722. Note that community members will not be able to access that Jira server but that is not a problem since all activity in that Jira mirror will be copied into this GitHub issue.


api: add missing ids and tags

I noticed that some of the endpoints are missing ids. To further improve generated output from HTML/JS generator, this patch adds tags which improves the redocly generator.
This is a portion of https://github.com/osbuild/image-builder/pull/900

I think you need to rerun the generator. Also, #900 links to #839 which has the original problem description :) Could you make the this commit message a little more verbose?

Thanks, improved the PR description.

Is there any chance to get this in? I stripped this down to the barebones. All I want is the link in the README which I find quite useful and better navigation which the tags do bring. Thanks.


Revert "adjust url paths for v2 of the api."

What happened? Is there something that can be fixed in the PR? I'm happy to work with you towards the implementation of the v2 api.


MACs, not FLOPs

According to the tools/get_flops.py, I think you took MACs as FLOPs, but always one MAC is two FLOP.

@MenghaoGuo
I have the same question.


(#25) testing

PR #25

@nishanth-kd Travis has been integrated. Right now, we just have a sample unit test case. I think we can add unit test cases in separate trackings. TravisCI is complete.
Travis CI URL:
https://travis-ci.org/ColoredCow/employee-portal

@rathorevaibhav :+1:


Office and WPS files is supported?

Some applications have special behavior.

This server doesn't support microsoft specific extensions, but you have two extension points:

IEntryPropertyInitializer (singleton, default implementation DefaultEntryPropertyInitializer) which is used to initialize the default (and maybe custom) properties for a created collection/document.
IMimeTypeDetector (singleton, default implementation DefaultMimeTypeDetector) which allows the support for custom mime types.

Other than that, this server doesn't support any microsoft specific extension, but it tries to detect WebDAV access from the Windows Explorer.
When you need additional response header values, then your only option is to copy the code from WebDavControllerBase and modify the responses passed into WebDavIndirectResult.
When you need special behaviour, then it would be nice to:

Create an issue with the description of the desired behaviour (ideally with link to the specification)
Creating a PR implementing the desired behaviour (Optional)

eh...,my mean is open file by office app,do not make a ext.
but your IMimeTypeDetector give me a way.


zabbix 3 JMX interface

Hi !
It is possible to setup JMX interface with this ansible role ?
Thanks in advance

Hi @molinacarlos
No, not yet. It is hardcoded for now that only agents interfaces can be added.
But it is a nice addition to this role, so I should make this happen.
Thank you

Just pushed 0.8.0 to the galaxy.


kvstore: Add mutex Lock and Unlock metrics

Add metrics lock and unlock metrics in order to make it easier to understand how much time they take, and if there potentially is a lot of contention around these locks. Its also interesting as these result in potentially multiple etcd requests in case there is contention, and waits until it successfully has grabbed the lock.
This metric does not include the time it takes to potentially acquire a new session, or the time taken to grab the local kvstore lock for the given key.

Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Fixes: #issue-number
Added Lock and Unlock metric for kvstore locks

# operator: With this PR and https://github.com/cilium/cilium/pull/36014#pullrequestreview-2445051298
$ kubectl get --raw /api/v1/namespaces/kube-system/pods/http:$(kubectl get pods -n kube-system -l io.cilium/app=operator -ojsonpath='{.items[0].metadata.name}'):9963/proxy/metrics |egrep -a "(kvstore|etcd|version)" |grep "cilium_operator_kvstore_operations_duration_seconds_count"
cilium_operator_kvstore_operations_duration_seconds_count{action="AcquireLease",kind="set",outcome="success",scope="lease"} 2
cilium_operator_kvstore_operations_duration_seconds_count{action="ListPrefix",kind="read",outcome="success",scope="identities/v1"} 1649
cilium_operator_kvstore_operations_duration_seconds_count{action="ListPrefixLocked",kind="read",outcome="success",scope="identities/v1"} 2356
cilium_operator_kvstore_operations_duration_seconds_count{action="Lock",kind="set",outcome="success",scope="cilium/.init"} 395
cilium_operator_kvstore_operations_duration_seconds_count{action="Lock",kind="set",outcome="success",scope="identities/v1"} 2356
cilium_operator_kvstore_operations_duration_seconds_count{action="Unlock",kind="delete",outcome="success",scope="cilium/.init"} 395
cilium_operator_kvstore_operations_duration_seconds_count{action="Unlock",kind="delete",outcome="success",scope="identities/v1"} 2356
cilium_operator_kvstore_operations_duration_seconds_count{action="Update",kind="set",outcome="success",scope="cilium/.hear"} 197
cilium_operator_kvstore_operations_duration_seconds_count{action="Update",kind="set",outcome="success",scope="default/cilium"} 2

# agent: With this PR
$ k get --raw /api/v1/namespaces/kube-system/pods/http:$(kubectl get pods -n kube-system -l k8s-app=cilium -ojsonpath='{.items[0].metadata.name}'):9090/proxy/metrics |grep "cilium_kvstore_operations_duration_seconds_count"
cilium_kvstore_operations_duration_seconds_count{action="AcquireLease",kind="set",outcome="success",scope="lease"} 2
cilium_kvstore_operations_duration_seconds_count{action="CreateOnly",kind="set",outcome="success",scope="identities/v1"} 21
cilium_kvstore_operations_duration_seconds_count{action="CreateOnlyLocked",kind="set",outcome="success",scope="identities/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="Delete",kind="delete",outcome="success",scope="identities/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="Delete",kind="delete",outcome="success",scope="ip/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="Get",kind="read",outcome="success",scope="identities/v1"} 22
cilium_kvstore_operations_duration_seconds_count{action="Get",kind="read",outcome="success",scope="ip/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="Get",kind="read",outcome="success",scope="nodes/v1"} 38555
cilium_kvstore_operations_duration_seconds_count{action="ListPrefix",kind="read",outcome="success",scope="identities/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="ListPrefixLocked",kind="read",outcome="success",scope="identities/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="Lock",kind="set",outcome="success",scope="cilium/.init"} 63
cilium_kvstore_operations_duration_seconds_count{action="Lock",kind="set",outcome="success",scope="identities/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="Unlock",kind="delete",outcome="success",scope="cilium/.init"} 63
cilium_kvstore_operations_duration_seconds_count{action="Unlock",kind="delete",outcome="success",scope="identities/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="Update",kind="set",outcome="success",scope="identities/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="Update",kind="set",outcome="success",scope="ip/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="Update",kind="set",outcome="success",scope="nodes/v1"} 1
cilium_kvstore_operations_duration_seconds_count{action="UpdateIfLocked",kind="set",outcome="success",scope="identities/v1"} 1

/test


transformers-compat weird constraints

transformers-<IP_ADDRESS> is out of bounds for:

[ ] transformers-compat-0.6.2 ((>=0.2 && < 0.6) && < 0.5.3 && >=0.5.3). No maintainer. @RyanGlScott. Used by: library

< 0.5.3 && >= 0.5.3 is obviously unsolvable, so something's up here.
I am constraining transformers-compat on stackage to < 0.6.2 until I can figure out what's going on. May require fiddling with flags? http://hackage.haskell.org/package/transformers-compat-0.6.2/dependencies

I can only fathom how that constraint set was generated. But throwing it at a constraint solver with GHC 8.4 should ideally yield +five-three +generic-deriving +mtl -five -four -three -two.

I'm not sure what's up with stackage-curator on this one, but I've manually added the five-three flag, which is a sufficient workaround to allow the new version into the build plan.


Undoing primary contact change doesn't work [4]

Describe the Bug:
Probability (how likely the bug is to happen, scored from 1-5): 2
(For example, probability of 5 is something like "it happens to all users every time they log in."
Probability of 1 "only happens to certain users when a really specific and unlikely path is followed.")
Effect (how bad the bug is when it does happen, scored from 1-5): 2
(For example, effect of 5 is "the entire app crashes and makes it unusable for all users" or "the bug causes the wrong data to be saved, with critical information (e.g. payment) being affected."
Effect of 1 is "It makes some styling look a little bit weird.")
Steps to reproduce the behaviour:
Create a new project (or go to an existing one that doesn't have a primary contact) and add a primary contact. Click undo. The form doesn't clear.
I think the issue is that rowId comes back undefined from the query in ProjectContactForm.tsx (this is why the jest test works; the mock data does have rowId). I think rowId is probably missing from a query elsewhere that the contact form relies on.
Screenshots:
https://www.loom.com/share/5f30ea0e3fd04f8ab8ea5c4c2a94b2a7
Additional information:

OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]
Additional context

Closing, appears to be fixed.


Timesheet - 02/05/2021 - James Pang

Task 1
Finalizing projects hifi page.

added date formatting
tested in safari, chrome, mobile safari and mobile chrome and made changes based on UI issues
run through with design once again to ensure that all details are added
added support for multiline content in project details and cards
added support for embedded links within content strings
fixed various UI issues

Proof of Work

https://github.com/thenewboston-developers/Website/pull/1753

Time Spent
5 hours

Task 2
Added projects data to production api
Proof of Work

https://api.thenewboston.com/projects

Time Spent
2.5 hours

Task 3
Worked on weekly progress page.

updated icons that were merged in thenewboston/ui
updated fonts based on new font system
removed gap css property as safari does not support
update UI as there were interactions left out due to oversight
updated weekly progress api calls to include all teams' milestone and restructure code
modified implementation as there were miscommunication on where the milestone of each team will be, in this new update, the Community repo will consists of Audit, Community team's milestones and the general milestone.

Proof of Work

https://github.com/thenewboston-developers/Website/pull/1762

Time Spent
5 hours

Total Time Spent
12.5 hours
Account Number
c54c04774efaae20746fd3f29cdd619fea512e119bc1082b863572b2e8844104

Approved

Approved


Error: Uncaught (in promise): TypeError: value is null

Hi there,
Everything is work fine. but I'm not sure why this error keep showing on my console log when using the inline-editor.

Hi! I think it is related to https://github.com/qontu/ngx-inline-editor/issues/92 Could be?

@xxxtonixxx Yes. It's the same issue.

Okei @jmorganmartin. Then, we need more info @daylenlim, can you provide us a demo or more information?


Review how we start local Jupyter Servers

Understand the existing architecture, issues and the like.
Document the workflow, components so its easier to re-factor this.

This can now be closed as we have refactored the code and its simpler to understand the components for refactoring
Refactoring can be done in debt week.


Catch model saving error

If an error is thrown when trying to save a checkpoint, it will give the user the error and ask if they would like to save again.
This helps with cases where something goes wrong at the end of an hours-long training (like if you didn't have enough disk space)
The code was also rearranged so that the epochs and steps parameters do not get altered and new_ckpt is only created if it is used

I updated all of the model-saving logic to funnel into a single function that has the try/catch and consolidated the logic for them as much as possible while keeping all the functionality the same. There is probably some potential to consolidate more if we change some of the differing logic to match.
Includes a merge of this PR: https://github.com/kohya-ss/sd-scripts/pull/1371


Compilation of Rust projects linking to C

Currently compilation of Rust projects linking to C libraries is broken or at least flaky.
It's not a priority for me personally, but it would be nice to have.

Works and tested


Edited parser/dateparser tests, add-alias bug

Made tests for AddAliasCommand
Renamed date parser test to fit coding style format
Dates can be separated by / as well. Mixed - and / allowed (closes #186)
Fixed #200

Coverage increased (+0.6%) to 70.028% when pulling b378d00d3f59f0b90e7b91f8b37270825a2574de on more-parser-tests into 8e326a023c339a6a4d0707f1e6ad89b0503d9a42 on master.

Coverage increased (+0.6%) to 70.028% when pulling 5ad283e3d4e6adcc0015ee8325f9c0dadf46163e on more-parser-tests into 8e326a023c339a6a4d0707f1e6ad89b0503d9a42 on master.

Coverage increased (+0.8%) to 70.702% when pulling 2b5f6948be9c35fb342ba858cda2047b94f72b63 on more-parser-tests into 23ef6776d927542e76571157e85a0625b71c104a on master.

Coverage increased (+0.8%) to 71.127% when pulling 4e495a053f6e5b23f700f5336151e6dcf8f2a007 on more-parser-tests into c0244749545a528a254ffa6915821c28b818d2cf on master.


fix(unit tests): Update reporting; fix failing launch webtop test.

Update unit test reporting to look like Center's unit test reporting - mocha style red/green x/checkmarks.
Remove trailing slash from webtop launch URL test.

@clarkjefcoat, just a quick look please.

:+1:


TLS 1.3 Client Version Issues

Problem:

we should never assume that a "actual connection" is TLS1.3, until the server upgrades it through supported version
https://github.com/awslabs/s2n/blob/60180cb4e3d0d2829c8c6abb155fd8a23f414d1f/tls/s2n_connection.c#L705

also make sure the client never sends > 0x0303 in the client hello

https://github.com/awslabs/s2n/blob/60180cb4e3d0d2829c8c6abb155fd8a23f414d1f/tls/s2n_client_hello.c#L388
Proposed Solution:

Fix in connection.c or
in client_hello.c, add conn->actual_protocol_version = MIN(conn->client_protocol_version, S2N_TLS12); to https://github.com/awslabs/s2n/blob/60180cb4e3d0d2829c8c6abb155fd8a23f414d1f/tls/s2n_client_hello.c#L368

addressed in #1740


Using imageWithSmartInvert with  isRecording = true/false - fails everytime

I am using the imageWithSmartInvert with isRecording = true/false and the test always fails
assertSnapshot(matching: view, as: .imageWithSmartInvert)
My original image is:

when i run with isRecording=true it generated the Black/Golden image.
when i run it with isRecording=false the snapshot does not match reference.
.
.
.
failed - Snapshot does not match reference.

"/Users/abc/Library/Developer/CoreSimulator/Devices/ACC40F6C-1421-4D1B-9008-20C0EB7B81EE/data/Containers/Bundle/Application/14408B86-E69D-4390-9E8D-0A050D98F518/SmallAppHost.app/PlugIns/SnapshotTests.xctest/SnapshotTestsBundle.bundle/Snapshots/Tests/testLoading.1.png"
@+
"/Users/abc/Library/Developer/CoreSimulator/Devices/ACC40F6C-1421-4D1B-9008-20C0EB7B81EE/data/Containers/Data/Application/E4FA0EDE-9A8C-4B4A-9E7B-4FDDBDF81EDB/tmp/Tests/testLoading.1.png"

Newly-taken snapshot does not match reference.
.
.
.

i tried opening the image in above locations - both are same -

can you please have a look?

attaching the images from xcresult:

zoom into the centre of the difference image and you will see the difference

the difference is

Hi Parth! Can you provide some more details about what you're snapshotting? Is that a simple UIImageView in the center of the screen? If you have a branch that reproduces the issue, that would greatly help me investigate what's going wrong.

@NickEntin - i and @abinodhthomas have added a support to add the precision - https://github.com/parikhparth23/AccessibilitySnapshot
plz have a look and merge it.

If you're seeing this on subsequent runs on the same machine, it sounds like there's likely an underlying issue going on here. While adding precision might work around it, I'd like to see if we can figure out the root problem first. Can you provide a code sample that reproduces the issue?

@NickEntin i wish i could share the code or even a snippet. the code is a proprietary code.
i tried creating a sample app and it works without any issue.
do you mind merging the precision code to your repo? - if you do it i will be able to use this framework. And i will look into our code base why the image is failing.

the precision value by default is to match 100%

There is now tolerance parameters available when using FBSnapshotTestCase as the snapshotting engine. Support for SnapshotTesting is tracked by #63.
That said, I would highly recommend looking into why your views are not able to pass consecutive snapshots on the same machine and only use precision for inter-machine comparison failures. Perhaps you need to disable animations, or something along those lines? The framework is not designed to support snapshotting non-deterministic rendering views.


Sepia theme

Hello devs, can you add an option to change the article background to sepia on iOS? Something like #fbfod9
Thank you very much :D

Thanks for the suggestion. We plan to handle this with theming.  Duplicate of #19


Ensure that doc url hash IDs are scrolled to on page load

I broke this a few weeks ago so I'll fix it
Demo: https://5f0fa445faca4aff5f580029--naughty-borg-09b903.netlify.app/?version=master&search=#brace_style

Done


Mozilla/5.0(Windows NT 10.0; Win64; x64)AppleWebKit/537.36(KHTML, like Gecko)Chrome/94.0.4606.81 Safari/537.36 Edg/94.0.992.47

Issue Type: Bug
This user-agent beacon login appeared in my Azure DevOps  in 2018, 2019 that I was able to track down and sent reports through send feedback as to the problem.  I am not a user agent so my computer has been compromised and bugged.  Also "Bug Job" appeared in 2013-2014 from Public Apache Server according to Mozilla Performance tools.  Dallas Police Dept CIU has the report and documentation on that computer interanet, internet break in.
My number is listed with Microsoft Corp. as I am a MPN 655702 just now able to send this communication.  Ransom was for $1,000.00.  Still dealing with them in GPS Ham form on grid EM13PA95.
 Please paste.

/needsMoreInfo


Feat: Add powerman role

Add task, handler and template.
Missing readme.

To solve the Test RPM build check you need to add powerman to https://github.com/bluebanquise/bluebanquise/blob/ca41671e349d61bb54783898ad7187d2c91af33d/bluebanquise.spec#L3-5.

Thanks a lot !

Ready to be reviewed.

I did not notice yesterday, but the static code analysis test is failing.

Yes, I have seen this failing static check. I skipped it as non related to the PR in progress :-)


Update specification.md

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I realized this comes from the go-algorand repo itself and will need to be fixed there.  PR filed here https://github.com/algorand/go-algorand/pull/5074
Thanks!


JSX: a way to make all the properties of value-based elements optional

It's not documented, but currently, if the JSX.ElementAttributesProperty interface is declared empty,
declare namespace JSX { interface ElementAttributesProperty {} }

then the element attributes type becomes same as the element instance type. However, if the element instance type is a class, this leads to a situation where the compiler requires that all the members of the class be represented as attributes since they're not optional (and even cannot be marked as such as the class syntax doesn't allow optional members).
class MyComponent {
  myProp: string;
  private myMethod(): void;
}
var a = <MyComponent myProp='value'/>;
// error: Property 'myMethod' is missing in type MyComponent

This prevents me from using JSX for type-checking Angular 1 templates (you can find my experiments in this area here).
What if we introduce some way to tell the compiler that not all the properties are required, but only some of them? E.g. those having a certain decorator?
A related issue: #5151

So what is the proposal?

I think we could reasonably say that private / protected members get ignored when checking against the element attributes type.

Probably something like
declare namespace JSX { interface ElementOptionalAttributesProperty {} }

All the properties would be considered optional. Not ideal but could be a good start.
Ideally, I'd like to use decorators to mark required properties. But I can't think of a good way to tell the compiler about such rules.

Discussed at the backlog slog today. There are a lot of scenarios here that would be helped by this, but the technical implications of the first type operator are very large. Some more notes are at #8228.
Just in terms of setting expectations, this isn't going to be something we can do in time for TypeScript 2.0

I opened duplicated issue #12016 .
I wrote my motivation to that issue.
I read backlog slog. I think I do not want a big thing to this issue.
My proposal is below.
declare global {
    namespace JSX {
        // We use magic interface. this is pragma for compiler.
        interface ElementAttributesProperty {
            // use optional property
            ''?: any;
        }
    }
}

in src/compiler/checker.ts,
        function checkJsxOpeningLikeElement(node: JsxOpeningLikeElement) {

            ...

            // add makeOptionalProperty condition from ElementAttributesProperty interface
            if (targetAttributesType && !sawSpreadedAny && !makeOptionalProperty) {
                ...
            }

I think we could reasonably say that private / protected members get ignored when checking against the element attributes type.

This is not so good for skate.js.
skate.Component extends HTMLElement signature can't control modifier by myself.

Yes, what I requested was just an alternative way to type check JSX, not 'optionalized types`, which is a separate complex feature.

Partial types, as proposed by @RyanCavanaugh in #11233, might well be able to model this.

@aluanhaddad Partial and optionalized types are the same thing. Even though it sounds like overkill for this issue, it will work, however we'll need to have a way to tell the compiler that <Foo ... /> refers to subset Foo not just Foo. So a new JSX-related setting will be needed.
And if we need a new switch anyway, does its implementation really need to involve partial types if it can be done without them like @vvakame wrote?

Now I am understood what @RyanCavanaugh and @aluanhaddad are said.
We can use Partial types (a.k.a Mapped types) now.
We need good proposal.
IMHO, If JSX.ElementAttributesProperty has callable property, Use the return type instead of the type passed as an argument for checking.
like this.
interface ElementAttributesProperty {
    ''<T>(v: T): Partial<T>;
}

This issue is last 2 mile of SkateJS+TypeScript. (other 1 is #12488 )
If you have no seen SkateJS yet, please try it once. it's fun!
http://skate.js.org/
https://github.com/vvakame/skatejs-todo/

Hm...
abstract class Component {
  /** A bogus type-system-only property. */
  private __bogusProps: Partial<this>;
}

declare namespace JSX {
  type Element = string;
  interface ElementAttributesProperty {
    __bogusProps: Partial<this>;
  }
}

class FooComponent extends Component {
  foo: number;
  method() { }
}

// ta-da !
let z = <FooComponent foo={2}/>;

@RyanCavanaugh It's been two years. Any progress on this front? We were hoping to enable JSX for Aurelia vNext but this issue is causing the compiler to be very unhappy with us.

@EisenbergEffect Doesn't this solution work for you?

One of the unique and important aspects of Aurelia's design is that it doesn't require using base classes for components. Components are plain classes. In fact, we discourage the use of inheritance and prefer guiding our community to use more compositional approaches. As such, even if the above did work, it wouldn't be an acceptable solution for us. That said, I've tried a few solutions that leverage the JSX namespace without inheritance and VS Code at least, doesn't seem to be affected at all in it's TS error reporting. It just doesn't work. I've been starting to wonder if there's a bug that was introduced in the last update... I need to experiment some more. It would be nice to have a real solution to this though.

@EisenbergEffect It suddenly crossed my mind that we could extend interface Object instead of a base class:
interface Object {
  /** A bogus type-system-only property. */
  __bogusProps: Partial<this>;
}

declare namespace JSX {
  type Element = string;
  interface ElementAttributesProperty {
    __bogusProps: any;
  }
}

But alas... TS adds the __bogusProps property to every object, but it thinks that this property has the type Partial<Object>, not Partial<...our more specific type...>.
BTW, I didn't quite understand your "even if the above did work". It does work.

Thanks for continuing to explore this @thorn0 I honestly can't remember if I tried the technique above or not. I know I tried a few things which didn't seem to work at least at one time. What I wanted to emphasize was that, either way, it's contrary to Aurelia's philosophy to force the use of a base class, so we wouldn't want to recommend this approach to our community as a best practice.
@RyanCavanaugh What we really need is a way to declare that the element attributes are derived directly from the type itself. In other words the properties of the object are the attributes of the element. There's no special property involved.

@EisenbergEffect Did you consider writing a design proposal?

Here's my code:
import { createElement } from './templating/create-element';

declare namespace JSX {
  type Element = string;
  interface ElementAttributesProperty {
  }
}

class Foo {
  public bar: string;
}

const view = () =>

    <Foo bar="baz"></Foo>

;

I get the error [ts] Property 'bar' does not exist on type '{}'. What I have done wrong?

@EisenbergEffect Because of the import statement, your file is a module, which means your JSX namespace is local, not global.
To make it global, use declare global:
declare global {
  namespace JSX {
    type Element = string;
    interface ElementAttributesProperty {
    }
  }
}

But after that you're going to face my original issue: the compiler requires that all the non-optional members of the class (including methods and private members) be represented as attributes.

Thanks @thorn0 ! I can confirm that exact behavior now. Here's my code:
import { createElement } from './templating/create-element';

declare global {
  namespace JSX {
    type Element = string;
    interface ElementAttributesProperty {
    }
  }
}

class Foo {
  public bar: string = '';
  public baz: number = 0;
}

const view = () =>

    <Foo bar='test'></Foo>

;

@RyanCavanaugh This would be 100% valid in Aurelia but TS is complaining that the Foo element doesn't include a value for baz. It sounds like the TS checking for JSX scenarios is causing issues for both Angular and Aurelia. It would be nice to have a solution for this, some compiler setting or something that could be done with the ElementAttributesProperty declaration to indicate what behavior we need.

Hi, @vvakame , the optional property is not working with typescript 3.4.5.
The typescript source code is here:

I got it  that how to turn off the required properties check in TSX context.
The code is below:
jsx-namespace.d.ts
declare namespace JSX {
     // ...
    interface IntrinsicAttributes {
        [attributeName: string]: any
    }
    // ...
}


konstraint: 0.19.1 -> 0.20.0

Description of changes

Bump konstraint to 0.20.0
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[X] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 173366 run on x86_64-linux 1

1 package built:

konstraint

@ofborg eval


phpbrew returns ??? in the console.  The detect_unicode setting needs to be turned off for php 5.3

I have already tried to install PHP 5.3.29, 5.3.28 with this command.
phpbrew install 5.3.29 +default +dbs +mb +xmlrpc +gettext +openssl +apxs2=/usr/bin/apxs2 +exif +iconv

It was successfully installed but when I use or switch to PHP 5.3.29 and run command such as phpbrew --help
I got this response.
root@ubuntu:~# phpbrew

???root@ubuntu:~#

And all phpbrew command return<EMAIL_ADDRESS>I have to reboot PC and edit ~/.phpbrew/init to change from 5.3.29 to newer version such as 5.6.0.
How to make 5.3.xx installed properly?

I think this is related to phar file. does it work for composer.phar too?

I think you can run reset to clear the wrong characters.

try
~/.phpbrew/php/php-5.3.29/bin/php --version
~/.phpbrew/php/php-5.3.29/bin/php composer.phar

looks like your php 5.3 was successfully built and installed. but it does support phar very well. I don't know why

Ok. I will leave it with php5.2 in the trash can then. :-D
All other versions are working fine. 5.4, 5.5, 5.6, 7.0

Yeah I just tried this
~/.phpbrew/php/php-5.3.29/bin/php /Users/c9s/.phpbrew/bin/composer                               !12822

And I got
???+?

I guess the packed phar is different from which 5.3 can support.

Thanks for reporting this, I think we can keep it as backlog.

It's wierd. It works fine on my centOS 7 x64. (php 5.3.29 +default). maybe it's platform related problem. btw, #731 seems using php 5.6 which should be ok as @ve3 reported.

I can reproduce on my OS X, this issue is only for php 5.3,  php 5.4 works totally fine with composer and phpbrew.

After some research, I discovered it's the php directive detect_unicode the cause of the problem. Setting it to Off in php.ini solved the issue. It's enabled by default. It must be some issue present in all versions of php until 5.3 concerning Phar and this setting.

@isapa1984 Thanks for the research you did.   does detect_unicode need to be turn off for all versions? or just for 5.3?
Thanks!

@c9s Good question. I could only test for 5.3.13.

OK, I think detect_unicode should be on for versions > 5.3.  I will consider about turning off this for 5.3

@isapa1984 could you try 1.22 release to see if this issue is solved? thanks! :)

Oops!
phpbrew install 5.3.29

PHP Fatal error:  Allowed memory size of 33554432 bytes exhausted (tried to allocate 72 bytes) in phar:///usr/bin/phpbrew/src/PhpBrew/PatchKit/RegExpPatchRule.php on line 99

only 32MB memory available ?
On Sun, Jun 12, 2016 at 11:34 PM, vee w<EMAIL_ADDRESS>wrote:

Oops!
phpbrew install 5.3.29
PHP Fatal error: Allowed memory size of 33554432 bytes exhausted (tried to
allocate 72 bytes) in
phar:///usr/bin/phpbrew/src/PhpBrew/PatchKit/RegExpPatchRule.php on line 99
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/phpbrew/phpbrew/issues/732#issuecomment-225443815,
or mute the thread
https://github.com/notifications/unsubscribe/AADGzlBev7O0Dgb-72G17J-z1yNwnmc6ks5qLCcJgaJpZM4IaClH
.

Yes

I have no idea with this unless you adjusted memory_limit to higher value X)

Closing as a general PHAR/PHP issue. I cannot think of anything that could be done on the application side.


docs: replace terraform google groups with terraform discuss

Welcome to the HashiCorp Terraform mailing list. As of July 22, 2021 inbound messages to this group have been disabled, and it will now be used for outbound announcements only.
Please direct questions and conversations to our primary medium to communicate with practitioners: HashiCorp Discuss. There you can ask questions, engage with the community, share your stories, and interact with Terraform developers.
For more information about Terraform, please see the website at https://www.terraform.io/.

Very helpful!


Add Bitrise

Hi folks!
Awesome initiative and looking forward to contributing 🚀
Signed-off-by: Hendrik Haandrikman<EMAIL_ADDRESS>

Thanks!


Discussions about cross platform support.

So I have always thought of EZSwiftExtensions as a standard library (kind of like Apache Commons).
Standard libraries of languages have the characteristic of being cross platform. So as a consequence I decided to investigate the feasibility of cross platform support.
I tried spinning up a docker container using  https://github.com/swiftdocker/docker-swift. After that I tried https://swift.org/package-manager/ to bundle the module in linux. I was able to get the foundation code to work but not the IOS specific code - (UIKit).
This issue is a discussion if we want to pursue cross platform support and a plan for the same.

Isolate Foundation and UI Extensions into two directories.
Use swift package manager to build it in linux. Keep the devops flow using xcodebuild in IOS.
Write a travis.yml script for linux only builds.
Bundle and distribute the foundation subset of EZSwiftExtensions (This one is an open question on how to best address it).

I believe our iOS framework should already come with both Foundation and UI Extensions. I don't think our iOS users should have to install both EZSwiftExtensions-UI and EZSwiftExtensions-Foundation directories separately.

This issue was brought up about a year ago too. It wasn't ready at that time and there weren't enough non-Apple related uses of Swift back then.
I think instead of making 2 separate directories which will confuse the user, we could just add if cases and only compile the code the user can compile?
Like:  #if os(iOS)
Also version compatibility is another similar issue. Ideally the user should be able to use the latest version of EZSwift even if they have a different version of Swift. This can be achieved by adding checks like: #if swift(>=3.0) everywhere.

I agree with everything but the last paragraph. I think it will look like a shitshow with those #if swift(>=3.0) everywhere....

Ok then should I go ahead and add #if os(iOS) on all UIKit classes (its a little concerning for me to make it architecture specific instead of separating the concerns into different folders).

Yeah, go ahead. But before check if there is an easier way of doing it, there just might be.

Thanks guys, this will be helpful. For my MacOS and Linux apps I've had to copy code into my project that could be based on Foundation rather than UIKit. I'll much prefer being able to use the code without having to modify it.

I am prioritizing this and started the ball rolling in : https://github.com/goktugyil/EZSwiftExtensions/pull/431

MacOSx support is complete. I will begin work on WatchOS when I get the free time.

Thanks @Khalian. You did an awesome job


feat(tutorial): complete step 3

Closes #
{{short description}}
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

can someone help me review? thanks!


Add documentation for DPG Credentials

We have guidance for service teams regarding how to configure credentials for DPG clients in two places right now:

https://github.com/Azure/autorest.csharp/blob/feature/v3/docs/protocol_method_client.md
https://github.com/Azure/azure-sdk-for-net/blob/main/doc/Data Plane Code Generation/AzureSDKCodeGeneration_DataPlane_Quickstart.md#create-starter-package (see -securityScope)

Part of: https://github.com/azure/autorest.csharp/issues/1945
Let's make sure this is consolidated somewhere under: https://github.com/Azure/azure-sdk-for-net/blob/main/doc/Data Plane Code Generation
Success Criteria
Service team can generate a DPG with the appropriate credentials for their service without reaching out to members of the Azure SDK team regarding which credential type to use, how to configure it to be generated, what to do if none of the types supported by the generator works for them.

[x] The two referenced documents link to each other
[x] Service team partners know how to choose the credential type from reading the docs
[x] Service team partners know how to pass in authentication values like default scope from reading the docs
[x] Service team partners know what to do if neither of the two supported authentication approaches applies to their service.

This has historically been a challenging area for library authors, so we should do our best to support them in this.

close as all sub-tasks are completed.


Explicitly specify owner in all package operations

Summary
When querying GitHub packages we should use the owner parameter, rather than relying on the user from the token.
Related to #2643
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[x] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 46.885%. remained the same
when pulling 58a2c7666c8de48edd6a3841da4ce8359b58b2fb on eleftherias:default-owner-everywhere
into 0c5d49a231b7b55caaaeaa59bea0d1ac034cedde on stacklok:main.


a problematic comment is calling trim on an undefined type

Description
Not sure what's causing this, but I'm noticing the action throws an error on some changes and fails the run. Example run!
What type of issue is this?

[x] bug

Requirements

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Here's the action output- none of the changes in the PR this action ran on contained changes to comments 🤔
Run slackapi/slack-health-score@v0
  with:
    extension: go
    codecov_token: ***
    github_token: ***
    include: cmd internal
Using SHA: 24813c79e3d764a6f1163dc83d3fb64516f69ef5
Pinging codecov API for coverage data...
/Users/runner/work/_actions/slackapi/slack-health-score/v0/dist/index.js:69097
    const commentType = (commentData == null) ? null : type.split('//')[1].trim();
                                                                          ^

TypeError: Cannot read properties of undefined (reading 'trim')
    at /Users/runner/work/_actions/slackapi/slack-health-score/v0/dist/index.js:69097:75
    at Array.map (<anonymous>)
    at Object.grepForProblematicComments [as grep] (/Users/runner/work/_actions/slackapi/slack-health-score/v0/dist/index.js:69092:53)
    at Object.compileScore [as compile] (/Users/runner/work/_actions/slackapi/slack-health-score/v0/dist/index.js:68827:28)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Node.js v20.13.1

It seems to be this line:
https://github.com/slackapi/slack-health-score/blob/7f03d8adc55dc5e9cbab340e11093e271cd55b2c/src/score_components/find-problematic-comments.js#L50

The line of code this dies in the particular code base is:
cmd/platform/deploy.go:146:		Data: logger.LogData{"authSession": "{}"}, // FIXME: Include app information

The problem is a combination of:

the comment as in-line with code, and
the code contains a colon character

The above two leads to this code, that splits the output of grep on colons, to fail.
Thinking about how to prevent this... 🤔

Super strange case 😳 I'm not sure of a fix either but I found this grep helpful for finding such cases:
$ grep -Er ":[^/]*// " .

Oh that shouldn't have closed- oops 😳

Here's another case of the same issue: https://github.com/slackapi/deno-slack-hooks/actions/runs/10218716617/job/28275465214?pr=90


fix url schema for webrdp example

Tested the corrected URL on dogfood.
Was
module "windows_rdp" {
  source      = "registry.coder.com/coder/module/windows-rdp"
  ...
}

Now
module "windows_rdp" {
  source      = "registry.coder.com/modules/windows-rdp/coder"
  ...
}

Hmm there seems to be an issue on my workspace... Please hold