New Windows CI job configurations

I'm working on updating the test CI machines. One of the changes is getting rid of the Win2012r2 machines, which are EOL as of recently. I see libuv-test-commit-windows-cmake uses Win2012r2 which will soon be unavailable.
What are the most important Windows and Visual Studio versions that need to be covered for the libuv project? We'll have Windows 2016, 2019, and 2022, as well as Windows 10 and 11. Visual Studio versions that will be present are VS2015 and above.

See discussion in https://github.com/libuv/libuv/issues/3889.  I personally don't have much of a problem with dropping pre-Windows 10 but VS2015 may be important because of python (more specifically: native python modules that use libuv.)

Sounds good to me. We have additional coverage through GH Actions.

The new machines are set up and I'm in the process of changing jobs on Jenkins. As discussed, I changed libuv-test-commit-windows-cmake to include new machines and I also added ARM64 machines (thanks for the idea @richardlau). In the following months, I'll be updating the Azure machine as well and then I'll probably add some Windows 11 machines to this job too.
Btw, is UNSTABLE the expected state when everything passes well?

Closing since I don't believe there's anything to do on our end?

Btw, is UNSTABLE the expected state when everything passes well?

Not sure. Maybe @richardlau knows.

No, UNTSABLE is not the expected state since libuv does not have the concept of a flaky test.
The configuration for libuv-test-commit-windows-cmake has:
echo TAP version 13 > out\test.tap
out\Debug\uv_run_tests.exe 2>&1 | tee -a out\test.tap
if errorlevel 1 exit /b
tap2junit -i out\test.tap -o out\test.xml
if errorlevel 1 exit /b

echo TAP version 13 > out\test_a.tap
out\Debug\uv_run_tests_a.exe 2>&1 | tee -a out\test_a.tap
if errorlevel 1 exit /b
tap2junit -i out\test_a.tap -o out\test_a.xml
if errorlevel 1 exit /b

:: The JUnit Plugin only marks the job as Unstable when it finds any kind of failure, including flaky tests.
:: We need to look for 'not ok' in the tap files below to fail the job when there are real failures.

If I look at the artifacts in https://ci.nodejs.org/view/All/job/libuv-test-commit-windows-cmake/nodes=win10-vs2019/ it looks like:

The tap files have no failures, so the check in the job that searches for ^not ok that would have failed the build is not triggered.
The xml file is showing failures. A lot of failures. They look like:

		<testcase name="None">
			<failure type="failure" message=" (0)"/>
		</testcase>

which looks like a failure of tap2junit to convert the tap to xml.


[Fix] Fix the training problem of pix2pix and cyclegan

#36 #26

#36

#36 #26

Codecov Report

Merging #38 (7329e6b) into master (80f31bd) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 7329e6b differs from pull request most recent head 4e2b773. Consider uploading reports for the commit 4e2b773 to get more accurate results

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   75.23%   75.23%
=======================================
  Files         108      108
  Lines        6517     6517
  Branches     1149     1149
=======================================
  Hits         4903     4903
  Misses       1302     1302
  Partials      312      312

Flag
Coverage Δ

unittests
75.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...chitectures/stylegan/generator_discriminator_v1.py
88.70% <0.00%> (-1.13%)
:arrow_down:

...chitectures/stylegan/generator_discriminator_v2.py
87.77% <0.00%> (+1.11%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f31bd...4e2b773. Read the comment docs.


fix: Avoid use of == and !=

Description
Fixed Avoid use of == and !=  JS-0050
Fixes # (issue)
https://deepsource.io/gh/appsmithorg/appsmith/issue/JS-0050/occurrences
Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Can anyone add "hacktoberfest-accepted" label to this issue?

@sheetal2001p Please link the GitHub issue which this PR is closing to avoid duplication.


STEEM currency pair not supported?

I found STEEM in some json resource files, but it is not available as currency pair combination.

you can make any currency pair you want by new CurrencyPair("STEEM", "USD")


bug: ingress routing resource manifest file does not take effect 路由的资源清单文件不生效

Issue description
添加路由的资源清单文件如下：

apisix-gateway使用nodeport形式访问关联到slb的出口上
然后test1.laoganma.fun解析到slb的公网出口地址
浏览器访问域名服务

@Marco-Zheng Any suspicious error logs?

How does ingress work? If ingress parsing route yaml and store the route in etcd? how can we know the route.yaml is efficient

In newest version (0.6), we record events and status for each ApisixRoute and ApisixUpstream, and error reason will be enrolled there.

so i need change a version to 0.6.0? if these version can match the apisix2.4?

0.6.0 is in the progress of vote, it will be released in few days. We should use 2.5 or later APISIX to match it.

Do you have any idea or advise for that case? I had reviewed my configuration by checking your configure doc, but i still have no idea about it.

@Marco-Zheng The 0.5.0 apisix-ingress-controller release doesn't contain the event and status feedback, Is it convenient for you to change the log level of apisix-ingress-controller to debug, we may get some clues from these debug logs.

@Marco-Zheng The 0.5.0 apisix-ingress-controller release doesn't contain the event and status feedback, Is it convenient for you to change the log level of apisix-ingress-controller to debug, we may get some clues from these debug logs.

I change the log to debug and the logs as below

It seems your apisix-ingress-controller still tries to watch the Ingress in networking/v1.

It seems your apisix-ingress-controller still tries to watch the Ingress in networking/v1.

I have reconfirmed my config and follow below file

change my file to

coud you please help me to check again, i try to change apisix.apache.org/v1 to apisix.apache.org/v1beta1
but failed,  here is config map,  i don't know why it's still inoperative

@tokers This is the version for Kubernetes Ingress resource.

@tokers This is the version for Kubernetes Ingress resource.

Yes, as you can see the config map version is v1beta1 now, and apisix route.yaml as above, and i try all methods to let it works, but failed, i add the route in apisix dashboard, it can work well..

@tokers This is the version for Kubernetes Ingress resource.

Yes, as you can see the config map version is v1beta1 now, and apisix route.yaml as above, and i try all methods to let it works, but failed, i add the route in apisix dashboard, it can work well..

What you configured is not ingress but the apisix route.

@tokers This is the version for Kubernetes Ingress resource.

Yes, as you can see the config map version is v1beta1 now, and apisix route.yaml as above, and i try all methods to let it works, but failed, i add the route in apisix dashboard, it can work well..

What you configured is not ingress but the apisix route.

below configure also failed to send request, as you mentioned before, the log still print networking/v1, but the configmap actually is v1beta1, does any other config will influence it

@tokers This is the version for Kubernetes Ingress resource.

Yes, as you can see the config map version is v1beta1 now, and apisix route.yaml as above, and i try all methods to let it works, but failed, i add the route in apisix dashboard, it can work well..

What you configured is not ingress but the apisix route.

below configure also failed to send request, as you mentioned before, the log still print networking/v1, but the configmap actually is v1beta1, does any other config will influence it

OK, let me try to reproduce it.

OK, let me try to reproduce it.

Thanks a lot

@Marco-Zheng any update?

@Marco-Zheng Sorry for the long delay. I have tried to reproduce this problem on my side with apisix-ingress-controller/1.0, but I cannot reproduce this scenario, could you please try to use the apisix-ingress-controller/1.0 again and see whether this problem still exists.

@tao12345666333 not yet

@tokers i add a httpserver-route in namespace ingress-apisix

apiVersion: apisix.apache.org/v1
kind: ApisixRoute
metadata:
  namespace: ingress-apisix
  name: httpserver-route
spec:
  http:
  - name: rule1
    match:
      hosts:
      - local.httpbin.org
      paths:
      - /*
    backend:
        serviceName: httpbin
        servicePort: 80

then use kubectl exec -it -n ingress-apisix apisix-6b6cfdd678-j24hx -- curl http://<IP_ADDRESS>:9180/apisix/admin/routes -H 'X-API-Key: edd1c9f034335f136f87ad84b625c8f1', no route was found

could you please explain to it , any problem with my yml?

My expect result is route create by my yml, and i can search route in apisix-dashboard, but nothing was found.

@Marco-Zheng Please use the ApisixRoute/v2alpha1, the v1 version was deprecated and obsolete.

@tokers kubernate create -f xxx.yml was failed when i use ApisixRoute/v2alpha1, the version of my ingress-controller is 0.6.0
and apisix version is 2.7, doesn't this problem belongs to version?

@tokers kubernate create -f xxx.yml was failed when i use ApisixRoute/v2alpha1, the version of my ingress-controller is 0.6.0
and apisix version is 2.7, perhaps this problem belongs to version?

@tokers kubernate create -f xxx.yml was failed when i use ApisixRoute/v2alpha1, the version of my ingress-controller is 0.6.0
and apisix version is 2.7, perhaps this problem belongs to version?

Oh, these two versions are not a good pair. You may try to update APISIX Ingress Controller.
BTW, what is the error reported by kubectl.

@tokers It's shown as below
error: unable to recognize "httpbin-route.yaml": no matches for kind "ApisixRoute/v2alpha1" in version "apisix.apache.org/v1"

@tokers Is 1.0.0 the right version

You should apply all the CRDs provided in this repo before you create resources.

@tokers do you means i need create apisix crds although we have apisix server in k8s? any example for this?

@Marco-Zheng  Please try to execute the following command kubectl apply -k samples/deploy/crd/v1beta1/
➜  apisix-ingress-controller git:(master) ✗ kubectl apply -k samples/deploy/crd/v1beta1/
Warning: apiextensions.k8s.io/v1beta1 CustomResourceDefinition is deprecated in v1.16+, unavailable in v1.22+; use apiextensions.k8s.io/v1 CustomResourceDefinition
customresourcedefinition.apiextensions.k8s.io/apisixclusterconfigs.apisix.apache.org created
customresourcedefinition.apiextensions.k8s.io/apisixconsumers.apisix.apache.org created
customresourcedefinition.apiextensions.k8s.io/apisixroutes.apisix.apache.org created
customresourcedefinition.apiextensions.k8s.io/apisixtlses.apisix.apache.org created
customresourcedefinition.apiextensions.k8s.io/apisixupstreams.apisix.apache.org created

@tao12345666333 thx for your reply, i have executed this command

@tokers Hi, i apply all the CRDs, then execute kubectl apply -f httpbin-route.yaml again, it was successed, but when i
use kubectl exec -it -n ingress-apisix apisix-6b6cfdd678-gqrsx -- curl, it shown below info
Defaulted container "apisix" out of: apisix, wait-etcd (init)
curl: try 'curl --help' or 'curl --manual' for more information
command terminated with exit code 2

it is success to register route , thx all

@Marco-Zheng You're welcome.


Model estimation on a subset of subjects and sessions

I have preprocessed data, which have a list of subjects and sessions in the script:
% prep script
subj_list = {'sub-01','sub-02','sub-03','sub-04','sub-05','sub-06','sub-07','sub-08','sub-09','sub-11','sub-12','sub-13','sub-14','sub-19','sub-20','sub-21','sub-22','sub-23','sub-24','sub-25','sub-26','sub-27','sub-28','sub-29','sub-30','sub-31','sub-32','sub-33','sub-34','sub-35','sub-36','sub-37','sub-38','sub-39','sub-40','sub-41','sub-42','sub-43','sub-44','sub-45','sub-46','sub-47','sub-48','sub-49','sub-50','sub-51','sub-52','sub-53','sub-54','sub-55'};`
tasknames = {'discrA_run-01','discrA_run-02','discrA_run-03','discrB_run-01','discrB_run-02','discrB_run-03'};
for i = 1:size(tasknames,2)
    aap = aas_addsession(aap,tasknames{i});
end

Now I am trying to do a pipeline connection to do GLM (only GLM! No contrasts), on a specific subset of subjects and subset of sessions:
% GLM script
subj_list = {'sub-03','sub-04','sub-06','sub-11','sub-20','sub-21','sub-22','sub-23','sub-24','sub-25','sub-26','sub-27','sub-28','sub-29','sub-30','sub-33','sub-35','sub-36','sub-38','sub-39','sub-40','sub-47','sub-48','sub-49','sub-50','sub-51','sub-52','sub-53','sub-54','sub-55'};
tasknames = {'discrA_run-01','discrA_run-02','discrA_run-03'};
for i = 1:size(tasknames,2)
    aap = aas_addsession(aap,tasknames{i});
end

However, it skips some subjects:
MODULE aamod_firstlevel_model RUNNING: First level model for D:\studies\analysis\tamer_study3\Ipek\GLM_results\mvpa_button_press_A\aamod_firstlevel_model_00001\sub-03
WARNING: No inputs selected for stream epi. --> MODULE aamod_firstlevel_model will be SKIPPED

	 	 	 Elapsed time = 0h:0m:0s
	 	 	 ...at = 08:35:16 (26/3/2023)
MODULE aamod_firstlevel_model RUNNING: First level model for D:\studies\analysis\tamer_study3\Ipek\GLM_results\mvpa_button_press_A\aamod_firstlevel_model_00001\sub-04
WARNING: No inputs selected for stream epi. --> MODULE aamod_firstlevel_model will be SKIPPED

It doesn't skip sub-06.
You will notice that in the longer subj_list (prep) sub-03 is the third subject, however in the GLM list, it is the first.
nstead of iterating over the new subj_list, it iterates over the old one. So it goes like:
this is subj-01, and can not match the session name (discrA) so it skips it. Same story for sub-02. However when it comes to sub-03, it thinks that it is sub-06, which also does have that session (it is the third subject in the larger list) it starts processing it. But due to this skipping, subj-03 and sub-04 can not be processed. Since sub-06 is the third subject in the GLM script, and the third subject is a match in the prep script so it doesn't skip sub-06.
So basically, for some reason is stuck with the old subject list, so it tries matching indices based on the larger subject list.
I believe the issue may be related to some code here:
https://github.com/automaticanalysis/automaticanalysis/blob/f7849b18297c277e3603e06e35010a437520d2eb/aa_engine/aa_doprocessing_onetask.m#L156-L171

Just now It did occur to me that since all subjects belong to a specific block, I could do something like this:
Adding all subjects, but specifiying specific sessions.
subj_list = {'sub-01','sub-02','sub-03','sub-04','sub-05','sub-06','sub-07','sub-08','sub-09','sub-11','sub-12','sub-13','sub-14','sub-19','sub-20','sub-21','sub-22','sub-23','sub-24','sub-25','sub-26','sub-27','sub-28','sub-29','sub-30','sub-31','sub-32','sub-33','sub-34','sub-35','sub-36','sub-37','sub-38','sub-39','sub-40','sub-41','sub-42','sub-43','sub-44','sub-45','sub-46','sub-47','sub-48','sub-49','sub-50','sub-51','sub-52','sub-53','sub-54','sub-55'};
tasknames = {'discrA_run-01','discrA_run-02','discrA_run-03'};

Have you used debugging to see which remote data is looked for which local subject?
I.e., What is aas_doneflag_getpath_bydomain(sourceaap,inp.sourcedomain,deps{d}{2},sourcenumber)? Does it match with the local subject?

In my opinion, whatever is causing this issue is mainly because somewhere in aap the subject list is the remote subject list. So subjects who do not exist in the local list should be removed, and a new subject list must be formed.

Yes! Indeed, the remote subject list, which is stored in the (copied) remote aap, causes the issue. aa usually uses subject index rather than subject name as a reference, and the indices are obviously not the same. It is also true for the sessions; however, in your case, the indices are the same because you use the first 3 sessions, whose indices are the same in the remote aap.

To me, it looks fine.
It returns a struct with the field:
K>> map.subject
ans =
 3     4     6    10    15    16    17    18    19    20    21    22    23    24    25    28    30    31    33    34    35    42    43    44    45    46    47    48    49    50

And some other fields as well:

Where do I place this in aa_doprocessing_onetask? Not sure how to use these indexes.
It also returns a session index, the thing is I never had an issue with sessions but I will check that as well. (removing A sessions and trying to process only B sessions)

When forming a pipeline connection, Is the remote aap present anywhere in the current aap? Shall I write code so that the remote aap is loaded (similar to beforeuserchanges) to the aap structure if we are forming a pipeline connection?

It is sourceaap in https://github.com/automaticanalysis/automaticanalysis/blob/f7849b18297c277e3603e06e35010a437520d2eb/aa_engine/aa_doprocessing_onetask.m#L144

Hi Tibor, sorry for the late reply! I got caught up with some other things and left this hanging.
Back then when I tried your implementation, I saw that it was a little too complicated to implement so I had given up. Now again I stumbled upon the same issue and tried fixing it...
I can implement a fix for mapping subjects, which I think is very straightforward.
However, it looks like even if you update parts that are related to sessions in deps before these lines for the "remote" indices:
Assume the remote indices are 4,5,6 but in the local script they are 1,2,3. Here, you can sort them by mapping the indices.
https://github.com/automaticanalysis/automaticanalysis/blob/f7849b18297c277e3603e06e35010a437520d2eb/aa_engine/aa_doprocessing_onetask.m#L156-L165
Then they need to reverted to the "local" indices here: (1,2,3) because that is what is expected.
https://github.com/automaticanalysis/automaticanalysis/blob/e1796d20a222ebdfc843b4ae79b8b299f4738ff8/aa_engine/aas_retrieve_inputs_part1.m#L31
Because they are needed here:
https://github.com/automaticanalysis/automaticanalysis/blob/e1796d20a222ebdfc843b4ae79b8b299f4738ff8/aa_engine/aas_getpath_bydomain.m#L22
And also here:
https://github.com/automaticanalysis/automaticanalysis/blob/e1796d20a222ebdfc843b4ae79b8b299f4738ff8/aa_engine/aas_retrieve_inputs_part1.m#L68
The issue is, in later iterations of "aa_doprocessing_onetask", the deps{d} contains different domains, so checks must be added so that we don't accidentally index the array out of bounds.
I know it sounds complicated, and it is. I spent some good hours trying to figure out a way, but I can not see anyother way to fix this without refactoring all these functions somehow.

I am unsure I understand the issue:
As far as I understand you need two sets of remote indices: original and mapped-to-local. You need to use the original indices with the remote app and the mapped-to-local indices with the local aap.

I came up with a better solution. Will make a PR soon.


New Release Checklist - v1.7.0

Description
This issue is tracking steps to complete a release ensuring all artifacts are correctly produced. This covers both automated tasks and manual tasks.
Release
Manual steps are instructions that need to be taken in order to have a full release on all associated repos. Validation steps consist of checklist of items to verify, to ensure all reqiuirements and releases have gone without problems and that the correct assets are created needed for the manual steps.
Validation Steps

[ ] Builds complete successfully
[ ] Release actions complete successfully
[ ] Assets — ensure the following assets have been created by the release actions and are uploaded as assets in the release

[ ] Debian Package, named trinsic_X.X.0_amd64.deb
[ ] Trinsic CLI tarball (for Homebrew), named trinsic-cli-X.X.0.tar.gz
[ ] Trinsic CLI vendored tarball (for Homebrew), named trinsic-cli-vendor-X.X.0.tar.gz
[ ] Trinsic CLI Microsoft Installer (msi), name trinsic-cli-X.X.0.msi
[ ] Trinsic Java/Kotlin (jar), name trinsic-services-X.X.0.jar

[ ] Package Releases — validate if packages have been correctly released

[ ] golang tag (go/vX.X.0)
[ ] nuget.org
[ ] npmjs.com
[ ] pypi.org
[ ] rubygems.org
[ ] pub.dev (Dart)

Manual Steps

[ ] Github Release — create a new release following the semantic versioning guidelines. The next available version should increase either the Major or Minor version, following the semver recommendations. Patch should be set to 0. This allows individual languages to publish hotfixes under the same version with new patch. An example version format is v1.2.0.

[ ] Ensure code contributions and commits are included in the release description, either by utilizing the GitHub automatic options or entering them manually.

[ ] Swift Release — create new release in associated repository for Swift package at trinsic-id/sdk-swift. The release version in this repo follows a pattern that doesn't include leading v. Example release format is 1.2.0.
[ ] External Tools

[ ] Homebrew — to create a new tap, follow the instructions at trinsic-id/homebrew-tap by making a new PR with the required information. This step depends on a release asset package.
[ ] Windows Package Manager (winget) — Update PR to the yaml here: https://github.com/microsoft/winget-pkgs/tree/master/manifests/t/trinsic/cli/
[ ] NixOS — TODO: Add details

[ ] Samples — if required, code samples at https://github.com/trinsic-id/sdk-examples should be updated to match the version
[ ] Release announced to Trinsic Team

Breaking Changes

WalletService.search is now WalletService.searchWallet, compile time change for sane defaults separated from generated code.

Is the breaking change necessary? Can we deprecate it and remove it after few versions?

What's the status of this? I checked some package repo's but doesn't seem 1.7.0 was released last Friday?

What's the status of this? I checked some package repo's but doesn't seem 1.7.0 was released last Friday?

My plan is to release it today. I had a question into TM that I didn't get an answer to in time and I didn't want to release last thing on Friday evening.

https://github.com/trinsic-id/homebrew-tap/pull/27 <- homebrew
https://github.com/microsoft/winget-pkgs/pull/68381 <- winget

Fixed the rubygems MFA push situation, will need to monitor next release for this failure:
Rubygem requires owners to enable MFA. You must enable MFA before pushing new version.
If we get it, I can manually push the release.

Swift SDK updated to 1.7.0


Update price.js

added malaysian ringgit , @filipnyquist please review my friends

@filipnyquist is this good to go now?

I'll take a closer look now

@tzarebczan and @filipnyquist thanks you so much for merge my PR


Disable shutdown by default

Disable shutdown by default, due DO now not requires it.

Closed by: b25366096cdbbe447f4aaad829b7001ceafa7644


Button stories added

storybook-addon-pseudo-states and @storybook/testing-library installed.
Button stories added.
Button types reviewed and comments added to them.
Added white-space: nowrap to solve this problem:

After adding white-space: nowrap:

Added ThemeProvider to the configuration for stories.

Test comment


2016 RX350 F Sport corrections

This fixes the botched PR I did yesterday...
https://github.com/commaai/openpilot/pull/1671
Accidentally used CAR.LEXUS_RXH_TSS2 firmware from my clipboard yesterday, instead of @gweedor#9653's...  Today I was extra careful ;-)
@gweedor#9653 DongleID 28f8c941d8b28743

Confirmed working!

Hi. I just installed my Comma2 today on my 2017 Lexus RX 350 F Sport, paired the app on my phone, and did a few test drives.  The screen shows the forward camera view well and depicts the white lane lines, white path, and multi-color lead car triangles, but there is no white steering wheel icon and the upper left always shows MAX N/A.  Vehicle speed is correct.  When I engage cruise control, the car's adaptive cruise control engages instead of OP.  Curiously, there was no "calibration period" during the initial drive like I observed on some YouTube videos.  OpenPilot software is installed and not dashcam; 2) Physically reseating all connections to ensure a tight fit; 3) Rebooting the device; 4) Checking for error messages on car and device (none); 5) Toggling "Enable Openpilot" and re-acknowledging disclaimers and completing training again; 6) Trying various car settings options for Lane Keep and Adaptive Cruise to see if that made a difference (it didn't).  Not sure what to try next.  I read you post on Discord for Ottopilot and it seemed like you solved his issue. Would you be abe to help with mine? Thank you kindly in advance.

Post FPv2 output in Discord, as seen in all the other situations.

Thank you for your response, but what does that mean? I am not an engineer.

FPv2 cmd. is pinned in the Comma Discord #toyota-lexus channel.

Actually...I do not know what FPv2 means

https://github.com/commaai/openpilot/wiki/Fingerprinting

OK. Thank you. I will try. I may have to return the Comma 2 it because the bottom part of the Fingerprint seems a bit over my head. But I will upload my drive and try. Thank you again. Have a good weekend. Donald

Just out of curiosity, why does the C2 need to be fingerprinted for a 2017 Lexus RX350 when the Comma 2 website states it is compatible with Lexus RX 2016-2017?

Various firmwares.

OK. Thank you


removed huge error when kick the disabled job ref T64087

Two issues with this fix: 1) it assumes that job kick may fail only because the job is disabled. That is not true. 2) This does not address the case where a user kicks a disabled job from the job details screen.
The right fix requires more than a simple change of the error message in the front end. Please review sever side code in JobsResource.startJob, then we can pair to figure out the right approach.

@satang500 please close this PR


[BUG] - Version mismatch of ts-luxon

NOTE
Describe the bug
With Version 5.1.3 the ts-luxon version in the main package.json has been updated to ^4.2.1 ( https://github.com/tonysamperi/ngx-mat-timepicker/blob/master/package.json#L52 )
But in the package.json of the package that will be used for the npm package ngx-mat-picker it is still ^3.0.1 ( https://github.com/tonysamperi/ngx-mat-timepicker/blob/master/projects/ngx-mat-timepicker/package.json#L27 ), is that on purpose?
Additional context (optional)
The problem is, that we use Angular 15 with your package @ngx-tonysamperi/ts-luxon-date-adapter which uses also ^4.0.1 as peerDependency.
When we want to use the libraries together this leads to errors because of different versions of ts-luxon and incompatibilities of the DateTime classes / instances.

By the way, no. It's not on purpose. I need to see the history again, because I clearly remember that I wanted ts-luxon v4 with picker v15.
I'll have to fix this

Fixed in v 15.1.7


Add test:compat to CI

Related: https://github.com/microsoft/botbuilder-js/pull/3628#discussion_r621500935
Looks like it hasn't been updated in awhile, so it needs to be updated and also added to CI so that it stays up-to-date.

I think test:compat is a command across many packages. Perhaps it can be extracted to the root package.json file and run across all packages? The CI job ought to operate just like the test:schemas command in that it should run the command and fail if there's a diff detected.

@joshgummersall Will do!


But this system with furnaces work fine.

Try update to the latest version.

I just test that issue on 4.7.2

Does the player have Builder's job? In the jobConfig.yml file, is there a block type in the Place method that is Brewing_Stand?

Nothing of that, I don't use the Builder's job

I'll test it and, if that's what it is, we'll try to fix it. If it works properly, it may take time.


iPhoneX SafeArea regression fix

Details
Fixed my regression on iPhoneX SafeArea
Fixed Issues

$ https://github.com/Expensify/App/issues/6530
$ https://github.com/Expensify/App/issues/5926
Tests

QA Steps

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

cc @parasharrajat @Julesssss

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @Julesssss in version: 1.1.17-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.1.18-3 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Only one Person should able to sign even though we could have multiple signers in the validatorset

types/validation.go

if len(h.Commit.Signatures) != len(h.Validators.Validators) {
		return errors.New("number of signatures and keys don't match")

This code breaks if you only have 1 signature but multiple validator keys.
We will have multiple sequencers schemes, so ideally, validation should hook into FCR Interface at some point.
Comment by @gupadhyaya :

this has to be handled by the staking module which keeps the set of allowed signers, their public keys, and then also defines the threshold for acceptance and we can simply make a call to the staking module to return boolean. this does not matter right now as we are setting the signer (single) and his public key in the signer header before gossip. so this condition will always hold. we can keep it this way for now?

Closed by https://github.com/rollkit/rollkit/pull/1301


Gemspec: Description grammar

This PR fixes copy-editing on the Description in the gemspec.

Thanks!


Print VFS name in error

I was getting VFS '[object Object]' already registered, which was relatively uninformative.
(Nuking my repo via git clean -xdf fixed the issue - not sure what the real problem was. Probably something got cached.)

In order to preserve licensing rights, this repository generally does
not accept unsolicited pull requests.

Bugs should be filed to Issues.
New features should be proposed in Discussions.
New extensions (modules and virtual filesystems) are encouraged to get their own repo.

Thanks!

Yeah, I'm aware, but felt like this was the best way to submit feedback. Feel free to close/not accept or whatever.

Merged.


GetBlobResponse produces error: CoreError(HeaderNotFound(\"content-range\"))")

I received this error while upgrading to the latest version of master today.
I think it is caused by https://github.com/Azure/azure-sdk-for-rust/blob/master/sdk/storage/src/blob/blob/responses/get_blob_response.rs#L33
Where we we are always expecting this header to be present but I think this is only true if the request has requested a subset of the blob

Probably related to https://github.com/Azure/azure-sdk-for-rust/pull/253

I've attempted my own fix at https://github.com/Azure/azure-sdk-for-rust/pull/268


Dumping dead by daylight

anti easy cheat is in the way , but to get access to the files you must dump it
well anti easy cheat i guess isn't in the way just can't dump it

If it is failing at the remote memory allocation step, then the application is not being allowed to remotely interface with the target process. Either through easy anti cheat or some other protection method.
Something to try though, if you aren't already doing it, is to be sure to run UWPDumper with administrator-privilege.

turns out IO bit can copy the files lets see if it works

It sounds like the executable itself is protecting against remote process allocations and is unable to be injected into. It blocks the initial remote memory allocation which gets the process to spawn the correct thread and inject the right DLL.
https://github.com/Wunkolo/UWPDumper/blob/c29e9d654d8743049ecc082ba8a414731f727a6e/UWPInjector/source/main.cpp#L516-L531
Each game has has the potential to have its own protection against remote process injection and I simply cannot account for them all.

it must be very protected . in linux the whole folder is gone. you can copy most of the files but the exes

i have been having this issue also


fix: cli codegen for idls generated for rust native

so i wanted to fix mpl-token-metadata decoder, but got lazy and thought of actually fixing the cli that generated wrong discriminators.
i am not aware of the way idl generation for rust native contracts works, but i think i managed to make the cli work.
pls review, i tested on the mpl-token-metadata idl and it seems to work

@KellianDev also one think, we should parse instruction/structs names in codegen with a check if it's a keyword or not.
For instance in the provided idl, there is a use instruction, which is a keyword in rust and fails to compile


Compile errors in VCS

There will be 6 compile errors when running the riscv_vip in VCS even in the latest release version.
Error-[NYI] Not Yet Implemented
instruction.svh, 254
  Feature is not yet supported: expression other than coverpoint label as
  coverpoint bin value.

   i32s_insts_cp : coverpoint inst {
      bins s_insts[] = S_INSTS;
   }

I put all the stuffs at (https://www.edaplayground.com/x/5reM).  Cheers!

Thanks @kencycheng for reporting this.  Unfortunately I don't currently have a license for VCS. I do ensure it works with Mentor Questa and Cadence IUS and regress with these.  I'll see what I can do to get this working with VCS via EDA playground.  If anyone has VCS licenses and has patches / pull requests for modifications to support VCS that would be great.

I took a try to replace the dynamic array S_INSTS by {SB, SH, SW}. It works.
  i32s_insts_cp : coverpoint inst {       bins s_insts[] = S_INSTS;    }
 i32s_insts_cp : coverpoint inst {       bins s_insts[] = {SB, SH, SW};  }

Thanks @kencycheng for this VCS workaround to incorporate.
Feel free to send pull requests for any VCS workarounds.  I had a look at your EDAplayground example but need to get setup there to run, which I do plan to do.

I new to Github. When I tried to create a new pull request. The Github desktop says "Your branch must be published before opening a pull request". It seems to me that I can not publish my branch and compare. Do you have any idea about that?
Thanks!

This is fixed now in master as of 473e8657d70b2262b4e7f5b3769e8396bed29ade
I used your recommend technique to fix, @kencycheng; however, I inserted a layer of `defines to allow the enum and bins to be defined from the same single source.


vscode doesn't respect terminal selection related to "The terminal process command 'C:\WINDOWS\System32\cmd.exe' failed to launch (exit code: 1)"

Issue Type: Bug
Trying to run a cmake project with "CMake: Execute the current target without a debugger" and I get the "The terminal process command 'C:\WINDOWS\System32\cmd.exe' failed to launch (exit code: 1)" error.
I've tried reinstalling vscode, nuking but the settings, and extensions.
I've tried changing "terminal.external.windowsExec" and "terminal.integrated.shell.windows" to all the options.  The integrated shell will change but the execution value is absolutely ignored for execution, the error message is always reported 'C:\WINDOWS\System32\cmd.exe' instead of the configured terminal.
"CMake: debug target" works fine.  I've checked out the other related bug reports, which don't seem to solve my issue, but also seem to indicate they are able to change the execution terminal.
https://github.com/Microsoft/vscode/issues/45693
https://github.com/Microsoft/vscode/issues/64449
https://github.com/Microsoft/vscode/issues/20100
https://github.com/Microsoft/vscode/issues/20858
https://github.com/Microsoft/vscode/issues/66867
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 3192)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.81GB (18.39GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

cpptools
ms-
0.22.1

cmake-tools
vec
1.1.3

You might want to report against cmake-tools, whatever it's running in the terminal is exiting with an exit code of 1. You can find out what it's launching which might be useful to them by enabling debug logging move (F1, "log level", "debug") then launching a terminal and viewing the devtools console (Help > Toggle Developer Tools, console). You should see something like this:


Thinkpad X1 yoga gen 3

Model
Thinkpad X1 yoga gen 3

Patchset
xx80

TPM
Yes, hexedit

I am having trouble with this rimby@rimby-ThinkPad-X1-Yoga-3rd:~/Downloads/UEFIPatch_0.25.0_linux_x86_64$ ./UEFIPatch /home/rimby/LenovoCFG/N25ET61W/firmware.bin /home/rimby/Downloads/LenovoPatch.txt -o  /home/rimby/LenovoCFG/N25ET61W/firmwareAdvanced.bin  parseVolume: unknown file system 00504624-8A59-4EEB-BD0F-6B36E96128E0 parseVolume: unknown file system FFF12B8D-7696-4C8B-A985-2747075B4F50 parseBios: one of volumes inside overlaps the end of data parseFile: non-empty pad-file contents will be destroyed after volume modifications Function called with invalid parameter rimby@rimby-ThinkPad-X1-Yoga-3rd:~/Downloads/UEFIPatch_0.25.0_linux_x86_64$

I too get those warnings but the patch continues fine after the parseFile warning
parseVolume: unknown file system 00504624-8A59-4EEB-BD0F-6B36E96128E0 parseVolume: unknown file system FFF12B8D-7696-4C8B-A985-2747075B4F50 parseBios: one of volumes inside overlaps the end of data parseFile: non-empty pad-file contents will be destroyed after volume modifications patch: replaced 16 bytes at offset 118D0h 04320B483CC2E14ABB16A73FADDA475F -> 778B1D826D24964E8E103467D56AB1BA patch: replaced 28 bytes at offset 6B8BEh 09072C1300000209072D1300000309072E1300000409072F13000005 -> 09072C1300001909072D1300001A09072E1300001B09072F1300001C patch: replaced 58 bytes at offset 53C04h<PHONE_NUMBER>0030004D0068007A000000143100350030004D0068007A000000143200300030004D0068007A000000143200350030004D0068007A -><PHONE_NUMBER>0035003000200020000000143100330030003000200020000000143100330035003000200020000000143100340030003000200020 patch: replaced 26 bytes at offset 69E91h 0A821286A10B04001206A60B010016021206A60B020016022902 -> 0A821286A10B04001206A60B000016021206A60B000016022902 patch: replaced 11 bytes at offset 545h 0BC8394B040F8437020000 -> 0BC8394B04E93802000000 patch: replaced 5 bytes at offset 535h C8390B7516 -> C8390B7500 Image patched
Not sure where that Function called with invalid param came from

I am only trying to enable the Advanced BIOS menu. I updated as i was on 0.25.0 and i got the same result. I want to say it might be the firmware file but we both have the same firmware file. Just to make sure, the first file (for the BIOS not the controller) is N25ET61W.

I too get those warnings but the patch continues fine after the parseFile warning
parseVolume: unknown file system 00504624-8A59-4EEB-BD0F-6B36E96128E0 parseVolume: unknown file system FFF12B8D-7696-4C8B-A985-2747075B4F50 parseBios: one of volumes inside overlaps the end of data parseFile: non-empty pad-file contents will be destroyed after volume modifications patch: replaced 16 bytes at offset 118D0h 04320B483CC2E14ABB16A73FADDA475F -> 778B1D826D24964E8E103467D56AB1BA patch: replaced 28 bytes at offset 6B8BEh 09072C1300000209072D1300000309072E1300000409072F13000005 -> 09072C1300001909072D1300001A09072E1300001B09072F1300001C patch: replaced 58 bytes at offset 53C04h<PHONE_NUMBER>0030004D0068007A000000143100350030004D0068007A000000143200300030004D0068007A000000143200350030004D0068007A -><PHONE_NUMBER>0035003000200020000000143100330030003000200020000000143100330035003000200020000000143100340030003000200020 patch: replaced 26 bytes at offset 69E91h 0A821286A10B04001206A60B010016021206A60B020016022902 -> 0A821286A10B04001206A60B000016021206A60B000016022902 patch: replaced 11 bytes at offset 545h 0BC8394B040F8437020000 -> 0BC8394B04E93802000000 patch: replaced 5 bytes at offset 535h C8390B7516 -> C8390B7500 Image patched
Not sure where that Function called with invalid param came from maybe try with newer uefipatch? I think I used 0.28.0

I am only trying to enable the Advanced BIOS menu. I updated as i was on 0.25.0 and i got the same result. I want to say it might be the firmware file but we both have the same firmware file. Just to make sure, the first file (for the BIOS not the controller) is N25ET61W

I believe the error is not patch related. Try cleaning up the parameter a bit or I could try patching your dump for you

I believe the error is not patch related. Try cleaning up the parameter a bit or I could try patching your dump for you

I don't see a way to clean it up as it is so simple but i have uploaded the files to google drive. Most of the files are self explanatory however i also put in a .sct file which contains where the cfg lock is. My goal out of this is to disable it using the advanced menu.

Oh there is a cfg lock option in the advanced bios. I remember seeing it one moment pls

ah you've un-commented line #27 of your patchfile which was causing the issue. you should be able to patch if you comment line #27. Here's the patched bin anyways oh and make sure to hex edit the tpm thing firmware.bin.zip

May i ask what you used to patch the bios?

ueftpatch 0.28.0 with your patchfile with line#27 commented out

ueftpatch 0.28.0 with your patchfile with line#27 commented out

Pardon my wording, I meant to update the BIOS to the custom .bin.

oh. lol. uhh i used ch341a spi flasher

oh. lol. uhh i used ch341a spi flasher

Wow that is a lot more involved than i thought. I was under the belief that we could put it on a usb drive and use an updater. Maybe fwupd is the answer here.

to my short knowledge thinkpad bioses are somehow temper protected and needs to be patched physically using spi flasher

The updater part of the UEFI rejects any deployed package that is invalid. Either modified or corrupt from a bad download.

to my short knowledge thinkpad bioses are somehow temper protected and needs to be patched physically using spi flasher

Completly unrelated but have you made a hackintosh with your X1 yoga?

no

ah you've un-commented line #27 of your patchfile which was causing the issue. you should be able to patch if you comment line #27. Here's the patched bin anyways oh and make sure to hex edit the tpm thing firmware.bin.zip

Any hint, info or heads-up on "hex editing" the TPM on the X1Y3 would be much appreciated.
I assume Fingerprint still works then with the patched Bios?
Were you able/did you try to use a different WWAN than the Fibocom (Quectel EM120R-GL or Qualcomm Snapdragon X55 5G)?

Did you simply replace 4C 4E 56 42 42 53 45 43 FB with 4C 4E 56 42 42 53 45 43 FF to get the TPM working?

yes

I assume Fingerprint still works then with the patched Bios?

yes

Were you able/did you try to use a different WWAN than the Fibocom (Quectel EM120R-GL or Qualcomm Snapdragon X55 5G)?

I did not have any other module than L850 at the time but it was not whitelisted part, so I'd assume whitelist removal worked fine.

Did you try the patch on the latest 1.48 Bios?

I belive it was 1.46 or 1.47. I do not have the device on hand anymore.

Did you simply replace 4C 4E 56 42 42 53 45 43 FB with 4C 4E 56 42 42 53 45 43 FF to get the TPM working?

yes

I assume Fingerprint still works then with the patched Bios?

yes

Were you able/did you try to use a different WWAN than the Fibocom (Quectel EM120R-GL or Qualcomm Snapdragon X55 5G)?

I did not have any other module than L850 at the time but it was not whitelisted part, so I'd assume whitelist removal worked fine.

Did you try the patch on the latest 1.48 Bios?

I belive it was 1.46 or 1.47. I do not have the device on hand anymore.

The newest could have been 1.47 at the time of your post. I assume the patch is working on all bios versions then.
Will report back on WWAN whitelist as soon as I got my hands on a Quectel EM120R-GL.
Thanks so much!

to my short knowledge thinkpad bioses are somehow temper protected and needs to be patched physically using spi flasher

Completly unrelated but have you made a hackintosh with your X1 yoga?

Neither did I but as starters you could have a look here:
https://github.com/Jamesxxx1997/thinkpad-x1-yoga-2018-hackintosh
https://github.com/tylernguyen/x1c6-hackintosh


Bump up version to support laravel 9

Bumped up the version for illuminate and mangopay php sdk.
I tested adding mango users, credit cards, bank accounts, payins, transfers, payouts, kyc documents. Seems to be all and well.

Laravel 9 went already through, didn't see, my bad.


Add a front-end for writing the blog posts

I wanted to stay away from this because it's going to be a big lift.
BUT
I really want a datepicker & a way to manage images. So... here we are... attempting to build a CMS.

We could use the Github API to write to our repo: https://docs.github.com/en/rest/reference/repos#create-or-update-file-contents


How long does it take in general for you to upgrade to the newest Puppeteer (2.1.1)?

Hi @kblok , I just investigating the possibility to use puppeteer-sharp in my project to replace selenium. I just want to ask in general, how long does it take you to catch up with the newest version of Puppeteer ?

Hey @ngiakhanh my focus is on https://github.com/kblok/playwright-sharp right now.
I would eventually work on 2.1.1 but I don't think it would be in the first half of 2020 (unless it gets sponsored).


"Anomalous backslash in string: '-'" in extract.py

pylint is complaining that an "Anomalous backslash in string: '-'"
The string constant might be missing an 'r' prefix.

Thanks!


Create github action to run app.py file to create and save graph, after new traffic has been pulled

I have appended to the workflow/traffic.yml which will run the app.py file which creates and saves the graphs. They are then committed and pushed to the traffic branch


Update README.md (llvm 3.7)

(OSX)

I think it should go with pure llvm37 on OSX. No need to build it from source.

Agreed, @chfast.
That's what I got working for eth.    So much better.

Thanks!


When is support for jest 28.0.0 coming?

Currently, this repo only supports jest 24.7.1

the latest jest version is 24.8

Inside the package-lock.json:
"@jest/environment": {
      "version": "24.8.0",

    "jest-resolve": {
      "version": "24.8.0",

"@jest/test-result": {
      "version": "24.8.0",

It's already supports latest version

Yep, thanks for checking.

This is the error I get with jest 28.0.0
There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.

The react-scripts package provided by Create React App requires a dependency:

  "jest": "24.7.1"

Don't try to install it manually: your package manager does it automatically.
However, a different version of jest was detected higher up in the tree:

  /active/dev/react-native/example/node_modules/jest (version: 24.8.0)

Manually installing incompatible versions is known to cause hard-to-debug issues.

If you would prefer to ignore this check, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That will permanently disable this message but you might encounter other issues.

To fix the dependency tree, try following the steps below in the exact order:

  1. Delete package-lock.json (not package.json!) and/or yarn.lock in your project folder.
  2. Delete node_modules in your project folder.
  3. Remove "jest" from dependencies and/or devDependencies in the package.json file in your project folder.
  4. Run npm install or yarn, depending on the package manager you use.

In most cases, this should be enough to fix the problem.
If this has not helped, there are a few other things you can try:

  5. If you used npm, install yarn (http://yarnpkg.com/) and repeat the above steps with it instead.
     This may help because npm has known issues with package hoisting which may get resolved in future versions.

  6. Check if /active/dev/react-native/example/node_modules/jest is outside your project directory.
     For example, you might have accidentally installed something in your home folder.

  7. Try running npm ls jest in your project folder.
     This will tell you which other package (apart from the expected react-scripts) installed jest.

If nothing else helps, add SKIP_PREFLIGHT_CHECK=true to an .env file in your project.
That would permanently disable this preflight check in case you want to proceed anyway.

P.S. We know this message is long but please read the steps above :-) We hope you find them helpful!

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

We regularly update dependency versions in our releases, but until a new version is released please use jest 24.7.1 or turn onn SKIP_PREFLIGHT_CHECK.

Solved it by removing  "jest": "24.8.0" from my package.json. My repo now pulls the jest version correctly.
Thank you!


showing hostname of ssh'd box machine

Is there any possibility the hostname to switch between local machine and other ssh'd boxes. This would be useful to keep track in which box you are ssh'd. How can we configure something like that for the powerline theme?

Let me try to understand the requirement - is this accurate?

You run Bash-it with the "powerline" theme on your local machine. It shows your local hostname (e.g. kirk) as part of the theme.
You ssh into a remote server/VM (e.g. spock). On the remote VM, Bash-it is also installed as part of your Bash configuration, also using the "powerline" theme. In this case, it should show the remote hostname (spock), since Bash-it is running on the remote server.

This is the way it works for me, when I have Bash-it on both my local machine and the remote machine. Is this the way you're using this? And are you saying this is not working?
Sorry if I missed something...

Sorry, can't help with this. In the case you describe, how/where do run the Bash shell in this case? If you ssh into a remote machine, isn't that where the shell runs?

If you ssh into a remote machine, isn't that where the shell runs?

Yup, that's where the shell runs, that's why I said that I've seen it work with ssh -i .... cause you can get a shell that way and query for the hostname but not with pass since it requires interaction from user. Thought maybe you'd seen sth similar, but it's ok, thanks?

No, sorry - never used it like that before.


Make SaveModule.py public

Description
Make SaveModule.py module public and place it at the same level as LoadModule.py
Checklist:

[x] Have you added tests that prove your fix is effective or that this feature works?
[x] Has code been commented, particularly in hard-to-understand areas?

@kwen2501 @wz337


Recursive collectiontype

I created a Content Type "menu" in order to make my menu in the backend.
However, each menu level is a collection (and can thus be nested).
But the info is not send in a nested way to elasticsearch.
The content type configuration:
menu-test.json.txt
I should have (pseudo json):
Root: "menu name"
Level 1: [
  {Name: "Level 1.1 item",
   Level 2: [ {Name: "Level 2.1 item" } ]}

  {Name: "level 1.2 item"}
]

But instead I get:
Root: "menu name"
Level 1: [
  {Name: "Level 2.1 item",
   Level 2: [ ]}

  {Name: "level 1.2 item"}
]

It has been fixed with the release 1.6


Add data inflation feature using pako library

This pull request adds a new feature to the vscode plugin that allows the user to inflate compressed binary data using the pako library. The changes include importing the pako library in the dataread.ts file, adding a new function inflateData() to inflate the data buffer, and writing a test case for the new function. This feature enhances the plugin's functionality and provides a better user experience for viewing compressed binary files.

Do you have an example project (parser and file) which shows how it works?
Can one use the inflateData only on the complete file or also on parts.
I'm thinking of a container file format that contains a few zipped data.
How is the packing algorithm (that should be used) determined?

hi @maziac thanks for your reply!
I'm using this parser: https://gist.github.com/Beim/f1b2f6e3c8936ebfa1f32dc5314726e4
and this file to parse: 15574018f85f4108a6eaadf36a3620412af8d1
The file format is from git object database

Can one use the inflateData only on the complete file or also on parts.

At the moment, the inflateData function is only used on the complete file and not on specific parts.

I'm thinking of a container file format that contains a few zipped data.

Could you please share an example of the container file you are considering?

How is the packing algorithm (that should be used) determined?

I used pako because it inflates same as zlib

I think the functionality in this PR is too specific.
To consider it to be integrated I would like to

have the decompression work on only part of the file
have a possibility to choose between different decompression methods.

Probably it's best that you use your own fork for your changes.
Anyway, thanks for contributing.

Yea I agree it's a specific use case, I'll use my own fork. Thanks for your time~


Add ecmaVersion and sourceType to options

Add ecmaVersion and sourceType to options, with their sensible defaults.
These two options are used by escope to support ES Modules syntax
refs power-assert-js/espower-source#15

Coverage increased (+0.02%) to 97.778% when pulling 069ab9899c6020a5c98aad1ac42791464592ee5d on escope-options into ca27989baa008c46c21a6114b444d1bb93cc6e0d on master.

Coverage increased (+0.02%) to 97.778% when pulling f574e8efe39ea0ffd9d995269f7d57e43c0d5dc1 on escope-options into ca27989baa008c46c21a6114b444d1bb93cc6e0d on master.


[fix][broker] Fix rare race condition in removing topic watcher

Motivation
While reviewing code in org.apache.pulsar.broker.service.TopicListService#deleteTopicListWatcher, a race condition was detected.
https://github.com/apache/pulsar/blob/9aed73653e1f706e3517072cce4a352d0838f8d7/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicListService.java#L231-L261
Modifications

replace usage of .getNow(null) with .thenApply(watcher -> ... to prevent a rare race condition.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

most likely not possible because of https://github.com/apache/pulsar/blob/9aed73653e1f706e3517072cce4a352d0838f8d7/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/TopicListService.java#L239-L240


New login issue

Looks like the login page has changed. My pull request added form id and thing however it is still not working. Do you have any idea?

Hi,
a couple of days ago stopped working and I already fix it adding the missing headers with this commit.
Can you check if is the same issue?

@windhamwong Do you still have the error or is working now?
Thanks

@windhamwong since I've received no answer I will close the issue


Where is the best place to merge different entities?

So, imagine that you need to complement the application. Add new entities and add list of pets to user details screen.
I think that the User presentation model should contain a list of pets.
public class UserModel {

  private int userId;

  private String fullname;

  private List<Pet> pets;

  public int getUserId() {
    return userId;
  }

  public void setUserId(int userId) {
    this.userId = userId;
  }

  public String getFullname() {
    return fullname;
  }

  public void setFullname(String fullname) {
    this.fullname = fullname;
  }

  public List<Pet> getPets() {
    return pets;
  }

  public void setPets(List<Pet> pets) {
    this.pets = pets;
  }

  ...

}

The question is, where should I add a list of pets to the user?
Option 1. In interactor.
Then you need to change the domain model. I'll add a list of pets into the domain model to be able to returns the pets.
public class GetUserDetails extends UseCase {

    private final int userId;
    private final UserRepository userRepository;
    private final PetRepository petRepository;

    @Inject
    public GetUserDetails(int userId, UserRepository userRepository, PetRepository petRepository
                          ThreadExecutor threadExecutor, PostExecutionThread postExecutionThread) {
        super(threadExecutor, postExecutionThread);
        this.userId = userId;
        this.userRepository = userRepository;
        this.petRepository = petRepository;
    }

    @Override
    protected Observable buildUseCaseObservable() {
        return Observable.zip(this.userRepository.user(this.userId),
                              this.petRepository.pets(this.userId),
                              new Func2<User, List<Pet>, User>() {
                                  @Override
                                  public User call(User user, List<Pet> pets) {
                                      user.setPets(pets);
                                      return user;
                                  }
                          });
    }
}

Option 2. In presenter.
Interactors can return observable and not to accept subscribers. Then you can add list of pets to user model in presenter. The domain model will not change.
@PerActivity
public class UserDetailsPresenter implements Presenter {

  /** id used to retrieve user details */
  private int userId;

  private UserDetailsView viewDetailsView;

  private final UseCase getUserDetailsUseCase;
  private final UseCase getPetListUseCase;
  private final UserModelDataMapper userModelDataMapper;

  @Inject
  public UserDetailsPresenter(@Named("userDetails") UseCase getUserDetailsUseCase,
	                                      @Named("petList") UseCase getPetListUseCase,
                                             UserModelDataMapper userModelDataMapper) {
    this.getUserDetailsUseCase = getUserDetailsUseCase;
    this.getPetListUseCase = getPetListUseCase;
    this.userModelDataMapper = userModelDataMapper;
  }

  private void getUserDetails() {

    Observable<UserModel> user = this.getUserDetailsUseCase
									 .execute()
									 .map(new Func1<User, UserModel>() {
												@Override
												public UserModel call(User user) {
													return this.userModelDataMapper.transform(user);
												}
    								});
	Observable<List<Pet>> pets = this.getPetListUseCase.execute();

	Observable.zip(user,
                   pets,
				   new Func2<UserModel, List<Pet>, UserModel>() {
						@Override
						public UserModel call(UserModel user, List<Pet> pets) {
							user.setPets(pets);
							return user;
						}
					})
					.subscribe(new UserDetailsSubscriber());
  }

  @RxLogSubscriber
  private final class UserDetailsSubscriber extends DefaultSubscriber<UserModel> {

    @Override public void onCompleted() {
      UserDetailsPresenter.this.hideViewLoading();
    }

    @Override public void onError(Throwable e) {
      UserDetailsPresenter.this.hideViewLoading();
      UserDetailsPresenter.this.showErrorMessage(new DefaultErrorBundle((Exception) e));
      UserDetailsPresenter.this.showViewRetry();
    }

    @Override public void onNext(UserModel user) {
      UserDetailsPresenter.this.showUserDetailsInView(user);
    }
  }
}

Please advise which option is best? Thank!

I'd wager to say this depends on your definition of a "User" in your app. Either you define that a User can always have 0 or more pets, and you can use that everywhere. Or you can define that there is a relation between User and Pet, but this is not used everywhere in the app, and thus not a core part for the User.
In the first case, you wouldn't have a PetRepository, and since Pets are directly linked to User, they are saved and loaded directly with the User.
The second case is what you are doing. The User has the option to define his Pets, but this is not integral  for the architecture of a User. I advise against using 2 Use Cases and merging those in the Presenter. A Presenter is only the glue between the View and the UseCases. There shouldn't be any business logic in the Presenter. Image if would have 4 different Presenters where you'd want to get the User and his Pets, you'd have to write this Observable zipping 4 times. You should always try to write a Use Case for, well, every Use Case you have. There should be a Use Case for "Get a User with his selected Pets". And a separate one for "Get a User". And one for "Get all possible Pets", to build a selection list, and so on.
I'd with option 1, but write it as a separate GetUserWithHisPetsUseCase.

Thanks for the detailed answer. I am also inclined to option 1. The only thing that bothered is Pets is not integral for a User, but I need add Pets to User domain model. Now I understand that Pets is part of a domain, that's normally.


Custom Timeout

The default timeout of Proxy Hosts seems to be 1 Minute, wich is pretty short, so i would like to change the timeout without having to use a Custom Nginx Configuration.
Describe the solution you'd like
A input field in the Web Interface to change the timeout per Proxy Host.
It should probably set following nginx configuration parameters:

proxy_connect_timeout
proxy_send_timeout
proxy_read_timeout
send_timeout

Additional context

Def need this.. so many things i reverse proxy need a much longer timeout.. Anything to do with Docker usually takes more than a minute to build a container and NPM causes it to bail out.

Maybe i will do a PR for this Feature at some point, but i currently don't have enough time

I really need that 👍  Hope you get around to it sometime!

+1

Would like to see that too! Good feature request!

Would like to see that too! Good feature request!

+1.
Is there a workaround in the meantime?

+1.
Is there a workaround in the meantime?

+1

+1
Has anyone figured out a workaround?

+1

The "workaround" is: just add the parameter you want to change to the advanced config field. If you want to change the proxy timeout, set the corresponding proxy timeout variables.
I am using the following line of advanced custom config to prevent console disconnects in Portainer:
proxy_read_timeout 30m;

@mriksman It worked for me as well, with timeouts in the portainer console. Maybe whatever app you proxy has some internal timeouts which expire independent of whether the proxy connection is kept open?
Oh and @JonathanTreffler, why is it exactly that you want this feature without the custom nginx configuration? That's exactly what the custom config is for.

did you ever find a solution to cloudflare timeout

The "workaround" is: just add the parameter you want to change to the advanced config field. If you want to change the proxy timeout, set the corresponding proxy timeout variables.
I am using the following line of advanced custom config to prevent console disconnects in Portainer:
proxy_read_timeout 30m;

How to do it? Can tutorial for me do this? tks

+1

+1

Bump. This would still be a very nice feature to have.

Instead of having a proxy_read_timeout for the whole site, could this be better:
location ~* /#!/1/docker/containers/[a-f0-9]{64}/exec {
    proxy_pass http://portainer:9000;
    proxy_read_timeout 30m;
    # Additional proxy settings can go here
}

Very needed feature!


Added Microsoft Automatic Graph Layout

Math/Microsoft Automatic Graph Layout - https://github.com/Microsoft/automatic-graph-layout
MSAGL is a .NET tool for graph layout and viewing. It was developed in Microsoft by Lev Nachmanson, Sergey Pupyrev, Tim Dwyer, Ted Hart, and Roman Prutkin.

Not sure why the Travis build failed - checked the details and it looks like the duplicate checks, etc. passed.

Travis build is failing because of some other projects, yours is fine.


Ubuntu can't find PotreeConverter command

I managed to build and make PotreeConverter successfully in Ubuntu 20.04 without any error. But now, when trying out the command, ubuntu says it can't find the command PotreeConverter. Any help will be appreciated.

Just making sure, you're trying to run PotreeConverter in the path that it was compiled to, right? You should be able to see the file with ls.
If you see it but it just won't run, try making it executable and running it with a relative path (Linux can be stubborn about this).
That is, when you're in the correct working directory:
sudo chmod +x PotreeConverter
./PotreeConverter YOUR-OPTIONS
If you can't find the file, then there may be bigger problems here.

Yeah, it worked now. I thought PotreeConverter would be globally installed. My mistake. Thanks for the prompt reply.

If it was an independent program, I'd suggest placing it in a bin folder. But this isn't a lone application... A couple of its features are dependent on the files around it, like the HTML page generator. I think it's generally a good idea to keep things simple and place it somewhere on your desktop in a directory that's easy to remember.
You can modify the bash terminal to look elsewhere by adding a line to the configuration file, but the name of the file escapes me right now. And it's easy to forget that you added a path to every scope, so I'd still recommend just making a simple path in your home dir so you can easily refer to it like: ~/pc/PotreeConverter YOUR-OPTIONS
Happy converting!


Support custom initial options for sqlite

Hello,
This addresses issue #621, the key (and any options) for sqlcipher must be set before the first operation on the database. the page_size option is set before setting any custom options.

Sorry, I'm making a mess of this PR by trying to get it passing in CI using the "Suggest a Change" feature in Github, it's very error-prone. All these excess commits should be removed by the squash.

Is there any guide or examples on how to connect to a sqlcipher encrypted database?

A bit late to the party but https://github.com/launchbadge/sqlx/blob/e783f9d47c6779304aa569384cabccd468b63e68/tests/sqlite/sqlcipher.rs#L52-L56 seems to be an example of using sqlcipher — I haven't tested it yet. I was confused how this PR would actually let you change the first pragma because it still sets a bunch of default pragmas in the new method and then the pragmas are written out in-order.
But actually, I don't think this PR was sufficient, look at what was added to the code since:
https://github.com/launchbadge/sqlx/blob/e783f9d47c6779304aa569384cabccd468b63e68/sqlx-sqlite/src/options/mod.rs#L118-L119
(There is explicitly a None entry added for the key first in the pragma map.)
So it should be sufficient to call .pragma("key", "hunter2"), without special care worrying about the order or anything, on the SqliteConnectionOptions because the place in the map was already reserved by SQLx.


Log objects via JSON for better debugging

Fixes #2633

LGTM, but it prompts me to suggest some other changes (NB these were issues before, but the increased size of log lines now we're actually the full objects brings things to a head):

The default logrus 'logfmt' format is injecting millions of backslashes which need to be stripped out if you want to parse the JSON - perhaps we should use the common/logging.go formatter
Log lines are truly huge now - I'm still minded to leave them in for a bit longer, but perhaps we should demote them to DEBUG, set the default log level to DEBUG but expose an override

Thoughts? Should these go in separate PR(s)?

My, that was a lot of backslashes.  I put the Weave formatter in, so now we get:
INFO: 2016/12/06 17:23:47.092667 adding entry <IP_ADDRESS> to weave-k?Z;25^M}|1s7P3|H9i;*;MhG
INFO: 2016/12/06 17:23:47.461555 EVENT AddPod {"metadata":{"name":"kube-apiserver-host1","namespace":"kube-system","selfLink":"/api/v1/namespaces/kube-system/pods/kube-apiserver-host1","uid":"bf13e2f0-bbd8-11e6-87c4-42010a800002","resourceVersion":"424","creationTimestamp":"2016-12-06T17:23:47Z","labels":{"component":"kube-apiserver","tier":"control-plane"},"annotations":{"kubernetes.io/config.hash":"0446d05fb9406214210e8d29397f8bf2","kubernetes.io/config.mirror":"0446d05fb9406214210e8d29397f8bf2","kubernetes.io/config.seen":"2016-12-06T17:22:20.379055536Z","kubernetes.io/config.source":"file"}},"spec":{"volumes":[{"name":"certs","hostPath":{"path":"/etc/ssl/certs"}},{"name":"pki","hostPath":{"path":"/etc/kubernetes"}}],"containers":[{"name":"kube-apiserver","image":"gcr.io/google_containers/kube-apiserver-amd64:v1.4.0","command":["/usr/local/bin/kube-apiserver","--v=4","--insecure-bind-address=<IP_ADDRESS>","--etcd-servers=http://<IP_ADDRESS>:2379","--admission-control=NamespaceLifecycle,LimitRanger,ServiceAccount,PersistentVolumeLabel,DefaultStorageClass,ResourceQuota","--service-cluster-ip-range=<IP_ADDRESS>/12","--service-account-key-file=/etc/kubernetes/pki/apiserver-key.pem","--client-ca-file=/etc/kubernetes/pki/ca.pem","--tls-cert-file=/etc/kubernetes/pki/apiserver.pem","--tls-private-key-file=/etc/kubernetes/pki/apiserver-key.pem","--token-auth-file=/etc/kubernetes/pki/tokens.csv","--secure-port=443","--allow-privileged","--etcd-servers=http://<IP_ADDRESS>:2379"],"resources":{"requests":{"cpu":"250m"}},"volumeMounts":[{"name":"certs","mountPath":"/etc/ssl/certs"},{"name":"pki","readOnly":true,"mountPath":"/etc/kubernetes/"}],"livenessProbe":{"httpGet":{"path":"/healthz","port":8080,"host":"<IP_ADDRESS>","scheme":"HTTP"},"initialDelaySeconds":15,"timeoutSeconds":15,"periodSeconds":10,"successThreshold":1,"failureThreshold":3},"terminationMessagePath":"/dev/termination-log","imagePullPolicy":"IfNotPresent"}],"restartPolicy":"Always","terminationGracePeriodSeconds":30,"dnsPolicy":"ClusterFirst","nodeName":"host1","hostNetwork":true,"securityContext":{}},"status":{"phase":"Pending"}}

Still pretty long.
On the subject of the default log level, I guess we could add a --log-level flag and default it to debug, then change the default to info at some later date?

I have converted weave-npc to use common logging, moved pod events to DEBU and added a --log-level flag


Can't find sys/times.h during vscode building in windows 7

Below is the building output:

Executing task: E:\Cadence\SPB_Data.platformio\penv\Scripts\platformio.exe run <

Processing native (platform: native)
Verbose mode can be enabled via -v, --verbose option
PACKAGES:
LDF: Library Dependency Finder -> http://bit.ly/configure-pio-ldf
LDF Modes: Finder ~ chain, Compatibility ~ soft
Found 2 compatible libraries
Scanning dependencies...
Dependency Graph
|--  6.0.2
|-- <lv_drivers> 6.0.2
|   |--  6.0.2
Compiling .pio\build\native\drivers\sdl2\driver.o
Compiling .pio\build\native\src\demo.o
Compiling .pio\build\native\src\img_bubble_pattern.o
Compiling .pio\build\native\src\main.o
Compiling .pio\build\native\src\syscalls.o
Compiling .pio\build\native\lib34d\lvgl_ID6598\lv_core\lv_disp.o
src\syscalls.c:56:10: fatal error: sys/times.h: No such file or directory
#include <sys/times.h>
^~~~~~~~~~~~~
compilation terminated.
*** [.pio\build\native\src\syscalls.o] Error 1

which was claimed to be supported

Where it was done? Send PR to remove and avoid confusion.

BTW: for mingw64 in windows, I'm using x86_64-8.1.0-release-posix-seh-rt_v6-rev0

which was claimed to be supported

Where it was done? Send PR to remove and avoid confusion.

I think here: https://docs.littlevgl.com/en/html/get-started/pc-simulator.html

I guess, doc predicts the future :). It's maintained by someone else. Ask on forum or in lvgl repo to clarify.
Also, i did not understood, are all targets broken or native only? Is stm32 target buildable?

@zzzh There is a difference between the PC simulator and the PlatformIO project. The documentation you are working with is not for PlatformIO.
If you are just looking to get a PC simulator on Windows try the CodeBlocks or Visual Studio projects. They should support Windows out of the box.

Got it.
Took a try, stm32 works, only native have issue

@embeddedt  Got it, thank you, I'll not use PlatformIO in windows.

Since you are not first, who report such issue, probably README should be improved to avoid confusion.
Also, i'm sure SDL2 can be fixed for PIO + Win. But that requires volunteer, who is interested to spend time for that.

https://github.com/littlevgl/lv_platformio/commit/c48729d0c6e2dbf4ae18315b4c4925abea5c5c49 added Windows note.


Fix resource group tag, also attempt to asynchronously delete

/azp run azure-dev - template - tests

/check-enforcer override


Clarify whether Flagsmith supports floating point values or not.

You can also optionally store and override String and numerical (int and float) values.
- https://docs.flagsmith.com/managing-features/

Traits are stored natively as either numbers, strings or booleans.
- https://docs.flagsmith.com/managing-identities/#identity-traits

I have not succesfully created a floating point value for a feature flag. Any such attempt leads to the value being coerced into a string. This experiment has not worked for traits either.
What is the actual situation regarding this?

Hi @js-sketch  - which SDK are you using?

Closing this due to inactivity.


Bug report: (node:5260) UnhandledPromiseRejectionWarning: Error: Cannot find module 'chalk' on Node 14.17.0

Description
After installing Node 14.17.0 and installing @pnp/cli-microsoft365
m365 --help shows error:
`(node:5260) UnhandledPromiseRejectionWarning: Error: Cannot find module 'chalk'
Require stack:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>at Function.Module._resolveFilename (internal/modules/cjs/loader.js:885:15)
at Function.Module._load (internal/modules/cjs/loader.js:730:27)
at Module.require (internal/modules/cjs/loader.js:957:19)
at require (internal/modules/cjs/helpers.js:88:18)
at Cli.closeWithError (C:\Users\ogal\AppData\Roaming\npm\node_modules@pnp\cli-microsoft365\dist\cli\Cli.js:636:23)
at C:\Users\ogal\AppData\Roaming\npm\node_modules@pnp\cli-microsoft365\dist\cli\Cli.js:243:26
at Array.forEach ()
at Cli.loadAllCommands (C:\Users\ogal\AppData\Roaming\npm\node_modules@pnp\cli-microsoft365\dist\cli\Cli.js:232:15)
at Cli.loadCommandFromArgs (C:\Users\ogal\AppData\Roaming\npm\node_modules@pnp\cli-microsoft365\dist\cli\Cli.js:256:18)
at Cli. (C:\Users\ogal\AppData\Roaming\npm\node_modules@pnp\cli-microsoft365\dist\cli\Cli.js:67:18)
(Use node --trace-warnings ... to show where the warning was created)
(node:5260) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:5260) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.`

Is Node version too new?

To add to this...
I tested CLI v3.5.0 on node v14 with no issues, but after removing the CLI and attempting to install 3.9.0 using npm i -g @pnp/cli-microsoft365 I get the below error.
npm ERR! 404 Not Found - GET https://npm.pkg.github.com/microsoft/@microsoft%2frecognizers-text-data-types-timex-expression - npm package "recognizers-text-data-types-timex-expression" does not exist under owner "microsoft"
npm ERR! 404
npm ERR! 404  '<EMAIL_ADDRESS>is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 It was specified as a dependency of '@pnp/cli-microsoft365'
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR!      /Users/garrytrinder/.npm/_logs/2021-05-16T10_32_18_066Z-debug.log

This was on macOS Big Sur, using nvm with<EMAIL_ADDRESS>

Maybe we should introduce a step in our CI/CD pipeline to check that an npm install is successful?

I've just tried this on a fresh install of<EMAIL_ADDRESS>using nvm on macOS BigSur and I don't get an error when calling m365 --help, so this seems to be either a local node install issue or is Windows specific.

How did you install node on your machine @Ofer-Gal ?

I used NVM install 14.17.0

@pnp/cli-for-microsoft-365-maintainers anyone able to recreate this on Windows?

Windows 10, nvm with Node 14.17.0 in Windows terminal is working for me.

@Ofer-Gal, could you try to uninstall CLI and reinstall it again to see if the issue persists?

Will do

@waldekmastykarz I uninstalled , changed to Node  14.17.0 and installed. It is working now.
All is good.
Thanks for your patience.

Awesome! Great to hear it's all working. I appreciate you taking the time to report the issue and double check together with us that all is working as expected.


use fullpath

Coverage remained the same at 96.579% when pulling 0cceab12d67fed7be07a096fddc2810a62912612 on security-change-test into c4b0b62f5dd391d4db202bf7e384967571ea4e3d on main.


Set a custom panic_hook to log to console.error in the test suite

Essentially what https://github.com/rustwasm/console_error_panic_hook is doing, but I don't know whether we want to use that directly (dependencies could get funky, since it depends on wasm-bindgen) or just do the same technique.
Other thing to think about is how to make this ergonomic, so that we don't have to keep repeating boilerplate in every test.

@myfreeweb because that has non-zero code size overhead implications. Something like ~40K to include all of the std::fmt and std::panicking infrastructure last time I checked.

And we have an opt-in solution right now with the console_error_panic_hook crate.

This is being done in https://github.com/rustwasm/wasm-bindgen/pull/524

Done now with the wasm_bindgen_test crate!


improve struct z_page_frame usage

There is a nasti __packed on struct z_page_frame that has to die.
Remove it and make the structure even more compact at the same time.

It might be easier for the compiler to omit better code by grouping the
negated ANDed terms into a single negation of the ORed terms.

The generated code is pretty horrid indeed. But Z_PAGE_FRAME_FREE must
be considered specially since if set the other bits are not valid.
And the compiler apparently insists on testing each flag one by one.
I prefer to introduce as few changes as possible and lean towards
correctness with this commit. But I'll revisit this part separately
to optimize it eventually.


win32,python3: Load DLL from registry path

Support loading python3.dll and/or python3xx.dll from the path written in the registry.  To support Stable ABI's forwarder DLL (python3.dll), use the LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR flag for LoadLibraryEx().
If Stable ABI is used, search the latest version from the registry (both from HKEY_CURRENT_USER and HKEY_LOCAL_MACHINE).  If Stable ABI is not used, search only the matching version.

thanks!


Remove version to always install the latest Ansible operator

Signed-off-by: Feng Xiang<EMAIL_ADDRESS>Issues:

https://github.com/stolostron/backlog/issues/21762
https://github.com/stolostron/backlog/issues/21700

Changes:

Remove ansible operator version to always install the latest operator that's available in the current OCP version

/test e2e-cluster

/test e2e-cluster


[Improvement] Unbind keys for undoSelection and redoSelection #218

We introduced 'unbindKeys' option to unbind codemirror's keys and used this option to disable those keys.

@happibum : setOption() will become instance method. So I will consider your commit and apply your idea to the new method. Thanks.

Dear @hwshim,
how's the schedule for this unbind?


Mosdepth in v1.0.5

Hi Brad,
I noticed our production install of bcbio uses an general call to Mosdepth during QC. However, this causes bcbio to use the wrong version (latest, in our main env) instead of the one in the bcbio env.
Do you suppose this could be fixed in the 1.0.5 tag?
If not, would a manual fix with something like this work to get the version from the bcbio env?
mosdepth = config_utils.get_program("modepth", data)
Cheers
M

Matthias;
Unfortunately we don't have version pinning tied to releases right now so this is likely the source of the trouble. I'm hoping to test and stabilize the current development and push a new release to resolve this. In the short term, the best approach is to ensure that your PATH is set so that it points to the 1.0.5 before your main environment. We're generally trying to avoid ad-hoc setting config_utils paths since it's not done consistently throughout bcbio.
Sorry about all the changes surrounding this. I'm hoping it'll all be worthwhile to folks with the speed improvements in the latest development version.

Hi Brad,
Thanks for the info. We try to keep both environments apart, and the path is set to include only the bcbio env. I suppose it's an issue with PBS resetting the path to default I suppose.
Cheers
M


Remote Update (everything): donovandmc/fixes-n-shit

@ErisPRUpdateBot merge

Error Merging:

HttpError: Pull Request is not mergeable
at /app/node_modules/@octokit/request/dist-src/fetch-wrapper.js:68:27
at runMicrotasks ()
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at /src/sites/yiff.rest/routes/github.ts:30:3
at async Promise.all (index 0)
at middleware (/app/node_modules/@octokit/webhooks/dist-src/middleware/node/middleware.js:51:9)


No Speed or Heading returned for iOS

Bug Information
Version Number of Plugin: <IP_ADDRESS>
Device Tested On: iPhone 6S with OS 11.4
Simulator Tested On:
Version of VS: 2017 For PC
Version of Xamarin: <IP_ADDRESS>0
Versions of other things you are using:
Steps to reproduce the Behavior
I am using the sample code that you published for the plug-in. When I go to the tab "Track Movement" on an iOS device (physical iPhone 6S), I get steady position updates but the position.heading and position.speed are always 0. On an Android, these values are correct and non zero based upon my movement.
Also, I am noticing the timestamp for the readings does not have the granularity down to milliseconds.
Expected Behavior_
I would expect to see the heading and speed value be non-zero on iOS as with Android.
I would expect the milliseconds in the timestamp to be non-zero as well (iOS and Android)
Actual Behavior
See above. I can certainly calculate speed based upon long/lat calculations but it would be nice for iOS to mimic how Android is returning these values.
Code snippet

See Sample Code for Geolocator on GitHub

Screenshots

None

Thanks James. Have you seen the timestamp on iOS/Android return milliseconds?


Add JWS_AUTH_SECRET to collections-publisher

Trello: https://trello.com/c/9ZMVHe0u
Motivation
We want to allow people with an access_limiting token to be able to view content published
by collections-publisher on the draft stack without the need of a signon account.
The first step is to create JWS_AUTH_SECRET environment variable that will be used to generate
the token.

I can see from the linked Trello card that the motivation for this is previewing Step by steps, but it might be useful to have this information in the commit message as well.


Do a noop update when updating the entities table

Summary
The ON CONFLICT DO NOTHING clause we used previously would have caused
the SQL query to return "No rows in result set". Let's pretend we do an
update by setting an ID to its own value to trigger the RETURN clause.
Change Type

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
smoke tests
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 53.974% (-0.005%) from 53.979%
when pulling f95de177fb53d6eda747f31a6be45c9150272da6 on jhrozek:noop_update
into e10dba16f9f3079d040a2a183b6497f7a0921d0e on stacklok:main.


Bug fix - Added standard MySQL port to config files

Fixing bug: https://buganizer.corp.google.com/issues/31465342

@ryanmats have you deployed and confirmed this works? The live connection string is different, so please confirm.

ill check now!


pretrained model

Hi @timmeinhardt ,
Thanks for your great works! I want to produce the results in the paper with your pretrained models. However, I do not find the link to download the models. Are you going to release the models used in your paper?

Sorry, I find the link now.

Top. Can we close the issue?


Rate limiting with excluded IPs doesn't use request.RemoteAddr

Do you want to request a feature or report a bug?
Bug
What did you do?
Tried to set a ratelimit that uses the IPStrategy and ues the remote IP address, since there is no X-Forwarded-For header in our setup (Traefik is listening to requests directly).
What did you expect to see?
Exhausing the rate limit from one IP should not affect the limit of any other IP, and <IP_ADDRESS> should be excluded from the limit entirely.
What did you see instead?
When the ratelimit.sourcecriterion.ipstrategy.excludedips is set, Traefik only considers the value of X-Forwarded-For
It took a bit of debugging and adding log statements all over the place, but it turns out that the source at https://github.com/traefik/traefik/blob/v2.4.7/pkg/middlewares/ratelimiter/rate_limiter.go#L108 is just an empty string as soon as you set the excluded IPs. That means every request shares the same bucket.
The cause for this is most likely found at these places:
https://github.com/traefik/traefik/blob/v2.4.7/pkg/config/dynamic/middlewares.go#L262
https://github.com/traefik/traefik/blob/v2.4.7/pkg/ip/strategy.go#L58
There are two tests for the excluded IP behavior at https://github.com/traefik/traefik/blob/v2.4.7/pkg/ip/strategy_test.go but they both only test by setting the header.

Following configs were set via Consul:
traefik.enable=true
traefik.http.routers.testing.rule=Host(`example.com`)
traefik.http.routers.testing.entrypoints=https
traefik.http.routers.testing.tls=true
traefik.http.routers.testing.middlewares=testing-ratelimit@consulcatalog
traefik.http.middlewares.testing-ratelimit.ratelimit.average=100
traefik.http.middlewares.testing-ratelimit.ratelimit.burst=250
traefik.http.middlewares.testing-ratelimit.ratelimit.period=1m
traefik.http.middlewares.testing-ratelimit.ratelimit.sourcecriterion.ipstrategy.excludedips=<IP_ADDRESS>

I think I understand what you're looking at, and I think I agree with your analysis, however I am not sure I get what you're tying to achieve.
If you want the ratelimit matcher to user the remote address (so that each incoming request from a different address gets its own bucket), then why don't you use an empty ratelimit.sourcecriterion (which defaults to using the remote address) in your config?

That's because I would like to exclude specific IPs from the rate limiting to allow stress testing behind the proxy.

@manveru If I understood the code correctly, even if we fixed the CheckerStrategy algorithm to take into account the RemoteAddress (which maybe we should, and I started working on that), I don't think it would fix your problem, as I don't think the excludedips strategy would do what I think you want (arguably, because this excludedips option is badly named).
The way the rate limiter works is: all the IPs in the excludedips pool will be considered as the same source (the "" one), and a common rate limit will be applied to all of them. But it is not meant to simply exclude them from any rate limiting considerations.
So with the configuration you showed the effect would be that: 1) any request that does not come from <IP_ADDRESS> gets into a different bucket (each unique IP gets its own bucket), i.e. anyone on the internet gets their own ratelimiting at 100req/m, 2) all requests matching the IPs in the pool get to the bucket for the "" (empty string), which also gets its ratelimiting at 100req/m. Since there's only one IP in the pool, it is in effect useless, and you could just as well remove the excludedips criterion.
If what you want to do is have a rate limit in general for most IPs, but have <IP_ADDRESS> completely escape the rate limiter, then I think what you want is two routers: one exclusively for <IP_ADDRESS>, with no rate limit middleware applied to it, and another router for all the other requests, with a rate limit middleware applied to it, with whatever parameters fit your case.

Thanks for the explanation, we'll try to use a different approach then. I must've misunderstood the documentation for this config option.

Closed by #8072.


Prevent autofocus on search field for mobile users

The select lists doesn't work vert well on mobile phones when used with the search/filter option.
Because whenever the user tap on the list to select an option, the keyboard will show up and cover half of the screen, making it hard to see and scroll through the options.
Is it possible to prevent the keyboard from showing up unless the search field is selected?

Yes this what I asked before https://github.com/silviomoreto/bootstrap-select/issues/912

Duplicate of #912.


Roll Plugins from 10b40ddae933 to d054fa9a19bc (2 revisions)

https://github.com/flutter/plugins/compare/10b40ddae933...d054fa9a19bc
2021-02-15<EMAIL_ADDRESS>Enable CI tests on beta (flutter/plugins#3538)
2021-02-14<EMAIL_ADDRESS>[google_maps_flutter] Migrate platform interface to null safety (flutter/plugins#3539)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

#76034


Python 2.6 support

It looks like we could get Python 2.6 support by just changing the way that formatted strings are defined to include the argument number.
tox -epy26 results in the following output:
https://gist.github.com/woodb/05795c29334d17d06f2a.js
I'd be willing to take this on, but it does require updating the following files, so I wouldn't want the PR to get too stale.
graphql/core/execution/values.py
graphql/core/language/error.py
graphql/core/language/lexer.py
graphql/core/language/parser.py
graphql/core/language/printer.py
graphql/core/validation/rules.py

seems like something we should do after https://github.com/dittos/graphql-py/issues/6 is finished off

Agreed @rawls238

After looking at what it would take to support Python 2.6, I'm thinking that it's not really important. Esp. since we're dealing w/ a hip new tech, I don't see anyone using it still being on Python 2.6 that would want to use it (while I would argue that #17 was necessary for this same reason).
Closing this one out, but if someone has a compelling reason to want to support 2.6, we can reopen it.


HIVE-26476: map ORCFILE to ORC while creating an iceberg table

What changes were proposed in this pull request?
Hive allows creating tables stored in ORC in two different syntaxes

STORED AS ORC

STORED AS ORCFILE

When running a create iceberg table statement that is using the second option we should map the ORCFILE keyword to ORC

Why are the changes needed?
The iceberg library throws an exception when the table was created using the ORCFILE syntax.

Does this PR introduce any user-facing change?
No

How was this patch tested?
Manual test, unit test

The testInsertIntoORCFile test case seems to be broken due to non-existing t2 table. Otherwise patch looks good, although please update the jira title now that text file format behaviour is affected too.


Cherry pick Fix failing unit tests on windows (#11191)

Codecov Report

Merging #11277 into release-2020.04 will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release-2020.04   #11277      +/-   ##
===================================================
- Coverage            61.44%   61.42%   -0.03%
===================================================
  Files                  596      596
  Lines                32828    32828
  Branches              4646     4646
===================================================
- Hits                 20170    20163       -7
- Misses               11640    11645       +5
- Partials              1018     1020       +2

Impacted Files
Coverage Δ

src/datascience-ui/react-common/arePathsSame.ts
75.00% <0.00%> (-12.50%)
:arrow_down:

src/client/common/utils/platform.ts
64.70% <0.00%> (-11.77%)
:arrow_down:

src/client/linters/pydocstyle.ts
86.66% <0.00%> (-2.23%)
:arrow_down:

src/client/datascience/debugLocationTracker.ts
76.56% <0.00%> (-1.57%)
:arrow_down:

...client/datascience/kernel-launcher/kernelFinder.ts
75.70% <0.00%> (-0.94%)
:arrow_down:

src/client/common/process/proc.ts
14.49% <0.00%> (-0.73%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e29be4...78935a2. Read the comment docs.


Print cannot be passed via php exec

Hello, dev
Maybe its a bug.
The code
import newspaper
from newspaper import Article
berita = Article(url="http://opensourceforu.com/2016/07/22843/")
berita.download()
berita.parse()
print(berita.text.encode('utf-8'))
and i have php script to get returned string from python script
exec('python3 /var/www/ig.zavirajewelry.com/htdocs/pyton/berita.py', $output);
print_r($output);
Its not working, but when i am remove
import newspaper
print can passed to php script.
thanks
I am use ubuntu 14.04 & python 3.x

Does it work when you run the python script (python3 /var/www/ig.zavirajewelry.com/htdocs/pyton/berita.py) in the shell?


[Feature] Keep Header and Filter Sidebar Fixed for Improved User Experience

Description: Currently, both the header and filter sidebar scroll away when navigating through the job listings. This causes inconvenience, as users lose access to the filters and top navigation options, making it harder to switch filters or navigate back to other sections. Fixing this will enhance usability, especially on long pages with multiple job postings.
Before scrolling:

After Scrolling:

Proposed Solution:
Fixed Header: The header should remain fixed at the top of the page to allow easy access to navigation links and the login button, regardless of scroll position.
Fixed Filter Sidebar: The filter sidebar should stay in place on the left side of the screen, allowing users to update filters as they scroll through job listings. Only the job listing area on the right side should be scrollable.
I am experienced with the technologies used in this project and skilled in the MERN stack, making me well-suited to address both frontend and backend issues. I would be more than happy to contribute fixes for these UI issues. If the maintainers are open to it, I can start by addressing one or all of these problems, ensuring that the solutions align with the project’s overall design and functionality standards.
If you would like me to submit a pull request with these fixes, please let me know. I am open to feedback on my proposed solutions and would appreciate any guidance on project-specific coding standards or best practices.
Additionally, if you need assistance with backend development or other aspects of the project, please feel free to reach out to me. Here is my LinkedIn profile for contact: www.linkedin.com/in/himanshu-mishra-459b882b4.

@himanshumishra1309 can you please clone repo and check local latest code and then raise the issue current code is lot more chnaged than the deployed old one

After testing the latest code in the local environment, I noticed that while the header is now fixed, the filter sidebar still scrolls with the page. For a better user experience, it would be beneficial if the filter sidebar remained fixed on the left side of the screen, allowing users to adjust filters as they browse through job listings. This way, only the job listing section on the right would be scrollable, making it easier for users to view and apply filters without losing their position on the page.
Before scrolling:

After scrolling:

Proposed Solution:

Make the filter sidebar fixed on the left side of the screen.
Allow only the job listings section on the right to be scrollable.

Benefit: This change will improve navigation and accessibility, providing a smoother experience for users when browsing and applying filters to job listings.