Add Sarachnis

Description:
Added Sarachnis LootTable to oldschoolJS
Changes:
Added Sarachnis LootTable to oldschoolJS, Hatty made most of the loot table, I just helped out.

[X] I have tested all my changes thoroughly.

Codecov Report

Merging #149 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   79.94%   79.90%   -0.05%
==========================================
  Files         161      162       +1
  Lines        1985     1991       +6
  Branches      168      168
==========================================
+ Hits         1587     1591       +4
- Misses        376      377       +1
- Partials       22       23       +1

Impacted Files
Coverage Δ

src/simulation/monsters/bosses/Sarachnis.ts
100.00% <100.00%> (ø)

src/simulation/monsters/index.ts
100.00% <100.00%> (ø)

src/structures/Worlds.ts
84.21% <0.00%> (-10.53%)
:arrow_down:

src/structures/Collection.ts
33.56% <0.00%> (-0.92%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f50f823...435d727. Read the comment docs.


Need to send tokens from wallet

See also #45

[ ] Hardcode token list for sending (we don't have a token registry yet)
[ ] Allow option to paste token address, and we assume a ERC-20 compatible interface


[bugfix] date is invalid and inBetween (inclusive) returns always true

when date is invalid the method inBetween with inclusivity != '()' returns always true.

I'm not sure the travis build is related with this pr...

@marwahaha I think I've done what is needed, but the cla is still yellow :(

This is was fixed in 40b52a0333f2620f1c3fc3bdad7dc71b5941c13f


Add rows/columns count, file size and data load time display to vscode status bar

similar to how Data Preview extension does it:

added data file stats display in vscode status bar:

closing this for now. will finalize loading data display progress in #60 and take care of resetting and updating active table view stats in #31.


INT B-18761 HL loading screen

B-18761
Summary
Ensures that the loading placeholder for the move history log stays in place until the table has actually been populated with data. One-line fix, added to if statement for LoadingPlaceholder to also render the placeholder if table data is <=0 and an error has not yet occured.
How to test

Access the Move History tab of any move as any user role.

In Chrome devtools, go to the "Network" tab, on the top ribbon next to the wifi symbol, you should see a dropdown to enable network throttling, choose either fast or slow 3G. Slow will take awhile but the effect will be easier to see.

After enabling, reload the move history page, you should see that the loading placeholder stays in place right up until the table is shown, fully populated. Contrast this to the main/int branch, where doing the same process will result in an empty table showing on the screen for a few seconds until it is populated.

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against b96dec9ec555c1f8ae37cdb64603a8bfeed8ab67


neosnippet snippets

https://github.com/Shougo/neosnippet.vim
The plugin has snippets for Ultisnips but not neosnippets :(

Going to close as it has been a long time and I'm not sure if this is relevant anymore.


Kotlin examples 500 and 513 should use an until range

The Kotlin examples 500 and 513 in the userguide have the following line:
.let { children -> (0..children.length).map { children.item(it) } }

This accidentally works as the next line is .filterIsInstance<Element>() which throws away the extra null element that is generated.
But if someone uses this as inspiration to do something similar and copies it, it might go wrong like for me when I created an extension function fun NodeList.asList() = (0..length).map { item(it) }.
Instead the line should actually read
.let { children -> (0 until children.length).map { children.item(it) } }

or for my extension function fun NodeList.asList() = (0 until length).map { item(it) }.
Actually you could even use the probably nicer
.run { (0 until length).map(::item) }

Hi @Vampire. Thanks for the report. Maybe you would like submitting an accompanying PR to fix it?

Maybe. (#9457)


png renderings not deterministic

Running tools/render.lua on the same frame yaml will result in different png files.

Fixing this means we could have goldens in the repo for validating rendering.


2 Kia's, 2 UVO Account Issues.

Please check Services, Known Bug / Issues and Troubleshooting over here first: https://github.com/fuatakgun/kia_uvo/blob/master/README.md
Region and Brand of car
Version of the integration
2.18.2
Describe the bug
My wife and I both have KIA's each of us have our OWN UVO account. Each is the Secondary drive of the other.
In the app/integration, I have no way to specify which UVO account send the command.
So as an example. if my wife starts her car(through HA) it will send as me the secondary driver of that car. The car profile will be mine, He phone won't connect to bluetooth etc. Is there a way we can specify which account to send the data from to prevent this?
Right now my only work around is to remove us each as secondary drivers so only primary is shown.
(Which I don't like cause when I want to use the KIA App I can't see her car unless I log out and back in)

Just to confirm you have two instances of the integration installed.   So two copies of each car.
You want to be able to select which login to use to send the command?

Yes each user has 2 Device. However cause they are named The same they don't appear as separate devices(cars)
And Yes I want to say send this command as this UVO login or that UVO login. So that it will send it as the primary or secondary driver.. I hope this makes sense.

It does.   Definitely not a use case we thought about when we did this.
We dealt with 2 cars to one account in 2.x of this. It also handles discrete accounts but not that combo.
I'll poke through the code to see how we would do this.

Thanks for now, I just removed each of us as secondary accounts. So when I send commands to her car it is as her, and mine it is as me and nothing in between for now. Let me know if I can help out at all.


Docs: fix formatting of return value

Currently it's showing each newline as another return value.

TODO

[ ] Enable RTD PR previews


Adding PO models and modified several other transaction models

added missing customer_id columns to stg_quickbooks__purchase_line
changed adjustment to is_adjustment in stg_quickbooks__journal_entry

@fivetran-joemarkiewicz added some changes

Thanks for opening this PR James! The additions you made make sense to me. Do you know if there is an intention to have any of these additional fields be present in downstream models within the dbt_quickbooks package? If so, we can create a new branch in that repo for these added columns and do a joint release with your PR and Issue recommendations.

Thanks for opening this PR James! The additions you made make sense to me. Do you know if there is an intention to have any of these additional fields be present in downstream models within the dbt_quickbooks package? If so, we can create a new branch in that repo for these added columns and do a joint release with your PR and Issue recommendations.

I haven't thought through that yet... I'm working on a few COGS models in our dbt project for now since the way we use QBO is a bit wonky. I've also just pushed a few more commits to build PO staging models - we use PO's as a COGS placeholder so I'll need them to estimate COGS when we don't have any actuals

Hi @jamesrayoub, thanks so much for making these updates! They will surely be helpful to other package users, we really appreciate your contributions. There are a few minor changes I am going to apply before merging with master. As such I have created a new branch in our repository james_changes which I will merge this PR to and make the small changes to before merging to master.
The only major change I may incorporate is having the PO models disabled by default. Since such a small percentage of customers use PO's it may cause additional confusion if it is another model they need to disable. Therefore, if you were to want to use the PO models you created then you will declare the variable as true to overwrite the default false.


Support for models with delays?

I'm curious as to your thoughts on how delays could get represented in the framework- see e.g. https://github.com/epirecipes/sir-julia/blob/master/markdown/dde/dde.md for a simple model with a delay.

I think that you could add delays with a type of system that has two variables where it reads from one variable and then holds that value for T seconds before writing it to the other variable. However, this looks like a much better way. We would define a new oapply https://diffeq.sciml.ai/dev/tutorials/dde_example/ following the instructions at this link.


Make heartbeat period shorter than inactivity timeout + test

This change is

r? @canndrew
(maidsafe_highfive has picked a reviewer for you, use r? to override)


Running brew doctor or any brew command causes Terminal To crash (Fedora 22)

After running the
sudo yum groupinstall 'Development Tools' && sudo yum install curl git irb m4 ruby texinfo bzip2-devel curl-devel expat-devel ncurses-devel zlib-devel

and finishing the installinations, running any brew command causes the default terminal of Fedora 22 to crash and be closed without errors being reported.
I attempted to run brew doctor with the same results. Suggestions on how to better report this bug?

Sorted this out. This was due to jruby running and not ruby. New system caused it to die.


keys_for_test_only/*.key: No such file from interactive bash session

prinKeys() seems to depend on files that have gone away:
https://github.com/Agoric/agoric-3-proposals/blob/bf97facd3bb802e385933d4c29514e8faa21a98b/packages/synthetic-chain/public/upgrade-test-scripts/env_setup.sh#L202-L204
symptoms:
$ yarn docker:bash
yarn run v1.22.21
$ cd contract; docker compose exec agd bash
WARN[0000] /home/connolly/projects/dapp-offer-up/docker-compose.yml: `version` is obsolete
ENV_SETUP starting
ENV_SETUP finished
========== GOVERNANCE KEYS ==========
bash: /usr/src/upgrade-test-scripts/keys_for_test_only/*.key: No such file or directory
*:
cat: '/usr/src/upgrade-test-scripts/keys_for_test_only/*.key': No such file or directory

========== GOVERNANCE KEYS ==========

cc @LuqiPan @turadg

Just tested on latest container image, there's still a unhandled y/N prompt in env_setup.sh
agd keys export --unsafe --unarmored-hex --keyring-backend=test user1
WARNING: The private key will be exported as an unarmored hexadecimal string. USE AT YOUR OWN RISK. Continue? [y/N]: ^C

The fix is to pipe yes | to it, as seen in #142


Add option to disable ordering dependencies on Openvpn::Client

Signed-off-by: Florian Pritz<EMAIL_ADDRESS>

Hi @Bluewind . Can you explaine a use case ?

We have a setup where we manage client certificates outside of puppet and we'd like to migrate our servers to this module. We are perfectly fine with managing the certificates with our existing workflow. Since we do not need it, we do not configure a Client[$name] resource for the matching  Client_specific_config[$name], but currently this code results in an error because it expects such a resource to be defined. Does that explanation help?


Change default path for configs in browserify

whip

change summary:

breaking for browserify + node
minor for core

change summary:

breaking for browserify + node
minor for core


Filippo's pull request - Repo assignment

Hello @donotdespair,
I have adjusted my computations as we previously discussed. Now, in the commit I have made the correct computations and I have added a R function to be updated with the parameters from the previous sections.
Thank you very much for your help and availability,
Filippo

Hi @IoTiFeelo
Please, introduce the changes to index.qmd file. No additional files are accepted for this submission. It's not a workable model in git/GitHub. Thanks!
Greetings, Tomasz

Hi @IoTiFeelo  I am closing this one. Please submit a pull request to a new branch. Thank you!


Pressing Enter on Client Search as worker redirects to the Keep.id homepage.

If you press enter on the textfield for searching clients as a worker, you are redirected to the Keep.id homepage.

@MelindaCardenas maybe you could look into this?


rnpm link is not working on Android for similar name modules

I have two modules named likes react-native-foo and react-native-foo-bar, if run rnpm link react-native-foo-bar then rnpm link react-native-foo, it works fine on iOS, but not linked react-native-foo on Android, outputs:
rnpm-link info Linking react-native-foo android dependency
rnpm-link info Android module react-native-foo is already linked

Environment:
node --version && npm --version && rnpm --version && react-native --version
v5.5.0
3.6.0
1.6.2
react-native-cli: 0.2.0
react-native: 0.23.1

Yeah, indeed. I'll do my best to fix it asap.

Is that @Kureev handled by your branch yet?

it would be

fixed

Great! Thanks @Kureev

Can you update rnpm and try to reproduce it, @cpunion?

@Kureev Just tested<EMAIL_ADDRESS>with<EMAIL_ADDRESS>first run rnpm link react-native-foo-bar first, and then rnpm link react-native-foo, a problem in android/settings.gradle:
rootProject.name = 'TestRNPM'

include ':app'
include ':react-native-foo'
project(':react-native-foo').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-foo/android')include ':react-native-foo-bar'
project(':react-native-foo-bar').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-foo-bar/android')

include ':react-native-foo-bar' should in new line.

So looks like the original issue is resolved, related issue to the include is here https://github.com/rnpm/rnpm/issues/153


win32 interop doesn't follow linux symbol links to NTFS folder on Win 10 v1903

Your Windows build number:  (Type ver at a Windows Command Prompt)

Microsoft Windows [10.0.18362.116]
Win 10 v1903 x64 (Education), upgraded from local ISO yesterday.

What you're doing and what's happening:  (Copy&paste the full set of specific command-line steps necessary to reproduce the behavior, and their output. Include screen shots if that helps demonstrate the problem.)

Here's my env:
$ cat /etc/wsl.conf
[automount]
enabled = true
root = /
options = "metadata,umask=22,fmask=11"
mountFsTab = false

$ ls -lad /wo (/wo is a Linux symbolic link created by ln -s)
lrwxrwxrwx 1 root root 10 Apr  1 22:39 /wo -> /r/working

And then I want to run some EXE files under R:\working.

What's wrong / what should be happening instead:

expected: Before ugprading to Win 10 v1903, I can run /wo/*.exe successfully.
After upgrading, it can not run if an exe's path is "/wo/...":
$ cd /wo
$ ./jsformatter.exe # it's a Win32 tool of mine
        Javascript formatter 0.9 - by<EMAIL_ADDRESS>$ /wo/JSFormatter.exe # nothing happens - it just fails silently
$ /r/working/JSFormatter.exe
        Javascript formatter 0.9 - by<EMAIL_ADDRESS>$ wslpath -w -a .
R:\working\
$ wslpath -w -a /wo
\\wsl$\Ubuntu\wo
$ wslpath -w -a JSFormatter.exe
R:\working\JSFormatter.exe
$ wslpath -w -a /wo/JSFormatter.exe
\\wsl$\Ubuntu\wo\JSFormatter.exe
$ wslpath -w -a /r/working/JSFormatter.exe
R:\working\JSFormatter.exe

Other Win32 programs, including git.exe from Git for Windows, also fails on a full path containing symbolic links.
cmd> wsl.exe --upgrade doesn't influence it.

Strace of the failing command, if applicable:  (If some_command is failing, then run strace -o some_command.strace -f some_command some_args, and link the contents of some_command.strace in a gist here).

$ strace  /wo/JSFormatter.exe
execve("/wo/JSFormatter.exe", ["/wo/JSFormatter.exe"], 0x7fffee0649c0 /* 26 vars */) = 0
arch_prctl(ARCH_SET_FS, 0x293820)       = 0
set_tid_address(0x293858)               = 163
brk(NULL)                               = 0x21f3000
brk(0x21f4000)                          = 0x21f4000
sched_getaffinity(0, 128, [0, 1, 2, 3]) = 64
uname({sysname="Linux", nodename="gdh-PC2", ...}) = 0
getpid()                                = 163
getcwd("/r/working", 4096)              = 11
open("/dev/lxss", O_RDWR)               = 3
ioctl(3, _IOC(0, 0, 0x2f, 0x22), 0x7fffd54a66f8) = 0
getcwd("/r/working", 4096)              = 11
open("/proc/self/mountinfo", O_RDONLY)  = 5
readv(5, [{iov_base="", iov_len=0}, {iov_base="2 2 0:2 / / rw,noatime - wslfs r"..., iov_len=1024}], 2) = 1024
readv(5, [{iov_base="", iov_len=0}, {iov_base="id=1000,gid=1000,umask=22,fmask="..., iov_len=1024}], 2) = 347
readv(5, [{iov_base="", iov_len=0}, {iov_base="", iov_len=1024}], 2) = 0
close(5)                                = 0
getcwd("/r/working", 4096)              = 11
open("/proc/self/mountinfo", O_RDONLY)  = 5
readv(5, [{iov_base="", iov_len=0}, {iov_base="2 2 0:2 / / rw,noatime - wslfs r"..., iov_len=1024}], 2) = 1024
readv(5, [{iov_base="", iov_len=0}, {iov_base="id=1000,gid=1000,umask=22,fmask="..., iov_len=1024}], 2) = 347
readv(5, [{iov_base="", iov_len=0}, {iov_base="", iov_len=1024}], 2) = 0
close(5)                                = 0
ioctl(0, TCGETS, {B38400 opost isig icanon echo ...}) = 0
ioctl(1, TCGETS, {B38400 opost isig icanon echo ...}) = 0
ioctl(2, TCGETS, {B38400 opost isig icanon echo ...}) = 0
ioctl(0, TIOCGPGRP, [161])              = 0
getpgid(0)                              = 161
fstat(0, {st_mode=S_IFCHR|0660, st_rdev=makedev(4, 1), ...}) = 0
fstat(1, {st_mode=S_IFCHR|0660, st_rdev=makedev(4, 1), ...}) = 0
fstat(2, {st_mode=S_IFCHR|0660, st_rdev=makedev(4, 1), ...}) = 0
ioctl(0, TIOCGWINSZ, {ws_row=66, ws_col=226, ws_xpixel=0, ws_ypixel=0}) = 0
ioctl(0, SNDCTL_TMR_START or TCSETS, {B38400 -opost -isig -icanon -echo ...}) = 0
                                                                                dup(0)                                  = 5
                                                                                ioctl(4, _IOC(0, 0, 0xb7, 0x22), 0x7fffd54a66a8) = 0
                                                                                ioctl(4, _IOC(0, 0, 0xb7, 0x22), 0x7fffd54a66a8) = 0
  ioctl(4, _IOC(0, 0, 0xb7, 0x22), 0x7fffd54a66a8) = 0
                                                      write(4<EMAIL_ADDRESS>182) = 182
                                                                                close(0)                                = 0
                                                                                close(1)                                = 0
   close(2)                                = 0
                                              rt_sigprocmask(SIG_BLOCK, [INT WINCH], NULL, 8) = 0
                                                                                signalfd4(-1, [INT WINCH], 8, 0)        = 0
                                                                                poll([{fd=4, events=POLLIN}, {fd=0, events=POLLIN}], 2, -1) = 1 ([{fd=4, revents=POLLIN}])
    read(4, "\10\0\0\0 \0\0\0\26\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", 32) = 32
                                                                                writev(2, [{iov_base="/wo/JSFormatter.exe: Invalid arg"..., iov_len=38}, {iov_base=NULL, iov_len=0}], 2) = -1 EBADF (Bad file descriptor)
                                                                                close(3)                                = 0
                                          close(4)                                = 0
                                                                                ioctl(5, SNDCTL_TMR_START or TCSETS, {B38400 opost isig icanon echo ...}) = 0
close(5)                                = 0
exit_group(1)                           = ?
+++ exited with 1 +++

For WSL launch issues, please collect detailed logs.

See our contributing instructions for assistance.

#3999


Spring profile management

I'm trying to "GraalVM-native"-ify the Spring PetClinic REST. I managed to fix expected configuration issues. However, I'm stuck now on Spring profiles.
The application offers several profiles: one set for data access and one for database. When I start the native image, I get the following:
Caused by: org.springframework.beans.factory.NoUniqueBeanDefinitionException: No qualifying bean of type 'org.springframework.samples.petclinic.repository.PetRepository' available: expected single matching bean but found 3: jpaPetRepositoryImpl,jdbcPetRepositoryImpl,springDataPetRepository
	at org.springframework.beans.factory.config.DependencyDescriptor.resolveNotUnique(DependencyDescriptor.java:220)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1358)
	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1300)
	at org.springframework.beans.factory.support.ConstructorResolver.resolveAutowiredArgument(ConstructorResolver.java:887)
	at org.springframework.beans.factory.support.ConstructorResolver.createArgumentArray(ConstructorResolver.java:791)
	... 34 more

While the JVM will automatically select the bean that matches the correct profile, the Native Image cannot.
I tried with the default command line and by passing -Dspring.profiles.active=jdbc. The logs display respectively the default profile and the jdbc one but the problem is the same.
I didn't find anything related to profile management in the documentation.

Hi Nicolas, could you please detail how do you pass -Dspring.profiles.active=jdbc in the native image variant? We can maybe improve the documentation indeed.

docker run -it --rm -p9966:9966 code-with:springboot -Dspring.profiles.active=jdbc

It seems as if at runtime, all candidate beans are part of the context and no profile-related filtering occurs.

I don't think passing -Dspring.profiles.active=jdbc to docker is expected to work, a quick test with a JVM image shows it does not.

You can use docker run --rm -e spring_profiles_active=jdbc ... instead. That's not specific to Spring Native so I won't document it there.

I've just done some tests with Spring Native 0.10.0 and I confirm that Spring profiles ( the org.springframework.context.annotation.Profile annotation to be exact) seem to be totally ignored.
I even tested using one bean with @Profile("azure") and another with @Profile("!azure") and I got the 2 available in my context! For me the annotation is simply ignored.

Let's re-evaluate that one after 0.11 which will change a lot of related things.

After digging into #888 - I think some of the problem here may simply be that there is no type hint for Profiles, so I've added it. Working on a test case at the mo.

@nfrankel Could you please do more tests with 0.10.2-SNAPSHOT?

Alright, I can try specifically on that pet clinic rest sample. I've been unable to create a profile problem with my playing around (doesn't mean there isn't one, I just can't in a simple case). @nfrankel do you by any chance have a fork of how far you've gotten it?

Sure https://github.com/nfrankel/spring-petclinic-rest/tree/native
Thanks for your help

I actually took Profile.class out again of our hints because I couldn't create a test case that didn't infer it automatically. However, this project is one of those cases :) So, I have added it back.
Without Profile in a hint the app fails in the way described. With Profile, it doesn't fail with that, it fails with something else. I think it is missing a bunch of config for other things (spring fox, swagger) - so I used the agent to collect that missing config. I tweaked it a little but it is still more verbose than it needs to be, the config is here:
https://github.com/aclement/spring-petclinic-rest/tree/native/src/main/resources/META-INF/native-image/a/b
I also modified the pom.xml in my fork so I could build locally without the docker buildpack need. With that config I can run:
mvn -DskipTests -Pnative clean package

Now I will say the app doesn't work for me (I get an error page for http://localhost:9966/petclinic - in either JVM or the native-image), so I've just been debugging startup and the app now starts for me.
I tried passing the jdbc profile and the app fails but I just think it is more missing configuration. I didn't run the JVM app with that profile and the agent to collect extra config, that could be a next step.
But I think the fundamental issue here, that profiles were misbehaving, is fixed. The addition of Profile/ActiveProfiles to the hints was the answer.

But I think the fundamental issue here, that profiles were misbehaving, is fixed. The addition of Profile/ActiveProfiles to the hints was the answer.

I'm a bit confused: should I do something, or is it on your side?

No, you don't need to do anything. The hints for the Profile/ActiveProfiles are built in now (0.10.2 snapshots). Your app can start without the error in the first comment of this issue. However, the app has other issues because we don't have defined configuration for all those other libraries.

No, you don't need to do anything
Perfect
However, the app has other issues because we don't have defined configuration for all those other libraries.
Yes, I started to configure those libraries

Thanks for your help!

I've just rebuilt the image using the latest snapshot:
mvnd -U clean spring-boot:build-image -DskipTests

I launch the application with profiles:
docker run -it --rm -p9966:9966 docker.io/library/code-with:springboot -Dspring.profiles.active=jdbc,hsqldb

I now have another kind of error:
[main] INFO org.springframework.nativex.NativeListener - This application is bootstrapped with code generated with Spring AOT

  .   ____          _            __ _ _
 /\\ / ___'_ __ _ _(_)_ __  __ _ \ \ \ \
( ( )\___ | '_ | '_| | '_ \/ _` | \ \ \ \
 \\/  ___)| |_)| | | | | || (_| |  ) ) ) )
  '  |____| .__|_| |_|_| |_\__, | / / / /
 =========|_|==============|___/=/_/_/_/
 :: Spring Boot ::                (v2.4.5)

[main] INFO org.springframework.samples.petclinic.PetClinicApplication - Starting PetClinicApplication using Java 1.8.0_292 on 92dc2ab6084f with PID 1 (/workspace/org.springframework.samples.petclinic.PetClinicApplication started by cnb in /workspace)
[main] INFO org.springframework.samples.petclinic.PetClinicApplication - The following profiles are active: jdbc,hsqldb
[main] WARN org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext - Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanDefinitionStoreException: Failed to parse configuration class [org.springframework.samples.petclinic.PetClinicApplication]; nested exception is java.lang.IllegalArgumentException: Could not find class [org.springframework.context.annotation.ProfileCondition]
[main] INFO org.springframework.boot.autoconfigure.logging.ConditionEvaluationReportLoggingListener -

Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
[main] ERROR org.springframework.boot.diagnostics.LoggingFailureAnalysisReporter -

***************************
APPLICATION FAILED TO START
***************************

Description:

Native reflection configuration for org.springframework.context.annotation.ProfileCondition is missing.

Action:

Native configuration for a class accessed reflectively is likely missing.
You can try to configure native hints in order to specify it explicitly.
See https://docs.spring.io/spring-native/docs/current/reference/htmlsingle/#native-hints for more details.

It seems I lack the reflection configuration for a Spring class (ProfileCondition)

As I recall, the app lacks many many different kinds of configuration (and when one is missing they won't all present in an obvious way like that). It'll be slow going unless you use the agent to collect them (are you using it?)
We could probably add ProfileCondition, but it'd be good to have a small test case for the usage.  Are you just going to manually add it locally for now?

Sorry for the delay, I'm back on it.
I've added the @ProfileCondition manually and I confirm I can go further (and fail because other things break).
In all cases, I do believe that if you want to improve the developer experience, it should be included in the out-of-the-box configuration. There are two use-cases:

Set the profile at compile-time and run the image with them
Compile with all profiles and set them at runtime

Let's try to see if we can allow to set AOT profiles with maybe predefined ones for aot ant aot-test in 0.11.1.

I tend to think this issue duplicates #1411 which provide a documented way to use profiles with the AOT engine.

Nitpick: the link to the documented way is wrong.

Oups fixed thanks.


"Bucșoaia" is listed in the drop-down menu

Description:
"Bucșoaia" is listed in the drop-down menu alongside its corresponding county according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Bucșoaia".

Expected results
The location is listed in the drop-down menu as "Sat Bucșoaia  SUCEAVA (Frasin)".


Can't tollerate error in first character in SingleError mode

It seems like errors in the first letter of a word are not handled even when SingleError mode is used.
For example Direball does not return results containing Fireball.
Test: https://leeoniya.github.io/uFuzzy/demos/compare.html?libs=uFuzzy&intraMode=1&intraIns=1&intraChars=[a-z\d%20]&outOfOrder&search=Direball
I found the intraSlice option and tried with [0, Infinite] but that didn't do the trick.

hmm, [0, Infinite] should do it :thinking:

this appears to be working?
https://jsfiddle.net/j7xkba1v/1/
let haystack = ["Fireball"];

let needle = "Direball";

let uf = new uFuzzy({
  intraMode: 1,
  intraIns: 1,
  intraDel: 1,
  intraTrn: 1,
  intraSlice: [0, Infinity],
});

let out = uf.search(haystack, needle);

console.log(out);

maybe you forgot to set the additional tolerances? (intraMode: 1 does not auto-enable them).

that being said, you probably dont want unconditional intraSlice: [0, Infinity], since typing a single letter will bring back the entire haystack. you most likely want these tolerance rules to be dynamic based on term length, which is what intraRules is for:
https://github.com/leeoniya/uFuzzy/blob/9486cf58cd937bc15082de217febfbf793bd589a/dist/uFuzzy.d.ts#L147-L154
the default intraRules already have some small-word gates that prevent a bad experience, so you may want to copy that fn and provide your intraSlice logic in addition to them:
https://github.com/leeoniya/uFuzzy/blob/9486cf58cd937bc15082de217febfbf793bd589a/src/uFuzzy.js#L150-L188

Thanks for the fast reply. I've noticed that the reason why my test with intraSlice: [0, Infinity] didn't work is because the string in the hackstack contained more than the needle word (think Fireball Test. It seems like it doesn't work as a partial/prefix match anymore.
So searching for Dire will match when the haystack is Fire but wont match if the haystack is Fireball. In the Fiddle you provided you can see this by changing the needle to Dire instead of Direball. If we instead search for Fire it will match Fireball just fine. Weirdly though the needles Direb or Direba and so on do return a match.
Thank you for pointing out the intraRules option though, that will be handy.

didn't work is because the string in the hackstack contained more than the needle word (think Fireball Test. It seems like it doesn't work as a partial/prefix match anymore.

replacing Fireball with Fireball Test in the haystack still works just fine for "Direball" needle. but as i explained above there is additional intraRules logic to make the matching more strict for terms <= 4 chars, which is probably why Dire does not work. maybe that default logic needs to be tweaked as it assumes intraSlice is the defaule [1, Infinity].

Oh sorry. I didn't understand the infraRules part correctly before. I see now that it has special logic for terms shorter than 5 characters which is why Dire was the cut-off point while Direb still worked.
Having run tests on my production haystack of roughly 25k entries I am definitely seeing considerably better results by overriding infraRules for short terms which would otherwise result in no matches at all. One example I saw was cork not matching a name starting with Cook County without the override. It does have side effects like changing the results that would have matches with and without this setting but in those cases it was sometimes hard to tell which one should be preferred.
I should point out though that in my application it is much worse to show no results than to show something that is not exactly a good match. When the haystack is big enough, it seems even short search terms will hit enough good results. On the flip side if results are omitted due to a single character error then that has a much higher negative impact on the user. We do start the search only if there are at least 2 characters. We then take the top N results and present them to the user.
So with the following options I'm seeing pretty decent results.
const opts = {
  intraMode: 1,
  intraChars: `[a-z\d' ]`,

  intraRules: () => {
    return {
      intraIns: 1,
      intraSub: 1,
      intraTrn: 1,
      intraDel: 1,
      intraSlice: [0, Infinity]
    };
  }
}

For longer search terms allowing more fuzzyness (e.g. 2 errors) could improve the results even further. But I think uFuzzy does not support that.

For longer search terms allowing more fuzzyness (e.g. 2 errors) could improve the results even further. But I think uFuzzy does not support that.

yeah more that 1 error is not really feasible since uFuzzy effectively constructs all possible regexp permutations of a single error for each term. those regexps can get pretty large already. any additional fuzziness would be too absurd for the current design 😅 . im happy with the tradeoff and outcome. people who need something different have quite a few oyher options to choose from.

Makes sense. It's pretty amazing and surprising that the regexp approach works as good as it does :)
The cork example might have not been the best but you can take cooj if you will. That's right next on the keyboard and just a single error (not event at the start) away but results in no matches. Cork could have been a typo introduced by a spelling auto correct I guess. Sometimes they are hurting rather than helping :)
This plus further testing where I saw results getting sometimes a bit too far from reasonable for very short terms have lead me to an approach that so far looks like a pretty good tradeoff:
I first do a search without the intraRules override and only when there are fewer than X (e.g. 10) results do I do another round but this time with the intraRules override. This has the benefit of returning better matches for short terms in the usual case and has noticably better performance (up to 10x faster) while still not missing matches that need a bit more fuzziness.

but i also used to live in Cook County, so i might be biased rofl

haha, what a funny coincidence :)


Incorrect locale 'en-US' used everywhere (Electron issue?)

VSCode Version: 1.50.1 (d2e414d9e4239a252d1ab117bd7067f125afd80a) x64
OS Version: ArchLinux x64 5.9.6

Today I upgraded electron from 9.3.3-1 to 9.3.4-1 and many extensions stopped working in VSCode, due to incorrect locale, eg. Python:

Probably it's related to https://github.com/electron/electron/issues/23272, but I want to let you know.

Same issue here, this message pops in integrated terminal, though it seems it didn't break anything in my setup.

Same here. For me it breaks lualatex compilation with LaTeX-Workshop extension.

This PR is backported to 9.3.4, could be the culprit https://github.com/electron/electron/pull/26185

The VS Code package on Arch Linux is a custom build. The current version of Electron of the official build is 9.3.3.  You should report this issue to Arch Linux.

https://github.com/microsoft/vscode/blob/a856e60a0cfcc9609f46855062162e8aa4b69c08/.yarnrc#L2
https://github.com/archlinux/svntogit-community/tree/packages/code/trunk

Arch Linux splits Electron from VS Code and always has the most recent version available from upstream. It looks like something broke in 9.3.4: https://github.com/electron/electron/issues/26443
So I guess we should wait for an update with a fix.

I opened that issue in electron's issue tracker after experiencing this exact problem in VS Code, so yes, that is the problem.

Great, meanwhile the latest Jupyter extension is not compatible with VS Code 1.45 and 1.51 has the LOCALE problems.

For anyone having this issue on Arch Linux, downgrade package electron9 from 9.3.4 to 9.3.3.
curl -O https://archive.archlinux.org/packages/e/electron9/electron9-9.3.3-1-x86_64.pkg.tar.zst
sudo pacman -U electron9-9.3.3-1-x86_64.pkg.tar.zst

You'll probably want to add electron9* to IgnorePkg in /etc/pacman.conf, so the next time you update your packages you won't accidentally update this one as well. When a fix has been deploy you can remove this setting...

@telmotrooper This works. Thanks!

@telmotrooper Thanks, be sure to also download the signature (https://archive.archlinux.org/packages/e/electron9/electron9-9.3.3-1-x86_64.pkg.tar.zst.sig) along the package and check pacman.conf so that LocalFileSigLevel = Required(or unset and SigLevel = Required), as you probably don't want to install unsigned packages.

You can also just do sudo pacman -U /var/cache/pacman/pkg/electron9-9.3.3-1-x86_64.pkg.tar.zst, as you probably have it still cached.

Just adding, for anyone looking for a low-hanging-fruit workaround, LC_ALL=en_US.UTF-8 code --lang=en_US.UTF-8 --set-lang=en_US.UTF-8 (ie. all of the LC_ALL environment variable, old --lang option that the blamed PR said didn't work, and --set-lang option that the PR appears to implement instead) still results in the en-US locale issue appearing in the first terminal you see.

Yep, because the Electron source code reads the locale passed from the command line, but then immediately overrides it:
https://github.com/electron/electron/blob/ef674025b5e17845e48a4d55721ea1a5583c4d04/shell/browser/electron_browser_main_parts.cc#L385-L387

The fix has been merged upstream: the next release will include the fix.

Closing this as vscode master is on 9.3.3 and the upstream issue was first observed in 9.3.4

Just adding, for anyone looking for a low-hanging-fruit workaround, LC_ALL=en_US.UTF-8 code --lang=en_US.UTF-8 --set-lang=en_US.UTF-8 (ie. all of the LC_ALL environment variable, old --lang option that the blamed PR said didn't work, and --set-lang option that the PR appears to implement instead) still results in the en-US locale issue appearing in the first terminal you see.

Is it possible to have VSC run a script or even a 1-liner before opening an intergrated terminal? I've seen similar issues back from 2016 which were solved by adding export LC_ALL=[whatever] to the shell configuration file (e.g. .bashrc), but I tried that and it didn't work.


Problem with contract in modules

Hi Nick, in Railsblcoks project, in entitities gem (https://github.com/railsblocks/railsblocks-entities), we are reusing a contract in two models, puting this in a module
https://github.com/jfreitasdutra/railsblocks-entities/blob/master/app/models/entities/manager/company/profile/contract.rb
the same for Entities::Organization https://github.com/jfreitasdutra/railsblocks-entities/blob/master/app/models/entities/organization/profile/contract.rb
But when I try to test the Entities::Profile::Contract isolated
https://github.com/jfreitasdutra/railsblocks-entities/blob/master/spec/models/entities/profile/contract_spec.rb
I can validate without ovveride methods :/. I tried test looking your test in reform and trailblazer gems.

You're overriding ::included in your contract module but you don't call super in it. I guess you misunderstood how a form module works.
module Contract
  include Reform::Form::Contract

  property ...
end

No need to add your own included logic.

Really, I made a mistake with included method. Now I just add a include of Reform::Form::Module on base because I use a nested modules. In this PR has a module with private methods to define the populators in lambda of properties, and one test for it.


Restore flow on device_tracker platform

Description:
I change the flow of restore a bit.
Actual:
[load device] -> (wait for restore) -> [write to statemachine] -> (wait for init platform) -> [Write found to statemachine] -> [setup others]

So we wait first until we have data for restore and write all thing to statemachine. After that we wait until all is setup and we have platform they need 15-60 seconds for it. And they also write found device to statemachine.
New:
[load device] -> (wait for init platform) -> [Write found to statemachine] -> [Setup others] -> ("Maby Wait" for restore only not seen entities) -> [Write only this to statemachine]

So we do not write the same device 2 times to statemachine and after we Setup all device tracker platforms, the db should finish to laod data for restore without waiting.
So we go more faster than now, and do things only once.

I think that will the best aprove. The flow is at the moment realy bad and setup slow. But I'm open for better handling.

This would be my perfect flow for the device tracker:

Load all devices that have track: yes in known_devices.yaml
Initialize tracker platforms and have them send their initial detected statuses
Restore state of devices that have not been seen yet by a tracker platform.
Write state to state machine

So I think that Pascal's flow is close, but still needs to skip restoring state if not necessary.

The tricky part with device tracker is that we own the entity implementation instead of the platform. So normally we let the platform decide the perfect approach but in this case we have to make 1 approach that fits all – which I think makes things complex.

It looks like Pascal is already implementing this flow btw. Note this line:
        for device in self.devices.values():
            if device.track and not device.last_seen:
                tasks.append(self.hass.async_add_job(
                    async_init_single_device(device)))```

I try to make the code cleaner. I think now is a bit more readable

Ah, could not see your whole comment on my phone.
I do think the method names could have been changed to make things a bit clearer though.

Naming can always be improved. We're not married to specific names since it's all internal API so suggestion welcome.


Mbs transform

What? and Why?

A new approach to transforming CS surveys, using the MBS survey as a starting point. Instead of using a list of tuples the transforms are now accessed via a mapping of question codes to transformations required in a Dictionary object. This has the advantage of being more obvious to anyone working on the code what transformations are taking place.

Checklist

[x] CHANGELOG.md updated? (if required)

Codecov Report

Merging #151 into master will decrease coverage by 0.72%.
The diff coverage is 76.71%.

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   85.76%   85.03%   -0.73%
==========================================
  Files          18       19       +1
  Lines         878      949      +71
==========================================
+ Hits          753      807      +54
- Misses        125      142      +17

Impacted Files
Coverage Δ

transform/transformers/__init__.py
100% <100%> (ø)
:arrow_up:

transform/transformers/cs_formatter.py
89.18% <66.66%> (-1.99%)
:arrow_down:

transform/views/main.py
66.91% <75%> (-0.26%)
:arrow_down:

transform/transformers/mbs_transformer.py
76.92% <76.92%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a86d07...120d56d. Read the comment docs.


export locales without renaming

This change updates the locale exports to not automatically append the .json suffix. The export pattern is a simple matching pattern as described in https://nodejs.org/api/packages.html#subpath-patterns and while friendly, it prohibits TypeScript from consuming the locales with its resolveJsonModule option which expect the import to have the .json suffix. Because the export is helpfully appending the .json suffix this results in a lookup of ./locale/<locale>.json.json which will then fail.
This PR as proposed is not backwards compatible and only one export can be provided on the left hand side. If backwards compatibility is desired then the packaging scripts can probably create copies of the files at the unsuffixed paths, but I'm not sure if that breaks some other loader that is looking at the resolved filename extension instead of the declared import.
related PR: https://github.com/d3/d3-format/pull/127

This is not needed anymore if your tsconfig can have the moduleResolution set to bundler


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter cec2 for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.cec2
   -
ERRORS:

[ ] :heavy_exclamation_mark: [E162] js-controller 3.3.22 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.

:thumbsup: No warnings found
SUGGESTIONS:

[ ] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 06 Sep 2024 07:12:19 GMT

Issue closed due to RECREATE request. Folloow up issue #191 has been created.
This issue can be closed.
your
ioBroker Check and Service Bot


Adding full support for swift 2.3

Changes:

Used Xcode 8 Beta 4 to convert to Swift 2.3
Took changes from previous Swift 3 changes to get code to compile within SSLSecurity.swift and WebSocket.swift
Started using recommended project settings per Xcode

👍 thanks!


⚠ Blog博客 has degraded performance

In 9aded4c, Blog博客 (https://blog.fangkehou.eu.org) experienced degraded performance:

HTTP code: 200
Response time: 6630 ms

Resolved: Blog博客 performance has improved in eacceb7.


Nuget in Powerapps Plugin Assemblies

Hi guys,
this documentation is somewhat confusing, as it is clearly not possible to add nuget references to Plugin Assemblies. Yet this page  describes it like its possible but not how. As far as i tried, even ilmerge or Fody doenst work anymore.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: edbeb418-f5d9-da8d-7598-d4965f666e50
Version Independent ID: f28b539d-69f1-5f2e-6f32-4248cb96eedf
Content: Sample: Custom virtual table provider with CRUD operations (Microsoft Dataverse) - Power Apps
Content Source: powerapps-docs/developer/data-platform/virtual-entities/sample-ve-provider-crud-operations.md
Service: powerapps
GitHub Login: @Nkrb
Microsoft Alias: nabuthuk

@SebastianAtWork Nuget packages in this context are being used to provide dependency references that exist server side already so that you can code against them.

I agree that it shouldn't be asked to be added if not used.

previously raised here: https://github.com/MicrosoftDocs/powerapps-docs/issues/2644

@NHelgren
This sample suggests that developers can depend on having NewtonSoft available on the sandbox service.
This is very risky and not supported.
Need to update this sample to use Dependent Assembly feature when it goes GA.


Catalog postgres-stash is not supported

I get the following error when trying to install the postgres-stash catalog.
Catalog postgres-stash is not supported

https://appscode.com/products/stash/v0.9.0-rc.0/guides/latest/auto-backup/database/#install-via-helm-chart

We haven't published the chart yet. We have to cut a release for KubeDB.

I'm assuming I have to wait a week before the release is cut?

@codejamninja we haven't published the charts yet. Some works still needs to be done before publishing. Btw, if you want to install from source here you go:

Chart: https://github.com/stashed/postgres/tree/master/chart/stash-postgres
How to try locally: https://github.com/stashed/catalog/blob/master/CONTRIBUTING.md

We are sorry for the confusion. We didn't want to block KubeDB release for this.


add support for leading ../ in patterns

Current Status
unsure if it's needed, will only merge if i see actual usecases in the wild that break without this.
if you need this, please let me know!

kinda hacky, but i can't think of anything else. has a notable performance hit if patterns start with ../ unless ignore options are better configured by the user
imagine you do the following:
glob(['../b/*.ts', '*.ts'], {
  cwd: 'users/me/projects/a'
});

// ['../b/a.ts', 'a.ts']

where the projects directory contains a/a.ts and b/a.ts, in addition to a node_modules folder bigger than god knows what.
in this case, tinyglobby infers a common root of users/me/projects, and it will start crawling every file under that root. this includes everything inside node_modules.
as such, it does some extra crawling that can make the whole thing potentially very slow. one solution for this would be for the user to manually ignore everything they don't want:
glob(['../b/*.ts', '*.ts'], {
  cwd: 'users/me/projects/a',
  ignore: ['../node_modules/**']
});

// ['../b/a.ts', 'a.ts']

this makes it fast again. thoughts?

someone's usecase is indeed breaking without this
https://github.com/unocss/unocss/issues/4094#issuecomment-2305317834


Grid fixed width

Sometimes ya just need a fixed width item in your grid (for a sidebar for example.
Thoughts on supporting this in the grid system and reflowing the width of non-fixed siblings?

NVM this does work its just not documented. I will close this and submit a PR for the docs.

Hi @mattapperson, I'm not really sure what you mean. Would you mind trying to explain it? Perhaps with screenshots


#309 - Custom Renderers

For issue #309: Add the ability to create custom renderers for both tags and suggestions

I would gladly do all the requested changes, but with another PR. I would not like to pollute this one with a lot of deestructuring. Do you agree @ad1992 ?

@cdreve I would prefer doing destruct in this pr only as its a part of this PR so it easy to review as well since I reviewed in this PR. Please push the commits of the other PR in this PR.

@ad1992 Could you please review the changes?

Hi @ad1992, please review the changes

@cdreve any updates?


Azure Egypt

Hi @John0Isaac . Welcome to the Global Azure 23. I just made my comments there. If you have any questions, let me know.
Thanks.

Hey @John0Isaac,
if you are replying to this using your email, you can use the "view it on Github" option, per image below, or open the PR using the link below and then see the history of comments.

https://github.com/globalazure/communities/pull/214

@hugobarona I did that but I can't seem to find anything you want me to change in the code.
Are you able to merge or not?

@John0Isaac if you use the link I provided before, you should be able to access my comments, as per image below.
We just need a couple of changes and we should be good to go please.

@hugobarona I did remove the template file is it still visible at your end?

The template file is deleted. Thank you. Now the only change left is the Sessionize API configuration to change API Format for json, if that's ok.
Thanks

@hugobarona Done!
Thanks for your time.

Looks good @John0Isaac . Thank you very much.

@hugobarona @John0Isaac THIS is community. Wonderful work gentlemen!


Improve versioning mechanics

Provide the following make directives:

major
minor
patch
update

Which automatically increment the current version.

done https://github.com/arthurpaulino/miraiml/commit/d95f9b5754a1ce3c923bde7f21da067e748459c2


fix: Update procedure.ts to return type if it is there on procedure definition

Fixes https://github.com/jlalmes/trpc-openapi/issues/431

Can we please get a quick approval on this fix?


fix: use a temporary file to host the new instance manager binary

Avoid using an hardcoded file name to store the newly uploaded
instance manager, preventing a possible race condition to happen.
Closes #659

This code is based on #655, and should be merged after it and rebased over the latest main.

/test

/ok-to-merge

/ready-to-test

/ready-to-test


Calendar event's Equals and GetHashCode methods don't match

Equals() considers attachments. GetHashCode does not.

The RFC allows attachments on all calendar components. I.e.:

Event
To-Do
Journal
Free/Busy
Time Zone
Alarm

So I'll drive through and make sure GetHashCode() and Equals() consider the appropriate properties, since I noticed that Alarm does not.

In nuget packages:

2.2.35
3.0.4-net-core-alpha


Beatmap/profile linking functionality + timestamp linking

Yes

@ThePooN when u deploy let me know so i can turn off maquia's stuff in the corsace server


/imports/granularity/group: unknown variant last, expected one of preserve, item, crate, module

Hello, when I open a *.rs file, I encountered this error.

I pull the lastest commit and the error suddenly disappeared.


Improve the settings of AnnubesEnv

 @gcroci2 cloned issue ANNUBS/neurogym#68 on 2024-11-18:

We need to organize in a clearer way the setting of AnnubesEnv (and likely, all the envs). Dataclasses did not convince me completely (see the discussion in https://github.com/ANNUBS/annubes/issues/36) and I think we should look for which are the best options around. This is for a later stage, when the entire training pipeline will be in place.

@gcroci2 @DaniBodor I will take this on if you have no objections. I designed a solution for this already while working on the weight extraction & tracking issue, and I realised that it can be used for configuring environments in a very generic way (quite in line with what @DaniBodor mentioned about using mixins).

@DaniBodor I cannot seem to be able to change the status of issues - perhaps I don't have the permissions? I'd like to move this to "In progress".

@gcroci2 @DaniBodor I cannot seem to be able to change the status of issues - perhaps I don't have the permissions? I'd like to move this to "In progress".

I made you an admin (I just double checked), so you should have the same rights as us. I usually drag and drop the issue from one column to another in the project board. Alternatively, inside the issue on the right, the status has a drop down menu, where you can change it. Does neither of this work for you?

Thank you for looking into this. I tried both of those methods before I posted the comment, but indeed I couldn't drag and drop (and still can't), and the status dropdown was (and still is) greyed out. Weird! I even logged out and back in - no change.🤔

I moved this issue to "In Progress" now. Indeed it's weird that it's not working for you! We can look at it together after the holidays if the issue persists.

I suspect that I might have to be a member of the organisation - right now I think I'm only a member of the project but not the org...

I suspect that I might have to be a member of the organisation - right now I think I'm only a member of the project but not the org...

That makes sense! I've just invited you

Yes, that was it! I can change the status now. Thank you for resolving this!🖖🤓


rename deploy script and lint. Add HH contracts

Deployment of contracts to testnet(s) before merging.


@types packages should be in devDependencies

Subject of the issue
There is the same problem as https://github.com/unifiedjs/unified/issues/45 in the vfile package.
https://github.com/vfile/vfile/blob/8f474a27c6347558dc62a67af0de90eaa58ab6fa/package.json#L35
I think that the @types/unist dependency should be in devDependencies instead of dependences.
Your environment

OS: macOS Mojave version 10.14.5
Packages<EMAIL_ADDRESS>(latest)
Env: Node 12.6.0 / npm 6.10.1 / npx 6.10.1

Steps to reproduce
Please execute the following commands in your terminal:
$ mkdir work

$ cd work

$ echo '{}' > package.json

$ npm install<EMAIL_ADDRESS><EMAIL_ADDRESS>...

$ echo 'var a = 1' > test.ts

$ npx tsc test.ts
node_modules/@types/unist/index.d.ts(31,20): error TS2304: Cannot find name 'unknown'.
node_modules/@types/unist/index.d.ts(40,20): error TS2304: Cannot find name 'unknown'.
node_modules/@types/unist/index.d.ts(97,12): error TS2304: Cannot find name 'unknown'.

Expected behaviour
TypeScript compilation should be successful also with older versions (e.g. 2.9.2).
Actual behaviour
TypeScript compilation with the version 2.9.2 fails.
It would be great if the problem could be solved!
Thanks.

I think that makes sense, but: why use a one year old version of typescript? 🤷♂

Thanks for your quick reply!

why use a one year old version of typescript? 🤷♂

I think that widely-used tools such as ts-loader usually need to support quite old versions, for example, for enterprise needs. 😅
(but I don't know real reasons...)
Please see the ts-loader CI configuration:
https://github.com/TypeStrong/ts-loader/blob/53f198f4c425a6e14f0be15cc3a1f57b8f969c69/.travis.yml#L17-L29

OK, well a PR like https://github.com/unifiedjs/unified/commit/3aa5737dac718451b804a4e19526c5cdc268671e would be welcome!

I think that the @types/unist dependency should be in devDependencies instead of dependences

:+1:

TypeScript compilation should be successful also with older versions (e.g. 2.9.2).

@ybiquitous to be clear, the latest versions of vfile, unified, and remark only support Typescript 3.
If they by any chance happen to work on TypeScript 2, great, but that is pure happenstance.
You should operate under the assumption that using latest TypeScript 2 will not work.
If you need a guarantee that it will work, please use the previous major version.

I think it’s weird that TS complains about stuff it doesn’t understand when it doesn’t need to. TS isn’t used when linting with remark-cli and remark-validate-links 🤷♂

I think that widely-used tools such as ts-loader usually need to support quite old versions, for example, for enterprise needs.

ts-loader does support TypeScript 2.
However their documentation guides people to install latest, and for building ts-loader they are using TypeScript 3.
Again, if TypeScript 2 support is needed, use vfile version 3, and upgrade to vfile version 4 when also upgrading TypeScript to version 3.

@ChristianMurphy Thanks for your kind response!
I think your idea (the updating policy) makes sense and I agree with you. 👍
Because ts-loader is a special tool for the TypeScript compilation, I think the tool may be forced to support widely versions (see the peerDepdendencies).
Anyway, if @types/* dependencies would be removed, remark as a linter would be successful. Unless, I'll give up using remark on ts-loader for linting. 😅

@ybiquitous a couple thoughts. :thought_balloon:
First, remark version 11 (CLI version 7) is the first that requires TypeScript 3, remark version 10 (CLI version 6) should still support still support TypeScript 2, if there are dependencies that don't we can work with you to lock those down, so TypeScript 2 support is preserved on the previous major version
Second for using remark-lint remember that you are testing markdown, not typescript.
What I've done in the past, is run remark-lint on only one of the configurations in the build matrix, since Node, TypeScript, and other libraries have no bearing on validity of markdown.
You could run remark-lint 11 only in a TypeScript 3 build.
Y

@ChristianMurphy Thanks, I understand your thoughts, so I get the following solution, for example:
# .travis.yml
install:
  # ...
  - |
    if [ "$TYPESCRIPT" ==<EMAIL_ADDRESS>]; then
      yarn add --dev remark-cli remark-validate-links && npx remark -u validate-links . ;
    fi
  - yarn add $TYPESCRIPT
env:
  -<EMAIL_ADDRESS>
Pros:

ts-loader don't need to add dependencies for remark.
The CI builds become fast because the lint is executed for only one job.

Cons:

Some tricky.
Executions on each local machine become slow because the installation is performed on every lint.
No lockfile support (e.g. yarn.lock).

Is the idea suit for your thoughts?
If so, I don't know whether the ts-loader team accept the bit tricky solution, but I'll suggest it. 💪

Is the idea suit for your thoughts?

Exactly :+1:

If so, I don't know whether the ts-loader team accept the bit tricky solution, but I'll suggest it. :muscle:

Worth a try, if not remark 10 is always an option.

@ChristianMurphy Do you suggest still moving the dependencies to dev-dependencies?

If it's just for TypeScript 2 support, lean towards not removing @types/unist.
It's nice to get @types/unist automatically, without needing an extra install step.

Alright, and (how) is that different from https://github.com/unifiedjs/unified/issues/45?

It isn't, and I'd like to re-add the dependency there as well.

So from both threads, this here, and GH-37, I see mixed feelings.
@ChristianMurphy, @Rokt33r, do you suggest going ahead with this and merging GH-37, if it has docs, or instead rejecting this?

@wooorm to clarify my position.
I am okay with merging #37.
However, it is not the approach I would prefer, because further downstream, people will need to know to install @types/unist, that could happen any number of layers downstream, anyone using typescript with remark, rehype, retext, mdx, or redot, directly or indirectly, will be affected.

I think that makes sense, so closing these two!

I would prefer to put it in devDependencies. But I don't think it is that important. As long as people using Parcel or Webpack, the type definitions won't be included to compiled code anyway. So I guess we could just leave it for now.


(Un)install scripts missing shebang

The scripts included in releases for installing and uninstalling the Ledger app doesn't work as an executable in some environment (macOS + fish shell, for example) because it doesn't have a shebang. When running as-is, users will see the following output:
❯ ./install.sh
Failed to execute process './install.sh'. Reason:
exec: Exec format error
The file './install.sh' is marked as an executable but could not be run by the operating system.

The solution is to add a shebang at beginning of install.sh, and uninstall.sh:
#!/bin/sh

...

Fixed by 1f2acf7bbdcad7f1480c31bde039ba7d75da0c08


Automatic spa configuration - validation/testing/fixing

Please use this thread to report your config, from the log:
[My Hot Tub] ControlPanelRequest Sending:7e,08,0a,bf,22,00,00,01,58,7e
[My Hot Tub] Control panel reply(0a,bf,2e):1a,00,01,90,00,00
[My Hot Tub] Discovered 3 pumps with speeds [ 2, 2, 1, 0, 0, 0 ]
[My Hot Tub] Discovered lights: [ true, false ] circ_pump true blower false mister false aux [ false, false ]
[My Hot Tub] ConfigRequest Writing:7e,05,0a,bf,04,77,7e
[My Hot Tub] Config reply(0a,bf,94):02,14,80,00,15,27,3f,9b,95,00,00,00,00,00,00,00,00,00,15,27,ff,ff,3f,9b,95
For me the above is correct: 3 pumps with the speeds shown above, and 1 light, (no blower, mister, etc).

[My Spa] Control types reply(0a,bf,2e):05,00,01,90,00,00
[My Spa] Discovered 2 pumps with speeds [ 1, 1, 0, 0, 0, 0 ]
[My Spa] Discovered lights: [ true, false ] circ_pump true blower false mister false aux [ false, false [My Spa] Config reply(0a,bf,94):02,14,80,00,15,27,3f,99,07,00,00,00,00,00,00,00,00,00,15,27,ff,ff,3f,99,07
Looks good to me.

Updated with my latest log output, as an example for future commenters:
[5/20/2020, 12:21:18 AM] [My Hot Tub] Control types reply(0a,bf,2e):1a,00,01,90,00,00
[5/20/2020, 12:21:18 AM] [My Hot Tub] Discovered 3 pumps with speeds [ 2, 2, 1, 0, 0, 0 ]
[5/20/2020, 12:21:18 AM] [My Hot Tub] Discovered 1 light
[5/20/2020, 12:21:18 AM] [My Hot Tub] Discovered other components: circ_pump true blower false mister false aux [ false, false ]
[5/20/2020, 12:21:19 AM] [My Hot Tub] Control Panel reply 1:14,00,01,1e,88,00,01,1e
[5/20/2020, 12:21:20 AM] [My Hot Tub] Control Panel reply 2:64,e1,24,00,4d,53,34,30,45,20,20,20,01,c3,47,96,36,03,0a,44,00
[5/20/2020, 12:21:20 AM] [My Hot Tub] Spa motherboard model MS40E
[5/20/2020, 12:21:21 AM] [My Hot Tub] Control Panel reply 3:05,01,32,63,50,68,61,07,41
[5/20/2020, 12:21:22 AM] [My Hot Tub] Control Panel reply 4:00,85,00,01,01,02,00,00,00,00,00,00,00,00,00,00,00,00
[5/20/2020, 12:21:33 AM] [My Hot Tub] Config reply with MAC address (0a,bf,94):02,14,80,00,15,27,3f,9b,95,00,00,00,00,00,00,00,00,00,15,27,ff,ff,3f,9b,95

On an unrelated note: when the spa is in rest mode and not actively filtering, it does not measure the temperature, though the status on the Home App says “100C”. Is this able to be changed?

Hmm - interesting. Mine doesn't run in Rest mode so hard to tell. Can you run Homebridge in debug mode:

and raise a new GitHub issue with the details of your log, while you take some actions (e.g. try turning lights on/off, try turning the mode from rest to ready and back to rest)?  Hopefully the details in the log will let us understand what is going on so we can find a way to fix that.  Also, on the Spa's physical control panel, what does it tell you there (about temperature) when in this situation?

Mine is running okay but after a while I get some errors in the log file.
[7/4/2020, 11:40:53 AM] [Bubbelbad] Discovered a Spa at <IP_ADDRESS>
[7/4/2020, 11:40:53 AM] [Bubbelbad] Successfully connected to Spa at <IP_ADDRESS> on port 4257
[7/4/2020, 11:40:53 AM] [Bubbelbad] Control types reply(0a,bf,2e):05,00,01,91,00,00
[7/4/2020, 11:40:53 AM] [Bubbelbad] Discovered 2 pumps with speeds [ 1, 1, 0, 0, 0, 0 ]
[7/4/2020, 11:40:53 AM] [Bubbelbad] Discovered 1 light
[7/4/2020, 11:40:53 AM] [Bubbelbad] Discovered other components: circ_pump true , blower 1 , mister undefined , aux [ false, false ]
[7/4/2020, 11:40:53 AM] [Bubbelbad] Autocreating accessories...
[7/4/2020, 11:40:53 AM] [Bubbelbad] Pump 1 has 1 speeds.
[7/4/2020, 11:40:53 AM] [Bubbelbad] Pump 2 has 1 speeds.
[7/4/2020, 11:40:53 AM] [Bubbelbad] Blower has 1 speeds.
[7/4/2020, 11:40:54 AM] [Bubbelbad] Control Panel reply 1:0b,0f,01,1e,97,0f,01,1e
[7/4/2020, 11:40:54 AM] [Bubbelbad] First filter time from 11:15 for 01:30
[7/4/2020, 11:40:54 AM] [Bubbelbad] Second filter time on from 23:15 for 01:30
[7/4/2020, 11:40:55 AM] [Bubbelbad] Control Panel reply 2:64,e1,25,00,4e,42,50,32,31,30,30,48,08,09,d8,67,69,03,0a,1e,00
[7/4/2020, 11:40:55 AM] [Bubbelbad] System Model NBP2100H
[7/4/2020, 11:40:55 AM] [Bubbelbad] SoftwareID (SSID) M100_225 V37.0
[7/4/2020, 11:40:55 AM] [Bubbelbad] Current Setup 8
[7/4/2020, 11:40:55 AM] [Bubbelbad] Configuration Signature 09D86769
[7/4/2020, 11:40:56 AM] [Bubbelbad] Control Panel reply 3:0a,08,32,63,50,68,61,03,41
[7/4/2020, 11:40:57 AM] [Bubbelbad] Control Panel reply 4:00,85,00,01,01,02,00,00,00,00,00,00,00,00,00,00,00,00
[7/4/2020, 11:40:58 AM] [Bubbelbad] No recent faults. Last fault 14 days ago of type M037 = hold mode activated (this is not actually a fault) with details from log: Fault Entries: 24 , Num: 24 , Error code: M037 , Days ago: 14 , Time: 21:19 , Heat mode: 24 , Set temp: 35 , Temp A: 35 , Temp B: 35
[7/4/2020, 11:41:08 AM] [Bubbelbad] Config reply with MAC address (0a,bf,94):02,14,80,00,15,27,3b,48,a2,00,00,00,00,00,00,00,00,00,15,27,ff,ff,3b,48,a2
[7/4/2020, 5:54:37 PM] [Bubbelbad] Bad checksum  233 for [
'7e', '1d', 'ff', 'af', '13',
'00', '00', '46', '11', '35',
'00', '00', '3c', '06', '03',
'04', '00', '00', '00', '00',
'00', '00', '00', '00', '00',
'46', '00', '00', '00', 'e9',
'7e'
]
[7/5/2020, 12:00:58 AM] [Bubbelbad] No recent faults. Last fault 15 days ago of type M037 = hold mode activated (this is not actually a fault) with details from log: Fault Entries: 24 , Num: 24 , Error code: M037 , Days ago: 15 , Time: 21:19 , Heat mode: 24 , Set temp: 35 , Temp A: 35 , Temp B: 35
[7/5/2020, 5:14:44 PM] [Bubbelbad] Bad checksum  120 for [
'7e', '1d', 'ff', 'af', '13',
'00', '00', '46', '11', '0d',
'00', '00', '3c', '06', '03',
'04', '00', '00', '00', '00',
'00', '00', '00', '00', '00',
'46', '00', '00', '00', '78',
'7e'
]
[7/5/2020, 5:14:47 PM] [Bubbelbad] Bad checksum  211 for [
'7e', '1d', 'ff', 'af', '13',
'00', '00', '46', '11', '0d',
'00', '00', '3c', '06', '03',
'04', '00', '00', '00', '00',
'00', '00', '00', '00', '00',
'46', '00', '00', '00', 'd3',
'7e'
]
[7/5/2020, 5:17:41 PM] [Bubbelbad] Bad checksum  undefined for [
'7e', '7e', '1d', 'ff', 'af', '13', '00',
'00', '46', '11', '10', '00', '00', '3c',
'06', '03', '04', '00', '00', '00', '00',
'00', '00', '00', '00', '00', '46', '00',
'00', '00', 'bf', '7e', '7e', '1d', 'ff',
'af', '13', '00', '00', '46', '11', '10',
'00', '00', '3c', '06', '03', '04', '00',
'00', '00', '00', '00', '00', '00', '00',
'00', '46', '00', '00', '00', 'bf', '7e'
]
[7/5/2020, 5:17:41 PM] [Bubbelbad] Not understood a received spa message  (nothing critical, but please do report this):1d,ff,af  contents: 13,00,00,46,11,10,00,00,3c,06,03,04,00,00,00,00,00,00,00,00,00,46,00,00,00,bf,7e,7e,1d,ff,af,13,00,00,46,11,10,00,00,3c,06,03,04,00,00,00,00,00,00,00,00,00,46,00,00,00,bf,7e
[7/5/2020, 5:19:17 PM] [Bubbelbad] Bad checksum  103 for [
'7e', '1d', 'ff', 'af', '13',
'00', '00', '46', '11', '12',
'00', '00', '3c', '06', '03',
'04', '00', '00', '00', '00',
'00', '00', '00', '00', '00',
'46', '00', '00', '00', '67',
'7e'
]

Thanks - on those bad checksum errors and not-understood messages - I get those occasionally too. My impression is that the spa-wifi-module has bugs and is sending those messages offset by 1 or 2 bytes and therefore wrong. They seem to be rare enough that not a cause for concern, and don't seem to meaningfully impact functionality.

Yes that's correct. I don't see any impact on functionality when these errors appear in the log. Thanks for this plugin. Really enjoying it!

Hi- I am the author of a node-red flow that uses mqtt on home bridge to control my spa, and thanks for making this plugin! I have 2 things to comment on.
1 - ideally the lock should stop the pumps - the way I implemented the lock on my setup was to shut the spa down for the night or week. I would stop all the pumps, put it in low heat more, and set it to rest mode. So I didn't have to worry I left something or not. I noticed yours will prevent state changes but doesn't stop pumps/lights. Just a suggestion.
2 - I am getting these errors:
[9/7/2020, 8:19:59 AM] [Spa] System Model MBP501UX
[9/7/2020, 8:19:59 AM] [Spa] SoftwareID (SSID) M100_201 V44.0
[9/7/2020, 8:19:59 AM] [Spa] Current Setup 7
[9/7/2020, 8:19:59 AM] [Spa] Configuration Signature A82F6383
[9/7/2020, 8:20:00 AM] [Spa] Control Panel reply 3:09,07,32,63,50,68,49,0f,41,02
[9/7/2020, 8:20:01 AM] [Spa] Control Panel reply 4:00,87,00,00,01,08,00,00,01,00,00,00,00,00,00,00,00,00
[9/7/2020, 8:25:27 AM] [Spa] Bad checksum  111 for [
'7e', '20', 'ff', 'af', '13',
'14', '03', '58', '08', '18',
'01', '0a', '58', '58', '36',
'0c', '00', '00', '02', '00',
'00', '00', '00', '01', '20',
'50', '09', '00', '00', '00',
'00', '00', '6f', '7e'
]
[9/7/2020, 8:25:49 AM] [Spa] Bad checksum  91 for [
'7e', '20', 'ff', 'af', '13',
'14', '03', '58', '08', '18',
'01', '0a', '58', '58', '36',
'0c', '00', '00', '02', '00',
'00', '00', '00', '01', '20',
'50', '09', '00', '00', '00',
'00', '00', '5b', '7e'
]
[9/7/2020, 8:26:00 AM] [Spa] Bad checksum  56 for [
'7e', '20', 'ff', 'af', '13',
'14', '03', '58', '08', '19',
'01', '0a', '58', '58', '36',
'0c', '00', '00', '02', '00',
'00', '00', '00', '01', '20',
'50', '09', '00', '00', '00',
'00', '00', '38', '7e'
]
[9/7/2020, 8:26:14 AM] [Spa] Bad checksum  53 for [
'7e', '20', 'ff', 'af', '13',
'14', '03', '58', '08', '19',
'01', '0a', '58', '58', '36',
'0c', '00', '00', '02', '00',
'00', '00', '00', '01', '20',
'50', '09', '00', '00', '00',
'00', '00', '35'
]
[9/7/2020, 8:27:14 AM] [Spa] Bad checksum  undefined for [
'7e', '7e', '20', 'ff', 'af', '13', '14', '03', '58', '08',
'1a', '02', '0a', '58', '58', '36', '0c', '00', '00', '02',
'00', '00', '00', '00', '01', '20', '50', '09', '00', '00',
'1e', '00', '00', 'ab', '7e', '7e', '20', 'ff', 'af', '13',
'14', '03', '58', '08', '1a', '02', '0a', '58', '58', '36',
'0c', '00', '00', '02', '00', '00', '00', '00', '01', '20',
'50', '09', '00', '00', '1e', '00', '00', 'ab', '7e', '7e',
'20', 'ff', 'af', '13', '14', '03', '58', '08', '1a', '02',
'0a', '58', '58', '36', '0c', '00', '00', '02', '00', '00',
'00', '00', '01', '20', '50', '09', '00', '00', '1e', '00',
... 3 more items
]
[9/7/2020, 8:27:14 AM] [Spa] Not understood a received spa message  (nothing critical, but please do report this):20,ff,af  contents: 13,14,03,58,08,1a,02,0a,58,58,36,0c,00,00,02,00,00,00,00,01,20,50,09,00,00,1e,00,00,ab,7e,7e,20,ff,af,13,14,03,58,08,1a,02,0a,58,58,36,0c,00,00,02,00,00,00,00,01,20,50,09,00,00,1e,00,00,ab,7e,7e,20,ff,af,13,14,03,58,08,1a,02,0a,58,58,36,0c,00,00,02,00,00,00,00,01,20,50,09,00,00,1e,00,00,ab,7e
[9/7/2020, 8:28:45 AM] [Spa] Bad checksum  59 for [
'7e', '20', 'ff', 'af', '13',
'14', '03', '58', '08', '1b',
'02', '0a', '58', '58', '36',
'0c', '00', '00', '02', '00',
'00', '00', '00', '01', '20',
'50', '09', '00', '00', '1e',
'00', '00', '3b', '7e'
]

Thanks for the "lock" suggestion, to make that more of a one-click action to solve a specific use-case. My plugin at the moment simply replicates the on-panel "lock" capability, but actually what you describe is more sensible, I think. So I'll implement that at some stage.
On the checksums, there seem to be two cases here. Case (A): The first 3 examples, and the last, that you gave, seem to be well-formed messages (starting/ending with 7e, a length byte in position 1, and the checksum last-1). So why is the checksum wrong for these? Is it genuinely that data is being corrupted? Very unclear to me. I do not believe I ever see cases like this with my spa.
The other examples, case (B), seem to be caused by something going wrong at the transport-layer level.  The 4th example you give is not terminated by 7e (and you could argue that the 7e byte has somehow slipped into your 5th example, which wrongly starts with two 7e bytes). I do see these kinds of cases from time to time with my spa.  It is unclear to me what causes this problem, and is it a "bug" in my plugin's interpretation of the socket data (or use of the socket), or a bug in the Balboa wifi module which sends incomplete messages down the socket (in theory my plugin could notice a message is incomplete, cache it, and wait for the rest, for example).  If you have input into this, I'd appreciate it (especially given your experience with your node-red implementation).

Latest release will log cases A/B differently, if you'd like to test.

Latest release (2.0.21) has some further improvements, which should now fix all of the 'case (B)' examples.

I am using this plugin with HOOBS.  Love this plugin with one exception.  Unlike the Spa Flow/Leak Sensor, I am unable to configure the Temperature Sensor in Apple Home to send me a notification based on a change in its value/state.  Is there a way to change the Temp Sensor code to make it so that Apple Home allows one to configure notifications for it based on rules?  Specifically, I would like to receive a notification when the temperature exceeds a certain level, such as to know when the tub reaches temp setting after a refill or some other circumstance that may have cooled the water.

I've clarified the documentation on this. You'll have to create Homekit automations/shortcuts to provide any notifications on temperature.


Make Preview 8 Quickstart Sha256 the Multiplatform Manifest

What
Change the sha256 digest hash for the quickstart image in preview 8 to be the digest of the multiplatform manifest instead of the amd64 digest.
Why
We can reference the multiplatform manifest which will cause clients to pick the right platform. We don't need to specify the amd64 or arm64 manifest specifically.
Note that the multiplatform manifest is not visible in the Docker Hub UI, which can be reasonable confusing. The only way to find out the multiplatform manifest hash is to look at the logs of the manifest push GitHub Action Job. For an example, see here: https://github.com/stellar/quickstart/actions/runs/4609937251/jobs/8148632141#step:7:10

Preview is available here:http://soroban-docs-pr362.previews.kube001.services.stellar-ops.com/


Dashboard – Feed - PopUp – Update version

When a new version is pushed - next time the user is on his dashboard - Show this pop up ( It's without the 'x' button)
https://xd.adobe.com/spec/8f259bcd-550e-4f0c-40bb-bdce2ed36fe5-f914/screen/45a95260-84f7-4a20-9722-49a67ca14a1f/Dashboard-Feed-PopUp-Update-version

"what's new?" should link to ChangeLogFy - link to https://gdlr.info/newversion

@AnastasiiaOdnoshevna done as part of #795

Checked on the Dev environment
Look as expected.


fix: broadcast in op_mul

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.14%. Comparing base (df9fe1f) to head (82bc2a3).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   68.14%   68.14%
=======================================
  Files          80       80
  Lines         700      700
=======================================
  Hits          477      477
  Misses        223      223

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix an assertion failure with XCFramework inside a subdirectory

Fix an assertion failure that occurred when a local XCFramework was at a subdirectory (the path in the manifest can be a relative path and not just a path component).

@swift-ci please smoke test


Rio Chart Support

Need to make sure Rio functions in the new catalog.

PR exists:  https://github.com/rancher/rancher/pull/32228

Will revisit after v2.6.5 and decide whether this is needed.


class_double and is_a? Class

Hey @myronmarston, hope you're doing fine? Recently I tried to use class_double and stub_const.
    let!(:another_test_event_klass) do
      class_double('Events::AnotherTestEvent').tap do |double|
        stub_const('Events::AnotherTestEvent', double)
        allow(double).to receive(:new).and_return(another_test_event_instance)
      end
    end

    let!(:another_test_event_instance) do
      class_double('Events::AnotherTestEvent').tap do |double|
        stub_const('Events::AnotherTestEvent', double)
      end
    end

Somewhere in the code I would like to do the following:
klass = event.is_a? Class ? event.to_s : event.class.to_s

I read your comments in #794, but maybe this use case is different. From my understanding an class_double should return true if some asks it, if it is a class?

You have to stub is_a? to return true, it's an instance of a ClassVerifyingDouble and we don't lie to Ruby so you'll have to do this manually:
allow(double).to receive(:is_a?).with(Class) { true }

Ok. Sure. Damn...


apt: 1.4.6 -> 1.8.4

Motivation for this change
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[X] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Determined the impact on package closure size (by running nix path-info -S before and after)

/nix/store/p8dkrms4nijj7gvcvfk9v2hm1acv2kcd-apt-1.4.6	  136146232
/nix/store/h9zk42aqcab4z2gj1j2hy9gy8vbfz6hn-apt-1.8.4	  148277800

[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Notify maintainers
cc @

I cannot reproduce your segfaults. Do you get them with the old version as well?
[root@hydra:~/nixpkgs]# NIX_PATH=nixpkgs=$(pwd) nix-shell --pure -p apt --command "apt --version"
apt 1.8.4 (amd64)
E: Unable to determine a suitable packaging system type

[root@hydra:~/nixpkgs]# NIX_PATH=nixpkgs=$(pwd) nix-shell --pure -p apt --command "apt"
E: Unable to determine a suitable packaging system type

[root@hydra:~/nixpkgs]# NIX_PATH=nixpkgs=$(pwd) nix-shell --pure -p apt --command "apt-config"
E: Unable to determine a suitable packaging system type

I just get the
E: Unable to determine a suitable packaging system type

using the current master

Odd... I don't know how to replicate your failure with 1.8.4 here. Nor do I understand what would make something work for me and not you here. We should be loading the same exact libraries, and I am using this in several different environments.
Can you shed some information on your test machine?

at work I get
[nix-shell:~/.cache/nix-review/pr-69571-2]$ ./results/apt/bin/apt --help
E: Unable to determine a suitable packaging system type

This may be from issues with a sandbox environment at my home computer, and not actually related to this PR :(

I'm getting segfaults with all binaries too ... :/ in a x86-64 NixOS VM


Changed getCount to count.

Hey  ireally enjoy this package and got me exactly what I was wanting. I apologize I am not extremely familiar with Laravel and its changes. Recently picked it up about a month ago.
I was trying to implement pagination, but was getting the error
 "Bad Method Call"
Method Illuminate\Support\Collection::getCount does not exist.

Followed the code and found ->count() returned the results count. I do not know if maybe this was a Laravel change? Or if I'm just completely missing it and how i'm supposed to change it. But I googled for a bit and could not find a getCounty() for Laravel collections. For more context I'm running at Laravel 7.11.0. Would love to see this get merged so I do not have to side load this package and hopefully it helps others, without breaking it for anyone else. If I missed the mark of this and someone has a better suggestion I don't mind implementing it.( Maybe a check for older versions of Laravel that did use getCount?).
Thanks!

Hi there, I came here to write the same than you, I was experiencing the same issue while trying to paginate results in laravel, but in my case using count() didn't solved the issue. instead, i used:
       return $results->first();
Given that first element of the collection, is the totalCount.
If i am not wrong, the count method that you used, returns the number of total elements in the collection, that is two, one field for count and another field for documents...
Hope it helps.


Allow specifying of "project-dir"

Want:
--project-dir cli argument.
Explanation:
Similar to dbt run --project-dir my-project/, I want to be able to parse and lint my project in a single command.
My current workaround is to run dbt parse ... then point to the manifest. But I'd rather have a single command.

Thanks for reporting and sharing your use-case!
Out of curiosity, does dbt-score run in the same virtual environment as dbt? (alternatively, does dbt run in a virtual environment, or is it installed system-wide?)
dbt-score makes use of the environment variable DBT_PROJECT_DIR to look for the dbt project. However I'm afraid it only works if that variable is a relative path appended to the current working directory, but making it work with absolute paths should be very easy
Ref: https://github.com/PicnicSupermarket/dbt-score/blob/master/src/dbt_score/dbt_utils.py#L59-L66

Also, just to check:
Have you tried running dbt-score lint --run-dbt-parse? It will actually try to run dbt parse, you will have to make sure your environment is setup correctly so it can find the dbt project though!

dbt-score indeed executes in the same virtual environment as dbt. (Using poetry as version manager)
Relatedly, I don't rely on the DBT_PROJECT_DIR env var, instead, pass it to the command line on each execution. This has a bit to do with project layout
dbt-score lint --run-dbt-parse fails, it cannot find the project yml file

Understood, thanks for the additional info. I think this feature definitely makes sense. Would you like to contribute it?


Magpie UTF-8 decoding on python 2.7

I ran into the following issue when attempting to test magpie:
Using the data in the train folder (master/data/hep-keywords/data/train) I would get the following exception:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 796: ordinal not in range(128)
it occurs on line 57 in /magpie/base/document.py in read_sentences and can be fixed by forcing UTF-8 decoding in the same file (by removing the test for python2 and just always decoding).
Thus my assumption is that the Python2 detecting does not function properly.
My environment is as follows:
OS: Ubuntu 16.04.2 LTS (xenial)
Kernel: 4.4.0-36-generic
Python: 2.7.12
With the following packages installed in my (brand new) virtualenvironment:
appdirs==1.4.0, boto==2.46.1, bz2file==0.98, gensim==<IP_ADDRESS>, h5py==2.6.0, Keras==1.1.1  , magpie==0.2, nltk==3.2.2, numpy==1.12.0, packaging==16.8, pkg-resources==0.0.0, pyparsing==2.1.10, PyYAML==3.12, requests==2.13.0, scikit-learn==0.18.1, scipy==0.18.1, six==1.10.0, smart-open==1.4.0, Theano==0.8.2
My install commands are as follows:
pip install git+https://github.com/inspirehep/magpie.git
pip install theano
If I manually 'fix' this issue by always decoding the MagPie model can be properly trained and used (with the same data).

Full stacktrace:
Using Theano backend.
Traceback (most recent call last):
  File "magpie-train.py", line 14, in <module>
    model.init_word_vectors(training_dir, vec_dim=vecdim)
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/magpie/__init__.py", line 188, in init_word_vectors
    self.train_word2vec(train_dir, vec_dim=vec_dim)
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/magpie/__init__.py", line 202, in train_word2vec
    self.word2vec_model = train_word2vec(train_dir, vec_dim=vec_dim)
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/magpie/base/word2vec.py", line 131, in train_word2vec
    window=context,
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/gensim/models/word2vec.py", line 469, in __init__
    self.build_vocab(sentences, trim_rule=trim_rule)
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/gensim/models/word2vec.py", line 533, in build_vocab
    self.scan_vocab(sentences, progress_per=progress_per, trim_rule=trim_rule)  # initial survey
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/gensim/models/word2vec.py", line 545, in scan_vocab
    for sentence_no, sentence in enumerate(sentences):
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/magpie/base/word2vec.py", line 116, in __iter__
    for sentence in d.read_sentences():
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/magpie/base/document.py", line 57, in read_sentences
    lines = self.text.split('\n')
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 796: ordinal not in range(128)

when running magpie-train.py:
from magpie import MagpieModel
from magpie import utils
import os.path

model = MagpieModel()
training_dir = 'train'
test_dir = '' #Optional for training.
#labels = ['label1', 'label2', 'label3']
labels = ['potential: chemical', 'Polyakov loop: correlation function', 'gauge field theory: SU(3)', 'mean field approximation', 'lattice field theory', 'critical phenomena', 'scalar particle', 'heavy quark', 'lattice', 'numerical calculations', 'effective action', 'Higgs model: nonabelian', 'field theory: scalar']
saving_dir = 'saved'
vecdim = 100
epochs = 30

model.init_word_vectors(training_dir, vec_dim=vecdim)

model.train(training_dir, labels, test_dir=test_dir, nb_epochs=epochs)
#Probably need batch_train() instead of train because of memory limitations.

#saving after training:
#model.init_word_vectors(os.path.join(os.getcwd(), saving_dir, 'wordvectors.magpie'), vec_dim=vecdim)
utils.save_to_disk(os.path.join(os.getcwd(), saving_dir, 'word2vec-model.magpie'), model.word2vec_model)
utils.save_to_disk(os.path.join(os.getcwd(), saving_dir, 'scaler.magpie'), model.scaler, overwrite=True)
model.keras_model.save(os.path.join(os.getcwd(), saving_dir, 'keras-model.magpie'))

labels are from 1037765.lab, which is the file I ran against the trained model to get an example of output.

Hey @NowayIndustries ! Thanks a lot for submitting the issue, you might be right - there might be a bug there.
Do you mean that the Python2 compatibility block is not being run for your case and if you run it manually then it works? What is the type of self.text then? Could you add some prints so we can see what's going on?
For example:
    with open(filepath, 'r') as f:
        self.text = f.read()
        print(type(self.text))

        # Python 2 compatibility
        if type(self.text) != str:
            print("Python2 compatibility block is being run")
            self.text = self.text.decode('utf-8')

Hello @jstypka thanks for the fast response!

Do you mean that the Python2 compatibility block is not being run for your case and if you run it manually then it works?
Yes, if I alter the document.py to have:

with open(filepath, 'r') as f:
    self.text = f.read()

    # Python 2 compatibility
    #if type(self.text) != str:
    self.text = self.text.decode('utf-8')

magpie will succesfully train a model (and can be used to predict labels using that model).

What is the type of self.text then? Could you add some prints so we can see what's going on?

With the prints added to document.py:
Using Theano backend.
<type 'str'>
<type 'str'>
<type 'str'>
<type 'str'>
Traceback (most recent call last):
  File "magpie-train.py", line 14, in <module>
    model.init_word_vectors(training_dir, vec_dim=vecdim)
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/magpie/__init__.py", line 188, in init_word_vectors
    self.train_word2vec(train_dir, vec_dim=vec_dim)
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/magpie/__init__.py", line 202, in train_word2vec
    self.word2vec_model = train_word2vec(train_dir, vec_dim=vec_dim)
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/magpie/base/word2vec.py", line 131, in train_word2vec
    window=context,
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/gensim/models/word2vec.py", line 469, in __init__
    self.build_vocab(sentences, trim_rule=trim_rule)
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/gensim/models/word2vec.py", line 533, in build_vocab
    self.scan_vocab(sentences, progress_per=progress_per, trim_rule=trim_rule)  # initial survey
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/gensim/models/word2vec.py", line 545, in scan_vocab
    for sentence_no, sentence in enumerate(sentences):
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/magpie/base/word2vec.py", line 116, in __iter__
    for sentence in d.read_sentences():
  File "/home/sn/.virtualenvs/magpie-bugfix/local/lib/python2.7/site-packages/magpie/base/document.py", line 58, in read_sentences
    lines = self.text.split('\n')
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 796: ordinal not in range(128)

So it appears that somehow the assumption that self.text would not be a str in python 2 is untrue, perhaps this was changed in an python update (or the logic is the wrong way around)? The python2 compatibility check was introduced in #80, before that everything would always be decoded.
Again thank you for the swift response.

hmmm, I think it's a bug from my side. It should work for Python3, but the Python2 bypass seems hacky. I'll look up for better ways to do it (probably with six) and will try to fix it this evening :)

by the way, maybe @jacquerie knows a smart way of loading utf-8 encoded files in a consistent way against Python2 and Python3?

Sounds good to me!
I will be able to test any fixes tomorrow, should you need me.
(Maybe I'll even migrate to python3 once the current pull request is merged)

hey @NowayIndustries , I added a fix in the PR #83. Could you use test whether it works for you before merging? You can find the new code on the (very descriptive) branch fix-file-reading-in-py2

Hello @jstypka
Everything seems to be working fine with PR #83,
after installing with
pip install https://github.com/inspirehep/magpie.git@fix-file-reading-inpy2
into another new virtualenv (with the other things installed aswell)
and verifying that document.py has the new io.open I reran my training and testing scripts,
both are functioning perfectly.
Thank you for the support

cool, we'll try to merge the PR then!


Specific questions about Windows Containers on Windows

Windows Containers Question
(Sorry in advance for how much I wrote, I just wanted to be as clear as possible with my questions instead of opening a new Issue for each)
I am a software developer for a small manufacturing company. We have 75+ Windows10Pro workstations distributed across the building. We have several code bases but are mainly moving towards python almost exclusively for the several functions we have on our production lines.
Recently, I have been experimenting with Windows Docker Containers and have even made a small script that ran a flask server as is demonstrated in the documentation. However, there are a few questions I cannot seem to get straight, and it is either because I am misinterpreting the doumentation, and/or because the functionality used to not exist, but does now.

Can I run a Windows 10 container on a Windows 10 Pro host?

The answer appears to be yes: https://docs.microsoft.com/en-us/virtualization/windowscontainers/manage-containers/container-base-images

I have successfully ran a Windows Container and traversed its file sytem (installing python packages and executing modules like PySerial) successfully.

Can a container(Win10) utilize a host(Win10pro) COM port?

We, like much of the manufacturing industry, rely on serial connections so COM ports are a vital part of interacting with instruments/tools.
This was pretty blatantly impossible early on, however there is more recent documentation to suggest that I can: https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/hardware-devices-in-containers#what-devices-are-supported
However, when I try to run my docker image with the supplied command template, it is always unsuccessful.

Attempting to run container with --device=... argument
(.venv) PS C:\Users\sassy\source\python-docker> docker run -it --isolation=process --device="class/{86E0D1E0-8089-11D0-9CE4-08003E301F73}" myapp cmd
docker: Error response from daemon: hcsshim::CreateComputeSystem 6f531a31c1185f01aa35be67ca0492a799466f970aef57f17663b5815d2606e7: The virtual machine or container JSON document is invalid.

My Host - virtual envrioment w/ python 3.9.7
(.venv) PS C:\Users\sassy\source\python-docker> py -m serial.tools.list_ports
COM35
1 ports found

My Container - python 3.9.7 (no venv)
C:\app>py -m serial.tools.list_ports
no ports found

Can I build a GUI application, and display that window to the user on the host?

End users are afraid of CLI, if my container has python+tkinter (or any UI kit I guess) installed, and the python script executes properly.

I suppose there is a final question I have, is this the technology I am looking for?

Between all the old information on places like Stack Overflow and elswhere from years when the answer was this, that, or the other thing dont work on Windows. I am not entirely certain what this use case would be for desktops. I would like to make a program that can then be distributed easily to any workstaion that requires it. And a private Docker repo seems like a possible solution. If I understand this technolgy correctly.

Thanks so much for your informative response @cwilhit
This really clears things up for me and realize Docker is not the product I am looking for. MSIX does look about right though!
I appreciate your input :)


KAFKA-10575: Add onRestoreSuspsnded to StateRestoreListener

Add the new API (default impl is empty) to StateRestoreListener.
Update related unit tests

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Merged to trunk after updating the javadoc.