Add FINGER approximation to speed up search

FINGER (2023) says they can get "good enough" approximations of the similarity of a query vector to a neighbor vector (when adding neighbors of the current node to the queue of nodes-to-search-next) by approximating only the residual angles between the graph node’s vector, and the neighbor vectors.  This means that the similarity computation becomes a handful of arithmetic operations, instead of a large set of multiplies proportional to vector size.
https://arxiv.org/abs/2206.11408
Complexities:

the paper assumes that we will keep its precomputed data in memory to get the speedup of 1.25x to 2x.  I believe we can come close to this by storing that data inline with the adjacency list on disk and pulling it out on demand but it's possible that could eat up most of the gains.
qTB (step 1 in algorithm 2) is fairly expensive.  We pay that price once per node expanded (as opposed to once per neighbor).  if the graph is of small degree then we will not make up our investment.  The good news is that DiskANN fits this model better than HNSW, since the longer edges are all in the same layer instead of being split up across layers.  The bad news is that the paper is studying graphs of degree 96 to get its numbers, Cassandra uses degree 32 right now.

We should attempt to de-risk these before attempting a full implementation.
The authors' C++ implementation of Finger is at https://github.com/Patrick-H-Chen/FINGER.  Requires avx512 to run.

Commentary on (1):
The paper gives the example (appendix C) of Finger taking 1.7GB of memory for a dataset of 3.6GB.  That is for degree 96, but even if you divide it by 3 for degree 32, that's 0.6GB or 1/6 of the indexed vectors size.  Currently PQ is compressing to 1/16.
You could cut the Finger size in half by using r=32 instead of r=64 but accuracy will suffer, unclear by how much.
Two pieces of data that might be useful:

Run the Finger code against a couple datasets with r=64 and r=32, see what that does to recall.
Mock up a graph write/read that reads the data that Finger would need from disk along with the adjacency list, see how much that slows it down.

Commentary on (2):
Again, I think it would be useful to run the Finger code w/ parameters that match ours better -- check the speedup on a graph of degree 32 instead of 96.

What are the numbers in the output?  Recall and _ ?

and, I assume the 16 in the command line is M?

FINGER ended up not panning out.


Warn if we override the chat template in the tokenizer config

Description
This PR adds a warning message if we override the chat template in the tokenizer config with the one in the training config.

Motivation and Context

This PR resolves #1120.
How has this been tested?

Screenshots (if appropriate)
Types of changes

Social Handles (Optional)

Hey, thanks for PR. Can you also add a check if the new chat template string is different? We don't want to warn if it's the same.

@NanoCode012 Sorry for the late response. I've updated the patch to warn only if the overriding template is different from the one from tokenizer. Here is an example log when I apply chatml template to gemma-2-2b-it model:
                                 dP            dP   dP
                                 88            88   88
      .d8888b. dP.  .dP .d8888b. 88 .d8888b. d8888P 88
      88'  `88  `8bd8'  88'  `88 88 88'  `88   88   88
      88.  .88  .d88b.  88.  .88 88 88.  .88   88   88
      `88888P8 dP'  `dP `88888P' dP `88888P'   dP   dP

****************************************
**** Axolotl Dependency Versions *****
  accelerate: 0.32.0
        peft: 0.12.0
transformers: 4.43.4
         trl: 0.9.6
       torch: 2.4.0+cu124
bitsandbytes: 0.43.3
****************************************
[2024-08-24 15:28:54,225] [INFO] [axolotl.utils.config.models.input.check_eval_packing:964] [PID:21491] [RANK:0] explicitly setting `eval_sample_packing` to match `sample_packing`
[2024-08-24 15:28:54,227] [DEBUG] [axolotl.normalize_config:83] [PID:21491] [RANK:0] bf16 support not detected, disabling for this configuration.
[2024-08-24 15:28:54,236] [INFO] [axolotl.normalize_config:183] [PID:21491] [RANK:0] GPU memory usage baseline: 0.000GB ()
[2024-08-24 15:28:56,078] [DEBUG] [axolotl.load_tokenizer:282] [PID:21491] [RANK:0] EOS: 107 / <end_of_turn>
[2024-08-24 15:28:56,078] [DEBUG] [axolotl.load_tokenizer:283] [PID:21491] [RANK:0] BOS: 2 / <bos>
[2024-08-24 15:28:56,078] [DEBUG] [axolotl.load_tokenizer:284] [PID:21491] [RANK:0] PAD: 0 / <pad>
[2024-08-24 15:28:56,078] [DEBUG] [axolotl.load_tokenizer:285] [PID:21491] [RANK:0] UNK: 3 / <unk>
[2024-08-24 15:28:56,079] [WARNING] [axolotl.load_tokenizer:295] [PID:21491] [RANK:0] The chat template is being overridden by the one in the config. This may cause a mismatch with the existing chat template in the base model. Please verify that this override is intended and compatible.

Hello, we're currently trying to get a PR #1732 in which should make this more explicit. For ex, setting chat_template: tokenizer_default would use the tokenizer's setting. This way, if a user explicitly sets a different template like chatml, we would believe that they understand what they're doing.
Would this be reasonable? If so, we can close this PR.

@NanoCode012 Yep, the approach with chat_template: tokenizer_default would be better than this warning. I close this PR. :)


Fix missing upper pins for cylc-rose

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Closes https://github.com/conda-forge/cylc-rose-feedstock/issues/10 hopefully

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Can you resolve the conflict and post the output of show_diff.py?

I got 504 both times I tried to run it
$ python recipe/show_diff.py --use-cache
linux-64::cylc-rose-0.1.1-py37h89c1867_0.tar.bz2
-    "cylc-flow >=8.0b0",
-    "metomi-rose >=2.0b1",
+    "cylc-flow ==8.0b0",
+    "metomi-rose ==2.0b1",
linux-64::cylc-rose-0.1.1-py38h578d9bd_0.tar.bz2
-    "cylc-flow >=8.0b0",
-    "metomi-rose >=2.0b1",
+    "cylc-flow ==8.0b0",
+    "metomi-rose ==2.0b1",
linux-64::cylc-rose-0.2-py37h89c1867_0.tar.bz2
-    "cylc-flow >=8.0b2",
-    "metomi-rose >=2.0b2",
+    "cylc-flow ==8.0b2",
+    "metomi-rose ==2.0b2",
linux-64::cylc-rose-0.2-py38h578d9bd_0.tar.bz2
-    "cylc-flow >=8.0b2",
-    "metomi-rose >=2.0b2",
+    "cylc-flow ==8.0b2",
+    "metomi-rose ==2.0b2",
linux-64::cylc-rose-0.2-py39hf3d152e_0.tar.bz2
-    "cylc-flow >=8.0b2",
-    "metomi-rose >=2.0b2",
+    "cylc-flow ==8.0b2",
+    "metomi-rose ==2.0b2",
osx-64::cylc-rose-0.2-py37hf985489_0.tar.bz2
-    "cylc-flow >=8.0b2",
-    "metomi-rose >=2.0b2",
+    "cylc-flow ==8.0b2",
+    "metomi-rose ==2.0b2",
osx-64::cylc-rose-0.2-py38h50d1736_0.tar.bz2
-    "cylc-flow >=8.0b2",
-    "metomi-rose >=2.0b2",
+    "cylc-flow ==8.0b2",
+    "metomi-rose ==2.0b2",
osx-64::cylc-rose-0.2-py39h6e9494a_0.tar.bz2
-    "cylc-flow >=8.0b2",
-    "metomi-rose >=2.0b2",
+    "cylc-flow ==8.0b2",
+    "metomi-rose ==2.0b2",
Traceback (most recent call last):
  File "~/conda-forge-repodata-patches-feedstock/recipe/show_diff.py", line 88, in <module>
    do_subdir(subdir, raw_repodata_path, ref_repodata_path)
  File "~/conda-forge-repodata-patches-feedstock/recipe/show_diff.py", line 49, in do_subdir
    instructions = _gen_patch_instructions(raw_repodata, new_index, subdir)
  File "~/conda-forge-repodata-patches-feedstock/recipe/gen_patch_json.py", line 316, in _gen_patch_instructions
    _add_removals(instructions, subdir)
  File "~/conda-forge-repodata-patches-feedstock/recipe/gen_patch_json.py", line 296, in _add_removals
    r.raise_for_status()
  File "~/.conda/envs/tmp/lib/python3.9/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 504 Server Error: Gateway Timeout for url: https://conda.anaconda.org/conda-forge/label/broken/win-32/repodata.json

@MetRonnie, could you try again? There may have been a temporary disturbance on the server, but I verified now that it works. If you keep having the error, I might try to produce the output.

The changes look good to me. The changes to virtualenv seem indeed to come from the latest commit already in main. @dopplershift, could you please have another look?

Sorry, @MetRonnie, I understand this is a bit frustrating, but could you resolve the new conflicts? Alternatively, if you add me to https://github.com/MetRonnie/conda-forge-repodata-patches-feedstock, I can do that.

Thanks, @MetRonnie. @conda-forge/core, could somebody have a look?


Page Titles

We currently assign page titles manually, instead we can make the following abstract classes, automatically figure out the page title, using the route name space.
-AbstractIndexRoute
-AbstractEditRoute
-AbstractModuleRoute
-AbstractDeleteController
i.e we have a titles.js translation that follows the same name spacing as the routes in the application. so for example:
inventory.index the page title will be under either titles.inventory.index = 'asd' or inventory.index.titles = 'asd'.
inventory.index the page title will be under inventory.index.title = 'asd'
the advantage of this is that the:

CI will throw and error if a page title translation doesn't exist
If needed the developer can always override the existing behaviour
keeps title, translations in a tidy format for ever :).
automatically fix the remaining titles to be translated :).

I like this. @jkleinsc what do you think?
Sent using CloudMagic Email [https://cloudmagic.com/k/d/mailapp?ct=pi&cv=7.11.40&pv=9.3.1&source=email_footer_2]
On Sun, Jul 3, 2016 at 5:04 AM, Sebastien Stettler<EMAIL_ADDRESS>wrote:
We currently assign page titles manually, instead we can make the following abstract classes, automatically figure out the page title, using the route name space.
-AbstractIndexRoute
-AbstractEditRoute
-AbstractModuleRoute
-AbstractDeleteController
i.e we have a titles.js translation that follows the same name spacing as the routes in the application. so for example:
inventory.index the page title will be under either titles.inventory.index = 'asd' or inventory.index.titles = 'asd' .
the advantage of this is that the:

CI will throw and error if a page title translation doesn't exist
If needed the developer can always override the existing behaviour
keeps title, translations in a tidy format for ever :).
automatically fix the remaining titles to be translated :).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub [https://github.com/HospitalRun/hospitalrun-frontend/issues/551] , or mute the thread [https://github.com/notifications/unsubscribe/AA4t7SWWUQh5MJawyVIYIz3pUYaqDTEiks5qR3sqgaJpZM4JD1QT] .

@billybonks I think this is a great idea.  I would prefer the path to be inventory.index.title = 'asd'

ye that is better 👍, also allows us to use route structure for other things if needed

@wolfieorama would like to work on this issue. I'd like to assign it to him. No sure why it's not letting me.

can i work on this?

@yasirunilan @wolfieorama is currently assigned to this issue.
@wolfieorama are you working on this?

@jkleinsc yes should be next in line

I'm working on it

cool no worries

@yasirunilan any progress here?

@tangollama sorry couldn't do it


UHF-0000: Reduced duplicate code on external, tel and mail links

UHF-0000

There is now  common <span> elements for the screen readers to read when a link takes to external page, opens a phone call or the default mail program. These weren't yet used in some cases.
What was done

Switched the aria-labelledby attributes in helfi-link.html.twig to refer the common span elements.

How to install

Make sure your etusivu instance is up and running on latest dev branch.

git pull origin dev
make fresh

Update the HDBT theme

composer require drupal/hdbt:dev-UHF-0000_Refactor-external-links

Run make drush-cr

How to test

[ ] Add some external link, telephone field and email field. Check that they have the hidden span for screen readers.
[ ] Translate the page to another language (other than Finnish, Swedish or English). Check that the hidden span for screen readers exists and is in English.

Designers review

[x] This PR does not need designers review

Closing this as duplicate of https://github.com/City-of-Helsinki/drupal-hdbt/pull/665


Future of this project

This looks like a very interesting concept, but with the commit history it looks like the project is not really being used by anyone, or being maintained in an active way.  I was just wondering if this was something you (@substack) are maintaining, or if it was being used actively in any way?
If I start using this, and have fixes or documentation additions, would they get merged?  It looks like there are some pending PR's and issues, and I would rather fork and continue development if this is not something you are interested in maintaining.
Thanks for all the awesome projects, including this one!

This question also applies to fwdb.


Sammy newroomattendant

it's just for checking if it's working or not.. we need to change the data
after we are done with the project because things might change by the time
we finish the project. Also need your pictures:). So information is on hold
now...
On Mon, Jan 29, 2024 at 5:22 PM Francesca @.***> wrote:

@.**** commented on this pull request.
In
roomranger/src/main/java/org/launchcode/roomranger/controllers/AboutUsController.java
https://github.com/slashley127/group-slash-2/pull/12#discussion_r1470358040
:

   authors.add(new Author(

           "Sonal",

           "/images/creators/pic-of-Mike.jpeg",

           "Backend, Creating Chore Details Page",

           "Current cook and coder.",

           "https://www.linkedin.com/in/michael-zanger-ba8b1a287/",

           "https://github.com/mikezanger"

   ));

   model.addAttribute("authors", authors);

   return "about_us";

}
+}

I like the about us page but the description for each one of us is
incorrect?
I don't understand!
—
Reply to this email directly, view it on GitHub
https://github.com/slashley127/group-slash-2/pull/12#pullrequestreview-1849955693,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BASTJO764CBBGGEFWZXK6ETYRAVMBAVCNFSM6AAAAABCM5B2NSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBZHE2TKNRZGM
.
You are receiving this because you authored the thread.Message ID:
@.***>

I  copied the code from another project and i didn't change the information
since it wasn't important.
On Thu, Feb 1, 2024 at 10:57 AM Samata @.***> wrote:

it's just for checking if it's working or not.. we need to change the data
after we are done with the project because things might change by the time
we finish the project. Also need your pictures:). So information is on hold
now...
On Mon, Jan 29, 2024 at 5:22 PM Francesca @.***>
wrote:

@.**** commented on this pull request.
In
roomranger/src/main/java/org/launchcode/roomranger/controllers/AboutUsController.java
https://github.com/slashley127/group-slash-2/pull/12#discussion_r1470358040
:

   authors.add(new Author(

           "Sonal",

           "/images/creators/pic-of-Mike.jpeg",

           "Backend, Creating Chore Details Page",

           "Current cook and coder.",

           "https://www.linkedin.com/in/michael-zanger-ba8b1a287/",

           "https://github.com/mikezanger"

   ));

   model.addAttribute("authors", authors);

   return "about_us";

}
+}

I like the about us page but the description for each one of us is
incorrect?
I don't understand!
—
Reply to this email directly, view it on GitHub
https://github.com/slashley127/group-slash-2/pull/12#pullrequestreview-1849955693,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BASTJO764CBBGGEFWZXK6ETYRAVMBAVCNFSM6AAAAABCM5B2NSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBZHE2TKNRZGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


Use the selinux enables k8s-1.17 lane

What this PR does / why we need it:
Use a 1.17 build with selinux enabled. Let's see what breaks.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:
NONE

/lgtm
Tested this locally, SELinux is enabled and enforced, no denial even after starting a VM.
Thanks!

I see some errors here: https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/3235/pull-kubevirt-e2e-k8s-1.17/1245765888964038656. Right now not too many are failing, and this may be fixed with your PR. We will see.

@jean-edouard @vladikr the kubevirtci PR is merged. This one is updated and should be ready.

/retest


Sidebar links improvement suggestion

I think the links in the sidebar looks a bit unaligned.

Does this look better? I can make it if people agree :)

/kind feature

/priority backlog


Request : SWS Studio Management

Is it possible to have something like this ?

Schedule for studio hiring,
Cards for clients, musicians, producers....
Time Tracker to see how much time spend on recording,mixing,....
Budget organizer

Thanks

Check out TrackBits, made by Australian studio engineer and programmer Simon Moro.
This is all that plus more (invoicing, etc)


⚠ Bofrost.nl has degraded performance

In 8b40ad4, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1345 ms

Resolved: Bofrost.nl performance has improved in b3cc93d after 8 minutes.


Migrating Ledger Account

Issue description
I have 0 tokens in Index 0 but I have many tokens in 1 - The migration comes back showing 0 tokens but does not allow me to change to Index 1 - How do I change the Index No. to migrate my tokens from Index 1
Firefly version
1.2.0
OS details
Windows 10
Can the issue be reliably reproduced?
Yes
Steps to reproduce the issue
1.Start the migration with 0 tokens in Index 0 but with Tokens in Index 1
2.
3.
...
Expected behaviour
Firefly does not continue to Ask for other Index no's
Actual behaviour
I cannot migrate my tokens in Index 1
Errors
No response

You can change the index in the migration process see attached image

Thankyou
On Tue, Sep 7, 2021 at 1:50 PM MiKeF05 @.***> wrote:

You can change the index in the migration process see attached image
[image: account index]
https://user-images.githubusercontent.com/71659397/132388881-9c51da73-4818-4b2c-9cd3-bbc02399fcb2.JPG
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/iotaledger/firefly/issues/1445#issuecomment-914503608,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVQWYXY5FIPDTZUHM33B3ETUAZGGBANCNFSM5DSWHOOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Carpe Diem  --  Life was meant to be awesome!

Hope this helps. If you any other problems with the migration you can also join the IOTA Discord server and go to the help channel.

Really appreciate your help!
I just completed my migration.
Best
L.F.
On Tue, Sep 7, 2021 at 2:04 PM MiKeF05 @.***> wrote:

Hope this helps. If you any other issues with the migration you can also
join the IOTA Discord server and go to the help channel.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/iotaledger/firefly/issues/1445#issuecomment-914512268,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVQWYX45XMZTNKRFV4NX3PDUAZHZLANCNFSM5DSWHOOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Awesome! :-) I guess this issue can be closed...

👍
On Tue, Sep 7, 2021 at 3:18 PM MiKeF05 @.***> wrote:

Awesome! :-) I guess this issue can be closed...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/iotaledger/firefly/issues/1445#issuecomment-914559134,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVQWYX2TXAURDKMWF6XZEUDUAZQOTANCNFSM5DSWHOOQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Carpe Diem  --  Life was meant to be awesome!


Inconsistency in working directories and test.sh

Dockerfile-minimal installs pygraphblas to /pygraphblas and uses it as working directory, but the notebook variant uses /home/jovyan.
@michelp, what is the reason behind the difference? Is this a way to avoid permission problems?
https://github.com/michelp/pygraphblas/blob/62a630e737a242a70214e7a86b0fefbe36cbdfd3/Dockerfile-minimal#L14-L15 https://github.com/michelp/pygraphblas/blob/62a630e737a242a70214e7a86b0fefbe36cbdfd3/Dockerfile-notebook#L43-L44
This causes inconsistency in test.sh, which copies the current source folder to /home/jovyan/pygraphblas, but runs the tests from the working directory (/pygraphblas for minimal image). In this case the source code and tests from the image itself are tested instead of the current source folder in the host file system.
https://github.com/michelp/pygraphblas/blob/62a630e737a242a70214e7a86b0fefbe36cbdfd3/test.sh#L5

The jovyan thing with notebook images is still a bit of a mystery to me, I haven't had the time to dig into the details of how the jupyter notebook images are built, so I split the Dockerfiles as an expedient.  Perhaps there is a better approach, like using a --build-arg to pass the working directory to one Dockerfile that can build them both.
Maybe another approach is to just put the minimal code in /home/jovyan as well?  It will confuse people but also allow the files to unify.  Thoughts?

It seems to me that the Jupyter images use jovyan to have a non-root user who can run the notebooks and has the same UID and GID as the user from the host to avoid permission problems if host folders are mounted to the container.
https://github.com/jupyter/docker-stacks/blob/master/base-notebook/Dockerfile
In our case, installation of packages and SuiteSparse must use root user, but the Python installations can run as non-root if I am right.
I think the pygraphblas code can be kept in /pygraphblas directory for both images and it can be used as working directory. Source folder from the host can be mounted to override this folder for development purposes, e.g. in test.sh.
Multi-stage build might be used to combine the Dockerfiles, but I am not sure how it works.

A similar inconsistency (at least for me) around building and testing is that build.sh runs a clean build based on a branch.
https://github.com/michelp/pygraphblas/blob/62a630e737a242a70214e7a86b0fefbe36cbdfd3/build.sh#L13-L17
Usually I would do some modifications, run build.sh and then run the tests with test.sh. The current version does not support this, since only a branch on the remote can be built and tested. What workflow do you recommend?
What do you think about separating the core parts of build.sh and the git clone and docker push part of it? The latter parts can go into something like build-and-deploy.sh.

Oops missed the part where you pushed some changes to this, I also pushed a fix that lets you build from a local repo and optionally pushes to dockerhub in docker-build.sh.  Does this work for you needs?  Otherwise I'll revert and use yours.

Your solution is great. I have extended it in #56.


please update pods according to new release of ios 13.4

receiving this error in ios 13.4.

@ravipromact2306 Yes I am also having the exact issue. Can anyone help how to resolve?

same here.

Also seeing the issue, opened a PR here: https://github.com/optonaut/ActiveLabel.swift/pull/360

I made a release 1.1.5 including the fix by @casperson for this issue. I asked to be published on cocoapods (I don't have permission for this)


Could we use the same trained model for translating from English to Germane

Hi we have trained german to English model and perform translation using the following command
python -m nmt.nmt --src=de --tgt=en --out_dir=tmp\deen_gnmt  --inference_input_file=tmp\my_infer_file.de --inference_output_file=tmp\deen_gnmt\output_infer
Would I be able t o convert from English to German using the same trained model by only change the src and target and inference input file. I have found the below command does not convert the English Text to German.
python -m nmt.nmt --src=en --tgt=de --out_dir=tmp\deen_gnmt  --inference_input_file=tmp\my_infer_file.en --inference_output_file=tmp\deen_gnmt\output_infer
Do i need to preform training and get a new model created for English to German to perform the conversion?

Yes, you do.


ERROR  [nuxt] [request error] [unhandled] [500] readMultipartFormData is not defined

Version
nuxt-security: Latest
nuxt: Latest
Reproduction Link

Steps to reproduce
Getting the following error when submitting a form wuth nuxt-security enabled - this has only occured since updated to latest nuxt (though downgraded and still getting issue - didnt try downgrade nuxt-seucruty)
ERROR  [nuxt] [request error] [unhandled] [500] readMultipartFormData is not defined
  at Object.handler (./node_modules/.pnpm/nuxt-security@1.3.1_rollup@2.79.1/node_modules/nuxt-security/dist/runtime/server/middleware/xssValidator.mjs:26:13)
  at ./node_modules/.pnpm/h3@1.11.1/node_modules/h3/dist/index.mjs:1962:31
  at async Object.callAsync (./node_modules/.pnpm/unctx@2.3.1/node_modules/unctx/dist/index.mjs:72:16)
  at async Server.toNodeHandle (./node_modules/.pnpm/h3@1.11.1/node_modules/h3/dist/index.mjs:2249:7)

Client Side

async function login(e: any) {
  loggingIn.value = true;
  try {
    console.log(e);
    const formData = new FormData();

    // Append each form field to the FormData object
    Object.keys(e).forEach((key) => {
      formData.append(key, e[key]);
    });
    console.log(formData);
    await $fetch("/api/auth/login", {
      method: "POST",
      body: formData
    });
    await navigateTo("/dashboard");
  } catch (err: any) {

    loggingIn.value = false;
    error.value = err.data?.message ?? null;
    toast.add({ title: 'Error', description: error.value ?? 'An error occurred', icon: 'i-heroicons-information-circle-20-solid', color: 'rose'})
  }
}

Server side:

export default eventHandler(async (event) => {
	const formData = await readFormData(event);
	const username = formData.get("username");
	const password = formData.get("password");

Thanks for libary!

Hey, thanks for reporting this. It was actually missing from the import statement. Should be fixed in 1.3.2 version :)

Solved


Different environments share .ini files, temp files, history...

On my system at least, which is a 2-hour old clean install of MacOS Catalina with miniconda3 and the latest Spyder build, if I create two conda environments, env1 and env2 in which I install spyder, both setups refer to the same .spyder-py3 configs. So if I open two instances (let's say I want to test the latest version of Spyder against the previous one), if I modify the theme or a keyboard shortcut in one instance, this immediately conflicts with the other instance. If I write in the temp.py file, likewise, as it is open in both instances.
A solution must involve an environment-specific .spyder-py3 directory.
This is a conda problem in a sense, but in the README file, conda is listed at the top as the method by which to obtain Spyder, so I'm reporting here. Please move if you feel it is appropriate.

A solution must involve an environment-specific .spyder-py3 directory.

Thanks for reporting. This is planned for Spyder 5, to be released next year.

Thanks Carlos. Since posting my suggestion I have noticed several discussions on related topics, including here, here, here.


Design Meeting Notes, 10/6/2023

No Checking on with Properties for Import Attributes
https://github.com/microsoft/TypeScript/issues/55994

What is going on in this example?

People are trying to restrict the type attribute to purely "json".
The entire set of import attributes probably should be checked against the type specified.

But really these attributes are implementation-defined.
You could imagine people would want to be able to say @types/node specifies exactly what literals are allowed.

But you'll be in for a bad time if you have duplicates installed and they conflict.
It always comes back to the "add a level of indirection with keyof and a registry of keys.

Can't we just encode what's in the standard?

Not part of ECMA262, it's implementation defined.
Browsers, Node, Bun, Deno all have different behavior here.

This is just a bug because we have the right checking with assert, but not with.
Should get out ahead of this and possibly define with as an extensible object.

Improvements to Constraints of Conditional Types on Constrained Type Variables
https://github.com/microsoft/TypeScript/pull/56004
type IsArray<T> = T extends any[] ? true : false;

function f1<U extends object>(x: IsArray<U>) {
    let t: true = x;   // Error
    let f: false = x;  // Proposed to error under this PR
}

Today we said that the constraint of U is the type false because we would say object (the constraint) isn't a subtype of any[].

This isn't really correct - U could actually be instantiated with any[] in a call to f1, could have a similar type at runtime.
It's more correct to say it could be either branch.

Idea is to check whether the conditional could fall into both branches via bidirectional comparability - if the check type (LHS) and the extends type (RHS) are comparable in either direction.
Why not do an intersection check and see if that's empty?

Because lots of bogus intersections can be created. It would be too permissive and so virtually everything would have a constraint that falls into both branches.
We can only get nevers from intersections when intersecting primitives or discriminated union object types that conflict. We allow nonsense like string & { yadda: any }.
So using intersections is technically more correct, but immensely useless.

Comparability is also not perfect because it's too conservative in terms of asking "do these types have any possible overlap", but it brings us a step closer to conditionals being less wrong where today we just punt decisions into the false branch.
Feels off because comparability was more of a heuristic-y relationship.

But by performing this loose check, we give you a less specific result from a conditional - which is more accurate.
If we modify comparability to be stricter, then conditional types behave differently.

One view of this is a way of pushing conditional types towards a more correct form where the false branch has to always include the true type as well.

That train is long gone, and has an undesirable UX.

Alternative to this is assignability in both directions.

Still technically incorrect, but

Perf effects?

Were very bad for the material-ui test case.

15% perf regression in the checker.
But also this codebase is very out of date and might be full of errors, so this might just be error message checking.

Slightly positive for xstate though.

Breaks?

Have to review.
vuejs/core seems right.
knex on DT seems right.

So this change - it's only for constraints. It's not for concrete types?

No, we believe that to be too breaky.
Feels weird but we can swallow that pill for now.

You could imagine people would want to be able to say @types/node specifies exactly what literals are allowed.

But you'll be in for a bad time if you have duplicates installed and they conflict.

people already have a bad time for having multiple copies of types/node.

Can't we just encode what's in the standard?

what about interface ImportMeta {} you have today?


glTF models are black with WebGL + SwiftShader

Filament clients who use puppeteer are hitting an issue where models look black when the GPU is disabled.  This can be reproduced by simply adding the --disable-gpu argument to the Chrome invocation:
/Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome --disable-gpu http://<IP_ADDRESS>:8080/helmet.html

The debugger output does not reveal anything obviously wrong.  Other Filament demos seem fine, like parquet.html.

The bug goes away if I add -g to matc or if I simplify Filament's core shading in any number of ways.  At this point it really seems like the bug existing within Chrome's --disable-gpu functionality (which is presumably based on SwiftShader) so I sent mail to the Chrome team.

The current Canary build does not allow WebGL 2.0 when disable-gpu is enabled, which makes it difficult to know if the issue still exists in upcoming versions of Chrome.

The bug goes away if I add -g to matc or if I simplify Filament's core shading in any number of ways. At this point it really seems like the bug existing within Chrome's --disable-gpu functionality (which is presumably based on SwiftShader) so I sent mail to the Chrome team.

Hello,
did they ever come back to you with a reply? It's still broken. Also could you please elaborate on how can I fix this with matc -g option? I want to render quite complex gltf models in headless mode with filament, but currently, it seems like a dead-end to me.
Any help is very appreciated!
Thanks!


Promote and destroy files asynchronously

Adds jobs for promoting files from cache to store, as well as deleting files from storage.
Fixes #217

We will need changes to start.sh to conditionally run sidekiq, and I'm curious if we should give sidekiq a default configuration at config/sidekiq.yml did you want me to push those to this branch, or give a separate PR?

@whereismyjetpack I'd do it as a separate PR. Rails will actually run async without sidekiq, it just wouldn't be very good; a kinda of "faked" async. So we can tweak the Sidekiq config and setup completely separately from PR here.

@rschenk One thing I did here was use the Shrine namespace. This could be construed as "bad" since I'm defining something like Shrine::DestructionJob and Shrine could technically create the same class in its gem code and that might cause problems. But, I wanted to use the namespace because it was there and kept things organized.


Add a wiki: Satisfactory

Link to origin wiki: https://satisfactory.fandom.com/wiki/Satisfactory_Wiki
Link to destination (independent) wiki: https://satisfactory.wiki.gg/wiki/Satisfactory
Thanks for all the work!

Woops, just saw wiki.gg was not considered indepedent !


feature request: allow stream in File.save

To avoid some boilerplate code with streams it would be nice to be able to pass a stream to File.save
Example
const read = fs.createReadStream('./somefile.bin');
const file = bucket.file(`test.bin`);
await file.save(read);
// do other stuff

This would be very useful when working with promises.

@fiws have you thought about using something like stream-to-promise? I think we're of the opinion that the streaming and non-streaming APIs shouldn't connect in that way.

I would agree that stream-to-promise seems like the right way to go. I would be convinced otherwise if in the average app, we're the only API not accepting streams as an argument. That doesn't match my experience so far, which is why I'm slanted towards letting the module ecosystem solve this-- since it's probably not just us, a user would need a module like stream-to-promise for use with those other APIs.
However, I'm contradicting myself by suggesting stream-to-promise. If a lot of users are finding that useful, then it stands to reason it would be best to give users what they want.
What do you think @fiws? Obviously, you asked for the feature, but have you been able to make this work without the suggested change in a way that's not too cumbersome? Or do you feel even more strongly we should support this as time passed?
Considering the above, I would be okay with a PR for this, although I don't consider it urgent. Its value might increase in time.

Thanks for the response.
stream-to-promise is better than the awkward wrapper I have build. Thanks for suggesting that. It's good enough for my use case for now. :)
I would really like to see node figure out their promise/callback/event/stream mess. It feels like we're slowly moving towards a more promise based node core starting with util.promisify.
You can close this issue if it bothers you. I would still like the feature though.

I'll mark it the issue with "help wanted", so if anyone beats us to implementing it, great!

For now, I think it's best to let the API stand, as-is. If you want to PR it, it should be a non-harmful change, although I don't think there is much demand from the community at this time. We can always re-open if we hear more requests for this.


Page does not open at the top when following a link

Steps to reproduce:

Open a page.
Scroll down.
Open a new page.

Expected: The new page opens at the top.
Actual: The new page opens at the same scroll level of the previous page.
As a user reading the page and following a link to read more this is confusing, because the next page seems to open at a random spot. See the gif below:

You can view the website code here. This is my index.html. Check it live here.

Same issue here, have to look for a workaround i guess

Thanks, i configured it and it works like a charm

Just a thought, wouldn't it be better for this to default to true instead of false? It seems (to me at least) that this would be the most commonly expected behaviour.


More robust sorting of yml files

this PR fixes the case where bucc breaks when someone has an @ in their file path.


rpc: add method to get address deltas from a block

based on current discussions, is this ready for review and test?

Yes

After discussion, I think we should take a look at these options before merging:

Adding prevTxId and outputIndex to the addressindex value, so that it's possible to determine which utxo is being spent in the getblockdeltas listing, similar to the responses from getaddressmempool

LevelDB snapshots for the getaddressutxos command, to be able to query based on the last 6 block heights, to keep consistency across multiple requests.


[Enhancement] Keep the number of migration tasks running on be to a fixed number

Currently, if there are huge number of tablets to migrate (SSD->HDD or HDD->SSD), FE will send 1000 tasks to BE every 1 minute(tablet report interval), which will cause tasks to pile up on BE, and end up with OOM.
We can use AgentTaskQueue to get the number of task running on BE, and send (Config.tablet_sched_max_migration_task_sent_once - running_tasks) tasks to BE, so that the number of migration tasks running on BE can be kept in a fixed number.
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[x] 3.0
[x] 2.5
[ ] 2.4

[FE PR Coverage Check]
:disappointed: fail : 6 / 46 (13.04%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/leader/LeaderImpl.java
0
25
00.00%
[288, 729, 730, 731, 732, 736, 737, 738, 741, 742, 743, 744, 745, 746, 749, 750, 751, 752, 753, 756, 759, 760, 761, 763, 766]

:large_blue_circle:
com/starrocks/catalog/TabletInvertedIndex.java
5
20
25.00%
[315, 317, 318, 322, 323, 327, 328, 329, 331, 333, 334, 336, 339, 342, 343]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 7 / 51 (13.73%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/leader/LeaderImpl.java
0
25
00.00%
[288, 729, 730, 731, 732, 736, 737, 738, 741, 742, 743, 744, 745, 746, 749, 750, 751, 752, 753, 756, 759, 760, 761, 763, 766]

:large_blue_circle:
com/starrocks/catalog/TabletInvertedIndex.java
5
24
20.83%
[315, 317, 318, 319, 320, 324, 325, 326, 330, 331, 332, 334, 336, 337, 338, 340, 343, 346, 347]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/task/AgentTaskQueue.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 8 / 52 (15.38%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/leader/LeaderImpl.java
0
25
00.00%
[288, 729, 730, 731, 732, 736, 737, 738, 741, 742, 743, 744, 745, 746, 749, 750, 751, 752, 753, 756, 759, 760, 761, 763, 766]

:large_blue_circle:
com/starrocks/catalog/TabletInvertedIndex.java
5
24
20.83%
[315, 317, 318, 319, 320, 324, 325, 326, 330, 331, 332, 334, 336, 337, 338, 340, 343, 346, 347]

:large_blue_circle:
com/starrocks/common/proc/LocalTabletsProcDir.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/task/AgentTaskQueue.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 9 / 53 (16.98%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/leader/LeaderImpl.java
1
26
03.85%
[286, 727, 728, 729, 730, 734, 735, 736, 739, 740, 741, 742, 743, 744, 747, 748, 749, 750, 751, 754, 757, 758, 759, 761, 764]

:large_blue_circle:
com/starrocks/catalog/TabletInvertedIndex.java
5
24
20.83%
[315, 317, 318, 319, 320, 324, 325, 326, 330, 331, 332, 334, 336, 337, 338, 340, 343, 346, 347]

:large_blue_circle:
com/starrocks/common/proc/LocalTabletsProcDir.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/leader/ReportHandler.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/task/AgentTaskQueue.java
1
1
100.00%
[]

@Mergifyio backport branch-3.1

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


Fix Ubuntu Impish dependencies and add Debian Bullseye build

The Ubuntu Impish package had wrong dependencies, so I fixed that.
Moreover, I added the CircleCI build for Debian Bullseye.
Please note that there was already a slight difference with regard to packages in script/install-deps.sh and .circleci/config.yml.
Hirsute and Impish install pipewire, etc. while Buster and Bullseye don't. Hence, I didn't add those dependencies as well.
Besides that, musikcube packages for Impish and Bullseye seem to be interchangeable.
@clangen: If you don't want to build an official package for Bullseye, feel free to reject this PR.
However, you might want to pick https://github.com/gschauer/musikcube/commit/566f248aee465d718f738d9071b99d3f6c6d91d4 to have a proper package for Ubuntu Impish.

Awesome, looks great. Thank you!


Error when deployed to Azure

Hi!
First, thanks so much for the blog posts/repos about hosting dotnet core apps in Azure functions, really interesting prototypes! I was able to clone your repo and it works great locally, however I am running into an issue when I deploy and run it as a real azure function. I enabled detailed dotnet core errors on the app and I am seeing the following error:
InvalidOperationException: Application is running inside IIS process but is not configured to use IIS server.
Just curious, is this something you ever ran into during your experimenting? If not, probably yet another change to the azure functions runtime may have broken it!
Thanks again!

Hi Jarrod,
This was reported to me through another channel as well end of last week. In the Program.cs file, replace WebHost.CreateDefaultBuilder with the code seen in the extension method (here: https://github.com/aspnet/MetaPackages/blob/f245512f6e68d65309b65528d479f32b34c67718/src/Microsoft.AspNetCore/WebHost.cs#L150) and remove the UseIISIntegration() method call and I think that should do the trick.


Create django.yml

github actions.
runs the tests.

Passes check and doesn't break any existing code. Also remembers to install dependencies.


Custom renderStepIndicator is not centered on iOS

Since we can't create issues in your fork, i'm doing it here @peterpme
A custom renderStepIndicator with a few custom styles lead to uncentered content inside the step indicator steps. But only on iOS, on Android it is fine.
<StepIndicator
        stepCount={stepCount}
        renderStepIndicator={renderStepIndicator}
        customStyles={indicatorStyle}
        currentPosition={currentPage}
        onPress={onStepPress}
        labels={labels}
 />

const indicatorStyle = {
        stepIndicatorSize: 20,
        currentStepIndicatorSize: 25,
        separatorStrokeWidth: 2,
        currentStepStrokeWidth: 3,
};

const renderStepIndicator = (params) => {
        return <MaterialCommunityIcon {...getStepIndicatorIconConfig(params)} />;
};

const getStepIndicatorIconConfig = ({ position, stepStatus }) => {
        const iconConfig = {
            name: icons[position],
            color: stepStatus === 'finished' ? '#ffffff' : activeIconColor,
            size: stepStatus === 'current' ? iconSize : iconSize - (activeStepSize - inactiveStepSize),
        };
        return iconConfig;
};

Android: perfectly centered

iOS: not centered

It is an issue with react-native-vector-icons on iOS: https://github.com/oblador/react-native-vector-icons/issues/1163

@Relax594 DId you solve it? Same here...

@Relax594 DId you solve it? Same here...

as i've written it is an issue with react-native-vector-icons which is used in this lib. I just solved it by adding padding 1px left and top

please share me your code, I need see some method create icons


Card not displayed

Describe the bug
The card is not displayed in the UI.
In the console of the browser i get this:

Hey, thanks for the report! Could you send a screenshot with attributes of meteoalarm entity from the Developer Tools tab?

Here it is:

I am using the custom component meteoalarmeu
https://github.com/xlcnd/meteoalarmeu

I am using the custom component meteoalarmeu
xlcnd/meteoalarmeu

Okay so that would resolve the issue, as of now, xlcnd/meteoalarmeu is not supported, only the core one is. Moving this to -> #4

You advice me to switch the the core one, or wait an update which support also the meteoalarmeu?

You advice me to switch the the core one, or wait an update which support also the meteoalarmeu?

If you have any automations or other things relying on meteoalarmeu you can just keep it as it is and add core integration as a separate entity. That way you can use binary_sensor.meteoalarmeu as you would before and point card to binary_sensor.meteoalarm instead

Problem is that the core integration and the custom one use both the same platform.
I have this in binary sensor:
- platform: meteoalarm
  name: 'Allarme Meteo Abruzzo'
  language: 'it'
  country: 'IT'
  province: 'Abruzzo'

And it's the same if i want to use the core integration....
I hope you can update the card asap so i can use it independently from the integration...


Doesn't work with Android

I want to send a continuous stream of data to my Android device via UDP. I tried chat example in both Android and Editor. The editor was acting as a Server and android as a client and it doesn't work. I changed the localhost to local IP but still, it doesn't work. Is there any simplistic example to send data between two devices?

IMHO, you're using the wrong tool for the job.
If you're just sending continous data between two devices, then I'd suggest you go more barebones than Mirror. Mirror is oriented for game workloads, not constant data streaming like trying to feed security camera footage to connected clients.
If you're going to stream data between two devices, you can do that using built-in Mono/C# library functions, or use something like ENet or KCP which are reliability protocols on top of the UDP protocol.
Don't get me wrong, Mirror can do what you are wanting to do, but for your usage I don't believe it's the best option available in the arsenal.

This is probably a firewall rules issue.  Join our Discord for support.


Variants not applying the correct selectors

Use https://github.com/tailwindcss/tailwindcss/blob/master/src/lib/substituteVariantsAtRules.js#L26 as reference for variants generation.
Earlier today I found that focus was not being correctly applied to placeholder pseudo elements. It was fixed in https://github.com/estevanmaito/tailwindcss-multi-theme/commit/0b5a4dd2f1280b83be46d42e48d7102aeac9dca6 but it probably affects every other variants like hover, active etc.
It's not breaking anything, but may not produce the expected result (like any result at all).
Will take a look at it later today or at least tomorrow.

:tada: This issue has been resolved in version 1.0.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


broken link

the link on the FQA is broken
it gives 404
(https://docs.microsoft.com/azure/load-balancer/concepts-limitations#load-balancer-types).
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 26f2ee4c-633b-8579-47e1-1543db5acaeb
Version Independent ID: 0baa18b9-14ca-1703-ba64-f036ec39b639
Content: Frequently asked questions - Azure Load Balancer
Content Source: articles/load-balancer/load-balancer-faqs.md
Service: load-balancer
GitHub Login: @erichrt
Microsoft Alias: errobin

@mailtogurvindersingh Thanks for the feedback! Both links have been updated, and the docs should reflect the change within 24 hours.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Missing carriage return in log

cf https://github.com/nvuillam/mega-linter/issues/665

Solved by https://github.com/nvuillam/markdown-table-formatter/pull/9


Extend ibc receive with advanced variant

This is an experiment towards solving https://github.com/CosmWasm/wasmd/issues/1220
To show it is possible and suggest a way forward. I do not expect this to be merged as is, and will likely need a lot of cleanup
Basically, I want to allow ibc_packet_receive to be able to return 3 types:

Ok - Success and return ack
Err - Rollback state changes and write an error string as ack
Abort - Completely rollback the transaction.

The last case is used in places where you have some external constaints. Eg. you only want whitelisted relayers to be able to relay on a channel. If another relayer submits the package, the whole Tx should fail, not just some error message. This is a very advanced use-case and not that common. Trying to "Rollback state changes and write an error string as ack" in an Ok response is very very difficult and we made the change to behavior of Err to empower 98% of the ibc contract devs. This is just for a very few special protocols that need a full abort.
My approach is to use another type for ibc_packet_receive. It returns AdvResult, which is like Result, but with a new ::Abort variant. There is a corresponding AdvContractError, which serializes like ContractError, but has one more variant.
The issue is that changing this is breaking to the API. My workaround is to add a new #[entry_point_adv] case, which generates the same ibc_packet_receive export, but has another handler that expects a function that returns AdvResult<> not Result<>. I demo how this can be used in ibc-reflect-send.
The other option I see if making this a CosmWasm 2.0 feature when we break APIs in a larger way. However, I would like to use this in some protocols in the next 3-6 months, and CosmWasm 2.0 seems much further off.

In #1644 you find a version that is doing more or less the same. But in contrast to this PR, it uses a generic result trait to avoid the need to change entry point macros.

As discussed, we use a different path documented in https://github.com/CosmWasm/cosmwasm/pull/1646


Better URL naming?

This seems to be an ongoing pain point at the moment.
Originally we had a set of custom filters than would add on the ?hl= to the end of a url if the person creating the content remembered to include it and we had a good number of places adding the '/web/' to the start of urls (both hardcoded and using the config variable).
To make this consistent I added a set of custom variables dedicated to URLs in WFPage.rb (See https://github.com/google/WebFundamentals/blob/material-branch/src/jekyll/_plugins/pages/WFPage.rb#L378) and removed the custom liquid filters.
Jake just raised an issue where the content had code along the lines of:

This equates to:

The fix is to simply reference the images relatively like so:

Are we happy with this being the case? I'm scared at the amount of confusion / the number of problems this seems to be creating.

Yep - works for me.

@gauntface - Can you update the bug title, tags, etc, along with the work so we can track what's on tap please?

@petele There is no work here if we are happy with the relative url of src="img/...." I just want to make sure we are

OK - yes, absolutely happy with that, seems the easiest way to go.


LLMonitor Callback Handler integration

Hi!
This PR adds a Callback Handler for LLMonitor, an open-source llm-ops platform.
This brings parity with the Python version where the callback handler is already available.
I added a new integration test as well as the relevant peer dependency and documentation.
The code was formatted and linted.
Twitter handles: @llmonitor_hq / @vincelwt
Let me know if anything needs to be changed.
Thank you and have a wonderful day.

Hey @vincelwt made a few small lint/build changes - most visible one is that we currently enforce entrypoints to be the same as paths under src.
If you really want to keep it as langchain/callbacks/llmonitor, we could make an index.ts file that exports the handler. LMK what you want to do.

Hi @jacoblee93 thanks for reviewing, making the changes asap

Ah @vincelwt already made them! Just wanted to make sure you saw and were aware of the entrypoint change

Oh awesome @jacoblee93, all good for me with the entrypoint change - thanks a lot

Awesome! Will get this merged and in the next release.


Investigate dependabot not returning CHANGELOG

Dependabot isn't picking up changes defined in the CHANGELOG
#46 might solve it but needs further investigation in dependabot docs, and possibly source code as to what logic it follows - e.g. does it need a Github release, or CHANGELOG should be sufficient?

Created a dummy project with dependabot to test this as a consumer:  https://github.com/heitorlessa/test-actions/commit/8ddf530c9b79f5ed24278308a71c5dcb5b6e5b24

@heitorlessa  works perfectly for me now

Mystery solved 🥳  Thanks for reporting back @michaelbrewer. Github release notes and repo automation next...


Pull request for libopenimageio-dev

For travis-ci/travis-ci#4497.
Ran tests and found no setuid bits.
See https://travis-ci.org/travis-ci/apt-whitelist-checker/builds/72071763

Sorry, but this test will have to be re-run. Will open a new one later.


Fix verify operators

This change ensures that verify-attached-operators does not fail if there are no bundle images attached. Also, it will look if a build is attached to an advisory if it is not shipped yet, and if so, it will assume that it will ship.

/lgtm


fix(plugins/plugin-bash-like): in headless mode, don't bother trying …

…to memoize user's alias and env
Fixes #7229
git cherry-pick 692fc3db32b557f87bce72bc9d7e7025536e13c2
[cherrypick13 33b572f82] fix(plugins/plugin-bash-like): in headless mode, don't bother trying to memoize user's alias and env

This has received extensive testing on the dev branch.
/lgtm


[Implementation] Refactor/improve async code (and synchronous code that should be async)

We have a bunch of code that should be asynchronous. This will make it more clear that these calls can take a while and the UI needs to handle this. This task involves making sure all method calls up the chain are async as well. Be sure to follow async best practices.

Any SQL calls should be made with DbConnection.OpenAsync(), DbCommand.ExecuteReaderAsync(), SqlDataReader.ReadAsync(), etc.
Any file IO should use File.WriteAsync()

I don't want to spend the time doing this unless we have clear user scenarios that are suffering because we aren't async.

We've been resolving these as we go. Closing! Thanks!


Kim2014 comparison, mhcflurry-predict tool, reimplement parallelization with futures

Add model selection and testing using Kim2014 data. I am still waiting for a run of this to complete, but when it does it will enable making a comparison against netMHC.
Add mhcflurry-predict tool
Reimplement parallelization using concurrent.futures

Coverage increased (+0.7%) to 76.741% when pulling c5d31dcae7caeee0fa5e171ebbbe078bafdb3ed2 on additions2 into 770a1e21b542283ee4990fe7a022e7fdbac1cea9 on master.

Coverage increased (+0.7%) to 76.741% when pulling 40b22f60f07d4d89ae198a9df0e93fbc0439af9b on additions2 into 770a1e21b542283ee4990fe7a022e7fdbac1cea9 on master.

@ihodes asked me earlier this week if we had an example notebook showing how to train and use a MHCflurry model. I just added a notebook illustrating some of the API to this PR, interested if people find it useful:
https://github.com/hammerlab/mhcflurry/blob/additions2/examples/class1_allele_specific_models.ipynb

LGTM

Coverage increased (+0.7%) to 76.741% when pulling 00d545ec2d2846bf2e9cb0e9d03b4a946433bc0b on additions2 into 770a1e21b542283ee4990fe7a022e7fdbac1cea9 on master.


Enhance support for bilibili videos in responsive video helper

This is an enhancement or feature.
This is a documentation change.

Summary

Enhance support for bilibili videos in responsive video helper

add a liquid variable called danmaku to control the danmaku function for the embed bilibili video only

add corresponding documentation

@mmistakes Repository owners can also mark a PR as a draft, which looks like a better alternative than tagging as "In Progress".


docs: adds docs tool, material for mkdocs, along with more fleshed ou…

…t docstrings.
this includes ability to serve up a local docs website.

make docs
mkdocs serve
make: mkdocs: No such file or directory
make: *** [docs] Error 1

Delete most the stuff chatgpt made. It highlights unimportant details.

I believe this has been completed.

make docs
mkdocs serve
make: mkdocs: No such file or directory
make: *** [docs] Error 1

This is probably because I didn't add necessary pip requirements.

mkdocs serve
ERROR   -  Config value 'plugins': The "mkdocstrings" plugin is not installed

Aborted with 1 configuration errors!
make: *** [docs] Error 1

mkdocs serve
ERROR   -  Config value 'plugins': The "mkdocstrings" plugin is not installed

Aborted with 1 configuration errors!
make: *** [docs] Error 1

Missed a package. They're all there now.


RLP-670/Fix-Refund-Transfers

This fixes the refund transfers, to make a refund transfer you need to make the next scenario:
        10 <- 10 B  2 -> 10
A ->                                <- D
        10 <- 10 C  10 -> 10

The balances of the channels are in the arrows of B and C nodes.
First of all, when trying a mediated transfer between A and D, the first route that transfer will try is A-B-C, when B-C fails, it will generated a refund from B to A, and then a mediated from A-C-D will happen. This is what we're trying to fix.
We find the next issues when trying this transfer:
-Node B will send a refund to A, and A is not performing a re-route to C (Fixed, and a mediated between A-D is perfomed now)
-B sends a refund message (matrix), and when receiving a Processed message, isn't removing the Refund from queue. This will generate a Lockexpired message that will remain on the queue
-When performing the first issue, now fixed, you cant make another mediated with refund. Only the first time it'll work, then it has a problem with the nonce expected.

Moved to PR 59


Async issues, code cleanup and some error handling

I haven't changed the package versions in package.json as I can't publish anything to NPM. These need to be manually adjusted after publishing.

PR was committed with small changes.


Support wildcard tables (and filter on _TABLE_SUFFIX) in read_gbq / read_gbq_table

Is your feature request related to a problem? Please describe.
In https://cloud.google.com/bigquery/docs/create-machine-learning-model there is the following SQL:
SELECT
  IF(totals.transactions IS NULL, 0, 1) AS label,
  IFNULL(device.operatingSystem, "") AS os,
  device.isMobile AS is_mobile,
  IFNULL(geoNetwork.country, "") AS country,
  IFNULL(totals.pageviews, 0) AS pageviews
FROM
  `bigquery-public-data.google_analytics_sample.ga_sessions_*`
WHERE
  _TABLE_SUFFIX BETWEEN '20160801' AND '20170630'

I'd like to be able to represent all of this in Python without any SQL code. There are two problems right now:

bigquery-public-data.google_analytics_sample.ga_sessions_* isn't supported as a table ID in read_gbq. This doesn't refer to any single table, so API requests based on the table ID will fail.

Even if (1) were supported, it would try to copy all the data into a temp table. It would be best to be able to specify a filter on _TABLE_SUFFIX at data read time.

Describe the solution you'd like
bpd.read_gbq("bigquery-public-data.google_analytics_sample.ga_sessions_*") should work.
Also, somewhat inspired by the BigQuery Storage API, accept a row_restriction parameter to filter rows.
bpd.read_gbq(
    "bigquery-public-data.google_analytics_sample.ga_sessions_*",
    filters=[("_TABLE_SUFFIX", ">=", '20160801'), ("_TABLE_SUFFIX", "<=", '20170630')],
)

See: https://cloud.google.com/bigquery/docs/reference/storage/rpc/google.cloud.bigquery.storage.v1#google.cloud.bigquery.storage.v1.ReadSession.TableReadOptions.FIELDS.string.google.cloud.bigquery.storage.v1.ReadSession.TableReadOptions.row_restriction
See also: "filters" parameter in pandas.read_parquet
Describe alternatives you've considered
SQL as an input to read_gbq works as an alternative right now.
Additional context
Related feature request on pandas-gbq:

https://github.com/googleapis/python-bigquery-pandas/issues/694 Add filters parameter to read_gbq

@Genesis929 This is affecting more BQML tutorials. I think we should try and find a solution for this sooner rather than later. I think it may require translation to SQL similar to your filters implementation.

fixed by https://github.com/googleapis/python-bigquery-dataframes/pull/377


Fixes config files

Signed-off-by: Puneet Punamiya<EMAIL_ADDRESS>

/ok-to-test

We need to update the github workflow as well to use config/kubernetes now though, to fix the CI.

We need to update the github workflow as well to use config/kubernetes now though, to fix the CI.

Updated


Experiment delete with unpublished dataset; problems?

If an experiment has one or more published datasets it cannot be deleted. However, if it has one or more unpublished datasets, it can be deleted and it is not clear what happens to the dataset in that case! This is especially a problem, as a dataset may have a DOI connected with it.

This should no longer be an issue. (1) a dataset with a DOI in an experiment or in any experiment with a project blocks the deletion of that experiment or project; same holds for a published dataset (2) a dataset that is publish or has an assigned DOI can not be directly deleted through the REST API; this is also blocked (3) if all the datasets in an experiment or in all the all the experiments of a project are deletable (neither published or having an assigned DOI) then they are deleted with the containing object is deleted.


cv2.error

Thanks for your excellent work. I test the BoT-SORT on MOT17 and MOT20. It works and shows good results. But when I test on my own video dataset, it shows errors.
My video format is mp4, 3.6MiB, dimension is 1920 x 1080, 1.01 Mbits/s with 25fps. Here is the error:
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------python tools/demo.py video -f yolox/exps/example/mot/yolox_x_mix_det.py -c yolox/pretrained/bytetrack_x_mot17.pth.tar --path ./videos/C06_1606.mp4 --with-reid --fp16 --fuse --save_result
2022-07-06 12:27:41.536 | INFO     | main:main:305 - Args: Namespace(ablation=False, appearance_thresh=0.2, aspect_ratio_thresh=1.6, camid=0, ckpt='yolox/pretrained/bytetrack_x_mot17.pth.tar', cmc_method='orb', conf=None, demo='video', device=device(type='cuda'), exp_file='yolox/exps/example/mot/yolox_x_mix_det.py', experiment_name='yolox_x_mix_det', fast_reid_config='fast_reid/configs/MOT17/sbs_S50.yml', fast_reid_weights='fast_reid/pretrained/mot17_ablation_sbs_S50.pth', fp16=True, fps=30, fuse=True, fuse_score=False, match_thresh=0.8, min_box_area=10, mot20=True, name=None, new_track_thresh=0.7, nms=None, path='./videos/C06_1606.mp4', proximity_thresh=0.5, save_result=True, track_buffer=30, track_high_thresh=0.6, track_low_thresh=0.1, trt=False, tsize=None, with_reid=True)
/home/kerwin/miniconda3/envs/FairMOT/lib/python3.8/site-packages/torch/functional.py:568: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at  /opt/conda/conda-bld/pytorch_1646755903507/work/aten/src/ATen/native/TensorShape.cpp:2228.)
return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]
2022-07-06 12:27:47.778 | INFO     | main:main:315 - Model Summary: Params: 99.00M, Gflops: 793.21
2022-07-06 12:27:47.780 | INFO     | main:main:323 - loading checkpoint
2022-07-06 12:27:49.678 | INFO     | main:main:327 - loaded checkpoint done.
2022-07-06 12:27:49.678 | INFO     | main:main:330 -        Fusing model...
/home/kerwin/miniconda3/envs/FairMOT/lib/python3.8/site-packages/torch/_tensor.py:1104: UserWarning: The .grad attribute of a Tensor that is not a leaf Tensor is being accessed. Its .grad attribute won't be populated during autograd.backward(). If you indeed want the .grad field to be populated for a non-leaf Tensor, use .retain_grad() on the non-leaf Tensor. If you access the non-leaf Tensor by mistake, make sure you access the leaf Tensor instead. See github.com/pytorch/pytorch/pull/30531 for more informations. (Triggered internally at  /opt/conda/conda-bld/pytorch_1646755903507/work/build/aten/src/ATen/core/TensorBody.h:475.)
return self._grad
2022-07-06 12:27:50.370 | INFO     | main:imageflow_demo:228 - video save_path is ./YOLOX_outputs/yolox_x_mix_det/track_vis/2022_07_06_12_27_50/C06_1606.mp4
Skip loading parameter 'heads.weight' to the model due to incompatible shapes: (487, 2048) in the checkpoint but (0, 2048) in the model! You might want to double check if this is expected.
2022-07-06 12:27:51.439 | INFO     | main:imageflow_demo:238 - Processing frame 0 (100000.00 fps)
Traceback (most recent call last):
File "tools/demo.py", line 366, in
main(exp, args)
File "tools/demo.py", line 354, in main
imageflow_demo(predictor, vis_folder, current_time, args)
File "tools/demo.py", line 251, in imageflow_demo
online_targets = tracker.update(detections, img_info)
File "/home/kerwin/temp/BoT-SORT/tracker/bot_sort.py", line 286, in update
warp = self.gmc.apply(img, dets)
File "/home/kerwin/temp/BoT-SORT/tracker/gmc.py", line 62, in apply
return self.applyFeaures(raw_frame, detections)
File "/home/kerwin/temp/BoT-SORT/tracker/gmc.py", line 205, in applyFeaures
H, inliesrs = cv2.estimateAffinePartial2D(prevPoints, currPoints, cv2.RANSAC)
cv2.error: OpenCV(4.6.0) /io/opencv/modules/calib3d/src/ptsetreg.cpp:1108: error: (-215:Assertion failed) count >= 0 && to.checkVector(2) == count in function 'estimateAffinePartial2D'

Hi, please try to use the demo.py I uploaded today.
Please let me know if errors occur.

In code just pulled right now, seeing same error after a few hundred frames of tracking successfully.

I found out that for cmc-method with ORB flag, the OpenCV function estimateAffinePartial2D could get too few matching points, which lead to an error.
I just updated the gmc.py code.
Thank you for your help.

Thanks @NirAharon , this is almost exactly what i ended up doing too. Appreciate your quick help.
BotSORT has been quite a nice improvement for me on challenging sports tracking cases. Thank you for the great tech!

Hi @NirAharon , I just clone new code today, when demo I keep getting the same error. Can anyone help me figure out why?
[6:14 PM] Nguyen Minh Duc (QAI.DEL)
File "tools/demo.py", line 371, in
main(exp, args)
File "tools/demo.py", line 359, in main
imageflow_demo(predictor, vis_folder, current_time, args)
File "tools/demo.py", line 255, in imageflow_demo
online_targets = tracker.update(detections, img_info["raw_img"])
File "/home/Akacam/ducnm57/akacam_tracking/bot_tracking/tracker/bot_sort.py", line 285, in update
warp = self.gmc.apply(img, dets)
File "/home/Akacam/ducnm57/akacam_tracking/bot_tracking/tracker/gmc.py", line 62, in apply
return self.applyFeaures(raw_frame, detections)
File "/home/Akacam/ducnm57/akacam_tracking/bot_tracking/tracker/gmc.py", line 205, in applyFeaures
H, inliesrs = cv2.estimateAffinePartial2D(prevPoints, currPoints, cv2.RANSAC)
cv2.error: OpenCV(4.6.0) /io/opencv/modules/calib3d/src/ptsetreg.cpp:1108: error: (-215:Assertion failed) count >= 0 && to.checkVector(2) == count in function 'estimateAffinePartial2D
My command: python3 tools/demo.py video --path ./videos/cam1_ds.mp4 -f yolox/exps/example/mot/yolox_s_mix_det.py -c pretrained/bytetrack_s_mot17.pth.tar --with-reid --fuse-score --fp16 --fuse --save_result


Add code coverage

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b60088c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage          ?   75.36%
=========================================
  Files             ?       11
  Lines             ?      406
  Branches          ?       48
=========================================
  Hits              ?      306
  Misses            ?       80
  Partials          ?       20

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60088c...5e38db9. Read the comment docs.


Fix disable DR for regional-dr and RBD storage

Testing disabling dr flow shows that when we delete a VRG, we abort
undoPVCFinalizersAndPVRetention() because the PVC has the ramen-restore
annotation:
volumereplicationgroups.ramendr.openshift.io/ramen-restore: "True"

and the PVC is used by the pod. Since the VR is not deleted, the VRG
deletion never completes.
Deleting the PVC is never needed since the PVC has the annotation:
apps.open-cluster-management.io/hosting-subscription: busybox-sample/busybox-sub

The annotation means that the resource is owned by the subscription and
will be deleted when the subscription will be deleted.
I could not find any OCM documentation for this, but the option is
mentioned in ACM docs indirectly[1]. According to Benamar, this works in
ACM 2.8.
This change removes the delete PVC step, fixing disable DR flow for RBD
storage.
Notes:

Metro-DR should not be affected by this issue since there is not VR.
VolSync is not affected by this change, and it also does use the
ramen-restore annotation, so it many not support yet Disable DR.
Not tested with application sets, since we don't have any integration
with in the test environment.
Not tested with OCP yet

[1] https://access.redhat.com/documentation/en-us/red_hat_advanced_cluster_management_for_kubernetes/2.5/html/applications/managing-applications#mergeandown-option
Related changes:

#1012 adds a system test testing enabling and disabling dr

depends on https://github.com/RamenDR/ocm-ramen-samples/pull/35

Fixes: #833
Updates: 165fec276514
Related-to: #152

Tests done with v1.
Testing deploy and configure ramen
$ ramenctl deploy $env; ramenctl config $env
2023-07-27 00:25:21,869 INFO    [ramenctl] Starting deploy
2023-07-27 00:25:21,875 INFO    [ramenctl] Saving image 'quay.io/ramendr/ramen-operator:latest'
2023-07-27 00:25:24,468 INFO    [ramenctl] Loading image in cluster 'hub'
2023-07-27 00:25:24,468 INFO    [ramenctl] Loading image in cluster 'dr1'
2023-07-27 00:25:24,469 INFO    [ramenctl] Loading image in cluster 'dr2'
2023-07-27 00:25:35,670 INFO    [ramenctl] Deploying ramen operator in cluster 'hub'
2023-07-27 00:25:39,707 INFO    [ramenctl] Deploying ramen operator in cluster 'dr1'
2023-07-27 00:25:42,733 INFO    [ramenctl] Deploying ramen operator in cluster 'dr2'
2023-07-27 00:25:46,069 INFO    [ramenctl] Finished deploy in 24.20 seconds
2023-07-27 00:25:46,267 INFO    [ramenctl] Starting config
2023-07-27 00:25:46,274 INFO    [ramenctl] Waiting until ramen-hub-operator is rolled out
2023-07-27 00:25:49,131 INFO    [ramenctl] Creating s3 secret in ramen hub namespace
2023-07-27 00:25:50,388 INFO    [ramenctl] Creating cloud credentials secret in cluster 'dr1'
2023-07-27 00:25:51,801 INFO    [ramenctl] Creating cloud credentials secret in cluster 'dr2'
2023-07-27 00:25:53,280 INFO    [ramenctl] Updating ramen config map
2023-07-27 00:25:53,743 INFO    [ramenctl] Creating dr-clusters for regional-dr
2023-07-27 00:25:54,128 INFO    [ramenctl] Creating dr-policy for regional-dr
2023-07-27 00:25:54,412 INFO    [ramenctl] Waiting until DRClusters report phase
2023-07-27 00:25:55,078 INFO    [ramenctl] Waiting until DRClusters phase is available
2023-07-27 00:25:55,345 INFO    [ramenctl] Waiting until DRPolicy is validated
2023-07-27 00:25:55,589 INFO    [ramenctl] Finished config in 9.32 seconds
Testing basic test run
$ test/basic-test/run $env
2023-07-27 00:26:47,882 INFO    [deploy] Deploying on cluster 'dr1'
2023-07-27 00:26:47,882 INFO    [deploy] Creating temporary directory /tmp/ramen-test/basic-test
2023-07-27 00:26:47,882 INFO    [deploy] Cloning ocm-ramen-samples
2023-07-27 00:26:47,882 INFO    [deploy] Creating kustomization for using cluster 'dr1'
2023-07-27 00:26:47,883 INFO    [deploy] Deploying busybox example application
2023-07-27 00:26:48,455 INFO    [deploy] waiting for namespace busybox-sample
2023-07-27 00:26:48,523 INFO    [deploy] Waiting until busybox drpc reports phase
2023-07-27 00:26:48,897 INFO    [deploy] Waiting until busybox drpc is deployed
2023-07-27 00:26:49,056 INFO    [deploy] Waiting until application is replicated
2023-07-27 00:28:18,126 INFO    [deploy] Application was deployed successfully
2023-07-27 00:28:18,247 INFO    [failover] Failing over to cluster 'dr2'
2023-07-27 00:28:18,247 INFO    [failover] Waiting until application is replicated
2023-07-27 00:28:18,304 INFO    [failover] Starting failover
2023-07-27 00:28:18,382 INFO    [failover] Waiting until application is failed over...
2023-07-27 00:28:48,147 INFO    [failover] Waiting until application is replicated
2023-07-27 00:31:48,164 INFO    [failover] Application was failed over to cluster dr2 successfully
2023-07-27 00:31:48,316 INFO    [relocate] Relocate to cluster 'dr1'
2023-07-27 00:31:48,316 INFO    [relocate] Waiting until peer is ready
2023-07-27 00:31:48,482 INFO    [relocate] Waiting until application is replicated
2023-07-27 00:31:48,552 INFO    [relocate] Starting relocate
2023-07-27 00:31:48,639 INFO    [relocate] Waiting until application is relocated...
2023-07-27 00:33:48,121 INFO    [relocate] Waiting until relocation completes...
2023-07-27 00:34:18,224 INFO    [relocate] Application was relocated to cluster dr1 successfully
2023-07-27 00:34:18,411 INFO    [undeploy] Deleting busybox example application
2023-07-27 00:34:53,885 INFO    [undeploy] Application was undeployed successfully
Testing disable and enable DR in Deployed state
$ test/basic-test/deploy $env
2023-07-27 00:37:11,342 INFO    [deploy] Deploying on cluster 'dr1'
2023-07-27 00:37:11,342 INFO    [deploy] Creating temporary directory /tmp/ramen-test/basic-test
2023-07-27 00:37:11,343 INFO    [deploy] Cloning ocm-ramen-samples
2023-07-27 00:37:11,343 INFO    [deploy] Creating kustomization for using cluster 'dr1'
2023-07-27 00:37:11,343 INFO    [deploy] Deploying busybox example application
2023-07-27 00:37:11,784 INFO    [deploy] waiting for namespace busybox-sample
2023-07-27 00:37:11,847 INFO    [deploy] Waiting until busybox drpc reports phase
2023-07-27 00:37:12,079 INFO    [deploy] Waiting until busybox drpc is deployed
2023-07-27 00:37:12,244 INFO    [deploy] Waiting until application is replicated
2023-07-27 00:41:41,193 INFO    [deploy] Application was deployed successfully
$ kubectl delete drpc/busybox-drpc -n busybox-sample --context hub
drplacementcontrol.ramendr.openshift.io "busybox-drpc" deleted
$ test/basic-test/deploy $env
2023-07-27 00:44:16,347 INFO    [deploy] Deploying on cluster 'dr1'
2023-07-27 00:44:16,348 INFO    [deploy] Creating temporary directory /tmp/ramen-test/basic-test
2023-07-27 00:44:16,348 INFO    [deploy] Cloning ocm-ramen-samples
2023-07-27 00:44:16,348 INFO    [deploy] Creating kustomization for using cluster 'dr1'
2023-07-27 00:44:16,348 INFO    [deploy] Deploying busybox example application
2023-07-27 00:44:16,909 INFO    [deploy] waiting for namespace busybox-sample
2023-07-27 00:44:16,983 INFO    [deploy] Waiting until busybox drpc reports phase
2023-07-27 00:44:36,141 INFO    [deploy] Waiting until busybox drpc is deployed
2023-07-27 00:44:36,316 INFO    [deploy] Waiting until application is replicated
2023-07-27 00:45:46,222 INFO    [deploy] Application was deployed successfully
Testing disable and enable DR in FailedOver state
$ test/basic-test/failover $env
2023-07-27 00:46:05,636 INFO    [failover] Failing over to cluster 'dr2'
2023-07-27 00:46:05,636 INFO    [failover] Waiting until application is replicated
2023-07-27 00:46:05,706 INFO    [failover] Starting failover
2023-07-27 00:46:05,800 INFO    [failover] Waiting until application is failed over...
2023-07-27 00:46:46,164 INFO    [failover] Waiting until application is replicated
2023-07-27 00:49:46,241 INFO    [failover] Application was failed over to cluster dr2 successfully
$ kubectl delete drpc/busybox-drpc -n busybox-sample --context hub
drplacementcontrol.ramendr.openshift.io "busybox-drpc" deleted
$ test/basic-test/deploy --cluster dr2 $env
2023-07-27 00:50:42,931 INFO    [deploy] Deploying on cluster 'dr2'
2023-07-27 00:50:42,931 INFO    [deploy] Creating temporary directory /tmp/ramen-test/basic-test
2023-07-27 00:50:42,932 INFO    [deploy] Cloning ocm-ramen-samples
2023-07-27 00:50:42,932 INFO    [deploy] Creating kustomization for using cluster 'dr2'
2023-07-27 00:50:42,932 INFO    [deploy] Deploying busybox example application
2023-07-27 00:50:43,386 INFO    [deploy] waiting for namespace busybox-sample
2023-07-27 00:50:43,466 INFO    [deploy] Waiting until busybox drpc reports phase
2023-07-27 00:51:20,576 INFO    [deploy] Waiting until busybox drpc is deployed
2023-07-27 00:51:20,741 INFO    [deploy] Waiting until application is replicated
2023-07-27 00:52:43,148 INFO    [deploy] Application was deployed successfully
Testing disable and enable DR in Relocated state
$ test/basic-test/relocate --cluster dr1 $env
2023-07-27 00:53:11,898 INFO    [relocate] Relocate to cluster 'dr1'
2023-07-27 00:53:11,898 INFO    [relocate] Waiting until peer is ready
2023-07-27 00:53:12,055 INFO    [relocate] Waiting until application is replicated
2023-07-27 00:53:12,113 INFO    [relocate] Starting relocate
2023-07-27 00:53:12,189 INFO    [relocate] Waiting until application is relocated...
2023-07-27 00:55:13,175 INFO    [relocate] Waiting until relocation completes...
2023-07-27 00:55:43,188 INFO    [relocate] Application was relocated to cluster dr1 successfully
$ kubectl delete drpc/busybox-drpc -n busybox-sample --context hub
drplacementcontrol.ramendr.openshift.io "busybox-drpc" deleted
$ test/basic-test/deploy --cluster dr1 $env
2023-07-27 00:58:39,278 INFO    [deploy] Deploying on cluster 'dr1'
2023-07-27 00:58:39,278 INFO    [deploy] Creating temporary directory /tmp/ramen-test/basic-test
2023-07-27 00:58:39,278 INFO    [deploy] Cloning ocm-ramen-samples
2023-07-27 00:58:39,278 INFO    [deploy] Creating kustomization for using cluster 'dr1'
2023-07-27 00:58:39,279 INFO    [deploy] Deploying busybox example application
2023-07-27 00:58:39,683 INFO    [deploy] waiting for namespace busybox-sample
2023-07-27 00:58:39,743 INFO    [deploy] Waiting until busybox drpc reports phase
2023-07-27 00:59:28,530 INFO    [deploy] Waiting until busybox drpc is deployed
2023-07-27 00:59:28,701 INFO    [deploy] Waiting until application is replicated
2023-07-27 01:00:39,217 INFO    [deploy] Application was deployed successfully
Testing undeploy app
$ test/basic-test/undeploy $env
2023-07-27 01:01:36,711 INFO    [undeploy] Deleting busybox example application
2023-07-27 01:01:42,175 INFO    [undeploy] Application was undeployed successfully
Testing unconfigure and undeploy ramen
$ ramenctl unconfig $env
2023-07-27 01:01:57,486 INFO    [ramenctl] Starting unconfig
2023-07-27 01:01:57,492 INFO    [ramenctl] Deleting dr-policy for regional-dr
2023-07-27 01:01:57,664 INFO    [ramenctl] Deleting dr-clusters for regional-dr
2023-07-27 01:01:57,987 INFO    [ramenctl] Deleting s3 secret in ramen hub namespace
2023-07-27 01:01:58,119 INFO    [ramenctl] Deleting cloud credentials secret in cluster 'dr1'
2023-07-27 01:01:58,223 INFO    [ramenctl] Deleting cloud credentials secret in cluster 'dr2'
2023-07-27 01:01:58,335 INFO    [ramenctl] Finished unconfig in 0.85 seconds
$ ramenctl undeploy $env
2023-07-27 01:02:04,600 INFO    [ramenctl] Starting undeploy
2023-07-27 01:02:04,607 INFO    [ramenctl] Undeploying ramen operator in cluster 'dr1'
2023-07-27 01:02:10,430 INFO    [ramenctl] Undeploying ramen operator in cluster 'dr2'
2023-07-27 01:02:12,362 INFO    [ramenctl] Undeploying ramen operator in cluster 'hub'
2023-07-27 01:02:20,273 INFO    [ramenctl] Finished undeploy in 15.67 seconds

v2 minimize the change and avoid trouble with golangci-lint.

In ACM 2.8, they now delete resources even if they were not created by the Subscription but are part of the deployment resources. In simple terms, as long as a resource has the annotation:
apps.open-cluster-management.io/hosting-subscription: busybox-sample/busybox-sub

then ACM will clean it up.
In the past, we asked the ACM team to add a setting called reconcile-option with the value mergeAndOwn. This setting ensured that any changes made to the resource upstream would be updated in the managed cluster, and any operations on the resource, like delete, would also be applied. The ACM team did provide this option as requested.
However, in the latest version, it appears that they made this behavior the default, without requiring the mergeAndOwn reconcile option.

In ACM 2.8, they now delete resources even if they were not created by the Subscription but are part of the deployment resources. In simple terms, as long as a resource has the annotation:
apps.open-cluster-management.io/hosting-subscription: busybox-sample/busybox-sub

then ACM will clean it up.

It seems the other call to deletePVCIfNotInUse in the `reconcileVRAsSecondary' routine should be removed also since ACM should delete it when it undeploys the application.
One use case that may need this behavior is disable-DR-but-preserve-backups.  Say a user wants to temporarily disable DR, but still be able to recover from a backup.  I'm thinking of an imperatively-defined application with a large backup that the user doesn't want to have to recreate.

It seems the other call to deletePVCIfNotInUse in the `reconcileVRAsSecondary' routine should be removed also since ACM should delete it when it undeploys the application.
One use case that may need this behavior is disable-DR-but-preserve-backups. Say a user wants to temporarily disable DR, but still be able to recover from a backup. I'm thinking of an imperatively-defined application with a large backup that the user doesn't want to have to recreate.

@hatfieldbrian It can probably be removed but it is not related to disable dr with rbd storage (which is my focus in this pr). In disable dr flows we are always removing the primary vrg/vr.
If we have a bug in specific disable dr/kube object protection flow, can you file an issue about it with reproduction steps?

It seems the other call to deletePVCIfNotInUse in the `reconcileVRAsSecondary' routine should be removed also since ACM should delete it when it undeploys the application.

@hatfieldbrian Technically correct, we do not need to delete the PVCs.
The move to Secondary passes because we have already instructed OCM to remove the App from the cluster, hence the PVC would eventually be not in use and we would delete it if it is not already deleted.

One use case that may need this behavior is disable-DR-but-preserve-backups. Say a user wants to temporarily disable DR, but still be able to recover from a backup. I'm thinking of an imperatively-defined application with a large backup that the user doesn't want to have to recreate.

@hatfieldbrian It can probably be removed but it is not related to disable dr with rbd storage (which is my focus in this pr). In disable dr flows we are always removing the primary vrg/vr.

@nirs disable DR is the test case, the problem in the code is the attempt to delete a PVC, which currently is not required.  Which should hence be fixed everywhere or tracked as an issue for action in the future, request you to open one to track the same.

@hatfieldbrian It can probably be removed but it is not related to disable dr with rbd storage (which is my focus in this pr). In disable dr flows we are always removing the primary vrg/vr.

@nirs disable DR is the test case, the problem in the code is the attempt to delete a PVC, which currently is not required. Which should hence be fixed everywhere or tracked as an issue for action in the future, request you to open one to track the same.

Added #1022.
@hatfieldbrian I don't follow your comment on "disable DR, but still be able to recover from a backup" - disable dr does not keep replicated data so it is likely does not keep backups. Who will own and remove the backups if you disabled DR? Maybe we need Pause DR - stop replication and backup without deleting the replicated or backed up data, so you can resume DR quickly later.
Please add more info about this to #1022 if needed.

LGTM.  Please test with AppSet before merging...

Benamar and me discussed this today, here is a summary:

Current PR works only for RBD mirroring - I will make it more clear in the commit message
I will test with applicationsets, Benamar thinks it should work
For volsync this change does not help since we have different ownership model. We discussed how to change the ownership so the PVC is owned by subscription by default, in the same way this works for RBD. I will add an new issue for this work.


Giant (~5GB) Args.dump-hi file with ghc 8.2.2 and -O2

When compiling the following with ghc 8.2.2 and -O2 it takes forever and it leaves me with a gigantic (about 5GB) Args.dump-hi file
data Options w = Options
  { database :: w ::: Maybe String  <?> "PostgreSQL database name"
  , host     :: w ::: Maybe String  <?> "PostgreSQL host"
  , httpPort :: w ::: Maybe Int     <?> "Web server port"
  , port     :: w ::: Maybe Integer <?> "PostgreSQL port"
  , secret   :: w ::: Maybe String  <?> "PostgreSQL password"
  , user     :: w ::: Maybe String  <?> "PostgreSQL user"
  } deriving (Generic)

instance ParseRecord (Options Wrapped)
deriving instance Show (Options Unwrapped)

When compiling with -O0 it works as intended. No large files and compiling is fast.
Switching to ghc 8.0.2 fixes the issue. Here both -O0 and -O2 works without a hitch. Fast compiling and no large build artifacts.
I suspect this is actually a bug in 8.2.2. Sadly I'm forced to use 8.2.2. I would really like to continue using Optparse-Generic. Anybody aware of any clever workarounds that might mitigate this issue?

This looks very similar to https://github.com/Gabriel439/Haskell-Optparse-Generic-Library/issues/47

@Gabriel439 you're right, it does. Except #47 experience the problem with 8.0.2 where I have it with 8.2.2 and not 8.0.2, the latter actually fixing it for me.
This is very odd, and quite unfortunate. I was really enjoying Optparse-Generic, but I guess it's back to parseargs until we move away from 8.2.2.

Yeah, the best guess I have is that it is a GHC compiler bug since it works for different versions of the compiler and different optimization flags

@Gabriel439 interestingly the problem goes away if I change the code to this:
data Options = Options
  { database :: Maybe String  <?> "PostgreSQL database name"
  , host     :: Maybe String  <?> "PostgreSQL host"
  , httpPort :: Maybe Int     <?> "Web server port"
  , port     :: Maybe Integer <?> "PostgreSQL port"
  , secret   :: Maybe String  <?> "PostgreSQL password"
  , user     :: Maybe String  <?> "PostgreSQL user"
  , version  :: Bool          <?> "Version of norih"
  } deriving (Generic, Show)

instance ParseRecord Options

So it seems to be related to the whole Wrapped/UnWrapped thing.

I can live with manually having to unbox the individual options, but it eludes me how to do that. How do I actually get to the user Maybe String after having called getRecord? The type has a weird shape that is definitely a cut above my pay grade!  :smiley:

@ThomasLocke: If you got rid of the Wrapped/Unwrapped stuff then you no longer need the <?> operators any longer.  You can turn them into comments:
data Options = Options
  { database :: Maybe String  -- ^ "PostgreSQL database name"
  , host     :: Maybe String  -- ^ "PostgreSQL host"
  , httpPort :: Maybe Int     -- ^ "Web server port"
  , port     :: Maybe Integer -- ^ "PostgreSQL port"
  , secret   :: Maybe String  -- ^ "PostgreSQL password"
  , user     :: Maybe String  -- ^ "PostgreSQL user"
  } deriving (Generic, Show)

@Gabriel439 but then I lose my fancy-pancy help output - or rather, it's still there, it's just a whole lot less fancy-pancy.
Or am I missing something?

@ThomasLocke: Sorry, my mistake.  You're right.
So if you keep the (<?>) operators and don't use Wrapped/Unwrapped then you need to unwrap each field using the unHelpful function:
unHelpful :: a <?> s -> a

The amount of awesome here is, well, awesome.
This just works. Thank you so very much for the help @Gabriel439

You're welcome! :slightly_smiling_face:


Add ability to edit existing notes

If that proves intractable the ability to cut&paste would provide a workaround & would be independently useful

Yes, please!!

+1 ...Any timetable on this? Being unable to edit existing notes is pretty limiting.

I've been quite busy recently, but this will be the next thing I'll look into.


Annotation of lncRNAs

In concert with with miRNA/transcription working groups.

[ ] Terms to describe molecular functions of lncRNAs (see GO ontology tracker)
Review all long non-coding RNAs in D.mel and annotate
[ ] Start with examples from reviews
[ ] list and review all lncRNAs

Reviews:

Drosophila as a Model to Gain Insight into the Role of lncRNAs in Neurological Disorders
Insights into the Functions of LncRNAs in Drosophila.
Functions of long non-coding RNAs in human disease and their conservation in Drosophila development.
Genomic and functional conservation of lncRNAs: lessons from flies


Support sparse arrays in sklearn estimators

Description
Some scikit-learn estimators (eg. tokenizers) transform methods will output sparse matrices. Currently our sklearn estimators will fail on this kind of input.
Questions/Ideas

Maybe do it at the same time with #95
In first instance just transform to dense array (??)
Use Khiops sparse features to treat this kind of table

Transform the sparse table to the Khiops format
Use sparse blocks when creating the dictionary

Does this generates another dependency (scipy) ? No
SVM format is admitted by sklearn ? A priori yes.

Verify if it still fails.

We need to support the csr_matrix type in the tables.py/Dataset class.

We need to refer to https://khiops.org/setup/KhiopsGuide.pdf#page=81 for sparse data support in Khiops itself.


Rendering bug when a linefeed is inserted at the end of the edited line

Reported here.
The bug is related to this code/optimisation.

Fixed in version 6.0.0


Fix tdD - using uint32_t

This PR addressed the issue in #34. It should be a uint32_t for tdD while uint64_t for tdm, according to the docs here.

Glorious, thank you! :green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:


DirectoryFormat: expose capture groups from the pathspec

Comments
This would cut down on duplicated parsing allowing the directory format to basically define what would be yielded by iter_views (other than the view).
Questions
This depends a little bit on #128 as it is usually the consumer of what is yielded. Is it possible to make that dependency transparent? Is that even a good thing to do?
References
#128

@ebolyen reopen if you think this is really important, but seems to have fallen by the wayside


Error:(27, 18) use of undeclared type 'PINAnimatedImageView'

Error:(27, 18) use of undeclared type 'PINAnimatedImageView'
what is it?
version is
pod 'PINRemoteImage', '~>3.0.0-beta.13'
pod 'PINRemoteImage/WebP', '~>3.0.0-beta.13'

@choiks14 can you provide a bit more information? PINAnimatedImageView is a UIImageView subclass which displays animated images (GIF and webp so far).

It's not released yet so you should use latest master instead of '~>3.0.0-beta.13'

Still facing the same issue. Isn't it updated yet?


⚠ SceneTime has degraded performance

In 4e9c357, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 2868 ms

Resolved: SceneTime performance has improved in 6180c63 after 7 minutes.


Stack Upgrade not working?

Hello,
I updated EE to v3.1.2 from v3.1.1 and i fired ee stack upgrade to upgrade my stack, PHP in particular but it doesn't seem to be working. I still have PHP v5.5, am i missing something?
I also tried with --php flag, no effect.
How do i upgrade if this is not the correct method?

What happens when you apt-get update then apt-get upgrade outside of ee?  I was just merging any conflicts myself, like with php pool config or php.ini's.  I have yet to use the ee upgrade functionality.

@cm896 apt-get update updated fine and then upgrade gave an output of this:
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following packages have been kept back:
  linux-generic linux-headers-generic linux-image-generic
The following packages will be upgraded:
  apport apt apt-transport-https apt-utils base-files bind9-host bsdutils
  ca-certificates cloud-guest-utils cloud-init coreutils cpio dnsutils dpkg
  e2fslibs e2fsprogs file gnupg gpgv initscripts isc-dhcp-client
  isc-dhcp-common krb5-locales landscape-common language-pack-en
  language-pack-en-base libapt-inst1.5 libapt-pkg4.12 libasn1-8-heimdal
  libbind9-90 libblkid1 libbsd0 libc-bin libcgmanager0 libcomerr2
  libcurl3-gnutls libdns100 libdrm2 libedit2 libelf1 libfreetype6 libgcrypt11
  libgnutls-openssl27 libgnutls26 libgssapi-krb5-2 libgssapi3-heimdal
  libhcrypto4-heimdal libheimbase1-heimdal libheimntlm0-heimdal
  libhx509-5-heimdal libicu52 libisc95 libisccc90 libisccfg90 libjson-c2
  libjson0 libk5crypto3 libkrb5-26-heimdal libkrb5-3 libkrb5support0
  liblwres90 libmagic1 libmount1 libnuma1 libpam-systemd libpolkit-agent-1-0
  libpolkit-backend-1-0 libpolkit-gobject-1-0 libprocps3 libroken18-heimdal
  libss2 libsystemd-daemon0 libsystemd-login0 libtasn1-6 libudev1 libuuid1
  libwind0-heimdal libxext6 libyaml-0-2 linux-libc-dev mount multiarch-support
  ntpdate openssl patch policykit-1 procps python-apt python-apt-common
  python-requests python-urllib3 python-yaml python3-apport
  python3-distupgrade python3-problem-report rsyslog sudo systemd-services
  sysv-rc sysvinit-utils tcpdump tzdata ubuntu-release-upgrader-core udev
  unattended-upgrades util-linux uuid-runtime wpasupplicant
108 upgraded, 0 newly installed, 0 to remove and 3 not upgraded.
Need to get 27.5 MB of archives.
After this operation, 391 kB disk space will be freed.
Do you want to continue? [Y/n]

I let it upgrade the above packages too, So it ended up with success and no issues. This is after my previous usage of ee stack upgrade. However, PHP is still not updated to the 5.6 version.
On Ubuntu 14.04 btw.

Nevermind, I just checked the docs and they were updated with this new command:
ee stack upgrade --php56
``

It works fine.


Adds doc and source entries for grasp_synergy package.

As suggested in #11543

lgtm. note that these jobs will not get generated until tomorrow night's reconfigure and the doc jobs only runevery 3 days so it may be a little while before you see the results.

The doc and source entry should point to the upstream repo, not the release repo. The master branch of the release repo contains no ROS packages.


Addressed unchecked return value in AllowanceCrowdsale #945 using SafeERC20

Fixes #945
🚀 Description

Addressed unchecked return value in AllowanceCrowdsale #945 using SafeERC20.

[x] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[x] ✅ I've added tests where applicable to test my new functionality.
[x] 📖 I've made sure that my contracts are well-documented.
[x] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:all:fix).

Thank you @dougiebuckets. Can you please resolve the conflicts?
And Crowdsale.sol is also using transfer instead of safeTransfer. I think it would make sense to update it in this PR.

@elopio - Thanks for the heads up! Should be all set.


Converts registry.NetIPNet to string

Resolves #116.
Replaces docker engine-api-types registry.NetIPNet with a string as the
marshaller is actually custom written for this type to turn the byte
stream into a string on the service side.

Hi @jterry75, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Justin Terry (VM)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

LGTM