View space maximization

The new update from today added a new darker bar and filters, which is super useful.
But the new bar also takes up more height revenue from the map. Would it be possible to either move the filter to the top white bar with the rest of the items or have the setting hide themselves on the left instead of taking up the space from the height of the map? I have a 1366x768 Monitor and I'd rather lose more space from the width than lose height.
EDIT: I've noticed now that the mobile uses this bar, didn't know this before. I still use my laptop when scanning for pokemon on the go and would still like to see the height space increased as much as possible for PC if possible.

Ithink part of the space consumption goes to the variance in size of names. Some names are much larger and take up more space. Icons would be more efficient for UI real estate. Names are useful for selecting what you want to filter, icons are more useful for "at a glance" information, like what is currently being filtered already.

The new bar that has been added is my main concern.
With the addition of this darker bar that now has the Filter rules on it we've lost another 51px of height to the Map view. on a larger monitor this is probably negligible, and this is probably still unnoticeable on a 4:3 screen but on a screen at 16:9 with smaller resolutions this loss of Map view space is very noticeable.
Windows 7 For example:

SuperBar takes up 39px
Titlebar if maximized takes up 22px
Menubar takes up 20px
The White bar takes up 50px
The new Filter bar takes up 51px

if you add this all up you have 182px of space, on a screen that has a height of 768px that lost space is a huge deal.


Exporting uifigure

Hi,
I am trying to use the export_fig code within the Matlab App Designer. I am trying to export the figure with the following code:
export_fig(figureHandle, path2file, '-pdf', '-png', '-m1.5');

However, as I execute the code the following error is shown:
Error using matlab.ui.Figure/set
Functionality not supported with figures created with the uifigure function. For more information,
see Graphics Support in App Designer.

Error in export_fig (line 397)
        set(fig, 'InvertHardcopy', 'off');

How can I run export_fig with uifigures?
Thanks a lot!

Figures created using App Designer or the uifigure command are not supported by export_fig, as long as Matlab does not support the built-in print function with such figures. This is still the case as of R2018b:
https://www.mathworks.com/help/releases/R2018b/matlab/creating_guis/graphics-support-in-app-designer.html
There is no possible solution or workaround for uifigures until this changes.

Fixed, please recheck

@MarvinILA how do yo do that?

@alfredoqt that's pretty easy. Please find below my code. Of course you might have to do some adjustments for your case.
% Convert UIFigure to normal figure
fig = figure('Units', app.YourPlot.Units, 'Position', app.YourPlot.Position, 'InnerPosition', app.YourPlot.InnerPosition, 'OuterPosition', app.YourPlot.OuterPosition);

% Set figure to be invisible
set(fig, 'MenuBar', 'none', 'ToolBar', 'none', 'Visible', 'off');

% Get figure axes
figAxes = axes(fig);

% Get all the children from the UIFigure
allChildren = app.YourPlot.Children;

% Copy all children to the new figure
copyobj(allChildren, figAxes)

% Set axes limits
figAxes.XLim = app.YourPlot.XLim;
figAxes.YLim = app.YourPlot.YLim;
figAxes.ZLim = app.YourPlot.ZLim;

% Modify the legend
lgndName = app.YourPlot.Legend.String;
lgd = legend(YourPlotsToAppearInTheLegend, lgndName);
lgd.Box = app.YourPlot.Legend.Box;
lgd.Location = app.YourPlot.Legend.Location;
lgd.FontSize = app.YourPlot.Legend.FontSize;

% Set axes labels
figAxes.YLabel.String = app.YourPlot.YLabel.String;
figAxes.YLabel.FontSize = app.YourPlot.YLabel.FontSize;
figAxes.XLabel.String = app.YourPlot.XLabel.String;
figAxes.XLabel.FontSize = app.YourPlot.XLabel.FontSize;

% Set title
figAxes.Title.String = app.YourPlot.Title.String;
figAxes.Title.FontSize = app.YourPlot.Title.FontSize;

% Honestly, I don't remeber why I set that color
fig.Color = [1 1 1];

% Export figure
export_fig(fig, biplotFNfull, '-pdf', '-png', '-eps', '-m5');

% Clean up
delete(fig)

Note the following:

replace YourPlot with the UIFigure/Axes element name you chose in your app.
replace YourPlotsToAppearInTheLegend with a vector of the plot elements, e.g. lines, you want a legend string to be displayed.

Good luck coding!

@MarvinILA - that's a great idea. I'm sorry that I missed it when you first posted it earlier this year. I'll integrate it into export_fig later today/tomorrow.

Fixed.
There are still a few limitations, but I expect them to affect only a very small percentage of users:

only uifigure and uiaxes handles can be specified, but not panel handles as in legacy figures
only a single handle at a time can be exported - not an array of handles as with legacy figures
exporting a combination of uifigure and legacy figure handles is not supported
uicontrols within the uifigures are not exported

Thanks again, @MarvinILA !
Enjoy!

Yair, might I suggest you add a note about the partial support for uifigure to the main README.md? I think your previous reply regarding the print function shouldn't be hidden within some closed bug report.
BTW, I'm experimenting with exporting those figures via webpage-to-pdf JS libraries (like https://github.com/niklasvh/html2canvas and https://github.com/MrRio/jsPDF), but I'm struggling with the limitations TMW keeps imposing on custom JS libraries (despite supposedly allowing them through uihtml).

@Dev-iL - done


async bind/unbinding fails often when more than one binding created

This form is for bug reports and feature requests. Major features will go through a spec process.
Feature:
Bug:
main.yaml
- name: "Update last operation"
  asb_last_operation:
    description: "0%: Starting"
  when: in_cluster

- name: 'Set facts'
  set_fact:
    cluster: '{{ "openshift" if "openshift" in lookup("k8s", cluster_info="version") else "kubernetes" }}'

- name: 'Include variables based on ansible version'
  include_vars: ansible_26.yml
  when: ansible_version.full is version('2.6', '>=')

- when: apb_action == 'provision'
  block:
    - name: encode bind credentials
      asb_encode_binding:
        fields:
          dummy: dummy

- when: apb_action == 'bind'
  block:

    - name: encode bind credentials
      asb_encode_binding:
        fields:
          dummy: "{{ _apb_provision_creds.dummy }}"
          openstack_keypair_id: "some value"

apb.yaml:
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
#      http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
---
version: 1.0
name: openstack-keypair-apb
description: Openstack KeyPair1
bindable: True
async: optional
tags:
  - Openstack
metadata:
  documentationUrl: https://openstack.org
  displayName: Openstack KeyPair (APB)
  longDescription: This deploys KeyPair secrets into the Openshift/K8
  imageUrl: https://www.openstack.org/assets/openstack-logo/2016R/OpenStack-Logo-Mark.svg
  dependencies: []
plans:
  - name: dev
    description: This development plan deploys openstack-keypair-apb
    free: True
    metadata:
      displayName: Development
    parameters:
      - name: os_client_config_clouds
        title: os_client_config
        type: string
        display_type: textarea
        default: |+
          clouds:
            otc:
              auth:
                auth_url: https://iam.eu-de.otc.t-systems.com:443/v3
                project_name: eu-de #required, since otherwise some APIs are not working
                user_domain_name: my_domain
              interface: public
              identity_api_version: 3
      - name: oc_client_config_secure
        title: os_client_config_secure
        type: string
        display_type: textarea
        display_group: secrets
        default: |+
          clouds:
            my_cloud:
              auth:
                username: MY_USER
                password: MY_SECRET
    bind_parameters:
      - name: cloud_name
        title: cloud, configured in the previously given os_client_config
        type: string
        required: true
      - name: keypair_name
        title: Name of the KeyPair
        type: string
        required: true

launch_apb_on_bind: true
What happened:
Creating of further binding sometimes fail:
Unable to update the job state 7bb91355-1079-4fd7-8440-21f30845d38f on the binding cd305ca6-852a-11e8-9736-0242ac11000b. Reason: Conflict - Operation cannot be fulfilled on bundlebindings.automationbroker.io \"cd305ca6-852a-11e8-9736-0242ac11000b\": the object has been modified; please apply your changes to the latest version and try again"
deletion of this binding fails as well. unprovisioning is not possible either
when launch_apb_on_bind:false the same APB is able to produce multiple bindings, unbind, deprovision (with existing bindings), however in that case binding is not invoked at all. According to log provision is invoked for each triggered binding (from UI). Changing this parameter has unpredictable influence on already provisioned service
Deprovisioning fails with following info (when i.e. multiple bindings were created successfully):
time="2018-07-11T17:47:43Z" level=info msg="All Jobs for instance: 231eab91-8532-11e8-985d-0242ac11000b in state:  in progress - \n[]bundle.JobState{}"
time="2018-07-11T17:47:43Z" level=debug msg="Found secret with name e44f9806-8531-11e8-985d-0242ac11000b\n"
time="2018-07-11T17:47:43Z" level=debug msg="Found secret with name 231eab91-8532-11e8-985d-0242ac11000b\n"
time="2018-07-11T17:47:43Z" level=debug msg="get service instance: e44f9806-8531-11e8-985d-0242ac11000b"
time="2018-07-11T17:47:43Z" level=info msg="ASYNC unbinding in progress"
time="2018-07-11T17:47:43Z" level=debug msg="set job state for instance: e44f9806-8531-11e8-985d-0242ac11000b token: 20e7cc51-cc63-49f1-840b-f5212ba552cd"
time="2018-07-11T17:47:44Z" level=error msg="Could not find binding e44f9806-8531-11e8-985d-0242ac11000b associated with job state 0d0aa957-9b25-4ebb-847d-7e82727d7623 - bundlebindings.automationbroker.io \"e44f9806-8531-11e8-985d-0242ac11000b\" not found"
time="2018-07-11T17:47:44Z" level=error msg="Failed to start new job for async unbind\nbundlebindings.automationbroker.io \"e44f9806-8531-11e8-985d-0242ac11000b\" not found"
time="2018-07-11T17:47:44Z" level=error msg="Unknown error: bundlebindings.automationbroker.io \"e44f9806-8531-11e8-985d-0242ac11000b\" not found"

complete log with provision, multiple bind, unbind of a random binding
openshift-automation-service-broker-2-jmmc6.log
What you expected to happen:
ASB is able to create as much binding as required and is able to unbind and deprovision itself.
How to reproduce it:

setup workspace with catasb
enable launch_apb_on_bind: true in OASB and redeploy
push sample APB with described content
provision APB
create multiple bindings (sometimes even this fails with "object has been modified")
try to delete bindings (usually fails with logs above, credential secrets are removed)
try to unprovision ServiceInstance (since unbinding does not work - no way to unprovision service)

the same error happened with just one binding

/close


load item extended info into folio

Modify the plugin here to pipe in the item extended info notes:
https://github.com/sul-dlss/libsys-airflow/blob/main/plugins/folio/items.py

Update https://github.com/sul-dlss/folio_migration/blob/main/mapping_files/item_mapping.json to add the extended info fields.

CSV format:
CKEY, TECHSTAFF, PUBLIC, CIRCNOTE, CIRCSTAF
1234, techstaff note if exists, public note if exists, circnote if exists, circstaf note if exists.

head -100  SAL.ckeys.0000 | selcallnum -iC -oKC 2>/dev/null | trs selitem -iN -oKSB 2>/dev/null | trs selved -fITEMXINFO -iV -oSed 2>/dev/null

@dlrueda can we discuss how we can possibly integrate these ☝ into the catdump scripts that you wrote?

Add to /s/SUL/Bin/folio_symphony_extract/do_catdumps_and_items.ksh

I modified the do_catdumps_and_items.ksh script and ran it for TANNER, and the correct looking files were generated under /s/SUL/Dataload/folio_symphony_extract/Bibs_catdumps, e.g.:
-rw-rw-r-- 1 sirsi sirsi   8855885 Apr 14 10:50 TANNER.ckeys.0000.mrc
-rw-rw-r-- 1 sirsi sirsi    532525 Apr 14 10:50 TANNER.ckeys.0000.csv
-rw-rw-r-- 1 sirsi sirsi   3685091 Apr 14 10:51 TANNER.ckeys.0000.techstaff.csv
-rw-rw-r-- 1 sirsi sirsi      2201 Apr 14 10:53 TANNER.ckeys.0000.public.csv
-rw-rw-r-- 1 sirsi sirsi     26185 Apr 14 10:54 TANNER.ckeys.0000.circnote.csv
-rw-rw-r-- 1 sirsi sirsi      8195 Apr 14 10:55 TANNER.ckeys.0000.circstaff.csv

@jgreben I was looking at the TANNER.ckeys.0000.public.csv file, and the barcodes are repeated in there multiple times?  There are only 29 unique barcodes but 1357 lines (plus header)?

@dlrueda I changed the following which fixed that I think:
Originally:
cat $marcdir/$filename.tsv | awk '{print $1}' | selcallnum -iC -oKC 2>/dev/null | trs selitem -iN -oKB 2>/dev/null

Now I am just pulling the barcode instead of the ckey:
cat $marcdir/$filename.tsv | awk -F'  ' '{print $5}' | selitem -iB -oKB 2>/dev/null


add DJED and iUSD tokens; rename items according to CIP-36 changes

Moved to https://github.com/LedgerHQ/app-cardano/pull/34


Doesn't render anything

I made a build for android but the screen was blank. Couldn't see the map
  return (
    <View style={styles.container}>
      <MapboxNavigation
        origin={[-97.760288, 30.273566]}
        destination={[-97.918842, 30.494466]}
        onLocationChange={event => {
          const { latitude, longitude } = event.nativeEvent
          console.log('UUUUUUUUUUUUUUUUUUUUUUUuu', event.nativeEvent)
        }}
        onMapReady={event => {
          console.log('UUUUUUUUUUUUUUUUUUUUUUUuu', event.nativeEvent)
        }}
        onRouteProgressChange={event => {
          const {
            distanceTraveled,
            durationRemaining,
            fractionTraveled,
            distanceRemaining
          } = event.nativeEvent
          console.log('LLLLLLLLLLLLLLLLLLLLLLLL', event.nativeEvent)
        }}
        onError={event => {
          const { message } = event.nativeEvent
          console.error(message)
        }}
        onCancelNavigation={() => {
          // User tapped the "X" cancel button in the nav UI
          // or canceled via the OS system tray on android.
          // Do whatever you need to here.
        }}
        onArrive={() => {
          // Called when you arrive at the destination.
        }}
      />
    </View>
  )

setup:
android/buid.gradle
allprojects {
    repositories {
        mavenLocal()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url("$rootDir/../node_modules/react-native/android")
        }
        maven {
            // Android JSC is installed from npm
            url("$rootDir/../node_modules/jsc-android/dist")
        }

        google()
        jcenter()

        maven { url 'https://maven.google.com' }

        maven { url 'https://www.jitpack.io' }

        maven {
            url 'https://api.mapbox.com/downloads/v2/releases/maven'
            authentication {
                basic(BasicAuthentication)
            }
            credentials {
                // Do not change the username below.
                // This should always be `mapbox` (not your username).
                username = "mapbox"
                // Use the secret token you stored in gradle.properties as the password
                password = "hardcoded_secret_token" ?: ""
            }
        }
    }
}

main/AndroidManifest.xml
        <!-- This should be a child of the application tag -->
        <meta-data android:name="MAPBOX_ACCESS_TOKEN"
            android:value="hardcoded_public_token" />

Solved by setting specific width & height


Support of specific "target" for  links by default UI to open result documents in different frame

When the default UI is integrated into an existing HTML suite that uses frames, it is much more convenient for larger suites when the selected search result link is opened in e.g. a new tab or a specific frame. Therefore, a CLI option "link-target" would be useful. When specified, the given value is added to the generated pagefile-ui.js as target attribute. By setting --link-target _blank the documents are opened in a new tab, by setting --link-target myframe the documents are opened in the given frame.

Good call, that can be added. It'll be an option when constructing the Default UI in the browser though, rather than a CLI option (the CLI is unaware of anything UI-side)

An option in the default UI would be fine for me as well. I just noticed that the default UI is generated as part of the index generation so I thought it could be specified there. I manually adjusted the minimized default UI to specify the target _blank and it makes the default UI much more usable in my setup. However, I have to do a "text editor" replacement after each index generation.


Update grpc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 3 committers have signed the CLA.:x: Maxksim Fomenkov:x: MaxFomenkov:x: Termina1Maxksim Fomenkov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Docs: "Advanced: Paragraph rule" need update

https://github.com/textlint/textlint/blob/master/docs/rule-advanced.md

Previously, we write ignore pattern in Paragraph node.

ignore Code.
replace Code to dummy object that is a single word.

We want to add pattern 3.

preserve ignored range and ignore it

It is a bit complex, but work fine most case without no hack.

https://github.com/azu/textlint-rule-no-mix-dearu-desumasu/blob/025dc054b00528851f62bfd2d3e1a2f182d87c4e/src/IgnoreManger.js

We should provide this function as helper library.

textlint/textlint-rule-helper: This is helper library for creating textlint rule. support IgnoreNodeManager. Use this.

Updated


GoogleMaps ClusterManager not working in Web

Steps to reproduce
I've set up GoogleMaps and tried to add the ClusterManager feature.
On Android and iOS, everything is working, but Web throws an Error.
Expected results
As there is nothing written in the docs, i would expect it to work, or that an exclusion of that function is noted in the docs.
Actual results

Code sample
Code sample
    return GoogleMap(
      initialCameraPosition: CameraPosition(target: LatLng(7, 50)),
      clusterManagers: {
        ClusterManager(clusterManagerId: ClusterManagerId("ID")),
      },
    );

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
https://pastebin.com/raw/r2Qp1yjq
Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.5, on macOS 15.0.1 24A348 darwin-arm64, locale de-DE)
    • Flutter version 3.24.5 on channel stable at /Users/yuki/Library/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dec2ee5c1f (4 weeks ago), 2024-11-13 11:13:06 -0800
    • Engine revision a18df97ca5
    • Dart version 3.5.4
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/yuki/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16A242d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11)

[✓] Connected device (3 available)
    • macOS (desktop)                 • macos                 • darwin-arm64   • macOS 15.0.1 24A348 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin         • macOS 15.0.1 24A348 darwin-arm64
    • Chrome (web)                    • chrome                • web-javascript • Google Chrome 131.0.6778.109
    ! Error: Browsing on the local area network for iPhone A. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)
    ! Error: Browsing on the local area network for iPhone von Yuki. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac.
      The device must be opted into Developer Mode to connect wirelessly. (code -27)

[✓] Network resources
    • All expected network resources are available.

• No issues found!

What a shame, i didn't read the endorsed web package Readme again. Its working.


Populate a package's scope field

While currently GitHub's dependency submission API only supports "runtime" and "development" scopes (which do not map really well to Gradle's configurations) it'd still be useful to have some coarse distinction here. Maybe compileOnly stuff should go to "development", and everything else to "runtime"?

It's particularly difficult to determine this, as it's very context-dependent. Take a look at the gradle/gradle build. There is quite a bit of logic in there that is just Gradle plugins that the Gradle team use to build/test Gradle itself. Are the dependencies used in those "development" or "runtime". What about test dependencies? Are those "development" or "runtime"? Test dependencies are used during a runtime, but is that the one we're concerned with?
Regarding your proposal to use compileOnly as "development", doesn't the API you compile against matter at runtime, as it can determine API compatibility? Is everything else truly "runtime"?

What about test dependencies? Are those "development" or "runtime"?

Yeah, I agree that "test" is definitely missing from the available choices. Maybe you guys could first work with GitHub to extend the list of supported scopes?

Is everything else truly "runtime"?

No. It was just a best-effort proposal to do something somewhat meaningful with the options at hand.
But given that the options (i.e. supported values for "scope") are so limited, it's maybe indeed better to not populate this field at all yet...

But given that the options (i.e. supported values for "scope") are so limited, it's maybe indeed better to not populate this field at all yet...

That was my thought, at least in the short term. If GitHub figures out a better explanation for what they want it to mean, we can maybe use it.
The other problem we have is that configurations can also be created custom by plugin authors. We don't really know what the use of those are.

Ok, let's then close this for now and eventually reopen once GitHub supports more scopes... maybe even just a free string without any general semantics attached (leaving it up to the user to interpret the meaning), so that we could literally tale the Gradle configuration name as-is.


Travis-CI Failes After Updates (configuration files/main.yml)

Describe the bug
Travis-CI Failing.  Updated the configuration files and amended the logstash>>main.yml file with updated paths. However, Travis-CI continues to fail.  Made updates to main.yml...reverted to previously working version but still received Travis-CI failures.  Will peel back and continue to troubleshoot later next week as time permits.
To Reproduce
Steps to reproduce the behavior:
Resort to previously working main.yml and/or amend with updates...Travis-CI fails

Hey,
I've started to troubleshoot this multiple times already.
Unfortunately, it looks like a systemd issue in the end (please see https://github.com/ansible/ansible/issues/48786 for details for example).
During my investigations, I refactored the java role, switched to focal distro (it introduced multiple new issues), but this brought some suboptimal configurations to my attention. These are fixed (although w/ logstash I had to include a workaround).
The steps mentioned above solved/masked the kibana error you've reported, but it came out again, but this time for logstash.
The generic advice for this, is to manually systemctl daemon-reload systemd, but it doesn't seem to have any effect.
After all, it shouldn't be neccesery, since daemon_reload: yes would address this exact issue.
I keep trying, as time permits.

Fixed


Add an appendix on polymorphism

@swalkinshaw
Based heavily on an internal polymorphism document I wrote while still at Shopify. I did tweak a bunch of things to fit the flow of the existing tutorial, so please give it a fresh read.

🎉  thanks for adding this


[1.18.2] raidManagerCapability is null

So i'm trying to enter my dedicated server and factioncraft is crashing only the client when i try to enter, heres is the crash log:
Pastebin: https://pastebin.com/4msAaiU2

Fixed in 1.19.2-1.2.0, there will always be a raidmanager now.
Unsure if this will be backported.


tests: slow.gif content can be incorrect if tests are executed in parallel

Sometimes, when tests are executed in parallel, checking of slow.gif content may fail:
_________________________________________________________________________________________ HarRenderTest.test_response_body _________________________________________________________________________________________
[gw6] linux -- Python 3.5.2 /usr/bin/python3
splash/tests/test_har.py:196: in test_response_body
    assert base64.b64decode(b64_data) == img_gif
E   AssertionError: assert b'GIF89aGIF89...x02L\x01\x00;' == b'GIF89a\x01\x...x02L\x01\x00;'
E     At index 6 diff: 71 != 1
E     Left contains more items, first extra item: 2
E     Use -v to get the full diff

It seems GIF header is duplicated in the result.

Shall we close this, given https://github.com/scrapinghub/splash/commit/dec1fccf75ee64df26cc6691085ffdd35e36f60b?

I'm not sure that's related.

It changes the way tests are executed. The previous instructions suggested -n to run things in parallel; now https://github.com/scrapinghub/splash/blob/master/dockerfiles/tests/runtests.sh runs the tests, which does not use -n. So, following the current instructions to run the tests, you cannot get this issue.
So, I’m wondering if instead of fixing the issue, we could either ignore it and assume people won’t try to execute tests in parallel, or explicitly document that tests do not support parallel execution.

You can still run tests in Docker in parallel, arguments like -n are passed to the command. It is super-useful to have these tests in parallel, as they're quite long; I recall doing it with -n4 or -n8 always.


Remove timeout for receiving from client handle to prevent flakiness

Another option is to just try to run the test with higher times, if the fast test fails. Then we can have a fast first test with 0.05sec and upto 0.1s, 0.5s if the previous test fails. I think that's the easy solution for flaky timers.

Yeah, for me the goal would be to remove flakyness from the tests completely, not just increasing the tolerance to flakyness.
My first thought was trying to fake the time, so we can control the flakyness. But then, after having another look, I even wonder why we need the timeout at all?
The tests pass even completely removing all the timeouts.
Do we have the timeouts to test that the PowerDistributor reacts quickly? If so, I would just measure the time it took to process and make an assert to make sure the time is less than the tolerance we want (this makes the test fails saying what we are really testing rather than failing in some unrelated way).
If it's just a boundary to avoid tests stalling if something goes wrong, I think it should be enough to rely on the total test time, or adding a much higher timeout, like when sending requests to the PowerDistributor, request_timeout_sec=30 is used.
So, unless there is a good reason to keep the timeouts, I would just kill them.

Click here to see diff and tests results
(the gather change is not relevant, it was just visually annoying because it was redundant :D)
frequenz-sdk-python [python-3.8.13] $ git diff
diff --git a/tests/power_distribution/test_power_distributor.py b/tests/power_distribution/test_power_distributor.py
index b0d620c..155255f 100644
--- a/tests/power_distribution/test_power_distributor.py
+++ b/tests/power_distribution/test_power_distributor.py
@@ -231,7 +231,7 @@ class TestPowerDistributor(IsolatedAsyncioTestCase):
                 Request(power=1200, batteries={106, 206}, request_timeout_sec=30)
             )

-            done, pending = await asyncio.wait([client_handle.receive()], timeout=0.1)
+            done, pending = await asyncio.wait([client_handle.receive()])
             await distributor._stop()  # type: ignore # pylint: disable=no-member

         assert len(pending) == 0
@@ -292,10 +292,10 @@ class TestPowerDistributor(IsolatedAsyncioTestCase):
                 Request(power=1300, batteries={106, 206}, request_timeout_sec=30)
             )

-            await asyncio.gather(*[task1, task2])
+            await asyncio.gather(task1, task2)

             done, pending = await asyncio.wait(
-                [user1_handle.receive(), user2_handle.receive()], timeout=0.05
+                [user1_handle.receive(), user2_handle.receive()]
             )
             await distributor._stop()  # type: ignore # pylint: disable=no-member

@@ -353,7 +353,7 @@ class TestPowerDistributor(IsolatedAsyncioTestCase):
                 Request(power=1200, batteries={106, 208}, request_timeout_sec=30)
             )

-            done, _ = await asyncio.wait([user1_handle.receive()], timeout=0.05)
+            done, _ = await asyncio.wait([user1_handle.receive()])
             await distributor._stop()  # type: ignore # pylint: disable=no-member

         assert len(done) == 1
@@ -420,15 +420,14 @@ class TestPowerDistributor(IsolatedAsyncioTestCase):
                 Request(power=1200, batteries={106, 206}, request_timeout_sec=1)
             )

-            await asyncio.gather(*[task1, task2, task3])
+            await asyncio.gather(task1, task2, task3)

             done, _ = await asyncio.wait(
                 [
                     user1_handle.receive(),
                     user2_handle.receive(),
                     user3_handle.receive(),
-                ],
-                timeout=0.5,
+                ]
             )
             await distributor._stop()  # type: ignore # pylint: disable=no-member

@@ -491,7 +490,7 @@ class TestPowerDistributor(IsolatedAsyncioTestCase):
                     adjust_power=False,
                 )
             )
-            done, pending = await asyncio.wait([user1_handle.receive()], timeout=0.05)
+            done, pending = await asyncio.wait([user1_handle.receive()])
             await distributor._stop()  # type: ignore # pylint: disable=no-member

         assert len(pending) == 0
@@ -550,7 +549,7 @@ class TestPowerDistributor(IsolatedAsyncioTestCase):
                 )
             )

-            done, pending = await asyncio.wait([user1_handle.receive()], timeout=0.05)
+            done, pending = await asyncio.wait([user1_handle.receive()])
             await distributor._stop()  # type: ignore # pylint: disable=no-member

         assert len(pending) == 0
@@ -613,7 +612,7 @@ class TestPowerDistributor(IsolatedAsyncioTestCase):
                 Request(power=1200, batteries={106, 206}, request_timeout_sec=30)
             )

-            done, pending = await asyncio.wait([client_handle.receive()], timeout=0.05)
+            done, pending = await asyncio.wait([client_handle.receive()])
             await distributor._stop()  # type: ignore # pylint: disable=no-member

         assert len(pending) == 0
@@ -683,7 +682,7 @@ class TestPowerDistributor(IsolatedAsyncioTestCase):
                 Request(power=1200, batteries={106, 206}, request_timeout_sec=30)
             )

-            done, pending = await asyncio.wait([client_handle.receive()], timeout=0.05)
+            done, pending = await asyncio.wait([client_handle.receive()])
             await distributor._stop()  # type: ignore # pylint: disable=no-member

         assert len(pending) == 0
luca@frq-lap-019:~/devel/frequenz-sdk-python [python-3.8.13] (clear-notes *=) $ pytest -W=all tests/power_distribution/test_power_distributor.py
=================================================================================================================================================== test session starts ===================================================================================================================================================
platform linux -- Python 3.8.13, pytest-7.1.3, pluggy-1.0.0
rootdir: /home/luca/devel/frequenz-sdk-python, configfile: pyproject.toml
plugins: cov-4.0.0, mock-3.10.0, asyncio-0.19.0, anyio-3.6.1
asyncio: mode=auto
collected 9 items

tests/power_distribution/test_power_distributor.py .........                                                                                [100%]

==================================================================================================================================================== 9 passed in 0.20s ====================================================================================================================================================

This LGTM but I'm not sure why we had timeouts in the first place. @ela-kotulska-frequenz @sahas-subramanian-frequenz can you confirm this change is fine?

Or you @jakub-toptal, of course, but I guess if you just incremented the timeout you are probably not sure either.

It put it there to:

Make sure it won't block all tests forever
Make sure the PowerDistributor is fast - and will be in the future.

So it is not needed, however I would prefer to put high timeout like: 60 seconds.

OK, 2. is a good point but I think it should be done in a performance test, maybe put it into the benchmarks. In the regular CI is probably very hard to do a performance test as they run in VMs with many other stuff, so it runtimes will probably vary a lot.

Will do


Daily Limit for Unauthenticated User Exceeded

So I am making a NodeJS Discord bot, and I'm using this API to extend shortened links. However, when I try to extend any link, it says the I need to signup. How do I signup, and where can I find my API key and use it?
Thanks!

I'm guessing this is what you're looking for?

Hi @Kyle2000,
Thanks for asking. I am hoping the link that @ace-n provided works for you? If not, feel free to reopen this issue.


[AIRFLOW-3250] Fix for Redis Hook for not authorised connection calls

Password stay None value and not None (str) in case there is no password set through webadmin interfaces.
This is fix for connections for Redis that not expect autorisation from clients.
Fixes originally  implemented: https://issues.apache.org/jira/browse/AIRFLOW-999
Make sure you have checked all steps below.
Jira

[X] My PR addresses the following Airflow Jira issues and references them in the PR title.

https://issues.apache.org/jira/browse/AIRFLOW-3250

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

This functionality is trivial further description is NOT needed.
Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:

/tests/contrib/hooks/test_redis_hook.py
/tests/contrib/sensors/test_redis_sensor.py
Commits

[X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

This functionality is trivial and documentation is NOT needed.
Code Quality

[X] Passes flake8

Codecov Report

Merging #4090 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4090   +/-   ##
=======================================
  Coverage   77.66%   77.66%
=======================================
  Files         199      199
  Lines       16273    16273
=======================================
  Hits        12638    12638
  Misses       3635     3635

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deebf44...db3d58f. Read the comment docs.

@smentek If you're interested, you can also test against a real Redis by adding it to the docker-compose: https://github.com/apache/incubator-airflow/blob/master/scripts/ci/docker-compose.yml
What do you think?

OK I'll check it. Would it go on current PR?

I've set real Redis, and some basic integration tests for it.


Unable to load banner ad when testing on physical device

What I'm trying to do:

I want to load the banner ad with a real adUnitID on my physical device when developing/testing.

What works:

I can load the banner ad with a test adUnitID of ca-app-pub-3940256099942544/6300978111 on my physical device AND emulator when developing/testing.
I can load the banner ad with a real adUnitID on my emulator when developing/testing.

What doesn't work aka what I tried:

I thought the issue was with the testDeviceID. I've so far tried using the Android Device ID, Google Services Framework (GSF), and Hardware Serial Number (as shown by https://play.google.com/store/apps/details?id=com.evozi.deviceid) as my testDeviceID. Same result every time -- my this.bannerError method tells me that banner error "ERROR_CODE_INTERNAL_ERROR" has occurred.
For the testDeviceID, I've used the values from getUniqueID() and getInstanceID() as shown by https://github.com/rebeccahughes/react-native-device-info. Same result every time -- my this.bannerError method tells me that banner error "ERROR_CODE_INTERNAL_ERROR" has occurred.

My question:

Is an improper configuration of testDeviceID causing me to not see ads on my physical device when I'm testing/developing? (Not even a fake ad renders.)
Or is there a way to tell what is causing the "ERROR_CODE_INTERNAL_ERROR"?
If I'm improperly configuring my testDeviceID when testing/developing, how do I set it correctly?

RESOLVED

The improper configuration of testDeviceID was causing me to not see ads on my physical device when I was testing/developing.
I was having difficulty figuring out what my testDeviceID should be as I'm new to mobile development in general. I was hoping to see Use AdRequest.Builder.addTestDevice... in my browser's dev tools (when debugging JS remotely) or via running adb logcat *:S ReactNative:V ReactNativeJS:V in my terminal. I did not see Use AdRequest.Builder.addTestDevice... in either cases. Instead, what I did was open up my project's /android directory via Android Studio,
run the app (), I was able to search for I/Ads, which finally revealed the testDeviceID that I should be using.

I hope this helps for anybody else new to React Native/Android development yet still wants to test if their ads are working or not!


Not Implemented Error when running EcoWitt2Mqtt

Hi,
I'm getting the following error when I get to the stage of running Python app.  I've attempted to debug the app locally to no avail, I'm think there may be something I missed in the setup of HASS as that step in your documentation is a little vague:
"Once Home Assistant is configured to accept MQTT Discovery"
I made sure the MQTT Discovery was set to enabled, and I have my MQTT Broker installed and setup, which is currently configured with another device working fine (config for MQTT Broker below). It could simply be my device is not supported, in which case I'd be happy to add it if your busy etc.
logins: []
customize:
  active: true
  folder: mosquitto
certfile: fullchain.pem
keyfile: privkey.pem
require_certificate: false

Error reported in console from EcoWitt2MQTT app:
INFO:ecowitt2mqtt:Unknown device; please report it at https://github.com/bachya/ecowitt2mqtt (payload: {'PASSKEY': '3A0CA3A42157F6147F3E3EDD630BBC60', 'stationtype': 'EasyWeatherV1.5.9', 'dateutc': '2021-10-04 02:28:32', 'tempinf': '64.4', 'humidityin': '72', 'baromrelin': '28.196', 'baromabsin': '28.196', 'tempf': '50.9', 'humidity': '96', 'winddir': '289', 'winddir_avg10m': '282', 'windspeedmph': '2.7', 'windspdmph_avg10m': '2.5', 'windgustmph': '6.9', 'maxdailygust': '20.6', 'rainratein': '0.000', 'eventrainin': '0.134', 'hourlyrainin': '0.012', 'dailyrainin': '0.134', 'weeklyrainin': '0.134', 'monthlyrainin': '1.110', 'yearlyrainin': '11.610', 'solarradiation': '174.81', 'uv': '1', 'temp1f': '66.4', 'humidity1': '69', 'soilmoisture1': '22', 'pm25_ch1': '7.0', 'pm25_avg_24h_ch1': '14.3', 'wh65batt': '0', 'wh25batt': '0', 'batt1': '0', 'soilbatt1': '1.5', 'pm25batt1': '5', 'freq': '433M', 'model': 'PT-HP2550_Pro_V1.6.7'})
ERROR:ecowitt2mqtt:Caught exception in on_socket_open:
ERROR:aiohttp.server:Error handling request
Traceback (most recent call last):
  File "c:\python38\lib\site-packages\aiohttp\web_protocol.py", line 422, in _handle_request
    resp = await self._request_handler(request)
  File "c:\python38\lib\site-packages\aiohttp\web_app.py", line 499, in _handle
    resp = await handler(request)
  File "c:\python38\lib\site-packages\ecowitt2mqtt\mqtt.py", line 106, in async_publish_payload
    await _async_publish_to_hass_discovery(client, data, discovery_manager)
  File "c:\python38\lib\site-packages\ecowitt2mqtt\mqtt.py", line 32, in _async_publish_to_hass_discovery
    async with client:
  File "c:\python38\lib\site-packages\asyncio_mqtt\client.py", line 315, in __aenter__
    await self.connect()
  File "c:\python38\lib\site-packages\asyncio_mqtt\client.py", line 78, in connect
    self._client.connect(self._hostname, self._port, 60)
  File "c:\python38\lib\site-packages\paho\mqtt\client.py", line 941, in connect
    return self.reconnect()
  File "c:\python38\lib\site-packages\paho\mqtt\client.py", line 1117, in reconnect
    self._call_socket_open()
  File "c:\python38\lib\site-packages\paho\mqtt\client.py", line 2071, in _call_socket_open
    self.on_socket_open(self, self._userdata, self._sock)
  File "c:\python38\lib\site-packages\asyncio_mqtt\client.py", line 293, in _on_socket_open
    self._loop.add_reader(sock.fileno(), cb)
  File "c:\python38\lib\asyncio\events.py", line 501, in add_reader
    raise NotImplementedError
NotImplementedError
INFO:aiohttp.access:<IP_ADDRESS> [04/Oct/2021:02:28:38 +0000] "POST /data/report HTTP/1.1" 500 250 "-" "-"

Hi @Frenchie90-alt – thanks for this. Looks like there are two things going on:

As you've noted, ecowitt2mqtt doesn't know about your device yet. Not a problem: I'm happy to add support via a PR.
Your NotImplementedError doesn't directly relate to ecowitt2mqtt's code; I don't raise that exception anywhere. Looks like it's happening deeper in your stack.

I just tried this on macOS using the dev branch and everything worked fine. What OS, library version, etc. are you using?

Hi  @bachya ,
Can confirm that fixed the device unrecognised issued, the other still exists when running via the PIP install method, however running via Docker works perfectly.
Really appreciate the quick turn around and the work you put into this.
Thanks again,
Eric


下个版本时间

下个版本什么时候发布呢？非常期待👍👍👍

希望能赶在五月前推出，你也可以在这里下载Beta版本喔：https://testflight.apple.com/join/EgZ8sE2P
On Sun, 25 Apr 2021 at 10:15, luobuyu @.***> wrote:

下个版本什么时候发布呢？非常期待👍👍👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/thebaselab/codeapp/issues/95, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJE6T22CUYTH4J3MRAUKCSTTKN3NLANCNFSM43QYA46Q
.


Offensive recommendations - Person first language

The style guide when talking about disabilities suggests Person first language such as a "Person with deafness" and "Person with autism".  The "Person" comes before the disability.
APA style directly recommends against both of these specific examples and for good reason.  Disabled communities have different views on the topic of "person first language", and many of them find the phrasing to be convoluted, condescending, and euphemistic and something foisted onto them without their input by well meaning editors.  The deaf and autistic communities have pretty consistently preferred identity-first language in general.  In other communities, such as those for people with intellectual disabilities, person-first phrasing remains preferred.  Further, individuals within these communities will disagree about which phrasing is more appropriate just to muddle the waters further.
I would recommend a rewrite of this entire section, and I would totally disregard the Microsoft Style guides recommendation until a rewrite is done because the current recommendations are likely to cause offence.  One would be wise to do a bit of research about the disabled people and disabled community you're talking about to find their preferences regarding how they would like to be referred to.  One should pay attention to how the disabled people you're talking about refer to themselves.  Suggesting that every disabled person should be referred to by "Person first language" is simply bad advice and is likely to cause offence, and further risks an editor correcting a disabled writer who refers to themselves by identity-first language which will DEFINITELY cause offence.
The style guide should emphasize how people and communities have different views on this subject, and the need to ask the relevant person or group being discussed for advice on this topic.  Some superior alternatives to Microsofts style recommendations that I think are quite thoughtful and reasonable:
https://apastyle.apa.org/style-grammar-guidelines/bias-free-language/disability
https://ncdj.org/style-guide/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47aaf3f0-fad9-7969-f4a6-687ff23e5315
Version Independent ID: 2df604ee-8963-1bc6-e68a-e7cc985b9e2d
Content: Accessibility terms - Microsoft Style Guide
Content Source: styleguide/a-z-word-list-term-collections/term-collections/accessibility-terms.md
Product: non-product-specific
GitHub Login: @pallep
Microsoft Alias: pallep

Thanks for your thoughtful feedback @Unnamed-Variable . This topic has been under consideration and revision recently, and we expect updates shortly to align with nuanced guidance provided by accessibility experts. We wholeheartedly agree that the preferences of the person or community being talked about should be respected whenever these are known. However, we simply do not have this context when discussing disability issues at the global level or in the abstract, which means that a default recommendation for inclusive language will always be made, in the absence of other information.


TURF: Add bezier operation

Follow these instructions for adding a new turf function.
Turf docs: http://turfjs.org/static/docs/module-turf_bezier.html

I didn't see this before, but I suppose I claimed it via my pull request!


Error yara - python install on windows 10

ISSUE
when i send command in cmd python setup.py install
consule out put
buillders
buillders1
running install
running build
creating Users
error: [WinError 1] Incorrect function

Have you solved this problem?I encounter this problem either.

ISSUE
when i send command in cmd python setup.py install
consule out put
buillders
buillders1
running install
running build
creating Users
error: [WinError 1] Incorrect function

Have you solved this problem?I encounter this problem either.

Have you solved this problem?I encounter this problem either.


Added option g:tmux_navigator_disable_wrapping

Added an option to prevent wrapping top/bottom or left/right when trying to move in a direction in which no tmux pane exists.  By default (if the new option is not set) the prior behavior of wrapping still occurs.

Ahh, crap, my bad.  I totally missed #237 addressing this already...


Update darktable to 2.6.1

Darktable 2.6.1 was released: https://www.darktable.org/2019/03/darktable-261-released/

They moved from zip to exe. Here is fixed manifest, but there is needed to determine how to install. I don't have time right now to test.
{
    "homepage": "https://www.darktable.org/",
    "description": "Open source photography workflow application and raw developer. A virtual lighttable and darkroom for photographers",
    "license": "GPL-3.0-only",
    "version": "2.6.1",
    "url": "https://github.com/darktable-org/darktable/releases/download/release-2.6.1/darktable-2.6.1-win64.exe",
    "hash": "c0b31a3ac4f02151f4fc0ee4e8e39dc1e5c8ef409b2f23eee440affba9cd73f6",
    "bin": "bin\\darktable.exe",
    "shortcuts": [
        [
            "bin\\darktable.exe",
            "darktable"
        ]
    ],
    "checkver": {
        "github": "https://github.com/darktable-org/darktable",
        "regex": "tree/release-([\\d\\.]+)"
    },
    "autoupdate": {
        "url": "https://github.com/darktable-org/darktable/releases/download/release-$version/darktable-$version-win64.exe",
        "hash": {
            "url": "https://github.com/darktable-org/darktable/releases/tag/release-$version"
        }
    }
}

Found something about NSIS 3.04 https://sourceforge.net/p/sevenzip/discussion/45797/thread/3f97de5252/
But I don't know what the NSIS signature is. Yet :smile:

Found a way to install with the new exe. Here is the corresponding PR : https://github.com/lukesampson/scoop-extras/pull/4707

This can be closed I guess, Was resolved with #4707

This can be closed I guess, Was resolved with #4707


Deployment-specific config file for help and feedback URLs

This pull request will add a config file that allows users to set data specific to a deployment. Links for 'Using the Data Browser' and 'Send us your feedback' are taken from this config file.

Yeah I saw it before my changes. I can make a new issue for it right now.

Should discuss with Cris. I think she worked on it originally but I’m not sure.
On August 17, 2015 at 6:31:41 PM, Jessie Wong<EMAIL_ADDRESS>wrote:
Yeah I saw it before my changes. I can make a new issue for it right now.
—
Reply to this email directly or view it on GitHub.


Replace Tor with I2P

Tor is becoming increasingly unreliable, I2P seems like a good alternative. Transient addresses should be used by peers for privacy between rounds and for alice & bob distinction

https://geti2p.net/en/docs/

https://geti2p.net/en/docs/api/streaming
https://geti2p.net/spec/streaming

http://www.i2p.to/en/docs/applications/embedding

https://mvnrepository.com/artifact/net.i2p

Should keep tor as an option and add i2p support in addition

Easiest way might be to configure as an i2p proxy
https://geti2p.net/en/about/browser-config


Updates to support Catchment-CN.4.5 in addition to Catchment-CN.4.0

Changes necessary to support two different versions of the Catchment-CN land model, Catchment-CN4.0 and Catchment-CN4.5. The default land model for GCM simulations remains Catchment.
This PR is contingent on the following PRs:
GEOSgcm_GridComp PR#368
GEOSldas PR#326
GEOSgcm_App PR#177

@smahanam ,  https://github.com/GEOS-ESM/GMAO_Shared/blob/d18746b3b36297d942d9022b1fa91c3815df2840/GEOS_Util/post/regrid.pl#L928, After this line, how is this variable mk_catchcn being used?

It goes to the 2nd perl scrip mkRestart or mk_Restart

But how? @smahanam

I want to change mk_catchcn to mk_catchcnclm40 and mk_catchcnclm45. The restart files are catchcnclm40_internal_restart and catchcnclm45_internal_restart.  So the "CN_VERSION" is not necessary. But I am not sure how version "40" is different from "45" when they are used.

Is this still Jana's branch or a new one? I guess first step create new branches  rather than editing this working version.
I'll get back to you - I need to take a look.

It is Jana's branch. I feel it may be better at the very beginning to create a link catchcn_internal_rst to point to catchcnclm40 or catchcnclm45,  then the change may be minimum.

I wont be able to help,

This PR is ready for review.

This PR is ready for review.

@biljanaorescanin It might be good for you to press the "update branch" button and make sure nothing goes wonky :)

@mathomp4 I've re-tested all experiments with all repos updated and we are good. We can proceed with the PR.


[Feature] Git commit submodule

Hello!
Please add commit capability in git submodules. It is desirable that this be all automatic.
Let's say I have a private repository with a public repository submodule (for example, I maintain my wiki there). I want to have a commit function in the submodule, and then a commit in the main module with changes in the submodule.
Or is there an option to do it differently? Thank you!

There is an option in the settings to commit everything and push in the submodule when committing all changes via command or doing backup in your vault.

Thank you!


i want this ;)

nice addons @compholio

Thanks @cy4n, I've been enjoying oh-my-git for some time and having these little extra addons (bisect status, in particular) have really made me happy :)

Yes, @cy4n, I also wish to personally thank you for what you did while I was disregarding my own repository. You kept it alive. Grazie di cuore! I'm willing to work on it again, and to publish an updated version soon.


Graphics not displaying

I have been trying to use your FlareClusterLayer with a REST service that returns JSON of points.  I am using the GraphicsLayer base class load function to call the REST service and store the point data as the FlareClusterLayer._data.  After that I call the draw function.
I can see console log statements when I pan around that tell me if the data is clustered or not during the draw function.  I cannot get any graphics to show up on the map.  I am not familiar with what part of your code loads the graphics in the view.  Maybe you have some insight that could help me.  Thank you much.

Hi @spatterson82, no worries. Can you post an example of your current code and problem somewhere - like a gist or plnkr.

Here is a gist link for the FlareClusterLayer that I added things to.  I commented the functions I added and I also updated the coordinate property names because the JSON I am using has Lat/Long. I will post some functions from the other parts to show how it is being called.
https://gist.github.com/spatterson82/04c72c9ac7467ce8666f111c51db0259

Here are the two functions that are part of a main application that build a layer and pass the layers to a Map object.
https://gist.github.com/spatterson82/4716c810a6a836ee617f6ed2c1a83831

Hi, I can't see anything glaringly wrong with what you're trying without seeing a live demo.
Couple of points though.

You can just set the xPropertyName and yPropertyName as values in the constructor parameters, don't need to change the default values in the layer itself.
You could move the calls to get the data outside of the layer and then just call setData() on an instantiated layer object once it's been retrieved. Just to try and keep the layer code black boxed.

For further debugging the drawing occurs in this method FlareClusterLayer.prototype.draw().
Add a bunch of console.log calls and/or debug into it. Firstly to confirm it's actually getting hit and then to see how far it's making it through that function. That's where the all of the actual drawing happens so if you're not seeing anything drawn it may be getting short circuited before the drawing occurs.

Thanks for checking it out.  I will try those suggestions today and try to troubleshoot a bit more.

@nickcam I finally got the clusters to display on the map today.  The layer visibility is being defaulted to false somewhere.  I don't see that getting set anywhere.
In the _createCluster function, I added "this.visble = true;" at the very bottom and it works.
I am going to try and change it now to take a FeatureLayer url to load data from a published map instead of querying live data from a REST endpoint.
Thanks for taking a look and helping me out.  You put alot of good stuff into the layer.

Good stuff, glad you got it working so far! Weird on the visibility thing though...the layer shouldn't be setting visible = false in itself internally anywhere.

I have the same problem，but i can't Solve In the _createCluster function, added "this.visble = true;"
it's not work


Release Google.Api.Gax version 4.1.0-alpha02

This release is primarily to test fixes to gRPC transcoding.

Created release for Google.Api.Gax-4.1.0-alpha02


Jesse: Watch bringusthathorizon.co.uk

Jesse requests the watch of the watch_keyword bringusthathorizon\.co\.uk. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Spevacus in Charcoal HQ


Stutter on pull to refresh (Flutter 3.19.1)

Describe the bug
Pull to refresh causes application UI on iOS to stutter.
To Reproduce
RefreshIndicator(
        onRefresh: () async {
          HapticFeedback.lightImpact();
          await ref.refresh(eventsBetweenProvider(
                  start: dateTimeRange.start,
                  end: dateTimeRange.end,
                  notClockedIn: false)
              .future);
        },
)

Expected behavior
With previous versions of Flutter it didn't stutter. When I remove the ref.refresh call and replace with a Future.delayed the animation looks fine.
Edit: just downgraded to 3.16.9 and can confirm it was not an issue in this version.

Please share a minimal reproducible example. The snippet given isn't enough to reproduce the issue.

@rrousselGit may I ask why you removed the bug label? As far as I know it is unexpected behaviour from Riverpod right or am I missing something?

Closing as it appears to be a Flutter issue.


Keeping up with fast moving react-native

Previously sdk branch was based on v0.9.0
With this pull request, moving to v0.11.0

:+1: (the diff crashed my browser the first time) :-)

:+1:


Allow placeholders in tag name

<app-${foo}></app-${foo}>
<app-${foo}></>

Placeholders should only be allowed in concise mode since the placeholder would be ambiguous in concise mode if it was at the beginning.

Hey @patrick-steele-idem this is a really cool feature! Wouldn't this only be allowed in verbose mode?

Hey @yomed, I updated the description to make it correct. Placeholders can be used in tag names for both verbose and concise mode, but in concise mode the placeholder cannot be at the beginning. Also, this feature description was probably misleading in that while the parser will recognize placeholders in tag names, the Marko compiler won't know the actual tag name at compilation time so the Marko compiler will just end up producing code that renders a normal HTML tag with a dynamic tag name. For example, the Marko compiler will end up producing code similar to the following:
function create(__helpers) {
  var str = __helpers.s,
      empty = __helpers.e,
      notEmpty = __helpers.ne,
      escapeXml = __helpers.x;

  return function render(data, out) {
    out.w("<" +
      data.myTagName +
      " class=\"my-class\" foo=\"bar\">My nested content</" +
      data.myTagName +
      ">");
  };
}

(module.exports = require("marko").c(__filename)).c(create);

So while this feature is cool, I suspect it is not as cool as you hoped. In hopes that you won't be too disappointed, I opened up another feature proposal: https://github.com/marko-js/marko/issues/227
Please add your comments to that new issue. Thanks!

That's true, I had misunderstood. Although even without compiling custom tags this is still pretty useful. I have had some use cases where I wanted to use <div> vs. <span> in different scenarios and would end up with lots of if statements in the template (when I'd prefer to store it in variables instead). Let me think about the custom imports some more.


Use fs/promises in the Node.js-specific code in the src/-folder

This is available in all Node.js versions that we currently support, and using it allows us to remove callback-functions; please see https://nodejs.org/docs/latest-v18.x/api/fs.html#promises-api

/botio xfatest


[#6152] Allows to set queueSize in the TcpDataSender

Codecov Report

Merging #6153 into master will decrease coverage by <.01%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master    #6153      +/-   ##
==========================================
- Coverage   40.49%   40.49%   -0.01%
==========================================
  Files        3026     3026
  Lines       91388    91391       +3
  Branches    11896    11896
==========================================
  Hits        37006    37006
- Misses      51310    51315       +5
+ Partials     3072     3070       -2

Impacted Files
Coverage Δ

...ontext/provider/thrift/StatDataSenderProvider.java
46.87% <0%> (ø)
:arrow_up:

...ontext/provider/thrift/SpanDataSenderProvider.java
45.16% <0%> (ø)
:arrow_up:

...ercorp/pinpoint/profiler/sender/TcpDataSender.java
69.42% <71.42%> (-0.71%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0%> (-11.12%)
:arrow_down:

...navercorp/pinpoint/rpc/common/SocketStateCode.java
82.92% <0%> (-2.44%)
:arrow_down:

...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java
57.44% <0%> (-2.13%)
:arrow_down:

...point/rpc/client/DefaultPinpointClientHandler.java
72.07% <0%> (-0.33%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
79.22% <0%> (ø)
:arrow_up:

...pinpoint/profiler/monitor/DeadlockMonitorTask.java
19.76% <0%> (+1.16%)
:arrow_up:

...tor/metric/datasource/DefaultDataSourceMetric.java
78.12% <0%> (+3.12%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc1273...525858d. Read the comment docs.


remove test_hf_import_missing_author test

Resolves #303
Description
CI started to fail again on test_hf_import_missing_author test.
Allegedly, HuggingFace and HF users, are moving away from "root-level" and get redirection to namespaced under a user or organization name.
As a result, is more and more difficult to locate a "root-level" model on HuggingFace (see previous PR work)
👉  At this point, is best to remove failing test to avoid CI failing, at the expense of slight decrease in codecov.
To Reproduce the bug
Steps to reproduce the bug:

see https://github.com/opendatahub-io/model-registry/actions/runs/7885901879/job/21517997615?pr=301

Additional context

https://github.com/opendatahub-io/model-registry/issues/286
https://github.com/opendatahub-io/model-registry/pull/287

How Has This Been Tested?

Merge criteria:

[x] The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (44d87e4) 76.30% compared to head (e5c60fd) 81.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   76.30%   81.07%   +4.76%
==========================================
  Files          17       12       -5
  Lines        2030      597    -1433
  Branches       73       73
==========================================
- Hits         1549      484    -1065
+ Misses        296       90     -206
+ Partials      185       23     -162

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow ignoring Mattermost server version when checking if supported

This makes it a little bit more future proof by allowing the admin/user to select ignore supported Mattermost server version and use at own risk per https://github.com/42wim/matterircd/issues/537

👍


Try to improve error message extraction

Scope & Purpose
Try to get the most specific error code and error message in more cases.

[X] Bug-Fix for devel
[ ] Bug-Fix for a released version (TODO check where we want to backport this)
[X] The behavior in this PR can be (and was) manually tested
[ ] The behavior change can be verified via automatic tests

Related Information

[X] There is an internal planning ticket: https://arangodb.atlassian.net/browse/BTS-152

Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/11468/

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/11743/

Tests blue.


[BUG] - Product - api association gets revoked, while extracting targeted apis and publishing those artifacts.

Release version
v5.1.4
Describe the bug
When extracting only targeted api using "configuration.extractor.yaml", the api gets extracted correctly. The issue is that for the product assignment, only product assignment with that api is configured properly. For all the other products, the api connection gets removed in the extracted artifacts. And when we run publisher pipeline, it revokes the api-product association. This actually caused a small outage in our company as well. Below are detailed behavior.
When Extracting all artifacts: (Working as expected)
Here are the extracted artifacts.

When we publish the artifacts by using "Extract-all" extractor pipeline, the deployment to DEV and UAT environment works as expected as well.

Extracting only targeted apis:
But, when we extract selected api using "configuration.extractor.yaml" file. Here is the behavior.
"configuration.extractor.yaml" file

Selected Artifacts:
Only – “mock-api” has been extracted under api folder, which is expected.

Under products folder, all the product definitions are extracted, Here are all products that got extracted: (All products are here)

But only product associated with “mock-api” has that association. All other product-api associations are no longer there.
Products --> demo --> apis.json

Products --> unlimited --> apis.json

Now the issue is when we run publisher pipeline.
The previously established product --> api connection will be removed automatically, and only product --> api association will remain between "mock-api" (the api we selected using configuration.extractor.yaml)

All the other apis will now have no products.  Here is one example. But its same for all other apis.

Basically api --> product association gets destroyed for all the other apis.
Expected behavior
When we run extract all, everything works as expected. When we run targeted extraction, expectation is that all the other products and api connection should not be destroyed. This can have major consequences, and it has potential to destroy all the consumer apps that call the apis in that apim instance.
Actual behavior
While selecting targeted api, the api-product connection gets broken for all the other apis and products except selected product.
Reproduction Steps
Have an apim instance with bunch of apis connected to few products. Run "Extractor" pipeline by selecting a subset of all apis using "configuration.extractor.yaml" file. Then run publisher pipeline, and see the behavior where all the other product-api association gets destroyed. Except the targeted one.

Can you please search some of the outstanding issues that may have touched n the same issue?
@guythetechie is this is a known issue that you plan on addressing in the upcoming release?

This will be fixed in the next release. See #245; not exactly the same issue, but related.

@guythetechie Thanks for the confirmation, any idea on how can I register for a notification, when new release is available.?

@guythetechie Thanks for the confirmation, any idea on how can I register for a notification, when new release is available.?

Subscribe to the repository release notifications.

we just tested under v6.0.0-rc1 and the issue has been resolved. Please test and let us know.


Store configs in sequence file instead of input from cli

Is your feature request related to a problem? Please describe.
Then we create sequence we can save all configs in the Sequence objects and then in the file
Describe the solution you'd like

create config class
add config to the sequence
change cli (may be make two scripts: one for capture, second for replay)

Describe alternatives you've considered
make CRUD for Sequence object

May be not actual


improve meta-elisa readme by specifying kvm option usage.

KVM need to be set in the bios setting  of the host PC or, if you remove KVM option from qemu call it will work, but performance is poor. The setting will differ based on the motherboard, but could be something like  Intel®Virtualization Technology or AMD-V.

it might be worth mentioning that the option is called "svm support" on my MSI mainboard  and can be found under "Advanced CPU Configuration" in the overclocking section. (see forum report msi docu - BTW, not always enabled by default),
I, for one, find that a tad counter-intuitive.

I placed this part to the wiki. It looks a bit like trouble shooting and there are two solutions with by removing the kvm option from the qemu call and accepting a lower performance of the demo or to switch on virtualization support in the hardware setting of the PC. This setting differs depending on Bios and UEFI version used. It depends on the underlying CPU architecture and also on the mainboard manufacturer. A clear answer cannot be provided in the official readme. It makes sense to have this as a general trouble shooting knowledge base. Using the wiki of the repo may serve a a base until there is a better solution for it.

Link to the wiki page: https://github.com/elisa-tech/meta-elisa/wiki/Troubleshooting


go/types, types2: error messages sometimes use x|y and sometimes x | y for union terms

Reminder issue: Should use consistent spacing for union terms in error messages.

cc: @findleyr

Decision: use x | y to match gofmt.

@griesemer Anything left to do for this issue?  Thanks.

CLs are present but I ran into problems with x/tools. Will try again.

Haven't gotten around to this. Not urgent. Moving to 1.20.


[Bug] Xenia Canary builds downloaded from Xenia Manager have no working keyboard input

Describe the bug
For some reason, and I don't know why, but Xenia Canary builds downloaded from the Xenia Manager app have no working keyboard inputs when playing a game. Every other keyboard input like hotkeys work just fine. I can not reproduce this issue when downloading the Xenia Canary release from the Github repo
To Reproduce
Steps to reproduce the behavior:

Download and install Xenia Canary from Xenia Manager
Start Xenia Canary
Start any game or app
Try and press any keyboard keys assigned to the Xbox 360 controller
No inputs work

Expected behavior
The inputs should work properly
Environment Information

OS: Windows 10 22H2
App Version: 2.1.0

Right as I reported this issue and reinstalled Xenia Canary, the inputs are working again. That's odd...


Bump version

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.51%. Comparing base (d074825) to head (e9784b6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   52.51%   52.51%
=======================================
  Files          27       27
  Lines        1489     1489
=======================================
  Hits          782      782
  Misses        707      707

Flag
Coverage Δ

unittests
52.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can the webview be "garbage collected" upon navigation?

Hello! The following code - a simplified example - causes the webview to balloon to 500MB+ of physical memory on my M1 Mac:
package main

import "github.com/webview/webview"

func main() {
	w := webview.New(true)
	defer w.Destroy()
	w.SetTitle("Basic Example")
	w.SetSize(480, 320, webview.HintNone)

	for i := 0; i < 100000; i++ {
		w.Navigate("data:text/html;base64,PGgxPkhlbGxvPC9oMT4=")
	}

	w.Run()
}

The same thing happens if I use SetHtml() instead.
In my case, I'd ideally like to open my application, and let it run for days or weeks while keeping a relatively constant footprint. I'm wondering if there are options I can set to "garbage collect" the browser history, cache, or any other resources the view is holding on to between successive calls to Navigate() or SetHtml().
Really appreciate this project, and the ecosystem that has developed on top of it!

This issue may be related:

#811

I added a comment to the linked issue above that fixes this particular issue.

The memory leaks were fixed with @jakenvac's suggestion to use NSAutoreleasePool.

Thank you for this! Can confirm, after the loop ends, memory goes from 1GB back down to 60MB. In the real world we won't be making these requests in a tight loop (there will be a few seconds between requests!) so this looks great.


New events management system

The following is not a requirement, but rather a story which can later be subdivided into later issues/requirements.
I would love to have comments/opinions on this.
The current events system works very well. The reasons, IMO, is that we never have that many current/future events at one given time.

It is easy, however, to imagine an instance of isamuni where we have even hundreds of current/future events. The current solution is very objective, but useless if we have that many events. I suggest to do the following (in no particular order):

Show events that user may interested in at the top of the table. Interest can be evaluated by letting users pin/like communities/pages/posts/events within isamuni and look for similarities. We could also look at what FB pages the user likes. Obviously, there are many ways of doing this and we could even combine these metrics together. Social metrics can also be used (e.g. how many people are going, how many of your friends are going, etc..)
Show similar events in the event modal. This could also be combined with the user metrics.
It should be possible to switch to the normal tabular view we are currently using in one click
Users should be able to find events by organiser (e.g. All GDG or Vulcanic events)
We should show the social metrics of a given event (e.g. how many people want to go, how many interested, etc)
We could show a list of friends that are going to a given event

@vigliag @giupardeb @aegroto - please give some feedback.
ps. issue #100!

I think we'll only have that many events if we aggregate events from various parts of Italy. If we do, then it's probably better to have a way to filter by region/province/distance from home city.

yes! that will help too.
I would love to deliver the events portal here in St Andrews too. We have maybe 5-10 events a day on average...

We could solve this problem by ordering events by user preference and by showing all events (future,current,past) In an unique list. First current,then future and in the end past events,each of them with a different color (and maybe an highlight on current events)

@aegroto colouring can help. I have started to do that. See latest changes.
Are you thinking about any specific user preferences?

Yes,maybe we can track tags that user looks for most.


Backslash in rezconfig.py causing errors on fresh windows installations.

Using Rez on Windows, I find that I have to manually remove a backslash in a comment in rezconfig.py before commands like rez-env will work
Environment

OS Windows11
Rez version 3.1.1
Rez python version (output of "rez-python --version")

To Reproduce

run python3 install.py [install path]
run rez-env

Expected behavior
the command finishes, even --help
Actual behavior
a back slash in a comment causes the program to fail

Are you using python 3.12? If so, rez is not yet compatible with it.


Short/long help distinction seems unclear to the end-user

 Issue by 8573
Saturday Jul 29, 2017 at 08:31 GMT
Originally opened as https://github.com/clap-rs/clap/issues/1015

FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information

This default help message, produced by clap version 2.25.1, seems to
me to imply that -h and --help do the same thing, when they don't
necessarily. For Args defined with both help and long_help,
--help may provide much more information than -h, but as far as I
can tell there is nothing to make the end-user aware of this, which
seems problematic to me.

 Comment by kbknapp
Saturday Jul 29, 2017 at 19:35 GMT

True, but then again they might do the same thing. Programs that opt in to differences (via Arg::long_help and friends) can also change the default help message to reflect those differences, such as how ripgrep does it.
I do believe this should be marked as a documentation issue.

 Comment by 8573
Saturday Jul 29, 2017 at 22:14 GMT

True, but then again they might do the same thing. Programs that
opt in to differences (via Arg::long_help and friends) can also
change the default help message to reflect those differences, such as how
ripgrep
does it.

Oh huh, I'd never noticed that in ripgrep; thanks for the tip.

I do believe this should be marked as a documentation issue.

Okay.

 Comment by martinvonz
Saturday Aug 28, 2021 at 20:36 GMT

Is it reasonable for clap to split up -h and --help into two arguments, so they appear on two lines in the help text?
I think much of the problem is that they're presented as -h, --help, which made at least me (as a user) think that they're just aliases. I'm a little worried that, even if I (as a developer) add a custom help message with App::help_message() to clarify that the two flags are different, my users might make not even read that because they see -h, --help and assume they're aliases without reading the description.


Why don't I have Content services in my SharePoint admin center?

I'm using the new SharePoint admin center (not the classic version) and the left navigation only has Home, Sites, Policies, Settings, Migration, Advanced, and More features. Term store is under More features.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ede0b3b6-c209-a6ed-9374-23a2cc9b010c
Version Independent ID: d5f088d4-97f7-ba69-e5f5-5f51a081983e
Content: Open the Term Store Management Tool - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/open-term-store-management-tool.md
Service: sharepoint-online
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

@hwkwicre the new term store user interface is currently rolling out. You should see it soon.

@hwkwicre Thank you for submitting feedback. We understand that this issue has been resolved and an update will be made soon.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Bug: add-key-phrases Function - region for TextAnalytics API is hard coded as "Westus"

This is an issue that was reported from a user in issue #1
In a functiion, add-key-phrases, the region of TextAnalytics API is hard-coded as "westus".
it should be changed with environmental value

Added TextAnalyticsAPILocation parameter to videoanalytics.conf and fixed add-key-phrases so as to read TextAnalyticsAPILocation env value.
Here is procedure:

git clone "the latest source code"
add TextAnalyticsAPILocation value  as well as the rest of parameters to videoanalytics.conf

# Location/Region name for your Text Analytics API account: "westus", "westeurope", "southeastasia", "eastus2", "westcentralus", etc
TextAnalyticsAPILocation="<Location/Region name for your Text Analytics API account>"

deploy functions with deploy-functions.sh

scripts/deploy-functions.sh


Nested \mathcal in \mathrm fails

Compiling the following file with either XeLaTeX or LuaLaTeX, the calligraphic A doesn't show up:
\documentclass{article}
\usepackage{unicode-math}
\setmainfont{TeX Gyre Pagella}
\begin{document}
$A\mathrm{\mathcal{A}}A$
\end{document}

The log file shows
Missing character: There is no 𝒜 in font TeX Gyre Pagella/OT:script=latn;language=DFLT;mapping=tex-text;!

This can be solved by using \symrm instead of \mathrm, but it is a serious flaw nonetheless, because also \DeclareMathOperator{\foo}{A\mathcal{A}A} (after loading amsmath) fails in the same fashion.
If, instead, the text font is set before loading unicode-math, the issue doesn't show:
\documentclass{article}
\usepackage{fontspec}
\setmainfont{TeX Gyre Pagella}
\usepackage{unicode-math}
\begin{document}
$A\mathrm{\mathcal{A}}A$
\end{document}

Also \DeclareMathOperator works with this setup.
Reference: http://tex.stackexchange.com/q/313584/4427

This seems to be fixed in 2017/01/27 v0.8d. Similarly to my own problem. Though I would be interested what exactly the problem was and which commit fixed it.


Is it possible to ignore specific line of code?

For example:
using namespace std; // Gives "Do not use namespace using directives"

while using suggested using std; does not compile.
Thanks.

Preferably using something like this in eslint.

You can look through the source code here, but I don't think there is such a thing currently. If you desire such functionality you would need to file an issue there.
Good luck!


⚠ ClamAV has degraded performance

In ca17a24, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 44 ms

Resolved: ClamAV performance has improved in 2a48d4c.


refactor: MEGA refactor

[!NOTE]
Stacked on top of #88

<PLACEHOLDER>: PR description will be a combination of all of the commits, but I wanted to get a draft PR first.

Please, create these as individual PRs. We won't be reviewing PR as this big.

@thesayyn ok, will do!
But just FYI I thought it would actually be much easier to do it this way since I've already separated the small fixes in #87, the small features in #88, then all of #89 is literally refactoring without adding any functionality, and then #90 has the flat repo feature + NVIDIA fix.
In here each commit is small enough and "self-contained", aiming to clean or improve a specific part and has a proper commit message explaining everything done in it (or so I hope!) and thus it can be easily reviewed one-by-one in the PR.
Anyway, I'll start breaking it up then!


Adding Milestone support for PullRequests

Looks like support for milestones is missing in the PullRequests struct...
Signed-off-by: Dave Henderson<EMAIL_ADDRESS>

Signed the CLA!

LGTM. Thanks!

LGTM.  Merging.

Thanks @shurcooL & @gmlewis! :tada:


Remove redundant .type="text/javascript" and .async=true

What kind of change does this PR introduce?
Cleanup/simplification
Did you add tests for your changes?
N/A
Summary
Remove .type = 'text/javascript' and .async = true on script-inserted elements as they are redundant. 'text/javascript' is the default type for all script elements, and all script-inserted elements are async by default.

It’s failing on whitespace changes caused by this repo’s own .editorconfig (trim trailing newlines) :(
Is there an easy way to re-generate the test/statsCases expectations?

'text/javascript' is the default type for all script elements,

Not in HTML 4.x enviroments.

and all script-inserted elements are async by default.

Is this true cross-browser? According to #535 it's not optional

@sokra

Not in HTML 4.x enviroments.

This fact that type=text/javascript is the implicit default was only codified in “HTML5”, indeed — but it wasn’t a breaking chance! Browsers have always treated <script> like that. (What does “HTML 4.x environment” even mean?)

Is this true cross-browser? According to #535 it's not optional

.async = true only has an effect in Omniweb and Firefox 3.6. I don’t think webpack really cares about those.
Maybe @diurnalist could explain the motivation behind #535 further? (Note that scriptElement.async = true is not the same as <script async>!)

Thanks
(CI failure caused by nsp security issue, which can be ignored here. It will fix itself)


ERROR: Allocation issue

Probably not much to be done about this but getting more memory but posting this in case someone has an idea beyond that.
Error occurred when executing CogVideoDecode:
Allocation on device
File "E:\ComfyUI_windows_portable\ComfyUI\execution.py", line 317, in execute
output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "E:\ComfyUI_windows_portable\ComfyUI\execution.py", line 192, in get_output_data
return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "E:\ComfyUI_windows_portable\ComfyUI\execution.py", line 169, in _map_node_over_list
process_inputs(input_dict, i)
File "E:\ComfyUI_windows_portable\ComfyUI\execution.py", line 158, in process_inputs
results.append(getattr(obj, func)(**inputs))
File "E:\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI-CogVideoXWrapper\nodes.py", line 336, in decode
frames = vae.decode(latents).sample
File "D:\Python\Python310\lib\site-packages\diffusers\utils\accelerate_utils.py", line 46, in wrapper
return method(self, *args, **kwargs)
File "D:\Python\Python310\lib\site-packages\diffusers\models\autoencoders\autoencoder_kl_cogvideox.py", line 1153, in decode
decoded = self._decode(z).sample
File "D:\Python\Python310\lib\site-packages\diffusers\models\autoencoders\autoencoder_kl_cogvideox.py", line 1123, in _decode
z_intermediate = self.decoder(z_intermediate)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1532, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1541, in _call_impl
return forward_call(*args, **kwargs)
File "D:\Python\Python310\lib\site-packages\diffusers\models\autoencoders\autoencoder_kl_cogvideox.py", line 877, in forward
hidden_states = up_block(hidden_states, temb, sample)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1532, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1541, in _call_impl
return forward_call(*args, **kwargs)
File "D:\Python\Python310\lib\site-packages\diffusers\models\autoencoders\autoencoder_kl_cogvideox.py", line 602, in forward
hidden_states = resnet(hidden_states, temb, zq)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1532, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1541, in _call_impl
return forward_call(*args, **kwargs)
File "D:\Python\Python310\lib\site-packages\diffusers\models\autoencoders\autoencoder_kl_cogvideox.py", line 286, in forward
hidden_states = self.norm1(hidden_states, zq)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1532, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "D:\Python\Python310\lib\site-packages\torch\nn\modules\module.py", line 1541, in _call_impl
return forward_call(*args, **kwargs)
File "D:\Python\Python310\lib\site-packages\diffusers\models\autoencoders\autoencoder_kl_cogvideox.py", line 187, in forward
new_f = norm_f * self.conv_y(zq) + self.conv_b(zq)

I have the same error and when I put "enable vae tiling" to true the error disappear

give me the bare min settings to use to take up the least memory. Even the smallest dimension of images would help. I have a 12gb 3060 rtx

give me the bare min settings to use to take up the least memory. Even the smallest dimension of images would help. I have a 12gb 3060 rtx

It could fit with the fp8 transformer enabled, and VAE tiling enabled on the VAE decode node. Absolute last resort is the newly added sequential_cpu_offload, it will be slow though. Also doing less frames uses less memory of course.


[2.6.x] GKE V2 Node Tags

Proposed changes
Exposes the new tags param on the gke node pool config.

Types of changes
New Feature

Linked Issues
rancher/rancher#33416

Further comments
Should be held until the back-end is in

Duplicating comment from the issue for visibility here:
Please note that Tags can only be set on create, so they should be read-only on edit forms.
https://github.com/rancher/gke-operator/pull/60#issuecomment-872665710

@snasovich this should already be the case in the UI, thanks for adding that comment.


Feature: Inlining direct svg files

I'd like to inline svg files that are directly referenced in index.html:
<!DOCTYPE html>

    <svg class="app-svg-symbols" xmlns="http://www.w3.org/2000/svg">
      <image id="icon-symbol" width="100%" height="100%" href="/src/assets/images/icon.svg" inline-source />
    </svg>

But it doesn't work, probably because the match pattern: is looking for  src= string:
https://github.com/bienzaaron/vite-plugin-inline-source/blob/4598072f67f127f88193744e7871ed00824d3000/src/index.ts#L45-L46
Is having such feature in scope of this plugin?

If you use <svg src="path/to/svg.svg/> or  it should work.
Does that meet your needs, or is there some reason you need to reference your svg using image?

Generally though, I think it makes sense to allow inlining based on other attributes than just src. Feel free to send a PR to add an option 👍

Thanks, I'll close this PR then.
Using <svg src= /> or <image src /> or  should work, but I guess the id attribute would be lost.


TypeError [ERR_INVALID_ARG_TYPE] because of react-scripts 3.3.0 seems to be broken

Got error after a clean install of npm and app:
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
    at validateString (internal/validators.js:112:11)
    at Object.join (path.js:375:7)

Looks like this is related to https://github.com/facebook/create-react-app/issues/8499 and the package jdcrensh/create-react-app needs to be updated..

I can update that to workaround this temporarily, just chang in file<EMAIL_ADDRESS>fro
line "react-dev-utils": "^10.0.0"
to
"react-dev-utils": "10.0.0"
and run npm update

This should be resolved with v3.4.2-1


'queryClient.invalidateQueries' is not working when Using multiple elements in queryKey array  with Vue

Describe the bug
I want to invalidate some queries when component is unmounted.
so, I write code like this
onUnmounted(() => {
    queryClient.invalidateQueries({ queryKey: ['key1', 'key2'] });
});

but this code is not worked
(not refetching when the component is re-rendering).
so I do invalidate query each other.. like this...
onUnmounted(() => {
    queryClient.invalidateQueries({ queryKey: ['key1'] });
    queryClient.invalidateQueries({ queryKey: ['key2'] });
});

and it's working! but the documents is written it's possible to invalidate multiple query at once.
https://tanstack.com/query/v4/docs/react/reference/QueryClient#queryclientinvalidatequeries
https://tanstack.com/query/v4/docs/react/guides/query-keys
what should I do for solving this problem?
Your minimal, reproducible example
confidential
Steps to reproduce
<script setup lang="ts">
...

onUnmounted(() => {
    queryClient.invalidateQueries({ queryKey: ['key1', 'key2'] });
});

...
</script>

Expected behavior
I expect to fetch data when the component is re-render.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform

OS: MacOs
Browser: Chrome 108
vue: ~2.7.10

Tanstack Query version
^4.17.0
TypeScript version
No response
Additional context
No response

This is a misconception of how fuzzy query invalidation works.
queryClient.invalidateQueries({ queryKey: ['key1', 'key2'] }); will invalidate all keys starting with ['key1', 'key2'], not those starting with either key1 or key2.
With query keys, it is advised to build a hierarchy, so that you can target various scopes at once. I've written about that here: https://tkdodo.eu/blog/effective-react-query-keys

@TkDodo yeah I want to invalidate all queries that I set in queryKey array.
but it doesn't work. (not invalidate when I write all keys in one array)

if you want to invalidate key1 and key2 with one call, they need to have something in common. If they are:
['foo', 'key1']
['foo', 'key2']

you can target them both with queryClient.invalidateQueries(['foo']).

ok tanks!

This is a misconception of how fuzzy query invalidation works.
queryClient.invalidateQueries({ queryKey: ['key1', 'key2'] }); will invalidate all keys starting with ['key1', 'key2'], not those starting with either key1 or key2.
With query keys, it is advised to build a hierarchy, so that you can target various scopes at once. I've written about that here: https://tkdodo.eu/blog/effective-react-query-keys

import { useQuery, useQueryClient } from '@tanstack/react-query';
import userRequest from '@/utils/AxiosInstance';
export const useGetQuery = <TResponse, TParams>(
queryKey: (string | number)[],
url: string,
params: TParams
) => {
const client = useQueryClient();
return useQuery({
queryKey: queryKey,
queryFn: async () => {
const { data } = await userRequest.get(url, {
params: params,
});
return data as TResponse;
},
onSuccess: (data: TResponse) => {
// client.invalidateQueries(queryKey);
console.log(data);
},
onError: (err) => {
console.error(err);
},
});
};
In this function it keeps reloading the api call, is there something wrong

In this function it keeps reloading the api call, is there something wrong

invalidate does a refetch, so yeah, your code refetches, and onSuccess, it refetches again, which trigger onSuccess, which fetches again ...
not sure what you're trying to achieve with invalidation in onSuccess, but please note that the callbacks (onSuccess, onError, onSettled) on useQuery are deprecated and will be removed in the next major version.

In this function it keeps reloading the api call, is there something wrong

invalidate does a refetch, so yeah, your code refetches, and onSuccess, it refetches again, which trigger onSuccess, which fetches again ...
not sure what you're trying to achieve with invalidation in onSuccess, but please note that the callbacks (onSuccess, onError, onSettled) on useQuery are deprecated and will be removed in the next major version.

Im trying to invalidate because, In my issue, Im trying to edit my record in frontend, so to do that first I use GET, then the PATCH, issue occured was after editing that record, and Im trying to edit the same record again it shows me the previous data, not the updated ones

Im trying to invalidate because, In my issue, Im trying to edit my record in frontend, so to do that first I use GET, then the PATCH, issue occured was after editing that record, and Im trying to edit the same record again it shows me the previous data, not the updated ones. How can I fix that

the query invalidation needs to happen in the callbacks of useMutation (where the PATCH request happens), not in the callbacks of the query (where the GET request happens)

Im trying to invalidate because, In my issue, Im trying to edit my record in frontend, so to do that first I use GET, then the PATCH, issue occured was after editing that record, and Im trying to edit the same record again it shows me the previous data, not the updated ones. How can I fix that

the query invalidation needs to happen in the callbacks of useMutation (where the PATCH request happens), not in the callbacks of the query (where the GET request happens)

Is there a way to invalidate the GET queries

Is there a way to invalidate the GET queries

GET/PATCH doesn't mater here, you invalidate queries by their queryKey and you should trigger invalidation at the moment when you want to invalidate it.

@kimsupin You can try something like this:
await queryClient.invalidateQueries({
                predicate: query =>
                    ['key1', 'key2' ].includes(query.queryKey[0] as queryKeys)
});

Refer this page in doc for more information.