Student unable to get certificate because  **Use the Twitch.tv JSON API Incomplete   *** isn't working.

Challenge Name

Intermediate Front End Development Projects
(100 hours)
**Use the Twitch.tv JSON API Incomplete   ***
Issue Description

Browser Information

Browser Name, Version: Multiple browsers
Operating System: Computers...Mac & PC replicated.
Mobile, Desktop, or Tablet: Android and IOS

Your Code

I have a student<EMAIL_ADDRESS>- We've found that this section of the: Use the http://Twitch.tv  JSON API Incomplete   *(Front End Development Certification), does not work...The root structure has changed and the API no longer works...this is all he has left to finish...any chance you can help us as I have a few more students getting close to this requirement.
No other way to really describe the issue, the API simply doesn't work as defined in the assignment...you follow everything and nothing works...we were unable to find anything online to hel solve or get around the issue. @freeCodeCamp told us to post the situation here.
Please email me if you have a solution as I have multiple students about to get to this point<EMAIL_ADDRESS>Appreciate the help.
Screenshot

@egosophist Did you see the update about replacing the API call per below? (step 9). It seems to be working on my end:
UPDATE: Due to a change in conditions on API usage explained here Twitch.tv now requires an API key, but we've built a workaround. Use https://wind-bow.gomix.me/twitch-api instead of twitch's API base URL (i.e. https://api.twitch.tv/kraken ) and you'll still be able to get account information, without needing to sign up for an API key.

Yes,
My student had found and tried it...with no luck. Did we miss something...
<EMAIL_ADDRESS>Mr. Green is the 1st student who's gotten this far.
He's using the update code and it isn't working...
On Fri, Oct 27, 2017 at 2:10 PM, Dylan<EMAIL_ADDRESS>wrote:

@egosophist https://github.com/egosophist Did you see the update about
replacing the API call per below? (step 9). It seems to be working on my
end:
UPDATE: Due to a change in conditions on API usage explained here
Twitch.tv now requires an API key, but we've built a workaround. Use
https://wind-bow.gomix.me/twitch-api instead of twitch's API base URL
(i.e. https://api.twitch.tv/kraken ) and you'll still be able to get
account information, without needing to sign up for an API key.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/16041#issuecomment-340059051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI_-ZcAeGE84Pf_oefu2HOjdfWS6tMj-ks5swiqdgaJpZM4QI7Zh
.

--
Sincerely,
Michael H. Twigg – M.Ed.
L**ead Developer & SERP Specialist: OkayNext.com http://OkayNext.com
"Compromise where you can. And where you can't, don't. Even if everyone is
telling you that something wrong is something right, even if the whole
world is telling you to move. It is your duty to plant yourself like a
tree, look them in the eyes and say, 'No. You move.'" - Steve Rogers &
Peggy Carter

He said this is a better email for him<EMAIL_ADDRESS>---------- Forwarded message ----------
From: Michael Twigg<EMAIL_ADDRESS>Date: Fri, Oct 27, 2017 at 2:27 PM
Subject: Re: [freeCodeCamp/freeCodeCamp] Student unable to get certificate
because **Use the Twitch.tv JSON API Incomplete *** isn't working. (#16041)
To: freeCodeCamp/freeCodeCamp <
<EMAIL_ADDRESS>
Yes,
My student had found and tried it...with no luck. Did we miss something...
<EMAIL_ADDRESS>Mr. Green is the 1st student who's gotten this far.
He's using the update code and it isn't working...
On Fri, Oct 27, 2017 at 2:10 PM, Dylan<EMAIL_ADDRESS>wrote:

@egosophist https://github.com/egosophist Did you see the update about
replacing the API call per below? (step 9). It seems to be working on my
end:
UPDATE: Due to a change in conditions on API usage explained here
Twitch.tv now requires an API key, but we've built a workaround. Use
https://wind-bow.gomix.me/twitch-api instead of twitch's API base URL
(i.e. https://api.twitch.tv/kraken ) and you'll still be able to get
account information, without needing to sign up for an API key.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/freeCodeCamp/freeCodeCamp/issues/16041#issuecomment-340059051,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI_-ZcAeGE84Pf_oefu2HOjdfWS6tMj-ks5swiqdgaJpZM4QI7Zh
.

--
Sincerely,
Michael H. Twigg – M.Ed.
L**ead Developer & SERP Specialist: OkayNext.com http://OkayNext.com
"Compromise where you can. And where you can't, don't. Even if everyone is
telling you that something wrong is something right, even if the whole
world is telling you to move. It is your duty to plant yourself like a
tree, look them in the eyes and say, 'No. You move.'" - Steve Rogers &
Peggy Carter
--
Sincerely,
Michael H. Twigg – M.Ed.
L**ead Developer & SERP Specialist: OkayNext.com http://OkayNext.com
"Compromise where you can. And where you can't, don't. Even if everyone is
telling you that something wrong is something right, even if the whole
world is telling you to move. It is your duty to plant yourself like a
tree, look them in the eyes and say, 'No. You move.'" - Steve Rogers &
Peggy Carter

Hey man, what dhcodes said is correct, you need to use https://wind-bow.gomix.me/twitch-api to make your requests. For instance, if I wanted information about the user "chesscrunchertv", I could use the url: https://wind-bow.glitch.me/twitch-api/users/chesscrunchertv. For some more information, see https://wind-bow.glitch.me/ as well as the Twitch API documentation pages.

I don't recommend posting your students' email addresses on a public site. I've removed them. Please see @rodenmonte's example for how to use the workaround.

Yeah, didn't realize this wasn't private.
He responded on his own that he's tried that with no success.
What's the time frame for the exercise to be updated on the freecodecamp website?
We love all everyone does. It's just this one section confusing us.
Sincerely,
Michael H. Twigg – M.Ed.
Lead Developer & SERP Specialist: OkayNext.com
"Compromise where you can. And where you can't, don't. Even if everyone is telling you that something wrong is something right, even if the whole world is telling you to move. It is your duty to plant yourself like a tree, look them in the eyes and say, 'No. You move.'" - Steve Rogers & Peggy Carter
Sent from TypeApp
On Oct 27, 2017, 8:16 PM, at 8:16 PM, Dylan<EMAIL_ADDRESS>wrote:

I don't recommend posting your students' email addresses on a public
site. I've removed them. Please see @rodenmonte's example for how to
use the workaround.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/freeCodeCamp/freeCodeCamp/issues/16041#issuecomment-340129339

His best bet is to ask for help on the forum or Gitter https://gitter.im/FreeCodeCamp/Help
It's hard to troubleshoot without seeing the code.

The challenge has an alternate API that is available on the production site.
This is the API just for your reference:
https://wind-bow.glitch.me/twitch-api
Going ahead and closing this.


The game crashes when starting in version 1.20.5

The game crashed whilst bootstrap
Error: java.lang.BootstrapMethodError: java.lang.RuntimeException: Mixin transformation of net.minecraft.class_2688 failed

farbic-loader-0.15.10-1.20.5 using the mods:

ferritecore-6.0.3-fabric
fabric-api-0.97.6+1.20.5

Yes, MC made some changes that were incompatible with the old FerriteCore build. I have released 6.1.0 for MC 1.20.5.


Make WaitForFleetCondition take up to 5 minutes

Should fix flakiness in autoscaler tests.

@victor-prodan :crossed_fingers: this solves the flakiness :+1:


Add docs for in-memory state store

What content needs to be created or modified?

Add docs for in-memory state store
Describe the solution you'd like

Where should the new material be placed?

component spec
The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos

https://github.com/dapr/components-contrib/pull/1326
Additional context

@skyao @seeflood please create a PR in docs as the contrib component is now merged.

ok.

@seeflood - Can you submit the docs ASAP. Without docs the release cannot go out.

@msfussell ok. Weekend todo list +1

@seeflood PLEASE can you get this PRed ASAP?

@msfussell Sorry for the delay! working on it now

Resolved


Witcher 3: no realtime reaction

Aurora detects when I play Witcher 3, but unfortunately it does not react on ingame-actions like changing the active sign. Is there something to set?

Have you installed the mod?

which mod I have to install?

Ah! I see in the overview settings. Sorry for this spam Issue!

It works in my testing but the method is not perfect. If you need any help the discord would be a better to not spam notifications :)


IcpKit showcase

Thank you for your contribution to the IC Developer Portal.
Before submitting your Pull Request, please make sure that:

[x] You have updated the .github/CODEOWNERS file according to your changes.
[x] You have registered new documents to /sidebars.js if any.

@kosta-bity Nice work on icpKit! Could you request to add it https://github.com/dfinity/awesome-internet-computer instead? It would be a better fit to list it there instead.

Thanks @jennifertrin,
I already added it on awesome internet computer. The PR has been approved.
I forgot some quotes in the json in this PR. Fix included here : https://github.com/dfinity/portal/pull/2436
Apologies for second PR, could not find a way to add a commit to this one.


[Feature][Object Storage] Allow Domain Data to be written in object storage

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Use case
As a Data Engineer, I want the flexibility to:

Save Domain-Data in Object Storage to be consumed by other systems;
Choose the data format to be written in Object Storage (e.g CSV, PARQUET, TSV);
Simplify DB management (by only keeping system tables in a OLTP system);

Currently, Apache DevLake doesn't have these features natively.
Description
By having these, any team can easily integrate Apache DevLake in their current ETL stack, and it will let teams choose the best way to persist Domain Data within their systems.
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@artofcomputing thanks for reporting! @klesh @Startrekzky could you kindly have a look?

Hi @artofcomputing , I'm open to this. Can you tell me a specific use case of how you'll use DevLake with another data format?

Thanks @Startrekzky!
My current use-case would be:

Output Domain Layer Data to CSV/Parquet in a S3 bucket
Consume S3 CSV/Parquet files with a Apache Airflow DAG
Load data into Google Big Query within the same Airflow DAG

However, by allowing Domain Layer Data to be exported to object storage (AWS S3, GCS, ABS) the possibilities are endless (I can choose X number of ETL tools to extract this data and load it into Y numbers of OLAP systems).

Hi @artofcomputing. Thank you for the feedback. I'll consider it. Just to clarify that it might not be supported in the short term as it requires a lot of work. The community has higher priorities which you can find in the roadmap

No worries @Startrekzky, it'll be a great addition to DevLake in a long term, for now I'll extract the data from the OLTP DB.


Drop Python 3.6

see: #317
see: https://github.com/zarr-developers/zarr-python/issues/765

[ ] Unit tests and/or doctests in docstrings
[ ] tox -e py39 passes locally
[ ] Docstrings and API docs for any new/modified user-facing classes and functions
[ ] Changes documented in docs/release.rst
[ ] tox -e docs passes locally
[ ] GitHub Actions CI passes
[ ] Test coverage to 100% (Coveralls passes)

@jakirkham, thoughts or help on the feedstock front(s) welcome.

Might be worth updating cibuildwheel. Also think we can skip certain builds. From their docs, this looks useful:
# Skip building on CPython 3.6 on all platforms
CIBW_SKIP: cp36-*

May need to push another commit

Good try, but I think it takes a new PR 😉

Yeah it may. Sorry pushed a couple more things. There was an old notebook that I reran. It has an issue we might need to follow up on ( https://github.com/zarr-developers/numcodecs/issues/319 ). Also added a release note. Otherwise LGTM
Thanks for working on this Josh! 😄 🙏

Hmm..was hoping that would trigger RTD without having to restart all the builds. Doesn't seem to have, but won't push on that any further in this PR.

So the wheel job has actually completed, but the status is still showing pending. Going to merge anyways.

Still seeing the Python 3.6 status as pending in PR ( https://github.com/zarr-developers/numcodecs/pull/320 ). Guessing we are missing something

Think I figured it out. Python 3.6 was still listed in the branch protection rules for master on GitHub. Removing it from that list seems to have fixed the issue.


[Refactor] Use BlockingThreadPoolExecutorService in autovacuum

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

@Mergifyio backport branch-3.1

[FE PR Coverage Check]
:disappointed: fail : 0 / 2 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/vacuum/AutovacuumDaemon.java
0
2
00.00%
[54, 102]

[FE PR Coverage Check]
:disappointed: fail : 0 / 2 (00.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/vacuum/AutovacuumDaemon.java
0
2
00.00%
[58, 107]

@Mergifyio backport branch-3.1


Should manually set metadata be saved to Local Storage?

Hi,
I successfully managed to use the library to connect to Microsoft Azure AD OIDC provider, which has been configured for Single Page Apps. Great to see all the auth code flow and PKCE in action.
Unfortunately Azure doesn't support CORS on the /.well-known/openid-configuration endpoint, so I've had to manually configure the metadata.
After calling signinRedirect() the main config (e.g. authority) is stored in Local Storage, but the metadata I entered is not stored. Which means I need to supply that information again on the call back page when using signinRedirectCallback(). Did I miss a simple configuration item?
I notice that in toStorageString() method there is no mention of metadata, so maybe the intent was never to store this?
It would be handy to have this stored as it means the library neatly encapsulates the entire process. Or would this then cause a problem with the OIDC standard?
Thanks

@brockallen - did you have any thoughts on this? Thanks!

Azure AD fully supports CORS and Authorization Code Flow (PKCE) since early 2020 (took them a while). Interestingly they also use one time use refresh tokens (even more recently).
You need to configure your OAuth Client as a Single Page App as in [step 6 of my write up[(https://authguidance.com/2017/11/30/azure-active-directory-setup/).

Azure AD fully supports CORS

Including the discovery endpoint(s)?

Yes - see my wrapper class here. Based on my Stack Overflow adventures I found out in early 2020 that it was now working in the recommended way.
Before that I had to double hop certain requests via an API to make it work. The SPA support Microsoft has added is actually pretty good.

@gary-archer - the reason I was looking at this, was to try out that new Azure AD Support for Single Page Apps.   All worked fine, but at the time it was blocking the client calling /.well-known/openid-configuration.
Just had a chance to get back to this, and the call now works from the client, so it doesn't matter that the state is not persisted.
@brockallen - I suspect you will want to close this, as the demand for this particular situation is going to be very low?


Third Party Cookies Unblocked for accounts.google.com, and still doesn't work

I click on sign in with google on messages.textfree.us and it says One moment, please. Then it disappears without even redirecting me to the site I need to be, please help.

@google-admin @googlebot

Feel free to reopen if this is still an issue.


Improve description and examples of Performance/UnneededSort

Add a more thorough description and more exhaustive examples to Performance/UnneededSort.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[ ] Added tests.
[ ] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

Nice!


regular expressions for DB Full Text search

Is your feature request related to a problem? Please describe.
ctrl-f Find has a nice feature: regular expressions. Would that this were also available in DB Full-Text search; without it, many unwanted hits occur.
Describe the solution you'd like
Add regular expresions to DB Full-Text search.

thanks for the suggestion


Added support for ghcr.io public images

Summary of changes
Added support for ghcr.io public images

Added a new section for images with the url ghcr.io in the pincher.sh script
Resolve Issue: https://github.com/sbe-arg/simple-compose-service-updates/issues/22
Does it keep it simple?
YES
Breaking Changes?
NO
How changes have been tested?, link to your runs

Tested in this repo: https://github.com/swissbuechi/compose-upgrade-test
Test PR: https://github.com/swissbuechi/compose-upgrade-test/pull/3

Any unknowns or heads ups?

Private images not supportet

Thanks for this.
Can you bump the VERSION file to v0.2.0?

bump the VERSION file to v0.2.0

Done

Awesome just waking up in NZ atm will test this manually in an hour or so so we can merge it.


Support PHPUnit tests?

Hello!
First off, thanks for this awesome adapter! I've been looking to switch to Neotest from vim-test but haven't because it wouldn't work with Docker/Sai---everything JustWorks™ with this adapter :smile:
I work on a large codebase with a mix of PHPUnit and Pest tests, Pest supports executing PHPUnit tests and we've been gradually converting them over but there's a lot of them. However, neotest-phpunit still doesn't work with Sail (at least, not like this plugin) and I can only run whole files with vim-test (executing :TestNearest runs the entire file instead of filtering the individual test case for some reason).
It would be awesome to only have to install a single adapter that works out of the box with Sail!
Thanks!

While I'd love to make this happen, at the moment I'm just not sure it's feasible due to the way test position discovery is done; I'm trying to get my head wrapped around some of the finer details of tree-sitter queries so I can implement parameterized tests and a few other small fixes (like supporting tests whose names are defined via double-quotes).
That said, I'm also not super sure what it looks like to have a project with both Pest and PHPUnit tests in one. If you can create a repo with a minimal reproduction of the type of setup you have, I'll gladly give it a shot!

If you can create a repo with a minimal reproduction of the type of setup you have, I'll gladly give it a shot!

I can create a repo if you really need it, but you can just drop any PHPUnit test (say the example test) into the Pest test suite and Pest will run it without any additional configuration (Pest is really just a wrapper around PHPUnit).

I was aware it's a wrapper around PHPUnit, but I can't say I've seen a mixed setup between the two; Sounds like it should be pretty straightforward though, so I'll poke around at it later on.

Spent some time last night and this morning looking into this a bit, and I've written up my thoughts so far in the PR where I'm exploring this in case you're curious.
Short answer is that so far it seems within reach, just needs navigating through.

Awesome! I'll take a look :smile:

Ok so @calebdw - I spent some further time yesterday playing around with ideas for resolving the differences between the logged PHPUnit test results and Pest test results, and as of this morning I think I may have it solved at this point. That said, I don't have a project setup with both Pest and PHPUnit at the moment.
I made some assumptions in it for now, just to prove out the concept (such as the tests existing in a tests folder), so it may break in unexpected ways at the moment.
I'll look at upgrading a PHPUnit project that I have later today, but for the moment feel free to update your package config to pull in the PHPUnit_Test_Support branch and let me know if/how it blows up for you =]

Sweet! It seems to be working pretty good when using function test*() methods. It does run the @test/#[Test] methods, but marks them as failed since it can't match up the results.
I did notice that it's not picking up failures in tests defined on the parent class (when I run the whole file)---granted I'm not sure how well you can detect this:

Hmm. Yeah that's a tricky ask, I'm actually not even 100% sure where to start with handling that one. That might have to come after the initial test*() method support

You might be able to look in the results for that classname and if any tests fail that are associated with it then mark the file as failed?

To clarify: It's my knowledge of neotest that breaks down here - I can think of several potential approaches, but I have no idea whether any of those approaches are reasonable to accomplish in the context of neotest; Maybe this will nerd-snipe me as the push I need to roll my sleeves up and just go dig through how neotest actually works under the hood a bit.
That's the problem with stepping in as the maintainer on an existing project that just needed some minor internal reworking: I know enough to do simple wrangling, but not enough (yet) to do more advanced stuff! ha.

So @calebdw I mentioned this over in #3  - But it looks like there's a --list-tests option I can pass to pest that might be useful both in solving parameterized tests and PHPUnit tests! Maybe!
I'm planning to take a look at it this weekend, but I'm hopeful it'll be useful.


sftp get, put?

Hello, I dont see anything in src for get and put for sftp. Is this something that needs to be added to the lib?

I believe you open a file and then you can read / write it


StrictMode warnings for unsafe lifecycle methods

Be sure to search for your issue before opening a new one.
Current Behavior
Warning: Unsafe lifecycle methods were found within a strict-mode tree:
    in StrictMode (at src/index.tsx:54)

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Player

componentWillUpdate: Please update the following components to use componentDidUpdate instead: ReactPlayer

Expected Behavior
No warning :)
Steps to Reproduce

Add the player under <React.StrictMode>

Environment

URL attempting to play: n/a
Browser: n/a
Operating system: n/a
jsFiddle example: no need

Other Information
n/a

I've created a pull request #692 implement the two instances of componentWillUpdate as componentDidUpdate.


Fix array out of bounds in ectrans-benchmark

Addresses https://github.com/ecmwf-ifs/ectrans/issues/83.  I'm not sure what is suposed to happen here; when nfld is 0 the 3rd dimension of the array zspsc3a is 0 and so referencing element 1 is out of bounds.  I have fixed this here by skipping that subroutine call when nfld is 0 but there may be a better solution.

I'm glad you found this, but I think the solution is to enforce positive definiteness for nfld. There are a few other places where this is assumed which would also have to be modified if we wanted to permit a value of 0. The variables zspsc3a and zgp3a don't make sense if there are no non-wind 3D fields, for example. I'm also not sure what ecTrans is doing when you pass an array that looks like this:
zspsc3a => sp3d(:,:,3:2)

to the PSPSC3A argument of INV/DIR_TRANS which I believe is mandatory.
Is there a specific reason you want to benchmark with no non-wind 3D fields?

In terms of this:
zspsc3a => sp3d(:,:,3:2)
it results in zspsc3a being a zero sized array so it depends what the rest of the code does with that.  Accessing element 1 (or any other element) of dimension 3 isn't allowed.
Beyond that I'm probably the wrong person to ask about the why of this.  I'm happy to implement alternative solutions though.

Fair enough. If you don't have a need to benchmark ecTrans with nfld = 0, then I suggest you close this PR and I'll put together some validation code so nfld < 0 is no longer permitted.

I don't have the need to benchmark it myself, I am just running the standard ctests.  I think the ctests should work?  If nfld = 0 is invalid then is this a problem with the ctest itself?

Oh I understand now. Sorry, I see now you were referring to this test. Hmm, I wonder why we have that test at all. @wdeconinck could you enlighten us? (Might take a while to reply as he's away.)

I think the reasoning is explained in the ectrans-benchmark file:
! 2) A Multiple "3d" fields are transformed and can be disabled with "--nfld 0"

The change looks a good step in the right direction. Wondering if it's the only problem though, as @samhatfield

It's certainly not. To be safe we would have to wrap all references to zspsc3a in the if (nfld > 0) then check. We would also need to introduce more calls to inv_trans and dir_trans without this argument provided. This is adding additional complexity to what is only supposed to be a simple benchmark. Perhaps we should just forget about the case with no fields, as it's a bit contrived anyway. Any strong thoughts there @wdeconinck?

As a benchmark it is not useful with --nfld 0, but for testing it is still a useful code path.

This PR isn't finished yet. We still need to wrap all references to zspsc3a within an if block like the one in this PR's change.

@DJDavies2 - could you make these changes in your branch?
We need similar changes here and here.

I have updated the branch.


Add double-tap & hold zoom interaction

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

See #3995


Do you have a plan to do different remapping depending on the application?

As I said in the title, the same key is mapped to different keys depending on the application.
For example, mapping C-a to Home in an application like firefox
In emacs C-a is still C-a

No, this is best done at the application level. keyd aims to be a key->key remapping tool like QMK and has no knowledge of the display server.

Okay, thanks for the reply.

You may want to keep an eye on #51 and #59.

Thanks for the heads up. I'm currently preparing to fork your code and add this part myself.

A prototype has already been implemented in #51 and will probably be fleshed out and provided as a companion script. The missing piece (to make it performant) is hot reloading which should be provided in the upcoming 2.0 release. Before you fork the project I would appreciate it if you could elaborate on how you expect such a feature to work.

A prototype has already been implemented in #51 and will probably be fleshed out and provided as a companion script. The missing piece (to make it performant) is hot reloading which should be provided in the upcoming 2.0 release. Before you fork the project I would appreciate it if you could elaborate on how you expect such a feature to work.

I skimmed through #51 and found that it seems to use the gnome interface, but I'm not a fan of gnome and I'm currently using i3wm. so it might be a bit different.
There are two main scenarios for my use

mapping to different keys in different windows
This is not so easy to do at the software level, because many software entries are used to map keys, for example, I like to use control-n for down, but in firefox this can only be used for creating new windows, so it is easier to do this in the uniput layer according to different windows, and different applications get the keys that have been simulated.
To make things more complicated, I might need to simulate a key as a key sequence or a key sequence as a key, like mapping c-x c-s to c-s in a window other than emacs.

It may be that a key may be used to execute a particular shell command in a different window.
I'm using super+<num> in i3-wm to switch between different workspaces.
And I usually have a Windows kvm guest on to use some software that is not available on linux, and I put this in a separate workspace, and then if I press super+num in the Windows guest, it is grabbed by the windows guest and I can't switch between workspaces. But if I can map different keys to execute shell commands in different applications, then I can execute i3-msg workspace 1 when I press super+1, which can greatly improve my productivity

There are two main scenarios for my use

I understand why this is desirable and, given the recent demand, will probably include support for it in the form of an optional companion script which makes use of the core.

I skimmed through #51 and found that it seems to use the gnome interface.

It was only a prototype demonstrating what is possible. Note that there is a comment in the script support all the things :P. I targeted gnome because that is what canadaduane is using.

but I'm not a fan of gnome and I'm currently using i3wm. so it might be a bit different.

Indeed.
Unfortunately there isn't a universal way to monitor and obtain window information across environments. While there is no silver bullet, it shouldn't be too hard to add support for the three major platforms (gnome, X, and wlroots based projects).
But ultimately this sort of patchwork approach is best achieved as a separate component rather than trying to pull a bunch of desktop specific libs into the main daemon. I do plan on making some changes to the core to facilitate this sort of thing, but it is already mostly possible (with a performance bottleneck that should be remedied with the 2.0 release).

But ultimately this sort of patchwork approach is best achieved as a separate component

And you can enable different methods of getting windows class (app-id in wayland) with different parameters, different configurations (or automatic detection by the program).
And in my current thinking, the mapping to shell commands via shortcuts should also be in a separate module, because there is a need to drop privileges before executing specific shell commands for security reasons.

Experimental support for this has been added. Feedback would be appreciated :).

Nice, I'll try it a little later after I'm done with the task at hand.


Overridden == being ignored under particular circumstances

Crystal is using Reference#== instead of Derived#== in the last line of the following code:
class Base
  getter foo : Base?  # One

  def ==(other : self)
    puts "Using overridden =="
    {% for ivar in @type.instance_vars %}   #
      {{ ivar.id }} == other.{{ ivar.id }}  # Two
    {% end %}                               #
    return true
  end
end

class Derived < Base
end

if false
  {Derived.new => nil}  # Three
end

p Derived.new == Derived.new # => false, should be true

Commenting out any of the sections marked One, Two, Three will cause the override for == to be used, which I believe is the correct behavior.
carc.in link: https://carc.in/#/r/5lvi
$  crystal --version
Crystal 0.27.0 (2018-11-02)

LLVM: 6.0.1
Default target: x86_64-pc-linux-gnu

I think the == here has infinite recursion - to compare Base you have to compare Base first (in a foo field).
This doesn't answers why operator isn't used but can be linked.
Also, section Three can be replaced with Base.new == Base.new (equality is used inside Hash implementation)

Another option here would be to include Comparable(Base) and your type and implement a <=> method.
https://crystal-lang.org/api/0.27.0/Comparable.html

The self restriction here causes problems, coupled with the macro method. It's a known issue (to me), I don't know why it happens. It happened in Struct too. You can use this as a workaround.

Might be related to #6760

Reduced:
class A
  def bar(other)
    false
  end
end

class B
  def bar(other : self)
    1
  end

  def bar(other : A)
    2
  end
end

class C < B
  def foo
    A.new.as(A | C)
  end

  def bar(other : self)
    {% @type %}
    foo.bar other.foo
    3
  end
end

class D < C
end

def test
  {% D.methods %} # => []
  D.new.bar(D.new) # => 3
  {% D.methods %} # => [def bar(other : self); 1; end, def bar(other : A); 2; end]
  D.new.bar(D.new) # => 1
end

test


Can I run chat on https server?

I changed this part in index.html:
ws = new WebSocket("wss://"+document.domain+":7272");
and enable ssl in start_gateway.php
$context = array(
    'ssl' => array(
        'local_cert' => __DIR__ . '/path',
        'local_pk'   => __DIR__ . '/path'
    )
);

// gateway process
$gateway = new Gateway("Websocket://<IP_ADDRESS>:7272", $context);
$gateway->transport = 'ssl';

Get following error:
Warning: stream_socket_enable_crypto(): SSL operation failed with code 1. OpenSSL Error messages:
error:14094418:SSL routines:SSL3_READ_BYTES:tlsv1 alert unknown ca in /home/orgjvpwd/public_html/user_account/video-server/vendor/workerman/workerman/Connection/TcpConnection.php on line 391
SSL Handshake fail.

Please upgrade workerman to the latest version.
Try to add 'verify_peer'  => false  to $context like this.
$context = array(
    'ssl' => array(
        'local_cert'     => __DIR__ . '/path',
        'local_pk'       => __DIR__ . '/path',
        'verify_peer'  => false,
    )
);

The Buffer information is displayed when an error occurs like this.
Warning: stream_socket_enable_crypto(): SSL operation failed with code 1. OpenSSL Error messages:
error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number in /home/www/workerman-chat/vendor/workerman/workerman/Connection/TcpConnection.php on line 392

SSL Handshake fail.
Buffer:20485454502f312e310d0a486f73743a206c6179636861742e776f726b65726d616e2e6e...

Please show the Buffer information.

Adding
'verify_peer'  => false,
didn't help.
My Workerman version:
----------------------- WORKERMAN -----------------------------
Workerman version:3.4.2          PHP version:7.1.5
------------------------ WORKERS -------------------------------
worker              listen                    processes status
ChatBusinessWorker  none                       1         [OK]
ChatGateway         websocket://<IP_ADDRESS>:7272   1         [OK]
Register            text://<IP_ADDRESS>:1236        1         [OK]
WebServer           http://<IP_ADDRESS>:55151       2         [OK]
Warning: stream_socket_enable_crypto(): SSL operation failed with code 1. OpenSSL Error messages:
error:14094418:SSL routines:SSL3_READ_BYTES:tlsv1 alert unknown ca in /home/orgjvpwd/public_html/user_account/video-server/test2/vendor/workerman/workerman/Connection/TcpConnection.php on line 391
SSL Handshake fail.
Buffer:
client:<IP_ADDRESS>:29684 gateway:<IP_ADDRESS>:7272  client_id:7f00000108fc00000001 onClose:''

Looks like the certificate is invalid.

What program you use to generate certificate? I use openssl and script make-certs.sh from this page http://stackoverflow.com/questions/19665863/how-do-i-use-a-self-signed-certificate-for-a-https-node-js-server.

I purchased the certificate from aliyun.com.

Thanks. Problem was resolved.


lib/ts/ink_sys_control.cc: define makes glibc-assumption

ink_sys_control.cc makes the assumption that linux is the equivalent of glibc, ultimately leading to this on non-glibc linuxes (where __rlimit_resource isn't defined):
In file included from ink_sys_control.cc:26:0:
ink_sys_control.cc: In function 'rlim_t ink_max_out_rlimit(int, bool, bool)':
ink_sys_control.cc:36:29: error: use of enum '__rlimit_resource' without previous declaration
 #define MAGIC_CAST(x) (enum __rlimit_resource)(x)
                             ^
../../lib/ts/ink_defs.h:98:39: note: in definition of macro 'likely'
 #define likely(x) __builtin_expect(!!(x), 1)
                                       ^
ink_sys_control.cc:42:5: note: in expansion of macro 'ink_release_assert'
     ink_release_assert(getrlimit(MAGIC_CAST(which), &rl) >= 0);
     ^~~~~~~~~~~~~~~~~~
ink_sys_control.cc:42:34: note: in expansion of macro 'MAGIC_CAST'
     ink_release_assert(getrlimit(MAGIC_CAST(which), &rl) >= 0);
                                  ^~~~~~~~~~
ink_sys_control.cc:36:29: error: use of enum '__rlimit_resource' without previous declaration
 #define MAGIC_CAST(x) (enum __rlimit_resource)(x)
                             ^
../../lib/ts/ink_defs.h:98:39: note: in definition of macro 'likely'
 #define likely(x) __builtin_expect(!!(x), 1)
                                       ^
ink_sys_control.cc:52:7: note: in expansion of macro 'ink_release_assert'
       ink_release_assert(setrlimit(MAGIC_CAST(which), &rl) >= 0);
       ^~~~~~~~~~~~~~~~~~
ink_sys_control.cc:52:36: note: in expansion of macro 'MAGIC_CAST'
       ink_release_assert(setrlimit(MAGIC_CAST(which), &rl) >= 0);
                                    ^~~~~~~~~~
ink_sys_control.cc:36:29: error: use of enum '__rlimit_resource' without previous declaration
 #define MAGIC_CAST(x) (enum __rlimit_resource)(x)
                             ^
../../lib/ts/ink_defs.h:98:39: note: in definition of macro 'likely'
 #define likely(x) __builtin_expect(!!(x), 1)
                                       ^
ink_sys_control.cc:58:5: note: in expansion of macro 'ink_release_assert'
     ink_release_assert(getrlimit(MAGIC_CAST(which), &rl) >= 0);
     ^~~~~~~~~~~~~~~~~~
ink_sys_control.cc:58:34: note: in expansion of macro 'MAGIC_CAST'
     ink_release_assert(getrlimit(MAGIC_CAST(which), &rl) >= 0);
                                  ^~~~~~~~~~
ink_sys_control.cc:36:29: error: use of enum '__rlimit_resource' without previous declaration
 #define MAGIC_CAST(x) (enum __rlimit_resource)(x)
                             ^
../../lib/ts/ink_defs.h:98:39: note: in definition of macro 'likely'
 #define likely(x) __builtin_expect(!!(x), 1)
                                       ^
ink_sys_control.cc:61:7: note: in expansion of macro 'ink_release_assert'
       ink_release_assert(setrlimit(MAGIC_CAST(which), &rl) >= 0);
       ^~~~~~~~~~~~~~~~~~
ink_sys_control.cc:61:36: note: in expansion of macro 'MAGIC_CAST'
       ink_release_assert(setrlimit(MAGIC_CAST(which), &rl) >= 0);
                                    ^~~~~~~~~~
ink_sys_control.cc:36:29: error: use of enum '__rlimit_resource' without previous declaration
 #define MAGIC_CAST(x) (enum __rlimit_resource)(x)
                             ^
../../lib/ts/ink_defs.h:98:39: note: in definition of macro 'likely'
 #define likely(x) __builtin_expect(!!(x), 1)
                                       ^
ink_sys_control.cc:65:3: note: in expansion of macro 'ink_release_assert'
   ink_release_assert(getrlimit(MAGIC_CAST(which), &rl) >= 0);
   ^~~~~~~~~~~~~~~~~~
ink_sys_control.cc:65:32: note: in expansion of macro 'MAGIC_CAST'
   ink_release_assert(getrlimit(MAGIC_CAST(which), &rl) >= 0);
                                ^~~~~~~~~~

@jbergstroem what libc have you tried? IIRC previously you checked it with musl isn't?

@webdriverrr correct, this is musl but I think uclibc doesn't cover it either. I just changed the define to __GLIBC__ instead but it obviously isn't great.


Initialise git repo when creating a kit.

Ticket: https://github.com/alphagov/govuk-prototype-kit/issues/1670
This will make the initial commit as the current user if they have set up a email address etc. in git, if they haven't set that up it will be committed as the Prototype Kit with the team email address - this is mostly for CI but it would also be useful for a user who has just set up a new computer and hasn't set up git properly yet.
As each of the test clients have git installed I have manually tested on an Ubuntu VM without git.  It works.

Thanks @nataliecarey. I think this needs an entry in the changelog?

Thanks for the reminder @lfdebrux. Updated.

@nataliecarey would be good to go through the user experience of this with you to review

Some notes as I wasn't able to review before the merge happened:

the commit here is by Your Name<EMAIL_ADDRESS>- this seems like a mistake?
there's a typo meaningulLines
The message should be just 'Create prototype' (not 'kit') to match our documentation, and I think Git practice is to have 'Create' rather than 'Created'? https://stackoverflow.com/a/3580764
this creates a master branch by default - should we change it to main?

we should also have a look at updating our git guidance
https://prototype-kit.service.gov.uk/docs/github-desktop
https://prototype-kit.service.gov.uk/docs/setting-up-git


[Backport 1.x] Bump protobuf-java from 3.21.7 to 3.21.8 in /test/fixtures/hdfs-fixtu…

…re (#4886)

Bump protobuf-java from 3.21.7 to 3.21.8 in /test/fixtures/hdfs-fixture

Bumps protobuf-java from 3.21.7 to 3.21.8.

Release notes
Changelog
Commits

updated-dependencies:

dependency-name: com.google.protobuf:protobuf-java dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>
Update changelog

Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>Signed-off-by: dependabot[bot]<EMAIL_ADDRESS>Co-authored-by: dependabot[bot]<EMAIL_ADDRESS>Co-authored-by: dependabot[bot]<EMAIL_ADDRESS>
Description
Backport #4886 to 1.x
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[X] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff
[X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #5006 (b4bc458) into 1.x (e1c682a) will increase coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                1.x    #5006      +/-   ##
============================================
+ Coverage     77.81%   77.91%   +0.09%
- Complexity    63425    63463      +38
============================================
  Files          4453     4453
  Lines        275011   275011
  Branches      41172    41172
============================================
+ Hits         214010   214282     +272
+ Misses        44043    43848     -195
+ Partials      16958    16881      -77

Impacted Files
Coverage Δ

...r/src/main/java/org/opensearch/http/HttpUtils.java
16.66% <0.00%> (-50.00%)
:arrow_down:

...earch/index/engine/FlushFailedEngineException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...rch/index/engine/RefreshFailedEngineException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...search/snapshots/InvalidSnapshotNameException.java
40.00% <0.00%> (-40.00%)
:arrow_down:

...nsearch/search/dfs/DfsPhaseExecutionException.java
0.00% <0.00%> (-33.34%)
:arrow_down:

...rg/opensearch/action/support/TransportActions.java
50.00% <0.00%> (-25.00%)
:arrow_down:

...opensearch/transport/TransportResponseHandler.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...va/org/opensearch/monitor/process/ProcessInfo.java
68.00% <0.00%> (-24.00%)
:arrow_down:

...pensearch/index/shard/SearchOperationListener.java
75.53% <0.00%> (-23.41%)
:arrow_down:

...ain/java/org/opensearch/geometry/MultiPolygon.java
80.00% <0.00%> (-20.00%)
:arrow_down:

... and 465 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Chaos Studio 2022-10-01-preview: Added optional filters object to selectors object

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run

API Readiness and TrafficViolation errors above are expected, as we have not yet deployed the service updates. This PR was created early to try to avoid being blocked waiting for review.

@brrusino can you please add the previous version as the first commit for this PR as explained in point number 7 here : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version or if you use the manual process point number 6 here : https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/208/OpenAPI-Hub-Adding-new-API-version


ci: template changes for v3.7.2 release

Template changes for v3.7.2 release
depends on #3454
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>skipping CI for now as this PR need to be rebased on top of #3454

@mergifyio rebase

/retest ci/centos/upgrade-tests-rbd

/retest ci/centos/mini-e2e/k8s-1.24


Title shows unread messages

The title of the tab now shows the amount of unread messages there are. Thanks KKosty4ka for the idea.

Thanks for the PR. However, I don't want to draw any more attention to the chat feature since OWOT is not all about the chat.


accept-language not supported

Trying to get MyBusiness Location Reviews it seems that $optParams not support 'accept-language' variable for headers.
This causes review comments in an unexpected language (such arabic instead of english etc.).
If I force adding withHeaders accept-language variable all working greats.

Hi @BusinessClick, sorry for the delayed response.
Could you share a bit more detail on how you're solving the problem? Sample code would be fantastic.
Unfortunately, since it doesn't appear the accept-language header is documented as part of the request, it's unlikely we'll be able to add it directly to $optParams, since that code is automatically generated. However, depending on how you're working around the issue, we may be able to improve things a bit!

I'm going to close this issue out. If you're still having trouble, please feel free to re-open!


Reveal headers in 404 errors and stop saying we ignore them

We do not ignore these and the unit tests expect that we don't.
Headers might reveal what's causing these errors

See: https://progress.opensuse.org/issues/133583

Why not log the body as well, like Henne suggested? What do you expect in the headers?

Why not log the body as well, like Henne suggested? What do you expect in the headers?

Because I have no idea how :-)

I played a bit with HTTPError and was able to get this working:
diff --git a/openqabot/approver.py b/openqabot/approver.py
index c8e1c8d..f9f53d0 100644
--- a/openqabot/approver.py
+++ b/openqabot/approver.py
@@ -41,8 +41,8 @@ def _handle_http_error(e: HTTPError, inc: IncReq) -> bool:
         return True
     elif e.code == 404:
         log.info(
-            "Received '%s'. Request %s removed or problem on OBS side: %s"
-            % (e.reason, inc.req, ",".join(e.headers))
+            "Received '%s'. Request %s removed or problem on OBS side: %s (%s)"
+            % (e.reason, inc.req, ",".join(e.headers), e.read().decode())
         )
         return False
     else:
diff --git a/tests/test_approve.py b/tests/test_approve.py
index 2af0a78..b0f1316 100644
--- a/tests/test_approve.py
+++ b/tests/test_approve.py
@@ -4,6 +4,7 @@ import re
 from urllib.error import HTTPError
 from urllib.parse import urlparse

+import io
 import functools
 import osc.conf
 import osc.core
@@ -299,7 +300,7 @@ def test_404_response(fake_qem, fake_two_passed_jobs, f_osconf, caplog, monkeypa
     caplog.set_level(logging.DEBUG, logger="bot.approver")

     def f_osc_core(*args, **kwds):
-        raise HTTPError("Fake OBS", 404, "Not Found", ["Foo: Bar"], None)
+        raise HTTPError("Fake OBS", 404, "Not Found", ["Foo: Bar"], io.BytesIO(b'body'))

     monkeypatch.setattr(osc.core, "change_review_state", f_osc_core)
     assert Approver(_namespace(False, "123", False, openqa_instance_url, None))() == 1
@@ -312,13 +313,13 @@ def test_404_response(fake_qem, fake_two_passed_jobs, f_osconf, caplog, monkeypa
         "* SUSE:Maintenance:3:300",
         "* SUSE:Maintenance:4:400",
         "Accepting review for SUSE:Maintenance:1:100",
-        "Received 'Not Found'. Request 100 removed or problem on OBS side: Foo: Bar",
+        "Received 'Not Found'. Request 100 removed or problem on OBS side: Foo: Bar (body)",
         "Accepting review for SUSE:Maintenance:2:200",
-        "Received 'Not Found'. Request 200 removed or problem on OBS side: Foo: Bar",
+        "Received 'Not Found'. Request 200 removed or problem on OBS side: Foo: Bar (body)",
         "Accepting review for SUSE:Maintenance:3:300",
-        "Received 'Not Found'. Request 300 removed or problem on OBS side: Foo: Bar",
+        "Received 'Not Found'. Request 300 removed or problem on OBS side: Foo: Bar (body)",
         "Accepting review for SUSE:Maintenance:4:400",
-        "Received 'Not Found'. Request 400 removed or problem on OBS side: Foo: Bar",
+        "Received 'Not Found'. Request 400 removed or problem on OBS side: Foo: Bar (body)",
         "End of bot run",
     ]


adding WAGILE.md

submitting my FOSS lifetime cycle idea.

This was assigned as a collaborative (in pairs) exercise in class


Do not keep IEditor in memory

I just came across this one:
https://github.com/microsoft/vscode/blob/5510ee9c51d94a871626a61a1c944a70acc123ec/src/vs/workbench/browser/layout.ts#L235-L235
I think it is very dangerous to keep instances of IEditor in memory because they resemble the actual editor widget (to my knowledge). So I would rather not want to keep these in-memory on a somewhat global object.
Can we find an alternative that does not require keeping instances of code editors in memory outside the lifecycle of the editor?

Good find. I can look into cleaning this up in debt week.

Removed the smartness, so we now do not keep the editors in memory.
Downside there might be some corner cases when going out of zen mode that line numbers are not restoring. I could not find this corner case right now, but I remember that was the initial reason why we had this logic


Fix nil check on nil pointers to structures.

https://github.com/dgottlieb/smarty-assertions/commit/0eedb634a98691dd4259a712f279be27d8954199 is the relevant commit I should be looking at?

If you'd like to, yep


How can make brunch to ignore bower?

I have bower file but would like to ignore it when using brunch. How can I configure brunch so it does not even notice bower.json?

config.bower.enabled = false. You will need brunch version from git (npm i brunch/brunch) for that.


Add JSDoc to createClient for clear typing docs

Hi 👋
First time contributing here, hope it's OK 🙂
I got a little confused when trying to get type generation to work with SvelteKit.    After finding that at least one other person had the same I thought a small PR might be helpful.
Consideration: Links might get outdated.
What kind of change does this PR introduce?
docs: Suggestion to add JSDoc to the createClient function.
What is the current behavior?
No JSDocs
What is the new behavior?
Some JSDocs
Additional context
PR for similar fix on the Docs: https://github.com/supabase/supabase/pull/12533
PR for Discussion Question on same topic: https://github.com/supabase/supabase/discussions/11811

Since we are just about to release a new version of sveltekit auth helpers i´m going to close this issue. The updated helpers have jsdoc comments included, thanks for mentioning them!


The CustomResourceDefinition "runnerdeployments.actions.summerwind.dev" is invalid:

Hi all,
This has been happening for me for a few weeks and I was hoping it was fixed in #123 but no such luck:
master $ kubectl apply -f https://github.com/summerwind/actions-runner-controller/releases/latest/download/actions-runner-controller.yaml
Warning: kubectl apply should be used on resource created by either kubectl create --save-config or kubectl apply
namespace/actions-runner-system configured
customresourcedefinition.apiextensions.k8s.io/horizontalrunnerautoscalers.actions.summerwind.dev created
The CustomResourceDefinition "runnerdeployments.actions.summerwind.dev" is invalid:
* spec.validation.openAPIV3Schema.properties[spec].properties[template].properties[spec].properties[sidecarContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[spec].properties[template].properties[spec].properties[containers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
* spec.validation.openAPIV3Schema.properties[spec].properties[template].properties[spec].properties[initContainers].items.properties[ports].items.properties[protocol].default: Required value: this property is in x-kubernetes-list-map-keys, so it must have a default or be a required property
master $

I've tried some debugging (hacking the CRD, use different k8s hosting) but haven't been able to figure it out.  Anyone else run into this?
Thanks

The latest release, https://github.com/summerwind/actions-runner-controller/releases/tag/v0.9.3 currently does not have the fix in #123 yet.
If you want to try it, install kustomize https://kubernetes-sigs.github.io/kustomize/installation/ and:
git clone https://github.com/summerwind/actions-runner-controller.git
kustomize build config/default > latest.yaml
kubectl apply -f latest.yaml

@igorbrigadir  - thank you so much, it worked!

The latest release, https://github.com/summerwind/actions-runner-controller/releases/tag/v0.9.3 currently does not have the fix in #123 yet.
If you want to try it, install kustomize https://kubernetes-sigs.github.io/kustomize/installation/ and:
git clone https://github.com/summerwind/actions-runner-controller.git
kustomize build config/default > latest.yaml
kubectl apply -f latest.yaml

It's enough to just run "make release" to create release manifest from master. No need to install anything (except go and make)

It's enough to just run make release to create release manifest from master. No need to install anything (except go and make)

Thank you very much @Hi-Fi - this is a great tip!

It's enough to just run make release to create release manifest from master. No need to install anything (except go and make)

Oh, that's even easier, thank you!


Error starting GPU plugin after updating to 1.5.31 (Ubuntu)

Describe the bug
GPU plugin fails to start when launching RuneLite after the latest release. There is an error log entry in client.log (see below). Once the client is launched, enabling the GPU plugin works fine, but the next time the client is launched, the plugin is disabled again. Not sure if this affects other platforms, but I am seeing the issue on Ubuntu 18.04.3 LTS.
To Reproduce
Steps to reproduce the behavior:

Launch RuneLite

Expected behavior
GPU plugin should successfully initialize on startup.
Environment (please complete the following information):

OS: Ubuntu 18.04.3 LTS
RuneLite version: <IP_ADDRESS>
Launcher version: 1.6.2

Additional context
Here are the contents of client.log:
2019-08-17 07:26:39 [Preloader] INFO  net.runelite.client.rs.ClientLoader - client-patch 273267602.227
2019-08-17 07:26:40 [RuneLite] INFO  n.r.c.plugins.kourendlibrary.Library - Library is now reset
2019-08-17 07:26:41 [RuneLite] INFO  n.r.client.discord.DiscordService - Initializing Discord RPC service.
2019-08-17 07:26:42 [Client] ERROR n.r.client.plugins.gpu.GpuPlugin - Error starting GPU plugin
com.jogamp.opengl.GLException: GLDrawableImpl.setRealized(true): Surface not ready (lockSurface)
        at jogamp.opengl.GLDrawableImpl.setRealized(GLDrawableImpl.java:184)
        at net.runelite.client.plugins.gpu.GpuPlugin.lambda$startUp$0(GpuPlugin.java:266)
        at net.runelite.client.callback.ClientThread.lambda$invoke$0(ClientThread.java:48)
        at net.runelite.client.callback.ClientThread.invoke(ClientThread.java:99)
        at net.runelite.client.callback.Hooks.clientMainLoop(Hooks.java:187)
        at client.je(client.java:15125)
        at client.ag(client.java)
        at bz.fu(bz.java:390)
        at bz.run(bz.java:344)
        at java.lang.Thread.run(Thread.java:748)
2019-08-17 07:26:43 [RuneLite] INFO  net.runelite.client.RuneLite - Client initialization took 7985ms. Uptime: 11154ms
2019-08-17 07:26:44 [AWT-EventQueue-0] INFO  net.runelite.client.ui.ClientUI - Showing frame net.runelite.client.ui.ContainableFrame[frame0,589,286,809x534,layout=java.awt.BorderLayout,title=RuneLite,resizable,maximized,defaultCloseOperation=DO_NOTHING_ON_CLOSE,rootPane=javax.swing.JRootPane[,0,0,809x534,layout=org.pushingpixels.substance.internal.ui.SubstanceRootPaneUI$SubstanceRootLayout,alignmentX=0.0,alignmentY=0.0,border=org.pushingpixels.substance.internal.utils.border.SubstancePaneBorder@1db80409,flags=16777673,maximumSize=,minimumSize=,preferredSize=],rootPaneCheckingEnabled=true]

And launcher.log (though doesn't look like there's anything relevant here):
2019-08-17 07:26:33 [main] INFO  net.runelite.launcher.Launcher - Setting hardware acceleration to OFF
2019-08-17 07:26:34 [main] WARN  net.runelite.launcher.PackrConfig - error updating packr vm args!
java.io.FileNotFoundException: /tmp/.mount_runelikM9xJf/config.json (Read-only file system)
        at java.io.FileOutputStream.open0(Native Method)
        at java.io.FileOutputStream.open(FileOutputStream.java:270)
        at java.io.FileOutputStream.<init>(FileOutputStream.java:213)
        at java.io.FileOutputStream.<init>(FileOutputStream.java:162)
        at net.runelite.launcher.PackrConfig.updateLauncherArgs(PackrConfig.java:75)
        at net.runelite.launcher.Launcher.main(Launcher.java:178)
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of client-<IP_ADDRESS>.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of slf4j-api-1.7.25.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of logback-classic-1.2.3.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of logback-core-1.2.3.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jopt-simple-5.0.1.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of guava-23.2-jre.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jsr305-1.3.9.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of error_prone_annotations-2.0.18.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of j2objc-annotations-1.1.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of animal-sniffer-annotations-1.14.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of guice-4.1.0-no_aop.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of javax.inject-1.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of aopalliance-1.0.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gson-2.8.5.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of substance-8.0.02.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of trident-1.5.00.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of commons-text-1.2.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of commons-lang3-3.7.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jogl-all-2.3.2.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jogl-all-2.3.2-natives-windows-amd64.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jogl-all-2.3.2-natives-windows-i586.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jogl-all-2.3.2-natives-linux-amd64.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jogl-all-2.3.2-natives-linux-i586.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gluegen-rt-2.3.2.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gluegen-rt-2.3.2-natives-windows-amd64.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gluegen-rt-2.3.2-natives-windows-i586.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gluegen-rt-2.3.2-natives-linux-amd64.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of gluegen-rt-2.3.2-natives-linux-i586.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jbsdiff-1.0.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of commons-compress-1.5.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jna-4.5.1.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of jna-platform-4.5.1.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of runelite-api-<IP_ADDRESS>.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of client-patch-<IP_ADDRESS>.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of http-api-<IP_ADDRESS>.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of okhttp-3.7.0.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of okio-1.12.0.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of commons-csv-1.4.jar
2019-08-17 07:26:35 [main] INFO  net.runelite.launcher.Launcher - Verified hash of discord-1.1.jar

As a side note, I noticed the fan on my PC running much louder after the recent update. I don't have a benchmark comparison since this was never an issue previously, but after the update I checked my GPU temps and they're hovering around the max that is recommended (85°C). This happens even when I'm just smithing bars in Varrock - not an especially graphics-intensive activity, I would imagine. Turning the GPU plugin off returns the temps back to normal.

Same here, fixed it changing settings.properties. Using the AppImage it doesn't seem to write the gpu setting to the config properly.
~/.runelite/settings.properties
runelite.gpuplugin=true

Just adding some more info, since the behavior I'm seeing now is a bit different than what I saw earlier. Now, if the GPU plugin was enabled when I close RuneLite, then next time I launch, it gets stuck somewhere on the main game loading screen (at a different point each time). I'm seeing some additional info in the logs too. The only way to get the client to launch now is to disable the GPU plugin (while it's stuck at the loading screen), then restart the client.
Here is client.log:
2019-08-18 08:00:17 [Preloader] INFO  net.runelite.client.rs.ClientLoader - client-patch 273267602.227
2019-08-18 08:00:18 [RuneLite] INFO  n.r.c.plugins.kourendlibrary.Library - Library is now reset
2019-08-18 08:00:19 [RuneLite] INFO  n.r.client.discord.DiscordService - Initializing Discord RPC service.
2019-08-18 08:00:21 [RuneLite] INFO  net.runelite.client.RuneLite - Client initialization took 8184ms. Uptime: 11344ms
2019-08-18 08:00:22 [AWT-EventQueue-0] INFO  net.runelite.client.ui.ClientUI - Showing frame net.runelite.client.ui.ContainableFrame[frame0,589,286,809x534,layout=java.awt.BorderLayout,title=RuneLite,resizable,maximized,defaultCloseOperation=DO_NOTHING_ON_CLOSE,rootPane=javax.swing.JRootPane[,0,0,809x534,layout=org.pushingpixels.substance.internal.ui.SubstanceRootPaneUI$SubstanceRootLayout,alignmentX=0.0,alignmentY=0.0,border=org.pushingpixels.substance.internal.utils.border.SubstancePaneBorder@1db80409,flags=16777673,maximumSize=,minimumSize=,preferredSize=],rootPaneCheckingEnabled=true]
2019-08-18 08:00:23 [Client] WARN  n.r.client.plugins.gpu.GpuPlugin - Canvas invalidated!
2019-08-18 08:00:23 [Client] ERROR net.runelite.client.RuneLite - Game crash: null
com.jogamp.opengl.GLException: Surface not ready to lock: X11OnscreenGLXDrawable[Realized true,
        Factory   jogamp.opengl.x11.glx.X11GLXDrawableFactory@23d0d2fb,
        Handle    0x4200056,
        Surface   JAWTWindow[0x1fe258bf][JVM version: 1.8.0_202 (1.8.0 update 202)
JAWT version: 0x10004, CA_LAYER: false, isLayeredSurface false, bounds [ 0 / 0  1817 x 1030 ], insets [ l 0, r 0 - t 0, b 0 - 0x0], pixelScale 1.0x1.0, shallUseOffscreenLayer false, isOffscreenLayerSurface false, attachedSurfaceLayer 0x0, windowHandle 0x4200056, surfaceHandle 0x4200056, bounds [ 0 / 0  1817 x 1030 ], insets [ l 0, r 0 - t 0, b 0 - 0x0], window [0/0 1817x1030], pixels[scale 1.0, 1.0 -> 1817x1030], visible true, lockedExt false,
        config AWTGraphicsConfiguration[AWTGraphicsScreen[AWTGraphicsDevice[type .awt, connection :0.0, unitID 0, awtDevice X11GraphicsDevice[screen=0], handle 0x0], idx 0],
        chosen    GLCaps[glx vid 0x27, fbc 0x10d: rgba 8/8/8/0, opaque, accum-rgba 16/16/16/16, dp/st/ms 24/0/0, dbl, mono  , hw, GLProfile[GL4/GL4.hw], on-scr[.]],
        requested GLCaps[rgba 8/8/8/0, opaque, accum-rgba 0/0/0/0, dp/st/ms 16/0/0, dbl, mono  , hw, GLProfile[GL4/GL4.hw], on-scr[.]],
        X11GraphicsConfig[dev=X11GraphicsDevice[screen=0],vis=0x27],
        encapsulated X11GLXGraphicsConfiguration[X11GraphicsScreen[X11GraphicsDevice[type .x11, connection :0, unitID 0, handle 0x7f504c7f22b0, owner true, JAWTToolkitLock[obj 0x4626f079, isOwner false, <5d4b2e82, 782978da>[count 0, qsz 0, owner <NULL>]]], idx 0], visualID 0x27, fbConfigID 0x10d,
        requested GLCaps[rgba 8/8/8/0, opaque, accum-rgba 0/0/0/0, dp/st/ms 16/0/0, dbl, mono  , hw, GLProfile[GL4/GL4.hw], on-scr[.]],
        chosen    GLCaps[glx vid 0x27, fbc 0x10d: rgba 8/8/8/0, opaque, accum-rgba 16/16/16/16, dp/st/ms 24/0/0, dbl, mono  , hw, GLProfile[GL4/GL4.hw], on-scr[.]]]],
        awtComponent am[canvas0,0,0,1817x1030,invalid],
        surfaceLock <7503e0c0, 4d76321>[count 0, qsz 0, owner <NULL>]]]
        at jogamp.opengl.GLContextImpl.destroy(GLContextImpl.java:454)
        at net.runelite.client.plugins.gpu.GpuPlugin.lambda$shutDown$1(GpuPlugin.java:396)
        at net.runelite.client.callback.ClientThread.lambda$invoke$0(ClientThread.java:48)
        at net.runelite.client.callback.ClientThread.invoke(ClientThread.java:61)
        at net.runelite.client.callback.ClientThread.invoke(ClientThread.java:46)
        at net.runelite.client.plugins.gpu.GpuPlugin.shutDown(GpuPlugin.java:350)
        at net.runelite.client.plugins.gpu.GpuPlugin.draw(GpuPlugin.java:792)
        at bz.tx(bz.java:20545)
        at bz.xb(bz.java)
        at bz.run(bz.java:345)
        at java.lang.Thread.run(Thread.java:748)

I can confirm the issue on Ubuntu 19.04 with the AppImage. Game crashes while loading, then I need to disable GPU, restart Runelite, then I can re-enable GPU and it works.

This happens on Red Hat Enterprise Linux 8 with the NVIDIA binary driver and OpenJDK 8 as well, the workaround described above to disable GPU plugin then re-enable after the game starts works


Fix Sequence error bubbling behavior

The Sequence class bubbled up errors in its children as warnings, which I
believe to be incorrect.
I discovered this while testing the new dependencies config: I found that invalid entries in files did not result in the overall config having any errors, and as a result erroneously being considered valid.
cc @codeclimate/review

LGTM -- is there any concern about an uptick in C* errors that may happen?

@pbrisbin I'm sure there will be a few repos in the wild that will get new C* errors, but I think it'll be a low number, and I think surfacing configs we can't process correctly as errors is an improvement for those cases.
Sequences are (aside from the new dependency files config) only used for glob lists & excluded fingerprints. I don't expect there to be much of anybody with an invalid excluded fingerprints list, but there has been confusion in the past with YAML parsing treating some globs in weird ways, specifically ones that started with ** and weren't quoted. See https://github.com/codeclimate/codeclimate/issues/476. If there are other configs similar to that one in the wild today, they'll start raising config errors.

I'm sure there will be a few repos in the wild that will get new C* errors, but I think it'll be a low number, and I think surfacing configs we can't process correctly as errors is an improvement for those cases.

That sounds good. Just wanted to mention it and make sure we're watching that graph as this deploys for anything unexpected.


Kubeflow slack invite link has expired

Hello,
The following slack invite link has expired.
https://www.kubeflow.org/docs/about/community/#:~:text=the Kubeflow community-,Slack,Join the official Kubeflow Slack with this invite link.,-Tip
Please share new invite link to join the Kubeflow slack channels.
Thanks
Balaram

Thank you for reporting this, new link is created in https://join.slack.com/t/kubeflow/shared_invite/zt-15p4qkx7a-gy2kDrQS52Y44HoSssxpcw. We are going to update documentation soon.

Thanks @zijianjoy


Possible outside of equinix?

Is it possible to use pulumi to provision a cluster on user owned hardware with no cloud provider? I didn't follow the code to see what it was doing but if I have an inventory file can I run this on my home lab?

Just wanted to leave a note in case anyone else finds this and considers it for home lab use. It isn't possible in the current state since this is a tight coupling with Equinix (see: https://github.com/pulumiverse/pulumi-aws-eksa/blob/main/provider/pkg/provider/cluster.go#L25)
This is also apparent given the unmerged PR to update the README to be more descriptive of the prerequisite to use an Equinix cluster: #1


Connection Service - Not Used

Hi Team,
Thank You for the sample application..
I was checking the entire code of this App, I found the implementation of the ConnectionService in Android.
However, as per my inspection the connection service is not being used in the app, wherein it say that is not supported.
I wanted to confirm if I am right that the Connection Service is not used in the app as of now and RTM is being used for call invitations?
Also, I wanted to know why it is now supported yet.
Thanks,
Mohit

yes RTM is being used for call invitations. We use connection service only for call interface. If you want to support push you will need to implement corresponding push notification service.


[DOC] [Remote Store] Missing option in Enable the feature section

What do you want to do?

[x] Request a change to existing documentation
[ ] Add new documentation
[ ] Report a technical problem with the documentation
[ ] Other

Tell us about your request. Provide a summary of the request and all versions that are affected.

In 2.3.0 release of OpenSearch, remote store is experimental feature and can be enabled by using 1 of the 3 options:

By updating jvm.options file
By using OPENSEARCH_JAVA_OPTS environment variable
By changing run.gradle

In the current documentation for remote store, only first 2 options are mentioned and run.gradle option is documented as a pre-requisite.
Please refer Segment Replication configuration doc for these changes

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

Hi Sachin. Please describe exactly what is missing in this document and where it needs to be added. The information you presented me explicitly calls out run.gradle as a prerequisite.  This information should have been provided to me during your technical review.
Your information stated:
To enable the feature flag:
For developers to enable with Gradle run:
Update run.gradle with:

testClusters {
  runTask {
    testDistribution = 'archive'
    if (numZones > 1) numberOfZones = numZones
    if (numNodes > 1) numberOfNodes = numNodes
    systemProperty 'opensearch.experimental.feature.replication_type.enabled', 'true'
    systemProperty 'opensearch.experimental.feature.remote_store.enabled', 'true'
  }
}

So "to enable the feature flag" we add this to run.gradle which is documented. You then went on to explain how the feature is enabled on individual nodes:
To enable on a node using a tarball:
Option 1. Update config/jvm.options with:

-Dopensearch.experimental.feature.replication_type.enabled=true
-Dopensearch.experimental.feature.remote_store.enabled=true

Option 2. include the flag in OPENSEARCH_JAVA_OPTS before ./bin/opensearch

OPENSEARCH_JAVA_OPTS="-Dopensearch.experimental.feature.replication_type.enabled=true -Dopensearch.experimental.feature.remote_store.enabled=true" ./opensearch-2.3.0/bin/opensearch

Option 3: Specify OPENSEARCH_JAVA_OPTS env var.

export OPENSEARCH_JAVA_OPTS="-Dopensearch.experimental.feature.replication_type.enabled=true -Dopensearch.experimental.feature.remote_store.enabled=true"
./bin/opensearch

This has been documented for 2.3: https://opensearch.org/docs/latest/opensearch/remote/


Dinamic content

How to insert dinamic content in description prop, betwen static content?
data() {
return {
descriptions: "Hi there! {{ here need dinamic content }} here is more static content"
}
}
Thanks in advance

Hello @miljko1984,
For that, you can use a Vuejs Computed Properties:
new Vue({
  data() {
    someProperty: 'something',
  },

  computed: {
    dynamicDescription() {
      return `Hi there! ${this.someProperty} here is more static content`;
    }
  }
});

<social-sharing description="dynamicDescription" inline-template>
  ...
</social-sharing

Hello @nicolasbeauvais,
Thank you very much!


 What @msegers said. Placing components into the entryComponents portion of the NgModule declaration will allow Angular to compile those components into component factories and therefore allow the component resolver to add them to the internal map used for component resolution.

Same issue here. The code I am trying is essentially the same demo "JazzDialog" at material2/src/demo-app/dialog/ on GitHub.

We are on RC5. Will this only work with RC-final?

I did it. Edit my app.modul.ts like https://github.com/angular/material2/blob/master/src/demo-app/demo-app-module.ts and in my component need show dialog, i edit it like https://github.com/angular/material2/tree/master/src/demo-app/dialog.

That seemed to work! Thanks!

OK, close it

FYI, it has to be the main module, at least for me, it wouldn't work in a sub-module.

@lozthiensu This issue came up again... I worked before without doing this and now with new angular updates this broke again or is this supposed to be intended use.

I also had issues with the error "No component factory". I tried declaring the component in both the same module as the parent, as well as the AppModule. Same error in both cases.
The demo on material.angular.io declares the dialog component in the same file. Maybe it's an issue for angular if you declare the component in a separate file, as you would do with any other component.

@lozthiensu you should reopen this issue because there is not clear documentation on this.

Also having this issue. Not sure how I'm supposed to get this to work in a lazy-loaded module. If i put the component in the lazy-loaded modules entryComponents array i still get:
No component factory found for xxxComponent. Did you add it to @NgModule.entryComponents

Confirmed, you cannot create a Dialog Component in a lazy-loaded module (Router loadChildren string value).
Is this an Angular project issue, or should this material2 issue be re-opened?

SOLVED with lazy loaded module:
i have done this, i have added  GenerateApiKeyComponent (dialog component) to delcarations array and in entryComponent array and its working fine. its opening dialog.
 declarations: [
    AdminComponent,
    ProjectsComponent,
    ProjectComponent,
    ProjectDetailsComponent,
    DashboardComponent,
    GenerateApiKeyComponent
  ],
  entryComponents: [
    GenerateApiKeyComponent
  ],
  providers: [ProjectService]
})

export class AdminModule {

}

Doing what @imVinayPandya did did not work for me. I'm still getting the No component factory found for <component>. error.

Looks like it will be fixed in next release #2556

@adamk33n3r please read my comment. i have already told that how it is working for me.

In case @lozthiensu instructions aren't 100% for people new to ng2+ and Material 2....
Keep in mind, if you are following the material demo code (as is @lozthiensu ) then your dialogs (JazzDialog, etc.) are individual child components, which means that you'll need to also add them to your @ngModule.declarations along with the parent component that your child components are residing in.  After that, you'll simply need to add your dialog child component(s) (i.e. JazzDialog) to @ngModule.entryComponents.
If you aren't familiar with entryComponents and how they differ from regular components I highly recommend spending 2 minutes reading this => https://angular.io/docs/ts/latest/cookbook/ngmodule-faq.html#!#q-entry-component-defined
Props to @lozthiensu for sharing his repo and the @angular team for having legit examples in their repo and thorough docs online.  I was struggling with this one for a minute.

In my case, I was not only missing
entryComponents: [
    MyDialogComponent,
  ],

(see @msegers answer)
but also
import { MaterialModule } from '@angular/material';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
...
  imports: [
    BrowserModule,
    BrowserAnimationsModule,
    MaterialModule,
   ...
  ],

inside app.module.ts

Thank you @zurfyx, I had the same problem and I solved it adding the entryComponents tag in the main module.

Hi, @zurfyx , i'm using the "@angular/material": "^2.0.0-beta.12" and i'm facing the same issue, however MaterialModule is nolonger exported by  @angular/material, How can i use your fix for the current @angular/material

@wizlif , did you find the solution? I'm having the same issue.. adding it to entryComponents and declarations does not work for me.

SOLVED with lazy loaded module:
add dialogComponent in lazy loaded module like this
bootstrap:[dialogComponent]
but also in
declarations: [dialogComponent]

In my case, the problem was that I forgot to add MatDialogModule into the lazy loaded module:
import { MatDialogModule } from '@angular/material/dialog';
imports: [MatDialogModule]

I've tried every solution here to get MyComponent working in a lazy-loaded module.

My lazy module imports the component, and MatDialogModule
MyComponent is in the declarations and entryComponents and bootstrap arrays of the lazy module

For me i opted to just add the dialog into the component that would use it.
Within the components .html i created the model.
<!-- Enter Results Dialog-->
<ng-template #feedBackResults let-dialogRef="dialogRef">
  <div layout="column" layout-fill>
    <mat-form-field mat-dialog-content flex>
      <textarea matInput placeholder="Message" rows="10"></textarea>
    </mat-form-field>
    <mat-dialog-actions align="end">
      <button mat-raised-button color="warn" class="text-upper" (click)="dialogRef.close()">Close</button>
      <button mat-raised-button class="text-upper bgc-green-500 tc-white-4" (click)="sendFeedBack()">Send</button>
    </mat-dialog-actions>
  </div>
</ng-template>

And in the .ts i opened it by referencing using the id
export class ComponentName {
  @ViewChild('feedBackResults') template: TemplateRef<any>;
   private _dialogRef: MatDialogRef<any>;

   constructor(public _dialog: MatDialog){}

  openFeedbackDialog(): void {
    this._dialogRef = this._dialog.open(this.template, {
      width: '50%',
      height: '50%'
    });
  }
}
}

The call the openFeedbackDialog() function anywhere within the component to use it.
However this will only work for a non-reusable dialog (Only available within that component.

I have the same problem but resolved now.  After I generated a new component using "ng generate ..." command, and then try dialog.open it, angular throw an error about 'No component factory found for ...'. However, once I appended a route for the component, it works fine.

@scozma You're a lifesaver, that was my issue. As well. I had my component with dialog in a lazy loaded module, in declarations and entryComponents, and the actual issue was not importing matDialog.

In my case, I imported MatDialogModule into my lazy loaded module, but still used MatDialog instance from root module, because MatDialog was injected into my own DialogService, which is provided in root module. When I use correct MatDialog instance, from lazy loaded module, there is no error.

@MartinQJD you saved me from a severe headache after one hour of trying to figure out what I was missing. Thank you very much for the discovery

Bootstrapping the component works for me :)

@mamatela Legend! I spent 2 days trying to fix this issue

@mamatela Not all heroes wear capes!

I know this is specifically an issue discussing Material, but for anyone using the Overlay CDK separately, I had to Add OverlayModule as an import in my Lazy Loaded Sub Module.
@NgModule({
  imports: [
    ...,
    OverlayModule
  ],
  providers: [
    ...,
    CustomDialogService
  ],
  declarations: [
    ...,
    DialogBodyComponent
  ],
  entryComponents: [
    ...,
    DialogBodyComponent
  ],
})
export class SubModule {}

Here you can find more information about entryComponents: https://material.angular.io/components/dialog/overview#configuring-dialog-content-via-code-entrycomponents-code-


[Bug]: Shopify cli theme dev command cause Cors 401 Error

Please confirm that you have:

[X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
[X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?
Theme
Expected behavior
Everything in my browser console run correct.
Actual behavior
http://<IP_ADDRESS>:9292/checkouts/internal/preloads.js?locale=en-US load fonts assets 401 Cors error.
Verbose output
Access to link prefetch resource at 'https://fonts.shopifycdn.com/open_sans/opensans_n4.5460e0463a398b1075386f51084d8aa756bafb17.woff2?h1=MTZjZWU1LTIubXlzaG9waWZ5LmNvbQ&hmac=d86a57be38592a2443960090a9b8f0860db15f2158124bdc62211aea22ed5529' from origin 'http://<IP_ADDRESS>:9292' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

The `http://<IP_ADDRESS>:9292/checkouts/internal/preloads.js` stack print:
preloads.js?locale=en-US:38
 GET https://fonts.shopifycdn.com/open_sans/opensans_n4.5460e04……NvbQ&hmac=d86a57b… net::ERR_FAILED 401 (Unauthorized)
prefetch	@	preloads.js?locale=en-US:38
next	@	preloads.js?locale=en-US:57
load（async）
prefetch	@	preloads.js?locale=en-US:37
next	@	preloads.js?locale=en-US:57
load（async）
prefetch	@	preloads.js?locale=en-US:37
next	@	preloads.js?locale=en-US:57
load（async）
prefetch	@	preloads.js?locale=en-US:37
next	@	preloads.js?locale=en-US:57
load（async）

Reproduction steps

pull theme
shopify theme dev
view http://<IP_ADDRESS>:9292
view browser console

Operating System
Windowns 10, WSL 2
Shopify CLI version (check your project's package.json if you're not sure)
3.58.0
Shell
bash
Node version (run node -v if you're not sure)
v18.19.0
What language and version are you using in your application?
No response

anyone view this ~

maybe related to this? https://github.com/Shopify/cli/issues/1642

Hi,
I am also experiencing this issue.
Details:

Issue: CORS error when loading font assets.

Console Output:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://vaudryjewelry.myshopify.com/cdn/fonts/gill_sans_nova/gillsansnova_n3.9bc1184b9390bb98ce0a2cb46e9266e8be923e76.woff2?h1=dmF1ZHJ5amV3ZWxyeS5jb20&h2=dmF1ZHJ5amV3ZWxyeS5hY2NvdW50Lm15c2hvcGlmeS5jb20&hmac=843b0601e2fd0c64ea9b7e52062442298891cd716a4874e6c7bab654dfbcfe44. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 401.

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://vaudryjewelry.myshopify.com/cdn/fonts/gill_sans_nova/gillsansnova_n4.bb07ca19f1ff19b6ca9f72c55add75de6c568354.woff2?h1=dmF1ZHJ5amV3ZWxyeS5jb20&h2=dmF1ZHJ5amV3ZWxyeS5hY2NvdW50Lm15c2hvcGlmeS5jb20&hmac=a67a8f5442955c4f1927dfcb37b95a6895761a870d580792c1dc6ee32cc028a6. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 401.

HTTPS-Only Mode: Upgrading insecure request “https://vaudryjewelry.myshopify.com/cdn/fonts/gill_sans_nova/gillsansnova_n4.bb07ca19f1ff19b6ca9f72c55add75de6c568354.woff2?h1=dmF1ZHJ5amV3ZWxyeS5jb20&h2=dmF1ZHJ5amV3ZWxyeS5hY2NvdW50Lm15c2hvcGlmeS5jb20&hmac=a67a8f5442955c4f1927dfcb37b95a6895761a870d580792c1dc6ee32cc028a6” failed. (M14-C1012)
gillsansnova_n4.bb07ca19f1ff19b6ca9f72c55add75de6c568354.woff2
The resource from “http://<IP_ADDRESS>:9292/checkouts/internal/preloads.js?locale=en-CA” was blocked due to MIME type (“application/json”) mismatch (X-Content-Type-Options: nosniff).
<IP_ADDRESS>:9292
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://monorail-edge.shopifysvc.com/v1/produce. (Reason: CORS request did not succeed). Status code: (null).

Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://monorail-edge.shopifysvc.com/unstable/produce_batch. (Reason: CORS request did not succeed). Status code: (null).
3
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://sessions.bugsnag.com/. (Reason: CORS request did not succeed). Status code: (null).

[bugsnag] Session failed to send… Error: Request failed with status 0
    onreadystatechange https://vaudryjewelry.myshopify.com/cdn/shopifycloud/payment-sheet/assets/latest/dynamic-checkout-cart.en.js:1
dynamic-checkout-cart.en.js:1:29112
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://notify.bugsnag.com/. (Reason: CORS request did not succeed). Status code: (null).

[bugsnag] Event failed to send… Error: Request failed with status 0
    onreadystatechange https://vaudryjewelry.myshopify.com/cdn/shopifycloud/payment-sheet/assets/latest/dynamic-checkout-cart.en.js:1
dynamic-checkout-cart.en.js:1:28416

Steps to Reproduce:

Pull theme
Run shopify theme dev
View http://<IP_ADDRESS>:9292
Check browser console

Environment:

Operating System: Linux pop-os 6.8.0
Shopify CLI Version: 3.61.2
Shell: bash
Node Version: v18.16.0
Browser: Firefox 126.0.1 (64-bit)

Additional Information:
When I ctrl + click on the terminal, I am redirected to the live domain '/?_fd=0&pb=0', but when brought up in the browser the css and fonts don't load.
Please let me know if any additional information is needed.
Thank you!


Update Profile.json

Added my profile

What happened i just followed instructions

@hrshtmlng Thanks for the contribution. PR is merged and its live.


Deep symbolic link chain results in UnhandledPromiseRejectionWarning

Scanning homedir w/ alwaysStat=true results in the following error on my system (multiple occurrences):
(node:87488) UnhandledPromiseRejectionWarning: Error: ELOOP: too many symbolic links encountered, stat '/Users/roland/Movies/Untitled.fcpbundle/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache/.fcpcache'
(node:87488) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)

I verified the symbolic link chain is present (and deep like shown).
macOS, node 10.15.1, readirp head version. Can be repro'd using standard streams sample documented by readme.

Try lstat: true

Try lstat: true

Didn't mention but I already did as much. Thanks for investigating.

Thanks for 3.0.1 update. Working flawlessly for my needs, and much appreciate the contribution!!
w/o stats
153,141 files found in 8.7s
with: { alwaysStat: true,  lstat: true } options
153,141 files in 63.7s
So, YMMV depending, because for smaller sets I find 2x perf cost like the README suggest.
Interestingly., when I enable just alwaysStat (but not lstat) the same take a very long time until out of memory error. Just FYI as something might want to look into.
Thanks again!
-Roland.


Where are the femenine words?

https://github.com/diekmrcoin/wordle-solver/blob/f4727c77e3a1ec50f00827f3abc9a9aa9fc12aa9/esp_words/o_clean.txt#L3

Hi @bayu01, there is a TODO to solve this issue, you can look into the clean-words.js file and PR if you want.


additional_pages could sometimes be html files?

maybe built by another tool? i'm checking out adbook right now...

The interesting thing about that is that you are asking for is what our "mdbook" option does but the name is terrible because it sounds like it's specific.
Passing that option all it does it copy over the folder you pass to the public folder since we don't actually build "mdbook".
maybe aditional files should accept .md or a folder?


Make numpy optional

Refactor cutil.pyx to avoid repetitions
Fix docstrings

stryd/fetch-release-asset requires an access token to get rustlib.zip, that's why the checks are failing.

@urschrei could you please review this?

@urschrei who can review this?

@urschrei The tests have passed: https://github.com/utapyngo/simplification/runs/5641757985

Hi @utapyngo, sorry for the delay at my end. I'll try to find time for a proper review this week, but in general these changes look good. I need to have a look at some details around Numpy installation and benchmarks, but we should be able to merge if those are OK.

@urschrei I have removed Cython from install_requires as it does not seem to be required for simplification to work.
Am I correct?

@urschrei could you please review?

Hi @utapyngo could you rebase against master, and then let's see about merging this…

Hi @utapyngo could you rebase against master, and then let's see about merging this…

Done.

Anyone here?


Add cl-duckdb to client list

This is my client library which works with several Common Lisp implementations. It's already on the DuckDB website.

:clap:


what's the frequency of update of the proto files corpus?

It seems that the latest version (2.4.0) is not in sync with https://github.com/googleapis/googleapis
See below:
🍊 (cd googleapis && git log -1 --oneline)
9a9e29627 (HEAD -> master, origin/master, origin/HEAD) feat: Add fields for Pub/Sub triggers
🍡 cat node_modules/google-proto-files/package.json  | grep version
  "version": "2.4.0",
🍊 diff -Nru node_modules/google-proto-files/google/home/graph/v1/homegraph.proto googleapis/google/home/graph/v1/homegraph.proto
--- node_modules/google-proto-files/google/home/graph/v1/homegraph.proto	1985-10-26 17:15:00.000000000 +0900
+++ googleapis/google/home/graph/v1/homegraph.proto	2021-04-15 21:45:00.313406274 +0900
@@ -194,10 +194,11 @@
   // Required. Third-party user ID.
   string agent_user_id = 2 [(google.api.field_behavior) = REQUIRED];

-  // Token to maintain state in the follow up notification response.
-  // Deprecated. See the [notifications
-  // guide](https://developers.google.com/assistant/smarthome/develop/notifications)
-  // for details on implementing follow up notifications.
+  // Deprecated.
+  // (-- Token to maintain state in the follow up notification response. See the
+  // notifications guide at
+  // https://developers.google.com/assistant/smarthome/develop/notifications for
+  // details on implementing follow up notifications --)
   string follow_up_token = 5 [deprecated = true];

   // Required. State of devices to update and notification metadata for devices.
👺

Should we clarify the frequency of update in the README.md file?

It's indeed not in sync. We do update it as needed.
@proppy Can you share your use case with this package? Is there any specific reason why you're using it and not the @google-cloud/* client libraries (that also have protos included)?

@summer-ji-eng Let's schedule some time to update the protos in this package.

@alexander-fenster as it also includes non-cloud APIs (like https://source.corp.google.com/piper///depot/google3/google/home/graph/v1/homegraph.proto), it's possibly used by developers willing to gain enhanced performance/optimize resource consumption over the generic Node.js client: https://github.com/googleapis/google-auth-library-nodejs
See https://stackoverflow.com/questions/67113632/how-to-call-the-home-graph-api-with-grpc-on-node-js

We did it two days ago, the latest release 2.5.0 contains the recent protos.  @summer-ji-eng We need to setup a process of regular proto updates, maybe monthly will work. In the normal case, it's just an empty feat: PR (git checkout -b update && git commit --allow-empty -m 'feat: update protos' && git push origin update) and then a release.


GUI folders

What exactly did you mean by this? Having guis in guis should already be possible using the current gui system

I was thinking about adding way to create sub-menus using something like wooden chest

Do you want to make a subclass of gui/multipagegui to do something like this or should it be added directly to gui/multipagegui?

Do you want to make a subclass of gui/multipagegui to do something like this or should it be added directly to gui/multipagegui?
I was thinking about having special class for that but I am still not sure about the implementation


How to finetune inpainting model for object removal? What is the input prompt for object removal for both training and inference?

Hi team,
Thanks for your great work!
I am trying to get object removal functionality from inpainting of SD.
How to finetune inpainting model for object removal?
What is the input prompt for object removal for both training and inference?
Thanks

do you figure out how they finetune the inpainting model? i reallly want to know that