spec: static lineage should allow for removals

Right now, the static lineage is a feature that allows you to describe datasets or jobs with input and output datasets, however, without connection to a particular run.
This allows you to bootstrap a lineage graph, or enhance an existing one where, for example, you want to attach some static metadata to existing dataset, like ownership. The bootstrapping of lineage graph fits nicely into BI systems, where creating a dashboard can be modelled as static lineage event describing job, and then executions of those datasets can be a regular run events.
However, spec does not define a way where static lineage gets deleted. Example usage for that in BI case is when dashboard gets deleted, we'd want notify consumer about that.

What scenario are you trying to cover. The ones that come to my mind are:

the dataset was present and does not exist anymore,
the static lineage event was wrong and you want to undo the event edition

The first scenario should be covered by lifecycle state change facet (https://github.com/OpenLineage/OpenLineage/blob/main/spec/facets/LifecycleStateChangeDatasetFacet.json) and I think it's already supported by Marquez. The second scenario does seem like something that should be put into the spec, nor expressed through OpenLineage events.
Is there any other scenario you have in mind?

@mobuchowski Good enough ;) Sry for silly question. We do have _deleted for JobFacet and DatasetFacet, but I don't think this would suit here well. Rather than removing, I think we should attach a facet to job meaning the job is not active anymore. Facet should contain timestamp so that consumer can know a point in time a dashboard got removed.

@pawel-big-lebowski something like LifecycleStateChangeDatasetFacet for Jobs would probably work.
The issue is what would be the states? We probably should make it reasonably generic.
I think a similar idea would fit with something like scheduled jobs as well - for example, notifying that this particular workflow should run daily, and when schedule changes (or the workflow becomes disabled) consumer is notified of that, so that it knows when and whether to expect further events.

Would we need states other than something like:
Active
Expired
??


bug: kubestellar-controller-manager expects only one ITS/IMBS - causes crachbackoffloop if multiple

Describe the bug
I had installed previously with IMBS1. I am switching to ITS in new installs.
on latest install I found bp, bdg, bd missing from wds1.  Bingo - working again and CRDs installed on WDS1
couple things wrong here.

KCM expects only one ITS/IMBS
if our naming is now ITS, then log messages should be updated to reflect that change

Steps To Reproduce

install with imbs1
re-install with its1 - without cleaning up imbs1
observe KCM backoffloop on pod in WDS'

Expected Behavior
should not crash with multiple IMBS/ITS...etc
Additional Context
No response

It is a (poorly) documented restriction that There Can Be Only One ITS. See the first figure in https://docs.kubestellar.io/main/direct/architecture/ . That is why I opened #2025 as a feature request rather than a bug report. Let's consolidate on that Issue.


[py] Make it easier to pass C++ node pointers in Python

I would like to not get too creative when trying to bind C++ code that has rclcpp::Node arguments. This is one approach.
Relates https://github.com/ros2/rclpy/issues/291

This change is

Done, I think. I had an odd failure of CMake-based ROS failing, but will see if CI shows the same issue.

@adityapande-1995 CI seems to have failed.
Can I ask if you can reproduce this (Bazel passes, CMake fails) and, if so, what might be the problem?
# Bazel
cd drake-ros
cd drake_ros
bazel run //drake_ros:core_test
# Passes

# CMake
cd ros_ws
colcon build --packages-up-to drake_ros --symlink-install
# "Shortcut" - not sure how to run single test
source install/setup.bash
( cd build/drake_ros && ctest -V -R core_test_py; )

Core bazel testing of drake_ros is done. I'm going to go ahead and skip drake_ros_examples because our caching is still broken.


WIP: Refactor common configuration into package

Create pkg/config, which is used by both pkg/endpoint and daemon. Before, such values were in pkg/endpoint, which doesn't make sense from an organizational perspective, as both daemon and endpoint configuration use these options / configuration values.

test-me-please

Closing in favor of #4086


Resolving configuration configures all tasks that publish artifacts in that project

Resolving a project configuration configures all tasks in that project that publish outgoing variants. E.g running ./gradlew consumer  fails as it tries to configure task foo:
abstract class MyTask extends DefaultTask {
    @OutputFile abstract RegularFileProperty getMyOutput();
}

def jarTask = tasks.register('foo', MyTask.class) {
    it.getMyOutput().fileValue(new File("foo/bar"))
    throw new RuntimeException("fail")
}

configurations {
    customPublishing
    toResolve
}
dependencies {
    toResolve files("foo.jar")
}
project.afterEvaluate {
    configurations.findByName("customPublishing").outgoing.variants { variants ->
        variants.create("myUniqueName") { variant ->
            variant.artifact(jarTask.flatMap {t -> t.getMyOutput() }) { artifact ->
                artifact.type = "my-custom-type"
            }
        }
    }
}

tasks.register("consumer") { Task t ->
    def c = t.project.configurations.findByName("toResolve")
    t.inputs.files(c)
    doFirst {
        println c.files
    }
}

This impacts AGP significantly, causing lots of tasks to be configured during Android Studio sync.

It looks like a duplicate of https://github.com/gradle/gradle/issues/6875
Can you please try removing the artifacts from archives configuration?
Here's a sample: https://github.com/vlsi/allure-gradle/commit/e50b5a7ef6afac408b9d833b8f041532426ddfdd#diff-33ffa30656f482ce2beaf3ac9528b373de327a87a9b2154c821af60f9fb4df67R79-R94

Thanks for that tip @vlsi , but that does not seem to fix the issue. Also, in recent versions of Gradle archives configuration has been removed IIRC.

@gavra0 ,

throw new RuntimeException("fail") should be in doLast section of the task. Please follow the example in https://docs.gradle.org/current/userguide/more_about_tasks.html#sec:defining_tasks

archives configuration exists in Gradle 7.3, and it is created in base plugin. If you add plugins { id 'base' } then you get archives. I believe 99% of plugins use base as a transitive.

@gavra0 , ok, it took me a while to understand the nature of the issue.
Please, consider using explicit failure messages rather than throw new RuntimeException("fail")
It would be so much better if you have written it as
throw new RuntimeException(":foo task must not be configured since :consumer does not have it in its dependencies")

In any case, I believe the core of the issue is the same as in https://github.com/gradle/gradle/issues/16777
The workaround is to configure artifact properties explicitly so Gradle does not try to resolve it via "lazy chains".
In the perfect world, Gradle should avoid building full metadata for resolving a single configuration, however, it looks it was just easier to implement.
In any case, adding explicit artifact names heals your case, so you might consider adding that as well.
My current set of workarounds is as follows: https://github.com/vlsi/vlsi-release-plugins/blob/ed3a3b4700af5ab4f912ca47099d8530b60c250a/plugins/stage-vote-release-plugin/src/main/kotlin/com/github/vlsi/gradle/release/ReleaseArtifacts.kt#L88-L95 :)


fix: use independent dns service for UDP e2e test

Use independent dns service for UDP e2e test, avoid create resource in kube-system namespace
Please answer these questions before submitting a pull request

Why submit this pull request?

[x] Bugfix

[ ] New feature provided

[ ] Improve performance

[ ] Backport patches

Related issues
#751

@gxthrj

Codecov Report

Merging #753 (a17917d) into master (da30386) will increase coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   31.69%   31.99%   +0.30%
==========================================
  Files          65       65
  Lines        6639     6639
==========================================
+ Hits         2104     2124      +20
+ Misses       4280     4267      -13
+ Partials      255      248       -7

Impacted Files
Coverage Δ

pkg/apisix/route.go
37.76% <0.00%> (+2.09%)
:arrow_up:

pkg/apisix/cluster.go
30.75% <0.00%> (+3.50%)
:arrow_up:

pkg/apisix/plugin.go
100.00% <0.00%> (+20.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da30386...a17917d. Read the comment docs.

@nic-6443 #754 has been merged. Can you please rebase the code? Then e2e can pass.

CI :green_circle:


Tidy up the HandleUtilsTest to deflake it.

Related:
http://b/155400612

  Stats over 10000 runs: max = 19.9s, min = 1.8s, avg = 3.9s, dev = 1.5s

Executed 1 out of 1 test: 1 test passes.```


Comment tidying

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Updating some comments
What is the current behavior? (You can also link to an open issue here)
Some comments either are missing/don't make sense.
What is the new behavior (if this is a feature change)?
I've tidied up a few comments...
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines: https://github.com/reactiveui/reactiveui#contribute
[x] Docs have been added / updated (for bug fixes / features)

Other information:
There are many more places where the comments don't line up...

@ghuntley not entirely sure what's going on here, AppVeyor has failed on OpenCover but I can't see anything obviously wrong...

https://ci.appveyor.com/project/ghuntley/reactiveui/build/505.Branch.pull/1266/merge.Sha.4a1025b956ebfb171a559c7de8e3c475412ff663#L2668
One of the tests is failing.

@ghuntley  managed to miss that test failure completely, apologies!

This PR seems to include a lot more than the title suggests, and I have to say it makes me feel a little uneasy. Not saying it won't get accepted, but I think there's considerably less chance than when a PR is more focused in what it's doing. I don't suppose you'd consider separate PRs?

@kentcb apologies, was trying to reduce the number of PRs for stuff that seemed fairly trivial...will happily split into two though.

@olevett PR's as thin highly targeted slices that get merged/integrated often; even if it takes a tiny bit more time. Progress should be incremental, in general long-running layers are discouraged 👍  Don't apologise about the broken test failure; obviously it'll need fixing up but I'm actually really happy to see. It's positive feedback that the efforts in improving integration testing is starting to pay off.


[<IP_ADDRESS>][Synchronous mode] Failed to call world.tick() in world callback

import carla
import time
client = carla.Client('localhost', 2000)
print("Now load map")
client.load_world("Town01")
world = client.get_world()

print("Now switch to sync mode")
old_settings = world.get_settings()
world.apply_settings(carla.WorldSettings(True, False, 0.01))

def callback(snapshot):
    print(snapshot.frame)
    world.tick()

print("Now set callback")
callback_id = world.on_tick(callback)

print("Now first tick")
world.tick()
time.sleep(11)

print("Now remove callback")
world.remove_on_tick(callback_id)

print("Now reset settings")
world.apply_settings(old_settings)

The script above runs smoothly in <IP_ADDRESS> but gets RuntimeError: time-out of 10000ms while waiting for the simulator in <IP_ADDRESS>
Server run in docker, client ubuntu 18.04. No server-client version mismatch.
Also I have done some tests in async mode, and it works well in <IP_ADDRESS>. So I believe my <IP_ADDRESS> server is working properly.

@thytless do you still have this problem?

@thytless do you still have this problem?

Excuse me but I have been away from this issue for quite a long time, <IP_ADDRESS> is good and stable for me. Maybe I would like to test it with latest carla later.

Seeing this intermittently in CARLA 0.9.11 when I have several vehicles using traffic manager (and a CPU bottleneck develops, see Issue #3442).  Oddly enough, it always reports a time-out of 10000ms regardless of what carla.Client::set_timeout is set to.


How to compile this as a shared library ?

Hi everyone,
I was wondering if you could please tell how I could compile this as a shared library ?
I tried using cmake but so far, without any success. Please point me to a better direction

You compile shared library by specifying the flag on the cmake command line:
 % cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -H. -Bcmake_build
 % cd cmake_build
 % make
Scanning dependencies of target cpu_features
[  6%] Building C object CMakeFiles/cpu_features.dir/src/linux_features_aggregator.c.o
[ 13%] Building C object CMakeFiles/cpu_features.dir/src/cpuid_x86_clang_gcc.c.o
[ 20%] Building C object CMakeFiles/cpu_features.dir/src/cpuid_x86_msvc.c.o
[ 26%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_aarch64.c.o
[ 33%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_arm.c.o
[ 40%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_mips.c.o
[ 46%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_ppc.c.o
[ 53%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_x86.c.o
[ 60%] Building C object CMakeFiles/cpu_features.dir/src/filesystem.c.o
[ 66%] Building C object CMakeFiles/cpu_features.dir/src/hwcaps.c.o
[ 73%] Building C object CMakeFiles/cpu_features.dir/src/stack_line_reader.c.o
[ 80%] Building C object CMakeFiles/cpu_features.dir/src/string_view.c.o
[ 86%] Linking C shared library libcpu_features.so
[ 86%] Built target cpu_features
Scanning dependencies of target list_cpu_features
[ 93%] Building C object CMakeFiles/list_cpu_features.dir/src/utils/list_cpu_features.c.o
[100%] Linking C executable list_cpu_features
[100%] Built target list_cpu_features

Please note that the use of shared libraries for cpu_feature is discouraged as stated here.

Oh, I see !
Thanks a lot @gchatelet :+1:

@gchatelet , I ran into an error while running this command on the macOS system

Abhinavs-MacBook-Pro:cpu_features eklavya$ cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -H. -Bcmake_build
-- The C compiler identification is AppleClang <IP_ADDRESS>20039
-- The CXX compiler identification is AppleClang <IP_ADDRESS>20039
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/eklavya/projects/code/c-shared-lab/cpu_features/cmake_build

Abhinavs-MacBook-Pro:cpu_features eklavya$ cd cmake_build/

Abhinavs-MacBook-Pro:cmake_build eklavya$ make
Scanning dependencies of target cpu_features
[  6%] Building C object CMakeFiles/cpu_features.dir/src/linux_features_aggregator.c.o
[ 13%] Building C object CMakeFiles/cpu_features.dir/src/cpuid_x86_clang_gcc.c.o
[ 20%] Building C object CMakeFiles/cpu_features.dir/src/cpuid_x86_msvc.c.o
[ 26%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_aarch64.c.o
[ 33%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_arm.c.o
[ 40%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_mips.c.o
[ 46%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_ppc.c.o
[ 53%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_x86.c.o
[ 60%] Building C object CMakeFiles/cpu_features.dir/src/filesystem.c.o
[ 66%] Building C object CMakeFiles/cpu_features.dir/src/hwcaps.c.o
[ 73%] Building C object CMakeFiles/cpu_features.dir/src/stack_line_reader.c.o
[ 80%] Building C object CMakeFiles/cpu_features.dir/src/string_view.c.o
[ 86%] Linking C shared library libcpu_features.dylib
Undefined symbols for architecture x86_64:
  "_CpuFeatures_GetPlatformType", referenced from:
      _GetPPCPlatformStrings in cpuinfo_ppc.c.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libcpu_features.dylib] Error 1
make[1]: *** [CMakeFiles/cpu_features.dir/all] Error 2
make: *** [all] Error 2

Shall I report this separately ?

Hmm, I tried it on my bare-metal ARMv7 - C1 instance on scaleaway and it failed to compile again
root@tuffy:~/projects/code/c-shared-libs# cd cpu_features/
root@tuffy:~/projects/code/c-shared-libs/cpu_features# cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON -H. -Bcmake_build
-- The C compiler identification is GNU 7.3.0
-- The CXX compiler identification is GNU 7.3.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /root/projects/code/c-shared-libs/cpu_features/cmake_build
root@tuffy:~/projects/code/c-shared-libs/cpu_features# cd cmake_build/
root@tuffy:~/projects/code/c-shared-libs/cpu_features/cmake_build# make
Scanning dependencies of target cpu_features
[  6%] Building C object CMakeFiles/cpu_features.dir/src/linux_features_aggregator.c.o
[ 13%] Building C object CMakeFiles/cpu_features.dir/src/cpuid_x86_clang_gcc.c.o
[ 20%] Building C object CMakeFiles/cpu_features.dir/src/cpuid_x86_msvc.c.o
[ 26%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_aarch64.c.o
[ 33%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_arm.c.o
[ 40%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_mips.c.o
[ 46%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_ppc.c.o
[ 53%] Building C object CMakeFiles/cpu_features.dir/src/cpuinfo_x86.c.o
[ 60%] Building C object CMakeFiles/cpu_features.dir/src/filesystem.c.o
[ 66%] Building C object CMakeFiles/cpu_features.dir/src/hwcaps.c.o
[ 73%] Building C object CMakeFiles/cpu_features.dir/src/stack_line_reader.c.o
[ 80%] Building C object CMakeFiles/cpu_features.dir/src/string_view.c.o
[ 86%] Linking C shared library libcpu_features.so
[ 86%] Built target cpu_features
Scanning dependencies of target list_cpu_features
[ 93%] Building C object CMakeFiles/list_cpu_features.dir/src/utils/list_cpu_features.c.o
[100%] Linking C executable list_cpu_features
libcpu_features.so: undefined reference to `GetXCR0Eax'
libcpu_features.so: undefined reference to `CpuId'
collect2: error: ld returned 1 exit status
CMakeFiles/list_cpu_features.dir/build.make:95: recipe for target 'list_cpu_features' failed
make[2]: *** [list_cpu_features] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/list_cpu_features.dir/all' failed
make[1]: *** [CMakeFiles/list_cpu_features.dir/all] Error 2
Makefile:129: recipe for target 'all' failed
make: *** [all] Error 2

Am I doing something wrong here ?

@abhi18av Please create a separate issue for both of them.

Yup, done 👍


pull request for e2e test at 01/05/2017 15:15:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


prepare.py slow speed

I have been running some experiments to debug why prepare.py is so slow.
I'll post the results here in a bit, but let me just give you a preview of why I believe it's so slow.
By default, torch seems to use a lot of threads, but it does so in a very inefficient way which actually just wastes CPU.
We attempt to get around this with:
  torch.set_num_threads(1)
  torch.set_num_interop_threads(1)

but now that we are using "spawn" as the parallelization method and the main() is guarded by:
if __name__ == '__main__':
    main()

that code is never reached.

Here are my notes from investigating the time to prepare dev-clean, including writing llc files.
The script prepare.py was modified to skip the prepare_librispeech set and just load the relevant manifest from
disk so the time is just the time taken in cut_set.compute_and_store_features().
Below I show various setups.   TL:DR: the following statements:
torch.set_num_threads(1)
torch.set_num_interop_threads(1)

need to be moved to OUTSIDE OF MAIN() for a 100-fold speed imrovement.
This should be done regardless of the num-jobs or execution setup.
with executor = None; torch.set_num_threads(1);  torch.set_num_interop_threads(1):
       real 1m17, user: 0m51, sys: 0m22

with executor = None; and no torch.setXXX, which means it uses about 25 CPUs:
        real    1m48, user: 45m45, sys: 1m6

with executor = ProcessPoolExecutor(num_jobs, mp_context=multiprocessing.get_context("spawn")),
  [in main.py: torch.set_num_threads(1);  torch.set_num_interop_threads(1)]; num_jobs = 1:
      Uses about 25 CPUs within 1 thread:
      real 1m35, user 39m30, sys 1m16.

with executor = ProcessPoolExecutor(num_jobs, mp_context=multiprocessing.get_context("spawn")),
  [in main.py: torch.set_num_threads(10);  torch.set_num_interop_threads(1)]; num_jobs = 10:
    Each thread uses about 500% CPU.
    real    10m16.768s,  user   299m8.986s, sys 2m26.761s

with executor = ProcessPoolExecutor(num_jobs, mp_context=multiprocessing.get_context("spawn")),
  [outside main.py: torch.set_num_threads(10);  torch.set_num_interop_threads(1)]; num_jobs = 10:
    Each thread uses about 500% CPU.
    real    real    0m13.860s,   user   1m8.146s, sys   0m44.639s

Also notice there is about a factor of 300 in speed between the last 2 runs, if you look at the user time taken (i.e. total across CPUs).

Let me try it under your suggestion and make a PR to fix it.

Yes, it is much faster!  👍
Use 48 cores on ('dev-clean', 'test-clean'):
real    0m47.141s
user    3m11.562s
sys     1m39.085s

🎉

I have disabled the OpenMP support for libsox on torchaudio side. https://github.com/pytorch/audio/issues/1026 It will be available through nightly binary distribution starting tomorrow. (Please check out pytorch.org for the installation of nightly build)
This should remove the suspected cause of crashing (GNU OpenMP and Intel OpenMP co-exist and interfere), and will allow you to go back to the fork method without being worried about OMP_NUM_THREADS configuration (or torch.set_num_threads).
We have minor release scheduled in the early December, so we appreciate if you can test it and confirm it resolves the issue (or not). https://github.com/pytorch/audio/issues/1021

@jimbozhang would you mind testing this?  (I think what is required is testing that the speed is ok after you revert the "spawn"->"fork" and remove the stuff about setting torch num_threads).

@jimbozhang would you mind testing this? (I think what is required is testing that the speed is ok after you revert the "spawn"->"fork" and remove the stuff about setting torch num_threads).

OK, I'll start to work on this (and k2 NVTX stuffs) next Monday. @danpovey

With the latest version's k2+lhotse+snowfall, under the path snowfall/egs/librispeech/asr/simple_v1:
$ time python prepare.py

dev-clean
Extracting and storing features in parallel: 100%|_________| 2703/2703 [00:07<00:00, 364.28it/s]

test-clean
Extracting and storing features in parallel: 100%|_________| 2620/2620 [00:07<00:00, 342.19it/s]

train-clean-100
Extracting and storing features in parallel: 100%|_________| 28539/28539 [01:26<00:00, 331.35it/s]

real    3m41.975s
user    33m55.149s
sys     5m25.221s

I think to test what he's asking about, you need to install the latest
version of TorchAudio (available through the nightly builds)... at least
I think that is what he was saying.  You might need to install PyTorch
1.7.0 in order to do that.
Perhaps you should talk to Haowen about this to-morrow.  On our test
machine we have cuda 10.1 and you are probably using PyTorch 1.6.0, so
you'll have to see whether there
Also you'd need to change the snowfall prepare.py code to use "fork"
instead of "spawn", and probably remove the 2 statements  setting
torch's num-threads to 0, to verify that it still works the same after
those changes.
On Tue, Nov 24, 2020 at 3:09 PM Junbo Zhang<EMAIL_ADDRESS>wrote:

With the latest version's k2+lhotse+snowfall, under the path
snowfall/egs/librispeech/asr/simple_v1:
$ time python prepare.py
dev-clean
Extracting and storing features in parallel: 100%|_________| 2703/2703 [00:07<00:00, 364.28it/s]
test-clean
Extracting and storing features in parallel: 100%|_________| 2620/2620 [00:07<00:00, 342.19it/s]
train-clean-100
Extracting and storing features in parallel: 100%|_________| 28539/28539 [01:26<00:00, 331.35it/s]
real    3m41.975s
user    33m55.149s
sys     5m25.221s
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/k2-fsa/snowfall/issues/18#issuecomment-732693212, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZFLO625JHOMXUVMTN4UGDSRNKS3ANCNFSM4TWZ42KA
.

Ah, apologies. I misunderstood it. I didn't notice mthrok's comment at all :sweat: and just simply tested the latest snowfall. Sorry about that ...
I'll try torchaudio with fork method tomorrow.

I tested it. The snowfall/egs/librispeech/asr/simple_v1/prepare.py worked fine when I just replaced "spawn" with "fork", with torchaudio (0.8.0.dev20201125) + torch (1.8.0.dev20201126+cu101).
But after I removed the torch.set_num_threads settings, it became extremely slow, same as before.  @mthrok @danpovey


Bugfix for specifying relative paths in .aiida-testing-config.yml

The path manipulation was using the full path of the config file
instead of the path to the directory of the config file
This was not noticed since the executable is only executed when
regenerating test data and no test was added in aiida-testing (My bad :()
A test is now added

@ltalirz I don't know what to make of the failing tests. Did something change in how the AiiDA test profile has to be set up?

Thanks @janssenhenning ! I'll have a look into the erorr

Fixed, can you please rebase on develop ?


[7229] Amended recruitment cycle year and default course year to 2024

Context
Recruitment cycle year and course year
Changes proposed in this pull request
Amended recruitment cycle year and default course year to 2024
Guidance to review
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

 Test the Publish integration and turn it on for the 2024-2025 academic year

Given all of the failing specs are to do with the current/next academic year, I think it's safe to assume that they will all start passing again on 1st August.

Yeah I decided to split it from this one https://github.com/DFE-Digital/register-trainee-teachers/pull/4387
So that there is a more granule changes, given that this is a config for next academic year


[FEATURE] Support secret CRUD on the API side

This PR is adding two new kind of object named Secret and GlobalSecret.
These two objects should be used to configure the HTTP Proxy for the datasource. It can be used for other purpose if we need secret for something else.
Note:

I didn't update yet the proxy so it can use these new configurations
I didn't take care about how to store properly the secret in the database (aka hash + salt of the sensitive informations)
I will do it later in different PRs

I guess you will do it following PRs

Yep that's what I have in mind


two options presented as one set of steps

The two options to create elastic pool are presented as one set of steps. Option 2 is presented as step 4 instead as a new step.
In addition, just replace one word: "add" with "create" as changed in the portal

#label:"aq-pr-triaged"

Ack - will review shortly.

Hi @pituach,
Thank you for submitting this PR and I apologize for the delay in getting back to you. This looks accurate and very helpful for other readers.
Thanks again for your contribution to making the docs better!
Kendra
Content Developer on the Database Docs Team
#sign-off

@LitKnd: I'm sorry - only the author of this article, @arvindshmicrosoft, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Introduce gosec for Static Application Security Testing (SAST)

What would you like to be added:
Please, ensure that linting is enabled, a new release is created, and deployed.
You can use this PR from g/g for reference
Why is this needed:
Security & Compliance

Easier to digest PR will be https://github.com/gardener/gardener-extension-shoot-oidc-service/pull/248. You can use that as a reference


[BEAM-8335] Modify the TestStreamPayload to accept an argument of output_tags and…

… modify the TestStreamFileRecord to use TestStreamPayload events.
Change-Id: I84ec1dd4698534c26c3a5219669da5f1a127250a
Adds the output_tags in the TestStreamPayload for allowing converting a TestStream to/from proto without reading from its events.
Also adds a file format version for the TestStreamFileHeader to document which version for backwards compatibility when decoding.
Also adds a list of "keys" to request which PCollection to read from in the TestStreamService.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @davidyan74

LGTM

R: @pabloem Hey Pablo, can you please review this?


Release pipeline w/ GitHub workflow + AzureML

Description

Added a GitHub workflow based release pipeline that is triggered on creation of a new tag.
The workflow executes unit and nightly tests, and if those pass, creates a draft release.
To test this pipeline, I created a new tag 1.1.1. See the run of the release pipeline triggered by this tag and a draft release created by the GitHub workflow.

Related Issues

Checklist:

[x] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[x] This PR is being made to staging branch and not to main branch.

LGTM
One detail, I see that in the PR, the release pipeline is also triggered. Is it triggered because you did the test tag, or it will be triggered in every PR?

@miguelgfierro it is only triggered when a tag matching 0.* or 1.* is created, not every PR. In this case, it was because of the test tag.


Setup.cfg support?

Would you mind adding setup.cfg support for the configuration?

The reason it's not currently supported is that pyproject.toml seems to be the standard nowadays.
However...having read some of the opinions on black, I think it'd be reasonable for slotscheck to support setup.cfg as well.
Note you can currently use --settings slotscheck.toml if you want to avoid using pyproject.toml specifically

Yes.
Yes.
Flake8 instead checks parent directories. Maybe should check subdirectories.
Raise exc if the specified file does not exist like in flake8, maybe ValueError.

I started implementing this feature, but not sure to bring it to a close.

I don't mind handling the final stretch. Let me know when you have something.

This is supported as of version 0.12.0


Wrapper function for better provisioning error logs to STDOUT

As per our discussion in the provision stream, I have modified the run function in scripts/lib/zulip_tools.py. You can have a look at an example output at http://hastebin.com/suvugoyato.rb with "Exact error>>.......<<" resembling to the exact error of the child process run by subprocess.Popen(.....). Am extremely sorry for not creating a seperate branch. Kindly consider

Automated message from Dropbox CLA bot
@Diptanshu8, thanks for the pull request! It looks like you haven't yet signed the Dropbox CLA. Please sign it here.

Closing this as a duplicate of #1902.


fix(root): fixes focus issue on navigation panel

Summary of the changes
Fixes focus issue in Firefox
Related issue
#564
Checklist

[x] I have manually accessibility tested any changes, if relevant.
[x] I have raised this pull request against the develop branch

So the subsection nav is no longer focusable, however the tab order after pressing the "skip to main content" link differs between Chrome and Firefox. On Chrome the next item in the tab order is the "skip to page content" link, whereas on Firefox it is the "Components" link. Is this a concern that it skips over an important "skip to..." link, as people may miss it if they're visiting the site for the first time? Happy to approve if it isn't a concern.

So the subsection nav is no longer focusable, however the tab order after pressing the "skip to main content" link differs between Chrome and Firefox. On Chrome the next item in the tab order is the "skip to page content" link, whereas on Firefox it is the "Components" link. Is this a concern that it skips over an important "skip to..." link, as people may miss it if they're visiting the site for the first time? Happy to approve if it isn't a concern.

For me, they both go through the top nav after 'skip to main content', and then the top nav items > skip to page content and then the first item in the left hand nav.


[Project] Establish a Lyft support rotation

This change includes:

Documentation stating the purpose, function and reasoning behind the Lyft support rotation.
A YAML file capturing the rotation list of GitHub user names and who's currently on rotation.
A script to bump who's on rotation to the next person.
A GitHub Action that runs weekly to automatically update who's on rotation.

There's a lot of room for growth in this system, such as posting who's on rotation to Slack, generating a calendar viewable in Google Calendar or other calendar clients, automatically assigning PRs, extending to have rotations for different companies or project areas etc.
Signed-off-by: JP Simard<EMAIL_ADDRESS>

Can you please take a look @alyssawilk ?


feat: toggle bold, italic, strike (close: #434)

Please check if the PR fulfills these requirements

[x] It's the right issue type on the title
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has a description of the breaking change

Description
fix #434

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

마크다운 렌더러에 이슈가 있는거 같습니다. 양쪽이 다르네요

가가나나다다라라**

이 상태에서 bold를 누르면 아래와 같이 바뀝니다.


Add subscription Id in API-Azure integration

:nut_and_bolt: Description: What code changed, and why?
Need to add an input text box for subscription_id in settings->node integration->azure-api and have to make backend changes respectively
:chains: Related Resources
https://github.com/chef/automate/issues/5252
:+1: Definition of Done

Add Input text box in settings->node integration->azure->azure-api
Input text box for subscription_id will be shown in azure-api not in VM (screenshot is mentioned below)
Done backend changes in the following  services (storing subscriptionId in secret service and retrieving them)

compliance
node manager

:athletic_shoe: How to Build and Test the Change

For UI

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command

npm run serve:hab

Backend
 rebuild components/compliance-service
 rebuild components/nodemanager-service
test cases
 go test components/nodemanager-service/managers

:white_check_mark: Checklist
All PRs must tick these:

[ ] I have read the CONTRIBUTING document.
[ ] All commits signed-off for the Developer Certification of Origin.

With occasional exceptions, all PRs from Progress employees must tick these:

[ ] Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
[ ] Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
[ ] Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
[ ] Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
[ ] Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

[x] Tests added/updated? (all new code needs new tests)
[ ] Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.
:camera: Screenshots, if applicable

Please resolve the errors in buildkite


dead link of file ThreeWayTreeMerger.swift

Request type

[ ] Please close this issue, I accidentally submitted it without adding any details
[ ] New documentation
[x] Correction or update

Details

URL https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Firefox_Sync
issue : ios there are some extensive comments here and here
this file was removed with commit
how should i proceed ?

I'd just remove the link


Merge Upstream PRs

Thanks for your work on this fork and maintaining aws-nuke! I noticed that there are several forks in the original project repo (like this one) that might be a good idea to merge (manually) into this fork. Any plans to do this?

Yes absolutely. I usually review every couple of weeks and I have it semi-automated to pull it in. Looks like I hadn't seen that on.
I plan on jumping out of beta soon, I haven't found any new issues recently. Let me know if you do.
If you want to open an issue for a candidate PR to bring it to my attention that would be great. I'll look at pulling that one over. I try and keep commit history when possible, that one looks a little messy, so I might have to do some squashing, we'll see.

:tada: This issue has been resolved in version 3.0.0-beta.40 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

Wow that was insanely fast.  Thanks!

Please give it a go and let me know if you run into any issues. I didn't have any cloud front policies to directly test it against.

Truthfully your issue caught me at a good time, I can't promise to always be this fast, but my goal is to not let things dwindle.

@Petersoj I actually found 2 minor issues I need to fix, PR inbound shortly.

I will test it out soon! Thanks again.

:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


New package: Shrike v0.1.0

Registering package: Shrike
Repository: https://github.com/djpasseyjr/Shrike.jl
Created by: @djpasseyjr
Version: v0.1.0
Commit: e77f59abfd0d0446a5cbf314e6cc1c85d7d8fb34
Reviewed by: @djpasseyjr
Reference: https://github.com/djpasseyjr/Shrike.jl/commit/e77f59abfd0d0446a5cbf314e6cc1c85d7d8fb34#commitcomment-54152628

@JuliaRegistrator register

Error while trying to register: Register Failed
@djpasseyjr, it looks like you are not a publicly listed member/owner in the parent organization (JuliaRegistries).
If you are a member/owner, you will need to change your membership to public. See GitHub Help

The robot thinks you are trying to register General. I think you need to invoke it from your package's repository, e.g. by commenting on https://github.com/djpasseyjr/Shrike.jl/commit/e923258c3b0a636581ab42167b55bffd8479e1ed
[no block]

@mcabbott Thanks for the help!

Is there anything that I need to do before this can be merged? Do I just need to wait for a person to review, as far as I can see the package meets the requirements for automatic merging now
[noblock]

Do I just need to wait for a person to review

No, but in order for automerge to work all comments must have [noblock] in them, but messages one, two and three were missing it, and this pull request simply slipped down the list of open pull requests.
You could have either deleted your own extra messages or edited them to add [noblock], but in this case you couldn't do much for the message by JuliaRegistrator.


tf1/metacal

I am creating this draft pull request to document the implementation of Metacalibration applied on our autoencoded galaxies. This code depends on the TensorFlow 1.15 code, so should be merged after #16 .

Running this script for 1600 galaxies:
S/N: 48.8465
R11: 0.0102601
m: 2.4682 +/- 3.15793 (99.7% conf)
c: 0.0442856 +/- 0.0650357 (99.7% conf)

Far from the requirements, I'll report results for higher SNR or more galaxies. If things don't improve, there might be an issue with the script

I am closing this since we don't need it now. See #3


apt-get doesn't work in Vm

Steps

create Vdisk with ubuntue template like this

{
  "id": "vdisktestdodo",
  "size": 15,
  "blocksize": 4096,
  "type": "boot",
  "templatevdisk": "ardb:///template:ubuntu-1604",
  "blockStoragecluster": "block2"
}

create vm with this disk
login inside Vm
try apt-get update

Issue
apt-get update doesn't work and any command using apt-get too

Software Version
c173cf9d353ebc3a4909ac852caa8d0c426c1f98

Software Version
477506c3ff269b2068d643e5e5debf9a0227747e


Update get-networkcontrollervirtualsubnet.md

Added descriptions and example

@AnirbanPaul,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Include klayout/python when installing

Hello @joamatab,
This PR is in addition to https://github.com/gdsfactory/gdsfactory/issues/943. This includes a minor edit to include the new python subdirectory under klayout. Without this, it is not installed when pip or conda installing gdsfactory.

Thank you Skandan!


Theme Selector Component

to embed on pages easier than making a custom one every time

maybe just make the tab component a little nicer to use (tab-selected no longer fits with the way windstorm works)


Quota or changes to the API recently ?

Hi,
I wrote some code that runs different audio files through the shazamio library and gives me back a tracklist but I noticed something strange yesterday. I retested an old run and where I would get 102 matches for a list of files mid january 2024 I now (12 feb 2024) only get 4 and all the other chunks error out in my logging with the following error :
Error with chunk_5.mp3: Check args, URL is invalid
URL- https://amp.shazam.com/discovery/v5/en-US/GB/iphone/-/tag/B8057BCE-C9BF-421D-8273-B7974DF3CEA3/8F4BD112-2382-4E5C-A050-14D86830B82F?sync=true&webv3=true&sampling=true&connected=&shazamapiversion=v3&sharehub=true&hubv5minorversion=v5.1&hidelb=true&video=v3
Error with chunk_6.mp3: Check args, URL is invalid
URL- https://amp.shazam.com/discovery/v5/en-US/GB/iphone/-/tag/AF1F5AC9-6B84-4652-BA89-2568DB3E56F8/2BFF82F8-5A28-47F4-9A35-7C9AEF3D8FAB?sync=true&webv3=true&sampling=true&connected=&shazamapiversion=v3&sharehub=true&hubv5minorversion=v5.1&hidelb=true&video=v3

etc.....

has anyone else run into the same issue recently ?
Was there any change in the library, shazam API or quota that would explain this because the code & audio files are identical ?

same thing here

@MnLgt Seems that this issue is very closely related to issue 81
Will test out the workaround from the comments in my code today

@MnLgt The workaround works, but as expected, because of the retries and delay times to circumvent the limits, any run of multiple files takes a lot longer.

All discussion is now at https://github.com/dotX12/ShazamIO/issues/81


PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453

Have this for a few days already in my php.out . It doesn't go away, so let me put in here for reference.
[11-Sep-2015 14:17:08 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453
[11-Sep-2015 15:52:51 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453
[11-Sep-2015 16:21:52 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453
[11-Sep-2015 17:04:04 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453
[11-Sep-2015 21:38:28 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453
[11-Sep-2015 23:14:50 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453
[11-Sep-2015 23:15:01 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453
[11-Sep-2015 23:32:30 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453
[12-Sep-2015 00:18:00 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453
[12-Sep-2015 00:26:50 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453
[12-Sep-2015 12:41:52 Europe/Amsterdam] PHP Warning:  stristr(): Empty needle in /var/www/hubzilla/include/items.php on line 3453

Seems to be fixed.


Initial Animate Parser added to editor

Add initial support for parsing of Adobe Animate files from the thang editor.

Going to update this to work with npm install.


pushing up a test file per tutorial

Good job! One trick: if this commit is on your local master branch, all your other PRs will start to show this file. That's no good. Normally, you should branch into a new topic branch before making commits and then merge those back into master.
For now, since it's on your master, you may need to revert this commit.


[Papercut] Schreibweise "sie" statt "Sie"

Description
Fixes SW-16254 by fixing a few typos. No side effects, even the number of letters stays the same

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?
https://issues.shopware.com/#/issues/SW-16254

How to test?
Just changes text

SW-16254 - Schreibweise "sie" statt "Sie"

Thank you @wenz for your Contribution to Shopware :+1:
Could you please change the commit message to fit the format as described here.
In your case the commit message should be SW-16254 - Change spelling of German "sie" into "Sie".
You can change the commit message using the following git command:
git commit --amend -m 'SW-16254 - Change spelling of German "sie" into "Sie"'
After that change you have to push the change to update this pull request like this:
git push origin delete-order-german-typo --force
The --force is required because with the --amend command the git history of your branch was changed and we have to tell git to overwrite the changes that are currently pushed to the origin remote.

done, thanks!


Saved Views

As ...
Nelly - Network Engineer
I want ...
to be able to save multiple list view configurations
So that ...
I can quickly switch between multiple workflows, where each workflow requires different columns in list view.
I know this is done when...

I can save several configuration of columns in list view
I can name them for easier orientation
I can quickly load any saved configuration from list view

Optional - Feature groups this request pertains to.

[ ] Automation
[ ] Circuits
[ ] DCIM
[ ] IPAM
[ ] Misc (including Data Sources)
[ ] Organization
[ ] Plugins (and other Extensibility)
[ ] Security (Secrets, etc)
[ ] Image Management
[X] UI/UX
[ ] Documentation
[ ] Other (not directly a platform feature)

Database Changes
None, it could be done with current implementation of user config
But some if cleaner solution would be implemented
External Dependencies
No response

#3774

AC:

On any list view, a user can manipulate the view as they can today (applying filters, table column config, pagination, etc)
User then have the ability to save (or update an existing) view that tracks all of the above
Users give the view a name and select whether the view should be shared with other users
On the list view, the user can quickly see the current active list view and change the saved view to another which is available

The owner and the view name should be unique together.
Save the table config, pagination, and filter params (sort order).
Url query parameters should be something similar to :<view_name>.

Implement the feature in the user app.
Combine the filter and the table config modals (filter is on the left side and table config on the right; apply (no save one-off), save (updating an existing saved view), save as (creating a new saved view), and clear buttons)
Navigation links should be grouped under the user dropdown
ListView that the saved view is applied to has to be a model CharField.
Save the user's default view (uniqueness constraint user -> list view)
Save Views button should trigger a modal to save the current view
Toggle between saved views should be a dropdown
Something like this #4784 for the Table config form
Table config should be a JSONArray field and the pagination field should be an integer field (max_page_size should win out if the pagination field stores a value larger than max_page_size)


Add aws_host param for AWS signing

Coverage remained the same at 89.797% when pulling ff8013c9e8a66962142674528ad569a6930001c8 on flamingspaz:esurl into 66c6138a618d677e48aba58da34184ba18e651af on mozilla:master.

Coverage remained the same at 89.821% when pulling b953bd7ba50ba6e94cdb6e7b15aecdd33052ad7f on flamingspaz:esurl into d731c3d1782325373354032db9e6f6f5009c69fe on mozilla:master.

Changes Unknown when pulling 33bd944100b83b6b235e681dc293c5f5df55b328 on flamingspaz:esurl into ** on mozilla:master**.

Coverage increased (+0.009%) to 89.829% when pulling dc5f97a6fdf3912dc74cf1f4e18b8c42c3ef85bd on flamingspaz:esurl into 96cf80f6157317d1aa337e1cc59093bf91185536 on mozilla:master.

Coverage increased (+1.8%) to 91.609% when pulling 959fffdf9072e3ce2ed00a5bd9f4f36a80943c67 on flamingspaz:esurl into 96cf80f6157317d1aa337e1cc59093bf91185536 on mozilla:master.


refactor: split the main code up into methods

This MR introduces a small refactor to keep codeToHtml small.
This MR also uses declare(strict_types=1) in order to scrict type the whole codebase.

This package is still a wip, thanks for the suggestions though!


unable to turn off  RBF for Timelocked txns

unable to turn off  RBF. Please fix it.

@panagiotos RBF is turned off by default.
I was able to make transactions with and without RBF.
If you are still having an issue, could you explain with more detail?

@Wowee0
RBF automatically turned off for normal txns but not for timelocked txn.

i checked a timelocked txn by turning off and on RBF at https://live.blockcypher.com/btc/decodetx/ and it always shows "opt_in_rbf": true, .

@lizz-y Here's a timelocked transaction made by coinbin on BTC testnet, tx#7d89b9821776ad1fef7aeb508209b470a5219591714bb59dfb15e43846ce1757.  Timelock script is "03c32818b1752103a51cec1cfe9844c9c3e9b536bea8edb22c1fef0af1b55b19dc197170a9e58567ac".  The TX does not have RBF turned on.
Could you provide more information, and a testnet example, created by coinbin.

Documentation:

https://medium.com/summa-technology/bitcoins-time-locks-27e0c362d7a1 - a good overview much more readable than the obtuse BIP documentation.
https://bitcoin.stackexchange.com/questions/87372/what-does-the-sequence-in-a-transaction-input-mean - answer that comprehensively explores nSequence and how it has evolved since inception
https://github.com/bitcoin/bips/blob/master/bip-0065.mediawiki - official spec OP_CHECKLOCKTIMEVERIFY.

Thank you very much for addressing the issue.


Iterative unfolding overview documentation

We should add a "Unfolding overview" page to the documentation that goes over what unfolding is generally (big picture stuff) and introduces relevant terminology (e.g. "cause bins", "prior").

I put in general big picture stuff, but didn't get to terminology. I will write a subsection in the overview commit I made earlier.

Closed by #30


Add 'state_class' property to Sensor class (fixes #96).

Description
Add 'state_class' property to Sensor class.
See https://developers.home-assistant.io/docs/core/entity/sensor
Fixes #96

License Acceptance

[x] This repository is Apache version 2.0 licensed and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Type of changes

[ ] Add/update a helper script
[ ] Add/update link to an external resource like a blog post or video
[ ] Bug fix
[x] New feature
[ ] Test updates
[ ] Text cleanups/updates

Checklist

[x] I have read the CONTRIBUTING document.
[x] All new and existing tests pass.
[ ] Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
[ ] Scripts added/updated in this PR are all marked executable.
[ ] Scripts added/updated in this PR do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
[ ] I have confirmed that any links added or updated in my PR are valid.

Thanks for the help!


PreFlight check-operator fails with unauthorized to access repository

Bug Description
I'm following these steps.
https://github.com/redhat-openshift-ecosystem/certification-releases/blob/main/4.9/ga/ci-pipeline.md
My pipeline fails with this error.
time="2022-05-03T18:00:09Z" level=fatal msg="failed to pull remote container: GET https://harbor.starburstdata.net/v2/starburstdata/starburst-enterprise-helm-operator-rhmp/manifests/370.2.0: UNAUTHORIZED: unauthorized to access repository: starburstdata/starburst-enterprise-helm-operator-rhmp, action: pull: unauthorized to access repository: starburstdata/starburst-enterprise-helm-operator-rhmp, action: pull"
The pipeline successfully built and pushed that target image - harbor.starburstdata.net/starburstdata/starburst-enterprise-helm-operator-rhmp:370.2.0. It is stored in our private repo, hosted by Harbor.
Version and Command Invocation
v1.0.6, but I have also downloaded the latest source from here (on 5-May-2022) and found the error was still there.
Steps to Reproduce:

Get a private container registry you can use.
Add credentials for that container registry as the registry-dockerconfig-secret k8s secret.
Run the pipeline.

Expected Result
It should pass the preflight step without exception.
Actual Result
The preflight utility cannot read the registry-dockerconfig-secret  k8s secret, even thought it is properly mounted to the container and referenced in the PFLT_DOCKERCONFIG env var.
Additional Context
This was originally raised with RedHat support as https://access.redhat.com/support/cases/#/case/03211150
When I run the preflight command on my workstation, it will properly read the PFLT_DOCKERCONFIG environment variable and successfully authenticate to our harbor.starburstdata.net registry.
Also on my workstation, unsetting PFLT_DOCKERCONFIG, or setting its value to a file that doesn't exist, will yield the expected results and cause the preflight command to show an appropriate error. That is, I can see that it is affected by what is in that variable.
However, when I “kubectl exec” into the operator-ci-pipeline-run-xxxx-preflight-pod/step-check-operator container the results are different. Unsetting PFLT_DOCKERCONFIG or setting it to an invalid file name has no effect on the pipeline command. It still throws the same "unauthorized to access repository" error time, no matter what I do to that variable.
What is more interesting with “kubectl exec” is that entering this cp command will get past the error!
cp $PFLT_DOCKERCONFIG /root/.docker/config.json
That is, overwriting the default docker authentication file with our credentials gets past the error.
This leads me to believe that there is something wrong with the way the preflight utility is processing this variable when it is running in the k8s container. It is completely ignoring PFLT_DOCKERCONFIG and is instead using docker’s default auth config.
I added that “cp” statement to my copy of the tasks/preflight.yml file, re-deployed, and the pipeline then got past the preflight:check-operator step!
Other variables seem fine inside the k8s container. If I change PFLT_LOGLEVEL or PFLT_LOGFILE, the preflight utility will adjust its log messages accordingly. So, from what I can tell it is only the processing of PFLT_DOCKERCONFIG that’s messed up, but I haven’t been able to test the other PFLT variables, other than those mentioned above.
Finally, I created of this fork of this repo (branch frankk/add-workarounds) where I added in that "cp" statement from above to the preflight.yml script that deploys this preflight utility, and have found this gets me past the problem and allows me to run the whole certification pipeline from beginning to end successfully. I'm guessing that's not the best way to fix this permanently, but thought it might help.

/assign

Hey @fckuligowski, Thanks for reporting this issue. My apologies for the weirdness!
I believe this should be resolved as of 1.2.0. Try that version and see if the problem persists.
In earlier versions of the operator checks, I believe the value of PFLT_DOCKERCONFIG was used solely to provide the path to the auth file that Preflight should pass to a remote cluster in order for Scorecard checks to be able to pull images from private registries.
Internally, Preflight's operator checks were still using the common locations (e.g. $DOCKER_CONFIG/config.json) for local checks.
Based on the error you provided, I'm almost certain that the version of preflight you used required your $DOCKER_CONFIG/config.json to have valid credentials (i.e. be logged in).
Looking at your workaround fork of operator-pipelines, I'm reading that the credentials passed in by the user should also be merged to $DOCKER_CONFIG/config.json which should have allowed Preflight (assuming an older version that may be running in that pipeline) to authenticate to the private registry.
https://github.com/starburstdata/operator-pipelines/commit/6179b8c3125571b32680be095d38c67b957de784#diff-a5e64e903acc5c1701af7281b078186803ccfac1c2caca05da58c52c6f94b87dR50-R71

Either way -
Preflight (as of 1.2.0) should be using the credentials stored in PFLT_DOCKERCONFIG for both local execution, remote execution, and submission (for container checks), and should no longer use $DOCKER_CONFIG/config.json at all. That was done in a combination of these PRs:
https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/588
https://github.com/redhat-openshift-ecosystem/openshift-preflight/pull/598
I know you mentioned you built from source as of 2022-05-05, and I think those changes should have been on main at that point. Would you mind testing against the 1.2.0 release to see if you see the same issue? At least in local testing, I don't see the same issue when I specify PFLT_DOCKERCONFIG with 1.2.0. Disregard the errors, this bundle is not being tested against an actual cluster.
(issue610) $ KUBECONFIG=./non-existent-kubeconfig PFLT_INDEXIMAGE=quay.io/opdev/simple-demo-operator-catalog:v0.0.5 PFLT_DOCKERCONFIG="./auth.json" ./preflight-1.2.0 check operator quay.io/komish/simple-demo-operator-private:0.0.5
time="2022-05-12T15:53:40-05:00" level=info msg="certification library version 1.2.0 <commit: 8374f324bfb1c54a5e2698b048d5f9d671813936>"
time="2022-05-12T15:53:41-05:00" level=error msg="unable to load the config, check if KUBECONFIG is set correctly: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable"
time="2022-05-12T15:53:41-05:00" level=error msg="Unable to determine test cluster version: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable"
time="2022-05-12T15:53:41-05:00" level=info msg="check completed: ScorecardBasicSpecCheck" ERROR="failed to run
... truncated ...
{
    "image": "quay.io/komish/simple-demo-operator-private:0.0.5",
    "passed": false,
    "certification_hash": "741e581a7b6ae6198a865baa1af24731",
    "test_library": {
        "name": "github.com/redhat-openshift-ecosystem/openshift-preflight",
        "version": "1.2.0",
        "commit": "8374f324bfb1c54a5e2698b048d5f9d671813936"
    },
    "results": {
        "passed": [],
        "failed": [],
        "errors": [
            {
                "name": "ScorecardBasicSpecCheck",
                "elapsed_time": 0,
                "description": "Check to make sure that all CRs have a spec block.",
                "help": "There was a fatal error while running operator-sdk scorecard tests. Please see the preflight log for details. If necessary, set logging to be more verbose."
            },
            {
                "name": "ScorecardOlmSuiteCheck",
                "elapsed_time": 0,
                "description": "Operator-sdk scorecard OLM Test Suite Check",
                "help": "There was a fatal error while running operator-sdk scorecard tests. Please see the preflight log for details. If necessary, set logging to be more verbose."
            },
            {
                "name": "DeployableByOLM",
                "elapsed_time": 0,
                "description": "Checking if the operator could be deployed by OLM",
                "help": "It is required that your operator could be deployed by OLM"
            },
            {
                "name": "ValidateOperatorBundle",
                "elapsed_time": 0,
                "description": "Validating Bundle image that checks if it can validate the content and format of the operator bundle",
                "help": "Check ValidateOperatorBundle encountered an error. Please review the preflight.log file for more information."
            }
        ]
    }
}

Comparing that to what I see against 1.1.0, 1.1.0 exits immediately with the same error you mentioned ("Unauthorized")
(issue610) $ KUBECONFIG=./non-existent-kubeconfig PFLT_INDEXIMAGE=quay.io/opdev/simple-demo-operator-catalog:v0.0.5 PFLT_DOCKERCONFIG="./auth.json" ./preflight-1.1.0 check operator quay.io/komish/simple-demo-operator-private:0.0.5
time="2022-05-12T15:55:59-05:00" level=info msg="certification library version 1.1.0 <commit: f1628fcf489aed88711d6cac95c3f096217f9feb>"
Error: failed to pull remote container: GET https://quay.io/v2/komish/simple-demo-operator-private/manifests/0.0.5: UNAUTHORIZED: access to the requested resource is not authorized; map[]
time="2022-05-12T15:55:59-05:00" level=fatal msg="failed to pull remote container: GET https://quay.io/v2/komish/simple-demo-operator-private/manifests/0.0.5: UNAUTHORIZED: access to the requested resource is not authorized; map[]"

Version 1.1.1 looks the same as 1.2.0:
(issue610) $ KUBECONFIG=./non-existent-kubeconfig PFLT_INDEXIMAGE=quay.io/opdev/simple-demo-operator-catalog:v0.0.5 PFLT_DOCKERCONFIG="./auth.json" ./preflight-1.1.1 check operator quay.io/komish/simple-demo-operator-private:0.0.5
time="2022-05-12T15:56:51-05:00" level=info msg="certification library version 1.1.1 <commit: a4cd06de61d3f795fae58bb73841ae94ade08705>"
time="2022-05-12T15:56:52-05:00" level=error msg="unable to load the config, check if KUBECONFIG is set correctly: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable"
time="2022-05-12T15:56:52-05:00" level=error msg="Unable to determine test cluster version: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable"
... truncated ...
{
    "image": "quay.io/komish/simple-demo-operator-private:0.0.5",
    "passed": false,
    "certification_hash": "741e581a7b6ae6198a865baa1af24731",
    "test_library": {
        "name": "github.com/redhat-openshift-ecosystem/openshift-preflight",
        "version": "1.1.1",
        "commit": "a4cd06de61d3f795fae58bb73841ae94ade08705"
    },
    "results": {
        "passed": [],
        "failed": [],
        "errors": [
            {
                "name": "ScorecardOlmSuiteCheck",
                "elapsed_time": 0,
                "description": "Operator-sdk scorecard OLM Test Suite Check",
                "help": "There was a fatal error while running operator-sdk scorecard tests. Please see the preflight log for details. If necessary, set logging to be more verbose."
            },
            {
                "name": "DeployableByOLM",
                "elapsed_time": 0,
                "description": "Checking if the operator could be deployed by OLM",
                "help": "It is required that your operator could be deployed by OLM"
            },
            {
                "name": "ValidateOperatorBundle",
                "elapsed_time": 0,
                "description": "Validating Bundle image that checks if it can validate the content and format of the operator bundle",
                "help": "Check ValidateOperatorBundle encountered an error. Please review the preflight.log file for more information."
            },
            {
                "name": "ScorecardBasicSpecCheck",
                "elapsed_time": 0,
                "description": "Check to make sure that all CRs have a spec block.",
                "help": "There was a fatal error while running operator-sdk scorecard tests. Please see the preflight log for details. If necessary, set logging to be more verbose."
            }
        ]
    }
}

The versions I used, for reference (all pulled from the Releases page):
(issue610) $ ./preflight-1.1.0 -v
preflight version 1.1.0 <commit: f1628fcf489aed88711d6cac95c3f096217f9feb>

(issue610) $ ./preflight-1.1.1 -v
preflight version 1.1.1 <commit: a4cd06de61d3f795fae58bb73841ae94ade08705>

(issue610) $ ./preflight-1.2.0 -v
preflight version 1.2.0 <commit: 8374f324bfb1c54a5e2698b048d5f9d671813936>

And finally - from what I can see, the current state of the pipeline appears to reference 1.2.0:
https://github.com/redhat-openshift-ecosystem/operator-pipelines/blob/main/ansible/roles/operator-pipeline/templates/openshift/tasks/preflight.yml#L10
    - name: base_image
      default: quay.io/redhat-isv/preflight-test@sha256:fba6919bfb5c647877453dd948b1e7d3394c4573482e3776ae9a85abd70f912e

$ skopeo --override-os linux inspect docker://quay.io/opdev/preflight:1.2.0 | jq .Digest
"sha256:fba6919bfb5c647877453dd948b1e7d3394c4573482e3776ae9a85abd70f912e"

Thanks Jose for the great details! I took a quick look at this today and it failed but I'm not sure its not something I'm doing. I'll have to wait until tomorrow until I can get into it. I'll post a response by COB tomorrow.


issue with import for Babel

The dot notation naming of the module gives errors when I want to import them using Babel.
Do you have any hints or tips on resolving this?

Sorry about that.
Not really, I have not used Babel, do you still have issues with this?

I use the videogular with webpack and babel-loader and do not have any issues. Can you show the log?

Closing, please, reopen if you still have issues.


feat(comment): allow to choose between 3 comment strategies

This PR allows to choose between 3 different comment strategies:

create (to always create a comment, this is the default strategy and the one used before)
create-if-not-exists (to create a comment only if its content doesn't already exist on the associated PR)
delete-and-create (to delete comment(s) if the content is similar and create the comment again

The check / deletion is only done to comment with similar Author Login :ok_hand:
Examples:
Create Strategy:
jx-gitops pr comment -s create -c ':star:TEST COMMENT:star:'
commented on pull request #22 on repository xxx/test-comment

Create If Not Exists Strategy
jx-gitops pr comment -s create-if-not-exists -c ':star:TEST COMMENT:star:'
Similar comment already exists on pull request #22 on repository xxx/test-comment

Delete and Create Strategy
jx-gitops pr comment -s delete-and-create -c ':star:TEST COMMENT:star:'
deleted comment with ID 12345 on pull request #22 on repository xxx/test-comment
commented on pull request #22 on repository xxx/test-comment

No defined Strategies (using the default one create)
jx-gitops pr comment -c ':star:TEST COMMENT:star:'
commented on pull request #22 on repository xxx/test-comment

#############
Tests are passing locally
go test -v ./pkg/cmd/pr/comment
=== RUN   TestPullRequestCommentStrategies
=== RUN   TestPullRequestCommentStrategies/CreateCommentStrategy-Existing-DifferentUser
commented on pull request #123 on repository myorg/myrepo
    comment_test.go:162: pull request #123, has comments: comment for CreateCommentStrategy
=== RUN   TestPullRequestCommentStrategies/CreateIfNotExistsCommentStrategy-Existing-DifferentUser
commented on pull request #123 on repository myorg/myrepo
    comment_test.go:162: pull request #123, has comments: comment for CreateIfNotExistsCommentStrategy
=== RUN   TestPullRequestCommentStrategies/DeleteAndCreateCommentStrategy-Existing-DifferentUser
commented on pull request #123 on repository myorg/myrepo
    comment_test.go:162: pull request #123, has comments: comment for DeleteAndCreateCommentStrategy
=== RUN   TestPullRequestCommentStrategies/CreateCommentStrategy-Existing-SimilarUser
commented on pull request #123 on repository myorg/myrepo
    comment_test.go:162: pull request #123, has comments: comment for CreateCommentStrategy
=== RUN   TestPullRequestCommentStrategies/CreateCommentStrategy-NotExisting-SimilarUser
commented on pull request #123 on repository myorg/myrepo
    comment_test.go:162: pull request #123, has comments: new-comment for CreateCommentStrategy
=== RUN   TestPullRequestCommentStrategies/CreateIfNotExistsCommentStrategy-Existing-SimilarUser
Similar comment already exists on pull request #123 on repository myorg/myrepo
    comment_test.go:162: pull request #123, has comments: existing-comment for CreateIfNotExistsCommentStrategy
=== RUN   TestPullRequestCommentStrategies/CreateIfNotExistsCommentStrategy-NotExisting-SimilarUser
commented on pull request #123 on repository myorg/myrepo
    comment_test.go:162: pull request #123, has comments: new-comment for CreateIfNotExistsCommentStrategy
=== RUN   TestPullRequestCommentStrategies/DeleteAndCreateCommentStrategy-Existing-SimilarUser
deleted comment with ID 0 on pull request #123 on repository myorg/myrepo
commented on pull request #123 on repository myorg/myrepo
    comment_test.go:162: pull request #123, has comments: comment for DeleteAndCreateCommentStrategy
=== RUN   TestPullRequestCommentStrategies/DeleteAndCreateCommentStrategy-NotExisting-SimilarUser
commented on pull request #123 on repository myorg/myrepo
    comment_test.go:162: pull request #123, has comments: comment for DeleteAndCreateCommentStrategy
--- PASS: TestPullRequestCommentStrategies (0.00s)
    --- PASS: TestPullRequestCommentStrategies/CreateCommentStrategy-Existing-DifferentUser (0.00s)
    --- PASS: TestPullRequestCommentStrategies/CreateIfNotExistsCommentStrategy-Existing-DifferentUser (0.00s)
    --- PASS: TestPullRequestCommentStrategies/DeleteAndCreateCommentStrategy-Existing-DifferentUser (0.00s)
    --- PASS: TestPullRequestCommentStrategies/CreateCommentStrategy-Existing-SimilarUser (0.00s)
    --- PASS: TestPullRequestCommentStrategies/CreateCommentStrategy-NotExisting-SimilarUser (0.00s)
    --- PASS: TestPullRequestCommentStrategies/CreateIfNotExistsCommentStrategy-Existing-SimilarUser (0.00s)
    --- PASS: TestPullRequestCommentStrategies/CreateIfNotExistsCommentStrategy-NotExisting-SimilarUser (0.00s)
    --- PASS: TestPullRequestCommentStrategies/DeleteAndCreateCommentStrategy-Existing-SimilarUser (0.00s)
    --- PASS: TestPullRequestCommentStrategies/DeleteAndCreateCommentStrategy-NotExisting-SimilarUser (0.00s)
PASS
ok      github.com/jenkins-x-plugins/jx-gitops/pkg/cmd/pr/comment       0.030s

/ok-to-test

can we get a "comment and hide previous" option similar how to Atlantis handles PR comments?

@joshuasimon-taulia didn't see your comment before but indeed you can if you want open a new PR with a new option to hide the previous comment :ok_hand:


pick item from a dropdown

I stole this code from someone elses repository and thought this might be useful for other people as well.
This dropdown picker can come in handy in lots of places like the browser or an IDE.
I am not sure whether this might conflict with other commands?
Maybe a prefix like "dropdown" would be helpful, so that you could say "dropdown pick three" to select the third item in the dropdown.
But that makes the command less useful because it needs more time to say it.
What do you guys think about this? Also, this is my first PR.

I use something quite similar.
https://github.com/nriley/knausj_talon/blob/b23a2b87/misc/pick.talon
I like the idea of ‘pick up’ and will probably steal it!
The main differences with mine are (a) waiting a little while between selecting and pressing enter (probably not worth doing if this works well for most people) and (b) having “pick” alone just select the item under the cursor.  I use “pick” as my command for “enter” pretty much everywhere and find it very rarely conflicts.

I'm personally slightly inclined against adding this feature to knausj for the following combination of reasons:

It is a 'shortcut' rather than adding new functionality. The current competition for 'pick three' is 'go down three times enter'. I have an inclination toward letting people make their own idiosyncratic shortcuts out of the existing functions, particularly if they're just a short snippet of .talon. IMO we have a problem of command discoverability in knausj already (partially addressed by cheat sheets) so should have a slight bias against new global commands, particularly for this kind of small improvement.
It globally takes over the nice command prefix 'pick' which people might want to use for other things.
'pick up' is dangerous the same way enter is if misrecognised. Imagine getting misrecognised as 'pick up three' in the terminal (execute a random history command), or 'pick three' in a web form (form submitted).

None of these things is definitive in itself, but they add up for me.
It's a cool idea though. I'd be more inclined to put this kind of thing in to a list of 'ideas'/inspiration somewhere so people could get their idiosyncratic creative process started. This would probably be a new talon.wiki page.
Anyway, just my two cents. Happy to be talked out of the above :).

I don't feel strongly given how simple the command definition is.
However, having had this command in place for 11 months I can't think of any case where it's accidentally triggered. But I realize my accent/dictation environment varies!  (Before "pick" I used "choose" which got misinterpreted as "two" quite a lot.)
Perhaps we can talk about it more tomorrow…

This does seem useful. I'm not opposed to having commands for very generally useful short sequences of actions like this. I do worry about possible misrecognition, though; pick is super short. Maybe dropdown pick or dropdown?

Another idea we had in the knausj grooming session was to implement this as an action. That way, if we have a smarter way of selecting from a list (e.g., using accessibility, adding delays or accounting for an off-by-one error) we can easily override in a particular context.

Sounds like other folks are in favour of this, so let's put it in. As for the prefix, here are some options:

:grinning: pick three and pick up three.
:tada: dropdown pick three and dropdown pick up three
:heart: dropdown three and dropdown up three
:rocket: pick list three and pick list up three
:confused: Something else.

My favourite is option #4. Let's try voting by reacting to this comment with the emoji next to the option. You can of course write a comment if you have another suggestion :). We can then get this added in with the preferred option in a few weeks.
As for the action idea, I'd be happy for that to be included. If not it could be easily added later I think.

Even split, though I guess Nikolai probably likes pick  as well.
What do you think about using dropdown as the prefix instead Nikolai (I could change my preference to that)? Also the idea of implementing this as an action so people can re-implement it using accessibility APIs if they want to?

I've altered this to use "dropdown" instead of "pick". If someone wants to make an action for this we can do it in another PR. Merging.


Visual mode isn’t working 😢

I’m pretty stumped on this one.
The plugin is installed and working fine in normal mode but not in visual mode. In visual mode the selected text is simply removed on typing the first c, presumably because it’s hitting the “change” command in visual mode even though it shouldn’t because I hit the leader key first.
I even checked :vmap and everything looks right.
x  ,cu           <Plug>NERDCommenterUncomment
x  ,cb           <Plug>NERDCommenterAlignBoth
x  ,cl           <Plug>NERDCommenterAlignLeft
x  ,cy           <Plug>NERDCommenterYank
x  ,cs           <Plug>NERDCommenterSexy
x  ,ci           <Plug>NERDCommenterInvert
x  ,cn           <Plug>NERDCommenterNested
x  ,cm           <Plug>NERDCommenterMinimal
x  ,c<Space>     <Plug>NERDCommenterToggle
x  ,cc           <Plug>NERDCommenterComment
v  gx            <Plug>NetrwBrowseXVis
x  <Plug>NERDCommenterUncomment * :call NERDComment("x", "Uncomment")<CR>
x  <Plug>NERDCommenterAlignBoth * :call NERDComment("x", "AlignBoth")<CR>
x  <Plug>NERDCommenterAlignLeft * :call NERDComment("x", "AlignLeft")<CR>
x  <Plug>NERDCommenterYank * :call NERDComment("x", "Yank")<CR>
x  <Plug>NERDCommenterSexy * :call NERDComment("x", "Sexy")<CR>
x  <Plug>NERDCommenterInvert * :call NERDComment("x", "Invert")<CR>
x  <Plug>NERDCommenterNested * :call NERDComment("x", "Nested")<CR>
x  <Plug>NERDCommenterMinimal * :call NERDComment("x", "Minimal")<CR>
x  <Plug>NERDCommenterToggle * :call NERDComment("x", "Toggle")<CR>
x  <Plug>NERDCommenterComment * :call NERDComment("x", "Comment")<CR>
v  <Plug>NetrwBrowseXVis * :<C-U>call netrw#BrowseXVis()<CR>

I removed my entire .vimrc and got it working with the default leader \ but if I just add the one line to set the leader I get the same problem. Being that it’s pretty common to bind , to the leader key I’m quite surprised I’m the only person seeing this issue though :/

Are you able to use your , leader with two-character mappings in visual mode that trigger other plugins? It does seem like it shouldn't matter what the leader is...that's kind of the point of having a leader key and not just hard coding a character.

I'm having the same problem using GVIm 8

@carlos-cabgj Same question to you. I can't duplicate this issue yet...

@mikeal You should keep holding the  key in visual mode, When you press the c .

@mikeal You should keep holding the key in visual mode, When you press the c .

That works for me. Thx a lot!!!


MSAA x16 broken on AMD GPU

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
Setting the AA value to MSAA x16 causes glitching.
To Reproduce
Set the AA value to MSAA x16
Expected behavior
Glitching
Screenshots
https://gyazo.com/75c2321e6b3ed1bd2370daed421f8384
Environment (please complete the following information):

Win 10
RuneLite version: 1.5.4
Launcher version: 1.6.0
GPU is an RX580 Nitro+ 8GB

Changing the setting from your GPU manufacturer's software to "Enhance application setting" does not work in this case like how it does with Nvidia cards.

RX480 Nitro+ 8GB and experiencing the same issue.

Before driver update, all of the AA options used to work out of the box, apart from the MSAA x16 one, after driver update i also started to have that weird wireframe stuff and the AA options were broken altogether. However, I found out that if you manually set your Anti-aliasing mode to "Override Application settings" from Radeon Settings, then put the Anti-aliasing level to 8xEQ, you'll be able to set the in-game AA to x8, setting it to x16 will cause the same glitching as before driver update.
I haven't tried to see what different Anti-aliasing levels do and how they change the behavior as 8xEQ sort of works fine enough for me.

As far as I'm aware (correct me if I'm wrong), no AMD GPUs support MSAA x16. The client should query what MSAA modes are supported.


MicroProfile 7.0 Release Training

I have volunteered for release training on 7.0 to lead future releases, here is the place to track related efforts.
Ref: TODO

Hi @emecas, as stated in the mail, I'll settle some internal tasks on the release and then ping you here for a catch up.

@pedanticdev welcome!!! you are assigned to this issue now


chore(package): bump dependencies

coverage: 97.68%. remained the same
when pulling a782c0ef2edf4229ef731785da6a719c115b5c33 on bump-deps
into 0d21a5748b4af0fcb2ab4f5276c471560fde8e5b on master.


cargo-flamegraph: init at 0.1.13

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I tested this on NixOS before rebasing.

@GrahamcOfBorg build cargo-flamegraph

Looks good, going to run the builder again for darwin
@GrahamcOfBorg build cargo-flamegraph


Face-tag with German Umlaut

I've created some face tags with German Umlauts like in Urgroßvater.
I wrote the tags with XnViewMP. There, they are displayed correct:

In Pigallery2 the tag is shown as "UrgroÃvater".
I'm running PiGallery2 with mariaDB as docker containers on a Pi running ubuntu 22.04.1
What might cause the strange coding?

My guess is that you have a character set mismatch between your DB and XnViewMP.

Would adding this parameter --character-set-server=utf8mb4 to the start command in my docker-compose.yaml solve the problem?
  command: sh -c 'bin/wait-for <IP_ADDRESS>:${MYSQL_PGDATABASEPort} -- --Server-Database-mysqlhost=<IP_ADDRESS> --Server-Database-mysql-username=${MYSQL_PGUSER} --Server-Database-mysqlpassword="${MYSQL_PGPASSWORD}" --Server-Database-mysql-database="${MYSQL_PGDATABASE}"'

I'm not sure. I'm only using sqlite.
I guess is the problem is actually with your exif tool using the wring characterset. I would try using and other one to see if that shows the characters properly.

Using lightroom for tagging and sqlite as DB, I have no issues having special characters


Add missing paren in mlCompared

Was just flicking through the docs of interest, and spotted what I assume (possibly incorrectly) is a typo.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Good catch, thanks!


Convert templates and examples from json to yaml

I find YAML a lot more (human-)user-friendly and less error prone to edit than json. Just to point that out, the json example in README had one syntax error (one extra comma)

/assign @balajismaniam

/retest

One additional benefit with yaml is that it allows embedding comments

ping @balajismaniam!

Rebased. Ping @balajismaniam, this has been open without review for over 4 months now


Output AzeritePowerWeights String in azerite-traits/

Is your feature request related to a problem? Please describe.
After running azerite-traits/ I need an AzeritePowerWeights string to put into the in-game addon.
https://wow.curseforge.com/projects/azeritepowerweights
Describe the solution you'd like
A new file in the azerite-traits/ directory that has Uldir Composite and Single Target weights for LotV and DA sims.
Additional context
First pass is almost done, need to add support for the Alliance versions of traits.

Will now create https://github.com/WarcraftPriests/bfa-shadow-priest/blob/master/azerite-traits/AzeritePowerWeights_DA.md for DA/LotV after each sim for azerite traits is ran


completion module path with re-export (#19351)

Fixes #19351

@mhegazy
did i missing some syntax?
review need

I think the only thing I'm seeing missing here is dynamic imports expressions. I filed an issue if you want to tackle it here or in another PR: #19367

i'm going to take a look

It's very helpful to me

@DanielRosenwasser seems ci is broken...


stackingsats: allow more than one config, also complementing a base config

enables usage of e.g.

a base config aside one or more alternative complementing ones
different stacking amounts
different accounts (such as friends and family or business and private)
test config aside a productive one

simply via 2nd cli parameter for stacksats.sh and more config files in /mnt/hdd/app-data/stacking-sats-kraken that look the same as .env but must be named .env-param2 when calling e.g. stacksats.sh "stack" "param2"

Thanks :) Will be part of v1.8.0rc3 for testing.


Error position

I've hand-written a pretty large baseline migration, and then started debugging it by creating a fresh database and running postgres-migrations repeatedly. One problem I've run into is that crucial error details are lost inside this library, here:
https://github.com/ThomWright/postgres-migrations/blob/25e737982e1c6070fecccfc4855889b71e237a3b/src/run-migration.js#L49-L61
Sometimes PostgreSQL spews out messages like syntax error at or near ")", in a file full of functions, triggers, constraints, arrays, etc. The only way to find the cause for an error like that is to know the position, which is contained inside the err returned from the driver.
The easiest solution would probably be to extend the error message with Position: ${err.position}, but there may be some value is passing through the other fields too. An even better solution would be to print the problematic line and its surroundings, with the exact position pointed out with a ^, but that's a lot of extra effort for a small QoL improvement, so that's just an idea for the future.

Hi, thanks for the issue. I reckon the solution of putting the err.position in our error message is something I'd accept a PR for.
Probably the main reason I don't do much with the errors is that I don't know what errors might be thrown. I assume not every error will have a position property. However, if it does it seems worth emitting that.
What I tend to do in your position is to look at the PostgreSQL logs, mainly because I don't trust JS libraries (including mine!) to give the full picture.

Similar problem on my first attempts to use this library. I get pumped and write a big migration, then gotta debug it. But the error message reads: error at or near "." ... and there are 76 "." in the migration!
cause: Error: An error occurred running 'prepare'. Rolled back this migration. No further migrations were run. Reason: syntax error at or near "."
Can we at least add line indicator?

I don't think Postgres gives that information (correct me if I'm wrong). We can only report what we get back from Postgres.
Again, I'm happy to accept a PR for this.


[BUG] Get-AksHciConfig and Install-AksHci cannot find cloudconfig in the remote host

Describe the bug
No cloudconfig file can be found
To Reproduce
Not sure. I am deploying in Azure in a 2 node HCI cluster. I initialized the nodes and used Set-AksHciConfig, no difference
Expected behavior
Install-AksHciConfig and Get-AksHciConfig working
Screenshots
PS C:\Users\labadmin> set-akshciconfig
[10/20/2020 02:12:42] Creating configuration
 - Removing old configuration...
 - New configuration has been saved

PS C:\Users\labadmin> get-akshciconfig
[10/20/2020 02:07:27] Checking for configuration
 - Merging Windows Admin Center configuration
 - Loading Windows Admin Center configuration from 'C:\Users\labadmin\Windows Admin Center\aks-hci-settings.json'...
 - Processing configuration...
[10/20/2020 02:07:27] Creating configuration
 - Removing old configuration...
 - New configuration has been saved
[10/20/2020 02:07:27] Reading configuration
[10/20/2020 02:07:28] Validating configuration
[10/20/2020 02:07:28] Confirming Configuration
[10/20/2020 02:07:28] Determining deployment type
 - This is a multi-node deployment using failover cluster: AZSHCI
[10/20/2020 02:07:28] Verifying cloudconfig access file
 - Retrieving access file from WIN-MUCC37Q1OIO
Copy-Item : Cannot find path '\\WIN-MUCC37Q1OIO\C$\Users\labadmin\.wssd\cloudconfig' because it does not exist.
At C:\Program Files\WindowsPowerShell\Modules\Moc\0.2.8\Common.psm1:946 char:5
+     Copy-Item -Path $remotePath -Destination $destination
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (\\WIN-MUCC37Q1O...ssd\cloudconfig:String) [Copy-Item], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.CopyItemCommand
Unable to locate a valid cloudconfig access file.
At C:\Program Files\WindowsPowerShell\Modules\Moc\0.2.8\Common.psm1:1437 char:5
+     throw "Unable to locate a valid cloudconfig access file."
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Unable to locat...ig access file.:String) [], RuntimeException
    + FullyQualifiedErrorId : Unable to locate a valid cloudconfig access file.

Environment (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]
AKS-HCI Version (i.e. Public Preview 1)
Kubernetes Version (i.e. 1.18.6)

Additional context
Add any other context about the problem here.
Collect log files

From a PowerShell Admin window run Collect-AksHciLogs
If you are running into issues with the deployment wizard in Windows Admin Center, run
Get-SMEUILogs.ps1 from the machine hosting Windows Admin Center.”

PS C:\Users\labadmin> get-akshcilogs
[10/20/2020 02:15:02] Checking for configuration
 - Merging Windows Admin Center configuration
 - Loading Windows Admin Center configuration from 'C:\Users\labadmin\Windows Admin Center\aks-hci-settings.json'...
 - Processing configuration...
[10/20/2020 02:15:02] Creating configuration
 - Removing old configuration...
 - New configuration has been saved
[10/20/2020 02:15:02] Reading configuration
[10/20/2020 02:15:02] Validating configuration
[10/20/2020 02:15:02] Confirming Configuration
[10/20/2020 02:15:02] Determining deployment type
 - This is a multi-node deployment using failover cluster: AZSHCI
[10/20/2020 02:15:02] Verifying cloudconfig access file
 - Retrieving access file from WIN-PSIERIALC37
Copy-Item : Cannot find path '\\WIN-PSIERIALC37\C$\Users\labadmin\.wssd\cloudconfig' because it does not exist.
At C:\Program Files\WindowsPowerShell\Modules\AksHci\0.2.8\Common.psm1:946 char:5
+     Copy-Item -Path $remotePath -Destination $destination
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (\\WIN-PSIERIALC...ssd\cloudconfig:String) [Copy-Item], ItemNotFoundException
    + FullyQualifiedErrorId : PathNotFound,Microsoft.PowerShell.Commands.CopyItemCommand
Unable to locate a valid cloudconfig access file.
At C:\Program Files\WindowsPowerShell\Modules\AksHci\0.2.8\Common.psm1:1437 char:5
+     throw "Unable to locate a valid cloudconfig access file."
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Unable to locat...ig access file.:String) [], RuntimeException
    + FullyQualifiedErrorId : Unable to locate a valid cloudconfig access file.

PS C:\Users\labadmin> get-module -name akshci
ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     0.2.8      AksHci                              {Get-AksHciCluster, Get-AksHciCredential, Get-AksHciKubernetesVersion, Get-AksHciLogs...}

Not sure where to find Get-SMEUILogs.ps1, it is not in the preview package I downloaded

Are you deploying this on Azure VMs?

@abhilashaagarwala Yes

Any idea what can I troubleshoot or try? Thanks!

You mentioned that you are attempting to install AksHci, but the script is indicating that you have Windows Admin Center configuration present (which is a sign that Windows Admin Center was used to deploy AksHci on this cluster/node previously):
- Loading Windows Admin Center configuration from 'C:\Users\labadmin\Windows Admin Center\aks-hci-settings.json'...
Did your previous Windows Admin Center deployment complete successfully? I am wondering if you had a failed deployment through WAC and some aspects of that deployment are still present and have not been cleaned up yet.
We are improving the powershell "Uninstall-AksHci" cmdlet to be more resilient to this type of issue/state moving forward. For now, you may need to perform some manual cleanup on the cluster/nodes if you are planning to switch to using the Powershell for Day0 deployment of AksHci.

Hey @nwoodmsft thanks for your answer! Yes, first I tried WAC, but after 2h it didnt work. After retrying with WAC a couple of times I switched over to pwsh. Would you have a link on how to "perform some manual cleanup on the cluster/nodes" to switch to pwsh from WAC?

I renamed C:\users\labadmin\Windows Admin Center\aks-hci-settings.json and issued set-akshciconfig in each node, and install-akshci in one of the nodes.
There was an error when removing the cloudagent directories, not sure whether this is going to affect the process...
- Removing cloudagent directory on WIN-PSIERIALC37...
Access is denied
    + CategoryInfo          : NotSpecified: (:) [Remove-Item], Win32Exception
    + FullyQualifiedErrorId : System.ComponentModel.Win32Exception,Microsoft.PowerShell.Commands.RemoveItemCommand
    + PSComputerName        : WIN-PSIERIALC37

I think we can close this one, since deleting/renaming C:\users\labadmin\Windows Admin Center\aks-hci-settings.json made the trick :-)


Selective Access via jdlms library

Story
As Grid Operator
I want to be able to only retrieve certain values from a buffer with a "Profile generic"
So that I can be able to retrieve only the requested data from the meter
(Basic principle : It is not allowed to retrieve data from the meter whithout authorization.)

Scenario: Using selective Access to only retrieve certain values from a buffer with a "Profile generic"
When we use selective access to only retrieve certain values from a buffer with
a "Profile generic" instance we use:

1) a range descriptor where we narrow down the results returned based on a from/to
value  for the clock :
This functionality WORKING WELL

2) We should also be able to use an array for selected_values where we can narrow
down on the captured objects returned :
This functionality NOT YET WORKING)

Tasks:

[ ] Define acceptance criteria
[ ] Ask Fraunhofer Institute to implement Selective Acces correctly in jdlms library
[ ] Install new version of the jdlms library
[ ] Implement required changes to correctly use the new version of the jdlms library
[ ] Implement acceptance tests
[ ] Test

@elhachhouchi can we close this item? We already use selective access where applicable.