Can't run any prompt in playground without openai key

Have you changed the OpenAI key to compulsory in playground recently?
I can't run any prompt without entering openai key!
If it's for the new canvas function, there should be a way to bypass or disable it.
There should be a way for people who only use azure/aws/google/claude to use LangSmith.

You pick the model for a given prompt. It may be defaulting to openai in your case

You pick the model for a given prompt. It may be defaulting to openai in your case

I know, I've been using bedrock for a long while, but last week the openai key become compulsory when I use bedrock. Please see this pic


How to do this on unraid?

Hey, i am using the jellyfin docker image from linuxserver. I got this plugin working after i ran the following into the console, but if the container gets updated it will forget these changes. How to solve this?
chown jellyfin:jellyfin /usr/share/jellyfin/web/index.html
chmod 666 /usr/share/jellyfin/web/index.html

Late reply, but ran into this recently, and this is what I came up with. Note that I'm using hotio/jellyfin, not linuxserver, but the steps I took should work pretty similarly, probably just gotta adjust the naming for the jellyfin service, and of course adjust the paths to reflect how your setup looks like
echo "oneshot" > /srv/apps/jellyfin/set-perms-jellyscrub/init-jellyscrub/type

cat <<EOF > /srv/apps/jellyfin/set-perms-jellyscrub/init-jellyscrub/run
#!/command/with-contenv bash
echo "Setting owner/group on index.html to ${PUID}:${PGID} so Jellyscrub can inject its script"
chown -v ${PUID}:${PGID} /usr/share/jellyfin/web/index.html
EOF

echo "/etc/s6-overlay/s6-rc.d/init-jellyscrub/run" > /srv/apps/jellyfin/set-perms-jellyscrub/init-jellyscrub/up

touch /srv/apps/jellyfin/set-perms-jellyscrub/dependency

And in my docker-compose.yml I have these extra volumes:
    - /srv/apps/jellyfin/set-perms-jellyscrub/init-jellyscrub:/etc/s6-overlay/s6-rc.d/init-jellyscrub
    - /srv/apps/jellyfin/set-perms-jellyscrub/dependency:/etc/s6-overlay/s6-rc.d/service-jellyfin/dependencies.d/init-jellyscrub

This creates an extra initialization step taken by the jellyfin container during startup, that runs before jellyfin itself starts, and sets the user/group ownership for the index.html file to what the container was started with.
And since I'm using volumes to add my modifications to the container, it will keep working even if there's a new image.

Thanks @Lochnair your solution worked for me.
I am in the same situation as dandud100, on Unraid with a linuxserver Jellyfin image.
However I still needed to execute chmod +x on the run file, and correct it contents since ${PUID}:${PGID} was missing. Your cat <<EOF > script didn't fully copy that over.
Linuxserver also didn't have a service-jellyfin path, I used svc-jellyfin instead for the docker path:
Path: /set-perms-jellyscrub/dependency
/etc/s6-overlay/s6-rc.d/svc-jellyfin/dependencies.d/init-jellyscrub

Thanks @nezuky, I've updated my comment.
I've changed cat <<EOF > to cat << 'EOF' >, which should stop the shell from doing variable substitution and keep the content intact.
Also added a note about the different path in the linuxserver image

This can be used as well for those running linuxserver/jellyfin image:
https://docs.linuxserver.io/general/container-customization/#custom-scripts
Create a script and mount it to the container and that script will be executed on startup


feat: add option to skip syncing DOPPLER_* keys for doppler provider

Describe the bug
Currently syncing every secret from a doppler config will include meta secrets DOPPLER_PROJECT, DOPPLER_ENVIRONMENT and DOPPLER_CONFIG by default, I don't want these extra secrets injected into my k8s deployment.
apiVersion: v1
data:
  API_TOKEN: ZGVtbw==
  DOPPLER_CONFIG: ZGVtbw==
  DOPPLER_ENVIRONMENT: ZGVtbw==
  DOPPLER_PROJECT: ZGVtbw==
kind: Secret
metadata:
  name: credential
type: Opaque

To Reproduce
Steps to reproduce the behavior:

external-secrets v0.9.1
follow the Fetch all tutorial
check the data of generated k8s secret

Expected behavior
No extra meta secrets (DOPPLER_PROJECT, DOPPLER_ENVIRONMENT and DOPPLER_CONFIG)，just the secrets I added in doppler config.

These values are always returned by the API. When you use Fetch all  as you have described above all keys are fetched, including the DOPPLER_ ones.
If you're only interested in a particular key then you can simply use the Fetch method.

If you're only interested in a particular key then you can simply use the Fetch method.

Yes. I know I can use the Fetch method to specify the keys I want to include, but there are a bunch of keys I want to use and that would be pretty verbose.
I think I can't use Negative Lookahead in regex filter to exclude there DOPPLER_ ones, as regex in golang doesn't support it.
Is there any other method for me to exlude these meta DOPPLER_* keys?

You can use templates with KeysAndValues filter. On the template you can do a simple match to skip if the key starts with DOPPLER

You can use templates with KeysAndValues filter. On the template you can do a simple match to skip if the key starts with DOPPLER

Thanks. I will check it out.

It's weird that now the generated secret becomes something like this:
data:
  DOPPLER_CONFIG:
  DOPPLER_ENVIRONMENT:
  DOPPLER_PROJECT:
  A:
  A_:
  B:
  B_:

Shouldn't the following template skip the DOPPLER_ keys giving that the mergePolicy is Replace?
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: demo-secret
  namespace: default
spec:
  dataFrom:
  - find:
      conversionStrategy: Default
      decodingStrategy: None
      name:
        regexp: .*
  refreshInterval: 1h
  secretStoreRef:
    kind: SecretStore
    name: doppler-demo-secret
  target:
    creationPolicy: Owner
    deletionPolicy: Delete
    name: demo-secret
    template:
      engineVersion: v2
      mergePolicy: Replace
      templateFrom:
      - literal: |
          {{- range $key, $value := . }}
          {{- if not (eq $key "DOPPLER_CONFIG" "DOPPLER_ENVIRONMENT" "DOPPLER_PROJECT") }}
          {{ $key }}_: {{ $value }}
          {{- end }}
          {{- end }}
        target: Data

It's weird that now the generated secret becomes something like this:
data:
  DOPPLER_CONFIG:
  DOPPLER_ENVIRONMENT:
  DOPPLER_PROJECT:
  A:
  A_:
  B:
  B_:

Shouldn't the following template skip the DOPPLER_ keys giving that the mergePolicy is Replace?
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: demo-secret
  namespace: default
spec:
  dataFrom:
  - find:
      conversionStrategy: Default
      decodingStrategy: None
      name:
        regexp: .*
  refreshInterval: 1h
  secretStoreRef:
    kind: SecretStore
    name: doppler-demo-secret
  target:
    creationPolicy: Owner
    deletionPolicy: Delete
    name: demo-secret
    template:
      engineVersion: v2
      mergePolicy: Replace
      templateFrom:
      - literal: |
          {{- range $key, $value := . }}
          {{- if not (eq $key "DOPPLER_CONFIG" "DOPPLER_ENVIRONMENT" "DOPPLER_PROJECT") }}
          {{ $key }}_: {{ $value }}
          {{- end }}
          {{- end }}
        target: Data

@gusfcarvalho hello, do you have any clue about the mentioned behavior?

I think these keys haven't been cleaned up (though they should have been). Please delete the secret and let ESO recreate it. It shouldn't come up with the undesired keys. The template literal looks good to me.
apiVersion: external-secrets.io/v1beta1
kind: ClusterSecretStore
metadata:
  name: fake-template-01
spec:
  provider:
    fake:
      data:
      - key: "DOPPLER_CONFIG"
        value: "..."
      - key: "DOPPLER_ENVIRONMENT"
        value: "..."
      - key: "frontend"
        value: "$$$frontend$$$"
      - key: "backend"
        value: "$$$backend$$$"
---
apiVersion: external-secrets.io/v1beta1
kind: ExternalSecret
metadata:
  name: fake-template-01
spec:
  refreshInterval: "10s"
  secretStoreRef:
    name: fake-template-01
    kind: ClusterSecretStore
  target:
    name: "fake-template-01"
    template:
      engineVersion: v2
      templateFrom:
      - target: Data
        literal: |
          {{- range $key, $value := . }}
          {{- if not (eq $key "DOPPLER_CONFIG" "DOPPLER_ENVIRONMENT" "DOPPLER_PROJECT") }}
          {{ $key }}_: {{ $value }}
          {{- end }}
          {{- end }}

  data:
  - secretKey: backend
    remoteRef:
      key: backend
  - secretKey: frontend
    remoteRef:
      key: frontend
  - secretKey: DOPPLER_CONFIG
    remoteRef:
      key: DOPPLER_CONFIG
  - secretKey: DOPPLER_ENVIRONMENT
    remoteRef:
      key: DOPPLER_ENVIRONMENT
```yaml

I think these keys haven't been cleaned up (though they should have been). Please delete the secret and let ESO recreate it. It shouldn't come up with the undesired keys. The template literal looks good to me.

Thanks. I deleted the existing secret and it is recreated correctly. Do you think we should create a new issue for the cleanup problem?

Create one in #2550. Closing this one out, feel free to reopen if anything is missing.

Create one in #2550. Closing this one out, feel free to reopen if anything is missing.

@moolen Maybe we can treat this issue as an enhancement and keep it open? Although using template filter can achieve the same outcome, it could be more user friendly if we implement an option in the SecretStore provider level to explicitly disable syncing meta keys from doppler.

:+1: to the enhancement on the SecretStore, could you please create a separate issue for it (feel free to mention this one).
That way one doesn't need to dig through the whole history of its discover :)

Sure. Then I will revert the title of this issue to the original one.


Remove outdated restriction regarding docs nesting

Motivation
@endiliey shipped a feature to allow doc nesting. This PR removes the outdated restriction in siteConfig regarding docs nesting.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
NA. Doc change.
Related PRs
#705

@endiliey On a side note, I have the following questions:

Does nested docs dirs work for custom doc path?
Could we try to convert the existing docs dir to nested? So as to dogfood the feature 😄

How about writing a script to migrate the current and versioned docs to nested?

Split each filename by hyphen.
Take the first word and create a dir.
Shift filenames with the same first word into the dir.
Rename the filename and strip off the dir.

I can try doing that tomorrow 👍

@yangshun appreciate it if you could help me on that. I'll be out of reach of my laptop in the next few hours for a week. No wifi & laptop at hospital 😢

No problem, I'll take care of it. Rest well! Take care 😄

On a side note, note that we have to basically replace all markdown linking
Example:
[Installation guide](getting-started-installation.md).

to
[Installation guide](getting-started/installation.md).

I thought moving admin to its own folder under docs would gives the least friction way to have this running on Docusaurus -- which I definitely think we should.  I do not mind moving our docs to their own folder as well.
Or #whynotboth 😄

Split each filename by hyphen.
Take the first word and create a dir.

@yangshun I don't think this works for getting-started though, which we would want as the directory name. Not getting 😄


Document API Product

Description:
Document API Product

Reviewed and updated
https://apim.docs.wso2.com/en/latest/Learn/DesignAPI/CreateAPIProduct/api-product-overview/
https://apim.docs.wso2.com/en/latest/Learn/DesignAPI/CreateAPIProduct/create-api-product/


Error when no general list ID is set

We used the plugin for a long time without setting a general list ID in the grav config. Instead we added a key to the form. After an update the plugin started throwing errors that the default list ID was given the value 'null'. So the list ID given via the form gets ignored and the list ID in the grav config isn't there, hence throwing an error.

Thanks for filing @JvanderCeelen. Closing this as fixed by #22.


Can't dump hashes of usernames containing spaces

For instance, when using --ntds
If username is "User Name", I get the following line:
domain.local\User
that's it, nothing else :)

Thanks for the bug report! Fixed in #153


Broken RubyDoc link.

If still valid, rubydoc info link in readme.

Thanks @stefanondisponibile - I've just fixed it.


Updated table space for meta table, with db2 z/OS standard values

Hi,
The pull request contains changes in meta data table. Encoding is changed to EBCDIC, the standard for zOS, and the tablespace are updated with more standard values.
Hope to reach the 4.0 release!
Christine

Hi Christine,
Can you provide a smooth migration path for existing users (#1117) that migrates the encoding for them?
Best regards,
Axel

Hi
I have looked at updateMetaDataTable.sql for db2zos. I don´t think "call ADMIN_CMD" is something we can use. I have changed job and have no test environment anymore.  But I know someone who can test and change the new version, but we need a day or two. We will also look at a migration path, but I´m not sure if we need it. Maybe I will remove the encoding from the create table statement, and instead use the encoding scheme of the database.
Christine

Yes, I think simply using the encoding of the DB is probably the best option.
I simply copied the regular DB2 update file, so no worries about call ADMIN_CMD. All I care about is that the test passes :-)

@cteig Did you make progress on this?

I have an appointment with someone with a test-environment tomorrow.
The upgrade was not so easy as we first assumed. It has to work with the db2 z/os version 9 and newer
It is not possible to delete columns in version 9 :-(
Christine

No worries Christine, if it doesn't work we'll simply instruct users to drop the table and recreate it with Flyway.baseline()

Hi
The issue is now handed over to a former colleague. You will get a pull request for this change, but I can´t say when. Mayby for a later release.
Christine

Obsolete. Closing.


POWERLEVEL9K_DIR_BACKGROUND not affecting prompt

Describe Your Issue
What is happening?
Changing POWERLEVEL9K_DIR_BACKGROUND in .zshrc not reflected after source ~/.zshrc
I searched issues, did not find any similar, and therefore assume I am doing something wrong.
Have you tried to debug or fix it?
Just started customizing this morning after doing a git pull. I'm assuming I'm doing something wrong here. Read the docs. Changing the aws segment color works fine.
What I have in .zshrc now:
POWERLEVEL9K_PROMPT_ON_NEWLINE=true
POWERLEVEL9K_LEFT_PROMPT_ELEMENTS=(context dir aws vcs)
POWERLEVEL9K_DIR_BACKGROUND='white'
POWERLEVEL9K_AWS_FOREGROUND='yellow'
The aws segment is yellow on red but the dir segment is black on blue. I toggled the settings a few times to confirm this behavior.
Environment Information
This information will help us understand your configuration.

What version of ZSH are you using? You can use zsh --version to see this.
zsh 5.7.1 (x86_64-apple-darwin18.2.0)

Do you use a ZSH framework (e.g., Oh-My-ZSH, Antigen)?
Oh-My-Zsh

How did you install P9k (cloning the repo, by tarball, a package from your OS, etc.,)?
Clone repo into ~/.oh-my-zsh/custom/themes/powerlevel9k

What version of P9k are you using?
Master as of 16 Mar 2020

Which terminal emulator do you use?
iTerm2

Issues with Fonts & Icons
Probably not a font issue.
===== Font debugging =====
You are using iTerm2 with Font DroidSansMonoForPowerline 11
Your font settings seem to be all right. If you still have issues,
it is more likely to be a font issue than a Powerlevel9k related one.

dir has states, so you need to set POWERLEVEL9K_DIR_${STATE}_BACKGROUND instead of POWERLEVEL9K_DIR_${STATE}_BACKGROUND. Accepted values of ${STATE} are: DEFAULT, HOME, HOME_SUBFOLDER, NOT_WRITABLE, ETC.

Yep, my bad here. Thanks for the tip. Got it working like so:
POWERLEVEL9K_DIR_HOME_FOREGROUND='white'
POWERLEVEL9K_DIR_HOME_BACKGROUND='019'
POWERLEVEL9K_DIR_HOME_SUBFOLDER_FOREGROUND='white'
POWERLEVEL9K_DIR_HOME_SUBFOLDER_BACKGROUND='019'
POWERLEVEL9K_AWS_FOREGROUND='000'
POWERLEVEL9K_AWS_BACKGROUND='142'

Note that you'll still get the original colors when your current directory is outside of $HOME. To get the same colors everywhere you need to override colors for all 5 states.


Replace dummy text

The following pages currently contain dummy text that should be replaced soon:

[ ] Main page, all columns in the About section

[ ] Find a purpose for the third column

[x] All mod detail pages

[x] Astus
[x] Ingens
[x] Undercraft

[x] All project detail pages

[x] New XKit

resolved


fix: add explicit array types

Despite the typo in the typings, strict TypeScript configurations would complain about generic Array declarations. Additionally, a standard Prettier configuration will modify icon.width to type number in selection.json.
Relates to #9 and #13.

It looks pretty good. Thank you for your contribution. 🎉


CUDA_VISIBLE_DEVICES mistaken as CUDA_VISIBLE-DEVICES in TFNode.py

0059-Amend-the-CUDA_VISIBLE-DEVICES-to-CUDA_VISIBLE_DEVIC.txt

Thanks for the find.


Fix - 1:1 Submit expense - The receiving end of the IOU should not be asked to fill out information if the scan failed

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/51574
PROPOSAL: https://github.com/Expensify/App/issues/51574#issuecomment-2442777973
Tests

Start the Submit expense flow in a 1:1 conversation with a user you have access to

Select the scan option

Upload a picture that will fail the scan process

Wait for the scan to fail

Log in as the other account

Navigate to the IOU that failed the scan

Verify the receiver is not asked to fill out the missing information no RBR is shown

On a workspace set tag as required field and allow approval workflow as the admin as the approver

From an employee side of the workspace create an expense without setting tag field

From an employee side verify that RBR is shown and tag required violation text is shown but no RBR shown from the admin side (b/c the admin cannot edit the request)

Now from the admin side approve the expense

Verify that now the employee (now can't edit the expense) will not see the RBR and violation but the admin can see the RBR

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Same as above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Bump for a review @getusha

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@FitseTLT noticed a RBR on the report preview. it disappears when you click on it.
https://github.com/user-attachments/assets/612ae0fc-48c1-469e-919a-f601556edf16

Yeah @getusha this because the report data will not be available in onyx to determine whether the current user can edit it or not but when you open it the data will be loaded. mounty agreed to live with this edge case inconsistency here 👍

@FitseTLT could you please add a unit test? thanks

@FitseTLT could you please add a unit test? thanks

Added

@FitseTLT we've got conflicts

@FitseTLT can you please fix the conflicts? Thanks!

@VickyStash I am confused with the lint errors I am having

Apart from the lint and ts errors coming from main I have fixed all the current pr errors. @getusha


[Request] Theme selector

Could be very useful have a theme selector for change colors, etc.

@miracle091 its done for new release last night. To change the theme just hover a hexagonal shape on top.

@AndikaTanpaH  Seem ok to me.
This can be closed and thanks. :smiley:


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/channel-wg-leads
/assign knative-sandbox/channel-wg-leads
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/hack 47ac3b0...ced8ce7:
  > ced8ce7 Fix bash version check to allow v4 or later (# 84)
bumping knative.dev/reconciler-test 816dbd1...04ea7dd:
  > 04ea7dd Enhance eventshub receiver with drop events response headers. (# 242)
  > 8cff9c9 Update actions (# 244)
  > 979a592 Update community files (# 230)
  > 70581e1 upgrade to latest dependencies (# 236)
bumping knative.dev/eventing a34aaa0...7af98bb:
  > 7af98bb Format go code (# 5815)
  > e05267a Update actions (# 5816)
  > 50b2f32 upgrade to latest dependencies (# 5825)
bumping knative.dev/pkg a34efd6...ba2b2b1:
  > ba2b2b1 upgrade to latest dependencies (# 2319)
  > caa95fe Bump assorted dependencies (# 2318)

/lgtm
/approve


[branch-2.1] Picks "opt Remove some restrictions on schema change on table that has auto-increment column #40280"

picks https://github.com/apache/doris/pull/40280

run buildall


Clean up definition of pg_hba rules

This makes the manifest slightly easier to read.

Thank you @blackknight36 for your contribution. Could you please take a look at the travis failures.
---> syntax:manifests Could not parse for environment *root*: Syntax error at end of input (file: /home/travis/build/puppetlabs/puppetlabs-postgresql/manifests/server/config.pp)

Thank you @blackknight36 for your contribution. Could you please take a look at the travis failures.
---> syntax:manifests Could not parse for environment *root*: Syntax error at end of input (file: /home/travis/build/puppetlabs/puppetlabs-postgresql/manifests/server/config.pp)

I found the problem.  Builds should work now.

Codecov Report

Merging #1214 (0299aa5) into main (08e3a51) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1214   +/-   ##
=======================================
  Coverage   65.81%   65.81%
=======================================
  Files          14       14
  Lines         351      351
=======================================
  Hits          231      231
  Misses        120      120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 711a729...0299aa5. Read the comment docs.

Thank you @blackknight36 for submitting the PR.

Thank you @blackknight36 for submitting the PR.


Cleanout metadata of old python3.3 and django<1.10

Forgot to bump the version which made our internal CI fail, in the process of fixing that I cleaned out the old version gruft.

@kairichard FYI

@kairichard then the docs need updating too
https://github.com/PaesslerAG/django-act-as-auth/blob/ee4b4eb6cb14f568aa1594e8c3893a7a335b5fe1/docs/supported-versions.rst#django-versions-support-philosophy

Just because Django itself doesn't support a version doesn't mean that the project will drop support for that. However, support for these Django/Python versions can be dropped any time without prior notice. Usually this would be because of a new Django relase that would require bending over backwards to support older versions.

For (most) OSS libs done after this, it was decided to simply stick to the official supported django versions, but not for this one


Java and Asha are being removed from buddyArray :(

Fix pls!

resolved by Kinley (moved out of topMatches function)


Temporary Fix: Set denite compatible commit

If anyone tries to install Jarvis today it will not work due to issue #20.
This PR temporarily fixes that, specifying a compatible Denite commit (the last commit from 2.0 version).

I appreciate the effort to do a temporary fix. The (hopefully) permanent one ended up being pretty simple once I looked at it, so I went ahead and merged that into master. Thanks again for the work and bug report!

Actually, I'm seeing several issues now working with Denite. I'm going to merge this in until we can get the correct solution.


Update master.yml

Use updated build flag and goreleaser action

@guineveresaenger @t0yv0 should this PR go forward, or should I close it?


task(fuzzing): separate fuzzing crate/feature

This is @dkuehr 's fuzzer slightly refactored to make it less intrusive for the rest of the code.

core fuzzing functionality in a separate feature-gated crate
macros for optionally fuzzing data
migrated fuzzing implemented by Daniel from openmina/badnode.

@dkuehr I think I ported the most of the functionality from this commit. Please check if there is something missing.


Store images in asset store

This gives the AssetStore the ability to store Docker images, which I think covers task 1347.
I had a look at using the standard nginx Docker image as a base for the data images, but couldn't get it to work quickly. The current setup is also not exactly exotic, just Ubuntu + nginx with WebDAV enabled, which is a configuration I'm familiar with, so I decided to go with that for now. The whole point of a Docker container is of course that it encapsulates the stuff inside, so this can always be changed later if we're so inclined.

Converted back to draft, I think I can make this more reviewable...

Converted back to draft, I think I can make this more reviewable...

I tried to make it a bit smaller, it's still a fair amount of code but I think it could work. I guess a single image would be enough just to test storing images, but I have the rest now so we might as well I guess. Feel free to have a go at reviewing :).

I tried to make it a bit smaller, it's still a fair amount of code but I think it could work. I guess a single image would be enough just to test storing images, but I have the rest now so we might as well I guess. Feel free to have a go at reviewing :).

I've dockumented the docker files and while I was at it some of the stuff that goes in them, and I've refactored app.py into a libmahiru.py and app.py and cleaned it up a bit. Also, the new libmahiru.py now has a global constant and a global variable! Better?

I've dockumented the docker files and while I was at it some of the stuff that goes in them, and I've refactored app.py into a libmahiru.py and app.py and cleaned it up a bit. Also, the new libmahiru.py now has a global constant and a global variable! Better?

@bakhshir Can I ask you to have a look at the new test_asset_store.py? I decided to remove the Docker-based tests (they'll be back later when I implement execution) and just have a unit test here, as that seems more appropriate.

@bakhshir Can I ask you to have a look at the new test_asset_store.py? I decided to remove the Docker-based tests (they'll be back later when I implement execution) and just have a unit test here, as that seems more appropriate.


Adding system for dynamically loading React components

Current Behavior

As discussed in the Meeting on 16th September, and a Go Plugin system demonstrated by Dev Kalra, we need a system to identify react-plugins which can dynamically load React Components on Need basis or Import Basis.
Desired Behavior

It will be used for Go plugin system demonstrated for MeshMap

Implementation

Resources to get started with this issue
Mockups

Acceptance Tests

I would like to assign this issue to myself.

@dhruv0000 @kushthedude Will you invite @tripathyprateek to participate in the notes that you were taking on this effort?

@utkarsh-pro you're at-bat!

This system has been implemented and is being documented for release in v0.5.0 - https://docs.google.com/document/d/1E7NWFy5ZVEPX2W892mfVG-3yku1uci2KRDU42tNRZwA/edit#

@leecalcote is there something else too that needs to get done here?

@leecalcote is there something else too that needs to get done here?

@utkarsh-pro, you're right. No, given the implementation and documentation. We're good to close this in preparation for it's release in v0.5.0.

@utkarsh-pro, you're right. No, given the implementation and documentation. We're good to close this in preparation for it's release in v0.5.0.


nc_def_var_chunking() currently ignores attempts to set chunking or filters on a scalar var - but should return error

In HDF5 chunking cannot be used on scalar vars. This results in an error on the H5Dcreate() call. So of course we don't do that.
But currently, the user can call nc_def_var_chunking() and set chunking on a scalar variable. The call ends up being ignored, due to another bug which I am just fixing WRT compact storage. So currently the user may call nc_def_var_chunking() on a scalar var, and get no error. The var, however, will be stored contiguous. nc_inq_var_chunking() will give inconsistent answers as to the storage of the var, calling it chunked for a while, but then properly identifying it as contiguous when the file is reopened.
To be consistent with the rest of the API, the nc_def_var_chunking() call should return NC_EINVAL for attempts to set chunking on a scalar variable. This will eliminate the inconsistent answers from nc_inq_var_chunking().
Since my current PR is big enough, and involves compact storage, I'll fix this as a separate PR.

Working with @DennisHeimbigner, we concluded that efforts to set filters on scalar vars should also return NC_EINVAL. That was merged to master with Dennis' recent merge of multiple filters.
What remains is to return NC_EINVAL for attempts to set chunking on a scalar var. I have a PR ready  with this fix, once the current PR gets merged.


[$250] Distance - Recent destination list shows more than 5 destinations

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.6-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4709538
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Go to staging.new.expensify.com
Go to FAB > Submit expense > Distance.
Click Start point.
Select 6 different waypoints.
Note that the recent destination list shows more than 5 destinations.

Expected Result:
The recent destination list will show at most 5 destinations (production behavior).
Actual Result:
The recent destination list shows more than 5 destinations on staging.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/da56a621-1caf-43b3-9f9a-cba3e673bb0d

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018ea8c6fb29aecd8f
Upwork Job ID:<PHONE_NUMBER>870180805
Last Price Increase: 2024-07-11

Issue OwnerCurrent Issue Owner: @Ollyws

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #collect project.

Production

Proposal
Please re-state the problem that we are trying to solve in this issue.
Recent destination list shows more than 5 destinations
What is the root cause of that problem?
CONST.RECENT_WAYPOINTS_NUMBER value is '20'. And we sliced the array using the value.
https://github.com/Expensify/App/blob/19922f5d45caa01a95bee0a89c4d8664ac493b43/src/pages/iou/request/step/IOURequestStepWaypoint.tsx#L257-L259
What changes do you think we should make in order to solve the problem?
We should change CONST.RECENT_WAYPOINTS_NUMBER = 20 to CONST.RECENT_WAYPOINTS_NUMBER = 5 in CONST file.
What alternative solutions did you explore? (Optional)

Demoting from blocker

This is not a bug we intentionally increased the number of displayed places to 20. We may need to update regression test steps somewhere though. cc @neil-marcellini

assigning @neil-marcellini to the issue based on @arosiclair's comment

@arosiclair, the Save will be pushed down and we need to scroll, to see the scroll button, I don't think thats expected. The button should always be fixed.

I think that's correct, but we did have a long discussion about it and I don't remember where we landed tbh. I'll leave it up to @neil-marcellini if we should change it or not.

Ah yeah this stuff again 😅, let me find what we decided.
This is working as expected. I sort of explained it here and we decided to go with the following approach at the end of that thread.

There is one scrollable container on the page
We show 20 recent waypoints because that matches the number we store and allows us to filter them when searching
(I am open to feature requests to show a number of waypoints that will fit on the screen nicely, but use all 20 for searching. It's probably too complicated though and doesn't solve a real problem)
The user knows there is a save button because it appears before the recent waypoints load
As long as there are recent or suggested waypoints in the list, the save button isn't needed because selecting one will save it. We also don't need to hide the save button. That's added complexity without any benefit
The user can always scroll down to find the save button, or hit enter when typing in a value (I think)

@izarutskaya I wasn't able to find a regression test checking that there are only 5 recent waypoints. If so, please update it to 20.


Zen 3.8+ Incompatibility

Hi @cdgatenbee
Essentially any czi file generated with zen 3.8 or later (were now on version 3.11) wont work with VALIS (1.04 and 1.1.0. I get this error when I try and align images generated from zen 3.11:

UserWarning: java.lang.ArrayIndexOutOfBoundsException: arraycopy: last source index 2097834 out of bounds for byte[2097152]
  warnings.warn(warning_msg, warning_type)
Traceback (most recent call last):
  File "ImageReader.java", line 449, in loci.formats.ImageReader.openBytes
Exception: Java Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/local/src/valis/slide_io.py", line 1141, in tile2vips_threaded
    tile = self.slide2image(level, series, xywh=tuple(xywh), z=z, t=t)
  File "/usr/local/src/valis/slide_io.py", line 1267, in slide2image
    img = self._read_multichannel(rdr=rdr, xywh=xywh, z=z, t=t)
  File "/usr/local/src/valis/slide_io.py", line 1356, in _read_multichannel
    buffer = rdr.openBytes(idx, *xywh)
java.lang.java.lang.ArrayIndexOutOfBoundsException: java.lang.ArrayIndexOutOfBoundsException: arraycopy: last source index 2097834 out of bounds for byte[2097152]

I’m fairly convinced this thread is relating to the same issues, seemingly revolving around changes to rounding from the zen software.
I’ve uploaded to a google drive the same image generated in zen 3.7 which i've then converted to v3.10 to help with the diagnosis.

Thanks for bringing this to my attention @Justin-Krieg, and for sharing the images, which should be very helpful in debugging this. Also, thanks for the update on your other issue, I'm glad to hear it was a fairly straightforward fix, and I'll try to push the updated Dockerfile and Docker image soon.
Best,
-Chandler


refactor

I guess the comments with refactoring notes should be removed before merging.
And also remove/finish the tests, now they are just quick and dirty sketch.

done

Huge thanks :heart:


new activities layout

a div for every activity instead of a table row
two lines: activity name, project

implemented in c301ac0


[github actions] unable to solve process (bash) when downloading building cypress/factory

I have recently created a GitHub Action that periodically executes a set of smoke tests every 30m using Cypress. Since execution is frequent and the intention is to have fast feedback. We have created a custom workflow and a custom docker image based on cypress/factory image, instead of using cypress official action. We have effectively reduced the execution time of E2E tests (battery) from 12m down to 7m and the smoke test execution time from 8m to 3m.
 We are no where near reaching the limit of our GitHub quotas, or bandwidth limits. Yet, the smoke tests fail on average 4% of the times that they run. With the following error:
 > [2/9] RUN bash /opt/installScripts/node/install-node-version.sh 16.20.0:
...
31.79 + gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys A363A499291CBBC940DD62E41F10027AF002F8B0
31.79 gpg: keyserver receive failed: No keyserver available
31.79 + gpg --batch --keyserver keyserver.ubuntu.com --recv-keys A363A499291CBBC940DD62E41F10027AF002F8B0

------
cypress.dockerfile:1
--------------------
   1 | >>> ARG NODE_VERSION='16.20.0'
   2 |     ARG CYPRESS_VERSION='13.2.0'
   3 |
--------------------
ERROR: failed to solve: process "/bin/sh -c bash /opt/installScripts/node/install-node-version.sh ${APPLIED_FACTORY_DEFAULT_NODE_VERSION}" did not complete successfully: exit code: 2
Error: Process completed with exit code 1.

This does not appear to be a problem on our side (see workflow and dockerfile below). It appears to be related with the cypress/factory dockerfile itself.
If not... Are there any pointers you can provide to us in order to fix this issue?
Below you can find our Dockerfile and the relevant parts of our GitHub Workflow
      - name: 🐳 Build custom cypress docker image
        if: ${{ inputs.environ != 'local' }}
        run: docker build . --file ./cypress.dockerfile --tag test

      - name: 👨🔬 Run custom cypress image against live website
        if: ${{ inputs.environ != 'local' }}
        env:
          # 'smoke' | 'e2e' | 'all'
          TEST_KIND: ${{ inputs.kind }}
          WEBSITE_PASSWORD: ${{ secrets.WEBSITE_PASSWORD }}
          WEBSITE_URL: ${{ inputs.environ == 'prod' && 'https://example-website.com' || 'https://dev.example-website.com' }}
        run: |
          docker run \
            --env WEBSITE_PASSWORD=$WEBSITE_PASSWORD \
            --env WEBSITE_URL=$WEBSITE_URL \
            --env TEST_KIND=$TEST_KIND \
            test --browser electron

ARG NODE_VERSION='16.20.0'
ARG CYPRESS_VERSION='13.2.0'

FROM cypress/factory

WORKDIR /runner

RUN touch package.json
RUN echo "{ \"name\": \"tests\", \"dependencies\": {} }" >> package.json

# Install minimum required dependencies for cypress to run our tests
RUN npm i --save \
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>\
<EMAIL_ADDRESS>;

COPY .env.test .env.test
COPY cypress.config.js cypress.config.js

COPY mocks/ mocks/
COPY cypress/ cypress/

ENTRYPOINT ["npx", "cypress", "run"]

@jennifer-shehane I see this was removed from Cypress App Triage, will anyone still answer the question I made?
Perhaps I am not using cypress/factory as expected, I followed the instructions on the Docker Hub, but I might be missing something that causes this to fail arbitrarly.

Could be totally unrelated, but I got the same error. Maybe it's caused by Google rotating their signing keys:
https://support.google.com/chromebook/thread/257688390/the-repository-http-dl-google-com-linux-chrome-deb-stable-inrelease-is-not-signed?hl=en

@FranciscoKloganB Is this still an issue?

Hi, I am also facing the same issue, not seeing anything special in my docker file.
ARG CHROME_VERSION='120.0.6099.109-1'
ARG EDGE_VERSION='120.0.2210.91-1'
ARG FIREFOX_VERSION='107.0'

FROM cypress/factory:latest

WORKDIR /opt/app

RUN npm install -g pnpm

COPY package.json pnpm-lock.yaml ./

RUN pnpm install --frozen-lockfile

COPY . /opt/app

@FranciscoKloganB
Node.js 16 entered end-of-life on Sep 11, 2023.
Are you still seeing this issue with a supported version of Node.js
18.x, 20.x, 22.x
and using cypress/factory latest version?

The original problem, which was reported to be occurring about 4% of the time, is a network error:
31.79 + gpg --batch --keyserver hkps://keys.openpgp.org --recv-keys A363A499291CBBC940DD62E41F10027AF002F8B0
31.79 gpg: keyserver receive failed: No keyserver available

This is not something which the build process can do much about.
As noted in the previous post, this issue is regarding a version of Node.js which has reached end-of-life.

@jennifer-shehane @MikeMcC399 sorry for not replying earlier.
I can't tell if it's still happening, I left the company on February 5.

@FranciscoKloganB
Thank you and all the best for your future work!

Having the same issue as @FranciscoKloganB
I have tried to follow the steps in https://hub.docker.com/r/cypress/factory/ to create a custom image of cypress .
I keep getting this error
ERROR: failed to solve: process "/bin/sh -c bash /opt/installScripts/node/install-node-version.sh ${APPLIED_FACTORY_DEFAULT_NODE_VERSION}" did not complete successfully: exit code: 100

I have tried with the latest cypress/factory image, cypress/factory:4.0.2 still having the same issue
It's part of cypress's doc, so I find it odd it's not working based on their example. Any suggestions will be much appreciated. 🙌
This is my Dockerfile, copied from Cypress's doc
ARG CHROME_VERSION='107.0.5304.121-1'
ARG EDGE_VERSION='100.0.1185.29-1'
ARG FIREFOX_VERSION='107.0'

FROM cypress/factory

COPY . /opt/app
WORKDIR /opt/app
RUN npm install --save-dev cypress

I don't think that matters but I'm on Mac OS Version 14.5 (23F79) with Docker version 25.0.3, build 4debf41.

Oh... in my case it was our VPN that was causing the issue :O


Issue while runing test_train.small.gemma.infini.py

Did anyone face this issue?
warnings.warn(
Traceback (most recent call last):
File "test_train.small.gemma.infini.py", line 150, in
trainer.train()
File "/transformers/src/transformers/trainer.py", line 1885, in train
return inner_training_loop(
File "/transformers/src/transformers/trainer.py", line 2216, in _inner_training_loop
tr_loss_step = self.training_step(model, inputs)
File "/transformers/src/transformers/trainer.py", line 3238, in training_step
loss = self.compute_loss(model, inputs)
File "/transformers/src/transformers/trainer.py", line 3264, in compute_loss
outputs = model(**inputs)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1541, in _call_impl
return forward_call(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/accelerate/utils/operations.py", line 822, in forward
return model_forward(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/accelerate/utils/operations.py", line 810, in call
return convert_to_fp32(self.model_forward(*args, **kwargs))
File "/usr/local/lib/python3.8/dist-packages/torch/amp/autocast_mode.py", line 16, in decorate_autocast
return func(*args, **kwargs)
File "/jupyter_workspace/Raghav/InfiniTransformer/infini_gemma/modeling_infini_gemma.py", line 1613, in forward
outputs = self.model(
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1541, in _call_impl
return forward_call(*args, **kwargs)
File "/jupyter_workspace/Raghav/InfiniTransformer/infini_gemma/modeling_infini_gemma.py", line 1371, in forward
layer_outputs = self._gradient_checkpointing_func(
File "/usr/local/lib/python3.8/dist-packages/torch/_compile.py", line 24, in inner
return torch._dynamo.disable(fn, recursive)(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/_dynamo/eval_frame.py", line 451, in _fn
return fn(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/_dynamo/external_utils.py", line 36, in inner
return fn(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/utils/checkpoint.py", line 487, in checkpoint
return CheckpointFunction.apply(function, preserve, *args)
File "/usr/local/lib/python3.8/dist-packages/torch/autograd/function.py", line 598, in apply
return super().apply(*args, **kwargs)  # type: ignore[misc]
File "/usr/local/lib/python3.8/dist-packages/torch/utils/checkpoint.py", line 262, in forward
outputs = run_function(*args)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1541, in _call_impl
return forward_call(*args, **kwargs)
File "/jupyter_workspace/Raghav/InfiniTransformer/infini_gemma/modeling_infini_gemma.py", line 1056, in forward
_attended = self.self_attn(
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/torch/nn/modules/module.py", line 1541, in _call_impl
return forward_call(*args, **kwargs)
File "/jupyter_workspace/Raghav/InfiniTransformer/infini_gemma/modeling_infini_gemma.py", line 868, in forward
query_states, key_states = apply_rotary_pos_emb(
File "/jupyter_workspace/Raghav/InfiniTransformer/infini_gemma/modeling_infini_gemma.py", line 272, in apply_rotary_pos_emb
q_embed = (q * cos) + (rotate_half(q) * sin)
RuntimeError: The size of tensor a (65536) must match the size of tensor b (8192) at non-singleton dimension 2

Hey @Beomi ,any clarity on this?it would be deeply appreciated

嘿，对此有任何澄清吗？将不胜感激。我目前运行自定义（I 型方法）训练脚本以在数据集上进行预训练，但我也想使用 HF 框架进行微调，但出现此错误

+1


Surface audit log of changes to policy store

This is related to the policy store feature
https://github.com/step-security/harden-runner/issues/217.
As of now, any user in the org where the app is installed can view and modify policy, but we do not have audit log of changes.

main


Updated NNX MNIST tutorial

Updated NNX MNIST tutorial to use nnx.Optimizer and nnx.MultiMetric after #3782.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.86%. Comparing base (5d9fd9f) to head (d9f3ca7).
 Consider uploading reports for the commit 58d4bbe to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3810   +/-   ##
=======================================
  Coverage   60.86%   60.86%
=======================================
  Files         105      105
  Lines       13045    13058   +13
=======================================
+ Hits         7940     7948    +8
- Misses       5105     5110    +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add switch_backend to BaseMPS

I'd like to take a look, good opportunity to get acquainted with latest development on MPS class.


Robinhood API Integration - $0 fees

The API has been reversed engineered (https://github.com/sanko/Robinhood) but it does appear that Robinhood has plans to release an API (https://support.robinhood.com/hc/en-us/articles/210216823-Robinhood-API-Integrations)

Duplicate of #22.

Is this intergrateable?


child "sentinl" fails on kibana start

Sentinl and Kibana version

releases/download/tag-6.2.4/sentinl-v6.2.4.zip
version: '6.2.4',
branch: '6.x',
buildNum: 16627
kibana-oss:6.2.4

Issue description
Keys hook, channel, username in sentinl.settings.slack are displayed in logs as not allowed.
Key active is OK
Reproducing the issue step-by-step

   sentinl:
      settings:
        slack:
          active: true
          username: sentinl
          hook: 'https://hooks.slack.com/services/...'
          channel: '#alerts'

Expected results vs. actual results
Results:
Kibana doesn't start with ValidationError
Sample of data

➜  ~ kubectl logs kibana-7lgsm
{"type":"error","@timestamp":"2018-09-19T09:21:22Z","tags":["fatal"],"pid":1,"level":"fatal","error":{"message":"child \"sentinl\" fails because [child \"settings\" fails because [child \"slack\" fails because [\"username\" is not allowed, \"hook\" is not allowed, \"channel\" is not allowed]]]","name":"ValidationError","stack":"ValidationError: child \"sentinl\" fails because [child \"settings\" fails because [child \"slack\" fails because [\"username\" is not allowed, \"hook\" is not allowed, \"channel\" is not allowed]]]\n    at Object.exports.process (/usr/share/kibana/node_modules/joi/lib/errors.js:181:19)\n    at _validateWithOptions (/usr/share/kibana/node_modules/joi/lib/any.js:651:31)\n    at root.validate (/usr/share/kibana/node_modules/joi/lib/index.js:121:23)\n    at Config._commit (/usr/share/kibana/src/server/config/config.js:119:35)\n    at Config.set (/usr/share/kibana/src/server/config/config.js:89:10)\n    at Config.extendSchema (/usr/share/kibana/src/server/config/config.js:62:10)\n    at /usr/share/kibana/src/plugin_discovery/plugin_config/extend_config_service.js:22:12\n    at next (native)\n    at step (/usr/share/kibana/src/plugin_discovery/plugin_config/extend_config_service.js:45:191)\n    at /usr/share/kibana/src/plugin_discovery/plugin_config/extend_config_service.js:45:361"},"message":"child \"sentinl\" fails because [child \"settings\" fails because [child \"slack\" fails because [\"username\" is not allowed, \"hook\" is not allowed, \"channel\" is not allowed]]]"}
FATAL { ValidationError: child "sentinl" fails because [child "settings" fails because [child "slack" fails because ["username" is not allowed, "hook" is not allowed, "channel" is not allowed]]]
    at Object.exports.process (/usr/share/kibana/node_modules/joi/lib/errors.js:181:19)
    at _validateWithOptions (/usr/share/kibana/node_modules/joi/lib/any.js:651:31)
    at root.validate (/usr/share/kibana/node_modules/joi/lib/index.js:121:23)
    at Config._commit (/usr/share/kibana/src/server/config/config.js:119:35)
    at Config.set (/usr/share/kibana/src/server/config/config.js:89:10)
    at Config.extendSchema (/usr/share/kibana/src/server/config/config.js:62:10)
    at /usr/share/kibana/src/plugin_discovery/plugin_config/extend_config_service.js:22:12
    at next (native)
    at step (/usr/share/kibana/src/plugin_discovery/plugin_config/extend_config_service.js:45:191)
    at /usr/share/kibana/src/plugin_discovery/plugin_config/extend_config_service.js:45:361
  isJoi: true,
  name: 'ValidationError',
  details:
   [ { message: '"username" is not allowed',
       path: 'sentinl.settings.slack.username',
       type: 'object.allowUnknown',
       context: [Object] },
     { message: '"hook" is not allowed',
       path: 'sentinl.settings.slack.hook',
       type: 'object.allowUnknown',
       context: [Object] },
     { message: '"channel" is not allowed',
       path: 'sentinl.settings.slack.channel',
       type: 'object.allowUnknown',
       context: [Object] } ],

Additional details
Those options look like allowed in the index.js
https://github.com/sirensolutions/sentinl/blob/branch-6.2.x/index.js#L224

It is because we don't have those slack options anymore. The following options are available:
          slack:
            active: true,
            token: 2387882dj3kd3...,

Where token is from your Slack app or custom integration - xoxa, xoxp, or xoxb https://get.slack.help/hc/en-us/articles/215770388-Create-and-regenerate-API-tokens

Thank you for explaining. Have I missed some docs articles about this options?


[MM-48167] Only grab the last extension from a filename during Save As

Summary
When right-clicking a file and choosing Save As, if the filename had more than one ., the dialog would pick up each string seperated by a . and add it to the file extension list. Commonly reproducible when sharing macOS screenshots.
This PR ensures that we always get the actual file extension (ie. the last one) and use it for the dialog.
Ticket Link
https://mattermost.atlassian.net/browse/MM-48167
NONE

Cherry pick is scheduled.


Strange indentation around braces

Suppose you prefer to lay data declarations out like:
data Foo
    = Foo
    { foo :: Int
    , bar :: Char
    , baz :: Int
    } deriving (Eq, Ord)

Attempting to input the above in a Haskell buffer with only haskell-vim loaded gives the following:
data Foo
    = Foo
        { foo :: Int
            , bar :: Char
            , baz :: Int
        } deriving (Eq, Ord)

The braces consistently align themselves, but the commas are always indented exactly one time.
Any idea how I might configure haskell-vim to not do that, or what part of the code might be causing that indentation?

I think there are some problems with the current setup of indentkeys. I'm using less aggressive rules now. I had some issues with this myself, lets see how this works.

I'm still getting this after pulling the master branch on an. Output of indentation is:
data Foo a
    = Foo
        { foo :: Int
            , bar :: String
            , baz :: Bool
        }

I can't reproduce this anymore.


QuickCreate.SelectLookup selects first item in the lookup list

Using v9.0 branch on On-premise solution and also having problem selecting lookup value. It always selects the first item in the lookup list:  ie.  Lookup list is in this order:  Phone Call, Voicemail, Email, Other
xrmBrowser.QuickCreate.SelectLookup("caseorigincode", "Email");
xrmBrowser.QuickCreate.SelectLookup("caseorigincode", 2);

Result:  It always populates the field with "Phone Call" instead of "Email".  Any workarounds to this?  Thank you.
Originally posted by @tipsey in https://github.com/Microsoft/EasyRepro/issues/111#issuecomment-414360384

@tipsey - Splitting this into a separate issue from #111.
Thanks for posting, we'll review this behavior and get back to you as soon as we can.
Best Regards,
Tyler

@tipsey - Could you try this using the SetValue() method and see if it gives you better results in the interim?
           ` xrmBrowser.QuickCreate.SetValue(new OptionSet { Name = "caseorigincode", Value="Email" });`

This should at least allow you to select the correct value for your scenario. I'm reviewing the SelectLookup() method with the creator to understand the intent and whether we need to enhance that method or create a different one for Option Set scenarios.
Thanks again for your patience on this. If you have issues using the code example listed above, please let me know.
Best Regards,
Tyler

//Workaround Bug
xrmBrowser.QuickCreate.SetValue(new OptionSet { Name = "gendercode", Value = "Female" });
This worked on the Quick Create Contact form .  Thanks

In Debug mode it is working fine. but in direct run taking first value.


removed encryptor

I have removed the encryptor from the code. As the key is available in plain text next to the database files, it only complicates things the code and makes it 'slightly' more difficult to get the credentials.

fixed in 0.2.5 by enabling encryption


connect wires with clicks

Fixes #
Describe the changes you have made in this PR -
now we finally can connect 2 terminals with clicks 🎉

on pressing CTR we can connect with clicks

without pressing CTRL we can connect them with drag

Coverage remained the same at 84.087% when pulling 450e896e0520ae7f91cfcb0886dfc20595997cf3 on mahmodHammad:wire into bc89cead0b643d42eb6c38010b69c2bee52b4fa1 on CircuitVerse:master.

@satu0king  @tachyons  @nitin10s
review this, please!

@satu0king

How would people know this functionality of CTR?

Built in tutorial I think this is part of gsoc project  in tutorial  will be implementing how build small circuit  @nitin10s  I think

@nitin10s i think this sould be done during GSOC at the custome shortcut feature, or thr getting started tutorial

@satu0king  conflict resolved,  check again


pull request for e2e test at 01/27/2017 00:56:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


☂ Drop support for Shoots with K8s < 1.24

How to categorize this issue?

/kind cleanup
What would you like to be added:
Drop support for k8s versions < 1.24. Support from kubernetes for this version ended 6 months ago (28 Feb 2023). See https://endoflife.date/kubernetes.
Gardener:

[x] https://github.com/gardener/gardener: https://github.com/gardener/gardener/pull/8487

Use  autoscaling/v2 API version for HPA by default, available since 1.23. https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v126
Adapt featuregates which are added or removed in <=1.23, https://github.com/gardener/gardener/blob/6b24aa7733130b20ab8b1c5778577664992ddfcb/pkg/utils/validation/features/featuregates.go#L34
Adapt admissionplugins which are added or removed in <= 1.23, https://github.com/gardener/gardener/blob/e68789246869f2fbc89fe42675fbb00508f110e4/pkg/utils/validation/admissionplugins/admissionplugins.go#L46
Drop docker as supported CRI, https://github.com/gardener/gardener/blob/302b1a95266976e9960225a910de100ccef46afd/docs/usage/docker-shim-removal.md

Extensions:

[x] provider-alicloud: https://github.com/gardener/gardener-extension-provider-alicloud/pull/647
[x] provider-aws:  https://github.com/gardener/gardener-extension-provider-aws/pull/802
[x] provider-gcp: https://github.com/gardener/gardener-extension-provider-gcp/pull/648
[x] provider-azure: https://github.com/gardener/gardener-extension-provider-azure/pull/733
[x] provider-openstack: https://github.com/gardener/gardener-extension-provider-openstack/pull/670
[x] provider-vsphere: https://github.com/gardener/gardener-extension-provider-vsphere/pull/472
[x] provider-equinix-metal: https://github.com/gardener/gardener-extension-provider-equinix-metal/pull/291
[x] networking-calico: No change required.
[x] networking-cilium: No change required.
[x] extension-shoot-dns-service: https://github.com/gardener/gardener-extension-shoot-dns-service/pull/241
[x] extension-shoot-cert-service: No change required.
[x] extension-shoot-lakom-service: https://github.com/gardener/gardener-extension-shoot-lakom-service/pull/34
[x] extension-shoot-oidc-service: https://github.com/gardener/gardener-extension-shoot-oidc-service/pull/124
[x] extension-shoot-networking-filter: No change required.
[x] extension-shoot-networking-problemdetector: No change required.
[x] os-gardenlinux:  No change required.
[x] os-suse-chost: No change required.
[x] os-ubuntu:  No change required.
[x] os-coreos:  No change required.
[x] runtime-gvisor:  No change required.
[x] registry-cache: No change required.
...

K8s test infra:

[x] https://github.com/kubernetes/test-infra: https://github.com/kubernetes/test-infra/pull/30861

Why is this needed:
Drop support for quite old K8s versions.

/assign

/close all task completed.


GEOMESA-583 Adding customized encoding/decoding for index entries

Replacing IndexEntry encode/decode with IndexValueEncoder
Adding ability to specify attributes to encode in st index value to SimpleFeatureTypes, SftBuilder
Selecting index iterator in the case of a transform covered by the custom index value
Improving method profiling

Looks good, with good comments in new code added. The new files still have the license header dated from 2014 --- which I feel is appropriate as they were written in 2014.

Merged as commit 0dc16c2bc1d84ce142592c691d167034e1f0e541


[Enhancement] : Navbar mobile not Accessable fixed

Related Issue
Fixes:  #2127
Description
[Enhancement] : Navbar mobile not Accessable fixed

Type of PR

[x] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
Before
Screencast from 2024-06-25 08-58-53.webm
After
Screencast from 2024-06-25 14-11-32.webm
Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers and screenshots after making the changes.

This branch has conflicts that must be resolved
assets/css/MenuClick.css
assets/css/style.css


⚠ RbxVeri has degraded performance

In 4f88363, RbxVeri (https://verify.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 1195 ms

Resolved: RbxVeri performance has improved in 8a82487.


erlang_27: init 27.0; erlang_27-rc3: remove

Description of changes
Erlang 27 was officially released https://erlangforums.com/t/erlang-otp-27-0-released/3636
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[x] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

> nix-build -A erlang_27
/nix/store/70y7d02jfqh6nfpaydd6dkwbnpcm9mfx-erlang-27.0
> ./result/bin/erl
Erlang/OTP 27 [erts-15.0] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit]

Eshell V15.0 (press Ctrl+G to abort, type help(). for help)
1> io:format("hello world~n").
hello world
ok
2> q().
ok

[nix-shell:~/.cache/nixpkgs-review/rev-a251d7e27849119564bb72e3ab157128f4200add]$ erl
Erlang/OTP 27 [erts-15.0] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit]

Eshell V15.0 (press Ctrl+G to abort, type help(). for help)
1> io:format(~"hello world~n").
hello world
ok

The deprecation,
> nix-build -A erlang_27-rc3
error:
       … while evaluating a branch condition

         at /Users/chiroptical/programming/nix/nixpkgs/pkgs/top-level/aliases.nix:33:5:

           32|   removeDistribute = alias: with lib;
           33|     if isDerivation alias then
             |     ^
           34|       dontDistribute alias

       … while evaluating a branch condition

         at /Users/chiroptical/programming/nix/nixpkgs/pkgs/top-level/aliases.nix:26:5:

           25|   removeRecurseForDerivations = alias: with lib;
           26|     if alias.recurseForDerivations or false
             |     ^
           27|     then removeAttrs alias [ "recurseForDerivations" ]

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: erlang_27-rc3 has been removed in favor of erlang_27

Add a :+1: reaction to pull requests you find important.

@ofborg eval

@superherointj I think I got it now. Thanks for sticking with me. I learned a lot about tag management. I also learned it would have been a lot simpler if I did erlang_27: init 27-rc3 instead of what I did.

Result of nixpkgs-review pr 313173 run on x86_64-linux 1

1 package built:

erlang_27

Also looks like we didn't make an interpreters.erlangRxx alias this time?

Also looks like we didn't make an interpreters.erlangRxx alias this time?

That is deprecated. And to be removed.

It looks like erlang 27 depends on erlang 26 inside beam_packages.nix:
https://github.com/NixOS/nixpkgs/blob/86e62b8133807f3d12836348c6e29e8e4169bcbd/pkgs/top-level/beam-packages.nix#L49
Is this intentional?

It is actually. Ex_doc is built using Erlang 26 (because we don't yet have Erlang 27) and then used as an input to Erlang 27 to build the documentation.
Is it ideal? Maybe not, but it was an intentional decision. We could instead just get the ex_doc binary instead of building it. (FWIW, this could also be a misunderstanding on how Elixir packages are built). Happy to fix if you have suggestions!

As for the other comments, I am planning to put together a post on Erlang forums to gather some nix related feedback. But I think removing the Rx versions is less controversial than removing the javac  versions. Unsure though.

As for the other comments, I am planning to put together a post on Erlang forums to gather some nix related feedback. But I think removing the Rx versions is less controversial than removing the javac  versions. Unsure though.

No version was removed. Using _ for separating package name and version is standard in nixpkgs. The use of R was non-standard.

We could instead just get the ex_doc binary instead of building it. (FWIW, this could also be a misunderstanding on how Elixir packages are built).

I would vote for fetching their binary script. Using a different erlang version to get ex_doc means using erlang 27 requires fetching and storing two different erlangs. It's even more painful when using beam_minimal with a custom erlang version, as you have to build both 26 and 27.
The otp docs say you can use thse: https://github.com/elixir-lang/ex_doc/releases/tag/v0.34.1
If we don't want to do that, I'd advocate for disabling doc generation by default or for the smaller beam package sets.

Exactly.  I've previously had lots of fun trying to exclude them from builds.

Docs should be a different package output.

Docs should be a different package output.

All outputs are built together, so this won’t save any build time.

All outputs are built together, so this won’t save any build time.

Then, what is missing is the means of globally disabling the build of manuals?
I understand the need particularly for containers.

I've opened https://github.com/NixOS/nixpkgs/pull/313173

If we don't want to do that, I'd advocate for disabling doc generation by default or for the smaller beam package sets.

Seems fine to me. We can easily add an attribute to override at minimum.
As for ex_doc, the current nix package comes with the run time. This makes sense. If we just used the binary people would also have to pull in a run time to use it. However, I am not opposed to only bringing in the executable in the generic erlang builder because we are building the run time before needing ex_doc. However, then you are maintaining two ex_docs. Just my two cents.
https://github.com/NixOS/nixpkgs/pull/321367 <- this one gives us the new ex_doc for OTP 27.1 when it releases. Just let me know what you want to do with it.

I've opened #313173

This link leads back to this PR. Might need to update.


allow syncing between remotes

This is a feature request to allowing syncing between remotes.
Commandline allows this.
Any reason it isn't allowed in the app?

I would like to have this option 😊


Plugin does not work in sketch 83.1

Plugin does not work in sketch 83.1

Is the project abandoned?

何时能更新 目前无法是使用

请求立即更新

拜托

It's a shame that no one will maintain it.

There are currently no similar plugins

Hope to continue maintenance


Use new tide API for pyschism

Pending https://github.com/schism-dev/pyschism/issues/105 for tests to be successful.
https://github.com/schism-dev/pyschism/issues/107 is also good enough for now!

Codecov Report

Merging #160 (a3fde0e) into main (1cc7c12) will increase coverage by 0.00%.
The diff coverage is 50.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   64.84%   64.84%
=======================================
  Files          35       35
  Lines        3871     3869    -2
=======================================
- Hits         2510     2509    -1
+ Misses       1361     1360    -1

Files
Coverage Δ

coupledmodeldriver/generate/schism/base.py
83.13% <50.00%> (+0.39%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Create an enumeration of possible annotation uris

I am not sure whether we already have this, if not, we should have an equivalent of enum type to list annotation tags.
I adapted the js example I found online to demonstrate the concept.
var ANNOTATION = {
  DISPLAY : "tag:misd.isi.edu,2015:facets,
  DEFAULT: "tag:misd.isi.edu,2015:default
};

We should do the same for context.

We could roll this into the ermrestjs Annotation class or Annotations class. I would also rather see the keys be more explicit: TAG_MISD_ISI_EDU_2015_DEFAULT instead of just DEFAULT.

I'll edit the issue description at time.

I'm going to leave the original issue description just so we can capture the discussion here. Stepping back a bit, we have to ask "what code do we expect will make annotation lookups?" We actually would anticipate ermrestjs itself will consume most of the annotations and clients (such as Chaise) will use interfaces defined in the ERMrest object model rather than checking for annotations. So first decision is at this point we do not need to introduce an enumeration as a public api, but rather this is used only for internal operations within ermrestjs. Second question, "what then is the purpose of these enumerations?" It is to avoid rewriting (or copy-and-pasting) the same string in multiple places. So if we only use the annotation string in a lookup in exactly one location, we do not need a variable for it, just use the string in that one location. Third question, "where should we define these variables for the annotation name strings?" The ERMrest module is separated into multiple files (.js scripts) following a JavaScript pattern for writing such modules. Once such file is called utility.js which can be used for this purpose. Here's a simple rule to follow:

if you need to make a lookup based on a tag name only in one call site, simply use a string (e.g., "tag:isrd...")
if you have more than one use for the tag name string, but only in one script comprising ERMrest, then define it toward the top of the closure, and keep it local to that closure (e.g., var _tag_default = "tag:...default")
if you have more than one call site in more than one script, then define the variable in the utility.js script and add it to the module (e.g., module._tag_default = "tag:...default") and it may then be used by code in different ermrestjs scripts (e.g., referencing module._tag_default somewhere)

Note that this is not being added to the public interface. Code outside of the various ermrestjs scripts are not intended to use these variables. Hence we follow the underscore prefix convention _variableName, which by convention indicates that the variable should be considered private to the module and clients are at least warned not to use it.
Finally, there are a variety of more sophisticated ways of emulating enumerations in object oriented languages, that don't natively support enumerations, however we advocate keeping things simple. There is no reason to follow one of the more sophisticated patterns for enums here. Simply using a variable in place of the literal string is sufficient for our use here. If in the future we realize we do need this enum for the public api then we can revisit the topic.

Maybe the above comment belongs in a ermrestjs developer guide.

It's true that one purpose of creating this enumeration is to avoid rewriting and copy-pasting. However I can see other benefits to that:

To change each of the annotations, we just have to just change one variable that is defined in one place. We don't need to search for that string in several files.
We can easily figure out which annotations are currently supported application-wide. We don't need to search in different files to see if they have the annotations or not.

Based on these, I think it's useful to have a variable in the utilities.js file, like this:
module._annotations = {
     DISPLAY : "tag:misd.isi.edu,2015:facets",
     DEFAULT: "tag:misd.isi.edu,2015:default"
};

Going with what @RFSH mentioned, I think it could actually be defined as an angular constant on the module, which would then have it behave like any other angular service, factory, or provider. Meaning you could very easily inject the Annotations constant anywhere it's needed in angular.

@RFSH I agree with your second bullet, and that's good enough for me to be on board with your proposal.

@RFSH if you are doing this as @robes suggested, maybe we can now close this issue?

Actually, @shinyichen can you please review and close this issue?

@hongsudt I was waiting for the Column order issue to be closed and then work on this issue.


[WIP] Feature/reduce size of minified script

Work in progress.
Changes:

moved Item, Listener and ListenerManager to revealed module functions pattern (reduced Data Layer only scripts from 11kB to 9.2kB minified)
custom Lodash script built only with methods that are used by DL (reduced size of Lodash script only from 44kB to 23kB).
moved scripts from src/scripts directly to src
removed DataLayer prefix in every file (as we have more and more files it does not make sense to have that prefix in the filename)
tests folder renamed to __tests__ (similar to alloy)
extracted some general methods from ListenerManager into utils as a separate module functions

To be done:

add custom lodash script to gulp build task
refactor DataLayer (index.js) into revealed function pattern
extract more utils functions from DataLayer (index.js) into src/utils/...
merge with development changes
additional unit tests for utils methods

Future improvements (probably not part of this PR):

remove .min.js files from repo
improve gulp build

Final results:

final DL script got down in size from 55kB to 32kB (10kB gziped) which now consists of 23kB of Lodash and around 9kB of DataLayer scripts
a bit modified structure

The refactoring looks good to me. I added a few comments here and there.
I have some general questions:

custom lodash: is the file built manually? Is it automatically updated for new lodash versions?
what’s the advantage of renaming the test folder __tests__?

The refactoring looks good to me. I added a few comments here and there.
I have some general questions:

custom lodash: is the file built manually? Is it automatically updated for new lodash versions?
what’s the advantage of renaming the test folder __tests__?

Custom lodash is built using lodash-cli. I am in the process of adding additional lodash configuration in which you will be able to specify lodash methods that you use and that should be included in the final script. This configuration will be processed with gulp scripts task and there custom Lodash script will be generated accordingly.
I followed pattern that is used in other Adobe js heavy repos: alloy, reactor turbine. I think it moves it to the very "top" of your list of folders as well as it might help excluding this folder from build / lint / others. There is no strong reason for that rename. It is very optional and opinionated so if you don't agree we can easily revert that change.

Thx for the explanations.

we will then need to add a new lodash method to this config, right? Would the build fail if we forget? Otherwise that could lead to nasty bugs.
that's fine, we can keep it as is.


Make circulation schedule chart interactive

Make circulation chart interactive. It allows to see exact data points, zoom in-and-out etc.

Renamed everything
Added fallback SVG for distribution chart
Squashed
Picked SVG rewards chart from https://github.com/oasisprotocol/docs/pull/158
Picked CSV downloads from https://github.com/oasisprotocol/docs/pull/158

Before
After

Hm the chart on the right doesn't seem entirely correct, e.g. for core contributors there should be a cliff at T+12 (value should be zero before) but here it looks like there is something between T+9 and T+12 which was not the case.

for core contributors there should be a cliff at T+12 (value should be zero before) but here it looks like there is something between T+9 and T+12 which was not the case.

Yeah, this is a consequence of how Plotly.js interpolates data points. By default, it uses linear interpolation.
Let me see if we can have something like in the old chart.

Replaced monthly offsets with short date strings
Improved tooltip
Added dark theme
Added empty months to reduce linear interpolation and match old chart https://github.com/oasisprotocol/docs/pull/117/commits/3ef7f725d6ca1270a112155103c9e00cb5e7cf45
Reverted rewards chart changes
Updated changelog

I'll squash now


请大佬建立个telegram群组

qq不支持linux，telegram方便些。。。

检查弗朗茨。它有一个AppImage

WhatsApp
WeChat
Telegram
...

https://meetfranz.com

build a telegram channel is very easy, but most of Chinese people cannot connect it without VPN.
Mr. probono is the founder of AppImage and maintainer. It have a offical IRC channel.
建一个TG频道很容易，但是大多数国人连不上，原因你懂得。
Mr. probono 就是AppImage项目的创始人和主要作者，你可以在IRC的官方#appimage频道找到需要的人。
你可以建立一个频道，然后拉人试试看，如果有一部分人愿意加入，我们会过去的。

建好了，搜一下@gamuxzh就可以进入

TG上不去，科学也不行。

@Andy2Clyde  先到QQ群274328087

Already in the QQ group.
发送自 Outlookhttp://aka.ms/weboutlook

发件人: 小鸡<EMAIL_ADDRESS>发送时间: 2017年12月5日 6:34
收件人: Gamuxorg/AppImage-CN
抄送: Andy2Clyde; Mention
主题: Re: [Gamuxorg/AppImage-CN] 请大佬建立个telegram群组 (#3)
@Andy2Clydehttps://github.com/andy2clyde 先到QQ群274328087
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Gamuxorg/AppImage-CN/issues/3#issuecomment-349209868, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVXTbNNLg0K6b3ye1fItDfYGMoiqqe0Bks5s9OQEgaJpZM4QzOFO.

@probonopd hello, we have registed an BAIDU account for you. please check your email<EMAIL_ADDRESS>to receive

Thank you @shouhuanxiaoji I am a bit busy right now

@probonopd
It doesn't matter. You're busy first. In addition, we find it a little wasteful to build a forum alone. Is it possible to incorporate bbs.appimage.cn into the official forum? Is it possible to open a Chinese plate in the official forum?

You would like a Chinese sub-forum on https://discourse.appimage.org/? That would be no problem, just let me know and I will open it.

@probonopd yes,then we will redirect bbs.appimage.cn to the chinese sub-forum of discourse.appimage.org.

https://discourse.appimage.org/c/chinese

@probonopd How did IPFS study? We have added two servers more, Beijing and Lithuania.


decode string with leading 0 as string

When setting parameters, if the value starts with a leading 0 and is
not a float, consider it to be a string.
e.g.:
00: string
0.1: float
0: int
#492
Signed-off-by: bryanl<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build 840

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 4.567%

Totals

Change from base Build 839:
0.0%

Covered Lines:
19

Relevant Lines:
416

💛  - Coveralls


Update Composer dependencies (2021-04-20-00-08)

Visual regression test passed!
View the visual regression test report


Analog/Digital audio sync for HD Radio can be improved

The initial implementation for HD Radio with the analog fallback is "pretty good" all things considered, and there are channels where the analog and digital audio are simply not synced up (WWMX Baltimore, for example), but the rough cut at making this work can be improved upon.
The analog and digital DSPs generate a different number of audio packets given the same I/Q sample input. It should be mathematically possible to track this better and discard some audio samples from the digital signal if the analog signal is "ahead". I don't think there is any way for the reverse scenario to work, the digital signal being "ahead" of the analog signal based on how this needs to work.
I've added a setting that will allow the user to disable the analog fallback feature completely via https://github.com/djp952/pvr.rtlradio/commit/cc4357ffe1437c3390f7857c6a9e25d58fbc2536 if it's too annoying.
Gross sync errors as were noted with WWMX Baltimore were confirmed as generally accurate using a real HD Radio receiver.  That station is truly sending different audio on their analog and digital streams.

For now, I'm removed the analog fallback, it really wasn't working well. In practice, some stations don't seem to be very good at keeping their analog and HD audio in sync, but that could be a regional thing for my locals. I would like to revisit this, perhaps as a part of refactoring the analog FM demodulator to work more like the HD Radio and DAB demodulators do.

This project will be archived; closing Issue as unresolved.


CRAYSAT-1871: Limit SLS query in sat status to only Nodes

Summary and Scope
The SLSStatusModule used by sat status has only Node as its component_types, meaning information from SLS is only added for nodes. The query, however, obtains SLS data for all components known to SLS. Modify this query to use the /search/hardware endpoint of SLS with type=comptype_node as a query parameter to limit the results to only the node components.
Issues and Related PRs

Resolves CRAYSAT-1871

Testing
Tested on:

Local virtual environment against drax

Test description:
Ran sat status from my macbook against drax with debug logging enabled to verify API requests made. Executed with multiple option combinations, including:

--types Node
--types NodeBMC
--types Node NodeBMC
--types all
Same as above but with addition of --sls-fields option

Risks and Mitigations
This is pretty low-risk. The data format returned by the two SLS API endpoints is the same, and this just limits the amount of data returned by SLS to the data for node-type components.
Pull Request Checklist

[x] Version number(s) incremented, if applicable
[x] Copyrights updated
[x] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[x] HPC Product Announcement prepared, if applicable

Testing output: https://gist.github.com/haasken-hpe/1da966a4c67c30e4bf39b713bdedabf0


feat: updated the chart legend ux

Overview
for the #1930 updated the chart legend ux and it includes

reduced the legend properties spacing
default width is increased for legend
tooltip added for the truncated names and properties names will truncate based on visibility width

Verifying Changes
legend-ux.webm
Legal
This project is available under the Apache 2.0 License.

acceptance criteria has a on-hover behaviour which i dont see in the attached screen recording

shows full name on-hover if the name is truncated like below (recorded this in video as well)


Make package exportable on npm

In order to require the module like so:
var politespace = require('pollitespace');

there needs to be a "main" property in the package.json. We had to
come up with a workaround here:
https://github.com/18F/web-design-standards/commit/74a8a5787a954c66a827581968b7a4688218c76c

Will this be ok not to include the DOM initialization stuff? The event bindings are in politespace-init.js

Manually including politespace-init.js
If you set "main": "./src/politespace.js" you do still have to manually include politespace-init.js. @msecret It seems like that's pretty much what you did in your workaround. (I'm assuming this is the code you mentioned—the initial link returns a 404 now.)
This is roughly the same as:
window.Politespace = require('politespace/src/politespace').Politespace;
require('politespace/src/politespace-init');

How to require Politespace now
Here's how I've been requiring Politespace via Browserify:
window.Politespace = require('politespace/dist/politespace').Politespace;

jQuery(function() {
  jQuery(document).trigger('enhance');
});

I've had to assign window.Politespace to avoid getting an Uncaught ReferenceError: Politespace is not defined (it happens when the jQuery plugin is initializied).
What about "main": "./dist/politespace.js"?
So it wouldn't be perfect, but if you set "main": "./dist/politespace.js" you'd be able to use:
window.Politespace = require('politespace/dist/politespace').Politespace;

jQuery(function() {
  jQuery(document).trigger('enhance');
});

A cleaner solution
You could get a cleaner solution by updating:

src/politespace.js to return Politespace as the value instead of a property, and
src/politespace-init.js to use window.Politespace when initializing the jQuery plugin

Then you'd be able to simply:
require('politespace');

jQuery(function() {
  jQuery(document).trigger('enhance');
});

In the meantime, the code under "How to require Politespace now" should do the trick.

@zachleat 🙌 Thanks for merging this in!
Have you already published this to npm?
Tried reinstalling but didn't see main included.

Awesome. 👍
Only thing that tripped me up was having to add an extra call for the require statement to work. (Didn't realize this was how the UMD jQuery template works—TIL.)
In case anyone else gets confused:
// ❌ Fails to initialize Politespace / returns a function
var Politespace = require('politespace');

// ✅ Initializes Politespace as a jQuery function / returns jQuery
var Politespace = require('politespace')();

Thanks again!


Add @VachaShah as maintainer

Description

Add @VachaShah as a maintainer
Correct @aditjind's affiliation
Update CODEOWNERS to specifically list maintainers
Update MAINTAINERS.md based off https://github.com/opensearch-project/.github/blob/main/MAINTAINERS.md

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #83 (c69cc87) into main (0b3212c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   42.32%   42.30%   -0.02%
==========================================
  Files          49       49
  Lines       27967    27967
==========================================
- Hits        11836    11832       -4
- Misses      16131    16135       +4

Flag
Coverage Δ

integration
42.30% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

opensearch/src/http/response.rs
16.18% <0.00%> (-2.32%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Support for umbrella projects

In order to support umbrella projects there has to be an option to group contexts. Cross-references would only be checked within each context subgroup.
Syntax proposal:
config :contexted,
  contexts: [
    [First.FirstContext, First.SecondContext],
    [Second.FirstContext, Second.SecondContext]
  ]

Maybe you can configure :contexted in the config file of each app inside umbrella apps instead of using the global config for all contexts? Not sure if using that option the feature that checks cross-references worked as expected or still needs some change.
Another possibility is to add an option in_umbrella: true in the config of :contexted to be detected by the library and run Cross-references for that use case with context grouped by app.
I am open to discussing this feature and contribute with a PR.
Best