Allow event handlers to be async

Currently, all event handlers are sync and return void, which makes using async operations possible only using the then and catch methods (or other techniques like creating and calling an async function that's called within the sync callback).
Can we change the types to allow for async callbacks? What are the drawbacks?

Hi @aryzing,
you can use async callbacks, they just won't be awaited. Changing the types would be misleading as the return value is always ignored (that's what the void means).
I'm not sure what's your use case or problem here.

Hi @aryzing,
you can use async callbacks, they just won't be awaited. Changing the types would be misleading as the return value is always ignored (that's what the void means).
I'm not sure what's your use case or problem here.

the return value is always ignored (that's what the void means).

Sure, and can't the same be true with
type Callback = void | Promise<void>

?
There is still no expectation of the lib awaiting the callback or handling any return value.

the return value is always ignored (that's what the void means).

Sure, and can't the same be true with
type Callback = void | Promise<void>

?
There is still no expectation of the lib awaiting the callback or handling any return value.

Fair enough, thanks for the correction, and aplogies for the incorrect type definition.
Regarding the types, here too you're right: an async func can be assigned sync one with void callback, I was coding fast and failed to realize the error was being thrown by the linter and not the type system,
Promise returned in function argument where a void return was expected. (@typescript-eslint/no-misused-promises)

Seems the linter here is on your side too, in that it feels weird to assign an async func to a sync one when an async one is not expected or isn't used for anything. And I guess that's where I'm going: since there's no impact on vis-network whether the callback is sync or async, but there is impact as far as correctness goes, then what's stopping us form explicitly allowing it?

Fair enough, thanks for the correction, and aplogies for the incorrect type definition.
Regarding the types, here too you're right: an async func can be assigned sync one with void callback, I was coding fast and failed to realize the error was being thrown by the linter and not the type system,
Promise returned in function argument where a void return was expected. (@typescript-eslint/no-misused-promises)

Seems the linter here is on your side too, in that it feels weird to assign an async func to a sync one when an async one is not expected or isn't used for anything. And I guess that's where I'm going: since there's no impact on vis-network whether the callback is sync or async, but there is impact as far as correctness goes, then what's stopping us form explicitly allowing it?

then what's stopping us form explicitly allowing it?

Because it makes no sense to require a return value (even if optional) that will be ignored. It would be confusing to accept a promise but then not await it. I'm simply not going to change the types in a way that makes no sense because of your linting rules. Which, by the way, are right; what you're doing there isn't very good use of promises. What if your promise rejects? You say you're contacting the server, that may fail and Vis Network is not going to solve this for you in any way (it won't even know that it failed).
PS: Write your code in a way that explicitly states what's gonna happen (e.g. throw the promise away with void)
network.on(
  "anyEvent",
  (params): void =>
    void (async (): Promise<void> => {
      await whatEver;
    })()
);

or reconfigure your linter so that it doesn't interfere with your practises.

then what's stopping us form explicitly allowing it?

Because it makes no sense to require a return value (even if optional) that will be ignored. It would be confusing to accept a promise but then not await it. I'm simply not going to change the types in a way that makes no sense because of your linting rules. Which, by the way, are right; what you're doing there isn't very good use of promises. What if your promise rejects? You say you're contacting the server, that may fail and Vis Network is not going to solve this for you in any way (it won't even know that it failed).
PS: Write your code in a way that explicitly states what's gonna happen (e.g. throw the promise away with void)
network.on(
  "anyEvent",
  (params): void =>
    void (async (): Promise<void> => {
      await whatEver;
    })()
);

or reconfigure your linter so that it doesn't interfere with your practises.


Feature/dev 440 new onboarding design

What kind of PR is this?:

/kind
What this PR does / why we need it:
Which issue(s) does this PR fixes?:

Fixes #
Additional comments?:
Developer Checklist:

[ ] Read your code changes at least once
[ ] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
[ ] No console errors on web
[ ] Tested on Light mode and Dark mode*
[ ] Your UI implementation visually matched the rendered design*
[ ] Unit tests*
[ ] Added e2e tests*
[ ] Added translations*

Hi @EdithDFX, I think you have raised on the wrong repository. I will close it now. 😅

Oh yes, sorry. Thank you @thedoublejay  😄


Creating a "latest" tag for your code-server releases (which helps when automating container rebuilds) ...

Hello Friends:
Can you create a latest tag for your releases so that when we, say, rebuild docker images, we can always refer to the same URL (i.e. the one with the latest tag)?
For example:
Instead of referring to this:
https://github.com/cdr/code-server/releases/download/v3.7.4/code-server-3.7.4-amd64.rpm

We refer to this instead:
https://github.com/cdr/code-server/releases/download/latest/code-server-amd64.rpm

Is this possible? I always have to check if the URL was updated. =:)
P.S. You guys are doing great work and I sincerely appreciate it!
Thank you!

Interesting, I'm not sure about this since I've always seen tags as more or less immutable. Would it work for you to query for the latest release the way we do in our install script?
https://github.com/cdr/code-server/blob/cb11e1f75054ea1faa79f8736d30f568582f1a50/install.sh#L74-L80

Interesting, I'm not sure about this since I've always seen tags as more or less immutable. Would it work for you to query for the latest release the way we do in our install script?
https://github.com/cdr/code-server/blob/cb11e1f75054ea1faa79f8736d30f568582f1a50/install.sh#L74-L80

@code-asher Ah, okay. I should be able to work with that script to get the version string. Thank you! :blush:

@code-asher Ah, okay. I should be able to work with that script to get the version string. Thank you! :blush:

Awesome! In that case I'll go ahead and close this. 😄

Awesome! In that case I'll go ahead and close this. 😄


Add new config to control the status icon size on Register screen

Describe the feature request.
Require a configuration to control the status icon size dynamically from the configs on the main register screen.
Acceptance criteria

status icon size should be controlled via configs

Implementation plan (For Engineers)

[ ] Add new configs in ButtonProperties called statusIconSize.
[ ] Replace the hard-coded value in ServiceCard with configs value.

LGTM!


Fix matte_paint and texture_paint role assignments

In v1 of these config releases, the working group decided to maintain parity with previous OCIOv1 ACES config releases with respect to the matte_paint and texture_paint roles. We made this decision to minimize disruption to applications wishing to make use of the new configs in the short term.
With the upcoming release of v2 of the configs, the group has decided the time is ripe to make the needed switch from:
  matte_paint: sRGB - Texture
  texture_paint: ACEScct

to the new:
  matte_paint: ACEScct
  texture_paint: sRGB - Texture

This issue is just to serve as documentation for the forthcoming PRs.

This has been implemented. The roles are switched in config version 2 and higher, per the working group discussion.


Add gitlab-ci export example

This addresses issue #97.

Thanks for the example! I think it would have been lost by adding it to the getting started page, so I've created a new GitLab page instead. Feel free to add more info to that page if needed.


Question on the NOTE about build source folder and cross-repo snippet links

Hi Tom ...
The NOTE in the Out-of-repo snippet references section states ...

The name you assign to the dependent repository is relative to the root of the main repository, but the tilde (~) refers to the root of the doc set. The doc set root is determined by build_source_folder in .openpublishing.publish.config.json. The path to the snippet in the preceding example works in the azure-docs repo because build_source_folder refers to the repo root (.). If build_source_folder were articles, the path would start with ~/../samples-durable-functions instead of ~/samples-durable-functions.

What is the parent path segment replacing or covering when the build_source_folder isn't the repo root (.)? It's not "articles" for a build_source_folder of articles because the following breaks 💥 ...
:::code ... source="~/articles/samples-durable-functions/samples/csx/shared/Location.csx" ...:::

... so what is it covering in the path if not "articles"? Why can't it be replaced with an explicit segment?
If this is more of a DocFX ❓ than something that you'd like to address in a doc update to the NOTE to clarify it further, then please go ahead and close this issue ... I'll ask via an internal DocFX issue.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d876ecc9-4bd3-7939-e085-45ee004d2ca4
Version Independent ID: 01ce33da-da13-b0f5-a153-3e1d41d848f5
Content: How to include code in docs - Contributor Guide
Content Source: Contribute/code-in-docs.md
Product: non-product-specific
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

for a build_source_folder of articles because the following breaks 💥 ...
:::code ... source="~/articles/samples-durable-functions/samples/csx/shared/Location.csx" ...:::

for a build_source_folder of articles I would expect you to need to go up one level as in the example in the note, by starting the path with tilde (~) to get to articles and then dot-dot (/..) to get to the repo root one level up. Once you're at the repo root, you can use the name you gave to the dependent repository.


add the FVWM window manager

ssia

@4z3 it's now part of nixpkgs, can you close this?

Closing in favor of https://github.com/NixOS/nixpkgs/pull/1532


Fix view_component deprecation warning

Requiring view_component/engine was deprecated in view_component version 2.46.0 https://github.com/github/view_component/commit/d24b26ae2697685e930d863839d7f8834b9ca4a3
Requiring view_component will automatically load the engine when in the correct context.
I'm also wondering if we should require "view_component" inside primer/view_components/engine so that we don't have to require view_component explicitly from apps using primer/view_component/engine?

Hey @Tonkpils, thanks for this! LOL we should have done this a while ago 😅
I do think it makes sense to require "view_component" inside primer/view_components/engine, and I would gladly accept a PR that makes the change. For now, I'll approve this one though.

Oh I forgot to mention: would you mind adding a CHANGELOG entry?

👍  @camertron I've added the changelog change. I'll also work on a PR to require view_components inside the engine and make the change to the docs again to reflect that 😄


feat: add SetIdleTaskOptions.taskName

https://hiroki0525.github.io/idle-task/api/setIdleTask#taskname-string

:tada: This PR is included in version 4.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Fixing coding convension for folders and files (1)

Pull request template

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
Describe your changes

Previously there is a closed PR because of the huge merge conflict.
This is the fixes of the previous closed PR.
https://github.com/ageddesi/Mocked-API/pull/226

Link to issue this resolves

Refactor: https://github.com/ageddesi/Mocked-API/issues/121

Cancelling this PR because or the Tests are still having issues..


Support CloudTrail logs

CloudTrail's JSON payload begins with an array of Records, the current lambda places all Records into a single NR Log entry.
The ask it to detect CloudTrail as a source and generate one NR Log entry for each CloudTrail Records entry.

Hi, this was merge #29 and published on version 1.1.2. Thanks @msummers-nr


Eureka client heart beat stopped but still showing in Eureka server

I have stopped my eureka client. But still the client name shows up on Eureka server.
Here is my code.
Am I missing something here?
const Eureka = require('eureka-js-client').Eureka;
var express = require('express')
var ip = require("ip");
const client = new Eureka({
// application instance information
instance: {
app: 'frontend',
instanceId : 'feapp',
hostName: 'localhost',
ipAddr: ip.address(),
port: {
'$': process.env.PORT || 5050,
'@enabled': true,
},
vipAddress: 'jq.test.something.com',
dataCenterInfo: {
'@class': 'com.netflix.appinfo.InstanceInfo$DefaultDataCenterInfo',
name: 'MyOwn',
},
},
eureka: {
// eureka server host / port
host: 'localhost',
port: 8761,
servicePath: '/eureka/apps/',
fetchRegistry: true,
heartbeatInterval:3000,
registerWithEureka:true
//preferIpAddress:true
},
});
client.logger.level('debug');
var app = express()
app.use(express.static('dist'))
var PORT = process.env.PORT || 5050
app.listen(PORT, function () {
client.start();
console.log('Express server listening on port ' + PORT)
})

The Eureka server doesn't drop the instance out of the registry immediately. It waits until it hasn't seen a heartbeat from that server in several minutes (configurable).

thanks @jquatier . Does this configuration has to be from server side or client side? If it is from the client side what is the parameter i need to set?

It's a setting on the Eureka server that applies to all registrations.

I am little bit confused here. I have other clients which uses spring cloud(Eureka discovery). Eureka server immediately evicts these clients when heart-beat is stopped. But Nodejs client stays there for hours

That's not really possible unless another instance is still sending heartbeats using the same app ID and instance ID. I would take a look at the last updated timestamp in the registry and debug from there. Your Eureka server will only drop records out if it hasn't gotten a heartbeat.


#415-improving card items

I have added a hover effect which will ease out kind on effect on hovering.
fixes #415
scrnli_03_06_2023_16-18-39.webm

@narayan954  pls verify and approve this so that i can create another pr for the other issue in order to avoid iany conflicts.

@narayan954 pls verify and approve this so that i can create another pr for the other issue in order to avoid iany conflicts.

okay sure, on it

Thanks for your contribution! :)


Add stress tests to test whether turms servers will OOM if unlimited number of clients try to login after #617

Prerequisite: https://github.com/turms-im/turms/issues/825


Add remaining test cases from track one DNS SDK to track two

Note, no test cases with a private DNS have been ported, this is due to the fact private DNS is no longer accepted by the service via this API. One must use the private DNS SDK.

/check-enforcer reset


Add missing CRLF epilogue

Missing the extra CRLF that marks the end of the outer headers.
multipart-body := [preamble CRLF]
                  dash-boundary CRLF
                  body-part *encapsulation
                  close-delimiter
                  [CRLF epilogue]

See: https://datatracker.ietf.org/doc/html/rfc2046#page-22
If the server is using a strict parser, the request will fail. (such as Google)

Hi, you're totally right, thanks for finding this! We actually used it for sending Google request but it has never failed for us...
I will merge this now, just have to fix the Unit tests!


Change file not found error to warning

Description
Currently when aligning dependencies and rnx-kit/dep-check finds a package without a package.json it exits with an error, blocking subsequent steps.
Changing this error to a warning to alert the user of missing file but still complete the runs.
Test plan
Align dependencies for packages that has a missing package.json file.
This should show a warning and not error out

Thanks for submitting this! Can you run yarn change and add a change log entry?


Support for Swiss German layout please

What are you experiencing an issue with?

[x] Aurora
[ ] Aurora supported game, (Fill in the game)
[x] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[x] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[x] Visual bug
[x] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[ ] Other, (Fill in another type of issue here)

Expected behavior:
Under automatic language selection, the £ and < keys should be illuminated, they are not. When selecting German layout, which should be the same, they are not illuminated, and the z and y illumination is wrong (illuminated as if the layout is QWERTY, which is wrong for DE, which should be QWERTZ)
The Enter key should also be illuminated, sometimes it is not.
How often does this problem occur?
Always
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:
Assigning a lighting colours to the £,> and Enter key.
What is the version of Aurora you are experiencing this issue with?
0.6b
Does the previous version of Aurora have this issue?
I don't know.
Please include any logs, screenshots, or files that are related to this issue:
Here's a link to the Swiss German and German layouts for reference:
https://en.wikipedia.org/wiki/File:KB_Swiss.svg
https://en.wikipedia.org/wiki/File:KB_Germany.svg

QWERTZ (DE layout) works fine for me.

Duplicate of #463. Closing...


Can we use take the result of embedding layer as target?

I want to train a model to identify the keyword of a sentences (assumpt just one keyword in a sentence).
My oringal thought is:

train word vectors using word2vec
train a lstm network using keras. Its input is the matrix (whose row is the word2vec vector of the words of sentence) of sentence, and the target is the word2vec vector of the keyword. Loss is mse or cosine_proximity.
if we want to identify the keyword of a new sentences, just rank the cos of the result and every word vector of sentence's words.

This way need to pretrain word vectors. But I know keras provide a embedding layer. Can we only use keras to realize my goal? In other word, Can we use take the result of embedding layer as target? Because in my way, the target is the result of the embedding layer?

You can use the target as an input, use it to compute the distance and add that distance to the loss using ActivityRegularizer


fix(license): Updating license and publishing new version to npm

:tada: This PR is included in version 1.5.1 :tada:
The release is available on npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:


don't list routers until session is available

list_routers_cb calls process_bindings, which needs the session

superseded by #760


Where can I order the ribbon?

I see no link for ordering the ribbon. I also cannot find it on OSH Park.

I am not selling it, nor have I filed the designs with any PCB manufacturing facility; however, the gerber files are included in this repository, so that they can be sent to any PC board factory which suits you (the surface-mount version uses "Flex PCB").
OSHPark is probably a good place, since they have a reasonably low cost for small quantities for flex PCBs (while the Chinese factories are very cost-effective for regular PCBs, they aren't cost-effective for small quantities of flex PCBs).
For the gerber files you would need to submit, they can be found here:
https://github.com/dshadoff/PCE_FRAM_adapter/tree/master/FRAM-SOIC
...the file is "FRAM-SOIC.zip"

Thanks for quick reply, do you know what the two resistors are A11 and A12? And how to wire up a bank switch? Will i need a 3-way toggle switch along with some pull-up resistors?

the two resistors are for pull-up, in case the inputs at A11 and A12 are either disconnected or unreliable.  47Kohm, 0603 surface-mount.  If you can guarantee stable logic signals at the A11 and A12 inputs, then they are not needed.
To hook up a bank switch, you'll need to figure out whether you need all 4 banks or not - if you do, then you'll need to find a way to apply the 4 different logic combinations to the A11/A12 pins:  { low/low, low/high, high/low, high/high }.
If you only need two banks, then an SPST switch may suffice (plus the pullups mentioned above): the SPST switch can connect one of (A11 or A12) to ground (for low) or leave it open (for high, due to the pullup).


Bugfix: Input_Rate errors out if dfNumerator has 0 rows.

Expected Behavior
Input_Rate should gracefully handle both a 0-row numerator and denominator dataset.  Given a 0-row numerator dataset, set numerator to 0 for all rows in the denominator dataset.  Given a 0-row denominator dataset, the function should exit.
Current Behavior
Input_Rate errors out here:
  # Calculate Numerator
  dfNumerator <- dfNumerator %>%
    rename("SubjectID" = !!strSubjectCol)

  if (strNumeratorMethod == "Count") {
    dfNumerator$Numerator <- 1 # throws error if dfNumerator has 0 rows
  } else {
    dfNumerator$Numerator <- dfNumerator[[strNumeratorCol]]
  }

Possible Solution
Process dfDenominator first then right join dfNumerator onto dfDenominator (keeping SubjectID only) prior to processing dfNumerator.
Steps to Reproduce

Run Input_Rate with a 0-row argument to dfNumerator.

Context (Environment)

Possible Implementation

Additional Comments

devtools::install_github("Gilead-Biostats/gsm", ref = "dev")
#> Skipping install of 'gsm' from a github remote, the SHA1 (05365a31) has not changed since last install.
#>   Use `force = TRUE` to force installation
library(gsm)
dfInput <- Input_Rate(
  dfSubjects = clindata::rawplus_dm,
  dfNumerator = data.frame(subjid = character(0)),
  dfDenominator = clindata::rawplus_dm,
  strSubjectCol = "subjid",
  strGroupCol = "siteid",
  strGroupLevel = "Site",
  strNumeratorMethod = "Count",
  strDenominatorMethod = "Sum",
  strDenominatorCol = "timeontreatment"
)
#> Error in `$<-.data.frame`(`*tmp*`, "Numerator", value = 1): replacement has 1 row, data has 0

library(tibble)
dfInput <- Input_Rate(
  dfSubjects = clindata::rawplus_dm,
  dfNumerator = tibble(subjid = character(0)),
  dfDenominator = clindata::rawplus_dm,
  strSubjectCol = "subjid",
  strGroupCol = "siteid",
  strGroupLevel = "Site",
  strNumeratorMethod = "Count",
  strDenominatorMethod = "Sum",
  strDenominatorCol = "timeontreatment"
)
head(dfInput)
#> # A tibble: 6 × 6
#>   SubjectID GroupID GroupLevel Numerator Denominator Metric
#>   <chr>     <chr>   <chr>          <dbl>       <dbl>  <dbl>
#> 1 0496      5       Site               0         675      0
#> 2 1350      78      Site               0         673      0
#> 3 0539      139     Site               0         673      0
#> 4 0329      162     Site               0         673      0
#> 5 0429      29      Site               0         664      0
#> 6 1218      143     Site               0         760      0

Created on 2024-10-17 with reprex v2.1.0
What's strange is it works for empty/0 row tibbles, I was having a hard time recreating it but then realized it needs to be a proper plainn old data.frame, the "intuition" we're going for is the bottom/tibble result right?

Ohhh, nice catch! That's an interesting divergence in data frame behavior.


Email formatting from the pager-me script

Using version 3.2.1
In PR #125, better email formatting was introduced. However, when using the implementation of hubot-pager-me, I see that the script is continuing to emit the mailto: link. In reading through both sets of source code, I am not sure where the "bug" really exists.
This is the basic example of the PagerDuty script's implementation:
robot.respond /pager(?: me)? as (.*)$/i, (msg) ->
  email = msg.match[1]
  msg.message.user.pagerdutyEmail = email
  msg.send "Okay, I'll remember your PagerDuty email is #{email}"

The bot then responds with:
user> hubot pager me as<EMAIL_ADDRESS>hubot> Okay, I'll remember your PagerDuty email address is<EMAIL_ADDRESS><EMAIL_ADDRESS>
The value of email is expanded to<EMAIL_ADDRESS><EMAIL_ADDRESS>rather than simply<EMAIL_ADDRESS>I'm not sure if that is the payload from Slack that sets that or if something else is going wrong.

Related: #125
Related: https://github.com/hubot-scripts/hubot-pager-me/issues/29
cc/ @paulhammond

+1 This exact email format issue is affecting my script as well.

I think the problem here is just that #125 hasn't yet made it into a release. But that's OK, because we just released 3.3.0 which includes the fix!
If I'm wrong please reopen this issue and we'll look into it!

Confirmed fixed.

I'm still seeing this. Fixed in 3.3?


Unable to load version 0.63 (from npm)

Hello.
I tried Rotjs with Webpack in a new project, but I think that the build on npm for version 0.63 is broken (version 0.62 works fine).
Loading a bundle with Rotjs in it in the browser results in this error:
Uncaught ReferenceError: ROT is not defined
    at Object.<anonymous> (bundle.js:5521)
    at Object.<anonymous> (bundle.js:5661)
    at __webpack_require__ (bundle.js:20)
    at Object.<anonymous> (bundle.js:72)
    at __webpack_require__ (bundle.js:20)
    at Object.defineProperty.value (bundle.js:63)
    at bundle.js:66

Line 5521 (bundle.txt):
ROT.Display.Term = function(context)
Which is the first line of node/term.js.
I had a look at the makefile, I think the problem is that 'umd/post.txt' isn't the last file added to the build file when using the node build.
Here is the file order defined in the makefile:
rot.js.node: $(NODE_PRE_SOURCES) $(SOURCES) $(NODE_POST_SOURCES)
I think that once 'umd/post.txt' (the last file in $(SOURCES)) is added, the object "ROT" is no longer in scope for anything that comes after that.
The files in $(NODE_POST_SOURCES) reference "ROT", so that results in the ReferenceError.

Hi @theotherhiveking,
thanks for this bugreport. I will try to have a look at it.

Hi @theotherhiveking,
please try updating to the NPM version 0.6.4 and trying again.

Just tried it. I can confirm it's working.


ion-refresher  TypeError: Cannot read property 'querySelector' of null

Ionic version:

[] 4.x
[ x] 5.1.0
I'm submitting a ...

[ x] bug report
[ ] feature request

Current behavior:

When I use Android 7.0 to open a page has ion-refresher, the console throws an error
TypeError: Cannot read property 'querySelector' of null
    at Refresher._callee6$ (https://-app/49-es5.js:1006:68)
    at tryCatch (https://xxx-app/polyfills-es5.js:14014:21)
    at GeneratorFunctionPrototype.invoke [as _invoke] (https://cne-app/polyfills-es5.js:14234:26)
    at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (https://xxx-app/polyfills-es5.js:14067:25)
    at asyncGeneratorStep (https://xxx-app/49-es5.js:3:103)
    at _next (https://xxx-app/49-es5.js:5:194)
    at ZoneDelegate.invoke (https://xxx-app/polyfills-es5.js:15149:166)
    at Zone.run (https://xxx-app/polyfills-es5.js:14810:43)
    at https://xxx-app/polyfills-es5.js:15801:32
    at ZoneDelegate.invokeTask (https://xxx-app/polyfills-es5.js:15185:179)

Then I checked 49-es5.js:1006:68, and the error code is:
 997                   console.error('<ion-refresher> must be used inside an <ion-content>');
998                    return _context6.abrupt("return");
999
1000                  case 7:
1001                    _context6.next = 9;
1002                    return contentEl.getScrollElement();
1003
1004                  case 9:
1005                    this.scrollEl = _context6.sent;
1006                    this.backgroundContentEl = contentEl.shadowRoot.querySelector('#background-content');

Expected behavior:

Steps to reproduce:

Related code:

<ion-content class="xxx">
    <ion-refresher slot="fixed" (ionRefresh)="doRefresh($event)">
      <ion-refresher-content pullingText="下拉刷新"
                             refreshingSpinner=""
                             refreshingText="">
      </ion-refresher-content>
    </ion-refresher>
</ion-content>

Other information:

Ionic info:

% ionic info

Ionic:

   Ionic CLI                     : 6.7.0 (/Users/xxx/node_modules/@ionic/cli)
   Ionic Framework               : @ionic/angular 5.1.0
   @angular-devkit/build-angular : 0.901.3
   @angular-devkit/schematics    : 9.1.3
   @angular/cli                  : 9.1.3
   @ionic/angular-toolkit        : 2.2.0

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : not available
   Cordova Plugins   : not available

Utility:

   cordova-res : 0.14.0
   native-run  : 1.0.0

System:

   Android SDK Tools : 26.1.1 (/Volumes/data/Android/sdk)
   ios-deploy        : 1.10.0
   ios-sim           : 8.0.2
   NodeJS            : v13.10.0 (/Users/xxx/node/v13.10.0/bin/node)
   npm               : 6.14.5
   OS                : macOS Catalina
   Xcode             : Xcode 11.4.1 Build version 11E503a

Step 1. Clone demo app from https://github.com/shuto-fandd/ionic-refresher-error-demo.git
Step 2. Initialize the project.
Step 3. exec Ionic cordova platform add<EMAIL_ADDRESS>Step 4. Launch an Android simulator based on sdk24.
Step 5. Run demo app on the simulator.
Step 6. Open the chrome console to view errors

Thanks for the issue. Can you try the following dev build and let me know if it resolves the issue?
npm i<EMAIL_ADDRESS>

It worked. Perfect.

Glad to hear it is working! I am going to keep this issue open until the fix has been merged in.

Thanks for the issue. This has been resolved via https://github.com/ionic-team/ionic/pull/21237 and a fix will be available in an upcoming release of Ionic Framework.


get_fieldmap

Hello,
It is unclear to me how I should set up my BIDS format in order to ensure that the proper field maps are found. I manually created an "IntendedFor" field within the field maps. Do I have to create something like that within other field to point to the field maps?
Thanks!

Did you figure this out, @tjhendrickson? If so, can we close this? If not, maybe @chrisfilo can help--I think he wrote get_fieldmap.

@tjhendrickson Does your dataset pass the validator without warnings? Which files did you put the IntendedFor fields?

Closing due to lack of activity, but feel free to re-open if necessary.


useTextField's onChange isn't firing with useFormik's formik change handler

Provide a general summary of the issue here
The controlled component controlled with formik's hook, for example:
      <TextInputField
        type="tel"
        id="phone"
        name="phone"
        prefix="phone"
        label="Mobile Phone"
        value={formik.values.phone}
        onChange={formik.handleChange}
      />

Does not allow the user to input a value because of the onChange function.
The onChange should return an event instead of just the target value
😯 Current Behavior
The onChange returns just the target value and is incompatible with other libraries
💁 Possible Solution
No response
🔦 Context
No response
🖥 Steps to Reproduce
https://codesandbox.io/s/naughty-water-87jkcy?file=/src/App.js
Version
3.26.0
What browsers are you seeing the problem on?
Firefox, Chrome, Safari
If other, please specify.
No response
What operating system are you using?
Mac OS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response

See #1860 and #3247 for previous discussions about this. In your case, could you do something like this?
<TextInputField
  // ...
  value={formik.values.phone}
  onChange={value => formik.setFieldValue('phone', value)} />

Yes that is exactly what I ended up doing. Thanks


Fill out expected readme.txt in the plugin directory

There is a generator we can use here: http://generatewp.com/plugin-readme/


[CodeCompletion] Don't take opaque types subst map into account

for checking duplicated results from multiple type checker solutions. e.g.
  protocol Proto {}
  struct Generic<T> {
    func retProto() -> some Proto
  }
  func foo() -> Generic<T1>
  func foo() -> Generic<T2>

  foo().<COMPLETION>

The return type of Geric<T1>.retProto() and Geric<T2>.retProto() is different, but they both spelled 'some Proto'. So IDE consumers don't care the difference.
rdar://107669173

@swift-ci Please smoke test


Transform GA4GH CWL-friendly Docker talk to documentation

Feature Request
Desired behaviour
The presentation of CWL-friendly Docker should be transformed into permanent documentation focusing on some of the constraints that cwltool imposes. Constraints like what cwltool uses for tmpdir, working dir, and how it sets most things to read only.

Already present on staging.dockstore.org as
https://staging.dockstore.org/docs/faq#do-you-have-tips-on-creating-cwl-files-


boards: arm: Update efm32pg_stk3402a and add tmo_dev_edge

Add PERSISTENT_GECKO_RTCC=y to COUNTER_GECKO_RTCC. Add gpio and regulator loopback fixtures to efm32pg_stk3402a. Add map.yml and testplan.json for tests that work on the Pearl Gecko. Add pinctrl to the Pearl Gecko and Jade Gecko with SiLabs help. Add pre_dt_board.cmake to eliminate SPI warning messages. Add tmo_dev_edge to match our https://devedge.t-mobile.com efforts. Update CODEOWNERS where it was applicable to T-Mobile.

`
druffer@druffer-VirtualBox:~/zephyrproject/zephyr/boards/arm/tmo_dev_edge$ ../../../../zephyr/scripts/twister --device-testing \

                                  --hardware-map tmo_dev_edge-map.yml \
                                  --load-tests tmo_dev_edge-testplan.json

INFO    - Using Ninja..
INFO    - Zephyr version: zephyr-v2.6.0-25366-g64ef2f28caee
INFO    - Using 'zephyr' toolchain.
INFO    - Writing JSON report /home/druffer/zephyrproject/zephyr/boards/arm/tmo_dev_edge/twister-out/testplan.json
Device testing on:

Platform
ID
Serial device

tmo_dev_edge
000900032606
/dev/ttyACM1

INFO    - JOBS: 1
INFO    - Adding tasks to the queue...
INFO    - Added initial list of jobs to queue
INFO    - Total complete:   49/  49  100%  skipped:    0, failed:    0, error:    0
INFO    - 2327 test scenarios (49 test instances) selected, 0 configurations skipped (0 by static filter, 0 at runtime).
INFO    - 49 of 49 test configurations passed (100.00%), 0 failed, 0 errored, 0 skipped with 0 warnings in 2162.23 seconds
INFO    - In total 330 test cases were executed, 12 skipped on 0 out of total 565 platforms (0.00%)
INFO    - 49 test configurations executed on platforms, 0 test configurations were only built.
Hardware distribution summary:

Board
ID
Counter

tmo_dev_edge
000900032606
49

INFO    - Saving reports...

INFO    - Writing JSON report /home/druffer/zephyrproject/zephyr/boards/arm/tmo_dev_edge/twister-out/twister.json

INFO    - Writing xunit report /home/druffer/zephyrproject/zephyr/boards/arm/tmo_dev_edge/twister-out/twister.xml...

INFO    - Writing xunit report /home/druffer/zephyrproject/zephyr/boards/arm/tmo_dev_edge/twister-out/twister_report.xml...

INFO    - Run completed

`

Hi, thanks for your contribution. You're introducing a lot of changes in this PR.

There is a ton of replication there, but on a few actual changes

Could you check if it's possible to limit the scope of this PR, i.e. split it into smaller PRs, so that's easier to review the code?

The problem is in testing, both the twsiter tests on an existing board and a new board on these same tests. Both boards need the same support files, so there is also a merge sequencing issue. I don't know of a "better" way yet, but I'm certainly open for suggestions.

Please split your changes into several commits. You're adding more than 4k LOC in one commit, across many Zephyr subsystems.

Half of the 4k LOC are in the test plans which are generated by Twister itself. I'd love to hear al alternative for that, cause with only 49 tests being specified, they are still a pain to maintain. The multiple subsystems are the introduction of pinctrl to both boards for the 1st time. That again, involves my files and I have may driver files that will follows those which could be split apart.

Please remove any unnecessary files (i.e. these JSON files) that are not needed by the Zephyr RTOS.

The JSON files are needed to test the Zephyr RTOS on these boards. I have no evidence that twister tests have been run on the existing board, and plenty of evidence that most tests do not work. I started with adding platform-exclude everywhere, but this method is much less intrusive. Obviously, the efm32pg_stk3402a was admitted to Zephyr with these problems. I'm just trying to figure out the best way for us to deal with the issues now.

The problem is in testing, both the twsiter tests on an existing board and a new board on these same tests. Both boards need the same support files, so there is also a merge sequencing issue. I don't know of a "better" way yet, but I'm certainly open for suggestions.

From what I've gather, this PR could be split up in the following way and order:

efm32pg_stk3402a changes (without persisent RTCC)
persisent RTCC driver changes + enablement on efm32pg_stk3402a
add tmo_dev_edge platform

The problem is in testing, both the twsiter tests on an existing board and a new board on these same tests. Both boards need the same support files, so there is also a merge sequencing issue. I don't know of a "better" way yet, but I'm certainly open for suggestions.

From what I've gathered, this PR could be split up in the following way and order:

efm32pg_stk3402a changes (without persisent RTCC)
persisent RTCC driver changes + enablement on efm32pg_stk3402a
add tmo_dev_edge platform

I have posted a new PR which just starts by redoing the twister proposal at: boards: arm: Update efm32pg_stk3402a to run twister tests that pass. I think I can add most of the others as small independent PRs too, but the final one, bringing in our tmo_dev_edge board is going to rely on them all and we will need to discuss how to do the properly.


Added code of conduct and other missing files

Added text for a code of conduct as well as some other missing files:
new file:   CHANGES.rst
new file:   CITATION
new file:   CODE_OF_CONDUCT.md
new file:   CONTRIBUTING.md
@eteq @nden @hcferguson comment with any changes you'd like to see?

I added more example sections to the README file as well

:tada:


RAILS server implementation refactored

Again, refactored version of  #5763 (that can be closed):

Fixes for some of bugs in server side
Fix in gfx: wrong pdu type that caused mstsc to close the connection when using RAILS with HiDef.
Fix bug in update_send_new_or_existing_notification_icons  (it checked the version field value without first checking it is present in the payload.
Keep extendedSpiSupported synced between server and client.

@kubistika hmm, looks like you need to rebase this one, looks like you started on the wrong branch.

@akallabeth yes, I’ll rebase tomorrow

@akallabeth i rebased on master.

@freerdp-bot test

@freerdp-bot test


can not adjust button size

Button is stretched。I can not custom size of button.

@bluesky0109 reupload your image as we cannot view the one in your post


fuzz: fixing unsigned integer underflow

Signed-off-by: Yifan Yang<EMAIL_ADDRESS>When length() equals to 0, having it minus 1 will trigger underflow that causes the program to try to allocate 0xffffffffffffffff bytes.
This bug is found by envoy fuzz testing, linked here https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24078&can=2&q=envoy.
Commit Message:
Additional Description:
Risk Level: Low, as the change is minimal.
Testing: All existing tests including the failed fuzz testing cases are passed
Docs Changes:
Release Notes:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

@asraa

/retest

/retest

/retest envoy-presubmit

@asraa @cpakulski  any chance you guys can run /azp run envoy-presubmit for me?
It seems that the test is flaky


communities: hidden search box on mobile fix

Shows serach box with icon and input only
on mobile devices (closes zenodo/zenodo#208).

Signed-off-by: Adrian Pawel Baran<EMAIL_ADDRESS>

After the changes propsed being applied:

:shipit:


Add some AbstractNamedGraph functionalities

Some convenience AbstractNamedGraph functionalities that I ended up using quite often, so I though it could make sense to add them here. A summary of the (potential) additions:

A function rename_vertices which allows renaming the vertices of an AbstractNamedGraph or AbstractNamedEdge given a Function or Dictionary name map. It is basically the same as the one in https://github.com/mtfishman/ITensorNetworks.jl/blob/main/examples/peps/utils.jl, with some minor adjustments to make it work for all currently existing AbstractNamedGraph subtypes. In particular, it seemed to make sense to allow renaming to change the vertex type for the case of NamedGraph.
Constructors for all currently existing AbstractNamedGraph subtypes which just take a list of vertices, similar to how Graphs.Graph(::Integer) returns a graph with a given number of vertices and no edges.
Equality for AbstractNamedGraphs, useful for checking if the underlying graph of two instances of a given data structure is the same.

As per the suggestions above, I switched to a core map-like interface for rename_vertices for AbstractNamedEdge and AbstractNamedGraph, with a Dictionary name map as a special case. These now rely on an internal set_vertices routine defined for each concrete subtype.

Looks great, thanks a lot! Also thanks for adding all those tests, these packages have been undertested...


ESP32 SUSTAIN_PIN

Hi Brandon. How to set up the SUSTAIN_PIN correctly in the sketch? I created a new sustain PWM output: "pinMode (SUSTAIN_PIN, OUTPUT);" connected LED to PIN 13, but it doesn't work. In the port monitor (ESP32), I see that a midi signal comes from the Control box (Pro micro), all notes except SUSTAIN. I plugged in the midi keyboard, all notes work just as well except SUSTAIN.
Thanks!
void setup ()
{
const int SUSTAIN_PIN = 13;
pinMode (SUSTAIN_PIN, OUTPUT);
pinMode (LED_BUILTIN, OUTPUT);
Serial.begin (38400);
initializeBluetooth ();
// create sustain PWM output. this can't be done by the Pro Micro because the shift registers are filled up
ledcSetup (0, 100, 8);
ledcAttachPin (SUSTAIN_PIN, 0);
}

did you manage to do the project? Can I contact you to clarify some doubts I have?

Hi. The project is still in progress.  I make the solenoids myself, I also made the PCB. I hope to finish soon :) You can ask questions here.

Can you tell me more about your PCB?


HTML Documentation Framework

Current coverage is 64.41% (diff: 100%)

Merging #1864 into develop will decrease coverage by 0.01%

@@            develop      #1864   diff @@
==========================================
  Files           683        683
  Lines         48973      48973
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits          31554      31548     -6
- Misses        17419      17425     +6
  Partials          0          0

Powered by Codecov. Last update aa11eff...8981082

Another suggestion: CMake custom target to build the docs. Not included in the "all" target, so won't build automatically, and won't negatively affect anyone without the toolchain. If built under VS, creates a project that gives access to the files under docs/ for editing within the IDE.
https://github.com/ximinez/rippled/commit/6069fc8b18fc2a765b1f448f060085fadbcf66ff

@vinniefalco On Ubuntu 16.04, I'm getting an error running b2:
~/dev/rippled/docs (vf-doc=)$ $BOOST_ROOT/b2
warning: mismatched versions of Boost.Build engine and core
warning: Boost.Build engine (/home/eah/boost_1_61_0/b2) is 2015.07.00
warning: Boost.Build core (at /usr/share/boost-build/src) is 2014.03-svn
boost.jam: No such file or directory
../Jamroot:10: in modules.load
ERROR: rule "boost.use-project" unknown in module "Jamfile</home/eah/dev/rippled>".
/usr/share/boost-build/src/build/project.jam:325: in load-jamfile
/usr/share/boost-build/src/build/project.jam:64: in load
/usr/share/boost-build/src/build/project.jam:113: in load-parent
/usr/share/boost-build/src/build/project.jam:464: in initialize
/usr/share/boost-build/src/build/project.jam:306: in load-jamfile
/usr/share/boost-build/src/build/project.jam:64: in load
/usr/share/boost-build/src/build/project.jam:145: in project.find
/usr/share/boost-build/src/build-system.jam:535: in load
/usr/share/boost-build/src/kernel/modules.jam:289: in import
/usr/share/boost-build/src/kernel/bootstrap.jam:139: in boost-build
/usr/share/boost-build/boost-build.jam:8: in module scope

This occurs whether or not b2 is in my $PATH

Sounds like you have a misconfigured system

I apt removed all of the system boost packages, and it's working now. Fortunately, nothing else depended on them.

I'm taking this PR over.


"Release Roadmap" section at the support page is outdated

Describe the bug
The support page at https://adoptium.net/support/ is outdated for all LTS releases (Java 8, 11, 17 and 21).
It shows the version that were released in October 2023 as "Latest Release" and the recently released January 2024 versions as "Next Release Due".
I would have opened a PR by myself but unsure which date should be added for the next releases.
Could https://www.java.com/releases/matrix/ be used for the wording?
This update was already forgotten after the October 2023 release (see #2443).
FTR: The release checklist (https://github.com/adoptium/temurin/issues/16) marked this update as done. But I was a little bit puzzled because the link within the task

Update support page (automate* github workflow to create a PR to update support webpage)

points to the supported-platforms and not the support table.

Thank you for the issue. The table is now up to date, and I have moved your proposed checklist change to another issue.

@tellison thanks for clarifying/splitting that issue.
The current table indeed does look correct, except Java 21 column, where the last release mentions 21.0.2 in January and the next one 21.0.3 in April. The April one is already out and therefore should be listed as the latest release and 21.0.4 as the next one. Right?

Good spot!  It looks like JDK21 dates were missed as part of the page update.
I have created a PR to fix it.
Thank you for letting us know.


CodeGenerator: missing Component class namespaces for [ComponentDependency]

First let me say: Great Job!
This little framework saves so much boilerplate while increasing code reuse.

I think I found a small bug in the CodeGenerator:
I have an [Entity] with multiple child components, with some [ComponentDependency] references between them.
Everything works fine, as long as the referenced child [Component] classes all have the same namespace.
Actual behavior:
The generated C# sources for the components are missing using statements
for any [ComponentDependency] component with a different namespace
than the generated component itself.
The build fails.
expected behavior:
Components may have [ComponentDependency] from any namespace.

my own component source code:
The referenced (shared) component from namespace "B":
namespace B;

[Component(typeof(Node))]
public partial class ComponentB : Node
{ ... }

The component from namespace "A" using the shared component from "B":
using B;

namespace A;

[Component(typeof(Node))]
[ComponentDependency(typeof(ComponentB))]
public partial class ComponentA : Node
{ ... }

The generated sources for ComponentA:
no using statement for namespace "B" (or a fully qualified name):
using Godot;
using Godot.Composition;

namespace A;

public partial class ComponentA: Godot.Composition.IComponent
{
    protected Node3D parent;
    protected ComponentB componentB; // <- ERROR
	[...]
}

Error from logs:
0>ComponentA_IComponent.g.cs(9,15): Error CS0246 : The type or namespace name 'ComponentB' could not be found (are you missing a using directive or an assembly reference?)

Desktop:

OS: Win11
Godot 4.2.2
Godot.Composition 1.2

@biberesser Good catch! I will have an updated version out soon.


Sizing guide

Type of change
Select the type of your PR

Documentation

Description
Sizing/capacity planning guide for service admins. Goals is to provide guidelines for sizing brokers, routers and operators (admin) and understanding resource consumption by these components.
@jenmalloy I put everything into a single file because it was easier to edit that way. Let me know how you think it should be structured.
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Update/write design documentation in ./documentation/design
[ ] Write tests and make sure they pass
[x] Update documentation
[ ] Check RBAC rights for Kubernetes / OpenShift roles
[x] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
[ ] Reference relevant issue(s) and close them after merging
[ ] Update CHANGELOG.md

@jenmalloy I'm done with the changes now :)


build time issues with php support

Hi,
I just tried to build merecat Merecat httpd 2.32-rc4 as it sits in git today, on a Debian oldstable 10/buster system.
I don't have php-cgi installed.  I tried to build a Debian package from it: I invoked 'debuild' from the merecat
git checkout.  It failed with:
make[3]: Entering directory '/home/joostvb/git-ro/merecat/tests'
/usr/bin/make  check-TESTS
make[4]: Entering directory '/home/joostvb/git-ro/merecat/tests'
make[5]: Entering directory '/home/joostvb/git-ro/merecat/tests'
PASS: start.sh
PASS: cgi.sh
FAIL: php.sh
PASS: gzip.sh
PASS: redirect.sh
PASS: location.sh
PASS: stop.sh
============================================================================
Testsuite summary for Merecat httpd 2.32-rc4
============================================================================
# TOTAL: 7
# PASS:  6
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See tests/test-suite.log
Please report to https://github.com/troglobit/merecat/issues
============================================================================
make[5]: *** [Makefile:486: test-suite.log] Error 1

.
test-suite.log has:
FAIL: php
=========

+ echo <?php echo 'Hello ' . htmlspecialchars($_GET["name"]) . '!'; ?>
+ ls srv
cgi-bin
img
index.html
index.html.gz
main.css
main.css.gz
test.php
+ cat srv/test.php
<?php echo 'Hello ' . htmlspecialchars($_GET["name"]) . '!'; ?>
+ + curl http://localhost:8086/test.php?name=foobar
grep Hello foobar
FAIL php.sh (exit status: 1)

It would be nice if in debian/control, the line
Build-Depends: debhelper (>= 10), systemd, pkg-config, libconfuse-dev, libssl-dev, zlib1g-dev
could be replaced with
Build-Depends: debhelper (>= 10), systemd, pkg-config, libconfuse-dev, libssl-dev, zlib1g-dev, php7.4-cgi | php-cgi
(I didn't test that, btw).  Furthermore, it'd be nice if ./configure honoured a --disable-php flag.
Thanks for maintaining merecat!
Bye,
Joost

Hi,
PHP is not a build-time dependency, is a configuration option.  So if you have  /usr/bin/php-cgi installed you can use it just like any type of CGI.  That's why it's not in Build-depends or has a configure option.  I guess a Build-recommends or -suggests could be in order, if that exists, I dunno.  I've only whipped up that debian/ build directory for my own benefit and to facilitate testing before the next release.
So ... I'm going to close this with a "won't fix" tag, unfortunately.  Thanks for using Merecat! <3


add palette in the landing page

add palette in the landing page with similar selection as the menu

merged with card branch for deployment


Make sure that Minikube is installed prior to kubectl

I was having a lot of trouble getting kubectl to configure, getting the error:
The connection to the server localhost:8080 was refused - did you specify the right host or port?
But I just needed to install and start Minikube first and then configure kubectl and all my problems were solved.

need to sign a CLA

I was having a lot of trouble getting kubectl to configure, getting the error:
The connection to the server localhost:8080 was refused - did you specify the right host or port?

That's true, if you use kubectl command before cluster up.  But i confusion about which step you you kubectl

Please reopen this PR when you have signed the CLA. We can't accept your work until that happens. Thanks!


Find a way to modularise Objects endpoints

These are used by CTI butler, Vulmatch, Obstracts and Stixify
In Obstracts and Stixify there are 2 more endpoints (reports) -- but these can be removed to achieve this ticket
I want to find a scaleable way of keeping these endpoints in sync between products

@fqrious these now need to also be imported to CTI butler
https://dogesec.slack.com/archives/D05L8JEAM1N/p1730279224599469?thread_ts=1730275724.850349&cid=D05L8JEAM1N


Update launcher readme

Summary of the Pull Request

Updated readme
Added GIFs for readme
Added link for module overview

PR Checklist

[x] Applies to #2858
[x] CLA signed. If not, go over here and sign the CLA

Validation Steps Performed

Clicked module overview in Settings which now opens launcher page
GIFs in readme are showing and playing

@crutkas where should the images for readme be uploaded? I see some are uploaded directly in src/modules/<feature> folder and some are in doc/images

all known issues have milestone of v1 & a .19 / .20 project?

all known issues have milestone of v1 & a .19 / .20 project?

@crutkas yes, most of them are .19. We can readjust if necessary.


Choose Web UI Links

Internal Review: First MVC App
Internal Review: Razor Pages Overview App
Internal Review: Razor Pages Get Started
Creating an include that links to the Choose Web UI topic.  This will be included at the top level of getting started tutorials.
Related to #22635

@Rick-Anderson,  embarrassingly, I'm not understanding why I am getting a build fail here.  Do you see what I might be doing wrong?  The warnings are the usual alt text duplication warnings we get on multi-version docs like these.   The include shows up in the topics fine however as intended in the build.  Do I ignore the build fail or is there something I am missing that I can fix here?  Although it would be odd, it occurred to me that new include files might need to be published first before referencing them, even though they show up in the build, is that it?
Also, you wanted a link in the Blazor getting started, but the one we point to for getting started is on the Marketing/new customer site, not in docs, and not in this repo.  As an alternative, It doesn't feel right to mention this link in the to do list Blazor tutorial, which we do not promote as a starting point.  Thoughts?

@Rick-Anderson, please disregard my question about the build fail. We have repeating alt text warning for just about any of the multi-version topics but I don't remember the build failing over them, so I though I must have an issue with the way I did the include.  It is my first new include.  I guess it really is just the alt text issues.
Also, I tried to model (copy) after one of the existing includes, but I see those were not following the latest expected for metadata, so fixing that.

close / reopen to force build.

@wadepickett  once you get this error you can't eliminate it from close/open. It's a bogus error see #22992

@wadepickett  double check those warnings


Split database.json

What do you think about splitting database.json into one JSON file per motor? Maybe a folder structure with manufacturer as the containing folder? E.g.:
motors
├── FPV_Cycle
│   └── 25MM-1870KV.json
├── T-Motor
│   ├── F1404-2900KV.json
│   ├── F1404-3800KV.json
│   ├── F1404-4600KV.json
│   ├── M0802-22000KV.json
│   ├── M0802-25000KV.json
│   └── M0802-27000KV.json
└── iFlight
    ├── Xing2_1404-3000KV.json
    ├── Xing2_1404-3800KV.json
    ├── Xing2_1404-4600KV.json
    ├── Xing2_2207-1855KV.json
    └── Xing2_2207-2755KV.json

On the upside, this would ease finding and updating existing entries. However, it'll require something like "compiling" database.json  in a GitHub action on main branch updates or updating the database loader code.
I don't mind doing the work, but I want to know if this is a reasonable direction before I do the work.

Compiling database.json would allow a pass to do some calculated values, like Stator Volume and Stator Ratio, so motors of different sizes can be more easily compared.

That's an interesting idea, thanks.
Is that how it's usually done?
I liked the idea of a single file. It's very easy to load it into Excel and convert back to json. Multiple files would make that more complex.
And creating a whole new database (batteries, esc's, ...) would be as easy as changing the database file and adjusting the default header ordering.
Calculating Stator Volume and aspect ratio is something I thought about as well. I think that can be done before sending the contents to DataTables without adding another field in the json file.

This is a common approach to data sets like this. Obviously, it doesn't maintain your Excel workflow, though.
Typically, there will be a template file and a strict schema (e.g., defined as JSON Schema), with schema compliance checked at pull request time. Adding a new entry is just copying the template to a new file and editing with a text editor. This is obviously optional process that gets more valuable as more contributors are submitting updates.
In moving away from an Excel-based workflow, where the data is only 2-dimensional, some fields can become more complex data types. Particularly, KV typically doesn't have a significant impact on other motor specs (e.g. weight), so having individual motor entries for each KV increases maintenance costs that can be mitigated by having a multi-value field for KV instead.
I maintain a database of sorts with a lot of different products, including motors, for myself. I haven't shared it, but have considered doing something like this. My plan is to integrate my list of motors into this and delete my personal copy. If scope here goes beyond motors, I'd be very happy to contribute the rest as well.


Python Wrapper pipeline.start() Segmentation Fault

Required Info

Camera Model
D455

Firmware Version
<IP_ADDRESS> (Built from source)

Operating System & Version
Ubuntu 20.04.6

Kernel Version (Linux Only)
5.10.66

Platform
Khadas Edge2 (ARM 64)

SDK Version
2.54.1

Language
python

Segment
Robot/others

I am attempting to use the pyrealsense2 library to capture frames from a single D455 on a Khadas Edge2. Since ARM is not officially supported, I built from source using the following cmake flags:
cmake …/ -DBUILD_PYTHON_BINDINGS:bool=true -DFORCE_RSUSB_BACKEND:bool=true -DBUILD_WITH_CUDA:bool=false -DBUILD_GRAPHICAL_EXAMPLES:bool=false -DCMAKE_BUILD_TYPE=release
The realsense viewer works fine for both depth and color, and so do the example CPP scripts. However, using python causes a segmentation fault when calling pyrealsense2.pipeline().start().
Python script that recreates the issue:
import pyrealsense2 as rs
pipe = rs.pipeline()
pipe.start() # Segmentation fault

This appears to be a problem with the python wrapper, given that the CPP pipe.start() function works just fine.

hi @cu-boulder-robotics  Using firmware version <IP_ADDRESS> may cause errors when used with librealsense SDK version 2.54.1.  This is because it was compatible with SDKs up to 2.51.1 but not 2.53.1.  Please update your firmware to <IP_ADDRESS>, the recommended firmware version for 2.54.1.  You can perform this firmware update in realsense-viewer in the drop-down menu of the More option near the top of the realsense-viewer options side-panel.

That's excellent to hear that a firmware update resolved your problem.  Thanks very much for the update!


(FACT-1844) JDK10 drops support for javah

Any JDK post 9 requires change of invocation from
javah -d
to
javac -h
The arguments change too. This PR allows the headers to be built on JDK 9 and 10.

Can one of the admins verify this patch?

Waiting for CLA signature by @mlevitt
@mlevitt - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/
Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

The CLA click through doesn't seem to have sent the email though I've clicked resend and even tried other email accounts. I believe this is exempt as it has only:

Changes in build or installation scripts

CLA signed by all contributors.

Done!  ... and a rebase against current master for good measure.


Docusaurus: Build a website and publish it on Github pages

Description
Docusaurus is a documentation website builder by Facebook. Need to explore and build a website for documentation of this project.

Hey is this task still open


Added note that Opus support is High Sierra-only

This is not true.. e.g. it doesn't work here: https://hpr.dogphilosophy.net/test/index.php
revert: #4146


Testing myst-demo - in storybook?

Is there a nice way to test myst-demo during dev? Would it make sense to add to storybook as just another component?

I think I did try this when I introduced storybook, and got some weird errors. That was before things settled down a bit, it might just work now!


Drop unused Pythons

Fixes https://github.com/conda-forge/yasm-feedstock/issues/7
Drops all Pythons except Python 2.7 as they are only used for building.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Bugfix: fdasd fails to re-read the partition when resizing the dasd.

when resizing the dasd, the "fdasd -a" fails to re-read the partition
table with the BLKRRPART IOCTL error(rc:255). It is most likely due to
the device just being in use by udev. So use blockdev to trigger
a re-read of the partition table.
Signed-off-by: Xiao Feng Ren<EMAIL_ADDRESS>

lgtm

lgtm


[FP]: CVE-2023-28867 graphql-java-annotations flagged as graphql-java

Package URl
<EMAIL_ADDRESS>CPE
cpe:2.3:a:graphql-java:graphql-java:9.1:*:*:*:*:*:*:*
CVE
CVE-2023-28867
ODC Integration
{"label"=>"Gradle Plugin"}
ODC Version
8.2.1
Description
According to https://nvd.nist.gov/vuln/detail/CVE-2023-28867 not an issue in graphql-java-annotations itself.

There are several FPs for this on various graphql related libraries.
I think it would make sense to use a suppression that ignores matches for that cpe for anything but pkg:maven/com.graphql-java/graphql-java.
Should look like this:
    <suppress base="true">
        <notes><![CDATA[
        suppress various improper matches to the CPE that belongs only to pkg:maven/com.graphql-java/graphql-java
   ]]></notes>
        <packageUrl regex="true">^(?!pkg:maven/com\.graphql-java/graphql-java@).+$</packageUrl>
        <cpe>cpe:/a:graphql-java:graphql-java</cpe>
    </suppress>

approved
@melo0187 suppressions were present, but CPE changed from cpe:/a:graphql-java_project:graphql-java to cpe:/a:graphql-java:graphql-java
When merging in the hosted suppressions to the packaged suppressions we'll merge in with the existing suppressions


Nodes are off by a pixel?

The black rectangle has 0, 0 abs positioning yet it's off by 1px on top and left in Chrome on desktop.

For structure, the yellow background image is the parent node with a src for image.

Here is the other corner as well. I thought this might be due to devicePhysicalPixelRatio but I updated that and still have this issue.

Could not reproduce this using #391 - if you can find another way to setup the test that this does show, feel free to reopen.


support line-comments to struct comment

Describe the PR
support line-comments to struct comment
Additional context

Comments written on top of the field are not beautiful

Codecov Report

Merging #356 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #356      +/-   ##
=========================================
+ Coverage   85.58%   85.6%   +0.02%
=========================================
  Files           7       7
  Lines        1304    1306       +2
=========================================
+ Hits         1116    1118       +2
  Misses        109     109
  Partials       79      79

Impacted Files
Coverage Δ

parser.go
84.76% <100%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d66fe8...ace1a8b. Read the comment docs.

And add comment plz.
https://github.com/swaggo/swag#description-of-struct

OK thx.

@easonlin404
I wit for License Compliace sometimes.
Can you add permission for me?

would you help add this to readme examples and example code ?

@easonlin404
I wit for License Compliace sometimes.
Can you add permission for me?

it seems like cannot grant permission, and I have found sometime will not trigger license scan so I have dropped check it.

OK.
I add later example code  .
We have to decide pr flow what do you think?
eg: If add solution. required readme and example update.

It's a good idea to add example or update readme when add new feature.


disable the image optimization

disabling the next/image optimization because:

the headless CMS do the image optimizations instead of next/image.
image/next optimization makes links such as http://<IP_ADDRESS>:3001/media-main/image1-100x124.webp&w=3840&q=75.
this link is illegible and throws 404 since after the .webp you expect to have "?".

sorry, missed the previous PR. closing


Improve evaluate on hover feature.

when session has support for 'supportsEvaluateForHovers', using regex to extract the
sub-expression of the hover and using it to evaluate.

Hi @rajkumar42, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Rajkumar Janakiraman). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Fixes issue https://github.com/Microsoft/vscode/issues/4059
@gregg-miskelly @wesrupert

@weinand, @isidorn can you please code review?

We are currently in the endgame this week, thus assigning this to august and I will code review / potentially merge start of next week.

Did a quick glance over the code, will do a full review next week. Here's some suggestions:

Are you sure you are using supportEvaluateOnHover correctly. If I understand everything correctly the goal of this PR is to better find the expression that is being hovered over. That has nothing to do with the supportEvaluateOnHover flag. That flag just tells how to evaluate the expression, if true we will do the evaluate if not we will find it in the variables view. All the debuggers should benefit from your imporvement, not only those that supportEvaluateOnHover
Instead of writing lenghty documentation, just document the feature in this PR and just put a link to this PR as a comment
Do not specify variable types if they are automatically infered by TS, that is not our style
Please extract your logic into a seperate method so it is easier to read
Squash all your commits into one once done so it is easier to read
You seem to have branched of master when there was a build failure - please get latest from master so the build checks pass
DId you build vscode of your changes and test you do not break at least the following debug adapters:

[ ] node
[ ] c++

@isidorn

This is not a comprehensive fix. One regex for all languages won't work. My fix is a stop gap solution for C#/C++ and probably work for some languages as well. Ideally every debug extension can provide a parser based on their language service. We can discuss about the extensibility point in the issue https://github.com/Microsoft/vscode/issues/4059
I have built and verified VSCode changes with C#/C++/node debuggers.

@jacdavis can you take a quick look?

LGTM as a stop-gap, though I second Rajkumar's concerns about trying to handle this at the editor-level at all.

My biggest problem with the current approach is that it uses the flag supportsEvaluateForHovers  to use a different strategy to find a word. This feels like a hack to me as the supportsEvaluateForHovers capability has nothing to do with the way a word is being matched.
It seems like we all have concers on solving this on the editor level.
Due to that I propose that we somehow move more of this logic to the extension, so each adapter extension could reason about what is being hovered over - a good example is Haskel as @wesrupert pointed out.
One idea would be that VSCode simply sends the line and column number of the cursor and the adapter would send back the data for the hover. Not sure how feasable this is.
Since @weinand is on vacation this week I propose to wait for next week to get his feedback on this matter.

Agreed, making it an extension would make it robust. We can hold off till @weinand gets back.
Say the expression under mouse hover is foo["bar"], debuggers which supportsEvaluateForHovers would actually evaluate to foo["bar"], but for the debuggers which don't it could only find and show foo from the stack. Hence the difference in finding the expression depending on supportsEvaluateForHovers feature. Sorry if hadn't made it clear before.

@isidorn ping...

@rajkumar42 Isidor will be back in the office next week.

@weinand we were actually waiting for your input.

I agree with most what was said in this thread:

in the future a language service should be involved in preparing the arguments before they are passed to the debug adapter (supportsEvaluateForHovers: true) or used for the variable lookup in the frontend (supportsEvaluateForHovers: true).
since we do not yet have hover support for a language service, this PR should be considered as a temporary workaround. As such it should not introduce or require any new architecture, it should be kept minimal, and should reduce the risk by only being used when a C++/C# debug session is active.

The fact that the PR uses supportsEvaluateForHovers to determine what strategy to use seems to be a necessity if it wants to make use of the much more powerful capabilities of  the eval based hover (as @rajkumar42 has pointed out in his comment).
Having VS Code send the line and column information to the debug adapter as part of the evaluate request could help in some (simple) cases but in general it is difficult in the debug adapter to get access to the language service.

@weinand  I have merged the latest changes from vscode/master. 2 unit tests are failing - unrelated to my change. Can you give me guidance on what needs to done to merge the PR?

Sorry for the slow reponse, I was on vacation.
I have added some minor comments to your commits. Can you please address them?
Did you try out your changes with node, c++ and c# debugging. We want to make sure everything works our fine.
Once both fo these things are done we can merge the PR in. Next week is our endgame, so in order to have this for the august release we would need to wrap this up until Monday.

@isidorn addressed your comments.
Tested, however since it is a stop-gap solution there will be cases it wouldn't work even in C++/C#.

Coverage decreased (-0.003%) to 60.815% when pulling 07874b8c42e9d9d9b90588df5ba441e460a216d1 on rajkumar42:master into 194bb22d3c9dac94325364c25adfa1633d5e71c3 on Microsoft:master.

Coverage decreased (-0.003%) to 60.815% when pulling 2c356714f3a49df2d3486fd0c31830bce6a1e569 on rajkumar42:master into 194bb22d3c9dac94325364c25adfa1633d5e71c3 on Microsoft:master.

Looks good to me, merged! Thanks a lot :beers:
I just did some minor renames on top.

Thanks!!


Provider errors and services refactor

This PR resolves #58 and introduces a major refactor to HttpService: stopped using singleton design pattern, separated several parts of services package into injected dependencies to facilitate simpler testing and mocking in the future.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@976324d). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage        ?   55.05%
=======================================
  Files           ?       40
  Lines           ?      890
  Branches        ?       62
=======================================
  Hits            ?      490
  Misses          ?      385
  Partials        ?       15

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Feature request: key in asdf_handler

I wonder if this is a reasonable request. Example below tested in Python 3.7.1.
>>> import asdf
>>> asdf.__version__
'2.3.0'
>>> asdf_f = asdf.open('imaging_wcs.asdf')
>>> asdf_f.keys()
dict_keys(['asdf_library', 'history', 'wcs'])

Actual:
>>> 'wcs' in asdf_f
...
~\asdf\asdf.py in __getitem__(self, key)
    400
    401     def __getitem__(self, key):
--> 402         return self._tree[key]
    403
    404     def __setitem__(self, key, value):

KeyError: 0

Desired:
>>> 'wcs' in asdf_f  # Same as 'wcs' in asdf_f.keys()
True

Oh, that was fast. Thanks!


Added privacy policy page

Description
Added privacy policy page
Related Issues*
#30
Checklist
Replace "[ ]" with "[x]" to mark them as completed.

[x] I have forked the repo and pushed the changes according to contribution guidelines.
[x] I have tested these changes locally.
[x] I have tried to maintain the consistency of the code.
[x] I have tested these changes locally.
[x] I have updated the documentation accordingly.

This PR cant be merged u forked and push the changes in wrong branch

Ok I will regenerate the PR


'folly/folly-config.h' file not found

I've got the issue "folly/folly-config.h' file not found"
"react-native" : "0.55.1"
I‘ve create the profile
pod 'React', :path => '../../node_modules/react-native', :subspecs => [
    'Core',
    'CxxBridge', # Include this for RN >= 0.47
    'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43
    'RCTText',
    'RCTNetwork',
    'RCTWebSocket', # Needed for debugging
    'RCTAnimation', # Needed for FlatList and animations running on native UI thread
    # Add any other subspecs you want to use in your project
  ]
  # Explicitly include Yoga if you are using RN >= 0.42.0
  pod 'yoga', :path => '../../node_modules/react-native/ReactCommon/yoga'

  # Third party deps podspec link
  pod 'DoubleConversion', :podspec => '../../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../../node_modules/react-native/third-party-podspecs/Folly.podspec'

install success
then I run the ios product get the "folly/folly-config.h' file not found" Error message
How can I solve it？

This happens when your pod cache is corrupted. Try cleaning the Xcode project, then the build folder, then the DerivedData folder, then the pod cache, then run again pod install.

Duplicate of #18683?

Nice catch, thanks @maxdavidson.
Duplicate of https://github.com/facebook/react-native/issues/18683

@alreadyRight
哥们，你的这个问题解决没有

当时没解决，但现在按照RN文档上操作一遍就成功了

@alreadyRight
自己搞个新项目能行，
在原来项目就报错

Going back to 0.54.2 worked for me. 0.55.0 should not have been released as stable.

@alreadyRight @xiaoyongchen 新项目没问题，集成进老项目就报错，很无奈

@alreadyRight  按照哪块的文档操作好的呀

@alreadyRight
自己搞个新项目能行，
在原来项目就报错

遇到了同样的问题，你后来怎么解决的丫？


Fix united sweep

Closes #617

@whoburg, ready for review

retest this please

reviewed -- currently failing unit and dependency tests

retest this please

@whoburg: ready for re-review

merge if passes tests


[Feature Request]: Global manager for default promt templates.

Feature Description
I would really like to have a global manager in which you can change the default templates for prompts, rather than manually entering them for each llama index object tha use them. This will be especially useful for localization into other languages, since if you need to use llama_index and chatgpt (or other models) to work with text and chat in other languages, almost all the templates need to be changed so that the model adheres to this language without problems.
Reason
No response
Value of Feature
No response

Thanks @Inkorak! This is something that we've been very recently thinking about how to better incorporate into our library.
More to come on soon on this.
(CC: @jerryjliu)


How the contribution of Attention mechanism

Hello, have you estimated the contribution of attention mechanism? If without attention mechanism, only use local anchors, how about the results?

Yes, those results are shown in the paper.


Create money for economy

Use gold ingots as a precursor to money. Forging ingots creates money. Need to make functions to make ingots useable as currency.

Made gold ingots and blocks transferrable between players by comment.
Made land exchangeable for gold ingots/blocks.

I finished this!


Escape HTML in room descriptions

Now, escape HTML in room descriptions to prevent things like this from being possible: http://prntscr.com/8g0mjy

Room descriptions are already escaped client-side.
Really, the only issue is that the reply to targetless /roomdesc is not escaped -which considering that the setter command is admin-only-, is hardly an issue.
@Zarel, we agreed not to have links in room descriptions, right? In that case, we should get rid of the url-linking and just escape the roomdesc in https://github.com/Zarel/Pokemon-Showdown/blob/b81e818200ebd91b904f971c3ce7698fa0cf63ee/commands.js#L400 .

I use a link in a private roomdesc for personal reasons.
@Slayer95's suggestion is probably best.

Updated @Zarel


NBS: Don't add 0-sample to histogram in Put()

Turns out sometimes Put() is so fast it gets reported as
taking 0ns. It's nonsensical to put a 0 in a Histogram, so
don't. Just change it to 1.
Fixes #1787

PTAL


zlib: Properly clean up static/shared distinction

Includes #66486 (a simple comments change) which is for master, while this is for staging.
Motivation for this change
The previous logic was "grown" and has become pretty crazy to understand.
This improves what commit e999def1 (zlib: clean up static/shared distincion) described as "kind of a mess" and "confusing". And indeed it was confusing.
Now, the concept whether or not the .a file is moved to a split output is controlled by a clean variable.
The defaults remain unchanged.
The new approach also finally cleanly allows building statically but NOT using a split output, like all other autoconf-based projects in nixpkgs do (using the dontDisableStatic setting).
That is important for overlays that want to enable static libs for all packages in one go, without having to hand-patch idiosynchrasies like zlib had until now.
Until now, if you wanted the .a in the main output, the only way was to go via static=false, shared=true -- which made no sense, because you had to say static=false even though you want a static lib. That is fixed now.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.
[x] Tested all boolean combinations of shared, static and splitStaticOutput, checking that the files in the outputs are as expected.

Notify maintainers
cc @matthewbauer

@GrahamcOfBorg build zlib

The comments look good, but I'm a little bit surprised this needs to be a mass rebuild. I didn't think dontDisableStatic would be needed at all, --disable-static is not being passed to zlib.
splitStaticOutput definitely makes things clearer, although for the same reasons you describe in .pc, I was hoping we could eventually phase those out altogether. There are a few things that rely on this output existing though. pkg-config assumes that all of your libraries are in the same directory.
Changing the order seems reasonable though, at least to make things more clear. Not sure why it has that behavior, but my understanding was that zlib just always assumed you wanted static libraries.

I didn't think dontDisableStatic would be needed at all, --disable-static is not being passed to zlib.

@matthewbauer Can you elaborate a bit on that? I thought that's passed in general, is there an exception for zlib somehwere that I could refer to?

for the same reasons you describe in .pc, I was hoping we could eventually phase those out altogether. There are a few things that rely on this output existing though

I wasn't sure if there's anyone who wants the zlib.static output to exist. Do you know if such someone exists?
I didn't find many uses of it; what's the best way to find them all?

Changing the order seems reasonable though, at least to make things more clear. Not sure why it has that behavior

As far as I can tell, zlib has a hand-writen ./configure script, not autoconf, and I suspect that the logic is that by default it builds both, that they added a --static option to build only static, and that later somebody added a --shared flag so that you can "turn it back on", and that the order is simply because their command line argument parsing code "grew that way". But I haven't checked.

I thought that's passed in general, is there an exception for zlib somehwere that I could refer to?

Ah I see: https://github.com/NixOS/nixpkgs/blob/6490f9c740092e61ab5fe3e73a71f665b82cd78a/pkgs/stdenv/generic/setup.sh#L993-L998
This greps for enable-static in the ./configure file, and zlib's handwritten one doesn't have that.

I'm a little bit surprised this needs to be a mass rebuild

I've pushed a fix that should avoid mass rebuilds, with extra commentary for rationale.

@GrahamcOfBorg eval
@GrahamcOfBorg build zlib

Great, we're at rebuild: 0, so I have changed this PR to master.

https://github.com/madler/zlib/pull/394 may it someday be better upstream.

splitStaticOutput definitely makes things clearer, although for the same reasons you describe in .pc, I was hoping we could eventually phase those out altogether. There are a few things that rely on this output existing though. pkg-config assumes that all of your libraries are in the same directory.

I have filed a separate issue for this task at #66658.


[Feature] RocketMQ client SDK adapt

相关组件
RocketMQ
背景说明
Apache RocketMQ 5.0 版本发布后，客户端 SDK 提供了 gRPC 协议的支持，以前版本均采用 Remoting 协议。

Remoting 协议
RocketMQ 早期组件间默认的通信协议, 是 RocketMQ 官方仓库中自带的实现
gRPC 协议
5.0 版本以后开始支持, 旨在以云原生主流技术演进更加轻量、标准、易扩展的客户端服务端通信协议.

组件适配
SCA 将对两个不同版本的客户端 SDK 进行适配，由用户根据使用的 RocketMQ 服务端版本来自行选择客户端 SDK。
选型问题建议
以下章节列出一些场景场景下，推荐的选型策略。官网说明

服务端版本是4.x版本，是否可以使用gRPC SDK ？

不支持，gRPC SDK 仅支持版本大于等于5.0的服务端，建议先平滑升级服务端到5.0再更换SDK。

从 Remoting SDK 更换到 gRPC SDK 是否需要修改代码？

需要，gRPC SDK 重新优化设计了客户端API，和Remoting SDK API 并不兼容，因此需要对照修改代码。

新业务使用 RocketMQ 推荐使用什么SDK？

全新的业务系统接入 RocketMQ，推荐使用gRPC SDK，可以获得更好的使用体验和多语言环境支持。

Background
After the release of Apache RocketMQ 5.0, the client SDK provides support for the gRPC protocol, while previous versions used the Remoting protocol.

Remoting Protocol
The default communication protocol between components in early versions of RocketMQ, implemented in the official RocketMQ repository.
gRPC Protocol
Supported since version 5.0, aiming to provide a lightweight, standard, and easily scalable client-server communication protocol using cloud-native mainstream technologies.

Component Adapt
SCA will adapt two different versions of the client SDK, and users can choose the client SDK based on the version of RocketMQ server they are using.
FAQ
The following sections list some recommended selection strategies for certain scenarios.Official Site

Can gRPC SDK be used with a server version of 4.x?
No, gRPC SDK is only supported by server versions equal to or greater than 5.0. It is recommended to first smoothly upgrade the server to version 5.0 and then replace the SDK.

Is it necessary to modify the code when switching from Remoting SDK to gRPC SDK?
Yes, it is necessary. The client API of gRPC SDK has been redesigned and is not compatible with the Remoting SDK API. Therefore, it is necessary to modify the code accordingly.

What's the best choice of sdk when use rocketmq in new system?
If a new business system is integrating with RocketMQ, it is recommended to use gRPC SDK, as it provides a better user experience and support for multiple language environments.

Has anyone completed this quest yet? If not, I would like to try to complete this quest, is that ok?

Welcome to contribute


Filter Spark event logger outside the spark engine

Why are the changes needed?

The default value of kyuubi.engine.event.loggers is SPARK, but it can't be used outside the spark engine, so filter it.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #3289 (0b5eeb9) into master (327336f) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##             master    #3289      +/-   ##
============================================
- Coverage     51.38%   51.37%   -0.01%
  Complexity       13       13
============================================
  Files           468      469       +1
  Lines         26220    26232      +12
  Branches       3632     3631       -1
============================================
+ Hits          13473    13477       +4
- Misses        11465    11470       +5
- Partials       1282     1285       +3

Impacted Files
Coverage Δ

...rg/apache/kyuubi/events/EventHandlerRegister.scala
56.52% <50.00%> (-3.48%)
:arrow_down:

...uthentication/JdbcAuthenticationProviderImpl.scala
73.21% <0.00%> (-6.54%)
:arrow_down:

...apache/kyuubi/engine/JpsApplicationOperation.scala
77.41% <0.00%> (-3.23%)
:arrow_down:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
74.07% <0.00%> (-0.93%)
:arrow_down:

...che/kyuubi/server/KyuubiTHttpFrontendService.scala
64.23% <0.00%> (-0.73%)
:arrow_down:

...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala
80.00% <0.00%> (ø)

.../main/scala/org/apache/kyuubi/util/JdbcUtils.scala
87.50% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more