use proto and addr replace protoAddrParts[0] and `protoAddrPart…

- updated variables name
- use proto and addr replace protoAddrParts[0] and protoAddrParts[1]

I'm not sure I like this change too much as it doesn't make it more readable (even less)

hm, it seems consistent with the code above this (which also uses addr and proto, so a "mild" +1  from me, so I think the next reviewer should make the decision :smile:

oh wait what ? :sweat: I don't know why but I did read the invert change, so in fact I'm +1 for this change (I think I was tired when first reviewing this one).

LGTM then :smile:

@pwzgorilla you need to sign your commit though
15:39:52 ---> Making bundle: validate-dco (in bundles/1.13.0-dev/validate-dco)
15:39:53 These commits do not have a proper 'Signed-off-by:' marker:
15:39:53  - 2d3f4475d44643c7cebc8128a7b3a8dafa190440

As @GordonTheTurtle would say :
Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-5" git@github.com:friism/docker-1.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

what happened to jenkins check?

Don't think CI failures are related. This one is scary though; not sure what happened there;
https://jenkins.dockerproject.org/job/Docker-PRs/30811/console
02:20:37 ----------------------------------------------------------------------
02:20:37 FAIL: docker_cli_build_test.go:5864: DockerSuite.TestBuildBuildTimeArgOverrideEnvDefinedBeforeArg
02:20:37
02:20:37 docker_cli_build_test.go:5888:
02:20:37     if out, _ := dockerCmd(c, "run", "--name", containerName, imgName); !strings.Contains(out, envValOveride) {
02:20:37         ...
02:20:37     }
02:20:37 /go/src/github.com/docker/docker/pkg/integration/dockerCmd_utils.go:42:
02:20:37     c.Assert(err, check.IsNil, check.Commentf(quote+"%v"+quote+" failed with errors: %s, %v", strings.Join(args, " "), out, err))
02:20:37 ... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc82049d340), Stderr:[]uint8(nil)} ("exit status 2")
02:20:37 ... "run --name bldargCont bldargtest" failed with errors: barOverride
02:20:37 panic: close of closed channel
02:20:37
02:20:37 goroutine 1 [running]:
02:20:37 panic(0xaff640, 0xc8203653f0)
02:20:37 	/usr/local/go/src/runtime/panic.go:481 +0x3e6
02:20:37 github.com/docker/engine-api/client/transport/cancellable.(*notifyingReader).Close(0xc820366e20, 0x0, 0x0)
02:20:37 	/go/src/github.com/docker/docker/vendor/src/github.com/docker/engine-api/client/transport/cancellable/cancellable.go:109 +0x7a
02:20:37 github.com/docker/docker/api/client/container.waitExitOrRemoved(0xc82007c510, 0x7f7e915b87c8, 0xc82032a380, 0xc820386180, 0x40, 0x0, 0xecf3b34f4, 0x202ffd6a, 0x139ab20, 0x0, ...)
02:20:37 	/go/src/github.com/docker/docker/api/client/container/utils.go:91 +0xc8f
02:20:37 github.com/docker/docker/api/client/container.runRun(0xc82007c510, 0xc82007d4d0, 0xc8202f97d0, 0xc820314500, 0x0, 0x0)
02:20:37 	/go/src/github.com/docker/docker/api/client/container/run.go:266 +0x168b
02:20:37 github.com/docker/docker/api/client/container.NewRunCommand.func1(0xc82031b680, 0xc820332f00, 0x1, 0x3, 0x0, 0x0)
02:20:37 	/go/src/github.com/docker/docker/api/client/container/run.go:49 +0x141
02:20:37 github.com/spf13/cobra.(*Command).execute(0xc82031b680, 0xc820332e70, 0x3, 0x3, 0x0, 0x0)
02:20:37 	/go/src/github.com/docker/docker/vendor/src/github.com/spf13/cobra/command.go:593 +0x6fe
02:20:37 github.com/spf13/cobra.(*Command).ExecuteC(0xc82007fb00, 0xc82031b680, 0x0, 0x0)
02:20:37 	/go/src/github.com/docker/docker/vendor/src/github.com/spf13/cobra/command.go:683 +0x55c
02:20:37 github.com/spf13/cobra.(*Command).Execute(0xc82007fb00, 0x0, 0x0)
02:20:37 	/go/src/github.com/docker/docker/vendor/src/github.com/spf13/cobra/command.go:642 +0x2d
02:20:37 github.com/docker/docker/cli/cobraadaptor.CobraAdaptor.run(0xc82007fb00, 0xc82007c510, 0x7ffd28d64aff, 0x3, 0xc82000a0c0, 0x3, 0x3, 0x0, 0x0)
02:20:37 	/go/src/github.com/docker/docker/cli/cobraadaptor/adaptor.go:122 +0x25f
02:20:37 github.com/docker/docker/cli/cobraadaptor.CobraAdaptor.Command.func1(0xc82000a0c0, 0x3, 0x3, 0x0, 0x0)
02:20:37 	/go/src/github.com/docker/docker/cli/cobraadaptor/adaptor.go:130 +0x8c
02:20:37 github.com/docker/docker/cli.(*Cli).Run(0xc8203325a0, 0xc82000a0b0, 0x4, 0x4, 0x0, 0x0)
02:20:37 	/go/src/github.com/docker/docker/cli/cli.go:81 +0x34b
02:20:37 main.main()
02:20:37 	/go/src/github.com/docker/docker/cmd/docker/docker.go:72 +0x599
02:20:37
02:20:37 goroutine 17 [syscall, locked to thread]:
02:20:37 runtime.goexit()
02:20:37 	/usr/local/go/src/runtime/asm_amd64.s:1998 +0x1
02:20:37
02:20:37 goroutine 5 [syscall]:
02:20:37 os/signal.signal_recv(0x0)
02:20:37 	/usr/local/go/src/runtime/sigqueue.go:116 +0x132
02:20:37 os/signal.loop()
02:20:37 	/usr/local/go/src/os/signal/signal_unix.go:22 +0x18
02:20:37 created by os/signal.init.1
02:20:37 	/usr/local/go/src/os/signal/signal_unix.go:28 +0x37
02:20:37
02:20:37 goroutine 24 [runnable]:
02:20:37 github.com/docker/docker/api/client/system.(*eventHandler).Watch(0xc820384420, 0xc82038c840)
02:20:37 	/go/src/github.com/docker/docker/api/client/system/events_utils.go:39 +0x7f
02:20:37 created by github.com/docker/docker/api/client/container.waitExitOrRemoved
02:20:37 	/go/src/github.com/docker/docker/api/client/container/utils.go:56 +0x417
02:20:37
02:20:37 goroutine 10 [runnable]:
02:20:37 github.com/docker/docker/api/client.(*DockerCli).ForwardAllSignals.func1(0xc82038c060, 0xc82007c510, 0x7f7e915b87c8, 0xc82032a380, 0xc820386180, 0x40)
02:20:37 	/go/src/github.com/docker/docker/api/client/utils.go:144 +0x83
02:20:37 created by github.com/docker/docker/api/client.(*DockerCli).ForwardAllSignals
02:20:37 	/go/src/github.com/docker/docker/api/client/utils.go:164 +0x97
02:20:37
02:20:37 goroutine 8 [runnable]:
02:20:37 net/http.(*persistConn).readLoop(0xc820368680)
02:20:37 	/usr/local/go/src/net/http/transport.go:1185 +0xd52
02:20:37 created by net/http.(*Transport).dialConn
02:20:37 	/usr/local/go/src/net/http/transport.go:860 +0x10a6
02:20:37
02:20:37 goroutine 9 [select]:
02:20:37 net/http.(*persistConn).writeLoop(0xc820368680)
02:20:37 	/usr/local/go/src/net/http/transport.go:1280 +0x472
02:20:37 created by net/http.(*Transport).dialConn
02:20:37 	/usr/local/go/src/net/http/transport.go:861 +0x10cb
02:20:37
02:20:37 goroutine 19 [select, locked to thread]:
02:20:37 runtime.gopark(0xec1d50, 0xc82001ef28, 0xd49050, 0x6, 0x18, 0x2)
02:20:37 	/usr/local/go/src/runtime/proc.go:262 +0x163
02:20:37 runtime.selectgoImpl(0xc82001ef28, 0x0, 0x18)
02:20:37 	/usr/local/go/src/runtime/select.go:392 +0xa67
02:20:37 runtime.selectgo(0xc82001ef28)
02:20:37 	/usr/local/go/src/runtime/select.go:215 +0x12
02:20:37 runtime.ensureSigM.func1()
02:20:37 	/usr/local/go/src/runtime/signal1_unix.go:279 +0x358
02:20:37 runtime.goexit()
02:20:37 	/usr/local/go/src/runtime/asm_amd64.s:1998 +0x1
02:20:37
02:20:37 goroutine 13 [runnable]:
02:20:37 encoding/json.(*Decoder).Decode(0xc820307ba0, 0xac2280, 0xc82041a480, 0x0, 0x0)
02:20:37 	/usr/local/go/src/encoding/json/stream.go:43
02:20:37 github.com/docker/docker/api/client/system.DecodeEvents(0x7f7e8fd68090, 0xc820366e20, 0xc820365040, 0x0, 0x0)
02:20:37 	/go/src/github.com/docker/docker/api/client/system/events_utils.go:56 +0x102
02:20:37 created by github.com/docker/docker/api/client/container.waitExitOrRemoved
02:20:37 	/go/src/github.com/docker/docker/api/client/container/utils.go:79 +0xaea
02:20:37
02:20:37 goroutine 12 [runnable]:
02:20:37 github.com/docker/engine-api/client/transport/cancellable.Do.func3(0x7f7e915b87c8, 0xc82032a380, 0xc8203845b0, 0xc820331440)
02:20:37 	/go/src/github.com/docker/docker/vendor/src/github.com/docker/engine-api/client/transport/cancellable/cancellable.go:78 +0xef
02:20:37 created by github.com/docker/engine-api/client/transport/cancellable.Do
02:20:37 	/go/src/github.com/docker/docker/vendor/src/github.com/docker/engine-api/client/transport/cancellable/cancellable.go:84 +0x336
02:20:37 , exit status 2
02:20:37
02:20:41

need re-check

ping @vdemeester PTAL (everything is signed, squashed, rebased 👍)

LGTM :tiger:


unable to inject the translation service inside of an http interceptor

Current behavior
I get the following error in my browser's console "Circular dependency in DI detected for InjectionToken HTTP_INTERCEPTORS" when trying to inject the translation service inside of an HTTP interceptor.
Expected behavior
I'm expecting that the injection works fine and that the translation is done.
How do you think that we should fix this?
By trying to remove the circular dependency. If that's possible.
Minimal reproduction of the problem with instructions

inject the translation service inside of an http interceptor
Environment

ngx-translate version: 13.0.0
Angular version: 11.0.7

Browser:
- Chrome (desktop) version 94.0.4606.61 (Official Build) (64-bit)

For Tooling issues:
- Node version: v14.17.6
- Platform:  Linux

Others:

I found the bug. You need to define dependencies for interceptors like below:
{provide: HTTP_INTERCEPTORS, useClass: HttpResponseInterceptor, multi: true, deps: [TranslateModule]}

I found a workaround here : https://stackoverflow.com/questions/67152273/angular-circular-dependency-when-inject-translateservice-to-interceptor


Update route.php for massUpdate

I would like to have massUpdate function in this package. Can you help to push it?

Hello,
Thank you for the pull request but at this point there is no mass update feature on our to do list. Please check future versions!
This pull request is closed due the fact that it only adds a single additional route.


nodejs slave fails with nexus exposed via edge ssl route

oc start build jenkins-slave-nodejs8-angular
npm ERR! code SELF_SIGNED_CERT_IN_CHAIN
| npm ERR! errno SELF_SIGNED_CERT_IN_CHAIN
  | npm ERR! request to https://... xxxx .... /repository/npmjs/@angular%2fcli  failed, reason: self signed certificate in certificate chain
https://stackoverflow.com/questions/9626990/receiving-error-error-ssl-error-self-signed-cert-in-chain-while-using-npm

ca=null did not do the trick
strict_ssl=false did it ...
I have a local branch with this as fix,.. but this sounds to me plain wrong - there must be a way to include the trust.crt from the slave!

Found an article on the official npm blog:
https://blog.npmjs.org/post/78085451721/npms-self-signed-certificate-is-no-more
but I will have to take a deeper look


Cmd duration

This PR implements both an interactive command duration variable and a callback for capturing that data. It does not include any unit tests. Once we've decided whether only one solution, or both, is worth merging I'll add appropriate unit tests. Personally I can't see much point in the callback mechanism and would use the $edit:command:duration var in my prompt rather than registering a callback to capture that data. Nonetheless, since I've implemented the callback it might be worth merging simply because there might be a use case I haven't thought of that justifies the added complexity.

The variable is useful for inserting the information in the prompt, but the callback might be more useful for producing notifications, like my long-running-notifications module does.
However, I don't much see the difference between the edit:after-command and the edit:before-readline callbacks. Wouldn't they run one after the other in any case?

However, I don't much see the difference between the edit:after-command and the edit:before-readline callbacks. Wouldn't they run one after the other in any case?

Note that edit:before-readline currently has no arguments. That could be changed but conceptually doing something before a prompt is written is different from doing something after a command completes. Too, simply pressing Enter will result in edit:before-readline being run. Since no command was run you need additional complexity in the interpretation of its arguments to distinguish between command completion and no command being run. Your long running notification mechanism is a useful example of how the edit:after-command callback is useful. Finally, as a practical matter the way the code is currently structured passing the command completion data to the edit:before-readline callback is difficult. Which isn't really an argument for not doing it that way but suggests the existing callback isn't the appropriate way to expose the event.

Also, the temporal relationships of the callbacks to each other and other actions (e.g., writing the prompt) is something that could be better documented.

Since @zzamboni provided an example of how an "edit:after-command" callback is useful, and I still maintain that a command duration variable is useful even though technically redundant, I think both mechanisms should be implemented. Thus I'm going to go ahead and remove the leading hyphen from the var name (so it is no longer marked experimental) and add unit tests for both features.

I'd say the variable is still useful for quick access to the information, e.g. to put it in the prompt.

I prefer to keep just the hook; the variable can be easily implemented in Elvish code with the hook mechanism.

I prefer to keep just the hook; the variable can be easily implemented in Elvish code with the hook mechanism.

As I noted in an earlier comment the truth value of that assertion depends on how you define "easily". I think the vast majority of users who simply want to include the last command duration in their prompt will not find the hook an "easy" way to get that information.

I prefer to keep just the hook; the variable can be easily implemented in Elvish code with the hook mechanism.

Hmmm, I just noticed that this could be implemented as default behavior by adding appropriate statements to the Elvish code in pkg/edit/default_bindings.go. I want to sleep on this but I'm still not convinced the near zero cost of the explicit module variable should be substituted with Elvish code that adds significant cost to the most common use case.
Also, I haven't pushed an update to this P.R. because adding unit tests is proving more difficult than I expected. The shell.Interact() function isn't run by the editor unit tests. So the code I added to that function to set $edit:cmd-duration and run the $edit:after-command hooks isn't exercised by the edit unit tests.

I prefer to keep just the hook; the variable can be easily implemented in Elvish code with the hook mechanism.

Hmmm, I just noticed that this could be implemented as default behavior by adding appropriate statements to the Elvish code in pkg/edit/default_bindings.go. I want to sleep on this but I'm still not convinced the near zero cost of the explicit module variable should be substituted with Elvish code that adds significant cost to the most common use case.

Implementing such a variable with Elvish code is a good idea. If you do that, default_bindings.go should also be renamed to something like edit_init.go.
By "significant cost" do you mean the overhead of executing Elvish code versus executing Go code? Elvish is much less performant than Go, but (1) users perhaps already have some code in their rc.elv, and (2) eventually the editor implementation should be moved more and more from Go into Elvish anyway. If the performance of Elvish becomes a bottleneck for (2), the solution is to speed up Elvish, not keeping things in Go.

Also, I haven't pushed an update to this P.R. because adding unit tests is proving more difficult than I expected. The shell.Interact() function isn't run by the editor unit tests. So the code I added to that function to set $edit:cmd-duration and run the $edit:after-command hooks isn't exercised by the edit unit tests.

That's exactly why there needs to be an additional REPL abstraction (I had another comment about this) which will be correct place to test this.

Implementing such a variable with Elvish code is a good idea.

That's trivial and, I agree, a good idea in general. Spefically, it is better to implement as much functionality in Elvish code as is possible; as opposed to implementing the same logic in Go. However, note that we still need to define the underlying var in the Go source. Which splits the implementation.

I just realized that $edit:command-duration cannot be implemented by a predefined $edit:after-command hook if we want to capture the cost of running the rc script (i.e., the shell.sourceRC function). That capability alone, IMHO, justifies the two lines added to the Go source to support that Elvish namespace variable. I really like seeing the time taken to run my ~/.elvish/rc.elv script in the first prompt.

That's exactly why there needs to be an additional REPL abstraction (I had another comment about this) which will be correct place to test this.

I'm not convinced that is needed or justified. At present the shell.Interact() function is effectively the REPL abstraction. That could be refactored to an explicit REPL abstraction but it's not clear that effort is justified unless we intend to introduce something like a repl: namespace rather than keep after-command and command-duration vars in the edit: namespace. It doesn't seem to me to make much difference where the updates of those vars occurs.
Too, we can add unit tests of these two vars to TestInteract_SingleCommand() by changing the progtest.Setup() function to use a real tty rather than a pipe. Thus causing the shell.Interact() function to construct a normal editor rather than a minimal editor.

I just realized that $edit:command-duration cannot be implemented by a predefined $edit:after-command hook if we want to capture the cost of running the rc script (i.e., the shell.sourceRC function). That capability alone, IMHO, justifies the two lines added to the Go source to support that Elvish namespace variable. I really like seeing the time taken to run my ~/.elvish/rc.elv script in the first prompt.

My preferred solution here is to make the after-command hook run for rc.elv too.

That's exactly why there needs to be an additional REPL abstraction (I had another comment about this) which will be correct place to test this.

I'm not convinced that is needed or justified. At present the shell.Interact() function is effectively the REPL abstraction. That could be refactored to an explicit REPL abstraction but it's not clear that effort is justified unless we intend to introduce something like a repl: namespace rather than keep after-command and command-duration vars in the edit: namespace. It doesn't seem to me to make much difference where the updates of those vars occurs.
Too, we can add unit tests of these two vars to TestInteract_SingleCommand() by changing the progtest.Setup() function to use a real tty rather than a pipe. Thus causing the shell.Interact() function to construct a normal editor rather than a minimal editor.

We don't actually disagree; if you make the necessary changes to make shell.Interact easy to test, then it is a proper REPL abstraction. I use the word "abstraction" pretty loosely.

My preferred solution here is to make the after-command hook run for rc.elv too.

Okay, I can do that. TBD is whether that is a net increase in complexity.

We don't actually disagree; if you make the necessary changes to make shell.Interact easy to test....

Given that we already depend on github.com/creack/pty it should be a straightforward enhancement to the interactive shell test framework. Of course, the fact the current framework uses pipes means "dragons be here" is operative. Which might mean more work than expected to change from pipes to ptys. Still, there is no reason that should not be possible and a net improvement for test coverage.

@xiaq: PTAL. I have more refactoring in mind. For example, the description of hooks should be moved from the edit page to the language page and augmented to include mention of the other hooks (e.g., builtin:after-chdir. I'll also start working on changing progtest.Setup() to use a pty rather than pipes so that a edit:after-command unit test can be written.

@xiaq, this version of the P.R. addresses all your feedback other than the removal of the *Evaler.Editor method. As I explained earlier that never returns a non-nil value and keeping that API greatly complicates this change for no good reason. Not to mention these lines in the type Evaler definition which implies the existing uses should be replaced with a different mechanism:
// TODO: Remove these dependency by providing more general extension points.
daemonClient daemon.Client
editor       Editor

We might want to add "TODO" comments where fm.Evaler.Editor() used to be used but it's far from obvious that would be useful. It seems to me that those two cases should be addressed by open issues explaining how the current behavior is sub-optimal and what might be better behavior.


Move Jenkins Ansible Slave Back to rpm install

Currently using pip install to get a devel release of ansible 2.5. Once 2.5 GA's let's move back to old way
https://github.com/rht-labs/labs-ci-cd/blob/5a952d2af3cba87d9f52c21f0890213a7021cf1e/docker/jenkins-slave-ansible/Dockerfile

Not needed as we're going to point to the cop version; in which this is fixed!


js files generated from tsx are not cleaned by tsc tsc --build . --clean

js files generated from tsx are not cleaned by tsc
tsc --build . --clean
could not find anything about this on the internet

We need you to fill out the template and provide complete repro steps when logging issues. Thanks!


"Snatchers" new creep characteristic request.

Feature request summary
It is often that one sees containers in reserved / unclaimed rooms of other placers, often with a "harvester" creep or a "miner" mining the sources. These containers are often full, and transport is inefficient in distant colonies in other code scripts. This is a proposal to introduce a new creep type that could aid in war, seige and in general resource collection.
While energy is not hard to come by, it would be much harder to destroy an enemy if all of your outposts were being raided.
This creeps name is the "snatcher", its logic works in conjunction with the "scout" class type.
Scouts search rooms for containers, and the "value" of that container based on smart things you do and the energy it contains. If the total value reaches a threshold on distance, a snatcher is spawned to travel there and steal the energy from the hopeless harvesters.
It is essentially an offensive lorry / transport.

This is an interesting Offensive tactic ... I like it.
Could have a flag associated with it that would cause a spawn of the Snatcher.
See also: #180


reduce output of plos lib to connected components

yay!
On Mon, Jan 9, 2017 at 11:19 AM, Brandon Duderstadt <
<EMAIL_ADDRESS>wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/NeuroDataDesign/pan-synapse/issues/12, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AACjcj5INZ3q6tH8TdL-vgFBmFpp7ZO8ks5rQl4pgaJpZM4LecN1
.

--
the glass is all full:  half water, half air.
neurodata.io, jovo calendar
https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York
starting in 2017, i will be responding to emails approximately weekly,
so that i can focus more on the people around me.
thank you for your understanding.


Add integrity check for unzipped contents

Currently, only the integrity of the zip file is checked when downloading. However, once the contents is unzipped into the deps folder, integrity is not checked anymore. If a user were to modify the source files of the installed packages, we would have no way of knowing.
I suggest to add a checksum for the unzipped contents so that integrity can be checked upon updating or installing.

Checksum has been added, now working on integrity validation which seems to work fine!

Rest of the feature is tracked at https://github.com/mario-eth/soldeer/issues/108


Can I implement it on tableview

Hi,
Is there is any way to add CLtimer on tableview cells. I want to hide cltimer when timer is stopped and show another view in the cell . Is that possible
Thanks and Regards

Yes of course it's possible simply take a UIView in your tableview cell and
replace it's class with CLTimer
Step 2 create it's outlet
Step 3 take a unbutton on its action call stopTimer func of CLTimer and
then simply hide cltimer and bring your another view in scene by unhiding
it .
If you still didn't get it then let me know I will provide a sample project
to you .
On Sep 28, 2016 7:36 AM, "jassimkm"<EMAIL_ADDRESS>wrote:

Hi,
Is there is any way to add CLtimer on tableview cells. I want to hide
cltimer when timer is stopped and show another view in the cell . Is that
possible
Thanks and Regards
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ConfianceLabs/CLTimer/issues/2, or mute the thread
https://github.com/notifications/unsubscribe-auth/ATW2pMrvaViNenSEppOymv31dfdz0cSUks5qulFPgaJpZM4KItpR
.

Thanks , I got the point but I want to reload the cell when timer hits zero. I cant use your delegate . The app is crashing when I set . cell.timerView.cltimerDelegate = self


Can't start overlay from background notifications

Hi, I'm trying to connect your package to run in the FCM background notifications, but for some reason it doesn't work, the overlay opens only from the application itself, if you set the await OverlayPopUp.showOverlay(); to a specific button.

@MukolaShiyak  had the same issue. Seems to happen because the activity is null when you call it from background.


Azure discovery - set default subscription ID to NIL

Bug description:
In 5.5 a subscription ID was added as an optional parameter for connecting to the Azure ARM API. If omitted, the azure-armrest gem selected the first active one. However, the Azure Cloud Manager discovery code expected a subscription ID to be supplied and, since it was optional, an error was thrown if the user did not enter one.
Fix:
This PR sets a default value of NIL when making the connection from ManageIQ to Azure.
https://bugzilla.redhat.com/show_bug.cgi?id=1362654

@chessbyte please backport for today's build.


Gracefully handle invalid CMSIS-Pack path with a warning

If you pass an invalid path to the --pack command line argument or pack user option, a warning will be logged but pyOCD won't exit.

/morph test


Retry node when :swarm fails to start

This pull request adds a retry mechanism to allow a newly joined node time to start the :swarm application.
When testing an application that uses Swarm, I noticed the nodeup event was logging a warning when a node joined an already formed and running cluster. This was due to an error when calling :application.ensure_all_started(:swarm) on the starting node. The exception prevented the network topology change function call from occurring on the existing nodes.
Here's the log output before:
[warn] [swarm on<EMAIL_ADDRESS>[tracker:nodeup] nodeup for<EMAIL_ADDRESS>was ignored because swarm failed to start: {:error, {:swarm, {'no such file or directory', 'swarm.app'}}}

Afterwards the retry provides enough time for the node to start Swarm:
[warn] [swarm on<EMAIL_ADDRESS>[tracker:nodeup] nodeup for<EMAIL_ADDRESS>was ignored because swarm failed to start: {:error, {:swarm, {'no such file or directory', 'swarm.app'}}}, will retry in 1000ms..
[info] [swarm on<EMAIL_ADDRESS>[tracker:nodeup] nodeup<EMAIL_ADDRESS>[debug] [swarm on<EMAIL_ADDRESS>[tracker:handle_topology_change] topology change (nodeup for<EMAIL_ADDRESS>[info] [swarm on<EMAIL_ADDRESS>[tracker:handle_topology_change] topology change complete

Note I'm configuring the :kernel application and using sync_nodes_optional to define the available nodes so that a cluster is formed during node startup.

We should make sure that the retry is limited - if a node in the cluster starts but does not run swarm for some reason, this will end up recursing indefinitely. There are other ways to deal with that case, but I think it's reasonable to impose a retry limit of 3-5 attempts, at which point we bail. Thoughts?

Yes, it's sensible to add a retry limit. I will make the change.
I toyed with the idea of sending a delayed message to the Tracker process, using Process.send_after,  rather than blocking it with a sleep. What are your thoughts on that approach?

@bitwalker I've pushed a commit to limit retries. The tracker process is now restricted to ten attempts, with a one second interval between each.

I have a couple of style changes I'd like to make, but I'll just merge this as-is and fix it directly to avoid making you wait. In case you have any future PRs in mind, I always avoid single-piping like function(arg) |> other_fun. In such cases, I prefer other_fun(function(arg)) or arg |> function() |> other_fun() (and typically multi-line for such pipes).
Anyway, thanks for the excellent work!


Define standard package.json structure for extensions

Define a standard package.json structure for Lens extensions. The below example contains mandatory fields with example content:
{
  "name": "@k8slens/extensions-sample",
  "version": "0.0.1",
  "author": "Mirantis, Inc<EMAIL_ADDRESS>(https://k8slens.dev)",
  "publisher": "k8slens",
  "maintainers": [
    {
      "name": "k8slens-bot",
      "email"<EMAIL_ADDRESS>    }
  ],
  "description": "Lens extension sample",
  "repository": {
    "type" : "git",
    "url" : "https://github.com/lensapp/lens-extension-samples.git",
    "directory": "sample"
  },
  "homepage": "https://github.com/lensapp/lens-extension-samples",
  "bugs": {
    "url": "https://github.com/lensapp/lens-extension-samples/issues"
  },
  "engines": {
    "lens": "^4.0.0"
  },
  "license": "MIT",
  "keywords": [
    "example",
    "extension",
    "k8slens",
    "lens",
    "mirantis",
    "tutorial"
  ],
  "main": "dist/main.js",
  "renderer": "dist/renderer.js",
  "scripts": {
    "build": "webpack --config webpack.config.js",
    "dev": "npm run build --watch"
  },
  "dependencies": {
    "react-open-doodles": "^1.0.5"
  },
  "devDependencies": {
    "@k8slens/extensions": "^4.0.0-alpha.2",
    "ts-loader": "^8.0.4",
    "typescript": "^4.0.3",
    "@types/react": "^16.9.35",
    "@types/node": "^12.0.0",
    "webpack": "^4.44.2",
    "webpack-cli": "^3.3.11"
  }
}

It is expected that all of the above fields would be present.

Required vs Optional
Do we really want to require all those fields? Do you really have to have:

keywords
dependencies and devDependencies: You probably would want to have at least one of those to reference the @k8slens/extensions dependency, but since that package only contains typings, and the actual values are injected as globals into the Extension scope, you actually don't need this package, especially if you aren't using TypeScript, provided you use the documentation to know what's in the global scope.
scripts: Would be strange not to have this, but technically, what does this have to do with extensions?
license, bugs, homepage, repository: Unless you intend to pull this into an Extension Page in a Marketplace View in Lens some day, but still, these feel like they should be optional, not required. If no license, you can assume "unlicensed"
description: You could argue this is also optional. The name is the most critical part. If you have this Marketplace with pages for each Extension, similar to VSCode, then as an extension dev, you should want to include a description, but will this affect the functioning of the extension? Probably not.
author, maintainers: This is just metadata...

I would say we're left with these required fields:

name
version
publisher
engines.lens
main
renderer

lensExtension in package.json
I would also strongly recommend that publisher, main, and renderer, which are all Lens extension-specific, should be moved into a common lensExtension section to be grouped together.
Otherwise, if you add more Lens-specific properties in the future, you'll end-up further polluting the standard package.json structure with non-package manager-related properties, all related to one another, scattered throughout the whole file. It could be become a mess...
You might also end-up in a name collision, which you could avoid now, for the future, by moving those properties into a single object.
This is common practice in the greater JS community, see ESLint (key: eslintConfig), Prettier (key: prettier), Babel (key: babel), etc.
Minimum package.json
I would propose that this is the minimum required package.json an extension would need:
{
  "name": "@k8slens/extensions-sample",
  "version": "0.0.1",
  "engines": {
    "lens": "^4.0.0"
  },
  "lensExtension": {
    "publisher": "k8slens",
    "main": "dist/main.js",
    "renderer": "dist/renderer.js"
  }
}

Granted lensExtension could still result in a collision with some new standard package.json property later on, but that seems less likely than the alternative.

I think this can be included in the generator template, I linked this issue to https://github.com/lensapp/lens/issues/1296

I agree that we should only require that minimum set of fields that are required to run extensions properly. So extension developers can easily develop/test extensions with the Lens app.


Add support for variables.

Some pipelines have variables that get set for each run of the analysis and it would be useful to not have to change the commands when this happens.
[COMMANDS]
./somescript -i <some_file> --level {debug_level}

[VARIABLES]
debug_level=1

Currently Paths can be used for this purpose.


Remove automount and projected volume tests

Related to: https://github.com/test-network-function/cnf-certification-test/pull/1384
Essentially the pod-service-account test covers the scenarios we need to cover because it forces users to use a service account that is non-default regardless of projected volume, automount enabled/disabled, etc.

We had a discussion this morning where we might end up keeping around the projected service account test but just flagging instances where the user might be using a default service account token mount.
https://github.com/test-network-function/cnf-certification-test/pull/1385

Closing in favor of: https://github.com/test-network-function/cnfcert-tests-verification/pull/497


Move upgrade out of AWS reference

The upgrading section of this doc should not be there: http://docs.projectcalico.org/v2.1/reference/public-cloud/aws
It should be moved to the feature (in this case, cross-subnet IPIP) documentation.

actually i think there are a number of changes required:

the feature content needs to be removed from the AWS and put in it's own feature documentation (AWS would ref this)
the upgrade section needs to be it's own guide ... but the documentation about setting up ip autodetection should probably also be it's own guide.


Compound bubble updates

Now insets and spacing for compound bubble components are defined on the bubble level, as opposed to the previous method when each bubble could define it's own insets.
Added new struct for providing new configuration CompoundBubbleLayoutProvider.Dimensions
Make bubble components fill all bubble width after determining it's size (by the widest component)
Additional option for MessageManualLayoutProviderProtocol to ignore content insets within the bubble (so component fill all available width - safe insets)

Codecov Report

Merging #587 into master will decrease coverage by 0.31%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   58.55%   58.23%   -0.32%
==========================================
  Files          90       90
  Lines        3812     3824      +12
==========================================
- Hits         2232     2227       -5
- Misses       1580     1597      +17

Impacted Files
Coverage Δ

...dMessage/Content/MessageManualLayoutProvider.swift
0% <ø> (ø)
:arrow_up:

...ems/CompoundMessage/CompoundMessagePresenter.swift
0% <0%> (ø)
:arrow_up:

...poundMessage/CompoundMessagePresenterBuilder.swift
0% <0%> (ø)
:arrow_up:

...s/CompoundMessage/Views/CompoundBubbleLayout.swift
0% <0%> (ø)
:arrow_up:

...ems/TextMessages/TextMessagePresenterBuilder.swift
86.48% <0%> (-1.61%)
:arrow_down:

...eMessage/Views/BaseMessageCollectionViewCell.swift
61.13% <0%> (+0.42%)
:arrow_up:

...ms/TextMessages/TextMessageMenuItemPresenter.swift
58.33% <0%> (+3.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea70f2...8b74037. Read the comment docs.


1.12-rc2 "client is newer than server" error

I installed the 1.12.0-rc2 build of the Docker Toolbox
I provisioned a new Docker Host (on Microsoft Azure) using docker-machine
I attempted to run the docker command line against the new Docker Host
I received the "client is newer than server" error

Any ideas how I can work around that? My docker -v output is below.
PS C:\Users\TrevorSullivan> docker -v
Docker version 1.12.0-rc2, build 906eacd
PS C:\Users\TrevorSullivan> docker-machine -v
docker-machine.exe version 0.8.0-rc1, build fffa6c9

Cheers,
Trevor Sullivan
Microsoft MVP: Cloud & Data Center Management
https://trevorsullivan.net
https://twitter.com/pcgeek86

I also had same issue.
My workaround is to use "--engine-install-url" option.
ex.
docker-machine create -d azure \
                      --azure-subscription-id <subs-id>  \
                      --engine-install-url "https://experimental.docker.com" \
                      <machine-name>

This will install docker v1.12.0-rc2 for target machine.

@yamamoto-febc Thanks, I decided to remove all versions of the Docker Toolbox, and install dvm instead. Apparently I can use this to switch between multiple versions of Docker binaries.
https://github.com/getcarina/dvm

If you do docker version you might be able to see which API versions are running in the client and server, then you can do export DOCKER_API_VERSION=xxx to swap between different API versions.

@zhanghan177 Thanks -- that's a good solution.


chore: add signup flow

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

36 of 79 (45.57%)  changed or added relevant lines in 14 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.5%) to 48.506%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/flows/Signup/PasswordSettingModal/PasswordSettingModal.tsx
4
8
50.0%

src/flows/Signup/SignupScreens/SignupScreens.tsx
3
7
42.86%

src/flows/Signup/SignupWrapper/SignupWrapper.tsx
7
14
50.0%

src/flows/Signup/CitizenshipModal/CitizenshipModal.tsx
7
20
35.0%

src/hooks/useNewVirtualAccount.ts
6
21
28.57%

Files with Coverage Reduction
New Missed Lines
%

src/cfd/modals/MT5PasswordModal/MT5Success.tsx
5
15.79%

Totals

Change from base Build<PHONE_NUMBER>:
-0.5%

Covered Lines:
1387

Relevant Lines:
2321

💛  - Coveralls


Improve documentation

I wish there was a description or video on how to use the "amplification" methods for L4. It is not entirely clear what exactly should be in the reflector file.

https://github.com/MHProDev/MHDDoS/wiki/Amplification-ddos-attack


I am Using ngx-owl-carousel, our client requirement is two rows sliding. is it possible can you please help on this

Our client requirement is like below.can anyone help on this

@ramanjiram yes what you're looking to do is possible using Owl Carousel 2, but GitHub issues isn't really the best place to ask this kind of question, as it's not an issue, as such.
I'd recommend asking on StackOverflow about using Owl Carousel 2, specifically:
https://stackoverflow.com/questions/tagged/owl-carousel-2
Good luck!


ARROW-15436: [Release][Python] Disable verification of gdb tests on windows and a flaky test on apple M1

Commits cherry-picked from https://github.com/apache/arrow/pull/12235

https://github.com/apache/arrow/pull/12253 should eliminate the need of disabling the GDB tests.


GUI new feature use case and test plan drive and execution

[x] Understand new GUI usages
[x] Create test plans
[x] Execute

Thanks @rahulmah for driving the GUI testing activities. This can be closed


[question] Can I use npm or yarn for import javascript and css modules?

Hello!
I'm asking here because I've already searched everywhere with no luck.
I wanted to use npm or Yarn to import and, above all, keep the js and css libraries updated, avoiding having to check and download each time in the relevant folders in "/public".
When I use npm (or yarn), it creates the "node_modules" folder. Is there a way you think I can tell Zend to draw resources from there? How does the "composer" do for the "vendor" folder.
Thanks for any replies.

Search for .yarnrc
You need something like
--modules-folder public/static/components/


Update RegistryCI.jl by updating the .ci/Manifest.toml file (1.6.0)

This pull request updates RegistryCI.jl by updating the .ci/Manifest.toml file.

@DilumAluthge I assume these needs to be merged manually?  CC: @ericphanson

Yeah they need manual merge.


IdentityServerAuthenticationOptions error

Hello, I used identityserver4 as the project's SSO, and I recently wanted to add the api side to the configuration file of appseting.json for IdentityServerAuthenticationOptions. Because I want to implement, I can modify the contents of the configuration file and then switch dynamically
Authority
ApiName
ApiSecret
Without restarting the application
My code is as follows:
services.Configure<IdentityServerAuthenticationOptions>(Configuration);   services.AddAuthentication(Bearer).AddIdentityServerAuthentication();
appseting.json:
"Authority": "https://xxxxx.com/sso",   "ApiName": "xxxapi",   "ApiSecret": "xxx-xxx-xx-xx"
but the api return error
You must either set Authority or IntrospectionEndpoint

Sorry, this is not supported and would be a massive reworking. It's not even clear if all the underlying components we use from ASP.NET Core support this.

So we can't use appsettings to set the IdentityServerAuthenticationOptions? How do we handle different environments?


Ensure analytics.yml keeps pace with changes to the database

Context
We often fail to send new fields to BigQuery, and we sometimes fail to remove old ones.
Add tooling to detect these situations, and specs that fail should they occur.
Changes proposed in this pull request
Maintain a blocklist, which is autogenerated via a rake command, of all the fields we don't send to BQ alongside the list of those we do.
Compare the two lists against the database to make sure everything's covered.
Guidance to review
Take something out of analytics.yml and see the test fail helpfully. Then put a made up field in and see another test fail helpfully!
Link to Trello card
https://trello.com/c/uYwHfFKi/637-create-auto-test-to-ensure-relevant-columns-being-sent-to-bq
Things to check

[X] If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
[X] This code does not rely on migrations in the same Pull Request
[X] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[X] API release notes have been updated if necessary
[X] Required environment variables have been updated added to the Azure KeyVault

This looks great however I wonder if we change our approach to send everything by default, and filter PII data and anything on the block list. This might be an issue in BQ however I wonder if there are any repercussions to sending everything past the ones we block? This means any new fields are sent by default unless we specify otherwise.
The caveat however to that is missing PII/fields we don't want to send. Thoughts?

Fair challenge. I think the current approach has some advantages:
One is that an explicit step is required to start sending data to BQ — rn it's inconvenient to miss something. It would be worse to accidentally send PII or sth. I like forcing a decision whenever something changes.
Another is that having an allowlist allows us to do some integrity checking at the BigQuery level, eg "we're now getting this field according to the app's analytics.yml but we're not transforming it correctly".
And finally it's the way all the apps do it (at least for now) and I'd prefer not to diverge while we're trying to standardise implementations. Once we're standardised, v happy to discuss this again, and we'll have much more leverage to change if we want to?


Track the number of repos that use the json-schema topic over time

We can assess the number of JSON Schema related GitHub repositories over time as a crude metric which will demonstrate the growth in popularity and use of JSON Schema.
We can do this by getting all the repositories with the json-schema topic, and finding out when they were first created.
This will not determine when the first commit of the repository was made, which may be earlier if the repo has commits pushed that are dated before the repository was made on GitHub.
We can plot this data over time.
We cannot directly identify when a topic was assigned to a repository, but we can attempt to identify if the topic was present when the repo was created.
We can make an assumption that the repo was always related to JSON Schema, which feels reasonable.
Here's a list of tasks that should be done in order to close this Issue:

[ ] #4
[ ] #11
[x] #5
[ ] #6
[ ] #7

I want to work on these issues :)
can you please assign before i start ?

Hi, I'd like to work on this if it's still available


Support flipped objects (X and Y)

This is currently unsupported but is readable through the relativeTransform property

Fixed in 1.0.7


Feature/sdk 3

Codecov Report
Attention: 84 lines in your changes are missing coverage. Please review.

Comparison is base (ba38097) 45.89% compared to head (e588a25) 33.48%.
 Consider uploading reports for the commit 94c434d to get more accurate results

Files
Patch %
Lines

...tore/src/migrations/generic/6-CreateXStateStore.ts
39.13%
28 Missing :warning:

.../xstate-persistence/src/agent/XStatePersistence.ts
0.00%
27 Missing :warning:

...es/data-store/src/xstatePersistence/XStateStore.ts
25.00%
18 Missing :warning:

...ations/postgres/1708097018115-CreateXStateStore.ts
22.22%
7 Missing :warning:

...grations/sqlite/1708096002272-CreateXStateStore.ts
57.14%
3 Missing :warning:

...kages/data-store/src/utils/contact/MappingUtils.ts
50.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #160       +/-   ##
============================================
- Coverage    45.89%   33.48%   -12.41%
============================================
  Files           65      157       +92
  Lines         2412     7394     +4982
  Branches       539     1749     +1210
============================================
+ Hits          1107     2476     +1369
- Misses        1305     4917     +3612
- Partials         0        1        +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Okay PR is ready for review. A lot has been changed. The most important part is that the store is agnostic, whilst the xstate-machine-persist plugin is Xstate specific. It accepts Xstate objects. This is different from the original implementation, where the burden would be constantly on the parties calling the plugin to provide all the properties and convert xstate objects to the desired formats. Since that is not a nice plugin from a user perspective it now has been changed to be specific for Xstate.
I still need to create one method for rehydration and continuing the machine interpreter from the persisted state in an easy way. But I will do that when working on the wallet authorization code flow


DnsValidatedCertificate reports DNS zone example.com to be non-authoritative

When requesting a DnsValidatedCertificate using an imported HostedZone (imported with HostedZoneProvider.findAndImport) not previously saved in cdk.context.json, validation fails with error DNS zone example.com is not authoritative for certificate domain name cdn.mydomain.com
Same error is present when requesting the certificate for the root domain name:
new DnsValidatedCertificate(stack, 'MyCertificate', {
    domainName: 'mydomain.com',
    hostedZone,
});

results in: DNS zone mydomain.com is not authoritative for certificate domain name mydomain.com

Anyone else experiencing this too? Seems like an issue with findAndImport specifically, works with a direct HostedZone.import

During weekend I tried project based on CDK examples and it uses that findAndImport (https://github.com/aws-samples/aws-cdk-examples/blob/master/typescript/static-site/static-site.ts) and had same problem
Have to see if import works

I'm having exactly the same problem.

I believe it's caused by this -
const DEFAULT_HOSTED_ZONE: HostedZoneContextResponse = {
  Id: '/hostedzone/DUMMY',
  Name: 'example.com',
};

  public findHostedZone(): HostedZoneAttributes {
    const zone = this.provider.getValue(DEFAULT_HOSTED_ZONE) as HostedZoneContextResponse;
    // CDK handles the '.' at the end, so remove it here
    if (zone.Name.endsWith('.')) {
      zone.Name = zone.Name.substring(0, zone.Name.length - 1);
    }
    return {
      hostedZoneId: zone.Id,
      zoneName: zone.Name,
    };
  }
}

https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-route53/lib/hosted-zone-provider.ts
Seems that it's always using the default.

I've the same problem, anyone found a solution?

I've found the same issue while trying to create some certificates today. The workaround (although not pretty) was to create a separate stack that just imports the hosted zone and makes the imported zone available to pass to other stacks. Then running cdk synth -e HostedZoneStack generates the correct cdk.context.json allowing other stacks containing the certificates to be deployed.
Hosted Zone Stack
import cdk = require('@aws-cdk/cdk');
import route53 = require('@aws-cdk/aws-route53');

export interface HostZoneStackProps extends cdk.StackProps {
    /**
     * Root level domain for the hosted zone
     */
    domain: string;
}

export class HostZoneStack extends cdk.Stack {
    public hostedZone: route53.IHostedZone;

    constructor(scope: cdk.Construct, id: string, props: HostZoneStackProps) {
        super(scope, id, props);

        this.hostedZone = new route53.HostedZoneProvider(this, {
                domainName: props.domain,
                privateZone: false
        }).findAndImport(this, "HostedZone");
    }
}

Example App
#!/usr/bin/env node
import "source-map-support/register";
import cdk = require("@aws-cdk/cdk");
import { ApplicationStack } from "../lib/application-stack";
import { HostZoneStack } from "../lib/hosted-zone-stack";

const app = new cdk.App();

const hostedZoneStack = new HostZoneStack(app, "HostedZoneStack", {
    domain: "somedomain.com"
});

new ApplicationStack(app, "StaticSiteStack", {
    hostedZone: hostedZoneStack.hostedZone, // imported zone passed in the stack props
    uiDomain: "ui.somedomain.com",
    env: {
        region: "us-east-1"
    }
});

I had the same issue and came up with this workaround:
this.hostedZoneProvider = new HostedZoneProvider(this, {
  domainName: props.domainName,
  privateZone: props.privateZone
});

const zone: HostedZoneAttributes = this.hostedZoneProvider.findHostedZone();

this.hostedZone = HostedZone.fromHostedZoneAttributes(this, 'HostedZone', {
  hostedZoneId: zone.hostedZoneId,
  zoneName: zone.zoneName
});

I am not sure was this right thing to do but it works for me. Is there a better solution?

I found, as a workaround, that if the hosted zone reference is still unresolved and contains the dummy values (example.com) you can simply return and wait for the next AppStack synth iteration when cdk will use the HostedZoneContextProviderPlugin to get real values from your account.
Take a look here:
https://github.com/awslabs/aws-cdk/blob/23a143ea34a1654af24bf8c58f73da26136d039e/packages/aws-cdk/lib/api/cxapp/stacks.ts#L205-L207
So a working (boilerplate) solution is:
  const domainName = "foobar.com";

  const zone = new HostedZoneProvider(this, {
    domainName
  }).findAndImport(this, "HostedZone");
  if (zone.zoneName == 'example.com') {
    return;
  }
  const certificate = new DnsValidatedCertificate(this, 'ApiSSLCertificate', {
    domainName,
    hostedZone: zone
  });

Warning: Obviously the given domainName hosted zone should exists in your account otherwise you will get an error like this
Found zones: [] for dns:foobar.com, privateZone:undefined, vpcId:undefined, but wanted exactly 1 zone

Nice workaround @rpanfili, much easier solution to the issue.


IRC Nickname color toggle

A quick workaround for people that might not like the colors in IRC.
Adds a config option to enable IRC colors

Cool! However, ircOptions are passed directly to node-irc (could've had a better name). Would be better to put this as a root option, and name it something like ircNickColor.

Would you want to add a test for disabling colors? This is a good starting point. If you don't have time I can fix it when merging.

Woops! Misread a bit, will add a test and merge this. Thanks!

Released in version 0.7.0, thanks! Set the default to true instead of false, to not break backwards compatibility.


Timestamp updates

Making some changes to improve timestamp type when creating and editing column. On of the commits resolves Timestamp bug with 'Allow NULL' #25 (https://github.com/yoichiro/chrome_mysql_admin/issues/25)

@kunklet Thank you for this contribution!

Released as 4.6.4.


deps: Remove dependency on lodash.merge

See https://github.com/googleapis/nodejs-firestore/pull/648

We also need to re-generate the v1beta1 client.


Error bars

Hello again,
my second question is regarding error bars [1]: does c3 allow to generate them? Again, if this is not the case, consider this as a feature request.
Best regards,
Yakov.
[1] https://en.wikipedia.org/wiki/Error_bar

This will be implemented as a plugin I guess. And this information is helpful for this functionality.
http://qiita.com/ku0522a/items/19934339c69037171b31

@masayuki0812 hi, that's great news!
I'm not sure how to use this coffeescript/how to install this stuff/where to track development until it is implemented as a plugin (and how to install that). Could you please give me an advice about that?

I would really like to have this feature, I am willing to help out on this. Problem is that I feel I have not enough knowledge to do this is a reasonable amount of time. Did someone already start on this? I looked at the two code samples but they are so different. So any pointers would be appreciated.

I'm needing this suddenly, so might spearhead some development in terms of getting it into a plugin. I'm wanting to wrap my head around modularly adding things to C3 anyway, so this might be a good place to start.

This feature would be really useful!

Hi @aendrew , any progress with your idea?

We also need this feature. Any Progress?

I too am looking forward to this feature.


usage / API in README.md?

I was trying to find out what functionality the library provided, but was unable to do so easily.
I checked the root directory README and only found installation directions. I had to manually navigate every folder until I finally found https://github.com/pimoroni/trilobot-python/blob/main/library/trilobot/README.md which had the information I was looking for. I suggest adding at least a Usage section to the root directory README that either links to the useful readme or to demos or something. A usage section for https://github.com/pimoroni/trilobot-python/blob/main/library/README.md would probably also be helpful.

Thanks for the suggestion. I have now added links to the examples and usage readme's in the two places you highlighted.


Taxon constraint:  various

(these were made by a function prediction predictions I'm checking)
Please provide as much information as you can:
Only in metazoa

[x] GO:0001505, regulation of neurotransmitter levels
[x] GO:0005326, neurotransmitter transmembrane transporter activity
[x] GO:0010098, suspensor development
[x] GO:0001775, cell activation (already has never in pombe)
[x] GO:0036051, protein localization to trailing edge

Never in fungi?

[x] GO:0048863, stem cell differentiation
[x] GO:0003365, establishment of cell polarity involved in ameboidal cell migration
[x] GO:0090398, cellular senescence
[x] GO:0000365, mRNA trans splicing. via spliceosome
[ ] GO:0035196, production of miRNAs involved in gene silencing by miRNA

only in myxomycetes 74506

[x] GO:0031154, culmination involved in sorocarp development

[x] GO:0099138, altruistic. chimeric sorocarp development

[x] GO:0031152, aggregation involved in sorocarp development

[ ] GO:0098727 maintenance of cell number. ?

[ ] GO:0009372, quorum sensing

[x] GO:0019270, aerobactin biosynthetic process (only in bacteria)

[x] GO:0016477, cell migration (never in yeast, I seem to remember some fungi that has a flagellum?) (never in ascomycota)

@pgaudet  @balhoff  I just committed these taxon constraints. What  is the other step that needs to happen?

After your changes are merged, then either wait for the GitHub action to run (once per day), which generates the taxon constraints import, or you can kick it off yourself (I can show you how to do that).

@pgaudet Thanks for removing that taxon constraint. What about the protein localization to uropod? Is there an extra issue?

Ah sorry can we add never in yeast
GO:0036051, protein localization to trailing edge
instead

@pgaudet When will these taxon constrains removals go through? I still get automatic emails from ebi every day about these taxon constrains.

This week I hope!


API key set in enviorn variables for non-logged in API calls

Find your legislator page uses the API, and should work while logged in or not

if you give me a key & the name of the environ variable i'll add it

added and calls seem to be working now :octopus:


Add trainer titles for "担当", "専属", and "名手"

These titles indicate how many fans you have for a specific character. Kanji words are often confusing even for Japanese speaker like me

Trainer title
Condition
My translation
Other meaning(s)

(Horse name)担当
Get 10M fans
(Horse name)'s Personal Trainer
being in charge

(Horse name)専属
Get 50M fans
(Horse name)'s Exclusive Trainer
attached to; specialist

(Horse name)名手
Get 100M fans
(Horse name)'s Best Trainer
master; expert

"名手" is usually translated as "master", but "Master of (Horse name)" doesn't fit Uma Musume world, it sounds like FGO lol

I like your translation of 担当 here.
名手 as "Best Trainer" sounds a bit off imo, but i wouldn't know what to use in exchange, since as you noted "Master" sounds like FGO, lol.
For 専属, what do you think about using the other meaning "Specialist", as noted in your post (E.g. "Vodka Specialist")?
I somewhat feel like "Personal Trainer" already implies "Exclusive Trainer", so if "Specialist" also works that may be better ot use here.

Meister Trainer? 🤔
IMO Vodka Master Trainer is totally OK. Master of Vodka or Vodka Master definitely not, as you said there's FGO vibes lol.

I somewhat feel like "Personal Trainer" already implies "Exclusive Trainer", so if "Specialist" also works that may be better ot use here.

I disagree somewhat; personal trainer doesn't imply exclusivity (in the sense that you can have multiple personal trainer for different trainings), but I'm not against Vodka Specialist either. Vodka Specialist Trainer? 🤔

Going for the german "Meister" imo just pushes the problem into another language :P
Another idea is that we transform 名手 into an adjective as opposed to a noun, i.e. "Masterful" instead of "Master".
We could then go with e.g. "Masterful Vodka Trainer", which sounds idiomatic, stays accurate and doesn't have FGO vibes.

I disagree somewhat; personal trainer doesn't imply exclusivity (in the sense that you can have multiple personal trainer for different trainings)

Ah yea, that's true as well. I think "Exclusive Trainer" sounds a lot more clean so if there's no overlap in meaning i'd prefer that.
Regarding the "Specialist" suggestion though, how about using again going for an adjective as opposed to a noun here, e.g. "Vodka-specialized Trainer", maybe?

I have nothing against Best Trainer as well btw; we can merge this PR as is.
@robflop please send request changes if you feel that it should be masterful trainer

Thanks for suggesting. I'm working on it

Thank you 🙇

Same from me, great to have a native speaker of Japanese helping with these titles.
Had been been struggling with em for a while.


Toolbar - Page may not be loaded when extraction request sent

Currently we send the HTML body to the extractor after the page loads but not necessarily before the page finishes being rendered.  This can cause extraction to not extract all terms in the body.
Add a 1 second delay to the scraper.js before sending the request on to give the page time to finish rendering.

completed and added pull request #106

I've only seen this happen once, but so far have not been able to repro it on this fix branch.  Assuming this fixed the issue.


Complete Inst Edit Window Happy Path

[ ] Criteria 1
[ ] Criteria 2
[ ] Criteria 3
[ ] Criteria 4
[ ] Criteria 5
[ ] Criteria 6

Criteria 1
Given:

The Inst edit window is open
The user has entered a valid name into the Inst Name Box

When:

The user clicks save

Then:

The name of the Inst will be set
The new name will be saved to the .yaml IR

Criteria 2
Given:

The Inst edit window is open
The user has entered a valid Inst Format into  the Inst Format box

When:

The user clicks save

Then:

The Inst Format will be set
The Inst Format will be saved to the .yaml IR

Criteria 3
Given:

The Inst edit window is open
The user has entered a valid Instruction Set into the Instruction Set box

When:

The user clicks save

Then:

The Instruction Set will be set
The new Instruction Set will be saved to the .yaml IR

Criteria 4
Given:

The Inst edit window is open
The user has entered a valid Syntax into the Syntax box

When:

The user clicks save

Then:

The Syntax will be set
The Syntax will be saved to the .yaml IR

Criteria 5
Given:

The Inst edit window is open
The user has entered a valid SC Syntax into the SC Syntax box

When:

The user clicks save

Then:

The Syntax will be set
The Syntax will be saved to the .yaml IR

Criteria 6
Given:

The Inst edit window is open
The user has entered a valid Encoding into the Encodings box

When:

The user clicks save

Then:

The Encoding will be added to the Inst
The Encoding  will be saved to the .yaml IR

should encodings be derived from inst format when a new format is added?

Encodings are only derived from the individual instructions for which they are defined.  Encodings won't be tied to an inst format.  Rather, they encode specific data values for a specific field (derived from the format) for a target instruction or pseudo instruction


Problems with Fluent

We are having trouble using this module with Fluent (https://github.com/tractorcow/silverstripe-fluent).
If we try to add a link mapping starting with a locale (e.g. en/example/page.html), the redirection doesn't occur properly and a 404 is returned.
We commented some lines in MisdirectionRequestFilter to make it work properly:
https://github.com/unibz/silverstripe-misdirection/commit/a06a811ed31a53c96d0088fc47cc7f581ec4c7d0
Is there any reason why you are doing the rules check?
In the comments it says:

Bypass the request filter when requesting specific director rules such as "/admin" or "/dev".

but even by commenting those lines of code those routes work just fine.
Do you have any other suggestions on how to fix this?

This was originally built with the intention to prevent users from creating link mappings for things such as /admin, therefore preventing access to the back end. I've now pushed something up to master which will only bypass specific rules, therefore the fluent director rules should now work as expected. I will create a new release soon.


chore(Makefile): update to go-dev 0.17.0

Includes the go 1.7 toolchain: faster, smaller, better. See https://tip.golang.org/doc/go1.7.
Also updates the Docker base image to deis/base:0.3.1.

To work around an issue in Travis CI (DEIS_REGISTRY defaulted to :5000), I added a commit to set it to an empty string before make test build docker-build.


Spec: fix a few builtin type arguments

This fixes a few bugs in the spec relating to builtin type arguments. Mostly these are cosmetic, but the first one makes it look like resizeInteger doesn't have failure conditions, which it certainly does.

Looks good! :)


Organize conversation logs into dedicated directory

This PR:

Creates a dedicated logs/conversations directory for JSON conversation files
Updates .gitignore to exclude JSON files but maintain directory structure
Updates cia.py to use the new directory structure
Keeps the repository root directory cleaner

This change improves the project structure by:

Reducing clutter in the root directory
Providing a dedicated location for conversation logs
Making it easier to manage and backup conversation files
Maintaining cleaner git status output

Abandoning this PR in favor of a cleaner approach


Add an "Edit this Page" link on each doc page

To encourage contribution, each Meshery docs page should have an "edit this page" link that opens to GitHub on the specific page the user is on.

@madhabpaul Are you up to the challenge here?

Yes

Awesome. :)

@madhabpaul, you could do something like:
Edit this Page
using variables like {{.File.Path}} documented here https://jekyllrb.com/docs/static-files/.

Opening up for an easy Hacktoberfest win for someone...

Can i go for it @leecalcote sir?

Absolutely, @Nikhil-Ladha

Thanks, guys. We're able to close this issue with the new docs theme having "edit this page" out of the box.


MINOR: disable flaky Streams EOS integration tests

LGTM

I am just running locally to test a potential fix. If if does not fail within 100 runs it seems to be stable. Usually it fails about 1 out of 30 runs. Should take about 1h to verify.

@mjsax Thanks. I'll hold off merging for now.

Closing this as https://github.com/apache/kafka/pull/3273 got merged.


Add BUILDMODE copy to build args in docker compose for mock tests.

Description: Necessary for changes made to Dockerfile in PR https://github.com/aws-observability/aws-otel-collector/pull/956
Tells the docker compose to copy in the built binaries instead of rebuilding them.

Not entirely necessary if copy is the default.


error: ‘cudnnSetRNNDescriptor’ was not declared in this scope; did you mean ‘cudnnSetLRNDescriptor

cuda8.0.5
in ngraph/src/ngraph/runtime/gpu/cudnn_emitter.cpp
error: ‘cudnnSetRNNDescriptor’ was not declared in this scope; did you mean ‘cudnnSetLRNDescriptor,
if I must use cuda8.0.5，change cudnnSetLRNDescriptor to cudnnSetLRNDescriptor_v6?

change cudnnSetRNNDescriptor to cudnnSetRNNDescriptor_v6 fix this problem

change cudnnSetRNNDescriptor to cudnnSetRNNDescriptor_v6 fix this problem


:new: Support to UIView for Mosaicable

Codecov Report

Merging #20 into master will decrease coverage by 7.55%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage    61.4%   53.84%   -7.56%
==========================================
  Files           7        8       +1
  Lines         114      130      +16
==========================================
  Hits           70       70
- Misses         44       60      +16

Impacted Files
Coverage Δ

Source/Extensions/UIView+Rx.swift
0% <0%> (ø)

Source/Mosaicable.swift
53.84% <0%> (-46.16%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db38d9...d62b0b4. Read the comment docs.


PEX_ROOT doesn't seem to be honoured for all directories.

After setting PEX_ROOT, pex still attempts to write to ~/.pex -- notably trying to create ~/.pex/interpreters.
This is a problem because on our build system the build process's users $HOME is non-writeable.
I suspect that the default values for the flags in pex.py lines 162 and 269 are at fault here; expanding to the $HOME regardless of the PEX_ROOT setting.
(For the time being have worked round this by setting flags explicitly.)
Thanks,
Katie

Sorry for the huge delay, but this issue has been revived through a reference.
How do you set PEX_ROOT? NB: A very confusing aspect of pex is its build time vs runtime behavior.
At build time, if you set PEX_ROOT as an env var or pass the --pex-root flag to the cli, you only set the PEX_ROOT for the build process and not for the runtime of the resulting pex when executed. The pex --help hints at this:
$ pex --help
...
  --pex-root=PEX_ROOT   Specify the pex root used in this invocation of pex.
                        [Default: ~/.pex]
...

So, to set PEX_ROOT at runtime you need to do one of:

Ensure the desired PEX_ROOT environment variable is exported.
Set PEX_ROOT inline if using a shell like bash; ie PEX_ROOT=x ./my.pex ...
Deploy appropriate pexrc files on target machines. These can be in 3 locations:

sibling to the pex file being run in .pexrc
in ~/.pexrc
in /etc/pexrc
Line in pexrc are env-var lines like PEX_ROOT=y and they are read and applied with the precedence above, a sibling .pexrc having the highest precedence.

We currently offer no option to embed the PEX_ROOT setting in the pex at build time since pexes are generally non-machine specific - they can run anywhere; so the PEX_ROOT embedded in the pex if we supported this might not exist or be appropriate on some target hosts.

I'm going to close this as answered, but if the above explanation is unclear or unsatisfactory for your usecase, please re-open.


gen_key failing TypeError and charset arg is also wrong

https://github.com/jthop/flask-api-key/blob/c0d35d3dc39d98befa4ea9ecfe7dc83a12d2f446/flask_api_key/api_key.py#L140
I am using python 3.7
First I got
TypeError: _genword() got multiple values for argument 'length'
I fixed that manually by adding "self" as an argument. You can also make the method static Then I got:
TypeError: _genword() got an unexpected keyword argument 'charset'
The keyword arg is referenced like "charset" but it is "_charset"

Oops this was already raised


open trait default spec fns not visible to exec fn proof

In this example, this definition that appears as a trait default
    open spec fn loyalty_test(&self) -> int
    {
        7
    }

isn't visible to complete this proof:
    exec fn try_get(&self)
    {
        assert( self.bdyf.loyalty_test() == 7 );
    }

Verus gives:
verus --time open-trait-default-spec-fn.rs --crate-type=lib
error: assertion failed
  --> open-trait-default-spec-fn.rs:82:17
   |
82 |         assert( self.bdyf.loyalty_test() == 7 );
   |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ assertion failed

Some degree of trait hierarchy is required to reproduce this. This is a distilling of the failure I have in my real code. I tried a simpler example and it didn't fail.
For some reason github is refusing my .tgz upload, so I'll paste the entire failed code example here.
use builtin::*;
use builtin_macros::*;
use vstd::prelude::*;

verus!{

pub trait Marshal {
    type DV;
    type U: Deepview<Self::DV>;
}

pub trait UniformSized {
}

pub trait IntFormattable : Deepview<int> {
}

pub trait Deepview<U> { }

impl<DVE, Elt: Deepview<DVE>> Deepview<Seq<DVE>> for Vec<Elt> {
}

pub struct IntFormat<T> {
    t: T,
}

impl<T: IntFormattable> UniformSized for IntFormat<T> {
}

impl<T: IntFormattable> Marshal for IntFormat<T> {
    type DV = int;
    type U = T;
}

pub trait SeqMarshal<DVElt, Elt: Deepview<DVElt>> {
    open spec fn loyalty_test(&self) -> int
    {
        7
    }
}

pub struct ResizableUniformSizedElementSeqFormat
    <EltFormat: Marshal + UniformSized, LenType: IntFormattable>
{
    e: EltFormat,
    l: LenType,
}

impl<EltFormat: Marshal + UniformSized, LenType: IntFormattable>
    SeqMarshal< EltFormat::DV, EltFormat::U >
    for ResizableUniformSizedElementSeqFormat<EltFormat, LenType>
{
}

impl<EltFormat: Marshal + UniformSized, LenType: IntFormattable>
    Marshal
    for ResizableUniformSizedElementSeqFormat<EltFormat, LenType>
{
    type DV = Seq<EltFormat::DV>;
    type U = Vec<EltFormat::U>;
}

pub struct VariableSizedElementSeqFormat <
    EltFormat: Marshal,
    BdyType: IntFormattable,
    LenType: IntFormattable,
> {
    e: EltFormat,
    pub bdyf: ResizableUniformSizedElementSeqFormat<IntFormat<BdyType>, LenType>,
}

impl<
    EltFormat: Marshal,
    BdyType: IntFormattable,
    LenType: IntFormattable,
>
    VariableSizedElementSeqFormat<EltFormat, BdyType, LenType>
{
    exec fn try_get(&self)
    {
        assert( self.bdyf.loyalty_test() == 7 );
    }

}

}

Perhaps related to #1235

Can you try this branch: https://github.com/verus-lang/verus/tree/trait-impl-projection-trigger

oh yeeeeah, that is delightful. It corrected my test case (above) and also fixes the lines in my big project where I had to temporarily assume. Thank you!

Fixed by https://github.com/verus-lang/verus/commit/50d07b5fe4465fed8b76f4d050c945ba5dd17141


Decode kernel time to user time

DecodeKtime() snippet is take from tetragon. Refer

Can you create an issue first to describe the bug?

Can you create an issue to describe the bug?

@cfc4n , Thanks for letting me know. I just created an issue with details.
Feel free to ask follow up questions.
Thanks Again :).
Refer: #420

LGTM


fix typo

I'm submitting a PR to fix room.ts doc. typo
[ ] Bug Fix
[ ] Feature
[x] Other (Refactoring, Added tests, Documentation, ...)

Checklist

[ ] Commit Messages follow the Conventional Commits pattern

A feature commit message is prefixed "feat:"
A bugfix commit message is prefixed "fix:"

[ ] Tests for the changes have been added

Description
please describe the changes that you are making
for features, please describe how to use the new feature
please include a reference to an existing issue, if applicable
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Thanks!


Sponsorship policy

In a recent transfer, the project was having a sponsorship link to a personal sponsor account. What should be our policy for sponsorship links?
Personally I would prefer dropping any sponsorship link or to create one for the organization - but that will require some management.
cc @jupyterlab-contrib/members

Allowing sponsorship for projects which are actively maintained by the author may be a good thing as it encourages maintenance contributions from developers who do this outside of their 9-5 job. Still, it may be good to set some rules, like only allowing "thank you" sponsorship links (rather than "pay me to fix this bug"), and ensuring that the link is described accurately as benefiting a specific maintainer, and not affiliated in any way with this organization. We could also require that if present, these are placed in a dedicated section in README with some template text to explain the situation.
As for the recent transfer case, here it is a clear case for removal as the author stated that they do not have time to maintain the project.
That said, I would be also fine with setting a policy to "no sponsorship links" in the short term until we have a consensus on how to allow them.


Add .env line to blog tutorial

When I was trying out the blog tutorial for the first time, I got stuck at the step where I followed every step very cautiously but I ran into an error where no database URL was defined in the prisma schema, which gets it from an env variable called DATABASE_URL.
This was an easy fix (copying .env.example to .env), but would definitely hinder first time JavaScript users in what is supposed to be a begginer friendly tutorial.
This is what the error looks like:

While this is an easy fix with a bit of googling, it might be fairly intimidating to the target audience.

It seems like the remix.init didn't run (this mostly is because you didn't install all dependencies).
If you run npx remix init, the .env file should be created.

I see, thanks!


Issue with the last release

Hey, i wanted to test the lastest version of your project Nucleus coop, the "release 2.0 Alpha 6". When i want to start the game with 2 players an error message pop up which says it's impossible to start the program because of some "app" (don't know what it is) missing :

MSVCP140.dll

VCRUNTIME140.dll

again the same file missing VCRUNTIME140.dll

and then again MSVCP140.dll

All these error messages end with saying that "i should try to reinstall these "app" to fix this problem"
(sorry for all the error message box in french but i tried to sum it up the best i can)
Thanks for your future reply and i hope you will help me to cross this hurdle! Thanks again.

I had the same issue. Grab and install both of those files if you have an 64-bit Windows.

Hey thanks for replying! Can you tell me how/where do i get these files ? Thanks again!

Sorry about that:
https://www.microsoft.com/en-us/download/details.aspx?id=48145


Add support for credential persistence

PR Summary

[x] Add an -Authentication parameter to the Register-PSResourceRepository
[x] Add an authentication dimension to the PSRespositoryInfo object
[x] The -Authentication parameter will take a hashtable which specifies the vault and secret where the credential is stored
[x] Detailed error messaging to indicate why authentication failed (SecretManagement wasn't installed, no vault was available, the vault couldn't be reached etc.)
[x] Since not all repositories requires authentication (principally PSGallery) PowerShellGet will not take a dependency
on SecretManagement
[x] When <x>-PSResource is called and the prioritized repository is determined, a check will also be made to the Authentication property

PR Context

Add functionality for supporting credential persistence as discussed in issue #330.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Documentation needed

[ ] Issue filed:

User-facing changes

[ ] Not Applicable
OR
[x] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively

Cmdlets have been tested manually due to the private feed requirement

OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[ ] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary.

Thank you @alerickson! Please let me know if you have any questions.

I didn't get to this PR this week, but will make it a high priority to review early next week.  Sorry for the delay.

Thank you @PaulHigin for the feedback! Sorry I was away for a few days but I will try to get your suggestions implemented and pushed hopefully by EOD tomorrow.

I already verified PSCmdlet.InvokeCommand.InvokeScript() works last week but I still need to spend some time on error messages.
I will rename the parameter and change the type it expects.
Just to make sure I'm understanding the -PersistCredential proposal:

Have a parameter set for the combination of -ProxyCredential and -PersistCredential
If -ProxyCredential is provided by itself, proceed as it is now, i.e. don't save the credential anywhere
If both are provided, call SecretManagement\Set-Secret with the credential and authentication info passed in

Is this correct? If so, do we want to maybe take in only the VaultName and use the username from PSCredential as the secret name? Because when it's time to pass credential into the Nuget library call, we are assuming SecretName is the username.

@cansuerdogan
I think we still need to talk through the proposals, and decide on how to proceed.  We hope to do this internally (early) next week, and then I think it would be good to have a live chat with you, if you are available.  In the mean time it may not be worthwhile to make too many code changes.  My aim is to soon have a list of action items that we all agree on.

Hi @alerickson, @anamnavi and @PaulHigin,
It has been a while sorry! I can finally get back to working on this pull request. Do you still have the notes from our meeting by any chance?
Here is what I remember:

Parameter name will be changed to CredentialInfo
I will be adding a concrete type for CredentialInfo which will have the following:

String VaultName
String SecretName
PSCredential Credential

Register-PSResourceRepository will at the very least take VaultName and SecretName as part of CredentialInfo, but optionally, users can also pass in a PSCredential to save the secret in the provided vault

If only VaultName and SecretName are passed in, PowerShellGet will NOT print out a warning regarding SecretManagement setup since this can come later
If additionally a Credential is passed in and SecretManagement setup is wrong or incomplete, PowerShellGet will throw a terminating error and will not register the repository

We will keep the PowerShell Invoker implementation for importing and using SecretManagement as part of PowerShellGet but try to add more meaningful error messages where things may go wrong

Are these accurate? Please let me know if I'm missing anything or misremembering any part.
Thank you!

Hi @cansuerdogan just wanted to check in.  We are targeting mid December for our next release, with all changes in by the end of the month so we can have a couple weeks to do manual testing and validations.  This PR certainly doesn't need to be in by then, but I just wanted to keep you updated.

Hi @alerickson! I had some time off in between so I wasn't able to get back to this PR sorry. Can you please confirm if what I remembered from our discussion (summarized in this comment) was correct? If so I'll get started on those changes and we can sync up after I have them implemented. Thank you!

Thanks @cansuerdogan your notes from the meeting all look correct, thanks for following up! It would be awesome to know when you may have a chance to return to this work--thanks so much!

@SydneyhSmith Sorry for the delay on this! I will try to finish this up by end of next week.

Thanks for the update @cansuerdogan, we are planning for a new release on Wednesday (12/2, so it would need to be in this week) so we might not be able to fit it in that release but will shoot to include it in the next release earlier in the new year! Thanks so much!

Thank you for the heads-up @StevenBucher98 ! Good luck with the new release!

Thank you all for your guidance and collaboration!


Would like to merge master and arm64 branches and add version selection option to config

Dealing with merging changes from upstream master and arm64 branches into my master and arm64 branches has been a major headache. I either need to stick to the arm64 branch or add a version selection option. Or figure out how to cherry-pick commits so I only merge the necessary commits.


Removed superfluous python-xlib dependency

Addresses #198.
This was a feature released in 1.3.0 (see changelog), but then regressed by a merge request in 2.0.1, #116
Someone must have realized that this replacement method was a bad idea, because the current branch is back to using the i3/sway --get-socketpath method. This revert was however incomplete, as the method added to #116 still remains, along with the python-xlib dependency.
Anyhow, the pull request purges any use of python-xlib. It's still used in testing, but there the package is separately installed when creating the docker testing image.
TL;DR: Don't accept pull request by script kiddies that address non-existent issues, regress features, and add package dependencies; all in the name of "removing a subprocess call" by replacing it with 5 method calls to python-xlib.

Ok it's probably better this way.


Join the competition! https://lmsys.org/blog/2023-05-03-arena/

LMSYS org was rolling out some serious back to back battle between LLMs, I would like to see Flamingo & Otter's debut there +1

Makes sense, but more correct is OpenFlamingo vs. Otter 😝


Fix session token capturing behavior when Account default is Session

This fixes #33797
Description
Fixes #33797 - when CosmosClinetBuilder.consistencyLevel is not specified, currently for accounts with default consistency level SESSION no session tokens are captured (effectively use eventual consistency). The expected behavior would be to honor the account default consistency (SESSION) and capture session tokens.
All SDK Contribution checklist:

[] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.


Setting up kerberos

Hello!
I can't figure out how to set up kerberos authentification in xrdp. Can anyone point me to instructions on how to configure xrdp to work with kerberos?
Compilled with kerberos support enabled:
xrdp -v
xrdp 0.9.9
A Remote Desktop Protocol Server.
Copyright (C) 2004-2018 Jay Sorg, Neutrino Labs, and all contributors.
See https://github.com/neutrinolabs/xrdp for more information.
Configure options:
--enable-kerberos
User has valid ticket, but when trying to login always getting the following in xrdp-sesman log:
sesman: error while getting initial credentials in k5_kinit
When compilled without kerberos support FreeIPA users are able to login fine after entering their username/passwd

Hi
there are several levels where kerberos can be used for several level to
achieve.
For XRDP:

xrdp auths the user with kerberos (validation from login/pass to get
credentials from KDC)
xrdp use pam which is configured to use kerberos to verify the
login/pass is valid (same as first , but pam is configured to do it.)

it's the only level you will be able to get Kerberos working. This is
not a limitation from xrdp, but from RDP  protocol.
The kerberos support available in RDP since 2008 is only used at NLA
level, to authenticate the server. The authentication of the user is
still "classic", as far as today.
(And for the moment, there is no NLA support for xrdp)
Emmanuel Blindauer
Le 04/04/2019 à 12:35, skirriks a écrit :

Hello!
I can't figure out how to set up kerberos authentification in xrdp. Can
anyone point me to instructions on how to configure xrdp to work with
kerberos?
Compilled with kerberos support enabled:
xrdp -v
xrdp 0.9.9
A Remote Desktop Protocol Server.
Copyright (C) 2004-2018 Jay Sorg, Neutrino Labs, and all contributors.
See https://github.com/neutrinolabs/xrdp for more information.
Configure options:
--enable-kerberos
User has valid ticket, but when trying to login always getting the
following in xrdp-sesman log:
sesman: error while getting initial credentials in k5_kinit
When compilled without kerberos support FreeIPA users are able to login
fine after entering their username/passwd
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/neutrinolabs/xrdp/issues/1328, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmXXXGXlaPZb4Bdj_rNapsYBrFneN_iks5vddVYgaJpZM4cceBB.

Thanx for your answer. This mean that configuring kerberos will not provide any advantages for me since pam works perfectly with entering login & password, but are there any methods or future plans to implement SSO for transparent logins of users to remote desktops?

@puneet336 - having a kerberos token won't currently provide SSO as we don't support NLA yet.
If you want to use kerberos for authentication (e.g. as part of an Active Directory or FreeIPA domain), it's best to build with PAM support and access your KDC that way.

Thank you for the response, i am having issues with PAM version as well.
Will open a new issue .

I'll close this one - it seems pretty dead.


QA-451: testing: implement san logfile reading in testing.js

Scope & Purpose
Manage server *san logfiles through testing.js

read the *SAN configurations from the environment on start
When launching the servers, prepare an individual SAN-environment that puts the logfiles in the servers respective directory.
on shutdown, check for these files, if they are there utilize the CRASH-mechanismus to represent their result to the testresults.

San reports written by the testing.js-arangosh itself (and thus executed test-files) will not be recognized by this PR.

[x] :pizza: New feature
[ ] Backports

[ ] Backport for 3.11: (Please link PR)
[ ] Backport for 3.10: (Please link PR)
[ ] Backport for 3.9: (Please link PR)

Related Information

[x] GitHub issue / Jira ticket: https://arangodb.atlassian.net/browse/QA-451

https://jenkins01.arangodb.biz/job/arangodb-ANY-linux-san.x86-64/1949/ *san run


Browse object history fixes

Previously, I though ⌘[ was only meant to be used for going to the 'last' object (hence the name of the branch) but it turns out ⌘[ and ⌘] are supposed to allow you to travel back/forward through your last (20, or could be 50?) objects.
The commits here now fix this.
Definitely a REALLY handy feature - if you want to go back to that object you were using 2 minutes ago just hit ⌘[ a few times :D

It has always bugged me that this didn’t really work. I know @neurolepsy made some changes that helped earlier this year, but it was still problematic (and would never go more than one object back).
I’ll take a look tomorrow morning. One thing that bothered me even when it was “working”: It would take you to the last object that was in the first pane, not the last object you did something with. So fictional example, if you typed TX quickly and the initial T brought up TextEdit, while TX brought up TextMate, the previous object would be TextEdit even though you never did anything with it. Did you fix that? :-)

I considered changing the history so that it only included the last objects
acted on - that's what I thought it should be like, but I decided against
this.
Since you can go back 10+ times in history, I didn't think it'd be much of
a problem keeping the old behaviour in.
It means that if you're browsing with QS you can go back to wherever you
were previously. Give it a try and you'll see that, now that it actually
works, the it probably won't bug you as much :)
P.S. I probably shouldn't have issued a pull request for this. I guess we
need to focus most attention on getting 63 out the door before we start
looking at other things
On 14 November 2011 04:36, Rob McBroom <
<EMAIL_ADDRESS>
wrote:

It has always bugged me that this didnt really work. I know @neurolepsy
made some changes that helped earlier this year, but it was still
problematic (and would never go more than one object back).
Ill take a look tomorrow morning. One thing that bothered me even when it
was working: It would take you to the last object that was in the first
pane, not the last object you did something with. So fictional example, if
you typed TX quickly and the initial T brought up TextEdit, while TX
brought up TextMate, the previous object would be TextEdit even though you
never did anything with it. Did you fix that? :-)

Reply to this email directly or view it on GitHub:
https://github.com/quicksilver/Quicksilver/pull/573#issuecomment-2726655

P.S. I probably shouldn't have issued a pull request for this. I guess we need to focus most attention on getting 63 out the door before we start looking at other things

I agree :-)

Since you can go back 10+ times in history, I didn't think it'd be much of a problem keeping the old behaviour in.

Well, that’s true. If I can go back more than 1 item, maybe it won’t be as annoying. I’ll try it in practice before I complain about it.

I haven't tried this, I'm just wondering:
What happens with this when using text mode or the calculator? Is each character an object on its own? Or is the finished text the only object in the history?

What happens with this when using text mode or the calculator? Is each
character an object on its own? Or is the finished text the only object in
the history?

I haven't considered text mode. I'll give it a play after bisecting the
master :) It'd be simple enough to do
if(previous history item was text mode with almost the same characters as
this one)
remove the old one and add this new one
On 14 November 2011 15:21, Henning Jungkurth <
<EMAIL_ADDRESS>
wrote:

I haven't tried this, I'm just wondering:
What happens with this when using text mode or the calculator? Is each
character an object on its own? Or is the finished text the only object in
the history?

Reply to this email directly or view it on GitHub:
https://github.com/quicksilver/Quicksilver/pull/573#issuecomment-2731577

It'd be simple enough to do
if(previous history item was text mode with almost the same characters as this one)
remove the old one and add this new one

Or even simpler, don’t store it in the history unless the user runs an action on it. ;-)

I just tested this and it's pretty cool.
The text thing is not a problem. It's only one object.
But of course it only works with an English keyboard setting. When I have my keyboard set to German, [ is produced by ⌥5, so the shortcut would be ⌘⌥5. And of course that doesn't work. :-/

But of course it only works with an English keyboard setting. When I have my keyboard set to German, [ is produced by ⌥5, so the shortcut would be ⌘⌥5. And of course that doesn't work. :-/

Any ideas on what we could change the keyboard shortcuts to then? Would  ⌘< and ⌘> work for your keyboard layout?
If not, maybe we should use ⌘- and ⌘+
Or, to fix this and all the age old problems people are having, we should just switch to an English keyboard when QS is activated... :)

I’ll try it in practice before I complain about it.

Mostly I just think “What? When did I ever have that up?”. And I feel like I have a vague idea how many objects back something will be if I intentionally looked for it. Seems like it would make things easier to find.
Can we add a checkbox to the preferences that makes it only add an object to the history when you “use” it? :-)

Can we add a checkbox to the preferences that makes it only add an object to the history when you “use” it? :-)

...I'm not going to :)
I honestly think that this 'feature' will save people so much time. I didn't describe a very good example earlier on.
Here's a better one:
I'm typing to search in the 1st pane to find address book. I accidentally mis-type (typo) 'adf' instead of 'add'. Instead of having to go back and type everything all over again, I just hit 'back' once then start from where I left off.
This is a really simple example that probably isn't that useful anyway, but I often find myself accidentally doing something that means I 'lose' the folder I've browsed to in the 1st pane - e.g. QS window deactivating, typos, etc. If I've spent 'ages' browsing through Quicksilver, I don't want all my work to go to waste because of a single slip up. It's kind of like an 'Undo' feature.

P.S. just wondering Rob if what I'm saying makes sense. Just another thing to elaborate on.
If I search for 'a  d  d' you DON'T get 3 objects added to the history, one for 'a', on for 'ad' and one for 'add'. It's only for objects acted upon or ones that you have browsed through with the arrow keys

Hmm. I’ll do some more testing. But I just brought up a remote host named t-corp-webap-01 (using ‘twe’) and when I hit ⌘[, it shows me Twitter.app, which I haven’t done anything with all day (it is the first result for ‘tw’ though, which I don’t think is a coincidence).

Just noticed you had two posts there…

This is a really simple example that probably isn't that useful anyway, but I often find myself accidentally doing something that means I 'lose' the folder I've browsed to in the 1st pane - e.g. QS window deactivating, typos, etc. If I've spent 'ages' browsing through Quicksilver, I don't want all my work to go to waste because of a single slip up. It's kind of like an 'Undo' feature.

Yes, that happens to me all the time when browsing folders, so that’s a good example. But I would count arrowing into something as “using” it. Also, this is my fault for having “Switch to text mode if no match is found”. Without that, couldn’t you just go back with the left arrow? Or wait a second and start typing again, knowing that as long as you don’t dismiss the interface, the matching will continue to happen in the current “folder”?


Escape filename in glob in ConfigMixIn (#2136)

Call glob.escape on filename to handle any unsafe characters prior to
globbing.

I cannot replicate the issue locally.  Trying to figure out why this is failing.

@kddejong Are you saying you weren't able to reproduce this even with the details I gave in the issue here? https://github.com/aws-cloudformation/cfn-lint/issues/2136

Here is the issue from what I can tell test/fixtures/templates/public/*.yaml is becoming test/fixtures/templates/public/[*].yaml which is resulting in the * not being expanded.

Going to close this one.  We can re-open as needed.