ES6 refactoring is deleting the comments above

Issue Type: Bug
When the lines above the code that is subject to ES6 refactoring are comments, VSC deletes them. If there is actual code, followed by comments, followed by code subject to ES6 refactoring, the comments inbetween are deleted as well.
Example image
VS Code version: Code 1.22.1 (950b8b0d37a9b7061b6f0d291837ccc4015f5ecd, 2018-04-06T02:26:57.615Z)
OS version: Windows_NT x64 10.0.16299

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4700MQ CPU @ 2.40GHz (8 x 2394)

Memory (System)
5.91GB (2.34GB free)

Process Argv
C:\Program Files\Microsoft VS Code\Code.exe D:\Documents\Kod\Web Dev\Resources\html5-boilerplate6.0.1\doc\html.md

Screen Reader
no

VM
0%

Extensions (8)

Extension
Author (truncated)
Version

vscode-eslint
dba
1.4.8

auto-rename-tag
for
0.0.15

python
ms-
2018.3.1

vscode-code-outline
pat
0.1.0

vscode-icons
rob
7.22.0

sass-indented
rob
1.4.8

code-settings-sync
Sha
2.9.0

jinja
who
0.0.8

(1 theme extensions excluded)

Thanks! Opened https://github.com/Microsoft/TypeScript/issues/23236 to track this upstream


fix: CI: Add owner name to cluster name

Description
This attaches the (sanitized) owner name to the cluster name; this does not remove the existing owner label on the cluster.
Motivation and Context
This is necessary because we don't get any information other than the cluster name with looking through DNS record sets; so we need something there to be able to identify entries that are safe to remove.
How Has This Been Tested?
Deployed locally a few times (via GitHub Actions, of course).
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code has security implications.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I would also prefer not relying on the cluster name for DNS; however, as far as I can tell we don't have any other way to tie a DNS entry to an already-deleted cluster.  It should (but doesn't) have any way to attach tags to the record.


add hascal programming language

Hi.I added link of hascal programming language repo in end of index.md file in programming languages collection.

Hi @hasan-kashi thanks for the contribution ❤. Unfortunately, as per our contribution guidelines, we don't allow self promotion if you are a maintainer of the project:

Maintainers of a project cannot add a topic or collection for their own project. If a topic is popular enough to warrant inclusion, someone else will add or improve it.

We do this so that project get curated if there is enough support/activity in the community. Thank you!

Hi @hasan-kashi thanks for the contribution ❤. Unfortunately, as per our contribution guidelines, we don't allow self promotion if you are a maintainer of the project:

Maintainers of a project cannot add a topic or collection for their own project. If a topic is popular enough to warrant inclusion, someone else will add or improve it.

We do this so that project get curated if there is enough support/activity in the community. Thank you!


Request: Capture system audio

This is awesome so far! I would like the ability to choose to capture system audio as well though!

An attempt at this is in 1.0.8 on windows only.


Update resin-compose-parse dependency version

#882

@flesler you should probably do a fresh npm i and then npm run build once again.
This will probably install an updated prettier version and update the source formatting so that catch-uncommitted will not find anything different when building on travis.
@pimterry Maybe we should pin prettier dependency with a ~ so that we don't have to pollute unrelated PR diffs whenever prettier changes its mind on something.

@thgreasi thanks, I did it but still failing.
This is still failing (https://concourse.ci.resin.io/builds/19097) it doesn't seem to be due to this PR per-se. It's only the dependency change and the version is indeed published on NPM. cc @pimterry

Seems like AppVeyor simply takes forever to build, will have to wait for it to finish then

Tested on staging, results here: https://github.com/resin-io/resin-api/issues/1011#issuecomment-393985376


Acknowledge multiple component creation strategies

RE: https://gitter.im/lhorie/mithril.js?at=58db36d2ad849bcf422cb1e7
CC @tivac @calainos

LGTM

There's no need to install different sets of tools to make different flavors work

This is only true if you target ES6 browsers (or define constructors/prototype manually)...

@pygy good point!  Updated.

Here we go, thanks for the catch, and for the patch!


question about sequential edit using SERAC

Hi, I have some questions about sequential edit using SERAC
I set keep_original_weight to False for sequential editing, but I noticed that self.alg.cache_inputs always has one item during editing.
https://github.com/zjunlp/EasyEdit/issues/32#issuecomment-1734778867
for code,
https://github.com/zjunlp/EasyEdit/blob/13dd1e07812d6ad55578bed0510a67e4b2e594a2/easyeditor/models/serac/serac_main.py#L165
line 165 return new_model and new_model.cache_inputs add new edit item and keep edited items
but new_model.cache_inputs  didn't update to self.alg.cache_inputs
i try to add some code here
https://github.com/zjunlp/EasyEdit/blob/13dd1e07812d6ad55578bed0510a67e4b2e594a2/easyeditor/models/serac/serac_main.py#L196
  if keep_original_weight:
      self.alg.cache_labels = self.alg.cache_labels[-1:]
      self.alg.cache_inputs = self.alg.cache_inputs[-1:]
  else:
      self.alg = new_model
      self.alg.replacement.to(torch.device(f'cuda:{self.params.device}'))
      self.alg.classifier.to(torch.device(f'cuda:{self.params.device}'))
      gc.collect()
      torch.cuda.empty_cache()

After adding the code, I found that sequential editing works fine.
btw, someone in the issue encountered an OOM problem. I found that adding the following code after editing can solve the OOM problem.
gc.collect()
torch.cuda.empty_cache()

Please check if this is a problem
looking forward to your reply, thank you!

Thank you for your attention, what you mentioned is indeed a current defect. An your code is correct.

      self.alg = new_model
      self.alg.replacement.to(torch.device(f'cuda:{self.params.device}'))
      self.alg.classifier.to(torch.device(f'cuda:{self.params.device}'))
      gc.collect()
      torch.cuda.empty_cache()

OOM comes from when calculating embedding similarity, serac calculates all embeddings in one batch, so it will cause OOM after nearly a hundred edits. This is a problem with serac's original code. We will improve this part as soon as possible, thank you for your attention
At the same time, I also recommend that you explore this feature. You are welcome to provide the corresponding PR.

hi, have you solved your issue？


Spelling mistake fix

Codecov Report

Merging #1807 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1807      +/-   ##
==========================================
- Coverage   75.14%   75.12%   -0.03%
==========================================
  Files          76       76
  Lines      125210   125169      -41
==========================================
- Hits        94092    94030      -62
- Misses      31118    31139      +21

Impacted Files
Coverage Δ

src/if_py_both.h
75.31% <0%> (-0.71%)
:arrow_down:

src/message.c
68.27% <0%> (-0.46%)
:arrow_down:

src/if_xcmdsrv.c
85.18% <0%> (-0.19%)
:arrow_down:

src/os_unix.c
58.67% <0%> (-0.15%)
:arrow_down:

src/channel.c
83.8% <0%> (ø)
:arrow_up:

src/window.c
81.82% <0%> (+0.09%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83fe75...49771ab. Read the comment docs.

Why did you close this?  Should the fix be included or not?

Ah, I see you created another pull request for the same patch.

I had made a spelling mistake in my commit message... quitte ironical ! I will also edit the same wile with the ISO encoding.
Max
Le 1 juil. 2017 à 18:22 +0200, Bram Moolenaar<EMAIL_ADDRESS>a écrit :

Ah, I see you created another pull request for the same patch.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


Refactor compiler's make_append to handle more than one dimension

This PR is a small refactor to the make_append function in the compiler module.  Previously, this function assumed that the input data structure for all glyphs was 1-dimensions (e.g. a DataFrame).  Because trimesh doesn't fit this assumption, there was special-casing logic in make_append to check if the glyph was a Triangle.
With this PR, each glyph has an ndims property that indicates the number of dimensions required to index into the data structure that the glyph is built from.  Currently, this value is 1 for all of the glyph except Triangle, in which case it is None.
When quadmesh is added, it will have an ndims value of 2. If the raster functionality is ported to the glyph framework, then it would have an ndims value of 2 as well.

Looks good, thanks!


double-beep: Blacklist green\Wvibe\Wketo

double-beep requests the blacklist of the keyword green\W*vibe\W*keto. See the MS search here and the Stack Exchange search here.

green\W*vibe\W*keto has been seen in 15 true positives, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Resizing stack browser window messes up slice indicator location on canvas

From @dosumis on July 11, 2017 13:35
Slice position indicator has wrong size  / X-Y position after resizing stack browser window
e.g. see:

Copied from original issue: VirtualFlyBrain/geppetto-vfb#54

Size Is all wrong on Half Brain - I'm working on this the maths is off somewhere.

From @dosumis on October 24, 2017 14:32
This is a more general issue  with scaling.  Needs to be documented: #81

From @dosumis on November 21, 2017 14:39
This should be documented as a known issue for VFB 2.0 release as we don't plan to fix it in time.


preflight: support setting up custom repo for ubuntu

Add custom repository configuration for ubuntu.

@guits  Sorry, I added a commit message and a sign-off

@ycy1766 can you squash your commits? thanks!

I will close this PR and edit it to re-open PR


Feat/orchard step refactor and endpoint implementation

Description
There's no Jira issue linked to this PR.
Some possible improvements that can be made to the orchard step of the registration flow were identified during the discussion regarding step 5's rework. This separate task was created to reduce the scope of work for the next task.
Please don't be discouraged by the number of lines added, it's a huge number due to file name changes.
Summary of Changes

Stash parent tree table to frontend/src/components/SeedlotRegistrationSteps/ParentTreeStep/Tabs/legacy for future usage, all credits goes to @mgaseta 🎖
Improve code readability and understandability. e.g.

change applicantInfo endpoint from /api/application-info to /api/applicant-info
change some type definitions' name that are the same as some components'
replace the usage of var with let in tests

seedlot species is now a prop that can be shared via the registration form component
use dynamic rendering in the Orchard step for components that are intended to be hidden in some cases, instead of using styles display: none
restructure the state object for Orchard step

instead of 2 hard coded orchard inputs, we can have an arbitrary number of orchards so the code is more robust, it is capped at 2 at the moment

implement /api/orchard to webapp, so user can type orchard id and retrieve orchard name

you'll have to click out of the input once finishing typing so the onBlur function can be triggered, using on blur is apparently recommended

add loading & error messages for Orchard Name
add new component InputErrorText, takes a single prop description
update all tests that are affected by these changes
Screenshots for the orchard id flow:

Initial stage

Not found

Loading

Loaded

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Test locally and manually
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend
Frontend
Oracle-API
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Unfortunately I have to delete the legacy(Parent tree table implementation) folder because it won't pass sonarcloud quality gate

Unfortunately I have to drop the legacy folder(parent tree implementation) since it does not pass the quality check from SonarCloud


Add signature to Capacity Increase Roadmap 2015-12-21

If you would like to add your signature in support of the Capacity Increase Roadmap 2015-12-21 page on the bitcoincore.org website, please add your name and company and position if applicable in a comment below. If support is from the company as a whole please make that clear.
For discussion, please visit the Bitcoin Core Slack group rather than this ticket. To sign up, visit here.

Chris Arnesen (individual)
On Tue, Jan 19, 2016 at 7:39 AM ฿tcDrak<EMAIL_ADDRESS>wrote:

If you would like to add your signature in support of the Capacity
Increase Roadmap 2015-12-21
https://bitcoincore.org/en/2015/12/21/capacity-increase/ page on the
bitcoincore.org website, please add your name and company and position if
applicable in a comment below. If support is from the company as a whole
please make that clear.
For discussion, please visit the Bitcoin Core Slack group
https://bitcoincore.slack.com/ rather than this ticket. To sign up,
visit here https://slack.bitcoincore.org.
—
Reply to this email directly or view it on GitHub
https://github.com/bitcoin-core/website/issues/53.

Shangzhou Wu (individual)

ACK statement

Updated in 59ce012

Andrew Poelstra

Paul Sztorc

Kawal Singh

updated in feadea60d3d86ab1a27671a8b1e130b584c23773

Please remove "For more information, please see the FAQ." The FAQ was not signed by all the signatories.

Cyrus, Bitcointalk moderator.

Luis Cardenas System Programmer Mercoeso  (socialist electronic community market) Development of electronic commerce applications under IBM I series platform with use of bitcoin and own blockchain for poor families.


Chore: Pretier for consistant formatting

TODO: This PR needs to be updated by Saoud after he runs npm install & npm format:fix and commits the results of the prettier changes.

@saoudrizwan There's a prettier config in there, but I updated it to match another popular VSCode extension's styling. It's up to you if you want to change it.

Thank you Mark!


mWeb - Login -Offline indicator is missing in "Resent link" page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com
On the login screen - create a new account
Tap "Continue" button
Disable the internet connection in the device

Expected Result:
The user should see a notification that user is offline.
Actual Result:
Missing notification that user is offline.
Workaround:
Unknown
Platform:

Where is this issue occurring?

Mobile Web

Version Number: v1.2.12-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/194399863-28605d79-418e-416e-8187-232de6ffbdc4.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@kavimuru can you re-test?

Also cannot reproduce, closing


[Q] Help me, I don't understand what the reason is

When receiving a stream over hls and transmitting over udp, there is a slight freezing of the image in vlc
I have already tried the --regulate option and small adjustments, but nothing helps.
Please tell me what could be the reason
tsp -v --debug -I http://online.video.rbc.ru/online/rbctv_576p/index.m3u8 -O ip <IP_ADDRESS>:1234
Latest version, windows 10, standard from the website
hls: downloading from https://e8-online-video.rbc.ru/online2/rbctvhd_576p/1690909364000.ts

hls: MIME type: video/mp2t, expected size: 1308104 bytes
Debug: hls: downloading http://online-video.rbc.ru/online/rbctvhd_576p/index.m3u8?e=e8&t=iELf69
Debug: hls: HTTP header: HTTP/1.1 200 OK
Debug: hls: HTTP header: Server: nginx
Debug: hls: HTTP header: Date: Tue, 01 Aug 2023 17:02:53 GMT
Debug: hls: HTTP header: Content-Type: application/vnd.apple.mpegurl
Debug: hls: HTTP header: Transfer-Encoding: chunked
Debug: hls: HTTP header: Connection: keep-alive
Debug: hls: HTTP header: Last-Modified: Tue, 01 Aug 2023 17:02:49 GMT
Debug: hls: HTTP header: ETag: W/"64c93ab9-19b"
Debug: hls: HTTP header: Expires: Tue, 01 Aug 2023 17:02:53 GMT
Debug: hls: HTTP header: Cache-Control: max-age=0
Debug: hls: HTTP header: Cache-Control: no-cache
Debug: hls: HTTP header: Access-Control-Allow-Origin: *
Debug: hls: HTTP header:
Debug: hls: MIME type: application/vnd.apple.mpegurl
Debug: hls: playlist media sequence: old: 1949965/0, new: 1949961/4
Debug: hls: no new segment in playlist
Debug: hls: downloading http://online-video.rbc.ru/online/rbctvhd_576p/index.m3u8?e=e8&t=iELf69
Debug: hls: HTTP header: HTTP/1.1 200 OK
Debug: hls: HTTP header: Server: nginx
Debug: hls: HTTP header: Date: Tue, 01 Aug 2023 17:02:56 GMT
Debug: hls: HTTP header: Content-Type: application/vnd.apple.mpegurl
Debug: hls: HTTP header: Transfer-Encoding: chunked
Debug: hls: HTTP header: Connection: keep-alive
Debug: hls: HTTP header: Last-Modified: Tue, 01 Aug 2023 17:02:49 GMT
Debug: hls: HTTP header: ETag: W/"64c93ab9-19b"
Debug: hls: HTTP header: Expires: Tue, 01 Aug 2023 17:02:56 GMT
Debug: hls: HTTP header: Cache-Control: max-age=0
Debug: hls: HTTP header: Cache-Control: no-cache
Debug: hls: HTTP header: Access-Control-Allow-Origin: *
Debug: hls: HTTP header:
Debug: hls: MIME type: application/vnd.apple.mpegurl
Debug: hls: playlist media sequence: old: 1949965/0, new: 1949961/4
Debug: hls: no new segment in playlist

Hi @KradinKYu
HLS is bursty by design (each segment is read at the speed of the network). Therefore, with ip output, regulate is required. Also make sure to pass 7 packets at a time (see the many topics on ip output about regulation and buffering).

Sorry, I tried different options:
tsp -I hls https://hls-03-video.webcaramba.com/rutv/live_720/index.m3u8 -O ip <IP_ADDRESS>:1234&pkt_size=1316&fifo_size=1000000&burst_bits=188 -P regulate
tsp --realtime=off --add-input-stuffing 15/25 --buffer-size-mb 50 -I hls https://hls-03-video.webcaramba.com/rutv/live_720/index.m3u8 -P regulate -O ip <IP_ADDRESS>:1234&fifo_size=5000000 -s 188 -p 7 -P filter -n -p 0x1FFF
tsp -I hls https://hls-03-video.webcaramba.com/rutv/live_720/index.m3u8 -P regulate --pcr-synchronous -O ip <IP_ADDRESS>:1234 -s 188 -p 7
I can't adjust the bitrate in any way....
please tell me, maybe there is a universal recipe how can I do this?

-O ip <IP_ADDRESS>:1234&pkt_size=1316&fifo_size=1000000&burst_bits=188

Where did you get that kind of syntax from ?

Try something like this:
tsp --max-input-packets 7 --max-flushed-packets 7 \
    -I hls ... \
    -P regulate --pcr-synchronous --packet-burst 7 \
    -O ip <IP_ADDRESS>:1234 --enforce-burst

I took your advice, similar errors began to appear, please tell me what is the reason for this?
tsp --max-input-packets 7 --max-flushed-packets 7 --buffer-size-mb 5 --max-output-packets 7 -I hls https://hls-03-video.webcaramba.com/rutv/live_720/index.m3u8 -P regulate --packet-burst 7 -P bitrate_monitor -O ip <IP_ADDRESS>:1234 --enforce-burst
Warning: bitrate_monitor: TS bitrate (0 bits/s) is lower than allowed minimum (10 bits/s)

Warning: bitrate_monitor: TS bitrate (4,866,643 bits/s) is back in allowed range (10-4,294,967,295 bits/s)
Warning: bitrate_monitor: TS bitrate (0 bits/s) is lower than allowed minimum (10 bits/s)
Warning: bitrate_monitor: TS bitrate (1,433,914 bits/s) is back in allowed range (10-4,294,967,295 bits/s)
Warning: bitrate_monitor: TS bitrate (0 bits/s) is lower than allowed minimum (10 bits/s)
Warning: bitrate_monitor: TS bitrate (4,783,923 bits/s) is back in allowed range (10-4,294,967,295 bits/s)
Warning: bitrate_monitor: TS bitrate (0 bits/s) is lower than allowed minimum (10 bits/s)
Warning: bitrate_monitor: TS bitrate (4,202,477 bits/s) is back in allowed range (10-4,294,967,295 bits/s)
Warning: bitrate_monitor: TS bitrate (0 bits/s) is lower than allowed minimum (10 bits/s)
Warning: bitrate_monitor: TS bitrate (5,130,144 bits/s) is back in allowed range (10-4,294,967,295 bits/s)
Warning: bitrate_monitor: TS bitrate (0 bits/s) is lower than allowed minimum (10 bits/s)
Warning: bitrate_monitor: TS bitrate (4,955,981 bits/s) is back in allowed range (10-4,294,967,295 bits/s)
Warning: bitrate_monitor: TS bitrate (0 bits/s) is lower than allowed minimum (10 bits/s)
Warning: bitrate_monitor: TS bitrate (4,525,536 bits/s) is back in allowed range (10-4,294,967,295 bits/s)
Warning: bitrate_monitor: TS bitrate (0 bits/s) is lower than allowed minimum (10 bits/s)
Warning: bitrate_monitor: TS bitrate (5,029,677 bits/s) is back in allowed range (10-4,294,967,295 bits/s)

I looked at the URL you mention. The stream has some unusual characteristics:

Very few PCR, only 0.6 per second, while the usage is typically one PCR per frame, i.e. 25 or 30 PCR per second.
The PCR rate is not stable. Sometimes, two consecutive PCR's are distant by more than 2 seconds.
The bitrate is highly variable, with large variations between lower and higher values.

This means that it is difficult to evaluate in real time the instant bitrate. Evaluating the instant bitrate from PCR requires that the PCR samples arrive at a higher rate than the bitrate variation (this is some kind of application of the Shannon's theorem on sampling).
Regulating a stream requires a reasonably valid evaluation of the instant bitrate. Full accuracy is not necessary when receivers have some buffering capabilities. However, here, we have zero accuracy.
For highly variable bitrates, regulating using --pcr-synchronous may be a solution. However, it requires sufficiently close PCR samples. It generates errors and loses synchronization when two consecutive PCR's are distant by more than 2 seconds, which is the case here on a regular basis.
This makes this stream impossible to regulate. This is a stream which is typically encoded for HLS, where the media player or receiver can receive and play at different rates, with proper buffering in between.
I see no solution to regulate this stream for a reliable HLS -> UDP conversion.


Token is treated as expired sometimes in OBO exchange

After a certain amount of time, the on-behalf-of flow ceases to function with the logged in user's token. The error returned is invalid_grant error code 500133. As far as I can tell, this corresponds to the assertion being expired, but I don't know why EasyAuth isn't catching this on the outside (and denying access correspondingly). Logging out and back in fixes the issue.
It might be worth looking for this and sending the user to the login flow if the error code comes back this way.

As of #108 the Automation is moving to using Microsoft.Web.Identity to do all the token management instead of the half-and-half approach from before. Closing -- if this ends up continuing a bug, it's likely to present completely differently.

As of #108 the Automation is moving to using Microsoft.Web.Identity to do all the token management instead of the half-and-half approach from before. Closing -- if this ends up continuing a bug, it's likely to present completely differently.


We have Loaders that make it really easy to load data as an artifact - can we also have Savers to make it easy to save artifacts?

[X] I have read and agree to the contributing guidelines.

The framework makes it very easy to load data from disk into an appropriate Artifact - but there are no methods to save those artifacts to disk.
For example, I can load audio like this:
sound_artifact = AudioLoader().load("WORKSPACE/audio.mp3")

But to write that same artifact I have to do:
bytes = sound_artifact.to_bytes()
with open ("workspace/audio.mp3", "wb") as f:
    f.write(bytes)

We could either add a save method to artifacts..
sound_artifact.save("workspace/audio.mp3")
or have an AudioSaver().save("workspace/audio.mp3").. and maybe that class could use a driver to control if it saves it locally or to the cloud?

Actually.. I just realized there's the LocalFileManagerDriver. hah
LocalFileManagerDriver(workdir="WORKSPACE").save_file("audio.mp3", audio_bytes)

maybe we just close this then. :)

I think the challenge is.. as a new user, I don't know what to use.. Loaders or FileManagerDrivers? Why use one in one situation, and the other in another?


node-ci cache and GitHub Action

After adding native cache support for setup-node action I have some doubts on this step:
https://github.com/probot/settings/blob/b0ca60a3a6f8e498e0c7cf98742707f68c3ada45/.github/workflows/node-ci.yml#L21
Is it adding a cache so it can be replaced by a regular npm install or npm ci ? Or is there anything else to keep this step (and maybe rollback cache feature from setup-node step)?

yes we can remove the uses: bahmutov/npm-install@v1 step now


Fix SDN status hook

@danwinship PTAL

the rest is good. ironically I just noticed this same problem like 10 minutes ago

LGTM.  Good catch!  Why bother execing when we know what it's going to return :)


docs: Link to helm chart

Current dependencies on/for this PR:

main

PR #4   👈

This comment was auto-generated by Graphite.


ARROW-8613: [C++][Dataset][Python] Raise in discovery on unparsable partition expression

I think ARROW-8631 is not the correct JIRA? (but I also don't directly find what it then should be)

@jorisvandenbossche I had the last two digits swapped, sorry. https://issues.apache.org/jira/browse/ARROW-8613

R failure is unrelated: https://github.com/apache/arrow/pull/7440/checks?check_run_id=776904790 Merging


the syntax 'limit #,#' is not supported

From which SQL dialect is this?

AnsiDialect, MySqlDialect

https://github.com/sqlparser-rs/sqlparser-rs/pull/370 attempts to add support for the syntax, but I am little concerned with the implementation. I'll try and whip up a new PR


[feature] count(tablename)

I just want to count all the entities without the requirement of a where clause.
select count(*) from 'table';

So basically just making the where parameter optional will be enough, right?

Exactly.

Looks like it was supported via repository.count() already. Now it allows omitting the where parameter in em.count() as well (in the dev branch). Will publish new alpha once #157 is finalized.

Available in 3.0.0-alpha.16.


Make ctrl-enter the keyboard shortcut to send data

In order to be consistent with Slack.

Fixed by commit ebc4857

Preliminry conclusion after oral discussion: per default the return key should give a new line (not send snippet). Sending snippet should be triggered by both shift-enter and control-enter. Later we may want to offer a user definable behaviour.


Update build to work with latest monaco changes

Well, I guess there's no CI or anything so I'll just test this quick locally and merge and rerun nightly.

This was still wrong, hopefully fixed in a followup commit...


max values no working

When the user type 20 digits, the values are setting with empty.
Is possible use more digits?

@Andreibv  Could you give me example of usage this package in your project and steps for reproduce wrong behavior?

https://github.com/user-attachments/assets/59da9b3d-b9ca-41ff-b627-0930298a06d9
if i type one more digit, after that the value is setting empty
im using
"react-native": "0.74.2",
"@alexzunik/react-native-money-input": "^0.3.3",

@Andreibv Sorry for a long wait.
I updated the library, now you can use 36 characters as integer part.
Unfortunately, the library has limitations (see here)


Unexpected crash

Running of hello_world demo crashes program with following output:

thread '' panicked at 'assertion failed: validate_hidpi_factor(dpi_factor)', ...\winit-0.16.2\src\dpi.rs:153:9

Could you let us know your OS and environment so that someone can try to reproduce this bug?

OS: Windows 7 x86
Rust:1.28.0-msvc
Running with --release

This looks like winit bug 607: https://github.com/tomaka/winit/issues/607
It's been fixed in winit 0.17, but the problem is glium still ends up using winit 0.16 through this dependency chain:
imgui-glium-renderer -> glium 0.22 -> glutin 0.17 -> winit 0.16
I don't think we can do anything to fix this at the moment, but once glium is updated with glutin 0.18, we can in turn update glium.


Remove logging scopes sample config for Console

Fixes #21469.
@Rick-Anderson This addresses the specifics of the linked issue, but it doesn't include anything re the duplication I mentioned. I think that might need more discussion, so I can open a new issue for that, if you like.
It looks like a lot of the sections could just be dropped, and the fundamentals/logging/loggermessage topic itself could also be dropped. I don't know if that's an acceptable approach here, so I don't want to run off and waste time making big changes to this topic and messing around with the toc if that's not the right approach.

@serpent5  thanks for the PR. This looks low risk for breaking the build. It will be a few days before the build is working again.


Type annotations for “currying” or function partial application style APIs

I'm trying to declare the typings of IFactory<T>. The factory APIs uses a “currying” or function partial application style:
interface IFactory<T> {
    (...args: any[]): (IFactory<T>|T);
}

class Engine {
    constructor(type: string, cc: number) {}
}

let engineFactory: IFactory<Engine> = (type: string) => (cc: number) => {
    return new Engine(type, cc);
};

let dieselEngineFactory = engineFactory("diesel");
let dieselEngine300cc = dieselEngineFactory(300);     // Error!
let petrolEngine300cc = engineFactory("petrol")(300); // Error!

@basarat helped me on stackoverflow with the following answer:
interface IFactory<T,C> {
    (type:string): (configuration:C) => T;
}

class Engine {
    constructor(type: string, cc: number) {}
}

let engineFactory: IFactory<Engine, number> = (type: string) => (cc: number) => {
    return new Engine(type, cc);
};

let dieselEngineFactory = engineFactory("diesel");
let dieselEngine300cc = dieselEngineFactory(300);     // OK
let petrolEngine300cc = engineFactory("petrol")(300); // OK

My problem is that I have a framework that uses factories and the factories are defined by the users so I can only have one unique generic implementation of IFactory that covers all the factories to be developed by the users.
I've been thinking and as far as I know this is not possible. I wonder if you could add support for a new operator it would not be an union type or intersection type. In set theory it would be the union of the intersection and the relative complement of the types. I would suggest to sue the || operator:
interface IFactory<T> {
    (...args: any[]): (IFactory<T>||T);
}

This would mean that (IFactory<T>||T) can take only one of the following types:

(A ∩ B) ∪ (B ∖ A) Union of the intersection and the relative complement (B ∖ A).
(A ∩ B) ∪ (A ∖ B) Union of the intersection and the relative complement (A ∖ B).

This is probably something complex but I believe it would be useful.
Thanks!

QQ : What about
let petrolEngine300cc = engineFactory("petrol")(300)("too many");

Error or Okay? :rose:

That would be a runtime error. I understand that compilation errors are better than runtime errors but this is making really complicated to use functional programming in TypeScript and I really believe that functional programming is becoming a big thing.
Let's imagine that I want to create the type definitions for ramdajs:
interface R {
    curry: <T>(func: (...args: any[])=> T) => (((...args: any[])=> T)|T);
}

declare var R: R;

var addFourNumbers = (a, b, c, d) => a + b + c + d;

var curriedAddFourNumbers = R.curry<number>(addFourNumbers);
var f = curriedAddFourNumbers(1, 2); // Error!
var g = f(3);
g(4); //=> 10

As I said I I understand that compilation errors are better than runtime errors but If I have the freedom to choose to do the following I would:
interface R {
    curry: <T>(func: (...args: any[])=> T) => (((...args: any[])=> T)||T);
}

declare var R: R;

var addFourNumbers = (a, b, c, d) => a + b + c + d;

var curriedAddFourNumbers = R.curry<number>(addFourNumbers);
var f = curriedAddFourNumbers(1, 2);
var g = f(3);
var h = g(4); //=> 10
h(5); // Error! (runtime)

Maybe we could have a compilation setting to enable compilation warnings? So we get a compilation warning before the runtime error.

This is essentially a dupe/heavily related to #5453 which is currently being implemented.

indeed #5453 should address this request. until then the only way is to list the first n-signatures explicitly as mentioned in https://github.com/Microsoft/TypeScript/issues/8303#issuecomment-214699527

Thanks for spending some time looking at this issue.


Safety tip mechanism not explained

The article does not explicitly state how safety tips are implemented. The Safety Tip section mentions that the custom header X-MS-Exchange-EnableFirstContactSafetyTip is set to "Enable" by the safety tip setting. But it does not explain how the tip is rendered by the client.
It is unclear if the email client is supposed to render the safety tip based on the value of the header, or if the email server rewrites the body of the email by injecting the warning text. It turns out it operates by injecting the warning directly into the email.
I found a third-party claim that EOP will not rewrite the bodies of S/MIME signed emails with safety tips as this would prevent the signature from being successfully verified. But I was not able to find any mention of this in official Microsoft documentation.
A detailed description of Safety Tip's implementation and how it interacts with email signing should be present in the Microsoft documentation.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: f0b8f651-9d8e-a34b-8dde-2b6a9448f875
Version Independent ID: 20e96426-627d-9973-8303-a43a114c7b61
Content: Anti-phishing policies - Office 365
Content Source: microsoft-365/security/office-365-security/set-up-anti-phishing-policies.md
Service: microsoft-365-security
Sub-service: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

Checking

Updates for article were waiting to publish, but I never pulled the trigger. I just pulled the trigger.
Thanks for the feedback.
Closing


There is no data shown in the dashboard

Please answer these questions before submitting your issue.

Why do you submit this issue?
[Y ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
Why there is no data shown in the dashboard

Bug

Which version of SkyWalking, OS and JRE?
SkyWalking : 6.5.0
OS : CentOS Linux release 7.7.1908 (Core)
JRE : 1.8.0_191

Which company or project?
personal demo

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.
(1)I download the skywalking from https://mirrors.tuna.tsinghua.edu.cn/apache/skywalking/6.5.0/apache-skywalking-apm-6.5.0.tar.gz
(2)unzip the package in my VMware
(3)change the server.port to 18080
(4)execute the command "./startup.sh"

(5)the home page is shown

(6)then I use below command to start my project "java -javaagent:/opt/microservice/client/agent/skywalking-agent.jar -jar -Xmx128m consumer-0.0.1-SNAPSHOT.jar"
(7)visit the exposed interface of the project some times, expected result is shown

(8)then I checked the skywalking page , there is no data shown in the page
Is there any wrong ?

Requirement or improvement

Please describe about your requirements or improvement suggestions.

I change the data range under the browser , the data is shown

I change the data range under the browser , the data is shown

I'm the same


Raise an exception if user configures a timestamp column that doesn't exist

Today we just ignore and the test works without a timestamp.

Don't we already have this logic?

@elongl
He saw the "column is not a timestamp" error and reached out in support as the column is a timestamp.
But he had a typo in the column name. So the right error should be that there is no such column.


Error while displaying Icons

When including icons inside the drawer, this error is thrown :

TypeError: Cannot read property 'icon' of undefined
See also: https://flutter.dev/docs/testing/errors

This was my code :
`drawer: CurvedDrawer(
          color: Colors.white,
          width: 75.0,
          items: <DrawerItem>[DrawerItem(icon: Icon(Icons.alarm),label: "Alarm")],
        ),`

#5

Should be fixed by #5Update curved_drawer.dart

@jonathananales it seems to be working now 👍


market order

Market order is not enabled in the trading page. Right now only limit order is supported in trading page.

Hello @arshad-bilawat
Can you provide the details?

There are atleast two types order in any exchange:

Market Order
Limit Order.

The peatio supports only limit order as of now. Can we please add market order support.

@yivo ping

@arshad-bilawat You can submit PR or contact https://peatio.tech/ for this feature.


The Great Suspender alternative

As you might know already, the great suspender has been killed off by google as it was deemed malicious.
Is there an alternative extension that you can suggest that would work with Tabli?

I don't yet have an immediate suggestion for an alternative to the Great Suspender.
I liked the suggestion in the above linked article of forking an older version of the Great Suspender.  If one of these emerges as a clear community favorite, it will be relatively easy to support it instead of  or in addition to the official Great Suspender in Tabli -- should be a simple matter of adding the extension ID to Tabli's code base.  The linked article mentions one such effort ( The Marvellous Suspender ), but there's not even a description of it in the Chrome Web Store, and it's not clear who is maintaining it, so I'm a little reticent to trust it just yet.  Happy to revisit this if more details emerge there, or if another community-supported fork of the Great Suspender emerges as a clear winner.

This is a clean fork I am using successfully: https://github.com/aciidic/thegreatsuspender-notrack
Is it possible to make the support universal for all forks? Maybe we can input the extension's hash name or something?

Yes, this should be fixed, as a hotfix to replace the support on this extension https://chrome.google.com/webstore/detail/the-marvellous-suspender/noogafoofpebimajpfpamcfhoaifemoa/related

As the 'Performance' options are coming via upstream Chromium now, maybe there is no longer any action needed here?

@JimBreton Tab discarding was added to Chrome in 2016 https://medium.com/@wdyluis/built-in-automatic-tab-discarding-of-chrome-9657579e4d35
But you can't specify unloading after half an hour there, for example


android-studio: 2<IP_ADDRESS> -> 2<IP_ADDRESS>

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[X] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

LGTM. It is a bit odd that our stable version is newer than the beta.

It is. I can open another PR updating those to the latest versions.

It is. I can open another PR updating those to the latest versions.

In this PR would also be okay.

In this PR would also be okay.

I could do it tomorrow or on thursday, I'll update the PR.
Thanks for the approval!

Please, don't close this PR. I'll make the changes I promised, I'm at this moment with some health issues and couldn't attend it.

Please, don't close this PR. I'll make the changes I promised, I'm at this moment with some health issues and couldn't attend it.

No worries :)
I estimate there are currently ~4k open PRs waiting on their authors..

I hope this satisfies the requirements for merging it, let me know if anything else must be done!

The CI is currently failing due to #354738
Other than that it's good to go.

stable was updated in #363548, please rebase

I'm out of my home for the New Year, I'll do it on Tuesday.
Happy new year and thanks for letting me know about the rebase!


Additional style property for Box inside of SimpleGrid component

Is your feature request related to a problem? Please describe.
I am unable to use the SimpleGrid in several scenarios because I cannot completely control it's style.
There is an inner Box being used to wrap the "col" component inside of the SimpleGrid, but it does not accept any props as styles. For my use case, I'm trying to "flex: 1" this box so that the children in each row expand to fill the entirety of the SimpleGrid's width (rather than just fitting the width of the children).
  {row.map((col: any) => {
    return (
      <Box {...DEBUG_STYLES.cols} key={col.key}>
        {col}
      </Box>
    );
  })}

Describe the solution you'd like
It would be helpful if we were given more control over the SimpleGrid component's styles.  This could be accomplished by passing down a _gridItem style or something similar for this wrapper.
Describe alternatives you've considered
I have considered using a series of VStacks + HStacks to achieve the desired behavior, but at that point, I will just be duplicating the SimpleGrid and tweaking it slightly.

I am trying to accomplish the same thing: having children expend to fill the full width for each lines.
Did you manage to find a solution? would you mind sharing it if you did? :)

@pierroo I actually don't recall exactly where we were trying to use this so I can't find the code, but I'm pretty sure we took the approach of nesting the VStack and HStack's similar to how the SimpleGrid works behind the scenes. Not as convenient, but it gets the job done for now.

Thank you for answering @kylegwalsh , I will look into this solution as well then, until NativeBase gives us this option natively :)

@kylegwalsh SimpleGrid component is currently on hold. We're going to add full support for that soon.


Added persistent volume claim for etcd and config map updates

@dymurray I tested deploying this from catasb, basic deployment checked out.

Ok just merged #166. @jwmatthews do you want to test again?

I've tested what I can, deployment of broker/etcd is coming up.  Having issues with provision of APB through broker, but I think that is to be expected at moment.
I'm good with merging this and continue to debug.


Exception error

Been getting this error from time to time when opening a PM with someone:
====================================
BEGIN EXCEPTION REPORT
22-6-2015 8:49:05
====================================

Version: slimCat Puma 4.11
Exception: Index was outside the bounds of the array.
Occured at: PM Channel ViewModel, init

Immediate stack trace: Boolean MoveNext()   at System.Collections.Generic.List`1.Enumerator.MoveNext()
   at System.Linq.Enumerable.WhereListIterator`1.MoveNext()
   at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection)
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Microsoft.Practices.Unity.NamedTypesRegistry.RegisterType(Type t, String name)
   at Microsoft.Practices.Unity.UnityDefaultBehaviorExtension.OnRegister(Object sender, RegisterEventArgs e)
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at Microsoft.Practices.Unity.UnityContainer.RegisterType(Type from, Type to, String name, LifetimeManager lifetimeManager, InjectionMember[] injectionMembers)
   at Microsoft.Practices.Unity.UnityContainerExtensions.RegisterType[TFrom,TTo](IUnityContainer container, String name, InjectionMember[] injectionMembers)
   at slimCat.ViewModels.PmChannelViewModel..ctor(String name, IChatState chatState, INoteService notes, IProfileService profile) in c:\Users\Justin\Source\Repos\slimCat\slimCat\ViewModels\Channels\PMChannelViewModel.cs:line 110

====================================
END EXCEPTION REPORT
====================================

No idea what's causing it, but my Stacktrace.log is riddled with them.
I should also mention that I'm using portable mode and have Slimcat installed inside a Google Drive folder (though I was getting similar errors with a Dropbox install as well).

Was not able to reproduce myself, but it appears to be related to the way slimCat registers new PM tabs. Not sure if this is resolve-able.

That is a shame to hear, but the error doesnt pop up all that often so its not the end of the world.


Document common completion reporting mechanisms from EPICS

Request from @danielballan

Put completion (aka put callbacks)
Record processing (with or without busy record)
Done flag in a record (or field)

From an email I wrote for a scientist, some content that might be useful whenever we get around to this:
Unfortunately, documenting the various ways that EPICS handles "completion" is still an open issue. My (possibly flawed) understanding is:

Some multi-PV devices like EPICS motors have a separate "readback" and/or "done" PVs that are involved in checking for completion, and ophyd Devices that span these multi-PV devices handle coordination of that information.
Simple EPICS signals do not have separate readback or done PVs. Instead, they use "put completion". The EPICS client sends a message "write this value" and the EPICS server on the IOC sends back the message "OK," meaning, "OK I have written that value". This all happens through just one PV.
Other, less smart EPICS signals do not implement put completion. When the EPICS client sends a message, "write this value", the server immediately answers "OK", meaning, "OK I will write that value" even though it hasn't actually done yet. For these, if we want to know when the writing is actually complete, our only option is to poll the server with messages to read the value and see whether it has changed yet. Again, this happens through just one PV.

By default, ophyd.EpicsSignal assumes it is talking to an EPICS server like the one in (2). It waits to get back that response ("OK I have written that value") and tells bluesky that it is ready. If it is hanging instead, then I think that the server is never sending a response or that the response is for whatever reason getting lost in network traffic (which is not too unusual, sadly).

I think there is also a case 4 which is a variation on 1, but without the 'done' PV so we have to poll the readback.  I think this is what the AD signal do.

This is of benefit to no one in a 4 year old "we should do this" issue


React dev tools profiling support

Add support for react dev tools profiling - either through the configuration (preferred, since it's not a frequently requested feature) or always enabled by default (in this case analysis needed whether it has any impact on the projects). Andrew's Connel blog post for inspiration.
And also enable strict mode?

Implemented in 1.13.3 - with new config setting reactProfiling.


i18n backend decision

In https://opensesame.libelektra.org/ we use gettext-rs for i18n.
Does gettext-rs support hot reloading?
Do you know any better i18n lib?
(Btw. for the frontend we were thinking to use https://react.i18next.com/)

I have never done anything related to i18n so the best I could would be to look through some crates https://lib.rs/internationalization.
What do you mean by

Does gettext-rs support hot reloading?

gettext-rs uses GNUs gettext (by default statically linked as far as I understand, see https://crates.io/crates/gettext-rs). We could switch to dynamic linking and then swap out/update gettext independently of gettext-rs

so the best I could would be to look through some crates https://lib.rs/internationalization.

I also looked at a few alternatives when deciding for gettext-rs, namely fluent (LangNeg), ICU.  I didn't check for support for hot reloading.

Does gettext-rs support hot reloading?
swap out/update gettext independently of gettext-rs (although I have never done that as well and have no idea how/if it would work)

I was mainly thinking about hot reloading the message catalogs, which must always fit with our own code.
But this is low priority, I thought maybe you already know. The probably simpler way is to store the translations in the database. It is actually mostly about translating the enums, which cannot simply have additional translation columns (afaik).
First #65 and #60 should be done.

@Bushuo @badnames @Benjaminimal @absurd-turtle Does someone have experience with i18n in React (Frontend)?

@Bushuo @badnames @Benjaminimal @absurd-turtle Does someone have experience with i18n in React (Frontend)?

no

Does someone have experience with i18n in React (Frontend)?

I have tried out i18next in react once. But do not consider myself as experienced with it.
I have some experience with i18n in angular, as we use this at work. So I know a little bit about how I would not do it 😂

I have only worked with i18n in a python backend project so far.

I have tried out i18next in react once. But do not consider myself as experienced with it.

Was it a good experience? Do you think we can simply use it or should we better investigate in options (write a decision)?

Was it a good experience? Do you think we can simply use it or should we better investigate in options (write a decision)?

@markus2330 Like discussed in the frontend meeting, I think we can simply use it. Should I attach a PR to this issue?

This issue is also about i18n backend and probably the SQL enums are the only thing left, so probably it is not even worth pulling in an i18n lib. It is not yet decided yet. Anyways, let us focus in this issue on the backend.
For frontend, you are right, we'll simply use i18next and you can attach to the better suited issue #150, I assigned it to you.

The enums are now being translated via i18next as shown in #235.
@markus2330 Are there any other tasks to do regarding translation?

Enums are translated perfectly, good job! :heart: There are a few other leftovers, I created #266.


Better support for DI

Hello
I'm using Dependency Injection together with Spring repositories. So basically I inject repository to access database data. Using your code, I want to inject into SecurityHandler which extends AbstractDeadboltHandler, so I can use it in getSubject method. Are there any good ways to accomplish this?
At the moment, I'm solving it with
@Override
public Subject getSubject(Http.Context context)
{
    String email = context.session().get("email");

    UserRepository userRepository = Play.current().global().getControllerInstance(UserRepository.class);
    User user = userRepository.findByEmail(email);

    return user;
}

but I'm not sure if this is good approach. Any tips?

This will be implemented as of Deadbolt 2.4 to take advantage of the built-in DI support.


UPNP

The binaries might require recompile.
http://talosintel.com/reports/TALOS-2015-0035/

what do you think of disabling it as per  https://github.com/rubycoinorg/rubycoin/commit/bd4a3e57f53f1d4caa2f0aa6ea27f86958c3454a

Whilst I don't like miniupnpc's code, I also don't like to disable UPNP.


fix: No permission for multiple users.

Codecov Report

Merging #1230 (c50ca29) into main (7d29f71) will increase coverage by 11.31%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main    #1230       +/-   ##
===========================================
+ Coverage   66.12%   77.44%   +11.31%
===========================================
  Files          21       35       +14
  Lines         307      594      +287
  Branches       27        0       -27
===========================================
+ Hits          203      460      +257
- Misses         94      114       +20
- Partials       10       20       +10

Impacted Files
Coverage Δ

...Api/Controllers/MarketParticipantControllerBase.cs
0.00% <ø> (ø)

...Api/Controllers/MarketParticipantUserController.cs
0.00% <0.00%> (ø)

...s/MarketParticipantUserRoleAssignmentController.cs
0.00% <0.00%> (ø)

...ers/MarketParticipantUserRoleTemplateController.cs
0.00% <0.00%> (ø)

...urce/DataHub.WebApi/Controllers/TokenController.cs
0.00% <0.00%> (ø)

...taHub.WebApi/Controllers/Wholesale/Dto/BatchDto.cs
0.00% <0.00%> (-100.00%)
:arrow_down:

...gistration/HealthEndpointRegistrationExtensions.cs
36.84% <0.00%> (-42.11%)
:arrow_down:

...WebApi/RequireNonNullablePropertiesSchemaFilter.cs
80.00% <0.00%> (-8.00%)
:arrow_down:

apps/dh/api-dh/source/DataHub.WebApi/Startup.cs
93.97% <0.00%> (ø)

...rce/DataHub.WebApi.Tests/Fixtures/WebApiFactory.cs
83.33% <0.00%> (ø)

... and 11 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Socket] [ERROR:flutter/lib/ui/ui_dart_state.cc(199)] Unhandled Exception: SocketException: OS Error: Software caused connection abort, errno = 103, address = <IP_ADDRESS>, port = 44968

code
   Socket.connect('<IP_ADDRESS>', 8848).then((socket) {
      print('connectSuccess');
      socket.listen((event) {

      }, onError: (e, s) {
        print('onListenerCallError: $e');
      });
      socket.write('data');
    }).catchError((e) {
      print('connectError: $e');
    });

Steps to Reproduce

Execute this code when the network is open.
log:I/flutter: connectSuccess
Shut down all Internet connections on your phone.
log: I/flutter: onListenerCallError: SocketException: OS Error: Software caused connection abort, errno = 103, address = <IP_ADDRESS>, port = 44968
E/flutter: [ERROR:flutter/lib/ui/ui_dart_state.cc(199)] Unhandled Exception: SocketException: OS Error: Software caused connection abort, errno = 103, address = <IP_ADDRESS>, port = 44968

Expected results:  No exceptions will be thrown after listening is set up.
Actual results:  I received the error result, but Fluuter also threw this exception, I don't know how to catch  it.
OS: Android

flutter doctor -v

[✓] Flutter (Channel stable, 2.2.0, on Mac OS X 10.15.6 19G73 darwin-x64, locale
    zh-Hans-CN)
    • Flutter version 2.2.0 at /Users/zero/Library/flutter
    • Framework revision b22742018b (5 months ago), 2021-05-14 19:12:57 -0700
    • Engine revision a9d88a4d18
    • Dart version 2.13.0
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/zero/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/zero/Library/Android/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor
      --android-licenses

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.60.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.26.0

[✓] Connected device (2 available)
    • PH 1 (mobile) • PM1LHMA7C1303567 • android-arm64  • Android 10 (API 29)
    • Chrome (web)  • chrome           • web-javascript • Google Chrome
      94.0.4606.61

! Doctor found issues in 1 category.

Hi @Tan-yi-xiong
There are similar issues in Dart SDK repo, this is a Dart issue rather than Flutter itself, dart:io is needed to use this code. Please file an issue on the Dart SDK repo.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


Refactor/simplify Radio component

As a designer...
I want the Radio component to use subcomponents in the same way as other form components...
so it's more predictable and understandable.
Acceptance criteria

User can edit Label text using nested properties
User can set error state
User can't reach state of invalid combination of properties

Done when

[x] EN Component is merged into main
[ ] EN Component is published
[ ] FR updates are handed off to FR maintainer

@SmartMouthWords to approve content changes before updating internal assets in EN and FR.
(left is original; right is new version)

Looks good @RavinaSamaroo we can close this.


comprehensive training

Hello, I wanted to know if you have a comprehensive training for implementing and installing these codes? Because this topic can help you a lot in getting noticed, especially for those who do not have special knowledge of working with codes.

Hi @Meta-Mahdi thanks for the advice! I will work on the Readme and documentation, in general, to further make it more comprehensive. But in order to use the packages I do highly recommend getting familiar with the programming languages and their respective package managers.


Multiple Schemas in one server.

I want to expose multiple schemas at different endpoints in a GraphQLServer. how can i achieve that?

I guess you can run multiple servers with one schema in each and then make them available at URIs of your choice by means of a reverse proxy. Take a look at Traefik – it’s my personal choice.

Agree with @oexza . I have multiple prisma endpoints connected to different databases. Would really be nice to have one graphql server to serve a customized graphql API.

I notice that Graphcms platform serves multiple endpoints on the same domain. Example:
https://api-useast.graphcms.com/v1/[hash]/master
Having hundreds of users through a reverse proxy and 1/n node process each could be very expensive for small business. (E.g: If we want to create something like graphcms)
Serving multiple endpoints (different schema and context) on the same instance could be very interesting.
I think we are able to achieve this right now if we use express-graphql instead of graphql-yoga. Anybody is in for bringing this feature to yoga? I can help!


Unknown yield error in lua 5.1

Whenever we invoke mongorover calls from lua 5.1, we are receiving "Unknown yield" error . This subsequently leads to the failure of the application using mondorover

Can you give me more information?
Are you installing from source or from luarocks?
What environment are you running on?
What version of the C driver did you install?
Can you run tests whatsover?
Do you have a code snippet that can show me how and why this fails? Stacktraces would be nice too.

Hello Chris,
I am using Luajit with Lua version 5.1. My intention was to integrate
OpenResty-Kong with MongoDB. For this, I am using Mongorover.
To recreate this issue, all iI need to do is to import ("require") the
mongorover module. After this, whenever I make any REST call to Kong, i get
the "Unknown Yield" error message.
Regarding unit testing, after this change, I am able to make the mongodb
database called (insert/find/remove) without any issues, via Mongorover.
regards,
Prabhakar
On Tue, Dec 20, 2016 at 7:29 AM, Christopher Wang<EMAIL_ADDRESS>wrote:

Can you give me more information?
Are you installing from source or from luarocks?
What environment are you running on?
What version of the C driver did you install?
Can you run tests whatsover?
Do you have a code snippet that can show me how and why this fails?
Stacktraces would be nice too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mongodb-labs/mongorover/issues/77#issuecomment-268133054,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUATB3sngdDOpdsys20O64n674grDQHuks5rJzaJgaJpZM4LQt6g
.

Hello Chris,
I need to figure out a way to recreate the issue in a standalone manner.
But please note that the change that I suggested is as per the
Lua c-wrapper interface. I suspect the stack is corrupted if we don't
follow the interface and this is manifesting in a weird manner in arbitrary
locations.
regards,
Prabhakar
On Tue, Dec 20, 2016 at 2:14 PM, Prabhakar Palanivel <
<EMAIL_ADDRESS>wrote:

Hello Chris,
I am using Luajit with Lua version 5.1. My intention was to integrate
OpenResty-Kong with MongoDB. For this, I am using Mongorover.
To recreate this issue, all iI need to do is to import ("require") the
mongorover module. After this, whenever I make any REST call to Kong, i get
the "Unknown Yield" error message.
Regarding unit testing, after this change, I am able to make the mongodb
database called (insert/find/remove) without any issues, via Mongorover.
regards,
Prabhakar
On Tue, Dec 20, 2016 at 7:29 AM, Christopher Wang <
<EMAIL_ADDRESS>wrote:

Can you give me more information?
Are you installing from source or from luarocks?
What environment are you running on?
What version of the C driver did you install?
Can you run tests whatsover?
Do you have a code snippet that can show me how and why this fails?
Stacktraces would be nice too.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/mongodb-labs/mongorover/issues/77#issuecomment-268133054,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUATB3sngdDOpdsys20O64n674grDQHuks5rJzaJgaJpZM4LQt6g
.


Ignore currentColor in VariableForProperty

Similar to 5a8cac9a2, this value is somewhat special and shouldn't be
considered as breaking the rules of this linter.
More information on the currentColor keyword can be found at:
https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#currentColor_keyword
Addresses #426.

Thanks! Merged in f42486fbf1ba035ca4565498bad47521b9836140.


Add percentile to stats

Add p95 to stats that currently use an average

Closed by https://github.com/Agoric/testnet-load-generator/pull/46


Can't store multidimensional data with Session Library

I was trying to store a multidimensional array using Session Library, and it is failing when I try to call set(). Not sure if this is a bug or just an unimplemented feature.
My shopping cart array $cart is set up like this:
Array (     [0] => Array         (             [item] => Adult             [qty] => 2             [price] => 38.02         )     [1] => Array         (             [item] => Child (Ages 4-12)             [qty] => 2             [price] => 17.68         )     [2] => Array         (             [item] => Lap Child (Ages 0-3)             [qty] => 2             [price] => 0         )     [3] => Array         (             [item] => Family Pass (Max 3 kids)             [qty] => 1             [price] => 87.53         )     [total] => 198.93 )
And I'm trying to store it like this:
$session->set($cart);
It fails and I get this error from the debugger:
**ErrorException
Illegal offset type
SYSTEMPATH/Session\Session.php at line 469**
if (is_int($key)) { 	$_SESSION[$value] = null; }
I was able to work around this by doing json_encode() on the data and storing it as a name-value pair. I was also able to store it with pure PHP like $_SESSION['cart'] = $cart;
CodeIgniter 4 version
CodeIgniter 4.0.0-r2.1

$session->set($data) expects $data to be an array of key/value pairs. The key is used as the associative index to $_SESSION  I believe what you want to do is  something like this
$_SESSION['cart'] = $cart;

@dafriend is correct here. That's not a bug, you're just not providing anything to index it by, which means there's no way to retrieve it.

That makes sense. Thanks guys!


Delete and re-add project each time wml s is run

This addresses #19.

I also added in an fs-extra command to clear the target directory first. That way as .watchconfig is updated to exclude new folders, those are automatically removed when wml s is run.


Should this tool check if the file in license_file= exists?

(end of issue)

that's probably more of the responsibility of setuptools


There is a 47MB google-chrome-stable_current_amd64.deb in package?

https://registry.npmjs.org/chrome-promise/-/chrome-promise-2.0.0.tgz

Thanks for reporting this. Didn't realize that. Travis is downloading chrome and then publishing to npm with this file included.
I will fix it later this day.

Fixed in v2.0.1

Thanks 👍


Electron app version

It would be nice to have an Electron app version of Squoosh to run natively.
Also, it would be nice to have the ability to work with multiple files (#301) in this native version.
I love Squoosh because it can convert between formats while showing the size and quality impact. I think it could be even more powerful as a native app with support for drag and drop, opening files, and a multi-file workflow. Keep it up!
BTW, if anyone knows another native app that can convert between and compress in multiple image formats, let me know.

Why does it need to be an Electron app?

Closing. Feel free to reopen with more info.

@jakearchibald I'm not the original poster, but I was looking for something like it too, so here's my input.

I'd love an offline version of the tool. Currently I do my image crushing with a set of pngquant and guetzli/mozjpeg scripts. But (as you know), an interactive UI helps fine-tune parameters. The closest I know is GIMP/Photoshop's "export with preview" screen, but your UI is better.
So I'd like to use Squoosh more, which is exactly that: a great UI to fine-tune parameters.
But it feels weird to have to open a browser to do something fundamentally offline. Service workers would be better, as it could enable offline usage, but to me it still feels weird to do it in a browser.

→ I, too, would enjoy a non-browser, offline, version of Squoosh.
Now, there's nothing mandating Electron, but since all the cross-platform UI work is already done using web tech, Electron seems like a reasonable choice. Passersby may utter the usual Electron heaviness profanities, then they're welcome to rewrite it in $LIGHTWEIGHT_TECH_OF_CHOICE, but a heavy Electron app to me seems better than a non-existing one.
And then even later it could be packaged by distributions, and I could just sudo pacman -Syu squoosh to install the standalone app and use it 🙂.
→ Maybe this issue deserves to be re-opened and rename to something like: "Package as offline, non-browser application (probably Electron)".
At any rate, thanks for your work!


[Idea] Provide multiple CDN links

With and without media queries to optimize payload sizes.

Duplicate of #10.


Add renewedTo field to RPCLastestRevision response

In v2 a renter has no way of knowing whether a contract has been renewed when fetching a revision. So if a renter for some reason misses the fact that the contract was renewed (e.g. due to a crash mid-renewal), it would be nice of the host to tell the renter about it via a renewedTo field. Previously we used the max revision number for that but we don't have that anymore.

@n8maninger I created this issue since it is something we discussed and after thinking about it I think it would be useful to have. Makes it easier to avoid failed interactions with hosts and also some of the contract maintenance checks.

Thinking about this more: instead of a RenewedTo field, maybe a "Resolved" field that includes the type? If resp.Resolution == "renewal", you can calculate the renewed contract ID using the existing contract ID: renewalID := fcid. V2RenewalID()

Sounds good to me. I don't feel strongly about either approach. The resolution might be a bit nicer since we only need to send another byte.

Perhaps make it RPCContractStatus and return something like ForEachV2FileContractElement?
struct {
    Contract types.V2FileContractElement // latest on-chain revision
    Revision *types.V2FileContractRevision // latest off-chain revision, if it exists
    Resolution types.V2FileContractResolutionType // non-nil if contract has been resolved
}


Fix #1273: add explicit handling of Assume-sourced exceptions for Integ tests

What this PR does:
Adds explicit handling of 2 kinds of exceptions junit throws to implement "Assume" functionality (ability to dynamically skip tests) -- here used to ignore non-applicable tests for some persistence backends.
Before change these are considered test failures wrt dumping out ExternalStorage buffered logs; after change they are not considered test failures any more. Although there are only 12 of such cases for C*4.0 backend, they are responsible for probably 30,000 more log lines.
Which issue(s) this PR fixes:
Fixes #1273
Checklist

[ ] Changes manually tested - will verify changes to logging
[ ] Automated Tests added/updated - yes, tests were changed (although not in the sense asked here maybe)
[ ] Documentation added/updated - no documentation about ITs.

Seems to work as expected; numbers:
Before changes, C*4.0 integration tests:

50.9 MB
159,000 lines

after changes

31.4 MB
108,000 lines

and now we have log lines like:
Step #4 - "cassandra-4.0": INFO  [main] 2021-09-24 18:37:46,590 ExternalStorage.java:332 - Skipping dumping storage cluster (Cassandra 4.0) logs: no test failures (7 tests skipped).

to indicate cases that would formerly have dumped boatloads of external logs due to assumed failures.


Serialized EXDATE sometimes breaks spec

In addition, changing the source code to this, to produce an all-day event:
var now = new DateTime(2017, 1, 1);

//Repeat daily for 10 days
var rrule = new RecurrencePattern(FrequencyType.Daily, 1) { Count = 10 };

var e = new Event
{
    DtStart = new CalDateTime(now),
    RecurrenceRules = new List<IRecurrencePattern> { rrule },
};

var exceptionDateList = new PeriodList();
exceptionDateList.Add(new Period(new CalDateTime(now.AddDays(1))));
e.ExceptionDates.Add(exceptionDateList);

var calendar = new Calendar();
calendar.Events.Add(e);

var serializer = new CalendarSerializer(new SerializationContext());
var serializedCalendar = serializer.SerializeToString(calendar);

Produces this output in serializedCalendar:
BEGIN:VCALENDAR
PRODID:-//github.com/rianjs/ical.net//NONSGML ical.net 2.2//EN
VERSION:2.0
BEGIN:VEVENT
DTSTAMP:20170220T144719Z
DTSTART;VALUE=DATE:20170101
EXDATE:20170102/P1D
RRULE:FREQ=DAILY;COUNT=10
SEQUENCE:0
UID:08670eeb-76ad-46d1-bbfa-2e88f1597d58
END:VEVENT
END:VCALENDAR

In this case, EXDATE breaks the spec completely, as it's a date, but VALUE=DATE hasn't been set, and it has a weird duration suffixed to it.

In the long term, it's reasonable to consider changing ExceptionDates to not be a list of IPeriodLists. EXDATE can only be DATE-TIME or DATE according to the standard.
In the short term, suppressing duration output when serializing to ICS, and emitting the TZID parameter, should be enough.

We had to work around this recently, because I didn't have time to fix it in the library itself... You can specify TzId via Parameters. IIRC:
exDate.Parameters.Add("TZID", "America/New_York");
You may want to check if the parameter is already present before doing a blind add, as there is no duplicate checking.
But yes, it's a bug, and should be fixed.

In this case, EXDATE breaks the spec completely, as it's a date, but VALUE=DATE hasn't been set, and it has a weird duration suffixed to it.

That "weird duration" is part of the spec:
https://tools.ietf.org/html/rfc5545#section-3.3.6

That "weird duration" is part of the spec

Oh, I know that, but I meant more in terms of why it's suffixed, as EXDATE has the value types of DATE-TIME or DATE if the VALUE attribute is set, see section <IP_ADDRESS>.
Of course, yeah, for PERIOD types you have the duration suffix, so I guess it makes sense since periods are used for values in the API.
As for why it's periods in the first place, I'm guessing there was a mix-up since RDATE supports DATE-TIME, DATE and PERIOD.

I edited your original post a bit, because I'm going to tackle #259 which should take care of the first part of your ticket.

Could someone please help, i'm banging my head against the wall with what I think is a simple issue, since everything else is working, but I just can't get this to work.
I'm using VB and trying to specify  ExceptionDates.  Everything compiles and "works" but the exception dates are completely ignored when doing GetOccurance.
Could someone please post a simple example (VB or C) that shows how you would add a few exception dates to the event and make it work.
Thank you!

https://stackoverflow.com/help/how-to-ask
See the section called "Help others reproduce the problem"

I sure wish someone would fix the PID thing.

@rianjs trying to debug why EXDATE won't work for me in Thunderbird and Google Calendar and it seems to be because of it being formatted as a period list with /P1D. I understand it's part of the spec, but perhaps it would be beneficial to use a regular DATE-TIME or DATE to comply with what most Calendar clients seem to prefer?
In particular, this is the event I'm having trouble with:
BEGIN:VEVENT
DESCRIPTION:
DTEND;TZID=America/Los_Angeles:20220427T081500
DTSTAMP:20220425T095711Z
DTSTART;TZID=America/Los_Angeles:20220427T004500
EXDATE;TZID=America/Los_Angeles:20220429/P1D,20220428/P1D
RRULE:FREQ=DAILY;COUNT=3
SEQUENCE:0
SUMMARY:test
UID:42566f87-1a0e-438a-9b8d-b5b3c9d276e5
END:VEVENT

As soon as I remove the /P1D, it starts working.

Testing more now... it seems Google Calendar will only accept my EXDATE if I specify it as UTC time, offset to account for the timezone of my event. So my EXDATE has to be formatted like EXDATE:20220429T074500Z,20220428T074500Z :/

Testing more now... it seems Google Calendar will only accept my EXDATE if I specify it as UTC time, offset to account for the timezone of my event. So my EXDATE has to be formatted like EXDATE:20220429T074500Z,20220428T074500Z :/
Edit: for anyone else experiencing this, provide a date converted to UTC to CalDateTime, and set HasTime on the CalDateTime to true. That'll cause the dates to be formatted as required above.

Hey, thanks a lot @hmnd, that was really helpfull


Rework database management for tests

Expose utils to share with client lib for their own tests.

Codecov Report

Merging #2 (8635cbb) into master (87a8683) will increase coverage by 0.45%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   83.90%   84.36%   +0.45%
==========================================
  Files           9       10       +1
  Lines         261      275      +14
  Branches       30       30
==========================================
+ Hits          219      232      +13
- Misses         29       30       +1
  Partials       13       13

Impacted Files
Coverage Δ

bemserver_core/database.py
62.50% <66.66%> (+0.20%)
:arrow_up:

bemserver_core/testutils.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87a8683...8635cbb. Read the comment docs.


Add a search input to fixture list for filtering

@flavius-tirnacop-hs @andrei-picus-hs
Please review code. Last commit contains the filter function, the 'core' of the search.

Finished review.

@flavius-tirnacop-hs I've made the changes you suggested. Everything ok now?
ping @andrei-picus-hs

LGTM

@andrei-picus-hs I've addressed everything, and the components are now sorted before iterating. Is the code ok?

Finished review.

@andrei-picus-hs I've made getFilteredComponents public, I don't see a problem in being able to call it from the tests.
Otherwise it would be a bit too complicated to test, either scanning the rendered refs for desired components, or adding a prop containing "active" components.

The solution is not to make those methods public, the solution is to test them through the public methods that use them. In this case, the render method.

I don't see a problem in being able to call it from the tests

Implementation details mustn't leak inside the tests. When those details change, the tests shouldn't be affected.

scanning the rendered refs for desired components

Refs, class names, component classes... whatever the output of the component is.

@andrei-picus-hs Done.

Proper. LGTM.


Use opaque reducers in 5.7 to fix builder inference

Turns out a lot of the bugs we were working around with CombineReducers inference, as well as buildFinalResult warnings (previously: #1467) go away if we use some ReducerProtocol<State, Action> on Swift 5.7 instead of the concrete alternative.
@slavapestov Not sure if you're aware of these functional differences between inference of generics vs. opaque constrained types or would like some fresh bug reports. It can take some time to file them, but if they're not being tracked yet we can try to file down a repro.

I've tested this in isowords and things still build OK...hopefully CI here is also agreeable.


Gatsby & Material-UI break in production builds

The gatsby and material-ui frameworks does not seems to be working correctly together in production mode
I have an entire repository that reproduces this issue. You can find it at
https://github.com/bonsaiilabs/gatsby-material-ui-embed-custom-font/tree/repro
I have additionally created a video that explains the issue
This is a blocker since I cannot deploy my changes to production. Any help is greatly appreciated

[ ] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
The production application breaks when served using gatsby serve or deployed on firebase
Expected Behavior 🤔
The styling and fonts should have worked normally
Steps to Reproduce 🕹
Steps:
git clone --single-branch --branch repro https://github.com/bonsaiilabs/gatsby-material-ui-embed-custom-font
cd gatsby-material-ui-embed-custom-font

yarn && gatsby build
gatsby serve

Go to http://localhost:9000

Observe that the page has issues as font is not loaded and the material-ui styling is not applied on the AppBar. You can also find this in this video
Click on Page1 or Page2 and this will load the fonts and the styling correctly
Go to the home http://localhost:9000 and you will see the rubik font and material-UI styling being applied correctly
Refresh the page and you are back on step 0, where the page did not load the fonts and the styling is broken

This complete video shows every part in detail.
P.S.

As I understand from Gatsby documentation, we do not need to use plugin to use Material-UI. This is what you would see in the codebase where the issue is reproducible.
However, I also tried gatsby-plugin-material-ui and the issue still persists.

Context 🔦
I am not able to deploy my project that uses Material-UI in production
Your Environment 🌎

Tech
Version

Material-UI
v4.3.3, but also reproducible with  v4.5.1

React
^16.9.0

Browser
Google Chrome

TypeScript

etc.

Looking at it, https://themes.material-ui.com/ is built with Gatsby. It shouldn't be too hard to fix.

It seems to be good with:
diff --git a/gatsby-config.js b/gatsby-config.js
index 999bd3d..e2d4865 100644
--- a/gatsby-config.js
+++ b/gatsby-config.js
@@ -5,6 +5,7 @@ module.exports = {
     author: `@gatsbyjs`,
   },
   plugins: [
+    `gatsby-plugin-material-ui`,
     `gatsby-plugin-react-helmet`,
     {
       resolve: `gatsby-source-filesystem`,
diff --git a/package.json b/package.json
index 9301644..705fca1 100644
--- a/package.json
+++ b/package.json
@@ -11,6 +11,7 @@
     "gatsby": "^2.13.73",
     "gatsby-image": "^2.2.10",
     "gatsby-plugin-manifest": "^2.2.6",
+    "gatsby-plugin-material-ui": "^2.1.6",
     "gatsby-plugin-offline": "^2.2.7",
     "gatsby-plugin-react-helmet": "^3.1.4",
     "gatsby-plugin-sharp": "^2.2.13",

Thank you @oliviertassinari. After making [this] change, things seem to be working fine.
There are 2 things however

The documentation says that you don't need plugin for Material-UI, which does not seem to be true.
And what exactly this plugin does

I am still unclear. However, the problem went away. Thank you very much for the help.
If you have the answers to my questions, please let me know.

@hhimanshu Thank you for the link to the Gatsby documentation, it's a false affirmation. Here is it: https://github.com/gatsbyjs/gatsby/pull/19277.

Awesome! I am glad that we could improve the documentation to bring clarity


Deprecation Warning

Description
Deprecation Warning for Gatsby Helper plugin:
Message Elements’ getSourceId() method has been deprecated. Use getCanonicalId() instead.
Origin: /app/vendor/craftcms/gatsby-helper/src/Plugin.php:210
Craft CMS Reference: Returns the element’s canonical ID.
https://github.com/craftcms/cms/blob/develop/src/base/Element.php#L2314
Steps to reproduce

Install Gatsby Helper Plugin
Add a Preview Webhook URL in the Plugin Settings
Navigate to an entry in the Craft CP.
Navigate away from that entry.
Deprecation Warning triggered.

Additional info

Craft version: Craft Pro 3.7.20
PHP version: 7.4.24
Database driver & version: PostgreSQL 13.3
Plugins & versions: Gatsby Helper 1.0.7

Thanks for the heads up! Just fixed this and cut a 1.0.8 release.


Add autoregistering for capsule service providers.

Description
This pull request add autoloading for service providers in capsules if present.
Capsule service providers should follow the naming convention CapsuleNameCapsuleServiceProvider.

I left my autoformatting psr12 on. I can revert the style changes if needed.


How to ensure this won't report my status with others?

Issue Type: Bug
It's really creepy to see whether others are online. How to disable this spyware?

@jamo you can change your status to 'offline' in the top right corner if the Contacts pane of Live Share viewlet in VSCode.
@fubaduba @mlacouture FYI

This happened on a large OSS repo where I saw the status of people who I had never heard of before. (well they were in the git commit history with a ton of others)

@jamo, another option is to disable the 'Presence' feature in VS: Tools -> Options -> Live Share, under the Advanced group set Presence to false.  Currently you need to restart VS for the setting to take effect.


Allow floating debugger controls to be draggable to the title bar

Can we please have the floating debugger panel to be able to move to the empty space in the title bar?
Cause: The floating debugger panel sometimes obstructs the window elements while debugging any flow which traverses through multiple files.
Why this suggestion?: There is an ample amount of space available in the title bar between the window title and the layout customization panel. The space in between can be used faithfully to place the floating debugger panel.
Another suggestion: Is it possible for the command center to be transformed to debugger panel while in debug mode?

Did you try the Debug Toolbar Location settings?

With the command center, I don't actually think we should be adding new controls to the window title, there will often not be enough room. And I don't think we should remove the command center when debugging.

Did you try the other Debug Toolbar Location settings?

This has helped me out. Thanks a ton @weinand!
@roblourens The command center takes up significant space indeed, but for wider screens, there is a lot of empty space which can be used.

I agree to not replace the command center with debug tools, but I was wondering if the command center could be modified to hold the buttons for debugging... Apologies, I cannot visualize this 😅


Feature/dependency providers

Description
Provide dependencies to eCAL build by dependency providers.

I like the look of this! Will make it much easier on the vcpkg side 😄 What version are you targeting this for? Post 5.13?

@DownerCase As the 5.13 branch has been created, this will become a post 5.13 feature (i.e. 6.0 or 5.14, if there will be one)


Add crddiff: A CRD breaking schema changes detection & reporting tool

Description of your changes

This PR proposes the crddiff tool, which is a CRD breaking API changes detection & reporting tool. Example usage is as follows:
usage: crddiff [<flags>] <base> <revision>

A tool for checking breaking API changes between two CRD OpenAPI v3 schemas

Flags:
  --help  Show context-sensitive help (also try --help-long and --help-man).

Args:
  <base>      The manifest file path of the CRD to be used as the base
  <revision>  The manifest file path of the CRD to be used as a revision to the base

I have:

[x] Read and followed Upbound's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Manually tested on example CRD base and and various revisions with the following changes:

Field type changes
Enum constant removals
Field requirement changes

P.S. We may need to update uptest references in other repos as this PR proposes to move the uptest binary's package.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


WIP: Add dn-middleware-webpack5

cc @ssbabysong

webpack/webpack#11406

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: jeasonstudio:x: ssbabysongYou have signed the CLA already but the status is still pending? Let us recheck it.


Improvements to corrosion_link_libraries()

As mentioned in #505,

Allow linking by full path and non-target library name
Propagate linking dependencies to artifacts

Partially merged via #559.  What's remaining is

Propagate linking dependencies to artifacts


make verify fails on Macbook with ARM64 architecture family

How to categorize this issue?
/area dev-productivity
/area testing
/kind bug
What happened:
On Macbook with:
$(go env GOOS) = darwin  && $(go env GOARCH) = arm64
when you run make verify then it fails with the following error log:
> Installing promtool
Unknown architecture
make: *** [hack/tools/bin/promtool] Error 255

What you expected to happen:
make verify should succeed when run on Macbook M1 chipset which belongs to ARM64 architecture family.
How to reproduce it (as minimally and precisely as possible):
Just run make verify on Macbook M1.
Anything else we need to know?:
The version of promtool used currently is 2.24.1 which does not have an archive for darwin && arm64. Version 2.26.0 onwards an archive for the same has been added. The latest version of the promtool is 2.34.0
In the script there is a snippet:
case $(uname -m) in
  aarch64)
    arch="arm64"
    ;;
  x86_64)
    arch="amd64"
    ;;
  *)
    echo "Unknown architecture"
    exit -1
    ;;
esac

When you execute uname -m on macbook M1 terminal then you directly get arm64 so it does not match any case and gives Unknown architecture. This also needs to be corrected.
Environment:
uname -a >> Darwin CP2H3HJQML 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:46:32 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T6000 arm64

Gardener version:
Kubernetes version (use kubectl version):
Cloud provider or hardware configuration:
Others:

Following changes can resolve the issue:
case $(uname -m) in
  aarch64 | arm64)
    arch="arm64"
    ;;
  x86_64)
    arch="amd64"
    ;;
  *)
    echo "Unknown architecture"
    exit -1
    ;;
esac

In addition change the version of promtool to 2.34.0 These changes do not cause promtool issues any longe,  however i am not sure what will break if the version is changed elsewhere.
Unfortunately i am unable to run tests and integration tests locally so cannot confirm the change. envtest does not work on M1

@shreyas-s-rao thanks for including this change in your PR


adding post-build script for npm files listing

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
132

Relevant Lines:
132

💛  - Coveralls


Saas 17114

added the git workflow and made the docker file generic to run without any version dependency
Concern:
this is a public repo so should we add git secret here? as this is a forked repo which need licence to use else will get a copyright strike

As per discussion around this docker file we are not maintaining this repo anymore as the license allow us to use the code in any repo that way we can make the repo private and the docker files will be stored in delivery-dockerfiles repo


Chore/upgrade nx ng

Description
Upgrading to the latest Angular 15.x and NX 15.x 🥳
What's included?

Upgrading to latest NX (15)
Upgrading to latest Angular 15
Upgrading to latest Angular Material 15 (moving to MDC based styling)

Test Steps

[ ] npm run start
[ ] then open the docs app at localhost:4200
[ ] finally check the functionality of every app

General Tests for Every PR

[ ] npm run start still works.
[ ] npm run lint passes.
[ ] npm run stylelint passes.
[ ] npm test passes and code coverage is not lower.
[ ] npm run build still works.

:tada: This PR is included in version 5.1.0-beta.1 :tada:
The release is available on:

v5.1.0-beta.1
GitHub release

Your semantic-release bot :package::rocket:


Consolidating e2e tests to use new getEntriesAndErrors

What is it
In one of the previous PRs (#77), I have introduced getEntriesAndErrors as a way to get both errors and measurements for TTVC.
There is likely no point in us keeping both getEntries and getEntriesAndErrors methods - so I am consolidating the remainder of the tests to use getEntriesAndErrors.
What's the difference?

getEntries returns successful measurements that TTVC has made
getEntriesAndErrors returns both errors/cancellations and succesful measurements

Testing
No impact on the runtime - only on e2e tests ran with yarn test:e2e.

Oh, I didn't realize I was the only one with merge privileges!
I have just added the rest of the team to the repo as owners as well, for the future.


Support alert server HA

Purpose of the pull request
Right now, we can only support start one alert server, and need to write the alert server ip in worker's application.yml.
This will have some problem:

Once the alert server crash the alert cannot use.
Once the alert server ip changed, we need to update the worker's application.yml and restart the worker.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #13865 (3f78f8b) into dev (e61b8a3) will decrease coverage by 0.19%.
The diff coverage is 9.39%.

:exclamation: Current head 3f78f8b differs from pull request most recent head dfbecc8. Consider uploading reports for the commit dfbecc8 to get more accurate results

@@             Coverage Diff              @@
##                dev   #13865      +/-   ##
============================================
- Coverage     39.09%   38.91%   -0.19%
+ Complexity     4460     4448      -12
============================================
  Files          1155     1157       +2
  Lines         42268    42261       -7
  Branches       4760     4751       -9
============================================
- Hits          16524    16445      -79
- Misses        23935    23998      +63
- Partials       1809     1818       +9

Impacted Files
Coverage Δ

...org/apache/dolphinscheduler/alert/AlertServer.java
0.00% <0.00%> (ø)

...hinscheduler/alert/metrics/AlertServerMetrics.java
0.00% <ø> (ø)

...phinscheduler/alert/plugin/AlertPluginManager.java
2.43% <0.00%> (ø)

...inscheduler/alert/registry/AlertHeartbeatTask.java
0.00% <0.00%> (ø)

...nscheduler/alert/registry/AlertRegistryClient.java
0.00% <0.00%> (ø)

...phinscheduler/alert/rpc/AlertRequestProcessor.java
0.00% <0.00%> (ø)

...che/dolphinscheduler/alert/rpc/AlertRpcServer.java
0.00% <0.00%> (ø)

...er/api/service/impl/MetricsCleanUpServiceImpl.java
14.28% <0.00%> (ø)

...e/dolphinscheduler/common/constants/Constants.java
75.00% <ø> (ø)

...e/dolphinscheduler/common/utils/PropertyUtils.java
31.86% <0.00%> (-0.72%)
:arrow_down:

... and 21 more

... and 53 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Docs are not properly generated with Type column of component

Docs are not properly generated with the correct Type for the component. Each component in react-semantic-ui has a Type with its property {custom}. This does not seem correct, as I do remember seeing the Type being rendered properly. I am happy to help if I can on this. I am a new contributor to not only this project but to an open source project 😊

Strange, locally on the latest master these are correct, see below.  I'll cut a new release right now which will update the docs and we'll see what they look like then.

This was indeed fixed in the latest release.  Not sure what caused the issue initially, however.

Awesome. Thanks @levithomason !


These 'hardCodedPrimaries' are not used any more

Separate PR just to make sure specs are still green.

Self-reviewing, just waiting for specs to go 🍏