How does duphold treat N tracts

I'm curious - how does duphold treat N tracts occurring between scaffolds in less-developed assemblies?  These regions would have zero coverage, but should likely be ignored when performing fold change calculations.
Cheers,
David

for the dist.txt values, those would contribute to the denominator and artificially lower the depth percentiles for those types of contigs. contigs without large tracts of Ns would of course be unaffected.
The user could re-calc these values from the per-base coverage using extra info in the VCF at their discretion, or they could pass a --by $bed where $bed includes the assembled regions of the genome.

Is --by something I can pass directly to duphold?

oh. sorry. I was responding as if this were mosdepth.
duphold simply reads the coverage as-is, it won't do any of the stuff I mentioned and I think that would be out of scope since duphold just annotates existing calls.

I see - thanks for the quick responses!
It sounds like this is something I could try and do myself with mosdepth.  I'm unfortunately working with a highly fragmented pseudo-tetraploid assembly - not an ideal situation!

well, duphold does report GCF (gc-fraction in the info field. That will be 0 if it's all N's.).


500 error response when trying to get the Content of the File

Hi! I'm creating a WebApi application to interact with the OneDrive.
I've successfully set the subscription up to get a notification when the OneDrive items are changed. Now I want to somehow manipulate the changed file.
When I'm trying to get the methadata of the changed file it works:
var item = await client.Drive.Items[resourceId].Request().GetAsync();
But if I'm trying to get a Content of the specific file it does nothing:
 var content = await client.Drive.Items[resourceId].Content.Request().GetAsync();
ngrok tool, used to get notifications, keeps showing me a 500 Internal Server Error

I've also set the ReadWrite.All permissions for Microsoft Graph on Azure Active Directory, where my app is registered, but it says that it's not granted. Could it be the reason?

Could you give us more information about the failing request like a requestId(correlationID) and timestamp


Wumpus World

🎮 Game Request
The Wumpus World game is a classic puzzle game where players navigate through a grid-based cave system to find gold while avoiding deadly traps and the menacing Wumpus creature. The game logic involves turn-based movement, where players make decisions to move in four cardinal directions or shoot an arrow to a neighboring room. The objective is to locate the gold without falling into bottomless pits or encountering the Wumpus. Players rely on perceptual clues such as a breeze indicating nearby pits or a stench revealing the Wumpus' presence. The game features include a  cave environment in the form of grids generated with random placement of hazards and objects and a scoring system to track player performance.
Point down the features
🎯Dynamic Cave Generation: Each game session generates a unique cave layout with the randomized placement of hazards, gold, and the Wumpus, providing new challenges and experiences with every playthrough.
🎯Perceptual Clues: Players rely on perceptual cues such as breezes indicating nearby pits or stenches revealing the Wumpus' presence, helping them strategize their movements and avoid deadly encounters.
🎯Scoring System: A scoring mechanism tracks player performance, considering factors such as the number of turns taken, gold collected, and hazards encountered, adding a competitive element to the gameplay.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey  @sanikapatil06 ! Thank you for raising an issue 💗 You have been assigned this issue you can start working on the issue 🎮

Hello @sanikapatil06, Time's Uppp!⏰
Sorry for closing your issue!
But it's more than a week since we haven't received anything from your side 😢 .
Come up with new ideas, create a new issue and make sure you finish it within a week! 🔥
All the best! 🚀
Happy Hacking! 💗

Hey @sanikapatil06 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


correction of rotation angle

Since e_R_d.length() is already one, this fixes the calculation of rotation angle.

Interesting. The previous call was numerically close in most instances, but not quite. Could you explain a little more about what led you to discover this, what issues it fixed and why you think this is the correct solution (vs. the existing one)?

I built a tricopter and flew the original code. After I experienced some nervous movements of the tri while yawing I took a closer look at control_attitude. There I saw that direct yaw-control is only made for big yaw errors since normal copters have no tilt mechanism and have weak yaw capabilities. For my tri I activated the directmethod-only-control. (BTW, yaw is also not that weak on small high-spinning racingquads and directmethod-only-control should be considered/tested here also in a different issue)
After reviewing the code I discovered the bug. Line 659 computes the error of SP and attitude and represents it as quaternion. With respect to quaternion laws the angle between SP and attitude is double the angle between (0,1) and (q(0),|q|). This gives line 662: applying acos to q(0) and doubling it.
Flgiht test with tri and directmethod-only-control worked well.

@tumbili Please review again.


stdout from scripts do not get captured

this means that things like print() are essentially worthless and you lose context.

            (out, err) = proc.communicate()
            iaslog('Output from %s: %s' % (pathname, out))

this works on both user/root scripts, at the expense of everything coming in as one line.

Fixed as of: https://github.com/macadmins/installapplications/commit/82969c4fd98c8bd12f6137a73aa4f764072a5e47
You'll now see things like:
success:
2020-10-15 12:40:44.634 Python[5971:84686] [InstallApplications] Output on stdout:
2020-10-15 12:40:44.634 Python[5971:84686] [InstallApplications] DEPNotify running - relaunching!

potential failure:
2020-10-15 12:41:02.768 Python[6043:85269] [InstallApplications] Output on stderr but ran successfully:
2020-10-15 12:41:02.768 Python[6043:85269] [InstallApplications] Detected provisioned dock, exiting.

actual failure:
2020-10-15 12:40:59.653 Python[5913:84008] [InstallApplications] Received non-zero exit code:
2020-10-15 12:40:59.653 Python[5913:84008] [InstallApplications] Traceback (most recent call last):
  File "/Library/installapplications/snip.py", line 1188, in <module>
    main()
  File "/Library/installapplications/snip.py", line 704, in main
    while not profile_installed(attributes_profile_id):
  File "/Library/installapplications/snip.py", line 395, in profile_installed
    for profile in plist['_computerlevel']:
KeyError: '_computerlevel'


Compiling v3.0 on debian 9 - utest error

Hello,
I get this error, when I try to compile current 3.0release branch:
g++ -I../../objs/gtest/include -g -Wall -Wextra -O0  -I../../src/utest -I../../src/core -I../../src/kernel -I../../src/protocol -I../../src/service -I../../src/app -I../../objs -I../../objs/st -I../../objs/openssl/include  -c ../../src/utest/srs_utest.cpp -o srs_utest.o
In file included from ../../objs/gtest/include/gtest/internal/gtest-port.h:197:0,
                 from ../../objs/gtest/include/gtest/internal/gtest-internal.h:40,
                 from ../../objs/gtest/include/gtest/gtest.h:57,
                 from ../../src/utest/srs_utest.hpp:36,
                 from ../../src/utest/srs_utest.cpp:24:
/usr/include/c++/6/sstream:300:7: error: ‘struct std::__cxx11::basic_stringbuf<_CharT, _Traits, _Alloc>::__xfer_bufptrs’ redeclared with different access
       struct __xfer_bufptrs

Is this a bug?

借着楼主，我也贴一下我的构建日志：
make[2]: Entering directory '/tmp/srs-db077254b28db97f44f810f6038f0fb6eebd0cf3/trunk/objs/utest'
g++ -I../../objs/gtest/include -g -Wall -Wextra -O0 -I../../src/utest -I../../src/core -I../../src/kernel -I../../src/protocol -I../../src/service -I../../src/app -I../../objs -I../../objs/st -I../../objs/openssl/include -c ../../src/utest/srs_utest.cpp -o srs_utest.o
In file included from ../../objs/gtest/include/gtest/internal/gtest-port.h:197,
from ../../objs/gtest/include/gtest/internal/gtest-internal.h:40,
from ../../objs/gtest/include/gtest/gtest.h:57,
from ../../src/utest/srs_utest.hpp:36,
from ../../src/utest/srs_utest.cpp:24:
/usr/include/c++/8/sstream:301:7: error: 'struct std::__cxx11::basic_stringbuf<_CharT, _Traits,_Alloc>::__xfer_bufptrs' redeclared with different access
struct __xfer_bufptrs
^~~~~~
make[2]: *** [Makefile:92: srs_utest.o] Error 1

第三方组件及时换新的吧 @winlinvip

How to fix it?

For now I compile it without utest.


Allow resizing panel splits

When you have multiple panels split on one side, it would be nice if you could resize them to proportions that you desire.

Fixed via https://github.com/lapce/lapce/pull/948


CI fix: Upgrade CI image to use clang 12

Signed-off-by: Luis Fernando Pino Duque<EMAIL_ADDRESS>Description:
https://github.com/envoyproxy/envoy/pull/18220 updated run_bazel_coverage_script.sh to require clang 12 thus making the current coverage script to always fail due to https://github.com/envoyproxy/envoy/blob/0656e34e0c87a77fb87273be89afd4922a30c7db/test/run_envoy_bazel_coverage.sh#L5. This PR updates the Ubuntu CI images in the envoy-mobile repo to match the image in Envoy.
Risk Level: Low
Testing: See CI workflows
Docs Changes: N/A
Release Notes: N/A

Thanks!


broker exited and java.io.IOException

Describe the bug
22:38:28.136 [Thread-1878] WARN  org.apache.pulsar.broker.service.ServerCnx - [/xxxxxxx:42350][persistent://public/default/test-string100-partition-38][consumerSych] Failed to create consumer: Error while using ZooKeeper -  ledger=1 - operation=Failed to open ledger
java.util.concurrent.CompletionException: java.io.IOException: Error while using ZooKeeper -  ledger=1 - operation=Failed to open ledger
        at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:292) ~[?:1.8.0_101]
        at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:308) ~[?:1.8.0_101]
        at java.util.concurrent.CompletableFuture.uniCompose(CompletableFuture.java:943) ~[?:1.8.0_101]
        at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:926) ~[?:1.8.0_101]
        at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) ~[?:1.8.0_101]
        at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:1977) ~[?:1.8.0_101]
        at org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorage.lambda$openLedger$32(BookkeeperSchemaStorage.java:525) ~[org.apache.pulsar-pulsar-broker-2.5.1.jar:2.5.1]
        at org.apache.bookkeeper.client.LedgerOpenOp.openComplete(LedgerOpenOp.java:232) ~[org.apache.bookkeeper-bookkeeper-server-4.10.0.jar:4.10.0]
        at org.apache.bookkeeper.client.LedgerOpenOp.lambda$initiate$0(LedgerOpenOp.java:117) ~[org.apache.bookkeeper-bookkeeper-server-4.10.0.jar:4.10.0]
        at java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:760) ~[?:1.8.0_101]
        at java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:736) ~[?:1.8.0_101]
        at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474) ~[?:1.8.0_101]
        at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:1977) ~[?:1.8.0_101]

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]

Additional context
Add any other context about the problem here.

@xuesong172500 Would you please use bookkeeper's command to check if ledger 1 exists?

Closed as stale. Please create a new issue if it's still relevant to the maintained versions.


[CI][R][Docs] Docs preview jobs failing due to R Markdown error

Describe the bug, including details regarding any error messages, version, and platform.
The crossbow docs preview jobs have started failing with a R Markdown error:
-- RMarkdown error -------------------------------------------------------------

Quitting from lines 192-195 [unnamed-chunk-14] (arrow.Rmd)
Warning message:
The vignette title specified in \VignetteIndexEntry{} is different from the title in the YAML metadata. The former is "", and the latter is "Get started with Arrow". If that is intentional, you may set options(rmarkdown.html_vignette.check_title = FALSE) to suppress this check.
--------------------------------------------------------------------------------
---
Standard error:
Attaching package: 'arrow'

The following object is masked from 'package:utils':

    timestamp

Warning message:
In process_conditional_examples(x) :
  @examplesIf condition `arrow_with_dataset() && identical(Sys.getenv("NOT_CRAN"), "true")` is FALSE
---
Backtrace:
1. pkgdown::build_site(install = FALSE)
2. pkgdown:::build_site_external(pkg = pkg, examples = examples, run_dont_run = run_d...
3. callr::r(function(..., cli_colors, pkgdown_internet) { ...
4. callr:::get_result(output = out, options)
5. callr:::throw(callr_remote_error(remerr, output), parent = fix_msg(remerr[[3]]))

See: https://github.com/ursacomputing/crossbow/actions/runs/7772142018/job/21194228305#step:7:13155
@assignUser @paleolimbot do you have any insights into what should be updated/fixed?
cc @kou
Component(s)
Continuous Integration, R

FWIW I assume it's not related to the preview, it's just the doc build in general that is failing? (also on the main branch, the last commits have red CI for docs)

Yes, true! Changed the description and title.

Quitting from lines 192-195 [unnamed-chunk-14] (arrow.Rmd)

https://github.com/apache/arrow/blob/ed78986aa6971484f40a5780922128636a47d175/r/vignettes/arrow.Rmd#L192-L195
This error happen since 2024-02-01: https://github.com/apache/arrow/actions/runs/7742113156/job/21110485230
reticulate 1.35.0 released on 2024-02-01: https://github.com/rstudio/reticulate/releases/tag/v1.35.0
It seems that reticulate 1.35.0 is related. https://github.com/apache/arrow/issues/39933 may be caused by the same problem.


fix: toFilePath with abs path in root

I'm working on a devcontainer where the workspace path is /workspace. (which is default when configured from vscode)
When I run vitest spec including expect(doc).toMatchInlineSnapshot(), the test is passed successfully but it fails to update snapshots. The error log is like below.
$ /workspace/node_modules/.bin/vitest run src/ui/consultationEditorV2/utils/convert.test.ts
Debugger attached.

 RUN  v0.15.2 /workspace

 ✓ src/ui/consultationEditorV2/utils/convert.test.ts (1)

Test Files  1 passed (1)
     Tests  1 passed (1)
      Time  6.03s (in thread 13ms, 46366.64%)

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Errors ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

Vitest caught 1 unhandled error during the test run. This might cause false positive tests.
Please, resolve all the errors to make sure your tests are not affected.

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯ Unhandled Error ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Error: Errors occurred while running tests. For more information, see serialized error.
 ❯ Object.runTests node_modules/vitest/dist/chunk-vite-node-externalize.0ec89ad1.mjs:7089:17
 ❯ processTicksAndRejections node:internal/process/task_queues:96:5
 ❯ async file:/workspace/node_modules/vitest/dist/chunk-vite-node-externalize.0ec89ad1.mjs:10369:9
 ❯ Vitest.runFiles node_modules/vitest/dist/chunk-vite-node-externalize.0ec89ad1.mjs:10379:12
 ❯ Vitest.start node_modules/vitest/dist/chunk-vite-node-externalize.0ec89ad1.mjs:10306:5
 ❯ startVitest node_modules/vitest/dist/chunk-vite-node-externalize.0ec89ad1.mjs:11074:5
 ❯ start node_modules/vitest/dist/cli.mjs:666:9
 ❯ CAC.run node_modules/vitest/dist/cli.mjs:662:3

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: {
  "errors": [
    [Error: ENOENT: no such file or directory, open '/workspace/workspace/src/ui/consultationEditorV2/utils/convert.test.ts'],
  ],
}
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

/workspace/workspace/src/ is a wrong path. the correct is /workspace/src/.
After debugging, I've found a bug in toFilePath function when given absolute path as id and root directry as base. And this will solve this problem.

Interesting, do you think this might also fix #1196 and #1534?

Both seems related, I think this solves those issues!


"Enable self-service password reset" doesn't appear to be in the list of improvement actions

Lab: 4
Exercise: 1
Task: 02
Step: 05
Description of issue
"Enable self-service password reset" doesn't appear to be in the list of improvement actions after following the guide.

@TesterTesterson1004, I was able to find the Enable self-service password reset improvement action in Compliance Manager, but I had to make sure Joni had Compliance Administrator access granted from lab 1, exercise 1, task 1 and Compliance Manager Administrators access granted in lab 4, exercise 1, task 1. It's possible it takes a moment for permissions to replicate after lab 4, exercise 1, task 1, so I'll add a note that if you're not seeing that improvement action you might have to wait a few minutes.


Map Service Injection Trouble

Hi. I have had a lot of trouble getting the injection of BingMapsService working properly. From delving through all open/closed issues and sparse documentation, I finally reached a solution to get the instance of the map object itself, using the method done in issue #29 . However, I am not happy with this result as it's not particularly clean. Whenever I inject the map instance like I would any other service, and add the BingMapService as a provider, none of the methods resolve/reject their promises, and the map instance is null.
Could anyone explain on how to properly inject the service to get map attributes?

In your html you can do something like this:
<x-map #xmap [Options]="_options"                           (MapPromise)="_processMapPromise($event)"                          (MapService)="_processMapService($event)"

you can catch the map by waiting for the $event to be resolved like this:
 mapPromise.then(x => {       this.map = x;     });

@PaulGG: did this solve your problem? can I close this issue?

yes, all good


Assign role to all server members with a connected API key

I would like GW2Bot to assign a role to all server members who have set up their API key, preferably on server join or when the key is added thereafter.

Mega-up of this issue.
Multiple reason come to my mind :

Filter user that can use or not the bot, and guide them if necessary
Authenticate user by guild wars account (can be helpful if you have to identify people in game & on discord at the same time)
More generally, can be use as a verification process (for guild members without using syncrole)

I'm sure there are more reason to use this feature. Can also be related to this issue

The reasons sound good and this feature would be pretty easy to add. I could use some name suggestions for the command, though :P

This is a thing now


Upgrade url-exist and patch up test and jest config

Like https://github.com/quarkusio/extensions/pull/195 from dependabot, but actually works.

I'm confused by this PR, since I can see most of its changes in my codebase. I wonder what happened? It was a whole month ago, so I obviously don't remember. :)

This ended up being complicated, to get the right balance of ESM and CJS. I updated the babel config to transpile the url-exist module, but that wasn't enough to allow it to be required. However, a normal import wasn't ok, so I had to do a dynamic import, which returns a promise.


Multiple NULL characters

Multiple NULL characters
Font
Fonts stored here: https://github.com/notofonts/notofonts.github.io/tree/main/fonts/NotoSans/googlefonts/ttf
Where the font came from, and when
https://github.com/notofonts/notofonts.github.io/tree/main/fonts/NotoSans/googlefonts/ttf
Font Version
Version 2.012; ttfautohint (v<IP_ADDRESS>-5d5b)
OS name and version
Noes not matter.
Application name and version
Does not matter.
Issue
There are two glyphs in the fonts 'NULL' with a unicode and 'null' without a unicode.
Nothin major, but as I noticed it, it's worth to mention it.
Character data
NULL
null
Screenshot

It does not break any functionality.

Yeah, it's not a problem; it comes from merging two fonts both of which have NULL in them; you can see that one comes from the Latin subset and one from the Devanagari.


Corrections and new language

Correction:
I was not carrying the translation skills correctly.
New language:
Added language Portuguese (Brazil)
Note: I did not know if I could add my name as a "contributor", but I would like to be part of your team.
Hugs! :)

I added improvements in the Portuguese (Brazil) translation and another correction.


CI pipelinine to autobuild for various OS & Archs

linux-x86_x64, linux-arm64, linux-arm32, windows-amd64, windows-amd32, macos-intel64, macos-AppleSilicon

@jbeyerstedt can you double check, if the workflow file is correct ?

@jbeyerstedt can you double check, if the workflow file is correct ?

I did try it out with a PR, "vx.x.x" Tag and push on main branch. Seems to work fine. Im not sure if the filenaming is "correct"

@jbeyerstedt dont merge yet. There are sone issues it seems like

@jbeyerstedt Okay now its ready to be merged

Borked windows build in between because it's the only one with .exe file names.


(for consideration) address smell:  fixture data changes affecting so many tests at once

When doing certain code tweaks, the recommendation for writing test code goes something like:

you'll need to make a change to the uberTemplate testing fixture to write your test (because you need n things from that template to exercise the conditions necessary for your test)
get your test working
look at all the tests you made fail by tweaking the uberTemplate ... and fix them.

This ... smells.
Were we in rails, I would say it's time to use factories to produce the so-called "fixtures" we want with the traits we want for each test.
I don't know if there is that sort of "factory" solution for us, or if it is easy to create that.  Or maybe we can break up our fixtures and combine them as needed?
This is but one way that writing tests is hard in this code base ... but maybe it's a tractable problem.

We could write smaller templates for testing, but that would defeat the purpose of the Uber-ness of the Uber template. However, for some of the tests the Uber template may not be necessary and a less volatile template could be selected.
Can you list some of the tests that you find break?

Sadly, it's been too long -- @peetucket  might be able to identify some brittle tests as he mentioned at standup this morning he was struggling.
We can keep this ticket until someone encounters the fun anew ...

finished by @justinlittman


No output in SplitThreader

Hi, I am trying to use SplitThreader on my yeast genome data, but I have some problems. I upload the .bedpe file (from Sniffles) and the .csv file (from copycat), but I can't see any output, I can't see the structural variations or the coverage plot.
The first message seems ok:
"Starting...

Reading input files

Sniffles bedpe file
Number of variants filtered out due to small size (minimum size is 1000): 48

Segmenting copy number

done"
but I don't see nothing:

It's also strange for me the fact that when I try to use copycat I receive this warning:
/home/cai/copycat-master/copycat ALL-MMy005_ngmlr_sort.bam -g chr.txt MMy005-copycat
"

*****WARNING: Genome (-g) files are ignored when BAM input is provided.

"
When the usage example tells that the genome file is needed:
Usage:
copycat alignments.sorted.bam genome_file output_prefix
Can this be related with the fact that I have not output in SplitThreader?
Thanks

The warning is likely coming from bedtools, which copycat uses under the hood, so you may have a newer version installed that doesn't need the -g file anymore. The coverage csv file is human-readable so you can check if it makes sense and has the same chromosome names as your variant file. If you post the first few lines of that coverage file, I can help you troubleshoot.

Thanks, these are the first few lines of my .csv file:
chromosome,start,end,unsegmented_coverage
chr01,0,10000,8.1822
chr01,10000,20000,9.213
chr01,20000,30000,10.2026
chr01,30000,40000,11.8462
chr01,40000,50000,11.983
chr01,50000,60000,15.3404
chr01,60000,70000,13.9089
chr01,70000,80000,16.1405
chr01,80000,90000,17.0873
chr01,90000,100000,17.6456
chr01,100000,110000,22.039
chr01,110000,120000,19.9698
chr01,120000,130000,14.9096
chr01,130000,140000,17.0698
chr01,140000,150000,17.4384
chr01,150000,160000,17.5956
chr01,160000,170000,27.1267
chr01,170000,180000,23.1103
chr01,180000,190000,18.0006
chr01,190000,200000,14.8789
chr01,200000,210000,9.5362
chr01,210000,220000,10.512
chr01,220000,230000,9.9087
chr01,230000,230222,3.24324
chr02,0,10000,5.3064
chr02,10000,20000,6.3053
chr02,20000,30000,6.5715
chr02,30000,40000,11.7827
chr02,40000,50000,11.4552
chr02,50000,60000,13.1165
chr02,60000,70000,14.2613
chr02,70000,80000,15.047
chr02,80000,90000,15.8066
chr02,90000,100000,15.5467
chr02,100000,110000,17.6214
Seems to me that the chromosome names are correct for the yeast, ranging from 1 to 16.
Is there any limit to the chromosomes size? I am most interested in one of these chromosomes that is only 100kb long, its name is chrsyn09R in my sample, but I didn't see it in the graphic circle and neither the mtDNA (85kb).

SplitThreader was made to work for cancer data, so it was assumed to be human data, and it filters automatically to the main chromosomes. It might take some work to make it work for yeast, but if you send me the URL I can take a look. In the meantime, you might find my other tool Ribbon at genomeribbon.com to be useful. Ribbon isn't specific to human and it also shows the variants as connections between chromosomes.

Thanks a lot, this is the URL for my SplitThreader data:
http://splitthreader.com/analysis.php?code=SPDiHhRGe1WdKTyTUErG
I already know Ribbon, is a very useful tool and it has a very cool design, I used it many times, but now I have some strains with one circular chromosome with a very complex structure and I wasn't able to solve/understand them also with Ribbon
URL of Ribbon data for example:
http://genomeribbon.com/?perma=Nc78rfW0fb
So I wanted to try using this other tool and see if the things are going better.


there is no way to color the helper and input text

in element mwc-textfield and mwc-textarea, I can not find a way to set helper text color, input text color, background color and unfocusd outlined outline color

unfocused outlined outline color already exists:
--mdc-text-field-outlined-idle-border-color.
The other ones I'm working on in a PR right now


Added closing of the scheduled thread executor if appropriate

If we are using an InstantiatingExecutorProvider then we should shutdown() the executor so we don't leak threads.

I think ExecutorAsBackgroundResource should already take care of this right?


need dehazing pre-trained model

Hi,
can you please share pre-trained dehazing model? the existing latent-dehazing.pth is not generating the results as you have shown in the document.
Thanks

Hi,
You can find all pre-trained weights of the Refusion model here.
Best.

Great, thanks let me try it, much appreciated your help.

Hi,
When I am running python test.py -opt=options/dehazing/test/nasde.yml using codes\config\latent-dehazing\test.py, and latent-reffusion-dehazing.pth, I am getting bluish picture, and when I am using latent-dehazing.pth then getting totally different output, but not like you have presented as Non-Homogeneous dehazing, you can find the results here . I am new to this, it will be great if I may get your assistance, much appreciated the help.
Thanks

Hi,
The provided U-Net latent model is only trained for the NTIRE HR Non-Homogeneous dehazing dataset. If you want to use it for other haze datasets (such as SOTS indoor or NH-HAZE), you need to retrain the U-Net model for latent-refusion in this directory.
Or you can just download the images from the NTIRE challenge.

Thanks, but when I tried U-Net, I got multiple error, when fixed one got other, and some how I managed to run it, but couldn't got the expected results, the deraining algorithm works too good but can't manage to run dehazing algorithm (unet-latent), is the code up-to-date?
Thanks again and sorry for being pain.

Hi, are you meet the problems in training the u-net or testing the latent-Refusion model? I could write a separate paragraph to show how to train and test the latent-Refusion.

Now I updated the code for latent-Refusion, hope it works!

Yes, the code works fine now, thanks, but it is not dehazing the image, can you please share any image that you have tested, so that I may run it and test it on my system? for Unet-latent, I am using pretrained weight that is latent-dehazing.pth, but the input and output image looks identical, moreover I notice that the deraining model works great for many random images downloaded from google as long as the image has better resolution, if I used same image with lower resolution, it was not deraining.
My main target is to get dehaze model running.
Thanks, really appreciate your help

Great! But the unet-latent is only used to compress the image thus the input and output are almost the same. If you want to test the dehazing results, you should get into the "latent-dehazing" directory and change the dataset path and pre-trained model paths.
Here are some validation images you could have a try.
Best.

Moreover, note that the performance of our model highly depends on the training dataset. We only trained the model on the Rain100H dataset thus it makes sense that it didn't work very well on lower-resolution raining images. But you can easily retrain the model on your own dataset to get better performance.

Thanks, When I used Latent-dehazing, the output is purple colored image, which does not look like input image please check here,

Hi, you can test images from the HR dehazing dataset: https://codalab.lisn.upsaclay.fr/my/datasets/download/14df5793-f1c2-4f32-aaa7-d60b7d6dd6be

And if you want to test the indoor haze images, I can also provide another IR-SDE code and pretrained model for indoor dehazing.

Wow, Works great on these images, Thanks.
Just a suggestion, since your code is compatible on Linux, so I had to make some minor adjustments in it to make it work on windows, so if you update line number 10, 11 and 67  of options.py file, and line number 40 and 41 of test.py file, then it will work on both Linux and windows. you can add condition to check OS and use commands accordingly.
That's just a suggestion, I hope you won't mind.
Thanks, you have been great help.

And if you want to test the indoor haze images, I can also provide another IR-SDE code and pretrained model for indoor dehazing.

yes please, that will be great, much appreciated

Hi，Did you train the dehazing task using only 40 hazy/haze-free pairs? This is too incredible. I would like to reproduce this experiment, can you provide a link to download the training data? thans!

Sure. Here is the challenge website in which you can download the dehazing dataset (but you need to register the challenge first): https://codalab.lisn.upsaclay.fr/competitions/10216.

Sure. Here is the challenge website in which you can download the dehazing dataset (but you need to register the challenge first): https://codalab.lisn.upsaclay.fr/competitions/10216.

I have applied to participate in the challenge, but have not got a permission. Maybe the challenge is over and no one is in charge of it. Can you provide the training set, if possible？

Ok, I guess the dataset would be released later. But I can send you the training and testing data through email.

Ok, I guess the dataset would be released later. But I can send you the training and testing data through email.

If you can provide the data that would be great, here's my email<EMAIL_ADDRESS>

Ok, I guess the dataset would be released later. But I can send you the training and testing data through email.

another question，in the validation set of NonHomogeneous Dehazing, there is no haze-free data, so how did you set up the validation dataset

Ok, I guess the dataset would be released later. But I can send you the training and testing data through email.

another question，in the validation set of NonHomogeneous Dehazing, there is no haze-free data, so how did you set up the validation dataset

Hi, we just divided 5 image pairs from the training data as the validation dataset. Thus actually we use 35 and 5 pairs as training and validation datasets, respectively.

好的，我想数据集稍后会发布。但我可以通过电子邮件向您发送训练和测试数据。
Hello, could you also send me a fog dataset, thanks, here is my email<EMAIL_ADDRESS>

Ok, I guess the dataset would be released later. But I can send you the training and testing data through email.

another question，in the validation set of NonHomogeneous Dehazing, there is no haze-free data, so how did you set up the validation dataset

Hi, we just divided 5 image pairs from the training data as the validation dataset. Thus actually we use 35 and 5 pairs as training and validation datasets, respectively.

When I trained the unet-latent using dehazing dataset, I found that the training processing was very slow and the gpu utilization was very low because a lot of time was spent on loading data.  How long did it take to reach  about  300000 iterations during your training? How did you solve this problem during training?

Hi, maybe you can pre-crop the images to a cropped training dataset with smaller image sizes. An example code can be found in this script.

Hello, did the author pre-crop the image during training?

Hi, maybe you can pre-crop the images to a cropped training dataset with smaller image sizes. An example code can be found in this script.

Hello, did the author pre-crop the image during training?

Yes.

如果你想测试室内雾霾图像，我还可以提供另一个 IR-SDE 代码和用于室内去雾的预训练模型。
您好，麻烦请教一下在Image Restoration with Mean-Reverting Stochastic Differential Equations附录中

在indoor数据集上的结果是采用哪个代码进行训练的呢？是否有预训练模型呀？

@azlanqazi2012
Sorry to bother you, I would like to ask what changes need to be made to these codes on windows.
thanks a lot.

很抱歉打扰，我想请问这个问题应该怎么解决

谢谢您，我正按照您说的训练UNet

Wow, Works great on these images, Thanks.
Just a suggestion, since your code is compatible on Linux, so I had to make some minor adjustments in it to make it work on windows, so if you update line number 10, 11 and 67 of options.py file, and line number 40 and 41 of test.py file, then it will work on both Linux and windows. you can add condition to check OS and use commands accordingly.
That's just a suggestion, I hope you won't mind.
Thanks, you have been great help.

Hello, even though I used the HR dehazing dataset, the test result is still purple. May I ask how you solved it？


Add a simple Lakeshore 331 driver.

Mostly copied from the 336, although there are some differences. Notably, there are only two channel inputs A and B, and one of the commands from the 336 does not exist on the 331. Tested on my own 331, let me know if I should do more.
@jenshnielsen

There is a major rebuild going on with the Lakeshore driver base. In the PR #972 you will find an almost finished version of the new structure. It would be great if you could base the driver off that new base class.

Sure, no rush. I'll update this once that PR goes in.


catalystproject-latam: Fix PLNC GPUs

Ref: #4162
The requested images (quay.io/jupyter/pytorch-notebook, quay.io/jupyter/tensorflow-notebook) don't recognize the GPUs and don't have nvidia-smi installed.
I tried using the cuda tags, but they don't work either.
However, the pangeo images are working correctly. What other images can we use for GPUs?
PD: The timeout error still happens sporadically.

@yuvipanda can you help me with this one?
According to this, it should work, right?
https://jupyter-docker-stacks.readthedocs.io/en/latest/using/selecting.html#cuda-enabled-variant

I've opened https://github.com/jupyter/docker-stacks/pull/2124 about this @AIDEA775
It can be very messy to try to adjust PATH and LD_LIBRARY_PATH because they are secure environment variables with special rules applicable to them - due to that I'm not sure we can workaround this quickly. Due to that my current idea is that we wait a week at least to see if the PR gets a review and is deemed reasonable to merge.

@AIDEA775 I pushed a commit bumping the tag, and nvidia-smi now executes and I think everything should work fine in these images as well.

The timeout error still happens sporadically.

It took me 6 minutes to start using the jupyter pytorch image, which included server startup + image pulling. I think it would be good to figure out what takes too long time when timeout happens. I expect it could be either scaling up or image pulling - where the scaling up part is hard to resolve, while the image pulling may be a network performance degradation that could be fixable somehow.


domain used for cookie - an issue in the example

Fortunately the discussion in issue #14 helped me figure this out.  Eventually... :-).
Could not get the buttons to register for TOTP or U2F.  Kept getting a message that "the email could not be sent" - which I thought indicated an issue with the file-based notification.
Could get the notification.txt when doing a password change, so dug deeper.  Added and ran tcpdump on the authelia_auth instance, and was seeing the 403 error for all calls - and noticed the domain for the cookie...
Ran into two different issues while verifying this - I think credential may be cached so that log-out doesn't work, and saw some occasional odd connection problems with the ldap server.  But tested enough to determine that those do not seem related to this change.
Thanks, and Best Regards,
Paul

Hello @pccasto , thank you for the fix. Indeed, it was a mistake.
For the 2 issues you reported:
1/ Logout procedure should invalidate the session by modifiying an attribute in the session. Then, during next access to the secret the check procedure should return a 401 error code. I will test it soon.
2/ I also figured some connection problems with the LDAP. This is due to a bad implementation of the reconnection at the level of the ldapjs npm module. Actually, when connection is not used for a long time it is closed and the client goes into 'idle' state. On next query, the client should start a new connection. There is a flag that if set to true should automatically start a new connection but it works only after the second request... The first one fails...
Thank you very much again for the fix.
Clément.

Hi Clément,
Thanks for the project.  Glad to be able to help.
Best Regards,
Paul


Add minor UI brush-ups

[x] Do not reload the list every time the settings are opened. Make the list adaptable to changes

[x] Split preferences into multiple tabs

Not reloading the list requires significant rework, because of how the flow of opening files is built. This will be changed along with architecture refactoring instead of this minor UI task.


As a Quick MAPS User, I want to share the current dashboard via a URL, So I can get bookmark it for later or share with colleagues

User story
As a Quick MAPS User, I want to share the current dashboard via a URL, So I can get bookmark it for later or share with colleagues
Acceptance criteria

[ ] Current state of the tool (selected nation, micronutrient etc.) is stored in the URL params.
[ ] Loading a page with URL params loads the appropriate data/visualisations
[ ] UI provides a means to view/copy the permalink to the current state

visualization JS libraries:


FreeRTOS+TCP : Adding a Network Interface for STM32H7

A Network Interface for STM32H7
Description
Adding a simple Network Interface for STM32H7. It was published earlier on the FreeRTOS forum by Thomas Kindler.
Now adding it to the FreeRTOS repo so it doesn't get lost and all users can have access to it.
It still needs some modifications to optimise it and handle the PHY more properly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

About commit "Changed the order of initialisation":
In xNetworkInterfaceInitialise(): do not create a task before both the ETH and the PHY have been initialised.
Reason: the task will take over the ETH and the PHY, and poll for the Link Status.

This doesn't build for me. Some names from STM32Fxx are used such as xETH which is not defined in the STM32Hxx NetworkInterface.c

This doesn't build for me. Some names from STM32Fxx are used such as xETH which is not defined in the STM32Hxx NetworkInterface.c

Hello Brendan,
This is not yet complete and cannot handle the PHY properly.
Still, @htibosch, can you can give him some pointers? it would be great.
Thanks,
Aniruddha

All right, I did the following:

Merge branch 'master' into htibosch:STM32H7_network_interface
Added the code that uses phyHandling.c
Start making use of the ISR callbacks like HAL_ETH_RxCpltCallback
Test compiled with STM32H745xx defined
Committed and pushed the changes

Please see this post about the origin of this network interface.
@brendanhaines : you can also ask questions about the STM32Hxx driver in mentioned post.

/bot run checks

Closing this PR #48, because it will be replaced by a new rebased PR #79


Installing mods with dependencies from modrinth does not work

Failed installing mod: json: cannot unmarshal object into Go struct field Version.dependencies of type string

Trying to install modmanager (packwiz modrinth install modmanager)
https://modrinth.com/mod/modmanager
MR api for the specific version (curl -i -s 'https://api.modrinth.com/api/v1/version/CdhVgHal'):
"dependencies":[{"version_id":"E4QBMVtO","dependency_type":"required"}]

According to @wafflecoffee, dependencies aren't stable in the v1 Modrinth API, and not worth supporting yet (especially as they are not usable on the Modrinth website itself yet). For now, I'll stub out the dependency checking code, and add support once the v2 Modrinth API is ready.

@comp500 Now that the V2 API is in production, would reopening this issue be possible?


LP Kids Website Update

**Department: **Marketing
**Name: **Cate Jaques
**Job Name: **LP Kids Website Update
**SAP Project Name & Number: **
**Region: **Global
**Key product stakeholders: **Cate Jaques, Seb Neylan

#Type/Format
Job Type: Digital
Does this job require a kick-off meeting? Yes
If yes, who should be invited to the call? Me, Seb Neylan
Require development resources? Yes
Format: Web page on LPKids.com
Specs: Same as existing
Amount of colors: 4 colour
Bleed Required? no
Print Run:
Printer Contact

#Important Dates
Drafts Due CST: w/c 4th April
Final Artwork Due CST: w/c 11th APril
Live Date/Deliverables from Printer:
Flexibility in Due Dates?

#Description
Project Description:
We have growing activity sheets and teachers resource packs for Lonely Planet Kids. We would also like to be able to target groups and direct them to the website separately - e.g. directing teachers to the website for teaching resources for their region: and directing parents to the site for activity sheets.
We'd like to change the current 'teachers and parents' page to:
Activities
And add another  tab for: Teachers
Activities
This page will hold activities sheets from books and the ones that we are creating each month for our newsletter.
We'll need an updated banner that says
Activities
Loads of fun activities for kids and families including colouring in sheets, quiz's and fun activities.
Then heading: Activity Sheets
all sheets can be uploaded here.
New tab for 'Teachers' - is that a separate request?? Let me know & I will either add to this board or create a new request.
What does this project hope to achieve?
Clarity of purpose for this page and somewhere to upload the activities we're creating for the LP Kids newsletter which are really brilliant - so we can link back to the website from our newsletter each month 'for more'.
Key Message, Considerations, Audience
Audience = parents
Key message = as above
Considerations = also need to upload four activity sheets from the newsletter which I can add to board - they are PDFs

#Images
Image purchasing info:
License images for other/global use?
Image direction:
Is there a budget for purchasing images for this job?
What is the max image budget?
What is the cost center?
What is the GL code?

INTERNAL POST-MORTEM
(Designer to complete this section)
Initial design hours:
Dev hours:
External costs USD (freelance, images, etc.):
Rounds of revisions:
Design hours on revisions:
Time allowance (job submitted to drafts due):
Due date met:
Hiccups:

This issue was moved to lonelyplanet/kids#52


Avoid conversion using type(value)

We should not assume that the following works to convert 1 to the same "type" as value:
t = type(value)
x = t(1)

In particular, this would break for many SageMath types.
As alternative, doing arithmetic with the given value does work for SageMath types and all standard Python types.

Thanks!


Remove no formatters defined message

This is a bit of a preference than a fix, but I think the log doesn't make much
sense & removing it actually can simplify the setup a bit.
autocmd BufWritePre * Format

Instead of keeping track of which filetypes that should be formatted in two
places, the table inside setup & the autocmd.
The user can just add this autocmd & forget about it & the plugin will do the
right thing.

I think im going to keep things the way they are. Thanks thought!


[Hexagon] Add RPC Mechanism for Hexagon

This PR:

Reuses minRPC implementation for hexagon to create RPC connection from host to hexagon device which is passed through android RPC server.
Adds HexagonLauncher which manages file upload to Android, initiate RPC server on Android and manage RPC session to hexagon.

This will build:

libtvm and libtvm_runtime using hexagon LLVM andtvm_rcp for host.
libtvm_runtime_android.so and tvm_rpc_android for Android under build/hexagon_rpc
libhexagon_rpc_skel.so library which include RPC server for Hexagon under build/hexagon_rpc

cc @areusch @csullivan @adstraw

@kparzysz-quic thanks for pointing out these issues. I will address these in the next PR for AOT executor.


Add a scene for the DSLR-based compositor

This change adds a scene for compositing DSLR-based scenes. This change includes only the scripts necessary to set up the native compositor with the correct textures and audio input and run the composition loop.  None of the user interface to view the composition in the editor or to control the compositor have been added yet.

Shader "SV/RGBToNV12"

we probably need to be sure that all of these files have licenses at the top as well.

Refers to: Assets/MixedRealityToolkit.Extensions/SpectatorView/Resources/Materials/RGBToNV12.shader:1 in 1add9ab. [](commit_id = 1add9abac398d97278a72a10257e85168ef607ec, deletion_comment = False)

Thanks for adding the more robust summaries!


Cardinality for Anthurium 'Ace of Spades' cultivar should be 1, not 2

Name: Anthurium 'Ace of Spades'

Canonical: Anthurium ‘Ace of Spades’

Authorship:
~~

```json
{"parsed":true,"quality":1,"verbatim":"Anthurium 'Ace of Spades'","normalized":"Anthurium ‘Ace of Spades’","canonical":{"stemmed":"Anthurium ‘Ace of Spades’","simple":"Anthurium ‘Ace of Spades’","full":"Anthurium ‘Ace of Spades’"},"cardinality":2,"details":{"uninomial":{"uninomial":"Anthurium","cultivar":"‘Ace of Spades’"}},"words":[{"verbatim":"Anthurium","normalized":"Anthurium","wordType":"UNINOMIAL","start":0,"end":9},{"verbatim":"Ace of Spades","normalized":"‘Ace of Spades’","wordType":"CULTIVAR","start":11,"end":24}],"id":"3adaf031-08f2-576e-b9af-616bf328473e","parserVersion":"test_version"}

We will leave cultivar cardinality as is, but will not try to assign ranks based on cardinality


Fix CI

There's a few issues with the CI:

[ ] It throws trivial warnings like -Wparantheses
lib/src/TheThingsNetwork.cpp: In member function 'void TheThingsNetwork::configureUS915(uint8_t, uint8_t)':
lib/src/TheThingsNetwork.cpp:422:37: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
if (ch == ch500 || ch <= chHigh && ch >= chLow) {
^

I couldn't find out how to disable a warning:
https://github.com/platformio/platformio/issues/816

[ ] It throws warnings for missing builtin libraries like Wire:
In file included from lib/src/Hackscribble_MCP9804.cpp:24:0:
lib/src/Hackscribble_MCP9804.h:27:18: fatal error: Wire.h: No such file or directory
#include <Wire.h>
^
compilation terminated.

[ ] When I add  --project-option="lib_deps=Wire" to fix it fails over errors in libs we include:
lib/src/Hackscribble_MCP9804.cpp:246:118: error: default argument given for parameter 2 of 'void Hackscribble_MCP9804::configureAlert(boolean, uint16_t)' [-fpermissive]
void Hackscribble_MCP9804::configureAlert(boolean action, uint16_t settings = ALERT_ALL | ALERT_LOW | ALERT_INTERRUPT)
^
In file included from lib/src/Hackscribble_MCP9804.cpp:24:0:
lib/src/Hackscribble_MCP9804.h:99:8: error: after previous specification in 'void Hackscribble_MCP9804::configureAlert(boolean, uint16_t)' [-fpermissive]
void configureAlert(boolean action, uint16_t settings = ALERT_ALL | ALERT_LOW | ALERT_INTERRUPT);
^
lib/src/Hackscribble_MCP9804.cpp: In member function 'uint8_t Hackscribble_MCP9804::_readRegister8(MCP9804_Register)':
lib/src/Hackscribble_MCP9804.cpp:51:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
lib/src/Hackscribble_MCP9804.cpp: In member function 'uint16_t Hackscribble_MCP9804::_readRegister16(MCP9804_Register)':
lib/src/Hackscribble_MCP9804.cpp:79:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
*** [.pioenvs/sparkfun_promicro8/lib/src/Hackscribble_MCP9804.o] Error 1

I'm not sure how we can ignore these files to be compiled/checked.

Overall I do think platformio is great to use for ci, but until we know how to tune it better I'll first do a PR to disable it.


query: deprecate extended query parser

Refs: https://github.com/expressjs/express/pull/3621

I thought about checking the parser type before throwing deprecation, but then found that it wasn't necessary, as we are hard-coding it to extended
the query part in var deprecate = require('depd')('query'); is my assumption about how it should be, let me know if that is not the case
feel free to propose changes to the message.

thanks!

I am expecting the following app to generate the deprecation warning with these changes, but I'm not seeing it. I believe I should be running the copy of your code, but just wanted to give it as a test case here if you wanted to confirm:
var express = require('express') // or './index' for testing
var app = express()

app.get('/', (req, res) => res.send('hi!'))

app.listen(3000)

@dougwilson - yes, I can confirm that:
#cat 4208.js
var express = require('express') // or './index' for testing
var app = express()

app.get('/', (req, res) => res.send('hi!'))

app.listen(3000)

#node 4208.js
express deprecated default extended query parser deprecated, set explicitly to override query.js:4:5
^C

And on the other hand, if the user explicitly sets the parser, the  warning is suppressed:
--- a.js	2020-03-10 09:03:02.000000000 +0530
+++ b.js	2020-03-10 09:02:39.000000000 +0530
@@ -1,5 +1,6 @@
 var express = require('express') // or './index' for testing
 var app = express()
+app.set('query parser', 'extended')

 app.get('/', (req, res) => res.send('hi!'))

looks like const in strict mode broke CI. Pushed a change. @dougwilson - are you good now with the changes?

Thank you @gireeshpunathil ! I also got my local working correctly now to try out a couple things. I found the following example file is not generating a deprecation, when I would expect it to do so due to app2 using the deprecated API:
var express = require('express')
var app1 = express()
var app2 = express()

app1.set('query parser', false)
app1.get('/', (req, res) => res.send('hi!'))
app1.use('/api', app2)

app2.get('/users', (req, res) => res.json([]))

app1.listen(3000)

The above is an example of a basic sub app being mounted in an app. It seems that the order of declaration of the two (or more depending on the set up of users) apps will dictate if another app in the same process detects if the deprecated API is being used.

@dougwilson - just pushed a change to address your scenario, please have a look!

Nice! I need to figure out what is wrong with my local environment tomorrow, because even though it says it pulled your updates, the code I posted above still prints no deprecation warnings when I run it. I need to figure out why my local is not picking up the fix.

ping @dougwilson - this and https://github.com/expressjs/express/pull/3621 - any blockers here? pls do the needful!

Hi @gireeshpunathil I have tried a few more times today to see if your latest comment resolved the issue above, but it does not seem to. I am definitely using your latest code, yet when I run the code I posted in https://github.com/expressjs/express/pull/4208#issuecomment-598380781 there is still no deprecation message printed as expected. Are you 100% sure that is printing a deprecation message?

@dougwilson - the code in that comment has explicit call to
app1.set('query parser', false)

right? as per the design you suggested, it is not supposed to print warning?

There are two apps, one which is not using a deprecated API (app1), but the second app (app2) is using the deprecated API, and should cause a deprecation to be emitted. You can see that app2 never sets the query parser, so it is using the default of extended, and this is supposed to print a deprecation warning when the user did not set the query parser on their app and instead is relying on the default behavior.

(everyday is an opportunity to learn something new! I was under the impression that you were struggling to test the patch due to setup issues, did not realize you were waiting for me to fix anything. I am sure with close collaboration over time, we can understand each other)
so here is my perceived design:
no explicit setting of query parser: throw warning, one per app
explicit setting of query parser: don't throw warning, for the app that over-rode it.
is this how it should be according to you?

pushed a change to that effect, PTAL!

tests have passed; however continuous-integration/appveyor/branch seems to be waiting for something that I cannot figure out (no link, the preview text is partly hidden). Anything actionable from me here?
/cc @dougwilson

tests have passed; however continuous-integration/appveyor/branch seems to be waiting for something that I cannot figure out (no link, the preview text is partly hidden).

Yea, something changed on the AppVeyor side. I spent a couple hours investigating this on Sunday and got the issue resolved (you'll see it no longer pending on this PR or a few others where it was stuck).

so here is my perceived design:
no explicit setting of query parser: throw warning, one per app
explicit setting of query parser: don't throw warning, for the app that over-rode it.
is this how it should be according to you?

Yep, that sounds right. I would just want to make sure that we don't want to throw the warning though, as we want the app to continue to work without the users needing to wrap something in a try catch.

I would just want to make sure that we don't want to throw the warning though, as we want the app to continue to work without the users needing to wrap something in a try catch.

deprecation warnings print informative messages and move on, they do not affect the control flow in any manner? The current change follow that model, unless I am missing something?
can you clarify that it is meant to be a statement to complete the design of deprecation, as opposed to a change request in the current PR?

deprecation warnings print informative messages and move on, they do not affect the control flow in any manner? The current change follow that model, unless I am missing something?

Right, that is what I'm looking for. You're saying that you're planning to throw the message, though, which is what I wanted to make sure was not going to happen. When you throw something in JavaScript, it does interrupt the control flow, as you need to use try catch to "catch" what was thrown.

can you clarify that it is meant to be a statement to complete the design of deprecation, as opposed to a change request in the current PR?

Appologies, I don't understand this question. Is there a different way you can word it or provide some additional clarification that may help?

@dougwilson - apologies if it caused confusion.

Right, that is what I'm looking for.

actually answers my question. But to try rewording my question:

would just want to make sure that we don't want to throw the warning though

For your this comment, I meant to ask: Do you mean to say the current code is not meeting this design, or you are just stating that the control flow should not be affected? But it is clear to me now that the confusion came from my usage of the word throw, and its established usage in JS.
For me, throw warning means print a message and move on,
and throw error means alter the control flow with an error description.
but it is just me, ha ha.

Hi @gireeshpunathil sorry, that was my bad; yes, I was thinking when you say "throw" you are referring to the throw keyword, especially since you could certainly throw a warning, there is no way to understand off-hand that you didn't meant to actually use the throw keyword, my mistake. Glad we could clear that up 😃

@dougwilson - review comments address, please have a look!

@dougwilson - b311f277eb34bf9fb21e3bb02f479489e5a8ecbd : thanks for pushing, is it to satisfy some linter? if so, I see the neighbors of the changes do not follow the rule? is it that the new rule applies to new changes only?

is it to satisfy some linter? if so, I see the neighbors of the changes do not follow the rule? is it that the new rule applies to new changes only?

From https://github.com/expressjs/express/blob/master/Collaborator-Guide.md :

Follow the JavaScript Standard Style

Discussion in https://github.com/expressjs/discussions/issues/70

We are currently converting the code base into Standard style by converting each line that we touch when making changes.

it has been 10 days, what is required for this to land?

Please @gireeshpunathil I know you mean well but I would love to not need to restate every week what we said in the TC meetings :)

need to restate every week what we said in the TC meetings :)

pardon me for the ignorance (TC happens at my 5 AM so at times it is possible that not all what is said is heard / understood well). Mind restating it for clarity?

Up to the previous TC meeting the work was done to begin the 4.18 release, but did not complete work due to the agreed priority to get a list of item folks can work with in parallel (the website docs). At TC meeting we spoke of the two security issues which are always the number 1 priority. We fixes one and discussed the fix for the second, which I'm working on to release this weekend.

While I was awaiting to get clarity around the docs situation around the release processes (thanks @wesleytodd for chiming in on that on Sunday!) I had my teams test a branch of Express with this (among other things) deprecation on it. From there experience, I think we ought to forgo having this deprecation on the 4.x line and just make the 5.0 change and leave it for the migration guide.
The biggest thing raised from testing (and I can see where it comes from) is that making just a basic Express app without writing anything wrong ends up emitting the deprecation warning -- every tutorial out there, even our own getting started, etc. That is not necessarily bad, but because it's actually the omission of doing something that is the warning, it turned out it was quite confusing.
Many users have never used a setting before, and since the query parser is also a "special" setting in 4.x (fixed in 5.0 already) where you have to set it before any other middleware, routes, etc. it turned out to be even more confusing on how to "fix" the issue, as folks would have settings not necessarily at the very top.
Additionally, it also pretty much makes it even more wordy to write Express-based onliners since now you have to include the query parser setting just to get something quick done, making oneliners a bit more unwieldy.
The deprecation added to missing options in bodyParser.urlencoded and in express-session also caused a lot of opened issues and user confusion, but I think this is even more confusion than those, which were already borderline, as at least those the user had like bodyPaser.urlencoded() directly in there code where it was obvious on where to add the option to (since the message pointed to the file and line number of that call) where as this deprecation has no such hint and typically simple apps have no calls to app.set anywhere; coupled with the user has to set the query parser setting in 4.x specifically in a certain part of the calls due to the 4.x bug around it's setting.
None of this is an issue with the quality of the work done on this PR, rather feedback on the concept itself. @expressjs/express-tc may want to weigh in as well. I am very heavily learning towards this deprecation being too disruptive and suggest we skip this one.

thanks @dougwilson ! user experience is extremely valuable, and it proved time and again! I can relate to all what you wrote!! kudos to your team that spent time on this, and provided candid and critical feedback!
I am happy to close this instantly on these grounds:

deprecation printed on the most common use cases
no obvious location visible to the user to circumvent the deprecation

but may be as you pinged the TC, let us wait for their views as well!

Yes. I am actually a bit sad, as I think deprecations are valuable, but this one turned out quite aggressive and I don't think there is any other way around it. I pinged the TC to double check mainly to give anyone a chance to advocate for the deprecation if there is a strong opinion.
I expect we will have a path forward with all these things by tomorrow night (my reference frame) to get the 4.18 PR open and, if this deprecation is not landing, the related 5.0 change merge to that respective branch.

Ok, so it is past the TC meeting, and though no TC members were present to make a decision, it has sat here for a bit for feedback, and the PR author has agreed we should not go forward with it, so I'm going to close this out instead of landing in 4.18.
Thank you for your hard work on this PR regardless.


[Feature] More command aliases

Allow users to define a list of command aliases like:
command-aliases:
- inventoryrestore
- invrestore

Although this can be done through the commands.yml, such command aliases lose out on auto-completion.

I added these aliases, not sure If I want to add a feature like this right now, maybe later


Could not identify extension for 'vscode' require call from

Hello,
I am very happy to have found this extension as it simplifies tasks that were built into other editors I used before.
I adopted one of the examples and noticed the follwing in the "Extension host" log window upon VSCode startup (line breaks added)
[exthost] [warning] Could not identify extension for 'vscode' require call from
    file:///c%3A/Users/xyz/.config/vscode-macros.js.
These are the extension path mappings:
  file:///c%3A/Users/xyz/.vscode/extensions/exceedsystem.vscode-macros-1.3.0 ->
    EXCEEDSYSTEM.vscode-macros

 ... other extension paths following ...

This is in the "global" part of my file
const vscode = require('vscode');  // I presume this to be the culprit

module.exports.macroCommands = {
  // makro deklarations
}

async function oneMakro() {
  const editor = vscode.window.activeTextEditor;
  if (!editor) return;
  // code
}

I am not very proficient in VSCode's API so it's likely I am doing it wrong and the line needs to go someplace else; or sth. is missing from your Gist example which I used as a blueprint.
If this isn't a "bug", any help would be appreciated :-)
Thank you.

Thank you for the report.
However, how exactly can I reproduce the problem?
Please also more detailed information such as vscode version and etc...
Regards.

I was able to reproduce it.
This is not a bug, it is by design.
Because this warning is caused by the VSCodeMacros extension calling the vscode API from outside the extension path, so there is no need to worry about it.
Regards.

ok, thanks.
I was just puzzled 'cos the code I wrote runs perfectly well.
Now I need to locate Code's API reference so I know what other fancy stuff I can do :-)

Is the following the VSCode API reference you are looking for?
https://code.visualstudio.com/api/references/vscode-api
The following VSCode extension samples may be useful for creating macros.
https://github.com/Microsoft/vscode-extension-samples


Embulk error using KSH

Hello,
Will embulk work on KSH? I am getting an error in KSH but not on BASH
Thanks in advance!
> embulk --version
Error: Unable to access jarfile embulk

Hello, @doctor
You can use java -jar /path/to/embulk
And another way, #1093

As a bonus information, at some point during upcoming v0.11.*, we are going to remove execution with the single embulk-based command-line as explained in #1496.
I'd anyway suggest you to start using a command-line based on java -jar embulk.jar.

Thank you. it works! POC using digdag and embulk is a huge success. I am working on installing embulk and digdag on higher environments....
@hiroyuki-sato and @dmikurube can you please let me know if I need to be concerned about any vulnerabilities such as log4j?

Generally speaking, it is user's responsibility to take care about vulnerabilities about open-sourced software. We may provide some information if something happens, but we don't guarantee/promise anything. So, shortly speaking, yes you need to be concerned about any vulnerabilities by yourself.
Specific to Log4j, the Embulk core uses SLF4J + Logback, neither Log4j 1 nor 2. But, it does not mean that any Embulk plugin does not use Log4j in it. If some Embulk plugins you use have Log4j in them, it may be affected. As far as we know, plugins maintained under https://github.com/embulk/ do not have Log4j, though.

Anyway, the original issue (about KSH) is considered to be resolved. Closing this issue.


Set Authority for Vault Account

Hello, I'm working on a separate (non-escrow) project, and been using this as a reference.
I am facing an issue when trying to transfer the Token Account authority. In this codebase, this is relevant to the authority transfer of vault_account on Line 45 of lib.rs.
Note: I am using different versions of anchor-spl, version 0.25.0, however I haven't found reason to believe this is the source of the issue.
In my example, the equivalent to Line 156 of test.ts fails as the _vault.owner address is the Token Program, not the program PDA.
Any help is appreciated, thanks.

Would it be possible that the authority is not set correctly?


[SPARK-37078][CORE] Support old 3-parameter Sink constructors

What changes were proposed in this pull request?
This PR aims to support 3-parameter Sink constructors which have SecurityManager as the 3rd parameter.
Why are the changes needed?
Apache Spark 3.2.0 cannot load old Sink libraries because SPARK-34520 removed SecurityManager parameter and try to create Sink class with two-parameter constructors.
Does this PR introduce any user-facing change?
This will recover the breaking change.
How was this patch tested?
Pass the CIs with newly added test coverage.

cc @HyukjinKwon and @srowen

Thank you, @HyukjinKwon .


[Core] Misc Specification fixes

This started out a routine clean up as part of #101. It however turned up a few bugs in Specification. Largely due to the somewhat suspicious dev practices ~we~ I had when I wrote this some very, very, long time ago in a text editor far away.
As Specification is quite a pivotal class in this API, it is worth sorting these out now regardless of what is happening when it comes to the C++ port.
The first few commits are mild linter fixes, the rest add test coverage to properly define the expected behaviour and fix the issues that surfaced.

I notice that a couple of commits don't have the issue # in them, was that intentional?

I notice that a couple of commits don't have the issue # in them, was that intentional?

Yeah, the "fixes" for Specification that weren't specifically linter-related didn't really have an associated issue.

Squash and merge when ready!


The footer covers the bottom of the venu setup pages

I've gotten the published staging version of planorama running. I'm trying to set up our venue, but can't because the footer covers the "cancel" / "save" buttons at the bottom of the page. So I can't tell which option is selected to create the venue and the other options.

the quick fix for this is the rake task called chicon.rake, but customize it for yourself. we still need to actually design this page. if you want an example of customizing, take a look at arisia.rake in the arisia branch

the other thing you can do as a temporary fix is go into the browser inspector and add the class "scrollable" to the container element... I can probably give you a one liner that does this, hold on.

lolol surprising third option - this is one of those pages that is surprisingly not broken on your phone. I mean it's definitely broken looking, but the buttons appear fine, interestingly. you could probably also zoom out your page an absurd amount as a quick fix.

Ok workaround: On the venue page, open up your javascript console, and run the following 3 lines:
$('.tab-pane .scrollable').classList.remove('scrollable')
$('.b-overlay-wrap.position-relative').classList.remove('position-relative')
$('.b-overlay-wrap').classList.add('scrollable')

Then click each of the other 2 tabs (venues and room setups) and run just the first line while on each tab. That should at least make the scrolling work right until we fix it.

Internal ticket: https://chicon-planorama.atlassian.net/browse/PLAN-805


URL Format When Specifying Path & Non-Master Branch

Hello,
I'm trying to use gitfs to retrieve files from a repository using a path and pointing to a branch that isn't master. What is the correct format for the URL to use with gitfs.New()? The documentation doesn't give a specify example when using both a path and a branch in the URL. I've tried the format github.com/owner-name/project-name/some/path/to/director@heads/PRO-72 but I just get a 404.

Hey there,
See New() doc
Did you try github.com/<owner>/<repo>@<ref>#<path>?


Internationalization (I18N)

Tasks

[ ] Investigate and design a I18n interface for skins to use.
[ ] Build and test I18n interface.

References

https://github.com/vime-js/vime/tree/master/core/src/components/core/player/lang
https://github.com/vidstack/player/blob/main/docs/architecture/overview.md#skins

Outdated issue, library doesn't need anything special for I18N support anymore 😄


Vue Draggable

Would it be possible to use https://github.com/SortableJS/Vue.Draggable within JustPy?
As always, big thanks!

Not currently, but I will add it to a future version.


Mass distributions via transactions instead of the genesis state

          Maybe it'd be better to do these kind of mass distributions via transactions instead of the genesis state?

The genesis state is baked directly into most execution clients, and I think it'd be much more convenient if it's kept small like the other testnet genesis states :)
I've written a small tool that we're using in the ephemery testnet to do individual fund distributions after each reset.
It's designed to work with a large set of addresses, so maybe it's worth to consider it for this too.
https://github.com/pk910/testnet-funding-tool
Edit:
I've been curious to see how the tool works with such a big address set.
It's working quite well. I've distributed 1 ETH to each of the eligible addresses timbeiko posted before on the ephemery testnet.
That's a set of 497596 addresses.
It took about 5h to complete (20 tx per block with batches of 20 transfers each, so 400 transfers per block).
Could have been completed in 2,5h too by using the full available block size.
Nice side effect: I didn't know that so many of my own dev addresses were eligible for the grabteeth.xyz drop :D
I never checked them all one by one,  but due to my distribution test I can easily identify them now, as they're all having a balance of 1 ETH on ephemery now
Originally posted by @pk910 in https://github.com/eth-clients/holesky/issues/1#issuecomment-1452860234

Heya,
Great to see that this Idea is being liked :)
I've made some changes to the funding-tool, that allows it to run offline, just generating a list of signed transactions.
These signed transactions can then be broadcasted by anyone who likes once the network is live.
The tool basically deploys the distributor contract and uses that for all subsequent transactions, due to the increasing tx nonce all transactions are forced to run in order.
The tool can also be run from a gihub action from within this repository.
When doing so, the private key could either be random and destroyed afterwards (it's actually no longer needed, as the list of signed transactions is everything this wallet should ever be allowed to do), or it could be read from a github secret (so it's still there in case of an emergency, but outsiders like me don't have access to it).
I think from the previous discussions that we want to start with a "base"-list of eligible wallets?
Should we just take the grabteeth.xyz list, or filter it further?
In addition there should be another tracking issue for arbitrary address collection.
I guess we can't fully prevent such an address collection issue from being spammed, but maybe we can enforce some "basic" rules.
I've thought about implementing a kind of comment moderation via github actions too:
https://github.com/pk910/funding-list
When adding/editing a comment in "https://github.com/pk910/funding-list/issues/1" a github action is triggered that checks if:

There is exactly 1 eth address in the comment
The ETH address hasn't been commented yet
The User didn't create another comment in the issue yet

There could be more strict checks added easily. eg. a check for a gitcoin passport?
Happy for feedback :)
If you like the Idea I can add these action workflows via a PR

Why not use a pull based contract?
use OAuth2 and  see user activity across github

I've opened PR #10, which adds a workflow to run the funding tool from within this repository.
That way it's fully trust-less and does only rely on someone (probably @q9f) triggering this workflow.
The output from the workflow (signed list of transactions) can be submitted by anyone once the network is live.
We should further discuss which addresses should be eligible.
With the big grabteeth list of 497,596 addresses that's a total of 4,975,960,000 ETH...
That sounds quite high.. Don't know if that's desired to have so much funds in the network?
(I'm slightly worried about all type of chain spamming)

I've composed another list of addresses, which contains addresses that successfully deposited to the beaconchain on goerli or mainnet.
As the network is more intended for CL testing, I think it's more reasonable to pre-fund these addresses instead of wallets that deployed a contract.
My final list looks as follows:
Goerlli [txt / csv]  11350 Addresses
Mainnet: [txt / csv]  20680 Addresses
Combined:  [txt] 31773 Addresses
To compose the lists I've done the following steps:

I've crawled all Deposit Events from the deposit contracts and loaded the corresponding transaction details via this script
The raw output of the script can be found here:  goerli  /  mainnet
It includes the validator pubkey, withdrawal address if set via 0x01 creds on deposit, block height, depositor address & forwarder contract if sent via another contract.
I've joined the current validators state via a json dump from the getState api.
Invalid deposits were removed during this merge operation as there is no corresponding validator state for them.
Grouped the data by the latest withdrawal credentials.
This basically combined all validators that use the same withdrawal address to a single entry in the list.
I've preserved the first depositor address for each group for the next step.
Grouped the data by the depositor address.
This basically combined all validator groups from the last step that were deposited from the same source wallet.
Filtered out well known entities like Lido and CEX pools like Kraken/Coinbase/...

Steps 2-5 are done by a excel sheet, which unfortunately got too big for github (>100MB each),
I can share it if anyone is interested in the aggregation steps in particular :)
However, I'm also open for other aggregations if anyone has a better way to do it.
If anyone wants to play around with the data, I've added a link to the raw outputs of the crawler above.
In the last holesky planning call it has also been decided to keep the amount of funds in the network limited to "a few 100M" and the mass distribution should be lowered to ~1-2k for each address.
So, various ways to go forward:

We use the grab-teeth list of 497k addresses to distribute 1k HolETH to each.
Total Amount: 497M HolETH (pretty much already exceeds the intention of a few 100M supply cap)
We use the combined list of depositor addresses (31k addresses) to distribute 2k HolETH to each. (enough for 62 validators)
Total Amount: 31M HolETH
We use a combination of both lists, to distribute 100 HolETH to all addresses from the grab-teeth list & 1k HolETH to the list of goerli/mainnet depositors.
Total Amount: ~65M HolETH

Some input would be great as I don't really want to decide that alone :)

I'm wondering if there is a significant benefit to doing this compared to having an address with 50M ETH fronted by a faucet, where people can fetch 33ETH at a time with suitable restrictions.
Note that we can always create a second address with 50M ETH, which can be used to distribute funds via the above method and one of the lists at a later date.  As long as we have the ETH lying around, we don't have to be in a rush to distribute it.

Why not just use SELFDESTRUCT to distribute all the ETH? It should be the most scaleable way to do so in fact.

@mcdee The reason why I am pushing this is, that we have the ability to do this mass distribution fully trust-less by publishing a signed list of transactions before genesis. These transactions can then be checked and the origin wallet funded via the genesis state. After the network is running, these transactions can be broadcasted by whoever wants to do so (I will do so, but it's not forced to be me). I agree we can do this mass distribution after genesis, but that's no longer trust-less then, as it then depends on someone doing this at some time.
I'd suggest adding some "reserve wallets" controlled by EF anyway. If these reserve funds are never used, fine. But we should absolutely avoid running into the same situation as goerli again. It's ultra nerve-wracking for so many devs...
@sambacha Can you explain more? I've tried the SELFDESTRUCT way, but always ended up paying more fees than with regular calls.

https://gist.github.com/sambacha/25e167ef0a5093f206bb5a9ba9900b57

If you did not see my last comment here is the contract:

pragma solidity >=0.7.6 <0.9.0;

contract TransactionConduit {

    function massTeleport(address payable[] memory _recipients, uint[] memory _amounts) public payable returns (bool) {

      uint numRecipients = _recipients.length;

      require(numRecipients == _amounts.length, 'FAIL! PARAM SIZE');

Conduit unstablePortal = new Conduit();

      for (uint i=0; i < numRecipients; i++) {
        unstablePortal.teleportEtherTo{value: _amounts[i]}(_recipients[i]);
      }

      uint remainingBalance = address(this).balance;

      if (remainingBalance > 0) {
        unstablePortal.teleportEtherTo{value: remainingBalance}(payable(msg.sender));
      }

      return true;
}

    function voidEther() public payable {
      Conduit unstablePortal = new Conduit();
      unstablePortal.teleportEtherTo{value: msg.value}(payable(address(unstablePortal)));

    }
}

contract Conduit {
  function teleportEtherTo(address payable _recipient) public payable {
    selfdestruct(_recipient);
  }
}

@sambacha
I've seen it and I tried modifying my distribution tool to use it.
Unfortunately I've always ended up paying more fees than with normal transfers.
Example with 20 transfers to new wallets (no state yet):
Normal transfers:  725,991 Gas tx
SELFDESTRUCT transfers: 905,562 Gas tx
With exactly your contract code: 921,495 Gas tx
Am I missing something?

@pk910 if I'm understanding this correctly, the benefit is that it allows you to send Ether to smart contract recipients without executing any of their code
but since this is to be done at genesis, I'm not too sure that's going to be an issue to begin with?
maybe I'm missing something here as well

Aah, fair point 👍 and totally agree that it is a reasonable thing to consider in some situations.
However, I think for this initial fund distribution it's not necessary, because there are no contracts deployed at genesis. And because our funding list contains non-contract addresses that deployed some contracts before only, there can't be any code deployed on any of these addresses itself.

@pk910 do we expect issues wrt nonces?

Not that I'm aware of.
The nonces actually ensure that all transactions are executed in strict order and no funds are sent to the distributor contract before deployment or so.
If any of the transactions gets dropped from the mempool it can simply be re-broadcasted.

Done, thanks for this. :)
https://github.com/eth-clients/holesky/actions/runs/5991155800

It looks like only 491 of the 11,350 addresses in @pk910's goerli depositor list are part of funding-list.txt. Is only the grabteeth list being used? I'd imagine a lot of current goerli stakers would be happy to roll onto holesky if their addresses are funded.

Yea, that's correct.
I actually didn't receive any feedback on the second list I've composed,
so as time was going on we've used the original grabteeth list only.
We cannot change the list anymore at this point in time (transactions are signed and published - no way to undo that).
However, we could probably organize a second smaller drop for the addresses on my second list.
There is an assignment of 500,000,000 ETH for the distribution.
497,596,000 ETH will be distributed, some fees will be burned (<100ETH), so there are about 2,403,900 ETH left.
If we take the combined list of 31,773 addresses for mainnet/goerli depositors,  we could distribute about 75 ETH to each.
I could top it up to 100ETH by using some of my faucet assignment too.
Still not that much, but still enough to spin up 3 validators :)
@q9f What do you think about it? You're the key holder ;)

If we had known this a couple of days earlier, we could have bumped the initial balance so that we have a bigger buffer.

Yea, completely agree. And I'm slightly sorry for that.
However, from my point of view, I'm just a regular holesky user, no special client dev role or similar assignment in the ETH world (yet).
So, if I propose a completely separate list of addresses to fund, I'd expect at least a small feedback like "yea, let's do it" or so from a relevant person. Otherwise I see it as not accepted and continue with the original proposal.
Maybe I should just see such updated proposals as accepted in future if nobody complains..
Or ask for feedback more "aggressively"?
Anyway, that's how it is now and I think it's not bad at all to fund contract deployers.
For distribution of the remaining balance to depositors we should wait for the initial distribution to run through.
I don't want to change the signed transactions at that point in time. I think it's best to do it after genesis

watch it getting drained 🤓
https://holesky.etherscan.io/address/0xd3994e4d3202dd23c8497d7f75bf1647d1da1bb1


Typed repositories for Firestore

Firestore Storage on Github
npm install firestore-storage

We have multiple NodeJS production apps written in Typescript which are heavily based on the Firestore Admin. From that this library was created, since we copied a lot of boilerplate code from each project.
It follows the repository pattern. For each collection you create a repository which provides you with a typed save, delete and multiple querying functions for listing and finding documents.
You can easily replace the "driver" from the default Firestore implementation with an included in-memory implementation for testing. It's also compatible with one of your favorite open source library out there, the dependency injection library Inversify.
Since it helped us a lot and saves us a lot of code we made it opens source and published it on npm. Feedback much appreciated

@Bartinger I'd be happy to add this repo to the site!  Just add the .opensource configuration to your repo (as explained in the issue template) and then let me know.

@samtstern Just added the project.json to the repo. Let me know if you need anything else.
Thanks :)

@Bartinger looks good to me!  Your project should appear on the site in the next 24h

@samstern just wanted to ask if there's an problem with our repo or the project.json, since it hasn't been published on the site?

@Bartinger this is why they shouldn't let me code alone:
https://github.com/firebase/firebaseopensource.com/commit/12a5084059d850c1218197c10c35a7978e751183

@Bartinger
https://firebaseopensource.com/projects/freshfox/firestore-storage/

@samtstern 😆 thank you very much


Allow more granular control of video recording

This issue is basically just a bump of #336.
While the video recording feature is great, it seems to me that the most likely use case for recording video is not per session but per test, with the name of each video being the name of the test with the exit status appended. So, something like item-can-be-added-to-cart.failed.mpg or item-can-be-added-to-cart.success.mpg.
Does the video-recorder or selenoid container provide an API to accomplish this?
Thanks

@EvanShaw no, it does not. But there is an alternative video recorder: https://github.com/presidenten/selenoid-video-api

@vania-pooh Thanks for the quick reply and suggestion. I'm considering using that alternative if need be.
I just want to confirm one thing though. In #336, you said:

We are currently considering another approach which could help to solve the same issues

Did you guys ever implement what you were considering?

@EvanShaw I don't think so and I frankly can't remember what we were considering.

@vania-pooh Okay, I'll close this then.


Failure in implicit resolution involving intersection types

Compiler version
3.2.2
Minimized code
trait X[A, B]
class Y[A](a: A)

trait Test {
  implicit def xy[A, B]: X[Y[A], B]

  def summon[A, B](a: A)(implicit ev: X[A, B]): X[A, B] = ev

  // Doesn't have to be AnyRef
  def y[A](a: A & AnyRef): Y[A & AnyRef] = Y(a)
  object a

  val ok = y(a)
  summon(ok)   // ok
  summon(y(a)) // fails
}

Output
16 |  summon(y(a)) // fails
   |              ^
   |No given instance of type X[Y[A & AnyRef], B] was found for parameter ev of method summon in trait Test
   |
   |where:    A is a type variable with constraint >: Test.this.a.type
   |          B is a type variable
   |.
   |I found:
   |
   |    this.xy[A, B]
   |
   |But method xy in trait Test does not match type X[Y[A & AnyRef], B].

Expectation
The code compiles

Fails in 3.4.0
https://scastie.scala-lang.org/lIH0PERRR12K2NlO80O7lQ
Fixed in 3.4.1
https://scastie.scala-lang.org/Uvub1CDESsWOTbJOz7Aung
Still works in 3.5.0
https://scastie.scala-lang.org/VFEj6eKJQxiFPuTPmDbgww


can.route.default

can.route.default({page:""});

would indeed be a mere interface for:
can.route("", {page:""});

…but, it'd self-document itself in our projects and would be an easy find in the official documentation.

@James0x57 Just a documentation change.  I can walk you through it.


Auto Dependency Updates ...

Waiting patiently ...

@lguzzon Thanks for this, but I've decided to keep most of the dependencies locked untill after 0.11, at which point I will start a restructure and rewrite of the development files, which will change dependencies.

Never mind ;)


🐛Fixed XSS vulnerability involving post excerpts

fixes https://github.com/TryGhost/Ghost/issues/17058

Uses the lodash escape function.
Avoids XSS vulnerabilities in post excerpts.

🤖 Generated by Copilot at d347a0a
Fixed a security issue by escaping excerpt text in excerpt.js. This prevents malicious HTML or scripts from being rendered in the post summaries.

Hi @daniellockyer
I see you merged my patch into a branch somewhere outside of this repo. I was wondering if you had any comments on this PR?
This is my first time submitting a PR to this repository (or any non-personal repository for that matter) so I am unfamiliar with what the process is to have my PR accepted and merged.

Joel

@joeldesante thanks for the contribution! Sorry for letting this one sit.

Not a problem at all! Thanks!


Added provisioning of Python 3.6 for runway & SAIO

I dunno... Maybe:

Travis CI (ProxyFS/.travis.yml)
CI (@gerardgine knows what, if anything, additional)
runway (ProxyFS/cookbooks...)
SAIO (ProxyFS/saio)
Native MacOS (although here only Go code is built/tested)
Native Linux devs (perhaps @charmster could answer)
SwiftDebBuilder (it actually disables most of the testing... just builds the .rpm)


Do we need Microsoft RSA Root Certificate Authority 2017 for Baltimore to Digicert proper migration?

As per the below article, we have to update the certificate from Baltimore to Digicert
https://techcommunity.microsoft.com/t5/internet-of-things-blog/azure-iot-tls-critical-changes-are-almost-here-and-why-you/ba-p/2393169
My question

Do we still need the "Microsoft RSA Root Certificate Authority 2017" certificate?
Microsoft document says, 1. If your devices use a connection stack other than the ones provided in an Azure IoT SDK, then action is required: - so what does it means??
What does it means "Make sure SHA384 for Server certificate processing is enabled on the device"

@deepakkumpala
Thanks for your feedback! We will investigate and update as appropriate.

@deepakkumpala
Thank you for your feedback!
Since this issue isn't directly related to improving our docs, and to gain a better understanding of your issue, I'd recommend working closer with our support team via an Azure support request. Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
Teams Q&A forum for technical questions about the configuration and administration of Microsoft Teams on Windows.
Microsoft Teams Community forum
Thank you for your time and patience throughout this issue.