Internal/unit tests that mock GotocCtx

It would be nice to have internal unit tests that can call into RMC functions like pretty_name_from_instance. Right now, I think the testing infrastructure only supports running rmc on full *.rs files.

Some unit tests on mock objects from core rust for inspiration: https://github.com/rust-lang/rust/blob/289ada5ed41fd1b9a3ffe2b694e6e73079528587/compiler/rustc_mir/src/dataflow/framework/tests.rs#L307

@bdalrhm  has found out that we can support these tests by defining functions with the #[test] annotation and calling ./x.py test -i --stage 1 compiler/rustc_codegen_llvm/
However, in the case of function pretty_name_for_instance (and many others) there is a need of mocking up complex objects to pass them as arguments before calling the function:
    pub fn pretty_name_from_instance(&self, instance: Instance<'tcx>) -> String {
        format!(
            "{}::{}",
            self.tcx.crate_name(instance.def_id().krate),
            with_no_trimmed_paths(|| instance.to_string())
        )
    }

Here, self is a GotocCtx object, which is defined as:
pub struct GotocCtx<'tcx> {
    /// the typing context
    pub tcx: TyCtxt<'tcx>,
    /// the generated symbol table for gotoc
    pub symbol_table: SymbolTable,
    pub hooks: GotocHooks<'tcx>,
    pub type_hooks: GotocTypeHooks<'tcx>,
    /// a global counter for generating unique names for global variables
    pub global_var_count: u64,
    /// map a global allocation to a name in the symbol table
    pub alloc_map: FxHashMap<&'tcx Allocation, String>,
    pub current_fn: Option<CurrentFnCtx<'tcx>>,
}

Of course, it is possile to define GotocCtx instances by mocking up underlying objects, but there is no guarantee that the whole GotocCtx would be valid then. This would probably involve too much effort just to test a single function.
Another option is to dump real GotocCtx objects from a given program and load them in the unit tests. There are two issues with this:

The process would be equivalent to test the function on a given program.
The dumped objects would remain static, which would not allow us to detect regressions on the compiler front end.

Neither of these options look good to me. These could be alternative solutions:

Refactor functions under tests and decouple them so that they do not need complex objects like GotoCtx. This may not be possible for all functions we want to test.
Start a new test module that works on the JSON output produced by RMC. This would be similar to what we already do in some tests where we check that a set of lines are present in the CBMC output.

Closing this issue as it seems there is no need for this kind of internal tests anymore (testing for dyn trait handling is being done on Rust programs), but we can revisit in the future if needed.


Use TryTaskWithRetry to check if pull secret is set

Add TryTaskWithRetry helper method to retry tasks that are canceled or times out
Use TryTaskWithRetry to check if pull secret is set. Show a error notification in case RetryableTaskFailedException is thrown

Closes #130 #128

@gbraad Updated, PTALA!


PayjoinLifecycleManager only listens on the main secure wallet (NOT urgent)

The current PayjoinLifecycleManager is only set up for the main secure wallet. For each instance of secure wallet to maintain feature parity across wallets.
This isn't showstopper for production release of something that works, but it's going to be a surprise incomplete behavior if it's not fixed.

Fixed on 0.4.0


Images in all of Wagtail’s supported formats

Currently the bakerydemo only contains JPEGs. I’d like to see at least one example of each format Wagtail supports, to simplify testing things like https://github.com/wagtail/wagtail/pull/10781. For formats that are interchangeable with JPEG we can just change existing images. For formats that aren’t (PNG, GIF, SVG), we’d likely need new visuals, or perhaps new content (all keeping on theme).
As well as making our Wagtail core testing easier, I suspect having mismatched formats will also be a more realistic representation of real-world content.
I don’t think this is a must but we could also include:

Format conversion in image template tags.
Examples of using images "lossless". Ideally only in a part of the site where this is indeed appropriate for a site (so not on a decorative image)

We now have format conversions in #465. And I’ve realised as well as SVG images we’re also lacking preserve-svg usage (wagtail#12285).

I've opened a PR for this issue here https://github.com/wagtail/bakerydemo/pull/506, although there are two unresolved problems however.

Finding a lightweight and contextually appropriate free to use giff.

Issue described in the current PR here https://github.com/wagtail/bakerydemo/pull/506#discussion_r1760793761

Supporting SVGs.

I ran into the issue referenced above (although closed in favor of https://github.com/wagtail/wagtail/issues/11570), when trying to add SVG support, the issue will first need to be resolved in Wagtail before being added to the bakerydemo, without needing to regress current usage of image tags to work around open issues. e.g. not having to convert {% picture author.image format-{avif,webp,jpeg} fill-50x50-c100 preserve-svg  to {% picture author.image format-jpeg fill-50x50-c100 preserve-svg
Adding SVG support to bakery, also requires some thought around how to extend/populate the sites data with SVGs whilst staying on theme, I would suggest adding the following SVGs as an ImageBlock on a recipe page and along with a new Author snippet.

ImageBlock -> https://svgsilh.com/image/1294246.html
Author -> https://svgsilh.com/image/307076.html

Example


build/semantic-release

:tada: This PR is included in version 0.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Only "Primary" class gets new spells upon level up (Gestalt issue)

Pretty much the title, have the most up to date version this time
"Primary" - Monk Sensei (wanted the monk outfit)
"Gestalt" - Priest of Balance Cleric/Enlightened Philosopher Oracle
In this case cleric SEEMS to be gaining spells since its automatic (clerics get all spells) and i get my "mystery/archetype" spells for oracle but don't get to choose any beyond first level unless i choose oracle as my primary

This should finally be resolved in the linked preview build in the discord or the next published nexus build.


Option to disable schema

Fixes #8

Coverage increased (+0.3%) to 91.837% when pulling 781f03eb5854c526f48ee669d8824616e6be08fb on rorygibson:option_to_disable_schema into 23dcc71b935c396506c258f2249c53d136b26dce on trevershick:master.


changes related to logo and skip functionality

for one student we can save multiple subject marks .
when student is marked as absent its count is not shown in save status and scan status . and the information of that student is also not showing it in save status .
student list was not coming proper when we were switching different classes of same school .
local storage count was not proper it is resolved now . it was happening because we were using react old method(navigate now its replace with push) .
in local storage if student count is more than 50 it is showing alert message .


Keyboard graphic doesn't pop up in expanded mode, which is a problem during tutorials (where there's no keyboard under the small game window.)

Describe the bug
When I click the keyboard key beneath the expanded game window, the graphic doesn't show. This has happened to me in Chrome and Safari.
To Reproduce
Steps to reproduce the behavior:

Go to a tutorial (aka.ms/lyla)
Click the expand button by the game window to get to the expanded game window
Click the keyboard icon
See error

Apparently this has been an issue for a while
https://github.com/microsoft/pxt-arcade/issues/5282


Choose a folder on macOS

Describe the bug
At first, I thought it was a simple matter, but it exceeded my expectations.
Firstly, I tried using await GetStorageProvider() OpenFolderPickerAsync(...). It does work when using TFM net8.0. But when I switched to net8.0-macos, it didn't work anymore. I think it's because sandbox makes it unusable.
Then, I want to try using NSOpenPanel.
I added NSApplication.Init(); into Main function, so I can use AppKit framework. But the following code doesn't work:
    var openPanel = NSOpenPanel.OpenPanel;
    openPanel.AllowsOtherFileTypes = false;
    openPanel.CanChooseDirectories = true;
    openPanel.CanChooseFiles = false;
    openPanel.AllowsMultipleSelection = false;
    var response = openPanel.RunModal();

Because NSOpenPanel.OpenPanel returns null. Perhaps OpenPanel should be assigned a value within the AppKit framework, but I don't know at what stage.
To Reproduce
As detailed in the previous text.
Expected behavior
Let NSOpenPanel.OpenPanel work.
Avalonia version
11.0.10
OS
macOS
Additional context
No response

Firstly, I tried using await GetStorageProvider() OpenFolderPickerAsync(...). It does work when using TFM net8.0

It works with net8.0 TFM.

I think it's because sandbox makes it unusable.

Sandbox wouldn't affect a file picker, only a direct access to them.

Let NSOpenPanel.OpenPanel work.

I don't think NSOpenPanel.OpenPanel being null is related to Avalonia.

I have made a new discovery. If I change TFM from net8.0-macos to net8.0 and introduce
<PackageReference Include="MonoMac. NetStandard" Version="0.0.4"/>
into my project, the following code will work properly: var openPanel=NSOpenPanel OpenPanel;.

@shanhongyue can we close this issue ? I don't see what we can do from our side tbh.


K8SSAND-1694 ⁃ ML framework with Apache Cassandra

What is missing?
A minimal ML framework and toolkit integration that can help K8ssandra enable for Machine Learning
Why do we need it?
Machine Learning will maximize the use of Cassandra
Environment
k8s

K8ssandra Operator version:
1.1

Anything else we need to know?:
Apache spark and Apache Cassandra goes well hand in hand.
https://medium.com/building-the-open-data-stack/real-world-machine-learning-with-apache-cassandra-and-apache-spark-part-1-4688edf08f9d
┆Issue is synchronized with this Jira Task by Unito
┆friendlyId: K8SSAND-1694
┆priority: Medium

Can you provide details on what changes you would like to see?


How to speed up val process ?

Hello! After I trained my model, I would use this model to extract features by [validate_cub.py] like the method that I used here for a hug amount of images. But there are limited GPUs. So how to speed up this val process?

I did not get what you want.
If you want to speed up the validation process by using several GPUs -- the functionality is already here, nothing to speed up.
If you want to extract features from the images (just inference, no validation), there is no special script for this yet. But you can work on it by yourself, if you need an easy multi-GPU setup, just check Trainer().predict() from Lightning

I did not get what you want.
If you want to speed up the validation process by using several GPUs -- the functionality is already here, nothing to speed up. If you want to extract features from the images (just inference, no validation), there is no special script for this yet. But you can work on it by yourself, if you need an easy multi-GPU setup, just check Trainer().predict() from Lightning

I mean how to do validation on GPUs more faster ?

Please, describe your case in numbers (how many images, what is the size of the query and gallery).
And did you do profiling to understand what part of the calculations is the heaviest one?

Hey, @PapaMadeleine2022 !
I've made a Prediction pipeline, so you can perform inference on several GPUs by using a simple config.
Just open the features_extraction section and you will find it in docs & example folders (see predict.py).

If you find the output format not convenient, let's discuss other options.


Fixed the links from 'developer' to 'master' branch

Verified that it developer has been changed to master


Create fi-eurobbw.txt

@davis-thereal Please provide us with:

the school official website URL
an URL of a page on the official website where the school offers an IT-related long-term (>1 year) course
a proof, which shows that the school recognizes the domain you are submitting as an official email domain for the students.

Currently i cant provide you all the infos. I will open a new request in 2 weeks where i provide you all the infos you need


Extension don't always load

Describe the bug
As title say, since few weeks sometimes the extension won't load at start of the browser and to fix i have to restart the browser (possibly restart the extension shuld be enough), especially noticeable when i try to turn down the volume with wheel scroll and nothing happen (all the icons are also not showing).
To Reproduce
Randomly but quite often
Expected behavior
The extension should always load
Desktop (please complete the following information):

OS: Win 11 24H2 (was happening also before on 22H2)
Browser Brave Beta
Version [Versione 1.65.108 Chromium: 123.0.6312.105 (Build ufficiale) beta (a 64 bit)]

Hmm, not totally sure on how to, tried to check about:debugging but is disabled on brave, with brave://inspect the extension won't even show up.
I was thinking that perhaps here was my fault since I've disabled some auto update from the registry however I'm not totally sure how this should affect your extension (all the others i have were correctly working), I've enabled collect error in case will happen again, if is the case I will update the post.

This is an error i could catch
Service worker registration failed. Status code: 2 (hinting to background.js)
{    "action": {       "default_icon": {          "16": "icons/16.png",          "24": "icons/24.png",          "32": "icons/32.png"       },       "default_title": "Enhancer for YouTube™"    },    "background": {       "service_worker": "background.js"    },    "commands": {       "c000-options-page": {          "description": "__MSG_open_options_page__"       },       "c020-theme-youtube-dark": {          "description": "__MSG_theme_youtube_dark__"       },       "c030-theme-youtube-deep-dark": {          "description": "__MSG_theme_youtube_deep_dark__"       },       "c040-theme-youtube-deep-dark-custom": {          "description": "__MSG_theme_youtube_deep_dark_custom__"       },       "c050-theme-custom-theme": {          "description": "__MSG_theme_custom_theme__"       },       "c060-focus-video-player": {          "description": "__MSG_focus_video_player__"       },       "c070-toggle-loop": {          "description": "__MSG_toggle_loop__"       },       "c080-stop-video": {          "description": "__MSG_stop_video__"       },       "c090-reverse-playlist": {          "description": "__MSG_reverse_playlist_order__"       },       "c100-toggle-volume-booster": {          "description": "__MSG_toggle_volume_booster__"       },       "c130-toggle-annotations": {          "description": "__MSG_toggle_cards_end_screens__"       },       "c140-toggle-cinema-mode": {          "description": "__MSG_toggle_cinema_mode__"       },       "c150-toggle-player-size": {          "description": "__MSG_expand_shrink_video_player__"       },       "c160-center-video-player": {          "description": "__MSG_center_video_player__"       },       "c170-pop-up-player": {          "description": "__MSG_watch_pop_up_player__"       },       "c180-decrease-speed": {          "description": "__MSG_decrease_playback_speed__"       },       "c190-increase-speed": {          "description": "__MSG_increase_playback_speed__"       },       "c200-default-speed": {          "description": "__MSG_select_default_playback_speed__"       },       "c210-normal-speed": {          "description": "__MSG_select_normal_playback_speed__"       },       "c220-toggle-video-filters": {          "description": "__MSG_toggle_video_filters__"       },       "c230-flip-horizontally": {          "description": "__MSG_flip_video_horizontally__"       },       "c240-flip-vertically": {          "description": "__MSG_flip_video_vertically__"       },       "c250-take-screenshot": {          "description": "__MSG_take_screenshot__"       },       "c260-keyboard-shortcuts": {          "description": "__MSG_keyboard_shortcuts_page__"       },       "c270-custom-script": {          "description": "__MSG_execute_custom_script__"       },       "c280-picture-in-picture": {          "description": "__MSG_toggle_pip_mode__"       },       "c290-quality-highres": {          "description": "__MSG_select_quality_4320p__"       },       "c300-quality-hd2880": {          "description": "__MSG_select_quality_2880p__"       },       "c310-quality-hd2160": {          "description": "__MSG_select_quality_2160p__"       },       "c320-quality-hd1440": {          "description": "__MSG_select_quality_1440p__"       },       "c330-quality-hd1080": {          "description": "__MSG_select_quality_1080p__"       },       "c340-quality-hd720": {          "description": "__MSG_select_quality_720p__"       },       "c350-quality-large": {          "description": "__MSG_select_quality_480p__"       },       "c360-quality-medium": {          "description": "__MSG_select_quality_360p__"       },       "c370-quality-small": {          "description": "__MSG_select_quality_240p__"       },       "c380-quality-tiny": {          "description": "__MSG_select_quality_144p__"       },       "c390-quality-auto": {          "description": "__MSG_select_quality_auto__"       },       "c400-comments-visibility": {          "description": "__MSG_toggle_comments_visibility__"       },       "c410-related-videos-visibility": {          "description": "__MSG_toggle_related_videos_visibility__"       }    },    "content_scripts": [ {       "exclude_matches": [ "*://www.youtube.com/embed/*", "*://www.youtube.com/live_chat/*", "*://www.youtube.com/pop-up-player/*" ],       "js": [ "start.js" ],       "matches": [ "*://www.youtube.com/*" ],       "run_at": "document_start"    }, {       "exclude_matches": [ "*://www.youtube.com/embed/*", "*://www.youtube.com/pop-up-player/*" ],       "js": [ "content.js" ],       "matches": [ "*://www.youtube.com/*" ],       "run_at": "document_end"    }, {       "exclude_matches": [ "*://www.youtube.com/live_chat/*", "*://www.youtube.com/pop-up-player/*" ],       "js": [ "idle.js" ],       "matches": [ "*://www.youtube.com/*" ],       "run_at": "document_idle"    }, {       "all_frames": true,       "js": [ "embed.js" ],       "matches": [ "*://www.youtube.com/embed/*" ],       "run_at": "document_start"    }, {       "all_frames": true,       "js": [ "live-chat.js" ],       "matches": [ "*://www.youtube.com/live_chat*" ],       "run_at": "document_start"    }, {       "css": [ "pop-up-player.css" ],       "js": [ "pop-up-player.js" ],       "matches": [ "*://www.youtube.com/pop-up-player/*" ],       "run_at": "document_end"    }, {       "js": [ "shorts.js" ],       "matches": [ "*://www.youtube.com/shorts/*" ],       "run_at": "document_start"    } ],    "default_locale": "en_US",    "description": "__MSG_description__",    "differential_fingerprint": "1.40f3aba7ea8f7ed363a0020f829b6ee2637e42eac2f35edbdf91743a3064a1ca",    "host_permissions": [ "*://www.youtube.com/*" ],    "icons": {       "128": "icons/128.png",       "16": "icons/16.png",       "19": "icons/19.png",       "24": "icons/24.png",       "32": "icons/32.png",       "38": "icons/38.png",       "48": "icons/48.png",       "64": "icons/64.png",       "96": "icons/96.png"    },    "key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQCrJipzcs6r7wrOrIhajflr37G10c+X+VAhhAWTJdL9icUUzFYS91ZcvNKyLqWRSI1j9sQJLK4m4gLYL1nHMZp1Zc/Eeer97b+TRuyQbapxu6ui/6APYHydWPHektVFbrsWdWM/sUzobEsYpYfWvwAiXDjFbwxodGNgC94wYIff1QIDAQAB",    "manifest_version": 3,    "minimum_chrome_version": "<IP_ADDRESS>",    "name": "Enhancer for YouTube™",    "options_page": "options.html",    "permissions": [ "cookies", "scripting", "storage" ],    "update_url": "https://clients2.google.com/service/update2/crx",    "version": "<IP_ADDRESS>",    "web_accessible_resources": [ {       "matches": [ "*://www.youtube.com/*" ],       "resources": [ "resources/*" ]    } ] }
Like I've said is not always happening and unfortunately I'm not able to check in more details without further instruction.
Since the extension is not loaded i can't check the chrome://serviceworker-internals

@Luke0094 you are confusing Enhancer for YouTube with my extension with a similar name YouTube Enhancer. The first is closed source the second is open source.

I apologize, this was my oversight xD

I apologize, this was my oversight xD

It's fine it is easy to confuse the two extensions

I had the same issue in Enhancer for YouTube and found this github issue. I tried your extension instead and it works flawless. So I switched to your extension and gave 5 stars. :)

I had the same issue in Enhancer for YouTube and found this github issue. I tried your extension instead and it works flawless. So I switched to your extension and gave 5 stars. :)

@mKay00 thank you, I appreciate your review.


in diff trees show just packages with changes

closes #269

this is annoying when it decides the property files needs to be updated too :S

so... any complains ?


Improve the reliability of venv gitignore checking

This includes the changes in #38.
Fixes #37.
I took a stab at improving the reliability of gitignore validation particularly for virtual environments. This uses git check-ignore to query git for what's ignored. I removed all of the VIRTUAL_ENV handling from gitignore checks since it's less robust than using sys.prefix (see also #36 which ran into this problem). I also added some tests to verify the behavior, though I don't have access to a Windows environment to test there.
Ideally I think this feature ought to be removed entirely because:

Virtualenv configuration is highly idiosyncratic with countless tools out there for managing the creation and invocation of them (e.g. sometimes activating them, sometimes directly invoking them). This sort of feature seems ripe for edge cases.
What is ignored seems difficult to accurately ascertain. git check-ignore is probably the best approach, but I'm not sure how it will interact with more exotic environments e.g. git worktrees, core git settings, etc.
This feature has already caused enough pain that at least 3 users have bothered to file issues about it: #28, #36, and #37.
Since there's scope creep here, it lends itself to extra confusion. It didn't occur to me that this would be an error message from django-fastdev. I initially suspected direnv but had to grep my entire virtualenv for "is not ignored in" before figuring it out.
It seems like this feature is already slated for removal in the future according to #33.

Gripes aside, this and #38 seemed to be the most straightforward way to get it to stop breaking my environment. Let me know what you think.

Thanks!

I rolled a 1.9.0 release too


Add README.md

Create branch issue1. Use the command

git branch -b issue1
git checkout issue1

Add README.md file to this repository on the top level in the issue1 branch. The file that you need to add needs to look similar to this file.

Edit the contents of the file README.md linked above

Replace the string fastani with the string gatk.
Replace the string fastANI with the string GATK.

Remember to commit and push these changes with the commands
git add README.md
git commit -m "Added README file."
git push origin issue1

@halbakri reviewed and approved.


Misc GQL Improvements

Just a recommendatory PR on how to clean up the gql client

Amazing, thanks!


test(unittests): add more unit tests

Codecov Report

Merging #411 (848f765) into master (652b8f6) will increase coverage by 6.97%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   52.57%   59.54%   +6.97%
==========================================
  Files          39       39
  Lines        1147     1147
  Branches      130      130
==========================================
+ Hits          603      683      +80
+ Misses        499      402      -97
- Partials       45       62      +17

Impacted Files
Coverage Δ

src/app/shared/add-device/add-device.component.ts
86.36% <0.00%> (-6.82%)
:arrow_down:

src/app/configs/configs.service.ts
37.03% <0.00%> (+25.92%)
:arrow_up:

src/app/domains/domains.service.ts
45.45% <0.00%> (+31.81%)
:arrow_up:

src/app/profiles/profiles.service.ts
45.45% <0.00%> (+31.81%)
:arrow_up:

...p/configs/config-detail/config-detail.component.ts
64.28% <0.00%> (+32.85%)
:arrow_up:

src/app/domains/domains.component.ts
92.00% <0.00%> (+40.00%)
:arrow_up:

src/app/wireless/wireless.service.ts
54.54% <0.00%> (+40.90%)
:arrow_up:

...p/domains/domain-detail/domain-detail.component.ts
85.36% <0.00%> (+48.78%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 652b8f6...848f765. Read the comment docs.


Create the thing that builds task graphs.

At last! We're getting to the meat! Things are finally happening.
This creates the initial version of the task graph builder. It consists
of only the part which builds a graph. Execution will come later.
The API is based on the existing tiledb.cloud.dag API, but with
better separation of concerns, and significantly streamlined. Some
features will be added in a follow-up, but the existing API is enough
to construct all but the most specialized task graphs.
Each function on the TaskGraphBuilder returns a specific type of
Node which, like the existing API, represents a step to be executed.
These Nodes are inert and only represent the actions that will be
later executed by an Executor and have no state of their own.
Nodes are capable of accepting other nodes as input not only in the
traditional UDF argument slots (i.e. those passed into user code),
but also in selected parameters of other functions where users may wish
to pass in parameters: array queries, SQL parameters, and a few others.

A few things that are worth pointing out:

Naming of the functions that you call on a graph to add a new node. I went with things that look like grf.udf(...) when called here, but I am wondering whether it might be better to include an add_ or maybe a _node in the name.

Using nodes as non-argument parameters. I've included it because it's something we currently support (if accidentally), and I can see wanting parameterizable configuration of e.g. query ranges. But is this something we explicitly want? My impression is "yes" but I want to make sure…

The way we accept ranges. The current implementation only accepts ranges in the form that is directly used by the backend. The difficulty with making it work the same way as the current parse_ranges implementation is that:

parse_ranges distinguishes between lists and tuples, which we can't do after JSON serialization.
If users want to pass in node outputs into ranges, we can't necessarily parse them that way.
Whatever interchange format we use should be implementation-independent, so that we can make an executor in another language (e.g. server-side) in the future.

These are the reasons that I'm currently only handling the [[start, end, start2, end2], [startB, endB, ...], ...] format of range specification, because designing an API for that is an even larger task.

[sc-14031]

OK, we’re back. This should be much easier to deal with, since it’s step-by-step now. It still makes sense to submit as one unit, because the entire thing needs to be there to get the full functionality of task graphs, and many of the API decisions should be taken together. However, it should be easier to review since each step can be taken in one at a time.


Some glitches

Hello
First, thank you for this amazing work.
I patched transparency v1.1 (HIToolbox + CoreUI) , however, I found some glitches in the dark mode.
No spotlight select bar:
(The same happens with the other colors, i'm using gray to both)

Safari also:

There is a really small bug at the edges of the Safari autofill popover window:

Thank you!

Thanks for the feedback.  The Safari issue has already been reported, as well as the edges.  Actually someone claimed weird corner edges appear in stock dark mode too.
I'll look into it and get back to you.

@fabioiop
Hi again - we have addressed many of these issues in an upcoming v1.3 release.
Stay tuned - v1.3 is being built and tested as we speak.
NOTE not everything may be addresses - so whatever is left will be tagged to a new future release.
Thanks!

@fabioiop
Hi again - we have addressed many of these issues in an upcoming v1.3 release.
Stay tuned - v1.3 is being built and tested as we speak.
NOTE not everything may be addresses - so whatever is left will be tagged to a new future release.
Thanks!

Thank you!!

Not all addressed in v1.3.
I will disposition the remaining issues this weekend.


[ci] Formatting

Coverage: 87.303% (+0.009%) from 87.294% when pulling d6dc7c23988658b3cf8b082caf3744494ca59ab7 on hazendaz:formatting into 77c9ac0274755d2fc3631498a87b348949b59cfc on mybatis:master.


Consolidate the two sided relationships as one model to eliminate transactions

won't do this ticket because we have to use broadcast operations in some cases if we consolidate the two sided relationships as one model.
Scenario: when a user A tries to query his/her own one sided relationships while the model may be sharded by the compound index <the related user ID, the owner ID> instead of <the owner ID, the related user ID>, which will cause a broadcast query operation.

won't do this ticket because we have to use broadcast operations in some cases if we consolidate the two sided relationships as one model.
Scenario: when a user A tries to query his/her own one sided relationships while the model may be sharded by the compound index <the related user ID, the owner ID> instead of <the owner ID, the related user ID>, which will cause a broadcast query operation.


ASTPrinter: Mutability fixes for protocol stubs

Don't print mutating in protocol stubs (this happened to stubs for mutating requirements in classes when the protocol and conformer were in different modules).
Print nonmutating for non-mutating setters in structs.

The AST printer would benefit from a better distinction between attributes and modifiers, but I think it is fine to implement it this way, for now :)

cc @jrose-apple

This seems wrong: we do want to print mutating on stubs by default, because usually they don't have a sensible non-mutating implementation.

I see, that makes sense. I got too carried away reasoning from a different perspective: that mutating (or, say, throws) on stubs could give the impression of being a mandatory modifier, when such requirements are often(«sometimes» is probably more accurate) expected to be understood as optional (spare flexibility). On the other hand, mutating methods with proper names should speak for themselves.
I will reenable it on struct in a moment.

Enums too; it's classes that are special.
I think the stubs are supposed to be "a reasonable default", but I could see how they could be interpreted as "the minimum set of requirements".

@jrose, do you approve?

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 0173e1edb017d6038e5ec48129237cf275b3b434

Build failed
Swift Test Linux Platform
Git Sha - 0173e1edb017d6038e5ec48129237cf275b3b434

Build failed
Swift Test OS X Platform
Git Sha - 0173e1edb017d6038e5ec48129237cf275b3b434

:-( Looks like the duplicate mutating was a problem after all.

Not anymore I believe, since I chose to skip mutability modifiers in printAttributes.

@jrose Turns out I forgot to skip them for functions as well. I don't know which tests failed now that the job is gone, though. Let's see if the duplication is still present?

@swift-ci please test

Looks pretty good now. Are there already tests for mutating get in a requirement, which should not print mutating in the stubs?

Yes, though I do print mutating for both getters and methods, because they are both "allowed to be mutating" in that case.

Build failed
Swift Test OS X Platform
Git Sha - 6f119b0286d6579791ec7d13f5e81818341b7ccd

That LLDB test was recently disabled, let's go again.
@swift-ci Please smoke test macOS

Fix double-printing mutating on interface generation: https://github.com/apple/swift/pull/30011


Image to SVG converter

Create an Image to SVG Converter, where the user can Convert their image to SVG
Also Create an SVG File to PNG, JPG, and JSX File Converter

Is this still on ? Can I complete this ?

Is this still on ? Can I complete this ?

Yes, you can work on it

Is this still on ? Can I complete this ?

Yes, you can work on it

ok


maxCropBoxWidth && maxCropBoxHeight

Hi!!!
Could you, please, add maxCropBoxWidth && maxCropBoxHeight?

reference: https://github.com/fengyuanchen/cropperjs/issues/399
seems won't


Build failed on nfc_in_flutter after upgrade

After Flutter upgrade, I can't build app.
../../../flutter/.pub-cache/hosted/pub.dartlang.org/nfc_in_flutter-2.0.5/lib/src/api.dart:524:54: Error: The operator '[]' isn't defined for the class 'Object'.

    'Object' is from 'dart:core'. Try correcting the operator to an existing operator, or defining a '[]' operator. throw NFCTagSizeTooSmallException(e.details["maxSize"] ?? 0); ^

FAILURE: Build failed with an exception.

    Where: Script '/Users/sissa/flutter/packages/flutter_tools/gradle/flutter.gradle' line: 991

    What went wrong: Execution failed for task ':app:compileFlutterBuildDebug'.

    Process 'command '../../flutter/bin/flutter'' finished with non-zero exit value 1

    Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

    Get more help at https://help.gradle.org

BUILD FAILED in 41s Exception: Gradle task assembleDebug failed with exit code 1

This is my Flutter doctor output:
[✓] Flutter (Channel master, 1.27.0-5.0.pre.18, on macOS 11.1 20C69 darwin-x64, locale en-GB) • Flutter version 1.27.0-5.0.pre.18 at /Users/sissa/flutter • Framework revision 50897c98fc (6 days ago), 2021-02-16 20:13:53 -0800 • Engine revision 9bcb3bfb0e • Dart version 2.13.0 (build 2.13.0-30.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2) • Android SDK at /Users/sissa/Library/Android/sdk • Platform android-29, build-tools 29.0.2 • ANDROID_HOME = /Users/sissa/Library/Android/sdk • Java binary at: /Applications/Android Studio 2.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495) • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 12.4, Build version 12D4e • CocoaPods version 1.10.0

[✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.5) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] Android Studio (version 4.1) • Android Studio at /Applications/Android Studio 2.app/Contents • Flutter plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/9212-flutter • Dart plugin can be installed from: 🔨 https://plugins.jetbrains.com/plugin/6351-dart • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.40.0) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension can be installed from: 🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available) • SM J610FN (mobile) • bbc7a841 • android-arm • Android 10 (API 29) • Chrome (web) • chrome • web-javascript • Google Chrome 88.0.4324.182

• No issues found!

Actions done that didn't work:

flutter clean
Invalidate caches / restart

Upgrading to 1.27.0-4.0.pre in dev channel solve the problem.


Add support for Croatian quotes

Add support for Croatian quotes to smartquote.rs pursuant to punctuation rules

Thanks, is there a source for the single quotes as well?

Thanks, is there a source for the single quotes as well?

Oh, my bad. Here it is.

Small mistake with the single quote orientation, it's good now

Thanks!


Can I customize the display order of Linting

I'm using linting on vscode. I install the python mypy.
Now, if I meet an error on the definition, I'll get the following result :

Is there any way to get the second then the first.

This is possibly a feature request on VS Code core. Python extension does not control the order of items here. Since this view can be filled in from multiple sources not just the python extension.


Added test to verify not responded users endpoint

Tests for survey API endpoint '/survey/admin/not_responded_users' that fetches all the users that have not responded to the survey.
Test cases:

Check the employees that have not responded to the survey and are active
Mock response given from an employee and verify that the employee is not listed

For the second test case, I have mocked response for an employee by establishing a relationship. Have done this for 'GIVEN'.
Before running this script, run the neo4j_restore script.

Hi Sravanti, can we just have the test to get all the active users from not_responded_users endpoint for now? Because any change to the the synthetic data in DB would make it difficult for tests to run in parallel. The current test wouldn't fit the first round of tests based on synthetic data. Edits to data should be run only after the read/fetch tests based on synthetic data are run

I think if we do that, we will not be testing all scenarios. Yes, the test would return all active users if I just keep the existing data and call the endpoint because no one responded yet. I think we should also test the case where a user actually responded and we do not return that user.
Ideally tests should be independent from each other and should not interfere other tests. We could solve this by mocking GraphQL responses and not actually use the GraphQL endpoint. Since this is a unit test, doing that would make all tests independent. If not, we can run these tests in sequence, that way we know what would be the state of the DB at the beginning of each test and write the test in that way.
Another way is to have a "before" script and "after" script for each test, which actually brings the DB to required state when "before" runs and clear/reset the state when the "after" script runs.
That said, I have removed the test data (commented out) that changes the synthetic data. I let the method be so that later when we make the tests independent we can use that.

Hi @sravantit25 , I agree, but if we mock the API endpoints then that would beat the purpose of having synthetic data itself in the first place right?  I have written new tests recently , in which testing one API depends on the output from other API, but that could be run separately. Arun & I thought of having the first set of tests to be run independently and in parallel.
Could you please remove the commented out code and raise a separate PR for that, we could use that separately.
In the current code can you please change the import of variables URL and API_KEY to have it imported from an .env file within the tests folder. You can do this with decouple library. Since we are changing the location of tests directory from root to backend folder, this would make it easier for me to relocate you're test

Hi Sravanti, can we just have the test to get all the active users from not_responded_users endpoint for now? Because any change to the the synthetic data in DB would make it difficult for tests to run in parallel. The current test wouldn't fit the first round of tests based on synthetic data. Edits to data should be run only after the read/fetch tests based on synthetic data are run

@akkuldn I have made the changes and pushed the changes. So sorry for such delay.


⚠ Bofrost.be has degraded performance

In 9009345, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1597 ms

Resolved: Bofrost.be performance has improved in e9d78a9 after 43 minutes.


Cleaner build

R: @jeffposnick @addyosmani
Fixes #52
This is the last step I wanted to take for sharing minified code for new modules. I've left the old modules alone for now.
As part of this PR I've juggled the gulp-tasks around so that the individual concerns are seperate (lint, test, build, documentation, publish, serve). Main hope with this is that gulpfile.js is kept minimal and it's clear how tasks relate to each other (for example linting of gulpfile.js and tasks is tucked away in lint.js).

👍


Add the ability to serve customizable data streams to other external consumers (mongoDB, grafana, etc.)

I like this! Could be a good thing to allow custom blocks at some point for ppl using it as a dashboard or engineering UI.
Definitely something to consider!
On Nov 4, 2018, 11:08 PM -0500, Gernby<EMAIL_ADDRESS>wrote:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


my farms page and node installer are using different bootstrap links

one is using https://bootstrap.grid.tf and the other one is using https://v3.bootstrap.grid.tf

that's the right link https://bootstrap.grid.tf/


Parameter Optimization

Hi all,
Is there any doc to follow-up purpose of all parameters inside the arguments/.../default.py ? Besides, any suggestion to optimize render quality on parameter section ?
Cheers

Hi, there
if you have any question, please contact me.

That was quick, thank you. Is any suggestion parameters, probably optimization parameters, to smooth the object edges with white background ?

It's hard for 3D/4D Gaussian splatting. Because Gaussians only focus on novel view synthesis instead of reconstruction(mesh).


⚠ Samsung has degraded performance

In a0650a6, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2467 ms

Resolved: Samsung performance has improved in bb5a65a.


Fix format button hover color in playground

Currently text on format button in playground is not visible when we hover on it. Updated format button hover color to use text-white-80-tr.

Nice! Thank you.


Fix demo gif not displayed

The current demo gif image on the README cannot be displayed. This PR fixes the issue by moving the image to GitHub itself.
Note: The image was uploaded to GitHub by creating a new issue on this repo, then drag the image into the page and copy the generated link, then cancel the issue.

Thanks @T-Pham !


Add Specimen Skeleton char categories

This code is copied over from the Specimen Skeleton project and
only lightly patched so work in the WF engine. This code works,
but it kinda dumb. There's a refactor issue in the Specimen
Skeleton project, if that is done we should improve the code
here as well.
Another small point of concern is that the GlyphData is over 5MB
large! This is a pretty hefty download, so we need to be smart
about loading this asset.

@RoelN how is this supposed to work, in terms of we need to be smart about loading this asset?
Currently the build is failing because Rollup out of the box doesn't support importing JSON files. We could fix that, but without any smarts, this would really negatively affect the engine size and WF site load time.
This easiest way to make this a bit better (though arguably not that smart :-P) is to lazy load the JSON data. This would require a loading indicator in the UI though, as it can probably take a couple 100 ms to download and parse this file (it's 450KB gzipped). For starters I think that's fine, let's see how well that performs and think about alternative solutions if it's really too slow.
Some other remarks:

Can you add tests for this? (Borrowing the test from the specimen project)
If we go with lazy loading we'll need two implementations; one for browser which fetches the JSON dynamically and one for Node that directly loads the JSON from FS.

@pascalw As this file is only needed after the font is parsed, I think we can get away with lazy loading.
We can wait with generating a report until all the engine-related stuff like this has finished loading, and show one single "please wait, processing font..."-message.  Do you expect me to implement this stil?

@pascalw Yes please 🙏  Especially regarding the Node/browser distinction!

Discussed offline that we're going to merge this now as is. Lazy loading of the Fondue engine in it's entirety will be implemented soon. If need be we could implement lazy loading of the glyhpData in the engine later, but we'll see later if that's needed or not.


Add animation when application is launched

Increase the size of the application icon and fade out when application is launched

I think is better something like a jummper icon.

We already have this animation in Dock. Now we need it in Filer.

Related:
https://github.com/helloSystem/Dock/issues/2

like this ?

Similar, yes.


onValidateQuestion  -- Possible to show validation error, but still proceed to next question?

Are you requesting a feature, reporting a bug or ask a question?
Asking a question

Is it possible (perhaps using onValidateQuestion or some other way) to make validation work as it currently does, but still allow the user to proceed to the next question?
Basic need is, our customer wants a warning to be displayed, yet still allow the user to proceed to the next question, even if the user's answer is "incorrect"
Thanks!

@asilverstein You may create your own nativation: https://surveyjs.io/Examples/Library/?id=survey-customnavigation
You may add a button "Go Next in Anyway", and just the next page:
var index = survey.visiblePages.indexOf(survey.currentPage);
//go to the next page
if(index < survey.visiblePages.length - 1) {
survey.currentPage = survey.visiblePages[index + 1]
} else {
// last page. complete the survey
 survey.doComplete();
}

Thank you,
Andrew

Thanks Andrew, I'll give that a try. Much appreciated.

This works perfectly, thanks again Andrew!


[Draft] React Adapter

Hello, i would like the frame feature in React. So i want to make a POC with React, and its works well.
Todos

This line in the router is bugging for me visitId === this.visitId is never true
Render componente in frame with layout
Improve FrameContext
Make other code know the frame like: useForm
Refactor

hey there, of course I'm merging this PR. But please note that this will never make it into any official inertia release. Even if @reinink considered it, I'd advise against it, because even though this feature is supercool, it needs a total rewrite.

Thanks man, I know is very hard to merge this PR, but if you need any help i am here to help.


Monthly meeting agenda (May 2022)

Date: Wednesday, May 25 at 12 p.m. UTC
Previous agenda: https://github.com/corazawaf/coraza/issues/211

Current agenda

Project status
CRS compatibility status
C (libcoraza) status
Funding ideas: dev on duty, issue bounties
Reduce reviewers to 1
Ask enterprise users for reviews and permission to add them to our README
coraza.io maintenance
V3 discussion: logs, tinygo, new features, etc https://github.com/corazawaf/coraza/issues/246

How to join?

Join OWASP slack: https://owasp.org/slack/invite
Join #coraza channel: https://owasp.slack.com/archives/C02BXH135AT

Project status

We are reviewing GSOC applications for our three projects, GraphQL, coraza-server, and rate limiting
Changes:

#234 utf8 RX compatibility issues
#232 include directive support
#220 rule matching optimization
#219 fix force request body, now it works
#214 fix RX capture

@roshan joined the coraza core team

CRS compatibility issues
We have fixed at least 3 bugs related to CRS compatibility, we should try to fix this by this week

Lua compatibility is coming as a plugin

The C wrappers (libcoraza) are undergoing tests, we are still having issues with the garbage collection. We are also having problems with the log callback function.


Replace HTML tags in summary

https://api.tvmaze.com/shows/67172
at Summary '&' char is "&"
is it able to fix to remove/repace every html tags?

I'm not sure if it would be a good idea to add logic to manipulate this response as the goal of this library is to return the same responses as if you were consuming the API directly.
Can you remove the HTML tags in your own code after you get the response?

I've tried both methods GetShowAkasAsync and GetShowMainInformationAsync using the show ID 67172 and I didn't get those errors.
Can you please provide the steps to reproduce them?

Thanks for letting me. Feel free to reopen the issue if it happens again.


Problem: incorrect task link in email alerts

Issue
After updating to v2.9.112-4f95ac8-1717, the Task Log link in email alerts is incorrect - it does not contain web_host, even though it is set correctly in config:

Before the update, the link was set correctly and was clickable.
Impact
Service (scheduled tasks, alerts)
Installation method
Docker
Database
Postgres
Browser
No response
Semaphore Version
v2.9.112-4f95ac8-1717
Ansible Version
No response
Logs & errors
No response
Manual installation - system information
No response
Configuration
config.json
{
    [...]
    "web_host": "http://example.com:3000",
    [...]
    "email_alert": true,
    [...]
}

Additional information
Possibly related to #2084

Same Problem here. Using docker-compose with:
  semaphore:
    image: semaphoreui/semaphore:v2.10.43
    ports:
      - "3000:3000"
    environment:
      SEMAPHORE_DB_DIALECT: bolt
      SEMAPHORE_EMAIL_ALERT: False
      SEMAPHORE_TELEGRAM_ALERT: True
      SEMAPHORE_TELEGRAM_CHAT: "-xxxx"
      SEMAPHORE_TELEGRAM_TOKEN: "***"
      SEMAPHORE_WEB_HOST: "https://sema.example.com"


Livebook problem installing amqp

Environment

Elixir & Erlang/OTP versions (elixir --version):
elixir 1.12.2
erlang/OTP 24.0.3

Operating system:
macOS Big Sur

How have you started Livebook (mix phx.server, livebook CLI, Docker, etc):
livebook server

Browsers that reproduce this bug (the more the merrier):
safari

Include what is logged to the server console:

Current behavior
Include detailed steps to reproduce error, errors and stacktraces if appropriate.

Start a new livebook
Mix.install {:amqp, "~> 1.0"} (RabbitMQ)
Evaluate

Expected behavior
🐰

You need to update the rebar version in your machine. Run mix local.rebar and you should be good to go. If that's not enough, make sure that which rebar3 points to an updated rebar version.
FWIW, this should be unrelated to livebook and you should be able to reproduce it on a regular Mix.install. :)


[LinearProgress] High frequency updates

[x] The issue is present in the latest release.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
When the value transfer is too fast,
The progress bar does not move

Expected Behavior 🤔
The progress bar move

Steps to Reproduce 🕹
https://codesandbox.io/s/material-progress-scale-qi4zd?file=/demo.js
I think it should be caused by the use of both transition and transform (translate)
If you use both transition and {transform-origin: 0 50%; transform: scaleX(xxx);} is ok
Context 🔦

Your Environment 🌎

Tech
Version

Material-UI
v4.10.2

React
16.13.1

Browser
chrome

TypeScript
3.9.3

etc.

Interesting feedback, it seems to be in direct opposition with the requirement of #11289. We broke this support for high-frequency updates in #14882. In this case, I would recommend that we update the documentation:
diff --git a/docs/src/pages/components/progress/progress.md b/docs/src/pages/components/progress/progress.md
index a436e6e337..6cc23d3ffd 100644
--- a/docs/src/pages/components/progress/progress.md
+++ b/docs/src/pages/components/progress/progress.md
@@ -89,7 +89,9 @@ After 1.0 second, you can display a loader to keep user's flow of thought uninte

 ## Limitations

-Under heavy load, you might lose the stroke dash animation or see random CircularProgress ring widths.
+### High CPU load
+
+Under heavy load, you might lose the stroke dash animation or see random `CircularProgress` ring widths.
 You should run processor intensive operations in a web worker or by batch in order not to block the main rendering thread.

 ![heavy load](/static/images/progress/heavy-load.gif)
@@ -98,3 +100,17 @@ When it's not possible, you can leverage the `disableShrink` property to mitigat
 See [this issue](https://github.com/mui-org/material-ui/issues/10327).

 {{"demo": "pages/components/progress/CircularUnderLoad.js"}}
+
+### High frequency updates
+
+The `LinearProgress` uses a transition on the CSS transform property to provide a smooth update between different values.
+In the event a parent component updates the `value` prop too quickly (>30 Hz), you might experience a delay.
+If the update frequency is higher than the frame rate (>60 Hz), you might not see any update at all.
+
+In these cases, we recommend disabling the transition:
+
+```css
+.MuiLinearProgress-bar {
+  transition: none;
+}
+```

https://codesandbox.io/s/material-progress-scale-rwc56?file=/demo.js

(>30 Hz)

Use "frames per second". "Hertz" has no inherent meaning.

Agree, we could be more explicit. Hz as renders per second (React).

Hi! Just new in contributing to open source. Can I work on this?

Actually, in think that Hz and FPS should be used in conjunction. We won't notice any change above 60 FPS because it match the refresh rate of the browser.
However for the slower updates, the issue is the transition duration: 200ms at an update frequency of 30 Hz, we get 30 renders per second, one every 33ms. The transition progress to 17% of the final value before receiving a new target. It lag, in this context the FPS don't matter.

Actually, in think that Hz and FPS should be used in conjunction. We won't notice any change above 60 FPS because it match the refresh rate of the browser.
However for the slower updates, the issue is the transition duration: 200ms at an update frequency of 30 Hz, we get 30 renders per second, one every 33ms. The transition progress to 17% of the final value before receiving a new target. It lag, in this context the FPS don't matter.

I don't know why in the case of retaining the transition, if I use scale to control it will not happen

I understand why not use scale to control, but I am curious why the result of scale control is so different from translate

@MyCupOfTeaOo I don't know

Can we take a step back and be accurate in the issue description and origin? It's not established that #14882 broke this. Nor is the issue confirmed in my book. There's smart sounding explanation but no evidence that it is true. The repro contains a lot of potentially unrelated code (e.g. props based styling, css vars).
What's missing:

a repro in prod (dev is not suitable for perf critical issues)
isolated repros so that it's clear that mixing these is not the cause
repro of a version that doesn't have the issue.

Ubuntu 18.04 Chrome Version 83.0.4103.97 (Official Build) (64-bit)

Ubuntu 18.04 Firefox 77.0.1

This is likely a chromium issue.
Why do we need transformation for translate anyway? For progressbars I'd rather recommend to avoid them if you they complete within a single frame.

@eps1lon Thanks for looking closer I have put a simplified reproduction, with the proposed patch in https://codesandbox.io/s/material-progress-scale-rwc56?file=/demo.js.
You are right, testing with more browsers, Firefox macOS, Safari macOS, Edge macOS, Chrome Windows, Firefox Windows, the behavior seems consistently the same:

Chrome & Edge: no update visible if re-render frequency (1/s) > browser max frames per second.
Other browsers: the delay is correlated with the re-render frequency.

I think that we can focus on documenting the behavior that is expected and will always be visible (not matter bugs Blink might have or not): the delay.

Maybe we should close the issue and label it "external dependency"? Given the workaround, it seems that it's worth stopping the exploration here. We admit that we have no idea what's going on. I have tried to look at the Chromium bug tracker couldn't find anything that matches.

Maybe we should close the issue and label it "external dependency"? Given the workaround, it seems that it's worth stopping the exploration here. We admit that we have no idea what's going on. I have tried to look at the Chromium bug tracker couldn't find anything that matches.

Yes,i will close it. I think this should be a browser issue, of course "High-speed refresh" is really rare


when I run "pip3 install py-imessage", I got this. (normal when running install other package)

Collecting py-imessage
Downloading py-iMessage-1.7.tar.gz (6.3 kB)
ERROR: Command errored out with exit status 1:
command: /System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/tmp/pip-install-HUY3wS/py-imessage/setup.py'"'"'; file='"'"'/private/tmp/pip-install-HUY3wS/py-imessage/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(file);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, file, '"'"'exec'"'"'))' egg_info --egg-base /private/tmp/pip-pip-egg-info-p6vHkC
cwd: /private/tmp/pip-install-HUY3wS/py-imessage/
Complete output (5 lines):
Traceback (most recent call last):
File "", line 1, in
File "/private/tmp/pip-install-HUY3wS/py-imessage/setup.py", line 13, in
with open (join(dirname(file), 'requirements.txt'), 'r') as f:
IOError: [Errno 2] No such file or directory: '/private/tmp/pip-install-HUY3wS/py-imessage/requirements.txt'
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
my OS is MAC 10.15 ,  and I run it in vmware

Hmm. Let me see if I can reproduce on my machine and figure it out.
You are going to run into issues using VMWare however, Apple often checks if a certain flag is set at the hardware level for the Messages App (unlike other pieces of software).
Are you able to send iMessages from the VMWare image already?

Yes, I'm running it in VMWare.

I am also getting this issue


Error if passing a primary key into find, update, etc

I have a array of IDs, for example 3 of them. When calling User.find(IDs).exec(console.log) I get the three records.
When I call User.find().where(IDs).exec(console.log) I get all records.
I have to do User.find().where({id: IDs}).exec(console.log) to get the ones I wanted
Moreover, when calling User.find().where(IDs[0]).exec(console.log) I get the correct one.
Very inconsistant, perhaps a bug with calling .where with an array

@devinivy @anasyb @particlebanana Hey, we've moving Waterline issues to our main Sails issue hub with the label "orm." It looks like this one was patched and resolved. Thanks for helping resolve this bug and I hope everything is working now. 👍

This has been published.


Improve btrfs version check

We'll probably drop the btrfs code anytime soon but in the meantime, some small improvements:

Allow to have a newer major version than the one specified
Fix an error message typo where the needed minor version was shown twice
Split the error message in a more accurate way (my version was reporting btrfs-tools v4.1.2 instead of Btrfs v4.1.2 like we were waiting for)

LGTM++, just one comment to fix

LGTM


Question about the whole React + ProseMirror integration

Hey there, been doing rich-text editing for a while and got stuck with a performance problem with Slate so I decided to see if ProseMirror would be the answer.
 From what I have gathered glueing React and PM together isn't a walk in a park as you might think it is, and there's definitely a high learning-curve for knowing how to implement that in addition to PM's quite verbose API.
Anyway, I'm glad somebody's up for the challenge since my brains are still being overloaded with having to go through the rabbit hole of rich text editing and the complex API it forces most libraries to use. So out of curiosity and because I really want to do this, how are you accomplishing this feat of engineering?
My current knowledge about the issue:

In rich text editing where you edit DOM elements directly, you must re-implement many of the native rich-text functionality yourself since the API quite frankly sucks and is not consistent across different browsers
All rich-text editing libraries do this at some-level, which requires intricate DOM manipulations with ranges and selections and whatnot, a lot of stuff
This makes the using of frameworks such as React or Vue less applicable, as you can't let them handle the DOM for you
However, the creation of complex DOM elements for rich text is such a pain in the ass, using some framework would be preferable. Nobody likes to work directly with DOM and frameworks offer much wanted safety
So in order to use framework, such as React, you must externalize the DOM element representation to it while at the same time maintaining the rich-text editing semantics of selections and ranges and so on
ProseMirror offers quite robust way of doing rich-text editing and a way of externalizing that DOM representation through things called NodeViews
To wrap a NodeView as a React component you must however first establish its ProseMirror schema eg.

this.editorState = EditorState.create({
  schema: new Schema({
    nodes: {
      doc: {
        content: 'block+'
      },
      underline: {
        group: 'block',
        content: 'inline*',
        parseDOM: [{ tag: 'p' }],
        toDOM() { return ['p', 0] }
      },
      text: {
        group: 'inline'
      },
    }
  })
})

Which is quite a new frontier for many developers not familiar with PM & rich-text
Only after that you can separate the NodeView, the rendering itself, by eg (full source copied/modified from here https://gist.github.com/esmevane/7326b19e20a5670954b51ea8618d096d)

class Underlined extends React.Component<any, any> {
  public hole: React.RefObject<HTMLParagraphElement>

  constructor(props: any) {
    super(props)
    this.hole = React.createRef()
  }

  public append(node: HTMLElement) {
    if (this.hole) {
      this.hole.current!.appendChild(node)
    }
  }

  public render() {
    return

  }
}

class Underline {
  public dom: HTMLElement
  public contentDOM: HTMLElement
  public ref: React.RefObject<any>

  constructor(public node: Node) {
    this.ref = React.createRef()
    this.dom = document.createElement('span')
    this.contentDOM = document.createElement('span')

    ReactDOM.render(
      <Underlined ref={this.ref} />,
      this.dom,
      this.putContentDomInRef
    )
  }

  public update(node: Node) {
    return true
  }

  private putContentDomInRef = () => {
    this.ref.current.append(this.contentDOM)
  }

  destroy() {
    ReactDOM.unmountComponentAtNode(this.dom)
  }
}

Which is the most minimal setup I can think of to integrate PM with React. Still it is a far away from being finished as you can see from my comments of the Gist.

Now that I have laid down my current know-how about the subject, if you have the time could you fill in some blanks for me. Would be highly appreciated.

I am curious what are the implications of using React instead of direct DOM manipulation that I should know?
I probably should use ReactDOM's portals as they allow sharing of React context between separately mounted DOM nodes, but is that only the reason why you should use them instead of numerous silly ReactDOM.render -calls?
Then what about the state-management, does is basically happen for all custom events in PM through these tr.setMeta/tr.getMeta -calls?
I'm not completely sure what all the Atlassian's editor's boilerplate are for (eg https://bitbucket.org/atlassian/atlaskit-mk-2/src/0fcae893b790443a30f7dadae00638d6e4238b2f/packages/editor/editor-core/src/event-dispatcher/index.ts?at=master)
As I mentioned in the comments of that Gist it would be nice to have a working minimal PM + React editor with all the required boilerplate. Do you have any idea how to accomplish that?

Hmm.. I guess that's most of it, for now : ). So there's a lot of confusing stuff here that's throwing me off. I really like the idea of establishing a familiar interface to interact with the DOM, like in Slate, but which would actually be performant (and have better API and no ImmutableJS). You have accomplished a lot with your project but it seems it's still far off from being actually usable hence I'd rather just do the PM+React integration myself.
And sorry for the ramble but I've been stuck with this problem for quite a while and I am getting frustrated with the massive complexity of this problem. Martin has spent years on this stuff which I feel I should have too to understand it, or at least taken a course or having read a book about it.
Teemu

@TeemuKoivisto thanks for the questions and patience. I fell a bit ill last week so wasn't able to respond as soon I would have like to.

I am curious what are the implications of using React instead of direct DOM manipulation that I should know?

I actually think DOM manipulation is better for simpler prosemirror functionality but I can see where the React integration will be helpful for more complex components. The main reason for this is that the current abstraction that I've copied from atlaskit isn't yet intuitive to build upon. It still relies on holding a deep understanding of Prosemirror.

I probably should use ReactDOM's portals as they allow sharing of React context between separately mounted DOM nodes, but is that only the reason why you should use them instead of numerous silly ReactDOM.render -calls?

Truth be told initially I tried with ReactDOM.render since it was easier to start off with (based on the very gist you linked to). For some reason, probably my own fault, it didn't remove the element onDestroy(). The node view would be deleted but the react debugger would keep hold of the shadow react element (memory leak). React.Portal just worked so I stuck with it. In hindsight, it seems like the better choice, since it allows React to handle the dom stuff.

> As I mentioned in the comments of that Gist it would be nice to have a working minimal PM + React editor with all the required boilerplate. Do you have any idea how to accomplish that?
The closest I've seen to that is available in react-prosemirror.

I'm not completely sure what all the Atlassian's editor's boilerplate are for (eg https://bitbucket.org/atlassian/atlaskit-mk-2/src/0fcae893b790443a30f7dadae00638d6e4238b2f/packages/editor/editor-core/src/event-dispatcher/index.ts?at=master)

Neither am I, good sir. Neither am I.

Hey, thanks for answering. Sorry for the delay, I originally had written a reply soon after you answered but since I felt a little inadequate about my knowledge about this stuff, I decided to work on my own editor to give a more descriptive reply.
I ended up with creating a secondary repo to write all the boilerplate as I figure stuff out, to which I'm soon going to add my Toolbar component that I just created https://github.com/TeemuKoivisto/prosemirror-react-typescript-example
Yeah I spent some time looking into the Atlaskit editor-core, which I managed to run locally all right  (with some problems, as its dependencies are a little bit out of sync..) which has quite a bit of moving parts. Yet I noticed it has its own issues with the context-wrappers sometimes nesting the components very deep, like 20-level nesting for a table component. I think that's ridiculous and silly, so something better should be invented for that. *Actually now that I've had a deeper look into it, I must say its code-base is quite horrible. There must have been a good idea in the beginning, but it has bloated out of control.
But there's some really good stuff there like the Table-component I mentioned and I'll be looking into the PortalProvider logic & plugin eventDispatcher if I use them in my work. I'm not interested in creating a creating my own editor library, just getting the basic boilerplate right. I love simple systems which we hold to high esteem at my work, and whatever I'm going to do I'll try to do as simply as possible.
After your reply I spent some time on creating a basic Toolbar with buttons for toggling marks and turning active whenever cursor or selection is on marked text. It helped me to clarify how the state-management should be done, since triggering updates from any editor-transactions to the React components is a bit tricky business. I decided to lean on to the pre-built plugin-state logic, so that all editor-specific state will be there. But instead of hacking some event dispatcher to notify React components about the changes, I'll leverage Mobx observables inside the plugin-state and provide the state slice as probably injected state (not passed down as props). If you're familiar with Mobx you know what I'm aiming at.
I think observables are the simplest way of doing state-management with React and omit a lot of the Redux boilerplate that I've come to hate. My biggest concern is can the UI somehow go out of sync with the PM editor. I mean it shouldn't because React receives the state from PM, which updates everything in singular transactions. Well only if there's state in both React and PM that do something that overlap. Will see how it goes.
If you have any tips or help, I'd appreciate it. =)

I ended up with creating a secondary repo to write all the boilerplate as I figure stuff out, to which I'm soon going to add my Toolbar component that I just created [TeemuKoivisto/prosemirror-react-typescript-example]

Sounds exciting @TeemuKoivisto! I hope this project can be of help in the future.


Re-pasting formula with Katex code does not render SVG tags

When I paste some content that has Katex formula with SVG tags (try sqrt to reproduce) taken from one editor instance (using getContents) to another (using setContents), the SVG tags in the formula (katex) do not render in the new editor preview. Rest of the formula appears fine.
A sample of square root of 2 appears as follows:

Moreover, if I click the edit button on the formula snippet, the SVG appears in the modal preview perfectly fine since the katex code is preserved perfectly. On submitting the modal, the formula starts rendering the SVG tags.
The ideal behaviour is that the formula should have that SVG tags appear in the first place.
P.S.: This is the first time I am creating an issue, so please forgive if I am not able to convey here.
P.P.S.: @JiHong88 Amazing work. I actually moved from using a paid editor to Sun :)

Hi, @dgandhi1993
Thank you using this project. :)
I'll notify you know after fixing the bug.

The 2.30.1 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.


can we have a docker-compose.yml with full running environment

I follow this document, then google leads me to this open source repo.
Seems it can save my time to set it.
I do follow up the README, and customize shibboleth-idp setting. But I still can't make it work with my ldap server.
The error I got is below, seems it try to access port 8080 which is not documented.
2016-07-12 13:57:16.978:INFO:oejs.ServerConnector:main: Started ServerConnector@38ee7a9d{SSL,[ssl, http/1.1]}{<IP_ADDRESS>:8443}
2016-07-12 13:57:16.979:INFO:oejs.ServerConnector:main: Started ServerConnector@629984eb{HTTP/1.1,[http/1.1]}{<IP_ADDRESS>:8080}
Exception in thread "main" java.lang.IllegalStateException: no valid keystore
	at org.eclipse.jetty.util.security.CertificateUtils.getKeyStore(CertificateUtils.java:48)

So could we have a running docker-compose.yml, which include ldap + shibboleth, that guarantee to have running docker containers directly?

Port 8080 is just what is opened by default and it's impact is minimal. The error is related to a keystore, probably the one associated with the backchannel?... That's my guess.
Here's a full working IdP (based off of this image), LDAP, and several SPs. https://github.com/UniconLabs/dockerized-idp-testbed.
Hopefully that will give you the missing clue.

Finally get the problem fixed with help from issue #23


After changing the currency name to something else, the command >settype doesnt recognize the new currency

Thanks, Fixed, Will be up in the next release


Fix TeamCity Build.

The 2.7.3 version of python in TeamCity requires additional packages to stop the InsecurePlatformWarning and hence a failed build.
see http://stackoverflow.com/questions/29099404/ssl-insecureplatform-error-when-using-requests-package

Coverage remained the same at 98.187% when pulling 80a7073b88291969e65e5a9ba09a41b5a109b4c9 on request-upgrade-fixes into 183b1bf550c4826898b2bbe935de94de3658e892 on master.


Re-enable gce-autoscaling tests for merge-bit

Because of its flakiness, the gce-autoscaling project was removed from the list of Jenkins projects that the merge-bot checks (PRs in waiting is growing). The failures needs to be investigated and the project added back to that list soon.

This is already fixed by #122
cc @jszczepkowski @mwielgus @fgrzadkowski


⚠ Processors has degraded performance

In b60a9ec, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 98 ms

Resolved: Processors performance has improved in 6400274.


Push filters beneath ProjectSet if they target standalone outputs.

Summary of the changes / Why this improves CrateDB
Checklist

[ ] User relevant changes are recorded in CHANGES.txt ?
[x] Touched code is covered by tests
[ ] Documentation has been updated if necessary
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Do we need a change a change log here?

retest this please

Do we need a change a change log entry here?

Yep I think it wouldn't hurt. For other optimization rules we've had https://github.com/crate/crate/blob/master/blackbox/docs/appendices/release-notes/4.0.0.rst#L399-L400
- Added a new optimization that allows to run predicates on top of views or
  sub-queries more efficiently in some cases.


[BUG] cellfinder_view throws a brainrender error "No module named 'brainrender.Utils.image"

Describe the bug
When I run cellfinder_view , I get the following error:
(cellfinder) C:\Users\Administrator>cellfinder_view
Traceback (most recent call last):
  File "c:\users\administrator\miniconda3\envs\cellfinder\lib\runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "c:\users\administrator\miniconda3\envs\cellfinder\lib\runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "C:\Users\Administrator\miniconda3\envs\cellfinder\Scripts\cellfinder_view.exe\__main__.py", line 4, in <module>
  File "c:\users\administrator\miniconda3\envs\cellfinder\lib\site-packages\neuro\visualise\viewer.py", line 23, in <module>
    from neuro.visualise.napari_tools.callbacks import display_brain_region_name
  File "c:\users\administrator\miniconda3\envs\cellfinder\lib\site-packages\neuro\visualise\napari_tools\callbacks.py", line 7, in <module>
    from neuro.segmentation.manual_segmentation.man_seg_tools import (
  File "c:\users\administrator\miniconda3\envs\cellfinder\lib\site-packages\neuro\segmentation\manual_segmentation\man_seg_tools.py", line 15, in <module>
    from neuro.visualise.brainrender_tools import (
  File "c:\users\administrator\miniconda3\envs\cellfinder\lib\site-packages\neuro\visualise\brainrender_tools.py", line 3, in <module>
    from brainrender.Utils.image import reorient_image, marching_cubes_to_obj
ModuleNotFoundError: No module named 'brainrender.Utils.image'

Desktop (please complete the following information):
Windows 10

Hi, sorry about this, what version of brainrender do you have? If it's <IP_ADDRESS> then this functionality might have been removed, @FedeClaudi?
I'll look into fixing this, but if you do have <IP_ADDRESS> it might be fixed temporarily by installing an older version of brainrender (pip install brainrender==<IP_ADDRESS>).
Let me know how you get on.

Thanks @adamltyson, going back to <IP_ADDRESS> worked!

Hi,
That's right I removed that function, sorry.
I thought you had implemented similar functionality in the neuro package @adamltyson ? If you need it back let me know and I'll add it back in, sorry I should've double checked with you before removing it.

No problem @FedeClaudi. Reopening to remind me to add this functionality into neuro.

okay, thanks and sorry again :)

Hi @rdbcasillas, this should be fixed by installing pip install neuro==0.0.19


Flink native support

Hi Team,
Is there any plan to implement native support for Apache Flink?
Any ETA?
Thanks

No ETA, but contributions are welcome! If you or anybody else would like to give it a try, here is the guide: https://camel.apache.org/camel-quarkus/latest/contributor-guide/promote-jvm-to-native.html


[WIP] Add specs for Integer ceil, floor, truncate and round that takes optional digits

This is currently Work in Progress(WIP)

Not sure if I'm missing something wrt the Integer ceil and floor function  but it looks like as per the ruby 2.4.0 docs for ceil and floor return an Integer.

1.ceil(2)        #=> 1
1.floor(2)        #=> 1

But in Ruby 2.4.0 console it looks like they return a Float:
2.4.0 :036 > 1.ceil(2)
 => 1.0
2.4.0 :037 > 1.floor(2)
 => 1.0

If the docs need to be updated, I can try to submit a patch to fix this in the ruby github repo as per the contribution guidelines specified here but before I do that, can one please confirm on the above observation and also please confirm if I'm using the correct approach to update the docs? Is my understanding correct that the docs get picked up from here for Integer#ceil and here for Integer#floor ?

Your observations are right:
$ ruby -v
ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
[5] pry(main)> 42.round 2
=> 42.0
[6] pry(main)> 42.ceil 2
=> 42.0
[7] pry(main)> 42.floor 2
=> 42.0
[8] pry(main)> 42.truncate 2
=> 42.0

Actually, this behavior changed in 2.5 (see https://github.com/ruby/spec/pull/436), but remains as you observe in 2.4.
It seems the problem comes from ruby-doc.org, which seems to take documentation from trunk and not 2.4.2 as it should. I commented on https://github.com/documenting-ruby/ruby/issues/81#issuecomment-335005854
Here is the source for 2.4.2: https://github.com/ruby/ruby/blob/v2_4_2/numeric.c#L5060
So ideally we should specify the behavior for both versions ranges like in https://github.com/ruby/spec/pull/436/files#diff-839feea4a131eb7231be5b63a9d0654cR7.

@eregon Interesting, what does the trunk branch signify? Sorry, I'm not quite aware of this naming convention of branches as part of the Ruby organization of projects. Also, what version of Ruby should the trunk branch ideally point to at any given point of time ?
I realise specs for Integer#round have already been added here. I've finished with the set of specs for ceil, floor and truncate as part of those that need to be wrapped up wrt Ruby 2.4 based on the issue specified here.  Can the specs for 2.5 wrt ceil, floor and truncate be treated as a separate PR that anyone can take up ?

Subversion's trunk is like git's master, i.e. the development branch (so currently what will become 2.5 but also development for the next versions).

Yes, of course the 2.5 part can be done separately.
Thank you for the new specs!

(FWIW I fixed the 2.5 behavior in 64c06f9c9faccba0c461fd15eccaaa2df04dacfc, not so trivial indeed)

Thanks for collaborating on this and sharing more info @eregon :) . I didn't know that they were using trunk in the context of subversion.
Thanks for adding the specs for Ruby 2.5 👍  . I was thinking of attempting it later if feasible but glad that you already have done them.
I'm curious about one thing in general, it would be great to get more insights to better understand the value of these specs. I mean I do know that Ruby 2.4 is already made available to end users but some specs here are still for some 2.4 features that are already made available to everyone then what additional value in general is there with adding these specs now ?
Also, I believe that whenever releasing a new ruby version for everyone's use, they would already have some sort of specs for the new features and bug fixes right and if so, where do those tests ideally reside ? I guess that is a different repo or place from what we have here ?
Thanks for your time answering my questions.

What additional value in general is there with adding these specs now ?
Also, I believe that whenever releasing a new ruby version for everyone's use, they would already have some sort of specs for the new features and bug fixes right and if so, where do those tests ideally reside ? I guess that is a different repo or place from what we have here ?

These are very good questions, with unfortunately not such a simple answer.
Tests are added when new features are added, such as https://github.com/ruby/ruby/commit/a1542d33ca30cdecb741be526d043be6bba01d76 in the case of Integer#ceil.
These specific tests look good and in this case might even have better coverage than the specs we wrote. But there are major differences which makes the specs here worthwhile:

These testes are written by the implementer of the feature, so it's basically a list of cases the author thought about. Writing tests from another perspective often discovers new edge cases (it's not so rare to find bugs while writing specs).
As you see MRI unit tests are just assertions with close to zero comments. For more complex methods, it becomes very hard to understand why the method should behave in such a way or should satisfy those assertions. Having descriptions of the behavior makes the specs a lot easier to read, but also to implement without needing to always look at MRI's code (which for example in this case is very tied to C arithmetic semantics and might be irrelevant if this is re-implemented in another language).
These tests live in the MRI repository, which means when the behavior changes, the tests are just changed in place. This means it can be very confusing (as you saw) when behavior changes and there is no good place to look at. ruby/spec really shines here, it's very clear what is the behavior for which Ruby version.
MRI tests tend to be specific to MRI. The organization of MRI tests is sometimes rather surprising (try finding a do/while loop test). MRI tests sometimes rely on advanced features like refinements in the test harness. These are a few issues that make it hard (but not impossible) for other implementations to reuse those tests, and much more so for early implementations.
There are other reasons, for instance mentioned here but I do want to make this too long.

Now, I am trying to encourage MRI developers adding new features to write specs, and this would be very valuable as they are expert about the feature since they implement it. We made progress so at least much less technical issues are standing in the way. But writing specs is different than writing unit tests, and it's hard to change habits so this might take a while. The current policy in MRI is you can write MRI tests or ruby/spec specs for a new feature/bug fix, and developers are free to choose what they prefer.
However, this is something that only happened during the 2.5 timeline so for 2.4 specs we basically need to catch up.

Wow! It's amazing to see the depth to which you have answered my question @eregon . Thank you very much :) I know better understand the value of writing these specs. Some food for thought may be, Do you think this specific repository could benefit with a Motivation section in the README in terms of why writing these specs is encouraged ? Hopefully, that may give people more insights on why they should consider contributing to this repo and may be also help them better realise the value they're bringing to the community through their contributions here ?
This was like the bigger picture for me and I definitely found it really insightful. Thanks once again for the detailed explanation Benoit :)


Support multiple domains per service

Good idea, any thoughts on how you'd like to specify multiple domains? Comma separated?

The way I have it right now in my separate script is comma separated. I think the "kubernetes way" is an actual list, but I don't know if that's actually supported under annotations. If it's not, comma separation would definitely be better than the alternative of domain0, domain1, etc.

One caveat to this: if you're terminating TLS in ELB then you'll still need multiple services so that each domain gets the ELB with matching cert.

I used a certificate with multiple alternative names for that. Let's Encrypt supports that. In my case it was nginx that terminated TLS, but I'm sure ELB supports that too.

Support was merged in #25. New tag coming shortly.


Publish the separated projects to NPM

When #303 Is finished we need to publish these packages so that we and the community can use it as a dependency.

I believe with the mgere of #358 we could close this down


Add add_outlives method to Poller

resolves #161
The previous implementation only implemented unsafe methods for registering file descriptors with Poller. This implements an add_outlives method that can guarantee safety by accepting a reference to an AsSource which outlives the Poller. Since file descriptors are guaranteed to be valid through the lifetime of the Poller, there is no need to ever delete to maintain soundness.
Please advise if I should change anything.

I tried this initially, but I don't think it will work if the source lifetime is not somehow tied to the Poller struct. The borrow checker will just shorten the poller lifetime inside add_outlives.
With the above example this compiles:
let poller = Poller::new().unwrap();

{
    let file = File::open("./file.txt").unwrap();
    let _ = poller.add_outlives(&file, Event::all(7));
    drop(file);
}
println!("{:?}", poller);

That's disappointing. I was under the impression that the borrow checker would catch this.
Still, thanks for checking!


Waiting for the code

We are all looking forward to you,xixi. Do not Delay, plz. :)

Also looking forward to your code

This is a very interesting invention and I feel it has generational significance, so I think I need to study your code in detail and actively await your open source.

期待

Also looking forward to codes. Thanks

Also looking forward to codes. Thanks

Sorry ICLR rebuttal and CVPR are busier than we expected. We are hoping to release the code asap after the deadlines....

@tsb0601 Thanks peter,
We are sorry for the delay. The ICLR rebuttal and CVPR submission are busier than we expected, and we will release our code before 1st Dec.
Thank you for being patience.

您好，作者什么时候发布代码谢谢您，今天已经12月1号了。

Hello, when will the author release the code? Thank you. It is already December 1st today.

估计是又延期了吧，我也在等这个，每天都看一遍是不是发布了
------------------ 原始邮件 ------------------
发件人:                                                                                "Delay-Xili/SDNet"                                                                                @.>;
发送时间: 2022年12月1日(星期四) 晚上9:36
@.>;
<EMAIL_ADDRESS>主题: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1)
您好，作者什么时候发布代码谢谢您，今天已经12月1号了。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

老哥，您也是做可解释的，想和您交个朋友。
眼镜蛇
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "Delay-Xili/SDNet"                                                                                @.>;
发送时间: 2022年12月1日(星期四) 晚上9:44
@.>;
<EMAIL_ADDRESS>主题: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1)
估计是又延期了吧，我也在等这个，每天都看一遍是不是发布了
------------------ 原始邮件 ------------------
发件人:                                                                                "Delay-Xili/SDNet"                                                                                @.>;
发送时间: 2022年12月1日(星期四) 晚上9:36
@.>;
@.@.>;
主题: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1)
您好，作者什么时候发布代码谢谢您，今天已经12月1号了。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.>

老哥，您也是做可解释的，想和您交个朋友。 眼镜蛇 @.*** &bsp;
...
------------------ 原始邮件 ------------------ 发件人: "Delay-Xili/SDNet" @.>; 发送时间: 2022年12月1日(星期四) 晚上9:44 @.><EMAIL_ADDRESS>主题: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1) 估计是又延期了吧，我也在等这个，每天都看一遍是不是发布了
------------------ 原始邮件 ------------------ 发件人: "Delay-Xili/SDNet" @.>; 发送时间: 2022年12月1日(星期四) 晚上9:36 @.>; @.@.>; 主题: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1) 您好，作者什么时候发布代码谢谢您，今天已经12月1号了。 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.> — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.>

同做可解释性，可以一起交流

我的wx是15176678823
…
---Original--- From: @.> Date: Fri, Dec 2, 2022 15:43 PM To: @.>; Cc<EMAIL_ADDRESS>Subject: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1) 老哥，您也是做可解释的，想和您交个朋友。 眼镜蛇 @.*** &bsp; ... ------------------ 原始邮件 ------------------ 发件人: "Delay-Xili/SDNet" @.>; 发送时间: 2022年12月1日(星期四) 晚上9:44 @.><EMAIL_ADDRESS>主题: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1) 估计是又延期了吧，我也在等这个，每天都看一遍是不是发布了 ------------------ 原始邮件 ------------------ 发件人: "Delay-Xili/SDNet" @.>; 发送时间: 2022年12月1日(星期四) 晚上9:36 @.>; @.@.>; 主题: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1) 您好，作者什么时候发布代码谢谢您，今天已经12月1号了。 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.> — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.> 同做可解释性，可以一起交流 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

加您了，您没同意？

您好，我这里没有显示请留下您的
---Original---
From: @.>
Date: Sat, Dec 3, 2022 20:05 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1)
我的wx是15176678823
…
---Original--- From: @.> Date: Fri, Dec 2, 2022 15:43 PM To: @.>; Cc<EMAIL_ADDRESS>Subject: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1) 老哥，您也是做可解释的，想和您交个朋友。 眼镜蛇 @.*** &bsp; ... ------------------ 原始邮件 ------------------ 发件人: "Delay-Xili/SDNet" @.>; 发送时间: 2022年12月1日(星期四) 晚上9:44 @.><EMAIL_ADDRESS>主题: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1) 估计是又延期了吧，我也在等这个，每天都看一遍是不是发布了 ------------------ 原始邮件 ------------------ 发件人: "Delay-Xili/SDNet" @.>; 发送时间: 2022年12月1日(星期四) 晚上9:36 @.>; @.@.>; 主题: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1) 您好，作者什么时候发布代码谢谢您，今天已经12月1号了。 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.> — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.> 同做可解释性，可以一起交流 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>
加您了，您没同意？
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

同期待源码

每日一看是否开源

哈哈哈
---Original---
From: @.>
Date: Wed, Jan 11, 2023 12:08 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1)
每日一看是否开源
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

要不要交个朋友
---Original---
From: @.>
Date: Wed, Jan 11, 2023 12:08 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1)
同期待源码
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

研究了一段时间，想看看FISTA的具体细节

一起交流呀，我已经搭建了一个模型。
---Original---
From: @.>
Date: Mon, Feb 6, 2023 21:04 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1)
研究了一段时间，想看看FISTA的具体细节
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

一起交流呀，我已经搭建了一个模型。
…
---Original--- From: @.> Date: Mon, Feb 6, 2023 21:04 PM To: @.>; Cc<EMAIL_ADDRESS>Subject: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1) 研究了一段时间，想看看FISTA的具体细节 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

嗯嗯，我加你vx了，也可加我qq614464503，请多指教

Also looking forward to codes, thanks.

Looking forward to the codes.

你是老外？
---Original---
From: @.>
Date: Tue, Feb 28, 2023 10:06 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1)
Looking forward to the codes.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

你是中国人嘛？
---Original---
From: @.>
Date: Tue, Feb 28, 2023 22:17 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [Delay-Xili/SDNet] Waiting for the code (Issue #1)
looking forward to your codes
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

等候你的代码
Hello, can I make friends with you?

期也待代号，谢谢。

Hello, can I make friends with you?

Hi All, I have reimplemented the code referring to the paper. The link is TOYCODE. Before the official version appears, that plays toy for fun. If the official publish, I will delete the related code. I think there are some key questions that are not solved. For example, How to get the value of $t$. See #2
To get the perfect code, I need all advice.
If you are interested in this toy, I hope you give me some advice. Thx!!!

Dear Delay-Xili.
Thank you very much for making the code public, could you please provide a copy of the code for the SDNet application in the 1D dimension?

Dear Delay-Xili. Thank you very much for making the code public, could you please provide a copy of the code for the SDNet application in the 1D dimension?

Hi,
Please refer to https://github.com/Delay-Xili/SDNet#sparse-coding-layer-for-1d-case.


.Pluck() to log correct number of rows returned

Describe the feature
.Pluck()  should return correct number of rows returned from DB
Motivation
In the debug logs of query execution, .Pluck() is always printing [0 rows affected or returned ] even though there are matching records. But the records are returned correctly.
for e.g.,
scopedQuery.Pluck("profiles.id", &profileIDs)

will always print [0 rows affected or returned ] even if there are 100 profiles matching the scope and are returned correctly.
This causes confusion atleast during debugging phase.
Related Issues
N/A

[0 rows affected or returned ]
gorm doesn't print such logs, check your own logging implementation, and this is not a feature request.


[azservicebus] Fixing a memory leak when doing cross receiver settlement.

go-amqp holds onto some tracking data that won't get cleared if we don't try to settle through the original Receiver. Our fix in here, combined with go-amqp's changes to route to the original receiver, should seal that up.
Benchmark added that also doubles as a stress test.
Fixes #22318

/azp run go - azservicebus


Minor fixes

Thanks, looks good. The shouldComponentUpdate operations are likely to disappear in the minefield branch, for what it's worth.

It really was in case you bumbed a version without minefield