The ability to make people see their own skin on an NPC

It would be cool if there was a way of making people seeing their own skin on an NPC so if 2 people (or more) are online they would both see their own skin on the same NPC

This was done, /npc mirror is now available


Use CI to update translations

Overview: What does this pull request change?

This is in continuation to #2333

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

Actually, if it's done inside of PR itself (like the pre-commit bot) it would be better rather than pushing after the PR is merged.


compare with saved not working

Applies To

[X] Notebooks (.ipynb files)
[ ] Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?
As shown below, the Compare with Saved functionality is not working for notebooks (while its' working for txt and py files).

VS Code Version
1.78.0
Jupyter Extension Version
v2023.4.1011241018
Jupyter logs
(nothing updated there)

Coding Language and Runtime Version
No response
Language Extension Version (if applicable)
No response
Anaconda Version (if applicable)
No response
Running Jupyter locally or remotely?
None

while https://code.visualstudio.com/docs/datascience/jupyter-notebooks#_custom-notebook-diffing works, this feature does not work. Is "compare with saved" so rarely used that its priority is low?


add test for deletion/insertion bug

This PR adds a test that occurs when performing a deletion followed by an addition of the same entity, in the same transaction span.
The first call works, but the second call will throw the error:
Error: error returned from database: database is locked

This is periodic: calling again will work, and then fail etc.

I have also checked, and the call to the endpoint is not transactional: the deletion succeeds, the insertion fails, and the state is committed.

idk if that can help debugging, but inverting the create and the delete causes the server to hang a few seconds, and log this:
[2022-06-24T18:29:22Z] WARN - DELETE FROM "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D" WHERE …; rows affected: 0, rows returned: 0, elapsed: 5.199s

DELETE FROM
  "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D"
WHERE
  "id" IN (
    SELECT
      "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D_id"
    FROM
      (
        SELECT
          *
        FROM
          (
            SELECT
              "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D"."id" AS "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D_id",
              "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D"."username" AS "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D_username",
              "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D"."email" AS "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D_email"
            FROM
              "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D"
          ) AS subquery
        WHERE
          (
            "ty_User_5B9759AD33F94F00A0C77AEB4C3B5A9D_email" =<EMAIL_ADDRESS>          )
      ) as subquery
  )

The test LGTM. Given that this is sqlite only, it might be possible to write a small series of sql commands that illustrate the difference. From there we have to understand what sqlite wants from us and implement that.

BTW, do we have an issue for this?

@espindola no, I'll open one and link this pr 👍

Please squash the commits, otherwise the test will fail if someone hits the first commit during a bisect.


Confusion in typescript abstract classes documentation

`abstract class Department {
constructor(public name: string) {
}

printName(): void {
    console.log("Department name: " + this.name);
}

abstract printMeeting(): void; // must be implemented in derived classes

}
class AccountingDepartment extends Department {
constructor() {
    super("Accounting and Auditing"); // constructors in derived classes must call super()
}

printMeeting(): void {
    console.log("The Accounting Department meets each Monday at 10am.");
}

generateReports(): void {
    console.log("Generating accounting reports...");
}

}
let department: Department; // ok to create a reference to an abstract type
department = new Department(); // error: cannot create an instance of an abstract class
department = new AccountingDepartment(); // ok to create and assign a non-abstract subclass
department.printName();
department.printMeeting();
department.generateReports(); // error: method doesn't exist on declared abstract type`
department.generateReports(); this will generate error since we explicitly create a reference to an abstract type.
Needs to be explicitly explained tat because we are referencing department to type Department as of this line "let department: Department; // ok to create a reference to an abstract type", then we won't find generateReports on this type and an error will occur. However if we let typescript implicitly refer the type of AccountingDepartment then there is no problem in implementing new methods such as generateReports.

This issue is a bit hard to understand, any chance you could make a PR to show your diff? It's this file: https://github.com/microsoft/TypeScript-Handbook/blob/master/pages/Classes.md

edited my issue. The issue is that for newcomers it's a bit hard to understand the concept of abstract classes, trying to access generateReports will fail because we explicitly refer department to be of type Department. This point needs to be emphasized or else it is confusing for beginners like myself.


Missing Tkinter dependency note

I just installed vanilla Ubuntu 18.04 LTS. Following the wiki I tried to issue "./run_subj". When doing so I got the following output:
Traceback (most recent call last):
  File "./run_subj", line 9, in <module>
    from sureal.routine import run_subjective_models
  File "/home/jakub/Workspace/sureal/python/src/sureal/routine.py", line 2, in <module>
    from matplotlib import pyplot as plt
  File "/home/jakub/.local/lib/python2.7/site-packages/matplotlib/pyplot.py", line 115, in <module>
    _backend_mod, new_figure_manager, draw_if_interactive, _show = pylab_setup()
  File "/home/jakub/.local/lib/python2.7/site-packages/matplotlib/backends/__init__.py", line 62, in pylab_setup
    [backend_name], 0)
  File "/home/jakub/.local/lib/python2.7/site-packages/matplotlib/backends/backend_tkagg.py", line 4, in <module>
    from . import tkagg  # Paint image to Tk photo blitter extension.
  File "/home/jakub/.local/lib/python2.7/site-packages/matplotlib/backends/tkagg.py", line 5, in <module>
    from six.moves import tkinter as Tk
  File "/home/jakub/.local/lib/python2.7/site-packages/six.py", line 203, in load_module
    mod = mod._resolve()
  File "/home/jakub/.local/lib/python2.7/site-packages/six.py", line 115, in _resolve
    return _import_module(self.mod)
  File "/home/jakub/.local/lib/python2.7/site-packages/six.py", line 82, in _import_module
    __import__(name)
  File "/usr/lib/python2.7/lib-tk/Tkinter.py", line 42, in <module>
    raise ImportError, str(msg) + ', please install the python-tk package'
ImportError: No module named _tkinter, please install the python-tk package

I believe it would be beneficial to mention in the wiki that the Tkinter module is necessary to run this code.

This might be a platform-dependent issue. We are working toward packaging/publishing sureal as a pypi package. Hopefully the issue is going away after that.

It is possible that it is a platform-dependent issue. In my case it is even more complicated because I had to install the Ubuntu 18.04 LTS Server version, which is stripped of all GUI-related packages. That may be the problem.

I've created a PR for this.


has_completed condition in Questbuilder

The has_completed condition currently does not detect the completion of individual objectives that are part of a stage that has been marked complete. This does work for checking objectives of the same stage that is not complete, as it currently works for "Life and Destruction".
As an example, I made a short test quest to see how this worked. It is as follows:
Stage 0- Chat Npc w/ a Show Options trigger
Stage 1- Choose Option (Yes) & Choose Option (No)
Stage 2- 3 Chat Npc objectives w/ has_completed conditions, "Yes", "No", and "Both". For yes and no, the opposite option is marked flipped.
The quest returns "both", indicating that both Yes and No were marked as complete, even when I had only picked yes. This is a rather niche issue, but it would cut the possible need for small quests out of various scenarios. It'd be especially useful for more "Open World" stuff.

Closing to merge into quest master thread.


Django 2.0.2

Version 0.0.9 is not compatible with Django 2.0.2?
What is the correct version to work with Django 2.0.2.
Thanks

Why you say that 0.0.9 is not compatible with django 2.0.2?  Did you find a bug?

if installed with "pip install django-cruds-adminlte", pip list says that version 0.0.9 is installed and I get the following error
NameError at / login /
name 'register_tag' is not defined
Request Method: GET
Request URL: http://<IP_ADDRESS>:8001/login/
Django Version: 2.0.2
Exception Type: NameError
Exception Value:
name 'register_tag' is not defined
Exception Location: /home/fernando/.virtualenvs/secdj2/lib/python3.5/site-packages/cruds_adminlte/templatetags/crud_tags.py in , line 31
Python Executable: /home/fernando/.virtualenvs/secdj2/bin/python
Python Version: 3.5.2
Python Path:
['/ home / fernando / Sistemas / WebApps / secColegioDJ2',
 '/home/fernando/.virtualenvs/secdj2/lib/python35.zip',
 '/home/fernando/.virtualenvs/secdj2/lib/python3.5',
 '/home/fernando/.virtualenvs/secdj2/lib/python3.5/plat-x86_64-linux-gnu',
 '/home/fernando/.virtualenvs/secdj2/lib/python3.5/lib-dynload',
 '/usr/lib/python3.5',
 '/usr/lib/python3.5/plat-x86_64-linux-gnu',
 '/home/fernando/.virtualenvs/secdj2/lib/python3.5/site-packages']
Server time: Mar, 6 Mar 2018 12:14:15 +0000
if I install it with "pip install e git + https: // github.com/oscarmlage/django-cruds-adminlte.git", pip list, it says that version 0.0.8 is installed, but it's ok.

@oscarmlage could you upload a new repared release ?

Release done, last version is now 0.0.11.


Config vars ineffective when instantiating with attributes

When instantiated with an array of attributes, User constructor will not take fillable and login-columns config settings into account - the fill method will be called  before the instance properties are overwritten with custom ones.

Sorry for the delay.
Thank you for the contribution! :smile:

Sorry for the delay.
Thank you for the contribution! :smile:


ci: use reusable workflows

Codecov Report

Merging #405 (a5d2ff9) into main (201d7f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #405   +/-   ##
=======================================
  Coverage   78.95%   78.95%
=======================================
  Files          27       27
  Lines        1730     1730
=======================================
  Hits         1366     1366
  Misses        364      364

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201d7f4...a5d2ff9. Read the comment docs.


Update: Perforce.P4Merge version 2020.1

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

@denelon here is one you can tell the engineers to investigate =)

I've asked one of the engineers to take a look at this one.

I don't know why it's showing as canceled here - that's not what I am seeing upon closer inspection. What I do see is that it's still running the installer validation. I would leave this for now so we don't have to start that over in case it is one of the installers that is going to take a little extra time. If we haven't seen any traction by end of day we can kick it again.

I take it back - it is for some reason canceled. I'm kicking it again - will dig in deeper if the issue persists.

/azp run

I take it back - it is for some reason canceled. I'm kicking it again - will dig in deeper if the issue persists.

This is the most common issue we see with the pipeline, https://github.com/microsoft/winget-pkgs/issues/42616


Fix TransferManager.cancel passing bad parameters to _shutdown

Passing the cancel boolean twice tries to pass a string as the exception class, which eventually crashes when creating an instance of it is attempted.

@nateprewitt Sorry for tagging you directly. This is a blatant bug. Could you merge the fix please?


fix: kill movement local testnet process before running eth-movement tests

Summary

bridge-eth-movement CI check has been failing for a couple PRs to main due to process already running. The code added to the checks is designed to find the process and kill it.
movement init sometimes fails. For more consistency in CI, delete .movement before running CI checks.

Changelog

added to .github/workflows/checks-all.yml:

    - name: Kill running movement process
      run: |
        PID=$(ps aux | grep 'movement node run-local-testnet' | grep -v grep | awk '{print $2}' | head -n 1)
        if [ -n "$PID" ]; then
          echo "Killing process with PID: $PID"
          kill -9 $PID
        else
          echo "No movement process found."
        fi

and
    - name: Delete .movement directory if present
      run: |
        cd $GITHUB_WORKSPACE
        if [ -d "protocol-units/bridge/integration-tests/.movement" ]; then
          echo ".movement directory found, deleting it."
          rm -rf protocol-units/bridge/integration-tests/.movement
        else
          echo ".movement directory not found."
        fi

Testing

Passing CI is the test for this. I tried locally but testing packages were not satisfactory, so it seems that pushing and seeing that CI passes is the best approach.

Outstanding issues

I just merged main into this, should fix the failing solidity test, as the missing lib file was causing the CI to fail 👍

Close this to add the logic into #523.


Throw an error when the custom_normalization.py script is run in parallel, as it require being run with only 1 worker.

If you run it in parallel each worker will update the metadata file binning codes multiple times, when you only want to perform this once. I'm not sure if meds-transform allows you to access n_workers for a stage via the stage_cfg command @mmcdermott as we could just check this and throw an error?

Can't you just set the number of workers to 1 in the stage runner yaml file?

And/or use cfg.worker like here: https://github.com/mmcdermott/MEDS_transforms/blob/main/src/MEDS_transforms/aggregate_code_metadata.py#L692


More detailed metrics for DataDog

It would be great if Traefik could provide and add more information about traefik.backend.request.* metrics for DataDog or any other monitoring tools.
Could you explain to me what is the difference between these metrics:

traefik.backend.request.duration.count
traefik.backend.request.duration.avg
traefik.backend.request.total

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.


Add data-XXX attributes for section elements of revealjs

Refs: #113

It is to re-merge, because I did not forget document


Installation

How to install this in ACode? Help

From Acode plugin store , or from this site:
https://acode.app/plugin/acode.plugin.chatgpt


update packages

:white_check_mark: Build TheIdServer 2.1.1-maintain-1-0-01-0047 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/08806bfd2c by @)


Fix ecommerce transaction item's name key

According to the protocol doc
https://github.com/snowplow/snowplow/wiki/snowplow-tracker-protocol
The ecommerce name key should be ti_na not ti_nm

Hmm, it seems that every tracker has this "wrong". Most importantly, what does the JSON Schema say?

Closing in favor of: https://github.com/snowplow/snowplow/issues/1401


[chore] upgrade test containers now that testcontainers-go/1971 is merged

See discussion for history if desired

Please rebase 👍

We are now on the latest testcontainers-go. We can close this PR.


Fixed Termux setup script.

The script couldn't installl ffmpeg and python due to the confirmation prompt.
Fixed that now.

@s1as3r Can you update this from master, then we'll merge it?

@s1as3r negative, please update from master, not change the base branch

Tests are not running on s1as3r:termux due to it being outdated, so it cannot be merged
Conflicts are present due to the branch being outdated

Now, the user can directly share a spotify link to termux and it'll download it to the songs directory.


Does this library automatically commits offsets?

Or do i have to take care of it myself?

There is no auto-commit feature.

Got it, thanks.


Use reserved word constant from model.thrift as actual reserved word list.

The current set of reserved words is hard-coded into the compiler, but should be based on the Model_Constants.kReservedWords constant.

... This has apparently already been done.


1247 fix docker image building

fixes #1247

npm install has to run after the files are copied
had to use  --ignore-scripts because it was failing on husky. Husky is a devDependency but also part of the postinstall
Everything works now with docker compose up

Is this going to get reviewed?

We can't use --ignore-scripts flag, because it blocks the postinstall script.


Security Risk : teleTan-Creation needs to be logged with hotline agent name

Describe the bug
Security risks from inside an organisation are often underestimated. Let's see how this may be a problem for the Corona app.
Quote from https://www.chip.de/news/Corona-App-steht-kurz-vor-dem-Start-Scheitert-das-Warn-Tool-an-einem-einfachen-Problem_182639402.html
_

Knapp 1.000 Anrufe soll die Hotline pro Tag bewältigen können. Nach Spiegel-Informationen sollen bereits Probeläufe gezeigt haben, dass das System funktioniert. Das Call-Center betreibt ein externen Dienstleister. Ob dieser in Deutschland sitzt, ist unklar.

_
A hotline agent currently is a trusted person who may create teleTans. Problem : is it correct to trust him if one even doesn't know if he works in Germany, Croatia, India or even a prison in the US?
Currently a hotline agent can create teleTans without the knowledge of a supervisor. It is not even possible to trace who created which teleTan.
Expected behaviour
It is easy to create teleTans that could be misused. Don't ask for a misuse scenario  - as long as it is possible there will be an invalid use.
Possible Fix
Log teleTan creation with hotline agent id and date/time.
See also  CWA_Documentation issue #129

After reading „Der Bericht der Datenschutz-Folgenabschätzung für die Corona-Warnapp“ I will not use the Corona warn app. According to this report it is necessary to leave my phone number and name at the hotline. A hotline I know nothing about. Not where it is. Not who runs it. This is a major problem of your requirements. The outer borders of the system are  defined too narrow.
There is no guarantee the data are destroyed after an hour. We know other cases where confidential data was found besides roadways.

After I finished my investigation, I saw that is only partly related to the real "bug" described here, however, maybe it helps:
I did some quick investigation.
The page https://www.telekom.com/de/konzern/themenspecials/special-corona/special-corona-warn-app shows in the second "slide" this picture:

There's a logo which says "AXIVAS". The first result on a google search is https://alex-gross.com.
The contract between the federal government and Deutsche Telekom also mentions "Axivas" under point 7;
"Axivas Deutschland GmbH - Call-Center-Dienstleistungen".
The same contract, on page 93 (counting from fragdenstaat.de - on the paper it's page 19 out of 25), says under point  3 "Verarbeitungsort":
"Die Verarbeitung der Daten findet in Deutschland, den Niederlanden und Ungarn statt. [...]"
And, now what has been asked here:
Annex 4, on page 97 (paper: 23 out of 25) says to the Axivas GmbH:
"Verarbeitungsort Deutschland".
So, the verification hotline, if I understand everything correct, is operated by the "Axivas GmbH" in Germany.


table_name is not supported with Mysql

db.Clauses(exclause.NewWith("cte", "SELECT * FROM `kbw_user_account`")).Table("cte").Scan(&results)

[16.641ms] [rows:-] WITH `cte` AS (SELECT * FROM `kbw_user_account`) SELECT * FROM `cte`
Error executing the query: Error 1146 (42S02): [17003,<PHONE_NUMBER>401419216822211203453556666] Table adb.kbw2.cte does not exist

@smoothdvd Thank you open the issue.
I tried reproduction your error, however I can't reproduction  it.
Could you tell me your MySQL version? MySQL 5.7 doesn't support WITH clause.
My test code is this. It has success.
func TestMySQL(t *testing.T) {
	type User struct {
		gorm.Model
		Name  string
		Email *string
		Age   uint8
	}
	dsn := "test_user:password@tcp(mysql:3306)/test_db?charset=utf8mb4&parseTime=True&loc=Local"
	db, _ := gorm.Open(mysql.Open(dsn), &gorm.Config{
		Logger: logger.Default.LogMode(logger.Info),
	})
	db.Use(extraClausePlugin.New())
	db.AutoMigrate(&User{})

	var results []User
	err := db.Clauses(NewWith("cte", "SELECT * FROM `users`")).Table("cte").Scan(&results).Error
	if err != nil {
		t.Errorf(err.Error())
	}
	defer db.Migrator().DropTable(&User{})
}

I using AnalyticDB for MySQL provide by Aliyun. It's support WITH clause.
I can run WITH clause in DataGrip like following:
[2023-12-19 12:02:50] Connected
kbw2> use kbw2
[2023-12-19 12:02:50] completed in 28 ms
kbw2> WITH cte AS (SELECT * FROM kbw_user_account LIMIT 10) SELECT * FROM `cte`
[2023-12-19 12:02:51] 10 rows retrieved starting from 1 in 173 ms (execution: 88 ms, fetching: 85 ms)

If WITH clause with wrapped with `` in definition, it will failed:
kbw2> WITH `cte` AS (SELECT * FROM kbw_user_account LIMIT 10) SELECT * FROM `cte`
[2023-12-19 12:04:30] [42S02][1146] [17003,<PHONE_NUMBER>043119216822211203453023793] Table adb.kbw2.cte does not exist


Bump min sdk version

More work might need to be done.
Integration in the final 2.0 release will depend on Android version statistics at the time of release.

Coverage remained the same at 22.981% when pulling 84cffa10017bfa9142c093454a8ba322f342b61e on bump_min_sdk_version into 8b32e27b8e468f13b942313a80761569a61f4f05 on release/2.0.

Closing this PR as it is too outdated.


Old notifications keep getting caught by getInitialNotification

Hi,
I have following code in my componentDidMount (copied and adapted it from the example app)
async componentDidMount() {
    registerAppListener(this.props.rootNavigation);
    FCM.getInitialNotification().then(notif => {
      this.setState({
        initNotif: notif,
      });
      if (notif && notif.opened_from_tray) {
        console.log(notif);
        const navigateAction = NavigationActions.navigate({
          routeName: 'Root',
          action: NavigationActions.navigate({ routeName: 'MatchTab' }),
        });
        setTimeout(() => this.props.rootNavigation.dispatch(navigateAction), 500);
      }
    });
}

However, everytime I start my app now, the getInitialNotification still finds the newest notification (even if that notification is already opened), and it triggers the navigate again. Is there a way to let the getInitialNotification "forget" the latest notification if the app has been opened in the meantime?
So, to make it more clear:

I get a notification
I tap it
I get redirected to the Root/MatchTab
I close the app (background or killed, doesn't matter)
I don't get a new notification
I reopen the app
I get redirected to the Root/MatchTab again, despite not receiving a new notification

Anything I can do to stop this behavior, and only redirect when a user enters the app by clicking the notification?
Running on a Android 7.1 device, with react-native 0.53.3, react-native-fcm 14.1.0

The notification is weirdly enough almost completely empty though, when it gets picked up by getInitialNotification on app open (without clicking on one).

So, when I check if notif.title exist, I can distinguish real initialNotifications from the fake ones, that are picked up when just opening the app.
Is this the intended behavior?

I am having the exact issue.....

@xanderberkein there is no way to clear the initial notification.
workaround would be adding a global variable outside of component lifecycle indicating if you have processed initial notification.

@evollu  is there any new way or any updates on this? I m facing this issue(or is it a behavior?) too.


Node joined to the cluster as secondary master is in NotReady state

Version:
k3s -v
k3s version v1.17.0+k3s.1 (0f644650)
Describe the bug
Create three nodes as masters. Third node changes from Ready state to NotReady state after sometime, using DQLite as the embedded db
To Reproduce
Create a cluster with single node providing token.
Join two more nodes as server to the cluster.
Expected behavior
All nodes in Ready state
Actual behavior
Third node goes to NotReady state after a while.
Additional context
No workloads added. Cluster was in idle state after creation to reproduce the issue. Logs show TLS handshake error
Jan 13 21:34:00 ip-172-31-13-183 systemd-timesyncd[539]: Network configuration changed, trying to establish connection.
Jan 13 21:34:04 ip-172-31-13-183 systemd-timesyncd[539]: Synchronized to time server <IP_ADDRESS>:123 (ntp.ubuntu.com).
Jan 13 21:37:17 ip-172-31-13-183 k3s[14501]: I0113 21:32:37.208395   14501 leaderelection.go:288] failed to renew lease kube-system/k3s: failed to tryAcquireOrRenew context deadline exceeded```

```Jan 13 22:02:47 ip-172-31-8-214 k3s[3105]: time="2020-01-13T22:02:47.675343907Z" level=error msg="failed to record compact revision: database is locked"
Jan 13 22:02:15 ip-172-31-8-214 k3s[3105]: I0113 22:02:15.282964    3105 log.go:172] http: TLS handshake error from <IP_ADDRESS>:36398: EOF```

@ShylajaDevadiga does the cluster datastore type matter? I'm guessing all are affected.

Closing - DQLite is now deprecated


Catch remaining missing supportUrl and rogue grammar.

Fix remaining hardcoded support straggler.

We'll need to make appropriate code changes for this @ProbablePrime

@Frooxius It is already handled.

Merging this, thanks!


ENYO-1894: Add Text to Speech Accessibility support to Progress

Apply accessibility on ProgressBar.
set 'progressbar' role, 'aria-valuenow' and 'aria-valuetext'.
https://jira2.lgsvl.com/browse/ENYO-1894
Enyo-DCO-1.1-Signed-off-by: Jaewon Jang<EMAIL_ADDRESS>

Looks good to me

replaced with https://github.com/enyojs/moonstone/pull/2438


Issue485 decimals in reports

New function to round numeric variables in dataset (round_decimals_df). Application of that function where pertinent to generate GGIR reports (g.report.part2, g.report.part4, and g.report.part5). Now, all the GGIR reports are saved with a maximum of 3 decimal places, except the data quality report because it might affect the calibrating factors in case they are used in other files. Also included a test file for the new function.

Checklist before merging:

[x] Existing tests still work (check by running the test suite, e.g. from RStudio).
[x] Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
[x] Updated or expanded the documentation.
[x] Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
[x] Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

Codecov Report

Merging #517 (942ca05) into master (3da596e) will increase coverage by 0.01%.
The diff coverage is 83.54%.

:exclamation: Current head 942ca05 differs from pull request most recent head dc78f4a. Consider uploading reports for the commit dc78f4a to get more accurate results

@@            Coverage Diff             @@
##           master     #517      +/-   ##
==========================================
+ Coverage   73.26%   73.28%   +0.01%
==========================================
  Files          92       93       +1
  Lines       11215    11242      +27
==========================================
+ Hits         8217     8239      +22
- Misses       2998     3003       +5

Impacted Files
Coverage Δ

R/g.part2.R
58.65% <ø> (-0.23%)
:arrow_down:

R/g.part3.R
61.66% <ø> (-0.32%)
:arrow_down:

R/g.report.part2.R
60.89% <38.88%> (-1.11%)
:arrow_down:

R/round_decimals_df.R
91.66% <91.66%> (ø)

R/g.analyse.perfile.R
88.38% <94.44%> (+0.30%)
:arrow_up:

R/g.convert.part2.long.R
76.72% <100.00%> (ø)

R/g.report.part4.R
84.18% <100.00%> (+0.16%)
:arrow_up:

R/g.report.part5.R
85.82% <100.00%> (+0.10%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da596e...dc78f4a. Read the comment docs.

The new round_decimals_df function is called where pertinent before storing the csv reports. Similarly, the remove_na_nan function is defined in different places in the package and called before storing the csv reports. What do you think about merging these 2 functions into (e.g.) tidyup_df()? So the remove_na_nan function does not have to be repeteadly defined and used.

Done. The tidyup_df function now combines both functionalities (rounding decimals and removing NA/NaN values). The remove_na_nan function is removed in g.report.part2, g.report.part4 and g.report.part5.


VRAM accumulation in Inference

Hi,
I'm currently working with this fabulous framework for adapting it to another problem.
Even though the model is in evaluation mode I suggest including a with torch.no_grad(): when performing the inference process (internally in the DPM solver). I had problems with memory accumulation during the inference process and I have solved it this way.
with torch.no_grad():
output = model(x, t_input, **model_kwargs)

check this issue https://github.com/WuJunde/MedSegDiff/issues/69


Cleaned Dev

fixed spelling mistakes, conventional errors, moved constants from giant file, added Shuffleboard tabs for each subsystem, has all subsystems in Dev

IDK if thats how you decided to do but i have qustions pleas someone reply to me so i can approve it (☆-ｖ-)

in comments: UTB Intake (caps, uppercase)
the folder: utbintake (all lowercase)
the files: UTBIntake (all uppercase)
the variables: utbIntake (camel casing)
same w otb

It is BCP to put ALL your constants in a single file like you had. That way you can easily find it by opening a single file. It is not considered BCP to put them in separate files for different subsystems or folders since that requires you search around for the proper file & folder.
Why did you essentially gut most of this file to move the various constants into separate files?

sorry what does BCP stand for?
also we separated them because the constants were getting really long and hard to scroll through/find anything, keeping them in relevant folders has a couple benefits like not needing to import it and shortening their names, we decided that as a team


Task switching on Windows is slow

When switching the active window with Alt-Ctrl, it often happens that nothing happens. This is because I'm used to task switching happen fast (instantly), but with Atom, it happens is that there is often maybe a 0.3 - 0.5 second delay until the "tasks dialog" (the dialog that contains task icons) appears.
So, in normal use switching task feels very unrealible - the task isn't often switched at all, since the dialog didn't appear fast enough.
Not sure if there is a fix for this or if this is because of the runtime used. Using Win 7 64-bit.

Actually a lot of other things are slow too. Not sure if there is a work around for this.
Have to switch to another editor unfortunately.

Suspect this is a dupe of https://github.com/atom/atom/issues/8451 will track it there.


TypeError: this.getMap is not a function V6.0.3

Now works with Angular 8, but still getting errors for polygons.
Environment:
Angular 8
"angular-maps": "6.0.3"
"typescript": "3.5.3"
Issue:
core.js:4002 ERROR Error: Uncaught (in promise): TypeError: this.getMap is not a function
TypeError: this.getMap is not a function

Polygons are not displaying.

As a workaround, I found that removing the [Title]="'Title Here'" from <x-map-polygon> it would render the polygon correctly. Stack trace seems to show it failing inside the show tooltip code.

Could you put a quick demo of your code together on stackblitz so I can take a look and debug this? The tooltip is implemented via a mapLabel,  I suspect this is a timing issue where the label has not yet been added to the map, so the getMap() function has not been added to the prototype yet (remember, bing maps is Javascript).  I think simply updating bing-label.ts from
    public GetMap(): Microsoft.Maps.Map {
        return (<any>this).getMap();
    }

to
    public GetMap(): Microsoft.Maps.Map {
        if(! (<any>this).getMap) return null; // or some such
        return (<any>this).getMap();
    }

will do the trick but want to look at it a bit closer first....

See https://github.com/infusion-code/angular-maps/tree/Issue110 as proposed fix. Will validate and publish as soon as I have your sample.

Stackblitz demo:
https://stackblitz.com/edit/angular-maps-bug-example

Can you please publish the fix soon.
I am getting this error. I was excited to see customStyle implementation but ran into polygon issue.
Thanks
krishna

Hi
Is there a way I can do npm install  --save "github:infusion-code/angular-maps#Issue110".
The above command does not get any of src directory gor me to work on.  I need this very urgently.

@krishtgkk Unfortunately, you cannot install from a branch, that is not possible with npm. I am planning to take a look on validating and publishing this Friday. In the meanwhile, you might use the workaround outlined above.

Hi
As suggested I have applied the fix locally. stilll getting errors as  cannot set property beneathLabels of undefined.
The issue is from BingMapLabel function.

Please Help.

Done some more investigation... This issue occurs because the BingMapLabel.getMap() is called before the label has been added to the map. The getMap function is dynamically added by Bing once the label has been added. This seems to be the result of dynamically creating the layers with the ngFor. Will need to investigate some more.

Further investigation shows the error was introduced with 6.0.3 by adding the Extender object to do the mixins. This does not to correctly appear to extend the prototypes of the objects with the mixed in class. This affects labels (used for tooltips) and overlays. I will need to debug this more to find the actual offending code...

Hi @thor-schueler, any update on this issue? Any there any docs for how to get started debugging the package?


chore: Adds canDisplayValue to property controls

Description

Added canDisplayValue(config, value) method to all the property controls
This property can be used to check whether a value in the input field can be represented directly in the property control UI.
Based on this method, we can disable or enable the JS toggle button.

Fixes #13307
TODO

[x] Add unit tests for each canDisplayValue methods
[x] Add canDisplayValue to ActionSelector
[x] Add canDisplayValue to LocationSearchControl

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manual

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: feat/can-display-value

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
56.74 (0.03)
38.72 (0.06)
36.26 (0.04)
56.99 (0.03)

:red_circle:
app/client/src/components/propertyControls/ActionSelectorControl.tsx
83.33 (-4.17)
66.67 (0)
60 (-15)
81.25 (-4.46)

:red_circle:
app/client/src/components/propertyControls/BaseControl.tsx
72.22 (-2.78)
44.44 (0)
40 (-10)
68.75 (-2.68)

:green_circle:
app/client/src/components/propertyControls/ButtonTabControl.tsx
73.68 (10.72)
52.38 (25.11)
71.43 (11.43)
71.43 (9.53)

:green_circle:
app/client/src/components/propertyControls/ColorPickerControl.tsx
94.44 (0.69)
72.73 (0)
80 (5)
93.75 (0.89)

:green_circle:
app/client/src/components/propertyControls/DropDownControl.tsx
55.38 (3.71)
47.06 (8.04)
58.33 (8.33)
53.33 (4.24)

:green_circle:
app/client/src/components/propertyControls/IconSelectControl.tsx
91.78 (0.29)
76.52 (0.41)
96 (0.17)
91.73 (0.26)

:green_circle:
app/client/src/components/propertyControls/IconTabControl.tsx
77.78 (5.05)
66.67 (26.67)
83.33 (8.33)
80.95 (5.95)

:green_circle:
app/client/src/components/propertyControls/LocationSearchControl.tsx
36.17 (2.08)
0 (0)
20 (-2.22)
37.21 (2.21)

:green_circle:
app/client/src/components/propertyControls/StepControl.tsx
51.52 (13.06)
50 (50)
37.5 (8.93)
61.54 (14.17)

:green_circle:
app/client/src/components/propertyControls/SwitchControl.tsx
93.75 (0.89)
85.71 (5.71)
80 (5)
92.86 (1.19)

:green_circle:
app/client/src/utils/PropertyControlFactory.tsx
80 (2.22)
33.33 (0)
75 (0)
80 (2.22)

:green_circle:
app/client/src/utils/autocomplete/TernServer.ts
52.94 (0.23)
41.67 (0.84)
36.21 (0)
56.99 (0.25)

/ok-to-test sha=b8f0baf

/ok-to-test sha=bddb02d

/ok-to-test sha=bddb02d


How to work with date objects in generated TypeScript client

I used NSwag to generate a TypeScript Angular 2 client for my .NET Web API service via a swagger.json file.
Some of my DTOs contain date fields that are formatted as ISO date strings in json.
The swagger definition of the fields look like this:
"BeginDateTime": {
    "format": "date-time",
    "type": "string"
},

This is the field in the generated TypeScript interface:
BeginDateTime?: Date;

And the JSON object:
{
    ...,
    "BeginDateTime": "2016-04-19T18:03:40.887",
    ...
}

The problem is that Json.parse() does not convert the date string to a JavaScript date object. When I want to use date specific functions like dto.BeginDateTime.getHours() it's no problem at compile time but crashes at runtime.
I can also not simply do a new Date(dto.BeginDateTime) because it would cause a TypeScript compile error. The workaround is new Date(<any>dto.BeginDateTime) and that's not the way we should use TypeScript.
What is your preferred way to handle this? Why does the generated client not use a reviver function to parse the date? Or at least allow me to inject a function or service that can do this.

DateTime is a big problem in JSON because there is no standard way to serialize them. The generated DTOs are just interfaces and cannot implement conversion methods or other logic to convert to a date. A way to fix this is to instead of serializing to "2016-04-19T18:03:40.887" serialize to date(...). I think there is an option in Json.NET to do this... I have to investigate further and check what the default behavior of Json.NET is...

If you serialize with JavaScriptDateTimeConverter then datetimes are serialized to new Date(...) and then the interfaces are correct... but I don't like having JavaScript in the JSON data...
http://james.newtonking.com/archive/2009/02/20/good-date-times-with-json-net
The other option is currently to add a setting to generate datetime as string... but this is also not very good.
The best solution would be to generate classes instead of interfaces and convert datetime properties from string to Date (if necessary). This is much more time consuming to implement but on the roadmap: https://github.com/NJsonSchema/NJsonSchema/issues/43

Another option is to add support for "\/Date(1198908717056)\/" in the generated client classes so that Json.NET standard serialization works correctly:
http://weblogs.asp.net/bleroy/dates-and-json

Thank you for your answers!
I know it's a general problem in JSON, but I hoped there is a way to handle this with NSwag. Like injecting a reviver function that can be used by the JSON.parse(text[, reviver]) function.
We use ISO date format because it is used by all big players and is therefor a de facto standard.
I will keep an eye on the implementation with classes and use a workaround in the meantime.

Currently, the Angular 2 template just uses the response.json() method to get the JSON.
https://angular.io/docs/ts/latest/api/http/Response-class.html
We could change this to:
var text = response.text();
var data = JSON.parse(text, this.reviver);

so that you can implement your reviver...

Ok, I've added some new bugs:
https://github.com/NSwag/NSwag/issues/62
https://github.com/NJsonSchema/NJsonSchema/issues/55

Ok, the Angular 2 tpl now accepts a reviver function and "\/Date(...)\/" is supported for all templates...
https://github.com/NSwag/NSwag/commit/c71f2ae9615c987be45c732f73c948a714028a73
You can now inject the ISO date time reviver function here:
http://stackoverflow.com/questions/1792865/how-to-use-json-parse-reviver-parameter-to-parse-date-string
More info in the issue here: https://github.com/NSwag/NSwag/issues/62

You can use the reviver here for converting ISO datetime strings:
http://stackoverflow.com/questions/1792865/how-to-use-json-parse-reviver-parameter-to-parse-date-string

Thank you for the prompt implementation. Reviver is now working for me!


Distributed identity: improve testability

What this PR changes/adds
Create an EdcSetting to optionally toggle http:// scheme instead of https:// when resolving DID Document URLs
Why it does that
When testing a deployment in docker-compose, it's quite a hassle to set up SSL and trust. It would be much more convenient to have an option to change the scheme to http:// for development.
This will be used by EDC extension projects such as https://github.com/eclipse-dataspaceconnector/RegistrationService for CI and local integration testing.
Further notes
Linked Issue(s)
Closes #1522
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] added relevant details to the changelog? (skip with label no-changelog)
[ ] formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

Codecov Report

Merging #1542 (4b7bec7) into main (3584c73) will decrease coverage by 0.21%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
- Coverage   67.37%   67.16%   -0.22%
==========================================
  Files         735      736       +1
  Lines       16198    16143      -55
  Branches     1058     1049       -9
==========================================
- Hits        10913    10842      -71
- Misses       4803     4824      +21
+ Partials      482      477       -5

Impacted Files
Coverage Δ

...ataspaceconnector/iam/did/web/WebDidExtension.java
0.00% <0.00%> (ø)

...connector/iam/did/web/resolution/DidFunctions.java
58.82% <71.42%> (+5.49%)
:arrow_up:

...nnector/iam/did/web/resolution/WebDidResolver.java
56.52% <100.00%> (+1.97%)
:arrow_up:

...tor/spi/types/domain/transfer/TransferProcess.java
68.75% <0.00%> (-6.10%)
:arrow_down:

...sferprocessstore/InMemoryTransferProcessStore.java
94.11% <0.00%> (-2.04%)
:arrow_down:

.../dataspaceconnector/spi/entity/StatefulEntity.java
0.00% <0.00%> (ø)

...main/contract/negotiation/ContractNegotiation.java
0.00% <0.00%> (ø)

...aceconnector/common/statemachine/StateMachine.java

...ector/common/statemachine/StateMachineManager.java
94.11% <0.00%> (ø)

...tor/core/defaults/InMemoryStatefulEntityStore.java
100.00% <0.00%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3584c73...4b7bec7. Read the comment docs.

LGTM


HomePage: Left Display (Image or Slideshow)

Add a image/slideshow on the left half of the homepage

Can we do an image gallery with carousel instead of slideshow?

Yesss sounds good


Disable generation of Id property

I am trying to migrate to squidb but my old database uses String ids. And as squidb supports only INTEGER as primary key, the generated class has now two methods returning 'ids': the rowid and the server id. This situation is error prone because all my code is base on the server id.
Any idea how to disable the generation of the Id property ?

This depends a little bit on exactly what you're asking.
If you've already declared your String server id column explicitly with a PRIMARY KEY constraint, this is probably not currently possible. SQLite only supports a single primary key per table, and squidb assumes it to be the rowid as a means of bookkeeping about whether or not a model object exists in the table yet. We can take a look at enhancing things in such a way that you could specify the rowid to NOT be a primary key, but I can't say for sure what changes that might require -- it'll take a bit of experimenting, as we'd still need to use the rowid for bookkeeping.
It sounds though like you might be asking more about naming. The base TableModel class that supports all table models does declare getId() and setId() methods for the long rowid, so those can't be removed or renamed -- if you're already using those method names for accessing the server id there's not much that can be done without updating the code that calls those methods.
If on the other hand those accessor methods DON'T exist yet, it will be possible to make sure that there's no naming confusion. The getter/setter/Property constant names are derived from the name of the field in your model spec, but the column name underlying them can be declared as something else using the @ColumnSpec annotation. So, you could declare something like this:
class MyModelSpec {

    // This will make the squidb integer primary key column be named myRowId instead of _id,
    // and the generated Property for the column will be the same. However, the getId and setId
    // methods will still exist as they're in the base class rather than generated code
    @PrimaryKey
    long myRowId;

    // This will make the accessors be getServerId/setServerId, but the underlying column will
    // be named "_id" -- useful if it already exists that way.
    @ColumnSpec(name = "_id")
    String serverId;
}

I've been  meaning to look into supporting things other than integer primary key for a while, but it's never been a high priority. Again, whether or not what you're asking will be possible right now depends a bit on your specific use case, but I'll leave the issue open to motivate us to improve our support for different kinds of primary keys.

Thanks a lot, it's very helpful !

if you're already using those method names for accessing the server id there's not much that can be done without updating the code that calls those methods

This is exactly my case, so I renamed the server id before starting the migration.
Is there a way to make the generated getter/setter of the row id private ? this way we ensure that we use use always the server id instead on the local id (rowid).

Unfortunately not at the moment. Those methods are actually defined in a base class rather than being code generated, as seen here: TableModel#getId().
I started working on a change that will eliminate the restrictions on our primary key support and use the internal SQLite rowid column for our bookkeeping, rather than requiring that all table models generate an _id integer primary key. As a part of this change I'll be deprecating those existing getId() and setId() methods, but we can't remove them entirely until the next major version release, as it would be a backwards-incompatible change to the public API and we'd need to give users some time to update. While deprecating them wouldn't prevent them from being called, it would at least be a warning every time you did -- so in the meantime, maybe that would be enough of a deterrent in your use case to ensure that you always used the server id?
I know it's still not 100% ideal for your use case at the moment but I appreciate that you're forging ahead and giving us this feedback! It's made me take a very close look at how we treat the autogenerated ID column and primary keys in general, and I think squidb will be better for it once some of these changes land.

This is awesome, I think it will help a lot to avoid the confusing of having two different ids.
Maybe an option is to make the generation of the setId and getId configurable, it will be convenient for the new users like me without any backwards-incompatible changes.
I really appreciate your efforts on creating this library and your responsiveness. It makes my migration journey a lot easier. If interested I can give you more feedback on the migration difficulties.

Happy to help! If you wanted to provide a list of the pain points you ran into when migrating it could be helpful for informing other feature requests. I can guess at what some of them are, but I'd be interested to get your perspective to see if I'm right :)

Maybe an option is to make the generation of the setId and getId configurable, it will be convenient for the new users like me without any backwards-incompatible changes.

This might work, not a bad idea at all. I'll have to experiment, but maybe as part of the changes I'm working on we can start generating those methods so that we can remove them from the base class. Then we can add some kind of temporary option to disable generating those methods for users like yourself.

Happy to see that there already a PR for this :)
Is there any snapshot that I can start using ?

Not yet, but we may publish a beta 3.1.0 version after the PR has been reviewed and merged.
I should also mention that unfortunately it wasn't possible in this PR to remove the getId and setId methods from TableModel after all, so the restriction of "no user properties named ID" will have to remain for now. The main reason for this is that users (including ourselves) may have defined custom methods operating generically on TableModel instances that call getId and setId, so removing them from the class entirely would be a breaking change even if they were generated in the model classes. We'll be able to remove this restriction whenever the next major version of SquiDB lands, because we'll have given users enough time to upgrade from the deprecated getId/setId to the new getRowId/setRowId that replace them.
I think other than this restriction the PR addresses the use cases discussed here, but feel free to review the summary in the PR and add comments if you have other thoughts!

Ok thanks. I looked at the PR and it looks fine except the fact that I can't name any property as Id.
To better understand things and to best implement my migration from ormlite to Squidb:
Now I am using integer and string Id properties and they are named "id".
For The classes with an integer id proeperty: nothing to do. I can keep using them.
For the classes with string id property: I have to rename the id field to something else (for example uid), and with the new beta I can annotate them with @PrimaryKey
is that correct ?

That sounds mostly correct, yes. A few things to take note of, just to be sure:

The property and underlying column don't have to be named the same thing -- the property name comes from the field name, but you can name the underlying column something else using @ColumnSpec. This will probably be useful to you to make sure that the column names match in your migration.
The default squidb integer primary key ID property makes a column named _id, so if this doesn't match your existing schema you should use @ColumnSpec to make sure the column names match, even in those tables that use integer primary key ids.
The restriction of "non-integer primary key properties can't be named ID" only applies to the property name -- any underlying column can still be named id.

Ok great, everything is clear now. Can't wait to try the new beta.

If you want to try it now so you don't have to wait for an official beta, you can always build from source as described here.

It's working great ! Thanks for all the help, I just finished migrating the code and works like a charm. I didn't have any issue until now.

PR merged!


Elminiated the cppcheck findings for include/pistache/optional.h.

Had to hack around apparent bug in cppcheck. :(

Codecov Report

Merging #658 into master will decrease coverage by 0.03%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
- Coverage   70.58%   70.54%   -0.04%
==========================================
  Files          49       49
  Lines        6856     6857       +1
==========================================
- Hits         4839     4837       -2
- Misses       2017     2020       +3

Impacted Files
Coverage Δ

src/common/description.cc
24.11% <0%> (ø)
:arrow_up:

include/pistache/optional.h
92.85% <100%> (+0.08%)
:arrow_up:

src/common/http.cc
80.51% <50%> (ø)
:arrow_up:

src/common/mime.cc
85.92% <50%> (ø)
:arrow_up:

src/common/http_headers.cc
82.6% <50%> (ø)
:arrow_up:

src/common/transport.cc
65.35% <0%> (-0.79%)
:arrow_down:

src/common/os.cc
56.32% <0%> (-0.64%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a13e4fd...0ad580e. Read the comment docs.


Update shaded Jackson Core code in azure-json

Description
Updates the shaded jackson-core code in azure-json from version 2.13.2 to 2.17.2.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

The changes look good to me.
Process question - do we want to automate this and update the shaded code every time we update the external_dependencies.txt file to use newer version of Jackson?

I'd rather do this infrequently but manually as there are some edits that have to be done to have the shaded Jackson code pass our compilation configuration (unnecessary casts, etc). I was thinking we'd do this once or twice a year and setting up that automation won't be worth the effort.


Help with Candlesticks required

Hi! First of all - thanks for your hard work!
Wanted to ask how can i make candle shadows longer?
Screenshot

As you can see, almost all shadows of candles are missing (except several proper shadows, i marked one of them). Which settings should i change to increase length of shadows, and decrease length of body of candle?
Also, it's possible to see that sequence heights of opening and closing of main (real) body of candles is wrong.
Close price of current candle is open price of next candle. That means body of current candle should start from same height as where body of previous candle finished. If you pay attention, it could be seen that most candles are just standing side by side without proper height order. How can i fix that?
Screenshot2 (expected behaviour)

Thank you for the feedback.

The length of shadow and body is calculated according to the data. I have checked this and there is no problem.
This is a bug, which is particularly evident in the descending candlestick charts. I will fix it as soon as possible.

I have fixed this issue in the master branch

Thank you for the feedback.
1. The length of shadow and body is calculated according to the data. I have checked this and there is no problem.

2. This is a bug, which is particularly evident in the descending candlestick charts. I will fix it as soon as possible.

Thanks you for checking. I think my case was that when i used Y axis Min-Max Type: Auto - values were too far apart from candlestick's lowest-highest values. That's why shadows were too short to see. Now that i switched to Y axis Min-Max Type: Custom, and setting Y axis Min-Max values myself depending on currently on-screen candlestick's lowest-highest values, it's all working properly.
Thanks!


correcting handler config example

bundle exec lita throws error when attempting to use api_url as forecast_io config.handler key  - grep'd through and changed to api_uri based on test syntax and all seems well.

Nice.  That bit me once before.  :)


Fix failing fallback_plugin tests and add to modules_test

Fixes #2756.

Thanks for the quick response @blink1073!


Get-DbaSqlBuildReference Upgrades

Fixed file handling in writable location (used to never update it after first copy. Issue when updating the module)
Redesigned object/property handling (Use Version type rather than suffer string manipulation)
Fixed Scope Violations (evil)
Overhauled messaging and flow control (Just adapting it to the current state, since a lot has changed)
Implemented DbaInstanceParameter (Another addition that came later)
Implemented integrated connections to instances. (Trivial with the instance parameter)

failing tests should not be a problem. When this is merged, I have one PR in line to let the index be fetched without having to update the release.

thanks all! 🙇


Could oci2aci provide 2 options for better use?

After using the oci2aci , I think that's a good tool for users , and could you provide the following 2 options when using the oci2aci command? :)

aci image name option: current image name/id is example, I think user might want to specify the name he/she wants
output folder:  default output folder is /tmp , user might want to specify where the output  aci file stored

@wangkirin Thanks so much for your sincere advice.
Quite agree with what you said, I will implement it in the coming days.

Hi @wangkirin, I have implemented what you mentioned before, please try out the tool and give your feedback, thanks a lot for your attention:-)


Scrape google search results for related searches

Scrape the google search results to retrieve the searches related section.
Things to handle:

Rethink overlap calculation method.
Consider removing overlap detection fully.
Bypass bot detection if needed.

Also keep in mind the issue of convergence, without a cap limit and reject procedure, convergence can be tricky.

Closing as deprecated.


Implement Work screen and it's behavior

Implement screen that counts work time.
TODO - describe how this screen behaves

Was implemented on the commit a907cec7980e11


Error accessing the database: Snippet type custom is not configured

Error accessing the database: Snippet type custom is not configured
Hue 4.5
tar hue.4.5gz build to install
config_jars_libs_path /user/hdfs/libext/libs
put  mysql-connector-java.jar into /user/oozie/libext/jdbc_drivers
chmod 755 to all
use imporer to import data from MySQL
type External Database
model customer
driver MySQL
host <IP_ADDRESS>
port 3306
user surpt
pwd surpt
then click test connect
error message :
连接失败：Error accessing the database: Snippet type custom is not configured.
log:  nothing wrong

also i have this problem in importing data with hue
did you find the solution ?

any resolution on this? Postgres also returns this message on importing an external database.

@jessequinn  ,  the error is due to something not configured well in hue.ini file (or pseudo ini if using the dev version)
Please look into that.

it's more than likely related to oozie. I am configuring this now.

same question...anybody knows it?

some problem here,how to slove it?
hue 4.6.0

@tencentemr you need to configure the source in the .ini

@tencentemr you need to configure the source in the .ini

Hey jersey thanx your reply
Could u show me the code how to configure ini file.for example if I wanna use customizable jdbc or hostname on this section?

@tencentemr you need to configure the source in the .ini

@jessequinn
Hey jersey thanx your reply
Could u show me the code how to configure ini file.for example if I wanna use customizable jdbc or hostname on this session?

@jessequinn Could you please explain a bit more about what you mean by "configure the source"? I see several sections mentioning MySQL as available for use as the db backend for Hue (obviously not what we're talking about) or as a subsection in the librdbms section. Is the librbdms section what you mean? Thanks for any help!

@ajs6f did u find the solution for the problem?

@divincode Nope, and we've given up on this. We aren't using Hue heavily now. Good luck, and please do comment here if you do figure it out.


Where is this now?

The image shows Authentication Settings and Custom Banned passwords in  AAD but it has since moved... where would this be found now?  And how do we find it in the ever evolving Azure Portal of Portals?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c58c903b-778e-e1d9-31c3-321a6fd0050f
Version Independent ID: 9ee47301-0c8d-26ff-1deb-6d309aef2f97
Content: Dynamically banned passwords - Azure Active Directory
Content Source: articles/active-directory/authentication/concept-password-ban-bad.md
Service: active-directory
Sub-service: authentication
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@D-Jeffrey Thank you for your feedback. We will investigate and update further.

It is right there where the screenshot says, except that it is not "(preview)" anymore.
login to portal.azure.com, select "Azure Active Directory", then select "authentication methods" (in SECURITY section), then select "password protection".

@ScarOF Thank you for your contribution. Much Appreciated . :)
@D-Jeffrey Once you click authentication methods , currently you have one setting to manage which is password protection and you can see the custom banned settings there as well. It has not moved. As pointed out by @ScarOF its just out of preview now. Please check the following screenshots.

We will close this issue now. Should you still have any further queries , feel free to tag me or the document author @MicrosoftGuyJFlo to your reply and we will be happy to help.
Thank you.


Can't install on Windows 11

When install Intel.RealSense.Viewer.exe  or Depth.Quality.Tool.exe  on Windows 11, crash  message like this.

Hi @shanxu9198   Do you experience the same error on Windows 11 if you install the full RealSense SDK on Windows instead of the standalone .exe versions of the Viewer and the Depth Quality tool, please?  The SDK installer will install versions of the Viewer and DQT that are bundled inside the SDK instead of the .exe versions on the Assets file list.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.50.0

The SDK installer will place launch shortcut icons for the Viewer and DQT on the Windows desktop when installation has completed.

@MartyG-RealSense Thank you for your reply. I install Intel.RealSense.SDK-WIN10-<IP_ADDRESS>85.exe successfully, but when start  Intel RealSense Viewer I got the same error

.

Please try running the SDK example program rs-capture.exe that will have been installed on your Windows computer when you installed the full RealSense SDK with Intel.RealSense.SDK-WIN10-<IP_ADDRESS>85.exe.   Instructions for launching rs-capture on Windows can be found at https://github.com/IntelRealSense/librealsense/issues/8024#issuecomment-747630656

It looks as though nvhw.inf is an old Nvidia graphics driver that is associated with the Nvidia Quadro graphics brand.
Could you provide information about the manufacturer and model name of your computer, please?
Does the error still occur if you update the graphics drivers on your Windows computer?
To help to confirm whether the error is graphics related, could you use the instructions at
to try running the non-graphical text program rs-hello-realsense.exe example program that will be in the same SDK Tools folder as rs-capture.exe.

Hi @shanxu9198  Do you require further assistance with this case, please?  Thanks!

Case closed due to no further comments received.


extend grid height when move or resize grid item

Whenever, grid item move or resize event is triggered, extend grid height, so the user could easily move grid items around.

You can use float:true in grid option. It will help you out.

@vbinithyanandamv I'm not sure which grid option you are referring to.
I looked for float option in INgGrid.d.ts. I couldn't see any option named to it.

Hi Martin, sorry for the misunderstanding. Seems like there is no API for it as you said. Then there is no straight forward way. However you can manually use CSS to fix the grid container height.


Fixes webp integration for CocoaPods > 1.0. Thanks to SDWebImage for …

…the solution and @yxztj to pointing it out!
Addresses #158

Thanks @garrettmoon !


Java 8 Support

:tada: This PR is included in version 0.2.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[attributes] seem to always be included in bundle

Hey guys,
Question about [attribute] selectors - are they intended to never be stripped from the final bundle? I noticed that they are always included.
My webpack config - nothing special, just good ol' vanilla purging:
new PurgecssPlugin({
  keyframes: false, // https://goo.gl/bACbDW
  styleExtensions: ['.css'],
  paths: globAll.sync([
    './src/**/*.js',
    './src/**/*.jsx',
    './src/index.ejs'
  ], { absolute: true })
})

I'm using my own scss library called Sassyons which out of the box contains an obnoxious amount of classes. Over 24,000 lines worth! Purgecss successfully strips that library down to only the handful of selectors that are actually used in my test project. So far, so good. Then I add these 2 styles to my top-level scss file to test things out:
.this-is-never-used {
  display: none;
}

[this-is-never-used] {
  display: block;
}

The class is stripped out successfully and not included in the built asset but the attribute selector is included. I'm wondering if this is because attributes can be a pain since they can be regexy like [some-attr*] or [another-attr^=whatever].
Just want to know if this behavior is intended or not. I'm trying to revamp my Purgecss Whitelister plugin and don't know if I should be considering attribute selectors or not since they seem to be included by default.  If they aren't supposed to be included by default (i.e. this is indeed a bug), what would be the correct way to whitelist them once this is ironed out? Should the whitelist array contain something like [attribute-name] or attribute-name?  I appreciate your help in advance!

Yes, attributes are not stripped from the final bundle.
At the moment, attributes are not consider when removing unused css. If the class associated with the attributes is not used, then it will be removed.
button[disabled=true], this will be removed if button is not found in the content. But it will be kept otherwise. I'll close this issue as https://github.com/FullHuman/purgecss/issues/110 is a duplicate.

@qodesmith
https://github.com/FullHuman/purgecss/issues/110#issuecomment-475669082


Web-UI is broken on Windows in the latest version of script(1.1.1)

Describe the bug
When I click on run button, the web-ui doesn't start. I get error messages in web-ui
You must click stop and then re-run tgcf to apply changes in config.
module 'signal' has no attribute 'SIGCONT'

I haven't modified anything. After a few seconds the run button appears again and if I click it is starting all over again with the same errors.
In terminal, I get these messages:
'rm' is not recognized as an internal or external command,
operable program or batch file.
'tail' is not recognized as an internal or external command,
operable program or batch file.

To Reproduce
Click on the run button to start the web-ui
Expected behavior
web-ui starts and shows the logs.
Screenshots

System information:
Windows 11 Enterprise 22H2
I also posted a question in Discussion, regarding the live mode.

tgcf is not supported on windows. Please read wiki. when video will come, the link will also be given in this same page.
https://github.com/aahnik/tgcf/wiki/Run-tgcf-on-Windows
you need to install Ubuntu 22.04 (a linux distro) using WSL (Windows Subsystem for Linux)


Implement Exercise type.

For options?
Seems this exists (American, European and Bermuda), but it's not really used.
How would you see the design?


electron-notorize hanging, but pinned to old version

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
^6.0.0-beta.60
Electron version
^14.0.0
Operating system
macOS 11.5.2 (m1)
Last known working Electron Forge version
No response
Expected behavior
Notarization is hanging for me.
I'm pretty sure the latest electron-notarize package will help. However, this project has pinned it to an old version.
https://github.com/electron-userland/electron-forge/commit/60778998108b56a264b14c75570a925ef843f8b7
Please can we change this?
Actual behavior
--
Steps to reproduce
--
Additional information
No response

To anyone following along, I repinned it using:
    "**/electron-notarize": "^1.1.0"
  }```

Electron-notarize have fixed the Typescript issue I think now.


AttributeError: 'CustomPGVectorStore' object has no attribute '_async_session'

While running a application getting attributeError
After set the value of _async_session getting below error

@shavejshaikh I think you just need to update your fork to the latest code in this main repo. Your stacktrace shows the error coming from async with self._async_session() as session: on line 43 of pg_vector.py. As you can see in the latest code here, we've since added a call to self._initialize() that sets up these session variables. Let me know if that fixes your error!

@sourabhdesai  While migrating using make migrate getting error

@sourabhdesai  After cloning latest code again getting error while migrating

Any idea ?

@sourabhdesai After update pg_vector.py getting error
AttributeError: 'CustomPGVectorStore' object has no attribute '_initialize'

@sourabhdesai , now getting DETAIL:  Could not open extension control file "/usr/share/postgresql/16/extension/vector.control": No such file or directory.
Created env using conda and install dependency using poetry

Any idea ?

Found the solution since pgvector isn't install along with postgres (Ubuntu).

Check postgres version
postgres=# SHOW SERVER_VERSION;

Install pgvector based on above postgres version
sudo apt install postgresql-16-pgvector
Change 16 based on your postgres version


Move put strike price up 1.00

Both put and call are trading at the floor/ceiling of the current price now.


Authentication Process Failed

Describe the bug*
When running the command $ docker run --env-file env.list -p 5000:5000 voyz/ibeam:0.3.0-rc7 , I encounter the following error/s:
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
2021-08-31 10:36:19,964|I| ############ Starting IBeam version 0.3.0-rc7 ############
2021-08-31 10:36:19,992|I| Gateway not found, starting new one...
running
runtime path : root:dist/ibgroup.web.core.iblink.router.clientportal.gw.jar:build/lib/runtime/*
verticle     :
config file  : root/conf.yaml
2021-08-31 10:36:21,005|I| Gateway started with pid: 24
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by io.netty.util.internal.ReflectionUtil (file:/srv/clientportal.gw/build/lib/runtime/netty-common-4.1.15.Final.jar) to constructor java.nio.DirectByteBuffer(long,int)
WARNING: Please consider reporting this to the maintainers of io.netty.util.internal.ReflectionUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
-> mount demo on /demo
Java Version: <IP_ADDRESS>

version: b5beb780761419a2f516040b40c47ec99d5f077e Wed, 24 Feb 2021 17:22:21 -0500

This is a Beta release of the Client Portal Gateway
for any issues, please contact<EMAIL_ADDRESS>and include a copy of your logs

https://www.interactivebrokers.com/api/doc.html

Open https://localhost:5000 to login
App demo is available after you login under: https://localhost:5000/demo/
2021-08-31 10:36:30,596|I| No active sessions, logging in...
2021-08-31 10:36:33,171|E| Error encountered during authentication
Traceback (most recent call last):
File "/srv/ibeam/src/authenticate.py", line 150, in authenticate_gateway
driver = start_driver(base_url, driver_path)
File "/srv/ibeam/src/authenticate.py", line 270, in start_driver
raise e
File "/srv/ibeam/src/authenticate.py", line 258, in start_driver
driver = new_chrome_driver(driver_path)
File "/srv/ibeam/src/authenticate.py", line 47, in new_chrome_driver
driver = webdriver.Chrome(driver_path, options=options)
File "/opt/venv/lib/python3.7/site-packages/selenium/webdriver/chrome/webdriver.py", line 81, in init
desired_capabilities=desired_capabilities)
File "/opt/venv/lib/python3.7/site-packages/selenium/webdriver/remote/webdriver.py", line 157, in init
self.start_session(capabilities, browser_profile)
File "/opt/venv/lib/python3.7/site-packages/selenium/webdriver/remote/webdriver.py", line 252, in start_session
response = self.execute(Command.NEW_SESSION, parameters)
File "/opt/venv/lib/python3.7/site-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
self.error_handler.check_response(response)
File "/opt/venv/lib/python3.7/site-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.WebDriverException: Message: chrome not reachable
(Session info: headless chrome=89.0.4389.82)
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/srv/ibeam/src/authenticate.py", line 238, in authenticate_gateway
raise RuntimeError('Error encountered during authentication') from e
RuntimeError: Error encountered during authentication
2021-08-31 10:36:33,216|I| Authentication process failed
2021-08-31 10:36:34,916|I| ############ Starting IBeam version 0.3.0-rc7 ############
2021-08-31 10:36:35,021|I| Starting maintenance with interval 60 seconds
2021-08-31 10:37:36,108|I| No active sessions, logging in...
2021-08-31 10:37:38,676|E| Error encountered during authentication
To Reproduce
Steps to reproduce the behavior:

Open docker
Run a container (using command line in VSCode)
Starting up docker image using env.list file
Authenticaton process failed

Expected behavior
The above steps 1-3 should lead to "Gateway running and authenticated"
Environment
IBeam version: 0.3.0-rc7
Docker image or standalone: image
Python version: 3.9.6
OS: Mac OS 11.4 (Apple M1)
Additional context
For reference, if I go to https://localhost:5000 and enter my credentials manually, I'm able to establish a connection successfully (only with my live account details) But, if I log in with my paper credentials, although https://localhost:5000 shows client login successful, I cannot see a successful authentication from my command line. Do you have any idea how I can connect my paper trading account specifically? (as I'd like to test my strategy on my paper account first).
Suggest a Fix
Not sure if it's anything to do with (bool, bool) (line 129 authenticate.py) and (bool, bool, bool) (line 48 http_handler.py)
I'd really appreciate your assistance as I'm quite stuck!
PS: love your work

Hi @mattspinach welcome to IBeam and thanks for writing this issue report 👋
Let me address a few things first:

Are you running it on a M1, ie. ARM processor? Others have attempted to do so and found it impossible. I've tried to compile an ARM image but also wasn't successful in doing so. You can read more about it here: https://github.com/Voyz/ibeam/issues/17

The current latest version is 0.3.0. Is there any reason why you're using 0.3.0-rc7?

Has this issue happened several times? Can you let IBeam run for 10 minutes and observe if this issue continues to repeat, or whether some other issues apear later?

Hi @Voyz
Thank you so much for your reply. I'm totally new to coding (I'm more of a trader with a finance background who's stepped foot into the programming space for the first time) and I'm attempting to build a bot that will trade for me, so your assistance is really, really appreciated.

Yes, I am running it on the M1. That's quite unfortunate that the M1 chip is the cause of my problems, but I wanted to ask, if I was to run this on an AWS EC2 instance (say Linux), then I wouldn't have this issue, is that safe to say? I'm planning to deploy my code to the cloud anyway as I intend to have it running 24/7 (as that would take away the need for me to keep my computer running all the time or setting up a Raspberry Pi and worrying about internet/power outages), so if that's the case, then maybe an EC2 instance is the way to go?
I decided to run it on 0.3.0-rc7 to see if that would make a difference which it didn't.
This issue happens every time I run $ docker run --env-file env.list -p 5000:5000 voyz/ibeam and keeps looping the failed authentication (even after letting it run for 20 minutes or more)

Once again, thank you so so much for your help. Look forward to hearing from you.

@Voyz I've been able to resolve the issue with the help of #31
Thanks for your help !

Fantastic @mattspinach I'm glad to hear that 👍😊 Closing the issue in this case, feel free to reopen if these problems return

Hi @Voyz I wanted to ask whether you've been running IBeam consistently for some time now because I noticed that IBKR's server was being quite buggy when I was testing it a couple weeks ago. I had Ibeam running and keeping me authenticated and it worked quite well most of the time but I believe it was IBKR's server that just wasn't reliable.

To some extent I use it consistently since around February 2021, however I also encounter the issues you're describing @mattspinach. IBKR server indeed is not reliable, so depending on your case you may want to look for a more robust solution. I wish it was otherwise, and I'm hoping sooner or later IBRK will fix these issues, in which case trading using the Client Portal Web API (and through it using IBeam) will become a lot more reasonable of a solution 🤷♂


MINOR: increase the timeout for the streams broker resilience test

After observing what seems to be a transient system test failure related to recovery just being a little slower than expected, I'm recommending to increase the timeout to the same value we use for trunk.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

/cc @guozhangwang @bbejeck


[Bug] Tag family not showing up

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
BanyanDB (apache/skywalking-banyandb)
What happened
When adding tag in BanyanDB web app, the tag family is not showing up. Hence, user is unable to add tag in Web App.

What you expected to happen
Tag family should show up. Or allow empty tag family when adding tag.
How to reproduce
Go to BanyanDB Web App. Create Measure, then add tag.
Anything else
No response
Are you willing to submit a pull request to fix on your own?

[X] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Sylvie-Wxr Is there any update?

I found that this actually requires entering the tag family first, and then you can select from the dropdown, so the function is not problematic. It's just not very intuitive. I'll go ahead and close the issue first.

I found that this actually requires entering the tag family first, and then you can select from the dropdown, so the function is not problematic. It's just not very intuitive. I'll go ahead and close the issue first.


"Persist headers" not working

Currently "Persist headers" does not persist the config after page refreshing. Any workarounds?
Tested on Chrome and Safari

I can see it toggles the variable on local storage, but after page refreshing it is gone.

Duplicate of https://github.com/mll-lab/laravel-graphiql/issues/13, related to https://github.com/mll-lab/laravel-graphiql/issues/21.


added headers option

Closes # .
Checklist:

[ ] issue number linked above after pound (#)

replace "Closes " with "Contributes to" or other if this PR does not close the issue

[ ] manually checked my feature / checking not applicable
[ ] wrote tests / testing not applicable
[ ] attached screenshots / screenshot not applicable

Hey @almahari
thanks for the PR - what did you try to achieve and why did it fail?

hey @BracketJohn ,
Want to add custom headers to the signIn, session and signOut requests


Tests for pipelines?

I suggest we add unit and/or end-to-end tests for the individual pipelines.
The advantage of end-to-end tests with actual data is that it would catch not only errors introduced by changes to the code but also errors introduced by changes to the source data or data format (how often does this happen?)
One type of end-to-end test is to verify that certain columns in the source file match certain columns in the output file for the latest date, for particular keys.
For example, for Afghanistan, we can verify that for the latest date, looking up the rows where 'Province' = 'Zabul Province' in the source and key = 'AF_ZAB' in the epidemiology.csv output, the values match for the following columns, stored as a map from column name of source to column name of output {'Cases': 'total_confirmed', 'Deaths': 'total_deceased', 'Recoveries': 'total_recovered'}
This won't work for every data source (some like Great Britain seem to have differently formatted source data).  For these we could either add some data transformations (how complex to allow I don't know, at some point we would start to duplicate the actual pipeline code) or just leave them out of the end-to-end testing and perhaps just have unit tests for them.

Have you seen https://github.com/open-covid-19/data/blob/master/src/lib/anomaly.py?
The core idea is the same, trying to detect when a pipeline stops outputting good data. But it's still not very comprehensive and it's too slow. Rather than unit tests, I would like to see some kind of status dashboard. Although maybe we're talking about the same thing, with a dashboard powered by unit tests :-)

Yeah, I think having unit tests and having their status surfaced on a
dashboard would be great.
I think detect_anomaly combined with unit tests would be good.
detect_anomaly for detecting problems with input data or schema or
mismatches between them, and unit tests to confirm that the data processing
works.  We could have a unittest framework that allows specifying a unit
test for each pipeline (either as input/output csv files or code to
construct the input and output DataTables) and runs the pipeline on the
input data and checks whether it matches the output data.

The core idea is the same, trying to detect when a pipeline stops
outputting good data. But it's still not very comprehensive and it's too
slow. Rather than unit tests, I would like to see some kind of status
dashboard. Although maybe we're talking about the same thing, with a
dashboard powered by unit tests :-)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/open-covid-19/data/issues/117#issuecomment-643642002,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABUM5R62UGU4VU3IARZGEE3RWOOTVANCNFSM4N42EEVA
.

Pipelines now all have basic unit testing which makes sure they output some data


fastlane appending path to lane call

New Issue Checklist

[ ✅] Updated fastlane to the latest version
[✅ ] I have read the Contribution Guidelines

Issue Description
Fastlane is appending the path to the fast lane bin in the call to the fast lane lane, so it cannot find the lane.
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

This is the script the bot will run
cd ${XCS_PRIMARY_REPO_DIR}/App
which fastlane
/Users/xcodeserver/.rvm/gems/ruby*/wrappers/fastlane pretrigger_git --verbose
/Users/xcodeserver/.rvm/gems/ruby*/wrappers/fastlane env`

[16:48:11]: For more information, check out https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
DEBUG [2017-07-28 16:48:14.15]: Checking if there are any plugins that should be loaded...
INFO [2017-07-28 16:48:14.26]: -------------------------------------------------
INFO [2017-07-28 16:48:14.26]: --- Step: Verifying required fastlane version ---
INFO [2017-07-28 16:48:14.26]: -------------------------------------------------
INFO [2017-07-28 16:48:14.26]: Your fastlane version 2.49.0 matches the minimum requirement of 2.46.0  ✅
INFO [2017-07-28 16:48:14.26]: ------------------------------
INFO [2017-07-28 16:48:14.26]: --- Step: default_platform ---
INFO [2017-07-28 16:48:14.26]: ------------------------------
WARN [2017-07-28 16:48:14.26]: Lane Context:
INFO [2017-07-28 16:48:14.26]: {:DEFAULT_PLATFORM=>:ios}
ERROR [2017-07-28 16:48:14.26]: Could not find lane '/Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/wrappers/fastlane pretrigger_git'. Available lanes: ios test, ios beta, ios release, ios release_testflight, ios pretrigger_git, ios test_strings
INFO [2017-07-28 16:48:14.26]: Successfully generated documentation at path '/Users/xcodeserver/Library/Caches/XCSBuilder/Bots/bef1ec531b653f7ba397a46df72f56cd/Source/projectname/projectdirectory/fastlane/README.md'

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
+------+-------------------------------------+-------------+

ERROR [2017-07-28 16:48:14.27]: fastlane finished with errors
/Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/fastlane_core/lib/fastlane_core/ui/interface.rb:131:in `user_error!': [!] Could not find lane '/Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/wrappers/fastlane pretrigger_git'. Available lanes: ios test, ios beta, ios release, ios release_testflight, ios pretrigger_git, ios test_strings (FastlaneCore::Interface::FastlaneError)
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/fastlane_core/lib/fastlane_core/ui/ui.rb:14:in `method_missing'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/fastlane/lib/fastlane/runner.rb:29:in `execute'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/fastlane/lib/fastlane/lane_manager.rb:52:in `cruise_lane'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/fastlane/lib/fastlane/command_line_handler.rb:30:in `handle'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/fastlane/lib/fastlane/commands_generator.rb:104:in `block (2 levels) in run'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0/gems/commander-fastlane-4.4.5/lib/commander/command.rb:178:in `call'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0/gems/commander-fastlane-4.4.5/lib/commander/command.rb:153:in `run'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0/gems/commander-fastlane-4.4.5/lib/commander/runner.rb:476:in `run_active_command'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:64:in `run!'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0/gems/commander-fastlane-4.4.5/lib/commander/delegates.rb:15:in `run!'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/fastlane/lib/fastlane/commands_generator.rb:303:in `run'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/fastlane/lib/fastlane/commands_generator.rb:42:in `start'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/fastlane/lib/fastlane/cli_tools_distributor.rb:66:in `take_off'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/gems/fastlane-2.49.0/bin/fastlane:20:in `<top (required)>'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0/bin/fastlane:23:in `load'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0/bin/fastlane:23:in `<main>'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0/bin/ruby_executable_hooks:15:in `eval'
	from /Users/xcodeserver/.rvm/gems/ruby-2.4.0/bin/ruby_executable_hooks:15:in `<main>'
[16:48:16]: For more information, check out https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[16:48:18]: -------------------------------------------------
[16:48:18]: --- Step: Verifying required fastlane version ---
[16:48:18]: -------------------------------------------------
[16:48:18]: Your fastlane version 2.49.0 matches the minimum requirement of 2.46.0  ✅
[16:48:18]: ------------------------------
[16:48:18]: --- Step: default_platform ---
[16:48:18]: ------------------------------
+------------------+-----+
|      Lane Context      |
+------------------+-----+
| DEFAULT_PLATFORM | ios |
+------------------+-----+
[16:48:18]: Could not find lane '/Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/wrappers/fastlane env'. Available lanes: ios test, ios beta, ios release, ios release_testflight, ios pretrigger_git, ios test_strings

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
+------+-------------------------------------+-------------+

[16:48:18]: fastlane finished with errors

[!] Could not find lane '/Users/xcodeserver/.rvm/gems/ruby-2.4.0@global/wrappers/fastlane env'. Available lanes: ios test, ios beta, ios release, ios release_testflight, ios pretrigger_git, ios test_strings

Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
✅ fastlane environment ✅
Stack

Key
Value

OS
10.12.4

Ruby
2.4.0

Bundler?
false

Git
git version 2.11.0 (Apple Git-81)

Installation Source
~/.rvm/gems/ruby-2.4.0/bin/fastlane

Host
Mac OS X 10.12.4 (16E195)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.4.0/lib

OpenSSL Version
OpenSSL 1.1.0f  25 May 2017

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.3.2

System Locale

Variable
Value

LANG
en_CA.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# Customise this file, documentation can be found here:
# https://github.com/fastlane/fastlane/tree/master/fastlane/docs
# All available actions: https://docs.fastlane.tools/actions
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# If you want to automatically update fastlane if a new version is available:
# update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "2.46.0"

default_platform :ios

platform :ios do
  before_all do
    # ENV["SLACK_URL"] = "https://hooks.slack.com/services/..."
    cocoapods

  end

  desc "Runs all the tests"
  lane :test do
    scan
  end

  desc "Submit a new Beta Build to Apple TestFlight"
  desc "This will also make sure the profile is up to date"
  lane :beta do
    # match(type: "appstore") # more information: https://codesigning.guide
    # Ensure that your git status is not dirty
    ensure_git_status_clean

    # Increment the build number (not the version number)
    # Providing the xcodeproj is optional
    increment_build_number()

    # Commit the version bump
    commit_version_bump(xcodeproj: "App.xcodeproj")

    # Add a git tag for this build. This will automatically
    # use an appropriate git tag name
    add_git_tag

    # Push the new commit and tag back to your git remote
    push_to_git_remote

    cert
    sigh
    gym(scheme: "CodeDrop")#Build your app - more options available
    pilot
    # sh "your_script.sh"
    # You can also use other beta testing services here (run `fastlane actions`)
  end

  desc "Deploy a new version to the App Store"
  lane :release do
    # match(type: "appstore")
    # snapshot
    gym(scheme: "Scheme") # Build your app - more options available
    deliver(force: true)
    # frameit
  end

  desc "Deploy a testflight release for App"
  lane :release_testflight do
    cert
    sigh
    pilot(ipa: ENV['XCS_PRODUCT'])
  end

  desc "Increment the build and version numbers as a pre-trigger lane so that the .ipa is of the right version and build number on testflight"
  lane :pretrigger_git do
    # match(type: "appstore") # more information: https://codesigning.guide
    # Ensure that your git status is not dirty
    ensure_git_status_clean
    # Increment the build number (not the version number)
    # Providing the xcodeproj is optional
    increment_version_number( bump_type:'patch')
    increment_build_number()
    # Commit the version bump
    commit_version_bump(xcodeproj: "App.xcodeproj")
    # Add a git tag for this build. This will automatically
    # use an appropriate git tag name
    varBuild=Actions.lane_context[Actions::SharedValues::BUILD_NUMBER]
    varVersion=Actions.lane_context[Actions::SharedValues::VERSION_NUMBER]
    varTag="CI_TestFlightBuild_#{varBuild}_v#{varVersion}"
    puts "#{varTag}"
    add_git_tag(
    tag: varTag
    )
    # Push the new commit and tag back to your git remote
    push_to_git_remote
  end

  lane :test_strings do
    varBuild=1
    varVersion=2
    varTag="CI_TestFlight_v#{varVersion}_Build:#{varBuild}"
    puts "#{varTag}"
  end

  # You can define as many lanes as you want

  after_all do |lane|
    # This block is called, only if the executed lane was successful

    # slack(
    #   message: "Successfully deployed new App Update."
    # )
  end

  error do |lane, exception|
    # slack(
    #   message: exception.message,
    #   success: false
    # )
  end
end

# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md
# All available actions: https://docs.fastlane.tools/actions

# fastlane reports which actions are used. No personal data is recorded.
# Learn more at https://github.com/fastlane/fastlane#metrics

`./fastlane/Appfile`
app_identifier "" # The bundle identifier of your app
apple_id "" # Your Apple email address

team_id "" # Developer Portal Team ID

# you can even provide different app identifiers, Apple IDs and team names per lane:
# More information: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Appfile.md

fastlane gems

Gem
Version
Update-Status

fastlane
2.49.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.1.0

executable-hooks
1.3.2

bundler-unload
1.0.2

rubygems-bundler
1.4.4

bundler
1.15.3

io-console
0.4.6

slack-notifier
1.5.1

rouge
2.0.7

xcpretty
0.2.8

terminal-notifier
1.8.0

unicode-display_width
1.3.0

terminal-table
1.8.0

plist
3.3.0

CFPropertyList
2.3.5

public_suffix
2.0.5

addressable
2.5.1

multipart-post
2.0.0

word_wrap
1.0.0

tty-screen
0.5.0

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.5

excon
0.57.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20170404

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.0

gh_inspector
1.0.3

uber
0.1.0

declarative
0.0.9

declarative-option
0.1.0

representable
3.0.4

mime-types-data
3.2016.0521

mime-types
3.1

httpclient
2.8.3

google-api-client
0.12.0

json
2.0.2

mini_magick
4.5.1

multi_json
1.12.1

multi_xml
0.6.0

rubyzip
1.2.1

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.2.1

openssl
2.0.2

faraday
0.12.2

little-plugger
1.1.4

logging
2.2.2

jwt
1.5.6

memoist
0.16.0

os
0.9.6

signet
0.7.3

googleauth
0.5.3

faraday_middleware
0.12.0

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.3

xcodeproj
1.5.1

generated on: 2017-07-28

According to the error, your lanes are scoped for platforms.   But also it looks like something could be going a little wonky with that script that you have thats running fastlane. If you run the lane from your command line directly, do you see the same issue? 🐙

@PetrosIchor Thank you for the reply, adding using fast lane ios pre trigger_git resulted in fast lane calming there was no lane called 'ios'.
@ohayon You are exactly right, turns out that '/Users/xcodeserver/.rvm/gems/ruby*/wrappers/fastlane pretrigger_git --verbose' was calling on the global system ruby through rvm and for whatever reason the /wrappers/ hook was not reading the command line arguments...as arguments?
Solved the issue by simply specifying the ruby version like so '/Users/xcodeserver/.rvm/gems/ruby-2.4.0/wrappers/fastlane pretrigger_git --verbose'
Thank you everyone for all your help!