MessageType filtering

I'm implementing SlimMessageBus with EventHubs and am targeting a single EventHubs instance (topic) for all messages.   Using pub/sub so my registrations more or less look something like:
MessageBusBuilder.Create()
    .Consume<FooBar>(config => config
        .Topic(configuration["SharedTopic"])
        .Group(configuration["ServiceConsumerGroup"])
        .WithConsumer<FooBarConsumer>())

I'm noticing that each of my consumer groups picks up messages for all message types...ie. the message processing does not filter on message type.  Since the messages are not filtered by type, I'm wondering if your intention was each message would get its own topic.

Hello @apitzele , the consumer side takes the declared type and tries to deserialize arriving messages into that type.
No filtering is implemented nor was intended as SMB is simple in nature.
Such filtering would have to be done in the app's consumer (FooBarConsumer where it decides what msgs to skip) or on the infrastructure (Azure Event Hubs don't support that as far as I know, but Azure SB does support filtering). The former would make sense if you have polymorphic message types (see my comment further down).
Furthermore, the message type you publish is expected to be deserializable into the type you declare that you consume.
If you have some base message type and messages that inherit from that you could send any message in that same class hierarchy on that same hub (topic) - in the case of JSON serialization the message type would be added to the message, so that the consumer knows what C# type to deserialize to (more here). Othwerwise, if you don't have a message type hierarchy or the chosen serializer does not support polymorphic types then you should use one hub (topic) per message type (otherwise message type A is sent but consumer expects message type B).
I hope this helps.

@zarusz, thanks for the explanation.  I think I'd like to avoid leaving the responsibility for verifying message types to the consumers.  Since the consumer is already bound to a type, it seems redundant to require each one to verify the message after it's been deserialized.  Also, for better or worse, our entities that get put onto the message bus happen to be our DTOs so I'd like to avoid hanging any additional properties off of them.
For now, I have a private fork that passes the type as a header so the PartitionConsumer can short circuit the deserialization of both the byte array and json string.  Obviously, I'd prefer to avoid maintaining a distinct repo.  Since it feels like you are wanting to keep this library lean, I'm going to bet adding a message filtering abstraction to the EventHubs plugin is not something you'd like to bring into the project.  Completely understand if that's not the direction you want to go.  If does sound like a fit, I'd consider contributing.  Either way, I really appreciate what you've done with this library.  It's been a pleasure working w/ it.

On a related note, I have plans pas the message type as part of the message headers (for transports that support message headers). This is to not have to rely on the particular serializer implementation, but mostly to satisfy the need to "not pollute" the message payload (there are pros and cons witch each approach).
Now, after is added, then having filtering (and even further routing to handler based on specific type) could be added to the master. One thing that I worry is that this might overcomplicate the configuration and that it would be confusing for users.
What do you think?
How do you configure that in your fork?

I didn't need to consider configuration since I'm the only 'customer'.   That made it pretty easy.
I was thinking along the lines of a filter that could be configured per consumer or even globally.
Once you update the library include the messagetype it seems like a viable solution but admittedly I've only dug in superficially.  I haven't spent much time w/ the other transports so I'm not seeing the complete picture.
class IMessageFilter
{
  bool CanProcess(ConsumerSettings settings, MessageWithHeaders message);
}

MessageBusBuilder.Create()
    .Consume<FooBar>(config => config
        .Topic(configuration["SharedTopic"])
        .Group(configuration["ServiceConsumerGroup"])
        .WithMessageFilter<MessageTypeFilter>()
// or
        .WithMessageFilter((settings, message) => true)

        .WithConsumer<FooBarConsumer>())

If generically exposing MessageWithHeaders is problematic, a simpler approach would be transport specific extensions
Something like:
 .WithEventHubsMessageFilter((settings, eventData) => true)  //where we're working directly against the payload instead of its abstraction

I like the generic solution better but not sure if it's as viable.  Thoughts?

I created an issue to add message type in the native message headers for supported transports. Beside the filtering scenario I have some other use cases for that. Feel free to comment on the ideas over there.
That issue is a prerequisite to allow to implement filtering. I am still thinking if just keep the filtering so simple that it would just rely on the consumer type definition Consume<TMessage> or wheather to also give the additional filtering customization as with your .WithMessageFilter(Func<ConsumerSettings, TMessage>) example. Potentially it will end up being both...

With the recent change #130, it should be possible to push multiple message types via one event hub. See the docs.


Expand nms4r vignettes

See #61

Show sequence of how content gets rendered, differentiating between fetching of new data (ie SST) vs rendering Rmd's.

Audience:

Who's gonna look at this?
Technical people familiar with R who may want to implement or improve upon the place-based webenized reports (NMS, IEA, ...)

Existing Vignettes:

Introduction • nms4r
HTML Rendering • nms4r

Perhaps expand on vignettes similar to breakdown here:

Function reference • nms4r

Data: Fisheries (CalCOFI)
Data: Oceanography (ERDDAP)
Data: Rocky intertidal (MARINe)
Reporting functions
Sanctuaries utilities

And then highlight how we populate static and dynamic content with captions, so possibly pulling from:

info-demo

Diagrams of what?

Perhaps something simple with bullets describing sequence of updates from oceanography data, knitting of Rmds to html

We need a bigger picture Vignette to orient the technical audience around the necessary files (html, svg, csv) to construct an interactive infographic website, and where these files should be located and reference each other.
See README.md in https://github.com/marinebon/info-demo.
> # brew install tree
> cd ~/github/info-demo
> tree -L 2
.
├── README.md
├── _site.yml
├── about.Rmd
├── docs
│   ├── README.html
│   ├── about.html
│   ├── index.html
│   ├── libs
│   ├── modals
│   ├── site_libs
│   └── svg
├── index.Rmd
├── info-demo.Rproj
├── libs
│   ├── bootstrap-toggle.min.css
│   ├── bootstrap-toggle.min.js
│   ├── d3.v5.min.js
│   ├── infographiq.js
│   └── styles.css
├── modals
│   ├── test-video.Rmd
│   └── test-video.html
└── svg
    ├── cinms_pelagic.svg
    └── svg_links.csv

Hey @bbest & @mspector13 - I took a first pass at a bunch of the vignettes, which you can find in the nms4r package here. I created vignettes for each of the function groups listed on the Reference page. It is a pretty crude first pass, so there is a lot of room for improvement. But I figured that something was better than nothing - editing is easier than writing from scratch, I find. I think the vignette for "Sanctuary Utilities" (which currently is just a placeholder) should be dumped, as there is only one function in this function group (meaning I don't what there is to say further than what is in the individual function description).
I also created an overview vignette, which is currently a placeholder. I'll get a bad first pass down on the overview later on today.

Hey @bbest - I had a thought. Given the complexity of creating a new site from scratch, I thought it might be good if nms4r could itself create a new template site. I created a new function to do that - initial_build() - which creates a template site in a path selected by the user. The function just copies over the contents of the template directory that is sitting in the R package (in the inst folder).
I created this template as a very simple version of a new site. I think it would work well to walk through this template site in a vignette.
The only trouble is that this template site doesn't quite work. The issue is that, in the rendered html, the clickable infographic images don't display in a browser (though they do show up fine if the html is viewed within R studio). Additionally, the rendered html files are huge.
Anyway, what do you think?

Looks good @superjai. Reminds me of devtools::create("dir/here"):
> devtools::create("testpkg")
New project 'testpkg' is nested inside an existing project './', which is rarely a good idea.
If this is unexpected, the here package has a function, `here::dr_here()` that reveals why './' is regarded as a project.

License: `use_mit_license()`, `use_gpl3_license()` or friends to
    pick a license
Encoding: UTF-8
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.1.1
✓ Writing 'NAMESPACE'
✓ Writing 'nms4r.Rproj'
✓ Adding '.Rproj.user' to '.gitignore'
✓ Adding '^nms4r\\.Rproj$', '^\\.Rproj\\.user$' to '.Rbuildignore'
✓ Opening '/Users/bbest/github/nms4r/testpkg/' in new RStudio session
✓ Setting active project to '<no active project>'

TODO:

Home for JS will pull from infographiq (which is to be consolidated from info-demo).
Rewrite vignettes (but TBD which most appropriate package)

Expand for reuse in different environments:

Rmarkdown website

cinms

HTML: R-independent website.  demo with vignette

fk-esr-info (see README.md): Seann Regan made website, self-contained HTML; just augmenting with an interactive infographic

Use Google Sheets to update the data directly from publicly viewable CSV: one spot updates within page Highcharts plots and additionally modal windows

Drupal module (ie for content management system): integratedecosystemassessment.noaa.gov

[info-demo:drupal-module(https://github.com/marinebon/info-demo/tree/master/drupal-module)

TODO:

Home for JS will pull from infographiq (which is to be consolidated from info-demo).
Rewrite vignettes (but TBD which most appropriate package)

Expand for reuse in different environments:

Rmarkdown website

cinms

HTML: R-independent website.  demo with vignette

fk-esr-info (see README.md): Seann Regan made website, self-contained HTML; just augmenting with an interactive infographic

Use Google Sheets to update the data directly from publicly viewable CSV: one spot updates within page Highcharts plots and additionally modal windows

Drupal module (ie for content management system): integratedecosystemassessment.noaa.gov

[info-demo:drupal-module(https://github.com/marinebon/info-demo/tree/master/drupal-module)

Hey @bbest & @mspector13 - I have gone ahead and greatly updated the vignette for documenting how to create a new nms4r site. What do you think? Feel free to edit as you wish. It is in the nms4r package so you should do a pull on that. Here is the direct link to the specific vignette. The file to edit is Overview.Rmd in the vignettes folder.

Looking good Jai! Thanks so much. Next, we’ll want to move this to
https://github.com/marinebon/infographiq
On Fri, Feb 5, 2021 at 4:13 PM Jai Ranganathan<EMAIL_ADDRESS>wrote:

Hey @bbest https://github.com/bbest & @mspector13
https://github.com/mspector13 - I have gone ahead and greatly updated
the vignette for documenting how to create a new nms4r site. What do you
think? Feel free to edit as you wish. It is in the nms4r package so you
should do a pull on that. Here is the direct link to the specific vignette
https://marinebon.org/nms4r/articles/Overview.html. The file to edit is
Overview.Rmd in the vignettes folder.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/marinebon/cinms/issues/69#issuecomment-774355170, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVUWCLXQSPCIUWQKZYJFA3S5SCQZANCNFSM4UN2HCHQ
.

--
Ben Best, PhD
Environmental Data Scientist
EcoQuants.com http://ecoquants.com/
calendar: LA (PDT)
<EMAIL_ADDRESS>, NY (EDT)
<EMAIL_ADDRESS>+1.805.705.9770 <(805)%20705-9770>

Hey @bbest. Sounds good. Let's chat about it though during our next meetup - I am not exactly sure where infographiq ends and nms4r begins.


Vulture doesn't disappear

https://discord.com/channels/463917049782075395/559837167430664203/1046184389001887867

Thanksgiving report

Only happens if Vulture is deloaded during the Try Again prompt


[Automated] Merge main into stara-krc

Automated Pull Request from 'main' into deployment branch

old PR


Pluto widget like option

We use your library to monitor the status of requests and responses in our application. But we faced one problem - Pluto's widget leads to conflicts with automation tests of the application on the BrowserStack. It would be nice to add an option that will programmatically disable the use of the widget and Over Other App request, depending on the needs of the developers, leaving access only through the notification panel (as is done in some libraries). Perhaps by using the builder when initializing Pluto, something like -
Pluto.Builder().overOtherAppsOption(false).build().initialize(this)
Sincerely. Yaroslav.
Describe the solution you'd like
using the builder when initializing Pluto ->
Pluto.Builder().overOtherAppsOption(false).build().initialize(context: this)
fun overOtherAppsOption(isEnabled: Boolean = true)
{
if (isEnabled) allowOverOtherAppOption()
}

hey @Yaroslav-Syrota-Tictrac,
is disabling the widget option from Settings, not working for you?

@srtvprateek will check. I'll let you know. Thanks a lot for your help and improvements!!!

@Yaroslav-Syrota-Tictrac we now support opening Pluto UI programmatically without draw over other apps permission.
from version 1.1.3 onwards, you can call Pluto.showUi() to open Pluto UI directly

@srtvprateek it's working for us, thanks a lot!!!!


Add cache for GetCharABCWidthsW in TextDrawer

GetCharABCWidthsW can account for about 45% for the time spent in gdi32.dll when minimap is active (or many lines are on screen). A way to alleviate that is to cache the values for the ASCII range.
Here is ported version for BCEditor of the GetCachedABCWidth I made for SynEdit a while ago:
https://bitbucket.org/egrange/tbceditorxe/commits/8cb0ac1c7cdd386dd2d42aeda4a5602839d50322
It could eventually be further optimized by maintaining the cache for all styles of the font, but the above is enough to almost double the framerate.

Nice, thanks. :)


Dead link

The link in this document, https://wg14.link/n2148#dr_400, is dead as a dodo.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6183aaac-1eb4-f704-4bf5-1c3fe67ae2fe
Version Independent ID: d3f24754-fcba-3eee-e34d-445962c5485c
Content: /std (Specify Language Standard Version)
Content Source: docs/build/reference/std-specify-language-standard-version.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @TylerMSFT
Microsoft Alias: twhitney

I have fixed the link. The fix will be live 6/21 afternoon or so.  The Raphus cucullatus lives again ;-)


[C++][Parquet] Sync merge script changes from Arrow

Apache Arrow has the same script but with Python 3, we should sync the changes.
Reporter: Uwe Korn / @xhochy
Assignee: Uwe Korn](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=uwe) / @xhochy
Note: This issue was originally created as PARQUET-916. Please see the migration documentation for further details.

Wes McKinney / @wesm:
Fixed by monorepo merge


chore: use container-storage as src container transport for skopeo-push-package make target

Fix broken CI builds.
What type of PR is this?
cleanup
What this PR does / why we need it?
Which Jira/Github issue(s) this PR fixes?
Fixes #
Broken CI builds
Special notes for your reviewer:
Pre-checks (if applicable):

[ ] Tested latest changes against a cluster
[ ] Ran make go-test command locally to run all the unit tests and mock tests locally.
[ ] Included documentation changes with PR

lgtm

/test operator-e2e

/lgtm


doc update: board file location

On this page:
https://pynq.readthedocs.io/en/v2.5/overlay_design_methodology/board_settings.html
it says to place new board files in
<Xilinx installation directory>\Vivado\<version>\data\boards
But in Vivado 2019.2 at least, the board files should go in
<Xilinx installation directory>\Vivado\<version>\data\boards\board_files

In 2019.1 as well, the doc is generated from this *.rst file: https://github.com/Xilinx/PYNQ/blob/master/docs/source/overlay_design_methodology/board_settings.rst


changed single expression plugin upload to validate responses

Instead of individual calls '&&' together, the deploy now checks each response for a valid result.
This  fixes problems on Ubuntu 16.04 when mysteriously, the  &&  && ok || failed never works.

@scottleedavis, can you give some context into the original issue? I'd like to reproduce it to try to better understand the fix here.

Sure @lieut-data.
I noticed my ThinkPad/Ubuntu16.04 laptop never seemed to upload plugins via 'make deploy' with the mattermost-preview docker image, and I assumed I had something setup incorrectly.  Later at some point, I setup the server and webapp locally and the same issue happened...  That of an apparent passed upload from the Makefile, but no logs or uploaded plugin resultant.
I mentioned this to ~extentions and @hanzei encouraged me to dig a bit deeper.  During which I found that by separating  the api calls in the Makefile, I was then able to see 100% success in uploads.
I have never had this problem previously on OSX.

Agree with @levb: I think we need to suss out the root issue here. @scottleedavis, can you share the output from make deploy when this fails?

Here is the failed output of make deploy which produces no visible error in output.
plugin built at: dist/com.mattermost.sample-plugin-0.1.0.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100    45    0     0  100    45      0  55900 --:--:-- --:--:-- --:--:-- 45000
Installing plugin via API
OK.

I used mitmproxy to capture the HTTP failure results
>> POST http://localhost:8065//api/v4/users/login
        ← 301 [no content] 27ms
   POST http://localhost:8065//api/v4/plugins
        ← [Errno 32] Broken pipe
   POST http://localhost:8065//api/v4/plugins/com.mattermost.sample-plugin/enable
        ← 301 [no content] 53ms

As can be seen by looking at the proxy calls, the double slash '//', is breaking the request by curl, and when I reviewed the ENV variable MM_SERVICESETTINGS_SITEURL=http://localhost:8065/  it had the trailing slash.
By removing the trailing '/' in the variable, all plugins deploy as expected.
This was my own error in not recognizing that I likely updated the environment variable manually while developing and testing for this PR.

@lieut-data that appears to solve the issue.  It does however break the mitmproxy, which isn't a problem imho.

Sounds good -- should we revert to the original invocation as such for now then (plus the new flags)?

I feel we should and went ahead and pushed a commit.  However, if @levb or @hanzei feel we should use the updated approach of checking responses I am also open to that.

@levb, I'm going to go ahead and merge this since we sussed out the root issue here as per your original feedback.


I'm having an error while I think I'm using the latest version of a package(unpinned).

I keep getting the error Error running timer ‘lsp--on-idle’: (invalid-function treemacs-get-icon-value) [18 times] while using lsp-mode, I'm running the unpinned package since this was solved just a few days ago, every single startup I look for the library, load the lsp-mode.el and eval buffer so that I can use the breadcrumb headerbar from lsp-mode. What should I do? I even tried using the makefile which comes within the repo to build the whole project with cask, I don't understand. It's like the older compiled version is still running while I even did sync upgrade and build, nothing worked. I don't want to keep evaluating that buffer every single startup.

where's the discord help channel btw?

The discord server: https://discord.gg/qvGgnVx
There's a link in the README, and should've been one in the issue template.
There isn't enough information in this report for me to guess the issue. Could you include your M-x doom/info? Or the output of ~/.emacs.d/bin/doom info? Please do not ignore the issue template in the future.

((emacs
  (version . "27.0.91")
  (features . "XPM JPEG TIFF GIF PNG SOUND GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS FREETYPE HARFBUZZ XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 XDBE XIM MODULES THREADS PDUMPER GMP")
  (build . "Jun 23, 2020")
  (buildopts "")
  (windowsys . batch)
  (daemonp . server-running))
 (doom
  (version . "2.0.9")
  (build . "HEAD -> develop, origin/develop, origin/HEAD 99eea1d3e 2020-06-21 13:53:58 -0400")
  (dir . "~/.doom.d/"))
 (system
  (type . gnu/linux)
  (config . "x86_64-pc-linux-gnu")
  (shell . "/usr/bin/zsh")
  (uname . "Linux 4.4.0-18362-Microsoft #836-Microsoft Mon May 05 16:04:00 PST 2020 x86_64")
  (path "~/.cask/bin" "~/gitrep/emacs/src/" "~/doom-emacs/bin" "~/.nvm/versions/node/v12.16.3/bin" "~/.local/bin" "/usr/local/sbin" "/usr/local/bin" "/usr/sbin" "/usr/bin" "/sbin" "/bin" "/usr/games" "/usr/local/games" "/mnt/c/Python38/Scripts/" "/mnt/c/Python38/" "/mnt/c/Program Files (x86)/Common Files/Oracle/Java/javapath" "/mnt/c/WINDOWS/system32" "/mnt/c/WINDOWS" "/mnt/c/WINDOWS/System32/Wbem" "/mnt/c/WINDOWS/System32/WindowsPowerShell/v1.0/" "/mnt/c/WINDOWS/System32/OpenSSH/" "/mnt/c/Program Files/Git/cmd" "/mnt/c/Program Files/Microsoft VS Code/bin" "/mnt/c/Program Files/nodejs/" "/mnt/c/ProgramData/chocolatey/bin" "/mnt/c/Ruby26-x64/bin" "/mnt/c/Program Files/MySQL/MySQL Shell 8.0/bin/")
 (config
  (envfile . envvar-file)
  (elc-files . 0)
 (modules :input chinese :checkers syntax :completion company (ivy +icons) :ui doom doom-dashboard hl-todo indent-guides modeline nav-flash ophints (popup +all +defaults) treemacs vc-gutter vi-tilde-fringe window-select workspaces :editor (evil +everywhere) file-templates fold multiple-cursors rotate-text snippets :emacs (dired +ranger +icons) electric :term eshell vterm :tools debugger (eval +overlay) lookup (lsp +peek) pdf :lang data emacs-lisp (go +lsp) (javascript +lsp) (markdown +grip) (org +dragndrop +pandoc +present) (python +lsp) (sh +lsp) web :config (default +bindings +smartparens))
  (packages (dap-mode) (flycheck-package) (hover) (eldoc-box) (company-box) (lsp-mode) (lsp-ui) (lsp-treemacs) (scss-mode) (treemacs) (paredit) (parrot :recipe (:host github :repo "jnc-nj/parrot" :branch "master")) (posframe) (modus-operandi-theme) (modus-vivendi-theme))
  (unpin treemacs lsp-treemacs lsp-mode lsp-ui dap-mode)
  (elpa "n/a")))

This is the output of doom info, I erased the line explicitly setting lsp-mode to the .local/straight/repos path and it stopped working again after I did a clean sync update.
Sorry, I saw the discord server but I had an issue with my browser(just a minimalist one to read documentation) not displaying the reaction icons to get to the other channels.

And this is the backtrace for the error
Debugger entered--Lisp error: (invalid-function treemacs-get-icon-value)
  treemacs-get-icon-value(method)
  lsp--headerline-breadcrumb-symbol-icon(#<hash-table equal 3/65 0x1ffff65faf11>)
  #f(compiled-function (last-symbol-name symbol-to-append) #<bytecode 0x1ffff677249d>)("" #<hash-table equal 3/65 0x1ffff65faf11>)
  #f(compiled-function (elt) #<bytecode 0x1ffff6112639>)(#<hash-table equal 3/65 0x1ffff65faf11>)
  mapc(#f(compiled-function (elt) #<bytecode 0x1ffff6112639>) (#<hash-table equal 3/65 0x1ffff65faf11>))
  seq-do(#f(compiled-function (elt) #<bytecode 0x1ffff6112639>) (#<hash-table equal 3/65 0x1ffff65faf11>))
  seq-reduce(#f(compiled-function (last-symbol-name symbol-to-append) #<bytecode 0x1ffff677249d>) (#<hash-table equal 3/65 0x1ffff65faf11>) "")
  lsp--headerline-build-string((#<hash-table equal 3/65 0x1ffff65faf11>))
  lsp--headerline-check-breadcrumb()
  run-hooks(lsp-on-idle-hook)
  lsp--on-idle(#<buffer phicorrel.js>)
  apply(lsp--on-idle #<buffer phicorrel.js>)
  timer-event-handler([t 0 0 500000 nil lsp--on-idle (#<buffer phicorrel.js>) idle 0])

Appears LSP is the issue, and you're on a 4 day old version of Doom. LSP was bumped yesterday, which should fix this issue. Run doom upgrade and see if the issue persists.

Yes, the issue still persiste after doing the upgrade, what's happening exactly? I'm just afraid this may be happening to other unpinned packages too 😞

This is my packages.el
(package! dap-mode)
;; (package! flutter)
(package! flycheck-package)
(package! hover)
(package! eldoc-box)
(package! company-box)
;; (package! lsp-dart :recipe (:local-repo "~/dev/lsp-dart" :files ("*.el") :no-byte-compile t))
(package! lsp-mode)
(package! lsp-ui)
(package! lsp-treemacs)
(package! scss-mode)
(package! treemacs)
;; (package! treemacs :recipe (:local-repo "~/dev/treemacs" :files (:defaults "Changelog.org" "icons" "src/elisp/treemacs*.el" "src/scripts/treemacs*.py" (:exclude "src/extra/*")) :no-byte-compile t))
(package! paredit)
(package! parrot :recipe (:host github :repo "jnc-nj/parrot" :branch "master"))
(package! posframe)
(package! modus-operandi-theme)
(package! modus-vivendi-theme)

(unpin! treemacs)
(unpin! lsp-treemacs)
(unpin! lsp-mode)
(unpin! lsp-ui)
(unpin! dap-mode)
;(package! lsp-mode :recipe(:local-repo "~/doom-emacs/.local/straight/repos/lsp-mode/" :files ("*.el") :no-byte-compile t))

And this is my init.el
(doom! :input
       chinese
       ;;japanese

       :checkers
       syntax            ; tasing you for every semicolon you forget

       :completion
       (company)           ; the ultimate code completion backend
       ;;helm              ; the *other* search engine for love and life
       ;;ido               ; the other *other* search engine...
       (ivy +icons) ; a search engine for love and life

       :ui
       ;;deft              ; notational velocity for Emacs
       doom              ; what makes DOOM look the way it does
       doom-dashboard    ; a nifty splash screen for Emacs
       ;;doom-quit         ; DOOM quit-message prompts when you quit Emacs
       ;;fill-column       ; a `fill-column' indicator
       hl-todo           ; highlight TODO/FIXME/NOTE tags
       indent-guides     ; highlighted indent columns
       (modeline)          ; snazzy, Atom-inspired modeline, plus API
       nav-flash         ; blink the current line after jumping
       ;;neotree           ; a project drawer, like NERDTree for vim
       ophints           ; highlight the region an operation acts on
       (popup            ; tame sudden yet inevitable temporary windows
        +all             ; catch all popups that start with an asterix
        +defaults)       ; default popup rules
       ;;pretty-code       ; replace bits of code with pretty symbols
       ;; tabs
       treemacs          ; a project drawer, like neotree but cooler
       ;;unicode           ; extended unicode support for various languages
       vc-gutter         ; vcs diff in the fringe
       vi-tilde-fringe   ; fringe tildes to mark beyond EOB
       window-select     ; visually switch windows
       workspaces        ; tab emulation, persistence & separate workspaces

       :editor
       (evil +everywhere); come to the dark side, we have cookies
       file-templates    ; auto-snippets for empty files
       fold              ; (nigh) universal code folding
       ;(format +onsave)  ; automated prettiness
       ;;lispy             ; vim for lisp, for people who dont like vim
       multiple-cursors  ; editing in many places at once
       ;;objed             ; text object editing for the innocent
       ;;parinfer          ; turn lisp into python, sort of
       rotate-text       ; cycle region at point between text candidates
       snippets          ; my elves. They type so I don't have to

       :emacs
       (dired +ranger +icons)
       electric          ; smarter, keyword-based electric-indent
       ;;vc                ; version-control and Emacs, sitting in a tree

       :term
       eshell            ; a consistent, cross-platform shell (WIP)
       ;;term              ; terminals in Emacs
       vterm             ; another terminals in Emacs

       :tools
       ;;ansible
       debugger     ; FIXME stepping through code, to help you add bugs
       ;;direnv
       ;; (docker +lsp)
       ;;editorconfig      ; let someone else argue about tabs vs spaces
       ;;ein               ; tame Jupyter notebooks with emacs
       (eval +overlay)              ; run code, run (also, repls)

       ;;flyspell          ; tasing you for misspelling mispelling
       ;;gist              ; interacting with github gists
       lookup        ; ...or in Dash docsets locally
       (lsp +peek)
       ;;macos             ; MacOS-specific commands
       ;;magit             ; a git porcelain for Emacs
       ;;make              ; run make tasks from Emacs
       ;;pass              ; password manager for nerds
       pdf               ; pdf enhancements
       ;;prodigy           ; FIXME managing external services & code builders
       ;;rgb               ; creating color strings
       ;;terraform         ; infrastructure as code
       ;;tmux              ; an API for interacting with tmux
       ;;upload            ; map local to remote projects via ssh/ftp
       ;;wakatime

       :lang
       ;;agda              ; types of types of types of types...
       ;;assembly          ; assembly for fun or debugging
       ;;cc                ; C/C++/Obj-C madness
       ;; (clojure +lsp)           ; java with a lisp
       ;;common-lisp       ; if you've seen one lisp, you've seen them all
       ;;coq               ; proofs-as-programs
       ;;crystal           ; ruby at the speed of c
       ;;csharp            ; unity, .NET, and mono shenanigans
       ;; (dart +lsp)
       data              ; config/data formats
       ;;erlang            ; an elegant language for a more civilized age
       ;;elixir            ; erlang done right
       ;;elm               ; care for a cup of TEA?
       emacs-lisp        ; drown in parentheses
       ;;ess               ; emacs speaks statistics
       ;;fsharp           ; ML stands for Microsoft's Language
       (go +lsp)                ; the hipster dialect
       ;;(haskell +intero) ; a language that's lazier than I am
       ;;hy                ; readability of scheme w/ speed of python
       ;;idris             ;
       ;; (java +lsp) ; the poster child for carpal tunnel syndrome
       (javascript +lsp)        ; all(hope(abandon(ye(who(enter(here))))))
       ;;julia             ; a better, faster MATLAB
       ;;kotlin            ; a better, slicker Java(Script)
       ;;latex             ; writing papers in Emacs has never been so fun
       ;;ledger            ; an accounting system in Emacs
       ;;lua               ; one-based indices? one-based indices
       (markdown +grip)          ; writing docs for people to ignore
       ;;nim               ; python + lisp at the speed of c
       ;; nix               ; I hereby declare "nix geht mehr!"
       ;;ocaml             ; an objective camel
       (org              ; organize your plain life in plain text
        +dragndrop       ; file drag & drop support
        +pandoc          ; pandoc integration into org's exporter
        +present)        ; using Emacs for presentations
       ;;perl              ; write code no one else can comprehend
       ;;php               ; perl's insecure younger brother
       ;;plantuml          ; diagrams for confusing people more
       ;;purescript        ; javascript, but functional
       (python +lsp)            ; beautiful is better than ugly
       ;;qt                ; the 'cutest' gui framework ever
       ;;racket            ; a DSL for DSLs
       ;;rest              ; Emacs as a REST client
       ;; (ruby +lsp)              ; 1.step {|i| p "Ruby is #{i.even? ? 'love' : 'life'}"}
       ;;rust              ; Fe2O3.unwrap().unwrap().unwrap().unwrap()
       ;;scala             ; java, but good
       (sh +lsp)                ; she sells {ba,z,fi}sh shells on the C xor
       ;;solidity          ; do you need a blockchain? No.
       ;;swift             ; who asked for emoji variables?
       ;;terra             ; Earth and Moon in alignment for performance.
       web               ; the tubes
       ;;vala              ; GObjective-C

       :email
       ;;(mu4e +gmail)       ; WIP
       ;;notmuch             ; WIP
       ;;(wanderlust +gmail) ; WIP

       ;; Applications are complex and opinionated modules that transform Emacs
       ;; toward a specific purpose. They may have additional dependencies and
       ;; should be loaded late.
       :app
       ;;calendar
       ;;irc              ; how neckbeards socialize
       ;;(rss +org)        ; emacs as an RSS reader
       ;;twitter           ; twitter client https://twitter.com/vnought
       ;;(write            ; emacs as a word processor (latex + org + markdown)
       ;; +wordnut         ; wordnet (wn) search
       ;; +langtool)       ; a proofreader (grammar/style check) for Emacs

       :config
       ;; For literate config users. This will tangle+compile a config.org
       ;; literate config in your `doom-private-dir' whenever it changes.
       ;;literate

       ;; The default module sets reasonable defaults for Emacs. It also
       ;; provides a Spacemacs-inspired keybinding scheme and a smartparens
       ;; config. Use it as a reference for your own modules.
       (default +bindings +smartparens))

Does it work if you don't unpin treemacs, lsp-treemacs, lsp-mode, lsp-ui and dap-mode?

For some reason it is still not loading even after rolling back and doing sync -u. Still don't understand whats the issue since the commit which is currently on lsp-mode still has the fix for this issue, it's like it is not loading the repo from .local but something else.

Is this still an issue?


Guidance is very oriented around "roll your own" which is the first don't rule of security

We are dealing with an important security domain here and most of content presented, with the objective of explaining the underlying mechanisms, fell short of ensuring a secure end state as the readers are left with the burden of the implementation.
Each parameter of one implementation can go wrong and that is why libraries and packaged solutions exist so that you don't have to roll your own... and fail.
This guide needs more references outside of OWASP and more references on certified components offloading the risk of misconfiguration for the readers.

The point above is true. However, that doesn't make packaged solutions the right response. The guides provide,as it stands, a very concise and to the point explanation of good practices when implementing these things.
As I see it, it would be a disservice to the goal of the guides to refer to pre-packaged solutions and abstract away the learning that it is trying to provide.

The book is intended for people who want to implement auth from scratch or just curious of how it works. There are already enough resources on using pre-existing solutions. The book is not for people who "just" want something that works out of the box.

Still, you don't reimplement cryptography.... you use and reference libs.


BUG: integrate: builtin name no longer shadowed

This slipped through the cracks in #5334, which is troubling. I did a quick check to make sure that no other bugs were introduced by those changes, and it seems okay now.

Thanks, LGTM


[react-packager] Fix absolute path detection in DependencyGraph

Sorry for the delay @aleclarson, was out for a while. Thanks for pointing this out.

No problem, @amasad! Glad I could help! :+1:


Make Tracer extends Closeable.

Prior to 0.32, I decided to take a shot at this feature (as part of https://github.com/opentracing/specification/issues/130) - the change itself is actually minimal, and I'm guessing that this could be an easy-to-implement item for Tracer maintainers, but would definitely love some feedback.
Depending on how good or bad the changes are deemed, we might include this in the 0.32 Final Release ;)
PS - Was tempted to leave MockTracer.close() as no-op, but preferred to keep the invariant.
@yurishkuro @tylerbenson @austinlparker  @opentracing/opentracing-java-maintainers

Coverage increased (+0.2%) to 77.301% when pulling bc09a25147961fc082662dcf2409b675980a9b60 on carlosalberto:tracer-closeable into 748a229c0c051111b47eba33a2e10307e2e601f2 on opentracing:v0.32.0.

I'm +1 to this change, but haven't we had this discussion before?

Hey @sjoerdtalsma
So, from the mentioned RFC:

In lieu of having to perform potentially unsafe casts of a Tracer to access it's implementation-specific Close method, the interface would ensure that it was available regardless.

Also, there was some previous feedback (https://github.com/opentracing/opentracing-java/issues/250#issuecomment-420210277 and https://github.com/opentracing/opentracing-java/issues/302#issuecomment-419909901)
Hope that helps ;)

@carlosalberto I have read those arguments and there seems to be a genuine need for this.
However, I'm more curious than anything else about a use-case where one is in control of the Tracer's lifecycle (because we need close) but not knowing which implementation he/she created earlier in the lifecycle.
Don't let my curiosity get in the way of merging by the way 😉 ..

@sjoerdtalsma perhaps a good example is around the usage of https://github.com/opentracing-contrib/java-tracerresolver, where the user only adds it to their classpath, and does not reference their desired tracer class directly.

However, I'm more curious than anything else about a use-case where one is in control of the Tracer's lifecycle (because we need close) but not knowing which implementation he/she created earlier in the lifecycle

I think I might have mentioned before, but one of the concrete cases where I needed this was when implementing the tracing subsystem for WildFly. Basically, the application server will create a tracer based on the tracer implementation from the application's classpath (possibly packaged inside the application's WAR) and start/close it whenever the deployment has started/finished.

My only concern with Close() API is that it requires synchronous, uninterruptible behavior. I don't know why, but Lightstep's tracer for Go implements cancellable Close():
https://github.com/lightstep/lightstep-tracer-go/blob/9a9bdeed74406bebe00f3875387e5ef1e2364c9e/tracer.go#L190
In Jaeger we never had requests to support that. Our Node.js implementation of Close() is asynchronous, but that's more of a side effect of Node.js style.
So I am interested in hearing from existing implementations:

do you need Close() to be async (i.e. return a future)?
do you need Close() to be cancellable?

If yes on either question, would be good to hear & document the use cases.

do you need Close() to be async (i.e. return a future)?
do you need Close() to be cancellable?

For Java, catching an InterruptedException is typically sufficient to handle the case where the close has to be canceled.
IMO, having the Tracer extend Closeable has a higher value than providing a non-standard async close method, or a close method with a context (or similar).

@yurishkuro I don't think close is cancellable in go - the context object is only used in the flush so we can ensure there's nothing in the span buffer before closing the tracer. Not really sure about the rationale for that implementation other than making it easier to close + flush in one instruction rather than two.

Hey @yurishkuro @jpkrohling

IMO, having the Tracer extend Closeable has a higher value than providing a non-standard async close method, or a close method with a context (or similar).

I strongly agree with this. But I'm still curious on this detail, and would love so hear other points of view.

@tylerbenson @jpkrohling Thanks for the use cases. With that I'm totally on board with this PR.
I should've guessed the tracer resolver example though.. :wink:

Apparently the rationale behind the Golang Close method being cancellable is to prevent process shutdown being blocked by the tracer, so that a shutdown circuit breaker implemented on the context can kill the Close method. The more you know!

Hey hey @yurishkuro wondering if this makes sense to you? If you think we need more feedback, we could poke people a little bit more ;)
cc @codingfabian @felixbarny

I am being a bit pedantic, but the fact that Lightstep had run into this situation indicates that the use case of tracer.close() blocking is not completely theoretical, that's why I want the semantics of that method to be defined more carefully.

I am being a bit pedantic, but the fact that Lightstep had run into this situation indicates that the use case of tracer.close() blocking is not completely theoretical, that's why I want the semantics of that method to be defined more carefully.

I think this is fine. We can iterate a little bit more to have better semantics ;) (worst case: if it takes too long, we can include it in a further release).
I'd love to get feedback on this
cc @austinlparker

every Tracer should try to flush for some given time -implementation specific- and then simply give up

That's reasonable, but if the API was cognizant of that use case it wouldn't have to be implementation specific. I assume the option here is to return CancellableFuture, which would make the tracer not io.Closable.

That's reasonable, but if the API was cognizant of that use case it wouldn't have to be implementation specific.

Agreed.

I assume the option here is to return CancellableFuture, which would make the tracer not io.Closable.

Also correct. But we could offer this also in the future, for 'advanced' scenarios ;)
What about saying something along "this is a synchronous call, will try to flush pending Spans and shutdown related resources. Be aware of the fact it may ultimately block for long". This is perhaps too general but would help give better expectations to users.

Is the weak guarantee, especially of freeing resources and returning, actually going to be sufficient for the people who need this functionality?

The people that have asked for the feature, iirc, haven't mentioned anything about wanting this to be cancellable, but have mentioned try-with-resources, so I think the current evidence tips towards implementing closeable rather than cancellable.

+1, making the Tracer implement Closeable has real benefits, such as being able to use with closeable streams and try-with-resources. Tracers aren't the only components that might depend on IO resources upon close, and the typical behavior is to properly handle signals like thread interruption when it has to exit right away.

@jpkrohling I don't follow your point about interruption. Typically this is used when you have work done in thread A and another thread B is waiting for that work to complete (e.g. B waits on future.get()). If someone interrupts A, then B gets the interrupted exception. In case of close() method, there's only single thread (most likely main), so who would/could interrupt the close() operation?

I expect blocking operations to not run in the main thread, so, Tracer#close should always run in a worker thread. Otherwise, you are right, but that's an application-level concern that applies to all other #close operations they might have (HTTP connections, file system operations, ...)

I expect blocking operations to not run in the main thread, so, Tracer#close should always run in a worker thread

Well, then to interrupt it you need another API on the tracer, and there's still nobody to actually do the interrupt because main thread is blocked.
Anyway, we're getting into the weeds. My main concern is that we're saying that tracer does not need to provide any guarantee how long it will take to return from close(), and to avoid blocking indefinitely we can only suggest that implementations support some sort of internal configurable timeout. Returning a future that can be cancelled or waited on with a user-controlled timeout avoids this problem completely in a very clean way. It does not make the tracer Closable.

I understand the appeal, but I'm not aware of any standard APIs in Java for that. I'm afraid we'd be building something that deviates from what pretty much everything out there uses.
If we really have a need for the feature you described, we could consider adding an overloaded method, #close(Context) (or #close(int)) with a deadline/timeout. Until then, it's more prudent to keep it simple and consistent with what people are used to.

🎉

Hey all - I've removed a pair of unused imports, and added a pair of minor notes on the close() behavior.
The plan is to merge it late Monday (start preparing the 0.32 release), btw ;)

Merged it, thank you all for the feedback!


Why the  outo finish of mini game  not working even editing in the config True

because the mini-game auto-completion functionality is excluded from the main loop for security reasons
please close the resolved issues.


use rsync to copy restored data from staging dir to volume dir

Signed-off-by: Steve Kriss<EMAIL_ADDRESS>

LGTM


fix issue which causes crash in production due to not properly concatenating buffers

Impacts by anyone using v0.1.9
fixes: https://github.com/MaxNoetzold/y-mongodb-provider/issues/15
this is the bare minimum fix for this issue it might be nice to rework this whole function as it would gain huge benefit from not looping over the whole array of updates for every part it finds.

@MaxNoetzold when do you think you would be able to get this tested and in a release? It is more or less a revert of this particular line from v0.1.8

Hey @rustysys-dev, thank you for your pull request. It's an unfortunate bug that you found here. It shouldn't take me too long to release your PR.
Some backstory for context: I implemented the parting feature some time ago for a project I no longer work on. Since then, there was this PR to optimize some code. In that PR, the very line that you want to add again was deleted. All tests passed perfectly. This is because I no longer used the 16MB feature and therefore didn't add a testcase for it.
So, before I merge your PR, I will add a testcase for big ydocs to avoid running into this problem again. I should have enough free time this week to do it.

it might be nice to rework this whole function as it would gain huge benefit from not looping over the whole array of updates for every part it finds.

I don't think that you are right, but please feel free to correct me here. The code does not loop through the whole updates array to build the parts. It expects that the parts in the docs array are ordered and located exactly after the doc with part number 1 (hence this error). The loop starts at the doc after the start and ends with the last part. The only optimization I see here is that after the inner loop, I could set i to j, so that the outer loop doesn't check the part docs again, but since this check is only an if statement, it probably won't even be noticeable performance-wise.
However, I do see the point that it might not be the best design to be easily understandable. We could add an extra parts collection to store the actual data and only store the info that there are parts in the original doc. However, as I see it, it should be less efficient because we need more database lookups.
I will definitely add a comprehensive comment block there to explain my reasoning for the future.

@rustysys-dev, I've just added a test case where I input 40MB of 'a's into a ydoc text field. It fails with updates.push(...parts) but works with updates.push(Buffer.concat(parts)).
I'd appreciate it if you could take a look at the test case to see if it covers your specific scenario too.

@MaxNoetzold Ill take a look at it soon and get back to you in a couple of hours. Thanks for your response!!

@MaxNoetzold I have confirmed it has worked properly!!

Perfect, I'll release it tomorrow


How to get type from R.addIndex?

const prize: {
    name: string,
    total: number
}[] = [
    { name: 'phone', total: 10 },
    { name: 'computer', total: 8 }
]
R.addIndex(R.map)(
    (item, index) => ({
        name: item.name,
        stock: item.total // error here: item is unknow
    }),
    prize
)

How to get type definition of item?

R.addIndex is a generic function, so you should add the expected type of the item as so
import * as R from "ramda";

const prize: {
  name: string;
  total: number;
}[] = [
  { name: "phone", total: 10 },
  { name: "computer", total: 8 }
];
R.addIndex<{
  name: string;
  total: number;
}>(R.map)(
  (item, index) => ({
    name: item.name,
    stock: item.total // error here: item is unknow
  }),
  prize
);

Better yet, you could clean it up a bit as
import * as R from "ramda";

interface IPrize {
  name: string;
  total: number;
}

const prize: IPrize[] = [
  { name: "phone", total: 10 },
  { name: "computer", total: 8 }
];

R.addIndex<IPrize>(R.map)(
  (item, index) => ({
    name: item.name,
    stock: item.total
  }),
  prize
);

@AndrewWD1  thanks, I'm sure it works, anyother way to make it to get in intelligence instead of  defining a new interface?

As long as you the type as a generic to R.addIndex the item populates as that type in IntelliSense

@AndrewWD1 Alright.


Add section form field

Check participant's state based on section
Update PLZ data as the old one contains multiple errors

Not sure if the sorting by state is actually helpful, especially since it currently does not work well with searching...


ss

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

ww

Please format your PR title and content. This is not how we work.


Web - IOU - Numbers added after decimal point are appearing preceding the decimal point

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to staging.new.expensify.com and login
Select a group and select option "Split bill"
Enter a decimal point and then numbers

Expected Result:
Numbers are added after the decimal point
Actual Result:
Numbers are added before the decimal point, user can't add decimal amount
(Same scenario with Request money and Send money as well)
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web

Version Number: v1.1.99-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

@eVoloshchak Is this in any way related to your changes?

@eVoloshchak Is this in any way related to your changes?

Yes, I think it's a regression from https://github.com/Expensify/App/pull/10028. I'll be able to revert the PR and verify this in ±14 hours.

@eVoloshchak Any updates on this one?

Sorry, having trouble with free time
It is related to https://github.com/Expensify/App/pull/10028 simply because this PR introduced adding preceding zero if the user entered the decimal point, so it was an edge case I missed in this PR
Somehow this doesn't happen if you have currency after the amount
https://user-images.githubusercontent.com/9059945/190479209-51313e2a-aa94-4cf1-9447-f41a77ba9293.mov
I'll look into this on the weekend

Could this be related to #10147?

I don't think so, this PR changed only the updateAmountNumberPad method (the one used for on-screen keyboard), while this bug is on Web, so the problem is with updateAmount method, which was unchanged in #10147

Now that I think about it more, yes, it could be related to #10147. It introduced some changes to the TextInput, mainly the selection being controlled by state, there could be bugs associated with this
I'll check it, thank you

I checked it, https://github.com/Expensify/App/pull/10147 was the PR that caused this, thanks @parasharrajat for pointing this out.
Solution:
This is a controlled input, but currently in updateAmount we update amount, but don't update the selection. Let's fix that
updateAmount(text) {
    this.setState((prevState) => {
        const amount = this.addLeadingZero(this.replaceAllDigits(text, this.props.fromLocaleDigit));
+       const selection = this.getNewSelection(prevState.selection, prevState.amount.length, amount.length);
        return this.validateAmount(amount)
-            ? {amount: this.stripCommaFromAmount(amount)}
+            ? {amount: this.stripCommaFromAmount(amount), selection}
            : prevState;
    });
}

https://user-images.githubusercontent.com/9059945/190911888-7d83dc58-b25e-4680-964b-4e74aea813a3.mov

Just checked with the team on how we need to handle this. I will put the updates here. Thanks

I'll work on the RCA

I just discussed it with the team and since this is a clear case of regression we would want @eVoloshchak to push a PR fixing this.

If the solution I proposed looks good to you, I can push a PR

@eVoloshchak yea, let's do it!

@eVoloshchak Hi, have you pushed a PR fixing it?

@eVoloshchak Hi, have you pushed a PR fixing it?

PR is up

Issue not reproducible during KI retests. (First week)

Issue not reproducible during KI retests. (Second week)

Issue not reproducible during KI retests. (Third week) @techievivek Are we ok to close this one?

Sorry, I agree we can close this now.


Filter out items other than videos in search

Fixes #248

Lol! The test failure is due to quota exceed!

I ran the tests locally with a new key. LGTM. Thanks for this!


Revert "add termination policy to TLS in cephobjectstore route"

This reverts commit 0bcab7b9f2c96fd5a22d958fe55e9a3d21fe0978.

/ok-to-test


Enable Prefix for TypeScript DTO Interfaces

In the output Typescript client file, I'd like to have the option of all generated DTOs as interfaces to be able to have the letter 'I' in front of them, in order to be able to clearly mark them as interfaces, as is often required by coding standards.  Even better would be the option to be able to add a custom prefix to all generated DTO interface names.

At the moment you need to preprocess the specification or implement an own ITypeNameGenerator
https://github.com/RSuter/NJsonSchema/blob/master/src/NJsonSchema/DefaultTypeNameGenerator.cs

@squeakyD  If you need quick workaround, here is a simple PowerShell script for adding 'I' prefixes to interfaces.
(Get-Content './path-to-models.ts' -Raw) -replace "export interface ([a-z]*) {", 'export interface I$1 {' | Set-Content -Path './path-to-models/nswag.ts'


Issue running swift build

pension_plan_kit/.build/checkouts/Get/Sources/Get/DataLoader.swift:156:50: error: incorrect argument label in call (have ':didCreateTask:', expected ':taskIsWaitingForConnectivity:')
handlers[task]?.delegate?.urlSession?(session, didCreateTask: task)

Hmm interesting. Please can you share some information about your build environment.. Are you using Xcode or swift build? Which version of Xcode/Swift are you trying to build with.

Get/Sources/Get/DataLoader.swift

This is actually part of the Get library so it might be that we need to open an issue over there depending on what the problem is.

I am using swift build and latest stable which is 14.0

Thanks, I just tried and I can replicate the same issue but this is related to Get and not CreateAPI itself. Please could you open an issue in that repository providing the same information above?
It looks like some things might have changed in the latest beta of Xcode. Note that CreateAPI doesn't support Get 2.0 yet so a version of Get 1.0 would also need to be released with a patch for this issue.

Actually, it looks like Get 2.x fixes the issue. But I wonder if we can get an updated version of Get 1.x that patches this issue too?
This is the required diff:
diff --git a/Sources/Get/DataLoader.swift b/Sources/Get/DataLoader.swift
index 9bfcc45..e4dca52 100644
--- a/Sources/Get/DataLoader.swift
+++ b/Sources/Get/DataLoader.swift
@@ -150,7 +150,7 @@ final class DataLoader: NSObject, URLSessionDataDelegate, URLSessionDownloadDele
         userTaskDelegate?.urlSession?(session, taskIsWaitingForConnectivity: task)
     }

-#if swift(>=5.7)
+#if !os(macOS) && !targetEnvironment(macCatalyst) && swift(>=5.7)
     func urlSession(_ session: URLSession, didCreateTask task: URLSessionTask) {
         if #available(iOS 16.0, macOS 13.0, tvOS 16.0, watchOS 9.0, *) {
             handlers[task]?.delegate?.urlSession?(session, didCreateTask: task)

cc @kean

Yes, I can release a patch for Get 1.0 as well. I'll do it later today.

Amazing thanks so much! I will try when it has been released :D @kean  @liamnichols

Should be fixed in Get 1.0.3.

I tried to reinstall CreateAPI but it is still the same version:
Warning: create-api 0.1.0 is already installed and up-to-date.
To reinstall 0.1.0, run:
brew reinstall create-api
Is there a fix expected here for this to work?

No need to update CreateAPI, you just need to run swift package reset and swift build on the package that you had already generated and it should clone the 1.0.3 version of Get instead.
If that doesn't work, try deleting the .swiftpm directory to force it to update the dependencies

Sorry for this, but I am struggling to get it past 1.0.2

Hmm, maybe try deleting Package.resolved? It might have 1.0.2 cached in there.

Where would I do this sorry?

Thanks, a new error but one for a separate issue probably, thanks for your help :)

Well at least we're making progress 🙂 The errors look very odd to me, I'm not entirely sure what is going on here. Is the project private ? Are you able to share the generated output so I can try running it locally to reproduce the issue?
In the meantime, I'm just adding Xcode 14 support to our CI checks to check if any errors show up - #156

I just saw your other ticket.. Will close this one and move the conversation over to #155 👍


Suspend Screen Looping (will not go away)

Describe the bug
When using Oxide without lockscreen (not if with with one as well rn but i think not or less pronounced), both models will stop waking up and upon a second press on the Power button will start what I call a "Suspend Screen Loop". On of it seems to be fake (and can be exited on the rM 1). The one that makes the screen flash usually seems to be the "real" suspend screen.
To Reproduce
Steps to reproduce the behavior:

Install either Oxide v2.1 (as in testing rn) or the packages from here
Starting
Suspending and resuming one time
Doing that again

Expected behavior
Suspend screen working as expected and not looping
Screenshots
Video (each time I move my finger to the standby button, I press it once).
https://transfer.cosmos-ink.net/MZlpk/20210118_214910_ffmpegged.mp4
to help explain your problem.
Version Information:

Device: Both
OS: Current on both devices
Version: Latest packages from here. Same also happened when building from the pr in toltec.

v2 1 is expected. This was suppose to be resolved in v2.1.1 so I'm confused as to why it's happening for you.

v2 1 is expected. This was suppose to be resolved in v2.1.1 so I'm confused as to why it's happening for you.

@LinusCDE Please attach the list of files in /opt/usr/share/applications as well as the contents of your tarnish.conf and decay.conf

@LinusCDE Please attach the list of files in /opt/usr/share/applications as well as the contents of your tarnish.conf and decay.conf

@LinusCDE Also, please attach the tarnish logs.

@LinusCDE Also, please attach the tarnish logs.

requested.tar.gz

requested.tar.gz

@LinusCDE Could you attach a screenshot of htop after resuming?

@LinusCDE Could you attach a screenshot of htop after resuming?

Sorry, didn't see the response until now.

Sorry, didn't see the response until now.

FYI - pressing F5 will display processes in a tree that makes it much easier to understand.

FYI - pressing F5 will display processes in a tree that makes it much easier to understand.

It looks like decay is crashing on resume though, which is likely the issue. Not sure why it's not happening for @dixonary or myself.

It looks like decay is crashing on resume though, which is likely the issue. Not sure why it's not happening for @dixonary or myself.

@LinusCDE are you still able to replicate this on the latest version?

Seems to be resolved. Tested with the testing release of oxide. I think this was resolved some time ago when you ensured, corrupt would still show up. I don't consider the brief appearance of corrupt a problem as the suspend loop was far more annoying.
Here is a side-by-side test. I tried to make all actions pretty much simultaniously. So it can probably also serve as some kind of speed comparison.
Video

Closing since you reported it as being resolved.


[haskell-updates] haskellPackages.hls-ghcide: Fix hydra-build

Rearrange the scope override of the haskell-language-server in a way
that intermediate packages don‘t cause build fails on hydra.
My last pr broke the hls-ghcide build on hydra. Which I didn‘t think of because no one uses it other than in hls.

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build fourmolu
@GrahamcOfBorg build hls-ghcide
@GrahamcOfBorg build haskell-language-server

Ah, perfect. The out-paths remain unchanged.
Although I just realize: This disables errors for multiple overrides in the same file. need to rearrange.

@GrahamcOfBorg build haskellPackages.fourmolu
@GrahamcOfBorg build haskellPackages.hls-ghcide
@GrahamcOfBorg build haskellPackages.haskell-language-server


Developer Forum

Is there a developer forum? I compiled the latest and I'm understanding some of the API, but I am trying to understand when the scene.yaml is indicating Manhattan, but I am seeing the world map.  Not much online documentation, but if there, can someone point me to it. I'm working on my senior project and trying to figure this out.
Any help would be great!!!!
Thanks

We don't have a developer forum, but it's true that it would be useful to have a way of asking support questions that didn't involve github issues.
Our team just made a chat room on gitter: https://gitter.im/tangrams/tangram-chat
So we'll give that a try!

Updated readme to mention about gitter chat.


Branch fix issue#247

Minor updates to UG

Codecov Report

Merging #279 (deb62cc) into master (8d3d91a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #279   +/-   ##
=========================================
  Coverage     58.69%   58.69%
  Complexity      420      420
=========================================
  Files            90       90
  Lines          1714     1714
  Branches        179      179
=========================================
  Hits           1006     1006
  Misses          665      665
  Partials         43       43

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3d91a...deb62cc. Read the comment docs.


Not able to download latest dataset for negotiated wages

Code:
ds = discovery.DataSet(dataflow_identifier = "155_358")
ds.dimensions_info()
freq = 'm'
ateco_2007 = '10'
qual_prof = '10'
tip_aggr1 = 'WAGE_E_2'
ds.set_filters(FREQ = freq, ATECO_2007 = ateco_2007, QUAL_PROF = qual_prof, TIP_AGGR1 = tip_aggr1)
df3 = retrieval.get_data(ds)
This retrieves a data set, base 2015, that only has data up until December 2023. The latest data (which is retrievable in the Istat website by using tip_aggr1 = 'WAGE_E_2021') yields an empty dataframe

Hi @OtavioEsper , unluckily WAGE_E_2021 is a value that is not present in the available_values for DataSet 155_358. Honestly I am not sure why and cannot investigate further right now. I have added a test in #26 to confirm that the value is not present


Build Errors With Wemos D1 Mini

Hi, I'm using Wemos D1 mini development board https://wiki.wemos.cc/products:d1:d1_mini_lite.
Whenever I build this library with that board selected, I get the following errors:
expected identifier before numeric constant
ESP8266.h:38: note  in expansion of macro ESP8266
class ESP8266 {
expected unqualified-id before numeric constant
ESP8266.h:38: note  in expansion of macro ESP8266
class ESP8266 {
expected unqualified-id before numeric constant
ESP8266.cpp:51: note  in expansion of macro ESP8266
ESP8266*: ESP8266(HardwareSerial &uart, uint32_t baud): m_puart(&uart)
expected unqualified-id before numeric constant
ESP8266.cpp:58: note  in expansion of macro ESP8266
bool ESP8266*: kick(void)
expected unqualified-id before numeric constant
ESP8266.cpp:63: note  in expansion of macro ESP8266
bool ESP8266*: restart(void)
Error compiling project sources
The library builds fine if I have an Arduino board selected (specifically Arduino Uno).

The reason is that the class name conflicts with the ESP8266 macro defined by the ESP8266 core.
I have a strong suspicion you don't understand the purpose of this library. It's supposed to be used with an Arduino board which is using an ESP8266 module running the AT firmware as a WiFi adapter. The only time it would make sense to compile this library for the WeMos D1 Mini or any other ESP8266 board is if you had two ESP8266 boards connected together and it would be a very rare case when that would make any sense.

Thank you @per1234 for your reply. I was actually trying to add the src to my library project (in Visual Studio IDE for Arduino) where I could add/modify code in my own git repo. Anyhow I went on without compiling it myself.


MAINT: signal: import gcd from math and not fractions when on py3+

on python 3+ fraction is deprecated and throws DeprecationWarning
fixes #5874
I hope MAINT is the right tag. Was unsure, my first time on scipy.

@@            master   #5880   diff @@
======================================
  Files          238     238
  Stmts        43542   43545     +3
  Branches      8166    8167     +1
  Methods          0       0
======================================
+ Hit          33971   33972     +1
- Partial       2600    2601     +1
- Missed        6971    6972     +1

Review entire Coverage Diff as of 511e17e

Powered by Codecov. Updated on successful CI builds.

Merging, thanks!


optimized.so: undefined symbol: PyFPE_jbuf

Dear Bednar,
I have a problem for using load_snapshot, for example I try load_snapshot('/GCAL_2000000.typ')
and  get the following errors:
Loading error:
Traceback (most recent call last):
File "/home/wenqi/miniconda2/envs/venv/topographica/topo/command/init.py", line 341, in load_snapshot
pickle.load(snapshot)
ImportError: /home/wenqi/miniconda2/envs/venv/topographica/topo/optimized/optimized.so: undefined symbol: PyFPE_jbuf
I would like to ask: how to solve this problem ?

An error like that typically indicates that you have non-matching versions somewhere, either between some python code and the corresponding binary libraries, or maybe between the version used to create the .typ file and the current version.  To decide between those cases, see if you can create a network, save a snapshot, and load it back in. If that works fine, then presumably the .typ file was saved with some older version, and you'd need to recreate the older environment if you want to use that .typ file. If you get the problem even with a brand-new .typ file, then it's likely an issue with your current environment, in which case you should try building it fresh.

Could it be possible to remove the optimized part connecting to load_snapshot function? I don't see what is the effect for load_snapshot to use optimized part. Recently I built new snapshots of GCAL model, but get the same error.

I don't think that we optimized snapshot loading, but the actual operation of the network. So you see an error to do with the optimized object just because you are trying to restore the state of an optimized object.  You can turn off optimization altogether, but things will get 100X slower, and so that's not normally practical. In any case if you get the same error for newly saved snapshots I'd try to create your environment fresh, using older versions of the dependent code that were previously tested with Topographica.


All balances

In your example the balance is output for one address 1F1tAaz5x1HUXrCNLbtMDqcw6o5GNn4xqX. can make a balance output for all addresses?

Thanks you for your interest.
Unfortunately, this project has for goal to provide some code to parse the chainstate, not compute all balances. This is something I get regularly asked about, and I do not wish to provide for free a way to dump all balances.
Cheers!


Introduce pyproject.toml

As the new configuration file pyproject.toml according to PEP 518 becomes more popular we should also support it. Currently it is not really needed, one could only add to the current default (if the file doesn't exist):
[build-system]
requires = ["setuptools", "wheel"]

add also setuptools_scm which is defined anyway with setup_requires.
@RonnyPfannschmidt has more information.

to sort this out, tracking a setuptools backend for pep-517 would allow to use pip for all install actions and ensuring the setup requirements nicely without ending up in a situation where one is in a "double standard situation"

This is currently solved as an external extension pyscaffoldext-pyproject. I would like to keep it like that until we see that PEP 517 really gets a high adoption, then we can move it into core PyScaffold.


feat: hello world in elixir/javascript renanlmiranda

But as I said your contribution will not be counted in your total of Hacktoberfest, as it was said to make the PR only after Oct 1
You all have to make your contributions from Oct 1, if you make now It will not count.
**Please read the website notices and guidelines **


Add missing documentation

http://babeljs.io/docs/advanced/transformers/es6/spec-block-scoping/
http://babeljs.io/docs/advanced/transformers/es6/spec-modules/
Doc to these 2 transformers seem to be missing.

Also:
http://babeljs.io/docs/usage/transformers/minification/dead-code-elimination

Closing since the docs changed in babel 6 - and searching the codebase there is no dead-code-elimination plugin at the moment


Need ability to seek to the beginning of a partition

We need the option to read from the beginning of a partition. Something along the lines of https://stackoverflow.com/questions/49723182/kafka-consumer-seektobeginning but the parallel consumer does not expose seekToBeginning() or assignment(). Is it possible to expose these or provide an overall wrapper for seekToBeginning()?

This should be achievable from the following workaround:

shutdown PC
use the raw consumer to seek the raw consumer
rebuild pc with the same consumer
pc will start receiving records from wherever underlying consumer starts from

@astubbs  I can't figure out how to implement this workaround. Please provide a working example.

You can try out the consumer interface branch now if you like - it works, and has been used in some experimental tests in other branches.

Closing Issue


Use Go in written language rather than Golang

Search engines are smart enough to match them to golang given the context.

done


[FIX] Unclear caption of example 3

The caption of example 3 is unclear compared to the code.
There is only one JSON file in the example.
A better title could be "Single json file at top level for same task and acquisition parameters
If the change is not committed, then change the json to capitals.

Thanks for pointing this out, however I think that the true issue was a mistake when carrying the spec over from Google Docs to Markdown.
Please go to the spec from before changing infrastructures, and in the pdf that'll pop up, search for However, if there is a key --> this will bring you to that section you are currently trying to fix (alternatively, go manually to "Inheritance Principle" section ... Example 3 is called "case 2" in the outdated spec).
This also alerts me to the fact that https://bids.neuroimaging.io/bids_spec.pdf is linking to version 1.1.0 of the spec in PDF format, instead of our most recent spec. Perhaps we should change that.

@pvdemael did you see my comment? If you don't have time to make the changes, we can turn this into an issue and have somebody else take over fixing it :-)


How to preduce the trimap?

I do some test but didn't get result as good as the images shown in the README.md.
I think trimap have a huge impact to the result. I use Mask RCNN to generator segmentation and than the trimap.
Could you tell how do you produce the trimap in the README.md demo images ?
Thanks!

good question, refer to #5

You can use the "Robust Matting" demo to produce the trimap.

@rainsun1 could you put a link of code here so that we can have a try? I searched for the code, it seemed 'robust matting' algorithm also need trimap to produce final result.

Here is a robust matting demo, you could load an image and then create a trimap yourself by the brushes and inpainting.
RobustMatting_1.45.zip

@rainsun1 many thanks for sharing this, actually, it'll be better if the trimap can be automatically generated so that the whole process can be automatic. recently, i found a useful website which can do bg removal all in automation: http://remove.bg

@tsing90 A paper named "Semantic Human Matting" is in this automatic trimap way.

@rainsun1 many thanks, that's what I need. unfortunately, the big datasets shown in that paper are not available for us. that kind of big datasets is essential for training a good model.

@tsing90 yes, but can you find some other implementations on "Semantic Human Matting" on github?

remove.bg,so wonderful

@rainsun1 yes, I found some, like
https://github.com/lizhengwei1992/Semantic_Human_Matting
https://github.com/CapsulE07/semantic-human-matting

@wodsoe that's our benchmark from industry ;)

@wodsoe that's our benchmark from industry ;)
How to re-implement

@tsing90 you can use Deep Lab v3+(https://github.com/tensorflow/models/blob/master/research/deeplab/deeplab_demo.ipynb) to get segmentation mask and then apply trimap generator to produce trimaps.
https://github.com/lnugraha/trimap_generator

@farazBhatti thanks for your suggestion. actually I've already tried its xception model which is good to get decent masks. To get trimaps, it's enough just by doing dilating and eroding if we know alpha matting. The key problem is we don't have alpha matting.

@tsing90, yes true we only need medium quality segmentation mask to get trimap and from that trimap along with original colored image alpha matte is predicted. Alpha matte segmented image will always be superior to any other segmented mask , but we really don't need that good quality of segmented mask to predict alpha matte.

Does anyone have this problem? when producing trimap using the alpoha matte image from Adobe's DIM datasets, the trimap is kind of jagged, shown like below. My first guess this issue is due to the image quality of .jpg, because .png images in that datasets don't have this problem.

Yes it could be the result of jpg compression quality. By the way is there any link to this data(
Adobe's DIM dataset) set which you are using?Thanks

@farazBhatti I got them from the author, due to license issue, you have to contact the author of that paper

@xaibeing The trimaps are in the dataset obtained from the author.

@tsing90 Hi, I'm re-implementing the work nowadays. Could you please share some details of your tests. Hope to have a talk, my email<EMAIL_ADDRESS>

@xaibeing The trimaps are in the dataset obtained from the author.

Only the test dataset has trimaps. The training set does not have them. @foamliu Can you explain a little bit how you generated trimaps for your training set? Thank you.


Automate Vault upgrades

See: https://www.vaultproject.io/docs/platform/k8s/helm/run#upgrading-vault-servers

Vault is gone! 🎉


Tracking Indonesian Translation Progress (M6)

This is tracking issue of our progress from Q1 2021 onwards. In the beginning of this milestone, as per our metrics, we have translated 220 pages from 84 contributors (the script from main repo shows 260+ pages), with around 8,000 views per month. In this milestone, we still continuing on updating the obsolete pages. We are not officially listing down target pages to translate, but feel free if you have spare time to translate some.
Maintainers

@ariscahyadi
@danninov
@girikuncoro
@irvifa
@phanama
@qbl
@wahyuoi
@habibrosyad

For New Contributors
Please check this documentation about Dokumentasi Khusus Untuk Translasi Bahasa Indonesia which gives step-by-step on how to start to contribute and translate using official guidelines.
Work Status
There is a list of outdated pages (40 out of 162 pages for this milestone) and please feel free if you want to take part on this work.
PIC: @ariscahyadi

[ ] 🏃🏽♂ removed content/en//docs/search.md
[ ] 🏃🏽♂  removed content/en//docs/tasks/tools/install-minikube.md
[ ] 🏃🏽♂ removed content/en//docs/tasks/tools/kubeadm/_index.md
[ ] removed content/en//docs/tasks/example-task-template.md
[ ] removed content/en//docs/tasks/administer-cluster/cluster-management.md
[ ] removed content/en//docs/setup/learning-environment/minikube.md
[ ] removed content/en//docs/concepts/configuration/assign-pod-node.md
[ ] removed content/en//docs/concepts/configuration/pod-overhead.md

PIC: @danninov

[ ] removed content/en//docs/concepts/configuration/manage-compute-resources-container.md
[ ] removed content/en//docs/concepts/configuration/resource-bin-packing.md
[ ] removed content/en//docs/concepts/configuration/taint-and-toleration.md
[ ] removed content/en//docs/concepts/scheduling/scheduling-framework.md
[ ] removed content/en//docs/concepts/scheduling/scheduler-perf-tuning.md
[ ] removed content/en//docs/concepts/scheduling/kube-scheduler.md
[ ] removed content/en//docs/concepts/scheduling/_index.md
[ ] removed content/en//docs/concepts/workloads/pods/pod-overview.md

PIC: TBD

[ ] removed content/en//docs/concepts/workloads/pods/pod.md
[ ] removed content/en//docs/concepts/workloads/controllers/jobs-run-to-completion.md
[ ] removed content/en//docs/concepts/extend-kubernetes/poseidon-firmament-alternate-scheduler.md
[ ] removed content/en//docs/concepts/containers/overview.md
[ ] removed content/en//docs/concepts/cluster-administration/cluster-administration-overview.md
[ ] removed content/en//docs/concepts/cluster-administration/federation.md
[ ] removed content/en//docs/concepts/cluster-administration/cloud-providers.md
[ ] removed content/en//docs/concepts/cluster-administration/controller-metrics.md

PIC: @habibrosyad

[ ] removed content/en//docs/concepts/cluster-administration/monitoring.md
[ ] removed  content/en//docs/templates/index.md
[X] removed content/en//docs/reference/glossary/kuantitas.md #26090
[ ] removed content/en//docs/sitemap.md
[ ] modified content/en/includes/task-tutorial-prereqs.md
[ ] modified content/en/docs/home/supported-doc-versions.md
[ ] modified content/en/docs/home/_index.md
[ ] modified content/en/docs/tasks/debug-application-cluster/resource-usage-monitoring.md

PIC: TBD

[ ] modified content/en/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough.md
[ ] modified content/en/docs/tasks/run-application/horizontal-pod-autoscale.md
[ ] modified content/en/docs/tasks/run-application/run-stateless-application-deployment.md
[ ] modified content/en/docs/tasks/run-application/force-delete-stateful-set-pod.md
[ ] modified content/en/docs/tasks/tools/install-kubectl.md
[ ] modified content/en/docs/tasks/tools/_index.md
[ ] modified content/en/docs/tasks/configure-pod-container/configure-service-account.md
[ ] modified content/en/docs/tasks/configure-pod-container/configure-persistent-volume-storage.md

/language id
/cc @kubernetes/sig-docs-id-reviews

/triage accepted

content/en/docs/search.md is moved to content/en/search.md as mentioned here #23083

content/en/docs/tasks/tools/install-minikube.mdis removed and redirect to official minikube webpage https://minikube.sigs.k8s.io/docs/start/ , as mentioned here #23354

The whole content/en/docs/tasks/tools/kubeadm/ pages are move into content/endocs/reference/setup-tools/kubeadm/ including _index.md as mentioned here #23048

The whole content/en/docs/templates/ are removed in https://github.com/kubernetes/website/pull/20893, I'm going to remove the directory as well as it's unused now.

content/en/docs/concepts/cluster-administration/monitoring.md is moved to content/en/docs/concepts/cluster-administration/system-metrics.md via https://github.com/kubernetes/website/pull/21202

content/en/docs/sitemap.md is removed via https://github.com/kubernetes/website/pull/24270

Just sharing a useful trick for finding related PR which delete/modified a file:
1. Get a commit hash related with the changes
git log --diff-filter=D -- [file path]

e.g.
git log --diff-filter=D -- content/en/docs/sitemap.md

The output will be similar with this:
commit b1fb333fad2301d4d6c30548fb001687f42e24c1
Author: ROSHEEN NAEEM<EMAIL_ADDRESS>Date:   Wed Sep 30 20:30:50 2020 +0500

    Delete sitemap.md

Please note the commit has in the output (b1fb333fad2301d4d6c30548fb001687f42e24c1, in the case of the example above).
You can use the same command to find which commit modified a file by changing the filter from D to M (refer to here for more filters)
2.
Find the related PR with the commit, e.g. via web UI:

In bottom left hand corner near the branch name, in this case master, you can see the PR id (#24270). Click on the link and you will be redirected to the respective PR page, then you can analyse what changes has been made and what actions needed to incorporate it to our localization.

content/en//docs/tasks/example-task-template.md is removed here #22301 together with others.

content/en//docs/tasks/administer-cluster/cluster-management.md is removed here #24415

Hi @kubernetes/sig-docs-id-reviews ... it seems this issue is automatically closed.
Do you have any idea how to re-opened it?

/reopen

Thanks @irvifa :)

/reopen

Hi @kubernetes/sig-docs-id-reviews .... I think we need to close this issue, because it has already behind the schedule.
Do we need to complete all within 1-2 weeks? or we need to carry forward to next quarter?

Hi All,
I have opened Q2 2021 tracking issue #28772


chore: update dependencies

:tada: This PR is included in version 5.24.0 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


Update CI

Codecov Report

Merging #2 (3dbce48) into master (46155a2) will decrease coverage by 0.69%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
- Coverage   73.41%   72.72%   -0.70%
==========================================
  Files           2        2
  Lines          79       66      -13
==========================================
- Hits           58       48      -10
+ Misses         15       13       -2
+ Partials        6        5       -1

Flag
Coverage Δ

unittests
72.72% <100.00%> (-0.70%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

bench.go
77.55% <100.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46155a2...3dbce48. Read the comment docs.


includes at top level should work!

@"breaks.jsonic"

actually an issue in https://github.com/jsonicjs/directive

fixed


Update provider.stub

Hi, @solomon-ochepa
Thank you for your contribution! However, the property names should follow the camelCase convention as per standard PHP and Laravel coding practices. Changing property names from camelCase to snake_case is not consistent with the rest of the Laravel codebase.
Please refer to the Laravel Framework repository for examples of this convention in practice.
Thanks for your understanding!

Hi, @solomon-ochepa
Thank you for your contribution! However, the property names should follow the camelCase convention as per standard PHP and Laravel coding practices. Changing property names from camelCase to snake_case is not consistent with the rest of the Laravel codebase.
Please refer to the Laravel Framework repository for examples of this convention in practice.
Thanks for your understanding!

The link you shared doesn't specify any naming convention standard!
Laravel leverages PHP and PSR 4 standards and does not have a naming convention standard of its own.
PHP Standards:
PHP standard for function/method and variable/property naming is snake_case.

RULES: https://www.php.net/manual/en/userlandnaming.rules.php#:~:text=Function names use underscores between,numerous exceptions to this rule
CODING_STANDARDS: https://raw.githubusercontent.com/php/php-src/master/CODING_STANDARDS.md

Nevertheless, every developer has a history and many come from another ecosystem such as Java, C++, Python, etc., and come with their inherited behaviors and principles, therefore we are given the freedom to use mixed naming conventions.
Therefore, the fact that you or the majority do a particular thing doesn't make it the right thing or the only way to do it.
User functions/methods naming conventions

variables/properties naming conventions

Bad method names

FYI: We have had this same discussion severally and you keep bringing it up. Instead, why not stick to what works for you?
Sometimes in life, we might be doing the wrong thing, thinking is the right thing to do, however, a wise one should never shy away from corrections.

Please, please, please—before responding, take a moment to fully read and understand the comment. I clearly mentioned Property Name, not Method Name. All the references you've provided are related to method names, which isn't what I was addressing.

The link you shared doesn't specify any naming convention standard!
Laravel leverages PHP and PSR-4 standards and does not have a naming convention standard of its own.

The link I shared is from a package with 32K stars; you might have heard of it. I shared this package expecting that you would check a few classes, but it seems you didn't. To clarify, I'll provide some specific classes for your reference. If you truly believe your knowledge surpasses that of Taylor Otwell, Graham Campbell, Nuno Maduro, Dries Vints, and the entire Laravel core team, then by all means, submit a Pull Request to correct the framework.
However, if you find even one property in the Laravel framework using snake_case, I'll stop contributing to this package forever.
Here are a few examples directly from the Laravel source code:

Application.php, lines 55-209
AuthManager.php, line 29
AuthManager.php, line 45
UniqueBroadcastEvent.php, lines 16-23

I understand that each developer might have their own coding style, but when contributing to an open-source project, it's essential to follow the established code style of the package.
Lastly, I didn’t want to bring this up, but it's evident that your contributions are more about appearing on the top contributors' list rather than genuinely improving the package. You've ignored significant issues and performance considerations, focusing only on changing config files and stubs.

Please, please, please—before responding, take a moment to fully read and understand the comment. I clearly mentioned Property Name, not Method Name. All the references you've provided are related to method names, which isn't what I was addressing.

PHP coding standards

Official PHP website referencing a past mistake and the link to the official coding standards.

FYI: I'm not here for a fight. I appreciate your time and contributions!

@solomon-ochepa
This discussion is about properties, not variables.
For variables, you can refer to the PHP documentation on variables. For properties, please see the PHP documentation on properties.
I’m not looking for your appreciation regarding my pull requests. Instead, I challenge you to find even one property in the Laravel framework that uses snake_case. If you can, please mention it in this Pull Request.

@solomon-ochepa This discussion is about properties, not variables.

I understand that you often seem more focused on winning arguments than on understanding different perspectives. It's important to shift your mindset and argue to learn rather than only to prove a point.
When variables are defined in a Class, they are called properties, props, or fields.

For variables, you can refer to the PHP documentation on variables. For properties, please see the PHP documentation on properties.

Ref: For properties, please see the PHP documentation on properties.
Do you read the documentation before sharing the link?

You need to understand that there are differences between documentation, rules, and coding standards. What I shared are the rules and coding standards that guide everything in PHP!

I’m not looking for your appreciation regarding my pull requests. Instead, I challenge you to find even one property in the Laravel framework that uses snake_case. If you can, please mention it in this Pull Request.

I expect exactly that from you! Nevertheless, you should learn to appreciate people.

Can we please focus on reviewing the real feature request here and stop this childish, blind, and unfruitful argument for once?

I've changed the variable name to camelCase as you recommended, I hope you are fine now.
Let's get on with other important things, please.

What is the benefit of changing variable names?
I believe moduleNameLower is more readable than nameLower, just as moduleName is clearer than simply name.
For this PR, I think updating only the docBlock would be sufficient.
On the other hand, this change isn't particularly important to me since we publish stub files, and this change won't affect our project. Ultimately, it's up to @dcblogdev to decide whether to merge or close this pull request.
I'm just bringing this to your attention for future contributions :)

What is the benefit of changing variable names?
I believe moduleNameLower is more readable than nameLower, just as moduleName is clearer than simply name.

Clean and readable code;

Avoid the repetition of keywords: the entire concept here is the module and we all know that already, there is no need to prefix everything repeatedly with the keyword module.
KISS: Always use short and precise names over lengthy names. Avoid spaghetti names as much as possible!
Module Design: module is the concept, and name is a property; module -> name instead of module -> moduleName

On the other hand, this change isn't particularly important to me since we publish stub files, and this change won't affect our project.

Stop always focusing solely on your personal interests. This is an open-source project used by hundreds of people.
For your information, it's advisable to re-publish the stubs and config after every upgrade to stay aligned with ongoing development.

I'm not focusing on personal interests; I always consider the bigger picture, which you seem unwilling to understand.

For your information, it's advisable to re-publish the stubs and config after every upgrade to stay aligned with ongoing development.

You're the only one changing the stubs file without any functional improvement, just stylistic changes.
Keep your advice for yourself. For instance, your latest pull request reflects something we've already had in our project for two years, and it's already been cleaned up.

Have a good day. I don't have time to argue and try to convince you.🙂

Thank you both, I agree with using camelCase for variable names. I'm find with using $name.


CASSANDRA-15347 - Add client testing capabilities to in-jvm tests

Committed with https://github.com/apache/cassandra/commit/fa85ff978bae303fe1b06dce64b758b635278a4d - thanks @ifesdjeen for all the help & review.


Act as a relay server

require('node-sendmail').relay({
  username: 'base64username',
  password: 'base64password'
}).listen(25);

@guileen I saw you had another one like this . Could we consolidate the two into a new one?


fix: use upsert instead of create

It can happen that a child_database returns a page as children and that same page is also returned by the search endpoint. In those cases, we hit the unique constraint.

Thanks LGTM


Automatically set the filename when downloading by the remote ssh extension

These days, I am using the remote ssh extension a lot because of teleworking. However, when I want to download a file (right-click on a file, then click on download) the filename field is empty and I have to put the name manually.
I was not sure if this is a bug or a missing feature but I decided to post it as a feature request. I hope it will be fixed soon.

This should be fixed in the latest insiders
Fixed by @alexr00
Dup of https://github.com/microsoft/vscode-remote-release/issues/2536

I still have this issue and I'm using 1.15.1 (the latest version) on Mac OS 10.15.7.

Yeah you need to use insiders, or wait for newer stable in 2 weeks

Yeah you need to use insiders, or wait for newer stable in 2 weeks

I see. Thanks for the heads up!


Add CornerRadius to TemplatedControl and use it where possible

What does the pull request do?
Adds CornerRadius property to the templated controls.
Handles this property in default/fluent templates.
Also see https://github.com/AvaloniaUI/Avalonia/discussions/5594
What is the current behavior?
There is no CornerRadius property on controls, but there are other border related properties (Brush, Thickness). Confusing.
User need to write a bit of verbose code
<Button Classes="roundy" />
<Style Selector="Button.roundy /template/ ContentPresenter">
    <Setter Property="CornerRadius" Value="4" />
</Style>

What is the updated/expected behavior with this PR?
There is CornerRadius property on controls.
Matches UWP/WinUI APIs.
Simplifies Fluent Expander for a bit.
<Button CornerRadius="4" />

How was the solution implemented (if it's not obvious)?
In the same way as passing other Border related properties from templated control to the root border/content-presenter.
Checklist

[ ] Added unit tests (if possible)?
[x] Added XML documentation to any related classes?
[x] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes https://github.com/AvaloniaUI/Avalonia/issues/5003
Fixes https://github.com/AvaloniaUI/Avalonia/issues/6318 (not related, but it's minor issue)

It's very easy to miss some control with such change... But not a big deal, can be added later, if won't be noticed on the review.

It's awesome to see this added in!
It is very useful and will be a huge help with the new Fluent styles as well as porting controls written for UWP.


update doc build to use github deployment

Would like to update this to make sure that the workflows are as similar as possible


Conflicts with existing model "Factory"

There is a Model "Factory" in our project since the beginning.
In the last days we decided to go away from a prepopulated test-db and use factory_girl for testing.
BUT FG seems to conflict with our model.
Is there any way to use FG in this case without to have to refactor the model and its dependencies?

All you'd have to do is refer to your factory as ::Factory.

So I have to do the code below in my model?
class ::Factory < ActiveRecord::Base
#my stuff
end
Thats not very kind... Would this even work?
Cant test it know, I cant reach the codebase from home...

Sorry, but I'm not sure what's not "kind" about that. Anywhere you reference your Factory, your safest bet is to refer to it as ::Factory. The :: explicitly states that it's not namespaced within a module or class and will guarantee that you're not dealing with a FactoryGirl::Factory.

But I have to begin with that already when I create my Model... Not
only inside of the factories or specs. That is what I consider "not
kind"

Referring to your model as ::Factory likely won't work, because factory_girl defines a top-level Factory module for the vintage syntax. We'd need a way to load just the new syntax.


[C++] ASOF join and sortedmerge join don't work in single threaded mode

Describe the bug, including details regarding any error messages, version, and platform.
Currently, if ARROW_ENABLE_THREADING is not set, asof join and sortedmergejoin are not implemented. This is because the current implementation uses std::thread internally, and I tried not to mess with any class internal code while creating the single threaded mode.
This could do with fixing, as I'm mid porting python to add single threaded support, and otherwise a load of tests will break.
Component(s)
C++

Issue resolved by pull request 41125
https://github.com/apache/arrow/pull/41125


simplify pom via parent, correct licenses, back to surefire

Removes redundant stuff from pom (everything that is already in parent)
Corrects all licenses via license plugin automation (Latest parent enables license check)
Moving back to surefire/failsafe (forge-plugin is no longer needed in all but one submodule)
Turns off spotbugs since it fails.  (On by default in parent)

Build will work once parent pom makes it to S3

Or not.  Need to rethink this.

@myronkscott is this failure caused by my changes?
[ERROR] Errors:
[ERROR]   ServerStackProviderTest>TCTestCase.runBare:196->testAttachAlreadyConnectedTransport:79 » IllegalState

Interestingly, galvan-support ITs work with failsafe 3.0.0-M4 but hang with 3.0.0-M5

This is good to go on my end


consider adding zorder

this line ensures that zoom images does not overlap:
data.zoomedImg.element.style.zIndex = '100000';

never mind, one can do with zoomStyle: 'z-index: 10000',


Update slow prompt example to use kubectl_context

I'm guessing the plugin name changed because it was giving me an error when I used this example SPACESHIP_PROMPT_ORDER.

@Runrioter Updated to use kubectl

Please correct the indent 😃

@Runrioter done!