mWeb/Safari - Log in/Payments- Blue border appears in password field

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/10162
Action Performed:

Go to staging.new.expensify.com
In log in page put your user name
Tap Continue

Expected Result:
Blue border does not appear in password field
Actual Result:
Blue border appears in password field
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/186459931-f739585b-f74c-4f05-8a71-422f413fab17.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

issue reported here on slack : https://expensify.slack.com/archives/C01GTK53T8Q/p1661107700990479

Going to look into this

Also going to look into this 😅

here's what I see in Safari, both in production & staging:

I've been able to reproduce this on dev:

Demoted. Interestingly this will disappear if you refresh the page or do anything that causes a re-render. This makes me think it's a react-native-web bug, and not a problem with one of our styles

What do you think @roryabraham, should we hire someone to investigate this? Or is there a pretty strong likelihood that this is a RN bug and isn't something we'll be able to fix?

I think we should make it external. That it's a RNW is just a hunch, and even if that's right we can fix it, because we have our own fork of react-native-web we use.

Posted to Upwork: https://www.upwork.com/jobs/~01091321c3578832d2

Proposal
I was able to reproduce this issue in my desktop Safari(but not able to reproduce in mobile safari) based on your issue report.
This is outline-width css issue, which is not working well in safari when input is focused.
We can resolve this issue by adding outline-style: none or outline: none
Actually, I've also noticed that login email input has the wrong outline like the below screenshot.

So, I suggest to change the withOutlineWidth method like below
function withOutlineWidth(obj, val, error = false) {
    return {
        ...obj,
        outlineWidth: val,
++      outlineStyle: val ? 'auto' : 'none',
        boxShadow: val !== 0 ? `0px 0px 0px ${val}px ${error ? themeDefault.badgeDangerBG : themeDefault.borderFocus}` : 'none',
    };
}

By adding this line, this issue will be resolved

@railway17's suggestion proposal sounds good, let's go with that.

It was just pointed out to me that I jumped the gun on assigning this, sorry about that @mananjadhav! 😅 Please take a look at it and let us know what you think.

No worries @deetergp. @railway17's proposal looks good.

@deetergp
I applied to Upwork yesterday but didn't get an offer.
Could you check it again?
Thank you
Han

@deetergp  am I eligible for reporting this issue as I have logged this issue in slack before listed in git https://expensify.slack.com/archives/C01GTK53T8Q/p1661107700990479

@railway17 Upwork offer sent!
@mananjadhav Please grab the job in Upwork when you get a chance! https://www.upwork.com/jobs/~01091321c3578832d2

@stephanieelliott
I've created a PR here.
Please assign reviewers.
Thank you

@kbecciv I am on not able to reproduce this on latest version on staging as well as local. I am on version v1.1.96-5.
@railway17 Are you able to reproduce on the latest version?

@mananjadhav
I've just tested in the v1.1.96-5 version, but still reproducible in desktop safari.
But couldn't reproduce it in the mobile safari that I've posted in my proposal.

What is your Safari and Mac OS version ?

Here are my versions, @mananjadhav

@mananjadhav the actual issue is different in mWeb/safari just try to change the password you will notice whenever it is secureTextInput with (eye icon) it has some weird blue opacity border

@mananjadhav the actual issue is different in mWeb/safari just try to change the password you will notice whenever it is secureTextInput with (eye icon) it has some weird blue opacity border

stagging + local both affected

@dhairyasenjaliya
Which iOS version do you use?
I think my PR will resolve the issue on both mobile as well as desktop, but couldn't reproduce it on my phone.

@railway17 you have to check in mobile web (specific safari web)

You mean do you want to see the screenshot from my phone?

https://user-images.githubusercontent.com/29966461/188462413-b6d01a27-6dd0-4569-8245-ca16e42f02ff.MP4
https://user-images.githubusercontent.com/29966461/188462468-c1c048d5-f141-40f1-b3d8-3600f570e4f6.MP4
@dhairyasenjaliya , @mananjadhav
I just reproduce the issue on the mobile phone and attached 2 videos with my fix.
Please take a look and let me know
Thank you

Issue not reproducible during KI retests. (First week)

@mvtglobally I am still able to reproduce this on iOS 14.4. I can see the previous dev screenshot was also from iOS 14.4. So you might want to take a look at the older versions maybe?

Quick update is that I was finally able to reproduce and I've reviewed the PR to confirm the fix works. Thanks @railway17 @dhairyasenjaliya

@stephanieelliott Upwork job for reporting issue is missing

Issue not reproducible during KI retests. (Second week)

Hey @dhairyasenjaliya there is no separate job for reporting -- please apply on the Upwork post and I will pay you on that 😊 https://www.upwork.com/jobs/~01091321c3578832d2

Hey @dhairyasenjaliya there is no separate job for reporting -- please apply on the Upwork post and I will pay you on that 😊 https://www.upwork.com/jobs/~01091321c3578832d2

Ah thanks applied

All paid!


Backport 2.7: Separate psk and psk_identity buffers free

Backport of https://github.com/ARMmbed/mbedtls/pull/1474

retest

Closing as backport not required.


failed to mount azure disks

Deployment failed to start Logging/metrics pods
While the azure storageclass is able to create the blobs on azure storage account, disks aren't discovered/mounted
Unable to mount volumes for pod "hawkular-cassandra-1-96ps3_openshift-infra(6fce6fb3-eb0a-11e7-bcd0-000d3a23c3e8)": timeout expired waiting for volumes to attach/mount for pod "openshift-infra"/"hawkular-cassandra-1-96ps3". list of unattached/unmounted volumes=[cassandra-data]
Running scope as unit run-84014.scope. mount: special device /var/lib/origin/openshift.local.volumes/plugins/kubernetes.io/azure-disk/mounts/kubernetes-dynamic-pvc-69d650dd-eb0a-11e7-84c4-000d3a23c124.vhd does not exist

This is not an issue on more current releases.  Closing.


How to test the model on other images

I have trained and tested the model on the given dataset, and the experimental result is pretty good.
However, when I test the model on my own data, it seems not to work.
My testing procedure is:

Collect a set of images using a camera with fixed focus;
Get the camera parameters and matching information through VisualSFM, and fill the information in the corresponding  cam.txt and pair.txt;
Get the depth range based on point clouds produced by  VisualSFM, and calculate the depth interval as  (max_depth-min_depth)/192. In my case, the min_depth is 0.0, the interval is 0.01, and I have filled the information in each cam.txt;
Set the max_w and max_h in the test script based on my image size (width:1152, height:768).

However, in the last depthfusion step, 0.00 million points are found. By visualizing the pfm files, I find that the probabilities are all 0.020833334.
I am new to this field and cannot figure out where is wrong. Could anyone be so nice to help me?

Hi @seul0724 , could you visualize the initial depth map?
BTW @KevinCain have discussed how to prepare the input from Colmap in this issue:
https://github.com/YoYo000/MVSNet/issues/8#issue-369981864

Hi Yao ,
thank you very much for your reply.
I have put the original and visualization of the initial depth maps in the attachment. The depth_min was 0.0, and the depth_interval was 0.01. As we can see, the values of the initial depth maps were all "0.0", and in the last depthfusion step, 0.00 million points were found.
After several trials, I have got a rough reconstruction result by setting depth_min to 0.0012 and depth_interval to 0.075.  The ply file and visualization result are also attached in the files. As we can see, the results (mvsnet in the attachment) seem inferior to that of VisualSFM (sfm in the attachment). More importantly, the parameters are set by exploring different values and do to match the depth range (the depth range is got by observing point clouds produced by Viusal SFM). Besides, I find that the reconstruction result is very sensitive to the depth_min parameter, and a small offset in depth_min can produce very different reconstruction result.
I used to do research on object detection in 2D images and I am new to this field.  I get so confused on how to set the parameters for our own images and how to improve the results. Maybe something is wrong, and I hope you can help me to figure it out.
Thank you very much for your patience.
| |
韩婧
|
|
<EMAIL_ADDRESS>|
签名由网易邮箱大师定制
On 11/4/2018 09:37，Yao<EMAIL_ADDRESS>wrote：
Hi @seul0724 , could you visualize the initial depth map?
BTW @KevinCain have discussed how to prepare the input from Colmap in this issue:
#8 (comment)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
从网易邮箱大师发来的云附件
attachment.rar(41.4MB,2018年11月20日 16:29 到期)
下载

Hi,
From my guess it is the problem of the depth range. MVSNet is unable to reconstruct the scenes out of the input depth range, so we must ensure that the given depth_min and depth_interval are corresponding to the SfM system. Note that large depth_interval may also affect the reconstruction quality.
BTW I am planning to transfer the SfM results from other software (e.g., Altizure and Colmap) to MVSNet input in the near future.
Best,
Yao

I have tried to set the depth_min and depth_interval  based on the depth range given by the sfm system, but I failed to get the desired result. Is there anyway to get the correct depth_min and depth_interval parameters?

@seul0724 if you wish you could send me the data, and I can apply our sfm and camera selection methods to help reconstruct the point cloud result.

I have tried colmap as discussed in another issue, and the camera parameters extracted from colmap produce better results than visualsfm. Could you please share your way to extract camera parameters and depth ranges?


[Derby] Unique Index couldn't be created using UI

System information:

Operating system (distribution) and version win10 x64
DBeaver version 7,0,1

Connection specification:

Database name and version Derby

Describe the problem you're observing:
Unique Index couldn't be created using UI
Steps to reproduce, if exist:

Open table
Try to create index (check Unique field)
Save index - generated SQL is for usual, not UNIQUE index
Generated sql:

CREATE INDEX NEWTABLE_1_COLUMN2_IDX ON APP.NEWTABLE_1 (COLUMN2);

Expected sql:

CREATE UNIQUE INDEX NEWTABLE_1_COLUMN2_IDX ON APP.NEWTABLE_1 (COLUMN2);

https://dbeaver.testquality.com defect D73. Do not remove or edit.

Fixed. It was broken for all Generic drivers.

verified


[rapidjson] Update

[x] Changes comply with the maintainer guide
[x] SHA512s are updated for each updated download
[x] The "supports" clause reflects platforms that may be fixed by this new version
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

how can I trigger a new build? The x64_android build failed because the runner was updating system packages...

git commit --allow-empty -m CI
git push

but that CI error probably shouldn't happen.

Thanks!


Added Games written in Python !

Added games written in python using Tkinter and PyGame. Please review and merge.

@TheFenrisLycaon, just add your details in the Contributors' Wall

Aarigato !

Yokoso


from ..sharedcode import helpers does not work

Folder structure
Functions
| - Function 1
|    | - File 1 > from ..sharecode import helpers
| ...
| - sharedcode
|    | - helpers > code
I get a red squiggly under "from .." in VSCode
Exact error message
Attempted relative import beyond top-level packagepylint(relative-beyond-top-level)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d955d169-8fb8-c511-8911-3e49f95c5ce6
Version Independent ID: 8a3d927c-51ce-d7d4-e5d1-acd928826db2
Content: Python developer reference for Azure Functions
Content Source: articles/azure-functions/functions-reference-python.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@prbans Thank you for bringing this to our attention. We are investigating and will update this when we have more information.

@PramodValavala-MSFT - would you happen to have any updates regarding this?

@prbans If you run the function, it still works as expected (probably because of this).

And direct import worked too
from SharedCode.shapes import Pentagon

For the relative import case, the pylint error went away if I added a __init__.py file to the root of the function app.

But guess the doc should include the structure for unit tests too.

@prbans Got tests to work too

Hey @PramodValavala-MSFT thanks for this info, tested and it works.
Would be good to add this info to the docs (i.e. "Ensure you have a init.py file at root of the python-functions directory" or similar)
Feel free to close once the docs are updated

Hey @PramodValavala-MSFT  seems it is again broken with latest runtime. Now absolute import (i.e from SharedCode.shapes import Pentagon) is no longer working with consumption plan. Please let me know if you have any update on this. After deployment when try to invoke the function following error come -
Result: Failure
Exception: ModuleNotFoundError: No module named 'SharedCode'
Stack:   File "/usr/local/lib/python3.6/site-packages/azure_functions_worker/dispatcher.py", line 239, in _handle__function_load_request
func_request.metadata.entry_point)
File "/usr/local/lib/python3.6/site-packages/azure_functions_worker/loader.py", line 66, in load_function
mod = importlib.import_module(fullmodname)
File "/usr/local/lib/python3.6/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
Note: It was working couple of week before. Best thing is if you use Appservice plan same code works perfectly :)

We've updated the Python reference article guidance to have the tests folder at the same level as the function app folder, based on a recommendation from @brettcannon. Please let us know if this guidance doesn't work for you and we can reopen this issue. #please-close

I can't for the life of me figure out why I'm unable to import shared code... Can anyone see what I'm doing wrong?
Errors:
When using from .shared.identity_utils import get_credential...
Exception while executing function: Functions.get-az-cost-data <--- Result: Failure Exception: ModuleNotFoundError: No module named '__app__.function1.shared'.

When using from ..shared.identity_utils import get_credential...
Exception while executing function: Functions.get-az-cost-data <--- Result: Failure Exception: ModuleNotFoundError: No module named 'identity_utils'.

Directory structure:
azure_functions/
| shared/
| | __init__.py
| | identity_utils.py
| function1/
| | __init__.py
| | function.json
| host.json
| requirements.txt


JS Error in the console

Hey,
I am using the latest version of ImageSet and getting this error in the console recently Uncaught ReferenceError: el is not defined on line 945 of imageset.js. Maybe you could have a look :)
Btw are you planning future releases of ImageSet & ImageKit? Both seem a bit stagnant unfortunately :(
Dennis

Hey Fabian :)
I can totally understand your situation, hope you have some more time soon!
Nonetheless many of my sites rely on ImageSet & ImageKit and I somehow thought the paid license model ensures its reliability at least for a while. I'm also very hyped for Kirby 3 but I'm definitely not planning to upgrade all of my sites immediately (or even at all) so if you plan to focus on Kirby 3 versions please don't forget Kirby 2 (at least with bugfixes)!

@wottpal Just released 1.1.0 Beta 2 :-) Please try agaign if your issue is fixed by now (I really hope so).


chore(*) update install docs if dockerfile install changes

Question: should have a debian dockerfile? Right now we're relying on the ubuntu dockerfile to test debian releases looks like: https://github.com/Kong/kong-build-tools/blob/master/test/build_container.sh#L8-L10

Question 2: should we be running CI tests against non-docker installs too? Right now we run tests against docker images only but docker images aren't always equivalent to distributions. (I know this is way out of scope of this PR, but just asking)

Question: should have a debian dockerfile? Right now we're relying on the ubuntu dockerfile to test debian releases looks like: https://github.com/Kong/kong-build-tools/blob/master/test/build_container.sh#L8-L10

I wouldn't personally oppose to this, but would be nice to see if there's been any asks from the community / customers.

Question 2: should we be running CI tests against non-docker installs too? Right now we run tests against docker images only but docker images aren't always equivalent to distributions. (I know this is way out of scope of this PR, but just asking)
edit: maybe we could do this via the jenkins cloud plugin, would it be worth the effort?

Unsure I understood this correctly, but the packages are smoke-tested separately, in kong-build-tools.

I wouldn't personally oppose to this, but would be nice to see if there's been any asks from the community / customers.

No demand yet AFAIK. And no issues reported so far.

Unsure I understood this correctly, but the packages are smoke-tested separately, in kong-build-tools. Mind clarifying?

They are smoke-tested in a docker image, my idea was to run smoke tests not in docker images, but in actual distributions.


What is the best way to secure the IronFunctions API?

I have been looking through the docs and haven't seen anything about how to secure access to the IronFunctions API. Is the expectation that IronFunctions will always be behind an HTTP Server and secured at that layer? Or are there plans to implement a security model?

I am considering using Iron Functions as the basis for an internal corporate FaaS. So I could put Nginx in front of the API but that would not give me fine grain control over creating, modifying, and deleting applications and routes. I know I can front fn with a web application that will manage access to the API but am wondering if that is something being considered as a feature in a future release so that using Iron Functions inside an enterprise is a turn key solution.

Hi @cruxnet , yes, we'll definitely be providing ways to add authentication/rights management in a future release. By next release (beta 2), we'll have the middleware and listeners all fleshed that will enable plugging in auth providers and what not. You can see that branch here and see how to use it: https://github.com/iron-io/functions/pull/474
We're using that to implement authentication in our internal Iron.io cluster.
Feedback welcome.

What you describe is what I was looking for. Much appreciated. Thanks!


time series forecasting

Hi, great job! can this model be used for time series forecasting?How's the effect

I didn't test on time series forecasting applications.
However, self-supervised contrastive learning is used here to pretrain the encoder network from the unlabeled data, regardless the downstream task. You can just plug the downstream task you want afterwards by adding the suitable module (i.e., classification, forecasting, anomaly detection, etc.).

thanks a lot, I will try to test it


my hass run in docker occur this problem

2021-10-13 11:43:34 ERROR (webrtc) [root] Uncaught thread exception
Traceback (most recent call last):
File "/usr/local/lib/python3.9/threading.py", line 973, in _bootstrap_inner
self.run()
File "/config/custom_components/webrtc/utils.py", line 172, in run
self.process = subprocess.Popen(
File "/usr/local/lib/python3.9/subprocess.py", line 951, in init
self._execute_child(args, executable, preexec_fn, close_fds,
File "/usr/local/lib/python3.9/subprocess.py", line 1821, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
PermissionError: [Errno 13] Permission denied: '/config/rtsp2webrtc_v5_amd64'

hi - I do have exactly same error
PermissionError: [Errno 13] Permission denied: '/config/rtsp2webrtc_v5_amd64'
Also running Hassio on docker on Debian 10 mini pc
Any lead to solve this?

I haven't found a solution yet

hi - I do have exactly same error PermissionError: [Errno 13] Permission denied: '/config/rtsp2webrtc_v5_amd64'
Also running Hassio on docker on Debian 10 mini pc
Any lead to solve this?

I haven't found a solution yet

Check this: https://github.com/AlexxIT/WebRTC/issues/131
Maybe your problem is the same, make sure you can run binary rtsp2webrtc_v5_amd64 through terminal, if you have "permission denied" error, maybe your mount point doesn't have permission to run binaries.
To clarify:
When my usb hdd that stores homeassistant config was on /mnt/myhdd/homeassistant/config i get Permission Denied error
When i moved to /home/myuser/homeassistant/config the problem was solved.
hope it helps.

Check this: #131
Maybe your problem is the same, make sure you can run binary rtsp2webrtc_v5_amd64 through terminal, if you have "permission denied" error, maybe your mount point doesn't have permission to run binaries.
To clarify:
When my usb hdd that stores homeassistant config was mounted on /mnt/myhdd/homeassistant/config i get Permission Denied error
When i moved to /home/myuser/homeassistant/config the problem was solved.
hope it helps.

Hi this was really helpful.
It was indeed a permission issue and running
sudo chmod -R 0755
fixed the problem after restarting HA
Thanks a lot

Check this: #131
Maybe your problem is the same, make sure you can run binary rtsp2webrtc_v5_amd64 through terminal, if you have "permission denied" error, maybe your mount point doesn't have permission to run binaries.
To clarify:
When my usb hdd that stores homeassistant config was mounted on /mnt/myhdd/homeassistant/config i get Permission Denied error
When i moved to /home/myuser/homeassistant/config the problem was solved.
hope it helps.

Architecture:        x86_64
CPU op-mode(s):      32-bit, 64-bit
Byte Order:          Little Endian
Address sizes:       43 bits physical, 48 bits virtual
CPU(s):              4
On-line CPU(s) list: 0-3
Thread(s) per core:  1
Core(s) per socket:  1
Socket(s):           4
NUMA node(s):        1
Vendor ID:           GenuineIntel
CPU family:          6
I run docker on my x86 Linux. Can't I use this component? Must it be an arm device?

Component support different architectures

Check this: #131
Maybe your problem is the same, make sure you can run binary rtsp2webrtc_v5_amd64 through terminal, if you have "permission denied" error, maybe your mount point doesn't have permission to run binaries.
To clarify:
When my usb hdd that stores homeassistant config was mounted on /mnt/myhdd/homeassistant/config i get Permission Denied error
When i moved to /home/myuser/homeassistant/config the problem was solved.
hope it helps.

Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 43 bits physical, 48 bits virtual CPU(s): 4 On-line CPU(s) list: 0-3 Thread(s) per core: 1 Core(s) per socket: 1 Socket(s): 4 NUMA node(s): 1 Vendor ID: GenuineIntel CPU family: 6
I have modified the permissions, but the component still doesn't work I run docker on my x86 Linux. Can't I use this component? Must it be an arm device?

What happens if you run ./rtsp2webrtc_v5_amd64 directly on bash?

Check this: #131
Maybe your problem is the same, make sure you can run binary rtsp2webrtc_v5_amd64 through terminal, if you have "permission denied" error, maybe your mount point doesn't have permission to run binaries.
To clarify:
When my usb hdd that stores homeassistant config was mounted on /mnt/myhdd/homeassistant/config i get Permission Denied error
When i moved to /home/myuser/homeassistant/config the problem was solved.
hope it helps.

Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian Address sizes: 43 bits physical, 48 bits virtual CPU(s): 4 On-line CPU(s) list: 0-3 Thread(s) per core: 1 Core(s) per socket: 1 Socket(s): 4 NUMA node(s): 1 Vendor ID: GenuineIntel CPU family: 6
I have modified the permissions, but the component still doesn't work I run docker on my x86 Linux. Can't I use this component? Must it be an arm device?

What happens if you run ./rtsp2webrtc_v5_amd64 directly on bash?

 I found the problem. The hard disk I mounted in Linux does not have the permission to execute files. I modified / etc / fstab, changed noexec to exec, and the problem was solved! Thank you for your help!


Share to Freebox sites

Note that Cool Maze already works in the Freebox web browser.  This browser is not a great user experience, though.


New feature: Supplement historic benchmark results manually

If you have started to collect benchmark results at a certain stage of your project, previously there was no simple way to compare your current benchmarks to these historic results. To close this gap, this PR adds a new script, run_local.ts, which allows to easily check in historic results into the gh-pages branch. In write.ts, a new optional parameter insert_mode is created that makes sure historic benches are inserted at the right point in time. This patch also adds a section to the docs that explains the motivation and usage of the new script.
Usage:
GITHUB_REPOSITORY=<owner>/<repo> node /path/to/github-action-benchmark/dist/src/index_local.js /path/to/config.yml <commit-sha>

Example commit (it actually works!): https://github.com/LinqLover/squeak-tracedebugger/commit/75815252aba86393761e76d136d67f973f1cd6df & https://github.com/LinqLover/squeak-tracedebugger/commit/afc45a3039c3299a729a7358fe1c4d4e4919fc44#commitcomment-63175903
I am looking very forward to your review! I understand that this is a rather unusual feature for a GitHub action, but I hope you can understand my motivation for it and share my belief that other new users of this helpful action might be in a similar need. If you think that this enhancement does not fit into the scope of this repository, I could also upload my sources anywhere else, but of course, this would complicate dependency management and maintenance, so it would be my last resort only. Have a nice weekend! :-)

hi @LinqLover
Thank you for the idea and your contribution! I like the idea in general but I need to think about it. I'll get back to you soon :)
I noticed that you removed a lot from package-lock.json file. Could you please run npm install with node v16? You've modified the package-lock.json file back to an old format so I'm assuming you're using a lower version of node.

Thank you for your feedback! 🙂 I will correct the lock file later today, I was assuming node 12 because this version is specified in the action.yml. Maybe this should be updated?


Fix readonly-array ignore-local not working in class methods

See #45

Changes Unknown when pulling fc00af479d61538875436d3a6201454f298db55f on fix/45-class-readonly-array into ** on master**.


feat(qt): Expose -coinjoinsessions, -coinjoindenomsgoal and -coinjoindenomshardcap in CoinJoin Options

Issue being fixed or feature implemented
Let GUI users control all CJ params (on the fly) without the need to edit dash.conf.

What was done?
Add 3 corresponding spin boxes in Options (with a simple sanity check). I tried my best to come up with the least confusing labels/tooltips for these, not sure if I'm 100% happy with the result though.
How Has This Been Tested?
Run qt wallet, play with values and make sure they are saved/loaded/used in mixing correctly.
Breaking Changes
n/a
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

I freaking love it!  Thanks guys for this PR !


Fix XTREME PAN-X loading

Hi 🤗
In response to the discussion in #425 @lewtun and I made some fixes to the repo. In the original XTREME implementation the PAN-X dataset for named entity recognition loaded each word/tag pair as a single row and the sentence relation was lost. With the fix each row contains the list of all words in a single sentence and their NER tags. This is also in agreement with the NER example in the transformers repo.
With the fix the output of the dataset should look as follows:
>>> dataset = load_dataset("xtreme", "PAN-X.en", data_dir='./data')
>>> dataset['train'][0]
{'words': ['R.H.', 'Saunders', '(', 'St.', 'Lawrence', 'River', ')', '(', '968', 'MW', ')'],
 'ner_tags': ['B-ORG', 'I-ORG', 'O', 'B-ORG', 'I-ORG', 'I-ORG', 'O', 'O', 'O', 'O', 'O'],
 'langs': ['en', 'en', 'en', 'en', 'en', 'en', 'en', 'en', 'en', 'en', 'en']}

Their a design question interesting to think about here (cc @lhoestq).
I guess the labels form a closed set so we could also use a nlp.ClassLabel instead of a string. The differences will be mainly that:

the labels are stored as integers and thus ready for training a model
the string to int conversion methods are handled by the nlp.ClassLabel feature (see the doc  and here  and here).

In my opinion, storing the labels as integers instead of strings makes it:

slightly less readable when accessing a dataset example (e.g. with dataset[0])
force you with a specific mapping from string to integers
more clear that there is a fixed and predefined list of labels
easier to list all the labels (directly visible in the features).

=> overall I'm pretty neutral about using one or the other option (nlp.string or nlp.ClassLabel).
Note that we can now rather easily convert from one to the other with the map function and something like:
dataset = dataset.map(lambda x: x, features=nlp.Features({'labels': nlp.ClassLabel(MY_LABELS_NAMES)}))
dataset = dataset.map(lambda x: {'labels': dataset.features['labels'].int2str(x['labels'])}, features=nlp.Features({'labels': nlp.Value('string')}))

^^ this could probably be made even simpler (in particular for the second case)

I see. This is an interesting question.
Maybe as the dataset doesn't provide the mapping we shouldn't force an arbitrary one, and keep them as strings ?
Moreover for NER the labels are often different from a dataset to the other so it's probably good to keep strings (there is no conventional mapping).
Also as the column is called "ner_tags" (or "langs"), you can already assume that there is a fixed and predefined list of labels.

Yes sounds good to me.
This make me wonder if we don’t want to have a default identity function in map so this method could also be used to easily cast features. What do you think?

Yes sounds good. I also noticed that people use map with identity to write a dataset into a specified cache file.


Empty map values and dialyzer fixes

Couple of fixes here: First, my earlier addition of the maps:map() type should just have been map(). Also the gen_tcp:socket() type isn't exported, so I've changed that so that it doesn't trip dialyzer up. (I'll submit a separate patch to OTP to get that exported).
The bigger fix, though, is that empty maps weren't working as query values when there were no columns specified in a query. This change fixes that up.

Looks good! Running tests now, and will merge right after!


Persian like languages not encoding

Describe the bug
first of all, thanks for your great work
the bug appears when characters are like persian or hebrew (rtl languages probably) , it seems it can't encode them.
here are some outputs: hebrew, persian, english
I think it might do something with nuxt server components
thank you again
Reproduction
No response
System / Nuxt Info
------------------------------
- Operating System: `Windows_NT`
- Node Version:     `v18.14.1`
- Nuxt Version:     `3.3.3`
- Nitro Version:    `1.0.0`
- Package Manager<EMAIL_ADDRESS>- Builder:          `vite`
- User Config:      `extends`, `app`, `router`, `experimental`, `components`, `modules`, `i18n`, `headlessui`, `colorMode`, `tailwindcss`, `runtimeConfig`, `nitro`
- Runtime Modules<EMAIL_ADDRESS>`<EMAIL_ADDRESS>`<EMAIL_ADDRESS>`<EMAIL_ADDRESS><EMAIL_ADDRESS>`<EMAIL_ADDRESS>`<EMAIL_ADDRESS>`<EMAIL_ADDRESS>- Build Modules:    `-`
------------------------------

Hey @arashsheyda, thanks for the issue.
This isn't really a bug, more a documentation issue. By default the Inter font is used to render the OG Image, you'll need need to include a font that has the characters you want to support.
export default defineNuxtConfig({
  ogImage: {
      fonts: [
        // will load this font from Google fonts
        'Noto+Sans+Hebrew:400'
      ]
  }
})

I'll update the docs to make this clearer

How did you manage to handle RTL?
Fonts will make the characters appear correctly.
Is there any way to handle the direction for Arabic and Persian lang?

@jesspinklet I handled it like this: https://github.com/persiansda/sabbath-school/blob/nuxt/components/app/OgImage/Base.vue

@jesspinklet I handled it like this: https://github.com/persiansda/sabbath-school/blob/nuxt/components/app/OgImage/Base.vue

Thanks for replying back.
Using Satroi renderer, the direction attribute and direction css property is not working for RTL regardless of checking i18n direction,
text-align is working but it's just the alignment, the word orders aren't correct.
Am I missing something here?
I found this issue that might be related.

Hello guys, I designed a template that aims to add RTL support. You can preview and contribute on this  repo
@arashsheyda @jesspinklet


Some coverage for wordnet.

Add some coverage of wordnet.
I notice that some of the callbacks in this section are in the form callback(result); in the successful case. In an error case, the callback is called with the error as the first argument.
I suggest changing the way the callback is called to callback(err, result);. In a successful case, err would be null. In an error case, result would be null.

sorry this ones gonna get delayed a bit im in the process of re-implementing all the wordnet stuff (#170, #211) ill probably merge it all at once

I'm gonna merge this for now, but unfortunately ill probably have to remove this when i finally get to finish up the WN rewrite since we wont rely on indexfile anymore


how to use describe method in pool?

sqlx-core  src/pool/Executor.rs
impl<'p, C, DB> Executor for &'p Pool<C>
where
    C: Connect<Database = DB>,
    DB: Database<Connection = C>,
    DB: for<'c, 'q> HasCursor<'c, 'q, Database = DB>,
{
    type Database = DB;

    fn execute<'e, 'q: 'e, 'c: 'e, E: 'e>(
        &'c mut self,
        query: E,
    ) -> BoxFuture<'e, crate::Result<u64>>
    where
        E: Execute<'q, Self::Database>,
    {
        Box::pin(async move { self.acquire().await?.execute(query).await })
    }

    fn fetch<'e, 'q, E>(&'e mut self, query: E) -> <Self::Database as HasCursor<'_, 'q>>::Cursor
    where
        E: Execute<'q, DB>,
    {
        DB::Cursor::from_pool(self, query)
    }

    #[doc(hidden)]
    fn describe<'e, 'q, E: 'e>(
        &'e mut self,
        query: E,
    ) -> BoxFuture<'e, crate::Result<Describe<Self::Database>>>
    where
        E: Execute<'q, Self::Database>,
    {
        Box::pin(async move { self.acquire().await?.describe(query).await })
    }
}

The describe method is still very much internal (and intentionally hidden from documentation) while we iterate on the details behind how the query macros work. You're welcome to take a look in the sqlx-macros crate and see how the describe method is used.
Is there a concrete use case you have in mind?

thanks,  i found the answer from 'sqlx-core/src/query.rs',  not public  'describe'.

impl<'q, DB> Query<'q, DB>
where
    DB: Database,
    Self: Execute<'q, DB>,
{
    pub async fn execute<E>(self, mut executor: E) -> crate::Result<u64>
    where
        E: Executor<Database = DB>,
    {
        executor.execute(self).await
    }

    pub fn fetch<'e, E>(self, executor: E) -> <DB as HasCursor<'e, 'q>>::Cursor
    where
        E: RefExecutor<'e, Database = DB>,
    {
        executor.fetch_by_ref(self)
    }
}

thanks


Investigate all the failed ingests + retry/clean up as necessary

Matthias has flagged an ingest from February that failed at the replication step: https://wellcome-ingest-inspector.glitch.me/ingests/b3bfc58c-b1d2-44c1-9096-f304dd9eae48
Once we have the ingests indexed, we should investigate known failures and check those bags were ingested successfully in another ingest. Building a dashboard that categorises ingests and their failure modes might be nice too.

Requires #4512.


Horizontal scroll with mouse wheel

When creating multiple PCR fragments from plasmids, I end up filling the window. Horizontal scroll is enabled, but only if I manually drag the scroll bar. The app should allow horizontal scroll while pressing the Shift key.
Some possible quick solution from perplexity: https://www.perplexity.ai/search/my-react-app-can-scroll-horizo-64mLPRSuRDG0Wpmk44ij2w

Another interesting behaviour would be to always scroll to the rightmost part of the screen after creating a new source, in other words, following the rightmost (+) button.

Very good idea, I will check it out!


fix: provide ACD error description

:tada: This PR is included in version 1.10.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add experimental flag which allows providing a custom test entry point file while still performing test discovery

Motivation:
There are situations where a user may wish to customize the entry point file used to run tests on non-Apple platforms via swift test. For example, to run custom code before invoking the XCTMain(...) function. But including a custom XCTMain.swift file (or its former name, LinuxMain.swift) causes swift test to solely rely on that file to run tests, and more importantly, it causes SwiftPM to skip automatic test discovery, so you end up needing to list all the tests to run in that file. Passing --enable-test-discovery explicitly does the opposite: it performs test discovery, synthesizes its own test entry point file, and ignores any custom entry point file present in the package.
This PR adds a way to both provide a custom test entry point file and still perform test discovery, allowing the custom entry point file to reference the automatically-discovered tests and pass them to XCTMain(...). It enables this behavior when passing a new, experimental flag --experimental-test-entry-point-path <file>.
Modifications:

Add new CLI flag --experimental-test-entry-point-path <file>.
Separate the logic for generating derived test targets: now, there are distinct internal targets for test discovery vs. test entry point code. The test discovery target may be independently enabled, and the test entry point target may either be synthesized entirely, contain the file at the path from the new CLI flag, or contain an XCTMain.swift file in the package source tree.
Ensure the test entry point target depends on the test discovery target if the latter was generated.
Include diagnostics to warn about unexpected configurations.

rdar://97940043

@swift-ci smoke test

@swift-ci smoke test

hi @stmontgomery this is interesting. another approach is to use the plugins that allow you to run code before running tests, which is a more structured way of extending package behavior.

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test

@swift-ci smoke test


workbench.action.terminal.rename does not return focus to element that was focused when command was issued

VSCode Version: Version 1.24.1 (1.24.1)
OS Version: Mac OS 10.13.5

Current Behavior:

After confirming or cancelling the "Enter terminal name" dialogue box, the focus is always returned to the "first editor", regardless of where the focus was when the workbench.action.terminal.rename command was issued.

Expected Behavior:

After confirming or cancelling the "Enter terminal name" dialogue box, the focus should return to wherever the focus was when the workbench.action.terminal.rename command was issued.

Steps to Reproduce:

Focus on the terminal (terminalFocus == true)
Issue workbench.action.terminal.rename command
Input new name for terminal session and press "enter" to accept
Dialogue box closes, but focus is now on the first editor, rather than the terminal

or

Focus on the terminal (terminalFocus == true)
Issue workbench.action.terminal.rename command
Press "escape" to cancel
Dialogue box closes, but focus is now on the first editor, rather than the terminal

Does this issue occur when all extensions are disabled?: Yes

@bpasero I think we've spoken about returning focus after a command is canceled before, can't seem to find the issue though. Do you know which one it was?

@Tyriar https://github.com/Microsoft/vscode/issues/44722


extended bolus doesn't get added to nightscout

Extended bolus doesn't add the extended part as a treatment just adds notes to the up front bolus amount.
tconnectsync 0.5
12:36 PM | Combo Bolus |   | 4.42 | 76 |   |   |   |   |   |   | Pump (tconnectsync) | Extended 50.00%/8.84 (Extended)

It looks like the correct options to use for the Nightscout bolus treatment are setting an eventType of Combo Bolus, along with splitNow, splitExt, and duration fields.
I will look into making this change.


Fixed regular expression for header matchin - SignedHeaders field is …

There is a small bug in the regular expression used, preventing AWS Signer to properly [re]sign the requests passing through the proxy/repeater/....
The "SignedHeaders" field in the Authorization header is not necessarily comma terminated.
Hence, added the optional question mark.

Hi Benjamin. Thank you very much for the PR! The change looks pretty straightforward to me, but I'd like to better understand the impetus.
Do you have a specific AWS service which is rejecting the comma after the SignedHeaders value? An example request (redacted appropriately) would be even more helpful.
From everything I can see in AWS' docs and code, it looks like there should be a comma after the SignedHeaders value and before the Signature in the Authorization header. Here are a couple examples:

IAM Roles Anywhere documentation
The Authorization examples on the subpages in this S3 documentation all have the comma
The Java SDK adds the comma when creating the signature
Botocore adds the comma when creating the signature

Overall, I understand that the original request may not have that specific comma, but from what I can see, it should. Was that original request that we're signing already modified in some way? If it was the original request created by a library or service, that would be really interesting if the comma was missing.

Hi Jake!
Thanks for your quick and thorough answer.
The problem I found is not about a service rejecting an authorization being comma-terminated, but requests passing through the proxy not being re-signed because not comma-terminated / not matching the authorization regex.
As you pointed out, the documentation does not explicitly deals with the "comma". However, it seems to be optional.
(The regex used in AWS Signer sets the comma as optional to separate other fields, for example after aws4_request - it is only set as mandatory after the SignedHeaders)
The API framework used by most of AWS APIs completely ignores the "commas". All the following requests are accepted by the APIs:
Example 1: no comma
POST / HTTP/1.1
Host: XX.XXX.XX.XXX:8000
Content-Length: 0
Content-Encoding: amz-1.0
Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464
Content-Type: application/json; charset=UTF-8
Accept: application/json, text/javascript, */*; q=0.01
X-Amz-Security-Token: <REDACTED>
X-Amz-Target: com.<REDACTED>
X-Requested-With: XMLHttpRequest
X-Amz-Date: 20230901T152222Z
x-amz-requestsupertrace: false
Accept-Encoding: gzip, deflate
Accept-Language: en-GB,en-US;q=0.9,en;q=0.8
Connection: close

HTTP/1.1 200 OK
x-amzn-RequestId: <REDACTED>
Content-Type: application/json
Content-Length: 515
Date: Fri, 01 Sep 2023 15:27:14 GMT
Connection: close

{
...
}

Example 2: many commas + 1 space
POST / HTTP/1.1
Host: XX.XXX.XX.XXX:8000
Content-Length: 0
Content-Encoding: amz-1.0
Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target,,,,,, Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464
Content-Type: application/json; charset=UTF-8
Accept: application/json, text/javascript, */*; q=0.01
X-Amz-Security-Token: <REDACTED>
X-Amz-Target: com.<REDACTED>
X-Requested-With: XMLHttpRequest
X-Amz-Date: 20230901T152222Z
x-amz-requestsupertrace: false
Accept-Encoding: gzip, deflate
Accept-Language: en-GB,en-US;q=0.9,en;q=0.8
Connection: close

HTTP/1.1 200 OK
x-amzn-RequestId: <REDACTED>
Content-Type: application/json
Content-Length: 515
Date: Fri, 01 Sep 2023 15:28:12 GMT
Connection: close

{
...
}

Example 3: many commas WITHOUT space
POST / HTTP/1.1
Host: XX.XXX.XX.XXX:8000
Content-Length: 0
Content-Encoding: amz-1.0
Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target,,,,,,Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464
Content-Type: application/json; charset=UTF-8
Accept: application/json, text/javascript, */*; q=0.01
X-Amz-Security-Token: <REDACTED>
X-Amz-Target: com.<REDACTED>
X-Requested-With: XMLHttpRequest
X-Amz-Date: 20230901T152222Z
x-amz-requestsupertrace: false
Accept-Encoding: gzip, deflate
Accept-Language: en-GB,en-US;q=0.9,en;q=0.8
Connection: close

HTTP/1.1 200 OK
x-amzn-RequestId: <REDACTED>
Content-Type: application/json
Content-Length: 515
Date: Fri, 01 Sep 2023 15:29:36 GMT
Connection: close

{
...
}

Such usage of the Authorization header without the use of the comma is widely used.

Got it. Thank you for the clarification with the examples. I didn't realize that some tools which created the Authorization were omitting that comma. It seems clear though that the AWS APIs are pretty flexible and accept the Authorization with or without that comma.
What are your thoughts on requiring the whitespace after the comma?

Current regex: ,\s+
Your update: ,?\s+
Possible change: ,?\s*

That last option would handle missing whitespace and a missing comma and work with your Example 3 above. I don't think it's likely that an original request would be missing that whitespace, but I think the regex is specific enough that this shouldn't harm any valid Authorization header.
The full regex would become: Authorization:\s*(?<algorithm>AWS4-(?:HMAC|ECDSA-P256)-SHA256)\s*Credential=(?<accessKeyId>[\w-]{1,128})\/(?<date>\d{8})\/(?:(?<region>[\w-]{0,64})\/)?(?<service>\S{0,128})\/aws4_request,?\s+SignedHeaders=(?<signedheaders>\S+),?\s*Signature=(?<signature>[a-fA-F\d]{1,256})
Some passing test cases:

1 comma and 1 space (should be the typical case): Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target, Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464
No comma and 1 space: Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464
1 comma and no space: Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target,Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464
Many commas and 1 space (very unlikely, but valid): Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target,,,,,, Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464
Many commas and no space (very unlikely, but valid): Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target,,,,,,Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464
No comma and no space (very unlikely and possibly invalid): Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-targetSignature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464

Let me know what you think :)

I think that either a space, or a comma, at least one time, would be the accurate pattern we are looking for!
What about something like (,|\\s)+ ?
I would also expand this change to other comma/space separator in the Authorization header  (between Credentialand SignedHeaders).
So the following regex seems to be working and passing my test cases:
    @Test
    void testFixRealRegEx() {
        String re = "Authorization:\\s*(?<algorithm>AWS4-(?:HMAC|ECDSA-P256)-SHA256)\\s*Credential=(?<accessKeyId>[\\w-]{1,128})\\/(?<date>\\d{8})\\/(?:(?<region>[\\w-]{0,64})\\/)?(?<service>\\S{0,128})\\/aws4_request(,|\\s)+SignedHeaders=(?<signedheaders>\\S+)(,|\\s)+Signature=(?<signature>[a-fA-F\\d]{1,256})";
        Pattern p = Pattern.compile(re);

        String[] exs_matching = {
            // 1 comma and 1 space (should be the typical case)
            "Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target, Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464",
            // No comma and 1 space
            "Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464",
            // 1 comma and no space
            "Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target,Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464",
            // Many commas and 1 space (very unlikely, but valid)
            "Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target,,,,,, Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464",
            // Many commas and no space (very unlikely, but valid)
            "Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-target,,,,,,Signature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464",

        };

        String[] exs_not_matching = {
            // No comma and no space (very unlikely and possibly invalid)
            "Authorization: AWS4-HMAC-SHA256 Credential=ASIAXXXXXXXXXXXXXXXX/20230901/us-east-1/XXXX/aws4_request SignedHeaders=content-encoding;host;x-amz-date;x-amz-requestsupertrace;x-amz-targetSignature=64ed7bf1ee17050e2a38b4c878ca6471c341b78cdb428bcec52cc6b58f1a8464"
        };

        for(String s : exs_matching) {
            Assertions.assertTrue(p.matcher(s).matches());
        }

        for(String s : exs_not_matching) {
            Assertions.assertFalse(p.matcher(s).matches());
        }
    }

For future reference, the regex listed here isn't the final regex that was used. See e3517a1. After adding the unit tests, I observed that the trailing comma was included in the parsed value. The trailing comma (if present) should not be extracted since it's treated like a delimiter.

@blafois Could you please give me a sanity check and load the latest release (2.0.4) manually to see if it fixes the original issue? If so, I'll start the process for updating the BApp store.

Hi @jakekarnes42
Sorry for my late answer, I just did some tests, and it seems to be fine on my side !


Added notification for unsaved file in scheduling

Handling issue mentioned in #7274 where an unsaved notebook resulted in an "invalid notebook path" error, the code now detects if the name of the "path" could be a valid filename via a regex and asks the user to save the notebook before the process can be started. Ideally there needs to be a way to have a save prompt or window pop up so that the user can save immediately onto the disk. Currently it simply prints an error asking the user to save first.

The current code for handling notebooks does not allow for unsaved files unlike the query editor and this may require changes on the C# end. Please note this to the Notebook team as there need to be significant changes for the code to be able to handle unsaved files (like that of the query editor).


Updating to reflect Data Residency information

This is required by the privacy team

Made the same request on the -pr verion, closing this


style, silk, Poaceae style

Suggest that you merge these,  keeping style, obsoleting silk and Poaceae style.  Do the same for other floral parts that have a species spin on them, but are really the same as other more generic names for flower parts.
Reported by: mlschaeffer
Original Ticket: obo/plant-ontology-po-term-requests/376

Decided that it would be best to split 'silk' out of the term 'style' (PO:0009074), as we are needing greater granularity for creating specific plant traits.  This required a few revisions to style.
Currently:
style (PO:0009074): An elongated part of a carpel or group of fused carpels between the ovary and the stigma, and through which the pollen tube grows.
Modified definition and comment:
Comment: If you are annotating to this structure for Zea mays or other grasses, please also add an annotation to the corresponding floret type. Choose the most specific term possible from: spikelet floret (PO:0009082), ear floret (PO:0006354), upper floret of pedicellate spikelet of ear (PO:0006350), upper floret of sessile spikelet of ear (PO:0006352), tassel floret (PO:0006310), upper floret of pedicellate spikelet of tassel (PO:0006314), upper floret of sessile spikelet of tassel (PO:0006316).
Revised def'n:
style (PO:0009074): A cardinal organ part (PO:0025001) which is an elongated part of a carpel (PO:0009030) or gynoecium (PO:0009062) between the plant ovary (PO:0009072) and the stigma (PO:0009073), and through which the pollen tube (GO:0090406) may grow.
Revised comment:
If you are annotating to this structure for grasses, please also add an annotation to spikelet floret (PO:0009082). For Zea spp. please use silk (PO:0006488).

New (ish) term silk (PO:0006488):
Proposed def'n: A collective organ part structure (PO:0025269) that has as parts an elongated stigma (PO:0009073) with stigma papilla (GO:0090397), and an elongated style (PO:0009074).
Source: POC:cooperl, PMID:21345919
Proposed Comment:
If you are annotating to this structure for Zea spp., please also add an annotation to the corresponding floret type. Choose the most specific term possible from: ear floret (PO:0006354), or one of the child terms: upper floret of pedicellate spikelet of ear (PO:0006350), or upper floret of sessile spikelet of ear (PO:0006352).


When adding a new KVM zone, the template_store_ref may get wrong install_path for systemvmtemplate

With an existing zone with a new system template (that would be registered with root admin's accoutn ID):

Add a new zone and scp/copy the system template directory to the new zone's secondary storage
Check the install_path template_store_ref for the reference for the systemvmtemplate in the new zone, does it use the account ID 1 in the folder path?

ISSUE TYPE

Bug Report

COMPONENT NAME

SystemVM Template

CLOUDSTACK VERSION

4.11

Looks like the systemvm install script by default hard codes the account folder to 1:
https://github.com/apache/cloudstack/blob/master/scripts/storage/secondary/cloud-install-sys-tmplt#L205

Another issue discovered is that the script renames the uuid for the template which is not necessary.

@Pearl1594 is this still an issue with new secondary storage changes? cc @Spaceman1984

@rhtyd I haven't noticed anything odd wrt the install path of sytemvm templates, the install_path in template_store_ref table seemed to be correct.
I think when the systemvm template is registered as root admin - the path is template/tmpl/2/<template_id>/...

@Pearl1594 does your work on the system VM template improvements fix this issue?

@nvazquez I haven't really testing in a multi-zone env - at this point, it hasn't been addressed. However, I can test/verify if this is still persistent and try to fix it.

Thanks @Pearl1594 looking forward to that.

Thanks @Pearl1594 please advise after your tests

@rhtyd @nvazquez I don't think this is an issue as when thecloud-install-sysvm-tmpltscript is used for seeding the template, it assumes that the template is owned by system account (account_id = 1) therefore on addition of the new zone, the path is properly updated.
Following is the observation made:
Seeded template :
# ls /export/testing/qa2-testzone415-b9ca73e3-kvm/secondary2/template/tmpl/1/3/   <--- zone1
deeeb1c5-5e26-4ab0-b72e-86e3ef0a6c47.qcow2  template.properties
# ls /export/testing/qa2-testzone415-b9ca73e3-kvm/secondary1/template/tmpl/1/3/ <--- zone2
f1b14109-1ea3-4c8f-8643-02d3006c68f3.qcow2  template.properties

Image store:
MariaDB [cloud]> select * from image_store\G
*************************** 1. row ***************************
                 id: 1
               name: nfs://<IP_ADDRESS>/export/testing/qa2-testzone415-b9ca73e3-kvm/secondary1
image_provider_name: NFS
           protocol: nfs
                url: nfs://<IP_ADDRESS>/export/testing/qa2-testzone415-b9ca73e3-kvm/secondary1
     data_center_id: 1
              scope: ZONE
               role: Image
               uuid: 1a5ee1f0-4191-458b-bd7c-18048f963b6a
             parent: 74432ad6-abcd-3ca4-a8d9-a20f91fcd339
            created: 2021-08-24 04:12:06
            removed: NULL
         total_size: NULL
         used_bytes: NULL
           readonly: 0
*************************** 2. row ***************************
                 id: 2
               name: nfs://<IP_ADDRESS>/export/testing/qa2-testzone415-b9ca73e3-kvm/secondary2
image_provider_name: NFS
           protocol: nfs
                url: nfs://<IP_ADDRESS>/export/testing/qa2-testzone415-b9ca73e3-kvm/secondary2
     data_center_id: 2
              scope: ZONE
               role: Image
               uuid: 7ada2348-e31f-4c53-994f-6c047afe9373
             parent: 25f12d68-e6b0-3610-9519-93d15de72bba
            created: 2021-08-24 04:21:47
            removed: NULL
         total_size: NULL
         used_bytes: NULL
           readonly: 0
2 rows in set (0.00 sec)

template_store_ref details corresponding to the systemvm template
MariaDB [cloud]> select id, store_id, template_id, download_pct, store_role, download_state, install_path, url, state, destroyed from template_store_ref where template_id = 3\G
*************************** 1. row ***************************
            id: 5
      store_id: 1
   template_id: 3
  download_pct: 100
    store_role: Image
download_state: DOWNLOADED
  install_path: template/tmpl/1/3/f1b14109-1ea3-4c8f-8643-02d3006c68f3.qcow2
           url: https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.1-kvm.qcow2.bz2
         state: Ready
     destroyed: 0
*************************** 2. row ***************************
            id: 13
      store_id: 2
   template_id: 3
  download_pct: 100
    store_role: Image
download_state: DOWNLOADED
  install_path: template/tmpl/1/3/deeeb1c5-5e26-4ab0-b72e-86e3ef0a6c47.qcow2
           url: https://download.cloudstack.org/systemvm/4.15/systemvmtemplate-4.15.1-kvm.qcow2.bz2
         state: Ready
     destroyed: 0
2 rows in set (0.00 sec)

As for the name being different, though that is not necessary - it doesn't cause any issue

Thanks @Pearl1594, closing after your remarks


Error: name "predict" is not defined

In the 227 line of cvae.py, the function "predict" is not defined.

@min-yang Thanks for notifying.


Add GTK support

This PR will add rendering support for GTK #797. PR also includes example for both native GTK and XF backend.
Implementation of drawing an individual pixel may look like a little bit odd but I think that's the most readable version that can be achieved with GTK.
I wasn't sure how to tackle nuspec files for GTK but I assumed we can use the same convention as Xamarin Forms GTK backend and use net45 as target framework (see here).

Any news? Thanks

@rblanca we have this merged in this fork in case you're interested: https://github.com/nblockchain/ZXing.Net.Xamarin (we also publish this fork on nuget)

@Redth can you include this in 3.0?

@knocte I'm super hesitant to add this into the main package, mostly because https://github.com/Redth/ZXing.Net.Mobile/pull/798/files?file-filters[]=.nuspec#diff-978f915984ac9573cd5e42dfc0550c3fR82-R83
The TFM of net45 isn't really appropriate to use in the main package if the binaries are specifically for GTK apps.
What we maybe could do is release a separate package of ZXing.Net.Mobile.GTK with these binaries in it.

@knocte any interest in trying to rebase this PR's work on current master?

The TFM of net45 isn't really appropriate to use in the main package if the binaries are specifically for GTK apps.

What do you mean? what's the issue exactly? I've been using this code for a while now and works perfectly. The proof is this fork we publish on nuget: https://github.com/nblockchain/ZXing.Net.Xamarin and the app that consumes it: https://github.com/nblockchain/geewallet

The problem is if I ship code that depends on GTK into an assembly which is in the net45 TFM, and someone tries to install and use the package in say a windows console app, they aren’t going to have a good time of it. Because there is no TFM that exists to pivot on GTK support directly, there’s limited options.

Ship it in a separate nuget package such as ZXing.Net.Mobile.GTK (and use net45 for that) - this is a bit more explicit since you have to opt in by installing the nuget package intentionally which means you likely understand what you are doing and won’t try and use it in the wrong type of app.

See if there’s any sort of MSBuild property that is exposed when an app uses GTK and use a .targets file in the main nuget package to pivot on which assembly gets referenced. This is kind of weird if there isn’t any other non-GTK implementation shipping (which there currently is not).

Basically 1 is less discoverable but much easier to implement than 2.
I’m leaning towards option 1.

and use the package in say a windows console app,

But this is not supported by ZXing.Net.Mobile anyway AFAIU, why not just put a warning about this on the Readme?

It's not supported today, but it could be one day.  That alone may not be a good enough reason, but generally the practice we use at Microsoft is to use a separate package name for GTK stuff.  Take Xamarin.Forms.Platform.GTK for instance.
I think the right thing to do here is the separate package (and one for the Forms implementation too).  This means separate .csproj's which I don't love, but I think this is the right choice

It's not supported today, but it could be one day.

One day? AFAIU net45 is the old framework; and these days in the .NET community people are even advocating to stop supporting it because "legacy" and just support .NETCore, why would anyone go in the other direction?
Anyway I understand the point of view (I use GTK myself with Xamarin.Forms) but it looks a bit ugly (because the other nonGTK platforms don't have a separate nuget package).

Yes, net45 is old, however net5 is coming, the same problem will exist there.  There will be no platform TFM for GTK pivoting.  The point is more about unintentionally expressing support for a TFM which you do not actually support.  Yes this is still true of a .GTK package but as I said, it's a bit more explicit by naming and the intentional additional install helps to avoid confusion.
Yeah more nuget refs in a project stinks, but I definitely think the trade off is ok in this case.

any interest in trying to rebase this PR's work on current master?

I have interest :) What I'm not sure is if I have time. Especially considering that even if I did the effort of rebasing it, I couldn't adopt the new 3.x verison of ZXing.Net.Mobile right away, because I just realised that you introduced Xamarin.Essentials as a dependency :( What was the motivation for that? It basically would break our setup because XamEssentials doesn't support macOS and Linux+GTK platforms.


[BUG] Incorrect Package Count and Premature Notification in UniGetUI

Please confirm these before moving forward

[X] I have searched for my issue and have not found a work-in-progress/duplicate/resolved issue.
[X] I have tested that this issue has not been fixed in the latest (beta or stable) release.
[X] I have checked the FAQ section for solutions.
[X] This issue is about a bug (if it is not, please use the correct template).

UniGetUI Version
3.1.1
Windows version, edition, and architecture
Windows 11 Pro 10.0.22631 Build 22631
Describe your issue
The UniGetUI notification system is currently experiencing two main issues
Incorrect Package Count

The notification displays an incorrect number of packages that need to be updated. It seems to show outdated information or fails to accurately count the packages that require updates.

Premature Notification

When I refresh and check for new packages, the notification does not wait until the process is fully completed before showing the package count. This leads to misleading notifications, as the count may not reflect the actual number of packages needing updates after the process finishes.

Expected Behavior

The notification should display the correct and updated number of packages that need updates.
The notification should only appear after the package check process is entirely finished, ensuring that the displayed package count is accurate.

Steps to reproduce the issue
Scenario 1 - Incorrect Package Count After Checking for New Packages

Initial State: UniGetUI displays a notification indicating that 3 packages need to be updated.
Action: The user checks for new packages to update.
Expected Outcome: If a new package is available, the notification should update to show 4 packages needing updates.
Observed Outcome: The notification still shows 3 packages to update, even though a new package is available, leading to an inaccurate package count.

Scenario 2 - Incorrect Package Count After Updating a Package

Initial State: UniGetUI displays a notification indicating that 3 packages need to be updated.
Action: The user updates one of the packages using regular app update mechanism (not UniGetIUI).
Action: The user then checks for new packages to update.
Expected Outcome: The notification should update to show 2 packages needing updates, as one package has already been updated.
Observed Outcome: The notification still shows 3 packages needing updates, failing to account for the package that was already updated.

UniGetUI Log
[21-Aug-24 00:41:34]    __  __      _ ______     __  __  ______
                       / / / /___  (_) ____/__  / /_/ / / /  _/
                      / / / / __ \/ / / __/ _ \/ __/ / / // /
                     / /_/ / / / / / /_/ /  __/ /_/ /_/ // /
                     \____/_/ /_/_/\____/\___/\__/\____/___/
                         Welcome to UniGetUI Version 3.1.1
[21-Aug-24 00:41:34]
[21-Aug-24 00:41:34] Version Code:  3.11
[21-Aug-24 00:41:34] Encoding Code Page set to 65001
[21-Aug-24 00:41:34] Using bundled GSudo at C:\Program Files\WingetUI\Assets\Utilities\gsudo.exe
[21-Aug-24 00:41:34] Loaded language locale: en
[21-Aug-24 00:41:34] Randomly-generated background API auth token for the current session: 3jh8kf2m1qnjjh2zrcg9utokl294dli73gn1v1zkkv6zowf2sefatbftyduwgqfw
[21-Aug-24 00:41:35] Api running on http://localhost:7058
[21-Aug-24 00:41:35] Lang files were updated successfully from GitHub
[21-Aug-24 00:41:35] Downloaded new icons and screenshots successfully!
[21-Aug-24 00:41:35] UniGetUI is up to date
[21-Aug-24 00:41:35] ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
                     █▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
                     █ Name: Winget
                     █ Enabled: True
                     █ Found: True
                     █ Fancy exe name: winget.exe
                     █ Executable path: C:\Users\Byakuga\AppData\Local\Microsoft\WindowsApps\winget.exe
                     █ Call arguments:
                     █ Version:
                     █   System WinGet CLI Version: v1.8.1911
                     █   Microsoft.WinGet.Client PSModule version: ""
                     █   Using Native WinGet helper (COM Api)
                     ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
[21-Aug-24 00:41:35] ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
                     █▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
                     █ Name: .NET Tool
                     █ Enabled: False
                     █ THE MANAGER IS DISABLED
                     ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
[21-Aug-24 00:41:35] ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
                     █▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
                     █ Name: Chocolatey
                     █ Enabled: False
                     █ THE MANAGER IS DISABLED
                     ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
[21-Aug-24 00:41:35] ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
                     █▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
                     █ Name: Npm
                     █ Enabled: False
                     █ THE MANAGER IS DISABLED
                     ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
[21-Aug-24 00:41:35] ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
                     █▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
                     █ Name: Scoop
                     █ Enabled: False
                     █ THE MANAGER IS DISABLED
                     ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
[21-Aug-24 00:41:36] ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
                     █▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
                     █ Name: Pip
                     █ Enabled: False
                     █ THE MANAGER IS DISABLED
                     ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
[21-Aug-24 00:41:36] ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
                     █▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
                     █ Name: PowerShell7
                     █ Enabled: True
                     █ Found: True
                     █ Fancy exe name: pwsh.exe
                     █ Executable path: C:\Users\Byakuga\AppData\Local\Microsoft\WindowsApps\pwsh.exe
                     █ Call arguments:  -NoProfile -Command
                     █ Version:
                     █   PowerShell 7.4.4
                     ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
[21-Aug-24 00:41:36] ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
                     █▀▀▀▀▀▀▀▀▀▀▀▀▀ MANAGER LOADED ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
                     █ Name: PowerShell
                     █ Enabled: True
                     █ Found: True
                     █ Fancy exe name: powershell.exe
                     █ Executable path: C:\Windows\system32\windowspowershell\v1.0\powershell.exe
                     █ Call arguments:  -NoProfile -Command
                     █ Version:
                     █   Name                           Value
                     █   ----                           -----
                     █   PSVersion                      5.1.22621.3958
                     █   PSEdition                      Desktop
                     █   PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
                     █   BuildVersion                   10.0.22621.3958
                     █   CLRVersion                     4.0.30319.42000
                     █   WSManStackVersion              3.0
                     █   PSRemotingProtocolVersion      2.3
                     █   SerializationVersion           <IP_ADDRESS>
                     ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
[21-Aug-24 00:41:37] Microsoft.Powershell.Client detection has been forcefully skipped as the module is not required on the current context
[21-Aug-24 00:41:37] Dependency WinGet PowerShell Module for manager Winget is present
[21-Aug-24 00:41:37] LoadComponentsAsync finished executing. All managers loaded. Proceeding to interface.
[21-Aug-24 00:41:38] Found 0 installed packages from PowerShell7
[21-Aug-24 00:41:38] Found 0 available updates from PowerShell7
[21-Aug-24 00:41:38] Found 1 installed packages from PowerShell
[21-Aug-24 00:41:42] Found 0 available updates from PowerShell
[21-Aug-24 00:41:46] Found 8 available updates from Winget
[21-Aug-24 00:41:46] Found 734 installed packages from Winget
[21-Aug-24 01:28:04] Found 0 installed packages from PowerShell7
[21-Aug-24 01:28:04] Found 1 installed packages from PowerShell
[21-Aug-24 01:28:08] Found 734 installed packages from Winget
[21-Aug-24 01:29:58] Found 0 available updates from PowerShell7
[21-Aug-24 01:29:59] Found 0 available updates from PowerShell
[21-Aug-24 01:30:02] Found 7 available updates from Winget
[21-Aug-24 01:30:07] Non-MSStore WinGet Native Icons have been forcefully disabled on code
[21-Aug-24 01:30:07] Icon for package GitHub.cli was not found, returning default icon
[21-Aug-24 01:30:07] Non-MSStore WinGet Native Icons have been forcefully disabled on code
[21-Aug-24 01:30:07] Icon for package GOG.Galaxy was not found, returning default icon
[21-Aug-24 01:41:35] UniGetUI is up to date
[21-Aug-24 01:46:58] Found 0 installed packages from PowerShell7
[21-Aug-24 01:46:58] Found 1 installed packages from PowerShell
[21-Aug-24 01:47:04] Found 734 installed packages from Winget
[21-Aug-24 02:41:36] UniGetUI is up to date
[21-Aug-24 03:41:37] UniGetUI is up to date
[21-Aug-24 04:41:37] UniGetUI is up to date
[21-Aug-24 05:04:17] Found 0 installed packages from PowerShell7
[21-Aug-24 05:04:17] Found 1 installed packages from PowerShell
[21-Aug-24 05:04:23] Found 734 installed packages from Winget
[21-Aug-24 05:04:27] Found 0 available updates from PowerShell7
[21-Aug-24 05:04:29] Found 0 available updates from PowerShell
[21-Aug-24 05:04:32] Found 6 available updates from Winget
[21-Aug-24 05:07:40] Found 0 installed packages from PowerShell7
[21-Aug-24 05:07:41] Found 1 installed packages from PowerShell
[21-Aug-24 05:07:45] Found 734 installed packages from Winget
[21-Aug-24 05:07:48] Found 0 available updates from PowerShell7
[21-Aug-24 05:07:50] Found 0 available updates from PowerShell
[21-Aug-24 05:07:53] Found 6 available updates from Winget
[21-Aug-24 05:08:41] Found 0 available updates from PowerShell7
[21-Aug-24 05:08:43] Found 0 available updates from PowerShell
[21-Aug-24 05:08:49] Found 5 available updates from Winget
[21-Aug-24 05:32:36] Found 0 installed packages from PowerShell7
[21-Aug-24 05:32:37] Found 1 installed packages from PowerShell
[21-Aug-24 05:32:41] Found 734 installed packages from Winget

Package Managers Logs
Manager WinGet with version:
System WinGet CLI Version: v1.8.1911
Microsoft.WinGet.Client PSModule version: ""
Using Native WinGet helper (COM Api)

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListSources
Process start time: 21-Aug-24 00:41:35
Process end time:   21-Aug-24 00:41:35

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged subprocess-based task on manager Winget. Task type is RefreshIndexes
Subprocess executable: "C:\Users\Byakuga\AppData\Local\Microsoft\WindowsApps\winget.exe"
Command-line arguments: " source update --disable-interactivity"
Process start time: 21-Aug-24 00:41:36
Process end time:   21-Aug-24 00:41:39

-- Process STDOUT
 ...

Return code: SUCCESS (0)

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListInstalledPackages
Process start time: 21-Aug-24 00:41:37
Process end time:   21-Aug-24 00:41:46

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListSources
Process start time: 21-Aug-24 00:41:37
Process end time:   21-Aug-24 00:41:37

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListUpdates
Process start time: 21-Aug-24 00:41:39
Process end time:   21-Aug-24 00:41:46

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListInstalledPackages
Process start time: 21-Aug-24 01:28:03
Process end time:   21-Aug-24 01:28:08

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged subprocess-based task on manager Winget. Task type is RefreshIndexes
Subprocess executable: "C:\Users\Byakuga\AppData\Local\Microsoft\WindowsApps\winget.exe"
Command-line arguments: " source update --disable-interactivity"
Process start time: 21-Aug-24 01:29:57
Process end time:   21-Aug-24 01:29:57

-- Process STDOUT
 ...

Return code: SUCCESS (0)

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListUpdates
Process start time: 21-Aug-24 01:29:57
Process end time:   21-Aug-24 01:30:02

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListInstalledPackages
Process start time: 21-Aug-24 01:46:56
Process end time:   21-Aug-24 01:47:04

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListInstalledPackages
Process start time: 21-Aug-24 05:04:15
Process end time:   21-Aug-24 05:04:23

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged subprocess-based task on manager Winget. Task type is RefreshIndexes
Subprocess executable: "C:\Users\Byakuga\AppData\Local\Microsoft\WindowsApps\winget.exe"
Command-line arguments: " source update --disable-interactivity"
Process start time: 21-Aug-24 05:04:26
Process end time:   21-Aug-24 05:04:27

-- Process STDOUT
 ...

Return code: SUCCESS (0)

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListUpdates
Process start time: 21-Aug-24 05:04:27
Process end time:   21-Aug-24 05:04:32

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListInstalledPackages
Process start time: 21-Aug-24 05:07:39
Process end time:   21-Aug-24 05:07:45

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged subprocess-based task on manager Winget. Task type is RefreshIndexes
Subprocess executable: "C:\Users\Byakuga\AppData\Local\Microsoft\WindowsApps\winget.exe"
Command-line arguments: " source update --disable-interactivity"
Process start time: 21-Aug-24 05:07:47
Process end time:   21-Aug-24 05:07:48

-- Process STDOUT
 ...

Return code: SUCCESS (0)

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListUpdates
Process start time: 21-Aug-24 05:07:48
Process end time:   21-Aug-24 05:07:53

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged subprocess-based task on manager Winget. Task type is RefreshIndexes
Subprocess executable: "C:\Users\Byakuga\AppData\Local\Microsoft\WindowsApps\winget.exe"
Command-line arguments: " source update --disable-interactivity"
Process start time: 21-Aug-24 05:08:40
Process end time:   21-Aug-24 05:08:40

-- Process STDOUT
 ...

Return code: SUCCESS (0)

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListUpdates
Process start time: 21-Aug-24 05:08:40
Process end time:   21-Aug-24 05:08:49

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListInstalledPackages
Process start time: 21-Aug-24 05:32:35
Process end time:   21-Aug-24 05:32:41

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListInstalledPackages
Process start time: 21-Aug-24 05:33:46
Process end time:   21-Aug-24 05:33:52

-- Task information
 ...

The task reported success

——————————————————————————————————————————

Logged native task on manager Winget. Task type is ListInstalledPackages
Process start time: 21-Aug-24 05:34:22
Process end time:   UNFINISHED

-- Task information
 ...

The task has not finished yet

——————————————————————————————————————————

Relevant information
No response
Screenshots and videos
No response

I will investigate


[WIP] JPA example

Right now, this all uses synchronous, blocking calls and does not share a transaction with the offset store.

This is ready for an overall review of the approach, but I won't merge it until the JPA implementation is moved over to Lagom and used here.


Corrected return values

The review values were incorrect.

@GrantMeStrength : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@GrantMeStrength : Thanks for your contribution! The author(s) have been notified to review your proposed change.


'infiniband/verbs.h' file not found

ERROR: /Users/abc/tensorflow/tensorflow/contrib/verbs/BUILD:90:1: C++ compilation of rule '//tensorflow/contrib/verbs:rdma_rendezvous_mgr' failed (Exit 1)
In file included from tensorflow/contrib/verbs/rdma_rendezvous_mgr.cc:18:
In file included from ./tensorflow/contrib/verbs/rdma_rendezvous_mgr.h:21:
In file included from ./tensorflow/contrib/verbs/rdma_mgr.h:24:
./tensorflow/contrib/verbs/rdma.h:21:10: fatal error: 'infiniband/verbs.h' file not found
#include <infiniband/verbs.h>

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

Have I written custom code: No
OS Platform and Distribution: Mac OS 10.13.2
TensorFlow installed from: Github
TensorFlow version: r1.8
Bazel version: 0.13.1-homebrew
CUDA/cuDNN version: N/A
GPU model and memory: N/A
Exact command to reproduce: are following
$ cd tensorflow  # cd to the top-level directory created
$ ./configure
Do you wish to build TensorFlow with Google Cloud Platform support? [y/N]Y
Do you wish to build TensorFlow with Hadoop File System support? [y/N]
Do you wish to build TensorFlow with the XLA just-in-time compiler? [y/N]Y
Do you wish to build TensorFlow with VERBS support? [y/N]Y
Do you wish to build TensorFlow with OpenCL support? [y/N]
Do you wish to build TensorFlow with CUDA support? [y/N] N
$ bazel build --config=opt //tensorflow/tools/pip_package:build_pip_package

When configuring with all default option that is all No it worked. Its only occurs when in configuration I select for VERBS support I guess
I have checked the code of the file /tensorflow/contrib/verbs/rdma.h and its including infiniband/verbs.h
#include <infiniband/verbs.h>
But there is no such file anywhere.

If you want verbs support, you need to have installed the necessary OFED components, which would provide this header file among other things.  If you don't have InfiniBand (or RoCE), then you don't need IB verbs.

Thanks, @cliffwoolley . @quadrixm - does installing the necessary components resolve your issue?


awk.Begin

Example shows awk.Begin being used as global pattern function but this doesn't compile.  Current version of awk package doesn't define it.  Example code sets s.Begin directly.  Probably just the example code needs updating.

You're absolutely right.  Commit 69e06a4994a6dc21de78b1c583838dea834abf6f updates the awk package's README.md file to show instead an assignment to the Script's Begin field.
Thanks for the bug report.


nsc-events_sprint_12_issue_561

Please fill out this description with the following:
Resolves 561
Description of what this pull request is for.
This pull request  updates the typescript config file to follow recommendations from material ui.
Screenshot:

Hello,
The changes look good, I see you implemented the minimum configuration guidelines from the MUI website. Since this is a change that affects GH actions workflow as stated in #561, how would one test this PR?

Great job working on the TypeScript config file! I ran all the unit tests after the changes, and everything works successfully. All six test suites, including creator.test.tsx, admin.test.tsx, signin.test.tsx, and signup.test.tsx, executed without any issues, confirming that the TypeScript settings are properly integrated. The tests took around 8.5 seconds in total.
Here’s a useful resource: TypeScript Compiler Options Explained.

Student is not participating this term so I am going to close so someone else can complete this PR


What is the unit in the box in the picture?

E：Physical MEM size in the file "/proc/" + spid + "/statm"  Unit: K (to be examined)
C："/proc/" + spid + "/statm"这个文件里面的, physical mem size，单位为K（待考证）


Scroll doesn't work with external mouse

Scrolling the list only seems to work with the onboard mac trackpad. Scrolling the mouse wheel over the area does not work.

Thanks for mentioning @aioue! It looks like preventing the user from zoom - was also disabling the mouse-wheel! Will include it in the next release! :ship:


Implement Rabin-Karp algorithm for String#rindex

Reverse version of this.
Benchmark is here.
My result is:
$ crystal run --release rindex_bench.cr
For long string:
       rindex_old 258.31  (  3.87ms) (± 6.69%) 11.04× slower
rindex_rabin_karp   2.85k ( 350.8µs) (± 6.77%)       fastest
For short string:
       short_rindex_old   1.92M (520.84ns) (± 6.08%)  2.66× slower
short_rindex_rabin_karp   5.11M (195.87ns) (± 8.64%)       fastest

(I recommend you run this benchmark on your environment ;)

Is it faster for short and long strings?

Old implementation is to scan string from head to end, and short string benchmark has no match but long string benchmark has match in middle of string, so long string benchmark is better score. Generally, the longer string length is, the better score.

Rabin-Karp is also faster for shorter strings. The old algorithm was very naive, for every char in the string check if there's a match from there on, so O(n*m), and Rabin-Karp will almost always be faster because of it's rolling hash algorithm.
Note that I knew the old algorithm was slow, it just wasn't a priority to improve it. There are many parts in the std that could use an optimization review.
@MakeNowJust By the way, there's also String#byte_index that currently has a very slow algorithm but could use Rabin-Karp (and it's easier, because it's byte index, not char index)

@asterite I have known it. I'll work tomorrow. Good night...

Awesome! Crystal is already quite fast; but I won't complain if it gets even faster! :)

I posted a possible improvement to the algorithm in the previous (for index) change #3873. I think it should be reviewed before merging this copy of it.

@MaxLap Your idea is awesome, but I think we cannot apply it to String#rindex.

@bcardiff Rebased

Ah, i see what you mean. A check could still be made to do another step unless the current byte is a valid starting one, but there may be less to gain here. You could still try it if you want.
if (byte & 0x80) == 0 || (byte & 0x40) != 0 is the same as if (byte & 0xC0) != 0x80. But maybe the compiler handles that one itself.

Keep up the great work people 🎉 😍

@MaxLap Thanks. I applied some optimizations.

Thanks @MakeNowJust and @MaxLap ! ⚡ ⚡

little changed behavior after this:
0.20.4
crystal eval 'p "".includes?("")'
true

0.20.5
crystal eval 'p "".includes?("")'
false

not sure what is really correct.

In Ruby:
2.4.0 :001 > 'p ""'.include?("")
 => true

Really? for me, on 0.20.5, I still get true O_o

ops i miss versions, fixed

True would be the same result as "".include?("") in ruby.
It may be interesting to add this edge case to the specs.


CODEOWNERS displays error to anonymous

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
If you visit https://github.com/github/docs/blob/main/.github/CODEOWNERS, you'll notice the linting error visible:
Unknown owner on line 10: make sure the team @github/oidc exists, is publicly visible, and has write access to the repository

…hardening-your-deployments/** @github/oidc

It is visible whether you're logged in or out of GitHub.

What changes are you suggesting?
Suggestion:

Hide linting errors unless you're either logged in to GitHub or have write access to the file

Perhaps, also set the team @github/oidc as public to fix the initial linting error.
Additional information
No response

@dan2k3k4 Thanks so much for opening an issue! I'll triage this for the team to take a look :eyes:

👋 !  That's expected with our setup:
https://github.com/github/docs/blob/b0b1a121f20a49ad3e97a010a4ee048333015043/README.md#L5
So internally in the private repo we might have some teams that will review particular changes but those teams won't be publicly visible.

Closing this issue per comment above 💛
Please take a look at our help wanted section to find open issues you can work on.
Thank you for your interest in improving GitHub Docs! :sparkling_heart:


Add two new vanguard HP/reset threshold render locations.

IMO it makes it a lot easier to see the reset threshold or current HP when there are lot of hitsplats on the NPC. Default behaviour is to draw it in the current location.
Below:

Above:

Below:
https://imgur.com/VkKUhgB


Slow startup performance for VSCode-Insiders

VSCode Version: Code - Insiders 1.11.0-insider (4db944bc08e34fb15c5805927d9cb67470776606, 2017-03-02T07:10:18.838Z)
OS Version: Windows_NT ia32 10.0.14393
CPUs: Intel(R) Core(TM) i7-4700MQ CPU @ 2.40GHz (8 x 2394)
Memory (System): 31.93GB (21.70GB free)
Memory (Process): 137.59MB working set (137.61MB peak, 113.88MB private, 27.49MB shared)
Load (avg): 0, 0, 0
VM: 0%
Initial Startup: yes
Screen Reader: no
Empty Workspace: no
Timings:

Component
Task
Time (ms)

main
start => app.isReady
133

main
app.isReady => window.loadUrl()
1059

renderer
window.loadUrl() => begin to require(workbench.main.js)
2203

renderer
require(workbench.main.js)
1198

renderer
create extension host => extensions onReady()
3157

renderer
restore viewlet
2431

renderer
restore editor view state
2231

renderer
overall workbench load
4272

main + renderer
start => extensions ready
8252

main + renderer
start => workbench ready
8897

7027_main.cpuprofile.txt
7027_renderer.cpuprofile.txt
:warning: Make sure to attach these files: :warning:

profile files are missing


update rcnn example to Faster R-CNN

Due to Commit 0ad34c9bada6eb3a5e11c8b56b7e36ddaa214bfd cudnn auto tuning, training speed has been decreased to 0.3 samples/sec, with 5+ samples/sec as the usual case. For this reason, we have not proceeded our attempts at finalizing details on the new Module API, nor added "fix_param_names" and set grad_req to null to Module.
To run this example, prepare data according to this outdated README and use python -m tools.train_rpn and python -m tools.train_rcnn.

It's due to auto tune being run for each bucket. For the moment you can turn it off with cudnn_tune=False.
@tqchen What would be a better solution?

@piiswrong Would it be better to turn off the auto-tuning by default?

I'm thinking about it. The thing is in most cases (without bucketing) it improves performance by 20%


Switch to correct upstream repo/image

Close/reopen to see if a build will happen

This is very similar to the changes pushed to jenkinsci/docker-slave which was approved, so I am going to merge it.


neon-cluster-operator needs a custom resource to manage settings

[x] V1NeonClusterOperator resource

[x] CA update schedule: CRON format?
[x] Security patch schedule: CRON format?
[x] Status where the operator can persist when it last performed operations, etc.

[x] Detect missing harbor images and create nodetasks to have nodes push these
[x] Add Priority class to Harbor pods: #1414

done


Update Examples README

README for the examples/ directory is made up-to-date with this PR. Let me know if any changes are required.

Thanks @a-r-r-o-w , this is very helpful.


Dynamically allocate context ID ranges to slaves

If code in a slave calls Router.connect(), it will currently try to allocate a new context ID starting at 1 just like in the master, which is incorrect.
Instead have the slave's router make a call to the master requesting an ID range during the first connect attempt, and allocate from that range instead.

A single-ID version of this was implemented in 491b5ab575dc7eec709e7aabc2f1e7b323b7800f and 5fc59f72cbcde42ea14a690c7031fe05b9c2649c


Added Binomial Expansion Calculator

Fixes Issue🛠
Closes #1276
Description👨💻
I have added a binomial expansion calculator.
Type of Change📄

[x] New feature (non-breaking change which adds functionality)

Checklist✅

[x] I am an Open Source contributor
[x] I have performed a self-review of my code
[x] My code follows the style guidelines of this project

Screenshots/GIF📷

@DharshiBalasubramaniyam What if any of the variable is 0.  Still it shows empty field error.

@DharshiBalasubramaniyam What if any of the variable is 0. Still it shows empty field error.

@Nihal4777 @Rakesh9100 Now that error is fixed


Note Icon support

This PR adds the following items in the appearance settings:

Key for note icons (To set which key from frontmatter should be used for note icons, defaults to dg-note-icon)
Default note icon value (To be used for fallback)
Show in Filetree
Show in Internal Links
Show in Title

It transports values from 2-5 to the sites .env file and processes note accordingly to add maturity values.

@oleeskild once implemented, I noticed that this is a more generic feature. Instead of Maturity, we can name it note icons because you can virtually add any note icon this way.

I made the changes that were needed. The only user-facing change is from dg-maturity to dg-note-icon, which is also configurable in settings.

Hi, how would I make it so there's no note icon

Hi, how would I make it so there's no note icon

In settings, there are 3 toggles to disable note icons from title, filetree, and internal links.

@uroybd I have those toggles off, but it doesn't seem to work for the filetree.
With the toggle on, this icon shows up:

And with the toggle off, this icon shows up:

@uroybd I have those toggles off, but it doesn't seem to work for the filetree.
With the toggle on, this icon shows up:

And with the toggle off, this icon shows up:

These were the generic icons used previously. @oleeskild should we keep them or make filetree completely iconless with the toggle?


Add fls-eu.amazon.com and fls-na.amazon.com for prime video to work

Theses hosts are in https://hosts-file.net/ad_servers.txt, but they need to be accessed to watch something on amazon prime video.
Could you add them ? (fls-eu.amazon.com and fls-na.amazon.com )

It breaks Amazon Prime on Apple TV. You can browse and select a video, but when starting one the loading icon stays there forever.


Merge pull request #1 from jerryscript-project/master

sync from upstream

I'm not sure what these recent PRs are ("Merge pull request #xxx from jerryscript-project/master") but they don't look like the proper way of keeping user forks in sync with main project master branch. Especially as they appear as PRs here (causing nose at the very least).
@jack60504 @lidingchao if you need help with git / github, don't hesitate to ask at irc (freenode #jerryscript).


including HTTP in the src attribute

The code wouldn't work if the http was not included in the src attribute. I made the changes to make it work.

@pvskand

Won't work for HTTPS
The behavior is browser/host dependent


travis: do a "cargo check" (no codegen) for all crates

This shows a failure in stm32l100 that seems legit...

I'm tracking down the build failure, by the way. Half resolved.

If you rebase onto master the build will hopefully succeed.

Passing :fireworks: The build takes about 30 minutes on Travis, which I guess is fair enough, it has to build 46 crates.
Each build uses its own target directory since otherwise the 2 cores offered by Travis can't straightforwardly be used in parallel, since the same crate is built multiple times leading to interlocks. On the other hand, the artifacts that could be shared only take a few seconds to compile.
I also tried building each crate in one go with all supported features, but it led to OOM and timeouts.

Looks good, thanks!