VSCode + adsf-vm

I was trying to use this extension from WSL2 but it seems formating and potentially other things, do not work.
2020-02-14 12:02:19:632 [INFO ] formatting-provider: running 'terraform fmt' on '/home/pecigonzalo/Workspace/src/3tier-app/infrastructure/domain.tf'
2020-02-14 12:02:19:633 [ERROR] formatting-provider: formatting failed. TypeError: Cannot read property 'path' of null

I was going through the code to try and find the reason, and I believe its related to the findInPath method. https://github.com/mauve/vscode-terraform/blob/master/src/runner.ts#L201
It's using process.env.PATH which I don't know how it behaves in VSCode Remote, but before attempting a fix I'm trying to understand why we are doing this.
We should be able to use terraform directly without finding a path and letting the user set a full path if not in PATH.
There is also a "version" finder here: https://github.com/mauve/vscode-terraform/blob/master/src/runner/version.ts which I cant find documentation for. As far as I understand the code it checks the version defined by terraform is the same as the one in the runner. IMO this is the job of the CLI and not of these extensions.
I also find we can define path and paths as extension options, but the usage of paths is not documented.
If you could help me out with these questions I might be able to put a PR to fix the path for VSCode Remote.

I found the problem is related to https://asdf-vm.com/ (and potentially any terraform version manager) due to that https://github.com/mauve/vscode-terraform/blob/master/src/runner/version.ts and version checkers.
Because terraform version does not run in the context of the workspace folder, asdf is unable to detect what version to use.

I believe we should move the function getTerraformVersion to be a method of the class Runner, it would make sense given the runner runs a version command to get it.
Then it should use the cwd constant to run in the correct folder. Let me know your thought and ill craft a PR.

@pecigonzalo This is a problem I would like to solve. Perhaps there's a change we can make to the asdf-terraform plugin that performs the required setup to make this work 🤔

I think defaulting this tool to terraform in terraform.path is the best approach.

@pecigonzalo Mine was already set to terraform

and yet I still had this issue. I might be misunderstanding your previous explanations

Did you run vscode in the context of the folder?

The Terraform codefiles are subfolders in the VSCode project.
I did just see this error, so something new to investigate
2020-03-23 11:49:31:139 [ERROR] formatting-provider: formatting failed. TypeError: Cannot read property 'path' of null

Yeah, that was the error I was getting, you also need to set a global terraform version in asdf I think, because the version checking code might not respect the path config. 🤷♂

Thanks, that worked. So for future people running into this issue:

check Terraform is set in the VSCode Ext path field as in the screenshot above
set your asdf global terraform version
restart VSCode (literally CMD + Q quit the application as a restart on macOS didn't do this for me).


Add installation of OpenCV to install script

Well yeah the sudo wasn't there for make install that's why I didn't do it either


Block fixes

Do not merge.
We will test some more blocks.

@Howaner?

Though there are some potentially good bugfixes here.

Yes, but the branch would need a lot of work to be mergable, and no one is currently working on it.


Getting an undefined symbol error

Hi Team,
Getting this error:
ImportError: /opt/conda/lib/python3.8/site-packages/fused_layer_norm_cuda.cpython-38-x86_64-linux-gnu.so: undefined symbol: _ZNK2at6Tensor7optionsEv

Hey,
This could be due to some errors in nvidia apex installation.
I found a similar issue here. Can you please check that out?

@gowtham1997
In the Dockerfile, the commands to install apex are commented.
Is it done on purpose?

@gowtham1997 If I am using docker, I should not have this error.


DEPRECATION: pykitinfo <IP_ADDRESS> has a non-standard dependency specifier pyedbglib

(py310x64venv) PS>pip install pykitinfo --upgrade
Collecting pykitinfo
  Downloading pykitinfo-<IP_ADDRESS>-py3-none-any.whl (19 kB)
Requirement already satisfied: pyusb>=1.2.0 in c:\work\python\py310x64venv\lib\site-packages (from pykitinfo) (1.2.1)
Requirement already satisfied: PyYAML in c:\work\python\py310x64venv\lib\site-packages (from pykitinfo) (6.0)
Requirement already satisfied: appdirs in c:\work\python\py310x64venv\lib\site-packages (from pykitinfo) (1.4.4)
Requirement already satisfied: pyedbglib>=2.22.* in c:\work\python\py310x64venv\lib\site-packages (from pykitinfo) (<IP_ADDRESS>)
Collecting pydebuggerconfig>=3.5 (from pykitinfo)
  Downloading pydebuggerconfig-<IP_ADDRESS>-py3-none-any.whl (217 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 217.5/217.5 kB 6.7 MB/s eta 0:00:00
Collecting crcmod (from pydebuggerconfig>=3.5->pykitinfo)
  Downloading crcmod-1.7.tar.gz (89 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 89.7/89.7 kB ? eta 0:00:00
  Preparing metadata (setup.py) ... done
Requirement already satisfied: packaging in c:\work\python\py310x64venv\lib\site-packages (from pydebuggerconfig>=3.5->pykitinfo) (23.0)
Requirement already satisfied: IntelHex in c:\work\python\py310x64venv\lib\site-packages (from pydebuggerconfig>=3.5->pykitinfo) (2.3.0)
Collecting xmlschema (from pydebuggerconfig>=3.5->pykitinfo)
  Downloading xmlschema-2.5.0-py3-none-any.whl.metadata (8.3 kB)
Requirement already satisfied: pyserial>=3.5 in c:\work\python\py310x64venv\lib\site-packages (from pyedbglib>=2.22.*->pykitinfo) (3.5)
Requirement already satisfied: cython in c:\work\python\py310x64venv\lib\site-packages (from pyedbglib>=2.22.*->pykitinfo) (3.0.0)
Requirement already satisfied: hidapi in c:\work\python\py310x64venv\lib\site-packages (from pyedbglib>=2.22.*->pykitinfo) (0.14.0)
Requirement already satisfied: setuptools>=19.0 in c:\work\python\py310x64venv\lib\site-packages (from hidapi->pyedbglib>=2.22.*->pykitinfo) (65.5.0)
Collecting elementpath<5.0.0,>=4.1.5 (from xmlschema->pydebuggerconfig>=3.5->pykitinfo)
  Downloading elementpath-4.1.5-py3-none-any.whl.metadata (6.7 kB)
Downloading xmlschema-2.5.0-py3-none-any.whl (395 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 395.0/395.0 kB 25.7 MB/s eta 0:00:00
Downloading elementpath-4.1.5-py3-none-any.whl (216 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 216.4/216.4 kB ? eta 0:00:00
Building wheels for collected packages: crcmod
  Building wheel for crcmod (setup.py) ... done
  Created wheel for crcmod: filename=crcmod-1.7-cp310-cp310-win_amd64.whl size=25182 sha256=f7b562382e0704525b6aa9638df7b4375a65006fd026b1bf307cb8c99dc6ce6e
  Stored in directory: c:\users\xiaof\appdata\local\pip\cache\wheels\85\4c\07\72215c529bd59d67e3dac29711d7aba1b692f543c808ba9e86
Successfully built crcmod
DEPRECATION: pykitinfo <IP_ADDRESS> has a non-standard dependency specifier pyedbglib>=2.22.*. pip 24.0 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of pykitinfo or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at https://github.com/pypa/pip/issues/12063
Installing collected packages: crcmod, elementpath, xmlschema, pydebuggerconfig, pykitinfo
Successfully installed crcmod-1.7 elementpath-4.1.5 pydebuggerconfig-<IP_ADDRESS> pykitinfo-<IP_ADDRESS> xmlschema-2.5.0

Fixed in 1.0.3


Issue with MWF noise calculation

We noticed that multi_comp_fit.m has a very poor way to estimate the sigma of the noise
function sigma = calc_bkgrnd_noise(data_vol, data_dim)

slices = data_dim(1,3);
height = data_dim(1,1);
width = data_dim(1,2);
voxels = height*width;
num_echoes = data_dim(1,4);

%--------------------------------------------------------------------------
% Calculate background noise

% "default" noise level...
sigma(1:slices) = 1;

% Prepare noise mask
noise_mask = zeros(height,width,slices);

% Pick four corners of 5x5
noise_mask(1:5,1:5,:) = 1;
noise_mask(1:5,end-5:end,:) = 1;
noise_mask(end-5:end,1:5,:) = 1;
noise_mask(end-5:end,end-5:end,:) = 1;

% apply mask to the data
for slice = 1:slices
    for frame = 1:num_echoes
        noise_data(:,:,slice,frame) = data_vol(:,:,slice,frame).*noise_mask(:,:,slice);
    end
end

noise_data = reshape(noise_data, voxels, slices, num_echoes);

for slice = 1:slices
    for frame = 1:num_echoes
        std_noise(slice,frame) = std(nonzeros(noise_data(:,slice,frame)));
    end
end

for slice = 1:slices
    sigma(slice) = mean(std_noise(slice,:));
end

end

Indeed, it simply picks the 4 corners of MET2 data, finds the standard deviation (std) for each slice and takes the mean of all std. Instead of that, we propose to use PIESNO algorithm to estimate the noise and therefore find sigma. https://www.ncbi.nlm.nih.gov/pubmed/19346143
To do so, there are 2 main possibilities:

Ask Koay (the author) to obtain his Java script and consent to add it to qMRLab
Directly implement the algorithm in Matlab

Let me know what's best! @jcohenadad @tanguyduval  @mathieuboudreau
Ian

Thanks for this investigation Ian,
First of all:

Plz add sigma has an option for MWF
Create a new ''Model'' Noise/NoiseLevel.m. Inputs: 4Ddata, NoiseMask. Voxelwise=0; Output: sigma. You can fit the noise histogram using a function like https://www.mathworks.com/matlabcentral/fileexchange/54244-histfit-noncentralchi

Concerning PIESNO.
Koay shares his code here: https://sites.google.com/site/hispeedpackets/
It's a java code so it's compatible with Matlab (a Matlab example already exists). However:
This archive does not contain the jar file, which is needed to "run" the software packets.
To obtain this jar file (compiled using Java JDK 1.7), your statement of consent to the software agreement is needed.

So in my opinion
1- Ask Koay if he agrees to share the code for qMRLab
2- If not implement it.
In the future, we will create a model Noise/PIESNO.m. Input: 4d Data. Output: NoiseMask, sigma.
Best


Fixing host name validation.

Fixing the order of parameters passed to "validateHostname" method.

True, according to RFC2109 a cookie should be rejected if its request url does not domain-match the domain string. RFC6265 states, that a request url domain-matches a domain string, if the domain string is a suffix of the hostname of the request url.
So a cookie received from foo.bar can be set for the domain bar, but a cookie received from bar can't be set for foo.bar.
As you correctly noticed, the existing code checks it the other way around. Thanks for the fix!


Change D compiler flags based on whether compilation_mode is dbg/fastbuild/opt

On Windows the new cpp_string_test verifies that the same C++ runtime is being used by the C++ compiler and the D compiler or linking fails.

The code looks good. Can you update the description? It looks odd

Updated docstring and commit message. Better?


Handle index_id mismatch

Description
Closes https://github.com/quickwit-inc/quickwit/issues/524
How was this PR tested?
Ran the cli commands while tampering index_id in quickwit.json file.

Thanks!


create DiskPool - Timout

Hello
I'm trying to add more disk pools to a 5 node microk8s cluster.
The first disk pools on NVMEs could be initialized without any problems.
When adding disk pools on normal HDDs, the following behavior occurs:
apiVersion: "openebs.io/v1beta2"
kind: DiskPool
metadata:
  name: pool-doc-k8s1-hdd1-test
  namespace: openebs
spec:
  node: doc-k8s1
  disks: ["aio:///dev/disk/by-id/scsi-35000cca2531e679c?blk_size=4096"]
  topology:
    labelled:
        class: hdd

kubectl events -n openebs
Critical   Failure   DiskPool/pool-doc-k8s1-hdd1-test   Unable to create or import pool error in request: request timed out
Critical   Failure   DiskPool/pool-doc-k8s1-hdd1-test   Unable to create or import pool error in response: status code '409 Conflict', content: 'RestJsonError { details: "", message: "SvcError :: Deleting: Pool Resource pending deletion - please retry", kind: Deleting }'

kubectl -n openebs get diskpools
NAME                      NODE       STATE      POOL_STATUS   CAPACITY       USED          AVAILABLE
pool-doc-k8s1-hdd1-test   doc-k8s1   Creating                 0              0             0
pool-doc-k8s1-nvme        doc-k8s1   Created    Online<PHONE_NUMBER>48   0<PHONE_NUMBER>48
pool-doc-k8s2-nvme        doc-k8s2   Created    Online<PHONE_NUMBER>48   0<PHONE_NUMBER>48
pool-doc-k8s3-nvme        doc-k8s3   Created    Online<PHONE_NUMBER>48   0<PHONE_NUMBER>48
pool-doc-k8s4-nvme        doc-k8s4   Created    Online<PHONE_NUMBER>16   0<PHONE_NUMBER>16
pool-doc-k8s5-nvme        doc-k8s5   Created    Online<PHONE_NUMBER>20<PHONE_NUMBER>6<PHONE_NUMBER>44

kubectl -n openebs logs deployment.apps/openebs-agent-core -f
2024-12-18T08:54:28.545368Z ERROR core::controller::io_engine::v1::pool: error: gRPC request 'create_pool' for 'Pool' failed with 'status: Cancelled, message: "Timeout expired", details: [], metadata: MetadataMap { headers: {} }'
    at control-plane/agents/src/bin/core/controller/io_engine/v1/pool.rs:33
    in core::pool::service::create_pool with request: CreatePool { node: NodeId("doc-k8s1"), id: PoolId("pool-doc-k8s1-hdd1-test"), disks: [PoolDeviceUri("aio:///dev/disk/by-id/scsi-35000cca2531e679c?blk_size=4096")], labels: Some({"class": "hdd", "openebs.io/created-by": "operator-diskpool"}) }, pool.id: pool-doc-k8s1-hdd1-test

  2024-12-18T08:54:28.551120Z ERROR core::pool::service: error: gRPC request 'create_pool' for 'Pool' failed with 'status: Cancelled, message: "Timeout expired", details: [], metadata: MetadataMap { headers: {} }'
    at control-plane/agents/src/bin/core/pool/service.rs:318
    in core::pool::service::create_pool with request: CreatePool { node: NodeId("doc-k8s1"), id: PoolId("pool-doc-k8s1-hdd1-test"), disks: [PoolDeviceUri("aio:///dev/disk/by-id/scsi-35000cca2531e679c?blk_size=4096")], labels: Some({"class": "hdd", "openebs.io/created-by": "operator-diskpool"}) }, pool.id: pool-doc-k8s1-hdd1-test

  2024-12-18T08:54:30.727593Z ERROR core::controller::io_engine::v1::pool: error: gRPC request 'destroy_pool' for 'Pool' failed with 'status: NotFound, message: "Pool NameUuid { name: \"pool-doc-k8s1-hdd1-test\", uuid: None } not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 18 Dec 2024 08:54:30 GMT", "content-length": "0"} }'
    at control-plane/agents/src/bin/core/controller/io_engine/v1/pool.rs:61
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:54:30.728961Z ERROR core::controller::io_engine::v1::pool: error: gRPC request 'import_pool' for 'Pool' failed with 'status: Aborted, message: "Failed to acquire lock for the resource: pool-doc-k8s1-hdd1-test, lock already held", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 18 Dec 2024 08:54:30 GMT", "content-length": "0"} }'
    at control-plane/agents/src/bin/core/controller/io_engine/v1/pool.rs:74
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:54:30.731620Z ERROR core::controller::reconciler::pool: Failed to delete the pool, error: gRPC request 'import_pool' for 'Pool' failed with 'status: Aborted, message: "Failed to acquire lock for the resource: pool-doc-k8s1-hdd1-test, lock already held", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 18 Dec 2024 08:54:30 GMT", "content-length": "0"} }'
    at control-plane/agents/src/bin/core/controller/reconciler/pool/mod.rs:205
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:54:33.679159Z ERROR core::pool::service: error: Pool Resource pending deletion - please retry
    at control-plane/agents/src/bin/core/pool/service.rs:318
    in core::pool::service::create_pool with request: CreatePool { node: NodeId("doc-k8s1"), id: PoolId("pool-doc-k8s1-hdd1-test"), disks: [PoolDeviceUri("aio:///dev/disk/by-id/scsi-35000cca2531e679c?blk_size=4096")], labels: Some({"openebs.io/created-by": "operator-diskpool", "class": "hdd"}) }, pool.id: pool-doc-k8s1-hdd1-test

  2024-12-18T08:54:40.739636Z ERROR core::controller::io_engine::v1::pool: error: gRPC request 'destroy_pool' for 'Pool' failed with 'status: NotFound, message: "Pool NameUuid { name: \"pool-doc-k8s1-hdd1-test\", uuid: None } not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 18 Dec 2024 08:54:40 GMT", "content-length": "0"} }'
    at control-plane/agents/src/bin/core/controller/io_engine/v1/pool.rs:61
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:54:40.740962Z ERROR core::controller::io_engine::v1::pool: error: gRPC request 'import_pool' for 'Pool' failed with 'status: Aborted, message: "Failed to acquire lock for the resource: pool-doc-k8s1-hdd1-test, lock already held", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 18 Dec 2024 08:54:40 GMT", "content-length": "0"} }'
    at control-plane/agents/src/bin/core/controller/io_engine/v1/pool.rs:74
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:54:40.743605Z ERROR core::controller::reconciler::pool: Failed to delete the pool, error: gRPC request 'import_pool' for 'Pool' failed with 'status: Aborted, message: "Failed to acquire lock for the resource: pool-doc-k8s1-hdd1-test, lock already held", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 18 Dec 2024 08:54:40 GMT", "content-length": "0"} }'
    at control-plane/agents/src/bin/core/controller/reconciler/pool/mod.rs:205
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:54:50.750922Z ERROR core::controller::io_engine::v1::pool: error: gRPC request 'destroy_pool' for 'Pool' failed with 'status: NotFound, message: "Pool NameUuid { name: \"pool-doc-k8s1-hdd1-test\", uuid: None } not found", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 18 Dec 2024 08:54:50 GMT", "content-length": "0"} }'
    at control-plane/agents/src/bin/core/controller/io_engine/v1/pool.rs:61
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:54:50.752285Z ERROR core::controller::io_engine::v1::pool: error: gRPC request 'import_pool' for 'Pool' failed with 'status: Aborted, message: "Failed to acquire lock for the resource: pool-doc-k8s1-hdd1-test, lock already held", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 18 Dec 2024 08:54:50 GMT", "content-length": "0"} }'
    at control-plane/agents/src/bin/core/controller/io_engine/v1/pool.rs:74
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:54:50.755297Z ERROR core::controller::reconciler::pool: Failed to delete the pool, error: gRPC request 'import_pool' for 'Pool' failed with 'status: Aborted, message: "Failed to acquire lock for the resource: pool-doc-k8s1-hdd1-test, lock already held", details: [], metadata: MetadataMap { headers: {"content-type": "application/grpc", "date": "Wed, 18 Dec 2024 08:54:50 GMT", "content-length": "0"} }'
    at control-plane/agents/src/bin/core/controller/reconciler/pool/mod.rs:205
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:54:53.831862Z ERROR core::pool::service: error: Pool Resource pending deletion - please retry
    at control-plane/agents/src/bin/core/pool/service.rs:318
    in core::pool::service::create_pool with request: CreatePool { node: NodeId("doc-k8s1"), id: PoolId("pool-doc-k8s1-hdd1-test"), disks: [PoolDeviceUri("aio:///dev/disk/by-id/scsi-35000cca2531e679c?blk_size=4096")], labels: Some({"openebs.io/created-by": "operator-diskpool", "class": "hdd"}) }, pool.id: pool-doc-k8s1-hdd1-test

  2024-12-18T08:55:00.769985Z  INFO core::controller::resources::operations_helper: complete_destroy, val: ()
    at control-plane/agents/src/bin/core/controller/resources/operations_helper.rs:382
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:55:00.772685Z  INFO core::controller::reconciler::pool: Pool deleted successfully
    at control-plane/agents/src/bin/core/controller/reconciler/pool/mod.rs:200
    in core::controller::reconciler::pool::deleting_pool_spec_reconciler with pool.id: pool-doc-k8s1-hdd1-test, request.reconcile: true

  2024-12-18T08:55:33.970629Z ERROR core::controller::io_engine::v1::pool: error: gRPC request 'create_pool' for 'Pool' failed with 'status: Cancelled, message: "Timeout expired", details: [], metadata: MetadataMap { headers: {} }'
    at control-plane/agents/src/bin/core/controller/io_engine/v1/pool.rs:33
    in core::pool::service::create_pool with request: CreatePool { node: NodeId("doc-k8s1"), id: PoolId("pool-doc-k8s1-hdd1-test"), disks: [PoolDeviceUri("aio:///dev/disk/by-id/scsi-35000cca2531e679c?blk_size=4096")], labels: Some({"class": "hdd", "openebs.io/created-by": "operator-diskpool"}) }, pool.id: pool-doc-k8s1-hdd1-test

  2024-12-18T08:55:33.976302Z ERROR core::pool::service: error: gRPC request 'create_pool' for 'Pool' failed with 'status: Cancelled, message: "Timeout expired", details: [], metadata: MetadataMap { headers: {} }'

I would be very grateful for help.
If any information or log files are missing, I will be happy to provide them.

I suspect this is the same issue: https://github.com/openebs/mayastor/issues/1772
We have a fix merged and scheduled for mayastor 2.7.3 and openebs 4.2

@besders maybe that can help until the 4.2 release https://github.com/openebs/mayastor/issues/1699#issuecomment-2530672725.


add schema version to JUnit5 test names

this will help distinguish which schema version is being run given TeamCity is running against a specific version as well as the latest.

successfully reporting the different schema versions


qnlp-experiment.jpynb: import error

ImportError: cannot import name 'Ty' from 'discopy'

The qnlp-experiment notebook was implemented with DisCoPy v0.5 so you can try pip install discopy==0.5 instead.

It works with v0.5. Since it is now part of v1.0, please update it to work with v1.0.
v1.0 breaks v0.5 and there is no migration guide, which is quite bad.

You're right we should have made a choice, either update the notebook or get rid of it.
I think we are going for the second option: this notebook was meant as an archive of our first experiment so it does not make sense to re-run it again, and it has now become redundant with the QNLP tutorial which contains almost the same material with better explanations.
As for the migration guide, the best we have at the moment is the description of the v1.0 release. I believe your issue would be solved by replacing from discopy import by from discopy.grammar.pregroup import.
Let me know if you have other issues.

Removing the notebook is a good solution, for the reasons you've stated. QNLP Tutorial is better.
The release note, unfortunately, doesn't help as a migration guide. For example, for
from discopy import Ty, Word
it is not clear how it should be updated to. In v1.0, there are so many different Ty and Word, residing in separate and different packages. The same is true for many other classes. I tried to update the Lorentz code without success, and the Lorentz team has no interest to update it to v1.0.
So, I'm forced to stay with v0.5.
BTW, thank you and your team for DisCoPy and many excellent associated publications.


Remember to call interest counter increment in save_received_squeak

https://github.com/yzernik/squeaknode/pull/1129


Fix failing NCAAB boxscore record parsing

Attempting to close #591 by tweaking the boxscore scheme according to suggestions that others have made in that issue. Appears to be working from what I can tell, but happy to change up the approach or add additional testing if required.

@roclark anything else needed to get this merged?

Is there a reason this hasn't been merged yet?

@alexwisswolf I had an alternative solution in #720 just changing the section_header to table_wrapper.
definitely agree to get one of these merged, as there is beginning to be a lot of duplicate issues.

@jkoestner can't say I have a strong opinion on either solution, honestly. Would just be nice to get one of them merged.

@jkoestner can't say I have a strong opinion on either solution, honestly. Would just be nice to get one of them merged.


$ref relative paths not working

I am running swagger on node.js using swagger-express-mw, and I'm trying to split the huge swagger.yaml file (which is currently over 2000 lines long) into multiple files for easier editing.
Now, in theory this should be a straightforward thing to do - just reference other YAML files using $ref - but in practice this seems far more complicated than it ought to be!.
For start, according to the official OpenAPI specification, you're not allowed to put $ref directly under paths: or definitions:. That's a weird restriction, but I can live with that, it's not the main problem.
The main problem is that Swagger doesn't seem to support relative paths in $ref at all!
For example, I have the main swagger file as  src/api/swagger/swagger.yaml in the same directory I have linkedFile.yaml, which swagger.yaml is supposed to link to using $ref. Simple enough, right? Just add $ref: './linkedFile.yaml' in swagger.yaml? Wrong!
If I run swagger project verify on swagger.yaml, it complains that it cannot find linkedFile.yaml, because it's searching for it in the project's root folder, instead of in src/api/swagger/. If, instead, I link it as $ref: './src/api/swagger/linkedFile.yaml', then the verifier does actually pass, but this approach obviously wouldn't work when actually running the application, because there will be no src folder then. I also can't put the YAMLs into the root folder, because only the files inside src will be built and deployed.
Even if I run swagger project verify while being inside src/api/swagger/, then it still somehow changes the working directory to the project root before running, and still not finds the linked file.
So, what is the point of having the ability to link files using $ref when in practice it doesn't even support specifying YAMLs relative to the current file?

+1

I did find a workaround from the swagger-tools developer: https://github.com/apigee-127/swagger-tools/issues/227 (bottom posts)
I tried it, it works fine, but as for fixing the actual bug, it looks like they aren't gonna do it anytime soon.

+1

+1
same problem on Python


Update versions

One security issue is fixed in this PR.
TODO(): Need to verify javac.version and if errorprone is running correctly for both J8 and J11
Remove Jisha & Tim

I apparently need to test this more.  Not sure why the install of Java 8 is no longer working.  Looks like the kokoro build needs work.
TODO has been done - it should just work.

@kurtisvg PTAL I updated .travis to use bionic; and stop attempting to use OracleJDK8, it defaults to OpenJDK11.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  14.401 s
[INFO] Finished at: 2020-03-05T17:15:20Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default) on project shared-configuration: Failed during checkstyle configuration: cannot initialize module TreeWalker - TreeWalker is not allowed as a parent of LineLength Please review 'Parent Module' section for this Check in web documentation if Check is standard. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
The command "mvn clean verify && cd test && mvn clean verify" exited with 1.

@lesv - Looks like this is a change in checkstyle as of 8.26. We probably need to update the google_checks.xml in the third_party folder from the source.

@kurtisvg PTAL

[ERROR] /home/travis/build/GoogleCloudPlatform/java-repo-tools/test/src/test/java/com/google/cloud/samples/test/AppTest.java:24: Extra separation in import group before 'org.junit.Test' [CustomImportOrder]
Audit done.
[INFO] There is 1 error reported by Checkstyle 8.30 with google-checks.xml ruleset.
[ERROR] src/test/java/com/google/cloud/samples/test/AppTest.java:[24] (imports) CustomImportOrder: Extra separation in import group before 'org.junit.Test'
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  15.117 s
[INFO] Finished at: 2020-03-05T18:26:46Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default) on project shared-configuration-test: You have 1 Checkstyle violation. -> [Help 1]


⚠ Bofrost.es has degraded performance

In f082061, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1754 ms

Resolved: Bofrost.es performance has improved in de0b928 after 1 hour, 20 minutes.


Fixes google-cloud-sdk-datastore-emulator install issue in e2e test

Fixes the failing e2e test in the workflow due to google-cloud-sdk-datastore-emulator not being installed. Addresses #682
Installs google-cloud-sdk & google-cloud-sdk-datastore-emulator from the  Google Cloud repository instead, as google-cloud-sdk-datastore-emulator package not available in the ubuntu default.
It does make the test slow, but it works.
Also adds documentation updates for the  GET /invalidate API for clearing the entire cache. addressing #691

Note, the first test run seemed to fail on one integration test (which remains unchanged), but I think that was general actions flakiness, it just timed out.


option to not crop in dataset run

What does this PR do?
Currently for dataset run, the dataset will be cropped to fixed len. Add option to not crop

Fixes # (issue)
Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


This adds new exported function GetHeaderFooter

PR Details
This adds new exported function GetHeaderFooter
Description
Support to get header and footer of the worksheets
Related Issue
N/A
Motivation and Context
Needs to get worksheet's header and footer.
How Has This Been Tested
Added new unit tests and all exist unit test passed.
Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5e247de) 99.04% compared to head (5b129f6) 99.04%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1720   +/-   ##
=======================================
  Coverage   99.04%   99.04%
=======================================
  Files          32       32
  Lines       28363    28385   +22
=======================================
+ Hits        28093    28115   +22
  Misses        179      179
  Partials       91       91

Flag
Coverage Δ

unittests
99.04% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


More standard headers

Summary
This pull request adds the following headers:

stdint.h -- adds 2 type definitions and 4 macros
stddef.h -- adds the NULL macro

Existing headers changed:

string.h -- This fixes issue #23

Discussion
This pull request only adds helpful type definitions and macros that define the architecture of stackl.

After a bit of research I think that not providing any headers may be more realistic.


blender usage question

Hi,
I have some questions about blender usage in this work, did you use blender rendered video for training or just used it for the demonstrations?

It's only used for visualizations. The visuomotor policy is trained entirely on real world data and the simulation trained whole body controller doesn't take as input vision. You can read the paper to learn more.


Add missing copyright and license

Please notice, the build system codes that ventus copied from chipsalliance/playground never licensed under the mulan license and under the copyright of Jiuyang Liu<EMAIL_ADDRESS>This PR added the copyright back, in case of potential license abuse and propagation.
I also found it steals the copyright and license from https://github.com/chipsalliance/cde, please don't remove the copyright and license header.
And obviously the ALU was coming from the rocket-chip ALU. Please add the license back.

Thank you for your PR pointing out the licensing issues. I appreciate your effort in helping to maintain the integrity of the project.
As for the point concerning the build system, the project has seen contributions from various stages, which might have led to certain elements resembling other projects. I found while there are some structural similarities with the playground project in the dependencies folder, while the build.sc and common.sc files were crafted with inspiration from the rocket-chip project. I would greatly appreciate it if you could provide further guidance on the specific aspects that might require adjustment or attribution, so I can address this issue correctly to ensure compliance with licensing standards.
Thank you again for your support and contributions.


Add transitionToExternalRoute to controllers

Add missing transitionToRoute as transitionToExternalRoute method to controllers inside engines.

could you review it? @dgeb @rwjblue @stefanpenner

I agree with the original issue #590 - this would be better named transitionToExternalRoute.
Also we should discuss #691,  which doesn't have to be a blocker. I could support merging this as a stopgap measure, but I'd prefer to drop the *External methods in general.
@rwjblue thoughts?

@dgeb we should keep using transitionToRouteExternal because of our RFC mention *External as a suffix, We created all methods adding external as a suffix. I think we need to keep following the pattern.
about #691 that will drop all *External methods, I think we need a new RFC to discuss more about it. Because this removes this RFC and adds big changes in the concept of externalRoutes

Reviewing this reminds me how out-of-date the patterns are in this repo, and how much we need to modernize engines to use octane patterns. Anyway, one thing at a time.

For sure @dgeb, we need to make ember-engines more up-to-date with octane and ember things such as test API, RouterService and ergonomics.

Suggestions applied and CI passed - ready to merge @dgeb  : )

Hi, do you have plans about publishing a version with this changes?
Thanks!!

@dgeb @rwjblue can you release it, please?

Hi, just came across this too, assuming its not released yet as we are on 0.8.5 currently?

Yes, we need to release it.
@dgeb @rwjblue someone can do that for us, please?

@linearza @villander I just published v0.8.6. Sorry for the delay!


local-gadget: Support running snapshot-process in a single call

Support running snapshot-process in a single call
This is a PoC where the goal is to discuss how to implement the support of running gadgets with local-gadget in a single call. Like this:
$ sudo local-gadget snapshot process

I started implementing the snapshot-process gadget to discuss the general approach. Then, once we agree and https://github.com/kinvolk/inspektor-gadget/pull/713 is merged, we can work on the trace category.
Implementation details

The idea was to reuse all the code already implemented for kubectl-gadget. Including specific gadget flags.
I created the cmd/common folder where I am moving all the code that is shared between local-gadget and kubectl-gadget.
The only differences between the implementation of gadgets on local-gadget and kubectl-gadget are:

The columns to be printed (availableColumns and the default value for CustomColumns). For now, for all the gadgets that we will support on local-gadget, I would suggest to removed the node, namespace and pod columns. Please notice they will be added in the future when we will enrich the containers from the runtimes also with this information, see more details at https://github.com/kinvolk/inspektor-gadget/issues/644.
The CommonFlags, local-gadget and kubectl-gadget has flags that do not make sense for the other, e.g. --runtimes in local-gadget.
The function that actually runs the gadgets: utils.RunTraceAndPrintStatusOutput.

I kept the interactive mode using the command interactive. However, I don't know how much sense it has to keep this mode once we support other gadgets in this single-call mode.
I didn't enable the socket gadget because the output without the node, namespace and pod doesn't have sense. It is visiting the same network namespace multiple times. We have to either include container information (if possible) or ensure we visit the same network namespace only once. The discussion was already initiated here: https://github.com/kinvolk/inspektor-gadget/pull/245#discussion_r713242794. See #744.

I tried to make progressive changes so that it can be reviewed by commit.
This PR is part of the effort for EPIC https://github.com/kinvolk/inspektor-gadget/issues/643. In particular, task https://github.com/kinvolk/inspektor-gadget/issues/638.
How to use
$ sudo local-gadget list-containers --runtimes containerd
calico-kube-controllers
calico-node
coredns
coredns
etcd
gadget
kube-apiserver
kube-controller-manager
kube-proxy
kube-scheduler

$ sudo local-gadget snapshot process --runtimes containerd
CONTAINER                  COMM               PID
calico-kube-controllers    kube-controller    4942
calico-node                bird               4062
calico-node                bird6              4063
calico-node                calico-node        3801
calico-node                calico-node        3803
calico-node                calico-node        3804
calico-node                calico-node        3807
calico-node                calico-node        3808
calico-node                calico-node        3809
calico-node                runsv              3793
calico-node                runsv              3794
calico-node                runsv              3795
calico-node                runsv              3796
calico-node                runsv              3797
calico-node                runsv              3798
calico-node                runsv              3799
calico-node                runsv              3800
calico-node                runsvdir           3697
coredns                    coredns            4938
coredns                    coredns            5024
etcd                       etcd               1608
gadget                     gadgettracerman    3320
kube-apiserver             kube-apiserver     1605
kube-controller-manager    kube-controller    1624
kube-proxy                 kube-proxy         2972
kube-scheduler             kube-scheduler     1641

# All the flags already implemented in kubectl-gadget are also supported in local-gadget
$ sudo local-gadget snapshot process -c gadget --runtimes containerd -t
CONTAINER    COMM               TGID    PID
gadget       gadgettracerman    3320    3320
gadget       gadgettracerman    3320    3342
gadget       gadgettracerman    3320    3343
gadget       gadgettracerman    3320    3344
gadget       gadgettracerman    3320    3345
gadget       gadgettracerman    3320    3346
gadget       gadgettracerman    3320    3347
gadget       gadgettracerman    3320    3348
gadget       gadgettracerman    3320    3349
gadget       gadgettracerman    3320    3350
gadget       gadgettracerman    3320    3622

I addressed all the comments and rebased the PR on top of https://github.com/kinvolk/inspektor-gadget/pull/742.
I introduced one change with respect to the initial PR: I added the command interactive to run the local-gadget with the already existing interactive mode because it was quite strange to automatically enter the interactive mode when the user does not specify any command.
cc @alban

Rebased to solve conflicts created after merging https://github.com/kinvolk/inspektor-gadget/pull/746.

I think it goes in the right direction. Thanks!
I am a bit worried we need to add a new file for each gadget to support in local-gadget instead of reusing the common code. I checked the difference between the two files:
$ diff -u  cmd/kubectl-gadget/snapshot/process.go cmd/local-gadget/snapshot/process.go
...
-		"node":      {},
-		"namespace": {},
-		"pod":       {},

Could we have something that automatically removes node, namespace and pod for local-gadget? In this way, we would not need to duplicate this file for each gadget.

I added the command interactive to run the local-gadget with the already existing interactive mode

docs/local-gadget.md needs to be updated to use this "interactive" command.
Btw, the command "create biolatency trace1" from the documentation (docs/local-gadget.md) does not work anymore. I am not sure if it biolatency was removed from pkg/gadget-collection/gadget-collection.go or if it was never added.

Could we have something that automatically removes node, namespace and pod for local-gadget? In this way, we would not need to duplicate this file for each gadget.

I think you missed another difference:
-       "github.com/kinvolk/inspektor-gadget/cmd/kubectl-gadget/utils"
+       "github.com/kinvolk/inspektor-gadget/cmd/local-gadget/utils"

It makes that most of the used functions and structures come from two different packages even though they use the same name: utils.CommonFlags, utils.RunTraceAndPrintStatusOutput and utils.AddCommonFlags. Therefore, I didn't find a way to move the remaining part to the common code without making it unreadable. Any suggestion?

docs/local-gadget.md needs to be updated to use this "interactive" command.

Oops, you are right. I missed that.

Btw, the command "create biolatency trace1" from the documentation (docs/local-gadget.md) does not work anymore. I am not sure if it biolatency was removed from pkg/gadget-collection/gadget-collection.go or if it was never added.

It was never added. I will update the documentation in another PR to not iterate on top of this one that was already reviewed and avoid creating conflicts with other PRs.

$ diff -u  cmd/kubectl-gadget/snapshot/process.go cmd/local-gadget/snapshot/process.go
...
-		"node":      {},
-		"namespace": {},
-		"pod":       {},

Could we have something that automatically removes node, namespace and pod for local-gadget? In this way, we would not need to duplicate this file for each gadget.

Regarding this, also Mauricio commented that we could have some basic columns, mainly the k8s metadata, and then each kubectl-gadget gadget extends it with its own list of columns. On the other hand, the local-gadget gadgets just need to use the gadget list without the basics ones.
That sounds good, but I'm not sure if a gadget will always use the same columns in kubectl-gadget and local-gadget. I don't know, I would like to import more gadgets to local-gadget, add the local-gadget specific fields and then decide how to manage this repeated code. I want to avoid implementing something that we will change/remove in a near future 🙂 .


🛠 [TASK] : Schema mismatch Integration test for cat-gateway

Summary
Add an integration test for schema mismatch case for cat-gateway
Description
Need to add an integration test for checking schema mismatch case for cat-gateway

I think this is covered already by https://github.com/input-output-hk/catalyst-voices/pull/226 ?

I think this is covered already by #226 ?

Nope, I'm adding a branch in a moment, the test specifically focuses on changing the schema version while the cat-gateway is active, to test the expected behaviour.


Changed outdated type-function to is_ and updated stdlib to 4.2.0

Hint: https://github.com/Ericsson/puppet-module-cron/pull/12 would also remove the use of type() for future compatibility

Fixed in #12


feat: Detect Drift on NodeClaims on changes to NodeClass

Fixes #337
Description

Detect drift on NodeClaims from when NodeClass get updated.

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

30 of 56 (53.57%)  changed or added relevant lines in 6 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 78.822%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/controllers.go
0
1
0.0%

kwok/cloudprovider/cloudprovider.go
0
3
0.0%

pkg/controllers/nodeclaim/disruption/controller.go
5
16
31.25%

pkg/utils/nodeclaim/nodeclaim.go
0
11
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/node/termination/terminator/eviction.go
2
88.89%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
8285

Relevant Lines:
10511

💛  - Coveralls


[UTOPIA-380] re-implement protected route for web

Description
This PR includes the following proposed change(s):

re-implement protected route for frontend

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Development Dependency Working Agreement

[x] My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
[ ] My code DOES include the importing of new dependencies into the DPIA ecosystem
If new dependencies are being introduced to the DPIA ecosystem:
[ ] The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
[ ] The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

[ ] N/A
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to project documentation or diagrams that reflect my changes
[ ] New and existing unit tests pass locally with my changes
[ ] My code follows Airbnb React Style Guidelines

API Development Changes

[x] N/A
[ ] I have performed a self-review of my own code
[ ] My code follows standards and practices outlined in the BC Government API Development Guidelines
[ ] New and existing unit tests pass locally with my changes
[ ] My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Note: I am not clear why the current solution did not work in dev/test. I try both in my local and both work. Let me know if you have any ideas. thanks

This won't work in dev either. I tried running the web build in local, and routes still show 404.

Should this PR be closed?

close this PR as it is outdated


Download notifications cover the screen with the exact same notification

Describe the bug
Download notifications cover the screen with the exact same notification
To Reproduce
Steps to reproduce the behavior:

Go to models tab in the settings
Download any model

Expected behavior
A loading bar showing the progress of download
Screenshots

Hi, this issue has been addressed with the latest version, please try again and keep us updated, Thanks!
Duplicate of #128

Ah sorry I didn't check closed issues, it does work after building again


feat: migrate rpc signing code to alloy

Closes #4742

Don't know what happened to my pc, I am seeing ethers-core errors :/  . Trying to fix .

Thanks for the help Dan

Integration test failed with no reason ?


Build fails (FileHelper.cpp: No such file or directory)

Thank you for making this tool!
I encountered a hiccup.
When running cargo run --release, I get the following error.
I'm on Windows 10 (22H2) with Visual Studio 2019 installed.
I can confirm the file it's looking for is missing, E:\Projects\gltf-ibl-sampler-egui\target\release\build\gltf-ibl-sampler-egui-ded4467bf4dab538\out\glTF-IBL-Sampler\lib\source is empty.
error: failed to run custom build command for `gltf-ibl-sampler-egui v0.1.0 (E:\Projects\gltf-ibl-sampler-egui)`

Caused by:
  process didn't exit successfully: `E:\Projects\gltf-ibl-sampler-egui\target\release\build\gltf-ibl-sampler-egui-23908ec615670fa8\build-script-build` (exit code: 1)
  --- stdout
  cargo:rerun-if-changed=build.rs
  TARGET = Some("x86_64-pc-windows-msvc")
  OPT_LEVEL = Some("3")
  HOST = Some("x86_64-pc-windows-msvc")
  cargo:rerun-if-env-changed=CC_x86_64-pc-windows-msvc
  CC_x86_64-pc-windows-msvc = None
  cargo:rerun-if-env-changed=CC_x86_64_pc_windows_msvc
  CC_x86_64_pc_windows_msvc = None
  cargo:rerun-if-env-changed=HOST_CC
  HOST_CC = None
  cargo:rerun-if-env-changed=CC
  CC = None
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
  DEBUG = Some("false")
  cargo:rerun-if-env-changed=CFLAGS_x86_64-pc-windows-msvc
  CFLAGS_x86_64-pc-windows-msvc = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64_pc_windows_msvc
  CFLAGS_x86_64_pc_windows_msvc = None
  cargo:rerun-if-env-changed=HOST_CFLAGS
  HOST_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  running: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x64\\cl.exe" "-nologo" "-MD" "-O2" "-Brepro" "-I" "glTF-IBL-Sampler/lib/include" "-I" "glTF-IBL-Sampler/thirdparty/stb" "-I" "glTF-IBL-Sampler/thirdparty/volk" "-I" "glTF-IBL-Sampler/thirdparty/Vulkan-Headers/include" "-W4" "-FoE:\\Projects\\gltf-ibl-sampler-egui\\target\\release\\build\\gltf-ibl-sampler-egui-ded4467bf4dab538\\out\\glTF-IBL-Sampler/lib/source\\FileHelper.o" "-c" "glTF-IBL-Sampler/lib/source\\FileHelper.cpp"
  FileHelper.cpp
  c1xx: fatal error C1083: Cannot open source file: 'glTF-IBL-Sampler/lib/source\FileHelper.cpp': No such file or directory
  exit code: 2

  --- stderr

  error occurred: Command "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Community\\VC\\Tools\\MSVC\\14.29.30133\\bin\\HostX64\\x64\\cl.exe" "-nologo" "-MD" "-O2" "-Brepro" "-I" "glTF-IBL-Sampler/lib/include" "-I" "glTF-IBL-Sampler/thirdparty/stb" "-I" "glTF-IBL-Sampler/thirdparty/volk" "-I" "glTF-IBL-Sampler/thirdparty/Vulkan-Headers/include" "-W4" "-FoE:\\Projects\\gltf-ibl-sampler-egui\\target\\release\\build\\gltf-ibl-sampler-egui-ded4467bf4dab538\\out\\glTF-IBL-Sampler/lib/source\\FileHelper.o" "-c" "glTF-IBL-Sampler/lib/source\\FileHelper.cpp" with args "cl.exe" did not execute successfully (status code exit code: 2).

warning: build failed, waiting for other jobs to finish...

I ran git clone https://github.com/pcwalton/glTF-IBL-Sampler.git in the project directory and it solved this error.
Is the submodule broken somehow? I correctly ran git clone --recursive when cloning the repo.

Hit this too

https://github.com/pcwalton/gltf-ibl-sampler-egui/commit/09e621f5fdf22725d63dbf0e51b2a4d47c461e5a might fix this. Let me know if it does.

@pcwalton the change resolved this issue for me.


Build packages on Travis

This pull request is a followup of https://github.com/jblakeman/apt-select/pull/14 and will build packages on travis and upload it to github tagged releases.
See https://github.com/brodock/apt-select/releases/tag/0.1.0 as an example of automatically generated package.

For further versions, you have to edit deb-package.rb version and tag the appropriate commit with the same version found there.

@brodock Thanks for this pull request.  Packaging and distribution are things I've been wanting to address.
Given that apt-select is an Ubuntu specific program, I've decided to use Launchpad as the distribution platform, even though it requires a bunch of extra tools like Bazaar.  I'll be working hard to get this released the right way, and with Travis integration, as soon as possible.
In the meantime, I recommend that anyone looking for a .deb package use this fork.  Fpm-cookery seems like a very useful tool.


ｅｐｏｃｈ

Hello, thank you for your contribution, I wonder if you need to really train 999999 epoch in training?

Of course not. That value is not used to constrain the training schedule. We set the max iteration step here:
https://github.com/prismformore/InvPT/blob/3b70fcc5a4f7053a7e32a9f85da5dda670c18fba/configs/pascal/pascal_vitLp16.yml#L17


Set suggested node/npm version in package.lock engines

This is to align with the improvement to Kommander UI for suggested node/npm versions.
Testing

Trade-offs

Dependencies

Screenshots

Checklist for PR creator

[] If any new components were added, there are exported from packages/index.ts
[ ] If this PR is associated with a JIRA, it is mentioned in commit message footer ("Closes …")
[ ] If this PR contains breaking changes, is stated in commit message body ("BREAKING CHANGE: …")
[x] Info for applicable sections above is provided

:tada: This PR is included in version 8.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support more colors

Adds support for xTerm system colors 0-16, e.g. (bling [:system-aqua "aqua text"]). Closes #1

Adds support for arbitrary xTerm colors 0-256, e.g. (bling [{:color 180} "xTerm color 180, aka Tan"]). Closes #2

Closes #1, #2


[7.x] Added client or server error definition in the Http

The Http facade has method successful, the return status of a successful request. But in case you need to determine the error, you have to use one of the following options:
if (! $response->successful()) { }
// or
if ($response->clientError() || serverError()) { }

Therefore, I propose adding method failed, which makes it possible to more clearly identify errors:
if ($response->failed()) { }

Why don't we negate the value of successful? This seems like an opening for edge cases to leak in.

Why don't we negate the value of successful? This seems like an opening for edge cases to leak in.

Because failed means a client or server error while successful defines status codes from 200 to 299.
This means that if successful is denied, the returned code, for example, 301 will be considered an error, and this is not correct.


Runtime Error with Jest on 0.26.2

Hey,
I tried upgrading our app to 0.26.2, but I'm faced with an issue when running tests with Jest (latest version):
 FAIL  src/utils/__tests__/NotificationsUtils-test.js
● Runtime Error
  - Error: Cannot find module 'ErrorUtils' from 'env.js'
        at Resolver.resolveModule (node_modules/jest-resolve/src/index.js:117:17)
        at Runtime._resolveModule (node_modules/jest-cli/src/Runtime/Runtime.js:214:32)
        at Object.<anonymous> (node_modules/react-native/jestSupport/env.js:22:28)

It seems to be coming from jestSupport/env.js but after that my knowledge of Jest is very limited but can't make much sense of it.
It doesn't work starting at<EMAIL_ADDRESS>previous versions work fine.
Any ideas?

Ahh, I've spent hour's trying to get Jest working in v 0.26.2, I should of checked here 1st.
My Stack Overflow Question:
http://stackoverflow.com/questions/37474160/cannot-get-jest-react-native-working
@Bhullnatik so if I try Jest v11 it should work?

@giantelk Yes, it works for me with<EMAIL_ADDRESS>

Can you post your package.json? Are you using require() or ES6 import in your test scripts, or something like:
jest
  .disableAutomock()
  .setMock('MyText', {})
  .setMock('React', {Component: class {}});

Thank you for your patience. We launched Jest 14.0 with experimental react-native support:

Blog Post
React-Native Tutorial

Please feel free to create new issues after trying out the new integration if any issues remain.

@cpojer is there an new version of jest-cli that goes with this version update? I'm currently getting the following error:
.../node_modules/jest-cli/src/lib/utils.js:189
  throw new Error('Unknown config option: ' + key);

Error: Unknown config option: preset

when I add the config to package.json:
  "jest": {
    "preset": "jest-react-native"
  },

Yes, update to 14.0.


RTL bullets appear on the LEFT instead of on the RIGHT.

describe the bug
RTL support not full.
For example, bullets on RTL should appear on the LEFT instead of on the right.
expected behaviour
When RTL bullet should appear on the RIGHT of the text.
screenshots

platform
macOS

duplicate of #55


feat(tablecard): support custom icon names and colors

Closes #https://github.ibm.com/wiotp/monitoring-dashboard/issues/773
Summary

Change to allow passing custom icon names and colors to configured TableCard thresholds. here's a custom Icon and Color for a TableCard threshold:

Change List (commits, features, bugs, etc)

refactor(CardIcon): share all Icon rendering code across all Cards so the same logic is followed
refactor(Attribute): refactor to use shared CardIcon
refactor(Hotspot): refactor to use shared CardIcon
fix(Hotspot): also pass the 'title' attribute to the svg rendered so that when we mouseover the threshold shows
fix(PropTypes): list the renderIconByName function in the CardPropTypes (code was already there, just documentation was missing)
feat(TableCard): add ThresholdIcon component that support custom icons and color to be passed to a TableCard threshold
fix(table): sorting breaks if some fields are undefined inside the table data
fix(table): support filtering on numeric values without throwing a prop types error

Acceptance Test (how to verify the PR)

Verify the custom icons shows correctly in the story called 'watson-iot-tablecard--table-with-thresholds-precision-and-expanded-rows'

:tada: This PR is included in version 2.56.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


add package.json for publishing to npm registry

Fixes https://github.com/timdown/rangyinputs/issues/12
@timdown You would still need to npm publish to the registry yourself. Thanks!

Thanks for this, okize. For anyone else wanting to use this even though the PR hasn't been merged, you can install via npm directly from this PR:
npm install timdown/rangyinputs#pull/17/head

I'm trying out yarn which does not (yet?) understand pull request URLs.  So for that refer to the commit hash instead:
yarn install timdown/rangyinputs#91d0c4e5448a79dc4c47f8771c258c854d690360


Use Tokens::ensureWhitespaceAtIndex to simplify code

It lowers cyclomatic complexity.
Before:
$ phploc src/Fixer | grep 'Average Complexity per Class'
  Average Complexity per Class                   17.27

After:
$ phploc src/Fixer | grep 'Average Complexity per Class'
  Average Complexity per Class                   17.22

Coverage increased (+0.001%) to 92.854% when pulling 867da40dc28e0478d271740cf8cc2f6f4195045d on werlos:use_Tokens_ensureWhitespaceAtIndex into 07430f5aca4874476bf175317cfb6284cd80421a on FriendsOfPHP:master.

Thank you @kubawerlos.


How to send text to a post controller?

Version
1.4.5
Test Environment
Chrome, Windows 10
Current Behavior
Does not send the editor text to the database.
  var initial_form_state, last_form_state;
  var editor = new tui.Editor({
    el: document.querySelector('#editor'),
    language: 'it_IT',
    initialEditType: 'markdown',
    previewStyle: 'tab',
    height: '500px',
    events: {
        change: function() {
          last_form_state = $('form').serialize();
        }
    }
  });
  $(window).bind('beforeunload', function(e) {
    if(last_form_state != initial_form_state){
      return false;
    }});
  $(document).on("submit","form",function(event){
    $('[name=document__text]').attr('value', editor.getMarkdown());
  $(window).off('beforeunload');
});

{{$articoli->testo}}

Expected Behavior
I am installing Tui.Editor in Laravel 5.8, I installed the editor correctly only when I go to send the form, it completely ignores what I wrote:
[00:14:33] LOG.info: The given data was invalid. {
"url":"http:\/\/<IP_ADDRESS>:8000\/admin\/articoli\/edit\/7234",
"previus":"http:\/\/<IP_ADDRESS>:8000\/admin\/articoli\/edit\/7234",
"input":{"_token":"8jmiOAam4WVOkQxhkddA8Jh3LRtC6Oo",
"titolo":"testa",
"slug":"testa",
"testo":null}

As you can see, the "testo" field is null. what is the practice for sending text to a post controller? I also tried to include a textarea internally as suggested editor.md of pandao...

@Ande1232
I think the usage is wrong. Are you trying to send data on server whenever the editor's value changes? If you want this, I think you should get the editor's value from calling getMarkdown() and submit it in events.change event. When I only see the code above, I'm not sure how to submit. 🤔


close the modals if auth fails

This PR will fix the issue of Modal staying open despite auth failure and UI moves to the login screen.

It works fine as expected!


Unhandled Runtime Error

I am facing this error

When I am fetching data from API in page.TSX (server component) and then pass it as a prop to my client component.
Here is my code:
Page.tsx

Button.tsx:

i think u need to return and element with content <>Something</> or
result could be undefined or null you need to check first either it is given data from api or not.

I think you are getting an object in {result} which can not be rendered. In my point of view, you should try like this {result.name} (object and key ).

Anas, please update the first line of your page.tsx code to this:
import Button from '../components/Button/Button';
The problem is in the first line, where you're trying to import the Button component from the wrong place. First, make sure that your Button component is saved in a file named either Button.tsx or button.tsx.
You mentioned the filename as Button.tsx, but in the first line of your page.tsx file, you're trying to import the Button component from ../components/button/Button, which is incorrect. Please fix the import path like I showed above, and your code will work correctly.


Background integration

Removed the background code from Way Cooler, is now loaded from Lua using way-cooler-bg. See here for that repo.
@SnirkImmington, can you please pretty up the code here so that instead of a stupid hacky os.execute at the end of the init file that code is ran in a special post-init hook function that is called by way-cooler at the very end of wlc setup?

Coverage increased (+1.1%) to 64.275% when pulling 7730b23d9e669a6d0d42ce7db2bee9fb359ab397 on background-integration into e07ff918f9fb203b552c18a0d174cbaee76817f4 on master.

Coverage increased (+1.07%) to 64.247% when pulling f4e8151920d3f8cbcf5b230f7cfd7f00bbc95b2a on background-integration into e07ff918f9fb203b552c18a0d174cbaee76817f4 on master.


Migrate to Flutter 3.27.0

Resolves #4548
Summary by Sourcery
Enhancements:

Update Flutter dependencies to version 3.27.

@sourcery-ai review


Cleanup Logs

Hello,
I am currently running Deis v1.10.1 and the folder /var/lib/deis/store/logs contains about 100gb log data. Clearing one of the logfiles > app1.log will wipe the data from the file -> 0kb but when running deis logs -a app1 I get the following error.
panic: runtime error: index out of range
goroutine 1 [running]:
github.com/deis/deis/client/cmd.AppLogs(0x7ffd346fbe73, 0x13, 0xffffffffffffffff, 0x0, 0x0)
/home/jenkins/workspace/build-deis-cli-installer-linux/src/github.com/deis/deis/client/cmd/apps.go:162 +0x571
github.com/deis/deis/client/parser.appLogs(0xc82000a1d0, 0x3, 0x3, 0x0, 0x0)
/home/jenkins/workspace/build-deis-cli-installer-linux/src/github.com/deis/deis/client/parser/apps.go:192 +0x2b6
github.com/deis/deis/client/parser.Apps(0xc82000a1d0, 0x3, 0x3, 0x0, 0x0)
/home/jenkins/workspace/build-deis-cli-installer-linux/src/github.com/deis/deis/client/parser/apps.go:37 +0x3e9
main.Command(0xc82000a1d0, 0x3, 0x3, 0x585820)
/home/jenkins/workspace/build-deis-cli-installer-linux/src/github.com/deis/deis/client/deis.go:87 +0xc24
main.main()
/home/jenkins/workspace/build-deis-cli-installer-linux/src/github.com/deis/deis/client/deis.go:18 +0x60
What is the safe way to cleanup this folder? My Problem is the our Deis cluster is running on DO and almost running out of diskspace
EDIT:
after scale web=0 and web=1 for app1 i can see some logs again, so is this the only way to get rid of big log files?

For a while, we toyed with the idea of adding a logrotate cron job or something of the sort to the logger.
Ultimately, we have decided against that and headed in a direction instead where Deis stores logs short term in-memory.  If you want to keep your logs, you drain them to someplace else.
See #4280 for further details.


VIH-6716 update CI pipeline project path

JIRA link (if applicable)
VIH-6716
Change description
update CI pipeline project path
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

Moved to feature/VIH-6716-build-client-on-build


resolved merge conflict

I resolved the merge conflict sorry for the delay

Sorry @balogun14, but it turns out that we will need a more complicated approach than constructing the UI using javascript. I have come up with a patch using Grunt.js for injecting the HTML into the source files.


remapping keyboard shortcut for delete not working

VSCode Version: 1.7.1
OS Version: OS X el capitan

Steps to Reproduce:

add {     "key": "cmd+delete",     "command": "editor.action.deleteLines",     "when": "editorTextFocus && !editorReadonly" } to keybindings.json
hit cmd+delete while editing. still triggers the original shortcut

I tried mapping the editor.action.deleteLines command to another key and it worked.
I tried mapping cmd+delete to another command and it did not work.

I played around w/ this a bit more and it seems I can't map a shortcut to any key combination containing delete

So I just managed to figure this out. The delete key is called backspace in vscode, similar to what the key is called on Windows, even on Mac.
Changing
{  "key": "cmd+delete",   "command": "editor.action.deleteLines" }
to
{   "key": "cmd+backspace",   "command": "editor.action.deleteLines" }
did the trick.
Maybe it should be renamed delete when on mac?

@Shayac sorry about that, but when one presses the key labeled as "delete" on Apple keyboards, the key code for the backspace key is generated.
We cannot "rename" all instances of the backspace key on the mac as "delete" because you could attach an external (non-Apple manufactured) keyboard that does contain both Backspace and Delete keys, and unfortunately we currently don't have that information (i.e. what physical keyboard you have plugged in).


http: allow matching ignoring ports

See discussion on https://github.com/envoyproxy/envoy/issues/11294
and some on https://github.com/envoyproxy/envoy/pull/10960/files
I think if added a matcher for host.com I would expect host.com:80 to match for HTTP.  Arguably sending host.com:443 on port 80 shouldn't match, but maybe it could be a config option?
cc @mattklein123 @antoniovicente @snowp @PiotrSikora

+1 I think we should have an option for this.

Would this be configured at the Route level?

No strong opinions.   I think the existing port stripping option is probably the easiest for most folks as it both fixes the local route matching problem and protects upstream from hitting the same class of issues.
Do you folks have an interest in preserving the original port but matching sans port, or was the stripping not on your radar?  Maybe we could something similar to https://github.com/envoyproxy/envoy/pull/15975 where we extend the port stripping option to allow strip-and-readd for all requests, not just CONNECT

oh wow I wasn't aware of strip_matching_host_port and strip_any_host_port, looks like these solve my problem. Should this ticket be closed?

Sure, I guess we can close for now and reopen if folks want to match without altering the host header :-)


Update test jobs to 800 and set runs_per_test back to 2 to detect fla…

…kes.

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences


Fix: ding-dong example requires uos protocol

I'm submitting a...
[x] Bug Fix
[ ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

[x] Commit Messages follow the Conventional Commits pattern

A feature commit message is prefixed "feat:"
A bugfix commit message is prefixed "fix:"

[x] Tests for the changes have been added

Description
Issue: Minor bug fix to help the beginners to use the repo.
Notes: Thanks @choogoo for explaining uos protocol
Does this PR introduce a breaking change?
[ ] Yes
[x] No

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you very much for your contribution!
You are welcome to join Wechaty Contributor Program
1. Join Wechaty Organization

You've invited Tianwei Yue to Wechaty! They'll be receiving an email shortly. They can also visit https://github.com/wechaty to accept the invitation.

I have invited you to join our Wechaty GitHub Organization, please accept it by following the above message. (See also: wechaty/PMC#16)
2. Update Your Wechaty Contributor Profile

Please open Contributor Hall of Fame and add yourself to the end of the list, so that other contributors will know you better!
Please add yourself to our Website Contributors by creating a PR and refer to this PR link as well.

3. Join The Contributor Only WeChat Room
We also have a WeChat room for contributors only which can discuss Wechaty at a deeper level, you are welcome to join and if you are interested.
Please add @lijiarui wechat: ruirui_0914 and send her this pr link. She will invite you into Wechaty Contributor Room
Cheers!


sorry for the last PR

I noticed that you are already addressing the issue, sorry for this :(
I was trying the same thing just now
  steps:
    - name: Set default image-name if not provided
      id: set-image-name
      run: |
        slugify() {
        echo "$1" | sed -e 's/[^[:alnum:]]/-/g' | tr -s '-' | tr A-Z a-z
        }

        if [ -z "${{ inputs.image-name }}" ]; then
          IMAGE_NAME=$(slugify ${{ github.repository }})-$(slugify ${{ inputs.caprover-app-name }})
          echo "IMAGE_NAME=$IMAGE_NAME" >> $GITHUB_ENV
        else
          echo "IMAGE_NAME=${{ inputs.image-name }}" >> $GITHUB_ENV
        fi

      shell: bash

By the way, github.repository should be sufficient for the image-name, as it already includes the GitHub username and the name of the repository itself. Adding the CapRover app name might be redundant, since it is likely to be the same as the repository name, which I assume would be the case for most people.

No worries! We got all of it working eventually!


using cell instead of render_cell since Cells 4.0

also added template engine support

thank you

:heart: @EppO


Lambda adds record to queue for each object in S3 that will need to be processed.

Completed in https://github.com/LouisvilleMetro/WazeCCPProcessor/tree/feature/terraform-buildout


Update typesafe:config to 1.4.1

Updates com.typesafe:config from 1.4.0 to 1.4.1.
GitHub Release Notes - Version Diff - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (1.4.0).
You might want to review and update them manually.
daffodil-cli/bin.NOTICE

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.typesafe", artifactId = "config" } ]

labels: library-update, semver-patch, old-version-remains

+1

[X] Do all automated continuous integration checks pass?
Yes
[X] Is the update a patch, minor, or major update?
Changelog apears to be a minor release, a couple new features/changes, nothing that seems to affect our usage.
[X] Is the license still compatible with ASF License Policy?
Yes, still Apache 2.0 license
[X] Have any changes been made to LICENSE/NOTICE files that need to be incorporated?
No LICENSE changes, no NOTICE file
[X] Have any transitive dependencies been added or changed?
No


Ubuntu WSL graphical setup fails

cmd /c ver
Microsoft Windows [Version 10.0.22621.457]
wsl --status
Default Distribution: Ubuntu
Default Version: 2
WSL1 is not supported with your current machine configuration.
Please enable the "Windows Subsystem for Linux" optional component to use WSL1.
WSL version: <IP_ADDRESS>
Kernel version: <IP_ADDRESS>
WSLg version: 1.0.42
MSRDC version: 1.2.3401
Direct3D version: 1.606.4
DXCore version: 10.0.25131.1002-220531-1700.rs-onecore-base2-hyp
Windows version: 10.0.22621.457
Did the problem occur during installation?

[X] Yes

What happened?

Setup completes decompressing image.

Setup spits out a bunch of errors [invisible to the end user if they don't click to show the console log]
I wasn't able to capture the full output of the errors because the setup utility doesn't seem to allow copying the output, this screencap is the best I could do -

Setup prompts you to continues as if nothing has failed

User creation step hangs/doesn't complete/spins its wheels indefinitely

What was expected?

Setup utility decompresses image
Setup proceeds to user creation window
Everything's good and working

Steps to reproduce

Install WSL from store.
Install 'Ubuntu' from store.
'Open' Ubuntu to run graphical setup.
[click to show console output]

Additional information
If you exit/close at the user creation step before creating the user it seems to fallback to the old cli user creation method which works fine as far as I can see.
The older 'Ubuntu on Windows' and its CLI install/setup, that is used when you run wsl --install ubuntu, appears to work just fine [albeit gives you the older 20.04 LTS]

Thanks for reporting that. Could you please inform us which language you selected so we can reproduce step by step exactly like you did?
You may also still have the logs inside /var/log/installer if you didn't wipe out that instance. In such case, you could review the ubuntu_wsl_setup.log and system_setup_server_debug.log files and share the contents here. (You may want to remove privacy related contents out of the log).

Language is English [en_US I assume as it doesn't specify beyond 'English'].
I did nuke the instance from orbit [and multiple others] these are the logs from the most recent attempt.
ubuntu_wsl_setup.log:
ubuntu_wsl_setup.log
system_setup_server_debug.log was empty

Hi!
The graphical UI is now disabled for all releases except for Ubuntu-Preview, where it has been completely reworked. Therefore, this bug no longer applies.
Thanks for bringing up this issue.


Protocol - Load Button >> file dialog only shows .tsv filetype

If you save a protocol file without supplying a .tsv extension, you can't see nor load the file because the .tsv filetype is the only file extension allowed. If the .tsv filetype could be forced at save time, this would fix the problem.  I may have caused a problem by suggesting the .tsv files. For plate protocols that are long, being able to view the file as a spreadsheet is necessary in my opinion. I thought one could open a .tsv directly in MS Excel, but that is no longer the case. It can be imported, but not opened directly. Can a tab-delimited file be saved as a .txt ? Maybe this would be a better choice. Github doesn't allow .tsv's either. In any case the dialog boxes for load and save need to be consistent. I miss the early days when these files were .csv's

This issue is similar to https://github.com/EtalumaSupport/LumaViewPro/issues/173#issue-1567184289

Fixed to force save as *.tsv. Changing back to *.csv requires a discussion in case some of the text contains commas.

Closing this as it is two issues, One solved. If we want it to return to CSV, then lets open a new issue. Right now, when I double click on a tsv file, excel opens it correctly.


get_processed_data not running

Pvlib was working fine and suddenly does not.
When trying to run  get_processed_data this error appears:
xml.etree.ElementTree.ParseError: no element found: line 1, column 0
Versions:

pvlib.__version__:  0.9.0
pandas.__version__: 1.3.4
python: 3.8 and 3.7

For some reason, the forecast server returned an empty response. I doubt this is a pvlib problem.

For some reason, the forecast server returned an empty response. I doubt this is a pvlib problem.

Thank you for your reply!
So there is not much to do, right?

Yes, I would wait and try again.


Type guard using square bracket notation does not narrow type

TypeScript Version:  3.2.0-dev.20181023

Search Terms:
type guard square bracket notation narrowing
Code
interface ConfigType {
    [key: string]: boolean | { prop: string };
}

const config: ConfigType = {
    works: { prop: 'foo' },
    'works-not': { prop: 'bar' },
    bool: true,
};

if (typeof config.works !== 'boolean') {
    config.works.prop = 'test';
}

if (typeof config['works-not'] !== 'boolean') {
    config['works-not'].prop = 'test'; // [ts] Property 'prop' does not exist on type 'false'.
}

Expected behavior:
The type guard using square bracket notation narrows the type in the same way the type guard using dot notation does, resulting in no type errors in the above example.
Actual behavior:
The type guard specifically using square bracket notation does not narrow the type.
Playground Link:
Link
Related Issues:
https://github.com/Microsoft/TypeScript/issues/10530

Is this not a duplicate of #10530?

No, this is not a duplicate. It's a missed interaction between indexed access and index signatures, where property access + index signatures works.
Here's a smaller repro, without the dashed-name red herring:
interface ConfigType {
    [key: string]: boolean | { prop: string };
}

const config: ConfigType = {
    works: { prop: 'foo' }
};

if (typeof config.works !== 'boolean') {
    config['works'].prop = 'test'; // error, config['works']: boolean | { 'prop': string }
    config.works.prop = 'test'; // ok
}

The behaviour is the same if the discriminator is typeof config['works'] !== 'boolean', so I think it's just a failure of control flow from indexed access in this case.
Also note that if we have interface ConfigType { works: boolean | { prop: string } } then both statements work.

Just a drive by comment. We are working in Google internal TS to forbid using the prop access on index signature objects. The main reason is that to Closure prop access means safe to rename and index access means don't touch. This optimization pass is done without global knowledge (other than whats' coming externally) so its up to the developer to decide whether it is really "safe" to rename.
The transformation from foo.bar to foo['bar'] is mostly noop TS-wise, except for this issue.

Turns out this was just missing. It is super simple to add since it's the same code as property access. I just need to make sure performance is OK.

Update: The PR is trivial and performance is, as expected, bad for probably-uncommon adversarial code. We need to discuss in the design meeting whether to take this change.


chore(release): v0.5.0

:robot: I have created a release beep boop
0.5.0 (2023-02-12)
⚠ BREAKING CHANGES

theme color scale strict satisfy Radix colors.

Features

add "info" built-in color. (0efd422)

Bug Fixes

docs: docs site color style fixup for Radix colors. (35babe5)

Performance Improvements

add contrast color css variables for theme colors. (7e3326b)

Code Refactoring

theme color scale strict satisfy Radix colors. (0efd422)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/riccox/sira/releases/tag/v0.5.0 :sunflower:


TV off after midnight

If the tv is turned off after midnight the living room lights will turn on. This is because there is a before condition which will only stop the automation until midnight. Need to add an after condition (hard coded or not?) or something so the lights don't turn on or add another automation which turns then off later (when in bed, ....).

Solved in 9fd2b60


Debian 11 Updates and Porting/Working with librobotcontrol

Describe the bug
The install is not available with dpkg nor can I get the install completed with the correct rc_test_drivers command.
To Reproduce
Steps to reproduce the behavior:

git clone https://github.com/beagleboard/librobotcontrol
cd librobotcontrol
make
sudo make install
rc_test_drivers

Expected behavior
I expected the drivers to be available and for my drivers for GPIO, PWM, UART, and SPI to pass.
Screenshots
debian@Me:~/librobotcontrol$ rc_test_drivers

Kernel: 5.10.65-ti-r24
BeagleBoard.org Debian Bullseye IoT Image 2021-10-10
Debian: 11.1

PASSED: gpio 0
PASSED: gpio 1
PASSED: gpio 2
PASSED: gpio 3
ERROR:  ti-pwm driver not loaded for hrpwm0
ERROR:  ti-pwm driver not loaded for hrpwm1
ERROR:  ti-pwm driver not loaded for hrpwm2
ERROR:  ti-eqep driver not loaded for eqep0
ERROR:  ti-eqep driver not loaded for eqep1
ERROR:  ti-eqep driver not loaded for eqep2
ERROR:  pru-rproc driver not loaded
ERROR:  uart1 driver not loaded
ERROR:  uart2 driver not loaded
ERROR:  uart4 driver not loaded
ERROR:  uart5 driver not loaded
ERROR:  i2c1 driver not loaded
PASSED: i2c2
ERROR: spi driver not loaded
PASSED: LED
PASSED: ADC iio

Currently running on a:
MODEL_BB_BLUE
Robot Control library Version:
1.0.5

Platform information

cat /etc/dogtag : BeagleBoard.org Debian Bullseye IoT Image 2021-10-10
uname -r : 5.10.65-ti-r24

** Additional Info. **
I have also been trying to repair rcpy and pycntrl to no avail. Anyway, I will stick w/ librobotcontrol as I know it has worked in the past. If anyone needs help updating old scripts or making current GCC-10 ideas available, please direct me.
Here is the current working errors I received: Although they are just warnings, I see them as errors that can be fixed in time: https://pastebin.com/raw/U2vz4224 . That is my account on Pastebin. I use it when the file is too large.

Also,
This may seem silly but here goes it. On the OrangeRX R820X V2, there are a few JST-ZH ports with three-pin assignments. There are eight "channels" on it also. So, there are a row of eight w/ three pins each as columns.
Anyway, I have come to a conclusion that I cannot access the receiver from and to the BBBlue. Is anyone using the librobotcontrol any longer w/ the BBBlue? I am basically looking for handouts here b/c I feel like one wrong turn and I could ruin the BBBlue.
Seth
P.S. I cannot find the V2 "datasheet" any longer. But! I found a V3 versioning of the OrangeRX "datasheet". I have quoted the datasheet wording b/c of the lack of data in their sheets. If you are using the BBBlue w/ librobotcontrol and a DSM (UART) connection, please do let me know about what connections to make on the BBBlue to/from the receiver for DSM and PRU.

I am using BBBlue with librototcontrol, but have issues... encoder 4 make trouble and no solution is present

@unl0ck :
Hello...I think in the .dts file, the PRUs are used to handle the encoder on connector four.
Seth
P.S. You can find it in the BBBlue .dts file called am335x-boneblue.dts.

I am using it, but its still show 0 -1 1 not more do you want to see a special line?


Crash out part way thru Export:  Error binding parameter 14: type 'Error' is not supported

Been running the osxphotos approx every month and didn't encounter this error until two days ago after upgrading to latest version (previously I'd upgraded around 1 month ago).
Command used:
osxphotos export photo_library_backup/ --load-config osxphotos_backup.toml
Export fails 1/4 the way through.  Error that happens after running for a good period of time is shown in picture below. Have run the exact same command a few times now and same issue occurs:

Last 12 lines from the crash log:
osxphotos_crash_last_12_lines.log
the TOML configuration file I use (added .txt to enable upload to GH):
osxphotos_backup.toml.txt
osxphotos, version 0.59.2
Python 3.11.3 (main, Apr  7 2023, 20:13:31) [Clang 14.0.0 (clang-14<IP_ADDRESS>)]
macOS 13.3.1, arm64
running on a MacBook Pro 14 2021 M1 silicon
NOTE:  Am running command again and will update if it crashes out on a different photo or the same one again.

Ran it again and it crashed out again at 27% of way through, but this time on a different photo file and the error messages were different.
[Errno 24] Too many open files: '/Volumes/WDSSD2B/Macbook_Pro_14_PhotosLibrary_Full_Originals_Backup/Photos Library.photoslibrary/resources/derivatives/0'
Something went wrong and osxphotos encountered an error:
Error binding parameter 14: type 'OSError' is not supported

Attached last 11 lines from the crash log file as the full crash log file is 1.12 GB in size. I'd deleted the crash log file prior to running the osxphotos command again so the 1.12 GB is from this one run.
2nd_Run_osxphotos_crash_last_11_lines.log

I downgraded to 0.58.2 version and am currently rerunning the command again.

It's already passed 30% and hasn't failed (I fully expect it to complete successfully this time)
The estimated time remaining and how long it's been running seem to suggest for my library at least that 0.58.2 is significantly faster vs 0.59.2 release.

My photos library is ~ 1.6TB on disk.

@all-contributors please add @rajscode for bug

@rajscode I think this is fixed in v0.59.3.  Please give that a try and let me know if you still see the error.

@rajscode I think this is fixed in v0.59.3. Please give that a try and let me know if you still see the error.

0.59.3 bugfix release looks to be working well (Thanks!)
Some observations:
0.59.3 (vs 0.58.2) seems to be faster:  ~ 1hr35m vs 2hr16m
going through a photos library of approx 155K items using ~ 1.6TB on disk

In regards to memory utilization - I logged 0.59.3 memory use from start to end.
4th_Run_0.59.3_bugfix_version_memory_usage_observations.log
Thanks again.

My results were also positive. 3:23:23 for ~90K pics exporting via 1GB LAN to NAS Server.
https://github.com/RhetTbull/osxphotos/issues/999#issuecomment-1503766386


Copy failed, please try later

Microsoft PowerToys version
0.78.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
Open PowerToys Run, enter a value to be calculated (f.e. " = 4096/12") and press Enter or the mouse key.

✔ Expected Behavior
Copy the value without any error messages.
PowerToysReport_2024-03-04-16-03-09.zip
❌ Actual Behavior
When inputting a mathematical operation in the PowerToysRun dialog using "=", after I press the enter key to copy the result I usually (9 times out of 10) get an error message that says "Copy failed, please try later".
The calculated value is always copied on the clipboard however, whether I get the error message or not, so I can copy it with Ctrl+V, but it does not show up in the clipboard history (Win Key + V).
Other Software
No response

This issue usually comes from another application which encounters an error while accessing the clipboard and prevents any other app from using the clipboard. Try restarting your PC this issue should go away. Are you are using a 3rd party clipboard manager? /needinfo

Having the same issue, I'm not using any 3rd party clipboard managers, only Win-V. Was working like a week ago

I have been getting this for a few months at this point, it doesn't happen every time, though it doesn't change run to run, more like day to day. And seems to only happen with the calculator plugin, for example the data plugin copies the current time with no issues.

This issue usually comes from another application which encounters an error while accessing the clipboard and prevents any other app from using the clipboard. Try restarting your PC this issue should go away. Are you are using a 3rd party clipboard manager? /needinfo

No I don't use anything like that... Also running PowerToys as an administrator does not solve the problem.

/dup #25437


BarSeries not working as bar, instead shows column

Hi,
I am trying to work with BarSeries, but its showing columns instead. What could be the possible error?

Hi @sweetyv would you mind pasting in the code you're trying to render so I can help debug it?

Hi @whawker .. i added "inverted" to the BarSeries and now its working :)
Thank you very much. Really appreciate the quick response.

No worries, although I didn't really do anything! Glad you got it sorted.
P.s. If you're planning to use React JSX Highcharts on a publicly accessible website I'd love to see it in action. Would you be able to post a link if that is the case?

@whawker Thanks :) I am not sure if I can share the link but I will definitely try and ask the client.


Mask R-CNN converted via JIT fails to load in PyTorch Android

🐛 Bug
ERROR:
com.facebook.jni.CppException:
Tried to access nonexistent attribute or method 'cell_anchors' of type '__torch__.torchvision.models.detection.rpn.___torch_mangle_242.AnchorGenerator'. Did you forget to initialize an attribute in __init__()?:
Serialized   File "code/__torch__/torchvision/models/detection/mask_rcnn/___torch_mangle_189.py", line 946
      _273 = torch.append(strides, [_270, _272])
    _274 = uninitialized(List[Tensor])
    _275 = torch.__isnot__(_263.cell_anchors, None)
                           ~~~~~~~~~~~~~~~~~ <--- HERE
    if _275:
      cell_anchors = _263.cell_anchors

    at org.pytorch.NativePeer.initHybrid(Native Method)
    at org.pytorch.NativePeer.<init>(NativePeer.java:24)
    at org.pytorch.Module.load(Module.java:23)

To Reproduce
Steps to reproduce the behavior:
Conversion:
model = torchvision.models.detection.maskrcnn_resnet50_fpn(pretrained=True)
scripted_module = torch.jit.script(model)
scripted_module.save("mask_rcnn.pt")

Android:
val bitmap = ... # extracted from image view
val module = Module.load(uri)  # fails
val values = module.forward(IValue.from(bitmap))

Expected behavior
Shouldn't fail with above error
Environment

PyTorch / torchvision Version (e.g., 1.0 / 0.4.0): 1.6.0 / 0.7.0
OS (e.g., Linux): macOS
How you installed PyTorch / torchvision (conda, pip, source): pip
Build command you used (if compiling from source): NA
Python version: 3.8
CUDA/cuDNN version: NA
GPU models and configuration: NA
Any other relevant information: NA

Additional context
JIT script works properly but fails during inference. Any idea how to fix this?

@prabhuomkar I maybe wrong, but in your android code seems like the input is a tensor and not a list of tensors https://github.com/pytorch/vision/blob/master/torchvision/models/detection/mask_rcnn.py#L149 ?

@prabhuomkar I maybe wrong, but in your android code seems like the input is a tensor and not a list of tensors https://github.com/pytorch/vision/blob/master/torchvision/models/detection/mask_rcnn.py#L149 ?

Hey, I mentioned #fails on wrong line of code. It fails when I try Module.load()

Hi,
We currently don't support Faster / Mask R-CNN on mobile. The main blocker I believe is that we rely on custom operators, which to the best of my knowledge can't be yet exported to mobile.
Your error seems unrelated to this issue though.
cc @dreiss if you have further thoughts on this

Closing this because of no activity!


I want to integrate superset with Prometheus.

I want to integrate superset with Prometheus.
It has been confirmed that superset does not support Prometheus as a database
So after installing trino in the middle, I'm trying to link Prometheus. At that time, trino has a problem in that part.
Is there any way to solve this phenomenon?

There's a whole discussion thread on this, since it's a feature request rather than a bug. Feel free to join in the conversation there:
https://github.com/apache/superset/discussions/18381
It seems that really, we just need some volunteer support to champion the cause and make it happen.


How do we create a Service Bus Client Scoped topic subscription in Azure CLI?

It appears this option is only available in the Azure Portal. Is there missing documentation that describes how to set it in Azure CLI?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 52b7d039-d543-895c-3056-2616b21ac86e
Version Independent ID: 84875b23-e2ef-997a-c819-dafbae87f4e1
Content: az servicebus topic subscription
Content Source: latest/docs-ref-autogen/servicebus/topic/subscription.yml
Service: service-bus
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

route to service team

Hi @samsmithnz , This option is available to be set via REST API/ ARM template. We would triage internally and get it supported with CLI. I would keep you posted for future updates.
https://docs.microsoft.com/en-us/azure/templates/microsoft.servicebus/namespaces/topics/subscriptions?tabs=bicep
https://docs.microsoft.com/en-us/rest/api/servicebus/stable/subscriptions/create-or-update?msclkid=5d214cdebf0b11ecbbb981ab81e4d58a#sbclientaffineproperties

Hi @samsmithnz, this has been supported in our latest release. Kindly try to create the subscription and let us know in case of additional concerns.


OVDB-136: Attribute Stealing

Two new additions related to stealing data from a Point Data Grid:

PointDataLeafNode::stealAttributeSet() - releases ownership of the AttributeSet and replaces it with a new empty AttributeSet.

AttributeSet::removeAttribute(...) - releases the shared_ptr reference to a specific AttributeArray by index or name and returns it. There is also an "unsafe" variant that doesn't attempt to put the AttributeSet or Descriptor back into a valid state which is useful when you know the AttributeSet is being destroyed and want the extra performance.

@Idclip - addressed your feedback except for the "unsafe" method as I think this is the best solution here. Thanks.


Confine shoot spec update rollout to maintenance

What this PR does / why we need it:
This PR adds a new optional field .spec.maintenance.confineSpecUpdateRollout to the Shoot. If it is set to true then any update to the spec will not cause a reconciliation directly. Internally, this is achieved by not incrementing the .metadata.generation. Instead, the changes are rolled out by the reconciliation that happens in the shoot's maintenance time window anyways.
Which issue(s) this PR fixes:
Fixes #2196
Special notes for your reviewer:

I added docs for shoot maintenance along the way.
Also, you might ask yourself (like I asked myself 😉) whether it's really a good idea to not bumped the .metadata.generation to achieve this. I was iterating back and forth, but eventually I decided for "yes". The main reasons were:

a) .metadata.generation is mainly a measurement for controllers to detect whether they have to reconcile. As we control both (API server + controller) we can keep this knowledge in sync.
b) End-users might want to compare .metadata.generation and .status.observedGeneration to check whether their changes got already applied. However, when they set the .spec.maintenance.confineSpecUpdateRollout=true then they know already that the changes won't get applied immediately, so it's no issue.
c) This was actually my main concern: Convention-wise this approach is violating, however, we are already "violating" (I'd rather call it "customizing") when we bump the generation. IMO this is the advantage of developing and maintaing our own API server (instead of using CRDs).

Release note:

It is now possible to confine rollouts of changes/updates to the `Shoot` specification to the individual maintenance time window. You can set `.spec.maintenance.confineSpecUpdateRollout=true` to achieve the desired behaviour. Please consult [this document](https://github.com/rfranzke/gardener/blob/feature/confine-spec-updates/docs/usage/shoot_maintenance.md#confine-specification-changesupdates-roll-out) to get all information about it.

I didn't test the changes but I'm afraid that this change breaks the scheduled hibernation feature, doesn't it? If yes, the least we should do is to prevent both features being used at the same time. WDYT?

Nice catch! Yes, it would break it, indeed. We could forbid it per validation, right. The other option would be to make an exception for hibernation/wake-up and roll them out immediately as those operations are disruptive anyways (and there isn't a use-case where people would want their shoots from being hibernated/woken-up in the maintenance time window only (and even if they can achieve that more accurately by defining a hibernation schedule)). The only downside would be an inconsistency, though, on the other hand hibernation is a strong use-case and preventing it in general might be too harsh, probably unnecessary harsh.

We could forbid it per validation, right. The other option would be to make an exception for hibernation/wake-up and roll them out immediately

I went back and forth with thoughts about this and tend to vote for the second option as well. Let's mention it in the documentation and ideally also in the doc string of the confineSpecUpdateRollout field.