Error: Integer types not allowed (at 'autoSizeTextType' with value '1')

Information

Apktool Version (apktool -version) - 2.3.0
Operating System (Mac, Linux, Windows) - Mac and Window. Not sure about Linux
APK From? (Playstore, ROM, Other) -  Compiled from the source

Stacktrace/Logcat
..... AndroidStudioProjects/APKTool/app/build/outputs/apk/_Generated/TestApk/res/layout/content_main.xml:4: error: Error: Integer types not allowed (at 'autoSizeTextType' with value '1'). And failed.

brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [C:\Users\IBM_AD~1\AppData\Local\Temp\brut_util_Jar_780322057631553104.tmp, p, --forced-package-id, 127, --min-sdk-version, 26, --target-sdk-version, 26, --version-code, 1, --version-name, 1.0, --no-version-vectors, -F, C:\Users\IBM_AD~1\AppData\Local\Temp\APKTOOL4110286854525879315.tmp, -0, arsc, -0, arsc, -I, C:\Users\IBM_ADMIN\AndroidStudioProjects\WinCrash\app\build\outputs\apk\framework\1.apk, -S, C:\Users\IBM_ADMIN\AndroidStudioProjects\WinCrash\app\build\outputs\apk\_Generated\TestApk\res, -M, C:\Users\IBM_ADMIN\AndroidStudioProjects\WinCrash\app\build\outputs\apk\_Generated\TestApk\AndroidManifest.xml]

Steps to Reproduce

apktool
Use Android Studio version 3.x to create a default project (target to Android 8) that has a text label. Add " android:autoSizeTextType="uniform" " to the TextView of the label in the content_main.xml. Note: android:autoSizeTextType is a new Android 8 attribute. My code runs the Apktools on the project and get the error above. If I don't add the autoSizeTextType attribute, my code runs fine.

The interesting part is I specify a "uniform" as the value, but it is translated to "1". I wonder where the translation happens and which file contains the defined values of the attribute. If I have the information, I may be able to figure out where the problem is.
Frameworks
If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files
(.apks that live in /system/framework or /system/priv-app)
The code is running on Mac/Windows machine. The problem occurred before the apk is run on a mobile device.
APK
If this APK can be freely shared, please upload/attach a link to it.
It is just a plain default app from Android Studio new project.
Questions to ask before submission

Have you tried apktool d, apktool b without changing anything?
I do not modify anything apktool code

If you are trying to install a modified apk, did you resign it?
Not at that point yet.

Are you using the latest apktool version?
Yes

I downloaded the apktool-2.3.0.jar from your site and run the decoding. I got the decoded section below:
TextView n1:layout_width="wrap_content" n1:layout_height="wrap_content" n1:text="Hello World!" n1:autoSizeTextType="1" n2:layout_constraintBottom_toBottomOf="parent"  ....
Should the n1:autoSizeTextType="1"  be decoded as n1:autoSizeTextType="uniform"  ?

Appears from my research that this should be a text value, which is probably tokenized as "1" internally.
android:autoSizeTextType="uniform"

I will need to do some research to see what the proper solution is here. Either decoding is broken, or we need to untokenize these resources back to human readable values.

@iBotPeaches thanks.
I ran the apktool b command to build the decoded source. I got the error below. It complains autoSizeTextType identifier not found. I got the same error if I use your jar in my code. However, if I compile the source and use the apktool-cli-all.jar in the Apktool-2.3.0/brut.apktool/apktool-cli/build/libs in my code, then I got the error in my original report. Am I using the right jar or the jar from the site doesn't have everything it needs?
my-mbp:decode myname$ ./apktool b app-debug
I: Using Apktool 2.3.0
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Checking whether resources has changed...
I: Building resources...
W: /Users/myname/tmp/decode/app-debug/res/layout/abc_screen_toolbar.xml:5: error: No resource identifier found for attribute 'keyboardNavigationCluster' in package 'android'
W:
W: /Users/myname/tmp/decode/app-debug/res/layout/content_main.xml:4: error: No resource identifier found for attribute 'autoSizeTextType' in package 'android'
W:
Exception in thread "main" brut.androlib.AndrolibException: brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/var/folders/rg/z171b2514hz5wjfmxx1lpj8w0000gn/T/brut_util_Jar_1777498077591960649.tmp, p, --forced-package-id, 127, --min-sdk-version, 26, --target-sdk-version, 26, --version-code, 1, --version-name, 1.0, --no-version-vectors, -F, /var/folders/rg/z171b2514hz5wjfmxx1lpj8w0000gn/T/APKTOOL5162487692981055122.tmp, -0, arsc, -0, arsc, -I, /Users/myname/Library/apktool/framework/1.apk, -S, /Users/myname/tmp/decode/app-debug/res, -M, /Users/myname/tmp/decode/app-debug/AndroidManifest.xml]
at brut.androlib.Androlib.buildResourcesFull(Androlib.java:485)
at brut.androlib.Androlib.buildResources(Androlib.java:419)
at brut.androlib.Androlib.build(Androlib.java:318)
at brut.androlib.Androlib.build(Androlib.java:270)
at brut.apktool.Main.cmdBuild(Main.java:224)
at brut.apktool.Main.main(Main.java:75)
Caused by: brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/var/folders/rg/z171b2514hz5wjfmxx1lpj8w0000gn/T/brut_util_Jar_1777498077591960649.tmp, p, --forced-package-id, 127, --min-sdk-version, 26, --target-sdk-version, 26, --version-code, 1, --version-name, 1.0, --no-version-vectors, -F, /var/folders/rg/z171b2514hz5wjfmxx1lpj8w0000gn/T/APKTOOL5162487692981055122.tmp, -0, arsc, -0, arsc, -I, /Users/myname/Library/apktool/framework/1.apk, -S, /Users/myname/tmp/decode/app-debug/res, -M, /Users/myname/tmp/decode/app-debug/AndroidManifest.xml]
at brut.androlib.res.AndrolibResources.aaptPackage(AndrolibResources.java:454)
at brut.androlib.Androlib.buildResourcesFull(Androlib.java:471)
... 5 more
Caused by: brut.common.BrutException: could not exec (exit code = 1): [/var/folders/rg/z171b2514hz5wjfmxx1lpj8w0000gn/T/brut_util_Jar_1777498077591960649.tmp, p, --forced-package-id, 127, --min-sdk-version, 26, --target-sdk-version, 26, --version-code, 1, --version-name, 1.0, --no-version-vectors, -F, /var/folders/rg/z171b2514hz5wjfmxx1lpj8w0000gn/T/APKTOOL5162487692981055122.tmp, -0, arsc, -0, arsc, -I, /Users/myname/Library/apktool/framework/1.apk, -S, /Users/myname/tmp/decode/app-debug/res, -M, /Users/myname/tmp/decode/app-debug/AndroidManifest.xml]
at brut.util.OS.exec(OS.java:95)
at brut.androlib.res.AndrolibResources.aaptPackage(AndrolibResources.java:448)

If your application has any resources from 8.1 (Oreo API 27) it will fail, as there are new resources.
However, the two resources you listed failing are both from API 26
https://developer.android.com/reference/android/R.attr.html#keyboardNavigationCluster
https://developer.android.com/reference/android/R.attr.html#autoSizeTextType
As you can see both are added in API26.
Try
apktool empty-framework-dir

(if you have more than 1.apk)
apktool empty-framework-dir --force

@iBotPeaches
You are right. According to the doc below, the internal value is 0 or 1.
https://developer.android.com/reference/android/widget/TextView.html#attr_android:autoSizeTextType

After I ran the "apktool empty-framework-dir" command, now I got the value not allowed error.
my-mbp:decode myname$ ./apktool b app-debug
I: Using Apktool 2.3.0-dirty
I: Checking whether sources has changed...
I: Checking whether resources has changed...
I: Building resources...
W: /Users/myname/tmp/decode/app-debug/res/layout/content_main.xml:4: error: Error: Integer types not allowed (at 'autoSizeTextType' with value '1').
W:
Exception in thread "main" brut.androlib.AndrolibException: brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/var/folders/rg/z171b2514hz5wjfmxx1lpj8w0000gn/T/brut_util_Jar_759714114662609974.tmp, p, --forced-package-id, 127, --min-sdk-version, 26, --target-sdk-version, 26, --version-code, 1, --version-name, 1.0, --no-version-vectors, -F, /var/folders/rg/z171b2514hz5wjfmxx1lpj8w0000gn/T/APKTOOL1026488455331632622.tmp, -0, arsc, -0, arsc, -I, /Users/myname/Library/apktool/framework/1.apk, -S, /Users/myname/tmp/decode/app-debug/res, -M, /Users/myname/tmp/decode/app-debug/AndroidManifest.xml]
at brut.androlib.Androlib.buildResourcesFull(Androlib.java:485)
at brut.androlib.Androlib.buildResources(Androlib.java:419)
at brut.androlib.Androlib.build(Androlib.java:318)
at brut.androlib.Androlib.build(Androlib.java:270)
at brut.apktool.Main.cmdBuild(Main.java:224)
at brut.apktool.Main.main(Main.java:75)
Caused by: brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/var/folders/rg/z171b2514hz5wjfmxx1lpj8w0000gn/T/brut_util_Jar_759714114662609974.tmp, p, --forced-package-id, 127, --min-sdk-version, 26, --target-sdk-version, 26, --version-code, 1, --version-name, 1.0, --no-version-vectors, -F, /var/folders/rg/z171b2514hz5wjfmxx1lpj8w0000gn/T/APKTOOL1026488455331632622.tmp, -0, arsc, -0, arsc, -I, /Users/myname/Library/apktool/framework/1.apk, -S, /Users/myname/tmp/decode/app-debug/res, -M, /Users/myname/tmp/decode/app-debug/AndroidManifest.xml]
at brut.androlib.res.AndrolibResources.aaptPackage(AndrolibResources.java:454)
... 6 more

Yep, that is the error I am investigating. So you are set just waiting at that point.

@iBotPeaches great. thanks. I am using API 26, not 27.

I added a test for this and can't seem to find a problem. Commit above, passing tests - https://travis-ci.org/iBotPeaches/Apktool/builds/308950244

hi @iBotPeaches I am not sure if I understand you comment above. Do you mean you can't recreate the issue with the test case? If so, I can upload my apk.  You can try and you will see the problem.

That is correct. I can not duplicate the issue. Test case above shows no problem.

Can you give this apk a try? Git doesn't support apk file type. I zipped up the apk. You can unzip it back...
What I did was use apktool to decode it, then use apktool to build the decoded folder and you will see the issue.
app-debug.apk.zip

Hi @iBotPeaches any luck to recreate the problem?

➜  1674 apktool d app-debug.apk
I: Using Apktool 2.3.1-ef9be8-SNAPSHOT on app-debug.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: /home/ibotpeaches/.local/share/apktool/framework/1.apk
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values */* XMLs...
I: Baksmaling classes.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
➜  1674 apktool b app-debug
I: Using Apktool 2.3.1-ef9be8-SNAPSHOT
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Checking whether resources has changed...
I: Building resources...
I: Building apk file...
I: Copying unknown files/dir...
➜  1674

Could not duplicate sorry. I added a test and ensured all is working from my side so closing this.

Hi @iBotPeaches,
I can recreate the problem on my macbook pro and my windows 7 laptop following the same steps all the time. Both machines have Android Studio 2.3.3/3 installed.
I got a windows 7 VM with no Android stuff on it. I download the apktool windows script and the 2.3.0 jar from your site to a tmp directory and I run the tool from that directory. I don't see the error. However, the apk is not generated at the end.
Is the "I: Copying unknown files/dir..." an expected output?
What would be the possible cause of the problem? Does Apktool use libraries that are on the system already? What is the best way to debug this issue?
=========================
Below is the console from the VM
C:\tmp\decode>apktool.bat d app-debug.apk
I: Using Apktool 2.3.0 on app-debug.apk
I: Loading resource table...
I: Decoding AndroidManifest.xml with resources...
I: Loading resource table from file: C:\Users\pttest\AppData\Local\apktool\framework\1.apk
I: Regular manifest package...
I: Decoding file-resources...
I: Decoding values / XMLs...
I: Baksmaling classes.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
C:\tmp\decode>apktool.bat b app-debug
I: Using Apktool 2.3.0
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Checking whether resources has changed...
I: Building resources...
I: Building apk file...
I: Copying unknown files/dir...
C:\tmp\decode>dir
Volume in drive C has no label.
Volume Serial Number is 306B-8819
Directory of C:\tmp\decode
11/29/2017  03:36 PM              .
11/29/2017  03:36 PM              ..
11/29/2017  03:24 PM               181 apktool.bat
11/29/2017  03:24 PM         5,882,586 apktool.jar
11/29/2017  03:37 PM              app-debug
11/29/2017  03:22 PM         2,008,394 app-debug-o.apk
3 File(s)      7,891,161 bytes
3 Dir(s)  27,060,617,216 bytes free
C:\tmp\decode>

More information, on the VM, the decode value of the attribute is correct now. It is the "uniform", not the "1"

@iBotPeaches
The apktool empty-framework-dir command and a reboot of my machines fixed the problem. Thank you very much for your help.


[Feature Request] Passing list of data hashes instead of sets to traintuples

One use-case that is not supported as of today in Substra would be to easily use a static algo.py to do either only one training epoch over a dataset or multiple epochs without any modifications to the algo or the Dockerfile.
The limitation is due to the fact that there is a uniqueness test on the data-hashes one passes to a traintuple to make sure they are unique (can be cast into a set).
If the hashes given to the traintuple are not unique Substra raises:
error is: Key: 'inputTraintuple.DataSampleKeys' Error:Field validation for 'DataSampleKeys' failed on the 'unique' tag"}
and the traintuple cannot be processed.
For instance consider the case where you want your traintuple to operate on the following hashes:
["A","B","C","D"]:
One might want to use a single algorithm similar to the following:
algo.py:
import json
import substratools as tools
from networks import MyNetwork

class ComputeUpdates(tools.Algo):
    def train(self, X, y, models, rank):
        #assuming the opener created a [n_hashes, d] numpy array X and a vector y of size [n_hashes, dtarget]
        my_model = MyNetwork()
        for i in range(X.shape[0]):
            my_model.update_weights(X[i], y[i])
        return my_model

    def predict(self, X, model):
        predictions = 0
        return predictions

    def load_model(self, path):
        return json.load(path)

    def save_model(self, model, path):
        json.dump(model, path)

if __name__ == '__main__':
    tools.algo.execute(ComputeUpdates())

So to do one epoch one would register a traintuple using this algorithm and the following data samples hashes set s=["A","B","C","D"] and it would work.
Now to do multiple epochs (N) instead of one, without modifying algo, the obvious solution would be to just pass  s*N instead of s during the registration of the traintuple.
However it is not possible as it would raise the above error in Substra as the hashes cannot be cast as a set because each hash is present N times.
This feature would be very valuable for my workflow !
It would also allow to support more complicated plans where we want to do a floating number of epochs by passing just the hashes of the samples that we intend to see (some samples multiple times some samples just once).
Thanks again !

My question is very naive, but wouldn't it be equivalent to creating N traintuples each taking as input the full set of data samples s and the trained model from the previous step?

Yes it would be equivalent mathematically in this case, but would induce lag because of the docker spawning at each traintuple processing and be a bit more complicated in terms of logic.

Un order to reduce the lag to very little, you could use a compute plan to create all the traintuples at once. The docker images created for the compute plan won't be removed until the end of the compute plan, so spawning a new container is very fast (no need to rebuild between traintuples).

Closing as stale


Add usage docs to wiki and sample apps

We need to document how to use the tool, and provide working samples:

[x] usage docs for each command
[ ] getting started doc and sample app
[ ] using with octopus deploy doc
[ ] blog post summarising all of the above

@robwoz, @nina26 I've added the usage docs for each command to the wiki.  Can you review when you get a moment?
I'll update this issue as the other docs are written.
/cc @Yorktech @Reddy11

@kevinkuszyk They look good. Nice work.

what about an what RSDeploy is looking for from the datasource config?


When i run "./colcon_release",terminal show "permision is denied"!

Ubuntu 16.04
Ros kinetic
When i run "./colcon_release",terminal shows "permission is denied"!I was in root state that time.
And I try another solution to install--"./catkin_make_release",but the terminal shows that "bash: ./catkin_make_release: No such file or directory".I am crazy because i search on the internet several days about this issue,until now i haven't found the solution.I wish you can solve my problem.Thank you very much

Thanks for using Autoware and for your question. However the issue tracker is for posting confirmed bugs and feature requests.
We ask that you please ask questions on the Autoware Discourse category following our support guidelines: https://github.com/CPFL/Autoware/wiki/Support-guidelines. Please pay particular attention to the information we ask you to provide.


chore(rust): ockam command add subcommand to generate man pages

Current Behavior
Currently there are no man pages available for ockam.
Proposed Changes
The PR adds a subcommand called manpages which generates man pages and writes the files to a user selected directory, the users default man page location within the home directory or to a fallback location based on the current working directory.
One man page is generated for the main command, and one for each subcommand. For further details please refer to the according issue:
https://github.com/build-trust/ockam/issues/3808
Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] I accept the Ockam Community Code of Conduct.
[x] I have accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam-contributors repository.

@adrianbenavides
with the input from your comment I've done the following adaptions:

extracted the manpage generation to a function
switched to a recursive call for generating the man pages to cover all levels of subcommands
added the hidden flag to the manpages subcommand so it does not appear for users in the help, but could be used e.g. for CI integration
fixed some formatting issues

Hi @adrianbenavides,l
I've addressed the inputs from the review and squashed all changes into a single commit.
Some background and information on the colour topic:

Currently the colours are added in help.rs which is called during adding the help messages for clap (e.g node/mod.rs).
Within clap there is only the colourized string version available, which ended up in the man page.
Without removing the syntax highlighting for colour enabled terminals within the help messages a way to solve that problem is to filter the ascii control characters before writing the man page to disk. This is what I've added to the PR.

I'm not very happy with that solution, and think it might be cleaner to think about removing the colourization within help messages.
Best regards,
Harald


Use click for prompting in read_response

This PR removes read_response from compat.py in favor of a re-implementation using click.prompt.
I wrote a simple test to make sure that click.prompt is being called with the correct arguments so that it mimics the current prompting scheme by leaving the actual prompt generation to prompt_for_config.
I will submit another request to change query_yes_no and to introduce the choices feature of #441 (and close #443).
Please let me know your thoughts. :smile:

I love seeing the commits where compat.py get smaller and smaller. :)

Hooray :smile_cat:


Tesla not working anymore

Describe the bug
I see my Tesla Model Y as offline.
Trace states "Endpoint is only available on fleetapi. Visit https://developer.tesla.com/docs for more info"
Regenerated Tokens to make sure this is not the problem.
Also created a second config via Webinterface. Same result.
Steps to reproduce

Configure Tesla and Log level to Trace
Start EVCC
Read Log
...

Configuration details
vehicles:
- name: ev3
  type: template
  template: tesla
  title: Model Y
  accessToken: ...
  refreshToken: ...

Log details
an 25 12:20:09 pi4 evcc[79184]: [tesla ] TRACE 2024/01/25 12:20:09 POST https://auth.tesla.com/oauth2/v3/token
Jan 25 12:20:10 pi4 evcc[79184]: [tesla ] TRACE 2024/01/25 12:20:10 client_id=ownerapi&grant_type=refresh_token&refresh_token=***
Jan 25 12:20:10 pi4 evcc[79184]: --
Jan 25 12:20:10 pi4 evcc[79184]: {"access_token":"...","expires_in":28800,"token_type":"Bearer"}
Jan 25 12:20:10 pi4 evcc[79184]: [tesla ] TRACE 2024/01/25 12:20:10 GET https://owner-api.teslamotors.com/api/1/vehicles
Jan 25 12:20:11 pi4 evcc[79184]: [tesla ] TRACE 2024/01/25 12:20:11 {"response":null,"error":"Endpoint is only available on fleetapi. Visit https://developer.tesla.com/docs for more info","error_description":""}
Jan 25 12:20:11 pi4 evcc[79184]: [main  ] ERROR 2024/01/25 12:20:11 creating vehicle ev3 failed: cannot create vehicle type 'template': cannot create vehicle type 'tesla': cannot get vehicles: 412 Precondition Failed

What type of operating system are you running?
Linux
Version
0.123.9

I have the same issue in my FHEM setup, so it could be an API change on Tesla side

see here: https://github.com/teslamate-org/teslamate/issues/3629
and here: https://github.com/teslamate-org/teslamate/pull/3630

Solved: https://github.com/evcc-io/evcc/pull/10802


I have the original copy of the book named Automate The Boring Stuff in python

I want to know how can I contribute it.

Hi, there! It looks like that book is already included in the book section for English. You can find it here.

Nice catch Amy. Thanks for your triage help.
https://github.com/EbookFoundation/free-programming-books/blob/f1dc9f15aa04ea7e1cd7f990cd9e1692af6e4dc3/books/free-programming-books-langs.md#L1784


Update elastic beat to be compatible with libbeat 5 and ES5

Related: elasticsearch/issues/21266

@nlowe Thanks for linking it! I am finishing migration of elasticbeat and I see the issue.

FYI Updating to 5.0.1 seems to have resolved most of the issues I had previously (elastic/elasticsearch#21266 was merged for 5.0.1)

Thanks @nlowe I have tested it as well with 5.0.1


Fix format bug and change the name of retrain

The change of the name "retrain" to "trainParam" is to avoid the confusion with the "retrain" used in ATLearn.

Codecov Report
Base: 72.08% // Head: 71.38% // Decreases project coverage by -0.70% :warning:

Coverage data is based on head (09d0276) compared to base (bb5073f).
Patch coverage: 72.02% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2147      +/-   ##
============================================
- Coverage     72.08%   71.38%   -0.71%
- Complexity     5126     6312    +1186
============================================
  Files           473      625     +152
  Lines         21970    27915    +5945
  Branches       2351     3011     +660
============================================
+ Hits          15838    19926    +4088
- Misses         4925     6523    +1598
- Partials       1207     1466     +259

Impacted Files
Coverage Δ

api/src/main/java/ai/djl/modality/cv/Image.java
69.23% <ø> (-4.11%)
:arrow_down:

...rc/main/java/ai/djl/modality/cv/MultiBoxPrior.java
76.00% <ø> (ø)

...rc/main/java/ai/djl/modality/cv/output/Joints.java
71.42% <ø> (ø)

.../main/java/ai/djl/modality/cv/output/Landmark.java
100.00% <ø> (ø)

...main/java/ai/djl/modality/cv/output/Rectangle.java
72.41% <0.00%> (ø)

...i/djl/modality/cv/translator/BigGANTranslator.java
21.42% <0.00%> (-5.24%)
:arrow_down:

.../modality/cv/translator/ImageFeatureExtractor.java
0.00% <0.00%> (ø)

.../ai/djl/modality/cv/translator/YoloTranslator.java
27.77% <0.00%> (+18.95%)
:arrow_up:

...modality/cv/translator/wrapper/FileTranslator.java
44.44% <ø> (ø)

...y/cv/translator/wrapper/InputStreamTranslator.java
44.44% <ø> (ø)

... and 563 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Panel groups inside panel does not work

So i have following markup:

    echo $this->Panel->create(__("Assignment rules for user {0}", $user->display));
    echo $this->Panel->startGroup(["collapsible" => true]);
    echo $this->Panel->create("Rule NO 1");
    echo "Rule 1";
    echo $this->Panel->end();
    echo $this->Panel->create("Rule NO 2");
    echo "Rule 2";
    echo $this->Panel->end();
    echo $this->Panel->endGroup();
    echo $this->Panel->end();

and This is what happening:

Removing top level panel fixes exerything and accordian works fine.

Unfortunately PanelHelper are not stateless, so you cannot create a panel or a group inside another one...
Modifying the Helper to work like that would require a non-negligible amount of work, so I am not sure I will update it, but you can do either of the following:
Create the inner panel before the panel:
$panel1 = "";
$panel1 .= $this->Panel->startGroup(["collapsible" => true]);
$panel1 .= $this->Panel->create("Rule NO 1");
$panel1 .= "Rule 1";
$panel1 .= $this->Panel->end();
$panel1 .= $this->Panel->create("Rule NO 2");
$panel1 .= "Rule 2";
$panel1 .= $this->Panel->end();
$panel1 .= $this->Panel->endGroup();

echo $this->Panel->create(__("Assignment rules for user {0}", $user->display));
echo $panel1;
echo $this->Panel->end();

Use another instance of PanelHelper:
$panel = new \Bootstrap\View\Helper\PanelHelper($this);

echo $this->Panel->create(__("Assignment rules for user {0}", $user->display));

echo $panel->startGroup(["collapsible" => true]);
echo $panel->create("Rule NO 1");
echo "Rule 1";
echo $panel->create("Rule NO 2");
echo "Rule 2";
echo $panel->endGroup();

echo $this->Panel->end();

@Holt59 I have buffered inner content and echoed it later just like you mentioned. Thanks for the tips.

This has been merged onto master, I am closing this issue, feel free to open a new one if you still have troubles with these helpers.


Added some points.

Conflicts with frequencies.md. Rest should be okay.
The BBC image should be renamed to something more readable, the image in frequencies.md should be the local one, and the alt attribute should be something more relevant.

I fixed all that stuff I think, all my points should include much of what your radiation point included so that it can be replaced.
help

Should be fine now. Merging.


Invalid filter in Usage Insights table

When going to Usage Insights page it displays strange Paragon filter

It appears that some projects import all of Paragon components in tests as follows

which confuses our dependent usage analyzer.
This can be solved in one of the following ways:

Improve dependent analyzer to understand such imports and extract the actual used components in the file (will likely require too much effort)
Ignore files with such imports (such imports will probably only occur in tests and I don't think we particularly care how our components are used in tests)
Ignore all test files (again, do we care how often Paragon components are used in tests? If not, maybe we can just skip such files)

We will close this as a won't do, because import * from '@edx/paragon'; is technically supported and having it show up in Usage Insights is good discoverability for when consumers do these imports.
If consumers want to import Paragon in this way for their tests (all the existing use cases thus far), this is likely OK.


[dv,rom_e2e] update expected ROM hash in GLS self hash test

A new ROM was released after #24417 was merged, however the expected hash was not updated in the vseq used for the GLS test. This updates the expected hash to match that in the .c file counterpart.

@eshapira I forgot to update the hash in vseq for the self hash GLS test just a heads up. My apologies. I will need to cherry pick this over to earlgrey_1.0.0 branch as well.


TSE module

It is not done yet, but it can download data from candidatos page. It closes #6 .
I am doing this pull request just to keep public the progress of this module.
TODO:

[ ] aggregate data
[ ] check years that it can download
[ ] download from eleitorado, pretacao_de_contas and resultados
[ ] save data on bradata dir
[ ] put headers on csv files

I may use luigi framework, so all of this can be refactored.

@JoaoCarabetta , we should put up a line in .gitignore to ignore .csv's, else we'll be drowning git with useless changes!

Yep. Sounds a nice idea.
On Mon, Mar 27, 2017, 11:11 bruno cuconato<EMAIL_ADDRESS>wrote:

@JoaoCarabetta https://github.com/JoaoCarabetta , we should put up a
line in .gitignore to ignore .csv's, else we'll be drowning git with
useless changes!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/labFGV/bradata/pull/10#issuecomment-289464542, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ATCfVCPJwiJE3q-BcsSxAKm6DObROH0Kks5rp8LcgaJpZM4MqRI5
.

--
João Carabetta / Data Developer
https://htmlsig.com/t/000001CA95SE
[image: Facebook] https://htmlsig.com/t/000001CA95SE [image: LinkedIn]
https://htmlsig.com/t/000001CC9BV9 [image: Github]
https://htmlsig.com/t/000001C5STHP


[Feature Request] visibleInShow option should accept closure

Feature Request
$this->crud->addColumn([
   'name' => 'description',
   'visibleInTable' => true,
   'visibleInShow' => function($entry){
        return $entry->someCondition;
   }
]);

Totally agree, makes sense. Will do, @izica , thank you for the suggestion!


Feature/230 get partitioning checkpoints

Introduces GET partitioning checkpoints endpoint with pagination
Closes #230

Release notes:

Introduces GET partitioning checkpoints endpoint with pagination

LGTM! I'd be interested in David's solution(s) regarding SQL code as well, but apart from that I like it

Any chance to increase the coverage %, @salamonpavel ?

Any chance to increase the coverage %, @salamonpavel ?

Coincidentally @miroslavpojer today mentioned that jacoco-report had release version 1.7.1 with number of bugifxes. Can you please increase the version in the script to test and see how the new version works.

Those coverage numbers are incorrect.

Any chance to increase the coverage %, @salamonpavel ?

Coincidentally @miroslavpojer today mentioned that jacoco-report had release version 1.7.1 with number of bugifxes. Can you please increase the version in the script to test and see how the new version works.

Those coverage numbers are incorrect.

The new jacoco-report version explains the meaning of the negative percentage numbers.
The "delta" (the negative value next to the coverage) represents the percentage of newly added or modified lines of code that are not covered by unit tests. It calculates the difference in test coverage based solely on the changes made in the current commit or pull request. For example, if 10 lines of code are modified or added, and 8 of those lines are covered by unit tests, the "delta" would be -20%, indicating 20% of the newly changed code is untested. However, the "delta" has limitations. It can never be positive, meaning if you add more unit tests to cover existing, unmodified code, this additional coverage is not reflected in the delta. The metric only considers lines directly changed in the current set of modifications, as there is no mechanism to track improvements in coverage for pre-existing code that hasn't been altered.
Do the numbers make more sense with this explanation?

Any chance to increase the coverage %, @salamonpavel ?

Coincidentally @miroslavpojer today mentioned that jacoco-report had release version 1.7.1 with number of bugifxes. Can you please increase the version in the script to test and see how the new version works.

Those coverage numbers are incorrect.

The new jacoco-report version explains the meaning of the negative percentage numbers.
The "delta" (the negative value next to the coverage) represents the percentage of newly added or modified lines of code that are not covered by unit tests. It calculates the difference in test coverage based solely on the changes made in the current commit or pull request. For example, if 10 lines of code are modified or added, and 8 of those lines are covered by unit tests, the "delta" would be -20%, indicating 20% of the newly changed code is untested. However, the "delta" has limitations. It can never be positive, meaning if you add more unit tests to cover existing, unmodified code, this additional coverage is not reflected in the delta. The metric only considers lines directly changed in the current set of modifications, as there is no mechanism to track improvements in coverage for pre-existing code that hasn't been altered.
Do the numbers make more sense with this explanation? I still need the action control to switch this feature off.

Every single line in GetPartitioningCheckpoints.scala is invoked when testing the code yet it reports coverage of 58.1 %.

Any chance to increase the coverage %, @salamonpavel ?

Coincidentally @miroslavpojer today mentioned that jacoco-report had release version 1.7.1 with number of bugifxes. Can you please increase the version in the script to test and see how the new version works.

Those coverage numbers are incorrect.

The new jacoco-report version explains the meaning of the negative percentage numbers.
The "delta" (the negative value next to the coverage) represents the percentage of newly added or modified lines of code that are not covered by unit tests. It calculates the difference in test coverage based solely on the changes made in the current commit or pull request. For example, if 10 lines of code are modified or added, and 8 of those lines are covered by unit tests, the "delta" would be -20%, indicating 20% of the newly changed code is untested. However, the "delta" has limitations. It can never be positive, meaning if you add more unit tests to cover existing, unmodified code, this additional coverage is not reflected in the delta. The metric only considers lines directly changed in the current set of modifications, as there is no mechanism to track improvements in coverage for pre-existing code that hasn't been altered.
Do the numbers make more sense with this explanation? I still need the action control to switch this feature off.

Every single line in GetPartitioningCheckpoints.scala is invoked when testing the code yet it reports coverage of 58.1 %.

The reason for 58,1% is in jacoco.xml
I have retested it on my local and there is 100% coverage after our scala filtering. I looks that scala filtering was not fully applied for XML file.


Consolidate to opentelemetry

Is your feature request related to a problem? Please describe.
Opentracing requires vendor-specific clients.
Describe the solution you'd like
Use opentelemetry with the collector, which makes COS vendor-agnostic.
Describe alternatives you've considered
bundling all clients into COS
Additional context
this was raised by the Glean team.

@bayarmunkh FYI this is in progress.

@bayarmunkh FYI this is in progress.


[Feats] Plugins Sapphire

Create new plugins for sapphire in new repository:

[ ] Sentry
[ ] Prisma

Not sure what you mean with this?
How is this related to Birthdayy?


ARM64&Unix: New unwinder

Implements a custom unwinder for ARM64 that does not need the generic CFI based libunwind functions. This way we only need to loop just once over all used registers instead of doing the complicated CFI process.This will improve the performances for everything that needs a stack walk.
Additional unwind data are generated and stored as part of the LSDA.
-4 byte for a relative offset
-3 byte for the CFA
-3 byte for each register that is part of the prolog save
-1 byte end marker
We still keep the CFI data for the debugger. Maybe the could be removed for a build without debug information.
A possible future optimization would be to introduce a compact format for the information used by the most common cases. This could be stored in the relative offset. But compared to the replacement of libunwind the wins would be rather small.
The same can be done for any  other supported architecture but each one will require a custom unwind function

Could you please share performance numbers:

How much bigger (%) is the native AOT code footprint with this change?
What are the median GC pause time you see before and after this change?

Currently grow by ~2.5% if I keep the cfi unwind data and ~1% if they are removed (only the debugger should need them). Seems I need to improve the encoding some more.
Need to find a good way to measure the performance difference.

Did a quick check. Should be possible to get the unwind info smaller than they current CFI Data used.

Added a compact encoding.
As it can cover most of the stack frames RuyJIT generates the average size of the unwind data per function/funclet (for my test program) is now 2.11 bytes. For the same program the DWARF based unwinder needs 8.46 bytes per function/funclet. If we remove the dwarf data in a release build the executable will get smaller than before. For my test programm 108KB. For larger programs with more functions the savings should be larger.

Performances for a GC.Collect(0) improves from .9 ms to 0.51 ms

(I have not forgotten about this PR. I want to take a detailed look at it that I have not found time for yet.)

Take your time.
In the meantime I noticed that a big chunk of the improvement on Android is not the unwinding itself but to reused the already searched LSDA. But on the switch I see a similar improvement just based on the new unwind code as getting the LSDA is much faster there.
I have a second change ready for another PR that does improve the search for the LSDA independent from the CPU architecture. But I don't now if Android is just a very bad chase or if this happens on every *NIX. If I combine this PR and the other change times go down to 0.11ms per GC.Collect(0)


[html] editor.linkedEditing does not work when the tag contains .

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.94.0
OS Version: Ubuntu 20.04

Steps to Reproduce:

Take the following sample HTML and paste it in a blank HTML file

<Table.Header>
	<Table.Row>
		<Table.Cell>Item</Table.Cell>
		<Table.Cell>Amount</Table.Cell>
	</Table.Row>
</Table.Header>

Enable editor.linkedEditing
Attempt to edit Table.Row in the start or end tag
See that the matching tag does not get edited

I am willing to contribute a fix for this. If I could get a code pointer or two, that would be great. I think I've found the unit test file for the feature, but I haven't found where it's actually implemented yet.

For the record, I was able to reproduce this on main on my machine.

You're right, the original snippet comes from a svelte codebase, and you're also right about HTML tag names only accepting alphanumeric characters. I've found that the wordPattern field in this language-configuration.json affects this feature, as removing the . from the regex fixes the issue I'm having.
I'm assuming that the svelte extension has some similar definition. Given that this isn't technically valid html, I'll forego making a PR here in favor of fixing the extension instead.

This is fixed for me now. It was an issue with svelte.


Use the API to generate GraphQL to SQL from a web browser?

Can join-monster be used as a library on a web browser to generate SQL without having to run a server?
Thanks

To clarify why I would need this. I'm planning on using it with sql.js

I am not the maintainer or a collaborator, but I see no issue with using it in the browser. I just think the overhead using GraphQL + Join Monster to auto-build some queries is too much, but I guess it should work.

Can? Yes. Should you? Not sure. Your query builder would be limited to what your GraphQL schema offers and Join monster's capabilities, which is only a small subset of SQL. Though running in the browser is not the primary use case of this library, if you have any problems running it in a browser, you can consider it a bug, report it as such and we will try to fix it.


[SPARK-47307][SQL][FOLLOWUP] Promote spark.sql.legacy.chunkBase64String.enabled from a legacy/internal config to a regular/public one

What changes were proposed in this pull request?

Promote spark.sql.legacy.chunkBase64String.enabled from a legacy/internal config to a regular/public one.
Add test cases for unbase64

Why are the changes needed?
Keep the same behavior as before. More details: https://github.com/apache/spark/pull/47303#issuecomment-2237785431
Does this PR introduce any user-facing change?

yes, revert behavior change introduced in #47303
How was this patch tested?

existing unit test
Was this patch authored or co-authored using generative AI tooling?

No

cc @gatorsmile too

BTW, @wForget , if you change the configuration name in this PR, the PR title and description should be updated accordingly.
Currently, the PR title and description is not matched.

In addition, the migration guide too.
$ git grep spark.sql.legacy.chunkBase64String.enabled
docs/sql-migration-guide.md:- Since 3.5.2, the `base64` function will return a non-chunked string. To restore the behavior of chunking base64 encoded strings into lines of at most 76 characters, set `spark.sql.legacy.chunkBase64String.enabled` to `true`.

BTW, @wForget , if you change the configuration name in this PR, the PR title and description should be updated accordingly.
Currently, the PR title and description is not matched.

Updated, thank you.

Let's wait for @gatorsmile and @cloud-fan 's review.

The test golden files need to be regenerated, I am doing it.

Oh, this one?
[info] *** 1 TEST FAILED ***
[error] Failed tests:
[error] 	org.apache.spark.sql.connect.ProtoToParsedPlanTestSuite

Oh, this one?

yeah

Merged to master.
Hi @wForget, please help backport this to 3.5. Thank you

It's good to keep the old behavior by default, but I'd like to understand the difference. Which one is more commonly supported in the ecosystem (decoding)? The chunked one or the unchunked one?

Unchunking is the behavior before 3.2(inclusive). Chunking was the behavior introduced accidentally in 3.3. I suggested @wForget in #47303 to make chunking as legacy behavior and unchunking as default, considering that unchunking is more reasonable here and users may not upgrade so eagerly, while chunking is mostly for editors who can not handle long lines. For the unbase64 part, both are valid for decoding.

Hive, Trino, and Clickhouse all seem to be unchunked.
Hive: https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBase64.java
Trino: https://github.com/trinodb/trino/blob/4acd387d3e3dd739a8b2ed00fb48f9bbb00c5ab0/core/trino-main/src/main/java/io/trino/operator/scalar/VarbinaryFunctions.java#L61-L64
Clickhouse: https://github.com/ClickHouse/ClickHouse/blob/a07707c56e5c5ad75b19a0e6f75ec02f0ab6c481/src/Common/Base64.cpp#L18


Centos 8 build fails

Hi all,
I am failing to build this software, I get this error:
Mem.cpp:233:8: error: declaration of ‘void* operator new(size_t) throw (std::bad_alloc)’ has a different exception specifier
void * operator new (size_t size) throw (std::bad_alloc) {
I am not new to C/C++ development but I am puzzled, it seems that the compiler version I am using is incorrect or the source code is broken - the former being more likely I reckon

Same FTBFS on Debian with gcc 10.2.1:
Mem.cpp:233:8: error: declaration of ‘void* operator new(size_t) throw (std::bad_alloc)’ has a different exception specifier
  233 | void * operator new (size_t size) throw (std::bad_alloc) {
      |        ^~~~~~~~

The following page might provide some insights: https://stackoverflow.com/questions/39188919/different-exception-specifier-with-g-6-2
Compiling with -std=c++98 progressed further but stopped on another problem:
Threads.cpp:3357:3: error: ‘pthread_join’ was not declared in this scope; did you mean ‘pthread_kill’?
 3357 |   pthread_join ( e->m_joinTid , NULL );
      |   ^~~~~~~~~~~~
      |   pthread_kill

Un-commenting #define PTHREADS in Threads.cpp (https://github.com/gigablast/open-source-search-engine/blob/master/Threads.cpp#L20) helped which suggests defect in the Makefile.


useEther does not working after "yarn build"

Description:
We are using a usedapp/core's useEthers to fetch the chainId inside of our Create-React-App.
The following code is what we have inside of our custom react provider.
import React from "react"
import { useEthers, ChainId } from "@usedapp/core"

const CustomProvider = ({ children }: ProviderProps) => {
  const { chainId } = useEthers()
  console.log("->>" ,chainId)
  if (!chainId) return <React.Fragment /> // don't render components until we know the chainID
  return <Context.Provider value={chainId}>{children}</Context.Provider>
}

The above code works fine when do yarn start.
We can see the changes in the console log.
However, it fails when run yarn build and serve the static files using e.g serve or on our server.
It' is always returning null.
Stack:
OS: Ubuntu 20 lts
Wallet: MetaMask
Browser: Chrome latest
Any advice would be greatly appreciated.

Issue resolved. It was a problem with my config file.


ARM template for "Azure landing zone" fails when deploying to Azure Gov - "code": "BadRequest"

Describe the bug
ARM template for "Azure landing zone" fails when deploying to Azure Gov - "code": "BadRequest"
Steps to reproduce

Log into Azure Gov tenant Portal
Create a Resource
Template deployment
Select Azure landing zone
Where applicable - Select "Yes" to deploying defined Azure policy
Review & Create
Deployment fails with the following message details: "message": "{\r\n  "error": {\r\n    "code": "PolicyDefinitionNotFound",\r\n    "message": "The policy set definition 'Deploy-ASCDF-Config' request is invalid. The following policy definitions could not be found: '/providers/Microsoft.Authorization/policyDefinitions/44433aa3-7ec2-4002-93ea-65c65ff0310a;/providers/Microsoft.Authorization/policyDefinitions/50ea7265-7d8c-429e-9a7d-ca1f410191c3;/providers/Microsoft.Authorization/policyDefinitions/b40e7bcd-a1e5-47fe-b9cf-2f534d0bfb7d;/providers/Microsoft.Authorization/policyDefinitions/64def556-fbad-4622-930e-72d1d5589bf5;/providers/Microsoft.Authorization/policyDefinitions/1f725891-01c0-420a-9059-4fa46cb770b7'."\r\n  }\r\n}"

This error is occurring with deployments targeted towards Azure Gov cloud because the json files listed under the url below reference policy definitions which only exist in the Azure Commercial cloud.
https://github.com/Azure/Enterprise-Scale/tree/main/eslzArm/managementGroupTemplates/policyDefinitions/gov
fairfaxDENY-PublicEndpointsPolicySetDefinition.json
fairfaxDINE-PrivateDNSZonesPolicySetDefinition.json
fairfaxPolicies.json
I have searched policy definitions in Azure Gov and have provided what I believe is the Azure Gov equivalent policies below which should be called within the referenced json files.
Az Comm-> Configure Azure Defender for open-source relational databases to be enabled -> 44433aa3-7ec2-4002-93ea-65c65ff0310a
Az Gov -> Configure Advanced Threat Protection to be enabled on open-source relational databases -> /providers/Microsoft.Authorization/policySetDefinitions/e77fc0b3-f7e9-4c58-bc13-cb753ed8e46e
Az Comm -> Configure Azure Defender for SQL servers on machines to be enabled -> 50ea7265-7d8c-429e-9a7d-ca1f410191c3
Az Gov -> Configure Azure Defender to be enabled on SQL servers -> /providers/Microsoft.Authorization/policyDefinitions/36d49e87-48c4-4f2e-beed-ba4ed02b71f5
Az Comm -> Configure Azure Defender for App Service to be enabled -> b40e7bcd-a1e5-47fe-b9cf-2f534d0bfb7d
Az Gov -> Deploy Azure Defender for Azure App Services -> /providers/Microsoft.Management/managementGroups/usva/providers/Microsoft.Authorization/policyDefinitions/Deploy-ASC-Defender-AppSrv
Az Comm -> [Preview]: Configure Azure Kubernetes Service clusters to enable Defender profile -> 64def556-fbad-4622-930e-72d1d5589bf5
Az Gov -> Configure Azure Defender for Kubernetes to be enabled -> /providers/Microsoft.Authorization/policyDefinitions/133047bf-1369-41e3-a3be-74a11ed1395a
Az Comm -> Configure Azure Defender for Key Vaults to be enabled -> 1f725891-01c0-420a-9059-4fa46cb770b7
Az Gov -> Deploy Azure Defender for AKV -> /providers/Microsoft.Management/managementGroups/usva/providers/Microsoft.Authorization/policyDefinitions/Deploy-ASC-Defender-AKV
Screenshots

Thank you for submitting this issue. There are currently a few built-in policies missing in Gov that we will track. We will create a short-term fix to ignore these for now, and re-enable once available. (The resourceId is the same across public and gov)

Running through the ARM template selecting all options but deselecting the recommended option to deploy ASC still fails with the same error.
BTW - As I mentioned, via Azure Gov tenant portal -> Policy -> Definitions -> search field -> past each ID as noted in the error and NONE are found in Az Gov. Doing so in Az Comm via my AIRS subscription I do find the IDs. Additionally, I searched Az Gov based on the name and again didn't find parity. That said - as I documented above I did find the policies in Az Gov which I believe achieve the same result as the ones in Az Comm which is why I documented those for you in the hopes it would speed the resolution along faster.  This time I have also attached a screenshot.

r.

Hey @techdawg70,
Can you confirm on the "Platform management, security and governance" blade this option is set to "no"?

Just an update on my looking into this, the workaround suggested above will not work due to the deployment of the policies is non-conditional in the eslzARM.json template: https://github.com/Azure/Enterprise-Scale/blob/main/eslzArm/eslzArm.json#L900 that is used by the deployment. And this is where your deployment is failing today.
We are investigating a fix internally and will come back to this thread when we have a way forward 👍

Just to add on to this ticket.
This is a major roadblock for my organization as we are in the process of standing up our Azure Government tenant. We have been working with Microsoft employees to build out our environment using the Cloud Adoption Framework and this is a core part of that process.
Prompt attention to this issue would be greatly appreciated.

Thanks @seversen. We have a fix ready and will release shortly depending on test results.

Any further updates on this bug or ETA for a fix to be available?

Hey @seversen this is linked to the PR #863 which is under review at this time.
It's close 👍

Awesome. This resolved the issues. Thanks again for the quick fix!!!


Validate copy and page numbers for scanned exam fix_errors

Motivation and Context

When investigating an issue related to fixing pages, I encountered a bug where the copy and page numbers on the scanned exam "fix errors" page weren't being validated either client-side nor server-side. This could cause MarkUs to get into a funny state.
Your Changes

Description: Added validation for copy and page numbers, and a mechanism for the server to flash error messages back to the client.
Screenshot:

Type of change (select all that apply):

[x] Bug fix (non-breaking change which fixes an issue)

Testing

Tested in the UI and added some test cases. Note: ExamTemplatesController#fix_error didn't seem to be tested at all before, and I've just added some tests for the error cases in this PR.
Questions and Comments (if applicable)

Checklist

[x] I have performed a self-review of my own code.
[x] I have verified that the pre-commit.ci checks have passed.
[ ] I have verified that the CI tests have passed.
[ ] I have reviewed the test coverage changes reported on Coveralls.
[x] I have added tests for my changes.
[x] I have updated the Changelog.md file.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

44 of 53 (83.02%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 91.845%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/models/exam_template.rb
2
11
18.18%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
37787

Relevant Lines:
40602

💛  - Coveralls


MyVector parameterized constructor

The parameterized constructor in my-vector.cpp initializes the new array using the size variable instead of capacity as shown below:

Fixed.
0e444321


Multiple Images

I'd like to have N images in my carousel per slide. Is this possible or something in the pipeline?
All examples I've seen all have just image visible in the viewport.

I  found the answer (kind of) http://stackoverflow.com/questions/26252038/multi-item-responsive-carousel....
However it would be nice to give angular-carousel an array of items and a param to set how many per slide and it do everything else.
Is this something has been tried in the past by anyone?
When I get time I'll fork the repo and look into the code.

well this is just a matter of template. if you organize your data it should be easy.
here's a non-working exampe but gives you the idea : https://github.com/revolunet/angular-carousel/blob/master/demo/flickr-full/index.html#L85-L95

Is there any possibility to get next element with multiple items per view(slide), e.g. if you have 2 items in slide when click next - move slide to half ow slide with.
there is jQuery slider that have imaginable features http://dev7studios.com/caroufredsel-old/examples/basic-carousels.php


Update intro.md

- Summary

- Test plan

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@ko-in Why do you think it should be called "Introduction11"?


fix coverity deference after null check, uninitialised scalar variabless and dereferences after null checks.

coverity 1474426: uninitialised scalar variable: based on the value, it would with work properly or produce an error.  Most likely seems to have been the former.
coverity 1452768: dereference after null check
fix coverity 271258:, 1371689, 1371690, 1451499, 1451501, 1451506, 1451507, 1351511, 145151, 1451574:, 1454812, 1469427, 1451534 & 1451544: improper use of negative values

[ ] documentation is added or updated
[ ] tests are added or updated

The PR subject is misleading as this fixes many other issues as well.

I forgot to make a new branch and figured I go with the flow.  I've updated the PR title and intro to match the contents.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.


Subsample of dataset

Hello, is it possible to download just a subset of the dataset? This is to browse through the data first, since investing in 4.7 TB is quite a lot.

We've been thinking about a demo but haven't made one yet since we have yet to decide which patients to include. For now I'd suggest one of two things: first you can view the DICOM files and the text files via PhysioNet if that helps. Alternatively it's pretty easy to download just a subset once you get gsutil working, something like:
gsutil -m cp -r gs://mimic-cxr-2.0.0.physionet.org/files/p10/p10000032 ./
.. which downloads all the DICOMs for a single patient (100 MB) and
gsutil -m cp -r gs://mimic-cxr-2.0.0.physionet.org/files/p10/p10000* ./
... which downloads the DICOMs for 4 patients (500 MB).
There's some instructions on gsutil on the website: https://mimic-cxr.physionet.org/about/download/

Thank you!


TPU error

Hi,
I am getting a TPU error on Colab and I am using the latest version of lightning.
Notebook
Trainer:
trainer = pl.Trainer(tpu_cores=8, precision=16, logger=logger, checkpoint_callback=checkpoint_callback, progress_bar_refresh_rate=50, accumulate_grad_batches=2, fast_dev_run=False,\
                    default_root_dir=root_path, auto_lr_find=True, gradient_clip_val=0.5,\
                    profiler=True,  max_epochs=1000, callbacks=[lr_monitor, early_stop, PrintTableMetricsCallback()])

Stack trace:
GPU available: False, used: False
TPU available: True, using: 8 TPU cores
Using native 16bit precision.
training on 8 TPU cores
INIT TPU local core: 0, global rank: 0 with XLA_USE_BF16=1
Exception in device=TPU:0: dictionary update sequence element #0 has length 1; 2 is required
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/torch_xla/distributed/xla_multiprocessing.py", line 330, in _mp_start_fn
    _start_fn(index, pf_cfg, fn, args)
  File "/usr/local/lib/python3.6/dist-packages/torch_xla/distributed/xla_multiprocessing.py", line 324, in _start_fn
    fn(gindex, *args)
  File "/usr/local/lib/python3.6/dist-packages/pytorch_lightning/accelerators/tpu_backend.py", line 122, in tpu_train_in_process
    self.trainer.train_loop.setup_training(model)
  File "/usr/local/lib/python3.6/dist-packages/pytorch_lightning/trainer/training_loop.py", line 132, in setup_training
    self.trainer.logger.save()
  File "/usr/local/lib/python3.6/dist-packages/pytorch_lightning/utilities/distributed.py", line 35, in wrapped_fn
    return fn(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/pytorch_lightning/loggers/tensorboard.py", line 220, in save
    save_hparams_to_yaml(hparams_file, self.hparams)
  File "/usr/local/lib/python3.6/dist-packages/pytorch_lightning/core/saving.py", line 378, in save_hparams_to_yaml
    yaml.dump(hparams, fp)
  File "/usr/local/lib/python3.6/dist-packages/yaml/__init__.py", line 290, in dump
    return dump_all([data], stream, Dumper=Dumper, **kwds)
  File "/usr/local/lib/python3.6/dist-packages/yaml/__init__.py", line 278, in dump_all
    dumper.represent(data)
  File "/usr/local/lib/python3.6/dist-packages/yaml/representer.py", line 27, in represent
    node = self.represent_data(data)
  File "/usr/local/lib/python3.6/dist-packages/yaml/representer.py", line 48, in represent_data
    node = self.yaml_representers[data_types[0]](self, data)
  File "/usr/local/lib/python3.6/dist-packages/yaml/representer.py", line 207, in represent_dict
    return self.represent_mapping('tag:yaml.org,2002:map', data)
  File "/usr/local/lib/python3.6/dist-packages/yaml/representer.py", line 118, in represent_mapping
    node_value = self.represent_data(item_value)
  File "/usr/local/lib/python3.6/dist-packages/yaml/representer.py", line 52, in represent_data
    node = self.yaml_multi_representers[data_type](self, data)
  File "/usr/local/lib/python3.6/dist-packages/yaml/representer.py", line 343, in represent_object
    'tag:yaml.org,2002:python/object:'+function_name, state)
  File "/usr/local/lib/python3.6/dist-packages/yaml/representer.py", line 118, in represent_mapping
    node_value = self.represent_data(item_value)
ValueError: dictionary update sequence element #0 has length 1; 2 is required
---------------------------------------------------------------------------
Exception                                 Traceback (most recent call last)
<ipython-input-16-2e5877a52826> in <module>()
      4 trainer = pl.Trainer(tpu_cores=8, precision=16, logger=logger, checkpoint_callback=checkpoint_callback, progress_bar_refresh_rate=50, accumulate_grad_batches=2, fast_dev_run=False,                    default_root_dir=root_path, auto_lr_find=True, gradient_clip_val=0.5,                    profiler=True,  max_epochs=1000, callbacks=[lr_monitor, early_stop, PrintTableMetricsCallback()])
      5
----> 6 trainer.fit(model_one)

4 frames
/usr/local/lib/python3.6/dist-packages/pytorch_lightning/trainer/trainer.py in fit(self, model, train_dataloader, val_dataloaders, datamodule)
    420         self.call_hook('on_fit_start')
    421
--> 422         results = self.accelerator_backend.train()
    423         self.accelerator_backend.teardown()
    424

/usr/local/lib/python3.6/dist-packages/pytorch_lightning/accelerators/tpu_backend.py in train(self)
     95                 args=(model, self.trainer, self.mp_queue),
     96                 nprocs=self.trainer.tpu_cores,
---> 97                 start_method=self.start_method
     98             )
     99

/usr/local/lib/python3.6/dist-packages/torch_xla/distributed/xla_multiprocessing.py in spawn(fn, args, nprocs, join, daemon, start_method)
    393         join=join,
    394         daemon=daemon,
--> 395         start_method=start_method)
    396
    397

/usr/local/lib/python3.6/dist-packages/torch/multiprocessing/spawn.py in start_processes(fn, args, nprocs, join, daemon, start_method)
    155
    156     # Loop on join until it returns True or raises an exception.
--> 157     while not context.join():
    158         pass
    159

/usr/local/lib/python3.6/dist-packages/torch/multiprocessing/spawn.py in join(self, timeout)
    110                 raise Exception(
    111                     "process %d terminated with exit code %d" %
--> 112                     (error_index, exitcode)
    113                 )
    114

Exception: process 0 terminated with exit code 17

As per the XLA troubleshooting guide:

Tensor shapes should be the same between iterations, or a low number of shape variations should be used.

In this application the images shapes are different for each batch. Could that be the issue?

Seems like there's an issue while trying to save the hyperparams. @rohitgr7 any idea about this?
Also I am unable to run the entire notebook as the data is present in Google Drive.

yeah maybe, if either we can somehow get the data or just input data shape, maybe we can reproduce this and check the real issue here.

@rohitgr7 @lezwon Images are of different shape ranging form a few pixels to 65k pixels per channel. The images are padded in a batch to make them of an equal shape. So, the batch shapes would differ.

@ishgirwan mind trying by excluding the model from saving in hyperparameters? just call self.save_hyperparameters('batch_size', 'learning_rate') instead of self.save_hyperparameters().

@lezwon It seems to be working. But I got this error. It may be a RAM issue as the model was training for some time for a batch size of 8 on Colab(15GB). I am new to TPUs so how should I manage the batch size wrt the number of cores? Thanks a lot.
training on 8 TPU cores
INIT TPU local core: 0, global rank: 0 with XLA_USE_BF16=None
INIT TPU local core: 4, global rank: 4 with XLA_USE_BF16=None
INIT TPU local core: 3, global rank: 3 with XLA_USE_BF16=None
INIT TPU local core: 7, global rank: 7 with XLA_USE_BF16=None
INIT TPU local core: 2, global rank: 2 with XLA_USE_BF16=None
INIT TPU local core: 1, global rank: 1 with XLA_USE_BF16=None
INIT TPU local core: 5, global rank: 5 with XLA_USE_BF16=None
INIT TPU local core: 6, global rank: 6 with XLA_USE_BF16=None

  | Name  | Type   | Params
---------------------------------
0 | model | ResNet | 11 M
Validation sanity check: 0%
0/2 [00:55<?, ?it/s]
Epoch 0: 18%
50/281 [13:45<1:03:33, 16.51s/it, loss=0.013, v_num=66, train_loss_step=0.0138, train_loss=0.0138]
Exception in thread Thread-8:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 875, in _try_get_data
    data = self._data_queue.get(timeout=timeout)
  File "/usr/lib/python3.6/multiprocessing/queues.py", line 113, in get
    return _ForkingPickler.loads(res)
  File "/usr/local/lib/python3.6/dist-packages/torch/multiprocessing/reductions.py", line 282, in rebuild_storage_fd
    fd = df.detach()
  File "/usr/lib/python3.6/multiprocessing/resource_sharer.py", line 57, in detach
    with _resource_sharer.get_connection(self._id) as conn:
  File "/usr/lib/python3.6/multiprocessing/resource_sharer.py", line 87, in get_connection
    c = Client(address, authkey=process.current_process().authkey)
  File "/usr/lib/python3.6/multiprocessing/connection.py", line 493, in Client
    answer_challenge(c, authkey)
  File "/usr/lib/python3.6/multiprocessing/connection.py", line 732, in answer_challenge
    message = connection.recv_bytes(256)         # reject large message
  File "/usr/lib/python3.6/multiprocessing/connection.py", line 216, in recv_bytes
    buf = self._recv_bytes(maxlength)
  File "/usr/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes
    buf = self._recv(4)
  File "/usr/lib/python3.6/multiprocessing/connection.py", line 383, in _recv
    raise EOFError
EOFError

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.6/dist-packages/torch_xla/distributed/parallel_loader.py", line 141, in _loader_worker
    _, data = next(data_iter)
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 438, in __next__
    data = self._next_data()
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 1071, in _next_data
    idx, data = self._get_data()
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 1037, in _get_data
    success, data = self._try_get_data()
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 888, in _try_get_data
    raise RuntimeError('DataLoader worker (pid(s) {}) exited unexpectedly'.format(pids_str)) from e
RuntimeError: DataLoader worker (pid(s) 1816) exited unexpectedly
Exception in thread Thread-10:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 875, in _try_get_data
    data = self._data_queue.get(timeout=timeout)
  File "/usr/lib/python3.6/multiprocessing/queues.py", line 113, in get
    return _ForkingPickler.loads(res)
  File "/usr/local/lib/python3.6/dist-packages/torch/multiprocessing/reductions.py", line 282, in rebuild_storage_fd
    fd = df.detach()
  File "/usr/lib/python3.6/multiprocessing/resource_sharer.py", line 57, in detach
    with _resource_sharer.get_connection(self._id) as conn:
  File "/usr/lib/python3.6/multiprocessing/resource_sharer.py", line 87, in get_connection
    c = Client(address, authkey=process.current_process().authkey)
  File "/usr/lib/python3.6/multiprocessing/connection.py", line 493, in Client
    answer_challenge(c, authkey)
  File "/usr/lib/python3.6/multiprocessing/connection.py", line 732, in answer_challenge
    message = connection.recv_bytes(256)         # reject large message
  File "/usr/lib/python3.6/multiprocessing/connection.py", line 216, in recv_bytes
    buf = self._recv_bytes(maxlength)
  File "/usr/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes
    buf = self._recv(4)
  File "/usr/lib/python3.6/multiprocessing/connection.py", line 383, in _recv
    raise EOFError
EOFError

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.6/dist-packages/torch_xla/distributed/parallel_loader.py", line 141, in _loader_worker
    _, data = next(data_iter)
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 438, in __next__
    data = self._next_data()
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 1071, in _next_data
    idx, data = self._get_data()
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 1037, in _get_data
    success, data = self._try_get_data()
  File "/usr/local/lib/python3.6/dist-packages/torch/utils/data/dataloader.py", line 888, in _try_get_data
    raise RuntimeError('DataLoader worker (pid(s) {}) exited unexpectedly'.format(pids_str)) from e
RuntimeError: DataLoader worker (pid(s) 1851, 1856) exited unexpectedly

---------------------------------------------------------------------------
ProcessExitedException                    Traceback (most recent call last)
<ipython-input-15-fbb0322b0ef6> in <module>()
----> 1 trainer.fit(model_one)

4 frames
/usr/local/lib/python3.6/dist-packages/torch/multiprocessing/spawn.py in join(self, timeout)
    150                     error_pid=failed_process.pid,
    151                     exit_code=exitcode,
--> 152                     signal_name=name
    153                 )
    154             else:

ProcessExitedException: process 3 terminated with signal SIGKILL

I think the model could not be parsed to yaml, as showing in the error. Probably avoid storing complex objects like models within hyperparams. :) Also to debug the above error, I'll need access to the notebook with the data. It's very hard to guess what might be going wrong without having a reproducible notebook.

Thanks :) Can we connect on the pytorch lightning slack channel? I can dm you the details over there.

Sure 👍

@ishgirwan I had a look at the notebook. I strongly suspect colab runs out of memory during the training, due to the dynamic size of your inputs. XLA will compile a new graph for every example if it has a different size than the others. Reference. Try padding your inputs to maintain a consistent size. Let me know if that works.

Also I dont think this optimizer_step function needs to be defined. Lightning handles this behind the scenes and calls xm.optimizer_step(optimizer) when training on TPU's. 👍
def optimizer_step(self, current_epoch, batch_idx, optimizer,
      optimizer_idx, second_order_closure=None,
       on_tpu=False, using_native_amp=False, using_lbfgs=False):
        optimizer.step()

Thanks a lot @lezwon for looking into this issue. As you mentioned, the issue is probably with the way XLA functions, since the code has worked properly with GPU. Padding would work as the images will then be of equal size. I will close this issue now.
Also, I have hosted the dataset at Kaggle. Thanks again.


New endpoints to the API

For example, we could make it easy to serve some specific tasks, such as

[x] #11
[ ] #23
[ ] Dialog between two persons, plus some kind of memory buffer

@vicgalle
Hi there,
I'm noticing that the version of the serve.py file on the main branch doesn't seem to actually be creating the zero-shot classification endpoint that should have been added in the v0.3 release. Am I missing something obvious?
I'm super excited to try out that feature!
Thanks,
Daniel

@vicgalle
Hi there,
I'm noticing that the version of the serve.py file on the main branch doesn't seem to actually be creating the zero-shot classification endpoint that should have been added in the v0.3 release. Am I missing something obvious?
I'm super excited to try out that feature!
Thanks,
Daniel

Hi @danielweidman , thank you for your interest in the new version!
I have not made public the changes in the implementation yet since i'm planning on a refactor of the server code (while keeping the public API intact) after I return from vacation.
However, if you are interested in setting up a zero-shot classification model, the one that is currently serving the API is this one: https://huggingface.co/vicgalle/xlm-roberta-large-xnli-anli (there are instructions there).
Let me know if you have further questions!

I see! Thanks very much for the info and that link! I hope your vacation is going well.


Upgrade calico-accountant image and chart

[!warning]
This is a public repository, ensure not to disclose:

[ ] personal data beyond what is necessary for interacting with this pull request, nor
[ ] business confidential information, such as customer names.

What kind of PR is this?
Required: Mark one of the following that is applicable:

[ ] kind/feature
[ ] kind/improvement
[ ] kind/deprecation
[ ] kind/documentation
[x] kind/clean-up
[ ] kind/bug
[ ] kind/other

Optional: Mark one or more of the following that are applicable:

[!important]
Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

[ ] kind/admin-change
[ ] kind/dev-change
[ ] kind/security
[ ] kind/adr

What does this PR do / why do we need this PR?

This updates the calico-accountant image to one with an updated Alpine base system.
The Go binary of calico-accountant itself is not updated due to difficulties rebuilding it from source. See Dockerfile for process.

Fixes https://github.com/elastisys/ck8s-issue-tracker/issues/274

Information to reviewers

$ kubectl set image -n calico-system ds calico-accountant calico-accountant=ghcr.io/elastisys/calico-accountant:0.1.6.ck8s1

Checklist

[x] Proper commit message prefix on all commits

Change checks:

[x] The change is transparent
[ ] The change is disruptive
[x] The change requires no migration steps
[ ] The change requires migration steps
[ ] The change upgrades CRDs
[ ] The change updates the config and the schema

Metrics checks:

[ ] The metrics are still exposed and present in Grafana after the change
[x] The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
[ ] The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)

Logs checks:

[x] The logs do not show any errors after the change

Pod Security Policy checks:

[ ] Any changed pod is covered by Pod Security Admission
[ ] Any changed pod is covered by Gatekeeper Pod Security Policies
[ ] The change does not cause any pods to be blocked by Pod Security Admission or Policies

Network Policy checks:

[ ] Any changed pod is covered by Network Policies
[ ] The change does not cause any dropped packets in the NetworkPolicy Dashboard

Audit checks:

[ ] The change does not cause any unnecessary Kubernetes audit events
[ ] The change requires changes to Kubernetes audit policy

Falco checks:

[ ] The change does not cause any alerts to be generated by Falco

Bug checks:

[ ] The bug fix is covered by regression tests

Nice, the image does not seem to contain any vulnerabilities anymore when I checked with Trivy, and I assume you tested that it still works. Also nice that you upgraded the upstream calico chart, but could you also update our self-managed calico-accountant chart so that it will use the new image?

Outch, I think I botched a rebase that was meant to drop the calico commit, and instead dropped the commit updating the calico-accountant chart. Will fix tomorrow.

Could you add the results after scanning the new image? :slightly_smiling_face: Then it LGTM :tada:

Can't seem to run the trivy CLI here, but how about:

Hm, I think my mistake was trying to update the Go dependencies and using the Go 1.11+ module system. This fails. For some reason, building the image from the upstream repo without changing anything works. But without updated Go dependencies, this should be equivalent to reusing the previous binary. :shrug:


Retina icon for adding the demo to home screen is missing

When adding the demo for home screen, the icon is really blurry

For iOS specifically you can use something like this
<link rel="apple-touch-icon" href="touch-icon-iphone.png">
<link rel="apple-touch-icon" sizes="152x152" href="touch-icon-ipad.png">
<link rel="apple-touch-icon" sizes="180x180" href="touch-icon-iphone-retina.png">
<link rel="apple-touch-icon" sizes="167x167" href="touch-icon-ipad-retina.png">

but maybe you want to use a tool to generate ALL THE ICONS! Something like this one: http://realfavicongenerator.net/

BTW the icon that we are using as favicon was a temp before we had the official icon. It should (probably) be changed.


[PyTorch]Add PyTorchTVM: compile torchscript to tvm and export as pytorch_op

To increase the TVM accessibility for PyTorch users, we add PyTorchTVM module to support the following workflow:

convert a torchscript module to tvm graph
build and tune tvm graph
export well-tuned tvm graph as a pytorch op
torch jit trace the tvm pytorch op with other pytorch modules, then save/load/serve as normal pytorch model

The example usage is here: apps/pt_class/tests/test_pt_script.py. We hope to further discuss the user api with the community. Please help review @Laurawly  @junrushao1994 @tqchen, thanks!
Credit: the original author is @kongroo .

CC @masahi @alexwong @comaniac @yzhliu

It would be good for this scope of new feature to start with an RFC.

Yeah it is super exciting feature for TVM, so would get more visibility in the community if we have like a RFC

Thanks, I will write an RFC this week.

Update:

RFC: https://github.com/apache/tvm-rfcs/pull/25
discuss: https://discuss.tvm.apache.org/t/rfc-pytorchtvm-compile-torchscript-to-tvm-and-use-accelerated-module-in-pytorch/10873

Looks great!
We have ever implemented a similar approach to put a optimized tvm graph runtime back to TensorFlow and Pytorch through custom ops. For some reason we're not able to split those codes out from another project. Glad to have this feature in main branch!
cc @minminsun

@Meteorix any updates on when this will be ready for review? happy to help shepherd these changes and work with you to get them merged.

@jroesch we just had long discussion in the RFC and the RFC was merged weeks ago. @Meteorix was a bit little in the recent weeks but will follow up soon

@Meteorix any updates on when this will be ready for review? happy to help shepherd these changes and work with you to get them merged.

Yes, it's ready for review!

@Meteorix I recently learned about TRTorch. Is it reasonable to say that PyTorchTVM is similar to what TRTorch does with TensorRT + Torch?

reasonable

@Meteorix I recently learned about TRTorch. Is it reasonable to say that PyTorchTVM is similar to what TRTorch does with TensorRT + Torch?

Yes, actually the proposed frontend API is inspired by TRTorch

@Meteorix any updates on when this will be ready for review? happy to help shepherd these changes and work with you to get them merged.

Yes, it's ready for review!

Great, I will take a pass this weekend and we can maybe aim for version one next week sometime?

Coming late to the discussion, thanks for the great work. It would be nice to discuss the naming a bit. Given we are moving towards a serious first class PT support. Some namespace ideas:

tvm.contrib.pt_op
tvm.contrib.pytorch
tvm.contrib.torch

Coming late to the discussion, thanks for the great work. It would be nice to discuss the naming a bit. Given we are moving towards a serious first class PT support. Some namespace ideas:

tvm.contrib.pt_op
tvm.contrib.pytorch
tvm.contrib.torch

I'm in favor of tvm.contrib.torch. pt_op is not accurate because It's actually implemented by custom class, not custom op. And torch is shorter than pytorch.

@kongroo Please make sure to pass the CI.
@jroesch @junrushao1994 @tqchen @comaniac Please take a look if you want to review. Otherwise I'm going to merge this week, I think we can bring this to the v0.8 release.

@kongroo Looks like you've hit an unfortunate flaky test error, please kick another job.

@kongroo Looks like you've hit an unfortunate flaky test error, please kick another job.

Finally CI passed...

Thanks @Meteorix @kongroo this is merged!


Unbookable and slot anomalies for Cardiff

Cardiff got in touch to request unbookable/slot anomalies due to bank
holidays and staff training:
MONDAY 4th MAY 2015 – 1.30pm ONLY (Bank Holiday)
WEDNESDAY 6th MAY 2015 – NO VISITS (Staff Training Day)
MONDAY 25th MAY 2015 – 1.30pm ONLY (Bank Holiday)
WEDNESDAY 27th MAY 2015 – NO VISITS (Family Day)

Missed this last week, but I wanted to mention that this is an excellent pull request, thanks @RoseFaulkner! :trophy:


Color picker for changing the text color of the text

Im not sure if it's already possible but is there a way to add a color picker to change the text color of the text?

Im not sure if it's already possible but is there a way to add a color picker to change the text color of the text?

custom input maybe


In the Cart rule there should be adate & time calendar. currently it shows only date.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
master
Issue Description
In the cart rule create/edit form, there should be a date& time calendar. because In the calendar time option is missing and on the listing page it shows the time as 00:00. so there should be a date & time calendar.
Preconditions

Admin should be logged in.

Steps to reproduce

Go to 'Admin panel'
Click on 'Create cart rule' inside the Promotion/Cart rule
Fill in all the required fields and select the start end date
Save it
See the error

Expected Result
It should show the date & time calendar. there should be a time in the promotions.
Actual Result
it shows only the date calendar. Here
Screenshots
No response
Additional context
No response

Checked and Found that the date and time calender has been added.
check screenshot here

Checked and Found that the issue has been fixed and also the PR has been merged, hence I am closing the issue.
Please check the screenshot here


Mobilenet V1 SSD - Small Object Detection issue

I successfully did transfer learning on custom object detection with Mobilenet V1 SSD. I used Pytorch SSD train.py provided with this repo and my custom dataset (Open Images format).
I'm getting very high confidence levels but as soon as the object becomes smaller than a certain size even if it is showing clearly the SSD won't detect it at all.
Is there any way to re-configure the SSD model to make it look for smaller objects as well?
Thanks

i've being handling the same problem with my custom object detection and I'll try to label and train this small object as another class, I don't know if it works for you, but I think this is an idea.

I noticed that as I add more pictures to the dataset the confidence level for smaller objects rises.
But I like your idea. I guess in that case the new class for the smaller version of the object should be trained on small objects, right?
I wonder if there is a way of changing the sizes of the SSD pre-fabricated (not sure of the correct terminology) detection boxes to make the small ones smaller...

But I like your idea. I guess in that case the new class for the smaller version of the object should be trained on small objects, right?

Yes, that's the idea.

I wonder if there is a way of changing the sizes of the SSD pre-fabricated (not sure of the correct terminology) detection boxes to make the small ones smaller...

maybe this should help you.


Better Shortcuts Editor

What improvement do you think would an existing feature in CtrlHelp?
Currently you can edit the shortcuts of pre-existing items. However, it could be have some added functionality/organization features that would be useful.
Solution/Idea

Ability to add your own items and your own categories.
Ability to delete categories and items because not everybody is going to need all of the built-in ones.

Comments
No response

It would also be nice to add new apps and new shortcuts from the app

Hi,
While Crunchbits request is indeed something missing in CtrlHelp, what you are asking @Raynbda is already possible using CtrlHelp Editor : https://github.com/veler/CtrlHelpApp/tree/main/Tools/CtrlHelpEditor#ctrlhelp-editor
It is this tool that I use to add support for new softwares to CtrlHelp :)

I meant something that's simple to use and built into the app. like you would right click on the apps page and click "add app"


Win10 1607 - Unable to find type [Windows.UI.Notifications.NotificationData]

First off, I think this tool is great. Keep up the great work! As for my problem, I've been experimenting with version 0.7.0 of this tool on two Win10 machines: one physical, the other virtual. When I try running New-BurntToastNotification on my physical machine, the toast is created but the title text is encapsulated in curly braces and I get the error below. It works fine on my VM, however.

Unable to find type [Windows.UI.Notifications.NotificationData].
At C:\Program Files\WindowsPowerShell\Modules\BurntToast\0.7.0\BurntToast.psm1:2193 char:19
+     $Toast.Data = [Windows.UI.Notifications.NotificationData]::new($D ...
+                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (Windows.UI.Noti...otificationData:TypeName) [], RuntimeException
    + FullyQualifiedErrorId : TypeNotFound

Here are the PS and OS build differences between the two machines:
Physical

PSVersion: 5.1.14393.3053
BuildVersion: 10.0.14393.3053 (Version 1607)

VM

PSVersion: 5.1.17763.771
BuildVersion: 10.0.17763.771 (Version 1809)

As you can see, my physical machine is running a much older version of Windows 10. I assume it has something to do with that. On the physical machine, I first tried importing the module in a PS session (without installing it, as I don't like installing modules I'm just playing around with). For the sake of troubleshooting, I then tried installing the module from the PowerShell Gallery. Both ways resulted in the error above. On my VM, I can do a temporary import of the module and it works fine.
I'd really like to be able to use 0.7.0 on Win10 1607. Is it possible?

I think I might have to build in some logic to account for older versions
of Windows 10... that'll be a 0.7.1 type thing.
On Fri, 1 Nov 2019 at 09:19, AdamOSDev<EMAIL_ADDRESS>wrote:

First off, I think this tool is great. Keep up the great work! As for my
problem, I've been experimenting with version 0.7.0 of this tool on two
Win10 machines: one physical, the other virtual. When I try running
New-BurntToastNotification on my physical machine, the toast is created but
the title text is encapsulated in curly braces and I get the error below.
It works fine on my VM, however.
[image: Capture]
https://user-images.githubusercontent.com/57235172/67982138-55f66280-fbdf-11e9-80ef-4c2d72573b7d.PNG
Unable to find type [Windows.UI.Notifications.NotificationData].
At C:\Program Files\WindowsPowerShell\Modules\BurntToast\0.7.0\BurntToast.psm1:2193 char:19

$Toast.Data = [Windows.UI.Notifications.NotificationData]::new($D ...

              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : InvalidOperation: (Windows.UI.Noti...otificationData:TypeName) [], RuntimeException
FullyQualifiedErrorId : TypeNotFound

Here are the PS and OS build differences between the two machines:
Physical

PSVersion: 5.1.14393.3053
BuildVersion: 10.0.14393.3053 (Version 1607)

VM

PSVersion: 5.1.17763.771
BuildVersion: 10.0.17763.771 (Version 1809)

As you can see, my physical machine is running a much older version of
Windows 10. I assume it has something to do with that. On the physical
machine, I first tried importing the module in a PS session (without
installing it, as I don't like installing modules I'm just playing around
with). For the sake of troubleshooting, I then tried installing the module
from the PowerShell Gallery. Both ways resulted in the error above. On my
VM, I can do a temporary import of the module and it works fine.
I'd really like to be able to use 0.7.0 on Win10 1607. Is it possible?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Windos/BurntToast/issues/81?email_source=notifications&email_token=ABVCGCQTRYGIJ2FPJLBS2NDQRM4ULA5CNFSM4JHR5XEKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HV5HHXA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVCGCUSPSHFB35EBZHBRWTQRM4ULANCNFSM4JHR5XEA
.

That would be great, as there are so many different versions and builds of Win10.
What's the 'official' minimum version/build of Win10 needed for 0.7.0?

I'm not sure... Until now I didn't realise there was. It's really hard to
test across all of them (and my person machines tend to be on the latest)
On Fri, 1 Nov 2019, 10:00 AM AdamOSDev<EMAIL_ADDRESS>wrote:

That would be great, as there are so many different versions and builds of
Win10.
What's the 'official' minimum version/build of Win10 needed for 0.7.0?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Windos/BurntToast/issues/81?email_source=notifications&email_token=ABVCGCSSIBIEAZSTHL57Q4LQRNBQJA5CNFSM4JHR5XEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECZHN7I#issuecomment-548566781,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVCGCRWQBDZX3J2E54EYLTQRNBQJANCNFSM4JHR5XEA
.

0.6.3 seems to be working properly on my physical machine.

I get the same error message with Windows Server 2016 (version 1607) and BurntToast version 0.7.0
Can you please fix this error?

hi,
i have got the same problem on my Windows Server 2016 (version 1607)

I should have a fix for this in v0.7.0, it's related to the same issue that #72 is seeing and the fix for that should also fix this.
One question for @KrX3D, @AdamOSDev, and @Syrah-NL: do you get any errors on import, or just when running New-BurntToastNotification

@Syrah-NL: do you get any errors on import, or just when running New-BurntToastNotification?

In the current version I use, I don't get any errors. I just have the curly Brackets (on Windows Server).

Still on a 1607 build?
On Mon, 6 Apr 2020 at 21:56, Syrah-NL<EMAIL_ADDRESS>wrote:

@Syrah-NL https://github.com/Syrah-NL: do you get any errors on import,
or just when running New-BurntToastNotification?
In the current version I use, I don't get any errors. I just have the
curly Brackets (on Windows Server).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Windos/BurntToast/issues/81#issuecomment-609695607,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABVCGCS5W7OPWKQLJVU3D23RLGRODANCNFSM4JHR5XEA
.

on my updated normal windows 10 it works fine, on my Windows Server 2016 (version 1607) i get this error

Hello,
i tried version 7.0.1 (after i forgot to update it) and now it works without getting this error.
now i need to wait for 7.0.2 to fix the problem with PS 7.0.3 mentioned here
https://github.com/Windos/BurntToast/issues/101

I should have a fix for this in v0.7.0, it's related to the same issue that #72 is seeing and the fix for that should also fix this.
One question for @KrX3D, @AdamOSDev, and @Syrah-NL: do you get any errors on import, or just when running New-BurntToastNotification?

Just when running the cmdlet.


Rewrite Modal components using blueprintjs's Dialog

There are multiple issues with the ConfirmModal, including how colors are defined and the component's API.
We have to work on buttons before handling this.
We would like this before merging: https://github.com/cheminfo/nmrium/pull/2618

Rewrite Modals which are not ConfirmModal with blueprintjs's Dialog
Rename ConfirmModal to ConfirmDialog. It should use blueprintjs's Dialog. I think all of Dialog's props can be forwarded by this component.

@wadjih-bencheikh18 If you notice any feature which were possible before but are lost when switching to blueprintjs, please write it down in the PR and we'll see case by case what we should do.


TypeError: 'type' object is not subscriptable

Traceback (most recent call last):
  File "run.py", line 6, in <module>
    from interactions.ext.checks import check
  File "/usr/local/lib/python3.8/dist-packages/interactions/ext/checks/__init__.py", line 8, in <module>
    from .cooldown import *
  File "/usr/local/lib/python3.8/dist-packages/interactions/ext/checks/cooldown. py", line 10, in <module>
    class Bucket:
  File "/usr/local/lib/python3.8/dist-packages/interactions/ext/checks/cooldown.py", line 37, in Bucket
    def _get_times(self, ctx) -> list[float]:
TypeError: 'type' object is not subscriptable
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7f62d5274550>

I just installed the module

Should be fixed as of 1b566fc, can you confirm?


TKG build failure on temurin-build Github actions checks

Temurin buil PR checks are currnetly failiung when building TKG material:
Copying this from my slack message:
Something in that area is causing a failure on the temurin-build automated PR checks and it wasn't immediately obvious from looking at recent PRs what it might be: https://github.com/adoptium/temurin-build/pull/3538#issuecomment-1846911986
Relevant run of the check: https://github.com/adoptium/temurin-build/actions/runs/7128536879/job/19455522686?pr=3538

Noting: https://github.com/adoptium/temurin-build/blob/master/.github/workflows/build.yml#L95-L108 it is trying to run the smoke test as part of PR testing

@llxia - FYI, this is related to recent improvements to how we handle dependencies we download.
Looks like json.jar file is in an unexpected location now for run-aqa (github workflows).

https://github.com/adoptium/temurin-build/actions/runs/7128536879/job/19455522686?pr=3538#step:8:407
We need to set LIB_DIR in run aqa.

LIB_DIR has the default value, which should not need to be explicitly export. The change https://github.com/adoptium/TKG/pull/476/files in settings.mk is invisible to  make compile process.

I have rerun the github runner tests seems initial issue is fixed. https://github.com/adoptium/temurin-build/actions/runs/7172315110/job/19572418555#step:8:411. However similar issue happened when compile the tests, https://github.com/adoptium/temurin-build/actions/runs/7172315110/job/19572418555#step:8:552. In the locally run both compile process with build_tool.xml and build_test.xml are run correctly with -DLIB_DIR=/Users/.../test/aqa-tests/TKG/../TKG/lib. Reopen untill all issues be addressed.

rerun jobs passed https://github.com/adoptium/temurin-build/actions/runs/7172315110/job/19613059609


Update README.md

Change logo to commercetools

Coverage remained the same at 93.317% when pulling 6f45232a0c0b67f9685ce55e8d6704ed480983c5 on wizzy25-patch-1 into ccb110b84be263f199f97566b83d5bec2dda34e4 on master.


Prioritize sdn creation in addon sync

We will be able to squeeze more time out of cluster bootstrap if we optimize addon creation (create SDN before any other pod so nodes can turn ready asap and new pods get scheduled as soon as they get created.
@jim-minter @pweil- @mjudeikis

The addon creation process tends to complete before the nodes have even booted.  Does the kubelet order pod creations by creationTimestamp or something?  I think the difficulty is more around the size of the container images we ship.

The addon creation process tends to complete before the nodes have even booted. Does the kubelet order pod creations by creationTimestamp or something? I think the difficulty is more around the size of the container images we ship.

Hrm, I think you are right. The fact that we don't see the sdn pods created asap is because daemon set pods get created when nodes first register in the cluster.

Pod priority classes will only help with scheduling.  Higher priority classes will be scheduled first if the can be.  If the issue is unready nodes or long docker pulls I don't think there is much that can be done other than pre-population of images.

ack
closing in favor of https://trello.com/c/gqaNTmqj/155-images-low-priority-consider-prebaking-docker-images-into-golden-images


Allow count attribute on persistence-threads

@vekterli PR

Yes, but not tested and not allowed by schema....


Getting "TypeError:" on backup with grafana3

Hi,
First of all, thanks for your work, it's a great tool.
Any chance to be compatible with grafana 3 ?
Worked very well with previous version but since grafana3 I get:
TypeError: the JSON object must be str, not 'bytes'
When trying to run a backup command.
The full trace:
Traceback (most recent call last):   File "/usr/local/bin/grafcli", line 27, in <module>     sys.exit(main())   File "/usr/local/bin/grafcli", line 22, in main     cli.run()   File "/usr/local/lib/python3.4/dist-packages/climb/core.py", line 55, in run     result = self.execute(*shlex.split(command))   File "/usr/local/lib/python3.4/dist-packages/climb/core.py", line 73, in execute     return self._commands.execute(command, **kwargs)   File "/usr/local/lib/python3.4/dist-packages/climb/commands.py", line 26, in execute     return method(*args, **kwargs)   File "/usr/local/lib/python3.4/dist-packages/grafcli/commands.py", line 173, in backup     self.file_export(doc_path, file_path)   File "/usr/local/lib/python3.4/dist-packages/grafcli/commands.py", line 204, in file_export     document = self._resources.get(path)   File "/usr/local/lib/python3.4/dist-packages/grafcli/resources/resources.py", line 46, in get     return manager.get(*parts)   File "/usr/local/lib/python3.4/dist-packages/grafcli/resources/common.py", line 33, in get     dashboard = self._storage.get(dashboard_name)   File "/usr/local/lib/python3.4/dist-packages/grafcli/storage/sql.py", line 70, in get     source = json.loads(result[0][0])   File "/usr/lib/python3.4/json/__init__.py", line 312, in loads     s.__class__.__name__)) TypeError: the JSON object must be str, not 'bytes'
Thanks for any help

Hey, thanks for the report! I'll look into it and grafana 3 compatibility in general.

Thank you !
I'll be happy to test and give feedback

@ddes Alright, it seems to be working fine now! Please just open another issue if you find something broken or have any suggestions. :)


Remove extra :if => true. from a listnav

review follow up for https://github.com/ManageIQ/manageiq/pull/11732

Marked as euwe/no based on this comment


YouTube playlist support?

I was thinking, maybe some functionality could be added which supports playlists? Like perhaps a video.GetNextVideo() which returns the video which YouTube Autoplay would have played next, and also support for inputting a playlist URL and returning an array/list of YoutubeVideos? Features like this would be invaluable to my project and I'm certain it will be much appreciated by others as well.

Check my github for a sort of implementation. Its called YoutubePLAYLIST something or other.

YoutubeExplode supports getting video ids from playlists


Fire spread does not stop the fire 1.12.2

Hi! Fire spread flag does not work.
What am I doing.
I ignite the block on the border, and the fire begins to spread further.
Thanks for the help.
Versions:
griefprevention-1.12.2-<IP_ADDRESS>4.jar
spongeforge-1.12.2-2705-7.1.0-BETA-3310.jar

Unable to reproduce and you are using a completely outdated SF build. Also Fire Spread will always work for owners in claims they own, if you want it completely disabled set the gamerule to false.

Oh I see 3310 was around the date this was posted. Just update SF and you should be fine.

Hi @bloodmc ,
I have the same problem. Fire spreads while fire spread is disabled. I have:
spongeforge-1.12.2-2705-7.1.0-BETA-3361.jar
griefprevention-1.12.2-<IP_ADDRESS>6.jar
installed.