Reordering of non-nested tables

Hello.
In docs I see,
"If your model has the proper fields (parent_id, lft, rgt, depth), you can use the built-in reorder" and "specify 1 for no nesting, just reordering (MAX_TREE_LEVEL)."
What if don't have parent_id, lft, right, depth fields? If I just want the sorting. Will I still need to add these fields to my table?
I want something like https://github.com/spatie/eloquent-sortable
Does it already work without all fields? (only 'depth')
Thank you.

This will be a bummer for you, but no, there's currently no "reordering only" option, without nesting. You'll still need to have all fields in your db (parent_id, lft, right, depth) and use 1 as MAX_TREE_LEVEL. It will only do sorting then (no nesting) - so it's the result you want on the front-end, but you'll have unnecessary table columns, yes.
Sorry.

Was looking for this as well. Are there any plans on implementing something like this? I can work with the current solution but would be really awesome. Cheers!

@floristenhove yes, we'll probably implement some way of disabling the nesting in the future, and only need one column "order".

@tabacitu I took a look at this and came up with a possible solution, I'm just not sure if there aren't any surprises.
I noticed, that the items in request are sent via an array, keyed by it's order as it appears in the UI. From that, it seems straightforward:

Add an updateFlatOrder() method to PanelTraits/Reorder.php (very similar to the updateTreeOrder() one)

// PanelTraits\Reorder->updateFlatOrder()

$count = 0;

foreach ($request as $key => $entry) {
    if ($entry['item_id'] != '' && $entry['item_id'] != null) {
        $item = $this->model->find($entry['item_id']);
        $item->lft = $key;
        $item->save();
        $count++;
    }
}

return $count;

Note: I'm using lft here to be backwards compatible with the current solution, but it could be changed to order if necessary.

Change the if statement in saveReorder() method in app/Http/Controllers/CrudFeatures/Reorder.php slightly:

if (count($all_entries)) {
    if ($this->crud->reorder_max_level == 1) {
        $count = $this->crud->updateFlatOrder($all_entries);
    } else {
        $count = $this->crud->updateTreeOrder($all_entries);
    }
} else {
    return false;
}

And that should be it. I'm also open to making a PR for this, if you consider this to be a viable solution :)

Hi @pavoltanuska ,
Hmm... That sounds like an elegant solution. So basically we would have two functionalities:

reorder (old one)
flat reorder (the new one)

And the saveReorder() method would work for both, depending on what you've "enabled", I presume? $this->crud->enableReorder() or $this->crud->enableFlatReorder()?

As for the 2 functionalities - yes - separate method for updateFlatOrder()
As for the "enabling", I see more options, but it'd be best to stay consistent with how things are (or will be) done in general.

enableReorder() and enableFlatReorder(), like you said
enableReorder() and enableReorder()->flat()
enableReorder($label = 'name', $max_level = 1, $flat = false)
The "implicit" decision based on $this->crud->reorder_max_level i.e. if($this->crud->reorder_max_level == 1) { updateFlatOrder() } else { updateOrder() }

I guess I'll let you guys decide :)

What about simple reordering with arrow buttons? Down/Up arrow button actions in the table. When up button clicked, increment row's order field by one (and when Down button clicked, decrease by one).

@alashow with flat order, that should be quite simple. With leveled ordering, it's a little bit tougher nut to crack (correctly and UX friendly).
Another thing (it's just the semantics), but increment/decrement doesn't suffice here, you should swap the order values with the higher or lower item. But that should still be easy enough.

Hey guys,
Any update on this one? Would be really handy to have simple reordering.

I took the approach of extending the CrudController and creating a new Trait that override the "saveReorder()" function and have the new updateFlatOrder() function above. I did this because I didn't want to edit the package directly which would get overwritten when updates are installed.
I am using a "sort_order" field within my database tables and so I hardcoded that field in the "updateFlatOrder()" function but it would be better to add a new field to the request object using "$request->request->set('sort_order_field', 'sort_order');" and then use that field within the function to make it more dynamic.
Controller:
`namespace App\Http\Controllers;
// Adrian (): Extend the Backpack CRUDController
use Backpack\CRUD\app\Http\Controllers\CrudController as BaseController;
use App\Http\Traits\CRUD\Reorder;
class Controller extends BaseController
{
use Reorder;
}`
Trait:
`namespace App\Http\Traits\CRUD;
use Doctrine\Common\Util\Debug;
trait Reorder
{
/*
|--------------------------------------------------------------------------
|                                   REORDER
|--------------------------------------------------------------------------
*/
/**
 *
 * @param  [Request] The entire request from the NestedSortable AJAX Call.
 *
 * @return [integer] The number of items whose position in the tree has been changed.
 */
public function updateFlatOrder($request)
{
    $count = 0;

    foreach ($request as $key => $entry) {
        if ($entry['item_id'] != '' && $entry['item_id'] != null) {
            // Adrian (): Changed this to call the model property accessible by the crud property
            $item = $this->crud->model->find($entry['item_id']);
            // Adrian (): The soirting will be done on the field "sort_order"
            $item->sort_order = $key;
            $item->save();
            $count++;
        }
    }

    return $count;
}

/**
 * Save the new order, using the Nested Set pattern.
 *
 * Database columns needed: id, parent_id, lft, rgt, depth, name/title
 *
 * @return
 */
public function saveReorder()
{
    $this->crud->hasAccessOrFail('reorder');

    $all_entries = \Request::input('tree');

    /**if (count($all_entries)) {
    $count = $this->crud->updateTreeOrder($all_entries);
    } else {
    return false;
    }**/

    if (count($all_entries)) {
        if ($this->crud->reorder_max_level == 1) {
            // Adrian (): Changed this to call the function within this trait
            $count = $this->updateFlatOrder($all_entries);
        } else {
            $count = $this->crud->updateTreeOrder($all_entries);
        }
    } else {
        return false;
    }

    return 'success for '.$count.' items';
}

}`


Closure Compiler Service API returns an empty response after v20220803

The Closure Compiler Service API (https://closure-compiler.appspot.com/compile) returns an empty response for any given input.
Even hitting it from the home page also doesn't work: https://closure-compiler.appspot.com
I know that according to https://developers.google.com/closure/compiler/docs/gettingstarted_api, the API has been deprecated and will be removed. But when? Has it been removed now? If so, then I think the docs and homepage should be updated. Thanks!

not working for me as well

I'm here with same issue.

Looks like something went wrong after updating the service to use the v20220803 compiler.
Temporarily reverted to the previous v20220719 version

It appears our update script failed to re-create the embedded jar file containing closure library correctly.
I'm working to fix that and also add more error checking to the script so it will prevent pushing a failed build in the future.

The service is now fixed and up-to-date with the current release.

Can confirm that it works now, thanks!


Update to delete button

Replace the delete button with an icon and right align as shown in https://github.com/LD4P/sinopia/issues/261#issuecomment-531882451.
Note that this does not include the mentioned undo functionality.

Closed by #1733


Redshift DDL generation invalid with diststyle AUTO

System information:

Widows 10, 1809
DBeaver version: <IP_ADDRESS>907061627
Java version bundled
Additional extensions none

Connection specification:

Database name and version: Redshift, Cluster version 1.0.8205
Driver name postgres-redshift-jdbc
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
when generating DDL on a table, I get following entry:
<<Error - UNKNOWN DISTSTYLE>>;
diststyle in use:
diststyle AUTO;
It was added this year: https://aws.amazon.com/about-aws/whats-new/2019/03/amazon-redshift-now-automatically-picks-the-best-distribution-st/
Steps to reproduce, if exist:
Create a table with diststyle auto and generate DDL
Include any warning/errors/backtraces from the logs
Nothing in logs

Thanks for the bug report.
You can test the fix in Early Access version (https://dbeaver.io/files/ea)

verified


New Model: "Jamba"  (Production Grade Mamba by ai21)

What model would you like?
https://www.maginative.com/article/ai21-labs-unveils-jamba-the-first-production-grade-mamba-based-ai-model/
https://huggingface.co/ai21labs/Jamba-v0.1?ref=maginative.com

Thanks for the excellent software :)

https://github.com/ggerganov/llama.cpp/issues/6372

Seconding this + the instructor model that comes later (still weirded about instable training tho)


chore: proposal to add github actions job to update GraalVM version

Fixes https://github.com/googleapis/google-cloud-java/issues/8893

Have you looked into using Renovate Bot config instead?

Thanks for the link @meltsufin! Quick question, in the example linked, how is renovate bot able to determine the version to upgrade the artifacts to? Does is it get that information from maven central?

Have you looked into using Renovate Bot config instead?

Thanks for the link @meltsufin! Quick question, in the example linked, how is renovate bot able to determine the version to upgrade the artifacts to? Does is it get that information from maven central?

Yes, if the datasource specified is "maven".

Got it, thank you. Will try this out. This may be helpful for updating the docker image in testing-infra-docker too.


fix: add ts test key to deployment

Add typesense test key to deployment.

Codecov Report

Merging #336 (4430bbe) into main (021a6a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   29.23%   29.23%
=======================================
  Files          61       61
  Lines        6520     6520
=======================================
  Hits         1906     1906
  Misses       4396     4396
  Partials      218      218

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021a6a4...4430bbe.


Add scoresheet display

Toggle score view to see tabular display of cumulative score from each turn

This has been partially completed: words that are not found via https://api.dictionaryapi.dev/ will display a validation error which does not block their play.
Further expansion: add native functionality for:

uploading a wordlist, e.g. via management command, which will construct and save a DAWG for word lookup (open question: should these live in codebase source? What file format?)
Option during game creation to pick from available word lists. Maybe also separate option to choose whether invalid words should block play
API endpoint to check word against chosen wordlists for game
Upload own wordlist?

Enhancement: add score points to table cells with some badge styling


Prepare the repo for the OpenSSF Best Practices badge

It would be nice to get the OpenSSF Best Practices badge. We need to tick the boxes listed on this page.

That’s a lengthy list, but how is that verified?

They have a web app where we can provide the information about the repo to get certified. I haven't used the app before.


Improve GHA config and dogfood GHA

Signed-off-by: Vadim Markovtsev<EMAIL_ADDRESS>

Codecov Report

Merging #77 (5b0af4e) into master (3c7717e) will increase coverage by 0.50%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   82.24%   82.75%   +0.50%
==========================================
  Files          18       18
  Lines         597      603       +6
  Branches       61       62       +1
==========================================
+ Hits          491      499       +8
  Misses         67       67
+ Partials       39       37       -2

Impacted Files
Coverage Δ

mloq/config/params.py
87.01% <ø> (ø)

mloq/files.py
100.00% <ø> (ø)

setup.py
0.00% <ø> (ø)

mloq/cli/setup_cmd.py
85.41% <62.50%> (-0.30%)
:arrow_down:

mloq/api.py
89.28% <100.00%> (+1.35%)
:arrow_up:

mloq/cli/main.py
89.74% <100.00%> (+0.55%)
:arrow_up:

mloq/config/logic.py
88.23% <100.00%> (ø)

mloq/templating.py
86.95% <100.00%> (+1.24%)
:arrow_up:

mloq/version.py
100.00% <100.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cec95af...5b0af4e. Read the comment docs.


Default parameter for HTTPClient.shutdown(queue: DispatchQueue...

Is it worthwhile defaulting queue in HTTPClient.shutdown to .global as is done in EventLoopGroup?

Sure, why not.


python3.pkgs.pygmt: fix build by replacing invalid call to env.get

Fix the build of pygmt by replacing the correct call to env.get for setting GMT_LIBRARY_PATH.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

4 packages built:
python311Packages.pygmt python311Packages.pygmt.dist python312Packages.pygmt python312Packages.pygmt.dist
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352875

x86_64-linux

:white_check_mark: 4 packages built:

python311Packages.pygmt
python311Packages.pygmt.dist
python312Packages.pygmt
python312Packages.pygmt.dist

@tobim I think this is ready for merge, thanks!

@tobim I think this is ready for merge, thanks!

I can't.

@ofborg build python312Packages.pygmt

@cpcloud , I think commit prefix should be changed to python3Packages.pygmt.

@cpcloud , I think commit prefix should be changed to python3Packages.pygmt.

I think either is fine. The last time someone mentioned this they had the opposite advice :)

Thanks!


Incomplete tests

Regression tests in ttmlir/test/ttmlir/Silicon/TTNN/ have CHECK statements but did not use FileCheck command. These tests will pass even if they are broken.

Tests updated in #260


Conditional Display of 'meatball icon' Button on Draft status and afterward.  (2)

Condition
"display some of the menus if status = 'Draft' afterward"

On which doctype and which menu ?

[x] 1. Item
status: Enabled/Disabled/Template (all status except Not saved)

[x] 2. Item Group
status: Saved (all status except Not saved)

[x] 3. Sales Invoice
status: Draft, Return, Credit Note Issued, Submitted, Paid, Partly Paid, Unpaid, Unpaid and Discounted,  Partly Paid and Discounted, Overdue and Discounted, Overdue, Cancelled, Internal Transfer (all status except Not saved)

[x] 4. Stock Entry
status: Draft, Submitted, Cancelled (all status except Not saved)

[x] 5. Delivery Note
status: Draft, To bill, Completed, Return Issued, Canceled, Closed (all status except Not saved)

@Muzmal
item group

remove customize menu

Please remove the script.
Because we will hide this by using role permission instead.


Enhance the docker/Dockerfile

Currently, the Dockerfile depends upon the external commands like npm install, and npm run build to be able to include the build folder in the image. Instead, it should be a multi staged Dockerfile with build and package stage. The build stage builds the code and the package stage uses the artifacts. Idea  is that the Dockerfile should work on its own. This will make the build and push workflow smaller and easier to follow. Also, if someone wants to build locally from the Dockerfile, then it will work without any external dependencies.

@ofermend Can I work on this issue?

for sure. would love to see your PR on this.

@ofermend Thank you 👍.


Ability to automatically take picture?

Is there a possibility to get this library automatically taking a picture as soon as it recognizes a document?

Yes, this is possible. However, due to this library being copied into scanner apps without any/little modifications I decided against open sourcing InstaPDF's for of this library. I implemented it like so:

Create a threshold value
Keep reference to previously detected rectangle
Compare the previously detected rectangle, where each point is within a valid range (~50px)
Once you detect a certain amount of valid rectangles you can auto capture.

Hope this helps.


Fix missing newlines in env file and log4j.properties

Description
This PR fixes the missing newline issue described in #189
The change in this commit broke the newlines by replacing occurrences of $/ with $INPUT_RECORD_SEPARATOR without adding a require 'English' that defines this variable.
I have added tests to verify some of the content of both the env file and the log4j.properties file.
While fixing this issue i also found out that the serverspec test suite was actually not being executed due to an invalid verifier path when using kitchen-dokken. kitchen-dokken expects the tests to be in /opt/verifier but the default path is /tmp/verifier, causing no tests to be executed.
When the tests were working again, i found out that the test suite was actually broken. The following changes were made to restore test functionality:

revert some changes made in this commit since shell_out! doesn't work in serverspec.
Fixed the env file location for Ubuntu

The best thing would probably be to convert all tests to inspec, but I'll leave that for another PR :)
Issues Resolved
#189
#190
Check List

[x] All tests pass. See TESTING.md for details.
[x] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

  Generated by :no_entry_sign: Danger

@hrak looks like replacing shell_out with run_command is now deprecated according to Cookstyle.

@hrak looks like replacing shell_out with run_command is now deprecated according to Cookstyle.

I know, i described that in the comment above. But shell_out doesn't work with serverspec, that's why i reverted that change. For this to pass cookstyle we'll have to either disable the ChefModernize/ShellOutHelper cop for libraries/log4j.rb and libraries/env.rb, or rename the run_command method to something that doesn't trigger cookstyle. What do you prefer?

Ah there's our problem. We shouldn't be using serverspec but InSpec.

To be honest. This cookbook really needs an overhaul. I'm fairly sure this isn't going to easily pass any recent cookstyle or spec testing 🤔

closing due to age. Feel free to reopen if you'd like to continue working on this. Currently the recommended cookbook approach is to use inspec for testing and chefspec only as needed for library helpers and others that inspec may be more of a lengthy heavy test.


Method to convert timestamps to and from snowflakes

Something like discordrb's synthesise and creation_time would be useful to have.

Just make Snowflake a struct and add some methods on it. Almost all of the things you can do with a number don't make sense on a snowflake.

test


fix bash syntax

Signed-off-by: Li Zhijian<EMAIL_ADDRESS>

Looks like this was fixed upstream :)

/close


[AIRFLOW-504][AIRFLOW-507] Update to Travis' trusty environment and fix mysql issues

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

AIRFLOW-504
AIRFLOW-507

Testing Done:

Unit tests pass on travis'

To update to Travis and use Mysql 5.6 in the CI environment the
following was required.
Both utcnow() and now() return fractional seconds. These
are sometimes used in primary_keys (eg. in task_instance).
If MySQL is not configured to store these fractional seconds
a primary key might fail (eg. at session.merge) resulting in
a duplicate entry being added or worse.
Postgres does store fractional seconds if left unconfigured,
sqlite needs to be examined.
@aoen @mistercrunch @zodiac @jlowin

seems like the mysql CI tests are failing, but I can't tell if they're related

Current coverage is 65.15% (diff: 16.92%)

Merging #1794 into master will decrease coverage by 0.23%

@@             master      #1794   diff @@
==========================================
  Files           143        144     +1
  Lines          9883       9948    +65
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6463       6482    +19
- Misses         3420       3466    +46
  Partials          0          0

Powered by Codecov. Last update afed622...4797b87

@artwr @aoen @mistercrunch @r39132 @jlowin I need your ideas on this. @artwr was in favor of changing the code in order to workaround MySQL not behaving (it is non standard), however this changes what other databases are storing.

So it is either MySQL that gets and updated schema and gets in line with the other databases and the need to be careful when adding new datetime fields to the schema.
or we lose granularity and we get extra maintenance (need to be extra careful when using datetime.now() ).

Personally I am in favor of changing the schema, but I understand the position of @artwr .

Checking in on status of this ticket as part of cold-case PR cleanup.

I do not have a sufficiently informed opinion on how to work around MySql to weigh in here, unfortunately

As per mailinglist (MySQL schema needs to be update) I will go ahead and merge this.


Variables with the same name in the same test function will only be snapshotted once

What happened?
In a test function, I use assert_debug_snapshot to take snapshots of variables with the same name, but only the first value is saved, which ignores subsequent variables with the same name. In this case, maybe warn should be used to prompt the user, or is it a bug in insta?
Reproduction steps
#[cfg(test)]
mod test {
    use insta::assert_debug_snapshot;

    #[test]
    fn test() {
        let r = 1;
        assert_debug_snapshot!(r);

        let r = 2;
        assert_debug_snapshot!(r);
    }
}

---
source: src/lib.rs
expression: r
---
1

Insta Version
latest
rustc Version
rustc 1.84.0-nightly (798fb83f7 2024-10-16)
What did you expect?
Variables with the same name should be snapshotted twice

This would be very surprising. Could you confirm once more? Your're sure it's not just failing on the first and not hitting the second? Changing the name of the second makes a difference?

Sorry, I mistakenly thought that all assertions in each test function were in the same file, insta is fine, thanks for your help


[Proposal] Move Bytes to own crate

This PR proposes that we move the Bytes API to another crate so others can use it without having to copy paste. It also separates concerns between this crate (arrow) and a mechanism to use share foreign arrays with Rust still compatible with mutable APIs.
Proposed home: https://github.com/DataEngineeringLabs/foreign_vec

cc @jhorstmann @ritchie46 , since both also contributed to this component (either here or in arrow-rs).


[TFLite] Added GATHER operator for 16x8.

In this PR added reference kernel implementation of GATHER operator for 16x8 scheme (weights - int8, activations - int16), that was required by one of models.
I added tests and versioning.

@jianlijianli Could you review the optimize changes? (Or reassign :-) )


Correct the instructions of regenerating protobufs

Signed-off-by: Fullstop000<EMAIL_ADDRESS>

Maybe just remove the Regenerate Protobufs section ?
And one more thing is that the actual eraftpb.rs file is a little hard to located. The eraftpb.rs will be created under target/debug/build/raft-proto-***/out but there are usually a lot of raft-proto-*** so that I don't know which is the newest being generated.

Maybe just remove the Regenerate Protobufs section ?

sgtm

And one more thing is that the actual eraftpb.rs file is a little hard to locate

The easiest way is to run cargo clean before you build. There will then only be two raft-proto directories and only one will have an out sub-directory.

Using cargo clean before re-building could be frustrating because it takes time re-compiling without caches :( .
I tried cargo clean -p but it only removes things in deps.

And one more thing is that the actual eraftpb.rs file is a little hard to locate

For anyone who has the same problem, I find that RLS is useful to deal with this.


mysqlJS makes the server to crash

Hello,
I got a problem when I try to send information from my front-end in JSON format. Basically, when I send the request (with fetch) with headers, It automatically sends an OPTIONS request which makes mysqlJS (and my server) crash...
Here is the logs (from Heroku):
2018-10-02T22:16:46.710600+00:00 heroku[router]: at=info method=OPTIONS path="/authentication" host=desolate-escarpment-15258.herokuapp.com request_id=e9bcb178-cb6a-42be-bd94-0b34e60f3e8c fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=8ms status=204 bytes=301 protocol=https
2018-10-02T22:16:46.759403+00:00 app[web.1]: throw err; // Rethrow non-MySQL errors
2018-10-02T22:16:46.759390+00:00 app[web.1]: /app/node_modules/mysql/lib/protocol/Parser.js:80
2018-10-02T22:16:46.759405+00:00 app[web.1]: ^
2018-10-02T22:16:46.759410+00:00 app[web.1]: at Query.db.query (/app/server.js:64:32)
2018-10-02T22:16:46.759407+00:00 app[web.1]:
2018-10-02T22:16:46.759409+00:00 app[web.1]: TypeError: Cannot read property 'password' of undefined
2018-10-02T22:16:46.759417+00:00 app[web.1]: at Query.Sequence.end (/app/node_modules/mysql/lib/protocol/sequences/Sequence.js:83:24)
2018-10-02T22:16:46.759413+00:00 app[web.1]: at Query.<anonymous> (/app/node_modules/mysql/lib/Connection.js:502:10)
2018-10-02T22:16:46.759415+00:00 app[web.1]: at Query._callback (/app/node_modules/mysql/lib/Connection.js:468:16)
2018-10-02T22:16:46.759422+00:00 app[web.1]: at Query._handleFinalResultPacket (/app/node_modules/mysql/lib/protocol/sequences/Query.js:139:8)
2018-10-02T22:16:46.759426+00:00 app[web.1]: at Protocol._parsePacket (/app/node_modules/mysql/lib/protocol/Protocol.js:278:23)
2018-10-02T22:16:46.759424+00:00 app[web.1]: at Query.EofPacket (/app/node_modules/mysql/lib/protocol/sequences/Query.js:123:8)
2018-10-02T22:16:46.759427+00:00 app[web.1]: at Parser.write (/app/node_modules/mysql/lib/protocol/Parser.js:76:12)
2018-10-02T22:16:46.759429+00:00 app[web.1]: at Protocol.write (/app/node_modules/mysql/lib/protocol/Protocol.js:38:16)
2018-10-02T22:16:46.759431+00:00 app[web.1]: at Socket.<anonymous> (/app/node_modules/mysql/lib/Connection.js:91:28)
2018-10-02T22:16:46.771457+00:00 heroku[router]: at=error code=H13 desc="Connection closed without response" method=POST path="/authentication" host=desolate-escarpment-15258.herokuapp.com request_id=8609e296-7bf7-4c7a-bf6d-242287dbeb57 fwd="<IP_ADDRESS>" dyno=web.1 connect=0ms service=29ms status=503 bytes=0 protocol=https
2018-10-02T22:16:46.869477+00:00 heroku[web.1]: Process exited with status 1
2018-10-02T22:16:46.887638+00:00 heroku[web.1]: State changed from up to crashed

Here is the code from nodeJS :
var express = require('express');
var app = express();
var cors = require('cors');
var bodyParser = require('body-parser')
var mysql = require("mysql");

//Enabeling all Access-Control-Allow-Origin
app.use(cors());
app.options('*', cors())

var port = process.env.PORT || 5000

app.use(bodyParser.urlencoded({ extended: false }));
app.use(bodyParser.json());

//omitted mysql connections details

app.post('/authentication', (req, res) **=> {
    email = req.body.username,
    password = req.body.password,
    matching = "false"
    var dbpassword

    sql = "SELECT password FROM users WHERE email = ?";
    db.query(sql, email, (err, result, fields) => {
        if(err) {
            console.error('error query: ' + err.stack)
            return;
        }
        dbpassword = result[0].password;

         if(dbpassword === password){
        matching = "true";
        console.log(dbpassword + " : " + password);
        }
        res.send({answer: matching});

    });
})

app.listen(port, function(){
    console.log("app running");
})

This is not an error with this module, but an issue with your logic. The error is that you are always expecting the query to return at least one result row but sometimes returns zero results. You need to add a condition when zero results are returned so you don't have an error

I did not even think about that... Did it and it works!
thanks!


Qf 2493 export users emails to csv

~- [ ] move the exportation function elsewhere as it can be used by organizations, not just PersonAdmins~

Task linked: QF-2493 Add button to django admin for exporting all users' emails addresses as a single CSV file

Great job!

Last bit before merging this. Can you add the CSV URI in the test_admin_opens skip_urls tuple?


Taint Analysis of functions out of the backtrace

Currently, the Taint Analysis is not performed for functions out of the backtrace, unless, one of the two conditions is met
(from TaintAnalysis::shouldAnalyzeCall:):

Return value of the function is in the Taint List (return value register is in the T.L. or it is a base register of memory location from the T.L.)
A global variable is in the Taint List (Taint Info with no register operand, but with offset is in the T.L.)
Those two conditions need to be revisited to meet real case scenarios and for condition 2) the future support of global variable tracking would be beneficial.

On the other hand, in many real cases, the parameter is passed as a reference (pointer) and its value is set in the functions out of the backtrace, but we don't have mechanism to detect such cases an to perform Taint Analysis for such functions.
With the patch below, we are able to run Taint Analysis on each function out of the backtrace, by selecting argument -analyze-each-call. This could be used during investigation to inspect how Taint Analysis could be performed on such functions, but in real cases, it could cause explosion of analysis.
Patch: analyze-each-call.patch
Please, consider the following test case:
void set(int* adr) {
  *adr = 5; // crash line
}
void init(int** p) {
 *p = 0; // correct blame line
}
int main() {
  int* ptr = 0; // incorrect blame line
  init(&ptr);
  set(ptr);
  return 0;
}

Although, argument -analyze-each-call is used and we are be able to analyze function init(), which is responsible for setting incorrect value of the pointer, the tool is not able to find correct blame line. The main reason is the fact that we don't have available register values for the frames out of the backtrace, so we cannot rely on concrete memory addresses. This means, that functions out of the backtrace are analyzed on symbolic level, so we need to match exact registers and offsets.
To sum up, there are two mechanisms which need to be developed:

Mechanism which will determine when a parameter is a reference to the tainted location, where we should analyze the call
Mechanism to efficiently perform analysis of functions out of the backtrace, without available register values (using memory to find needed values and improving symbolic level analysis)

Some updates from the current Proof-of-concept investigation.
There are several different scenarios to take into consideration:

parameters passed via registers
vs
parameters passed via stack
one level of call
vs
multiple level of nested calls (out of the backtrace)
blame line is in the call (out of the backtrace)
vs
blame line is not in the call (out of the backtrace), but the flow of the Tainted Value goes through it

I've made a certain progress with the basic test case, which corresponds to the register passed parameter, one level of nesting and blame line inside the call.
About developed mechanisms:

Added support for getting parameter forwarding register set from CrashAnalyzer TargetInfo
Improve RegisterEquivalence to handle LEA instructions (including changes in TargetInstrInfo)
Implemented detection if any of the parameter forwarding register is Tainted (this includes equivalent locations) and checking if the dereference level is less than 0 (which should imply that the parameter is a reference to the Tainted location)
Implemented FowardTaintAnalysis for functions with tainted parameter reference (can detect loading of the constant in the tainted parameter, like in the init function, in the test case)
Implemented detection of instruction which loaded the parameter into register

some additional fixes in TaintDFG management

With those changes the basic case is covered, and the TaintDFG looks like:

The second case to consider is when one parameter is used to set the value of the other, like in the test below:

void crash(int val, int* adr){
	*adr = val; // crash - line 3
}

void fun(int** ptr, int* adr)
{
	*ptr = adr; // wrong blame - line 8
}

int main(){
  int *p = 0; // wrong blame - line 12
  int *adr = 3; // correct blame - line 13
  fun(&p, adr);
  crash(1, p);
  return 0;
}

In this case we can use the ForwardTaintAnalysis to track  the parameter to the "set point" (*ptr = adr;), which corresponds to the following MIR instruction:
MOV64mr $rax, 1, $noreg, 0, $noreg, $rcx, debug-location !DILocation(line: 8

From this point we can perform the existing Backwards TaintAnalysis to track the value of parameter adr (from $rcx).
In that way the resulting TaintDFG looks like:

However, currently, TaintDataFlowGraph analysis fails to find the correct blame node from the graph, which is yet to be investigated.


fix: debug alt hover options

Types

[x] 🐛 Bug Fixes

Background or solution

Changelog
修复在 debug 模式下 hover 变量提示与语言服务提示重复显示的问题

@Ricbet CI 处理一下

Codecov Report

Merging #773 (ced88b8) into main (c512d51) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #773      +/-   ##
==========================================
- Coverage   58.56%   58.56%   -0.01%
==========================================
  Files        1211     1211
  Lines       75003    75004       +1
  Branches    15593    15593
==========================================
  Hits        43929    43929
- Misses      28319    28320       +1
  Partials     2755     2755

Impacted Files
Coverage Δ

...ackages/debug/src/browser/debug-session-manager.ts
67.00% <0.00%> (-0.23%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c512d51...ced88b8. Read the comment docs.


chore: fix docs react related  warnings

Pull Request Test Coverage Report for Build 114687334

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 114684871:
0.0%

Covered Lines:
0

Relevant Lines:
0

💛  - Coveralls


Unable to find plugin: acme (Puma::UnknownPlugin)

Hello,
I'm considering using this gem but I can't seem to get my rails application to start using the suggested config options:
# Config for ACME
plugin :acme

acme_server_name 'puma-acme.example.org'
acme_tos_agreed true

then:
 bundle exec puma -p 3000
bundler: failed to load command: puma (/Users/gilad/.asdf/installs/ruby/3.3.0/bin/puma)
/Users/gilad/.asdf/installs/ruby/3.3.0/lib/ruby/gems/3.3.0/gems/puma-6.4.3/lib/puma/plugin.rb:50:in `rescue in find': Unable to find plugin: acme (Puma::UnknownPlugin)
	...
/Users/gilad/.asdf/installs/ruby/3.3.0/lib/ruby/3.3.0/bundled_gems.rb:74:in `require': cannot load such file -- puma/plugin/acme (LoadError)

I've added the gem to my Gemfile and ran bundle install.  What am I missing?

Looks l need to add a require to the config file:
# puma.rb
require "puma/acme"

# Config for ACME
plugin :acme

acme_server_name 'puma-acme.example.org'
acme_tos_agreed true

Is that correct?  Perhaps the README needs to be updated?

I'm also having issues with some of the more complex config options:
# Config for ACME
plugin :acme

config.bind "tcp://<IP_ADDRESS>:80"
config.bind "acme://<IP_ADDRESS>:443"

# Account contact URL(s). For email, use the form<EMAIL_ADDRESS># Recommended for account recovery and revocation.
acme_contact<EMAIL_ADDRESS>
# Specify server names (SAN extension).
acme_server_names "site-dev.it.edu", "www.site-dev.it.edu"

# Enable automatic renewal based on an amount of time or fraction of life
# remaining. For an amount of time, use Integer seconds, for example the value
# 2592000 will set renewal to 30 days before certificate expiry. For a fraction
# of life remaining, use a Float between 0 and 1, for example the value 0.75
# will set renewal at 75% of the way through the certificate lifetime.
acme_renew_at 0.75

# URL of ACME server's directory URL, defaults to LetsEncrypt.
acme_directory "https://acme.enterprise.sectigo.com"

# Accept the Terms of Service (TOS) of an ACME server with the server's
# directory URL as a string or true to accept any server's TOS.
acme_tos_agreed true

# External Account Binding (EAB) token KID & secret HMAC key for the ACME
# server. See RFC 8555, Section 7.3.4 for details.
acme_eab_kid      ENV["ACME_KID"]
acme_eab_hmac_key ENV["ACME_HMAC_KEY"]

# Encryption key algorithm, either :ecdsa or :rsa, defaults to :ecdsa.
acme_algorithm :ecdsa

# Provision mode, either :background or :foreground, defaults to :background.
# Background mode provisions certificates in a background thread without
# blocking binding or request serving for non-acme listeners.
# Foreground mode blocks all binding listeners until a certificate
# provisions, compatible only with zero-challenge ACME flow.
acme_mode :background

# ActiveSupport::Cache::Store compatible cache to store account, order, and
# certificate data. Defaults to a local filesystem based cache.
acme_cache Rails.cache

# Path to the cache directory for the default cache, defaults to 'tmp/acme'.
acme_cache_dir "tmp/acme"

# Time to wait in seconds before rechecking order status, defaults to 1 second.
acme_poll_interval 1

# Time to wait in seconds before checking for renewal, defaults to 1 hour.
acme_renew_interval 60 * 60

then I get:
config/puma.rb:58:in `_load_from': undefined local variable or method `config' for an instance of Puma::DSL (NameError)
Did you mean?  @config

Calling bind instead of config.bind I'm getting:
config/puma.rb:99:in `_load_from': uninitialized constant Puma::DSL::Rails (NameError)

@giladshanan Sorry to hear you are having trouble and thanks for the detailed report.
Oof, sounds like we have a few mistakes in the readme still. We mostly don't use this directly, but instead through https://github.com/anchordotdev/anchor-rb, which maybe hid from us that this was wrong. In any event, let me see if I can help you out first and then we can see about updating the README.
First, it does look like the README omits the very important require, so we should add that.
Second, I think bind is a keyword directly from the Puma DSL. So I think you can drop the config. parts and it should probably work, or at least get us to the next unfortunate omission:
So you would replace:
config.bind "tcp://<IP_ADDRESS>:80"
config.bind "acme://<IP_ADDRESS>:443"

With this:
bind "tcp://<IP_ADDRESS>:80"
bind "acme://<IP_ADDRESS>:443"

Again, sorry about that. Just let me know if you have any other questions and please let me know if that works for you. I'd also be curious to hear more about your use case. And of course if you'd like to help with the README I'd welcome it, but I'm also happy to fix it up once we know the necessary changes. Thanks!

@giladshanan Thanks for the update.
That Rails error looks like another missing require to me, though I'm not certain. Might need to require 'rails' or some subset prior to referencing it.
Yeah, the external account required error would be expected and likely indicates that you have it integrated correctly and just need credentials, so that's a plus! The anchor-rb repo I linked to and the autocert plugin facilitates that via environment variables, fwiw, but you should be able to do that directly here or pull them from elsewhere if you prefer.

@geemus I added require "rails" and can confirm that resolves uninitialized constant Puma::DSL::Rails (NameError).

I tried to push a branch but I don't have access (naturally).
Here's my suggested changes to the README:

Thanks for the update and changes. I won't have a chance to incorporate this week due to the US Thanksgiving holiday, but I should be able to make the changes early next week.

@giladshanan Turns out I had a little time after all, so I went ahead and updated the README. Thanks again for your feedback and suggestions. Just let me know if you have further questions or feedback.

@giladshanan great, I hope it goes smoothtly. Just let us know if you have further questions or feedback.


Remove bpf.GetMapType()

MapTypeLRUHash on 4.9 kernel: no prealloc to no prealloc upgrade in pkg/bpf/map_linux_test.go uses setMapTypesFromProber() to force a particular probe result during a map upgrade scenario. Specifically, the probe output is consulted in the call to GetMapType() in bpf.Map.openOrCreate().
There are a few problems with this approach:

A package-level global is used to override the probe result for all map creations globally, inviting bugs and flakes. (and the override is not reverted after the test?)
This override mechanism is introduced for just this one test.
This is currently blocking the removal of one bpftool shellout in ProbeManager.
From a distance, it looks like the test might be exercising more than it should. Perhaps it can be removed since it's 4.9-specific?

If this test cannot yet be removed or narrowed down, one option might be to add a method to bpf.Map to override the map type it will assign to mapType in Map.openOrCreate().
cc @christarazi

For what it's worth, this test is intended to prevent regressions like https://github.com/cilium/cilium/commit/7e5a97f5dddb59394484d401c230cbaba4e6a686. I think that the key question in replacing / rewriting / removing the test will be to understand how to avoid that type of bug in future.
Also worth noting, we plan to discuss kernel version support this Wednesday during the weekly community meeting which will likely impact any decisions around code that supports Linux 4.9.x.


CTECH-1582: Adds whitespace to check forked PR flow.

Signed-off-by: Paul Saunders<EMAIL_ADDRESS>Pull Request Checklist

[x] Read the contributing guidelines
[x] Tests pass

Description of the PR
Test MR to check that the forked PR process works. Close unmerged is expected when everything works.

/LGTM

/LGTM

/LGTM

/LGTM

/LGTM

Closing.  Looks good.


Update Velero component for Packet [openebs and restic plugin support]

Supersedes #881 (including implementation of my feedback).
This PR adds supports for Packet platform for Packet platform with the help of OpenEBS and Restic plugin.
TODO:

[ ] e2e tests
[x] Documentation.

Please review and provide your valuable feedback.

I'm still on a fence between providing default values for the configuration vs rejecting the configuration if conflicting blocks are defined. We could:

Implement block typy with different arguments, depending on the label, similar to how we do it with component and cluster blocks
Use reflect.DeepEqual to see if user has modified the struct to reject conflicting values
Require from user specifying provider parameter and not reject invalid configuration blocks.

We'll continue in #881.


Class 'Endroid\QrCode\Response\QrCodeResponse' not found

Installed via composer require endroid/qr-code.
I noticed that the Response class was not downloaded. Able to verify why the Response class is missing?

Hi @markestocapio what version do you have installed? When I install the latest version (3.6.0) using composer the QrCodeResponse class is available and the required Symfony\Component\HttpFoundation\Response class also. Can you verify in your file system that the file exists (otherwise something went wrong during composer command and you should delete the vendor/endroid/qr-code directory and reinstall) and the symfony/http-foundation package is installed?

Hi @endroid,
Earlier I was using PHP 5.6 and the version installed was 2.5. After using PHP 7.2, I managed to install 3.6.0. All are ok now.


[Question] Useless property in the Command and ErrorCommand table

Useless property in the Command and ErrorCommand table
I'm working on adopting the table field to our company database specification: all the fields could not be null.
So I found the Command and ErrorCommand table has dependence in the database, but I cannot found the bean property in java bean. I found the t_ds_command and t_ds_error_command DDL file defined this field.
Which version of DolphinScheduler:

dev branch

Requirement or improvement

I think it should be removed, Does I miss anything?

It cannot be removed .
t_ds_Command is the core table. It is used to trigger tasks
t_ds_error_command is used to record wrong command information
It can be used in the monitoring page of Web UI

It cannot be removed .
t_ds_Command is the core table. It is used to trigger tasks
t_ds_error_command is used to record wrong command information
It can be used in the monitoring page of Web UI

Hi, Thanks for the reply.
I mean should remove the dependence  field, not remove the table. On my tests,  It running well after remove the dependence field.

Yes, The field "dependence" is not used, can remove it.
Welcome create a PR.


Building Hobbes on MacOS

I am trying to build Hobbes on Mac and got stuck with this:
cmake .
CMake Error at CMakeLists.txt:5 (find_package):
  Could not find a package configuration file provided by "LLVM" with any of
  the following names:

    LLVMConfig.cmake
    llvm-config.cmake

  Add the installation prefix of "LLVM" to CMAKE_PREFIX_PATH or set
  "LLVM_DIR" to a directory containing one of the above files.  If "LLVM"
  provides a separate development package or SDK, be sure it has been
  installed.

-- Configuring incomplete, errors occurred!
See also "/Users/x/code/sb/hobbes/CMakeFiles/CMakeOutput.log".

Darwin y.local 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64

Am I missing something?

This solved it. Thanks!
brew install llvm37
 env<EMAIL_ADDRESS>cmake .

Awesome, hope to hear more about your experience and thoughts!  :)


添加节点能否动态填入内容？

您好，在进行添加子节点的时候，能否弹出对话框，或者设置我要添加的节点内容？或者是否已经实现了，有代码参考吗？

In English
Hello, when adding child nodes, can a dialog box pop up, or set the content of the node I want to add? Or is it already implemented, is there a code reference?

In English Hello, when adding child nodes, can a dialog box pop up, or set the content of the node I want to add? Or is it already implemented, is there a code reference?

Use onAppend event.


Skip texture management example on MI300 and above

To resolve build failure when building the entire example suite on an MI300.

FYI: in our internal branch for fixing the examples for ROCm 6.1 we also solved this issue by doing
+ #if !defined(__HIP_NO_IMAGE_SUPPORT) || !__HIP_NO_IMAGE_SUPPORT
+   // Read the value from the texture, if supported.
     unsigned char val = tex2D<unsigned char>(tex_obj, u, v);
+ #else
+   // Prevent compile errors on HIP architectures that do not support
+    // texture instructions.
+    (void)u;
+   (void)v;
+   (void)tex_obj;
+   unsigned char val = 0;
+ #endif

within the texture management example, so it can still be compiled for the gfx4* archs.

Thanks for the FYI. Will your internal change eventually be pushed to ROCm/rocm-example?
If yes, I'll just wait for that to come. If not, I'll update my PR. :)

@dgaliffiAMD yes, just opened the PR now (#138 ) :)

Closing, as this will be addressed in PR#138.


Project source models

fix #4280

All changed packages have been documented.

:white_check_mark: @typespec/compiler

Show changes
@typespec/compiler - fix ✏

[API] model sourceModels property are now projected correctly

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Add animations to main menu items on hover

Is this issue valid? Do we have designs for those animations?


Development discontinued?

has the development on this extension been discontinued ?

No, we just waiting for Store Credits to get into Spree Core before updating the master branch. You welcome to submit PR's to other branches.

perfect, thank you! does this work with 2.3 ?


Broken installation due to missing sdn manifests

Hello,
I am trying to rollout an okd 4.6 cluster on vsphere with upi method.
The installation breaks everytime when starting the sdn pods:
[root@bootstrap ~]# oc --kubeconfig=/etc/kubernetes/kubeconfig get events -A
[...]
openshift-infra                                    11m         Warning   NetworkNotReady           pod/recyler-pod-master-01.ocp-infratest.cloud.mydomain.net   network is not ready: runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file in /etc/kubernetes/cni/net.d/. Has your network provider started?
[...]

The nodes are not ready because of missing sdn:
[root@bootstrap ~]# oc --kubeconfig=/etc/kubernetes/kubeconfig describe node master-01.ocp-infratest.cloud.mydomain.net
[...]
Conditions:
  Type             Status  LastHeartbeatTime                 LastTransitionTime                Reason                       Message
  ----             ------  -----------------                 ------------------                ------                       -------
  MemoryPressure   False   Fri, 27 Nov 2020 12:43:15 +0000   Thu, 26 Nov 2020 22:05:59 +0000   KubeletHasSufficientMemory   kubelet has sufficient memory available
  DiskPressure     False   Fri, 27 Nov 2020 12:43:15 +0000   Thu, 26 Nov 2020 22:05:59 +0000   KubeletHasNoDiskPressure     kubelet has no disk pressure
  PIDPressure      False   Fri, 27 Nov 2020 12:43:15 +0000   Thu, 26 Nov 2020 22:05:59 +0000   KubeletHasSufficientPID      kubelet has sufficient PID available
  Ready            False   Fri, 27 Nov 2020 12:43:15 +0000   Thu, 26 Nov 2020 22:05:59 +0000   KubeletNotReady              runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: No CNI configuration file in /etc/kubernetes/cni/net.d/. Has your network provider started?
[...]

In fact, most of the manifest files on the master nodes and the cni folder are empty:
[root@master-01 ~]# ls -l /etc/kubernetes/manifests/
total 4
-rw-r--r--. 1 root root   0 Nov 26 22:00 coredns.yaml
-rw-r--r--. 1 root root   0 Nov 26 22:00 haproxy.yaml
-rw-r--r--. 1 root root   0 Nov 26 22:00 keepalived.yaml
-rw-r--r--. 1 root root   0 Nov 26 22:00 mdns-publisher.yaml
-rw-r--r--. 1 root root 709 Nov 26 22:00 recycler-pod.yaml

[root@master-01 ~]# ls -l /etc/kubernetes/cni/net.d/
total 0

I couldn't find any helpful information for the error message on the internet. I also don't know where the manifests are being generated.
Any advice on how to debug this?
I am using okd 4.6.0-0.okd-2020-11-26-085309 and fcos 32.20201104.3.0 initially, which updates itself to 33.20201124.10.1 after the first reboot.
Thanks,
Tim

Check oc get nodes - first three masters in NotReady should join the cluster. This is where bootstrap node starts network operator, which runs DaemonSets in sdn namespace. Multus iirc should have created CNI configs - check crictl ps -a for containers created there

Unfortunately there was a mistake in the ignition configuration. The worker nodes got the same ignition files as the master nodes. After fixing that, the control plane was able to start.


autopull error

See the following:
$ make update

go run build/cmd/zonedb/main.go -update -w -c 100
Read 4355 zones
Read 4216 metadata files
Working on 4355 zone(s) out of 4355
Parsing http://www.internic.net/domain/root.zone
New zone tiia
New zone whois.nic.beauty
New zone _
Set 52 whois servers, 0 URLs from Ruby Whois
Querying whois-servers.net for 4358 zones...
Found 0 whois servers
Querying whois.iana.org for 1740 TLDs...
Fetching name servers for 4358 zones...
Found 6908 name servers
Wrote 4358 zones
Wrote 4216 metadata files, deleted 0
Time elapsed: 25m33.033s
make zones.go
go generate
Warning: missing parent nic.beauty for subdomain whois.nic.beauty at zones.txt:4331
Read 4358 zones
Read 4216 metadata files
Fatal: read failed with 1 issue(s)
exit status 1
zone.go:10: running "go": exit status 1
make[1]: *** [zones.go] Error 1
make: *** [update] Error 2

fixed by https://github.com/zonedb/zonedb/commit/d5c663 & https://github.com/weppos/whois/pull/541


[FIX] Integrated React into frontend repo

Description
Integrated Reactjs into repo
All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #10
How Has This Been Tested?
Previously test wasn't passing now it does.
Screenshots (if applicable, else remove this line / section)
Previous Test Result

Updated Test

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added necessary inline code documentation
[x] I have added tests that prove my fix is effective and that this feature works
[x] New and existing unit tests pass locally with my changes

Thanks so much, will take a look and let you know what happens.
On Fri, May 22, 2020, 10:58 PM Tiku Okoye<EMAIL_ADDRESS>wrote:

@primuse requested changes on this pull request.
Make the changes I suggested and update the test suite so that your test
passes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BuildForSDG/Team-213-agroMart-Frontend/pull/11#pullrequestreview-417204424,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGDKOPCOYOTT7A7HHTLMFFDRS3YQZANCNFSM4NG62SHA
.

@sintimmisa I see you have some checks failing as a result of failed netlify deploys. Have you checked why?

Thanks


Doc - Usage: Editions schmitions

Background:
    Given I install Rust following the Rust project directions
    And I successfully run `rustup update --no-self-update stable`

  @requires-bash
  Scenario: Cucumber BDD
    Given I follow the cucumber-rust Usage document
    And a file named "Cargo.toml" with:
    """
    [package]
    name = "hello-world"
    version = "0.1.0"

    [[test]]
    name = "cucumber"
    harness = false # Allows Cucumber to print output instead of libtest

    [dev-dependencies]
    cucumber = { package = "cucumber_rust", version = "^0.7.0" }
    """
    When I run `cargo test --test cucumber`
    Then the exit status should be zero
    And the stderr should not contain:
    """
    error[E0670]: `async fn` is not permitted in the 2015 edition
      --> 01_hello_world/tests/cucumber.rs:13:5
       |
    13 |     async fn test_async_fn(&mut self) {
       |     ^^^^^ to use `async fn`, switch to Rust 2018
    """

It appears the incantation is
cargo fix --edition

and add to Cargo.toml
[package]
...
edition = "2018"
...

cucumber = { package = "cucumber_rust", version = "^0.7.0" } imports the crate with the name cucumber, and extern crate is largely not needed in 2018.
You can read more about that here: https://doc.rust-lang.org/stable/edition-guide/rust-2018/module-system/path-clarity.html

@bbqsrc isn't that line what I have in this issue and in issue #75 ?

Yes, the issue was that the README incorrectly copied the extern crate from the internal tests we have where it is required. It is not longer in the README so copy and pasting it won't happen. :smile:


Move Pipeline to miningpipeline.MiningPipeline

Moves o.c.s.Pipeline to o.c.s.miningpipeline.MiningPipeline.

Codecov Report

Merging #191 into master will not change coverage.
The diff coverage is 100%.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd51946...370ac9a. Read the comment docs.


Output PO number in detailed report

The PO number header was added during the beam migration but we forgot
to print the actual data in the corresponding column. This resulted in a
misalignment of columns in the detailed report.
This PR fixes it. Note that we cannot drop PO number from the header (as is not
useful in the detailed report) because the header represents all fields
that are to be parsed from the SQL query results, and PO number is
needed when generating the invoice itself. By dual-purposing the header
(both as the required fields in the parser and the first line in the
detailed report) we have to include the value of PO number in the
detailed report CSV as well.

This change is

@Exprosed


I have quick questions for training

Thanks for your awesome works.
I just would like to train model with Kinetics-Skeleton data.
I download Kinetics-Skeleton, preprocess that data and generate the bone and the joint data with tools.
then, I am capable of obtaining train_data_joint.npy , train_data_Joint_motion.npy, train_data_bone.npy and train_data_bone_motion.npy
When i am about to run run.sh script for training, i should change the file named train.yaml.

but there is a component about data_path, i don't know what i choose the file among rain_data_joint.npy , train_data_Joint_motion.npy, train_data_bone.npy and train_data_bone_motion.npy.

What's the difference about them?

there are some files in data_gen folder: merge_joint_bone_data.py and merge_joint_motion_data.py. i would like to know the purpose and the usage of that files.

could you give me some advises?

For single stream, you can choose the train_data_joint.npy, it performs best.
You can know their exact meaning from Skeleton-Based Action Recognition with Multi-Stream Adaptive Graph Convolutional Networks
It merges two different data (joint and bone or motion) along the channel dimension, so the input_channel should change to 6, if you double the channels of the network, it should perform better than the score level fusion.
If you have any other questions, feel free to put them here.

Thanks for your reply :) I read the paper in your answer. I have another question.

if i would like to recognize multiple people's action, how should i do? input data is merged by the mean function along the M dimension before passing through the FC layer. M means number of the person which has high energy. but it is merged...

Could u give me some advises?

Sorry, so far, skeleton behavior recognition only supports single-person action recognition or multi-person interaction action recognition.
For your question (multiple person action recognition), I have two suggestions.

Detect and track the persons, then use pose estimation (e.g. openpose) to extract the skeleton sequences for each person, than recognize the actions with skeleton-based action recognition.
Maybe you should read the paper in Spatial-Temporal Action Detection, for example, MOC
Hope this helps you~

i appreciate for your reply. I already read the paper about MOC! anyway, thansk for your awesome work and answers! I try to do your recommendation in the frist manner.


refactor(cli): split the command files

Current dependencies on/for this PR:

main

PR #2447   👈

This stack of pull requests is managed by Graphite.

Merge activity

Feb 19, 11:43 PM EST: @Boshen merged this pull request with Graphite.


Fixes user-csv-import

Replaces the templates of all csv-import-components with -component
Moves the logic from base-import-list.component to basic-import-list.component

if i recall that correctly, we "used to" treat bulk actions and single create actions as @GabrielInTheWorld shows here, while working on 3.0. Was there a specific reason to drop it?

I'm not sure what you mean @GabrielInTheWorld did here (I did not look into all 1000 LOCs ;) ). For the bulk actions now: All actions should accept a list of instances, so you can create multiple objects in one action.

looks a lot cleaner, however, there are certain things to enhance.
@FinnStutzenstein if i recall that correctly, we "used to" treat bulk actions and single create actions as @GabrielInTheWorld shows here, while working on 3.0. Was there a specific reason to drop it?

If I recall it correctly, then we have to use different functions for single and bulk actions because there were different endpoints to request to, in OpenSlides 3.x. Now, our action-system has only one endpoint and let us combine multiple actions in one request. This is the reason, why I unified the single and bulk actions for the same intention. They do the same. The only different is the amount of models that are involved.
Do @FinnStutzenstein and my replies answer your question, @tsiegleauq?


fix(installer): fix scoop on windows

Automatically install scoop using the -RunAsAdmin flag on the get.scoop.sh

I am not familiar with powershell, why the echo command? Have you tested this command?

Yes I did

The | powershell executes what echo printed

I messed up, will fox in the next commit

The scoop install guide has instruction on installing scoop here. There is no need to use admin rights. In fact, it is not encouraged. If you have specific needs, you can customize yourself.


can't even run install file?

Is it a mod compatibility issue?
No
If it's a mod compatibility issue, please provide the link(s) to the incompatible mod(s)
No response
Minecraft version
1.20.2
Describe the issue
I can't even run the installation file, immersive-portals-4.1.4-mc1.20.2-fabric.jar. If I double-click and click past the warning from Windows, nothing happens. If I run it in the terminal, like so: java -jar .\immersive-portals-4.1.4-mc1.20.2-fabric.jar, I get this error:
no main manifest attribute, in .\immersive-portals-4.1.4-mc1.20.2-fabric.jar
I'm definitely missing something obvious here, thank you

search how to install fabric mods, you don't need to open the jar files, you need to put them in the mods folder

apologies, i've never installed a fabric mod before! thank you


Is the API pricing for the Deepseek v2 coder 230B model?

The price of the API is really low, but I want to know if the large version of the model endpoint is correct.
I can't seem to find any information on it.

It's the large one. The name is "Deepseek-Coder-V2" instead of "DeepSeek-V2-Lite".

The model on the platform is DeepSeek-Coder-V2 236B.

The model on the platform is DeepSeek-Coder-V2 236B.

Thank you for the amazing model release.

Is the model on the platform  base or instruct version?


Can you add the Dayle Rees themes

https://github.com/daylerees/colour-schemes/tree/master/sublime
and the subway themes would be good too
https://github.com/idleberg/Subway.tmTheme
Thanks.

Could you make a pull request?

closed due to inactivity


Etcher thinks images are too small when they are not

v1.0.0-beta19
Win 7 x64 pro
custom raspbian
no error in devtools

Hiya, I have a custom image that is 3,965,190,144 bytes

and trying to burn to 4G card which reports 3,955,228,672 bytes free.

What is odd is etcher says there's not enough space

but win32 disk imager works fine? not sure how this is possible - is there some lower-level size that would allow win32 disk imager to work?

I'm confused – Etcher is doing the right thing here, isn't it? The 4 GB card is a whole 9.5 MB smaller than the image if I read your numbers correctly.

yes! sorry, etcher is correct, but...win32 imager writes it fine...which makes me wonder if there's some other lower-level-space-calculation that is not related to what the OS reports!

No, but there might be a difference in what Win32DiskImager sees if it's using a different Windows API than we are to get the device size – there are some Win APIs (the COM stuff, for example) that still report it based on CHS addressing, where the size cannot be represented precisely for a lot of storage devices.

hmm yah - the reason this comes up for me is that if you 'read' the SD card using win32, it creates an image that is that size. so basically you cannot use etcher to burn images that are backups.
anyways, its not a huge deal!

Ooh... I didn't realise that at first; but in this case we should look into it – not that we're screwing something up here. I'll try to reproduce this.

np - sorry initial report was super unclear :D

Because I am an idiot, and can't read, I didn't see that you're still on Etcher v1.0.0-beta19 – that is a version that's using an older version of drivelist that does still use the inaccurate CHS APIs. Can I ask you to try this again with the current Etcher v1.1.2?

Hi @ladyada I've just noticed that in your first post you said you're using Etcher v1.0.0-beta19 ? That's a really old version, and it suffers from "using the COM API which CHS addressing to calculate the disk-size" bug https://github.com/resin-io-modules/drivelist/issues/142
If you use the latest version of Etcher (v1.1.2) you should find that Etcher is able to write your disk-image without any problem :)
The reason that Windows shows the disk as having a capacity of 3,955,228,672 bytes is because this is the capacity of the filesystem, not of the raw disk.

I've just tried to reproduce this with Etcher v1.1.2, and there's no size difference between Win32DiskImager and Etcher, so that should work.

omg wait, i always update when i get a popup - but yeah now that i think of it i haven't seen an update in a while. sigh ok thanks i will manually update!

yep all good now. thank you!

@lurch there's a difference of 9.5 MB (!) between the two though – that seems a bit excessive – wonder where that's coming from.

Good to hear @ladyada! Glad we don't have a bug here after all :)

there's a difference of 9.5 MB (!) between the two though

Perhaps whatever formatting tool is being used didn't create the partition spanning the whole extent of the disk?


is the camera coordinate colmap

Hi, Thanks for sharing the dataset.
I saw the camera_xxxx.txt file stores the c2w. Is it in colmap coordinates or blender or others?
Thanks

I got it. It's in colmap. Thanks!
I got another question, for evaluating relighting, does you also added the results of relighting with the input (source, not novel ones) envmap?
Thanks,


Port practical support model to pg

I rule and have completed some work on Case Manager that's ready for review!
Ports practical support and associated logic to postgres.
There's no practical supports in the seedfile, so you'll need to create some manually, unfortunately:
git checkout main && rails db:drop db:create db:migrate db:seed
echo "Patient.first.practical_supports.create source: 'Metallica Abortion Fund', support_type: 'Transportation', created_by: User.first" | rails c
echo "Patient.last.practical_supports.create source: 'Metallica Abortion Fund', support_type: 'Transportation', created_by: User.first" | rails c

git checkout pg-psup && rails db:migrate migrate_to_pg:clinic_user_patient
echo "PracticalSupport.count" # 2

This pull request makes the following changes:

Port PracticalSupport model to pg

no view changes
It relates to the following issue #s:

Bumps #2072

For reviewer:

Adjust the title to explain what it does for the notification email to the listserv.
Tag this PR:

feature if it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.
dependencies if it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.

If it contains neither, no need to tag this PR.

There's no practical supports in the seedfile, so you'll need to create some manually, unfortunately:

Should we create some? Sounds like a nice beginner-friendly issue

pro adding some! I'll spin up an issue for it


Fixing a few missing language strings

Mostly fixes #2

Might eventually be worth just avoiding any base-system strings when possible, to avoid future problems.


Token Refresh

Is the token supposed to automatically refresh when the token expires or do I need to manually call this when required.
If I shorten the token timeout to 60 seconds, then 60 seconds after logging in the app logs out of the session and redirects to the login route.
Is this the expected behavior?  Is there a pattern where I can tell the token to refresh (it doesn't seem to be refreshing on it's own)

Hey guys, we could use some direction with this as well. Right now we have set out tokens to expire after something like a week, which isn't useful because we have permission related items in the token. This means if anything with permissions changes we have to wait for the token to expire before changes are realized, or the user is in a broken state.
Is this expected? How else should we handle this?


Adding functionality to SPI/CGPA converter.

The SPI/CGPA converter contains just the rules.
I would like to add functionality to convert SPI to CGPA and vice versa.
Please assign this to me.

Functionality is already implemented


Nothing happens when trying to download blobs with AzCopy enabled

Storage Explorer Version: 1.5.0
Platform/OS Version: Windows 10/ MacOS High Sierra/ Linux Ubuntu 16.04
Architecture: ia32
Build Number: 20181119.1
Commit: b4d317fd
Regression From: Not a regression
Steps to Reproduce:

Add 'Reader' and 'Storage Blob Data Reader(Preview)' roles on storage account scope.
Expand this account -> Open one blob container which contains one blob at least -> Make sure the AzCopy feature is enabled.
Try to download blobs from the blob container -> Check the result.

Expected Experience:
The selected blob can be downloaded successfully.
Actual Experience:
Nothing happens when trying to downloading the blob.
More info:
This issue still reproduces when uploading blobs to one blob container which has write permission.

Although AzCopy command line supports RBAC, we haven't built in RBAC support in Storage Explorer using AzCopy yet.  It is a work item in our backlog however.

Verified this issue on build 20201119.2. Fixed.


Undefined values for Entity boolean properties can crash Cesium

From the forum, the below snippet will crash Cesium when jumping to a time outside of the show interval because we internally return undefined which then has boolean logic applied to it, which simply propagated the undefined.  Eventually, we try and create a ShowGeometryInstanceAttribute with a value of undefined, which throws.
var czml = [{
        "id": "document",
        "version": "1.0"
}, {
    "id": "water1First",
    "availability": "2012-08-04T00:00:00Z/2012-08-05T02:00:54.9962195740191Z",
    "polygon": {
        "positions": {
            "cartographicDegrees": [
                0, 0, 55660,
                0.5, 0, 55660,
                0.5, 5, 55660,
                0, 5, 55660,
                0, 0, 55660
            ]
        },
        "material": {
            "solidColor": {
                "color": {
                    "rgba": [0, 0, 255, 255]
                }
            }
        },
        "outline": [
            {
                "boolean": true
            }
        ],
        "perPositionHeight": [
            {
                "boolean": true
            }
        ],
        "show": [
            {
                "interval": "2012-08-04T00:00:00Z/2012-08-04T02:00:54.9962195740191Z",
                "boolean": true
            }
        ]
    }
}];

var viewer = new Cesium.Viewer('cesiumContainer');
var dataSourcePromise = Cesium.CzmlDataSource.load(czml);
viewer.dataSources.add(dataSourcePromise);
viewer.zoomTo(dataSourcePromise);

Congratulations on closing the issue! I found these Cesium forum links in the comments above:
https://groups.google.com/d/msg/cesium-dev/wUL8pqy5jf0/0LQg4hRLTfIJ
If this issue affects any of these threads, please post a comment like the following:

The issue at https://github.com/AnalyticalGraphicsInc/cesium/issues/2650 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:


⚠ BCR Bot has degraded performance

In 0053131, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 1455 ms

Resolved: BCR Bot performance has improved in 6aa3126.


The 'Optimize Images' filter does not affect images with scandic letters

The 'Optimize Images' filter does not seem to affect images which have scandic letters(ä, ö, etc) on the filename. Filter affects all the other images on my site that does not have scandic letters.
Server: Apache/2.4.10 (Debian)
X-Mod-Pagespeed: <IP_ADDRESS>-7443

Duplicate of Issue 704

https://github.com/pagespeed/mod_pagespeed/issues/704


Does not compile on windows

because of the semicolon in
    "prepare": "tsdx build; husky install",

windows parses it as calling tsdx with build; husky install

this should be fixed in 35588c9e321e659b7273d495057528a869641995


Support for Apple Silicon using Homebrew installed Python

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
Ex. I'm always frustrated when [...]
I use Homebrew installed python (3.11.7 currently) pip3 (24.0).  I use pip3 installed  cvxpy(1.4.2) , open source cvxpy solvers along with jupyterlab (4.1.1).  I use both arm64 and i386 (Rosetta2) versions because some codes run faster in one or the other. I have been running a modified version of cvxportfolio in Jupyterlab / notebook for  a while.
Poetry does not seem to work in this environment.  See unresolved issues on Github (install.python-poetry.org)  for over a year : @Poetry environment breaks when Homebrew upgrades Python on MacOS #71
I want to evaluate cvxmarkowitz but seems like it assumes use of poetry for the install.  Is that true?  If I use pip3 to install all the required packages is there a way to make it work on Apple Silicon / Homebrew?
Describe the solution you'd like
A clear and concise description of what you want to happen.
It would be nice if there was a working version of cvxmarkowitz and  examples that (1) works on Apple Silicon with homebrew installed python3 and other packages / libraries using pip3.  (2) open-source non-proprietary solvers for cvxpy (MOSEK trial license not needed).
Describe alternatives you've considered
A clear and concise description of any alternative solutions
or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Thank you for your comment

You can clone the repo and use poetry (see https://python-poetry.org) and then make install to construct the virtual environment used and expected by cvxmarkowitz

The correct link to the poetry issue is https://github.com/python-poetry/install.python-poetry.org/issues/71

I would recommend using pyenv to manage your local Python installations. Do not rely on homebrew for that job. In those environments you can actually pip install poetry (although poetry people would not recommend that).

It's also a bit too early to evaluate cvxmarkowitz. It's a bit too early at this stage. We have not yet published a version of it on pypi and once we have you can simply run "pip install cvxmarkowitz".

Thanks @tschm!
I will check out use of pyenv with my homebrew installs for separation.   Once that works, I will try poetry per the documentation.  However, the sheer number of open issues in poetry repo on GitHub makes me wonder if it will be robust.

Hi @tschm
I did manage to use the built-in venv to create environments with different versions of installed homebrew python and tested that they work in Jupyter lab kernels as expected.
Next, I downloaded cvxgrp/cvxmarkowitz and ran make install per your instructions in README.md.  That seemed to work fine. make test' worked.   However, there is no make kernelentry in your Makefile.  I assumed you wanted to build Jupyter so I built it usingpoetry run pip3 install jupyterlab, poetry run Jupyter lab build`.  What kernel did you want to build?
Separately, make coverage reports missing cvx/markowitz/portfolios/soft_risk.py         28     28     0%   14-67.
Trying to run examples:
$poetry run python backtest.py
Traceback (most recent call last):   File "/Users/sunilshah/Library/Mobile Documents/com~apple~CloudDocs/Python/cvxmarkowitz-main/experiments/backtest.py", line 11, in <module>     from cvx.simulator.builder import builder ImportError: cannot import name 'builder' from 'cvx.simulator.builder' (/Users/sunilshah/Library/Caches/pypoetry/virtualenvs/cvxmarkowitz-glLIiM4z-py3.11/lib/python3.11/site-packages/cvx/simulator/builder.py)
Suggestions?

@sunilshah. Ok, I should add the make kernel to the Makefile. However, it's not really needed as make jupyter installs jupyterlab in the same python environment. Maybe my documentation is a bit out of sync here... You should use the python3 standard kernel if jupyter and cvxmarkowitz are served from the same environment. The backtest.py is a problem. I need to sync with the cvx.simulator package...

Thanks @tschm


fnotifystat: fix src/homepage, moved to github

Motivation for this change
Mentioned source (and homepage) no longer work, presumably because it's
now on GitHub.
Update accordingly, and while visiting the file also touchup the build
to match pattern used for other ColinIanKing utilities
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Could you also update meta.license to gpl2Plus? (to use current SPDX 3.0 license ids)
I forgot to update that when I updated other cking packages

Could you also update meta.license to gpl2Plus? (to use current SPDX 3.0 license ids)
I forgot to update that when I updated other cking packages

Sure thing, thanks for catching that! Updated! :)


Make it possible to reference a SigningCredential in DefaultIntegrationServiceConfiguration

When setting up instances of DefaultIntegrationServiceConfiguration we can do everything from a Spring Boot properties file except for setting the signingCredential property. We don't want to use a concrete class for this purpose since configuring a HSM-credential differs from setting up a soft credential. A good solution would be to reference a named SigningCredential bean.

Even better is to introduce a converter.


Presign URL not refreshing for same file within same day.

Hello James,
When I try to regenerate the presign URL for same object name after it expires, it does not change for the same day.
As a business requirement I need to update the object within same day, due to same presignURL I'm unable to overwrite the object after 300s and same date.
Can you please assist, if this can be done in nodejs.
Thank you,

Change this configuration parameter to the desired expiration time.
https://github.com/jthomas/serverless-file-storage/blob/master/nodejs/presign/presign.js#L32

Thanks James, I've tried changing Expires: 300 to a constant or random value but presign URL remains same in Cloud function - nodejs api response.
Do you recommend to keep presign valid for 24 hours?


In realignYawGPS() reset the wind estimate and dont use it for t…

…he yaw align
If a fixed wing experiences a bad heading estimate in cruise flight the wind estimate will most likely be very bad, (due to sideslip and airspeed fusion during the period from the bad heading estimate to the reset). Using this bad wind estimate to re-align the heading is thus risky and should be avoided.
@priseborough interested to hear your opinion

I briefly looked through our data and couldn't find a good example of an in flight reset with a decent amount of wind and sideslip fusion active. Will update here as soon as I find something

Ping?

I could not find any data with a reasonably new version of ecl verifying this so closing here. Lets come back to it if it is needed


Add Safety orders using profit

Is your feature request related to a problem? Please describe.
Just like the script created by @Lutjebroequer, it would be nice to increase the bot with more Safety orders.
Describe the solution you'd like
In the compound.ini file add a value that notes down the actual max safety orders and desired safety orders.
Technically it should work the same as "add max active deals"
Describe alternatives you've considered
/
Additional context
A problem/decision that would rise is to choose between "addmaxactivedeals" and "addsafetyorders".
My personal preference is to give priority so "addmaxactivedeals"

#72


Install templates from a remote tarball

Broken out from #2555 @jandubois:

There is no way to install templates from a remote tarball
Since we [sc. Rancher Desktop] can't rely on git being installed, we need to install using --dir from a local directory because there is no option to install from a remote tarball like this:
spin templates install --from https://github.com/fermyon/spin/archive/refs/heads/main.tar.gz
That means we need to download the file ourselves, unpack it into a temporary directory, install from there, and then remove the temporary directory again.
Since we are doing this from a shell script, it means we need curl or wget, neither of which are guaranteed to be installed.

Thank you! This will simplify our setup-spin logic, so we no longer need to hunt for wget or curl. Too late for 1.17.0, but I created a GitHub issue as a reminder.

Too late for 1.17.0, but I created a GitHub issue as a reminder.

We had to push the release to early January anyways, so still squeezing this into 1.17.
@itowlson Nice simplification for our setup-spin script: https://github.com/rancher-sandbox/rancher-desktop/pull/7982/files
The script was not properly cleaning up the temp directory inside WSL2 distros. So getting rid of that code is better than having to figure out what was wrong with it (things get confusing when you manipulate the same directory both on the host, and through the 9p mount).


Added startupProbe

Added startupProbe

to increase start speed up.
best practice
some migrations can takes a long time and initialDelaySeconds=90 for livenessProbe maybe a little.

Hello @mustdiechik,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.
Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.
This is a standard procedure for many open source projects.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

/check-cla

@mustdiechik In my view these values (failureThreshold,periodSeconds,initialDelaySeconds,timeoutSeconds) shouldn't be hardcoded in the template. You could follow the approach we have on this PR.

+1 on what @stafot mentioned

@mustdiechik looks good. Did you sign the CLA? Seems that there's still an issue

/check-cla

@mustdiechik CLA looks good to me unsure why it fails. Although you need to resolve conflicts on this PR

@stafot check please

@spirosoik ^^

@mustdiechik let's have a similar PR for the enterprise edition too. It will be valuable there too.


Validator returns AttributeError: 'list' object has no attribute 'get'

intel@ubuntu:~/Redfish-Interop-Validator$ python3 RedfishInteropValidator.py -c config/example.ini OCPRackManagerController.v1_0_2.json >> deletesValues.txt
Traceback (most recent call last):
  File "RedfishInteropValidator.py", line 10, in <module>
    status_code, lastResultsPage, exit_string = main()
  File "/home/intel/Redfish-Interop-Validator/redfish_interop_validator/RedfishInteropValidator.py", line 224, in main
    success, _, resultsNew, _, _ = validateURITree('/redfish/v1/', profile, 'ServiceRoot', expectedJson=jsonData)
  File "/home/intel/Redfish-Interop-Validator/redfish_interop_validator/validateResource.py", line 336, in validateURITree
    msgs = interop.validateComparisonAnyOfAllOf(profile_entry['PropertyRequirements'], resource_type)
  File "/home/intel/Redfish-Interop-Validator/redfish_interop_validator/interop.py", line 48, in validateComparisonAnyOfAllOf
    my_compare = property_profile.get('Comparison', 'AnyOf')
AttributeError: 'list' object has no attribute 'get'

Do you know if this a problem with the profile or the validator?  (If the validator, then the issue should be filed in that repository.)

I think the problem lies within profile. The field Voltages under Power has square brackets instead of curly brackets. And the Validator cannot handle that correctly.

Can you edit the profile accordingly and verify that it fixes this issue?

Yes, I replaced the brackets in profile file and it fixed the issue.

Fixed in v1.0.3

Hi, @jcleung5549
I'm sorry for misleading you, but deleting the brackets completing will resolve the issue. So, not changing the brackets, but deleting unnecessary curly brackets in l336 and l344 will solve the issue.


Introduce new ELF parser

When config.new_elf_parser=true, parse ELF files using a new dependency free ELF parser instead of the old goblin based one.

I still want to add some structured fuzzing, but this is now ready for review!

Codecov Report

Merging #348 (7f5ddce) into main (19515b4) will decrease coverage by 1.07%.
The diff coverage is 75.87%.

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   90.28%   89.20%   -1.08%
==========================================
  Files          21       24       +3
  Lines        8390     9071     +681
==========================================
+ Hits         7575     8092     +517
- Misses        815      979     +164

Impacted Files
Coverage Δ

src/lib.rs
100.00% <ø> (ø)

src/elf_parser_glue.rs
41.31% <41.31%> (ø)

src/elf_parser/types.rs
71.42% <71.42%> (ø)

src/elf.rs
89.81% <84.97%> (+1.01%)
:arrow_up:

src/elf_parser/mod.rs
93.96% <93.96%> (ø)

src/vm.rs
80.18% <100.00%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19515b4...7f5ddce. Read the comment docs.

As it is now, the new parser is supposed to be a drop in replacement for the old goblin parser. It does not enforce stricter checks yet. I'm happy to add those as part of this PR or do them as a follow up, but my priority for now is to be 100% compatible with the old parser so we can drop goblin sooner rather than later.

The new parser is a lot stricter (e.g. sections may not overlap, string length limits, etc.) do you plan on putting these restrictions behind a feature flag? Or just have them come with the general switch of the parser implementation feature gate?
Also, additionally to fuzzing, can we have benchmarks for parsing speed and memory consumption?

As it is now, the new parser is supposed to be a drop in replacement for the old goblin parser. It does not enforce stricter checks yet. I'm happy to add those as part of this PR or do them as a follow up, but my priority for now is to be 100% compatible with the old parser so we can drop goblin sooner rather than later.

The new parser is a lot stricter (e.g. sections may not overlap, string length limits, etc.) do you plan on putting these restrictions behind a feature flag? Or just have them come with the general switch of the parser implementation feature gate?

Good question! My reasoning so far is: I think it would be fine if enabling the new parser breaks a tiny percentage of tiny files and people have to redeploy them; It's not ok if it breaks a significant number of files, applying strict checks to non-complying files our toolchain generated not too long ago.
The rationale being that we're soon going to require developers to redeploy their files to comply to the SBFv2 format, and that it seems like a bad idea to roll out all the features needed to enable the new parser AND SBFv2 at the same time - there are a lot of moving parts, from toolchain to runtime.
So through that lens:

e.g. sections may not overlap, string length limits, etc.

The new parser checks that sections don't overlap with the ELF header, the program table and the section table. I think that's ok. Files that do overlap that way sound very broken to me and I suspect that we never generated them. It's possible that people did generate them using custom toolchains/linker scripts, but that sounds like it'd be a tiny fraction of deployed programs.
As for string length limits, this is a trickier one.
const SECTION_COUNT_MAXIMUM: usize = 16;
const SECTION_NAME_LENGTH_MAXIMUM: usize = 16;
const SYMBOL_NAME_LENGTH_MAXIMUM: usize = 64;

The first two seem fine to me, and doubt that our toolchain ever generated non compliant files. As for the third, is there a reason why you chose 64 as the value? It doesn't seem very large to me, I wouldn't be surprised if that actually broke a few files, so I'm tempted to raise it.

Also, additionally to fuzzing, can we have benchmarks for parsing speed and memory consumption?

Sure load speed benches should be easy enough. As for memory consumption, not sure if there's a simple way to do that? Don't know if we have any insight into what goblin does (I mean I know it uses scroll etc, but don't know if it does any buffering internally). Would probably have to parse procmaps and stuff like that, which seems a bit painful.

I still want to add some structured fuzzing, but this is now ready for review!
As it is now, the new parser is supposed to be a drop in replacement for the old goblin parser. It does not enforce stricter checks yet. I'm happy to add those as part of this PR or do them as a follow up, but my priority for now is to be 100% compatible with the old parser so we can drop goblin sooner rather than later.

Before we enable this new parser we should run a comparison of this parser vs the old on mainnet to actually find out if/what programs fail with the new parser.  We can't assume folks are going to upgrade their programs, even for ABIv2.  The assumption is that they will want to but are a variety of reasons why folks wouldn't or wouldn't for a while and they need to continue working.

Oops, sorry, didn't mean to close the pr!

Quick update on this: I've been running this against some ledger snapshots from MNB and so far have found only one issue I'm now looking into related to parsing dynamic tables, but otherwise seems to do pretty ok.

Quick update on this: I've been running this against some ledger snapshots from MNB and so far have found only one issue I'm now looking into related to parsing dynamic tables, but otherwise seems to do pretty ok.

Ok those were actually two issues which I've now fixed in eceac86 and c1cf8b5
I've now tested this against 409 unique mnb programs and there are no remaining issues. I'm now doing a run with a larger ledger.

const SECTION_COUNT_MAXIMUM: usize = 16;
const SECTION_NAME_LENGTH_MAXIMUM: usize = 16;
const SYMBOL_NAME_LENGTH_MAXIMUM: usize = 64;

The first two seem fine to me, and doubt that our toolchain ever generated non compliant files. As for the third, is there a reason why you chose 64 as the value? It doesn't seem very large to me, I wouldn't be surprised if that actually broke a few files, so I'm tempted to raise it.

I found a program in MNB right now that has a symbol name that is 283 characters long. It's a borsh serde generated symbol and it doesn't even seem that long. I'm tempted to bump SYMBOL_NAME_LENGTH_MAXIMUM to 1024 - anyone against?

I have now tested this with 4 different ledger snapshosts from mnb, for a total of 575 unique programs, with 0 load failures. The oldest slot I was able to test is from February this year. I'm going to see if I can find an older snapshot, but I think we're ready to go ✌

@alessandrod add a elf fuzzer maybe, so we can fuzz the elf parser


graphics: ReplacePixels should take []color.RGBA instead of []byte

At least, this would require wasm ver or []color.RGBA would be really inefficient.

Hi! Would it still be inefficient to use []color.RGBA? I created a small test, but with using a (very) dirty unsafe trick to test the possibility os having []color.RGBA on the ReplacePixels API:
// extracted from reflect
type sliceHeader struct {
	Data uintptr
	Len  int
	Cap  int
}

func (i *Image) ReplacePixelsEx(fatpixels []color.RGBA) {
	i.copyCheck()

	if i.isDisposed() {
		return
	}
	r := i.Bounds()

	len4 := len(fatpixels)

	shdr := (*sliceHeader)(unsafe.Pointer(&fatpixels))
	shdr.Len = len4 * 4
	shdr.Cap = len4 * 4

	pixels := *(*[]uint8)(unsafe.Pointer(&fatpixels))

	// Do not need to copy pixels here.
	// * In internal/buffered, pixels are copied when necessary.
	// * In internal/shareable, pixels are copied to make its paddings.
	if err := i.buffered.ReplacePixels(pixels, r.Min.X, r.Min.Y, r.Dx(), r.Dy()); err != nil {
		theUIContext.setError(err)
	}

	// fix the slice header because it might be used by the caller
	shdr = (*sliceHeader)(unsafe.Pointer(&fatpixels))
	shdr.Len = len4
	shdr.Cap = len4

	return
}

It feels very wrong but the tests passed 🤷♂
Anyways, it was just an experiment

Thanks! Using unsafe would solve the performance concerns. My concern was GopherJS, where you cannot use unsafe.
I'll revisit this issue when Ebiten suspends to support GopherJS. (I think this will come when Ebiten's major version becomes v2).
BTW, I'm not confident []color.RGBA is really a good API compared to []byte

I don't see an obvious benefit so far. Mark this wontfix.


adding FMRL and BlazorPass app links

Hello @ebekker ... Thanks for submitting the links.
Could you provide more detail in the description? I noticed the one from TMWSD ...

TMWSD is a secure messaging service. Messages sent are encrypted, securely transferred, and automatically deleted when they are retrieved.

Could you write something out for the FMRL.link description similar to that?

Awesome ... thanks @ebekker! :rocket:


Small fixes/typos that didn't affect functionality but now cleaner

should @freddebacker give it a quick view?

He's in the reviewers list but this small fixes are going to be fine.


.launch (or init) should take an arg specifying where to place the unix sockets

Let's use whatever terminology mmstats is using.

It takes a path kwarg that defaults to tempfile.gettempdir(). The problem is that if the application launches socketconsole from one environment and socketreader is run from another environment, the temp dir might vary.
In this case I think the only sane thing to do is expect users to specify a path for socketreader on the command line:
socketreader /path/to/socketconsole/apps/tmp


Fun messages on Wednesday edges

Resolves #3
Motivation: If it is Tuesday or Thursday, I want to receive a fun message instead of "It is not :(".
I made a refactoring on commands/wednesday module. I hope you like it!
Unfortunately, I didn't open this PR on a Wednesday. :(

Oh, don't worry, i made the same mistake


WIP: Add node_exporter_manage_service toggle

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions
Remember to set idealista:develop as base branch;

Description of the Change

Benefits

One will be able not to configure service when applicable
Possible Drawbacks

Applicable Issues

Looks good to me, just one thing, could you mind updating the CHANGELOG.md?

done

Released these changes in v2.1.0. Спасибо @kostyrev for your contribution


Fix WARC headers parsing when record has Content-Length: 0 and record after it.

Validated against Python implementation: https://github.com/webrecorder/warcio
Also fixed flaky test record::verify_display by sorting header names.

Hi @jedireza! I appreciate your review on this PR, thanks!

@jedireza Thanks for coming back on this!
The test case zero_and_nonzero_content_length demonstrates the problem and if you rollback next method original logic let mut found_body = expected_body_len == 0; then it fails.
Regarding verify_display I don't feel strongly about specific way to fix flaky test, so I went with your suggestion sorting headers in the test.

Thanks for quick response and PR approval! I'd appreciate if you could merge it and release new version of the crate, so that I can update dependencies in my projects instead of using a fork.

Going to merge this and make it a minor release.