adding/deleting geojson layers, setProps method

To briefly provide context of my use case, I should mention that I'm trying to use a deck view in a country map where I dynamically add layers using geojson. There are two dropdown menus, one has cities and the other one has towns.
I am initializing the map as it is done on following example:
https://deck.gl/showcases/gallery/geojson-layer
In that example, it generates the layer first and then initializes the map with the newly generated layer.
My problem is, when I need to update map (where it zooms, with new layers that shows towns of cities) I simply can't get rid of previous city layers. As you can guess, I had success by generating a new map/layer pair but it's just inconvenient and plain bad practice.
In the following link, indeed there is a usage as such:
https://deck.gl/showcases/gallery/highway
However, I couldn't get my map to render new layers when I used it like "deckgl.setProps({layers});"
I'd like to have some tips regarding adding/deleting geojson layers and redrawing decks with different values.
I searched various keywords and I failed to find examples that demonstrate usage of setProps() method.
In case the post is not relevant enough (given that it doesn't particularly point out any bugs), you could just take this as a request for a more detailed documentation.
I realize that I am struggling probably because I'm not very familiar with "The Reactive Programming Paradigm". While waiting for some tips, I'll be trying to update my layers by changing my geojson variables. Hopefully that'll do the trick.
Thanks in advance, Taha.

You can listen to onViewStateChange callback

const deckgl = new deck.new DeckGL({
  onViewStateChange: onViewStateChange
  layers: [...]
});

function onViewStateChange({viewState}) {
   // decide which layers you would like to display
   const layers = [...];
   deckgl.setProps({layers});
}

Also you can toggle the visible prop of a layer.

@bonellia deckgl.setProps({layers}) should work. Items added/removed from the layers array are then added/removed from deck. Can you share your code if you are seeing different result?

I've managed to update deck object's layers props to be updated. By using geojson.io, I also confirmed that layers render on their tool. So the argument seems to be correct.
The code is as follows:
`
var tarimDeck;
var typeColorList = {};
$(document).ready(function () {
    // Set the map view zone.
    $("#TarlaMapView").css("height", $(window).height() - 200 + "px").css("width", "100%");

    const LIGHT_SETTINGS = {
        lightsPosition: [-125, 50.5, 5000, -122.8, 48.5, 8000],
        ambientRatio: 0.2,
        diffuseRatio: 0.5,
        specularRatio: 0.3,
        lightsStrength: [1.0, 0.0, 2.0, 0.0],
        numberOfLights: 2
    };

    // Get cities with geojson data to place initial layers.
    // Currently cities are pulled from a local file.
    var data = {};
    $.getJSON("./tr_iller_geo.json", function (file_content) {
        data = file_content;

        const visibleLayers = new deck.GeoJsonLayer({
            id: "current-layers",
            data,
            opacity: 0.6,
            stroked: false,
            filled: true,
            extruded: true,
            wireframe: true,
            fp64: true,
            lightSettings: LIGHT_SETTINGS,
            getElevation: f => (/* f.properties.alan ? (5 + 20 * f.properties
                    .ekiliAlan / f.properties.alan) :  */5555),
            getFillColor: f => /*(colorSetter(f.properties.urunType) ? colorSetter(f
                        .properties.urunType) : [0, 0, 0]) */random_rgba(),
            getLineColor: f => [0, 0, 0],
            pickable: true,
            onHover: updateTooltip
        });

        // Load the initial map view with city layers.
        tarimDeck = new deck.DeckGL({
            mapboxAccessToken: 'pk.eyJ1IjoiaGFiaWwyNCIsImEiOiJjanU5cHk1a3QwbGZwNGRuMHc4dHZsMGJwIn0.Yrkp8-SSLDqHTRCKzXd8DA',
            mapStyle: 'https://free.tilehosting.com/styles/positron/style.json?key=2OrAmqAgbK4HwBOq6vWN',
            container: 'TarlaMapView',
            latitude: 38,
            longitude: 35.8,
            zoom: 5.9,
            maxZoom: 16,
            pitch: 45,
            layers: [visibleLayers]
        });

        $("#il-dropdown").dropdown('setting', 'onChange', function () {
            // Actions Here
            var ilID = $("#il-dropdown").dropdown('get value');
            if (ilID) {
                $.ajax({
                    type: "POST",
                    url: 'getIlCEs',
                    dataType: 'json',
                    data: {
                        ilID: ilID
                    },
                    success: function (response) {
                        console.log("ilceler geldi", response);
                        var ilceFeatures = [];
                        response.forEach(x => {
                            if (x.geo) {
                                ilceFeatures.push(
                                    {
                                        "type": "Feature",
                                        "geometry": x.geo,
                                        "properties": {
                                            ilce_name: "salla_bisi"
                                        }
                                    });
                            }
                        });

                        var ilceFeatureCollection = {
                            "type": "FeatureCollection",
                            "features": ilceFeatures
                        };
                        console.log("ilce gejson: ", ilceFeatureCollection);
                        // Create new layers for  "ilce" geojson.
                        const newLayers = [new deck.GeoJsonLayer({
                            id: "current-layers",
                            data: ilceFeatureCollection,
                            opacity: 0.8,
                            stroked: false,
                            filled: true,
                            extruded: true,
                            wireframe: true,
                            fp64: true,
                            lightSettings: LIGHT_SETTINGS,
                            getElevation: f => (/* f.properties.alan ? (5 + 20 * f.properties
                    .ekiliAlan / f.properties.alan) :  */5555),
                            getFillColor: f => /*(colorSetter(f.properties.urunType) ? colorSetter(f
                        .properties.urunType) : [0, 0, 0]) */random_rgba(),
                            getLineColor: f => [0, 0, 0],
                            pickable: true,
                            onHover: updateTooltip

                        })];

                        tarimDeck.setProps(newLayers);
                        console.log("tarimdeck: ",tarimDeck);

                    },
                    error: function (err) {
                        console.log(err);
                    }
                });
            }

        });

    });

`
According to the documentation;
Layer ID
The id prop is the unique identifier of this layer among all layers. Constructing a new layer instance in its own does not have any performance impact, as deck.gl only does the expensive calculations when a layer is created (an id appearing for the first time) or updated (different props are passed in for the same id). Read more about this in layer lifecycle.
It is recommend that this prop is set explicitly to avoid collision.
I have generated one layer instance for cities (and initialized the deck with it) then on my city drop down menus' change listener, I generated a new layer instance with same id. This seems to suffice for updating my deck' layer props. However, it still shows city layers. I tried using redraw function, which also didn't help. Added true as "force" parameter.

@Pessimistress one thing I noticed is that, after I update layer props, I am inspecting the deck object and on layers, state is "awaiting-state". Is that expected?
I've read about layer lifecycles and I am a bit riddled when is it supposed to update the layers considering stuff I've already done. It seems to me like I'm updating it as intended, still the map won't update.
@xintongxia I have added your suggestion into my code (hopefully properly) in order to at least trigger the change when map is interacted (hover, drag, any of them).
            tarimDeck = new deck.DeckGL({
            mapboxAccessToken: 'pk.eyJ1IjoiaGFiaWwyNCIsImEiOiJjanU5cHk1a3QwbGZwNGRuMHc4dHZsMGJwIn0.Yrkp8-SSLDqHTRCKzXd8DA',
            mapStyle: 'https://free.tilehosting.com/styles/positron/style.json?key=2OrAmqAgbK4HwBOq6vWN',
            container: 'TarlaMapView',
            latitude: 38,
            longitude: 35.8,
            zoom: 5.9,
            maxZoom: 16,
            pitch: 45,
            onViewStateChange: onViewStateChange,
            layers: currentLayers
        });

        function onViewStateChange({ viewState }) {
            // decide which layers you would like to display
            tarimDeck.setProps({ currentLayers });
        }

Please note that I change the array "currentLayers" somewhere below in my code where a city is chosen on my drop-down list. Indeed it shows that city layers are not the current layers props of the deck, but district layers is set as the current layer props. But as I said above (I've been repeating myself too much) the view doesn't show the new layers as expected.

tarimDeck.setProps(newLayers);
Should be
tarimDeck.setProps({layers: newLayers});

@Pessimistress
I don't know why I assumed the setProps function would understand what props is intended to be updated.
It's one of those situations where you are a bit embarrassed that the mistake is that simple, but you are also glad that you can fix it easily as well.
Thanks for the help, this seems to solve my problem.


Add new column last_id to the table volumes

Description
In ACS Once a volume is migrated, it duplicates its row in the database and labels the previous one as removed; however, there is no reference to the deleted row, making it so the operator is unable to track the previous volume effectively. This PR aims to change this by adding a new column to the table volumes called last_id.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
This PR was tested by live migrating VM with storage and also by migrating a volume with the VM turned off; in both cases, the new column was populated accordingly.

@blueorangutan package

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 11265

@blueorangutan package

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 11356

@blueorangutan test

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-11680)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54228 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9759-t11680-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_provision_certificate
Error
120.43
test_certauthority_root.py

test_02_create_iso_with_checksum_sha256
Error
66.64
test_iso.py

@blueorangutan package

@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

this will bring troubles for users who use 4.20.0, because 4.20.0 does not have the db changes

ok, so we need to revert this, or add a fix in 4.19.2 to 4.20.1. thanks for the headsup @weizhouapache

ok, so we need to revert this, or add a fix in 4.19.2 to 4.20.1. thanks for the headsup @weizhouapache

maybe add to both schema-41910to41920.sql (4.19.1 to 4.19.2 upgrade) and schema-42000to42010.sql (for 4.20.0 to 4.20.1 upgrade)
anyway, schema-41900to41910.sql is not the right place to add SQL changes as <IP_ADDRESS> has been released.


CMS Mobile UI is broken

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!

I can’t see post name in the list of post.
The burger menu seems off.
Post title are too long for the UI
Would be better to have a page title in a "header/NavBar" with a left square burger menu.
Padding between screens aren't similar. (Should not be too big on mobile 20px max)

Here some images:

Reproduction
Localhost
Steps to reproduce
Simply use a mobile.
i used a iPhone 15 Pro max to get these results
System Info
Tinacms: 1.6.0
Cli: 1.5.42

Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug.

Few things here.
In mobile at least: (Some could fit easy on desktop too)

Should have a "NavBar" with the title of the page in the center and a square burger menu to the left. (A bit like when the menu is open)
The Post List should be more like bloc with list of info one under each other (Or marbe simply display the title?)
The search not configure should take full width.
When editing a post, the breadcrumb should be under a "NavBar" (1.) and if too long end with a ....
When editing a post, the change status should be in the right of the "NavBar" (1.)

By fixing that (Header and breadcrumb), it should fix the content under that appear to be too wide.

I would like to add that it's not possible to add images on mobile at all. Thanks for taking care of all the mobile issues.

@severinkilchhofer Could you please provide more information on this (e.g., screenshots, where this is occurring) or raise an issue for it (if there isn't already one)? Thanks

@Jord-Gui Thanks for reaching out. Sure, here is a screenshot and a short screencast of the issue:
After the image upload I want to insert the image but the drawer is not responsive and it's not possible to scroll and tap on the button at the bottom.

https://github.com/tinacms/tinacms/assets/26141288/d832c338-3ad3-430f-9f0d-a147f5a17f3b

@severinkilchhofer There was a fix for this released yesterday. See PR https://github.com/tinacms/tinacms/pull/4607 for details.
If you update your tinacms to v1.6.5 and @tinacms/cli to v1.5.47, this should be resolved. Let me know if there are any more problems.

Looks like @Jord-Gui has already broken this down into individual issues, will circle back to this PBI when they are done.

@Jord-Gui Thanks for your quick response. I can now select the image, which is great! However, the UX for the drawer could still use some improvement. Nonetheless, it works for now, and I'm truly grateful for that!

Hi @t1gu1,
We have resolved the mobile UI issue in our latest patch.
If you update your packages to @tinacms/cli: 1.5.48 and tinacms: 1.6.6, these issues should be fixed.


How to learn how to code

What is your question?
Ok so, i want to ask how did y´all learn how to code in haxe, and basically modify the psych engine without viewing any tutorials or finding any tutorials. How did y´all learn it ?

Actually, the question is quite simple, first try to memorize the functions and classes and their uses. The second thing you have to do is code and practice it yourself continuously
That will make it easier for you to memorize functions and classes and how to write correct code that at least works
Hope it helps you a little


fix cargo run error

This resolves issue https://github.com/apache/datafusion-sqlparser-rs/issues/1484

This one is a duplicate of another PR https://github.com/apache/datafusion-sqlparser-rs/pull/1483.


build project

could u give instruction how to build this project?
i have a problem when i build this project: atal error: opencv2/cudaarithm.hpp: No such file or directory
9 | #include <opencv2/cudaarithm.hpp>

@Gambler19 This error can be caused by one of the following reasons,

First of all check the cudaarithm.hpp file location. It may be moved to some different folder. My suggestion is locate command if you are in a linux environment. Use locate cudaarithm.hpp and check the result.
If you can't find the header file (this means previous command returns empty response): Make sure OpenCV compiled with CUDA backend. Check your CUDA and OpenCV installation. If you install OpenCV from pre-built binaries they are not supporting CUDA backend, so you must compile OpenCV in your computer with CUDA backend. First install CUDA in your computer than make sure during CMake configure of OpenCV, you enabled CUDA backend with -DWITH_CUDA=ON. You should see a line in your terminal like "  NVIDIA CUDA: YES (ver <version string>, <cuda features>). If you don't know how to compile it CUDA backend I suggest checking some online tutorials because of sometimes OpenCV can be a problematic depending on your module selections (especially with contrib).
If you can find the header file and if you are sure, you compiled your OpenCV with CUDA backend, check your installation folder. This line, https://github.com/egecetin/VideoStabilization/blob/4918a9d901d6f53898908680dd58deebadb76bf7/CMakeLists.txt#L6 tries to find your OpenCV installation but if somehow CMake can't find your OpenCV config in your system you should update your include directories. For example, your installation might install your header files in /some/dir/opencvX/. Make sure /some/dir/opencvX/ is in your system search path.

I can try to help you if you have more questions!

Thaks to try help me. I will follow your instructions to build project and after that i report your about my success.

@Gambler19 If you mean video is not completely stabilized with

but video is not stabilized

Since this is a software based solution for the stabilization, 100% stabilizing of video is not possible. If I remember right by using its default parameters it fails for,

Videos with fast and big displacements: it uses average for decide the displacement vectors. So for fast displacements the average value can't catch up with the real displacement. It is normal the see still a shaking video but with less shaking when compared with the original video.
 For detecting displacement vectors it relies on point tracking algorithm. Since point tracking algorithm requires points (you can call it feature points, corner points, good points etc most of them leads similar pixels mostly) when one of the objects occupies lots of pixels most of these tracking points are calculated from the object (because you can't get enough data from background). In this situation even when there is no shaking in the camera side, when this big object moves to a direction there will be a average displacement vector and the algorithm fails to catch up with camera motions. Also it will try to track the object so there will be more shaking more than normal in the stabilized video.

I suggest using some stock videos (from internet/youtube) especially recorded for stabilization demonstration as a first step if you are using your custom video. If the video is more stabilized than the original you can start to adjust variables,

HISTORY_LIMIT https://github.com/egecetin/VideoStabilization/blob/4918a9d901d6f53898908680dd58deebadb76bf7/src/process.cpp#L117

SMOOTHING_RADIUS https://github.com/egecetin/VideoStabilization/blob/4918a9d901d6f53898908680dd58deebadb76bf7/src/process.cpp#L122

Feature detector options (check OpenCV documentation for input variables, maybe even you can replace with another algorithm if you like) https://github.com/egecetin/VideoStabilization/blob/4918a9d901d6f53898908680dd58deebadb76bf7/src/process.cpp#L44

Tracking options (check OpenCV documentation for input variables, maybe even you can replace with another algorithm if you like) https://github.com/egecetin/VideoStabilization/blob/4918a9d901d6f53898908680dd58deebadb76bf7/src/process.cpp#L52

I'm closing the issue for now. You can reopen any time you need it.


Fix typo

github -> GitHub

@changeworld : Thanks for your contribution! The author, @codemillmatt, has been notified to review your proposed change.

#sign-off

@JasonWHowell: I'm sorry - only the author of this article, @codemillmatt, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


Update to simplifile 2.0.1

Please could you update chrobot to work with simplifile 2.0.0 or greater. This seems like such a cool tool and I'd love to use it to test the package I'm working on, but it conflicts with wisp and birdie over simplifile. Thanks! 👍

Thanks for the heads-up, I'll work on updating it!

@snailcreature I've upgraded gleam & simplifile in 2.25, please let me know if there is still a dependency issue with wisp

Thank you so much, and I'll let you know 👍


[ BUG ] Build Fail even after setting compileSdkVersion to 30

🐛 Build Fail

Note: /home/frosty/.pub-cache/hosted/pub.dartlang.org/geocoding-2.0.1/android/src/main/java/com/baseflow/geocoding/GeocodingPlugin.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
/home/frosty/.pub-cache/hosted/pub.dartlang.org/geolocator_android-2.1.0/android/src/main/java/com/baseflow/geolocator/location/LocationMapper.java:29: error: cannot find symbol
    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
                                                    ^
  symbol:   variable S
  location: class VERSION_CODES
/home/frosty/.pub-cache/hosted/pub.dartlang.org/geolocator_android-2.1.0/android/src/main/java/com/baseflow/geolocator/location/LocationMapper.java:30: error: cannot find symbol
      position.put("is_mocked", location.isMock());
                                        ^
  symbol:   method isMock()
  location: variable location of type Location
2 errors

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':geolocator_android:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Configuration
Version:
Flutter 2.5.2 • channel stable
geolocator: ^7.7.0
geocoding: ^2.0.1
Platform:

[ ] :iphone: iOS (unsure)
[x] :robot: Android 11

Possible Fix
The following change in build.gradle builds the application
compileSdkVersion:31
targetSdkVersion:31

Although the following code seems to build the application placemarkFromCoordinates method does not work for my system, even for known coordinates it returns
PlatformException(NOT_FOUND, No address information found for supplied coordinates (latitude: 52.216516, longitude: 6.945971)., null, null)

Documents needs to be updated. VERSION_CODES.S need sdk 31. Try set compileSdkVersion 31 and compile again.

Documents needs to be updated. VERSION_CODES.S need sdk 31. Try set compileSdkVersion 31 and compile again.

This along with targetSdkVersion:31 compiles but placemarkFromCoordinates method does not work

Fixed in version 2.0.3


Added floating option to SnackBar

Description
This PR enables the user to change the SnackBar to appear as floating.
Before:

After:

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes tests for all changed/updated/fixed behaviors (See Test Coverage).
[ ] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (Please read Handling breaking changes).
[x] No, this is not a breaking change.

I signed it!

Mh, I don't know why but online editor or VSCode keeps putting a blank space at the end of the file causing it to fail the checks.

It will always fail because GitHub keeps adding a whitespace at the end of the file and the checks fails.


[plugin-images] addVanillaLazy:false will result in no image are showing

As the current state of the plugin, whenever we set addVanillaLazy: false no image will be shown in chrome as it will use the fallback img tag whereas the current output of plugin images still using the placeholder for the img tag with class lazy blur-up (which added at line 38 in utils/ImageStore.js as shown below. This is because by default browser thinks the base64 image is 10x4 pixel (which is the size the plugin resized it to). Not sure how the vanillaylazyload bypass this behavior, but without the script, it will show nothing.

        <picture class="">
            <source type="image/webp" data-srcset="/images/my-image-ejs-1000.webp<EMAIL_ADDRESS>2x">
            <source type="image/png" data-srcset="/images/my-image-ejs-1000.png<EMAIL_ADDRESS>2x">
            <img src="data:image/jpeg;base64,/9j/2wBDABALDA4MChAODQ4SERATGCgaGBYWGDEjJR0oOjM9PDkzODdASFxOQERXRTc4UG1RV19iZ2hnPk1xeXBkeFxlZ2P/2wBDARESEhgVGC8aGi9jQjhCY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2NjY2P/wgARCAAEAAoDASIAAhEBAxEB/8QAFQABAQAAAAAAAAAAAAAAAAAAAAX/xAAUAQEAAAAAAAAAAAAAAAAAAAAB/9oADAMBAAIQAxAAAAGIE//EABQQAQAAAAAAAAAAAAAAAAAAABD/2gAIAQEAAQUCP//EABQRAQAAAAAAAAAAAAAAAAAAAAD/2gAIAQMBAT8Bf//EABQRAQAAAAAAAAAAAAAAAAAAAAD/2gAIAQIBAT8Bf//EABQQAQAAAAAAAAAAAAAAAAAAABD/2gAIAQEABj8CP//EABUQAQEAAAAAAAAAAAAAAAAAABAR/9oACAEBAAE/Iaf/2gAMAwEAAgADAAAAEAf/xAAUEQEAAAAAAAAAAAAAAAAAAAAA/9oACAEDAQE/EH//xAAUEQEAAAAAAAAAAAAAAAAAAAAA/9oACAECAQE/EH//xAAWEAEBAQAAAAAAAAAAAAAAAAABEQD/2gAIAQEAAT8QUhY67//Z" alt="my-image" class="lazy blur-up">
        </picture>

With the addVanillaLazy: false,  the img tag should contain the original image or optimized version of the original image instead of the blurred placeholder as below:
<picture>
  <source type="image/webp" data-srcset="/images/my-image-ejs-1000.webp<EMAIL_ADDRESS>2x">
     <source type="image/png" data-srcset="/images/my-image-ejs-1000.png<EMAIL_ADDRESS>2x">

</picture>

Additional info
elderjs version: 1.4.13
plugin version: 1.0.0
Browser: Chrome version 90
OS: MacOS Mojave
References:

https://stackoverflow.com/questions/39236087/html5-picture-element-does-not-seem-to-be-supported-by-chrome-52-srcset-not-wor
https://www.smashingmagazine.com/2014/05/responsive-images-done-right-guide-picture-srcset/
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture

closes as it already resolves in https://github.com/Elderjs/plugins/commit/0397c80ff3df156495395568faad1a983311dd58

closes as it already resolves in https://github.com/Elderjs/plugins/commit/0397c80ff3df156495395568faad1a983311dd58


Default working thread is not on main thread after the app loads.

Trying to modify UI from the viewDidLoad() method caused some exceptions in the UIKIT while running in Visual Studio in debug mode. As soon as I have explicitly made the UI changes using dispatch_asyn(dispatch_get_mainQueue,{
});
The exceptions are no more.
expected behavior is by default in viewDidLoad() method the default thread running should be main thread.

The issue can be seen by running the present BoltsInClasspath app in winobjc-samples and removing the workaround code that he mentions above.


Docs gh OIDC

PR Checklist:
[ ] Describe and explain your intentions for this change
[ ] Setup pre-commit and run the validators (info in README.md)

this was only a test


add workflow to lint pull requests

Configure a Github Actions workflow to lint pull requests to the master branch.
script to lint: npm run lint
workflow should be in .github/workflows

Would you mind if I take this up?

Sure @sprakash57 ! I have assigned you the issue
Looking forward to your contribution 😄


First cut at making file writing async in build mode

I basically want to know if there are any major problems I should address before I start (e.g.) cleaning up the tests and running official perf tests.
Context: An internal partner users project references and this caused file write time (a separate, sequential step in build mode) to drop from 30 seconds to 10 seconds.

Just as easy to revisit closed as open.


Overlay not 100% height of page when page has scroll

Hi.
Not sure if this has been fixed in recent versions (i have "angular2-busy": "^1.0.2", in my packages.json) but I'm finding this problem:
When the page has scroll and an action at the bottom of the page triggers my
<div [ngBusy]="{busy: busy}"></div>
, the spinner and transparent overlay don't occupy all of the page height. It occupies only the part of the page that users see before scrolling down.
Found a fix by changing position: absolute to position: fixed in my busy-loading.sass but the spinner does not stick in the same position during all stages of the loading.
Any tips?

Hi,
I solved by editing the 'busy.css' file:
.ng-busy > dynamiccomponent > * {
position: fixed;     // old: absolute
.ng-busy-backdrop {
position: fixed;     // old: absolute

Adding this css fixed it for me (separate css file, referenced from angular.json, I'd discourage editing library's css file as it will be overwritten each time you reinstall/update it)
.ng-busy-default-spinner, .ng-busy-backdrop {
position: fixed;
}


install.sh: problems with python2 (IDFGH-2718)

install.sh
Installing ESP-IDF tools
Installing tools: xtensa-esp32-elf, esp32ulp-elf, openocd-esp32
Installing<EMAIL_ADDRESS>Downloading xtensa-esp32-elf-gcc8_2_0-esp-2019r2-linux-amd64.tar.gz to /tue/esp/idf_tools_path/dist/xtensa-esp32-elf-gcc8_2_0-esp-2019r2-linux-amd64.tar.gz.tmp
Done
Extracting /tue/esp/idf_tools_path/dist/xtensa-esp32-elf-gcc8_2_0-esp-2019r2-linux-amd64.tar.gz to /tue/esp/idf_tools_path/tools/xtensa-esp32-elf/esp-2019r2-8.2.0
Installing<EMAIL_ADDRESS>Downloading binutils-esp32ulp-linux64-2.28.51-esp32ulp-20180809.tar.gz to /tue/esp/idf_tools_path/dist/binutils-esp32ulp-linux64-2.28.51-esp32ulp-20180809.tar.gz.tmp
Done
Extracting /tue/esp/idf_tools_path/dist/binutils-esp32ulp-linux64-2.28.51-esp32ulp-20180809.tar.gz to /tue/esp/idf_tools_path/tools/esp32ulp-elf/<IP_ADDRESS>70517
Installing<EMAIL_ADDRESS>Downloading openocd-esp32-linux64-0.10.0-esp32-20190313.tar.gz to /tue/esp/idf_tools_path/dist/openocd-esp32-linux64-0.10.0-esp32-20190313.tar.gz.tmp
Done
Extracting /tue/esp/idf_tools_path/dist/openocd-esp32-linux64-0.10.0-esp32-20190313.tar.gz to /tue/esp/idf_tools_path/tools/openocd-esp32/v0.10.0-esp32-20190313
Installing Python environment and packages
Creating a new Python environment in /tue/esp/idf_tools_path/python_env/idf4.0_py2.7_env
usage: virtualenv [--version] [--with-traceback] [-v | -q] [--discovery {builtin}] [-p py] [--creator {builtin,cpython2-posix}] [--seeder {app-data,pip}] [--no-seed] [--activators comma_separated_list] [--clear] [--system-site-packages]
                  [--symlinks | --copies] [--download | --no-download] [--extra-search-dir d [d ...]] [--pip version] [--setuptools version] [--wheel version] [--no-pip] [--no-setuptools] [--no-wheel] [--clear-app-data] [--symlink-app-data]
                  [--prompt prompt] [-h]
                  dest
virtualenv: error: unrecognized arguments: --no-site-packages
Traceback (most recent call last):
  File "/tue/esp/esp-idf/tools/idf_tools.py", line 1372, in <module>
    main(sys.argv[1:])
  File "/tue/esp/esp-idf/tools/idf_tools.py", line 1368, in main
    action_func(args)
  File "/tue/esp/esp-idf/tools/idf_tools.py", line 1184, in action_install_python_env
    stdout=sys.stdout, stderr=sys.stderr)
  File "/usr/lib/python2.7/subprocess.py", line 190, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/usr/bin/python', '-m', 'virtualenv', '--no-site-packages', '/tue/esp/idf_tools_path/python_env/idf4.0_py2.7_env']' returned non-zero exit status 2

Reason: python --version =2.7.17
I'd recommend to run python scripts in install.sh via "python3".

Hi @szutenberg, the cause of this issue is the deprecated --no-site-packages argument which idf_tools.py was passing to virtualenv. This happens when virtualenv package installed is later than v20.0.0. In your specific case, switching to python3 might be solving the issue if the virtualenv package installed in py3 environment is of an older version. The issue was first raised in https://github.com/espressif/esp-idf/issues/4744 and is now fixed in master and most release branches. In release/v4.0 branch which you are using, it was fixed in commit https://github.com/espressif/esp-idf/commit/8cb3cc515477e777144acb3b58f5156c4ad69124. Please update to the latest release/v4.0 branch and the issue should be fixed. The fix will be part of the next bugfix release (v4.0.1).

I have tried the instller, selected the v4 idf, upgrade to python3.7 and upgrade git.
Yet still this gives the "--no-site-packages argument" fault.
Not sure that this is really fixed"
C:\Users\Anne\esp\esp-idf>install
Installing ESP-IDF tools
Installing tools: xtensa-esp32-elf, esp32ulp-elf, cmake, openocd-esp32, mconf, ninja, idf-exe, ccache
Installing<EMAIL_ADDRESS>file xtensa-esp32-elf-gcc8_2_0-esp-2019r2-win32.zip is already downloaded
Extracting C:\Users\Anne\dist\xtensa-esp32-elf-gcc8_2_0-esp-2019r2-win32.zip to C:\Users\Anne\tools\xtensa-esp32-elf\esp-2019r2-8.2.0
Installing<EMAIL_ADDRESS>file binutils-esp32ulp-win32-2.28.51-esp32ulp-20180809.zip is already downloaded
Extracting C:\Users\Anne\dist\binutils-esp32ulp-win32-2.28.51-esp32ulp-20180809.zip to C:\Users\Anne\tools\esp32ulp-elf\<IP_ADDRESS>70517
Installing<EMAIL_ADDRESS>file cmake-3.13.4-win64-x64.zip is already downloaded
Extracting C:\Users\Anne\dist\cmake-3.13.4-win64-x64.zip to C:\Users\Anne\tools\cmake\3.13.4
Installing<EMAIL_ADDRESS>file openocd-esp32-win32-0.10.0-esp32-20190313.zip is already downloaded
Extracting C:\Users\Anne\dist\openocd-esp32-win32-0.10.0-esp32-20190313.zip to C:\Users\Anne\tools\openocd-esp32\v0.10.0-esp32-20190313
Installing<EMAIL_ADDRESS>file mconf-v<IP_ADDRESS>-idf-20190628-win32.zip is already downloaded
Extracting C:\Users\Anne\dist\mconf-v<IP_ADDRESS>-idf-20190628-win32.zip to C:\Users\Anne\tools\mconf\v<IP_ADDRESS>-idf-20190628
Installing<EMAIL_ADDRESS>file ninja-1.9.0-win64.zip is already downloaded
Extracting C:\Users\Anne\dist\ninja-1.9.0-win64.zip to C:\Users\Anne\tools\ninja\1.9.0
Installing<EMAIL_ADDRESS>file idf-exe-v1.0.1.zip is already downloaded
Extracting C:\Users\Anne\dist\idf-exe-v1.0.1.zip to C:\Users\Anne\tools\idf-exe\1.0.1
Installing<EMAIL_ADDRESS>file ccache-3.7-w64.zip is already downloaded
Extracting C:\Users\Anne\dist\ccache-3.7-w64.zip to C:\Users\Anne\tools\ccache\3.7
Setting up Python environment
Creating a new Python environment in C:\Users\Anne\python_env\idf4.0_py3.7_env
usage: virtualenv [--version] [--with-traceback] [-v | -q] [--app-data APP_DATA] [--clear-app-data] [--discovery {builtin}] [-p py] [--creator {builtin,cpython3-win,venv}] [--seeder {app-data,pip}] [--no-seed] [--activators comma_sep_list]
                  [--clear] [--system-site-packages] [--copies] [--download | --no-download] [--extra-search-dir d [d ...]] [--pip version] [--setuptools version] [--wheel version] [--no-pip] [--no-setuptools] [--no-wheel]
                  [--symlink-app-data] [--prompt prompt] [-h]
                  dest
virtualenv: error: unrecognized arguments: --no-site-packages
Traceback (most recent call last):
  File "C:\Users\Anne\esp\esp-idf\tools\idf_tools.py", line 1372, in <module>
    main(sys.argv[1:])
  File "C:\Users\Anne\esp\esp-idf\tools\idf_tools.py", line 1368, in main
    action_func(args)
  File "C:\Users\Anne\esp\esp-idf\tools\idf_tools.py", line 1184, in action_install_python_env
    stdout=sys.stdout, stderr=sys.stderr)
  File "C:\Users\Anne\AppData\Local\Programs\Python\Python37\lib\subprocess.py", line 347, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['C:\\Users\\Anne\\AppData\\Local\\Programs\\Python\\Python37\\python.exe', '-m', 'virtualenv', '--no-site-packages', 'C:\\Users\\Anne\\python_env\\idf4.0_py3.7_env']' returned non-zero exit status 2.

C:\Users\Anne\esp\esp-idf>python -V
Python 3.7.3

@ozarchie could you please check IDF version git describe --tags and post it here? Perhaps your branch is older than commit 8cb3cc5?

Hi Ivan,
I downloaded esp-idf-tools-setup-2.3.exe and installed from that exe.
I hope this is what you are looking for:
C:\Users\Anne\esp\esp-idf>git describe --tags
v4.0
C:\Users\Anne\esp\esp-idf
(I am not sure which git repository you are asking about but assumed it was the esp_idf.)
I finally stepped through the manual install, and deleted the "--no-site-packages" argument in the script.
It installed and is working now.
Cheers
John

Right, looks like you are using v4.0 tagged version, which has this bug. Removing the --no-site-packages argument manually, like you did, or pulling the latest release/v4.0 branch, are both valid solutions. The next bugfix release, v4.0.1, will include the fix as well.

Thanks were having this -no-site-packages issue as well on my ubuntu 18, is there any pitfall if I go to release/v4.0 branch ? are the codes there committed daily that could potentially break my code?

@manoj153 The tradeoffs associated with tags/branches are explained here: https://docs.espressif.com/projects/esp-idf/en/latest/esp32/versions.html#which-version-should-i-start-with. In short, yes, there is some risk, but don't expect any major changes on a release branch. If you don't feel confident switching to the release branch, you can also cherry-pick the fix on top of v4.0 tag (git cherry-pick 8cb3cc5).

Relieved to find this link on the issue. Spent almost a week trying to debug the issue.
Thank you guys!
Removing the --no-site-packages argument manually worked for me! Below is the log at the end of the installation.
...
...
Adding ESP-IDF tools to PATH...
C:\Users\Dipen Shah.espressif\tools\xtensa-esp32-elf\esp-2019r2-8.2.0\xtensa-esp32-elf\bin
C:\Users\Dipen Shah.espressif\tools\esp32ulp-elf\<IP_ADDRESS>70517\esp32ulp-elf-binutils\bin
C:\Users\Dipen Shah.espressif\tools\cmake\3.13.4\bin
C:\Users\Dipen Shah.espressif\tools\openocd-esp32\v0.10.0-esp32-20190313\openocd-esp32\bin
C:\Users\Dipen Shah.espressif\tools\mconf\v<IP_ADDRESS>-idf-20190628
C:\Users\Dipen Shah.espressif\tools\ninja\1.9.0
C:\Users\Dipen Shah.espressif\tools\idf-exe\1.0.1
C:\Users\Dipen Shah.espressif\tools\ccache\3.7
C:\Users\Dipen Shah.espressif\python_env\idf4.0_py2.7_env\Scripts
G:\gitHub\gitHubLibraries\espressif\esp-idf\tools
Checking if Python packages are up to date...
Python requirements from G:\gitHub\gitHubLibraries\espressif\esp-idf\requirements.txt are satisfied.
Done! You can now compile ESP-IDF projects.
Go to the project directory and run:
idf.py build

@manoj153 The tradeoffs associated with tags/branches are explained here: https://docs.espressif.com/projects/esp-idf/en/latest/esp32/versions.html#which-version-should-i-start-with. In short, yes, there is some risk, but don't expect any major changes on a release branch. If you don't feel confident switching to the release branch, you can also cherry-pick the fix on top of v4.0 tag (git cherry-pick 8cb3cc5).

Thanks, that was informative


Use application/strategic-merge-patch+json

The headers and documentation claim that we're doing a strategic merge, but we're using merge-patch headers..

This would be a breaking change, can you elaborate on your usecase? I want to prevent releasing it and breaking existing apps.

No reaction. Closing.


pip install fails

The following command:
pip install git+https://github.com/aaugustin/websockets.git

with the following logged by pip:
------------------------------------------------------------
/home/amirouche/.virtualenvs/suprm3/bin/pip run on Thu Oct 24 01:24:34 2013
Downloading/unpacking git+https://github.com/aaugustin/websockets.git

  Cloning https://github.com/aaugustin/websockets.git to /tmp/pip-tgmzlg-build

  Found command 'git' at '/usr/bin/git'
  Running command /usr/bin/git clone -q https://github.com/aaugustin/websockets.git /tmp/pip-tgmzlg-build
  Running setup.py egg_info for package from git+https://github.com/aaugustin/websockets.git

    Traceback (most recent call last):

      File "<string>", line 16, in <module>

      File "/tmp/pip-tgmzlg-build/setup.py", line 11, in <module>

        with open(os.path.join(root, 'README')) as f:

    FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-tgmzlg-build/README'

    Complete output from command python setup.py egg_info:

    Traceback (most recent call last):

  File "<string>", line 16, in <module>

  File "/tmp/pip-tgmzlg-build/setup.py", line 11, in <module>

    with open(os.path.join(root, 'README')) as f:

FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-tgmzlg-build/README'

----------------------------------------

Command python setup.py egg_info failed with error code 1 in /tmp/pip-tgmzlg-build

Exception information:
Traceback (most recent call last):
  File "/home/amirouche/.virtualenvs/suprm3/lib/python3.3/site-packages/pip-1.3.1-py3.3.egg/pip/basecommand.py", line 139, in main
    status = self.run(options, args)
  File "/home/amirouche/.virtualenvs/suprm3/lib/python3.3/site-packages/pip-1.3.1-py3.3.egg/pip/commands/install.py", line 266, in run
    requirement_set.prepare_files(finder, force_root_egg_info=self.bundle, bundle=self.bundle)
  File "/home/amirouche/.virtualenvs/suprm3/lib/python3.3/site-packages/pip-1.3.1-py3.3.egg/pip/req.py", line 1057, in prepare_files
    req_to_install.run_egg_info()
  File "/home/amirouche/.virtualenvs/suprm3/lib/python3.3/site-packages/pip-1.3.1-py3.3.egg/pip/req.py", line 236, in run_egg_info
    command_desc='python setup.py egg_info')
  File "/home/amirouche/.virtualenvs/suprm3/lib/python3.3/site-packages/pip-1.3.1-py3.3.egg/pip/util.py", line 662, in call_subprocess
    % (command_desc, proc.returncode, cwd))
pip.exceptions.InstallationError: Command python setup.py egg_info failed with error code 1 in /tmp/pip-tgmzlg-build

websockets is a Python3-only module, Lower versions of python will not allows successful installation


fix vscode tasks.json with correct build path

Codecov Report
Patch and project coverage have no change.

Comparison is base (6fc1817) 19.22% compared to head (acf482a) 19.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   19.22%   19.22%
=======================================
  Files          57       57
  Lines        6793     6793
=======================================
  Hits         1306     1306
  Misses       5487     5487

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: show proposal start and end date in proposal editor

Summary
Show the expected proposal start and end date in the proposal creation page
Closes: #71
How to test

Go to the proposal creation page
It should display the expected proposal start and end date like the screenshot

These date should depends on your space settings. One thing to note is that final time will not be exactly the same, as the start and end date are set only on form submission.
UI/Design is not final, and will do the job, until designer come up with something better

Another design variant would be to have a sidebar, and display the voting period using the Timeline component

@wa0x6e @bonustrack this doesn't match the designs that were proposed (I don't think we have final designs still), what do we want to do with this PR? merge it as-is or wait for designs?

We dont have final design, better to wait for it and not merge this

Updated to match the figma

I don't see this line in the design

I don't see this line in the design

fixed

Also added UI for small screen


Invalid scancode 310

glfw version: 3.3.6
os: windows
error: 65540
description: Invalid scancode 310
I get this error when I press right shift.
I don't know if it's a glfw problem or a keyboard problem.

This seems like a bug in GLFW. Thank you for reporting this!
What keyboard layout do you have set? Do you get the error when calling glfwGetKeyName?

What keyboard layout do you have set? Do you get the error when calling glfwGetKeyName?

My keyboard is the usual qwerty layout.
This error message I got in the GLFWErrorCallback function.

@v-dao Which language do you have the keyboard set to? What version of Windows are you running?

@elmindreda Windows 10 professional 21H2.
I use "Chinese (Simplified, China) - Microsoft Pinyin" for my keyboard.

中文(简体，中国)

This error does not occur when I switch the keyboard to "English (United States)".

I got a similar error (ERROR GLFW error #65540: Invalid scancode). I solved it by changing the keyboard language to ENG US.


Security: do version checks first, then send a verack response

Motivation
As a general rule, Zebra should do local checks first, then send messages to the peer.
Review
This is a routine security fix. Anyone can review.
Related Issues
This fix is based on #2120. GitHub will automatically rebase it to main once #2120 merges.

Marking as draft until #2120 merges


[BEAM-12419] Add Timeout and WaitForReady support in java gRPC calls

Add JobServerTimeout option that defaults to 60s to all job server requests (with exception to the ones that are expected to last long or hang) to be on Par with python BEAM-7933
Add WaitForReady for ExternalEnvironment

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[x] Update CHANGES.md with noteworthy changes.
[x] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Let me know if you think we should add timeout in external_payload as well

@ibzib Could you help review this PR?

Run Java PreCommit

Run Java_Examples_Dataflow PreCommit

Run Java PreCommit

Run Java PreCommit

@ibzib Could you help take another pass?

Run Java Flink PortableValidatesRunner Batch

Looks like this change broke the portable spark runner: https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/4428/
Are you aware of the breakage? Can we roll this back?

Looks like this change broke the portable spark runner: https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/4428/
Are you aware of the breakage? Can we roll this back?

Thanks for bringing this up, let me take a look if we can fix them soon or we can roll it back.

@apilloud Found the RC and fixed in https://github.com/apache/beam/pull/14995, could you help take a look ?


We have a problem!

Why images are not deleted?
I use the latest version of the project.
P.S.: function onFilesRemoveCallback in upload.php does not work

@php11i5,I know about this issue when you are deleting all images after upload. I will fix it as soon as possible. Thanks

Ok, tnx

fixed. Please update it.
Sorry for this issue


Component not rendering

Hello!
I can see that the component is loaded and have recieved my config, using the vue devtools for Chrome.
But for some reason it just doesn't render.
import Vue from 'vue';
import VueMce from 'vue-mce';

Vue.use(VueMce);

<vue-mce name="content" :initial-value="card.content" :config="mceconfig" v-model="card.content" />
I'm using TypeScript and Webpack... And I'm really new to both of them, maybe there is some kind of standard configuration I have to do?

Hi,
Have you included tinymce in your project? Is it available via window.tinymce?

the same

when as a plugin
window.tinymce
is undefined

got this in handleError
err = Error: TinyMce wasn't found at VueComponent.mounted (webpack-internal:///725:1:7106)

Please note that vue-mce doesn't provide any tinymce build by default. You must include tinymce by yourself. If it is, make sure that tinymce is loaded before your script

I see, I had not included TinyMCE. I ran npm install to get tinymce but they miss a typedeclaration so I can't load it. But I guees you don't do support for TinyMCE!
Thanks alot for the answer!

You can include tinymce via script tag
<script src="https://cloud.tinymce.com/stable/tinymce.min.js"></script>

Oh okay, that worked! Thanks alot!


Dialect-aware variant of Tabler

Describe the feature
In some contexts it would be very helpful to have a variant of the Tabler interface that models can implement that is dialect aware -- i.e. it can return a different value depending on the dialect in use.
Motivation
When building an app that uses e.g. PostgreSQL in production but SQLite in testing, models that need their name to be schema-qualified when talking to PostgreSQL can't use that same qualified name when talking to SQLite.
Related Issues
Haven't found any yet

A proposed sketch:
type DialectTabler interface {
  TableName(Dialector) string
}

in schema.Parse, it would then check for this interface first before falling back on Tabler.
A couple potential difficulties with this I see:

Passing a Dialector instance into schema.Parse everywhere might be a bit of a yak shave
A naive attempt at implementing this might introduce a circular dependency between the top level gorm package and the schema package. This might require moving the definition of the Dialector type, or something else creative

@jinzhu how am I supposed to provide a playground PR for a feature request?

I would suggest implement the Naming strategy based on the dialector when initialize gorm.DB

That implies that the Naming strategy has to know info about all the models and their behavior, which produces pretty unclean code. And since the naming strategy gets a candidate table name passed to it, not a model instance, it can't pull information from e.g. custom interfaces the models might implement.

that's exactly we want to avoid, I received lots of misusage reports about the TableName method in v1, maybe this is helpful for you. https://gorm.io/docs/v2_release_note.html#Table-Name


Add tooltip support for textInput.

Can we have support for custom tooltip(something like UIMenuController) for textInput?

@vjeux

For those looking for this check: https://github.com/chirag04/react-native-tooltip


concept-property#inactive

should we add the concept-property#inactive to the deprecated codes?
I am not sure what is best-practice. I have asked HL7
https://jira.hl7.org/browse/FHIR-42956

could add this property to those that are marked with the concept status of deprecated.


changes in dark and light mode

Improvement in Ui
Improved Light mode with attractive visibility

/GSSOC2023

not required


Support trait-only and impl-only attributes

One thing. Maybe the impl_attr/trait_attr can be wrapped in #[ext(impl_attr/trait_attr)] to make it obvious which macro they come from

One thing. Maybe the impl_attr/trait_attr can be wrapped in #[ext(impl_attr/trait_attr)] to make it obvious which macro they come from

Good point. I looked around and your naming style indeed seems more idomatic--see serde attributes for example.
Will make the change.

One thing. Maybe the impl_attr/trait_attr can be wrapped in #[ext(impl_attr/trait_attr)] to make it obvious which macro they come from

Good point. I looked around and your naming style indeed seems more idomatic--see serde attributes for example.
Will make the change.

Updated. But instead of #[ext(impl_attr/trait_attr)] I went with #[ext_attr(impl_only/trait_only)] to clearly distinguish between main #[ext] attribute.


private prediction cleanup

Removed the training notebook and assumed we'd use the model trained with FL.

Looks great @justin1121 ! I have added just two small comments in reviewnb.
Thanks!


DOCS - Docker Cheat Sheet

Related page: https://github.com/app-generator/deploypro-docs/blob/main/docs/60-docker/02-cheatsheet.mdx

TY!

Validated. Closing.


installation fails

Cannot install due to
case-insensitive import collision: "github.com/SeerUK/i3x3/internal/xserver" and "github.com/seeruk/i3x3/internal/xserver"

:(

Aha, apologies - I'll see if I can sort this out quickly later today. I've not been using i3 for a little while now, but it'd be great if this tool works for others still!

Awesome! Lemme know if you need something to be tested!
Abusing a bit purpose of this issue, do you mind if I ask two minor questions about the code?
I wonder about the scenario with two monitors:
a) are all outputs coupled, it is if you move down a workspace it moves down on all monitors?
b) what happens if you move a workspace to a different monitor? Does it add it at the end and add more workspaces?
for a) is there an option to configure it maybe?

So, i3x3 is a pretty opinionated tool - I had something very specific in mind that I wanted and just made it exactly like that. With that in mind:
a) Outputs are not coupled, they're separate (and sadly, there's no way to configure this currently
b) i3x3 controls which workspaces are on certain displays, so if you were to move a workspace to a different monitor, i3x3 would move it back to the one it expects it to be on. This is fleshed out a little more in the README, but it was so I could make it so that it was just some maths used to move workspace - and if a workspace didn't already exist, it would create it and put it on the right display for you, etc.
Sort of sadly I'm using a Mac these days - but I do still have my desktop with Arch on it, I just haven't used it since I got my MacBook.

Thanks for the reply.
Opinionated is fine ; - ). I am now exploring different solutions out there to see how they are built to probably at some point get my own opinionated "gridded workspace" solution.
I do love how i3 is handling windows on single workspace but I much more preferred how KDE was handling multiple workspaces in gridded manner.
But oh man, before giving it more thought I didn't expect that simple subject of moving workspaces around in geometrical context maybe such complicated subjects. I don't mean math but all the design decisions how it should behave with more monitors etc. ; - )
Anyway, looking forward to trying out your solution!

Alright, I've updated those references of SeerUK now to seeruk. Let me know if you have any more issues installing.
One other thing that springs to mind is that I think you might also need dep installed, and I'm not sure the README mentions anything to do with it. Once you've got dep, install the third-party code with:
$ dep ensure -v -vendor-only

From there, as long as you have the GTK libraries on your system, I think the go build should work just like normal.

Thanks @seeruk, installation now succeeded.
I had however to do go install github.com/seeruk/i3x3/cmd/i3x3d additionally.
Something may not be fully right for my though as I do not see any GTK-based overlay GUI when switching workspaces. The switching however seems to work fine ; - ).


Manipulating input image

Hey Rene,
great work, the example scene and ML model works fine! I have not really an issue but more of a question: I'd like to grab the camera image and manipulate it (using openCV), before using it with an ONNX model. However I'm badly stuck at trying to set up the input for the model coming from an Unity Texture2D (getting to the Windows specific Videoframe). Did you by chance try something like that or have some insights how to do that?
Best regards
Stoffel

You might want to inverse that if possible. Unity also accepts a pointer to a native system texture as Texture2D which might be the fastest approach.

Thanks a lot for the quick response! :)
Doing the inverse seems more straight forward, but as I want to feed the result back to the machine learning model, after manipulating it in Unity, I think I need to go from Texture2D to VideoFrame. I need the Texture2D format for my current implementation using OpenCV, which I basically use to do some preprocessing on the images. Or is there any other input option to trigger the Windows specific functions? I have the camera input and preprocessing set up and it works fine already e.g. with Azure Custom Vision, "just" want to try to make it offline available now.
Currently I'm trying to get from Texture2D to VideoFrame by setting up a WriteableBitmap, writing the byte array from the Texture2D to it via its PixelBuffer and then use CopyFromBuffer to populate the SoftwareBitmap of a newly created VideoFrame. Haven't gotten anywhere useable so far, but will keep trying ;)
Do you think this would work in general, or am I missing/misunderstanding something?

Yes, I think this should work. Might just not be very efficient and fast. :)
You might at least be able to circumvent Unity's Texture2D with your OpenCV implementation. I'm sure there's another bitmap copy involved there which is expensive. OpenCV works on a pixel buffer internally so hopefully you can get it directly. Otherwise Texture2D provides the GetPixels method to get the pixel buffer copied. And yes, then you can feed that into a SoftwareBitmap via an IBuffer.
https://docs.microsoft.com/en-us/uwp/api/windows.media.videoframe.createwithsoftwarebitmap#Windows_Media_VideoFrame_CreateWithSoftwareBitmap_Windows_Graphics_Imaging_SoftwareBitmap_
That you can then use to create a VideoFrame:
https://docs.microsoft.com/en-us/uwp/api/windows.graphics.imaging.softwarebitmap
Maybe it also works that you can get a reference to the VideoFrame's internal SoftwareBitmap and avoid creating a new instance but might be you have to use the static method:
public static VideoFrame CreateWithSoftwareBitmap(SoftwareBitmap bitmap)
Also make sure to pay attention to the pixel formats you are dealing with and ensure these match.
Good luck.


Orchest configuration might lose state about requiring a restart if a pod is restarted

Currently, the OrchestGlobalConfig.save() method return value will tell if Orchest needs to be restarted and, if so, which changed settings required the restart. Said logic is based on comparing the flask application settings with the current settings.
If a pod is restarted, for whatever reason, the application will be initialized again, leading to the flask application settings being updated with the content of the OrchestGlobalConfig, then, according to the logic, no restart would be required, but any change affecting entities outside of the flask application (like celery parallelism) won't actually have been applied.
Starting from https://github.com/orchest/orchest/pull/868 each setting will be mapped to a record in the database, which opens up better tracking of what settings have been applied.

Nice catch! I hope this is the only one that slipped through the cracks during the k8s port ;)


Don't require a staged SDK for the Python portable worker.

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.

R: @lostluck

LGTM


Controller Container Fails To Start, Failure is Hidden in Pipeline

I've had issues with the jmeter-controller container failing to start from this pipeline intermittently.
There are no container logs to be pulled during 'TEST: Wait Test Execution', so this step of the pipeline exits immediately with a success code. It may be better to fail at this point in the pipeline by checking if the container is running at the end of SETUP: Run Terraform Apply (target=all).
As far as I can tell this is just an issue with Jmeter's distributed worker reliability, there are no code changes between succeeding & failing runs except for a change in the WORKER_COUNT variable in the jmeter file.

I've seen this same error from the controller container multiple times during this failure, it is failing to connect to the worker[0] instance which always has IP <IP_ADDRESS>
START Running Jmeter on Mon Sep 27 16:31:37 UTC 2021
JVM_ARGS=-Xmn2908m -Xms11632m -Xmx11632m
jmeter args=-n -J server.rmi.ssl.disable=true -t sample.jmx -l results.jtl -e -o dashboard -R <IP_ADDRESS>,<IP_ADDRESS>
Sep 27, 2021 4:31:39 PM java.util.prefs.FileSystemPreferences$1 run
INFO: Created user preferences directory.
Creating summariser <summary>
Created the tree successfully using sample.jmx
Configuring remote engine: <IP_ADDRESS>
Configuring remote engine: <IP_ADDRESS>
Connection refused to host: <IP_ADDRESS>; nested exception is:
	java.net.ConnectException: Connection refused (Connection refused)
Failed to configure <IP_ADDRESS>
Stopping remote engines
Remote engines have been stopped
Error in NonGUIDriver java.lang.RuntimeException: Following remote engines could not be configured:[<IP_ADDRESS>]
END Running Jmeter on Mon Sep 27 16:31:40 UTC 2021

I'm going to bet it's the same problem as issue #78 I just reported.
The reason is actually due to worker container failing to start JMeter, and because worker doesn't have restart_policy specified, ACI tries to restart it couple times before giving up which wipes the console log. I was able to catch it by setting restart_policy to Never like controller, and watching the ACI console as it runs.
I have no idea how to resolve it yet though.

The worker container actually starts with the right IP, but for some reason the heuristics that JMeter employs isn't able to resolve it. You can also verify by skipping cleanup step on failure, and just manually try to restart the worker container.

See #78 for a possible workaround.


Dynamic property is not displayed through the with clause

I need the model to contain a computed property from a query in the database, and I'm able to do this with hooks.
PlayerHook.calcDebit = async (player) => {
  const totalOrder = await player
    .orders()
    .where('status', 'pending')
    .fetch()

  player.debit = await totalOrder.toJSON().length
}

I get this result when I access the model directly:
{
  "id": 3,
  "user_id": 1,
  "name": "Pedro Gomes",
  "type": "quest",
  "created_at": "2018-10-23 00:51:37",
  "updated_at": "2018-10-23 00:51:37",
  "debit": 1
}

I get debit normally.
However, when performing a query on another model with with ...
async show({ params }) {
    const pelada = await Pelada
      .query()
      .where('id', params.id)
      .with('confirmations', (builder) => {
        builder.with('player').orderBy('updated_at', 'desc')
      })
      .fetch()

    return pelada
  }

I get this:
[
  {
    "id": 3,
    "title": "Primeira Pelada",
    "info": "Só pra testar a API mesmo",
    "date": "2018-10-23 18:05:00",
    "seats": 28,
    "location": "R9 Bate Bola",
    "status": "scheduled",
    "period_id": 1,
    "created_at": "2018-10-23 00:21:42",
    "updated_at": "2018-10-23 00:21:42",
    "confirmations": [
      {
        "id": 4,
        "player_id": 3,
        "pelada_id": 3,
        "created_at": "2018-10-23 00:51:51",
        "updated_at": "2018-10-23 00:51:51",
        "player": {
          "id": 3,
          "user_id": 1,
          "name": "Pedro Gomes",
          "type": "quest",
          "created_at": "2018-10-23 00:51:37",
          "updated_at": "2018-10-23 00:51:37"
        }
      },
      ...
    ]
  }
]

Note that in player, inside confirmations, I do not have the debit property.
Can we consider this a bug? Do I need a hook also in related models? Or am I letting something go?

You do not have the debit since you are not setting it anywhere after making the 2nd query.

What does it suggest for me to have debit in any scenario?

You have shared 2 code snippets.
Number 1
PlayerHook.calcDebit = async (player) => {
  const totalOrder = await player
    .orders()
    .where('status', 'pending')
    .fetch()

  player.debit = await totalOrder.toJSON().length
}

Number 2
async show({ params }) {
    const pelada = await Pelada
      .query()
      .where('id', params.id)
      .with('confirmations', (builder) => {
        builder.with('player').orderBy('updated_at', 'desc')
      })
      .fetch()

    return pelada
  }

As per you, the Number 1 has a key/value pair called debit and Number 2 doesn't.
By looking at the code, it is clear that you are manually adding the debit key in first example and doing it in 2nd example

Closing since no response from the issue reporter and not actionable as well


Modified and cleaned up code for RISCV

Hi,
I briefly saw you added some verilator support. can you also please add brief details what is being cleaned up.
I suppose it can be run on opensource tools now.
Thanks!


add support for Rock64

added a choice in build_sdcard.sh for aarch64 version of bitcoin for the rock64
added rock64.md  with specific instructions - DietPi automation works great!
stop xxcleanHDD.sh deleting /mnt/hdd/ssh, because deleting that folder breaks openSSH
main menu HEIGHT=24, CHOICE_HEIGHT=21 to avoid scrolling - uncommented, but could be the default
added display_install.sh (from build.sdcard.sh) for DietPi display experiments
small addition to FAQ
typo fix

Repeating the install the Rock64 seems quite often error ridden. Getting this a lot:
*** TAKES LONGER THEN EXCEPTED ***
1551210194
result()
error(Error: Specified data directory "/home/bitcoin/.bitcoin" does not exist.)
2019-02-26T19:42:43Z Reindexing block file blk01369.dat...
2019-02-26T19:42:47Z LoadExternalBlockFile: Deserialize or I/O error - ReadCompactSize(): size too large: iostream error
2019-02-26T19:42:47Z LoadExternalBlockFile: Deserialize or I/O error - ReadCompactSize(): size too large: iostream error
2019-02-26T19:42:54Z Reindexing block file blk01370.dat...
2019-02-26T19:43:05Z Reindexing block file blk01371.dat...
If you see an error -28 relax, just give it some time.
Waiting 1 minute and then trying again ...

Also there is this sad and concerning tweet regarding the future of the DietPi project: https://twitter.com/DietPi_/status/1098420068998938625

After the first successful build the data on the Rock64 deprecated and could not build again after that. Will close this PR now and reopen when further tests are successful.


Non-Visual Studio PCF development?

Hello,
I'd like to develop custom components using linux. Is Visual Studio a requirement for PCF development? At a cursory glance, it appears that as long as npm and PowerApps CLI are installed on my system I should be good to go.
Thoughts?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3fc8bc19-4e5e-b6f4-34ef-77b004c2afd6
Version Independent ID: 847c467c-0015-1eb9-bdc7-720a40f1cdba
Content: Implementing code components using TypeScript - PowerApps
Content Source: powerapps-docs/developer/component-framework/implementing-controls-using-typescript.md
Service: powerapps
GitHub Login: @Nkrb
Microsoft Alias: nabuthuk

@SeaDude Visual Studio is required for MS Build. You can also install MSBuild as a standalone application, but we recommend you to have Visual Studio installed.

Closing the issue.


Removed AMT and OOB references

Removed AMT and OOB references as AMT supported has been removed from ConfigMgr.

@jason4tw : Thanks for your contribution! The author, @aczechowski, has been notified to review your proposed change.

Thanks @jason4tw , looks good.
#sign-off


Issue/4130 v1tov2 does not specify packages sufficiently strict

Description
Explicitely limit namespace packages to inmanta_plugins
Part of  #4130
Self Check:
Strike through any lines that are not applicable (~~line~~) then check the box

[x] Attached issue to pull request
[x] Changelog entry
- [ ] Type annotations are present
[x] Code is clear and sufficiently documented
[x] No (preventable) type errors (check using make mypy or make mypy-diff)
[x] Sufficient test cases (reproduces the bug/tests the requested feature)
[x] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

Reviewer Checklist:

[ ] Sufficient test cases (reproduces the bug/tests the requested feature)
[ ] Code is clear and sufficiently documented
[ ] Correct, in line with design

Processing this pull request

Processing #4150.


KeyError: key not found: "REDIS_URL"

When trying rake db:setup or any rake db I'm keep getting KeyError: key not found: "REDIS_URL" and "PUSHER APP CLIENT" and go on.
It looks like all <%= ENV[''] %> are not recognized
What am I missing ?
I even tried with doing everything from begining but the same result

Hi @hamid1989
Exec bin/init_config and try again.

Thanks, I dont know how I missed this


Deployment not deletes old files from s3

When deleting an old file like a page the deployment does not delete this file from the static s3 folder.
Therefore an old and deleted page will still be accessible..

same issue here...any workaround?


Add distanceToLine computing

I ported distanceToLine function from android Java to PHP and the function returned normal sounding results but I wasn't able to verify since I don't know Java to do cross test.

Hi @jaska120,
Thanks for your input!
Regards,
Alexander


[VM] Install failed-> "fatal: fetch-pack:  invalid index-pack output"

Install Raspiblitz via Proxmox / Debian 12.7.0 amd64

Fresh Debian install, VM via Proxmox 8.2-2

First install with:
wget https://raw.githubusercontent.com/rootzoll/raspiblitz/dev/build_sdcard.sh

2nd try:
wget https://raw.githubusercontent.com/rootzoll/raspiblitz/v1.11/build_sdcard.sh

Both ends with:
fatal: fetch-pack: invalid index-pack output

Just a guess: Firewall / VPN issue?
I had issues before with VPN and github, not only with raspiblitz. Try installing Raspiblitz without VPN.

Its an issue that happens sometimes and sometimes not - its related to github server response (and internet stability).

#4823 will not solve but try to reduce this happening


Release websocket handshake response if pipeline checks fail

Motivation:
The WebSocketServerHandshaker require that either an HttpRequestDecoder or an HttpServerCodec exist in the pipeline. If they do not, we can't send a websocket handshake response. The handshake response is allocated prior to the pipeline checks. Therefor, if the checks fail, we need to release the response before returning the failed future.
It might be possible to delay the allocation of the response until after the pipeline checks, but doing so breaks assumptions made by numerous tests.
Modification:
If the pipeline checks fail, release the handshake response before returning the failed promise.
Result:
We no longer leak a buffer in the handshake response if the pipeline checks fail.
Fixes #13337

Why are we even creating it before checking for pipeline configuration?

@hyperxpro I do not know, but there were multiple test failures if I just moved it.


Run tests in GitHub Actions

Additionally, add some cleanup within the existing test suite to
handle non-determinism of which tests run in which order.

@freakboy3742 I request your review, and if you like it, please merge!
I intend to continue to pick pieces off of #5 until they're all merged in fairly minimal, self-contained PRs. Every time I make one of these fairly minimal, self-contained PRs, I end up learning new things about the codebase. This time, I learned that if you run the test suite in GitHub Actions in a different order than the order it runs on my laptop, you end up with tests that fail for seemingly mysterious reasons. Hence the new context manager.
Happy to address feedback from your review.

Hi! Somehow I have a lot of friendly, excited comments on your comments. Feel free to read them, or ignore them.

Looks good. I'm sure we can add more as time goes by (like adding beefore checks for linting).

Big +1 from me. :)

I'm interested why I've never seen the test ordering problem before. Makes sense why it might be a problem; it's just interesting to me that I've never seen it.

It's weird! I ran into in GitHub Actions, but I didn't run into it on my laptop. This was a reliable experience for me. I'm going to leave it a mystery for now; I agree it's interesting that neither you nor me experience it on our machines, but GitHub Actions does.

It turns out that I (in my capacity as repo admin) need to poke the repository to make the actions actually start triggering, so I've made a couple of small changes.

Fascinating! I didn't run into any such thing on my fork. Would be curious to know what you ran into, or feel free to not answer this if you think this question of mine is a boring distraction. Is this about allowing GH Actions to run for people without beeware/rubicon-java repo permissions?

One (the trigger for the action) I've flagged inline as a coment

I don't see the comment -- can you point me to it? What I do see is two build YAML files which are near-duplicates of each other.
I have just discovered that you can have one GitHub Actions workflow apply in multiple situations, per https://help.github.com/en/actions/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions#example-using-multiple-events-with-activity-types-or-configuration , so I am likely to submit a follow-up implementing that.

I've also added a placeholder for matrix builds (which we're going to need very soon)

I was avoiding matrix builds in this PR as part of a personal focus on YAGNI/minimalism. Having matrix builds in here is OK with me, too. :)

a separate build_status workflow that will re-run the tests when a PR is merged.

Cool!

(And thanks for the review & merge!)

The comment I referenced is https://github.com/beeware/rubicon-java/pull/9/files/59ead3e416b0a85ec00a762c38adbf62aa58dec6#r356425504.
As for the needing to poke it myself... that's interesting. Looking at the action history, I can see that there were a bunch of successful builds triggered by your commits... but none of those build seem to correspond to the commit hashes that are actually in this PR - it looks like the were all on an "github-actions-on-mac" build. The two commits attributed to you on this PR didn't trigger builds. I assumed that was because I was the owner... but maybe not? Anyway... it's a moot point now.
As for the multiple workflow files - that's actually with a purpose. The pattern I've used on other repos (cf toga is that the CI workflow is a full test on all platforms, preceded by code quality checks (linting etc); the Build status workflow is a smoke test on a single representative platform that can be used to flag whether builds are succeeding or failing.
The primary reason for this is the build status badge in the README. You can't have a build status badge on your README that is driven by the CI workflow, because any PR that fails will alter the state of the badge, regardless of whether it's merged. You need a distinct workflow that only triggers on commits to master. If CI passes on a PR, we should have a reasonable degree of confidence that result will persist into master; but we need to trigger a distinct "yeah, really, everything is OK" build on master to provide data to drive the badge.
As for YAGNI - I can understand that as a motivation, but this is a case where we're very definitely GNI... :-)
If you can find a better way to manage this, I'm open to suggestion - but in terms of billable time, I don't consider this a high priority for the moment.


Skip credentials prompt for CI builds

The XPlat build hangs because git waits for user input. Added a flag that will not invoke git if credentials are not available.
@NTaylorMullen @troydai @ChengTian @suhasj

:shipit:


Update Composer dependencies (2021-08-31-00-13)

Visual regression test passed!
View the visual regression test report


Game Crash

Spelunky 2 crashes whenever I start up Overlunky.
I've tried version 0.6.0, 0.5.9, and the WHIP build.
What do I do to fix this?

I have the same issue the game recently updated on steam and I haven't been able to use overlunky since.

The game got an update that broke the tools. I thought Overlunky had a popup to state this. But let's keep this open for future people wanting to complain about this.
The solution is to not use Overlunky, be patient and start using it again when the next stable release comes out.

I got the new WHIP build, and it's still not working. It keeps on crashing.

Wow, almost sounds like the exact opposite of what you were told to do so I wonder why it doesn't work.

No, I meant the one that was released 2 days ago.
The two messages before my message were before the new WHIP build.

Yes you immediately got the automated pre-release build that only has some random tile code fixes, as stated by the release notes. Just wait PATIENTLY for the STABLE release, which comes with a version number, an announcement and updates to the README, which still clearly states everything is for version 1.25.0b.
The update is being drafted in #179 if you want to follow the progress.


Page Type Migration: Media Library Form Control backed by Text field

Brief bug description
For KX13 Page Types that are a data type of Text and use the Media Selector Form Control:

The migration toolkit brings those fields over into Xperience by Kentico as Text fields

This makes those types of fields unusable in Xperience by Kentico when you try to use them as Media Library selectors in Xperience because you have to change the type to Media Library but the value of the field is not the expected JSON format.

Repro steps

Migrate command that uses --media-libraries to migrate via the CLI
Change a given page type that has a field that should be a media file selector.
Attempt to load that page in the pages app - edit mode.

Expected behavior
What is the correct behavior?
I should be able to use the field as a Media Library selector without the Pages app causing a 500.

Thanks for the update @tkrch, I think your specific answer makes sense. However, I think this is a very common use case for Kentico projects. I think there should be something different that happens here though as I have 250 blog posts to migrate and now basically won't have images for each one of them if nothing changes.

All of our sites built since K12 MVC have used the text field of Page Types to store paths created by the Media Selector or URL Selector (with only the media library tab).
This inserts urls with the /getmedia/... path as the text value of the field.
We then use a Regex on this value to extract the Guid of the Media File and retrieve the file from the database to access the Description, Width, Height properties.
So this feature would be extremely important for us to be able to migrate any site to XbyK.
Make this a configurable setting would be nice.
But, this has me thinking about the extensibility story for the Migration Toolkit - are developers expected to fork, modify the source and then build the toolkit to handle use cases that it doesn't support?
Maybe there's a plugin/extension model that could let the Toolkit hand off migration of specific data to custom code/assembly without rebuilding the tool to get the custom functionality 🤔.


add ECS, VPC, DMS, DCS and RDS resources and examples

Description of your changes

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[ ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

LGTM


Update instructions to match page wording

Make sure that language in instructions matches AWS page.

Proposed changes

Unreleased project version (optional)

Related issues (optional)

Nice, thanks, @mjclemente 👍


Add linkify-full-profile-readme-title feature

Fixes: #3426
Testable on https://github.com/sindresorhus

// @fregante

Uhm, why are you using the API to get the path when it's right there? It's /readme.md in the screenshot you posted

@fregante Github by default always displays README.md regardless of capitalisation. This PR fixes that.

Then we're not going to link to the file directly. Let's just link to the repository home, it displays the same file.

@fregante Linking to the repository home would sacrifice the correct capitalisation of the readme.md text.

Linking to the repository home would sacrifice the correct capitalisation of the readme.md text.

Is the capitalization important in any way?

I suggest just moving the existing nodes into the link. Example:
const link = select(…);
while (link?.nextSibling) {
  link.append(link.nextSibling)
}

Is the capitalization important in any way?

The lack of which is a Github shortcoming.

The lack of which is a Github shortcoming.

GitHub has many shortcomings but we're not going to waste maintenance and API calls on fixing capitalization

I suggest just moving the existing nodes into the link.

A TextNode can't be query selected.

I just run this code in the console. It works:
const link = $('.user-profile-nav + div .octicon-smiley + a');
while (link?.nextSibling) {
  link.append(link.nextSibling)
}

I just run this code in the console. It works:

We don't want to be inadvertently linkifying the slash. Also, the README link is set up to point to #readme on the repository.

My review comments and suggested code were ignored multiple times so I'll close this.
If it takes me longer to review a PR than it takes to write it myself, the PR is not helping me.

🤦

🤦

That's my avatar!


cleanup(userspace/libsinsp): reduce allocations in filtercheck classes

What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
This should save us some MBs used at runtime for large rulesets. In general, this cleans-up the filtercheck classes by:

Having explicit virtual destructors
Remove unused state variables
Allocating storage variables only on-demand

Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE

/milestone 0.15.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, incertum, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,incertum,jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Testing

merging matlalaReuben patch with the pre branch

Codecov Report

Merging #32 (c829ea3) into main (4c9f4ad) will increase coverage by 41.21%.
The diff coverage is 47.44%.

@@            Coverage Diff            @@
##           main      #32       +/-   ##
=========================================
+ Coverage      0   41.21%   +41.21%
=========================================
  Files         0       25       +25
  Lines         0     2033     +2033
=========================================
+ Hits          0      838      +838
- Misses        0     1195     +1195

Impacted Files
Coverage Δ

lib/forms/answer_edit_form.dart
0.00% <0.00%> (ø)

lib/screens/home_screen.dart
0.00% <0.00%> (ø)

lib/screens/module_questions_screen.dart
0.00% <0.00%> (ø)

lib/screens/user_info_screen.dart
0.00% <0.00%> (ø)

lib/utils/authentication.dart
3.27% <ø> (ø)

lib/utils/exceptions.dart
0.00% <0.00%> (ø)

lib/widgets/favourites_tab.dart
0.00% <0.00%> (ø)

lib/widgets/my_posts_tab.dart
0.00% <0.00%> (ø)

lib/widgets/recent_activity_tab.dart
0.00% <0.00%> (ø)

lib/utils/functions.dart
23.37% <37.50%> (ø)

... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c9f4ad...c829ea3. Read the comment docs.


mbed sync ignores forks of mbed-os / sets lib reference incorrectly

While testing an application example using a fork of mbed OS (from a PR), I wanted to sync the mbed-os library to the mbed-os fork instead of the main repo location.
However, mbed sync seems to always assume that mbed-os is located at https://github.com/armmbed/mbed-os/
Steps to recreate:
mbed import mbed-os-example-mesh-minimal
cd mbed-os-example-mesh-minimal\mbed-os
git remote add myremote https://github.com/pradeep-gr/mbed-os5-onsemi
git fetch myremote
git checkout myremote/master
cd ..
mbed sync
This results in mbed-os.lib containing an invalid reference to:
https://github.com/ARMmbed/mbed-os/#079aedf2531e23a504b5f1ca761ec87033792f0f
which does not exist.
It should be:
https://github.com/pradeep-gr/mbed-os5-onsemi/079aedf2531e23a504b5f1ca761ec87033792f0f

@maclobdell We should add some documentation to point out that Mbed CLI "prefers" origin remote and therefore you should change the "origin" URL if you're pulling from a fork. Is this something you could look at with perhaps @AnotherButler ?

ah, I see.  I thought that it could figure out which remote you want to specify based on if you have a specific remote/branch checked out, but I guess that isn't possible.   I agree this would be good to document.  Perhaps also this could be mentioned in the help for mbed sync (mbed sync -h).

ARM Internal Ref: MBOTRIAGE-464

Thank you for raising this issue. Please note we have updated our policies and
now only defects should be raised directly in GitHub. Going forward questions and
enhancements will be considered in our forums, https://forums.mbed.com/ . If this
issue is still relevant please re-raise it there.
This GitHub issue will now be closed.


Update observability branch (trace-analytics repo) to 1.2 in manifest

Signed-off-by: Joshua Li<EMAIL_ADDRESS>Description
Update observability branch (trace-analytics repo) to 1.2 in manifest
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #940 (dfa5416) into main (08ee51f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   92.24%   92.24%
=======================================
  Files          88       88
  Lines        2321     2321
=======================================
  Hits         2141     2141
  Misses        180      180

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08ee51f...dfa5416. Read the comment docs.


Misspellings

Most of them were documentation or method's inline code misspellings. However, the ReactCommon/jsi/jsi/test/testlib.cpp #countOccurences name was replaced with countOccurrences, it's not used though.
Thanks,
Gerasimos Maropoulos.

I agreed to the CLA 10 minutes ago. Don't know why this @facebook-github-bot is slow but I still love it :heart:


Feature: Single Directional Binary Pipes

This PR does a bit more than I planned on originally.

This adds the ability to open a NexusPipe on an invoked method.
Renamed NexNet classes to just Nexus.
Changed the default client settings to not auto reconnect.

NexusPipe Writing Usage
var pipe = NexusPipe.Create(async (writer, token) =>
{
    while (true)
    {
        var result = await writer.WriteAsync(data);

        if (result.IsCanceled || result.IsCompleted)
            break;
    }
});

Usage Notes:

Pipe will auto complete and notify the reader of completion as soon as exiting the closure.

Replaced by #18.


VSCode refuses to type check JavaScript files

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.77.3 (Universal)
OS Version: macOS Ventura 13.3.1

Steps to Reproduce:
Despite trying everything that was documented, VSCode straight out refuses to type check JavaScript files.
I have tried:

Adding @ts/check explicitly to files I want to have checked
Adding jsconfig.json with "checkJs": true
Adding tsconfig.json with "allowJs": true, "checkJs": true
Adding js/ts.implicitProjectConfig.checkJs": true setting

The following illustration shows how TS file is checked, while identical JS file is not.

Another example shows how tsc --noEmit is able to find the error, but VSCode is not:

What's the structure of your project? Can you share a small example project with the issue

Sure! Here's the minimal reproduction:
vscode-typescript-repro.zip

Thanks. Works fine for me though:

Did you set "javascript.validate.enable": false?  Does this reproduce in the latest VS Code insiders build with all extensions disabled?

OH. MY. GOD.
It's that setting indeed! I've set it back in like 2017 and completely forgot about it 🤦♂ Would be good to add it to the docs to ensure this setting is not turned off!


flakiness fix for forked chain test

Change Description

Fixes flakiness in nodeos_forked_chain_lr_test
Flakiness as caused by waitForBlock timeout that was default (60 seconds).
Sometimes it requires longer timeout because of producer schedule for 10 producers is 10 * (12 * 0.5) = 60.
So when wait starts simultaneously with wait for next producer schedule test fails because of error getting next block.
Change Type
Select ONE:

[ ] Documentation

[ ] Stability bug fix

[ ] Other

[ ] Other - special case

Testing Changes
Select ANY that apply:

[ ] New Tests

[x] Existing Tests

[ ] Test Framework

[ ] CI System

[ ] Other

Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

Didn't fix the problem. https://buildkite.com/EOSIO/eosio-lrt/builds/4329


vl53l0x: Add support for interrupt and configurable sampling frequency

drivers: sensor: vl53l0x: run clang-format
drivers: sensor: vl53l0x: add attr_get/set for the sampling frequency
drivers: sensor: vl53l0x: add support for interrupt-gpios
boards: shields: x_nucleo_53l0a1: add interrupt-gpios
samples: sensors: vl53l0x: update to use trigger mode if available

Thank you for reviewing this PR @MaureenHelm
I applied your suggestions, fixed some issues uncovered by the compliance checks, and rebased on top of the latest main

I clicked on "Re-request review" for @MaureenHelm and this removed all the other reviewers, not sure why :thinking:


Docs typo: value -> $value

Hello! It seems to me that I found a typo in the documentation:
<input type="text" bind:value="{value}" />

should be
<input type="text" bind:value="{$value}" />

@sorrat good catch, the documentation is now fixed.


Add Java ACI runtime annotation

Part of the effort for resolving: https://github.com/metaparticle-io/package/issues/23

LGTM.


Bring back selecting multiple namespaces

What would you like to be added:
Please allow selecting multiple namespaces, without needing to hold ctrl or other buttons.
Why is this needed:
I would argue that for most users, it is not an intuitive behavior of a drop down multi-select with check marks. I have not seen a multi-select dropdown where a user has to hold an extra button to select multiple items. Having to hold an extra button is cumbersome. As proof, there is even a bug issue #4047, a user thought it is a bug. I personally spent a month with new Lens 5 and only now found out the multiple-select feature.
Environment you are Lens application on:

Kubernetes distribution: [EKS, Linode, On-Premise]
Desktop OS: Ubuntu

While we do not plan on reverting the change, we completely agree that the UX around multi-select could be better and will work to make it so.
We are working on making this better.

Great to hear that! Thank you!


Add dictionary and fix some spellings in docs

Addresses #803 , approach taken was :

Capture possible misspellings list using Typescript spellchecker
Weed out the obvious technology words identified and keep them
Correct some spellings while acknowledging my bias towards Australian and British English

In the future I propose maintaining the dictionary.txt in the docs folder and automating via CI using the Typescript tool I used or some other pre-baked GitHub Action. I can create a follow-on issue with this if you would like some assistance with the CI.

Which CI workflow should I target ? A new one or a linting focused one
seems appropriate. Will propose make docs-lint as a command where things
like spellcheck and markdown lint can live.
On Thu, 24 Aug 2023, 17:33 Dario Tranchitella, @.***>
wrote:

Definitely an interesting approach, thanks @whatnick
https://github.com/whatnick.
I just saw the addressed fix, the Typescript spellchecker
https://github.com/tbroadley/spellchecker-cli/issues implementation is
still missing: may I ask you to implement it using the Makefile and
automate it in the CI?
—
Reply to this email directly, view it on GitHub
https://github.com/clastix/capsule/pull/804#issuecomment-1691204137, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADX7BB4CS3HHVUJXBQ533DXW4DGJANCNFSM6AAAAAA34JTLNQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

make docs-lint LGTM.
We could set up a new workflow in order to trigger it only if we have changes on docs folder, as we're doing similarly with e2e.
https://github.com/clastix/capsule/blob/ffa4a47e6baa6f9cb3660e2f37b81392a40cf675/.github/workflows/e2e.yml#L3-L27


update to version 1.4.1

Please amend the commit message to include the name of the updated cask.

Shouldn't be versioned without an appcast

Thank you for the contribution. It was merged directly as 3b669d07a3e11ae3f81f2a0a2423e643e4b96ad4 to keep commit history cleaner. Your contribution is still credited to you.


Feature/vs 12082

Build finished. No test results found.

Waiting on omnipay-test PR to be merged, to fix failing test.

retest this please

retest this please

retest this please

Looks good