ns-viewer does not start on the blender-data lego scene, pose_adjustment size mismatch

First I train nerfacto on the traditional LEGO scene like this:
ns-train nerfacto --pipeline.model.near-plane 2 --pipeline.model.far-plane 10 --max-num-iterations 4000 --experiment-name bl_lego blender-data --data data/nerf_synthetic/lego
The visualizer works perfectly fine while training. But when finish training and want to start ns-viewer with the command
ns-viewer --load-config outputs/bl_lego/nerfacto/2023-04-13_121027/config.yml
I get the following error

Loading latest checkpoint from load_dir
Traceback (most recent call last):
File "/home/seymour/.local/bin/ns-viewer", line 8, in
sys.exit(entrypoint())
File "/home/seymour/.local/lib/python3.10/site-packages/scripts/viewer/run_viewer.py", line 108, in entrypoint
tyro.cli(RunViewer).main()
File "/home/seymour/.local/lib/python3.10/site-packages/scripts/viewer/run_viewer.py", line 48, in main
config, pipeline, _ = eval_setup(
File "/home/seymour/.local/lib/python3.10/site-packages/nerfstudio/utils/eval_utils.py", line 105, in eval_setup
checkpoint_path = eval_load_checkpoint(config, pipeline)
File "/home/seymour/.local/lib/python3.10/site-packages/nerfstudio/utils/eval_utils.py", line 62, in eval_load_checkpoint
pipeline.load_pipeline(loaded_state["pipeline"], loaded_state["step"])
File "/home/seymour/.local/lib/python3.10/site-packages/nerfstudio/pipelines/base_pipeline.py", line 375, in load_pipeline
self.load_state_dict(state, strict=True)
File "/home/seymour/.local/lib/python3.10/site-packages/nerfstudio/pipelines/base_pipeline.py", line 115, in load_state_dict
super().load_state_dict(pipeline_state, strict=False)
File "/home/seymour/.local/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1604, in load_state_dict
raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for VanillaPipeline:
size mismatch for datamanager.eval_camera_optimizer.pose_adjustment: copying a param with shape torch.Size([100, 6]) from checkpoint, the shape in current model is torch.Size([200, 6]).
size mismatch for datamanager.eval_ray_generator.pose_optimizer.pose_adjustment: copying a param with shape torch.Size([100, 6]) from checkpoint, the shape in current model is torch.Size([200, 6]).
In comparison, ns-viewer works just fine.
My system:
Ubuntu 22.04
Python 3.10.6
nerfstudio 0.1.19, PIP-installed
torch  1.12.1+cu113
cuda 11.5.1
GeForce 1660

I'm a little confused is ns-viewer working or not?

ns-viewer --load-config outputs/bl_lego/nerfacto/2023-04-13_121027/config.yml
I get the following error ...

In comparison, ns-viewer works just fine.

Sorry, missed a part of the sentecnce.
It should be
In comparison, ns-viewer works just fine for nerstudio data (e.g. poster).
ns-viewer does NOT work with lego (blender data)
ns-viewer works fine with poster (nerfstudio data)

Issue also holds for ns-export: DNeRF Lego data has a size mismatch, also probably from them using different datasets.
I'd argue training using the validation dataset is weird anyways, since val only has 10 frames where train has 50 (and thus you train with less data)
I removed the validation and test dataset, and copied train to both of them (so now all 3 datasets val,train,test are the same 50 images and the same json file). It's not quite the spirit of machine learning, but if we're gonna have mismatches because of the way the data directories is structured and which sets are used between different programs, this should fix that. I'm pretty sure nerfstudio creates its own training / evaluation split anyways
Of course the actual solution would be fixing this within nerfstudio, but unfortunately that's out of scope for me at the moment


Policy-based vrf selection rt3.2 testcase - multiple protocol+dscp rule based traffic match

RT-3.2: Multiple <Protocol, DSCP> Rules for VRF Selection
-Added coverage for following tests for policy based vrf selection RT3.2:

Case1 - Ensure matching IPinIP with DSCP (10 - VRF10, 20- VRF20, 30-VRF30) traffic reaches appropriate VLAN.
Case2 - Ensure matching IPinIP with DSCP (10-12 - VRF10, 20-22- VRF20, 30-32-VRF30) traffic reaches appropriate VLAN.
Case3 - Ensure first matching of IPinIP with DSCP (10-12 - VRF10, 10-12 - VRF20) rule takes precedence.
Case4 - Ensure matching IPinIP to VRF10, IPinIP with DSCP20 to VRF20 causes unspecified DSCP IPinIP traffic to match VRF10.
logs.txt

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 66.592%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
594

Relevant Lines:
892

💛  - Coveralls

Hi @dplore, could you help decide fate of this PR.

I think in this case, let's keep this PR and let @cprabha be a reviewer? @dplore

@cprabha although this development is assigned to you via #131 but if you have not completed most of this test, we suggest that this PR could be used for the implementation.  What do you think @cprabha ?

/gcbrun to force featureprofiles-pr CI check to run

Sure Darren.
I will review the PR.
Thanks,
Prabha
Juniper Business Use Only
From: Darren Loher @.>
Sent: Friday, June 17, 2022 9:40 AM
To: openconfig/featureprofiles @.>
Cc: Prabha Chethan @.>; Mention @.>
Subject: Re: [openconfig/featureprofiles] Policy-based vrf selection rt3.2 testcase - multiple protocol+dscp rule based traffic match (PR #214)
[External Email. Be cautious of content]
@cprabhahttps://urldefense.com/v3/__https:/github.com/cprabha__;!!NEt6yMaO-gk!CYXdnYC8MlBEh2R_BuB2hJnu3CaoW6e2Iq2u7lpcb9PKNqggp36_pOzGZnPAxtEYRIcg_ImNVaArH2P9LW4hjqU4$ although this development is assigned to you via #131https://urldefense.com/v3/__https:/github.com/openconfig/featureprofiles/issues/131__;!!NEt6yMaO-gk!CYXdnYC8MlBEh2R_BuB2hJnu3CaoW6e2Iq2u7lpcb9PKNqggp36_pOzGZnPAxtEYRIcg_ImNVaArH2P9Ldh4vPsI$ but if you have not completed most of this test, we suggest that this PR could be used for the implementation. What do you think @cprabhahttps://urldefense.com/v3/__https:/github.com/cprabha__;!!NEt6yMaO-gk!CYXdnYC8MlBEh2R_BuB2hJnu3CaoW6e2Iq2u7lpcb9PKNqggp36_pOzGZnPAxtEYRIcg_ImNVaArH2P9LW4hjqU4$ ?

Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/openconfig/featureprofiles/pull/214*issuecomment-1159051137__;Iw!!NEt6yMaO-gk!CYXdnYC8MlBEh2R_BuB2hJnu3CaoW6e2Iq2u7lpcb9PKNqggp36_pOzGZnPAxtEYRIcg_ImNVaArH2P9LfZ9KgVt$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AHCEB5QLT4TVPCPMFMBK4VDVPSS6DANCNFSM5X5KIR2Q__;!!NEt6yMaO-gk!CYXdnYC8MlBEh2R_BuB2hJnu3CaoW6e2Iq2u7lpcb9PKNqggp36_pOzGZnPAxtEYRIcg_ImNVaArH2P9LYOe-rPD$.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@singh-prem let us know if can you address the comments.  If you need some additional time, please let us know, thank you.

Thanks @cprabha for comments.
Hi @dplore working on taking care of the comments. Will push changes within this week.

have taken care of comments, please review changes.

logs.txt
pass logs

Hi @bstoll @cprabha could you review the changes.

@singh-prem will review it shortly.

logs.txt

Hi @dplore could you help on future course for this PR.

logs.txt

/gcbrun


Can i bundle puppeteer to use it in an extension i'm building ?

i'm trying to build a chrome extension to be able to scrape some data which requires to be fetched outside the users tab it's basically going to take a list of urls from a page that the user is and then tries to enter each url and scrape data from it know i'm trying to get puppeteer to do this but i can't find a way to bundle it so that i can use it to build the extension
i also tried to download an older versions like bump-v2.1.0 i did managed to bundle this one
but when i run the extension and tried to launch a browser it give me this error
Uncaught (in promise) TypeError: Cannot read property 'call' of undefined
at bundle.js:9487
at new Promise ()
at promisified (bundle.js:9479)
at ChromeLauncher.launch (bundle.js:5280)
at module.exports.launch (bundle.js:8459)
at Scraper (main.js:4)
at main.js:10
the newer versions i couldn't even be able to bundle 'em they kept giving this error

browserify -r ./index.js:puppeteer -o bundle.js

Error: module not found: "ws" from file /media/kali/tools/web_developments/extension/linkedin/puppeteer_core/node_modules/puppeteer-core/lib/WebSocketTransport.js
at onresolve (/usr/lib/node_modules/browserify/node_modules/module-deps/index.js:182:30)
at /usr/lib/node_modules/browserify/index.js:537:20
at /usr/lib/node_modules/browserify/node_modules/browser-resolve/index.js:247:21
at /usr/lib/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:55:18
at load (/usr/lib/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:69:43)
at onex (/usr/lib/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:92:31)
at /usr/lib/node_modules/browserify/node_modules/browser-resolve/node_modules/resolve/lib/async.js:22:47
at FSReqCallback.oncomplete (fs.js:175:21)

any help

+1 could also use some assistance with this.

can you give an example of something you want to do?

Hi! I'm also wondering when puppeteer-core will be bundled for the browser. According to puppeteer-core's documentation, the benefit of pupeteer-core is:

puppeteer-core is intended to be a lightweight version of Puppeteer for launching an existing browser installation or for connecting to a remote one. Be sure that the version of puppeteer-core you install is compatible with the browser you intend to connect to.

However, as it's not currently bundled for the browser, it's not possible to use pupeteer-core in javascript tools built to run outside of node. When will we see puppeteer-core bundled for the browser?

Hey there @babahadjsaid, I'm also facing the same issue now, could you help me that how did you deal with it?


removing type annotations from loader_function per #32

Enabling generation of a DTable via d = DTable(CSV.File, files) by removing the ::Function type annotation per the suggestion in this thread.

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.12% :warning:

Comparison is base (9fcbe23) 95.56% compared to head (e4b2c14) 95.44%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   95.56%   95.44%   -0.12%
==========================================
  Files          12       12
  Lines         857      857
==========================================
- Hits          819      818       -1
- Misses         38       39       +1

Files Changed
Coverage Δ

src/table/dtable.jl
92.85% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Looks alright, let's just fix the format
Is there an alternative to Base.Callable? Can be a newish Julia only since we support new versions anyway
I would love to have some type annotation there if possible eventually

I can't seem to see which lines are causing the formatting problem. Is there a way to run this locally so I can check before I try again?

using JuliaFormatter; format(".")


[WIP]: Migrate Card story to typescript

Part of #735

I'm having an issue with the first tab being renamed to Story. Will hopefully be fixed soonhttps://github.com/storybookjs/storybook/issues/12357

I had to use the JSX.IntrinsicElements trick for the args table to show. I wasn't enough with React.HTMLAttributes 🤷♀


Enumerator is inconsistent on JRuby 1.6 and 1.7

It is also possible to run it 1.7.dev currently, except the issue here.
So we may periodically run specs against it to make it easier to transition.
Currently there's inconsistent behaviour on the Enumerator.
For example:

JRuby <IP_ADDRESS>: Blog.first.posts.any? {|p| puts p.class}  # Post
JRuby 1.7.dev: Blog.first.posts.any? {|p| puts p.class, p.first.clas}  # Array, Post

As a result (I suppose) of this ~50-ish specs fail.
The fix I imagine is easy and is related to the Enumerator behaviour.
(However, it's possible that it's a JRuby issue, but I haven't been able to reproduce it outside neo4j.rb)

Very strange. I have no clue what's wrong. It sounds like a JRuby bug. Either we wait and hope that it is a JRuby bug that will be solved or we investigate and try to reproduce it with use less and less or neo4j.rb.

It's not jruby bug. At least it is not reproducible without neo4j:
http://jira.codehaus.org/browse/JRUBY-6329
This bug only appears in the project with neo4j. And running neo4j.rb specs
on jruby 1.7 clearly shows the bug. So its 99.9999% neo4j bug.
On Jan 10, 2012 6:38 PM, "Andreas Ronge" <
<EMAIL_ADDRESS>wrote:

Very strange. I have no clue what's wrong. It sounds like a JRuby bug.
Either we wait and hope that it is a JRuby bug that will be solved or we
investigate and try to reproduce it with use less and less or neo4j.rb.

Reply to this email directly or view it on GitHub:
https://github.com/andreasronge/neo4j/issues/119#issuecomment-3426404

Reproducing it veeeery easy. Just run specs on 1.7.
On Jan 10, 2012 6:38 PM, "Andreas Ronge" <
<EMAIL_ADDRESS>wrote:

Very strange. I have no clue what's wrong. It sounds like a JRuby bug.
Either we wait and hope that it is a JRuby bug that will be solved or we
investigate and try to reproduce it with use less and less or neo4j.rb.

Reply to this email directly or view it on GitHub:
https://github.com/andreasronge/neo4j/issues/119#issuecomment-3426404

Sure, I was just thinking of creating the simplest possible RSpec that
can reproduce it so we can identify which part of neo4j.rb cause it.
On Tue, Jan 10, 2012 at 9:23 AM, Dmytrii Nagirniak
<EMAIL_ADDRESS>wrote:

Reproducing it veeeery easy. Just run specs on 1.7.
On Jan 10, 2012 6:38 PM, "Andreas Ronge" <
<EMAIL_ADDRESS>wrote:

Very strange. I have no clue what's wrong. It sounds like a JRuby bug.
Either we wait and hope that it is a JRuby bug that will be solved or we
investigate and try to reproduce it with use less and less or neo4j.rb.

Reply to this email directly or view it on GitHub:
https://github.com/andreasronge/neo4j/issues/119#issuecomment-3426404

Reply to this email directly or view it on GitHub:
https://github.com/andreasronge/neo4j/issues/119#issuecomment-3426740

I think there already is:
> bundle exec rspec spec/has_n/has_n_spec.rb:163 --backtrace
/There are warnings here... but omitting those.

Run filtered including {:line_number=>163}, excluding {:identity_map=>true}
F

Failures:

  1) Neo4j::NodeMixin#has_n specified relationship: has_n(:friends).relationship(Role) generated 'friends' method when adding ruby class including Neo4j::NodeMixin: a.friends << b from.friends.first == to (should load the correct Ruby class)
     Failure/Error: @a.friends.first.class.should == @b.class
       expected: Model_1
            got: Array (using ==)
       Diff:
       @@ -1,2 +1,2 @@
       -Model_1
       +Array
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-expectations-2.6.0/lib/rspec/expectations/fail_with.rb:29:in `fail_with'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-expectations-2.6.0/lib/rspec/matchers/operator_matcher.rb:48:in `fail_with_message'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-expectations-2.6.0/lib/rspec/matchers/operator_matcher.rb:70:in `__delegate_operator'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-expectations-2.6.0/lib/rspec/matchers/operator_matcher.rb:60:in `eval_match'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-expectations-2.6.0/lib/rspec/matchers/operator_matcher.rb:29:in `=='
     # ./spec/has_n/has_n_spec.rb:163:in `(root)'
     # org/jruby/RubyBasicObject.java:1798:in `instance_eval'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example.rb:48:in `run'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example.rb:107:in `with_around_hooks'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example.rb:45:in `run'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:294:in `run_examples'
     # org/jruby/RubyArray.java:2335:in `map'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:290:in `run_examples'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:262:in `run'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:263:in `run'
     # org/jruby/RubyArray.java:2335:in `map'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:263:in `run'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:263:in `run'
     # org/jruby/RubyArray.java:2335:in `map'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:263:in `run'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:263:in `run'
     # org/jruby/RubyArray.java:2335:in `map'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/example_group.rb:263:in `run'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/command_line.rb:24:in `run'
     # org/jruby/RubyArray.java:2335:in `map'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/command_line.rb:24:in `run'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/reporter.rb:12:in `report'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/command_line.rb:21:in `run'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/runner.rb:80:in `run_in_process'
     # /Users/dnagir/.rvm/gems/jruby-head/gems/rspec-core-2.6.4/lib/rspec/core/runner.rb:69:in `run'

Finished in 1.29 seconds
1 example, 1 failure

Failed examples:

rspec ./spec/has_n/has_n_spec.rb:162 # Neo4j::NodeMixin#has_n specified relationship: has_n(:friends).relationship(Role) generated 'friends' method when adding ruby class including Neo4j::NodeMixin: a.friends << b from.friends.first == to (should load the correct Ruby class)

Note that the simplest repro ONLY fails when used in neo4j.rb. Doesn't fail when used with other libs.
Something leaked into global namespace? Or maybe core objects are modified?

Well, I guess we have to do a binary search, just remove code and requires statement in neo4j.rb and see when it starts to work again.

Yeah. Binary search is good. But with more knowledge maybe it can be done in log(n) ? :)

I think this has been solved ...


use vpath for app subdirectories

@brghena I think this should address your issue from 9a35bbd

Sure does. That looks like a pretty sustainable solution for subdirectories. The content of the build folder doesn't really need to be anything but a flat set of files.


Gizmo locations are not updated when dragging a parent entity

Create an entity and add a child
Add a component that renders a gizmo, such as a light component
Drag the parent around using the translation gizmo

It's still not updating gizmos from children of children

I can no longer reproduce this


[RaisedButton] Don't override SvgIcon color prop

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[x] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

When passing an SvgIcon to a RaisedButton with a color property set, it renders the icon with the correct color (fixes #3745).
Since there wasn't a unit test file for RaisedButton component yet, I made one.

@goffreder Can you rebase and squash please? (You could use the PR title as the commit title.)
Thanks!

Ping @goffreder

I'm sorry, I missed the emails. Is it ok now?

@goffreder Nearly, you need to git pull --rebase upstream master and fix any merge conflicts.

@goffreder Can you move the test into the new unit test file for RaisedButton inside the src folder? We don't put unit tests in /test/ anymore.

@goffreder Thanks for the fix :+1:.


Duplicate DA values for new editions

Trello
Draft PR at the moment... i'll create a proper PR after testing the branch out on integration tomorrow (16/06) but feel free to start reviewing.
Devolved administration availability modelling was added in a previous PR.
A bug was discovered, in that the embedded fields in DevolvedAdministrationAvailability were not being copied when a new edition was created.
The reason for this is the scotland_availability, wales_availability and northern_ireland availability fields were not included in the array returned by the type_specific_field_keys method. The test for duplicating editions used a different edition type, which is partly why the bug was missed.
This commit adds the devolved administration availability fields to the type_specific_field_keys and ensures they are copied over when a new edition is created.
The DEVOLVED_ADMINISTRATION_AVAILABILITY_FIELDS have been hardcoded as a constant. I did look into listing the keys in an embedded model but couldn’t find an obvious simple solution but that would have been preferable, so suggestions very much welcomed on that.
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Just a quick comment as I'm running out of time before a meeting. Thanks for working this out 👍
I think there's some improvements we can make to this, so it's a bit of a cleaner implementation. I don't think the Edition class should know about devolved administration stuff at all, that should be entirely within the LocalTransactionEdition model.
There is some prior art in https://github.com/alphagov/publisher/blob/45182956f5bd16eb0c6ae1b88ed9783d60d5efbe/app/models/simple_smart_answer_edition.rb#L27-L35
I imagine it'd be better still if the copying of fields was able to copy over the embedded fields implicitly as per fields, I'm not sure how much of a pain that is but could probably be investigated by looking into edition_class.embedded and having something to remove actions and link_check_reports.
Hope this helps, happy to chat verbally about it.

Thanks @kevindew i'll look into the suggested approach. I'll message you if any questions.


Get Selected Date?

Hi Im sorry but it is unclear how to get the actual selected date.

Here is a sample of how it can be done with the date picker state
    @Composable
    private fun Test(
        onSelectedDates: (List<LocalDate>) -> Unit
    ) {
        val state = rememberEpicDatePickerState(
            selectionMode = EpicDatePickerState.SelectionMode.Single(maxSize = Int.MAX_VALUE),
            config = rememberEpicDatePickerConfig(
                pagerConfig = rememberEpicCalendarPagerConfig(
                    basisConfig = rememberBasisEpicCalendarConfig(
                        displayDaysOfAdjacentMonths = false
                    )
                ),
                selectionContentColor = MaterialTheme.colorScheme.onPrimary,
                selectionContainerColor = MaterialTheme.colorScheme.primary
            )
        )
        Column {
            Text("currentMonth:  ${state.pagerState.currentMonth.year.toString()} ${state.pagerState.currentMonth.month.name}")
            EpicDatePicker(
                state = state
            )
        }

        LaunchedEffect(state.selectedDates) {
            // dates changed
            onSelectedDates(state.selectedDates)
        }
    }


Replace ZLUX in Zowe docs

ZLUX is a codename for the Zowe Application Framework, consisting of the Zowe desktop and App server. We should replace as many occurrences of "ZLUX" in our documentation with "desktop", "app framework" and "app-server" according to which part we are talking about. More mentions of ZLUX lead to more confusion.
zlux should not be found anywhere except code and developer doc.

I think this is done. When I just checked, I saw very little "zlux" except when mentioning specific code which uses it, so the doc looks good to me right now.


[CT-60] [Bug] It takes too long to generate docs (BigQuery)

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Hi there
I have seen a similar bug here https://github.com/dbt-labs/dbt-core/issues/1576 and the issue is closed, but it appears to still be long for me to generate docs because (I believe) of the sharded tables in BQ (the ga_sessions_* from GA360)
Right now it takes around 30min and we have a little bit more of 10K tables
Expected Behavior
I would expect the dbt docs generate command to finish generating the catalog within a minute
Steps To Reproduce
No response
Relevant log output
No response
Environment
- OS:
- Python: 3.7
- dbt: 1.0.0

What database are you using dbt with?
bigquery
Additional Context
No response

@chaos87 Sorry for the delay here! I'm going to transfer this to dbt-bigquery, which is where the code for BigQuery-specific catalog generation lives today, and where any change to that logic would need to happen.
Given the change we made way back in https://github.com/dbt-labs/dbt-core/pull/1795 — which seems like it should have fixed this, but maybe we missed a spot? — and Drew's note there about the syntax he tapped into, there might also be some interesting overlap with https://github.com/dbt-labs/dbt-bigquery/issues/113...


specialize max/min for common case

because the general case instantiates a large number of templates.

If it does cut down on instances I am all for it.
Can't believe it's used that often tough?
Perhaps 1024 different instances at most?

@WalterBright this fails the style checker:
std/algorithm/comparison.d(1544:11)[warn]: Public declaration 'max' has no documented example.
std/algorithm/comparison.d(1674:11)[warn]: Public declaration 'min' has no documented example.


Stack usage concerns

@kisvegabor There are a few places in LittlevGL where we are using >= 1024 bytes of stack in a single function. This concerns me, since not everyone's platform may be configured with a large stack by default.
(These measurements are with LV_HOR_RES_MAX and LV_VER_RES_MAX set to 480 and 320, respectively.)

Around 1 kilobyte of stack is used by each of these two functions.
https://github.com/littlevgl/lvgl/blob/7f7034f50fd62b3a3335e72510e129dab4cc3745/src/lv_draw/lv_img_decoder.c#L366
https://github.com/littlevgl/lvgl/blob/7f7034f50fd62b3a3335e72510e129dab4cc3745/src/lv_draw/lv_draw_img.c#L473
I think too much of the stack is being used here. IMO this should either be dynamically allocated with malloc, or, even better, since it's only running on one thread at a time, statically allocated.

lv_draw_shadow_bottom uses 1 kilobyte of stack.
lv_draw_shadow_full uses over 3 kilobytes of stack. I think this is too much for the typical embedded stack - which could only be 1 or 2 kilobytes (less in some environments).
I'm not quite sure how to optimize these - there are several VLAs in use that can't be allocated statically. Possibly dynamic allocation is an option here?

Can the stack usage be profiled somehow? Maybe there are more spots that uses lots of stack memory.
If those large arrays are allocated inside functions maybe you can move them outside those and made them file scoped by adding the static qualification. As for VLAs, i think you can avoid them by allocating the 'worst possible' scenario, the linux kernel is VLA as far as i know, so lvgl can be also free of those.
I'm surely suggesting a naive thing but i'm interested to know how this will be solved.

lv_color32_t palette_tmp[256];

I was able to improve it. The palette dynamically allocated later so I've just used that dynamically allocated memory instead of a local variable.

uint8_t buf[LV_HOR_RES_MAX * ((LV_COLOR_DEPTH >> 3) + 1)]; /+1 because of the possible alpha byte/

I can't see a good solution here. However, it is used only when

image is not TRUE_COLOR
LV_COMPILER_VLA_SUPPORTED == 0

lv_draw_shadow_bottom uses 1 kilobyte of stack.
lv_draw_shadow_full uses over 3 kilobytes of stack. I think this is too much for the typical embedded stack - which could only be 1 or 2 kilobytes (less in some environments).

These are also only when LV_COMPILER_VLA_SUPPORTED = 0, right?
IMO, the LV_COMPILER_VLA_SUPPORTED == 0is not a big issue. All embedded C compilers what I saw so far supported it. I added this option because of Visual Studio.
As @C47D suggesteed we can move these variables out of the functions but only if VLA is not supported. With VLA consuming extra 3..4 kB RAM continuously is worse IMO.
What do you think?
@C47D

Can the stack usage be profiled somehow? Maybe there are more spots that uses lots of stack memory.

I don't know but it'd be an interesting experiment.

@kisvegabor Is it correct to say that when VLAs are supported the array uses the width/height of the object instead of LV_[HOR/VER]_RES_MAX? If so then I suppose that is acceptable.

we can move these variables out of the functions but only if VLA is not supported.

I agree.

I did checkout the use of:
https://github.com/littlevgl/lvgl/blob/7f7034f50fd62b3a3335e72510e129dab4cc3745/src/lv_draw/lv_img_decoder.c#L366
And it's only used when lvgl is configured to use a file system (LV_USE_FILESYSTEM != 0). According with the function where it is allocated (lv_img_decoder_built_in_open), this function open an image file and tries to decode it (this is when buf is created), if it can't decode it, it will return NULL and the image will be decoded line by line using the decoder_read_line function pointer. If i understand correctly the default behavour can be decode the image line by line so buf allocation can be avoided?
Please let me know if i am misunderstanding, i'm in a break at job (:

@C47D Decoding the image line by line is probably much slower - it would be more ideal to statically or dynamically allocate the buffer, since LittlevGL is single-threaded.

@C47D

We can build lvgl with the -Wvla compiler switch to warn on VLA usage so we can try to avoid the, as much as possible.

Basically, we either use the stack for dynamic allocations (and expect people to increase their stack size) or we use the heap. Considering that the heap has overflow checking while the stack doesn't, using the heap is probably safer.

@C47D

If i understand correctly the default behavour can be decode the image line by line so buf allocation can be avoided?

The behavior depends on

the color format: ALPHA and INDEXED images are read line-by-line but for TRUE_COLOR images only a pointer is returned if stored in the flash
every image stored as a file (with built-in format) is read line-by-line to avoid buffering the whole image in RAM.

@embeddedt

Basically, we either use the stack (VLA) for dynamic allocations (and expect people to increase their stack size)

Using the heap people need to increase the heap size, isn't it?.
However, usually, the minimum stack size is defined.

Considering that the heap has overflow checking while the stack doesn't, using the heap is probably safer.

Is lv_mem_alloc really faster than allocating something in the stack? I don't know for sure but I think a VLA is just jumping the stack pointer.
So for no VLA I think using static variables is a good solution. But do you think we should remove VLAs at all?

My concern is simply that people aren't likely to be using/expecting a 5 kilobyte stack. We need to have some way of capping the amount of stack we'll use... VLAs make that difficult.
Allocating on the heap is slower, but safer.

My concern is simply that people aren't likely to be using/expecting a 5 kilobyte stack. We need to have some way of capping the amount of stack we'll use... VLAs make that difficult.

True, it really could be an issue. However, we should take into account that nobody concerned about stack overflow so far. (Except some people with FreeRTOS but I think it's a different thing).  Probably it's because VLA is usually supported by the embedded compilers.
Anyway, the biggest VLAs are the shadow related buffers and file read buffer for images, right?
For shadow buffers, we can always reallocate a buffer if the current is too small. This way only the required size will be used. (Shadow is usually < 10 px so the buffer will be < 100 bytes)
We can do the same thing with the file buffer. Its max size is 4 * LV_HOR_RES_MAX so 1-2 kB.
We can even generalize this thing to have a function like lv_draw_get_tmp_buf(size) which reallocates the buffer if it's current size is too small. Now one buffer is enough, but a function like this can hide multiple buffers.
What do you think?

My concern is simply that people aren't likely to be using/expecting a 5 kilobyte stack. We need to have some way of capping the amount of stack we'll use... VLAs make that difficult.
Allocating on the heap is slower, but safer.

Just found this link which explain some problems of using VLAs. Dinamically allocated memory can be reallocated with realloc, while VLAs doesn't, the heap memory is usually bigger than stack.

Just found this link which explain some problems of using VLAs. Dinamically allocated memory can be reallocated with realloc, while VLAs doesn't, the heap memory is usually bigger than stack.

Okay, we can update the code to remove VLA. What about my proposal in the above comemnt?

@kisvegabor It should be possible to just dynamically allocate both of the buffers you mentioned at the top of the functions. Is that the same idea you were saying? Sorry, I was a bit confused.

@embeddedt To better demonstrate what I mean I implemented if for shadow drawing. See  071bf4c

@kisvegabor This is great! But it has one flaw. Once the buffer has grown it is never shrunk again for the lifetime of the system's operation.
Imagine that for some reason the buffer became 1 kilobyte due to a large object, and then that object was deleted. The draw buffer would still consume 1 kilobyte for the program's lifetime.
One solution could be to free the draw buffer at the end of lv_refr_task, or at least shrink it to a more reasonable size.

Once the buffer has grown it is never shrunk again for the lifetime of the system's operation.

That's true.

One solution could be to free the draw buffer at the end of lv_refr_task, or at least shrink it to a more reasonable size.

Sounds good. It shouldn't affect the performance too much.
Added here: f806f8c

I've replaced all VLAs here: https://github.com/littlevgl/lvgl/commit/b04367c702f9a07f96518ad461b4856c49162f6f
Here and here I kept the local variables because the draw buffer is already used here.

@kisvegabor Great! I will test it with -Wstack-usage again when I get a chance just to make sure there's nothing we missed.

I will test it with -Wstack-usage again when I get a chance just to make sure there's nothing we missed.

Great!
I've tested the performance on STM32429 Discovery with the benchmark app. With all features enabled:

dev-6.0: 62 ms
vla: 61.3 ms

So surprisingly is seems we have improved the performance too. :)

So surprisingly is seems we have improved the performance too. :)

Strange... I would expect it to be slower because of the extra allocation!
Are we merging vla to dev-6.0 today?

If you agree, yes!

@embeddedt I read your comment again and it seems you are happy with merging it so I've just merged it.

@kisvegabor Hmm, I thought I replied. Anyways, yes, it's fine to merge it.


Following the documentation for minikube deployment doesn't work

Describe the bug
Following the documentation for creating a "Falco Learning Environment" unfortunately does not work. Upon using helm to deploy the Falco and getting this error in the pod logs:
Tue Mar 15 15:25:42 2022: Runtime error: Kernel module does not support PPM_IOCTL_GET_API_VERSION. Exiting.

Workaround
I went on to try a handful of other virtual machine drivers for minikube to no avail. I resorted to the Kubernetes slack where I got help from @terylt.
As it turns out, it seems that there is a script that runs at startup to try and install the kernel module / ebpf probe necessary to get Falco running in the relevant environment. The bash script seems to do some guesswork to determine what operating sytem it is in, then tries to decide the correct approach to install the kernel module / ebpf probe. This does not currently work correctly for minikube.
to get the script to pass through the logic linked here (and hence correctly determine that it is in a minikube vm), the daemonset must be modified like so, after a helm template or a kubectl edit after deployment:
      containers:
        - name: falco
...
          volumeMounts:
...
            - mountPath: /host/etc/VERSION
              name: etc-fs
              readOnly: true
...
      volumes:
...
        - name: etc-fs
          hostPath:
            path: /etc/VERSION

...

The daemonset also needs to have eBPF enabled, as otherwise it continues to fail. This can either be done by setting the env var on the falco pod in the manifest:
          env:
          - name: FALCO_BPF_PROBE

or by enabling eBPF in the helm values file:
ebpf:
  # Enable eBPF support for Falco
  enabled: true

once these two steps have been taken, the pod should turn to a READY state:
NAME                READY   STATUS    RESTARTS   AGE
falco-falco-blfrb   1/1     Running   0          24m

How to reproduce it
Follow the documentation for creating a learning environment with minikube
Expected behaviour
I feel others thoughts might be mixed on this... but to me it doesn't seem unreasonable to request the user to specify the environment they are deploying to (e.g. GKE, minikube, kind etc.) in the form of an env var or a command-line argument. This way, there is no need for a script to exist or be maintained when inevitably, situations arise that break the mechanisms in which the script tries to decipher the environment it is in.
Environment

Falco version:
0.31.1
Cloud provider or hardware configuration:
OS:
Minikube (v1.25.0 - commit: 3edf4801f38f3916c9ff96af4284df905a347c86)
Installation method:
Helm on Kubernetes

Thanks for filing the issue Tom!
Just to add to Tom's issue.  I think the bug is in the falco-driver-loader script in the if statement here: https://github.com/falcosecurity/falco/blob/a5d3663c75f4a1553edb974da07e2b44af7eb3e4/scripts/falco-driver-loader#L104
Falco uses the /etc/VERSION file to detect it is running in minikube.   Unfortunately, it never gets to that check in the if statement above because I think minikube instances also have the os-release file as well, so it pops out of that if statement without detecting it's running in minikube.   The old sysdig-probe-loader script dealt with this by breaking out the /etc/VERSION  check into a separate if statement, which did work, but I'm not sure of the other implications of that.
Also, I think minikube requires ebpf to be enabled, but it doesn't look like that is documented in the docs.

Minikube ships its own Falco pre-built driver (see https://github.com/kubernetes/minikube/pull/6560) since it is impossible to build the driver on the fly for Minikube because it doesn't provide a compiler or kernel-headers.
Unfortunately, the last update in Minikube was two years ago :point_down:  https://github.com/kubernetes/minikube/tree/master/deploy/iso/minikube-iso/package/falco-module
The driver version they ship should work up to Falco 0.30.x, but not with 0.31.1.
We should open a PR in minikube to fix it.

This does not affect only minikube. I have it on Ubuntu 18.04
# cat /etc/os-release
NAME="Ubuntu"
VERSION="18.04.6 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.6 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic
# uname -a
Linux HOST 4.15.0-167-generic #175-Ubuntu SMP Wed Jan 5 01:56:07 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
# journalctl -xe -u falco
Mar 16 09:54:19 HOST systemd[1]: Started Falco: Container Native Runtime Security.
-- Subject: Unit falco.service has finished start-up
-- Defined-By: systemd
-- Support: http://www.ubuntu.com/support
--
-- Unit falco.service has finished starting up.
--
-- The start-up result is RESULT.
Mar 16 09:54:19 HOST falco[37102]: Falco version 0.31.1 (driver version b7eb0dd65226a8dc254d228c8d950d07bf3521d2)
Mar 16 09:54:19 HOST falco[37102]: Wed Mar 16 09:54:19 2022: Falco version 0.31.1 (driver version b7eb0dd65226a8dc254d228c8d950d07bf3521d2)
Mar 16 09:54:19 HOST falco[37102]: Wed Mar 16 09:54:19 2022: Falco initialized with configuration file /etc/falco/falco.yaml
Mar 16 09:54:19 HOST falco[37102]: Wed Mar 16 09:54:19 2022: Loading rules from file /etc/falco/falco_rules.yaml:
Mar 16 09:54:19 HOST falco[37102]: Falco initialized with configuration file /etc/falco/falco.yaml
Mar 16 09:54:19 HOST falco[37102]: Loading rules from file /etc/falco/falco_rules.yaml:
Mar 16 09:54:20 HOST falco[37102]: Loading rules from file /etc/falco/falco_rules.local.yaml:
Mar 16 09:54:20 HOST falco[37102]: Wed Mar 16 09:54:20 2022: Loading rules from file /etc/falco/falco_rules.local.yaml:
Mar 16 09:54:20 HOST falco[37102]: Loading rules from file /etc/falco/k8s_audit_rules.yaml:
Mar 16 09:54:20 HOST falco[37102]: Wed Mar 16 09:54:20 2022: Loading rules from file /etc/falco/k8s_audit_rules.yaml:
Mar 16 09:54:21 HOST falco[37102]: Rules match ignored syscall: warning (ignored-evttype):
Mar 16 09:54:21 HOST falco[37102]:          loaded rules match the following events: access,brk,close,cpu_hotplug,drop,epoll_wait,eventfd,fcntl,fstat,fstat64,futex,getcwd,getdents,getd
Mar 16 09:54:21 HOST falco[37102]:          but these events are not returned unless running falco with -A
Mar 16 09:54:21 HOST falco[37102]: Runtime error: Kernel module does not support PPM_IOCTL_GET_API_VERSION. Exiting.
Mar 16 09:54:21 HOST falco[37102]: Wed Mar 16 09:54:21 2022: Runtime error: Kernel module does not support PPM_IOCTL_GET_API_VERSION. Exiting.
Mar 16 09:54:21 HOST systemd[1]: falco.service: Main process exited, code=exited, status=1/FAILURE
Mar 16 09:54:21 HOST systemd[1]: falco.service: Failed with result 'exit-code'.
Mar 16 09:54:21 HOST systemd[1]: falco.service: Received 0B IP traffic, sent 0B IP traffic
# grep -C2 falco /var/log/apt/history.log

Start-Date: 2022-03-12  13:01:57
Upgrade: dotnet-runtime-3.1:amd64 (3.1.22-1, 3.1.23-1), dotnet-host:amd64 (6.0.2-1, 6.0.3-1), dotnet-hostfxr-3.1:amd64 (3.1.22-1, 3.1.23-1), sosreport:amd64 (4.1-1ubuntu<IP_ADDRESS>, 4.3-1ubuntu<IP_ADDRESS>), dotnet-runtime-deps-3.1:amd64 (3.1.22-1, 3.1.23-1), falco:amd64 (0.31.0, 0.31.1)
End-Date: 2022-03-12  13:02:40

Downgrading to 0.31.0 restores functionality
# apt-get install falco=0.31.0
# systemctl status falco
● falco.service - Falco: Container Native Runtime Security
   Loaded: loaded (/lib/systemd/system/falco.service; disabled; vendor preset: enabled)
  Drop-In: /etc/systemd/system.control/falco.service.d
           └─50-CPUQuota.conf, 50-CPUShares.conf, 50-MemoryLimit.conf
   Active: active (running) since Wed 2022-03-16 10:34:02 UTC; 4s ago
 Main PID: 57182 (falco)
       IP: 0B in, 0B out
    Tasks: 3 (limit: 4915)
   CGroup: /system.slice/falco.service
           └─57182 /usr/bin/falco --pidfile=/var/run/falco.pid

Mar 16 10:34:02 HOST falco[57182]: Wed Mar 16 10:34:02 2022: Loading rules from file /etc/falco/falco_rules.yaml:
Mar 16 10:34:02 HOST falco[57182]: Falco initialized with configuration file /etc/falco/falco.yaml
Mar 16 10:34:02 HOST falco[57182]: Loading rules from file /etc/falco/falco_rules.yaml:
Mar 16 10:34:03 HOST falco[57182]: Loading rules from file /etc/falco/falco_rules.local.yaml:
Mar 16 10:34:03 HOST falco[57182]: Wed Mar 16 10:34:03 2022: Loading rules from file /etc/falco/falco_rules.local.yaml:
Mar 16 10:34:03 HOST falco[57182]: Loading rules from file /etc/falco/k8s_audit_rules.yaml:
Mar 16 10:34:03 HOST falco[57182]: Wed Mar 16 10:34:03 2022: Loading rules from file /etc/falco/k8s_audit_rules.yaml:
Mar 16 10:34:04 HOST falco[57182]: Rules match ignored syscall: warning (ignored-evttype):
Mar 16 10:34:04 HOST falco[57182]:          loaded rules match the following events: access,brk,close,cpu_hotplug,drop,epoll_wait,eventfd,fcntl,fstat,fstat64,futex,getcwd,getdents,getd
Mar 16 10:34:04 HOST falco[57182]:          but these events are not returned unless running falco with -A

# apt-mark hold falco
falco set on hold.

@leogr would it be preferable to just align all minikube installs to the ebpf probe and have the init script download that, as I have done in my workaround? I am unsure as to what the "most supported" method of setting up falco is wrt ebpf/kernel driver though.

@juju4

This does not affect only minikube. I have it on Ubuntu 18.04

Your issue is slightly different. You should be able to install the new driver version by running:
falco-driver-loader --clean

Then
falco-driver-loader

Let me know if that works. Perhaps we will have to improve the documentation regarding that.

no, it didn't fix the issue but made me understand the problem.
# apt-mark unhold falco
Canceled hold on falco.
# apt-get upgrade falco
# systemctl restart falco
# systemctl status falco
 falco.service - Falco: Container Native Runtime Security
   Loaded: loaded (/lib/systemd/system/falco.service; enabled; vendor preset: enabled)
  Drop-In: /etc/systemd/system.control/falco.service.d
           └─50-CPUQuota.conf, 50-CPUShares.conf, 50-MemoryLimit.conf
   Active: activating (auto-restart) (Result: exit-code) since Wed 2022-03-16 22:31:08 UTC; 1s ago
  Process: 27908 ExecStart=/usr/bin/falco --pidfile=/var/run/falco.pid (code=exited, status=1/FAILURE)
 Main PID: 27908 (code=exited, status=1/FAILURE)
       IP: 0B in, 0B out

Mar 16 22:31:08 vps58732 systemd[1]: falco.service: Received 0B IP traffic, sent 0B IP traffic
root@vps58732:~# falco-driver-loader --clean
* Running falco-driver-loader for: falco version=0.31.1, driver version=b7eb0dd65226a8dc254d228c8d950d07bf3521d2
* Running falco-driver-loader with: driver=module, clean=yes
* Unloading falco module failed
* Removing falco failed
root@vps58732:~# falco-driver-loader
* Running falco-driver-loader for: falco version=0.31.1, driver version=b7eb0dd65226a8dc254d228c8d950d07bf3521d2
* Running falco-driver-loader with: driver=module, compile=yes, download=yes
* Unloading falco module, if present
* falco module still loaded, waited 5s (max wait 60s)
* falco module still loaded, waited 10s (max wait 60s)
^C

so kernel modules unloading/loading issue.
And found the issue because for this system, boot ends with disabling kernel modules. rc.local has after doing multiple modprobe, including falco
echo 1 > /proc/sys/kernel/modules_disabled

I did a reboot to confirm and new version is working after.
strangely, not seen this issue after past upgrades and this setting is not new.
sorry for the mix. yes, different issue.

Oh yeah, there are cases where falco-driver-loader can't unload the driver. Consequently, it cannot install the new driver version. We should improve our documentation about that.
This issue happened with Falco 0.31.1 because we introduced a mechanism to detect incompatible driver versions, and this specific Falco version requires a new driver version. Combining these two factors produced the issue, which does not usually happen.

We also experience this issue: Runtime error: Kernel module does not support PPM_IOCTL_GET_API_VERSION. Exiting.
We build the driver through driverkit-builder, load the module successfully and start Falco. When using falco 0.31.1 it croaks with the above message. When using Falco 0.31.0 it works fine.
This happens on nodes where it replaces the old Falco instances (0.29.1) but also on clean nodes that did not have any modules loaded before this new version (0.31.1) started. Unloading modules cannot be the cause there. Version 0.31.0 does not show this problem.

We build the driver through driverkit-builder, load the module successfully and start Falco. When using falco 0.31.1 it croaks with the above message. When using Falco 0.31.0 it works fine.

Note that 0.31.1 has a newer driver (ie. kernel module) version than 0.31.0.

This happens on nodes where it replaces the old Falco instances (0.29.1) but also on clean nodes that did not have any modules loaded before this new version (0.31.1) started. Unloading modules cannot be the cause there. Version 0.31.0 does not show this problem.

AFAIK, the problem arises when an old driver is already installed and loaded. Basically, when one previously installed an older version and then installs the 0.31.1, the old driver remains up and running and Runtime error: Kernel module does not support PPM_IOCTL_GET_API_VERSION. Exiting. is returned.
The workaround is to uninstall the old driver manually before installing the 0.31.1.
PS
Falco 0.32.0 (not yet released) will come with a fix that forces the driver uninstallation when upgrading to a newer version.

/milestone 0.32.0

/remove-milestone 0.32.0 /milestone 0.33.0

Hey @jasondellaluce
This issue should be actually fixed by 0.32.0
I know @alacuku had the same issue and is testing. Has 0.32.0 worked for you on minikube? Please let us know :)

Hi @leogr, here are my findings on Falco and Minikube.
The issue is still present even with Falco 0.32.0. That's because the latest version of minikube v1.25.2 ships with the 85c88952b018fdbce2464222c3303229f5bfcfad version of Falco kernel module. It works fine with Falco 0.31.0 but not with later versions of Falco.
Minikube developers have already bumped version of Falco to 0.31.1 (https://github.com/kubernetes/minikube/commit/69fb8c243256d407402d754bfa562a38aa794129) but we need to wait for the next release of Minikube for that.
There are two options in order to use the latest version of Falco with Minikube:

We start to offer prebuilt driver modules for the Minikube kernels;
The end users build their own Minikube iso image with the latest Falco driver module.

Seeing this still with 0.32.0 and Ubuntu 20.04.2 LTS on 5.4.0-1038-aws #40-Ubuntu kernels. It seems to have worked on a few of our nodes but not in any easily observed pattern.

Hey @jrabbit
Could you share more detail pls?

Meanwhile, I've opened a PR in minikube to bump Falco to 0.32.0 :point_right:  https://github.com/kubernetes/minikube/pull/14329

Seeing this still with 0.32.0 and Ubuntu 20.04.2 LTS on 5.4.0-1038-aws #40-Ubuntu kernels. It seems to have worked on a few of our nodes but not in any easily observed pattern.

Hey @jrabbit Could you share more detail pls?

So we're on a full 1.19 K8s cluster so it might be a different bug but we're having trouble getting the script or manually to unload the falco kernel mod. Strangely it seemed like falco kept spawning binaries (which then access the module, blocking rmmod) when the pods were unscheduled? (Maybe this is a k8s quirk i'm not used to?). Let me validate if the nodes that succeeded were ones that were freshly spun up (and thus wouldn't have falco kernel mods to remove) and get back to you w/ that.

e: So the nodes that do have working pods aren't new, the others are in restart loops with errors in dkms and Mon Jun 13 15:54:57 2022: Runtime error: Kernel module does not support PPM_IOCTL_GET_API_VERSION. Exiting. at the end. May help to know the nodes are kops provisioned and have similar os package state. Also installed via helm w/ latest which may complicate things?

This issue should be fixed in Falco 0.32.0. Have you tried to upgrade?

Got falco working according to @ChaosInTheCRD workaround but had to also delete SKIP_DRIVER_LOADER environment variable in falco container.

cc @alacuku
Should this be fixed now? Should we have to update the documentation somewhere?

cc @alacuku Should this be fixed now? Should we have to update the documentation somewhere?

Yes, it should be fixed now. I'm waiting for 0.33.0 falco release in order to update the docs and eventually close the issue.

cc @alacuku Should this be fixed now? Should we have to update the documentation somewhere?

Yes, it should be fixed now. I'm waiting for 0.33.0 falco release in order to update the docs and eventually close the issue.

@alacuku Thank you! :pray:
Please put Fixes https://github.com/falcosecurity/falco/issues/1941 in the falco-website's PR you will open, so we both track and automatically close this once you have done with the docs.


Use Ollama/deepseek-coder:6.7b show LiteLLM:ERROR

Issue
I Installed Aider in Anaconda Env and connect Local ollma deepseek-coder:6.7b.
export OLLAMA_API_BASE=http://<IP_ADDRESS>:11434
aider --model ollama/deepseek-coder:6.7b
but when I use it always show LiteLLM:ERROR like This. Even though I just used a --help command.

who can tell me how to resolve it.
Version and model info
Aider v0.45.1
Model: ollama/deepseek-coder:6.7b with whole edit format
Git repo: .git with 0 files
Repo-map: disabled

This looks like a duplicate of #883, so I'm going to close it so discussion can happen there. Please let me know if you think it's actually a distinct issue.


Error: "Cannot find News table" in news example

The error occurs because of parsing error of table elements
Error: "Cannot find News table"

The layout may be changed.
Made it works by the merge request

Thanks for the fix. There is also another error coming from new table class name and I've fixed it in the latest version 0.3.2.


disabling does not work

Hi,
if you disable the select with:
document.getElementById('example').disabled = true;

it does not work.

I currently don't have the spare time to maintain this project. In the meantime, you can use the following method:
document.getElementById('example').classList.remove('d-none')
document.getElementById('example').disabled = true

// Then reinitialized
UseBootstrapSelect(document.getElementById('example'))

In v2 you can do this:
const target = document.getElementById('example')
const example = new UseBootstrapSelect(target)

target.disabled = true
example.update()

Thanks for your work.


XSS in documentation

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar.
"Because we have introduced more code that relies on user generated content (UGC) and input, we have increased our attack surface area for our application."
<script>
    window.__PRELOADED_STATE__ = ${JSON.stringify(preloadedState)}
</script>

Suppose
preloadedState = {deepInState: {someUserInput: "</script><script>alert(1);</script>"}};

What is the current behavior?
XSS.
What is the expected behavior?
No XSS.
Which versions of Redux, and which browser and OS are affected by this issue? Did this work in previous versions of Redux?
Documentation issue. 684 github code search results, mostly with same bug.

Already fixed in master 20 days ago. Why it is not online?

The docs aren't automatically republished on commits - it's a manual process.  @timdorr 's been the one republishing docs lately.  (I did do it once or twice, but haven't tried in a while, and the current publish script makes a couple assumptions about running on Linux while I'm on Windows, so it took some effort to make it happen.)

@timdorr, could you publish new docs, please?
@markerikson With all my respect, such situations make me suspicious if I will be informed when some serious security issues will be found that do affect my code. Luckily I'm a big fan of OWASP, but there're thousands of other users that have a huge security issue, they're not informed, and their numbers are counting. I would not only fix docs the day the issue was found, but draw some users' attention. Could you ask if, for example, Dan can talk on this in his twitter?

It's been published. Sorry about that!


docs: remove reference to IPFS

Docs Only: Temporarily remove an outdated/incorrect reference to IPFS as storage component.
I'm sure better updates will be made in the near future but opening this in the meantime!

We don't have a concept of StateView anymore and I feel we need to consider Drive as a replicated state machine for Platform rather than just storage. Maybe @dalibran or @thephez could help us with description?


Print npm output, handle exit code in case of errors

If npm returned an error, the marker "updated" was created anyway, preventing update from being executed again. Also, npm failures were silent.
This pull request handles npm failures a bit better, printing diagnostic output and catching the exit code.

Thanks Toni.


event - add support for sending events via SQS

add support for sending events via SQS

implemented in https://github.com/stellar/java-stellar-anchor-sdk/pull/209


Finalize UX for non-exec languages

Let's think about what to display/show here prior to release:

https://github.com/stateful/vscode-runme/pull/630


Fix iOS widgets

AppBar and PageRoute.

Cupertino components have a lot of problems. No TextFormField, no validation. Poor work with dark theme (black text on black page). Waiting for next releases of flutter.


BUG: Icons in Navigation Bar Not Visible in Dark Mode

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
When switching the app interface to dark mode, the icons in the navigation bar become invisible or blend into the background, making navigation difficult for users. This issue affects the usability of the app significantly in low-light environments or when users prefer darker themes. The icons should maintain visibility and contrast appropriately regardless of the selected color scheme to ensure a seamless user experience across different modes.

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Its-Aman-Yadav @Kalivarapubindusree Please assign me this issue


Added zero line to data, noughitified data

Remove or leave noughtify function?

Altering this commit, due to lack of obvious need.


Opening SwipeRow programatically

Hello!
I wanted to know if there is a way for opening the SwipeRow programatically. I need to manually adjust leftOpenValue and rightOpenValue, because my hidden content width is dynamically changing. Once I open the row with leftOpenValue=100 and rightOpenValue=-100 it doesn't seem to be possible to swipe it back to leftOpenValue=50 and rightOpenValue=-50.
I am able to close row programatically, as SwipeRow gives me the closeRow method:
export class SwipeRow<T> extends Component<Partial<IPropsSwipeRow<T>>> {
	closeRow: () => void;
	closeRowWithoutAnimation: () => void;
	render(): JSX.Element;
}

But that's not exactly what I'm looking for. I don't need to close it, just slide an opened row from 100 to 50.
Is there any way to do this? :)
Here is a vid that may give a notion of my problem:

I am using only SwipeRow, not the SwipeListView :)
Thank you very much for your incredible work :) It works smoooooth like butter :) :) :)

Hey @ochrostowska this is a bit untested but instead of using swipeRow.closeRow() try using swipeRow.manuallySwipeRow(value) in your case I think something like swipeRow.manuallySwipeRow(-50)
LMK if that works for you

I've read your answer in previous issues mentioning manuallySwipeRow  function, but I dont have   available for SwipeRow... Do I have some deprecated dependency? It seems I can call only declared functions:
export class SwipeRow<T> extends Component<Partial<IPropsSwipeRow<T>>> {
	closeRow: () => void;
	closeRowWithoutAnimation: () => void;
	render(): JSX.Element;
}

These are the suggestions IDE is giving me:

manuallySwipeRow(value) cannot be found:

current is SwipeRow reference

Hey @ochrostowska sorry for the delay. I think the IDE is complaining because it is using the types from types/index.d.ts which was an open source contribution that doesn't have manuallySwipeRow function declared in it. I'm hesitant to add it to types because it's not really supported functionality (though a PR is always welcome if you'd like to add it)
But I have tested using manuallySwipeRow in my own code. As long as you have a valid ref to the SwipeRow it should work :)
Were you able to give it a try?

It is working when js debugger is enabled, but in release build the process hanged and app is not responding.Any idea why?

Closing as I believe this was solved


Cannot work with streams files

In many cases file path + mtime is enough to take from cache.
Why does the plugin force to read the file? That counters performance.
gulp.src('**/*.js', {read: false}) should be cacheable, why not?
file.path + file.mime -> cache?
  -> yes -> get content and all needed from cache
  -> no -> populate content and process it

Cannot work with streams/null files? Why?

I don't see any benefits to cache null vinyl objects, which are directories.

You cache not the null objects. You cache the result of it's processing. The processing reads them and populates.
gulp.src('**', { read: false })
  .cache( stream which reads and processes files and returns the result, { options } )

I really have no clue how to make it even more obvious.

I haven't prioritized streams because I didn't have a use case for it.  Your examples seem contrived, can you give an actual example of something you can safely cache based on file.path and file.mime alone?  Seems like the contents of those files would affect the output of any proxied task that I can think of.

@jgable: most of stuff. if same file is not modified, then can take from cache, isn't that obvious? :1234: )

Closing for the lack of useful feedback and impoliteness of the issue reporter.

This is my assertion: You cannot for certain know whether the file is the
same without checking the contents. I have asked for a situation where that
assertion could be proven wrong and your only reply is "it's obvious". This
is unproductive.
On Thu, Mar 17, 2016 at 7:36 AM Shinnosuke Watanabe <
<EMAIL_ADDRESS>wrote:

Closing for the lack of useful feedback and impoliteness of the issue
reporter.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/jgable/gulp-cache/issues/52#issuecomment-197906421

Dear Sirs,
In my experience many caches rely on that assertion. Can be disabled for some rare cases, but mostly true.
I'm very sorry if my response appears impolite. I mean no offense to anyone.
The module is yours, I only tried to make it better by suggesting the optimizarion that I think is good.
With all respect for your work in the field of open source.
Ilya

You still have not given a single concrete example of a scenario where you
could reliably cache a task based only on the file name and mime type. I
don't think you really understand the functionality of this plugin.
On Thu, Mar 17, 2016 at 10:41 AM Ilya Kantor<EMAIL_ADDRESS>wrote:

Dear Sirs,
In my experience many caches rely on that assertion. Can be disabled for
some rare cases, but mostly true.
I'm very sorry if my response appears impolite. I mean no offense to
anyone.
The module is yours, I only tried to make it better by suggesting the
optimizarion that I think is good.
With all respect for your work in the field of open source.
Ilya
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/jgable/gulp-cache/issues/52#issuecomment-197993748

@jgable Let's consider compilation for example. The task is to compile the file by TypeScript (CoffeeScript whatever) compiler.
Wouldn't it be sane to reuse the previous result if the same file is unchanged?

In order to tell whether the file has changed, you would need to look at
the contents and compare what it was before.
On Fri, Mar 18, 2016 at 1:38 AM Ilya Kantor<EMAIL_ADDRESS>wrote:

@jgable https://github.com/jgable Let's consider compilation for
example. The task is to compile the file by TypeScript (CoffeeScript
whatever) compiler.
Wouldn't it be sane to reuse the previous result if the same file is
unchanged?
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/jgable/gulp-cache/issues/52#issuecomment-198256482

What about file.stat.mtime?
https://github.com/gulpjs/vinyl#optionsstat
https://nodejs.org/api/fs.html#fs_class_fs_stats
It contains the last time the file was modified. Store that value and if it doesnt change the next time the task is run the cached result can be used.

Seems plausible as a reasonable default implementation. I'm still skeptical
it'll be consistent.
Put a PR together with some tests to feel it out.
On Fri, Mar 18, 2016 at 1:43 PM Sam Genest<EMAIL_ADDRESS>wrote:

What about file.stat.mtime?
https://github.com/gulpjs/vinyl#optionsstat
https://nodejs.org/api/fs.html#fs_class_fs_stats
It contains the last time the file was modified. Store that value and if
it doesnt change the next time the task is run the cached result can be
used.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/jgable/gulp-cache/issues/52#issuecomment-198534504

You use a single cache file per original file, right?
So, if the file mtime is not newer than the cache mtime, then that's it. No need to store anything, you already have it.
That allows to speed up things a lot. File linting, file compilations, a lot of other stuff.


[HOLD #14982] Dev: sending the same amount of money twice causing  console ERROR  Warning: Encountered two children with the same key

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to report screen
Send money to the user (e.g. $100)
Send same amount of money again to the same user (e.g. $100)
Press on the IOU Preview

Expected Result:
There should not be any warning of same key
Actual Result:
Getting an warning of Encountered two children with the same key
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] iOS / native

Version Number: 1.2.67-1
Reproducible in staging?: Happening in Dev
Reproducible in production?: Happening in Dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/217659236-7771efde-7adb-44ed-885f-706fac66022b.mov
Expensify/Expensify Issue URL:
Issue reported by: @jayeshmangwani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1675806708961009
View all open jobs on GitHub

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Came across this duplicate bug in the IOUDetails screen when trying to execute this one.

Asked here about the dev error that Jayesh is seeing. I think it's probably related to why we're seeing dupe send money requests.

Jayesh confirmed this console warning is only happening on dev. I think it's related to this: https://github.com/Expensify/App/issues/14982
@mountiny I don't suppose you could hip check me here before I close it out?

Yes, done it for ya

Still held.

Still held.

Okay so yep, this was the console error for the duplicate bug, so I'm going to close it.


Fix PR/issue redirects when having external tracker

Missed a vital part in #9247, pull requests shall not be redirected to external tracker :sweat_smile:
Also I went through other redirects to ensure they use correct link (use the  HTMLURL function).

I'm working on the failing tests.

I reverted using HTMLURL redirect for NewIssuePost as it is anyhow always issues. The redirect didn't seem to work properly, maybe not all variables was initalized yet.

Codecov Report

Merging #9339 into master will increase coverage by <.01%.
The diff coverage is 62.5%.

@@            Coverage Diff             @@
##           master    #9339      +/-   ##
==========================================
+ Coverage   41.26%   41.26%   +<.01%
==========================================
  Files         561      561
  Lines       73433    73440       +7
==========================================
+ Hits        30301    30305       +4
- Misses      39339    39342       +3
  Partials     3793     3793

Impacted Files
Coverage Δ

routers/repo/issue_watch.go
0% <0%> (ø)
:arrow_up:

routers/repo/issue_dependency.go
0% <0%> (ø)
:arrow_up:

routers/repo/issue.go
36.99% <76.92%> (+0.09%)
:arrow_up:

modules/log/event.go
64.61% <0%> (-1.03%)
:arrow_down:

modules/indexer/issues/indexer.go
63.79% <0%> (-0.12%)
:arrow_down:

modules/notification/indexer/indexer.go
50.72% <0%> (+0.72%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2fe98...acf5b5e. Read the comment docs.


Integrate folders

_Hi, I am trying to include folders that my program uses but, I have found that they can only be added manually.
Is there any way to add them during compilation?
I tried to use this but it didn't work for me

nuitka --standalone --plugin-enable = qt-plugins --windows-icon-from-ico = favicon.ico --windows-disable-console --include-data-file = img / *. svg = interface / * .ui * .py = constants / *. py player.py_

Example:
--include-data-file=E:\Test1\Test2\icons\*=icons\
Attach all files from a folder to a folder.

What @Pro100rus32 said is spot on, thanks.

Sorry if I ask again. I have already been testing and it still gives me an error ... I attach a photo of my project so that you have a clearer idea of the folders that I have to include


Add --bug-report option to frontend (and llvm-backend)

The Haskell backend kore-exec has the --bug-report BUG_NAME option which generates a tarball containing all the inputs needed to reproduce an execution on a definition. This includes:

A vdefinition.kore file which is the definition the backend sees.
A spec.kore file which is the initial configuration to execute or prove from.
A kore-exec.sh script which contains exactly the kore-exec command to invoke to reproduce the issue.
The output.kore file which the run produces.
Any supporting files needed as inptu to the backend (eg. the smt prelude)

It would be nice to have the same option in the LLVM backend and to expose this to the frontend directly as a feature.

@ttuegel says you can set environment variable to generate bug report KORE_EXEC_OPTS="--bug-report kevm-$SPEC_NAME". So maybe this is not needed to simplify out KEVM and KWasm runner scripts.


Update snippets for NRT

Contributes to #27310
Hide whitespace when reviewing - changing to file-scoped namespaces changes indentation, which makes it look like the whole file was changed if you don't hide whitespace.

Thanks for the review @gewarren !


Question: Does CRA cover runtime typechecking with flow?

Hi,
Does CRA provides warnings where we use flowtype (props) only and not Proptypes at runtime?

Please see the relevant section of the docs: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#adding-flow.

I am aware of that docs,  and it is working for me. it checks as it suppose to check. But works only at compile time. Was asking if there is a solution for runtime checking.

There is no runtime checking solution at the moment. It will be available when 0.10 is released.

OK, I can see it https://github.com/facebookincubator/create-react-app/pull/1152


Parse  variable

When i parse a variable Mode LR example variable X=test.ts:80
I want to parse X to be without :80 i put Right string ":" and is come test.ts and is ok but when i have X=test.ts and no :80 the variable is not save in new one with the same value how is X

If you use LR with right string ':' and there's no ':' of course it won't parse it. This is not a bug.

Ok i know this but if not have nothing to parse i want he take the value of first variable because new variable come empty be nice he take the value of first variable


Change Keyring construction to make it constant

This allows code doing things like:
const KEYRING: Keyring = Keyring::new(service, username);

@jaysonsantos Why do you want to have an entry be a constant?

With the revamp of #70 that we're about to release, it's unlikely that keyring can be constants, so I'm going to close this PR.  @jaysonsantos if you feel this is important functionality, can you please submit an issue giving the rationale for why it's needed?  Thanks!


io.write(..., compress=True) increases file size

General

pyfar version: 0.6.9
Python version: 3.11.9
Operating System: Ubuntu 23.10
Did you install pyfar via pip: yes

Description
Hi guys,
I noticed that instead of compressing the data, pf.io.write() produces much bigger files when using compress=True.
I tested this with a sine signal. The behavior is consistent for long and short signals and single-channel as well as multi-channel audio.
When using noise, the difference decreases but the compressed file is still larger than the uncompressed one.
What I Did
import pyfar as pf

signal = pf.signals.sine(frequency=1000, n_samples=44100, amplitude=1, sampling_rate=44100)

pf.io.write('signal_uncompressed', signal=signal)
pf.io.write('signal_compressed', signal=signal, compress=True)

signal_uncompressed.far is 383.4 kB, while signal_compressed.far is 706.7 kB.

Thanks for reporting. Seems like its beeing compressed if compress=False and vice verca.
It should be fixed in #707


Wrong P-Code for "67 E8" on x86-64

The P-Code generated for call instructions with the byte sequence 67 E8 xx xx xx xx (a call with a addr32 prefix) seems to be wrong for x86-64 binaries: Ghidra generates something like
RSP = INT_SUB RSP, 4:8
STORE ram(RSP), 0x10433f:4
CALL *[ram]0x105390:8

but the size of the return address pushed onto the stack is still 8 bytes and not 4. In other words, Ghidra seems to misinterpret the effect of the 67 prefix on the call instruction, since it actually has no effect in this situation (as far as I can tell). I confirmed the different actual behaviour of the instruction with gdb on my computer.
Tested with Ghidra version 9.2.2 DEV.

I just want to confirm/clarify what you're stating. The return address pushed onto the stack here should be 8 bytes, not 4. Which is what the processor manual states is the correct behavior.
The behavior on the actual call instructions seems to be correct, but the instruction info seems to suggest that the 67 prefix is setting addrsize=1 rather than addrsize=2, and the actual instruction being executed is the 32-bit one. So I suspect it might be an issue with how the addrsize context value is being set.

Yes, the return address pushed onto the stack here should be 8 bytes, not 4.
The relevant section of the processor manual (taken from here, page 130 (170 in the PDF)) seems to be the following:
In all cases, the rIP of the instruction after the CALL is pushed on the stack,
and the size of the stack push (16, 32, or 64 bits) depends on the operand size of the CALL instruction.

For near calls in 64-bit mode, the operand size defaults to 64 bits.
The E8 opcode results in RIP = RIP + 32-bit signed displacement
and the FF /2 opcode results in RIP = 64-bit offset from
register or memory. No prefix is available to encode a 32-bit operand size in 64-bit mode.

So no prefix can change the addrsize for the instruction in 64bit mode. That the 67 prefix is allowed nevertheless, but with no effect on the instruction, seems to be a legacy issue. But it is generated by standard compilers (for padding I suppose).


AIR [PCSG00940]

Game summary

Game name: AIR
Game serial: PCSG00940
Game version: 1.00

Vita3K summary

Version: v0.1
Build number: 1063
Commit hash: https://github.com/vita3k/vita3k/commit/deff8367

Test environment summary

Tested by: Zangetsu38
OS: Windows 10
CPU: AMD Ryzen 2700X
GPU: NVIDIA GTX 1080 Ti
RAM: 16 GB DDR4 3600 mhz

Issues

Stop boot with Mutex error

sceKernelSignalLwCondAll returned SCE_KERNEL_ERROR_LW_MUTEX_RECURSIVE (0x80028182)

Log
vita3k.log

Vita3K summary

Version: v0.1.4
Build number: 2400
Commit hash: https://github.com/vita3k/vita3k/commit/7cf07fb1

Issues

music and voice missing, using LibAtrac with PartlyDecode missing

Screenshots

Log

now Playable with audio

crashes when surface_sync is on


When items are inactive, should they display in summary data?

I encountered this while doing #1030
Situation 1

Create an item
Create a donation with a non-zero quantity
Delete the item; it has_history? so it will just be marked inactive

Should this quantity appear in reports?
I don't know how explicitly our existing queries consider these items, especially on the dashboard reporting. I think it ignores them but I'm not 100% sure.
Situation 2

Create an item
Create donation with non-zero quantity
Delete the item; it has_history? so it will be marked inactive

Should the donation that was created still display in "Recent Donations" on the dashboard? I'm assuming it should appear in the total Donations#index because that's a more exhaustive record of activity.
We do not currently check for whether or not an Itemizable object has any quantity before displaying it. I believe the AR query for this would be more complicated, as well.

@armahillo yes -- if there is/was a physical donation then the donation should show up, IMO. Now that the default scope is gone this should happen already.


More details on training on Visual Grounding

You've done great work, but there are no training details for Visual Grounding in this code. So can the author provide more details about the training and testing of Visual Grounding?

We have provided the details about the training of grounding in the experiments. Please refer to the experiments/baseline_base_grounding.yaml


Section 508 502.3.1: (devenv/button '') The Name property of a focusable element must not be null.

“Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”
GitHubTags:
#A11yMAS; #A11yTCS; #Win32; #DesktopApp; #Feature-ML.NETModelBuilder-Win32-Nov2020; #A11ySev2; #NonBenchmark; #Visual Studio; #A11yAuto; #WCAG4.2.1;
Environment Details:
Microsoft Visual Studio 2019 Preview Version 16.8.0 preview 6.0
Repro Steps:
1.Open Visual Studio Enterprise 2019 Preview
2. Create a new .Net Core Console App (C#)
3. Tab to "Solution Explorer" and right click on the project (Shift + F10) and then from the expanded list Select "Add" and then from the list items select "Machine learning"
4. Select "Recommendations" scenario and press enter
5. Tab till "Next" button and press enter
6. Select file as input data source and Select the file that has your data
7. Select the column you need to predict and then navigate to "Next Step" and press enter
8. Run Accessibility Insights for Windows and Verify whether Name is given for  buttons present in the window
App:
devenv
Element path:
button ''
Issue Details:
The Name property of a focusable element must not be null. Section 508 502.3.1
How To Fix:
Provide a UI Automation Name property that concisely identifies the element.
This accessibility issue was found using Accessibility Insights for Windows, a tool that helps debug and find accessibility issues earlier. Get more information and download this tool at https://aka.ms/AccessibilityInsights.

@zewditu @beccamc
Verified the bug in the latest build and the issue still re-pros.
Microsoft Visual Studio Enterprise 2019 Preview
Version 16.9.0 Preview 4.0

Removing the ready to review tag until we have a build for all of these issues

Build https://devdiv.visualstudio.com/_apis/resources/Containers/7343454/VSSetup?itemPath=VSSetup%2FMicrosoft.ML.ModelBuilder.vsix

Verified the bug in latest build and the issue is fixed. Hence closing the bug
Microsoft Visual Studio Enterprise 2019 Preview
Version 16.10.0 Preview 1.0

Github tag : #Closed;


Added faction Elysium

Description

Adds content of Elysium faction

Testing

downloading the module and testing it is the way to go.

Outstanding Work

[ ] If there is work still outstanding, please include it here
[ ] if there is nothing outstanding, remove this section.

Notes

Include any extra notes here

Pre Pull Request Checklist:

[ ] Code has been scanned with SonarLint
[ ] Methods have been annotated with @ Nullable and @ Nonnull (Read more)
[ ] There are no errors present in the project
[ ] Code has been formatted and indented
[ ] Methods have appropriate Javadoc (How to write Javadoc)

Can one of the admins please verify this patch?

Your medium ship works in-game. Tested locally, collision meshes are flawless.


USB Host: Can't claim interface on a configuration descriptor other than 1 (IDFGH-9669)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
I am developing a program that uses the ESP32 as a USB host. However, I ran into an issue when trying to switch to another configuration descriptor. As the API reference states:

During enumeration, each device is configured to use configuration 1.

But I need to be able to use configuration 4 for my device and interact with its endpoints. I could not find any function that sets the configuration, so I used USB_SETUP_PACKET_INIT_SET_CONFIG to create the control transfer setup packet and sent it to the device. I verified that the device changed its configuration. However, usb_host_get_active_config_descriptor doesn't update, it still references configuration 1 (since it was cached on enumeration). Thus when I run usb_host_interface_claim it fails with the error ESP_ERR_NOT_FOUND because the usb_host_interface_claim function claims the interface on the configuration that is stored in the internal cache.
In summary, the problem I'm facing is that the ESP32 is unable to claim interfaces that are on a configuration other than 1.
There is a function in the API that does exactly what I need (usbh_hub_enum_fill_config_desc). However, that function is part of the internal usbh.c api and so I am not able to call it from my code. A solution I thought of was to write a function called usb_host_set_active_config_descriptor or usb_host_set_config_descriptor in the usb_host API that both sends the control transfer to the device to change its configuration and also updates the internal cache using the usbh_hub_enum_fill_config_desc function. I would be happy to create a pull request if that sounds like a good solution!
Thank you so much for all of your guys's help!

@maxslarsson  Thanks for reporting this issue. Using other configuration isn't currently supported yet by the USB Host stack.
As a quick workaround, does changing the ENUM_CONFIG_INDEX in hub.c to 3 work (it should basically lock the selected configuration to 4 for all devices at compile time).
Supporting run time configuration change won't be trivial as we need ensure that all other clients are not using the same device (i.e., we should not reconfigure the device if there is another class driver using that device). But this feature is on our roadmap.

Thank you for you response! Unfortunately, my code checks all the config descriptors for the right one and therefore needs to set the configuration descriptor at runtime. However, I only have one class driver and so I don't need to check if another class driver is using that device. So is there a good workaround given that I am only going to have one class driver?
The workaround I am thinking of using is to make the usbh_hub_enum_fill_config_desc function public through the usb_host.h file. However, I would love to contribute to the project in any way that I can. Is there any way runtime configuration descriptor could be supported?
Another workaround I came up with is to specify the configuration descriptor when opening the device. So for example modifying the usb_host_device_open function to take another argument that is the configuration descriptor to open on enumeration. However, I wasn't able to fully track the device enumeration process (where the entire state machine in hub.c runs and the device configuration 1 is opened). It seemed to happen automatically when the device is connected (before the usb_host_device_open function is called) which would mean that this would not possible. Is there any chance that I missed it and it occurs when usb_host_device_open is called? But does this face the same issue of not ensuring that all client drivers are using the same configuration for the device?

Hello @maxslarsson
A new feature - setting a device configuration during enumeration was implemented by this commit in esp-idf, also a chapter in documentation was added explaining the feature. The feature has been added to our USB Host Lib example to present it's usage.
Now, a user is provided with a device descriptor via a callback function and has an ability to set a configuration of a device during the device enumeration.
In addition, there is an ability to filter through attached USB devices and choose which device to enumerate and which one not to. However, changing a configuration during run time, as already mentioned, still has not been implemented, but it is planned.


Static badge with data url logo doesn't work on GitHub if set as srcset attribute of <source> tag

Are you experiencing an issue with...
shields.io
🐞 Description
Setting static badge inside srcset of <source> doesn't work:

 />

If set as src in , it does work:

Screenshot:

🔗 Link to the badge
https://img.shields.io/badge/Open Hub-white.svg?logo=data:image/svg%2Bxml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxOSAxMyI+PHRleHQgeT0iMTIiIGZpbGw9IiM1YTJhODEiIGZvbnQtZmFtaWx5PSJOaW1idXMgU2FucyBOYXJyb3ciIGZvbnQtd2VpZ2h0PSI4MDAiPk9IPC90ZXh0Pjwvc3ZnPg==
💡 Possible Solution
No response

This is true in a GitHub issue, but if you put
<picture>
  <source srcset="https://img.shields.io/badge/Open%20Hub-white.svg?logo=data:image/svg%2bxml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxOSAxMyI+PHRleHQgeT0iMTIiIGZpbGw9IiM1YTJhODEiIGZvbnQtZmFtaWx5PSJOaW1idXMgU2FucyBOYXJyb3ciIGZvbnQtd2VpZ2h0PSI4MDAiPk9IPC90ZXh0Pjwvc3ZnPg==" />

</picture>

in a HTML file it works as expected.
If you look at what GitHub is actually rendering in those two cases, it is
<source srcset="..." data-canonical-src="https://img.shields.io/badge/Open%20Hub-white.svg?logo=data:image/svg%2bxml;base64">

and

so there is something stripping the part after the comma in the first case, but it is not us.
This isn't something we can do anything about.

OK. Cheers for following up. If it has been acknowledged as a problem on GitHub's side, I think we can close this one here.


Update markerWithlabel to fix onRemoveChild issue.

PLEASE CHECK "Allow edits from maintainers"

FOLLOW "Conventional Commits Specification" FOR ALL COMMITS
https://conventionalcommits.org/

In previous version 2.0.1 of markerwithlabel, there were no validations added while unmounting the markerwithlabel.  after updating it  the issue has been resolved.

@anudeep1426  thank you for the findings. But there's already a PR made against this issue #894

@sakhisheikh , Yeah i see you also have a pull request for the same issue. okay then we can close this with reference to that issue. thanks.


Modifying the vector style in the selected state does not save the style after deselection.

There is a vector on the map with a style called style1. I added a Select event on the map and set the selected style as style2, which means the style of the selected vector will change to style2. If I now modify the selected vector's style to style3, a problem arises. When I deselect the current vector, the vector's style changes back to style1, but I want to keep it as style3.

Specify null as the Select style and use the select event to set and restore styles only if you wish to change them.


'getMatchHistory' results in 'Undefined offset'

Notice: Undefined offset: 403 in [ ... ] \ php-riot-api.php on line 324

ok, so I added the error (403 - Access Denied) to the code. It shouldn't throw that error in the error exception handler now. Your problem seems to be with your credentials though if you're getting that status code.

I fixed it by tweaking your script's function "getMatchHistory".
Riot seemed to have changed "matchlist" to "recent", worked for me.

Hello, I wanted to share how i solved this problem.
on line 100 of php-riot-api.php(134 of github) there is the following line of code:
$call = self::API_URL_2_2  . 'matchhistory/' . $id;
I changed this code to the following:
$call = self::API_URL_2_2  . 'matchlist/by-summoner/' . $id;
after making this change I no longer experience this issue. I think it should be safe to update your api with this new code. It seems that riot must have changed the url in the api.

ok ive updated the library with that code, thanks! (in the future, feel free to submit a pull request)


Fix LDouble.to_int

long double must be casted to intnat first, not to uintnat directly. Otherwise the conversion is undefined behavior for nearly all negative values, see: http://c0x.coding-guidelines.com/<IP_ADDRESS>.html , Note 50.
The code was correct until https://github.com/ocaml/ocaml/commit/24c118d7b63cdab58ed9bad28e2d337e9d1d30ba
. It seems to work as intended on x86 platforms and the CI for ARM still uses OCaml 4.02.3.

Thanks!  This is an interesting bug and an unexpected consequence of the Val_long change (/cc @gasche, who might also be interested).


NUKE no longer publishes CHANGELOG.md notes to GitHub Release

Since merging https://github.com/akkadotnet/Akka.Hosting/pull/74 GitHub Release flows no longer propagate the release notes typed into CHANGELOG.md into GitHub Releases - we noticed this yesterday with https://github.com/akkadotnet/Akka.Hosting/releases/tag/0.4.0. The release notes for 0.4.0 were auto-generated by GitHub itself, rather than using the notes that @Arkatufus typed up. This is a regression that needs to be fixed in this project and in all of https://github.com/petabridge/petabridge-dotnet-new that have been upgraded to the latest NUKE.

Looks like NUKE captures the first line of RELEASE_NOTES.md but nothing else.

Looks like this was always an issue with NUKE build, so never mind.


Add handling for special visibility string M1SM as less than one

Add handling for special visibility string M1SM as less than one
Spotted in a METAR string, M1SM should be parsed as "visibility less than one statute mile".
A search shows references to this string. For example, this page uses M1SM example of "M" as a prefix standing for "less than":
https://wiki.ivao.aero/en/home/training/documentation/METAR_explanation
Checklist

[x] Tests covering the new functionality have been added
[x] Documentation has been updated OR the change is too minor to be documented
[x] Changes are listed in the CHANGELOG.md OR changes are insignificant

I actually ran into some other visibility strings prefixed with "M" or "P", so I took a stab at implementing generic M-as-less-than and P-as-greater-than handling. I'm going to close this PR in favor of that one.


Fix small grammer with DynamoDB

Was just reading through the documentation and saw it, minor I know :)

Thanks, @kevinsimper!