android tv remote back key stopped functioning on master channel

Hello,
I just noticed that on master branch the android tv remote back key stopped functioning today after a flutter upgrade.
I think this flutter change to master was recent, on dev & beta channels same flutter app works fine.
here is my app:
https://github.com/andraskende/apptv1/
simple app - works on dev, can't exit the program with remote back button on android tv (nvidia shield tv)
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Shortcuts(
      shortcuts: {
        // MASTER BRANCH
        LogicalKeySet(LogicalKeyboardKey.select): const ActivateIntent(),
        // STABLE BRANCH
        // LogicalKeySet(LogicalKeyboardKey.select):
        //     const Intent(ActivateAction.key),
      },
      child: MaterialApp(
        title: 'Flutter Demo',
        theme: ThemeData(
          primarySwatch: Colors.blue,
          visualDensity: VisualDensity.adaptivePlatformDensity,
        ),
        home: MyHomePage(title: 'Flutter Demo Home Page'),
      ),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key, this.title}) : super(key: key);

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headline4,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ),
    );
  }
}

Hi @andraskende
Can you please provide your flutter doctor -v on master which reproduces the issue ? Also please provide details about which nvidia shield tv it is and Android version
Thank you

andras@andras ~ %
andras@andras ~ % flutter channel master
Switching to flutter channel 'master'...
git: Already on 'master'
git: Your branch is up to date with 'origin/master'.
Successfully switched to flutter channel 'master'.
To ensure that you're on the latest build from this channel, run 'flutter upgrade'
andras@andras ~ %
andras@andras ~ % flutter upgrade
Flutter is already up to date on channel master
Flutter 1.21.0-2.0.pre.94 • channel master • https://github.com/flutter/flutter.git
Framework • revision adc9dde3ba (11 hours ago) • 2020-07-21 16:17:23 -0700
Engine • revision 5a73d4dc25
Tools • Dart 2.9.0 (build 2.9.0-21.0.dev 84e5eeaea4)
andras@andras ~ %
andras@andras ~ % flutter create apptv3
Creating project apptv3...
apptv3/ios/Runner.xcworkspace/contents.xcworkspacedata (created)
apptv3/ios/Runner.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist (created)
apptv3/ios/Runner.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings (created)
apptv3/ios/Runner/Info.plist (created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
apptv3/ios/Runner/Assets.xcassets/LaunchImage.imageset/README.md (created)
apptv3/ios/Runner/Assets.xcassets/LaunchImage.imageset/Contents.json (created)
apptv3/ios/Runner/Assets.xcassets/LaunchImage.imageset/LaunchImage.png (created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
apptv3/ios/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json (created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
<EMAIL_ADDRESS>(created)
apptv3/ios/Runner/Base.lproj/LaunchScreen.storyboard (created)
apptv3/ios/Runner/Base.lproj/Main.storyboard (created)
apptv3/ios/Runner.xcodeproj/project.xcworkspace/contents.xcworkspacedata (created)
apptv3/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist (created)
apptv3/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings (created)
apptv3/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme (created)
apptv3/ios/Flutter/Debug.xcconfig (created)
apptv3/ios/Flutter/Release.xcconfig (created)
apptv3/ios/Flutter/AppFrameworkInfo.plist (created)
apptv3/ios/.gitignore (created)
apptv3/test/widget_test.dart (created)
apptv3/apptv3.iml (created)
apptv3/.gitignore (created)
apptv3/.metadata (created)
apptv3/android/app/src/profile/AndroidManifest.xml (created)
apptv3/android/app/src/main/res/mipmap-mdpi/ic_launcher.png (created)
apptv3/android/app/src/main/res/mipmap-hdpi/ic_launcher.png (created)
apptv3/android/app/src/main/res/drawable/launch_background.xml (created)
apptv3/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png (created)
apptv3/android/app/src/main/res/mipmap-xxhdpi/ic_launcher.png (created)
apptv3/android/app/src/main/res/values/styles.xml (created)
apptv3/android/app/src/main/res/mipmap-xhdpi/ic_launcher.png (created)
apptv3/android/app/src/main/AndroidManifest.xml (created)
apptv3/android/app/src/debug/AndroidManifest.xml (created)
apptv3/android/gradle/wrapper/gradle-wrapper.properties (created)
apptv3/android/gradle.properties (created)
apptv3/android/.gitignore (created)
apptv3/android/settings.gradle (created)
apptv3/android/app/build.gradle (created)
apptv3/android/app/src/main/kotlin/com/example/apptv3/MainActivity.kt (created)
apptv3/android/build.gradle (created)
apptv3/android/apptv3_android.iml (created)
apptv3/pubspec.yaml (created)
apptv3/README.md (created)
apptv3/ios/Runner/Runner-Bridging-Header.h (created)
apptv3/ios/Runner/AppDelegate.swift (created)
apptv3/ios/Runner.xcodeproj/project.pbxproj (created)
apptv3/lib/main.dart (created)
apptv3/.idea/runConfigurations/main_dart.xml (created)
apptv3/.idea/libraries/Dart_SDK.xml (created)
apptv3/.idea/libraries/KotlinJavaRuntime.xml (created)
apptv3/.idea/modules.xml (created)
apptv3/.idea/workspace.xml (created)
Running "flutter pub get" in apptv3...                              1.1s
Wrote 71 files.
All done!
[✓] Flutter: is fully installed. (Channel master, 1.21.0-2.0.pre.94, on Mac OS X 10.15.6 19G73, locale en-US)
[✓] Android toolchain - develop for Android devices: is fully installed. (Android SDK version 29.0.2)
[✓] Xcode - develop for iOS and macOS: is fully installed. (Xcode 11.6)
[✓] Android Studio: is fully installed. (version 4.0)
[✓] VS Code: is fully installed. (version 1.47.2)
[✓] Connected device: is fully installed. (1 available)
In order to run your application, type:
$ cd apptv3
$ flutter run
Your application code is in apptv3/lib/main.dart.
andras@andras apptv3 %
andras@andras ~ % cd apptv3
andras@andras apptv3 %
andras@andras apptv3 % flutter doctor -v
[✓] Flutter (Channel master, 1.21.0-2.0.pre.94, on Mac OS X 10.15.6 19G73, locale en-US)
• Flutter version 1.21.0-2.0.pre.94 at /Users/andras/development/flutter
• Framework revision adc9dde3ba (12 hours ago), 2020-07-21 16:17:23 -0700
• Engine revision 5a73d4dc25
• Dart version 2.9.0 (build 2.9.0-21.0.dev 84e5eeaea4)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/andras/Library/Android/sdk
• Platform android-29, build-tools 29.0.2
• ANDROID_HOME = /Users/andras/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.6)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.6, Build version 11E708
• CocoaPods version 1.9.3
[✓] Android Studio (version 4.0)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 47.1.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] VS Code (version 1.47.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.12.2
[✓] Connected device (1 available)
• SHIELD Android TV (mobile) • <IP_ADDRESS>:5555 • android-arm64 • Android 9 (API 28)
• No issues found!
andras@andras apptv3 %
andras@andras apptv3 % code .
andras@andras apptv3 %
andras@andras apptv3 % flutter run
Launching lib/main.dart on SHIELD Android TV in debug mode...
Running Gradle task 'assembleDebug'...
Running Gradle task 'assembleDebug'... Done                        35.5s
✓ Built build/app/outputs/flutter-apk/app-debug.apk.
Installing build/app/outputs/flutter-apk/app.apk...                 6.6s
Waiting for SHIELD Android TV to report its views...                 9ms
Syncing files to device SHIELD Android TV...                       273ms
Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h Repeat this help message.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).
An Observatory debugger and profiler on SHIELD Android TV is available at: http://<IP_ADDRESS>:51154/QkkDGOojjuI=/
Lost connection to device.
andras@andras apptv3 %

NVIDIA SHIELD Android TV Pro 2019 Android 9 (API 28) - Up to with latest updates...
Thanks !!

The back button was affected by https://github.com/flutter/engine/pull/19024.
This has been reverted (https://github.com/flutter/engine/pull/19956)

Just tested again with upgraded master, its working fine again.
Thank you !


Update index-content.md

Components. Considerations.

Docs Build status updates of commit 3bb6fd7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/reference-architectures/sharepoint/index-content.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Safari 14.1 updates

https://webkit.org/blog/11648/new-webkit-features-in-safari-14-1/
TODO to make sure the changes here are (more) correct:

[x] https://tests.caniuse.com/audio-api on iOS 14.5
[x] https://tests.caniuse.com/mediarecorder on iOS 14.5
[ ] https://tests.caniuse.com/webm on macOS 11 Big Sur using Safari 14.1 plus latest TP (CC @kiding because #5721)
[ ] https://tests.caniuse.com/speech-recognition on iOS 14.5 + Safari 14.1 on macOS 11 Big Sur (CC @apple-web-evangelist because #5765)

Can't yet test myself, since I'm not on Big Sur for Xcode 12.5 nor already on iOS 14.5. Browserstack doesn't seem to be there either.

Can confirm audio-api and mediarecorder support on iOS 14.5

Can also confirm speechrecognition only has prefixed support.

Thansk @Fyrd for testing :)

Thanks again @kiding & @Fyrd! :)
Afaik ready to merge.

Nice work, thanks!


Some tweaks related to Frontend cookies

By default Artalk manages versions according to version configuration
https://cdnjs.cloudflare.com/ajax/libs/artalk/**2.7.1**/Artalk.js
https://cdnjs.cloudflare.com/ajax/libs/artalk/**2.7.1**/Artalk.css
Every time there is a new version, there will be a different link
http://your_domain:8080/dist/Artalk.css
http://your_domain:8080/dist/Artalk.js
It will keep the link intact regardless of version
The actual situation that happened was when I updated Artalk to a new version
Almost all old members will see a message like the one in the picture
I'm currently handling it the same way
https://bibica.net/Artalk/2.7.1/Artalk.css
https://bibica.net/Artalk/2.7.1/Artalk.js
It's a bit annoying because now every time I update a new version, I will have to recreate these two files
Is there a simpler way to handle this problem?

Hello! If you're utilizing Cloudflare, you can utilize the Purge by single-file (by URL) feature. This allows for manual refreshing of the CDN cache remotely via the Cloudflare web control page, effectively applying changes locally on the client's end. Essentially, this action can modify the HTTP response headers such as Last-Modified and If-Modified-Since, consequently refreshing client caches remotely.
For more in-depth technical insights, you can explore:
Heuristic caching on MDN Web Docs
Alternatively, for those not using a CDN service like Cloudflare, a simple solution involves configuring your Nginx reverse proxy. Ensure that the response header for the dist path consistently carries Cache-Control: no-cache. This setup effectively prevents client-side caching.

重新计算后，我认为我们仍然应该使用与我们正在使用的CDN服务相同的方法
默认值仍然是无限缓存“expires max;”，以优化用户性能。
稍后，当有新版本时，我会手动将其更新到另一个文件夹，例如https://bibica.net/Artalk/2.7.2/
不需要花太多时间，大多数情况下我有时会忘记它


Day difference DST issue

An attempt at fixing https://github.com/rluiten/elm-date-extra/issues/21

Another day light saving complication fun stuff...
Here are some thoughts around this issue I had last night.
The Period model is intended to represent an elapsed time concept with no compensation for interesting human abstractions like Years with variable number of days, Months with variable number of days and Day light saving back flips. So I don't like the idea of modifying it for this behavior. (I think I may need to clarify this better in the Period module header doc comment)
The Duration model is suited to this and it makes sense for it to compensate for day light saving stuff in there but it has extra baggage with Years, Months etc.
In addition any change to diff behavior also indicates that add behavior needs to change in an equivalent manner. So adding a diff to a date produces the other date again.
Given changes to both diff and add in Duration covers part of the requirement. Then need a way to get the number of day in a Duration relative to a reference Date. (require reference date because Duration needs to know about Year/Month/Date to compensate for extra days hours etc.).
In Duration module add something like asDays : Period -> Date -> Int
Then look at using Duration.diff and Duration.asDays in isoWeek very similar to how you did things.
Side Notes that have come up while exploring issues.
I am doubting the value of the Period.Week and Duration.Week in the models. They are of limited value and easy to for anyone to get themselves from Day if they need it.

Thank you for the detailed answer. I'd like to discuss a few more points.

But the diff function does not similarly compensate, that is a bug I am pretty sure

I'm not sure if it needs to. As far as I understand the code, add needs to compensate, because it uses Period.add internally, but diff just compares calendar values.
Also, it seems to work as described in documentation in the repl:
> mar28 = Create.dateFromFields 2016 Date.Mar 28 12 0 0 0
<Mon Mar 28 2016 12:00:00 GMT+0300 (EEST)> : Date.Date
> mar21 = Create.dateFromFields 2016 Date.Mar 21 12 0 0 0
<Mon Mar 21 2016 12:00:00 GMT+0200 (EET)> : Date.Date
> delta = Duration.diff mar28 mar21
{ year = 0, month = 0, day = 7, hour = 0, minute = 0, second = 0, millisecond = 0 }
    : Date.Extra.Duration.DeltaRecord
> Duration.add (Duration.Delta delta) 1 mar21
<Mon Mar 28 2016 12:00:00 GMT+0300 (EEST)> : Date.Date
> Duration.add Duration.Day 7 mar21
<Mon Mar 28 2016 12:00:00 GMT+0300 (EEST)> : Date.Date

In Duration module add something like asDays : Period -> Date -> Int

Then look at using Duration.diff and Duration.asDays in isoWeek very similar to how you did things.

Have you meant using Period.diff and Duration.asDays in  isoWeek? I haven't been able to think of how to extract number of days from Duration.DeltaRecord, in a way that doesn't feel like doing the same work twice. Maybe I'm missing something obvious though :-)

The Period model is intended to represent an elapsed time concept with no compensation for interesting human abstractions like Years with variable number of days, Months with variable number of days and Day light saving back flips.

Period.diff still isn't working quite right, I think.
> sep12 = Create.dateFromFields 2016 Date.Sep 12 0 0 0 0
<Mon Sep 12 2016 00:00:00 GMT+0300 (EEST)> : Date.Date
> jan4 = Create.dateFromFields 2016 Date.Jan 4 0 0 0 0
<Mon Jan 04 2016 00:00:00 GMT+0200 (EET)> : Date.Date
> Period.diff sep12 jan4
{ week = 35, day = 6, hour = 0, minute = 0, second = 0, millisecond = 0 }
    : Date.Extra.Period.DeltaRecord

This adds up to just 251 days. I'd expect it to return { week = 35, day = 6, hour = 23, ... }
Moment.js:
moment("2016-09-12").diff(moment("2016-01-04"), "days")
252

Maybe it'd be better to just use round in isoWeek, document it as a temporary solution and don't change anything else for this particular fix? Are there any other use cases at the moment, where similar logic would be useful?

I havn't forgotten this, been busy, and I want to make sure i allocate a bit of time once I get into it.

I'm not sure if it needs to. As far as I understand the code, add needs to compensate, because it uses Period.add internally, but diff just compares calendar values.
Also, it seems to work as described in documentation in the repl:

You are right, I was over thinking it.
Though I do think there might be a bug in the way it currently does daylight compensation as it only tries to compensate for day light saving for Days, Week,s Months and years which may be wrong I believe, since adding 1 millisecond can cross a day light saving boundary.

I haven't been able to think of how to extract number of days from Duration.DeltaRecord, in a way that doesn't feel like doing the same work twice.

Yes its a lot of work to do it, as much work as calculating the diff to start with.
I will have to explore things a bit further when I allocate time to work on this.
I do wish it was easier to run tests in different time zones, at the moment I have a notebook here that I can remote to and change its timezone to test things manually :). My home machine time zone has no daylight saving and I really don't want muck with its time zone as I have a lot of stuff on it.
Cheers Rob.

Closing this as have fixed.


Use proxy for github request and allow scheme in proxy host

Fixes two issues:

Use a proxy if available to download the detect script from github. This code was moved from the detect powershell script up to the tfs script. Unfortunately we will now need to keep them in sync.
When a scheme is provided in the host, the UriBuilder was failing to parse it. Now we treat host as a uri and let the builder's constructor parse it. This change also happened on the detect repository.

@taikuukaits  Any update getting this PR through?


Implement multiple robot agents

hi,
I like your work very much,
I currently have an idea to do collaborative tasks among multiple robot agents.So I would like to ask you, how to implement multiple robot agents in the environment based on this github repository? Do you have any suggestions for this?

See #22

Hi,
I've seen  https://github.com/Shuijing725/CrowdNav_DSRNN/issues/22
If I want to train two robots, then after adding the second robot instance, as follows:
Under the two programs crowd_sim/envs/crowd_sim.py and crowd_sim/envs/crowd_sim_dict.py
rob_RL = Robot(config, 'robot')         rob2_RL = Robot(config,'robot2')         self.set_robot(rob_RL)         self.set_robot(rob2_RL)
ob['robot_node2'] = self.robot2.get_full_state_list_noV()
I assume that both robots use the same reinforcement learning strategy, and the episode ends with both robots reaching the same target point. Then, referring to the training of the first robot, what procedures do I need to modify in the project file? Do I just need to modify the environment's code? For example, the related functions in crowd_sim_dict.py.
Secondly, does the render() function in crowd_sim.py also need to be modified?
Do I need to add code to train.py?
Sorry to bother you.
Thank you so much！

Yes, besides the gym environment, multiple modifications are needed. For example, you probably need to modify the main scripts including train.py and test.py.
Also, the code for network and ppo in pytorchBaselines folder needs to be adapted. For example, dsrnn network and RL replay buffer are only designed for single robot scenarios.
Besides changing our repo, another way to achieve your purpose is to look at open-source implementations of other multi-agent social navigation papers. For example, you can search for works that used environments like this one.


evaluateScript: include result term

Describe the feature you'd like
We would like to use Plutus to evaluate a custom-generated UPLC Program[^1].
Plutus.V1.Ledger.Scripts exposes evaluateScript and applyArguments which are useful for this, however the former is throwing away the term result, which we need.
The proposal is to change the type to:
evaluateScript
  :: forall m . (MonadError ScriptError m)
  => Script -> m (PLC.ExBudget, [Text], Term Name uni fun ())

If accepted, I can open a PR.
[^1]: Generated both by Pluto and Plutarch -- an assembly language and an eDSL respectively compiling to UPLC.
Describe alternatives you've considered
We copy-pasted evaluateScript in our project and modified it, but that's not ideal because upstream can change.

You can just use the underlying functions. The function in the plutus-ledger-api is designed to be exactly what the ledger needs and no more.

@michaelpj I forgot to state that mkError (used by evaluateScript to wrap user evaluation errors) is not exposed by the module. What do you think of exposing mkError? It would gives free improvements to Plutus' error handling improvements (eg: when #4270 gets addressed).

Why? Just use the evaluator yourselves directly and you can do whatever you want.


ActionMenu does not work inside Dialog

Hi Rails team! I'm trying to render an ActionMenu within a Dialog and I'm coming up against an error. This PR had fixed a different bug when ActionMenus were used to open a Dialog, but introduced a new one as the ActionMenu doesn't propagate any events inside a Dialog component, so is not functional.
Here's a video I setup in my local development:
https://github.com/primer/view_components/assets/12400507/c7fc20c5-4627-4f17-88b6-313e62ab2132

@keithamus would you mind taking a look at this and letting me know what size you would assign the work (GitHub staff only), given your familiarity with these components? This will help us make the call on when to prioritize it.

Pebble size. I'll look closely tomorrow and if I can, I'll raise a fix.


chore: Update dependencies

Information

Type
Breaking change

Feature/Fix/Doc/Chore
Yes/No

Todos

[ ] Tests
[ ] Coverage
[ ] Example
[ ] Documentation

Pull Request Test Coverage Report for Build 975803421

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.075%

Totals

Change from base Build 963626959:
0.0%

Covered Lines:
8099

Relevant Lines:
8107

💛  - Coveralls

:tada: This PR is included in version 6.59.1 :tada:
The release is available on:

v6.59.1
GitHub release

Your semantic-release bot :package::rocket:


Feature: set line height

Description

Is there a way to set line height?
like the video shows
https://github.com/user-attachments/assets/80183786-4184-4cb0-b40d-3bfb28e72ed5

Impact

You can modify the line-height CSS attribute in the respective CSS classes that you've specified in the EditorTheme. This would be your 'default' line height.
If you want to override line height for different paragraphs/text nodes, you can set the 'style' property on the text node to contain the line-height CSS attribute with the value in question. You would need to override the TextNode importDOM and exportDOM to read it. An example:
https://lexical.dev/docs/concepts/serialization#handling-extended-html-styling

I tried adding this feature，that's ok

@keiseiTi   How did you set style attr to h2? when I tried to set style to paragraphNode  by ***.setStyle('line-height:2;'),it did not working?

@keiseiTi How did you set style attr to h2? when I tried to set style to paragraphNode by ***.setStyle('line-height:2;'),it did not working

You should modify the updateDOM method of the ParagraphNode. You can refer to other usage of updateDOM


Examples are incorrect?

It looks like the examples weren't updated for recent versions of mdex, because the pattern matching is {binary, map, list(tuple)} — {"block_quote", %{}, [{"paragraph", %{}, …}]} — but the attributes is not a map but a string tuple list.
I’m wondering if this change was intentional, because it is possible to pattern match on a map (as with examples/mermaid.exs matching on %{"info" => "mermaid", "literal" => code}) but you cannot do so with a keyword list.

Hi @halostatue the examples are now up to date with the v0.3.0 release. The AST format changed from {"block_quote", %{}, [{"paragraph", %{}, …}]} to structs, see https://hexdocs.pm/mdex/MDEx.Document.html

Thanks. I was mostly able to get this working, but in the context of tableau, I can't seem to get the mermaid HTML to not be escaped (and I’m passing render: [unsafe_: true] like in the example); I don't have time to try to reduce this and I haven't pushed up the code yet to see if there is anything that I’m doing that’s weird, but just FYI.

When I get a chance to do so and if it doesn't appear to be something that I’ve done nonsensically in my own code, I will try to make a minimal reproduction.


Parallel iteration using rayon

Implements parallel iteration using the rayon crate. This closes #19.
The outer implementation (of query::result::ParIter) is based on the implementations of rayon::iter::Filter and rayon::iter::FlatMap. I believe everything is implemented correctly.
Benchmarks put this up to par with other ECS libraries for outer parallelism.

Codecov Report

Merging #20 (8f18fbf) into master (a18a904) will decrease coverage by 0.59%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   57.45%   56.85%   -0.60%
==========================================
  Files           9        9
  Lines        1234     1247      +13
==========================================
  Hits          709      709
- Misses        525      538      +13

Impacted Files
Coverage Δ

src/internal/archetype/mod.rs
14.74% <0.00%> (-0.73%)
:arrow_down:

src/internal/archetypes/mod.rs
56.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18a904...8f18fbf. Read the comment docs.


[Feature Request] Support of Ed25519 SSH keys

Hi,
Unless I am missing something, Ed25519 SSH keys are not supported for sftp targets. Not the end of the world, but a bit annoying.
Thank you.

@rmrnc
I am using ssh2-sftp-client for SFTP.
I am not sure if it is possible to use the key format there.
Is there a way to convert?

@rmrnc
I have find a way to convert keys. I am using sshpk module for that.
Since version 9.32.0, you can set the privateKeySourceFormat property to define the source format of your private key.
{
    "deploy": {
        "targets": [
            {
                "type": "sftp",

                "user": "mkloubert",

                "privateKey": "/.ssh/id_rsa",
                "privateKeySourceFormat": "auto",

                // ....
            }
        ]
    }
}

By default it will convert this to ssh format, This change be changed by setting up privateKeyTargetFormat.

Thank you for your quick response, but I am not entirely sure whether we are on the same page. I'd opted intentionally for elliptic-curve keys and specifically for an Ed25519 key (admittedly, a quite popular choice within the security community). Therefore, I am afraid to say that "(format) conversion" is not the issue. It appears to me, that the SSH client you are employing has omitted support for this kind of SSH keys. Let me know whether you need more information about the cryptographic background.

@rmrnc
Ah, OK. I wasn't really sure if a conversion is the really answer.
But on the other hand I have implemented a new, useful feature :D
Yes, tell me the background. What I currently see is, that this is a problem of the SSH client.
But I am not sure if there is a NodeJS module that supports this feature.

Related to: https://github.com/joyent/node-sshpk/issues/72


circle: run tests on Node v0.12.x in addition to Node v0.10.x

I'm pleased to have learnt how to do this (from one of the members of the CircleCI support team).

:dromedary_camel:


Implement bar option: colors {}

This only supports the color format #rrggbb. I see that the colors are defined with an alpha channel in swaybar/main.c should I extend it to also allow the format #rrggbbaa?
Also note that I have remove the color foreground I don't know if this was just an error or you intended to provide an extra color not available in i3?

Nice work. The foreground thing was a mistake. Can you extend this to support rgba?

I will add rgba support!

rgba support added. It is now possible to define the color as #rrggbb or #rrggbbaa.

Coolio, thanks!


mapdb.org without www does not work

Recently I wanted to show a friend how awesome mapdb is. I remembered the website but it did not work. Now I know why:
http://www.mapdb.org (works)
http://mapdb.org (does not work)
Is it possible to fix this small issue?
Cheers,
Julian

While on the topic of the website, the bottom-left link on http://www.mapdb.org/features.html#generic-pojo-serialization to Documentation results in a 404.

Will setup forwarding soon

Made DNS change, http://mapdb.org should work in a few hours.

Awesome! Will test it tomorrow and report back.

Sorry forgot to test it. Works like expected. Thank you!


chore(deps): update ci dependencies

This PR contains the following updates:

Package
Type
Update
Change

common-dev-assets

digest
55c4c41 -> 27f53d9

github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper
require
patch
v1.23.2 -> v1.23.4

Release Notes

terraform-ibm-modules/ibmcloud-terratest-wrapper (github.com/terraform-ibm-modules/ibmcloud-terratest-wrapper)
v1.23.4
Compare Source
Bug Fixes

add unauthenticated clone if authentication fails (#653) (f575f65)

v1.23.3
Compare Source
Bug Fixes

deps: update github.com/ibm-cloud/bluemix-go digest to dfb1429 (#671) (fcd05c4)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: tests/go.sum
Command failed: go mod tidy
go: go.mod file indicates go 1.21, but maximum version supported by tidy is 1.20

/run pipeline

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: tests/go.sum
Command failed: go mod tidy
go: go.mod file indicates go 1.21, but maximum version supported by tidy is 1.20

/run pipeline

:tada: This PR is included in version 3.9.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


2.4.6 broke eager loading

After upgrading to 2.4.6 I see a bunch of N+1 queries in my logs. Which leads me to believe Identity Map and/or eager loading is broken.

Here's the diff between 2.4.5 and 2.4.6 - nothing changed around eager loading.
https://github.com/mongoid/mongoid/compare/v2.4.5...v2.4.6
However, are you potentially seeing this when serializing to json?

I'm just looping through records from an association. The only thing I did was to upgrade mongoid in my Gemfile and restart the web server locally. Reverted to 2.4.5 made eager loading work...

What does your exact loop through the records look like, and the models/relations in question please? Eager loading is still working just fine for us in our apps - you're killing me here... haha. :)

Oddly, I tried upgrading again and restarting the web server and now it works... Lord knows what happened there, but it happened! Closing...


pull out background clearing into its own method

Console and TileView currently duplicate some background drawing logic. this might be better off going on Widget instead

resolved by cc2cad691c6fe50cf2b8a7105e45821d49e0f172


Add !showOverlay check to ads calls

Only fire ads when the overlay is not displayed.

 Configure metering for staging site


Booking confirmation rule triggers after every alteration

Check reservation with Khoo - extended couple days got booking confirmation again
Alex - same thing
Jacub supposed to check out tomorrow but changed to 24th of July - still got the message today about tomorrow check out

I think this has been fixed.  Can you confirm that it's not happening anymore?


Incorrect Turf dependency

According to the Turf docs, the name is only Turf not Turf-swift making it impossible to use Cocoapods to integrate these projects.
My suggestion is to update the mapbox-arkit-ios dependency!

Fixed in https://github.com/mapbox/mapbox-arkit-ios/pull/20. Turf-swift had a name change and was published to CocoaPods a few days ago in https://github.com/mapbox/turf-swift/commit/dccd622eeff5d274b65eef9ecd7b1b070fe2509d.


Incompatible block pointer (self.bridge.uiManager addUIBlock)

self.bridge.uiManager addUIBlock:^(__unused RCTUIManager *uiManager, NSDictionary<NSNumber *, UIView *> *viewRegistry) show an alert that says incompatible block pointer
You can solve this adding :
pod 'React', path: '../node_modules/react-native' pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'
to pod file.

Please following this url
https://github.com/react-native-community/lottie-react-native/issues/113


fix: Attach comma token to MATCH_ARM instead of MATCH_ARM_LIST

bors r+

bors r+

bors retry

👍
I think we should apply this treatment to all nodes. That is, attach commas to fields, parameters, arguments, etc. that’s going to be annoying and invasive change, but I think one we need to do (and one that’s been burning at the back of my mind forever).
we should do it one element at the time, and this also needs ungrammar updates.

This one here doesn't need an ungrammar change fortunately
bors r+

bors retry


Slack notifications

Is there a way to add slack notifications on model failure similar to DBT cloud?

Hey Julius,
I might have misunderstood your question, and if so let me know, but I'll do my best to answer.
If you use dbt Cloud, any failures from the posthook or downstream models should trigger a notification that you've setup.  If you're not using dbt Cloud you'd have to work out how to configure notifications within your orchestration platform.
Because notifications belong at the orchestration level, providing them is out of scope for this package.