cannot import fs/promises

Package json dependencies mapped:
    "bare-fs": "^2.1.5",
    "fs": "npm:bare-node-fs",

Then index.js
import fs from "fs/promises";
console.log(fs.writeFile);

Then:
pear dev
Error:
ModuleError: MODULE_NOT_FOUND: Cannot find module 'fs/promises' imported from 'pear://dev/index.js'

Seems to be two issues here:

There is bare-node-fs and bare-fs on npm, not sure why both exist and are different, only one of them supports ./promises
Using the package.json mapping doesn't seem to support subpaths? or am I missing something?


Anticipatory setpoint adjustment for control

When a dry period is coming or ongoing, water boards and Rijkswaterstaat adjust some of their operating setpoints such target water-levels in a boezemsystem or Lake IJsselmeer. These setpoints guide the PID control.
This adjustment is based on anticipated crossing of a threshold of a boundary condition (e.g. flow forecast of Lobith) or even an external condition which is not feed directly to the model (e.g. deviation of net precipitation shortage from the normal shortage).
Characteristics for the condition:

timeshift (look ahead)
boundary condition of external condition

Based on PID control. We leave the preprocessing (such as deviation of net precipitation shortage) up to the user

[ ] New condition based on time lookup with dT.

An initial check (befor running the simulation) is needed to evrify that the simulation length (e.g.365 days) and the external boundary provided matches the timeshift that is needed to check the condition.
If this check fails, an error needs to be raised (at this moment).

The look-ahead condition on boundary nodes could be implemented by adding an optional $\Delta t$ column to the condition table which defaults to $0$.
Then validation is needed:

To check whether sufficient data is available to look as far ahead as you need even towards the end of the simulation as mentioned by @gijsber;
Whether the condition of that row is indeed a (transient) boundary node for which look-ahead is possible.


Implement GetTrackedDeviceClass

Not sure if this was added later or not but when I wrote the original controller code I checked the name of the trackers to determine whether we were dealing with a controller.
This needs to change to using: https://github.com/ValveSoftware/openvr/wiki/IVRSystem::GetTrackedDeviceClass
If this returns TrackedDeviceClass_HMD or TrackedDeviceClass_TrackingReference we skip the tracker.
If this returns TrackedDeviceClass_GenericTracker we need to make sure we do not use tracker ids 1 or 2

This was implemented


KC-1182: Fix test failures

https://confluentinc.atlassian.net/browse/KC-1182
Fix test failures
Committer Checklist (excluded from commit message)

[x] Verify test coverage and CI build status

Thanks for finding these, @aloknnikhil !
I think we should replace the check
      if (zkConnect.isEmpty) {
        throw new ConfigException("Missing required configuration \"zookeeper.connect\" which has no default value.")
      }

with
      if (zkConnect == null {
        throw new ConfigException("Missing required configuration \"zookeeper.connect\" which has no default value.")
      }

That will let all the tests that set zkConnect to the empty string keep working.  I realize this is in some sense a less ideal scenario than what you have here, but there are a lot of tests outside the Kafka project that might be affected if we forbid setting this to the empty string.  It would be annoying to fix all of them, and I don't think we'd gain much by it.  Or at least that's my first thought.

Thanks for finding these, @aloknnikhil !
I think we should replace the check
      if (zkConnect.isEmpty) {
        throw new ConfigException("Missing required configuration \"zookeeper.connect\" which has no default value.")
      }

with
      if (zkConnect == null {
        throw new ConfigException("Missing required configuration \"zookeeper.connect\" which has no default value.")
      }

That will let all the tests that set zkConnect to the empty string keep working. I realize this is in some sense a less ideal scenario than what you have here, but there are a lot of tests outside the Kafka project that might be affected if we forbid setting this to the empty string. It would be annoying to fix all of them, and I don't think we'd gain much by it. Or at least that's my first thought.

Yea, good point. Fixed

I committed the fix to KafkaConfig.scala.  Can you explain the other changes a bit more?

@aloknnikhil Would it make the change smaller and clearer if we put the case None => fail("Empty response not expected") into the simulateSendResponse() method and had that method return AbstractResponse like the readResponse() method currently does?  I think it might, because then all the match stuff that got added in dozens of places would disappear?

Nice find, BTW.  I can't stand EasyMock, I much prefer Mockito.  I cringe every time I have to deal with EasyMock.

@aloknnikhil Would it make the change smaller and clearer if we put the case None => fail("Empty response not expected") into the simulateSendResponse() method and had that method return AbstractResponse like the readResponse() method currently does? I think it might, because then all the match stuff that got added in dozens of places would disappear?

Yea, good catch. That should definitely make it smaller.


Remember user's current role across sessions

Resolves #3345
Description
Before this commit, users starting a new session would be assigned the highest role available to them from a hierarchy of roles. This role would then be stored in, and later referenced from, the session. With this commit, users will be assigned their most recently active role.

"Active" role is recorded via the new last_active_at timestamp field on users_roles.
If a role is stored in the session, the user will be assigned to that role (if it is available to them) and the role will be removed from the session.
Otherwise the user is assigned a role using the most recent users_roles.last_active_at.
If all available users_roles.last_active_at are null, the user is assigned the default role available to them by hierarchy.
The current role's last_active_at field is updated on each request.
After a reasonable amount of time has passed, the session check should be removed.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Controller and model tests

@patrickarnett thanks for your help here!
I'm a little confused as to the complexity of this solution. First, I don't think it's necessary for us to stop reading the role from the session. The session would be re-created on login and we're really only talking about changing the behavior on that re-creation. You'd want to continue reading from the session on subsequent requests because it saves on additional database queries.
Second, it seems like a lot of extra work to store the last used time on the UsersRole rather than on the User itself. I was envisioning a column on the users table last_role_id which would store the role ID, and on login it would simply use that value if it exists rather than relying on the hierarchy.
Thoughts?

Hi @dorner!
I was thinking it would be simpler to store the current_role in a single place, with a single method of retrieval. It doesn't require any additional queries to get the role id from the db vs the session; a single query loads the role from the db with either strategy.
I thought we could use a timestamp so that there might be a fallback in the event a user's access to their current_role is revoked, but that's probably an edge case. I'll revert to default.

Hmm... I still think it seems a bit flakier to go to the database to check whatever the last signed in role was rather than storing a value on the session. E.g. let's say the user has two windows open at once, one logged in as an org user and one as a partner user. If you are fully relying on the database, that use case would be impossible.

I'd say yes, whenever a brand new session is created, it should use the most recent role we've seen. But if a session already exists, it should use the role specified in the session.

We will need to set it somewhere other than session start, though, right? Otherwise, it will always be whichever role is the default upon the user's next sign-in after deployment. I was thinking we would persist the last_role_id in users_controller#switch_to_role.

Yep, I think that makes sense!

Hey @patrickarnett -- what's the status on this?  (We check in when it's been a few  weeks with no activity as part of our process.)

Greetings! Thank you for the PR, but based on the feedback above I think it needs to be re-worked. I'm going to go ahead and close this PR and update the issue with a note to refer to the conversation here for the next attempt.


Warning given about linear disused:aeroway=runway

URL
https://master.apis.dev.openstreetmap.org/changeset/253299
How to reproduce the issue?
Using taginfo, note that disused:aeroway=runway is used both on linear and area objects:
13 closed in Lincs
https://overpass-turbo.eu/s/1r3F
19 open in Lincs
https://overpass-turbo.eu/s/1r3G
In iD, add an "aeroway=runway"
Save
Note no warning
Changed to "disused:aeroway=runway"
Save
Warning given incorrectly saying it should be an area feature.
Screenshot(s) or anything else?
No response
Which deployed environments do you see the issue in?
Released version at openstreetmap.org/edit
What version numbers does this issue effect?
2.24.1
Which browsers are you seeing this problem on?
Firefox

this was fixed in #9483 but it hasn't been merged yet

Fixed in #9483.


linuxKernel.kernels.linux_zen: 6.6.9-zen1 -> 6.6.10-zen1 ; linuxKernel.kernels.linux_lqx: 6.6.9-lqx1 -> 6.6.10-lqx1

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

CC @thiagokokada if you want to look over it real quick.

It seems there is a hash mismatch in OfBorg, can you take a look @JerrySM64 ?

Yup, there is. For some reason, both hashes are wrong. Don't know what nix-prefetch-git did to get any of these. Will try to force push the new commits later.

Alright. Now, OfBorg should have no issues. You can take a look when the evaluation is done, @thiagokokada.


feat: allow to import dashboards roles

Description
This PR allows importing the roles associated with the dashboard:
TODO:

Add documentation

Screenshots:

Thanks for the pull request, @Ian2012!  Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 🎉 Your pull request was merged!  Please take a moment  to answer a two question survey so we can improve your experience in the future.


Knight no Scanlation changed his url

Source information
Knight No Scanlation  1.4.39
Source language
Spanish
Source new URL
https://kns.topmanhuas.org/
Other details
I already did this report before
Acknowledgements

[X] I have updated all installed extensions.
[X] I have opened WebView and checked that the source URL has not changed yet.
[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I will fill out all of the requested information in this form.

I already did this report before

Learn to read first then


Javascript only needed for Admin should not load on view

Hey guys,
We're tracking down some issues with performance for our site.  We noticed that all the Admin JS gets loaded when no admin screens are present.
I noticed that all of these get shoved into the rcmHtmlIncludes() but really we should only be including things that are needed.
Obviously I can jump in here and fix this, but before I move on this I want to make sure I won't be breaking anything for you guys.

We have alot of thoughts on how to better handle JS includes as well. We would like to eventually have the option to not use the asset manager.
I believe last time we discussed, we found that we need several different "lists" of JS files in the RCM config. Perhaps admin files could be one of these lists.
@jerv13  - James do you remember if what I am saying above is what we came to conclude last time?

On the performance note, I recently did alot of profiling with CacheGrind. Surprisingly it was hard to find major slow areas where alot of improvement could be made. I found most of the time was taken by four things: ZF Router, ZF Service Manager, and Doctrine. Symfony generates a fast cache compiled version of their router and service manager but we do not have that option in ZF.
One thing we could do is get onto the ZF3 service manager. The only barrier to it that I see is that so many composer.jsons (including the aws tools) demand the 2.* service manager even though they would work the the 3.* one.

There's something else too. Including all the files in one JS is now also considered bad practice and shouldn't be used anymore with http 2.
I got dinged pretty hard on this by our optimization consultant.
I'm all for getting rid of the AssetManager so long as installing assets is easy and doesn't require node on the production boxes. If you have a better idea on this I'm all ears.

Actually in performance we got A GLOWING review on the backend.  Where we got killed was on the front end.

There are two separate things:

The FXP Composer-bower thing
The asset manager

Here is how we are getting rid of the asset manager (but keeping FXP now) in our current setup:

We configured the composer bower thing to install directly into the public folder.
Our front-end combined/minified JS files for each package are pre-built into dist folders inside those packages with grunt

If you do those, you only need node on you local and maybe your build servers, not on your prod servers.
Not everyone has to do things this way but this is how we are doing it now.

"Actually in performance we got A GLOWING review on the backend. Where we got killed was on the front end." - This makes sense.

That method of getting rid of the asset manager above only applies to front end apps and front end libraries though. Of course the asset manager is still currently needed to server public assets that are in cms plugin folders.

Also one more note: We are not currently wanting to REMOVE the asset manager. We just want the option to not use it for front in apps and libraries.

@wshafer Where are you seeing admin-js loading when not an admin? I do not see it here
view-source:https://reliv.com/

Angular, tinyMCE are being loaded every request.

There's some other unneeded js libraries as well.

As for the Asset Manager, yea I hit the same wall. How to plugins include their assets the easiest.  Requiring node seems a bit much for quick easy plugins.
For full on apps, it makes complete sense to move those out to bower/npm, I just wish FXP wasn't so damn slow!

I have alot of problems with FXP's slowness, bugs, breaking build, and the fact that it has to be global installed. But we cannot think of anything better right now.

I personally think core should NOT include tinyMCE. Debating with @jerv13 right now.

If I can put in my two cents.  Anything ONLY required for admin should not be loading.  Let the theme's + plugins add as needed.
In our world the only thing that uses Angular is the admin section (much to my dismay).  Our frontend team is using Redux and React for everything front end.  None of our plugins use this.

Just got done with a long discussion with @jerv13
@jerv13 is pretty adamant that Rcm should dictate/manage a certain version of jQuery and Angular in order to simplify development, compatibility, and JS loading order. In order to keep providing this but still allow @wshafer to do what he wants, we are going to do these today:

Make a new module rcm/js-core.
Move all front-end js and css inclusion from rcm/core to rcm/js-core

js-core will be used in the rcm skeleton app and will dictate jQuery and Angular versions (and TinyMce for now since it is used for cases other than admin)
@wshafer can disable js-core if he want to manage the js himself

Supposable this helps with speeding up FXP. Idk how much it helped us though. Maybe we need a better regex. https://github.com/fxpio/composer-asset-plugin/issues/237

Ok sounds good. What do I need to do to ensure all the Admin required JS is loaded for Admins?  Will these be included and injected via RCM-admin like they use to?

My issue was not the version but the automatic inclusion when not logged in.

Oh but this would fix the earlier issue with bootstrap. Nice.

As far as I know, rcm-admin already injects the admin.js only when you are logged in.
For angular, tinymce, and other things that the admin.js depends on, you will need some way to include these selectively. Perhaps by injecting them into admin.js?
We do not include these selectively because all our pages use angular and many use TinyMce. Also because @jerv13 wants to keep JS dependency management simple for now by just including all the commonly used dependencies on every page.

Also... by "Version" I also meant the @jerv13 wants Rcm to dictate that these libraries are included on every page so that plugins can depend on them being there. He said all three of us (including Westin) discussed this in detail and came to this decision.
Of course this will only happen in the future if the core-js module is enabled.

What if we just simply include them like the other JS files and let Zend sort it all out.
Like the other JS libraries in:
cms/vendor/rcm/admin/view/rcm-admin/admin/admin.phtml
Simply adding them to this should fix all of this, since I can just overwrite the rcm list from my local.config.php.

Ya know what... I can do that right now cant I.  Let me experiment.

This gets me closer but not quite there.  Loading order is a problem here.
module.php
public function init(ModuleManager $moduleManager)
    {
        $events = $moduleManager->getEventManager();

        // Registering a listener at default priority, 1, which will trigger
        // after the ConfigListener merges config.
        $events->attach(ModuleEvent::EVENT_MERGE_CONFIG, array($this, 'onMergeConfig'));
    }

    public function onMergeConfig(ModuleEvent $e)
    {
        $configListener = $e->getConfigListener();
        $config         = $configListener->getMergedConfig(false);

        // Modify the configuration; here, we'll remove a specific key:
        $config['asset_manager']['resolver_configs']['collections']['modules/rcm-admin/admin.js'] = array_merge(
            $config['Rcm']['HtmlIncludes']['headScriptFile'],
            $config['asset_manager']['resolver_configs']['collections']['modules/rcm-admin/admin.js'],
            $config['asset_manager']['resolver_configs']['collections']['modules/rcm/rcm.js']
        );

        $config['asset_manager']['resolver_configs']['collections']['modules/rcm-admin/admin.js']
            = array_reverse($config['asset_manager']['resolver_configs']['collections']['modules/rcm-admin/admin.js']);

        $config['asset_manager']['resolver_configs']['collections']['modules/rcm-admin/admin.css'] = array_merge(
            $config['asset_manager']['resolver_configs']['collections']['modules/rcm/rcm.css'],
            $config['asset_manager']['resolver_configs']['collections']['modules/rcm-admin/admin.css']
        );

        $config['Rcm']['HtmlIncludes']['headScriptFile'] = [];
        $config['asset_manager']['resolver_configs']['collections']['modules/rcm/rcm.js'] = [];
        $config['asset_manager']['resolver_configs']['collections']['modules/rcm/rcm.css'] = [];

        // Pass the changed configuration back to the listener:
        $configListener->setMergedConfig($config);
    }

lol...  ok I'm on to something... JUST DON'T INCLUDE $this->rcmHtmlIncludes(); in my theme!
So that absolutely worked AND is being injected by the admin.phtml template.
Course now I get to find out which plugins are REALLY using Angular.  A couple of them are.

Thanks for your help guys.   I appreciate all the time you took out of your day.
Now it's on to ZF3

Sounds good. We are still going to separate core-js from the core module.

...everything in the core public folder will move to the core-js module


[Feature Request] Add Namesilo

What is the idea?
Feature request Please Add Namesilo Domain Register for all Namesilo Reseller
Why would this be beneficial
Benefits

namesilo is allready added. you just need the extention

There is an old adapter here: https://github.com/boxbilling/extensions/blob/master/bb-library/Registrar/Adapter/Namesilo.php
I'm not sure if it's still working.
If not, BoxBilling is extensible and everyone can bring support for external services by coding domain adapters for them. I don't think we'll be able to create and maintain all of the requested services with a small team and no help from the community.
So if you are interested, feel free to write your own adapter. And we'd be glad if you share it with the community. Thanks for your interest.


patching sublevel

To initiate maxogden/dat/#384, patching sublevel is the best possible way I can think of. It respects current sublevel codec and, hopefully should not change any existing behaviours so far.

Link to the issue: https://github.com/maxogden/dat/issues/384

Wow, great. @mafintosh wouldn't this be backwards compatible, too?

I'm not super confortable switching out subleveldown since its a major critical dependency (and by now pretty battle tested in various projects). @cshum why is a new sublevel abstraction needed for this? I tried digging through the code but couldn't find the relevant sql parts

If I'm not mistaken, in the original issue @cshum  discusses wanting the MySQL backend to respect a table<->dataset association (seen in myDOWN).
When I use dat with sqldown, it is practically unusable from the SQL side because it is stored in binary format. Would this problem still persist with MyDOWN @cshum ?

@karissa everything we do is wrapped in internal protobuf encodings so it would probably still be binary

I think the idea would be to map the protobuf into mysql types. would be pretty cool to have the mysql tables be 'idiomatic'

Ah yeah, this would be pretty nice

I think maybe we are discussing 2 different use cases here: one is running dat-core on mysql (for when you e.g. only have access to a mysql database and not leveldb), another is syncing a subset of dat data into a mysql table (for general purpose use)

@maxogden right. and we definitely have support for the 1st right now.
So, this PR would be a step address the second point, it seems. The 'syncing' data to a mysql table could be done externally (through a changes/SLEEP feed, as we've discussed), or like this -- but we still don't have the second piece, which is mapping protobufs to sql..

Before coming up with this PR there are several ways considered:

Simply use one table. Doesn't sound right for sql database. Also MySQL unique key has a 767 bytes limit by default, which is easy to reach if we have lots of sublevels.
Reverse engineer key prefix to figure out the sql tables it belongs to. Table joins when we need a full scan of database. This sounds complicated and super easy to go wrong.
PR subleveldown for such changes. But since it appends ! padding manually for .batch(), changing this behaviour means incompatibility for many of its dependent projects.

Regarding to single table usage, it should be testable without making any changes to dat-core:
var mydown = require('mydown')('db', { //uses mysql db `db`
  host: 'localhost',
  user: 'root'
})
var db = dat('/some/regular/path', {
  backend: function () {
    return mydown('dat'); //uses table `dat`
  }
})

@karissa the value needs to be protobuf to be compatible with abstract leveldown.
levelup('dat', {
  db: mydown,
  schema: ...
})

It may be possible to specify schema but that will be too much hassle as a LevelUP backend.
Another notable backend though, PostgreSQL supports JSON types.
http://www.postgresql.org/docs/9.4/static/datatype-json.html
Combined with tables it should be pretty usable for PostgreSQL side.

One hassle of PostgreSQL backend though is put().
Because UPSERT is surprisingly difficult for SQL databases.
While MySQL has INSERT ... ON DUPLICATE KEY UPDATE there is no much reliable equivalent to PostgreSQL:
https://wiki.postgresql.org/wiki/UPSERT#UPSERT_as_implemented_in_practice
However PostgreSQL 9.5 added UPSERT support, which means this will also be fixed.

@cshum we're doing a video call in a couple days: https://github.com/datproject/discussions/issues/25 if you can join it would be awesome to talk about this. otherwise we can schedule a separate call to discuss ideas, i think this is one of this topics that voice chat would be much better for :)

@maxogden I would really love to join the discussion, but that's 1am here. Guess I should watch the video and catch up later on. Many thanks!


Creating tests to the "cartolafc.Api.clubs" method

Coverage increased (+1.3%) to 90.429% when pulling a0ba99c600b0e7abf4daab8ae775999eddd85894 on dev into 4af5427535629667ba139c3ccb656eda0b1236c5 on master.


How to use multiple length sequences for trainning

Hi,I have tried to modify the code for multiple length sequences trainning like this:
df=BatchData(df,self.batch_size)
How to modify code to support multiple length sequences？

Hi @jiqizaisikao take a look https://github.com/theconsummate/deep-voice-conversion/commit/3bc71b0a819ac79fa5d0b975d2e6bca25df25304
https://github.com/theconsummate/deep-voice-conversion/commit/0bafb4e44cbb550082a02acea41c4963dfa8dc8f


React 16.x PropTypes Breaking Change

The PropTypes in the library causing the code to break with React 16.x. PropTypes has been deprecated in favor of another method. Any ideas how I can modify this package to allow it to be compatible with both React 15 and 16? I was thinking to just completely remove the PropTypes and it should work with both versions. Thoughts?

It's not that PropTypes has been deprecated, PropTypes is extracted from the React scope, into it's own module prop-types. react-input-slider had already fixed this in v2, while we're now at v4.
I think https://github.com/wayofthefuture/react-input-moment/issues/4 can be fixed by a update of the react-input-slider dependency (as it's still using 1.6.0). No changes to react-input-slider are required.
This issue can be closed. There's nothing wrong with PropTypes in the latest version of this library.

Thanks!


vscode-win32-ia32 build failure: JavaScript heap out of memory

OS: Windows 7 (VM 10GB memory)
Insiders source (June 27)
(Note: I have built the Win32 package before on the same machine, as recently as a month ago)
Building vscode OSS and executing from source succeeds.
Building vscode-win32-ia32 package fails near the end: see partial output below (full file attached)
[23:49:59] [i18n] No localized message found for key versionMismatch
[23:49:59] [i18n] No localized message found for key versionMismatch
[23:49:59] [i18n] No localized message found for key versionMismatch
[23:49:59] [i18n] No localized message found for key versionMismatch
[23:49:59] [i18n] No localized message found for key versionMismatch
[23:49:59] [i18n] No localized message found for key versionMismatch
[23:49:59] Finished 'compile-extension-build:typescript' after 33 s
[23:49:59] Starting 'compile-extensions-build'...
[23:49:59] Finished 'compile-extensions-build' after 4.3 μs
[23:52:03] [monaco.d.ts] Starting monaco.d.ts generation
[23:52:06] [monaco.d.ts] Finished monaco.d.ts generation
[23:52:06] Finished compilation with 0 errors after 159978 ms
[23:52:06] Finished 'compile-client-build' after 2.38 min
[23:52:06] Starting 'compile-build'...
[23:52:06] Finished 'compile-build' after 51 μs
[23:52:06] Starting 'optimize-vscode'...
CSS INLINING IMAGE AT out-build\vs\workbench\browser\parts\editor\media\close-dirty.svg MORE
THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\browser\parts\editor\media\close-dirty-inverse.s
vg MORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\browser\parts\editor\media\close.svg MORE THAN O
NCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\browser\parts\editor\media\close-inverse.svg MOR
E THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\browser\parts\editor\media\close-dirty.svg MORE
THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\browser\parts\editor\media\close-dirty-inverse.s
vg MORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\browser\parts\editor\media\close.svg MORE THAN O
NCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\browser\parts\editor\media\close-inverse.svg MOR
E THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\parts\debug\browser\media\current-arrow.svg MORE
THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\parts\debug\browser\media\continue.svg MORE THAN
ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\parts\debug\browser\media\continue-inverse.svg M
ORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\parts\debug\browser\media\continue.svg MORE THAN
ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\parts\debug\browser\media\continue-inverse.svg M
ORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\parts\feedback\electron-browser\media\info.svg M
ORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\parts\preferences\browser\media\edit.svg MORE TH
AN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\parts\preferences\browser\media\edit_inverse.svg
MORE THAN ONCE. CONSIDER CONSOLIDATING CSS RULES
CSS INLINING IMAGE AT out-build\vs\workbench\parts\welcome\code-icon.svg MORE THAN ONCE. CONS
IDER CONSOLIDATING CSS RULES
[23:52:13] [i18n] de has 260 untranslated strings.
[23:52:13] [i18n] es has 189 untranslated strings.
[23:52:13] [i18n] fr has 259 untranslated strings.
[23:52:13] [i18n] hu has 189 untranslated strings.
[23:52:13] [i18n] it has 249 untranslated strings.
[23:52:13] [i18n] ja has 192 untranslated strings.
[23:52:13] [i18n] ko has 260 untranslated strings.
[23:52:13] [i18n] pt-br has 189 untranslated strings.
[23:52:13] [i18n] ru has 259 untranslated strings.
[23:52:13] [i18n] tr has 189 untranslated strings.
[23:52:13] [i18n] zh-cn has 190 untranslated strings.
[23:52:13] [i18n] zh-tw has 237 untranslated strings.
<--- Last few GCs --->
267046 ms: Mark-sweep 1348.7 (1435.6) -> 1348.7 (1435.6) MB, 1940.1 / 0.0 ms [allocation fa
ilure] [scavenge might not succeed].
269000 ms: Mark-sweep 1348.7 (1435.6) -> 1348.7 (1435.6) MB, 1953.2 / 0.0 ms [allocation fa
ilure] [scavenge might not succeed].
270963 ms: Mark-sweep 1348.7 (1435.6) -> 1348.7 (1435.6) MB, 1962.4 / 0.0 ms [allocation fa
ilure] [scavenge might not succeed].
<--- JS stacktrace --->
Cannot get stack trace in GC.
FATAL ERROR: MarkCompactCollector: semi-space copy, fallback in old gen Allocation failed - J
avaScript heap out of memory
build failure.txt

Hi @cleidigh. Try running npm run gulp -- instead of gulp. So, that would be npm run gulp -- vscode-win32-ia32.

@joaomoreno
Thanks! When I tried this get first compiled okay, however, when code launches I get the main window
the menu bar , no content gets rendered and the menu does not do anything basically a blank main screen.
The second time I compiled I got the memory out error. tried the task system
that compiled but the code was not operational as before.
any other ideas? thanks

Maybe let's start over:
git clean -xfd .
./scripts/npm.bat i
npm run watch

# and in another terminal, after the watch stops compiling
./scripts/code.bat

What node version do you have installed?

@joaomoreno
node 6.10.1
npm 3.10.8
this is been my stable build environment for several months and over a hundred compiles
while I can compile and execute code, I did just get an error log that doesn't seem to be fatal
for compiling and running from source  but does affect packaging - see attached
looks like an error compiling tsc
this was just the result of the clean and npm.bat install
if I do an incremental compile or code.bat afterwards that's fine - compiles and executes
in fact just did a build and a new PR yesterday.
npm run gulp for Windows platform subsequently has the issue
npm-debug .txt

looks like an error compiling tsc

What makes you say this?
It's not clear to me why npm is failing in your machine.
First, running npm in verbose mode really doesn't help, there's way too much output in there, which makes it hard to detect the problems.
127305 silly lifecycle<EMAIL_ADDRESS>Args: [ '/d /s /c', 'node build/npm/postinstall.js' ]
127306 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
127307 info lifecycle<EMAIL_ADDRESS>Failed to exec postinstall script

These lines are very suspicious and can point as to why you're getting those errors.
But in any case you seem to be able to compile and execute, so I don't think there's really a problem here.

@joaomoreno
I think there was an error relative to TSC maybe it does not go into the debug log.
yes I can compile and execute - I cannot package. I was trying to package in a recent PR effort
that required looking at different locales and therefore could only be done in a package.
is there any other debugging output that might help?
Thanks

What do you mean by pack?

@joaomoreno
Sorry for the bad dictation: I meant "package binary"
This is the development sequence I use:
git clean -xfd
.\scripts\npm install
npm run watch (Build VS Code task)
gulp: vscode-win32-i32 (build task)
I have also tried -64
The source builds completes, the binary package fails.
Although every ten times or so, it succeeds.
Most of the time it fails with the out of memory error.

Have you tried npm run gulp -- vscode-win32-ia32, instead of calling gulp directly?

Yes, tried that also, still get failures

So, it's been our experience that npm run gulp -- vscode-win32-ia32 won't fail with out of memory errors, we use it in our build machines once we started getting those errors.
I'm not really sure where all the TypeScript errors come from though.
I ran out of ideas. 😕

Having the same issue with tsc
npm ERR<EMAIL_ADDRESS>compile: tsc
Will post an update if I figure this out.

@GharTok
Good, I'm not crazy ;-)
can we reopen this?

@joaomoreno
any reason to try new version of node or npm?
or are there any other TSC dependencies I may have incorrectly installed?

@cleidigh  What I reported earlier was on Windows 10.
Now I have been able to reproduce the same problem on macos (worked fine yesterday)
Today, on a working macos machine I ran git clean -xfd
now when I try ./scripts/npm.sh install it fails
The errors start with TypeScript errors and end with npm ERR!... as follows:
...

<EMAIL_ADDRESS>compile .../build
tsc
lib/tslint/allowAsyncRule.ts(9,14): error TS2415: Class 'Rule' incorrectly extends base class 'AbstractRule'.
...
npm ERR! argv "/Users/ghar/.nvm/versions/node/v7.4.0/bin/node" "/Users/ghar/.nvm/versions/node/v7.4.0/bin/npm" "run" "compile"
npm ERR! node v7.4.0
npm ERR! npm  v4.0.5
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>compile: tsc
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>compile script 'tsc'.

Note: running node v7.4.0 and npm 4.0.5

@GharTok
just to be clear, you are seeing build problems with NPM install
do you have problems doing binary packaging?
I have seen similar errors to what you describe, but these have2 been inconsistent.
sometimes doing a clean and restarting solves the problem, but for no apparent reason

cc @mjbvz @jrieken Have you seen these errors?
><EMAIL_ADDRESS>compile C:\VSC Dev\vc-fork-cdl\vscode\build
> tsc

lib/tslint/allowAsyncRule.ts(9,14): error TS2415: Class 'Rule' incorrectly extends base class 'AbstractRule'.
  Types of property 'apply' are incompatible.
    Type '(sourceFile: SourceFile) => RuleFailure[]' is not assignable to type '(sourceFile: SourceFile, languageService: LanguageSer
vice) => RuleFailure[]'.
      Types of parameters 'sourceFile' and 'sourceFile' are incompatible.
        Type 'ts.SourceFile' is not assignable to type 'ts.SourceFile'. Two different types with this name exist, but they are unrela
ted.
          Types of property 'statements' are incompatible.
            Type 'ts.NodeArray<ts.Statement>' is not assignable to type 'ts.NodeArray<ts.Statement>'. Two different types with this n
ame exist, but they are unrelated.
              Types of property 'push' are incompatible.
                Type '(...items: ts.Statement[]) => number' is not assignable to type '(...items: ts.Statement[]) => number'. Two dif
ferent types with this name exist, but they are unrelated.
                  Types of parameters 'items' and 'items' are incompatible.
                    Type 'ts.Statement' is not assignable to type 'ts.Statement'. Two different types with this name exist, but they
are unrelated.
                      Types of property 'kind' are incompatible.
                        Type 'ts.SyntaxKind' is not assignable to type 'ts.SyntaxKind'. Two different types with this name exist, but
...

This look like the errors you see when building with TypeScript. 2.4.
Are you synced to a point after https://github.com/Microsoft/vscode/commit/96643e312a8a4b3f9836c43061408f7b04c96f90 ?

@cleidigh yes, scripts/npm install is the issue (both Windows 10 and macos)
On macos I can now replicate the problem, so hopefully can isolate and fix it soon.
Still working on it, here is what I have determined so far.
EXISTING local VSCode project release/1.13 scripts/npm.sh install WORKS
after running git clean -xfd scripts/npm.sh install FAILS
NEW VSCode Clone branch release/1.13 - Install FAILS

git clone https://github.com/Microsoft/vscode.git
cd vscode
git checkout release/1.13
./scripts/npm.sh install\n

NEW VSCode Clone branch release/1.14 - Install WORKS

git clone https://github.com/Microsoft/vscode.git
cd vscode
git checkout release/1.14
./scripts/npm.sh install\n

@GharTok Try cherry-picking 96643e3 into your local 1.13 branch and then running git clean -xfd ./scripts/npm.sh install

@mjbvz thanks - trying it now

@mjbvz  That worked - tried on two systems - Thank you very much!

@mjbvz
I'm still having problems with the binary packaging phase
Using:
upstream/master            722e6ba347 Merge pull request #30365 from Microsoft/roblou/terminalCursorColor
Per @joaomoreno  suggestion packaging with:
npm run gulp -- vscode-win32-ia32
see error below:
any ideas?
[13:37:50] [i18n] zh-cn has 142 untranslated strings.
[13:37:50] [i18n] zh-tw has 224 untranslated strings.
[13:39:07] Finished 'optimize-vscode' after 1.48 min
[13:39:07] Starting 'vscode-win32-ia32'...
Unhandled Rejection at: Promise Promise {
 { Error: spawn UNKNOWN
at exports._errnoException (util.js:1018:11)
at ChildProcess.spawn (internal/child_process.js:319:11)
at exports.spawn (child_process.js:378:9)
at Object.exports.execFile (child_process.js:143:15)
at Object.exports.exec (child_process.js:103:18)
at C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\npm.js:21:24
at exec (C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\npm.js:19:12)
at checkNPM (C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\npm.js:40:12)
at Object.getDependencies (C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\npm.js:49:1
2)
at collectAllFiles (C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\package.js:550:18)
at collectFiles (C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\package.js:561:12)
at C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\package.js:671:44 code: 'UNKNOWN',

errno: 'UNKNOWN', syscall: 'spawn' } } reason: { Error: spawn UNKNOWN
at exports._errnoException (util.js:1018:11)
at ChildProcess.spawn (internal/child_process.js:319:11)
at exports.spawn (child_process.js:378:9)
at Object.exports.execFile (child_process.js:143:15)
at Object.exports.exec (child_process.js:103:18)
at C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\npm.js:21:24
at exec (C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\npm.js:19:12)
at checkNPM (C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\npm.js:40:12)
at Object.getDependencies (C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\npm.js:49:1
2)
at collectAllFiles (C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\package.js:550:18)
at collectFiles (C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\package.js:561:12)
at C:\VSC Dev\vc-fork-cdl\vscode\node_modules\vsce\out\package.js:671:44 code: 'UNKNOWN',

errno: 'UNKNOWN', syscall: 'spawn' }
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Users\Christopher Leidigh\AppData\
Roaming\npm\node_modules\npm\bin\npm-cli.js" "run" "gulp" "--" "vscode-win32-ia32"
npm ERR! node v6.10.1
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>gulp: gulp --max_old_space_size=4096 "vscode-win32-ia32"
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>gulp script 'gulp --max_old_space_size=4096 "vscode
-win32-ia32"'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the code-oss-dev package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp --max_old_space_size=4096 "vscode-win32-ia32"
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs code-oss-dev
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls code-oss-dev
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\VSC Dev\vc-fork-cdl\vscode\npm-debug.log

@mjbvz
just saw and tested your commit now using typescript 2.4.2
the binary build completes without error but when I open Code I get the menu bar and a blank window


D435 Frame didn't arrive within 5s

Required Info

Camera Model
D435

Firmware Version
5.15.02

Operating System & Version
Ubuntu 22.04

Kernel Version (Linux Only)
5.15.0-43-generic

Platform
PC

SDK Version
2.54.1

Language
N/A

Segment
others

Issue Description
I'm attempting to use the D435 on a Ubuntu 22.04 machine using the Realsense Viewer. When I attempt to connect to the camera I get the "Frame Didn't arrive within 5s" error.
The only thing that seems odd to me is that the device is listed as connected via USB 2.1 in the interface. I tried several different USB cables, just to be sure, as well as all the available ports (including USB C) but that didn't change. Some outputs from lsusb:
$ lsusb
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 007: ID c0f4:07b0 USB usb keyboard
Bus 001 Device 009: ID 2575:0001 Weida Hi-Tech Co., Ltd. CoolTouch® System
Bus 001 Device 006: ID 8087:0aaa Intel Corp. Bluetooth 9460/9560 Jefferson Peak (JfP)
Bus 001 Device 008: ID 8086:0b07 Intel Corp. RealSense D435
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

$ lsusb -t
/:  Bus 02.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/10p, 10000M
/:  Bus 01.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/16p, 480M
    |__ Port 4: Dev 9, If 0, Class=Human Interface Device, Driver=usbhid, 12M
    |__ Port 5: Dev 7, If 1, Class=Human Interface Device, Driver=usbhid, 1.5M
    |__ Port 5: Dev 7, If 0, Class=Human Interface Device, Driver=usbhid, 1.5M
    |__ Port 10: Dev 8, If 4, Class=Video, Driver=uvcvideo, 480M
    |__ Port 10: Dev 8, If 2, Class=Video, Driver=uvcvideo, 480M
    |__ Port 10: Dev 8, If 0, Class=Video, Driver=uvcvideo, 480M
    |__ Port 10: Dev 8, If 3, Class=Video, Driver=uvcvideo, 480M
    |__ Port 10: Dev 8, If 1, Class=Video, Driver=uvcvideo, 480M
    |__ Port 14: Dev 6, If 0, Class=Wireless, Driver=btusb, 12M
    |__ Port 14: Dev 6, If 1, Class=Wireless, Driver=btusb, 12M

It looks to me that xhci_hcd is identifying the camera as a USB 2.1 device. Does anyone know of a way to modify UDEV rules to force the device to the higher speed? Am I missing something else?
Thanks!

Hi @econeale  Can you confirm please that all of the USB cables that you are using are USB 3 cables and not USB 2.1 cables?  If a USB 3 device such as a camera is connected to a USB 2.1 cable then the device will be identified as USB 2.1.  This is because USB2 cables lack an additional wire that USB 3 cables have that allows the device to be identified as USB3.

Thanks very much.  I look forward to your next report.  Good luck!

It's great to hear that you achieved a solution.  Thanks very much for the update and for the product link!


[BUG] Macchina 6.1.4 doesn't report version when running macchina --version

Describe the bug
When running macchina --version it simply reports macchina on its own without the version number.
To Reproduce
Steps to reproduce the behavior:

Run macchina --version

Expected behavior
Command outputs macchina 6.1.4
Screenshots

macchina --doctor output
Let's check your system for errors... Here's a summary:

We've collected 18 readouts, including 2 failed read(s) and 1 read(s) which resulted in a warning.
Readout "Packages" failed with message: No packages found — Do you have a package manager installed?
Readout "LocalIP" failed with message: Unable to get local IPv4 address.

1 of the 3 unsuccessful read(s) resulted in a warning:
Readout "Distribution" threw a warning with message: Since you're on macOS, there is no distribution to be read from the system.

System Information
You don't have to provide this information if you're not comfortable doing so, but it'll help us solve the issue a lot faster.

Distribution: N/A
Desktop Environment: Aqua
Operating System: macOS Monterey 12.6 (21G115)
Terminal: wezterm 20220905-102802-7d4b8249
Macchina's version: 6.1.4

Fixed, thanks for the report


Add Linkerd support for blue/green (canary) deployments

Use case
As a user, I would like to use Linkerd to automate blue/green (canary) deployments orchestrated by Keptn.
Details

Currently, Istio is used to implement a traffic switch between the previous and new deployment (blue/green). The previous is considered to be the primary while the new one is the canary; More details on the deployment strategy are explained here: https://keptn.sh/docs/0.9.x/continuous_delivery/deployment_helm/#blue-green-deployments

In Keptn, the helm-service is implementing the functionality to handle the traffic routing. For Istio, this is implemented in: https://github.com/keptn/keptn/tree/069dd0f5c7b6f37a3737f4c0c9c7cf07a801b039/helm-service/pkg/mesh

Goal

Prerequisite:

Linkerd install on cluster
Keptn install on cluster
Keptn project & service created

Goal: The goal of this issue is to manage the traffic routing during a deployment roll-out, similar to the Linkerd tutorial implemented here:

When the deployment of a service went through successfully, the primary deployment is facing the traffic. This is the starting point of a roll-out:

When Keptn runs a delivery sequence, which contains a deployment task: Linkerd manages the traffic routing between the old deployment (primary) and new deployment (canary). Consequently, the canary is tested and evaluated during the deployment phase.

To trigger a delivery, e.g.: keptn trigger delivery --project=linkerd-tutorial --service=podinfo --image=podinfo --tag=0.11.2
Picture during the deployment phase:

Example of a delivery sequence in Keptn:

After the deployment of the new service version,  canary is promoted to the primary deployment which then faces the entire traffic (and represents the starting point for the next roll-out):

@johannes-b do we want to replace istio with linkerd or have it as an additional option?

@warber we won't replace Istio, but rather provide additional support by Linkerd.


Add a paging function allowing specify result page in data editor

Currently, there are "Fetch next page of results" and "Fetch all results" available in the data editor, I suggest adding a paging function where you can specify which page to fetch and go previous/next page (like Navicat shown in the screenshot below), so one can only fetch the pages they want instead of fetching all results before them.

Thanks for the feature request!


Webpack v5 support

Hi,
It'll be good for this plugin to support webpack v5. In the meantime Ive forked/rewritten it here https://github.com/burt202/nunjucks-webpack-plugin for anyone that wants v5 support sooner. It also simplifies the code and massively reduces (and updates) all dependencies
Cheers

@alexander-akait would it be possible to incorporate these improvements into this repo so that Webpack 5 is supported? Or would it be possible to pass the ownership/responsibility of this repository to someone would could update it and publish to NPM?

Sorry, I don't have time on this package, I can give permissions for this repo and npm

Im happy to take this on if you like. Let me know what I need to do

sent invite

Ok cool, i wont do anything immediately but I'll likely just override the whole repo with the code in the fork and then publish a v6. Ill keep the license and changelog bits though.
Also its worth noting, my fork doesnt port across all features, so I would be tempted to fix forward and see what people miss as time goes on.
How does that sound? Everyone happy with that?

Yep, feel free to send PRs, I will review

Ive just brought over the tests into my fork and one of them fails due to changes with webpack between v4 and v5 (to do with compilation.hash). I havent got time right now to look into this Im afraid but hopefully I can find some time soon to complete this update


Fixes iOS 13 reverting back to "Times New Roman" when changing the font size of default system fonts

Fixes iOS 13 reverting back to "Times New Roman" when changing the font size of default system fonts.
This fix uses the proper method for changing the font size of an existing font. You should not use internal Apple font names, they may change at any moment.

Please, can somebody merge this?


proper render of pellet block

(because currently it's a standard 1m^3 but non-collidable, which looks and feels cursed)

fixed!


Run mongo as replicaset in docker-compose

Currently mongodb is run configured as replicaset in production which exposes functionality like watching collections that are desirable.
Currently running it as replicaset in docker-compose doesn't pass the tests so we need some investigation of how to achieve this.
The issue is that the testGaloy user isn't being provisioned automatically so we need to investigate one of the following approaches:

dig deeper into the container and figure out if there actually is a way to statically configure
write a small hook that can be executed post docker-compose up as part of make start-deps
expose root creds to the test runner and have the test provision the user in a before hook

When running with the following configuration:
  mongodb:
    image: bitnami/mongodb:4.4.6-debian-10-r0
    ports:
    - "27017:27017"
    environment:
    - MONGODB_PASSWORD=password
    - MONGODB_USERNAME=testGaloy
    - MONGODB_DATABASE=galoy
    - MONGODB_REPLICA_SET_MODE=primary
    - MONGODB_ROOT_PASSWORD=password
    - MONGODB_REPLICA_SET_KEY=replicasetkey123

The log output indicates that the user is indeed being created:
$ docker-compose up mongodb                                                                                Creating galoy_mongodb_1 ... done                                                                                Attaching to galoy_mongodb_1                                                                                mongodb_1        | mongodb 13:20:27.71
mongodb_1        | mongodb 13:20:27.71 Welcome to the Bitnami mongodb container                                                                                mongodb_1        | mongodb 13:20:27.71 Subscribe to project updates by watching https://github.com/bitnami/bitnami-docker-mongodb
mongodb_1        | mongodb 13:20:27.71 Submit issues and feature requests at https://github.com/bitnami/bitnami-docker-mongodb/issues                                                                       mongodb_1        | mongodb 13:20:27.72
mongodb_1        | mongodb 13:20:27.72 INFO  ==> ** Starting MongoDB setup **                                                                                mongodb_1        | mongodb 13:20:27.73 INFO  ==> Validating settings in MONGODB_* env vars...
mongodb_1        | mongodb 13:20:27.73 WARN  ==> In order to use hostnames instead of IPs your should set MONGODB_ADVERTISED_HOSTNAME                                                                       mongodb_1        | mongodb 13:20:27.75 INFO  ==> Initializing MongoDB...
mongodb_1        | mongodb 13:20:27.77 INFO  ==> Deploying MongoDB from scratch...                                                                                mongodb_1        | mongodb 13:20:28.06 INFO  ==> Creating users...
mongodb_1        | mongodb 13:20:28.06 INFO  ==> Creating root user...
mongodb_1        | mongodb 13:20:28.18 INFO  ==> Creating 'testGaloy' user...
mongodb_1        | mongodb 13:20:28.32 INFO  ==> Users created
mongodb_1        | mongodb 13:20:28.32 INFO  ==> Writing keyfile for replica set authentication...
mongodb_1        | mongodb 13:20:28.34 INFO  ==> Configuring MongoDB replica set...
mongodb_1        | mongodb 13:20:28.36 INFO  ==> Stopping MongoDB...
mongodb_1        | mongodb 13:20:30.06 INFO  ==> Configuring MongoDB primary node
mongodb_1        | mongodb 13:20:30.26 INFO  ==> Stopping MongoDB...
mongodb_1        | mongodb 13:20:32.29 INFO  ==> Enabling authentication...
mongodb_1        | mongodb 13:20:32.31 INFO  ==> ** MongoDB setup finished! **
mongodb_1        |
mongodb_1        | mongodb 13:20:32.33 INFO  ==> ** Starting MongoDB **

add MONGODB_ADVERTISED_HOSTNAME=<IP_ADDRESS> fixes it


Issue running smurf

Hi, I am getting the following error from the pipeline, related to Smurf,
I have been trying to fix it over the last few days, do you know what might be wrong ?
Error:
Error executing process > 'short_variants:get_somatic_vcfs:smurf (SMuRF myfile.vcf)'
Caused by:
Process short_variants:get_somatic_vcfs:smurf (SMuRF myfile.vcf) terminated with an error exit status (1)
Command executed:
host=$(hostname)
echo ${host}
export projectDir=/apps/PTATO
python /smurf/SMuRF.py     -i myfile.vcf.gz      -b /work/fe/9dd25d0001393ff0faac5afcdaa6c6/Invitro_H1.bam -b /work/80/5c3c1bcabad477d1367007327d3c86/Invitro_Bulk.bam      -n Invitro_Bulk     -t 8     -c /apps/PTATO/resources/hg38/smurf/config_15cov.ini
bash /smurf/scripts/split_in_single_sample_vcfs.sh myfile.8X.SMuRF.filtered.vcf
for BULK in  -n Invitro_Bulk; do
if [[ "${BULK}" != "-n" ]]; then
rm myfile_${BULK}.SMuRF.filtered.vcf*
fi
done
Command exit status:
1
Command error:
Config file /apps/PTATO/resources/hg38/smurf/config_15cov.ini does not exists
grep: myfile.SMuRF.filtered.vcf: No such file or directory
grep: myfile.SMuRF.filtered.vcf: No such file or directory
grep: myfile.SMuRF.filtered.vcf: No such file or directory
grep: myfile.SMuRF.filtered.vcf: No such file or directory
rm: cannot remove ‘myfile_Invitro_Bulk.SMuRF.filtered.vcf*’: No such file or directory
Work dir:
/work/c7/5146411a97053bcf075d359fff81be
Tip: you can replicate the issue by changing to the process work dir and entering the command bash .command.run
Thanks!

Can you please check if this (config) file exists.
/apps/PTATO/resources/hg38/smurf/config_15cov.ini

Hi !
Yes it does exist, this is why this issue is quite unsettling

I have been able to "recreate" your error. Could it be that you didn't bind the path to your singularity? Can you change this line in the nextflow.config
  runOptions = '-B /hpc -B $TMPDIR:$TMPDIR'

to
  runOptions = '-B /apps -B $TMPDIR:$TMPDIR'

Maybe also good the check which (version of) singularity you use. We currently working on making a docker file and we had also some problems with singularity in the docker. When we changed it to apptainer version 1.1.3-1.el8 it looks like it works.

Thank you very much ! It solved my issue with singularity


Fix sanitycheck.fsx script

Closes #229
Closes #230
Closes #231
Closes #232

I'm gonna push1by1...

You should place the commit titled scripts/sanitycheck: throw if sln doesn't exist as the 1st in the PR, otherwise I don't see its effects in CI.

The title "Sanity check file location changes" is very confusing because it doesn't really summarize the PR properly. I think the main issue that makes it very ambiguous is the absence of any verb in it.

BTW please beware of your type chenges -> changes.

BTW please beware of your type chenges -> changes.

Typo: type->typo

Ok, let's squash properly.

I did NOT say squash commits into 1.

Bring back the sanity check

This PR title would make a future developer think that we had disabled or removed the sanity check and you brought it back. But this is not the case. The sanity check is/was there, you're just fixing one of its steps. Please fix the PR title.

Frontend.XF.*: sync & resolve packages conflict
This commit upgrades packages in Frotend.XF.* projects
to be in sync with versions used in Backend.
Sanity check was also complaining before this commit with
the following error:

Also? The error you're quoting is exactly the same as the thing you're referring to before that paragraph. It is not two different problems, so I think you should remove the word also.

Fix sanitycheck.fsx script

The sanitycheck script has many steps. Not all of them were broken. Please re-read (paying attention to detail) what I said in https://github.com/nblockchain/geewallet/pull/236#issuecomment-1767607747

scripts/sanitycheck.fsx: fix dotnet legacy

dotnet legacy??? That sounds so weird and looks like a contradiction, given that in .NET4.x (legacy), the command dotnet doesn't exist. Please change the above to read .NET legacy to avoid any possible confusions.

Readjustment sanitycheck.fsx script

Why did you remove the word "fix" from the title? I did not have a complain about that word. Please read again my previous complaint @Mersho .


feat: solve typeclass subgoals in reverse order

@leodemoura I fixed the order of all the transitive instances, so Lean4 does compile on this branch. However, I only changed the order as necessary for termination.  Before merging, please swap the order of inst-implicit arguments to other instances as appropriate for performance reasons.

merged


[Feature] Use JPlag for text exercises plagiarism detection

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.
[x] Server: I added @PreAuthorize and check the course groups for all new REST Calls (security)
[x] Server: I implemented the changes with a good performance and prevented too many database calls
[x] Server: I documented the Java code using JavaDoc style.
[x] Client: I documented the TypeScript code using JSDoc style.
[x] Client: I added multiple screenshots/screencasts of my UI changes
[x] Client: I translated all the newly inserted strings into German and English

Motivation and Context
Plagiarism detection for text exercises does not support JPlag yet. However, our current plagiarism detection algorithm is quite slow so JPlag might be the preferable option. The user should be able to decide which strategy/algorithm to use when triggering the plagiarism detection.
Description
The Artemis client application can now call the /check-plagiarism endpoint for text exercises and pass an optional strategy parameter to specify the strategy to use for text exercise comparison. If no strategy parameter is specified, the algorithm will default to the current implementation.
Example request to trigger the plagiarism detection using JPlag:
GET http://localhost:9000/api/text-exercises/13/check-plagiarism?strategy=JPlag
Note: As discussed with @krusche, this PR does not contain tests for the new functionality. These tests will be implemented in a follow-up PR.
Steps for Testing

Log in to Artemis
Navigate to Course Administration
Create a text exercise
Create similar submissions for the text exercise on multiple student accounts
Log in as the course instructor and navigate to the exercise details view

Make sure that:

Clicking on "Check Plagiarism" now offers a third option called "JPlag"
Clicking on "JPlag" correctly sets the strategy=JPlag parameter in the GET request
The server responds with a ZIP file containing the JPlag output (a bunch of HTML files, no need to check those)

Screenshots

Worked as advertised when testing. Two observations which are more questions than blockers:

Clicking "Check Plagiarism" does nothing when there only is one submission (and possibly in other cases I don't know about). But that is the same with CSV, so probably not an issue for this PR. In comparison to CSV however (which does print a warning), using JPlag crashes which should probably be avoided:

ERROR Error: Parameter "key" required
    instant ngx-translate-core.js:990
    addAlert ng-jhipster.js:4368
    addErrorAlert alert-error.component.ts:131
    httpErrorListener alert-error.component.ts:82
    RxJS 13
    broadcast ng-jhipster.js:4222
    intercept errorhandler.interceptor.ts:26
    RxJS 8
    onLoad Angular
    sentryWrapped helpers.js:72
    Angular 7
instrument.js:109

(Crashing also leaves some leftover files in the 'tmp' folder.)

The zip file remains in the 'tmp' folder after downloading, is that intended? (Is 'tmp' regularely cleared in another way?)

Thanks for your review, Lukas! I also noticed the issue when too few submissions are available for comparison. Because this error also exists in the current plagiarism detection, as you mentioned, I plan to handle this error in a dedicated follow-up PR. The zip file will be scheduled for deletion and should be removed after 5 minutes 👍


Force deleting sources/javadoc to fix sbt/sbt#1750

Replaces (wip) #15 PR.

Restarting Travis.

Some history I found, for the present day and future reviewers here.
A more generic fix for this was attempted in sbt/sbt#637 and reverted in sbt/sbt#1234 due to the fall out in sbt/sbt#1091.
Is this going to cause that effect? I'm not sure but I hope not..

@eed3si9n Added another commit which adds details.
@jsuereth Can you just sanity check I'm not fibbing :) thanks

Travis is very confused about where the branch it's meant to build is found (it's not looking in my clone). Closing and reopening in an attempt to fix.

If we can get this behind a settings flag, I'm all for it.

https://github.com/sbt/sbt/pull/2163 got merged, which uses the ivy built from d21bcdd997a724338fbb06ecb82453c1431ff6e6 (pre sbt comments commit).
For consistency I'm going to merge my branch, but I'll follow up with another PR with the agreed upon changes discussed here.


[Improvement][doc]fix typo in readme

Purpose of the pull request
Fix a typo, and by the way just try my first ci to get familiar with PR process
This pull request is code cleanup without any test coverage.

Codecov Report

Merging #14878 (06df444) into dev (5062aa1) will decrease coverage by 0.02%.
The diff coverage is n/a.

:exclamation: Current head 06df444 differs from pull request most recent head 1429b1b. Consider uploading reports for the commit 1429b1b to get more accurate results

@@             Coverage Diff              @@
##                dev   #14878      +/-   ##
============================================
- Coverage     38.89%   38.87%   -0.02%
+ Complexity     4585     4583       -2
============================================
  Files          1232     1232
  Lines         43237    43205      -32
  Branches       4772     4755      -17
============================================
- Hits          16817    16798      -19
+ Misses        24560    24548      -12
+ Partials       1860     1859       -1

see 24 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Clean and flat all icon in bolt

Jira
http://vjira2:8080/browse/BDS-2023
Summary
Clean and flat all icons in the bolt.
How to test
Run bolt locally and check if icons rendered correctly. Try to change color of the icon to different one and check if working eg.
<bolt-icon style="color: #7ACDCD; --bolt-theme-icon: #7ACDCD;" name="face-sad" size="xlarge"></bolt-icon>
Please check that on various of browsers.

@adamszalapski @remydenton I'd recommend holding on this until I get my PR for http://vjira2:8080/browse/BDS-2012?filter=-1 in place.
Based on local testing I think this PR I'm working on might address the Firefox and Safari issues / theming issues we were seeing with only requiring 1 SVG icon to be updated.

Fixed by https://github.com/boltdesignsystem/bolt/pull/1747


Expose merge_system_user_message for ilab model train --strategy lab-multiphase

Describe the bug
Mixtral-based models (e.g. Prometheus) don't allow System messages to precede User messages in its template. We merge the first System message with the first User message so messages lists don't break VLLM serving. This is okay but might not be ideal if it's hard-coded.
Direct link: https://github.com/instructlab/instructlab/blob/a6f21450dcfc7619fb27d648137614872a691934/src/instructlab/model/train.py#L812

Is this a bug? Or an enhancement?

This may no longer be necessary with: https://github.com/instructlab/eval/pull/100
If we can detect the models that need merge-system-user-message reliably, we can potentially just deprecate the option from evaluate as unnecessary.

@JamesKunstle - is this still relevant or can we close this?

I'm not sure if it's relevant anymore. I created the issue when I had to debug this but it might be fixed by the eval side.

I'm not sure if it's relevant anymore. I created the issue when I had to debug this but it might be fixed by the eval side.

I think it's still a bit of an issue that it's hardcoded here:
https://github.com/instructlab/instructlab/blob/main/src/instructlab/model/accelerated_train.py#L595
If we just remove that line, we could declare it's no longer an issue.  The only downside then would be the code is a bit fragile.  The only thing that would cause it to select the right value then is:
https://github.com/instructlab/eval/blob/cd0487eff651922acdaf6d265212a3741153ddd8/src/instructlab/eval/mt_bench_model_adapter.py#L97
and
https://github.com/instructlab/eval/blob/cd0487eff651922acdaf6d265212a3741153ddd8/src/instructlab/eval/mt_bench_common.py#L274
which selects the adapter/conversation template based on the model name.  In our case it would match for prometheus.  The fragileness being that other model names might need the setting that we don't recognize.  But I think that's still better than hardcoding True in phased training.


OSRM table nodejs bindings tutorial

@nilsnolde do you want to give this a quick read before merge?

Oh jep, sorry, lost sight of that. Will do tmrw


fix(): add GetConditions() & SetConditions() for JWTOIDCAuthEngineRol…

fix() for JWTOIDCAuthEngineRole type :

GetConditions()
SetConditions()

@raffaelespazzoli pls, check this and let me know.

hello, to avoid that error that you are getting at build time, can you change the relevant make target to this:
KUSTOMIZE_INSTALL_SCRIPT ?= "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh"
kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary.
$(KUSTOMIZE): $(LOCALBIN)
	rm $(KUSTOMIZE) || true
	curl -s $(KUSTOMIZE_INSTALL_SCRIPT) | bash -s -- $(subst v,,$(KUSTOMIZE_VERSION)) $(LOCALBIN)

hello, to avoid that error that you are getting at build time, can you change the relevant make target to this:
KUSTOMIZE_INSTALL_SCRIPT ?= "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh"
kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary.
$(KUSTOMIZE): $(LOCALBIN)
	rm $(KUSTOMIZE) || true
	curl -s $(KUSTOMIZE_INSTALL_SCRIPT) | bash -s -- $(subst v,,$(KUSTOMIZE_VERSION)) $(LOCALBIN)

@raffaelespazzoli tbh, the workflow seems to fail in the target :

.PHONY: deploy-vault
deploy-vault: kubectl helm
$(KUBECTL) create namespace vault --dry-run=client -o yaml | kubectl apply -f -
$(KUBECTL) apply -f ./integration/rolebinding-admin.yaml -n vault
$(HELM) repo add hashicorp https://helm.releases.hashicorp.com
$(HELM) upgrade vault hashicorp/vault -i --create-namespace -n vault --atomic -f ./integration/vault-values.yaml
$(KUBECTL) wait --for=condition=ready pod/vault-0 -n vault --timeout=5m

Thanks,
Erlis

@raffaelespazzoli, can you create a release with these changes. Thnx

trying to. But the release still not building... https://github.com/redhat-cop/vault-config-operator/actions/runs/3514571576
…
On Thu, Nov 24, 2022 at 9:34 AM Erlis Balla @.> wrote: @raffaelespazzoli https://github.com/raffaelespazzoli, can you create a release with these changes. Thnx — Reply to this email directly, view it on GitHub <#81 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPERXCAE3CCUJFSPMC5Q73WJ54GLANCNFSM6AAAAAASAHMBN4 . You are receiving this because you were mentioned.Message ID: @.>
-- ciao/bye Raffaele

maybe this will fix it : https://github.com/redhat-cop/vault-config-operator/pull/84

that fix is already in main. we cannot reduce the issue on our laptop.
Maybe it's just a matter of increasing the timeout, but I doubt it.
On Thu, Nov 24, 2022 at 9:53 AM Erlis Balla @.***>
wrote:

trying to. But the release still not building...
https://github.com/redhat-cop/vault-config-operator/actions/runs/3514571576
… <#m_5301837127315079245_>
On Thu, Nov 24, 2022 at 9:34 AM Erlis Balla @.> wrote:
@raffaelespazzoli https://github.com/raffaelespazzoli
https://github.com/raffaelespazzoli https://github.com/raffaelespazzoli,
can you create a release with these changes. Thnx — Reply to this email
directly, view it on GitHub <#81 (comment)
https://github.com/redhat-cop/vault-config-operator/pull/81#issuecomment-1326531577>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPERXCAE3CCUJFSPMC5Q73WJ54GLANCNFSM6AAAAAASAHMBN4
https://github.com/notifications/unsubscribe-auth/ABPERXCAE3CCUJFSPMC5Q73WJ54GLANCNFSM6AAAAAASAHMBN4
. You are receiving this because you were mentioned.Message ID: @.>
-- ciao/bye Raffaele
maybe this will fix it : #84
https://github.com/redhat-cop/vault-config-operator/pull/84
—
Reply to this email directly, view it on GitHub
https://github.com/redhat-cop/vault-config-operator/pull/81#issuecomment-1326554493,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPERXGSOOWYAHOQH22AYNDWJ56P5ANCNFSM6AAAAAASAHMBN4
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
ciao/bye
Raffaele

if you don't mind, try to run the helm chart test from make directly on
your laptop and see if you can reproduce the issue.
On Thu, Nov 24, 2022 at 10:07 AM raffaele spazzoli <
@.***> wrote:

that fix is already in main. we cannot reduce the issue on our laptop.
Maybe it's just a matter of increasing the timeout, but I doubt it.
On Thu, Nov 24, 2022 at 9:53 AM Erlis Balla @.***>
wrote:

trying to. But the release still not building...
https://github.com/redhat-cop/vault-config-operator/actions/runs/3514571576
… <#m_7058048816404670265_m_5301837127315079245_>
On Thu, Nov 24, 2022 at 9:34 AM Erlis Balla @.> wrote:
@raffaelespazzoli https://github.com/raffaelespazzoli
https://github.com/raffaelespazzoli https://github.com/raffaelespazzoli,
can you create a release with these changes. Thnx — Reply to this email
directly, view it on GitHub <#81 (comment)
https://github.com/redhat-cop/vault-config-operator/pull/81#issuecomment-1326531577>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPERXCAE3CCUJFSPMC5Q73WJ54GLANCNFSM6AAAAAASAHMBN4
https://github.com/notifications/unsubscribe-auth/ABPERXCAE3CCUJFSPMC5Q73WJ54GLANCNFSM6AAAAAASAHMBN4
. You are receiving this because you were mentioned.Message ID: @.>
-- ciao/bye Raffaele
maybe this will fix it : #84
https://github.com/redhat-cop/vault-config-operator/pull/84
—
Reply to this email directly, view it on GitHub
https://github.com/redhat-cop/vault-config-operator/pull/81#issuecomment-1326554493,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPERXGSOOWYAHOQH22AYNDWJ56P5ANCNFSM6AAAAAASAHMBN4
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
ciao/bye
Raffaele

--
ciao/bye
Raffaele

It takes ~ 1m. Please, check the logs :

erlisb @ LHIND-N211647 ➜  /home/erlisb/testing/vault-config-operator git:(JWT/OIDC-auth-engine-role) ✗ make helmchart-test | awk '{ print strftime("[%Y-%m-%d %H:%M:%S]"), $0 }'
[2022-11-24 16:36:11] /usr/local/bin/kubectl create namespace vault --dry-run=client -o yaml | kubectl apply -f -
[2022-11-24 16:36:11] namespace/vault configured
[2022-11-24 16:36:11] /usr/local/bin/kubectl apply -f ./integration/rolebinding-admin.yaml -n vault
[2022-11-24 16:36:11] rolebinding.rbac.authorization.k8s.io/admin unchanged
[2022-11-24 16:36:11] /usr/local/bin/helm repo add hashicorp https://helm.releases.hashicorp.com
[2022-11-24 16:36:12] "hashicorp" already exists with the same configuration, skipping
[2022-11-24 16:36:12] /usr/local/bin/helm upgrade vault hashicorp/vault -i --create-namespace -n vault --atomic -f ./integration/vault-values.yaml
[2022-11-24 16:36:12] Release "vault" does not exist. Installing it now.
[2022-11-24 16:36:19] NAME: vault
[2022-11-24 16:36:19] LAST DEPLOYED: Thu Nov 24 16:36:13 2022
[2022-11-24 16:36:19] NAMESPACE: vault
[2022-11-24 16:36:19] STATUS: deployed
[2022-11-24 16:36:19] REVISION: 1
[2022-11-24 16:36:19] NOTES:
[2022-11-24 16:36:19] Thank you for installing HashiCorp Vault!
[2022-11-24 16:36:19]
[2022-11-24 16:36:19] Now that you have deployed Vault, you should look over the docs on using
[2022-11-24 16:36:19] Vault with Kubernetes available here:
[2022-11-24 16:36:19]
[2022-11-24 16:36:19] https://www.vaultproject.io/docs/
[2022-11-24 16:36:19]
[2022-11-24 16:36:19]
[2022-11-24 16:36:19] Your release is named vault. To learn more about the release, try:
[2022-11-24 16:36:19]
[2022-11-24 16:36:19]   $ helm status vault
[2022-11-24 16:36:19]   $ helm get manifest vault
[2022-11-24 16:36:19] /usr/local/bin/kubectl wait --for=condition=ready pod/vault-0 -n vault --timeout=5m
[2022-11-24 16:37:29] pod/vault-0 condition met
[2022-11-24 16:37:29] rm -rf ./charts
[2022-11-24 16:37:29] mkdir -p ./charts/vault-config-operator/templates
[2022-11-24 16:37:29] mkdir -p ./charts/vault-config-operator/crds
[2022-11-24 16:37:29] repo=vault-config-operator envsubst < ./config/local-development/tilt/env-replace-image.yaml > ./config/local-development/tilt/replace-image.yaml
[2022-11-24 16:37:29] /home/erlisb/testing/vault-config-operator/bin/kustomize build ./config/helmchart -o ./charts/vault-config-operator/templates


Added Cross partition query tests for sync and async APIs

Description:

Current query (both sync and async) tests are running on single partition collections.
Duplicated the same query tests to run on multiple partition collection for sync and async APIs.

API change check
API changes are not detected in this pull request.

/azp run python - cosmos - tests

/azp run python - cosmos - tests

/azp run python - cosmos - ci

/azp run python - cosmos - ci

/azp run python - cosmos - tests

/azp run python - cosmos - tests

Still going through the files but figured I'd leave two comments on things I saw.
Firstly, I see that the use of the unittest package has been re-added to the SDK tests in several places - we had recently moved away from using that package since it was supposed to have issues with running async tests and most/all other Python SDKs are no longer using it in favor of the default pytest package and the test proxy that Core offers (that we purposely don't use since we don't want to run tests against recordings.) Here was the PR: https://github.com/Azure/azure-sdk-for-python/pull/32076 - I believe to be aligned with everyone else we should probably not re-add this package unless we absolutely need it for some reason.
Secondly, more of a nitpick, but I see in several files there is not a blank line at the end of the files - which I believe is a formatting rule that we try to use in all our SDKs (I believe even Java does the same).
So far so good with the actual changes though, and it does seem like the pipelines are all passing 👍 thanks Kushagra!

@simorenoh - understood, however, unittest only had issues with running async tests because of python 3.7. Starting python 3.8 it can run both sync and async just fine. Currently I am using both unittest and pytest.
unittest is great for standard testing practices as it provides boiler plate code for setup, teardown, setupClass and tearDownClass whereas pytest is used for fixtures which are used across the whole test setup. In my opinion, pytest is more advanced and might be an overkill in some of the basic test setup.
Regarding new line at the end, I will add one.


Read vertical bar as "bar" rather than "divides" by default

Currently, it seems that MathCAT reads the vertical bar as "divides" by default. Note that the vertical bar can be used to indicate norm, absolute value, conditioning (probability), set builder notation, divisibility, etc. In my experience, I encounter cases of absolute value and conditioning way more than the rest, but that is likely because I am taking more statistics classes and my experience is not representative. That said, I don't think that divisibility is the most common context either. While the eventual goal would be to read the vertical bars in a context-aware manner, for now, I'd say the default reading should be "bar" and not "divides." It is shorter, more neutral, and less misleading.

There are several vertical line characters. The most commonly used one is "|" (U+007C)
The one that has "divides" as the default is U+2223. This characters is explicitly called "divides" by the Unicode standard and is meant to be used for that purpose (it is a little shorter in height than U+007C.
If you are using ClearSpeak (as opposed to SimpleSpeak), then the ClearSpeak standard has rules that will fallback to saying "divides". I've encoded them. ClearSpeak (which I helped to create) is far from perfect, so potentially it can be changed, but I'm a little reluctant to make a change without trying to change the standard (which is hard because there is no group maintaining ClearSpeak). Here is the rule:
     - test:
           # if it isn't ClearSpeak, or if there is nothing before the char or after the char...
        - if: "$SpeechStyle != 'ClearSpeak' or not(preceding-sibling::*) or not(following-sibling::*)"
          then: [t: "vertical line"]
        - else_if: "$ClearSpeak_VerticalLine = 'SuchThat'"
          then: [t: "such that"]
        - else_if: "$ClearSpeak_VerticalLine = 'Given'"
          then: [t: "given"]
        - else: [t: "divides"]

Note:  $ClearSpeak_VerticalLine is a preference that can be set by changing the value in prefs.yaml. So far, I haven't added the ClearSpeak preferences to the NVDA dialog.


Update DirecTV Now to AT&T TV

Checklist

[x] I'm reporting a feature request
[x] I've verified that I'm running youtube-dl version 2020.07.28
[x] I've searched the bugtracker for similar feature requests including closed ones

Description

I can not download anything from Discovery Go or any related networks by passing my AT&T TV (--ap-list-mso: ATTOTT) login credentials. It seems that the rebrand of Direct TV Now to AT&T TV might be interfering with Youtube-dl's ability to use the login credentials. I know it's not a geo blocking issue because I can login and watch content via my browser without issue, here's proof, as well as the actual link to demonstrate it's not one of the free episodes that doesn't require a login, and passing a cookie file to Youtube-dl does work. On top of it these exact same credentials worked before the rebrand to AT&T TV. Here is the current code concerning ATTOTT:
    'ATTOTT': {
        'name': 'DIRECTV NOW',
        'username_field': 'email',
        'password_field': 'loginpassword',
    },

But when presented with the AT&T TV Login page (when logging in via the browser) the username field ID is userName while the password field ID is password as shown here so I forked Youtube-dl to change that to the field ID:
    'ATTOTT': {
        'name': 'AT&T TV',
        'username_field': 'userName',
        'password_field': 'password',
    },

and when that didn't work I tried the field name (both with and without the underscore in USER ID):
    'ATTOTT': {
        'name': 'AT&T TV',
        'username_field': 'User_ID',
        'password_field': 'Password',
    },

but neither seem to get AT&T TV/DirecTV now back up and running. I do have an active login so I can help troubleshoot this as much as needed to get this login in working order again. I am not being geo-restricted: I am a US Citizen, I am currently physically in the US, using a US TV provider (AT&T TV), attempting to use a US service.

Has there been any progress on getting this fixed?

None from what I can tell.

In case you had not heard, AT&T partially divested themselves of this service, so it is now known as DirecTV Stream, which apparently is different from regular DirecTV (you can't use a DirecTV Stream login on the DirecTV site or vise versa).  But something is still broken with regard to logging in using that service.

If someone can provide credentials I can work on this.


added support for building on linux

it doesn't work on my machine. I have always used to Linux to build Garb and there have been no problems. Also please provide a description from next time.


Self-Documented Configuration Reference xml delay class wrong

On page Norconex HTTP Collector Configuration https://www.norconex.com/collectors/collector-http/configuration link for self-documented config https://www.norconex.com/collectors/collector-http/latest/examples/collector-http-config-reference.xml got delay section:
<delay default="1000" ignoreRobotsCrawlDelay="true"
           class="$http.delay.impl.DefaultDelayResolver">
          <schedule dayOfWeek="from Monday to Friday"
                    time="from 8:00 to 16:30">10000</schedule>
    </delay>

Provided here class value is wrong - $http.delay.impl.DefaultDelayResolver and crawler totally ignores all other attributes value and procceed with default values.

This was an error in the documentation.  The actual name is GenericDelayResolver.
I have updated the collector-http-config-reference.xml  file.
Thanks for reporting!


@external autocomplete duplicates the @ sign

Version: v2.7.0
Autocompleting

produces

I didn't find any prior issues; I'm also not sure if this is a vscode-gleam-specific thing or if this should be in https://github.com/gleam-lang/gleam, so sorry in advance.

Hello! Yes this is from the snippets in this repo


Update the cognito userpools sample

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Update fixes the breaking issue, but please remove the unused import statements for cleanup


[C4GT] provide 'update' method for stream contents

What is this enhancement about?
Today, we have stream.create() and stream.revoke() methods added in cord.js SDK. We need to build proper interfaces and methods for stream.update() extrinsic, so we can get started with full fledged integration with current studio and any other tools like sunbird RC.
How to test?
Enhance yarn demo to perform stream.update, and make sure we see stream.updated event on chain using explorer UI.
What are the things to consider?

content module will have to get a proper 'update()' method too, which should be passed for stream module.

Created another issue with proper formatting needed for displaying on C4GT portal


[cxx-interop] Update a test on Linux

libstdc++ currently cannot be split into submodules due to the way some types are defined, e.g. there are multiple headers that define size_t, so those headers must be a single (sub-)module.

@swift-ci please smoke test


SSDP error - No sockets available, cannot start.

Any thoughts on what might be causing this error? Rebooting seems to fix it. I am running Homebridge on an Ubuntu 22.04 box. It is running Homebridge v1.5.0 and the latest version of the plugin.
Unhandled rejection Error: No sockets available, cannot start.
    at SsdpClient.SSDP._createSockets (/var/lib/homebridge/node_modules/homebridge-konnected/node_modules/node-ssdp/lib/index.js:186:11)
    at SsdpClient.SSDP._start (/var/lib/homebridge/node_modules/homebridge-konnected/node_modules/node-ssdp/lib/index.js:229:10)
    at /var/lib/homebridge/node_modules/homebridge-konnected/node_modules/node-ssdp/lib/client.js:60:10
    at Promise._execute (/var/lib/homebridge/node_modules/homebridge-konnected/node_modules/bluebird/js/release/debuggability.js:384:9)
    at Promise._resolveFromExecutor (/var/lib/homebridge/node_modules/homebridge-konnected/node_modules/bluebird/js/release/promise.js:518:18)
    at new Promise (/var/lib/homebridge/node_modules/homebridge-konnected/node_modules/bluebird/js/release/promise.js:103:10)
    at SsdpClient.start (/var/lib/homebridge/node_modules/homebridge-konnected/node_modules/node-ssdp/lib/client.js:54:10)
    at SsdpClient.search (/var/lib/homebridge/node_modules/homebridge-konnected/node_modules/node-ssdp/lib/client.js:82:17)
    at KonnectedHomebridgePlatform.discoverPanels (/var/lib/homebridge/node_modules/homebridge-konnected/src/platform.ts:328:16)
    at Timeout._onTimeout (/var/lib/homebridge/node_modules/homebridge-konnected/src/platform.ts:395:14)
    at listOnTimeout (node:internal/timers:559:17)
    at processTimers (node:internal/timers:502:7)

This plugin is no longer managed by me at this location, I will be working on it l, and managing issues on my own GitHub repo externally under @mkormendy.


[SMALLFIX] Use the @Nullable annotation for all methods which may ret…

…urn null in MockMaster.java

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16339/Failed Tests: 2org.alluxio:alluxio-tests: 2alluxio.shell.command.TailCommandIntegrationTest.alluxio.shell.command.TailCommandIntegrationTestalluxio.shell.command.TestCommandIntegrationTest.alluxio.shell.command.TestCommandIntegrationTest
Test FAILed.

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16348/Failed Tests: 1org.alluxio:alluxio-tests: 1alluxio.master.JournalShutdownIntegrationTest.multiMasterMountUnmountJournal
Test FAILed.

jenkins, test this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/16369/
Test PASSed.


Add optional hash argument to transform_keys{!,}

This PR updates the signatures for Hash#transform_keys and Hash#transform_keys! to recognize the optional hash argument introduced in Ruby 3.0
Motivation
I wanted to use this functionality in my project, and was surprised that sorbet thought there was an error!
Test plan
See included automated tests.

👋 !

ohai! thanks!


KYLIN-3477 Save spark job counter to hdfs

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build 3474

0 of 40 (0.0%)  changed or added relevant lines in 7 files are covered.
14 unchanged lines in 6 files lost coverage.
Overall coverage decreased (-0.02%) to 22.903%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/HBaseSparkSteps.java
0
1
0.0%

engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkBatchCubingJobBuilder2.java
0
1
0.0%

engine-mr/src/main/java/org/apache/kylin/engine/mr/JobBuilderSupport.java
0
2
0.0%

storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/SparkCubeHFile.java
0
7
0.0%

engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkExecutable.java
0
7
0.0%

engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkFactDistinct.java
0
9
0.0%

core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java
0
13
0.0%

Files with Coverage Reduction
New Missed Lines
%

core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java
1
81.08%

core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java
1
23.17%

core-metadata/src/main/java/org/apache/kylin/metadata/cachesync/Broadcaster.java
1
57.71%

storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/SparkCubeHFile.java
2
4.42%

engine-spark/src/main/java/org/apache/kylin/engine/spark/SparkFactDistinct.java
3
0.0%

core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java
6
77.2%

Totals

Change from base Build 3473:
-0.02%

Covered Lines:
15816

Relevant Lines:
69055

💛  - Coveralls

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@32c6593). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master    #210   +/-   ##
========================================
  Coverage          ?   20.9%
  Complexity        ?    4326
========================================
  Files             ?    1079
  Lines             ?   69055
  Branches          ?   10009
========================================
  Hits              ?   14434
  Misses            ?   53241
  Partials          ?    1380

Impacted Files
Coverage Δ
Complexity Δ

...ache/kylin/storage/hbase/steps/SparkCubeHFile.java
3.53% <0%> (ø)
0 <0> (?)

...org/apache/kylin/engine/spark/SparkExecutable.java
0% <0%> (ø)
0 <0> (?)

.../org/apache/kylin/engine/mr/JobBuilderSupport.java
0% <0%> (ø)
0 <0> (?)

...g/apache/kylin/engine/spark/SparkFactDistinct.java
0% <0%> (ø)
0 <0> (?)

...che/kylin/storage/hbase/steps/HBaseSparkSteps.java
0% <0%> (ø)
0 <0> (?)

.../java/org/apache/kylin/common/util/HadoopUtil.java
18.29% <0%> (ø)
10 <0> (?)

...ylin/engine/spark/SparkBatchCubingJobBuilder2.java
0% <0%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c6593...64904a6. Read the comment docs.


Housekeeping Task Viewer

Various housekeeping things in the frontend:

[x]  Horizontal scrollbar for team-score view is always present
[x] Debounce task state queries (this is an issue, if many submissions are made in batch style)
[x] Previews: Have a placeholder (instead of the missing)
[x] Previews: Regularly update (in case the backend has produced them)
[ ] Add option to force-scale team information to fit on screen
[x] Add visual highlight to new submission/submitting team
[x] Sort bar charts by score

I added two more items to the list, based on experiences of the last evaluation.

Ad number two (Debounce task state queries..."): Am I assuming correctly, that you mean RunState instead of task state?

Ad number two (Debounce task state queries..."): Am I assuming correctly, that you mean RunState instead of task state?

I think you are right, proper wording would have been "Debounce task viewer's run state queries"

I'd suggest to move 'Add option to force-scale team information to fit on screen' to a new issue, together with centring of the team boxes in case there are fewer than the width and the polishing of the score display.

Moved 'Add option to force-scale team information to fit on screen' to #142


Hydrate callback

Feature request
Is your feature request related to a problem? Please describe.
A third-party library needs to adjust the DOM, but it must happen after hydration is complete.
Describe the solution you'd like
ReactDOM allows for a hydrate callback, but it is not added here
I would like to be able to pass a function in some way that would fire on hydrate-complete.

If it isn't what you're talking about, would be useful for JSS too: https://github.com/cssinjs/examples/blob/gh-pages/react-ssr/src/client.js#L5

Looks like you only need this feature on the client. Maybe React s componentDidMount will solve your problem in a more elegant way.

Yeah, componentDidMount would suffice for this.


[Imath] vcpkg clean failed

Hello,
I tried to update Imath, but CI failed because of failing vcpkg clean.
The details is following:

x64_windows
x64_uwp

I’d appreciate it if you can.

@sukeya For the exception thrown by the cleanup operation, it is possible that the load caused the command to fail. I have re-run the ci. :)

Related PR https://github.com/microsoft/vcpkg/pull/31944

Thank you!

Closed this issue due to https://github.com/microsoft/vcpkg/pull/31944.


stem2wav

Where is stem2wav? How to install that? I see stempeg 0.1.3 does not have that.

0.1.3 includes it (see here. It should come when you install it via pip

For stempeg 0.1.2, a message tells me where that script is installed. But 0.1.3 does not have that. I use that script from 0.1.2, works now.


Box shadow on light modes

On the game startup in white mode the tiles has a box shadow due to which the white background of the tiles is visible. After choosing the wrong options when the tiles reappear the shadow is removed.

I have fixed the issue and generating a PR now


Version 2.5.0

Windows compatibility (thanks, @daanzu!)
This is just a version bump PR.

tfatool-v2.5.0 is now installable with pip install tfatool, and it ought to fix Windows users' path problems.


Handled error page in books buy, added error page

Fixes #(issue number)
#250

Describe the changes you've made
A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!
Added error page, handled error while buying books
Deploy your changes to github page or netlify and mention deployment link:
Add the deployment link here.
Describe if there is any unusual behaviour of your code(Write NA if there isn't)
A clear and concise description of it.
NA
Additional context (OPTIONAL)
You can also configure this error page while configuring it in NGINX.
Test plan (OPTIONAL)
A good test plan should give instructions that someone else can easily follow.
How someone can test your code?
Checklist

[250 ] I have mentioned related issue number in PR description.
[ ] I have added screenshots and related demo links of my changes..
[ ] The title of my pull request is a short description of the requested changes.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] Open Source Program names(OPTIONAL: If you participated in any open-source program then please mention the program name here)

@c99SRS go through the entire website and replace the dummy page with error.html.
and add hyperlinks to the error page wherever it is required.

Sure @QAZIMAAZARSHAD

HI @QAZIMAAZARSHAD I have updated all the dummy pages with an error pages. please review it and merge it


Add Nong Song

Song Name
Apprehension
Artist Name
MyNewSoundtrack - MasterSwordRemix
Source
Youtube
Youtube Link
https://youtu.be/EJEbnsu1GFA?si=UhLPJrA2n_1slv9K
Direct File Link
No response
Song ID
7629
Start Offset [ms]
No response
Extra
No response

accept


Regex doesn't work for all possible whitespaces (only for 1 space character)

The main issue with this regex:
var result = data.replace(/^(\s?)+Version: \d+\.\d+\.\d+$/mg, 'Version: ' + newVersion)

It only works if there is exactly one space between Version: and version number, such as 1.0.0.
But it doesn't work for cases like:
Version:         1.0.0

Fixed in https://github.com/fredbradley/gh-action-wordpress-version-update/pull/2 Feel free to merge.