Bug/Snag Inventory

Go over every click on every SG page; note below the page in question and anything needing attention or not working.
General

All pages

[x] Replace tooltip white on black center-justified styling with something less jarring: e.g. black on white, left-justified

Home: http://localhost:8001/

[x] Attribution button misplaced (too high)
[x] On initial load, features for 1st object (collection number 2 typically) don't display, but when it comes around in the circuit, they do
[x] ~Loading of one of the featured datasets is leaving a map spinner~ NB some sample datasets are dicey for unknown reasons; set featured - NULL on a few, now all display w/above caveat
[x] Remove footer text (development deferred to #200)

Gallery: http://localhost:8001/datasets/gallery/datasets/

[x] Something off with the map padding for all datasets/collections
[x] ~Atlas of Mutual Heritage in gallery missing tileset error
jquery-3.6.3.min.js:2  GET http://tiles.whgazetteer.org:8080/data/datasets-40.json 404 (Not Found)~ SG: I can't replicate this - perhaps it's gone away, or perhaps you have a dodgy version cached in LocalStorage?

Search: http://localhost:8001/search/

[x] ~kg: Remove tooltip from input! sg I suggested (2 below) to keep it but hide on focus; kg removed, sorry!~
[x] Clear previous results when Advanced Options or Spatial Filter is changed
[x] On clear, display #initial_results blurb, not no_results message
[x] Clear search mode and input tooltips on focus (search mode tooltip is now disabled after focus so will appear again only on the next visit to the page; input tooltip additionally has a localStorage variable which will prevent its reappearance even on revisiting).
[x] Spatial filter text input: remove non-bs title, and clarify bs-tooltip wording wrt Region/Country dropdown
[x] ~Portal links require tooltips~ kg: disagree
[x] ~Results require tooltips to explain click action (remove cursor: pointer)~ kg: disagree
[x] Increase (even remove?) #result_container max-height kg: not if it means scrolling the map out of view sg: nope - it's limited to the viewport height...show me :^)

Place Portal: http://localhost:8001/places/12346428/portal/

[x] $(".pop-dataset").popover({ for dataset source got lost; added to portal.js but event propagates to #source_box action, unlike the notes button

Areas: http://localhost:8001/areas/create/

[x] Draw areas tab generates this error: areas.bundle.js:165 Uncaught TypeError: Cannot read properties of undefined (reading 'clearSource')
[x] Form should have placeholder texts instead of title properties
[x] Implement Select2 for country selection (as on Search and Gallery pages)
[x] Poor bs/flex layout wrt column margins

Tooltip Initialisation:

[x] Remove from base_webpack.js dependencies. @kgeographer: Tooltips are now all initialised by delegation from the body in base.js: all that is required for an element to have a tooltip is for it to have a data-bs-toggle="tooltip" attribute.

Datasets

Dataset Browse: http://localhost:8001/datasets/28/browse

[x] Detail div content in ds_browse.html does not display
[x] Tooltip/link on title & variants in detail not relevant here - all of this dataset

Dataset publication: http://localhost:8001/datasets/28/places

[x] Tooltip/link on variants in detail not relevant here; for title only if indexed (has portal)
[x] Time slider should default to open
[x] Time control does not actually toggle date filtering (misleading tooltip)
[x] Time control fa-question-circle requires popover to replace "Lorem ipsum..."
[x] Image download and Exit fullscreen buttons lack BS tooltips
[x] Image download modal lacks title and should be Bootstrap
[x] Apart from the blue colour, the pid column lacks any indication that it links to another page (inconsistently, clicking anywhere else on the row highlights the feature), and in any case seems redundant now that links appear in the Detail box [@kgeographer: should the column perhaps be removed?] yes, see below

[x] some configurations of vis parameters cause 'add to collection' check boxes to disappear to the right; maybe just comment out the pid column [@kgeographer Not a complete solution, because the container has hidden overflow, so other columns become hidden when the screen width is not "wide". Fixed by allowing overflow-x: auto and setting the BS .row margin-right to auto (default behaviour causes persistent scrollbar). Also, have to set column to visible: hide rather than commenting it out because it has a data property that needs to be accessible.]

[x] Thumbnail image is limited to row height of title. Float it instead with a non-percentage max-height.
[x] Download and Metadata links have non-Bootstrap tooltips (i.e. titles): need to accommodate both tooltip and modal by using different tag for tooltips (i.e. not data-bs-toggle).
[x] Metadata eyeball icon not linked
[x] Metadata modal has a permalink tooltip with sometimes-missing content: tooltips in modals require specification of container, e.g. data-bs-container="#metadataModal"
[x] ~Citations could usefully be offered in a selectable range of standard formats (see https://citation.js.org/)~ pls defer

Collections

[x] ~Redirection~(messy) 404 error should be set up to prevent browse_ds and browse_pl being used interchangeably on the wrong type of collection
Place Collection Browse: http://localhost:8001/collections/11/browse_pl

[x] Sequence Player fails if no row has first been manually selected: e.g. http://localhost:8001/collections/11/browse_pl

Dataset Collection Browse: http://localhost:8001/collections/2/browse_ds

Added an item under portal; some changes to portal js and css are in the latest staging (19:31 Turkey time 16 May), so work on this should follow an update to that staging

Since all the boxes are checked, closing this. Anything related or further on any of the items should surface in a new issue


Failed to create the WebView Control

ℹ Computer information

PowerToys version:
PowerToy Utility:
Running PowerToys as Admin:
Windows build number: [run "winver"]

📝 Provide detailed reproduction steps (if any)

…I got this problem after I install the software
…and I change the position and try to install again
…but it still did'n work

✔ Expected result
What is the expected result of the above steps?
❌ Actual result
What is the actual result of the above steps?
📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

Have you edge installed?

Have you edge installed?

yes, I have the Microsoft Edge.
My edge seems doesn't work too.  it exit unusual immediately I try to open it

@guyuedumingx
what Windows version are you running?

@enricogior
windows 10

Windows 10 Professional Edition year 2018

@guyuedumingx
open the Start menu and type winver and report the version shown in the dialog:

Do you need I change it to English?

Version 1803 needs a working Edge browser as far as I know

@guyuedumingx
it's OK, the info I was looking for is 1803
Unfortunately that version is using the old settings and in a couple of months it will not be supported anymore.
I would suggest you to update to Windows version 1903 or later.


Market: several problems

[ ] 1) when user buys 2 or more licenses for 1 product then only 1 license is generated
[ ] 2) when user making manual order then transaction is added to bx_payment_transactions table but nothing is added to bx_market_licenses, as the result it's impossible to generate license for client manually

Point №2 can be reproduced only when a payment with the same order number was alreade processed.


Add support to create Direct Connect Gateway association with Virtual Private Gateway

Is your feature request related to a problem? Please describe.
Without doing it manually or through the customizations-config.yaml file, it is impossible to create an association between the DX Gateway and the Virtual Private Gateway.
Per AWS Support, only custom resources can achieve this via customizations-config.yaml which can be quite complex for many people.
Since all other elements are managed and generated through the network-config.yaml it would be relevant to be able to do this via the network-config.yaml file just like the TransitGateway without having deployment parts outside of the network-config.yaml file.
Describe the feature you'd like
Like Transit Gateway association, being able to create a Virtual Private Gateway association with a Direct Connect Gateway.

Hi @JimToupet ,
We have an open feature request for this and I've added this issue to the feature request to get more traction and prioritization. I will keep this issue open in the meantime to keep you up to date on when this has been implemented and set for release. Please let me know if you have any questions or concerns in the meantime.


could you add shell command

I using mac os, I want to get a one key decompile tool. but I  found it only run on Windows platform.

Finished dex2jar, you can write your own shell command according to bat


Write a Scala program to print fibonacci series without recursion

Description
Write a Scala program to print fibonacci series without recursion
Input  : 5
Output : 0 1 1 2 3

How to contribute

Save the solution in printFibonacciSeriesWithoutRecursion.scala file
Add printFibonacciSeriesWithoutRecursion.scala file in print-fibonacci-series-without-recursion folder

!assign

Hey @Chirag8023,
This issue has been assigned to you for more than 15 days.
We are unassigning you from this issue.
If you are still interested in contributing to this issue, please get auto-assigned on the issue by commenting !assign again.
Thanks for your contributions :)


Cleanup: Remove functions from kptfile

This is an undocumented behavior that will be superseded by hydration redesign.

Do we have a clear understanding of how this feature has been used and how those use-cases can be addressed with the hydration redesign?
Code looks good.

No, such undocumented behavior is a bug IMO, so I would flip the burden of proof. I haven't seen this UX discussed anywhere in external or internal docs. The spirit of this codepath (A package has functions, and interaction of setters and functions) needs to be addressed by v1 hydration story regardless.
In addition, given this is on next branch, we shouldn't hesitate to do such cleanups.


6.3.2: setuptools build fails

On using sdist source tar ball setuptools build command fails
+ /usr/bin/python3 setup.py build '--executable=/usr/bin/python3 -s'
running build
running build_py
creating build
creating build/lib
creating build/lib/diff_cover
copying diff_cover/__init__.py -> build/lib/diff_cover
copying diff_cover/command_runner.py -> build/lib/diff_cover
copying diff_cover/config_parser.py -> build/lib/diff_cover
copying diff_cover/diff_cover_tool.py -> build/lib/diff_cover
copying diff_cover/diff_quality_tool.py -> build/lib/diff_cover
copying diff_cover/diff_reporter.py -> build/lib/diff_cover
copying diff_cover/git_diff.py -> build/lib/diff_cover
copying diff_cover/git_path.py -> build/lib/diff_cover
copying diff_cover/hook.py -> build/lib/diff_cover
copying diff_cover/hookspecs.py -> build/lib/diff_cover
copying diff_cover/report_generator.py -> build/lib/diff_cover
copying diff_cover/snippets.py -> build/lib/diff_cover
copying diff_cover/util.py -> build/lib/diff_cover
creating build/lib/diff_cover/violationsreporters
copying diff_cover/violationsreporters/__init__.py -> build/lib/diff_cover/violationsreporters
copying diff_cover/violationsreporters/base.py -> build/lib/diff_cover/violationsreporters
copying diff_cover/violationsreporters/java_violations_reporter.py -> build/lib/diff_cover/violationsreporters
copying diff_cover/violationsreporters/violations_reporter.py -> build/lib/diff_cover/violationsreporters
error: package directory 'violationsreporters' does not exist

@kloczek So I suspect this issue started with version v6.2.2
diff cover does not have a setup.py anymore and uses a pyproject.toml for its build. I think the command is slightly different now. I use poetry but I wanna say python -m build would work as well. Ill check that.

Yeah, please see https://setuptools.readthedocs.io/en/latest/build_meta.html
but essentially https://github.com/pypa/build build tool can build the project with python -m build.
Or you can use poetry's poetry build command
Or you can use the binaries provided on pypi if those work

@kloczek So I suspect this issue started with version v6.2.2
diff cover does not have a setup.py anymore and uses a pyproject.toml for its build. I think the command is slightly different now. I use poetry but I wanna say python -m build would work as well. Ill check that.

Nevertheless sdist pypi tar ball has generated setup.py.
Does it mean that poetry has some bug and generates wrong setup.py?

🤔 oh I had not fully realized a setup.py is being generated in the source build.
Sorry, still have a lot to learn I guess. I am poking around and there may be something we can add to the toml to ensure the generated setup.py includes the expected paackage directory... im seeinig an older poetry issues suggesting this. https://github.com/python-poetry/poetry/issues/1338
I should be able to experiment with this some next week

@kloczek Please give https://pypi.org/project/diff-cover/6.3.3/ a shot and let me know if that works for you. I think I found the issue. I was able to build with the source dist.
Sorry again for being too quick to close earlier.

No problem .. things happens :)
Just tested and I was able to build package out of sdist tar ball (without any issues)
Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.3-2.fc35.x86_64
Wrote: /home/tkloczko/rpmbuild/SRPMS/python-diff-cover-6.3.3-2.fc35.src.rpm
Wrote: /home/tkloczko/rpmbuild/RPMS/python-diff-cover-6.3.3-2.fc35.noarch.rpm

Thank you and closing :)

If may I mention yet another small thing .. :)
Just found that git tree contains bits which are not present in sdist like tests/. Is it possible to add those files as well to the sdist to allow use it on building packages? (I'm obligatory trying to include in my packages build procedures execution of the test suites).

Im out of town for a few days but I'll look into it next week.
On Fri, Aug 20, 2021, 4:25 AM Tomasz Kłoczko @.***>
wrote:

If may I mention yet another small thing .. :)
Just found that git tree contains bits which are not present in sdist like
tests/. Is it possible to add those files as well to the sdist to allow
use it on building packages? (I'm obligatory trying to include in my
packages build procedures execution of the test suites).
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Bachmann1234/diff_cover/issues/244#issuecomment-902525920,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALTLRP5GZBQCJUVD7YXT33T5YGPZANCNFSM5CPCPCUQ
.

@kloczek 6.3.4 should include the test files

sorry to flail on this. I had to remove the test dir because doing so polluted the site-packages namespace in a way that felt inappropriate.  https://github.com/Bachmann1234/diff_cover/issues/247

Build package with 6.3.4 still fails for me but reason is completly differesnt.
Looks like in in some filres are some issues which afe blocking generate python 3.x bytecode
+ /usr/bin/python3 -sBm compileall2 -f -j48 -o 0 -o 1 -o 2 -s /home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64 -p / /home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib64/python3.8/site-packages /home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages
Listing '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib64/python3.8/site-packages'...
Can't list '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib64/python3.8/site-packages'
Listing '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages'...
Listing '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/__init__.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/command_runner.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/config_parser.py'...
Listing '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/templates'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/diff_cover_tool.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/diff_quality_tool.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/diff_reporter.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/git_diff.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/git_path.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/report_generator.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/hook.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/hookspecs.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/snippets.py'...
Listing '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/violationsreporters'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/util.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/violationsreporters/__init__.py'...
Listing '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover-6.3.4-py3.8.egg-info'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/violationsreporters/base.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/violationsreporters/java_violations_reporter.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/diff_cover/violationsreporters/violations_reporter.py'...
Listing '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests'...
Listing '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/fixtures'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/__init__.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/fixtures/hello.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/fixtures/hi.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/fixtures/snippet_8859.py'...
***   File "/usr/lib/python3.8/site-packages/tests/fixtures/snippet_8859.py", line 2
    Line 2
         ^
SyntaxError: invalid syntax

Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/fixtures/snippet_src.py'...
***   File "/usr/lib/python3.8/site-packages/tests/fixtures/snippet_src.py", line 1
    Line 1
         ^
SyntaxError: invalid syntax

Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/fixtures/snippet_unicode.py'...
***   File "/usr/lib/python3.8/site-packages/tests/fixtures/snippet_unicode.py", line 1
    Line 1
         ^
SyntaxError: invalid syntax

Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/fixtures/violations_test_file.py'...
Listing '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_clover_violations_reporter'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/helpers.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_clover_violations_reporter.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_config_parser.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_diff_cover_main.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_diff_cover_tool.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_diff_quality_main.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_diff_reporter.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_git_diff.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_git_path.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_integration.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_java_violations_reporter.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_report_generator.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_snippets.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_util.py'...
Compiling '/home/tkloczko/rpmbuild/BUILDROOT/python-diff-cover-6.3.4-2.fc35.x86_64/usr/lib/python3.8/site-packages/tests/test_violations_reporter.py'...

Right, you can't compile the test fixtures. They are not intended to be ran or imported in any way they are not executable code. that directory is not a a module (no init.py)
But the point is moot as the most recent version removed the test directory as it pollutes site packages.


What is the best practice to send data from a producer to clients?

Hello,
Sorry for a newbie question - I've spent 1,5 days reading websockets docs, FAQ, googling and thinking how to do it - finally there is some code and I'm sure there is a better way to do it: to pass data from a function to websockets to send to clients.
The problem with the code that I can't remove return('Producer') from async def producer() - websocket clients constantly receive the same return message from the producer - producer function should return something otherwise await complains:
Traceback (most recent call last):
  File "C:\Users\USER\AppData\Local\Programs\Python\Python38\lib\site-packages\websockets\server.py", line 191, in handler
    await self.ws_handler(self, path)
  File "n:/Python/WebSockets/ws.py", line 30, in producer_handler
    await websocket.send(message)
  File "C:\Users\USER\AppData\Local\Programs\Python\Python38\lib\site-packages\websockets\protocol.py", line 651, in send
    raise TypeError("data must be bytes, str, or iterable")
TypeError: data must be bytes, str, or iterable

My code:
# !/usr/bin/env python

import asyncio
import websockets

send_data = False
msg = ''

async def producer():
    global send_data
    if send_data:
        print("Sending new data...")
        send_data = False
        return(msg)
    await asyncio.sleep(1)
    return('Producer')

async def producer_handler(websocket, path):
    while True:
        message = await producer()
        await websocket.send(message)

# This function is called via a callback
def my_function():
    global send_data
    global msg
    # ...
    # here we have code to write data in DBs, etc
    # ...
    # We also need to send some data to WebSocket Clients:
    msg = processed_data
    send_data = True
    # There is no return in this function

ws_server = websockets.serve(producer_handler, "<IP_ADDRESS>", 8765)
asyncio.get_event_loop().run_until_complete(ws_server)
asyncio.get_event_loop().run_forever()

You have two problems here:

Your code doesn't work when more than one client is connected. Look at https://websockets.readthedocs.io/en/stable/intro.html#registration for broadcasting a message to all connected clients.

You need a way to schedule a coroutine from a regular function. Take a look at call_soon or more likely call_soon_threadsafe — you didn't mention it but I suspect my_function() runs in another thread (or else you're in trouble because you're blocking the event loop).

connected = set()

async def handler(websocket, path):
    # Register.
    connected.add(websocket)
    try:
        async for msg in websocket:
            pass
    finally:
        # Unregister.
        connected.remove(websocket)

async def broadcast_msg(msg):
    await asyncio.wait([ws.send(msg) for ws in connected])

def my_function():
    asyncio.get_event_loop().call_soon_threadsafe(broadcast_msg, msg)

(didn't try that code, but shouldn't be too far from a working solution)

@aaugustin
Thanks! Works fine. I've just added a check for connected clients and everything works.


kisearch

go

#kbcluckywinnerhit.blogspot.com

what is the reason/purpose for this PR? if no update, will close this Pull Request.


What is the difference between this lib and InAppBillingPlugin lib

This lib seems very similar to the InAppBillingPlugin by James Montemagno, are their differences or improvements made over that lib?  Can that be outlined in the readme?
https://github.com/jamesmontemagno/InAppBillingPlugin

When i started this library James library was using old api of Android and UWP apis.  This uses billingclient api of Android and StoreContext from UWP and up to date with the latest versions and functionality. IOS has no difference so far. I took over the IOS code from him. It supports also Amazon iap as i wrote in the read me. you need to do a manual work if you want to use Amazon Iap as well. I want to add also Tizen soon but so far i couldnt find yet time for it :)

Got it. Thanks for letting me know.

If you are targeting AndroidX libraries and Android 10 api version, you can use 2.2.1-pre which is using BillingClient 2.2.1. It is just called pre for precaution but actually working. I am using in my projects in production.  It looks like that Xamarin has updated to 3.0 latest version 2 days ag. i will update it as well soon.
https://www.nuget.org/packages/Xamarin.Android.Google.BillingClient/3.0.0


kpromo: set git clone depth for pr subcommand to prevent downloading the whole repository

What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds git clone options for cloning the kubernetes/k8s.io repository to only clone a depth of 1.
The kubernetes/k8s.io did grow in the past to a big (1,4GB to download) repository:
❯ git clone https://github.com/kubernetes/k8s.io.git
Cloning into 'k8s.io'...
remote: Enumerating objects: 211546, done.
remote: Counting objects: 100% (1397/1397), done.
remote: Compressing objects: 100% (881/881), done.
remote: Total 211546 (delta 428), reused 1294 (delta 359), pack-reused 210149 (from 1)
Receiving objects: 100% (211546/211546), 1.27 GiB | 6.65 MiB/s, done.
Resolving deltas: 100% (122622/122622), done.
Updating files: 100% (15059/15059), done.
❯ du -h -d 0 k8s.io
1.4G    k8s.io

This change should reduce the downloaded size from 1.27 GiB to currently ~29.29 MiB instead.
❯ git clone --depth 1 https://github.com/kubernetes/k8s.io.git
Cloning into 'k8s.io'...
remote: Enumerating objects: 17520, done.
remote: Counting objects: 100% (17520/17520), done.
remote: Compressing objects: 100% (9760/9760), done.
remote: Total 17520 (delta 8344), reused 14982 (delta 7181), pack-reused 0 (from 0)
Receiving objects: 100% (17520/17520), 29.29 MiB | 4.14 MiB/s, done.
Resolving deltas: 100% (8344/8344), done.
Updating files: 100% (15059/15059), done.
❯ du -h -d 0 k8s.io
142M    k8s.io

So this reduces the amount of data which is downloaded when running kpromo pr ... and by that also reduce the time for maintainers to run kpromo.
Which issue(s) this PR fixes:

Special notes for your reviewer:
Does this PR introduce a user-facing change?

kpromo pr: Only clone the head commit to reduce amount of data to download

Let's give this a try!
/hold cancel

We should consider --filter=blob:none instead, that's what we use in prow these days.
It doesn't break git describe (unlike depth=1 and similar) but it does significantly reduce clone size.
https://github.blog/open-source/git/get-up-to-speed-with-partial-clone-and-shallow-clone/

We should consider --filter=blob:none instead, that's what we use in prow these days. It doesn't break git describe (unlike depth=1 and similar) but it does significantly reduce clone size.
github.blog/open-source/git/get-up-to-speed-with-partial-clone-and-shallow-clone

Oh, this is neat!
I'll gonna try that and file a PR to change to that :-)

Unfortunately: --filter=blob:none is not yet supported in the used library: https://github.com/go-git/go-git/issues/713

Ah, we do clones via exec in prow ... it's kinda nice for debugging but does introduce an external runtime dependency ... (we use a container image with git)


Discovering Subdomains with Python

Aim

Python Script to List all the subdomains of a website and stored it in a CSV file.

can i work on the issue plss assign me @avinashkranjan sir

can i work on the issue plss assign me @avinashkranjan sir

@avinashkranjan sir plss assign me this issue i have to work on this issue i take some time but i will work on it take inspiration from some other work

@avinashkranjan sir plss assign me this issue i have to work on this issue i take some time but i will work on it take inspiration from some other work

plss explain something about this we have to make  Subdomain Scanner in Python type

plss explain something about this we have to make  Subdomain Scanner in Python type

Hello @Ayush7614, You need to create a subdomain.txt file and run a dictonary attack. I've added a subdomain.txt file with popular 1000 subdomains  and you can find more subdomain.txt files..
subdomain.txt

Hello @Ayush7614, You need to create a subdomain.txt file and run a dictonary attack. I've added a subdomain.txt file with popular 1000 subdomains  and you can find more subdomain.txt files..
subdomain.txt

Assigning it to you..

Assigning it to you..

definately sir i will try my best

definately sir i will try my best

#23 this is pull for this issue plss review it @avinashkranjan sir

#23 this is pull for this issue plss review it @avinashkranjan sir


Lint/Syntax false negative

def foo(arg1:)
  puts arg1
  yield
end

foo arg1: {hello: 'world'} { puts 'bar' }

Running the above code with Ruby 2.5.1 raises:
syntax error, unexpected '{', expecting end-of-input
foo arg1: {hello: 'world'} { puts 'bar' }

However, Lint/Syntax does not report a violation.

Expected behavior
Lint/Syntax should report a violation
Actual behavior
Lint/Syntax does not report a violation
Steps to reproduce the problem
Run/Inspect the example code with Ruby 2.5.1
RuboCop version
$ rubocop -V
0.54.0 (using Parser <IP_ADDRESS>, running on ruby 2.5.1 x86_64-darwin17)

@Tolsto: Please open an issue with parser. 🙂

@Drenmi Parser <IP_ADDRESS> has been released which fixes https://github.com/whitequark/parser/issues/495


Istio 1.8.2 does not require TLS cert mounted on istio-ingressgateway deployment to match TLS cert stationed at gateway

Bug description
We recently switched to using cert manager to provide a TLS cert at our gateway like so:
  - hosts:
    - '*.mydomain'
    port:
      name: https
      number: 443
      protocol: HTTPS
    tls:
      credentialName: k-gateway-cert-cm-secret
      mode: SIMPLE

Previously, we had just used a static TLS cert that we had stored in the secrets of the namespace, called istio-ingressgateway-certs.
After deploying, we hit this bug: https://github.com/istio/istio/issues/14205
We realized that our istio-ingressgateway deployment was failing to cycle or scale because its deployment was trying to mount istio-ingressgateway-certs. Further, by re-adding this secret to the cluster, the pods were successfully able to cycle and scale.
My question, then, is: why are these certs allowed to be different, and what is the istio-ingressgateway-certs in the deployment responsible for?
[ x ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ x ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
Consistent application of TLS certs at the gateway level
Steps to reproduce the bug
Remove istio-ingressgateway-certs secret from namespace and roll istio-ingressgateway deployment.
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
1.8.2
How was Istio installed?
Standalone Operator
Environment where the bug was observed (cloud vendor, OS, etc)
AKS
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

A default install outputs this:
      - name: ingressgateway-certs
        secret:
          optional: true
          secretName: istio-ingressgateway-certs

So it should not block. Did you customize it to not be optional?

@howardjohn Nope, the deployment for istio-ingressgateway I have live on the cluster is exactly that:

@howardjohn Is the ingressgateway-certs mount just a cert to use if the gateway you're accessing doesn't provide one? i.e. a fallback cert of sorts

@howardjohn No problem then, that answers my question. But still leaves the mystery of why optional: true was not respected by istiod:
2021-05-25T13:06:01.664164Z	warn	ads	ADS:LDS: ACK ERROR router~<IP_ADDRESS>~istio-ingressgateway-5cf87d48b5-hbx27.istio-system~istio-system.svc.cluster.local-3194 Internal:Error adding/updating listener(s) <IP_ADDRESS>_8443: Invalid path: /etc/istio/ingressgateway-certs/tls.crt
That log occurred for each pod that attempted to spin up. Each pod then failed readiness checks and was not servicing any traffic.

Ah, probably you still have a Gateway referencing them?
btw, I think post 1.8 that failure will not block startup


ZoomEye - If added togheter with other engines, sometimes fail with the same error

When performing multiple searches using the -e zoomeye command along with other search engines, an error occasionally occurs with the following panic message:
panic: interface conversion: interface {} is string, not float64
goroutine 58 [running]:
github.com/projectdiscovery/uncover/uncover/agent/zoomeye.(*Agent).query(0x0?, {0x1286f8b?, 0x0?}, 0x0?, 0x0?, 0x0?)
	/home/runner/work/uncover/uncover/uncover/agent/zoomeye/zoomeye.go:94 +0x4e5
github.com/projectdiscovery/uncover/uncover/agent/zoomeye.(*Agent).Query.func1()
	/home/runner/work/uncover/uncover/uncover/agent/zoomeye/zoomeye.go:42 +0x10b
created by github.com/projectdiscovery/uncover/uncover/agent/zoomeye.(*Agent).Query
	/home/runner/work/uncover/uncover/uncover/agent/zoomeye/zoomeye.go:31 +0xcc

uncover version:
1.0.3
Steps To Reproduce:
-r -silent -e shodan,censys,zoomeye -q "apache"
Note that this issue occurs intermittently, not consistently with every search.

have you tried 1.0.4?

with 1.0.4 -r and -j are broken so i cannot replicate the same behaviour.
response with -r -silent -e shodan,zoomeye -q "apache" is a blank line

@AeonDave @Paradigm00 Fortunately, I could reproduce the issue, and I'm hopeful that the [PR (https://github.com/projectdiscovery/uncover/pull/228) will resolve it.

@notwhy

uncover -shodan "ssl:aaa.com" -zoomeye "ssl:aaa.com +ssl.cert.availability:1"
it will ignore the +ssl.cert.availability:1 options and will found more garbage data.

It looks like you're using the Multiple query against multiple search engine feature, which can run multiple queries against various providers. In your example, it's searching for the queries "ssl:aaa.com" and "ssl:aaa.com +ssl.cert.availability:1" on both shodan and zoomeye.

Fixed in latest release - https://github.com/projectdiscovery/uncover/releases/tag/v1.0.5


In transitivity mode, some names may appear several times in the output partition list

With some datasets and some threshold K/theta values, the partition list outputted by KoT is too long as some names are repeated several times (not consecutively). So far I only saw this problem when using the transitivity mode.

Problem is now solved.


Visualization of health metrics in Grafana Dashboard

As Administrator
I want a visualization of IRS ready to use health check in Grafana
so that I can see at a glance whether the IRS is ready for operation and can be used.
Hints / Details

...

Outcome / Acceptance Criteria

Outcome

...

Acceptance Criteria

[ ] Health Actuators of shared services are shown in Grafana Dashboard System Health
[ ] Health Actuators of IRS are shown in Grafana Dashboard System Health
[ ]  Extend HelmCharts dashboard Import Dashboard during setup of application

Out of Scope

...

[ ] need to clarify how dashboard is imported
[ ] rollout on DEV


Update README.md

joi.io is either down or nonexistent as of 3:30PM CDT on 3/4/2018, so I modified the link to point to the GH repo
Cool lib, btw! 8)

Oh, yeah, my internet was down when I wrote that, so I guessed the url and was going to change it later. But of course forgot, lol. Thanks!


AWS - use account specific region list.

The list of enabled regions might differ between AWS accounts. The describe_regions API call will only list regions available for the current account. Therefor don’t call describe_regions only once, for the default account, but rather once per account.

An additional reason for this change is that it allows cartography to work with a centralised AWS account only for IAM, that has region listing disabled.
I'm using it for a setup with a default account that only has users and policies that allows assuming roles in other accounts. All non-default AWS accounts use a role_arn and "source_profile = default".


⚠ deces.matchid.io search API has degraded performance

In d8531f4, deces.matchid.io search API (https://deces.matchid.io/deces/api/v1/search?q=pompidou) experienced degraded performance:

HTTP code: 200
Response time: 3993 ms

Resolved: deces.matchid.io search API performance has improved in 896bf5a after 22 minutes.


Update Skelly Vs The Rev lobby art

About the PR
Someone said the original was a bit low res
and I agreed.
This is a 1440p (from an 8k base image) rendition
of the same scene, with a new dramatic forced
perspective look, and generally cleaner art throughout.
Also now there's two mothroaches.
Why / Balance
The original was well received but I wanted a second go.
Technical details
I made the background using Meta as a reference.
Tools used:
Blender 3
Clip Studio Paint
XP Pen Artist 12
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog
:cl:

tweak: Swapped out the Skelly Vs The Rev art with a new, higher-res version.

Very very good :D
Merging


fix(protocol-designer): enable color picker's alpha value

Overview
enable color picker's alpha value since onChange used only rgb
https://github.com/user-attachments/assets/f008c088-1414-409a-805c-525befcef329
close RQA-3347

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment
low

tested the code here


net.tomp2p.tracker.TestTracker has ambiguous / uninformative test method names

"testTracker2", "testTracker3", ..., etc. One needs to dive into the test method bodies in order to see what is going on there. Renaming these methods would help.

The first priority right now, is to make all testcases green. It would be nice to have good names, not only in the tracker packge, but in all packages. However, this is low priority for me, but if you have good names, I would appreciate a pull request.


Add kafkaSource saslType, e2e tests for auth (tls and sasl512)

Fixes #200
Adds SASL mechanism support for the kafkasource, adds a variety of testing, including e2e testing with plain (no auth), sasl512 and tls

I tested the source, e2e, locally - like:

Setup strimzi (with only SASL/TLS), like:

apiVersion: kafka.strimzi.io/v1beta1
kind: Kafka
metadata:
  name: my-cluster
spec:
  kafka:
    version: 2.6.0
    replicas: 3
    listeners:
      - name: sasl
        port: 9094
        type: internal
        tls: true
        authentication:
          type: scram-sha-512
    config:
      offsets.topic.replication.factor: 3
      transaction.state.log.replication.factor: 3
      transaction.state.log.min.isr: 2
      log.message.format.version: "2.6"
    storage:
      type: jbod
      volumes:
      - id: 0
        type: persistent-claim
        size: 100Gi
        deleteClaim: false
  zookeeper:
    replicas: 3
    storage:
      type: persistent-claim
      size: 100Gi
      deleteClaim: false
  entityOperator:
    topicOperator: {}
    userOperator: {}

Setup a Kafka User via Strimzi, like:

apiVersion: kafka.strimzi.io/v1beta1
kind: KafkaUser
metadata:
  name: my-sasl-user
  labels:
    strimzi.io/cluster: my-cluster
spec:
  authentication:
    type: scram-sha-512
  authorization:
    type: simple
    acls:
      # Example ACL rules for consuming from knative-messaging-kafka using consumer group my-group
      - resource:
          type: topic
          name: "*"
        operation: Read
        host: "*"
      - resource:
          type: topic
          name: "*"
        operation: Describe
        host: "*"
      - resource:
          type: group
          name: "*"
        operation: Read
        host: "*"
      # Example ACL rules for producing to topic knative-messaging-kafka
      - resource:
          type: topic
          name: "*"
        operation: Write
        host: "*"
      - resource:
          type: topic
          name: "*"
        operation: Create
        host: "*"
      - resource:
          type: topic
          name: "*"
        operation: Describe
        host: "*"

Create the secret with the SASL and TLS info, like (note: using default namespace):

STRIMZI_CRT=$(kubectl -n kafka get secret my-cluster-cluster-ca-cert --template='{{index .data "ca.crt"}}' | base64 --decode )
SASL_PASSWD=$(kubectl -n kafka get secret my-sasl-user --template='{{index .data "password"}}' | base64 --decode )

kubectl create secret --namespace default generic strimzi-sasl-secret \
    --from-literal=ca.crt="$STRIMZI_CRT" \
    --from-literal=password="$SASL_PASSWD" \
    --from-literal=saslType="SCRAM-SHA-512" \
    --from-literal=user="my-sasl-user"

Define some source:

apiVersion: sources.knative.dev/v1beta1
kind: KafkaSource
metadata:
  name: kafka-source2
spec:
  bootstrapServers:
   - my-cluster-kafka-bootstrap.kafka.svc.cluster.local:9094
  topics:
   - my-topic
  net:
    sasl:
      enable: true
      user:
        secretKeyRef:
          name: strimzi-sasl-secret
          key: user
      password:
        secretKeyRef:
          name: strimzi-sasl-secret
          key: password
      saslType:
        secretKeyRef:
          name: strimzi-sasl-secret
          key: saslType
    tls:
      enable: true
      caCert:
        secretKeyRef:
          name: strimzi-sasl-secret
          key: ca.crt
  sink:
    ref:
      apiVersion: serving.knative.dev/v1
      kind: Service
      name: event-display

SOURCE POD CAME UP
All in default namespace ...

I just have a comment about the validation of the new type field but other than that it looks good to me.

I believe all the comments are addressed, unholding
/unhold


training with japanese language

is it possible to train CLIP with  other language

Yes, you can sure do that.
For example, you can choose a Multilingual-CLIP that supports japanese https://github.com/FreddeFrallan/Multilingual-CLIP. Besides, you also need to change the charset and tokenizer in https://github.com/VamosC/CLIP4STR/blob/main/strhub/data/utils.py and other files.

Close due to inactivity. Feel free to re-open.


Add support for array types

Doesn't implement support for dimension expressions, as that first requires all the expression parsing to be written, and that's a lot more work

Ouch. I thought this is only necessary for decltype...

Strictly,  might be used in function noexcepts, array sizes, decltypes, and as template args. Of those, I'd say array types are the most common, then template args and decltypes for SFINAE, and function noexcept expressions are not super common in my experience.

Yeah, makes sense.


Non developer readme contribution

I have written a clear, easy-to-comprehend introduction for Pixi.js.
I believe this introduction, free of complex technical terms, will swiftly and thoroughly inform anyone about the use-cases, merit, and advantages, including the celebrated features, of Pixi.js.
Seasoned developers, new programmers, and even nontechnical visitors will benefit from the clear language, exposing Pixi.js to a broader range of users.

This is really cool @GabrieleRomeo, thanks for writting this up.

Thanks @englercj !
I hope that my little contribution will be used to improve your fantastic project :-)
For me, it would be very, very important!

Its easier if you make PRs to the dev branch :)

Hi @englercj
Do I need to make my changes on my dev branch and then create a new pull request?
I'm sorry but I'm a newbie with GitHub :smile:
Thank you


Branches

Clean up branch mess (merge master into main / delete master;  Merge in "Single Service" branch)

Done!


Race condition in OnOrder/OnTrade and cached transaction

Fix is coming

fix https://github.com/buybackoff/QuikSharp/commit/56908ac0b4f30c95c4f63936a5f0784b6d86251f


After start game i get one more windows unlocker

First i start unlocker -> start game

Then minimize game window and see a warning

And checkbox framerate and patching not active
What i do wrong?

Thx!
Now all works!
x.x.x.3 ver finaly corretly start on win11

same problem    sad

Fist need change game directory, then start FIX and start the game.
After loading game enter checkbox and patch game.


docs(icons): fix small typos

[X ] I have read CONTRIBUTING.md
[X ] I have read CODE_OF_CONDUCT.md

It might just be me, but this line in the nvim-tree/nvim-web-devicons was a bit hard to understand.
Please let me know if I'm misrepresenting anything or if you'd like something worded differently! (also feel free to edit the PR directly)

Thanks for the PR! It should be part of the main branch now.


SignalR + NancyFX + Self-Hosting - HttpContext

I'm attempting to use AddDynamic with the ~/signalr/hubs path, but since this is a NancyFX project there is no HttpContext.  I attempted to use AddRemote, but SquishIt turns my relative path into signalr/hubs which gets appended onto whichever subdirectory  it is in rather than the site root.   Is there any way to work around this?

If Nancy hasn't changed dramatically i suspect this will help.
http://blogs.lessthandot.com/index.php/webdev/serverprogramming/squishit-and-nancy-part-deux/

If not let me know I haven't tried this particular combination.

My implementation of your example only appears to make things worse.  I found that your original implementation of PathTranslator did all of the regular links correct, it's just the dynamic ones I am having issues with.  However, when I copied your code and modified it so that it left http links alone so that I can map directly to http://mysite/signalr/hubs I encounter an error elsewhere in Squishit in FileSystemResolver:
    public string Resolve(string file)
    {
        return Path.GetFullPath(file);
    }

The error indicates that "URI formats are not supported." with Path

Hmm OK this is definitely a gap.  There's a method called BuildAbsolutePath that uses HttpContext directly, it should probably get its information from the path translator or simliar.
I will try to look into this in the near future, if you could upload a sample project somewhere that would be very helpful.

The URI formats are not supported message - assuming you are trying to use add which assumes you are adding a normal file.  You will want to use AddRemote("~/signalr/hubs", "http;//mysite/signalr/hubs", true) as a workaround - this is what AddDynamic uses under the hood
https://github.com/jetheredge/SquishIt/blob/master/SquishIt.Framework/Base/BundleBase.cs#L246-250
If you get a chance to throw together a sample project I would really like to see it so I can ensure the change to that BuildAbsolutePath method works.  I am not going to make the change otherwise, because I envision it as a breaking change for anyone who is already using Nancy + SquishIt (new method and possibly a rename of the IPathTranslator interface).
Email is alex dot ullrich at gmail if you don't want to upload the project here.

I am working on a sample project for your use by cutting down my current project to a functioning example

Fantastic, thanks!
Once you have a path provider in place, does
AddRemote("~/signalr/hubs", "http;//mysite/signalr/hubs", true)

Work in the meantime?

I remembered I had a test project to get things working with SignalR, the initial way I did things was slightly different (though I think what I have above might be more correct?)
.AddRemote(null, HttpContext.Current.Request.Url.GetComponents(UriComponents.SchemeAndServer, UriFormat.Unescaped) + "/signalr/hubs", true)

https://github.com/AlexCuse/PlayR/blob/7643f5f900adf01310d46f645fa615cc3296b88d/PlayR/Views/Chat/Index.cshtml#L15
Not sure if poking around in there will help or not since its not using Nancy, but it might glean some other useful info I've forgotten

Passing Null into .AddRemote and adding .ForceRelease() does not make SquishIt happy.  When ResolveAppRelativePathToFileSystem(string file) is called file == null.  When I try returning the null back to SqushIt from the NancyPathTranslator, SquishIt FileSystemResolver.Resolve throws an error.
When I attempt calling AddRemote as follows:
AddRemote("~/signalr/hubs", "http://mysite/signalr/hubs", true)
It generates:

Which will not work on http://site/subdirectory/signalr/hubs as the route is mapped to http://site/signalr/hubs
In addition, using the NancyPathTranslator produces links to the other files as follows:
.Add(@"~/Content/scripts/knockout-3.3.0.js")=>

I made a change so that AddDynamic will use the IPathTranslator interface.  Method it consumes is called BuildAbsolutePath.
You can try with the package available here to see if it works: http://www.nuget.org/packages/SquishIt/<IP_ADDRESS>-alpha2
You are mostly going to be on your own figuring out the nancy issues.  I do not use nancy for anything, and debugging it is more than I have time for at the moment.  Injecting nancy's root path provider into your translator should give you all you need but I really have no idea.  With all the translation activity now confined to that interface you should be able to figure it out by debugging your implementation.  I will try updating my nancy sample project again sometime soon, but it could be a while.

I thought of another potential issue with nancy deployments today.  SquishIt's bundle cache is backed by HttpRuntime.Cache which would obviously not be available.
I will try to get that hidden behind an interface but its another thing that I have no idea how to replace in Nancy.  Going to reach out to a few people to see if they'd be willing/able to help with a push to fix this kind of thing for v1.0 - I would really like to put out a SquishIt.Nancy package that has implementations of all the relevant interfaces but I'm not sure I'm up to the task.  Let me know if this is something you'd have the bandwidth to help with over the next few months.

I'm currently working on #315 and will take a look at this when @AlexCuse accepts the PR.


antispam

the website is getting spammed, and some idea has got negative likes...

got this one now. all the same except the number

What to code has now recaptchav3 support! So i can close this ticket :)
Also banned words are not allowed


Build creates invalid include.gradle file for plugins

This started with 2.0 and relates to the minification of the dimensions. If the plugin's include.gradle file contains the following:
dependencies {
    compile 'com.microsoft.azure:azure-mobile-android:3.1.0'
}

The auto-prepend of the dimensions creates an invalid .gradle file that looks something like (notice there is no new line before dependencies) and fails on build:
android {
          productFlavors {
            "F0" {
              dimension "nativescriptazuremobileapps"
            }
          }
        } 	 dependencies {
    compile 'com.microsoft.azure:azure-mobile-android:3.1.0'
}

Current workaround is to add a blank new line at the start of the plugin's include.gradle file.

fixed with: e5ff35c3eefb234a7126638bc054d182cc7afb6f


Add Import operator

Objective: Allow users that want to periodically import existing data from an object store into a lakeFS repository
How: Using Airflow as an orchestrator, users can create DAGs that trigger on an interval (every hour/day/..) - By introducing a lakeFS Import operator, users can automate the metadata ingestion process required, without having to directly interface with the lakeFS API, e.g.:
task = LakeFSImportOperator(
    task_id='import_from_s3',
    repo='my-repository',
    branch='main',
    commit_message='daily import of raw events',
    paths=[{
        'type': 'prefix',
        'source': 's3://my-bucket/events/ingested/',
        'destination': 'datasets/events/',
    }],
)

@ozkatz Thanks
One thing to consider is how this operator returns import status. When I use Python API, I use following code to periodically check the status:
`        create_resp = client.import_api.import_start(repo, sourceBranch, import_creation)
    # Wait for import to finish
    while True:
        status_resp = client.import_api.import_status(repo, sourceBranch, create_resp.id)
        print(status_resp)
        if hasattr(status_resp, "Error in import"):
            raise Exception(status_resp.err)
        if status_resp.completed:
            print("Import completed Successfully. Data imported into branch:", sourceBranch)
            break
        time.sleep(2)`

I agree! blocking and reporting on completion status should be possible (perhaps even default)

@ozkatz to prioritize


Fix #166: Add missing pygments css link

Fix #166: Add missing pygments css link

This will also be fixed by #467

Did you test the changes? Because I think that we are pulling some sass from wyrm that might be overriding this

I figured you had tested it, no? It is in the Sphinx docs, so figured we should do it. Seems like putting it after the theme CSS would make sure it's supported.

I have not tested but that is likely true but there might not be a need for
the wrym sass for syntax highlighting anymore
On Sun, Dec 3, 2017 at 1:10 PM, Eric Holscher<EMAIL_ADDRESS>wrote:

I figured you had tested it, no? It is in the Sphinx docs, so figured we
should do it. Seems like putting it after the theme CSS would make sure
it's supported.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/rtfd/sphinx_rtd_theme/pull/448#issuecomment-348802251,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOeua8raeJI5y1glk8RwPM1R5nh9aZyFks5s8uQdgaJpZM4Onf77
.

--
Aaron Carlisle
Picture taker | Bit cruncher | Pixel pusher | Document writer |
Project administrator for the Blender 3D Documentation Project

I will test again and open a second PR if other stuff needs to change
On Sun, Dec 3, 2017 at 1:17 PM, Aaron Carlisle<EMAIL_ADDRESS>wrote:

I have not tested but that is likely true but there might not be a need
for the wrym sass for syntax highlighting anymore
On Sun, Dec 3, 2017 at 1:10 PM, Eric Holscher<EMAIL_ADDRESS>wrote:

I figured you had tested it, no? It is in the Sphinx docs, so figured we
should do it. Seems like putting it after the theme CSS would make sure
it's supported.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/rtfd/sphinx_rtd_theme/pull/448#issuecomment-348802251,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOeua8raeJI5y1glk8RwPM1R5nh9aZyFks5s8uQdgaJpZM4Onf77
.

--
Aaron Carlisle
Picture taker | Bit cruncher | Pixel pusher | Document writer |
Project administrator for the Blender 3D Documentation Project

--
Aaron Carlisle
Picture taker | Bit cruncher | Pixel pusher | Document writer |
Project administrator for the Blender 3D Documentation Project


DigitalOcean now uses /dev/vda

/root/nixos-in-place/util: line 23: grub_device: unbound variable
Since line 23 is before the help message, event ./install -h just results in the above crash.
Resolved by adding a third check (elif grep '/dev/vd') and suggest a final else clause aborting with a helpful message if $grub_device can't be inferred.
Details:
DigitalOcean
Debian 5.5
GNU bash, version 4.3.30(1)-release (x86_64-pc-linux-gnu)

Thanks for reporting this! Are you interested in submitting a PR for that change?

Resolved in pull request https://github.com/jeaye/nixos-in-place/pull/24


main#update chart

Update Trivy to version 0.36.0
Remove version templating
Sync chart with upstream.
Revert modules config
Revert modules config
Re-enable psps
Update CHANGELOG
Manually update app version
Add Sync from fork workflow

Wrongly pushed ups


Please publish a new release

The current release is currently broken for me, likely due to https://github.com/rlivsey/broccoli-concat/commit/521d2c270a12e96cbd8aadd80976ed83e3813462 not being available in the current release

Published v0.0.13 - thanks for the prod


Renaming a playlist causes weird reordering.

When renaming a playlist it causes the playlist to jump around in the list of playlists, and causes weird selection issues.

Suggested fix:
Don't automatically sort playlists in alphabetical order, let users arrange playlists into their chosen order.

The current playlist implementation is extremly basic, and will be improved for sure. Something I don't get with your screencast (it goes too fast) is: is the list reordering while you're typing ? (it should not)
Note to myself:

Don't allow empty string playlist name

Yeah it reorders as I type, which is causing it to reselect and actually delete the text I had already written.
I just noticed that the .gif cuts off halfway through what I recorded, let me try re-processing it.

Okey, I can reproduce it, thanks for the report

You can also see on the gif that the progress bar freezes when right click. (#225)


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.7 to before v5.15",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e11f5bd8228fc3760c221f940b9f6365dbf3e7ed",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=97794170b696856483f74b47bfb6049780d2d3a0"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "e11f5bd8228fc3760c221f940b9f6365dbf3e7ed",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "97794170b696856483f74b47bfb6049780d2d3a0",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "drm/edid: In connector_bad_edid() cap num_of_ext by num_blocks read\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.15 by commit 97794170b696856483f74b47bfb6049780d2d3a0, it was introduced in version v5.7 by commit e11f5bd8228fc3760c221f940b9f6365dbf3e7ed. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1002158


Support Request: Support storysource to Prettier v1.13.0

Request Support Prettier v1.13.0
Prittier default parser option changed  babylon to empty and if settting empty, ouput error.
See: https://prettier.io/blog/2018/05/23/1.13.0.html#don-t-default-to-the-javascript-parser-4528-by-duailibe
Steps to reproduce
New create using storysource project and run.
Out this error:
Error: No parser and no file path given, couldn't infer a parser.

platform and version

Mac 10.12.6

Node.js v8.9.4

"<EMAIL_ADDRESS>

"<EMAIL_ADDRESS>

Where to start
https://github.com/storybooks/storybook/blob/master/addons/storysource/src/loader/default-options.js
I tried add parser: 'babylon' in default option. And it works.
But I do not know if this modification alone is enough.
Add:
prettier changed output from error to warning in 1.13.1

Referencing the related prettier issue.
https://github.com/prettier/prettier/issues/4567

@igor-dv
I think this need fix. But there's no rush.
Because Prettier changed to warning, but will change again error in the future.
Now this is output:

No parser and no filepath given, using 'babylon' the parser now but this will throw an error in the future. Please specify a parser or a filepath so one can be inferred.

But if this commit is enough (locke Prettier version forever) , don't need it.

But if this commit is enough

That was a temporary solution until your PR gets merged

It was merged, I close this.
@Hypnosphi
Thanks for reviewing many times :bow:

Released as 4.0.0-alpha.9


[SPARK-44188][CORE] Remove useless resetAllPartitions method in ActiveJob

What changes were proposed in this pull request?
Remove useless resetAllPartitions method in ActiveJob. It unused when #22158.

Why are the changes needed?
Clean code

Does this PR introduce any user-facing change?
No

How was this patch tested?
Unnecessary

cc @jiangxb1987 @dongjoon-hyun


fix allow_unicode kwarg for AutoSlugField

Rebase #463 to merge in 0.9 branch
Fix #463

Coverage increased (+0.02%) to 95.776% when pulling 9f7d0275501953269a9722383499617f6f148fe2 on hotfix/merge-463 into ba04424686de876d0b75370b52d807fd347181b3 on release/0.9.x.


PD: add validation for mix form delay fields

This ticket is no longer necessary because we do not have a form field for delay tip position offset
Overview
Add validation to the mix form's delay fields.
Implementation details
~Validation should match what happening in the moveLiquid form. Use the following maskers/casters:~
aspirate_delay_seconds: {
    maskValue: composeMaskers(maskToInteger, onlyPositiveNumbers, defaultTo(1)),
    castValue: Number,
  },

aspirate_mix_delay_mmFromBottom: {
    castValue: Number,
  },

dispense_delay_seconds: {
    maskValue: composeMaskers(maskToInteger, onlyPositiveNumbers, defaultTo(1)),
    castValue: Number,
  },

dispense_mix_delay_mmFromBottom: {
    castValue: Number,
  },

No need to change the validation logic in the tip position modal, it should clamp the input for distance from bottom of well between 0 and 2x the well depth
Acceptance criteria

~You should only be able to enter positive integers into the seconds field.~
~You should not be able to add a value below 0 for the distance from bottom of well (same logic as in the moveLiquidForm)~
~You should not be able to add a value more than 2x the well depth for the distance from bottom of well (same logic as in the moveLiquidForm~

This ticket is no longer necessary because we do not have a form field for delay tip position offset


Inkscape not installing correctly

I noticed, when installing Inkscape via Installomator, the app isn’t correctly installed: it always generates a crash report after quitting, prefs can’t be saved, and some other functionality isn’t working properly (esp. copy-pasting objects, when working in the app).
I checked the prefs, and on ~/Library/Application\ Support/org.inkscape.Inkscape/ (+ subfiles/ dirs) the owner is root, instead of the logged in user.
When installing manually via drag + drop, everything’s fine - Installomator does more/less the same (so it's performed as root, and the owner changed afterwards)... The prefs aren't created on install though, instead at 1st launch, so I'd expect this difference to be irrelevant. Changing anything reg. the SYSTEMOWNER value obviously doesn't make a difference either.
Is there a problem with the recipe? It looks ok to me, but I never created one myself yet so might be overseeing something.
Many thanks!

Have you added an extra step to the installation that launches Inkscape from a root process?

No, I'm using it in Jamf, as instructed here: https://scriptingosx.com/2020/06/using-installomator-with-jamf-pro/, installation via Self Service... Works fine for all other apps, must be something specific to the app or it's recipe I guess

FYI, I created a very basic recipe (which doesn't check for the most recent version, just to test):
inkscape)
name="Inkscape"
type="dmg"
downloadURL="https://media.inkscape.org/dl/resources/file/Inkscape-1.1.2.dmg"
appNewVersion=""
expectedTeamID="SW3D6BB6A6"
;;
That works without issues. I'm a bit puzzled though: the official label in Installomator does after all download the app etc. one would expect this to work as well? Unless it finds some incorrect version, of course...

Version 1.1.2 is an Intel only release.. I'm not sure which version was installing when you encountered the issue. There's been several releases since then, have you tested the newest release? The Installomator label is still getting the latest release correctly, except for not accounting yet for Intel vs Apple Silicon.
Right now the label will download https://inkscape.org/gallery/item/34663/Inkscape-1.2.1_x86_64.dmg

Ok, took a while until I could check this; tested it today on Intel + ARM with Installomator v10.3 beta, works fine again, thanks for the info!


Unable To Disable Pay For Pet Kills

*Description of issue: In Jobs 4.16.2, I am unable to disable pet pay for Hunter job. I tried setting the jobs.petpay permission to false, but that did not work. And as far as I can tell, there is no config option to disable it.
Server Type (Spigot/Paperspigot/etc): Tuinity (Paper)
Server Version (using /ver):  MC 1.16.3, latest build of Tuinity

Players not getting paid if they don't have petpay permission. Remove it, or set it to jobs.petpay.-1

I just tested on a clean server with no permissions setup and fresh jobs config. Pet kills pay with hunter job. Setting jobs.petpay.-1 did not work either.


Repo description might need to be edited

https://www.strapi.io doesn't DNS-resolve
The link should probably be changed to https://strapi.io

seems like this has been fixed, so I'm closing it. thank you for fixing!


Add more about PQLs and onboarding

Feel free to merge upon review

@ebrodymoore feel free to merge upon review


Closes #52: remove signup

I simply removed the signup, or we can do following - let me know what you think

not sure how to fix the current failing links, @StefanThoma @bms63 could you help check?

not sure how to fix the current failing links, @StefanThoma @bms63 could you help check?

I think it doesn't like the slack link,  you can just add it to .lycheeignore and it won't check it.  It should work - this happens I think in admiral as well.

Good to know. Thanks, @bms63 !


Check if effectiveToolType is null before calling ToolType#action

Fixes #3 (on 1.20)

FYI I actually started working on adding a harvestability tooltip built into WTHIT, see the exp/harvest branch. I plan to also backport it to 1.19.2 and 1.20.1.

Now that it is merged and in the middle of buildingfor release, I'll archive this repo.


What role needs to be granted to the service account email which is used for oidcToken.serviceAccountEmail for httpTarget Task with authentication

I am trying create a httpTask with authentication, but it keeps failing with the below error.

const task = {
//taskName,
httpRequest: {
httpMethod: "POST",
url: "https://host-test.org.com/task",
headers: {
traceHeaders: logTrace
},
oidcToken: {
serviceAccountEmail<EMAIL_ADDRESS>}
}
};

Error Message
Failed to create task:  {"code":7,"details":"The principal (user or service account) lacks IAM permission \"iam.serviceAccounts.actAs\" for the resource<EMAIL_ADDRESS>(or the resource may not exist).","metadata":{"internalRepr":{}}}
Currently below roles are granted to this service account.

Stackdriver Debugger Agent
Cloud Tasks Admin
Cloud Tasks Service Agent
Pub/Sub Editor

Can anyone please help me with what Role needs to be given to the service account to be able to generate the oidcToken?

Hi @SaugataDutta - did you find a solution for this? I have hit the same problem.

Its the Service Account User i.e roles/iam.serviceAccountUser role which finally worked for me to generate HTTP task with OIDC token..

Hi, how it's supposed to work with cross project?
I need cloud tasks to invoke a cloud function in another project.
I tried to:
1 - Create a service account
2 - Attach this account on cloud function:
gcloud projects add-iam-policy-binding user-staging \
<EMAIL_ADDRESS>\
  --role='roles/cloudfunctions.invoker'

But it's not working.
When I try to use cloud tasks service account on oidcToken.serviceAccountEmail it gives me:
Failed to create task: {"code":7,"details":"The principal (user or service account) lacks IAM permission \"iam.serviceAccounts.actAs\" for the resource<EMAIL_ADDRESS>(or the resource may not exist).","metadata":{"internalRepr":{}}}

Its the Service Account User i.e roles/iam.serviceAccountUser role which finally worked for me to generate HTTP task with OIDC token..

This is true but I don't like it. From what I understand, this role allows the user to become any service account theoretically? Or the default compute account?
Let's assume we are creating a task from cloud run managed instance that runs under a cloud-run-svc service account. We want to create a cloud task that will call back to the same cloud run service with the same cloud-run-svc service account. I would expect that this would either:

work out of the box (because cloud-run-svc can act as cloud-run-svc)
I would need to allow the cloud tasks default account to act as cloud-run-svc

With this solution it's neither. It turns out that I need to allow cloud-run-svc to become any service account, which I don't want.

I also got following error when I tried to enqueue from Cloud Function (go 1.13)
The principal (user or service account) lacks IAM permission "iam.serviceAccounts.actAs" for the resource<EMAIL_ADDRESS>(or the resource may not exist).

but I resolved the issue by following command.
gcloud projects add-iam-policy-binding ${ProjectID} --member serviceAccount:${ServiceAccount} --role=roles/iam.serviceAccountUser

Its the Service Account User i.e roles/iam.serviceAccountUser role which finally worked for me to generate HTTP task with OIDC token..

I could not find a better way. But by doing this be aware that if you have a default service account with editor role, your service account can now be editor. Sad...

@saugatadutta Did you mean to close this immediately after creating it? I'm not sure it got the attention it needed, and the suggestion to use roles/iam.serviceAccountUser opens a huge security hole as @mapad-oprate pointed out.

tl;dr: The global "Service Account User" role suggested here and on Google's docs doesn't seem to provide access to resources, it "only" allows Tasks to assert that callbacks can come from any service account inside your project, including the default compute engine service account. This means you shouldn't entirely trust the oidc token you get but it seems that you can be sure it was at least generated from any one of the service accounts within your project. Please, anyone at Google, correct me if I'm wrong.

I may be wrong about the size of the security hole. After digging around a lot (and trying various requests) as far as I can tell you can abuse this permission to create signed oidc tokens on behalf of any service account in your project, including<EMAIL_ADDRESS>But the only thing those tokens seem to allow you to do is assert your identity. That's really bad, of course, but it's not as critical as I'd first feared.
PoC:
Command-line script to inject a task, run this in an environment where you're authenticated as a service account (I used a k8s pod w/ a GCP SA bound to its k8s SA with Workload Identity).
const { CloudTasksClient } = require('@google-cloud/tasks');

// Fill in the blank: Your GCT queue name
const QUEUE_NAME = '...';

// Fill in the blank: Your project's numeric id
const PROJECT_ID = '...';

// Fill in the blank: Some URL on a server you operate that can accept HTTP POSTs (see the next file in this GH comment)
const TASK_URL = '...';

const main = async () => {
	const body = { x: 1, };

	const task = {
		httpRequest: {
			body: Buffer.from(JSON.stringify(body)).toString('base64'),
			headers: {'content-type': 'application/json'},
			httpMethod: 'POST',
			oidcToken: {
				audience: 'whatever',
				serviceAccountEmail<EMAIL_ADDRESS>			},
			url: TASK_URL,
		},
	};

	const request = {
		parent: `${QUEUE_NAME}`,
		task,
	};

	const cloudTasksClient = new CloudTasksClient();

	const [response] = await cloudTasksClient.createTask(request);

	console.log(JSON.stringify(response, null, 2));
};

main();

Express route to accept the POST from Tasks:
const express = require('express');
const router = module.exports = express.Router();

router.post(
	'/',
	async (req, res) => {
		const client = new OAuth2Client();
		const authorization = req.header('authorization');

		const idToken = authorization.replace(/Bearer /u, '');

		console.log(idToken);

		try {
			await client.verifyIdToken({
				audience: 'whatever',
				idToken,
			});

			console.log('verified');
		} catch (err) {
			console.error(err);
		}

		res.status(200).send();
	}
);

idToken is three strings joined by .s that contain two base64 encoded JSON objects and a signing key. The second object is a JWT, looks like:
{"aud":"whatever","azp":"123","email":"$PROJECT_ID-compute@developer.gserviceaccount.com","email_verified":true,"exp":1633117228,"iat":1633113628,"iss":"https://accounts.google.com","sub":"456"}
and that's what you'd typically use to verify the source of a request.


SSL Certificate for https://pkg.freebsd.org/ expired

Is anyone else getting an expired certificate for https://pkg.freebsd.org/ ???  Or is it just the mirror that I am using?

The SSL cert was replaced.  If you ever have a problem, use the non-https URL for http://pkg.freebsd.org


how to support phantomjs 2.1?

when i use phantomjs 2.1, the following error happens:
WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none was installed

how to resolve this issue?

Encountering same issue

have you actually installed phantomjs-prebuilt locally?

I did and the installation is successful after that, but Karma is still not able to locate the "PhantomJs" launcher.
I get this error:
[11.05.2016 15:51:10.777] [Karma] [Debug] [Proj.Tests] 11 05 2016 15:51:10.777:INFO [karma]: Karma v0.13.22 server started at http://localhost:7599/
[11.05.2016 15:51:10.779] [Karma] [Debug] [Proj.Tests] 11 05 2016 15:51:10.778:WARN [launcher]: Can not load "PhantomJs", it is not registered!
[11.05.2016 15:51:10.780] [Karma] [Debug] [Proj.Tests]   Perhaps you are missing some plugin?

That means karma is not finding karma-phantomjs-launcher. You need to either add it to the devDependencies in your package.json or the plugins section in the karma.conf.js. See this for details: http://karma-runner.github.io/0.13/config/plugins.html

It's already part of my devDependencies. Based on the my logs, the phantomJs launcher was loaded successfully, but karma still complains that this package is not registered.
[11.05.2016 15:51:10.713] [Karma] [Debug] [Proj.Tests] 11 05 2016 15:51:10.713:DEBUG [plugin]: Loading plugin c:\dev\proj.tests\node_modules/karma-phantomjs-launcher.

can you show me your karma.conf

I am just using the default karma configuration.
// Karma configuration

module.exports = function(config) {
    config.set({
        // base path that will be used to resolve all patterns (eg. files, exclude)
        basePath: '',

        // frameworks to use
        // available frameworks: https://npmjs.org/browse/keyword/karma-adapter
        frameworks: ['jasmine'],

        // preprocess matching files before serving them to the browser
        // available preprocessors: https://npmjs.org/browse/keyword/karma-preprocessor
        preprocessors: {
        },

        // test results reporter to use
        // possible values: 'dots', 'progress'
        // available reporters: https://npmjs.org/browse/keyword/karma-reporter
        reporters: ['progress'],

        // web server port
        port: 9876,

        // enable / disable colors in the output (reporters and logs)
        colors: true,

        // level of logging
        // possible values: config.LOG_DISABLE || config.LOG_ERROR || config.LOG_WARN || config.LOG_INFO || config.LOG_DEBUG
        logLevel: config.LOG_DEBUG,

        // enable / disable watching file and executing tests whenever any file changes
        autoWatch: true,

        // start these browsers
        // available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
        browsers: ['PhantomJs'],

        // Continuous Integration mode
        // if true, Karma captures browsers, runs the tests and exits
        singleRun: false,

        // Concurrency level
        // how many browser should be started simultaneous
        concurrency: Infinity,

        // list of files / patterns to load in the browser
        // Order is important, so make sure files are loaded in correct order
        files: [
          '**/*.test.js'
        ],

        // list of files to exclude
        exclude: []
    })
}

I found the issue, i was using wrong browser name. It had to be "PhantomJS" instead of "PhantomJs".
Thanks for your help anyways.

Sweet :) happy to help


ISSUE-9 - first pass at map-concurrent and practical tests

Preliminary PR for #9 with practical tests added

Coverage remained the same at 100.0% when pulling 4f64d0dd4310742a2a2a0b2fcdf95065b5e9f63d on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.

Coverage remained the same at 100.0% when pulling d0905f8e7b9256eea4cb2f49dd372be351ff7f91 on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.

Coverage remained the same at 100.0% when pulling cbd2c36dffca6fb0033891ba414ff8411c3047e6 on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.

Coverage remained the same at 100.0% when pulling be95004d70efb6e3e5981ddf4792d8432bc80cdb on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.

Coverage remained the same at 100.0% when pulling f4be4805026735b9a6ea1f04323ff4fcf7596c6c on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.

Coverage remained the same at 100.0% when pulling a1eb21346186120334676f0f4ab37feaf7aa0ecf on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.

Coverage remained the same at 100.0% when pulling 1cd6234be020341fd5e62879f1d105159987993d on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.

Coverage remained the same at 100.0% when pulling 2d3afb1efe790c03194ae3e2ed626ebeaf97034c on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.

Coverage remained the same at 100.0% when pulling e41c7c072c29c3f58217264e4fc211f73385bf65 on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.

Coverage remained the same at 100.0% when pulling 95758657c348695e4be8b7b051500ddfb310e6ae on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.

Coverage remained the same at 100.0% when pulling 8dc2a59bb47247e08004476f9e793c26aed8a57e on ISSUE-9 into 7f35d6dcf181e2ab7dc1b5726311dc1c5c619cb3 on master.


Verify XDP program name before removal

Description
This PR verifies that the name of the BPF program is prefilter which is of the XDP program that Felix uses
when running, the RemoveXDP() function that is run during XDP re-sync.
I also implemented a unit test to verify the fix.
The idea of the unit test is to create an XDP BPF file with a different program name and load it to a network interface.
My first idea was to use the existing prefilter program and modify the name by altering the function name in the symbol table (the name is derived from the function). By altering the name, we can simulate a program that does not match during the name verification and therefore should not get deleted.
This can be achieved with objcopy. The version of objcopy in the Debian 10 docker image that is used for tests does not yet support the elf64-bpfle file format. A solution would be to upgrade to Debian 11.
However, to keep it simple, I added the modified BPF program in a testdata package for now, as it seems like the most suitable solution.
Disclamer
Currently, this only works for the prefilter program.  It is not clear to me whether this needs to be further generified.
Related issues/PRs
https://github.com/projectcalico/calico/issues/5250
Based on existing commits from user @sjh5205. Thanks! I added you as co-author.
https://github.com/sjh5205/felix/commit/6f4a643e988cb61ebeb4bf80b749f737619a04a1
https://github.com/sjh5205/felix/commit/b6bc626a48f3d27726f8fff1dd69e4f572c5a007
Todos

[x] Tests
[ ] Documentation
[ ] Release note

Release Note

TBD

Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one docs-* label.

docs-pr-required: This change requires a change to the documentation that has not been completed yet.
docs-completed: This change has all necessary documentation completed.
docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

release-note-required: This PR has user-facing changes. Most PRs should have this label.
release-note-not-required: This PR has no user-facing changes.

Other optional labels:

cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@alexanderstephan #7219 merge, could you review whether/how would your change apply? :pray:

Yes, I just saw it. I am trying out if my tests still works, but I am having a bit trouble with the setup. If the test works we can safely close https://github.com/projectcalico/calico/issues/5250, I think.

@tomastigera OK, my fix still seems relevant. Tests now passing again locally with the additional logic. Feel free to take another look, but looks good from my side.

@tomastigera Can you please have a look at this PR? This feature/bug fix would be really useful.


Native Windows Version

Can you add a Windows installer also to try on MS Windows?

We recommend using Docker or WSL to run EdgeDB on Windows for now.  Native Windows support is not currently a priority.

We need to make sure our "Download" page suggests people how to work with edgedb on Windows. Will keep this open until we update it.

Note to myself: this will be part of the new website design.

Just a reminder that this issue is solved and can be closed.


Improve error from "zed serve" due to lake version mismatch

Repro is by moving from Zed commit bbc9c4d to 332fb2c.
Commit 332fb2c introduced a change to the lake storage format that upped its version from 1 to 2. This is shown with a clear error message if the lake is accessed directly on the filesystem.
$ zed -version
Version: v1.5.0-33-gbbc9c4d4

$ zed -lake /Users/phil/lake init
lake created: /Users/phil/lake

$ zed -lake /Users/phil/lake create foo
pool created: foo 2LsJWT2yTYoq25GVD9gLYe34zCg

$ zed -lake /Users/phil/lake -use foo load sample.zng
(2/1) 4910B/4910B 4910B/s 100.00%
2LsJYY3LdddLKYoTWF3AnAAD47n committed

Then Zed is upgraded to the version with the new lake format. The error message from zed query is helpful.
$ zed -version
Version: v1.5.0-34-g332fb2cd

$ zed -lake /Users/phil/lake query 'from foo | count()'
unsupported lake version: found version 1 while expecting 2

However, if we try to start a service using the lake, the error message is less helpful.
$ zed -lake /Users/phil/lake serve
open /Users/phil/lake/lake.zng: file exists

@mccanne's thought upon seeing this:

Yes, that's probably because opening the lake fails and then it tries to make the lake.  Should detect the version mismatch on open.

Verified in Zed commit 6889ec5.
Repeating the repro steps, now when we run zed serve on the old-format lake directory we get the helpful error message.
$ zed -version
Version: v1.5.0-36-g6889ec58

$ zed -lake /Users/phil/lake serve
unsupported lake version: found version 1 while expecting 2

Thanks @mccanne!


Support Linode as ddns Provider

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[ X] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md
[ X] I have searched the existing issues, open and closed, and I'm convinced that mine is new.
[X ] When the request is meant for an existing plugin, I've added its name to the title.

Is your feature request related to a problem? Please describe.
The legacy plugin of dyndns was removed on 23.7, and the ddns plugin does not have a solution for the Linode cloud provider.
Describe the solution you'd like
Add Linode as a DDNS provider to the list. I found this project on GitHub: https://gist.github.com/amoe/06cf6ffe66eec9efd0135b775cff0363 which may be of help.
Describe alternatives you've considered
No alternatives are available as all my domains are hosted by Linode. This prevents me from upgrading to Opnsense 23.7.

I still cannot understand why os-dyndns plugin was depreciated. The os-ddclient in either legacy or Opnsense version is seriously limited in functionality and support of DDNS providers. It does not work for FreeDNS either.

I found this patch with the help of @amoe: https://sourceforge.net/p/ddclient/tractickets/23/ - A patch was submitted for ddclient 3.8 on source forge to add Linode as ddns provider.

I still cannot understand why os-dyndns plugin was depreciated. The os-ddclient in either legacy or Opnsense version is seriously limited in functionality and support of DDNS providers. It does not work for FreeDNS either.

I'd hazard to say that it's because noone wants to maintain these things. It's a complete nightmare. Things breaking all the time due to changes made by dyndns providers, loads of those services are paid for and/or with no way to test them, people bugging you to add obscure providers noone ever heard about and that's just the start.

I would not think Linode as an obscure provider. Since there is no support neither on ddns or here, I am pretty much stuck on last the opnsense version supporting os-dyndns plugin. And I believe I am not the only one.
on 23.1.11_2 ddns does not even show what IP address it is tracking or updating. I honestly can't say if my address changes that ddns will update it.
The ddns project also lost its maintainer and was being put on life-support until re-write. Also taking into consideration that os-dyndns had support for so many more providers, I still stand to that I cannot understand the rationale for depreciating the plugin. At least it could have stayed as a legacy plugin without support until a suitable replacement for all the providers was found.

The ddns project also lost its maintainer and was being put on life-support until re-write.

While that was true it's back on track and 23.7.9 will add the latest version 3.11.1.
To be frank we see two things here:

Lack of DynDNS providers adding support into all available tools themselves.
Lack of DynDNS users ability to code and debug themselves.

It tells us that DynDNS is a niche technology for home users with all of its good and bad implications. It only takes that one user contributing, but everyone seems to be complaining why that contribution wasn't made or why it was broken (by the provider most likely). This is a never-ending story. I also agree that paid-only access is making it way harder to implement these things and keeping them up-to-date.
Cheers,
Franco

I agree with your points. If I could write code at that level, I would certainly contribute. However, reading Reddit posts and other forums, many OPNsense users are stuck on the OPNsense release having the dyndns-plugin since they use providers not supported on the os-ddclient plugin.
While I do not know how much work would have been involved in keeping the legacy dyndns plugin as an unsupported plugin, I still believe that this could have been a solution for users like myself to bridge the gap until os-ddclient was providing the necessary support for more DNS providers.


Hide Round-End Vote Counts

this was kinda always the plan but now it's possible

Can you also disable it for map votes if they are not already?

ok


what():  encryption parameters do not support batching

I am getting this error (SEAL version 3.5.8):
terminate called after throwing an instance of 'std::logic_error'
  what():  encryption parameters do not support batching

Parameters:
N = 4096
t = 257
q = default value for 4096. Three moduli 36,36,37 bits.
keygen->galois_keys_local( vector <uint32_t> {3 , 5, 9, , 17, 33, 65, 129, 513, 1025, 2049, 4097} )

Could you point out the issue? This seems fine to me.

This is explained in the examples.

Great. That works. Thanks.


Set userVerification to preferred in registration options

In the authentication flow, userVerification is set to "preferred" so that user verification is only attempted when possible (i.e. biometric authentication methods like TouchID are presented when available, but it is not required for successful authentication).
However, on the registration flow userVerification is not specified. Because of this, userVerification is required as this is the default in SimpleWebAuthn's verifyRegistrationResponse. This presents an issue during the registration flow when using iCloud Keychain or Chrome's built in passkey manager when no user verification method is available (e.g. when a MacBook is in clamshell mode and therefore TouchID is not present/available). In this case, the follow error is returned from authenticator.authenticate(): User verification required, but user could not be verified.
This PR addresses this by specifying userVerification: "preferred" on the registration flow as well so that the user verification behaviour is consistent in both flows. This follows the guidance from web.dev on how to specify the userVerification parameter.

This is published.


MWPW-160617: Remove legal disclaimer below the widget for Signed-In users only

Resolves: MWPW-160617
Test URL:

https://main--dc--adobecom.hlx.live/acrobat/online/sign-pdf
https://mwpw-160617--dc--adobecom.hlx.live/acrobat/online/sign-pdf

Codecov Report
Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 84.64%. Comparing base (0fd8344) to head (b289860).

Files with missing lines
Patch %
Lines

acrobat/blocks/verb-widget/verb-widget.js
0.00%
10 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #897      +/-   ##
==========================================
- Coverage   84.71%   84.64%   -0.08%
==========================================
  Files          48       48
  Lines        6183     6187       +4
==========================================
- Hits         5238     5237       -1
- Misses        945      950       +5

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles


Add config_modbus_port option to allow Modbus port to be set (for virtualcoke)

Support patch to allow Modbus port to be set.     This is part of the ongoing development work for uccvend-vagrant

A few notes:

Prefix for the port number should be gi not gs
What is up with the change to items.cfg?


Blazor Hybrid WinForms sample code not working

[Can't run the sample code as I get an error from the Program.cs file as follows:
System.InvalidOperationException
HResult=0x80131509
Message=Unable to find the required services. Please add all the required services by calling 'IServiceCollection.AddWindowsFormsBlazorWebView' in the application startup code.
Source=Microsoft.AspNetCore.Components.WebView.WindowsForms
StackTrace:
at Microsoft.AspNetCore.Components.WebView.WebView2.WebView2WebViewManager..ctor(WebView2 webview, IServiceProvider services, Dispatcher dispatcher, IFileProvider fileProvider, JSComponentConfigurationStore jsComponents, String hostPageRelativePath, Action`1 urlLoading)
at Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.StartWebViewCoreIfPossible()
at Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.OnCreateControl()
at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
at System.Windows.Forms.Control.CreateControl()
at System.Windows.Forms.Control.WmShowWindow(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
at System.Windows.Forms.ContainerControl.WndProc(Message& m)
at System.Windows.Forms.Form.WmShowWindow(Message& m)
at System.Windows.Forms.Form.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, WM msg, IntPtr wparam, IntPtr lparam)
This exception was originally thrown at this call stack:
Microsoft.AspNetCore.Components.WebView.WebView2.WebView2WebViewManager.WebView2WebViewManager(Microsoft.Web.WebView2.WinForms.WebView2, System.IServiceProvider, Microsoft.AspNetCore.Components.Dispatcher, Microsoft.Extensions.FileProviders.IFileProvider, Microsoft.AspNetCore.Components.Web.JSComponentConfigurationStore, string, System.Action<Microsoft.AspNetCore.Components.WebView.UrlLoadingEventArgs>)
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.StartWebViewCoreIfPossible()
Microsoft.AspNetCore.Components.WebView.WindowsForms.BlazorWebView.OnCreateControl()
System.Windows.Forms.Control.CreateControl(bool)
System.Windows.Forms.Control.CreateControl(bool)
System.Windows.Forms.Control.CreateControl()
System.Windows.Forms.Control.WmShowWindow(ref System.Windows.Forms.Message)
System.Windows.Forms.Control.WndProc(ref System.Windows.Forms.Message)
System.Windows.Forms.ScrollableControl.WndProc(ref System.Windows.Forms.Message)
System.Windows.Forms.ContainerControl.WndProc(ref System.Windows.Forms.Message)
...
[Call Stack Truncated]
The code in this file is:
namespace WinFormsBlazor
{
internal static class Program
{
///
///  The main entry point for the application.
///
///
    [STAThread]
    static void Main()
    {
        // To customize application configuration such as set high DPI settings or default font,
        // see https://aka.ms/applicationconfiguration.
        ApplicationConfiguration.Initialize();
        Application.Run(new Form1());
    }
}

}
]

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0b88d48-74df-8dc4-446d-121e65b552ab
Version Independent ID: b0b88d48-74df-8dc4-446d-121e65b552ab
Content: Build a Windows Forms Blazor app
Content Source: aspnetcore/blazor/hybrid/tutorials/windows-forms.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @rod-mac ... Thanks for the report! Yes! They made a change for the release last week ... that they didn't tell the doc guy about! 😢. I even asked them if there were any other changes, but they didn't say so. There was nothing in the blog post on this. I suspect that in addition to this change that I'll need to check on the WPF tutorial, too. I know the MAUI one is ok, as we made updates to that one for RC1.
I ran the WinForms app in the original form, too, following the guidance and received the same result that you did ...

The change that they made is in Form1.cs. They went from ...
services.AddBlazorWebView();

... to ...
services.AddWindowsFormsBlazorWebView();

If you make that change, you should be able to get it running ...

I'm going to put in an 🚑🚒🚓 emergency patch 🚑🚒🚓 on the tutorial right now, and it will go live within perhaps 20 minutes.
Leave this issue open, as it will close automatically in a few minutes after the update goes in.
Thanks again for the report, @rod-mac! 🎸