Ensure router group with available TCP port

First pass of merging the logic from the service-gateway library into the routing-api.
#175028198
Signed-off-by: Shaan Sapra<EMAIL_ADDRESS>

Hi @ssapra, It looks like you are continuing to push commits. Please let us know when you are done and want us to review.
Thanks!

Hi @ameowlia we're ready for that review now, thanks.
We're struggling to add the EasyCLA auth. We'll add it later.

Hi @colins and @ssapra,
Can you provide any docs or background on the "why" you are doing this, just so I can better understand the use cases you are working towards? Also do you have any api docs something like these?

Hi @ameowlia ,
That's totally fair, we should've added some more context in the description.
In order to support off platform access to a service instance on the foundation, we have decided to use the TCP router provided in cf-deployment. To use the feature, we ask operators to decide on a port range that they would like to allocate for service instances of a specific database (i.e. MySQL or RabbitMQ).
When the CF developer chooses to provision/update a service instance that has enabled off platform access, we need to be able to find which ports are available in the port range that the operator has chosen. To that end, we've built a utility function that is able to list all router groups, determine which ports are already reserved, and then find the first port that is available to be reserved for the service instance.
Initially this utility function was used solely by the RabbitMQ team. Now we on MySQL have begun to use it as well and we are trying to avoid proliferation of repositories whose sole purpose is to interact with the internals of the routing-api via the client. We think that this small utility function can be added to the routing-api so that it can be maintained alongside other similar functions.

To add a bit more context to the Service Gateway feature:
A blog post describing the Service Gateway ( aka. Off Platform) feature can be found here.
More information on how this feature is currently used in the RabbitMQ Tile and an architecture diagram can be found here.
This PR intends to simplify and to reduce the number of dependencies needed for the Service Gateway feature by moving existing logic from the service-gateway Go module (not open source) to the routing-api such that the service-gateway Go module doesn't need to exist anymore.

Thank you for the context @ssapra and @ansd, that really helps. In order to help us try out these endpoints for ourselves, can you please add corresponding api docs to this file - https://github.com/cloudfoundry/routing-api/blob/main/docs/api_docs.md .
Thank you!

We aren't adding or changing any endpoints. We intend to vendor the routing-api and invoke the client directly in our code.

Gotcha. Thanks @ssapra. I have added this story to our backlog to review & comment & merge. Is there any time pressure on this?

There's no time pressure. For now both teams are using the service-gateway library so we're unblocked in making progress.


Tool requires .NET 5.0, which is out of support (EOL-ed)

In order to run the tool, one has to install .NET 5.0, which is deprecated/EOL-ed. It is recommended to move applications forward to .NET 6.0

Thanks for the pull-request <3


Add progress bar to rovers forms

progress bar added to form pages:

common attribute states: 25%
specific attribute states: 50%
resource states: 75%

I will add a progress bar to room_state forms too. What do you think?

Makes sense. Honestly it's just a design choice.

I will add a progress bar to room_state forms too. What do you think?

Oh, sorry. I wanted to write 'Would you like to add a progress bar to room_state forms too?' Not that I will add it.


[1530] Move create logic to controller

Context
The access request controller currently has the logic for adding the requester_id, request_date_utc and the status to the access_request object upon instantiation.
Changes proposed in this pull request

Move updating the above 3 attributes from the controller to the model.

Checklist

[x] Make sure all information from the Trello card is in here
[x] Attach to Trello card
[x] Rebased master
[x] Cleaned commit history
[x] Tested by running locally

Good point 👍

 [S] Move access request logic to model callbacks


Ignoring event coming from unknown registry

So I remember reading about the issue with notifications and the registry/portus being behind compose.
In the case of "Ignoring event coming from unknown registry" (it detects the registry as "registry:5000" instead of docker.internal.example.com) would it not just be simplest to follow up with a http call and pull the event from the registry api?
I am not sure of the notification payload because it isn't logged, but it would seem that one could query the registry api for the notification supplied by the rejected payload and use the reponse.

Could you provide more information ? Versions of docker, distribution and Portus (also note that we have released Portus 2.0.3 not so long ago, and that it fixes some known problems with the registry). Even better, we may want to continue this conversation in our new mailing list: https://groups.google.com/forum/#!forum/portus-dev. If we realize that it's an actual bug from Portus, then we can submit a new issue. What do you think ?

I've just run into something similar.  Finally got my nginx proxy working with both portus and registry on same host.  I don't think it's a problem with Portus and the event  spec per-se, but rather in the ways in which you determine if it is a known registry.  Too tired to do a full write up, but I'll try to follow up tomorrow

Closing this issue since it's old and we never got info back.
@jmahowald feel free to leave a comment here anyways, any help that we can get is always appreciated :blush:

Here's what I believe the fundamental issue is.  There isn't a way to configure the "host" field of the event that the registry uses when it pushes an event.  It appears to use the name that the client used when interacting with the registry.   I have portus though communicate directly with the registry, as SSL termination is happening through nginx.  So that "hostname" in portus is registry:5000.   That's fine since they are linked.  But my clients that want to push go to registry.docker.mycompany.com over 443.
I think the most correct answer might be to propose a "fix" to the registry to allow the incoming host to be configurable, as the service in the auth token is.   I also think the easier thing for me to fix would be to patch portus to have another field in the registry configuration like external name, or to break up the "hostname" field into host and port, then change the matching logic in the event handler.
Thoughts?

Thanks for taking the initiative and submitting a PR :blush: As I said in your PR, I didn't think about this option really :sweat_smile:


Make this repo support multiple architectures

Fixes https://github.com/kubernetes/heapster/issues/1280
Written in line with proposal https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/multi-platform.md
Originally in https://github.com/luxas/kubernetes-on-arm/tree/master/addons/images
Disclaimer: I have not manually tested this yet.
I would appreciate feedback.
I left all amd64 code totally unchanged, but eventually I think we'd like to make the amd64 images smaller as well.
We could for example release a v1.2.1 with no code changes, just release infra changes if we want to
@piosz @vishh @brendandburns @ixdy @kubernetes/heapster-maintainers

This change is

🤗 👍

@vishh @kubernetes/heapster-maintainers This PR is now ready for review.
I'd like to get it merged soon, as we're planning to add the heapster deployment by default to kubeadm.
It's easy for you to just merge this and push the influxdb and grafana containers.
But we can discuss what we should do with the heapster image.
I think we have two options:
a) You checkout the v1.2.0 Go code, but use this releasing/deployment code when pushing the image
b) After this PR is merged, I'll send a PR that targets the release-1.2 branch, and you can then release v1.2.1 with that commit.
Also, I'd like to know if you'd like that the amd64 images stay the same, or if they should be swapped to this "new" code (that's risky, but you choose)
Please take a look as soon as possible.

@luxas thanks a lot for you change. Do you anyone in your mind who is familiarized with build stuff and can review it?

@piosz I think you and @vishh would be perfect :)

@luxas I can take a look from high level Kubernetes perspective, but I don't have enough expertise with go build.

I can review the build aspects of this PR.

thanks @vishh

ping @vishh @piosz
I hope we'll be able to merge this PR this week so we can release a v1.3 version next week or so

I'll rebase when you say you have time to look at it

@vishh @piosz Rebased, but this is a WIP item, still testing locally
I guess I'll have it ready tomorrow or on Thursday
Do we want to have influxdb 1.1.1 in the next release? I think that would be great!
In that case, merge #1415 now, before this one, but do not push the image, since I would build on top of that PR.

@timstclair votes for using the new images that I wrote that are of minimal size, and I vote for that too.
@vishh does it make sense to you to switch to those simpler images as well?
That would also reduce the amount of code that's required.

@luxas updating influxdb and grafana would be great. We don't have a
release process for those images since they meant to serve as a reference
implementation only. If the build process is robust, then just documenting
a release process for these images should suffice.
On Tue, Jan 3, 2017 at 3:16 PM, k8s-ci-robot<EMAIL_ADDRESS>wrote:

Jenkins GCE e2e failed
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/heapster/1387/pull-heapster-e2e/80/
for commit 4a1c976
https://github.com/kubernetes/heapster/commit/4a1c9764479aceb2b007b923aced83f1c3001b43.
Full PR test history http://pr-test.k8s.io/1387.
The magic incantation to run this job again is @k8s-bot test this. Please
help us cut down flakes by linking to an open flake issue
https://github.com/kubernetes/heapster/issues?q=is:issue+label:kind/flake+is:open
when you hit one in your PR.
If you have questions or suggestions related to my behavior, please file
an issue against the kubernetes/test-infra
https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:
repository. I understand the commands that are listed here
https://github.com/kubernetes/test-infra/blob/master/prow/commands.md.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kubernetes/heapster/pull/1387#issuecomment-270253105,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGvIKO9xYBXEJ8P4jprOkNJtCaKU85V_ks5rOtaygaJpZM4K12-1
.

Updated this now. This works great on amd64!
Please take a look and merge today so we can test the new release soon.
@vishh @piosz @DirectXMan12

@piosz Please merge this now so you feel comfortable with it in time for the release.
It's ready to merge, and simplifies things a lot while adding the manifest list functionality, which means docker will pull the right layers for the right arch automatically.
Ping me if you have any comments, but I've worked on this for so long now so it's quite robust

Is make push the magic command to build and push for all architectures? If yes, I'd suggesting having a dry run mode where a real push doesn't happen, just to verify images locally.

@piosz Feel free to merge this.
It worked fine for @vishh
A build-all or something make target that would build for all arches would be an improvement, but that's only a slight improvement.
The default build-only behaviour is still working with container or build.
I'm excited to get this merged!

Thanks for your contribution.

@piosz Just make sure you docker login to your GCR account before you push everything (i.e. you can't use gcloud docker only.


no style for disabled input

You tested direct downloading from the repository or from a package manager?
These features will come in version 1.1.0

I always pull the source from the master branch and compile on my own.

I always pull the source from the master branch and compile on my own. @cjpatoilo I'll send a PR

that was funny, just fetched the latest commits from master. Disabled button works fine now but it seems that milligram on CDNjs isn't updated.


Release PartitionedSolvers v0.3.0

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.81%. Comparing base (37e60ca) to head (fa471b1).
Report is 140 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   85.26%   86.81%   +1.55%
==========================================
  Files          11       11
  Lines        4302     5096     +794
==========================================
+ Hits         3668     4424     +756
- Misses        634      672      +38

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Automated cherry pick of #7710: httperrors: use existing details if id is not present

Cherry pick of #7710 on release/3.4.
#7710: httperrors: use existing details if id is not present

/lgtm
/approve


As a addition to the inventory viewer can we get a worn equipment viewer?

title

This is what I have so far. I will continue with this tomorrow to include the slot tiles and placeholders similar to the equipment tab.

Managed to get the tiles and placeholders working. Will finish this off tomorrow.

#4712


MS Docs Platform Productized?

This is a question and not feedback, but couldn't find a good place to ask.
Is docs.microsoft.com available as a platform that other companies or individuals can use? It's a really great documentation format and system of contribution. Would be great if it were productized for others to use as well for their own documentation needs.

Very good question @joshua-phillips! The MS Docs platform is something I would like to be able to use instead of SharePoint documents. I hope we can get a positive answer to this soon.


Is there a Linux i386 version?

Is there a Linux i386 version?

Thank You !

Nope. Use JAR instead.
(GraalVM native-image doesn't support i386 build)


mendix-cloud

Please use the form below, leaving the prefilled data to help us. Thank you.
Page link: mendix-cloud
Document link: _index.md
My Issue/Suggestion
Regarding the number of environments per free app, the documentation versus the pricing page provide conflicting information:

https://docs.mendix.com/developerportal/deploy/mendix-cloud-deploy/  specifies single environment
https://www.mendix.com/pricing/ specifies 2 environments

Hi Dan,
Thanks for the comment and suggestion.
It is confusing, but when the pricing page refers to two environments it is including the ability to deploy the app locally for testing on your own machine. This is the way most low-code companies count their environments.
In the documentation, we are talking about deploying to the cloud and so talk about one cloud environment, to make it clear that there is only one environment that can be shared with users.
I will have a look and see if this can be made clearer.
Thanks for drawing attention to this conflict - I will pass your experience on and see if we can make our messaging clearer.
Yours
Mark


frozen OS error.

I'm not sure if this is as I'm UK based and it won't work for me, however this will not run. following setting up env file, and turning headless back off, it seems it's not even getting to opening a chrome window. Any ideas on what may be causing the below?
Traceback (most recent call last):   File "C:\Users\My Laptop\Desktop\BingRewards-main\main.py", line 29, in <module>     if not os.environ["LOGIN"]:            ~~~~~~~~~~^^^^^^^^^   File "<frozen os>", line 679, in __getitem__ KeyError: 'LOGIN``

Make sure you have a `LOGIN' variable in your env. Seems to be an issue with your system.

I'm having the same issue. Whenever I attempt to run it, it gives me the same thing. Here is what it looks like.
Required .env variables:
Comma delimited, remove quotes if using a single account
'LOGIN'= southwestern12cat@gmail.com:a2zwithme
If you open up the Bing homepage in incognito mode and click the "Sign In" button.
Should take you to the login page, where you can copy the URL and assign it to the URL env variable.
URL="https://login.live.com/login.srf?{QUERY}"
Optional .env variables:
Set WebDriver Download Manager status to on
Default: True
Values: True | False
HANDLE_DRIVER=True
** Experimental **
Set the browser the bot will use.
Not used in Docker
HANDLE_DRIVER must be True
Default: 'chrome'
Values: 'chrome' | 'edge' | 'firefox'
BROWSER='chrome'
Whether the program will run in headless mode [no ui]
Default: False
Values: True | False
HEADLESS=False
Whether the program will run multiple threads to run all accounts or not
Default: False
Values: True | False
MULTITHREADING=False
How long to wait before performing searches
Values: Any valid integer
DELAY_SEARCH=10
Configure Apprise URL Alerts
Full list of available URLs
https://github.com/caronc/apprise/wiki
Default:
Values: Any Apprise URL
APPRISE_ALERTS=
Auto-Redeem rewards
Default: False
Values: True | False
AUTO_REDEEM=False
Set the goal automatically
Default: 'amazon.com'
Values: 'amazon.com' | 'hulu' | 'walmart'
GOAL='amazon.com'
Whether the bot should automate punchcards
Default: False
Values: True | False
AUTOMATE_PUNCHCARD=True
** Experimental **
Attemptes to create a new shoping feature

No contributing developer has access to this method
of points to verify/debug functionality
Default: False
Values: True | False
SHOPPING=False
Sets the currency symbol or name
Plan to add more as more users provide information on their local conversion rates.
Default: USD
Values: $ | USD | € | EURO
CURRENCY=USD
Name of the instance of the bot
Default: 'Bing Rewards Automation'
Values: Any String, single-quoted if name contains spaces or special characters
BOT_NAME='Bing Rewards Automation'
Sets the timezone for the bot
Default: 'America/New_York'
Values: Any valid IANA timezone (https://www.iana.org/time-zones)
TZ='America/New_York'
Enables / Disables the timer functionality
Default: False
Values: True | False
TIMER=False
What time the bot will function

Use 1-24 to set time, such as 4 being 4:00AM, 13 being 1:00PM
Default:
START_TIME: 4
END_TIME: 19
Values: 1-24
START_TIME=4
END_TIME=19
Whether you want to use a flask server to prevent the program
from dying

Default: False
Values: True | False
KEEP_ALIVE=False
Your desired external IPv4 Address
Optional
If you do not want to check your external IPv4 address
is the same as your desired IPv4 address
Default:
Values: Any valid IPv4 Address
WANTED_IPV4=
Your desired external IPv6 Address
Optional
If you do not want to check your external IPv6 address
is the same as your desired IPv6 address
Default:
Values: Any valid IPv6 Address
WANTED_IPV6=
Configure a HTTP(S) or SOCKS5 proxy through which all of the bot's traffic will go
Default:
Values: Any valid URI format proxy (e.g., https://<IP_ADDRESS>:5678)
PROXY=https://<IP_ADDRESS>:8000


Index non-200 responses and robots.txt

Since August we have datasets with non-200 responses (redirects, 404s, etc.) and robots.txt files [1]. They should be added to the Common Crawl index, cf. [2]. Trivial to do: add these WARC files to the index input but make sure that paths/filenames do not collide.

Fixed with CC-MAIN-2016-50:
Create list of all WARC files (including robots.txt and non-200 responses) to step 1 (indexwarcsjob.py):
cat {warc,robotstxt,non200responses}.paths | shuf >input.paths

(list is shuffled so that smaller robots.txt and non-200 WARC files are mixed with large main WARC files)


Cannot build documentation with Python 3.11 or 3.12

Describe the bug
When building documentation using sphinx, for release <IP_ADDRESS> get an error
invalid use of incomplete type ‘PyFrameObject’ {aka ‘struct _frame’}

Full Log
Full log is available at
https://kojipkgs.fedoraproject.org//work/tasks/273/106030273/build.log
Minimal Reproduce
sudo dnf install wget sphinx-build python3-devel gcc-c++
wget https://github.com/jittor/jittor/archive/<IP_ADDRESS>/jittor-<IP_ADDRESS>.tar.gz
tar -xf jittor-<IP_ADDRESS>.tar.gz
cd jittor-<IP_ADDRESS>
cd doc
sphinx-build -b man source man

Expected behavior
Expect to get documentation.

We prepared the official documentation:
https://cg.cs.tsinghua.edu.cn/jittor/assets/docs/index.html


[Improvement][Task Log] Adding color display for log levels and time in task log.

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
Currently, DolphinScheduler does not add color display for log level and log time in Task instance log, which is not effective when locating key content when there is a lot of log content.
It is recommended to refer to the log file color display function of vscode to improve the user experience when viewing task logs.
DS 3.1.x task instance log:

Color display effect of vscode log file for reference:

In order to make the display more beautiful, I modified the some log printing format in SQL task.
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

if no one is working on this, i'd like to deal with it.


(feature) 메뉴 숨김

Remove X(close) button
tkinter.Tk().overrideredirect(1)
#Reference
http://stackoverflow.com/questions/17117156/create-a-python-tkinter-window-with-no-x-close-button


Doc: update etcd configuration detail with config file

Add a reference of the config file, sample file link and precedence detail  to the
configuration doc.
Fixes #9063
Contributing guidelines
Please read our contribution workflow before submitting a pull request.

/cc @gyuho @xiang90
Since the config file itself is used through a command line flag, I didn't create a new section but tried to add detail in the current sections on configuration flags. Thanks!

Do we have a doc about the syntax and options for the config file? For
example how do we map command line flags to config file yaml fields?
On Sun, Dec 24, 2017 at 11:56 AM Sahdev Zala<EMAIL_ADDRESS>wrote:

/cc @gyuho https://github.com/gyuho @xiang90
https://github.com/xiang90
Since the config file itself is used through a command line flag, I didn't
create a new section but tried to add detail in the current sections on
configuration flags. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coreos/etcd/pull/9066#issuecomment-353800802, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AERby5aMEvwaR0H3LfdB_Tu2rKeXQOgeks5tDqxlgaJpZM4RMAKL
.

@xiang90 it seems like configuration.md is the doc which has all the flags usage and syntax documented that can be used in the config file.

@xiang90 I have tried modifying a line to show the relationship/mapping between file and flags as "A reusable configuration file is a YAML file made of one or more command-line flags...." if that look good? Thanks!

LGTM after add env variable clarification, and squash the commits into one. Thanks!

@xiang90 sorry, squashing was messaged up so I had to push few times to fix it but I hope it looks good now. Thanks!

Thanks. Will merge when CI is green. Merry Christmas.
On Sun, Dec 24, 2017 at 9:08 PM Sahdev Zala<EMAIL_ADDRESS>wrote:

@xiang90 https://github.com/xiang90 sorry, squashing was messaged up so
I had to push few times to fix it but I hope it looks good now. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/coreos/etcd/pull/9066#issuecomment-353815399, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AERby0oOTniIYcw7PwA13AN2Utu2PBBnks5tDwODgaJpZM4RMAKL
.

@xiang90 thanks!! Merry Christmas.


[Event request] codeunit 408 DimensionManagement procedure GetDefaultDimID

Hi,
we need additional parameter on event OnGetDefaultDimIDOnBeforeTempDimSetEntryInsert , SourceCode.:

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


remove facebook ads from generator

I don't have yarn installed... yet the generator always complains about it. Encouraging users to install the product to make the generator happy.
ray ~/git/third_party/lmao2$ yo feathers
/bin/sh: yarn: command not found
? Project name (lmao2)

Closed in the next release of @feathersjs/cli via #295


Update migrations

closes #49

edited the original migrations for the changes, commented out the update migrations but left in place


overzealous item-marker escaping when rendering to commonmark

I'm using cmarkit to generate and format markdown content using the cmarkit_commonmark module.  I've noticed that it adds a lot of unnecessary escape characters which can hurt readability.
let%expect_test "Issue: Escape unnecessary because it's immediately followed by non-whitespace" =
  roundtrip {|3.14 is pi|};
  [%expect {| 3\.14 is pi |}]
;;

let%expect_test "Issue: Escape unnecessary because it doesn't start a line." =
  roundtrip {|pi is 3.14|};
  [%expect {| pi is 3\.14 |}]
;;

let%expect_test "Issue: Escape unnecessary because it doesn't start a line." =
  roundtrip {|pi is approximately 3.|};
  [%expect {| pi is approximately 3\. |}]
;;

let%expect_test "GOOD! The escape is necessary to prevent being parsed as an ordered list" =
  roundtrip {|3\. is approximately pi|};
  [%expect {| 3\. is approximately pi |}]
;;

This patch addresses tests 1 and 2, but does not address test 3.  For that, I think that the renderer might need to scan back into the buffer to see if there's any non-whitespace preceeding the nearest newline.
diff --git a/src/cmarkit_commonmark.ml b/src/cmarkit_commonmark.ml
--- a/src/cmarkit_commonmark.ml
+++ b/src/cmarkit_commonmark.ml
@@ -71,11 +71,16 @@ let buffer_add_escaped_text b s =
   let esc_tilde s max prev next =
     not (Char.equal prev '~') && next <= max && s.[next] = '~'
   in
-  let esc_item_marker s i =
-    if i = 0 || i > 9 (* marker has from 1-9 digits *) then false else
-    let k = ref (i - 1) in
-    while !k >= 0 && Cmarkit_base.Ascii.is_digit s.[!k] do decr k done;
-    !k < 0
+  let esc_item_marker s i max =
+    let after_marker_is_whitespace =
+      if i + 1 >= max then true
+      else Cmarkit_base.Ascii.is_white (s.[i + 1])
+    in
+    after_marker_is_whitespace && (
+      if i = 0 || i > 9 (* marker has from 1-9 digits *) then false else
+      let k = ref (i - 1) in
+      while !k >= 0 && Cmarkit_base.Ascii.is_digit s.[!k] do decr k done;
+      !k < 0)
   in
   let flush b max start i =
     if start <= max then Buffer.add_substring b s start (i - start)
@@ -95,7 +100,7 @@ let buffer_add_escaped_text b s =
         flush b max start i; buffer_add_bslash_esc b c; loop b s max next c next
     | '!' when i = max ->
         flush b max start i; buffer_add_bslash_esc b c; loop b s max next c next
-    | '.' | ')' when esc_item_marker s i ->
+    | '.' | ')' when esc_item_marker s i max ->
         flush b max start i; buffer_add_bslash_esc b c; loop b s max next c next
     | '\\' | '<' | '>' | '[' | ']' | '*' | '_' | '$' | '|' ->
         flush b max start i; buffer_add_bslash_esc b c; loop b s max next c next

Indeed this was recently tweaked in https://github.com/dbuenzli/cmarkit/commit/90fb75ed20a8dae7dd859b41dcd14e368489cc09, a bit carelessly it seems.
However I don't think your patch handles correctly the escape to prevent an ordered empty list item to be created at the beginning of a line.

Oh interesting; I didn't know about that parsing behavior!  I'll admit I'm not super familiar with the cmarkit codebase yet; do you have an intuition for how best to solve this issue without regressing this case?

I'd need to put back this in my head.
But that's the third case for list items. However this cannot happen in the middle of a paragraph (scroll one line up for the sentence). So we'd need only to make sure this doesn't happen only at the start of paragraph text. Basically we have one overeager escape here:
printf "1\\.\nWe need an escape here but not here\n1." | cmarkit commonmark
1\.
We need an escape here but not here
1\.

I think there is state in the rendering context that tracks this but the context is not available in this function, so maybe we'd need to trickle down the context there if we wanted to solve that case correctly.


#478 Improve the reliability of squbs test executions on travis (#482)

Thanks for your pull request.  Please review the following guidelines.

[ ] Title includes issue id.
[ ] Description of the change added.
[ ] Commits are squashed.
[ ] Tests added.
[ ] Documentation added/updated.
[ ] Also please review CONTRIBUTING.md.

Cherry pick of d1ab813a765 for branch RELEASE-0.9.X


path.parse is not a function (0.2.1)

In the attached node-path-issue.zip. It does only one thing:
import path from 'path'
console.log(path.parse('/home/user/dir/file.txt'))

using jspm run test.js would prompt the error:
err  (SystemJS) path.parse is not a function
        TypeError: path.parse is not a function
            at execute (/Users/yunjia/Dev/jspm-playground/node-path-issue/test.js!transp
iled:11:24)
        Error loading /Users/yunjia/Dev/jspm-playground/node-path-issue/test.js

A little inspection, I tried to use an earlier version of nodelibs-path, 0.1.0. (I had to jspm uninstall path, manually put "path"<EMAIL_ADDRESS>in the package.json dependencies, and run jspm install again).
No error happened.
My wild guess is v0.2.1 loaded an earlier version of path? Since not only parse(), but other functions are also missing.

Yes version 0.2.0 is only meant to run in jspm 0.17 and above. I've removed the tag so you shouldn't get this version on jspm install path in jspm 0.16 anymore.


TraceEvent doesn't support loading symbols on Linux

A call to Microsoft.Diagnostics.Tracing.Etlx.TraceCodeAddresses.GetSourceLine on Linux will cause the following exception:

System.DllNotFoundException:` Unable to load shared library 'kernel32.dll' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable: libkernel32.dll: cannot open shared object file: No such file or directory

call stack:

Microsoft.Diagnostics.Tracing.TraceEvent.dll!NativeDlls.LoadLibraryEx(String lpFileName, IntPtr hReservedNull, LoadLibraryFlags dwFlags)
Microsoft.Diagnostics.Tracing.TraceEvent.dll!NativeDlls.LoadNative(string simpleName)	C#
Microsoft.Diagnostics.Tracing.TraceEvent.dll!Dia2Lib.DiaLoader.GetDiaSourceObject()	C#
Microsoft.Diagnostics.Tracing.TraceEvent.dll!Microsoft.Diagnostics.Symbols.NativeSymbolModule.NativeSymbolModule(Microsoft.Diagnostics.Symbols.SymbolReader reader, string pdbFilePath, System.Action<Dia2Lib.IDiaDataSource3> loadData)	C#
Microsoft.Diagnostics.Tracing.TraceEvent.dll!Microsoft.Diagnostics.Symbols.SymbolReader.OpenSymbolFile(string pdbFilePath)	C#
Microsoft.Diagnostics.Tracing.TraceEvent.dll!Microsoft.Diagnostics.Tracing.Etlx.TraceCodeAddresses.OpenPdbForModuleFile(Microsoft.Diagnostics.Symbols.SymbolReader symReader, Microsoft.Diagnostics.Tracing.Etlx.TraceModuleFile moduleFile)	C#
Microsoft.Diagnostics.Tracing.TraceEvent.dll!Microsoft.Diagnostics.Tracing.Etlx.TraceCodeAddresses.GetSourceLine(Microsoft.Diagnostics.Symbols.SymbolReader reader, Microsoft.Diagnostics.Tracing.Etlx.CodeAddressIndex codeAddressIndex)	C#

Can the TraceEvent library add support for symbols on linux? Probably that will only include portable pdbs.

TBH, I didn't realize we were close to getting TraceEvent working on Linux.
In this case, I think it's as straightforward as adding:
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
   ...
}

at the appropriate place in SymbolReader.cs (Microsoft.Diagnostics.Symbols.SymbolReader.OpenSymbolFile)

I don't know if it's true for all other features, but the symbols loading was the only issue I encountered when trying to process a trace.


Document fairness properties

Traits such as race and merge produce a single output from multiple inputs. These traits provide fairness properties which should be documented at the trait implementation level, but also on the Race and Merge traits themselves.

I think this is a great idea because there are a few ways we could define fairness and I think it's worth declaring which one we mean and plan to uphold.
Here are a few questions I think would be good to answer:
How do we measure fairness?
Here are some possibilities:

We try to poll each future the same number of times.
We try to spend the same amount of time executing each future.
We want each future to have an equal chance of completing.

I think 3 is probably not what we want. For example, if you do (file.read(), timeout(45)).race(), you want the file.read() future to be the one that completes 100% of the time. The timeout is basically just there to keep things from getting stuck.
Option 2 is probably not great either, since we may not always be running in an environment that has a clock. (Although I think basically any device that can run Rust code will have some way of tracking time.) Also, futures are probably IO bound, rather than CPU bound, so balancing execution time probably doesn't really matter since futures will spend very little time running compared to time spent waiting on IO.
Option 1 is the easiest to implement, but it may not be fair if the futures themselves are unbalanced in how much work each call to poll does.
What assumptions do we make about the behavior of futures?
Since we're doing cooperative multitasking and can't preempt futures, the behavior of the system depends a lot on the futures themselves.
I'd suggest we assume a future that does something like when polled executes for a small, random amount of time, then returns Ready or Pending with some probability. If it returns Pending, then after a random amount of time something will wake up the future.
How do we deal with futures that are Pending?
Say we had future a and b and we polled each of them once. Future a returns Pending and then doesn't wake up until we've polled future b ten times. At this point let's say both futures return Pending when polled but immediately wake up. Do we then poll a ten more times before giving b another chance to run, or do we do round-robin between them as long as they are both ready?

I'm sure there are more questions but these are a few I'm currently thinking about. Are there other things we need to consider?

Would you be open to having non-fair variants of combinators? For use-cases where ordering is important, it'd be great to have biased/prioritized versions (analogous to futures::select_biased!). I'm not sure what would make the most sense for such APIs, but I'd be happy to work on them if they'd be welcome

In our case I don't think it matters as much as with the macro variants. Because we reuse futures and streams, and employ perfect wakers in just about every instance, the difference between "fair" and "unfair" waking is really small.
We are of course biased towards being fair; but if you want to preserve ordering in a stream which is being processed concurrently, I don't think new operations specifically to do away with fairness are going to be of much benefit for your use.


Disable Xfce4 opening in window (PiP)

hronos@localhost / $ sudo edit-chroot -all
name: xenial
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/xenial...
WARNING: Unable to register core dump handler.
crouton: version 1-20200116214215~master:9017d640
release: xenial
architecture: amd64
xmethod: xiwi
targets: xiwi,xfce
host: version 12607.82.0 (Official Build) stable-channel caroline
kernel: Linux localhost 3.18.0-19838-gc647e70c954a #1 SMP PREEMPT Thu Jan 9 23:22:43 PST 2020 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...```

#### Please describe your issue:
I installed the crouton integration extension. Every time I boot "sudo startxfce4" it launched PiP but I actually prefer lanching to a more native version without picture in picture. How do I disable the default launch to PiP?

#### If known, describe the steps to reproduce the issue:

As said above everytime I launch I get PiP.

I have tried researching and trying some of the advice here https://github.com/dnschneid/crouton/issues/1276
I replaced with xiwi and xenial where made sense but no luck.

@Anthem22,
With the xiwi xmethod you can launch your desktop three different ways:

In a window (default): sudo startxfce4 -n xenial -X xiwi
In full screen mode:  sudo startxfce4 -n xenial -X xiwi-fullscreen
In a browser tab:  sudo startxfce4 -n xenial -X xiwi-tab

You can also just launch a Linux app without a desktop using something like:

In a window (default) sudo startxiwi -n xenial gnome-mahjongg
In full screen mode: sudo startxiwi -n xenial -F gnome-mahjongg
In a browser tab: sudo startxiwi -n xenial -T gnome-mahjongg

Hope this helps,
-DennisLfromGA

@DennisLfromGA -This is helpful but doesn't fully solve. When I first installed crouton I was able to switch between ChromeOS and Crouton as though they were separate OS. All of your suggestions are different versions of Linux within ChromeOS. When using CTRL+ALT+SHIFT+RIGHT ARROW I'd like it to have that native feel I once had.

@Anthem22,

All of your suggestions are different versions of Linux within ChromeOS.

Nope, all of those examples were for launching desktops and apps using the 'xiwi' xmethod, the Linux version doesn't change at all.

When using CTRL+ALT+SHIFT+RIGHT ARROW I'd like it to have that native feel I once had.

What you're describing is the 'xorg' xmethod, you can update your chroot and add it as the default xmethod with the following:

sudo crouton -n xenial -t xorg -u

Hope this helps,
-DennisLfromGA

@DennisLfromGA - At what point do I start paying you?! That did the trick. Thanks again.

@Anthem22,
If for some reason you need to force the 'xorg' xmethod just use it in a similar manner as the 'xiwi' examples I showed above with:

sudo startxfce4 -n xenial -X xorg

Hope this helps,
-DennisLfromGA


Link features, game levels, versions and tokens

The features in each level per game version are listed in this excel sheet
We merged @pydew-j's PR, a script that converts excel to json. Based on this script (i.e., the json), the features and levels should be linked and the different versions created.
What still needs to be implemented is a trigger for the different game versions. The trigger should come from the token for logging into the game. Tokens starting with 1 should trigger the first game version, tokens starting with 2 the second and tokens starting with 3 the third game version.

Hi @sloukit,
I have quite a list of questions regarding detailed implementation of this task. You can answer them gradually, since it's quite a lot, I'll need time to implement them one by one.

bathtub_signs

bathtub signs should not be visible at all, right?

sign_interaction

this means, the player should not be able to read the signs by pressing space, right?

notify_new_crop_text

00:15 means, that after 15 seconds into the new round (level), the player should receive a notification, right?
I assume, besides the message, the list of seeds the player possesses should be extended. The inventory should probably be extended by icons of new seed and crop, right?

playable_outgroup

the switch to outgroup menu should not be displayed at all, right?

healthbar

player's health decreases over time, and its body becomes transparent. Without healtbar visible, this might be confusing. Should health decrease logic stay untouched?

sickness

this refers to the player only and NPCs still can get sick, right?

statistics

this refers to the not yet implemented API calls to db, right?

government_character / government_statistics

there is no logic around government_character implemented yet, right?

resource_allocation_item_text

the player task menu after correct resource allocation by the player is not doing anything with the result of allocation. Gloves, boots, jeans, shirts, rain caps, and aprons have no graphical assets and are not shown in the inventory. Is this supposed to stay like that?

character_introduction_text

is this supposed to separate logic from the game intro scripted sequence with dialog?
Since character_introduction_timestamp == 0, this would need to be shown exactly at the same time as the intro.

self_assessment_menu

the self assessment menu is not doing anything with the information provided by the player. Is this supposed to stay like that?

minigame_rooting_npcs

what is this?

ingroup_introduction_text

is this the same thing as intro scripted sequence with dialog?

I think there are still side tasks that need to be done separately before this one can be completed:

the layout of round end menu is broken (overlapping elements) and needs to be fixed
additional seeds and crops are not added to enums
all debug shortcut keybindings need to be switched off
resources to be allocated (no assets)
simple notification menu
processing of self-assessment data

I'll probably start creating separate tasks for them to manage them more clearly.

Hi @sloukit,
I have quite a list of questions regarding detailed implementation of this task. You can answer them gradually, since it's quite a lot, I'll need time to implement them one by one.

bathtub_signs

bathtub signs should not be visible at all, right?
> Right, they should not be visible at all i.e., not be displayed on the maps.
2. sign_interaction
this means, the player should not be able to read the signs by pressing space, right?
> Right, the player should not be able to read the signs by pressing space.
3. notify_new_crop_text
00:15 means, that after 15 seconds into the new round (level), the player should receive a notification, right? I assume, besides the message, the list of seeds the player possesses should be extended. The inventory should probably be extended by icons of new seed and crop, right?
> Right: 00:15 means that the player will receive the notification 15 seconds into the new round. You have correctly added that the seed list and inventory must always be extended by the icons of the new crop.
4. playable_outgroup
the switch to outgroup menu should not be displayed at all, right?
_> Right, it is not possible to switch to the outgroup. Therefore, the player can walk around on the outgroups farm for > 1 minute and nothing happens.
5. healthbar
player's health decreases over time, and its body becomes transparent. Without healtbar visible, this might be confusing. Should health decrease logic stay untouched?
_> I'm sorry for the confusion here. For this study, we don't need any health logic at all: No health bar, no getting sick and dying, no bathhouse, no transparency or reduced walking speed. Everything related to the health system can be ignored for this study. The "health" of the player is not an issue at all, it remains untouched all the time.
6. sickness
this refers to the player only and NPCs still can get sick, right?
_> In the previous comment I described that there is no "health system" at all in this study, i.e., neither the player nor the NPCs can get sick at all (including no transparency, no reduced walking speed, and no dying). (We will only need this feature for the second study, which is not relevant right now).
7. statistics
this refers to the not yet implemented API calls to db, right?
_> No, this is another feature of the second study, which is not relevant at the moment. (Just to explain briefly: It has nothing to do with the API. The "statistics" are not real statistics, but simple graphs showing the effectiveness of wearing the goggles and taking the bath to avoid getting sick. We want to let the player know how effective they are and we're interested in how this might affect their behavior in the game)
8. government_character / government_statistics
there is no logic around government_character implemented yet, right?
_> Right, there is no government character at all
9. resource_allocation_item_text
the player task menu after correct resource allocation by the player is not doing anything with the result of allocation. Gloves, boots, jeans, shirts, rain caps, and aprons have no graphical assets and are not shown in the inventory. Is this supposed to stay like that?
_> Right, it is intended that there are no graphic assets for gloves, boots, jeans, shirts, raincoats, and aprons. They also don't need to be displayed in the inventory or anywhere else. As you rightly said, they will not reappear in the game. We just need to save the information (i.e., the number) about the amount of items that have been assigned to your group and to the other group in the db.
10. character_introduction_text
is this supposed to separate logic from the game intro scripted sequence with dialog? Since character_introduction_timestamp == 0, this would need to be shown exactly at the same time as the intro.
_> No, it should be done gradually, as it is now. First, the camera should zoom in on the main character, and then the "This is your character" box should appear.
11. self_assessment_menu
the self assessment menu is not doing anything with the information provided by the player. Is this supposed to stay like that?
_> Right, the information provided by the player is not relevant at all. It is the same as with the resource allocation task: In the game, the decisions are completely irrelevant, they are only stored in the db.
12. minigame_rooting_npcs
what is this?
_> I'm sorry for the lack of precision here. We have a feature where ingroup NPCs stand next to the fence during the mini-game and root for the player. We have the same thing for outgroup NPCs. However, in game version 3, we don't need the ingroup/outgroup NPCs next to the fence. In the mini-game f game version 3, there should only be the player and one outgroup NPC.
13. ingroup_introduction_text
is this the same thing as intro scripted sequence with dialog?
_> I'm not sure I understand your question. You mean that this sequence is linked to the intro_to_main_character sequence?

thank you - now I have much better understanding of the whole idea.

Task progress will be tracked in this comment
Steps

step name
status
remarks

connect to dummy backend
in progress ⌛
simple API for testing link

connect to final backend
todo 🚫
testing and fine-tuning

fix layout of menu_round_end
in progress ⌛
#247

add missing seeds and crops
in progress ⌛
#248

add notification menu
done ✅

fix Excel tool
done ✅
now it's loading all game versions, not one

Features

feature name
status
remarks

level_duration
done ✅

town_area
todo 🚫
is visible by default

farm_area
todo 🚫
is visible by default

forest_area
todo 🚫
is visible by default

path_signs
todo 🚫
is visible by default

bathtub_signs
todo 🚫

sign_interaction
todo 🚫

notify_new_crop_timestamp
done ✅

notify_new_crop_text
done ✅

round_end_screen
done ✅

crop_types_list
todo 🚫

playable_outgroup
todo 🚫

healthbar
todo 🚫

accessible_bathhouse
todo 🚫

sickness
todo 🚫

inventory_goggles
todo 🚫

volcanic_eruption
todo 🚫

statistics
todo 🚫
nothing to do in this phase

government_character
todo 🚫
nothing to do in this phase

inventory_tools
done ✅
nothing to do in this phase

inventory_crops
todo 🚫

inventory_harvest
todo 🚫

walking
done ✅
nothing to do in this phase

farming
done ✅
nothing to do in this phase

market
done ✅
nothing to do in this phase

emote_wheel
done ✅
nothing to do in this phase

government_statistics
done ✅
nothing to do in this phase

resource_allocation_timestamp
todo 🚫

resource_allocation_text
todo 🚫

resource_allocation_item_text
todo 🚫

character_introduction_timestamp
todo 🚫

character_introduction_text
todo 🚫

self_assessment_timestamp
in progress ⌛

self_assessment_menu
in progress ⌛

minigame
done ✅
nothing to do in this phase

minigame_rooting_npcs
todo 🚫

ingroup_introduction_timestamp
todo 🚫

ingroup_introduction_text
todo 🚫

player_hat_sequence_timestamp
todo 🚫

player_hat_sequence
todo 🚫

ingroup_necklace_sequence_timestamp
todo 🚫

ingroup_necklace_sequence
todo 🚫

player_necklace_sequence_timestamp
todo 🚫

player_necklace_sequence
todo 🚫

player_birthday_sequence_timestamp
todo 🚫

player_birthday_sequence
todo 🚫

group_market_passive_player_sequence_timestamp
todo 🚫

group_market_passive_player_sequence
todo 🚫

group_market_active_player_sequence_timestamp
todo 🚫

group_market_active_player_sequence
todo 🚫

ingroup_40p_hat_necklace_appearance
todo 🚫

outgroup_npcs_identical_appearance
done ✅
nothing to do in this phase

Demo
In this recording, 123 token is used, which selects game version v1 (first tab from Excel). All settings are loaded from rounds_config.json, and all events (self assessment, resource allocation, etc.) are triggered automatically - the timestamps are adjusted to make it shorter.
In round (level) 1 you can see:

character_introduction_text and ingroup_introduction_text as a part of intro animation
resource_allocation_text, resource_allocation_timestamp and resource_allocation_item_text
self_assessment_timestamp and self_assessment_menu - twice as in source Excel

In round (level) 2 you can see:

notify_new_crop_timestamp and notify_new_crop_text
ingroup_necklace_sequence_timestamp and ingroup_necklace_sequence
self_assessment_timestamp and self_assessment_menu - first time
resource_allocation_text, resource_allocation_timestamp and resource_allocation_item_text
player_hat_sequence_timestamp, player_hat_sequence
self_assessment_timestamp and self_assessment_menu - second time

Resource allocation data is send through API with following payload:
{
    "resource_allocation": {
        "allocation_item": "pairs of boots",
        "max_allocation": 2,
        "allocations": [
            2,
            0
        ]
    },
    "game_version": 1,
    "game_round": 2,
    "round_timer": 13.01
}

Self assessment data is send through API with following payload:
{
    "self_assessment": {
        "VALENCE": 2,
        "AROUSAL": 4,
        "DOMINANCE": 3
    },
    "game_version": 1,
    "game_round": 2,
    "round_timer": 9.0
}

Issues
There are some issues:

some text labels are still hardcoded with english text

menu_round_end looks bad - there is a separate ticket for that: #247

intro + character_introduction_text + ingroup_introduction_text: I'm still not sure how it should work. At the moment both messages are one dynamically created dialog with 2 sentences. The problem with that solution is that there is no control when the second sentence (ingroup_introduction_text) will be displayed - it all depends on when player presses SPACE key. Player can press is to early (when the camera is still at the start) or too late (when camera has already passed Ingroup area).
According to specification it should be after 10 seconds, but the scripted sequence logic (the camera animation) and dialog system do not have any way to communicate in the current implementation.
My understanding is that those messages should be displayed when the camera is showing the respectful area - not necessarily on the exact point of time (e.g. 10 seconds).
I see potential solutions to this:

extend the scripted sequence logic to be able to communicate with dialog logic (not sure how har it will be)
split intro scripted sequence into 2 separate ones: character introduction and ingroup introduction

during the intro, the camera is showing Outgroup area - in game versions, where the outrgroup switching is not possible it might be confusing to show this area. Can I leave it like this?

@sloukit the feature ingroup_40p_hat_necklace_appearance (40% of ingroup NPCs wear a hat and a necklace; 60% wear only a hat) in v3(no group) is set to No - this means everyone has no hat and no necklace?

Yes, exactly: In version 3 of the game, no character wears a hat and necklace (neither NPCs nor player). All in-group characters, including the player, look like the original character from the Sprout Lands Asset Pack. Out-group NPCs look the same in all game versions (blue colour and a horn).

Demo
In this recording, 123 token is used, which selects game version v1 (first tab from Excel). All settings are loaded from rounds_config.json, and all events (self assessment, resource allocation, etc.) are triggered automatically - the timestamps are adjusted to make it shorter.
In round (level) 1 you can see:

character_introduction_text and ingroup_introduction_text as a part of intro animation
resource_allocation_text, resource_allocation_timestamp and resource_allocation_item_text
self_assessment_timestamp and self_assessment_menu - twice as in source Excel

In round (level) 2 you can see:

notify_new_crop_timestamp and notify_new_crop_text
ingroup_necklace_sequence_timestamp and ingroup_necklace_sequence
self_assessment_timestamp and self_assessment_menu - first time
resource_allocation_text, resource_allocation_timestamp and resource_allocation_item_text
player_hat_sequence_timestamp, player_hat_sequence
self_assessment_timestamp and self_assessment_menu - second time

Resource allocation data is send through API with following payload:
{
    "resource_allocation": {
        "allocation_item": "pairs of boots",
        "max_allocation": 2,
        "allocations": [
            2,
            0
        ]
    },
    "game_version": 1,
    "game_round": 2,
    "round_timer": 13.01
}

Self assessment data is send through API with following payload:
{
    "self_assessment": {
        "VALENCE": 2,
        "AROUSAL": 4,
        "DOMINANCE": 3
    },
    "game_version": 1,
    "game_round": 2,
    "round_timer": 9.0
}

Issues
There are some issues:

some text labels are still hardcoded with english text

menu_round_end looks bad - there is a separate ticket for that: Bug: the layout of menu_round_end is broken #247

intro + character_introduction_text + ingroup_introduction_text: I'm still not sure how it should work. At the moment both messages are one dynamically created dialog with 2 sentences. The problem with that solution is that there is no control when the second sentence (ingroup_introduction_text) will be displayed - it all depends on when player presses SPACE key. Player can press is to early (when the camera is still at the start) or too late (when camera has already passed Ingroup area).
According to specification it should be after 10 seconds, but the scripted sequence logic (the camera animation) and dialog system do not have any way to communicate in the current implementation.
My understanding is that those messages should be displayed when the camera is showing the respectful area - not necessarily on the exact point of time (e.g. 10 seconds).
I see potential solutions to this:

extend the scripted sequence logic to be able to communicate with dialog logic (not sure how har it will be)
split intro scripted sequence into 2 separate ones: character introduction and ingroup introduction

during the intro, the camera is showing Outgroup area - in game versions, where the outrgroup switching is not possible it might be confusing to show this area. Can I leave it like this?

Is there anything we need to discuss regarding this comment? Or did we cover everything on Tuesday?

@sloukit regarding your last question - all clear for now 👌

@sloukit in the tutorial sequence, in the last step it is expected that the player will switch to the outgroup. The tutorial won't end until the player belongs to Outgroup. I don't think it's a good idea, since this step is not reversible. In my opinion, it's sufficient that the player goes to the outgroup area and interacts with one of npc's (this is the second to last step of the tutorial).
For game versions where switching to outgroup is unavailable, I'll always skip this step of tutorial.

@sloukit in order for the crops names from Excel to match with game object names, the string Tomatos must be replaced with tomato in row 13 (crop_types_list) on all levels on all tabs.

@sloukit in the tutorial sequence, in the last step it is expected that the player will switch to the outgroup. The tutorial won't end until the player belongs to Outgroup. I don't think it's a good idea, since this step is not reversible. In my opinion, it's sufficient that the player goes to the outgroup area and interacts with one of npc's (this is the second to last step of the tutorial). For game versions where switching to outgroup is unavailable, I'll always skip this step of tutorial.

You're absolutely right, that was a mistake I made. Your suggestion is great - skip the "switch to outgroup" task in the turotial and have the player interact with an outgroup NPC.

@sloukit in order for the crops names from Excel to match with game object names, the string Tomatos must be replaced with tomato in row 13 (crop_types_list) on all levels on all tabs.

That's good. Have you implemented this yet?

@sloukit in order for the crops names from Excel to match with game object names, the string Tomatos must be replaced with tomato in row 13 (crop_types_list) on all levels on all tabs.

That's good. Have you implemented this yet?

The enums class has a lot of duplicated code and it was very time-consuming to add all crops. Now, I can display all of them. The more tricky part is to enable only some of crops depending on the game level. The enum class is not quite fit for that, but I don't have enough time to refactor all of it. I'll implement some kind of wrapper around it.


Undead portraits not automatically created

I've got two of every race, 1 male and 1 female, for some reason both male and female Undead characters do not have portraits automatically generated.

Hey there,
In game, undead players are categorized as being part of the "scourge" race (prolly a leftover from WC3 or to differentiate from undead mobs)
Usually, stpain put a workaround in the code in the form of if character.Race:lower() == "scourge" then race = "undead"; for them to be correctly categorized for Guildbook
Seems in this case that the workaround either failed or wasn't there


I can not open YouTube-dl on M1 MacBook Air

Checklist

[ ] I'm asking a question
[ ] I've looked through the README and FAQ for similar questions
[ ] I've searched the bugtracker for similar questions including closed ones

Question

WRITE QUESTION HERE
When I try to run YouTube-dl from the terminal on my M1 MacBook Air, I get the following message:
env: python: No such file or directory.
I have re-installed Python and can use it through the IDLE app.
I have followed suggestions to try:
sudo ln -s /usr/bin/python3 /usr/bin/python
This gives the message:
ln: /usr/bin/python: Operation not permitted

Review this SO thread https://stackoverflow.com/questions/36730549/cannot-create-a-symlink-inside-of-usr-bin-even-as-sudo.

Thanks for the suggestion. I did not have any luck though. I guess I'll stick to using YouTube-dl on my Linux laptop.

Use python3 -m youtube_dl, which you might simplify with alias youtube-dl='/usr/bin/python3 -m youtube_dl'.

dirkf, thanks again, but this didn't help me to run YouTube-dl.

How didn't it?
You have python3 (check by running python3 --version).
Install yt-dl using pip (it may be called pip3 for you) according to the instructions.
Then try python3 -m youtube_dl --version.
If you paste the terminal session for any of these that doesn't work, we might be able to help.

Thanks again, dirkf,
Here's the terminal session
python3 --version
Python 3.10.4
sudo -H pip install --upgrade youtube-dl
pip: command not found
python3 -m youtube-dl —version
/Library/Frameworks/Python.framework/Versions/3.10/bin/python3: No module named youtube-dl

Either

install pip from the package management.
use pip as a module:##System-wide:
sudo -H python3 -m pip install --upgrade youtube-dl

##User-only:
python3 -m pip install --upgrade --user youtube-dl

Thanks for your help, I feel like I am getting in over my head and I think I will give up trying to get YouTube-dl to work on my my M1 MacBook Air, since it works fine on my old MacBook Pro running Zorin OS.

python3 -m ensurepip --upgrade


Fixed typo in README.md

Thanks for the library!
I came here from the Numpy 2.0 announcement and
saw this minor typo.

Thanks a lot! Merging right away.


Popper elements: Cross-axis in placement serves no purpose

🐛 Bug report
Currently, due to these lines in the popper package:
    const { hasAlign } = getPlacementDetails(placement)

    return compact({
      crossAxis: hasAlign ? opts.shift : undefined,

The crossAxis key that's accepted in positioning['placement'] serves no purpose. Instead, only the mainAxis is used, and for crossAxis you need to instead use the shift attribute, which is only useable with aligned items.
💥 Steps to reproduce

With a menu machine with the following options:
const [state, send, machine] = useMachine(
  zagMenu.machine({
    id: window.crypto.randomUUID(),
    positioning: 'bottom-end',
    offset: {
      mainAxis: 6,
      crossAxis: 6,
    },
  })
)

💻 Link to reproduction

I believe my explanation is sufficient to track down the issue, but let me know if you'd like a reproduction nonetheless, I'll be glad to provide one
🧐 Expected behavior
I expect the menu to be shifted in the crossAxis.
🧭 Possible Solution
I'd think the crossAxis should naturally work. Alternatively, placement should only accept mainAxis, or just accept a number, as a shorthand for mainAxis, and have JSDoc annotations to explain this pattern.
🌍 System information

Software
Version(s)

Zag Version
0.38.1

Browser
Chrome

Operating System
Mac

📝 Additional information

I just pushed a fix for this. We'll release an update shortly.
If the issue persists after upgrading, I'll re-open it.


otbr docker size is more 1.2gb when created using otbr-posix docker file

Build issue(s)
[Build] i am trying to create docker image for otbr using the dockerfile that is provided in otbr-posix repo but when i check the size of docker image after built is successful it is very big ~1.2gb.
Can anyone let me know how connectedhomeip is able to generate a docker image for otbr is of less size, which is available publically in dockerhub
https://hub.docker.com/layers/connectedhomeip/otbr/sve2/images/sha256-15b4105efba0f98134f57662d3d7680ad10380722c60bb6afa636fbb54014916?context=explore
Platform
raspi
Anything else?
No response

Closing older issues, trying to focus on current build failures


Update Grant-SPBusinessDataCatalogMetadataObject.md

Fixed example formatting.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sharepoint/sharepoint-ps/sharepoint-server/Grant-SPBusinessDataCatalogMetadataObject.md
:white_check_mark:Succeeded
View (sharepoint-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Installer Error:  The GET method is not supported for this route. Supported methods: POST.

When working thru the installer I get the following.
Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException
The GET method is not supported for this route. Supported methods: POST.
http://phpvms.pg.id.au/install/envsetup
I've tried this with both Apache2 and Nginx (to eliminate Nginx sometimes rewriting Post as Get). Used both the last release branch, and a git clone. Looking to see if anyone has any suggestions on how I can get thru the installer.
It fails just after I put in the mysql user/password.
If anything else is required please let me know.

Hmm that's strange. I haven't seen that before. Have you tried the latest dev?

if you mean latest code via a git clone, then yeah, same issue.

That page is a POST, after entering your DB info. Are you using fastcgi or something? Lemme see if I can do a fresh install today

method for git clone was
git clone https://branch.url
cd /path/install
composer install
then fired up the URL in a browser. Used the examples listed on the installation docos to knock up both nginx and apache vhosts.
Tried nginx/fastcgi with both the last release & dev
Tried apache/mod-php with last release.
All exhibited the same issue when I got to the step after you put in database details.

Oh wait. I just discovered the issue.  It must be something in the nginx reverse proxy I use for external access (The joys of having numerous sites on numerous boxes at home). Testing with internal IP worked. I'll play with it some. If I find the solution, I'll put it in here for continuity sake, in case anyone else strikes it.

Sounds good, thanks! And no worries, I know that kinda fun in debugging that 😀


Add support for marc21 to oai_xml driver

One collection provider, CSIC, only supports the marc21 metadataPrefix. Include marc21 in the metadataPrefix options here: https://github.com/sul-dlss/dlme-airflow/blob/main/dlme_airflow/drivers/oai_xml.py#L77
See: https://eu.alma.exlibrisgroup.com/view/oai/34CSIC_INST/request?verb=ListRecords&set=manuscripta&metadataPrefix=mods results in:
...
<error code="noRecordsMatch">No Publishing profile exists for given set and metadataPrefix</error>
...

While: https://eu.alma.exlibrisgroup.com/view/oai/34CSIC_INST/request?verb=ListRecords&set=manuscripta&metadataPrefix=marc21 results in data.

@aaron-collier I noticed this was in Ready and was wondering if you are still working on this, or do you want me to pick it up?

@edsu apologies, zenhub drag and drop is acting weird for me, this should not be in ready. If I don't make much progress this afternoon I may kick it back, but it's only effecting a single provider (CSIC) for now, so it's not as much a priority as other ready column tickets. Thanks :-)

@edsu I'm going to kick this one back for now, with a comment on the branch I have. I'm having trouble getting any data out from the Xpath, but there is clearly a record being loaded in the test.
I'm happy to continue this work, but want to kick it back to READY in case you feel like it something you can make headway on.
Also, I'm wondering if pymarc or another tool may be required here at some point:
Branch:
https://github.com/sul-dlss/dlme-airflow/compare/202-oai-marc-21?expand=1


Merging develop to main

Initially worked off main branch. Which is incorrect, upon realising mistake, the develop branch was created off current main work. Completed work on develop branch to now be merged

Merged develop on to main


Type boolean not working correctly?

Whenever I'm adding a field of type boolean, it is getting rendered as a checkbox, but the data is not updated correctly on my model.

Hi:
The same problem occurs when I use the v2.0.0-alpha1 version.
Finally, I did not have this problem with v1.1.0.

This project has been moved to https://gitlab.com/formschema/native


to decrease build time, sources should be in separate src/ folder

The derive.cabal spec contains executable and library. When cabal install, (most) library files are recompiled. This wastes time.
The executable should depend on the library, then recompilation is avoided.
This only works when the sources are in a separate directory.
(I don't know why, and I think this is seriously underdocumented, but I know it from experience.)
It is a trivial change to make, I can do it.

Go for it. Although given your other large pending change, I suggest you either wait til after that, or do this change first then merge into that one.

I saw your changes and liked them, so merged them all over - so this is now fixed. Thanks!


Update dominoes.md

https://github.com/exercism/xrust/issues/82#issuecomment-194556684

This looks good to me. Would you squash the commits, please, @masters3d?

i broke this. i'll create a new PR

Oh, wow, that's kind of epic, actually :) :heart:


Strange Issue with Capacitor and Baubles Stuff in Botania

please see https://github.com/Vazkii/Botania/issues/1757 for details and logs
ignore the closed state it just happened without festcraft so false positive
something odd is happening when opening the capacitor inventory
botania bauble check is beeing fired from the entwork thread with an very odd error

What is the status on this?

Status is "waiting for Azanor". As of now, (and #3164 applied) I see nothing wrong in our implementation, it seems this is part of Baubles' not quite rock-solid implementation.

Botania released 249 testing this evening if my crash persists


first_visit and session_start when sending events to GA4.

Hi there, at my work we've been trying to use this Client to receive events in GTM SS and send events to GA4 through a Tag.
I've found that some of the reports end up broken because of a few parameters collected by the GA4 Client which are not calculated or shown in the Snowplow Client. Mainly the ones that makes metrics which regard the first session or the first visit of the user.
In a GA4 Client when a new session is set the "ss" is set to 1 which triggers a "session_start" event and when a new client_id is set then "fv" is set to 1 which triggers a "first_visit" event. Don't mind the "dbg" parameter which means debug.

"x-ga-system-properties" currently does not exist in events coming from a Snowplow Client, could it be added?
Thanks, looking forward to your reply. :)

Hi @emilianorios1 and thank you for raising the issue! It sounds as something useful to implement!
Can you please help me fully understand what is required, possibly with an example of a simple Snowplow user journey and the desired outcome?
At this point the first thing that comes to mind is using the Snowplow client_session context entity. If this information is available/attached on the event then:
Example 1:
User A visits page A for the first time. This triggers a Snowplow page-view event. Then we can possibly map:

ss to sessionIndex, which in this case will be 1
fv to eventIndex (or sessionIndex), which will also be 1 in this case

Example 2:
User A visits page A for the second time on same session. This triggers a Snowplow page-view event. Then we can map:

ss to sessionIndex, which will again be 1 ? or should it be something else denoting not-a-session-start?
fv to eventIndex (which will be > 1)? or should it be 0 in this case, denoting not-a-first-visit ?

Example 3:
User A visits page A for the first time on next session. This triggers a Snowplow page-view event. Then we can map:

ss to sessionIndex, which will be 2 - would this be fine?
fv to ?? does this count as a first-visit?

You mentioned about fv:

when a new client_id is set

When this happens? How that works for GA? When is a new client_id being set?

Also, what about the session_start and first_visit events? From Snowplow side we are having a page-view event.
Would it be enough to populate those parameters without actually triggering/firing those events?
What do you have in mind?

session_start and first_visit are events received by GA4 which populate the reports regarding a users first traffic channel or the landing page path in a session.
Every time a user triggers the first page view of a session a session_start will be sent which is triggered by having the ss="1". If that session happened to be the first then fv="1" will also be set.
Regarding your examples I'll answer:
Example 1:

ss = 1
fv = 1

Example 2:

ss and fv will not be sent nor be in the parameters

Example 3:

ss=1
fv will not be sent nor be in the parameters

Regarding when client_id is set:
Basically when a user clears the cookis or it expires, although I'm not sure if it expires like your cookie.
session_start and first_visit can only be triggered by populating these parameters in a page_view.
Me and my team we tried to find a way but weren't able to find a way to confirm if a page_view is a first_visist.
Also, something else we found was that events should have a c=1 in x-ga-system_properties to actually trigger a conversion, which was also bugging us as to why they were not triggered.
Nonetheless, this leds me to think if this is really an issue in your client or if this is an issue in the GA4 Tag, because we were sold on GTM Server Side on the ability to use any Client to populate GA4 data but this has not been really possible because of all these limitations imposed by Google.
Anyways, sorry I wrote this in a rush let me know if you found this helpful or any other doubts and sorry for grammar errors.
Regards

Hey @emilianorios1 ! Since resolving this issue is quite open-ended, it may be better to be handled either through GTM-SS transformations or through the new merging features we just added to the (just released) v0.6.0. Closing this for now, please feel free to reopen if needed!


Update AV3ManagerWindow.cs

Just for Rigister Undo

Currently the manager is undergoing a complete ui rework that will use UIElements (probably going to push it in the next week or 2), so this change in the current ui would not last long. I'll check if in the new ui the undo has been added already or not.


Writing tests for problem classes

For v6 of pySDC all problem classes should be tested in a wide range. For those implementing different variants of the problem such as IMEX or fully_implicit it does make sense to test something like

does the right-hand sides of the problems match?
does the number of calls of eval_f match?

as it is already realised here (written by @brownbaerchen). In general, it also does make sense to do one time step for testing solve_system, testing the output error and compare it with a threshold.
However, there are many classes also using some problem dependent tricks, computations, etc. that have to be tested individually. For instance, allencahn_front_finel implemented here uses Finel's trick to rewrite the right-hand side (a more detailed information about the rewriting can be found in the documentation of the class). For this problem, no meaningful test for eval_f is found yet, and has to be added.

[ ] Writing a test for eval_f in allencahn_front_finel

For the other problem classes:

[ ] Problem-specific tests have to be considered

This entry can be supplemented at any time with ideas for problem-specific tests.

These things are difficult to verify and maybe it's not worth getting lost in these tests. If you compare different variants of the same problem in a publication, for instance, you can compute the error wrt the same reference solution to make sure that the comparison makes sense. This you have to do anyway, in my opinion, because you have to somehow make sure you are solving to the same accuracy in order to compare sensible things.
If you do implement such tests, that is of course awesome. But it should not be too high on your list of priorities.
Also, you don't need to test the number of right hand side evaluations. This is just an issue of the sweeper. I.e. you don't want to make more evaluations than necessary. But the problem class does not know what is necessary and hence should worry about it.
By the way, I like the issues. But I think you can open them in the main repo in the future. These issues apply also there after all ;)


Can not find 'example_scenes.py' when running example on Windows 10

I spent about a full day trying to get manim to work. First I had issues with python 3.8, hence I uninstalled and now run 3.7. Then I ran into problems with cairo, but made it work.
Finally I succeeded in installing manimlib, so I thought I made it.
If I run the following in the prompt, now from the python folder, it seems that manim is not correctly detected:
C:\Users\steve\AppData\Local\Programs\Python\Python37-32>python -m manim example_scenes.py -pl
C:\Users\steve\AppData\Local\Programs\Python\Python37-32\python.exe: No module named manim

But when I give the following command, it does seem to do something:
python C:\Users\steve\OneDrive\Documenten\Nerds\Manim\manim\manim.py example_scenes.py SquareToCircle -pl from my python 3.7 folder.
I get the following error:
Traceback (most recent call last):
  File "C:\Users\steve\OneDrive\Documenten\Nerds\Manim\manim\manim.py", line 5, in <module>
    manimlib.main()
  File "C:\Users\steve\OneDrive\Documenten\Nerds\Manim\manim\manimlib\__init__.py", line 11, in main
    config = manimlib.config.get_configuration(args)
  File "C:\Users\steve\OneDrive\Documenten\Nerds\Manim\manim\manimlib\config.py", line 185, in get_configuration
    module = get_module(args.file)
  File "C:\Users\steve\OneDrive\Documenten\Nerds\Manim\manim\manimlib\config.py", line 180, in get_module
    spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 724, in exec_module
  File "<frozen importlib._bootstrap_external>", line 859, in get_code
  File "<frozen importlib._bootstrap_external>", line 916, in get_data
FileNotFoundError: [Errno 2] No such file or directory: 'example_scenes.py'

example_scenes.py is in the main manim folder. I do not understand this error. Any help would be much appreciated.
The only thing I can think of that might be related, is the fact I could not install readlines by pip. This threw an error while installing manimlib. It gave an error that the module (being readlines) was not meant for windows. Therefore I installed pyreadline, but I never changed any code to for example use pyreadlines as readlines, since I did not find anything like that anywhere in the code.
PS: I am quite new to github. I try to adhere to all the rules and I searched extensively before asking this question, but I do not know what else to do.

I guess you probably have already watched it, but first I'd suggest this tutorial.
If you indeed have watched it and got this error, I believe you should wait a bit more to see if you can get some answers here to get it working, but from my experience, I've tried to use manim in Windows about a year ago and it was a terrible experience. I then changed to Ubuntu and finally got it working.
Unfortunately I don't know how to solve your problem, but if you get stuck for too long there, my suggestion would be to use a dualboot with Ubuntu and install it there. I believe it will be way smoother even though you might still face some issues.

Thanks for your reply. I will thoroughly watch that tutorial and see if it matches all the steps I took. I was not aware of that tutorial by the way.
I have no experience with dual boot or with ubuntu. You reckon it is worth the effort if the (at least for now) sole purpose of it is to get manim to work more easily?

I just did another run on the requirements install by (which I did multiple times before) running from my manim main folder:
py -m pip install -r requirements.txt
Note that I need to type py, if I use python or python3 it won't work. It then found that both scipy and numpy were from a higher than compatible version, hence it uninstalled those are installed the correct versions.  I then used the following command, again from the manim main folder:
py manim examples_scenes.py SquareToCircle -pl
Which worked. Thank god.


Herency

Is possible use classes that using herency? I use it to have a basic structure for every event and I add the necessary fields.
public class SyncDocumentIntegrationEvent : IntEvent
{
public int DocumentId { get; }
public int UserId { get; }
    public SyncDocumentIntegrationEvent(int documentId, int userId) : base()
    {
        DocumentId = documentId;
        UserId = userId;
    }
}

The document generated by asyncAPI is enormous and breaks the structure:
I'm doing something wrong?
Thanks for the help.

Would be fixed by #60

This is partially supported by using the [Discriminator] attribute
https://github.com/tehmantra/saunter/blob/291d2aa30fe054331106442bc8a4d9bc23bcdea3/test/Saunter.Tests/Generation/SchemaGeneration/SchemaGenerationTests.cs#L177
This issue will be closed in favor of #60


Make fibonacci example work

Use the pil compiler (and maybe in-line constant expressions) so that we can make the fibonacci example work using pilcom to verify the pil, committed polys and constant polys.

Implemented in https://github.com/chriseth/powdr/pull/28


Maximum length of path

I remember that in some cases when the path to the generated paramFile is longer than 128 characters, the computation would fail.
Would it be possible to increase this to 256?
Thanks!

can you point me out the source code of this?

This is actually a LaMEM limitation so has to be solved there.


fix date bug and improve coverage

Codecov Report

Merging #140 (8f79943) into main (f742e10) will increase coverage by 1.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   96.19%   97.52%   +1.33%
==========================================
  Files           5        5
  Lines         289      283       -6
==========================================
- Hits          278      276       -2
+ Misses         11        7       -4

Impacted Files
Coverage Δ

service/error_handlers.py
100.00% <ø> (+44.44%)
:arrow_up:

service/routes.py
98.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f742e10...8f79943. Read the comment docs.

IBM Cloud toolchain: Delivery Pipeline deployed promotions to dev, including commit 49bba5caaca04db5b6943db7dc653163f18c83c1


[SPARK-41111][CONNECT][PYTHON] Implement DataFrame.show

What changes were proposed in this pull request?
Implement DataFrame.show
Why are the changes needed?
api coverage
Does this PR introduce any user-facing change?
yes
How was this patch tested?
added ut

cc @HyukjinKwon @cloud-fan @amaliujia

thanks, merging to master!

thank you @HyukjinKwon @amaliujia @cloud-fan for the reviews


Remove escapeChar from DEFAULT_DIALECT

According to the CSV dialect specification, the escapeChar option should not be set by default.

escapeChar - specifies a one-character string to use for escaping (for example, \), mutually exclusive with quoteChar. Not set by default

Closes #200
Continued from #201

@dahlbaek
Sorry for the long wait. It looks good. Thanks for the work on the lib and the specs!


refactor(v2): stronger typing for blog plugin

Motivation
Fix typing, no logic change. So everything can autocomplete and blog plugin can meet our plugin types
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan

Locally no compile error
Build ok
Dev ok

Just waiting CI

I'm going to merge this out @lex111 , sorry but you'll have to merge the conflict in https://github.com/facebook/docusaurus/pull/2000 so that all TS error can be caught

Let's merge this PR and I will update #2000 from master branch, right?

Let's merge this PR and I will update #2000 from master branch, right?

yes


Docker clang

CMAKE + LLVM + CLANG

I think something like export CXX="clang++-10" CC="clang-10" works better than the cmake

@MatusKysel done

I see you add clang in Dockerfile. How to make sure Linux and Mac have same version in local?

@gaoqi8649 I guess we can find a way to do that but this wasn't the purpose of this pull request and having clang-format and clang-tidy be downloaded each time wasn't the way to go.


[8.x] Refactor component attribute bag

When using components, I realized that we can only merge attributes with the array
<div {{$attributes->merge(['class' => 'alert alert-'.$type])}}>

we cannot pass a collection
<div {{$attributes->merge(collection(['class' => 'alert alert-'.$type]))}}>

This PR is a refactoring of ComponentAttributeBag

Can you fix the conflicts?

@driesvints fixed

I don't really except blanket "refactoring" PRs. What are you improving specifically?

@taylorotwell
With this refactoring we can enjoy many benefits of the collection, not to mention that there is no duplication of code

// component.php
class Component extends \Illuminate\View\Component
{
    public function render()
    {
        // works
        $myAttrs = [];

        // not works
        $myAttrs = collection();

        return View::make('component', compact('myAttrs'));
    }
}

// component.blade.php
<span {!! $attributes->merge($myAttrs) !!}></span>

With this refactoring, how two implementations above would work.


Default theme (Neko Pure) unread count is black on black

Device information

Neko version: 2.6.0
Android phone & version: Pixel 4, 10

Steps to reproduce
Change the theme to light (Neko Pure); open the library navigation
Expected behavior
After opening the library navigation, unread count is black on black
Actual behavior
After opening the library navigation, unread count should be white on black
Other details
Tried with white and black OS' theme, but nothing changes. All other themes seems fine.

Show example

Dang I knew something theme wise would come up.. grey wolf has some minor issues also

Should be fixed in 2.7.0


Don't allow instant withdrawals if the daily limit it 0

Before this change, even if the daily limit was 0, token withdrawals
would by-pass the multi-sig capabilities of this wallet. While this
is still by-passed if there is a dailyLimit set, at least if it is 0
you require multi-sig as configured.

We have decided to go elsewhere for a true multi-sig wallet.


Supported languages revamp

JIRA 515
Asterisks now showing in both chrome and safari browsers and there is a consistent look to them.  If user selects a language that is partially supported or unsupported, a message shows up below the dropdown telling them what is specifically not supported.  This info is generated but a supportedLanguages.json file.  In the future we could use this for populating the preferred contact method as well.

@holmesie @DPC15038 I think I've addressed all your comments (with massive changes lol). tests might still fail but let me know how this looks

@holmesie @DPC15038 ready for another check!

@kylietmo I think I've addressed all your comments and answered your questions

@kylietmo I think I've addressed all your comments and answered your questions

Yep, all set on my end. Thank you!

@holmesie @DPC15038 This looks good to me now - any other thoughts before I merge?


Document how to install all dependencies on recent versions of Ubuntu

Other distros are also welcome

Usually installing the build-essential metapackage is enough to build most simple software, that gives you gcc/g++ and make.

I'm installing on ubuntu 18.04 and the command pip for installing platformio failed. It needed to be changed to pip3 since python3 is default on this distro. Could be handy to check for presence of pip vs pip3.


[Feature Request] Header search in file: Implementation of folding

As always thx for this wonderful plugin. By far my favorite search tool :)
I know about https://github.com/tadashi-aikawa/obsidian-another-quick-switcher/issues/42#issue-1228894898
So I assume it won't be doable for now but i'd like to leave a feature suggestion for the case that obsdian add folding states to the API.

Feature Request:
I'd like to suggest to implement folding into the "Header search in file" dialog. With Left / Right for folding and unfolding, a shortcut for (un-)folding all and with a bidirectional representation of folding states (headers in file and headers in "Header search in file" dialog mirroring each other.
It would be a great way to ease navigation in bigger files.

Thank you for your FR, @Glint-Eye :)


ulauncher: 5.9.0 -> 5.11.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for ulauncher is: "A fast application launcher for Linux, written in Python, using GTK"
meta.homepage for ulauncher is: "https://ulauncher.io/"
meta.changelog for ulauncher is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/wmcarq2barhrkjnvzzzmhwwn6f0daw2x-ulauncher-5.11.0/bin/ulauncher passed the binary check.

/nix/store/wmcarq2barhrkjnvzzzmhwwn6f0daw2x-ulauncher-5.11.0/bin/ulauncher-toggle passed the binary check.

/nix/store/wmcarq2barhrkjnvzzzmhwwn6f0daw2x-ulauncher-5.11.0/bin/.ulauncher-wrapped passed the binary check.

/nix/store/wmcarq2barhrkjnvzzzmhwwn6f0daw2x-ulauncher-5.11.0/bin/.ulauncher-toggle-wrapped passed the binary check.

/nix/store/wmcarq2barhrkjnvzzzmhwwn6f0daw2x-ulauncher-5.11.0/bin/..ulauncher-wrapped-wrapped passed the binary check.

0 of 5 passed binary check by having a zero exit code.

5 of 5 passed binary check by having the new version present in output.

found 5.11.0 with grep in /nix/store/wmcarq2barhrkjnvzzzmhwwn6f0daw2x-ulauncher-5.11.0

found 5.11.0 in filename of file in /nix/store/wmcarq2barhrkjnvzzzmhwwn6f0daw2x-ulauncher-5.11.0

directory tree listing: https://gist.github.com/64b8dba0c0717066e769ccc18547254c

du listing: https://gist.github.com/13bfed51371656fbbfc8002e9f52d506

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
ulauncher

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wmcarq2barhrkjnvzzzmhwwn6f0daw2x-ulauncher-5.11.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ulauncher https://github.com/r-ryantm/nixpkgs/archive/af17dca3e028446d06eb7e59fc5d34f594db4c34.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wmcarq2barhrkjnvzzzmhwwn6f0daw2x-ulauncher-5.11.0
ls -la /nix/store/wmcarq2barhrkjnvzzzmhwwn6f0daw2x-ulauncher-5.11.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

ulauncher

Maintainer pings
cc @aaronjanse for testing.

may no longer need libappindicator in dependencies https://aur.archlinux.org/cgit/aur.git/commit/?h=ulauncher&id=97c537776d84a81f0ec0d38ea7125ea29f084a06


Fixes Fetch error when debugging in Chrome

Fixes https://github.com/facebook/react-native/issues/6679
Test Plan:

reproduce #6679 locally

BTW, why don't we use fetch via node_modules instead of copy/pasting code?

cc @davidaurelio

An excellent change! Cheers to you, my friend!

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.


Colors and Font of How to play can be improved

Hello @YadavAkhileshh,
This issue is raised on a feature improvement
The How to play dropdown fonts and colors can be improved. And transition speed can be decreased for a good animation.
Kindly assign me this issue under Hacktoberfest 2024.

Kindly assign me this issue under Hacktoberfest and Hacktoberfest2024

I'm ready contribute. Please assign this to me under Hacktoberfest2024.

@MrSwapnilRahate, I am already working on this issue, please create new issue.

Hi @YadavAkhileshh as @kanduru-abhiram suggestions if you need any help then please create new issue under Hactoberfest2024 and assign it to me.


creates server with routes. Connects mongodb with mongoose. Creates c…

…lient with initial input forms


Add Virtual Measurements

Size -> Bytes, Megabytes, Gigabytes, etc.
Clock Speed -> Hertz, Megahertz, Gigahertz, etc.
Any others?

Bytes are in, working on hertz.


Improve text splitter

I'll move this over to alignment-research-dataset asap and switch sql to mysql and then update the pinecone dataset once and for all.


[Improvement] skip signing for non-public publishing

What would you like to be improved?
In the current publishing process, the content must be signed using the gradle signing plugin. While signing is not necessary for local use, conditionally skipping signing can help developers build and debug more easily with other systems. See this discuss for details.
How should we improve?
signing only when publishing to public repositories

@xiacongling
Will you continue working on this issue?


fix: make simplify_expressions use a single schema for resolution

Which issue does this PR close?
Closes #5996.
Rationale for this change
Fixing this will allow lots of expression simplification to succeed where it failed before.
In IOx we would like to be able to run the logical optimizer with skip_failed_rules set to false, since some of our custom rules are required to run and produce user-facing errors.
When I ran IOx tests with skip_failed_rules set to false, I found issue #5996.
What changes are included in this PR?
The issue is with the SimplifyExpressions logical rule. As it traverses the logical plan, it includes both the output schema for the current node and the merged input schema from the node's inputs.
The inclusion of two schemas causes an issue when various expression simplifiers inquire about attributes of expressions, e.g., here, which was the case for #5996:
https://github.com/apache/arrow-datafusion/blob/011adc203e4a02a822a8f0008852b90fb7441264/datafusion/optimizer/src/simplify_expressions/context.rs#L130-L139
This PR refines the schema used when simplifying to just the node's merged input schema. There is just one exception to using the child schema: for table scans with inlined predicates, those expressions need to be evaluated against the scan's output schema.
Are these changes tested?
I added unit tests for both the issue with power(f, 1) from the issue, and also for the case of an inlined table scan.
As a baseline I ran all the unit tests on main with skip_failed_rules set to false. I found just two failures:

sql::select::use_between_expression_in_select_query
sql::subqueries::support_limit_subquery

(Seems like there should be more, based on #4685? Maybe I am not running all of the tests)
When I run my branch wtih skip_failed_rules set to false. There was just one failure, which was already on main:

sql::subqueries::support_limit_subquery

So this PR also allows use_between_expression_in_select_query to pass when skipping failed rules. It was failing in a similar way as #5996.
I also ensured that the tests mentioned in #5208 (a recent bug fix that also touches on what schemas to use) all pass on my branch with skip_failed_rules set to false:

right_anti_filter_push_down
right_semi_with_alias_filter
csv_query_group_by_and_having_and_where (has inlined table predicate)

Are there any user-facing changes?
No.

cc @alamb (for when you get back from vacation)
@jackwener I am also interested in your thoughts on this PR since you worked on #5208.


Pick different port

Is there a way to specify a port different from 5000?

https://github.com/dgtlmoon/changedetection.io/blob/master/README.md   just change the 5000 to another port

FYI: one needs to change port not only for docker command, but also in changedetection.py

@nm2k that's completely and totally untrue
docker run -p "<IP_ADDRESS>:1234:5000" -v datastore-volume:/datastore --name changedetection.ioxx dgtlmoon/changedetection.io

Just change the first 5000 there to something else (1234), the second is for the mapping to the container.

It would be great to be able to change it via env var.


edits to the manual

In section 1.2 of the manual, included a brief description of object-oriented programming.
Included an example that describes how to import a module and use
functions.

This pull request has been manually incorporated into master in commit bbf60bd.  Couldn't do with git because it included a bad merge commit that Chris and I made last night, which has since been banished from history.


Add flash attention support for inference

Description
Flash-attention released an updates that optimize for inference. This PR adds the adaptation for speeding up inference with flash-attention.
Specifically, this PR includes:

Add flash attention patch for inference. Users can use flash attention in inference with inference_hf.py and gradio_demo.py by adding the --flash_attn parameter.
Add padding_mask in flash attention and xformers patches. This parameter was added in LlamaAttention.forward function in transformers v4.34.

Related Issue
Add padding_mask: #326

flash-attention and speculative sampling work correctly, but the inference speed is slow when enabling both CFG and speculative sampling. We should advise users not to use both CFG and speculative sampling simultaneously.


invalid escape sequence in documentation

If docstring contains \, python will report warning:

related SDK issue: https://github.com/Azure/azure-sdk-for-python/issues/35364

I have checked that adding r for docstring could fix the issue: https://github.com/Azure/azure-sdk-for-python/issues/35364#issuecomment-2081806529

@msyyc the issue if we switch everything over to raw strings is that strings we have escaped before (with \) will no longer be escaped. Can you go through our autorest code and see where we are currently escaping strings?

@iscai-msft I think it is reasonable for regex expression(e.g. \d) or windows path (e.g. C:\dev) in python class description. In such scenario, warning caused by python interpreter is fake warning and we shall avoid them. Currently autorest.python use """ by default in template (e.g. here), I think we could add logic that if docstring contains single slash \ then use r""" instead.
nit: I serach escape in autorest.python and find that current escape logic is not for docstring so the solution shall have no conflict


prepare repo for v0.4.0 release

add SPEC_LATEST_STABLE.md file
rename SPEC.md -> SPEC_WORKING_DRAFT.md
update readme to point to latest stable
add table with links to latest stable and working draft
of relevant docs

This PR prepares the spec for a v0.4.0 release. Once this PR is merged, I will create and push a v0.4.0 and cut a release.

/lgtm


Hostname at zabbix web interface is set to IP

Describe the bug

Hostname of the added server at zabbix web interface is set to IP, I need it to be a hostname, not IP, how do I do that please?
Installation method/version
ansible-playbook, .yml
Ansible Version
ansible 2.9.1
Targetted hosts
Concerns the following OS(es):

CentOS

Hi,
The following property is used zabbix_agent_hostname: {{ inventory_hostname }}. So it should use your hostname of what is used in your inventory file.