Please provide support for MySQL 5.6 and 5.7 on Debian

Hi Guys,
Could you implement support for MySQL 5.6 and 5.7 for Debian? Currently, when I use your cookbook I get:

MySQL 5.6:

[2015-02-06T11:05:42+01:00] ERROR: Unsupported Version: You requested to install a Mysql Server version that is not supported by your platform
[2015-02-06T11:05:42+01:00] ERROR: Platform: debian 7.8 - Request Mysql Server version: 5.6
[2015-02-06T11:05:42+01:00] ERROR: Availabe versions for your platform are: 5.5

    ================================================================================
    Error executing action `create` on resource 'mysql_service[default]'
    ================================================================================

    RuntimeError
    ------------
    Unsupported Mysql Server Version

    Cookbook Trace:
    ---------------
           /tmp/kitchen/cookbooks/mysql/libraries/helpers.rb:292:in `package_name_for'
           /tmp/kitchen/cookbooks/mysql/libraries/helpers.rb:328:in `server_package'
           /tmp/kitchen/cookbooks/mysql/libraries/helpers.rb:339:in `server_package_name'
           /tmp/kitchen/cookbooks/mysql/libraries/provider_mysql_service.rb:30:in `block in <class:MysqlService>'

MySQL 5.7:

[2015-02-06T11:09:19+01:00] ERROR: Unsupported Version: You requested to install a Mysql Server version that is not supported by your platform
[2015-02-06T11:09:19+01:00] ERROR: Platform: debian 7.8 - Request Mysql Server version: 5.7
[2015-02-06T11:09:19+01:00] ERROR: Availabe versions for your platform are: 5.5

    ================================================================================
    Error executing action `create` on resource 'mysql_service[default]'
    ================================================================================

    RuntimeError
    ------------
    Unsupported Mysql Server Version

    Cookbook Trace:
    ---------------
    /tmp/kitchen/cookbooks/mysql/libraries/helpers.rb:292:in `package_name_for'
    /tmp/kitchen/cookbooks/mysql/libraries/helpers.rb:328:in `server_package'
    /tmp/kitchen/cookbooks/mysql/libraries/helpers.rb:339:in `server_package_name'
    /tmp/kitchen/cookbooks/mysql/libraries/provider_mysql_service.rb:30:in `block in <class:MysqlService>'

What's the canonical way to get these packages on the debian family?

You should specify a different version, because 5.5 is the only version available
mysql_service 'default' do
  version '5.5'
  bind_address '<IP_ADDRESS>'
  port '3306'
  data_dir '/data'
  initial_root_password dbpassword
  action [:create, :start]
end

This gets really annoying every once in a while. I hope there will be a version of this cookbook which doesn't hardcode versions in such a strict way in the future. We also use the apt-repo from dotdeb, where mysql-5.6 and mysql-5.7 is available for debian7 and we always have to keep a fork (https://github.com/ffuenf/mysql/commit/3ebcfef3ebbec45bf05e7ebd12e9294f3187e4ff) to allow successful installation of the mysql-service.

Released in v6.0.18
On Tue, Mar 24, 2015 at 2:15 PM, Achim Rosenhagen<EMAIL_ADDRESS>wrote:

This gets really annoying every once in a while. I hope there will be a
version of this cookbook which doesn't hardcode versions in such a strict
way in the future. We also use the apt-repo from dotdeb, where mysql-5.6
and mysql-5.7 is available for debian7 and we always have to keep a fork (
ffuenf@3ebcfef
https://github.com/ffuenf/mysql/commit/3ebcfef3ebbec45bf05e7ebd12e9294f3187e4ff)
to allow successful installation of the mysql-service.
—
Reply to this email directly or view it on GitHub
https://github.com/chef-cookbooks/mysql/issues/291#issuecomment-85628590
.


Unable to set visibility for file

An exception has been thrown during the rendering of a template:
Unable to set visibility for file minified_javascript_core_fca972a47fddc27c98d276c1370ebabe.js. chmod(): Operation not permitted.

The error message suggests that the script is unable to set the visibility of the file because the operation is not permitted. This can happen when there is a permission issue with the file or directory where the file is located.
Here are some steps you can take to resolve this issue:

Check the permissions. Make sure that the user or group that the web server is running under has the necessary permissions to access and modify the file.

Try setting the permissions using the chmod command.

If you are using a shared hosting service, contact your hosting provider to check if there are any restrictions on modifying file permissions.


feat: parse slice to pubkey

Please explain why adding this public interface.

If we want to get the peerid information through the public key, the current API cannot complete this task


Tseries

TseriesBase class added, with additional attributes.
Stresses are checked for missing values and constant frequency. User
can define frequency and how to fill nan-values.

Should be a pull request into dev -- not master!


acdcloud

Hi,
I was just strolling through github for some inspiration for https://github.com/fbartels/mount-encfs-cloud and noticed you have a slightly modified version of my script in your repo. Just wanted to drop by and say "Hi" and notify that I also have added some more rclone switches to my script (upload and mount with rclone).
Greetings from Hanover to Hanover ;-)

Hey,
Thanks for your script, it's probably the best out there! Made my dive into ACD+encfs much more pleasant. Rclone support is very nice to have, because my initial reaction was to combine both of your scripts into a single one. Also noticed that I forgot proper attribution in my version, which you definitely deserve.
Though I have to admit that I'm now using pure rclone with its builtin encryption :)
Cheers! Currently chasing the last bits of summer in Las Palmas before returning to Hanover for christmas :)


Update .NET client API reference for 4.x

The rabbitmq .net client has bene updated to 4.1.3 (as of 2017-06-16), but the documentation link still goes to 3.6.10.
Target Page: https://www.rabbitmq.com/dotnet.html

Documentation guide is up-to-date. API reference isn't but there weren't any major API changes.
@kjnilsson did we settle on any JavaDoc-like tool to use in the future?

@michaelklishin There are actually some significant changes.
Example: BasicPublish only has one signature in 4.x, but there are 3 in 3.6.10.
https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/master/projects/client/RabbitMQ.Client/src/client/api/IModel.cs#L221
vs
https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/stable/projects/client/RabbitMQ.Client/src/client/api/IModel.cs#L255 to line 270

These (and more) are implemented as extension methods.
On Fri, 16 Jun 2017 at 21:08, ebelew<EMAIL_ADDRESS>wrote:

@michaelklishin https://github.com/michaelklishin There are actually
some significant changes.
Example: BasicPublish only has one signature in 4.x, but there are 3 in
3.6.10.
https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/master/projects/client/RabbitMQ.Client/src/client/api/IModel.cs#L221
vs
https://github.com/rabbitmq/rabbitmq-dotnet-client/blob/stable/projects/client/RabbitMQ.Client/src/client/api/IModel.cs#L255
to line 270
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rabbitmq/rabbitmq-website/issues/396#issuecomment-309122511,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABIDlJGUdNgUli4-Zg6ZuiDPHwW2_hfeks5sEuDJgaJpZM4N8ypQ
.


Installer Failed, GDK Build Failed, Runtime problem (All solved)

I just a newbie to SpatialOS, was following the instructions to setup the Spatial Environment and GDK (Unity). Then I encountered few problems as described below:
Description
Installer Failed
I followed the instructions to setup the environment for SpatialOS. Everything is fine at the beginning, but Unity crashed during the project loading (I have sent the report to Unity), then once I re-open the project again, it prompted “Can’t find the Spatial CLI and the donet dependency”, Therefore, I tried to re-installed the dependency.
But the SpatialOS Installer (mac.20180830.170931) failed this time, both in installer and terminal. I have done the screen shot for the mac installer but I did for the terminal
Screenshot of failure:

Possbile Solution
I manually install the CLI by brew and Launcher by SpatialOS.Launcher.mac.1.6.2.pkg separately, and it works this time.
Don’t know whether is a problem with the installer or my environment
Spatial functions missing in Unity and Failed to build the GDK for Unity
After setup the environment, I clone the project, and open it in Unity (2018.3.11f1),
I remove the project, retry the instructions, this problem still occurred 3 times. But I got things solved out at the 4th
Screenshots:

Possible Solution
I forgot to screenshot the log once the problem occurred, but I remember I have seen the log “Google storage API failed” (or something like this) once I use the “spatial diagnose” in terminal.
I think this because I’m using proxy (I’m in China), the internet connection to access Google API has been block by the firewall, therefore the installation process has failed.
I have change my proxy and internet setting to force all internet access to go though proxy, after that, the installation process has succeeded.
Sorry I forgot the keep the log file.
Deployment Launch Failed in Unity (Donet runtime failed) but able to deploy
I try launch the deployment after everything has done, but the deployment has failed due to donet runtime error. The SpatialOS Console has open in browser anyway before the error message display in Unity Log.
Two workers look like working properly in Spatial OS as the screenshot below, able to use the launcher to launch the game and play
Runtime Error

Logs:
my_deployment failed
Launch of my_deployment failed. Code: CannotParseOutput Message: Unable to parse the standard error. Raw standard error: Unhandled Exception: System.AggregateException: One or more errors occurred. (A task was canceled.) ---> System.Threading.Tasks.TaskCanceledException: A task was canceled.    --- End of inner exception stack trace --- at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) at Improbable.Gdk.DeploymentLauncher.Commands.Create.UploadSnapshot(SnapshotServiceClient client, String snapshotPath, String projectName, String deploymentName) in /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Commands/Create.cs:line 184 at Improbable.Gdk.DeploymentLauncher.Commands.Create.CreateDeploymentInternal[TOptions](TOptions options, Func2 getLaunchConfigJson) in /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Commands/Create.cs:line 49 at Improbable.Gdk.DeploymentLauncher.Commands.Create.CreateDeployment(Create options) in /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Commands/Create.cs:line 19 at Improbable.Gdk.DeploymentLauncher.Program.<>c.<Main>b__2_1(Create createOptions) in /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Program.cs:line 22 at Improbable.Gdk.DeploymentLauncher.Program.Main(String[] args) in /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Program.cs:line 17 UnityEngine.Debug:LogError(Object) Improbable.Gdk.DeploymentLauncher.DeploymentLauncherWindow:Update() (at /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/DeploymentLauncherWindow.cs:116) UnityEditor.EditorApplication:Internal_CallUpdateFunctions()
my_deployment_sim1 failed
Launch of my_deployment_sim1 failed. Code: UnknownGrpcError Message: Grpc.Core.RpcException: Status(StatusCode=ResourceExhausted, Detail="couldn't schedule deployment creation; Couldn't launch deployment because your project (beta_eight_cup_619) doesn't have enough quota for it. Quota required: (18). Quota left: (10). Quota is a limit on the compute resources that your SpatialOS project can use. Try stopping any other deployments you have running then launching this one again. If you need a higher quota, get in touch.")    at Grpc.Core.Internal.AsyncCall`2.UnaryCall(TRequest msg)    at Grpc.Core.DefaultCallInvoker.BlockingUnaryCall[TRequest,TResponse](Method`2 method, String host, CallOptions options, TRequest request)    at Grpc.Core.Internal.InterceptingCallInvoker.BlockingUnaryCall[TRequest,TResponse](Method`2 method, String host, CallOptions options, TRequest request)    at Improbable.SpatialOS.Deployment.V1Alpha1.DeploymentService.DeploymentServiceClient.CreateDeployment(CreateDeploymentRequest request, CallOptions options)    at Google.Api.Gax.Grpc.ApiCall.<>c__DisplayClass0_0`2.<Create>b__1(TRequest req, CallSettings cs) in C:\Users\jon\Test\Projects\gax-dotnet\releasebuild\src\Google.Api.Gax.Grpc\ApiCall.cs:line 27    at Google.Api.Gax.Grpc.ApiCallRetryExtensions.<>c__DisplayClass1_0`2.<WithRetry>b__0(TRequest request, CallSettings callSettings) in C:\Users\jon\Test\Projects\gax-dotnet\releasebuild\src\Google.Api.Gax.Grpc\ApiCallRetryExtensions.cs:line 79 at Improbable.SpatialOS.Deployment.V1Alpha1.DeploymentServiceClientImpl.CreateDeployment(CreateDeploymentRequest request, CallSettings callSettings) at Improbable.Gdk.DeploymentLauncher.Commands.Create.CreateDeploymentInternal[TOptions](TOptions options, Func`2 getLaunchConfigJson) in /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Commands/Create.cs:line 68 at Improbable.Gdk.DeploymentLauncher.Commands.Create.CreateSimulatedPlayerDeployment(CreateSimulated options) in /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Commands/Create.cs:line 24 at Improbable.Gdk.DeploymentLauncher.Program.<>c.<Main>b__2_0(CreateSimulated createOptions) in /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Program.cs:line 21 at Improbable.Gdk.DeploymentLauncher.Program.Main(String[] args) in /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/.DeploymentLauncher/Program.cs:line 17 UnityEngine.Debug:LogError(Object) Improbable.Gdk.DeploymentLauncher.DeploymentLauncherWindow:Update() (at /Users/CMY/Downloads/gdk-for-unity/workers/unity/Packages/com.improbable.gdk.deploymentlauncher/DeploymentLauncherWindow.cs:116) UnityEditor.EditorApplication:Internal_CallUpdateFunctions()
Screenshot for SpatialOS Console

Possible Solution
I reinstalled the donet runtime and update to 2.2.5 and the problem solved.
Think you should noice people the runtime version. As I use the 2.2.204 before.
Environment
System: macOS Mojave 10.14.5
Unity: 2018.3.11f1
Donet: Core 2.2 Runtime (v2.2.5)
Summary
I have finally got everything done, the game runs perfect. Just let you guys know the problem that I encountered during the setup 🙂

Hey @neaped thanks for the reports!
I think you are correct that some of those issues are related to your internet connection and VPN. I've passed on the installer failure to the relevant team and will open a ticket to look into the dotnet issues you were finding (UTY-2074)

Hi, @jamiebrynes7 , glad to be help.
Btw, got another problem with internet connection. As you use google api within the service, even use "Local Launch", the platform still need to connect to Google Service, therefore, the local launch will failed without the VPN. The "http://localhost:21000" wont work properly.
Think you should give a notice to some develop like me who has the internet restriction, recommend to use VPN (need to setup in terminal) within your tutorial, otherwise, it will failed to setup the project.
Or alternatively, once the Google Service connection failed, should prompt the message about the possible solution.


You are very big company making a huge push and not even testing

There are no such thing as                     "./assets/bach.mp3", anymore
So Gradio app fails to launch after your latest update
I am updating my tutorial github readme file for those who are interested in
Moreover I have 1 click auto installer : https://www.patreon.com/posts/ai-music-auto-84334460
Tutorial
Audiocraft / MusicGen - AMAZING Text-To-Music AI Model By Facebook | Tutorial | Better Than MusicLM

I had the same issue. The asset is still there in the assets folder. (https://github.com/facebookresearch/audiocraft/tree/main/assets)
Its just the way how the asset is referenced. Usually it is not a good idea to rely on the script being invoked from a specific path.
The following worked for me
python .\demos\musicgen_app.py

I had the same issue. The asset is still there in the assets folder. (https://github.com/facebookresearch/audiocraft/tree/main/assets)
Its just the way how the asset is referenced. Usually it is not a good idea to rely on the script being invoked from a specific path.
The following worked for me
python .\demos\musicgen_app.py

i see
this is definitely relative pathing problem


Adding package_data and data_files sections to setup.py

Should fix #673 and #674
cc @AlexCline

Coverage remained the same at 60.323% when pulling e83d3828cc3056e41303fd670792d0dde9f3dadf on issue_674_install_missing_files into 400e708cf5bd9aa135feb008af6d47c2e7c009d5 on develop.

@monkeysecurity, this did fix #674, but didn't fix #673. When I'm in the container running SM, I can see that the templates directory is now copied to /usr/local/lib/python2.7/dist-packages/security_monkey-0.9.0-py2.7.egg/security_monkey/, but running monkey amazon_accounts still returns the following error message because the data directory doesn't exist:
Traceback (most recent call last):
  File "/usr/local/bin/monkey", line 9, in <module>
    load_entry_point('security-monkey==0.9.0', 'console_scripts', 'monkey')()
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.0-py2.7.egg/security_monkey/manage.py", line 625, in main
    manager.run()
  File "/usr/local/lib/python2.7/dist-packages/Flask_Script-0.6.3-py2.7.egg/flask_script/__init__.py", line 397, in run
    result = self.handle(sys.argv[0], sys.argv[1:])
  File "/usr/local/lib/python2.7/dist-packages/Flask_Script-0.6.3-py2.7.egg/flask_script/__init__.py", line 376, in handle
    return handle(app, *positional_args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/Flask_Script-0.6.3-py2.7.egg/flask_script/commands.py", line 145, in handle
    return self.run(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.0-py2.7.egg/security_monkey/manage.py", line 152, in amazon_accounts
    data = json.load(open(data_file, 'r'))
IOError: [Errno 2] No such file or directory: '/usr/local/lib/python2.7/dist-packages/security_monkey-0.9.0-py2.7.egg/security_monkey/data/aws_accounts.json'

This is a low-priority issue at this point since amazon account changes will only happen during an upgrade.


DHCP support for ge-0/0/1.0 through ge-0/0/9.0

ge-0/0/0.0 supports only NAT / DHCP by default, for port forwarding
add DHCP support for ge-0/0/1.0 through ge-0/0/9.0

@RobWC :+1:


The same Dubbo service cannot be registered under multiple namespaces of one NACOS, but can be registered under different NACOS namespaces

Pre-check

[X] I am sure that all the content I provide is in English.

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component
Java SDK (apache/dubbo)
Descriptions
This is my configuration:
dubbo:
registries:
nacos1:
id: nacos-dubbo
address: nacos://<IP_ADDRESS>:8848?namespace=dubbo
register: true
username: nacos
password: nacos
nacos2:
id: nacos-plm
address: nacos://<IP_ADDRESS>:8848?namespace=plm
register: true
username: nacos
password: nacos
Related issues
No response
Are you willing to submit a pull request to fix on your own?

[X] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

My Dubbo version is 3.3.10

我试过 3.3.1、3.2.10 版本，都可以。你能提供一个可以重现这个问题的仓库地址吗？

I have tried 3.3.1, 3.2.10 versions and they all work. Can you provide a repository address where this problem can be reproduced?

Sorry, I read it wrong. My version is 3.1.10  Does this version have this issue？

我试过 3.3.1、3.2.10 版本，都可以。你能提供一个可以重现这个问题的仓库地址吗？

I have tried 3.3.1, 3.2.10 versions and they all work. Can you provide a repository address where this problem can be reproduced?

Sorry, I read it wrong. My version is 3.1.10 Does this version have this issue？

This problem does exist in versions below 3.2.x, but it is only resolved in versions above 3.2.x, please refer to this pr for details
https://github.com/apache/dubbo/pull/13439

我试过 3.3.1、3.2.10 版本，都可以。你能提供一个可以重现这个问题的仓库地址吗？

I have tried 3.3.1, 3.2.10 versions and they all work. Can you provide a repository address where this problem can be reproduced?

Sorry, I read it wrong. My version is 3.1.10 Does this version have this issue？

This problem does exist in versions below 3.2.x, but it is only resolved in versions above 3.2.x, please refer to this pr for details #12731 #12629

ok，thankyou


Toggleable clothing system refactor

About the PR

Toggleable clothing now can work with multiple clothings.
Toggleable clothing now have ui (if more than one attached clothing)
Toggleable clothing unequip now can be blocked if any attached clothing is equipped
Attached clothing now have option to replace already worn clothings keeping them in container

Why / Balance
Toggleable clothing is very limited with only one attached clothing whats not allow to make something more cool like modsuits.
Technical details
Most ToggleableClothingSystem methods were change to work with multiple attached clothings. ToggleableClothing component now have two Dictionaries instead of Slot, ClothingUid and Prototype fields. ContainerSlot was replaced with Container to contain multiple clothings.
AttachedClothingComponent got container for replaceable clothing.
I really need review to understand how to make everything of this better.
Media
(Atmos Hardsuit was changed just for tests)
https://github.com/user-attachments/assets/e0f8e423-6437-4117-a779-144f2c44698d
Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes
ToggleableClothingComponent was changed to work with multiple clothings so it require some changes in prototype. Also you need to change "toggleable-clothing" in ContainerManager (ContainerContainer) from ContainerSlot to Contaier.

Looks like a system for modsuits lol

Looks like a system for modsuits lol

Yes, i made it for modsuits. Also it can be used for clothing with toggleable hoods + capes or superhero suits.

Actually, i don't know why checks are failing, because making containers like this just won't affect the game :\

Actually, i don't know why checks are failing, because making containers like this just won't affect the game :\

Even if it doesn't break anything in this instance, we don't want to add components on spawn as a general design principle.
You'd need to add the containers in the YML for these entities. It could be done more easily/cleanly with parenting, so you could have one abstract BaseToggleableClothing entity with the containers, and the rest inherit from it.

Actually, i don't know why checks are failing, because making containers like this just won't affect the game :\

Even if it doesn't break anything in this instance, we don't want to add components on spawn as a general design principle.
You'd need to add the containers in the YML for these entities. It could be done more easily/cleanly with parenting, so you could have one abstract BaseToggleableClothing entity with the containers, and the rest inherit from it.

They already added in prototypes. That's way check fails.

If you try to create a prototype from example video, spawn it, reconnect, then the Client starts suffering a lot.
https://github.com/user-attachments/assets/6414a597-bcef-4b54-9a8e-31c721491114


Quality for image manipulation

Use the quality option for the stream function:
public Intervention\Image\Image stream([mixed $format, [int $quality]])
By default, we still have the default behavior (value of 90 for the image quality)
If you define a filter (see https://asgardcms.com/docs/v1/media-module/thumbnails#crop) you might set a different quality
Basic usage
return [
    'smallThumb' => [
        'quality' => 50,
        'crop' => [
            'width' => '100',
            'height' => '200'
        ],
        'blur' => [
            'amount' => '15'
        ],
    ]
];

As mentioned in the doc it's only for JPG

Define the quality of the encoded image optionally. Data ranging from 0 (poor quality, small file) to 100 (best quality, big file). Quality is only applied if you're encoding JPG format since PNG compression is lossless and does not affect image quality. Default: 90.

Also, could do with squashing the commits :)


Implementing copy and paste operators with system clipboard

Implemented operator's copy-and-paste functionality with system clipboard, allowing copying and pasting across different tabs and browsers, one exception being copying from another browser to firefox

This is not the right branch to be merged into. Closing this PR.


Can you add a button to the node?

HI,Your example is great.I hope that your component can achieve the click effect similar to neo4j graph database node, click the node can appear buttons, choose to show or hide the node relationship, want to know if you can add buttons in the outer layer of the node, can you give me some suggestions?   thanks.  @emiliorizzo

HI @birdle-joe, please look at this example: https://codepen.io/emilio/pen/xxKMMpY
I used the 'node-click' event to display the dialog, and node coordinates for the labels.

@emiliorizzo Thank you  for your reply,It has achieved the desired results.


"regime" needs to be an enumerated value with a defined domain

If there is indeed a wave of privacy legislation coming world-wide, as Gartner predicted, the possible values will quickly go into the dozens and maybe hundreds. Multinationals will need to know which law to apply to particular requests, so a defined list of possible values should be created. (Maybe this can wait until 5min before V1.0 is being released; so I think a placeholder is fine for now.)

Have to agree 100% here, we know that there are some big blind spots in how we model this. We're treating it as a placeholder right now since we're leaning on the CCPA's provisions right now.

In conversation with @dazzaji : the list of regimes and their implementation is ultimately something which is derived through regularly (monthly/quarterly) conversations with business + their GRC + legal teams to develop a "centralized" taxonomy which we can bake in to the protocol -- and perhaps other data rights tools.

I think the best word for this is "periodic" (rather than regular monthly or quarterly) communications among the participants, the cadence and method for which is really whatever is simplest and agreed among the organizations that are deploying the protocol together in the same trust network.  The cadence could just be as one of the agenda items on occasion sync up meetings just "as needed" or once it becomes routine, even asynchronously such as by updating a shared spreadsheet which gets curated and occasionally rolled into protocol updates.

IMHO ultimately it needs to be something like IANA: maintains a list of enumerated values.

Is it possible for more than one regime to apply to a single request? For example, if a user in California wants to opt out of sale (CCPA/CPRA) and object to processing (GDPR) by a company in Europe?


Length of title

Hey! I noticed that some titles I add get chopped:
root      3497  0.1  0.0<PHONE_NUMBER>8 ?        Ssl  19:46   0:00 buildkite-agent v2.1-beta.3 (buildkite-ci-10) [i

It should end with [idle]. Is there a limit to the length of the proc title?

It depends on the platform you are on. But in your case I guess the limit is the length of argv. It replaces this memory so it's a bit complex to give a specific limit.

Ah right, and I don't suppose there's a way to extend that limit?

The only way is to pass some very long arguments to your program. That way argv gets bigger.


Applying code action 'Sort imports' hangs indefinitely

Environment data

VS Code version: 1.47.3
Extension version (available under the Extensions sidebar): v2020.7.96456
OS and version: Ubuntu 20.04
Python version: 3.8.3 (installed by pyenv)
Type of virtual environment used: pyenv-virtualenv
Relevant/affected Python packages and their versions: XXX
Relevant/affected Python-related VS Code extensions and their versions: XXX
Value of the python.languageServer setting: doesn't seem to matter; I have tried Jedi, Microsoft, Pylance, and None
isort version: 4.3.21

Expected behaviour
When I hit save on a Python file, I expect it to quickly/automatically sort my imports
Actual behaviour
It pops up a box much like this one:

Saving 'main.py': Applying code action 'Sort imports'.

And that box never goes away. It hangs indefinitely. Obviously it never actually sorts my imports either, nor does it proceed to linting / auto-formatting. It just gets stuck.
Steps to reproduce:

pip install black pylint isort autoflake
Copy my settings.json file
Save a Python file

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

> ~/.pyenv/versions/myproject/bin/python ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/sortImports.py - --diff
cwd: ~/src/myproject/home
> ~/.pyenv/versions/myproject/bin/python ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.7.96456/pythonFiles/sortImports.py - --diff
cwd: ~/src/myproject/home

@soapergem this seem similar to #12949
I've been having these issues for a long time and they seem to be fixed on the insiders version.

Actually they are not solved on the insiders version. It intermittently stopped happening after I started using the insiders version, but I am still experiencing the problem.

I have been having this exact problem since the recent version. Starting a new session everything works fine. After some time, not sure exactly what happens to trigger it or exact time frame, but at some point I try to save and all I get is a spinning circle as shown below.

It never finishes and the file does not get saved at all.

Looking at .vscode\extensions\ms-python.python-2020.7.96456\pythonFiles\sortImports.py, this code looks fishy!
`
Work around stdin buffering issues on windows (https://bugs.python.org/issue40540)
caused in part by isort seeking within the stdin stream by replacing the
stream with something which is definitely seekable.
try:
# python 3
stdin = sys.stdin.buffer
except AttributeError:
# python 2
stdin = sys.stdin
sys.stdin = io.BytesIO(stdin.read())
End workaround
`

I disabled this block of code, I'm using python 3.7.4, VSCode 1.47.3 and ms-python.python v2020.7.96456 on Windows 10. I will let you know if this issues is still reproducible without this block of code.

Disabling this code block does not stop this issue.

I am also facing the same issue

To add another data point, I'm experiencing this problem as well, with VSCode version on Mac:
Version: 1.47.3
Commit: 91899dcef7b8110878ea59626991a18c8a6a1b3e
Date: 2020-07-23T13:08:29.692Z (2 wks ago)
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 18.5.0

I find it is still possible to format and save the file without sorting the imports by running these two commands from the command palette, which don't seem to invoke import sorting:

Format Document
File: Save without Formatting

which tides me over for now. Though it would be cool to know if there's a potential fix to the hanging "Sort imports", as it's awesome to have the editor manage them automatically :-)

This issue got fixed by installed isort in my virtual environment
pip install isort

This issue got fixed by installing isort in my virtual environment

No it didn't. That does not fix the issue. In fact, installing isort in your virtual environment is the first step that I posted in the "Steps to Reproduce" above.

I have it saving and sorting in a venv but not in a pyenv...... Same exact version of python, isort, black, vscode, same everything.

There's no difference between a venv and "a pyenv" as you put it... pyenv is simply a tool for managing your virtual environments. Are you similarly on Ubuntu 20.04? I see other comments confirming this bug exists there.

I'm on 18.04.  And I know!  There should be no difference!  And yet, the behavior is different.  I tried the same file with the same settings.json and same packages installed from a fresh 3.8.2 pyenv and venv.  Yet, when I used pyenv, it hangs but not with venv.

Huh. You're absolutely right. I just confirmed that this behavior works with a plain vanilla virtual environment, but not when using pyenv-virtualenv. That is the strangest thing.

It only happens when I use anaconda's python as my interpreter. I was able to fix it by installing miniconda.

I use venv as per https://docs.python.org/3/library/venv.html using python 3.7.4 in a sub directory inside my work area called ".pyenv" and I can reproduce this issue sporadically.

@soapergem, thanks for letting us know about this.  It is definitely undesirable that sort-imports-on-save would prevent saving the file.  We'll work on identifying the problem and fixing it.

It only happens when I use anaconda's python as my interpreter. I was able to fix it by installing miniconda.

Just to note, I've only ever used miniconda and I'm seeing this isort issue

I get this too and I use miniconda. Though for me it works for a while every time I  restart vscode but after a while it stops working (after multiple edits/saves, which might trigger it to show again).

I also see this issue, and I operate in a completely different environment. I see the issue when using the dev container feature only. I can use sort imports just fine when not connected to the dev container. I do not use any virtual environment. Host machine is a mac.

I managed to workaround the problem by adding the following to settings.json (change according to you location of isort script):
"python.sortImports.path": "/home/david/.local/bin/isort"

No, I'm not running in dev containers.
Tried setting the path, and restarting, etc. but none helped.
Virtual environment: conda 4.8.3
isort: 4.3.21
VSCode install:
Version: 1.48.1
Commit: 3dd905126b34dcd4de81fa624eb3a8cbe7485f13
Date: 2020-08-19T17:09:41.484Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.6.0

Hi all,
We recently shipped isort5 in the insiders version of the extension. Can anyone try using the Switch to Insider weekly command to install the insiders version of the extension, and see if it has this issue?
Unfortunately, I'm unable to reproduce this either on the stable or the insiders. Note we use the isort shipped in the extension by default, so it shouldn't matter what kind of virtual environment you're using, unless you use the python.sortImports.path setting to use a different version of isort. I would appreciate if someone can give me a small reproducible example, which includes the virtual environment.

Hi all,
We recently shipped isort5 in the insiders version of the extension. Can anyone try using the Switch to Insider weekly command to install the insiders version of the extension, and see if it has this issue?
Unfortunately, I'm unable to reproduce this either on the stable or the insiders. Note we use the isort shipped in the extension by default, so it shouldn't matter what kind of virtual environment you're using, unless you use the python.sortImports.path setting to use a different version of isort. I would appreciate if someone can give me a small reproducible example, which includes the virtual environment.

This strategy sounds counter intuitive. I would expect (and always thought) that when I set a python interpreter in my workspace, you would try and use everything from that interpreter.  Setting the special variable would deviate from that norm and choose a separate one if needed.

@brgirgis We have our reasons for doing so. It's a direct integration with "sort imports" and there is/was only one real choice - i.e we know for a fact that users would need to install it to sort imports. So we ship it in the box, similar to how we ship Jedi because we know everyone will use it.

@karrtikr - FYI, I just switched to insider weekly and it didn't fix it for me. VS code on mac, using a remote linux box with miniconda.
I've also tried setting the path as above and no luck, still hangs forever.
Version: 1.48.2
Commit: a0479759d6e9ea56afa657e454193f72aef85bd0
Date: 2020-08-25T10:09:08.021Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.5.0

I am able to reproduce this issue with the following settings:
{
    "python.formatting.provider": "black",
    "[python]": {
        "editor.formatOnSave": true,
        "editor.codeActionsOnSave": {
            "source.organizeImports": true
        }
    },
    "python.formatting.blackArgs": [
        "--line-length=88"
    ],
    "python.linting.enabled": true,
    "python.linting.flake8Enabled": true,
    "python.linting.flake8Args": [
        "--max-line-length=88",
        "--ignore=E203,E266,E501,E501,W503,E266,F541",
    ]
}

I'm using Miniconda. I selected my Conda environment in the python interpreter. When I edit and save a file, sort import hangs indefinitely

I had the same problem as well, I found that my problem was in .editorconfig file.
isort is reading the max_line_length = 89  # black preference config from .editorconfig file, and it failed due to inline comments.
I found the problem because isort failed even when I ran manually.

Idk if this is related, but i had the same issue today (Version | 2020.8.105369)
I noticed this message in the Log(Window):
/usr/lib/python3.8/site-packages/setuptools/distutils_patch.py:25: UserWarning: Distutils was imported before Setuptools. This usage is discouraged and may exhibit undesirable behaviors or errors. Please use Setuptools' objects directly or at least import Setuptools first.
  warnings.warn(

I applied a quick dirty fix, by modifying:
~/.vscode/extensions/ms-python.python-2020.8.105369/pythonFiles/lib/python/isort/settings.py (246 line)
            # Only some configuration formats support native boolean values.
            if not isinstance(value, bool):
-                value = bool(strtobool(value))
+                value = bool(value.lower() == 'true')
            computed_settings[access_key] = value

And removed distutils import.
After that, isort started working

I have also been suffering from isort hanging for the past few versions of VS Code (I am also running Ubuntu 20.04 which was mentioned by others). The good news (for me): I got it working again. The bad news: I am no longer able to reproduce the hanging behavior to work out how I fixed it.
But in case it's useful for someone else, I discovered that if you make a mistake with the isort options in the "python.sortImports.args" section then you will get the hanging behavior. I am pretty sure I hadn't made a mistake in those options, and it was only when I was messing with them that the mistake got introduced. Nonetheless, when I fixed the newly-introduced errors, that's when isort started working for me again and as mentioned I can't make it hang any more unless I make a mistake with specifying an option. For the record, I was attempting to use isort with black (I suspect this is quite a common combination).
My trouble-shooting consisted of:

Making sure I had "source.organizeImports": true in my settings.json and then saving a Python file, and seeing that the hang was occurring.
Going to the OUTPUT tab of the 'Panel' (the thing you bring up with ctrl+J which houses the terminal, problems and so on), and choosing Python from the dropdown.
Finding the line where isort was being invoked, and then pasting that command into my terminal. I got isort: error: unrecognized arguments: messages that revealed my mistakes.
Correct the contents of python.sortImports.args to reflect the correct way to specify the options. When those were fixed, my isort problems went away.

 And I agree, except there are some subtle ways to mess up the options to do with spaces which will cause the VS Code invocation to put the option between double quotes which in turn makes isort unhappy. For example, "--line-width 88" doesn't work. It needs to be either "--line-width=88" or two separate array elements: "--line-width", "88".

@jlmelville workaround doesn't help here. I'm on macOS Catalina 10.15.6, vscode 1.49.0, python extension v2020.8.109390
The sortImports command just hangs indefinitely. I've located the command in Python output panel:
~/Projects/test/.venv/bin/python ~/.vscode/extensions/ms-python.python-2020.8.108011/pythonFiles/pyvsc-run-isolated.py ~/.vscode/extensions/ms-python.python-2020.8.108011/pythonFiles/sortImports.py - --diff

This command never finishes and the same thing happens when I run it manually in the terminal. I have no extra arguments for isort, only "source.organizeImports": true in settings.
vscode info:
Commit: e790b931385d72cf5669fcefc51cdf65990efa5d
Date: 2020-09-10T17:39:53.251Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0

@ivasic when it started working, my invocation of isort also hangs when run directly from the terminal (I assume that's to do with reading from stdin).
One difference is that I installed my own isort into a venv in the workspace directory, so at least on Linux it looks much more like a standard execution of isort (I realize this goes against the advice of using the insiders build of the python extension with its own isort). Assuming you have a virtual environment installed, what happens if you pip3 install isort and then explicitly set "python.sortImports.path": "${workspaceFolder}/venv/bin/isort" in your settings.json?

@jlmelville yeah, I was afraid the stdin read might have had something to do with the hang when I run the command manually.
But great workaround using the locally installed isort via python.sortImports.path! It actually works without any issues along with the isort arguments and everything.
Ideally the problem should be solved, of course, but I'm happy with the workaround for the time being. Thanks for the tip!

@ivasic does your process still hang if you remove the python.sortImports.path entry and go back to the default (i.e. using ~/.vscode/extensions/ms-python.python-2020.8.108011/pythonFiles/sortImports.py)? The confounding thing for me was not being able to get back to reproducing the problematic behavior.

Folks would you mind trying out our Insiders build to see if you still have this issue? (View > Command Palette... and run Python: Switch to Insiders Weekly Channel)

Switching to the Insiders Weekly Channel seems to have fixed the issue.

Can confirm here as well. Insiders weekly seems to do the trick

Awesome🎉 The fix should be officially out in the next stable release which is scheduled in a week.
(FYI we think https://github.com/microsoft/vscode-python/pull/13717 fixed the issue, we weren't handling errors thrown by isort correctly, we also upgraded to isort 5.5.2 which might have helped)

I also have the issue running version 1.56.0 of VS code in Windows 10.

Unfortunately I'm unable to reproduce this in 1.56.1 version of VSCode. Do you mind creating a new issue filling the issue template?

Had a similar issue which was resolved by setting "python.pythonPath": "/usr/local/bin/python"

yeah I'm getting the sorting of imports hanging on version 1.56.2, I'm using pipenv for my environment

how do I disable isort completely?

I faced the same problem but solved it.
It seems to hang out when python.sortImports.path is a relative path.
NG:
"python.sortImports.path": ".venv/bin/isort",

OK:
"python.sortImports.path": "${workspaceRoot}/.venv/bin/isort",

It seems the issue is with relative paths. The issue is being tracked here https://github.com/microsoft/vscode-python/issues/7042.


Integrate Hugging Face Hub & add Docker image

This PR implements two main features:
Integration with the 🤗  Hub for downstream fine-tuning.
The --hub flag allows users to pick any (suitable) upstream model from the PyTorch or 🤗 Hubs, while the --push_to_hf_hub flag pushes all the artifacts from fine-tuning to the 🤗 Hub for inference / evaluation.
A fine-tuning run with these flags looks like:
python run_downstream.py -n exp_dir -m train -u ${upstream_model} -d ${downstream_task} --hub huggingface --push_to_hf_hub True

Upstream models on the 🤗 Hub require an expert.py interface to be defined and you can find an example here.
Downstream models are automatically wrapped in a model.py file that defines the interface for inference and you can find an example here. By default we use the *best*.ckpt checkpoint for inference / evaluation and fall back to the final checkpoint if a "best" one is not produced during training.
By storing all the artifacts, we can visualize the Tensorboard logs and reproduce training runs if needed from the args_*.yaml and config_*.yaml files.
Update: the tensorboard logs are only visible for public repos and by default we create a private repo (in case participants don't want to share their fine-tuned models with everyone).  The participant can view the logs by simply making their repo public if they wish
A Docker image for downstream fine-tuning
This builds on the above Hub integration and should be runnable on any infra that has the NVIDIA Container Toolkit installed. See the downstream README for more details on how to build the image / run it. Once this PR is merged, an interesting exercise will be to see if you can run the Docker container on your own infra 😃
Miscellaneous
We have also included some changes to:

The downstream README
The ASR and SD modules now include a template folder for the 🤗 Hub interfaces

cc @leo19941227

Many thanks @lewtun!!
I will look into this after I wake up. (Just about to sleep :) )

Thanks @lewtun! Just as as an additional piece of info, if you go to a repo with a downstream model (example), you get a widget at the right where users can try out the model.

Hi @lewtun, @osanseviero and @albertvillanova, thanks again for the great work!
I might still need some time to catch up all the changes and the new usage.
Please feel free to ping me if you think I am too slow :)

Hi @lewtun, @osanseviero and @albertvillanova, thanks again for the great work!
I might still need some time to catch up all the changes and the new usage.
Please feel free to ping me if you think I am too slow :)

take your time @leo19941227 - it's important that we test these changes carefully before merging to master ;)
in the meantime, you should be able to test that fine-tuning and the docker image work by simply cloning this branch

Hi @lewtun!
Besides a few comments, I am actual having trouble to push model files to the Hub.
I can create a Repository and I can also see the repository on my personal huggingface's profile page. However I can't finish the uploading operation. Specifically I ran into the following line and it take so much time and seems not able to complete.
train:   0%|                                                                                | 1/1783 [00:03<1:37:21,  3.28s/it]
overall: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:19<00:00, 19.71s/it]
HF Hub user: leo19941227
Created Hub repo: https://huggingface.co/leo19941227/superb-s3prl-fbank-asr-baf1deb3
Pushing model files to the Hub ...

Do you have any idea why this might happen?

Let me wait longer. I find that I can complete the uploading if I only put a single text file in the Repository. Maybe I just need to wait a little longer.

Hi @lewtun!
Besides a few comments, I am actual having trouble to push model files to the Hub.
I can create a Repository and I can also see the repository on my personal huggingface's profile page. However I can't finish the uploading operation. Specifically I ran into the following line and it take so much time and seems not able to complete.

Let me wait longer. I find that I can complete the uploading if I only put a single text file in the Repository. Maybe I just need to wait a little longer. Do you know how much time it took for uploading a finetuned ASR downstream model? @lewtun

Hmm it should be pretty fast (no more than a minute or so), so I think something might have be broken on the huggingface_hub side. I'll investigate to see if I can reproduce the issue and patch a fix if so :)

Hmm @leo19941227 I am not able to reproduce the problem you're having with pushing files to the Hub. For example if I run the following command
python3 run_downstream.py -n asr-push-to-hub -m train -u osanseviero/hubert_base -d asr --hub huggingface --push_to_hf_hub True -o "config.downstream_expert.datarc.libri_root='/data/lewis/superb/LibriSpeech',,config.downstream_expert.datarc.bucket_file='/data/lewis/superb/LibriSpeech/len_for_bucket',,config.runner.total_steps=10,,config.runner.save_step=5"

then I get a repo on the Hugging Face Hub after a few minutes, complete with all the files.
Could you share the transformers version you are using? For reference I have transformers==4.10.0 which includes huggingface-hub==0.0.15 by default.

Hey I find I am using the old versions. transformers==4.9.2 and huggingface-hub==0.0.12. I will try to upgrade the packages and run the commands you provided. The commands look the same as what I ran at my side.

Hey I find I am using the old versions. transformers==4.9.2 and huggingface-hub==0.0.12. I will try to upgrade the packages and run the commands you provided. The commands look the same as what I ran at my side.

Thanks for sharing the code versions! The huggingface_hub library has undergone quite some changes between versions, so perhaps this is the problem 😬
If that's indeed the problem, would there be any issue if we bump the minimum version of transformers to 4.10.0?

Created Hub repo: https://huggingface.co/leo19941227/superb-s3prl-osanseviero__hubert_base-asr-c61a5cff
Cloning https://huggingface.co/leo19941227/superb-s3prl-osanseviero__hubert_base-asr-c61a5cff into local empty directory.
Did not find a best checkpoint! Using the final checkpoint instead ...
Pushing model files to the Hub ...
Upload file model.ckpt:   3%|██▎                                       | 14.0M/490M [01:08<33:25, 249kB/s]

After I updated now I can see the upload progress bar :)
I am not sure whether the previous version has bug or it is just that I have very limited bandwidth lol
The bandwidth is varying and the time can take from 30 mins to 1hr.
Let me wait for it and see if I can successfully upload the entire repo to huggingface's hub.
Just to confirm, the bandwidth I show is normal for my free HF account right?

If that's indeed the problem, would there be any issue if we bump the minimum version of transformers to 4.10.0?

No I think there is no dependency issue :)
We can just change the minimum version in setup.py

I am not sure whether the previous version has bug or it is just that I have very limited bandwidth lol
The bandwidth is varying and the time can take from 30 mins to 1hr.
Let me wait for it and see if I can successfully upload the entire repo to huggingface's hub.
Just to confirm, the bandwidth I show is normal for my free HF account right?

As far as I know there should be no bandwidth difference between free HF accounts and the paid tier (although @osanseviero might want to confirm this), so indeed it might be a limitation on your end 😬

If that's indeed the problem, would there be any issue if we bump the minimum version of transformers to 4.10.0?

No I think there is no dependency issue :)
We can just change the minimum version in setup.py

Great! I'll add this change with the other fixes


:sparkles: [Proposal] The profile card will tilt in accordance with the tilt of the device.

Issue

None.

Overview (Required)

Inspired by @shunm-999 's implementation of #750, I tried making the cards tilt when the device is tilted.

Links

https://github.com/DroidKaigi/conference-app-2024/pull/750

Movie (Optional)

@takahirom
The operation is correct, but there is a possibility that the code is incorrect in part, so it will be returned to the draft for the time being. 🙇

Thank you for this great pull request!
Could we have a test using Robolectric's sendSensorEventToListeners?
https://github.com/expo/expo/blob/0e9df9fec13bf220130e85dce3e4186bc9346451/packages/expo-dev-menu/android/src/test/java/expo/modules/devmenu/detectors/ShakeDetectorTest.kt#L117


feat: Delete apps in an org parallelly

Fixes #370
I added a maximum number of concurrent app deletions. I thought it would be a good a idea just in case the system cannot handle too many requests at the same time. I set 100 for the max number of concurrent deletions, but please let me know if you think we should change this number or if this limit is not needed at all.
I didn't include unit tests as I didn't saw any, but please let me know if they need to be included.
Any feedback would be highly appreciated!

@jimmykarily Thank you for your valuable feedback! I originally thought of doing it without the main goroutine, but I found out I needed it in order to wait for an error or a success if there was no errors. If I wait for the error channel to receive a message just outside the loop, app will stop there forever. Or maybe I misunderstood what you meant? Please have a look at the latest changes and let me know what you think.
Thanks!

@jimmykarily  Thanks for your comments! I tried moving the errChan select inside the loop, but it fails in some edge cases. Let's say you have 100 apps, and the 99th app fails. The for loop finishes as soon as the 100 goroutines start executing. The select errChan goes to the default case, then for loop finishes. But the 99th goroutine is still running and fails, then send an error to errChan but this error is not received as the for loop has finished. That's why I added the main goroutine.
Do you see what I mean? If it is not clear, I would love to do a pairing session!
Thanks again for your feedback!

@jimmykarily Thanks for your comments! I tried moving the errChan select inside the loop, but it fails in some edge cases. Let's say you have 100 apps, and the 99th app fails. The for loop finishes as soon as the 100 goroutines start executing. The select errChan goes to the default case, then for loop finishes. But the 99th goroutine is still running and fails, then send an error to errChan but this error is not received as the for loop has finished. That's why I added the main goroutine.
Do you see what I mean? If it is not clear, I would love to do a pairing session!
Thanks again for your feedback!

I get what you mean. When that happens, your main thread (outside the for loop) will wait until all the running routines are done (because right after the for loop you will have a wg.Wait() call). This means the failed go routine will have time to write its error to the errChan. All we need then is to collect the errors after the wg.Wait() with a select call, almost like the one you have now but with no need to send anything to the stop chan:
// Right after the for loop
wg.Wait() // Wait for all running go routines to finish (either successfully or with error)
select {
case err := <-errChan: // See if we have any errors
  return err
default: // If there are no errors
  return nil
}

ah ok! I see it now! But if we add this outside the loop, we will have to wait for all the apps to be deleted. Maybe add 2 selects, one inside the loop and another outside? so the inside select will also return err and stop the loop if an error is received
Thanks!

Yes I meant 2 selects  , but that won't work :facepalm:  (that's where writing the code would have helped). If the inner loop reads the error from the errChan (to be able to stop), then the error will no longer be available for the outer select to read it.
Given this method only returns one error and not the list of all failures, we could store the error read inside the for loop in a variable so it's not lost. E.g.
// before the for loop
var forLoopErr error

...
    // In the for loop
    select {
    case forLoopErr := <-errChan:
      break loop
    default:
    }
}

// Right after the for loop
wg.Wait() // Wait for all running go routines to finish (either successfully or with error)
if forLoopErr != nil { // If the loop was stopped because of an error
  return forLoopErr
}

select {
case err := <-errChan: // See if we have any errors (that didn't stop the for loop but did happen after the for loop was done)
  return err
default: // If there are no errors
  return nil
}

@jimmykarily  you are right! This will work. I pushed a new commit with the changes, please have a look.
Thank you very much for your support with this!

Heh. And just as I completed my reading of the code and writing up my understanding. :wink:
Well, time to look at these changes and update my document and understanding.
When I am done I will post my own review. Will still take a while as I have a meeting in a moment.

@Raullllll yes, that's what I had in mind. It looks good now. I will wait for Andreas' review and also want to give it a hands-on try to see if we missed something before I approve. I hope to get it done tomorrow or worst case by the end of this week. Stay tuned!

I approve.
Attached my write up and documentation of the current code: dac.md
I would be pleased if this document could be added to the docs/ directory of the project, as reference for developers. Maybe make a reference to it in a code comment as well.
For posterity see also the dac1.md. This document describes the state of the system at commit 528af5feead2d4c21ccc4ac80633507d7e0ffa21, before the dispatcher goroutine got removed, and the two issues I found with it while writing the document.
@jimmykarily :bell:

@andreas-kupries thanks for the review, good to have another pair of eyes. I don't think we should have a separate document to explain how a method works for 2 reasons:

line numbers or even the way the method works could easily change without updating the document. One can't guess there is such a document when working on the code.
one shouldn't have to look in other places to understand the code.

That said and given this method is a little complex I would be ok to have a (maybe shorter) version of your document at the top of the method. The part that describes what various lines do can be left out then, since it's easier to directly look at the code below.
I believe all is good. I just need to do some manual QA on it (just did a code review up to now) and if all is ok we can merge.

line numbers or even the way the method works could easily change without updating the document

Right. Could be handled by using unique markers in the code for the various blocks and referencing these in the document.
This kind of thing could be done with the code comments as well, i.e. have it reference markers in the code underneath the explanation.

@Raullllll Note that @jimmykarily has approved. That means you can hit merge now.
My last comments here regarding comments in code can be ignored.
The plan is now for me to add such comments summarizing my writeup after the merge is done.

@andreas-kupries @jimmykarily  CI build pipeline failed. There was an error when trying to login into DockerHub.
I don't think I can merge it since I don't have write access.
Thanks!

No worries, the one that fails is a copy of the one that succeeded (long story related to internal github action runners and secrets). I will merge now. Thanks @Raullllll, good job!


[Bug]: Mod cannot be used on 1.18.1

What happened?
A bug happened!
Game Version
Other
What platform are you using?
Forge
Platform version
2.3.5 Forge
Config File
Not applicable, due to the nature of this issue

Crash report / Error log (if applicable)
Not applicable

Additional Information
The mod appears to be unable to run on 1.18.1, thus causing any server to crash when attempting to boot up, should they be using that version of Forge.

same here

This appears to have been resolved.


Fix input validation bugs

fix all input validation bugs like ability to add a group with just whitespaces for name (should not be allowed)

related to #186 @yokester98 @sophiien


[AI Agent Idea] Textile Fiber Analyzer

Description
An AI agent that analyzes & tells various properties of Textile Fibers.

Created a PR @wenzhuo2022


Philips Hue Ensis not supported, is available in devices.js

I get the following message in the log file: "Device '0x001788010924d127' with Zigbee model '4090330P9_02' and manufacturer name 'Philips' is NOT supported." but when I check the devices.js I do see the following entry:
"
{
zigbeeModel: ['LCP001', 'LCP002', '4090331P9_01', '4090331P9_02'],
model: '4090331P9',
vendor: 'Philips',
description: 'Hue Ensis',
meta: {turnsOffAtBrightness1: true},
extend: preset.hue.light_onoff_brightness_colortemp_color(),
ota: ota.zigbeeOTA,
},
"

Hi @stefanschoemaker,
please note that your actual zigbee model 4090330P9_02 does not match any of the zigbee models in philips.js (4090330* vs 4090331*). You could follow the guide How to support new devices to add it to your z2m instance.

Please open device specific issues here: https://github.com/Koenkk/zigbee2mqtt/issues


Contract Selection Override

Make it possible for a user to choose which contract her transaction is routed through. She may already have an allowance granted for the Uniswap contract or she may trust it more than our contracts. In the event that the default selection is only slightly "better" than another option, it's reasonable to expect the user to want to switch to her preference and still submit the transaction through our DApp.
We currently support this for testing purposes by running the following command in the JS console:
localStorage.setItem('override_best_tx_route', 'true')

We should probably take some time to confirm how we want the UX to work in this case before we enable it by default.

Done


Cube Checker

The Cube Checker seems to be not working correctly for me. When controlling the cube status via Cube Checker whether it is INT or PROD yields the same result.

This screenshot shows the status of the Cube Checker when applied to the Greenhouse Gas Emission cube which has been already published on PROD and is live and working, which is unexpected.
This error appears also if you follow from Cube Creator to Visualize via the direct link  after the publication process.
To Reproduce
It can be easily reproduced by entering the links from the respective cubes into the Cube Checker (int, prod)
For the links to the Cube themselves, follow the Run SPARQL Query link below the graphics of either Visualize graphic

Environment:

Visualize environment and version: v3.19.5 0481cfa
Browser and version Edge 109.0.1518.55

Hi @tboeni, thanks for the feedback. It seems like you are entering an unversioned cube IRI in the cube checker. The cube checker supports only versioned iri at the moment. I agree that the error could be better. From the Run SPARQL Query link that you mentioned, you get the versioned IRI. I added this warning in the cube checker doc and added a link to the cube checker doc on the cube checker page.
- https://environment.ld.admin.ch/foen/ubd000502
+ https://environment.ld.admin.ch/foen/ubd000502/3

Please tell me if it's OK for you, I am closing this issue, do not hesitate to re-open if it's unclear.

Hi @ptbrowne thanks for your answer, yes for this cube it has been solved. With this IRI it works fine.
I have not experienced the error again since. However I will keep my eyes open if the issue would return


Added guidance on writing URLs and updated DS URLs to follow these rules

What is the context of this PR?
Added guidance on writing URLs and updated DS URLs to follow these rules
How to review

Check documentation
Check for broken links caused by folder name changes

 Add "writing URLS" content to "writing page titles" content guide


[Tiny] UI fixes

There are few tiny UI suggestions I wanted to fix.

1. The alignment of the create post box (avatar, comment input and image) isn't correct.

In the user comment, there is an extra :' ' (at the last of picture) which kind of broke my build in local.

The avatar at top doesn't hold much use as of now. Adding a popover which would display the user address would be helpful for the users also. Or else, we could remove the avatar.

Hey, @keerthanak-tw you can go on.
Just know that that's is one component I am just replicating it, to show dummy datas for now, but go an ahead to add your fixes

Thanks @yhoungdev. It would be great if this can be considered as hacktoberfest contribution
Also, I had one small query. In this create box, I am unable to se image+ or voice record. Is that intended to upload docs?

That is just upload image, ye sure it's as a part of Hacktoberfest

I had raised a PR for the tiny fixes i mentioned. #26
Can you have a look at it @yhoungdev

Closing this one as PR was merged..
Thanks @yhoungdev 🙂


Problem during build step of installation

When I run npm run build after successfull npm install, this is what I get as error, do you know why this could be happening?

npm run-script build
<EMAIL_ADDRESS>build /home/kadir/Documents/baidu-pan-downloader
npm run clean && react-app-rewired build && node user-script.js > ./dist/bundle.user.js && cat ./build/static/js/main.js >> ./dist/bundle.user.js
<EMAIL_ADDRESS>clean /home/kadir/Documents/baidu-pan-downloader
rimraf build/*
/home/kadir/Documents/baidu-pan-downloader/node_modules/terser-webpack-plugin/node_modules/p-limit/index.js:30
} catch {}
^
SyntaxError: Unexpected token {
at createScript (vm.js:80:10)
at Object.runInThisContext (vm.js:139:10)
at Module._compile (module.js:616:28)
at Object.Module._extensions..js (module.js:663:10)
at Module.load (module.js:565:32)
at tryModuleLoad (module.js:505:12)
at Function.Module._load (module.js:497:3)
at Module.require (module.js:596:17)
at require (internal/module.js:11:18)
at Object. (/home/kadir/Documents/baidu-pan-downloader/node_modules/terser-webpack-plugin/dist/index.js:26:38)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build: npm run clean && react-app-rewired build && node user-script.js > ./dist/bundle.user.js && cat ./build/static/js/main.js >> ./dist/bundle.user.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

This issue has not been processed for a long time. hence close it.


Add button variant with live region support to password component

As noted in https://github.com/tmobile/magentaA11y/issues/125 it would be nice to have a variant that demonstrates live region support. I've added this example below the checkbox variant.

@silverli Back to you! thanks for the fixes!

@silverli Thank you! I've removed aria-describdeby and updated/trimmed the text content as well!


m4 'git' build fails due to internal 'git' usage

m4 build performs it's own 'git' to pull down files for the gnulib dependency.
These files are ascii and untagged, so subsequent processing fails.
The 'right' way to tackle this is to pre-req our git which should tag these files as ISO8859-1 automatically.
@IgorTodorovskiIBM fyi...

using our git now


Export Data from Tag Improver to csv / xls

Is there a way to Export Data from Tag Improver to csv / xls
I want to export data we see  in Entities tab/section in Tag Improver to csv / xls  based on sections I do in "Tag analyzer" tab.
Thanks and  Regards - Jai

how will I know if there can be any update on this request ?

We anticipate an upgrade project to happen in the next quarter. We will add this request to the list  of enhancements for tag-improver and update the issue, so you'll be notified - thank you


Rescue exceptions raised when inspecting objects

Exceptions raised when inspecting frame variables cause the debugger to
exit with the original Exception.
Instead, note to the user that an exception was rescued and any possible
result of #to_s on the failing object.
Closes #45

Thank you.


Update doc for 21.12 release

Signed-off-by: Allen Xu<EMAIL_ADDRESS>

Verified scala & notebook files, got PASS.


Errors with desock.so and desock.dup

I am trying to use preeny to make lighttpd recieve http requests from stdin. Hence, I used desock.so and desock_dup,so. When I use desock.so, I get this error: setsockopt(TCP_NODELAY) failed: Operation not supported. When I use desock_dup.so, I get this error: setting default fds failed: Success.
Have you guys occurred this error before? How would I solve this?

It looks like lighttpd is treating the socketpair that preeny replaced the network connection with as a network socket, and is trying to set socket options on it. The way to handle this for desock is to add some handling (probably just return 0) for setsockopts in the module. Not sure what's happening with desock_dup, but I'm guessing a similar root cause (treating the FD as a socket).

This is the c code that throws the error `srv->cur_fds = srv_socket->fd;
if (fdevent_set_so_reuseaddr(srv_socket->fd, 1) < 0) {
	log_error_write(srv, __FILE__, __LINE__, "ss", "setsockopt(SO_REUSEADDR) failed:", strerror(errno));
	return -1;
}

if (family != AF_UNIX) {
	if (fdevent_set_tcp_nodelay(srv_socket->fd, 1) < 0) {
		log_error_write(srv, __FILE__, __LINE__, "ss", "setsockopt(TCP_NODELAY) failed:", strerror(errno));
		return -1;
	}
}

if (-1 != stdin_fd) { } else
if (0 != bind(srv_socket->fd, (struct sockaddr *) &(srv_socket->addr), addr_len)) {
	log_error_write(srv, __FILE__, __LINE__, "sss",
			"can't bind to socket:", host, strerror(errno));
	return -1;
}

if (-1 != stdin_fd) { } else
if (AF_UNIX == family && !buffer_string_is_empty(s->socket_perms)) {
	mode_t m = 0;
	for (char *str = s->socket_perms->ptr; *str; ++str) {
		m <<= 3;
		m |= (*str - '0');
	}
	if (0 != m && -1 == chmod(host, m)) {
		log_error_write(srv, __FILE__, __LINE__, "sssbss", "chmod(\"", host, "\", ", s->socket_perms, "):", strerror(errno));
	}
}

if (-1 != stdin_fd) { } else
if (-1 == listen(srv_socket->fd, s->listen_backlog)) {
	log_error_write(srv, __FILE__, __LINE__, "ss", "listen failed: ", strerror(errno));
	return -1;
}`

The specific part that causes the error is if (family != AF_UNIX) { .... Hence, I deleted that if statement. For desock_dup.so, the error is thrown here `/* close stdin and stdout, as they are not needed /
{
struct stat st;
int devnull;
int errfd;
do {
/ coverity[overwrite_var : FALSE] */
devnull = fdevent_open_devnull();
#ifdef COVERITY
coverity_escape(devnull);
#endif
} while (-1 != devnull && devnull <= STDERR_FILENO);
if (-1 == devnull) {
log_error_write(srv, FILE, LINE, "ss",
"opening /dev/null failed:", strerror(errno));
return -1;
}
errfd = (0 == fstat(STDERR_FILENO, &st)) ? -1 : devnull;
if (0 != fdevent_set_stdin_stdout_stderr(devnull, devnull, errfd)) {
log_error_write(srv, FILE, LINE, "ss",
"setting default fds failed:", strerror(errno));
#ifdef FD_CLOEXEC
if (-1 != errfd) close(errfd);
if (devnull != errfd) close(devnull);
#endif
return -1;
}
#ifdef FD_CLOEXEC
if (-1 != errfd) close(errfd);
if (devnull != errfd) close(devnull);
#endif
}
if (0 != config_set_defaults(srv)) {
	log_error_write(srv, __FILE__, __LINE__, "s",
			"setting default values failed");
	return -1;
}`

As you can see, they are trying to disable stdin and stdout, so I deleted this entire portion of the code. Then I successfully compiled the binary, and I sent an invalid request through stdin. The request threw a 501 error through stdout and everything worked fine. However, when I tried using a valid request with stdin, there was no stdout. I checked my error log and I got a connection reset by peer error. This linked me with another file.
`	cnt = fdevent_accept_listenfd(srv_socket->fd, (struct sockaddr ) &cnt_addr, &cnt_len);
if (-1 == cnt) {
switch (errno) {
case EAGAIN:
#if EWOULDBLOCK != EAGAIN
case EWOULDBLOCK:
#endif
case EINTR:
/ we were stopped before we had a connection /
case ECONNABORTED: / this is a FreeBSD thingy /
/ we were stopped after we had a connection /
break;
case EMFILE:
/ out of fds */
break;
default:
log_error_write(srv, FILE, LINE, "ssd", "accept failed:", strerror(errno), errno);
}
return NULL;
} else {
if (sock_addr_get_family(&cnt_addr) != AF_UNIX) {
network_accept_tcp_nagle_disable(cnt);
}
return connection_accepted(srv, srv_socket, &cnt_addr, cnt);
}
}
/* 0: everything ok, -1: error, -2: con closed */
static int connection_read_cq(server srv, connection con, chunkqueue cq, off_t max_bytes) {
ssize_t len;
char mem = NULL;
size_t mem_len = 0;
force_assert(cq == con->read_queue);       /(code transform assumption; minimize diff)/
force_assert(max_bytes == MAX_READ_LIMIT); /(code transform assumption; minimize diff)/
/* check avail data to read and obtain memory into which to read
 * fill previous chunk if it has sufficient space
 * (use mem_len=0 to obtain large buffer at least half of chunk_buf_sz)
 */
{
	int frd;
	if (0 == fdevent_ioctl_fionread(con->fd, S_IFSOCK, &frd)) {
		mem_len = (frd < MAX_READ_LIMIT) ? (size_t)frd : MAX_READ_LIMIT;
	}
}`

The specific error in the error log is at log_errror_write. Also, to send the previous requests through stdin I used desock.so.
How would I fix this error and make valid requests work? Or is my method of patching wrong or is there an easier option?

Sorry if the source code part looks wierd.

The return zero method did not work.

Ive got it to work

What was the solution in the end?
https://xkcd.com/979/ :-)

FYI: the next version of lighttpd 1.4.56 additionally supports a special case of lighttpd -1 (one-shot mode) with pipes on stdin and stdout, e.g. for use with a netcat listener.  The current lighttpd -1 expects a socket on stdin.

The solution was that they closed stdin in the program. You would just have to delete that section in the code and desock worked.


Would you consider releasing under Public Domain?

Usually, you'd use something like this by copying and paste little snippets into your own code. But MIT requires you to include the copyright notice with every use, which would mean you have to be tracking every snippet you use. And if you modify a snippet, you'd have to keep track of that too.
Would you consider a public domain license? Something like the Unlicense?

yeah sure. maintaining copyright notice for this kind of work would be unnecessary


Android release build fails with Suspicious method call lint error

Hi,
When trying to create a release build containing this module I'm currently getting a lint error at lintVitalRelease with a Suspicious method call error.
...
:app:compileReleaseJavaWithJavac - is not incremental (e.g. outputs have changed, no previous execution, etc.).
:app:compileReleaseNdk UP-TO-DATE
:app:compileReleaseSources
:app:lintVitalRelease[...]/node_modules/react-native-webrtc/android/src/main/java/com/oney/WebRTCModule/WebRTCView.java:453: Error: Suspicious method call; should probably call "layout" rather than "onLayout" [WrongCall]
            onLayout(
            ~~~~~~~~

   Explanation for issues of type "WrongCall":
   Custom views typically need to call measure() on their children, not
   onMeasure. Ditto for onDraw, onLayout, etc.

1 errors, 0 warnings
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:lintVitalRelease'.
> Lint found fatal errors while assembling a release target.

  To proceed, either fix the issues identified by lint, or modify your build script as follows:
  ...
  android {
      lintOptions {
          checkReleaseBuilds false
          // Or, if you prefer, you can continue to check for errors in release builds,
          // but continue the build even when errors are found:
          abortOnError false
      }
  }
  ...

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 59.767 secs

Guess this is not really an error, just a lint issue. And guess I could set the abortOnError to false, but would prefer not to tho.

React Native version: 0.44.3
Plugin version: 1.58.1
OS: Android
OS version: n/a

Please read https://github.com/oney/react-native-webrtc/issues/321 to see how we fixed it, the problem the fix caused, and why we'll revert the fix. Basically, the current fix in the source code in master to address the linter error actually broke runtime functionality so it looks like we may have to find a way to tell the linter that the suspicious call is a false positive.


libxml2 git repo address has changed

In README.md,

Download subject (e.g., libxml2)

the git repo address has changed. It is now
https://gitlab.gnome.org/GNOME/libxml2.

Thanks. Fixed in 046293c.


Address eslint warnings

Please verify the version of auro-datepicker you have installed
@latest
Please describe the bug
When running a build, see the following warnings.
/Users/dalesande/src/auro/datepicker/src/auro-calendar.js
  23:1  warning  The type 'auroCalendar-dateSelected' is undefined  jsdoc/no-undefined-types
  24:1  warning  The type 'auroCalendar-ready' is undefined         jsdoc/no-undefined-types

/Users/dalesande/src/auro/datepicker/src/auro-datepicker.js
  53:1  warning  The type 'auroDatePicker-ready' is undefined      jsdoc/no-undefined-types
  54:1  warning  The type 'auroDatepicker-validated' is undefined  jsdoc/no-undefined-types
  55:1  warning  The type 'auroDatePicker-valueSet' is undefined   jsdoc/no-undefined-types

✖ 5 problems (0 errors, 5 warnings)

Reproducing the error
This issue cannot be reproduced on the Auro docsite
Expected behavior
No warnings.
What browsers are you seeing the problem on?
No response
Additional context
n/a
Exit criteria
This issue can be closed once there are no warnings in the CLI when running a build.

@jason-capsule42 can you please validate if this issue persists with all the updates you have recently made?


[BUG]: Data Configuration panel for Logs view remains disabled.

What is the bug?
Data configuration panel in logs view visualization remains disabled when "stats" aggregation is not present in PPL.
How can one reproduce the bug?
Steps to reproduce the behavior:

Go to Observability/Event Analytics/Explorer page
Enter the query in PPL query with no stats aggregation in it and select 'Year to date' option from calendar and click on 'Refresh'
Navigate to Visualizations page.
Select Logs view visualization from chart dropdown.
Data configuration panel remains disabled.
User can add fields from Fields panel but the fields are not getting reflected under data configuration panel.

What is the expected behavior?
Data configuration panel must remain enabled when there is no stats aggregation in PPL query. When user add fields from Fields panel, it should get reflected under data configuration panel.
Do you have any screenshots?

@anirudha @mengweieric
cc: @abasatwar @spattnaik

Merged to main.


Store the updated fabric info when bringing up controller on existing fabric

Right now bringing up a controller on an existing fabric updates the in-memory fabric table but does not store the updated data.
This is not very consistent with our desire to not even keep the fabric table in memory, and leads to inconsistent behavior if someone later reloads the fabric table from storage in some way.
Specific changes:

Change FabricInfo::SetFabricInfo to not modify any member state until
validation of the incoming info is complete, so we won't corrupt an existing
fabric due to mistaken input and leave it in a bad state.

If updating the existing fabric in ProcessControllerNOCChain succeeds, store
the updated fabric info.  This is done outside the fabric table for now,
pending changes to the fabric table to store things itself instead of keeping
them in RAM.

Problem
See above.
Change overview
See above.
Testing
CI should cover this, but I will also be writing tests for some work I am doing right now on Darwin controller bring-up which will exercise this.

/rebase


path/filepath: Rel() fails on Windows when only one parameter has \\?\ prefix

Go version
go version devel go1.24-47cdc43289 Mon Aug 12 13:09:41 2024 -0400 windows/amd64
Output of go env in your module/workspace:
PS C:\Users\Dan\REPOS\go\src> ..\bin\go.exe env
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Dan\AppData\Local\go-build
set GOENV=C:\Users\Dan\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\Dan\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\Dan\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Users\Dan\REPOS\go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Users\Dan\REPOS\go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=devel go1.24-47cdc43289 Mon Aug 12 13:09:41 2024 -0400
set GODEBUG=
set GOTELEMETRY=local
set GOTELEMETRYDIR=C:\Users\Dan\AppData\Roaming\go\telemetry
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=C:\Users\Dan\REPOS\go\src\go.mod
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\Dan\AppData\Local\Temp\go-build933240645=/tmp/go-build -gno-record-gcc-switches

What did you do?

Used patchset 3 of my demo CL: https://go-review.googlesource.com/c/go/+/604875/3 on top of d36353499f673c89a267a489beb80133a14a75f9
Ran .\all.bat

What did you see happen?
--- FAIL: TestRelWindows (0.00s)
    path_windows_test.go:734: Rel("C:\\foo", "\\\\?\\C:\\foo\\bar") = "", Rel: can't make \\?\C:\foo\bar relative to C:\foo; want "bar"
    path_windows_test.go:734: Rel("C:/foo", "//?/C:/foo/bar") = "", Rel: can't make //?/C:/foo/bar relative to C:/foo; want "bar"
    path_windows_test.go:734: Rel("\\\\?\\C:\\foo", "C:\\foo\\bar") = "", Rel: can't make C:\foo\bar relative to \\?\C:\foo; want "bar"
    path_windows_test.go:734: Rel("//?/C:/foo", "C:/foo/bar") = "", Rel: can't make C:/foo/bar relative to //?/C:/foo; want "bar"
FAIL
FAIL    path/filepath   1.568s

What did you expect to see?
The demo CL (https://go-review.googlesource.com/c/go/+/604875/3) contains several expectations, but I'll pick one. I'm particularly surprised that the relative path from basepath \\?\C:\foo to targpath \\?\C:\foo\bar is an error instead of bar.
I'm a little out of my depth, but this Microsoft documentation (https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#win32-file-namespaces) seems to indicate that \\?\ is just a way of turning off string parsing in Windows APIs.
I think it should be possible to work around this limitation, for instance by prefixing \\?\ onto the parameters when they are already absolute paths.

Related Issues and Documentation

path/filepath: Rel() fails for UNC volumes when trailing slash is omitted #41230 (closed)
path/filepath: EvalSymlinks doesn't work for Windows long filenames #40966 (closed)
path/filepath: filepath.Abs("[...]\...") returns different results on Windows than other systems #42362 (closed)
path/filepath: EvalSymlinks is broken for relative paths on Windows #16793 (closed)
path/filepath: calling Rel hangs my program #13258 (closed)
path/filepath: Rel() returns invalid path if volume case is different #10802 (closed)
path/filepath: Rel is not returning an error for symlinks #66622 (closed)
path/filepath: EvalSymlinks gives error for Windows's symbolic links with \?\ prefix #18924 (closed)
path.Base doesn't work for Windows paths #57649 (closed)
path/filepath: confusing error message for Rel #13259 (closed)

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

CC @neild @golang/windows

I agree with @dmcardle that \\?\ prefix should be ignored when comparing files in filepath.Rel.
All tests in https://go-review.googlesource.com/c/go/+/604875 should pass.
Alex


Fiat to Retirement UX & Design

This work stream is related to defining the user journey and designs related to a work flow of using fiat to retire/offset carbon. It will build off of the existing retirement aggregator app. The UX and designs may impact other related pages/apps (for example, the retirement receipt page).
Noted app features that will need design changes:

dApp retirement aggregator
net new payment modal
retirement summary page and/or retirement receipt

Related design issue: KI User Journey Design Review (#478)
Roadmap card here: https://www.notion.so/klima-dao/Fiat-to-Retirement-b957f0f460794bdcade38634987ebeee
Notes from design ideation meeting:

current dApp workflow assumes user has a wallet
need to inject a payment step to support also pay with fiat
“connect wallet btn” becomes “continue”
choose payment method
all the info entered in the offset form gets sent to the modal pre-loaded
modal should be in our design language
credit card —> confirmation page pre-populated
go to stripe payment flow (”checkout with offsetra”)

using offsetra stripe account, they are our payment provider partner

status of transaction (loading modal)
a confirmation page for success —> click next
error page for failed payment
end on a retirement receipt
CTA = claim your pledge

Version 1 is ready for review @jabby09 @Atmosfearful https://www.figma.com/file/gIsDanJUvVwQE4QqSh36Rr?node-id=0:1#255764402

Shipped design: https://www.figma.com/file/gIsDanJUvVwQE4QqSh36Rr/Fiat-2-Retirement?node-id=1%3A236#258974662


Fix recent list position to the left hand column on the Welcome Page

Fixes: https://github.com/microsoft/vscode/issues/171976
Also limits the # of recent items shown to 5.

This seems to be a bug at least in the case that you've closed all the new-user-guidance stuff.


Lost old emails after update

Hi,
I use 5 different email accounts on my K9 app. I have download a copy of my email on my phone since 2013. One in the week I use Outlook on my laptop and download all emails from the server (gmx.de). After the download the emails are not available on the server.
For all email accounts are the localStorageProvider = ExternalStorage. So i can find the files under Android/data/com.fsck.k9/files
This path includes normaly:
5x folder with the account uuid ending ".db_att"
5x file with the account uuid ending ".db" (file size min 85.000 KB max 475.000KB)
5x file with the account uuid ending ".db-journal"
1x file name ".nomedia"
2 of 5 accounts were empty (all old emails not shown) after update. The other 3 accounts updated correct and all old emails available.
I have look at the path after update which included two new folder:
2x account uuid ending ".db_attach-"  and 13 digit number
2 of 5 files with the account uuid ending ".db" (has a low file size < 17.000KB)
3 of 5 files with the account uuid ending ".db" (file size > 115.000KB)
Steps to reproduce

Download update via Play Store
Start App
App show "database update for emailadress" (or somthing like that)
Wait until the email accounts are shown (takes a lot of time)

Environment
K-9 Mail version: I'm not sure. Update was yesterday 04. Jan 2017 midday. I installed the new version 5.202 today
Android version: 6.0.1 (Samsung S7)
Account type (IMAP, POP3, WebDAV/Exchange): IMAP gmx.net accounts

Hi, I have probably the same issue:
I do not see my old (about 3000 emails) anymore since around new year.
Android 5.0.1
Samsung Galaxy S4
K9-mail v5.202
Issue probably already happened about two updates ago.
Can they be restored?

Additional information:
I use only POP3.
Emails are not deleted from the mail account by K9. I empty the account regularly when there are about 100 emails on it by using a PC.

Presumably this is a database upgrade failure and there's likely nothing we can do. Sorry.
There's also no log (unsurprisingly) so I don't know that we are going to be able to fix the specific case.
Personally I wonder whether we should remove the check and always crash the app if we can't upgrade properly @cketti ?

I had the same issue upgrading to version 5.202.
From the log:
01-09 23:13:06.816 E/k9      (32655): Exception while upgrading database. Resetting the DB to v0
01-09 23:13:06.816 E/k9      (32655): java.lang.IllegalStateException: Couldn't read row 0, col 0 from CursorWindow.  Make sure the Cursor is initialized correctly before accessing data from it.
01-09 23:13:06.816 E/k9      (32655): 	at android.database.CursorWindow.nativeGetLong(Native Method)
01-09 23:13:06.816 E/k9      (32655): 	at android.database.CursorWindow.getLong(CursorWindow.java:524)
01-09 23:13:06.816 E/k9      (32655): 	at android.database.AbstractWindowedCursor.getLong(AbstractWindowedCursor.java:75)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.mailstore.migrations.MigrationTo51.db51MigrateMessageFormat(MigrationTo51.java:79)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.mailstore.migrations.Migrations.upgradeDatabase(Migrations.java:58)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.mailstore.StoreSchemaDefinition.upgradeDatabase(StoreSchemaDefinition.java:60)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.mailstore.StoreSchemaDefinition.doDbUpgrade(StoreSchemaDefinition.java:36)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.mailstore.LockableDatabase.openOrCreateDataspace(LockableDatabase.java:381)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.mailstore.LockableDatabase.open(LockableDatabase.java:354)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.mailstore.LocalStore.(LocalStore.java:210)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.mailstore.LocalStore.getInstance(LocalStore.java:235)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.Account.getLocalStore(Account.java:1278)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.controller.MessagingController.setupPushing(MessagingController.java:4322)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.service.MailService.setupPushers(MailService.java:349)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.service.MailService.reschedulePushers(MailService.java:338)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.service.MailService.access$100(MailService.java:24)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.service.MailService$1.run(MailService.java:194)
01-09 23:13:06.816 E/k9      (32655): 	at com.fsck.k9.service.CoreService$1.run(CoreService.java:315)
01-09 23:13:06.816 E/k9      (32655): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
01-09 23:13:06.816 E/k9      (32655): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
01-09 23:13:06.816 E/k9      (32655): 	at java.lang.Thread.run(Thread.java:818)
01-09 23:13:06.826 I/k9      (32655): Upgrading database from version 0 to version 55
01-09 23:14:08.586 I/k9      (32655): No folders are configured for pushing in account Greg
01-09 23:14:08.586 V/k9      (32655): Pusher refresh interval = -1
01-09 23:14:08.586 D/k9      (32655): CoreService (com.fsck.k9.service.MailService) completed Runnable 235798985 with startId 1
01-09 23:14:08.586 V/k9      (32655): TracingWakeLock for tag CoreService execute / id 2: releasing after 277109 ms, timeout = 60000 ms
01-09 23:14:08.596 V/k9      (32655): ***** MailService *****: onDestroy()
01-09 23:14:08.596 I/k9      (32655): CoreService: com.fsck.k9.service.MailService.onDestroy()
01-09 23:14:11.136 I/k9      (32655): DatabaseUpgradeService stopped
01-09 23:14:11.136 V/k9      (32655): TracingWakeLock for tag DatabaseUpgradeService / id 5: releasing after 279579 ms, timeout = 600000 ms

I have had the exact same issue. All of my old emails are gone. I have made copies of the files themselves as i used to move them from phone to phone. Is there any way of access the files. Can this be done through a program on the pc?

I also lost my emails after in upgrade, although in my case it was the content ID replacement in the MigrationTo51 that was the problem.  I've fixed the issue, and will be submitting a pull request soon.


Added Here map widget for Jupyter as plotting backend

Hi @giswqs,
This PR includes below features:

Visualise default HERE basemap using here-map-widget-for-jupyter
Add basemaps  both existing supported by leafmap as well as HERE supported basemaps.
Add GeoJSON layer
Add XYZ TileLayer
Added separate notebook to show above functionalities.
Updated documentation.

Please review.
I will add the remaining features once this PR is accepted. I just included basic functionality as a starting point.

This is fantastic! Thank you very much for your contribution.


Change SSL to opt-in

Currently the SSL library is opt-out, having to manually specify default-features=false in every crate that depends on Iron.
Many of the middleware available does not care about whether SSL is enabled or not. However, many libraries do not opt out of the feature, making compilation without it almost impossible. This is especially an issue on Windows where compiling openssl-sys is not easy.
#351 did not take a clear stand on inclusion of this feature. I would like to see this changed to the opt-in behaviour.
Sample middleware which are currently unsusable without ssl:

handlebars-iron
router (present in TOML, but not yet pushed to crates.io)
mount
staticfile

Perhaps this is the way to go, yes. @reem?

Yes, I agree making ssl opt-in is the right move here.

Great! This will greatly improve the experience on Windows. Should I submit a PR removing the default or is there more work to be done?

I don't think there's any other change required.
Reverting all those default-features = false PRs is not required to make this work, although I suppose it should be done at some point.

Remove the default feature should be all that is needed.


Fix double dot range for invalid input

For double dot range i.e., a..b where a and b are inclusive when ranging from a to b. Therefore every element x in the range must satisfy a <= x && x <= b
Previously, it used to panic because, for a..b, a is considered minimum and b is considered maximum which results in negative size when allocating memory for slice using make. Ref:
file: optimizer/const_range.go
size := max.Value - min.Value + 1
...
...
value := make([]int, size)

So, for invalid inputs where a > b, it panics. Similar problem is there in vm/runtime.go's makeRange function as well.
Changing it in the optimizer and makeRange seems apt to me, but I figured it could be handled in checker/checker.go and cry the error out loud that the expression is not correct, but it didn't feel right.
@antonmedv What do you think? Having an empty slice instead of exiting out with an error seems good, right?
Fixes #163

Could you add tests to fix #163 ?

@johejo done!

I think same way work in python. So I think it make sense.

I think same way work in python. So I think it make sense.

So, this PR looks good, right? Could be merged?

Yes, gonna test it today and merge.