Create projectname_shared project when generating projects

I have run into several cases where my client and server need to share some code, e.g. business logic, or data classes / enums that don't need to be passed over the wire but are needed for processing on both the server and the client.
I noticed that the way this is solved by Serverpod itself is by creating a ..._shared directory: packages/serverpod_shared and  tests/serverpod_test_shared.
serverpod generate should create a shared project like this automatically (creating ..._shared alongside ..._server, ..._client, and ..._flutter), with instructions for users to put shared code into that project if necessary, automatically adding a dependency on this project from the server and flutter projects.
At a minimum the shared project should contain a configuration file that specifies the host and port of the server. This has to be specified in two places right now:

it is specified in the client when calling the Client constructor;
it has to also be specified in the server, e.g. in config/development.yaml, otherwise file URLs generated by the server will not be valid. (By the way, this is not documented anywhere that I saw, I had to figure out the hard way why uploaded images weren't originally loading from the server...)

The generated starter project should pull from this shared configuration file on both the client and the server.

Yes! We had a discussion on this point yesterday and it would indeed be quite nice to have even though there is nothing stopping you from manually setting this up.
For documentation purposes:
We could also generate base classes in the shared package of our protocols, this way both the server and client classes could inherit from them and you got a single place where you can add extensions to the generate code (that should be shared).

I'll be manually setting this up, yes, but I couldn't figure out how to do it before I noticed your _shared projects -- I have raised the issue of wanting to share code between client and server once or twice before in Serverpod issues or discussions. Anyway it wasn't intuitive to me to come up with this solution, so that's why I propose generating all projects that way by default. People can delete the _shared project if they don't need it. But at least for host/port config, as I pointed out this is in fact an important usecase for a shared project.
Although that raises another issue -- when a client or server project is built, how does the compiler know to bundle a config file (e.g. a config yaml file) from a dependency with the build? I would assume only the code that is called in dependencies (after tree shaking) makes it into the final build, not every file that was shipped with every dependency.

OK, I tried manually setting up a shared project. The flutter and server projects both depend upon the shared project. However, the shared project needs to also depend on the client project, which is generated from the server, because some of the shared functions depend upon generated types (like enums, generated from protocol files on the server).
Including the shared project on the server now gives errors like:
The argument type 'FileType (where FileType is defined in /home/luke/Work/click/click_server/lib/src/generated/enum_file_type.dart)' can't be assigned to the parameter type 'FileType (where FileType is defined in /home/luke/Work/click/click_client/lib/src/protocol/enum_file_type.dart)'.dart[argument_type_not_assignable](https://dart.dev/diagnostics/argument_type_not_assignable)
enum_file_type.dart(11, 6): FileType is defined in /home/luke/Work/click/click_server/lib/src/generated/enum_file_type.dart
enum_file_type.dart(11, 6): FileType is defined in /home/luke/Work/click/click_client/lib/src/protocol/enum_file_type.dart

So I'm back to the drawing board. The shared project cannot depend upon the client project, therefore it can't use any of the types that should be commonly accessible on both the server and the flutter frontend.
Really what needs to happen is that there should be a way to mark classes on the server for copying into the client.

@lukehutch, I think you can manage this using a symlink. E.g. place your shared extensions in a file (or directory) on the server. Use ln -s to create a symlink for the file or the directory in the client or in your flutter code. You may need to use a relative import to import any supporting files (e.g. the generated protocol and models).
This way you will only need to maintain one file, but it will be present in two places.

@vlidholt I'm willing to contribute time and effort on a redesign and rework for this issue. We are currently designing a build_runner's builder for the topic and I'm realizing because of this that it wouldn't be as good as a 15/30 minutes talk and a roadmap of the changes needed. What do you think about this?

@lukehutch, I think you can manage this using a symlink. E.g. place your shared extensions in a file (or directory) on the server. Use ln -s to create a symlink for the file or the directory in the client or in your flutter code. You may need to use a relative import to import any supporting files (e.g. the generated protocol and models).
This way you will only need to maintain one file, but it will be present in two places.

That would work for pure non-generated shared code, but as the error message in my previous comment indicates, it won't work for any shared code that depends upon generated code (presumably because there are different server and client versions of generated classes).

@lukehutch I'm pretty sure it would work if you make sure to import using the same relative import.
E.g.
Server side
// my_exports.dart
export '../generated/my_serializable.dart';

// File with shared extensions (i.e. my_extension.dart)
import 'my_exports.dart';

extension MyExtension on MySerializable {
  // Added shared methods.
}

Client side
Make a ln -s to my_extension.dart
Add a second my_exports.dart which references the local generated files.

@vlidholt so you're saying the client and server version of generated classes are always exactly the same?
I assumed they wouldn't be, because some fields of generated classes are api-only, and some are database-only.

Sorry I'm a bit slow. They aren't exactly the same, but similar enough that you can extend them with the same code.

@vlidholt How about allowing for a common directory in the server project, which, if present, is sync'd into the client project whenever serverpod generate is called? (The client should probably have a README file added that says Do not modify the contents of this directory, it is synchronized from the server. Or maybe the client directory should just be a softlink to the server.)

I think the proper solution is to correctly do the projectname_shared package, with generated abstract classes as a base for the other generated models.

I have tried to create a shared code project in a number of different ways. Nothing I do works. The fundamental problem is that there are separate server and client versions of all model classes, and shared code can import only one of these two. Actually the server versions are not even exported from the server project, so the only option in a separate project is to import the client version. But then if the server project adds a dependency to the shared project, it now transitively imports the client versions of the model classes -- and the server versions are not compatible with them.
One stop-gap might be to make the client and server model classes share a common abstract superclass, although I don't think that will work with enums, since they are not extensible.
The only solution I can see is to allow a user to mark a source file in the server project as something that should be copied across into the generated client project. However, when the file is copied, its imports also need to be updated so that they point to the client project's model classes, rather than the server project's model classes.
This is pretty important -- I keep having to duplicate code between my server and flutter projects, and having to manually keep both versions in sync is a big risk for breakage.

Any update on fixing this issue from the Serverpod team?


Spring fox still producing "allowEmptyValue" in generated spec for @ApiModelProperty annotation

Originally posted by @taddygrrr in https://github.com/springfox/springfox/issues/2204#issuecomment-419528703

This is still happening in 2.9.2 - any chance someone can look into it?


Add Gearbox Protocol (GEAR)

As title, add Gearbox Protocol's GEAR token.
Please let me know if there are any changes needed.

Hey @MRabenda, pushed those two fixes. Cheers 🍻


Zone mismatch error

Error log
The following assertion was thrown during runApp:
Zone mismatch.
The Flutter bindings were initialized in a different zone than is now being used. This will likely
cause confusion and bugs as any zone-specific configuration will inconsistently use the
configuration of the original binding initialization zone or this zone based on hard-to-predict
factors such as which zone was active when a particular callback was set.
It is important to use the same zone when calling ensureInitialized on the binding as when calling
runApp later.
To make this warning fatal, set BindingBase.debugZoneErrorsAreFatal to true before the bindings are
initialized (i.e. as the first statement in void main() { }).
Yes i already this Zone mismatch Migration guide but it don't work
Future<void> main() async {
  FirebaseCrashlytics? crashlytics;

  if (!kIsWeb && (Platform.isIOS || Platform.isAndroid)) {
    try {
      WidgetsFlutterBinding.ensureInitialized();
      await Firebase.initializeApp(
        options: DefaultFirebaseOptions.currentPlatform,
      );
      crashlytics = FirebaseCrashlytics.instance;
    } catch (e) {
      debugPrint("Firebase couldn't be initialized: $e");
    }
  }

  await guardWithCrashlytics(
    guardedMain,
    crashlytics: crashlytics,
  );
}

void guardedMain() async {
   /// other code
    runApp();
}

@filiph  Do you have any thoughts about it?

@filiph

Hi ,
I came across an issue in our Tic Tac Toe app regarding a "Zone mismatch" error, and I believe I have a solution to resolve it.The error arises from inconsistencies in how the Flutter bindings are initialized and when runApp is called. By ensuring that the Flutter bindings are initialized in the same zone as when runApp is invoked, we can mitigate this issue.
I'm eager to contribute to resolving this issue and improving the stability of our app. Could you please assign me this task?
Best regards,
Ayush


Installation on Fedora requires extra setup steps

While, technically, this step is related to VirtualBox installation and not Drupal VM, I think it may be good to start a linux.md section in the docs and start putting distro-specific notes and installation gotchas into there (Ubuntu, Fedora, and Arch are the three OSes I see the most small issues for).
The first thing I've noticed while working within Fedora 22 (I'll upgrade to 23 in a day or two) is that to resolve the following error on vagrant [anything]:
$ vagrant status
VirtualBox is complaining that the kernel module is not loaded. Please
run `VBoxManage --version` or open the VirtualBox GUI to see the error
message which should contain instructions on how to fix this error.

...I had to do the following:
sudo dnf install "kernel-devel-uname-r == $(uname -r)"
sudo dnf install gcc
sudo /var/lib/vboxdrv.sh setup

Basically, some of the VirtualBox deps were missing, including kernel headers, and I had to install them prior to VirtualBox actually running.

@geerlingguy I've noted that whenever I run a kernel upgrade, I need to run sudo dnf remove VirtualBox followed by sudo dnf install VirtualBox.


A List relation is not allowed on module tables.

So I'm trying to decouple my server a little bit and separate some models into modules but then when I try to use a model from a module as a Listmodule:Model I get the following error:
Found 1 issue.
Error on line 15, column 47 of lib/src/models/warehouse/top_shelf.spy.yaml: A List relation is not allowed on module tables.
  ╷
1 │ relation
  │ ^^^^^^^^

relation in the top_shelf:
products: List<module:products:ProductDTO?>?, relation(optional)

Def:
class: ProductDTO
table: products_product

fields:
  # product type
  type: ProductType

Is there a workaround for this, am I doing something wrong or is there just no support for this in which case I'd like to turn this into a feature request and get some info on the timeline for this feature?

TLDR
Defining a list relation directly to a module model is not allowed. This would require changing the model in the module, thus breaking the encapsulation of the module models.
Workaround documented here: https://docs.serverpod.dev/concepts/database/relations/modules#advanced-example
Relations are defined
When a relation is defined, this connection needs to be preserved some way in the database. This is done by storing the primary key of the related record in the other table. So Table A will get an additional column that stores the primary key of the associated record in Table B.
How list relations are defined
When a list relation is defined, a single record from Table A should now be associated with multiple records from Table B. The way this is solved in the database is by modifying Table B to have an extra column that stores the primary key of the record associated with it in Table A.
So, if you create a list relation towards a module Model, this would require a modification of that module's database definition, breaking the encapsulation of the module.
Workaround
To get around this issue and preserve the module encapsulation, you can define a connection model (or junction table) in your project.
This is documented here: https://docs.serverpod.dev/concepts/database/relations/modules#advanced-example
Feature status
Breaking encapsulation for modules is not something we are planning to implement.
Will transform this into a Q&A discussion and mark this as an answer.


Handle .spec.js and __mocks__ different

This tool is a great idea Ben!
It would be awesome if this would end the endless debates about folder structures like prettier ended the debates about formatting.
I ran it against a small project and quickly realised, that it doesn't play well when u have .spec. files and __mock__ folders inside your src folder.
So this

becomes:

instead of:

How do the files import each other?
Would you mine adding this as a test case?

should be fixed now


Double Click to go back

What's the Problem?
To go back with my mouse only, I have to go all the top of the explorer and press the up icon
Solution/Idea
It would be nice if you could double click on any place that is not already being used and it would go to the previous folder.
Explorer++ has this feature and I love it but I like the looks of Files
Alternatives
Maybe there could be a back icon on the left side to quickly go back to the previous folder but it isn't such a good solution.
Priorities

Capability
Priority

This proposal will allow developers and end-users to accomplish navigating quicker
Should

Files Version
v<IP_ADDRESS>
Windows Version
Windows 11 Pro 21H2 22000.184
Additional comment
No response

Merging with #5090, #2355


fix(resource): make properties for async resource resolution optional

Which problem is this PR solving?
See #3676, existing detectors that previously worked with 1.9.1 do not compile anymore. This PR fixes this, but will break the use of resource.waitForAsyncAttributes() that was introduced in the most recent version. Looks like this is the only way to restore compatibility. I'm open to any suggestions to improve this.
Fixes #3676
Fixes open-telemetry/opentelemetry-js-contrib#1429
Short description of the changes

make properties for async resource resolution optional

Type of change

[x] Bug fix, restoring backwards compatibility, see semver:

What do I do if I accidentally release a backwards incompatible change as a minor version?
As soon as you realize that you’ve broken the Semantic Versioning spec, fix the problem and release a new minor version that corrects the problem and restores backwards compatibility. Even under this circumstance, it is unacceptable to modify versioned releases. If it’s appropriate, document the offending version and inform your users of the problem so that they are aware of the offending version.

How Has This Been Tested?

[x] Existing tests
[x] Added an unmodified 1.9.1-style Detector as a regression test that should fail compilation when incompatible changes are made in the future.

Checklist:

[ ] Followed the style guidelines of this project
[ ] Unit tests have been added
[ ] Documentation has been updated

What about the existing compat tests here?
Are they still needed/helpful?
And why haven't they shown the compat problems or do they focus on something completely different?

Those tests focus on using the old version of @opentelemetry/resources with a new resource detector. I believe what marc here is showing is the opposite? Using an old detector with the newest version of @opentelemetry/resources

Exactly, they're the other way around. Even without the ts-ignore that I removed in 0887706, this would not have been caught using the existing tests.

This is only a problem because the old detect method referenced the class Resource instead of a Resource interface. Yet again concrete class references in types coming to bite us.
https://github.com/open-telemetry/opentelemetry-js/blob/v1.9.1/packages/opentelemetry-resources/src/types.ts#L33

Discussed in SIG. We decided that the breaking change introduced in 1.10.0 was itself a bug. This PR fixes that break.


Does the OpenStack plugin work with an https keystone endpoint?

I have set up an OpenStack instance (HPE Helion OpenStack) and all of its endpoints are https-based. Does the OpenBaton OpenStack VIM Driver work with that? I received this message when I tried to register the VIM:
ERROR: HTTP status: 422 response data : {"code":"Bad Request","message":"Not listed Images successfully of VimInstance HOS VIM. Caused by: org.openbaton.exceptions.VimDriverException: Received fatal alert: handshake_failure connecting to POST https://<IP_ADDRESS>:5000/v2.0/tokens HTTP/1.1"}
Unfortunately I can't access the logs at the moment, but I was wondering if you've run into this before.

Hi @ftcjeff
I merged a pull request #3 that disable the check for ssl self signed certificates. This should mean that https is supported. Anyway we are completely relying on the jCloud library so you can have a look in their documentation too.
But we never tried with HPE Openstack, so it could also be a versioning issue.

Okay, thank you @lorenzotomasini. I built this OpenBaton instance yesterday, so it should definitely have that PR included... Weird, I'll keep looking.  Thanks!

It looks like the cert check setting is defaulted correctly (at least according to the logs):
[main] DEBUG org.openbaton.clients.interfaces.client.openstack.OpenstackClient - Loading properties
[main] DEBUG org.openbaton.clients.interfaces.client.openstack.OpenstackClient - external-properties-file: /etc/openbaton/plugin/openstack/driver.properties doesn't exist
[main] DEBUG org.openbaton.clients.interfaces.client.openstack.OpenstackClient - Loaded properties: {external-properties-file=/etc/openbaton/plugin/openstack/driver.properties, type=openstack, disable-ssl-certificate-checks=true, dns-nameserver=<IP_ADDRESS>}
[main] DEBUG org.openbaton.clients.interfaces.client.openstack.OpenstackClient - Disable SSL certificate checks: true
Here's the stack trace if it helps:
[pool-1-thread-8] DEBUG org.openbaton.clients.interfaces.client.openstack.OpenstackClient - Listing images for VimInstance with name: HOS VIM
[pool-1-thread-8] DEBUG org.jclouds.rest.internal.InvokeHttpMethod - >> invoking AuthenticationApi.authenticateWithTenantNameAndCredentials
[pool-1-thread-8] DEBUG org.jclouds.http.internal.JavaUrlHttpCommandExecutorService - Sending request<PHONE_NUMBER>: POST https://<IP_ADDRESS>:5000/v2.0/tokens HTTP/1.1
[pool-1-thread-8] ERROR org.jclouds.http.internal.JavaUrlHttpCommandExecutorService - Command not considered safe to retry because request method is POST: [method=org.jclouds.openstack.keystone.v2_0.AuthenticationApi.public abstract org.jclouds.openstack.keystone.v2_0.domain.Access org.jclouds.openstack.keystone.v2_0.AuthenticationApi.authenticateWithTenantNameAndCredentials(java.lang.String,org.jclouds.openstack.keystone.v2_0.domain.PasswordCredentials)[admin, PasswordCredentials{username=admin, password=*****}], request=POST https://<IP_ADDRESS>:5000/v2.0/tokens HTTP/1.1]
[pool-1-thread-8] ERROR org.openbaton.clients.interfaces.client.openstack.OpenstackClient - Received fatal alert: handshake_failure connecting to POST https://<IP_ADDRESS>:5000/v2.0/tokens HTTP/1.1
org.jclouds.http.HttpResponseException: Received fatal alert: handshake_failure connecting to POST https://<IP_ADDRESS>:5000/v2.0/tokens HTTP/1.1
at org.jclouds.http.internal.BaseHttpCommandExecutorService.invoke(BaseHttpCommandExecutorService.java:117)
at org.jclouds.rest.internal.InvokeHttpMethod.invoke(InvokeHttpMethod.java:90)
at org.jclouds.rest.internal.InvokeHttpMethod.apply(InvokeHttpMethod.java:73)
at org.jclouds.rest.internal.InvokeHttpMethod.apply(InvokeHttpMethod.java:44)
at org.jclouds.rest.internal.DelegatesToInvocationFunction.handle(DelegatesToInvocationFunction.java:156)
at org.jclouds.rest.internal.DelegatesToInvocationFunction.invoke(DelegatesToInvocationFunction.java:123)
at com.sun.proxy.$Proxy57.authenticateWithTenantNameAndCredentials(Unknown Source)
at org.jclouds.openstack.keystone.v2_0.functions.AuthenticatePasswordCredentials.authenticateWithTenantName(AuthenticatePasswordCredentials.java:43)
at org.jclouds.openstack.keystone.v2_0.functions.AuthenticatePasswordCredentials.authenticateWithTenantName(AuthenticatePasswordCredentials.java:31)
at org.jclouds.openstack.keystone.v2_0.functions.internal.BaseAuthenticator.apply(BaseAuthenticator.java:79)
at org.jclouds.openstack.keystone.v2_0.functions.internal.BaseAuthenticator.apply(BaseAuthenticator.java:36)
at com.google.common.cache.CacheLoader$FunctionToCacheLoader.load(CacheLoader.java:148)
at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3524)
140,2-9       42%
at org.jclouds.rest.internal.DelegatesToInvocationFunction.getInstanceOfTypeWithQualifier(DelegatesToInvocationFunction.java:277)
at org.jclouds.rest.internal.DelegatesToInvocationFunction.lookupValueFromGuice(DelegatesToInvocationFunction.java:234)
at org.jclouds.rest.internal.DelegatesToInvocationFunction.handle(DelegatesToInvocationFunction.java:152)
at org.jclouds.rest.internal.DelegatesToInvocationFunction.invoke(DelegatesToInvocationFunction.java:123)
at com.sun.proxy.$Proxy67.getConfiguredRegions(Unknown Source)
at org.openbaton.clients.interfaces.client.openstack.OpenstackClient.getZone(OpenstackClient.java:213)
at org.openbaton.clients.interfaces.client.openstack.OpenstackClient.listImages(OpenstackClient.java:509)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.openbaton.plugin.PluginListener.executeMethod(PluginListener.java:204)
at org.openbaton.plugin.PluginListener.run(PluginListener.java:126)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
Caused by: javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure
at sun.security.ssl.Alerts.getSSLException(Alerts.java:192)
at sun.security.ssl.Alerts.getSSLException(Alerts.java:154)
at sun.security.ssl.SSLSocketImpl.recvAlert(SSLSocketImpl.java:1989)
at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:1096)
at sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1342)
at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1369)
at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1353)
at sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsClient.java:559)
at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnection.connect(AbstractDelegateHttpsURLConnection.java:185)
at sun.net.www.protocol.http.HttpURLConnection.getOutputStream(HttpURLConnection.java:1139)
at sun.net.www.protocol.https.HttpsURLConnectionImpl.getOutputStream(HttpsURLConnectionImpl.java:250)
at org.jclouds.http.internal.JavaUrlHttpCommandExecutorService.writePayloadToConnection(JavaUrlHttpCommandExecutorService.java:294)
at org.jclouds.http.internal.JavaUrlHttpCommandExecutorService.convert(JavaUrlHttpCommandExecutorService.java:170)
at org.jclouds.http.internal.JavaUrlHttpCommandExecutorService.convert(JavaUrlHttpCommandExecutorService.java:64)
at org.jclouds.http.internal.BaseHttpCommandExecutorService.invoke(BaseHttpCommandExecutorService.java:95)
... 62 more
[pool-1-thread-8] DEBUG org.openbaton.clients.interfaces.client.openstack.OpenstackClient - Answer is: {
"exception": {
"detailMessage": "Received fatal alert: handshake_failure connecting to POST https://<IP_ADDRESS>:5000/v2.0/tokens HTTP/1.1",
"stackTrace": [],
"suppressedExceptions": []
}
}

Any thoughts about this?  I can't get past the handshake error. I've looked at some options from a few jclouds boards, but nothing has shown any promise.
ubuntu@openbaton:~$ curl --insecure https://<IP_ADDRESS>:5000/v2.0
{"version": {"status": "stable", "updated": "2014-04-17T00:00:00Z", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.identity-v2.0+json"}], "id": "v2.0", "links": [{"href": "https://<IP_ADDRESS>:5000/v2.0/", "rel": "self"}, {"href": "http://docs.openstack.org/", "type": "text/html", "rel": "describedby"}]}}
ubuntu@openbaton:~$ curl --insecure https://<IP_ADDRESS>:5000/v3
{"version": {"status": "stable", "updated": "2016-04-04T00:00:00Z", "media-types": [{"base": "application/json", "type": "application/vnd.openstack.identity-v3+json"}], "id": "v3.6", "links": [{"href": "https://<IP_ADDRESS>:5000/v3/", "rel": "self"}]}}

have you tried downloading and installing the certificate in the local JVM? usually that's done via keytool and it is needed unless disabling completely security mechanisms..

I believe so! I keytool --imported what I believe is the correct certificate.

Hi. Even I too face the same issue. Is this issue resolved by any chance?


1123 common mdx error documentation updates

Closes #1123
Implements new styles for common mdx errors page.
Can't put this into SB yet since most of the components used in the page haven't been migrated to mdx-components yet, will put on storybook once #1103 completes
Redline: https://www.figma.com/file/WyfqQh9R1VXYZErfmsNDVH/Platform_MDXerrors?node-id=317%3A11968
Note:

InlineError and FullPageError are both hanging left, this is documented in issue #1364
There's this weird overlap on the inline code and the text here http://localhost:3000/common-mdx-errors#component-not-rendering, it's also on prod https://next.carbondesignsystem.com/common-mdx-errors#inline-styles not sure what's happening here 🤷♀ , tracking in #1384

Changelog
Changed

Converted common errors mdx page into a .js page to prepare for storybook migration, also added styling according to redlines pattern

Testing / reviewing
http://localhost:3000/common-mdx-errors

Small missing token, I'm also seeing the incorrect col width for the notifications at sm/md, but possibly unrelated to this PR? They should match the paragraph width I believe.

thanks! will fix. Col issues are general and documented here #1364

@andreancardona fixed columns, the small screen white space issue is documented in #1384


Project Continuous Integration

As a developer, I want my push requests to trigger a GitHub Action that clean builds the project and runs all tests, so that no breaking changes are merged into the main branch.
Size: Large
Definition of Done

[x] Create build.sh
[x] Create test.sh
[x] Implement GitHub Action to run build.sh and test.sh
[x] Automate GitHub Action to run on pull request
[x] Readme has a status badge
[x] Ensure Workflow is Correct

Fixing time allocation.
Sprint 3.
{t:360}


ls-remote and install many times to run

I used the latest version of nvm.
When nvm ls-remote, i must run 4 times this command then get 3 times result 'N/A' and a result valid.
Similar for nvm install <version> (4times-3f-1ok), but take too-long time to finish.
Pls check this and resolve. Thank you!

@dunght160387 how did you install nvm? What does nvm debug print out? Can you provide a full gist of running nvm ls-remote multiple times? What does curl --verbose https://nodejs.org print out?


User should be able to configure on-premise private registries in Kitematic configuration.

User should be able to configure on-premise private registries in Kitematic configuration. At present, user is not able to configure on-premise private registries. Not sure whether you are allowing docker registry enterprise configuration to pull images from private registries.

+1 for this. Rather... +9000!

:+1:

:+1:

+1000

:+1:

Although it's not very well document, as support isn't 100% yet, Kitematic does check for local environment endpoints before using it's hard-coded path.
One could set its registry as such and Kitematic would read from it:
export REGHUB2_ENDPOINT="http://my.repo.docker"

We're going to need this big time @FrenchBen. Especially if we get Docker Trusted Registry.  It would help to be able to "add a registry" as a config setting.. or "change default registry"...   Please consider that as i'd like to deploy docker images for all Splunk demos for employees, partners.. and maybe even the public.

@michaelwilde I actually made this possible in this PR https://github.com/kitematic/kitematic/pull/1076
Just need someone to help QA ;)

@FrenchBen ... you know I'll help.  What do i do?

@michaelwilde
Clone the repository:
git clone https://github.com/FrenchBen/kitematic/
Use the private-repo branch (https://github.com/FrenchBen/kitematic/tree/private-repo)
npm install
npm start
You should be able to navigate to the preference panel where you can update the link to the docker hub of choice.

Hi FrenchBen,
I am very new to docker, but I think I managed to test this, but I get error message "Registry does not exists or is down". But I can access my registry using browser ssl enabled and currently I am not using any authentication on registry. Hope this helps you or help me to proceed further.
/Bala.

@FrenchBen
I also get Registry does not exist or is down running the private-repo branch on https://github.com/FrenchBen/kitematic/ against my Docker Trusted Registry instance.
The problem appears to be src/utils/RegHubUtil.js  lines 30-37 which assumes the private registry will have a repository named debian.  My private registry does not have a registry named debian, so this check fails.
According to the Docker Registry HTTP API v2, we might GET /v2/ and verify a 200 response code.

@steve-jansen good point - I thought the check would work as debian is a pretty common image. What I didn't realize is that a lot of the registry API calls will be different and thus the branch isn't going to work as expected. There's a lot more work to be done to get this working properly.

I can also see a use case for "multiple registries"... say we have a private one for internal stuff at Splunk, using Kite.. i might want to be able to see the one's I am allowed to use, AND the one at hub.docker.com/v2
Y'all definitely want to get it working with DTS for for sure. Liking the direction.

@michaelwilde Absolutely! I see it as something like yum repos, where multiple channels can be added allowing for a greater range of images to be selected.

@FrenchBen any chance you can raise this to a higher priority.  Close to becoming a customer.  Will require Kitematic + DTR.

Hows the progress?  Any movement on DTR in Kitematic?

+1

bump.

Closing in favor of #210


2 in 1 sensor pir and lux

Prerequisites:

Before requesting a device addition, please ensure there is not already a request for the device among the open issues.
Make sure your Homey is upgraded to firmware v5 or higher.
You need a physical example of the device

Device Name: motion sensor
Device Model: zg-204zl
Device Description: motion sensor with light srnsor
Link to device image: Ik heb net dit geweldige item op AliExpress gevonden. Bekijk het nu! €5,76 | Tuya 2 In 1 Zigbee Mini Pir Bewegingsmelder + Heldere Lux Licht Passieve Infrarood Beveiliging Inbraakalarm Sensor
https://a.aliexpress.com/_EQ0EWb5
Device Interview:
"ids": {
"modelId": "TS0601",
"manufacturerName": "_TZE200_3towulqd"
},
"endpoints": {
"endpointDescriptors": [
{
"endpointId": 1,
"applicationProfileId": 260,
"applicationDeviceId": 1026,
"applicationDeviceVersion": 0,
"_reserved1": 1,
"inputClusters": [
0,
3,
1280,
57346,
61184,
60928,
57344,
1,
1024
],
"outputClusters": []
}
],
"endpoints": {
"1": {
"clusters": {
"basic": {
"attributes": [
{
"acl": [
"readable"
],
"id": 0,
"name": "zclVersion"
},
{
"acl": [
"readable"
],
"id": 1,
"name": "appVersion"
},
{
"acl": [
"readable"
],
"id": 2,
"name": "stackVersion"
},
{
"acl": [
"readable"
],
"id": 3,
"name": "hwVersion"
},
{
"acl": [
"readable"
],
"id": 4,
"name": "manufacturerName"
},
{
"acl": [
"readable"
],
"id": 5,
"name": "modelId"
},
{
"acl": [
"readable"
],
"id": 7,
"name": "powerSource"
},
{
"acl": [
"readable",
"writable"
],
"id": 18,
"name": "deviceEnabled"
},
{
"acl": [
"readable"
],
"id": 16384,
"name": "swBuildId"
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision"
}
]
},
"identify": {
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"iasZone": {
"attributes": [
{
"acl": [
"readable"
],
"id": 0,
"name": "zoneState",
"value": "notEnrolled"
},
{
"acl": [
"readable"
],
"id": 1,
"name": "zoneType",
"value": "motionSensor"
},
{
"acl": [
"readable"
],
"id": 2,
"name": "zoneStatus",
"value": {
"type": "Buffer",
"data": [
0,
0
]
}
},
{
"acl": [
"readable",
"writable"
],
"id": 16,
"name": "iasCIEAddress",
"value": "00:12:4b:00:18:dd:6a:73"
},
{
"acl": [
"readable"
],
"id": 17,
"name": "zoneId",
"value": 0
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"powerConfiguration": {
"attributes": [
{
"acl": [
"readable"
],
"id": 0
},
{
"acl": [
"readable"
],
"id": 32,
"name": "batteryVoltage",
"value": 33
},
{
"acl": [
"readable"
],
"id": 33,
"name": "batteryPercentageRemaining",
"value": 200
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
},
"illuminanceMeasurement": {
"attributes": [
{
"acl": [
"readable"
],
"id": 0,
"name": "measuredValue",
"value": 1000
},
{
"acl": [
"readable"
],
"id": 1,
"name": "minMeasuredValue",
"value": 0
},
{
"acl": [
"readable"
],
"id": 2,
"name": "maxMeasuredValue",
"value": 4000
},
{
"acl": [
"readable"
],
"id": 65533,
"name": "clusterRevision",
"value": 1
}
],
"commandsGenerated": "UNSUP_GENERAL_COMMAND",
"commandsReceived": "UNSUP_GENERAL_COMMAND"
}
},
"bindings": {}
}
}
}
Additional Comments:
[Provide any other relevant information or requests related to the device. Link to where you bought the device can be of help]
How to interview a device:

Add the device as a generic Zigbee device in Homey
Navigate to https://developer.athom.com/tools/zigbee.
Interview the device, the button for this is to the right of the device in the list of Zigbee units.
Click the copy button/icon to capture the device information.
Paste the copied information above.

Note: To be able to add more devices to the Tuya Zigbee app, we rely on community members like you to provide interviews of the devices you want added. Thank you for your contribution!

Related: #208 #368 #380

Added to next release, thanks to @demyvdj 😎

Thats awesome!

Is it possible to test in 0.2.18, @JohanBendz?

This is what i get after i added my sensor to Homey. I tryd several times.

@avanderwulp: There is an issue on it at https://github.com/JohanBendz/com.tuya.zigbee/issues/715


update install page with link to binaries

For OS X and Linux, Download the Binary needs a valid link.
@bdarnell, @mberhault: When do you think OS X and Linux binaries will be ready, and where will we host them for user download?

we can have them ready anytime you like, we just need to decide how often to rebuild them and how. If it's manual, we can easily build and push to www.cockroachlabs.com. If it's automated, we may be better off putting them in AWS.

Should we distribute i386 and amd64 binaries?
On Mon, Feb 8, 2016 at 2:21 PM, marc<EMAIL_ADDRESS>wrote:

we can have them ready anytime you like, we just need to decide how often
to rebuild them and how. If it's manual, we can easily build and push to
www.cockroachlabs.com. If it's automated, we may be better off putting
them in AWS.
—
Reply to this email directly or view it on GitHub
https://github.com/cockroachdb/docs/issues/34#issuecomment-181459112.

According to a note in CONTRIBUTING.md, we only support 64-bit builds. I'm not sure what the issue is, but it seems safe to go 64-bit only.

Good to know we're ready whenever. @jess-edwards and I are planning to do a soft-release of the docs as early as next week, so can you guys choose a location, push them there, and post links here by Monday or Tuesday?

ok, finally getting back to this. I'll be tweaking various S3 paths and naming schemes, so I'll probably be breaking some of my nightly scripts, but here's a proposal for the ultimate goal:

build linux/osx binaries for every master commit that passes the tests
build a tarball containing only the binary (eg: expands to cockroach/cockroach.linux.amd64)
push tarball to S3 bucket: binaries.cockroachdb.com with sha included in the filename
update a fixed filename in S3 to redirect to the SHA-based name. eg: binaries.cockroachdb.com/cockroach.linux.amd64.tgz redirects to binaries.cockroachdb.com/cockroach..linux.amd64.tgz
setup S3 bucket binaries.cockroachdb.com with static website hosting (allows redirects to work)
setup cloudfront to serve binaries.cockroachdb.com using AWS-generated SSL certs. this should make https://binaries.cockroachdb.com/ work properly with a recognized CA.

The download page will simply link to the fixed binary name (the redirect should take care of going to the right one). eg:

https://binaries.cockroachdb.com/cockroach.linux.amd64.tgz
https://binaries.cockroachdb.com/cockroach.darwin10.9.amd64.tgz

ok, the redirect doesn't work so well with cloudfront. I may have to write to the final filename right away (eg: upload directly to s3://binaries.cockroachdb.com/cockroach.linux-amd64.tgz). The only issue here is what happens when concurrent circle-ci runs step all over each other. S3 will usually drop one of them but can sometimes result in an empty file.

Excellent. Thanks very much, @mberhault! I'll add those links in today.

we'll also need to change the instructions. the downloads tar gzipped tarballs, so people will need to do the following:

click on the link to download
extract the tarball: $ tar xfz cockroach.linux-amd64.tgz
move to the directory: $ cd cockroach/
run the binary: $ ./cockroach ...

no chmod needed.

@mberhault, when I extract the tarball, the directory created is called cockroach and the binary inside is given the same name as the tarball. It seems unnecessarily complicated to run a binary called ./cockroach.darwin-10.9-amd64 start.
@bdarnell suggested that we should be doing the opposite: extracting the tarball should create a directory with the same name as the tarball, but the binary in that directory should just be cockroach. Can you change that behavior?

ok. will do.

Renamed the binary per suggestions. We now have:
cockroach.darwin-10.9-amd64/cockroach
and:
cockroach.linux-amd64/cockroach
Leaving open since this about docs, not the binaries themselves.

oh, and it may take a little while for the new binaries to be effective, cloudfront caching is a little pesky.

Thanks, Marc.

Resolved with PR #113


fix: use dfn instead of code tag

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

I've noticed this problem in some other sections - maybe this is intended? However, the style guide states that the dfn tag should be used.

@ojeytonwilliams should I change this in other files as well?

@SomeDer Feel free! It's more semantic HTML and, as you say, it's in the style guide.

@SomeDer Thanks for all your hard work on this.  Please let me know when you've made all your changes and I'll go through them.

@ojeytonwilliams this is ready for review now.

As I am reviewing the conversions of <code> to <dfn>, I am realizing many of the words which were surrounded by code, should not have been in the first place.  This means many don't need the <dfn> either.  The <dfn>tag is only supposed to be used when a term is defined the first in a phrase or sentence.  I am seeing the use of <dfn> for words which are not defining anything.  Below is an example which is using <dfn> and does not define anything.

First, you'll start by building a simple web page using HTML. You can edit code in your code editor, which is embedded into this web page.

code and code editor are not being defined here, so there is no need to be wrapped in the dfn tags.  The same goes for most of the words which have been wrapped with dfn.  I believe whoever originally wrapped many of these words in code tags might have been doing it for emphasis or just got carried away with code tags.  Either way, we should be using the dfn tag only where applicable and not just replacing code tags with dfn which do not define the words.

@SomeDer Also, it would make it easier to review and see changes (via other commits) if you first squash all the existing 76 commits into a single commit and then add additional commits to fix the issue I mention above.  Thank you.

@RandellDawson are you happy with the changes?  Let me know and I'll give it another look.

Actually, I shouldn't have removed that label.  @SomeDer, when you have a moment, could you address @RandellDawson's comments?

@ojeytonwilliams I've fixed most of the suggestions. I didn't fix the one @RandellDawson said should be left for now, and I've also left comments on some of them, suggesting possible alternatives - can you please take a look and say what you think?

@SomeDer Can you fix the merge conflicts and then I can give this PR one last review? Thanks.

@SomeDer If you can address the most recent comments I made above, then I think we can get this merged.

@SomeDer Thanks for all the work you put into this PR.
We're happy to accept these changes, and look forward to future contributions. 🎉


Expected at least one value for header content-length

springweb 6.1.15 and 6.2.1
spring cloud gateway 4.1.6
springboot 3.3.6
springcloud 2023.0.4
Error Message :
Failed toString() invocation on an object of type [org.springframework.http.ReadOnlyHttpHeaders]
Expected at least one value for header content-length
Phenomenon :
when i extract response headers with this method, exchange.getResponse.getHeaders(), i faces that error. So, i debugged and i found "toCaseInsensitiveSet" method made root cause. it has one param called Set originSet. when i debugged it doesnt have content-length, but suddenly i appeared when for iteration. So, the method returns headers with content- length.  And then "formatHeaders" method took the returned headers. now this method has two headers group. one original headers and one headers from "toCaseInsensitiveSet" method. now, comparision started but, as i said, original headers doesnt have content-length but another headers has. Then it makes error.
one more thing!!! it happened without debug checkpoint... when i set some checkpoints on headers, i cant watch content-length was added.
sorry this captured image. i can not copy this code for some reason....

cc.
@khkkhk4095

Please describe how to replicate your issue. The code you've showed is all spring framework and does not live in gateway

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.


Disk storage

What
Deploy limitador with disk (persistent) storage.
Simplest deployment option for disk storage
apiVersion: limitador.kuadrant.io/v1alpha1
kind: Limitador
metadata:
  name: limitador-sample
spec:
  storage:
    disk: {}

TODO:

[x] Doc
[x] Fix existing tests
[x] Add new tests
[x] Discuss about replicas

Verification Steps
Simplest deployment
dev setup
make local-setup

Deploy the limitador CR with storage set to disk
k apply -f - <<EOF
---
apiVersion: limitador.kuadrant.io/v1alpha1
kind: Limitador
metadata:
  name: limitador-sample
spec:
  storage:
    disk: {}
EOF

Check deployment is correct
kubectl wait --timeout=300s --for=condition=Ready limitador limitador-sample

Should return
limitador.limitador.kuadrant.io/limitador-sample condition met

Check command line
kubectl get deployment/limitador-sample  -o yaml | yq '.spec.template.spec.containers[0].command'

should look like this
- limitador-server
- /home/limitador/etc/limitador-config.yaml
- disk
- /var/lib/limitador/data

By default, 1Gi persistent volume is booked for limitador
kubectl get pvc

Should get
NAME                         STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
limitador-limitador-sample   Bound    pvc-3296fc91-8f2d-4f8a-b24b-3cba99304abe   1Gi        RWO            standard       28s

Codecov Report

Merging #96 (1bbfc55) into main (3ddcadc) will decrease coverage by 15.63%.
The diff coverage is 18.32%.

:exclamation: Current head 1bbfc55 differs from pull request most recent head 2d2ecf7. Consider uploading reports for the commit 2d2ecf7 to get more accurate results

@@             Coverage Diff             @@
##             main      #96       +/-   ##
===========================================
- Coverage   51.78%   36.15%   -15.63%
===========================================
  Files          12       14        +2
  Lines         867      979      +112
===========================================
- Hits          449      354       -95
- Misses        377      584      +207
  Partials       41       41

Flag
Coverage Δ

unit
36.15% <18.32%> (-15.63%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

api/v1alpha1/limitador_types.go
100.00% <ø> (ø)

pkg/limitador/disk_storage_options.go
0.00% <0.00%> (ø)

pkg/limitador/inmemory_storage_options.go
0.00% <0.00%> (ø)

pkg/limitador/k8s_objects.go
13.65% <0.00%> (-58.07%)
:arrow_down:

pkg/limitador/redis_cache_storage_options.go
0.00% <0.00%> (ø)

pkg/limitador/redis_storage_options.go
0.00% <0.00%> (ø)

pkg/reconcilers/base_reconciler.go
33.92% <0.00%> (-0.62%)
:arrow_down:

pkg/limitador/deployment_options.go
31.42% <31.42%> (ø)

pkg/reconcilers/deployment.go
17.39% <36.84%> (-4.53%)
:arrow_down:

controllers/limitador_controller.go
52.58% <50.90%> (+8.03%)
:arrow_up:

... and 4 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.

ready for review @Kuadrant/engineering

Took me a little while to go through all the changes here but I've run through the verification and the code. I think it looks good from my side but perhaps you'd prefer a second review.

Thanks @adam-cattermole
Sorry for the "too big" PR. I refactored the options to have a cleaner deployment objects. I think that the outcome is a better code to extend and maintain.
There is no rush. Let's wait for the review from @didierofrivia

rebased to fix merge conflicts (in the CSV)


Allow the crosschain account state to be compatible with MainNet acco…

…unt state
Signed-off-by: Peter  Robinson<EMAIL_ADDRESS>

PR description
Fixed Issue(s)

Signed-off-by: Peter Robinson<EMAIL_ADDRESS>Allow the crosschain account state to be compatible with MainNet account state.


Two-Chainz silent failure on unconventional gaia setup

When running ./two-chainz, there will be a silent failure if the user does not have the origin remote setup (on their gaia repo) or has their origin remote pointing to a different repo (a fork) other than github.com/cosmos/gaia. It silently fails because the output is being directed to /dev/null
Unlikely scenario, but I figured I'd open an issue in case someone runs into this issue. One side effect of this failure is the data/ directory not being created and filled.

@colin-axner would love to see a PR to fix this issue! Also 👋 good to see you here!


fix: update platform pattern for k9s

See https://github.com/derailed/k9s/pull/1910

Thanks for the ping.
Fixed directly in https://github.com/looztra/asdf-k9s/pull/25 as the plugin is not based anymore on the cookie cutter template (my bad, doc updated).
Hard for plugin maintainer to deal with tools that change the released artifacts during the lifetime of the product :(


feat: modularize the runtime layer

Description of changes

In an effort to decrease binary size, this PR modularizes the runtime layer into three targets, runtime, xmlruntime and jsonruntime. this way xml pieces never find their way into json sdks and vice versa.
Corresponding PR: https://github.com/awslabs/aws-sdk-swift/pull/528
Scope

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing due to abandonment.


Generate version constants file

I've encountered a few instances where it is useful to have the package version number available in code whether that library was imported as a package or not. I'd like to add an optional module to package manifest that enables generation of a static VersionConstants class file when the semver of the package is updated.

This was accomplished in v1.3.0 https://github.com/jeffcampbellmakesgames/unity-package-tools/releases/tag/upm%2Fv1.3.0


Hovering stars/installs causes weird drop down menu to appear

I'm using Chrome and can see this on the homepage and /apps page. Not a huge deal, just looks kind of weird.
cc/ @JasonEtco

Fascinating. I'll take a look, thanks @hiimbex 👍

Looks like this is caused by the overflow: hidden I put on the app card ☹ . Solutions:

Undo this change and apply the same border-radius as the app card has to the bottom of the bottom bar.
Change the orientation of the tooltips (n? w for the left two and e for the ones on the avatars?)

@j-f1 it looks like just removing overflow: hidden does the trick. Do you want to make that PR?


Raspotify fails to loop song

So here is something I noticed while installing Raspotify. If I am on my Android device and I select a song and I try to select it to loops forever (Spotify has that option), I can't do it on my Raspotify connection. I can still do it if I run spotify on my phone but not on the device where raspotify is installed.

for me looping is ignored, no matter how i set it... running on raspian on an pi3b


Several examples do not work (missing lib/require.js)

Hi,
Several examples do not work because the require.js file can't be found:

https://pissang.github.io/qtek/example/gltf2.html
https://pissang.github.io/qtek/example/IBL.html
https://pissang.github.io/qtek/example/standard_material.html

No directory of lib exists with the required Require.js file.
    <head>
        <meta charset="utf-8">
        <meta name="viewport" content="width=device-width, initial-scale=1" />
        <script type="text/javascript" src="lib/require.js"></script>
    </head>

Possible other files that are missing the lib folder can be found using the following search query:
https://github.com/pissang/qtek/search?utf8=✓&q=%2Flib%2Frequire.js&type=
Thank you for the great library, it has been a great inspiration.
Tim

Thanks for the feedback!! The lib folder was ignored unexpectedly. Just submitted the lib folder and the examples work well now.

Oh great, I'll close my pull request.
Thanks 👍


Revert "Add support for .list without changing current API"

Reverts roylines/node-credstash#21

Hello, can you let me know why this was reverted? Thanks

It failed to build on circleci. I'll take a look, but I'm in vacation for a
few days more. If you want to look at the failed build on circleci please
do.
On Mon, 26 Dec 2016, 17:56 Jason Morita<EMAIL_ADDRESS>wrote:

Hello, can you let me know why this was reverted? Thanks
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/roylines/node-credstash/pull/22#issuecomment-269231069,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNk_OHwhxkJiSY-0uDtm7qi9W9i1cQsks5rL__ngaJpZM4LVrtz
.

--
Roy Lines
@roylinesuk

You can see the failed build here.
https://circleci.com/gh/roylines/node-credstash/28
On Mon, 26 Dec 2016, 18:15 Roy Lines<EMAIL_ADDRESS>wrote:

It failed to build on circleci. I'll take a look, but I'm in vacation for
a few days more. If you want to look at the failed build on circleci please
do.
On Mon, 26 Dec 2016, 17:56 Jason Morita<EMAIL_ADDRESS>wrote:
Hello, can you let me know why this was reverted? Thanks
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/roylines/node-credstash/pull/22#issuecomment-269231069,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNk_OHwhxkJiSY-0uDtm7qi9W9i1cQsks5rL__ngaJpZM4LVrtz
.
--
Roy Lines
@roylinesuk

--
Roy Lines
@roylinesuk


Download golangci-lint instead of installing it in a vendored environment

Among the consequences of vendoring dependencies is the fact that we cannot go install any package from the internet.
We have to either:

list the code of the package as a dependency and vendor it, even though the operator does not use it, or;
install the binary we need through other means.

This PR installs golangci-lint by downloading it from the GitHub release.

why have you changed it to a PATH location instead of under the project?

@yevgeny-shnaidman not sure I understand your comment. The binary still goes into the same bin directory.


Typo in distributed version

While I was debugging, I spotted a small typo. 😉
https://github.com/oe/truncate-html/blob/master/dist/truncate.es.js#L2
https://github.com/oe/truncate-html/blob/master/dist/truncate.cjs.js#L2
The source of the mistake is here: https://github.com/oe/truncate-html/blob/master/rollup.config.ts#L12

Thanks for reporting😄
I'll update npm package  after fixing #31


setgenerate command crashes the qt-wallet

Hi team
Today, after having installed and synchronized the wallet, I wanted to start mining DeviantCoin using the QT client. I opened the Debug window and typed "setgenerate true 32" and after a couple if seconds the wallet crashed.
Can you please help? I would like to mine DeviantCoin.
Thanks

Hi,
It's a POS coin, not a POW, you need coins for stake or creating MN


Block upgrading partner chart to a feature chart repo

Setup
Rancher version: 2.6-head 56f0c2d
Browser type & version: Chrome
Describe the bug
When we install an app from a partner chart repo, we can upgrade the same chart via feature charts if the chart also exists in the feature charts default repo.
To Reproduce

Create a cluster 3 worker, 1 etcd, 1cp [required spec as I tested with istio app]
From the cluster's apps & market >> Repositories >> create a repo [ I forked feature charts to my repositories. If needed can make use of this https://github.com/anupama2501/charts ]
Select the option Git repository containing Helm chart or cluster template definitions, Git repo URL :https://github.com/anupama2501/charts and branch:dev-v2.6 , name:test
Once the repo is active, navigate to charts and from the chart repos drop down select test
Install monitoring any version and install istio version 1.9.6
Once the app is installed, from the charts page select Rancher repo from the drop down
Navigate to istio chart and select the version 100.2.0+up1.12.6 which is not present in the test repo versions of istio.

Result
Chart upgrades successfully and partner chart is upgraded to feature chart
Expected Result
Disallowing the upgrade of partner charts to feature charts

As a note to docs, the release note label here is if we can't get this in for 2.6.5.

Need to push to 2.6.6. Still need to document this for 2.6.5.


ng-template  tag conflicts with ngdialog

Hi,
could we have some alternative of ng-template script tag for selector since there are issues integrating ngdialog box with angular selector .
below is the plunker for your reference
http://plnkr.co/edit/LTqFbqiRsf27ZZUH02nY?p=preview

I resolved it by seperating ng dialog container and multiselect container into different html components by using custom serverside components containers like multiselect.html and modalovelay.html and passing scope thorugh it !


Telemetry for different number based items should be fixed to pass a property

These 3 in particular are sending a count as the 'duration'

DATASCIENCE.NATIVE.WORKSPACE_NOTEBOOK_COUNT
DATASCIENCE.NATIVE.NOTEBOOK_RUN_COUNT
DATASCIENCE.NATIVE.NOTEBOOK_OPEN_COUNT

We should also skip sending those if they're zero? Whatever the PMs decide. They shouldn't be sent for every user I'd say.

would like to send

DATASCIENCE.NATIVE.WORKSPACE_NOTEBOOK_COUNT for those who have notebooks in the workspace
DATASCIENCE.NATIVE.NOTEBOOK_RUN_COUNT for those who have run cells in the notebook editor
DATASCIENCE.NATIVE.NOTEBOOK_OPEN_COUNT for those who have opened the notebook editor

Meaning skip sending them if the count is zero.

@ronglums do you want to send this periodically instead of on VS shutdown?

yes and shutdown is fine as that gives us a number for the whole session.

For some reason I'm not seeing this in the debug console when I turn on the logging. But I can debug in and see the event firing with undefined for measures and count: X in the properties object. So validated.


Additional Fields in ProbeScanResult

Please add the following fields to the ProbeScanResult data class that is emitted by the ProbeScanner when it finds probes.

Add Bluetooth MAC Address
Add Bluetooth RSSI

Added the additional fields in v0.4.0 release.  Tested using the sample code in the Open Source Example App.


Add pubspec.lock to git

Description
The flutter Orb's install_sdk_and_pub will try and use the lock file for the cache. Our CI is always failing on that step, even though it doesnt fail our build.

This PR ensures the Orb can correctly generate the cache.
However, as the dart documentation mentions the following:

The lockfile is generated automatically for you by pub when you run pub get, pub upgrade, or pub downgrade. If your package is an application package, you will typically check this into source control. For library packages, you usually won’t.

 @Widcket @stevehobbsdev ? If not, the CI step will continue to fail (but wont fail our build)
Checklist

[x] I have added documentation for new/changed functionality in this PR or in auth0.com/docs
[x] All active GitHub checks for tests, formatting, and security are passing
[x] The correct base branch is being used, if not master

cc @adamjmcgrath

Codecov Report

Merging #127 (05e084e) into main (7f36c91) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #127   +/-   ##
=========================================
  Coverage     94.63%   94.63%
  Complexity       49       49
=========================================
  Files            39       39
  Lines           615      615
  Branches         33       33
=========================================
  Hits            582      582
  Misses           27       27
  Partials          6        6

Flag
Coverage Δ

auth0_flutter
100.00% <ø> (ø)

auth0_flutter_android
91.39% <ø> (ø)

auth0_flutter_platform_interface
99.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f36c91...05e084e. Read the comment docs.

We tend to check in our lock files for our JS SDKs, even when they're not strictly needed.
Wether they're needed or not is usually quite nuanced (eg does the SDK bundle its runtime dependencies, is it transpiled) - so we just go for checking them in for everything for simplicity's sake. This is probably why the Orb works like that.
I think this PR is fine, if you really don't want to check in the lock files we could update the orb to optionally use the package.json (or whatever the equivalent is on flutter) or use the package.json as a fallback if the lock is not found.

we could update the orb to optionally use the package.json (or whatever the equivalent is on flutter) or use the package.json as a fallback if the lock is not found.

Note that this is a Dart library, so the orb won't have to be updated (until we modify it for Dart packages).


Module map file '/Library/Developer/Xcode/DerivedData//Build/Products/Debug-iphonesimulator/amplitude-react-native/amplitude_react_native.modulemap' not found

When I try to build using Xcode (v12.4), I get the error
Module map file '<home>/Library/Developer/Xcode/DerivedData/<appname>/Build/Products/Debug-iphonesimulator/amplitude-react-native/amplitude_react_native.modulemap' not found

But I can run react-native run ios fine. How can I fix this build error in Xcode?

Hi @denniswon
When you try to build in Xcdoe did you open xxx.xcworkspace instead of xxx. xcodeproj?

Yes. Resolved it, and forgot about this. xcworkspace resolved it. thanks

I have this error in appcenter when building the app. In my local environment works fine. Any solution?


Subpackage vendoring issue

What version of Go are you using (go version)?

go version go1.6.1 linux/amd64

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT="1"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"

Linux serenity 4.3.0-1-amd64 #1 SMP Debian 4.3.5-1 (2016-02-06) x86_64 GNU/Linux
Running golang with Docker image, official golang build, latest image from docker hub.
Full reproduction script available with ./run
Source files: https://cdn.si/assets/go-gh-issue-vendoring.tgz

What did you do?

I created a small program, using a local subpackage.
main.go (using a subpackage + vendor) = experienced problem.
main2.go (using vendored import from main) = works as expected.
Subpackage is imported with: import "./apiservice". Import of vendored package from this subpackage results in a run/build error.
Also included is a test-runner using the official golang docker image. It's the same environment, that I'm running the example in. The folder vendor was created with gvt fetch github.com/namsral/flag, full source provided.

What did you expect to see?

Expected output with main.go:
# go run main2.go
Hello world! Network port: 8080

What did you see instead?

# go run main.go
apiservice/apiservice.go:4:8: cannot find package "_/go/src/app/vendor/github.com/namsral/flag" in any of:
        /usr/local/go/src/_/go/src/app/vendor/github.com/namsral/flag (from $GOROOT)
        /go/src/_/go/src/app/vendor/github.com/namsral/flag (from $GOPATH)

Problem:
Import path for local subpackage is not honored. The dot gets converted to underscore, and as a consequence, it's looking for the vendor directory in the wrong path:
Expected path:
        /usr/local/go/src/app/vendor/github.com/namsral/flag (from $GOROOT)

Your need to put your source in GOPATH. From the example you posted (sorry
I haven't run your script) you have not done this.
On Thu, 28 Apr 2016, 19:33 Tit Petric<EMAIL_ADDRESS>wrote:

What version of Go are you using (go version)?

go version go1.6.1 linux/amd64

What operating system and processor architecture are you using (go
env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/go"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GO15VENDOREXPERIMENT="1"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0"
CXX="g++"
CGO_ENABLED="1"
Linux serenity 4.3.0-1-amd64 #1 https://github.com/golang/go/issues/1
SMP Debian 4.3.5-1 (2016-02-06) x86_64 GNU/Linux
Running golang with Docker image, official golang build, latest image from
docker hub.
Full reproduction script available with ./run
Source files: https://cdn.si/assets/go-gh-issue-vendoring.tgz

What did you do?

I created a small program, using a local subpackage.
main.go (using a subpackage + vendor) = experienced problem.
main2.go (using vendored import from main) = works as expected.
Subpackage is imported with: import "./apiservice". Import of vendored
package from this subpackage results in a run/build error.
Also included is a test-runner using the official golang docker image.
It's the same environment, that I'm running the example in. The folder
vendor was created with gvt fetch github.com/namsral/flag, full source
provided.

What did you expect to see?

Expected output with main.go:
go run main2.go
Hello world! Network port: 8080

What did you see instead?

go run main.go
apiservice/apiservice.go:4:8: cannot find package "/go/src/app/vendor/github.com/namsral/flag" in any of:
/usr/local/go/src//go/src/app/vendor/github.com/namsral/flag (from $GOROOT)
/go/src/_/go/src/app/vendor/github.com/namsral/flag (from $GOPATH)
Problem:
Import path for local subpackage is not honored. The dot gets converted to
underscore, and as a consequence, it's looking for the vendor directory in
the wrong path:
Expected path:
    /usr/local/go/src/app/vendor/github.com/namsral/flag (from $GOROOT)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/15478

@davecheney I've been putting it in GOROOT, I updated now to use GOPATH, same issue persists.
#!/bin/bash
printf "Expected:\n\n"
docker run --rm -it -v `pwd`:/go/src/app -w /go/src/app golang go run main2.go
printf "\nActual:\n\n"
docker run --rm -it -v `pwd`:/go/src/app -w /go/src/app golang go run main.go

# ./run_gopath
Expected:

Hello world! Network port: 8080

Actual:

apiservice/apiservice.go:4:8: cannot find package "_/go/src/app/vendor/github.com/namsral/flag" in any of:
        /usr/local/go/src/_/go/src/app/vendor/github.com/namsral/flag (from $GOROOT)
        /go/src/_/go/src/app/vendor/github.com/namsral/flag (from $GOPATH)

So, sorry, no. I also tried putting everything in /go instead of /go/src/app but that breaks both examples.

I belive GOPATH is not set in your enviroment correctly. I believe this
because of the leading _/ in the error report. This is the path that the go
tool uses when source is outside GOPATH or GOPATH is not set correctly.
If GOPATH is not set correctly, vendoring will not be used.
Is it possible to isolate your issue by removing docker?
On Thu, Apr 28, 2016 at 8:10 PM, Tit Petric<EMAIL_ADDRESS>wrote:

@davecheney https://github.com/davecheney I've been putting it in
GOROOT, I updated now to use GOPATH, same issue persists.
#!/bin/bash
printf "Expected:\n\n"
docker run --rm -it -v pwd:/go/src/app -w /go/src/app golang go run main2.go
printf "\nActual:\n\n"
docker run --rm -it -v pwd:/go/src/app -w /go/src/app golang go run main.go
./run_gopath
Expected:
Hello world! Network port: 8080
Actual:
apiservice/apiservice.go:4:8: cannot find package "/go/src/app/vendor/github.com/namsral/flag" in any of:
/usr/local/go/src//go/src/app/vendor/github.com/namsral/flag (from $GOROOT)
/go/src/_/go/src/app/vendor/github.com/namsral/flag (from $GOPATH)
So, sorry, no. I also tried putting everything in /go instead of
/go/src/app but that breaks both examples.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/15478#issuecomment-215376603

I don't have an environment outside of docker where I can run the tests. If I get one, I'll post the results, and if you have one, please just stick the sources from the tgz into $GOPATH/src/app and run go run main.go to see if the error occurs with you.
But, my sanity check here tells me that you shouldn't be so suspicious, go env reports /go (same as $GOPATH in bash), sources don't reference some /other or ../other locations. I might be quite new at this, but I'm pretty sure that nowhere in about 10-20 lines of code I'm going outside of GOPATH, and I'm not touching it in any way. The obvious question is "what's the correct way to set up GOPATH?" if the official docker image doesn't do this. Source Dockerfile is here, if you can spot the issue: https://github.com/docker-library/golang/blob/master/1.6/Dockerfile
I'll attach my results if I can get my hands on on a local install of go somewhere.

You shouldn't need docker to compile your tests -- they may not pass, but
you'll at least confirm that you can compile your code.
On Thu, Apr 28, 2016 at 8:28 PM, Tit Petric<EMAIL_ADDRESS>wrote:

I don't have an environment outside of docker where I can run the tests.
If I get one, I'll post the results, and if you have one, please just stick
the sources from the tgz into $GOPATH/src/app and run go run main.go to
see if the error occurs with you.
But, my sanity check here tells me that you shouldn't be so suspicious, go
env reports /go (same as $GOPATH in bash), sources don't reference some
/other or ../other locations. I might be quite new at this, but I'm
pretty sure that nowhere in about 10-20 lines of code I'm going outside
of GOPATH, and I'm not touching it in any way. The obvious question is
"what's the correct way to set up GOPATH?" if the official docker image
doesn't do this. Source Dockerfile is here, if you can spot the issue:
https://github.com/docker-library/golang/blob/master/1.6/Dockerfile
I'll attach my results if I can get my hands on on a local install of go
somewhere.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/15478#issuecomment-215380064

I just checked out your sample. Sorry I should have done that before.
The root cause is you are using go run, which does not support vendoring.
I recommend you lay out your code in the prescribed package format as
documented here https://golang.org/doc/code.html
Then compile and run your program.
On Thu, Apr 28, 2016 at 8:29 PM, Dave Cheney<EMAIL_ADDRESS>wrote:

You shouldn't need docker to compile your tests -- they may not pass, but
you'll at least confirm that you can compile your code.
On Thu, Apr 28, 2016 at 8:28 PM, Tit Petric<EMAIL_ADDRESS>wrote:

I don't have an environment outside of docker where I can run the tests.
If I get one, I'll post the results, and if you have one, please just stick
the sources from the tgz into $GOPATH/src/app and run go run main.go to
see if the error occurs with you.
But, my sanity check here tells me that you shouldn't be so suspicious, go
env reports /go (same as $GOPATH in bash), sources don't reference some
/other or ../other locations. I might be quite new at this, but I'm
pretty sure that nowhere in about 10-20 lines of code I'm going outside
of GOPATH, and I'm not touching it in any way. The obvious question is
"what's the correct way to set up GOPATH?" if the official docker image
doesn't do this. Source Dockerfile is here, if you can spot the issue:
https://github.com/docker-library/golang/blob/master/1.6/Dockerfile
I'll attach my results if I can get my hands on on a local install of go
somewhere.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/15478#issuecomment-215380064

I'm having the same result with go build, but I'll check the layout extensively. I followed the recommended layout from glide - in the main README, which should be this:
$GOPATH(/go)/src/your-project
  |__ main.go (Where your main code lives)
  |__ subpackage/
  |     |__ subpackage.go (You can create subpackages)
  |     \__ ...
  |__ ... (Other files or subpackages)
  \__ vendor/
        |__ github.com/namsral/flag
        |__ github.com/gorilla/mux
        \__ ...

So if I understand you, instead of using "subpackage" I should create src/subpackage and use import "subpackage" as a replacement? I'm just about to go AFK into a meeting, and I'll try this asap. But it really seems that I shouldn't. Importing subpackages which reside in the same level is done with "./package", which is a documented thing somewhere. It actually works... at least some packages use a slightly different approach to structure the sources in the same way, with the double-slash import option:
package main // import "github.com/janeczku/go-dnsmasq"
import "github.com/janeczku/go-dnsmasq/hostsfile"

Is there a way to achieve something similar for local development without a recognized VCS location? I believed until now that: import "./package" was it.

Is there a way to achieve something similar for local development without
a recognized VCS location? I believed until now that: import "./package"
was it.

Yes, packages are just directories on disk. They follow the url based
convention to avoid namespace collision and to enable go get. You should
layout your code using the url based pattern, but there is no requirement
(unless you want someone else to go get your code) to push it to a remove
vcs location
On Thu, Apr 28, 2016 at 8:45 PM, Tit Petric<EMAIL_ADDRESS>wrote:

I'm having the same result with go build, but I'll check the layout
extensively. I followed the recommended layout from glide
https://github.com/Masterminds/glide - in the main README, which should
be this:
$GOPATH(/go)/src/your-project
|__ main.go (Where your main code lives)
|__ subpackage/
|     |__ subpackage.go (You can create subpackages)
|     __ ...
|__ ... (Other files or subpackages)
__ vendor/
|__ github.com/namsral/flag
|__ github.com/gorilla/mux
__ ...
So if I understand you, instead of using "subpackage" I should create
src/subpackage and use import "subpackage" as a replacement? I'm just
about to go AFK into a meeting, and I'll try this asap. But it really seems
that I shouldn't. Importing subpackages which reside in the same level is
done with "./package", which is a documented thing somewhere. It actually
works... at least some packages use a slightly different approach to
structure the sources in the same way, with the double-slash import option:
package main // import "github.com/janeczku/go-dnsmasq"
import "github.com/janeczku/go-dnsmasq/hostsfile"
Is there a way to achieve something similar for local development without
a recognized VCS location? I believed until now that: import "./package"
was it.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/15478#issuecomment-215384801

I think that currently local (relative) imports do not work with vendoring. I am not sure if it is even possible to make these features work together. Local imports do not work in some other cases as well (see for example http://stackoverflow.com/questions/10687627/relative-import-from-parent-directory).

@davecheney It is just slightly awkward if you're using go get to mix remote packages from github, etc, with whatever you have locally. main.go and package/package.go with import "./package" would seem like a valid usage pattern.
@kostya-sh That's unfortunate. I guess I'd mark this issue as a feature request then, I would very much like local imports to work with vendoring.

If anybody is coming here for a fix, this worked for me:

My app name is 'app' (/go/src/app),
instead of importing ./submodule, import app/submodule
Vendoring starts to work, everything works with go run.

I will not close this issue, just because I expect that this should be fixed in a future version. I hope someone agrees and tags/assigns the issue properly. Relative imports should work with vendoring, but I understand the motivations for FQDN imports. Considering that i'm using them from the main package, which is a reasonable "root" of the project, and if I'll ever reuse it from another package i would use the FQDN import from a VCS/other.


Adding front matter to more files

Some questions and script tasks:

[ ] How many files are there that are not named index.md and that don't end in .es or .pt (the english ones)?
[ ] How many are missing speakers from the front matter? Output an array of those file names so that we can manually improve
[ ] How many are missing media links? Output an array of those file names so that we can manually improve
[ ] For those without a date, how many have a year associated with them that can be parsed from the parent directory?
[ ] For those without tags, how many have pre-existing tags in the title?
[ ] For those without tags, can we run NLP on them and match them to our current tag list?

Here is some work that Peter did to come up with some of these counts.

How many files are there that are not named index.md and that don't end in .es or .pt (the english ones)?

The live count of our existing transcripts is always accessible in a JSON format at https://btctranscripts.com/status.json under transcripts. The current number for English transcripts is 1049.

How many are missing speakers from the front matter? Output an array of those file names so that we can manually improve
How many are missing media links? Output an array of those file names so that we can manually improve

This information is accessible for all fields in a JSON format at https://btctranscripts.com/status.json under missing


Generate static .keys property

Fixes #294

Hi @siarhei-murkou,
I have adjusted the .keys property as discussed to use an internal Symbol as key to make it unaccessible inside of handlers.
You can get an idea of which usage is allowed and which is not from the associated test file.
Please let me know if this covers the cases we were discussing.
Best,
Daniel