hotfix/safewalk -> dev

This change is

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, 9 unresolved discussions.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 38 at r1 (raw file):

            AccountInformation accountInformation = AccountInformation.fetch(SafeWalkMainActivity.this, AccountResolver.getAccount(SafeWalkMainActivity.this));
			phoneEditText = (EditText) findViewById(R.id.phone_number_edit_text);

Only the phone number loading needs to happen in this sync task. Do the rest outside of this lambda

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 52 at r1 (raw file):

        if (checkPhoneNumber()) {
            Intent intent = new Intent(this, SafeWalkMapActivity.class);
            intent.putExtra(SafeWalkMapActivity.EXTRA_PHONE_NUMBER, userPhoneNumber);

So this would work if they input 1-2-3-4-5-6-7-8-9-0-------------? And it would send that to the service?

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 67 at r1 (raw file):

            startActivity(intent);
        } else {
            //  Displays a dialog box prompting the user to enter in a 10 digit phone number.

No more dialog. Just make the edit text border red (or something like that to indicate that the need to edit it. Figure out what is the best Android way of validating edit texts)

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 73 at r1 (raw file):

            new AlertDialog.Builder(this).setTitle(R.string.invalid_phone_number)
                    .setMessage(R.string.safewalk_input_phone_dialog_message)
                    .setPositiveButton("OK", ((dialog, which) -> dialog.cancel()))

Wait... Does this dialog not even do anything?

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMapActivity.java, line 43 at r1 (raw file):

			} else if (!isInBoundaries(markerLocation)) {
				new AlertDialog.Builder(this).setMessage("Your destination falls outside the boundaries monitored by BYU police. In order to use Safewalk your destination must be within a mile of campus.")
						.setPositiveButton("OK", ((dialog, which) -> dialog.cancel())).show();

What is this line doing...?

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMapActivity.java, line 67 at r1 (raw file):

	}

	public void startWalk(){

CMD OPT L

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMapActivity.java, line 74 at r1 (raw file):

	public boolean isInBoundaries(LatLng destination) {
		return destination.latitude >= 40.233000 && destination.latitude <= 40.265000 && destination.longitude >= -111.668000 && destination.longitude <= -111.631000;

Save magic numbers as private static finals

app/src/main/res/layout/safewalk_activity_main.xml, line 62 at r1 (raw file):

	<TextView
		android:id="@+id/info_bullet1"
		android:layout_width="0dp"

Let's put most of this stuff into a style (so that it can be used for all three). Obviously don't put in the constraint stuff, but the text size, margins, width, and height should all be the same

app/src/main/res/values/strings.xml, line 276 at r1 (raw file):

	<!--Safewalk-->
	<string name="cell_phone_number">Cell Phone Number:</string>

prefix this with safewalk_ (like the other ones)

Comments from Reviewable

Review status: all files reviewed at latest revision, 9 unresolved discussions.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 38 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Only the phone number loading needs to happen in this sync task. Do the rest outside of this lambda

Whoops, I didn't even realize this was inside of a lambda.  Haha done.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 52 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
So this would work if they input 1-2-3-4-5-6-7-8-9-0-------------? And it would send that to the service?

The way we were handling that before was by stripping all non-digit characters out before checking and sending that to the service, so we would accept this number and send it to the service as<PHONE_NUMBER>; I just realized, however, that I'm only stripping the number when I check it, not when I send it to the service, so I will fix that.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 67 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
No more dialog. Just make the edit text border red (or something like that to indicate that the need to edit it. Figure out what is the best Android way of validating edit texts)

Done.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 73 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Wait... Does this dialog not even do anything?

No, I was just using it to notify the user that the phone number was invalid.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMapActivity.java, line 43 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
What is this line doing...?

It just closes the dialog.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMapActivity.java, line 67 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
CMD OPT L

Done.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMapActivity.java, line 74 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Save magic numbers as private static finals

Done.

app/src/main/res/layout/safewalk_activity_main.xml, line 62 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Let's put most of this stuff into a style (so that it can be used for all three). Obviously don't put in the constraint stuff, but the text size, margins, width, and height should all be the same

Done.

app/src/main/res/values/strings.xml, line 276 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
prefix this with safewalk_ (like the other ones)

Done.

Comments from Reviewable

Reviewed 4 of 5 files at r2, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 52 at r1 (raw file):
Previously, geogor37 (Geoff Gorham) wrote…
The way we were handling that before was by stripping all non-digit characters out before checking and sending that to the service, so we would accept this number and send it to the service as<PHONE_NUMBER>; I just realized, however, that I'm only stripping the number when I check it, not when I send it to the service, so I will fix that.

Great. Just add a comment now that you removed the function

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 31 at r3 (raw file):

		setContentView(R.layout.safewalk_activity_main);
		showProgressDialog();
		progressDialog.setCancelable(false);

I think you can do this by passing in false to showProgressDialog()

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMapActivity.java, line 43 at r1 (raw file):
Previously, geogor37 (Geoff Gorham) wrote…
It just closes the dialog.

Oh I see! I'm just used to new lines for builder functions. Add a new line before .show()

Comments from Reviewable

Review status: all files reviewed at latest revision, 6 unresolved discussions.

a discussion (no related file):
Wait for Steve on the coordinates

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 33 at r3 (raw file):

		progressDialog.setCancelable(false);

		AccountInformation.sync(this, AccountResolver.getAccount(this), result -> {

I don't think we need to do this anymore. Just use whatever is saved in the shared preferences when the open the feature

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 38 at r3 (raw file):

			AccountInformation accountInformation = AccountInformation.fetch(SafeWalkMainActivity.this, AccountResolver.getAccount(SafeWalkMainActivity.this));
			phoneEditText = (EditText) findViewById(R.id.phone_number_edit_text);
			phoneEditText.setText(accountInformation.getPhoneNumber() != null ? accountInformation.getPhoneNumber() : "unknown");

Don't default to "unknown" anymore

Comments from Reviewable

Reviewed 2 of 2 files at r4.
Review status: all files reviewed at latest revision, 6 unresolved discussions.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 52 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Great. Just add a comment now that you removed the function

I did this one for you. Let me know if you have questions

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 31 at r3 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
I think you can do this by passing in false to showProgressDialog()

I did this one for you. Let me know if you have questions

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 33 at r3 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
I don't think we need to do this anymore. Just use whatever is saved in the shared preferences when the open the feature

I did this one for you. Let me know if you have questions

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 38 at r3 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Don't default to "unknown" anymore

I did this one for you. Let me know if you have questions

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMapActivity.java, line 43 at r1 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Oh I see! I'm just used to new lines for builder functions. Add a new line before .show()

null will close them automatically. I did this one for you. Let me know if you have questions

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

a discussion (no related file):
Previously, romrell4 (Eric Romrell) wrote…
Wait for Steve on the coordinates

Coordinates are good. Now work on location updates in background

Comments from Reviewable

Reviewed 5 of 7 files at r5.
Review status: 8 of 10 files reviewed at latest revision, 5 unresolved discussions.

app/src/main/AndroidManifest.xml, line 45 at r5 (raw file):

		<service
			android:name=".features.safewalk.service.SafeWalkLocationService"
		    android:exported="false">

What does exported do? Also, use the self-closing tag / >

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 27 at r5 (raw file):

	private EditText phoneEditText;

//	TODO: Make up arrow work properly after finishing a Safewalk session

Do it

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkWalkActivity.java, line 40 at r5 (raw file):

	}

//	@Override

Remove if unneeded

support/src/main/java/edu/byu/support/activity/ByuLocationActivity.java, line 91 at r5 (raw file):

	protected void onDestroy() {
		super.onDestroy();
		if (googleApiClient.isConnected()) {

Why did we remove this? Could this cause an exception?

Comments from Reviewable

Review status: 5 of 10 files reviewed at latest revision, 5 unresolved discussions.

a discussion (no related file):
Previously, romrell4 (Eric Romrell) wrote…
Coordinates are good. Now work on location updates in background

Done.

app/src/main/AndroidManifest.xml, line 45 at r5 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
What does exported do? Also, use the self-closing tag / >

Setting exported to false means that other apps can't use this service.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkMainActivity.java, line 27 at r5 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Do it

Done.

app/src/main/java/edu/byu/suite/features/safewalk/controller/SafeWalkWalkActivity.java, line 40 at r5 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Remove if unneeded

Done.

support/src/main/java/edu/byu/support/activity/ByuLocationActivity.java, line 91 at r5 (raw file):
Previously, romrell4 (Eric Romrell) wrote…
Why did we remove this? Could this cause an exception?

No I took it out because we already check this in the stopUpdatingLocation method, so this was redundant

Comments from Reviewable


soc/mediatek: Add DTS binding and definitions for AFE

Add a DTS binding for the MediaTek Audio Front End device, and definitions for the in-tree devices.
These .dts files were auto-generated from pre-existing SOF code (that defined the devices as C structs) using a tool currently being submitted in the SOF tree, thus are included here as separate files. The expectation is that future variants will be authored in this format directly.  Longer term we can move them directly into the core board DTS.

@andyross looks like the files are generated with a trailing blank line, compliance is not impressed :-)

Hm... indeed.  Usually check patch catches that locally for me, maybe not for .dts.  Will clean up once I get the big flurry of cross-project PRs pushed out.

Sorry, never pushed the update.  Please review.


[mixed time-series] extra x-axis labels

When creating the chart with only 1-2 bars on x-axis, some unnecessary x-axis labels are displayed.
Expected results
Number of x-axis labels should be same as number of data points.
Actual results
Excessive x-axis labels are displayed.
Screenshots
With Time Grain: Month

With Time Grain: Quarter

How to reproduce the bug

Create a Mixed Time-series chart with limited number of points on x-axis

Environment

superset version: 1.2
python version: 3.7
node.js version: v14.15.5

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Add any other context about the problem here.

some unnecessary x-axis labels are displayed.

you mean these? what time grain did you set for the bar?

Yes, this was with Time grain 'month'. I updated the original comment with this info.

Got it, this is a limitation from Echarts, the charting library we use. unfortunately there's no easy way to resolve ATM. apologies🙏


pointers, jet templates and more

Since we have package support, we should be able to fully wire up your first controller to the router. Probably should do that, too :)

Travis CI has been removed in favor of Github actions. Please ignore the travis checks for now and we'll remove the travis config shortly.

While this isn't 100% yet, Im going to go ahead and merge this in to master. We can continue working off of it there and cut a release whenever we feel that it is ready. I think this is the right path to go forward with, so I dont mind getting it into master branch.


[Xiaomi/Chrome/Firefox] - Clicking "Read More about free weekend shipping" banner redirects to FAQ page

this is actually correct, could be better, but the faq has the free shipping info (or is supposed to)


Dev

Fixes #5, Fixes #6

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-pre.6 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


IVY-1572 - Check for Thread interruption while resolving resources

Signed-off-by: Aurélien Pupier<EMAIL_ADDRESS>

Seems that there was an issue with the Jenkins webhook.
Jan Matèrne mentioned that the build was in success https://issues.apache.org/jira/browse/IVY-1572?focusedCommentId=16316345&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16316345

long time without progress and no more in my scope of work. Closing. feel free to reuse my work if needed


Revamp the inventory system

The inventory system needs the following updates

Needs to be able to handle transferring of a multiple of the same item. 1--max player is holding
Need to be able to handle/have different options for different item types (weapon/entity/clothing/case)
redesign the UI for item options
have an abstract/easy to use function for adding items to the player's inventory. (when opening a case/ purchasing VIP etc)

Fixing in branch 11-revamp-the-inventory-system. I noticed that when mining no items are being added to the players inventory, I may have just never added this before, given I did mention making adding items to to the players inventory simpler.

Yep, deleting and re-writing the inventory system. It seems I previously added to the existing inventory code and botched it. I keep seeing an AddItem method called on the player when adding an item to the inventory, but I see this method called on other objects like UI elements as well. Confused. Couldn't find the root AddItem method, did find the mining functions, and I did implement adding the rocks to the players' inventory, unsure why it wasn't for me. Will investigate that before moving on to rewriting, it could be I didn't add models or entities for the actual mined rock.


Add public device type

Change-type: patch
Signed-off-by: Tomás Migone<EMAIL_ADDRESS>
Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

Oops missed that, it's fixed now.

@balena-ci retest


Bold text is no longer displaying as bold

OS: Fedora 40 x86_64
Top: Firefox 127.0.2 (64-bit)
Bottom: Ladybird @ commit 09f7609

What is the source code for that HTML file?

What is the source code for that HTML file?

If I may be so bold

Interestingly it works as expected for me

Do you know when this regressed for you?
One possibility I can think of is that font-config doesn't pick up the bold variant of your serif font.
Does If I may be so bold look bold for you?

Same result with sans-serif. I'm unsure when the issue first occurred, I just happened to notice it while browsing.

My guess is somehow that font doesn't have a bold variant, or Ladybird isn't finding it... We need better font debugging tools.

Note that the "b" tag has long ceased to mean "bold text", but rather " bring attention to". The browser is not required to apply any particular style to this tag by default.

While it's true that  nowadays has a semantic meaning rather than a stylistic one, the HTML spec still expects it to have font-weight: bolder: https://html.spec.whatwg.org/multipage/rendering.html#phrasing-content-3.
Which Ladybird has in Default.css, so that's not the cause of this issue.

As mentioned in the introduction https://html.spec.whatwg.org/multipage/rendering.html#rendering and here a visual user agent is not required to present HTML documents in any particular way and I have not found any information in the documentation for this browser indicating that it is designated as supporting the suggested default rendering.
However, I only said this for informational purposes, I don't think it is linked to the problem mentioned.

hi, just trying to add more info
this is Ladybird on mac, with --enable-skia-painting flag

this is Ladybird on mac, without --enable-skia-painting flag

master branch, 72b4d44d07e12cc04bde90872e2f31aaab64aa00

My guess is somehow that font doesn't have a bold variant, or Ladybird isn't finding it... We need better font debugging tools.

I’m pretty sure this is the reason why it’s not working. I had this issue with fresh installations of Arch Linux.

After digging into this a bit, I've determined (on my system, at least):

fontconfig strongly prefers the Google Noto variable weight fonts over all others
These variable weight fonts are not being handled properly by whatever part of the browser stack is responsible for handling them properly
All text using these fonts is displayed at font-weight: 400 whether you like it or not

For now, I ended up creating a ~/.config/fontconfig/fonts.conf with the following:
<?xml version='1.0'?>
<!DOCTYPE fontconfig SYSTEM 'fonts.dtd'>
<fontconfig>
  <match>
    <test name="family" compare="contains">
      <string>sans</string>
    </test>
    <edit name="family" mode="prepend">
      <string>Liberation Sans</string>
    </edit>
  </match>
  <match>
    <test name="family">
      <string>serif</string>
    </test>
    <edit name="family" mode="prepend">
      <string>Liberation Serif</string>
    </edit>
  </match>
</fontconfig>

and the result:

While this is a workaround rather than a solution, I figure it might be helpful for others who may be experiencing the same issue on similar systems.

Ahhhh. Yes, we don't yet support variable width fonts (or, the variable width part anyway). So that all makes sense.


Feedback for “Vanilla Client”

Hey there. Was just reading your documentation:

rspc will generally use a GET request for queries and POST request for mutations however this isn't guaranteed.

This looks a bit scary, you might want to clarify it a bit (at least state that a GET will never be used for mutations) :)

Very fair. It's definitely not intended to say that mutations will ever be done over GET, it was intended for queries potentially being done over POST such as how GraphQL commonly works although that isn't currently supported.
We can probally just remove the whole sentence though because i'm not sure it's actually something that needs to be mentioned.


Patch 1

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Further there is a merge conflict could you try to resolve it. If you need any help please let us know.

Merge conflict still occurs 🙈


Reviving mwa_ppdb - WIP (Do not merge)

From #1606,  #1608 and #1627, something is wrong when corpus is loading from other subdirectory in nltk_data other than nltk_data/corpora.

I'm out of wits, why would Python 3.5 test fail while Python 3.4 and Python 2.7 works.


Fix a race condition when handling many concurrent responses

Should fix #354

In hindsight, it's isolated by the connection's EventLoop - so not an issue


Updated LISF development workflow diagram

Description
Replaced hand-drawn diagram of LISF development workflow in git.
New diagram was created on app.diagrams.net, saved as a .drawio file,
and converted to png.
Revised working_with_github.adoc file was processed with
asciidoctor, and the resulting html file was inspected with
Firefox on Discover.

I like the minimal design @emkemp! I actually started working on something similar a while back, but it's much busier (and uglier) than yours...

Are we able to make edits to your version? I have a few suggestions:

Borrowing from my version, it might be helpful to indicate where pull requests are occurring.
Re-label "Release Branch" as "Support Branch" to align with our branch names.
Delete the arrow from fix branch to master and add an arrow from the last commit on the support branch to the last commit on master. This reflects that the fix is merged into support via PR then support is merged back into master.

Lastly, do we need the LISFLOW.io file in the PR since we have the PNG file?

Hi @bmcandr:
Yes, we can edit the diagram by loading the LISFLOW.drawio file back into app.diagrams.net (that's why I kept it). I agree with your edit suggestions and will incorporate.

Latest diagram version is ready for review.
Also, I vote to keep the .drawio file, so we can update the diagram later if we change our development workflow.

Thanks @emkemp. Looks good to me.

Also, I vote to keep the .drawio file, so we can update the diagram later if we change our development workflow.

Agreed.


gtk GUI: Fix Ctrl+[ (Belgian,German keyb. layout)

Problem: issue #10454 reported troubles with leaving insert mode on Belgian keyboard in GTK GUI. Handling of Ctrl+ü on German keyboard is lost over the time as well in GTK GUI.
This PR partly fixes issue #10454 (only GTK part of it, not Win32). Additionally it provides back missing Ctrl+ü handling on German keyboard (ü is on same place in german layout where [ is on english keyboard). Fix is probably not very nice and cannot be yet considered a final solution (?) but it seems to work. It was made possible due to the fact that Motif GUI still handles both Belgian and German CTRL+[ nicely. Tracing/comparing of the key codes feed to background Vim engine by Motif GUI and by GTK GUI via add_to_input_buf() was the key.

I have tested release 9.00.35 and build release 9.00.48 and I still have the problem.
I'm afraid the patch doesn't solves the problem and issue should be reopen.

Hi, Vivian,
Did you made your tests on Linux or on windows, because my patch is only
for unix-like GTK gvim. What does your :version command in gvim reports?
(Windows version of the patch is in pipeline yet ))))
Vivian De Smedt @.***> schrieb am Sa., 9. Juli 2022,
15:34:

I have tested release 9.00.35 and build release 9.00.48 and I still have
the problem.
I'm afraid the patch doesn't solves the problem and issue should be reopen.
—
Reply to this email directly, view it on GitHub
https://github.com/vim/vim/pull/10658#issuecomment-1179546260.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to @.***
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/10658/c1179546260%40github.com
https://groups.google.com/d/msgid/vim_dev/vim/vim/pull/10658/c1179546260%40github.com?utm_medium=email&utm_source=footer
.

Hi Vim,
I do my test on Windows 10 on Vim version 9.00.48.
Best regards,
Vivian.

Hi Vivian,
Just created a PR https://github.com/vim/vim/pull/10687 which hopefully solves your issue on windows.
If you can build your own windows binary you can try my branch directly:
https://github.com/haron13-2019/vim/tree/azerty_ctrl_dead
With best regards, Anton

Hi Anton,
Thanks for the branch (https://github.com/haron13-2019/vim.git).
I only realize that you wrote to me few minutes ago (sorry for that).
I have tested your branch but unfortunately it doesn't solve my problem.
Best regards,
Vivian.


Blob storage client should not erase abortSignal from pollUntilDone

The Blob Storage client offers a pollUntilDone method for file copies etc. Other Blob Storage operations in this SDK allow passing an abortSignal in the options, however, this method does not.
The option is available in the underlying abstraction. This interface erases the options object from the method signature.
Offering the possibility to pass an abortSignal enables users to implement timeouts and more without reimplementing pollUntilDone themselves.

Hi @reknih
The PollerLikeWithCancellation instance provides a method cancelOperation. Would it work for your scenario?
Thanks
Emma


manifest的作用？

    // extract webpack runtime and module manifest to its own file in order to
    // prevent vendor hash from being updated whenever app bundle is updated
    new webpack.optimize.CommonsChunkPlugin({
      name: 'manifest',
      chunks: ['vendor']
    })

不是很理解，请解释一下

See this discussion for why this is necessary.


Switch upload from setuptools to Twine (~=1.9)

fixes #503

Coverage increased (+0.09%) to 75.064% when pulling 72ad96e9062b23e27e4a42cf6d9a847a6302a85d on arcivanov:issue_503 into 82acc02dd50b243049158815822acceb2d474713 on pybuilder:master.

Coverage increased (+0.09%) to 75.064% when pulling 72ad96e9062b23e27e4a42cf6d9a847a6302a85d on arcivanov:issue_503 into 82acc02dd50b243049158815822acceb2d474713 on pybuilder:master.

Coverage increased (+0.09%) to 75.064% when pulling 72ad96e9062b23e27e4a42cf6d9a847a6302a85d on arcivanov:issue_503 into 82acc02dd50b243049158815822acceb2d474713 on pybuilder:master.

Coverage increased (+0.09%) to 75.064% when pulling 72ad96e9062b23e27e4a42cf6d9a847a6302a85d on arcivanov:issue_503 into 82acc02dd50b243049158815822acceb2d474713 on pybuilder:master.

Coverage increased (+0.1%) to 75.075% when pulling ae496d7115ebdd0036c4f48e78f203cfc1c6c4f1 on arcivanov:issue_503 into 82acc02dd50b243049158815822acceb2d474713 on pybuilder:master.

@AlexeySanko please review

Ok, no objections, merging. :smile:


Remove outFiles from 'Debug Current Test' option in vscode launch.json

outFiles was added to "Debug Current Test" via PR #4306.
However, with we can't add breakpoints while debugging tests locally in vs code. This makes debugging locally a lot harder. So, removing the outFiles.

Hm, it worked for me just fine, and VSCode kept nagging me to add it there. Curious, what's the difference between our setups?

See here: https://code.visualstudio.com/docs/typescript/typescript-debugging
What am I missing?

Not sure. VS code is not nagging me about it. Maybe you have some debug extension installed?

Those instructions require a compile step and don't use ts-node

i think we should merge this, as i can't debug tests without it, and it doesn't seem it was blocking @vladsud

Merging this for now to unblock local testing. If needed, we can figure out a better way of fixing this.


OSError: Expected to be able to read 12300328 bytes for message body, got 12300316

Hello,
I've been trying to evaluate several custom models on MTEB
I faced some errors,
2022-11-08 11:12:04.822852 >>> ClimateFEVER
Traceback (most recent call last):
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/mteb/evaluation/MTEB.py", line 235, in run
    results = task.evaluate(model, split, **kwargs)
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/mteb/abstasks/AbsTaskRetrieval.py", line 93, in evaluate
    results = retriever.retrieve(corpus, queries)
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/beir/retrieval/evaluation.py", line 23, in retrieve
    return self.retriever.search(corpus, queries, self.top_k, self.score_function, **kwargs)
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/beir/retrieval/search/dense/exact_search_multi_gpu.py", line 150, in search
    cos_scores_top_k_values, cos_scores_top_k_idx, chunk_ids = metric.compute()
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/evaluate/module.py", line 433, in compute
    self._finalize()
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/evaluate/module.py", line 390, in _finalize
    self.data = Dataset(**reader.read_files([{"filename": f} for f in file_paths]))
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/datasets/arrow_reader.py", line 236, in read_files
    pa_table = self._read_files(files, in_memory=in_memory)
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/datasets/arrow_reader.py", line 171, in _read_files
    pa_table: Table = self._get_table_from_filename(f_dict, in_memory=in_memory)
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/datasets/arrow_reader.py", line 306, in _get_table_from_filename
    table = ArrowReader.read_table(filename, in_memory=in_memory)
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/datasets/arrow_reader.py", line 325, in read_table
    return table_cls.from_file(filename)
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/datasets/table.py", line 1036, in from_file
    table = _memory_mapped_arrow_table_from_file(filename)
  File "/home/qmin/anaconda3/envs/sgbert/lib/python3.7/site-packages/datasets/table.py", line 51, in _memory_mapped_arrow_table_from_file
    pa_table = opened_stream.read_all()
  File "pyarrow/ipc.pxi", line 691, in pyarrow.lib.RecordBatchReader.read_all
  File "pyarrow/error.pxi", line 115, in pyarrow.lib.check_status
OSError: Expected to be able to read 12300328 bytes for message body, got 12300316

(other retrieval tasks have the same issue)
Is there any workaround?

Can you try install the latest BEIR development branch via pip install git+https://github.com/beir-cellar/beir.git@development?

Yes, I tried it as you said, but it doesn't work

Yes, I tried it as you said, but it doesn't work

You can fix it by downgrading BEIR to 1.0.0 pip install --upgrade beir==1.0.0, which will use a different download mechanism for BEIR datasets.
It's an issue with the exact_search_multi_gpu in BEIR. Here's a reproducer: https://colab.research.google.com/drive/1IeaXB12kuVn15vUQMwgmBttkFY4luQCO?usp=sharing @NouamaneTazi is the expert here - Do you have an idea what might cause the issue?
Meanwhile, I will pin beir==1.0.0

Thanks for replying
It goes well now :)


API Documentation issue in QueryHelpers

The documentation for QueryHelpers.AddQueryString has wrong signatures.
Specifically,

AddQueryString(String, IDictionary<String,String>) should be AddQueryString(String, IDictionary<String,String?>) (with nullable dictionary values)
AddQueryString(String, IEnumerable<KeyValuePair<String,String>>) should be AddQueryString(String, IEnumerable<KeyValuePair<String,String?>>) (with nullable values in the KVP)

It seems these types changed to be nullable with ASP.NET Core 5.0, and I'm referring to the 5.0 documentation.

@v-alje please review.

@Rick-Anderson the Docs Reference Engineering team is working on getting NuGet ingestion working for Platform NuGet packages like ASP. Hopefully using the latest packages will fix this.


Support for JSON traits + remote config

We currently support setting numeric, string and boolean traits / remote config, people also ask for JSON support.
Slightly related to this, people also ask that if we do this we have some sort of TypeScript or schema validation.
Unfortunately, we'd need to roll this change out to SDKs.

I think the solution to this could be to add a separate field to signify it being json and SDKs can opt into parsing it.

I think the solution to this could be to add a separate field to signify it being json and SDKs can opt into parsing it.

This still doesnt help with e.g. Java. Maybe the languages with native support could provide a native object for it, but for something like Java it's problematic.

I might be wrong about Java?
Regardless, I think if we had our time again we would have completely untyped config values and just leave it up to the developer. If thats the case, adding more types would be going in the wrong direction?

Quite a common ask (2 above related issues) is for people to be able to define a schema for values so that people don't add the wrong config for an environment.
This doesn't necessarily need to affect SDKs I guess, it's more just preventing people from entering incorrect remote config. Having said that, the suggestions in https://github.com/Flagsmith/flagsmith/issues/3457 could lead to generated typed definitions, at least in the JavaScript SDK

Closing this in favour of #3457


Pool fills up with 'USED' connections - node app restart required as a result

Expected Behavior
On calling connection.release(), connections should be released back into the pool and these connections should be in state = 1, meaning 'FREE' state so that they can be reused in the future, regardless of errors having occurred on the connection (timeouts, etc...)
Current Behavior
My connection pool slowly fills up to the max number of connections where it ends up with all connections being in the 'USED' state (i.e. state = 2).
my minimum pool size = 5 and maximum pool size = 15.
After some time (this is variable, can be after 24 hours, sometimes 48 hours,... depends on the load on the database and how often timeouts occur) I end up with 15 connections in the 'USED' state and I need to restart my application.
Whenever this happens:
RequestError: Timeout: Request failed to complete in 15000ms

--> the connection on which the timeout occurred is not released properly and remains in state = 2 ('USED')
logs from a test run: the pool starts of with 5 connections in the 'FREE' state and every time a request timeout happens on a connection, that connection's state is set to 2 and it is never free'd up.
[2019-05-27T13:00:07.421] [INFO] default - Zdeapp beta_release_0.118_SNAPSHOT running on port 3000...
[2019-05-27T13:01:00.005] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:02:00.004] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:03:00.004] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:04:00.004] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:05:00.008] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:05:00.111] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:06:00.004] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:07:00.006] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:08:00.003] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:09:00.005] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:10:00.003] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:10:00.103] [INFO] default - pool status 2,1,1,1,1
[2019-05-27T13:11:00.006] [INFO] default - pool status 1,1,1,1,1
[2019-05-27T13:11:15.022] [ERROR] default - Error retrieving todays order IDs RequestError: Timeout: Request failed to complete in 15000ms
[2019-05-27T13:12:00.003] [INFO] default - pool status 2,1,1,1,1
[2019-05-27T13:13:00.004] [INFO] default - pool status 2,1,1,1,1
[2019-05-27T13:14:00.003] [INFO] default - pool status 2,1,1,1,1
[2019-05-27T13:15:00.006] [INFO] default - pool status 2,1,1,1,1
[2019-05-27T13:15:00.105] [INFO] default - pool status 2,1,1,1,1
[2019-05-27T13:16:00.004] [INFO] default - pool status 2,1,1,1,1
[2019-05-27T13:17:00.003] [INFO] default - pool status 2,1,1,1,1
[2019-05-27T13:17:15.018] [ERROR] default - Error retrieving todays order IDs RequestError: Timeout: Request failed to complete in 15000ms
[2019-05-27T13:18:00.005] [INFO] default - pool status 2,2,1,1,1
[2019-05-27T13:19:00.003] [INFO] default - pool status 2,2,1,1,1
[2019-05-27T13:20:00.005] [INFO] default - pool status 2,2,1,1,0
[2019-05-27T13:20:00.100] [INFO] default - pool status 2,2,2,1,1
[2019-05-27T13:21:00.004] [INFO] default - pool status 2,2,1,1,1
[2019-05-27T13:22:00.004] [INFO] default - pool status 2,2,1,1,1

Steps to Reproduce (for bugs)
You won't be able to reproduce with only the code pasted here, I only copied the core of the code involved. I will write up another test case (a separate test application) and I'll also post that test code here if I the same issue manifests itself.
I started printing the status of all the connections in the pool every time a connection is acquired from the pool. As can be seen from the logs, the number of 'USED' connections slowly creeps up
log excerpt:
[2019-05-25T17:33:00.008] [INFO] default - pool status 1,1,1,1,1
[2019-05-25T17:35:00.499] [INFO] default - pool status 2,1,1,1,1
[2019-05-25T17:36:00.004] [INFO] default - pool status 2,1,1,1,1
[2019-05-25T17:39:00.009] [INFO] default - pool status 2,2,1,1,1
[2019-05-25T17:40:00.499] [INFO] default - pool status 2,2,2,1,1
[2019-05-25T17:42:00.005] [INFO] default - pool status 2,2,2,1,1
[2019-05-25T17:45:00.014] [INFO] default - pool status 2,2,2,2,1
[2019-05-25T17:45:00.545] [INFO] default - pool status 2,2,2,2,2
[2019-05-25T17:45:15.676] [ERROR] default - Error when checking for newly invoiced orders RequestError: Timeout: Request failed to complete in 15000ms
[2019-05-25T17:48:00.003] [INFO] default - pool status 2,2,2,2,2
[2019-05-25T17:50:00.489] [INFO] default - pool status 2,2,2,2,2,2
[2019-05-25T17:50:15.597] [ERROR] default - Error when checking for newly invoiced orders RequestError: Timeout: Request failed to complete in 15000ms
[2019-05-25T17:51:00.026] [INFO] default - pool status 2,2,2,2,2,2
[2019-05-25T17:54:00.005] [INFO] default - pool status 2,2,2,2,2,2
[2019-05-25T17:55:00.507] [INFO] default - pool status 2,2,2,2,2,2
[2019-05-25T17:57:00.007] [INFO] default - pool status 2,2,2,2,2,2
[2019-05-25T18:00:00.099] [INFO] default - pool status 2,2,2,2,2,2,2
[2019-05-25T18:00:00.619] [INFO] default - pool status 2,2,2,2,2,2,2,1
[2019-05-25T18:03:00.008] [INFO] default - pool status 2,2,2,2,2,2,2
[2019-05-25T18:05:00.493] [INFO] default - pool status 2,2,2,2,2,2,2
[2019-05-25T18:06:00.027] [INFO] default - pool status 2,2,2,2,2,2,2
[2019-05-25T18:09:00.006] [INFO] default - pool status 2,2,2,2,2,2,2,2
[2019-05-25T18:10:00.505] [INFO] default - pool status 2,2,2,2,2,2,2,2,2
[2019-05-25T18:12:00.029] [INFO] default - pool status 2,2,2,2,2,2,2,2,2
[2019-05-25T18:15:00.007] [INFO] default - pool status 2,2,2,2,2,2,2,2,2,2
[2019-05-25T18:15:00.577] [INFO] default - pool status 2,2,2,2,2,2,2,2,2,2,2
[2019-05-25T18:18:00.028] [INFO] default - pool status 2,2,2,2,2,2,2,2,2,2,2
[2019-05-25T18:20:00.495] [INFO] default - pool status 2,2,2,2,2,2,2,2,2,2,2,2
[2019-05-25T18:21:00.025] [INFO] default - pool status 2,2,2,2,2,2,2,2,2,2,2,2
[2019-05-25T18:24:00.004] [INFO] default - pool status 2,2,2,2,2,2,2,2,2,2,2,2
[2019-05-25T18:25:00.503] [INFO] default - pool status 2,2,2,2,2,2,2,2,2,2,2,2

My connection pool js file
const ConnectionPool = require('tedious-connection-pool')
const appConfig = require('./config')[process.env.ZAPENV]
const logger = require('./logger').mainLog

const poolConfig = {
  min: 5, // 5
  max: 15, // 15
  idleTimeout: 10000,
  acquireTimeout: 12000,
  log: false
}

const config = {
  userName: appConfig.mssql.MSSQL_USER,
  password: appConfig.mssql.MSSQL_PASS,
  // server: appConfig.mssql.MSSQL_EXT_SRV,
  server: appConfig.mssql.MSSQL_INT_SRV,
  options: {
    // port: appConfig.mssql.MSSQL_EXT_PORT,
    port: appConfig.mssql.MSSQL_INT_PORT,
    database: appConfig.mssql.MSSQL_DB,
    trustedConnection: true,
    rowCollectionOnRequestCompletion: true,
    useUTC: false,
    readOnlyIntent: true,
    // acquireTimeout: 10000,
    connectTimeout: 15000,
    requestTimeout: 15000,
    maxRetriesOnTransientErrors: 0
  }
}

const pool = new ConnectionPool(poolConfig, config)

pool.on('error', function (err) {
  logger.error(`db connection pool error - ${err} pool size ${pool.connections.length}`)
})

module.exports = pool

Here's one example usage of how I use the connection pool. There are many modules inside my application which rely on the connection pool and the pattern is always the same.

acquire connection
execute the sql
process the returned data in the sqlrequest callback function

Note that the first line in the callback is 'connection.release()'. This to make sure the connection is definitely released once the callback is hit regardless of connection errors/success.
function getTodaysOrderIds (callback) {
  logger.info('pool status ${connectionPool.connections.map(x => x.status)}')
  connectionPool.acquire(function (err, connection) {
    logger.info('acquiring sqlserver connection...')
    if (err) {
      logger.error(err)
      return
    }

    let dataSet = []

    let sqlRequest = new MssqlRequest('SELECT something FROM somewhere', function (err, rowCount, rows) {
      connection.release()

      if (err) {
        callback(err, null)
      } else if (rowCount === 0) {
        callback(null, null)
      } else {
        rows.forEach(function (row) {
          if (row[0].value !== '') {
            let element = { 'id': row[0].value, 'create_date': row[1].value }
            dataSet.push(element)
          }
        })

        callback(null, dataSet)
      }
    })

    connection.execSql(sqlRequest)
  })
}

Am I right in thinking that in the example code below (taken from the tedious-connection-pool github repo), the connection will not be released when an error occurs? For example, DB connection is established but the request times out...
    //use the connection as normal
    var request = new Request('select 42', function(err, rowCount) {
        if (err) {
            console.error(err);
            return;
        }

        console.log('rowCount: ' + rowCount);

        //release the connection back to the pool when finished
        connection.release();
    });

Ironically, this seems to be happening in my code - connections not being released back into the pool in the correct state.... should I move my connection.release() call back to the bottom of the callback function?
Reason For Request (for feature requests)
Possible Solution
Background Details
Regular restarts are required...
Environment

Node.js Version: 8.12.0
Windows/Mac/Linux: CentOS Linux release 7.5.1804, x86_64 x86_64 x86_64 GNU/Linux

I'm with the same problem! In my case, the RequestTimeout is thrown trying to execute a DELETE statement, under a transaction, inside a connectionPool.


Custom bucket policy statements

what
Add the ability to include custom bucket policy statements
why
Sometime we need to allow someone else to access to tfstates. Ex: Allow the entire orgs to access to some states

@feraudet thanks for the contribution, but I believe this is possible via the source_policy_documents variable. Please check that out, try it out within your own project, and then report back and reopen if needed. If there is a need here, we're happy to look into it, but I believe this is already accounted for. Thanks!

Hello,
As far as I understand source_policy_documents only allow to override existing policies, not to add policies

I think your'e right, according to the documentation, using blank Sid allow to add policies

@feraudet yeah and it is confusing due to the terminology, so it makes sense to not get it at first. Try it out and let me know how it goes!


Optional catch-all API route not working

Hi @aiji42
is there some way to support Optional catch all API routes ( [[...path]] )? I need to have routes
example.com/archive
example.com/archive?page=2&...

If I create project with structure like this
pages
|-- archive
  |-- _middleware.js
  |-- [...path].js

then example.com/archive?page=2 works but example.com/archive returns 404. I have tried it like this as well with no success (example.com/archive?page=2 triggers index.js with undefined query):
pages
|-- archive
  |-- _middleware.js
  |-- [...path].js
  |-- index.js

Basically is there a way to add support for this? (I tried, but query is always undefined):
pages
|-- archive
  |-- _middleware.js
  |-- [[...path]].js

I guess for now I will redirect example.com/archive to example.com/archive?page=1 and use the first file structure but it would be great if [[...path]].js worked.

@milanku  Thanks for the question. This library does not support Optional catch all API routes at this time.
I am currently planning a major update (#34). Please wait for a while as the new version will include the support.

v2.0.0 was released to support Optional catch all API routes.
Note, however, that prefetch navigation (e.g. Link component, router.push) is not supported in that case. We've also mentioned that in the readme.
This is due to the specs of Next.js, and we decided that it would be difficult to support it further at this time.


Link to Plumtree paper is 404

Link should be http://asc.di.fct.unl.pt/~jleitao/pdf/srds07-leitao.pdf

Fixed in https://github.com/helium/plumtree/pull/43

Thanks!


Accessing PropTypes via the main React package is deprecated

Use import PropTypes from 'prop-types' instead.

Fixed in #84


Icon insetead of text

Hey!
For example, I have that in routes:
{
  path: '/',
  name: 'home',
  component: page('home.vue'),
  meta: {
    breadcrumb: {
      label: 'Home',
      icon: 'home',
    }
  },
},

So in this case route home has icon key and it should output an icon (font awesome, for example) instead of label.
Is it possible? crumb.meta.breadcrumb.icon gives me null everytime.

@RomanSarvarov Hi, interesting idea.

It is not clear which template to use for the icon name
At the moment you can try to transfer an icon template to the label. for example

meta: {
    breadcrumb: {
      label: '<i class="fa fa-home"></i>'
    }
  },

I have not tested it, but there is a suspicion that it will work.

Let me know if something goes wrong with you, we will figure it out

I guess I just found a better way:
breadcrumb: {
  label: {
    icon: 'home',
  },
},

<FontAwesomeIcon
  v-if="typeof getBreadcrumb(crumb.meta.breadcrumb) === 'object'"
  :icon="getBreadcrumb(crumb.meta.breadcrumb).icon"
/>


Add SchemaForm for JSON generated react-hook-form forms

Adds <FormSchema /> to take JSON and turn it into a (partial) form.

<FormSchema /> is meant to be used inside of an implemented react-hook-form.. form, it doesn't provide the form wrapper for you, but it interacts directly with existing properties of a react-hook-form.
Provides support for Input and Select form elements
Provides support for validation
Provides support for conditional field rendering within generated form.

Adds useErrorMessages hook for memoizing and providing simple error messages to <FormSchema />
Adds tests, docs, examples

Preview:
https://deploy-preview-21--laughing-shockley-2b3f4c.netlify.app/?path=/docs/components-forms-schemaform--basic

I don't desire to block progress, so my commenting isn't a request for changes for today. But I disagree with concepts introduced in this PR.
I'm surprised we're interested in maintaining a dbt Cloud feature in a package that's, in my mind, just supposed to be design implementation. I don't understand what benefit we get out of putting SchemaForm here.

Is it because Storybook is already installed, which is nice for documentation? We could install that for dbt Cloud too if we wanted.
Are we suggesting all components are defined in Fishtown UI? I very much disagree with this concept. It adds unnecessary overhead, as you have to open two pull requests when adding new componentry to dbt Cloud.

I think Fishtown UI will prove to be most valuable when it provides rudimentary building blocks, such as Field. We'll be able to iterate quickly on styles and components without considering feature-specific requirements. SchemaForm might be better positioned to live in dbt-cloud, or some other package that's specifically spec'd for business logic.

@eiof is right here - closing this PR and moving this to cloud
Good call!


Integration of Client CLI and Java SDK Tests with GitHub CI/CD and Allure Test Ops

We need to integrate the existing Client CLI and Java SDK tests into a unified workflow that can be run as part of our GitHub CI/CD pipeline. The outcome of these tests should be reported in Allure Test Ops for easier management and tracking of test results.
Unified Test workflow: The existing Client CLI and Java SDK tests would be configured to run in a single workflow.
GitHub CI/CD Pipeline Integration: The unified test workflow needs to be integrated into our existing GitHub CI/CD pipeline. This means the workflow should be configurable and manually triggerable from within the pipeline.
Allure Test Ops Integration: The results of the unified test workflow should automatically be reported to Allure Test Ops. This means both the overall success/failure of the suite, as well as the results of individual tests. Also, tests should be run from Allure. Information about the Allure-GitHub integration can be found here.

Blocked by https://soramitsu.atlassian.net/browse/DOPS-2715


Nuget custom upstream source not available

The instructions claim that custom upstream public sources are available for nuget: "For public sources, choose npmjs, NuGet Gallery, PyPI, or Maven Central".
I dont see nuget available.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72c152cc-c1d1-abc1-1861-20aab95731bb
Version Independent ID: 0d75b4b4-3297-fae7-9345-d863f67e6fed
Content: Set up upstream sources for your feed - Azure Artifacts
Content Source: docs/artifacts/how-to/set-up-upstream-sources.md
Product: devops
Technology: devops-artifacts
GitHub Login: @ramiMSFT
Microsoft Alias: rabououn

@slobo80 Thanks for your feedback! The article has been updated. Custom public upstream sources are only available with npm .


 I don't want to run Docker-based kafka-topics.sh nor run Java program. Would you accept the idea of adding admin commands to this tool?

Sure! What kind of admin commands do you want to support at top tier? I love the concept of kaf, which is already in the roadmap #8 .

At least I'd like to create topics beforehand in order to dump files to kafka. A more natural way of managing topics in the use-case of kafkacat is to directly use the file name as the topic name.
For example, starting with a clean-slate kafka cluster, we can provide an option --file-as-topic that creates a Kafka topic using the file name if it doesn't exist. And after that, the command will ingest the file content into the topic.

It shouldn't be hard to implement. But for now, I have little time to work on this project. Do you mind implementing it on your own?
TODO:

[ ] inspect.rs: turn information about the cluster and watermark of the topic into rust struct
[ ] hook.rs: do some operation before performing dumping/copying
[ ] --create-if-not-exists as a pre-produce hook
[ ] --file-as-topic in main

Yep I'm glad to do that! Thanks for your information!

Just realized that Kafka supports automatic creation of topics auto.create.topics.enable, so for now, I no longer need admin API from the client-side. Other people encountering a wider scope of requirements may create another issue.


Cannot read property 'off' of undefined

For no reason the error message below has started to appear, does anyone know how to fix it?
Message: javascript error: Cannot read property 'off' of undefined
(Session info: headless chrome=74.0.3729.131)
(Driver info: chromedriver=74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Linux 4.15.0-55-generic x86_64)

Error detected in this line: window.Store.Msg.off('add');
Store.Msg does not exist
Any solution?

Hi have you found the solution I am facing same issue?

what was the sollution?


Roll engine 6bc33b5e1442..7fd4caf03736 (8 commits)

https://github.com/flutter/engine/compare/6bc33b5e1442...7fd4caf03736
git log 6bc33b5e144254ceab274298dd61d9d9ed0dcc8f..7fd4caf03736343c2d70d5cd486aa1c8a6d86c60 --no-merges --oneline
7fd4caf03 Roll src/third_party/dart 1ad11facec..da4ccd0855 (6 commits)
d3fbaea9a Android Embedding PR25: Prevent black rectangle when launching FlutterActivity (flutter/engine#8460)
99da038da Document the leak_vm flag. (flutter/engine#8462)
ce7c21ce9 Log the correct function on error in the embedder. (flutter/engine#8461)
e10d46421 Improve path metrics tests and docs (flutter/engine#7851)
424045c3f Enable shutting down all root isolates in a VM. (flutter/engine#8457)
816e3dc0f Roll src/third_party/dart 907c514c89..1ad11facec (7 commits)
45dc353ee Roll src/third_party/skia 0e35ce27e0e9..053b2939938c (10 commits) (flutter/engine#8458)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/4835827086524416 , https://cirrus-ci.com/task/6665414435143680 , https://cirrus-ci.com/task/6102464481722368 , https://cirrus-ci.com/task/4624720853991424 , https://cirrus-ci.com/task/5539514528301056 , https://cirrus-ci.com/task/5750620760834048 , https://cirrus-ci.com/task/4695089598169088

Commit queue failed; closing this roll.


Set default datashader cmap to fire

Simple change, the default defined by datashader isn't great.

Doubt this is tested right now, happy to merge.

Yes, only testing aggregate atm, so just merge.


[release-1.6] fix error service name in Cleanup

cherry-pick https://github.com/istio/istio/pull/27349/commits

Hi @ImmortanJoe. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@ImmortanJoe: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio_release-1.6
69af8b0a45bdb229c2da8254f2891c8af4dbf48d
link
/test unit-tests_istio_release-1.6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio_release-1.6


Error: Unexpected value 'Ng2DragDropModule' imported by the module

Trying to use it angular2 app generated by angular cli. Default setup (with webpack).
Installed module via npm and trying to import to my app module:
imports: [Ng2DragDropModule]
Everything compiles fine but in browser I got:
Error: Unexpected value 'Ng2DragDropModule' imported by the module 'AppModule'
Importing module like so:
import { Ng2DragDropModule } from 'ng2-drag-drop'
Do you know what it can be?
Thanks for the module btw =)

Also if I console Ng2DragDropModule just before @NgModule annotation I can see:
function Ng2DragDropModule() {}

@gund , I think this is probably related to using webpack. I haven't tested or added support for webpack yet. (I plan to). If could possibly provide me a plunkr that would really help.

@ObaidUrRehman I'm not sure it is possible to use webpack with plunkr =)
Anyway there is really no configuration required for webpack to use your library, I just npm install it and import that should do the job.
But for some reason angular complains.
You can try to create project with angular cli, install your lib and import it to AppModule to see that error in runtime.

@gund what version of ng-cli are you using? Its seems that this is a know problem with older versions of cli. See Also: https://github.com/videogular/videogular2/issues/249
I encountered the same problem with angular-cli 1.0.0-beta-15.0.0 but with v 1.0.0-beta.19-3 its working fine.

I do use angular-cli v1.0.0-beta-16 so I will try to upgrade it and try again.
Thanks for referencing an issue.

You are right with updated angular-cli (1.0.0-beta.19-3) this is not longer an issue.
Thanks a lot!

fyi - i'm having the same error, using the latest greatest angular-cli (1.0.0-beta.24) with angular 2.3.0. i happen to be using webpack, so not sure if that is a factor after all as suggested above.

@sarora2073 can you tell if you are getting that error in AOT mode only?

No, i'm not doing this in AOT mode.

This seems to be an issue with angular-cli.
For refrence: https://github.com/angular/angular-cli/issues/3426
I need to look into this in detail.

@sarora2073 I just updated ng2-drag-drop to v0.5.1. Now using ngc to build instead of tsc (among other changes). Its now working on angular-cli v1.0.0-beta.24


fix omit function

There is currently a method called omit that lives in /lib/omit.js.
It is incomplete and needs to be fixed!
This function should take an object and a array of key names and return a new object with these keys omitted from it.
Acceptance Criteria:

Running yarn test <methodName> results in tests passing.
You have written a skeleton method for someone else to work on.
You have written tests surrounding your skeleton method.
Running yarn lint does not print any errors to the console!
Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.
Thank you so much for your contribution!

Gimme gimme

It's yours @mr-rodgers !!


Incorrect URL for MeiliSearch + React InstantSearch demo in README

The URL for MeiliSearch + React InstantSearch redirects to the Angular MS Demo.
The correct url is : https://codesandbox.io/s/ms-react-is-sh9ud?fontsize=14&hidenavigation=1&theme=dark

I can take up the issue @ferdi05

yes please go ahead


Feature Request: UNet (U-Shape) from original paper

Hello,
Does anyone know if there's any existing python algorithm that would generate the UNet U-shape from the original paper? Or is it possible to request such a feature? Thank you.

https://github.com/HarisIqbal88/PlotNeuralNet/tree/master/examples/Unet_Ushape

Thanks Munila! I've already taken a look but that is something completely different.
I've made something above using draw.io for now. :)


Feature Request: workspace removal capability

Right now, once a workspace is created, there is no way to remove the workspace. Is it possible to add workspace removal capability to allow user better control the workspace?

This idea is helpful when using workspaces for projects and sub-projects - you can easily create a workspace by name (Issue 123) and bring windows to it, but when done it would be nice if it could go away (without restarting - I have hundreds of windows and that takes too long).
Similarly, renaming a workspace would be useful when you want to repurpose it, or simply have a better name.


Adds a WorkflowView API, as discussed in #61

Linked Issue:

Checklist:

[ ] Did you sign the Contributor License Agreement?
[ ] Is the linter reporting 0 errors?
[ ] Did you comply with our styleguide?
[ ] Is there adequate test coverage for your new code?
[ ] Does the CI pipeline pass?
[ ] Did you update the documentation?
[ ] Did you update the sample app?
[ ] Do we need to increment the minor/major version?
[ ] Did you change the public API?
[ ] Have you done everything you can to make sure that errors that can occur are compile-time errors, and if they have to be runtime do you have adequate tests and documentation around those runtime errors? For more details.

If Applicable:

[ ] Did you test when the first item is skipped?
[ ] Did you test when the last item is skipped?
[ ] Did you test when middle items are skipped?
[ ] Did you test when incorrect data is passed forward?
[ ] Did you test proceeding backwards?

If Public API Has Changed:

[ ] Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
[ ] Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
[ ] If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

Codecov Report

Merging #179 (c86d135) into main (edaedd0) will decrease coverage by 1.62%.
The diff coverage is 55.35%.

@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   91.28%   89.65%   -1.63%
==========================================
  Files          92       94       +2
  Lines        2375     2485     +110
==========================================
+ Hits         2168     2228      +60
- Misses        207      257      +50

Impacted Files
Coverage Δ

...rrent_SwiftUI/ResultBuilders/WorkflowBuilder.swift
38.46% <38.46%> (ø)

...rces/SwiftCurrent_SwiftUI/Views/WorkflowItem.swift
88.60% <60.00%> (-5.47%)
:arrow_down:

...rces/SwiftCurrent_SwiftUI/Views/WorkflowView.swift
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58dd8a8...c86d135. Read the comment docs.

I'm liking this a lot. I think the main thing said against a style similar to this when originally discussing the SwiftUI API was that it didn't feel clear enough that this is an ordered sequence of FR's. I'm not really feeling that so much anymore with this. Having sat with the choice we made about the SwiftUI API, I don't think it was as crucial as we made it out to be.

We did change the public API but I don't know if there's a great way to have the compiler guide people to the new change. This is something the team should discuss before merging.
The changes to WorkflowItem and the lowering of the ACL on WorkflowLauncher are what lead me to think it won't be reasonable to guide people to WorkflowView.

Given the previously approved reviews, I'm going to use admin privilege to merge this as soon as the pipeline is passing.


console.log messages not shown

From<EMAIL_ADDRESS>on September 14, 2014 22:39:07
What steps will reproduce the problem? 1.make a simple hybrid apk with html file that has 'console.log("my_log_message");'
2.test manually & with robotium testcase
3.check log messages What is the expected output? What do you see instead? the log message comes up when I run the app manually. Not seen only when I run the robotium test-case. What version of the product are you using? On what operating system? robotium 5.2.1 on android L preview Please provide any additional information below.
Original issue: http://code.google.com/p/robotium/issues/detail?id=632

From<EMAIL_ADDRESS>on September 15, 2014 03:48:00
Thanks for reporting this.
Status: Accepted
Owner<EMAIL_ADDRESS>

From<EMAIL_ADDRESS>on February 06, 2015 13:47:11
This is not currently prioritised to be fixed.
Status: WontFix


Feature - optionally include Error.cause property

This fixes #2446 by adding optional cause property

@DABH this PR seems simple and would help a lot--could you please take a look?

Can we add a test or modify a test to maintain coverage? 🙏

Can we add a test or modify a test to maintain coverage? 🙏

took me way longer than expected to get back to this. I added a test case, please let me know if ok, I'll make any necessary changes

Any updates for this feature?

@p-herbert I was able to circumvent the issue with a custom formatter
import winston from 'winston'

export const serialize = (error: Error, i = 1): string =>
  `${i}. ${error.stack}\n${'cause' in error ? serialize(error.cause as Error, i + 1) : ''}`

const formatError = winston.format((info) => {
  if (info instanceof Error) {
    return {
      ...info,
      message: serialize(info),
    }
  }

  return info
})

export const logger = winston.createLogger({
  levels: winston.config.npm.levels,
  format: winston.format.combine(winston.format.timestamp(), formatError()),
  transports: [
    new winston.transports.Console({
      format: winston.format.combine(
        winston.format.colorize(),
        winston.format.simple(),
      ),
    }),
  ],
})

This would be very useful.


Create SECURITY.md

Creating security policy for developers to be able to report vulnerabilities in the repository.

Thanks for the contribution!


Add new files category and handle FTP as well

Some usecases such as firmware upgrade need access to FTP server. As most FTP servers are quite archaic it might make sense to set one up to share the same file directory as TFTP.
Add a new Misc/FTP category to the Images handling on the app so you can upload non kernel non initrd images. Because the directory is shared these would be available both by tftp and by ftp.
D0X machines use FTP for firmware upgrade, ThunderX machines use tftp for firmware upgrade so this would work for both types of machine without leaving the app environment.
It is a usecase for Server Architecture/QA teams to replace/test firmwares as ERP firmware is one of our deliverables.

FTP is out of the scope of this project.


Match query params with hash-based routing

I don't think this is possible with properly formatted URLs, since the query param should come before the anchor tag.
https://stackoverflow.com/questions/12682952/proper-url-forming-with-query-string-and-anchor-hashtag
Sure, you can get this working with incorrectly-formatted URLs (query after anchor), but other sites are unlikely to present the URL this way (e.g. github OAuth).
Should I add a note about this in the guide?

There's nothing wrong with have a query-looking part in the anchor, it's perfectly valid according to RFC 3986, it's just that it won't be part of the actual query, it'll be part of the "fragment" (anchor) instead.
So /#foo?bar=baz is a completely valid URI, it's just ?bar=baz will not be treated as a query string by webserver and such.

From the spec:

A fragment identifier component is indicated by the presence of a
number sign ("#") character and terminated by the end of the URI.
   fragment = *( pchar / "/" / "?" )

So you can see from the ebnf there that ? is definitely allowed.

Would it be worth noting the ordering restriction in the guide? For example, we don't want users struggling with trying to figure out how to parse this with hash-based routing:
/?bar=baz#foo

I don't think so... it seems pretty clear to me that hash based routing only deals with things after the #?

Actually, if it tripped you up, I'm wrong in that assumption, and adding a note certainly wouldn't do any harm.


feat(httpProxy): add module for http dynamic receivers

What this PR changes/adds
Add a new module http-dynamic-receiver for sending the EDR to a custom url/callback defined in transfer creation phase by the client.
Why it does that
Flexibility for client applications.
Further notes
For supporting dynamic callback of EDR, a new field properties has been added to TransferProcess in order to store the callback for the EDR in the custom property receiver.http.endpoint.
Once the consumer needs to forward the EDR to the external API, it will look for the correlated transfer process and it will fetch the receiver.http.endpoint property if present.
For security reason the Auth headers are still configurable via EDC properties and not stored in the EDC at runtime.
The only limitation for now is that all the client application needs to share the same header authorization when
working with the EDR APIs.
Linked Issue(s)
Closes #2265
Checklist

[x] added appropriate tests?
[x] performed checkstyle check locally?
[x] added/updated copyright headers?
[x] documented public classes/methods?
[x] added/updated relevant documentation?
[x] assigned appropriate label? (exclude from changelog with label no-changelog)
[x] formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Codecov Report
Base: 64.19% // Head: 64.23% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (b849c26) compared to base (3564487).
Patch coverage: 75.92% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2276      +/-   ##
==========================================
+ Coverage   64.19%   64.23%   +0.03%
==========================================
  Files         823      825       +2
  Lines       17323    17377      +54
  Branches     1085     1089       +4
==========================================
+ Hits        11121    11162      +41
- Misses       5759     5770      +11
- Partials      443      445       +2

Impacted Files
Coverage Δ

...DynamicEndpointDataReferenceReceiverExtension.java
0.00% <0.00%> (ø)

...amic/HttpDynamicEndpointDataReferenceReceiver.java
91.42% <91.42%> (ø)

...flow/ProviderDataPlaneProxyDataFlowController.java
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Shouldn't this new extension be rather into extensions:control-plane:transfer ?

@bscholtes1A yes it's a WIP, i will move it into the new folder

Hi @wolf4ood we had a discussion about this issue and decided, that it would be good to use the former configuration "edc.receiver.http.endpoint" as fallback when the "receiver.http.endpoint" property not set in TransferProcess. See the story in Catena-X board (https://jira.catena-x.net/browse/A1IDSC-371).
As far as I can see you are throwing an error if "receiver.http.endpoint" is not set, could you please use the "edc.receiver.http.endpoint" instead and throw an error only if both are not set. It would be great if you could make this adjustment too.

@tuncaytunc-zf
I've incorporated in the PR the fallback URLt configuration time


Fix enum type for question preparedness; fixes #74

Closing this for now in favor of #76, I'll fix this properly at some point.


it can't work

when I run run_demo.py, errors output
Traceback (most recent call last):
File "run_demo.py", line 46, in
main()
File "run_demo.py", line 36, in main
model = get_crfrnn_model_def()
File "/home/zhengye/crfasrnn_keras/crfrnn_model.py", line 49, in get_crfrnn_model_def
x = Conv2D(64, (3, 3), activation='relu', padding='valid', name='conv1_1')(x)
File "build/bdist.linux-x86_64/egg/keras/engine/topology.py", line 603, in call
File "build/bdist.linux-x86_64/egg/keras/layers/convolutional.py", line 164, in call
File "build/bdist.linux-x86_64/egg/keras/backend/tensorflow_backend.py", line 3183, in conv2d
AttributeError: 'module' object has no attribute 'convolution'

@zhysee This looks like a Keras issue. Can you please run a CNN example in Keras (e.g. https://github.com/fchollet/keras/blob/master/examples/mnist_cnn.py) and make sure your Keras installation works?

See also https://github.com/fchollet/keras/issues/6078 for more details.

when I run run_demo.py, errors output like this：
Traceback (most recent call last):
File "run_demo.py", line 25, in
from crfrnn_model import get_crfrnn_model_def
File "/home/wang/crfasrnn_keras/crfrnn_model.py", line 28, in
from crfrnn_layer import CrfRnnLayer
File "/home/wang/crfasrnn_keras/crfrnn_layer.py", line 28, in
custom_module = tf.load_op_library('./cpp/high_dim_filter.so')
File "/home/wang/tensorflow/local/lib/python2.7/site-packages/tensorflow/python/framework/load_library.py", line 56, in load_op_library
lib_handle = py_tf.TF_LoadLibrary(library_filename, status)
File "/home/wang/tensorflow/local/lib/python2.7/site-packages/tensorflow/python/framework/errors_impl.py", line 473, in exit
c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.NotFoundError: ./cpp/high_dim_filter.so: undefined symbol: _ZTIN10tensorflow8OpKernelE

my env is ubuntu14.04 and i also try in 16.x, however they have the same errors

My pro has been solved. THX

@CHWangXing 你好，我是中国人，我想问一下你是怎么解决这个问题的啊？我现在也遇到了这个问题，我是直接运行./compile.sh，没有什么source的过程？麻烦告知

g++ -std=c++11 -D_GLIBCXX_USE_CXX11_ABI=0 -shared high_dim_filter.cc modified_permutohedral.cc -o high_dim_filter.so -fPIC -I$TF_INC -I$TF_INC/external/nsync/public -O2 -L$TF_LIB -ltensorflow_framework
更改comple.sh文件内容即可，具体原因可以上网百度下。

@zyfsa Hi, where do you find compile.sh


complete container support

This looks like a really promising library, thank you for sharing it.
Looking over the PVE API and the functionality implemented in the library. I was thinking the following enhancements would be helpful:

Implement node.NewContainer()

POST to /nodes/{node}/lxc

Add ContainerConfig struct
Add ContainerConfig field to Container struct
Update node.Container() to include container.Config

This shouldn't break the existing API and bring it in line with existing VirtualMachine behavior. It would also complete CRUD functionality for PVE containers.

i tried to abstract the complexities so most get/put/post/delete aren't much more than a couple lines. you'll do fine and we can fix anything after you put up a PR

@xortim i think someone beat you to it #126, closing this for now but feel free to open new ones if anything was missed


Create SLSC Switch consumer in engine

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Enables the SLSC Switch engine to handle messages from a producer.
Initialization sets configuration and source channels.
Writes values to the status channels.
Why should this Pull Request be merged?
Using the consumer message handler is the fundamental basis for  how the engine will work.
What testing has been done?
Manual test to ensure the Shutdown message is handled by the engine.
Monitored the Heartbeat and Status Code channels to make sure they behave as expected.
More functional testing can't be completed until the Routing and Faulting custom device is functional.

Where do we plan to write the heartbeat channel?

The heartbeat channel is already written in Write Output Channels.vi.


Admin url not working and link not showing

So i am having a issue with getting the admin ui working.
I enabled development mode and development.config.php is loaded and contains:
<?php
return [
    'modules' => [
        'ZF\\Apigility\\Admin\\Ui',
    ],
];

But nothing shows and the admin path does not work. So after doing some reading im unsure what documentation to follow.

https://apigility.org/documentation/modules/zf-apigility-admin talks about the module Admin and not Admin\Ui
https://github.com/zfcampus/zf-apigility-admin-ui talks about Admin\Ui but nothing shows...

    "require": {
        "php": "^5.5 || ^7.0",
        "zfcampus/zf-apigility": "^1.3",
        "zfcampus/zf-apigility-documentation": "^1.2",
        "woonon/core": "dev-master",
        "zfcampus/zf-oauth2": "^1.4",
        "zendframework/zend-cache": "^2.7",
        "zendframework/zend-mvc-i18n": "^1.0",
        "zendframework/zend-log": "^2.9"
    },
    "require-dev": {
        "zfcampus/zf-apigility-admin": "^1.5",
        "zfcampus/zf-apigility-admin-ui": "^1.3",
        "zfcampus/zf-deploy": "~1.0",
        "zfcampus/zf-asset-manager": "^1.0",
        "zfcampus/zf-development-mode": "^3.0",
        "zendframework/zend-developer-tools": "^1.1"
    }

This is not an issue with the repo but rather an issue with your configuration of LAMP(or LEMP these dayz).
Please verify your error logs in order to investigate. Let us know if you find anything relevant to this project.

Right so it turns out this is not perse a admin-ui issue, rather a documentation issue.
In the development config modules we not only add ZF\\Apigility\\Admin\\Ui but we also MUST add ZF\\Apigility\\Admin. This is nowhere mentioned in the docs.


training operator pod in CrashLoopBackOff, failed to wait for mpijob-controller caches to sync

2023-08-02T06:21:33Z	INFO	setup	starting manager
2023-08-02T06:21:33Z	INFO	setup	registering controllers...
2023-08-02T06:21:33Z	INFO	starting server	{"path": "/metrics", "kind": "metrics", "addr": "[::]:8080"}
2023-08-02T06:21:33Z	INFO	Starting server	{"kind": "health probe", "addr": "[::]:8081"}
2023-08-02T06:21:33Z	INFO	Starting EventSource	{"controller": "mpijob-controller", "source": "kind source: *v1.MPIJob"}
2023-08-02T06:21:33Z	INFO	Starting EventSource	{"controller": "mpijob-controller", "source": "kind source: *v1.Pod"}
2023-08-02T06:21:33Z	INFO	Starting EventSource	{"controller": "mpijob-controller", "source": "kind source: *v1.ConfigMap"}
2023-08-02T06:21:33Z	INFO	Starting EventSource	{"controller": "mpijob-controller", "source": "kind source: *v1.Role"}
2023-08-02T06:21:33Z	INFO	Starting EventSource	{"controller": "mpijob-controller", "source": "kind source: *v1.RoleBinding"}
2023-08-02T06:21:33Z	INFO	Starting EventSource	{"controller": "mpijob-controller", "source": "kind source: *v1.ServiceAccount"}
2023-08-02T06:21:33Z	INFO	Starting Controller	{"controller": "mpijob-controller"}
2023-08-02T06:22:33Z	INFO	Starting EventSource	{"controller": "paddlejob-controller", "source": "kind source: *v1.PaddleJob"}
2023-08-02T06:22:33Z	INFO	Starting EventSource	{"controller": "paddlejob-controller", "source": "kind source: *v1.Pod"}
2023-08-02T06:22:33Z	INFO	Starting EventSource	{"controller": "paddlejob-controller", "source": "kind source: *v1.Service"}
2023-08-02T06:22:33Z	INFO	Starting Controller	{"controller": "paddlejob-controller"}
2023-08-02T06:23:03Z	ERROR	controller-runtime.source.EventHandler	failed to get informer from cache	{"error": "failed to get API group resources: unable to retrieve the complete list of server APIs: kubeflow.org/v1: Get \"https://<IP_ADDRESS>:443/apis/kubeflow.org/v1\": dial tcp <IP_ADDRESS>:443: i/o timeout"}
2023-08-02T06:23:33Z	ERROR	Could not wait for Cache to sync	{"controller": "mpijob-controller", "error": "failed to wait for mpijob-controller caches to sync: timed out waiting for cache to be synced for Kind *v1.MPIJob"}
2023-08-02T06:23:33Z	INFO	Stopping and waiting for non leader election runnables
2023-08-02T06:23:33Z	INFO	shutting down server	{"path": "/metrics", "kind": "metrics", "addr": "[::]:8080"}
2023-08-02T06:23:33Z	INFO	Stopping and waiting for leader election runnables
2023-08-02T06:23:33Z	INFO	Starting workers	{"controller": "paddlejob-controller", "worker count": 1}
2023-08-02T06:23:33Z	INFO	Shutdown signal received, waiting for all workers to finish	{"controller": "paddlejob-controller"}
2023-08-02T06:23:33Z	INFO	All workers finished	{"controller": "paddlejob-controller"}
2023-08-02T06:23:33Z	INFO	Stopping and waiting for caches
2023-08-02T06:24:03Z	ERROR	setup	problem running manager	{"error": "[failed to wait for mpijob-controller caches to sync: timed out waiting for cache to be synced for Kind *v1.MPIJob, failed waiting for all runnables to end within grace period of 30s: context deadline exceeded]", "errorCauses": [{"error": "failed to wait for mpijob-controller caches to sync: timed out waiting for cache to be synced for Kind *v1.MPIJob"}, {"error": "failed waiting for all runnables to end within grace period of 30s: context deadline exceeded"}]}```

Is mpijob CRD correct installed ?

my crd list :
bgppeers.crd.projectcalico.org                        2023-07-26T06:31:18Z
blockaffinities.crd.projectcalico.org                 2023-07-26T06:31:18Z
caliconodestatuses.crd.projectcalico.org              2023-07-26T06:31:18Z
clusterinformations.crd.projectcalico.org             2023-07-26T06:31:18Z
felixconfigurations.crd.projectcalico.org             2023-07-26T06:31:18Z
globalnetworkpolicies.crd.projectcalico.org           2023-07-26T06:31:18Z
globalnetworksets.crd.projectcalico.org               2023-07-26T06:31:18Z
hostendpoints.crd.projectcalico.org                   2023-07-26T06:31:18Z
ipamblocks.crd.projectcalico.org                      2023-07-26T06:31:18Z
ipamconfigs.crd.projectcalico.org                     2023-07-26T06:31:18Z
ipamhandles.crd.projectcalico.org                     2023-07-26T06:31:18Z
ippools.crd.projectcalico.org                         2023-07-26T06:31:18Z
ipreservations.crd.projectcalico.org                  2023-07-26T06:31:18Z
kubecontrollersconfigurations.crd.projectcalico.org   2023-07-26T06:31:18Z
mpijobs.kubeflow.org                                  2023-08-02T04:09:55Z
mxjobs.kubeflow.org                                   2023-08-02T04:09:55Z
networkpolicies.crd.projectcalico.org                 2023-07-26T06:31:18Z
networksets.crd.projectcalico.org                     2023-07-26T06:31:18Z
paddlejobs.kubeflow.org                               2023-08-02T04:09:56Z
pytorchjobs.kubeflow.org                              2023-08-02T04:09:56Z
tfjobs.kubeflow.org                                   2023-08-02T04:09:56Z
xgboostjobs.kubeflow.org                              2023-08-02T04:09:56Z```

how to apply controller in my k8s ?
i only exec kubectl apply -k ./kubeflow/training-operator/manifests/overlays/standalone

How can this issue be reproduced  ?

i get the same err, just  both apply  v1 and  v2beta1 crd of mpijob to  k8s  to fix
itttps://github.com/kubeflow/training-operator/blob/master/manifests/base/crds/kubeflow.org_mpijobs.yaml

It is bit strange. you just need v1  crd if you are using training operator.


Domain activation is Failed - [BRIEF DESCRIPTION]

App Id: d3pra1i98n24cg
Region: us-east-2
Step: Domain activation
Status: Failed
Error message
Error message: One or more of the CNAMEs you provided are already associated with a different resource.
Notes
We used the domain before for a CloudFront distribution but we deleted everything.

@ryanm43 It seems like your domain works fine now (www.roxxxxxxxxar.com & testapp.roxxxxxxxxar.com). If you face the same issue, please let us know.


Can Barely do a moderate infusion

I don’t know why I can’t even do moderate infusions peacefully! I have 12 candles and 24 skulls around my altar. I have 5 stabilizers directly pointing at the matrix that are receiving from a source producing 16k RF per tick and everything is symmetrical, even the stabilizers. Even with all that, my altar goes crazy at a moderate level infusion. It starts out as Very Stable and goes to dangerously unstable within a few seconds. I have 4 speed boosters if that matters. I’m not sure how I’m supposed to make the item that closes rifts if I can't even handle a moderate infusion!

so, first off, now you are limited to only 10 occult items, such as candles and skulls.
secondly, did you place the items in radial symetry or bilateral symetry (the correct is the prior).
did you place the items in the pedestals in the same arrengement as in the thaumonomicon and, once again, with radial symmetry?
if possible can you provide me/us with pictures of your setup and it doing an infusion?
infusion is quite broken currently, but with such a ridiculous (positively so) setup as yours, i don't think it would be so unstable.
also, sorry if i sound rude, i tend to, but that is not my intention.

![2018-07-06_21 46 56](https://user-images.githubusercontent.com/29665124/42406068-4602bf30-8166-11e8-9442-2a30a4f7484
ignore the area beyong the arcane stone floor, its either decorational or essentia

Oh wow...you're using a powerful RF source from an external mod instead of the wimpy Vis Generators, and a Moderate infusion is still dangerously unstable?
That's extremely troubling. Your setup looks like it should not just be fine, but over-the-top excessively fine.

I managed to pull off a brain in a jar infusion but it was extremely irritating and it was always at dangerous instability. I tried headband of knowledge and it almost destroyed my entire setup

Wow, that was a lot to process. But now I understand how these stabilizers work but I have 6 stabilizers so I should have 0.73. According to your calculations moderate takes 0.8 to 1 so removing speed would probably bring me up to that and adding cost stones while would increase my boredom level from 0.5 to 1 would allow time to do all moderate infusions.  Seems a little overkill

The numbers are obviously still being balanced, but I find it incredibly interesting.  Actually needing to swap out the cost/speed stones based on the recipe you're making is really cool, and the careful stability balance feels like it could be super fun if it were a tiny bit more forgiving.

I managed to do a moderate infusion that left the altar switching between stable in very stable mid infusion by having max candles 6 max stabilizers and 4 cost stones. But I still doubt I’ll be able to do a very high infusion

It looks like you can have more than 6 stabilizers. From my experience, stabilizers do not block each other and can stabilize a matrix through solid blocks. In other words, you can have up to around 22 stabilizers on an infusion matrix.

@belathus  I've just tested that - you can fit 23 within range of the Matrix. (Three below, four in each other direction.) It seems to work, although some of the stabilizers seemed to cut out midway through a Moderate infusion - that many Vis Generators in a small area might be putting a strain on the aura. I think I might get even better results after building a few dozen more Vis Batteries to keep the Generators fed.
@apmax @IMewco  Agreed - while it's been interesting working out the details of how to perform infusions under such unforgiving conditions, the current balance seems to be tilted towards absurdly aggressive min-maxing.

@Reassembly I'm afraid just a few dozens of vis batteries will not be enough. In my tests with a series of runic shield infusions, each infusion used around 300k RF for +1 (moderate instability), 650k RF for +2 (moderate) and 1.1M RF for +3 (high). Another test with grinning devil infusion (very high) used around 1.8M RF. These values correspond to around 30 vis batteries for runic shield +1, around 65 for +2, around 110 for runic shield +3, and around 180 for grinning devil.  (As a side note, 10 candles + 13 fully powered stabilizers were enough for the grinning devil infusion.) The balance does indeed seem to be off.

Do the stabilizers have to be directly facing the matrix?

They do.

How would one set up 20 stabilizers? There would need to be a block or wire connecting them to a power source between each stabilizer

If they take up 2 blocks each in the axis pointing towards the matrix, you could fit about 4 in each direction within an 8 block range, with 5 directions possible, for roughly 20 of them total.
Needing 20 stabilizers seems wholly unintended, though it's very possible there will end up being more ways to improve the function of your infusion altar beyond the stabilizers, as more development occurs.

I managed to fit 16 and I’ll try to make a collapser hopefully I don’t run into any errors

Sounds like it worked. Awesome.

Related to the issue I created earlier - https://github.com/Azanor/thaumcraft-beta/issues/1093

@yunruiwatts  Thanks for linking that - I was just thinking of looking that up myself. If Azanor is making Stabilizers able to accept power on five sides, that should increase the amount of stability they're able to output (without RF mod wires) - requiring fewer Stabilizers using more Generators each.
@corhydrae 180?!?  ...I'm going to need more quartz.

@Reassembly I am fairly certain that the power of just 23 generators is not even near to the power required for very high instability infusions. Note that my grinning devil infusion test was actually finished in roughly a minute I think, because my setup was using 1300 RF/t (13 stabilizers * 100 RF/t/stabilizer), which corresponds to the power of 130 vis generators.

I think rather then increasing the power of a single stabilizer a good solution would be to provide better generators (20RF/t, 30RF/t, etc) and a way to transfer energy from afar (some sort of wire maybe) so that players will be able to max stabilizer power. Another enhancement I can think of is that stabilizers need not be facing the matrix directly instead anywhere within a 4 block radius or 8 block diamanter of the matrix. And maybe add a stabilizer limit as well so it doesn’t go out of hand. Upgraded stabilizers could also be another solution

Hmm, looks like the numbers need some tweaking.

Also I should note - having MORE than 10 candles/skulls/etc. around the altar will actually worsen the stability.
In b18 I will up the stability they provide to .02 and up the max amount to 16 (for a total of .32 stability). I will also make it a bit clearer in the research entry that 16 is the limit.

@Azanor  Did that change very recently? There doesn't seem to be anything in the code (b17) that would reduce stability for more than 10 candles. Also, after running a few tests (identical except for number of candles, restoring from backup between tests) there doesn't seem to be an observable difference between 10, 12, and 68 (symmetrical) candles - but there was a very noticeable loss of stability between 10 and 0 candles.

Nope, you are right. I checked the code again and more than the 10 candles won't do anything.


Add call to create PR in AzDo servicing.

Fixes https://github.com/dotnet/source-build/issues/3069.
Release pipieline dry run is at https://dnceng.visualstudio.com/internal/_build/results?buildId=2138107&view=results.

@crummel - It appears that the dry-run you linked to failed prior to invoking the affected code.  Could you please link to a PR created by these changes?

I did end up having an auth problem and having to do some debugging - I've pushed those changes.  The internal CI ran https://dnceng.visualstudio.com/internal/_build/results?buildId=2139683&view=logs&j=3a04dffd-22cf-5707-fa41-9bd4708cc1db&t=102abc8f-88d1-56a3-f0d3-e5f498d0f4f9 and produced the PR https://dev.azure.com/dnceng/internal/_git/security-partners-dotnet/pullrequest/30092.


Add composer.json for convenient use with PHP apps

This allows PHP based apps to require Bourbon conveniently via their composer file and use it as such: scss --load-path vendor/thoughtbot/bourbon/core some-stylesheet.scss.
For more info on composer: http://getcomposer.org/
If this PR is approved, Bourbon should be submitted to https://packagist.org.

Thanks for the PR, @shnhrrsn!
At this time, we’re not interested in officially supporting Composer or PHP-based package managers. It’s rare for us to work with PHP at thoughtbot and we want to make sure if we are going to support something, that we have the knowledge and experience to do it right.
We’ve had people from the community wrap Bourbon and provide installation via other package managers in the past, so if that is something you’d be interested in, we’d welcome that!


Any filters or level control in v3 Get?

we are trying migrate data from v2 to v3. however we have to face a problem is in v2, we can list nodes in a directory without recursive but in v3 withPrefix will list all keys like force recursive in v2.
so is there any filters or level control in v3 get operation ?
for example, we have a data like this
/a/1/a
/a/1/b
/a/1/c
/a/2/a
/a/2/b
/a/3/c
/a/3/b

in v2, we can get "/a" then we know under directory a, there are 3 nodes (1,2,3). we will do something with those keys. if we get "/a" without prefix in v3, there is no response. but if we get with prefix all keys will return to client. we have to filter by ourselves.

@CMGS v3 uses a flat keyspace, it doesn't know about directories. The keys can be encoded with depth information to get efficient directory-level listing like:
000/a/
001/a/1/
001/a/2/
001/a/3/
002/a/1/a
002/a/1/b
...

the directories immediately under /a/ would be fetched with Get(context.TODO(), "001/a/", WithPrefix())

@heyitsanthony I know v3 use a flat keyspace so there is no directory any more. but in this case, it will change much logical in real projects and migration process will not smoothly. I think it's a bit ridiculous.
in our real online cluster, we had many directories (100k+). and the business logical depend on those directories' name to do right things. according to official migration guide, offline will be better. thus encode directory's name with depth information will take a long time and make keys more than before. we have to spend more time on check it and modify our logical to fit it. I don't think it's a good idea. however, if there is any pattern methods or filters built in, things will be easy.

@CMGS ok, wait for the v2 emulation proxy; there are no plans to support directories natively in v3. Filtering and pattern matching would be too slow; processing ls / would have to churn through the entire data store.

@heyitsanthony sounds great! any roadmap for v2 emulation proxy?

@CMGS experimental in 3.3, stable in 3.4

got it thank you

Can v3.3 be used? If there is an example?


Regression with opening PopupContextMenu from within Status bar popover

Describe the bug
When PopupContextMenu is invoked by clicking a button inside an opened status bar popover component, it briefly renders the context menu behind the parent component and immediately closes both.
To Reproduce

Create a status bar popover component with a button that triggers a PopoverContextMenu from @itwin/core-react
Open the status bar popover component from the status bar
Click the button to trigger the context menu
Both, the context menu, and the popover component are closed

Expected Behavior
Context menu should be rendered on top of the parent status bar popover component and not close the popover.
Last iTwin.js AppUI version where it seems to be working correctly is 4.13.3.
Screenshots
No response
Desktop (please complete the applicable information)

OS: Windows 11
Browser: Chromium (within Electron)
Browser version: v124
iTwin.js AppUI version: v4.14.1
iTwin.js version: v4.7.3

Additional context
No response

In AppUI 4.16.0 the PopupContextMenu will be deprecated. As replacements DropdownMenu or DropdownButton from iTwinUI can be used. They should work fine in status bar popovers.
However, if that is not suitable for you and you need this fixed please provide some minimal code that reproduces this bug because I cannot seem to reproduce this exact problem.

I believe the problem is fixed in #912. It will be released in version 4.15.3.


settings: Use correct email when searching users.

If we aren't showing users emails, then we don't
want to use emails in the search.
And if we are showing users emails, we want to
search on the email that's displayed to them.
For admins this will be delivery_email.
For regular users we arguably shouldn't search
on emails either, since it mostly causes confusion,
but this commit just preserves the current
behavior for those users (unless show_email is
false).

Testing Plan:
GIFs or Screenshots:

Merged, thanks @showell!