Invalid schema definitions don't raise errors

It seems that it is possible to create "invalid" schema definitions that don't raise any errors but silently don't do what you'd expect them to do.
I just have one example, I'm not sure how exactly this can be generalised:
require "dry-validation"

SCHEMA = Dry::Validation.Form do
  required(:is_last).bool?
  required(:foo).filled
end

input = { "is_last" => true, "foo" => "bar" }
data = SCHEMA.(input).to_h
puts "foo: #{data[:foo]}"
puts "is_last: #{data[:is_last]}"

output:
foo: bar
is_last:

In order to fix this, one has to change the is_lastdefinition to
required(:is_last).value(:bool?)

What I would expect:
That the schema definition is validated somehow in order to prevent you from introducing bugs like this without realising it.
Also, maybe the usage of value could be made a bit clearer in the documentation.

It will throw an error in the next version
./bin/console:8:in `block in <main>': undefined method `bool?' for #<Dry::Schema::Macros::Required:0x00007fd55514f820> (NoMethodError)


python312Packages.base64io: 1.0.3 -> 1.0.3-unstable-2023-10-30

Fixes the base64io build for Python 3.12 on Hydra: https://hydra.nixos.org/job/nixpkgs/trunk/python312Packages.base64io.x86_64-linux
Diff: https://github.com/aws/base64io-python/compare/1.0.3...604817576e607d1f7f8af1ffa1530522fd4e4be2
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build python312Packages.base64io

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3749

Result of nixpkgs-review pr 296018 run on x86_64-linux 1

2 packages failed to build:

aws-encryption-sdk-cli
aws-encryption-sdk-cli.dist

4 packages built:

python311Packages.base64io
python311Packages.base64io.dist
python312Packages.base64io
python312Packages.base64io.dist

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1591


slider animation

Is there a way to trigger animation of text for slider instead of scrolling? i.e. tha parent "li" get the "active" class on it.
I tried to initialize boxclass as '.active .wow' but in the console i get a syntax error

Without wow.js you can try something like this
/*css*/
.slider .active .text { /*animation name*/}

    hello

    goodbye


web debugging support for enhanced enums

See https://github.com/dart-lang/sdk/issues/47849 for the main tracking issue.

cc @annagrin

This is likely simply require adding a few tests for the debugger and expression evaluation. We expect the implementation to be entirely handled by the CFE lowering, though.

The work required:

adding tests for new expressions in expression evaluation tests,
validating that completion works in devtools

Update: tests added in https://github.com/dart-lang/sdk/commit/e68c3e8bc86bd07ebd39886544444125f9de1e5c

@Markzipan - I'm closing this assuming there is nothing more to do, but please reopen if I missed something.


Line-height breaks placeholders

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
When using line-height or another style property with percentage sign, placeholders don't work anymore.
Or, percentage signs in style attributes should be ignored for placeholders.
To Reproduce
Steps to reproduce the behavior:

create text node with %test%
Ctrl+m and add property test with any value to your liking, make sure to check "placeholders" checkbox. Click Apply
Placeholder work for now.
Double click text box, to select. Then single click to deselect but keep cursor.
In text properties, adjust line height.
Placeholder now breaks (only %test% is shown)

Workaround:

Extra -> Edit Diagram ...
Replace the set line-height (which has a percentage value), with a value defined as px or pt.
Ok
Placeholder works again.

Expected behavior
Placeholder should have been replaced.
draw.io version

draw.io version 15.1.3 on linux desktop and 15.3.4 on chromium

Desktop (please complete the following information):

OS: Linux
Browser Chromium
Version 93.0.4577.82

Quick workaround for the GUI: change line-height from percentage to a unitless value. (Which is apparently preferred way according to MDN)

Thanks for the report. This will be fixed in the next release.

In 15.4.1

That was fast, thanks!


gcc8 compile errors

GCC 8 is complaining about memcpy with atomics
will add some type traits stuff probably to do memcpy for non -atomics and a loop for atomics

possible SWIG issue found also
https://github.com/swig/swig/issues/1379

swig is updated


exploitdb: 2023-12-07 -> 2023-12-12

Diff: https://gitlab.com/exploit-database/exploitdb/-/compare/refs/tags/2023-12-07...2023-12-12
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.


Adding MTH CUIs to AdministrativeGender VS

Adding MTH CUIs to AdministrativeGender VS

This pull request has been overcome by events.


add multi proposal operator (cpu version) and fix the bug in proposal op (gpu version)

Description
The multi_proposal operator (mxnet.sym.contrib.MultiProposal, CPU version) is not implemented before.
I wrote the code about it.
And I found there was a bug in proposal.cu and multi_proposal.cu.
The batch_size of the output of Proposal and MultiProposal are both param_.rpn_post_nms_top_n.
When count_anchors < param_.rpn_post_nms_top_n, the variable rpn_post_nms_top_n will be count_anchors, which is less than param_.rpn_post_nms_top_n.
https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/proposal.cu#L438
It will cause the problem that the output whose index is larger than rpn_post_nms_top_n will be not assigned.
 I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Multi Proposal Operator is supported on the CPU context.
[x] Add unit-test for Multi Proposal Operator
[x] Fix PrepareOutput bug in proposal op (GPU) and multi_proposal op(GPU)

Comments
Here is the testing code.
import mxnet as mx
from mxnet import nd
import numpy as np

feature_stride = 16
scales = (8, 16, 32)
ratios = (0.5, 1, 2)
rpn_pre_nms_top_n = 12000
rpn_post_nms_top_n = 2000
threshold = 0.7
rpn_min_size = 16

batch_size = 20
feat_len = 14
H, W = feat_len, feat_len
num_anchors = len(scales) * len(ratios)
count_anchors = feat_len * feat_len * num_anchors

'''
    cls_prob: (batch_size, 2 * num_anchors, H, W)
    bbox_pred: (batch_size, 4 * num_anchors, H, W)
    im_info: (batch_size, 3)
'''

cls_prob = nd.empty((batch_size, 2 * num_anchors, H, W), dtype = np.float32)
bbox_pred = nd.empty((batch_size, 4 * num_anchors, H, W), dtype = np.float32)
im_info = nd.empty((batch_size, 3), dtype = np.float32)

cls_prob = nd.array(np.random.random(cls_prob.shape))
bbox_pred = nd.array(np.random.random(bbox_pred.shape))

for i in range(batch_size):
    im_size = np.random.randint(100, feat_len * feature_stride, size = (2,))
    im_scale = np.random.randint(70, 100) / 100.0
    im_info[i, :] = [im_size[0], im_size[1], im_scale]

def get_sub(arr, i):
    new_shape = list(arr.shape)
    new_shape[0] = 1
    res = arr[i].reshape(new_shape)
    return res

def test(rpn_pre_nms_top_n, rpn_post_nms_top_n):

    single_proposal = []
    single_score = []
    for i in range(batch_size):
        rois, score = mx.nd.contrib.Proposal(
                cls_score = get_sub(cls_prob, i),
                bbox_pred = get_sub(bbox_pred, i),
                im_info = get_sub(im_info, i),
                feature_stride = feature_stride,
                scales = scales,
                ratios = ratios,
                rpn_pre_nms_top_n = rpn_pre_nms_top_n,
                rpn_post_nms_top_n = rpn_post_nms_top_n,
                threshold = threshold,
                rpn_min_size = rpn_min_size, output_score = True)
        single_proposal.append(rois)
        single_score.append(score)

    multi_proposal, multi_score = mx.nd.contrib.MultiProposal(
            cls_score = cls_prob,
            bbox_pred = bbox_pred,
            im_info = im_info,
            feature_stride = feature_stride,
            scales = scales,
            ratios = ratios,
            rpn_pre_nms_top_n = rpn_pre_nms_top_n,
            rpn_post_nms_top_n = rpn_post_nms_top_n,
            threshold = threshold,
            rpn_min_size = rpn_min_size, output_score = True)

    single_proposal = nd.stack(*single_proposal).reshape(multi_proposal.shape)
    single_score = nd.stack(*single_score).reshape(multi_score.shape)

    single_proposal_np = single_proposal.asnumpy()
    multi_proposal_np = multi_proposal.asnumpy()

    single_score_np = single_score.asnumpy()
    multi_score_np = multi_score.asnumpy()
    print (multi_proposal_np.shape)

    # test rois x1,y1,x2,y2
    assert np.allclose(single_proposal_np[:, 1:], multi_proposal_np[:, 1:])
    # test rois batch_idx
    for i in range(batch_size):
        start = i * rpn_post_nms_top_n
        end = start + rpn_post_nms_top_n
        assert (multi_proposal_np[start:end, 0] == i).all()

    # test score
    assert np.allclose(single_score_np, multi_score_np)

test(rpn_pre_nms_top_n, rpn_post_nms_top_n)
test(rpn_pre_nms_top_n, 1500)
test(1000, 500)
print ("test ok")

Thanks for adding the CPU implementation.. Would you like to add test cases for it, so the operator can be checked in jenkins.

Could you add a cpu/gpu consistency test in tests/python/gpu/test_operator_gpu.py?

@piiswrong Yes, I will add it.

I wrote a cpu/gpu consistency test for Proposal and MultiProposal.
I found there is difference between the CPU output and the GPU output for mx.nd.contrib.Proposal.
It seems that the index order of Nonmaximum may be different.
And another problem is that it may need to add the condition num_to_keep < rpn_post_nms_top_n
https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/proposal.cu#L341
reference: https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/proposal.cc#L235
Here is the cpu/gpu consistency test.
import mxnet as mx
import numpy as np

# @with_seed()
def test_multi_proposal_op():
    # paramters
    feature_stride = 16
    scales = (8, 16, 32)
    ratios = (0.5, 1, 2)
    rpn_pre_nms_top_n = 12000
    rpn_post_nms_top_n = 2000
    threshold = 0.7
    rpn_min_size = 16

    feat_len = 14
    H, W = feat_len, feat_len
    num_anchors = len(scales) * len(ratios)
    count_anchors = H * W * num_anchors

    def get_new_data(batch_size, ctx):
        '''
        cls_prob: (batch_size, 2 * num_anchors, H, W)
        bbox_pred: (batch_size, 4 * num_anchors, H, W)
        im_info: (batch_size, 3)
        '''

        cls_prob = mx.nd.empty((batch_size, 2 * num_anchors, H, W), dtype = np.float32, ctx = ctx)
        bbox_pred = mx.nd.empty((batch_size, 4 * num_anchors, H, W), dtype = np.float32, ctx = ctx)
        im_info = mx.nd.empty((batch_size, 3), dtype = np.float32, ctx = ctx)

        cls_prob = mx.nd.array(np.random.random(cls_prob.shape), ctx = ctx)
        bbox_pred = mx.nd.array(np.random.random(bbox_pred.shape), ctx = ctx)

        for i in range(batch_size):
            im_size = np.random.randint(100, feat_len * feature_stride, size = (2,))
            im_scale = np.random.randint(70, 100) / 100.0
            im_info[i, :] = [im_size[0], im_size[1], im_scale]
        return cls_prob, bbox_pred, im_info

    def check_proposal_consistency(op, batch_size):
        '''
            op is mx.nd.contrib.Proposal or mx.nd.contrib.MultiProposal
        '''
        cls_prob, bbox_pred, im_info = get_new_data(batch_size, mx.cpu(0))
        rois_cpu, score_cpu = op(
                cls_score = cls_prob,
                bbox_pred = bbox_pred,
                im_info = im_info,
                feature_stride = feature_stride,
                scales = scales,
                ratios = ratios,
                rpn_pre_nms_top_n = rpn_pre_nms_top_n,
                rpn_post_nms_top_n = rpn_post_nms_top_n,
                threshold = threshold,
                rpn_min_size = rpn_min_size, output_score = True)

        gpu_ctx = mx.gpu(0)

        # copy data to gpu from cpu
        cls_prob_gpu = cls_prob.as_in_context(gpu_ctx)
        bbox_pred_gpu = bbox_pred.as_in_context(gpu_ctx)
        im_info_gpu = im_info.as_in_context(gpu_ctx)

        rois_gpu, score_gpu = op(
                cls_score = cls_prob_gpu,
                bbox_pred = bbox_pred_gpu,
                im_info = im_info_gpu,
                feature_stride = feature_stride,
                scales = scales,
                ratios = ratios,
                rpn_pre_nms_top_n = rpn_pre_nms_top_n,
                rpn_post_nms_top_n = rpn_post_nms_top_n,
                threshold = threshold,
                rpn_min_size = rpn_min_size, output_score = True)

        print (rois_cpu.asnumpy(), rois_gpu.asnumpy())
        assert np.allclose(rois_cpu.asnumpy(), rois_gpu.asnumpy())
        assert np.allclose(score_cpu.asnumpy(), score_gpu.asnumpy())

    check_proposal_consistency(mx.nd.contrib.Proposal, 1)
    check_proposal_consistency(mx.nd.contrib.MultiProposal, 20)

test_multi_proposal_op()
print ("test ok")

@pengzhao-intel Thank you! I will have a try.

@wkcn What's the size of your for-loop in the test-case?
How can I test your code?

@pengzhao-intel Here is the testing code.
https://gist.github.com/wkcn/4a09c142bc9886b45b5a23461bbe4733
I found that I made a mistake that I didn't use nd.waitall() to test the performance.
If not using nd.waitall(), the calculation will not execute because of lazy-evaluation.

@wkcn Nice work for the parallelization by OMP. 2X speedup is a good start point.
I see you have added several OMP in the code.
Could you help profile where is the performance bottleneck now?
PS: you may need to add gettimeofdate in your C code and identify the most time-consuming loop (or section).

@wkcn @pengzhao-intel I think there are so much units in multi_proposal.cc. We can help find which unit is the bottleneck and then fix it.

@pengzhao-intel @xinyu-intel
Thank you! I will have a try.

For the cpu/gpu consistency, it's interesting that the number of valid anchors in the CPU implementation and the GPU implementation may be different.
The reason is that the float precision in CPU's and GPU's is different.
The size of some anchors may be near the margin of the minimal valid anchor or the maximal valid anchor.
The margin of the minimal valid anchor:
https://github.com/wkcn/incubator-mxnet/blob/add_multi_proposal_cpu_version/src/operator/contrib/multi_proposal.cc#L159
The margin of the maximal valid anchor.
https://github.com/wkcn/incubator-mxnet/blob/add_multi_proposal_cpu_version/src/operator/contrib/multi_proposal.cc#L89
I want to create testing sample to avoid these margins.

@marcoabreu
The reason to add USE_STABLE_SORT_FOR_PROPOSAL flag is for the cpu/gpu consistency test.
Proposal Operator (CPU) uses unstable sort to sort the anchors by scores, however Proposal Operator (GPU) uses stable sort.
For the performance, I couldn't replace unstable sort with stable sort in Proposal (CPU).
And for the cpu/gpu consistency test, I think it's necessary to use a building flag to test these operator.

@marcoabreu
Hello! Could you please retrigger the test?
It seems that test_operator_gpu.test_deconv has some problem.
And I have removed  'USE_STABLE_SORT_FOR_PROPOSAL'  building flag.
Thank you!

Hi, you can just create an empty commit to trigger the CI yourself  :)
JackieWu<EMAIL_ADDRESS>schrieb am Di., 6. März 2018, 07:49:

@marcoabreu https://github.com/marcoabreu
Hello! Could you please retrigger the test?
It seems that test_operator_gpu.test_deconv has some problem.
And I have removed 'USE_STABLE_SORT_FOR_PROPOSAL' building flag.
Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-mxnet/pull/9939#issuecomment-370681494,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARxB60WFPEI1M-bpfgc0ROyVoDjozvq5ks5tbjF4gaJpZM4SXzsy
.

@marcoabreu Thank you:) I will commit it soon.

Hi, the community has passed to vote about associating the code changes with JIRA<EMAIL_ADDRESS>We have updated the guidelines for contributors in https://cwiki.apache.org/confluence/display/MXNET/Development+Process, please ensure that you have created a JIRA at https://issues.apache.org/jira/projects/MXNET/issues/ to describe your work in this pull request and include the JIRA title in your PR as [MXNET-xxxx] your title where MXNET-xxxx is the JIRA id
Thanks!

@pengzhao-intel Thank you!

@CodingCat I will read it. Thank you!

@marcoabreu @szha @cjolivier01
Hello!
For Changes Requested, I have removed the USE_STABLE_SORT_FOR_PROPOSAL flag and recovered the building setting.
Could you please review and merge the PR?
Thank you!

@marcoabreu Thank you! :)

@wkcn Hi looks like the multi proposal operator fails randomly. Do you have any idea?
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/PR-10161/5/pipeline/549#step-919-log-1763

@piiswrong
Sorry, I think the score of invalid anchors is assigned to -1. The CPU implementation uses unstable-sort (std::sort), but GPU implementation uses stable-sort(thrust::stable_sort_by_key). It leads to inconsistency in invalid anchors.
The cpu/gpu consistency couldn't be guaranteed when the output has invalid anchors whose score is -1.
https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/multi_proposal.cc#L89
https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/multi_proposal.cc#L141
https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/multi_proposal.cc#L159
I followed Proposal Operator and Multi Proposal (GPU) to implement Multi Proposal (CPU).
The output of Proposal Operator may have invalid anchors, but invalid anchors is needless. (reference:
https://github.com/apache/incubator-mxnet/blob/master/example/rcnn/rcnn/symbol/proposal.py#L133)
There are three ways to solve the cpu/gpu consistency test in Proposal and MultiProposal:

Ignoring the comparison between invalid anchors whose score is -1
Using stable-sort for the CPU implementation
Removing invalid anchors from the output.

Hello @wkcn, thanks a lot for the quick response! Do you have an ETA when this is going to be resolved? As stated by eric, we're experiencing a significant number of test failures which is impacting the overall results of our CI.

@marcoabreu Sorry. I'm fixing it.
https://github.com/wkcn/incubator-mxnet/tree/fix_multi_proposal_op_consistency_test
When I finish it, I will create a new PR.
Could you disable the cpu/gpu consistency test temporarily?
https://github.com/apache/incubator-mxnet/blob/master/tests/python/gpu/test_operator_gpu.py#L1662
The another solution is to replace std::sort with std::stable_sort.
https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/proposal.cc#L195
https://github.com/apache/incubator-mxnet/blob/master/src/operator/contrib/multi_proposal.cc#L200
Thank you!

Feel free to create a PR which disables that test, I'll merge it asap.

@marcoabreu
Hello! I have created a new PR to disable the cpu/gpu consistency test temporarily.
I will fix the bug.

@piiswrong @marcoabreu
Hello!
I found the reason of the CPU/GPU consistency test failed.
It seems that the float computation is different between CPU and GPU.
When doing Non Maximum Suppression and the overlap of anchors is close to the threshold, the overlap may be greater than the threshold in the CPU implementation, but that is less than the threshold in the GPU implementation.
nms cpu
nms gpu
Here is the output (score) comparison between the Multi Proposal CPU/GPU implementations.
LINE    score(cpu) score(gpu)
10920 0.881283_0.881283
10921 0.881242_0.881242
10922 0.880963_0.880963
10923 0.880916_0.880916
10924 0.880834_0.880834
10925 0.880719_[0.880812] HERE
10926 0.880509_0.880719
10927 0.880333_0.880509
10928 0.880228_0.880333
10929 0.879861_0.880228


Fixed incorrect dependency definitions

This should fix the issue encountered in #3. It looks like there's a bug in yarn where it brings in peer dependencies when it shouldn't, but I don't think that will affect this change!

Thanks!


chore: set knock user agent

This PR overrides the default go http client's user agent with a knock specific one.
We'll have to update sdk_version.go during our release process, but we already do that for other SDKs (e.g. elixir).
Here's an example log for a request I made with this branch:

Closing this PR as we have plans in-flight for generating SDK user agents a different way in the future

Re-opening as there is still value in this telemetry today.


Fix a deadlock when Run() to create a process.

Child forked will inherit state of global mutex which may be in intermediate taken status by one of threads of then parent, then in child process it tries to get this mutex and is always pending. One example of mutex is malloc_lock, and there are more.
If this is confirmed as a proper bug fix, I would like choose Contribution option (1): Allowing us to apply the same patch into PacketiX VPN.
This problem is found because I find that in Linux when vpnclient is connected, the client can't get IP address from vpn server (Is it intentional or bug too? ). Then in commit #b7f4b78 (For Unix like OS, auto launch dhcp client on tap interface), I tried to do dhcp client using Run. It works but after several times of connect/disconnect, I found something like this by ps to list processes:
root      3165  0.0  0.0  53968  2008 ?        S<s  14:11   0:00 /home/ajee/github/SoftEtherVPN/bin/vpnclient/vpnclient execsvc
root      3166  0.4  0.2 1099376 18504 ?       S<l  14:11   0:01 /home/ajee/github/SoftEtherVPN/bin/vpnclient/vpnclient execsvc
root      3292  0.0  0.2 1099376 16192 ?       S<   14:12   0:00 /home/ajee/github/SoftEtherVPN/bin/vpnclient/vpnclient execsvc

There is one more vpnclient than normal two and it never quits.
By gdb into the third process and saw this stack trace:
0  0x00007f54770bbf4d in __lll_lock_wait () from /lib64/libpthread.so.0
1  0x00007f54770b7d02 in _L_lock_791 () from /lib64/libpthread.so.0
2  0x00007f54770b7c08 in pthread_mutex_lock () from /lib64/libpthread.so.0
3  0x000000000040937d in UnixMemoryAlloc (size=26) at src/Mayaqua/Unix.c:2128
4  0x00000000004fe5c2 in OSMemoryAlloc (size=26) at src/Mayaqua/OS.c:459
5  0x00000000004d7757 in InternalMalloc (size=26) at src/Mayaqua/Memory.c:4173
6  0x00000000004d7342 in MallocEx (size=10, zero_clear_when_free=0) at src/Mayaqua/Memory.c:4014
7  0x00000000004d75c3 in ZeroMallocEx (size=10, zero_clear_when_free=0) at src/Mayaqua/Memory.c:4148
8  0x00000000004d75a4 in ZeroMalloc (size=10) at src/Mayaqua/Memory.c:4144
9  0x00000000004c8497 in UnixCalcStrToUni (str=0x5a68ac "") at src/Mayaqua/Internat.c:988
10 0x00000000004c9ab7 in CalcStrToUni (str=0x5a68ac "") at src/Mayaqua/Internat.c:2013
11 0x00000000004c959b in CopyStrToUni (str=0x5a68ac "") at src/Mayaqua/Internat.c:1662
12 0x000000000050951d in PrintArgs (fmt=0x5a68ac "", args=0x7f546d81a2d8) at src/Mayaqua/Str.c:3010
13 0x0000000000509628 in Print (fmt=0x5a68ac "") at src/Mayaqua/Str.c:3031
14 0x0000000000408220 in UnixRun (filename=0x5afdc3 "dhclient", arg=0x7f546d81a490 "-r -q vpn_vpn", hide=1, wait=0) at src/Mayaqua/Unix.c:1186
15 0x00000000004fe1ab in OSRun (filename=0x5afdc3 "dhclient", arg=0x7f546d81a490 "-r -q vpn_vpn", hide=1, wait=0) at src/Mayaqua/OS.c:317
16 0x00000000004ccb3f in Run (filename=0x5afdc3 "dhclient", arg=0x7f546d81a490 "-r -q vpn_vpn", hide=1, wait=0) at src/Mayaqua/Kernel.c:688
17 0x0000000000490e72 in SessionMain (s=0x7f545c001b20) at src/Cedar/Session.c:715
18 0x000000000046919f in ClientConnect (c=0x7f5448000a20) at src/Cedar/Protocol.c:5422
19 0x0000000000492020 in SessionConnect (s=0x7f545c001b20) at src/Cedar/Session.c:1194
20 0x0000000000492bdb in ClientThread (t=0x7f545c004710, param=0x7f545c001b20) at src/Cedar/Session.c:1533
21 0x00000000004cd269 in ThreadPoolProc (t=0x7f545c003d60, param=0x7f545c003a80) at src/Mayaqua/Kernel.c:923
22 0x0000000000408a5e in UnixDefaultThreadProc (param=0x7f545c004010) at src/Mayaqua/Unix.c:1676
23 0x00007f54770b5dc5 in start_thread () from /lib64/libpthread.so.0
24 0x00007f5475ee0ced in clone () from /lib64/libc.so.6

Obviously, This is stuck in the lock. My change is moving all stuff using the mutex lock out of the child process, to the place before forking. With this fix, it works well.
(Attention, make sure UnixCloseIO would not have some Print or Malloc in the future, otherwise also run into trouble).
Thanks

I also correct a typo in commit log from "threads of then parent" to "threads of the parent". Thanks

I also correct a typo in commit log from "threads of then parent" to "threads of the parent".
Thanks

Thank you for fixing it.

@moatazelmasry2 I think that you should enable the rebase by default when using git pull:
git config --global pull.rebase true

I messed up yesterday's PR specifically by running
git pull --rebase tidatida-master origin/master
While his commit remained at the top of the branch, doing a git push -f, pushed everything except his commit and I broke the PR.
I'm hoping with the cherry picking to reduce the damage

I would've added his repository as new remote, checked out his branch, pulled from origin/master and then force-pushed.
git remote add tidatida git@github.com:tidatida/SoftEtherVPN.git
git fetch --all
git checkout -b tidatida-master tidatida/master
git pull --rebase origin master
git push -f

This is exactly what I did last time, really line for line and word for word what you just wrote.
and it broke the PR.

But I agree that cherry picking is also not the right way to go. I'll try again in future PRs to rebase

This time I'll do a regular merge of the PR into master, since in my opinion both squash or rebase would be wrong. Feel free to argue otherwise

That would be the best way to merge a pull request, in my opinion.
All of the commits are inserted into the target branch as they are, along with a merge commit which indicates that the commits come from a pull request.

Your great PR has been merged into the master branch. Thank you for your hard work

Will the stable version fix this?
i found a  high cpu load ,SoftEther version:[SoftEther VPN Server (Ver 4.38, Build 9760, rtm)]
Can you help us!!! Thank you so much！
https://github.com/SoftEtherVPN/SoftEtherVPN/discussions/1809


Sh/#646 rewrite groovy test to scala test

Here is the finished version of PVModelTest.scala.
This PR is related to Issue #646

I noticed that the constructor for PvInput is no longer working here. I looked it up and think it is because of the input parameter "EmInput" which is missing. Is that something that was only recently added to the PvInput class?

Yes, this change was introduced with #751. Before the em was told which entities he controlls. We changed this, so now the entities, here the PV, needs to get an em (or none, if the pv is not em controlled). However, it should work if you add null, you can compare with PvModelTest.


Fix bug where order is wrong after adding objects

This problem was caused by using the count of the objects in the intermediary join table as the starting sort value. This was insufficient because deleting objects would not update the sort values.
So imagine with a fresh database, you added 5 objects then deleted 3. The max sort value would be 4 (the 5th object would use the count prior to adding, hence 4), but when you add a new object, its sort value would be 2 (current count of intermediary objects), NOT 5!
This fixes that by querying for the maximum sort value in use by the source object's intermediary objects and using that as the starting sort value.
Since bulk_create() was introduced in Django 1.4 and there is a dummy atomic() implementation (that actually was not being used), there is no need to use a different implementation to create intermediary objects on Django 1.5. Also, this ensures the right database is being used for the transaction, which was not the case before.

Hey, thanks a lot for this patch. I will review the code and post comments inline.

Thank you for lining out your intend! It makes sense and I merged your code with commit ba6d5db5fc713fc907a904598ab9224d40496246. However this PR is not marked as merged as I modified the commit slightly (whitespace changes).
I just released 1.0.2 containing your fix.

Awesome, thanks @gregmuellegger!


[MPG][.Net] Unexpected diff in AzureSample.ResourceManager.Storage

Need to handle x-ms-long-running-operation-options.enable-interim-state in a better way to produce MgmtOutputLibrary.IntrimOperations. The existing logic is here

Planning to replace the logic with custom code


navigation2: 1.1.3-1 in 'humble/distribution.yaml' [bloom]

Increasing version of package(s) in repository navigation2 to 1.1.3-1:

upstream repository: https://github.com/ros-planning/navigation2.git
release repository: https://github.com/SteveMacenski/navigation2-release.git
distro file: humble/distribution.yaml
bloom version: 0.11.2
previous version for package: 1.1.2-1

Holding for humble sync: https://discourse.ros.org/t/preparing-for-humble-sync-and-patch-release-2022-11-21/28234

@methylDragon but this PR predates that hold :cry: This is also a pretty important set of updates to get out ASAP with bug fixes impacting users

@methylDragon this PR predates that hold cry This is also a pretty important set of updates to get out ASAP with bug fixes impacting users

@SteveMacenski okay, I'll merge it.
I'll need to monitor for regressions on the various status pages and revert if there are regressions though. So note that this might get reverted if it causes issues.

@SteveMacenski looks like nav2 isn't working in RHEL https://build.ros2.org/view/Hbin_rhel_el864/job/Hbin_rhel_el864__nav2_constrained_smoother__rhel_8_x86_64__binary/17/
15:14:34 DEBUG: In file included from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother_cost_function.hpp:32,
15:14:41 DEBUG:                  from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother.hpp:29,
15:14:41 DEBUG:                  from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/constrained_smoother.hpp:26,
15:14:41 DEBUG:                  from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/src/constrained_smoother.cpp:23:
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/utils.hpp: In function 'Eigen::Matrix<_Scalar, 2, 1> nav2_constrained_smoother::tangentDir(Eigen::Matrix<_Scalar, 2, 1>, Eigen::Matrix<_Scalar, 2, 1>, Eigen::Matrix<_Scalar, 2, 1>, bool)':
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/utils.hpp:89:14: error: 'isinf' is not a member of 'ceres'
15:14:41 DEBUG:    if (ceres::isinf(center[0])) {  // straight line
15:14:41 DEBUG:               ^~~~~
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/utils.hpp:89:14: note: suggested alternative: 'sinh'
15:14:41 DEBUG:    if (ceres::isinf(center[0])) {  // straight line
15:14:41 DEBUG:               ^~~~~
15:14:41 DEBUG:               sinh
15:14:41 DEBUG: In file included from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother.hpp:29,
15:14:41 DEBUG:                  from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/constrained_smoother.hpp:26,
15:14:41 DEBUG:                  from /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/src/constrained_smoother.cpp:23:
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother_cost_function.hpp: In member function 'void nav2_constrained_smoother::SmootherCostFunction::addCurvatureResidual(const double&, const Eigen::Matrix<_Scalar, 2, 1>&, const Eigen::Matrix<_Scalar, 2, 1>&, const Eigen::Matrix<_Scalar, 2, 1>&, T&) const':
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother_cost_function.hpp:162:16: error: 'isinf' is not a member of 'ceres'
15:14:41 DEBUG:      if (ceres::isinf(center[0])) {
15:14:41 DEBUG:                 ^~~~~
15:14:41 DEBUG: /builddir/build/BUILD/ros-humble-nav2-constrained-smoother-1.1.3/include/nav2_constrained_smoother/smoother_cost_function.hpp:162:16: note: suggested alternative: 'sinh'
15:14:41 DEBUG:      if (ceres::isinf(center[0])) {
15:14:41 DEBUG:                 ^~~~~
15:14:41 DEBUG:                 sinh

@methylDragon Nav2 has never worked on rhel, I don't believe. Pretty much every project I work on should be on the RHEL blacklist in the build farm configuration

Hmm, okay, I think everything's okay then :fire:


KeyError that happens at random

When I run my chat bots, then sometimes I get a KeyError, which seems to happen at random.
Traceback:

Traceback (most recent call last):
  File "C:\Python27\lib\threading.py", line 810, in __bootstrap_inner
    self.run()
  File "C:\Python27\lib\threading.py", line 763, in run
    self.__target(*self.__args, **self.__kwargs)
  File "Path\ChatExchange\chatexchange\browser.py", line 625, in _runner
    self.on_activity(json.loads(a))
  File "Path\ChatExchange\chatexchange\rooms.py", line 71, in on_activity
    for event in self._events_from_activity(activity, self.id):
  File "Path\ChatExchange\chatexchange\rooms.py", line 85, in _events_from_activity
    event = events.make(room_event_data, self._client)
  File "Path\ChatExchange\chatexchange\events.py", line 16, in make
    return cls(data, client)
  File "Path\ChatExchange\chatexchange\events.py", line 48, in __init__
    self.room = client.get_room(data['room_id'], name=data['room_name'])
KeyError: 'room_id'

Smokey is getting this too. I'll take a look, but we'll see if I get anywhere.

I'm betting as @Manishearth said it has to do with the lazy loading. It looks like room data is lazy-loaded, correct? And if that room data isn't there before an event is created, something like this would occur.


Tighten color regex

Update the regex patterns for RGB, RGBA, and HSL strings to match only valid colors.
This patch was extracted from #2097, where we use Hypothesis' from_regex() strategy to generate test inputs.  It will need to be merged before that PR, but is worth merging and documenting independently - strings like rgb(300, 300, 300) now fail to match the regex instead of raising an error later.

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change

There are no new tests for this change, because everything that used to work (or fail) still does work or fail respectively, and we maintain 100% coverage.

looks good, can you add some tests for outside the ranges to confirm this is working correctly.

Unfortunately (?) this doesn't change the range of valid values at all, so it's fully covered by the existing tests.  The total effect of this change is that

Using Hypothesis to generate matching strings only generates valid strings
Invalid inputs raise this ColorError instead of e.g. this one.

If the second change is undesirable I can close this PR and just use a more complicated Hypothesis strategy to generate color strings in the plugin.

Then I do think this is a regression.
I was surprised i hadn't implemented the regexes like this to start with, that explains my decision.
Can't you just use those new regexes for hypothesis?

Yeah, I'll either use them (involves replicating a bit more logic to reconstruct everything else), or just implement it with format strings (probably more efficient shrinking).
Thanks for the quick review :grin:


deploy: fix web publish

Turns out cloudflare pages isn't really practical due to the 25MiB file size limit, a godot export will easily be bigger than that. Oh well, netlify Just Works.

Also, I can't use github pages because there is no reasonable way to set headers https://github.com/orgs/community/discussions/13309


CNAME support

Please add CNAME support.  I couldn't find anything in the documentation

Closing issue. Example CNMAE
apiVersion: crds.kubeflare.io/v1alpha1
kind: DNSRecord
metadata:
  creationTimestamp: null
  name: home.example.com
spec:
  record:
    content: www.lexample.com
    name: home.example.com
    priority: 0
    proxied: false
    ttl: 1
    type: CNAME
  zone: example.com
status: {}


table cell selection improvement

Fixes the following issues:

This PR fixes #2727
Support cell selections on macOS (previously the multi-selection using keyboard never worked)
The rowNumber plugin and cellSelectionModel is conflicting since they both do selection management; it is just a matter of the event registration order to decide who gets called first. To fix the issue, I am adding options to the plugins and the consumer of the components can set those options properly.

NOTE: The multi-selection key is CTRL for Windows/Linux, CMD key for macOS.
Scenarios

Select all - click the header of row number column

Select a single column - click the column header

Select columns individually - click the header of the columns with CTRL/CMD key pressed

Select columns in a range - select the start column (a cell or entire column), then select the end column header with SHIFT key pressed

Select a row - click the row number cell

Select muliple rows individually - click the row number cells with CTRL/CMD key pressed

Select rows in a range - select the start row (a cell or the row header), then select the end row header with SHIFT key pressed

Select cells in a range with mouse - press and hold the select button in the start cell, then move the cursor to the end cell and release the button

Select cells in a range with keyboard only - select the start cell, press and hold SHIFT key, then use the arrow keys to select the range

Select cells in a range with mouse and SHIFT key - select the start cell, press and hold SHIFT key, then click the end cell

Select multiple ranges - Select a range with the options listed above and then with CTRL/CMD pressed and keep adding new selections.

I'm positive that you looked at this, but what kind of accessibility testing did you do with this change?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 36 (0.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 42.358%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/services/notebook/browser/outputs/tableRenderers.ts
0
1
0.0%

src/sql/workbench/contrib/executionPlan/browser/topOperationsTab.ts
0
2
0.0%

src/sql/workbench/contrib/query/browser/gridPanel.ts
0
2
0.0%

src/sql/base/browser/ui/table/plugins/rowNumberColumn.plugin.ts
0
3
0.0%

src/sql/base/browser/ui/table/plugins/cellSelectionModel.plugin.ts
0
28
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
29428

Relevant Lines:
64626

💛  - Coveralls

@chlafreniere , there are quite a few issues with the grid, I have a master issue tracking all them: https://github.com/microsoft/azuredatastudio/issues/20855.


Update Pages “PestControlPage”

Automatically generated by Netlify CMS

👷 Deploy Preview for chic-shortbread-66a66b processing.

Name
Link

🔨 Latest commit
0a1b4fdff37f1608806bc6f8ef0640692add3936

🔍 Latest deploy log
https://app.netlify.com/sites/chic-shortbread-66a66b/deploys/654c4042542c590008ab7ee5


Game Status and accept word

It is still in progress!

I commented two lines in "submitWord" because they cause a bug that still needs to be solved. At the moment the game is playable with this branch


Typo "@source_object"→"@source_object"

Italic with escape characters
https://docs.microsoft.com/en-us/sql/relational-databases/system-stored-procedures/sp-addmergearticle-transact-sql?view=sql-server-ver15

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Formatting fix looks good; thanks.


implement platform agnostic IP handling, Fix IOTCLT-1001

This is fix for address handling in mbed Client (and mbed-client-c). There is an issue that the current implementation presumes that the IP is given as byte array, whereas some platforms give instead a char pointer. This should fix some CoAP messages being ignored by Client (due to not recognizing the IP).
@yogpan01 @anttiylitokola

Depends on this PR: https://github.com/ARMmbed/mbed-client-c/pull/73

I added some additional code clean-up on top of the fixes we did with @yogpan01

rebuild

rebuild

LGTM, just update the doxygen part.

rebuild


static_file endpoint doesn't love null byte

Hello,
while fuzzing my API, I think I've discovered a Flask issue. The static_file endpoint generate a 500 if the filename include a null byte (\x00).
Here is a minimal flask application:
from flask import Flask
app = Flask(__name__)

if __name__ == '__main__':
    app.run(debug=True)

I've tried launching it with either python 2 (2.7.11) or python 3 interpreter (3.5.1) with flask 0.10.1, then make this request:
import requests
requests.get('http://localhost:5000/static/\x00')

I get a 500, here is the traceback for python2:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1836, in __call__
    return self.wsgi_app(environ, start_response)
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1820, in wsgi_app
    response = self.make_response(self.handle_exception(e))
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1403, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/lib/python2.7/site-packages/flask/helpers.py", line 823, in send_static_file
    cache_timeout=cache_timeout)
  File "/usr/local/lib/python2.7/site-packages/flask/helpers.py", line 613, in send_from_directory
    if not os.path.isfile(filename):
  File "/usr/local/Cellar/python/2.7.11/Frameworks/Python.framework/Versions/2.7/lib/python2.7/genericpath.py", line 37, in isfile
    st = os.stat(path)
TypeError: must be encoded string without NULL bytes, not unicode

And here is the traceback for python 3:
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/site-packages/flask/app.py", line 1836, in __call__
    return self.wsgi_app(environ, start_response)
  File "/usr/local/lib/python3.5/site-packages/flask/app.py", line 1820, in wsgi_app
    response = self.make_response(self.handle_exception(e))
  File "/usr/local/lib/python3.5/site-packages/flask/app.py", line 1403, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.5/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/usr/local/lib/python3.5/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python3.5/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python3.5/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/local/lib/python3.5/site-packages/flask/_compat.py", line 33, in reraise
    raise value
  File "/usr/local/lib/python3.5/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python3.5/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/local/lib/python3.5/site-packages/flask/helpers.py", line 823, in send_static_file
    cache_timeout=cache_timeout)
  File "/usr/local/lib/python3.5/site-packages/flask/helpers.py", line 613, in send_from_directory
    if not os.path.isfile(filename):
  File "/usr/local/Cellar/python3/3.5.1/Frameworks/Python.framework/Versions/3.5/lib/python3.5/genericpath.py", line 30, in isfile
    st = os.stat(path)
ValueError: embedded null byte

The error is not exactly the same but isfile doesn't seems to love null bytes.
I've tried to fix it locally by adding this piece of code to detect null bytes in send_static_file (https://github.com/mitsuhiko/flask/blob/master/flask/helpers.py#L862):
if '\x00' in filename:
     raise RuntimeError("Null byte")

It seems to works with both python2 and python3, but I'm not sure what is the best response when the request include a null byte.
Here is the output of pip freeze if necessary:
Flask==0.10.1
itsdangerous==0.24
Jinja2==2.8
MarkupSafe==0.23
Werkzeug==0.11.5

I only tried on Mac OS X 10.11.4, I don't know if null byte are accepted in valid filename on other filesystems.

I don't think NULs are acceptable in any paths since the functions dealing with paths expect NUL-terminated strings in the C APIs.

Nullbyte should raise a 400 Bad Request since they're invalid characters in filenames.

hm.. are they disallowed in URLs? if yes 400 makes more sense indeed. otherwise i'd go for 404 since it's none of the client's business whether the file is loaded from the filesystem (where NUL is disallowed) or somewhere else (where it might be valid)

I guess 404 is also a solution.
Anyway, this should be implemented by catching ValueError from the os.path.isfile call in the traceback. Not just checking for nullbytes, because there might be other rules for valid filenames on Windows.

I can make a pull-request but what is the best way to return a 400 inside flask/helpers? abort?

check existing code, but you could import BadRequest from werkzeug.exceptions and raise that

Fixed in above pull request; this issue should be closed.


Ensure previous Fedora Workstation isn't installed

Noticing that in /sysroot/{usr/bin,} there's data from the original install around and there's a chance that it's being used in the boot process.

Prior to install, I installed lolcat via DNF and found it after migration in /sysroot/usr/bin/lolcat.
There's a chance that the previous system is also being relied for booting. Gotta look at grub config and such with OSTree


Coverage!

Me this morning

There is an issue with detecting stream termination in Node 10.x

9⃣ 9⃣ . 3⃣

9⃣ 9⃣ . 7⃣ 7⃣

I need a better test for lastResortHandler in case of an error in ResultHandler

1⃣ 0⃣ 0⃣ 🎉


testing/ostest: add test case for task priority change with locked scheduler

Summary
This test helps to verify that scheduler lock/unlock functionality is working as expected.
Currently there is a bug, so test fails.
Impact
More test coverage
Testing
The test pass if https://github.com/apache/nuttx/pull/7464 is applied

Ok. Could you please point me to some examples, or should I just place some explanations in the comments?

Currently this is blocked by https://github.com/apache/nuttx-apps/issues/1716

@pkarashchenko please rebase your patch

Continuing what @davids5 was saying, I think a comment in the code that explains the purpose of the test and what we expect from it will help people reading the code later.
Separately, another idea:
Since the test is expected to fail due to a bug, I think we should modify the ostest program to tally five possible results from each test, like some other test suites do: pass, fail, expected fail, unexpected pass, skipped.
Explanation:

pass: the test passed as expected

fail: the test should have passed but it failed

expected fail: the test failed and it was expected to fail because of a known bug; that is the situation with the test in this PR. We should tally such failures separately from above-mentioned fail because they are caused by known bugs

unexpected pass: we expected the test to fail with "expected fail" because of a known bug, but to our surprise, it passed unexpectedly

skipped: the test is not being run because the hardware or build doesn't support it; e.g., the priority inheritance tests will be skipped in a non-priority-inheritance build

@pkarashchenko please add commit message describing the change

@pkarashchenko please add commit message describing the change

Should I modify all the three commits? I'm not sure that commit that adds missing comment needs any other description than testing/ostest: add missing section comments currently available.

Seems like https://github.com/apache/nuttx/pull/9981 is needed to move forward

@xiaoxiang781216 do you have any ideas why sim:citest fails? Initially I thought that it is a timeout issue, but seems like it is not, I can run the tests locally and all test pass
=========================================================== test session starts ===========================================================
platform linux -- Python 3.8.10, pytest-6.2.5, py-1.11.0, pluggy-1.2.0 -- /usr/bin/python3
cachedir: .pytest_cache
rootdir: /home/pkarashchenko/eclipse-workspace/nuttx-upstream/nuttx/tools/ci/testrun, configfile: pytest.ini
plugins: repeat-0.9.1, ordering-0.6, json-0.4.0
collected 12 items

test_example/test_example.py::test_hello PASSED                                                                                [  8%]
test_example/test_example.py::test_helloxx PASSED                                                                                [ 16%]
test_example/test_example.py::test_pipe PASSED                                                                                [ 25%]
test_example/test_example.py::test_popen PASSED                                                                                [ 33%]
test_example/test_example.py::test_usrsocktest PASSED                                                                               [ 41%]
test_os/test_os.py::test_ostest PASSED                                                                                [ 50%]
test_os/test_os.py::test_mm PASSED                                                                                [ 58%]
test_os/test_os.py::test_cxxtest PASSED                                                                                [ 66%]
test_os/test_os.py::test_scanftest PASSED                                                                                [ 75%]
test_os/test_os.py::test_getprime PASSED                                                                                [ 83%]
test_os/test_os.py::test_fs_test PASSED                                                                                [ 91%]
test_os/test_os.py::test_psram_test PASSED                                                                                [100%]

But on CI the test_os/test_os.py::test_ostest fails.

@ttnie could you check why the citest fail?

@xiaoxiang781216 seems this should fix the root cause https://github.com/apache/nuttx/pull/10016
But still I do not understand why it works locally for me.

@xiaoxiang781216 seems this should fix the root cause apache/nuttx#10016 But still I do not understand why it works locally for me.

without SIM_WALLTIME_SIGNAL, simulator timing doesn't sync with the PC wall clock. I guess the ci server either run to fast or slow than your PC.


Ensure all Cloud SQL database instance have backup configuration enabled

Possible check to target the following resource

[ ] google_sql_database_instance

closing, tracking in spreadsheet


It does not work if used in a dependency service implemenation from PCL?

I've tried using this in a dependency service implementation by setting isUsingNativeUI = true and:
var authenticator = new OAuth2Authenticator(/setting clientId and other parameters here/, isUsingNativeUI = true);
var context = Forms.Context;
context.StartActivity(authenticator.GetUI(context));
The login or whatever it is doesn't even open, however if isUsingNativeUI = false, it normally opens a WebView which is also NOT ALLOWED if you are using the OAuth2 to login to Google Sign-in.
The point is I am using this for Google Sign-in, and it does not work.

Aware of the issue.

For the latest -alpha-06, there seems to be an error the when I use the code above:
In my application output:
[Mono] Assembly Ref addref Zeemo.Droid[0xb7c87e80] -> Newtonsoft.Json[0xb7cb4630]: 4 [Mono] Assembly Ref addref Zeemo.Droid[0xb7c87e80] -> Xamarin.Auth[0xb7cd3c90]: 2 [Mono] Assembly Ref addref Zeemo.Droid[0xb7c87e80] -> System[0xb7d9c5a0]: 17 [Mono] Assembly Ref addref Xamarin.Auth[0xb7cd3c90] -> System[0xb7d9c5a0]: 18 [Mono] Assembly Ref addref Xamarin.Auth[0xb7cd3c90] -> Xamarin.Android.Support.CustomTabs[0xb7cd2f60]: 2 [Mono] Assembly Ref addref Xamarin.Auth[0xb7cd3c90] -> System.Core[0xb7f75ca0]: 10 [Mono] Assembly Ref addref Mono.Android[0xb7cf12c8] -> System.Runtime.Serialization[0xb86df0e0]: 4

1.5.0-alpha-* have Xamarin.Forms support and this caused linker issues. Investigating that.

@jelmarlaunchlabs
Please try released 1.5.0 and provide some feedback here.

Problem still persist
` Activity activity = this;
        var auth = new OAuth2Authenticator(
              clientId: "myclientid",
        scope: "",
        authorizeUrl: new Uri("https://m.facebook.com/dialog/oauth/"),
        redirectUrl: new Uri("http://www.facebook.com/connect/login_success.html"));

        auth.Completed += (sender, eventArgs) => {
            if (eventArgs.IsAuthenticated)
            {
                App.SuccessfulLoginAction.Invoke();
                // Use eventArgs.Account to do wonderful things
                Log.Debug("App", eventArgs.Account.Properties["access_token"]);
                Log.Debug("App", eventArgs.Account.Properties["email"]);
                Log.Debug("App", eventArgs.Account.Properties["contact"]);
                App.SaveToken(eventArgs.Account.Properties["access_token"]);
            }
            else
            {
                // The user cancelled
                Log.Debug("App", "Cancelled By User");
            }
        };
       var intent = auth.GetUI(activity);

       // StartActivity(intent);
        Forms.Context.StartActivity(intent);`

@jelmarlaunchlabs  @Cariaga Can you please check to see if this is still and issue with the latest version.

no response after 2 weeks, closing


Install package icinga-archive-keyring?

Moin,
Currently, this collection downloads the apt keyring manually:
https://github.com/Icinga/ansible-collection-icinga/blob/3ed368755b01dd3866d3cc47030b9e0a1721c531/roles/repos/tasks/Debian.yml#L10
Wouldn't it be more future proof to download the icinga-archive-keyring.deb manually, install it and then add the icinga sources referencing the installed key?

That's true, this usecase would be more complicated after such a change. I never hosted my own repo so I don't know whether one would do this without referencing the key in the apt sources.
Certainly it is not the most common usecase, so I would by default use the more secure and convenient function via the deb. You could:

add icinga_repo_apt_keyring into the sources it if it is defined
install the keyring deb if the sources point to packages.icinga.com and set the variable from above to the default path.

What do you think?


make clean changes git index

Commit 224a9e2 recently made istio certs fixed by removing them from
.gitignore:
security/docker/istio_ca.crt
security/docker/istio_ca.key
security/docker/node_agent.crt
security/docker/node_agent.key
However, the Makefile wasn't updated and make clean still removes these files.

The issue with "make clean" has been addressed by https://github.com/istio/istio/pull/2831 .


Component comma decimal disappears on blur

Go to https://vue-number-format.netlify.app/guide/play-ground.html
Leave it to the defaults:

Separator: .
Decimal: ,
Prefix: Rs.
Precision: 2
Masked: false

Select all text in the Component
Type: 1,23
Tab out of the field

Expected result: the "Rs.1,23" remains

Actual result: the input becomes "Rs.123"

v3.27.0

Please use latest version.


chore: bdd-spring-1568572323 to 0.0.1

chore: Promote bdd-spring-1568572323 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Release for Jakarta / Hibernate 6+

Are such releases planned?

The only problem i've detected in the current Version, is the usage of the old javax Entity Manager. I guess changing the imports should be enough.

This isn't that simple. I updated the Spring Boot dependency to 3.0.4, had to change HibernateQueryInterceptor to implement StatementInspector, and to add a new dependency “org.hibernate.orm.hibernate-ant” to fix the missing class (MultipleLinesSqlCommandExtractor, which is deprecated, btw) problem. However, I've got 6 test failures and 2 errors after that.
Sadly, Hibernate 6 had broken a lot.

Anyone found already a solution for the NplusOne Stacktrace detection with hibernate 6.2? Looks like the parts that this tool was looking for are not there anymore in the stacktrace.
The Query counting itself is working again thanks to the hints of @ferderer

Thanks for looking into it!
Sadly I will not have time to work on it soon...

Trying to make PR and have the same problems as @ferderer said.

I've implemented StatementInspector, replaced line with MultipleLinesSqlCommandExtractor to spring.jpa.properties.hibernate.hbm2ddl.import_files=import.sql, make some other things, but no success for now.


Add API for mapping Attr back to its syntax node

This will be useful for emitting diagnostics pertaining to a specific attribute

bors r+


AADSTS50194: Application '3b79e557-4d51-4b78-a1b0-82f9dd'(Testing for mail read) is not configured as a multi-tenant application. Usage of the /common endpoint is not supported for such applications created after '10/15/2018'. Use a tenant-

AADSTS50194: Application '3b79e557-4d51-4b78-a1b0-82f9dd'(Testing for mail read) is not configured as a multi-tenant application. Usage of the /common endpoint is not supported for such applications created after '10/15/2018'. Use a tenant-specific endpoint or configure the application to be multi-tenant.

You registered your application to only allow users in your tenant. You need to either:

Change your app registration to allow "Accounts in any organizational directory and personal Microsoft accounts."

Update this line in .env, replacing common with your tenant ID.
https://github.com/microsoftgraph/msgraph-sample-phpapp/blob/c82afc94f04b5e3d88531d84bef6286206dddb61/graph-tutorial/example.env#L64


NCCL Slowdown caused by aws-ofi-nccl conflict

If you experience an NCCL slowdown the first step is to enable:
export NCCL_DEBUG=INFO

This will allow you to catch an misconfigurations in the logs, for example if you see:
version `EFA_1.2' not found (required by /opt/amazon/efa/lib/libfabric.so.1) No plugin found (libnccl-net.so), using internal implementation

This likely means it's pulling in a version of the plugin aws-ofi-nccl that's not compiled against the system libfabric. You can check this (assuming you're using conda) by running:
conda list | grep -E "nvidia|nccl|cud|torch"

If this shows something like:
nvidia-nccl-cu12           2.19.3                    pypi_0    pypi

It's likely this version is getting pulled in as dependency and isn't working properly. You can override this and install aws-ofi-nccl from Amazon Pytorch like so:
conda install -y \
    aws-ofi-nccl \
    --override-channels \
    -c https://aws-ml-conda.s3.us-west-2.amazonaws.com/ \
    -c nvidia -c conda-forge

The error version EFA_1.2 not found should now disappear from the logs.

In practice, does this happen only for certain PyTorch build?
Has it ever happened with nccl-tests?


[lightswitch] problem with drawing widgets when getting back from launcher

Affected hardware version
Bangle 2
Your firmware version
2v17, 2v17.71(Cutting Edge)
The bug
Describe the bug
When getting back from launcher (and I think only from launcher) to clock, only lightswitch widget is draw.
No mater if return is done via btn or timeout. Long btn press works fine, getting back from settings works fine.
Error from IDE:
Uncaught SyntaxError: Expecting a valid value, got var  at line 1 col 1 in .bootcde ^ in function "draw" called from line 266 col 12 in lightswitch.wid.js     w.draw()            ^ in function called from system
Expected behavior
A clear and concise description of what you expected to happen.
Steps to reproduce

Tested with default launcher and dtlauncher
Open launcher
back to clock with short btn or timeout
bug occurs

Installed apps

widalarm (0.01)
widmessages (0.05)
widbt_notify (0.17)
chimer (0.02)
lightswitch (0.06)
widslimbat (0.01)
accelgraph (0.01)
alarm (0.41)
android (0.23)
files (0.08)
authentiwatch (0.07)
boot (0.57)
calculator (0.07)
calendar (0.13)
clock_info (0.02)
dtlaunch (0.23)
health (0.23)
ha (0.09)
keytimer (0.02)
locale (0.17)
lato (0.02)
messageicons (0.05)
messagegui (0.65)
messages (0.58)
messages_light (1.6)
gbmusic (0.11)
mylocation (0.09)
notify (0.12)
owmweather (0.02)
qcenter (0.04)
quicklaunch (0.14)
sched (0.22)
setting (0.60)
swscroll (0.03)
weather (0.25)

I experienced this bug in development, too. But I thought to have this fixed back then.
Maybe there have been some changes on widget drawing lately.

Sadly I couldn't reproduce the bug on my hardware, but maybe the PR #2784 might fix this behavior.

Sadly I couldn't reproduce the bug on my hardware, but maybe the PR #2784 might fix this behavior.

Side newbie question. For testing purposes how to open your BangleApps directly to lightswitch branch so I can test it beforehand?
Right now Your github.io is pointing to master I think.

I pushed the changes to master. Now you can test the changes here: https://storm64.github.io/BangleApps/?id=lightswitch

Yup changes are now visible but no luck.
When getting back from launcher by short click, only lightswitch widget is present.
I will provide more debug info later the night as I'm busy now. Thanks for quick reaction

I just found that @thyttan did a PR #2756  to implement some changes related to a new interpreter feature.
Maybe this could resolve this issue, but I think it is unlikely as it doesn't touch anything related to the drawing process.

I believe this may have been fixed by #3007, @storm64 do you see any problems with the latest version?

Going to close as fixed, but please reopen if you do see the issue after upgrading


Label isn't affected by format prop

Label isn't affected by format prop – function passed to format prop is actually used for formatting tooltip value only, despite docs says it should be used also for label as well.
I expect that the same function from format prop should be used for formatting both tooltip and label as well, according to the docs.

Simply pass format function to labels set values.
labels={{
            0: formatSlider(minSlider),
            100: formatSlider(maxSlider),
          }}


Per instance privacy policy and terms of service

https://www.dimagi.com/terms/latest/privacy/ & https://www.dimagi.com/terms/latest/tos/ for Dimagi

Add settings to link to policy in site footer
Also remove the blank '/terms' page.


fix(amplify-codegen): rename ModelIdentifiable.Identifier to identifierProtocol

Description of changes
Related to https://github.com/aws-amplify/amplify-ios/pull/2077 this renames ModelIdentifiable.Identifier to IdentifierProtocol
Issue #, if available
Description of how you validated changes
Checklist

[x] PR description included
[x] yarn test passes
[x] Tests are changed
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] Breaking changes to existing customers are released behind a feature flag or major version update
[x] Changes are tested using sample applications for all relevant platforms (iOS/android/flutter/Javascript) that use the feature added/modified

Ran yarn setup-dev and amplify-dev codegen models from the sample app containing iOS CPK schemas. The app is compiling and working as expected
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #467 (f5bce7e) into main (5c6c91c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #467   +/-   ##
=======================================
  Coverage   85.88%   85.89%
=======================================
  Files         143      143
  Lines        7065     7070    +5
  Branches     1852     1854    +2
=======================================
+ Hits         6068     6073    +5
  Misses        906      906
  Partials       91       91

Impacted Files
Coverage Δ

...ugin/src/visitors/appsync-json-metadata-visitor.ts
95.74% <100.00%> (+0.14%)
:arrow_up:

...elgen-plugin/src/visitors/appsync-swift-visitor.ts
97.26% <100.00%> (+0.01%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

The library changes have been merged!

Discussed with @AaronZyLee on merge strategy, i just did a force push to pull out this PR https://github.com/aws-amplify/amplify-codegen/pull/468 and so we can squash and merge this PR. Then i'll open https://github.com/aws-amplify/amplify-codegen/pull/468 again to merge to main on its own


Upgrade components

Prometheus-operator: v0.28.0
prometheus: v2.7.1
alertmanager: v0.16.0

Addressed by https://github.com/sighupio/fury-kubernetes-monitoring/commit/983f660134371b1588998199ccbcde3acb2ee7f0.
Closing.


Create camiseta-elias

Module: 00
Lab/Demo: 00
Fixes # .
Changes proposed in this pull request:


consistent labels sort on exposition

Consider using a BTreeMap to have labels always sorted by key when creating samples to have consistency on exposition

fixed by #6


[bug] Incorrect tray position, monitor size

Describe the bug
The position and size argument provides an incorrect position value. This issue happens for current_window as well.
https://user-images.githubusercontent.com/5789670/184507948-0d787ee4-35ee-40dc-90ce-7864fe12560d.mp4
Reproduction

Clone the minimal repro repo https://github.com/seahindeniz/tauri-position-issue-1
Run npm run tauri dev
Click on tray icon and observe details on terminal

Expected behavior
Since I have a 1440 x 900 pixels monitor resolution, I would like to see get the correct values from the API as well.
Platform and versions
Macbook M1
Environment
  › OS: Mac OS 12.4.0 X64
  › Node.js: 16.15.0
  › npm: 8.15.0
  › pnpm: Not installed!
  › yarn: 1.22.19
  › rustup: 1.24.3
  › rustc: 1.61.0
  › cargo: 1.61.0
  › Rust toolchain: stable-aarch64-apple-darwin

Packages
  › @tauri-apps/cli [NPM]: 1.0.5
  › @tauri-apps/api [NPM]: 1.0.2
  › tauri [RUST]: 1.0.5,
  › tauri-build [RUST]: 1.0.4,
  › tao [RUST]: 0.12.2,
  › wry [RUST]: 0.19.0,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../dist
  › devPath: http://localhost:5173/

App directory structure
  ├─ dist
  ├─ node_modules
  ├─ public
  ├─ src-tauri
  └─ .git

Stack trace
No response
Additional context
No response

Been trying to handle this issue for hours and after posting this issue, just noticed current_monitor.scale_factor() which returns the scale value 🤦🏻
I wasn't aware that the primary monitor was getting scaled, unlike an external monitor.

The reported values seem to be correct. Keep in mind that the struct they return is called PhysicalSize/Position, so they return the actual hardware specs. These structs do have a to_logical method if you prefer to work with these numbers; this method takes the scale_factor you mentioned as an argument.
(Also you really confused me by calling the monitor size, window size in the console output :D


Dynamo for Revit 2023 conflict

There seems to be some conflict between our Revit connector and Dynamo in Revit 2023 which makes code blocks uneditable.
Current conversations:
https://speckle.community/t/dynamo-code-block-not-working-in-revit-2023/3788
https://forum.dynamobim.com/t/code-block-not-working-due-to-conflict/81999

This seems to be caused by Generative Design plugin for Dynamo. Since it requires more investigating, I'm moving it to 2.11

I have the same issue 😢 .. Code blocks are broken even in the latest Revit connector version 2.13

@teocomi Yeah... 😕 I don't think it's because of Generative Design. I tried the fixes and none of them worked.
Plus the code blocks don't even work in Dynamo 2.3 in Revit 2020 were there is no Generative Design.


storage upload -> "custom disk offerings" not displayed correctly (ui bug)

ISSUE TYPE

Bug Report

COMPONENT NAME

UI

CLOUDSTACK VERSION

4.11->4.12 Master

CONFIGURATION

OS / ENVIRONMENT

CentOS7
SUMMARY

When you try to upload a disk file in "storage->upload" e.g. a qcow2 the ui displays one description in the "custom disk offering" field. it will not display the disk offerings but instead "one" description of that?
STEPS TO REPRODUCE

goto Storage->Upload, put URL and Description into the fields and select "Custom Disk Offerings"

thats our "Custom Disk Offerings"

if this bug is fixed we run in the next #2820

EXPECTED RESULTS

Normally there should be displayed all custom disk offerings

@mike-tutkowski what do you think?

https://github.com/apache/cloudstack/blob/1d05fead49f5c856257a741b07122f5633d2e359/ui/scripts/storage.js#L509-L552
This should be the relevant section.

Is this bug fixed or are you working on it - @svenvogel @DennisKonrad ?

Confirmed fixed by https://github.com/apache/cloudstack/pull/3479 which should be merged after a manual UI test.

I've just confirmed the fix it LGTM


Writing own Strategy for Database Migration

I followed the official documentation and can't get things to work.
https://github.com/rocketeers/docs/blob/master/II-Concepts/Strategies.md
As the documentation tells you to, I created the class mentioned.
The namespaces there seem to be not up to date, so I changed them according to the files on my machine.
Next, as code seems to be correct (as far as I can say), I put the Acme\Grunt into strategies.php in my configuration folder. Nothing happens, nor the rocketeer executable lists this newly created strategy.
Are there some known issues dealing with strategy creation? Are there some hints on how to get around this?
Thanks in advance

+1 : I encountered the same problem with deploy strategy.
    'deploy'       => 'LocalSync',

And my strategy :
use Rocketeer\Strategies\Deploy\SyncStrategy;

class LocalSyncStrategy extends SyncStrategy
{
    /**
     * @type string
     */
    protected $description = 'Uses rsync to create or update a release from local temporary cloned repository';
}

I maybe find where is the problem.
As strategies are loaded when a command is launched, this method (buildStrategy) is called to instanciate strategies. The name of the strategy is given to function via the $concrete parameter BUT in this method, if you do not find the concrete strategy into the rocketeer namespace, you erase it and the test after return false.
That's why, if the strategy is not into the rocketeer namespace, it won't work.
In the taskBuilder :
    public function buildStrategy($strategy, $concrete = null)
    {
        $handle = strtolower($strategy);
        if ($concrete) {
            // Here (1)
            $concrete = $this->findQualifiedName($concrete, [
                'Rocketeer\Strategies\\'.ucfirst($strategy).'\%sStrategy',
            ]);
           // And Here (2)
            if (!$concrete) {
                return false;
            }

            return new $concrete($this->app);
        }

        return $this->app['rocketeer.strategies.'.$handle];
    }

So, I maybe made a mistake, but I think not. I let you check this ;)

I tried chaging my class namespace from nothing to Rocketeer\Strategies\Deploy and it's works
<?php

namespace Rocketeer\Strategies\Deploy;
use Rocketeer\Strategies\Deploy\SyncStrategy;

class LocalSyncStrategy extends SyncStrategy
{
    /**
     * @type string
     */
    protected $description = 'Uses rsync to create or update a release from local temporary cloned repository';
}


STYLE: Modernize code of elxTransformBase

Used using for typedef's from Superclass
Defaulted default-constructor and destructor (C++11).
Replaced "purposely not implemented" by ITK_DISALLOW_COPY_AND_ASSIGN calls
Made three protected data members private
Replaced a raw pointer by std::unique_ptr
Did clean up the #include's.
Used const auto for variables that are initialized by New()
Replaced old for-loops in AutomaticScalesEstimation and AutomaticScalesEstimationStackTransform by modern C++11 range-based for-loops.

looks good !


DataSpreadsheet: active cell should have $ui-background color

What will this achieve?
Currently, the active cell (when part of a cell selection area receives the background of the cell selection area. What should actually happen is that the active cell always gets a background-color of $ui-background.
Current:

Expected:

How will success be measured?

Additional information

Designs
Existing code
etc

Complete


Upgrade jackson-databind to 2.9.x for vulnerability issue

jackson-databind prior to 2.9.1 have a serious remote execution bug. See https://github.com/FasterXML/jackson-databind/issues/1723
We are using jongo in production and will be forced to remove it if we don't get a patched version of it soon. Is there an ETA for a new release of jongo with a newer version of jackson-databind?

That ticket shows that the patch was rolled out to the 2.8.x, 2.7.x, and 2.6.x lines of development.  I am running Jongo with the 2.8.x line.  You should just be able to update your Jackson dependency.

@ctrimble is right.
I have just tested release 1.3.0 against Jackson v2.8.10 (+bson4jackson v2.7.0) and all tests pass.
According to this issue https://github.com/FasterXML/jackson-databind/issues/1737, v2.8.10 contains the most recent blacklist

True. But irrespective of whether upgrading to 2.9.x is necessary, Jongo does prevent doing so, it seems:
com.fasterxml.jackson.databind.introspect.AnnotatedMember.fixAccess()V
	at org.jongo.marshall.jackson.JacksonObjectIdUpdater.mustGenerateObjectId(JacksonObjectIdUpdater.java:48)
	at org.jongo.Insert.preparePojo(Insert.java:72)
	at org.jongo.Insert.save(Insert.java:47)
	at org.jongo.MongoCollection.save(MongoCollection.java:128)
	...

I haven't checked myself whether it'd be hard to fix this in a backwards-compatible manner; just to point out that this ticket has merit.

@Stephan202  I agree that 2.9.x support needs to be added at some point, but this ticket should stay focused on providing an immediate way to resolve this vulnerability.  A different ticket should be opened about supporting 2.9.x.

Actually, I forgot that my very own colleague @philleonard fixed that issue in PR #312. Maybe we can have a release with that? :D.

thanks @Stephan202 @ctrimble and @bguerout for the super quick response. You are right, we can use 2.8.10 to close the security issue.
We also tried building Jongo from master with the 2.9.2 version as @Stephan202 did and hit that same issue with "fixAccess"
There is definitely some work involved in migrating to jackson-databind 2.9.x, looks like the API has had some methods you guys are using removed.
Thanks again for being so helpful.

closing this as we can specify the newest jackson-databind in our project to fix the problem. I think you should consider releasing a 1.3.1 with a patched version of jackson-databind anyway to help secure projects using your library.

Hi, why there is no 1.3.1 release yet? We updated to Jackson 2.9.2 and we are not able to use Jongo anymore. I now there is a version 1.4 pending but no release in the Maven repository. Can you provide a workaround? Thanks by advance.

Hello you can find the release plan in milestone section of the project https://github.com/bguerout/jongo/milestones.
To sump up,

1.3.1: Jackson fixAcces(true) and Jackson update to 2.7.9
1.4.0: Jackson and bson4jackson updated to 2.9.x
1.5.0: New API to deal with mongo java driver API v3


Upgrade resolve-url-loader.

Fixes a security error on one of its dependencies (postcss) in the older version.
Related to similar upgrade PR for terriajs PR.

Might have to wait for a new release of terria for the CI build to pass.


Only update core for 1.2.1 aso plugin teams can depend on it for bulds

Signed-off-by: Peter Nied<EMAIL_ADDRESS>Description
Updating core so it will build and teams can take a dependency on it
Check List

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1298 (454991c) into main (00532ab) will decrease coverage by 19.80%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1298       +/-   ##
=============================================
- Coverage     93.87%   74.07%   -19.81%
  Complexity       11       11
=============================================
  Files           134       17      -117
  Lines          2956       81     -2875
  Branches          8        8
=============================================
- Hits           2775       60     -2715
+ Misses          173       13      -160
  Partials          8        8

Impacted Files
Coverage Δ

.../ci_workflow/ci_check_gradle_properties_version.py

src/ci_workflow/ci_manifests.py

.../assemble_workflow/bundle_opensearch_dashboards.py

src/git/git_repository.py

src/test_workflow/integ_test/integ_test_runner.py

src/ci_workflow/ci_check_list_source.py

..._workflow/input_manifests_opensearch_dashboards.py

src/build_workflow/build_recorder.py

src/run_build.py

src/build_workflow/builder_from_dist.py

... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00532ab...454991c. Read the comment docs.


Adding links within note to the IW Queue does nothing

I'm working on a project and have an index note with a hundred links or so to other notes. I tried adding all links within the note to the queue using the command palette, but it appears to have done nothing. Have you run into this before, or do you think I am missing a step?

I have done quite a bit of refactoring to the code related to bulk adding notes and links to queues recently and it seems to be working for me. It will get released into the next version soon so hopefully that should fix things for you. I will keep this issue open until a couple weeks after the next release so if there are any issues you can let me know.

Sounds good @bjsi, when I see the new version drop I'll do some testing and confirm.

New version available now, let me know how it goes.

Worked great - I now see the popup, and all the links are added to the desired queue. Closing as resolved.


fix issue with cluster clicks and unclustered markers

If we have unclustered markers showing close enough to a cluster, clicking on the cluster executes the underlying marker's click handler because of marker's zIndex

Good catch. I've verified the problem and the fix. This will improve my map too!

Thanks guys

My first merged pull request! And on google code... I feel "Hell yeah!!!"

👍


Help on changing mouse cursor while dragging

I'm trying to change the mouse cursor while user is dragging an object on various drop targets. The idea is to signal the user if she can or can't drop an object on a certain target.
Indeed changing a mouse cursor needs to be done in JS via a port with a call to dropEffect (see  https://developer.mozilla.org/en-US/docs/Web/API/DataTransfer/dropEffect):

Within event handlers for dragenter and dragover events, dropEffect should be modified if a different action is desired than the action that the user is requesting.

So I'm wondering  how I can access the dragover event. It seems I'm missing something very similar to getDragstartEvent, only for such event. Am I missing something obvious here?  Thanks!

Hi!
There is currently no way to get that event in the package, unfortunately. I've been planning to do an overhaul on the API, since it's somewhat of a patchwork at the moment, and that's I've thing to consider when doing that.
In the meantime, I'm sure it can be patched in. I'll have a look.

Hi!
There is currently no way to get that event in the package, unfortunately. I've been planning to do an overhaul on the API, since it's somewhat of a patchwork at the moment, and that's I've thing to consider when doing that.
In the meantime, I'm sure it can be patched in. I'll have a look.


What is  Postback URL? Also how can we add more coins for payment?

It is only showing limited payment coins while I have setup all coins in merchant setting.

Sorry for the late response, the notification got lost. The Postback URL is https://<your-paymenter-url>/extensions/atlos/payment/webhook, so if your paymenter domain is example.com, postback URL would be https://example.com/extensions/atlos/payment/webhook
Regarding only showing limited coins, you will have to contact ATLOS support, as the extension just integrates ATLOS, its upto ATLOS to show what coins it wants to show.


(Web, Safari) Copying and pasting line with colon and no leading space results in URL encoding of pasted text

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: Web
OS Version: iPadOS 18.1 (Safari)

VSCode Web on iPadOS/Safari appears to be erroneously encoding certain copied text as a URL.
So copying this string of text from a VSCode Web file:
foo: bar
And pasting it into another VSCode web file will result in:
foo:%20bar
This is only the case if there isn’t a space before the colon anywhere on the line. So,
 foo: bar and foo bar: baz both copy and paste normally.
This also only happens within VSCode web. So, copying foo: bar from an external app and pasting it into VSCode Web or copying foo: bar from VSCode web into another app both work fine.
I have not been able to reproduce this on VSCode Web on Mac or Windows.
Steps to Reproduce:

On iPadOS on Safari, open a new file on VSCode Web (or Github Codespaces)
Write text foo: bar
Copy to clipboard, where the first character of selection is NOT whitespace
Paste into same file.

https://github.com/user-attachments/assets/0dca81bb-fee2-4623-9ed4-0441ff70231e

I am unable to reproduce this behavior in Safari on macOS with vscode.dev, do you happen to have an extension installed that might be interfering here?

I noted this in the original issue: it’s only on iPadOS (and iOS) safari. I’m not seeing the issue on Mac either. I see it without any extensions installed—also reproduced on VSCode.dev in a clean private browsing session.

Seems to happen on copy as you can also paste the wrong content into other apps

For anyone investigating, it seems fixed if you set "editor.pasteAs.enabled": false
That means a good place to start is likely the copy paste controller:
https://github.com/microsoft/vscode/blob/31f77d2fe4daf09e45092ee35c9f52cf2a5da677/src/vs/editor/contrib/dropOrPasteInto/browser/copyPasteController.ts#L166

this issue relate to this https://github.com/coder/code-server/issues/7116


Create footer fragment

footer created and displays on each page.  did not incorporate it on the loading page


Use entry() instead of get() and insert()

This avoids hashing the backtrace twice the first time it's constructed,
which should almost double the performance. I do not have benchmarks to
back this up.
meta: DHAT has slowed down rustdoc by a factor of almost 30, and it wasn't fast to start. It would be great to improve the performance of DHAT in general.

Ah ok, that makes sense. I'll revert the change - I think the first commit should be valid.

An equivalent change was made in #3.


Add support to widget in json-schema properties with $ref

I changed the example json-schema reference adding the property widget
in order to add a custom wrapper:
 "properties": {       "billing_address": {         "title": "Billing address",               "$ref": "#/definitions/address",          "widget": {             "formlyConfig": {                 "wrappers": ["riquadro"],                 "templateOptions": {                     "title": "Billing address"                 }             }         }             }, ....
The property widget is deleted by the resolveDefinition function in ngx-formly-core-json-schema.js
Adding the widget to the list in line 566 seem to work  ['title', 'description', 'default', 'widget']
https://stackblitz.com/edit/angular-og72iy?file=src/app/object.type.ts

This issue has been fixed and released as part of v5.10.21 release.
Please let us know, in case you are still encountering a similar issue/problem.
Thank you!


Feature/csh/random bytes

Description

Now we can use randomSuffixValue (value: ${value}:${randomNumber})
Improve calculation logics

before: record start block number -> wait -> send Txs -> wait -> record finish block number
after: send Txs -> find start block number by first tx & find finish block number by last tx

Thanks for the quick review! Now merging


Site locale syntax does not work with Jekyll 4

Environment

Minimal Mistakes version: 4.20.2 (latest)
Ruby gem version: ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c)
Jekyll version: 4.1.1
Git repository URL: https://github.com/toolownerforked/minimal-mistakes-on-jekyll-4
Operating system: Ubuntu 20.04

Expected behavior
When I set the locale to another language, such as France, it does not display France as expected, still in English, even I stopped and started the Jekyll server again.
I dug into the template a little bit and find out that this syntax:
{{ site.data.ui-text[site.locale].recent_posts | inspect }}

will return nill, instead of a locale string.
Steps to reproduce the behavior
install minimal-mistakes on Jekyll 4 (starting from jekyll new command), then set locale to France like this: https://github.com/toolownerforked/minimal-mistakes-on-jekyll-4/commit/92596e79cbf7c46a3855b0d5de51417e20e3536f

Check the docs:

From v4.5.0 onwards, Minimal Mistakes theme-gem comes bundled with the necessary data files and will automatically use them via the jekyll-data plugin. So you no longer need to maintain a copy of these data files at your project directory.

Thanks, @iBug, in my repo, I did not keep any copy of data files. When I mentioned the syntax and the template, I just want to show the issue behind that.

At some point I removed the jekyll-data plugin as a dependency. I had a reason but don't remember what it was.
But when it was removed that statement above was left in and probably should have been removed too as I don't think bundled _data files carry over into sites using the theme.
I could be wrong on that as I haven't tested. I seem to remember Jekyll core adding this as a feature and that could be why I removed the plugin, or not.

@quanengineering Sorry I didn't notice I copied the text from an older revision of the repository (possibly forgot to git pull or such).
To be clear: It's now recommended that you copy _data/ui-text.yml into your repository for the localization feature to work.

Thanks @iBug, and @mmistakes.


Article about how PalDB works

Hi after reading your code, I tried to write an article about how PalDB works. I didn't find anything on the internet, I hope it can help, it could be a good start before contributing. If I made any mistakes, please
correct me.
http://www.jscarinos.com/2016/01/how-paldb-linked-works.html

Do you think PalDB support store data larger than physical memory?
I see in their introduction that PalDB relies on memory-mapped file which can be larger than physical memory. But on the other hand, PalDB emphasizes on their limitation "PalDB is optimal in replacing the usage of large in-memory data storage but still use memory (off-heap, yet much less) to do its job. Disabling memory mapping and relying on seeks is possible but is not what PalDB has been optimized for."
So if we use memory mapping mode of PalDB, does it support data larger than physical memory?

support


Uncaught ReferenceError: process is not defined

I am trying to compile some js files with brunch, have a bit of trouble when I have npm=true it targets the index.js file or module_name.js in my case react.js from node_modules/react/react.js how do I load node_module/react/dist/react.js instead

Are you using brunch from github (npm i -g brunch/brunch)? Older versions support of npm is very bad.


build: Use default build pool for AKS-Swift

Reason for Change:

Use default build pool for AKS-Swift
Issue Fixed:

Requirements:

[X] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests

Notes:

/azp run


Adding loading step to customize query selection

PULL REQUEST
Summary
This adds a loading step to the customize query step to prevent from getting ahead of the db load.
I think the only other open questions I had:

do we want the customize query button unclickable until an actual selection is made? If you click the button, it just takes you to a blank version of the page, which could be a little confusing if the user does think they made a selection.

is Social Determinants of Health supposed to be broken? Getting this error:
No results found for query: Social Determinants of Health

I can open up a ticket to look more closely at it, but I wasn't sure if this was a known bug or if anyone knew offhand why it may now be broken.
Related Issue
Fixes #47
Acceptance Criteria
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
For frontend PR’s - include a description (including anything that’s out of scope) for what you want the designers to review

ex: “Check out the whitespace on the page, as well as the dropdowns in the form. Here is the corresponding Figma link. You can ignore everything else. Also, the button at the bottom doesn’t work now”

Additional Information
Anything else the review team should know?
Checklist

[ ] If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

made some follow-up tickets:

https://github.com/CDCgov/dibbs-query-connector/issues/52
https://github.com/CDCgov/dibbs-query-connector/issues/51


Added encodekey option to enable encoding of key

If the key of kafka message has binary value.Then, it's not possible to separate the key from a message by looking for keySeparator. So, we must encode key before prepending.
It uses the encodeKey option to enable/disable encoding. If encodeKey has been enabled then key will be encoded using base64 and then prepended to message.

This change will become unnecessary with 0.5.x.
You can save the key to a metadata field and apply a standard base64 encode formatter to it.


STM32F303 - GPIOE.split() missing

I'm trying to get something running on the STM32F3Discovery board, which has an STM32F303 processor.
I've hit a problem where cargo build reports:
error[E0599]: no method named `split` found for type `stm32f3::stm32f303::GPIOE` in the current scope
  --> src/main.rs:49:38
   |
49 |         let mut gpioe = device.GPIOE.split(&mut rcc.ahb);
   |                                      ^^^^^

What's odd about this is that if I change the port to any of GPIOA-GPIOF other than GPIOE, there's no problem. And if I change the hal feature to "stm32f373" instead of "stm32f303" there's also no problem.
Any ideas?

Thanks for transferring @adamgreig :)
Yes this is indeed a HAL issue.
No issue directly, but a confusing way about the device features.
stm32f303 is a least common functionality subset of the subvariants stm32f303xb, stm32f303xb, stm32f303xb, stm32f303xb, stm32f303x6 and stm32f303x8 and as stm32f303x6 and stm32f303x8 are missing the gpioe peripheral, it is not included for stm32f303.
It should work, when you use the stm32f303xc feature, which is the microcontroller on the stm32f3 discovery board.
This confusen happend before as well:
https://github.com/stm32-rs/stm32f3xx-hal/issues/62
We do plan to change this in the future, probably by removing the stm32f303 feature, so that this confusion does not happen in the future.
https://github.com/stm32-rs/stm32f3xx-hal/pull/75

Thanks for the clarity. Going up and down the Arm-core stack is quite confusing for beginners!

The stm32f303 feature is now removed as it is to u specific, see #75.


Add TOML config option to default taipy create (Taipy CLI)

Description
When you create a Taipy application with taipy create, you have the option:
[5/6] Does the application use scenario management or version management? (No)
When you create a taipy core application with taipy create --template scenario-management, you have the following option:
[4/4] Does the application use TOML Config? (No):
You don't have that option in the default taipy create.
Solution Proposed
It would be great if you had this option when you select Yes in 5/6 within taipy create. If you select No, there is no reason to ask for a TOML file.
Impact of Solution
No response
Additional Context
No response
Acceptance Criteria

[ ] Ensure new code is unit tested, and check code coverage is at least 90%.
[ ] Create related issue in taipy-doc for documentation and Release Notes.
[ ] Check if a new demo could be provided based on this, or if legacy demos could be benefit from it.
[ ] Ensure any change is well documented.

Code of Conduct

[X] I have checked the existing issues.
[ ] I am willing to work on this issue (optional)

Hello @enarroied, on the default template, even if the answer to the
[5/6] Does the application use scenario management or version management? (No)
is Yes or y, there is no Configuration created.
The template will only have some scaffold for configuring new Config, so there will be no content in the TOML file.
Let me know if it makes sense, or how we can improve the content of the default template. Thank you

Hi @trgiangdo,
Thank you for your answer. I see what you mean, in the default template, the Config file is empty, while in the scenario-management template, there is a mock configuration (in either TOML or Python format).
I would find it useful to have the demonstration code, especially for beginners, but I also understand that having too many options in the CLI tool (and nested options) could be confusing, so now I'm having second thoughts!
In the main template, when you choose to add config file, you have a comment section, you could add the info there, something like:
# #############################################################################
# PLACEHOLDER: Put your application's configurations here                     #
#                                                                             #
# Example:                                                                    #
# scenario_config = Config.configure_scenario("placeholder_scenario", [])     #
# Comment, remove or replace the previous lines with your own use case        #
#
# Or create a config.toml file and load it like this:
# def configure():
#    Config.load("config/config.toml")
#    return Config.scenarios["scenario_configuration"]
# #############################################################################

I think this extra comment is useful, adds no complexity for the user and requires minimal effort. What do you think?