normalizing/conforming input data

To make sure data fed to FMRIPREP from different datasets is looking as similar as possible we are currently reorienting anatomical images to RAS. However, there is more that can be done:

make sure that the information in the header concerning data type and affine transformation (sform, qform) are correct; fix if possible
apply the same procedure to all input data (_bold, _sbref, fieldmaps etc.)

Problems:

If we change the orientation of input files we need to adjust the phase encoding direction as well.
Applying those fixes to big 4D _bold files will create an (almost) identical copy and waste a lot of disk space

Possible duplicate of #581, #388, #433 ?

Copying in part of https://github.com/poldracklab/fmriprep/issues/573#issuecomment-313799752:

To address further issues raised in #260:

If we change the orientation of input files we need to adjust the phase encoding direction as well.

NIfTI does have a phase_dim header entry. We could update the header, and use that later.

Applying those fixes to big 4D _bold files will create an (almost) identical copy and waste a lot of disk space

True, and adding the PE direction header entry will cause the same issue, if we don't already need to create a new file.
I haven't tried this out yet, but we could consider creating a filename.hdr.gz with a data offset matching the original header, and symlink to the original file with filename.img.gz. Assuming this works, we couldn't reorient, but we could update the headers without copying the data.

Superseded by new issue (link above)


ReplSet option using Mongo memory server

Hi! 👋
Today I used patch-package to patch<EMAIL_ADDRESS>for the project I'm working on.
We are using transactions and sessions. To do testing around this we need to use the ReplSet in mongo memory server. Is there a way we could choose if we wanted to use the ReplSet vs the standalone?
Here is the diff that solved my problem:
diff --git<EMAIL_ADDRESS><EMAIL_ADDRESS>index 01b4037..b63b353 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -17,7 +17,7 @@ class TestMongooseContext extends common_1.PlatformTest {
     static async install(options = { binary: {} }) {
         if (!TestMongooseContext.getMongo()) {
             // @ts-ignore
-            global.__MONGOD__ = new mongodb_memory_server_1.MongoMemoryServer({
+            global.__MONGOD__ = new mongodb_memory_server_1.MongoMemoryReplSet({
                 ...options,
                 binary: {
                     ...(options.binary || {}),

It shouldn't be a big issue too add an option to switch between RepliSet or Server:
static async install(options = { binary: {} }) {
       options.replicaSet ? new mongodb_memory_server_1.MongoMemoryReplSet() : new mongodb_memory_server_1.MongoMemoryServer()
}

@virus2016 PR ready
I let you to review the PR to check if the code is ok for you :)
See you
Romain

Amazing! Thank you! 😀

:tada: This issue has been resolved in version 6.121.0 :tada:
The release is available on:

v6.121.0
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 7.0.0-beta.13 :tada:
The release is available on:

v7.0.0-beta.13
GitHub release

Your semantic-release bot :package::rocket:


added custom css properties

I added generic definitions for two variables coming out to be undefined.
I am relatively newer to open source contributions, do let me know if any changes are required.

Thanks for the contribution, @Udassi-Pawan. We'll need to make a couple edits before moving forward here:

Let's scope these new values to the .modal CSS selector, rather than the :root. This will help users of the package avoid variable naming clashes at the root of their projects.
Please only edit the contents of the src/ directory. The dist/ directory is the compiled output that gets shipped to the user of the package. The file you'll want to edit is src/components/modal.scss.

Thanks!

@andrewrubin Thanks for the input, I have made the required modifications to the code, do let me know if further changes are required.

We're almost there! Would you please add the variables to the existing .modal selector, so we do not have a duplicate selector. Thanks!


Register MapLibre at AppBrain

We can detect MapLibre by usage of the MapLibreMap class after MapLibre for Android 11.0 release, which will include the new class name.
https://www.appbrain.com/stats/libraries/suggest

Hope we will show up soon: https://www.appbrain.com/stats/libraries


Custom label class

Prerequisites

[X] I have read the documentation;
[X] In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.
[ ] Ideally, I'm providing a sample JSFiddle or a shared playground link demonstrating the issue.

Description
I need to add a custom class in the label tag. I cannot find any way right now to add a custom class in the label tag. Is there any way to add?
Steps to Reproduce
Expected behaviour
There should have some property like labelClassName in uiSchema to add a custom class in label tag.
Actual behavior
Version
"react-jsonschema-form": "^1.7.0"

'ui:options': {
  class: 'custom-class'
}

@gr8pathik yeah, you are right. Perhaps rather than creating a new property like labelClassName, we can create a field such as LabelField which allows one to override the label completely. Or do you think it would be useful enough to be able to conveniently customize the label class name with something like labelClassName instead of needing to create an entire new field?

Merging this into #408.


req: how to configure always-visible control below video?

[X ] Issue does not already exist

With a call like this:
    <link rel="stylesheet" href="Quick Access Popup_files\plyr.css">

            <video width="640" height="380" controls>
                <source src="Quick Access Popup_files\video.mp4" type="video/mp4">
                Download
            </video>

How to do these?:

move controls below video
enable controls always visible
configure styling as in the screenshot at https://github.com/Selz/plyr

This is a custom implementation - I don't have time to write you the CSS for it.
This is a config option but if you're doing 1) then you can ignore the class name that's added to hide the controls.
If you use the default stylesheet, you'll get the default styling


API, undefined means false

Testing #117307
The TestItem.runnable property is defined as optional but defaults to true. It means undefined equals true and try to avoid that
https://github.com/microsoft/vscode/blob/e4364e5f5da60e371f995001836175d81cd942c3/src/vs/vscode.proposed.d.ts#L2403

Hm. I could make it required, but I definitely don't want to make a property for "notRunnable" since that is quite confusing.

I think the challenge is to figure out what is a test that's not runnable. Is that really a test or some kind of leaf/container or whatnot. Once that's clear you have a name ;-) Tho, maybe it's also overloading the meaning of a TestItem, e.g how does the UI render not-runnable tests? Do I still get code lens for them?


MAX78000 support of external SPIRAM

I want to use an external SPI RAM with MAX78000 on a custom PCB.
But I'm not able to find the Driver and example to use the external SPIRAM N01S830HAT22I which is used on MAX78000FTHR Board.
Could you please help to identify how I can use the external SPIRAM.
Thanks

Would be interested as well - on the feather EVK an OnSemi 1MByte SPI RAM is implemented but no library or reference example in the software is available Can u please clarify?

You're right, it looks like we're missing drivers for it in the SDK.
The IC looks very similar to the APS6404 SRAM which I recently wrote drivers for.  You can find them in the QSPI Example for the MAX78002.
It should be easy to adapt the example/drivers.  I'll try to do it by the end of the week.  In the meantime you can reference the QSPI example and its drivers yourself

@matti122 @BitSalat
I was able to complete some preliminary drivers this afternoon.  The main challenge for this SRAM is its "hold" feature.  I found I had to disable it in the mode register to get it to work reliably.
You can find the updated drivers and example on the dev/N01S830HA-drivers branch of my fork here.
Again, be warned this is a preliminary solution.  It may change significantly before the next release.  We are trying to freeze our codebase next Tuesday, so this may or may not make it in to the official June release.
Everything seems functional at its max speed of 20Mhz except for tests 7-9, which test operations across page boundaries.  I will need to troubleshoot this further next week.
QSPI SRAM Test:
        Test Address: 0x0
        Test size: 640 bytes
        Test count: 480 rows
        Test speed: 2000000 Hz
(Benchmark) Wrote 640 bytes to internal SRAM in 5us
Test 1: Standard SPI write...
        Done (640 bytes in 2594us)
Test 2: Validate w/ standard SPI...
        Read finished (640 bytes in 2593us)
        Checking for mismatches...
        Done
Test 3: Validate w/ QSPI...
        Read finished (640 bytes in 660us)
        Checking for mismatches...
        Done
Test 4: QSPI Write...
        Done (640 bytes in 663us)
Test 5: Validate w/ standard SPI...
        Read finished (640 bytes in 2593us)
        Checking for mismatches...
        Done
Test 6: Validate w/ QSPI...
        Read finished (640 bytes in 660us)
        Checking for mismatches...
        Done
Test 7: QSPI Writing across page boundaries...
        Wrote 307200 bytes in 317693us
Test 8: Validating with standard SPI...
        Failed (305760) mismatches
Test 9: Validating with QSPI...
        Failed (305760) mismatches

Failed with 611520 mismatches (199.06%)!

@matti122 @BitSalat this did not make the cut-off for our June release, but I'll get in some more polished drivers asap.
It would be helpful if you can confirm you can replicate the linked example above on your boards.

Hello Jake,
we are still in Design phase and our own PCB is currently not ready.
I tested it with MAX78000 Feather Board and got same results.
Best regards
Matthias


Error uploading to private repository via cli

Steps to reproduce

set up new virtualenv and install dependencies, including cloudsmith-cli
set CLOUDSMITH_API_KEY env variable to appropriate key
build python (3.5.2) package using setuptools/distutils (successful)
run process to upload python package to cloudsmith via cli tools
process errors as described below

Expected behavior
Upload occurs, placing package in proper repository per input values at the command line level. Outcome is identical to the process that would occur if uploaded by web UI (I have confirmed this works w/ the same package attempted via cli).
STDERR Output
$ python setup.py bdist_wheel
$ package_filename=$(ls dist)
$ cloudsmith push python private-org/python dist/$package_filename

Checking python package upload parameters ... OK
Checking private-org.models.common-0.1.0-py2.py3-none-any.whl file upload parameters ... OK
Requesting file upload for private-org.models.common-0.1.0-py2.py3-none-any.whl ... OK
Uploading private-org.models.common-0.1.0-py2.py3-none-any.whl:  [------------------------------------]    0%
Traceback (most recent call last):
  File "/home/pmdev/.virtualenvs/models/bin/cloudsmith", line 11, in <module>
    sys.exit(main())
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/cloudsmith_cli/cli/decorators.py", line 40, in wrapper
    return ctx.invoke(f, *args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/cloudsmith_cli/cli/decorators.py", line 65, in wrapper
    return ctx.invoke(f, *args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/cloudsmith_cli/cli/decorators.py", line 81, in wrapper
    return ctx.invoke(f, *args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/cloudsmith_cli/cli/decorators.py", line 119, in wrapper
    return ctx.invoke(f, *args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/cloudsmith_cli/cli/commands/push.py", line 382, in push_handler
    upload_files_and_create_package(ctx, *args, **kwargs)
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/cloudsmith_cli/cli/commands/push.py", line 245, in upload_files_and_create_package
    skip_errors=skip_errors, md5_checksum=md5_checksums[k]
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/cloudsmith_cli/cli/commands/push.py", line 94, in upload_file
    callback=progress_callback
  File "/home/pmdev/.virtualenvs/models/lib/python3.5/site-packages/cloudsmith_cli/core/api/files.py", line 62, in upload_file
    upload_fields.append(
AttributeError: 'dict_items' object has no attribute 'append'

Environment Details

python version: Python 3.5.2
OS: Elementary OS 0.4.1
uname -a: Linux asus13 4.10.0-42-generic #46~16.04.1-Ubuntu SMP Mon Dec 4 15:57:59 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

packages installed in virtualenv
certifi==2017.11.5
chardet==3.0.4
click==6.7
click-configfile==0.2.3
click-didyoumean==0.0.3
click-spinner==0.1.7
cloudsmith-api==0.21.3
cloudsmith-cli==0.3.1
colorama==0.3.9
configparser==3.5.0
idna==2.6
mongoengine==0.15.0
nose==1.3.7
nose-mongoengine==0.2.2
pep8==1.7.1
pycodestyle==2.3.1
pymongo==3.6.0
python-dateutil==2.6.1
requests==2.18.4
requests-toolbelt==0.8.0
semver==2.7.9
simplejson==3.13.2
six==1.11.0
urllib3==1.22

Notes
This looks like just a bad assumption related to the upload_fields object here, but it looks like this is being passed through from the upstream API, so I'm hesitant to fork and fix as I assume this was a list at one point where now a dict is present.

@mcclory Fantastic report, thank you!
It looks like this is a py2 vs py3 issue - It was developed primarily within py2 and we haven't implemented the test coverage yet to fully exercise it via py3 (but example integrations repository will be released before the new year, so at least we'll have an end-to-end test in py2 and py3!) The items() call returns a list within py2 but a dict_items within py3, so a quick fix here is to coerce it into list. A PR is more than welcome if you'd like to get your name stamped in the book! :-)

I'll check it out then :)  should be coming up shortly... and get back to not working.. plz!


Add wait_nodes_max_tries to wait for nodes to be available before applying the kubernetes configurations

PR o'clock
Description
Add wait_nodes_max_tries to wait for nodes to be available before applying the kubernetes configurations
Checklist

[x] terraform fmt and terraform validate both work from the root and examples/eks_test_fixture directories (look in CI for an example)
[ ] Tests for the changes have been added and passing (for bug fixes/features)
[ ] Test results are pasted in this PR (in lieu of CI)
[x] Docs have been updated using terraform-docs per README.md instructions
[x] I've added my change to CHANGELOG.md
[ ] Any breaking changes are highlighted above

Hi @rmakram-ims,
Is this to solve a particular problem? I've destroyed and recreated EKS clusters with this module many many times and never had kubectl timeout after cluster creation. Have you had this problem? What was the exact error message?

Hi @max-rocket-internet ,
Yeah, I was getting the following error:
Error applying plan:
1 error(s) occurred:
* module.test_eks_module.module.eks.null_resource.update_config_map_aws_auth: Error running command 'kubectl apply -f ./config-map-aws-auth_terratest_bfdlhtl1cfnion1pqqfg.yaml --kubeconfig ./kubeconfig_terratest_bfdlhtl1cfnion1pqqfg': exit status 1. Output: Unable to connect to the server: dial tcp <IP_ADDRESS>:443: i/o timeout

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

I would see this happening intermittently.

I think from that error you have some network connectivity problem. Because it's resolved the endpoint correctly but you are not able to connect to it. And the API hasn't returned an error like "service not ready", you are simply not able to connect to the AWS IP.
Do you get what I mean?

Thanks for the comment, I will check again on my side and will update this PR if needed.

Had the same issue: It failed on kubectl apply with same i/o timeout message. Tried to run it again and it was able to complete successfully.
It does not happen on every run, but I'd say approx in 30%.

OK but I think i/o timeout is a local problem, not really a problem with this module or the EKS service.
Also I've built and destroyed around 50 clusters with this module, even 4 new clusters this week, and never had kubectl timeout before. So I'm a little reluctant to add 3 resources, another script and variable to solve this problem unless it's super common.
Have you guys tested the --request-timeout option for kubectl?
Does kubectl timeout regularly, after cluster creation?

Hey,
exactly the same issue here. @max-rocket-internet totally see your point. What about making module.test_eks_module.module.eks.null_resource.update_config_map_aws_auth optional? or allowing to sleep inbetween :)
Creating cluster from germany in us-east1 and run regularly in this timeout issue.

OK it seems some other people also have this problem (e.g @Jeeppler in https://github.com/terraform-aws-modules/terraform-aws-eks/issues/199) so let's get something merged 😎
Can we greatly simplify this though? I think 3 new resources, another script and variable is a little overkill.
Is there anything wrong with this?
resource "null_resource" "update_config_map_aws_auth" {
  depends_on = ["aws_eks_cluster.this"]

  provisioner "local-exec" {
    command = "for i in {1..5}; do kubectl apply -f ${var.config_output_path}config-map-aws-auth_${var.cluster_name}.yaml --kubeconfig ${var.config_output_path}kubeconfig_${var.cluster_name} && break || sleep 10; done"
  }
...

@Dolape1983 do you have network problem where you are running terraform? Like a bad connection? Does increasing {1..5} or sleep 10 help for you?

Hi @max-rocket-internet , I'm running mi pipeline in gitlab.com and I have the same issue. I think that problem is regarding about permissions, because I'm using aws_security enabled. Locally I don't have the issue. I'm investigating about the base setup for use aws security and eks. If I have news I'll share it with you.
Warm Regards.

The script in the null resource breaks the module on Windows. It is now a shell-specific script, which won't work in cmd. This should be reverted or fixed immediately.


rc4 compilation failure with operator/distinctKey

src/add/operator/distinctKey.ts(2,29): error TS2307: Cannot find module '../../operator/distinctKey'

distinctKey was removed https://github.com/ReactiveX/rxjs/commit/89612b2914fe0f48123ceaa66e3e63b5f7975873

We forgot to remove the file https://github.com/ReactiveX/rxjs/blob/c7cfe444642407f3227a09a0cdf38fd495b867e1/src/add/operator/distinctKey.ts


Please see here.

Hi,
Thanks for clicking in.
Please forgive me that I was so busy these days that could not solve issues and reply emails from you. Unfortunately, I will continue to be very busy (in applying PhD, writing master thesis and many other things) until Jan 2019, and this issue is for brief answers to some questions and my plan that need your suggestions.
My plan:
In the beginning, I released PRNet just for sharing my research work, which only focuses on reconstruction and dense alignment.  Other applications like pose estimation and face swapping are implemented casually for showing the usefulness of the research results. So the problem is that the project is not well-organized and many parts need to be optimized(that's why I don't want to add functions based on the current framework).
So, I plan to make a BIG UPDATE in Jan 2019.
Just now, I've updated my another project face3d, which implements some basic functions about 3D faces. The expected new version will replace many current codes with functions from face3d, which should be then faster and more extensible.
Furthermore, I am very happy that this project could be useful for you, and I want to add more useful functions. It would be appreciated if you could write down some suggestions below.
After the update, if you still have problems, I will then help you solve the issues.
Now, I give some brief answers to Questions about

applications based on PRNet
I strongly recommend you see the repo face3d, especially transformation and render part, then you should be able to accomplish applications based on PRNet quickly and solve many problems easily. From my personal perspective, PRNet and face3d contain almost all the core parts and enough examples, only writing several lines could implement a specific application(Of course, optimization need more time). If you have done one and released your code, please send me the link and I would like to add it in the readme. Thanks in advance for your sharing!
expressions
Sorry for that PRN can not process expressions now, this is decided by the algorithm. I am working on new algorithm that can solve this.
relationship with 3DMM
Of course we can establish the relationship between position map and 3D morphable model back, I will add this function in the new version.
training codes
I am sorry that the released training codes are all for some reasons. However, from emails, I know there are someone have re-implemented the training part well and are willing to release them, maybe you can wait.
python version
Now PRNet is only tested on python 2, I will modify the codes so that they can run on python 3 and windows. You can also run them now with small changes. see #23
ideas about 3D faces
It's very welcomed if you are willing to discuss some new ideas with me, via my email<EMAIL_ADDRESS>
Thanks for your understanding!
Best,
Yao Feng

hope you back.

Dear YadiraF,
I have a c++ implementation which can run on iOS (only for pose estimate based on dense landmark and face swap),
https://github.com/taylorlu/FaceConverter
The app can reach 3-5fps for face swap, on iPhone SE device.
But it seams that the render part is more time cost when the face area is bigger, because the poisson blend?
And the quality of blending face is unadjustable, how to enhance the face quality when we use a face picture with a high resolution.
The last question is the 3D landmark in video is apt to shake frame by frame. Is there any method to keep stability such as landmark tracking.
Hope you back.

Hi YadiraF:
Will the training source code be open? Could you please send your PRNnet train code to my email?1261775243 @qq.com
Thank you very much!


Add ability to update the node properties for existing relations/edges

@tmkasun Please let me know when the fix is pushed to this PR.


Add support for OS X and manylinux platform tags

Also removed "win-amd64" and "win-ia64" from the whitelist, since they
violate PEP 425.
Fixes: gh-1008
Fixes: gh-1009

You have linting errors here.

Fixed, tests are passing

Improved error message and tests are passing -- ready to go I think.


recreate settings panel using metabox.io

Rather than maintaining our own settings panel and metabox components, we can simplify things by utilizing metabox.io. This will also give us some flexibility with all the field types, options, and extensions that metabox.io has built over the years.

backlogging for now.

We decided against this for the foreseeable future.


schema not valid with dark theme

when using dark theme, the private endpoint schema is unreadable.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22711686-7353-1674-4313-96801a0808dc
Version Independent ID: ef864bd9-a9ad-3537-18e3-9cd41f035ffb
Content: Network security for Azure Event Grid resources
Content Source: articles/event-grid/network-security.md
Service: event-grid
GitHub Login: @VidyaKukke
Microsoft Alias: vkukke

Hi @Ericgre Thanks for your feedback. We will review and update as appropriate.

@Ericgre It will be great if you can provide some screen shot.

you can just try yourself to use the dark theme on this page : https://docs.microsoft.com/en-us/azure/event-grid/network-security
here is the result :

@Ericgre I have assigned this to content author for further review and update as appropriate.

#reassign: spelluru

This issue is fixed now.
#please-close


[DOC] Seperated Notes and References

What does this implement/fix? Explain your changes.
Fixes #2280
Separated Notes and References.

@MatthewMiddlehurst any reason for the error?

@MatthewMiddlehurst any reason for the error?

no reason, random fail, re-ran the failed job


Trim extra parameters

Main changes

fix: trim key-value pairs for extra arguments

It works perfectly now thank you very much @inigomarquinez @Betisman @UlisesGascon

I'm already using version 2.0.2 in the project I'm working on, thank you


Include login as a popover

We should make it as we had it before, like Scratch does it. Here's the login form that can be included pretty much everywhere.
<form action="http://opensprites.gwiddle.co.uk/forums/?p=user/login" method="post" enctype="multipart/form-data">
<input type="hidden" name="return" value="http://dev.opensprites.gwiddle.co.uk/">
<input type="hidden" name="token" value="2ad259bb23746">

Username or Email

<input type="text" name="username" value="">

Password Forgot?

<input type="password" name="password" value="">

<input type="submit" name="login" value="Log In" class="big submit button">

</form>

I support this. @The-Cheese-Eater, is this OK to implement?

It's ok as long as everything still fits in with EsoTalk.

Well, some styling will have to be required. But I support.

I didn't bother including styling for this example. :P

I meant that we shouldn't use that form- we should use an iframe like /login/ as it EsoTalk won't let you log in through other means.

Yep. :) The token seems to be the same all the time, so it's just a matter of copy, paste and adding styling. Even if we don't use a popover, we could replace the iframe with this so it doesn't look so ugly with the dark theme.

Heh, the forums will look fine once cheese merges dev.opensprites and opensprites. The localStorage doesn't carry over os-theme.

I was thinking we should just screw the development sub-domain and move everything over to the main one? It's not like the main domain gets a high hit count, yet.

Yeah, maybe- it'll make my life easier :P

Have you seen my new epic user pages?

Yeah, I have. :) But the background image on my profile looks a bit dodgy though. :P

I think it looks quite cool, to be honest :P

Try uploading some images- they appear on your profile page now! http://dev.opensprites.gwiddle.co.uk/users/4/

It automatically updates with ajax.

Really cool! :D

Though I'm not sure about the blurred logo as the background on my profile, and a big white box in the center. it doesn't contrast well, if thats what the arty people say. :P

Oh, our first sound! http://dev.opensprites.gwiddle.co.uk/uploads/uploaded/1-4.mp3

Did anyone implement this?

Did anyone implement this? I can't remember is somebody mentioned if this was possible or not...

no

I think the token field may change, unless it was just because of a forum reset.


Fix enumJsonFormat not to throw an exception on invalid input

enumJsonFormat currently throws an exception when encountering an input String that doesn't match any of the enum's constructors.
This pull request makes it return a FromAeson ParseError. Not an ideal solution, but certainly better than exception.

Oh this is great thanks! And a unit test to boot! When I wrote this I apparently spaced on fail having bad behavior for ABE.

I removed all other uses of fail in an ABE context that I could find, and cut a release <IP_ADDRESS> with this and some other fixes. Thanks again!


add back_AD and test

Codecov Report
Patch coverage: 86.84% and project coverage change: -1.47% :warning:

Comparison is base (7047e66) 61.09% compared to head (5c843bf) 59.63%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           tao_AD     #133      +/-   ##
==========================================
- Coverage   61.09%   59.63%   -1.47%
==========================================
  Files          55       48       -7
  Lines        3416     3218     -198
==========================================
- Hits         2087     1919     -168
+ Misses       1329     1299      -30

Files Changed
Coverage Δ

src/computational_graph/operation.jl
95.52% <86.84%> (-2.20%)
:arrow_down:

... and 52 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Creatures are listed as grouped even when they aren't

If you click the roll all button in initiative the card for all the creatures says "grouped" even if there is only one of that creature. I'm not sure this is intended and it might be misleading.

@Zamrod can you possibly share a screenshot of what happens? I've just added a bunch of creatures and PC's and click the "Roll All" and it created groups (when there were more than one) and not-groups (for single creatures/pc's) for the creatures as expected.
Also tried when there were just single creatures/pc's and that look correct as well.

Believe I found a fix for this, will be released a bit later the week


Rendering an Obj file with implicit face normals

Hi,
I'm trying to render a submarine object from poly.
In this specific submarine object the vertex normal indices are implicit.
You can see it when looking at the "faces" lines, for example f 40/91 41/90 37/89 36/88
I previously tried to use rajawali  to render the object, but I got a runtime exception there are no normals specified for this model.
It looks like rajawali expect for explicit declaration of face normals, although:

Vertices are stored in a counter-clockwise order by default, making explicit declaration of face normals unnecessary.
from .obj wiki

In the documentation stated that

Construct a mesh with default vertex layout float3 a_position float2 a_texcoord float3 a_normal

and also:

Usually each mesh vertex may have a position, normal and texture coordinate.

My question is, does GVRMesh intended to parse and render an Obj file with implicit face normals?
Thanks!

There are many special cases as you observe if it's currently unsupported. And we may choose to utilize time to support more modern file formats with the resources we have.
I'd say the fastest way to resolve this is to convert the models so there are no implicit normals via Blender for example

@itanbp we use assimp (assimp.org) for loading in many file formats, including obj.  @NolaDonato will assimp support what he is looking for?
and fwiw, we have our own parser for x3d that will generate normals if they are not provided in the file.  if it would be possible to export to x3d (read the file in blender, export to x3d), that may do what you need.

@itanbp Assimp doesn't generate the normals for us when using the model you referenced (tells us there are no normals). You can still load the model and view it but there will be no lighting effects.

@bohuang3d @thomasflynn @liaxim thank you all for your quick answers!
I'm intending to work with Poly project, which is a large, free to use, 3D virtual objects library. Poly is also accessible via an API.
Using Blender (as a solution for the implicit normals) isn't relevant as I'm building an Android app that fetches 3D models, and displays them to the user.
What do you suggest? What is the effort of calculating the normals and changing this files to explicitly declare the face normals?

there appears to be a 'GenNormals' post process flag for assimp (http://assimp.sourceforge.net/lib_html/postprocess_8h.html).  let us investigate that and see if we can enable it.

@thomasflynn the GenNormals flag looks like the right solution -

This is ignored if normals are already there at the time this flag
is evaluated.

@NolaDonato  I'm not sure I fully understand the difference between the two options you mentioned, but this 3D model and many similar ones with the same issue are exported without normal vectors at all.
For instance, you can notice that in the submarine model it doesn't have vn lines at all.
If it helps, my goal is to render the model the same way they are in Poly, see how the object renderer here

EnumSet<GVRImportSettings> importSettings = EnumSet.of(CALCULATE_NORMALS, TRIANGULATE) works. TRIANGULATE required to avoid exception in AiMesh. Doesn't look much like the referenced example though. Added a light but didn't help much.

Works for me too. The mistake I made was not to use GVRImportSettings.getRecommendedSettingsWith so I was missing required import flags. GVRImportSettings.getRecommendedSettingsWith should be at least mentioned in the javadoc if not automatically used.

thank you all for your help!


0.0.8 only showing Zappi

0.0.7 showed the Zappi, Harvi, Hub but only the Zappi is now showing in 0.0.8
I have just removed a custom setup and re-installed and setup via HACS.

It sounds like something goes wrong, have you check the log for any errors?

I was about to say nothing in there but ...
Logger: homeassistant.components.sensor
Source: custom_components/myenergi/sensor.py:131
Integration: Sensor (documentation, issues)
First occurred: 1:08:06 pm (2 occurrences)
Last logged: 1:08:17 pm

Error while setting up myenergi platform for sensor
Traceback (most recent call last):
  File "/snap/home-assistant-snap/365/lib/python3.8/site-packages/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform
    await asyncio.shield(task)
  File "/var/snap/home-assistant-snap/365/custom_components/myenergi/sensor.py", line 131, in async_setup_entry
    totals = coordinator.client.get_power_totals()
  File "/root/snap/home-assistant-snap/365/.local/lib/python3.8/site-packages/pymyenergi/client.py", line 88, in get_power_totals
    if device.ct3.is_assigned:
AttributeError: 'Eddi' object has no attribute 'ct3'

Ah! It's fixed in 0.0.10 which was just released :)


Support tensorflow melgan version for speedup inference time

Hi @kan-bayashi , this is the PR adds tensorflow melgan version using tf.function to optimize speed (around 2x-3x faster on CPU and GPU). The PR include code for TFMelganGenerator, notebook for convert weight from pytorch original version to tensorflow version and simple notebook to check the inference speed of tensorflow/pytorch version.

Hi @dathudeptrai.
Thank you for your great PR!
Could you remove notebook/.ipynb_checkpoints and add .ipynb_checkpoints to .gitignore?

@kan-bayashi okay :D

@dathudeptrai I made PR for your fork. Could you check it?
https://github.com/dathudeptrai/ParallelWaveGAN/pull/1

I will merge. Thanks for your great feature, @dathudeptrai!

hi @kan-bayashi , just curious about the performance on ur GPU :D

OK. I will check it later.

hi @dathudeptrai
get this error when this line code  “audio = TFMelGANGenerator(**config["generator_params"])(inputs)”  run ，
InaccessibleTensorError: The tensor 'Tensor("conv2d_80/dilation_rate:0", shape=(2,), dtype=int32)' cannot be accessed here: it is defined in another function or code block. Use return values, explicit Python locals or TensorFlow collections to access it. Defined in: FuncGraph(name=call, id=139867161584976); accessed from: FuncGraph(name=call, id=139867559519064).'

@dathudeptrai I tried in colab. x2.3 faster!

I found that .numpy() is too slow.

@kan-bayashi thanks for ur information. So now we can conclude that tensorflow version is faster than pytorch version around 2.X times ?, on my 2080Ti, TF is faster than pytorch 3.4 times. I also check my TF fastspeech version and got 2x faster than pytorch fastspeech. I'm planing to implement training code for fastspeech and melgan/parallelwavegan on tensorflow, since tf support pruning and sparse convnet (being implemented internally as far as i know), we will further optimize speed to 2-4 times :))

In colab, the speed comparison result is not consistent (there is a case where both models are almost the same). Personally, I love pytorch since the api is beautiful but in terms of the speed, it seems that tensorflow is better than pytorch.

Hi @kan-bayashi , not sure if u know that colab have 3 different types of GPU :v (T4: 8GB, K80: 12GB, P100: 16gb). on T4 8gb, pytorch and tf is the same but on K80 and P100, tf is faster than pytorch about 2-3x :D

Ah-ha. I see! Let me check it.


是否可以提供一个动态修改sleuth采样率的示例

就像动态修改zuul路由的那个例子一样，给出一个动态修改sleuth提交zipkin采样率的例子，谢谢！

后续可以加一下，不过原理都差不多的，具体接入方式应该google一下也能找到

if you do dynamic sample rates, let me know.. there is some prior art available:
rate limited sampler: https://github.com/openzipkin/brave/pull/819
old zookeeper adaptive group-based sampler: https://github.com/openzipkin-attic/zipkin-zookeeper

This issue is closed for now. Please provide more information if further assistance is needed, Thanks!


Calling setState() during build without user interaction

Steps to Reproduce

Integrate FCM (Firebase Cloud Messaging) in the app.
Share the context and the setState() of each page in static variables with these two lines by calling them in all the build functions of all the pages :

    @override
    Widget build(BuildContext context) {
        StaticClass.currentContext = context;
        StaticClass.currentSetState = this.setState;
        return ... ;
    }

Create a callback to handle the coming notifications when the app is running

    fcm.configure( onMessage: (){
        StaticClass.currentSetState((){
            Navigator.pushNamed(StaticClass.currentContext, "/notifications");
      });
    });

Logs
I/flutter (31385): onMessage Fired
I/flutter (31385): ══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
I/flutter (31385): The following assertion was thrown building MainPage(dirty, state: _MainPage#f9b84):
I/flutter (31385): setState() or markNeedsBuild() called during build.
I/flutter (31385): This Overlay widget cannot be marked as needing to build because the framework is already in the
I/flutter (31385): process of building widgets. A widget can be marked as needing to be built during the build phase
I/flutter (31385): only if one of its ancestors is currently building. This exception is allowed because the framework
I/flutter (31385): builds parent widgets before children, which means a dirty descendant will always be built.
I/flutter (31385): Otherwise, the framework might not visit this widget during this build phase.
I/flutter (31385): The widget on which setState() or markNeedsBuild() was called was:
I/flutter (31385):   Overlay-[LabeledGlobalKey<OverlayState>#78a15](state: OverlayState#54ba6(entries:
I/flutter (31385):   [OverlayEntry#a97c0(opaque: false; maintainState: false), OverlayEntry#bb499(opaque: false;
I/flutter (31385):   maintainState: true), OverlayEntry#267ab(opaque: true; maintainState: false),
I/flutter (31385):   OverlayEntry#cbb6e(opaque: false; maintainState: true), OverlayEntry#25923(opaque: false;
I/flutter (31385):   maintainState: false), OverlayEntry#8f9f9(opaque: false; maintainState: true),
I/flutter (31385):   OverlayEntry#ff888(opaque: false; maintainState: false), OverlayEntry#fb1a4(opaque: false;
I/flutter (31385):   maintainState: true)]))
I/flutter (31385): The widget which was currently being built when the offending call was made was:
I/flutter (31385):   MainPage(dirty, state: _MainPage#f9b84)
I/flutter (31385):
I/flutter (31385): When the exception was thrown, this was the stack:
I/flutter (31385): #0      Element.markNeedsBuild.<anonymous closure> (package:flutter/src/widgets/framework.dart:3485:11)
I/flutter (31385): #1      Element.markNeedsBuild (package:flutter/src/widgets/framework.dart:3511:6)
I/flutter (31385): #2      State.setState (package:flutter/src/widgets/framework.dart:1146:14)
I/flutter (31385): #3      OverlayState.insertAll (package:flutter/src/widgets/overlay.dart:301:5)
I/flutter (31385): #4      OverlayRoute.install (package:flutter/src/widgets/routes.dart:43:24)
I/flutter (31385): #5      TransitionRoute.install (package:flutter/src/widgets/routes.dart:185:11)
I/flutter (31385): #6      ModalRoute.install (package:flutter/src/widgets/routes.dart:861:11)
I/flutter (31385): #7      NavigatorState.push (package:flutter/src/widgets/navigator.dart:1560:11)
I/flutter (31385): #8      NavigatorState.pushNamed (package:flutter/src/widgets/navigator.dart:1473:12)
I/flutter (31385): #9      Navigator.pushNamed (package:flutter/src/widgets/navigator.dart:740:34)
I/flutter (31385): #10     _MainPage.build (package:mcom/Pages/HomePage.dart:32:17)
I/flutter (31385): #11     StatefulElement.build (package:flutter/src/widgets/framework.dart:3809:27)
I/flutter (31385): #12     ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3721:15)
I/flutter (31385): #13     Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter (31385): #14     BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2286:33)
I/flutter (31385): #15     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:676:20)
I/flutter (31385): #16     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:219:5)
I/flutter (31385): #17     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
I/flutter (31385): #18     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:930:9)
I/flutter (31385): #19     _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:842:5)
I/flutter (31385): #20     _invoke (dart:ui/hooks.dart:154:13)
I/flutter (31385): #21     _drawFrame (dart:ui/hooks.dart:143:3)
I/flutter (31385): ════════════════════════════════════════════════════════════════════════════════════════════════════

Explanations :

I can't update the page (by using context or calling setState()) when the framework is building
This problem doesn't happen when this function is called with a user interaction

What I want :

Is there a way to repair my code or am I doing something wrong ?

OR

Is there any other solution to go to another Page when onMessage() is triggered ?

OR

Is there a way to know when the build function completes, to setState() without any problem ?

Please Help I'm stuck here

Solution from StackOverflow by (miguelpruivo):
You can call setState after rendering is done by adding a post frame callback with addPostFrameCallback method. This will be called only once and after build process is done.
import 'package:flutter/scheduler.dart'

SchedulerBinding.instance.addPostFrameCallback((_) => setState(() {}));

Solution from StackOverflow by (miguelpruivo):
You can call setState after rendering is done by adding a post frame callback with addPostFrameCallback method. This will be called only once and after build process is done.
import 'package:flutter/scheduler.dart'

SchedulerBinding.instance.addPostFrameCallback((_) => setState(() {}));

This Worked for me.
Thank you @Khalilbz

Solution from StackOverflow by (miguelpruivo):
You can call setState after rendering is done by adding a post frame callback with addPostFrameCallback method. This will be called only once and after build process is done.
import 'package:flutter/scheduler.dart'

SchedulerBinding.instance.addPostFrameCallback((_) => setState(() {}));

thank you

Similar To Is there any callback to tell me when “build” function is done in Flutter?

@Khalilbz Hey! This doesn't work for me.. When I'm calling it and use setState.. the program never stops and running for ever..
Please if you have any suggestion please inform me :)


Enable use of up/down asymmetric images

To summarize some of the discussion which already took place in https://github.com/PyAbel/PyAbel/issues/14, currently PyAbel presupposes the raw_data being transformed has up/down symmetry, i.e., f(r,-z) = f(r,z). This is mostly because in photoelectron spectroscopy, images are theoretically up/down symmetric, and so a lot of reconstruction algorithms make this approximation in order to gain better signal-to-noise.
The underlying BASEX algorithm does not require the raw_data being transformed to have up/down asymmetry. The only requisite symmetry is the lateral f(-r) = f(r) condition, which is common to all Abel inversion algorithms. This symmetry condition is a feature of many experimental data sets, such as images of coflow and counterflow flames, or even in photoelectron spectroscopy images, where hot spots on the detector might break up/down symmetry. Therefore it would be useful to enhance PyAbel to perform in the more general no-up-down-symmetry situation.
My fork of PyAbel, PyroBASEX has already made the changes to the basis-set generation and implementation codes to account for this situation. The overall changes can be summrized as: n has been decomposed into n_horz and n_vert, and the relevant nbf_horz and nbf_vert basis functions are generated for each direction independently. The basis functions in the vertical direction do not need to be forward-transformed, and therefore their calculation is very quick.
As far as incorporating the code changes into PyAbel goes, most of it ought to be straightforward. To preserve code legibility in PyAbel, it might be useful to have two separate internal basis-set generation routines. From the end-user's perspective, a vertical_symmetry=<True, False, or unspecified> will need to be added to whatever function call is being made to do the transform. Additionally, the format of the specification of the center of the raw data will need to be updated to handle a vector in addition to a tuple.
One user-interface concept is the one discussed in https://github.com/PyAbel/PyAbel/issues/14

vertical_symmetry=True -> Use PyAbel code
vertical_symmetry=False or unspecified -> Use pyroBASEX code

Examples

n=500 -> Use pyroBASEX, n_horz, n_vert = 500,500
n=500, vertical_symmetry=True -> Use PyAbel as usual
n=(500,500), vertical_symmetry=True -> Same as above, convert n from tuple to integer n=500
n=(500,500) -> Same as 1)
n=(500,498) -> Use pyroBASEX, n_horz, n_vert = 500,498
n=(500,498), vertical_symmetry=True -> Enlarge raw_data to (500,500), then proceed as 3)

This looks great! A minor comment could be that for point 6) after the transform is performed, the padded zeros are removed to get the orginal shape of raw_data.

Agreed.
Another situation that just came to mind - what if raw_data is bigger than the user-specified values of n? Do we crop raw_data centered around center to make a new shape with dimensions equal to n?

I agree, that would be consistent with the way it works now.

I'm excited about including the asymmetric option, and now that @rth has made the major user interface changes, I think that we are good to move forward with this.
I would think that it would be safer to make decisions about the symmetric versus asymmetric transform based solely on the vertical_symmetry keyword. Having the transform function act differently based on the tuple versus the integer arguments for n is subtle and might be confusing. Is there any problem with just using vertical_symmetry and throwing an error if n does not match?
Currently raw data is cropped if it's too large, which seems like what most users would want. We could consider a warning if the image is being clipped and suggest that the user select a larger basis set. For now I would say to just clip the image.

With PR #54, BASEX can now handle images that do not have up/down symmetry. This issue has been resolved.

Great work on this @DhrubajyotiDas!


LUCI tasks failing with 401 AuthenticatedClientError URI: https://flutter-dashboard.appspot.com/api/update-task-status

All the LUCI tests on my PR are failing

Unhandled exception:
AuthenticatedClientError:
  URI: https://flutter-dashboard.appspot.com/api/update-task-status
  HTTP Status: 401
  Response body:
User is not signed in
#0      AuthenticatedCocoonClient.send (package:flutter_devicelab/framework/cocoon.dart:168:7)
<asynchronous suspension>
#1      BaseClient._sendUnstreamed (package:http/src/base_client.dart:91:38)
#2      BaseClient.post (package:http/src/base_client.dart:32:7)
#3      Cocoon._sendCocoonRequest.<anonymous closure> (package:flutter_devicelab/framework/cocoon.dart:125:25)
#4      retry (package:flutter_devicelab/framework/utils.dart:773:22)
<asynchronous suspension>
#5      Cocoon._sendCocoonRequest (package:flutter_devicelab/framework/cocoon.dart:124:37)
#6      Cocoon.sendTaskResult (package:flutter_devicelab/framework/cocoon.dart:109:49)
#7      _runTasks (file:///b/s/w/ir/k/flutter/dev/devicelab/bin/run.dart:114:20)
<asynchronous suspension>
#8      main (file:///b/s/w/ir/k/flutter/dev/devicelab/bin/run.dart:93:11)
#9      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:309:32)
#10     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8864599270237813584/+/steps/run_build_aar_module_test/0/stdout

Thanks Jenn for filing.
This looks related to a CL I had. I created a revert at  https://flutter-review.googlesource.com/c/recipes/+/8241. Once that lands and propagates these should go back.
I'll add this builder to our presubmit testing for recipes to prevent future breakages.

Fix landed: https://ci.chromium.org/p/flutter/builders/try/Linux build_aar_module_test
Created https://github.com/flutter/flutter/issues/69778 to track the fix to prevent future breakages.


Fixed #34058 -- Changed sequence types when altering pre-Django 4.1 auto fields on PostgreSQL.

Thanks Anders Kaseorg for the report.
Regression in 2eea361eff58dd98c409c5227064b901f41bd0d6.
ticket-34058

@andersk Can you confirm if it works for you?

Yes, this seems to work.

Yes, this seems to work.

Many thanks for your confirmation :tada:


Route description

This repo will soon be deprecated. The new repo is https://github.com/lazojs/lazo-todomvc. The routes set up documentation should be a part of https://github.com/lazojs/lazo/tree/master/docs as LazoAppJson.md, which should describe the app level configuration. For now route documentation can be found https://github.com/lazojs/lazo/wiki/Configuration#appjson.


Release 0.1.0

@rultor release it; the tag is 0.1.0.

@rultor release it; the tag is 0.1.0.

@rafamizes OK, I will release it now. Please check the progress here

@rultor release it; the tag is 0.1.0.

@rafamizes Done! FYI, the full log is here (took me 1min)


Add(): learn to record hashes of what we add

Add a field to AddOrCopyOptions that can take a 1hash.Hash1, or more often a Hash returned by digest.Digester's Hash() method, to calculate a sum over what we add or copy.
Make the help output summarizing the arguments that buildah add and buildah copy accept more closely match their man pages.

LGTM
but failing tests.
Is this for the --layers work?

Changes LGTM, seeing new related warnings in the test output:
add.go:39:63:warning: hasher can be io.Writer (interfacer)
util.go:95:62:warning: hasher can be io.Writer (interfacer)
util.go:111:58:warning: hasher can be io.Writer (interfacer)
util.go:127:56:warning: hasher can be io.Writer (interfacer)

@TomSweeneyRedHat I tried to lower buildah default logging to Warning, but it looks like that was a mistake, since we have stuff like this showing up to the user. I think we need to move it back to Errors before we release.

@rhatdan, ugh hadn't thought of that.  If we bump back up to error, will that mess up Podman?

No.  But there was some Warnings I wanted to get out to buildah.

Replaced hash.Hash objects with io.Writer in the new additions, and tweaked things so that copyFileWithTar produces a digest of just the file contents based on feedback from @umohnani8.

Is this merging before 1.1? (#769)

No.

LGTM

@TomSweeneyRedHat @umohnani8 @pixdrift PTAL

LGTM

@rh-atomic-bot r+


Kron and KronDecomposed error handling

Currently, these do not support BatchNorm due to the backends but this should not fail silently when all-weights Laplace is used on networks with Batchnorm.

I face the problem that I want to compute the Laplace approximation of ResNets, which contain BatchNorm.
I intend to ignore them and warn the user about it.
More concretely, I will send a warning to the user and will initialize the kronecker factors for the Batchnorm layers to 0. Since the backend also returns 0 as values for these layers, they should infact just be kept ignored.
I plan to update the Asdl interface for that.
Is the approach correct ?
I can implement it and create a pull request.

Just returning them as zero could be fine within the backend but might be problematic for the posterior approximation. The prior will still be non-zero and when Computing the predictive or marginal likelihood, the batch norm curvature will be non-zero. I think what could be safer is to return a single factor as None and then handle these cases in the matrix.py module within the Kronecker classes. This way you can make sure that they do not impact any important quantity.


Getting timeout error

Hi @shikha1970,
Let me test it quickly. Looks like there is some issue with the dependencies. I will test the setup and give you an update later during the day.

Hi @shikha1970,
Thanks for submitting the issue. I will fix the issue with the attached PR. Can you please update the environment.yml in train/ and deploy/ to the following:
deploy/environment.yml
# Conda environment specification. Details about the Conda environment file format:
# https://conda.io/docs/user-guide/tasks/manage-environments.html#create-env-file-manually

name: deployment_env
dependencies:
  - python=3.8
  - scikit-learn=0.23.2
  - numpy=1.19.4
  - pip:
    - azureml-defaults==1.19.0
    - azureml-monitoring==0.1.0a21
    - inference-schema==1.1.0
    - inference-schema[numpy-support]==1.1.0
channels:
  - conda-forge

train/environment.yml
# Conda environment specification. Details about the Conda environment file format:
# https://conda.io/docs/user-guide/tasks/manage-environments.html#create-env-file-manually

name: training_env
dependencies:
  - python=3.6.2
  - scikit-learn=0.23.2
  - pandas=1.1.5
  - matplotlib=3.3.3
  - pip:
    - azureml-defaults==1.19.0
channels:
  - conda-forge

@shikha1970 Can you confirm that this fixes the issue?

@marvinbuss yes thanks this worked like a charm. thanks for quick revert and fix! Just brilliant!

Thanks @shikha1970 for your response and for submitting the issue. I am glad that it works for you! I have also updated the branches accordingly. Have a great weekend!


More notebooks for the reference gallery

The goal is to get at least one examples of each type of plot before merging this.

If this passes I'll merge it. The only one missing is paths.

The only remaining notebook failure is from an example that is not changed in this PR.


Create practical examples using public datasets

Summary

Create case studies of how manifold is applicable to analyzing ML models in real world data science examples.

if you can pickup resnet model with coco dataset and show an example on how to setup manifold on a localsystem and visualize the model performance it would be very helpful.


C#: Skip methods with pointer parameters

Ignore methods with pointer parameters when generating the C# API. Currently these methods are generated using integer type parameters which makes them unusable.
Example of a method with pointer parameters: MultiplayerPeerExtension::_get_packet
https://github.com/godotengine/godot/blob/0ddd9c3e8f9088fa139e25b2903289d727073e12/doc/classes/MultiplayerPeerExtension.xml#L44-L51
This generates the following C#:
public virtual Error _GetPacket(long rBuffer, long rBufferSize)
{
    return default;
}

The parameters are Variant::INT, virtual methods currently don't have metadata so they are long (this is a separate issue unrelated to this PR), the important thing to notice is that these parameters are meant to be pointers because they are out parameters, the generated C# methods make them impossible to use.
This breaks compat because it removes methods from the public API but I don't think anyone is using them since they don't work.
For convenience, this is the diff of the generated C# API with this PR:
diff.zip

These parameters can actually be used by casting them to the appropriate pointer type, so this should a somewhat useful implementation of that example method:
public override Error _GetPacket(long rBuffer, long rBufferSize)
{
	var buffer = GC.AllocateArray<byte>(1024, pinned: true);
	var len    = _stream.Read(buffer);
	_keepAlive = buffer;

	*(byte**)rBuffer = (byte*)Unsafe.AsPointer(ref buffer[0]);
	*(int*)rBufferSize = len;
	return default;
}

If proper type information about the pointer is not available, I would make these parameters void* or at least IntPtr to show that they are pointers and not just numbers without having to open the documentation of that method.

Are these methods available in GDScript?

@RedworkDE I think using unsafe to make the method work is not the most intuitive so I'd rather not expose it like this. I agree that if we were to expose this a better way to do it would be to use pointers or IntPtr.
I'm not sure if we want to expose these methods but if we do we can always do it without breaking compatibility later, the main motivation for this PR is trying to remove potentially bad API before the stable release to avoid having to break compatibility later.

Are these methods available in GDScript?

@neikeq I don't think so, since GDScript doesn't support pointers. This particular API does have al alternative that is exposed so it can be used in GDScript:
https://github.com/godotengine/godot/blob/0ddd9c3e8f9088fa139e25b2903289d727073e12/doc/classes/MultiplayerPeerExtension.xml#L58-L63
https://github.com/godotengine/godot/blob/9ebb3e3107bee82da2b4eafad685978c26bc1a2c/scene/main/multiplayer_peer.h#L116
Which is also generated in C#:
public virtual byte[] _GetPacketScript()
{
    return default;
}

If they're not usable from GDScript, I think it's fine to skip them. Especially, if there's no target type information. Not a big fan of those methods tbh. They're a poorly designed patch for exposing more advanced stuff to GDExtension.

Are we sure there's no way to retrieve that uint8_t type information?

There is, the hint_string gives you const uint8_t * in that case.

the hint_string gives you const uint8_t * in that case

Never mind, it is what I'd thought initially. I don't have much interest in supporting that unless there's a case where it gives a great advantage over the normal API.

Thanks!


add replacement cycling

Issue
I can not run ariard's replacement cycling test in Warnet.
Cause
A number of the test framework components available in Bitcoin Core have not been ported into Warnet.
Solution
Add the replacement cycling test as a scenario.
Wins
The test runs without meaningful augmentation. This is great because it points us in a direction of copy/pasting tests that run today in Core's functional test framework. We can then augment the tests to work in realistic environments with lightning nodes and other future tank types.
Depends on
#370
#371

are you able to get this scenario running in warnet?

Yes, we got a version of it working just fine on this branch. There shouldn't be any differences that sync_all would have trouble with. I'll rebase and have a look.

I rebased this.

Rebased on main

@willcl-ark Happy to add a CI for this.
When the scenario failed locally, were these the steps you took?
just start
just p &
warcli scenarios run repalcement_cycling

Closing in favor of https://github.com/bitcoin-dev-project/warnet/pull/422


Faster Call for CompiledSDFG

This PR adds a new possibility how a CompiledSDFG can be called.
Before __call__() performed a lot of operations, which can be summarized as:

Ensuring that the arguments are ordered correctly.
Transforming them to the right type (ndarray to pointers).

Especially when benchmarking smaller SDFG this is a lot of overhead, which actually dominates the execution.
Furthermore, the runtime heavily depends on the number of arguments.
To solve this, this PR introduces the _fast_call() function, which expects that its arguments are already in the right order and casted to the right type.
In addition it does some refactoring and splits _construct_args() into multiple parts.

@BenWeber42 Now ready for review.

Hi, thanks for the PR!
Unfortunately, I'm not too familiar with these parts of the codebase, so it would take me quite some time to do a proper review. Let's see if we can find someone who could do the review more efficiently...

@philip-paul-mueller general comment before the review: please remove the unrelated (NaN) changes from the PR.

@tbennun Sorry that thing got somehow mixed up.

Thanks for your work and especially for correcting my typos.
I have addressed most of your suggestions, but for some I am unsure (see comment).
Regarding your comments about my splitting of _construct_args(), I would be fine to revert this if you would prefer that.
When I did the split (and all further modifications) I constantly checked its runtime and according to that it is now faster.
One reason is, that it spend less time with type checking since the results are cached.
@tbennun

Hello Tal,
thanks for your patience with me, I have addressed all your comments.
Except one I have removed all .append() loops, the one I kept had the advantages of fusing two loops.
I also did the benchmarking you requested, see below, which show that the new code is at least as fast as the original one and reverting would hurt performance.
I which you a happy new year.
Best, Philip


The MyConfigOptions class by itself doesn’t bind.

In https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration/options?view=aspnetcore-5.0#options-validation
The phrase “The following class binds to the "MyConfig" configuration section and applies a couple of DataAnnotations rules:”
seems incorrect.
The MyConfigOptions class by itself doesn’t bind.
Startup. ConfigureServices does the binding.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed39cb0e-aa85-8bba-ffb4-859b56a60723
Version Independent ID: dc7e3449-650b-d117-5eac-69e5ccb250cb
Content: Options pattern in ASP.NET Core
Content Source: aspnetcore/fundamentals/configuration/options.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Good point @MNF


Add support for Antigen

Add this github repo as an antigen bundle.

Seems to work fine as a bundle.


Add Alpine Linux 3.17

Add support for Alpine Linux 3.17 and marks it as the latest.

Fixed, sorry about that.

All good, I got to try the bot as well now 😄


Feature/post moderation without dashboard

What does this pull request aim to achieve? 💯
post-moderation tools for production release without dashboard functinoality.
Please be concise and link any related issue(s):

[x] I have checked that no one else is working on similar changes.
[x] I have read the latest README and understand the development workflow.
[x] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix, where <branch_name> briefly describes the issue(s) resolved and is prefixed with the issue number(s) (e.g. 1127-1130-update-git-branching-model). The branch is created in a cloned version of this repo, not a forked repo.
[x] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[x] There are no merge conflicts.
[x] There are no console warnings and errors.
[x] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".
[x] The title describes the issue(s) being addressed using format: <issue_numbers> - <brief_issue_description> (e.g. #1127/#1130 - Update Git Branching Model)

there is one empty file client/src/components/CreatePost/PostAs.js

there is one empty file client/src/components/CreatePost/PostAs.js

we are not adding that file, we are actually removing it :sweat_smile:

I know it's unlikely... But I found a way to see and comment on a post held for review.
I tried hiding the overlay with the inspector from the help board, all interactions seemed blocked, but I was still able to get the link to the post.
I went to the single post page with the link, hid overlay, left comments.


Automatically resolve schema location for downloadApolloSchema Task

The downloadApolloSchema task is great but it requires us to publish the schema location manually.
If it can figure out the path from the configuration, that would be awesome.

If there are no custom service defined, the path would be completely optional.
If there are one or more services present, --service parameter can be passed.

Should the default behaviour be to put schema.json at the root of the sourceSet?
// If no service is present:
src/main/graphql/schema.json
// If a service is present:
src/main/graphql/service/schema.json

I'm asking because most of the times, files are in a subdirectory that defines the package:
src/main/graphql/com/example/schema.json

The schema package is used for types and fragments and there is no way to guess it from the configuration.

That's only true for new projects where the schema does not even exist. In such a case, picking a logical default makes sense.
I believe in the majority of the cases, users already have it and wants to update. In that case, our configuration knows the location of the schemas files perfectly. That includes all cases whether if the user defines a service or custom location of schema etc.

I see. Yep, for updating the schema, we can just lookup the existing location. I'll look into this.


idea - derive boolArray from bitArray class

Would give same interface, specific optimizations still possible?
Check nybbleArray too.

No real need for this. => close

No real need for this. => close


Helm 3.0.0 beta 4 - can't upgrade charts (existing resource conflict)

Hi, Bitnami developer here. When trying to upgrade a chart to a newer version using helm v3 beta 4, it fails due to an existing resource conflict. This never happened neither with helm v2 nor with the previous beta versions of helm v3. It seems to be related with commit https://github.com/helm/helm/commit/36f3a4b326f1df1ad50cfa19c47808a7e42bd294.
I would like to know if this is a bug or the expected behaviour, and in that case try to understand why this is happening. This is happening to all our charts.
Steps to reproduce:

Add the stable repository

helm repo add stable https://kubernetes-charts.storage.googleapis.com

Grab and install an older version of a chart (e.g. dokuwiki)

helm fetch --untar --untardir . stable/dokuwiki --version 5.0.0
helm install doku ./dokuwiki --namespace dokuwiki

Try to upgrade to the latest version

helm upgrade doku stable/dokuwiki --namespace dokuwiki
Error: UPGRADE FAILED: rendered manifests contain a new resource that already exists. Unable to continue with update: existing resource conflict: kind: Deployment, namespace: amoreno, name: doku-dokuwiki

Note that running the above command with helm v3 beta 3 instead works correctly.
Output of helm version:
version.BuildInfo{Version:"v3.0.0-beta.4", GitCommit:"7ffc879f137bd3a69eea53349b01f05e3d1d2385", GitTreeState:"dirty", GoVersion:"go1.13.1"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.3", GitCommit:"5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0", GitTreeState:"clean", BuildDate:"2019-06-06T01:44:30Z", GoVersion:"go1.12.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"14+", GitVersion:"v1.14.6-gke.2", GitCommit:"c9de33b5439df6e206d7ba646787c6ace92d737b", GitTreeState:"clean", BuildDate:"2019-09-06T18:30:33Z", GoVersion:"go1.12.9b4", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
GKE

@alemorcuq Thanks for reporting the issue! It looks like you have done some research, if you are interested to work on this and raise a PR, please mention here and go ahead or we will check it out and post our findings 😄 If I have time I'll just dig a bit to understand the issue better, and see if I can help with the root cause

@alemorcuq With the steps you provided, I'm not able to reproduce the issue. My guess from the logs and what you are trying to do is - looks like there's an existing Deployment named doku-dokuwiki in namespace amoreno somehow - not created/managed using helm. Hence the error

Same issue here. Cannot understand why only some of my charts are affected.

 But can you help us reproduce the issue?

Actually I don't know how to reproduce it properly. But when it appears it stays. Personally I have an example when I created my chart and have these dependencies in Chart.yaml:
- name: patroni
  alias: patroni-managed
  repository: https://kubernetes-charts-incubator.storage.googleapis.com/
  version: 0.14.0
- name: redis-ha
  alias: redis-ha-managed
  version: 3.9.2
  repository: https://kubernetes-charts.storage.googleapis.com/
- name: minio
  alias: minio-managed
  version: 2.5.16
  repository: https://kubernetes-charts.storage.googleapis.com/
- name: sentry
  version: 3.1.0
  repository: https://kubernetes-charts.storage.googleapis.com/

I believe it happens rather because Helm is trying to create resources instead of updating them or it just doesn't treat these resources create by himself previousely.

Actually I've noticed yet one strange thing, that my release secret's data.release is very big (42k symbols) and linux base64 tells "Wrong input". Could it be that decoding from base64 could be the problem? Btw could you explain to me what should I see after the decoding from base64 as I've managed to decode and see some gibberish?

I've debugged my helm a little bit:
	existingResources := make(map[string]bool)

	fmt.Println("CURRENT")
	for _, r := range current {
		fmt.Println(objectKey(r))
		existingResources[objectKey(r)] = true
	}

	var toBeCreated kube.ResourceList
	fmt.Println("TOBECREATED")
	for _, r := range target {
		if !existingResources[objectKey(r)] {
			fmt.Println(objectKey(r))
			toBeCreated = append(toBeCreated, r)
		}
	}

	if err := existingResourceConflict(toBeCreated); err != nil {
		return nil, errors.Wrap(err, "rendered manifests contain a new resource that already exists. Unable to continue with update")
	}

And got:
CURRENT
v1/Secret/production-app-sentry-minio-managed
v1/Secret/production-app-sentry-patroni-managed
v1/Secret/production-app-sentry-postgresql-managed
v1/Secret/production-app-sentry-redis-managed
v1/Secret/production-app-sentry-enapter-registry
v1/Secret/production-app-sentry-postgres-backup-env
v1/ConfigMap/production-app-sentry-minio-managed
v1/ConfigMap/production-app-sentry-redis-managed
v1/ConfigMap/production-app-sentry-redis-managed-health
v1/PersistentVolumeClaim/production-app-sentry-minio-ceph
v1/PersistentVolumeClaim/production-app-sentry-postgres-ceph
v1/ServiceAccount/production-app-sentry-minio-managed
v1/ServiceAccount/production-app-sentry-patroni-managed
rbac.authorization.k8s.io/v1beta1/Role/production-app-sentry-patroni-managed
rbac.authorization.k8s.io/v1beta1/RoleBinding/production-app-sentry-patroni-managed
v1/Service/production-app-sentry-minio-managed
v1/Service/production-app-sentry-patroni-managed
v1/Service/production-app-sentry-postgresql-managed-headless
v1/Service/production-app-sentry-postgresql-managed
v1/Service/production-app-sentry-redis-managed-headless
v1/Service/production-app-sentry-redis-managed-master
apps/v1/Deployment/production-app-sentry-minio-managed
apps/v1beta1/StatefulSet/production-app-sentry-patroni-managed
apps/v1/StatefulSet/production-app-sentry-postgresql-managed
apps/v1/StatefulSet/production-app-sentry-redis-managed-master
batch/v1beta1/CronJob/production-app-sentry-postgres-backup
v1/Endpoints/production-app-sentry-patroni-managed

TOBECREATED
v1/Secret/production-app-sentry-postgresql
v1/Secret/production-app-sentry-redis-ha-managed
v1/Secret/production-app-sentry-redis
v1/Secret/production-app-sentry
v1/ConfigMap/production-app-sentry-redis-ha-managed-configmap
v1/ConfigMap/production-app-sentry-redis
v1/ConfigMap/production-app-sentry-redis-health
v1/ConfigMap/production-app-sentry
v1/ServiceAccount/production-app-sentry-redis-ha-managed
v1/ServiceAccount/production-app-sentry-redis-ha-managed-haproxy
rbac.authorization.k8s.io/v1/Role/production-app-sentry-redis-ha-managed
rbac.authorization.k8s.io/v1/RoleBinding/production-app-sentry-redis-ha-managed
v1/Service/production-app-sentry-postgresql-headless
v1/Service/production-app-sentry-postgresql
v1/Service/production-app-sentry-redis-ha-managed-announce-2
v1/Service/production-app-sentry-redis-ha-managed-announce-1
v1/Service/production-app-sentry-redis-ha-managed-announce-0
v1/Service/production-app-sentry-redis-ha-managed
v1/Service/production-app-sentry-redis-ha-managed-haproxy
v1/Service/production-app-sentry-redis-headless
v1/Service/production-app-sentry-redis-master
v1/Service/production-app-sentry-redis-slave
v1/Service/production-app-sentry
apps/v1/Deployment/production-app-sentry-redis-ha-managed-haproxy
extensions/v1beta1/Deployment/production-app-sentry-cron
extensions/v1beta1/Deployment/production-app-sentry-web
extensions/v1beta1/Deployment/production-app-sentry-worker
apps/v1/StatefulSet/production-app-sentry-postgresql
apps/v1/StatefulSet/production-app-sentry-redis-ha-managed-server
apps/v1/StatefulSet/production-app-sentry-redis-master
apps/v1/StatefulSet/production-app-sentry-redis-slave
extensions/v1beta1/Ingress/production-app-sentry

According to the error in this comment
I feel that there's an existing secret. Could you check it out?
kind: Secret, namespace: production-app-sentry, name: production-app-sentry-redis-ha-managed

I have to check the code, but another venue for errors, is the apiVersion, and looks like you are already checking that out by printing the current and tobecreated, where tobecreated tells what resources are to be created. And issues can occur if existing resources (manifests) have different apiVersion for the same resource. Just for example extensions/v1beta1/Deployment could be the installed one, from the old chart and apps/v1/Deployment could be the new one from the new chart. This is just a hunch.
But from your error, I don't think anything of that sort happened for the Secret resource.

This is the output with the same debugging than @Antiarchitect for my case, @karuppiah7890 :
❯ ./helm-3.0.0-beta.5/bin/helm upgrade doku stable/dokuwiki --namespace doku-amoreno
CURRENT
v1/Secret/doku-dokuwiki
v1/PersistentVolumeClaim/doku-dokuwiki-dokuwiki
v1/Service/doku-dokuwiki
extensions/v1beta1/Deployment/doku-dokuwiki
TOBECREATED
apps/v1/Deployment/doku-dokuwiki
Error: UPGRADE FAILED: rendered manifests contain a new resource that already exists. Unable to continue with update: existing resource conflict: kind: Deployment, namespace: doku-amoreno, name: doku-dokuwiki

I do have the doku-dokuwiki deployment, which was created installing a previous version of the chart with Helm.
❯ k get all -n doku-amoreno --show-labels
NAME                                READY   STATUS    RESTARTS   AGE     LABELS
pod/doku-dokuwiki-5c478cd57-x8brz   1/1     Running   0          8m44s   app=dokuwiki,chart=dokuwiki-5.0.0,pod-template-hash=5c478cd57,release=doku

NAME                            READY   UP-TO-DATE   AVAILABLE   AGE     LABELS
deployment.apps/doku-dokuwiki   1/1     1            1           8m44s   app=dokuwiki,chart=dokuwiki-5.0.0,heritage=Helm,release=doku

NAME                                      DESIRED   CURRENT   READY   AGE     LABELS
replicaset.apps/doku-dokuwiki-5c478cd57   1         1         1       8m44s   app=dokuwiki,chart=dokuwiki-5.0.0,pod-template-hash=5c478cd57,release=doku

Yes, there is the change in the apiVersion (since Kubernetes dropped support of some old API versions), but there wasn't any issue upgrading until beta 4.

Seems this check rely on the keys that include full API versions that doesn't match in our case;

Still on beta.3 all was fine because that check just not exist

Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Changing the APIVersion is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new APIVersion in-place.
A larger explanation was provided in https://github.com/helm/helm/issues/6583. The tl;dr is that since this is considered a breaking API change, you must delete the Deployment from the cluster before you can upgrade.

I'll also come up with a strategy for the upgrade and put it as a blog I guess or as a doc if that's acceptable

Yes. Thank you very much, @bacongobbler, it's all clear now.
Also, thank you @Antiarchitect and @karuppiah7890.

@bacongobbler @karuppiah7890 It seems like the current set of things is incorrect, because I have for example secret v1/Secret/production-app-sentry-redis-ha-managed and it is actually used by redis-ha and created by helm but it counts as not present. From the other side helm counts v1/Secret/production-app-sentry-redis-managed as present in the release, but it was deleted logn time ago and I do not use it anymore. Is there a way to edit release manually. Because constant deletion of resources via kubectl delete does not help.

@bacongobbler Have a look at this commit - it's very representative: https://github.com/helm/charts/commit/26c75727aad71de2165a41827e60be9c227b828d
We have STS with the data we cannot afford to delete. And new chart version upgrades API version of STS. What should we do?

FYI, seems highly related to https://github.com/helm/helm/issues/2947
And I am facing this issue without any api change.

Confirm. In some cases, it appears without any API changes.

@bacongobbler We should reopen this case.
I am getting hit a lot by this issue.
And it's only on secrets.
Error: UPGRADE FAILED: rendered manifests contain a new resource that already exists. Unable to continue with update: existing resource conflict: kind: Secret, namespace: istio-system, name: kintossl-hk

And I can confirm using helm get all my-release than the kintossl-hk secret is in the release.

@bacongobbler having the same issue with helm Version:"v3.0.0", gitCommit:"e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6" and a ConfigMap

I am also getting this trying to use helm 3 to update a service that was previously installed using helm 2
 Error: rendered manifests contain a resource that already exists. Unable to continue with install: existing resource conflict: kind: Service, namespace: ingress-basic, name: front

Yep, just hit this one as will, on a secret. I'm using version 3.0.0.

@bacongobbler Seems like problem stays. Should this issue be reopened?

Is there a work around to 'ignore' existing resources?  or something?   Really hoping to be able to upgrade with out blowing everything away and starting all over.

Ran into the same issue when upgrading from version 2 to 3. Using the 2to3 migration plugin.

Same issue v3.0.0. Please re-open!

same issue in v3.0.0. Please re-open this issue. Tried
--cleanup-on-fail, --atomic, --force almost everything to mitigate this issue, obviously helm is not able to detect first hand that the resource was already created by itself.
Not able to understand how this issue can be re-created.

we are observing this issue on 3.0.0 with persistent volume claims, please reopen

Please follow up with https://github.com/helm/helm/issues/6850 for issues related to resource creation. The issue raised by @alemorcuq results in the same error, but it is a different diagnosis than the issues being raised here. Thanks

one quick fix would be to essentially allow helm to ignore the conflicting resource and go ahead with the release upgrade. I happened to make some changes to the src to make this happen
https://github.com/RiflerRick/helm/commit/1ee55a3c69535becb3c2854573e60c07121f15fb
Clone the repo https://github.com/RiflerRick/helm/tree/debug-v3.0.0 and simply run make build. That will create a binary in ./bin. You can use that binary.

one quick fix would be to essentially allow helm to ignore the conflicting resource and go ahead with the release upgrade. I happened to make some changes to the src to make this happen
RiflerRick@1ee55a3
Clone the repo https://github.com/RiflerRick/helm/tree/debug-v3.0.0 and simply run make build. That will create a binary in ./bin. You can use that binary.

the bulk of the code is in https://github.com/helm/helm/blob/e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6/pkg/action/upgrade.go#L192
Here is how helm is creating target and current resource lists:

current is coming from the current release
target is coming from the manifest we provided

The possible cause

it then creates an existingResources array containing each element of current corresponding to that elements GVK(group, version, kind)
next it creates a toBeCreated array from target such that elements that do not match the GVK of the existingResources are added to toBeCreated
It then queries kubernetes to find out any resource among toBeCreated that already exists. If so then the conflict occurs. In essence any resource whose GVK changes after helm had already created the resource will face this conflict
If there are no conflicts, it executes Update(...) on the target
Looks like GVK comes directly from kubernetes and it should never change in general unless someone tampers the resource group, version or kind.
https://github.com/helm/helm/blob/e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6/pkg/action/upgrade.go#L192 is responsible for actually performing the upgrade
The most probable cause of the issue is a possible tampering of the resources without using helm. https://github.com/helm/helm/blob/e29ce2a54e96cd02ccfce88bee4f58bb6e2a28b6/pkg/action/upgrade.go#L416 This function is responsible for checking the GVK equivalent for helm to compare resources. If at any point, this string changes between the existing and current resources, the conflict issue would occur
The conflict error is actually a failsafe from the side of helm. It should in theory only occur when resources that are created outside of helm are being created later with helm. In other scenarios this error should not come which is why there is an github issue on this:  https://github.com/helm/helm/issues/6646
The fact that the issue is arising suggests that either GVK from kubernetes is being returned incorrectly for an existing resource or that helm is somehow corrupting its secret while trying to write to it resulting to its false notion that a particular resource does not exist.

Possible Mitigation
One attempt at mitigation was to ignore the conflicting resource, essentially deleting the resource from the current and target arrays. That way helm does not modify the resource at all. The following commit essnetially does that
https://github.com/RiflerRick/helm/commit/1ee55a3c69535becb3c2854573e60c07121f15fb
The commit above might result in inconsistent states in the helm secrets, that is something yet to be tested fully. If this is indeed the way to go about then a possible resolution might involve having a flag something like --ignore-conflicts that will execute portions of the code referenced by that commit

I also believe, that possible reason could be Ctrl+C on helm deploy while using --atomic and trying to deploy after. Could it be Helm does not mark objects created by it (or does not form the release) until some phase and objects created before Ctrl+C are not recognized by Helm afterward?

I cannot update deployments to api v1 without removing them manually... Can you please fix it?

I am locking this thread for the time being. As explained above, this thread and #6850 are separate issues. Please follow up in that thread. I want to be respectful of others who originally raised this issue, which has since been resolved. Thanks.


Meaning of Dept

Is it meant to give an indication of how much debt has accumulated in the codebase and the amount of time it might take to fix all of the issues we have found?
I always wondered if it is supposed to be called Debt and was just a typo or if it carries a meaning that is not obvious to me.

Thank you for asking this. I'm also puzzled by this class.

:D yes it is a typo! A debt value was needed for sonar so I introduced one for detekt too, maybe for the complexity report later when there are hotspot reports (packages/files with the most smells -> developers can better estimate new features when they know which code part is hard to change) and other metrics ^^
PS: this one is embarrassing, like the poll pool thing :D


remove Typelevel Scala from projects list

it's dead/archived

There are actually a lot of archived projects.  I marked them all in the front matter with archive, but we're not doing anything special to render them.  I wasn't sure if we wanted to keep them for historical interest or just banish them.

I wasn't sure if we wanted to keep them for historical interest

it's not worth making life more difficult for newcomers and casual users, IMO

In that case, there are several more.

In that case, there are several more

#390


Expose verifier key's digest with a trait

@microsoft-github-policy-service agree company="Microsoft"


Retrieve Value from custom field key/value List

Hi,
I tried to create a computed custom field with the value of another key/value type custom field. I can retrieve the key but I don't know how to get the value.
Please can you help me?

Same problem here :)

I'm sorry, but I'm really can't reproduce this. The formula works fine.
To get root issue custom field try this root.try(:custom_field_value, 21).try(:name) or  root.try(:custom_field_value, 21).try(:id)


Cannot build on windows

Bug Report

Version
Master

Platform
64-bit Windows 10
Description
Cannot build on windows.
From a fresh checkout tried cargo run --bin helloworld-client
Got:

error: failed to run custom build command for openssl-sys v0.9.50
Caused by:
process didn't exit successfully: C:\projects\test\tonic\target\debug\build\openssl-sys-0c79ae8c49ce2a76\build-script-main (exit code: 101)
--- stdout
cargo:rustc-cfg=const_fn
cargo:rerun-if-env-changed=X86_64_PC_WINDOWS_MSVC_OPENSSL_LIB_DIR
X86_64_PC_WINDOWS_MSVC_OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=OPENSSL_LIB_DIR
OPENSSL_LIB_DIR unset
cargo:rerun-if-env-changed=X86_64_PC_WINDOWS_MSVC_OPENSSL_INCLUDE_DIR
X86_64_PC_WINDOWS_MSVC_OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=OPENSSL_INCLUDE_DIR
OPENSSL_INCLUDE_DIR unset
cargo:rerun-if-env-changed=X86_64_PC_WINDOWS_MSVC_OPENSSL_DIR
X86_64_PC_WINDOWS_MSVC_OPENSSL_DIR unset
cargo:rerun-if-env-changed=OPENSSL_DIR
OPENSSL_DIR unset
note: vcpkg did not find openssl as libcrypto and libssl: Could not find Vcpkg tree: No vcpkg.user.targets found. Set the VCPKG_ROOT environment variable or run 'vcpkg integrate install'
note: vcpkg did not find openssl as ssleay32 and libeay32: Could not find Vcpkg
tree: No vcpkg.user.targets found. Set the VCPKG_ROOT environment variable or run 'vcpkg integrate install'
--- stderr
thread 'main' panicked at '
Could not find directory of OpenSSL installation, and this -sys crate cannot
proceed without this knowledge. If OpenSSL is installed and this crate had
trouble finding it,  you can set the OPENSSL_DIR environment variable for the
compilation process.
Make sure you also have the development packages of openssl installed.
For example, libssl-dev on Ubuntu or openssl-devel on Fedora.
If you're in a situation where you think the directory should be found
automatically, please open a bug at https://github.com/sfackler/rust-openssl
and include information about your system as well as this message.
$HOST = x86_64-pc-windows-msvc
$TARGET = x86_64-pc-windows-msvc
openssl-sys = 0.9.50
It looks like you're compiling for MSVC but we couldn't detect an OpenSSL
installation. If there isn't one installed then you can try the rust-openssl
README for more information about how to download precompiled binaries of
OpenSSL:
https://github.com/sfackler/rust-openssl#windows
', C:\Users\jkolb.cargo\registry\src\github.com-1ecc6299db9ec823\openssl-sys-0.9.50\build\find_normal.rs:150:5
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace.
warning: build failed, waiting for other jobs to finish...
error: build failed

@kjeremy hi! Looks like its unable to find openssl. This is because the interop tests need this. I think besides installing openssl you may want to just comment out the tonic-interop entry in the Cargo.toml at the root of the repo.

@LucioFranco thanks. In order to install openssl I had to install vcpkg and then follow the instructions from this comment. That allowed me to cargo build and cargo test from cmd.exe (though building from git bash fails).
Note that when running (no firewall on the machine) I get:

c:\projects\test\tonic>cargo run --bin helloworld-client
Finished dev [unoptimized + debuginfo] target(s) in 0.38s
Running target\debug\helloworld-client.exe
Error: Status { code: Unknown, message: "Client: buffered service failed: error trying to connect: No connection could be made because the target machine actively refused it. (os error 10061)" }
error: process didn't exit successfully: target\debug\helloworld-client.exe (exit code: 1)

and

c:\projects\test\tonic>cargo run --bin helloworld-server
Finished dev [unoptimized + debuginfo] target(s) in 0.36s
Running target\debug\helloworld-server.exe
Error: Error(Server, Error(Accept, Error(Listen, Os { code: 10013, kind: PermissionDenied, message: "An attempt was made to access a socket in a way forbidden by its access permissions." })))
error: process didn't exit successfully: target\debug\helloworld-server.exe (exit code: 1)

@carllerche have you seen this type of error on TcpListener::accept on windows?

Cannot reproduce on 1903, @kjeremy can you rule out the port (50051) being used by another program?

That port is not being used.
I went into my network adapters and disabled the "Npcap Loopback Adapter" from Wireshark and it started working. I re-enabled the adapter and it STILL works so I'm not really sure what the problem was.

@kjeremy interesting. Are you still not able to reproduce?

Try this:
cd C:\dev\msys64\home\davidm
git clone https://github.com/hyperium/tonic

FIRST RUN the vc++ environment:
"C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Auxiliary\Build\vcvars64.bat"
cd C:\dev\msys64\home\davidm\vcpkg
powershell
.\bootstrap-vcpkg.bat
.\vcpkg install openssl:x64-windows

set VCPKG_ROOT=c:\dev\msys64\home\davidm\vcpkg
set VCPKGRS_DYNAMIC=1
cd C:\dev\msys64\home\davidm\tonic\
cargo build --release

PS C:\dev\msys64\home\davidm\vcpkg> .\vcpkg owns openssl
openssl-windows:x64-windows: x64-windows/tools/openssl/LIBEAY32.dll
openssl-windows:x64-windows: x64-windows/tools/openssl/SSLEAY32.dll
openssl-windows:x64-windows: x64-windows/tools/openssl/openssl.exe

PS C:\dev\msys64\home\davidm\tonic> [Environment]::SetEnvironmentVariable("PATH", "C:\dev\msys64\home\davidm\vcpkg\installed\x64-windows\tools\openssl;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64;C:\Program File
s (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\CommonExtensions\Microsoft\TestWindow;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Roslyn;C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64;C:\Program Files (x86)\Win
dows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\\MSBuild\15.0\bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studi
o\2017\BuildTools\Common7\Tools\;C:\ProgramData\Boxstarter;C:\VulkanSDK\<IP_ADDRESS>\Bin;C:\Program Files\ImageMagick-6.9.3-Q16;C:\Program Files (x86)\Common Files\Oracle\Java\javapath;c:\Program Files (x86)\Intel\iCLS Client\;c:\Program Files\Intel\iCLS Client\;C:\WINDOWS\
system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;c:\Program Files (x86)\Hewlett-Packard\HP Performance Advisor;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files (x86)\Intel\Intel(R) Management Engine
 Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\IPT;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\IPT;C:\WINDOWS\System32\OpenSSH\;C:\Program Files (x86)\QuickTime\QTSystem\;C:\Program Files\Symantec.cloud\PlatformAgent\;
C:\ProgramData\chocolatey\bin;C:\Go\bin;C:\Users\davidm\.cargo\bin;C:\Users\davidm\AppData\Local\Microsoft\WindowsApps;C:\Users\davidm\go\bin;C:\Git;C:\Git\bin;C:\pipeline_virtenv\Scripts;L:\3D\Maya\Maya2015\scriptLib\bin;C:\ffmpeg;C:\radare2;C:\MSVsCode\bin;C:\Users\dav
idm\go\bin;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\Ninja", "Process")

PS C:\dev\msys64\home\davidm\tonic> $Env:Path
C:\dev\msys64\home\davidm\vcpkg\installed\x64-windows\tools\openssl;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\CommonExtensions\Micros
oft\TestWindow;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Roslyn;C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64;C:\Program Files (x86)\Windows Kits\10\bin\x64;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools
\\MSBuild\15.0\bin;C:\Windows\Microsoft.NET\Framework64\v4.0.30319;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\Tools\;C:\ProgramData\Boxstarter;C:\VulkanSDK\<IP_ADDRESS>\B
in;C:\Program Files\ImageMagick-6.9.3-Q16;C:\Program Files (x86)\Common Files\Oracle\Java\javapath;c:\Program Files (x86)\Intel\iCLS Client\;c:\Program Files\Intel\iCLS Client\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\
v1.0\;c:\Program Files (x86)\Hewlett-Packard\HP Performance Advisor;C:\Program Files\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files (x86)\Intel\Intel(R) Management Engine Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine Components\IPT;C:
\Program Files (x86)\Intel\Intel(R) Management Engine Components\IPT;C:\WINDOWS\System32\OpenSSH\;C:\Program Files (x86)\QuickTime\QTSystem\;C:\Program Files\Symantec.cloud\PlatformAgent\;C:\ProgramData\chocolatey\bin;C:\Go\bin;C:\Users\davidm\.cargo\bin;C:\Users\davidm\
AppData\Local\Microsoft\WindowsApps;C:\Users\davidm\go\bin;C:\Git;C:\Git\bin;C:\pipeline_virtenv\Scripts;L:\3D\Maya\Maya2015\scriptLib\bin;C:\ffmpeg;C:\radare2;C:\MSVsCode\bin;C:\Users\davidm\go\bin;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\I
DE\CommonExtensions\Microsoft\CMake\CMake\bin;C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\Ninja

PS C:\dev\msys64\home\davidm\tonic> start .\target\release\tls-server.exe
PS C:\dev\msys64\home\davidm\tonic> start .\target\release\tls-client.exe

This continues to work for me today so I think I will close the issue.


Simplify and correct chef-client path determination in cron recipe

Stop using the find_chef_client helper to search for the chef-client binary and just use the node attribute that defaults to /opt/chef/bin/chef-client
Pass the correct binary attribute in the resource. This was causing the path to be set instead.
This should fix https://github.com/chef-cookbooks/chef-client/issues/714
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

Hi
@tas50 @Nirbhay1997
I have used the below scenario for node
vi /etc/crontab
then run below command

root chef-client
:wq
The node is bootstrapped completely and when I run chef-client manually, it fetches the data from server. But the crontab file is not working. it should work automatically. Please suggest how can solve this problem


Liuhuapiaoyuan main

Extends #65

@bracesproul
I can solve your problem, but I have found a new bug. It is that once a markdown marker appears, such as '# -  ###', it will cause the selection calculation to be incorrect.