[bug] content harvest error for 2 Nuxeo collections--each with supersized map index pages (OSError: [Errno 28] No space left on device / Failed to seek in the stream.)

These are both extremely large collections, with hundreds of pages in complex objects.
Collection 26771

Error seems to be on this record: uclaclark_fDA660W35S4v2_0268.tif
Nuxeo record: https://nuxeo.cdlib.org/nuxeo/nxdoc/default/fbc3fc9e-4b8e-4d26-8c29-f312b4b90251/view_documents
Run ID: manual__2024-04-25T02:33:38+00:00

Mapped task: 5
Gridview to the log: https://7a8067cb-3b99-477e-a883-7e311175a9b4.c3.us-west-2.airflow.amazonaws.com/dags/harvest_collection/grid?base_date=2024-04-25T02%3A33%3A38%2B00%3A00&dag_run_id=manual__2024-04-25T02%3A33%3A38%2B00%3A00&task_id=content_harvesting.content_harvest&tab=logs&map_index=5
Permalink to the error: https://7a8067cb-3b99-477e-a883-7e311175a9b4.c3.us-west-2.airflow.amazonaws.com/log?dag_id=harvest_collection&task_id=content_harvesting.content_harvest&execution_date=2024-04-25T02%3A33%3A38%2B00%3A00&map_index=5

Error log for 26771 uclaclark_fDA660W35S4v2_0268.tif
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/content_harvester/by_page.py", line 98, in <module>
    print_value.append(harvest_page_content(
                       ^^^^^^^^^^^^^^^^^^^^^
  File "/content_harvester/by_page.py", line 31, in harvest_page_content
    record_with_content = harvest_record_content(
                          ^^^^^^^^^^^^^^^^^^^^^^^
  File "/content_harvester/by_record.py", line 104, in harvest_record_content
    downloaded_md5 = download_content(request, http, thumbnail.tmp_filepath)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/content_harvester/by_record.py", line 203, in download_content
    f.write(block)
OSError: [Errno 28] No space left on device
/tmp/uclaclark_fDA660W35S4v2_0267.tif converted to /tmp/uclaclark_fDA660W35S4v2_0267.jp2
Mime-type 'image/tiff' was pre-checked and recognized as something we can try to convert.
--------------------------------
ERROR: make_jp2 command failed: ['/usr/bin/convert', '-quiet', '-format', '-jp2', '-define', 'jp2:rate=10', '/tmp/uclaclark_fDA660W35S4v2_0268.tif[0]', '/tmp/uclaclark_fDA660W35S4v2_0268.jp2']
returncode was: 1
output was:
convert: Failed to seek in the stream.
 `OpenJP2' @ error/jp2.c/JP2ErrorHandler/194.
convert: unable to encode image file `/tmp/uclaclark_fDA660W35S4v2_0268.jp2' @ error/jp2.c/WriteJP2Image/1141.
convert: unable to write file `/tmp/uclaclark_fDA660W35S4v2_0268.jp2' @ error/constitute.c/WriteImage/1353.
--------------------------------; 8388)
[2024-04-26, 04:48:03 UTC] {{local_task_job_runner.py:225}} INFO - Task exited with return code 1

Collection 27124

Error seems to be on this record: sim_181_000_012_0031.tif
Nuxeo record:
https://nuxeo.cdlib.org/nuxeo/nxdoc/default/78c4be3a-c5fc-45a0-90ef-9abdcc449479/view_documents
Run ID: manual__2024-04-24T17:18:21+00:00

Mapped task: 48
-Gridview to the log: https://7a8067cb-3b99-477e-a883-7e311175a9b4.c3.us-west-2.airflow.amazonaws.com/dags/harvest_collection/grid?base_date=2024-04-24T17%3A18%3A21%2B00%3A00&dag_run_id=manual__2024-04-24T17%3A18%3A21%2B00%3A00&task_id=content_harvesting.content_harvest&tab=mapped_tasks&map_index=48
Permalink to the error: https://7a8067cb-3b99-477e-a883-7e311175a9b4.c3.us-west-2.airflow.amazonaws.com/log?dag_id=harvest_collection&task_id=content_harvesting.content_harvest&execution_date=2024-04-25T02%3A33%3A38%2B00%3A00&map_index=5

Error log for 27124 sim_181_000_012_0031.tif
/tmp/sim_181_000_012_0030.tif converted to /tmp/sim_181_000_012_0030.jp2
Mime-type 'image/tiff' was pre-checked and recognized as something we can try to convert.
--------------------------------
ERROR: make_jp2 command failed: ['/usr/bin/convert', '-quiet', '-format', '-jp2', '-define', 'jp2:rate=10', '/tmp/sim_181_000_012_0031.tif[0]', '/tmp/sim_181_000_012_0031.jp2']
returncode was: 1
output was:
convert: Failed to seek in the stream.
 `OpenJP2' @ error/jp2.c/JP2ErrorHandler/194.
convert: unable to encode image file `/tmp/sim_181_000_012_0031.jp2' @ error/jp2.c/WriteJP2Image/1141.
convert: unable to write file `/tmp/sim_181_000_012_0031.jp2' @ error/constitute.c/WriteImage/1353.
--------------------------------
[2024-04-25, 07:13:17 UTC] {{taskinstance.py:1345}} INFO - Marking task as FAILED. dag_id=harvest_collection, task_id=content_harvesting.content_harvest, map_index=48, execution_date=20240424T171821, start_date=20240424T174602, end_date=20240425T071317
[2024-04-25, 07:13:17 UTC] {{logging_mixin.py:150}} INFO - Message sent to SNS with Message ID: 355885a2-5265-54a9-869d-db0656a8a647
[2024-04-25, 07:13:17 UTC] {{standard_task_runner.py:104}} ERROR - Failed to execute job 78597 for task content_harvesting.content_harvest (This task is not in success state - last 100 logs from Cloudwatch:
/tmp/sim_181_000_011_0050.tif converted to /tmp/sim_181_000_011_0050.jp2

27124 also has the "no space left" error
/tmp/sim_181_000_012_0003.tif converted to /tmp/sim_181_000_012_0003.jp2
Mime-type 'image/tiff' was pre-checked and recognized as something we can try to convert.
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/content_harvester/by_page.py", line 98, in <module>
    print_value.append(harvest_page_content(
                       ^^^^^^^^^^^^^^^^^^^^^
  File "/content_harvester/by_page.py", line 31, in harvest_page_content
    record_with_content = harvest_record_content(
                          ^^^^^^^^^^^^^^^^^^^^^^^
  File "/content_harvester/by_record.py", line 104, in harvest_record_content
    downloaded_md5 = download_content(request, http, thumbnail.tmp_filepath)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/content_harvester/by_record.py", line 203, in download_content
    f.write(block)
OSError: [Errno 28] No space left on device
/tmp/sim_181_000_012_0004.tif converted to /tmp/sim_181_000_012_0004.jp2

It looks like the No space left on device error is actually fine -- the machine recovers and the jp2 is written to S3.
The convert: Failed to seek in the stream. error is a problem though. There's something about the tif file that OpenJP2 doesn't like. Are these new tiffs, or are they on calisphere prod? Just wondering if our legacy conversion tool was able to handle them.

27124 is also on production:

Nuxeo: https://nuxeo.cdlib.org/nuxeo/nxdoc/default/89235286-24b6-4e78-9c52-ac435d769a9c/view_documents
on -test: https://calisphere-test.cdlib.org/item/ark:/86086/n21z4672/?order=30

I am able to run the jp2 conversion process successfully in a content harvester docker container running on my local machine, so it looks like the out of space error is actually the issue. We deleting the files in /tmp after each file is processed.
I think we need to use Fargate's ephemeral storage:
https://docs.aws.amazon.com/AmazonECS/latest/developerguide/fargate-task-storage.html
Looks like we would do this by configuring the docker container with tmp_dir and mount_tmp_dir: True:
https://airflow.apache.org/docs/apache-airflow-providers-docker/stable/_api/airflow/providers/docker/operators/docker/index.html

@christinklez This should be fixed now. You can try re-running the content harvester just for the failed mapped tasks.

Thanks @barbarahui! I think your fix is good! However, I re-ran both failed pages (at the same time) and after running for 12 hours and 8 minutes, they both seem to just stop running.
SIM: https://7a8067cb-3b99-477e-a883-7e311175a9b4.c3.us-west-2.airflow.amazonaws.com/dags/harvest_collection/grid?base_date=2024-04-24T17%3A18%3A21%2B00%3A00&dag_run_id=manual__2024-04-24T17%3A18%3A21%2B00%3A00&task_id=content_harvesting.content_harvest&map_index=48&tab=logs
Clark: https://7a8067cb-3b99-477e-a883-7e311175a9b4.c3.us-west-2.airflow.amazonaws.com/dags/harvest_collection/grid?base_date=2024-04-25T02%3A33%3A38%2B00%3A00&dag_run_id=manual__2024-04-25T02%3A33%3A38%2B00%3A00&task_id=content_harvesting.content_harvest&tab=logs&map_index=5
I can try running each of these individually overnight (and not at the same time) to see if that helps. Feel free to let me know if you have other ideas!

I don't think that re-running the content harvest for those pages is going to help. I'm guessing you'll run into the same error again once it hits the 12 hour mark.
Airflow is configured to keep pinging ECS for 24 hours, but something happens at 12 hours that causes the task to stop. Based on the messages at the very end of the logs, it looks like Airflow is trying to re-run the task, but can't because it's already running. And then it stops, either immediately (in the case of 26771) or soon after (in the case of 27124).

Thanks @barbarahui! I let 27124 run overnight on just that one task, and it finished! It did take 12h23m47s.
I'll try letting 26771's one task run solo as well.

I do think when running multiple harvests, the job is competing for Nuxeo resources.
For 27124, attempt number 3 stopped after this file:
/tmp/sim_190_000_007_0088.tif converted to /tmp/sim_190_000_007_0088.jp2-- so presumably, it took 12 hours to get here.
Attempt number 4 got through this file at around the 5 hour mark (and continues on to churn through the remaining files, of which there are many more).
Here's the [log to this mapped task 48](https://7a8067cb-3b99-477e-a883-7e311175a9b4.c3.us-west-2.airflow.amazonaws.com/dags/harvest_collection/grid?base_date=2024-04-24T17%3A18%3A21%2B00%3A00&dag_run_id=manual__2024-04-24T17%3A18%3A21%2B00%3A00&task_id=content_harvesting.content_harvest&tab=mapped_tasks&map_index=48), in case it is of interest!

Looks like it finished successfully this time!

Based on the errors in the logs, I still think the errors have something to with Airflow mismanaging lots of concurrent tasks (maybe specifically dynamic tasks?). Not sure what's going on there, and it concerns me because this is exactly what Airflow's job is supposed to be. We don't want to have to coordinate with other users of Airflow once other PAD services start using it. Anyway, we can run these big pages overnight on their own for now just to get it through, but I think we'll need to figure it out post-MVP.

Thanks so much, @barbarahui! Each of the Nuxeo super-sized mapped pages did complete, when run individually!
26771's page5 content harvest took 9h31m44s
27124's page48 content harvest took 12h23m27s.
Is it okay if we close this out for now, and open up a new issue if we run into this again (and if running a solo job doesn't help)?

Sounds good!


dropdown element is jumping on page load/reload

When I load the page, the dropdown element experiences a styling glitch. Presumably because the js loads after page loads. What can be done to avoid this and show the select dropdown as it should be on page load without the style glitch?

Presumably because the js loads after page loads.

Yeah, pretty much

What can be done to avoid this and show the select dropdown as it should be on page load without the style glitch?

Since the jump is caused by styling being applied by JS, you could apply matching CSS style to the inputs prior to JS load+execution.


Camera Intent Crash

Android applicaiton crash on kitkat. please fix it.

Hi @amjadislam ,
Can you please paste your stack trace?
Thanks

Hi @PavelFoujeu  and @nadhirfr
Can you please confirm if it fixed wit last beta release 2.4.1-beta or not?
Thanks


deploy django

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

In browser console, the deployed app throws:
Refused to apply style from 'https://derisen-django-test.azurewebsites.net/static/style.css' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.
Might be related to misaligned footer below:

In browser console, the deployed app throws:
Refused to apply style from 'https://derisen-django-test.azurewebsites.net/static/style.css' because its MIME type ('text/html') is not a supported stylesheet MIME type, and strict MIME checking is enabled.
Might be related to misaligned footer below:


Bug found

What is the current behavior?
If the current behavior is a bug, please provide the exact steps to reproduce.
What is the expected behavior?
Additional context
Add any other context about the problem here.

My bad!


Coli builder somehow causing rejected import error on endojs/ses

references:

https://github.com/figma/plugin-typings/issues/36
https://github.com/Agoric/agoric-sdk/issues/43#issuecomment-850914157
https://github.com/endojs/endo/tree/master/packages/ses

caused by   import(_import: HandyImport): this {

/// IMPORTANT NOTICE
/// 1. do not use token import in comment or as a function name (Upper case or _import is fine)
/// This is because in some secure environment, such as figma plugin platform, rejects it.
/// using import keyword as start of the line will throw error on runtime, but like this line, using it on second or later place will be fine.
/// so using keyword "import" in comment on the first place must be replaced with "_import"


Question: Computing what percentage one duration is of another

My specific use case requires using Moment to find what percentage one duration is of another.
e.g. 3 months being roughly 25% of one year.
Given 2 periods represented by 2 start and 2 end dates converted to durations, what is the best way to compute the percentage one is of the other?
This is what I'm doing currently:
const firstPeriodLength = moment.duration(firstEndDate.diff(firstStartDate));
const secondPeriodLength = moment.duration(secondEndDate.diff(secondStartDate));

// BigNumber.js is used for better accuracy.
const factor = new BigNumber(firstPeriodLength.as("milliseconds"))
	.dividedBy(secondPeriodLength.as("milliseconds"));

Excuse the use of Typescript here.
This seems to yield a usable result, but I'm concerned with the overall accuracy of such a method.
Is there a better way to do this? This seems pretty good, but I need it to be as accurate as I can get it.
If anyone could advise on the best way to achieve this, I'd be very grateful!
Thank you so much.

Hello,
What about:
const firstStartDate = moment('2019-03-17');
const secondStartDate = moment('2019-03-28');
const now = moment();
console.log((now - firstStartDate ) / (secondStartDate  - firstStartDate)); // 0.15

This magic is available thanks to valueOf().
PS: const is ES6, not TypeScript-specific.

Thanks for your response. You're correct, I had just copied and adapted that example straight from my Typescript source without checking whether it had type annotations or other Typescript specifics.
I'm trying to track down the source of what I think are some truncation errors in some very precise calculations, part of which requires working this out.
I tested this using moment(...).unix() to get the raw epoch values for the start and end values and using those to get the lengths directly, and got the same value. So I'm starting to think this is fairly accurate.


Round M2 dot product in Weyl decomposition

Summary
Differences in floating point precision between different systems and
environments was causing inconsistent decompositions for decompositions
with 0s in the unitary would have differing results because of very
subtle floating point precision errors in the results. For example one
system would return 0 for a value and another would return
-1.55582133e-19 (which is essentially 0). This would have compound
effects in later stages because the signs were different. This commit
attempts to fix cases like this by rounding to 13 decimal places to
prevent issues like this in the future.
Details and comments

In general I'm loth to add these kind of roundings because it usually indicates an underlying problem being papered over. At the very least when I come across code with round-to-epsilons in it, that indicates to me scars from previous battles with numeric bugs and makes me very reluctant to make changes in order to avoid reopening old wounds. To reduce such fears can we at least capture the problematic cases as a test instance and add a comment with a pointer at the lines with the rounding?
I've been playing around off and on with a couple other implementations for Weyl decomposition to eliminate the ugly randomization anyway, so with a test case I'll be able to check if any of them is able to solve address this issue without rounding.

In general I'm loth to add these kind of roundings because it usually indicates an underlying problem being papered over. At the very least when I come across code with round-to-epsilons in it, that indicates to me scars from previous battles with numeric bugs and makes me very reluctant to make changes in order to avoid reopening old wounds. To reduce such fears can we at least capture the problematic cases as a test instance and add a comment with a pointer at the lines with the rounding?
I've been playing around off and on with a couple other implementations for Weyl decomposition to eliminate the ugly randomization anyway, so with a test case I'll be able to check if any of them is able to solve address this issue without rounding.

Sure I'll add a test case for the example that prompted me to add this. I definitely know that pain of debugging numeric bugs. I spent way too much time digging through things here to figure out that it was the CX gate decomposition in the basis being subtly off of zero here for some envs that was causing different decompositions on different systems and not an issue with the random unitary being tested..

Not sure what the concern is here. Setting was is a floating point zero to exactly zero is fairly common. Especially if the sign is important later.

Agree that it's common. IMO it should be much less common and used as a last resort.
It increases the error of the routine (by in this case factor of around 1E6. If the results of that routine feed into other routines with similar epsilon tolerances then those will have to broaden their tolerances. In the worst case you feed the output of this routine into a downstream routine that also needs to round-to-epsilon and because of this needs to broaden its tolerances correspondingly.
A factor of 1E6 here, a factor of 1E6 there, pretty soon you're talking real money.


🚀 Feature: Filter on package last-updated date

Bug Report Checklist

[X] I have tried restarting my IDE and the issue persists.
[X] I have pulled the latest main branch of the repository.
[X] I have searched for related issues and found none that matched my issue.

Overview
My npx tidelift-me-up shows tslint-microsoft-contrib and tslint-to-eslint-config. tslint-microsoft-contrib is deprecated. Probably no need to display it here.
Additional Info
No response

Hmm, npm.io doesn't always show deprecated. I ran npm deprecate tslint-microsoft-contrib without publishing a new version but the API hasn't been updated to show it.
Anyway, I think a similarly fine approach would be to add a --since for when the package was last updated. Very (>2 year) old packages probably aren't things folks want to Tidelift by default.


NFC: Add clang-tidy config file

This makes sure that folks who use clang-tidy see consistent code analysis reports. This is especially helpful for those using IDEs with clang-tidy integration.
The config file is based on the LLVM .clang-tidy file: https://github.com/llvm/llvm-project/blob/main/.clang-tidy
This isn't meant to be the final edition of the config file, but this could be a starting point. We could add useful checks and remove noisy ones as we go.

@egorzhdan Would you mind also adding yourself as a code owner of the file?

Added myself as a code owner, thanks @AnthonyLatsis for the suggestion

@swift-ci please smoke test

@swift-ci please smoke test Linux

@swift-ci please smoke test Windows

@swift-ci please smoke test macOS

@swift-ci please smoke test macOS

@swift-ci Please smoke test MacOS platform

While we're at it, would folks be too opposed to adding include-what-you-use so that we stop getting smacked by a wet fish every rebranch?

@swift-ci please smoke test


New major version

feat(API): remove setFlash
BREAKING CHANGE:

req.session.setFlash was removed, if you were using this please comment on
GitHub

fixes #53
feat(API): expose ironSession (express), applySession, cookieName required
New features:

an Express/Connect middleware: import { ironSession } from "next-iron-session"
app.use(ironSession(options))
or router.get("/", ironSession(options), (req, res, next) => {});
import { applySession } from "next-iron-session":
await applySession(req, res, options);

Examples:

moved to examples/ folder
added an Express example

BREAKING CHANGE:

you need to import withIronSession as a named export:
before: import withIronSession from "next-iron-session"
after: import { withIronSession } from "next-iron-session"
cookieName option is now mandatory (#54)

fixes #54
fixes #9
fixes #41
feat(cookieName): enforce cookieName option
BREAKING CHANGE: cookieName is now mandatory, to avoid issues of shared
cookieNames in examples etc..
fixes #54

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@next dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


empty facets

empty facet logic, broken out of #332

in axis.js, do not extend the grid on empty slots
in facet.js, only render marks if the facet exists

image for the CHANGELOG


Given the configuration of the jupyter instance in the tutorial

Is your feature request related to a problem? Please describe.
When I ran this instance, because I didn't have enough configuration and I didn't know what kind of configuration I needed, I couldn't kill the DataLoader process
Describe the solution you'd like
I didn't find a solution because my config is low and I want to run through a demo locally as much as possible, but it's hard to work
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

@LReion why the tutorial doesn't run?

spleen_segmentation_3d

What's the output from print_config()?

My first guess is pytorch 2.0.1 doesn't work well with MONAI 1.1.0. We can either pip install monai-weekly to get the latest branch or downgrade pytorch to 1.13.

The conversion to python script may skip the installation of monai-weekly:

I may have solved this problem, the main reason does not seem to be a compatibility problem, the main problem is that the sliding_window_inference is used to calculate when verifying, and the image and label without cropping will be loaded in this process, but because this image without cropping<PHONE_NUMBER>) and label (512512*1) are large, it will cause the loader to use too many resources and cause the loader to crash, At the same time, the video memory will not be enough during verification


server: fix socialID type

typeof player.socialID doesn't return bigint, but number.
Typing mistake, or was it normally supposed to be a bigint?

Converted to issue


EditorConfig

Add support for .editorconfig files. See http://editorconfig.org/.

Here's some reference.
So in order to do this we have to think about indent-tabs-mode.  EditorConfig sets it magically, but certain language modes have their own indent-tabs-mode variables. (E.g. ruby-indent-tabs-mode)
We should discuss the best ways to deal with these variables.  For one, we should always make sure that smart-tabs-mode is turned on whenever indent-tabs-mode is turned on, which we can add as a hook to editorconfig-custom-hooks.

In rye/duff, I solved the problem regarding tabs variables by adding a hook, though if Smart Tabs is used, this won't matter because it should be turned on.
More apposite is my work on turning off smart-tabs-mode if indent-tabs-mode is set.  I think EditorConfig only sets indent-tabs-mode, but I'm not sure.

I disagree with respect to smart-tabs-mode: the user may be working on a project that does not use smart tabs.
I think hooks are the right approach for setting language-specific variables.

Actually we can use editorconfig-indentation-alist.

@cg505 there is no intelligent way to discern through EditorConfig whether the user wants smart tabs.  I suppose the only case we can really, truly handle is if the user wants to disable tabs. (See this.)

So basically this just needs to install it and then turn off smart-tabs-mode if indent-tabs-mode is nil, which will happen whenever a user loads a file and EditorConfig sets that variable.

Or, should we just always keep smart-tabs-mode active?  If indent-tabs-mode is not truthy, smart-tabs-mode doesn't seem to do anything.

Since EditorConfig has its own core built into the Emacs plugin, I don't think we should force the user to install EditorConfig's C core, perhaps just notify them that it's a thing.

RFC @cg505, let me know what you think of all of this.


docs: Add book 'Automate The Boring Stuff With Python'

Description: This book is both a great introduction into Python for beginners and also offers code examples to automate daily tasks and put the new knowledge into practice.
Link to the free book: Automate the boring stuff with Python
Link to the landing page: Automate the boring stuff

I didn't notice that Prettier had changed the spaces from 2 to 4 in my previous PR. Sorry about that! I changed it back to 2 spaces with my latest commit.

Great thank you! 🌮


Long and Short Token naming conventions

User Story
As a user and developer of MP, we need to determine how to name the short and long tokens and what symbol to be used for them.
Why Is this Needed?
Summary: This will determine how positions show up in a wallet.
Description
Type: Feature
Current Behavior
erc20 tokens names are generically called "Long Position Token" with symbol "LONG"
Expected Behavior
we create better naming mechanism in the future
Definition of Done

[ ] determing naming mechanism
[ ] figure out way to create those names, cannot be easily handed into constructor of MarketContract due to abi encoder not allowing nested arrays string[] (which is actually bytes[][]).
[ ] add needed tests.

I believe the naming convention we want to take it should somehow show which underlying asset it is trading against or else there might be confusions when trading the same tokens but in different markets.

Needs to be addressed before launch of minting platform


Generate new post/article.

Complete Beginner to SSG like astro. Wanted to know more about like How can we generate our own version of articles, posts in this type of portfolio.

This provides a good introduction to Astro: https://docs.astro.build/en/tutorial/0-introduction/

If you want to learn more about Astro and its feature, I recommend Astro's Docs and its blog tutorial.
If you want to generate new posts, you can integrate sort of git-based CMS.
Another option would be using VSCode and code-snippet to create boilerplate codes.
Hope this comment helps you in some way.
Closing this issue for now.
If you have any problems, feel free to open a new issue or start a discussion.
Thanks for your understanding.


[SPARK-38144][CORE] Remove unused spark.storage.safetyFraction config

What changes were proposed in this pull request?
This PR aims to remove the unused spark.storage.safetyFraction.
Why are the changes needed?
Apache Spark 3.0.0 deleted StaticMemoryManager and its spark.storage.safetyFraction usage via
SPARK-26539.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.

cc @srowen

Thank you, @srowen . Merged to master/3.2.

Thanks for cleaning this up @dongjoon-hyun !


pip install facepy install fails

When I run pip install facepy I see the following error:
Downloading/unpacking facepy==0.6.2
  Running setup.py egg_info for package facepy
    Traceback (most recent call last):
      File "<string>", line 14, in <module>
      File "/Users/MGstaff/Documents/inkjoy_workspace/branches/phase-2-dev/vEnv/build/facepy/setup.py", line 3, in <module>
        readme = open('README.rst').read()
    IOError: [Errno 2] No such file or directory: 'README.rst'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

Thanks for the heads-up, @vaskelas. 0f5c8d3a3ae9c52df3e5fa340018795a4b16b6eb should fix this issue.


Add #![feature(const_fn_union)] when needed

This crate currently fails to compile on the newest nightly when using the "const-fn" feature because unions in const fns now require a feature flag. This change adds the feature flag when using that feature.

bors try


fix links to anchors

(e.g. https://observablehq.com/framework/files#static-analysis)

Good find. We can do a simpler fix with scroll-padding-top instead of scroll-margin-top.

I guess this fix should be applied in the default styles rather than our custom stylesheet? But then we need to know whether the header is shown. Hmm. 🤔


Right Hand side of instanceof is not an object

Bug Report
Current Behavior
running the app the normal way via smee works fine but as soon as you want to interact with the octokit api it crashes and shows the error below in the terminal. Everything is set up the way the docs say but for some reason the octokit api does not work.
109 |
110 |   if (!secretOrPrivateKey && options.algorithm !== 'none') {
111 |     return failure(new Error('secretOrPrivateKey must have a value'));
112 |   }
113 |
114 |   if (secretOrPrivateKey != null && !(secretOrPrivateKey instanceof KeyObject)) {
                                         ^
TypeError: Right hand side of instanceof is not an object

// Your code here
module.exports = (app) => {
  	app.on('pull_request.opened', async (context) => {
		const prLink = context.payload.pull_request.html_url;
		const prNumber = context.payload.pull_request.number;
		const repoName = context.payload.repository.name;
		const createdAt = await parseDateStringToUTCString(
			context.payload.pull_request.created_at
		);

		const firstCommitOfCurrentPullRequestCreatedAt =
			await parseDateStringToUTCString(
				context.payload.pull_request.head.repo.created_at
			);

		const timeSpentCoding = await calculateTimeSpentCoding(
			firstCommitOfCurrentPullRequestCreatedAt,
			createdAt
		);
		// save all the data to the database
		await saveNewPullRequest({
			firstCommitOfCurrentPullRequestCreatedAt:
				firstCommitOfCurrentPullRequestCreatedAt,
			link: prLink,
			pullRequestCreatedAt: createdAt,
			pullRequestNumber: prNumber,
			repoName: repoName,
			timeSpentCoding: timeSpentCoding,
			pullRequestCoAuthors: getPrCoAuthors(
				context.payload.pull_request.requested_reviewers
			),
			pullRequestMainAuthor: context.payload.pull_request.user.login,
		});
		// write the comment inside the PR
		context.octokit.issues.createComment({
			owner: context.pullRequest().owner,
			repo: context.pullRequest().repo,
			issue_number: prNumber,
			body: `## Hey Skripty here!\nI am tracking the time it takes to review and merge this PR!\nThe first commit was created at: ${firstCommitOfCurrentPullRequestCreatedAt}\nThis PR was created at ${createdAt}\n${await formatTimeSpentCoding(
				timeSpentCoding
			)}`,
		});
	});
};

Expected behavior/code
A clear and concise description of what you expected to happen (or code).
It should not error with everything set up correctly.
Environment

Probot version(s): [e.g. v6.0.0]
Node/npm version: [e.g. Node 18.15.0/bun 1.0.0]
OS: [e.g. OSX latest]

Possible Solution

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

Just to confirm: You're definitely running this with Node.js and only using Bun as a package manager? If you run it with Bun, the bug is probably in Bun.

Just to confirm: You're definitely running this with Node.js and only using Bun as a package manager? If you run it with Bun, the bug is probably in Bun.

I also ran it on Node but the issue seems to persist. I am going to try it on my other machine also running node. It might be Bun or something related to bun or my environment.

update
I fixed the error by using an older version of npm (v16.x.x) apparently node deprecated some things on v20 and don't work correctly. Also bun runs on v18 which also has some things that are qwerky

I fixed the error by using an older version of node (v16.x.x) apparently node deprecated some things on v20 and don't work correctly. Also bun runs on v18 which also has some things that are qwerky

Then let's keep this open, it's still a bug then. I'll check on Bun and Node 18.

@AaronDewes  I also opened a new issue on the bun repo to maybe see if this can be fixed on their side too. But for now i do not mind running Probot on version 16.x.x using nvm

btw. Node 16 has EOL today


Could you help build windows pypi package with cuda9.0

Hello, Could you help build windows pypi package with below dependencies:

cuda9.0 and cudnn7.05
windows 10, x64
mxnet1.2

Thank you very much!

@yajiedesign

@PaulaQin Were you able to build the package?

@nswamy Could you please add label-
installation, windows


Fix npe when no host.json exist

Fix npe when no host.json exist

Codecov Report

Merging #789 into develop will increase coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop     #789      +/-   ##
===========================================
+ Coverage    33.15%   33.16%   +0.01%
===========================================
  Files           83       83
  Lines         3218     3217       -1
  Branches       487      488       +1
===========================================
  Hits          1067     1067
+ Misses        2071     2070       -1
  Partials        80       80

Impacted Files
Coverage Δ

...om/microsoft/azure/maven/function/PackageMojo.java
53.47% <0%> (+0.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6427d8...bc51696. Read the comment docs.


replace deprecated FontLoader.computeStringWidth

FontLoader.computeStringWidth is deprecated and even removed in recent versions of javafx/openjfx causing Pattypan not to build.

This should be squash merged.


CORS-3617: Promote Azure CAPI as the default Install method

Azure Techpreview job results

/retest-required

/retest-required

/retest-required

Techpreview Azure Infrastructure is passing at 97%
Looking through the 4 failures, only one of those appears to be a CAPI-based failure. The rest are Terraform.
That seems to be roughly comparable to default infrastructure provisioning which is at 97.6%
I don't suspect we're going to be able to get verify to pass because it looks like some operators are failing to come up reliably in TechPreview

As long as we understand why techpreview installs themselves are unreliable and there's open bugs for them, I think it's fine to override.  I agree infrastructure looks comparable between techpreview and non-techpreview.

/retest-required

/test verify

/test verify

/lgtm

/test verify
verify seems wedged, stuck in pending state

/test verify


Docker Logs HTTP Format is Ambiguous

docker logs (and by extension, docker service logs, which duplicates the docker logs api format) is ambiguous and cannot be reliably parsed by machines.
Specifically, there are two problems:
First, there is no delimiter for the end of log lines, so log lines that include newlines cannot be parsed. You can't tell when one log line ends and another begins. The stdcopy marshaling format sort of fixes this by including a message length, but there is no such message length for TTY logs, which are sent raw.
EDIT: the above might not be a problem, actually, I think I'm confusing control codes (inserting ^M, a literal enter key press) with newlines. Something is still weird with it, but I'm not sure what, and I think it's unrelated.
Second, details of a log allow for unbounded user-entered data, which means that you can confuse any parser of logs by putting things like spaces, commas, and equals signs in the key or value field of your details.
For example, consider the following. In the first example, we can split out the details by taking the second space  . The spaces in the environment variable in the second part make that log impossible to parse. When do the details end and the log message begins? A user might fight it intuitive but a computer can never know without the context of the program being logged.
I have an outstanding PR #31952 that works around this internally, so that swarmkit does not have to parse log messages from the docker format. However, as it is currently design, swarmkit embeds context of the node, service, and task of a log message as details to send over the wire, and then parses them out for a better user interface. We can't continue to provide that nice UI and support user details if we don't fix this problem.
$ docker run -d --log-opt env=asdf,jkl --name testdetails1 -e asdf=wombo -e jkl=combo flyinprogrammer/logtester
296aca12eff1836389c9d7ef4003d16fa13a302c597ce919680cd1b29628c22c

 $ docker logs --timestamps --details testdetails1
2017-03-20T22:41:37.438236633Z asdf=wombo,jkl=combo + exec app
2017-03-20T22:41:37.466396100Z asdf=wombo,jkl=combo 2017-03-20 22:41:37.46574108 +0000 UTC stderr msg: 1
2017-03-20T22:41:37.466479201Z asdf=wombo,jkl=combo 2017-03-20 22:41:37.46574108 +0000 UTC stdout msg: 1
2017-03-20T22:41:42.470094993Z asdf=wombo,jkl=combo 2017-03-20 22:41:42.469542351 +0000 UTC stdout msg: 2
2017-03-20T22:41:42.470306141Z asdf=wombo,jkl=combo 2017-03-20 22:41:42.469542351 +0000 UTC stderr msg: 2
2017-03-20T22:41:47.473416235Z asdf=wombo,jkl=combo 2017-03-20 22:41:47.473037886 +0000 UTC stderr msg: 3
2017-03-20T22:41:47.473535493Z asdf=wombo,jkl=combo 2017-03-20 22:41:47.473037886 +0000 UTC stdout msg: 3
2017-03-20T22:41:52.477177753Z asdf=wombo,jkl=combo 2017-03-20 22:41:52.476695927 +0000 UTC stdout msg: 4
2017-03-20T22:41:52.477305202Z asdf=wombo,jkl=combo 2017-03-20 22:41:52.476695927 +0000 UTC stderr msg: 4

$ docker run -d --log-opt env=asdf,jkl --name testdetails2 -e asdf="wombo combo" -e jkl="your logs broke" flyinprogrammer/logtester
e33776e91b8b6a46ab6c215922584b2c4836ccfc3238e02af323bdd127fa3414

$ docker logs --timestamps --details testdetails2
2017-03-20T22:43:40.085280619Z asdf=wombo combo,jkl=your logs broke + exec app
2017-03-20T22:43:40.087018949Z asdf=wombo combo,jkl=your logs broke 2017-03-20 22:43:40.086539819 +0000 UTC stdout msg: 1
2017-03-20T22:43:40.087171467Z asdf=wombo combo,jkl=your logs broke 2017-03-20 22:43:40.086539819 +0000 UTC stderr msg: 1
2017-03-20T22:43:45.090802840Z asdf=wombo combo,jkl=your logs broke 2017-03-20 22:43:45.090365361 +0000 UTC stderr msg: 2
2017-03-20T22:43:45.090883844Z asdf=wombo combo,jkl=your logs broke 2017-03-20 22:43:45.090365361 +0000 UTC stdout msg: 2
2017-03-20T22:43:50.094351612Z asdf=wombo combo,jkl=your logs broke 2017-03-20 22:43:50.093726656 +0000 UTC stdout msg: 3
2017-03-20T22:43:50.094567255Z asdf=wombo combo,jkl=your logs broke 2017-03-20 22:43:50.093726656 +0000 UTC stderr msg: 3

There are a couple of possible solutions for this. The first is a hack: do something like URL encode details in log messages when sending them over the wire so that things like spaces, commas, equals signs, and new lines cannot screw up log parsing, and then de-URL encode those things when we display things for the user on the CLI. This means we change the REST API somewhat (in a way that shouldn't affect any users, because nobody should be able to rely on the broken grammar that we're fixing) while leaving the CLI with identical behavior.
The second is to switch to a different log message format that is more structured and which has an unambiguous grammar. Some people (@aluzzardi among them) have suggested returning logs in some standard like Syslog format, which could be more easily parsed. I have also heard talk of maybe having, like, a content-type header send down a different, more structured format (protobuf or similar).
The third is to just, like, disallow spaces, commas, equals signs, and new lines in details. I don't think that's workable, though.
I'm not sure what the right answer is, but the wrong answer, both internally to the project and for our users, is to stay the course with what is essentially a broken API.
PS: I've accidentally turned myself into a low-key domain expert on certain parts of logs over the past couple of months, which means I've probably got a bit of an expert's blind spot going on with the level of detail I've explained. Feel free to let me know if there's any part I need to explain in greater depth.

This is a semi-blocking issue for getting service logs to GA (#31399 as a meta-issue) because we cannot support details while the format is broken, so either the format has to be fixed or support for details has to be dropped.

/cc @aluzzardi

I don't think the log format was designed to do anything other than just be regurgitated by the API consumer and not really parsed except for stdout/stderr.
Definitely 👍  to improving this.
A simple change to the media type is probably not enough. All API clients < version N should be served the old format at the very least.
I like the idea of using a standard log format however the implementation on these has proven difficult, and even within the syslog format there are multiple RFCs for which we'd have to choose one: https://github.com/RackSec/srslog/blob/master/formatter.go
If we provide protobufs there is a well defined structure that anyone can generate a working client from which should be relatively efficient to stream as well.
Note that in #28403 we are working on a logger plugin implementation that uses protobufs as well. It's not exactly the same since the stream format only needs to handle the log stream type, the actual log data, and the timestamp and none of the extra details since these are initialized on driver startup.

👍 overall
I think:

Short term we should "enhance" the current format with URL encoding, at least to make it somewhat machine parsable
Medium term, we should provide an additional machine-friendly format such as syslog. I think the client could negotiate the format (e.g. ?format=syslog) so we don't break compat and eventually we deprecate the current format

I would avoid protobufs because, even though I'm a huge fan, it's really a hassle to work with if you're not running a proto shop already

I generally consider formatting a job of the client. We're in a really bad situation now because formatting is on the daemon, but I suppose swapping an ill-conceived and ill-defined format for one that is well defined is a step forward... I'm afraid of adding more technical debt here, though.

fixed by #32996 cc @thaJeztah


README: Fix broken links to examples.yaml

One link forgot to add the subdirectory, the other used the wrong branch name.

thanks!


Oracle Cloud Streaming guide

Currently there's only Java code but I'll add Groovy and Kotlin in a bit.

Fixes https://github.com/micronaut-projects/micronaut-guides/issues/261

This is awesome, love this guide! Well done Burt 🤯🤩

OMG Burt you really raised the bar in the guides. It's going to be complicated to even match this!
AMAZING!

Just one minor thing @burtbeckwith, please add some tests so we make sure everything works when we upgrade to new versions.


fe(feature) added 4 cards which describe the number of transactions in dashboard

This is only thing I can contribute now 🥲.
I hope you merge this.

F hogaya koi dusre branch se switch karke ye branch bana diya lag raha hai

F hogaya koi dusre branch se switch karke ye branch bana diya lag raha hai

@amal-thundiyil

Closing in favour of #72.


Add JsonAdaptedTuitionClassTest and update UG to notify users that fi…

…ltering students will not affect class size only what is displayed
Resolves #274

Codecov Report

Merging #281 (2d73915) into master (5be4bfa) will increase coverage by 0.76%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #281      +/-   ##
============================================
+ Coverage     69.36%   70.13%   +0.76%
- Complexity      781      789       +8
============================================
  Files           127      127
  Lines          2602     2602
  Branches        316      316
============================================
+ Hits           1805     1825      +20
+ Misses          700      688      -12
+ Partials         97       89       -8

Impacted Files
Coverage Δ

...seedu/address/storage/JsonAdaptedTuitionClass.java
97.87% <0.00%> (+42.55%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5be4bfa...2d73915. Read the comment docs.

LGTM!

LGTM


checkMeta: Expose checkValidity and add to all-packages

Description of changes
Cherry-picked from a commit that used to be in https://github.com/NixOS/nixpkgs/pull/326199 (see discussion at https://github.com/NixOS/nixpkgs/pull/326199#discussion_r1677255589)
This is useful when a package has an optional dependency on another package that is nonfree or not available for every platform (e.g. https://github.com/NixOS/nixpkgs/pull/326199, https://github.com/NixOS/nixpkgs/pull/310138).
CC @natsukium

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Bump

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/4709

Bump!


durationMillis should accept float instead of int

When we receive float values from functions like Js.Date.now, we're forced to use int_of_float which truncates values causing an overflow.

Hey @baransu,
Your changes look good to me!
View build log
TravisBuddy Request Identifier: 8f4e43c0-f9a2-11e9-93c5-f3e7c8487984


Add dynamodb domain md5 mocking

to: @jacknagz or @ryandeivert
cc: @airbnb/streamalert-maintainers
size: small
resolves N/A
Background

Add more dynamodb mocking which will be useful when doing rule testing while Threat Intel Beta is enabled. (Note, currently, Threat Intel Beta has issue, I am fixing now.)
Enforce IOC value check in lowercased.
Also, this PR adds a conditional check to add read permission to IOC dynamodb table to Rule Process IAM role.

Testing

Rule test

python manage.py lambda test --processor all
...
StreamAlertCLI [INFO]: (60/60) Successful Tests
StreamAlertCLI [INFO]: (93/93) Alert Tests Passed
StreamAlertCLI [INFO]: Completed

Unit test

./tests/scripts/unit_tests.sh
...
-------------------------------------------------------------------------------------
TOTAL                                                    2954     41    99%
----------------------------------------------------------------------
Ran 501 tests in 7.929s

OK

Coverage decreased (-0.03%) to 95.54% when pulling e244c4e97223f8475d6b1a4a73d256662e87108e on add_dynamodb_domain_md5_mocking into b5f9dfe01dbc8ef18481e88e5aa2f9ed58cc7a30 on master.

@ryandeivert Can you help review this PR?
Thanks!

Coverage decreased (-0.03%) to 95.541% when pulling 69be7583d5ff0f9ecac9ea18146c4f3ca0861c18 on add_dynamodb_domain_md5_mocking into 1cede4a68cf34f0ff575c967de8072fe7ca1fd62 on master.


@MasterPranjal Incorrect marking in wiki

Multiple entries for 13/05/2018. Fix it.

corrected for now. Will check again in the evening.


cleanup noisy logs

Description
Please provide a brief description of the purpose of this pull request.
Related Issue
If applicable, please reference the issue(s) that this pull request addresses.
Changes Made
Provide a clear and concise overview of the changes made in this pull request.
Screenshots (if applicable)
Add screenshots or GIFs that demonstrate the changes visually, if relevant.
Checklist

[ ] I have tested the changes locally and they are functioning as expected.
[ ] I have updated the documentation (if necessary) to reflect the changes.
[ ] I have added/updated relevant unit tests (if applicable).
[ ] I have ensured that my code follows the project's coding standards.
[ ] I have checked for any potential security issues and addressed them.
[ ] I have added necessary comments to the code, especially in complex or unclear sections.
[ ] I have rebased my branch on top of the latest main/master branch.

Additional Notes
Add any additional notes, context, or information that might be helpful for reviewers.
Reviewers
Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
Definition of Done

[ ] Code is reviewed.
[ ] Code is tested.
[ ] Documentation is updated.
[ ] All checks and tests pass.
[ ] Approved by at least one reviewer.
[ ] Merged into the main/master branch.

/retest

/retest

/override sonar-pre-submit

/override "SonarCloud Code Analysis" sonar-pre-submit

/override "SonarCloud Code Analysis"

/override ci/prow/sonar-pre-submit

/lgtm


pip install logic2-automation is failing

pip install logic2-automation
Collecting logic2-automation
  Using cached logic2_automation-1.0.6.tar.gz (16 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Preparing metadata (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [26 lines of output]
      Building logic2-automation protobuf files
      Traceback (most recent call last):
        File "C:\Users\huffman\dev\test-logic2-automation\venv\lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 144, in prepare_metadata_for_build_wheel
          hook = backend.prepare_metadata_for_build_wheel
      AttributeError: module 'hatchling.build' has no attribute 'prepare_metadata_for_build_wheel'

      During handling of the above exception, another exception occurred:

      Traceback (most recent call last):
        File "C:\Users\huffman\dev\test-logic2-automation\venv\lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 351, in <module>
          main()
        File "C:\Users\huffman\dev\test-logic2-automation\venv\lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 333, in main
          json_out['return_val'] = hook(**hook_input['kwargs'])
        File "C:\Users\huffman\dev\test-logic2-automation\venv\lib\site-packages\pip\_vendor\pep517\in_process\_in_process.py", line 148, in prepare_metadata_for_build_wheel
          whl_basename = backend.build_wheel(metadata_directory, config_settings)
        File "C:\Users\huffman\AppData\Local\Temp\pip-build-env-no8xozzi\overlay\Lib\site-packages\hatchling\build.py", line 58, in build_wheel
          return os.path.basename(next(builder.build(directory=wheel_directory, versions=['standard'])))
        File "C:\Users\huffman\AppData\Local\Temp\pip-build-env-no8xozzi\overlay\Lib\site-packages\hatchling\builders\plugin\interface.py", line 155, in build
          artifact = version_api[version](directory, **build_data)
        File "C:\Users\huffman\AppData\Local\Temp\pip-build-env-no8xozzi\overlay\Lib\site-packages\hatchling\builders\wheel.py", line 405, in build_standard
          for included_file in self.recurse_included_files():
        File "C:\Users\huffman\AppData\Local\Temp\pip-build-env-no8xozzi\overlay\Lib\site-packages\hatchling\builders\plugin\interface.py", line 177, in recurse_included_files
          yield from self.recurse_forced_files(self.config.get_force_include())
        File "C:\Users\huffman\AppData\Local\Temp\pip-build-env-no8xozzi\overlay\Lib\site-packages\hatchling\builders\plugin\interface.py", line 231, in recurse_forced_files
          raise FileNotFoundError(msg)
      FileNotFoundError: Forced include not found: C:\Users\huffman\AppData\Local\Temp\pip-install-9b1nuh82\proto\saleae\grpc\saleae.proto
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

Related pr. https://github.com/saleae/logic2-automation/pull/34. Confirmed, these temporary changes works.

https://github.com/saleae/logic2-automation/pull/34#issuecomment-1852262554


Aura ring not rotating with token

When I turn my token to the right, the aura jumps about 90 degrees to be at a new angle and then rotates normally with the token.  Basically, the token will rotate, and the ring won't rotate for one click of rotation. Then the ring will rotate with the token as expect but off set from where you want since the token rotated without the ring.  When I rotate the token to the left it acts as expected and stays at the set angle.

Yeah, directional aura ring is not rotating correctly with the token. In my case even just rotating using shift+mouse wheel makes the directional aura ring jump in all sorts of places but almost never correctly, almost as if randomly.

I have almost finished with my UI overhaul; looking at it, the aura rotation seems to be one update behind for some reason.

For me it only happens when rotating in a single direction
On Mon, Aug 26, 2024, 09:12 Anthony Edmonds @.***>
wrote:

I have almost finished with my UI overhaul; looking at it, the aura
rotation seems to be one update behind for some reason.
—
Reply to this email directly, view it on GitHub
https://github.com/AnthonyEdmonds/token-aura-ring/issues/16#issuecomment-2310455690,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEZBNPWNJTECHJLJQYNGW2DZTNAXJAVCNFSM6AAAAABMQXNEJSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJQGQ2TKNRZGA
.
You are receiving this because you authored the thread.Message ID:
@.***>

This should be resolved with v2.0.0. If it isn't, you can re-open the ticket.


Echoing /bebop/cmd_vel displays nothing

Hey,
I wanted to fly the bebop up and then make him go forward, the code is the following:
`#include<ros/ros.h>
#include<nav_msgs/Odometry.h>
#include<geometry_msgs/Twist.h>
#include<stdlib.h>
#include<math.h>
// global variable for yaw
// subscribe to navdata yaw
// in navdata yaw callback update the global variable for yaw
// use the global yaw in getpos
float tag_yaw,tag_x,tag_y,tag_z;
ros::Publisher pub;
ros::Subscriber sub;
void getpos(const nav_msgs::Odometry& posmsg){
geometry_msgs::Twist msg;
float err;
if (posmsg.pose.pose.position.z<= 1){
msg.linear.x=0.0;
msg.linear.y=0.0;
msg.linear.z=  0.05;   // exp ( 0.1);
msg.angular.x= 0;
msg.angular.y= 0;
msg.angular.z=0.0;
}
else {
msg.linear.x=0.8*(tag_x-posmsg.pose.pose.position.x);
msg.linear.y=0.0;
msg.linear.z=  0.0;   // exp ( 0.1);
msg.angular.x= 0;
msg.angular.y= 0;
msg.angular.z=0.0;
}
pub.publish(msg);
ROS_INFO_STREAM( "Showing position : "
<< "x =" << posmsg.pose.pose.position.x
<< "y =" << posmsg.pose.pose.position.y
<< "z =" << posmsg.pose.pose.position.z);
}
int main(int argc, char **argv){
ros::init(argc, argv,"velBebop");
ros::NodeHandle nh;
ros::Rate rate(2);
int i;
tag_x= 1;
tag_y= 0.0;
tag_z= 0.0;
sub = nh.subscribe("/ardrone/predictedPose",1, &getpos) ;
pub = nh.advertise<geometry_msgs::Twist>("/cmd_vel" , 1);
ros::spin();
}
`
even am not able to send commands with the command line:
rostopic pub -r 10 /bebop/cmd_vel geometry_msgs/Twist  '{linear:  {x: 0.1, y: 0.0, z: 0.0}, angular: {x: 0.0,y: 0.0,z: 0.0}}
and echoing /bebop/cmd_vel shows nothing even rqt_graph doesn't include /bebop/cmd_vel topic

I don't know what I did wrong!! PLZ any help will be appreciated

I am currently using the ROS bebop_autonomy package to control the behavior of the Parrot Bebop 2 in Gazebo that works together with Sphinx (please check out this link to learn more about it). Right now, I don't know exactly what your problem is, but you could read my code to understand how to get the drone off the ground and send the command signals.
Please note that the actual control loop is not stable. Nevertheless, you may find it useful to understand how I made the launch file and the C++ files (for controlling the drone).

@gsilano Thanks for your answer.
I saw your code but it is really advanced programming for me. I couldn't see where you send the commanded velocity through /bebop/cmd_vel anywhere!!

Right now, I don't know exactly what your problem is,

my problem is that when I connect to the drone and launch the drive. I can see the topic /bebop/cmd_vel listed but when I do rqt_graph I can't find it and now I don't know how to manage controlling the drone since the topic doesn't appear!!
I want just send some velocities command to make the drone reach some point!!
Any ideas!!!
Thanks

Have you taken a look at my launch files? The problem could be related to a topic remap. Look here or here.

@gsilano Thanks again,
Actually it was my bad defining a wrong topic sorry. In fact, I should replace this
sub = nh.subscribe("/ardrone/predictedPose",1, &getpos) ; pub = nh.advertise<geometry_msgs::Twist>("/cmd_vel" , 1);
by:
sub = nh.subscribe("/bebop/odom",1, &getpos) ; pub = nh.advertise<geometry_msgs::Twist>("/bebop/cmd_vel" , 1);
and I could publish the velocity on /bebop/cmd_vel topic like shown in this rqt_graph

but I still have a problem!! even the velocities are being published, the drone doesn't move at all !!!
Please any suggestions what could be the problem, Thanks.

I solved the problem. by just send an empty message to /bebop/takeoff topic before running the node.
Thanks for your help
I have another question!!! where to get the battery state so I can send an error message when the battery is low!!!
Please help

I didn't get your point. What do you want exactly? 1) Receive an error message when the battery level is too low 2) Use the battery status information to design a controller that manages the landing?
As I know, the Parrot Bebop 2 onboard firmware already manages it. When the battery level is too low (I don't remember exactly the battery percentage) the drone stops the task executions and lands on the ground.

@gsilano I have parrot bebop. and I want to use the battery status information to design a controller that manages the landing!!
How can I do that!! and on which topic this information is available!!
thanks in advance

Here you find all the information that you need. Furthermore, do not forget to use the issue tracker to read questions and answers on topics already discussed.

@gsilano how can I use issue tracker!! and what's to track!! Sorry I search and I found nothing

I suggest you to start reading this page, and then the others linked reported into the conversation. Moreover, I think you could use these ROS services to track the drone battery status and to get the information you need.
CommonChargerStateCurrentChargeStateChanged
Ardrone3PilotingStateAlertStateChanged
Ardrone3MediaRecordStateVideoStateChangedV2
CommonCommonStateBatteryStateChanged

@gsilano Thanks. I will do it!
Another question please, I want to get the simulation time using /clock topic
but this topic is missing when I list the topics even the parameter use_sim_time doesn't exist!!
My purpose is to generate a sinosoidal trajectory with cos( pi t) and the time t here has to be set to 0 when the simulation starts.
Any suggestion please !!

I think, but I could be wrong, you have to develop your trajectory generator using an external C++ file. In this file, your trajectory reference, in terms of x, y, and z components, is sent to the Barropt Bebop in order to generate the appropriate command signals. This is an idea, and I don't if it works or not, so you have to try.

@gsilano ok thanks I will try :)

I solved the problem. by just send an empty message to /bebop/takeoff topic before running the node.
Thanks for your help
I have another question!!! where to get the battery state so I can send an error message when the battery is low!!!
Please help


refactor: migrate to tracing

What does this PR try to resolve?
The migrates CARGO_LOG logging from log to tracing.
tracing is already widely used among the ecosystem and rustc adopted it for a while. We've chatted about this a while back in the weekly meeting.
Last week in the office hour, epage, Muscraft, and arlosi have no objection to this when I mentioned this upcoming PR. ehuss seems to looking forward to the migration https://github.com/rust-lang/cargo/pull/12445#issuecomment-1664753017. Hence posted this pull request.
How should we test and review this PR?
By commits. And please check if CARGO_LOG works for you.
Largely, a search & replace worked just fine. Only in util/network/http.rs I did a manual fix.
The format is also a bit different. Should we make it compatible? (I don't want to though)
# before
[2023-08-07T10:53:48Z DEBUG cargo::sources::registry::http_remote] loading config
# after
2023-08-07T10:43:47.867106Z DEBUG cargo::sources::registry::http_remote: loading config

Additional information
-2 dependencies
+11 dependencies

The format is also a bit different. Should we make it compatible? (I don't want to though)

Compatibility only matters if we intend people to parse it which I don't think we do.
The only other issue is usability which it is probably good enough

I'd like to call out the other change. By default log enables all levels, whereas the built-in fmt subscriber in tracing-subscriber enables up to INFO only. Is that a thing we need to consider? I do feel like INFO is a better default.

@bors r+

:pushpin: Commit 964c083ea1a862f47f20228f64918da6ce8f30cd has been approved by epage
It is now in the queue for this repository.

:hourglass: Testing commit 964c083ea1a862f47f20228f64918da6ce8f30cd with merge b19934c1ea5184d35bd0d514644e40c2e5389355...

:boom: Test timed out

Timed out again…
@bors retry

:hourglass: Testing commit 964c083ea1a862f47f20228f64918da6ce8f30cd with merge 211fd7eac105f0960433a935ce17b8d787233692...

:sunny: Test successful - checks-actions
Approved by: epage
Pushing 211fd7eac105f0960433a935ce17b8d787233692 to master...


Incorrect decimal separator in NumberFormat on iOS with region settings

Hello, I have faced issue related to language and region settings on iOS. I will give you an example based on my settings.
On iOS when you set system language to Polish and region settings to Poland (pl_PL) system will provide number formatting with "," decimal separator.
On the other hand, if you set language to English and region to United Kindom (en_GB) it will provide "." decimal separator.
For both above examples, NumberFormat works as expected.
The problem starts if when you set language to English and region to Poland (en_PL) - the iOS system will format values same as in Poland region settings (so "," decimal separator) but NumberFormat uses English formatting (with "."). That leads us to issue because system keyboard shows comma, which is treated by NumberFormat as group separator - so there is no possibility to type in decimal number.
Currently what I have done to avoid this issue is add numerFormatSymbol for (en_PL), which is same as (pl).
But I'm afraid that many other edge cases are facing same issue.
Is currently anyway to avoid this issue, maybe I'm doing something wrong?

Unfortunately that's probably the best solution at the moment. The fallback logic is very simple and not customizable. So if it doesn't find en_PL it will fall back to en. I'm not sure how you're adding en_PL, but you can do it programmatically by adding a locale to the map, based off one that's already in there. I've seen this used, for example, to customize particular Arabic locales to use native or latin digits.


CreateContainerConfigError - secret "airflow-config-envs" not found

What is the bug?
Running airflow with the KubernetesExecutor - when a pod is launched to run a task it is stuck waiting with a CreateContainerConfigError and message: secret "airflow-config-envs" not found. I am using the default pod template provided in the helm chart.
I am not sure how to fix this myself unfortunately - would love to hear any advice or work arounds if available. Thank you!
What version of the chart are you using?
I am using version 8.5.2 of this chart.
What version of Kubernetes are you using?
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.10", GitCommit:"575467a0eaf3ca1f20eb86215b3bde40a5ae617a", GitTreeState:"clean", BuildDate:"2019-12-11T12:41:00Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.14", GitCommit:"89182bdd065fbcaffefec691908a739d161efc03", GitTreeState:"clean", BuildDate:"2020-12-18T12:02:35Z", GoVersion:"go1.13.15", Compiler:"gc", Platform:"linux/amd64"}

What version of Helm are you using?
version.BuildInfo{Version:"v3.7.1", GitCommit:"1d11fcb5d3f3bf00dbe6fe31b8412839a96b3dc4", GitTreeState:"clean", GoVersion:"go1.17.2"}

What are your custom helm values?

click to expand
######## PASTE values.yaml BELOW ########
###################################
# Airflow - Common Configs
###################################
airflow:
  image:
    repository: airflow:2.2.1-python3.8
    pullPolicy: IfNotPresent

  ## the airflow executor type to use
  executor: KubernetesExecutor

  ## the fernet key used to encrypt the connections in the database
  fernetKey: "fernetkey"

  defaultTolerations:
    - key: node-specialization
      operator: Equal
      value: airflow-staging
      effect: NoSchedule

  ## environment variables for the web/scheduler/worker Pods (for airflow configs)
  config:
    # Security
    AIRFLOW__WEBSERVER__EXPOSE_CONFIG: "False"

    # DAGS
    AIRFLOW__CORE__LOAD_EXAMPLES: "True"

    ## Disable noisy "Handling signal: ttou" Gunicorn log messages
    GUNICORN_CMD_ARGS: "--log-level WARNING"

  ## a list of initial users to create
  users:
    - username: admin
      password: admin
      role: Admin
      email<EMAIL_ADDRESS>      firstName: admin
      lastName: admin

  ## a list of initial connections to create
  connections: []
    ## see docs: https://airflow.apache.org/docs/apache-airflow-providers-google/stable/connections/gcp.html
    # - id: my_gcp
    #   type: google_cloud_platform
    #   description: my GCP connection
    #   extra: |-
    #     { "extra__google_cloud_platform__num_retries": "5" }

  ## a list of initial variables to create
  variables:
    - key: "environment"
      value: "dev"

  ## a list of initial pools to create
  pools:
    - name: "pool_1"
      slots: 5
      description: "example pool with 5 slots"
    - name: "pool_2"
      slots: 10
      description: "example pool with 10 slots"

###################################
# Airflow Ingress
###################################
ingress:
  enabled: true
  apiVersion: networking.k8s.io/v1beta1 # Kubernetes 1.18.14
  web:
    host: ""
    annotations:
      kubernetes.io/ingress.class: "nginx-private"
      nginx.ingress.kubernetes.io/enable-cors: "true"
      nginx.ingress.kubernetes.io/cors-allow-methods: "GET, POST"
      nginx.ingress.kubernetes.io/cors-allow-origin: ""
      nginx.ingress.kubernetes.io/cors-allow-credentials: "true"

###################################
# Airflow - Scheduler Configs
###################################
scheduler:
  ## the number of scheduler Pods to run
  replicas: 1

  resources:
    requests:
      cpu: "2000m"
      memory: "1028Mi"

###################################
# Airflow - WebUI Configs
###################################
web:

  ## configs to generate webserver_config.py
  webserverConfig:
    ## the full text value to mount as the webserver_config.py file
    stringOverride: |-
      from flask_appbuilder.security.manager import AUTH_DB
      AUTH_TYPE = AUTH_DB
      AUTH_ROLE_PUBLIC = 'Admin'
      APP_THEME = "bootstrap-theme.css"
  ## the number of web Pods to run
  replicas: 1

  ## resource requests/limits for the airflow web Pods
  resources:
    requests:
      cpu: "200m"
      memory: "2056Mi"

  ## configs for the Service of the web Pods
  service:
    type: ClusterIP
    externalPort: 8080

###################################
# Airflow - Worker Configs
###################################
workers:
  ## if the airflow workers StatefulSet should be deployed
  enabled: false
  replicas: 2

  resources:
    requests:
      cpu: "256m"
      memory: "2Gi"

  podDisruptionBudget:
    enabled: true
    maxUnavailable: "20%"

  autoscaling:
    enabled: true
    maxReplicas: 8
    metrics:
    - type: Resource
      resource:
        name: memory
        target:
          type: Utilization
          averageUtilization: 80

###################################
# Airflow - Flower Configs
###################################
flower:
  ## if the Flower UI should be deployed
  ##
  enabled: false

###################################
# Airflow - Logs Configs
###################################
logs:
  ## configs for the logs PVC
  persistence:
    ## if a persistent volume is mounted at `logs.path`
    enabled: false

###################################
# Kubernetes - Service Account
###################################
serviceAccount:
  create: true
  name: "airflow-staging"

###################################
# Airflow - DAGs Configs
###################################
dags:
  ## configs for the git-sync sidecar (https://github.com/kubernetes/git-sync)
  gitSync:
    ## if the git-sync sidecar container is enabled
    enabled: false

###################################
# Database - PostgreSQL Chart
###################################
postgresql:
  enabled: false

externalDatabase:
  type: postgres
  host: rds_host
  port: 5432
  database: airflow
  user: airflow
  passwordSecret: airflow-postgresql
  passwordSecretKey: postgresql-password

  # use this for any extra connection-string settings, e.g. ?sslmode=disable
  properties: ""

###################################
# Database - Redis Chart
###################################
redis:
  enabled: false

  ...
######## PASTE values.yaml ABOVE ########

Might not be too useful, but I too run Airflow on the KubernetesExecutor and I checked all my namespaces and did not find the secret - airflow-config-envs.
My setup works, the major difference being the airflow version is the one that comes with the chart. Since you're overriding that I'm assuming you need the new features, but you can try with the default version to see if that changes something.

@piyush-daga what namespace are you installing the helm chart into, and is the Secret/airflow-config-envs in that namespace?
Note, if you don't specify one, helm install ... will use the default namespace.

@DMilmont @piyush-daga are you still having this issue?
If so, I imagine that you are somehow submitting your KubernetesExecutor task pods into a DIFFERENT namespace than you have installed airflow into, this won't work because our pod_template.yaml references the airflow-config-envs Secret from the airflow install namespace.

I had to add this env var under the airflow.config section:
AIRFLOW__KUBERNETES__NAMESPACE: "airflow"
The airflow-config-envs secret was referring to the default namespace for some reason, even though my chart is deployed on the airflow namespace (using ArgoCD). I happened to check the FERNET_KEY secret in airflow-config-envs and it was different than the fernet key secret I created initially. Everything seems to work right now though so maybe that doesn't matter, just seemed odd.


Update Visitor-and-Patch.md

Stringer example fixed.

Thanks a lot! Contributions to the documentation is very helpful.


Exception: Failed to retrieve the i3 IPC socket path

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/i3ipc/i3ipc.py", line 341, in __init__
    close_fds=True, universal_newlines=True).strip()
  File "/usr/lib/python3.6/subprocess.py", line 336, in check_output
    **kwargs).stdout
  File "/usr/lib/python3.6/subprocess.py", line 418, in run
    output=stdout, stderr=stderr)
subprocess.CalledProcessError: Command '['i3', '--get-socketpath']' died with <Signals.SIGUSR1: 10>.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/user/.i3expo/i3expod.py", line 511, in <module>
    update_state(i3, None)
  File "/home/user/.i3expo/i3expod.py", line 218, in update_state
    if current_workspace.num == i3ipc.Connection().get_tree().find_focused().workspace().num:
  File "/usr/local/lib/python3.6/dist-packages/i3ipc/i3ipc.py", line 343, in __init__
    raise Exception('Failed to retrieve the i3 IPC socket path')
Exception: Failed to retrieve the i3 IPC socket path
[xcb] Unknown request in queue while dequeuing
[xcb] Most likely this is a multi-threaded client and XInitThreads has not been called
[xcb] Aborting, sorry about that.
python3: ../../src/xcb_io.c:165: dequeue_pending_request: Assertion `!xcb_xlib_unknown_req_in_deq' failed.

This occurs apparently randomly whenever the above line (i3ipc.Connection().get_tree().find_focused().workspace().num) is executed. Unfortunately it's rare enough that I can't easily narrow down the circumstances, but there appears to be no simple reason. Called in a while True, this does exactly what it's supposed to do for hours at least, suspends included.
Please advise what additional information would be necessary. Installed from pip3, current version 1.5.1.
Edit: Oh, and nvm the SIGUSR1 thing - the function gets executed only when I send that signal.

This looks like a problem within the i3 binary.

This will help: https://github.com/i3/i3/issues/3476

The new asyncio connection will use python-xlib to get the socketpath from the root window in preference over the binary which should fix this even more.


BUG: onyo new allows multiple usages of --path, but does just use the last one

When I want to create 2 devices with two different "make" (and everything else being equal), I would type e.g. --keys make=lenovo make=apple.
When I try to add 2 different directories for these, onyo allows that I do --path a/ --path b/ (no error raised), but it just applies the second directory to all newly created assets:
> onyo new --keys RAM=8GB display=14.6 type=laptop make=lenovo make=apple model=T490s serial=faux --path shelf/ --path a/
The following will be created:
---
+++ /Users/tkadelka/onyo/a/laptop-lenovo-T490s.fauxC7MBPj
@@ -1 +1,6 @@
-{}
+RAM: 8GB
+display: 14.6
+type: laptop
+make: lenovo
+model: T490s
+serial: fauxC7MBPj
---
+++ /Users/tkadelka/onyo/a/laptop-lenovo-T490s.fauxfYv0KX
@@ -1 +1,6 @@
-{}
+RAM: 8GB
+display: 14.6
+type: laptop
+make: apple
+model: T490s
+serial: fauxfYv0KX
Create assets? (y/n)

Further testing shows, that actually this is true for specifying --keys two times, too:
> onyo new --keys RAM=8GB display=14.6 type=laptop make=lenovo model=T490s serial=faux --keys make=apple type=laptop model=T490s serial=faux --path shelf/
The following will be created:
---
+++ /Users/tkadelka/onyo/shelf/laptop-apple-T490s.fauxkOEtK8
@@ -1 +1,4 @@
-{}
+make: apple
+type: laptop
+model: T490s
+serial: fauxkOEtK8
Create assets? (y/n)

IMO we should check if this is true for all commands/arguments, and if possible block the double-usage of flags that overwrite each other, and instead raise an error, explaining the contradiction.

This seems to be a known limitation of argparse.

https://stackoverflow.com/questions/14915986/only-one-command-line-argument-with-argparse
https://stackoverflow.com/questions/23032514/argparse-disable-same-argument-occurrences

Using a custom action looks to be the most appropriate way. The onyl problem is that it will "conflict" with some of the existing actions. These are the ones in use:

store_true (8)
store_false (1)
version (1)
append (1)
StoreKeyValuePairs (2)

store_true, store_false, and version won't create any problems if they are specified multiple times. So that's easy. append intentionally wants that behavior. So that leaves StoreKeyValuePairs, which will need to be extended to include the behavior of the new custom action.

Note, that WRT to --path it simply shouldn't be allowed multiple times any more (I see an argument for this for --keys, though).
If multiple assets need to be created in different dirs, the directory reserved key is the way to go - either via --keys or TSV.

If multiple assets need to be created in different dirs, the directory reserved key is the way to go

Good point, this should be described in read the docs!

If multiple assets need to be created in different dirs, the directory reserved key is the way to go - either via --keys or TSV.

This will require some sort of append functionality.

I understood that this will not require anything , since it is already implemented.
And indeed, when I run onyo new --keys directory=shelf directory=advertisement [all other stuff needed] it works like a charm :)
So only the behavior for using the same flag multiple times (caused by arg-parse) needs to be fixed, and I will add a PR for readthedocs adding the explanation for multiple directory tomorrow.


Update us/ma/statewide to use statewide address points instead of par…

…cels. #1831
My first contribution, so please treat with caution. For this
"street": [
    "PRE_MOD",
    "PRE_DIR",
    "BASE",
    "POST_MOD",
    "POST_DIR"
],

I've verified that the order of PRE_MOD and PRE_DIR are correct with respect to the source's aggregate field, STREETNAME. There seem to be no records having entries for both POST_MOD & POST_DIR so I've made my best guess at their best concatenation order.

I noticed that STREETNAME field in the source data already contains the concatenated street fields instead of piecing together the other 5 components, so you could use that instead.  Other than that, it looks great!

I started with STREETNAME but when I asked @iandees about it in Slack he said

i usually like to concatenate the street names by specifying the parts in a list so that if we add the individual columns in the future it'll be easier to spot the ones that have the columns broken out already

so I went with his approach.

Ah, makes sense.


Unhelpful error with take -10

What happened?
I get an unhelpful error message.
Error:
    ╭─[std.prql:23:61]
    │
 23 │ let sub = left right -> <int || float || timestamp || date> internal std.sub
    │                                                             ────────┬───────
    │                                                                     ╰───────── expected a pipeline that resolves to a table, but found `internal std.sub`
    │
    │ Help: are you missing `from` statement?
────╯

PRQL input
from pets | take -10

SQL output
-- None

Expected SQL output
No response
MVCE confirmation

[X] Minimal example
[X] New issue

Anything else?
Earlier there was now resolved issue #1396.

Thanks!
Could we add this to bad_error_messages.rs? Quoting from there on why that's a better way of managing these than GH issues: https://github.com/PRQL/prql/blob/85d911c6085578a8a68bbcbcdd5ecebf11872f21/prqlc/prqlc/tests/integration/bad_error_messages.rs#L13-L16

The problem here is that your query is parsed as:
from pets | (take - 10)

This is obviously wrong, you cannot substract a number from a function.
Long-term solution is to provide a type error. Short term solution is to make a special case somewhere.


feat: add expired value in permissions

What does this do / why do we need it?
It adds a new property named expired for the expired permissions based on the ttl value set.
What should your reviewer look out for in this PR?
Do you need help or clarification on anything?
Which issue(s) does this PR fix?

@siddharthlatest Fixed the changes.


Typescript

Type definition files for all components.
Does not show if .svelte files are imported directly. E.g.:
-- good: import Checkbox from 'smelte/src/components/Checkbox'
-- bad: import Checkbox from 'smelte/src/components/Checkbox/Checkbox.svelte'
If preferred I can publish types to definitelyTyped

That's pretty insane amount of work. Thank you!


feat(tracing): bump to v1.1.0

bump tracing version to v1.1.0.
drop deprecated fields from tempo's configuration file template.
align nomenclature in minio's root credentials to follow the breaking change introduced in the release of the module.

[!NOTE]
Creating PR as draft waiting for confirmation on 1.28 compatibility

I think that we can safely merge it while it's also being tested for 1.28, since tempo has no direct dependencies to Kubernetes

Compatibility has been confirmed in https://github.com/sighupio/fury-kubernetes-tracing/pull/13


Add service build and publish GitHub action

Changes

minor tweaks to Mise commands
build initial "build and publish" GitHub workflow

Comments

This is an initial stab at what I think we might want for automating service deployments.
DO NOT MERGE THIS PULL REQUEST UNTIL IT HAS BEEN GIVEN THE ALL-CLEAR

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#430  👈 (View in Graphite)
#429
#428
#427
#426
#425
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

@chrisaddy I'm merging just because this has been open for a while.


Newline support/Unwanted escaping of backslash character

First of all, thank you for this library! This is just right for my needs (no dependencies, yet complete with tool support for string extraction). Worked on the first try, too...
I need to specify newlines in my translated strings. The obvious way to just include \n doesn't work, because the resulting C string has the backslash escaped with another backslash, i.e. 'Hello\nworld' becomes "Hello\\nworld".
Is this a bug or am I missing something?
Edit: I changed the quotes from double to single above, because that is what I actually did use in code before and what triggered the behaviour. See my next comment.

I can not reproduce. Backslashes may be duplicaed in keys, but not duplicaed in value.
You can use any word for phrase key (instead of real phrase), and then assign real value in translation. Usually default translation has zero content, because default value = key value. But that's not mandatory.
Please, create a test repo with minimal sample. It's a bit difficult to understand problem from description.

While preparing the test case, I noticed that the double backslash does only occur if I use single quotes in the .yml file. Using double quotes, everything works as intended. I suspect that this is Working As Intended and it is just me not understanding the finer semantics of .yml files. So feel free to close this issue, but maybe consider adding a note to the documentation. Otherwise, just let me know if you want me to push my example project.

Double quoted strings supports escaping (\n) inside. Single quoted take string as is.
In short - don't use quoting, or use single quoting is something goes wrong. Or read yaml spec, if you have a lot of time and wish to break your brain :)

I have the same problem. Here is the example: https://github.com/liangyongxiang/lv_i18n_test
In the c code, I am using _("line1\nline2\nline3"), which is expected to be {"line1\nline2\nline3", "line 1\\n line 2\\n line 3\n"}.
Actually it is: {"line1\\nline2\\nline3", "line 1\\\n line 2\\\n line 3\\\n"}, link: https://github.com/liangyongxiang/lv_i18n_test/blob/master/lv_i18n.c#L38=

I had the same issue but putting the translation into " solved it for me. E.g. in the yml file:
de:
  a\nb\nc: "some\ntranslation\nhere"

I was happy too early. My above comment solves the issue of \n in the translated text but biggest problem is that _("a\nb\nc") will be exported as:
  a\\nb\\nc: ~

And as a\\nb\\nc != a\nb\nc lv_i18n won't find translation for a\nb\nc. The solution seems to be to replace \\ns with \n in the tags when generating lv_i18n.c. Other special characters might be affected too, but at least replacing this one would solve the most possible issue.

Here is example of difference with quoting in yaml:
http://nodeca.github.io/js-yaml/#yaml=LSAiYVxuYlxuYyI6ICJzb21lXG50cmFuc2xhdGlvblxuaGVyZSIKLSBhXG5iXG5jOiAic29tZVxudHJhbnNsYXRpb25cbmhlcmUiCi0gJ2FcbmJcbmMnOiAic29tZVxudHJhbnNsYXRpb25cbmhlcmUi
So, with " we can be sure yaml data is correct (at least). Probably, bug in import/export between C and JS string formatting.
I'm a bit busy  with other things now. Relocating & cutting urgent tails.

I have the same problem. Here is the example: https://github.com/liangyongxiang/lv_i18n_test

If you want to write newlines as \n, you need to use double quotes in your yaml.
If you don't use quotes, yaml parser treats it as literal backslash+"n". This is intended behavior as per yaml spec.

My above comment solves the issue of \n in the translated text but biggest problem is that _("a\nb\nc") will be exported as:
 a\nb\nc: "some\ntranslation\nhere"

Can you please explain which tool exports the string like that without quotes?

Fixed in https://github.com/lvgl/lv_i18n/commit/a5c19c3c20bc92b6dbef2506941421ed1509c49d, thanks for reporting.

Fixed in a5c19c3, thanks for reporting.

Yes, It worked


Move backoff logic into own struct and increase test coverage of timeout logic

Changes
Separate backoff logic from timeout logic ⏰
The timeout handler was trying to do two different jobs:

Track timeouts for executing TaskRuns and PipelineRuns; when they
timeout, they should be re-reconciled, at which point they would
fail b/c they took to long
Track backoffs when TaskRun pod creation fails due to resource quota
issues. In this case we want to retry pod creation (by re-reconciling)
after a backoff in case the resource issue has been resolved.

The logic for these 2 jobs was combined because they both share at their
heart very similar logic: the logic for creating go routines that wait
until a period of time has passed.
Now these two jobs are done by 2 different structs, which both use the
new Timer struct and logic, so they can share this logic, without having
to mix the code on top.
Future things we can do to make this even better:

Add more test coverage for the new structs
The "Handler" struct (which may have too generic a name at this point)
probably doesn't need to have separate logic for pipelineruns +
taskruns since each of these controllers will instanitate it
separately
As discussed in #2905, knative/pkg's controller logic will attempt
to re-reconcile all the Runs on start up, so we probably don't need
to be explicitly doing this as well

Add more timeout test coverage and fix timeout "bug" 🐞
Add more tests to increase coverage of timeout package. This means
updating some code to be more unit testable, specifically injecting the
function used to determine the current time into Backoff.
This revealed a "bug" where the backoff logic wasn't using a default
value when the TaskRun timeout isn't set - however the defaulting logic
ensures that it is always set, so if anything, maybe we should actually
panic in this case.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[n/a] Includes docs (if user facing)
[x] Commit messages follow commit message best practices
[x] Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
It almost seems like this is fixing a bug, but because of how the defaulting logic works, I don't think it really is.
NONE

oooo a data race!
==================
WARNING: DATA RACE
Read at 0x00c000c3c198 by goroutine 103:
  reflect.typedmemmove()
      /usr/local/go/src/runtime/mbarrier.go:177 +0x0
  reflect.packEface()
      /usr/local/go/src/reflect/value.go:119 +0x126
  reflect.valueInterface()
      /usr/local/go/src/reflect/value.go:1023 +0x1b9
  reflect.Value.Interface()
      /usr/local/go/src/reflect/value.go:993 +0x3c27
  fmt.(*pp).printValue()
      /usr/local/go/src/fmt/print.go:726 +0x3c28
  fmt.(*pp).printValue()
      /usr/local/go/src/fmt/print.go:880 +0x2709
  fmt.(*pp).printArg()
      /usr/local/go/src/fmt/print.go:716 +0x25a
  fmt.(*pp).doPrintf()
      /usr/local/go/src/fmt/print.go:1030 +0x311
  fmt.Sprintf()
      /usr/local/go/src/fmt/print.go:219 +0x73
  go.uber.org/zap.(*SugaredLogger).log()
      /home/prow/go/src/github.com/tektoncd/pipeline/vendor/go.uber.org/zap/sugar.go:230 +0x175
  go.uber.org/zap.(*SugaredLogger).Errorf()
      /home/prow/go/src/github.com/tektoncd/pipeline/vendor/go.uber.org/zap/sugar.go:148 +0x331
  github.com/tektoncd/pipeline/pkg/timeout.(*Backoff).SetTimer()
      /home/prow/go/src/github.com/tektoncd/pipeline/pkg/timeout/backoff.go:142 +0x29a

Previous write at 0x00c000c3c198 by goroutine 79:
  knative.dev/pkg/apis/duck/v1beta1.(*Status).SetConditions()
      /home/prow/go/src/github.com/tektoncd/pipeline/vendor/knative.dev/pkg/apis/duck/v1beta1/status_types.go:84 +0x43
  github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1.(*TaskRunStatus).SetConditions()
      <autogenerated>:1 +0x61
  knative.dev/pkg/apis.conditionsImpl.SetCondition()
      /home/prow/go/src/github.com/tektoncd/pipeline/vendor/knative.dev/pkg/apis/condition_set.go:208 +0x3ee
  knative.dev/pkg/apis.(*conditionsImpl).SetCondition()
      <autogenerated>:1 +0x149
  github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1.(*TaskRunStatus).SetCondition()
      /home/prow/go/src/github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1/taskrun_types.go:253 +0x43c
  github.com/tektoncd/pipeline/pkg/reconciler/taskrun.(*Reconciler).handlePodCreationError()
      /home/prow/go/src/github.com/tektoncd/pipeline/pkg/reconciler/taskrun/taskrun.go:470 +0x144
  github.com/tektoncd/pipeline/pkg/reconciler/taskrun.TestHandlePodCreationError.func1()
      /home/prow/go/src/github.com/tektoncd/pipeline/pkg/reconciler/taskrun/taskrun_test.go:2100 +0xd5
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:992 +0x1eb

Goroutine 103 (running) created at:
  github.com/tektoncd/pipeline/pkg/reconciler/taskrun.(*Reconciler).handlePodCreationError()
      /home/prow/go/src/github.com/tektoncd/pipeline/pkg/reconciler/taskrun/taskrun.go:467 +0x52a
  github.com/tektoncd/pipeline/pkg/reconciler/taskrun.TestHandlePodCreationError.func1()
      /home/prow/go/src/github.com/tektoncd/pipeline/pkg/reconciler/taskrun/taskrun_test.go:2100 +0xd5
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:992 +0x1eb

Goroutine 79 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1043 +0x660
  github.com/tektoncd/pipeline/pkg/reconciler/taskrun.TestHandlePodCreationError()
      /home/prow/go/src/github.com/tektoncd/pipeline/pkg/reconciler/taskrun/taskrun_test.go:2099 +0x12bd
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:992 +0x1eb

I think this race condition might be another instance of #1307 🤔

While trying to figure this out I think I found a bigger problem, I'm going to close this PR for now b/c I'll need to rebase it anyway.

My hunch is that the %q formatter is not threadsafe in that case? In hindsight this may be why we have the StatusKey interface - the GetRunKey() func of TaskRun returns a thread-safe descriptor.

In fact I think this is a bug that I introduced - the address of the Run might be thread safe, but it's not going to be the same on every reconcile! So I think that actually every single Run is timing out because the done channel can never be signaled 😅


Would you consider working on a proposal to include this in phobos?

This is a great lib that is generally useful. I came across it on a board somewhere. Just a suggestion, I think it makes sense to try and get this included in Phobos.

If someone else wants to include it in phobos, I'll gladly sign off on it and maintain it afterward. I have no desire to work through that process myself.


di: Sanitize data carrying enums correctly

Data carrying enums are causing a crash of the BPF Assembly Printer pass. As a workaround, we were always replacing the elements of that enum metadata with an empty MDNode.
However, #142 broke this behavior by calling replace_elements on a wrong composite type - it was calling it on the inner one (data carrying field), instead of the outer one (enum). This change fixes it.

This change is

src/llvm/di.rs line 648 at r1 (raw file):
Previously, tamird (Tamir Duberstein) wrote…
Are you sure the elements aren't reference counted? I think they might be, and we need not do anything.

OK, it is actually being handled gracefully in LLVM. I must've been blind before.
https://github.com/llvm/llvm-project/blob/be1e8a659df5003fa74e1f55c40acf3667f3cdb9/llvm/lib/IR/Core.cpp#L1339
https://github.com/llvm/llvm-project/blob/be1e8a659df5003fa74e1f55c40acf3667f3cdb9/llvm/lib/IR/Metadata.cpp#L1039
https://github.com/llvm/llvm-project/blob/be1e8a659df5003fa74e1f55c40acf3667f3cdb9/llvm/lib/IR/Metadata.cpp#L869-L917
Let me just remove this comment.


Update curl logic for broader compatability

change the way we use curl to minimize cross platform issues.

I tested it on Ubuntu->
I ran
CLIENT_ID=REDACT CLIENT_SECRET=REDACT SIDECAR_ID=REDACT CONTROL_PLANE=REDACT  bash -c "$(curl -fsSL https://raw.githubusercontent.com/cyral-quickstart/quickstart-sidecar-express/curlupdate/install-sidecar.sh)"
This is the output:
Sidecar Setup
=============
CONTROL_PLANE enviroment variable found, using 'REDACT'
SIDECAR_ID enviroment variable found, using 'REDACT'
CLIENT_ID and CLIENT_SECRET enviroment variables found, client ID being used 'REDACT'
Getting sidecar version from Control Plane...
ENV_FILE_PATH not set, skipping
Downloading sidecar version v4.12.2
Starting Sidecar
Sidecar Started, checking for Control Plane connectivity...
.....
Sidecar successfully started!
To check if its has successfully connected to the controlplane go to Sidecar -> your sidecar -> Sidecar Instances

CONTAINER ID   IMAGE                                        COMMAND                  CREATED              STATUS              PORTS     NAMES
67525affb63f   public.ecr.aws/cyral/cyral-sidecar:v4.12.2   "/opt/cyral/bin/star…"   About a minute ago   Up About a minute             sidecar

Will do more tests to check, but the sidecar is coming up so the script worked


[DOCs] - Components - List

Go to the documentation API
Components => List
Scroll to Controls box
Take a look at the CODE

It's a code of some other box.

Duplicate of #486.

True.


mojang-spigot-remapper fails on plugins targeted for Java 21

mojang-spigot-remapper fails to remap plugins targeted for Spigot 1.20.5 since it requires Java 21 code.  The 1.4.0 release of mojang-spigot-remapper uses an out of date implementation of net.md-5:SpecialSource that doesn't support Java 21 code.   The gradle.properties should be update to use the 1.11.4 version of SpecialSource in order to avoid unsupported class file major version 65 errors that prevent remapping.

Submitted a PR @ https://github.com/patrick-choe/mojang-spigot-remapper/pull/4. See when the owner comes online.

I'll push it to gradle plugin server in few hrs thank you so much!


Add support for annotation in pdf

Is your feature request related to a problem? Please describe.
The Android PDF viewer currently does not display embedded annotations. This limits the usability of annotated PDFs for users, who must rely on other tools to view essential feedback or notes, disrupting their workflow.
Describe the solution you'd like
Please add support for rendering standard PDF annotations within the Android viewer, most wanted is user filled data, forms.
Describe alternatives you've considered
Users currently need to switch to third-party PDF viewers or export annotations separately—both of which complicate the process.
Additional context
Previously used a different library for viewing PDF in app, it had enableAnnotationRendering which enabled comments, colors and forms.

Hi,
Is there any update about that?


Clearing Operations: Potential Issues with Alternative Coordinate Systems

Using the "Canvas GRG" tool in the Clearing Operations Template with WGS 1984 for the data layers and data frame over Boston, MA. Input AO equals 1.4 mile square but the output produces a single grid square (A1) with 4,600 mile diameter: Boston to the Black Sea. Changed AO feature class input projection to WGS 1984 Web Merc and the tools worked as designed.
┆Issue is synchronized with this Asana task

Added to Asana - https://app.asana.com/0/23179693844547/23186355169299

@mfunk shouldn't this be assigned to @jscott11, since she worked on the tools before?

@jscott11 Can you check this one out also?

Logged into backlog.

This should now be fixed on the version in the september staging folder

I will take a look at this.

Verifed