proposal: time: Duration should have .Ceil method

What version of Go are you using (go version)?

$ go version
go1.14.4

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/jaap/.cache/go-build"
GOENV="/home/jaap/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/jaap/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build626039516=/tmp/go-build -gno-record-gcc-switches"

Having a ceil method is usefull for cases where you have a minimum duration, but in reality it needs to be on a per X basis, so the duration might only be 0.5 seconds, but in-reality it can only finish once aa second so you want to round it up to 1 second.
The Time package provides a time round method for rounding to the nearest X and a truncate method for rounding down(towards 0) but not the other way around (away from 0) making it incomplete.

Having a ceil method is usefull for cases where you have a minimum duration, but in reality it needs to be on a per X basis, so the duration might only be 0.5 seconds, but in-reality it can only finish once aa second so you want to round it up to 1 second.

Can you elaborate on this use case? I'm having a hard time envisioning what exactly you mean.

@JAicewizard can you respond to @mdempsky's question? I too am having a little bit of trouble understanding why this is important to add to the API.

I believe OP wants to replace this code with a method
dur := durationOfSomeTask
X := time.Second
if dur < X {
    dur = X
}

Imagine you have a task taking X duration and you have timeslots of length Y and task X can only finish at the end of a timeslot.
At the moment I have:
startTime = {start time} //time.Time
X := {duration} //time.Duration
realDuration := X.Truncate(Y)
endtime = start.Add(realDuration)
//realDuration will be Y less then we need, unless X == n*Y
if realDuration != X{
    endtime.Add(Y)
}

This would all be solved by being able to round up to the neared multiple of Y instead of just being able to round down/nearest.

I'm sorry but I still don't understand. It still seems like very hypothetical.
Note that endtime := start.Add((X+Y-1).Truncate(Y)) works today.

This is a real world example of where this is usefull. lesson.startTime/endTime are just timestamps and their week/year is irrelevant.
min/max are the start/end time these lessons should be active for (like term begin/end dates for example)
Here we calculate how much these lesson.startTime/endTime should be offset by in order to be the first occurance of this timerange withing this term start/end time range.
This is done by calculating how much it should be offset by to match the start time, and then round up to 1 week. Or in this case round down and then optionally add 1.
timeOff := min.Sub(lesson.startTime).Truncate(time.Hour * 24 * 7)
lesson.startTime = lesson.startTime.Add(timeOff)
lesson.endTime = lesson.endTime.Add(timeOff)

//remember, we truncate, so we will almost always fall short 1 week
if lesson.startTime.Before(min) {
	lesson.startTime = lesson.startTime.Add(time.Hour * 24 * 7)
	lesson.endTime = lesson.endTime.Add(time.Hour * 24 * 7)
}

This is an example of a real world program, or well if it ware not scraped it would be running in the real world.
Particular code is part of importing data from a scheduling program.
You are right that  endtime := start.Add((X+Y-1).Truncate(Y)) might do the exact same, but it is unintuitive. .Ceil is much simpler to read, write and reason about when making changes.

OK, I think I understand what you are trying to write. Thanks for bearing with me. I wrote a running demo at https://play.golang.org/p/GUreZdb5pYI:
package main

import (
	"fmt"
	"time"
)

func main() {
	start := time.Date(2020, 8, 1, 0, 0, 0, 0, time.Local)
	end := time.Date(2020, 8, 31, 23, 59, 59, 0, time.Local)

	fmt.Println(start)
	fmt.Println(end)
	fmt.Println()

	example := time.Date(2001, 1, 1, 14, 30, 0, 0, time.Local)

	const D = 24 * 7 * time.Hour
	first := example.Add((start.Sub(example) + D - 1).Truncate(D))
	// want to write: first := example.Add(start.Sub(example).Ceil(D))

	fmt.Println(example)
	fmt.Println("=>")
	fmt.Println(first)
}

Note that while it works on the playground in UTC, it actually fails on my local system, in that the time of the event changes from 14:30 to 15:30 because of a daylight savings change. Not all weeks are 247time.Hour long.
Note also that (d+D-1).Truncate(D) is not even correct when d < 0, so if we change example to be the year 2100, first will end up being August 14 instead of August 7. (d+D-1).Floor(d) would be correct, but we don't have Floor, only Truncate.
It would be weird to have Ceil and Truncate but not Floor, so really this proposal would be to add both Ceil and Floor.
And I'm also not convinced Ceil and Floor would be the right names since those are so tied to real -> integer conversions. It would be better to call them RoundUp and RoundDown. So Duration would have Truncate, Round, RoundUp, and RoundDown.
It's not too bad to consider adding those two extra methods. They are simple enough.
But since every new method incurs cost for users reading docs and learning the APIs, I'd still like to understand whether there's a widespread need, ideally in an example that doesn't depend on daylight savings time not happening.
I looked at C#, Java, and Python to see if there was evidence of need in other languages, and as far as I can tell those all don't have any kind of rounding methods whatsoever.

I dont know if there is a widespread need, but considering there is a Truncate clearly there used to be a need of some kind of rounding. I found it odd to only see Truncate and not the other round methods since they are usually provided together.
Maybe it is also worth considering adding the opposite of Truncate, I dont know what it would be called but with those 2 combined users can easily construct Floor and Ceil. This might not be as elegant but if keeping the API tight is the goal it could be an option.

Note that while it works on the playground in UTC, it actually fails on my local system, in that the time of the event changes from 14:30 to 15:30 because of a daylight savings change. Not all weeks are 24_7_time.Hour long.

Wouldnt daylight savings be a new timezone (in the go timezone sense)? ₣om what I can see a go timezone is always the same offset to GMT.

Go timezones do not have a fixed offset from GMT.  They do support daylight savings time.  As the docs say: "For many Locations the time offset varies depending on whether daylight savings time is in use at the time instant."

If there were other use cases for RoundUp/RoundDown that come up the future, then it seems like it would be fine to revisit this. But this use case doesn't seem like it justifies them, since the use does not result in a correct program.
Are there any other use cases? If not, we should probably decline this.

I dont know, maybe there are, maybe not.
I would definitly think of adding the opposite of .Truncate aka round away from 0, just to make it symmetrical.
If this is closed, I think we should invite people to reopen if they find a good use-case for this.

Based on the discussion above, this seems like a likely decline.
It would be fine to file a new proposal for RoundUp/RoundDown, mentioning this one, if compelling use cases can be found.
(The use case here does not quite work.)

No change in consensus, so declined.


Fixes building wheel process on local CI.

What do these changes do?
It have been failed for quite a while... Removing unsupported Python 3.7 from CI (and install_deps.sh) as well.

See  also https://github.com/alibaba/GraphScope/actions/runs/4249240830/jobs/7389565466, the local ci has been install incorrect artifacts since many revisions ago ...

Codecov Report

Merging #2455 (bd0996c) into main (555abd3) will decrease coverage by 2.91%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2455      +/-   ##
==========================================
- Coverage   42.84%   39.93%   -2.91%
==========================================
  Files          88       88
  Lines        9771     9771
==========================================
- Hits         4186     3902     -284
- Misses       5585     5869     +284

Impacted Files
Coverage Δ

python/graphscope/tests/unittest/test_java_app.py
0.00% <0.00%> (-100.00%)
:arrow_down:

python/graphscope/deploy/hosts/cluster.py
30.48% <0.00%> (-57.32%)
:arrow_down:

python/graphscope/framework/utils.py
42.25% <0.00%> (-13.75%)
:arrow_down:

python/graphscope/client/rpc.py
73.88% <0.00%> (-6.72%)
:arrow_down:

python/graphscope/framework/graph_schema.py
52.73% <0.00%> (-6.63%)
:arrow_down:

python/graphscope/analytical/app/java_app.py
24.36% <0.00%> (-4.57%)
:arrow_down:

python/graphscope/tests/conftest.py
47.53% <0.00%> (-4.02%)
:arrow_down:

python/graphscope/framework/app.py
70.50% <0.00%> (-3.69%)
:arrow_down:

python/graphscope/analytical/udf/utils.py
36.17% <0.00%> (-3.20%)
:arrow_down:

python/graphscope/client/session.py
65.79% <0.00%> (-3.18%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555abd3...bd0996c. Read the comment docs.


Marker not updating

When using Worldguard to define regions, a marker in the bluemap should be created after some time.
Unfortunately this is not working for the dimension "world_nether".
The console is stating, that the changes done to worldguard have been saved to background but the marker is never generated .
Using the latest version of all involved plugins:

BlueBridge (v1.3-alpha)
BlueMap (1.5.5)
WorldGuard (7.0.5)
Paper 1.16.5 (Build #779)

Thanks for the detailed info, I will try to replicate the issue once I have time.
In the meantime, could you tell me if the marker is created when it already exists on a fresh server restart? That would tell me if it was an issue with my plugin not detecting the world at all or not fetching region updates correctly.

Thanks for your fast reply!
Sorry for missing out that information. The marker is also not created after restarting the server.

Alright so the issues were:

I overwrote the current markers for a region on each world update (Don't even ask how I didn't notice that WAY earlier :D)
I didn't reset the last saved markers on every Bluemap reload so it just cleared the markerset (which is intended) and then it thought all the old regions were unchanged and didn't add them again.

Both issues will be fixed in v1.3.1-alpha.


HDDS-6373. EC: Exclude pipeline upon container close instead of exclude DNs.

What changes were proposed in this pull request?
Exclude pipeline upon container close instead of exclude DNs.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6373
How was this patch tested?
manula tests, see the JIRA above.

Thanks for looking into this issue. Myself and Uma discussed something related to this recently, but we did not get time to address it yet. The change looks mostly good to me - I just had one comment / question.
I would like @umamaheswararao to review it too, as he knows the write code path better than I do.


Create Types of (PET) Privacy Enhancing Technologies .md

I want to introduce the types of PET in this documentation part with a general discussion on federation learning, Zero-knowledge proof, differential privacy and many more. I have also created a summary table for these types along with their use cases.
If there is anything more to be added or make changes please tell me.
Also, I would like to create documentation for each type in much more details.
Thank you.

Thanks for the PR, please open an issue first for the same. Will setup some processes before we merge content on the website.

Thanks for the PR, please open an issue first for the same. Will setup some processes before we merge content on the website.

Okay, I will do it from next time. Or should I open an issue for this one as well.

Yes, please go ahead an open an issue for this PR.


SINGA-108 Add Python wrapper to singa

Currently, we want to add some wrappers for "driver.cc" and "driver.h" so that users can also train their data via python. In details, users can just import some python libraries of singa and call APIs within driver.h in a python style.

The commits are mixed up... some commits repeated (only one commit from chonho is shown)
could you please clean the commits or reapply your updates?

checkout from latest master
add swig part + main.py
finish your ticket for python binding
rebase to chonho's code
finish the ticket of python helper for job config

the cuda compilation part can be in a separate pull request with cudnn (I will send it later today).
thanks.

can you compress the commit msgs using git rebase -i , only keep important msgs.
e.g., the two msgs for reorgnanizing directories can be compressed, and the commits for adding and removing code from choho can be compressed.

wangwei@singa1:~/incubator-singa$ ./bin/singa-run.sh -exec tool/python/singa.py -conf examples/cifar10/job.conf
Unique JOB_ID is 138
Record job information to /tmp/singa-log/job-info/job-138-20151210-210113
Executing : tool/python/singa.py -conf /home/wangwei/incubator-singa/examples/cifar10/job.conf -singa_conf /home/wangwei/incubator-singa/conf/singa.conf -singa_job 138
Traceback (most recent call last):
  File "tool/python/singa.py", line 30, in <module>
    import singa.driver as driver
  File "/home/wangwei/incubator-singa/tool/python/singa/driver.py", line 28, in <module>
    _driver = swig_import_helper()
  File "/home/wangwei/incubator-singa/tool/python/singa/driver.py", line 20, in swig_import_helper
    import _driver
ImportError: No module named _driver
E1210 21:01:15.238301  5473 cluster_rt.cc:419] job 138 not exists


Uncaught Error: Cannot call function 'getPosition' on missing remote object 24Error: Cannot call...

[Enter steps to reproduce:]

...
...

Atom: 1.40.0 x64
Electron: 3.1.10
OS: Ubuntu 18.04.3
Thrown From: Atom Core
Stack Trace
Uncaught Error: Cannot call function 'getPosition' on missing remote object 24
Error: Cannot call function 'getPosition' on missing remote object 24
at throwRPCError (/usr/share/atom/resources/electron.asar/browser/rpc-server.js:145:17)
at EventEmitter. (/usr/share/atom/resources/electron.asar/browser/rpc-server.js:367:7)
at EventEmitter.emit (events.js:182:13)
at WebContents. (/usr/share/atom/resources/electron.asar/browser/api/web-contents.js:294:13)
at WebContents.emit (events.js:182:13)
At /usr/share/atom/resources/electron.asar/renderer/api/remote.js:219

Error: Cannot call function 'getPosition' on missing remote object 24
Error: Cannot call function 'getPosition' on missing remote object 24
    at throwRPCError (/usr/share/atom/resources/electron.asar/browser/rpc-server.js:145:17)
    at EventEmitter.<anonymous> (/usr/share/atom/resources/electron.asar/browser/rpc-server.js:367:7)
    at EventEmitter.emit (events.js:182:13)
    at WebContents.<anonymous> (/usr/share/atom/resources/electron.asar/browser/api/web-contents.js:294:13)
    at WebContents.emit (events.js:182:13)

    at metaToException (/usr/share/atom/resources/electron.asar/renderer/api/remote.js:271:17)
    at Object.exception (/usr/share/atom/resources/electron.asar/renderer/api/remote.js:219:30)
    at metaToValue (/usr/share/atom/resources/electron.asar/renderer/api/remote.js:223:28)
    at Object.remoteMemberFunction (/usr/share/atom/resources/electron.asar/renderer/api/remote.js:123:16)
    at AtomEnvironment.getWindowDimensions (/usr/share/atom/resources/app/static/<embedded>:1:705395)
    at AtomEnvironment.storeWindowDimensions (/usr/share/atom/resources/app/static/<embedded>:1:705810)
    at WindowEventHandler.handleWindowBlur (/usr/share/atom/resources/app/static/<embedded>:11:285354)

Commands

Non-Core Packages
atom-beautify 0.33.4
atom-html-preview 0.2.6
atom-ternjs 0.20.0
autoclose-html 0.23.0
busy-signal 2.0.1
csslint 1.2.0
emmet 2.4.3
hyperclick 0.1.5
intentions 1.1.5
language-ejs 0.4.0
linter 2.3.1
linter-eslint 8.5.5
linter-jshint 3.1.16
linter-ui-default 1.7.1
pigments 0.40.2
Sublime-Style-Column-Selection 1.7.5

Thanks for contributing!
We noticed that this looks like a duplicate of https://github.com/atom/atom/issues/16630 so you can subscribe there for updates if you'd like (we believe that this will be fixed in a future Electron upgrade).

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


exclude property path

sometime I might want to ignore properties only at certain level, eg:
expect({
  id: 123,
  a: {
    id: 345,
    b: "c",
  }
}).excludingPath(["a", "id"]).to.deep.equals({
  id: 123,
  a: {
    b: "c",
  }
})

do you think excludingPath would be useful ? I’ve worked around it for now by not testing some properties but I’d like to make a PR sometime if you think that would be useful

@mathroc I am closing this issue. Hope you have figured out the solution. If you want to reopen this issue feel free to do so. We can discuss further.


⚠ Remove ClusterVersion from vc-manager & native provisioner.

User Story
As a user I would like to reduce the overall components deployed for using CAPN w/ VC so I don't need to support deprecated provisioning routes.
Detailed Description
With the move to support CAPN, provisioning should be done outside of VC drawing a hard line between CAPN and VC, with this move we'll be able to get vc-manager and the controller-gen manifests back to being auto generated and easily consumed.
Anything else you would like to add:
This should help to remove cruft that made #62 and #63 hard to configured and causes user confusion.
[Miscellaneous information that will assist in solving the issue.]
/kind feature
/milestone v0.1.x

/remove-lifecycle stale
/lifecycle frozen


Sphinx -- Treadmill OSS initial documentation

Please merge pull-request: https://github.com/Morgan-Stanley/treadmill/pull/21 first

This needs to be squashed as well


pgpool building failing: libssl returns 404 not found

Tried quite a few of the docker-compose files and they all fail with:
ERROR: Service 'pgpool' failed to build: The command '/bin/sh -c install_deb_pkg "http://security-cdn.debian.org/debian-security/pool/updates/main/o/openssl/libssl1.0.0_1.0.1t-1+deb8u11_amd64.deb" "libssl1.0.0"' returned a non-zero code: 8

The link returns a 404.

@paunin opened PR #248 to fix this.


Remove files ending in ~

Editors are leaving files around ending in a ~ (example: index.html~). These files should be removed. To prevent this from happening in the future, you can add a new line to app/.gitignore after the node_modules line:
*~

deleted files with ~ and added *~ to .gitignore


APP force closes after install

is this version specific? I created the IPA but the app just force closes after install.

Device info? Sideload tool?
I've tested on FB v363.0 (latest) and it works fine

Device info? Sideload tool?

I've tested on FB v363.0 (latest) and it works fine. You can get it from my AltStore repo

https://qnblackcat.github.io/AltStore/

I'm using iPhone 12 Pro plus, and side loading with signulous.

Device info? Sideload tool?
I've tested on FB v363.0 (latest) and it works fine. You can get it from my AltStore repo

https://qnblackcat.github.io/AltStore/

I'm using iPhone 12 Pro plus, and side loading with signulous.

I did notice that I have to put the FBSideloadfix.dylib file on the Tweaks folder, if I don't do that I get an "Undefined symbols for architecture arm64" error message. I'm also using xcode 12.4 with its command tools on my Mac, I can't install anything newer as it's unsupported by my mac.
I notice a warning on the Making all for tweak FBSideloadfix portion of the tweak "make[2]: Nothing to be done for `internal-library-compile'."  I'm going to see if that may be causing the problem with app crash.

If you want to use the compiled dylib, then use it with a tool like Azule or Sideloadly.
If you want to use theos-jailed, then you DO NOT need to download the compiled dylib, because theos will compile the source code and gives you the dylib.

make[2]: Nothing to be done for `internal-library-compile'.

This is not an error. The compiler simply tells you that the source code has been converted into the dylib, no need to convert it again.


Added read methods

Added read methods for main heat state, main AC state, alternate heat
state, and target temperature type (heat/cool).

I'm not sure how to provide CircleCI with the environment variables that it needs to execute the tests properly.


Permit toggling of various checks via property file (assertj-swagger.properties)

This pull request is a first attempt to give assertj-swagger users a little bit of finer control on what assertions are tested. Changes outlined below.
@RobWin : happy to rework this as needed, to get this into sufficiently good state to merge. Looking, especially, feedback on whether you think I've gone about making these changes sensibly, and what could be improved.

Some simple toggles are added to turn various types of checks on and off (see SwaggerAssertionType). This is to work around imperfect normalization of definition attribute type checks that are referenced through $ref (however, some groundwork has been laid to rectify the latter)
Added a mechanism to resolve consumes and produces values (AttributeResolver inner class); this can be extended later to normalize type references through $ref, etc
Added a means to whitelist paths and definitions which are missing from the 'actual' schema -- this is to permit validating against a contract-first schema, where only some of the endpoints have actually been implemented.

Thx for your effort. I will definitely merge it. Could you please add a documentation of it in the README?

@RobWin: cheers!

I'll get to the README shortly and then ask you afterards to take another look at this PR.
In a separate PR, I'd like to rework definition attribute type validation to normalize the type definitions (by traversing local $refs). Do you have any thoughts on what you'd like to see done to make this useful and effective?


Gathered feedback

Recording the feedback received from Daniel and Phuntsok:

[x] smaller cross validation fold
[x] insert random state when in building model
[ ] Include confusion matrix, and report recall and precision.

Feedback received from Sayanti and Fan:

[ ] Combination of features.

[ ] Connection between EDA and results.

Regarding combination of features : Mentioned in future directions in the final report.

Regarding : Include confusion matrix, and report recall and precision, we will be addressing this in upcoming week.


Log4Net.Async dll not copied to output if library is unreferenced in code

If the Log4Net.Async library is only referenced in non-code (eg. a log4net log.config file), then the VS build process will not automatically copy the Log4Net.Async dll to the build folder for projects that reference other projects using Log4Net.Async. This occurs even if Copy Local is set to "True".
To get around this I created a dummy class whose sole purpose is to extend the RingBuffer class, without actually doing anything or being used anywhere at all.
A note about this in the documentation would be very helpful for those who are solely looking to wrap their existing appenders in their log config file.

Richard, in that case I will close this off then, thanks for checking. Even if it didn't there's not really much we can do to address it, it's almost an issue with MSBuild outputs.

Is there any code snippet/implementation on how to extend the RingBuffer class ?

@PoorDesigner why would you want to extend it?

I am using a shared library and Log4net async  is only referred in config.  I am trying to use the workaround that you mentioned
"To get around this I created a dummy class whose sole purpose is to extend the RingBuffer class, without actually doing anything or being used anywhere at all."

I think I understood  what  we need to do.  We need to refer the async library in the code somewhere so that the dll will be copied to output.  I'll try that.
Thanks

@PoorDesigner so I did, my apologies it's been a while since I looked at this stuff. There was an open issue this afternoon with a suggestion to add an Attribute that could be applied in an AssemblyInfo to force the compiler to reference the library. I pushed a new NuGet package this afternoon and I've just updated the Readme in the Notes section with how to use this.

when i try to use this in AssemblyInfo it gives me "Assembly generation failed as log4net.async doesn't have a strong name"

That's a different issue. I do not sign the Log4Net.Async assemblies so if you are signing your assemblies you won't be able to reference it without a work around.
http://stackoverflow.com/questions/331520/how-to-fix-referenced-assembly-does-not-have-a-strong-name-error

Yeah i looked through those. But i would like to know whether there is any chance of giving us signed one ? :)


Option to disable scroll to search

Basically, disable scrolling past the chat page and entering the search page. Currently, if you do that and go back to chat, the chat history is gone.

Hi @johan456789, thank you for the recommendation. This sounds more like something MS should fix, but I will try to see if there is a "hacky" way to disable the scrolling or preserve the chat history.

Currently, if you do that and go back to chat, the chat history is gone.

Chat history is preserved when using edge.
I should have said the main reason to disable the scrolling is to use bing chat just like chatGPT. Scrolling between search and chat is a feature for MS so they won't change it. I personally don't care about using bing search and just want to use the chat.

Just a noob who wanted to use Bing with Firefox and is grateful to be able to do so bc of this project... and I post here bc i have an issue related to this. I cannot scroll back up the thread of "conversation" I have had with Bing, and thus I lose much of any response that is more than 10 lines or so. Mysterious and frustrating. ANy thoughts?

I am using Chromium, and the chat history persists when I scroll back up. Is anyone having issues with chat history disappearing?

I'm using Chrome and the chat history is preserved now.


Fix document comments in code blocks to multi-line comments

What is the purpose of the change
Comments in code blocks should be multi-line comments, not documentation comments
Brief changelog
1.dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
Verifying this change
Passed unit tests
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #5573 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5573      +/-   ##
============================================
- Coverage     61.24%   61.14%   -0.11%
+ Complexity      425      423       -2
============================================
  Files           922      922
  Lines         37504    37504
  Branches       5432     5432
============================================
- Hits          22971    22932      -39
- Misses        12053    12084      +31
- Partials       2480     2488       +8

Impacted Files
Coverage Δ
Complexity Δ

...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java
63.77% <ø> (ø)
0 <0> (ø)
:arrow_down:

...rg/apache/dubbo/remoting/utils/PayloadDropper.java
30.76% <0%> (-15.39%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyServerHandler.java
59.09% <0%> (-9.1%)
0% <0%> (ø)

.../dubbo/remoting/transport/netty4/NettyChannel.java
61.38% <0%> (-6.94%)
0% <0%> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
62.06% <0%> (-6.9%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyClientHandler.java
59.32% <0%> (-6.78%)
0% <0%> (ø)

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0%> (-5.67%)
0% <0%> (ø)

...ng/exchange/support/header/HeartbeatTimerTask.java
73.68% <0%> (-5.27%)
0% <0%> (ø)

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0%> (-5.27%)
0% <0%> (ø)

...e/dubbo/remoting/transport/netty/NettyChannel.java
55.68% <0%> (-4.55%)
20% <0%> (-1%)

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16f1fad...98f0075. Read the comment docs.


Add An Luong Dong High School

Add An Luong Dong High School: http://thpt-aldong.thuathienhue.edu.vn/

@TerryTran Pull request merged. Thank you!


Add in section about the schedules display tab in Azure Devops only shows 7 days or increase the diplay time.

If I am to set my cron schedule to 0 0 1 * * (Run once a month) below and commit my yaml to azure devops repo. If the next execution time is more than 7 days away, I cannot easily verify the scheduled run on the website. Confirming it's scheduled to be run.
Can either the schedule page be updated to display all scheduled runs or add in some documentation to say that it only shows 7 days.
I should be able to verify the pipeline is scheduled at the right time and the right date.
Without displaying anything I get the impression that it's failed to read my schedule.
Schedule (I've listed a 0 0 * * *) so it shows 7 days as an example.

If I am to set this to 1 month - '0 0 1 * *', which is greater than 7 days from now. It does not show anything, as the next schedule time is greater than 7 days.
Yaml:

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2ea2c851-bd1e-cddc-b4d0-e9f4112b8565
Version Independent ID: 07c23fdd-14b5-985b-1c63-3f26f3a216ad
Content: Configure schedules to run pipelines - Azure Pipelines
Content Source: docs/pipelines/process/scheduled-triggers.md
Service: azure-devops-pipelines
Sub-service: azure-devops-pipelines-process
GitHub Login: @steved0x
Microsoft Alias: sdanie

@KeysAU -- Keith, thank you for your thorough feedback.  For the product-related suggestions, please add them here:

Developer Community

@steved0x -- Steve, please look into the possible documentation aspects of this issue.

Thank you for letting us know. I can verify this and I have added a note to the documentation to indicate this, which will be live later today. To file a feature request to increase the scheduled runs view interval for longer than 7 days, please file a feature request here: https://developercommunity.visualstudio.com/AzureDevOps


minor tracker fixes for complete* examples

What does this PR do?

with_tracking was failing for complete example scripts with error / in name of the run (logs/complete_... was being used as run). This fixes it.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Updated Contributors.md

Updated the Contributors file.

@SiddharthMahapatra12, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?
We’ve added a tweet feature to our web app recently. Can you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Thank you sir, for presenting an opportunity for beginners like me through your repo. It has & will enable a lot of newbies to get started on their open-source journey. Thank you again.

@SiddharthMahapatra12, Please don't call me sir.
I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://firstcontributions.herokuapp.com


Give the user clearer feedback that results are being loaded

Right now, the text of the search button changes to "Searching...", but this turns out to be not clear enough.

How did you find out it isn't clear enough? Do you already have an idea on how to make it clearer?

Jeroen noticed this - he initially did not see that the "Search" button had changed text. Perhaps this can be done using a "searching" text above the results, it does not have to be anything fancy, I guess.


Moving the window causes panning

This is an SDL2 bug that will be fixed in future versions: https://bugzilla.libsdl.org/show_bug.cgi?id=2842


SelectedValue on ComboBox throws Xamlll exception in debug mode

Describe the bug
A null reference exception is thrown when a ComboBox is bound with SelectedValue only when run with the debugger.
The combobox does what it should and the value is updated.
stack:-
CompiledAvaloniaXaml.XamlIlHelpers.AvaloniaComboBoxRepro.ViewModels.MainViewModel,AvaloniaComboBoxRepro.Value!Setter(Object , Object )
To Reproduce
Steps to reproduce the behavior:
AvaloniaComboBoxRepro.zip
run the repro in debug mode, the exception should be thrown.
Expected behavior
No exception
Environment

OS: Windows 10
Avalonia-Version: 11.0.2 11.0.5-rc1 11.1.999-cibuild0040934-beta

I guess what happens is, that during loading the SelectedValue is null. The issue is solved for me if I make the bound property int? instead of int. Would that help you?
Also I think if it is only happening during debug mode, you probably can safely mute the exception and the program should continue normally.

This does not stop my code working and is really just an annoyance, I reported it as it possibly indicates there should be a null check somewhere to prevent an exception being thrown and swallowed.
Thanks for the int? suggestion but that would be a bit messy in my code.

I ran across this issue as well and it does always throw an exception during debug. So I wouldn't really say "does not stop my code working" since it causes a crash.
There is an issue in the property store or binding system here. Null should not be assigned for non-nullable types. Instead default(T) should be used. There is definitely a bug some place.

@robloo the issue is still open for that reason. The binding system is currently under development. After that, this issue should be revisited.


Locust test results

Hello, I tested the POST interface with Locust. As a result, is there something wrong with me?

`from locust import HttpLocust,TaskSet,task,Locust
class WebsiteTasks(TaskSet):
@task()
def go(self):
header = {'Content-Type': 'application/json',
'Authorization': 'eyJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJCTUtQIiwidiI6MSwasdiMTM2IiwiaWF0IjoxNTAxNDadJjbGFpbXMiOnsicm9sZSadaXZlciIsInBob25lIjoiMTU4Mjc2MjgxMzkiLCJ0eXBlIjoiYW5kcm9pZCIsInZlcnNpb24iOiI0LjAuMCJ9LCJhZG1pbiI6ZmFsc2UsImV4cCI6MTUwMjc3NzI5NH0.k-Con5IkURvaus-HXkxVY5w6ihaHzMNmlLb77IrQyNE'
}
    self.client.post("/wyc/v400/zebra/walker/setPos",header, {
                "speed": 0.0,
                "orderId": "421",
                "walkerPhone": "15827631231",
                "latitude": "30.478699",
                "deviceKey": "3a4fe19f001fdf30",
                "longtitude": "114.427418",
                "drvId": 58,
                "direction": 0
            })

class WebsiteUser(HttpLocust):
task_set = WebsiteTasks
host = 'https://xx.xx.xx'
min_wait = 1000
max_wait = 2000`

I don't understand your question, what are you asking?

If you're not getting the performance you're expecting (I'm guessing here) I must refer you to this note from the documentation:

You can't use Locust on Windows to perform any real test with many users. You could maybe get a decent performance if you run it through Docker on Windows (though I have not tested this).


Differentiate developer install and usage install

 pip install -e .[dev]
Is dev optional here? What is the right command for someone who just wants to install pd-sdk and not for development?

Yes dev is optional and only needed if you want to contribute to PD-SDK. For general usage pip install -e . or even pip install . will do.


inttypes.h-style printf format strings for common types

Is your feature request related to a problem? Please describe.
For Message ID's, cFS generally use 0x%08X but sometimes it's printed with 0x%08x (lowercase a-f), or without the 0x, or even as %d or %u. (Although I don't know if that's used anymore.)
Describe the solution you'd like
Per https://en.wikipedia.org/wiki/C_data_types#Printf_and_scanf_format_specifiers C99 added printf format string macros for int types and it would be keen to follow this practice. I suggest PRIxMSG or PRIdMSG for printing (generally, sending an event message) a message ID in hex or decimal (defined as "0x%08X" and "%u" for unsigned integer (32-bit) MsgIds. So instead of:
...SendEvent(..."Error: unable to process message (MsgId=0x%08X)", MsgId)
it would be:
...SendEvent(..."Error: unable to process message (MsgId=" PRIxMSG ")", MsgId)
Describe alternatives you've considered
Leave well enough alone...:D
Additional context
Add any other context about the feature request here.
Requester Info
<EMAIL_ADDRESS>

I've found that inttypes.h isn't really available for use in VxWorks 6.9 DKMs though...


Make code more readable; remove misleading function arguments and add necessary ones

In the previous version, the main function assigned year=2011 and then called build_co2_totals() with this year.
Two problems, first, the year 2011 is only used for certain data fetching functions and not as base year for emissions where year=1990 is used instead. I split these two hard-coded value into two variables. Second, build_co2_totals() is not using its argument year at all. I removed it.
Furthermore, build_energy_totals() is dependent on specific variables being set and I hence added the required function arguments (eurostat, swiss, idees).

Clarification: the proposed changed do not lead to any changed behaviour just make the code easier to read and more future proof.

Great, thanks for the code clean-up @leonsn !


Stub staking support for pcli

WIP code following #321 that tries to map out required internal functionality for staking by sketching an external interface via pcli.

I think it would make sense to go through this, create a list of unfinished chunks of work, and then merge it as a skeleton for filling in that work.

Closes #275.

Closes #49


Allow to compare arbitrary commits from the commits page

By commits page, I mean the commit list at http://gogs.example.com/user/repo/commits/branch.
It would be neat to select a commit range and get a diff for it.

Thanks your feedback!

This would be really nice, Github has a little publicized feature to do this by visiting /compare path for any repo.  Github doc at https://help.github.com/articles/comparing-commits-across-time/.

This is also similar to https://github.com/gogits/gogs/issues/3080 which has to do with comparing tags/releases.


Contour plot, Contour band and Dot plot updates

[x] Contour plot update related to isolines (Resolves issue https://github.com/UniStuttgart-VISUS/uadapy/issues/3)
[x] Extension of isoline changes to other functions
[x] Implementation of contour bands
[x] Implementation of dot plots

Note that the branch was deleted, please do not continue to work on this branch. Also, please update your branches with current master.


User+App delegated Access token is stored in static variable which could be shared by users

Please correct me if I am wrong but it looks like a User+App delegated Access token is acquired in Startup.cs and it is stored in a static variable. Will this static variable be shared by all users.
AuthenticationResult result = authContext.AcquireTokenByAuthorizationCode(
code, new Uri(HttpContext.Current.Request.Url.GetLeftPart(UriPartial.Path)), credential, graphResourceId);
AuthenticationHelper.token = result.AccessToken;
So will usersA's access token be used by UserB?
I see that the UserProfileController uses the user's token from NaiveCache but other controllers like ContactsController use the static token in GetActiveDirectoryClient(). Is there a reason why the token is not obtained from NaiveCache?

From a sample point of view, we show you how to get a token using ADAL, refresh tokens or get a new token for new users. You can change the behavior according to your scenario.


fix(curriculum): move RDBMS cert to proper order

This moves the Relational Database cert to right after the Data Viz. In order to do this I...

Added 1 to the order in all the meta/{superBlock}-certificate/meta.json files from API's and Microservices on. This is the certificate order.
Added 1 to the superOrder in all the meta/{block}/meta.json files for all blocks from API's and Microservices and on. This is the order of the superBlock each block belongs to.

Side addition: In all the meta/{superBlock}-certificate/meta.json files, I change the superOrder to 0. This is the certificate superblock and is not shown anywhere. Changing it to zero should keep it from getting in the way in the future. I didn't see any issues with it.
You will need to set showUpcomingChange to true in the .env to see it. Everything seems to be working whether or not they are shown.
Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Related to #42509

I am quite confused why this test did not fail

Pretty sure it's cause the cert is an upcoming change - so it does not get loaded for the tests.


Suggestions aren't being sent occasionally on startup

Details TBD. It could be related to a recent rewrite but logs and details need to be collected when it happens.

Should be fixed by #9961


feat(rerouting-static-obstacle): rerouting static obstacle using a selected point by the user

Description
closes #4523

Related links
Discussion / Idea
Issue
autoware_launch PR

Tests performed
Using planning simulator :

let the reroute static obstacle point publisher plugin appear for ease of use
select a point through the route of the vehicle
if alternative route is available, vehicle should be able to change route and does not go through the selected point.

This video demo shows this testing procedure.

Notes for reviewers

Please follow the same procedure as show in the video above for testing
:exclamation: This PR mush be tested and merged with autoware_launch PR :exclamation:

Interface changes
N.A.

Effects on system behavior
Autoware will be able to reroute for road blockage based on input from the user (human driver/operator)

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Enable review by ChatGPT. Sorry if this is too noisy.

Thank you for implementing this useful feature. And sorry for the very late review.  I would be happy if you could follow this branch to the main.
I checked that a reroute similar to your video was possible.
But on the contrary, I cannot reroute when the following route is drawn. Do you know what the cause is?

https://github.com/autowarefoundation/autoware.universe/assets/39142679/5235ccd1-9830-4b5b-ba05-8292b2d10c08

@ahmeddesokyebrahim could you resolve the conflicts for this PR?


Cannot import in ember CLI

When trying to export the component using
import EmberRadioButton from 'ember-radio-buttons';

export default EmberRadioButton;

I get the error
Uncaught Error: Could not find module ember-radio-buttons

I will manually add the source code in for now.

Nevermind, restarting the server fixed it.

:+1:

Hi @mansona  and @mihai-scurtu
I was using an older version of the addon, I updated to 3.0.1 to be able to set the disabled property. But I am having the same problem. I created a component using 'ember generate component radio-button' and add the code you put in the README in the component, but I am getting the same error.
I restart the server... reinstall npm modules....
Thanks in advance,
Daniel.

+1 "Nevermind, restarting the server fixed it."


Choice of License

I think we can keep our license as is (i.e. MIT license). Because we want to be able to openly distribute our package, an MIT license would be appropriate.
We could also consider a GNU General Public License. This is similar to a MIT license, except those who use our package must also make available their source code.

Agree. We can stick to MIT License.

I agree that we keep using MIT license. Other the reason Andrea already stated, MIT license is probably one of the most widely used licenses so potential contributors and users should all be pretty familiar with its terms. Thus, they do not need to spend much time deciding whether they will be okay with our license.

I also agree with keepin the MIT license. As Xinwen mentioned, it is the most well known licenses


rowan build script fails

Here is the tail end of running
./newBuild_rowan
topaz 1>
topaz 1>   commit
Successful commit
topaz 1>
topaz 1>   run
  | packageManager repo |
  packageManager := CypressPackageManager3 new.
  repo := CypressAbstractRepository
    onUrl: (CypressUrl absoluteFromText: 'tonel:/foos2/users/ewinger/GsDevKit_home/shared/repos/Rowan/src/tonel/'  )
    alias: ''.
  packageManager
    defaultSymbolDictionaryName: #'UserGlobals'.
  #('Cypress-Core' 'Rowan-Url' 'Rowan-Core' 'Rowan-GemStone' 'Rowan-Cypress' 'Rowan-Tests' 'Rowan-Tode')
    do: [ :packageName |
      packageManager
        addResolvedReference:
          (CypressResolvedReference name: packageName repository: repo) ].
  packageManager loadResolvedReferences
%
ERROR 2710 , a CypressAddition(add: a CypressMethodDefinition(TDRowanTool class>>initialize)) failed because a MessageNotUnderstood occurred (error 2010), a UndefinedObject does not understand  #'repositoryTools' (CypressLoaderError)
topaz 1>
topaz 1>   run
  Rowan addProject: (STON fromString: (GsFile openReadOnServer: '/foos2/users/ewinger/GsDevKit_home/server/stones/test_rowan_340/rowanSpec.ston') contentsOfEntireFile)
%
ERROR 2010 , a MessageNotUnderstood occurred (error 2010), a UndefinedObject does not understand  #'image' (MessageNotUnderstood)
topaz 1>   commit
Successful commit
topaz 1>   exit
Logging out session 1.
--- 03/08/2018 17:12:06.412 PST Logging out
**Error on or near line 64 :: startTopaz test_rowan_340 -l :: startTopaz test_rowan_340 -l**
ewinger@foos:/foos2/users/ewinger/GsDevKit_home/server/stones/test_rowan_340$

Good ... there's the initialize error and the project spec for Rowan
(which you don't need) is failing it's load ... presumably everything
else is loading without error ... need to fiddle the topaz scripts and
figure out the initialization failure ...

Reply to this email directly, view it on GitHub
https://github.com/dalehenrich/Rowan/issues/6, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmFT7kJR_qQT6M6i21WA5XB3pO5lGKBks5tcddpgaJpZM4Sjmgo.

After running the new build, I realized I forgot to update from git first. But this result was unexpected.
ewinger@foos:/foos2/users/ewinger/GsDevKit_home/server/stones/test_rowan_340$ git pull origin master
From https://github.com/GsDevKit/GsDevKit_gs_server

branch            master     -> FETCH_HEAD
Already up-to-date.
ewinger@foos:/foos2/users/ewinger/GsDevKit_home/server/stones/test_rowan_340$

you updated git in the wrong spot ...
cd $GS_HOME/shared/repos/Rowan
git pull origin master

How hard would it be to make both of those commands work from the same directory?
Since I'm for-git-ful and git-nor-ant, it's hard to keep little details like this straight.

I would suggest that you create a bash script or alias:
pushd $GS_HOME/shared/repos/Rowan
git pull origin master
cd $GS_HOME/server/stones/test_rowan_340
./newBuild_rowan
popd

I've done that. That's useful as long as updating Rowan remains stable.

For what definition of stable?

Well, horses live in stables and there is a lot of manure in stables.
Since I like horses, I'm ok with a few smells. :)

When we get to the point where we can use Rowan to update Rowan, there will be a new script for updating an existing stone.
The newBuild_rowan script will be kept around to reload Rowan into a fresh image ... so your script should be good until Rowan reaches the point where it no longer relies on tODE and I've created .gs files for bootstrapping Rowan

see this script for instructions on picking up the updates for this issue


About RefreshScopeRefreshedEvent

I found that the propagation of any RefreshScopeRefreshedEvent event will cause Eureka to restart. I think this is unreasonable. The event object already contains the name of the configuration object refreshed. You should check whether this name belongs to you before restarting.

@OlgaMaciaszek Hi, is there any update?

Hi @shawnplay, I hope we'll be able to discuss this at today's team meeting. Will post any updates here.

Hi @shawnplay  - what is your specific scenario here? Please provide more detail or some code snippet of how you would like to use the name in your usecase.

I am using hot update of spring config, but this event is triggered, causing my eureka instance to experience a brief restart

We are still not sure, how you propose to handle this event based on name (against what to check the name of the event). Do you have any suggestions?

I want to know, why do I need to listen to the RefreshScopeRefreshedEvent event and then re-register the Eureka instance?


conditional header

Description
While reviewing notebooks in collections, noticed header could be better
Review Instructions
Test new header with notebooks on (and off)
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5123
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that your code compiles by running npm run build
[x] Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
[x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[x] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[x] Do not use cookies, although this may change in the future
[x] Run npm audit and ensure you are not introducing new vulnerabilities
[x] Do due diligence on new 3rd party libraries, checking for CVEs
[x] Don't allow user-uploaded images to be served from the Dockstore domain
[x] If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
[x] Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

This reminds me, when I was looking at notebooks this morning, we need to add the feature flag for hiding notebooks in collections:

The notebooks card is also missing the notebooks icon.  I'll make a ticket for this and actually pick it up with my current notebooks changes


Allow to undo TextEdit.set_text

Closes #20691
With this, set_text() is registered as "complex operation" for undo if undo is enabled, so after doing e.g. $TextEdit.text = "some text" you can return to previous text with CTRL + Z. It might be considered a minor compatibility breakage, since you need to call clear_undo_history() after setting text to keep old behavior. Also cursor moves to the end of the text now, instead of going to beginning after changing text (that change is rather debatable).
I also cleaned set_text() a bit, as it was doing many unnecessary operations already done in _clear().

I thought that with this change it will be trivial to fix #26325, so I wanted to make another PR. But seems like this change is actually remove-one-line-trivial, thus I made an update and added it here.

If undo is not enabled the cursor will be set to the start of the line, as compared to the end.

But this is how it works originally. Should I change it?

If undo is enabled the selection is still active.

Fixed.

But this is how it works originally. Should I change it?

Yeah, it's better to be consistent, and as you mentioned, it's a harmless change.

Ok, done.

Might be an idea to also apply the reload_text fix to text_editor as well.

Done.

Thanks!


Fix vector magnitude caching

A typo in Vector.magnitude() was preventing it from returning the cached value

Fancy adding a test to prevent this from happening again?

Not sure how I'd write a test for this since the method returns the correct value. I guess you could compare execution time between the first and subsequent calls, but that seems fragile.

I guess that its output isn't covered by any of the existing tests is the problem.

I think it's covered here: https://github.com/olivernn/lunr.js/blob/master/test/vector_test.js#L3

Ah yes, but not the caching. Oh well! I'll go back to sleep now :sleeping:

I saw that yesterday as well, but also noticed another thing: The insert method doesn't invalidate the cache when it adds new Nodes.
Maybe that's ok, since Vectors seem to be mostly one-use, but in cases where they might not be, the typo actually prevents stale cache issues.

Thanks @satchmorun. I've added cache invalidation to Vector.insert() and a corresponding test.

Tpying is hrd! Good spot, wish there was a better way to prevent my fat fingered mashing of the keyboard resulting in bugs like this, any ideas?
https://www.youtube.com/watch?v=OqjF7HKSaaI
I've released version 0.5.8 with this change in, let me know if there are any issues, and thanks again for the pr.

Haha, easily done. Caching code isn't exactly easy to test. :)
We could try something like this (not tested):
var cached = function (key, func) {
  return function () {
    if (this[key]) return this[key]
    return this[key] = func.apply(this, arguments);
  }
}

lunr.Vector.prototype.magnitude = cached('_magnitude', function () {
  var node = this.list,
      sumOfSquares = 0,
      val

  while (node) {
    val = node.val
    sumOfSquares += val * val
    node = node.next
  }

  return Math.sqrt(sumOfSquares)
})

However it doesn't prevent typos in the invalidation code (e.g. this._magniture = undefined) and it makes the code harder to read. Personally, I think the risk of a typo in the caching code is the lesser of two evils.


S3CrudPolicy does not allow for specifying a bucket prefix

Description:

I would like to create a SAM application that writes to only a specific prefix within a bucket and thus only have CRUD access to that bucket prefix.
Steps to reproduce the issue:

Create a SAM application that writes to an S3 bucket (see below)
Try to pass the bucket/prefix to the S3CrudPolicy "BucketName" argument
Try to create a SAM application using that file and you will get an error with invalid argument being passed to BucketName.

Policies:
        - S3CrudPolicy:
            BucketName: !Sub '${bucketName}/${bucketPrefix}'

Observed result:
SAM application cannot be created due to an invalid argument being passed for bucketname
Expected result:
BucketName under the S3CrudPolicy should accept any valid s3 ARN (such as bucket/prefix) but instead it only operates in entire buckets.

This might be user error, closing it for now.


Please upgrade angular dependency to 1.7.*

Angular ≤ 1.7 is going to be unmaintained until 7/1/2018 (https://docs.angularjs.org/misc/version-support-status). Could you please update your library to support angularjs-1.7.x (LTS) ?
Regards,
Xavier

I've tested examples/index.html with angularjs-1.7.2, it works. But note that I can't rebuild package due to unmaintained dependencies

Is this project maintained or abandoned ?


Fix TNT not damaging blocks

Hi,
I noticed whilst using this plugin that TNT explosions also wouldn't break blocks, so I added a little check to see if the entity creating an explosion was a creeper and that seemed to fix it. Haven't done any extensive testing other than making sure creeper explosions still don't break blocks and that TNT explosions do.

Thank you so much for the contribution!


bufferedMQF_integration failed to build

I'm trying to build the bufferedMQF_integration branch alone to assure it has no problems before merging to the development and I got this error.
https://github.com/dib-lab/kProcessor/blob/c6641b8a065a047568bedb3c1580b8bd8f8b9b2e/include/kProcessor/kDataFrame.hpp#L576
This line is causing the build to fail. Consequently, the development branch is also failing.
kDataFrame.hpp:576:5: error: ‘bufferedMQFIterator’ does not name a type

@shokrof  If this a real bug, please fix it on its own branch.
You don't need to merge again to the development I created another branch called fix_merge containing the devel + kDataFrameMultiColumns + development before merging.
So, after you fix this issue I will manage to merge all to the development branch.
Thanks ^^


Greenkeeper/webpack 4.0.1

Coverage remained the same at 99.579% when pulling eae53cda72209def9b716d721d5a035be2db07ea on greenkeeper/webpack-4.0.1 into 4586fc3e9db7c68a4e310f39a1171d9e1018ee6f on master.

Coverage remained the same at 99.579% when pulling eae53cda72209def9b716d721d5a035be2db07ea on greenkeeper/webpack-4.0.1 into 4586fc3e9db7c68a4e310f39a1171d9e1018ee6f on master.

Closing this in favor of #170


Moved duplicate adr 0009

Signed-off-by: Tom Runyon<EMAIL_ADDRESS>Description
Duplicate ADR 9s.  This moves the older 9 to 10 to keep ordering
Related Issue
Fixes #
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[ ] Test, docs, adr added or updated as needed
[ ] Contributor Guide Steps followed

Closed, fixed in #1144


Add tests exercising the optimization passes

This PR adds a test exercising the standard optimization passes of LLVM (i.e., -O0, -O1, ...)
It supersedes #57.

@kyouko-taiga Any reason not to merge this?


default setup in init.robot cause exception

I put 4 files in test cases dir like the following:

the content in function1.robot  is like the following
*** Settings ***

Library  function1.py   WITH NAME  F

Library  function1.c1   WITH NAME  c1

*** Test Cases ***

add order - 00001

  c1.teststeps

the content in __init__.robot is like the following
*** Settings ***

Library  __st__.py   WITH NAME  D

Suite Setup    D.suite_setup

Test Setup    D.test_setup

so, when I run test, robotframework will call suite setup and default setup before executing the case add order - 00001.
But robot could run suite setup successully, while run default setup failed and report No keyword with name 'D.test_setup' found.

also,  the whole test cases directory attached.
cases.zip

Having test setup/teardown in suite init file is supported, but it only specifies the keyword to use. That keyword then needs to be available where that setup is actually executed. In other words, you need to import the library D in the test case file or in a resource file imported by that test case file.
Could you check what the User Guide says about this and could it be enhanced?

I get it.
But imaging if we have multiple levels suites with multiple test setup, we need to import every neccery libraries in very test cases file carefully.
Could RF be enhanced to be free from that limitation? That would be really convinient.

Could you clarify what exactly is the problem of test case files needing to import libraries they use? Do you have concrete idea how RF should be enhanced? If we agree on that, are you interested to provide a pull request?

Because test case file does not use default setup explicitly, I mean there is no any keyword from that library you could find in test cases file.  Developer need to check what libraries are used for default setup in test case file carefully.
Sorry I'm not familiar with the source code of RF. So I could not modify it for now.
Anyway, RF it great, and has really help me a lot already, Thank you.

In my opinion the confusing feature is being able to specify default test setup/teardown in higher level suites in the first place. The fact that the setup/teardown keyword then needs to be available in the suite where it is actually used isn't that strange in my opinion. It also means that you can specify some setup/teardown name in an init file, and in different files in that same directory import different resources/libraries so that the actually executed keyword is different.
Anyway, this logic won't be changed.


[LUIS instrumentation] Include emulator scenario x version identifier in User-Agent header on all calls to LUIS APIs

Is your feature request related to a problem? Please describe.
Today, we do not have any view into LUIS traffic that are driven by botbuilder. LUIS service instruments all calls to the service and can report on User-Agent to identify the specific client.
Describe the solution you'd like
On all calls to LUIS service (from the inspector including login, train, publish as well as reassign intent), include User-Agent header with the following value -
botbuilder/emulator/inspector/major.minor.patch.build
botbuilder/emulator/list-luis-apps/major.minor.patch.build
[enhancement]

Should this be limited to just LUIS api calls? It might be appropriate to include user agent headers for all external traffic.

What are the requirements for this item?
While investigating this, I found out that Electron already appends BotFrameworkEmulator/<version> to the user-agent string.
If that's not sufficient, I also found a way to attach a custom user agent string to all outgoing traffic from the Emulator, but I'm wondering if we want a different string corresponding to the LUIS / QnA endpoint that is being hit. Or can we just include all the custom strings on every request?
Can LUIS & QnA just group the data on their side by the endpoint that was hit?
Ex.

Luis receives 200 requests at /api/.../train with user-agent: ... BotFrameworkEmulator/4.1.0 so they can determine that users made 200 calls to train from the emulator.

Or do we need to include a specific string for each endpoint so that they can look at all the incoming requests across all their endpoints, and derive the action from the user-agent string?
Ex.

Luis receives 200 requests with user-agent ... BotFrameworkEmulator/4.1.0 botbuilder/emulator/luis-train/4.1.0 so they can determine that users made 200 calls to train from the emulator

Fitting a custom user-agent string to each outgoing request from the emulator seems cumbersome.

@tonyanziano - this is a broader effort across the SDK, CLI tools and Emulator and so we need the user-agent to be of the following format (I've also posted in the respective LUIS and QnA Maker tickets)
botbuilder//<lang.or.scenario>/
So for Emulator, we would do the following
LUIS
botbuilder/emulator/inspector/major.minor.patch.build
botbuilder/emulator/list-luis-apps/major.minor.patch.build
and for QnA Maker
botbuilder/emulator/inspector/major.minor.patch.build
botbuilder/emulator/list-qnamaker-apps/major.minor.patch.build
We also do not need to include any additional information in the header. The specific command/ endpoint is instrumented and reported on both LUIS and QnA Maker side.

Addressed in #1092
===
There is no easy way for us to distinguish between calls made from the inspector, and calls made from the services flow without going into each call and adding on a custom user agent string, which would be tedious and fragile as the emulator grows. For now we will just add a custom user agent string of botbuilder/emulator/version to all outgoing requests.


Issue with k8s.io/docs/setup/independent/create-cluster-kubeadm/

This is a...

[ ] Feature Request
[x] Bug Report

Problem:
These statements are confusing about the ordering of steps:
"first choose the pod network plugin you want"
... "You need to choose a Pod Network Plugin in the next step."
Proposed Solution:
Make very clear the chicken/egg relationship:
"Before running kubeadm init you must select one of several available network plugins to use in your deployment. Having selected which network plugin you plan to use, this will determine which if any arguments will need to be passed to kubeadm init in order to make the deployment compatible with that network plugin. kubeadm init will be run with those arguments first. Then immediately after you will need to then run a further command to actually install the network plugin. Details on network plugins and their installation are shown below."
Page to Update:
https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm

the bellow paragraph available at:
https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm

You need to choose a Pod Network Plugin in the next step. Depending on what third-party provider you choose, you might have to set the --pod-network-cidr to something provider-specific. The tabs below will contain a notice about what flags on kubeadm init are required.

seems sufficient in terms of details to me, yet perhaps i have a slightly different perspective.
comments from @kubernetes/sig-cluster-lifecycle-bugs ?
WDYT about the suggestion from @bboreham ?
/sig cluster-lifecycle

My complaint is not just about the level of detail; the statements I quoted are contradictory.
It's either the first step or the next step; can't be both.

https://kubernetes.io/docs/setup/independent/create-cluster-kubeadm/
was overhauled in 1.11.
/close


fix: dark less

ref: https://github.com/ant-design/ant-design-dark-theme/pull/21#discussion_r386104287

antd 版本也需要升级上来了。


Porting to React

The library looks great, any plan porting eleme to React?

We don't have such plan.


Introduce CLIF (cranelift ir) for optimization

Some useless files were also deleted. But there is still a lot of work to be done, so let’s finish it in the PR later.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

#39


Change getters and setters into virtual attributes

Change the getters and setters of all classes into virtual attributes.
That is, users can change properties (including pos, color, etc) using attributes.

Completed in the virtual-attributes branch.  Still needs to be merged to master.

Merged into master and closed.


i am trying to convert heic image into jpeg

source: bad seek to 41473\nheif: Unsupported feature: Unsupported codec (4.3000)
in AWS Lambda I don't want to install other dependencies globally
is there any solution?
my aim is just convert image heic to jpeg

The prebuilt binaries provided by sharp do not provide support for the patent-encumbered HEIC format so you'll need to find an alternative solution.