[FEATURE] Preprocessing of HO operators

If we want to support fold-like operators, see #693, we have to fix the preprocessing phases, so they do not destroy higher-order operators that are passed as arguments to the built-in operators. Consider the example from #693:
SumAddressesWithFold(Addrs) ==
  LET Iter(sum, addr) == sum + banks[addr] IN
  FoldSet(Iter, 0, Addrs)

In the current implementation the operator Iter disappears, leaving the model checker with an undefined argument to FoldSet. Instead, for every call SumAddressesWithFold(A) the preprocessing phases should produce something like follows:
FoldSet(
  Lazy(LET Iter(sum, addr) == sum + banks[addr] IN Iter),
  0,
  Addrs)

Here, Lazy is a made-up operator that tells the preprocessing steps not to inline the operator Iter. Actually, the expression inside of Lazy(...) is not a syntactically correct TLA+ expression. However, the same pattern occurs in case of LAMBDAs, so we have to add such a partial support for passing operators by value.

As far as I remember, this is about how it is implemented by @Kukovec. Closing this one.


Using --split-chapters option crashes | Error opening input files: Invalid argument

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running yt-dlp version 2021.03.15
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

PASTE VERBOSE LOG HERE
...@...:~$ .local/bin/yt-dlp --extract-audio --audio-format mp3 --split-chapters -v https://www.youtube.com/watch?v=0HbnqjGirFg
[debug] Command-line config: [u'--extract-audio', u'--audio-format', u'mp3', u'--split-chapters', u'-v', u'https://www.youtube.com/watch?v=0HbnqjGirFg']
[debug] Loading archive file None
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] yt-dlp version 2021.03.15
[debug] Python version 2.7.17 (CPython 64bit) - Linux-5.4.0-67-generic-x86_64-with-Ubuntu-18.04-bionic
[debug] exe versions: ffmpeg 3.4.8, ffprobe 3.4.8
[debug] Proxy map: {}
[youtube] 0HbnqjGirFg: Downloading webpage
[debug] Sort order given by user:
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] Downloading format(s) 251
[debug] Invoking downloader on u'https://r1---sn-8qu-t0ay.googlevideo.com/videoplayback?expire=1616125001&ei=6cdTYOilKpLohgblu4rQCw&ip=<IP_ADDRESS>&id=o-AFqc9cPE05-aKpUfrhJvnsGZTP3N8flcdzpHm-puIRMa&itag=251&source=youtube&requiressl=yes&mh=uk&mm=31%2C29&mn=sn-8qu-t0ay%2Csn-t0a7sn7d&ms=au%2Crdu&mv=m&mvi=1&pl=18&initcwndbps=1633750&vprv=1&mime=audio%2Fwebm&ns=ZRXHAfcuIkF3czU0URJPofwF&gir=yes&clen=71145566&dur=4056.441&lmt=1612599122284797&mt=1616103159&fvip=1&keepalive=yes&fexp=24001374%2C24007246&c=WEB&txp=5431432&n=OCnWfbTvx58evtY-Pz&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cvprv%2Cmime%2Cns%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRQIhALusYeZSeG9V4pig2jh2JNThlLvJ4ajzKP-MeImH1CbPAiAaM16hERIft2DRHd2lwSTec2533mStSSbbDYGhrl_OEw%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRQIgfWokS44XPK5Vzoxw0doRD2Qd1w2_CzbFI95hASlDpmECIQDkt_5L0VU3drnpjDNO7L50VLOfwz3PV6mZ1pj7ACoDgA%3D%3D'
[download] Destination: Hollow Knight Official Soundtrack (Full Album) [0HbnqjGirFg].webm
[download] 100% of 67.85MiB in 00:18
[debug] ffmpeg command line: ffprobe -show_streams 'file:Hollow Knight Official Soundtrack (Full Album) [0HbnqjGirFg].webm'
[ExtractAudio] Destination: Hollow Knight Official Soundtrack (Full Album) [0HbnqjGirFg].mp3
[debug] ffmpeg command line: ffmpeg -y -loglevel 'repeat+info' -i 'file:Hollow Knight Official Soundtrack (Full Album) [0HbnqjGirFg].webm' -vn -acodec libmp3lame '-q:a' 5 'file:Hollow Knight Official Soundtrack (Full Album) [0HbnqjGirFg].mp3'
Deleting original file Hollow Knight Official Soundtrack (Full Album) [0HbnqjGirFg].webm (pass -k to keep)
[SplitChapters] Splitting video by chapters; 26 chapters found
[SplitChapters] Chapter 001; Destination: Hollow Knight Official Soundtrack (Full Album) - 001 1.).Enter Hallownest [0HbnqjGirFg].mp3
[debug] ffmpeg command line: ffmpeg -y -loglevel 'repeat+info' -ss 0.0 -to 90.0 -i 'file:Hollow Knight Official Soundtrack (Full Album) [0HbnqjGirFg].mp3' -c copy 'file:Hollow Knight Official Soundtrack (Full Album) - 001 1.).Enter Hallownest [0HbnqjGirFg].mp3'
ERROR: ffmpeg version 3.4.8-0ubuntu0.2 Copyright (c) 2000-2020 the FFmpeg developers
  built with gcc 7 (Ubuntu 7.5.0-3ubuntu1~18.04)
  configuration: --prefix=/usr --extra-version=0ubuntu0.2 --toolchain=hardened --libdir=/usr/lib/x86_64-linux-gnu --incdir=/usr/include/x86_64-linux-gnu --enable-gpl --disable-stripping --enable-avresample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libmp3lame --enable-libmysofa --enable-libopenjpeg --enable-libopenmpt --enable-libopus --enable-libpulse --enable-librubberband --enable-librsvg --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxml2 --enable-libxvid --enable-libzmq --enable-libzvbi --enable-omx --enable-openal --enable-opengl --enable-sdl2 --enable-libdc1394 --enable-libdrm --enable-libiec61883 --enable-chromaprint --enable-frei0r --enable-libopencv --enable-libx264 --enable-shared
  libavutil      55. 78.100 / 55. 78.100
  libavcodec     57.107.100 / 57.107.100
  libavformat    57. 83.100 / 57. 83.100
  libavdevice    57. 10.100 / 57. 10.100
  libavfilter     6.107.100 /  6.107.100
  libavresample   3.  7.  0 /  3.  7.  0
  libswscale      4.  8.100 /  4.  8.100
  libswresample   2.  9.100 /  2.  9.100
  libpostproc    54.  7.100 / 54.  7.100
Option to (record or transcode stop time) cannot be applied to input url file:Hollow Knight Official Soundtrack (Full Album) [0HbnqjGirFg].mp3 -- you are trying to apply an input option to an output file or vice versa. Move this option before the file it belongs to.
Error parsing options for input file file:Hollow Knight Official Soundtrack (Full Album) [0HbnqjGirFg].mp3.
Error opening input files: Invalid argument
  File ".local/bin/yt-dlp", line 11, in <module>
    sys.exit(main())
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/__init__.py", line 615, in main
    _real_main(argv)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/__init__.py", line 605, in _real_main
    retcode = ydl.download(all_urls)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 2489, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 1017, in extract_info
    return self.__extract_info(url, ie, download, extra_info, process, info_dict)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 1024, in wrapper
    return func(self, *args, **kwargs)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 1061, in __extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 1093, in process_ie_result
    return self.process_video_result(ie_result, download=download)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 1967, in process_video_result
    self.process_info(new_info)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 2458, in process_info
    self.post_process(dl_filename, info_dict, files_to_move)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 2583, in post_process
    files_to_move, info = self.run_pp(pp, info, files_to_move)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 2534, in run_pp
    files_to_delete, infodict = pp.run(infodict)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/postprocessor/ffmpeg.py", line 808, in run
    self.real_run_ffmpeg([(info['filepath'], opts)], [(destination, ['-c', 'copy'])])
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/postprocessor/ffmpeg.py", line 274, in real_run_ffmpeg
    self.report_error(stderr)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/postprocessor/common.py", line 55, in report_error
    return self._downloader.report_error(text, *args, **kwargs)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 743, in report_error
    self.trouble(error_message, tb)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 705, in trouble
    tb_data = traceback.format_list(traceback.extract_stack())

ERROR: Postprocessing: Error opening input files: Invalid argument
Traceback (most recent call last):
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 2458, in process_info
    self.post_process(dl_filename, info_dict, files_to_move)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 2583, in post_process
    files_to_move, info = self.run_pp(pp, info, files_to_move)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/YoutubeDL.py", line 2534, in run_pp
    files_to_delete, infodict = pp.run(infodict)
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/postprocessor/ffmpeg.py", line 808, in run
    self.real_run_ffmpeg([(info['filepath'], opts)], [(destination, ['-c', 'copy'])])
  File "/home/.../.local/lib/python2.7/site-packages/yt_dlp/postprocessor/ffmpeg.py", line 275, in real_run_ffmpeg
    raise FFmpegPostProcessorError(stderr.split('\n')[-1])
FFmpegPostProcessorError: Error opening input files: Invalid argument

Description

Using the split-chapters option throws an error and stops after trying to run real_run_ffmpeg in ffmpeg.py
Downloading and extracting the audio works, it crashes right after.
Option to (record or transcode stop time) cannot be applied to input url file:Hollow Knight Official Soundtrack (Full Album) [0HbnqjGirFg].mp3 -- you are trying to apply an input option to an output file or vice versa. Move this option before the file it belongs to.
I've tested a simple download / extract as follow to check if it's working as expected on my system, no problem there:
...@...:~$ .local/bin/yt-dlp --extract-audio --audio-format mp3 https://www.youtube.com/watch?v=0HbnqjGirFg
I've also tested without --extract-audio --audio-format mp3, same errors.
It seems to have been merged recently (thanks!), maybe no one came upon this, or it's a problem at my side?
Thanks for reading + for maintaining this!
Have a good day

I am aware of the issue. It happens for mp4, m4a and mp3, but not for webm, mkv etc afaik. I have no idea why it happens - googling the error message doesnt give any usefull results. The only solution I know of rn is to re-encode the video when splitting the chapters. I need to investigate further before pushing a solution.

nvm, found the problem. Update your ffmpeg. I was also using an older version, lol. I will try to make a patch to make it work with older ffmpeg, but no guarantees

Mmmh, I already have the latest version for Ubuntu 18.4
...@...:~$ apt update
...@...:~$ apt-cache policy ffmpeg
ffmpeg:
  Installé : 7:3.4.8-0ubuntu0.2
  Candidat : 7:3.4.8-0ubuntu0.2
 Table de version :
 *** 7:3.4.8-0ubuntu0.2 500
        500 http://ca.archive.ubuntu.com/ubuntu bionic-updates/universe amd64 Packages
        500 http://security.ubuntu.com/ubuntu bionic-security/universe amd64 Packages
        100 /var/lib/dpkg/status
     7:3.4.2-2 500
        500 http://ca.archive.ubuntu.com/ubuntu bionic/universe amd64 Packages

What version of ffmpeg are you now using? Is it 4.2.2 from 20.4 repos?

Any 4.x.x version should work. Older versions of ffmpeg doesn't have -to as an input option. I'll patch it for older versions anyway

Awesome, thanks for that super fast fix!


Migration: textScaleFactor is deprecated

From flutter 3.16.0, textScaleFactor is deprecated and then we need to replace them with TextScalar.

Deprecate textScaleFactor in favor of TextScaler (docs.flutter.dev)
#20

Todo

[ ] Replace textScaleFactor with TextScalar
[ ] Bump minimum SDK version to 3.16.0

Closing as fixed in #22.


OCPBUGS-6712: Serialise LB tests

Due to https://issues.redhat.com/browse/OCPBUGS-6069 the LB type svc
creation time depends on the number of LBs being created in parallel,
thus on the number of LB tests running in parallel. By making them run
serially the svc creation time won't depend on the number of tests
running in parallel.

/jira refresh

/jira refresh

/lgtm

It looks like they actually ran serially: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_openstack-test/78/pull-ci-openshift-openstack-test-main-test/1618928447885676544/artifacts/test/openstack-test-openstack/build-log.txt
According to the logs, the next test seems to only start after the previous has completed.

/approve

/cherry-pick release-4.12


Extend the EpochInfo window in the Alonzo era.

The EpochInfo provided to the ledger by consensus can throw an error
(or return the Left of an Either) when the slot it is asked to translate
lies outside of its predictable window. However, at present this
function has a bug: when consensus doesn't know about any future epochs,
it considers its predictable interval to be unbounded. This may then
change when a new era is added to the codebase, resulting in old
transactions not validating.
The intention is to remove this bug in consensus, such that the
EpochInfo is appropriately bounded in all eras. Unfortunately, since
some transactions with TTLs outside of the usual window have been
allowed on-chain, we have to disable this check in the Alonzo era. In
order to do this, we linearly extend the EpochInfo based on the
current and previous slot, which we are guaranteed to be able to
translate, since otherwise we could not be processing this slot.
closes #2788

We need to extend the...

fantastic catch, thanks :pray:


Read before flush and device truncation fix

2 changes in this PR:

There are use cases where read on logstore for a seq_num to return valid value even if those entries are not flushed. This is done by flushing the data if seq_num is not already flushed and then read from the persistent store. Alternative to that would be to read from cache, which would be more performant. However, this could cause a scenario where read could give different result before and after flush. (Thanks @yamingk for pointing that out)
There is an issue where if a logstore is created, appended with logs but it has not truncated ever, logdevice truncate (which truncates on least log_id of all logstore) doesn't truncate until the said logstore actually calls truncation. While this is not a huge issue as it is expected that all logstores should call truncate at some point, one can see lots of corner cases. This is fixed by setting the logdev upon first insertion.

LGTM


add package.json browser entry

nevermind browserify doesnt like this until this PR is merged https://github.com/browserify/browserify/pull/1826


Write a GO program to find volume of cube

Description
Write a GO program to find volume of cube
Volume of cube = (edge of cube)^3
Input  : 2
Output : 8

How to contribute

Save the solution in find_volume_of_cube.go file
Add find_volume_of_cube.go file in find-volume-of-cube folder

!assign


[hu] cs-229-supervised-learning

@shervinea This is my attempt to create the pull request for the Supervised Learning cheatsheet. Looks like I managed to create a branch with only this cheatsheet in it (by deleting the other two sheets from this branch). Contentwise, no changes have been made to it.
Please let me know if this looks acceptable. Thanks!

Thanks a lot for your work @balazs-vida, it looks great! I just restored some templates that got deleted from the template/ folder so that this PR doesn't change the existing structure of the repo.
Now, we can start the review process with other native speakers who can come in and comment on the translation. Please feel free to invite anyone you know who could do that!

Hey!
I went through the whole doc, and only found one line to comment on: at Line 453, changing sigma-subadditivity to (finite) subadditivity, since the number of events is finite.


No servers available

I'm 50 weeks trying to update my roi wallet, but the wallet just say "No server available".
Did i lost all my roi coins?

What wallet version are you on ? What is your ROI address, you can always check on the explorer how many coins are seen by the block chain.
Can you zip up and send me your debug.log ?

My Wallet is <IP_ADDRESS> Version
my wallet adress: RRymYC4WBsYRP6wj9rnwEGYa9gZQh6R9SN
My debug.log file
https://www.sendspace.com/file/eyhjyk

Hi Rodrigo , please try the following procedure.
1 - stop the wallet, and backup your wallet.dat to a safe place.
2 - goto the D:\util\Executaveis\RoiCoin Directory
3 - delete all files except wallet.dat and ROIcoin.conf(if it exist)
4 - download this blockchain bootstrap zip file (https://github.com/ROIcoin/ROIcoin/releases/download/v<IP_ADDRESS>/blockchain-12-august-2019.zip ) and unzip it in the D:\util\Executaveis\RoiCoin directory.
5 - start wallet back up , and tell me if its syncing ...

Now seems to be working!
Thanks very much! :D

very good, closing this issue.


Add documentation for useNativeAnimations option in DrawerNavigator

For https://github.com/react-community/react-navigation/pull/2568

Thanks!


No service has returned a valid result

It doesn't work for me
script
import os
from srtranslator import SrtFile
#from srtranslator.translators.deepl_api import DeeplApi
#from srtranslator.translators.deepl_scrap import DeeplTranslator
from srtranslator.translators.translatepy import TranslatePy
translator = TranslatePy()
filepath = "/home/alucard/Downloads/film.srt"
srt = SrtFile(filepath)
srt.translate(translator, "nl", "hu")
# Making the result subtitles prettier
srt.wrap_lines()
srt.save(f"{os.path.splitext(filepath)[0]}_translated.srt")

result
[alucard@arch ~/Downloads]$ python translate.py
Loading /home/alucard/Downloads/film.srt
... Translating chunk. 0 %
Traceback (most recent call last):
File "/home/alucard/Downloads/translate.py", line 9, in <module>
srt.translate(translator, "nl", "hu")
File "/home/alucard/.local/lib/python3.11/site-packages/srtranslator/srt_file.py", line 154, in translate
translation = translator.translate(
^^^^^^^^^^^^^^^^^^^^^
File "/home/alucard/.local/lib/python3.11/site-packages/srtranslator/translators/translatepy.py", line 14, in translate
result = self.translator.translate(
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/alucard/.local/lib/python3.11/site-packages/translatepy/translate.py", line 135, in translate
raise NoResult("No service has returned a valid result")
translatepy.exceptions.NoResult: No service has returned a valid result

Does not work with other translators...
Arch Linux

Hey!
This is an issue with TranslatePy, it wasn't able to fullfill the translation request. I can't really do much to help. This is a helper to translate .srt files, not really to actually translate it, tho has multiple built-in providers, try another one, probably the most used is DeeplTranslator (not the api, the selinum based).
Hope it works

OMG!! WORKING!!!!!!!!!!!!
[alucard@arch ~/Downloads]$ python -m srtranslator --translator translatepy film.srt -i en -o hu
Loading film.srt
... Translating chunk. 0 %
... Translation done
Saving film_hu.srt
yeahhh!


How is a set of sewing patterns "stitched" before conducting physical simulation?

First, thanks for releasing the dataset :)
Can you briefly explain how a generated set of sewing patterns is "stitched" together before going through a physical simulation to retrieve 3d garments?
Thanks in advance :)
Sungwon Hwang

Hi Sungwon!
The stitching information for a sewing pattern sample is passed on from the template spec. Design sampling does not change the pattern topology, only the shapes of panel edges, so transferring stitches is trivial. In the code, you can see that the stitching section of the pattern spec is simply left as is and not updated when new parameter values are applied: https://github.com/maria-korosteleva/Garment-Pattern-Generator/blob/4f2c3d655e6f9e739c6349fea31f91c15186e75e/packages/pattern/core.py#L652
We then apply that stitching information on loading the pattern to the Qualoth simulator, and Qualoth takes care of generating geometry correctly (lucky us 😄):
https://github.com/maria-korosteleva/Garment-Pattern-Generator/blob/4f2c3d655e6f9e739c6349fea31f91c15186e75e/packages/mayaqltools/mayascene.py#L116
Let me know if that answers your question!


Can make custom template noneos-sdk on new project ?

Can make custom template noneos-sdk on new project ?
i need make custom template on new project have some file and function
not have int main(){ } only ?

The PlatformIO core does not directly support a platform providing a "new project" template: https://github.com/platformio/platformio-core/issues/446
The platform code (aka platform-ch32v) can work around this by checking if the e.g. src/main.c file does not exist (or the src/ folder is completely empty), then a file with a default template can be copied into that.
What would a sensible template for framework = noneos-sdk be?
#if defined(CH32V00X)
#include <ch32v00x.h>
#elif defined(CH32V10X)
#include <ch32v10x.h>
#elif defined(CH32V20X)
#include <ch32v20x.h>
#elif defined(CH32V30X)
#include <ch32v30x.h>
#elif defined (CH32X035)
#include <ch32x035.h>
#endif
#include <debug.h>

void NMI_Handler(void) __attribute__((interrupt("WCH-Interrupt-fast")));
void HardFault_Handler(void) __attribute__((interrupt("WCH-Interrupt-fast")));

int main(void)
{
	NVIC_PriorityGroupConfig(NVIC_PriorityGroup_2);
	SystemCoreClockUpdate();
	Delay_Init();

	while (1)
	{
		Delay_Ms(1000);
	}
	return 0; // never reached
}

void NMI_Handler(void) {}
void HardFault_Handler(void)
{
	while (1)
	{
	}
}


add field purchaseRequestRefNo

Coverage increased (+0.02%) to 73.941% when pulling 08238368d9a344cae24350b40ad984f5e5a7ed93 on indriHutabalian:dev into 88bcd70a47886e54b9cc37f13503be55f799ea49 on danliris:dev.


Lack of chart and background

Describe your bug here. If you are modding, try testing your bug in a clean version of the engine instead. Also, if you're using an older version of JSE, please try the latest version/action build. Also, be sure to check the pinned 'JS Engine: Known Issues' issue, to check if your issue hasn't already been found!
Its the actual, fresh and new Engine, i've been using it for a while now, but I never seen a thing like this:
https://github.com/user-attachments/assets/65f46b0d-0c88-4ed7-8034-69167bde656d
Command Prompt/Terminal/Crash logs (if existing)
No response
Have you identified any steps to reproduce the bug? If so, please describe them below in as much detail as possible. Use images if possible.
playing the literal game (happens on all songs)
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.

If you use 1.12.0 or earlier, did you have Optimized Chart Loading turned on?
None
Did you check for any similar issues to what you're reporting? Check, then come back here. If there is a similar issue, then do not report the issue, otherwise it will be marked as a duplicate.


Cannot add UseContextMenu to MauiProgram.cs

Per Readme, I add using Plugin.ContextMenuContainer and the .UseContextMenu() to the builder in MauiProgram.cs, but I get an error message that UseContextMenu() does not exist.

Looking through your code, I see only ConfigureContextMenuContainer() as an extension to MauiAppBuilder. Is the Readme out of date?

Yes, it is. Sorry, I forgot to update the Readme. You can use .ConfigureContextMenuContainer()


Auth0 & Foretold Integration: users should have "verified" emails

Either show a special "message" to users or may it be redirect them into "Auth0" page.

Can you describe this more? Like, if their emails aren't verified, what would happen? Would there be a link to "send a new confirmation email" or similar?

We should make users to verify theirs emails with Auth0, because we send emails and we do not want to be spamers.
May it would help:
https://auth0.com/docs/api/management/v2#!/Jobs/post_verification_email

I meant, can you describe the functionality more?
How about this:
For users without verified emails, we'll show a simple message in the header. It will say,
"Please verify your email address. Click here to send a new verification email."
Clicking there will trigger a mutation which will trigger auth0 to send a new verification email.
On success of that mutation, the message will be replaced with one that reads, "Email sent"

Yes, good logic


change(consensus): Refactor block::check::subsidy_is_valid()

Motivation
This is an optional refactor of the subsidy_is_valid() function and could include other cleanups following the NU6 consensus rule changes.
Depends-On: #8694.
Solution

Adds a num_halvings() fn
Calls num_halvings() instead of halving_divisor() in subsidy_is_valid()

Tests
Zebra has several vectors tests for this function.
PR Author's Checklist

[x] The PR name will make sense to users.
[x] The PR provides a CHANGELOG summary.
[x] The solution is tested.
[x] The documentation is up to date.
[x] The PR has a priority label.

PR Reviewer's Checklist

[ ] The PR Author's checklist is complete.
[ ] The PR resolves the issue.

Closing this for now, it's easier to recreate than to maintain


Change when streaming Combine on Flink should be fired

The goal is to avoid situations where two Flink tests run at the same time on the same machine.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @piotr-szuberski


1 state model

@Farnazmdi what do you suggest we should do with this code?

Oh, sorry, I hadn't seen this email before, hadn't received the
notification.
I just had made this branch to keep that code in this repository if needed,
I think it diverged enough to ignore to be a part of this.
Thanks,
On Mon, Jul 1, 2019 at 4:56 PM Aaron Meyer<EMAIL_ADDRESS>wrote:

Closed #120 https://github.com/meyer-lab/lineage-growth/pull/120.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/meyer-lab/lineage-growth/pull/120?email_source=notifications&email_token=AIJTGTSZONQW3EU75U25XP3P5KKR5A5CNFSM4HXJBKQ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSIY5BTQ#event-2452738254,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIJTGTUNNEI23WRHVH44FADP5KKR5ANCNFSM4HXJBKQQ
.

--
Sincerely,
Farnaz Mohammadi


[2.0-wip] Add accordion features

Allow clicking the entire group item area (not just over the link)
Add more styling

Took care of the first one just now, but unsure what you're looking for on the more styling front. What's wrong with these basics?

they're great already. just thinking maybe add the same background the breadcrumbs have?
thanks

Gotcha. I'll check that out later when we continue our testing to see if any extra styles would help. Thanks!

i'll have to say "thank you" marko for this great library you create! :))


[utilityfunctions] generateCsv producing incorrect result

What package is this for?

[x] React
[ ] Angular

Describe the bug
The generateCsv is producing incorrect result with an additional column and the test is incorrectly written to match the result.
To Reproduce
Steps to reproduce the behavior:

Go to https://next.carbon-addons-iot-react.com/?path=/story/1-watson-iot-table--playground
Click on the download button
Open the file
See empty column

Please create a reduced test case in CodeSandbox:
https://codesandbox.io/s/github/carbon-design-system/carbon-addons-iot-react/tree/next/packages/react/examples/codesandbox

Expected behavior
No empty column and correct test
Environment/versions:

OS: [e.g. MacOS, Windows]
Browser: [e.g. chrome, safari]
carbon-addons-iot-react version: [e.g. v2.60.0]

Additional context
If applicable, add screenshots to help explain your problem.
Add any other context about the problem here.
Specific timeline issues / requests
Do you want this work within a specific time period? Is it related to an
upcoming release?
NB: The core contributors will try to work with your timeline, but it's not
guaranteed. The earlier you make a request in advance of a desired delivery
date, the better!

Fixed this while writing the toolbar documentation since I wanted to use the example in the docs. Adding new issue to track it and separate the code changes from the doc changes.


Pass an exception object to at_exit block.

It is more useful than integer status code.

@MakeNowJust Why is it more useful? What do you need the exception for?

@asterite This feature makes a difference between 'exit 1' and 'raise exception'. It is useful to decide to run main script hook, and to show more diagnostic message of the exception for example.

In spec or kemal, how would you use it instead of using the status code?

Mmm... I'm thinking, maybe in spec if you do exit in some code then checking for the status code 0 will still run the specs, but maybe you don't want to do that. Or maybe if you exit in kemal in your script, the server will still run. But the question is: why is that code doing exit instead of exit 1? If the specs are not run, or the server shouldn't get up, it's because something "bad" happened.

Another thing is that SystemExit doesn't feel right, it's an exception that's never thrown... Well, exit could actually throw SystemExit, but it's ugly. I'm not sure we should copy Ruby here.

This is old and we'll probably not merge it like this.


CustomTypeFlag decoder codegen incorrect when in List and Nullable flags

Pipeline decoder code is incorrect for CustomTypeFlag when used with List and Nullable flags.
The following causes incorrect decoder pipelines
ObjectFlag({"something": ListFlag(CustomTypeFlag(variants=[("A", StringFlag()]))})

ObjectFlag({"something": NullableFlag(CustomTypeFlag(variants=[("A", StringFlag()]))})

Fuzzers would have caught this but CustomTypeFlag's are not being fuzzed due to name clash issues that I need to work around.

Released in 0.10.0


webpack-typescript template can't resolve native node modules in webpack bundling

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
7.2.0
Electron version
28.2.2
Operating system
Windows 10 22H2
Last known working Electron Forge version
No response
Expected behavior
Native node modules imported in preload.ts should be resolved correctly by webpack.
Actual behavior
"electron-forge start" fails at the webpack bundling, with this error:
√ Checking your system
√ Locating application
√ Loading configuration
√ Preparing native dependencies [2s]
√ Running generateAssets hook
√ [plugin-webpack] Compiling main process code [2s]
√ [plugin-webpack] Compiling main process code [2s]
√ [plugin-webpack] Compiling main process code [2s]
× [plugin-webpack] Launching dev servers for renderer process code
› Compilation errors in the preload: group_0:
asset main_window/preload.js 562 KiB [emitted] (name: main_window)
runtime modules 26.…
An unhandled rejection has occurred inside Forge:
Error: Compilation errors in the preload: group_0:
asset main_window/preload.js 562 KiB [emitted] (name: main_window)
runtime modules 26.4 KiB 12 modules
modules by path ./node_modules/ 163 KiB
modules by path ./node_modules/webpack-dev-server/client/ 71.8 KiB 16 modules
modules by path ./node_modules/webpack/hot/.js 5.18 KiB
./node_modules/webpack/hot/dev-server.js 1.94 KiB [built] [code generated]
./node_modules/webpack/hot/log.js 1.74 KiB [built] [code generated]
+ 2 modules
modules by path ./node_modules/html-entities/lib/.js 81.8 KiB
./node_modules/html-entities/lib/index.js 7.91 KiB [built] [code generated]
./node_modules/html-entities/lib/named-references.js 73 KiB [built] [code generated]
./node_modules/html-entities/lib/numeric-unicode-map.js 339 bytes [built] [code generated]
./node_modules/html-entities/lib/surrogate-pairs.js 537 bytes [built] [code generated]
./node_modules/ansi-html-community/index.js 4.16 KiB [built] [code generated]
./src/preload.ts 1.22 KiB [built] [code generated]
external "events" 42 bytes [built] [code generated]
ERROR in ./src/preload.ts 25:24-37
Module not found: Error: Can't resolve 'fs' in 'C:\DriveD\projects\my-app\src'
resolve 'fs' in 'C:\DriveD\projects\my-app\src'
Parsed request is a module
using description file: C:\DriveD\projects\my-app\package.json (relative path: ./src)
Field 'browser' doesn't contain a valid alias configuration
resolve as module
C:\DriveD\projects\my-app\src\node_modules doesn't exist or is not a directory
looking for modules in C:\DriveD\projects\my-app\node_modules
single file module
using description file: C:\DriveD\projects\my-app\package.json (relative path: ./node_modules/fs)
no extension
Field 'browser' doesn't contain a valid alias configuration
C:\DriveD\projects\my-app\node_modules\fs doesn't exist
.js
Field 'browser' doesn't contain a valid alias configuration
C:\DriveD\projects\my-app\node_modules\fs.js doesn't exist
.ts
Field 'browser' doesn't contain a valid alias configuration
C:\DriveD\projects\my-app\node_modules\fs.ts doesn't exist
.jsx
Field 'browser' doesn't contain a valid alias configuration
C:\DriveD\projects\my-app\node_modules\fs.jsx doesn't exist
.tsx
Field 'browser' doesn't contain a valid alias configuration
C:\DriveD\projects\my-app\node_modules\fs.tsx doesn't exist
.css
Field 'browser' doesn't contain a valid alias configuration
C:\DriveD\projects\my-app\node_modules\fs.css doesn't exist
C:\DriveD\projects\my-app\node_modules\fs doesn't exist
C:\DriveD\projects\node_modules doesn't exist or is not a directory
C:\DriveD\node_modules doesn't exist or is not a directory
C:\node_modules doesn't exist or is not a directory
group_0 (webpack 5.90.1) compiled with 1 error in 5570 ms
Steps to reproduce
init a new electron-forge app with:
npm init electron-app@latest my-app -- --template=webpack-typescript
cd my-app
add this code in src/preload.ts
import * as fs from "fs";

const c = fs.readdirSync("C:\\");
console.log("dir", c);

npm start
Additional information
The same test made using vite-typescript template, works as expected.
For the code to work in electron, the main BrowserWindow must be created with webPreferences.sandbox: false.

From memory I resolved this by:
setting target: "web", in webpack.renderer.config.ts

Same problem here. Webpack can't resolve native node modules in preload.js. Node integration enabled. Has someone found any solution?


tsconfig INCLUDE and inheritance in Visual Studio 2017

In Visual Studion 2017 web project I have this tsconfig.json
{
  "extends": "../template/tsconfig.common.json"
}

and this tsconfig.common.json
{
  "compilerOptions": {
    "target": "es5",
    "moduleResolution": "node",
    "allowSyntheticDefaultImports": true,
    "jsx": "react"
  }
  "include": [
    "./common",
    "./web",
  ]
}

VS.NET build succeeded but VS.NET intellisense shows errors in web\index.tsx file.

Error is the same as if the web\index.tsx file was excluded from the project. If I move content
of tsconfig.common.json to tsconfig.json (and do not use config inheritance), all is OK.
Error text is:
Module '"...node_modules/@types/react-dom/index"' has no default export...

My mistake because  of
All relative paths found in the configuration file will be resolved
relative to the configuration file they originated in.

from https://www.typescriptlang.org/docs/handbook/tsconfig-json.html
Sorry for it.


Version mismatch

Brief bug description
Upgrading Kentico.Xperience.AspNetCore.WebApp in the KX13.Extensions project to 13.0.128 or higher prevents compilation.
Repro steps

Open the Migration Toolkit in Visual Studio
Right click on the solution and pick "Manage Nuget Packages for Solution"
Go to "installed" and search for 'Xperience'
See that the target version of Kentico.Xperience.AspNetCore.WebApp (and thus Kentico.Xperience.Libraries) for the "KX13.Extensions" project is '13.0.76
Site I want to migrate is 13.0.133, so we update that version.
Upgrading to 13.0.127 gives no errors, but going to 13.0.133 (or 13.0.128, or 13.0.147) throws a large set of compilation errors on ToolkitApiController, ranging from 'The name 'SiteContext' does not exist in the current context' to 'The type or namespace name 'Kentico' could not be found'

Expected behavior
Migration code should be compileable using the versions of the APIs matching your source and target projects, or documentation should say to not try to match the 13 API's to the project version
Test environment

.Net 8.0
No browser
Visual Studio 17.8.3

Additional context
This started when I tried to run the site as-is on a KX13.0.133 -> XbyK 28.4.4 migration.
I got an error in the console that there was a version mismatch between 28.4.1 and 28.4.4, which led me to bumping up the XbyK APIs to 28.4.4.
I saw that the KX13 libraries were set to 13.0.76 (for KX13.Extensions) and 13.0.82 (for KX13.NET48.Extensions) so I wanted to get ahead of any issues by matching that to my repo as well.
I believe the issue is that .128 removed .net pre-6 support, and KX13.Extensions is marked for .net 5 and core 3.1 support. Removing those two from the Extensions project seems to get rid of the errors.
Screenshot
https://imgur.com/S66ozNP

Thank you for reporting the issue. Our team will investigate it thoroughly and provide updates on the resolution.

Thank you - Just to be clear: If I'm migrating from a site that is
KX13.0.145 (or other new project) I should still keep the KX dependencies
in the Migration.Toolkit project itself as 13.0.82 and 13.0.74 (or whatever
they are), not alter the dependencies to match the version of KX13 I'm
using, correct? I know about the ToolkitApiController and putting it in my
source project, I just had assumed that the dependencies in the
Migration.Toolkit project itself should be altered to match. It may be
worth throwing some documentation in that api discovery setup setup step
(or anywhere) to say to leave that alone.
_____________________
Chris Bass
Wakefly*,** Inc.*
On Wed, Apr 17, 2024 at 6:02 PM Tomáš Krch @.***> wrote:

Hello @ChristopherBass https://github.com/ChristopherBass, please see
docs about those 2 projects:
https://github.com/Kentico/xperience-migration-toolkit/blob/master/Migration.Toolkit.CLI/README.md#api-discovery-setup.
This is not intended use, you should copy ToolkitApiController.cs to Your
project and register endpoints - not upgrade it in place. Project is
intentionally set to lowest supported version of KX13.
Supported version of target instance is 28.4.1 currently (it isn't
incorporated into docs yet - see issue #165
https://github.com/Kentico/xperience-migration-toolkit/issues/165). You
can try with 28.4.4., but that target version was not tested yet (i will be
glad for any feedback if You try migration with 28.4.4. target api version).
—
Reply to this email directly, view it on GitHub
https://github.com/Kentico/xperience-migration-toolkit/issues/169#issuecomment-2062509627,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMPUAIHD4QQGHISTIFNIY3Y53WQBAVCNFSM6AAAAABGEYLK56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSGUYDSNRSG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Angular and JQuery versions - Random settting of dropdown values (with plunkr)

I've forked the Angular plunkr to demonstrate. See http://plnkr.co/edit/heUR0cEUNGEbfMECuXWK?p=preview
To demonstrate I've just changed the radiogroup input types to dropdown.
Navigating between pages ie navigate back and forwards a few times between pages produces the effect of randomly selecting a dropdown choice.
I've checked this out with the jquery version and the same behaviour applies.

@ltex this is a bug. Thanks!

@ltex it is fixed now in 0.12.3 version. Could you check it please?


set env in shell to avoid command not found

Signed-off-by: duanmeng<EMAIL_ADDRESS>

@Iceber


Triggering 500 for duplicate emails

Hi,
If a project doesn't include allauth.url there is a case when someone using the same email address as local user tries to sign in with SocialAccount and same email address. There is a 500 triggered on social_acount_signup reverse.
I've seen it mentioned in closed issues.
Allauth provides a hook on the adapter pre_social_login.
I've noticed that the only type of exception covered in the SocialLoginSerializer you provide is:
try:
    login = self.get_social_login(adapter, app, token, access_token)
    complete_social_login(request, login)
except HTTPError:
    raise serializers.ValidationError(_('Incorrect value'))

This seems like a bad way to intercept anything put in pre_social_login hook. Also there are other errors which could happen in the process to which maybe other messages apply.
Do you guys think there is maybe a better way to go about this?

@mariodev or @mateusz-sikora maybe this could catch the HTTPError as intended but also could catch any exception with a generic message like:
Login procces failed.
This could then provide more flexibility and would not require anyone who needs to break the login process to import HTTPError and they could use something meaningful to them.
If you want i could write the addition of another except Exception block there.
Maybe there is a better way?

I think here the main problem is how to deal with all the cases a duplicate email would mean. I'm facing the same problem in my project and I had to override the adapters to achieve my result.  There are many cases when one tries to log in via social account and an account already exists:

do we want to merge the accounts?
do we want to send a notifications to the user asking if he/she wants to merge the accounts?
do we want to just send back a message like "sorry, an account with the given email already exists"
create another User with the same email

I'd really like to have some kind of logic to allow choosing between those when using rest-auth

@MattBlack85 that is a general problem of having both local account and social account option gives to the project.
Account handking is not done by django-rest-auth. It is done by django-allauth. There are a few issues there, but generally it is left for each project to build and customize via adapter.
Some projects have a policy to never allow social and local accounts to connect, some want them to be connected from inside a logged in user session.
I've started this issue so authors take notice that they are narrowing options for overriding behavior set in the adapter inside the login view.
If you want to throw and attribute error, or a custom exception inside your project from the adapter the view will not catch it.

Resolved in https://github.com/Tivix/django-rest-auth/pull/367
Also social connect functionality was added that addresses this issue: http://django-rest-auth.readthedocs.io/en/latest/installation.html#additional-social-connect-views


Error codes seen in O365 Management API, stream Audit.AzureActiveDirectory are missing

Hello,
AAD audit stream contains the following error codes that are not documented here:

None: Probably just success event
FaultDomainRedirect
UserAccountDeleted
DeviceNotCompliantDeviceManagementRequired

All of those appear with operation 'UserLoggedIn', which is interesting for 'UserAccountDeleted' error - so apart from error description, I'm also interested in description of those errors in context of successful login
Thanks,
Jiri

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a826ee6f-f457-7109-9f77-67c57977d4e7
Version Independent ID: 11766f27-492e-a579-dced-8a42528cbb47
Content: Azure Active Directory authentication and authorization error codes
Content Source: articles/active-directory/develop/reference-aadsts-error-codes.md
Service: active-directory
Sub-service: develop
GitHub Login: @CelesteDG
Microsoft Alias: celested

@jformacek, Thanks for the feedback! Your feedback has been shared with the content owner for further review.

Addiing few more undocumented errors seen with UserLoginFailed operation:

OnPremisePasswordValidationAuthenticationAgentTimeout
InvalidGrantDeviceNotFound
InvalidSamlTokenNoTrustedRealmFromIdentifier
UnauthorizedClientDoesNotMatchRequest
UnsupportedResponseTypeImplicitFlowAccessTokenNotAllowed
InvalidReplyToInvalidScheme

#reassign:rwike77

rwike77
is not a valid GitHub ID, or is not a collaborator on this repo.

#reassign:rwike77

@rwike77 the page really doesn't help if you don't know the error code being returned and only have the LogonError to search with. I'm receiving the "FaultDomainRedirect" error through the API and it does not come accompanied with the error code. Is there any way to add the functionality to search on either the code or the LogonError name itself?

Is there an update on the FaultDomainRedirect logon error either having a code or being added to the list so we can understand what it means?

Also having a hard time finding information on "FaultDomainRedirect" and O356 logs do not contain a error ID. Can we have this issue readdressed please?

Not really sure why this is closed. It's still undocumented.


[Test] Speed up transform_ops_test

_test_grad was the most expensive call. Reduce the number of calls by removing useless differing image sizes.
Local test: 55s -> 21s
Related to #1143

Thank you for the pull request!


[BUG] model.set_retrieval_candidates_for_evaluation(train) for twotower throws AttributeError

Bug description

model.set_retrieval_candidates_for_evaluation(train) for twotower throws AttributeError: 'RetrievalModel' object has no attribute 'set_retrieval_candidates_for_evaluation'
Steps/Code to reproduce bug

      model = mm.TwoTowerModel(
      schema,
      query_tower=mm.MLPBlock([128, 64], no_activation_last_layer=True),
      loss="categorical_crossentropy",
      samplers=[mm.InBatchSampler()],
      embedding_options=mm.EmbeddingOptions(infer_embedding_sizes=True),
      metrics=[mm.RecallAt(10), mm.NDCGAt(10)],
  )
model.set_retrieval_candidates_for_evaluation(train)

@gabrielspmoreira Thank you for getting back so quick. I tried passing the item_corpus inside model.evaluate() after model.fit() and I get TypeError: __init__() got an unexpected keyword argument item_corpus. I did a git pull from models/nvtabular/core already and that didn't resolve it.

@gabrielspmoreira  Also, if I do a model.evaluate() on validation data without the item_corpus=train_tt, then I see a ValueError: None values not supported

it works for me. I dont get error.  Please do the following first in your container to pull the latest changes in the main branch:
cd /models
git checkout main
git pull origin main
pip install -e .

Then, please try again something like that:
metrics = model.evaluate(valid, batch_size=4096, item_corpus=train, return_dict=True)

** replace valid and train with the dataset objects you trained your model.

@rnyak @gabrielspmoreira  I have pulled the latest changes from main branch into my container. Have tried it on both tf-training as well as tf-inference 22.04 containers. I still see the same error on my end. However, it doesn't block me from proceeding with the next steps in the notebook as model.fit works.

@mkumari-ed , please re open a ticket if you are still facing issues.


Url shortener

Issue that this pull request solves
Link shortener service
Made under DWOC and SWOC
Closes: #153
Proposed changes
Brief description of what is fixed or changed
Added a link shortener service which accepts a query parameter link and shortens it to a code of length 5. One using that link is redirected to the original link if valid, else an error is thrown.
Types of changes
I've added the API testing file in the url folder itself named API Tests.postman_collection.json
Also the API Tests are available at https://www.getpostman.com/collections/69d0f7207dd18940e91a
Put an x in the boxes that apply

[x] New feature (non-breaking change which adds functionality)

Checklist
Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] My changes does not break the current system and it passes all the current test cases.

will try to have a look tomorrow
detailed review will be done mostly by Saturday

Working on it

@nehaparmar99 Are you still working on this? Please update your status

@nehaparmar99 Are you still working on this? Please update your status

Yes I am, I'll do it by tomorrow latest

@jackfrost13 I've made the changes.Please check it out.
Changes made:
1.Refactored error handling.
2.Nanoid used.
3.The shortUrl obtained now redirects to the Original long url

@jackfrost13 please review it

Extremely sorry, slipped out of my review list.
Please make a habbit to request for re-review else we don't get notification

@nehaparmar99 Hi, can you join for 15 mins meet? I can request for changes but since you have been blocked on this for a couple of days I have made changes and was thinking to help you on it

Closes #153
@nehaparmar99 Let me know if want a sync up on brief understanding as to why my changes are helpful, I will be available only on weekends

Hi @nehaparmar99, we didn't hear back from you, please let me know if you had gone through my changes. The whole point of running this cohort sprint is to spread awareness and exchange knowledge and if you are not benefitting out of it then it defeats the whole purpose. We try our best to rely on high standard.

Hi @nehaparmar99, we didn't hear back from you, please let me know if you had gone through my changes. The whole point of running this cohort sprint is to spread awareness and exchange knowledge and if you are not benefitting out of it then it defeats the whole purpose. We try our best to rely on high standard.

Hey I'm so sorry for not getting back.I had gone through the changes, and understood the point of them.I have been extremely busy with my college schedule, so couldn't find much time.I am so sorry for the delayed response.


Page difficult to read

While this page is technically ok, it doesn't read very well and could be explained much better.  Suggest someone at Microsoft reviews and re-writes this page to make it easier to capture the concepts.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a69c921d-0f42-7b6c-88ef-e82ff2e2453b
Version Independent ID: 9f8b73b2-fa6a-cb9c-d22e-67ec625ce3d7
Content: Set up IP addressing to connect after disaster recovery and failover to Azure with Azure Site Recovery
Content Source: articles/site-recovery/concepts-on-premises-to-azure-networking.md
Service: site-recovery
GitHub Login: @mayurigupta13
Microsoft Alias: mayg

@benwhittaker Thanks for your comment. The feedback has been shared with the content owner @mayurigupta13 for further review.

@KrishnaG-MSFT Please assign to me. I'm working on this. thx

I also made a comment back in may that VNET to VNET doesn't allow this to work as it doesn't allow transit connectivity.  VNET Peering is required.  Article still hasn't been updated.  These articles for each of the DR scenarios (Azure to Azure is fine) need a big revamp as it needs to be much clearer to the reader on how this all works.

@benwhittaker Thanks for your feedback! I've updated the article and hopefully it's now a bit more readable. Please take a look.
@ElanShudnow Hey Elan, I couldn't find your comment from May, but can you take a look now and let me know what you think needs a revamp.
Leaving this open to wait for feedback. Thx!

I haven't heard back on this so I'm closing. Please feel free to reopen or to open a new issue if needed. Thanks!
#please-close

The feedback is on this specific article  https://docs.microsoft.com/en-us/azure/site-recovery/concepts-on-premises-to-azure-networking. Happy to take feedback on other articles but I can you give me a few more details. Which articles do you think need a revamp, and what do you think isn’t clear or explained well enough.
Cheers!
From: Elan Shudnow<EMAIL_ADDRESS>Sent: Monday, September 30, 2019 7:28 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Rayne Wiselman<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Page difficult to read (#38431)
I also made a comment back in may that VNET to VNET doesn't allow this to work as it doesn't allow transit connectivity. VNET Peering is required. Article still hasn't been updated. These articles for each of the DR scenarios (Azure to Azure is fine) need a big revamp as it needs to be much clearer to the reader on how this all works.
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F38431%3Femail_source%3Dnotifications%26email_token%3DAA635CDCBS5FY46SPSGKXEDQMF55RA5CNFSM4IUG4JAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD74MAWY%23issuecomment-536395867&data=02|01|raynew%40microsoft.com|4a62c9d6f7ce4748ddc808d7455e9981|72f988bf86f141af91ab2d7cd011db47|1|0|637054144910321342&sdata=6afghLltmgOosAEG8DQ6F2ifna0Yz%2BrXmoHw3shhBuo%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA635CAHJPJUTAVAN6DMDULQMF55RANCNFSM4IUG4JAA&data=02|01|raynew%40microsoft.com|4a62c9d6f7ce4748ddc808d7455e9981|72f988bf86f141af91ab2d7cd011db47|1|0|637054144910331333&sdata=A971RsyntuDfWJv8q3YfldaoVz3fNTv7C%2B%2BJlPbGbKM%3D&reserved=0.


Sorted set commands returning empty lists

All the sorted set commands are giving me empty lists whereas when I run the same command using redis-cli it works.
I am trying something like zset, cursor, err := c.conn.ZScan("new", 0, "", 10).Result() where c.conn is a redis client.
type Client struct {
	conn *redis.Client
}

Other functions like Scan and SMembers are working and giving the desired result but the sorted set commands are always returning empty lists. Can someone please check whether this is reproducable or not

There is a test for ZScan so this looks like a problem on your side.


Argument Unpacking

Well detailed description of the change :

This PR adds argument unpacking to callsites of different values. Works with functions, methods, classes and builtins.
Example:
const myList = [1, 2, 3];

def printMyList(a, b, c) {
    print(a, b, c);
}

printMyList(...myList); // 1 2 3

Resolves: #440

Type of change:

[x] New feature

Housekeeping

[x] Tests have been updated to reflect the changes done within this PR (if applicable).

[x] Documentation has been updated to reflect the changes done within this PR (if applicable).

@briandowns Be good to get your thoughts if you get a spare moment!


Bug: anchor links navigate too far above target

This problem has been reported on the design system site by @ashleydraper and on the development.digital.ca.gov site which uses design system components by Regan.
Noticed in sidebar links all over the design system site by Ashley.
From Regan:
The sidebar jump links seem to calculate a higher y-value than needed (maybe 150px off due to header calculation?). Persists across browsers on Mac/iPhone

This still seems to be an issue. While it jumps to the header, that header is at the bottom of the screen, rather than the top.

@aaronhans @ashleydraper  I couldn't recreate this at any screen size. Could you include the url+path, browser, and the link that was clicked? Bonus points for video screen shot.

@zakiya and @aaronhans I still get this when using Firefox on PC. While I don't have video capture possibilities (at least that I know of with my baseline Windows setup), here's a step-by-step of how I got my bug with screenshots.

I go to https://designsystem.webstandards.ca.gov/style/content/.

I click Our inspiration in the left menu.
It moves the screen slightly so the Our inspiration header is at the bottom of the screen rather than the top.

I'd expect the header to be at the top of the screen rather than the bottom.
Just the observations of a California citizen. 😄

I bet this would be solved by addressing the first bullet point in #672.
Safari 15.4 has been out for a while now, so we could remove all of that polyfill code and just trust the browser to scroll to the right place.

Nice @xjensen! I love that solution

Thanks all! Reassigning to @xjensen so @aaronhans can focus on Benefits.

PR is ready in #926.


LoadError: Failed to get MOSEK version

On virgin julia installation on Linux, Pkg.add("Mosek") gives this error:
LoadError: Failed to get MOSEK version
while loading...../.julia/v0.6/Mosek/deps/build.jl, in expression starting on line 152
MOSEKBINDIR is not set.

Hi, I cannot reproduce your problem. Internally the installer uses wget or curl to download files. Can you verity that you can do
curl https://www.mosek.com/downloads/default_dns.txt

and
curl d2i6rjz61faulo.cloudfront.net/stable/8/version

I believe I have fixed the issue in branch "b0.8". I will make a new release soon, until then do:
Pkg.checkout("Mosek","b0.8")


[Docs] Add RLHF Content

Great MR,
Would you mind citing the source of the Ray+vLLM-based RLHF architecture - OpenRLHF at README.md?
Such as in https://github.com/InternLM/xtuner?tab=readme-ov-file#-acknowledgement
I noticed that most RLHF-related codes/architecture of XTuner are refactored based on OpenRLHF, the Apache license 2.0 of OpenRLHF requires the original copyright statement.
Thanks.


Add and verify consensus config hash

Makes consensus and client configs implement Encodable so they can be deterministically hashed and validated.
Adds the consensus hash and an API endpoint for retrieving it with the client config (next step will be to save and return the signed hash of the client config).
Fixes #950, will be used to solve #1262

triggered CI

Needs a rebase after #1323 :frowning:

Looking great now. Pointed out one SerdeEncodable. The conflict should make your life easier as some of your changes won't be required anymore.


Fix inconsistent port numbers in "Hello Hub Choice" tutorial

Summary
I was trying to work through the "Hello Hub Choice" tutorial and I noticed that after first mentioning localhost:5000 as the app port, the document was subsequently assuming localhost:8080 instead.
This might confuse some new users, because there will likely be no application (or something else) running on that port, unless they edit the manifest by hand, which the tutorial does not tell them to do.
I replaced all occurrences of localhost:8080 with localhost:5000.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[REVIEW] WasiqB

GitHub Profile Link
https://github.com/WasiqB

I like your simple and minimalistic profile 🎉

@Kira272921 , thanks. It's good to know that you liked it. Would appreciate if you can share feedback on improving it further.

@WasiqB Maybe trying mentioning on which open source projects you are currently working, and trying adding their repository links as well
🤔 It would be good, if there is a techstack section. You can look at my profile for the idea and here is a great repository which contains lot of README badges

Thanks for sharing the feedback, will look into the links you've shared and update the profile accordingly.

Looks great, reviewed on live stream, some suggestions are:

suggest removing widgets
also the duplicate repo widgets are not required
pin max 4 repos


Bridge methods are not created properly for covariant overridden methods

I just added CovariantViewTest which fails because it uses a covariant override and the bridge method is not generated in the proxy class. This should be done properly!

Current workaround is to implement the method yourself and delegate it.


Update sbt-scalajs, scalajs-compiler, scalajs-library... to 0.6.26

Updates

org.scala-js:sbt-scalajs
org.scala-js:scalajs-compiler
org.scala-js:scalajs-library
org.scala-js:scalajs-test-interface

from 0.6.24 to 0.6.26.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   64.33%   64.33%
=======================================
  Files           5        5
  Lines         143      143
  Branches        9        9
=======================================
  Hits           92       92
  Misses         51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15b9fd...e04fb1f. Read the comment docs.


dolphin.properties & application.properties in Spring boot not work together

🆕🐥:dog: First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
:space_invader: Description of the issue
If you use Spring Boot you normally define all properties in 'application.properties'. Dolphin Platform supports this property file and all DP related properties can easily be defined here.
In addition DP provides the framework independent 'dolphin.properties' file to define properties. This is needed if you have a JavaEE server for example that do not define a way how to configure properties.
If you add 'application.properties' and 'dolphin.properties' file to a Spring Boot based application DP related properties that are defined in 'application.properties' will be ignored.
📋 Step by Step

🙋 Claim this issue: Comment below.
🔄 replace the up for grabs label with in progress.
:fork_and_knife: fork the repository in github by simply clicking the 'fork' button.
:arrow_heading_down: check out the forked repository
:twisted_rightwards_arrows: create a feature branch for the issue. We do not have any naming definition for branches.
💾 Commit your changes.
🔀 Start a Pull Request.
🏁 Done 👍 Ask in comments for a review :)
🔬 If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
:boom: you did it! We will merge the fix in the master of the Dolphin Platform project.
:bouquet: Thanks, thanks, thanks for being part as an open source contributor for Dolphin Platform

🤔❓ Questions
You can join our community chat at Slack

Hi, I am a new in Open Source and it will be my first contribution to Open Source. I would like to claim this issue

@aftabthedeveloper sure :)

Thank You


Typecasting useLoaderData doesn't work in blog tutorial

What version of Remix are you using?
1.6.5
Steps to Reproduce
Follow the tutorial till the Dynamic routing section. I was able to use generic to resolve the issue. I've attatched a PR to this issue that should fix this problem
P.S, I'm a fresh contributer, so I'd appreciate any tips !
Regards,
Dev
Expected Behavior
Able to continue as shown in the tutorial
Actual Behavior
Using const { posts } = useLoaderData() as LoaderData;  results in the following error
Conversion of type '{ posts: { slug: string; title: string; markdown: string; createdAt: string; updatedAt: string; }[]; }' to type 'LoaderData' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
  Types of property 'posts' are incompatible.
    Type '{ slug: string; title: string; markdown: string; createdAt: string; updatedAt: string; }[]' is not comparable to type 'Post[]'.
      Type '{ slug: string; title: string; markdown: string; createdAt: string; updatedAt: string; }' is not comparable to type 'Post'.
        Types of property 'createdAt' are incompatible.
          Type 'string' is not comparable to type 'Date'.

Here is my PR #3773 https://github.com/remix-run/remix/pull/3773

FYI -- I also ran into this as a +1


Add constructor for 1 action

This constructor will make it easier for initialise DefaultRules with lambda

DefaultRule is package private and not part of the public APIs. How will this make things easier? It is not even possible to make things (ie to create the class outside the package). And even for internal use within Easy Rules code, how is this different from:
new DefaultRule("name", "description", 1, facts -> false, Collections.singletonList(facts -> { }));

where lambdas can be used to define the condition and the single action?

DefaultRule is package private and not part of the public APIs. How will this make things easier? It is not even possible to make things (ie to create the class outside the package). And even for internal use within Easy Rules code, how is this different from:
new DefaultRule("name", "description", 1, facts -> false, Collections.singletonList(facts -> { }));

where lambdas can be used to define the condition and the single action?

I don't think this is necessary, especially that DefaultRule is package private. Thank you for your PR anyway!


Datashard added OwnedCellVecBatch

Datashard added OwnedCellVecBatch

Query: SELECT WatchID, Title, UserID, EventTime, OS FROM hits ORDER BY EventTime LIMIT 50.  Around 24% performance improvement.
./ydb -p test_db benchmark --query "SELECT COUNT(WatchID) FROM hits" --threads 32

Before:

Queries executed: 32 QPS 0.02311798632 Average query time: 43.256362s

0.000%  0.000000s
10.000% 0.000000s
20.000% 0.000000s
30.000% 0.000000s
40.000% 0.000000s
50.000% 0.000000s
60.000% 0.000000s
70.000% 0.000000s
80.000% 0.000000s
99.000% 0.000000s
99.900% 0.000000s
99.990% 0.000000s

After:

Queries executed: 25 QPS 0.030314547 Average query time: 32.987463s

0.000%  0.000000s
10.000% 0.000000s
20.000% 0.000000s
30.000% 0.000000s
40.000% 0.000000s
50.000% 0.000000s
60.000% 0.000000s
70.000% 0.000000s
80.000% 0.000000s
99.000% 0.000000s
99.900% 0.000000s
99.990% 0.000000s


Fix seccomp output in docker info

This fix tries to address the issue raised in #24374 where docker info outputs seccomp support in Ubuntu 14.04 but the seccomp wass not actually supported.
The issue is that in the current docker implementation, seccomp support is only checked against the kernel by inspect CONFIG_SECCOMP and CONFIG_SECCOMP_FILTER. However, seccomp might not be enabled when building docker (through golang build flag).
This fix adds a supportsSeccomp boolean variable. The supportsSeccomp is only set to true when seccomp is enabled while building docker.
This fix fixes #24374.
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

ping @amitkris do we need something for Solaris, or is that using the _linux.go file?

@thaJeztah : Solaris will be using  _disabled.go atleast initially, so we're covered. Thank you for reaching out! :)

@amitkris cool, thank you!
@yongtang doesn't windows use _disabled.go as well?

Thanks @thaJeztah @amitkris for the review.
@thaJeztah I had some confusion about the build tag too. Before my commit, the build tag was
// +build !seccomp,!windows and  seccomp,linux, and it caused build error on windowsRS1 when I added supportsSeccomp.
That was why I added the _windows.go
Let me take a deeper look into it and see my understanding is correct or not.

Thanks! Perhaps it's okay, was just wondering if we could just remove the !windows from the _unsupported.go file, but maybe not

@thaJeztah I take a second look. Both _disabled.go and _linux.go uses SeccompProfile which only exist in linux OR freebsd (see container_unix.go).
Based on it I think the following would cover all cases (comma as AND) and easier to maintain:
_linux.go:
// +build linux,seccomp
_disabled.go:
// +build linux,!seccomp
_unsupported.go:
// +build !linux
I updated the PR based on above. Please let me know if there are any issues.

nice! LGTM (if CI is green 😇 )

LGTM, thanks for fixing.


Problems with special characters in the Polish version of tessdata

Environment

Tesseract Version: 5.1.0
Platform: Windows 32-bit, compiled under MSVC 2017

Current Behavior:
I have the following problem..

I prepared a custom build for Tesseract 5.1.0, so as to generate dlls, which I then use in the project of a 32-bit .exe application.
I prepared the following dependencies with CMake 3.23 (without SW build)
a. tesseract 5.1.0, leptonica 1.82.0, libtiff 4.3.0, libjpeg-turbo 2.1.3, zlib 1.2.11, libpng 1.6.37.
b. Links to src:
tesseract 5.1.0 (https://github.com/tesseract-ocr/tesseract/releases) – 01.03.2022
leptonica 1.82.0 (http://www.leptonica.org/download.html) – 22.09.2021
libtiff 4.3.0 (http://download.osgeo.org/libtiff) – 20.04.2021
libjpeg-turbo 2.1.3 (https://github.com/libjpeg-turbo/libjpeg-turbo/releases ) – 25.02.2022
zlib 1.2.11 (https://github.com/madler/zlib/tags) – 15.01.2017
libpng 1.6.37 (https://github.com/glennrp/libpng/releases/tag/v1.6.37) – 14.04.2019
Then I used the model: pol.traineddata from https://github.com/tesseract-ocr/tessdata_fast for process image:

a. I got the result: "janQkowalski".
b. The 'Q' character was not recognized correctly.
c. My problem is that I have to scan a lot of address data, incl. emails and no matter how large the font is, the '@' character is recognized as 'Q'.
d. I checked on the version 4.1.1 it works properly. Maybe this is important info: I only use the "pol" language for the OCR parameterization.

Expected Behavior:
I expect special characters such as '@' to be recognized regardless of the language selected (especially for pol version, but maybe for another langugage problem still exist). For example in german version problem isn't reproducible.
Suggested Fix:
Is there any workaround to this behavior? If this is not the correct place, please give me info, but on the other hand, if something worked in 4.1.1 and now doesn't work, it should be treated as a bug.

Are you using the same traineddata file with 4.1.1?

Hello @Shreeshrii,
exactly the same. If that helps, here's my tessdata folder.
tessdata.zip

1). Today I started doing tests combined with another language - ie. "pol+eng". Surprisingly, for this case, the '@' sign started to be properly recognized.
2). However, not always strings with '@' are correctly recognized, especially if they are smaller -> example below.
File:

Result for only 'pol' language:

Result for 'pol+eng' languages:

Result for 'pol+deu' languages:

Here, 'pol' + 'deu' is doing best here, but the problem is that some Polish letters, ie "ó", are recognized as German "ö", so I would have to think about another solution. Do you have any ideas what could be done to make the special characters correctly recognized?

Hello @krzysiekj94. You could try the Latin model. At first glance it seems to produce good results, but maybe you need to finetune some character to get proper results for all polish character.

Hello @JKamlah,
1). in the case Latin I found some mistakes by ocr process with PL letters - model "pl+Latin". Sometimes engine returns "t" instead of "ł".

2). in the case combined pl and eng model I found less mistakes by ocr process with PL letters - model "pl+eng". There are no problems with PL characters here, but latin is better at dealing with email addresses.
Next problem is that "pl+latin" is slower than "pl+eng". For example, for a 30 page tiff, OCR time for Latin takes about 3 minutes, while for "pl + eng" 2 times less. I think here the "pl + eng" model wins a bit.
Do you have any other ideas what I could try?

You could try: Finetuning
This technique will work best if you want to work with a small set of font types and fix glyph ranges, which you want to detect properly. So it depends on your task.

Use "latin" model only and not "pl+latin" (it seems you work with mixed languages all based on latin script?)
Extend the dictionary with polish words (or just get rid of the existing one). If you have some fix keywords, add these to the dict(!).
-> use combine_tessdata to (un-)pack the model and dawg2wordlist/ wordlist2dawg to convert dawg to wordlist and vice versa. The wordlist can be edit with a simple texteditor.
Find the characters which get most often confused ("t" instead of "ł" etc. )
Generate artificial or transcribe some ground truth and finetune the latin model
Or find some polish GT..
Finetune the latin model (you can only train best-models) with tesstrain
-> You can find some examples in the tesstrain-wiki

To find the best workflow, you could use some tooling to get proper values and more insights:

Generate a ground truth set for validation
Evaluate the OCR result with ocreval

You could try: Finetuning This technique will work best if you want to work with a small set of font types and fix glyph ranges, which you want to detect properly. So it depends on your task.
1. Use "latin" model only and not "pl+latin" (it seems you work with mixed languages all based on latin script?)

2. Extend the dictionary with polish words (or just get rid of the existing one). If you have some fix keywords, add these to the dict(!).
   -> use [combine_tessdata](https://digi.bib.uni-mannheim.de/tesseract/manuals/combine_tessdata.1.html) to (un-)pack the model and [dawg2wordlist](https://digi.bib.uni-mannheim.de/tesseract/manuals/dawg2wordlist.1.html)/ [wordlist2dawg](https://digi.bib.uni-mannheim.de/tesseract/manuals/wordlist2dawg.1.html) to convert dawg to wordlist and vice versa. The wordlist can be edit with a simple texteditor.

3. Find the characters which get most often confused ("t" instead of "ł" etc. )

4. Generate artificial or transcribe some ground truth and finetune the latin model
   Or find [some polish GT](http://dl.psnc.pl/activities/projekty/impact/results/)..

5. Finetune the latin model (you can only train best-models) with [tesstrain](https://github.com/tesseract-ocr/tesstrain)
   -> You can find some examples in the [tesstrain-wiki](https://github.com/tesseract-ocr/tesstrain/wiki)

To find the best workflow, you could use some tooling to get proper values and more insights:
1. Generate a ground truth set for validation

2. Evaluate the OCR result with [ocreval](https://github.com/eddieantonio/ocreval)

Thanx for suggestions. I will try it.


Update text-decoration.json

Ships by default in Chrome 57/Opera 44. https://www.chromestatus.com/feature/5766823203045376

Confirmed, thanks!


tag = "kan-bayashi/jsut_fastspeech2" trivial problem

In espnet2_tts_demo.ipynb google colab and in my local notebook shows strange problem.
When I input the following sentence,
"この谿谷の、最も深いところには、木曽福島の関所も、隠れていた。"
last character is missing, no sound.
tag = "kan-bayashi/jsut_fastspeech2"
vocoder_tag = "jsut_multi_band_melgan.v2"
Other tags including "kan-bayashi/jsut_conformer_fastspeech2" does not show the problem.

Sometimes, duration predictor failed to predict durations. Maybe that is the reason of the failure.
By introducing the conformer, the convolution module can capture the local context better than the standard transformer, and therefore, the conformer-fastpseech2 is more robust to the input text content.

I also confirmed the above behavior.
Interestingly,  この谿谷の、最も深いところには、木曽福島の関所も、隠れていた is failed but この谿谷の、最も深いところには、福島の関所も、隠れていた is OK.

If you have a further discussion, please re-open.


Initial tests for debug info

To make fixtures visible for all the tests, moved them to separate config file.
To know more about pytest features look to docs:
https://docs.pytest.org/en/stable/fixture.html#scope-sharing-fixtures-across-classes-modules-packages-or-session

@reazulhoque For some reason tests on "level0" are failed here. Error is "SyclProgramCompilationError", so I temporarily disabled them. Could you please look into get_kernel_ir() function in the test, may be I do something wrong for level0?


Bug/bl 302 fixing mentee intake application endpoint

Description
-- fixed bug that wasn't allowing mentees/mentors applications to post to our BE severs. Updated relevant fields to their actual values in-line with DS API 0.48.0. Submitted forms weren't intaking the correct values for 'other_info' and 'convictions',  changes reflect the application submitting with the correct values.
Fixes # (689)
## Loom Video
Jira Board Link
https://bloomtechlabs.atlassian.net/browse/BL-689
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[x] I have made corresponding changes to the documentation if necessary (optional)
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Great bug fix, allowing mentors/mentees to access BE is a great feat!

What a win -- this work is a triumph. I specifically found the referred_by and heard_about stuff very interesting!


Provisioner is kernel ceph only

If a storage class has provisionVolume: true, the provisioner fails on nodes without kernel ceph support, since createVolume has mountKernel hardcoded.  Does it make sense to use the mounter specified by volOptions.Mounter?

good point!
in the long run, i would like to see a cephfs fuse mounter and use it for provisioner
@gman0

Thanks for the suggestion, this will get in as a post-0.3.0, meaning the beginning of the next week if everything goes smoothly.


[Quick - Tour] Curl command error in creating service.bal

Description:
In instruction #8 curl command doesnt work. It has to be modified as follows
curl -d "{'firstNumber':10,'secondNumber':200,'operation':'add'}" "http://localhost:9090/calculator/operation" -H "Content-Type:application/json"
or a json data file can be attached like follows
curl -d<EMAIL_ADDRESS>-X POST "http://localhost:9090/calculator/operation" -H "Content-Type:application/json"
data.json
{
"firstNumber":10,
"secondNumber":200,
"operation":"add"
}
Suggested Labels:

Suggested Assignees:

Affected Product Version:
Ballerina 0.980.0
curl 7.55.1 (Windows) libcurl/7.55.1 WinSSL
OS, DB, other environment details and versions:
Windows 10

@mster3313 Could you please point me to the exact link to which you are referring?

@pranavan15 I think this issue is about the service on https://ballerina.io/community-program/ page

Tested the current version, which works fine. Last commit that modified this section belongs to the PR https://github.com/ballerina-platform/ballerina-www/pull/1008.

@mster3313 Closing this issue as per the above comment. Please re-open if you have any concerns.


[14.0.x] ISPN-15712 org.apache.commons:commons-compress 1.26.0

Build error

Build error

Stupid Jakarta modules :man_facepalming:

Argh, spring test failures due to an older spring boot version on 14.0.x. 3rd time  lucky :crossed_fingers:


Feature: Opus as additional audio codec

I was asked to create this PR, so this will add opus as audio codec.
As described in the  Forum thread.
If you prefer one commit I can squash them into one.
Feel free to add comments.

Looks very good. You should just put empty lines above comment lines, and I'd also rewrite the writeint macro as a function, like it's done in other encoders.
Is error.opus small enough, free of charge and under a suitable license?
I think you've forgotten to add the opus headers and libraries (in /extlibs).

Opus is a next gen xiph.org codec licensed under 3-clause BSD that should according to tests beat both Speex and Ogg Vorbis in their respective fields.
For size

file
size
file
size
file
size
file
size

libvorbis.so
175k
libvorbis.a
233k
libvorbisfile.so
35k
libvorbisfile.a
34k

libopus.so
294k
libopus.a
561k
libopusfile.so
46k
libopusfile.a
54k

on my x86_64 Debian machine, sizes on other platforms should be similar. It is slightly bigger than Vorbis, but not much and covers both speech and music.

@LaurentGomila
Sample file: It is public domain through the CC 0 license, took it from this place Freesound. But I will replace it with an other encode, I noticed it is unneeded big.
Also with the last commit I think I implemented your notes (empty lines, rewrote writeint).

Ahh the static android libraries are missing, will commit them.
I had to modify the build script because the new NDK uses gcc toolchain 4.9 not 4.8 thats why it failed for me...

The MSVC libraries can be built by someone else, don't worry.
The writeInt function still needs some formatting for compliance with our coding rules. I adapted a similar function found in the WAV encoder, for consistency. I also removed the offset argument, since it can simply be added to buffer when the function is called.
    // Make sure to write int into buffer little endian
    void writeInt(unsigned char* buffer, sf::Uint32 value)
    {
            buffer[0] = static_cast<unsigned char>(value & 0x000000FF),
            buffer[1] = static_cast<unsigned char>((value & 0x0000FF00) >> 8),
            buffer[2] = static_cast<unsigned char>((value & 0x00FF0000) >> 16),
            buffer[3] = static_cast<unsigned char>((value & 0xFF000000) >> 24),
    }

Ok changed that, removed include it is useless (I used it to debug but forgot to remove it).

tolower() is -- like everything in the C++ standard library -- part of the std namespace

He just copied the code that I wrote in other encoders. And I probably did that on purpose (I never explicitly scope a symbol just for fun). Maybe the C++ version don't compile here due to template/overload stuff? I don't remember.

Thanks a lot for your contribution! The code looks mostly good, I've added some comments (mostly related to style or non-standard C++).

sfml is not going to use c++11 or is it?
If not I have to rewrite my changes (used std::vector with c++11 only functions to replace non c++ dynamic arrays (c99)). Like initializer lists and std::vector:data()

SFML currently uses C++98. Which doesn't matter, because variable-length arrays are not part of any C++ standard. They have been introduced to C99, but never to C++.
As an alternative, a library-based solution was discussed for C++14, namely std::dynarray, however it was voted out [1, 2].

@Bromeon Thank you!
I think I resolved all your comments.

SFML currently uses C++98, and it will use C++11 starting from a future major version 3.

Ok I replaced the dynamic arrays with std::vector where only read support is needed and the other dynamic buffer with heap memory (new).
With c++11 some lines can be improved (&vector.front() can be replaced with vector.data(), initalizer_list constructors...), but I think it is ok for the moment.

Looks much better, thanks for adapting! There are still some notes, sorry for being picky :grimacing:
Maybe you should have a look at the style guide. For minor things, I guess we could also do a final touch, instead of annotating every single misplaced character.

Ok I replaced the dynamic arrays with std::vector where only read support is needed and the other dynamic buffer with heap memory (new).

Avoid new[] and use std::vector everywhere. You can write to vectors just as easily. Dynamic memory management is generally a bad idea, I wrote an article about it in case you're interested.

With c++11 some lines can be improved (&vector.front() can be replaced with vector.data(), initializer_list constructors...), but I think it is ok for the moment.

Yeah, that looks good.

No problem ;-)
Ok changed  that.
Thank you for the link, I will read it later. I personally have no problem with new and delete in a function, but I dislike using it between functions / classes when the owner is not clear.

How is this coming along? I would absolutely love to have Opus support in SFML!

@susnux Could you rebase this on to master?

@eXpl0it3r ok rebased the branch.

Minor suggestion: I would not add something to the example, especially if it adds a new resource without demonstrating something new in the API (the goal is to keep SDK size as low as possible).

@LaurentGomila I have added the example, because ogg and flac also added an example for playing a flac/ogg file, I can remove it if you prefer that.

Yeah, I added the FLAC file to the example as well and I think it's okay to add ome for Opus as well, as long as it's reasonably small.

I agree with Laurent. Wouldn't add anything, since it's really just another file format used the very same way with nothing new to show. It's just a different string passed as a parameter. If you spin that further we'd have to add Windows Bitmaps and other image formats as well.

I don't mind another small resource like this one personally. It's very convenient to have those examples around when we want to quickly test a feature/bugfix. In any case, we might want to move all examples to a dedicated git repo at some point.

Yes, I agree that it can be convenient for quick testing after modifications to the audio module. But for that we'd better have proper (unit) tests ;)

Definitely, but at the same time we are so far away from a usable unit test suite that this seems more than reasonable to me.

Alright.

I'll look into building Windows libraries.

So I've been trying to build opus for Windows for the better part of the day and kept running into linker issues. Talking with someone in the opus IRC channel, it became clear, that for opus below version 1.2 (currently this PR uses 1.1.2), one not only has to link opus and opusfile, but also celt and silk. Version 1.2 which currently is in alpha combines celt and silk directly into opus.
The FindOpus.cmake script doesn't seem to know about these celt or silk libraries as such I'm curious how you managed to build SFML on your system?
Finally I'm not sure whether we really want to add four new dependencies.

If dependencies become an issue, we can maybe think about adding some codecs as plugins. The classes are already made for such usage, we'd just have to add a plugin loader/manager to the audio module.

@eXpl0it3r

I'm curious how you managed to build SFML on your system?

I just installed the libraries required by SFML and in addition libopus and libopusfile.
I am developing and testing on openSUSE Leap 42.1, so I have libopus 1.1 and libopusfile 0.8.
SFML builds successfully, no linking issue and it seems like there is no special magic when building libopus:
./configure --disable-silent-rules  --disable-doc --enable-custom-modes
Here is my build log of SFML with opus support: log2.txt
There is also no celt in linked libraries of sfml-audio.so:
% ldd lib/libsfml-audio.so
        linux-vdso.so.1 (0x00007ffc99c05000)
        libsfml-system.so.2.4 => /home/ferdinand/Dokumente/Projekte/C++/SFML/build/lib/libsfml-system.so.2.4 (0x00007f2a503eb000)
        libopenal.so.1 => /usr/lib64/libopenal.so.1 (0x00007f2a50143000)
        libvorbisenc.so.2 => /usr/lib64/libvorbisenc.so.2 (0x00007f2a4fc73000)
        libvorbisfile.so.3 => /usr/lib64/libvorbisfile.so.3 (0x00007f2a4fa63000)
        libvorbis.so.0 => /usr/lib64/libvorbis.so.0 (0x00007f2a4f833000)
        libogg.so.0 => /usr/lib64/libogg.so.0 (0x00007f2a4f62b000)
        libopusfile.so.0 => /usr/lib64/libopusfile.so.0 (0x00007f2a4f41b000)
        libopus.so.0 => /usr/lib64/libopus.so.0 (0x00007f2a4f1cb000)
        libFLAC.so.8 => /usr/lib64/libFLAC.so.8 (0x00007f2a4ef8b000)
        libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f2a4ed6b000)
        librt.so.1 => /lib64/librt.so.1 (0x00007f2a4eb63000)
        libstdc++.so.6 => /usr/lib64/libstdc++.so.6 (0x00007f2a4e7db000)
        libm.so.6 => /lib64/libm.so.6 (0x00007f2a4e4d3000)
        libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f2a4e2bb000)
        libc.so.6 => /lib64/libc.so.6 (0x00007f2a4df13000)
        libdl.so.2 => /lib64/libdl.so.2 (0x00007f2a4dd0b000)
        libcrypto.so.1.0.0 => /lib64/libcrypto.so.1.0.0 (0x00007f2a4d913000)
        /lib64/ld-linux-x86-64.so.2 (0x0000562c8d37e000)
        libz.so.1 => /lib64/libz.so.1 (0x00007f2a4d6fb000)

I talked with the same person again on IRC and it seems I misunderstood them. The split of these libraries only exists in the VS solution and was merged after 1.1.3 into one VS project.
I'll try and see if one can just move all the files from the other projects into one a build it like that.

I have picked this up again. After spending a lot of hours getting all the libraries to build, the MinGW version finally builds and links just fine, unfortunately the example opus file doesn't play a sound. Next I'll have to build opusfile for VS and see if it works there. I'll certainly keep investigating this.
Example code:
#include <SFML/Audio.hpp>
#include <iostream>

int main()
{
    sf::Music music;
    if (!music.openFromFile("file.opus"))
        return 0;

    std::cout << " " << music.getDuration().asSeconds() << " seconds"       << std::endl;
    std::cout << " " << music.getSampleRate()           << " samples / sec" << std::endl;
    std::cout << " " << music.getChannelCount()         << " channels"      << std::endl;

    music.play();

    while (music.getStatus() == sf::Music::Playing)
    {
        sf::sleep(sf::milliseconds(100));

        std::cout << "\rPlaying... " << music.getPlayingOffset().asSeconds() << " sec        ";
        std::cout << std::flush;
    }
    std::cout << std::endl << std::endl;

    std::cout << "Press enter to exit..." << std::endl;
    std::cin.ignore(10000, '\n');
}

This PR has been superseded by #1259!
Let me know if there are some additional changes to re-sync.


add dark mode to the editor

These changes:

adds dark mode to the sprig editor
that's it!

@JosiasAurel can you confirm this pr changes no behavior by default, and any change in this setting would be opt-in?


bugfix: 移动端搜索结果跳转

Codecov Report

Merging #1001 (4097422) into v2.6.x_develop (4f1bade) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           v2.6.x_develop    #1001   +/-   ##
===============================================
  Coverage           60.76%   60.76%
===============================================
  Files                 467      467
  Lines               29880    29880
===============================================
  Hits                18157    18157
  Misses              11723    11723

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Android] Fix autolinking: Remove redundant package

Why
Fixes #1
It looks like RN autolinking supports only one class implementing ReactPackage per library on Android. This library had two packages and one wasn't added to the generated com.facebook.react.PackageList in the app project.
How
Deleted the VolumeManagerSilentListenerPackage and moved the VolumeManagerSilentListenerModule initialization to VolumeManagerPackage.
Test plan
Tried this with a plain new RN app (the example app still uses manual linking):
npx crna my-app
yarn add react-native-volume-manager
# here applied the PR changes to `node_modules/react-native-volume-manager`
expo run:android

You're the GOAT! Thank you so much!


Link vs. Link Contribution vs. Embedded

I built a serializer that would accept a full, nested representation for a model and create an instance for that representation.  Once the representation existed, it made sense to return a _links entry for that instance.  To do this, I wrapped a Serializer with a class that (in to_representation) extracted serialized[LINKS_FIELD_NAME][URL_FIELD_NAME] and inherited from HalIncludeInLinksMixin to get it put in links.
Unfortunately, this nested serializer matches both _is_link_field and _is_embedded_field.  This is a problem because to_representation uses pop on link_field_names so the field is absent by the time embedded_field_names tries to access it (i.e. KeyError).
I'm looking for feedback on the situation:

Are asymmetric serializers anti-pattern?  Should I have a separate read and write serializer?  Or is it even anti-pattern to use asymmetric serializers on a view?  For example, the RFC says:

A successful PUT of a given representation would suggest that a subsequent GET on that same target resource will result in an equivalent representation being sent in a 200 (OK) response.

At least for the sake of argument, I submit that a _links entry is "equivalent" (they did not say "identical") to the original, embedded resource.

If an asymmetric serializer like this is reasonable, we could improve _is_embedded_field, is_link_field, and is_link_contribution_field to ensure a field never matches more than one.

We would need to agree on a priority in the event of conflicts. In my case, (1) link, (2) link contribution, and (3) embedded makes sense, but maybe not in a broader analysis.

Other suggestions?

I think this would be fixed by #116 since you can exclude the representation from embedded fields.


Stylelint v14 compatibility

Will there be an update which supports Stylelint v14?

Yes, just haven't gotten around to do it yet.


cannot install angularjs.Typescript.DefinitelyTyped

Response status code does not indicate success: 400 (One of the request inputs is out of range.).

is this related? https://github.com/borisyankov/DefinitelyTyped/issues/4241

@staxmanade yup, that's it

Closing for now, let me know if there is anything more you have to add...

The same error with angular-ui.TypeScript.DefinitelyTyped.

@kelong have you tried the update : http://blog.nuget.org/20150226/nuget-3.0-beta2.html

@basarat Yes, it is not nuget related problem. Only those 2 packages can't install in cordova project.

@kelong And you are getting the same error response : 400?

Yes
Rgrds,
Maciej Lelito
On Sun, May 31, 2015 at 2:32 PM -0700, "Basarat Ali Syed"<EMAIL_ADDRESS>wrote:
@kelong And you are getting the same error response : 400?
—
Reply to this email directly or view it on GitHub.

But it works in a new non Cordova project?

It doesn't matter. I created new blank project. I see that new version angularjs.TypeScript.DefinitelyTyped 3.9.2 came out, will test this out.

I have nuget 3.0.60410.213 installed for VS2015 RC. Nuget package manager don't even see 3.9.2 version of angularjs.TypeScript.DefinitelyTyped. When I try manually enter version:
install-package angularjs.TypeScript.DefinitelyTyped -Version 3.9.2
still the same error:
Response status code does not indicate success: 400 (One of the request inputs is out of range.).

I am on Visual Studio 2013 Update 4 and it works fine:

And since the version is available on nuget : https://www.nuget.org/packages/angularjs.TypeScript.DefinitelyTyped/ I'd prefer if you reported it here : https://nuget.codeplex.com/WorkItem/Create?ProjectName=nuget < I know a horrible url to give someone but last I checked this was the way to go :rose:

Ok, thanks.

Thanks. For reference of everyone else the issue now lives here : https://nuget.codeplex.com/workitem/8333

same problem, any solution?

Yes, it works on vs2013.


future proof open-ended ProtocolType

See #390

This has largely been borrowed from AppProtocol.

@thockin Do you have any ideas on how we could expand the list of protocols we support on Gateway listeners?

Thanks! Interested in any final feedback from @danehans or @jpeach here.
/approve

/cc @danehans

/lgtm
I created https://github.com/kubernetes-sigs/service-apis/issues/433 to capture the need to define "Extended" protocol types.


Allow turbolift to toggle or set draft status for PRs

Would help with usability of #11

Is this still an issue after https://github.com/cli/cli/pull/5995? Since we now presumably have turbolift foreach gh pr ready --undo
There might still be the problem of setting the default remote repository before this command will work. But I'm not sure whether that's an issue to be dealt with here.

Nice one, thanks for raising this @Dan7-7-7 ! Wasn't aware of https://github.com/cli/cli/pull/5995, this is great news.
I'd be happy to close this PR, we could maybe discuss the possible shortcut of using turbolift update-prs with extra flags for this. I'll leave it open until our next turbolift review board.
cc @rnorth


[Enhancement] Icon for attachments in message list

From #8 - a feature request from @Kabouik to indicate whether a message has attachments in the message list.

Development notes:
Supporting this will require changes to how nmail fetches email headers, in particular instead of using only RFC822_HEADER we'd need to fetch BODYSTRUCTURE. Local cache version would need to be bumped and old caches invalidated.

FYI @Kabouik - support for message list indication of attachments has finally been implemented. The indication symbol is configurable, by default it's set to +.

FYI @Kabouik - support for message list indication of attachments has finally been implemented. The indication symbol is configurable, by default it's set to +.

Awesome, thanks. I must say seeing all those Github notifications about closed issues in my nmail box felt great!

Awesome, thanks. I must say seeing all those Github notifications about closed issues in my nmail box felt great!

Haha, yeah it's been long overdue for many over the suggestions/requests. 2020 was a busy year, I hope this year will be better. :)

Haha, yeah it's been long overdue for many over the suggestions/requests. 2020 was a busy year, I hope this year will be better. :)