pointer.leftButtonReleased() while holding RMB on DRAG_END reports false (wrong), instead of true (correct) value

Version

3.55.2

Windows 10
Description

....
.on(Phaser.Input.Events.DRAG_END, this.OnSceneDragEndHandler, this)
....
private OnSceneDragEndHandler(
    pointer: Phaser.Input.Pointer,
    gameObject: Phaser.GameObjects.GameObject): void
{
    // true if LMB was released and RMB was not held, false if LMB was released while RMB was held (!!!)
    console.log("pointer.leftButtonReleased()=",pointer.leftButtonReleased())
    // false if LMB was released and RMB was not held, false if LMB was released while RMB was held
    console.log("pointer.rightButtonReleased()=",pointer.rightButtonReleased())
}

Additional Information

The correct behavior would be to report pointer.leftButtonReleased() as true when LMB is released, while RMB, MMB, FWDMB, BACKMB (or any other buttons, keys, etc) are held. Pretty sure there are other permutations, where this might be causing problems, like holding LMB and releasing RMB (or other keys). Lastly, its expected this to work through other triggers (not just DRAG_END).

The behavior you are experiencing with the pointer.leftButtonReleased() and pointer.rightButtonReleased() methods is expected. These methods return true if the respective button was released during the current frame, and false otherwise.
In the case you described, if you release the left mouse button while the right mouse button is being held down, pointer.leftButtonReleased() will return false because the left button was not released during the current frame. Similarly, pointer.rightButtonReleased() will return false because the right button is still being held down.
If you want to check if the left mouse button is not currently being held down, regardless of whether it was released during the current frame, you can use !pointer.leftButtonDown() instead. Similarly, if you want to check if the right mouse button is not currently being held down, you can use !pointer.rightButtonDown().
Regarding your last point, you can use any pointer event to check the status of the mouse buttons, not just Phaser.Input.Events.DRAG_END. For example, you can use Phaser.Input.Events.POINTER_UP to detect when a button is released.
Hope this helps!

SlimHR

This issue has been resolved.
The Pointer now correctly checks for multiple mouse button presses.
This change will be reflected in the next Phaser update.


S3 GetObjectAsync returns HttpErrorResponseException from  InvokeAsyncCallback()

What I want a do is very simple, I'm trying to download a text file from s3 to my unity project and read its contents. But I'm stuck in the simplest part of it all. I'am fallowing the s3 example projects getobject method to localize the error. So far I havent been able to run anything related to S3 from unity.
I'm currently using the <IP_ADDRESS> version of the sdk. I apologize if there are any formatting errors on my post. Here are errors from the log messages:
1

HttpErrorResponseException: Exception of type 'Amazon.Runtime.Internal.HttpErrorResponseException' was thrown.
Amazon.Runtime.Internal.RedirectHandler.HandleRedirect (IExecutionContext executionContext) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/Handlers/RedirectHandler.cs:138)
Amazon.Runtime.Internal.RedirectHandler.InvokeAsyncCallback (IAsyncExecutionContext executionContext) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/Handlers/RedirectHandler.cs:78)
Amazon.Runtime.Internal.PipelineHandler.AsyncCallback (IAsyncExecutionContext executionContext) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/PipelineHandler.cs:95)
UnityEngine.Debug:LogException(Exception)
Amazon.Runtime.Internal.Util.UnityDebugLogger:Error(Exception, String, Object[]) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Internal/Util/_unity/UnityDebugLogger.cs:39)
Amazon.Runtime.Internal.Util.Logger:Error(Exception, String, Object[]) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Internal/Util/Logger.cs:145)
Amazon.Runtime.Internal.PipelineHandler:AsyncCallback(IAsyncExecutionContext) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/PipelineHandler.cs:100)
Amazon.Runtime.Internal.PipelineHandler:InvokeAsyncCallback(IAsyncExecutionContext) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/PipelineHandler.cs:131)
Amazon.Runtime.Internal.HttpHandler`1:GetResponseCallbackHelper(Object) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/HttpHandler/HttpHandler.cs:337)

2

An exception of type HttpErrorResponseException was thrown from InvokeAsyncCallback().
UnityEngine.Debug:LogError(Object)
Amazon.Runtime.Internal.Util.UnityDebugLogger:Error(Exception, String, Object[]) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Internal/Util/_unity/UnityDebugLogger.cs:42)
Amazon.Runtime.Internal.Util.Logger:Error(Exception, String, Object[]) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Internal/Util/Logger.cs:145)
Amazon.Runtime.Internal.PipelineHandler:AsyncCallback(IAsyncExecutionContext) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/PipelineHandler.cs:100)
Amazon.Runtime.Internal.PipelineHandler:InvokeAsyncCallback(IAsyncExecutionContext) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/PipelineHandler.cs:131)
Amazon.Runtime.Internal.HttpHandler`1:GetResponseCallbackHelper(Object) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/HttpHandler/HttpHandler.cs:337)

3

NullReferenceException: Object reference not set to an instance of an object
AWSSDK.Examples.loadfile.m__35 (Amazon.Runtime.AmazonServiceResult`2 responseObj) (at Assets/Scripts/loadfile.cs:115)
Amazon.S3.AmazonS3Client+<>c__DisplayClass74_0.b__0 (Amazon.Runtime.AmazonWebServiceRequest req, Amazon.Runtime.AmazonWebServiceResponse res, System.Exception ex, Amazon.Runtime.AsyncOptions ao) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Services/S3/Generated/_unity/AmazonS3Client.cs:1537)
Amazon.Runtime.Internal.UnityMainThreadDispatcher.ProcessRequests () (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/_unity/UnityMainThreadDispatcher.cs:82)
UnityEngine.Debug:LogException(Exception)
Amazon.Runtime.Internal.Util.UnityDebugLogger:Error(Exception, String, Object[]) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Internal/Util/_unity/UnityDebugLogger.cs:39)
Amazon.Runtime.Internal.Util.Logger:Error(Exception, String, Object[]) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Internal/Util/Logger.cs:145)
Amazon.Runtime.Internal.UnityMainThreadDispatcher:ProcessRequests() (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/_unity/UnityMainThreadDispatcher.cs:89)
Amazon.Runtime.Internal.UnityMainThreadDispatcher:Update() (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/_unity/UnityMainThreadDispatcher.cs:59)

4

NullReferenceException: Object reference not set to an instance of an object
AWSSDK.Examples.loadfile.m__35 (Amazon.Runtime.AmazonServiceResult`2 responseObj) (at Assets/Scripts/loadfile.cs:115)
Amazon.S3.AmazonS3Client+<>c__DisplayClass74_0.b__0 (Amazon.Runtime.AmazonWebServiceRequest req, Amazon.Runtime.AmazonWebServiceResponse res, System.Exception ex, Amazon.Runtime.AsyncOptions ao) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Services/S3/Generated/_unity/AmazonS3Client.cs:1537)
Amazon.Runtime.Internal.UnityMainThreadDispatcher.ProcessRequests () (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/_unity/UnityMainThreadDispatcher.cs:82)
UnityEngine.Debug:LogException(Exception)
Amazon.Runtime.Internal.Util.UnityDebugLogger:Error(Exception, String, Object[]) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Internal/Util/_unity/UnityDebugLogger.cs:39)
Amazon.Runtime.Internal.Util.Logger:Error(Exception, String, Object[]) (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Internal/Util/Logger.cs:145)
Amazon.Runtime.Internal.UnityMainThreadDispatcher:ProcessRequests() (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/_unity/UnityMainThreadDispatcher.cs:89)
Amazon.Runtime.Internal.UnityMainThreadDispatcher:Update() (at D:/Jenkins/jobs/v3-stage-release/workspace/AWSDotNetPublic/sdk/src/Core/Amazon.Runtime/Pipeline/_unity/UnityMainThreadDispatcher.cs:59)

Some other non-error messages from the logs:

Attached unity initializer to Canvas
Received response(turncated to 4096 bytes): [{}"Credentials":{"AccessKeyId":"ACCESSKEY","Expiration":1.474822488E9,"SecretKey":"SECRETKEY","SessionToken":"AgoGb3JpZ2luEBwaCXVzLXdlc3QtMiKAAjIk9eY4TEVrCYxkQqlqIRYZqBzOAnE/]

-Request metrics: {"properties":{"AsyncCall":"False","ServiceName":"Amazon.CognitoIdentity","ServiceEndpoint":"https://cognito-identity.us-west-2.amazonaws.com/","MethodName":"GetCredentialsForIdentityRequest","RequestSize":"63","StatusCode":"OK","BytesProcessed":"1508","AWSRequestID":"6323dadf-8338-11e6-9c1f-b3a539d0ad23"},"timings":{"HttpRequestTime":7291.139,"ResponseUnmarshallTime":104.9853,"ResponseProcessingTime":4289.2184,"ClientExecuteTime":11629.381},"counters":{}}
-Request metrics: {"properties":{"AsyncCall":"True","CanonicalRequest":"GET\n/umut1474634241486.txt\n\nhost:ghostmultiplayer.s3-us-west-2.amazonaws.com\nuser-agent:aws-sdk-unity/<IP_ADDRESS> aws-sdk-core/<IP_ADDRESS> .NET_Runtime/2.0 UnityVersion/5.4.0f3 OS/unity__ ClientAsync UnityWWW\nx-amz-content-sha256:e3b0c
all of this coming from this little snippet of code:
public void GetObject()
{
    ResultText.text = string.Format("fetching {0} from bucket {1}", SampleFileName, S3BucketName);
    GetObjectRequest request = new GetObjectRequest()
    {
        BucketName = S3BucketName,
        Key = SampleFileName
    };

    Client.GetObjectAsync(request, (responseObj) =>
    {
        string data = null;
        var response = responseObj.Response;

        if (response.ResponseStream != null)
        {
            using (StreamReader reader = new StreamReader(response.ResponseStream))
            {
                data = reader.ReadToEnd();
            }

            ResultText.text += "\n";
            ResultText.text += data;
        }

    });
}

Also I made sure that I'm using the right s3 bucket region, but still getting same errors as above

What is the code on line Assets/Scripts/loadfile.cs:115 ?
The exception only lists the callstack, not the message. Can you capture the exception message as well?

Is the time on your computer wrong?

Closing for lack of activity, feel free to reopen.


When edit node template, Save button is actually "Create"

Version: master-head (7/16/19)
What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Create a node template
Edit the node template and attempt to save changes.

Result:
The button is %saveCancel.create% ("Create") instead of %saveCancel.edit% ("Save")
Other details that may be helpful:
This is a simple change to the ui template that I can do.
Related: rancher/rancher#18730

I'm not sure what has changed, but checked again and now when I create a node template and edit it in latest master-head I do NOT see the issue. Someone must have already fixed this somewhere.


Update README

Update README

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

Why is my request pool not being considered?

My request pool is ready for consideration

There is a typo in the documentation. The same definition is repeated twice

Hey. Please review the change request


Minor updates for moi06

Tests are passing with LQOI master. As JuliaOpt/GLPK.jl#74, it can be merged once LQOI is tagged.
Next step will be to update to julia 1.0

Can we merge?


SNOW-911327: Use CTAS for save as table

Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #1046, #SNOW-911327

Fill out the following pre-review checklist:

[ ] I am adding a new automated test(s) to verify correctness of my new code
[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency

Please describe how your code solves the related issue.
In PR #895 we started using create-table-insert-values pattern instead of using a CTAS pattern for saving dataframes. This is causing issues for multiple users so we are using CTAS while also respecting nullable columns. The tests added before also work for the correctness of this change.

To make sure I understand, we only revert the CTAS -> create and insert change, but not the original changes to allow nulls, right?
As for table_type, as long as we have one test that tests table_type, we should be okay.

We only revert CTAS -> create+insert statement but keeping the NULL changes. In the first PR, I didn't know it was possible to enforce schema nulls using CTAS until yijun showed it to me. Note we haven't removed any nullable schema checks that were added earlier.


Suggestion: Make the back button/gesture close the app

Right now pressing the back button/gesture opens the folder list and if you press it again then the app closes. It feels very unintuitive.

Pressing the back button used to close the app. However, some people complained about "leaving the app quickly", see #36.
I think the best way to solve this, is to provide an option in settings.

Any suggestions for the settings name? @Turbolqk

How about Quick exit? With description like "Close Noto with a single back action."

Great!

This small feature is now supported in version 2.2.1. Please, let me know your thoughts!


Unable to launch Jenkins agent on test-macincloud-macos1014-x64-1

Node test-macincloud-macos1014-x64-1 agent has failed, and cannot be re-launched
https://ci.adoptopenjdk.net/computer/test-macincloud-macos1014-x64-1/

Im unable to ping the machine, and I get this when trying to ssh into it
Haroons-MacBook-Pro:~ haroonkhel$ ssh<EMAIL_ADDRESS>ssh: connect to host <IP_ADDRESS> port 22: Network is unreachable

Looks like the machine is pingable and sshable again. It seems to be connected to Jenkins too, just low on disk-space

I've migrated all machines to macstadium + given them more disk space


Make SAIL Pipeline compatible with all libraries

Current Situation: Currently SAIL Pipeline only works with River and Sklearn.
Target: Make SAIL Pipeline compatible with Torch and Keras.

Done

Completed.


chore: Updated GitHub actions

Hello,
I recently used your template to start a new Snakemake project and it makes the development process much smoother, thank you!
I noticed that many GitHub actions need to be updated. The most important change is the github/super-linter that changed recently to super-linter/super-linter. All other actions just had version bumps.

@marksantcroos @johanneskoester @endrebak pinging you to make sure the template is updated and fixed

Hello, is there a reason why this PR was not accepted, or is it just an oversight?
@johanneskoester


Fix issue with apt-get on circle ci

Start hitting this:

Issue seems to be the new default image introduced in April 30th.
https://discuss.circleci.com/t/default-machine-executor-image-update/29308
Fix seems to be using a different image:

[x] failed - circleci/classic:201710-01 (failed)
[ ] trying: ubuntu-1604:20190301-01
[ ] next: circleci/classic:201808-01

CI got fixed since yesterday, probably Circle CI acted on it.


Event not produced after sideEffects are submitted using the onExtrinsicTrigger

Expected behavior
When you submit a side effect using onExtrinsicTrigger, it's expected to emit events or at least give you some staus about the submitted side effect.
Actual behavior
No event is emitted and so the flags such as isCompleted,  isError,  isInBlock, isWarning, isFinalized are in their default values.
Steps to reproduce

Make sure you're running the stand-alone (ws://localhost:9944) from branch update_v0.9.17
Visit https://t3rn-alice.vercel.app
Click on Execution
Connect your Polkadot wallet or MetaMask (this does not affect this procedure on this staging environment, it's only used on prod to sign transactions)
Click on the circular + button
Add a transfer side effect, fill the form
Open your console before you submit
Submit the side-effects
Check your console for submission result.

This object is supposed to be emitted more than once as each object contains the recent status of the submitted side effects.
Which version(s) does this affect? (Environment, OS, etc...)

Solved by #297


_86_64  and  _WIN64

when i read the source code of has_new_bits() in afl-fuzz.c , i find afl-fuzz.c use  __x86_64 to distinguish between  32_bit system and 64_bit system. like this:
#ifdef __x86_64__

  u64* current = (u64*)trace_bits;
  u64* virgin  = (u64*)virgin_map;

  u32  i = (MAP_SIZE >> 3);

#else

  u32* current = (u32*)trace_bits;
  u32* virgin  = (u32*)virgin_map;

  u32  i = (MAP_SIZE >> 2);

#endif /* ^__x86_64__ */

However, although i'm using a 64-bit system when i debug , i still execute like a 32-bit system.
so  on windows, we should use _WIN64 macro to distinguish between  32_bit system and 64_bit system.
Because it says in the comments that " This function is called after every exec() on a fairly large buffer, so
it needs to be fast. We do this in 32-bit and 64-bit flavors" ，i think it's important to execute this piece of code correctly

Indeed, you are correct. Could you submit a PR?

enhe, ok


Gpu

fix CMakeList output LD_LIBRARY file
rewrite cuGesvd(still not working)
add equivelem api for Tensor&Storage

I found the way to fix cuGesvd, will commit soon

But I check the type order first, and then choose to convert lhs or rhs, won’t that work?

Why it doesn’t work when lhs>rhs? Sorry I don’t get it

Oh I do the bi-directional astype conversion inside every XXXStorage.cpp
And forgot to do it on Scalar or Tensor approx_eq

Yes. Sorry I wasn't being specific

Yes. Sorry I wasn't being specific

So does it work if I convert both lhs and rhs in Scalar and Tensor approx_eq?

commented out approx_eq for this PR.
Note that linalg_Test.BkUt_Svd_truncate1 test failed


feat: update axios to v0.20.x (#214)

All tests past locally
fixes #214

Anyway we can get this merged in? There was a fix with how axios interacts with proxies release in 0.19 that would be really nice to have

👍

@RasCarlito Everything okay mate? We haven't heard from you?

any plan to this being merged?

The latest is now v0.21.1

The latest is now v0.21.1

@RasCarlito any plan to update this?

@RasCarlito any plan to update this?

In my project, a temporary fix is made by setting axios in a specific version in dependencies.

In my project, a temporary fix is made by setting axios in a specific version in dependencies.

The previous versions contain vulnerabilities :( (only fixed in v0.21.1)

The previous versions contain vulnerabilities :( (only fixed in v0.21.1)

I'm not sure what we should do here, the maintainer hasn't responded to anything. And we need a new release. Can we temporarily fork the project, and publish an alternative until rascalito gets back on his feet? I hope he's okay!
Get Outlook for Androidhttps://aka.ms/ghei36

From: Bálint<EMAIL_ADDRESS>Sent: Friday, January 22, 2021 6:29:28 AM
To: RasCarlito/axios-cache-adapter<EMAIL_ADDRESS>Cc: jahead<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [RasCarlito/axios-cache-adapter] feat: update axios to v0.20.x (#214) (#215)
The previous versions contain vulnerabilities :( (only fixed in v0.21.1)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/RasCarlito/axios-cache-adapter/pull/215#issuecomment-764883298, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGV5AH7PZDL4KVG4ZWQU3TS3B6BRANCNFSM4RRL3MLA.

I'm not sure what we should do here, the maintainer hasn't responded to anything. And we need a new release. Can we temporarily fork the project, and publish an alternative until rascalito gets back on his feet? I hope he's okay!
Get Outlook for Androidhttps://aka.ms/ghei36

From: Bálint<EMAIL_ADDRESS>Sent: Friday, January 22, 2021 6:29:28 AM
To: RasCarlito/axios-cache-adapter<EMAIL_ADDRESS>Cc: jahead<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [RasCarlito/axios-cache-adapter] feat: update axios to v0.20.x (#214) (#215)
The previous versions contain vulnerabilities :( (only fixed in v0.21.1)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/RasCarlito/axios-cache-adapter/pull/215#issuecomment-764883298, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGV5AH7PZDL4KVG4ZWQU3TS3B6BRANCNFSM4RRL3MLA.

Wow this thread is active - i am ok with the forking - does anyone know the maintainer?

Wow this thread is active - i am ok with the forking - does anyone know the maintainer?

@jahead can you bump axios to the latest and then fork this to another repo?

@jahead can you bump axios to the latest and then fork this to another repo?

Please put a link here to forked repository

Please put a link here to forked repository

https://github.com/jahead/axios-cache-adapter
Okay,
I've bumped and run the tests, it all checks out.
I just quickly bumped the axios to "~0.21.1" for peer and dev deps.
I also rebuilt the dist folder.
This is just a stop gap. We should probably put this fork under a organization, and  find out who wants to put time into reviewing the current PRs. and we need to publish to the npm store - I'm just praying @RasCarlito will poke his head in.
we could do @axios-cache/adapter?

https://github.com/jahead/axios-cache-adapter
Okay,
I've bumped and run the tests, it all checks out.
I just quickly bumped the axios to "~0.21.1" for peer and dev deps.
I also rebuilt the dist folder.
This is just a stop gap. We should probably put this fork under a organization, and  find out who wants to put time into reviewing the current PRs. and we need to publish to the npm store - I'm just praying @RasCarlito will poke his head in.
we could do @axios-cache/adapter?

I sent a LinkedIn message/request to @RasCarlito to ask him about maintaining this library.  Maybe we will get a response, all his contact information is on his GH profile though.

I sent a LinkedIn message/request to @RasCarlito to ask him about maintaining this library.  Maybe we will get a response, all his contact information is on his GH profile though.

Yea I've sent him an email as well hopefully we can get through to him
Get Outlook for Androidhttps://aka.ms/ghei36

From: Maxwell Krause<EMAIL_ADDRESS>Sent: Saturday, January 23, 2021 2:24:55 AM
To: RasCarlito/axios-cache-adapter<EMAIL_ADDRESS>Cc: jahead<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [RasCarlito/axios-cache-adapter] feat: update axios to v0.20.x (#214) (#215)
I sent a LinkedIn message/request to @RasCarlitohttps://github.com/RasCarlito to ask him about maintaining this library. Maybe we will get a response, all his contact information is on his GH profile though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/RasCarlito/axios-cache-adapter/pull/215#issuecomment-765481865, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGV5AHFUUDPE6VLIIAKI5LS3GKEPANCNFSM4RRL3MLA.

Yea I've sent him an email as well hopefully we can get through to him
Get Outlook for Androidhttps://aka.ms/ghei36

From: Maxwell Krause<EMAIL_ADDRESS>Sent: Saturday, January 23, 2021 2:24:55 AM
To: RasCarlito/axios-cache-adapter<EMAIL_ADDRESS>Cc: jahead<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [RasCarlito/axios-cache-adapter] feat: update axios to v0.20.x (#214) (#215)
I sent a LinkedIn message/request to @RasCarlitohttps://github.com/RasCarlito to ask him about maintaining this library. Maybe we will get a response, all his contact information is on his GH profile though.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/RasCarlito/axios-cache-adapter/pull/215#issuecomment-765481865, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABGV5AHFUUDPE6VLIIAKI5LS3GKEPANCNFSM4RRL3MLA.

@maxwellsmart84 we should wait for a response before making an issue about it, maybe Monday?
I've also parked the spaces. If we pull the trigger on this, I'll make a issue.

@maxwellsmart84 we should wait for a response before making an issue about it, maybe Monday?
I've also parked the spaces. If we pull the trigger on this, I'll make a issue.

For now
npm install https://github.com/jahead/axios-cache-adapter.git

worked

For now
npm install https://github.com/jahead/axios-cache-adapter.git

worked

@RasCarlito Yea! if you need any help mate, please let us know. We use this project internally so I can put some work time to helping!
I'll close out the organizations that I parked


Version v5.1.0 provides an empty version to engine

What happened?
The latest version of the plugin (5.1.0) is unusable because the engine doesn't accept an empty version.
error: fatal: failed to Init GRPC to register RPC handlers: failed to create resource provider: ProviderInfo needs a semver-compatible version string, got info.Version
error: could not read plugin [/home/spigell/.pulumi/plugins/resource-cloudflare-v5.1.0/pulumi-resource-cloudflare] stdout: EOF

Expected Behavior
The plugin works
Steps to reproduce
[spigell@dragonfish gcp ]$ pulumi plugin install resource cloudflare v5.1.0
[resource plugin cloudflare-5.1.0] installing
Downloading plugin: 19.98 MiB / 19.98 MiB [=========================] 100.00% 3s
[spigell@dragonfish gcp ]$ /home/spigell/.pulumi/plugins/resource-cloudflare-v5.1.0/pulumi-resource-cloudflare -version
<empty>

Output of pulumi about
Backend
Name           pulumi.com
URL            https://app.pulumi.com/spigell
User           spigell
Organizations  spigell, infraunlimited

Dependencies:
NAME                VERSION
@pulumi/cloudflare  5.1.0
@pulumi/gcp         6.52.0
@pulumi/pulumi      3.60.0
@types/node         16.18.22
lint-staged         13.2.0
mrm                 2.6.2
prettier            2.8.7

Additional context
Works well for version 5.0.0
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Thank you for reporting this! The ecosystem team is looking into this shortly, marked as P1.  In the meanwhile recommend downgrading to https://github.com/pulumi/pulumi-cloudflare/releases/tag/v5.0.0

Tagged v5.1.1 and it should be available shortly with a fix. Apologies for the disruption here! This regression should have been caught by our acceptance tests but they were being silently skipped. This is now fixed also.


Update gnomad v3 paper details on publications page

Updates details of the v3 paper

@phildarnowsky-broad this is a very short purely content PR, requesting your review at your convenience.


lastest build key errors to run example currency contract

Hi,
I encountered the following error when I tried to execute
./cleos push action currency issue '{"to":"currency","quantity":"1000.0000 CUR", "memo":
"Test"}' --permission currency@active
2039019ms thread-0   main.cpp:1008                 main                 ] Failed with error: Assert Exception (10)
condition: assertion failed: unable to find key
Request Path: localhost:8888/v1/chain/push_transaction, Request Post Data: {"signatures":["EOSKXaXGTT3aocZyK2dcyHhg9bMXaxEwqRtMZonsNm314qKeSKgtV2iQqDYY8YFpch2rbrS3fwbGTkEeK8Jj2fUe4uvmmT1pV"],"compression":"none","data":"5ef3dc5800000000000000000000000000010000001e4d75af460000000000a53176010000001e4d75af4600000000a8ed32321d0000001e4d75af46809698000000000004435552000000000474657374"}
However, I have already added 5KQwrPbwdL6PhXujxW37FSSQZ1JiwsST4cqQzDeyXtP79zkvFD3 as private key to my wallet.
./cleos wallet keys
[[
"EOS5nGU1fzERfNUXT3Z1XJjNtbQEv7TdCVD6jH1MefkBdBcon892v",
"5JcbmPrYvKTsWeStLgGEz95G5Ta2xCB2Lfb8qm6KHt5ACQfav6H"
],[
"EOS6MRyAjQq8ud7hVNYcfnVPJqcVpscN5So8BhtHuGYqET5GDW5CV",
"5KQwrPbwdL6PhXujxW37FSSQZ1JiwsST4cqQzDeyXtP79zkvFD3"
],[
"EOS7HrtBh5bNZq5uRvA7L1VfayWA1u5vycZcmGMtQAQJiKi3kWPkJ",
"5HzXp5jJNi8E9nh26FHyiytKPqxh7gNtoCCgYsuPYCsDywnZAN2"
]
]
Any idea how to fix this?
Thanks,
Chris

I have the same problem.

@heifner
Do you know this problem，ts

The key mentioned in the error is the currency symbol.
You first need to create the currency before you can issue some more (that is a recent change):
cleaos push action currency create '{"issuer":"currency", "maximum_supply": "1000000000.0000 CUR", "can_freeze": 1, "can_recall": 1, "can_whitelist": 1}' -p currency@active

For the details of the actions check the contract code:
https://github.com/EOSIO/eos/blob/master/contracts/eosiolib/currency.hpp

Take note that it seems that get table is broken but the contract is working fine. I reported it in #1742
I attached to #1742 the log of the tests I did with it. You can check it to know how to use the latest version of the contract.

The answer from @jeremi should be the right one. The currency contract is not available anymore so this issue is no longer relevant. I'm going to close this issue


Fixed retrieval of rating, total-ratings and price

I tested my changes on the German Amazon, I hope it works for the US one as well. Here I made your example app work with my German wishlist: http://wishlist.mcflash99.de/

@mcflash99 Do you mind sharing your wishlist ID so I can compare against mine on US Amazon? Thanks

My wishlist ID on amazon.de is 34G47HZEKJDJ3.

This is updated


Ctrl+C have different behaviour in console

Description of your problem
Context menu in console suggest that Ctrl+C can be used to copy text. However during execution of command Ctrl+C will abort execution, without copying of selected text.
What steps will reproduce the problem?

Select text in console while no command running. Press Ctrl+C. On Ctrl+V selected text is available.
Run long command in console. Select text in console. Press Ctrl+C.  Execution aborted. Selected text not available on Ctrl+V

What is the expected output? What do you see instead?
Either copy text in both cases or don't copy text on Ctrl+C but abort execution if any.
Please provide any additional information below
Versions and main components

Spyder Version: 3.0.0
Python Version: Python 2.7.12 64bits, Qt 5.6.0, PyQt5 5.6
Operating system: Windows

If you're executing something, then Ctrl+C tries to abort a computation. That's hard coded so (unfortunately) we can't change it.
What you can do while a computation is running is using the context menu entry to copy text, instead of pressing Ctrl+C :-)


Front-end to add users by BCeID /IDIR

As a application access manager I want to assign users to an application role by BCeID/ IDIR So That users can access an authorized application such as FOM.
Additional Context
-- Private page to add the user ID, select the login domain and select the application role, or add/select the forest client role.
--Ability to add the forest client role. If the forest client role does not exists, the backend would create the role. (All the business logic is handled in the API)
--If you create a role assignment that already exits, return a successful result.
--Upon successfully assigning roles, display a message "Access granted"
--Upon clicking "Grant Access", submit an object the username, roles, and forest client
-Upon clicking "Grant Access" return a response " Access granted" or 'Error Saving' and if successful, clear the user id field and remain on page.
-Note navigation buttons on the mockup.
--if the forest client already exists, update the table and if not add the forest client.
Note: A separate ticket, the forest client API will be integrated the front -end and the back-end for validation.

Acceptance Criteria
Given I have click on the Grant Access, create an object with user ID, application role and/or forest client as a  database record.
Given I have logged in successfully with an IDIR, When thee are no applications returned, Then I am advised to check with the FAM Team
Definition of Done
Ready to Demo in Sprint Review
Does what I have made have appropriate test coverage?
Documentation and/or scientific documentation exists and can be found
Peer Reviewed by 2 people on the team
Manual testing of all PRs in Dev and Prod
Merged

A side note for AWS dev environment.

To test with example like "FOM" application, roles needs to exist first (probably need another version of alembic/flyway migration).
I use this script locally for database inserts:

insert into app_fam.fam_role(role_name, role_purpose, application_id, create_user, role_type_code)
values('FOM_SUBMITTER', 'FOM Submitter', 2, 'fam_proxy_api', 'A');

insert into app_fam.fam_role(role_name, role_purpose, application_id, create_user, role_type_code)
values('FOM_REVIEWER', 'FOM Reviewer', 2, 'fam_proxy_api', 'C');

Also, due to some fixes in backend for this ticket, backend needs to be re-dployed to AWS.

@basilv, is this what I should be looking at in Dev for the Grant Access screen?

I checked, and I'm seeing the updated screen. Are you maybe looking at the test environment URL instead of dev? URL: https://d2solh97t525i7.cloudfront.net/grant

Thanks Basil, I was looking at Dev, but it is working now. It was probably showing me the screen I opened before deployment. probably, my cache or something.
@basil how do I confirm that the records are in the database?

Looks good, I have some questions that I would like to ask tomorrow.

You can call the get role assignments endpoint on the API to check what's in the database.


nixos/tests: add test for prometheus exporters

Things done

set the default value of RestartSec for the varnish exporter service to avoid unrecoverable crashes (during a restart of varnish for example)
fixed the default service settings (Restart, PrivateTmp and  WorkingDirectory) which where falsely ignored before for all prometheus exporters
added a test for all available exporters (excluding minio and unifi) with instructions on how to add more tests
added myself as maintainer for the prometheus exporters module

The exporter tests are executed one after another as subtests to go easy on the memory.
The unifi and minio tests were intentionally excluded because recently minio itself started to expose prometheus metrics. The unifi controller is unfree software and also needs to be configured in the webinterface (as far as I know).

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Once this is approved, I'll open another PR to backport 9ed397d1c69b9158a20b234df5c3ac082ea9308d and dd0bdbe to 18.09.

@GrahamcOfBorg test prometheus-exporters

Backported to 18.09: https://github.com/NixOS/nixpkgs/compare/a8ad1fbe92af...2cae2b9a8491


allow arrays into the arithmetic macros

Closes #341.
cc @mwpastore

What should the return value be if the array is empty?

erroring?

That's an interesting question. I think you could probably get away with returning zero,

What happens if the array contains something that's not a number?

@Fed03 It would try to add it 😛

@Fed03 It would try to add it 😛

In that case, I think that NaN would be the right thing to return when array is empty, like suggested by @mwpastore

I ended up saying empty array is zero. I thought it would be easier to reason this:
total: sum('array')
vs
total: or(sum('total'), 0) or total: conditional('total.length', sum('total'), 0)

Released in https://github.com/kellyselden/ember-awesome-macros/releases/tag/v0.37.0


Add gardener-cert-management repo to prow configs

/kind enhancement
What this PR does / why we need it:
Add gardener-discovery-server repo to prow configs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:

/cc @RaphaelVogel

I forgot one thing. You should create an OWNERS and an OWNERS_ALIASES file to cert-management repository which enlist its reviewers and approvers. I linked examples.

Thanks for the examples. So the CODEOWNERS file used by GitHub (see about-code-owners) is then obsolete after the move?

Yes, CODEOWNERS should be obsolete then, because prow is overwriting the reviewers anyway.
/lgtm
/approve


Failure in pkg/vm_snapshot_analysis/test/instruction_sizes_test

The test
pkg/vm_snapshot_analysis/test/instruction_sizes_test RuntimeError (expected Pass)

is failing on configuration
unittest-asserts-release-linux

The trybot infrastructure classified this test as going from "flaky" to "RuntimeError (expected Pass)" in one of my 5 cls:

6853db8e7716979ed9a0bd3e74c9249a7c31301d
4510f1dc984c3412d36c11223d40b64192f34a7e
5c19c9f5e4b0659205e102c70aa444aba8fa0a9e
c64842e582aaca210f6d072d7041b30f9748a600
afc9a4eeffae5d7e59a41c2cd18a6f89361c241d

However I find the test to be just as flaky both before and after my CLs:

With bb7081c6c759d9b827fba19cce2500c6a0aec14f (the CL just before mine), I see 10 failures out of 10 runs
With 6853db8e7716979ed9a0bd3e74c9249a7c31301d (the last of my 5 CLs), I also see 10 failures out of 10 runs

(Assigning the actual failure to myself so that I remember to take a look at it when I come back from holidays)


Support coverage when push

Support coverage when push

Hi @bluelovers!
I don't understand the request 🤔. Currently, this action writes a message in an opened PR. I don't know where it should write the message when there is no PR.


description for parameter disable_scp_checks does not look correct and looks to be same as parameter disable_workload_monitoring

description for parameter disable_scp_checks does not look correct and looks to be same as parameter disable_workload_monitoring
disable_scp_checks  (Boolean) Enables you to monitor your own projects in isolation from Red Hat Site Reliability Engineer (SRE) platform metrics.

disable_workload_monitoring (Boolean) Enables you to monitor your own projects in isolation from Red Hat Site Reliability Engineer (SRE) platform metrics.

@vamsinm thank you.
I opened a PR

Thank you @bardielle ,
I see the PR was merged and it was already included in latest prerelease
@vamsinm is there any other comment here or can this issue be closed now?

@vamsinm This bug was fixed as part of our last release version
you can see here that disable_scp_checks`s description is different than disable_workload_monitoring's description
Closing this issue


Eco update

Change ecoconfig.json line 73 from text to Textarea - allows for multi-line detaileddescription fields. Tested and works (including testing with the colour system and it works still)

You’ve got other guff in there that needs to be cleaned up.
Create the branch based off the CC repo, not your own.


Unable to load DLL 'libSkiaSharp' when referenced in class library targetting netstandard1.3

Description
SkiaSharp beginner here, using VS2019. I created an ASP.NET WebForms application, targetting .NET Framework 4.6 (=.NETStandard 1.3), and installed SkiaSharp v2.88.7 NuGet package in a class library referenced by the WebForms application, compiling as AnyCPU. On build the LibSkiaSharp.dll is not deployed to any bin folder and on runtime I get the infamous error:
Unable to load DLL 'libSkiaSharp': The specified module could not be found.
I added
<ShouldIncludeNativeSkiaSharp>True</ShouldIncludeNativeSkiaSharp>
<PreferredNativeSkiaSharp>x86</PreferredNativeSkiaSharp>

to all PropertyGroups of both the class library and Webforms application *.csproj files, but it makes no difference. I'm out of ideas... From what I could research:

#513: AnyCPU should be supported with the snippet above added to csproj;
#955: C++ VS 2015 dist is statically compiled in since v1.68.x, no need to install it;
#1726: LibSkiaSharp.dll should be copied without issues for library projects;

I confirmed the same issue happens on version 2.80.0.
SkiaSharp v1.68.3 works fine and I do get libSkiaSharp.dll deployed in the bin folder, so for now I will continue using that version.
Code
I created a sample project to reproduce the issue and uploaded it to the following GitHub repository:
https://github.com/lbras/SkiaSharpTestWebFormsNETFramework46
Expected Behavior
LibSkiaSharp.dll should be copied to the application bin folder
Actual Behavior
LibSkiaSharp.dll is not deployed with the application, resulting in runtime errors
Version of SkiaSharp
2.88.3 (Current)
Last Known Good Version of SkiaSharp
1.x (Obsolete)
IDE / Editor
Visual Studio (Windows)
Platform / Operating System
Windows
Platform / Operating System Version
Windows 10
Devices
No response
Relevant Screenshots
No response
Relevant Log Output
[DllNotFoundException: Unable to load DLL 'libSkiaSharp': The specified module could not be found. (Exception from HRESULT: 0x8007007E)]
   SkiaSharp.SkiaApi.sk_data_new_empty() +0
   SkiaSharp.SKData..cctor() +28

[TypeInitializationException: The type initializer for 'SkiaSharp.SKData' threw an exception.]
   SkiaSharp.SKData.Create(Stream stream) +0
   SkiaSharp.SKImage.FromEncodedData(Stream data) +33
   Imaging.ImageFile.IsValid() in D:\Repos\SkiaSharpTestWebFormsNETFramework46\Imaging\ImageFile.cs:30
   SkiaSharpTestWebFormsNETFramework46._Default.Page_Load(Object sender, EventArgs e) in D:\Repos\SkiaSharpTestWebFormsNETFramework46\Web\Default.aspx.cs:21
   System.Web.Util.CalliEventHandlerDelegateProxy.Callback(Object sender, EventArgs e) +85
   System.Web.UI.Control.OnLoad(EventArgs e) +79
   System.Web.UI.Control.LoadRecursive() +130
   System.Web.UI.Page.ProcessRequestMain(Boolean includeStagesBeforeAsyncPoint, Boolean includeStagesAfterAsyncPoint) +2852

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Try updating netframework to latest netframework or dotnet8 so you can use netstandard2.0 at least.

Try updating netframework to latest netframework or dotnet8 so you can use netstandard2.0 at least.

I tried updating my sample project to .NET Framework 4.8 and had no issues, SkiaSharp worked out of the box without having to add  or  using platform Any CPU. I confirmed the same is true for .NET Framework 4.6.2.
So it is an issue specific for .NET Framework 4.6 / .NETStandard 1.3.

.NET Framework 4.6 is out of support so there is no expectation that this should work or not work. A search for netstandard in the repo indicates that netstandard1.3 has been removed with netstandard2.0 and netstandard2.1 and net462 as current targets, which makes sense.

I do expect it to work because SkiaSharp claims it provides bindings for .NET Standard 1.3:

If this is no longer true, then the above statements should be corrected. I specifically picked SkiaSharp because of .NET Standard 1.3 support.

I expect those references would be removed when the current prerelease gets released. Why would this matter to you? You said you updated your project to netframework 4.8 and there was no problem.

Hi folks, looking at this issue I think the nuget UI and readme may not be the greatest source of how this all works.
The meaning of support for .NET Standard 1.3 really just refers to the API level. There is no real ".NET Standard" app. SO you can't "run" it. This just means that if you want to build a .NET Standard dll with SkiaSharp, you can do so.
The other part is the .NET Framework, and that is just supported from 4.6.2 since that is the latest 4.5 version.
I agree this is a bit confusing as you have to know that .NET Standard is not really meant to be used in the way you would expect.
I need to see why I do not copy the native dlls for plain .NET Standard. I am sure there was a reason. If you were to build a net8.0 class library I think it gets copied. So, it may have been that everyone using .NET Standard just used it as a library and had some form of app.

I can relate.
System.TypeInitializationException: 'The type initializer for 'SkiaSharp.SKAbstractManagedWStream' threw an exception.'
DllNotFoundException: Unable to load DLL 'libSkiaSharp' or one of its dependencies: The specified module could not be found. (0x8007007E)
Problem occurs on line
var canvas = SKSvgCanvas.Create(SKRect.Create(squareSvgSize, squareSvgSize), stream);
Installed libs via nuget:
SkiaSharp 2.88.8
SkiaSkarp.Svg 1.60.0
Any ideas?

I encountered a similiar issue in a WinForm (.NET Framework 4.8) project that use ScottPlot: (5.0.44). My situation is:

git clone this project from remote
Open and debug (F5) on VS2022
The exception "Unable to load library 'libSkiaSharp.dll' "throw
As lbras said, the expected behavior "LibSkiaSharp.dll should be copied to the application bin folder" not implemented.
Even if the coping logic is already written in .csproj file of th project:

I just save .csproj outside VS2022 without changing anything and force VS2022 reload project and the files are copy to as it excepted.
Another solution is to not git ignore the packages folder. This allows the first debug (F5) to be successful. Although the packages folder will be automatically generated If packages folder ignored during the first debug (F5), the second debug (F5) will not "interpret". csproj file again (vs2022 seems to remember some past states). This lead the coping logic will not be run.


#1623 - Implement Create/Update/Delete on Import endpoint of Project

#1623 - Implement Create/Update/Delete on Import endpoint of Project

Updated import projects API to handle, create, update and delete operations

#999 - Special History - Proponent name

fixed issue where relationship holder name was not disabled when editing special field

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (develop@9f0e08d). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1626   +/-   ##
==========================================
  Coverage           ?   61.93%
==========================================
  Files              ?      248
  Lines              ?     8193
  Branches           ?        0
==========================================
  Hits               ?     5074
  Misses             ?     3119
  Partials           ?        0

Flag
Coverage Δ

epictrack-api
61.93% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Failing to install skills

When I try to install a skill with osm-install it fails with the following result:
$ osm-install --skill "Speed Test"
Speed Test does not look like a valid skill url, do you want to enable search? [y/N]: y

Search Results:
    appstore - branch - url
1 - OpenVoiceOS - v0.1.0 https://github.com/NeonGeckoCom/speed-test.neon
2 - MycroftMarketplace - 47c4cc05237562f81b5c25c2883aa66f91f64280 https://github.com/luke5sky/speedtest-skill
0 - cancel installation

Select an option: 1
Do you want to install v0.1.0 https://github.com/NeonGeckoCom/speed-test.neon ? [y/N]: y
Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/bin/osm-install", line 8, in <module>
    sys.exit(install())
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/scripts/install.py", line 114, in install
    skill.install(folder)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/skill_entry.py", line 238, in install
    skills = self.requirements.get("skill", [])
AttributeError: 'list' object has no attribute 'get'

My /opt/mycroft/skills directory belongs to my user (the same user running mycroft services), besides that user has sudo powers and even with the NOPASSWD flag on visudo, so I guess there is no permissions issue
I'm running the osm-install inside the virtualenv, activated via source ~/mycroft-core/venv-activate.sh

Just tried with pip install git+URL, there was errors as well
(.venv) [malevolent@malevolo mycroft-core]$ pip install git+https://github.com/NeonGeckoCom/speed-test.neon
Collecting git+https://github.com/NeonGeckoCom/speed-test.neon
  Cloning https://github.com/NeonGeckoCom/speed-test.neon to /tmp/pip-req-build-663qiczm
  Running command git clone -q https://github.com/NeonGeckoCom/speed-test.neon /tmp/pip-req-build-663qiczm
    ERROR: Command errored out with exit status 1:
     command: /home/malevolent/mycroft-core/.venv/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-663qiczm/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-663qiczm/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-req-build-663qiczm/pip-egg-info
         cwd: /tmp/pip-req-build-663qiczm/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/usr/lib/python3.9/tokenize.py", line 392, in open
        buffer = _builtin_open(filename, 'rb')
    FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-req-build-663qiczm/setup.py'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
WARNING: You are using pip version 20.0.2; however, version 20.3.3 is available.
You should consider upgrading via the '/home/malevolent/mycroft-core/.venv/bin/python -m pip install --upgrade pip' command.

Just tried with pip install git+URL, there was errors as well
(.venv) [malevolent@malevolo mycroft-core]$ pip install git+https://github.com/NeonGeckoCom/speed-test.neon
Collecting git+https://github.com/NeonGeckoCom/speed-test.neon
  Cloning https://github.com/NeonGeckoCom/speed-test.neon to /tmp/pip-req-build-663qiczm
  Running command git clone -q https://github.com/NeonGeckoCom/speed-test.neon /tmp/pip-req-build-663qiczm
    ERROR: Command errored out with exit status 1:
     command: /home/malevolent/mycroft-core/.venv/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-663qiczm/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-663qiczm/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-req-build-663qiczm/pip-egg-info
         cwd: /tmp/pip-req-build-663qiczm/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/usr/lib/python3.9/tokenize.py", line 392, in open
        buffer = _builtin_open(filename, 'rb')
    FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-req-build-663qiczm/setup.py'
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
WARNING: You are using pip version 20.0.2; however, version 20.3.3 is available.
You should consider upgrading via the '/home/malevolent/mycroft-core/.venv/bin/python -m pip install --upgrade pip' command.

osm-install --skill GITHUB_URL works

osm-install --skill GITHUB_URL works

I noticed, when I try to install through osm-install without the --skill URL parameter, it still fails, but search shows the appstore name:
(.venv) [malevolent@malevolo skills]$ osm-install
skill to install (url or search term): wolfram
wolfram does not look like a valid skill url, do you want to enable search? [y/N]: y

Search Results:
    appstore - branch - url
1 - MycroftMarketplace - eface55448c473a4138024cf9859f631ecd9c426 https://github.com/MycroftAI/fallback-wolfram-alpha
2 - MycroftMarketplace - 60bd41663a09036f4cadf2325a6a1037d0fafd1d https://github.com/MycroftAI/skill-pairing
3 - pling.opendesktop - master https://github.com/JarbasSkills/skill-wolfie
0 - cancel installation

Select an option: 3
Do you want to install master https://github.com/JarbasSkills/skill-wolfie ? [y/N]: y
Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/bin/osm-install", line 8, in <module>
    sys.exit(install())
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/scripts/install.py", line 114, in install
    skill.install(folder)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/skill_entry.py", line 238, in install
    skills = self.requirements.get("skill", [])
AttributeError: 'list' object has no attribute 'get'
(.venv) [malevolent@malevolo skills]$ osm-install --skill https://github.com/JarbasSkills/skill-wolfie

but when I use the --skill URL parameter, yet it installs the skill, the appstore name is shown as "unknown":
(.venv) [malevolent@malevolo skills]$ osm-install
skill to install (url or search term): wolfram
wolfram does not look like a valid skill url, do you want to enable search? [y/N]: y

Search Results:
    appstore - branch - url
1 - MycroftMarketplace - eface55448c473a4138024cf9859f631ecd9c426 https://github.com/MycroftAI/fallback-wolfram-alpha
2 - MycroftMarketplace - 60bd41663a09036f4cadf2325a6a1037d0fafd1d https://github.com/MycroftAI/skill-pairing
3 - pling.opendesktop - master https://github.com/JarbasSkills/skill-wolfie
0 - cancel installation

Select an option: 3
Do you want to install master https://github.com/JarbasSkills/skill-wolfie ? [y/N]: y
Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/bin/osm-install", line 8, in <module>
    sys.exit(install())
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/scripts/install.py", line 114, in install
    skill.install(folder)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/skill_entry.py", line 238, in install
    skills = self.requirements.get("skill", [])
AttributeError: 'list' object has no attribute 'get'
(.venv) [malevolent@malevolo skills]$ osm-install --skill https://github.com/JarbasSkills/skill-wolfie

I noticed, when I try to install through osm-install without the --skill URL parameter, it still fails, but search shows the appstore name:
(.venv) [malevolent@malevolo skills]$ osm-install
skill to install (url or search term): wolfram
wolfram does not look like a valid skill url, do you want to enable search? [y/N]: y

Search Results:
    appstore - branch - url
1 - MycroftMarketplace - eface55448c473a4138024cf9859f631ecd9c426 https://github.com/MycroftAI/fallback-wolfram-alpha
2 - MycroftMarketplace - 60bd41663a09036f4cadf2325a6a1037d0fafd1d https://github.com/MycroftAI/skill-pairing
3 - pling.opendesktop - master https://github.com/JarbasSkills/skill-wolfie
0 - cancel installation

Select an option: 3
Do you want to install master https://github.com/JarbasSkills/skill-wolfie ? [y/N]: y
Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/bin/osm-install", line 8, in <module>
    sys.exit(install())
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/scripts/install.py", line 114, in install
    skill.install(folder)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/skill_entry.py", line 238, in install
    skills = self.requirements.get("skill", [])
AttributeError: 'list' object has no attribute 'get'
(.venv) [malevolent@malevolo skills]$ osm-install --skill https://github.com/JarbasSkills/skill-wolfie

but when I use the --skill URL parameter, yet it installs the skill, the appstore name is shown as "unknown":
(.venv) [malevolent@malevolo skills]$ osm-install
skill to install (url or search term): wolfram
wolfram does not look like a valid skill url, do you want to enable search? [y/N]: y

Search Results:
    appstore - branch - url
1 - MycroftMarketplace - eface55448c473a4138024cf9859f631ecd9c426 https://github.com/MycroftAI/fallback-wolfram-alpha
2 - MycroftMarketplace - 60bd41663a09036f4cadf2325a6a1037d0fafd1d https://github.com/MycroftAI/skill-pairing
3 - pling.opendesktop - master https://github.com/JarbasSkills/skill-wolfie
0 - cancel installation

Select an option: 3
Do you want to install master https://github.com/JarbasSkills/skill-wolfie ? [y/N]: y
Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/bin/osm-install", line 8, in <module>
    sys.exit(install())
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/scripts/install.py", line 114, in install
    skill.install(folder)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/skill_entry.py", line 238, in install
    skills = self.requirements.get("skill", [])
AttributeError: 'list' object has no attribute 'get'
(.venv) [malevolent@malevolo skills]$ osm-install --skill https://github.com/JarbasSkills/skill-wolfie

@adocampo i believe these are all fixed, could you please test version 0.0.5 ?

bump

sorry dudes...
just installed 0.5.1 and it doesn't even start
[malevolent@malevolo mycroft-core]$ osm
Traceback (most recent call last):
  File "/home/malevolent/.local/bin/osm", line 5, in <module>
    from ovos_skills_manager.commands import osm_commands
  File "/home/malevolent/.local/lib/python3.9/site-packages/ovos_skills_manager/commands.py", line 2, in <module>
    from click_default_group import DefaultGroup
ModuleNotFoundError: No module named 'click_default_group'

sorry, I slept today barely 3h1/2... I noticed I installed osm outside a venv... but it seems to fail as well
nstalling collected packages: kthread, ovos-utils, ovos-skills-manager
  Attempting uninstall: ovos-utils
    Found existing installation: ovos-utils 0.0.5
    Uninstalling ovos-utils-0.0.5:
      Successfully uninstalled ovos-utils-0.0.5
  Attempting uninstall: ovos-skills-manager
    Found existing installation: ovos-skills-manager 0.0.1
    Uninstalling ovos-skills-manager-0.0.1:
      Successfully uninstalled ovos-skills-manager-0.0.1
Successfully installed kthread-0.2.2 ovos-skills-manager-0.0.6 ovos-utils-0.0.11
WARNING: You are using pip version 20.0.2; however, version 21.1.2 is available.
You should consider upgrading via the '/home/malevolent/mycroft-core/.venv/bin/python -m pip install --upgrade pip' command.
(.venv) [malevolent@malevolo mycroft-core]$ osm --install wolfram
Traceback (most recent call last):
  File "/home/malevolent/.local/bin/osm", line 5, in <module>
    from ovos_skills_manager.commands import osm_commands
  File "/home/malevolent/.local/lib/python3.9/site-packages/ovos_skills_manager/commands.py", line 2, in <module>
    from click_default_group import DefaultGroup
ModuleNotFoundError: No module named 'click_default_group'

That was fixed earlier today. Sorry, I should have realized it was in current pip.

So... do I need to ckeck it again?

Ultimately, but not this second. Sorry 🤐 there's one open PR that should be merged today, and then a new version will be released which should be working. You can try that branch, if you want, but hassle

I'd rather wait for the new version then ;)

Just released last night/this AM, informing people in phases because HEAT WAVE 🌞🌎🌡💥🥵

We had here the first heat wave of the year two weeks ago (still on spring)... if you don't have them yet, ceiling fans are awesome, I'm under one of them 24h a day, I just need to turn AC only in the hottest and most humid days.
On the other hand, I still see version 0.0.6 on pip... am I doing sth wrong or we need to pip to refresh?

Definitely on 0.0.8: https://pypi.org/project/ovos-skills-manager/

Well, now I can run the osm command without errors, but I'm still unable to install anything
(.venv) [malevolent@malevolo mycroft-core]$ osm search wikipedia
2021-07-01 14:30:50.312 - OVOS - ovos_skills_manager.appstores:bootstrap:51 - INFO - Bootstrapping InstalledSkills, this might take a while!
Wikipedia https://github.com/MycroftAI/skill-wiki
Wikipedia https://github.com/JarbasSkills/skill-wikipedia-for-humans
Wikipedia https://github.com/MycroftAI/skill-wiki
Wikipedia https://github.com/einstalek/ru-wiki
Wikipedia https://github.com/AIIX/plasma-skill-wiki
Wikipedia https://github.com/Shivaabhai/webmd-skill
(.venv) [malevolent@malevolo mycroft-core]$ osm install https://github.com/JarbasSkills/skill-wikipedia-for-humans
2021-07-01 14:31:04.519 - OVOS - ovos_skills_manager.github:get_requirements_json:209 - ERROR - Error reading from manifest!
2021-07-01 14:31:05.980 - OVOS - ovos_skills_manager.github:get_requirements_json:222 - ERROR - Error reading skills requirements!

Search Results:
    appstore - branch - url
1 - unknown - v0.2.2 https://github.com/JarbasSkills/skill-wikipedia-for-humans
0 - cancel installation

Select an option: 1
Do you want to install v0.2.2 https://github.com/JarbasSkills/skill-wikipedia-for-humans ? [y/N]: y
2021-07-01 14:31:13.062 - OVOS - ovos_skills_manager.skill_entry:install:274 - INFO - Installing skill: https://github.com/JarbasSkills/skill-wikipedia-for-humans from branch: v0.2.2
2021-07-01 14:31:13.063 - OVOS - ovos_skills_manager.skill_entry:install:291 - INFO - Running pip install
2021-07-01 14:31:13.064 - OVOS - ovos_skills_manager.requirements:pip_install:43 - INFO - (pip) Installing ovos_utils
2021-07-01 14:31:13.960 - OVOS - ovos_skills_manager.requirements:pip_install:43 - INFO - (pip) Installing wikipedia_for_humans>=0.2.3
2021-07-01 14:31:17.938 - OVOS - ovos_skills_manager.skill_entry:install:294 - INFO - Downloading https://github.com/JarbasSkills/skill-wikipedia-for-humans
Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/bin/osm", line 8, in <module>
    sys.exit(osm_commands())
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/commands.py", line 98, in install
    _install.install(method, skill, fuzzy, no_ignore_case, thresh, appstore, search,
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/scripts/install.py", line 92, in install
    skill.install(folder)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/skill_entry.py", line 295, in install
    updated = self.download(folder)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/skill_entry.py", line 254, in download
    return install_skill(url, folder, file, session=requests,
TypeError: install_skill() got an unexpected keyword argument 'session'
(.venv) [malevolent@malevolo mycroft-core]$

Presumptive version mismatch, due to an unpinned dep in setup.py, pinned in requirements.txt. Should be fixed by #49 in short order. Nice catch.

nice, please let me know when I should try again

Apologies for the delay. v0.0.9a1 should now be available.

Ok, so, now it seems to work... I've tried to install like 10 skills and just 1 got installed (skill-wikipedia-for-humans)
Most of the others gave me an exception, but I guess this is not osm's fault, an example.
(.venv) malevolent@malevolo ~/mycroft-core (dev)$ osm install https://github.com/AIIX/youtube-skill
Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/__init__.py", line 21, in get_skill_data
    branch = get_branch_from_github_url(url)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/utils.py", line 113, in get_branch_from_github_url
    raise GithubInvalidBranch
ovos_skills_manager.exceptions.GithubInvalidBranch

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/__init__.py", line 147, in get_branch_from_skill_json
    return get_branch_from_skill_json_github_api(url, branch)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/api.py", line 420, in get_branch_from_skill_json_github_api
    json_data = get_skill_json_from_github_api(url, branch)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/api.py", line 333, in get_skill_json_from_github_api
    data = get_file_from_github_api(url, dst.format(repo=repo), branch)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/api.py", line 151, in get_file_from_github_api
    branch = branch or get_main_branch_from_github_api(url)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/api.py", line 126, in get_main_branch_from_github_api
    data = get_repo_data_from_github_api(url, branch)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/api.py", line 62, in get_repo_data_from_github_api
    raise GithubAPIRateLimited
ovos_skills_manager.exceptions.GithubAPIRateLimited

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/raw.py", line 269, in get_skill_json_from_github_url
    return json.loads(res)
  File "/usr/lib/python3.9/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python3.9/json/decoder.py", line 340, in decode
    raise JSONDecodeError("Extra data", s, end)
json.decoder.JSONDecodeError: Extra data: line 1 column 4 (char 3)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/raw.py", line 489, in get_branch_from_skill_json_github_url
    json_data = get_skill_json_from_github_url(url, branch)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/raw.py", line 274, in get_skill_json_from_github_url
    raise GithubFileNotFound
ovos_skills_manager.exceptions.GithubFileNotFound

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/malevolent/mycroft-core/.venv/bin/osm", line 8, in <module>
    sys.exit(osm_commands())
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/commands.py", line 98, in install
    _install.install(method, skill, fuzzy, no_ignore_case, thresh, appstore, search,
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/scripts/install.py", line 62, in install
    skills = [SkillEntry.from_github_url(skill, branch)]
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/skill_entry.py", line 87, in from_github_url
    return SkillEntry.from_json({"url": url, "branch": branch},
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/skill_entry.py", line 80, in from_json
    raise e
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/skill_entry.py", line 75, in from_json
    github_data = get_skill_data(url, data.get("branch"))
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/__init__.py", line 24, in get_skill_data
    branch = get_branch_from_skill_json(url)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/__init__.py", line 149, in get_branch_from_skill_json
    return get_branch_from_skill_json_github_url(url)
  File "/home/malevolent/mycroft-core/.venv/lib/python3.9/site-packages/ovos_skills_manager/github/raw.py", line 494, in get_branch_from_skill_json_github_url
    raise GithubFileNotFound
ovos_skills_manager.exceptions.GithubFileNotFound

That's interesting. Are you sure you're running 0.0.9?

0.0.9a1 in fact (a --version would be nice to have 😝 )

Latest published version is 0.0.9a4 as of now. @adocampo was this issue ever resolved?
also, osm --version functionality is in the repo, just need a new PyPI release ;)


jesec-rtorrent: allow passthrough of dependency.

Description of changes
Add a passthru attribute that exposes the libtorrent dependency.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[-] (Package updates) Added a release notes entry if the change is major or breaking
[-] (Module updates) Added a release notes entry if the change is significant
[-] (Module addition) Added a release notes entry if adding a new NixOS module
[-] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[?] Fits CONTRIBUTING.md.

This is my first contribution here. If I've missed something from the contribution guidelines I'm happy to address that.
Wasn't sure if I was supposed to submit an issue as well as a PR, but I've submitted https://github.com/NixOS/nixpkgs/issues/178804 to describe the problem here.
The same issue exists with rakshasa-rtorrent as well, and I'm happy to submit a similar PR if this is accepted.

My only concern with this approach is that I'm not sure if it's adequate for your use (developing the client), solely because there are changes in libtorrent made in lockstep with the client, so using the release version of libtorrent with the trunk of rTorrent may not work out.
What do you think?

It's certainly possible that I need my own derivation of libtorrent, or maybe I supply it as part of the workspace and set the cmake path myself.
However that shouldn't preclude using the libtorrent version that's packaged if I'm trying to patch the packaged version of rtorrent.

Makes sense.
Feel free to add this to rakshasa's rTorrent as well, preferably in the same commit, just adjust the commit message accordingly. My rationale for this is that it's the exact same change, just in 2 (closely related) packages; I don't see a point in splitting it up into 2 commits. If you feel differently you can add it in a separate commit of course, that's just my 2c. Thanks!

Can absolutely drop the period from the commit message. I had read that in the contribution guidelines, but it seems my grammar kicked in subconsciously.
I’m happy to add this in the same commit. What’s the correct format for the first line in the case of multiple packages being modified? I don’t think I was able to get an understanding of whether there is a structured format for a change like that.

I’m happy to add this in the same commit. What’s the correct format for the first line in the case of multiple packages being modified? I don’t think I was able to get an understanding of whether there is a structured format for a change like that.

What I've been using (see here) is shell expansion syntax, so {jesec-,}rtorrent.


enable and disable code protect using minichlink

how to enable and disable code protect using minichlink?

According to https://github.com/cnlohr/ch32v003fun/blob/bf73d9ad18b525059e5b80b1052a3c4dccc3463b/minichlink/minichlink.c#L733-L734 with the -P flag, so you could say in the platformio.ini
upload_flags = -P

(or add it onto maybe other existing upload_flags).
You may not be able to flash again after that, until read protection is disabled again, not sure.  -p will unprotect the flash again.

I can do it using the mourn river ide and then going to the configure uploader section, But it will be convenient to do so from within the vscode environment. Please see if it is possible.

in minichlink when given ./minichlink -p following are the outputs

this shows that enable and disable code protect  can be done using minichlink but in case of vscode it's not possible yet.

Fixed in https://github.com/Community-PIO-CH32V/platform-ch32v/commit/9078ce4b9211753d7cb088ec0bf3cc351515d0a5

Thanks Bro, it worked like a charm, GREAT JOB.... KUDOS TO YOU....


Master

g

Hi @mlody888, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

This pull request seems to have been made in error, closing it out.


Update series conversion

Implement updated ConvSpec for 240+, 490+ and Process 6

Missing Conversion of 49X $3: http://id.loc.gov/tools/bibframe/compare-lccn/full-ttl?find=79640364

Associate ISSN from 49X $x with 830 in conversion: http://id.loc.gov/tools/bibframe/compare-lccn/full-ttl?find=94067679

Sent to Sally:

A few clarifying questions:
The spec for 490 says to ignore the first indicator (regarding series tracing). The MARC standards suggest that if ind 1 = 0, there will be no 8XX to pair with. If ind 1 = 0, should we still try to pair with an 8XX?
Does each 490 pair with an 8XX, or is it each 490 $a($x)($v)?
Related question - it appears that repeating the $a/$x/$v has 2 use cases -- one for a subseries, one for a parallel title. For a parallel title, does a single 490 get broken up into multiple hasSeries properties?
If there is no 8XX to pair with a 490, do we still create the instanceOf property and Work object?
If there is no 490 to pair with an 8XX, do we still create the Instance object of the hasSeries property, or do we just let the hasSeries property take the Work created by the 8XX as its object?

The conversion has been updated in branch issue-27. A development version of the conversion is installed on mprxyvls02.
URLs for the acceptance test records:
http://mprxyvls02.loc.gov:210/LCDB?version=1.1&operation=searchRetrieve&query=rec.id%3D11225612&recordSchema=bibframe2-dev&startRecord=1&maximumRecords=1
http://mprxyvls02.loc.gov:210/LCDB?version=1.1&operation=searchRetrieve&query=rec.id%3D2071829&recordSchema=bibframe2-dev&startRecord=1&maximumRecords=1

I've cleaned up the code and updated the development server with the latest code for testing.


Add support for Generic notes

I've added support for Generic notes. No unit tests added though.

Kim, thanks for your patch. I would like to merge it but with some refactoring. This library is already used by some projects and I would like to keep it at least minimally backwards compatible. This patch brakes the old code. I also think Account and GenericNote don't have anything in common and should not be a part of the same hierarchy. Sure they come from the same type of chunk in the blob but that doesn't mean we have to follow. I would much rather just add Notes to the Vault and leave the Accounts the they were. What do you think?

I think that's both a valid point and a better design. I did it because it was the shortest path to what I wanted to do :)
If you want I'll happily take a stab at it a create a new pull request. It might take some time though as it's a hobby project and my time for such is limited.

This PR has died of old age.


Add user-defined types

UDTs can be any fixed-length numpy type that doesn't have Python objects.
Basically, UDFs that operate on the UDTs need to be able to be compiled with @numba.njit.
Still lots to do, but many things are already working!

Whew!
Okay, I think this is pretty much done.  Tests and coverage are as solid as I can reasonably make them.
Nevertheless, a PR this large and invasive is likely to have a bug or oversight or three.
I also don't know how it'll impact dask-grblas (CC @ParticularMiner).
Final thoughts and future possibilities:

We could allow default operators to work array dtypes of normal dtypes (such as np.dtype("(3,)uint8"))

For example, plus(A | A) could add subarrays together
This could also leverage normal NumPy broadcasting rules for the subarrays

(in)equality checking of UDTs could probably be faster

array dtypes could probably be specialized
should be benchmarked to determine what is best

NumPy string dtypes (such as np.dtype("S5")) are not tested (but I played around with them in my preliminary experiments)
Should we require dtypes to be registered?  Can things "just work" if given a numpy dtype?

In this PR, I kept to the standard register_new and register_anonymout pattern we use elsewhere.

Ideally, we should document UDTs better in docstrings and online documentation.  (We'll get there someday, but I'm wiped!)

This PR opens up a whole universe of possibilities.  Record dtypes and array dtypes support different use cases, and both can be super-important.
Anyway, I think this PR should be merged ASAP, but feedback is welcome for any who are courageous enough to review it (CC @jim22k).  Although I think things are pretty good, we can always smooth any rough edges we find once we actually implement workloads that needs UDTs.


Add warning about unsupported tools

Clarify that support for unsupported tools, drivers, and frameworks is "best effort."
Fixes DOC-7613.

[ ] Backport to currently supported versions after content review.

We will wanna wait a bit on this, we decided to make some changes to the language, I'll update with the new copy as soon as I have it.

Thanks @ianjevans for working on this and apologies for the delay. I'll let @dikshant take a look as well.


support a missing method for as.viz?

I have run into this a few times where we change ids and function names. We are also on a path to converge on a style guide for ids and functions.
I see this a lot:
fetch.{thing} <- function(viz = as.viz("{thing}"){
   ...
}

it seems to happen often that we change ids and then don't change the default arg to the function to reflect this. And then this only becomes clear (and is confusing) when debugging.
Given our pivot to remake, should we 1) get rid of this practice and go with fetch.{thing} <- function(viz), or 2) support a generic missing method for viz in this case that uses the function name.
such as:
fetch.viewbox_limits <- function(viz){
  if (missing(viz)){
    func_name <- as.character(match.call()[[1L]])
    id <- tail(strsplit(func_name, "[.]")[[1L]], 1L)
    viz <- as.viz(id)
  }
...

This is kind of ugly, and I don't think I like it. But I figured I would ask the question either way.

Hmm, I guess we do change viz item names often enough to make this a problem, don't we?
For solutions, I prefer option 1 to option 2. Vizlab has changed a lot, such that we can actually already call
fetch('thing')

without a default for fetch.thingfetcher's viz argument. attempting to fetch a non-viz-item gives an error, albeit not one that's extremely explicit about the viz id not existing:
> fetch('notathing')
Error in match(no.match, c(`NA` = NA, stop = stop("Could not find ", x))) :
  Could not find notathing

I'm personally content with this behavior (along with a team decision to stop using the viz=as.viz() default). What do you think - good enough?

"along with a team decision to stop using the viz=as.viz() default"
yes, I think w/ remake and this update to the guidelines that option 1 is the way to go.
Safe to close this issue?


@property should only add a property to a @typedef with initial type of Object

In the example below, I don’t expect the string map to disappear from MyBadMap when adding a function-typed property to the object. Asking internally, @sandersn suggested I open an issue here.
C:\T\tsrc>npm ls
C:\T\tsrc
`--<EMAIL_ADDRESS>

C:\T\tsrc>type example.js
"use strict";

/**
* Good example.
*
* @typedef {Object.<string, string>} MyGoodMap
*/

/**
  * Simple function
  *
  * @callback MyCallback
  * @returns {void}
  */

/**
* Bad (?) example.
*
* @typedef {Object.<string, string>} MyBadMap
* @property {MyCallback} callback
*/

C:\T\tsrc>node_modules\.bin\tsc --allowjs --declaration --outdir out example.js

C:\T\tsrc>type out\example.d.ts
/**
* Good example.
*/
type MyGoodMap = {
    [x: string]: string;
};
/**
* Simple function
*/
type MyCallback = () => void;
/**
* Bad (?) example.
*/
type MyBadMap = {
    callback: MyCallback;
};

C:\T\tsrc>

Smaller example:
/** @typedef {Object.<string,string>} Mmap
 * @property {string} ignoreMe - should be ignored
 */

should produce { [s: string]: string} not { ignoreMe: string }.

@sandersn knows this area far better than I, but his example seems slightly different than mine. In his, the added property is a “subset“ of the existing map behavior, whereas in mine, the added property is a function which should end up in the resulting declaration file.

So the typescript type you expected to see was { [s: string]: string, ignoreMe: string } ?

@sandersn Yes, that!


Avoid specific dependency versions

Use x.y rather than x.y.z for Cargo dependencies.

Oooh nice! What will this buy us?

@brendanzab Better build times for little gl tests (cargo new, init and etc.), 95% sure.

You could do this change yourself and I'd be satisfied.

@brendanzab It'll probably improve builds. You should know z is only a bugfix matter.

For pre-1.0 versions I normally include the revision number, and Cargo defaults to using the latest revision, but not the latest minimum version (which is usually a breaking change in pre-1.0 libs). I'm ok with removing the revision number for the post-1.0 libraries though.

Ah, so the revision number won't cause issues in compilation, usually. I guess I got confused. This is a small commit, was just thinking it'd solve some worries with me.


Add tags directly in the span constructor

AutoScope allows to pass tags as a constructor argument, so there is no need to get the same span from the tracer just to do that. The do block is redundant. I've also fixed some typos in the comments and documentation.

the do { ... } block is a leftover that once was designed to be used as the anonymous code ref that be wrapped around the original subroutine and install into *$AUTOLOAD for faster execution net time a Redis command would be needed.
It is okay to be removed, doing TDD and delivering a MVP, this should not have been there.


Add bottom button constraints variation

Now the bottom space constraints for the continue button will shrink to 10 points when in compact height. This will address issue #10 but for me the wrong horizontal scroll in landscape is not appearing. Can you try again if it is indeed fixed with my PR #7 ?

Yes, the horizontal scroll in landscape disappeared for me too, not sure how/why 😄
Thank you very much! This closes #10


support bean validation

support javax.validation.validation-api by

adding @Valid annotation to parameters
adding validation api annotations to model properties based on openapi constraints

openapi
annotation
comment

minimum
@Min
only if exclusiveMinimum = false (default)

maximum
@Max
only if exclusiveMaximum = false (default)

minLength
@Size(min = .. )

maxLength
@Size(max = .. )

?
@NotNull
default?

?
@Null

pattern
@Pattern

Unfortunately the OpenAPI constraints do not match very well the javax.validation. Probably need to write an own set of annotations...


Add the Livy connection wrapper

Test Plan:
a) create a profile for spark_livy with parameters similar to:
demo_project:
target: dev
outputs:
dev:
type: spark
method: livy
schema: my_db
host: https://spark-livy-gateway.my.org.com/dbt-spark/cdp-proxy-api/livy_for_spark3/
user: my_user
password: my_pass
b) Run the dbt commands for any sample dbt project (say demo_project):
dbt debug (test connections)
dbt run (run models)
dbt test
dbt seed
dbt docs generate
dbt docs serve
All the above commands should succeed

This PR is added on the hard reset to:
git reset --hard 9614bca5b471089692bd1df73760b23e83d537bb

discarding this PR


Request performance improvements

Any request prioritization related PRs will be going into this one.
Task list:

[ ] Request priority data structure https://github.com/AnalyticalGraphicsInc/cesium/pull/6240

[ ] Is a sorted array performant enough if the request queue gets larger? Move to a double-sided priority queue instead?
[ ] Queue up requests and then sort? https://github.com/AnalyticalGraphicsInc/cesium/pull/6240#discussion_r169668812

[ ] Implement Request pool to avoid allocating many Request objects.
[ ] Fix 3D Tiles starving terrain/imagery: https://github.com/AnalyticalGraphicsInc/cesium/issues/5954
[ ] 3D Tiles improvements https://github.com/AnalyticalGraphicsInc/cesium/issues/5509

[ ] Time slice processing - which also means sorting received tiles by priority
[ ] Cull received tiles that are now out of view
[ ] Cancel request when tile goes out of view

[ ] Tweaks for better http2 performance. Some notes in https://github.com/AnalyticalGraphicsInc/cesium/pull/5317
[ ] Different prioritization modes

[ ] SSE
[ ] Close to center of screen
[ ] Distance (current approach)
[ ] How can we mix and match different prioritization modes. Additive tiles use distance, replacement tiles use SSE, terrain uses distance but should probably use SSE. Is there any way to normalize all values to a 0-1 range?

[ ] Stagger renders to allow more request throughput: https://groups.google.com/forum/#!topic/cesium-dev/WQ4mgLcoBqI
[ ] skip lods for additive refinement

[ ] Parent tile keeps flag indicating whether descendants have renderable content

[ ] Debug visualizations to see load order.

[ ] Colorize by load order
[ ] Secondary camera see loaded tiles from a better vantage points

[ ] Evaluate performance for smaller or larger tile sizes
[ ] For terrain

[ ] Heuristic to take into account dot(view-direction, tile surface normal) so that the more the viewer is looking at the tile, the more important it is?
[ ] Sorting terrain requests by distance is probably bad and messes with terrain's internal priority handling.

@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

Will any of these improvements take HTTP/2 vs HTTP/1.1 throughput into account?  For many of these optimizations, I'm sure it doesn't matter but I've seen incredible performance improvements with HTTP/2 for certain views if I throttling is disabled completely.  I guess an optimal scheduling system won't actually care which protocol is being used.

Yes, I have a note for http2:
Tweaks for better http2 performance. Some notes in #5317

Shame on me, sorry for the noise I totally missed that.

Thanks again for the pull request!
Looks like this pull request hasn't been updated in 30 days since I last commented.
To keep things tidy should this be closed? Perhaps keep the branch and submit an issue?
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

Different prioritization modes

For the terrain improvements I've been working on, I've experimented with this metric for terrain tile prioritization:
        var cameraPosition = frameState.camera.positionWC;
        var cameraDirection = frameState.camera.directionWC;
        var tileDirection = Cartesian3.normalize(Cartesian3.subtract(obb.center, cameraPosition, tileDirectionScratch), tileDirectionScratch);
        return (1.0 - Cartesian3.dot(tileDirection, cameraDirection)) * tile._distance;

And have been pretty happy with it so far, though I haven't done a particularly principled analysis of it.
FYI, though, I've also disabled terrain tile prioritization with RequestScheduler cause it just doesn't do anything like what I want right now (for one thing: terrain has a low/medium/high priority load queue, which the Scheduler ignores and just looks at tile distance) and there's a bunch of overhead (for one thing: per-tile priorityFunction).

Hey @kring I noted this problem above:

Sorting terrain requests by distance is probably bad and messes with terrain's internal priority handling.

This is probably one of the bigger problems with the RequestScheduler right now. Originally we wanted a single metric to compare all requests, and distance was the easiest choice, but I don't think it's a good idea anymore. In https://github.com/AnalyticalGraphicsInc/cesium/pull/6390 additive tiles still use distance, but replacement tiles use SSE, and terrain tiles have their own priority handling, so distance just doesn't work across the board.
I envision RequestScheduler being a lot more trimmed down. Maybe a limit on how many requests can be active for each type, but none of the sorting that it does now. https://github.com/AnalyticalGraphicsInc/cesium/pull/6390 updated the 3D Tiles code to issue requests in order of priority, rather than arbitrarily like in master, so that's one step closer...
You priority function also looks a lot like @pjcozzi's suggestion in the task list above:

Heuristic to take into account dot(view-direction, tile surface normal) so that the more the viewer is looking at the tile, the more important it is?

Maybe a limit on how many requests can be active for each type, but none of the sorting that it does now.

Makes sense to me. You might be interested in taking a look at my slightly hacky changes to Request and RequestScheduler in the bvh branch: https://github.com/AnalyticalGraphicsInc/cesium/compare/master...bvh
The idea is to make throttleByServer independent of throttle. So when throttleByServer is true by throttle is false, you get the usual server-level request limiting (and it returns undefined when you exceed it), but it never queues or sorts requests.

You priority function also looks a lot like @pjcozzi's suggestion in the task list above:

Not quite, my metric is dot(direction-from-camera-to-center-of-tile, camera-view-direction), so tiles near the center of the screen are given higher priority (when distances are similar). Really it's not that different from sorting by distance, except that it tends to deprioritize tiles that are nearly off screen and may not even be visile, but we think they are because their bounding volume just barely intersects the view frustum.

@ggetz is it worth considering some of these?

Not quite, my metric is dot(direction-from-camera-to-center-of-tile, camera-view-direction), so tiles near the center of the screen are given higher priority (when distances are similar).

Makes sense - I read the code snippet too quickly before. We've been planning on adding something similar to the 3D Tiles traversal.
The request scheduler changes sound good too... back to basics.

I was originally hoping to finish more of these and consolidate them into a single PR (this), but I think it's better now to close this and submit fixes individually to master. I moved 3D Tiles relevant items to https://github.com/AnalyticalGraphicsInc/cesium/issues/5509.

Congratulations on closing the issue! I found these Cesium forum links in the comments above:
https://groups.google.com/forum/#!topic/cesium-dev/WQ4mgLcoBqI
If this issue affects any of these threads, please post a comment like the following:

The issue at https://github.com/AnalyticalGraphicsInc/cesium/pull/6243 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:


Create requirements.txt

The github CI for the docs keeps running into issues due to the lack of a doc/requirements.txt. This hopefully will fix that
General Checklist

[X] Conform by the style guides, by using formatter
[X] (optional) Please add a label to your PR

curious: why do we need boto3 to generate the docs? 🤔

Note: This can be removed with the CI action is removed if we are moving completely to sphinx in v1. Until the v0-v1 if we keep the action on, this does block PRs from easy merging into this branch without a fix.


Enforce dependencies check at runtime

Currently the binaries version are only checked when called
with flag "version". Now enforce it so that it fails with explicit
error message in case of missing binary or incorrect version installed.

The comment currently doesn't help me to understand what this fixMajorVersion flag really is. Could you clarify?

I've simplified the patch - now only enforcing the version check at runtime. Removed the other part.


Reloading config does not reinitialize changed role settings.

Reloading via ```/guild reload`` does not reinitialize changed role permission settings. So you can't enable or disable settings on the fly, i.e. if you wanted to change access to vault from allow to deny.
roles:
  0:
    name: "GuildMaster"
    permissions:
      open-vault: false

I have a possible fix on this, would you please test a beta build for me?

Sure, I can test a beta build for you.

Please try this build, I know it fixes roles, but make sure it doesn't break anything else - https://ci.glaremasters.me/job/Guilds/73/artifact/build/libs/Guilds-1.8.5-BETA-all.jar

Fixed