docs(matomo-plugin): fix config example and replace GA with Matomo

Tried using the Matomo Plugin but had to take a look in the Code to make it work. Fixed the documentiation for future users.

/cc @akhilmhdh @riginoommen can you PTAL

@fabianrindlisbacher Hi, sorry to ask this question on your PR (hope it gets merged soon). I followed your instructions, but nothing is being sent to Matomo. Is there anything else that needs to be configured?

@brunobastosg @riginoommen Will you merge this?

@brunobastosg @riginoommen Will you merge this?

Code changes are needed for this proposal

Are we going to accept this change?

@riginoommen Can it be merged as is?

@riginoommen Can it be merged as is?

No because it looks like a proposal more like this needs the code changes

@riginoommen Can it be merged as is?

No because it looks like a proposal more like this needs the code changes

This is not a proposal. It just fixes the documentation and some code comments.

@riginoommen Can it be merged as is?

No because it looks like a proposal more like this needs the code changes

This is not a proposal. It just fixes the documentation and some code comments.

Ah just remembered before opensourcing it. we made this consistent with other analytics plugin I just recalled it now. LGTM
https://github.com/janus-idp/backstage-plugins/blob/main/plugins/analytics-module-matomo/config.d.ts

LGTM

/approve


build_docker_aspnetcore failure

Bottom of the log:
++ uuidgen
+ CONTAINER_NAME=build_grpc_interop_aspnetcore_ffd5b22a-6e8c-489f-964b-cec819d349dc
+ docker run --cap-add SYS_PTRACE -e 'THIS_IS_REALLY_NEEDED=see https://github.com/docker/docker/issues/14203 for why docker is awful' -e 'THIS_IS_REALLY_NEEDED_ONCE_AGAIN=For issue 4835. See https://github.com/docker/docker/issues/14203 for why docker is awful' -i -v /tmpfs/src/github/grpc:/var/local/jenkins/grpc:ro -v /tmpfs/src/github/grpc-java:/var/local/jenkins/grpc-java:ro -v /tmpfs/src/github/grpc-go:/var/local/jenkins/grpc-go:ro -v /tmpfs/src/github/grpc-dart:/var/local/jenkins/grpc-dart:ro -v /tmpfs/src/github/grpc-node:/var/local/jenkins/grpc-node:ro -v /tmpfs/src/github/grpc-dotnet:/var/local/jenkins/grpc-dotnet:ro -v /home/kbuilder/service_account:/var/local/jenkins/service_account:ro --name=build_grpc_interop_aspnetcore_ffd5b22a-6e8c-489f-964b-cec819d349dc grpctesting/grpc_interop_aspnetcore:ff27c667aea48cc8232a236c5c52a90b9fd7f4bc bash -l /var/local/jenkins/grpc/tools/dockerfile/interoptest/grpc_interop_aspnetcore/build_interop.sh
mesg: ttyname failed: Inappropriate ioctl for device
Cloning into '/var/local/git/grpc-dotnet'...
done.
Downloading install script: https://dot.net/v1/dotnet-install.sh => /var/local/git/grpc-dotnet/build/obj/dotnet-install.sh
curl: (35) Unknown SSL protocol error in connection to dot.net:443

2021-03-16 00:03:51,990 FAILED: build_docker_aspnetcore [ret=35, pid=10978, time=207.1sec]

https://source.cloud.google.com/results/invocations/9c13291d-8aea-4d7b-ae02-fdc58d6fd063/targets/grpc%2Fcore%2Fpull_request%2Flinux%2Fgrpc_interop_tocloud/log
Seen in PR: https://github.com/grpc/grpc/pull/25726

I don't think we was this flake recently.


fix gas estimation & update

@rmeissner please review

We might want to wait for this fixes in solidity to have a more "clean" final version:
https://github.com/ethereum/solidity/issues/10158
https://github.com/ethereum/solidity/issues/10159


The Prisma Client API reference is overloaded with content - consider splitting it into separate pages

The Prisma Client API reference page is overloaded. We should probably split it into separate pages - and we need to decide how urgent this is.
Problems

The heading levels are excessive - if we are getting to level 5, that's a sign that there's too much content in the page.
This page is so big that it's slowing down the docs build. We probably need to divide it out into multiple pages. See Slack thread: https://prisma-company.slack.com/archives/C5Z9TH6N9/p1668535632567839
We are also getting build log warnings about the rendered page being over 500K. We should keep pages below this size. This page as rendered HTML is apparently greater than 2MB.
This particular page is taking 40 seconds every build just at one stage of the build process. Along the way, it's causing two timeouts that each trip at 15s. See the Slack thread for screenshots from Nilu.

Prognosis
IMO we should judiciously split out some of the material - e.g. the stuff at the very bottom which is supplementary - into separate pages. Also review anything that is heading level 5 or below.
But we also should also break the page up to lighten the server load. This is probably an easier task, because it doesn't require as much refactoring. We can split out each major section into a sub-page.
Note - we already plan to spin out the material about "database upserts" - into a "Prisma under the hood" page. A docs issue for this is to be created.
Another problem is that there are many duplicate headings, because they relate to keywords in different operation types. For example, isnot has two headings, under relation filters and composite types respectively. But when you go to one of these, it's not clear which section it's in because the page is so long. If the in-page TOC scrolled, this would mitigate the problem, but I personally don't like the lack of in-page signposting. Breaking the page up would help with this.
Considerations
If we split the page, how will this impact any existing PRs on the current page?
Discussion outcome
Zach’s proposal: landing page with table (we will need to decide how granular to make any splits that we do)
Andrew to investigate next sprint

👋 Hi there,
We're reviewing and tidying up our backlog to focus on the most relevant and impactful issues. After careful consideration, we're closing issues that haven't had any recent activity or align with our current priorities.
If you believe this issue is still important or unresolved, you're welcome to reopen it or create a new one with updated details. Your feedback is always valued and we're here to help ensure our docs continue to improve.
Thank you for your understand and contributions!


Update software-requirements-for-microsoft-dynamics-365-server.md

Support regularly fields questions and requests for documentation on how to host D365 CE on a Azure Managed SQL instance. Our stance is that this is not currently supported for D365 CE on premise deployments. The purpose of this document change is to (hopefully) deflect the question before it comes to support and offer an easy reference for support to quickly deflect the ticket.
Posted by<EMAIL_ADDRESS>

Please update this change to the main article.

@aengusheaney - FYI


Primary bitstream support for the REST api

References

Fixes #3349
UI PR: https://github.com/DSpace/dspace-angular/pull/2213

Description
Rest changes according to the following contract: https://github.com/DSpace/RestContract/pull/222
Instructions for Reviewers
Take a look at the changes in the contract & try them on the branch.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[X] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & integration tests). Exceptions may be made if previously agreed upon.
[X] My PR passes Checkstyle validation based on the Code Style Guide.
[X] My PR includes Javadoc for all new (or modified) public methods and classes. It also includes Javadoc for large or complex private methods.
[X] My PR passes all tests and includes new/updated Unit or Integration Tests based on the Code Testing Guide.
[X] If my PR includes new libraries/dependencies (in any pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
[X] If my PR modifies REST API endpoints, I've opened a separate REST Contract PR related to this change.
[X] If my PR includes new configurations, I've provided basic technical documentation in the PR itself.
[X] If my PR fixes an issue ticket, I've linked them together.

@KevinVdV and @benbosman : Friendly reminder that the Primary Bitstream work (all PRs) needs updating.  This has been sitting for 10 days now, and we'd need it to move more quickly if we are going to have time to review/approve it for 7.6.  Review deadline is this coming Friday (May 26). Merge deadline is June 9.  Thanks!

Closing, replaced by #8876


perf: isEmpty

Lots more perf if you avoid Object.keys(o) allocations, in particular for large objects.
Sometimes I write the for .. in without the if-guard, but it doesn't matter much, engines can usually eliminate that branch from JIT'ted code (not SpiderMonkey though). But as a generic-purpose lib, being correct including all edge-cases is probably more important than being hyper performant.
I would also find it convenient to have isObjectEmpty exported on its own, a catch-all isEmpty is bound to perform less well than a type-specialized one.

Thanks for the MR! :)
Mhh I don't see a performance improvements in the benchmarks here. I would only merge this if the benchmarks would show actually faster results. If we need to improve the benchmarks that should be done also in the MR then.

Not enough time to push this further, but feel free to pick it up if you're interested.


prealloc confused by ranging over a channel

var jobs []job
for job := range jobc {
    jobs = append(jobs, job)
}

In the code above, jobc is an unbuffered channel. I don't know the number of jobs that will be pulled from it. So I can't preallocate it.

You should preallocate the slice with 0 length and a non-0 reasonable capacity based on your work load.

@tyler-smith  we cant prealloc space because it will fill with the 0 value and also append does this for us if we choose 0 capacity.

Channels are not slices. When you append to a slice, it doesn't block. Sending on a channel can block. Blocking may be the desired behavior. There are many ways to write concurrent code, and some of those ways require unbuffered channels for correctness. prealloc can't possibly know the algorithm we're trying to implement, so it should never recommend preallocating channels.


clear Trail after JSON view. Optimize object loads for trails, urls, …

…and extractions
This should resolve #167 and cause list (default) view for Trails, Urls, and Extractions to load much quicker.

Much better...closing as fixed.


Can use ResNet 50?

If I want to use hr_res50.mat, how can i revised the code "matconvnet_hr101_to_pickle.py" and "tiny_face_model.py" ?
thank you

please comment on this.


GPU compilation fails after PR #198 (next VR)

GPU compilation fails after PR #198. Only resulting in a Aborted (core dumped).  This could be because some of some changing data layout when implementing new tracking method? Also something to note is that the global int flags like BC and FILL_LATTICE: are never declared and/or moved to the GPU. I am guessing they are supposed to be stored in the global state but that feels like the most significant difference in this PR.
This must be fixed before next version release

Fixed as of PR #222


Hitting enter on add expression inserts a new line and displays a warning.

Herbie: 9287265  Odyssey: 8da4444
I don't know if this is really an issue, as not every text box supports hitting enter to submit and then you have to figure out if shift-enter works or if that's the submit command. Current behavior is probably fine.
https://github.com/user-attachments/assets/7de9dcad-84e3-43bd-8532-5800923f8519

Quick solution, strip whitespace from start/end of expression @jaelafield

Fixed in 671c390


Example with parent structure

See https://github.com/guylabs/angular-spring-data-rest/issues/6

Close it as https://github.com/guylabs/angular-spring-data-rest/issues/6 is fixed.


inserting multiple files by fzf_file()

The help document of fzf_file() says "choose one or multiple to insert them",
but in reality it only inserts one.
Changing r:read("*line") to r:read("*all") will insert the multiple selected items,
but the entire items gets quoted as if one space-containd item is inserted.
Is this the intended behavior?
I'd like it to be possible to expand multiple items.
It would be good if each individual item was quoted as needed.
I'm use this tiny fix, but it is not good when space-contained item is selected.
> diff -u fzf-orig.lua fzf.lua
--- fzf-orig.lua        2024-07-05 21:39:05.194089200 +0900
+++ fzf.lua     2024-07-05 21:26:33.596039100 +0900
@@ -648,13 +648,13 @@
         return
     end

-    local str = r:read('*line')
+    local str = r:read('*all')
     str = str and str:gsub('[\r\n]+', ' ') or ''
     str = str:gsub(' +$', '')
     r:close()

     if #str > 0 then
-        insert_match(rl_buffer, first, last, has_quote, str)
+       insert_match(rl_buffer, first, last, '', str)
     end

     rl_buffer:refreshline()
@@ -1182,3 +1182,4 @@
     -- Reset the fzf completion hook.
     fzf_complete_intercept = false
 end)

Thanks for reporting this.  It's not the intended behavior.


proxyRequest does not use new req headers set event.headers.set()

Environment
Nitro v2.9.6
Node v20.12.2

Basic nuxt 3 project
Reproduction
https://stackblitz.com/edit/github-c51gfm?file=app.vue,server%2Fapi%2Fauth%2Flogin.post.ts,server%2Fapi%2F[...].ts
Describe the bug
import {joinURL} from "ufo";

export default defineEventHandler((event) => {
    const authCookie = getCookie(event, 'authorization')
    const {proxyUrl} = useRuntimeConfig()
    const path = event.path.replace(/^\/api\//, '')
    const target = joinURL(proxyUrl, path)
    event.headers.set('authorization', `Bearer ${authCookie}`) // does not work
    Object.assign(event.node.req.headers, { Authorization: 'Bearer ' + authCookie}) // works
    console.log(event.headers)
    return proxyRequest(event, target, {
        headers:{
            authorization: `Bearer ${authCookie}` // works
        }
    })
})

event.headers.set() does not apply to proxyRequest, but other variants works well
Additional context
No response
Logs
No response

Hi. With upcoming v2, two way sync will be possible (https://github.com/unjs/h3/pull/829)


FakeStream implementation

This is the FakeStream simple implementation.
But I have a few doubts here:

Is it worth to move FakeStream and FakeCollection classes to separate folder (like util) ?
For now it doesn't support operations like
Format.toCsv(FakeStream.Builder...) and Format.toJson(FakeStream.Builder...)
as it (Csv and Json classes in particular) was designed for FakeCollection only and it will take much effort (and much redundant and similar code) to add such an ability. What do you think, how could we improve the code and avoid of writing a lot of similar code? Probably to add some new level of abstraction? Or adding some converter function, which could convert FakeStream to FakeCollection and the pass collection to the functions like Format.toCsv(FakeStream.Builder...) and Format.toJson(FakeStream.Builder...) ?
Also, do we need a common interface or abstract class for FakeCollection and FakeStream, as them contain quite similar API? From my point of view, here we don't need common interface, as in fact them belong to different subjects...

Codecov Report

Merging #435 (da3e3a1) into main (2afc229) will decrease coverage by 0.16%.
The diff coverage is 87.27%.

@@             Coverage Diff              @@
##               main     #435      +/-   ##
============================================
- Coverage     93.95%   93.79%   -0.17%
- Complexity     2006     2013       +7
============================================
  Files           222      223       +1
  Lines          4021     4076      +55
  Branches        384      388       +4
============================================
+ Hits           3778     3823      +45
- Misses          146      156      +10
  Partials         97       97

Impacted Files
Coverage Δ

...n/java/net/datafaker/providers/base/BaseFaker.java
89.02% <66.66%> (-0.85%)
:arrow_down:

src/main/java/net/datafaker/FakeStream.java
88.46% <88.46%> (ø)

...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java
92.59% <0.00%> (-3.71%)
:arrow_down:

.../main/java/net/datafaker/service/FakerContext.java
84.61% <0.00%> (-2.57%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Hi @NarekDW great to see here and thanks for the contribution.
Agree about common classes.
First I would say we could completely reuse Builder and would say replace build() methods with collection() to build FakeCollection and stream() to build FakeStream... In theory for backward compatibility build() method could be still kept and marked as deprecated.
What do you think?
I will try to have a deeper look later

Hi @snuyanzin glad to see you :blush:
Thank you for the response :)
As I understood, you want to combine FakeCollection and FakeStream into one class and reuse common Builder, right?
If so, then I see some issues here:

Collection and Stream have different nature, Stream is not Collection and vice versa.
At first glance I see a number of challenges in implementation, for example:
2.1 initialization issue.
FakeCollection - is always a fixed sized data structure (with default value  = 10).
FakeStream - could be an infinite size data structure.
2.2 Issue to distinguish which data structure was created by the client (Collection or Stream)...

Correct me if I’m wrong please.
Don't you think that it would be better to keep them (FakeCollection and FakeStream) separately?

Not really. FakeCollection and FakeStream could be in separate classes
At the same time as you suggested above there could be an interface e.g. Sequence (probably there could be better name).
Both FakeCollection and FakeStream could implement it.
At the same time both builders are the same, so it could be extracted to this Sequence interface or even separately.
Initialization issue could be easily workarounded e.g.
    public static class Builder<T> {
        private final List<Supplier<T>> suppliers;
        private int minLength = -1; // negative means same as maxLength
        private int maxLength = -1; // negative means infinite stream
        private double nullRate = 0d;
        private BaseProviders faker;
    ...

    public FakeStream<T> buildStream() {
      ...
    }

    public FakeCollection<T> buildCollection() {
        maxLength = maxLength == -1 ? 10 : maxLength;
        ...
     }
}

2.2 Issue to distinguish which data structure was created by the client (Collection or Stream)...

Didn't get this problem. In Faker there could be 2 different methods collection() and stream(). So depends on which was invoked

@snuyanzin

I've added an abstract class FakeSequence, which is common class for FakeCollection and FakeStream classes, with common methods/API/Builder (in the child classes we just overwrite the build method).
Also, I changed CSV and Json creation method to support that common  (FakeSequence) class, instead of using FakeCollection only. Added support to generate csv and json from finite/infinite stream.
I moved that classes to the separate folder - util. Is it fine from backward compatibility point of view?
I don't like some classes names like CsvCollectionBasedBuilder and JsonFromCollectionBuilder + JsonForFakeCollection. It could be better to name them *Sequence*,  but I didn't change them as they are public classes and the change could lead to some issues with client code (regarding backward compatibility)...

Could you review please?
Is this the same way which you mentioned in your previous comment?

thanks, in general it looks good
there are a few cosmetic comments

I moved that classes to the separate folder - util. Is it fine from backward compatibility point of view?

It's better to have some more self-explanatory names e.g. sequence rather than util
2. Currently there are 2 classes CsvTest within this PR, the one from fileformats package should be removed together with fileformats package

Done. Changed the folder name from util to sequence and changed the error message in case of generating csv or json file from infinite sequence.

Merged
thanks for the contribution  @NarekDW

@NarekDW This is a really great contribution! Love it! Just wondering: would it be possible for you to add something to our documentation, the markdown files I mean? If you don't have time, no problem, I'm happy to port some of your unit tests to the public website (I saw you added something to the README already) and publish it here or so:
https://www.datafaker.net/documentation/collections/

this page is a result of generation based on input here https://github.com/datafaker-net/datafaker/blob/main/docs/documentation/collections.md
so you can just edit this file

Thanks, let me take a look.

Thanks!
And sorry about that 404, I've probably configured something wrong, thanks for reporting!

Please review - https://github.com/datafaker-net/datafaker/pull/443
Is that autogeneration (of docs) a part of CI?
How can I check the result? :)


Fixed issue #786

Hello,
I've fixed the issue with the rally points not working on the latest version.
o7

I made these changes, and it didn't fix the Rallly Points. Is there something I need to do have you make the changes?

Perhaps you need to rebuild js files:
npm run gulp production

@DontCryAndPlay thanks for the PR! I had already fixed this in the develop branch
branch: cffeea80a363935ec9c72461d8ffa3494d3b53d4


Is this library that much stable to use in Production App ? Please guide me

We use it in production successfully. If you have specific issues, please don't hesitate to open them on Github.

@ened when you will update this library because i see their was a last update of Stable versions of flutter_uploader on
1.2.0 | Nov 5, 2019 because i have to use this library in my production app and i am really excited to use this lib in my app.

@kadnan0900 I suggest you start by testing the beta version of the plugin in your app and report issues.


windows-terminal: function issue

As you can see, the shim cmd window will not close itself until the main windows terminal window is closed.

This is not related to windows-terminal but to scoop shims in general. I would call it a duplicate of https://github.com/lukesampson/scoop/issues/1606


Turn passwords to environment variables in docker-compose.yml

This refers to the ADOP-ready docker-compose file as created by @SachinKSingh28
Ensure it matches the ADOP approach to secrets.

New environment variables were added in env.config.sh file and used in docker-compose.yml

The changes related to this issue have been merged to my repository.

I believe this issue can be closed.


Allow to debug anonymous function

Debugging an anonymous plpg function can be a great feature.

[ ] Detect we are in an anonymous function in the editor
[ ] Create a temporary function with the anonymous code in the target
[ ] Debug it in direct mode
[ ] Delete the temporary function at the end of debugging

@cvas71 Hi, what about this proposal?

Hi! The idea is interesting, especially since you can only debug functions and procedures that exist in the dictionary. How much will this affect the dictionary, and in particular the use of values for OIDs of such procedures? After all, the database will have to constantly produce a new unique value. The number of these values is not finite?
At the moment, when using the current version, it happens that the positioning of the cursor on the desired line gets lost. It is not possible to repeat it on purpose.


Appstudio update mvp-test-component

Pipelines as Code configuration proposal

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
17 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
15 seconds
inspect-image

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
16 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
23 seconds
label-check

✅ Succeeded
22 seconds
optional-label-check

✅ Succeeded
5 seconds
show-summary

Pipelines as Code CI/mvp-test-component-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
17 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
15 seconds
inspect-image

✅ Succeeded
14 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
16 seconds
clair-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
23 seconds
label-check

✅ Succeeded
22 seconds
optional-label-check

✅ Succeeded
5 seconds
show-summary


Move a fallback language handling logic to a pluggable service

I'll close this too. Besides the fact we cannot merge/pick this anymore (technically), there was no more effort into this feature. The topic #605 remains.. yet.


Task Queue error in unit tests running on PhantomJS

Trying to unit test a simple custom element.
export class BrainDeadSimple {
  msg = 'hello';
}

with test:
import {BrainDeadSimple} from 'src/resources/elements/brain-dead-          simple/brain-dead-simple';
import {BindingEngine} from 'aurelia-binding';
import {Container} from 'aurelia-dependency-injection';
import {TemplatingEngine} from 'aurelia-templating';
import {TaskQueue} from 'aurelia-task-queue';

describe('BrainDeadSimple', () => {

  let testee;
  let templatingEngine;
  let container;

  beforeEach(() => {
    container = new Container();
    templatingEngine = container.get(TemplatingEngine);
    testee = templatingEngine.createViewModelForUnitTest(BrainDeadSimple);
  });

  it('should set msg', () => {
    expect(testee.msg).toBe('hello');
  });
});

results in error:
Error: Error invoking TaskQueue. Check the inner error for details.
inner error: TypeError: 'undefined' is not a constructor (evaluating 'new     (window.MutationObserver || window.WebKitMutationObserver)(callback)')

Not sure I need task queue imported here, but did that anyway to try to fix the error.
I am initialising the DOM elsewhere in code with:
import {initialize} from 'aurelia-pal-browser';
initialize();

I have the same issue.

I can work around this problem OK by using Chrome instead of Phantomjs when running karma tests.  However, have also started using Wallaby.js inside Intellij - and get the same problems.  Wallaby uses Phantomjs - so that is expected.  I can live with this for now.

We know how to fix this. I've got it on my list.

Thanks.  No intention to hassle you about this - no rush at my end - I know you'll get around to fixing it.  Just adding comment about Wallaby in case anyone was searching for the issue.


Unable to format code cell (no formatter for 'polyglot-notebook' files)

Describe the bug
When trigger "Format document" (alt+shift+f), VS Code prompts

There is no formatter for 'polyglot-notebook' files installed."

Same result with both .ipynb and .dib.
Please complete the following:
Which version of .NET Interactive are you using? (In a notebook, run the #!about magic command. ):
Version: 1.0.510102+2c9feb8daff54c194b638d355d18b5428480a786
Library version: 1.0.0-beta.24101.2+2c9feb8daff54c194b638d355d18b5428480a786
Build date: 2024-02-13T16:52:04.4164793Z

OS

[x] Windows 11
[ ] Windows 10
[ ] macOS
[ ] Linux (Please specify distro)
[ ] iOS
[ ] Android

Browser

[ ] Chrome
[ ] Edge
[ ] Firefox
[ ] Safari

Frontend

[ ] Jupyter Notebook
[ ] Jupyter Lab
[ ] nteract
[x] Visual Studio Code
[ ] Visual Studio Code Insiders
[ ] Visual Studio
[ ] Other (please specify)

Screenshots
If applicable, add screenshots to help explain your problem.

I exactly have the same problem.

Same problem for me. When working in an F# project, Ionide formats my code. When in Polyglot, I get the same message. For Python in Jupyter notebooks, the Black Formatter works.

up.

i have same problem.

Version: 1.0.522904+cdfa48b2ea1a27dfe0f545c42a34fd3ec7119074

Library version: 1.0.0-beta.24229.4+cdfa48b2ea1a27dfe0f545c42a34fd3ec7119074

Build date: 2024-05-07T02:45:57.5641864Z

https://github.com/dotnet/interactive

same here


Not Fired timers leak into the kernel

This has been reported by @pveentjer in a private conversation about io_uring Netty mechanics.

schedule a timer in 2 minutes
await till the IoUring event loop park/wait
schedule a second timer 10 seconds which is going to replace the last deadline set
once it fires, the next in-line scheduled task was the previous one of 1 hour (now <50 minutes, likely): the event loop arm a timer for this deadline (<50 mins)  BUT there was already such a timer, hence we arm it twice!

If we have a huge amount of already registered timers in the future, they will see their registrations to always happen twice, if their deadline is replaced with a new recent one.
Update the timer through a remove (via IORING_TIMEOUT_UPDATE) require >=5.11, while removing the existing one (when the new recent one need to be armed) is >=5.5.
There are several ways to address it, including NOT addressing it, but it can still cause silently to goes OOM or worse (no idea really).
I believe we had no covering for this because our await operations didn't allow any level of concurrency: if we block awaiting, is a blocking operations, period. But if we request to be awaken in the future, and we're awaken earlier, the same "in flight" request is not yet completed, hence allow to enqueue more and more of this.

@chrisvest @normanmaurer Netty 5 is affected the same I think


should update the skaffold setup + instruction to develop the docs

update to the latest skaffold version
update to use helm by default
update docs to run on remote k8s

need @hoavt to verify this

verified


Ensure 3 dates for calendar view

This reverts the Calendar tests to bring back some code that was used to ensure that the Calendar tests have enough dates to work with per month view.
These functions got removed during some cleanup work.

Ah, I thought taking this out was intentional.

Out was intentional but it was an oversight as those we're still needed.


Model configuration schema is not taken into account by the populate() query.

Hello,
I set my model config file with schema: false to prevent attributes filtering of the documents retrieved from mongo DB (for different reasons, the models in sails are not always defining all attributes of a document).
But the join document retrieved by a populate() query does not follow that schema: false configuration, and the attributes of the joined document are filtered according to the model.
For example, in database there are the two documents in different collections:
collection user: { _id: "a user ID", tenant: "a tenant ID", theme: "a theme ID" }
with a sails model like (this is not a real sails model but just an illustration): { id: { type: "string" }, tenant: { model: "Tenant" } }
collection tenant: { _id: "a tenant ID", lang: "fr", configuration: "A configuration" }
with a  sails model like (this is not a real sails model but just an illustration): { id: { type: "string" }, configuration: {type: "string"}}
a query like: sails.models.user.findOne({ id: "a user ID" }).populate('tenant') returns a user document like:
{ id: "a user ID", theme: "a theme ID", tenant: { id: "a tenant ID", configuration: "A configuration" }}
The lang attribute of the tenant has been filtered out as it is not defined by the tenant model, but the theme attribute of the user has been preserved as expected.
Node version: 14.18.3
Sails version (sails): 1.5.2
ORM hook version (sails-hook-orm):
Sockets hook version (sails-hook-sockets):
Organics hook version (sails-hook-organics):
Grunt hook version (sails-hook-grunt):
Uploads hook version (sails-hook-uploads):
DB adapter & version (e.g. sails-mysql@5.55.5): sails-mongo
Skipper adapter & version (e.g. skipper-s3@5.55.5):

@benoitbzl This is the intended behavior today https://github.com/balderdashy/waterline/blob/98e4b7cf2f16611c56a2542ddb2b92a56928ad94/lib/waterline/utils/query/process-all-records.js#L131-L149
Have you seen this information in our documentation?
I discussed this with @mikermcneil and he recommends using schema: true

Hello. For different reasons we cannot use the schema: true configuration in our case. We must disable the schema verification and result filtering. This works for the parent documents (attributes are not filtered), but it does not for the populated (child) documents (some attributes are filtered). If this is the intended behavior, it should be clearly stated in the documentation that the  schema: true configuration does only apply to parent documents.

@benoitbzl we agree that this should be documented, we'll update the documentation.


Spark operator helm chart moved to kubeflow

refer to the github issue, Spark Operator helm chart repo URL is changed to kubeflow.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Approving PR since the location of OSS Spark operator has changed to: repository='https://kubeflow.github.io/spark-operator'


Cannot checkout 11.9.0 tag

Describe the issue/behavior that seems buggy

Update: The correct commit appears to be: 2a4acf4.

When you git pull from the repo, you do not get the 11.9.0 tag.
On Github, this is shown:

Can one of the contributors please fix the tag so folks can backport new commits in main to it, especially since main appears to have breaking changes in it (please see #4026).
Thanks! :)

11.9.0 now points back into the history of main.  Thanks for report!


python27Packages.anytree: fix build

Motivation for this change
ZHF: #97479
Tests fail on python2.7 b/c the tests use enums (python 3.4+).
Follow-on from closed #97761.
Converts tests to use pytestCheckHook for easier test disabling.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

WFM macos 10.14 (not a full rebuild, obviously)

This should have gone to staging :/

Yeah it should have, sorry.

I moved this to staging (i.e. reverted on master).  It's a really large rebuild and these resources are rather scarce now.  Please watch the red labels from ofborg (5001+).

Yeah, I forgot some people are still trying to use master as normal while we're doing all the ZHF stuff.

Sorry about that, didn't realize how large the rebuild would be and forgot to switch to staging.

(it's my fault - I'm supposed to catch these things)


👷 Add docker-ignore to all-in-one image

Pain
Currently, our dockerfile copies every file from the repository in order to build the docker image - even unnecessary files like the deploy/* dir.
Suggested Solution
Adding .dockerignore file to avoid copying those files.

I can take that @maorlx

@ronyis assigned to you


fixed-point test remove liquidity

Codecov Report
Patch coverage: 85.10% and project coverage change: -0.07 :warning:

Comparison is base (02049c6) 83.60% compared to head (14e5c2f) 83.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   83.60%   83.54%   -0.07%
==========================================
  Files          32       32
  Lines        4161     4187      +26
==========================================
+ Hits         3479     3498      +19
- Misses        682      689       +7

Flag
Coverage Δ

unittests
83.54% <85.10%> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

elfpy/markets/borrow.py
76.27% <57.14%> (-1.90%)
:arrow_down:

elfpy/markets/base.py
89.88% <75.00%> (-0.82%)
:arrow_down:

elfpy/agents/wallet.py
87.50% <100.00%> (+0.61%)
:arrow_up:

elfpy/markets/hyperdrive/hyperdrive_market.py
78.75% <100.00%> (+0.29%)
:arrow_up:

elfpy/pricing_models/base.py
86.82% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Manually draw a curve in WpfPlot.

I want to enter points manually in a scatterplot by dragging the mouse, but apparently I need to turn off panning and zooming first. Can this be done?
The reason is that I want to draw an arbitrary curve to serve as the domain for a complex valued function. The output of the function will be displayed in a second scatterplot next to the domain plot.

You can use WpfPlot.Configuration.LockVerticalAxis = true and WpfPlot.Configuration.LockHorizontalAxis = true
You can turn off panning individually with WpfPlot.Configuration.LeftClickDragPan = false. Similarly WpfPlot.Configuration.RightClickDragZoom controls right-click dragging to zoom to a rectangle, and WpfPlot.Configuration.ScrollWheelZoom controls zooming with the scroll wheel.
You may want to check out the "WPF Config" demo: source. You can download the demo program here: https://scottplot.net/demo/


Add flag option to UsrInstance object

Just the ISO country code is enough
Ref:

https://github.com/repasscloud/lunavpn-api/issues/5
https://github.com/repasscloud/lvpnportal/issues/22

Not required. Handled in the API.


Support multi-step swaps with Curve

When a user has ETH and wants OETH, there are two options: minting with the zapper or swapping through the Curve ETH/OETH pool. However, if she has stETH or another LSD and wants OETH, minting is currently the only option. Due to the frequency of stETH (and others) being off-peg, there's a high likelihood that users won't be able to acquire OETH from our dapp. Let's add support for additional Curve swaps beyond just ETH/OETH.
In order of priority...

[ ] stETH
[ ] WETH
[ ] rETH
[ ] frxETH

@smitch88 isn't this merged?

Yup, closing


update sequelize to ^3.2.0

I couldn't get the tests to pass, but I couldn't get them to pass before I made changes. They fail in the same way as before.

Thanks,
All test seem to pass, I'll update the README to make it more clear how to run them


Documentation: Clarify which URLs to use for

Hi, I am working over some stumbling blocks with integrating popper into my application. For example, I wasn't sure which of the many URLs listed on CDNJS to use in my <script> tags:
https://cdnjs.com/libraries/popper.js
Could the popper documentation include a mention of which of these to use? I think it's
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.15.0/umd/popper-utils.js"></script>

But I'm not entirely sure.

Hey, CloudFlare is not even an officially supported CDN.
If you click on the Unpkg URL you are directed to the correct URL/file already.
Also, please, read the dist targets chapter, since it answers your exact question.
To be honest, I doubt any amount of documentation could help if I then get questions with people trying to use a CDN not even listed in the documentation...


Volta Unable to find executable

Description
LspInfo is showing "Unable to find executable" for every server installed through Volta npm.
I noticed both cmd are suffixed with .cmd, while my other LSP that's working are not.
I tried to remove .cmd from the cmd, and it no longer throws the error. However, the LSP is now not working as expected (no syntax highlighting and others).
With some searching, I found out that .cmd is needed on Windows.
Neovim version
NVIM v0.5.1
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Nvim-lspconfig version
No response
Operating system and version
Windows 10
Affected language servers
svelte, tsserver
Steps to reproduce

Install LSP according to readme
Open .svelte or .ts file
View LspInfo

Actual behavior
Unable to find the executable of language server.
Expected behavior
Language server functioning properly.
Minimal config
local on_windows = vim.loop.os_uname().version:match 'Windows'

local function join_paths(...)
  local path_sep = on_windows and '\\' or '/'
  local result = table.concat({ ... }, path_sep)
  return result
end

vim.cmd [[set runtimepath=$VIMRUNTIME]]

local temp_dir
if on_windows then
  temp_dir = vim.loop.os_getenv 'TEMP'
else
  temp_dir = '/tmp'
end

vim.cmd('set packpath=' .. join_paths(temp_dir, 'nvim', 'site'))

local package_root = join_paths(temp_dir, 'nvim', 'site', 'pack')
local install_path = join_paths(package_root, 'packer', 'start', 'packer.nvim')
local compile_path = join_paths(install_path, 'plugin', 'packer_compiled.lua')

local function load_plugins()
  require('packer').startup {
    {
      'wbthomason/packer.nvim',
      'neovim/nvim-lspconfig',
    },
    config = {
      package_root = package_root,
      compile_path = compile_path,
    },
  }
end

_G.load_config = function()
  vim.lsp.set_log_level 'trace'
  if vim.fn.has 'nvim-0.5.1' == 1 then
    require('vim.lsp.log').set_format_func(vim.inspect)
  end
  local nvim_lsp = require 'lspconfig'
  local on_attach = function(_, bufnr)
    local function buf_set_keymap(...)
      vim.api.nvim_buf_set_keymap(bufnr, ...)
    end
    local function buf_set_option(...)
      vim.api.nvim_buf_set_option(bufnr, ...)
    end

    buf_set_option('omnifunc', 'v:lua.vim.lsp.omnifunc')

    -- Mappings.
    local opts = { noremap = true, silent = true }
    buf_set_keymap('n', 'gD', '<Cmd>lua vim.lsp.buf.declaration()<CR>', opts)
    buf_set_keymap('n', 'gd', '<Cmd>lua vim.lsp.buf.definition()<CR>', opts)
    buf_set_keymap('n', 'K', '<Cmd>lua vim.lsp.buf.hover()<CR>', opts)
    buf_set_keymap('n', 'gi', '<cmd>lua vim.lsp.buf.implementation()<CR>', opts)
    buf_set_keymap('n', '<C-k>', '<cmd>lua vim.lsp.buf.signature_help()<CR>', opts)
    buf_set_keymap('n', '<space>wa', '<cmd>lua vim.lsp.buf.add_workspace_folder()<CR>', opts)
    buf_set_keymap('n', '<space>wr', '<cmd>lua vim.lsp.buf.remove_workspace_folder()<CR>', opts)
    buf_set_keymap('n', '<space>wl', '<cmd>lua print(vim.inspect(vim.lsp.buf.list_workspace_folders()))<CR>', opts)
    buf_set_keymap('n', '<space>D', '<cmd>lua vim.lsp.buf.type_definition()<CR>', opts)
    buf_set_keymap('n', '<space>rn', '<cmd>lua vim.lsp.buf.rename()<CR>', opts)
    buf_set_keymap('n', 'gr', '<cmd>lua vim.lsp.buf.references()<CR>', opts)
    buf_set_keymap('n', '<space>e', '<cmd>lua vim.lsp.diagnostic.show_line_diagnostics()<CR>', opts)
    buf_set_keymap('n', '[d', '<cmd>lua vim.lsp.diagnostic.goto_prev()<CR>', opts)
    buf_set_keymap('n', ']d', '<cmd>lua vim.lsp.diagnostic.goto_next()<CR>', opts)
    buf_set_keymap('n', '<space>q', '<cmd>lua vim.lsp.diagnostic.set_loclist()<CR>', opts)
  end

  -- Add the server that troubles you here
  local name = 'svelte'
  local cmd = { 'svelteserver.cmd', '--stdio' } -- needed for elixirls, omnisharp, sumneko_lua
  if not name then
    print 'You have not defined a server name, please edit minimal_init.lua'
  end
  if not nvim_lsp[name].document_config.default_config.cmd and not cmd then
    print [[You have not defined a server default cmd for a server
      that requires it please edit minimal_init.lua]]
  end

  nvim_lsp[name].setup {
    cmd = cmd,
    on_attach = on_attach,
  }

  print [[You can find your log at $HOME/.cache/nvim/lsp.log. Please paste in a github issue under a details tag as described in the issue template.]]
end

if vim.fn.isdirectory(install_path) == 0 then
  vim.fn.system { 'git', 'clone', 'https://github.com/wbthomason/packer.nvim', install_path }
  load_plugins()
  require('packer').sync()
  vim.cmd [[autocmd User PackerComplete ++once lua load_config()]]
else
  load_plugins()
  require('packer').sync()
  _G.load_config()
end

Health check
health#lspconfig#check
Checking language server protocol configuration

ERROR: svelte: The given command "svelteserver.cmd" is not executable.

LSP log
https://gist.github.com/AvlKP-dev/54b35cab3cbe7ef5dbe0e77c52932198

Sorry, probably copied the thing before editing.
Fixed it.

You installed the servers and both are executable from the command line?

Yes. Here is my installed packages (I'm using Volta):
⚡ Currently active tools:
Node: v14.17.6 (default)
npm: v8.1.2 (default)
Tool binaries available:
    tailwindcss-language-server (default)
    volar-server (default)
    emmet-ls (default)
    firebase (default)
    neovim-node-host (default)
    pyright, pyright-langserver (default)
    svelteserver (default)
    tsc, tsserver (current @ E:\Projects\Indput\package.json)
    typescript-language-server (default)
    vscode-css-language-server, vscode-eslint-language-server, vscode-html-language-server,
vscode-
    json-language-server (default)

See options for more detailed reports by running volta list --help.

Is the only issue you are having svelte? I was confused by your original issue which mentioned tsserver.

I have also experienced issue with tsserver, but decided to exclude it from the minimal config. Should I add it?

I have found the cause.  Volta automatically added the installed packages to a bin folder and the env variable is configured for that folder. The only bins in that folder are those without file extensions and a symbolic link .exe file. Is there any way to go around this?

Well, you can try changing cmd to call insert_server_name.exe
I use Volta on linux/MacOS and the default configurations work fine. I’d have to find/look into this on windows

From: AvlKP-dev @.>
Sent: Friday, November 19, 2021 3:27:58 AM
To: neovim/nvim-lspconfig @.>
Cc: Michael Lingelbach @.>; Comment @.>
Subject: Re: [neovim/nvim-lspconfig] Unable to find executable (Issue #1444)
I have found the cause. Volta automatically added the installed packages to a bin folder and the env variable is configured for that folder. The only bins in that folder are those without file extensions and a symbolic link .exe file. Is there any way to go around this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/neovim/nvim-lspconfig/issues/1444#issuecomment-973861252, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADFTBJVZBPAFTSKODXC3UVDUMYDA5ANCNFSM5IJ2N3GQ.

I have done so, it still doesn't work for me. Installing it through nvim-lsp-installer fixed it for now.

Make sure that :where svelteserver actually works, and then just use:
require("lspconfig").svelte.setup({
  cmd = {
  "svelteserver",
   "--stdio"}
})

Otherwise, provide the full path to wherever volta has these binaries.
Note: I was unable to use "$env:LOCALAPPDATA\\Volta\\bin\\svelteserver.exe" since Neovim was refusing to expand the environment variables, no matter what I tried.

@williamboman I don't know what to do here. I think volta's installation is actually preferable because the installed packages are invokable without special casing the cmd name on windows... I could make it not special case the cmd on windows and then suggest people use volta to install. I'm not a windows user so I don't know the most convenient thing to do for them.

@williamboman I don't know what to do here. I think volta's installation is actually preferable because the installed packages are invokable without special casing the cmd name on windows... I could make it not special case the cmd on windows and then suggest people use volta to install. I'm not a windows user so I don't know the most convenient thing to do for them.

Hm I'm not familiar with this problem (I am mostly improvising with most things Windows). Would it be possible to try to detect what flavour of Node/npm installation is active based on some heuristics and use that to modify the cmd accordingly?

I would rather not introduce complexity to deal with windows. The problem is actually already an issue sans volta, many commands implement the post-hoc postfixing with .cmd for windows. I am contemplating dropping it entirely and encouraging windows users to use volta, but that might entail nvim-lsp-install adding the shims to call the language server without the post-fixed .cmd

I know the issue now. Closing this issue in favor of #1500


[Enhancement] Cancle also on outercircle-click

It would be great to also have the option to get a cancel or maybe an extra event on a click on the outer circle.

You can use TapTargetView:: onOuterCircleClick for it.

Ah ok i see ... also found "considerOuterCircleCanceled"
So I close this issue, thanks. But consider to update/complete the docs 👍


Timelapse mode

@jedgarpark this is a new timelapsing mode with sub-modes use OK to turn on / off timelapse, and SEL button to change power mode (backlight/preview)

@jedgarpark dunzo - please check latest commit code/library for 'frozen' settings

There's some minor flickering on the screen when the new labels are in use but nothing that makes me want to hold this back

@ladyada just got back from trip, tested timelapse, the new locked settings are great, no more flicker!


Catching rets errors in multipart

Description
GitHub Issues

Coverage increased (+0.05%) to 91.682% when pulling 4538d7c7ced3788d338b3c3e3df52d8956e1e01c on mcrowson:catching-rets-errors-in-multipart into a0d277d38b1bb75ae13bf2a1fbabacdbef9b52f4 on refindlyllc:development.


Add gzip to Azure.Monitor.Ingestion

Completed in https://github.com/Azure/azure-sdk-for-net/pull/29426


Engine uses the eloquent getScoutKey() to get key values but uses getKeyName() to get the name of the key

Scout allows you to customize the Eloquent value and key name used for the keys in your index.
The Meilisearch engine uses the getScoutKey() method to get the key value however, makes use of the getKeyName() method instead of the getScoutKeyName() method for the value.
I would like to change this behaviour to use the getScoutKeyName() method instead of getKeyName(). May I go ahead with a PR?

I think that this would not work out as expected.
The getScoutKeyName() method is only used for fetching the models from the database not from the search index. It looks to me as if the documentation and the method description on laravel/scout is not correct.
This means that if we change getKeyName() to getScoutKeyName() in the MeiliSearchEngine class, everyone that uses the library also would need to add a toSearchableArray method on each model and set the primaryKey name of that model to getScoutKeyName() and the value to getScoutKey.
For Aloglia this works because there is a mandatory field ObjectID that is sent with each create/update/delete. Whereas the identifier for a MeiliSearch index basically can be set to anything you want.
@keithza maybe you can point this out in the issues at laravel/scout

@mmachatschek there definitely seems to be an issue with laravel/scout and the documentation as well as the behavior of getScoutKeyName() in the laravel/scout code as well. The base method returns the qualified name meaning <table>.<key>. This causes issues.
I still feel that this should apply so that using the --key option in the scout:index command can be implemented without the need for implementing the change to the toSearchableArray() method and allow use of the custom key name for tables without an id field.
If getScoutKeyName() was implemented correctly in laravel/scout only one change would need to be made in the getKeyName() method and that change would cascade.
Regardless, before this can happen, laravel/scout needs to be amended.


Example of all_of

New example of all_of

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: EmilEnchev sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@EmilEnchev : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@corob-msft : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Fix editor tabs

Coverage decreased (-0.1%) to 79.685% when pulling 392e2c9eaa5a302fb1e688267ec9039847008841 on dwarfcrank:fucking-editor-tabs into c20dc45d3060ebae1c0bef8065b199b3abe6d0d7 on tdd-pingis:master.

Coverage decreased (-0.1%) to 79.685% when pulling 9c0734126c19182be934da198b81a2475d6293f9 on dwarfcrank:fucking-editor-tabs into c20dc45d3060ebae1c0bef8065b199b3abe6d0d7 on tdd-pingis:master.

Nice


Add meeting notes for 2022-09-07, 2022-09-21, 2022-10-05, 2022-10-19,…

… 2022-11-02 and fix typo in README.md

:heart:


Fix 107 Merge River Deltas into Tilemaps

This PR will merge the river deltas into tilemaps. It also fixed a problem where the tilemaps branch never showed any rivers. There's still work to be done; currently the deltas will often show up in the ocean or on a land tile. I should check for river directionality, which will be somewhat more complex

This delta is showing up in the ocean. Also the rivers are always rendered in the middle of tiles, which is a problem since you can't easily tell what edge they're on (bad for debugging but also for playing).
This delta needs to be forward a bit

The way the TileMap renders terrain is terrainTilemap is offset such that it renders the base terrain at the intersection of 4 tiles, so it is offset from tilemap which renders everything else such as hills and forests that fall on a tile. This is done because the terrain that should be rendered on each tile is 4 corners from terrain pcx tiles. I'm not sure how rivers are rendered but it's likely that they could be added as another layer in terrainTilemap?

Ok, thanks for the info. In that case I think we just need to make it rivers are not offset from the base grid. That way they'll start at corners of tiles like (I think) they do in the base game

This is proving more difficult than expected. Rivers are currently marked as a layer in the tilemap, but making them show up at the corner of tiles (or at least shifted a bit) is tricky.

Whenever I mess with setCell in mapView to try and offset rivers there, they don't show up properly. I tried to offset them by half a tile width in x, y, or both, but none of that worked. It might be possible to offset them and I'm just doing it wrong, so I'll keep looking into this

I don't think it's really possible to set the offset of a tile in a TileMap - the stackedCoords are coordinates that index into a tile. We can set an offset for a particular atlas texture in the TileMap. This is done in the TileSetLoader in TileSetLoader.cs. You can trace the code, but for example:
{Atlas.JungleVolcano, new AtlasLoader("Art/Terrain/Volcanos jungles.pcx", 4, 4, mountainSize, 12)},

The last parameter is passed into the loader, and eventually gets assigned to TextureOrigin, which gives that texture a relative offset to the tile it's in. I'm pretty sure rivers are rendered on tile edges they lay along. I'd suggest adding the river tiles to terrainTileset since the entire terrain tilemap is offsest half a tile in both x and y, so if we render a river overtop of base terrain on the terrainTilemap I think the river texture will line up perfectly with tile boundaries. This thread gives a decent explanation of how terrain is rendered: https://forums.civfanatics.com/threads/terrain-editing.622999/

@benskywalker have you or can you check the selection logic against the Java code linked to in #107 ? I think that's the best reference we have.

@benskywalker have you or can you check the selection logic against the Java code linked to in #107 ? I think that's the best reference we have.

I haven't, but I'll get on that once I've got some more dev time


Merge latest changes in develop into the community branch

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: lostmsu sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Integrate Zen Coding for HTML

Zen Coding is available for CodeMirror, and it speeds up HTML code composing a lot.

Oh that's cool, didn't know that existed. I'll definitely look into that!


Register default services directly in AddMvc and remove MvcServices

https://github.com/aspnet/Mvc/issues/1634
@rynowak @pranavkm @HaoK

Are the only real changes here that it now call TryAddXyz?
Also per @HaoK's comments from #1634 are any of these multiply-registered services that should use AddXyz or are they all single-instance services? (Did that even make any sense? :smile: )

Yeah so the general idea is, anything that is being resolved as IEnumerable of a service, you want don't want to use TryAdd, because well, you'll never get more than one.  So I noticed that issue for IConfigureOptions, I am not familiar enough with all the other MVC services, but that's the review that needs to be done...

There's a few others that are multi-service. I'll take a look.

Also take a look at the webapi compat shim project.

Updated /cc: @rynowak @Eilon @HaoK

:shipit:

commit 284c8992333d5eeede4bfd9b34974994606e5c8b


Move the 'thread-local stack' implementation up from datastore.

Preparing to tackle #15, which needs similar support in storage.

Coverage remained the same at 100.0% when pulling 83ed43763efb0f4af5234e6aac01af8c58f17911 on tseaver:move-thread_local_stack_up into 32e50ebe81306be0b878450c5ddefc5ce27a4d07 on GoogleCloudPlatform:master.

LGTM (I think you should clarify the module docstring, but do as you see fit).

@tseaver When merged can you ping me and point at the next PR in line?

I'm still working on the next-in-line (it is the real meat of #15).

OK cool

@dhermes I'm partway through the middle part here, if you are interested.

Just took a peek. I feel like the multipart stuff will have been handled already by @craigcitro
Also, what sorts of API requests are allowed with batch? Any and all?

I didn't see any of that in apitools.  @craigcitro, can you comment?  We are talking specifically about the batch request and batch response kinds of multipart API calls.
Batching can handle POST, PATCH, and DELETE for buckets, blobs, and their ACLS, but not GET (the batch object just proxies it through) nor the upload / download APIs (not yet excluded).

writing from my phone - but apitools has full batch support. see base/py/batch.py

I didn't see the batching support in apitools because we didn't vendor in that module.  Looking at it, I think we would be using the lower-level BatchHttpRequest class, because the higher-level BatchApiRequest.ApiCall class takes a service constructor paramter defined as being an instance of a subclass of apitools.base.py.base_api.BaseApiServie, which would put us back in protorpc land.
@craigcitro It looks like the BatchHttpRequest does not preserve the original ordering of the batched requests (they are stored in a dict, whose keys are iterated when building the payload.  I'm not sure if that would matter, but it bugs me a bit.

apitools/base/py/batch.py module doesn't appear to have test coverage, and does not yet straddle Py3k.

@tseaver ah, i probably don't export batch_test.py from internal. trying to get that sync'd up.


Bug: possible to see how other players voted

Update waiter move message payload to not contain actual player move details. Only indication that player made the move.
In console it is possible to see how other players voted even though my vote is not finished yet

Tested on local environment.
In console it is possible to see how other players voted even though game is not finished yet.

Tested on local environment. In console it is possible to see how other players voted even though game is not finished yet.

We did not remove the logs in the local environment for debugging reasons. After deploying to production environment logs should not be visible anymore.


AuthError after migrating from Laravel 10 to 11 on Private Channel

Reverb Version
1.4.4
Laravel Version
11.35.1
PHP Version
8.3.12
Description
After having an existing Laravel 10 application, and following the migration steps to upgrade to Laravel 11, I get the following error when listening to a private channel.
Object { type: "AuthError", error: "JSON returned from channel-authorization endpoint was invalid, yet status code was 200. Data was: ", status: 200 }
This private channel was previously working without error before upgrading.
This is occurring on my machine running Laravel Herd.

Steps To Reproduce
Demo repo: https://github.com/jonjakoblich/reverb-10
Steps taken in repository

Install fresh Laravel 10 application with latest Laravel 10 version
Install Jetstream w/ Inertia-Vue
Create an event to test
Modify welcome page to listen to event
Upgrade to Laravel 11

To reproduce

Clone the repository linked above
Install and run the site using Laravel Herd (not tested in other environments)
Install composer packages, node packages, run migrations
Run npm run build
Register a user (& be logged in since the private channel is related to the user)
Navigate to welcome page (should be base URL of the newly installed app)
Open Tinker and run the test event broadcast(new MyTestEvent(User::find(1)));
Inspect in the console to see the error
Inspect the network tab to see that the web socket connection was not the expected response

Hey @jonjakoblich, which URL is being requested when that error is returned?

Thanks, but I meant is that request failing on the broadcasting/auth endpoint or connecting to the WebSocket server itself. Are you able to show the failing request in the network tab?

Thanks, but I meant is that request failing on the broadcasting/auth endpoint or connecting to the WebSocket server itself. Are you able to show the failing request in the network tab?

@joedixon I'm attaching a few additional screenshots here of the broadcasting/auth endpoint. Hopefully this helps. Let me know if you need something else.

I'm sorry, it's still not clear to me where the error is being generated. Are any of the network requests returning failed status codes?

@joedixon No, they are not. The blue highlighted request in each of those screenshots is the request. You can see the 101 status in the first one (the web socket connection I believe) and the 200 status in the successive ones on each (the /broadcasting/auth endpoint). The screenshots are from Firefox Developer Edition. Beyond that, I've not been able to trace the error. It looks like it connects to the /broadcasting/auth endpoint, gets a 200 response, but not the anticipated data back.
I don't know if you've had a chance to clone and install the demo repo I provided, but that does illustrate the issue when using Laravel Herd. I have not tried other setups.

I was facing the same problem, make sure you have BROADCAST_CONNECTION=reverb in you .env

I was facing the same problem, make sure you have BROADCAST_CONNECTION=reverb in your .env

I already have it set up that way. Thank you.


Does RTM support team_migration_started event?

As documented in Slack team_migration_started event happens when teams are being switched between servers. Does botkit RTM handle that?

You can listen for that event, but currently Botkit does nothing with it by default.
controller.on('team_migration_started',function(bot,message) {
// message contains the original message from slack
});

Yeah, so currently we need to re-connect manually?

You can pass in retry: true to your call to controller.spawn


File extension validation fix

(optional) Issue number:
Summary of the change:
Added validation + tests to prevent uploading a php file disguised as an image by checking the file extension, rather than relying solely on the mime type check.
Added an allowed_types option in the config with jpg, gif and png as default - you may want to add more as default

NOTE: The failed test/errors were already there before I made these changes so would appreciate it if you could merge this security fix as without it, any user can execute shell/php really easily

already test it and file .php (image file that already midified with php code) still success uploaded by tamper data manipulation.

With a .php extension? An image file with php code in it isn’t much good if it doesn’t execute.

already test it and file .php (image file that already midified with php code) still success uploaded by tamper data manipulation.

With a .php extension? An image file with php code in it isn’t much good if it doesn’t execute.

yes, this is how it's work, first i'm upload minishell.jpg then using tamper data tools modified to minishell.php then it's success uploaded as minishell.php.
when execute, it's looks like broken but works fine to upload another shell backdoor..

already test it and file .php (image file that already midified with php code) still success uploaded by tamper data manipulation.

With a .php extension? An image file with php code in it isn’t much good if it doesn’t execute.

yes, this is how it's work, first i'm upload minishell.jpg then using tamper data tools modified to minishell.php then it's success uploaded as minishell.php. when execute, it's looks like broken but works fine to upload another shell backdoor..

this work on latest v2.6.0

this work on latest v2.6.0

Did you try it with this fix though? The PR hasn’t been merged yet

this work on latest v2.6.0

Did you try it with this fix though? The PR hasn’t been merged yet

sorry my bad, already try with your commits and it's work correctly now

Thanks @deanzod for you PR. This is related #1113 .
In v2.6.2 a new config disallowed_extensions has been added, and it defaults to block extensions for .php & .html.
Similar to another config disallowed_mimetypes, the reason why I chose to implement it with blocklist rather than allowlist, is I want to make setup steps as simple as it can. If an allowlist is implemented, users have to fill in all extensions they need. It is much more secure, but also frustrating for a first-time user in my own opinion.
So I will close this PR for now. But I will keep in mind if there is a way to make it more secure.
Thanks again for your awesome PR!


Restructure

Summary

Overall goal of this restructuring is to allow user contributed code alongside generated code.
Each generated task has its module, nested in its former module label, jobs, under code_generated, e.g.
prefect_databricks/jobs/code_generated/jobs_submit.py
prefect_databricks/jobs/code_generated/jobs_create.py
Benefit of this is that each task can be regenerated individually without affecting other tasks / modules.
Alongside code_generated directory is the user_contributed directory where it's free-form code written by someone.
prefect_databricks/jobs/user_contributed/flows.py
Through this structure, there's no breaking changes thanks to the multiple __init__.py, so users can still do
from prefect_databricks import jobs_runs_submit, but at the moment, I don't like how the init.py imports and might not be idempotent in regenerating it.
However, I am wondering if I should have the code_generated and module label swapped, e.g.
prefect_databricks/code_generated/jobs/*.py
prefect_databricks/user_contributed/jobs/*.py
instead of
prefect_databricks/jobs/code_generated/*.py
prefect_databricks/jobs/user_contributed/*.py
Probably?
Also, not sure where to put credentials.py and rest.py; under code_generated I assume. And I wonder if I should make this so granular (one task per module), or have it as before (multiple endpoints per module)
Suggestions welcomed!
Relevant Issue(s)

This follows option 5 of https://github.com/PrefectHQ/prefect-collection-generator/issues/58.
Checklist

[ ] Summarized PR's changes in CHANGELOG.md

Nevermind about swapping because it ends up being really strange.
.
├── __init__.py
├── _version.py
├── code_generated
│   ├── __init__.py
│   └── jobs.py
├── jobs.py
└── user_contributed
    ├── __init__.py
    └── jobs.py

Has a base jobs.py that calls:
from code_generated.jobs import *
from user_contributed.jobs import *

I think that the generated code should go in a folder or file named _generated to communicate that it is an internal detail.
I also like having one task per file since I think it makes it easier to navigate the generated code, but that may be bias by my past usage of Java/JS.
I also think that there shouldn't be a module named user_contributed. Instead everything that is not in the _generated module is considered user contributed.

Closing in favor of https://github.com/PrefectHQ/prefect-databricks/pull/36


perf: remove unused Svelte code

Not sure if I actually want to do this, but let's look at the perf numbers.

Doesn't feel worth it for 480 bytes


Pulled out app paths to separate config and added a check for required files in start script

PR is still a work in progress mainly because for some reason installing the module globally on my local machine to test was not working and even installing the module from npm doesn't work so I haven't really been able to test this -_-
I keep getting a prompt saying that the create-react-app command is not found.
Anyways...
I also feel like I should add some logic where the browser doesn't attempt to open if there are any missing required files, maybe don't even compile if any files are missing.
Referencing issue #96
If someone wants to build on top of this PR feel free too as well, just leave a comment below in case I or someone else wants to continue this.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Both myself and @lacker have the issue of npm install -g react-native not working. Would be awesome to investigate and figure out why

@vjeux interesting, when I start working on this again i'll look into that issue as well.

By the way I started making the path change (although in a different way) in #191.

I’m going to close this because it got out of date.
This was a bit hard to review because it contains two unrelated changes.
We still need help on #96 so please feel free to resubmit focusing on that feature in particular.
Thank you!

Makes sense, the portions of the changes (path changes) seem to already be made so i'll look into the changes and try making another PR that solely focuses on fixing the issue if no one is already pursuing #96.


vagga doc failing with missing sphinx dependency

Building documentation fails with the following message:
sphinx-build -b html -d _build/doctrees   . _build/html
Traceback (most recent call last):
  File "/usr/bin/sphinx-build", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2927, in <module>
    @_call_aside
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2913, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 2940, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 635, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 943, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.7/site-packages/pkg_resources/__init__.py", line 829, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'imagesize' distribution was not found and is required by Sphinx
Makefile:53: recipe for target 'html' failed
make: *** [html] Error 1

This is happening because the package py-sphinx (version 1.4.1-r0) currently does not have py-imagesize as a dependency since py-imagesize is still in the branch edge of the alpine repository.
A simple solution would be adding the missing imagesize dependency using pip:
containers:
  docs:
    setup:
    - !Alpine v3.4
    - !Install [alpine-base, py-sphinx, make]
    - !Py2Install [imagesize] # add the missing dependency
    - !Py2Requirements docs/requirements.txt

Fixed https://github.com/tailhook/vagga/pull/292


NSG/Firewall limitations unclear

The Limitations section is unclear on how to restrict access within an existing environment. Am i reading correctly that we will need to:

Create outbound NSG rules on every other subnet to prevent access to the Private Endpoint
Create /32 UDR's to prevent traffic from ExpressRoute hitting the SQL servers for specific ranges within our on-prem network
Can you elaborate in more detail how to secure these resources?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b006a616-2f2f-8ecf-8b80-fd0a3cc62090
Version Independent ID: 92c54dc6-8ddf-b1f7-4a58-d61b8cd7fe25
Content: What is an Azure Private Endpoint?
Content Source: articles/private-link/private-endpoint-overview.md
Service: private-link
GitHub Login: @malopMSFT
Microsoft Alias: allensu

@dr-ivan Thanks for the feedback. We are investigating the issue and will update you shortly.

@dr-ivan, yes you are correct. You need to add NSG outbound deny rule to Private endpoint to the all the sources which you don't want access to the private Endpoint.
If you have On-Premises traffic to Azure VNET, then you need to have a specific /32 route of the Private endpoint next hop as null and associate that to the Gateway Subnet.
Hope that clarifies.

@dr-ivan , We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


[rlgl] Fixed return type of rlGetCompressedFormatName

The return type of rlGetCompressedFormatName has been corrected from char * to const char *

@Bigfoot71 thanks for the review!


if you right click the same straw cushion twice, you become stuck and cannot unmount by shifting

I had to break it and put it in a new spot , and sit on that cushion to be able to dismount,
also they seem to leave behind a weird white dot after breaking them

I'll fix it as soon as possible.


Excessive RAM usage building with the release profile

Describe the bug
Under archlinux, the PKGBUILD runs cargo build --frozen --release and it uses up to 10GB RAM for the build. Is there something we can do to optimize this much RAM usage?
To Reproduce
clone the repo, cd to the repo
  export RUSTUP_TOOLCHAIN=stable
  export CARGO_TARGET_DIR=target
  cargo build --frozen --release

Expected behavior
Compile with a reasonable amount of RAM usage.

disable lto

to tell you the truth, i didn't know how to file it either. it is not a feature request or a security issue, afaict.
I believe cargo build --release is pretty common, although from what i see in the CI files it seems like mise releases do not use the release profile and never see this issue. But lto is set to true in mise's Cargo.toml so maybe that's something we could (or should) change?


PhpStorm: Not remember windows size, cursor grab false visual element position

Environment
Windows build number: Microsoft Windows NT 10.0.22000.0
Your Distribution version: 20.04
Your WSLg version: 1.0.24
Install Intel and Nvidia CUDA drivers.
Steps to reproduce
Install X11 apps. Manually installed latest PhpStorm. Open PhpStorm via wsl /opt/PhpStorm-*/bin/phpstorm.sh

Open first time PhpStorm, click to full screen, close program. Start PhpStorm again - program isn't in full screen border.
When click in full screen border PhpStorm - mouse grab false element position inside this program. Mouse grab position before apply program in full screen border. When program in not full screen and manually change size window - mouse grab correctly position element inside program.

UPD:

Problem

If before maximized window change position window on screen - problem is not tracked

Still a problem. window sizing is erratic, I spend so much time resizing every opened window.
Problem is more acute with multiple monitors:
1 - Open a window on monitor 1, move it to 2. (2 having a bigger resolution and scaled at 1x)
2 - Close phpstorm, reopen it, everything is sized up like 1.3 times, expanding through multiple monitors...
Every issue filed to Jetbrains reports a wslg problem...


Fix the c8y custom operation status handling

Proposed changes
A custom operation managed in /etc/tedge/operations/c8y could be marked successful unconditionally and the status had been sent out before the operation has completed.
To fix, now the Cumulocity converter holds a mqtt publisher and sends executing and successful/failed message from the converter. Either successful or failed is determined by the exit code (0 or not).
Also, stdout is reported when successful, and stderr for a failed case.
Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue
#1603
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

To sanitize an utf8 string I would work at the char level and not to byte level.
Something along the lines:
input.chars().filter( ...).map(...).take(max).collect()

There are then 2 tricky points:

How to sanitize a non-utf8 input? One can use the current code.
How to cut the utf8 output to fit the maximum size that is a byte count? I would try to use an iter::scan that accumulates the number of bytes used so far.

        input
            .chars()
            .filter(...)
            .flat_map(...)
            .scan(0, |bytes_count, char| {
                *bytes_count = *bytes_count + number_bytes(char);
                Some( (*bytes_count, char))
            })
            .take_while(|(size, _)| { size <= max })
            .map(|(_,char)| {char})
            .collect();

Thanks @didier-wenzek. You are absolutely right. Now all sanitising functions were re-written.


Force streamer and audio input device sample rate

Is it possible to change audio sample rate of the audio input device and NDI streamer to specific setting?
I'm using an USB audio device with Raspberry to stream over NDI that supports 48kHz sample rate. The NDI project in the receiving machine is otherwise using 48kHz sample rate audio inputs, and Dicaffeine NDI streamer appears only connect to the USB audio device at 44.1kHz.

Hi, it's not possible right now, but I will post some examples here:
https://dicaffeine.com/guide
to show how to change special settings not available in GUI.


Require s3fs >=2021.08.0 for aiobotocore error

Whoops I had meant to commit this directly instead of a PR, but I updated tests/requirements.txt to use s3fs>=2021.08.0 to fix the aiobotocore error that was failing the tests. (also mentioned here https://github.com/dask/s3fs/issues/514)


Bump patch number 0.4.3 -> 0.4.4

forgot again!
previous PR #143 fixed a bug from issue #133

Codecov Report

Merging #148 (45111dd) into main (89b3027) will decrease coverage by 0.82%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   48.37%   47.55%   -0.83%
==========================================
  Files          65       64       -1
  Lines        6667     6614      -53
==========================================
- Hits         3225     3145      -80
- Misses       3442     3469      +27

Impacted Files
Coverage Δ

src/Optical/Emitters/Emitters.jl
0.00% <0.00%> (-20.00%)
:arrow_down:

src/Geometry/Primitives/Qtype.jl
75.00% <0.00%> (-8.34%)
:arrow_down:

src/Optical/LensAssembly.jl
48.22% <0.00%> (-7.33%)
:arrow_down:

src/Optical/OpticalInterface.jl
63.23% <0.00%> (-4.30%)
:arrow_down:

src/Geometry/CSG/Intersection.jl
48.57% <0.00%> (-2.14%)
:arrow_down:

src/Geometry/Geometry.jl
0.00% <0.00%> (-1.86%)
:arrow_down:

src/Geometry/Primitives/Curves/BSpline.jl
66.15% <0.00%> (-0.52%)
:arrow_down:

src/Geometry/CSG/Interval.jl
83.20% <0.00%> (-0.37%)
:arrow_down:

src/Geometry/CSG/CSG.jl
84.88% <0.00%> (-0.06%)
:arrow_down:

src/Vis/Vis.jl
100.00% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b3027...45111dd. Read the comment docs.


Media control keys on task bar thumbnail not showing

OS:
Windows 10
GPMDP Version:
4.6.0
Issue Descriptions:
Hello,
After 4.6.0 update, I'm unable to see the thumbnail media control keys (previous, pause, next) when hovering the icon in the taskbar. With version 4.5.0 this works, but the app automatically updates, and I can't find a way to disable updates.
Does anyone know what's going on?
Thank you!!!!

This is fixed in master. Will be published next release.

Thank you for your quick response.
Have a nice day!!!


Stutter/lag if using Bluetooth to stream audio

To get sound while mirroring, I use bluetooth dongle to stream audio from smartphone to laptop.
Without streaming audio via bluetooth the mirrored screen is displayed normally, but if bluetooth used to stream the audio the mirrored display is laggy/stutter.
scrcpy v1.14
Laptop OS: Ubuntu 20.04
Phone: Xiaomi Redmi Note 5 AI
ROM: MiRoom 20.5.14. MIUI 12 based on Android 9.0.
BT dongle: Ugreen USB BT 4.0. aptX capable.

Probably some conflicts on USB? Unfortunately, I'm not sure scrcpy can do anything about that.

I think you're right. I've changed the USB BT dongle with BT receiver and the lag is less noticeable.
Thanx.

I might wasn't clear about this. But the lag happens when scrcpy connected via wifi adb. If the smartphone connected to laptop through USB cable there is no lag.


Why function 'jerry_fatal' just terminate the program instead of doing jerry clean and exits normally?

Calls to jerry_fatal happen when the engine experiences some issues it cannot recover from. In those cases, there is no guarantee that anything can be performed afterwards, not even a proper cleanup, as the internal state of the engine may be compromised.


ERR_MODULE_NOT_FOUND when inlining some modules

Environment

Operating System: Windows_NT
Node Version:     v20.10.0
Nuxt Version:     -
CLI Version:      3.11.1
Nitro Version:    2.9.3
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
https://stackblitz.com/edit/unjs-nitro-starter-mhus1e?file=module%2Fmod.ts,module%2Fruntime%2Fplugin.ts,nitro.config.ts&title=Nitro Starter
Describe the bug
There's currently an issue (again sorry :pray:) with applicationinsights node.
We have a different issue on stackblitz and windows.
On windows we have

while on stackblitz the module is not found.
The only way to fix it seems to be to force the resolution of mlly to 1.4.0.
I think it's probably due the strip comment feature for mlly hasEsmSyntax and hasCjsSyntax is behind an experimental feature flag not enabled by default.
Additional context
The issue with windows is that the absolute paths generated in .nitro/dev/index.mjs are generated without file:// for applicationinsights imports.

After manually adding them back

We have another issue which is the stackblitz one.
Logs
No response

here's the ouput with mlly 1.4.0
import * as ApplicationInsights from<EMAIL_ADDRESS>import ApplicationInsights__default, { DistributedTracingModes } from<EMAIL_ADDRESS>

We probably cannot safely enable stripping comments for mlly until next major version that uses AST-aware stripping.
I know it is a pain for some legacy modules but making changes to CJS/ESM detection that can fixes one legacy module can break other legacy modules.
I am closing this issue because the only common reported case is applicationinsights but if there are more common legacy packages that having issues, i would be happy to see what we can do for Nitro v2 fix.
Made a tracker issue in https://github.com/huang-julien/nitro-applicationinsights/issues/59 for an alternative suggestion.


added px-alert-message-hidden when dismissing/hiding an alert message

added an event when an alert message goes hidden (dismissed)
resolve #7
@runn-vermel @ek @mdwragg

now fixed on safari 8


Setting AWS SDK fails

Bugs:
http://www.springframework.org/schema/cloud/aws/context/spring-cloud-aws-context.xsd
cannot be found now

@xiaoyudeng666 why do you want to access the url at all ? The schema file should never be loaded from the internet as we are using the schmea.handler see https://github.com/spring-cloud/spring-cloud-aws/blob/master/spring-cloud-aws-context/src/main/resources/META-INF/spring.handlers
Please re-open if you think there is really a need for the online schema.


Bin icon not shown in term info

From @Robbie1977 on April 18, 2017 12:18
Delete should be added to term info tools.
Should remove and clear the term info window.
Copied from original issue: VirtualFlyBrain/geppetto-vfb#12

This issue was moved to VirtualFlyBrain/VFB2#81

fixed and tested


Collect VMI OS info from the Guest agent

What this PR does
Before this PR:
No guest agent info was collected and exposed through vmi metrics.
After this PR:
kernelRelease, machine, name and versionId fields from vmi.status.guestOsInfo are collected and added as labels to kubevirt_vmi_phase_count metric.

Fixes # https://issues.redhat.com/browse/CNV-37369
Why we need it and why it was done in this way
We would like to have more visibility regarding VMIs OS, so we can differentiate between running VMs, and alert for specific OS issues (e.g. https://issues.redhat.com/browse/CNV-38482).
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

Collect VMI OS info from the Guest agent as `kubevirt_vmi_phase_count` metric labels

/lgtm

@enp0s3 can you please take a look?

Hey.
Many of our metrics are infrlimited to infra aspects.
This metric change captures my attention, because we start to disclose details about the guest.
This can be potentially security relevant information, thus:

What oter metrics do we have that are exporting guest related informations?
Did we consider to add a cluster level knob to disable all guest related exposure via metrics?

To me metrics stand out (compared to i.e. CR level details), because metrics are designed to be formwared to remote systems, and it's much easier to - unintentionally - leak guest related informations.
/hold
to give us time to answer these questions.

Hey.
Many of our metrics are limited to infra aspects. This metric change captures my attention, because we start to disclose details about the guest.
This can be potentially security relevant information, thus:

What oter metrics do we have that are exporting guest related informations?
Did we consider to add a cluster level knob to disable all guest related exposure via metrics?

To me metrics stand out (compared to i.e. CR level details), because metrics are designed to be formwared to remote systems, and it's much easier to - unintentionally - leak guest related informations.
/hold
to give us time to answer these questions.

@fabiand Hi, I'm not aware of any metrics exposing guest related information yet, thus we didn't consider implementing such knob. Are there specific GuestOSInfo fields exposed by this PR that you find problematic, or is it a general concern?

It's a general concern - by exposing any information about the guest we cross this boundary.
Thus to me this PR should be extended with a cluster level knob in order to turn off all guest related metric reporting.

/unhold
Usually metric system already require authentication, aka not permitting arbitrary users to view metrics.
Filtering can also be applied when metrics are forwarded to an out-of-cluster metrics collection instance.
This should be good enough.

/retest

/retest

/approve

/retest

/cherry-pick release-1.2


Album-image download-progress indicator not updating

See https://i.imgur.com/3QoKxEx.mp4.
I think calling the following line within a DispatchQueue.main.async block should resolve the issue:
https://github.com/ccrama/Slide-iOS/blob/bdb7b6fa88185cc2b3a42aeaf338c1714bb49fb5/Slide for Reddit/ImageMediaViewController.swift#L234
Also, do you think submission cell images ("Full image", "Cropped image", and "Thumbnail only") would benefit from having a download progress indicator? For large images, the app can seem unresponsive because there is no feedback as the image downloads - especially on subs like /r/wallpapers.

Great find, I'll look into this!
I don't think the images should though, too many moving parts and complication of views in my opinion. But if you disagree I would be interested in seeing what an implementation of this could be

Fixed, and @colejd did a pulsing animation while loading. What do you think?

Okay, I just installed the latest version - the last version I had install was from Oct 2.
I like the pulsing animation and find it helpful.


Offline use

Hi. If this is possible, I would like to ask to add the possibility of offline translating (after downloading the packages), especially for all those occasions when data is not working or there is no free Wi-Fi.

I would love to implement this feature, but unfortunately we only access deep learning translations via APIs, so it won't be possible to implement offline translation. There is no "translation package" to download.


User not showing up in the list of organizations depite being whitelisted

Despite being added to the whitelist, I cannot find myself in the registered Github organization. At the very beginning I (mefyl) was listed there, but clicking the page yielded a 500. I supposed this could be some propagation issue and decided to give it some time, but I now disappeared from the list altogether. Did I miss something?

Hi!
Thanks for the report. To fully understand what could happen, do you have any repository where you have installed the ocaml-ci GitHub App?

Just did so, I suppose it will take some time to propagate.

It is available again: https://ci.ocamllabs.io/github/mefyl
There was a mistake on our side where the list wasn't up-to-date, and it's fixed now.
Sorry for the inconvenience, and thanks for having raised the issue :+1:

Awesome, thank you for the quick support!


Hope to get in touch

Dear DemoGPT developer,
Greetings! I am Jimmy, a community developer and volunteer at InternLM. Your work has been immensely beneficial to me, and I believe it can be effectively utilized in InternLM as well. Welcome to add Discord https://discord.gg/gF9ezcmtM3 . I hope to get in touch with you.
Best regards,
Jimmy

Hi @JimmyMa99 , thank you for your invitation.
I've just joined the channel. I'm open to all collaborations.


Add bulb-failure warnings

First PR is adding the warnings API. It will return (in theory) the bulbFailure codes.
I'm however not able to test this. The API returns 200, but gives only basic data.

As this endpoint don't returns valid data, I will not merge this PR. I don't want to have "dead" enpoints in this integration, sorry!

Fair point, let's see in future if it becomes alive. Thanks for the feedback.


Issue When Trying to Replicate the Result

Hi team,
I recently came across your excellent work on Modular LLM and am excited to build upon it.  I found the MBC library you trained at hf://zhan1993/mbc_library_phi2_icml and wanted to give it a try.
However, when running the following command:

python eval_library.py
-k output_dir=an_expert_eval/
library_id=hf://zhan1993/mbc_library_phi2_icml
pipeline_eval_tasks='bbh'
merge_or_route='arrow'

I encountered the following error:

Traceback (most recent call last):
File "/workspace/uyen/test/mttl/projects/modular_llm/eval_library.py", line 369, in
run_eval(args)
File "/workspace/uyen/test/mttl/projects/modular_llm/eval_library.py", line 251, in run_eval
selector_config.selector_data_id = fetch_prototypes(args, library)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/workspace/uyen/test/mttl/projects/modular_llm/eval_library.py", line 120, in fetch_prototypes
add_base_proto=args.add_base_proto,
^^^^^^^^^^^^^^^^^^^
AttributeError: 'EvaluationConfig' object has no attribute 'add_base_proto'`

Could you help me understand what might be causing this error? Is it related to a missing parameter in the configuration or a potential issue with the code or library setup?

hi, sorry this in on our side, could you remove args.add_base_proto? from line 120 in eval_library.py?

Hi, thank you for your response. I tried it, but another issue has come up. It seems like the argument 'add_base_proto' is still being used somewhere else.
Traceback (most recent call last):
  File "/workspace/uyen/test/mttl/projects/modular_llm/eval_library.py", line 368, in <module>
    run_eval(args)
  File "/workspace/uyen/test/mttl/projects/modular_llm/eval_library.py", line 250, in run_eval
    selector_config.selector_data_id = fetch_prototypes(args, library)
                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/uyen/test/mttl/projects/modular_llm/eval_library.py", line 114, in fetch_prototypes
    return compute_arrow_embeddings(
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/uyen/test/mttl/mttl/models/containers/selectors/arrow_selector.py", line 24, in compute_arrow_embeddings
    cfg = ArrowTransformConfig(
          ^^^^^^^^^^^^^^^^^^^^^
TypeError: ArrowTransformConfig.__init__() got an unexpected keyword argument 'add_base_proto'

tracked it down and merged, let me know

Hi, I am sorry for the late response. I am working on it but another issue has come up:
Traceback (most recent call last):
  File "/workspace/uyen/test/mttl/projects/modular_llm/eval_library.py", line 368, in <module>
    run_eval(args)
  File "/workspace/uyen/test/mttl/projects/modular_llm/eval_library.py", line 252, in run_eval
    model = MultiExpertModel.from_pretrained_library(
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/uyen/test/mttl/mttl/models/expert_model.py", line 590, in from_pretrained_library
    model = cls(config, **loading_kwargs)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/uyen/test/mttl/mttl/models/expert_model.py", line 665, in __init__
    super().__init__(config, **loading_kwargs)
  File "/workspace/uyen/test/mttl/mttl/models/base_model.py", line 56, in __init__
    model_loader_helper(
  File "/workspace/uyen/test/mttl/mttl/models/utils.py", line 173, in model_loader_helper
    for n, p in model_object.named_parameters():
                ^^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'model_object' where it is not associated with a value