3.7.1 bars under 100% width will have repeating empty bars next to the working bars that have output

Checklist

[X] I have read the appropriate section in the contributing guidelines
[X] I believe this issue is a problem with polybar itself and not a misconfiguration on my part
[X] I have searched for other open and closed issues that may have already reported this problem
[X] I have checked the known issues page for this problem.
[X] I have followed the debugging guide to narrow down the problem to a minimal config.

Steps to reproduce
Have a bar under 100% width on the far left side of the screen.
Minimal config
;==========================================================
;
;
;   ██████╗  ██████╗ ██╗  ██╗   ██╗██████╗  █████╗ ██████╗
;   ██╔══██╗██╔═══██╗██║  ╚██╗ ██╔╝██╔══██╗██╔══██╗██╔══██╗
;   ██████╔╝██║   ██║██║   ╚████╔╝ ██████╔╝███████║██████╔╝
;   ██╔═══╝ ██║   ██║██║    ╚██╔╝  ██╔══██╗██╔══██║██╔══██╗
;   ██║     ╚██████╔╝███████╗██║   ██████╔╝██║  ██║██║  ██║
;   ╚═╝      ╚═════╝ ╚══════╝╚═╝   ╚═════╝ ╚═╝  ╚═╝╚═╝  ╚═╝
;
;
;   To learn more about how to configure Polybar
;   go to https://github.com/polybar/polybar
;
;   The README contains a lot of information
;
;==========================================================

[colors]
background = #282A2E
background-alt = #373B41
foreground = #C5C8C6
primary = #FF6D10
secondary = #FF6A13
alert = #A54242
disabled = #707880
spotify-black = #91414
spotify-green = #1DB954
transparent-black = #aa000000
blue = #0064ff

[bar/bar1]
	width = 100%
	height = 22pt
	radius = 10
	background = #aa000000
	foreground = ${colors.foreground}
	line-size = 2pt
	border-size = 4pt
	module-margin = 1
	padding-right = 1
	padding-left = 1

	font-0 = monospace;2
	font-1 = Symbols Nerd Font:style=2048-em

	modules-left = xworkspaces xwindow
	modules-right = spotify filesystem pulseaudio memory cpu cpu-temp wlan tray rofi-power-menu
	cursor-click = pointer
	cursor-scroll = ns-resize
	enable-ipc = true
	wm-restack = i3

[bar/vol-bar]
	width = 12%
	height = 20pt
	radius = 10
	background = #aa000000
	foreground = #C5C8C6
	border-size = 2pt
	border-color = #FF6D10
	module-margin = 1

	monitor = DisplayPort-1

	font-0 = Square721 BT:style=Roman
	font-1 = Symbols Nerd Font:style=2048-em

	modules-center = pulseaudio headset-plug-status headset-batt

	cursor-click = pointer
	cursor-scroll = ns-resize
	enable-ipc = true
	wm-restack = i3

[bar/mouse-bar]
	width = 15%
	height = 20pt
	radius = 10
	background = #aa000000
	foreground = #C5C8C6
	border-size = 2pt
	border-color = #0064ff

	module-margin = 1

	monitor = DisplayPort-1

	font-0 = Square721 BT:style=Roman
	font-1 = Symbols Nerd Font:style=2048-em

	modules-center = logi-dpi-dis logi-mouse-batt-per

	cursor-click = pointer
	cursor-scroll = ns-resize

	enable-ipc = true
	wm-restack = i3
	bottom = true

[bar/spotify-bar]
	width = 20%
	height = 20pt
	radius = 10
	offset-x = 15%

	background = #aa013220
	foreground = ${colors.spotify-green}

	border-size = 2pt
	border-color = ${colors.spotify-green}
	padding-left = 0
	padding-right = 0

	font-0 = monospace;2
	font-1 = Symbols Nerd Font:style=2048-em

	modules-center = spotify

	cursor-click = pointer
	cursor-scroll = ns-resize

	enable-ipc = true

	override-redirect = true

	bottom = true

[bar/bottom-bar]
	width = 20%
	height = 20pt
	radius = 10

	background = #aaA54242
	foreground = #C5C8C6

	border-size = 2pt
	border-color = #FF6D10
	module-margin = 1

	font-1 = Square721 BT:style=Roman
	font-0 = Borda,Borda 4:style=Regular 9,Regular
	font-2 = Symbols Nerd Font:style=2048-em

	modules-center = date outside-temp gas-price

	cursor-click = pointer
	cursor-scroll = ns-resize

	enable-ipc = true
	bottom = true

[module/tray]
type = internal/tray
format-margin = 8px
tray-spacing = 8px

[module/headset-batt]
type = custom/script
exec = /home/xt3ns1s/.config/polybar/poly-scripts/headset-batt.sh
internal = 1
format-prefix = " "
label = "%output%"
format-prefix-foreground = ${colors.primary}

[module/headset-plug-status]
type = custom/script
exec = /home/xt3ns1s/.config/polybar/poly-scripts/headsetplugstatus.sh
internal = 1
format-prefix = "󰕓 "
label = "%output%"
format-prefix-foreground = ${colors.primary}

[module/logi-mouse-reports-stream]
type = custom/script
exec = python ~/Documents/mouse-reports-stream.py
internal = 1
format-prefix = "󰍽 "
label = "%output%"
format-prefix-foreground = ${colors.blue}
tail = true

[module/logi-mouse-batt-per]
type = custom/script
exec = /home/xt3ns1s/Documents/logi_mouse_batt_per.sh
internal = 1
format-prefix = "󰁹 "
format-fail = "%output%"
format-prefix-foreground = ${colors.blue}
tail = true

[module/logi-dpi-dis]
type = custom/script
exec = python ~/Documents/logitech_mouse_dpi_notify.py
internal = 1
format-prefix = " "
label = "%output%"
format-prefix-foreground = #0064ff
tail = true

[module/outside-temp]
type = custom/script
exec = python ~/.config/polybar/scripts/weather.py
interval = 5
format-prefix = " "
format-prefix-foreground = ${colors.primary}
label-foreground = ${colors.primary}
label = "%output%"

[module/timer]
type = custom/script
interval = 1
format-prefix = 󱎫
format = <label>
exec = termdown >>
click-left = termdown --no-figlet
format-prefix-foreground = ${colors.primary}
label = "%output%"

[module/rofi-power-menu]
type = custom/text
content = 
content-background = #000
content-foreground = #FF2400
click-left = exec rofi -show power-menu -modi power-menu:rofi-power-menu

[module/gas-price]
type = custom/script
exec = python ~/.config/polybar/poly-scripts/gas.py
interval = 2
format-prefix = "󰊘 "
format-prefix-foreground = ${colors.primary}
label-foreground = ${colors.primary}
label = "%output%"

[module/spotify]
type = custom/script
interval = 1
format-prefix = " "
format = <label>
exec = /home/xt3ns1s/.config/polybar/polybar-spotify/spotify_status.py -f '{play_pause} {song} - {artist}'
format-underline = #1db954
;control players (optional)
click-left = playerctl --player=spotify play-pause
click-right = playerctl --player=spotify next
click-middle = playerctl --player=spotify previous

[module/spotify-scroll]
type = custom/script
tail = true
interval = 1
; prefix symbol is shown before the text
format-prefix = ""
format = <label>
exec = ~/.config/polybar/scripts/scroll_spotify_status.sh

[module/cpu-temp]
type = custom/script
exec = ~/.config/polybar/scripts/cpu-temp.sh
interval = 2
format-prefix = "󰏈 "
format-prefix-foreground = ${colors.primary}
label = "%output%"

[module/info-cava]
type = custom/script
exec = ~/.config/polybar/scripts/info-cava.py -f 24 -b 12 -e fffdfc,fffafe,ffeafa,ffc3d2 -c average
tail = true

[module/xworkspaces]
type = internal/xworkspaces

label-active = %name%
label-active-background = ${colors.background-alt}
label-active-underline= ${colors.primary}
label-active-padding = 1

label-occupied = %name%
label-occupied-padding = 1

label-urgent = %name%
label-urgent-background = ${colors.alert}
label-urgent-padding = 1

label-empty = %name%
label-empty-foreground = ${colors.disabled}
label-empty-padding = 1

[module/xwindow]
type = internal/xwindow
label = %title:0:60:...%

[module/filesystem]
type = internal/fs
interval = 25

mount-0 = /
label-mounted =%{F#FF6D10}󱛟  %{F#C5C8C6}%percentage_used%%
label-unmounted = %mountpoint% not mounted
label-unmounted-foreground = ${colors.disabled}

[module/pulseaudio]
type = internal/pulseaudio

sink = alsa_output.usb-SteelSeries_SteelSeries_Arctis_7-00.stereo-game

format-volume-prefix = "󰋎 "
format-volume-prefix-foreground = ${colors.primary}
format-volume = <label-volume>

label-volume = %percentage%%

label-muted = muted
label-muted-foreground = ${colors.disabled}
click-right = pavucontrol

[module/xkeyboard]
type = internal/xkeyboard
blacklist-0 = num lock

label-layout = %layout%
label-layout-foreground = ${colors.primary}

label-indicator-padding = 2
label-indicator-margin = 1
label-indicator-foreground = ${colors.background}
label-indicator-background = ${colors.secondary}

[module/memory]
type = internal/memory
interval = 2
format-prefix ="󰍛 "
format-prefix-foreground = ${colors.primary}
label = %percentage_used:2%%

[module/cpu]
type = internal/cpu
interval = 2
format-prefix = "󰻠 "
format-prefix-foreground = ${colors.primary}
label = %percentage:2%%

[network-base]
type = internal/network
interval = 5
format-connected = <label-connected>
format-disconnected = <label-disconnected>
label-disconnected = %{F#800000}%ifname%%{F#707880} disconnected

[module/wlan]
inherit = network-base
interface-type = wireless
label-connected = %{F#FF6A13}%ifname% %{F#C5C8C6}%essid% %local_ip%

[module/eth]
inherit = network-base
interface-type = wired
label-connected = %{F#F0C674}%ifname%%{F-} %local_ip%

[module/date]
type = internal/date
interval = 1
date = %Y-%m-%d %a   %I:%M:%S %p
label =  %date%
label-foreground = ${colors.primary}

[settings]
screenchange-reload = true
pseudo-transparency = false

; vim:ft=dosini

Polybar log
# Bright orange bar, bottom left of right screen:
[xt3ns1s@acid-byte ~] $polybar bottom-bar
notice: Parsing config file: /home/xt3ns1s/.config/polybar/config.ini
notice: Listening for IPC messages (PID: 1155065)
notice: Loading module 'date' of type 'internal/date'
notice: Loading module 'outside-temp' of type 'custom/script'
notice: Loading module 'gas-price' of type 'custom/script'
notice: Loaded 3 modules
notice: Loaded font "Borda,Borda 4:style=Regular 9,Regular" (name=Borda, offset=0, file=/home/xt3ns1s/.local/share/fonts/borda.ttf)
notice: Loaded font "Square721 BT:style=Roman" (name=Square721 BT, offset=0, file=/home/xt3ns1s/.local/share/fonts/SQR721N.TTF)
notice: Loaded font "Symbols Nerd Font:style=2048-em" (name=Symbols Nerd Font, offset=0, file=/usr/share/fonts/TTF/SymbolsNerdFont-Regular.ttf)
warn: Dropping unmatched character '宅' (U+fa04) in '26.8 宅'

# Blue bar, bottom left of left screen:
[xt3ns1s@acid-byte ~]$ polybar mouse-bar
notice: Parsing config file: /home/xt3ns1s/.config/polybar/config.ini
notice: Listening for IPC messages (PID: 1214267)
notice: Loading module 'logi-dpi-dis' of type 'custom/script'
notice: Loading module 'logi-mouse-batt-per' of type 'custom/script'
notice: Loaded 2 modules
notice: Loaded font "Square721 BT:style=Roman" (name=Square721 BT, offset=0, file=/home/xt3ns1s/.local/share/fonts/SQR721N.TTF)
notice: Loaded font "Symbols Nerd Font:style=2048-em" (name=Symbols Nerd Font, offset=0, file=/usr/share/fonts/TTF/SymbolsNerdFont-Regular.ttf)
warn: Ignoring restack of i3 window (not needed when `override-redirect = false`)

# Orange bar, top left of left screen:
[xt3ns1s@acid-byte ~]$ polybar vol-bar
notice: Parsing config file: /home/xt3ns1s/.config/polybar/config.ini
notice: Listening for IPC messages (PID: 1366284)
notice: Loading module 'pulseaudio' of type 'internal/pulseaudio'
notice: Loading module 'headset-plug-status' of type 'custom/script'
notice: Loading module 'headset-batt' of type 'custom/script'
notice: Loaded 3 modules
notice: Loaded font "Square721 BT:style=Roman" (name=Square721 BT, offset=0, file=/home/xt3ns1s/.local/share/fonts/SQR721N.TTF)
notice: Loaded font "Symbols Nerd Font:style=2048-em" (name=Symbols Nerd Font, offset=0, file=/usr/share/fonts/TTF/SymbolsNerdFont-Regular.ttf)
warn: Ignoring restack of i3 window (not needed when `override-redirect = false`)

Expected behavior
I want the bars under 100% width to only display once with output and to have no extra bars next to them. Only my desktop should be visible in the space that the empty bars are occupying. This screenshot is with polybar 3.6.3

Actual behavior
My under 100% width bars have empty bars repeating next to the bars that have output.
This screenshot is with 3.7.1

Window Manager and Version
i3 version 4.23
Linux Distribution
Linux 6.6.3-arch1-1
Polybar version
polybar 3.7.1

Features: +alsa +curl +i3 +mpd +network(libnl) +pulseaudio +xkeyboard

X extensions: +randr (+monitors) +composite +xkb +xrm +xcursor

Build type: Release
Compiler: /usr/bin/c++
Compiler flags: -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -g -ffile-prefix-map=/build/polybar/src=/usr/src/debug/polybar -flto=auto -O3 -DNDEBUG -Wall -Wextra -Wpedantic -Wdeprecated-copy-dtor -Wsuggest-override
Linker flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -flto=auto -Wall -Wextra -Wpedantic -Wdeprecated-copy-dtor -Wsuggest-override  -Wall -Wextra -Wpedantic -Wdeprecated-copy-dtor -Wsuggest-override

Additional Context / Screenshots
No response

Clarifying question: Are you using a compositor in these screenshots?
I have narrowed it down to d743a228173e50b6dc98293e6db05eca962d334c triggering this issue.
The problem is that we just don't interact too well with i3. i3 doesn't actually let you have non-full-width bars, when putting the window on screen it tells polybar that it has the full screen width (instead of the requested width), polybar just ignores that info.
The rendering changes in that commit normally wouldn't have an effect, but because polybar treats its window smaller than it is. The contents of the first rendering get duplicated to fill out the remainder of the window.

I reverted the rendering change in #3091. Please try it out to see if it fixes your issue (it did work for me)

Hey, sorry to respond so late to this but yes I was using a compositor (picom) when I had this issue happen to me. I'll update polybar when I get a chance and I'll let you know if it resolved my issue.

im getting the same behavior under 3.7.1. Setting the override-redirect option to true renders the widths correctly, however setting it to false creates the repeating bars, unfortunately with override-redirect set to true, i3 covers the bar.


log2022: checkpoint, time to test

write new logging code (similar to old CXS but for all files)
remove imports to old logging code (especially forge/logging/sigs)
create DB and cloud function ... I hope!

Need to test that all these can make and post logs on success AND on failure:

[x] forge
[x] forge/bsl
[x] forge/core
[x] CXS

Latest CI failure is all about forge/core:

Need to allow require; can't wrap the whole body in a parameterize
The parameterize has to end with (void) ... or just clobber the error handler!
Need exports from logging sigs


Send an email inside a Edge function

Hi,
I can send an email using SMTP in Typescript.
import { SMTPClient } from "https://deno.land/x/denomailer/mod.ts";
....
  const smtp = new SMTPClient({
    connection: {
      hostname: Deno.env.get('_SMTP_HOSTNAME')!,
      port: Number(Deno.env.get('_SMTP_PORT')!),
      tls: true,
      auth: {
        username: Deno.env.get('_SMTP_USERNAME')!,
        password: Deno.env.get('_SMTP_PASSWORD')!,
      },
    },
  });
...
await smtp.send({ ....})

However I would prefer to use Dart on the Edge functions.
I tried to use the mailer library but it doesn't work. issue
What is the best way to achieve this?
I can't seem to find a solution in the web, which is weird because I thought it would be a usual feature.
Am I overlooking something?
Thank you for any tips

Use something like mailgun or another actual SMTP API. Using cloud function ips for email sending is a good way to get flagged as spam. Probably many other reasons not to do this with a serverless function too.

Hi Machael,
But the question is why is it possible in Typescript but there is no alternative in Dart?
After all, Dart is converted to JS as well. I can't figure out a reason for it. You are saying that it is bad practice to use in Typescript also, is that it?
Thank you for your time.

Yes, bad practice in both. If supabase hasn't blocked, they probably will at some point. As far as being possible in JS vs Dart, it's all about the libraries. JS/Typescript typically has more than dart, but dart is catching up.

Use something like mailgun or another actual SMTP API. Using cloud function ips for email sending is a good way to get flagged as spam. Probably many other reasons not to do this with a serverless function too.

@nuno84 Maybe we should accept this as the proper solution...


Inconsistent format in ZMQ publishing for mempool and blocks

A user pointed out that slp.outputs uses type of string in block notification and $numberDecimal in mempool notification.
Conversation:
in the "block" message the outputs are similar to this format:
    "outputs": [{
      "address": "slptest:xxx",
      "amount": "1000000"
    }]

while in the "mempool" message the format is:
  "outputs": [{
    "address": "slptest:xxx",
    "amount": {
      "$numberDecimal": "1000000"
    }
  }]

i.e: the "amount" is number (as string) in the first one, while it's an object with a property named "$numberDecimal" in the second one

This is fixed in v1


[SPARK-23464][MESOS] Fix mesos cluster scheduler options double-escaping

What changes were proposed in this pull request?
Don't enclose --conf option value with "", as they are already escaped by shellEscape
and additional wrapping cancels out this escaping, making the driver fail to start.
This reverts commit 9b377aa49f14af31f54164378d60e0fdea2142e5 [SPARK-18114].
How was this patch tested?
Manual test with driver command logging added.
Author: Marcin Kurczych<EMAIL_ADDRESS>

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Thanks for the PR! It seems that the previous attempt to fix this (SPARK-18114) was wrong -- I'm not sure why we didn't catch the problem before, maybe lack of testing? @krcz My suggestion for this patch is to add a test, in order to prevent another regression in the future. I've written a unit test for this -- you could do something similar:  https://github.com/mesosphere/spark/commit/4812ba3d10264f6d22ec654fa16b5810d70c27a9 I will also do more testing with my own integration tests. cc @skonto

@susanxhuynh Thanks for the example! I have added similar test, covering more cases. After you or someone else reviews it, I'll rebase the pull request.

Can one of the admins verify this patch?

@susanxhuynh I tested this. Here is what you get:
./bin/spark-submit --deploy-mode cluster --name test --master mesos://spark.marathon.mesos:13830 --driver-cores 1.0 --driver-memory 1000M --class org.apache.spark.examples.SparkPi --conf spark.executor.extraJavaOptions="-Dparam1=\"value 1\" -Dparam2=value\\ 2 -Dpath=\$PATH" --conf spark.mesos.containerizer=mesos  --conf spark.mesos.executor.docker.image=skonto/spark-test:test https://...jar 10000

At the driver side in DC/OS:
/usr/lib/jvm/jre1.8.0_152/bin/java -cp /opt/spark/dist/conf/:/opt/spark/dist/jars/*:/etc/hadoop/ -Dspark.mesos.driver.frameworkId=bddf96ce-45f6-45f7-ac83-5a3622cafc41-0030-driver-20180612154509-0007 -Xmx1000M org.apache.spark.deploy.SparkSubmit --master mesos://zk://master.mesos:2181/mesos --conf spark.driver.memory=1000M --conf spark.driver.cores=1.0 --conf spark.mesos.executor.docker.image=skonto/spark-test:test --conf spark.app.name=test --conf spark.mesos.containerizer=mesos --conf spark.executor.extraJavaOptions=-Dparam1="value 1" -Dparam2=value\ 2 -Dpath=$PATH --conf spark.driver.supervise=false --class org.apache.spark.examples.SparkPi --name test --driver-cores 1.0 /mnt/mesos/sandbox/....jar 10000

@skonto
The command you have pasted as "At the driver side in DC/OS:" concerns me. It doesn't seem escaped properly.  Is it the command to be run by shell or is it just space-joined arguments list (as in Spark Dispatcher web UI), which would explain why it is not escaped?

@krcz which one? Btw both job run successfully although might not have been escaped properly.

@skonto The one directly below  "At the driver side in DC/OS:" in your comment. But if it's output of ps that's ok, as ps wouldn't be able to discern between command "foo bar" and command foo bar.

@krcz yes it should be ok. So I verified it:
Dispatcher passes the following command to mesos:

spark-class will run this at the executor side:
exec /usr/lib/jvm/jre1.8.0_152/bin/java -cp '/opt/spark/dist/conf/:/opt/spark/dist/jars/*:/etc/hadoop/' '-Dexecutor.test.param1=value 1' '-Dexecutor.test.param2=value 2' '-Dexecutor.test.path=$PATH' -Xmx1024m org.apache.spark.executor.CoarseGrainedExecutorBackend --driver-url spark://CoarseGrainedScheduler@ip-10-0-0-77.us-west-1.compute.internal:33887 --executor-id 9 --hostname <IP_ADDRESS> --cores 3 --app-id bddf96ce-45f6-45f7-ac83-5a3622cafc41-0032-driver-20180613103044-0001

ok, could you rebase this PR

ok to test

@mgummelt too

Test build #91820 has started for PR 20641 at commit 22c6739.

Test build #91820 has finished for PR 20641 at commit 22c6739.

This patch fails due to an unknown error code, -9.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91820/
Test FAILed.

@felixb @skonto
I've triend rebasing, but it looks that the issue has been meanwhile fixed independently in other pull request  while someone was working on SPARK-23941 issue. It looks that there is no unit test there though, so I can modify his PR to incorporate just the test. Do you want that or should I just close the pull request?

@krcz
@felixcheung <- different felix ;)

@krcz how is your PR different from 21014?

@felixcheung It fixes the same problem so in terms of implementation it is not very different. But when I created this one 21014 didn't exist.
The only difference is that this PR adds an unit test, which 21014 had not. That's why I'm asking if I should modify this PR to just add the test.

yap, that sounds like a good idea

Can one of the admins verify this patch?

I'm closing this since there's been no activity. If you plan on adding the test, update your branch, and tag this with the other bug number (I duped this one to the bug with the fix attached to it).


Poll heard through TX when WSJT or JTDX

Hi,
I noticed the poll intervall ticks are heard through the TX. And only when using JTDX and WSJT for instance.
If I just use manual PTT during voice, it is not heard.
Rgds,
Johan

Johan,
OmniRig does not work with the audio system. The ticks you hear is a hardware problem, interaction between the COM and audio cables. To fix this, eliminate the pin 1 problem, break the ground loops, use shielded cables - google for the detailed instructions.


[I, J] Add meta-ros doc

https://github.com/bmwcarit/meta-ros/issues/357#issuecomment-143976855
@bulwahn

hydro is e.o.l-ed, please remove.

Done.
(I was going to ask "even only the document update isn't allowed?" but looks like test failed maybe for Hydro.)

not sure if it's allowed. But you forgot : after meta-ros

But you forgot : after meta-ros

Sorry, now corrected.


Dub repository is out-of-date

https://code.dlang.org/packages/pyd
For some reason dub is only aware of the 0.9.x series of releases. Those releases lack compatability with python 3.6, which I think is the default on Ubuntu 18.4. (That release of Ubuntu doesn't have packages for python 3.5) Is there a way to get code.dlang.org to refresh its cache of available versions?
A temporary workaround is to specify ~master as the version to use.

https://github.com/dlang/dub-registry/issues/269

@ariovistus have you tried logging in to code.dlang.org and triggering a manual update?

yup, that was it

code.dlang.org is up to date


domCache needs a maximum

This is a (multiple allowed):

[ ] bug
[x] enhancement
[ ] feature-discussion (RFC)
Framework7 Version: 1.4.2
Platform and Target: Cordova iOS

When enabling domCache: true, it would be nice to have a way to limit the number of pages that get cached. Something like domCacheMax: 5 to limit the max cached pages to 5. I like using domCache because it preserves the exact page state when a user hits back, but there needs to be a way to limit this so it does not get out of hand.
I added a hack in a plugin that does this for myself (I'm using jquery).
if (view.params.domCache && view.params.domCacheMax && view.history.length > view.params.domCacheMax) {
                    var removed = view.history.splice(1, 1);
                    var $page = $(view.pagesContainer).children('.page[data-page="' + removed[0] + '"]:first');

                    if (view.initialPages.indexOf($page[0]) == -1) {
                         app.pageRemoveCallback(view, $page[0], 'left');
                         $page.remove();
                     }
}

@nolimits4web what do you think?

@ZanderBrown I think it can be useful, will add it to roadmap

@emilynewsom, where did you put this hack of yours? what specific file

@nolimits4web is this applied in v3 already?

@pluckannfeel I created a plugin framework7 plugin that does a lot of hacking but i've stripped out the other stuff. Something like below. This is from 1.4.x unfortunately, I haven't done much work with f7 lately:
(function(root) {
    Framework7.prototype.plugins.pages = function(app, params) {
        return {
            hooks: {
                appInit: function() {
                    var originalLoad = app.router.load;

                    app.router.load = function(view, options) {
                        var url = options.url;

                        if (!url || view.url === url) {
                            return originalLoad(view, options);
                        }

                        if (view.params.domCache && view.params.domCacheMax && view.history.length > view.params.domCacheMax) {
                            // skip home
                            var index = 1;

                            view.history.splice(index, 1);
                            var $existing = $(view.pagesContainer).children('.page:eq(' + index + ')');

                            if ($existing.length != 0) {
                                framework7.pageRemoveCallback(view, $existing[0], '');
                                $existing.remove();
                            }
                        }

                        return originalLoad(view, options);
                    };
                }
            }
        }
    };
})(this);

Im using v2, is this applicable?


Pie chart start angle

I want pie chart plotting to be started from 90 degree for that i used below code.
Live:PieSlice RotationAngle="90"
is it the right way to use. It is not working for me. Kindly guide me to change the starting degree

No, this is the variable that handles starting angle in a pie series https://github.com/beto-rodriguez/Live-Charts/blob/master/Charts/Series/PieSeries.cs#L64 this is not supported right now, as you can see it always starts from the same value. I will improve this as soon as possible.

Thanks alot for ur kind reply .

is it possible to override plot method in pieSeries and change the angle? or can you suggest some other solution to make it possible?

I will add this feature in next release, Right now I am working improving zoom and high perfomance charts, for now you can use Rotate all the control with RotateTranform here is a good example http://www.c-sharpcorner.com/uploadfile/mahesh/rotatetransform-in-wpf/

you can also override the Plot method meanwhile, but I think its much easier to rotate all the control

while overriding im not able to access PlotArea ,DataMouseEnter ..how to access those . thank in advance

You cant because it is internal use Control.ActualHeight and ActualWidth instead, or even better modify it in the same assembly so you can do a pull request and share your code with us :)

you cant access DataMouseEnter  but you can override the event

i copied the enitre code and tried to use. but i m getting so many error. I guess i did something wrong. kindly guide me. How can i edit ur code and create assembly . thanks in advance

Fork this repo, actually you already did.

Connect your visual studio to your Fork source and edit directly this file, here you can access PlotArea and DataMouseEnter https://github.com/beto-rodriguez/Live-Charts/blob/master/Charts/Series/PieSeries.cs

After you have debugged your code, and you are really sure everything is working fine, do a pull request.

It is actually really simple and that is why gits are amazing.

Another alternative is to wait for me to add it, Don´t worry I will in 0.6.4 I am already working on it maybe tomorrow is ready

thanks alot for adding in ur release  ...  :) .. i ll also try from my side

while debugging i'm always getting \bin\Debug\LiveCharts.dll missing alert . Kindly help me to fix this

sorry... Now i am able to compile :)  :+1:

This is already supported with the new property for PieChart class PieRotation, follow this link for an example
https://github.com/beto-rodriguez/Live-Charts/tree/master/WPFExamples/Pie Examples/Custom
P.S. it will be available when I publis 0.6.4 it is almost ready

i tried the below code for binding colors in pie chart..but chart is always coming with default color.It is working fine with static colors
xmal:
<LiveCharts:PieSeries Title="Donut1" Values="{Binding ViewModel.FirstSeries}"
Brushes="{Binding ViewModel.ColorSeries}">
cs:
ViewModel = new BindingPieViewModel
{
ColorSeries = new ChartValues{color1,color2 }
};


close/stop client sockets when stopping the process

@portertech: "bewm", as they say. :boom:

Travis is under maintenance until 12.

I see, thanks, didn't realize you had your own fork. I'll try to port the patch over later. Upstream event-machine seems somewhat dead.


Games won't start.

The problem is when you link your game executable to WInLaunch, most of them won't start. But in every case it is the same thing: app will go fullscreen like it's launching normally, then the screen is dimming itself randomly then it crashes or it hangs on that screen forever. Of course outside WL it is working fine.

can you give an example of a game that wont work?


Please provide your suggestions for new gateway support!

We have updated the most widely used crypto gateways including:

Binance
OKX
Bybit

After completing the crypto strategy module, we will continue developing new gateways.
Please let us know if you have any suggestions, especially the reason for you to trade on this specific exchange.

please add get order book on all gateways if possible. Think that might be good for market maker strategies


chore: bdd-spring-1577972499 to 0.0.1

chore: Promote bdd-spring-1577972499 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Complete basic sync tests

Asana: #36085818904536
https://app.asana.com/0/36084070893405/36085818904536

Looks good :)


How to get component data object..?

I want to get the component's data when the 'vue-stepper' stepper-finised event is called.

In your case:

Update your root .vue component - add new array in data (after Steps).
myData: {
step1: null,
step2: null
}
And add in
Then you need to update node_modules/vue-stepper/src/HorizontalStepper.vue - add myData in props.
Update your steps components - add myData in props
And in each component add watch like this:
'form.username': function (val, oldval) {
this.myData.step1 = val
}

Sorry my english, i hope this will be useful =)

Thank's for your answer.
but,
I think I don't like update your HorizontalStepper... :(
so, i'm touched $children using ref(horizontal-stepper)
i don't like either...

got error  Error in callback for watcher "form.username": "TypeError: Cannot set property 'step1' of undefined"


Reviewdog throws 'input data has violations' when the fail-on-error flag is used

Whenever I add the -fail-on-error flag combined with the -filter-mode flag, I receive the reviewdog: input data has violations warning.
When does this happen
This happens only when warnings or errors are present. In this case, it also throws an exit 1 exit code (see test reports below). This is fine given the documentation. The problem is that the exit code, however, also is thrown when only warnings are present. I, therefore, suspect something else is going wrong. Interestingly, this error only occurs for the local and github-pr-review reporters and not for the github-check reporter (I did not check the other reporters). Maybe this bug has to do with the fact that this combination is not yet supported(see the documentation)?
What I already tried

I tried using a different linter/formatter (black) for example but the issue also occurs.
I tried changing adding double quotes to my reviewdog input arguments.
I tried different -fail-on-error flag syntaxes (-fail-on-error="true" and -fail_on_error=true).
I tried different report levels (info, warning and error).

How to reproduce

Clone the example repository I created for this bug.
Follow the steps in the readme.
See the problems appear.

flake8 lint warnings test report
Let's test what happens when we enable -fail-on-error while the code vase contains linter warnings.
🧪 thttps://github.com/rickstaa/action-test-repo/pull/54
Flake8 lint warning+errors test report
Let's test what happens when we enable -fail-on-error while the code vase contains linter warnings and errors.
🧪 https://github.com/rickstaa/action-test-repo/pull/55

It's actually working as intended. With -fail-on-error, it fails when reviewdog finds any results from linters regardless of the diagnostic level (error/warning/info).
Though I agree that it's confusing and -fail-on-error is not well-designed.

It's actually working as intended. With -fail-on-error, it fails when reviewdog finds any results from linters regardless of the diagnostic level (error/warning/info).
Though I agree that it's confusing and -fail-on-error is not well-designed.

@haya14busa Okay that is good to know. In that case we might need to change the documentation a bit from:
``diff

If -fail-on-error flag is passed, reviewdog exits with 1 when at least one error/warning was found/reported.

If -fail-on-error flag is passed, reviewdog exits with 1 when at least one error/warning was found/reported.

Or we need to redesign the behavoir of the flag:

1. Let it only fail on errors (Bad for back-compatibility).
2. Let people define on which reviewdog should fail `-fail-level="warning"`. Keep the default on both warnings and errors.
3. Add a -fail-on-warning flag and let the -fail-on-error flag only fail on errors (Bad for back-compatibility).

@haya14busa Okay that is good to know. In that case we might need to change the documentation a bit from:
``diff

If -fail-on-error flag is passed, reviewdog exits with 1 when at least one error/warning was found/reported.

If -fail-on-error flag is passed, reviewdog exits with 1 when at least one error/warning was found/reported.

Or we need to redesign the behavoir of the flag:

1. Let it only fail on errors (Bad for back-compatibility).
2. Let people define on which reviewdog should fail `-fail-level="warning"`. Keep the default on both warnings and errors.
3. Add a -fail-on-warning flag and let the -fail-on-error flag only fail on errors (Bad for back-compatibility).

As for the document, reviewdog still fails with info or diagnostics without any level, so it's still incorrect.
Option 2 looks good and similar to what I imagined, but the detailed design should be discussed more including exit-code handling in general.

As for the document, reviewdog still fails with info or diagnostics without any level, so it's still incorrect.
Option 2 looks good and similar to what I imagined, but the detailed design should be discussed more including exit-code handling in general.

@haya14busa Ah I see I didn't use it with linters that encountered the info or diagnostics tag. Let's go for option 2 then. I will draft a design note, containing the exit-code handling, for you to review when I find time to work on the feature.

@haya14busa Ah I see I didn't use it with linters that encountered the info or diagnostics tag. Let's go for option 2 then. I will draft a design note, containing the exit-code handling, for you to review when I find time to work on the feature.

@haya14busa I quickly went through the codebase and I currently do not have the resources to work on this myself. I created a seperate feature request on 856 might other people want to implement the feature.

@haya14busa I quickly went through the codebase and I currently do not have the resources to work on this myself. I created a seperate feature request on 856 might other people want to implement the feature.


Convert de.zalando.zally.apireview to Kotlin

Converted de.zalando.zally.apireview to Kotlin via Intellij Idea
Applied Kotlin idioms
Completes the transition to pure Kotlin codebase

Closes #712

Codecov Report

Merging #811 into master will increase coverage by 0.74%.
The diff coverage is 75.48%.

@@             Coverage Diff             @@
##             master    #811      +/-   ##
===========================================
+ Coverage     84.65%   85.4%   +0.74%
+ Complexity      928     909      -19
===========================================
  Files           171     170       -1
  Lines          2627    2570      -57
  Branches        397     400       +3
===========================================
- Hits           2224    2195      -29
+ Misses          198     157      -41
- Partials        205     218      +13

Impacted Files
Coverage Δ
Complexity Δ

...de/zalando/zally/apireview/ServerMessageService.kt
100% <100%> (ø)
6 <6> (?)

...ain/java/de/zalando/zally/dto/ViolationsCounter.kt
100% <100%> (ø)
5 <4> (+2)
:arrow_up:

...n/java/de/zalando/zally/apireview/OpenApiHelper.kt
46.66% <46.66%> (ø)
8 <8> (?)

...ava/de/zalando/zally/statistic/ReviewStatistics.kt
92.3% <50%> (-2.57%)
31 <0> (ø)

...ando/zally/statistic/ReviewStatisticsController.kt
85% <57.14%> (-15%)
13 <3> (+3)

.../main/java/de/zalando/zally/apireview/ApiReview.kt
61.53% <61.53%> (ø)
8 <8> (?)

...n/java/de/zalando/zally/apireview/RuleViolation.kt
80% <80%> (ø)
5 <5> (?)

...java/de/zalando/zally/apireview/EndpointCounter.kt
83.33% <83.33%> (ø)
3 <3> (?)

...zalando/zally/apireview/ApiViolationsController.kt
88.23% <88.23%> (ø)
8 <8> (?)

.../de/zalando/zally/apireview/ApiDefinitionReader.kt
88.23% <88.23%> (ø)
6 <6> (?)

... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5055cc...4f963e2. Read the comment docs.

Any chance of review today? Would be great to avoid the branches getting stale while I disappear for a week!
@ddufourboivin-zalando, @maxim-tschumak, @netme and @tkrop

:+1:

👍

@roxspring : The build is failing because of ktlint violations.
Please run ./gradlew clean ktlint locally and fix them.
Before committing (or opening a PR), make sure you run all checks (tests, linting, etc...) by running ./gradlew clean check.

:+1:


[BUG] Total Monthly Goals does not account for Loans

Total monthly Goals do not match underfunded amount if you change your goal from "needed for spending" to "Debt Payment Target"
To Reproduce
Change monthly spending goal of any goal to a debt payment target, and Total Monthly Goals subtract that from your total amount to budget for.
Expected behavior
Total monthly spending should account for all of your monthly expenses regardless of what type of goal it's set for. Otherwise, it will be too easy to accidentally stretch yourself too thin.
Screenshots

After reviewing your bug report, I believe this is normal behavior as dictated by the YNAB team. For further course of action, I suggest opening a support ticket through the app to report this to the proper channels. Closing this, as we here at the toolkit team have no control over this.

I closed this error, apologies. Will take a closer look.

@cdeluna43 Can you paste a copy of your settings export here?

I noticed the same issue (my Total Monthly Goals is not including my Mortgage (Loan Payment)), so it led me here.  Would it be helpful to have my settings?  If so, let me know how to do that and I'll help.

@carrjar @cdeluna43 Can either of you confirm this is still an issue with v3.2.1?

My loan spending goal IS included in the Total Monthly goals in v3.2.1
Thank you!


Modified Submit button in Contact page

I created changes in contact us.
Detailed Description.....

Modified submit button with hover effect and icon
Created separate css file for Contact us page
css file name contact.css

Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


conan.io C++ packages need to be recognized as registry

https://github.com/NLeSC/awesome-research-software-registries lists https://conan.io for C++, but howfairis does not recognize projects that are available through Conan.
The solution seems to be a simple
--- a/howfairis/mixins/registry_mixin.py
+++ b/howfairis/mixins/registry_mixin.py
@@ -14,6 +14,7 @@ class RegistryMixin:
             results = [
                 self.has_ascl_badge(),
                 self.has_bintray_badge(),
+                self.has_conan_badge(),
                 self.has_conda_badge(),
                 self.has_cran_badge(),
                 self.has_crates_badge(),
@@ -43,6 +44,11 @@ class RegistryMixin:
                    r"https://img\.shields\.io/bintray/.*"]
         return self._eval_regexes(regexes)

+    def has_conan_badge(self):
+        """ """
+        regexes = [r"https://img\.shields\.io/conan/.*"]
+        return self._eval_regexes(regexes)
+
     def has_conda_badge(self):
         """ """
         regexes = [r"https://anaconda\.org/.*/.*/badges/downloads\.svg",

While recognizing conan badges is simple, fixing the tests to not fail after the change is way more complex. I could use some help there. I tried to adjust the expected snippets and add a test_has_conan_badge function to test_checker_.... But now pytest errors out with 'UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc5 in position 18: invalid continuation byte' all over the place. Even after switching back to the 'main' branch with a clean 'git status'. I'm no Python expert... how do I reset this thing without starting over completely?

Oh, the tests pick up vim's .*.swp files (binary) and try to interpret them as utf-8. Not helpful.

OK, managed to adjust the tests. IMHO, adjusting tests for a new badge is way too complex.
May I open a PR?

Hi @mattkretz, thanks for reporting this. Let me ping @fdiblen and @c-martinez for you, they might be able to tell you how best to go about this.

Hi,
Thanks @jspaaks for pinging us!
@mattkretz, I briefly discussed this with @fdiblen. Yes, a PR would be very welcome! Could you please tag me in the PR, to make sure it gets reviewed without too much delay?
You are right, maybe we could improve/simplify how we are testing the badges, but I am not sure if/when we would be able to implement that.

Addressed by #369 -- thanks @mattkretz and @fdiblen !


Bugfix - Editions

Description
Reworked editions logic based on the feedback from the demo. Just test and see.
closes #480 #490 #504
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

What needs to be tested
After migrating and seeding, as an event organizer:

[x] Try acessing any other moderator route, such as: /schedule and verify that it redirects to moderator/editions if there is no active edition.
[x] Try the same with other roles (e.g. participant can't access any mod routes). Basically double check if all the routes are protected.
[x] Verify that there is a badge next to Editions in sidemenu.
[x] Click on the edition.
[x] Set dates of both edition and events and verify that you can't make an edition "during the year Jesus was born". Try to break date inputs as much as possible.
[x] Activate the edition.
[x] Add/Edit keynote speaker on the show page of the edition.
[x] Verify that you can access other moderator routes once the edition is activated.
[x] Create new edition.
[x] Delete edition.

Checklist:

[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Frontend wise: I think it could be clearer that these are clickable


Transition from Miro to Mural

User Story:
As a team member, I want to seamlessly transition from using Miro to Mural for our collaborative work, so that we can continue our visual collaboration without disruption and take advantage of Mural's features
Acceptance Criteria

Data Migration:

[ ] All existing Miro boards are successfully imported into Mural
[ ] Board content (text, images, sticky notes, shapes) is accurately preserved
[ ] Board structure and layout closely resemble the original Miro boards

User Access:

[ ] All team members have active Mural accounts - will need to review this
[ ] Users' access levels and permissions are correctly transferred or reassigned

Training:

[ ] At least one training session is conducted to familiarize users with Mural's interface and features

Data Retention:

[ ] A backup of all Miro boards is created and securely stored before the migration
[ ] Access to Miro is maintained for a specified period post-migration for reference or in case of migration issues

Sam to get access from 77000 and then we would find a way around that

I now have access to the zelda email and I have emailed David requesting for our mural licence.
I will keep us updated.

Mural access granted

I will try to replicate most of the content on miro on mural manually and I will start tomorrow


drivers: serial: nrf uarte: avoid dropping RX chars/overruns

In some cases (eg at high baud rate, no HW flow control, and when BLE
radio/ints running) data could be lost between when enough characters
have been RX'd to fill the DMA buffer and when the ENDRX event was fired,
where the the STARTRX task is invoked to start filling the next buffer
(which is set up earlier, but I think will not be filled until STARTRX).
To fix this, the SHORT is enabled between ENDRX and STARTRX whenever the
'next' buffer is available, so that STARTRX is invoked automatically and
subsequent chars go into the next buffer via EasyDMA.
To make this work properly, uarte_nrfx_isr_async() now handles the ENDRX
event before the STARTRX event.
There was also an issue in rx_timeout() where the received character
count (rx_total_byte_count) could be incremented greater than the actual
buffer size. This arises from rx_total_byte_count value coming from the
counting the RXDRDY events (either by PPI/timer counter or counting the
RXDRDY ints themselves) and so if chars are received in the rx_timeout()
(or before ENDRX is handled) the rx_timeout() could increment rx_offset
past the length of the buffer. This could result the remaining 'len' being
calculated incorrectly (an underflow due to unsigned - signed , where
signed > unsigned).
To fix this, we now store the lengths of the buffers and don't invoke the
UART_RX_RDY callback when the buffers are full; its handled by ENDRX.
(Also note that the buffer size should be available via the RXD.MAXCNT
register on the nrf, but this register is not exposed through the nrfx HAL
and is also double buffered, so it seemed clearer to just track the buffer
lengths explicitly here in the driver).
Signed-off-by: Marc Reilly<EMAIL_ADDRESS>

Hi, you can check the CODEOWNER file and see whom files you edited belong to, then add them as reviwers manually or @their names.

Hi Song,
On Thursday, 9 April 2020 12:06:29 PM AEST Song Qiang wrote:

Hi, you can check the CODEOWNER file and see whom files you edited belong
to, then add them as reviwers manually or @their names.

Thanks, but in this case there is no matching entry for /drivers/serial/
uart_nrfx_uarte.c
Cheers
Marc

Actually the owner of the driver folder , the uart driver folder and maintainer of nrf socs all can review this, especially the latter two.

When this is ready, I would ask that this is back-ported to 1.14.x, thanks!

Both @anangl and @Mierunski need to look at this before we merge.
Regarding the backport, I will add a label, but someone needs to send the PR

#24245 covers backport to 1.14.x


Add since-annotation for hashUsing

I'm curious, do you have a use for hashable older than <IP_ADDRESS>?


Refactoring Edge configuration module.

Description
Refactoring config/config.go to hopefully make it easier to test it.
Fixes # (issue)
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I run make pre-commit to check fmt/vet/lint/test-no-fdo

Codecov Report
Base: 45.00% // Head: 46.05% // Increases project coverage by +1.04% :tada:

Coverage data is based on head (b73686d) compared to base (5cba859).
Patch coverage: 27.02% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1756      +/-   ##
==========================================
+ Coverage   45.00%   46.05%   +1.04%
==========================================
  Files          70       70
  Lines        9798     9805       +7
==========================================
+ Hits         4410     4516     +106
+ Misses       4955     4845     -110
- Partials      433      444      +11

Impacted Files
Coverage Δ

config/config.go
43.25% <27.02%> (+40.80%)
:arrow_up:

pkg/services/devices.go
50.43% <0.00%> (+0.32%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

retest

/retest

/retest

/retest

/retest

/retest

/retest

remove do not merge as automation is ok now


Support multiple paths in fds add

Same syntax is expected as in git add:
fds add path1 path2 path3
Right now, only 1 path argument is supported.

Can I work on it?


CAN documentation points to old sample locations

Describe the bug
The CAN samples were renamed but a couple of entries in the CAN documentation was missed.
To Reproduce
Steps to reproduce the behavior:

boards/shields/mcp2515/doc/index.rst refers to the old samples/drivers/can sample.
samples/subsys/canbus/isotp/README.rst refers to refers to the old samples/drivers/can sample.

Expected behavior
Documentation should point to the correct samples.

This was fixes in main in #51615. Backport for v3.2 in #51695.


Refactor manifests processing.

This PR:

Removed all manifests that are not used now, we will add them incrementally.
Added a yaml config where we can list supported providers and read it for installing them.
Added operator-components.yaml as temporary storage before we get upstream repo setup.
Most important, refactor manifests processing. With this change, we can have a consistent way for all providers to import their manifests to openshift. The import-assets binary reads assets from github, replaces cert-manager with service-ca, places CRDs and RBAC in manifests directory, all other manifests will be placed in assets to be managed by upstream CAPI operator.

/approve

thanks for the answer @alexander-demichev , one other question, does the readme need updating (or add a readme to the import-assets dir) for the new changes?

@elmiko I plan to add a readme once we test this on a provider we own, to be sure that this approach actually work and everyone is happy with it.

/lgtm

@elmiko I plan to add a readme once we test this on a provider we own, to be sure that this approach actually works and everyone is happy with it.

that sounds great, thanks @alexander-demichev
/lgtm

/hold There are legitimate issues within the tests that will need further investigation
https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_cluster-capi-operator/23/pull-ci-openshift-cluster-capi-operator-main-e2e-aws-capi-techpreview/1471745630392029184

/retest

/unhold

/lgtm


The installed extensions need to be grouped

Issue Type: Feature Request
Source translation software:
Multiple voice plugins can cause conflicts, and I want to disable other extensions in a single voice development environment.At present, you can only click one by one. Can you add the grouping function and perform batch operation on the expansion of the grouping?
多个语音的插件可能会造成冲突，我想在单个语音的开发环境禁用其他的扩展。目前只能一个一个的点击，是否能添加分组功能，对分组的扩展进行批量操作？
哪位好心人帮忙看看翻译的有没问题？
VS Code version: Code 1.68.1 (30d9c6cd9483b2cc586687151bcbcd635f373630, 2022-06-14T12:48:58.283Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No

Hmm the translation is not really correct. Can you please file a new issue in VS Code and try to provide reproducable steps. Thank you!


blog article

adding the roadmap to the blog

I'd rather we write about the things we've done instead of the things we're planning to do. It's not super helpful to see what we're planning to do unless they know what our project is.
Instead we could talk about:

bit fields optimizations
hashchain logic/updating merkle tree roots using a zk proof
documentation
specific changes in new version (this is sorta done in releases section)

make sense.
I guess we can revisit after the holidays, and I won't be able to write this off myself XD

@vimwitch one more time, please.
Change to year in review instead.

Thanks for review @vivianjeng


Tabbed decision letter concept

@maxinedivers this is the branch for the pattern we discussed yesterday.

Will re-create this concept in prototype


Docs for ReceiptStatus

Is ReceiptStatus documented anywhere?
Actually, I'm only interested about ReceiptStatus.HSM_NOK field.

Unfortunately there is no official API documentation. What exactly the HSM_NOK status means is unknown, it is only known that this status means an error.


[Currency Bot] Bumped koa-router from 12.0.1 to 13.0.1

Tada!

Even though they dropped 14 and 16, the tests are still running.


feat: initial setup

What is included in this PR:

Migrate https://github.com/fabric-ds/css/blob/next/src/utils/component-classes/index.js from Fabric
Fix build step
Support for automated semantic releases.

Changes introduced for the release are based on our internal guide on adding automatic releases to Warp packages:
trigger a release with semantic-release whenever a commit is pushed to alpha or master branch.
3.1 add support for commitizen
3.2 add a PR title validator to ensure correct commit history structure in case of squashing
automatically update alpha branch whenever a merge to master takes place
Co-authored by @magnuh and @BalbinaK

 Automate releases of warp packages to NPM and EIK

The build command and esbuild dep can be changed/removed - then this looks good!

The build command and esbuild dep can be changed/removed - then this looks good!

With this change we will release index.js to npm as is.

Missing the LICENSE file? 🙂

didn't notice but yeah, the LICENSE file was missing 😄

I think it was in an initial (sneaky) commit to alpha. 😄

didn't notice but yeah, the LICENSE file was missing 😄

I think it was in an initial (sneaky) commit to alpha. 😄

It was actually an initial commit to master https://github.com/warp-ds/component-classes/tree/master

That license file isn't valid - line 189 needs fixed

That license file isn't valid - line 189 needs fixed

Great catch! Adjusted


Update Wrapper for SmtpClient

This removes wrapped objects that don't need to be wrapped.
It should provide a fully wrapped implement of SmtpClient.

Love the continuous integration.


Additional Languages

In order to add other languages would we just have to add another js file that we manually translate in the 118n folder and recompile? We are looking for English, Chinese, Portuguese, Spanish, French, Korean, Hindi, Arabic and Thai.

Yes, it is as you say @rlavoie, need help?

Seems like the question was answer so I'm closing this


Fix failing test

only add --no-problems-report for version newer than 8.10
Fixes https://github.com/gradle/gradle-private/issues/4484
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger) (Check)


chore: add manual js uploads

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#576  👈 (View in Graphite)
#575
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Improve deserialization exception message when expecting a YamlObject

This pull request improves the message associated with the deserialization exception that arises when a YamlObject was expected, but we got something else instead.
This fixes #1.

LGTM!


Bring Python to 3.8 in Travis

Signed-off-by: Gábor Lipták<EMAIL_ADDRESS>

@kmova @muratkars @openebs please review

This changes not required, please pick the issue having Hacktoberfest label on it  and make a valid contribution. thanks


Add rule to separate case from return statement

Currently swift-format would squash case and return statement together like this:
switch self {
    case .primary: return 0
    case .secondary: return 1
}

Ideally it should be able to produce something more readable but I don't see any option to achieve that.
switch self {
    case .primary:
        return 0
    case .secondary:
        return 1
}

Are you using a configuration that disables respectsExistingLineBreaks, or does this occur even when respectsExistingLineBreaks is enabled?

Using a configuration disabling existing line breaks

Then yes, this is working as intended; the single statement in the case fits on the same line and no line break is forced there so it makes the opinionated choice.
If this is desired behavior, we'd have to add a new configuration option to require a line break after a case.
I don't think I'd want to specialize case statements though; if we do this we should probably treat all single-statement control flow statements equally, e.g.:
// Today, if it fits
if x { foo() }

// With some new option
if x {
  foo()
}

I’ve been evaluating swift-format the last few days and the eagerness to fit as much as possible on single lines is a bit hard to swallow, while the option to respect existing breaks is too respectful. :)
This PR seemed promising until I saw the date. Is there any current work being done in this area?


Preserve search parameters

When going back to a search configuration page, the last configuration for that page should be remembered.

Solution will be to use the combination of Play's cache, and session (with a cache that expires over time).

Solution will be to use the combination of Play's cache, and session (with a cache that expires over time).

Found a possible better solution with local storage / session storage!

Done!