I want to create a EKS cluster with AMI prepared by AWS and install additional packages on the node group instances

Hi,
I want to create an EKS cluster, which:

node group is using the AWS EKS AMI
SSH access to the node group EC2 instances is unblocked. Currently, a separate security group is created with appropriate SSH access but it's not attached to the instances
pre_bootstrap_user_data parameter is executed to install additional packages to the node group EC2 instances.

Unfortunately, I cannot achieve this, not sure if it is feasible at all. Maybe someone can point out what I am doing wrong?
There is no issue during terraform run.
Versions
Terraform v1.2.2
on darwin_amd64
+ provider registry.terraform.io/gavinbunney/kubectl v1.14.0
+ provider registry.terraform.io/hashicorp/aws v4.33.0
+ provider registry.terraform.io/hashicorp/cloudinit v2.2.0
+ provider registry.terraform.io/hashicorp/helm v2.7.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.13.1
+ provider registry.terraform.io/hashicorp/local v2.1.0
+ provider registry.terraform.io/hashicorp/null v3.1.0
+ provider registry.terraform.io/hashicorp/tls v4.0.3
+ provider registry.terraform.io/terraform-aws-modules/http v2.4.1

Reproduction Code [Required]
provider "aws" {
  region = "us-west-2"
}

locals {
  name            = "my_cluster"
  cluster_version = "1.23"
  region          = "us-west-2"

  vpc_id     = "<my_vpc>"
  subnet_ids = ["<subnet-1>", "<subnet-2>", "<subnet-3>"]

  tags = {
    Environment    = "dev"
  }
}

resource "aws_security_group" "remote_access" {
  name_prefix = "${local.name}-remote-access"
  description = "Allow remote SSH access"
  vpc_id      = local.vpc_id

  ingress {
    description = "SSH access"
    from_port   = 22
    to_port     = 22
    protocol    = "tcp"
    cidr_blocks = ["<IP_ADDRESS>/8","<IP_ADDRESS>/8"]
  }

  egress {
    from_port        = 0
    to_port          = 0
    protocol         = "-1"
    cidr_blocks      = ["<IP_ADDRESS>/0"]
    ipv6_cidr_blocks = ["::/0"]
  }

  tags = local.tags
}

module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "~> 18.0"

  cluster_name    = local.name
  cluster_version = local.cluster_version

  cluster_endpoint_private_access = true
  cluster_endpoint_public_access  = true

  cluster_addons = {
    coredns = {
      resolve_conflicts = "OVERWRITE"
    }
    kube-proxy = {}
    vpc-cni    = {
      resolve_conflicts = "OVERWRITE"
    }
  }

  vpc_id     = local.vpc_id
  subnet_ids = local.subnet_ids
  cluster_enabled_log_types = ["audit", "api", "authenticator", "controllerManager", "scheduler"]

  # EKS Managed Node Group(s)
  eks_managed_node_group_defaults = {
    disk_size      = 100
    instance_types = ["t3.medium"]
  }

  eks_managed_node_groups = {

    worker1 = {
      instance_types = ["t3.medium"]
      capacity_type  = "ON_DEMAND"
      min_size       = 2
      max_size       = 4
      desired_size   = 2
      name           = "worker1"

      # Installation of additional packages
      pre_bootstrap_user_data = <<-EOT
      yum -y install osquery
      EOT

      create_launch_template = false
      launch_template_name   = ""

      vpc_security_group_ids = [aws_security_group.remote_access.id]

      remote_access = {
        ec2_ssh_key               = "Instant-Environments-test2"
        source_security_group_ids = [aws_security_group.remote_access.id]
      }
    }
  }

  tags = local.tags
}

Steps to reproduce the behavior:
Update the following variables with parameters that suit your VPC
vpc_id     = "<my_vpc>"
subnet_ids = ["<subnet-1>", "<subnet-2>", "<subnet-3>"]

execute :
terraform init
terraform apply

Expected behavior

the EKS cluster is created (AWS default EKS AMI is used),
nodes groups instances have:
additional packages installed - in my case it's osquery
Security Group that allows SSH access is attached

Actual behavior

the EKS cluster is created (AWS default EKS AMI is used),
nodes groups instances have:
DON'T HAVE additional packages installed - in my case it's osquery
Security Group that allows SSH access IS NOT attached

If you want to provide user data then you need to use a custom launch template (which is the default for this module for this reason plus a number of other reasons).
I would suggest using the custom launch template which will allow you to provide user data and open up SSH access on the security group created by this module (another reason to use custom launch template). Within the launch template spec you can provide key_name which is the name of an existing PEM key for SSH access.
Lastly, I would recommend not using SSH which avoids a lot of what you are trying to do here (key pair, SSH security group rules) and instead use session manager by simply attaching the SSM access policy to the node group https://github.com/terraform-aws-modules/terraform-aws-eks/blob/7f901840c430c0b631cc4066a87779b915a07524/examples/complete/main.tf#L104


Using packed: true doesn't unpack and run properly

Running the EXE on Windows extracts the packed exe, but doesn't seem to know where it was extracted to when launching, and expects it to have been extracted to its local folder, which it shouldn't be.
I only know this as after I built, after running and encountering a stalled launch, I killed the process and copied my extracted source to the local folder and once I reran it, it launched.

If it's expecting launching from the local directory, the generated package.json stripped by nwjs-builder-phoenix might be the case, but I can't reproduce with the sample project and the LTS version.
Would you mind removing the package.json in the built directory and see if it launches? If not, could you please provide a reproducing sample which I can investigate with?
Thanks.

You were right, this was a mistake in forgetting to include my dependencies in my package.json! In converting my application over to nwjs-build-phoenix from nw-builder, I had moved all my dependencies of my app to devDependencies, but a couple were needed for the app, rather than just the build process.
Thanks so much for all your enhancements and fixes thus far, it is greatly appreciated!


Update dependencies and Otel to v1.32.3

Ran rm -rf licenses && ./gradlew --no-build-cache --rerun-tasks generateLicenseReport to get diff
Ran  ./gradlew dependencyUpdates to get below:
> Configure project :awsagentprovider
Inferred project: aws-otel-java-instrumentation, version: 1.33.0-SNAPSHOT

> Task :dependencyManagement:dependencyUpdates

------------------------------------------------------------
:dependencyManagement Project Dependency Updates (report to plain text file)
------------------------------------------------------------

The following dependencies are using the latest release version:
 - com.sparkjava:spark-core:2.9.4
 - com.squareup.okhttp3:okhttp:4.12.0

The following dependencies have later release versions:
 - com.amazonaws:aws-java-sdk-bom [1.12.599 -> 1.12.760]
     https://aws.amazon.com/sdkforjava
 - com.fasterxml.jackson:jackson-bom [2.16.0 -> 2.17.2]
     https://github.com/FasterXML/jackson-bom
 - com.github.ben-manes.versions:com.github.ben-manes.versions.gradle.plugin [0.50.0 -> 0.51.0]
 - com.google.guava:guava-bom [33.0.0-jre -> 33.2.1-jre]
     https://github.com/google/guava
 - com.google.protobuf:protobuf-bom [3.25.1 -> 4.27.2]
     https://developers.google.com/protocol-buffers/
 - com.linecorp.armeria:armeria-bom [1.26.4 -> 1.29.2]
     https://armeria.dev/
 - commons-logging:commons-logging [1.2 -> 1.3.3]
     https://commons.apache.org/proper/commons-logging/
 - io.grpc:grpc-bom [1.59.1 -> 1.65.0]
     https://github.com/grpc/grpc-java
 - io.opentelemetry.contrib:opentelemetry-aws-resources [1.32.0-alpha -> 1.36.0-alpha]
     https://github.com/open-telemetry/opentelemetry-java-contrib
 - io.opentelemetry.contrib:opentelemetry-aws-xray [1.32.0 -> 1.36.0]
     https://github.com/open-telemetry/opentelemetry-java-contrib
 - io.opentelemetry.instrumentation:opentelemetry-instrumentation-bom-alpha [1.32.1-adot1-alpha -> 2.5.0-alpha]
     https://github.com/open-telemetry/opentelemetry-java-instrumentation
 - io.opentelemetry.javaagent:opentelemetry-javaagent [1.32.1-adot1 -> 2.5.0]
     https://github.com/open-telemetry/opentelemetry-java-instrumentation
 - io.opentelemetry.proto:opentelemetry-proto [1.0.0-alpha -> 1.3.2-alpha]
     https://github.com/open-telemetry/opentelemetry-proto-java
 - net.bytebuddy:byte-buddy [1.14.10 -> 1.14.18]
     https://bytebuddy.net
 - org.apache.logging.log4j:log4j-bom [2.21.1 -> 2.23.1]
     https://logging.apache.org/log4j/2.x/
 - org.assertj:assertj-core [3.24.2 -> 3.26.3]
     https://assertj.github.io/doc/#assertj-core
 - org.curioswitch.curiostack:protobuf-jackson [2.2.0 -> 2.5.0]
     https://github.com/curioswitch/protobuf-jackson
 - org.junit:junit-bom [5.10.1 -> 5.10.3]
     https://junit.org/junit5/
 - org.slf4j:slf4j-api [1.7.36 -> 2.0.13]
     http://www.slf4j.org
 - org.slf4j:slf4j-simple [1.7.36 -> 2.0.13]
     http://www.slf4j.org
 - org.springframework.boot:spring-boot-dependencies [2.7.17 -> 3.3.1]
     https://spring.io/projects/spring-boot
 - org.testcontainers:testcontainers-bom [1.19.3 -> 1.19.8]
     https://java.testcontainers.org
 - software.amazon.awssdk:bom [2.21.33 -> 2.26.19]
     https://aws.amazon.com/sdkforjava

Gradle release-candidate updates:
 - Gradle: [8.8 -> 8.9]

Generated report file build/dependencyUpdates/report.txt

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.8/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 1m 4s
5 actionable tasks: 2 executed, 3 up-to-date

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

https://github.com/aws-observability/aws-otel-java-instrumentation/pull/841


JSX support and improved npm run tasks

This resolves 3 things:

npm test is traditionally used for unit-tests. npm start is often used for a dev-server.
npm start wasn't running initial build before watch.
Added JSX support, demo & updated README

I also readded a npm test, so travis would try a build to test (which is better than running a dev server) but then realized that the .travis.yml does that anyway.

Hmm. not sure why it's failing.

Hi konsumer and thanks for the PR.
The first build failed as the latest version of your plugin wasn't published on npm. I've rerun the tests and now another error is thrown. I'm pretty sure it's related to https://github.com/rollup/rollup-plugin-commonjs/issues/63 which involves node v6.0.0 (used in the CI tests). Could you modify your PR in order to use node v5.11.1 instead in the .travis.yml file?

I could, but I am using 6.0.0 locally (I noticed you had it set to that, so I switched with nvm) and it works fine.

Problem with Travis?

In fact, Travis is totally right. I just need to adjust the config/prod.js file! Thanks for your work :beers:

Nice!

Just noticed that rollup-plugin-jsx isn't pulled in anymore, but jsx still works. Is that plugin unneeded now?

Found it! Sweet.


Clarification needed

I've enabled this for my company and I still see people trying older protocols such as IMAP and getting that there password did not match. It appears that people are still able to try but I image will be blocked once they have a good password. This should be clarified in the above and you might want to look at changing that in the future as this doesn't really block the spray attempt, just them using the old protocol once the have the good password.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 138acb44-cb43-d134-b92b-089fc337e0d5
Version Independent ID: 12f90d0c-5d2d-31ee-3f84-314bc964526f
Content: Baseline policy Block legacy authentication (preview) - Azure Active Directory
Content Source: articles/active-directory/conditional-access/howto-baseline-protect-legacy-auth.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@kucster
Thanks for your feedback! We will investigate and update as appropriate.

Hi @kucster - just to clarify, are you wanting to add a note that images will be blocked for older protocols like IMAP? Or is there another note you would like to add to the doc?

In testing I've found that the legacy protocol will only be blocked when
authentication is successful so a person is still able to try legacy but
will be blocked if they have a good user name and password combination. So
a person reading this page may get the opinion that legacy is always
blocked which does not seem to be the case.
--The reason this came up is my company is under attack via brute force via
IMAP. I've enabled this setting but the attack is able to continue so it
seems as though this setting only takes effect after a successful login. So
someone like me could be disappointed when they realize this won't help an
attack.
On Thu, Jul 11, 2019 at 1:07 AM Marilee Turscak - MSFT <
<EMAIL_ADDRESS>wrote:

Hi @kucster https://github.com/kucster - just to clarify, are you
wanting to add a note that images will be blocked for older protocols like
IMAP? Or is there another note you would like to add to the doc?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/34779?email_source=notifications&email_token=AH4QAWFRUJT5NIVHGHNKF33P625ZFA5CNFSM4H7HMJ62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZVQQJI#issuecomment-510330917,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH4QAWDHHFNCSKNX2AAME7DP625ZFANCNFSM4H7HMJ6Q
.

Got it. This is a good point and maybe something worth adding as feedback to the product team as well.
@MicrosoftGuyJFlo  I made a PR to add the note, "This setting only takes effect after a successful login, so users will still have the option to attempt using legacy authentication" and will leave it up to you to approve/reject. https://github.com/MicrosoftDocs/azure-docs-pr/pull/82026
Do you think that additional updates are needed and that this might be something worth leaving as feedback or a bug fix to the product team?

Pending feedback from PM

Approving PR

#please-close


For targeting SDK 34 - Added RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support in DevSupportManagerBase

Summary:
Add RECEIVER_EXPORTED/RECEIVER_NOT_EXPORTED flag support to DevSupportManagerBase for Android 14 change. See
https://developer.android.com/about/versions/14/behavior-changes-14#runtime-receivers-exported for details.
Without this fix, app crashes during launch because of :
SecurityException: {package name here}: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts
Differential Revision: D47313501

Hi! Ai updated from react native from 0.70.6 to 0.72.8, and the error persists. How to resolve?

Which version of React Native includes these features? We are using 0.68.2, and I am still facing the issue. Can someone guide here?


(column: select_multiple) Relationship Values Column Formatting in Export is Not Properly Aligned

Bug report
(column: select_multiple) Relationship Values Column Formatting in Export is Not Properly Aligned
What I did
I'm using Laravel Backpack 4.1.66V and Exporting data by calling $this->crud->enableExportButtons(); in CrudController@setup() function. Where in this CRUD Controller I have used the select_multiple column type to display the relationship values (comma separated). Everything working fine except for Export Formatting for relationship values. In Export Files relationship values column format is weird. I guess because of commas they're not displaying in the right format.
Is it a bug in the latest version of Backpack?
I guess it still persists in the latest version too.
Backpack, Laravel, PHP version
Backpack: V4.1.66
Laravel: v8.83.5
When I run php artisan backpack:version the output is:
Backpack: 4.1.66
Any help would be great. Thanks in advance

Hello @sandeepchowdary7 thanks for the report.
At the moment the separator comma (,) is hardcoded, but if you publish your column and override the blade file to use something else like ; or . as a separator does it work ? https://github.com/Laravel-Backpack/CRUD/blob/337163b7e9a0e63413474bd3ee800a198f83c8e9/src/resources/views/crud/columns/select_multiple.blade.php#L43
Let me know. 🙏

Hello @sandeepchowdary7
I can confirm the export for select_multiple column is kind of broken.
After some hours of debugging I found out the issue to be related on the fact that datatables export uses the generated html for export, and blade leaves out some artifacts in html that are not correctly interpreted.
I found out that if we have the column "render" in one line, it will export almost fine:
// select_multiple.blade.php column
{{-- relationships with pivot table (n-n) --}}
@php
    $column['value'] = $column['value'] ?? data_get($entry, $column['name'], []);
    $column['escaped'] = $column['escaped'] ?? true;
    $column['prefix'] = $column['prefix'] ?? '';
    $column['suffix'] = $column['suffix'] ?? '';
    $column['limit'] = $column['limit'] ?? 32;
    $column['attribute'] = $column['attribute'] ?? (new $column['model'])->identifiableAttribute();

    if($column['value'] instanceof \Closure) {
        $column['value'] = $column['value']($entry);
    }

    if($column['value'] !== null && !$column['value']->isEmpty()) {
        $related_key = $column['value']->first()->getKeyName();
        $column['value'] = $column['value']->pluck($column['attribute'], $related_key);
    }

    $column['value'] = $column['value']
        ->each(function($value) use ($column) {
            $value = Str::limit($value, $column['limit'], '…');
        })
        ->toArray();
@endphp

@if(!empty($column['value'])){{ $column['prefix'] }} @foreach($column['value'] as $key => $text)@includeWhen(!empty($column['wrapper']), 'crud::columns.inc.wrapper_start')@if($column['escaped']){{ $text }}@else{!! $text !!}@endif @includeWhen(!empty($column['wrapper']), 'crud::columns.inc.wrapper_end', ['related_key' => $key])@if(!$loop->last), @endif@endforeach{{ $column['suffix'] }}@else{{ $column['default'] ?? '-' }}@endif

The problem is that the html we give to the datatable column to render is from a view, that by default will render the exactly contents of your blade file (divs, spans, etc) in multiple lines like you defined in your blade file.
That is not needed in this case, as long as everything is displayed we don't need it to be rendered in multiple lines etc.
I found a "quick" solution, since render() accepts a closure as parameter to format contents, I get the contents without line breaks and no more than 1 space allowed.
Also did some modifications to the blade file to remove some extra white space from elements. Check PR here: https://github.com/Laravel-Backpack/CRUD/pull/4546
All of this findings came when debugging the colum and writting the output as a plain string, I've create a branch with it, but didn't submit pr for it, you can check the changes here: https://github.com/Laravel-Backpack/CRUD/compare/v5...select-multiple-column-string
@tabacitu I think $column['render'] would be usefull here ... 👍 If not any of this two solutions I talked about, only having CrudColumns as objects and implementing their render function could solve this. Using "rendered" views for this situation it's not ideal.
What do you think ?

Thanks for letting us know @sandeepchowdary7 . I tried it too, and I think I understand the problem. Let me post some screenshot here too, so it's easier to understand what we're talking about. Here's how the select_multiple column gets exported to PDF:

and to Excel:

In short, the Tags column has a lot of space after each item (before the comma).

All of this findings came when debugging the colum and writting the output as a plain string, I've create a branch with it, but didn't submit pr for it, you can check the changes here: https://github.com/Laravel-Backpack/CRUD/compare/v5...select-multiple-column-string

I don't understand - should I be looking at that or not? I don't understand if there's anything here to discuss @pxpm or we should close this and move the conversation to https://github.com/Laravel-Backpack/CRUD/pull/4546 Can you please give your recommendation on what to do here?
Thanks!

Closing and moving the conversation to #4546


Bug: LoggedUserSensor sensor shows wrong value if logged in as another user

If HASS.Agent is installed under user account A which is signed-in in the background but user B is currently logged in and has an active desktop session the LoggedUserSensor reports the name of user A, not user B.
Based on that behaviour I believe that LoggedUserSensor would only ever show the name of the user HASS.Agent is installed under.
I assume this is a side effect of HASS.Agent currently being installed under / tied to a specific user. This will likely be solvable once the 'satellite service' is implemented.

You're right, that can be fixed with the satellite service. Thanks for posting this though, otherwise I hadn't known :)

Related but slightly different issue with this sensor is that the value of the sensor remains set to the username even when the PC is locked. It's debatable whether this should be the case or not because technically the user is still "logged in" but the intent of this sensor IMO is to show which user has an active desktop session (i.e. is logged into the desktop session and is actively using the PC).
Thinking about the future where we have a "satellite service" and multiple users are supported and multiple users are logged in what should this value be? For example when more than one user is logged in but the PC is locked should it show the username of the last user to have an active desktop session? Should it show something like "system" or "locked"? Hmmmm 🤔

Hey @bverkron,
I've been thinking about this as well, and this is what I've come up with so far:
I'm going to make the LoggedUsersSensor more strict: only users with an active session will be listed. Locked means not active, so not listed.
The LoggedUserSensor will be based on the same code, but will always just show one user: if more are logged, it'll take the first.
It's up to the user to decide what they need, I don't think Windows 10/11 even support multiple active (remote desktop) users out of the box, so usually the LoggedUserSensor will do.
The SessionStateSensor can be used to show whether a specific user's session is locked or not.
Let me know what you think!

Fixed in the latest beta: https://github.com/LAB02-Research/HASS.Agent/releases/tag/2022.13.0-beta1


Which one is correct/preferred way?

Hi,
During the compilation I got error and suggestion that I should use one of:
use cursive::event::EventResult;
use cursive_core::event::EventResult;
Which one is the preferred one?
Thank you

Both are the same. Cursive re exports all of cursive-core.
If you write a library, it may help to only depend on cursive-core.
If you write an application, just use cursive.


add more PROTECTs to C++ code generated for a nimbleRcall

fixes #869
This pull request inserts additional uses of PROTECT into C++ generated for a nimbleRcall.  There is a C++ function generated that creates an R expression object (LANGSXP) and populates it before calling the R evaluator.  Arguments to it are SEXP objects copied from nimble's internal C++ objects (NimArr).  Those needed PROTECT statements, as did the object returned from R before being copied into a nimble internal object.

@perrydv Confirming that this fixes the error / bug I was experiencing

@perrydv Happy to have this merged into devel, whenever you deem it ready.

@perrydv @danielturek do NOT merge until I give the go-ahead. I haven't yet tagged v0.7.1 nor merged devel into master.

Ok, devel is unfrozen - feel free to merge when you want.

@perrydv Is this ok to merge in?  I'm keen to, if you think it's ready.  We have the "go ahead" from Chris.


Custom authorization/rate limit error messages

Component(s)
router
Is your feature request related to a problem? Please describe.
It would be great to be able to change the default authorization/rate limit error message set in the loader.
Main reason - it's a string of no fixed structure and no guarantees that it won't change it the upcoming release. I'd really love to be able to have something like UNAUTHORIZED instead of the Unauthorized request to Subgraph ....
The functions in question are Loader.renderAuthorizationRejectedErrors and Loader.renderRateLimitRejectedErrors.
Describe the solution you'd like
I'd be fine with any way of accessing these errors w/o copying/patching half of the router code. The simplest one would probably be the "override" similar to other error overrides.
Describe alternatives you've considered
No response
Additional context
In general it would be nice to have some access to the resolve.Context created in the GraphQLHandler.ServeHTTP. One option I was exploring was to find a way to set a LoaderHook as there is a call to it right after the auth error is merged. But to set these hooks i'll need to customize the handler, which implies customizing the mux, which implies customizing the startup procedure. Basically too much copy-pasting for a single line of text

Hi @upcFrost, thanks for your feedback. This is not currently in our pipeline, but that might change in the future.


fix: Update docs table

Fixes #505
Please refer to this comment: https://github.com/prisma/website/issues/505#issuecomment-1700941316

For me, the "before" is more usable when I want to get an overview of the database features that Prisma supports.


We need a way to query vaults given a member address

We will do it really simple for now. In a full production environment this MUST use an Indexing service (unless we keep members inmutable)


[loc][Query][vscode-cmake-tools] Localizability of 0; "./src/kit.ok.running"

Hello developers,
please help localization team to answer question from translator.
In case translator is not sure about context/meaning/localizability of string we raise a question.
Source:
OK running {0} {1}, env vars: {3}
File Name:
Src\vscode-extensions\vscode-cmake-tools.xlf
Query:
Please provide more context for this string. What are the placeholders and what is meant by "env vars". Thanks.

{0} is a script file name
{1} are the arguments passed to the script
{3} is a list of environment variables

perfect, thx


Extension shows empty despite master items in the app

Hello,
Extension shows empty despite master items in the app.
Also, whenever I click on the buttons for Measures/Dimensions, I get the below error message.
That's with September 2019 patch 2.
angular.31978c1cc8d68d2ba534.js:8 TypeError: getMasterLibrary is not a function
at h.$scope.viewChange (master-items-viewer.js:50)
at fn (eval at compile (angular.31978c1cc8d68d2ba534.js:8), :4:158)
at i (angular.31978c1cc8d68d2ba534.js:8)
at h.$eval (angular.31978c1cc8d68d2ba534.js:8)
at h.$apply (angular.31978c1cc8d68d2ba534.js:8)
at HTMLButtonElement. (angular.31978c1cc8d68d2ba534.js:8)
at HTMLButtonElement.dispatch (jquery.b98c142190f10af0d55e.js:8)
at HTMLButtonElement.v.handle (jquery.b98c142190f10af0d55e.js:8)

Can you give e bit more information please so I can try replicating this - I have only tested this with November 2019 and February 2020 release so far and it works on desktop and QSE for windows server, I was not able to recreate this error.

Which browser are you using (version)?
Which built are you testing? release <IP_ADDRESS> or an earlier build?

Thanks for trying it out.
Kab

Chrome Version 80.0.3987.122 (Official Build) (32-bit)
"version": "<IP_ADDRESS>"

The error is a JavaScript error with the primary function which is the one being called by the angular controller to view the data fetched by the service. I am running chrome version 80.0.3987 too - but the 64 bit version (that shouldn't really matter). I think there something must be going wrong with the babel and web pack during package creations. I have going to repack without minifing the js file. Can you try the attached please and let me know if this resolves the issue? (you might have to clear your browser cache as you have loaded the other version already)
master-items-viewer-v-<IP_ADDRESS>.zip

Hi Kab, unfortunately same behavior.
I don't see any errors in the network tab or WS stream, apart from the console one I shared earlier with regards to buttons.

hmm this is acting rather strange. I can rewrite this function slightly different way and see if this makes any difference.

can you try this build please? I have changed the way I am calling the method to see if that resolves it. I still can't recreate this issue - I have tried IE 10, chrome and Edge - all worked fine with all versions of the codes I have shared with you. Working on QSE servers - I have tried it on 3 different version now (June 2019 - February 2020). So this got me bit puzzled.
I am sure you are clearing the browser cache, but just going to throw it out there, clear it out please. Also please make sure older version is deleted from the server before adding this one in (which you have to do anyways).
master-items-viewer-v-<IP_ADDRESS>.zip

Hi,
Sorry I had missed the notification on your message.
I imported that version. The extension shows empty, still.
Do I need to set something for Measures/Dimensions to display?
I was under the impression they should display when we add the extension on the sheet.
When hitting the Dimensions button:
angular.31978c1cc8d68d2ba534.js:8 TypeError: Cannot read property 'dimensions' of undefined
at getMasterLibrary (master-items-viewer.js:26)
at h.$scope.viewChange (master-items-viewer.js:51)
at fn (eval at compile (angular.31978c1cc8d68d2ba534.js:8), :4:158)
at i (angular.31978c1cc8d68d2ba534.js:8)
at h.$eval (angular.31978c1cc8d68d2ba534.js:8)
at h.$apply (angular.31978c1cc8d68d2ba534.js:8)
at HTMLButtonElement. (angular.31978c1cc8d68d2ba534.js:8)
at HTMLButtonElement.dispatch (jquery.b98c142190f10af0d55e.js:8)
at HTMLButtonElement.v.handle (jquery.b98c142190f10af0d55e.js:8)
angular.31978c1cc8d68d2ba534.js:8 TypeError: Cannot read property 'measures' of undefined
at getMasterLibrary (master-items-viewer.js:25)
at h.$scope.viewChange (master-items-viewer.js:51)
at fn (eval at compile (angular.31978c1cc8d68d2ba534.js:8), :4:158)
at i (angular.31978c1cc8d68d2ba534.js:8)
at h.$eval (angular.31978c1cc8d68d2ba534.js:8)
at h.$apply (angular.31978c1cc8d68d2ba534.js:8)
at HTMLButtonElement. (angular.31978c1cc8d68d2ba534.js:8)
at HTMLButtonElement.dispatch (jquery.b98c142190f10af0d55e.js:8)
at HTMLButtonElement.v.handle (jquery.b98c142190f10af0d55e.js:8)
All resources were downloaded without an issue from the network tab in dev tools.
FYI, I tried that one as a sanity check and it works fine:
https://github.com/GINQO/Master-Item-Manager
We cannot see the measures/dimensions in a table, but only as CSV.
Maybe you can check how they did it.
Kind regards,
Armand

I'm having the same problem as @armandfrigo . I see a "No results found" error message despite there being many master measures defined in the app.
Error message from console upon clicking 'Measures':
app.6.105.4.js:7 TypeError: Cannot read property 'measures' of undefined
at getMasterLibrary (master-items-viewer.js:25)
at d.$scope.viewChange (master-items-viewer.js:51)
at fn (eval at compile (app.6.105.4.js:7), :4:158)
at i (app.6.105.4.js:7)
at d.$eval (app.6.105.4.js:7)
at d.$apply (app.6.105.4.js:7)
at HTMLButtonElement. (app.6.105.4.js:7)
at HTMLButtonElement.dispatch (app.6.105.4.js:7)
at HTMLButtonElement.m.handle (app.6.105.4.js:7)
(anonymous) @ app.6.105.4.js:7
(anonymous) @ app.6.105.4.js:7
$apply @ app.6.105.4.js:7
(anonymous) @ app.6.105.4.js:7
dispatch @ app.6.105.4.js:7
m.handle @ app.6.105.4.js:7
Error message from console upon clicking 'Dimensions':
app.6.105.4.js:7 TypeError: Cannot read property 'dimensions' of undefined
at getMasterLibrary (master-items-viewer.js:26)
at d.$scope.viewChange (master-items-viewer.js:51)
at fn (eval at compile (app.6.105.4.js:7), :4:158)
at i (app.6.105.4.js:7)
at d.$eval (app.6.105.4.js:7)
at d.$apply (app.6.105.4.js:7)
at HTMLButtonElement. (app.6.105.4.js:7)
at HTMLButtonElement.dispatch (app.6.105.4.js:7)
at HTMLButtonElement.m.handle (app.6.105.4.js:7)
Chrome version:
80.0.3987.132 (Official Build) (64-bit)
Qlik Sense Enterprise Version:
Qlik Sense June 2019 - 13.32.2
Master-Items-Viewer Extension versions tested:
0.0.2
0.0.3
I followed the instructions during installation (standard extension installation process via QMC) and made sure to clear my browser cache and remove the previous version before testing 0.0.3.
Thank you!

ok I will take a look at the weekend, I think I have an idea on how to fix this but still bit puzzled as to why its only happening in certain cases. I suspect its the the angular service class is causing this issue. I will rewrite this to see if i can resolve it.

@kabir-rab Thank you! I am happy to perform further testing when you are ready.

@viperior @armandfrigo - I have finally managed to get some time to test it on June 2019. Seems like the issue is with the following -
generateSheetList = function(){
                    var deferred = $.Deferred(),
                        sheetObjectList = [];
                    app.getList( "Sheet", function(sheets){
                        sheetObjectList = sheets.qAppObjectList.qItems; // This is not included in the older version and causing the error
                    })
                    .then(function(sheets){
                        app.destroySessionObject(sheets.id)
                        .then(function(a){
                            deferred.resolve(sheetObjectList);
                        });
                    });
                    return deferred;
                }

qAppObjectList.qItems is missing in version prior to November 2019. Fix for the older versions would be to use a different logic to retrieve all objects, can use the full property tree call which was one of the options I was using at a earlier stage of the development. I will see if I can rewrite this so it works in older versions.
Reason for getting all objects is to check where the master dimensions/measure is being used. Prior to adding that feature, the version I had that works with older version. If you are interested, I can re-pack that earlier version for you to use till I work on the re-write.
-Kab

@kabir-rab Nice work! I am interested in a re-pack of the earlier version.

@viperior @armandfrigo  - There is a lite version that works on earlier versions of Qlik Sense. I have tested this on June 2019. You miss some additional feature but its 90% of the full version.
https://github.com/kabir-rab/master-items-viewer-lite
I will close the ticket as this is no longer relevant.
Thank you.
Kab

@kabir-rab You rock! Thank you!


Can't block YouTube ads?

When I visit the YouTube site, an ad appears, can I not block it? Video ads.

Can I enter those list to yours webview or should I modify them?
Thanks a lot!


Uploading Artifacts to S3 Endpoint

Is there a way to change the artifacts location other than local? I set MLFLOW_S3_ENDPOINT_URL with user/pass in the jupyternotebook but every run sends the model to metadata/mlflow/mlartifacts/..

Yes. You can specify artifact_location in the profile config. For example here: https://github.com/mlflow/mlp-regression-template/blob/main/profiles/local.yaml#L4

Thanks @jinzhang21 I did try to replace this with a s3 url, but It still stores the artifacts locally

Hi,
I've been reading source code to try to figure out how to resolve this.
I tried adding overrides in the local.yaml for the aws public and private keys but that prevents the pipeline from running

Thanks for the feedback @alex-g-tejada and @bvarjavand ! We'll investigate this in the coming weeks.


[core] Introduce stats in snapshot

Purpose
First step of PIP-14: Paimon statistics
snapshot-x
{
  "version" : 3,
  "id" : 2,
  "schemaId" : 3,
  "baseManifestList" : "manifest-list-485c5847-cb20-4324-b2ea-fd73959c5857-0",
  "deltaManifestList" : "manifest-list-485c5847-cb20-4324-b2ea-fd73959c5857-1",
  "changelogManifestList" : null,
  "commitUser" : "e30257ac-a617-4571-a57b-60c3dd608754",
  "commitIdentifier" :<PHONE_NUMBER>854775807,
  "commitKind" : "ANALYZE",
  "timeMillis" :<PHONE_NUMBER>486,
  "logOffsets" : { },
  "totalRecordCount" : 6,
  "deltaRecordCount" : 0,
  "changelogRecordCount" : 0,
  "watermark" : null,
  "statistics" : "stats-87effd5d-48fd-4aab-81fe-4222b847d247-0"
}

statistics/stats-87effd5d-48fd-4aab-81fe-4222b847d247-0
{
  "snapshotId": 2,
  "mergedRecordCount" : 10,
  "mergedRecordSize" : 1000,
  "colStats" : {
    "orderId" : {
      "distinctCount" : 10,
      "min" : "1",
      "max" : "10",
      "nullCount" : 0,
      "avgLen" : 8,
      "maxLen" : 8
    }
  }
}

Tests

API and Format
write
FileStoreCommitImpl commit = store.newCommit();
commit.writeStats(stats, Long.MAX_VALUE);

read
StatsFileHandler statsFileHandler = store.newStatsFileHandler();
Optional<Stats> stats = statsFileHandler.readStats();

Next
Future work

expire of stats
read stats with system table
spark analyze

In pip-14, we included statistics for maxLen and avgLen, would you consider adding minLen？

In pip-14, we included statistics for maxLen and avgLen, would you consider adding minLen？

The primary purpose of PIP-14 is to enable Paimon to preserve stats for query engine CBO (especially for Spark), Below are the stats collected by various engines, the common ones among them are the stats introduced in this PIP.
Hive: https://cwiki.apache.org/confluence/display/Hive/StatsDev
Flink: https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/sql/analyze/
Spark: https://spark.apache.org/docs/latest/sql-ref-syntax-aux-analyze-table.html
Besides, from what I know, aside from histograms (maybe will add to paimon in the future), distinctCount, min, max, avglen, and nullCount are useful in cost estimation, maxLen is hardly used in Spark(open source)'s CBO. Nevertheless, we have decided to include it in order to maintain consistency with Spark. Of course, if we find other certain stats are very useful, we can also add them.
Cost estimation example: https://cwiki.apache.org/confluence/display/Hive/Cost-based+optimization+in+Hive.

In pip-14, we included statistics for maxLen and avgLen, would you consider adding minLen？

The primary purpose of PIP-14 is to enable Paimon to preserve stats for query engine CBO (especially for Spark), Below are the stats collected by various engines, the common ones among them are the stats introduced in this PIP.
Hive: https://cwiki.apache.org/confluence/display/Hive/StatsDev Flink: https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/sql/analyze/ Spark: https://spark.apache.org/docs/latest/sql-ref-syntax-aux-analyze-table.html
Besides, from what I know, aside from histograms (maybe will add to paimon in the future), distinctCount, min, max, avglen, and nullCount are useful in cost estimation, maxLen is hardly used in Spark(open source)'s CBO. Nevertheless, we have decided to include it in order to maintain consistency with Spark. Of course, if we find other certain stats are very useful, we can also add them.
Cost estimation example: https://cwiki.apache.org/confluence/display/Hive/Cost-based+optimization+in+Hive.

Thanks for your reply, which helped me understand the design idea of this part.

two update:

add schemaId in stats: snapshot may expire, but schema never
add colId for each col in colStats: for schema evolution in the future

+1

#2799

https://github.com/apache/incubator-paimon/issues/2404


Render attribute docstrings

Currently, quartodoc raises a NotImplementedError when rendering Attributes. It can mostly be rendered like a griffe Object, except that it does not have parameters. (Should be a quick thing to implement).

Released in v0.2.1


Change Worm Supreme to All fishing hooks.

Add the option to use Bladebone Hooks.
(added ItemInBag as support for the other 2.)

Thanks! :)


Adds more window title options

Adds multiple new Window Title options:

Icon Toggle for Custom Titles
Custom Window Title Toggle:

If disabled, the title will default to either the client-provided title or, if that’s empty, the class name.

Truncation Options for the new Title

Added a toggle for truncating the new title.
Added options to set the truncation length.

Noticed the following issues:

Show Custom Title hides the icon (even with icon enabled)
Truncate window title doesn't seem to work (enabled or disabled, no matter the truncation size)

Oh my bad, I might have broken something while merging your changes. I will look at them in a few days when I find some more time.

No worries :+1:

@Jas-SinghFSU Alright I finally got some time on my hands again and checked your issues.

Added custom icon support even when the custom title is disabled.
Applied truncation to custom titles as well.

I hope I understood your points correctly, else just give me heads up and i will fix it. Thanks!

As always, appreciate the contribution :heart:


Defining IssueRepo

https://github.com/ossf/allstar/pull/80
We are trying to centralize all issues in Org to repo centralRepo, but not exactly sure how to setup IssueRepo.
In that case, I am assuming what we define in allstar.yaml within .allstar repo is the following.
optConfig:
  optOutStrategy: true
  disableRepoOverride: true
issueRepo: centralRepo

But, I'm not quite sure because it seems none of the issue is appearing in the repo.

Yes, that looks correct. Allstar is only running about once every 24 hours currently, you might just need to wait a bit.

I see. Thanks!


Provide better logging

📚 Documentation preview 📚: https://metatensor-models--37.org.readthedocs.build/en/37/

For now, I would merge it. I will open an issue about cleaning up the logging, which will also cover other aspects of the logger


Need to add flg of organization.

Example
Request
https://api.github.com/users/facebook
Response
Whether type parameter is Organization.
{
  "login": "facebook",
  "id": 69631,
  "avatar_url": "https://avatars.githubusercontent.com/u/69631?v=3",
  "gravatar_id": "",
  "url": "https://api.github.com/users/facebook",
  "html_url": "https://github.com/facebook",
  "followers_url": "https://api.github.com/users/facebook/followers",
  "following_url": "https://api.github.com/users/facebook/following{/other_user}",
  "gists_url": "https://api.github.com/users/facebook/gists{/gist_id}",
  "starred_url": "https://api.github.com/users/facebook/starred{/owner}{/repo}",
  "subscriptions_url": "https://api.github.com/users/facebook/subscriptions",
  "organizations_url": "https://api.github.com/users/facebook/orgs",
  "repos_url": "https://api.github.com/users/facebook/repos",
  "events_url": "https://api.github.com/users/facebook/events{/privacy}",
  "received_events_url": "https://api.github.com/users/facebook/received_events",
  "type": "Organization",
  "site_admin": false,
  "name": "Facebook",
  "company": null,
  "blog": "https://code.facebook.com/projects/",
  "location": "Menlo Park, California",
  "email": null,
  "hireable": null,
  "bio": "We work hard to contribute our work back to the web, mobile, big data, & infrastructure communities. NB: members must have two-factor auth.",
  "public_repos": 149,
  "public_gists": 12,
  "followers": 0,
  "following": 0,
  "created_at": "2009-04-02T03:35:22Z",
  "updated_at": "2015-10-07T21:49:32Z"
}

TODO
test


feat(agent): add support for function-based agents and buffer editor

.gitignore: Exclude macOS .DS_Store files.
AGENTS.md: Updated to include information on function-based agents and buffer editor implementation.
README.md: Documented the new Buffer Editor agent and distinctions between agent types.
lua/codecompanion/agents.lua: Added execute function for Buffer Editor agent.
lua/codecompanion/config.lua: Configured Buffer Editor agent.
lua/codecompanion/helpers/buffers.lua: Implemented buffer content formatting and buffer info retrieval.
lua/codecompanion/strategies.lua: Included context in agent strategy.
lua/codecompanion/utils/util.lua: Added function to get active buffers.

The introduction of function agents significantly enhances the plugin's capabilities and flexibility. This type of agent can perform more complex and powerful operations, going beyond the default chat interface interaction model.

This looks awesome!!! I'll try it out tomorrow and feedback.

A few tweaks I'd like to make to the docs and config. Could you give me access to your fork?

Thanks so much for this. I've just played around with it now and it's awesome! I was hoping that someone would implement this type of feature in the plugin as it's the next logical step of allowing the LLM to implement its code in the editor.
Your idea to use CDATA in the XML prompt is fantastic. I've played around asking the agent to do minor changes and it works well. For more complex asks like "refactor this file" it's less able but we can think about how we could implement that in the future.
Just a couple of minor requests to the config and README.

Thanks for giving me access. I find working on PRs to be impossible at times:

I'm happy to merge the PR as it is now and make the changes later. Anything new you want to add before I merge?

Thanks for giving me access. I find working on PRs to be impossible at times:

I'm happy to merge the PR as it is now and make the changes later. Anything new you want to add before I merge?

If that's the case, let's merge it first. I can submit new pull requests in the coming days to make some minor bug fixes. One obvious bug I've found so far is that there's an issue with creating new files in the buffer editor.


indent ipython blocks, fixes #334

I'll create a new issue to solve the problem itself and propose ideas to automate the indentation/styling of rst

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.


Dynamic Shortable Asset List

Description
useGetShortableSynths.ts
Added a new query. Updated ethcall to 4.3.6 to enable OP support.  L2 Synths are retrieved from synthetixjs using multicall, memoed into each file that uses it.  L1 list is hard coded into the query since they are deprecated.
useShort.tsx
ShortingHistory.tsx
ShortingReward.tsx
ShortingStats.tsx
Replaced SYNTHS_TO_SHORT and SYNTHS_TO_SHORT_L1 with a single query that populates SYNTHS_TO_SHORT, and updated hooked memos.
useFeeReclaimPeriodsQuery.ts
new version of ethcall no longer required {} parameter. It also returns unknown[] instead of [any,any,any], like the previous version did, so I cast the result.
useRedeemableDeprecatedSynthsQuery.ts
new version of ethcall no longer required {} parameter
useTokensBalancesQuery.ts
new version of ethcall no longer required {} parameter
Resolved Various Lint Errors that somehow made it into dev (came down with my upstream fetch)
/home/kethic/archive/kwenta/components/TVChart/TVChart.tsx
85:5  warning  React Hook React.useEffect has missing dependencies: 'autosize', 'containerId', 'fullscreen', 'interval', 'libraryPath', 'overrides', and 'studiesOverrides'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
/home/kethic/archive/kwenta/sections/exchange/TradeCard/Cards/CombinedMarketDetailsCard.tsx
2:25  warning  'useMemo' is defined but never used                                                                                @typescript-eslint/no-unused-vars
50:5   warning  React Hook useEffect has a missing dependency: 'rates24hQuery.isSuccess'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
/home/kethic/archive/kwenta/sections/exchange/hooks/useExchange.tsx
541:3  warning  React Hook useMemo has an unnecessary dependency: 'isL2'. Either exclude it or remove the dependency array  react-hooks/exhaustive-deps
Related issue
https://github.com/Kwenta/kwenta/issues/359
Motivation and Context
Allow for automated deployment of new synthetix synths to kwenta shorting market
How Has This Been Tested?
useShort.tsx
ShortingHistory.tsx
The right-side drop-down populates with the correct L2 synths. I opened and closed positions on every L2 synth, confirming it was selectable, and showed up correctly under Your Positions.
ShortingReward.tsx
This is only used on L1.  Verified the synth reward list is correct for L1 after the change.
ShortingStats.tsx
This is used on L1 and L2.  Verified the synth list displayed is correct on both L1 and L2 after the change.
useFeeReclaimPeriodsQuery.ts
I don't know how to this one other than the console.log commands I used during dev.
useRedeemableDeprecatedSynthsQuery.ts
DashboardCard uses this.  Synth list appears to still work after the change.
useTokensBalancesQuery.ts
This is used in useExchange and SelectTokenModal.  Both of these appear to still work after the change.

I don't know what to do to resolve these checks.  they never pass, and it concerns me.

@kethcode Sorry for the delayed review. Left a few comments above.

Thank you for the review. I will make these changes

Also, it looks like there are conflicts in the package-lock.json. I think you should be able to fix them by deleting the file and re-running npm i. Only caveat is to make sure you're on npm v7.

@koredefashokun I saw that.  However, I need to upgrade ethcall to 4.3.6, so the changes need to occur.  Someone else just pushed a lock file with 3.2.0 in it since I submit the PR.  Should I pull the latest dev v1, merge and recommit?

@koredefashokun @platschi should be done now.

I give up.  Turning off my linter, deleting this PR, and I'll resubmit with a narrower scope.


Add Feature to Pause and Schedule Start/Stop Times for Clusters in Elastic Clou

Context
Clusters, whether for production, QA, or development, are not always in use continuously. Currently, the only way to avoid unnecessary costs for idle clusters is to delete them, which results in data loss and requires time-consuming reconfiguration. A feature to pause clusters, along with scheduling when they stop and start, would offer a cost-effective solution. This allows teams to manage resources efficiently without losing important configurations or data. Scheduling stop and start times ensures that resources are only used when needed, further optimizing cost savings.
Overview
Add a feature that allows pausing any cluster in Elastic Cloud—whether it's for production, QA, or development—to save costs when the cluster isn't in use. Users should also have the ability to schedule automatic pauses and restarts of clusters based on their specific usage patterns, reducing resource consumption and costs while preserving the cluster's state for easy reactivation when needed.
Possible Implementation

Pause/Resume Option: Include a "Pause" option in the Elastic Cloud UI that lets users suspend a cluster's operations, freeing up resources while keeping all configurations and data intact.
Scheduling: Add a scheduling feature that allows users to set specific times for clusters to automatically pause and restart. For example, a production cluster could be paused during non-peak hours and restarted automatically when needed.
Reminders/Notifications: Provide automated reminders or notifications for paused clusters, giving users the option to resume or delete them based on their needs.

Testing

Unit Testing: Ensure that the pause, resume, and scheduling functions work correctly without data loss, and that all configurations are preserved.
Integration Testing: Validate that scheduling works as expected, with clusters pausing and resuming automatically according to the user-defined schedule.
Acceptance Testing: Test the feature in various scenarios, such as pausing production, QA, or development clusters, to ensure it effectively reduces costs and meets user needs.

@crn1239 thanks for adding this however, the issue has a much bigger scope than just this Terraform provider. We have an internal issue tracking this request (i.e scheduled pause/resume of deployments to minimise cose), and I've added your vote to that issue. That request isn't on the roadmap at the moment though, so there's no time frame to share.
I'm going to close this out, since it's not really a provider issue. We are tracking it internally, and would aim to add support to the provider once it's implemented in the broader Cloud API.


bsp scanner "post" section

Yes, I'm still using VeeSeeVST! So, I've been reading up on the available modules, and this paragraph from bsp's own Scanner module caught my attention.

The post section is activated by pluggin a cable into the post output. It's basically an experiment where I wanted to hear how the shape window sounds when applied to audio data. I left it in since it turned out to be useful for synthesizing cymbal and hihat sounds (among other things). The knob selects the window shape (same as the main shape parameter), and the switch toggles a window offset (this used to be a bug in earlier versions but it sounded nice with some sounds).

I don't really get what that all means. What's the shape window applied to audio data? If the regular window shape appears to be affecting the Post output, does the knob add up to that shape window? ...And how can I synthesize cymbals with it, if I may ask?
From what I've understood (if anything), the Post output seems to be intended for position modulation feedback, so I can change the post window shape (?) without affecting the regular window shape, but there's a lot I don't understand.

Connecting the POST output activates a ring buffer (32 frames) which is filled with the OUT sample frames.
The POST shape (controlled by the knob next to the POST output) is then applied to the ring buffer content and written to the POST output.
This is simply an experimental feature that could have been moved to a completely different module. So yes, it's a bit confusing.
There are a few examples patches in the release, btw (e.g. BSP scanner cy 1.vcv or BSP scanner hh 1.vcv).
The POST shape knob and offset switch (bottom left) basically give you different flavours of noise in these patches.
And yeah, it aliases a lot so it makes a big difference which note is played. Makes nice sampler-fodder, though :-)

Ooh I haven't tried to dive into the example patches! Thanks for the tip!
I'm not sure if I understand the whole deal. The "shape" knob for the main output affects how the 16 inputs are scanned, but how does that work with the buffer? Do each of the frames/samples act as one input for the regular scanner? That's what I gather from it but I don't know if I'm on the right track.

There are two shape knobs: The first one controls the weights of the regular inputs, the second one (near the POST output) controls the weights of the sample frames in the output ringbuffer. The POST section is basically a 32-tap FIR filter whose coefficients (sample weights) are controlled by the (lower) shape knob.


Add Image View Component

Description
Now we're using view components i'm going back through the edit page and puling out complexity from the view logic.
Images are a good candidate for this as there's quite a few fields and hidden fields rendered based on the state of the image. And many images can be rendered on the same page in these different states.
It's a good test to whack in a component and unit test it.
Trello card
https://trello.com/c/OexrlFwM/900-add-view-components-where-appropriate-for-new-edit-edition-pages
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

closing as the image workflow is changing


feat: incorporate <svelte:html> into templates

Related to https://github.com/sveltejs/kit/pull/13065
TBH I don't love the fact that it's one more file for the minimal template and the library template, but it is what it is - and it scales much better.
Can only be merged after the related PR and the one in Svelte chore is actually released

Marking as draft, as the other PR are drafts too, and have received at least some pushback. We cannot merge this without the other PRs.


Terminal revive: bad contrast for restore message

Testing #133516
Using Default Light theme:

I doubt this matches our contrast ratio.
//cc @misolori

This actually does pass the color contrast ratio:

But I think it does feel a bit heavy so going with a lighter bg could be beneficial here. @meganrogge can we use 252 for the bg?


Improve TypeScript typings

Typings in all the packages can be improved further.
Someone who is into TypeScript may want to take a look at the packages in the monorepo :)
For local development guide, please see: https://github.com/fahad19/proppy/blob/master/MAINTAINERS.md

I'll take a pass on the repo. Can I swap tslint for eslint+@typescript-eslint and introduce a formatter (prettier) while I'm at it?

@caseyWebb: sure thing!


GCP API Gateway Gateway YAML example not been generated

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
https://www.pulumi.com/registry/packages/gcp/api-docs/apigateway/gateway/#example-usage
Click on the YAML tab and you see this:

The examples in other languages are present.

Affected area/feature

Thank you for reporting this!
This seems like it could be a bug, as other resources for AWS have generated YAML resources. We've had a few docs generation bugs due to the bridge, so we will investigate and move the the pulumi-terraform-bridge repo if related.

There's other docs generation issues in the vicinity: https://www.pulumi.com/registry/packages/gcp/api-docs/apigateway/apiiambinding/ just runs all the examples together, with no tabs for selecting the language (similarly https://www.pulumi.com/registry/packages/gcp/api-docs/apigateway/apiiammember/ and possibly others).
Not that I did an exhaustive search, but like Jasmine I don't see these problems elsewhere, so I'm inclined to keep it here for further investigation.

This appears to be fixed in the latest version of these docs.


[RFC] Supporting sparse semantic retrieval based on neural models

[RFC] Supporting sparse semantic retrieval based on neural models
Background
Dense retrieval based on neural models has achieved great success in search relevance tasks. However, dense methods use k-NN to search the most relevant docs, which consumes large amount of memory and CPU resource. It is very expensive.
Recent years, there are a lot of research about sparse retrieval based on neural models, such as DeepCT[1], SparTerm[2], SPLADE[3,4]. Since sparse retrieval fashion can be naturally implemented using inverted index, these methods are as efficient as BM25. After fine-tuning, neural sparse retrieval can achieve high search relevance on par with dense methods. Neural sparse methods also show great generalization ability. SPLADE defeats all dense methods in BEIR benchmark with the same setting. Thus we propose to implement support for sparse retrieval based on neural models.
Example Comparison 1: Dense and Sparse retrieval models on MS-MARCO dataset.

Type
Algorithm
Model
MRR@10
Latency*

Dense
Encoding
BERT-tasb
0.347
120ms

Dense
Late Interaction
ColBERT
0.359
193ms

Sparse
BM25
-
0.184
15ms

Sparse
Expansion
DeepCT
0.243
-

Sparse
Expansion
SparTerm
0.279
-

Sparse
Encoding
SPLADE-max^
0.340
117ms

Sparse
Encoding
DistilSPLADE-max
0.368
-

Sparse
Encoding
SPLADE-doc
0.322
19ms

*: All the experiments are conducted on a single OpenSearch node with 8 * 2.4G CPU cores and 32GB RAM.
^: SPLADE-max conducts a BERT model inference for query encoding, thus have similar latency to dense methods.
Example Comparison 2: Splade vs. Others on BEIR benchmarking dataset.

Metrics
BM25
ColBERT
TASB
SPLADE

Avg. NDCG@10
0.440
0.455
0.435
0.500

Winners in BEIR
2
2
0
11

All the above performance are extracted from the SpladeV2 paper.
Example Comparison 3: Splade vs. openai embedding on BEIR benchmarking subset.

Metrics
Ada
Babbage
Curie
Davinci
SPLADE

Avg. NDCG@10
0.490
0.505
0.509
0.528
0.527

Winners in BEIR
0
0
1
5
5

Above table is extracted from the paper of openai. The experiments are conducted on a subset of BEIR benchmark.
What are we going to do?

Implement api to search in the sparse semantic space, where the query can be encoded via either a simple tokenizer or a deep neural network.
Implement api to ingest documents in the form of sparse vectors (i.e. tokens and weights) generated by neural models.
Provide out-of-box model weights for neural sparse retrieval. The model should have good search relevance on general domains without fine-tuning.

Design
We are going to implement one IngestionProcessor for document sparse encoding and one QueryBuilder for sparse querying. Before ingestion or querying, we will have the sparse encoding model deploy via the ml-commons plugin and the ingestion processor will consequently invoke the prediction action for the encoding result. If query encoding is enabled, the query builder will also encode the queries via prediction actions while passing the query through a bert tokenizer when query encoding is disabled. Because the encoding result is in the form of sparse vector, it is very natural to adopt the term vector based Lucene index. Here is the architecture diagram.

Term Weight integration with Lucene
Suggested by the SPLADE paper, the relevance score is calculated following $r = \Sigma_{t \in T}w_t$ where $w_t$ is the weight of sparse term $t$ and $T$ is the intersection term set of query and document. Standard Lucene indices will only store TF(term frequency) and DF(document frequency), we will implement an analyzer that interprets term weights and stores into the payload attribute. Since the above formula is not a standard Lucene relevance scoring function, we will involve a PayloadScorer with a sum operator in the query.
The out-of-box Model
The schema of the sparse encoding model will be similar to SparTerm or SPLADE, where the input is a natural language sentence while the output is a sparse vector(in SPLADE, the sparse terms are BERT tokens). We will mainly focus on cross-domain optimization for a better relevance over different scenarios. The models are planned to be released in huggingface.co and have Appache 2.0 licence.
API
Ingestion Processor
The ingestion processor can be created with following API, where the field field_map can specify the fields need to be encoded and the new field names after encoding.
PUT /_ingest/pipeline/sparse-pipeline
{
    "description": "Calling sparse model to generate expanded tokens",
    "processors": [
        {
            "neural_sparse": {
                "model_id": "fousVokBjnSupmOha8aN",
                "field_map": {
                    "body": "body_sparse"
                }
            }
        }
    ]
}

Sparse Search Query
Similar to vector search based neural search, sparse retrieval is also bind with a query type called neural_sparse. One can search the field body_sparse (sparse encoded fields only) via the API below.
GET /test-index-3/_search
{
    "query": {
        "neural_sparse": {
            "body_sparse": {
                "query_text": "i be going",
                "model_id": "fousVokBjnSupmOha8aN",
                "tokenizer": "fousVokBjdfs4vb6gGdgYl"
            }
        }
    }
}

The fields model_id and tokenizer are optional, if model_id presents, the query executor will call the sparse model for query encoding, while if tokenizer presents, the executor will only encode the query via tokenization.
Reference
[1] Dai et al, Context-Aware Sentence/Passage Term Importance Estimation For First Stage Retrieval, arxiv.org. 2019.
[2] Bai et al, SparTerm: Learning Term-based Sparse Representation for Fast Text Retrieval, arxiv.org. 2020.
[3] Formal et al, SPLADE: Sparse lexical and expansion model for first stage ranking, SIGIR, 2021.
[4] Formal et al, SPLADE v2: Sparse lexical and expansion model for information retrieval, arxiv.org. 2021.
[5] Neelakantan et al, Text and Code Embeddings by Contrastive Pre-Training, arxiv.org. 2022.

This is really interesting! @model-collapse Could you include the proposed interfaces you are going to add and what they would look like?

Additionally, I believe Lucene has some features to support this case. See https://github.com/apache/lucene/issues/11799.

Hi @model-collapse,
Thanks for adding this RFC. I have couple of questions, so that I understand the proposal properly.

This new query type neural_sparse is getting mapped to what Query clause of Lucene/OpenSearch
This seems more like an analyser use case where indexed text is getting analzsed using a model that provides weights/preference to some words. Did we consider the alternative to model this as Analyzer?
During indexing to what field type of lucene these fields will be mapped to?
If sparse retrieval is as good as BM-25 what is the exact use case we want to target here?

Hi @model-collapse, Thanks for adding this RFC. I have couple of questions, so that I understand the proposal properly.

This new query type neural_sparse is getting mapped to what Query clause of Lucene/OpenSearch
This seems more like an analyser use case where indexed text is getting analzsed using a model that provides weights/preference to some words. Did we consider the alternative to model this as Analyzer?
During indexing to what field type of lucene these fields will be mapped to?
If sparse retrieval is as good as BM-25 what is the exact use case we want to target here?
As suggested by @jmazanec15 I think we should look into the github issue: Indexing method for learned sparse retrieval apache/lucene#11799 at lucene side. They were trying to add a similar functionality in lucene too.

---------------------------------------------------------1,

This query type is mapped into PayloadQuery with a base recall query(SpanOrTermQuery) and a PayloadScorer.
The relevance score calculation is different from BM25, thus it is not convenient to separate the implementation into Analyzer and Scorer.
Just like what we did in neural-search, the field_map field will cover this.
Just check the performance table. Sparse model can have better accuracy than BM25 but the efficiency is the same.

Hi @model-collapse, Thanks for adding this RFC. I have couple of questions, so that I understand the proposal properly.

This new query type neural_sparse is getting mapped to what Query clause of Lucene/OpenSearch
This seems more like an analyser use case where indexed text is getting analzsed using a model that provides weights/preference to some words. Did we consider the alternative to model this as Analyzer?
During indexing to what field type of lucene these fields will be mapped to?
If sparse retrieval is as good as BM-25 what is the exact use case we want to target here?
As suggested by @jmazanec15 I think we should look into the github issue: Indexing method for learned sparse retrieval apache/lucene#11799 at lucene side. They were trying to add a similar functionality in lucene too.

Hi @navneet1v , for question 4, sparse models have advantages over both KNN and BM25:

compared with KNN

if both fine-tuned

sparse models can have performance on par with KNN, but cosume much less memory, and has better search latency

if both not fine-tuned

sparse models are better at search relevance, memory and latency

compared with BM25

They both use inverted index. For search scenerio, sparse models may have a little more flops because they may expand the document vocab. But this is not a critical concern for search latency. Sparse models have better search relevance even without fine-tuning. If sparse models are fine-tuned, the performance gap between BM25 and them are much larger.

Hi @model-collapse, Thanks for adding this RFC. I have couple of questions, so that I understand the proposal properly.

This new query type neural_sparse is getting mapped to what Query clause of Lucene/OpenSearch
This seems more like an analyser use case where indexed text is getting analzsed using a model that provides weights/preference to some words. Did we consider the alternative to model this as Analyzer?
During indexing to what field type of lucene these fields will be mapped to?
If sparse retrieval is as good as BM-25 what is the exact use case we want to target here?
As suggested by @jmazanec15 I think we should look into the github issue: Indexing method for learned sparse retrieval apache/lucene#11799 at lucene side. They were trying to add a similar functionality in lucene too.

@navneet1v

This query type is mapped into PayloadQuery with a base recall query(SpanOrTermQuery) and a PayloadScorer.
The relevance score calculation is different from BM25, thus it is not convenient to separate the implementation into Analyzer and Scorer.
Just like what we did in neural-search, the field_map field will cover this.
Just check the performance table. Sparse model can have better accuracy than BM25 but the efficiency is almost the same.

@model-collapse I cannot see where we are comparing the latency of BM-25 with the sparse retrieval?
For #4 , we compared on the accuracy but I will be really interested in latency.

Hi @model-collapse, Thanks for adding this RFC. I have couple of questions, so that I understand the proposal properly.

This new query type neural_sparse is getting mapped to what Query clause of Lucene/OpenSearch
This seems more like an analyser use case where indexed text is getting analzsed using a model that provides weights/preference to some words. Did we consider the alternative to model this as Analyzer?
During indexing to what field type of lucene these fields will be mapped to?
If sparse retrieval is as good as BM-25 what is the exact use case we want to target here?
As suggested by @jmazanec15 I think we should look into the github issue: Indexing method for learned sparse retrieval apache/lucene#11799 at lucene side. They were trying to add a similar functionality in lucene too.

Hi @navneet1v , for question 4, sparse models have advantages over both KNN and BM25:

compared with KNN

if both fine-tuned

sparse models can have performance on par with KNN, but cosume much less memory, and has better search latency

if both not fine-tuned

sparse models are better at search relevance, memory and latency

compared with BM25

They both use inverted index. For search scenerio, sparse models may have a little more flops because they may expand the document vocab. But this is not a critical concern for search latency. Sparse models have better search relevance even without fine-tuning. If sparse models are fine-tuned, the performance gap between BM25 and them are much larger.

@zhichao-aws, I understand the memory footprint between dense and sparse will be high. Also, my question was never about comparing dense and sparse vectors. From memory and latency yes sparse vector will work well. I want to compare Sparse vectors with OpenSearch Text Search. The three parameters, I would at-least like to see the comparison is:

Search Latency
Relevance
Memory Footprint.
From the proposal I can see we provided info for 2 only. Can we add details for 1 and 3 too.

@navneet1v , since the implementation details have large impact on Latency/Memory metrics, it's hard to give a concrete number in RFC state within the framework of opensearch. However, the search latency with other engines supporting inverted index is also a strong indicator to illustrate their efficiency:

The above figure comes from this paper, and the first 3 items are Splade-series models. They use PISA and Anserini instead of opensearch. With several optimizations, Splade's latency is of the same magnitude with BM25. And Splade-doc's latency is within twice.
Note that there are hyperparameters to control the "expansion" of sparse models, the same algorithm can still have different search relevance and efficiency(usually negatively correlated), which require us to find a balance point.

One clarification question, Do we need support of sparse vector data type in k-NN plugin similar to knn_vector(dense vector)?

One clarification question, Do we need support of sparse vector data type in k-NN plugin similar to knn_vector(dense vector) to support sparse vector indexing/search?

No, we can use lucene engine to index and search sparse vectors. We will implement this feature in neural-search and ml-commons.

@zhichao-aws sorry could you explain which data type you would use for indexing sparse vectors?

@zhichao-aws sorry could you explain which data type you would use for indexing sparse vectors?

Hi @vamshin , for sparse vectors we need to build a machanism to store and index term-weights pairs. Our initial proposal was to use normal opensearch text field (i.e. TextFieldMapper) to index terms and put terms' weights in payload attribute. This requires us to build a new analyzer to parse the input text and encode the payload. For searching, we build a new query clause to decode the payload and sum the terms' weights.
After more research, we find that the lucene FeatureField is more straightforward and extensible. If we choose FeatureField, we'll introduce a new field like "sparse_vector" by implementing a new wrapper FieldMapper to transform the input term-weight map to lucene FeatureField (the wrapper FieldMapper can be put at neural-search plugin or somewhere else, we can discuss about that). For searching, we'll build a new query clause.
For both design we have finished some POC code and proved they're workable. We'll run some benchmarking test to examine their execution efficiency.

Hi @model-collapse , @zhichao-aws
Putting some high level thoughts on the APIs provided in this RFC:

We are trying to model the APIs just like we did for the dense vector use-case. I think we should create a separate github issue where we provide all the different alternatives that we have considered while coming up with the interface provided on top.

Sparse vector is a new field for the users. I think we should do more deep-dive on how we want to model this field type. Few things that we should ans is if a user do a match all query what will be the output of that query will it have a field body_sparse in the source? if yes then what will be its value? etc.

Similarly goes for the query. neural query clause was simple because it was just providing an abstraction over the dense vector query.

Is the ingestion pipeline is the only option to ingest data in the sparse_vector field? what if a user runs the sparse model outside OpenSearch and wants to ingest the response(sparse vector) directly in the index. How that can be done?

Hi @model-collapse , @zhichao-aws Putting some high level thoughts on the APIs provided in this RFC:

We are trying to model the APIs just like we did for the dense vector use-case. I think we should create a separate github issue where we provide all the different alternatives that we have considered while coming up with the interface provided on top.
Sparse vector is a new field for the users. I think we should do more deep-dive on how we want to model this field type. Few things that we should ans is if a user do a match all query what will be the output of that query will it have a field body_sparse in the source? if yes then what will be its value? etc.
Similarly goes for the query. neural query clause was simple because it was just providing an abstraction over the dense vector query.
Is the ingestion pipeline is the only option to ingest data in the sparse_vector field? what if a user runs the sparse model outside OpenSearch and wants to ingest the response(sparse vector) directly in the index. How that can be done?

Hi @navneet1v , these are really good questions. We did many investigations about different routines and debated much about the user interface. We will create a seperate issue to list our proposal and all alternatives we've considered.

Hi all, Please create a doc issue or PR ASAP if this has doc implications for 2.11. Thanks.

Great feature, I look forward to it and I hope it is going to be generally available on the upcoming 2.11 release in October.

Are the out-of-box-models be fine-tuneable? Are you going to publish the fine-tuning process for them?

Are the out-of-box-models be fine-tuneable? Are you going to publish the fine-tuning process for them?

We'll release the weights and structure for the models, users can fine-tune them using pytorch or other frameworks. But sadly fine-tuning model in Opensearch is out-of-scope for this release.

Are the out-of-box-models be fine-tuneable? Are you going to publish the fine-tuning process for them?

Since we'll release the weights and structure of our model, users can fine-tune them using Pytorch or other frameworks. However, sadly the fine-tuning process is out of scope for this release. If you believe it is important for this feature, let's create a feature request issue and call for comments. This will help us make the decision of future work.

Are the out-of-box-models be fine-tuneable? Are you going to publish the fine-tuning process for them?

Since we'll release the weights and structure of our model, users can fine-tune them using Pytorch or other frameworks with their own implementation. Sadly the fine-tuning process is out of scope for this release. If you believe it is important for this feature, let's create a feature request issue and call for comments. This will help us make the decision of future work.

Thanks for the clarification. What I meant is just giving a fine-tuning example in the documentation or as a blog post, just like the example the team has posted for fine-tuning embedding models.

Does it work with a KNN query as well? My team uses a custom inference server for all our ML models.

Does it work with a KNN query as well? My team uses a custom inference server for all our ML models.

Hi @yudhiesh , KNN query is used for dense vectors and neural sparse needs sparse vectors, like {"a":1, "b":2, "c":1.2, ...}.
If your purpose is using custom inference server to generate sparse vector, then use raw sparse vector for query, then the answer is yes. Query by raw sparse vectors will be supported in 2.14 (if everything goes will, 2.14 will release in several few days).
We have put our neural sparse model on huggingface (opensearch-project/opensearch-neural-sparse-encoding-v1) and we have a demo deployment script to deploy neural sparse model in SageMaker. It can be a reference here

Does it work with a KNN query as well? My team uses a custom inference server for all our ML models.

Hi @yudhiesh , KNN query is used for dense vectors and neural sparse needs sparse vectors, like {"a":1, "b":2, "c":1.2, ...}.
If your purpose is using custom inference server to generate sparse vector, then use raw sparse vector for query, then the answer is yes. Query by raw sparse vectors will be supported in 2.14 (if everything goes will, 2.14 will release in several few days).
We have put our neural sparse model on huggingface (model link) and we have a demo deployment script to deploy neural sparse model in SageMaker. It can be a reference here

Great thanks for the quick response!


[fix] consider paths.assets for version.json

fix: https://github.com/sveltejs/kit/issues/4188
Checklist
I checked behavior with adapter-node.

[x] It can fetch version.json if kit.paths.assets has custom value
[x] It can fetch version.json if kit.paths.assets doesn't set value

I couldn't find how to write tests.
So could you please teach me if there are some sample existing tests?
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Thanks — this would fix the issue (agree that it's quite hard to add a test for this, I suppose we could set paths.assets to http://localhost:${TEST_PORT}/assets and check it works, but that feels like a task for another day) but it's not 100% future-proof, because one day we'd like to introduce dynamic basepaths (#595) so that Kit apps work on IPFS/the internet archive/situations where the basepath is set by an environment variable/etc.
I think we can support that by just using paths.assets instead of paths.base (if assets is unset, it defaults to base) — 5cb887020877461b6302f8b6a083e9b5422ef27e

VITE_SVELTEKIT_APP_VERSION_FILE is super specific name, so I assigned complete path.
But I agree with you that building complete path at runtime is more flexible if we consider dynamic basepath.👍


React to JsonPatch exception message changes.

Build was failing because of https://github.com/aspnet/JsonPatch/commit/e46ba481c8b281b04fbb682ca4db92bee6799d24.

@jkotalik,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot


federation: cluster replicasets should not be scaled down when federated rs is deleted using kubectl

 Issue by nikhiljindal
Tuesday Dec 06, 2016 at 22:42 GMT
Originally opened as https://github.com/kubernetes/kubernetes/issues/38223

Steps to repro:

fedkubectl create -f myrs.yaml
fedkubectl delete rs myrs

where fedkubectl is kubectl --context=federation-cluster
Expected:
myrs should be deleted from federation control plane. myrs in underlying clusters should be left as is.
Actual:
myrs is deleted from federation control plane fine, but myrs in all underlying clusters are also scaled down to zero. This should not happen. They should be left as is.
Note that this problem exists only when replicaset is deleted using kubectl. Deleting the replicaset directly using the REST API works fine.
cc @kshafiee @kubernetes/sig-cluster-federation

 Comment by nikhiljindal
Tuesday Dec 06, 2016 at 22:43 GMT

From what I can tell, this problem has existed since 1.4 when we first introduced federated replicasets (as alpha).

 Comment by nikhiljindal
Tuesday Dec 06, 2016 at 22:58 GMT

Ref  https://github.com/kubernetes/kubernetes/issues/32826 to add kubectl tests

 Comment by kshafiee
Tuesday Dec 06, 2016 at 23:10 GMT

@XiaoningDing

 Comment by nikhiljindal
Wednesday Apr 26, 2017 at 22:32 GMT

We updated kubectl delete to perform cascading deletion by default so deleting federation replicaset deletes replicasets from underlying clusters as well. So that works fine.
The same problem however now exists for kubectl delete --cascade=false which we need to fix.

 Comment by quinton-hoole
Friday Sep 08, 2017 at 01:00 GMT

Required for GA.

cc @nikhiljindal


Scanning with 3 lens iPhones isn't possible

Since the iOS CameraViewHandler always uses the BuiltInWideAngleCamera which doesn’t support close range focus for devices with 3 lenses and therefore scanning with 3 lens iPhones (e. g. iPhone 13 Pro & iPhone 15 Pro Max) isn’t possible. Based on https://github.com/JimmyPun610/BarcodeScanner.Mobile/issues/202#issuecomment-1834844897 I was able to adapt the CameraViewHandler as follows so sthat scanning is also possible with iPhones with 3 lenses.
Inside UpdateCamera() I replaced following code:
_captureDevice = AVCaptureDevice.GetDefaultDevice(
    AVCaptureDeviceType.BuiltInWideAngleCamera,
    AVMediaTypes.Video,
    VirtualView?.CameraFacing == CameraFacing.Front ? AVCaptureDevicePosition.Front : AVCaptureDevicePosition.Back);
_captureDevice ??= AVCaptureDevice.GetDefaultDevice(AVMediaTypes.Video);

with following code:
var position = VirtualView.CameraFacing == CameraFacing.Front ? AVCaptureDevicePosition.Front : AVCaptureDevicePosition.Back;
_captureDevice = GetCaptureDevice(position);

and the implementation of GetCaptureDevice() looks as follows:
private static AVCaptureDevice GetCaptureDevice(AVCaptureDevicePosition position)
 {
     AVCaptureDevice captureDevice = AVCaptureDevice.GetDefaultDevice(AVCaptureDeviceType.BuiltInTripleCamera, AVMediaTypes.Video, position);
     captureDevice ??= AVCaptureDevice.GetDefaultDevice(AVCaptureDeviceType.BuiltInDualCamera, AVMediaTypes.Video, position);
     captureDevice ??= AVCaptureDevice.DevicesWithMediaType(AVMediaTypes.Video.GetConstant()).FirstOrDefault( d => d.Position == position);

     return captureDevice;
 }

Would it be bossible to add support for 3 lens iPhone scanning based on the CameraViewHandler modifications described in this issue?

Thank you very much for great feedback. I'll implement this ASAP in next release

Sounds good, thank you!

Added in 1.2.1. Have a go at testing it and report back any bugs

It is working for my iPhone 15 Pro with 3 lenses. You're awesome, @afriscic !


Update Chart and add error-printing when not writeable

Alright, so a few things I got to note here:

[ ] The chart.json should not live in the git repo
[ ] Would be awesome if we could visualize multiple milestones in one view (Could be a new PR)
[ ] Don't put all of the code in an else block, instead use PHP's exit functionality

I agree it shouldn't live in the Git repo, but then we'll need something to use in development without setting up the file with permissions. As for else vs exit, I've always thought of exit as evil, but I suppose it makes more sense since this is effectively just a bash script.
Multiple milestones should definitely be a new PR.

I'm going to close rather than rebase this, as some work has been merged from other branches.


Add a save as PNG and/or SVG button

This will require that the stylesheet is integrated into the result. Interestingly, that might mean that having the excess CSS mentioned in #39 might actually be of benefit.

Getting close to completing this one. Above shows the dropdown menu of saving options (JSON, SVG, or PNG). One thing that none of them allow is saving while highlighting a tree or edge; I don't know how important that use case is. The only work around I can think of would be highlighting the tree then pushing a combination of keyboard keys which are mapped to a save option. This seems cumbersome and may not work well when multiple ARGs are plotted to the screen, like in a Jupyter Notebook.

A small note, opening the SVG in Illustrator does not properly import all styles (only inline styles, which are rarely used in the visualizer). Though all styles can be manually added or changed within Illustrator, this can be tedious. Styles are properly load when opening in a web browser.


feat: port Algebra.Order.Field.Canonical.Defs

Mathlib SHA: fc2ed6f838ce7c9b7c7171e58d78eaf7b438fb0e
Sorry, I forgot to push the mathport version. The only manual changes are:

breaking two align lines that were above 100 chars.
the deletion of a @[protect_proj] before line 20, which returned an error. I don't know whether that is the right thing to do or not. The wiki says I should protect all fields, but that class only extends two others and does not introduce new fields.
replace one => by ↦

bors merge


Black border in the bounds of a polygon with bound tooltip

Checklist

[X] I've looked at the documentation to make sure the behavior isn't documented and expected.
[X] I'm sure this is an issue with Leaflet, not with my app or other dependencies (Angular, Cordova, React, etc.).
[X] I've searched through the current issues to make sure this hasn't been reported yet.
[X] I agree to follow the Code of Conduct that this project adheres to.

Steps to reproduce
You can check what happens here: https://plnkr.co/edit/a3ZpKDqAPqlA80Db
The example is very minimal
let geojson = L.geoJSON(geojsonData).addTo(map)
let geojsonCenter = geojson.getBounds()?.getCenter()

let tooltip = L.tooltip()
tooltip.setContent("test")
tooltip.setLatLng(geojsonCenter)
geojson.bindTooltip(tooltip)

Expected behavior
No black border around the polygon bounds
Current behavior
A black border is shown in the bounds of a clicked polygon with a tooltip

Minimal example reproducing the issue
https://plnkr.co/edit/a3ZpKDqAPqlA80Db
Environment

Leaflet version: 1.9.4
Browser (with version): Chrome 117.0.5938.132
OS/Platform (with version): Ubuntu but I think it happens everywhere

I noticed that it happens due to the MultiPolygon, because if I bind the tooltip to a single feature inside the polygon it doesn't happen. I don't know if that's ok as default behaviour

Duplicate of https://github.com/Leaflet/Leaflet/issues/8659.


HBASE-24550 Passing '-h' or '--help' to bin/hbase doesn't do as expected

Closing this PR as branch-1.0 is not active. branch-1 PR is sufficient.
Thanks


I created a thin wrapper around this tool to use it from the CLI

https://github.com/fearphage/cronstrue-cli
Usage
cronstrue-cli git:(main) npx --yes fearphage/cronstrue-cli '0 30/10 * * * *'
Every 10 minutes, starting at 30 minutes past the hour

I considered a PR, but this was a quick fix that I needed.

Neat!  Thanks!


Feature/query v2 sse

Add query v2 sse support

(Jove Github Bot) added it to the current sprint.

(Jove Github Bot) moved this ticket out of the GitHub project(up to 1200 tickets for one project).


Update indent in api/README.md

See change - The example was missing an indent

Coverage remained the same at 94.616% when pulling 0aec3e7f9c9ecdac5306f965c45b421cd0202950 on tmarshall:tmarshall/indent into 4d526048c3d71e82bf42a2ebe7760b243ba046dd on FormidableLabs:master.

🙌 thank you!


[Impeller] tiny scalars can break the mask blur

Spawned from https://github.com/flutter/flutter/issues/152778
The numbers were chosen specifically since numbers closer to zero have no issue.
observed result
A black screen.
expected result
A blurred circle.
reproduction
import 'package:flutter/material.dart';

void main() {
  runApp(const Test());
}

class Test extends StatefulWidget {
  const Test({super.key});

  @override
  State<Test> createState() => _TestState();
}

class _TestState extends State<Test> {
  @override
  void initState() {
    super.initState();
  }

  @override
  void dispose() {
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Stack(
      textDirection: TextDirection.ltr,
      children: [
        CustomPaint(
          painter: Painter(),
        )
      ],
    );
  }
}

class Painter extends CustomPainter {
  Painter();

  @override
  void paint(Canvas canvas, Size size) {
    canvas.scale(9.999999999999991e-18);
    final Paint paint = Paint()
      ..color = const Color(0xFF66BBFF)
      ..maskFilter = MaskFilter.blur(BlurStyle.normal,<PHONE_NUMBER>0000008000.0);
    canvas.drawCircle(Offset.zero,<PHONE_NUMBER>0000040000.0, paint);
  }

  @override
  bool shouldRepaint(Painter oldDelegate) => true;
}

@gaaclarke is this related to the last issue you filled about the rrect blur artifacts?

@gaaclarke is this related to the last issue you filled about the rrect blur artifacts?

Sorry, context lost.  This was spawned from an issue ian was reporting where he was doing some galactic scale animations.  I don't remember it being related to anything else.
I ran this on 7ec6083bed and it no longer renders black.  It instead is rendering a circle that isn't blurry.


Device Flow: cleanup expired device codes

For expired grants automatic (periodically) cleanup is supported.
This would also be nice for expired device code as well.

This has been a post-it note on my desk for too long... Thanks for the reminder

Initial implementation added to TokenCleanup: https://github.com/IdentityServer/IdentityServer4/pull/3200

Initial implementation added to TokenCleanup: #3200

Thank you for the quick response and implementation.
I will watch the next release closely.


Allow SharedArrayBuffer to be used by extensions in vscode.dev (using cross-origin isolation)

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.62.3 (vscode.dev)
Browser Version: Chrome 96

Hi,
I am trying to make our extension (https://github.com/eclipse/che-che4z-lsp-for-hlasm) work in browser environment so it can be used with web version of vscode. It is written in C++ and we are using emscripten to compile it into WebAssembly. The C++ backend uses multiple threads, which translate into web workers and emscripten uses SharedArrayBuffer to communicate between them. However SharedArrayBuffer is not available on vscode.dev, since the site does not use cross-origin isolation - see this: https://developer.chrome.com/blog/enabling-shared-array-buffer/
Steps to Reproduce:

Open vscode.dev in your browser (I tried with Chrome 96).
Install this extension: https://marketplace.visualstudio.com/items?itemName=mbali.hlasm-browser-dev
Open arbitrary folder on your computer (empty one is enough)
Create a new empty file
Open developer tools of browser
Choose HLASM as language of the file
In the Console of developer tools, this message shows:

And of course, the extension is not enabled.

Additional Info:
I have managed to get it working by starting chrome with disabled security:
chrome.exe --enable-features=SharedArrayBuffer --disable-web-security --user-data-dir="<some-folder-on-your-computer>"

If I reproduce those steps with chrome started this way, the extensions works as expected (just try to type something and there will by some diagnostics).
BTW I have opened a similar issue (https://github.com/microsoft/vscode-test-web/issues/14) in the vscode-test-web repository, but nobody noticed it there, so I created this issue with reproducible example.

Related: https://github.com/microsoft/vscode/issues/116715

March to investigate. Enabling crossOrigin isolation can have some ripple on things that we load and those need CORP or CORS to continue to work

Enabling this unfortunately has unwanted side-effects on extensions using webview. I believe we are blocked until browsers relax restrictions for embedded iframe a bit, see https://github.com/microsoft/vscode/pull/145539#issuecomment-1090840251

We will do more exploring during June

Plan for July

add support for a url-query like ?vscode-coi (cross origin isolation)
when present the server responds with the COOP/COEP headers
this enables COI for the renderer
when creating descendant resources (e.g. worker based extension host, web views) we check for globalThis.crossOriginIsolated and use the the same url-query so that our CDN can respond with the COEP header for them
this enables COI for the web worker extension host
(optionally set a cookie so that subsequent loads don't need the vscode-coi query)

Once we have that we can explore and see what all breaks - webviews loading 3rd party resources, auth, embedding...

We're building a internal wasm ui design/edtior as a vscode plugin which needs SharedArrayBuffer feature, expect this to ship in July!

This is now live on insiders.dev. You have to use the vscode-coi-query argument to enable cross-origin isolation, e.g https://insiders.vscode.dev/?vscode-coi.
Note that for now this is only for insiders.vscode.dev - stable (vscode.dev) will follow with the normal release flow and github.dev will follow later, esp after having gained more insights. Also expect that some external resources aren't loading - they need the CORP header to be set. Please file issues for those cases. Last, this is for web only - https://github.com/microsoft/vscode/issues/116715 tracks a similar effort for desktop

To verify

open insiders.vscode.dev with the ?vscode-coi query
make sure everything loads
test a view webview extensions and see if they work or not


Experimental

This PR changes a few things

VariationalMergingModel no longer returns the mean prediction. Instead it returns the sample value(s).
VariationalMergingModel has a new method prediction_mean_stddev which computes the first two moments for predictions. These are both written to the predictions file now as Ipred/SigIpred. Internally the method uses scipy and is not differentiable.
The DataManager class now has a build_model method which is used for constructing models in the top level careless.py script.
The CLI now serializes the DataManager instance for a given run into *_data_manager.pickle
The CLI now serializes the model weights for a given run into *_weights

One important consequence of this is that models can now be loaded by

unpickling the data manager
calling build_model
calling model.load_weights

Codecov Report

Merging #30 (49c4123) into main (a0d98d9) will increase coverage by 0.17%.
The diff coverage is 85.52%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   86.41%   86.58%   +0.17%
==========================================
  Files          38       38
  Lines        1229     1267      +38
==========================================
+ Hits         1062     1097      +35
- Misses        167      170       +3

Flag
Coverage Δ

unittests
86.58% <85.52%> (+0.17%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

careless/careless.py
59.15% <63.63%> (-4.18%)
:arrow_down:

careless/io/manager.py
91.90% <86.00%> (-2.54%)
:arrow_down:

careless/models/merging/variational.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0d98d9...49c4123. Read the comment docs.

i'm still a little stumped as to why the RiceWoolfsonReferencePrior test keeps failing due to numerical issues. so, i am going to xfail that test for the time being. that class is not accessible from the CLI at the moment anyway.