Add zipcode service

In this PR, we add an service that wraps the ZipcodeQueryAPI from
http://api.zippopotam.us/us/{zipcode}
as well as tests
Closes #16

LGTM


Install docker and change executor

Install docker to deployed VM
Change gitlab runner executor from shell to docker

another version will be installed


Gevent and KafkaClient.copy patch?

This is referencing #145 I'm seeing copy failing still when monkey patching and then constructing a multiprocess. If this was punted on that's cool I can look at adding my own multiprocessing or threading pool to scale my upstream socket reads but gevent is nicer for this pattern.
versions:
gevent==1.0.1
kafka-python==0.9.2
Works:
    >>> from kafka.client import KafkaClient
    >>> from kafka.producer import SimpleProducer
    >>> kclient = KafkaClient("broker1,broker2,broker3")
    No handlers could be found for logger "kafka"
    >>> kproducer = SimpleProducer(kclient,batch_send=True, batch_send_every_n=100,  batch_send_every_t=10)

Fails:
    >>> import gevent.monkey
    >>> gevent.monkey.patch_all()
    >>> kclient = KafkaClient("broker1,broker2,broker3")
    >>> kproducer = SimpleProducer(kclient,batch_send=True, batch_send_every_n=100, batch_send_every_t=10)
  Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/kafka_python-0.9.2-py2.7.egg/kafka/producer.py", line 240, in __init__
    batch_send_every_t)
  File "/usr/local/lib/python2.7/dist-packages/kafka_python-0.9.2-py2.7.egg/kafka/producer.py", line 143, in __init__
    self.client.copy(),
  File "/usr/local/lib/python2.7/dist-packages/kafka_python-0.9.2-py2.7.egg/kafka/client.py", line 235, in copy
    c = copy.deepcopy(self)
  File "/usr/lib/python2.7/copy.py", line 190, in deepcopy
    y = _reconstruct(x, rv, 1, memo)
  File "/usr/lib/python2.7/copy.py", line 334, in _reconstruct
    state = deepcopy(state, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 257, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 257, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/usr/lib/python2.7/copy.py", line 190, in deepcopy
    y = _reconstruct(x, rv, 1, memo)
  File "/usr/lib/python2.7/copy.py", line 334, in _reconstruct
    state = deepcopy(state, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 257, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/usr/lib/python2.7/copy.py", line 190, in deepcopy
    y = _reconstruct(x, rv, 1, memo)
  File "/usr/lib/python2.7/copy.py", line 334, in _reconstruct
    state = deepcopy(state, memo)
  File "/usr/lib/python2.7/copy.py", line 163, in deepcopy
    y = copier(x, memo)
  File "/usr/lib/python2.7/copy.py", line 257, in _deepcopy_dict
    y[deepcopy(key, memo)] = deepcopy(value, memo)
  File "/usr/lib/python2.7/copy.py", line 182, in deepcopy
    rv = reductor(2)
TypeError: cannot serialize 'Hub' object

Yep, this is broken for me too. +1. I worked around with async=False for now.

It'd be good if this was fixed to allow proper use in gevent-based applications.

In my opinion, gevent works well (increase throughput) if there are lots of independent connections. As for each green thread, it can use an independent connection. However kafka-python does not maintain a  connection pool for each broker. So for current kafka-python, gevent could only work properly when publishing messages to different brokers (each broker has a owned connection) at  the same time.
We'd better to implement a connection pool if we want to use gevent to increase throughput. Other option could be integrated with Tornado.

Most of the inner-workings of kafka-python have changed, so I'm going to close this and only keep open a single 'work with kombu' issue.


Sent document template failed.

Hi DocuSign
I am using the latest java client version 3.9.0-RC-1 in Test environment. OAuth Login is passed, and then I sent doc to end user by template id, and got failed message like this:
Exception: com.docusign.esign.client.ApiException: Error while requesting server, received a non successful HTTP code 401 with response Body: '{
  "errorCode": "PARTNER_AUTHENTICATION_FAILED",
  "message": "The specified Integrator Key was not found or is disabled. An Integrator key was not specified."
}'

Please help to check this issue.
my code:
	public void sendEnvelopeDoc(String accessToken, UserInfo userInfo, ApiClient apiClient) {
		apiClient.setBasePath(userInfo.getAccounts().get(0).getBaseUri() + "/restapi");
		Configuration.setDefaultApiClient(apiClient);
		String accountId = userInfo.getAccounts().get(0).getAccountId();
		try {
			// create a new envelope to manage the signature request
			EnvelopeDefinition envDef = new EnvelopeDefinition();
			envDef.setEmailSubject("DocuSign for Genscript - Sample MC.org Sales Contract Signature Request");

			// assign template information including ID and role(s)
			envDef.setTemplateId("ddda5bd8-78c5-4588-b8f2-88243992bfb9");

			// create a template role with a valid templateId and roleName and
			// assign signer info
			/*
			 * TemplateRole tRole = new TemplateRole();
			 * tRole.setRoleName("manager"); tRole.setName("[SIGNER_NAME]");
			 * tRole.setEmail("[SIGNER_EMAIL]");
			 *
			 * // create a list of template roles and add our newly created role
			 * java.util.List<TemplateRole> templateRolesList = new
			 * java.util.ArrayList<TemplateRole>();
			 * templateRolesList.add(tRole);
			 *
			 * // assign template role(s) to the envelope
			 * envDef.setTemplateRoles(templateRolesList);
			 */

			// send the envelope by setting |status| to "sent". To save as a
			// draft set to "created"
			envDef.setStatus("sent");

			// instantiate a new EnvelopesApi object
			EnvelopesApi envelopesApi = new EnvelopesApi(apiClient);

			// call the createEnvelope() API
			EnvelopeSummary envelopeSummary = envelopesApi.createEnvelope(accountId, envDef);
		} catch (ApiException ex) {
			System.out.println("Exception: " + ex);
		} catch (Exception e) {
			System.out.println("Exception: " + e.getLocalizedMessage());
		}
	}

Hello @JunweiDuan,
I apologize for the slow reply to your question. We have reorganized so we can answer your questions faster.
If you haven't already solved your problem, I think the issue is that you have not specified the access token that should be used in the API call.
You can do it as follows:
        ApiClient apiClient = new ApiClient(basePath);
        apiClient.addDefaultHeader("Authorization", "Bearer " + accessToken);

Also, I suggest that you check out the Java example launcher. It includes many scenarios and code examples for each.


initial upload

replaces hcluster.js by @cmpolis
in general, faster and more efficient than hcluster.js, with equivalent functionality
more modern javascript syntax to be cleaner and more readable

Added a github actions workflow to publish package to npm. Don't merge until these two questions are answered:
https://github.com/mikeal/merge-release/issues/13#issuecomment-597678620
https://github.com/mikeal/merge-release/issues/9#issuecomment-597668069

@dongbohu @dhimmel Could you take a quick look at this commit regarding github actions, and this specific action.

The git action part looks good to me too.


A Darcula theme would be nice

A Darcula theme based on Android Studio/IntelliJ's IDES would be 👍

We already have a Darcula (Dracula) theme 👍

Hi @mfix22, quick follow-up on this issue:
I don't see Dracula anymore, only Dracula Pro. But Dracula Pro is different from IntelliJ's Darcula:

So I'm thinking it would make sense to add a Darcula theme, to look like what IntelliJ developers are expecting to get from a screenshot. What do you think?


How can I find your paper here?

How can I find your paper here?

This doesn't have an accompanying paper - actually, this is based on existing work on RRT algorithms. You may find an introduction to RRT and related publications at Steven LaValle's site.


165 growth rate comparisons

Figures comparing the growth rate of wastewater data and hospital admissions data using data interpolation and calculation of weekly or daily growth rate. Here I am defaulting to saving weekly as a part of the post-process pipeline.
See for example https://github.com/cdcent/cfa-forecast-renewal-ww/issues/771

Very neat. Just a couple things.
I'm kind of interested in the difference between the growth rates, but that involves a time shift due to different delays.

I was wondering if you think it makes sense to do something more quantitative with this e.g. find the R-squared across a range of lags (e.g. 1-15 days?)

Very neat. Just a couple things.
I'm kind of interested in the difference between the growth rates, but that involves a time shift due to different delays.

I was wondering if you think it makes sense to do something more quantitative with this e.g. find the R-squared across a range of lags (e.g. 1-15 days?)

Yeah, that would be a good idea, but I'm happy to kill this PR off as one that builds some functions. Maybe put a follow up issues or a multi-step analysis plan issue.


Android Template

Intellij
*.iml
.idea/workspace.xml
.idea/tasks.xml
.idea/gradle.xml
.idea/dictionaries
.idea/libraries
Please change into
Intellij
*.iml
.idea

@why168 thank you for this ticket.
Sorry, but I'll not change them. All templates come from https://github.com/github/gitignore repository.
You can create your own templates with User Templates in plugin's settings.


job failures

if a job fails, we dont get an email with a link to the output file etc to work out why, we have to try and work out where it is ourselves
also if it fails quickly it doesnt appear in the job list, or in the admin page

open CRM


Refactor signup screen as per mockups

@imaginator - as discussed, can you please provide a mockup.

I'll refactor based on your comments off this. I've removed the facility to choose domains (- we can add that later if necessary) ![sign-up screen]
Some rebranding.
(https://cloud.githubusercontent.com/assets/469572/5960519/6293f528-a7d6-11e4-8f0c-97d3660e6b00.png)


Replace/remove faker library

We should upgrade (or remove) the faker library to the forked package:

Faker.js helps users create large amounts of data for testing and development. The maintainer deliberately removed the functional code from this package. This appears to be a purposeful and successful attempt to make the package unusable. This is related to the colors.js CVE-2021-23567.
The functional code for this package was forked and can be found here.

Thanks for flagging. I don't know how exactly this got added (looks like something that snuck in when I converted from snowpack to vite.) Good catch!

@ChristiaanScheermeijer It looks like we have colors 1.4.0 as a dependency of<EMAIL_ADDRESS>Faker is at version 5.5.3. What am I missing here?


Using QR codes for infection cluster detection

Feature description
As repeatedly discussed by Prof. Drosten and others, it's crucial to identify infection clusters. Here is an idea towards this goal.

Create a website to print specific QR codes. These printed codes are used to identify rooms or closed spaces in general, such as class rooms in schools, offices, workplaces, restaurants, maybe even train compartments. Anybody can print a code and display it inside the room. Each QR code contains two pieces of information: a unique ID (generated by the backend behind the website) and some nickname for the room (not necessarily unique, such as "McDonald's at Berlin Hbf" or "Commerzbank München Office 210"; provided by the user who prints the QR code). For privacy concerns see below.

Use CWA to scan the QR code when you enter a room. The unique ID is stored only locally on the device, and the nickname of the room is stored only locally on the device in the form of some "my closed rooms diary" together with a time stamp, visible to the user of CWA.

If a user is tested positive, three things happen:

The user can send his/her list of room nicknames to the health authorities/Gesundheitsamt. This will improve the contact tracing interviews a lot: they will be more precise, more complete, and faster, because the list of visited rooms will help the patient to recall what happened during the last 14 days. For privacy, of course the user will be able to delete items from the list before sending, and of course sending the list will be voluntary at any time. This is the main benefit of the suggested feature. Additionally:

The scanned room IDs + timestamps will be used in the same way that CWA is working right now: The patient can (voluntarily) upload the list of scanned unique room IDs, CWA can download the list, and CWA can then display a warning to anybody who scanned the same ID at around the same time: "a covid patient was in the same room with you". This could be more precise than the current BLE for example in restaurants or offices with bad ventilation, where people can sit 20 m apart and still catch the virus through aerosols.

The server side of CWA can compute statistics on room IDs scanned by people tested positive to find infection clusters. These highly relevant room IDs can be downloaded by CWA, which can then display a warning such as "you were in a room where several people got infected. Please inform the health authorities". This could help the health authorities to prioritize some investigations above others. For example, they could call contacts of somebody who was found to be in a cluster situation earlier  than contacts of somebody who was not found to be in such a situation.

Problem and motivation
Current problem: contact tracing interviews are slow, and results are imprecise and incomplete. Imagine people had the option to quickly scan a QR code every time they go into a closed room. This would greatly improve the outcome of contact tracing interviews. Furthermore, it would have positive side effects as described above.
Is this something you're interested in working on
Yes

@jniediek
Thanks for your proposal!
Something very similar was already proposed here: #70, so maybe you could consider to close this Issue and comment your (very detailed) proposal there?
Thanks!

became part of #70


Created a maven plugin for the apicurio codegen

This PR adds a maven plugin for the apicurio codegen.  We could use this if we wanted to stop checking in the generated jax-rs classes and instead generate them at build time.
For an example of how it would be configured, see the sample-1/pom.xml file in test resources.  It shows how we can use the plugin and also compile the resulting generated code as part of the maven lifecycle.
Note: some maven plugins do not need the extra build-helper-maven-plugin to ensure that their generated code is added to the maven lifecycle.  I don't know how they do that and I haven't looked into it.  If anyone knows how that's done, it would be a nice improvement to this.  :)

Wow! I will look into the implementation, but I'm super happy to see this PR coming! 🙂

Would you be able to provide one integration test to guarantee the generator functionality?
E.g.:
https://github.com/fabric8io/kubernetes-client/tree/master/java-generator/it

Yes for sure - that's why it's still Draft status - testing is needed.  I have plans for that.
I also wanted to see if any of you @Apicurio/developers might know how to configure a custom maven plugin so that it adds the output directory as a generated source directory automatically, to eliminate the need for build-helper-maven-plugin.

OK @andreaTP have a look now?  Two nice new shiny tests.  :)  The widget API test is actually a pretty nice example of how to use the plugin.

The direction looks great, and I'm happy to discuss further how we want to proceed in this direction (overall with the Apicurio project). Thanks!

So clearly what this plugin enables is the ability for us to remove the generated JAX-RS classes from Apicurio Registry and instead use this plugin to generate those classes at build time.  Then any change to the API (the OpenAPI spec) can be done in a PR that includes only the OpenAPI changes and any implementation changes necessary.
If the API is changed to, for example, add a new endpoint or operation, then CI for the PR will fail because no implementation is provided for the new operation(s).
The only exception to this would be if an entirely new endpoint path were added.  In this case, the PR would be green because the codegen would just produce a new JAX-RS interface, with no implementation class.
I'd be interested to know what everything thinks about this workflow vs. what we do today (checking in the generated code).

Quick iteration:

The only exception to this would be if an entirely new endpoint path were added. In this case, the PR would be green because the codegen would just produce a new JAX-RS interface, with no implementation class.

in Apicurio Registry the build will fail anyhow down the line since the implementing classes will be missing methods, I think ...

I'd be interested to know what everything thinks about this workflow vs. what we do today (checking in the generated code).

The workflow that this plugin enables is the one I'm used to, the biggest downside is that it's not integrated with Apicurio Studio in any specific way.
Not committing the sources requires more careful tracking of the versions of the codegen and relies on the fact that the codegen has to be completely idempotent (which should be the case already).
Happy to hear other opinions as well!

Quick iteration:

The only exception to this would be if an entirely new endpoint path were added. In this case, the PR would be green because the codegen would just produce a new JAX-RS interface, with no implementation class.

in Apicurio Registry the build will fail anyhow down the line since the implementing classes will be missing methods, I think ...

This is only usually true.  :)  If a new top level path is introduced, it will result in a brand new java Interface.  So instead of the implementation class missing some newly added methods, there will be a total lack of an implementation class for a new interface.  Which will pass the build.  I think it's probably OK though - if you introduce a new endpoint and then don't implement it, then you probably shouldn't be writing software.  :)

I'd be interested to know what everything thinks about this workflow vs. what we do today (checking in the generated code).

The workflow that this plugin enables is the one I'm used to, the biggest downside is that it's not integrated with Apicurio Studio in any specific way. Not committing the sources requires more careful tracking of the versions of the codegen and relies on the fact that the codegen has to be completely idempotent (which should be the case already).

What sort of integration could we have with Studio/Designer if we use this approach?  I'm thinking, for example, that we simply need a way to open a draft GitHub PR with the new version of the openapi.json file.  Then developer is then responsible for checking out the branch for that PR and implementing the changes.  Is there more we can do?
+1 that the codegen needs to be idempotent.  That's surely the case now, and should remain so as long as we only generate Java interfaces and beans.

if you introduce a new endpoint and then don't implement it, then you probably shouldn't be writing software. :)

Agreed :-) if we ever want to enforce it anyhow we can probably leverage a CDI framework and generate a class that needs to retrieve a concrete implementation of all of the defined interfaces ... but probably too much trouble for very little gain ...

open a draft GitHub PR

this approach is probably feasible but introduces some complications/limitations when using forks(and expecting users' contributions).
I don't have a good answer here, a few extreme random thoughts I'm playing in my head with:

completely own even the generated code lifecycle -> e.g. you develop in designer and you can directly use a published library from your changes
tight integration with Git (and maybe github) -> e.g. we don't store the code at all and changes are going to be made directly in Git even when playing with Designer (using branches etc.)
Designer is always the source of truth -> e.g. code in main gets always compiled against the latest stored version of the API fetched on the fly from a designer/studio instance

and any middle ground in between :-P

This looks great! I have tried this with FM repository. These are my findings:
1) I think the plugin should lean more towards the convention over configuration pattern, i.e. some configuration options should be set by default. This is my plugin config with notes:
<plugin>
  <groupId>io.apicurio</groupId>
  <artifactId>apicurio-codegen-maven-plugin</artifactId>
  <version>1.0.12-SNAPSHOT</version>
  <executions>
    <execution>
      <phase>generate-sources</phase> // This should be a default phase + goal. User could specify <configuration> only
      <goals>
        <goal>generate</goal>
      </goals>
      <configuration>
        <projectSettings>
          <mavenFileStructure>false</mavenFileStructure> // This should be false for most use-cases, default is true
          <includeSpec>false</includeSpec> // This should be false for most use-cases, default is true
          <codeOnly>true</codeOnly> // This should be true for most use-cases, default is false
          <!-- <reactive>false</reactive> --> // OK default
          <!-- <cliGenCI>false</cliGenCI> --> // OK default
          <!-- <groupId>org.bf2</groupId> --> // OK default
          <!-- <artifactId>srs-fleet-manager-core</artifactId> --> // OK default
          <javaPackage>org.bf2.srs.fleetmanager.rest.publicapi</javaPackage> // OK required
        </projectSettings>
        <inputSpec>src/main/resources/srs-fleet-manager.json</inputSpec> // OK required
        <outputDir>src/main/java</outputDir> // This should probably be in "${project.build.directory}/generated-sources/<name based on input spec>" by default
      </configuration>
    </execution>
  </executions>
</plugin>

2) This is the diff with manual changes (without imports):
-  RegistryList getRegistries(@Min(1) @QueryParam("page") Integer page, @Min(1) @Max(500) @QueryParam("size") Integer size,
+  RegistryList getRegistries(@QueryParam("page") Integer page, @QueryParam("size") Integer size,
       @QueryParam("orderBy") String orderBy, @QueryParam("search") String search);

-  Registry createRegistry(RegistryCreate data) throws RegistryStorageConflictException, TermsRequiredException, ResourceLimitReachedException,
-          EvalInstancesNotAllowedException, TooManyEvalInstancesForUserException, TooManyInstancesException,
-          AccountManagementServiceException;
+  Registry createRegistry(RegistryCreate data);

-  Registry getRegistry(@PathParam("id") String id) throws RegistryNotFoundException;
+  Registry getRegistry(@PathParam("id") String id);

-  void deleteRegistry(@PathParam("id") String id) throws RegistryStorageConflictException, RegistryNotFoundException;
+  void deleteRegistry(@PathParam("id") String id);

-  Error getError(@PathParam("id") Integer id) throws ErrorNotFoundException;
+  Error getError(@PathParam("id") Integer id);

-  ErrorList getErrors(@Min(1) @QueryParam("page") Integer page, @Min(1) @Max(500) @QueryParam("size") Integer size);
+  ErrorList getErrors(@QueryParam("page") Integer page, @QueryParam("size") Integer size);

which consists of:

Adding additional parameter annotations
Adding checked exceptions

We should add support for those into the codegen.

Additional note - the parameter annotations are for validation, and those must be on the interface level (as I sadly found out) because of this https://docs.oracle.com/javaee/7/tutorial/bean-validation-advanced004.htm

Good feedback, thanks Jakub.
The default values are historical.  But perhaps we can change them without worrying about it being a breaking change, since the only consumer is likely us.  Another option is probably to subclass the config bean and override the defaults.  Perhaps I'll try that.
I think checked exceptions would be really interesting.  I have some ideas for that.  Would a 1-1 mapping between the declared HTTP response types and the checked exceptions be good enough?  Or would you need more control than that?  I'm thinking we could annotate the HTTP responses in the openapi.json definition to indicate the Java checked exception it should map to.
Also a good idea to support bean validation annotations.  I think we can do that with additional annotations on the query parameters in the openapi.json.

@jsenko I've updated the default values for the project settings.

Regarding the checked exceptions, I thought about the mapping to be defined at the operation level, but it actually makes sense to define it per response. Does something like this make sense (some fields omitted)?
  "paths": {
    "/api/serviceregistry_mgmt/v1/registries": {
      "description": "Manage the list of all Registry instances",
      "post": {
        "operationId": "createRegistry",
        "responses": {
          "409": {
            "x-checked-exceptions": [
              "org.bf2.srs.fleetmanager.common.storage.RegistryStorageConflictException",
              "org.bf2.srs.fleetmanager.spi.ams.ResourceLimitReachedException",
              "org.bf2.srs.fleetmanager.spi.ams.TermsRequiredException",
              "org.bf2.srs.fleetmanager.common.storage.RegistryStorageConflictException",
              (...)
            ]
          },
          "500": {
            "x-checked-exceptions": [
              "org.bf2.srs.fleetmanager.spi.ams.AccountManagementServiceException"
            ]
          }
        }
      }
  }

It improves documentation and could even be used to generate exception mappers!
Regarding the parameters, something like this would be great:
"size": {
  "name": "size",
  "schema": {
    "maximum": 500,
    "minimum": 1,
    "type": "integer"
  },
  "in": "query",
  "required": false,
  "x-annotations": [
   "@javax.validation.constraints.Min(1)"
    "@javax.validation.constraints.Max(500)"
  ]
}

but notic that some of these can be even generated from the schema, which would be another cool feature! Also I would enable this for path parameters as well.

@jsenko I've updated the default values for the project settings.

Can you point out the change? I don't see an additional commit.

Should I turn my last comment into a feature-request issue?

Yes please!

Regarding the checked exceptions, I thought about the mapping to be defined at the operation level, but it actually makes sense to define it per response. Does something like this make sense (some fields omitted)?
  "paths": {
    "/api/serviceregistry_mgmt/v1/registries": {
      "description": "Manage the list of all Registry instances",
      "post": {
        "operationId": "createRegistry",
        "responses": {
          "409": {
            "x-checked-exceptions": [
              "org.bf2.srs.fleetmanager.common.storage.RegistryStorageConflictException",
              "org.bf2.srs.fleetmanager.spi.ams.ResourceLimitReachedException",
              "org.bf2.srs.fleetmanager.spi.ams.TermsRequiredException",
              "org.bf2.srs.fleetmanager.common.storage.RegistryStorageConflictException",
              (...)
            ]
          },
          "500": {
            "x-checked-exceptions": [
              "org.bf2.srs.fleetmanager.spi.ams.AccountManagementServiceException"
            ]
          }
        }
      }
  }

It improves documentation and could even be used to generate exception mappers!

I like this.  Put this info in the feature request GH issue.  :)

Regarding the parameters, something like this would be great:
"size": {
  "name": "size",
  "schema": {
    "maximum": 500,
    "minimum": 1,
    "type": "integer"
  },
  "in": "query",
  "required": false,
  "x-annotations": [
    "@javax.validation.constraints.Min(1)"
    "@javax.validation.constraints.Max(500)"
  ]
}

but notice that some of these can be even generated from the schema, which would be another cool feature! Also I would enable this for path parameters as well.

Yes, adding the bean validation annotations directly from the schema would be nice.  Although not by default - so perhaps an extension to enable/disable that.  We'll have to play around with it in the implementation.

@jsenko I've updated the default values for the project settings.

Can you point out the change? I don't see an additional commit.

Sorry I pushed to the wrong branch.  It's there now.


Getting PermGen space issues when building latest master

with master at d2053a60681d2d3e66fb82283b3708b27e2b9168
$ ./gradlew
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':elasticsearch-spark-1.2:compileScala'.

PermGen space

Could this be an issue that is specific to my local environment?

Looks like you are using Java 7 in which case yes, you need to increase the PermGen since the scala compiler runs inside the Gradle JVM (it is not forked).
The quick solution is to use Java 8 (recommended as it adds several improvements including on the security side) and gets rid of PermGen.
Going forward, there are some improvements in Gradle 2.8 that hopefully will eliminate this issue, at least in master/2.2.

yes i am using java 7
this worked for me:

   maxHeapSize = "768m"

   maxHeapSize = "1024m"
   if (!java8)

       jvmArgs '-XX:MaxPermSize=368m'

       jvmArgs '-XX:MaxPermSize=512m'

On Mon, Nov 9, 2015 at 3:00 PM, Costin Leau<EMAIL_ADDRESS>wrote:

Looks like you are using Java 7 in which case yes, you need to increase
the PermGen since the scala compiler runs inside the Gradle JVM (it is not
forked).
The quick solution is to use Java 8 (recommended as it adds several
improvements including on the security side) and gets rid of PermGen.
Going forward, there are some improvements in Gradle 2.8 that hopefully
will eliminate this issue, at least in master/2.2.
—
Reply to this email directly or view it on GitHub
https://github.com/elastic/elasticsearch-hadoop/issues/596#issuecomment-155174135
.

Strange. Compiling the project with gradlew works fine on my end and on the CI - at least PermSize doesn't seem to be a problem.

I've increased the PermSize to 496m which should be more then enough. Again it's strange that on the CI and on my machine the build works fine with both gradle and gradlew but not in your case. Are you using some kind of instrumentation or agents in your JVM? Something is eating that PermGen but it's unclear what.

not that i am aware of... just plain oracle jdk 1.7.0_75
anyhow, thanks!

i just noticed when building elasticsearch-hadoop 2.2.0-rc1 today that i had permgen issues again. but it is not with test but instead with scalac. so changing the parameters mentioned before did not solve anything.
i fixed it for myself by doing:
$ export JAVA_OPTS="-Xmx1024M -XX:MaxPermSize=512M -XX:ReservedCodeCacheSize=512M"


Updated metadata defs

Codecov Report

Merging #17 (7316497) into main (732efd4) will increase coverage by 69.81%.
The diff coverage is 100.00%.

:exclamation: Current head 7316497 differs from pull request most recent head 10544e0. Consider uploading reports for the commit 10544e0 to get more accurate results

@@            Coverage Diff            @@
##           main      #17       +/-   ##
=========================================
+ Coverage      0   69.81%   +69.81%
=========================================
  Files         0        9        +9
  Lines         0      762      +762
=========================================
+ Hits          0      532      +532
- Misses        0      230      +230

Files
Coverage Δ

dataverse_api/_api.py
50.68% <ø> (ø)

dataverse_api/_metadata_defs.py
76.47% <100.00%> (ø)

... and 7 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


mac os 10.15 issue.

While installing the Cocoapods getting the following issue.
Updating Homebrew...
Warning: You are using macOS 10.15.
We do not provide support for this pre-release version.
You will encounter build failures with some formulae.
Please create pull requests instead of asking for help on Homebrew's GitHub,
Discourse, Twitter or IRC. You are responsible for resolving any issues you
experience while you are running this pre-release version.
Error: The following directories are not writable by your user:
/usr/local/share/man/man5
/usr/local/share/man/man7
You should change the ownership of these directories to your user.
sudo chown -R $(whoami) /usr/local/share/man/man5 /usr/local/share/man/man7
And make sure that your user has write permission.
chmod u+w /usr/local/share/man/man5 /usr/local/share/man/man7
Please help me.

Maybe this can help? https://stackoverflow.com/questions/56572116/this-terminal-wont-let-me-run-or-install-cocoa-pods-because-i-am-on-macos-catal

Working fine. Thank u.


Fixing bug in optional route parameter binding

I noticed this bug in some local testing. Basically, if you have a route template like csharp/products/{category:alpha}/{id:int?} defined (id is optional/nullable) we don't let you bind to it as in the below signature.
public static HttpResponseMessage Run(HttpRequestMessage request, string category, int? id)

The reason I didn't catch this before was because the scenario test I have in place (here) was also binding to a POCO, so the static binding contract was filled in from the POCO Id property and things worked. If in that sample you remove the POCO binding, you'll hit this bug.

The existing e2e test is already doing too much, and I don't want to add a new e2e for each new permutation. That's why I added good unit test coverage for this.


Update/modernize modules

Required items, please complete
Change(s):

Ongoing initial modernization/rewrite of Training Lab content. More PRs to come.

Reason for Change(s):

Outdated content in some places

Version Updated:

N/A

Testing Completed:

Checked the nav works and that it looks broadly OK.

Checked that the validations are passing and have addressed any issues that are present:

N/A

Hi @TristankMS,
Thank you for raising Pull Request with us! You should expect an initial response to your Pull Request from the team within 2 business days.

Looks good to me. Also tagging @miguel-pgomes

Looks good!


Complete Image Ingest

Did a complete image ingest ( ID286) and did not move over to the tile store. Not sure that this is working.

I can't replicate.  Also I see other people using the system and there was a possibility that his was just on a long queue.  I see full image ingests


[Bug] Engine token expired issue after idle for long time

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
We have enabled the HadoopCredentialsManager to refresh delegation token, but met token expired issue when the backend engine is idle for long time.
I think that we can refresh the token when establishing a connection to prevent this issue.
22/02/18 00:58:44 INFO ExecuteStatement:
           Spark application name: kyuubi_apollorno_USER_SPARK_SQL_b_stf_default_06dc1722-f0ff-4535-bea1-d2abe5d3ebf2
                 application ID: application_1635906065713_7300973
                 application web UI: https://apollo-rno-rm-1.vip.hadoop.ebay.com:50030/proxy/application_1635906065713_7300973,https://apollo-rno-rm-2.vip.hadoop.ebay.com:50030/proxy/application_1635906065713_7300973
                 master: yarn
                 deploy mode: cluster
                 version: <IP_ADDRESS>.6.0
           Start time: 2022-02-15T05:07:49.417
           User: b_stf
22/02/18 00:58:45 WARN Client: Exception encountered while connecting to the server : org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.security.token.SecretManager$InvalidToken): token (HDFS_DELEGATION_TOKEN token 22821449 for b_stf) can't be found in cache
22/02/18 00:58:45 INFO DAGScheduler: Asked to cancel job group 292fd765-4f99-44f8-afb3-a35fcc96e1a6
22/02/18 00:58:45 INFO ExecuteStatement: Processing b_stf's query[292fd765-4f99-44f8-afb3-a35fcc96e1a6]: RUNNING_STATE -> ERROR_STATE, statement: select count(*) from ddm_notiplat_t.nss_event_queue where src_cre_dt>='2022-02-16 00:00:00', time taken: 1.108 seconds
22/02/18 00:58:45 ERROR ExecuteStatement: Error operating EXECUTE_STATEMENT: org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.security.token.SecretManager$InvalidToken): token (HDFS_DELEGATION_TOKEN token 22821449 for b_stf) can't be found in cache
	at org.apache.hadoop.ipc.Client.getRpcResponse(Client.java:1586)
	at org.apache.hadoop.ipc.Client.call(Client.java:1530)
	at org.apache.hadoop.ipc.Client.call(Client.java:1430)
	at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:255)
	at com.sun.proxy.$Proxy16.getFileInfo(Unknown Source)
	at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getFileInfo(ClientNamenodeProtocolTranslatorPB.java:881)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)

Affects Version(s)
1.4.0-incubating
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

@lightning-L could you help on this issue?

FYI:
here is the ticket for Implement delegation token renewal framework

We can send credentials  in LaunchEngine operation when it succeeds.
Another case should be taken into consideration:

kyuubi engine being idle and credentials have been expired.
User created a KyuubiSession to this engine on kyuubi-server-1.
Due to some reason (server restarted or server never talked to this engine),  kyuubi-server-1 has no cached credentials for this engine.
Invoking HadoopCredentialsManager#sendCredentialsIfNeeded triggered a task to renew credentials but engine did not receive new credentials.
Following SQL operation still fails due to expired credentials.

Invoking HadoopCredentialsManager#sendCredentialsIfNeeded triggers a task to renew credentials and returns. New credentials will not be sent to engine until renewal task succeeds.
Following SQL operation still fails due to expired credentials.

Seems that we need wait the renewal task completion before executing query.


Correct getPathOr type annotation

Coverage remained the same at 100.0% when pulling bbf589d1e449b0b117d53d12441582e22b6049cb on jakubbarczyk:patch-2 into 3a9d5651da12065bc83d7bbc471e8702229ad03d on evilsoft:master.


export Node class

To enable creating features like duplicating elements on a page

Thanks for the PR, but we think the Node class is the implementational details of v-craft, we don't want it to be exposed to the developer. We implement duplicate() method in Node, and hope it would resolve your use case.
https://github.com/yoychen/v-craft/issues/19#issuecomment-927302070


Clean up travis.yml and introduce tests for oldest version of PLY supported.

Cleanup of travis config:

Use env vars instead of Python version
Use travis defaults when possible instead of specifying os/distro
Add run to test apacheconfig with oldest version of Ply

Bumps up version of Ply to 3.4 since that seems to be the earliest version
available on most distros: https://repology.org/project/python:ply/versions

Codecov Report

Merging #99 into master will increase coverage by 0.58%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #99      +/-   ##
=========================================
+ Coverage   79.92%   80.5%   +0.58%
=========================================
  Files           8       8
  Lines         802     826      +24
=========================================
+ Hits          641     665      +24
  Misses        161     161

Impacted Files
Coverage Δ

apacheconfig/parser.py
85.71% <100%> (ø)
:arrow_up:

apacheconfig/reader.py
100% <0%> (ø)
:arrow_up:

apacheconfig/lexer.py
96.69% <0%> (+0.01%)
:arrow_up:

apacheconfig/loader.py
91.1% <0%> (+0.03%)
:arrow_up:

apacheconfig/wloader.py
38.33% <0%> (+8.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1e641d...d335163. Read the comment docs.

Ah! Discovered and fixed another bug with the older code with this test cleanup (yay for testing!). Failed test here: https://travis-ci.org/etingof/apacheconfig/jobs/633794432
  File "/home/travis/virtualenv/python3.8.0/lib/python3.8/site-packages/ply/yacc.py", line 198, in __getitem__
    if n >= 0: return self.slice[n].value
TypeError: '>=' not supported between instances of 'slice' and 'int'

In Ply 3.4, the Yacc object don't handle slices correctly for Python 3. This was fixed in this commit for the Ply 3.6 release.
This might warrant another point release with the bug fixed!

Thank you! o/

Is it a good time for another release?

I think so! I'm in the middle of fixing #91 as well, but since that's a cleanup thing I don't think it should block a release.


GestureDetector vs ListView vs Column - touch events delegate confusion

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I actually wanted to follow up on one of the somehow inconclusively closed issues #72996 or #23325 - that I'm also so confused about whether GestureDetector is supposed to capture all events or not, vs its child that also capture events. Behaviour at the moment seems like (for v3.16.2); when the child listens to a touch event (such as tap or drag), it doesn't propagate to GestureDetector parent at all. Here is a reproducible minimal application:
import 'dart:developer';

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  /// Return a 100 height 100% width tile
  static Widget _tile(int index) {
    return InkWell(
      onTap: () => log('InkWell onTap: $index'),
      child: Container(
        height: 100,
        width: double.infinity,
        color: index % 2 == 0 ? Colors.lightBlue : Colors.grey.shade300,
        child: Center(child: Text('Tile $index')),
      ),
    );
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(useMaterial3: true),
      home: Scaffold(
        appBar: AppBar(
          backgroundColor: Theme.of(context).colorScheme.inversePrimary,
          title: const Text('Flutter Demo Home Page'),
        ),
        body: GestureDetector(
          onVerticalDragEnd: (DragEndDetails details) => log(
              'GestureDetector onVerticalDragEnd: ${details.primaryVelocity}'),
          onTap: () => log('GestureDetector onTap'),
          child: ListView(
            children: [for (int i = 0; i < 10; i++) _tile(i)],
          ),
        ),
      ),
    );
  }
}

Here is the behaviour below but to be honest, I would expect onVerticalDragEnd and onTap events on GestureDetector to be triggered that they do not.
https://github.com/flutter/flutter/assets/1009931/631c2f43-7b44-4ece-9497-309938535d4d
If you comment out the onTap: on InkWell without even removing it, then the onTap: () => log('GestureDetector onTap'), line starts getting called.
https://github.com/flutter/flutter/assets/1009931/8d4d4c58-a534-4766-b826-5852f40195b8
I tried with ListView.builder() at some point and it gave the similar results as I remember.
When I tried with a SingleChildScrollView wrapped Column, it has the same behaviour of ListView. However, if I try with "less items" that doesn't exceed the screen height, say 5 items, interestingly it becomes "not really scrollable" (whatever that means) and it does start propagating the drag events now to GestureDetector:
https://github.com/flutter/flutter/assets/1009931/9c6dd45a-55b0-4ef9-b82f-a4db248945db
My question is; if GestureDetector is capturing touch events with the expected behaviour, what is the point of using it with touchable widgets? Its behaviour is so confusing.
Expected results
GestureDetector to detect all touch events, even if it means a duplicate same event call on its child. For example, I would expect:
GestureDetector(
  onTap: () => log('GestureDetector onTap'),
  child: ...,
)

this to log GestureDetector onTap every time I tap on absolutely anything within its child, whether it's a button or inkwell or any other tappable widget. Same goes with the draggable widgets, such as ListView...
Actual results
GestureDetector events get called sometimes, depending on if any of its child or children listens to same events.
Code sample
Code sample provided at the beginning.
Screenshots or Video
No response
Logs
No response
Flutter Doctor output
Doctor says everything fine and on the latest sable version 3.16.2 before anyone asks..
Doctor output
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.2, on Microsoft Windows [Version 10.0.22621.2715], locale en-AU)
[✓] Windows Version (Installed version of Windows is version 10 or higher)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Chrome - develop for the web
[✓] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.7.4)
[✓] Android Studio (version 2022.3)
[✓] VS Code (version 1.84.2)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!

GestureDetector uses the gesture recognizers system. Which has different widgets compete so only one wins the gesture. If you want to receive touch events unconditionally use a Listener widget.

Thanks for filing a detailed issue, @kirpit.
About GestureDetector.onVerticalDragEnd issue, I see you can work around it with NotificationListener as below:
child: NotificationListener(
  onNotification: (ScrollNotification notification) {
    if (notification is ScrollEndNotification) {
      log('NotificationListener onNotification: ${notification.dragDetails?.primaryVelocity}');
    }
    return false;
  },
  child: ListView(
    controller: _scrollController,
    children: [for (int i = 0; i < 10; i++) MyApp._tile(i)],
  ),
),

About other gestures like onTap, you can try using Listener.onPointerDown as @moffatman suggested above.

Thank for explaining and showing how it can be done.
The Listener widget unfortunately doesn't have any drag start / end events that is not really useful. NotificationListener does work but it only captures what's bubbling from an ancestor widget, meaning there must be a scrollable child such as ListView AND it must float over the screen so is actually scrollable.
I had to use both GestureDetector => NotificationListener wrapping the ListView so I could actually capture all scroll drag events regardless to ListView content. If it does float over screen, scroll drag events will bubble to NotificationListener, otherwise GestureDetector detects if no child ancestor "wins" it.
This is so tricky and utterly confusing. All the examples of GestureDetector parent listening to onTap with a ListView child makes it even more confusing as it gives the impression that it should also work for onVerticalDrag* & onHorizontalDrag* events too.

Let me know what the actual use case is for the parent drag listening, I can suggest a good design

Did you try DraggableScrollableSheet?

Thanks for the suggestion @moffatman, it might work but I didn't understand how to implement DraggableScrollableNotification with it so parent scaffold can close. Also only its children is dragged down leaving an awkward empty background and I guess it will be the same effect even though it succeeds to close the parent.

DraggableScrollableSheet works with both scrolling and non scrolling children afaik. But yeah I guess DraggableScrollableSheet is not compatible with being the top level of a Navigator Route or whatever GetX does (not familiar with that library. Personally I use it within a Stack above lower content.
Not sure what to do with this issue, what developments do you want to see to close it. Clean up documentation on GestureDetector? There really isn't any "bubbling" as you say, based on a certain touch gesture either ancestor onTap might win or the list view might win and scroll. Depending on the speed and direction of the touch.

Also just had an idea, did you try with AlwaysScrollableScrollPhysics with a short list?

Also just had an idea, did you try with AlwaysScrollableScrollPhysics with a short list?

I'm not really sure how to make that work. By using both GestureDetector & NotificationListener widgets at the moment, I can achieve the UX I've been trying to.

Not sure what to do with this issue, what developments do you want to see to close it. Clean up documentation on GestureDetector?

My humble opinion as a Flutter learner is that the confusion comes from the "The child GestureDetector wins in this scenario ..." logic, explained under Troubleshoot doco (also your first reply explaining the situation).
It's confusing because it doesn't inline with the initial and concise explanation of the widget:

A widget that detects gestures.

I think it should detect all gestures. If that's not the option, without knowing the underlying structure, I would ask for a parameter whether to bypass that "winning" logic or not and would like to explicitly detect any ancestor input events.
Just looking at the parameters in doco; came across this excludeFromSemantics but haven't tried it so far, maybe it's similar to what I wanted in the first place?

... would result in duplication of information.

With AlwaysScrollableScrollPhysics you should get ScrollNotifications when dragging the list even if it's not tall enough to spill below the screen. Then it should work with just the NotificationListener. And may be able to simplify it further by handling only OverscrollNotification.
excludeSemantics refers to how the flutter widgets translate into accessibility compatible data, it won't affect this.
Only one GestureRecognizer / GestureDetector winning is the design on purpose. Every widget should not have to be aware of any other possible widget behaviour to work. It allows easily composability of different widgets.
To detect any child touch events, use a Listener. Your use case could be done via onPointerMove event.delta.dy field. But you would still have to check the state of the child scroll view to avoid breaking scrolling.


nvidia-container-toolkit: add noNvidiaDriverAssertion option

The assertion to ensure the Nvidia driver does not make sense on WSL, where the Nvidia driver is mounted by Windows. See https://github.com/nix-community/NixOS-WSL/blob/a6b9cf0b7805e2c50829020a73e7bde683fd36dd/modules/wsl-distro.nix#L83-L105
This PR adds an option to suppress the assertion so that nvidia-container-toolkit works on WSL.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

/cc @SomeoneSerge


MAE-44 - Fix a warning with mixed assembly versions

Fix a warning with mixed assembly versions

Warning fixed already in another checkin


Implementation of langchain based on mobile terminal

Feature request
HI! Whether the current langchain framework can be implemented on mobile, because considering the current computing power of the server is not so sufficient.We can use the computing power of our phones as well.
In addition, the deployment on the mobile phone will pay more attention to the user's privacy, and it is a good choice in some cases where the network connection is not possible.
Motivation
As far as I know, there is already the ability to deploy LLM to mobile.eg:MLC-AI
Your contribution
It is completely possible to consider deploying lightweight small databases and lightweight small LLM models (eg: MiniChat,Qwen) on mobile phones and use them.
Thanks

It may take some time, but the current performance of mobile devices is still not enough


add:vijay

I created a json file and added it to ProfilesList.json. Hope I have followed the contributing.md file and made changes accordingly. Would really appreciate if you merge my pull request.
Issue #411

@vijayv18 Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


Syntax changes and deprecated warnings

The sample code needs to be updated across this scenario due to updates of the Terraform Azure provider. Tags now require a = in the definition, there are a series of deprecated warnings when you attempt to plan this.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f9e973d5-b117-99c6-f0a0-c7d779ea3ea0
Version Independent ID: d4d46d49-d837-6d99-2f50-5578f67b1e89
Content: Tutorial - Validate a hub and spoke network in Azure using Terraform
Content Source: articles/terraform/hub-spoke-validation.md
Service: terraform
GitHub Login: @TomArcherMsft
Microsoft Alias: tarcher

@Roblarson Thanks for the feedback. The tags syntax has been updated in all Terraform docs. You should see the change published by afternoon.


How to create an action of my C# program function?

Hi there,
I am trying to use the Task Scheduler Managed Wrapper to schedule runing one of my C# function. Is that possible to do? and how? The example shows how to schedule an exe as the following:
            td.Actions.Add(new ExecAction("notepad.exe", "c:\\test.log", null));

But can I schedule to run one of my functions in the same C# program?
Thanks
Feng
Originally posted: 2013-11-06T10:25:23

You can either create an executable that accepts parameters as a means to call your method or you can create a COM Handler using my template (https://taskscheduler.codeplex.com/releases/view/29938) as an independent DLL assembly that contains your method and then use the COMHandlerAction to invoke it from the task.
Originally posted: 2013-11-06T17:50:51


FastSpeech2,Hifi-GAN, Parallel WaveGAN, MelGAN TFLite models

Any pull request you open is subject to the TensorFlow Hub Terms of Service at www.tfhub.dev/terms.

@maringeo Gentle ping

@maringeo Gentle ping

Thanks for the review @WGierke. Updated as per your suggestion.

Thanks for the review @WGierke. Updated as per your suggestion.

Oh sorry, I did not notice it. Updated @WGierke

Oh sorry, I did not notice it. Updated @WGierke


Input simulation help text cuts off in 1440p

Describe the bug
The help text for Input Simulation overlaps in the bottom left corner in a 1440p monitor (resolution: 2560x1440).
Screenshots

Your setup (please complete the following information)

Unity Version 2019.4
MRTK Version 2.5.1

Target platform (please complete the following information)
-Input Simulation
Additional context
This is a similar issue to #8646

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Add isLooped property to disable looped functionality

Can someone review this PR?

@wouterkool isLooped It was working for me with React Native 0.47.1, but after I updated XCode to 9.2, it stopped working. I know that there seems to be no relation, but it's the only change I did

This was also implemented in #128 which is merged and live now


Model, refresh new data after updated

fixed model loss its data (e.g. primary key) after updated to db

It shouldn't lose it's data, we don't remove primary key here:
https://github.com/ice/framework/pull/244/files#diff-adc4d2a2f6f7dca511a6e8073769eb86R378
Also as I said before https://github.com/ice/framework/pull/202#discussion_r221505817, maybe we could move to fields() this https://github.com/ice/framework/pull/244/files#diff-adc4d2a2f6f7dca511a6e8073769eb86R413.

$m->update(['a' => 1]);
$m has no primary key now

I added some tests, but they passed https://github.com/ice/framework/pull/246/files
Is the primary key an array? or auto-increment is false?

Oops, I change my repos to support $m->update(['a' => 1]);.
the correct way to work with yours repos should be
$m->a = 1;
$m->update(['a']);

goddamn ugly implement

Both ways should work... I just wonder why they first isn't working for you.

primary key are removed L226, and other unrelated data fields are removed at L257 or L260

Right, your fix should work then. Could you please merge the tests here #248?


why use negative no_w_metric and w_metric?

https://github.com/YuxinWenRick/tree-ring-watermark/blob/3015283d9cf82e90b628f02ad2121bd37408ca9a/run_tree_ring_watermark.py#L141
https://github.com/YuxinWenRick/tree-ring-watermark/blob/3015283d9cf82e90b628f02ad2121bd37408ca9a/run_tree_ring_watermark.py#L142
Why do you use negative no_w_metric  and w_metric instead of the postive ones?

Hi, @liwd190019, thanks for asking. It's a good question. For preds that we pass to metrics.roc_curve is the confidence score of being watermarked. If it's a watermarked image, this score should be larger. We negate it, since our metric is the distance, and we know that the distance is smaller for the watermarked images.
Let me know if you have further questions!


helm init should include tiller limits options

helm init should include support for --tiller-cpu-limits, --tiller-cpu-requests, --tiller-memory-limits, --tiller-memory-requests so that Kubernetes can allocate appropriate resources for tiller

I would like to work on this feature.

I'm running into the same problem when trying to deploy tiller to a multi-tenant cluster using namespaces, RBAC and quotas. Output from the replicaset:
Events:
  FirstSeen	LastSeen	Count	From			SubObjectPath	Type		Reason		Message
  ---------	--------	-----	----			-------------	--------	------		-------
  33m		11m		19	replicaset-controller			Warning		FailedCreate	Error creating: pods "tiller-deploy-121279995-" is forbidden: failed quota: test-quota: must specify limits.cpu,limits.memory

Since the work done on this is from a while ago, could someone please be so kind to provide some insight into the current status of implementing this feature request?
I have a workaround for those running into the same problem:
helm init --service-account tiller-test --tiller-namespace test --override 'spec.template.spec.containers[0].command'='{/tiller,--storage=secret}' --override 'spec.template.spec.containers[0].resources.limits.cpu'="2" --override 'spec.template.spec.containers[0].resources.limits.memory'="1Gi"

I found it is much easier as below
kubectl set resources deployment tiller-deploy  --limits=cpu=10m,memory=20Mi -n kube-system


Wintertodt plugin

Adds a plugin that highlights tiles that are about to damage players.
Highlights tiles for both normal snow attacks

and brazier explosions

Additionally, highlights the safespots that will prevent players from being hit by the normal snow attack.

Alright, implemented all your review changes @Infinitay
Thanks!

Whoops, sorry about that. Probably should have read the comment on top of the file first. It has been fixed.

Can we re-open this please 😄 @OTRD5k

@RajanGrewal Already did, just under a new PR.
https://github.com/runelite/runelite/pull/3047


Can't completely ignore group

I have a gem that can only be downloaded in production environment.
When I try to use --without production syntax, I get an error, since Bundler still tries to download all the gems.
I know this is the expected behavior and it is described in the docs:
http://bundler.io/man/bundle-install.1.html

While the --without option will skip installing the gems in the specified groups, it will still download those gems and use them to resolve the dependencies of every gem in your Gemfile(5).

But I really want to completely ignore this particular gem in development environment. I don't need it to be downloaded. I totally understand all the risks, etc, and still need a way to completely ignore some gem (or group) in a particular environment.

Do you have a lockfile present? It shouldn't need to download the gem if it doesn't need to re-resolve

@segiddins yes, lockfile is present, and that was working as you describe until I had to create a new rvm gemset. On a clean gemset bundle install fails.
Anyway, your tip is a workaround. I know several ways to workaround this behavior. But it would be much better if I wouldn't have to.

If Bundler has a lock and doesn't need to re-resolve, the gem will not be downloaded. If Bundler does not have a lock, or has a lock but the Gemfile has changed, it is not an issue of warnings or danger, it is an issue of not being able to resolve the Gemfile unless every gemspec is available.
This isn't us refusing to do something we could do, it's us letting you know that what you want isn't logically possible. :/ If you are okay with different versions of gems in development and production, don't use groups and without, add a conditional to your Gemfile.


Https

The web is moving to https for security... These servers seem to support HTTPS (some even speak HTTP2 when the https urls are used).
I skipped databinder.net because while the server speaks https, http://databinder.net/repo seems to be gone.
https://github.com/sbt/sbt/blob/4c3cd4e535a89d220a0d20f360f36212ceff9b09/launch/src/main/resources/sbt.boot.properties0.7#L14
I suspect that means that someone trying to ask sbt for sbt0.7 will be unhappy, although I'm not really sure how to prove it.

@jsoref Thanks!

I dropped the change to sbt/src/sbt-test/actions/external-doc/build.sbt because it depends on something:
[info] [info] Out of 1 candidates we found for org.example#b_2.12;0.1.0-SNAPSHOT in b-resolver, we are choosing b-resolver.
[info] Actual API Mappings:
[info] 	/tmp/sbt_46fc2224/c/target/scala-2.12/classes -> http://example.org/c
[info] 	/tmp/sbt_46fc2224/global/boot/scala-2.12.8/lib/scala-library.jar -> http://www.scala-lang.org/api/2.12.8/
[info] 	/tmp/sbt_46fc2224/a-repo/org/example/a_2.12/0.1.0-SNAPSHOT/a_2.12-0.1.0-SNAPSHOT.jar -> http://example.org/a
[info] 	/tmp/sbt_46fc2224/b-repo/org.example/b_2.12/0.1.0-SNAPSHOT/jars/b_2.12.jar -> http://example.org/b
[info] Expected API Mappings:
[info] 	/tmp/sbt_46fc2224/c/target/scala-2.12/classes -> http://example.org/c
[info] 	/tmp/sbt_46fc2224/global/boot/scala-2.12.8/lib/scala-library.jar -> https://www.scala-lang.org/api/2.12.8/
[info] 	/tmp/sbt_46fc2224/a-repo/org/example/a_2.12/0.1.0-SNAPSHOT/a_2.12-0.1.0-SNAPSHOT.jar -> http://example.org/a
[info] 	/tmp/sbt_46fc2224/b-repo/org.example/b_2.12/0.1.0-SNAPSHOT/jars/b_2.12.jar -> http://example.org/b


Whitelist the DAP tag for ReportStream website analytics

Problem statement
The DAP code (used to track our public website analytics through Google Analytics) is being blocked by our agency Content Security Policy. We need to whitelist the DAP code so the tag is allowed to send data.
What you need to know

Acceptance criteria

[ ] DAP code is no longer being blocked by our Content Security Policy
[ ] Check (with Chris) that GA4 is working properly (collecting data from ReportStream website)

The PR itself is officially merged BUT we need the changes within Azure to take effect as well. Devops has been made away of this issue and can be tracked here: https://github.com/CDCgov/prime-reportstream/issues/14202
cc @chris-kuryak

GA4 still not working properly, still waiting on DevOps to finish their ticket #14202

Just checked, appears to be working now. Closing ticket.

double confirming that we're all good!


Sometimes task ansible:deps might result in galaxy install failing due to SSL

OS: MacOS 14.2 (23C64)
Just wanted to add this here, in case someone comes across this:
task: [ansible:.venv] .venv/bin/ansible-galaxy install --role-file "/Users/sm/code/personal/github.com/samip5/k8s-cluster/provision/ansible/requirements.yaml" --force
Starting galaxy role install process
[WARNING]: - xanmanning.k3s was NOT installed successfully: Unknown error when attempting to call Galaxy at 'https://galaxy.ansible.com/api/': <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate
(_ssl.c:997)>. <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)>
ERROR! - you can use --ignore-errors to skip failed roles and finish processing the list.
task: Failed to run task "ansible:deps": exit status 1

Looks like you found a workaround. https://github.com/samip5/k8s-cluster/commit/45ecdc945ee391e41c8390835598a261410c6781
I'll go ahead and close this hopefully it helps someone out in the future that has this problem.


AccessDenied to lambda:GetLayerVersion

Hi,
I just tried to deploy release 1.0.7 (thank you for the update) but I run into a permissions issue, I have not encountered before.
When running Terraform (version 1.1.7), I get the following error
module.clickops_notifier.aws_lambda_function.func: Creating...
╷
│ Error: error creating Lambda Function (1): AccessDeniedException:
│ 	status code: 403, request id: 3d590222-7f98-456f-b4fe-2f4014404436
│
│   with module.clickops_notifier.aws_lambda_function.func,
│   on .terraform/modules/clickops_notifier/lambda.tf line 1, in resource "aws_lambda_function" "func":
│    1: resource "aws_lambda_function" "func" {

When checking Cloudtrail for the AWS account in question, I see the following AccessDenied message.
"errorCode": "AccessDenied",
"errorMessage": "User<EMAIL_ADDRESS>is not authorized to perform: lambda:GetLayerVersion on resource: arn:aws:lambda:eu-central-1:306986787463:layer:common-python-libraries:1 because no resource-based policy allows the lambda:GetLayerVersion action"

Could this relate to the recent release with updated layers? Would it be possible to make the layers public, if they aren't already?
Thanks,

Shoot, it could be that some layers were not made public with the GH action. I've made this one public, I'll need to add a check to check that all layers are public.
Sorry about that.
For reference here is the repo with the layers (https://github.com/phzietsman/aws-lambda-layer-common)

no worries @phzietsman I ran Terraform again and it works for us now (for eu-central-1). Have not tried any other regions.

I ran this and found a few that were not public.
for region in us-east-2 us-east-1 us-west-1 us-west-2 af-south-1 ap-east-1 ap-southeast-3 ap-south-1 ap-northeast-3 ap-northeast-2 ap-southeast-1 ap-southeast-2 ap-northeast-1 ca-central-1 eu-central-1 eu-west-1 eu-west-2 eu-south-1 eu-west-3 eu-north-1 me-south-1 sa-east-1
do
    aws lambda add-layer-version-permission \
    --region $region \
    --layer-name "common-python-libraries" \
    --statement-id public \
    --action lambda:GetLayerVersion  \
    --principal "*" \
    --version-number 1
done


Updated validations.py python script.

Fixed the behavior of validate_user function in validations.py.
Closes: #1
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

signing CLA from one or more contributors


TIKA-4126

Thanks for your contribution to Apache Tika! Your help is appreciated!
Before opening the pull request, please verify that

there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
the issue ID (TIKA-XXXX)

is referenced in the title of the pull request
and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)

commits are squashed into a single one (or few commits for larger changes)
Tika is successfully built and unit tests pass by running mvn clean test
there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

"By the time someone passes DateUtils a Calendar, there's already a timezone on it" from tika-4126 ISSUE:
Yes, but if you see the Calendar code, this timezone that was read from XMP metadata does not immediately triggers any method to shift the hour of day field. Neither this setTimezone method, nor the "date.setTimeZone(UTC);" method in line 92 of DateUtils formatDate method.
What really triggers the field hour of day sync, is the first "calendar.get(Calendar.YEAR)" that is called in doFormatDate method (line 116). But when this is triggered, the timezone is set as UTC, ignoring the first setTimezone called when the XMP metadata was read.
Just add "date.get(Calendar.DAY_OF_MONTH)" right before line 92 of DateUtils formatDate and it will force sync the XMP metadata timezone read, so, in subsequent calendar.get(Calendar.DAY_OF_MONTH) done at line 117, the shift of the hour of day (and other fields) will be correctly done.

"so we may as well just rely on Instant's toString(), truncated to seconds?"
I don't think this helps anyhow on solving the tika-4126 ISSUE.

I don't think this helps anyhow on solving the tika-4126 ISSUE.

The unit test that I added shows that it does help, I think?  Also, I had to fix 3 other unit tests after making this correction.
The documentation here (https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Instant.html#toString()) and https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Instant.html#toString() suggests that Java is correctly converting the times to UTC in Instant's toString method?
Please let me know if the unit tests are wrong or if I'm misunderstanding Java or the original problem.  Thank you!

Yes, it seems you misunderstood (or I misinformed) the issue.
There is a XMP metadata tag in the PDF with the values:
<rdf:Description rdf:about="" xmp:ModifyDate="2023-09-06T13:35:38-04:00" xmlns:xmp="http://ns.adobe.com/xap/1.0/">
Look that the timezone is -04:00. But tika does not extracts the timezone, parsing the value as "2023-09-06T13:35:38Z", as it was in UTC.

Look at the code execution on the following video I have done:
https://github.com/apache/tika/assets/28692427/63f7cf7a-11b2-40e0-9720-6af181b8c8b3
If I uncomment the Calendar get method, the preceding setTimezone is correctly applied, and the following setTimezone to UTC and get methods work well, shifting the hour_of_day field correctly.
If it is kept commented, when the setTimezone to UTC is called, the following get method does not shift the internal fields as it considers them already synchronized.

A similar behaviour occurs.
When the metadata is read, the setTimezone is called, but not applied. When the second setTimezone to UTC is called to 'normalize' the metadata timezone information, the first wasn't applied, so, the field are not shifted.

Yes, it seems you misunderstood (or I misinformed) the issue.
There is a XMP metadata tag in the PDF with the values: <rdf:Description rdf:about="" xmp:ModifyDate="2023-09-06T13:35:38-04:00" xmlns:xmp="http://ns.adobe.com/xap/1.0/">
Look that the timezone is -04:00. But tika does not extracts the timezone, parsing the value as "2023-09-06T13:35:38Z", as it was in UTC.

When I add the date string from your original issue to the testXMP.xmp file, I get this from Tika:
xmp:ModifyDate : 2023-09-06T17:35:38Z
That's what you'd expect, right?

yes. thanks
Em seg., 11 de set. de 2023 17:37, Tim Allison @.***>
escreveu:

Yes, it seems you misunderstood (or I misinformed) the issue.
There is a XMP metadata tag in the PDF with the values: <rdf:Description
rdf:about="" xmp:ModifyDate="2023-09-06T13:35:38-04:00" xmlns:xmp="
http://ns.adobe.com/xap/1.0/">
Look that the timezone is -04:00. But tika does not extracts the timezone,
parsing the value as "2023-09-06T13:35:38Z", as it was in UTC.
When I add the date string from your original issue to the testXMP.xmp
file, I get this from Tika:
xmp:ModifyDate : 2023-09-06T17:35:38Z
That's what you'd expect, right?
—
Reply to this email directly, view it on GitHub
https://github.com/apache/tika/pull/1329#issuecomment-1714619356, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AG247S3J5PYM25N7DM5JMTDXZ6AB3ANCNFSM6AAAAAA4TTWCUM
.
You are receiving this because you were mentioned.Message ID:
@.***>


Issue when running config bert on NVIDIA H100 GPU with latest PyTorch / transformers installed

Hello, if there are any contribution guildelines for me to modify this issue please let me know! Happy to modify my request.
I attempted to run the bert.yaml configuration with default device=cuda, and was met with the following error. I have the latest transformers installed at 4.31.0. Is there something on my end that needs modification? I was able to run gpt2.yaml!
user@ef0083661451:/scratch/projects/optimum_benchmark/optimum-benchmark$ python3 main.py --config-name bert
INFO:nncf:NNCF initialized successfully. Supported frameworks detected: torch, onnx, openvino
[2023-07-24 22:19:29,535][benchmark][INFO] - Configuring inference benchmark
[2023-07-24 22:19:29,535][benchmark][INFO] -    + Setting seed(42)
[2023-07-24 22:19:31,019][backend][INFO] - Checking initial device isolation
[2023-07-24 22:19:31,078][backend][INFO] - Initial device isolation check passed: no process is running on device cuda
[2023-07-24 22:19:31,078][backend][INFO] - Checking contineous device isolation
[2023-07-24 22:19:31,101][pytorch][INFO] -      + Infered AutoModel class AutoModelForMaskedLM for task fill-mask and model_type bert
[2023-07-24 22:19:31,102][backend][INFO] - Configuring pytorch backend
[2023-07-24 22:19:31,105][pytorch][INFO] -      + Disabling gradients
[2023-07-24 22:19:31,106][pytorch][INFO] -      + Loading pretrained model weights in None on cuda with no quantization
/home/user/.local/lib/python3.8/site-packages/transformers/modeling_utils.py:2193: FutureWarning: The `use_auth_token` argument is deprecated and will be removed in v5 of Transformers.
  warnings.warn(
Some weights of the model checkpoint at bert-base-uncased were not used when initializing BertForMaskedLM: ['bert.pooler.dense.weight', 'cls.seq_relationship.weight', 'bert.pooler.dense.bias', 'cls.seq_relationship.bias']
- This IS expected if you are initializing BertForMaskedLM from the checkpoint of a model trained on another task or with another architecture (e.g. initializing a BertForSequenceClassification model from a BertForPreTraining model).
- This IS NOT expected if you are initializing BertForMaskedLM from the checkpoint of a model that you expect to be exactly identical (initializing a BertForSequenceClassification model from a BertForSequenceClassification model).
Some weights of BertForMaskedLM were not initialized from the model checkpoint at bert-base-uncased and are newly initialized: ['cls.predictions.decoder.bias', 'cls.predictions.decoder.weight']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.
[2023-07-24 22:19:31,870][pytorch][INFO] -      + Turning on eval mode
[2023-07-24 22:19:31,871][inference][INFO] - Running inference benchmark
[2023-07-24 22:19:31,871][backend][INFO] - Generating dummy inputs for ['input_ids', 'attention_mask', 'token_type_ids']
'BertConfig' object has no attribute 'encoder'
'BertConfig' object has no attribute 'decoder'
'BertConfig' object has no attribute 'encoder'
'BertConfig' object has no attribute 'decoder'
'BertConfig' object has no attribute 'encoder'
'BertConfig' object has no attribute 'decoder'
[2023-07-24 22:19:31,875][backend][INFO] - Generating dummy inputs with shapes {'batch_size': 1, 'sequence_length': 16, 'num_choices': 4}
[2023-07-24 22:19:31,875][inference][INFO] -    + Warming up the forward pass
[2023-07-24 22:19:32,015][inference][INFO] -    + Tracking forward pass latency and throughput
INFO:nncf:NNCF initialized successfully. Supported frameworks detected: torch, onnx, openvino
Otherprocess
Otherprocess
Otherprocess
Otherprocess
Otherprocess
Otherprocess
[2023-07-24 22:19:42,123][inference][INFO] -    + Forward pass latency: 6.42e-03 (s)
[2023-07-24 22:19:42,124][inference][INFO] -    + Forward pass throughput: 156.00 (samples/s)
[2023-07-24 22:19:42,442][backend][INFO] - Generating dummy inputs for ['input_ids', 'token_type_ids', 'attention_mask']
'BertConfig' object has no attribute 'encoder'
'BertConfig' object has no attribute 'decoder'
'BertConfig' object has no attribute 'encoder'
'BertConfig' object has no attribute 'decoder'
'BertConfig' object has no attribute 'encoder'
'BertConfig' object has no attribute 'decoder'
[2023-07-24 22:19:42,443][backend][INFO] - Generating dummy inputs with shapes {'batch_size': 1, 'sequence_length': 16, 'num_choices': 4}
[2023-07-24 22:19:42,443][inference][INFO] -    + Warming up the generation pass
[2023-07-24 22:19:42,443][main][ERROR] - 'BertConfig' object has no attribute 'decoder'
Traceback (most recent call last):
  File "main.py", line 51, in run_experiment
    benchmark.run(backend)
  File "/scratch/projects/optimum_benchmark/optimum-benchmark/src/benchmark/inference.py", line 87, in run
    self.run_generate_tracking(backend)
  File "/scratch/projects/optimum_benchmark/optimum-benchmark/src/benchmark/inference.py", line 123, in run_generate_tracking
    _ = backend.generate(generate_input, new_tokens=self.new_tokens // 10)
  File "/scratch/projects/optimum_benchmark/optimum-benchmark/src/backend/pytorch.py", line 226, in generate
    else self.pretrained_model.config.decoder.eos_token_id,
  File "/home/user/.local/lib/python3.8/site-packages/transformers/configuration_utils.py", line 261, in __getattribute__
    return super().__getattribute__(key)
AttributeError: 'BertConfig' object has no attribute 'decoder'

Here are a couple of my package versions:
user@ef0083661451:/scratch/projects/optimum_benchmark/optimum-benchmark$ python3 -m pip list | grep -E 'transformers|torch|triton'
torch                         2.0.1+cu118
torchaudio                    2.0.2+cu118
torchvision                   0.15.2+cu118
transformers                  4.31.0
triton                        2.0.0

hi @x11kjm thank you for your interest in the repo and for pointing that bug. I fixed it.


will you finish this?

Hello! Thanks for your interest in my project!
Probably I will finish it but not in the near future. I have a lot of work to do at the moment.

Ok, thx for a quick reply!


Docs: Update navigation and badge colors

Summary
What changed?
Now that we have updated Text colors that work in dark mode, I updated the TOC green to use the new color, and updated the required badges to use "warning"
Why?
With recently color updates that better support dark mode, this enhances our docs in dark mode
Before

After

Before

After

Late hit from me, but that yellow is totally 👍 to me, doesn't seem too aggressive or anything


Sanitize names before applying resources

MGDCTRS-823: Sanitize names before applying resources
feat: parallel it

@rinaldodev mind having a look ?
I've tried to split the PR tests in separate jobs to see if helps speeding up tests but unsure ...

@rinaldodev mind having a look ?
I've tried to split the PR tests in separate jobs to see if helps speeding up tests but unsure ...

Looks good. The problem I see is that setting up Kind is a huge overhead to IT tests, and we still need to wait the 5min build before even starting to run the tests in parallel anyway. That said, might not be a huge improvement for now (20 to 30% reduction in my super fast analysis), but this will let us add more tests without increasing test time too much.

@rinaldodev mind having a look ?
I've tried to split the PR tests in separate jobs to see if helps speeding up tests but unsure ...

Looks good. The problem I see is that setting up Kind is a huge overhead to IT tests, and we still need to wait the 5min build before even starting to run the tests in parallel anyway. That said, might not be a huge improvement for now (20 to 30% reduction in my super fast analysis), but this will let us add more tests without increasing test time too much (which alone is a good improvement IMO).

Yeah I wasn't really unsure about the change but, tried ... we also need to upload/download the maven repo as jobs can't share any folder ...


Plots from large datasets are congested

I'm testing immunarch in a jupyter notebook for use in an upcoming project. The plots look great when the sample count is small. However, when it gets into the hundreds (currently n=359), the plots are congested and unusable.
Plots from the following are offset by the legend which is all you see.
repExplore(immdata$data, "len") %>% vis()
repExplore(immdata$data, .method = "len") %>% vis()

How can these plots be made without a legend? I've tried a number of ways without success.
And plots from the following are solid black, likely from all of the overlapping value labels.
repOverlap(immdata$data) %>% vis()

How can I plot the without the values?
The following plots are all black, likely due to all of the bar borders.
repClonality(immdata$data, "homeo") %>% vis()
repExplore(immdata$data, "lens") %>% vis()

How can I plot without the bar borders?
The current data set will be over 600 when complete, so I suspect that the plots may still be difficult even with these changes. I may just rewrite the plot functions. Any other suggestions would be greatly appreciated.
Thank you
Jake

I've figured out how to remove the legend ...
p = repExplore(immdata$data, "len") %>% vis()
p + theme(legend.position = "none")

And how to remove the overlaid heat map values
p = repOverlap(immdata$data) %>% vis()
p + geom_tile()

Hello,
My name is Vasily, I am a developer of the Immunarch package. Thank you for using it!
Sorry for the late reply and thank you for providing the solution, which worked for you. We will include this in our tutorials.
How is the project going? We are working on a better support for the large-scale data analysis, and we would genuinely appreciate your input. Please let me know if you are interested in a short call with us to discuss how we can help. E.g., we could provide early development builds with large-scale support features, you might find helpful in your analysis.
Best regards,
Vasily Tsvetkov

We've always got a lot of projects going. The rest of the team seemed to like the output. We haven't done much with this since but we'll circle back eventually.


Remove connection wait and throttling

Type of issue

[ ] Bug
[ ] New feature
[x] Enhancement

Description
The device actor should not wait for connections to happen nor throttle the connection task, because the SDK connects only when needed.
Throttling connections should not be required.

Won't do, improvement achieved anyway during the recent refactoring


finalize eventing

Description
This PR fixes multiple bugs in the new event processing and also add the lifespan feature for and-event triggers

[ ] E2E tests passes?

i consider the work on dis pr as complete, but have no way to validate that everything is working as expected apart the manual tests i did.


Examples

Please add a few examples on how to use it.
Thank you for all of the efforts!

Thank you for your interest in this project, but I don't think I'll be able to provide comprehensive examples yet for several reasons:

Currently, I'm using it exclusively in my workplace and it's still under the process of fleshing out. I'll probably ditch some of the APIs and change other ones, so it doesn't make much sense to document it as is.
Apart from that, it is based on a non-conventional (in Unity community at least) Vertical Slices architecture. It is an extension of Clean Architecture and you can watch a primer video here. The problem with the non-conventionality of this approach is that a simple set of examples won't do much - there needs to be a whole "what dis 🧐" introduction into how this translates into the Unity environment.

So, until then, you can read those articles, watch that video and try to figure this approach out by yourself 😉

Still, if you need some guidance on this topic - I can answer your questions to the best of my ability

also, can request and command live in different assemblies? And which assemblies are being scanned for RequestHandlers?
Additional: to chain RequestHandlers - we will need to create another command and propagate result of Handler in InputMediator.Send(CommandFromPreviousResultHandler), correct?

Many thanks, could you update your repository with this example? I will close this issue.


comments to InvestmentService for next steps

To provide context. I am trying to make a Financial tracker API. I would be grateful if you can double check for redundancies and if CRUD is correctly set up. I had issues with JSON reading and writing to this file.  Thank you

@jenieb3 I've just come to look at and review this. The PR is only showing a small change to one file?

Oh dear, I thought you would have been able to see all of it.  Oops


Python: tox is lowercase

Why:
For consistency, spell tox all in lowercase. This is how the tox project spells it, and these docs also have it lowercase in some places.
https://tox.readthedocs.io/
https://twitter.com/jugmac00/status/1431712286557843457

What's being changed:
Change example workflow to use lowercase tox.

Check off the following:

[ ] I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@hugovk
Thanks so much for opening a PR! I'll get this triaged for review :zap:


Remove UserVmDetailsDao duplicate field

Description

Removing UserVmDetailsDao duplicate field;
Found the following repeated field in the UserVmManagerImpl class
@Inject
private UserVmDetailsDao _vmDetailsDao;
@Inject
private UserVmDetailsDao _uservmDetailsDao;
Refactored to a single field;
@Inject
private UserVmDetailsDao userVmDetailsDao;
Similar to this PR: https://github.com/apache/cloudstack/pull/2750/files

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[x] Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):
How Has This Been Tested?

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
Testing
[ ] I have added tests to cover my changes.
[ ] All relevant new and existing integration tests have passed.
 I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian.  I will have a look and see if I can provide fixes for some of them starting with the test_usage.py.

LGTM, failures not related to the changes in the PR. Merging.


Add security.md file

Details:

Add security.md file to this repo

Ticket:

111140

Could we merge this PR? @nkogteva @ilyachur


Disable -ffast-math in tests

This patch disables the fast math optimizations for the test compilation. These optimizations cause test failures in blas1_rotmg_test and blas1_rotg_test.
Fast math optimizations are applied by default by Intel(R) oneAPI DPC++/C++ Compiler 2023.0.0 binary release.

Thanks to everybody for your reviews!

LGTM. Just one minor question, would it be possible to apply this flag only on the rotmg test and not others. It would be good to monitor this flag for other tests.

@mehdi-goli Yes, why not!
I implemented it in the last commit. Let me know if it is fine.


add zoom plugin to docs

What type of PR is this?
/kind design
/kind documentation
/kind feature
What this PR does / why we need it:
for better usability documentation so that images can be enlarged
Which issue(s) this PR fixes:
resolve https://github.com/karmada-io/website/issues/108

Good work @Arhell.
Can we do similar for homepage?

Ok I'll take a look

сс  @RainbowMango

Sorry @Arhell
I can't clearly tell what the patch is and what's the difference between before and after.
Can you help give a more details description? Or, @rgrupesh can you?

Or https://deploy-preview-110--karmada.netlify.app/docs/developers/guide/github-workflow

Sorry @Arhell I can't clearly tell what the patch is and what's the difference between before and after.
Can you help give a more details description? Or, @rgrupesh can you?

@RainbowMango So the patch/plugin basically adds zoom functionality to the pictures that we have on the site.
Before patch:
https://deploy-preview-107--karmada.netlify.app/docs/developers/guide/github-workflow
After patch:
https://deploy-preview-110--karmada.netlify.app/docs/developers/guide/github-workflow/
You should now be able to see the difference.

Sorry, the pictures on my side can be zoomed in and out.
So, I still can't tell the difference. By the way, I'm using Chrome.

Sorry, the pictures on my side can be zoomed in and out. So, I still can't tell the difference. By the way, I'm using Chrome.

I also use chrome
What do I have
not zoom

zoomed

I have not seen the difference between them, too.


fixing the sshkey, nw, and image name vs id issues

Fixing the nil ssh key issue, and adding both names and IDs for the network, vpc, and image.

still todo: there's an issue creating the ssh key. this fails long after the lb creation, etc.:
ERROR Error: Failed to create the key failed to Create PI Key rdr-cln-wlznb-key with error [POST /pcloud/v1/tenants/{tenant_id}/sshkeys][400] pcloudTenantsSshkeysPostBadRequest  &{Code:0 Description:bad request: rdr-cln-wlznb-key sshkey is invalid; please enter a valid ssh RSA key: ssh: no key found Error:bad request Message:}
ERROR
ERROR   on ../../../../tmp/openshift-install--168301301/main.tf line 13, in resource "ibm_pi_key" "cluster_key":
ERROR   13: resource "ibm_pi_key" "cluster_key" {
ERROR
ERROR
FATAL failed to fetch Cluster: failed to generate asset "Cluster": failed to create cluster: failed to apply Terraform: failed to complete the change

@mjturek can you test this? i think it's working but would like a verification before merge

Tested and working


Allow DAPR apps without a http endpoint to function correctly

Description
The DAPR hosting WithDaprSideCar() expects the application to always expose a http endpoint. In the DAPR world, this is not the expectation. Only apps that expect to work with input bindings or subscribe to a pubsub topic (i.e. receive messages or events) are expected to have an http endpoint.
It seems a regression was introduced where an endpoint validation was previously a null check, and now it requires an IsAllocated boolean test. I also simplified the tests into patterns and unified the three checks across all three if statements checking appPort, appChannelAddress and appProtocol respectively.
I added a third "service C" to the playground app to validate that a service without an endpoint is successfully launched.
Unit tests (to come?) -- but they look pretty arcane. Might need some pointers.
Fixes #3687
Checklist

Is this feature complete?

[ ] Yes. Ready to ship.
[x] No. Follow-up changes expected.

Are you including unit tests for the changes and scenario tests if relevant?

[ ] Yes
[x] No

Did you add public API?

[ ] Yes

If yes, did you have an API Review for it?

[ ] Yes
[ ] No

Did you add <remarks /> and <code /> elements on your triple slash comments?

[ ] Yes
[ ] No

[x] No

Does the change make any security assumptions or guarantees?

[ ] Yes

If yes, have you done a threat model and had a security review?

[ ] Yes
[ ] No

[x] No

Does the change require an update in our Aspire docs?

[ ] Yes

Link to aspire-docs issue:

[x] No

/azp run

@davidfowl -- will this make next release? It's a blocker for us. Thx!

It could, there's still time, my big concern is that we have no automated test coverage for dapr at the moment.

Spoke to the team and since we have little dapr test coverage at the moment I will merge this into main so that we can do more testing. Worst case is that we can back port to 9.0.1 if it doesn't make this release.

Spoke to the team and since we have little dapr test coverage at the moment I will merge this into main so that we can do more testing. Worst case is that we can back port to 9.0.1 if it doesn't make this release.

I did add extend the playground app for it to verify, but yeah, I wish I could help more.

Can you help verify 9.1.0 builds?

Can you help verify 9.1.0 builds?

Yes -- what do you need me to do?

Verify that there are no regressions in using it with dapr.


CI Integration

Expected Behaviour
As a developer, I would like a CI service to build my branch for which my PR is based on so that it can check for:

Unit test coverage (Java & Javascript)
Security vulnerabilities (as described by Cloud Manager rules)
Ability to compile

Actual Behaviour
There is no CI service.
Reproduce Scenario (including but not limited to)

Submit a PR

Steps to Reproduce

Submit a PR

Platform and Version
All
Sample Code that illustrates the problem
None
Logs taken while reproducing problem
Submitted PR

@auniverseaway should we give a try to githubactions?

I think so.

@auniverseaway pls have a look at https://github.com/adobe/adobe-dx/runs/446514339 a build is triggered for any push or pull request.
Will resume my work on this by adding unit test & codecov action in the workflow which should close this issue.

@auniverseaway i think we might run into some issues having exactly the same coverage as cloud manager, as i don't see an easy "free" way to integrate (all custom rules cloud manager runs) [https://docs.adobe.com/content/help/en/experience-manager-cloud-manager/using/how-to-use/understand-your-test-results.html]. May be running with default + some rules (basically findbugs ones could be added) is ok for now?

@auniverseaway problem found with github actions is PR can't access repo's secrets. Hence you can't have nice sonarcloud reports for each PR made (just once commit gets actually in the repo's branch)

let's call it done for now, i'm sure it will evolve but we have all we needed in the initial description


docs: fix issues with Getting Started section, and prettify markup

This pull request has 2 small commits to address issues with the docs:

The first commit is more functional, and fixes some small issues in the tutorial.
The second is purely stylistic, and should make the LiveView example look a little nicer when viewed in the browser.

Contributor checklist

[x] Bug fixes include regression tests (N/A)
[x] Features include unit/acceptance tests (N/A)

🚀 Thank you for your contribution! 🚀


Update test case

Codecov Report

Merging #356 (c5fc45f) into master (9853fef) will increase coverage by 1.52%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #356      +/-   ##
============================================
+ Coverage     61.91%   63.43%   +1.52%
- Complexity      818      835      +17
============================================
  Files           136      136
  Lines          3140     3140
  Branches        412      412
============================================
+ Hits           1944     1992      +48
+ Misses         1119     1067      -52
- Partials         77       81       +4

Impacted Files
Coverage Δ

...seedu/awe/logic/commands/GroupEditNameCommand.java
92.59% <100.00%> (+92.59%)
:arrow_up:

src/main/java/seedu/awe/model/group/Group.java
83.91% <0.00%> (+1.39%)
:arrow_up:

...c/main/java/seedu/awe/logic/parser/ParserUtil.java
66.27% <0.00%> (+6.97%)
:arrow_up:

...u/awe/logic/parser/GroupEditNameCommandParser.java
83.33% <0.00%> (+83.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9853fef...c5fc45f. Read the comment docs.