reversed() is not recognized in call to reversed()

Environment data

Language Server version: 2021.4.1
OS and version: Ubuntu 20.04
Python version: 3.8.6 installed via pyenv

Description
Just as len(object) calls object.__len__(), reversed(object) calls object.__reversed__().
Pylance correctly recognizes when a custom class has __len__ that calling len() is valid. This is not the case with __reversed__.
Expected behaviour
class Class:
  def __len__(self):
    return 0
  def __reversed__(self):
    return []

len(Class())
reversed(Class())  # Expect no issues here

Actual behaviour
class Class:
  def __len__(self):
    return 0
  def __reversed__(self):
    return []

len(Class())  # This is still fine
reversed(Class())  # Pylance Error: No overloads for "reversed" match the provided arguments Argument types: (Class)

I think pylance is doing the right thing in this case.
The reversed function is declared in builtins.pyi. It is an overloaded function defined as follows:
@overload
def reversed(__sequence: Sequence[_T]) -> Iterator[_T]: ...
@overload
def reversed(__sequence: Reversible[_T]) -> Iterator[_T]: ...

Sequence is not a protocol class, and Class does not subclass from it, so the first overload does not apply in this situation. So the question is whether Class implements the Reversible protocol, which is defined as follows:
class Reversible(Iterable[_T_co], Protocol[_T_co]):
    def __reversed__(self) -> Iterator[_T_co]: ...

The __reversed__ method in Class returns a list instance, but list is not an Iterator because it provides no __next__ method. For that reason, Class does not meet the requirements of the Reversible protocol.
The Python documentation indicates that __reversed__ must return an iterator, so I think the builtins.pyi stub is correct, and I think pylance is correct in indicating that this is a type consistency error.
I confirmed that mypy (another Python type checker) also emits an error in this case.

@erictraut Gotcha. I didn't realize type-checkers expect the class to inherit Reversible to call reversed() on it, since the code does run without it.
In short, the correct usage for my example would be:
+ from typing import Reversible

- class Class:
+ class Class(Reversible):
    def __reversed__(self):
      # The result must be an iterator
-     return []
+     return iter([])

Thanks for the clarification :+1:

No, you don't need to inherit from Reversible explicitly. Protocol classes don't have that requirement. However, your class needs to conform to the Reversible protocol's interface. Class didn't conform to the Reversible protocol in two important ways:

The __reversed__ method did not return an Iterator. (I see that you've corrected this in your updated code.)
Reversible also inherits from the Iterable protocol, which means that your class must also implement that protocol. That means it must also provide a __next__ and __iter__ method, which it does not.

@erictraut Okay, got it now :smile:


Osmo v22/v0.47.5

Please compare commits!

We arent using this branch anymore so i dont think this needs to be done


Fix data/plugin folders mounted as root

Due to mattermost image needs mattermost ownership for version >= 5.14
Summary
Mount volumes as mattermost user if mattermost image is greater than 5.14 (first version to use mattermost user to run processes in the container)
Ticket Link
Fixes #129, #139, #142

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich

@cpanato, @stylianosrigas ping for review

Could this get merged please?
I was going to submit the same PR as I had to spend some time sorting out the init container hack today.  It would be great if I could remove my dirty work!!
Thanks in advance

@etlfg can you rebase and fix the conflict so we can merge it?

Could this be merged?

Could this be merged?

@debarshibasak It has conflicts with the master branch. It needs to be rebased.

@debarshibasak It has conflicts with the master branch. It needs to be rebased.

@metanerd I helped resolve the merge conflicts (though looks like the tests failed, not sure why).
Queuing for your review next, or please feel free to re-assign to another member of your team.

@metanerd I helped resolve the merge conflicts (though looks like the tests failed, not sure why).
Queuing for your review next, or please feel free to re-assign to another member of your team.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

@metanerd I helped resolve the merge conflicts (though looks like the tests failed, not sure why).
Queuing for your review next, or please feel free to re-assign to another member of your team.

@metanerd gentle ping on this!

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @jfrerich @emilyacook

Hi @etlfg - I'm helping to review stale PRs and, since we haven't heard from you in a few months, I'll close this PR for now. Please feel free to re-open if you're able to prioritize. Thanks!
//cc @cpanato @metanerd


stm32: clock_control_on might return before peripheral is properly clocked

Describe the bug
According to RM0433, section 8.5.10, the following sequence must be used on STM32H7 MCUs when enabling a peripheral's clock to guarantee the peripheral is properly clocked before accessing its registers:

Set the corresponding PERxEN bit in the RCC_xxxxENR register.
Read back the RCC_xxxxENR register.
Perform a dummy read operation to any register of the enabled peripheral.

(Note that this sequence assumes the domain in which the peripheral is located is in DRun mode. Otherwise, additional steps are required.)
However, the current implementation of clock_control_on on STM32H7 devices currently only performs step 1 and 2 (see here).
This means an access to a register of the enabled peripheral just after the call to clock_control_on might silently fail, leading to hard to investigate issues. This is probably especially true for peripherals having a low clock frequency, in comparison to the CPU clock.
I suspect this issue to also impact other STM32 series. For example, RM0481, section 11.4.16, suggests that a similar sequence should be followed on STM32H5 MCUs.
Relates to https://github.com/zephyrproject-rtos/zephyr/issues/73580.
To Reproduce
In theory, it the following sequence could fail on an STM32 MCU:

Call clock_control_on to enable the clock of a given peripheral P.
After clock_control_on has returned, immeditaly access a register R of the peripheral P.

Expected behavior
The peripheral P is properly clock after clock_control_on has returned and the access to the register R succeeds.
Impact
According to the reference manual, the peripheral P might not be properly clocked when clock_control_on returns, which means the access to the register R might silently fail.
Logs and console output
N/A
Environment

OS: N/A
Toolchain: N/A
Commit SHA: Zephyr main (https://github.com/zephyrproject-rtos/zephyr/commit/459517badcaacad9cf4d1781c43c4b34e62771ae)

Additional context
Relevant quotes from the RM0433 8.5.10:

A maximum delay of two periods of the enabled clock may occur between the enable command and the first rising edge of the clock. The enable command can be the rising edge of the PERxEN bits of RCC_xxxxENR registers, or a kernel clock request asserted by a peripheral.

The following sequence can be followed to avoid this issue:
a) Enable the peripheral clocks (i.e. allocate the peripheral) by writing the corresponding PERxEN bit to ‘1’ in the RCC_xxxxENR register,
b) Read back the RCC_xxxxENR register to make sure that the previous write operation is not pending into a write buffer.
c) [...] (step not needed if the domain is in DRun mode)
d) Perform a dummy read operation into a register of the enabled peripheral. This operation will take at least 2 clock cycles, which is equal to the max delay of the enable command.
e) The peripheral can then be used.

Thanks for raising this issue.
This description is correct but some notes should be added:

Expected behavior
The peripheral P is properly clock after clock_control_on has returned and the access to the register R succeeds.

Not exactly. API clock_control_on specifies: " On success, the clock is enabled and ready when this function returns.".
hence that the clock is enabled and nothing else. Nothing is specified on the requesting peripheral.
Coming to the way to fix this, the most simple would be performing systematic dummy read in each peripheral driver following return from clock_control_on.
We can also think of alternatives like getting the requesting peripheral to provide a reg address where the dummy read should be performed in the opaque clock_control_subsys_t structure provided as argument to clock_control_on and have the clock_control driver performing the read.
Both have pro's and cons but I'd prefer the first one.

@erwango Sorry for the delay! Could you please remove the "Stale" label?

Not exactly. API clock_control_on specifies: " On success, the clock is enabled and ready when this function returns.".
hence that the clock is enabled and nothing else. Nothing is specified on the requesting peripheral.

Yes, you're right, to be rigorous I should have written something like "The peripheral P is properly clock after clock_control_on has returned, which implies the access to the register R cannot fail because of the state of the peripheral's clock" (assuming the clock is not disabled in the meantime of course). However, in most cases I guess an enabled and ready peripheral's clock is a sufficient condition for guaranteeing a successful access to the peripheral's registers.

Coming to the way to fix this, the most simple would be performing systematic dummy read in each peripheral driver following return from clock_control_on.
We can also think of alternatives like getting the requesting peripheral to provide a reg address where the dummy read should be performed in the opaque clock_control_subsys_t structure provided as argument to clock_control_on and have the clock_control driver performing the read.
Both have pro's and cons but I'd prefer the first one.

I agree the first solution is the most straightforward, however I guess it might be error-prone: it would be easy to forget adding the dummy read after the return from clock_control_on. It would also not match the specifications of clock_control_on since the latter would no longer guarantee that the peripheral's clock is ready on return.
One idea I had in mind is that we might perhaps perform at the end of clock_control_on a dummy 32-bit read to the very beginning of the peripheral's memory area, which I guess can be retrieved from the device tree. The problem is that for some peripherals this might have side effects, e.g. if the read register contains some clear-on-read bits. The second solution you suggested might be an alternative but perhaps the address from which to perform the dummy read could also be instead indicated for each peripheral in the device tree, using a new dedicated property?
I haven't had the chance to use Zephyr for a quite a bit of time so my apologies if my ideas are not very relevant.


the extract_info error

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.10.05. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ ] I've verified and I assure that I'm running youtube-dl 2018.10.05

Before submitting an issue make sure you have:

[ ] At least skimmed through the README, most notably the FAQ and BUGS sections
[ ] Searched the bugtracker for similar issues including closed ones
[ ] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2018.10.05
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
I'm in China.I try RaspberryCast,but the youtube-dl can not work.Maybe it's the extract_info's problem.
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.10.05
[debug] Python version 2.7.12 (CPython) - Linux-4.4.38-v7+-armv7l-with-Ubuntu-16.04-xenial
[debug] exe versions: ffmpeg 3.2-2, ffprobe 3.2-2, rtmpdump 2.4
[debug] Proxy map: {u'http': '<IP_ADDRESS>:8087', u'https': '<IP_ADDRESS>:8087'}
[PornHub] ph5b02341d08b0a: Downloading pc webpage
ERROR: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 792, in extract_info
ie_result = ie.extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 507, in extract
ie_result = self._real_extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/pornhub.py", line 166, in _real_extract
webpage, 'title', group='title')
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 977, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "extract_info.py", line 8, in
url_dict=ydl.extract_info(url, download=False)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 815, in extract_info
self.report_error(compat_str(e), e.format_traceback())
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 620, in report_error
self.trouble(error_message, tb)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 590, in trouble
raise DownloadError(message, exc_info)
youtube_dl.utils.DownloadError: ERROR: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2018.10.05
[debug] Python version 2.7.12 (CPython) - Linux-4.4.38-v7+-armv7l-with-Ubuntu-16.04-xenial
[debug] exe versions: ffmpeg 3.2-2, ffprobe 3.2-2, rtmpdump 2.4
[debug] Proxy map: {u'http': '<IP_ADDRESS>:8087', u'https': '<IP_ADDRESS>:8087'}
[PornHub] ph5b02341d08b0a: Downloading pc webpage
ERROR: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 792, in extract_info
ie_result = ie.extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 507, in extract
ie_result = self._real_extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/pornhub.py", line 166, in _real_extract
webpage, 'title', group='title')
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 977, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "extract_info.py", line 8, in
url_dict=ydl.extract_info(url, download=False)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 815, in extract_info
self.report_error(compat_str(e), e.format_traceback())
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 620, in report_error
self.trouble(error_message, tb)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 590, in trouble
raise DownloadError(message, exc_info)
youtube_dl.utils.DownloadError: ERROR: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

I have a similar issue , here is an example

youtube-dl  https://www.pornhub.com/view_video.php?viewkey=ph5ba0522415124 --dump-json

ERROR: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Verbose:
ERROR: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 792, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 507, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/pornhub.py", line 166, in _real_extract
    webpage, 'title', group='title')
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 977, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
youtube_dl.utils.RegexNotFoundError: Unable to extract title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.


Added ability to check duplication of rows by specific function

Now we can pass in rule:
duplicateChecker = function (_id, rows) {
   return true; // duplicate found
}

#51

@jifeon we definitely need node 4.x
Parser #parse parse single page with duplicateChecker which returns true:
     TypeError: Object [object Object],[object Object],[object Object] has no method 'findIndex'
      at Parser._parseCollectionRule (lib/Parser.js:389:36)
      at Parser._parseRow (lib/Parser.js:352:14)
      at Parser.<anonymous> (lib/Parser.js:317:22)
      at Array.0 (node_modules/vow/lib/vow.js:711:39)
      at Object.callFns [as _onImmediate] (node_modules/vow/lib/vow.js:23:35)

@jifeon for review

The function actually should work with Promises

However, it should work like that with Promises


Add Hugo

https://github.com/cnych/awesome-hugo
Hugo is one of the most popular open-source static site generators. With its amazing speed and flexibility, Hugo makes building websites fun again.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.

I have read and understood the contribution guidelines and the instructions for creating a list.
This pull request has a descriptive title.For example, Add Name of List, not Update readme.md or Add awesome list.
The entry in the Awesome list should:

Include a short description about the project/theme of the list. It should not describe the list itself.Example: - [Fish](…) - User-friendly shell., not - [Fish](…) - Resources for Fish..
Be added at the bottom of the appropriate category.

The list I'm submitting complies with these requirements:

Has been around for at least 30 days.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
It's the result of hard work and the best I could possibly produce.
Non-generated Markdown file in a GitHub repo.
Includes a succinct description of the project/theme at the top of the readme. (Example)
The repo should have awesome-list & awesome as GitHub topics. I encourage you to add more relevant topics.
Not a duplicate.
Only has awesome items. Awesome lists are curations of the best, not everything.
Includes a project logo/illustration whenever possible.

Either fullwidth or placed at the top-right of the readme. (Example)
The image should link to the project website or any relevant website.
The image should be high-DPI. Set it to maximum half the width of the original image.

Entries have a description, unless the title is descriptive enough by itself. It rarely is though.
Includes the Awesome badge.

Should be placed on the right side of the readme heading.
Should link back to this list.

Has a Table of Contents section.

Should be named Contents, not Table of Contents.
Should be the first section in the list.
Should only have one level of sub-lists, preferably none.

Has an appropriate license.

That means something like CC0, not a code licence like MIT, BSD, Apache, etc.
WTFPL and Unlicense are not acceptable licenses.
If you use a license badge, it should be SVG, not PNG.

Has contribution guidelines.

The file should be named contributing.md. Casing is up to you.

Has consistent formatting and proper spelling/grammar.

The link and description are separated by a dash. Example: - [AVA](…) - JavaScript test runner.
The description starts with an uppercase character and ends with a period.
Drop all the A / An prefixes in the descriptions.
Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Doesn't include a Travis badge.You can still use Travis for list linting, but the badge has no value in the readme.

Go to the top and read it again.

Hey, sorry for the lack of response, please see #1363.

Description is not really descriptive I think
Link should be https://github.com/cnych/awesome-hugo#readme
Marker style should be -                                    unordered-list-marker-style
Missing Awesome badge after the main heading                awesome/badge
Remove trailing slash (http://blog.kerkerj.in)              trailing-slash
Remove trailing slash (http://lanlingzi.cn)                 trailing-slash
Remove trailing slash (http://nanshu.wang)                  trailing-slash
Remove trailing slash (http://prism.com)                    trailing-slash
Remove trailing slash (http://www.gohugo.org)               trailing-slash
Remove trailing slash (https://bitsflow.org)                trailing-slash
Remove trailing slash (https://gohugo.io)                   trailing-slash
Remove trailing slash (https://jimmysong.io)                trailing-slash
Remove trailing slash (https://laozhu.me)                   trailing-slash
Remove trailing slash (https://skyao.io)                    trailing-slash
Remove trailing slash (https://stackimpact.com)             trailing-slash
Remove trailing slash (https://support.1password.com)       trailing-slash
Remove trailing slash (https://www.hartwell-insurance.com)  trailing-slash
Remove trailing slash (https://www.himysql.com)             trailing-slash

Remove trailing slash (https://www.paceup.com)              trailing-slash
Remove trailing slash (https://www.quiply.com)              trailing-slash
Remove trailing slash (https://yumminhuang.github.io)       trailing-slash

Closing for lack of response.


Feature importance based on value

Let’s say you want to identify which features increase or decrease a specific metric in a dataset; ‘these features have impact on feature X being positive’ and ‘these features have impact on feature X being negative’. Is that possible with PFI?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1b1fb0dd-648b-26e9-7e4e-48824ab94160
Version Independent ID: 689b6488-dadc-fd39-c432-ebf095a0299a
Content: Explain model predictions using Permutation Feature Importance - ML.NET
Content Source: docs/machine-learning/how-to-guides/explain-machine-learning-model-permutation-feature-importance-ml-net.md
Product: dotnet-ml
GitHub Login: @luisquintanilla
Microsoft Alias: luquinta

Hi @famschopman,
Thank you for your question. Because this is not a doc-related issue/question, can you please post this on the dotnet/machinelearning repo instead.

AB#1572600


Refactor: Fix transition router switch logic

Existing transition router switch logic is fragile. @nholland94 would like to fix it up. In particular

It's not clear that pipes are always closed in the right way.
The rules for switching between participation + bootstrap are not obviously correct.

@nholland94 if @ghost-not-in-the-shell 's recent changes don't address this issue as far as you're concerned, could you make another more specific issue?

@imeckler Jiawei ended up just trying to patch the logic as it was rather than doing a full refactor. The necessary refactor is still an open issue.

This work will soon be required due to changes in the transition frontier initialization logic that need some new state management logic in the transition router.

@imeckler we are still encountering bugs due to this work not being done. Recently @mrmr1993 encountered yet another closed pipe issue. I don't think we should close this issue.

Maybe we can take some inspiration from how openmina architects their stuff around reducers to try and clean this up?


feat: portfolio refresh on new tx

Description
now that we have a state machine tracking tx loading status https://github.com/shapeshift/web/commit/16a699b26cd0db37703d6117eaea57c001f8a82d
we can refetch the portfolio when a new tx comes in, which fixes a bunch of bugs.

changes the delimiter we use for TxId's, previously - was also used in cosmos chain references, e.g. cosmoshub-4 so we couldn't deserialize correctly. hopefully * does not appear in chain namespace, reference, or asset namespaces or references 🤷♂
some fairly terse logic for monitoring for new txids, refetching cosmos immediately, or monitoring pending eth/btc txs and refetching the account when the tx is actually confirmed and unchain is aware of new assets and balances
tested with @MBMaria receive a brand new erc20 asset into a portfolio

Notice
Before submitting a pull request, please make sure you have answered the following:

[ ] Have you followed the guidelines in our Contributing guide?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
closes #706
closes #740
closes #786
#1409
Risk
this has significant risk for portfolio thrashing, over or under data fetching, and should be tested by another engineer with the console open.
Testing
connect a wallet, wait a few seconds, do any sort of transaction - preferably swapping into a new asset, make sure the dashboard automatically updates with the new asset and balances correctly.
you'll have to do a transaction, and ensure the portfolio is refetched correctly. fully refresh the page and confirm the balance is the same as the live updated balance.
please note - for eth and btc, your balance and charts will update when the pending tx is picked up, but will only account for the fee, as unchained optimistically includes pending txs. your balance and charts will update again with the full send or receive amount respectively when the tx is confirmed.
Screenshots (if applicable)
n/a

@stackedq let's get this ready for review when you are, and ops can test this with transactions

Will test this one out after requested changes are implemented.

putting this one back into draft, as we're actually blocked by an unchained issue.
the portfolio logic refetch logic works as expected, i'm about to push another small commit for a eth checksum lowercase address fix.
the issue is that pending transactions for new assets aren't showing up the new asset id, until the tx is confirmed.
the effect of this is that balance charts and total portfolio balance will update to reflect transaction fees on outgoing pending txs, but until the tx is actually confirmed on chain, unchained will not respond with that asset in the portfolio.
we could manually add it into the portfolio in the client, but that doesn't feel like the best solution. we're already being "optimistic" and showing unconfirmed txs in balances, and we should probably include that those pending tx assets in the portfolio response from unchained too.

my last comment above is invalid. we now monitor pending txs in the client, and only refetch the account from unchained when the tx is confirmed. it doesn't really make sense (or may not be feasible) for unchained to be optimistic about assets in the portfolio for pending txs, and adds a bunch of UI considerations.

@0xdef1cafe I just noticed that you probably did your testing with the same account that is used for cypress tests, and now the expected values are not equal to actual values.

Removed the closes reference to #1409 as it only partially fixes it

Removed the closes reference to #1409 as it only partially fixes it

This can be a solution for now, but I want to highlight that I strongly disagree that staking data should be it's own slice. It's related to an account and an asset.
We should have extended the portfolio with optional types to account for this extra data that comes back, and transformed it in the accountToPortfolio call.
Additionally, now we have to call unchained twice, and now we have more chain specific logic in this very high level application data management layer.
@cjthompson something to keep in mind for more cleanup when this is done. End goal is staking slice shouldn't exist.


Support rebuilding packages in other distributions than sid

Sometimes when I want to push a new upstream bugfix version to stable, I want to be able to prove to release managers that it doesn't break any other package and showing a successful rebuild is a good start. But then I need to be able to rebuild in a distribution which is not sid...

Having a command line parameter would be enough but it would be even better if the default value was to reuse the target distribution of the .changes that we give as parameter.


Match semantic colors to Figma colors

Describe the feature you'd like
There are some differences between the semantic colors in the code and the Figma file that designers use.
The goal of this issue would be to add the missing colors in the code.
This is the part that we are missing:

Describe alternatives you've considered
None.

Reopening because we want to rethink how we want our semantic colors to look like. How broad/specific do we want them to be? (e.g. we have a border.primary but also a forms.datepicker.calendar.borderHover, do we really need the second one?)

Action Items from meeting 01/12/2022:

Plan / document approach with semantic colors
Apply semantic colors to component styles config
e.g.
instead of button.border.primary: Colors.something
utilize semantic: button.border.primary: SemanticColors.border.secondary

After these two are done, define an issue for setting up strategy for managing design system wide styling via theme, or CSS variables...


remove reference to cleanup config flag

See https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/blob/61cc42d2195853ed3dc8cb0a68b1f05b440818cc/hooks/pre-exit#L13

plugin_read_config CLEANUP "true"

There is no cleanup flag and therefore that comparison is always true.

This is somewhat of a hack used in the unit tests only, because it’s a tricky one to test for. If you manage to figure out a cleaner approach, would be more than welcome to accept a change.


WEATHER DASHBOARD

WEATHER DASHBOARD
User Story
AS A traveler
I WANT to see the weather outlook for multiple cities
SO THAT I can plan a trip accordingly
Acceptance Criteria
GIVEN the weather dashboard
WHEN a user searches for a city
THEN they are presented with current conditions for that city
AND they are presented future conditions for that city
AND that city is added to the search history

GIVEN the weather dashboard
WHEN a user searches for a city
THEN they are presented with current conditions for that city
AND they are presented future conditions for that city

GIVEN the weather dashboard
WHEN a user searches for a city
AND that city is added to the search history

GIVEN the weather dashboard
WHEN a user searches for a city
AND that city is added to the search history


Invalid configuration

Plugin version: 1.4.0
IDE: PhpStorm 2021.3.3
OS: Windows 11
Description:
Run/Debug configuration doesn't work anymore after upgrading Pest plugin to the latest version.
Screenshot:

🙈
Could you please share a screenshot of your pest configuration under test frameworks? 👀

Temporary fixed downgrading the plugin version to 1.3.0.
Waiting for a permanent fix 😊

Same problem with the 'working directory' after update to 1.4.0 here.
Downgrade to 1.3.0 fix the problem.

Thanks, sorry for the inconvenience.
Having a bit of trouble reproducing 👀
@Sergej-Tihonov could you confirm if your settings are identical to @Lukasss93?

Have same issue

if i set custom directory to "/tests", got another error

What version of IntelliJ? And are all of you on windows?

What version of IntelliJ? And are all of you on windows?

Windows 10 corporate ltsc
PhpStorm 2021.3.3 Build #PS-213.7172.28, built on March 17, 2022

Downgrade to 1.3.0 fixed the problem for me too

I think I might have found the issue, could you please try out this EAP build and check if it fixes the problems for you?
Install it manually using
Preferences > Plugins > ⚙ > Install plugin from disk...
PEST PHP-1.4.1-EAP.3.zip

@olivernybroe tested your provided version "PEST PHP-1.4.1-EAP.3.zip". Works for me like a charm. Thank you very much for the fix.
Details to my System:

MacOS (M1)
PhpStorm 2021.3.3
I run my project in a docker container via remote interpreter

@Sergej-Tihonov Thank you for testing it! ❤
Interesting that you also had the issue on M1, the issue was related to me making the stupid mistake of assuming / as path separator...
Will wait for @Lukasss93  or @MrSapog to also test it before I will begin the process or releasing it as a stable version.

@olivernybroe works for me too. Wow thats the speed! Thanks a lot!

Thanks for being fast testing it, I'll begin the release process. Might take up to a day for them to review.
Closing this issue 👍


Person table should have column for userId

this should match whatever is provided by the authentication method.  i.e. Cleartrust uses email.

Need to fix:
PersonDao:: findByUserId (currently using email)
Person (model)

Duplicated by (newer) #6477


Better support for dynamically adding routes - in nested routers

Im having some issues with nested app-routers.
In my application i have a main router which initializes the main route with a wildcard:

e.g: /:aId/landing/*

This router gets populated by an Array of a Polymer-Element thats wrapped around the router and initializes manually via 'router.init()` int the elements ready function and init="manual" on the router element.
The Path that lies underneath initializes a nested app-router that needs to be populated dynamically too.
There are no errors but it seems like app router doesn't resolve the dynamic routes in the nested router.
so something like this:
<some-custom-element>
 <app-router  id="a" init="manual">
   <template is="dom-repeat">
    <app-route path="/:aId/landing/*" import="some-other-custom-element"> <!-- this one is populated properly -->
    <some-other-custom-element>
     <app-router ="b" init="manual">
      <template is="dom-repeat">
      <app-route path="/:aId/landing/static" import="static-element"> <!-- this one looks like its populated but the route wont return the needed import element -->
...

to test if there is an implementation error i cloned one of these dynamic nested routes and hard coded it into the nested router. When i do that everything works, so there must be an issue with the manual initialization of nested routes i think. Do you have any experience with this kind of issue or can you help me solve this?
The project im working on is available here : https://github.com/juicyarts/wbm-polymer/tree/develop

i managed to get it working by setting a Timeout but to me that doesn't seem to be the best approach to solve this issue.


⚠ Spryr has degraded performance

In 739cbdc, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 3627 ms

Resolved: Spryr performance has improved in e53c4c6 after 9 minutes.


[BUG] Bug with the Pockets Mod

Aged Version: 2.2.2

When I tried to use the Pockets on my leather leggings, the game crashed and it's not letting me enter my world again. I tried erasing the mod bu it didn't work.
here is a copy of my world file: Google Drive
I have downloaded 2 extra mods (Xaero's minimap & First Player Model) but I didn't use them yet, i downloaded them after my game crashed so I don't think it's the case.

Hi, i need the crash report

crash-2024-04-13_19.06.36-client.txt

crash-2024-04-13_18.55.37-client.txt

Try to disable Inventory Sorter

it worked! thank you very much!

Awesome


Attempting to cast Refined Storage Class throws exception

https://paste.ubuntu.com/p/yhKBTxfMpW/
[16:38:45] [Client thread/ERROR] [jei]: Error caught from Recipe Category: knightminer.inspirations.plugins.jei.smashing.SmashingRecipeCategory java.lang.ClassCastException: com.raoulvdberge.refinedstorage.integration.jei.RecipeWrapperCover cannot be cast to knightminer.inspirations.plugins.jei.smashing.SmashingRecipeWrapper

This is definately caused by Refined Storage, the log is littered with errors of trying to cast their recipe to just about every recipe type, making it clear they are somehow adding the recipes wrongly.

Closing as its caused by another mod and I am not working on 1.12 anymore.


[Enhancement](multi catalog) Support hudi mor java side

Proposed changes
Issue Number: close #18432
Problem summary
Support reading Hudi MOR table by using jni connector
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Cloud you please add in the description that the FE part of the current PR is completed, and the BE part will be supplemented in next PR.

LGTM

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.91 seconds
stream load tsv:          420 seconds loaded<PHONE_NUMBER>9 Bytes, about 169 MB/s
stream load json:         23 seconds loaded<PHONE_NUMBER> Bytes, about 97 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          78.0 seconds inserted 10000000 Rows, about 128K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230524091604_clickbench_pr_149641.html

LGTM


feat: support removeFilteredPolicy()

:tada: This PR is included in version 1.3.0 :tada:
The release is available on:

GitHub release
v1.3.0

Your semantic-release bot :package::rocket:


tortoisehg is out-of-date

tortoisehg 5.2.1 does not exist. The URL is dead and there is no authoritative "5.2.1" tarball listed anywhere. This package was upgraded to an unreleased version because of the python2 to 3 work 7063f6f29ac310a62fc20bc4bc1b37117f3d0fa5 by @Mic92 . We can upgrade to 5.6 which mirrors the version of mercurial in master or 5.4.2 for nixos-20.09. Will verify locally for 5.4.2 on nixos-20.09
Checklist

[x] Checked the nixpkgs master branch

[x] Checked the nixpkgs pull requests

Project name
nix search name: tortoisehg , nixpkgs.tortoisehg

current version: 5.2.1
desired version: 5.6, 5.4.2
Notify maintainers

maintainers: @danbst
Note for maintainers
Please tag this issue in your PR.

Current version is also a little buggy with the error described here: https://aur.archlinux.org/packages/tortoisehg/?O=40&PP=10#comment-718577

TypeError: propertyChanged(self, str, str).emit(): argument 1 has unexpected type 'str'

5.4.2 works for me.

Current version is also a little buggy with the error described here: https://aur.archlinux.org/packages/tortoisehg/?O=40&PP=10#comment-718577

TypeError: propertyChanged(self, str, str).emit(): argument 1 has unexpected type 'str'

5.4.2 works for me.


correct the sha265 of typora after package update

Motivation for this change
The deb is updated without increase the version number, so sha256 should be updated
Things done
Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers.

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

LGTM


Transform Quotes

Was there any particular reason you left out the "quotes" transformations? I have successfully transferred my invoicePlane data to Invoice Ninja with the exception of the quotes....

No particular reason, I probably just forgot! It won't be much work to bring this over.

Any ETA on this? I'm new to InvoicePlane and InvoiceNinja. I'm actually migrating from Fusion Invoice -> InvoicePlane -> InvoiceNinja lol, only way to migrate my data but quotes are important so I can't move over until this is in place. Have you already started on this @turbo124 yet otherwise I'll take a look.

@Braunson this is on my list, should be completed shortly.

This was quite easy to implement though as invoice ninja uses invoice table for quotes with a column that is set to "is_quote_type" or something of the sort. It was then a matter of replicating the class functions for the invoice migration

@karneaud are you able to PR your changes?

@turbo124
I should but in the interim https://gist.github.com/karneaud/4eb8f0ba235395bf9ac2b1afb70dec78

@karneaud thanks for this, i'll test the changes and merge. tks!

Oh wow that was quick, awesome. I'll just be waiting on your merge @turbo124. Thanks @karneaud!

#6eaa5df
@Braunson this has been implemented and only lightly tested, please let me know your results!

@turbo124 I ran the updated code, I'm not sure what the download data button is suppose to do it but outputted a bunch of json with no quotes array within it.

Invoice Ninja stores Quotes in the invoice table and uses a boolean is_quote for filtering.
Sounds like your data is ready to import!

Haha oh yeah, apologies!


Allow the use of string_body and vector_body with -fno-exceptions

string_body and vector_body will no longer translate all exceptions
to "buffer_overflow" error code. buffer_overflow error can now only
occur if the Body's max_size() is exceeded.
Changes required:
Code that relies on exceptions thrown from value_type's reserve/resize
being translated into an error code must implement a mechanism to catch
the exception.

Merged in 226.


Add script which updates eventuals commit and shallow_since

Adds scripts to have the possibility to create auto-PR on every push in main in 3rdparty/eventuals repo in order to update eventuals in the repository needed.
NOTE: make sure that all branches\refs are tied to main in scripts before merging this PR!!! Also uncomment all stuff for merge labels!!!

Since all this stuff was moved to eventuals repo (check this PR), we close this!


Compilation for North Hemisphere

Hi Erik, nice compilation. Do you have a similar catalogue but for the North Hemisphere?

Hello Dailer!
Unfortunately I do not have a compilation for the North Hemisphere. I can make one but I won't be able to do it for some time, since I'm finishing my PhD at the moment.
Anyway, I'll add this to my to-do list!
Thanks!

Thanks Erik, for the replying!


Remove stale information from sidecar.

The sidecar is used for atomic metadata updates, but it's not being kept
in sync with removals from the solr document. This should refresh those
removals appropriately, fixing issues with strange metadata showing up
in records.

Coverage remained the same at 100.0% when pulling 7c10a99cc947dc48e9bfb6a5447bc92c29bab10b on fix_stale_sidecar_data into 9d823427d2a821f39cf8d558e01109e962746fb6 on master.


Checksum for manifests

What type of enhancement is this?
Tech debt reduction, Other
What does the enhancement do?
The manifest doesn't have any checksum for data validation. We need a way to do the checksum validation for region manifests. A possible way is saving the checksum as the part of manifest file name, for example,<PHONE_NUMBER>01-{checksum}.json.
After reading the file content, we can calculate the content checksum by CRC32 or other algorithms and ensure the value is equals to the checksum in the file name.
Implementation challenges
No response

Another way is saving a checksum JSON object in the next line of the file content, like a footer.
{"manifest": "manifest_data"}
{"footer": { "checksum": 235423 }}

Hi, I'd like to have a try.

Need help:  How can I design the return Value for fn verify_checksum(&self, content: &[u8]) ? since there's a alias pub type Result<T> = std::result::Result<T, Error> I've tried to return  an error like VerifyChecksum but failed. any suggetions ?

@killme2008 @evenyag gimme some help or advice, I'd appreciate it, thanks.

We use snafu to generate errors. I guess that you want to return a leaf error.
https://docs.rs/snafu/0.8.0/snafu/guide/examples/basic/enum.Error.html#leaf-errors
You can add a variant to the Error type in the relevant crate.
https://github.com/GreptimeTeam/greptimedb/blob/f735f739e5de7a028a7b860b4e507eb774c9523a/src/mito2/src/error.rs#L37

We use snafu to generate errors. I guess that you want to return a leaf error.
https://docs.rs/snafu/0.8.0/snafu/guide/examples/basic/enum.Error.html#leaf-errors
You can add a variant to the Error type in the relevant crate.
https://github.com/GreptimeTeam/greptimedb/blob/f735f739e5de7a028a7b860b4e507eb774c9523a/src/mito2/src/error.rs#L37

ok, I'll try.

@killme2008 @evenyag May you provide some of the related source code?
We have a few of Manifest, said FileRegionManifest/RegionManifest. It's not quite clear what's proposed in this issue.

We store several manifest files.
https://github.com/GreptimeTeam/greptimedb/blob/20e8c3d864bd1fc4baf26ee273a03d46c8c7d399/src/mito2/src/manifest/storage.rs#L351-L370
https://github.com/GreptimeTeam/greptimedb/blob/20e8c3d864bd1fc4baf26ee273a03d46c8c7d399/src/file-engine/src/manifest.rs#L46-L63
Both of them are plain JSON files. We might store a checksum in each file to help validate whether the file is not corrupted.


Publish new version

Hey guys
I recently got a tiny PR merged here and was wondering if there is any chance of getting a new version pushed to pub.dev.
Thanks

Done!


Include a SagaManager abstract class.

This issue is closely related to: https://github.com/Clariteia/microservice_template/issues/6


Lossless compression information for LERC

What Changed
Lossless compression detail for LERC.
Thanks @blacha 🙏
How to test it
Review the preview from GitHub action below.

I don't think this explanation is the full story, but generally agree this needs an update. The issue I have with the fix is that the GDAL/ArcGIS parameter is called MAX_Z_ERROR/Max-error not Precision. Which to me is different since precision is to what decimal place is the data stored, and max error, is how far is the value allowed to change from what's currently stored. Net effect is the same but explaining the number is different.
Precision would be a number like 3, but the equivalent max error would be .001?
https://kokoalberti.com/articles/geotiff-compression-optimization-guide/
cc: @vincentsarago

@wildintellect I completely agree there is a jumbling of terms error vs precision, I originally had it as MAX_Z_ERROR but I thought that may be too GDAL specific and reworded it to precision as it was used earlier in the paragraph.
How about something like :

this compression is not lossless when used with an allowed error greater than zero.

Or going back to MaxZError as its referenced on https://github.com/Esri/lerc#when-to-use

this compression is not lossless when used with a MaxZError greater than zero.

I was also trying not to completely change the flow of this paragraph being as it is my first pull request.
This section could be changed further, LERC is quite good (fast compression/decompression & good output size) for most lossless applications I have tried, uint8 (RGBA), uint16(RGBi), float32(DEM/DSM). It also has a nice wasm interface for accessing raw pixel values in a browser.

@blacha feel free to propose alternate text.
Also just discovered thanks to @bitner , that you can check which Compression is available in GDAL with gdalinfo --format gtiff


don't crash on requirements file from stdin with recursive include

safety version: 1.8.1
Python version: 3.5.5
Operating System: ubuntu 16.04 (via the ubuntu:16.04 docker image) (also for OSX 10.13.4 (17E199))

Description
Run safety on a requirements file with a recursive requirement from --stdin e.g. -r requirements.txt from requirements-dev.txt
what happened/what went wrong: safety crashed
what you expected to happen: safety not to crash and check the remaining lines. Logging a warning to stderr would be good too.
What I Did
wget https://raw.githubusercontent.com/mozilla/pontoon/6fe02c4734d6f60df45dd2f829cfdc3d40faa9b6/requirements-dev.txt

If there was a crash, please include the traceback here.

Traceback (most recent call last):
  File "/usr/local/bin/safety", line 11, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.5/dist-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.5/dist-packages/safety/cli.py", line 63, in check
    vulns = safety.check(packages=packages, key=key, db_mirror=db, cached=cache, ignore_ids=ignore)
  File "/usr/local/lib/python3.5/dist-packages/safety/safety.py", line 133, in check
    name = pkg.key.replace("_", "-").lower()
AttributeError: 'RequirementFile' object has no attribute 'key'

Use case is checking many repos without cloning them.

I'm wondering what would be the fallback decision? Should we look into current working directory for the included file named requirements.txt? Or should we just ignore and warn about those when we are reading from stdin?

Just for the records, a nice-to-have feature would be supporting HTTP URLs right away, and be able to perform such relative references.


Fixed hreflang tag with one translation and different schemas

tasks:

[x] test coverage

informations:

q
a

Fixed tickets
fixes #2022 fixes #2042

Related PRs
none

BC breaks
none

Documentation PR
none

@danrot i have fixed the second issue as well now.

@wachterjohannes Tests failing

Isn't there a test missing for checking if the x-default is not set on a single language?


Integrate with plenary?

Hey @Xuyuanp !
Cool plugin! I was wondering if you would be interested in collabin with github.com/nvim-lua/plenary.nvim since I think we'd both benefit from sharing some of the abstractions over vim.loop (and potentially upstream some of them to core someday).
If you're not interested in doing so, totally fine :)
Have a good day!

Thanks for your suggestions. will see


HDDS-4687. Disable compression for closed-container replication

What changes were proposed in this pull request?
During the measurement of closed container replication I found that the biggest bottleneck is the read side. 5 Gb container is replicated under ~3 minutes but ~2:30 was the downloading part.
Closed containers are replicated via GRPC. The source side creates an OutputStream on-the-fly (OnDemandContainerReplicationSource.java) and stream all the container content as a "tar.gz" archive to the client.
It turned out that the compression (the .gz part) is quite expensive:
I created a CLI tool to export containers to tar files (same logic as the replication but without streaming via GRPC, just saving to a file).
I have seen the 2:30 time to create the archive:
2021-01-13 05:51:25,302 [main] INFO debug.ExportContainer: Preparation is done
2021-01-13 05:53:53,472 [main] INFO debug.ExportContainer: Container is exported to /tmp/container-3.tar.gz

But when I removed the compression in TarContainerPacker.java, the speed was significant better (25 sec instead of the 150 sec)
2021-01-13 06:11:46,254 [main] INFO debug.ExportContainer: Preparation is done
2021-01-13 06:12:11,512 [main] INFO debug.ExportContainer: Container is exported to /tmp/container-3.tar

As a result I suggest turning off the compression for closed container replication.
More details: https://github.com/elek/ozone-notes/tree/master/20210113-closed-container-replication
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4687
How was this patch tested?
Tested in real kubernetes cluster:

data is generated with the freon data generator
containers were replicated with the freon container replicator (time is checked from the log)

Thanks for the review @arp7. The reason why I didn't merge it yet that I am not sure if we need more testing or not. After I turned off the compression I noticed other OOM related exceptions which may or may not be related.
There is a chance that with removing this obstacle will also remove a natural throttling and the faster streaming cause additional problems.
I am wondering if it should be tested with more realistic replication scenarios.
What do you think @arp7?

Yes we do need to introduce throttling separately, HDFS also has this for re-replication. Were the OOM exceptions seen in large scale testing or also on a smaller setup?

large scale testing or also on a smaller setup

Only on large scale testing. A local, smaller setup (where I replicated a few containers only) it worked well.

Closing for now as it seems to require further testing. It increases the chance that Netty buffers became full. Will open a separated issue about the buffer allocation.

Full details are here: https://issues.apache.org/jira/browse/HDDS-5188 (cc @arp7 @swagle)


Fix file path

Codecov Report

Merging #14 (e2a95a2) into master (7eecebc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eecebc...e2a95a2. Read the comment docs.


Is it possible to access the rooted deployed contract address on chain?

Could / does the rooted deployment return the instance address?

It does return it which isn’t a lot of use unless a contract called it. It also emits an event.
Otherwise you can compute the address within a contract, I should include the solidity code to do that, but basically you just need the springboard address, the hash of the bootstrap part and the address deploying it and compute the create2 address from that. No need for even an external call. I’ll add a code sample. :)


[BUG] Self signed admin certs not working proper

Im not quite sure about this one. I have self signed certs for nodes and admin and the opensearch cluster boots fine and show green status.
When i try to restore a snapshot using admin certs i get “Unauthorized”

Yet when I run the security admin tool, the certs are accepted. how come?

Any help would be greatly appreciated.
Thanks.

Thanks for reaching out.
Will move this to our security plugin repository.


Record is removed when BelongsTo record is null

I have Post model and User model
i have some post where user_id is null
public function user()
{
return $this->belongsTo('App\User');
}
Post::orderByJoin('user.name');
this only return records where user_id is not null.
how can i solve this. i also want that post where user_id is null

Post::setLeftJoin(true)->orderByJoin('user.name');

thanks


Changing library name

invdyn is a name closed to sot-dyninv.
To avoid occlusion, together with @olivier-stasse, @andreadelprete and @nmansard, we decided to change from invdyn to tsid standing for Task Space Inverse Dynamics

Done!


[Feature] [working] Working on emoji feature

I am currently working on emoji feature. I know we can send emoji on mobile but what about pc user. So i am gonna add one. Their is special react lib called react emoji. Should I use that Or should I create one from scratch.

use https://github.com/missive/emoji-mart

@tanay-pingalkar you can use a token called: "emoji" may be

Would be nice to have them bound to something like :emoji:

use https://github.com/missive/emoji-mart

dont know why emoji-mart is behaving so different

@tanay-pingalkar different how?

@tanay-pingalkar different how?

it is working as they had told in their docs

wala it works


logfile format is undocumented

Or at least, I  can't find the documentation for it.
It's CRI specific:

https://github.com/containerd/cri/blob/0dcaf6e98719b02ad9a1cf93aa3c7dcb4225f7fc/pkg/server/io/logger.go#L49-L50

I found an example of it in an old PR comment:

https://github.com/containerd/cri/pull/421/files#r152399214

But no other information.
The "tag" in particular ("P"? "F"?) I'm not sure what it indicates.
I have been searching for the source of that CRI format, because its turning my container's JSON-per-line output into invalid JSON (see https://github.com/ubuntu/microk8s/issues/803#issuecomment-554680594).
It doesn't appear to be opt-out, which I assume is for good reason, but the lack of docs made it quite hard to find who was responsible for the log decoration (fluentd, microk8s, kubelet, systemd, journald, snap, and containerd, were all options I searched through, until I found that PR comment).

The CRI format documentation is here https://github.com/kubernetes/community/blob/master/contributors/design-proposals/node/kubelet-cri-logging.md.

Thanks @Random-Liu I see you are the author of
https://github.com/kubernetes/kubernetes/commit/70a0cdfa8e05ac47d7dd04b032ceb79bead3fb5f
That change doesn't work for me when <log> is itself JSON, it is just finding the text, and it shows up in elastic search as a string log message, with the string content being JSON, something like {"level": "info", ...etc}
Its my understanding that fluentd needs to know here at time of ingest that the log is JSON, as it does in the first branch of the multiformat, the original one that expected each line to consist of only JSON.
Am I missing something? Is there a later stage in the pipeline where container output can be parsed into JSON, maybe in elastic search?

https://github.com/kubernetes/kubernetes/pull/54777 <-- to link these issues

@sam-github If your log content is json, it will just be streamed as json, I don't think we configure fluentd to parse the actual log content today.
To us, it is container output, we'll stream it as it is.

If your log content is json, it will just be streamed as json,

it will have have the CRI log format metadata prepended, making it non-json

I don't think we configure fluentd to parse the actual log content today.

its parsed here:
https://github.com/kubernetes/kubernetes/blob/c97baa339b5043424522dc7932fc3891f15543cb/cluster/addons/fluentd-elasticsearch/fluentd-es-configmap.yaml#L123-L125
that configuration would parse my log output:

{ "level": 30, "time":<PHONE_NUMBER>098, "pid": 28461, "hostname": "samtu", "name": "from-PINO", "req": { "id": 1, "method": "GET", "url": "/", "headers": { "host": "localhost:3000", "user-agent": "curl/7.64.0", "accept": "/" }, "remoteAddress": "::ffff:<IP_ADDRESS>", "remotePort": 46692 }, "res": { "statusCode": 200, "headers": { "x-powered-by": "Express", "content-type": "text/html; charset=utf-8", "content-length": "170", "etag": "W/"aa-z+ebXSEdArbZ+EXlN/WQjf6HV8c"" } }, "responseTime": 170, "msg": "request completed", "v": 1 }

Or see the json format docs, https://docs.fluentd.org/parser/json, for a smaller example, and notice how all the keys are parsed out ("method": "PUT", for example).
but the json parser won't match the input once the CRI data is prepended.
The fallback parser, https://github.com/kubernetes/kubernetes/blob/c97baa339b5043424522dc7932fc3891f15543cb/cluster/addons/fluentd-elasticsearch/fluentd-es-configmap.yaml#L127-L130, does sucessfully match the CRI metadata, but it treats the log message as unstructured text (unlike how the JSON parser would load it).
I don't see any way to next parser plugins in fluentd, to use a regex to match, then take the log part, and pass it to a sub-parser.
AFAICT, this means there needs to be a CRI plugin written, that checks the log part of the CRI format, and applies the JSON parser logit to it if it's JSON, and does what it does now with the regex parser if its non-json. And if its a series of key=value pairs... or apache ... I don't know. Its not clear to me how this is supposed to used. The CRI format clearly works as an internal data format shared with kubelet/kubectl log, but how to consume it with fluentd isn't clear.

{
  "timestamp": "xxxx",
  "stream": "stdout",
  "message: "Your escaped json log",
}

Before CRI log format is introduced, here is the docker log format. Are you saying that fluentd is going to parse "your escaped json log"? I never tried it, but I thought it wouldn't

Yes, I am saying that, Not from direct experience. I started post-containerd, but posts below claim that it used to work:

https://github.com/fluent/fluentd/issues/2021
https://github.com/fluent/fluentd/issues/2073

They claim that such nested JSON was indeed parsed, then was broken for a while (by fluentd). Its not clear why those issues were closed, They each say they were fixed but they just point to the other as the fix, which is infinitely circular. I don't have access to a non-containerd microk8s to try to see pre and post CRI annotation behaviour. I'll try to work through the config examples in those issues, and identify the fluentd versions they apply to, and compare to the one I got with kube/microk8s 1.13.
Its not entirely clear to me where the responsibility for setting this up lies, maybe its all on me to configure fluentd to parse containerd output?
I originally thought it was the ubuntu microk8s snap team that had a config that didn't cover this case, but it looks to me that containerd and kube and fluentd are all CNCF and ubuntu just packages the default configuration. Then issues like above make it look like JSON logs used to work with no mods to the default config with docker JSON. As well, I keep finding posts indicating that some effort has gone in, credit to you, to ensure that the es-fluentd addon parses CRI logs with default config.

This is still an issue with fluentd and it seems judging by the age of some of their issues they have no intention to fix it.

Is the format documented now?


PySpark shell does not work with Python 3.6.0

Our conda combine environment is python 3.6, but not compatible with Spark 2.0.1 that we're currently using:
https://issues.apache.org/jira/browse/SPARK-19019
Not a breaking problem, but prevents using nicer ipython shell with pyspark.  Worth keeping an eye on this.

Downgraded to python 3.5 in VM build.


missing assembly of "Microsoft.AspNetCore.Antiforgery"

The following error was reported when I downloaded the updated identityServer4.Samples:

An assembly specified in the application dependencies manifest (identityserverwithaspidandef.deps.json) was not found:
package: 'Microsoft.AspNetCore.Antiforgery', version: '2.0.1'
path: 'lib/netstandard2.0/Microsoft.AspNetCore.Antiforgery.dll'
This assembly was expected to be in the local runtime store as the application was published using the following target manifest files:
aspnetcore-store-2.0.3.xml

The error was temporarily fixed when I rewinded Microsoft.AspNetCore.All from version 2.0.3 to 2.0.0, but not sure how it happened.

You probably don't have the latest version of the .NET SDK.

It is, indeed I had .NET SDK version 2.0.0. Thanks!


Question about rot vale

Hi, thank for your wonderful work.
It is very impressive to me.
In bevfusion/mmdet3d/core/bbox/coders/transfusion_bbox_coder.py,
I noticed this line (line 61-69)
center[:, 0, :] = center[:, 0, :] * self.out_size_factor * self.voxel_size[0] + self.pc_range[0]
center[:, 1, :] = center[:, 1, :] * self.out_size_factor * self.voxel_size[1] + self.pc_range[1]
dim[:, 0, :] = dim[:, 0, :].exp()
dim[:, 1, :] = dim[:, 1, :].exp()
dim[:, 2, :] = dim[:, 2, :].exp()
height = height - dim[:, 2:3, :] * 0.5  # gravity center to bottom center
rots, rotc = rot[:, 0:1, :], rot[:, 1:2, :]
rot = torch.atan2(rots, rotc)
what is meaning of rot value in this python module?
torch.atan2 is element-wise arctangent function.
I'm not familiar with torch.atan2 function, so I can't understand why the shape of rot is [200,2]
I guess first list is arctangent of  rots and (0,1)..
Second list is arctangent of rotc and (0,1)... element-wise manner, maybe...
But it is not make sense..we use atan2 function to get angle between A,(0,1),B in my knowledge
Anyway, I think every object has just one rotation_z value.
I mean, rot value of a specific car is [x.xxx] not [[x.xxx], [y.yyy]]
But the return of rot is [[x.xxx], [y.yyy]] in this module. What is  the meaning of this?
Theses day, I'm not using English in my daily life so I think it is hard to understand my question...
I'm sorry about it..
Thanks!

Oh.. my bed.. Sorry, I confused..
I solved this..


Added support for camel with Boot 2.0;  fixes gh-673

this commit reverts https://github.com/spring-cloud/spring-cloud-contract/pull/387

Codecov Report

Merging #785 into 2.0.x will decrease coverage by 0.23%.
The diff coverage is 35.59%.

@@             Coverage Diff              @@
##              2.0.x     #785      +/-   ##
============================================
- Coverage     61.55%   61.32%   -0.24%
- Complexity     2120     2135      +15
============================================
  Files           225      231       +6
  Lines          8756     8874     +118
  Branches       1414     1431      +17
============================================
+ Hits           5390     5442      +52
- Misses         2592     2652      +60
- Partials        774      780       +6

Impacted Files
Coverage Δ
Complexity Δ

...ging/camel/ContractVerifierCamelConfiguration.java
0% <0%> (ø)
0 <0> (?)

...nner/messaging/camel/StubRunnerCamelProcessor.java
0% <0%> (ø)
0 <0> (?)

...ct/verifier/messaging/camel/CamelStubMessages.java
0% <0%> (ø)
0 <0> (?)

.../messaging/camel/StubRunnerCamelConfiguration.java
0% <0%> (ø)
0 <0> (?)

...ing/camel/ContractVerifierCamelMessageBuilder.java
0% <0%> (ø)
0 <0> (?)

...nner/messaging/camel/StubRunnerCamelPredicate.java
89.36% <89.36%> (ø)
14 <14> (?)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d7a86a...a9c28ab. Read the comment docs.


Add Pyramid to benchmarks

This looks like a great framework and since I'm coming from the Pyramid world I thought it would be interesting to have it in your benchmark comparisons!
Looking at this benchmark from 2012:
http://mindref.blogspot.com/2012/09/python-fastest-web-framework.html
It is much faster than most of the frameworks you included in your benchmarks and when looking at pypi it had 80,000 downloads in the last month vs bottle only having 40,000.

Happy New Year @kgriffs! Any chance you could update your benchmarks now?

Here are current download statistics of what are posted in the benchmarks:
Pecan:       31675 downloads in the last month
Pyramid:    43038 downloads in the last month
Werkzeug: 55286 downloads in the last month*
Bottle:        59555 downloads in the last month
Flask:         289161 downloads in the last month

Werkzeug numbers adjusted to exclude Flask downloads.

Its the holidays so in general downloads are lower than normal, but you can see that Pyramid does have a very good showing and shares the same Response/Request library with Pecan, which is WebOb.

I would love to see Pyramid benchmarked against Falcon too, as a current Pyramid user it would help me decide on whether to continue using it or move on to a different framework.

Pyramid is not that popular nowadays, we'll probably prioritize ASGI benchmarks vs the likes of Starlette.


CSV Import not populating record selector inputs

I am in the process of migrating all of my accounts over from my old CRM to Corteza
I have added all of the leads/accounts and now trying to import events/notes etc.
I added a dummy note and then exported it to get all of the field names. I then added my notes using the relevant fields.
The issue I am finding though is that the notes are not being attributed to the relevant leads/accounts.
Focusing on Leads just now
when adding notes manually, they are attributed to a lead by selecting the relevant lead from the dropdown Record Selector.
I am adding the Lead name to the CSV as shown in in the record selector but when I import the Notes and then view, the lead section is blank. when I view the lead, there are no notes added
the same is true for any imports where a record selector is used, Corteza seems to import all information but misses that out, There can be hundreds of notes and to go through them all and manually add the record will take for ever

Hi @PaulMcF1987, you're right, currently, we can't import fields type record as we don't have an option to keep a reference. @tjerman would your magical importer be able to help sort this out?

I really need this functionality also, I'm happy to contribute to the migration guide. I'm moving my uncle over from ACT! and this record selector issue from CSV is a real drawback. I'm on 2021.3

Sorry, but we haven't implemented that bit yet; I'll look around a bit to see if we can have it done in the near future.

Hello, is there any update on this? It would be really nice to be able to use the UI to migrate from a different CRM to Corteza.

No update yer.


Update resolvers for User and Tweet Types

Use models and promises to resolve the fields in User and Tweet Types

Implemented in d52850f04c9de02901ec7ddf1f22c81f158ce582


Update project files and add IncludeSymbols

https://github.com/khalidabuhakmeh/Htmx.Net/issues/23


FileNotFoundError reported for unsaved files

See example below:
https://user-images.githubusercontent.com/1657652/211078520-14bb7c79-81d7-499d-a936-4d6293838b7c.mov
Version info:
VSCode:

Version: 1.74.2
Commit: e8a3071ea4344d9d48ef8a4df2c097372b0c5161
Date: 2022-12-20T10:26:09.430Z (2 wks ago)
Electron: 19.1.8
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 22.2.0
Sandboxed: No

Extension: v2022.6.0

@dmartin please share the logs from Output > flake8.

Sure, the relevant log is:
/usr/local/bin/python -m flake8 --format='%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s' --toml-config=api/pyproject.toml Untitled-3
CWD Linter: /platform
untitled:Untitled-3 :
'0,1,E,E902:FileNotFoundError: [Errno 2] No such file or directory: 'Untitled-3''

(The --toml-config flag is due to my configuration:)
 "flake8.args": [
    "--toml-config=api/pyproject.toml"
  ],
  "flake8.importStrategy": "fromEnvironment",

This is inside a devcontainer, if that is possibly a contributing factor.

The error itself is reported by flake8. All the extension is doing is showing what flake8 is giving us as a problem for that line. Please file this on https://github.com/PyCQA/flake8/issues .

Ah! sorry missed that. Yes, sorry about that.
This should be easy enough of a check to add. I forgot that for flake8 we were not able to use the stdin to pass the unsaved content to get the result and we had to rely on using the file on disk to get the issues. For other linters we were able to use stdin to pass the content, so unsaved buffer did not matter.


Fix typo in PostDocumentQuery query params builder.

I noticed the OverwriteMode option not working for POST document operation and on investigation discovered a typo in the query-string builder.

Wow good catch!
A method that takes two parameters would've helped avoid this.
Example:
query.AddQueryParam("overwriteMode", OverwriteMode.ToLower());

public static class StringBuilderExtensions
{
    public static StringBuilder AddQueryParam(this StringBuilder builder, string name, string value)
    {
        builder.Add($"{name}={value}");
    }
}

I think it's worth opening a small separate improvement. What do you think?

Yeah that probably would have been a good idea, thought we may not benefit from it now that most of these are already implemented the way they are.  Also we use a List<string> and then join with &s, but I think your approach of an extension method would work for List<string> instead of StringBuilder.


HTTP protocol error on packettotal.com

https://packettotal.com/app/analysis?id=31420f40624d6d0553a8b4fb36bf23dc&name=ssl

They think it is ok to send error log messages while sending HTTP headers:
< HTTP/1.1 200 OK
< Date: Thu, 18 Apr 2019 10:30:20 GMT
< Transfer-Encoding: chunked
< Connection: keep-alive
< Set-Cookie: __cfduid=dfc82fa991d58e18851cfb149a75437841555583419; expires=Fri, 17-Apr-20 10:30:19 GMT; path=/; domain=.packettotal.com; HttpOnly
< /usr/local/lib/python3.4/dist-packages/packettotal-1.0-py3.4.egg/packettotal:
< Trying.../etc/packettotal/config.yaml:
< [Errno 2] No such file or directory: '/etc/packettotal/config.yaml'
< Trying...$HOME/packettotal/config.yaml:
< [Errno 2] No such file or directory: '$HOME/packettotal/config.yaml'
< Trying.../usr/local/lib/python3.4/dist-packages/packettotal-1.0-py3.4.egg/packettotal/config.yaml:
< Using config at: /usr/local/lib/python3.4/dist-packages/packettotal-1.0-py3.4.egg/packettotal/config.yaml
< Content Type: text/html
< Set-Cookie: __cflb=230809059; path=/; expires=Fri, 19-Apr-19 09:30:20 GMT; HttpOnly
< Expect-CT: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
< Server: cloudflare
< CF-RAY: 4c95f670ee124ec6-DME
<

So, it seems that we should accept any chars in HTTP/1.1 header keys.

core/pull-requests/1212

https://memo.naver.com/ site show HTTP protocol error too
(Need to required account)

@swan201 Moved into a new issue: https://github.com/AdguardTeam/CoreLibs/issues/882
Thank you!


AWS cloud provider support

Adds cloud provider integration into the AWS profiles. If this approach works for others, then I can look at doing similar in at least GCP and Azure.
I have confirmed that dynamic PVCs are fulfilled with EBS volumes with this. I believe ELBs work too, but I haven't tested it yet.

YAYAYYYYYYY


Add status reasons to S3 notification stats

Value Statement
As a VANotify business line customer
I want to be able to view my notification stats in DOMO
So that I can build reports and views based on my needs
Acceptance Criteria
WHEN every day after the “create nightly notification status” job is run
THEN a task is executed that exports daily stats as a CSV file to S3
AND notifications are seperated by service, template, status and status reason
Checklist

[x] Add status reasons column to fact_notification table
[x] Update existing fact_notification_dao methods to group by status reason
[x] Update CSV generator in reporting_tasks to include status reasons column

Assumptions

Notification stats will recalculate for past 4 days

Additional Info/Resources

Schema for CSV file: service id | service name | template id | template name | status | reason | count
If there is no status reason, then leave blank(?)

Out of Scope

Uploading to Big Query

Open Questions

QA testing will be done to ensure the CSV files reflect changes in status.

Testing for status reasons can be done in the development environment with identifiers located in this file: https://docs.google.com/spreadsheets/d/1KdjgA-8ZvoUQyQtBZfk8HEzSkvMNX7-rJ5zQMr6RiUE/edit#gid=0

This story has been verified,
Unit test coverage for the change has been verified - verified new column exists and population with the status reason when there is a valid one
handling of no status reason when is there is none - csv is generated with blank status reason.
The csv file generated displays the status reasons field as expected.
The validation of the count displayed previously during desk check.
The generation of csv files based on daily execution of report was verified.
see csv file attached above.

Will need to deploy to get into production.

Deployed to production


Add community pager to show images with kitty

This adds a custom pager to show images within the terminal emulator Kitty. I use it every day, so I thought it might also be interesting for others.
Usage instructions are included in the script. Requires the kitty terminal emulator.

Thank you!


New version: Microsoft.AzureDataStudio version 1.50.0

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Hi @erpett,
would it be possible to also include the arm64 version into your package updates?


Stammer fails after opening

I installed all three dependencies, I put stammer.py in the same directory as ffmpeg, but every time I try to run Stammer, it gives me this message:
"Traceback (most recent call last):
File "C:\ffmpeg\stammer.py", line 17, in
import image_tiling
ModuleNotFoundError: No module named 'image_tiling'"
and then it closes. What's happening?

I forgot to download the other five python files


Send SIGHUP to the process group in the terminal, not just the leader

Closes gh-37
@sknepal could you try this out and see if it fixes your issue with firejail?

Firejail is still around. Doesn't seem to fix the issue.

Myeh. Maybe part of its sandboxing involves launching the child in a new process group, so it still doesn't get the signal.
Have a look for any options for firejail to quit on SIGHUP. Or work out if there's something else you can do to make it quit, e.g. another signal. If so, you can subclass UniqueTermManager and override its client_disconnected method.


Select Control cannot Type-to-select on Material UI Next

On Material UI Next, the Select component behaves different from Material UI 0.19.
On the old version, you could open the select box, and type to select an option, then press enter to select the option.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Opening the select box and typing one of the valid options should highlight said option and pressing enter should select it.
Current Behavior
Typing / pressing enter doesn't select anything, but it used to work under Material UI 0.19
Steps to Reproduce (for bugs)

https://material-ui-next.com/demos/selects/
Click on Age
Type "Twenty" and press enter
Try the same thing on the Native Select component below.
Do the same steps on http://www.material-ui.com/#/components/select-field (It works here)

Context
This small feature help users with navigation / selecting. It's expected behaviour in that component.
Your Environment
It doesn't really matter, you can replicate on the Material UI Next website.

Duplicate of #8191


[$500] IOU- When replacing receipt and downloading it, previous receipt with new receipt name is downloaded

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.14-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to IOU request details that has a receipt
Click on the receipt
Click 3-dot menu > Replace
Upload another receipt
After the upload is complete, download the receipt

Expected Result:
The latest receipt will be downloaded
Actual Result:
The previous receipt is downloaded, while the receipt file name is the name of the latest receipt
On Android and iOS app, it downloads the previous receipt (file name is not affected/not relevant) after replacing the receipt
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/9832528f-9c30-42c3-a343-7921ac46c0dd
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0113378cba031fc595
Upwork Job ID:<PHONE_NUMBER>446364160
Last Price Increase: 2023-12-20

Proposal
Please re-state the problem that we are trying to solve in this issue.
The link source download does not update when replace the image
What is the root cause of that problem?
Currently, when the source changes we don't update in the threeDotsMenuItems.
What changes do you think we should make in order to solve the problem?
We should add the source into dependence
What alternative solutions did you explore? (Optional)

I am trying to access the issue details using the link "https://stackoverflow.com/c/expensify/questions/14418" but i am getting you do not have access. Can you help on it ?

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01a59961216a1ee633?viewMode=1

This is regression from #32647 which fixes #31105 (confirmed by reverting locally)
It's still within regression period

In that case, @dukenv0307 please create a quick PR for this

@abdulrahuman5196 should we close these GHs in favor of what @situchan mentioned above or move forward with the proposal review?

Heads up, I will be offline from Friday, December 22, to Thursday, January 4, 2024. I will not be actively watching over this GitHub during that period. If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

@abdulrahuman5196 should we close these GHs in favor of what @situchan mentioned above or move forward with the proposal review?

@alexpensify We can close this issue, given the PR was merged. This was a regression fix.

👍🏼 - closing

@shubham1206agra - can you please identify if this PR triggered the deploy blocker or if there is another reason for this update? Thanks!

Oh it's a false alert actually

@shubham1206agra - can you please share more context as to why the alert is wrong? It will be helpful to have it recorded. Thanks!

@alexpensify https://github.com/Expensify/App/pull/33586 is the offending PR. Some contributor marked this by mistake as this issue is already deployed to production.

Thank you! I will continue the process to prepare for the payment date.

Based on the 👎🏼 here https://github.com/Expensify/App/issues/33363#issuecomment-1874209603 and the note here https://github.com/Expensify/App/issues/33363#issuecomment-1874348862, there is no payment action here since this issue was handled in other GH.


docs(takeUntil): update docs to match operator's behavior

Description:
This PR only updates takeUntil docs to reflect its functionality.
Related issue (if exists):
#2160

Coverage remained the same at 97.261% when pulling a82121a164ad8f085bcd13883cb960953d302257 on martinsik:update-takeUntil-doc into 1f55dade6757d4fdee5501cea8028ea77f5e8fcc on ReactiveX:master.

This is correct, thanks @martinsik !


Patch 1

Please review our Contribution Guidelines to ensure your changes abides by it.
Review your changes and complete the checklist below.

[X] Company name
[X] Company description
[ ] GitHub link
[X] How Elixir is used
[X] Sorted alphabetically

No Github link with relevant stuff.

Thank you @h4cc 👍


TypeError: global is undefined

in version 2.2.1 When I try to import the lory with webpack as follows:
import {lory} from 'lory.js/dist/jquery.lory.js'

I'm encountering the following error TypeError: global is undefined with message:
var NativeCustomEvent = global.CustomEvent;

How to fix?

Ok, is seems lory isn't supporting babel-loader, so workaround is here: https://github.com/gaearon/react-hot-loader/issues/133

Did you want the jquery version of lory?

Not exactly, any one working


Fix Scoring System

The current algorithm for the scoring system is inaccurate and not desirable as it starts from a high value and counts down.
It is also not implemented, as it gives high scores to players if they end the round fast enough. This is not by design. Players should only be given high scores if they finish the level.

Look for better algorithm for score which counts UP rather than down
Only give high scores if the player is successful

Hey @museHD ,
I'm interested in contributing to this issue, so before I start working on it, would you mind sparing your time explaining what the issue is about and pointing me to some resources to get started.

Hey @museHD , I would also love to work on this issue. I also noticed that the README has the wrong project named in the git clone line so I could fix that too if needed.

Hi,
Thank you for your interest. Unfortunately I don't think there's enough work for two people so I'll just assign it to @udaybadhe as they were first. If you feel like both of you need to work on it let me know.
The high score calculation and game state logic is handled within the following lines: https://github.com/museHD/MineWalker/blob/master/minewalker.py#L169-L202
I personally don't know much about what the right way to calculate game scores is, so you might have to do some research on that.
@Rohan-G thanks a lot for picking up on the readme typo! Could you please create an issue and a pull request for it?
Feel free to play the game as I'm sure there are other bugs you could find or enhancements you could make. Additionally, you could have a look at some of my other projects to raise issues or look at fixing existing ones.
Cheers!


Bower "unable to find a suitable version of polymer" on empty clean Polymer project

I have create an empty polymer project using the polymer-cli and the first thing I wanted to do was try the px-tree web component, however this is the error I get when trying to install:
Unable to find a suitable version for polymer, please choose one by typing one of the numbers below:
    1) polymer#^1.9.0 which resolved to 1.11.0 and is required by px-app-nav#2.0.11, px-icon-set#2.0.17, px-tree#2.0.5
    2) polymer#^1.9.1 which resolved to 1.11.0 and is required by px-app-helpers#1.4.2, px-branding-bar#1.0.6
    3) polymer#1.9 - 2 which resolved to 2.2.0 and is required by app-layout#2.0.4, iron-a11y-keys-behavior#2.0.1, iron-behaviors#2.0.0, iron-collapse#2.0.0, iron-dropdown#2.0.0, iron-fit-behavior#2.0.1, iron-flex-layout#2.0.0, iron-icon#2.0.1, iron-iconset-svg#2.1.0, iron-media-query#2.0.0, iron-meta#2.0.2, iron-overlay-behavior#2.1.0, iron-resizable-behavior#2.0.1, iron-scroll-target-behavior#2.0.0, iron-selector#2.0.0, neon-animation#2.0.1, px-theme#3.1.2
    4) polymer#^2.0.0 which resolved to 2.2.0 and is required by my-app

Prefix the choice with ! to persist it to bower.json

? Answer 3

Unable to find a suitable version for webcomponentsjs, please choose one by typing one of the numbers below:
    1) webcomponentsjs#^0.7.24 which resolved to 0.7.24 and is required by polymer#1.11.0
    2) webcomponentsjs#^1.0.0 which resolved to 1.0.17 and is required by my-app
    3) webcomponentsjs#^v1.0.2 which resolved to 1.0.17 and is required by polymer#2.2.0

Prefix the choice with ! to persist it to bower.json

? Answer 3

edit: took a guess and added the next questions - now to see if it works.
Any suggestions?

Predix UI components are (for now) built against Polymer 1.x. The docs explain this: https://www.predix-ui.com/#/about/start-developing.
TL;DR - resolve for polymer 1.x and webcomponents 0.7.x


Initial commit for pyarrow support

Problem & Solution Description (including issue #)
This PR adds support for pyarrow for

IO with parquet files (pyarrow.parquet and pyarrow.dataset)
In-memory tabular representation (pyarrow.Table)

There is a lot of overlap between this and pandas (as pandas uses pyarrow as a backend), but in principle pyarrow offers much better scaling for, e.g., reading/writing data in batches, streamed computations (pyarrow.acero), etc., so it seems worth having.
Code Quality

[ ] My code follows the code style of this project
[ ] I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
[ ] My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
[ ] Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

A few notes:

I haven't succeeded in modifying the test suite to cover all of the new pyarrow bits. The conversion from an Astropy Table to a pyarrow Table (which should raise a NotImplementedError) never runs, for example
Pyarrow/parquet schema supports metadata (both at the schema-level and at the individual field level); I need to add code to propagate metadata to/from the schema appropriately

Linking this PR to #66


about preprocessing

It would be great if you could share the pre-training segmenttion and flow files for UCF dataset?

Hi, sorry for keeping you waiting. In case you still need it, here is a link to preprocessed files.


Multiple sender usernames

This page is linked to from Create multiple sender usernames, which says:

Sender usernames cannot be enabled for Azure Managed Domains or custom domains with default sending limits. For more information, see Service limits for Azure Communication Services.

But this service limits page doesn't mention anything about limiting the number of sender usernames.
(I actually only care about sender display names, not addresses, but it seems these concepts are linked?)

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9083c4c3-dd89-b628-84e3-77faf5765bac
Version Independent ID: b4e04b2d-7b24-1f50-5fad-17d11606e15b
Content: Service limits for Azure Communication Services - An Azure Communication Services how-to document
Content Source: articles/communication-services/concepts/service-limits.md
Service: azure-communication-services
Sub-service: data
GitHub Login: @tophpalmer
Microsoft Alias: chpalm

@fowl2
Thanks for your feedback! We will investigate and update as appropriate.


Sequence index not being updated for mocked SOAP operations

The sequence index is not being updated correctly when a SOAP operation response has been returned.

This issue has been resolved. Closing issue.


Refactor tsdb tests to use test util functions to test different sample types

This PR is the first part of adding support for out-of-order ingestion of native histograms. This code refactors the tests involved in out-of-order sample ingestion to be able to test for different sample types (floats, integer native histograms and float native histograms).

@krajorama This is ready for another review


Made sliding on slope an optional feature

This pull request fixes issue #102 to control whether the player slides on slopes due to gravity. In some areas slope-sliding is desirable (ski ramps) and in others it's not desired (walking ramps). This change adds an option to the GroundPhysicsSettings resource to control whether the player will stop on the slope.

Cool thanks!