Updated the base images to use debian:bullseye

Python, Go, Java dockerfiles are updated for Beam Playground to use debian bullseye
Python, Gom Java dockerfiles are updated for Beam SDK to use debian bullseye
Java dockerfile uses openjdk. openjdk updates the base image on their end.
Even though the default images uses latest distribution(eg: bullseye) of the OS,  it's good to have control over the distribution that we use by specifying the distribution name while pulling the image.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R : @tvalentyn , @emilymye

cc: @snkalinin FYI re: playground changes.

I wasn't sure if this was just a missed file, but did you want to update the Java image as well? https://github.com/apache/beam/blob/da11b84ba29f75a5764826f465b5bca9fad72a0e/sdks/java/container/Dockerfile#L19
I think it might be better to pin it to a specific version just for consistency go/python, e.g. by doing
FROM openjdk:${java_version}-bullseye

If not, can you change description (non-Java in title maybe) saying specifically why we aren't updating Java?
I believe the Java image updated here is for Playground, not the SDK itself

I wasn't sure if this was just a missed file, but did you want to update the Java image as well?
https://github.com/apache/beam/blob/da11b84ba29f75a5764826f465b5bca9fad72a0e/sdks/java/container/Dockerfile#L19
I think it might be better to pin it to a specific version just for consistency go/python, e.g. by doing
FROM openjdk:${java_version}-bullseye

If not, can you change description (non-Java in title maybe) saying specifically why we aren't updating Java?
I believe the Java image updated here is for Playground, not the SDK itself

I agree to have control over the distribution of the OS we use(Like how we do it with Python and Java). I pinned the OS distribution to openjdk.

retest this please

FYI @fernando-wizeline who is working on Java 17 (17-bullseye should exist, but possibly touching same Dockerfile)

Failures look unrelated.


UTY-2647: bad sync point in ecs view manager

Description

Bad sync point by looking up components using WorkerSystem during an update in SpatialOSReceiveSystem
Changed codegen to use SpatialOSReceiveSystem instead

Tests

[ ] help?

Documentation

[ ] Changelog

Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@zeroZshadow does removing the view not render this redundant? Unless its a different view

Is the workerSystem used in the generated classes anymore? If not, lets get rid

Yes, its used to map spatial-unity entities.


feat(wasmexec) New package: wasmexec

This package aims at containing a collection of host functions for
multiple hosts, to support WebAssembly modules compiled by the TinyGo
and the Go compilers.
For the moment, only the Go host is supported, i.e. it's Go host
functions implementations. Host functions have empty implementation.
In the future, it will contain real implementations, and it will be extended
to a Rust, Python, PHP, Ruby implementations.
I wonder though if we should support host functions required by the Go
compiler. It's really focused on JavaScript, plus it is experimental.
cc @MarkMcCaskey @syrusakbary

@Hywan I began implementation of this in Wasmer on the Rust side; I almost got Hello World working but we found out there's an existing Rust implementation -- I contacted them about adding a license to their project so that we could possibly use a forked version to avoid duplicating work.  We haven't heard back since posting that issue!
It is a bit messy to support, the ABI is a bit strange for WASM and requires emulating a bit of JS.

Everything is fine.
I think supporting Go Wasm ABI is messy because it's heavily JS centric. However, the TinyGo Wasm ABI is relatively small (2 imports) and make sense outside of a browser.
The question is: Where do we store those implementations? In the wasmer.git repository, nah. In this repository, why not, but it'll contain Python, PHP, Ruby etc. in the future, and I reckon this repository should only contain the go-ext-wasm package, not other packages. So, should we create another repository? One that is runtime agnostic.

Yeah, I agree -- it's pretty tricky.
In my opinion it depends on if we want to use it in the wasmer CLI binary.  I think, in general, we should keep things related to the Wasmer CLI in the wasmerio/wasmer repo.  If it's just for library use then I don't have an opinion about where it should live (though probably not in wasmerio/wasmer if it's not in the binary)

Do we really need this on the go extension? I see it more as a separate addition.
As a note, this project did already the implementation (perhaps people can just use this project)
https://github.com/vedhavyas/go
https://github.com/vedhavyas/go-wasm/blob/master/imports.go

The work done by @vedhavyas looks great! We should also support PHP, Python, Ruby and other implementations, so that Wasm modules emitted by go can be used more broadly.
@syrusakbary Should we (Wasmer) lead this effort? If yes, where is the best place to create this project?

I've been trying out this branch and am attempting to pass strings back and forth from Go to the wasm runtime compiled from tinygo. The tinygo file is:
//go:export req
func req() int64 {
	s := "blah"
	return int64(uintptr(unsafe.Pointer(&s)))
}

And fails during compilation with not implemented in env_resource_write. I'm new to wasm land. Can you point me in the right direction to implement env_resource_write myself?

@Hywan I thought of reaching out to you guys to include the imports as part of the wasmer but decided against it since its very js centric and hoping that would change in the future. Not sure how to proceed for now.

@mjibson That's expected to get a not implemented at that progression.
@vedhavyas I think we have a synergy to develop here.  I won't find legimitate for Wasmer to “import” your project in the wasmerio organisation. However, it makes sense to create a go-wasm org, and propose several repositories, like go, javascript, python etc. respectively for the Go implementation, JavaScript implementation, Python implementation etc. for host functions to run Go Wasm modules. Issue is that there is yet no standards to plug host functions to a runtime (we are working on this area though). So including the “go-wasm” project inside Wasmer would imply the code is specific for the Wasmer runtime, and it's not a good idea. Hence the go-wasm org. We can help on that area! Thoughts?

Yes, I'm aware. Can you point me in the right direction to implement it?

@mjibson Which compiler did compile your Wasm module: go or tinygo?

@Hywan

So including the “go-wasm” project inside Wasmer would imply the code is specific for the Wasmer runtime, and it's not a good idea.
Agree!

Issue is that there is yet no standards to plug host functions to a runtime (we are working on this area though)
You mean wasmi. Not sure what you mean by this :-D

It makes sense to create a org go-wasm with other language implementations if we have enough excitement from the community to build a port of/ something similar to go-wasm in other languages since it is too JS specific? This I'm not sure.
But, IMO, it is safe to give it shot :-D

@Hywan tinygo. I was hoping to implement the solution myself, but I'm new to wasm and so am looking for like a pointer to a doc or something about what I'd need to do. But I'll also try go-wasm.

@vedhavyas

You mean wasmi. Not sure what you mean by this :-D

Not wasmi. What is missing right is standard interface to interact with Wasm runtimes. W3C has defined a standard for JS, but standards are missing for C, Go, Python, PHP etc. A draft exist for C (https://github.com/WebAssembly/wasm-c-api), and we are proposing 2 other drafts for Python and PHP (resp. https://github.com/wasmerio/wasm-python-api and https://github.com/wasmerio/wasm-php-api). Nothing yet for Go. Check https://github.com/WebAssembly/design/issues/1290 to learn more.

It makes sense to create a org go-wasm with other language implementations if we have enough excitement from the community to build a port of/ something similar to go-wasm in other languages since it is too JS specific? This I'm not sure.

What go-wasm must provide is a collection of implementations, and then it's up to the Wasm runtime to add a “wrapper”/adapter/bridge to plug this collection into its host function API. I think it's the best strategy. Thoughts?
I see that https://github.com/go-wasm is already reserved :-(. Any name idea?
@mjibson Can you open another issue please? This issue aimed at discussing about defining the implementation, where, and how. I reckon it's a little bit too early to try to solve the intentional “not implemented” issue ;-).

@vedhavyas Any progress on that side :-)?

@Hywan still on it but with the crisis, I had other things taken care off. I will create the agreed Org and move the go-adapter there.

@Hywan the lib is moved here - https://github.com/go-wasm-adapter

<3 thanks!

I also implemented Go wasm runtime. https://github.com/mattn/gowasmer

Closing this issue as there is now multiple projects handling this :-).


Scheduler Migrations: AppDefinition validation

For now, we want to restrict the configuration possibilities to simplify the implementation:

We only allow on readinessCheck.

[we can also think of more restrictions if it makes implementing an MVP easier and supports the Scheduler Migrations use case of one instance]
Depends on #3500.
Context: We want to be able to drive scheduler upgrades manually. See MARATHON-856 (private, sorry).

A scheduler application can not be scaled
A scheduler application has always an instance count of 1
A scheduler application has always the upgrade strategy (0, 0)

@aquamatthias I changed your comment and integrated it into the description of the issue


Basic Unit Test Framework

This PR ...

Adds a github action file that builds the package and runs the CI
Adds some basic unit tests against pyfixest - not all of them pass yet

I will continue with this in the next days =)

thanks!

Took out the failing tests and relaxed the SEs tolerance a bit. Maybe you can merge it so that we can test if the CI workflow is running?


Apply body query continuously while typing

Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
This adds a new on_change callback to TextBox, which is called whenever the text is changed (and valid). In QueryableBody we now use this to apply the query.
I played around with some major refactors to replace callbacks with events, but I think it adds a ton of complexity for little gain. The main issue is you need a way to link callback events to their individual senders (for when there's multiple instances of the same component type emitting), which adds a whole other layer of complexity. It's still possible in the future but still not worth it I think.
Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
Without a debounce this could potentially be annoying and slow to apply continuously. I wanted to implement a debounce but it's difficult because the debounced callback has to be called on the main thread (because ViewContext and the event queue is a thread local), but the main thread doesn't have a LocalSet so we can't do that. I think it would require a pretty major refactor to make this work.
QA
How did you test this?
Manual testing in the UI. Added unit tests.
Checklist

[x] Have you read CONTRIBUTING.md already?
[x] Did you update CHANGELOG.md?

Only user-facing changes belong in the changelog. Internal changes such as refactors should only be included if they'll impact users, e.g. via performance improvement.

[x] Did you remove all TODOs?

If there are unresolved issues, please open a follow-on issue and link to it in a comment so future work can be tracked

Closed in favor of #284


[1.21.1/1.21.3 Bug] Custom end skybox disappears when ender dragon is alive

Bug Description
Custom resource pack end skies disappear when the ender dragon is alive. This used to be a bug in OptiFine too a long time ago but was fixed, needs to be fixed for FSB.
Screenshots
Alive:

Defeated:

Example properties
{
	"schemaVersion": 2,
	"type": "single-sprite-square-textured",
	"texture": "skybox:end/end.png",
	"blend": {"type" : "replace"},
	"properties": {
		"changeFog": true,
		"fogColors": {"red": 0.09803921568627451, "green": 0.023529411764705882, "blue": 0.11764705882352941, "alpha": 1.0}
		},
	"conditions": {"worlds": ["minecraft:the_end"]},
	"decorations": {
		"showSun": false,
		"showMoon": false,
		"showStars": false
		}
}

This was the report  for the bug in OptiFine.

bumping this before i try to dig through the code for the mod and see if i can find the problem myself


Underrun bug

Sometimes the song info is "underrun" which leads to info like song duration and song volume to be missing. Not sure how this happens, I think it's something when switching songs quickly, though I wasn't able to replicate it yet.
Another thing to consider is the fact that the volume is also underrun, which means that it might be a problem of the sink (if the sink calls the song in the background then well that might explain it, but it would make more sense if the sink would handle the volume itself). So perhaps the problem is because of the sink, though I wouldn't conclude that on the info known so far.

I got the bug again, it happened while I was download (updating) a game in heroic games launcher. The exact error message is something like
ALSA lib pcm.c:8526:(snd_pcm_recover) underrun occured

The error message is quite messed up, most likely because the TUI is the problem here.

The issue seems to be related to the disk. When profiling I observed that the R/s, T.read and T.write were all important factors when the audio stopped and was underrun. So the disk seems to be the reason why this problem happens, it also makes sense that it happens when downloading (updating) something, especially a game (given that we have to write a lot to disk).

It also makes sense that this happens only with vimp (local music, especially given that I am still using .wav files only). When you play music from the browser it's not really an issue for the disk, mainly for the network and memory. However when you have to load the music data from disk then it's not at all on the network and probably less on the memory too. Perhaps I could preload music, or maybe part of it. That could potentially reduce the load on the disk for the price of higher memory usage (which I would gladly trade off).


Remove redundant data member from BaseOperator class.

Remove the _operatorName data member from this class, and replace it
with getOperatorName() method call. This avoids storing the information
in multiple places.

@atumbde The logger/traceContext code appears in most part of query execution code, and needs to be addressed/cleanedup separately.

Current coverage is 66.53% (diff: 100%)

Merging #1003 into master will decrease coverage by 0.05%

@@             master      #1003   diff @@
==========================================
  Files           740        740
  Lines         35139      35138     -1
  Methods           0          0
  Messages          0          0
  Branches       5236       5236
==========================================
- Hits          23399      23378    -21
- Misses        10207      10231    +24
+ Partials       1533       1529     -4

Powered by Codecov. Last update 4e369a2...cf255fa


🐞 - Changing Programming language doesn't change file extension

Which @codeimage/* package(s) are the source of the bug?
codeimage, ui
Please provide a screenshot or a video to a minimal reproduction of the bug
No response
Description
When selecting a new language, it does not change file extension in UI.
Let's suppose TypeScript is selected by default, so there will be a TypeScript icon and index.tsx filename.
Now, If I change the language to Kotlin, the logo will be correctly updated, but filename will remain index.tsx which is incorrect. It should be changed to index.kt
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[X] Edge

Which operating systems have you used?

[ ] macOS
[X] Windows
[ ] Linux
[ ] iOS
[ ] Android

Hey @hadiyarajesh, thanks for reporting the issue 😄 I'll roll out the fix tomorrow

Up with v1.1.1 release 😄

Perfect. Thanks @riccardoperra


fix typo

...

Coverage decreased (-0.3%) to 97.917% when pulling 5d7c55edd408585571b9c8457263bf29f378ed46 on janpio:patch-1 into a63f2df6acd0811c66d0b548ebcd7626b3cfc150 on piotrmurach:master.

Coverage decreased (-0.3%) to 97.917% when pulling 5d7c55edd408585571b9c8457263bf29f378ed46 on janpio:patch-1 into a63f2df6acd0811c66d0b548ebcd7626b3cfc150 on piotrmurach:master.

Coverage decreased (-0.3%) to 97.917% when pulling 5d7c55edd408585571b9c8457263bf29f378ed46 on janpio:patch-1 into a63f2df6acd0811c66d0b548ebcd7626b3cfc150 on piotrmurach:master.

Coverage decreased (-0.3%) to 97.917% when pulling 5d7c55edd408585571b9c8457263bf29f378ed46 on janpio:patch-1 into a63f2df6acd0811c66d0b548ebcd7626b3cfc150 on piotrmurach:master.

Coverage decreased (-0.3%) to 97.917% when pulling 5d7c55edd408585571b9c8457263bf29f378ed46 on janpio:patch-1 into a63f2df6acd0811c66d0b548ebcd7626b3cfc150 on piotrmurach:master.

Thanks! ❤


Check whether evenI is still faster than even

Module Math.NumberTheory.Moduli.Jacobi contains an interesting helper function:
-- For large Integers, going via Int is much faster than bit-fiddling
-- on the Integer, so we do that.
evenI :: Integral a => a -> Bool
evenI n = fromIntegral n .&. 1 == (0 :: Int)

Actually, it was definitely much faster than even from Prelude before GHC 8.4 due to trac 14437. We should check (looking at Core and CMM), whether evenI is still faster. And if it is, push its definition into base for the profit of the whole community.

Unexpectedly, evenI appears much faster than even from Prelude.
import Data.Time.Clock

evenI :: Integer -> Bool
evenI n = fromIntegral n `rem` 2 == (0 :: Word)

lim :: Integer
lim = 100000000

main :: IO ()
main = do
  t0 <- getCurrentTime
  print $ maximum $ filter even [1..lim]
  t1 <- getCurrentTime
  putStrLn "even"
  print $ diffUTCTime t1 t0

  t0 <- getCurrentTime
  print $ maximum $ filter evenI [1..lim]
  t1 <- getCurrentTime
  putStrLn "evenI"
  print $ diffUTCTime t1 t0

With GHC 8.4.1:
$ ghc -O2 Even.hs
[1 of 1] Compiling Main             ( Even.hs, Even.o )
Linking Even ...
$ ./Even
100000000
even
6.367393s
100000000
evenI
4.35664s

I looked into CMM. Prelude.even results in remInteger n 2, which is left as is. On contrary, fromIntegral :: Integer -> Word is very cheap and remWord n 2 is optimised to bitwise and.
I'll file a ticket in GHC trac.

Filed as https://ghc.haskell.org/trac/ghc/ticket/15327

Anyway, evenI has been refactored in #103 and is in line with rem4is3 and rem8is1or7, so closing.


Etcd client raises a ReadTimeoutError traceback

When the etcd client times out its watch, it is generating a traceback as seen below. In our code we are catching the TimeoutError exception. However, the etcd client is logging the exception and as a result a stack trace is printed in our stdout confusing our users.
Please fix this bug to either
a) not log the exception in your code below
or b) to catch and handle it.
except:
_log.exception("Unexpected request failure, re-raising.")   <----- offending line
raise
_Traceback seen in our console_
ERROR etcd.client ReadTimeoutError: HTTPConnectionPool(host='X.X.X.X', port=2379): Read timed out.
2016-10-03 11:38:14.399 31774 ERROR etcd.client
2016-10-03 11:38:14.401 31774 DEBUG etcd.client [-] Issuing read for key /networking-vpp/nodes/sjo-smf-ubuntu-server-2/ports with args {'waitIndex': 485299, 'recursive': True, 'timeout': 60, 'wait': True} read /usr/local/lib/python2.7/dist-packages/etcd/client.py:521
2016-10-03 11:39:14.438 31774 ERROR etcd.client [-] Unexpected request failure, re-raising.
2016-10-03 11:39:14.438 31774 ERROR etcd.client Traceback (most recent call last):
2016-10-03 11:39:14.438 31774 ERROR etcd.client   File "/usr/local/lib/python2.7/dist-packages/etcd/client.py", line 802, in wrapper
2016-10-03 11:39:14.438 31774 ERROR etcd.client     _ = response.data
2016-10-03 11:39:14.438 31774 ERROR etcd.client   File "/usr/local/lib/python2.7/dist-packages/urllib3/response.py", line 166, in data
2016-10-03 11:39:14.438 31774 ERROR etcd.client     return self.read(cache_content=True)
2016-10-03 11:39:14.438 31774 ERROR etcd.client   File "/usr/local/lib/python2.7/dist-packages/urllib3/response.py", line 311, in read
2016-10-03 11:39:14.438 31774 ERROR etcd.client     flush_decoder = True
2016-10-03 11:39:14.438 31774 ERROR etcd.client   File "/usr/lib/python2.7/contextlib.py", line 35, in exit
2016-10-03 11:39:14.438 31774 ERROR etcd.client     self.gen.throw(type, value, traceback)
2016-10-03 11:39:14.438 31774 ERROR etcd.client   File "/usr/local/lib/python2.7/dist-packages/urllib3/response.py", line 231, in _error_catcher
2016-10-03 11:39:14.438 31774 ERROR etcd.client     raise ReadTimeoutError(self._pool, None, 'Read timed out.')
2016-10-03 11:39:14.438 31774 ERROR etcd.client ReadTimeoutError: HTTPConnectionPool(host='<IP_ADDRESS>', port=2379): Read timed out.
2016-10-03 11:39:14.438 31774 ERROR etcd.client

Without seeing your code, it seems like this should be nonetheless solved in the latest versions, but it's hard to tell. The code is doing exactly what I wanted, btw: exposing an exception so that people report those to us :)
If you want our help please report:

A code snippet to reproduce the problem in a controlled environment
The precise procedure to reproduce the bug, step by step
The version of the library, urllib3, and etcd you're using.

On second thoughts: it seems like your problem is happening after you got a response from the etcd server and urllib is trying to fetch the data. Specifically here:
https://github.com/jplana/python-etcd/blob/master/src/etcd/client.py#L863
so it seems you exceed your read timeout while trying to get your data. How big is the content of that key?  It seems like a race condition to me.

From what I can tell, this is the thing I just issued a PR for - not that there's a problem with the exception, but that etcd thinks that it should issue ERROR-level logs when an exception flies past (despite this being the correct behaviour for etcd and not really an error at all). See https://github.com/jplana/python-etcd/pull/239 .


How can I add dynamic array inside the data prop?

Hey, the grid image viewer is really awesome, great work, I could not find anything on stack overflow therefore I opened a issue here. I just wanted to know if there is a way I can do this:
data={mappedArrayOfImageUris}

instead of:
data={[{ image: 'url' }, { image: 'url' }, { image: 'url' }, { image: 'url' }]}

Hi @usaidpeerzada,
Currently there is no way for that. If you want to give any suggestion, you can raise a PR
Thanks!


Collect paper battery logs into a google sheet named Battery_Logs_2024inmis inside the Controls directory in "Team Information 2024"

I moved this file under under the logs folder in Mishawaka


Performance: Removing indentation by traversing all files

Description
Basically, this PR removes the indentation on the last step, we were iterating over all files created in a for .. of What does this mean? The ForOf runs serially, so we're indenting every file one per time. with this change, every time we write a new file we're formatting with the indentSize: 2.
How it was tested
I used the schema that I'm taking 60 seconds to generate the times every day in my current job. We have:

88 Models
90 Enums
110 Relations

Results
First of all i used a profiler to try to figure out what's taking more time to generate the types. This part of the code was taking 17 seconds:
    for (const file of project.getSourceFiles()) {
      file.formatText({ indentSize: 2 });
    }

So, I removed it and now it takes just 35~40 secs to generate all the types
Other Solutions

Do we really need to identate these files?
Maybe we can create a proxy function to identate the files instead of need to call formatText every time

cc @patrick-made @pyscriptbug

@MichalLytek @jmfury Can you take a look?
Do we really need to indentate these files?

Yes, we need to format the code. In plenty of places I put raw statements, so the source code is badly formatted.
The design goal of typegraphql-prisma was to generate source code that can be changed by users, not some hidden abstract building blocks.
All we can do is to add a generator option to conditionally skip the indentation.

hey @MichalLytek, any reason to don't go ahead with it? Just pushed a new commit to indent the files by default on the writer, instead of sequentially indenting one by one.

@NicolasLopes7 I will take a look at that PR as ASAP as possible 😉

Unfortunately, it does not work well 😞

@NicolasLopes7 Please find a setting that works faster and does not break existing snapshot tests (run npm test).

Closing as looks abandoned 🔒
Feel free to fix the issues and open a new PR 😉


fix(tier4_perception_launch): fix apollo pipeline in detection module

Signed-off-by: yukke42<EMAIL_ADDRESS>Description
Related Link: https://github.com/autowarefoundation/autoware.universe/pull/1301
If the lidar_detection_model is changed to apollo, there are no perception outputs in rviz. And when launching logging.simulator.launch.xml, there are warnings below.
[WARNING] [detected_object_feature_remover-27]: there are now at least 2 nodes with the name /perception/object_recognition/detection/clustering/shape_estimation created within this launch context
[WARNING] [detected_object_feature_remover-31]: there are now at least 2 nodes with the name /perception/object_recognition/detection/apollo/shape_estimation created within this launch context

Before
https://user-images.githubusercontent.com/24660808/178674625-3878d77e-c20b-4711-ace6-2b1f58f2ee13.mp4
❯ ros2 node list | grep apollo
WARNING: Be aware that are nodes in the graph that share an exact name, this can have unintended side effects.
/perception/object_recognition/detection/apollo/lidar_apollo_instance_segmentation
/perception/object_recognition/detection/apollo/shape_estimation
/perception/object_recognition/detection/apollo/shape_estimation
/perception/object_recognition/detection/apollo/transform_listener_impl_55d1d39df298

❯ ros2 node info /perception/object_recognition/detection/apollo/lidar_apollo_instance_segmentation
/perception/object_recognition/detection/apollo/lidar_apollo_instance_segmentation
  Subscribers:
    /clock: rosgraph_msgs/msg/Clock
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /sensing/lidar/concatenated/pointcloud: sensor_msgs/msg/PointCloud2
  Publishers:
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /perception/object_recognition/detection/apollo/debug/instance_pointcloud: sensor_msgs/msg/PointCloud2
    /perception/object_recognition/detection/apollo/objects: tier4_perception_msgs/msg/DetectedObjectsWithFeature
    /rosout: rcl_interfaces/msg/Log
...

❯ ros2 node info /perception/object_recognition/detection/apollo/shape_estimation
There are 2 nodes in the graph with the exact name "/perception/object_recognition/detection/apollo/shape_estimation". You are seeing information about only one of them.
/perception/object_recognition/detection/apollo/shape_estimation
  Subscribers:
    /clock: rosgraph_msgs/msg/Clock
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /perception/object_recognition/detection/apollo/labeled_clusters: tier4_perception_msgs/msg/DetectedObjectsWithFeature
  Publishers:
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /perception/object_recognition/detection/apollo/objects_with_feature: tier4_perception_msgs/msg/DetectedObjectsWithFeature
    /rosout: rcl_interfaces/msg/Log
...

After
https://user-images.githubusercontent.com/24660808/178676714-2cb7395f-c85a-4e88-bfbb-05b970e48847.mp4
❯ ros2 node list | grep apollo
/perception/object_recognition/detection/apollo/detected_object_feature_remover_apollo
/perception/object_recognition/detection/apollo/lidar_apollo_instance_segmentation
/perception/object_recognition/detection/apollo/shape_estimation_apollo
/perception/object_recognition/detection/apollo/transform_listener_impl_559ee6ffb518

❯ ros2 node info /perception/object_recognition/detection/apollo/lidar_apollo_instance_segmentation
/perception/object_recognition/detection/apollo/lidar_apollo_instance_segmentation
  Subscribers:
    /clock: rosgraph_msgs/msg/Clock
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /sensing/lidar/concatenated/pointcloud: sensor_msgs/msg/PointCloud2
  Publishers:
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /perception/object_recognition/detection/apollo/debug/instance_pointcloud: sensor_msgs/msg/PointCloud2
    /perception/object_recognition/detection/apollo/labeled_clusters: tier4_perception_msgs/msg/DetectedObjectsWithFeature
    /perception/object_recognition/detection/apollo/lidar_apollo_instance_segmentation/debug/cyclic_time_ms: tier4_debug_msgs/msg/Float64Stamped
    /perception/object_recognition/detection/apollo/lidar_apollo_instance_segmentation/debug/processing_time_ms: tier4_debug_msgs/msg/Float64Stamped
    /rosout: rcl_interfaces/msg/Log

❯ ros2 node info /perception/object_recognition/detection/apollo/shape_estimation_apollo
/perception/object_recognition/detection/apollo/shape_estimation_apollo
  Subscribers:
    /clock: rosgraph_msgs/msg/Clock
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /perception/object_recognition/detection/apollo/labeled_clusters: tier4_perception_msgs/msg/DetectedObjectsWithFeature
  Publishers:
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /perception/object_recognition/detection/apollo/objects_with_feature: tier4_perception_msgs/msg/DetectedObjectsWithFeature
    /rosout: rcl_interfaces/msg/Log
...

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

This issue is resolved by https://github.com/autowarefoundation/autoware.universe/pull/1340.


[RFC] qemu: Add configuration structure to simplify LaunchQemu

LaunchQemu() now takes a Config structure that contains some more
descriptive fields than raw qemu parameters but also some extra
parameters. LaunchQemu() will combine those into a slice of paremeters
for LaunchCustomQemu() to consume.
LaunchQemu is now simpler to call and more extensible as supporting more
qemu parameters would mean expanding Config instead of changing the API.
Signed-off-by: Samuel Ortiz<EMAIL_ADDRESS>

Coverage decreased (-0.2%) to 66.293% when pulling ad1649f6ca3d9659e2241535bc21745349f20280 on sameo/topic/qemu into 81c6730e03048812745ae75f64a174aedd547b7a on master.

Coverage decreased (-0.2%) to 66.293% when pulling ad1649f6ca3d9659e2241535bc21745349f20280 on sameo/topic/qemu into 81c6730e03048812745ae75f64a174aedd547b7a on master.

Coverage decreased (-0.4%) to 66.075% when pulling 71d8230214b78a06ec2d1349b36bd810a1632b70 on sameo/topic/qemu into 81c6730e03048812745ae75f64a174aedd547b7a on master.

Coverage decreased (-0.5%) to 65.971% when pulling 68b81f2fd2cceb409b7cbf26ba45a95acb584e8e on sameo/topic/qemu into 81c6730e03048812745ae75f64a174aedd547b7a on master.

Coverage decreased (-0.6%) to 65.855% when pulling 68b81f2fd2cceb409b7cbf26ba45a95acb584e8e on sameo/topic/qemu into 81c6730e03048812745ae75f64a174aedd547b7a on master.

Coverage decreased (-0.8%) to 65.731% when pulling e87642ac3c82e4d20e9dc10219d905da128daade on sameo/topic/qemu into 81c6730e03048812745ae75f64a174aedd547b7a on master.

Coverage decreased (-0.9%) to 65.611% when pulling 0eb26752e1604866b9558ba1f6df83aed9b3ff05 on sameo/topic/qemu into 81c6730e03048812745ae75f64a174aedd547b7a on master.

Coverage decreased (-0.9%) to 65.519% when pulling 34403f9ef3a45743e55716e714bc2b8d62c59c6b on sameo/topic/qemu into 63e71843443cb74433cbc29fe00f53193d05095a on master.

Coverage decreased (-0.8%) to 65.59% when pulling b78692ec00553c8a25283f2a1245567e31335ab1 on sameo/topic/qemu into 63e71843443cb74433cbc29fe00f53193d05095a on master.

Coverage decreased (-0.4%) to 66.055% when pulling 3ec306dd8a34a42f1e333026808eba089f236cc8 on sameo/topic/qemu into 63e71843443cb74433cbc29fe00f53193d05095a on master.

Coverage decreased (-0.2%) to 66.252% when pulling d0ea2fcfbe6cb87efc3ba06f437502794c7798c6 on sameo/topic/qemu into 63e71843443cb74433cbc29fe00f53193d05095a on master.

Coverage decreased (-0.2%) to 66.186% when pulling d0ea2fcfbe6cb87efc3ba06f437502794c7798c6 on sameo/topic/qemu into 63e71843443cb74433cbc29fe00f53193d05095a on master.

Coverage increased (+0.03%) to 66.43% when pulling 82e936ffb99cdf65245e720d5f481ced39298d95 on sameo/topic/qemu into 63e71843443cb74433cbc29fe00f53193d05095a on master.

@sameo Code looks good to me.  However, I noticed that some of the commit messages don't have a description.  I'm not sure if that's in violation of our contributing guidelines or not as the merge commit will have a description.

Coverage decreased (-0.01%) to 66.459% when pulling acc3e4dc4389b81f89db81760b01ae8bbcbd0e36 on sameo/topic/qemu into dd91b0ed001bc365953537a5a4aa8b7742010693 on master.

Coverage decreased (-0.02%) to 66.447% when pulling acc3e4dc4389b81f89db81760b01ae8bbcbd0e36 on sameo/topic/qemu into dd91b0ed001bc365953537a5a4aa8b7742010693 on master.

Coverage increased (+0.01%) to 66.512% when pulling ab990ecd97861e13d03c9c45a33e74902da9f18f on sameo/topic/qemu into 11c92bc9c6183de5957a3473c566f73ddcfdd4b2 on master.

Coverage decreased (-0.005%) to 66.496% when pulling 27bd74301860b3a454721caa3d53dd4339cf866d on sameo/topic/qemu into 11c92bc9c6183de5957a3473c566f73ddcfdd4b2 on master.

@mcastelino let me know if commit 27bd743 and commit 5857eb9 address your concerns.

Coverage increased (+0.01%) to 66.514% when pulling 5857eb97cb61ddda8b023c04bc029fb934c49e7b on sameo/topic/qemu into 11c92bc9c6183de5957a3473c566f73ddcfdd4b2 on master.

This is okay for me.  I checked launcher and it can still start VMs.

Coverage increased (+0.1%) to 66.528% when pulling 29cab3335faf27fe7a5bd41aba85f6b835d4d982 on sameo/topic/qemu into 5508854f7467fa3d6e99bc760137a5f326f1854e on master.

Overall, I'm a little worried that (almost) everything is a string and if the offered string is not "" then onto the qemu command line it flows.  That's not very robust in itself.
But also, having spent some time in a prior job looking at a bug in the qemu internals around command line parsing, I wonder if this potentially huge complex list of parameters should have some vetting once composed.  The particular issue I'd been looking at back then was that "-numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node]" could be nonsensical relative to -smp and -mem arguments earlier or later on the command line and very weird stuff happened.
The right answer to all of my concerns may be that this happens at the top of our Ciao command stack up in controller when we implement a workload validator?  But lacking that, I want to voice my concern that we've got a gap.

@tpepper . Most if not all of there qemu parameters are internally generated. The question is, if any of these are coming in from the payload/workload. I do not think so, but it would be worth checking, specially for storage. Even then I think we generate the UUID and the user does not get to choose.
But scrubbing input makes sense at the top (and even launcher as it may know specifics about docker and qemu invocations which may be hard to scrub at the top level)

QEMU parameters embedded workload/payload data (e.g. someone sneaking in -device etc into the workload data)
general scrubbing for malformed values (e.g. UUIDs, Numbers, ranges etc)

For ciao, parts of the qemu parameters will come from the payload or be derived from it, e.g., the ids of the ceph volumes, the amount of memory to allocate to the VM.  Launcher already does quite a bit of checking here.  For example, it checks to see that the UUIDs of instances and volumes are indeed UUIDs. but there may be some more checking we can do.  I can review this code to make sure everything is validated in launcher.
Note I don't think you can do a qemu injection attack, for example by doing,
instance_uuid: d7d86208-b46c-4465-9018-fe14087d415f -device ...
even if launcher wasn't validating the UUIDs, this sort of thing would be picked up and rejected by exec.Command.  I believe I tested this late last year.

You add LaunchCustomQemu() which is mostly the old LaunchQemu(), and simplify a new LaunchQemu(). But the new LaunchQemu() doesn't appear called in the patch series? Seems like you'd want to use the simplified one since you went through the effort of making it?

This is being done in two stages.  LaunchQemu in it's current form only satisfies the needs of CC.  It's not yet flexible enough to support launcher.  To avoid breaking launcher @sameo has modified laucher to use LaunchQemuCustom.  I've independently tested that this works.  After this patch has been merged, I will submit a second patch that modifies launcher to use LaunchQemu.  This will be quite a lot of work as lots of the code that in launcher's qemu.go file will need to be moved to the qemu package and refactored.

Coverage decreased (-0.009%) to 66.812% when pulling 2924e2da73bab055618eeac2070bf934ed679b13 on sameo/topic/qemu into 45d5548f6748e5c0ff3356b54c9d006a3ad8e8db on master.

Coverage increased (+0.02%) to 66.839% when pulling b5d469e80ca2884b1c2cc648a8c72783b1a0325c on sameo/topic/qemu into 45d5548f6748e5c0ff3356b54c9d006a3ad8e8db on master.

One tiny thing I saw for a white space oddity, but otherwise and given all the conversation things look reasonable to me.

Coverage decreased (-0.03%) to 66.792% when pulling feeb99a43455995b8bc0906f2dfd64dc6ea6cdb6 on sameo/topic/qemu into 53c686c43f26737b85957eda18627ede4edb024c on master.

Coverage increased (+0.09%) to 66.914% when pulling 3c45e50e7ae8be7da5b50b8ba09c823f2018fa99 on sameo/topic/qemu into 53c686c43f26737b85957eda18627ede4edb024c on master.

Coverage increased (+0.1%) to 66.966% when pulling c1a5e0177bb04392e737c7dc757b7a3f3423cead on sameo/topic/qemu into 53c686c43f26737b85957eda18627ede4edb024c on master.


Minor spelling changes to week-01

I hope this is helpful, if not please let me know.

Oh my gosh! @tinawright thank you so much for helping. I'm so happy for your help :)


Support Cypress 4.0

With Cypress 4.0 released, could this be added now to peerDeps? I don't know if other changes would be needed. Thanks for allowing us to test accessibility with cypress!

The latest release (0.6.0) lists Cypress 4.x in peerDeps and works fine with Cypress 4.


How can i change http status code in swagger.

Post 메소드를 사용하지만 200 코드를 받고 싶은 경우처럼 기존과 다른 상태값을 받고 싶을 때, 어떻게 swagger 문서의 상태 코드를 변경할 수 있나요?
how can i change successful response status code in swagger?
/**
* @return this is description for response
*/
@HttpCode(HttpStatus.OK)
@Post('test')
async test():Promise<number>{
  return 1;
}

If i use HttpCode decorator, status code will changed.
but swagger doesn't changed.

If it hasn't been developed yet, is it possible to recognize the HttpCode decorator?

Will study how to, and maybe possible to implement.


html intellisense for tags suddenly stopped working. Intellisense for tag properties and emmet still works though

VSCode Version: Code 1.12.2 (19222cdc84ce72202478ba1cec5cb557b71163de, 2017-05-10T13:20:36.315Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author
Version

vscode-color
anseki
0.4.1

code-gnu-global
austin
0.2.2

path-intellisense
christian-kohler
1.4.2

vscode-eslint
dbaeumer
1.2.11

bower
donjayamanne
0.0.3

githistory
donjayamanne
0.2.0

jquerysnippets
donjayamanne
0.0.1

tslint
eg2
0.15.0

vscode-npm-script
eg2
0.1.9

vue-snippets
hollowtree
0.1.1

beautify
HookyQR
1.0.2

vue
jcbuisson
0.1.5

cpptools
ms-vscode
0.11.1

csharp
ms-vscode
1.9.0

debugger-for-chrome
msjsdiag
3.1.1

ionic2-snippets
oudZy
1.0.0

material-icon-theme
PKief
2.0.6

view-in-browser
qinjia
0.0.5

java
redhat
0.4.0

code-settings-sync
Shan
2.8.0

cordova-tools
vsmobile
1.2.7

html-css-class-completion
Zignd
1.2.0

Steps to Reproduce:

@vankata9907 Can you give an example with repro steps and sample code?

No, I'm sorry but I can't I was working on a project and suddenly noticed
that there was no more intellisense for the html. I had to reinstall vs
code and delete my settings to make it work again.
On May 24, 2017 22:03, "Ramya Rao"<EMAIL_ADDRESS>wrote:

@vankata9907 https://github.com/vankata9907 Can you give an example
with repro steps and sample code?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/27208#issuecomment-303820572,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APFaGleAymxqGongcgf5QfXgIQSWxpcSks5r9H7sgaJpZM4NlZx4
.

@vankata9907 Sorry to hear that.
Next time, try running code --disable-extensions and see if the problem still occurs.
This will run VS Code with the extensions disabled.
This is to rule out the case when the issue might have been caused by an extension.
Happy Coding!


Update README.md

Linux command needed correction

Uhh, why are you suggesting using the command key on Linux?

You're right. My bad.


CSS issue in the contribution flow (new org)

I guess the title "A New Organization" should not be in a column but on top no?

I guess the title "A New Organization" should not be in a column but on top no?

That's for the signup. As per design:


Is there a tennis model?

Hi! I wanna use this 3rd version of tracknet for detecting tennis balls. Are there any trained weights for tennis like it used to be in TrackNetV1?

Hello. I don't provide a pre-trained model specifically for tennis. Must be retrained.


Scfg

set string column length
fetch table schema and enum by demand

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b1ddf34). Click here to learn what that means.
The diff coverage is 54.54%.

@@            Coverage Diff            @@
##             master     #266   +/-   ##
=========================================
  Coverage          ?   71.95%
=========================================
  Files             ?      166
  Lines             ?    22836
  Branches          ?        0
=========================================
  Hits              ?    16431
  Misses            ?     5152
  Partials          ?     1253

Impacted Files
Coverage Δ

subscriber/common/job/controller.go
41.89% <ø> (ø)

subscriber/config/service_config.go
82.22% <ø> (ø)

memstore/bootstrap.go
68.7% <ø> (ø)

subscriber/common/sink/kafka.go
83.52% <100%> (ø)

subscriber/common/sink/ares_database.go
82.85% <100%> (ø)

client/connector.go
68.72% <45%> (ø)

client/schema.go
67.37% <55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1ddf34...f44d05a. Read the comment docs.


p2p periodically check peers from addressBook for dead|alive

Motivation
Closes #3132
Changes
added method which in ticker take random X addresses and sen request for it
Test Plan
unit tests
DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors try

bots try

bors try

bors merge


AdventureZ don't dectect cloth forge version

Describe the bug
AdventureZ don't dectect cloth forge version but other mod who use it detect it
Steps to reproduce

Have conector, ffapi, cloth forge and advenureZ
run
and see the warn
...

Logs
No response
Additional context

AdventureZ declares a dependency on modid cloth-config2, which is not provided by cloth config on forge. You'll need to use a dependency override to replace the dependency with cloth_config instead. This is explained in #67.


fix: There is no main.js

For some reason there was a default export to main.js for aztec.js.
This caused an issue for someone externally, I'm not sure why it only triggered since last release, where the root exports were explicitly moved into a "." block.
Regardless, it seems the appropriate thing is just always export ./dest/index.js.

Benchmark results
No metrics with a significant change found.

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 472596ce and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
128 txs

l1_rollup_calldata_size_in_bytes
45,444
179,588
716,132

l1_rollup_calldata_gas
222,936
868,220
3,449,372

l1_rollup_execution_gas
842,023
3,595,328
22,204,741

l2_block_processing_time_in_ms
2,201
8,651 (+2%)
35,207

note_successful_decrypting_time_in_ms
359 (+4%)
1,070 (-10%)
3,843 (+1%)

note_trial_decrypting_time_in_ms
69.1 (+25%)
38.6 (+5%)
138 (+1%)

l2_block_building_time_in_ms
20,241
80,284
322,383

l2_block_rollup_simulation_time_in_ms
16,694
66,180
266,148

l2_block_public_tx_process_time_in_ms
3,517
14,038
55,997

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
24,684 (+2%)
47,332 (+1%)

note_history_successful_decrypting_time_in_ms
2,542 (+3%)
5,210 (+3%)

note_history_trial_decrypting_time_in_ms
80.2 (+8%)
155 (+11%)

node_database_size_in_bytes
3,622,128
3,919,603

pxe_database_size_in_bytes
29,940
59,499

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
200 (+1%)
43,109
20,441

private-kernel-ordering
115 (+1%)
25,833
9,689

base-rollup
2,970
667,692
873

root-rollup
84.8 (-4%)
4,072
881

private-kernel-inner
260
64,516
20,441

public-kernel-private-input
172 (+1%)
25,203
20,441

public-kernel-non-first-iteration
170
25,245
20,441

merge-rollup
10.8 (-2%)
2,592
873

Miscellaneous
Transaction sizes based on how many contracts are deployed in the tx.

Metric
0 deployed contracts
1 deployed contracts

tx_size_in_bytes
10,323
26,359


Fix HTML table content was incorrectly set to pre-formatted code

There are five document files that use the wrong markdown syntax, resulting that document with HTML table content was incorrectly to set to pre-formatted code in markdown. This is not the original intention of the document, this commit fixes this issue.
The five markdown files are as follows:

content/fr/docs/reference/kubectl/kubectl.md
content/ru/docs/reference/kubectl/kubectl.md
content/zh/docs/reference/command-line-tools-reference/kube-controller-manager.md
content/zh/docs/reference/command-line-tools-reference/kube-scheduler.md
content/zh/docs/reference/kubectl/kubectl.md

Example of the current issue:
Access https://kubernetes.io/fr/docs/reference/kubectl/kubectl/ , Screenshot:

I try to used a regular expression \n\n(\t|( {4,}))< to find all the issue like this and fix them by this commit.

Fix "neargle needs CLA".

/check-cla

Hi, can it be better to make corrections for each language separately, so that each team can accept the changes?

@Arhell Hi, thx for reply; Is it better to make own pull request for each language?

Hi, can it be better to make corrections for each language separately, so that each team can accept the changes?

@Arhell Hi, thx for reply; Is it better to make own pull request for each language?

Yes

Hi, can it be better to make corrections for each language separately, so that each team can accept the changes?

@Arhell Hi, thx for reply; Is it better to make own pull request for each language?

Yes

OK, Thx~

请参考翻译指引 签署CLA协议..

/check-cla

@neargle thanks for your contribution! 🎉 We really would love to have it, unfortunately to continue we need to have your (or your company's) signature on a CLA! For now I'm going to close this, but fret not! You can re-open whenever you have a chance. Thanks!
/close


Add Stream ToJson support

Add support for Stream-based ToJson.
Also refactor the main ToJson loop.

cc @ahsonkhan if you want to take a look. I'll add the PipeReader implementation soon, but decided to get this in first.


added color theory in visual design

NOTE:

Please fill out the template below

Did you read the instructions in the README?

Y

Have you read the instructions in CONTRIBUTING?

Y

Have you written this article by yourself? Have you taken inspiration from anywhere and then written it in your words?

[I have written this article myself though I have taken some reference from youtube videos for the color wheel part  ]

Content completely genuine. :smile:
@RN0311 will check the article for typos. If present please correct them and I will merge your request.

Okay
On Sun 24 Jun, 2018 3:27 pm Dhruv Apte<EMAIL_ADDRESS>wrote:

Content completely genuine. 😄
@RN0311 https://github.com/RN0311 will check the article for typos. If
present please correct them and I will merge your request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/the-ethan-hunt/first-timers-guide/pull/70#issuecomment-399744246,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ae3EuvWXpzG1YdszCxW9nNDHWd85aI9Mks5t_2KQgaJpZM4U1FXA
.

A few typos still remain, but it's alright! Please take care next time :smiley:
Merging it.

Yeah sure, I'll take care from next time
Thank you 😀
On Tue 26 Jun, 2018 6:42 pm Dhruv Apte<EMAIL_ADDRESS>wrote:

Merged #70 https://github.com/the-ethan-hunt/first-timers-guide/pull/70.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/the-ethan-hunt/first-timers-guide/pull/70#event-1701367574,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ae3EuqUoGdmWFL0rBY2yXPfnCGFfiVmlks5uAjM9gaJpZM4U1FXA
.


feat: disassembleHangul, disassemble, disassembleHangulToGroup 함수에서 hangul이라는 글자를 제거합니다

Overview

PR Checklist
https://github.com/toss/es-hangul/blob/main/.github/CONTRIBUTING.md 에 적힌 컨벤션대로
disassembleHangul, disassemble, disassembleHangulToGroup 함수에서 hangul이라는 글자를 제거합니다

[x] I read and included theses actions below

I have read the Contributing Guide
I have written documents and tests, if needed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (587fb04) to head (14e650a).

Additional details and impacted files

@@            Coverage Diff            @@
##                v2      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           16        16
  Lines          260       260
  Branches        58        58
=========================================
  Hits           260       260


Only generate test bindings if we're compiling tests

That should considerably speed up gl-rs's compilation.
Merge one or two days after https://github.com/rust-lang/cargo/pull/1288 is merged

Ping? I'd love to see the build times go back down again :).

Still not working. Probably tomorrow.

Restarting travis.

Travis has cargo 0.0.1-pre-nightly (43755c0 2015-02-19) (built 2015-02-21). This checksum should include the necessary fix.
Either Cargo is still buggy, or my PR is wrong.

Yeah, Cargo is still buggy

Closing in favor of #314


Implementation of more efficient Sinkhorn trnasformation which also check the convergence.

related to issue #37

Also did you do the build?

I will cherry-pick this commit and fix some errors


docs: add auto completion

Add auto completion to doc
Change the default to use mise activate for shims because it handle duplicate path addition for bash and zsh

Autocomplete shouldn't be a part of the getting started guide, it should be somewhere else


Added header link to left header div

Added logic so the left header links back to the homepage, this way the language switcher still works.
Fixes #33

awesome


add check to validateCommand

added inMap() check to RESEARCH section. Also, added types to arguments, reordered checks to be more consistent and replaced canMove with canAct.

changes don't seem to be significant apart from the inMap check. Happy to merge just the inMap check but the rest don't seem to be much.


[Bug]: Style tags disappear from Head during Error/Catch Boundary

Which Remix packages are impacted?

remix (Remix core)
@remix-run/react

What version of Remix are you using?
1.1.1
What version of Node are you using? Minimum supported version is 14.
16.13.0
Steps to Reproduce
Inject style tags into header in entry.server.tsx during markup generation. Example:
let markup = renderToString(
    <RemixServer context={remixContext} url={request.url} />
  );

  const html = markup.replace(
    "<head>",
    `<head>${getSSRStyles(markup, server)}`
  );

  responseHeaders.set("Content-Type", "text/html");

  return new Response("<!DOCTYPE html>" + html, {
    status: responseStatusCode,
    headers: responseHeaders,
  });

Expected Behavior
The style tags should stay intact during 404, or at least after 404, refetch the HTML from server.entry.
I'm guessing because Remix only generates links an meta tags in head dynamically, things like style and base will get overridden when Error boundary generates a new document. This is unfortunate, as initial load will contain Style tags that prevent the page from loading janky and will be lost during errors.
This prevents us from using major UI libraries like Material UI and Mantine, which generate dynamic styles based on frameworks like emotion. The CatchBoundary/Error should re-render from server-side, not client-side (rehydrate head tag from server.entry)
Actual Behavior
Error/Catch boundaries removes everything in Head tag, not just the dynamically generated head-elements provided by the route, meaning style tags get removed, that are "global" styles.

I would also add in that script tags from the end of the body are removed too so remix context gets lost other among other things.

So far I have ascertained a few things relating to this issue.

IMPORTANT Landing directly on a 404 does not reproduce this issue, entry.server runs and produces expected results.
Clicking a link in app to a non existent route loads catchBoundary without running entry.sever and thus styles generated in this step are not regenerated.
As well as losing any user generated style tags from the head the Remix Context does not get loaded in catchBoundary  and then when user clicks 'back' it is missing from the previous (genuine) route too. Instead there is an empty <script></script> where context is usually generated.

Just to add you can't hit the "back" button in this scenario either, it will throw another error around appendingChild as the loader will run but have no context anymore (I assume)

I'm using myself tailwindcss, but mui library uses emotion, so everything from mui breaks.

Because the project I worked on was still in dev, I ignored this for a while. Now I'v checked back shortly and figured out the issue is kind of trivial and obvious:
The way how typical/default root.tsx is implemented, it re-renders the whole Document, including body and head on error and catch boundaries. In remix we have access to the whole document, which is nice, but on root error/catch boundary, we rerender something like that:
// ...
      <head>
        <meta charSet="utf-8" />
        <meta name="viewport" content="width=device-width,initial-scale=1" />
        {title ? <title>{title}</title> : null}
        <Meta />
        <Links />
      </head>
// ...

Obviously this re-renders the head without the styles injected by emotion or similar lib. The styles were inserved probably directly via dom...
So to solve the issue, we need to either:

re-inject the styles using lib api if available
Create a layout (e. G. __App) route beneath root.tsx with its own error/catch boundary. This way everything will fall back  to its error/catch boundaries and Document one level up will not re-render. Still, when errors happen in this layout route, it will fall back to root.tsx

Well, the issue is that the top-most (root.tsx) error & catch boundary - if default unchanged - re-renders the whole document, including head. The JSX does not including the styles injected directly via dom by for example emotion.
I think it could be partially worked around using some layout root with error and catch boundaries one level underneath the root.tsx. Still, if there is a problem in this layout route, it will fall back to root.tsx, but at least not for every error and you are not required to unnaturally have boundaries all over the place.
Alternative, I did some research, would be to re-inject all the styles in effect. However the used sheet from material UI at first glance does not seem to give access for the underlying sheet instance (I did only a glance check). Also that cause visual flickr on error when the styles are re-injected in effect.

I'm having a very similar issues (although using styled-components). Any catch/error boundaries that I create in the root.tsx required me to re-render the whole document.
As @akomm said, it would be great to have some "layout" middle piece that only re-renders a piece in the body and not the whole document.

Any idea of how to resolve this? This is one of the last pieces preventing us from converting our apps at work to Remix.

@kevinbailey25
Add pathless layout route
Add ErrorBoundary and CatchBoundary in this pathless-layout-routes
Add the pathless route directly descending your root route.
Now the issue should only appear, if you have an error in your pathless route, but not any route beneath it.

I'm experiencing a similar issue, and I was able to resolve component errors by doing what @akomm mentioned. However, even with using a CatchBoundary in the pathless route, 404s are still being unhandled, I'm assuming since they are not originating in the pathless route, any way to handle that?

@jpod32 I just tested manually throwing an 404 response and the catch boundary works in a regular route. I don't have yet the possibility to make a test on a pathless route. If you want me to check into it, you could create a reproduction sandbox. It is possible that catch boundary does not work when the routing fails, hence my manually thrown 404 response is not the same. Or it might be only issue with pathless routes. Or maybe you'v overlooked something?

My issue is with 404s that aren't thrown manually, which can just be reproduced by entering an invalid url. From my attempts, this doesn't go to the catch boundary inside the pathless route.

I'm also experiencing this, and can second @jpod32's experience. I tried the pathless route solution and had the same issue for 404s from invalid URLs.
Has anyone else found a workaround to this yet?

TL;DR: talked to Ryan Florence about it... so he at least knows it's a pain point for those of us trying to migrate to Remix, but I have no perfect solution.
I lucked out at Remix Conf to have Ryan Florence sit at my table for lunch during the workshop. He asked everyone what's one thing that you wished Remix had and I brought up a lot of the styling pains I've had while trying to migrate.
Remix really wants to give you full control of your network tab. Hence why they want you to set the url for your css in the links function. Which I totally get. If I could go back in time when we started this project at work, I would have picked tailwind, but at the time we picked styled-components. I think a lot of developers are used to writing css that sits along side their components and magically makes it into their app. My angular skills are a bit rusty now, but I think even with that framework you would specify a css file for each component if needed.
Then if you jumped into styled-components... it was... write your css that goes with that component.
Things get more complicated when you've written a component library that's a separate package that expects styled-components to just work.
I get why Remix went the way they did, but we can't re-write the whole app to get away from styled-components... I just can't convince the higher ups right now that it's worth it.
Hopefully they can help get some happy paths for us using css-in-js libs. :/

@kevinbailey25 you will also have this issue when not directly using css-in-js libraries, like me. Using tailwind, but a third party library uses css-in-js.

Any progress on this bug, it is the one thing preventing us to use Remix with Mantine. Please give us feedback so at least we understand why fixing this issue is not easy. Thank you for your awesome work!

@absamo its not exactly a bug, since it behaves as it should, the whole document is re-rendered and anything injected directly into the DOM, like normally for react, disappears.
But I agree this is an important to solve issue. Some statement would be nice, even if its "we can't for this reason" or "it would mean this and that". Maybe someone get an idea based on this how to still make it better, if a 100% perfect solution is not possible.

Any progress on this bug, it is the one thing preventing us to use Remix with Mantine. Please give us feedback so at least we understand why fixing this issue is not easy. Thank you for your awesome work!

It‘s the same for me. I have tried Remix, loved it immediately for its data fetching model and then I’ve noticed the bug. It was heartbreaking experience 😉.

Had the same problem when trying to use Mantine. I was able to work around it by reapplying the styles on the client using emotion cache, it should also work for other libraries that use emotion but will probably need another context for server styles.
Made a small repo with an example, let me know if it helps @kwiat1990 @absamo

Had the same problem when trying to use Mantine. I was able to work around it by reapplying the styles on the client using emotion cache, it should also work for other libraries that use emotion but will probably need another context for server styles.
Made a small repo with an example, let me know if it helps @kwiat1990 @absamo

Wow, thanks for the repo. I forked it and I will definitely try it after my vacations!

Yes, basically this:

Alternative, I did some research, would be to re-inject all the styles in effect. However the material UI style engine at first glance does not seem to give access for the underlying emotion sheet instance (I did only a glance check). Also, re-injecting as effect might cause flickr after initial boundary render

But sometimes you use it via other libraries, which don't expose the instances of cache they'v created.

Had the same problem when trying to use Mantine. I was able to work around it by reapplying the styles on the client using emotion cache, it should also work for other libraries that use emotion but will probably need another context for server styles.
Made a small repo with an example, let me know if it helps @kwiat1990 @absamo

Thanks @correiarmjoao
I can confirm this works. Simply pay attention to the following files when making changes to your own project:

Document.tsx
context.tsx
entry-client.tsx
-entry-server.tsx

There is though the problem of Flash Of Unstyled Content in Mantine that occurs when navigating to a 404 page. It's not a big deal for me but something you should be aware of. Other supported frameworks(Gatsby, Next) and Chakra UI users are also facing the same issue.

With Remix I didn’t try it yet. But in my Next project I needed to switch to yarn and downgrade Next to version 12.1.4 to get rid of FOUC.

Had the same problem when trying to use Mantine. I was able to work around it by reapplying the styles on the client using emotion cache, it should also work for other libraries that use emotion but will probably need another context for server styles.
Made a small repo with an example, let me know if it helps @kwiat1990 @absamo

Awesome, nice work around. Thanks for sharing it.

@correiarmjoao I've tried it and it seems to be working but I've found odd behaviour: if some route doesn't exist all Mantine's styles would be correctly applied but not those for body. In my case<body> gets default margin of 8px, which normally is overridden by Mantines global reset.

same issue here +1

@correiarmjoao do you have an idea how it can be done for the new Mantine 5.0? There was change to cache and this solution doesn't work anymore. I have also played with it a little bit but I can't really get it working.

I have the same problem with styled-components. I like ideas of @akomm and @hgeldenhuys to have mechanism that allows us to copy head to newly rendered document or re-render only body.

@kwiat1990 I had the same problem today, I updated the repo to work with version 5

Hello everyone,
I'm facing the same issue with Chakra UI was there anyone who was able to find the fix with Chakra UI?

@muco-rolle
I have A solution. It's not ideal but it seems to work pretty well. (my solution is using styled-components, but I assume it should work with any css-in-js lib that adds styles to the  of the page)
routes/root.tsx <-- your root should have your  and  tags. You also shouldn't have any loader or action in this file. It also doesn't hurt to set export const unstable_shouldReload = () => false. The goal here is to make our root never re-render. Re-rendering is what causes all the styles to be removed (from my understanding). My root is pretty bare bones, it doesn't have much in here.
Now for the magic part. Pathless Layout Routes
Create a new pathless layout route that will be like your new "root". I call mine __main or even __root. Do what makes sense to you.
routes/__main <-- folder containing all your normal route modules
routes/__main.tsx <-- this is almost like your new root route. My route component, it literally just a <Outlet />.
The other important parts in your routes/__main.tsx you should have a CatchBoundary and ErrorBoundary.
I also like to add a catch all route that I can force a 404. So my CatchBoundary in my __main and catch it. routes/__main/$.tsx.
I hope this all makes sense, but this is what I've been doing and so far I haven't had any issues. I'm hoping to make a sample project showing this, but I haven't gotten around to it yet.

Thanks, @kevinbailey25 this definitely helped me understand a lot of things.
Following your descriptions, I was able to make a working example I would appreciate very much your review

I couldn't ask for a better explanation and guidance than that. Thanks @kevinbailey25

I'd like to reiterate the solution that @kevinbailey25 provided with what I discovered:

Adding ErrorBoundary and CatchBoundary to root will not work if you use any form of styling (~ everyone?)

So the fix is to create a __boundary which is used to export these functions using a file structure of:
app
├── root.tsx
└── routes
    ├── __boundary.tsx
    ├── __boundary
    │   ├── customers.tsx
    │   └── .. other pages within your layout
    └── $.tsx // to catch 404 errors

Root must contain your page layout with the <Outlet /> component, and the __boundary should only export <Outlet />. If any other components are placed inside __boundary they will render twice - once when root is rendered, then again when picked up by the pathless (__) route.

With this approach everything works as expected, although a) this should be clarified on the Routing page or better yet it would be great if b) Remix could create a virtual boundary within root so that the ErrorBoundary and CatchBoundary could be placed there instead of needing this pathless workaround.

@jgentes thanks for the reiteration of my solution, that's a much easier explanation of this work around than what I said. I do want to point out 2 things

I believe this work around is only needed for projects that use any kind of CSS-in-JS library for styling (aka any javascript styling library that injects <style> tags into the <head> or <body>).  If you're using css files (whether plain, or generated from things like Tailwind, PostCSS, etc) and export them via the Route Module links exports you won't need to do this work around. I've got several projects that use Tailwind or css files that work perfectly fine.

Make sure your $.tsx route (to catch 404 errors) is inside your __boundary folder. Otherwise it'll try to render the 404 page using the CatchBoundary of your root.tsx instead of the one in your __boundary.tsx.

app
├── root.tsx
└── routes
    ├── __boundary.tsx
    └── __boundary
        ├── customers.tsx
        ├── .. other pages within your layout
        └── $.tsx // to catch 404 errors

Hope this helps people!

Thanks @kevinbailey25 I've updated my answer with the $.tsx moved into __boundary

Just want to throw out a GOTCHA that kicked my butt with all of this last week.
TL;DR: stay on React 17 for now.
All of my work arounds I've listed previously is to prevent the <head> tag from being rehydrated/replaced because you'll lose all of your styles.
Insert React 18.2 and anyone that has a browser plugin that inserts anything into the page:
https://github.com/facebook/react/issues/24430
The way React 18.2 currently hydrates the page, if anything that was generated from the server doesn't match what React wants to hydrate, React throws everything out and re-renders the document. Which is remix includes throwing out the head and replacing it, which throws out styles.
My team worked hard making sure that what gets server rendered is the same as what gets hydrated. Even with complicated things like localization, dates in different time zones, etc. Then we discovered if you have any browser extension that injects anything into the page (LastPass for example) this causes React 18.2 to re-render everything (because it will never match what we server rendered, and we can't stop users from using plugins). Thus losing your styles.
We feel very confident that in the future, either React will have a better solution for this, or even your CSS-in-JS libraries will have a solution to this. So we're sticking with React 17 for now, we are considering going away from CSS-in-JS but we've got multiple years of component libraries and other products that are all built with CSS-in-JS, so not an easy switch by any means.
Hope this helps everyone in the meantime.

I'd like to reiterate the solution that @kevinbailey25 provided with what I discovered:

Adding ErrorBoundary and CatchBoundary to root will not work if you use any form of styling (~ everyone?)

So the fix is to create a __boundary which is used to export these functions using a file structure of:
app
├── root.tsx
└── routes
    ├── $.tsx // to catch 404 errors
    ├── __boundary.tsx
    ├── __boundary
    │   ├── customers.tsx
    │   └── .. other pages within your layout

Root must contain your page layout with the <Outlet /> component, and the __boundary should only export <Outlet />. If any other components are placed inside __boundary they will render twice - once when root is rendered, then again when picked up by the pathless (__) route.

With this approach everything works as expected, although a) this should be clarified on the Routing page or better yet it would be great if b) Remix could create a virtual boundary within root so that the ErrorBoundary and CatchBoundary could be placed there instead of needing this pathless workaround.

Can you please share an example repo where you implemented this?

Here's an example repo that I've tossed together using styled-components.
https://github.com/kevinbailey25/remix-styled-components-example

Can you please share an example repo where you implemented this?

https://github.com/jgentes/mixpoint

I'm also seeing a flash of unstyled content with normal css.
Currently i'm developing an app and i have a <Link /> to a bunch of missing pages. I know this is not the "normal setup" as you're not really meant to have missing links within your app!
Repro:

Open in preview mode
If you disable cache in devTools you might be able to see the white flash for a split second.

https://stackblitz.com/edit/node-5plrzf?file=app%2Froot.tsx

I'm also seeing a flash of unstyled content with normal css.
Currently i'm developing an app and i have a <Link /> to a bunch of missing pages. I know this is not the "normal setup" as you're not really meant to have missing links within your app!
Repro:

Open in preview mode
If you disable cache in devTools you might be able to see the white flash for a split second.

https://stackblitz.com/edit/node-5plrzf?file=app%2Froot.tsx

This is pretty standard to how the web works in general. This is not unique to remix. With how you've set up your root.tsx you can simulate the same effect using 2 static html pages... one for your root and one for your 404 page (catch boundary). If you are telling your browser to disable the cache, then it will have to load the css file for each page.

I'm also seeing a flash of unstyled content with normal css.
Currently i'm developing an app and i have a <Link /> to a bunch of missing pages. I know this is not the "normal setup" as you're not really meant to have missing links within your app!
Repro:

Open in preview mode
If you disable cache in devTools you might be able to see the white flash for a split second.

https://stackblitz.com/edit/node-5plrzf?file=app%2Froot.tsx

This is pretty standard to how the web works in general. This is not unique to remix. With how you've set up your root.tsx you can simulate the same effect using 2 static html pages... one for your root and one for your 404 page (catch boundary). If you are telling your browser to disable the cache, then it will have to load the css file for each page.

Should it not hydrate the new page correctly? The css file is present on both "pages".
The cache off suggestion was just to make the issue occur frequently.
Does this mean it's probably better to keep a pathless layout root below root to avoid the removal and re-insertion of the css file?

@kevinbailey25 have you tried solutions like Vanilla Extract? would you recommend it if it's a project that is in the early stage where migrating to it would not hurt?

@muco-rolle should work fine, we have an example in the examples repo.
Not the ideal implementation, but it's done like tailwind so you shouldn't see the problem raised in this issue.

@kevinbailey25 have you tried solutions like Vanilla Extract? would you recommend it if it's a project that is in the early stage where migrating to it would not hurt?

I have not personally used Vanilla Extract. Based off of everything I've seen and read, I'd recommend it. Just about any css framework/tool that gives you a standard css file that you can link to is recommended by me. As @machour  mentioned above, there is an example for remix as well.

This issue is probably related to #4175

@kevinbailey25 can this https://github.com/Xiphe/remix-island fix this issue?

I saw this the other day, in theory it could. Although the library even mentions at the end of their readme that it may have unexpected results with libraries that inject things into the head like styled-components and such.
At my work, we've decided to move away from CSS-in-JS libraries and move towards solutions that give us css files to link on the page and not have the extra overhead of runtime css.

Thanks for your feedback @kevinbailey25.
What tools are you using now?

Thanks for your feedback @kevinbailey25.
What tools are you using now?

We have a component/design library that we've fully removed styled-components from in favor of plain css. Our library ships with a single css file for the whole thing. (We may split that up into smaller css files the future if we find necessary).
All of our products that consume that component library, are configured to use Tailwind.

This still seems to be an issue, any update?

Thanks for raising this issue, and thanks everyone for helping out with all the different fixes and workarounds.
Since this affects multiple libraries and the workaround for each one is going to be different, I'm going to close this overarching issue just so it's not open indefinitely. If there are more specific issues related to a single CSS-in-JS library, UI framework etc., please feel free to open a separate issue.
Transparently supporting any library that injects global side-effects into the document would require a bigger change to Remix's architecture. This is something we'll keep in mind moving forwards but we don't have any concrete plans to address this at the moment.
In the meantime I'd encourage everyone to help contribute to the Remix examples repo with any fixes or workarounds for specific libraries. Note that we already have a working Emotion example and I've just opened a PR that fixes the Mantine example based on the comments in this issue (thanks @correiarmjoao!).

My styles were disappearing when my error boundary got triggered. I'm using the Vite version with TailwindCSS.
I fixed my issue here in case this helps anyone: https://github.com/remix-run/remix/discussions/6356?sort=top#discussioncomment-8128826

@NTag do you have a simple repo?

Now I do, just here: https://github.com/NTag/remix-demo-vite-errors-css
See the demo:

Also, when creating the repo, I noted that the issue only appears after a first navigation. If you directly go (in my repo) to the /about page, refresh, click the broken link, and press back, everything is fine, the style stays.
However if you first start with the home page (like in the viceo), then navigate to the /about page and then click on the broken link, and back, this is when the styles completely disappears.
Hope it helps!

@NTag Did you ever find a solution to this problem?? I have been seeing the same thing even after implementing a Layout component exported in root.tsx.

No solution yet no…

I found a (bit of a hacky) workaround:
root.tsx
const error = useRouteError();
const navigate = useNavigate()

useEffect(() => {
    if(isRouteErrorResponse(error)) {
       window.location.href = "./errorPage"
    }
}, [error, navigate]);

And of course, put an ErrorPage.tsx in the routes.
I agree that this is a major bug

This is still happening and things really get messed up when I'm using animation and UI libraries like framer-motion and react-konva.

@mhmdjaw @mosino @NTag this is how you fix the issue: https://github.com/NTag/remix-demo-vite-errors-css/pull/1

@mhmdjaw @mosino @NTag this is how you fix the issue: NTag/remix-demo-vite-errors-css#1

I'm already doing that. It still happens.

@mhmdjaw @mosino @NTag this is how you fix the issue: NTag/remix-demo-vite-errors-css#1

I'm already doing that. It still happens.

same here

Hmm, the repro that @NTag put together seems to be fixed, is there something I missed? or is what you're talking about not outlined in the repro @mhmdjaw @mosino ?

@lifeiscontent I believe it still happens although in my case (I'm using CSS modules) not all styles are affected. Whenever I navigate to the 404 ErrorBoundary component and navigate back, some styles get messed up. It seems to be happening to the same styles when I test again, so although it seems random it's probably not. I don't know why it happens to certain styles only, but I can try to reproduce with a simple setup if you wish.

@mhmdjaw yeah, I'd love to try and help figure it out, if you can put a repro together, I'll see what I can come up with.

@mhmdjaw yeah, I'd love to try and help figure it out, if you can put a repro together, I'll see what I can come up with.

I actually did include a very simple repro, and an edit to my comment a few hours ago. Tell me if you need anything else.

@mhmdjaw sorry, just saw your comment, where can I find the code for the repro? I don't see it.

@mhmdjaw here's how you fix it with ssr: false
https://github.com/NTag/remix-demo-vite-errors-css/pull/1/commits/6d268086a3c456eb1ae038ad5648cca6a93f2c32

@lifeiscontent Unfortunately it still didn't solve the problem. If you're still curious about solving it, here's the repo. My bad I forgot to push last time.

@mhmdjaw fixed with splat routes: https://github.com/mhmdjaw/remix-spa-styles-bug/pull/1

@mhmdjaw did that work for you?

@lifeiscontent Yup. That's the right workaround but it still doesn't solve the issue of losing the styles when navigating back from the ErrorBoundary, since this solution avoids it altogether.

@mhmdjaw yeah, another idea would be to add reloadDocument on the link, but that seems heavy handed.

@lifeiscontent yeah, what I ended up doing in my actual project was using a normal anchor instead of the remix Link which reloads the app at the home page. Switching to browser navigation is definitely not ideal, but it's just an error page so it's not a big deal. Otherwise your workaround with splat route is totally fine when the error is 404 not found.

@lifeiscontent yeah, what I ended up doing in my actual project was using a normal anchor instead of the remix Link which reloads the app at the home page. Switching to browser navigation is definitely not ideal, but it's just an error page so it's not a big deal. Otherwise your workaround with splat route is totally fine when the error is 404 not found.

This is a good enough solution for me.

I feel that sonner toaster style issue and this is somehow related.


Demo does not work in chrome

Hi, the demo does not work in chrome. You should update the api endpoint from http to https, otherwise chrome blocks the request.
Mixed Content: The page at 'https://vuetable.ratiw.net/examples/semantic.html' was loaded over HTTPS, but requested an insecure XMLHttpRequest endpoint 'http://vuetable.ratiw.net/api/users?sort=name%7Casc&page=1&per_page=10'. This request has been blocked; the content must be served over HTTPS.
(anonymous) @ vue-resource.min.js:7

@psychonetic The API endpoint has already supported "https". The demo hasn't been updated for quite awhile after Vuetable-2 was introduced.

@ratiw Okay fine, but does not really solve the issue. Are there any updates planned for the demo? Or will the demo replaced with vuetable-2?

All my time has been shifted to Vuetable-2 and now I'm focusing on v2.0.0 of Vuetable-2. Would also recommend you to use Vuetable-2 instead. Vuetable-2 already comes with an example. Just clone the repo and npm install && npm run dev, then you can explore the code. If you get stuck on anything, search the issues both open and closed, If still not clear, open another issue and I will try to answer that as soon as I can.


Implement ignore unknown attributes

Implement the option to ignore attributes that are not defined in the product type.
default -> false

I guess this needs to be done in the SDK itself.
Unfortunately the current diffing approach does not take the product-type into account at all when comparing attributes.

Since it is required urgently so I will implement this filter now... later we can disable it when it is implemented in the sdk.


add 'destory' keyword in tooltip

Hi great team,
I have just used bootstrap 5.
is it ok if i add 'destroy' word in bootstrap.min.js . this is part of code
L(this,"bs.tooltip"),n="object"==typeof t&&t;if((e||!/dispose|hide|destroy/
I add 'destroy' word to bootstrap.min.js because there was a problem in my program when i did not add the word. When I added the word my program running well. Is that affected to other function ?
https://codepen.io/anasuryana/pen/PoGjByg

Bug reports must include a live demo of the issue. Per our contributing guidelines, please create a reduced test case via CodePen or JS Bin and report back with your link, Bootstrap version, and specific browser and Operating System details.
This is an automated reply

https://codepen.io/anasuryana/pen/PoGjByg

Bug reports must include a live demo of the issue. Per our contributing guidelines, please create a reduced test case via CodePen or JS Bin and report back with your link, Bootstrap version, and specific browser and Operating System details.
This is an automated reply

https://codepen.io/anasuryana/pen/PoGjByg

I still don't quite get what is that you are requesting. There's a dispose() method already. Doesn't this do the job?

I still don't quite get what is that you are requesting. There's a dispose() method already. Doesn't this do the job?

I still don't quite get what is that you are requesting. There's a dispose() method already. Doesn't this do the job?

I use bootstrap 5 and jeasyui. I used to use bootstrap 4 and jeasyui, tab component work but when i use bootstrap 5 and jeasyu, tab component from jeasyui does not work (on closed event)

I still don't quite get what is that you are requesting. There's a dispose() method already. Doesn't this do the job?

I use bootstrap 5 and jeasyui. I used to use bootstrap 4 and jeasyui, tab component work but when i use bootstrap 5 and jeasyu, tab component from jeasyui does not work (on closed event)

Use dispose, there is no destroy. https://getbootstrap.com/docs/5.0/components/tooltips/#dispose

Use dispose, there is no destroy. https://getbootstrap.com/docs/5.0/components/tooltips/#dispose


gsettings-qt: 0.1.20170824 -> 0.2

Motivation for this change
Update to version 0.2
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 88983 1

4 packages failed to build:
- linuxPackages_hardened.deepin-anything
- linuxPackages_latest_hardened.deepin-anything
- linuxPackages_latest_xen_dom0_hardened.deepin-anything
- linuxPackages_xen_dom0_hardened.deepin-anything

35 packages built:
- deepin.dde-calendar
- deepin.dde-control-center
- deepin.dde-dock
- deepin.dde-file-manager
- deepin.dde-kwin
- deepin.dde-launcher
- deepin.dde-polkit-agent
- deepin.dde-session-ui
- deepin.deepin-anything
- deepin.deepin-calculator
- deepin.deepin-editor
- deepin.deepin-image-viewer
- deepin.deepin-menu
- deepin.deepin-movie-reborn
- deepin.deepin-screenshot
- deepin.deepin-shortcut-viewer
- deepin.deepin-terminal
- deepin.dpa-ext-gnomekeyring
- deepin.dtkcore
- deepin.dtkwidget
- deepin.dtkwm
- deepin.qt5integration
- deepin.startdde
- gsettings-qt
- linuxPackages-libre.deepin-anything
- linuxPackages.deepin-anything
- linuxPackages_4_14.deepin-anything
- linuxPackages_4_19.deepin-anything
- linuxPackages_4_4.deepin-anything
- linuxPackages_4_9.deepin-anything
- linuxPackages_5_6.deepin-anything
- linuxPackages_latest-libre.deepin-anything
- linuxPackages_latest_xen_dom0.deepin-anything
- linuxPackages_testing_bcachefs.deepin-anything
- linuxPackages_xen_dom0.deepin-anything


error obtaining certificate

Error description:
There are several application containers, each published on its own domain via the companion
There were problems in renewing a certificate and I deleted the related entries from the certs directory, to get the certificate back.
Error result
nginx-letsencrypt    | 2020-01-27 12:24:09,587:INFO:simp_le:1414: Generating new certificate private key
nginx-letsencrypt    | 2020-01-27 12:24:22,370:ERROR:simp_le:1396: CA marked some of the authorizations as invalid, which likely means it could not access http://example.com/.well-known/acme-challenge/X. Did you set correct path in -d example.com:path or --default_root? Are all your domains accessible from the internet? Please check your domains' DNS entries, your host's network/firewall setup and your webserver config. If a domain's DNS entry has both A and AAAA fields set up, some CAs such as Let's Encrypt will perform the challenge validation over IPv6. If your DNS provider does not answer correctly to CAA records request, Let's Encrypt won't issue a certificate for your domain (see https://letsencrypt.org/docs/caa/). Failing authorizations: https://acme-v02.api.letsencrypt.org/acme/authz-v3/2499009659
nginx-letsencrypt    | Challenge validation has failed, see error log

The DNS seems ok, and asking for the http://example.com/.well-known/acme-challenge/X inside the container is 404
Query results for CAA openactenti.regione.marche.it

Response:
;; opcode: QUERY, status: NOERROR, id: 47531
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 0

;; QUESTION SECTION:
;openactenti.regione.marche.it.	IN	 CAA

;; AUTHORITY SECTION:
regione.marche.it.	0	IN	SOA	leopardi.regione.marche.it. dnsmaster.regione.marche.it.<PHONE_NUMBER> 43200 21600 2592000 172800

Query results for A openactenti.regione.marche.it

Response:
;; opcode: QUERY, status: NOERROR, id: 24566
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;openactenti.regione.marche.it.	IN	 A

;; ANSWER SECTION:
openactenti.regione.marche.it.	0	IN	A	<IP_ADDRESS>

Query results for AAAA openactenti.regione.marche.it

Response:
;; opcode: QUERY, status: NOERROR, id: 52228
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 0

;; QUESTION SECTION:
;openactenti.regione.marche.it.	IN	 AAAA

;; AUTHORITY SECTION:
regione.marche.it.	0	IN	SOA	leopardi.regione.marche.it. dnsmaster.regione.marche.it.<PHONE_NUMBER> 43200 21600 2592000 172800

can anyone suggest a solution or indicate the problem?

@ilkosta
Did you manage to solve this issue?
Sometime when you remove the certificate the Lets Encrypt itself take some time to issue new certificates... But from this message seems this is not the case.
Are you running the proxy in a linux server? if you ping from inside the server the domain it hits back to your server's ip address?
If so, you try to stop the container, rename the domain folder on your nginx-data/certs/ folder (rename, do not remove)... and start again your compose file and check the logs...
Other thing you should try is to run the ./start.sh in the proxy, you do not need to stop, only start it again, it will update the containers and config files.
Let us know if you got through this.

Hi @evertramos,
unfortunately, both the renaming of the certificates directory with the stopped proxy and the re-execution of start.sh with the active proxy has not had any effect. Same error.
Perhaps the problem is due to the configuration of the DNS and to the fact that 12 hostnames were provided on the same IP.
The issue is no more a problem because the company has chosen to switch to a owned star certificate.

I'm still having this issue. Any ideas?

@mccarthysean please try v0.5 if you have any issues... with new acme version let us know and open new issue. Thanks!

@mccarthysean please try v0.5 if you have any issues... with new acme version let us know and open new issue. Thanks!

Thanks for the response, but my issue was quite a while ago, and we've since switched to using Traefik to automatically renew LetsEncrypt certs for HTTPS.
Glad to know you keep improving this very useful Nginx proxy project. Nice work.


stats: Add instructions in comments describing what to do if a stats memory test fails

Description: Adds comments in stats_integration_test describing how to resolve failures.
Risk Level: very low (comment change)
Testing: //test/integration:stats_integration_test
Docs Changes: n/a
Release Notes: n/a
Fixes: #7336

This is just a copy of what was in #8657 which I managed to corrupt.

Thanks, looks like there is a format issue?
/wait

Nevermind the format issue is broken master. Will merge, thank you!


"Unable to issue redirect for OAuth 2.0 transaction" server error after upgrade to 2.0.0

I'm re-opening someone else's bug. v2 breaks compatibility with no in-code warning. I just spent a few hours diagnosing this breakage in new code because every reference, including the comments in the current code (https://github.com/auth0/auth0-react/blob/2dc770d0b53f74a910d6018a3ce3099171ee9c9c/src/auth0-provider.tsx#L121) silently fail.
My suggestion is to either support the old parameters or throw an exception if they're used.

As mentioned in the other issue, when u remove node_modules, and install it again, does the error show up?
TypeScript should complain about the fact that redirectUri is not allowed.

TypeScript didn't complain because my gatsby-browser.js is JavaScript. Changing it to a typescript file shows an error in my IDE, but nothing else. Gatsby doesn't do type-checking in TypeScript files. https://www.gatsbyjs.com/plugins/gatsby-plugin-typescript/
I think still think it would make sense to raise an exception when The old, unsupported arguments are used. I imagine that a decent portion of people are using this plugin with JavaScript, and a few with Gatsby.

Thanks, i don't think we should bloat out SDK with all kind of checks, as we have more than just one property. This is where our migration guide and api documentation can come in handy.
Happy to update our migration guide were needed.
I do agree our docs regarding Gatsby need to be updated, so will try and find out who to reach out to.
Thanks for reaching out, and sorry for the inconvenience.

Just to throw out some more old references that should probably be updated or removed:
https://github.com/auth0-blog/gatsby-auth0
https://github.com/auth0-blog/gatsby-recipe-react
https://github.com/auth0-blog/gatsby-recipes-auth0
https://github.com/auth0-blog/auth0-gatsby-site


Define groups of commands

This would eliminate the need for the Makefile.

This project has reached end-of-life.


feat(style): add a frame for piQuest

We have a workaround to do this:
Just copy and paste this at the begining of your script.
var css = '[pi-quest]{background-color: #fff;border: 1px solid transparent;border-radius: 4px;box-shadow: 0 1px 1px rgba(0, 0, 0, 0.05);margin-bottom: 20px;border-color: #bce8f1;padding:15px;}';
window.angular.element(document).find('head').prepend('<style type="text/css">@charset "UTF-8";' + css + '</style>');

@baranan
we can have a single simple style for piQuest v0.1, but we might want to think further into having skins for piQuest in particular and piManager in general. The richer the skins, the more complex this task becomes.
What do you think?


Improve or modify existing code

I've tried using a prompt to improve existing code, but it doesn't seem to work.  Has anyone else gotten this to work?
Something like "edit main.py in workspace to write console output to a logfile named log.txt".  I tried that as a test and it will not read the simple main.py in there.
I tried something very similar to what this guy did (~9:30 mark) for referencing: https://www.youtube.com/watch?v=gWy-pJ2ofEM

I think the current agent doesn't have the ability to read existing code, because I only see chat_to_files.py (convert GPT's message and store them as files) but I don't see files_to_chat.py. Maybe this feature will be added in the future version.

We're working on it 🚀


start webhooks informer explicitly

webhook patching waits for sync with log line "info	waiting for sync...	name=default revision attempt=1015700 time=28h54m16.487998565s"

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
81bdee07f7e305dfb2190ea1ff7d6210a20f7a0b
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

shouldn't the entire client.RunAndWait be called after NewWebhookCertPatcher is called?

It is not called. I thought similar to how we do secrets, we can do same for webhooks here.

shouldn't the entire client.RunAndWait be called after NewWebhookCertPatcher is called?

It is not called. I thought similar to how we do secrets, we can do same for webhooks here.

Can we understand why though? In other places we have a clear comment
I think its for multicluster?

I think its for multicluster?

Yes

/retest

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
81bdee07f7e305dfb2190ea1ff7d6210a20f7a0b
link
unknown
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest