problem with Build a Full-Stack React Application learn module part 3 ~ add authentication

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d24v30ethdkds1
Region
us-east-1
Amplify Console feature
Backend builds
Describe the bug
I have done the module 4 times today ~ get the following build error on completion of item 3 above learn module to use react with amplify
# Starting phase: build
# Executing command: amplifyPush --simple
2021-05-17T04:24:45.877Z [INFO]: File project: data should NOT have additional properties: 'graphqltransformer'
2021-05-17T04:24:45.878Z [INFO]: JSONValidationError: File project: data should NOT have additional properties: 'graphqltransformer'
at validator (/root/.nvm/versions/node/v12.21.0/lib/node_modules/@aws-amplify/cli/node_modules/amplify-cli-core/lib/feature-flags/featureFlags.js:136:27)
at featureFlagsValidator (/root/.nvm/versions/node/v12.21.0/lib/node_modules/@aws-amplify/cli/node_modules/amplify-cli-core/lib/feature-flags/featureFlags.js:140:17)
at FeatureFlags.validateFlags (/root/.nvm/versions/node/v12.21.0/lib/node_modules/@aws-amplify/cli/node_modules/amplify-cli-core/lib/feature-flags/featureFlags.js:146:17)
at FeatureFlags.loadValues (/root/.nvm/versions/node/v12.21.0/lib/node_modules/@aws-amplify/cli/node_modules/amplify-cli-core/lib/feature-flags/featureFlags.js:204:18)
at async Function.FeatureFlags.initialize (/root/.nvm/versions/node/v12.21.0/lib/node_modules/@aws-amplify/cli/node_modules/amplify-cli-core/lib/feature-flags/featureFlags.js:267:5)
at async Object.run (/root/.nvm/versions/node/v12.21.0/lib/node_modules/@aws-amplify/cli/lib/index.js:73:9)
2021-05-17T04:24:45.883Z [ERROR]: !!! Build failed
2021-05-17T04:24:45.883Z [ERROR]: !!! Non-Zero Exit Code detected
2021-05-17T04:24:45.883Z [INFO]: # Starting environment caching...
2021-05-17T04:24:45.883Z [INFO]: # Uploading environment cache artifact...
2021-05-17T04:24:45.970Z [INFO]: # Environment caching completed
Expected behavior
build with no error so I can do next part or module 4.
Reproduction steps
follow module 1-3
Build Settings
No response
Additional information
Little more info in doc's

Hi @rmasonh18, thanks for raising. That error usually indicates that the build is using an older version of the Amplify CLI.
The steps outlined in this comment (below) should help unblock you, specifically the CLI version

Adjusted the build settings by adding:
Build Settings -> Build image settings -> Live package updates -> Amplify CLI -> latest

https://github.com/aws-amplify/amplify-console/issues/1726#issuecomment-814571075


ENH: Add cepstrum functions and minimum phase reconstruction. - WIP

This adds

complex_cepstrum         -- Compute the complex cepstrum of a real sequence.
real_cepstrum            -- Compute the real cepstrum of a real sequence.
inverse_complex_cepstrum -- Compute the inverse complex cepstrum of a real sequence.
minimum_phase            -- Compute the minimum phase reconstruction of a real sequence.

To do:

[ ] Add more references
[ ] Add tests.
[ ] Add examples.

What do you think about the names of the functions? I'm not so much a fan of short names but rather be explicit of what a function does.
For the implementation I used the documentation of Matlab, which describes the steps to be taken quite well. I suppose this is okay? Can this be added as a reference?
I've added one test but I guess it would be good to add more. Any suggestions for tests? I did validate the results against Matlab for a couple of sequences (was also a good way to find the cases they do not document...)
cc @rgommers @WarrenWeckesser @endolith @ewmoore

cepstrum - my noun of the week:)
Why not combine the real and complex functions? Signatures are the same, so can't you simply switch the code path based on the dtype of the input?
What is the reason to only have an inverse function for complex and not for real?

Please don't add a reference to the Matlab version. What you can do is mention the matlab function name corresponding to the Python version in the Notes section. An article or book as a reference would be useful.
You can read Matlab docs and learn from them, as long as you do not look at any Matlab source code.

The real and complex cepstrum are different. Both operate on a real-valued sequence, and return a real-valued sequence. However, the real cepstrum uses only the magnitude of the DFT of the input, whereas the complex cepstrum uses both magnitude and phase angle.
Because the real cepstrum discards the phase angle it is impossible to reconstruct the original signal, and therefore no inverse_real_cepstrum exists.
I've added a use-case for the complex_cepstrum as an example. If you have a signal consisting of harmonics it allows you to determine the fundamental frequency. This is actually what I use it for.

Note that Travis failed because the test exceeded the 50 minutes limitation.

+1 for this enhancement. @FRidh Do you need any help?

We now at least have scipy.signal.minimum_phase. @FRidh are you interested in coming back to this? If so it might be best to start from scratch based on what scipy.signal.minimum_phase already provides.
It looks like the last commit was 4 years ago with no response to a ping 3 years ago, so I'll go ahead and close. But @FRidh I'm happy to reopen if you want to work from this branch again!


The "az aks update" command misses switches that enable the assignment of Managed Identities.

Hello,
I'm trying to use the convenience of the new MIs on existing AKS clusters.  Regretfully, for updating the AKS cluster, neither the --enable-managed-identity nor --assign-identity exist in CLI 2.17.1.
PS C:\projects> az aks get-credentials -g <rgName> -n <aksName>
Merged "<aksName>" as current context in C:\Users\<me>\.kube\config
PS C:\projects> az feature register --namespace Microsoft.ContainerService -n MigrateToMSIClusterPreview
Once the feature 'MigrateToMSIClusterPreview' is registered, invoking 'az provider register -n Microsoft.ContainerService' is required to get the change propagated
{
  "id": "/subscriptions/<GUID>/providers/Microsoft.Features/providers/Microsoft.ContainerService/features/MigrateToMSIClusterPreview",
  "name": "Microsoft.ContainerService/MigrateToMSIClusterPreview",
  "properties": {
    "state": "Registering"
  },
  "type": "Microsoft.Features/providers/features"
}
PS C:\projects> az provider register -n Microsoft.ContainerService
PS C:\projects> az aks update  -g <rgName> -n <aksName> --enable-managed-identity
UnrecognizedArgumentError: unrecognized arguments: --enable-managed-identity
Try this: 'az aks update --resource-group <MyResourceGroup> --name <MyManagedCluster> --load-balancer-managed-outbound-ip-count <2>'
Still stuck? Run 'az --help' to view all commands or go to 'https://aka.ms/cli_ref' to learn more
PS C:\projects> az feature register --namespace Microsoft.ContainerService -n UserAssignedIdentityPreview
Once the feature 'UserAssignedIdentityPreview' is registered, invoking 'az provider register -n Microsoft.ContainerService' is required to get the change propagated
{
  "id": "/subscriptions/<GUID>/providers/Microsoft.Features/providers/Microsoft.ContainerService/features/UserAssignedIdentityPreview",
  "name": "Microsoft.ContainerService/UserAssignedIdentityPreview",
  "properties": {
    "state": "Registering"
  },
  "type": "Microsoft.Features/providers/features"
}
PS C:\projects> az provider register -n Microsoft.ContainerService
PS C:\projects> az aks update -g <rgName> -n <aksName>  --enable-managed-identity --assign-identity <manage ID's clientID field, no quotes>
UnrecognizedArgumentError: unrecognized arguments: --enable-managed-identity --assign-identity  <manage ID's clientID field, no quotes>
Try this: 'az aks update --resource-group <MyResourceGroup> --name <MyManagedCluster> --load-balancer-managed-outbound-ip-count <2>'
Still stuck? Run 'az --help' to view all commands or go to 'https://aka.ms/cli_ref' to learn more
PS C:\projects>

Running az aks update --help does not list those two options, while running az aks create --help lists both of them.
Did I miss installing anything please?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a9c74a8-9f1a-3d3d-3aed-f8ec45f92e05
Version Independent ID: 01e98043-dc80-490e-a761-8d558ff4e6df
Content: Use managed identities in Azure Kubernetes Service - Azure Kubernetes Service
Content Source: articles/aks/use-managed-identity.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

@eugen-nw
Thank you for reaching out. At this time we are reviewing the ask and will provide an update as appropriate

@eugen-nw
Thank you for reaching out. At this time we are reviewing the ask and will provide an update as appropriate

@norshtein can you look into this.  I was able to have this working on 2.16.0, as soon as I upgraded to 2.17.1 I was able to reproduce the error above.

@norshtein can you look into this.  I was able to have this working on 2.16.0, as soon as I upgraded to 2.17.1 I was able to reproduce the error above.

@norshtein Can you please check and add your comments on this issue.
Thanks

@norshtein Can you please check and add your comments on this issue.
Thanks

@eugen-nw Updating from SPN cluster to MSI cluster requires aks-preview extension. Could you please try to run command az --version and check the output in “Extensions”. If aks-preview is not installed, you can install it by running command az extension add -n aks-preview. Let me know about results.
Thanks

@eugen-nw Updating from SPN cluster to MSI cluster requires aks-preview extension. Could you please try to run command az --version and check the output in “Extensions”. If aks-preview is not installed, you can install it by running command az extension add -n aks-preview. Let me know about results.
Thanks

Thanks very much!  I did not have the aks-preview extension installed.  Once I installed it I could see both --enable-managed-identity and --assign-identity switches listed in the "az aks update --help" command.

Thanks very much!  I did not have the aks-preview extension installed.  Once I installed it I could see both --enable-managed-identity and --assign-identity switches listed in the "az aks update --help" command.


[GSSOC'21] Hover effect to calculator

Is your feature request related to a problem? Please describe.
While clicking on any number or operator in the calculator, if it hovers it will give a feel of clicking it and would look more interactive.
Describe the solution you'd like
I would like to add the hover effect to its keys.

@sairish2001 sir, please try to assign me this issue, if this issue is valid.

Please look into this issue, I think this feature should be added to the calculator as will have a good user experience.

Since the hover effect does not works well in mobile devices, so that's the reason


Call Install method  with Vue constructor as first argument

A Vue.js plugin should expose an install method. The method will be called with the Vue constructor as the first argument, along with possible options.
See https://vuejs.org/v2/guide/plugins.html

Fixed that. By the way, please do not change the index.min.js file.


Deploy through "Portal" link also failed with a "Resource Deployment Failure"

Tried using the "Deploy via Portal" link, which resulted in failure, detail below:
{
  "code": "DeploymentFailed",
  "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/DeployOperations for usage details.",
  "details": [
    {
      "code": "Conflict",
      "message": "{\r\n  \"status\": \"Failed\",\r\n  \"error\": {\r\n    \"code\": \"ResourceDeploymentFailure\",\r\n    \"message\": \"The resource operation completed with terminal provisioning state 'Failed'.\"\r\n  }\r\n}"
    }
  ]
}

*Note, this was in a brand new Azure setup with no pre-existing resources defined

Managed to get the site to successfully deploy using updates in @yannickRe fork azuredeploy script (I suspect the newer module versions and switch to "Basic" deploy might have done it.
https://github.com/YannickRe/Ghost-Azure
However, site fails to load.

It used to fail because of a conflict. Web app names must be globally unique:

I will need more time to look at the whole deployment. The old handy button for azuredeploy seem to be deprecated. The ARM template needs some refactoring now, so it provides some meaningful defaults.
I'm going to leave that issue open until I am able to make it better.

hey @SimonDarksideJ did you manage to get the site to spin up using either @RadoslavGatev or @YannickRe deploy scripts? I also encounter an 500 error when using Yannick's.

I do have the site running using @YannickRe 's deployment, however it's not reporting security issues and requires ghost to be updated. Need a find a path to come back to @RadoslavGatev version as it is using a newer version of Ghost.

Hello @svict4,
We are hitting the limits of the free App Service plans when deployments get longer. Technically if you try setting up a fresh blog, there is a huge chance it will work. But if you are redeploying a newer version of Ghost it will likely need more time.
If you encounter a 503 error, it most likely means that it got stuck on database migrations. The only way to recover it is to download the db file and remove the lock.
Generally, the deployment duration can be optimized by offloading most of the work to Azure pipelines/GitHub actions that can download the npm packages and leave just the database migrations to run on Kudu for example. However, that would make it more difficult for people to get started deploying Ghost on App Service...


Getting the old schema aften setting up a new Activity Log Alert

Using the Azure Portal UI (Monitoring -> Alerts -> New Alert Rule) I created a new Activity Log alert, but the payload I'm getting is very different to the one being described here. In fact, I'm getting something similar to the old schema, the one being described in this doc page:
https://docs.microsoft.com/en-us/azure/monitoring-and-diagnostics/monitoring-activity-log-alerts-webhook
Am I missing something?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f45f57cb-5482-db31-c268-ff2322eb64ef
Version Independent ID: 4e6ce5b3-578f-8a6f-25ea-9a15f706c65b
Content: Azure Activity Log event schema
Content Source: articles/monitoring-and-diagnostics/monitoring-activity-log-schema.md
Service: azure-monitor
GitHub Login: @johnkemnetz
Microsoft Alias: dukek

@gonzalofarias Thanks for bringing this to our attention. Your feedback has been shared with the content owner for further review.

@gonzalofarias -- the webhook payload is intended to have only a subset of the event properties, not the full event on its own. This is by design. Activity Log alerts are intended to be notifications about an event in the activity log, not the full activity log event itself. You should use the event hub streaming option if you are trying to get full events streamed from the Activity Log.
@femsulu , since this is "by design," can we close this?

@femsulu please close


Response Headers

Hello there, Is it possible to get response headers ? the example on readme curl_chrome99 https://www.wikipedia.org only return body of the response, It would be nice if we could get full response with put some additional flag in cli, Some of websites return useful cookies.

Hi,
curl_chrome99 is just a wrapper script. You can pass additional flags to it and they will be passed to curl. The -v flag will show you response headers for example.


init-launch-sandbox: Stop capturing stdout/stderr

This stops capturing and buffering stdout and stderr when installing extensions in the sandbox, so live progress is visible.
Checklist

[ ] I have added tests

Yes there was problem with the output on windows. I can try this on when I get back home

@AndreasArvidsson when you get a minute it would be awesome if you could try this out on Windows; I believe that's what's blocking this PR

stdout appears to be working on windows

@AndreasArvidsson do you remember what the problem was originally?  Unfortunately we didn't leave any comment.  Here's the commit where you fixed Windows originally fwiw

I think it was that stdout wasn't showing. I can't remember exactly. Now it appears to be working at least.


Adding a network

What version of Wallet are you using?
Version: 0.7.2
What is happening?
Incorrectly adding networks
steps to reproduce
When adding a custom network, I specified a name and inserted a link to a random tweet instead of the network URL, but the network was added to the wallet. I switched to that network, and even requested test tokens through the wallet tap, but they came to the main Testnet Beta 3 network
How it should behave?
Checking for a valid URL should work better and reject non-existent RPCs
What os are you seeing the problem on?
Mac/Apple Desktop
What browser?
Brave
What is your browser version?
Version 1.50.114

Just in case my Fuel address:
fuel1hv0vcv8m4q3ek5v0tgjcj6vgudxt7c0ghqgagz37j7rs7s4qggdqqzjgwt
My Discord name:
LogosWGP#4707
My MetaMask address:
0x85A76add66EA3CfD94803Aaa2d60ca1985cCaB18

Thanks, @danevqq, for reporting. This are known issues and will be solved on #610 #611


RackEnvironmentBuilder: handle header punctuation differences.

Something upstream of us sent X-Forwarded-For headers that both mapped to HTTP_X_FORWARDED_FOR, breaking ImmutableMap.Builder's contract. Since it looks like (Jetty's HttpFields and) the servlet spec claim support for case-insensitive header semantics, the dash/underscore difference is all else I can imagine.

Build should be fixed by #14, will merge that first.

LGTM


Websocket Error: Connection is already closed

Async patch: yes
HA: 0.111.4
Error shows up every 10 seconds. Eventually the device is unreachable.

Source: custom_components/sonoff/__init__.py:417
Integration: sonoff
First occurred: June 21, 2020, 11:38:35 AM (51149 occurrences)
Last logged: 1:11:33 AM

websocket error: Connection is already closed

Same here.


Wrong URL for reports dropdown

For some reason these weren't working for me until I added an additional -/ to the url. Hopefully this isn't a result of a misconfiguration on my behalf, LMK!

good catch.
This broke when I added the ARN field.


Example app is missing persistence

I think it was a really nice feature to demonstrate - not necessarily as a part of "easy" examples, but just to give developers a nice way to copy & paste this piece of functionality.
Any plans to bring it back?

closing it for now, as I don't think we need it in the example app right now. We could create maybe multiple examples, later on, showcasing different scenarios.


Where is the FAQ?

https://github.com/infinitered/nsfwjs/wiki/FAQ redirects to home page

@jamonholmgren - is wiki turned off for our org?   I had a WIKI setup and now it's gone.  Not only is it gone, I can't seem to find the wikipage link!   I can find one in my personal GitHub.   So I'm at a bit of a loss of where the wiki went.
It held some pretty critical info.

UPDATE:  It was turned off.... by whom I have no clue!
I turned it back on in settings.

Sorry @mifi - looks like it's back now, and still contained all the important data.


After upgrade to rancher 2.5.6 HA mode resource unavailable

After upgrade to rancher 2.5.6 HA mode I get resource unavailable for grafana, prometheus ui etc.

I am cluster-admin

When creating the url in the browser it work (example): https://[fqdn]/k8s/clusters/[cluster-id]/api/v1/namespaces/cattle-monitoring-system/services/http:rancher-monitoring-grafana:80/proxy/?orgId=1

No errors in rancher log..

SURE-2984. This will need reproduction in 2023-Q1-2.6x and  2023-Q1-2.7x

I was able to reproduce the issue with port forwarding on Private GKE clusters, and confirm the workaround. The URLs do show up as active and are not greyed out. Without working proxy traffic they spin and eventually produce a 503 gateway timeout:
{
  "kind": "Status",
  "apiVersion": "v1",
  "metadata": {},
  "status": "Failure",
  "message": "error trying to reach service: dial tcp <IP_ADDRESS>:9093: i/o timeout",
  "reason": "ServiceUnavailable",
  "code": 503
}

To fix, these ports must be opened from the Control Plane to the Target Node instances:
9093 - AlertManager
8080 - Grafana
8081 - Prometheus
(Thanks bluemalkin for the initial find.)
Additionally, new to Rancher v2.7.2, the following port must be opened on new clusters, without which chart installation will fail:
9443 - Rancher Webhook
With the above in place, all monitoring URLs appear to be in good working order, so I'd agree that this is primarily a documentation failure. The GKE instructions are provided in great detail here:
https://cloud.google.com/kubernetes-engine/docs/how-to/private-clusters#add_firewall_rules
Our Rancher documentation for GKE Private clusters currently makes no mention of these ingress rules:
https://ranchermanager.docs.rancher.com/reference-guides/cluster-configuration/rancher-server-configuration/gke-cluster-configuration/gke-private-clusters
There is a separate tracking issue for Rancher Webhook: https://github.com/rancher/rancher/issues/41142 with more details and workarounds for anyone affected.

Resolving as the original report is resolved.


Software requirements

Hi good evening bro. I want to build a software for pc using
My Excel worksheet. Could you please help me

Can you elaborate a bit? Not sure what you're asking.


No preview picture visible on the grav theme page

While in Grav admin panel, when i try to add a new theme and look at the preview pictures of the different themes, i don't see the preview of this theme

Same issue here.


Fix variable reference in with-exchange-online.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/3866

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@LanaChin PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


TeamManager Class

I'm working on a TeamManager class, this ticket intended as a public list of advancement and suggestions.
It should:

Browse the PC using PC.lua
Pick the best team (IV/types/ability/nature) using data from Smogon
Include a BattleManager
Pick a pokemon that can learn the wished HM
Learn the best moves
Pick in priority the pokemons from a whitelist and tend to avoid the one from a blacklist
Learn moves from TM
Evolve pokemon by using the right item

I do not know if it also count 'special evolves' like Pikachu (Thunder stone) or Growlithe (Fire stone)
(If we have enough money, it will buy it and evolve our Pokémon. [2.500$/ea - Celadon]

Oh, right, I forgot about this.

What would be the criteria to "learn the best moves" since different pokemon have different recommended move sets?
Will we define a standard move set to every pokemon?

A Pokemon is learning a move:

if the move does not deal damages, do not learn it (the fighting AI is not yet ready for that). End.
pick the first smogon setup of the last evolution of the pokemon
check if the IV or EV to up are attack or attackSpe move, if none then check the type of the damaging moves
if the move does not match the attack mode the do not learn the move
learn a damaging move from the set in priority (erasing anything else)
learn a damaging move that beat the power of a previous one (including type scaling)
erase a move of the same type first, if there is already a better move of the same type, then do not learn the move

That should be enough to have a reliable team.


As a user, I want to see the average score after voting is concluded

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When we finish voting, we can't see the average of the cast votes and need to calculate them ourselves, which is imprecise as we just eye-ball the number.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Show the average after voting is concluded.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Calculate in a spreadsheet on the side
Eye-ball the average

Additional context
Add any other context or screenshots about the feature request here.
If you'd be interested, I'd be willing to take a stab and submit a PR if that'd work. We really enjoy this tool and would love to help with adding extra features as a way to give back!

Thank you for your feature request and for offering to contribute! I agree that displaying the average score after voting concludes would be a valuable addition, so feel free to add this feature.

I am working on app redesign, so I'll take this in work

Here it is


oh-my-posh: Update version 7.10.1 and Fix the autoupdate

What type of Apps related PR is this? (check all applicable)

[ ] ✨ Add Manifest
[ ] ♻ Refactor
[x] 🐛 Bug Fix
[ ] 👷 Optimization
[ ] 🚩 Other

Description

Update the 'oh-my-posh' verison and fix the autoupdate after a change on the download url project.
Related Tickets & Documents

None
Did you verify the followings

Add/Modify a description in the manifest?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Check URLs?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Update to the latest version?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Update Hashes?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Format the json manifest?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Did you identify extra steps
Notes in the manifest?

[x] 👍 yes
[ ] 🙋 yes, but I need help
[ ] 🙅 no, because they aren't needed

Application Dependencies?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Application Suggestions?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Pre-installation steps to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

Post-installation steps to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

File persistence to perform?

[ ] 👍 yes
[ ] 🙋 yes, but I need help
[x] 🙅 no, because they aren't needed

[optional] What gif/emoji best describes this PR or how it makes you feel?

:alien: :bug:

All changes look good.
Wait for review from human collaborators.
oh-my-posh

[x] Description
[x] License
[x] Hashes
[x] Checkver
[x] Autoupdate
[x] Autoupdate Hash Extraction


Removed file comes back after it's removed when using AUFS

Hello, I've hit a weird bug using AUFS that causes a deleted file to come back after the container is committed.
This issue can be easily reproduced with the script below, it involves creating a file inside a directory, and subsequently removing and recreating the whole directory with the file. After that, if we remove and recreate only the directory, the file will come back.
I tested the same script with devicemapper and this bug doesn't happen.

 But then, mkdir /x will replace it with /x again but with new mtime, ctime, atime, etc. AUFS will also make this new directory "opaque", creating a hidden .wh..wh..opq file in this new directory in the working branch (it's not visible in the container). This tells AUFS to hide whatever is in this directory in lower branches, like the /x/a file.
The bug comes in when we export the rootfs diff. AUFS does it differently than the other copy-on-write storage drivers. It just exports the working branch, but excludes the hidden .wh..wh..* files. All other removed files/dirs are regular "whiteouts", like .wh.<original_name>. However, when this exported diff is then applied to a new layer we don't see the .wh..wh..opq file so AUFS doesn't know that that directory is "opaque" anymore.
This wouldn't be a problem if we didn't exclude the .wh..wh..* files when exporting an AUFS diff.
But if we didn't exclude them then we'd run into another bad issue, different storage drivers calculating different diffs for the same set of changes which results in different Tarsum checksums which are currently used in verifying image content.
I think the solution to this will be to "Stop Using Tarsum to Verify Rootfs Diffs". Then we no longer need to exclude the ".wh..wh..opq" files when exporting an AUFS branch and this problem will be fixed (at least for AUFS).
But then there's another issue: Say you push this diff to the registry and I download it and I'm using the BTRFS storage driver. The other storage drivers don't respect the .wh..wh..opq files, so then I'd still see /x/a file. The other storage driver ApplyLayer methods will have to be updated to to support the "opaque" markers that AUFS produces: when it sees the marker, just remove everything in the directory. Either do this OR make AUFS diffs be generated in the same way (would cause performance hit when doing docker commit with AUFS when there's a lot of filesystem entries).

op sorry this is a dup of https://github.com/docker/docker/issues/9093 so moving jlhawns awesome comment there


Configure poll interval for folder watching

Hi, I noticed that the folder watching functionality polls the disk every second for files to extract. Is there a way to configure this interval? I don't need it to be that quick to react and would rather reduce the wear and tear on my disk. Thanks!

[folders]
interval = "10s"

or UN_FOLDERS_INTERVAL=10s

If you want even less IO, don't run it in Docker and it won't start the file system poller.

I'm glad those settings worked for you. So few people need them that I've chosen not to document them. They are advanced settings that generally should not need changing. In cases where changing them is needed, I like to understand why, by having this short conversation. The really advanced users tend to find them on their own.
Let me know if I can help with any other tuning!


gen_kobject_list.py: Add support for 64-bit addresses

Currently the python script is assuming we only have objects on 32-bit
addresses. This is obviously wrong for 64-bit platforms. Fix this.
Signed-off-by: Carlo Caione<EMAIL_ADDRESS>

I'm no Python expert, but any reason to not use int.from_bytes here?

Maybe to support big endian?

I'm no Python expert, but any reason to not use int.from_bytes here?
Maybe to support big endian?

int.from_bytes accepts byteorder parameter.


mkref but get the empty "Homo_sapiens_ensembl_99.refFlat"

I try to use celescope to mkref,  i download the same file and code in manual.
reference put this directory: "XX/software/CeleScope-1.10.0/database/"
in the step of "celescope rna star", i get error:
subprocess.CalledProcessError: Command 'picard -Xmx20G -XX:ParallelGCThreads=4 CollectRnaSeqMetrics I=.//B11T/03.star/B11T_Aligned.sortedByCoord.out.bam O=.//B11T/03.star/B11T_region.log REF_FLAT=XXX/software/CeleScope-1.10.0/database/Homo_sapiens_ensembl_99.refFlat STRAND=NONE VALIDATION_STRINGENCY=SILENT' returned non-zero exit status 1.
when i check the "Homo_sapiens_ensembl_99.refFlat" , and i found it's empty.

Homo_sapiens_ensembl_99.refFlat is generated with celescope rna mkref. When you ran celescope rna mkref, did you get any error?

No error was reported，
les Log.out | head -n 20
`STAR version=2.7.9a
STAR compilation time,server,dir=2021-07-15T17:03:54+08:00 :/home/data/XXX/software/STAR-2.7.9a/source
Command Line:
STAR --runMode genomeGenerate --runThreadN 6 --genomeDir ./ --genomeFastaFiles Homo_sapiens.GRCh38.dna.primary_assembly.fa --sjdbGTFfile Homo_sapiens.GRCh38.99.gtf --sjdbOverhang 100
Initial USER parameters from Command Line:
All USER parameters from Command Line:
runMode                       genomeGenerate        ~RE-DEFINED
runThreadN                    6     ~RE-DEFINED
genomeDir                     ./     ~RE-DEFINED
genomeFastaFiles              Homo_sapiens.GRCh38.dna.primary_assembly.fa        ~RE-DEFINED
sjdbGTFfile                   Homo_sapiens.GRCh38.99.gtf     ~RE-DEFINED
sjdbOverhang                  100     ~RE-DEFINED
Finished reading parameters from all sources
Final user re-defined parameters-----------------:
runMode                           genomeGenerate
runThreadN                        6
genomeDir                         ./
genomeFastaFiles                  Homo_sapiens.GRCh38.dna.primary_assembly.fa
sjdbGTFfile                       Homo_sapiens.GRCh38.99.gtfles Log.out | tail -n 20Jun 20 15:27:51   Finished preparing junctions
Jun 20 15:27:51 ..... inserting junctions into the genome indices
Jun 20 15:30:02   Finished SA search: number of new junctions=383200, old junctions=0
Jun 20 15:30:46   Finished sorting SA indicesL nInd=153280000
Genome size with junctions=3215411168<PHONE_NUMBER>   77023200
GstrandBit1=32   GstrandBit=32
Jun 20 15:31:48   Finished inserting junction indices
Jun 20 15:32:12   Finished SAi
Jun 20 15:32:12 ..... finished inserting junctions into genome
Jun 20 15:32:12 ... writing Genome to disk ...
Writing<PHONE_NUMBER> bytes into .//Genome ; empty space on disk =<PHONE_NUMBER>49824 bytes ... done
SA size in bytes:<PHONE_NUMBER>6
Jun 20 15:32:14 ... writing Suffix Array to disk ...
Writing<PHONE_NUMBER>6 bytes into .//SA ; empty space on disk =<PHONE_NUMBER>75520 bytes ... done
Jun 20 15:32:34 ... writing SAindex to disk
Writing 8 bytes into .//SAindex ; empty space on disk =<PHONE_NUMBER>45952 bytes ... done
Writing 120 bytes into .//SAindex ; empty space on disk =<PHONE_NUMBER>45952 bytes ... done
Writing<PHONE_NUMBER> bytes into .//SAindex ; empty space on disk =<PHONE_NUMBER>45952 bytes ... done
Jun 20 15:32:37 ..... finished successfully
DONE: Genome generation, EXITING`

I'm referring to the stdout of the celescope rna mkref command, not the STAR log; the refflat file is not produced by STAR.
The refflat file is actually generated with the following command:
gtfToGenePred -genePredExt -allErrors -ignoreGroupsWithoutExons \
Homo_sapiens_ensembl_99.gtf /dev/stdout | \
awk '{print $12"\t"$1"\t"$2"\t"$3"\t"$4"\t"$5"\t"$6"\t"$7"\t"$8"\t"$9"\t"$10}' \
> Homo_sapiens_ensembl_99.refFlat \

Also, I noticed that the version in the STAR log file is 2.7.9a. The STAR version used by the celescope conda environment is 2.6.1b. https://github.com/singleron-RD/CeleScope/blob/master/conda_pkgs.txt. This indicates that the celescope conda environment is not properly activated.


Rosetta 2.0 Test

@KatieWoe, @kathy-phet, @oliver-phet, and @jbphet, Rosetta 2.0 is feature-complete and ready for testing.
There are two main objectives to this test:

Ensure Rosetta 2.0 has the same basic functionality as the old translation utility.
Ensure Rosetta 2.0's new features work as intended.

This might sound simple, but there's a lot behind both of these objectives. We will test in phases.
Think of the checkboxes as "bare minimum" testing. It be good to do a bit of "dev" testing where you're just trying to break things. It would also be good to do a bit of "RC" testing where you verify things are behaving the same on different browsers. We don't really care about mobile devices.
Also, QA has a set of "testing" logins to the PhET website.
As always, feel free to ask questions. Since @jbphet is busy trying to get Greenhouse out the door, please direct questions to me.
We might have another phase where we actually have some builds done when you hit the publish button, but this will require coordination with Jonathon Olson and Matt Pennington, and we'll need to be careful about the configuration and which sims we publish.
The test can be accessed by going to https://ox-dev.colorado.edu/translate. @mattpen is testing working on the sign-in to the website, so it's possible you'll have trouble signing in at some point.
At some point, ideally during phase 1, it would be great if we could get @solaolateju and/or @DianaTavares to do a bit of testing. I will ping them on Slack on Monday.
Assigning @kathy-phet for prioritization.
As of this writing (11 PM Friday night), I'm not able to sign in to Ox-Dev, and Rosetta seemingly can't hit the website user data route on Ox-Dev. Right now, Rosetta is configured to use https://phet-direct-dev.colorado.edu/user/check-login as the website user data route. Hopefully @mattpen can take a look on Monday morning.
@KatieWoe, I wasn't sure what labels to add, so I didn't add any, but if you think it needs certain labels, please add them.
Phase 1: Test New Features
Be aware that the publish button is not meant to be working during this phase.

[x] I will configure Rosetta to not perform string commits.
[x] I will configure Rosetta to not send build requests.
[x] I will configure Rosetta to have it's Babel branch be master.
[x] QA will:

[x] ensure the translation "report" i.e. the stats for each sim in a
given locale load properly
[x] spot-check a handful of the stats to ensure they are accurate

To do this, QA will have to look at the translated string file in
Babel. If they really want to be thorough, they can count the
total number of strings in the published sim. If they want to do
this, they should ask me for a copy of the strings file for the
published sim.

[x] ensure the translation reports are cached
[x] ensure the tables are sortable

❎ ensure the sorting is correct

[x] ensure the translation "form" shows errors when placeholders
don't match
[x] ensure the save, publish, and test buttons are disabled when
there are form errors
[x] ensure the copy button copies the English string over

Phase 2: Test Old Features
Be aware that during this phase, the publish button should work, and it will commit strings to the test branch of Babel.

[x] I will configure Rosetta to perform string commits.
[x] I will configure Rosetta to not send build requests.
[x] I will configure Rosetta to have it's Babel branch be tests.
[x] QA will:

[x] ensure they can publish a translation and see the results on
Babel
❎ ensure the simulation you published has a "(pending update)"
badge next to it

this should go away after 2 * SIM_METADATA_VALID_DURATION or ten
minutes, whichever is the greater

[x] ensure the save button saves their translation
❎ ensure that once they've published a translation, and then
wait about ten minutes, they see the strings from Babel, not strings
they saved

To test this, save a translation, modify the saved translation,
publish it, and then wait ten minutes. When you come back, you
should see the strings that are in Babel in the form rather than your
saved strings. (The saved translation should be deleted from the
database when you publish.)

Phase 3: Test Down for Maintenance / Sign-In / Permissions
Phase 3 Part A

[x] I will configure Rosetta to show its "Down for Maintenance" page.
QA will:

[x] ensure they see a message about the translation utility being
down for maintenance
[x] ensure they can't access /translate/{locale}
[x] ensure they can't access /translate/{locale}/{sim-name}
[x] ensure they can't access /translate/admin

Phase 3 Part B

[x] I will configure Rosetta to be enabled.
[x] I will configure Rosetta to not perform string commits.
[x] I will configure Rosetta to not send build requests.
[x] I will configure Rosetta to have it's Babel branch be master.
QA will:

[x] ensure that someone who isn't a trusted translator or a team
member can't access the translation utility
[x] ensure that team members who aren't trusted translators can
access the translation utility
[x] ensure that trusted translators who aren't team members can
access the translation utility

for phase 1 testing: I used win10 chrome and Nancy used MacOS 13 Safari 16

Hi team!
Glad to see that Rosetta is coming along! Here are some comments about my review as user:
I really like the view and the new features! The first time I access, it takes some time to load all the information about the percentage of the strings translated in that locale, but the second time, it was faster, looks like is saving some data.
I like the links to go back to the Sims list and the Select Locale.
I said @liammulh that in the beginning I thought that this button will copy the English string to the clipboard for me to paste it in Google Translate for example. But no, this button put the English string to the Translation. A tooltip will be enough to solve this confusion, but I am still thinking that a functionality that allow to copy the English strings to the clipboard is also super useful to think in a future improvement.

I also think that the Save, Publish and Test buttons need to be always visible while we are translating. It is not a good user experience to have to scroll up or down to access this buttons. Also, a button that said, “Go to the top” always visible can be good! It is not a good experience to finish translating a sim, you want to move to another sim or go back to the list of sims/locales, and need to scroll all the way up.
It is possible to have the information in the picture always visible while we are translating the strings? I always give a fast scroll up-down to be sure that I translate all strings, but having this information, I think, is more efficient.

I use control+f to look for the sim I want to translate, but probably a search option cool be a good idea, specially for tablets, but I know that this is more for computer users.
When I clicked the buttons in the picture I expected to see the list to reorder for the sim with less or more strings, or less or more common strings, but no, the list reorder alphabetic. It is the behavior expected for the same button in the “Sim title”, but in the other column titles it was strange. Looks like these buttons are only useful in the “translated sims” table, where it reorders the sims according to the %.

Is normal that when I test a sim, the tab loos like is always loading?

I have to accept that I didn't see the “Translation saved” message the first time. It has the same color that the page and appears at the top of the page. I finish translating something in the bottom of the page, click Save, and didn't realize why I couldn't scroll the page until I saw the small window.  Probably move it to the center of the page with a more colorful ackgorund, or just close to the Save button.

These are all my comments. Amazing job team!

Great work @liammulh. It's so nice to see the progress.
Following the review of the translation utility, the copy button, placeholder message, and inactive buttons (test, save, publish) all work.
Phase 1:

Sorting: In the "not yet translated" list, "Sim-Specific Strings" seem to sort by  "Sim Title". Understandably, since the translated string percentages are equal. Sorting by this list might not be necessary.
When a translator saves their progress but did not publish the sim, will it remain in the "not yet translated" or "translated" list? Staying in the "not yet translated" list will make the list sortable and address this concern.

I did not test caching of the translation reports.

Others Out of scope(phase 1);

Prompt user  to save to avoid losing when "Back to Yoruba (yo) Sim List" is clicked with unsaved content.

I use control+f to look for the sim I want to translate, but probably a search option cool be a good idea, specially for tablets, but I know that this is more for computer users.

I think adding a search feature would increase the complexity of the client-side code significantly and it would really only be a feature for people who translate on tablets, so I'm very reluctant to add this. Also, it's possible to search web pages on mobile now, at least in Safari on iOS.

When I clicked the buttons in the picture I expected to see the list to reorder for the sim with less or more strings, or less or more common strings, but no, the list reorder alphabetic. It is the behavior expected for the same button in the “Sim title”, but in the other column titles it was strange. Looks like these buttons are only useful in the “translated sims” table, where it reorders the sims according to the %.

The sim title button sorts according to sim title, the sim-specific column sorts according to sim-specific percentage, and the common button sorts according to common percentage. @DianaTavares, what is confusing about the buttons?
It's true the sim-specific button in the untranslated table doesn't really do anything since all of the sims have 0 percent. We could disable that button or make it so that it doesn't do anything. @DianaTavares, what do you think about this?

Is normal that when I test a sim, the tab loos like is always loading?

No, I don't think that's normal. I think that needs an issue.

I have to accept that I didn't see the “Translation saved” message the first time. It has the same color that the page and appears at the top of the page. I finish translating something in the bottom of the page, click Save, and didn't realize why I couldn't scroll the page until I saw the small window. Probably move it to the center of the page with a more colorful ackgorund, or just close to the Save button.

We don't have control over where the pop-up happens. It's controlled by the web browser. In a future release, we could create and position our own modal, I think.

It is ok without a search option.
My confusion about the sort buttons is that in the no translated sim they don't do anything because all the percentages are 0%. I like the idea of disable them (or delete them from this table). Because buttons that don't do anything make think that something is wrong.
I understand the pop-up comment. It is ok if we can't control its position.
Thanks for answer all my comments!!

In the "not yet translated" list, "Sim-Specific Strings" seem to sort by "Sim Title". Understandably, since the translated string percentages are equal. Sorting by this list might not be necessary.

Noted. I made https://github.com/phetsims/rosetta/issues/340 for this.

When a translator saves their progress but did not publish the sim, will it remain in the "not yet translated" or "translated" list? Staying in the "not yet translated" list will make the list sortable and address this concern.

Saving the translation will not affect whether it is in the "not yet translated" or "translated" list. It also won't affect the statistics for the number of strings translated. The "not yet translated" or "translated" lists can only change if you click the publish button. Similarly, the string statistics can only change if you click the publish button.

Prompt user to save to avoid losing when "Back to Yoruba (yo) Sim List" is clicked with unsaved content.

This is a feature we plan to add, but not for this version of Rosetta, unfortunately. This issue is tracked in https://github.com/phetsims/rosetta/issues/325.
Actually, now that I think about it, we could add an alert just for clicking the "Back to {Locale} {locale-code}" link. It wouldn't handle the case if someone clicked a different link or if they tried to close the tab.

Thank you @DianaTavares and @solaolateju for all of your feedback! I appreciate it! :)

I'm going to use this comment to track the issues that have come out of testing and what I plan on doing about them.

Issue
Type
For this release?
Actionable?
Done and ready for testing?

https://github.com/phetsims/rosetta/issues/331
Bug
Yes
Yes
No

https://github.com/phetsims/rosetta/issues/332
Design
Yes
Yes
No

https://github.com/phetsims/rosetta/issues/334
Design
Yes
Yes
No

https://github.com/phetsims/rosetta/issues/335
Feature
No
N/A
N/A

https://github.com/phetsims/rosetta/issues/336
Design
Yes (if easy)
Yes
No

https://github.com/phetsims/rosetta/issues/337
Feature
No
N/A
N/A

https://github.com/phetsims/rosetta/issues/338
Bug
?
Needs steps to reproduce
No

https://github.com/phetsims/rosetta/issues/339
Design
No
N/A
N/A

https://github.com/phetsims/rosetta/issues/340
Design
Yes
Yes
No

https://github.com/phetsims/rosetta/issues/341
Feature
Yes
Yes
No

I think Phase 2 is done. @Nancy-Salpepi tested macOS13 + safari 16 and I tested Win 11 + Chrome.

Okay, I've configured Rosetta for Phase 3, Part A.

Phase 3a looks ok

Okay, I've configured Rosetta for Phase 3 Part B.

I noticed when entering the translation utility, for a second the sign in page flashes even if already signed in (whether the account signed in is a translator or not) before going to the appropriate page. I don't think this is necessarily a bug, but let me know if you want an issue @liammulh

QA is done with 3b

the sign in page flashes even if already signed in (whether the account signed in is a translator or not) before going to the appropriate page

It's probably re-rendering due to data changing. If it's not too much trouble, could you record a gif?

Sorry for the poor quality. I took a video since this device doesn't have any of the gif recording tools installed. The flash is quite quick.
https://user-images.githubusercontent.com/41024075/209384192-01149a1b-72ac-4eae-89cc-e8a1620f8b34.MOV

Oh, yeah I think that's just how it is due to it getting data and re-rendering. Thanks for being so thorough!

All issues have been addressed. Closing.


Fix v7: check transactions succeed after they're included in a block

Summary
Sometimes a transaction returns code 0 initially, but then fails when a validator goes to actually include it in a block. This PR adds code to cosmos' ExecTx to make sure transactions are verified after their inclusion in a block; if they fail at any stage of proceedings, an error is returned.

Yea this is an SDK thing. It always returns code 0 so long as it passes message Validate(), but then once included is when the real failure can occur (like gas, etc)
I do worry that some users may want a tx which is successful on submit but fail upstream (I have this exact case checked with proof of authority). I need to think on this moer

hmm, i think we should maybe introduce different error types then; that way you get an err back and you can make sure it's of type UpstreamFailure or whatever

Thinking about it, I think it makes sense to for ExecTx. If someone wants to bypass they can use Exec / ExecBin to ignore

Ty!


Async parser does not transform array into comma-separated.

My data in json:
[
 { name: "test name", tags: ["tags1", "tags2"] }
]

my code:
import { transforms, AsyncParser } from 'json2csv';

  protected getParser(): AsyncParser<DataCsvFields> {
    const fields = ['name', 'tags'];

    return new AsyncParser({
      fields,
      delimiter: ',',
      eol: '\n',
      transforms: [transforms.flatten({ arrays: true })],
    });
  }

    let data = await this.readData();
    let csv = '';
    const asyncParser = this.getParser();
    asyncParser.processor
      .on('data', chunk => {
        csv += chunk.toString();
      })
      .on('error', err => {});

    while (data.length) {
      asyncParser.input.push(JSON.stringify(data));
      data = await this.readData(data[data.length - 1].id);
    }
    asyncParser.input.push(null);

expected csv output:
name,tags
test name, "tags1, tags2"

current result:
name,tags
test name

So tags are missing, but when I remove transforms: [transforms.flatten({ arrays: true })],
I will get:
name,tags
test name, "[""tag1"", ""tag2""]"

but I want to array value to be comma-separated.

Hi @kkorus ,
The reason you are getting that output is because after using flatten, there is no tags field anymore.
Try removing the fields option. The actual result is (notice that there is no tags column)
"name","tags.0","tags.1"
"test name","tags1","tags2"

For something close to your expected output, as you figured out, you don't use any transform and you get:
"name","tags"
"test name","[""tags1"",""tags2""]"

If you want to remove the brackets or inner quotes you need to use a custom selector.
Or using v6 (only in pre-release now)

Closing since help was provided and there was no answer.

Closing since help was provided and there was no answer.


Add files via upload

Description
Here my contribution to "The Duck Gallery".

You must respect the following conditions

Your contribution must respect the code of conduct
It's your first PR to this repository
You have added your image of the duck downloaded from https://pimpmyduck.zenika.com
You have not changed the image of the duck
The image filename must be your GitHub username (ex: your-username.png)
You are using your own GitHub user and it's the same as the PR author
Into the contributors.js file, the message must be short and respect the code of conduct

If the PR doesn't respect those conditions, it will be closed

Hello @maram934 , thanks for your contribution.
Please complete your PR with a change on contributor file as mentionned in the Readme.


remove unnecessary persist

Signed-off-by: Ratan Rai Sur<EMAIL_ADDRESS>PR description
In the process of fixing the pruning bug, I believe I found an unnecessary persist.

@CjHare I've been burning this in for a while and it looks to be good:
https://grafana-metrics-ohio.ops.pegasys.tech/d/5S-6O8VZk/besu-overview?orgId=1&from=1587744825000&to=now&refresh=5s&var-system=dev-besu-release-mainnet-persist-rai2


Add OnSendToIRCMessage and OnSendToClientMessage

As described in this comment.

@DarthGandalf Should I implement CMessage variants of PutIRC and PutUser?

I see several issues:

Any changes to the message made by modules are ignored
Rather than parsing the line for the sake of calling modules, PutClient should accept CMessage, and stringify it to get the line to send. Also see #1193

@DarthGandalf Any recommendations for handling changes to the message made by modules? Should we make a copy of the CMessage before sending it to modules?
As for making a version of PutClient that accepts a CMessage, one already exists, but ultimately it stringifies the CMessage and calls the CString variant, which is what calls modules and writes to the client. Changing things so that this is handled by PutClient(CMessage) would require some more significant changes. What do you think?

Oh wait, I misunderstood your first issue. Give me a moment and I'll fix that.

Actually, on review, it wasn't that difficult to change PutClient such that the PutClient(CMessage) handled actually sending messages and calling hooks.

Another bonus from doing that is that it eliminated the need for a separate module hook for specifying message tags, as that can now be done inside OnSendToClientMessage().

@DarthGandalf Please take another look when you have the opportunity. Thanks!

The copying behavior was based on the way OnChan/PrivBufferPlayMessage is handled, along with the way most of the other OnXMessage hooks are handled. While there is a performance hit for modules that don't override OnSendToIRCMessage or OnSendToClientMessage, if those are overridden then the non-Message variants aren't even called. Then again, OnSendToIRCMessage and OnSendToClientMessage will be called much more often, so I'll switch to a method of calling both directly.

For those OnXMessage hooks, I don't know how to avoid such per-module conversion back and forth. If you have any better idea, please say.
Hopefully, after several versions, after the sufficient transition period, old deprecated hooks can be removed, and such compatibility code can be dropped.

Okay, I've switched things such that both OnSendToClient/IRC and OnSendToClient/IRCMessage are called for performance reasons. I've also added tests for the new hooks.


md-select initial value not loaded

Bug, feature request, or proposal:
I am having an issue with Angular2's material md-select component where the value from a FormGroup is not loading or being populated into the select. Here is the code...
https://embed.plnkr.co/p7Fm9lC4TxoVaZ8ydYf0/
The value for the control 'formal' is set to 1, but the UI shows as if no value is populated with the placeholder message.
Am I doing something wrong or is this a bug?
What is the expected behavior?
The select should be populated with the correct value
What is the current behavior?
It defaults to the no selections or placeholder text
What are the steps to reproduce?
https://embed.plnkr.co/p7Fm9lC4TxoVaZ8ydYf0/
What is the use-case or motivation for changing an existing behavior?
It is expected user behavior
Which versions of Angular, Material, OS, browsers are affected?
Angular 2.4.1
Is there anything else we should know?

Number -> String
ngOnInit() {
    this.form = new FormBuilder().group({
      'formal': ['1']
      });
  }```

That was stupid of me, Thanks!


Release Google.Shopping.Merchant.Quota.V1Beta version 1.0.0-beta00

Changes in this release:
No API surface changes; just dependency updates.
PiperOrigin-RevId: 616092500
Fixes: b/329819910

Doh! Apologies for that. On it...

Closing this as we'll end up creating a new branch...


Fix runtime error creating arrays of negative length

This one-character change (plus test) fixes a runtime error when creating arrays of negative length with Array.initialize or Array.repeat. This behavior is now consistent with List.repeat.

This will fix #175.


Create magic_number.cpp

This Pull Request is for HacktoberFest 2020
Description of Change

Checklist

[ ] Added description of change
[ ] Added file name matches File name guidelines
[ ] Added tests and example, test must pass
[ ] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[ ] Relevant documentation/comments is changed or added
[ ] PR title follows semantic commit guidelines
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[ ] I acknowledge that all my contributions will be made under the project's license.

Notes:

👍 Well-written and documented code.
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/neha-hasija17/C-Plus-Plus/actions

thankyou sir. please review this.

@Panquesito7 please review this. this Pull request is for hacktober fest 2020

@Panquesito7 why the basic tests are failing? I don't understand this, kindly make the necessary changes so it works well like before.

@Panquesito7 please have a look

@Panquesito7 Kindly review this.

@ayaankhan98 Please use squash-merge. Thank you.


"Red Five" mahjong tiles

Japanese (Rīchi) Mahjong optionally switches one five in each suit to be a red five. When discussing rules or strategy in text, it is useful to be able to refer to them directly, as they have a semantic difference (they are worth extra points).
Here are two screenshots from Daina Chiba's book "Riichi Book 1":

Petitions
N/A
Proposals
N/A
Specific References

Riichi Book 1

Standard References

Unicode Technical Standard 51 “Unicode Emoji” (beta)
How to propose emojis to Unicode
How to propose other additions or changes to Unicode (required form, email address: docsubmit＠unicode.org)
Unicode document submission form

Note that in some variants other tiles (3s, 7s) are marked red as well/instead of the 5s.

Note that in some variants other tiles (3s, 7s) are marked red as well/instead of the 5s.

New link for the Book
I guess another justification is that the red dora tiles are sometimes drawn differently (e.g. with a dot) for accessibility purposes, like those shown here, or this Kanto set in Wikipedia

Though if we are talking about encoding Mahjong variant tiles, I wonder how far we can go with that.
Encoding local variants in Unicode is not exactly a new thing, we have stuff like:

Separate codepoints for variants in the Eastern Zodiac (which is how we got different characters for Goat, Sheep and Ram, etc)
The "Playing Cards" Block containing the standard poker deck + Knight, and 3 Jokers instead of 2.
The "Chess Symbols" Block containing all sorts of "rotated" variants of chess pieces to represent fairy chess pieces, some of them not even having evidences of actual use cases.
Even for Mahjong tiles, The joker tile 🀪 is already encoded in Unicode because it is "used in American Mahjong". It is not in the standard or traditional "Old Hong Kong" version.

Here are some variants that I know of/can find (based on wiki), in a roughly decreasing order (*in my opinion) of certainty/popularity:

Red dora 5's, as given by this issue. Popular in Japanese Mahjong, probably the most common local rule in Japan.
Dotted white dragon (白ポッチ shiro pocchi), which is a special White Dragon that acts as a wildcard if drawn after Richi (among other rule variations). Wiki says they are rare, but I assume they are at least more popular than most other variants in Japan.

There are two styles  for this tile, though they have no semantic difference.

Restricted Jokers, along with the "Universal" one. Used in Vietnamese Mahjong (according to wiki) and some Hong Kong variants. The most common version I can find (online) is these 8: 番元喜合筒索萬總 (Honor, Dragon, Wind, Suit, Circle, Bamboo, Character, Universal), but more variants exists (see below)

In older Vietnamese Mahjong there is 花 (Flower Joker, always the "correct" Flower) instead of 番.

Two extra sets of Flowers. Used in Malaysian and Vietnamese Mahjong (according to wiki), but with different naming schemes. Whether they can/should be unified is unknown.

Malaysia uses 琴棋書画 漁樵耕読 (4 arts + 4 professions)
Vietnam uses 皇 and 后 with numbering

Extra Red tiles, as mentioned above. 3/7's appears occasionally in variants, and even rarer are 1/9's or Norths.

Sometimes the Dotted white dragon is considered a Red tile as well.

Unordered (but paired) Flowers ("Animal Tiles"). Used in Malaysian Mahjong. Getting a matching pair means immediate payment (according to wiki). The 2 most standardized pairs are probably these:

Some versions involve "loosely paired" Human Head Tiles, where any Female + Male Head tile form a matching Pair.
Some versions involve "unpaired" Clown Tiles, where any two Clown tiles form a matching Pair.

Some variants are so rare and niche that they might not be encoded properly:

Less common/standard Jokers:

"Fly" tiles (飛), which are Universal Joker that can be "recycled" if the tile it replaces is drawn, Rummikub-style. Found in Malaysian Mahjong. Though since they don't have a "normal" Universal Joker, this might not count as a separate tile.

Similarly, a "second Universal joker" (陞王) that is assumed to function the same as the Universal Joker.

Number-restricted Jokers: Terminal (1-9), 1-4-7, 2-5-8, and 3-6-9 Joker (么仕將卒). Found in some Hong Kong Joker Mahjong variants.
Some even more obscure Joker variants exists, like those sold here. No idea what some of them even mean.

Extra animals:

Wiki mentions that Thai and 4P Malaysian sets have 4 animals, but no info on what the other 2 pairs are.
The Wiki also shows an image with 18 pairs of animals.
Since they can't reasonably be all encoded. It may actually make more sense to use an Emoji + "combining Mahjong Tile character" at that point. Same for the Jokers or the Flowers below.

Extra flowers:

This article mentions that ancient Mahjong variants have more than 2 sets of flowers, which all have vastly different themes. The wiki even mentions a variant that has up to 44 flowers (11 sets).

Even more Red Tiles (Even numbers, Wind tiles or Flower tiles), or even other colored (counted differently) tiles. Found in Mahjong parlors that want to have their unique house rules

If these obscure variants are to be encoded (or considered), it's probably best to just use modifiers or sequences instead.

10-tiles are briefly mentioned in the Japanese wiki, but it is probably a one-off thing made by some manufacturers. No rules about them are known.

There seems to be one attempt to encode Mahjong variants (among other things like related symbols) into a font:
https://twitter.com/Umihotarus/status/945598664512233472
However, the font (pack) itself doesn't seem to be free, nor is it available for sale (for some reason, so I'm not able to find out what tiles the font has recorded.
The creator also decided against proposing a "Mahjong Tiles Supplement" block themselves, due to lack of evidence of these variants ever being referenced in text.


Return old nice JS icon!

Please, i very like your extension but new JS icon you made (latest version) make my eyes a little bleeding.
Give us back old good intelligent JS icon please :-)
P.S. I have light theme.

Here we go again! #508, #339 & #354.
Thanks @VitalySenko for your opinion. We'll have to start a debate on this. What I know is that at some point any decision me make is not going to please everybody. Let's see what people says in this thread.
Anyway, I'm starting to work in a new functionality that will allow more customization options to the extension. It's just raw material for the moment but I expect to have it soon. By now, just a PoC.

Been there, done that. It's a non ending story. Would a poll do the trick?

Using the dark theme it's the brightest thing on my screen now.  Large blocks of yellow for js files.  Maybe supporting themes would be a good way to solve it ? Right now I'll probably have to turn it off.

@solomon23 what do you mean with supporting themes? VSCode api is what it is and doesn't really allow any kind of customization by the user. Their solution is to create an alternative theme, but there are already other themes in the market that provide slightly different icons (a lot of them are feeding from our repo).
I was reluctant to change JS and TS icons at the beginning but now I think I like how they look like. I intend to keep this thread open and see which are the opinions of users, although I guess this will be biased to the don't like feeling.
I've asked among my fellow colleagues and they all seem to like it but everything is susceptible of being discussed.

@robertohuertasm apologies, i can't really speak intelligently about solutions since i'm not really familiar with it.  The new yellow JS icon is garish enough that I had to turn it off since it's too distracting to my workspace.  Luckily for me there are other icon choices out there for me, so I'll just use one of those.  Thanks !

@solomon23 no worries. I understand that pleasing everybody is an impossible mission. Anyway, I will try a new set of icons playing with inversion of colors (that was the idea behind the old icons) and hopefully will find a way for the user to decide which one to use (although I can't promise you anything).

It's not about pleasing everybody in this case, since many users are using a dark theme placing a light yellow block as an icon it's a debatable choice at best.
Isn't there a way to manually override it at the moment?

@JohhnyP, no overriding options at the moment 😞 In fact, VSCode API doesn't allow any user decision at all.

Sadface.
Ok looking forward to your changes that will allow to revert or customize the icons.
Also i'm attaching an image to see how distracting is on a .js heavy project.

Maybe this weekend I'll have time but I can't promise you anything.
The thing is that I kind of like it although I was myself reluctant to adopt this icon at first, but as I said before, everybody has its own opinion on subjective matters.

On a survey among colleagues the answers were in favor of the new icon.
As Roberto said, we won't get any positive feedback in this thread.
Now on the front on how to provide a way to customize the icons, I have an idea but I first would like to discuss this in private with Roberto.
So @robertohuertasm when you find the time please email me (email is on my profile).

Same situation in my workplace. @JimiC I'm currently working on this but I'll be happy to discuss with it. I was considering to create a slack channel or something for us to communicate faster and privately if we want.

👍 on slack. Skype will suffice too.

I've been using vscode very early on, and vscode icons when it had like 13k downloads so I've seen the progress, which I thank you guys for very much! But when I updated the extension today and saw all that yellow across my screen I died a bit inside.
@JohhnyP Same here:

So yeah, please provide a way so we can choose the icon or something please :)
thanks!

Just FYI. @robertohuertasm and I are looking into providing a way to add a feature so you can configure each icon.
So until this happens

+1 to revert icon, or being able to opt out of it in configuration.


layoutsDirs Option is not working

Expectation:
When the layoutsDirs option is set to layouts, all files inside that folder are expected to be imported and used as layouts on the <root>/layouts.
Current state
The layout won't render unless I place it inside of  src/layouts
This is my vite.config.js:

This is my current folder structure:

This is what I do to work:

try this:
layoutsDirs: 'src/layouts',
btw, src/layouts is the default value for this option.

try this: layoutsDirs: 'src/layouts', btw, src/layouts is the default value for this option.

Hi @mazhewei, thanks for the reply.
The default option is the only one that is working. Any option filled at layoutsDirs property doesn't.
For instance:
{
...
    layoutsDirs: 'layouts' // OR "test/layout",
...
}

Doesn't work, the layout files inside of <root>/layout or <root>/test/layout aren't found,  but with the same configuration if you place the files inside of src/layouts, still works.
I believe there is may have a bug in there.

Just tested with example code in this repo, cannot reproduce.


Xamarin.Forms 3.6 (Android) - Linker issue in Release configuration: "Failed to resolve System.Void SkiaSharp.SKPath::AddRoundRect"

Description
When trying to compile in VSTO Release configuration with activated linker I get this exception:
Mono.Linker.MarkException: Error processing method: 'SkiaSharp.SKPath FFImageLoading.Svg.Platform.SKSvg::ReadElement(System.Xml.Linq.XElement,System.Collections.Generic.Dictionary`2<System.String,System.String>)' in assembly: 'FFImageLoading.Svg.Platform.dll' ---> Mono.Cecil.ResolutionException: Failed to resolve System.Void SkiaSharp.SKPath::AddRoundRect(SkiaSharp.SKRect,System.Single,System.Single,SkiaSharp.SKPathDirection)
bei Mono.Linker.Steps.MarkStep.HandleUnresolvedMethod(MethodReference reference)
bei Mono.Linker.Steps.MarkStep.MarkMethod(MethodReference reference)
bei Mono.Linker.Steps.MarkStep.MarkInstruction(Instruction instruction)
bei Mono.Linker.Steps.MarkStep.MarkMethodBody(MethodBody body)
bei Mono.Linker.Steps.MarkStep.ProcessMethod(MethodDefinition method)
bei Mono.Linker.Steps.MarkStep.ProcessQueue()
--- Ende der internen Ausnahmestapelüberwachung ---
bei Mono.Linker.Steps.MarkStep.ProcessQueue()
bei Mono.Linker.Steps.MarkStep.ProcessPrimaryQueue()
bei Mono.Linker.Steps.MarkStep.Process()
bei MonoDroid.Tuner.MonoDroidMarkStep.Process(LinkContext context)
bei Mono.Linker.Pipeline.Process(LinkContext context)
bei MonoDroid.Tuner.Linker.Process(LinkerOptions options, ILogger logger, LinkContext& context)
bei Xamarin.Android.Tasks.LinkAssemblies.Execute(DirectoryAssemblyResolver res)
bei Xamarin.Android.Tasks.LinkAssemblies.Execute()
bei Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
bei Microsoft.Build.BackEnd.TaskBuilder.d__26.MoveNext()
Steps to Reproduce
Add the NuGet packages Xamarin.FFImageLoading.Forms, Xamarin.FFImageLoading.Svg.Forms, Xamarin.FFImageLoading.Transformations to all projects of a Xamarin.Forms solution. Switch VSTO to Release configuration. Try to build the Android project.
Expected Behavior
Should build in Release config with linker activated. (In Debug config everything works fine.)
Actual Behavior
Shows exception during compile time.
Basic Information

Version with issue: FFImageLoading <IP_ADDRESS>9-pre with Xamarin.Forms <IP_ADDRESS>4457, Android Target: 9.0 Pie
Last known good version: ???
Platform: Xamarin.Forms, Xamarin.Android

Only with activated linker.
Screenshots
n/a
Reproduction Link / Code
n/a

Do you have SkiaSharp package installed? Which version do you use?
Are you sure you have the same FFIL packages version in all projects?

No, I didn't install SkipSharp package. I followed this wiki: https://github.com/luberda-molinet/FFImageLoading/wiki/Xamarin.Forms-API.
All packages had the same version <IP_ADDRESS>9-pre in all projects.

You must install SkiaSharp, it's a library dependency. It should be installed by Visual Studio automatically, but as you see sometimes there are problem with that.

Simple as that :-) Thank you very much!
One last question: where is the place to post general questions about things I can't find an answer in the documentation?

I think asking as a separate issue should be fine. Also note, that our wiki is open for edits for everyone, feel free to update it if you think that information would be useful for anyone. Cheers.


Try to fix broken images on egui.rs

The images in the widget gallery on egui.rs are broken:

Not sure why yet, and I fail to reproduce locally.
Probably related to:

https://github.com/emilk/egui/pull/5431

I really dont want to intervene here, but @lucasmerlin might be right. I cannot even open the image with my standard image viewer. If i copy the image from the eframe/data to egui_demo_lib/data it works.

@InfoInnovator if you have this problem locally, make sure you have properly setup git lfs.

My bad. I didnt expect somebody to use lfs for a small PNG and didnt know of the guide. After pulling the lfs files, the web demo works as intended.

Ah, then we should mark the .png:s used for the demo as non-lfs, and also see if we can improve the error message (does lfs links start with some magic bytes?)

(does lfs links start with some magic bytes?)

I think so:
version https://git-lfs.github.com/spec/v1
oid sha256:4d7a214614ab2935c943f9e0ff69d22eadbb8f32b1258daaa5e2ca24d17e2393
size 12345

Improvement!

Fixed! Just need to update CI not to complain


Please specify the supported node.js versions, or, preferably, please convert the code to run on the lower versions of node.js.

I'm using node.js version 4.x (for some reason). I downloaded this module, and found it was not for the node.js version I use.
Since the concept of this module is nice, I will try to convert the code using the typescript compiler to run on the node.js version I use.
But it would be nice if this module could run on the somewhat old node.js versions.

Node 4 will end its maintenance LTS in 7 days, see https://github.com/nodejs/Release
For that reason, you should upgrade your nodejs installation ASAP since you will no longer receive any security patches.
Having that in mind, it doesn’t make much sense to support node v4.
Makes sense?

Regarding the versions support, I'm open to accept a MR that adds "engine" do the package.json, see https://docs.npmjs.com/files/package.json#engines

If you really want to use node v4, you may use v2.x.x of this module.

I know that the lifetime of 4.x is ending. I have a plan to upgrade it.
Meanwhile I'll use your module by 'compiling' the source code into the old JS code using Typescript compiler. In fact it's already done and seems to work well for 4.x. Is it ok? You added a comment about v2.x.x while I'm writing this comment. I think that the 'compiled' latest code will be better than the old v2.x.x code. (bug fix, additional feature, etc.)
Thanks!

@zeodtr yep, compiling is better since you will be using the latest version always.
Will close this issue. Feel free to make a PR adding engines to package.json as I stated above.
Have a nice week!


Support of structure parsing

Codecov Report

Merging #38 into master will decrease coverage by 0.32%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   44.21%   43.89%   -0.33%
==========================================
  Files          91       91
  Lines        1911     1925      +14
==========================================
  Hits          845      845
- Misses       1066     1080      +14

Impacted Files
Coverage Δ

...ages/dynamic_forms/lib/src/parser/parser_node.dart
47.61% <ø> (ø)
:arrow_up:

...amic_forms/lib/src/parser/xml/xml_parser_node.dart
67.27% <0%> (-13.17%)
:arrow_down:

...ic_forms/lib/src/parser/json/json_parser_node.dart
73.07% <0%> (-17.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a9598b...e2d316f. Read the comment docs.


vt cat results in chrom replacement

Hi,
Thanks for developing vt - looks like it could be really helpful
I've come across an issue when using vt cat to combine VCF files generated on the same set of samples but on different chromosomes (as per the example in the docs: http://genome.sph.umich.edu/wiki/Vt#Concatenate). The chromosome name is being replaced with whatever it is in the first VCF file supplied. I've tried with both specifying the VCFs in full or using an input file list (-L)
An example of what I'm trying to do:
vt cat chr1.vcf chr2.vcf -o cat.vcf
The variants are concatenated in cat.vcf, however all the chromosome names would be converted to chr1
BW
Chris

vt cat just writes out the header in the first vcf file in the list.  To ensure a complete header, you can prepare a complete header with all the contigs and necessary meta information and name it as chr1.vcf.hdr.  vt will read that header instead and print that out in the out file.
It would be if vt scans through all the headers but I prefer to keep the implementation simple as that solution does not work in a series of pipes.
Did you try bcftools concat too?

Hi, thanks for getting back to me so quickly, bcftools concat is just what I needed!
Thanks again,
Chris

fixed. allows for concatenating of files with different headers.  missing headers in the first file are copied over and ids are translated accordingly.  checks for consistency of samples in all the files too. Used bcf_hdr_combine and bcf_translate which made it really simple.


ERR_CERT_COMMON_NAME_INVALID on Laravel Valet

Hi,
I'm using Laravel Valet for my local environment with https enabled, and I got this error using https on Laravel Echo:
net::ERR_CERT_COMMON_NAME_INVALID
My conf:
{
	"authHost": "https://tarenas.test",
	"authEndpoint": "/broadcasting/auth",
	"clients": [],
	"database": "redis",
	"databaseConfig": {
		"redis": {},
		"sqlite": {
			"databasePath": "/database/laravel-echo-server.sqlite"
		}
	},
	"devMode": true,
	"host": null,
	"port": "6001",
	"protocol": "https",
	"socketio": {},
	"sslCertPath": "..../.valet/Certificates/Tarenas.test.crt",
	"sslKeyPath": "..../.valet/Certificates/Tarenas.test.key",
	"sslCertChainPath": "",
	"sslPassphrase": "",
	"apiOriginAllow": {
       "allowCors" : true,
       "allowOrigin" : "*",
       "allowMethods" : "GET, POST",
       "allowHeaders" : "Origin, Content-Type, X-Auth-Token, X-Requested-With, Accept, Authorization, X-CSRF-TOKEN, X-Socket-Id"
   }
}

App:
new Echo({
    broadcaster: 'socket.io',
    host: 'https://localhost:6001',
    encrypted: true
});

Anyone know what this could be?

@regiszanandrea What did you do to get this working?

My host https://localhost:6001 should be https://tarenas.test


GitHub-PR-check reports to the wrong job when using concurrency

I have an action with concurrency enabled to ensure that only a single job will run at a time. However, the reporter creates the checks report in the canceled job instead of the current job.
Reporter: GitHub Checks (-reporter=github-pr-check)
command: reviewdog -name="Apex Tests ($TARGET)" -f=rdjsonl -reporter=github-pr-check -filter-mode=nofilter
current job:

Canceled job:

In this case, the github checks Apex Tests should be presented in the current job and not the canceled one.

I'm pretty sure this is https://github.com/reviewdog/reviewdog/issues/403

This can be closed as its a duplicate of #403.


Sunbird-RC 2.0 setup guide for Bangladesh team

What is the feature request for?
Registry Core
What problem/inconvenience (if any) will this feature solve?
Demo on 18th March: Write a ready to use docker-compose file which can used by the Bangladesh team to setup RC-2.0 for credential Issuance.
Describe the feature clearly.
Add a new feature that does ....

https://github.com/Sunbird-RC/bangladesh-sample-poc/pull/2


Add option to always activate "base" environment by default

Fixes #125

Note: this currently depends on the .condarc feature, to be able to read the auto_activate_base setting out of Conda's configuration.


[LMS-470] Rewrite Canvas Extractor to use GraphQL for Assignments

Adding the functionality to extract assignments with GraphQL

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@sgonzalezgap Thanks for making the changes. As discussed we will be adding additional tests (against the GraphQL Canvas API) in a future ticket.


NetworkException

I have been using this cool package for two months. There was recently an issue with the QuickStats website (a certificate problem) but it eventually got solved. Since this issue, this package throws a NetworkException. The traceback is long but this message comes up twice (as MaxRetryError and SSLError):
HTTPSConnectionPool(host='quickstats.nass.usda.gov', port=443): Max retries exceeded with url: /api/get_counts/?short_desc=WHEAT%2C+WINTER+-+PROGRESS%2C+MEASURED+IN+PCT+PLANTED&agg_level_desc=STATE&year=2020&key=ACF9C369-6644-3388-8B11-1AB901A18830 (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1108)')))
This seems indeed related to the recent certificate issue. The exception occurs upon running the query with q.count() or q.execute().

The issue lies with the QuickStats server. The SSL certificates are not properly passed.
requests.get() takes a verify argument that can be set to False. Creating a new class based on NassApi allows the code to keep running. This library shouldn't be touched.
import nass
class NassApiNoSSL(nass.NassApi):
    """Like nass.NassApi but doesn't check for SSL validity."""
    def _api_request(self, url, params, field_name):
        api_url = self.BASE_URL + url
        params.update({'key': self.key})
        try:
            resp = self.http.get(api_url, params=params, verify=False) #
        except requests.RequestException:
            raise exceptions.NetworkException()
        try:
            data = resp.json()
        except ValueError:
            raise exceptions.InvalidJson(resp)
        return self._handle_response_data(data, resp, field_name)


broken?

I created a fresh new create-react-app project and tried to create an Allotment but I don't see any separator and nothing is draggable. Node version 18 and 20, React v18.2.0

I also get a version conflict with the recently merged dependabot changes with rollup:
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/rollup
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/rollup-plugin-terser
npm ERR!   dev<EMAIL_ADDRESS>from the root project```

The following React app also has the following error:
import React from 'react';
import { Allotment, setSashSize } from 'allotment'

const App = () => {
  return (

      <Allotment vertical={true}>
        <Allotment.Pane maxSize={600}>

Lorem Ipsum

        </Allotment.Pane>
        <Allotment.Pane maxSize={400}>

Lorem Ipsum

        </Allotment.Pane>
      </Allotment>

  );
}

export default App;

ERROR
ResizeObserver loop completed with undelivered notifications.
handleError@http://localhost:3000/static/js/bundle.js:39217:58
./node_modules/webpack-dev-server/client/overlay.js/createOverlay/<@http://localhost:3000/static/js/bundle.js:39236:18

It seems like allotment's current behavior is to just render the panes vertically with no separator and no resizing capabilities; I am trying to inspect the source code and I think no CSS is being applied in my case... looking further into it.

I think you just forgot to the Usage section :)
You just need to import the css
import 'allotment/dist/style.css';

You are right... I am embarrassed. Sorry, and thanks!

@woodreamz it is still not working even when importing the CSS

Hi @mizlan. I've tried to reproduce the problem with:
Node 20.3.1
npm 9.6.7
create-react-app 5.0.1
allotment 1.19.0
react 18.2.0
but with no success. Just one small thing to check. Are you giving your container element a height? I only ask because if it has height 0 then it often looks like the Allotment component isn't working.
Also, thanks for pointing out the rollup dependency conflict. I'll see if I can resolve it.

I faced the same issue, however importing @import "allotment/dist/style.css"; fixed it.
I've tried to import it in:

App.less
App.tsx

It works in both situations.


Pi node-red->Adafruit LE not work

Hi nice job but i only can send data from the pi with node-red to my adafruit blue fruit feather! I don't know whats the problem! Thank you!
Regards Marc

Hi,
Thank you very much for testing.
Could you please let me know how you test with? If you have a code for Arduino, please share with me.
Thanks,
Shigeru

I used the example from adafruit for the feather. on the pi which bluez version do you use? How can i check it? sudo bluetoothd -v?  I will try your code! Regards

if i use you're code arduino says every sec disconnected!! But your node says connected and ready!

@MMMMarc
I just got an Adafruit Feather 32u4 Bluefruit LE and found that the board has been shipped with 0.6.0 installed (instead of the latest 0.7.0).

Could you please check yours with the Adafruit Bluefruit LE Connect app?


Support custom yieldable

Support custom yieldable, in order to extend the current list of supported yieldable: (function, promise, generator, array, object).
This may be very useful to extend the usage of co.

Are you joking? What is cocon?

In my opinion, @MichaelDiguet did not want to change repository's name, he only wanted to custom co . He changed his fork's name in order to use it in another project. So the three last commits should not be in this pull request.


Added prune xpath to spider

Hey @adbar,
This pull request adds the prune_xpath feature to the Spider function. As part of this update, I've removed the process_response to consolidate the pruning logic into a single function.
Please let me know if you have any feedback or suggestions!
Thanks.

Hey @adbar,
Thanks for the feedback—I understand how the parameters are set up now and have made the requested changes.
I noticed that the code below directly calls process_links instead of using the process_response function. How would you prefer we fix this? Should we move everything into probe_alternative_homepage, or would you rather replace process_links with process_response as a quick workaround? (process_response, receives a Response instead of htmlstring)
htmlstring, homepage, new_base_url = probe_alternative_homepage(url)
if htmlstring and homepage and new_base_url:
    # register potentially new homepage
    URL_STORE.add_urls([homepage])
    # extract links on homepage
    process_links(htmlstring, params, url=url)

Hi @felipehertzer, the tests don't pass for all versions, could you check if you can fix them?
What happened to the line URL_STORE.add_urls([response.url], visited=True) (in your first commit), maybe it was a good idea?
The code you mention is not an issue because probe_alternative_homepage() returns a string, or am I getting it wrong?

Hey @adbar,
The tests are currently pending a solution for the crawl_page function. Specifically, when initial is set to true, the process_response function does not execute. I have not found an optimal way to run it effectively when initial is either true or false, as the true condition returns an htmlstring, while the false condition returns a response

I'm not sure how to untangle that right now, if you have an idea feel free to test it.

@felipehertzer I think the best way would be to isolate this code in a function and/or to call it in process_links():
    if htmlstring and params.prune_xpath is not None:
        if isinstance(params.prune_xpath, str):
            params.prune_xpath = [params.prune_xpath]
        tree = load_html(htmlstring)
        tree = prune_unwanted_nodes(tree, [XPath(x) for x in params.prune_xpath])
        htmlstring = tostring(tree).decode()

Yes, you are right, it does make way more sense, I will change it

Alright, I just updated it.


Can't edit settings on the GUI

Hi Patrik,
Describe the bug
I've upgraded (installed from scratch) to the latest 1.8.0 version and although I've rewritten everything, I can't make it for the site to allow me to change or save any settings.
I've follow all the installation instructions:
curl -sL https://deb.nodesource.com/setup_12.x | sudo -E bash -
sudo apt-get install -y nodejs
cd ~
wget https://github.com/bpatrik/pigallery2/releases/download/1.8.0/pigallery2.zip
unzip pigallery2.zip -d pigallery #changed name of the output for my own naming convention
cd pigallery #used the new named folder
npm install

Run the creation of the config file:
npm start -- --config-only
Edited the config file with my own configurations (attached config.json)
Changed the permissions on the files explained in issue https://github.com/bpatrik/pigallery2/issues/98
start pigallery2 with elevated permissions (because I'm using port 81 and because of the explanation on issue https://github.com/bpatrik/pigallery2/issues/115)
sudo npm start
I can access the environment and login. However I cannot save any changes I make to the settings and I cannot even see its correct configurations.
However, if I change the settings directly on config.json file and restart the server, I can see the changes (like enabling or disabling the random link).
I even dropped the database from MySQL and recreated it (just in case) but with no effect (pigallery was able to recreate the tables which indicated to me it could connect to the database and I could create my user on the settings and see it appearing inside the MySQL database, on the pigallery.user_entity table).
As you can see on the attached printscreen

Even if I change a setting (like the "Images folder" in the print screen case), the "Save" button doesn't allow me to save it.
I can't also find the reindexing buttons we used to have at the bottom of the Settings and it doesn't show mw any "Faces" or "Duplicates" although I had some of both in the previous version.
Environment

OS: Linux 4.19.55-6-osmc #1 SMP PREEMPT Sun Nov 3 22:15:28 UTC 2019 armv7l GNU/Linux
Browser: Chrome and Internet Explorer
Hardware: Raspberry Pi 3B

Used app version:

release 1.8.0

If you need any additional information, just let me know.
Thanks,
Marco Angélico

Hi,
There might multiple issues:

it seems that your browser did not get the update. You can see the difference between your version and the heroku version: https://pigallery2.herokuapp.com/gallery/. (Most likely your browser cached the old version, force reaload could solve the issue)

this will most likely solve most of your issues

once you have the correct version. There is a chance that the config.json is not writable by the user that runs the app. Please doublecheck that.

after v1.8.0 docker (with docker-compose) is the officially recommended way of running the app. I'm also using it to run on a RPi 3B . That should be easier to set up and update later.

Hi Patrik,
I tried several ways of cleaning my browser's cache but always with the same result. So, suggestions 1 and 2 (config.json was writable by all users) didn't solve my problem.
I went for suggestion 3 and had a bunch of issues installing docker and deploying pigallery on it (mostly because I was not using the default ports and folders). I finally was able to have pigallery working on the docker and the problem with the editing of settings on the GUI has been overcome.
Now I'm facing some new bumps but if I cannot overcome them on my own I'll open new issues for them.
Thanks again for the help and for the fantastic tool!
Thanks,
Marco Angélico

I'm happy that it got solved.
Keep in mind that release and and ':latest'  docker vesrions of the app considered to be stable, while the '-nightly' might contain bugs.
Patrik


Torch is Not working , i followed the advanced example at it is ? react native: 0.55.4, react: 16.3.1

@dileepbolisetti you have to toggle torchmode to on via a user interaction. Torchmode should be initialized to off the toggle to on.

Can you give me an example of how to do this, I have set it using a state var but it still doesnt work on my honor P9 lite, the torch just doesnt work.  I also noticed the even with the type set to QR the camera still reads barcode, its almost as if its ignoring the props.


Move the main command to cmd/busl/

So we can do go get github.com/heroku/busl, and get both busltee and busl.

I made this yesterday but didn't commit it. Looks good to me.


Short solution needed: "Rust lang yield and generators" (rust)

Please help us write most modern and shortest code solution for this issue:
Rust lang yield and generators (technology: rust)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments explain solution.
Link to this issue in comments of pull request.

How to create a generator function in Rust?
How to use a generator map in Rust?
How to implement a generator trait in Rust?
How to create a generator iterator in Rust?
Generator example in Rust
How to use an async generator in Rust?
How to yield return in Rust?
How to use an async yield in Rust?
Yield generator in Rust
How to yield a thread in Rust?
Example of yield_now in Rust?
Yield example in Rust


raft: add read index for RawNode

Hi,
This PR adds read index(PR #5553) for RawNode, and test case.

I need to hold on this pr. We need to merge #6275 first.

#6275 is merged. The interface is changed. Can you change this pr accordingly?

@xiang90 Sure.

PTAL @xiang90

Let's squash the commits into one. Then it would be ready to merge.

@hhkbp2 Thanks a lot!


fix: updating code in class DmtxTime

fix: updating code in class DmtxTime to solver problem reading matrix code on raspberry
c_ulonglong -> c_ulong

Coverage remained the same at 96.422% when pulling 8d4b8360d63bd0fab148cebdb1cb234abb5d2c8f on fillipinascimento:master into a425ec36050500af4875bf94eda02feb26ea62ad on NaturalHistoryMuseum:master.


secure lua + module support

improvement of pr #6716
credits: @superpowers04 @cyn-8 @DragShot

removes only the abusable builtin functions
reimplements require for use of modules while blocking requiring luajit extensions like ffi

searches in mods/libs (and mods/modfolder/libs if the script runs from a modfolder)
because mod folders are dynamic, a script in mods/scripts cannot search for a module in a modfolder, and a script in mods/modfolder/scripts cannot search for a module in other modfolders

calling require will only work in global scope
Make sure the line set('require', false); has been removed from he constructor of FunkinLua. It is present atm and for this patch to work correctly it has to be removed.

calling require will only work in global scope

Make sure the line set('require', false); has been removed from he constructor of FunkinLua. It is present atm and for this patch to work correctly that line has to go.

okk ill do that now

Please can you keep the IO module? It is no removed actually and nobody have any problem with that I think.

Please can you keep the IO module? It is no removed actually and nobody have any problem with that I think.

i dont want to include io because it can easily write over existing files
and create/execute malicious ones
and do command line stuff
etc

Please can you keep the IO module? It is no removed actually and nobody have any problem with that I think.

i dont want to include io because it can easily write over existing files and create/execute malicious ones and do command line stuff etc

At least see if you can recreate a safe alternative of it?

might try my hand at breaking out of the sandbox later

At least, can you recreate a safe alternative of it?

We got a getTextFromFile() callback so far, so maybe a putTextIntoFile() one wouldn't do bad. As long as they keep the reach of file access inside the mod folders it should be OK, and they could be even easier to use than the io streams.

Yeah I forget that! This is a good idea!

legend

@cyn-8 Uhh... is this supposed to be here in FunkinLua.hx?
80.  root = splice_path(1) [[ .. 'libs/?.lua;' ]]
81.  path_script = root .. 'libs/?.lua;' .. root .. 'libs/?/init.lua;'

Because I think not.

@cyn-8 Uhh... is this supposed to be here in FunkinLua.hx?
80.  root = splice_path(1) [[ .. 'libs/?.lua;' ]]
81.  path_script = root .. 'libs/?.lua;' .. root .. 'libs/?/init.lua;'

Because I think not.

im not sure, really; it was part of the original code
ill try removing it and see if anything happens

Please can you keep the IO module? It is no removed actually and nobody have any problem with that I think.

i dont want to include io because it can easily write over existing files and create/execute malicious ones and do command line stuff etc

At least, can you recreate a safe alternative of it?

maybe in a separate pr i can make a haxe lua function thing for that

im not sure, really; it was part of the original code ill try removing it and see if anything happens

Hmm... it's probably a mistake on my end, because I do see it in my copy as well. I mean, 'libs/?.lua;' is being appended in line 81 so there's no point in doing it in line 80, it would end up being pasted twice. Please remove that part.

Uh... why?

That match() is needed to weed out the filename from the path. Without that, search inside data/mysong (or whenever the calling script is) will break, leaving only the lib folders.

this looks funkin nuts

Nice!

when is this gonna get approved, this pull request is just too powerful! it would be really useful to not copy-paste the same functions in different scripts

plus the fact that you could add custom libs

no need for module support as the new commits basically implement the same functionality
making a new pr for secure lua on its own


Fix Dashboard icons in high-contrast mode

Fixes #7325
Screenshots:
Before:

After:

Tested on:
OS: Windows 10 Normal & High-Contrast mode
Browsers:
Google Chrome - Version 94.0.4606.81 (Official Build) (64-bit)
Mozilla Firefox - Version 92.0.1 (64-bit)
Microsoft Edge - Version 94.0.992.50 (Official build) (64-bit)

P.S.: I checked out the failing CircleCI backend check and it is unrelated to this PR.

@SakshiUppoor thanks so much for taking the time to investigate and find a resolution for this, we really appreciate it.
This will be in the next release, I have pushed up some updates to the release notes and the commit message to your branch and will merge in now.
Thanks @Scotchester for reviewing.


Coordinates

Is there an option to get "lat" and "lon" parameters?

Hi @brascene
Location details passed into onPress prop callback has geometry.location information. See more https://developers.google.com/places/web-service/search#PlaceSearchResponses

@myaskevich Great, thank you very much :+1: