Add release script

What is the purpose of the change
A script to automate the release process.
Brief changelog
release.sh
Verifying this change
Still need to be improved and will verify during the next release.
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Great. We can make it better to better from next release.

If no one has suggestions at this moment, I will merge it to the 2.6.x branch. And we can improve it further during the next release.

Great. We can make it better to better from next release.

@diecui1202 I have created a thread discussing the next release (v2.6.4)  in the @dev mailing list, would you like to keep an eye for it, for example, list the patches we already have in 2.6.x, find the issues we must address in v2.6.4?


Update base string vars for localization

Clarification. This is for translating the user interface widgets into French, etc. This is done with these configs:
https://github.com/intrahealth/gofr/tree/master/gofr-gui/src/locales


Proxy: Dedicated DaemonSet for Envoy Proxy

Currently, whenever L7 capabilities are required, the Cilium L7 Proxy (Envoy) gets executed as separate process within the CIlium Agent k8s container.
This PR adds support for deploying Envoy independently as a separate K8s DaemonSet for availability, performance, and (potentially ) security benefits.
Potential Benefits

Restarting cilium-agent for upgrades does not impact live dataplane traffic (this is a property of cilium in general for the BPF datapath, but no longer applies once any Envoy-based forwarding is brought in).
Failures of cilium-agent to start that result in cilium pods in crashloop backoff do not impact dataplane traffic.
Performance isolation between Envoy and cilium-agent. An overloaded Envoy will not swamp the cilium-agent, or vice versa. Can also have separate CPU/mem limits.

Tasks

[x] Separate directory /var/run/cilium/envoy/sockets for Envoy proxy sockets (admin, xDS, accesslogger) -> will be shared via host between agent & Envoy
[x] Agent Configuration (external-envoy-proxy), whether envoy is deployed in DaemonSet or whether it should be started in embedded mode (defaults to false for the time being)
[x] Introduce CIlium Envoy DaemonSet in Cilium Helm Chart
[x] Using Image quay.io/cilium/cilium-envoy from https://github.com/cilium/proxy (which became an ubuntu runtime for a start)
[x] Bugtool: adapt changed admin api socket path when gathering Envoy Config during Cilium SysDump
[x] Add Metrics Listener as static resource when deploying Envoy  as DaemonSet
[x] Use /ready endpoint as health endpoint for Envoy Pods
[x] Envoy Version check via Admin Interface instead of checking via binary version output
[x] Configurable Envoy application log configuration (log path, log format, log level) -> Envoy Application Log will only be visible in CIlium Envoy container
[x] Temporary GitHub action based on Conformance Kind for testing Cilium connectivity tests against cilium with Envoy in DaemonSet (based on latest Cilium CLI to be able to use new helm mode)
[x] Add Envoy deployment mode to Cilium proxy status (CLI)

This PR tries to cover the relevant tasks to provide support for deploying Envoy in its own DaemonSet - without getting too big. The following tasks were out of scope.

Optimize runtime base image of Envoy (currently still builds on top of the same base image as the agent)
Reduction of the permission of the Agent DaemonSet deployment
Resource configuration for the Envoy DaemonSet deployment
Optimized behaviour if Envoy isn't deployed
proxylib integration (https://github.com/cilium/cilium/issues/25226)
OpenShift support (communication without unix sockets)
...

Please review the individual commits! They are more or less aligned with above tasks.
Installation
For the time being, the default will still be the "embedded" Envoy proxy. Therefore, Envoy as DaemonSet must be explicitly enabled via helm value envoy.enabled=true.

Helm: supported
Cilium CLI: out of the box supported via newly introduced "helm mode" (requires latest Cilium CLI from main branch).

:information_source: Adaptions (status, sysdump, install) in cilium/cilium-cli will follow soon (edit: https://github.com/cilium/cilium-cli/pull/1546)
Release Note
Support for deploying Cilium L7 Proxy (Envoy) independently as a separate DaemonSet for availability, performance, and security benefits.

rebased to master to resolve conflicts with nodeinit serviceaccount

Couple of comment as below, the rest looks good to me +1

thanks @sayboras
addressed your comments except for the proxylib part (need some more time & probably discussions for that next week)
please take another look :pray:

Changed documentation regarding newly introduced envoy health listener (9878) and changed helm value proxy.prometheus -> envoy.prometheus
I'm aware that this is the bare minimum.
More documentation definitely has to follow once we know how prominent we want to announce this new feature and whether it's the new default or not.

rebased to main to get kind cluster config fix

Tried to review, but this PR is just too massive. Would it be possible to split it up into multiple PRs? See e.g. Joe's series of PRs culminating in #24968, which makes the review much easier.
Left some comments inline as far as I got

@bimmlerd thanks for your review so far. i addressed your comments.
i do understand your input regarding the size of the PR. it's just that it's also important to see the whole context when reviewing the main parts - which already helped in detecting some issues in the history of this PR.
i tried as best to provide meaningful commits from the beginning - and also updating the PR feedback into these commits.
therefore, it's totally fine to concentrate on the changes within your review group.

conflicts in upgrade guide -> rebased to main without any changes

How do you envision rolling this out to an existing cluster without significant disruption? Neither helm nor DaemonSet updates are atomic, so rollouts for each randomize across nodes. That means there will be nodes with both embedded and standalone Envoy, as well as nodes with neither.
If the answer is "well, it's no worse than a normal upgrade", that's fine as long as we can handle both embedded and standalone while rollouts happen.
Additionally, are we prepared to handle version skew between Envoy and Cilium daemonsets now? Again, we will now have version skew in both directions on upgrade - sometimes cilium-agent will be newer, sometimes envoy.

How do you envision rolling this out to an existing cluster without significant disruption? Neither helm nor DaemonSet updates are atomic, so rollouts for each randomize across nodes. That means there will be nodes with both embedded and standalone Envoy, as well as nodes with neither.
If the answer is "well, it's no worse than a normal upgrade", that's fine as long as we can handle both embedded and standalone while rollouts happen.
Additionally, are we prepared to handle version skew between Envoy and Cilium daemonsets now? Again, we will now have version skew in both directions on upgrade - sometimes cilium-agent will be newer, sometimes envoy.

@squeed thanks for your review - i addressed your comments.
regarding the rollout: with this PR the default will still be the embedded variant. There are plans to rollout this feature only for new installations if somehow possible.
but we will definitely have a second look at the upgrade in detail before activating this feature by default - not only the initial one when changing the variant (embedded -> daemonset) but also the one when upgrading the version of the envoy daemonset itself.
This won't be the last PR in this area.

regarding the rollout: with this PR the default will still be the embedded variant. There are plans to rollout this feature only for new installations if somehow possible.

Helm doesn't have any reasonable way to do this :-(. There is the lookup chart function but this is extremely fragile and shouldn't be used. We can embed this in the install operator but otherwise there's no way to have this sort of "higher-kinded" logic in Helm.

but we will definitely have a second look at the upgrade in detail before activating this feature by default - not only the initial one when changing the variant (embedded -> daemonset) but also the one when upgrading the version of the envoy daemonset itself.

It would be good if we had at least a vague plan for how the rollout should work, so we don't paint ourselves in a corner.
My suggestion: When standalone-Envoy is enabled, label the cilium operator with something like io.cilium/standalone-proxy="". Then, configure the Envoy daemonSet with PodAffinity to only be run on nodes where the agent daemonset has been appropriately configured.

@squeed thanks for the idea! it looks like there are quite some options how we can tackle this - it might be even possible to run the embedded and daemonset-one in parallel for some time if we would use SO_REUSEPORT and have different [envoy-]node-ids for the two instances.
i agree that we should have a plan once we release this with 1.14. but for the sake of the scope and size of this PR we should keep the discussion (and definitely implementation) out of scope for this PR. we'll have a dedicated session (and follow up PRs) specifically on this topic anyway. cc @jrajahalme @sayboras @aanm

/test

/ci-external-workloads

/test

Upgrade tests failed with helm template issue when enabling preflight.
Error: INSTALLATION FAILED: YAML parse error on cilium/templates/cilium-configmap.yaml: error converting YAML to JSON: yaml: line 1: did not find expected key
-> fixed helm template issues which have been introduced while adding mutual auth to the cilium ConfigMap (preflight condition was no longer covering the whole ConfigMap).

Overall it looks, but I have one overriding concern that needs issue documentation:
Cross-pod communication via a UNIX domain socket will trip SELinux up and not work on platforms like Openshift. The preferred method for doing this is a service (which you can secure via mTLS if needed) with internalTrafficPolicy: Local set, which ensures that Envoy and Cilium will always communicate on the local node. See this PR as an example conversion.
It's fine that this PR doesn't do this, but we must document this limitation.
A follow on Documentation PR along with an issue to fix should be good.

@nathanjsweet thanks for the review and this important feedback including the pointer to the reference PR. will address this in a follow up!

With this feature, does the envoy DS need to run on every node in the cluster or can it be limited by NodeSelector?

Envoy DS needs to run on every node having a cilium agent for related l7 policy or visibility.


Check engineer's stock when adding task

Adding a task to an engineer's scheduled tasks needs to check their stock against partsNeeded. As partsNeeded might get updated after assignment, and there will be parts needed for already-scheduled tasks, this should be flexible enough to check all parts needed for already-scheduled tasks, but also take into account shipments that have been sent to the engineer's stock (the system will also need to support parts being sent directly to a customer).

Empty unit test method added in a628d36 ready for development.

Now complete.


Any period at the start of a line highlights as a scene heading

Fountain forces a scene heading with a single period followed by an alphanumeric character, but right now the package is highlighting any line that starts with a period as a scene heading. In my instance specifically, it's interpreting ellipses as a heading, when they should just be another action line.
Sample script:
EXT. QUARRY

Paul and Steve throw rocks at each other.

PAUL
Here's a fast one!

He throws a rock as hard as he can...

...but misses by a mile.

STEVE
Missed me!

Hope this one isn't as annoying to fix as my other issue.

The latest commit to master should only create scene headings for a single leading period now. Can you pull the latest and run in development mode to see if that handles it before I push a new patch? If you can mess around and see if there are any other funny cases for scene headings, I'd really appreciate it since we don't have great test coverage on the syntax grammar.

Yeah, it seems like that fixed it. I played around a bit but can't think of a lot of other scenarios that sort of thing might come up; it seems good to me.

Ok. Published in 0.8.3.


Add support for generic types with varying type arguments

In order to generate something like the following:
{
  "$schema" : "http://json-schema.org/draft-04/schema#",
  "title" : "Generic Class Container",
  "type" : "object",
  "additionalProperties" : false,
  "properties" : {
    "child1" : {
      "$ref" : "#/definitions/GenericClass[String]"
    },
    "child2" : {
      "$ref" : "#/definitions/GenericClass[BoringClass]"
    },
    "child3" : {
      "$ref" : "#/definitions/GenericClassTwo[String,GenericClass[BoringClass]]"
    }
  },
  "definitions" : {
    "GenericClass[String]" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "data" : {
          "type" : "string"
        }
      }
    },
    "GenericClass[BoringClass]" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "data" : {
          "$ref" : "#/definitions/BoringClass"
        }
      }
    },
    "BoringClass" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "data" : {
          "type" : "integer"
        }
      },
      "required" : [ "data" ]
    },
    "GenericClassTwo[String,GenericClass[BoringClass]]" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "data1" : {
          "type" : "string"
        },
        "data2" : {
          "$ref" : "#/definitions/GenericClass[BoringClass]"
        }
      }
    }
  }
}

from
public class GenericClassContainer {
    public GenericClass<String> child1 = new GenericClass<>("asdf");
    public GenericClass<BoringClass> child2 = new GenericClass<>(new BoringClass(1337));
    public GenericClassTwo<String, GenericClass<BoringClass>> child3 =
            new GenericClassTwo<>("qqq", new GenericClass<>(new BoringClass(1337)));

    @Override
    public boolean equals(Object o) {
        if (this == o) return true;
        if (o == null || getClass() != o.getClass()) return false;
        GenericClassContainer that = (GenericClassContainer) o;
        return Objects.equals(child1, that.child1) &&
                Objects.equals(child2, that.child2) &&
                Objects.equals(child3, that.child3);
    }

    @Override
    public int hashCode() {
        return Objects.hash(child1, child2, child3);
    }
}

Just for more context: the example I posted (that is also in the tests) generates a wrong schema in current master and thus fails validation:
{
  "$schema" : "http://json-schema.org/draft-04/schema#",
  "title" : "Generic Class Container",
  "type" : "object",
  "additionalProperties" : false,
  "properties" : {
    "child1" : {
      "$ref" : "#/definitions/GenericClass"
    },
    "child2" : {
      "$ref" : "#/definitions/GenericClass"
    },
    "child3" : {
      "$ref" : "#/definitions/GenericClassTwo"
    }
  },
  "definitions" : {
    "GenericClass" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "data" : {
          "type" : "string"
        }
      }
    },
    "GenericClassTwo" : {
      "type" : "object",
      "additionalProperties" : false,
      "properties" : {
        "data1" : {
          "type" : "string"
        },
        "data2" : {
          "$ref" : "#/definitions/GenericClass"
        }
      }
    }
  }
}

thanks a lot... manually merged.

From the examples, the URI's generated for id and $ref (like "#/definitions/GenericClass[BoringClass]") that contain square brackets are invalid.
You could replace them with normal round parenthesis "(" and ")" because those are valid.
If you leave square brackets in the URI's, then the schema's can't be used with validators that stick to the standards.

Long explanation:
According to the JSON schema draft 04, "id" and "$ref" should contains valid URI's. And valid URI's are not allowed to contain square brackets; square brackets must be url-encoded.
The "fragment" section of a URI (the part behind "#") must only contain a "pchar", a slash or a question mark: (RFC3986)
fragment    = *( pchar / "/" / "?" )
From appendix A of RFC3986:
pchar         = unreserved / pct-encoded / sub-delims / ":" / "@"
pct-encoded   = "%" HEXDIG HEXDIG
unreserved    = ALPHA / DIGIT / "-" / "." / "_" / "~"
sub-delims    = "!" / "$" / "&" / "'" / "(" / ")"
/ "*" / "+" / "," / ";" / "="
So the only allowed characters in the fragment are:

alphabetic
numeric
"-"  "."  "_"  "~"  "%"   "!"  "$"  "&"  "'"  "("  ")"  "*"  "+"  ","  ";"  "=" "?" "/"

https://tools.ietf.org/html/rfc3986#section-3.5
https://tools.ietf.org/html/rfc3986#appendix-A
https://stackoverflow.com/questions/40568/are-square-brackets-permitted-in-urls


Redshift JDBC 4.2 not supported?

What version of Flyway are you using?
4.2.0
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command-line
What database are you using (type & version)?
Redshift JDBC 4.2
What operating system are you using?
Mac OS 10.11.6
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
I tried running the following command: flyway migrate with the username, password, and url defined in flyway.conf.
What did you expect to see?
I expected it to succeed and output:
Creating Metadata table: "PUBLIC"."schema_version"
Current version of schema "PUBLIC": << Empty Schema >>
Migrating schema "PUBLIC" to version 1 - Create person table
Successfully applied 1 migration to schema "PUBLIC" (execution time 00:00.062s).

What did you see instead?
After running the above mentioned command, I get the following error: ERROR: Unable to instantiate JDBC driver: com.amazon.redshift.jdbc42.Driver : com.amazon.redshift.jdbc42.Driver.
Other notes
I downloaded the Redshift JDBC driver from here, and moved the 4.2 driver into the drivers directory. After digging around, I'm seeing that only 4.1 is currently supported. Are there any plans on supporting 4.2 in the near future? Or is this already supported and I'm just not configuring Flyway properly?

What is the output if you add -X?

This has now been implemented.


moving "Qiskit Terra" README to "Qiskit" README

Adapting README to the new Qiskit==qiskit-terra era.

#10530 does this

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
17 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.003%) to 87.237%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/expr.rs
1
93.76%

crates/qasm2/src/lex.rs
4
90.63%

crates/qasm2/src/parse.rs
12
96.67%

Totals

Change from base Build<PHONE_NUMBER>:
-0.003%

Covered Lines:
74238

Relevant Lines:
85099

💛  - Coveralls

oops! good catch. Closing this in favor of https://github.com/mtreinish/qiskit-core/pull/19


Add nullability to objective-c service header files to improve swift calling

In Swift, Apple is using a type Optional that is very relevant to the language since it brings nullability while all other types can not be nil. In Objective-C every type can be nil and is therefore imported as an implicitly unwrapped optional which is very insecure to use since the program crashes on use it it's nil.
In the generated header files of a service there are no nullability flags which can help to bridge better to Swift. I added the needed implementation in a pull request, it would be great if someone could review and merge it. (https://github.com/grpc/grpc/pull/6163)
Thanks for your awesome work!

Pull request merged - thanks!


MS Graph API does not help when you need to access Azure resources

All documentation insist that you use the MS Graph API instead of the Azure AD Graph API. However, the tokens retrieved via MS Graph API do not seem to work with Azure REST API (eg: to list Azure Subscriptions, read Azure resources, etc). Calls return empty data as if there are no such resources on Azure.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ac43307-75d4-cb6f-e561-0dd9008f28c6
Version Independent ID: 8fc47e76-5ee1-6aeb-73e2-c64c44e3e4ed
Content: Azure Active Directory v2.0 scopes, permissions, and consent
Content Source: articles/active-directory/develop/v2-permissions-and-consent.md
Service: active-directory
GitHub Login: @CelesteDG
Microsoft Alias: celested

@sujayvsarma Thank you for your query . We will investigate and update the thread.

@sujayvsarma Can you share the details of the Graph call you are using ?

Repro steps:

Create a Console/Web app using MSAL.net SDK.
Attempt to sign in with a Microsoft Account that has a valid Azure Subscription.
Use the access token obtained via #2 above to execute the GET /subscriptions request).

Expected:
The result of the #3 call would be a Json list of subscription items for the user -- as returned on the "Try it" page linked in #3 above.
Actual result:
The result is EMPTY. As if there are no such subscriptions.
This is the same behaviour for all Azure resource queries using an access token retrieved via MSAL. The SAME queries work fine for access tokens retrieved via ADAL methods.

@sujayvsarma If I am understanding this correctly , then for the same MSA account it's working if you are using the token obtained using ADAL and it's not working if you are using the token obtained using MSAL endpoint .
Can you share the REST call you are making to the token endpoint in your web app ? (both MSAL/ADAL)
Also can you compare the tokens in https://jwt.ms and check the aud parameter in the two scenarios ?

@sujayvsarma I am following up to get an update regarding this.

The tokens looked comparable. But when the ADAL token was used against the AzureRM endpoint (https://management.azure.com/subscriptions?api-version=2019-03-01 for example), it returned a valid answer. When I use the MSAL one, it returns "{ value: [ ] }".

@sujayvsarma What is the value you are passing in the  resource parameter in ADAL and MSAL token requests?

Always "https://management.core.windows.net/". I have also tried with "https://management.azure.com/" -- gives me exactly the same results as the "core" URL.

While this issue definitely needs to be resolved, given that Microsoft is recommending everywhere that MSAL is the way forward, I have since abandoned this approach (I have run out of "POC-time" in the project) and gone in a different direction for my authorization needs. Therefore, I can no longer provide you with code snippets, screenshots, etc.  If this information means that you leave the issue unresolved but close this issue to meet your SLA and active tickets metrics, then that is your wish.

@sujayvsarma I understand. I do not intend to close this issue as long as you are engaged and have questions regarding this. Let's work together to see if this is actually a flaw in MSAL.
Ideally MSAL is used to communicate to the V2 endpoint and V2 endpoint accepts scopes instead of resource parameter. We should be sending  "https://management.core.windows.net/.default" as the scope parameter.
I understand you will not be able to reproduce the issue, so please provide the following details, so that I can reproduce the issue at my end.

Which endpoint were you sending the request to in your MSAL application ? (v1 or v2 )
Which flow of authentication were you using ? (client credential,  authorization code with web app /console)
It would be great if you can share the sample or the doc you followed to build your console app.
Ideally in ARM API calls, null value is returned even in scenarios where the user/service principal does not have enough permissions to retrieve the resource information. Can you please reconfirm that you are using the same account in ADAL and MSAL scenario ? Also confirm that the account used in MSAL scenario has contributor/owner role assigned ?

Thank you @ManojReddy-MSFT.
Replies to your questions:

I don't control that. I am simply using the MSAL SDK from NuGet, with values set up from the "Endpoints" pane of Azure AD. I have tried appending "v2" in various ways ("oauth2/v2", "/v2" etc) but the SDK does not seem to like it.

2 & 3. I don't have the link anymore, but here is what I was doing:

I was using my own account - I am the subscription owner and am listed as Global Administrator on it.

@sujayvsarma I believe you gave us the code from your  ADAL app. The method you called is from  the NUGet package "Microsoft.IdentityModel.Clients.ActiveDirectory".
I am assuming the token obtained using the above method worked for you in ADAL when you are hitting the V1 endpoint.
For  MSAL you have to sue something like this
AuthorizationCodeReceived = async (context) => {     var code = context.Code;     string signedInUserID = context.AuthenticationTicket.Identity.FindFirst(ClaimTypes.NameIdentifier).Value;     TokenCache userTokenCache = new MSALSessionCache(signedInUserID,         context.OwinContext.Environment["System.Web.HttpContextBase"] as HttpContextBase).GetMsalCacheInstance();     ConfidentialClientApplication cca =         new ConfidentialClientApplication(clientId, redirectUri, new ClientCredential(appKey), userTokenCache,null);     string[] scopes = { "Mail.Read" };     try     {         AuthenticationResult result = await cca.AcquireTokenByAuthorizationCodeAsync(code, scopes);     }
Please check this [sample
](https://github.com/Azure-Samples/active-directory-dotnet-webapp-openidconnect-v2) as this explains how to specifically target v2 endpoint and pass the scopes.
I was able to clone this sample and got it to work in my environment.

Hi @ManojReddy-MSFT,
I am not disputing that MSAL works for MS Graph API. It does. Quite well.
What I need is to be able to use the MSAL tokens with AzureRM API (https://management.azure.com). THAT is not what is working.

@sujayvsarma I understand. I was able to make the Get-Subscription using the Azure RM API by  modifying the scopes parameter provided in that sample.

What did you set scopes to?

@sujayvsarma  Scope : https://management.core.windows.net/.default

Thank you for being persistent and chasing this down. But like I said here (https://github.com/MicrosoftDocs/azure-docs/issues/26148#issuecomment-471425116), I have since gone in a different direction for now in that project. When I get some time, I will check to see if this works for me. I shall post back to this thread with my findings.
In the meantime, I am going to go ahead and close this issue.
Your help is much appreciated. 5*


Remove loading of bangers font by default in main boot class.

I was looking through the code of the Boot state, and saw that it was trying to load the bangers font family. (https://github.com/lean/phaser-es6-webpack/blob/master/src/states/Boot.js#L14). Lately, the font has been taking a while to download, causing this game to to freeze on the loading fonts page.
Since this is the starting template for a game to build using webpack and phaser, perhaps it could be ideal if we remove the default behavior of loading a font library?

thanks for the suggestion. Done
https://github.com/lean/phaser-es6-webpack/commit/5e01f3dbf5e75d685ee59b91b45b90ec17d5faeb

Thanks man!


Support templates other than MNI152NLin2009cAsym

Now that TemplateFlow is up and seemingly running okay, it is time to open up the --template option and allow additional template keywords.
This is related to poldracklab/smriprep#50 where the CLI interface will be reconsidered and where we will come up with a solution for people who want to run normalization to two or more templates.

cc @satra

more than other templates, i think i would want to extract individual space data. that being said, custom/other templates would likely be helpful to extend fmriprep to other workflows (e.g., infant mri)

Absolutely. I pinged you because now fsLR can be applied as the target and generating HCP-compliant CIfTIs will be much easier - at least for the volumetric part.

this describes the surface mappings. so if the templates are in place, creating the workflows is not that complicated.
https://wiki.humanconnectome.org/download/attachments/63078513/Resampling-FreeSurfer-HCP.pdf?version=1&modificationDate=1472225460934&api=v2&download=true

Necessary surfaces were already there (L, R).
Although discouraged (the recommendation is to align the individual's surfaces to fsLR's via MSM), the  files I included into the fsLR template are intented to implement route C of the document.
For the recommended way (or at least more accurate procedures involving surface native spaces), people should use ciftify (wdyt @edickie?).

Seems like the best plan for the time being. Sorry I haven't had time to contribute to this lately. I'm pretty swamped till May.

Wait aren't you doing route D in the doc?

if fsLR is the target, shouldn't we be going route B (individual to fsLR)?
obviously we will not be able to do single step interpolation, but at least in two steps going from bold to individual surface and then to fsLR

I'll be using the  fs_LR-deformed_to-fsaverage.?.sphere.???k_fs_LR.surf.gii files, just for convenience. Then, I'll concatenate all the inverse transforms from BOLD to fsaverage and map all coordinates from fsaverage to BOLD and sample via interpolation. Basically, I'll resample into fsaverage with just 1 step.


test downgrade cilium

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.81%. Comparing base (d861d7a) to head (13c6dbf).

:exclamation:  There is a different number of reports uploaded between BASE (d861d7a) and HEAD (13c6dbf). Click for more details.
HEAD has 2 uploads less than BASE

Flag
BASE (d861d7a)
HEAD (13c6dbf)

oats-test
1
0

integration-test
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1155       +/-   ##
===========================================
- Coverage   77.40%   53.81%   -23.59%
===========================================
  Files         136      136
  Lines       11293    11293
===========================================
- Hits         8741     6077     -2664
- Misses       2023     4812     +2789
+ Partials      529      404      -125

Flag
Coverage Δ

integration-test
?

oats-test
?

unittests
53.81% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


new

this new issue

i have released the source file for the student website which is used to deploy it in gcp with help of docker image. if you have idea for further development you can change it and let me know it.


New Tree based Structure for index metadata

What changes were proposed in this pull request?
The new Content structure, built on a recursive Directory structure will look like below:
Content(
    Directory(
        name: String,
        subDirs: Seq[Directory],
        files: Seq[FileInfo]

Here Content represents any data or index content, and holds the file contents (and maybe other info) about files. Directory semantically maps to a file system directory. It is composed of a directory name, a list of children subDirs Directory(s), and a list of children files. The name is the directory name (and not the whole directory path).
Content APIs:
files: Seq[Path]: returns list of leaf files as hadoop Paths representing the files logged in the Content object.
def fromDirectory(path: Path): Content: Creates a Content object from a given directory path. It contains all leaf files at the directory subtree rooted at path.
def fromLeafFiles(files: Seq[FileStatus]): Content: Creates a Content object from a list of leaf files.
Directory Apis:
def fromDirectory(path: Path): Directory: Creates a Directory object from a given directory path. It contains all leaf files at the directory subtree rooted at path.
def fromLeafFiles(files: Seq[FileStatus]): Directory: Creates a Directory object from a list of leaf files.
This is the output of the directory structure when we create a Content object by passing a directory path. Here's how the new structure looks:
Print the content object
Content(Directory(file:/C:/,List(),List(Directory(Users,List(),List(Directory(apdave,List(),List(Directory(repo2,List(),List(Directory(testdata,List(),List(Directory(sampleparquet,WrappedArray(FileInfo(part-00000-5782bdd3-4729-44e6-b54b-51b557f66792-c000.snappy.parquet,1473,1585280921507), FileInfo(part-00000-e8c8821f-a1b2-4b3b-be9e-687b6fa6d057-c000.snappy.parquet,1878,1585280853559)),List()))))))))))))

Print the json conversion of the object
{
  "root" : {
    "name" : "file:/C:/",
    "files" : [ ],
    "subDirs" : [ {
      "name" : "Users",
      "files" : [ ],
      "subDirs" : [ {
        "name" : "apdave",
        "files" : [ ],
        "subDirs" : [ {
          "name" : "repo2",
          "files" : [ ],
          "subDirs" : [ {
            "name" : "testdata",
            "files" : [ ],
            "subDirs" : [ {
              "name" : "sampleparquet",
              "files" : [ {
                "name" : "part-00000-5782bdd3-4729-44e6-b54b-51b557f66792-c000.snappy.parquet",
                "size" : 1473,
                "modifiedTime" :<PHONE_NUMBER>507
              }, {
                "name" : "part-00000-e8c8821f-a1b2-4b3b-be9e-687b6fa6d057-c000.snappy.parquet",
                "size" : 1878,
                "modifiedTime" :<PHONE_NUMBER>559
              } ],
              "subDirs" : [ ]
            } ]
          } ]
        } ]
      } ]
    } ]
  }
}

Convert back from json to content1 object. Note it's the same as the first one.
Content(Directory(file:/C:/,List(),List(Directory(Users,List(),List(Directory(apdave,List(),List(Directory(repo2,List(),List(Directory(testdata,List(),List(Directory(sampleparquet,List(FileInfo(part-00000-5782bdd3-4729-44e6-b54b-51b557f66792-c000.snappy.parquet,1473,1585280921507), FileInfo(part-00000-e8c8821f-a1b2-4b3b-be9e-687b6fa6d057-c000.snappy.parquet,1878,1585280853559)),List()))))))))))))

Asserting the return object is same as the original
true
List leaf files using content.files api
file:/C:/Users/apdave/repo2/testdata/sampleparquet/part-00000-5782bdd3-4729-44e6-b54b-51b557f66792-c000.snappy.parquet
file:/C:/Users/apdave/repo2/testdata/sampleparquet/part-00000-e8c8821f-a1b2-4b3b-be9e-687b6fa6d057-c000.snappy.parquet

Why are the changes needed?
Before this PR: the metadata content structure is limited in its expressiveness in case of partitioned folders. If there's multi-level hive-partitioning, it's further difficult to recognize where the root folder starts and where the partitioning starts.
Solution: To simplify this, we decided to keep a tree structure starting at the root of the file system, with every sub-directory a child to it's parent directory. Same for files. The files are still stored as FileInfo objects, maintaining their file name, size and last modified time.
Does this PR introduce any user-facing change?
Yes. This is a breaking change. Earlier, the file paths were complete paths themselves. Now file path is a combination of /root/dir1/dir2/.../file.parquet. Indexes created before v0.2.0 may not be readable.
Notes
Limitations:
Currently this PR doesn't support merging of Content objects. So there is some duplication there. For example, Content objects from /a/b/c and /a/b/d can be theoretically merged into a content object which looks like
root = {
  name: "a",
  subDirs: [{
    name: "b",
    subDirs: [
      {
        name: "c",
        subDirs: [],
        files: []
      },
      {
        name: "d",
        subDirs: [],
        files: []
      }],
    files: []
    }],
  files: []
}

but this merge support will be added as needed in the future. This will not affect the correctness of the code in any way.
How was this patch tested?
unit tests

but this merge support will be added as needed in the future. This will not affect the correctness of the code in any way.

Can we handle the limitation in this change or follow up PR?  It sounds like not tree, but just list of sub directories.

BTW it would be good to provide some statistics of index based on this new metadata like total size of index, size of each index version, modification times and so on. (Also good to show appended/deleted files and sizes for invalidated indexes)

@apoorvedave1 In the PR description, can you describe the actual data structure and the what operations on this are supported vs. not? Currently, you provide an example output but I think it'll be useful to provide some information on the internals of this PR (for instance, once you add this description, it is easy to understand that merge is not supported etc.).

Why are the changes needed?
Current structure is limited in its expressiveness in case of partitioned folders. If there's multi-level hive-partitioning, it's further difficult to recognize where the root folder starts and where the partitioning starts. To simplify this, we decided to keep a tree structure starting at the root of the file system, with every sub-directory a child to it's parent directory. Same for files. The files are still stored as FileInfo objects, maintaining their file name, size and last modified time.

Can you provide documentation on what these limitations are? If you opened an issue to capture these limitations, just link to that one.

LGTM thanks @apoorvedave1

BTW it would be good to provide some statistics of index based on this new metadata like total size of index, size of each index version, modification times and so on. (Also good to show appended/deleted files and sizes for invalidated indexes)

Thanks @sezruby , that's a good suggestion. Could you please open up an issue with these details and more clarity? We can come back to it as required.

Why are the changes needed?
Current structure is limited in its expressiveness in case of partitioned folders. If there's multi-level hive-partitioning, it's further difficult to recognize where the root folder starts and where the partitioning starts. To simplify this, we decided to keep a tree structure starting at the root of the file system, with every sub-directory a child to it's parent directory. Same for files. The files are still stored as FileInfo objects, maintaining their file name, size and last modified time.

Can you provide documentation on what these limitations are? If you opened an issue to capture these limitations, just link to that one.

I think I phrased it incorrectly here. By "Current structure is limited" I meant the master branch is limited because it lacks the tree structure as of today. This PR will fix these limitations by bringing in the tree based structure. I will fix the description

@apoorvedave1 In the PR description, can you describe the actual data structure and the what operations on this are supported vs. not? Currently, you provide an example output but I think it'll be useful to provide some information on the internals of this PR (for instance, once you add this description, it is easy to understand that merge is not supported etc.).

Thanks @rapoth , I have added a "Notes" section which highlights the limitations. It has the merge limitation mentioned in detail along with other info. Thanks.

but this merge support will be added as needed in the future. This will not affect the correctness of the code in any way.

Can we handle the limitation in this change or follow up PR? It sounds like a list of sub directories rather than tree and it'll be shown in each index log file. I think it's possible with top-down approach in fromLeafFiles by grouping top dir name of paths instead of getParent.

thanks @sezruby , Let's take it in the next PR if it is an absolute requirement. As of now, I think it's not necessary since this change is not a blocker so I will not be handling it in this PR. Thanks for bringing it up.

@sezruby @pirz Can you take a look one more time since there have been quite a bit of changes since you last reviewed?

LGTM, Thank you @apoorvedave1

LGTM, thanks for the work!
nit: remove the limitation part of the pr description.


Postgrest.Exceptions.PostgrestException: {"code":"42883","details":null,"hint":"No operator matches the given name and argument types. You might need to add explicit type casts.","message":"operator does not exist: text @> unknown"} Dotnet Supabase

Bug report
"code":"42883"
Describe the bug
I am trying to use this command in my project :
await _SupabaseClient
.From()
.Select("id,name,price,desc,brand_id:Brands(id,name),subcategory_id:Subcategories(id,name,category_id:Categories(id,name,gender)),Imgs(image),shop_id:users(id,fullname)")
.Filter(x=>x.brand_id.name.ToString(),Operator.Contains,new List {"Nike","Puma"}).Get();
When i try use have this is error:
Postgrest.Exceptions.PostgrestException: {"code":"42883","details":null,"hint":"No operator matches the given name and argument types. You might need to add explicit type casts.","message":"operator does not exist: text @> unknown"}
System information

OS: [ Windows]
Version of supabase-js: [e.g. 6.0.2]
Version of Dotnet : [7]

Hm. Seems like something is not being translated into the query correctly... it should be using the operators like specified here.
Off the top of my head, I wonder if ?tags=cs.{example, new} is being sent incorrectly as ?tags=cs.{"example", "new"}.
Could you try the In operator instead and see if that works?

Thanks to respond me, Yes i try use operator In and nothing is working.

I'm able to duplicate, but I'm not sure what the issue is with the CONTAINS operator. The request is being formed according to their documentation. I'm going to open an issue on the postgrest repo and see if they have an issue.
It looks like the functionality you're looking for is available using the IN operator though.
The following test case works (relative to the PostgrestTests part of the repo) as expected:
[TestMethod("filters: cs (list)")]
public async Task TestContainsFilterList()
{
    var client = new Client(BaseUrl);

    var filteredResponse = await client.Table<User>()
        .Filter(x => x.Username!, Operator.In, new List<string> { "dragarcia", "acupofjose" })
        .Get();

    filteredResponse.Models.ForEach(x => Assert.IsTrue(x.Username is "dragarcia" or "acupofjose"));
}

@joseadrianoemmanuel1999 the answer given the issue:

The contains operator @> does not work for text types. It's used for arrays, json(b) and others. Are you trying to query all the users with username that belong to a list of candidates? If so you can use like(any).

So please use the IN or LIKE operator!

It's worked but it's sad other command fails, But thanks for help


stuck

npm install --global windows-build-tools
It get stuck @ reify:resolve: timing reifyNode:node_
It has been 4 hours now.

Same here

I've been having the same issue for about a week now.

As have I, happened after upgrading into node 16.

Yep, its still fucked.

As a workaround, I was able to get gyp to install (on Windows) by uninstalling nvm (nvm-windows) and installing node 16.6 via the official NodeJS installer. During the installation process there in an option to install extra tooling (including gyp). That process went off without a hitch.


change name_prefix to be name prefix

The purpose of ASG-${local.name_prefix} is to build the prefix to have the finnal name like ASG-name_prefix_randomID
With your PR, this will be change to name_prefix_ASG_randomID which IMO is not fine.


Support adding tags

Have a question? Please checkout our Slack Community or visit our Slack Archive.

Describe the Feature
Resources created by this module have no tags.
Expected Behavior
Have the possibility to pass a set of tags to this module.
Use Case
Same use-case for having tags in general.
Describe Ideal Solution
Add a var.tags variable consistent with other modules. Add the tags to all taggavle resources in this module.
Alternatives Considered
/
Additional Context
/

@aairey this module does not create any resources

Right, looks like I will be adding it in the task definition as per the example here.


Update formatdef_prettier for Prettier 2.0

Prettier 2.0 deprecates the --stdin flag stating it was redundant and that it should simply be a warning with no change in exit code. Not sure if this plugin is watching for exit code or some other method to check for success, but after upgrading Prettier, formatting would not work until I removed the flag from formatdef_prettier!
I've note verified with a Prettier 1.0 project yet, but it sounds like it should be safe since that was the default mode it was operating in with or without the flag.

Thanks!


User can't tag the bot, only admin can able to tag in test Server.

In test server normal user can't able to tag the bot(bot isn't replying). where it does in Appbrewery Flutter server.

Made a fix on 8bc05de commit


Documents with lists may not be able to save on update

If a document has fields with lists, save may complain about being non-deterministic.  I've made some changes to the field manager that would keep track of dirty fields and then only update those, which should have the same effect but be atomic.  I'll make a pull request as soon as it's well tested.

From my knowledge, lists should work fine with remodel. Can you post an example about the issue you've encountered?
Also, I wanted to add dirty fields, but I felt it added too much overhead to the operations, making remodel slower. Since they didn't add that much value to remodel, I've decided not to implement them at that time.

I finally was able to investigate this fully.  Seems it's a geojson problem, not lists.
https://github.com/rethinkdb/rethinkdb/issues/3864


Difference with changing the gradient accumulation - ZeroEval and AlpacaEval 2

Hi,
I fine-tuned the LLaMA-3-8b-Instruct  on "llama3-ultrafeedback-armorm" in different gradient accumulation (other hyperparameters are the same with llama-3-8b-instruct-simpo-v2.yaml). For fine-tuning, I used 4 A100:80GB.
The results on Alpaca-Eval 2 (I used your config for evaluation):
Gradient Acc: 16 - Batch-Size-Per-Device: 2 - LC: 50.34 - WR: 47.4
Gradient Acc: 128 - Batch-Size-Per-Device: 2 - LC: 34.78 - WR: 31.99
Gradient Acc: 16 - Batch-Size-Per-Device: 4 - LC: 39.16 - WR: 44.97
The results on MMLU-Redux and GSM8k (ZeroEval):
Gradient Acc: 16 - Batch-Size-Per-Device: 2 - MMLU: 43.38 - GSM8k: 58
Gradient Acc: 128 - Batch-Size-Per-Device: 2 - MMLU: 62.38 - GSM8k: 79.68
Gradient Acc: 16 - Batch-Size-Per-Device: 4 -  MMLU: 62.1 - GSM8k: 78.85
The ability of the model to make a reason to find the correct answer will increase if we use a larger Gradient Acc. However, the performance of the model on AlpacaEval 2 will decrease. How can we conclude that SimPO is better than other methods?
I think AlpacaEval 2 just evaluates the style of the answer, which is not a good way to compare the two models.

Hi @sahsaeedi , thanks for using SimPO and reporting your results back to us! If I understand it correctly,
Gradient Acc: 16 - Batch-Size-Per-Device: 2 -> Total Batch Size: 128
Gradient Acc: 128 - Batch-Size-Per-Device: 2 -> Total Batch Size: 1024
Gradient Acc: 16 - Batch-Size-Per-Device: 4 -> Total Batch Size: 256
It seems that with a larger effective batch size, chat abilities are not as well trained. We've seen similar phenomenon.
In our experiments, to ensure a fair comparison, we maintain the same batch size across different methods. Ideally, we would perform a grid search for each method wrt different batch sizes, but preliminary results indicate that the trend remains consistent as long as we use the same SFT model for different algorithms.
You've observed that chat ability appears to be at odds with ZeroEval, which we've also openly discussed in our repo README. We’ve identified this issue specifically with Llama 3 instruct models, where they are prone to catastrophic forgetting. However, when using Gemma models, we find this problem is significantly reduced, and training with PO actually improves chat scores without compromising ZeroEval results. You can find more details in this section of the README. For further studying continued training with instruction tuned models, I'd suggest using gemma models.
In summary, I believe your findings highlight a combination of two factors:

Llama 3 instruct models are prone to catastrophic forgetting.
A large batch size is less effective in learning PO, which helps preserve MMLU and GSK performance from the original llama3 instruct model

I think AlpacaEval 2 just evaluates the style of the answer, which is not a good way to compare the two models.
Yes, and that's why we have done thorough evaluations with Arena-Hard and WildBench as well, which are two much more challenging benchmarks for evaluating chat abilities of models, and we find the trends of the two largely consistent with AlpacaEval 2.

Please let me know if this clears up any confusion!

Hi @xiamengzhou, Thanks for answering my concerns,
Your main improvement is on AlpcaEval 2. The difference between DPO and SimPO in MT-Bench is less than 0.1, and for Arena-Hard, it is less than 0.5%. Still, this question arises: Is SimPO the SOTA method or DPO?

@Sahsaeedi, thank you for your question.
We've tested various settings to ensure a fair comparison between DPO and SimPO. Here's what we've observed:

In scenarios where the base models are relatively weaker (e.g., Zephyr, Mistral Instruct, or even LLaMA settings), SimPO shows a significant advantage, as detailed in our v1 series of models in the preprint.
For settings with stronger base models (e.g., Gemma), SimPO remains competitive with DPO, even though it eliminates the reference model and demands considerably more computational resources.

Based on these observations, I am confident in stating that:

SimPO is at least as competitive as DPO across all the settings we've explored.
The effectiveness of methods may vary depending on the base model. For instance, the catastrophic forgetting issue of llama and the diminishing gap between methods as the base model strengthens illustrate this variability.

We should have conveyed this more clearly in our materials, such as the GitHub repository, preprint, and Twitter posts! Let me know if this answers your question, and I'm happy to have further discussions.

Hi @sahsaeedi
In addition to Mengzhou's answers above, I also wanted to mention the potential issues with the evaluation metrics of MT-Bench and Arena-Hard:

According to the LMSYS blog, MT-Bench scores often show very little differentiation between models (e.g., Llama3-70B's MT-Bench score is nearly identical to GPT-4's), with high variance. Because of this, we don't consider MT-Bench scores to be a reliable metric for ranking different models or methods. We included MT-Bench scores in our paper mainly because it is a widely used benchmark in prior studies, but we clearly stated that AlpacaEval2 and Arena-Hard scores are more reliable.
The Arena-Hard evaluation does not use length penalty mechanisms. However, as many studies have shown, win rate metrics are often biased toward longer responses. We observed that DPO models generally produce longer responses than SimPO models on Arena-Hard, yet SimPO consistently achieves a higher win rate. We believe that SimPO's ability to achieve higher win rates with shorter responses is a significant advantage.

Best,
Yu


New Better Discord crashes

I get pop-up with info that bd crashed discord and running vanilla. Old better discord still working without an issue.

yes i have had the same issue its to do with the amount of plugins or the plugins you have it needs to be fixed but a quick fix is if you cant even get into bd put all your plugins in a folder and drag them individually to find the issue one or just dont use any heavy plugins

This is not an issue with the installer but with BD itself

First, I tried without plugins and still crashes. Second, then give option to install old version of BD in this installer because the only way to have working BD is using old installer.

Issues regarding the client should be directed to the appropriate repo => https://github.com/rauenzi/BetterDiscordApp/.


[Amplitude] Page view and session tracking client side

Description
I was a bit unsatisfied with the current state of the Amplitude tracking, for a few reasons:

The groups tracking dimension was poorly done, the API / SDK was a bit hard to make sense of initaly.
We were not tracking any information that was not in our DB already, making Amplitude only a better UI for analytics.

This PR adds 2 things:

User session tracking on the front end.
Page view tracking for nearly all the logged in pages.

Clean workspace tracking to lookup a workspace activity (group dimension) is done in a separate PR.

Risk

Deploy Plan

PMRW


Tigera Operator helm deploy not updating CRDs

When upgrading from v3.21.3 to 3.24.1, the upgrade fails to update pods in the calico-system namespace. Upon further investigation it appears that the issue stems from the spec.kubernetesProvider attempting to use a value of RKE2 which is not present in the existing installations.operator.tigera.io CRD.

Current Behavior
CRDs are not updating during helm install/upgrade by design, and therefore any changes made to underlying CRDs will not be applied during an upgrade. Current solution is to manually run kubectl replace -f using the CRD from operator.tigera.io_installations_crd.yaml as the current operator-crds.yaml is not up-to-date.
Possible Solution
As helm intentionally does not upgrade CRDs as part of a helm install/upgrade, the operator should perform these upgrades directly. If that is not possible, an up-to-date operator-crds.yaml should be provided to allow updating the CRDs outside of the tigera-operator chart.
Steps to Reproduce (for bugs)

Install calico v3.21.3 from helm chart on an RKE2 cluster
Apply necessary changes for v.3.23+
Run helm install calico projectcalico/tigera-operator --version v3.24.2 --namespace tigera-operator
Monitor tigera-operator pod logs for errors
"Installation.operator.tigera.io \"default\" is invalid: spec.kubernetesProvider: Unsupported value: \"RKE2\": supported values: \"\", \"EKS\", \"GKE\", \"AKS\", \"OpenShift\", \"DockerEnterprise\""
Apply operator.tigera.io_installations_crd.yaml manually
Monitor tigera-operator pod logs and pods in calico-system to verify upgrade is completed

Context
While we have identified a workaround, would appreciate a long-term documented solution for future upgrades to continue allowing the use of helm while supporting required changes to CRDs.
Your Environment
kubernetes v1.22.9
calico v3.21.3/3.24.1
ubuntu 18.04/20.04
Rancher RKE2

Yep, I think we could do any of the following:

Configure the operator to update its own CRDs on upgrade (I believe this is already possible, but maybe not enabled in the helm install).
Add a new CRD yaml file as part of the upgrade.
Something else, perhaps?

My current preference is probably for the first option, although I think we'll need a values.yaml config option to disable that for users who don't want that behavior. Should be straightforward, and I'd be happy to review a PR to do this.
@tmjd might be able to comment more on the auto-CRD-upgrade capabilities since I believe he implemented that originally.

For anybody i need for the work around
wget https://raw.githubusercontent.com/projectcalico/calico/v3.24.5/manifests/ocp/operator.tigera.io_installations_crd.yaml
kubectl replace -f operator.tigera.io_installations_crd.yaml

What i also did was
wget https://raw.githubusercontent.com/projectcalico/calico/master/manifests/operator-crds.yaml
kubectl replace -f operator-crds.yaml

Add a new CRD yaml file as part of the upgrade.

An attempt to improve the helm upgrade docs here:
https://github.com/projectcalico/calico/pull/7127/files

@lwr20 IMHO that does not work and did not for me.

@EugenMayer IIUC the issue in this bug is that the operator-crds.yaml at that location isn't being updated (and should be).  Once this bug is fixed, those instructions should be correct, or have I missed something further?

@lwr20 i cannot tell if it was outdate, broken or anything else. It did not work, the instructions i posted in https://github.com/projectcalico/calico/issues/6880#issuecomment-1367963633 do work, since they use the current source code with the actual version relating to the helm chart.
But yes, if the only issue was it is outdated, and keeping it up to date can be automated, it is the easier way to do what i did above.

@EugenMayer IIUC the issue in this bug is that the operator-crds.yaml at that location isn't being updated (and should be). Once this bug is fixed, those instructions should be correct, or have I missed something further?

Once manifests/operator-crds.yaml is being updated reliably, I think we can start using that as a pre-upgrade task and replace. Thanks a lot.

This PR should fix the generation of the operator-crds.yaml manifest: https://github.com/projectcalico/calico/pull/7216

Latest instructions explain how to replace the CRDs on upgrade: https://docs.tigera.io/calico/latest/operations/upgrading/kubernetes-upgrade#all-other-upgrades


Ability to change mesh's texture?

I was looking for a way to change an SSObjectMesh's texture while the program is running. My attempt at it was:
myObjectMesh.textureMaterial = new SSTextureMaterial (myNewTexture);
However, this doesn't seem to do anything -- I'm guessing I'm misunderstanding how SimpleScene handles this, looking for any suggestions! Thanks.

What type of mesh is it?
If your object is loaded from wavefront OBJ/MTL files, then you need to
look at "SSMesh_wfOBJ". Because wavefront supports multiple textures in an
object, it doesn't use AbstractMesh.textureMaterial. Instead it has it's
own "material subsets", each with a mesh and texture. You'll have to find
the right one in the list (SSMesh_wfOBJ.geometrySubsets) and reassign it.

Thank you, this clears a lot of things up for me. I'm now able to swap new textures onto my existing mesh objects with the following code.
SSTexture myNewTexture = SSAssetManager.GetInstance<SSTextureWithAlpha>("./newtexture.png");

SSMesh_wfOBJ myInstance = SSAssetManager.GetInstance<SSMesh_wfOBJ>("./modelfile.obj");
myInstance.geometrySubsets[0].textureMaterial = new SSTextureMaterial(myNewTexture);

myMeshObject = new SSObjectMesh(myInstance);


Show keyboard buttons in hud when no gampad is detected

Hey @sdtv9507 👋
It looks like you deleted the changes in this PR. We are always happy to have contributions, but apologies if we can be slow to deal with pull requests.
Also, feel free pop into our discord and you can join in some of the design discussion that people are having: https://discord.gg/cxTBVCZ

Eh, sorry, its the First time i use github and im having some problems

Eh, sorry, its the First time i use github and im having some problems

No worries, just making sure. If you need help, feel free to reach out.


More sane IAM permissions

Description
Hi there,
We've come up with a more restrictive set of IAM permissions (instead of allowing global access to s3, IAM, ec2 and many others which is unacceptable in many environments)
The first is an apex general policy:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": [
                "acm:ListCertificates",
                "acm:DescribeCertificate",
                "iam:GetRole",
                "iam:PassRole",
                "lambda:AddPermission",
                "lambda:Create*",
                "lambda:Delete*",
                "lambda:Get*",
                "lambda:InvokeFunction",
                "lambda:List*",
                "lambda:RemovePermission",
                "lambda:Update*",
                "logs:Create*",
                "logs:Describe*",
                "logs:FilterLogEvents",
                "logs:Put*",
                "logs:Test*",
                "route53:ListHostedZonesByName"
            ],
            "Resource": "*"
        },
        {
            "Effect": "Allow",
            "Action": "apigateway:*",
            "Resource": "arn:aws:apigateway:*::/*"
        }
    ]
}

A TODO here is to lockdown the apigateway perms further but the risk to the account is significantly lower than global s3 and IAM and Route53 access
A secondary policy grants access to the specific function in question
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Action": "iam:PutRolePolicy",
            "Resource": "arn:aws:iam::<AWS ACCOUNT ID>:role/<FUNCTION_NAME>-function"
        },
        {
            "Effect": "Allow",
            "Action": [
                "iam:ListPolicies",
                "ssm:PutParameter",
                "ssm:DescribeParameters",
                "ssm:GetParametersByPath",
                "ssm:GetParameters",
                "ssm:GetParameter"
            ],
            "Resource": "*"
        },
        {
            "Effect": "Allow",
            "Action": [
                "cloudformation:Create*",
                "cloudformation:Delete*",
                "cloudformation:Describe*",
                "cloudformation:ExecuteChangeSet",
                "cloudformation:Update*"
            ],
            "Resource": "arn:aws:cloudformation:<REGION>:<AWS ACCOUNT ID>:stack/<FUNCTION NAME>/*"
        },
        {
            "Effect": "Allow",
            "Action": [
                "s3:ListBucket"
            ],
            "Resource": [
                "arn:aws:s3:::up-<AWS ACCOUNT ID>-<REGION>"
            ]
        },
        {
            "Effect": "Allow",
            "Action": [
                "s3:PutObject",
                "s3:GetObject",
                "s3:DeleteObject"
            ],
            "Resource": [
                "arn:aws:s3:::up-<AWS ACCOUNT ID>-<REGION>/*"
            ]
        }
    ]
}

A TODO here is to further lock down the perms on SSM and to restrict the S3 access to the specific function in question (just restricts to the up folder for now)

Thanks! Yeah I agree it needs to be more restrictive by default, I was leaving it a bit open for future-proofing but I think feature-wise things have settled down so it's probably worth spending the time on that now

I was just working on locking these down also, this is great, thanks!

Hey, I have an issue with permissions in a Pro version only:
> up version
0.7.7-pro

> up deploy staging -v
     ...
     1.436s  DEBU ensuring s3 bucket exists name=up-130059590533-us-east-1
     0s      DEBU event platform.function.update map[commit:0eb1f29 stage:staging region:us-east-1]
   ⠹ 0s      DEBU event platform.deploy.complete map[commit:0eb1f29 stage:staging region:us-east-1 duration:3.018784649s version:]
     0s      DEBU event platform.deploy.complete map[commit:0eb1f29 stage:staging region:us-east-1 duration:3.018784649s version:]
   ⠹ 0s      DEBU event deploy.complete map[commit:0eb1f29 stage:staging duration:6.058625395s]
     Error: deploying: us-east-1: creating s3 bucket: updating acceleration status: AccessDenied: Access Denied
	status code: 403, request id: 8F30EE6B1FF27097, host id: 8MY4udmWLM4ed+...

The up-130059590533-us-east-1 bucker already exists. Surprisingly, it works without any errors with:
> up version
0.7.7

As a work around to the above, we've added the following permissions (it looks like the code tries to create the bucket in all cases and then introspects the error message, but doesn't take into account access denied. This also adds permission for the transfer accelerator which is required to successfully upload the function through up.
{
            "Effect": "Allow",
            "Action": [
                "s3:CreateBucket",
                "s3:GetAccelerateConfiguration",
                "s3:PutAccelerateConfiguration"
            ],
            "Resource": [
                "arn:aws:s3:::up-<AWS ACCOUNT ID>-<REGION>"
            ]
        }

Ideally this would be changed to use the ListBucket perm to check for the existence of the bucket. Also I'm not sure why Transfer accelerator is needed in this use case?


Add TC006 rule for string literal types in typing.cast()

Closes #114.

Tried switching to ast-compat for backport of ast.unparse() required for Python < 3.9 instead of astunparse, but they both wrap expressions with extraneous parentheses. Will have to think what to do about this... 🤔

I found a replacement for both astunparse and ast-compat in astor which seems to produce similar output to ast.unparse().
While it's not ideal having a dependency for this, with Python 3.11 nearly out it'll only be affecting Python 3.8, one of four supported versions. The only other alternative is to vendor Tools/parser/unparse.py from the Python 3.8 source tree, but I haven't checked whether it produces the expected output.

Just a thought, but do you think it would be weird to simplify the error message for 3.8 and have it output the annotation value where there's built-in support for it?

I guess we could simplify the error message for 3.8 only if the additional dependency is a problem. At least astor doesn't have any sub-dependencies so at least it's not pulling in a large tree of stuff. I did try the version from the CPython 3.8 branch, but it has the same issues with parentheses everywhere that astunparse does, so it's likely what was used to create that package in the first place. Anyway, that's a little more info, but I'll defer to what you want to do. 🙂

I'll see if I can get a chance to test the PR on a larger code base today and look over it one more time, then I'm happy to accept this if we don't find anything needing a tweak :slightly_smiling_face:

I gave it a quick go over a large code base and it looked sensible at a quick glance, but would be good to have a second opinion!

Tested and looks good! Thanks @ngnpope 👏


Day/Night cycle

Add support for night.

Can I do that

Yes
On Sun, Feb 28, 2021, 20:26 Picoseconds<EMAIL_ADDRESS>wrote:

Can I do that
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PrismarineJS/prismarine-web-client/issues/8#issuecomment-787507683,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR437UGW26JOLWVI77UPADTBKKFDANCNFSM4YKPCGMQ
.

I'll never do that

already open at https://github.com/PrismarineJS/prismarine-viewer/issues/94


Does not scrape anything for me

I'm a new Jellyfin user and set up my server with the Jellyfin ThePornDB plugin.
Installed without problems, added a token but when scraping any movies I do not get any results...
Jellyfin v10.8.10 (Docker)
Plugin: v<IP_ADDRESS>
Any help is appreciated

Finally got to a point it's scraping scenes but not full lenghts movies.
I only have full lenghts movies so the info scraped is not correct.

Use dev build

Use dev build

Awesome! Working now.
Many thanks!


boards: nrf52_adafruit_feather: remove RTS/CTS pin definitions from dts

The Adafruit Feather nRF52 does not have any RTS/CTS signal
connections between the nRF52832 and the on-board CP2104 USB/UART
bridge. Pins 5 and 7 are regular GPIOs.
Signed-off-by: Henrik Brix Andersen<EMAIL_ADDRESS>

Codecov Report

Merging #10795 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10795   +/-   ##
=======================================
  Coverage   53.24%   53.24%
=======================================
  Files         215      215
  Lines       25820    25820
  Branches     5692     5692
=======================================
  Hits        13748    13748
  Misses       9756     9756
  Partials     2316     2316

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53db000...0b6438a. Read the comment docs.


Question on StackOverflow: Why both @com_google_protobuf_cc and @com_google_protobuf?

https://stackoverflow.com/questions/44494304/why-both-com-google-protobuf-cc-and-com-google-protobuf

Also mentioned in #4


USMemorialDay defined incorrectly.

Memorial day is incorrectly defined.
>>> from pandas.tseries.holiday import AbstractHolidayCalendar, USMemorialDay
>>> class MemorialDayCalendar(AbstractHolidayCalendar): rules=[USMemorialDay]
>>> MemorialDayCalendar().holidays('2021','2022')
<class 'pandas.tseries.index.DatetimeIndex'>
[2021-05-24]
Length: 1, Freq: None, Timezone: None

The actual date of Memorial day in 2021 is 5/31.
Memorial day should be defined as:
Holiday('Memorial Day'    , month=5 , day=25, offset=DateOffset(weekday=MO(1)))

One would think the test spanning 10 years was enough.  I agree that this is right...care to do a Pull Request?

OK, I made a pull request.

closed by #10282


[FEATURE] Angular 18 support

Description
Any plan to support Angular 18 ?
Thank for this project !
Proposed solution
Migrate to Angular 18
Alternatives considered
No response

🎉 Released in<EMAIL_ADDRESS>📦🚀


chore: bump go version to 1,18

Just a simple update to the latest go

Codecov Report

Merging #816 (0384e9e) into main (a2dbbbe) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   53.30%   53.22%   -0.08%
==========================================
  Files         119      119
  Lines        6833     6833
==========================================
- Hits         3642     3637       -5
- Misses       2821     2825       +4
- Partials      370      371       +1

Impacted Files
Coverage Δ

das/daser.go
73.68% <0.00%> (-2.64%)
:arrow_down:

ipld/retriever.go
83.45% <0.00%> (-0.72%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2dbbbe...0384e9e. Read the comment docs.


🚀 [Wrangler] Feature Request: Flag to seed local KV / D1 for new projects from existing KV / D1 stores

Describe the solution
It would be really helpful to have wrangler commands/flags to allow for easier seeding of a new local project's KV and D1 data from an existing KV or D1 data store.
Use Case:
I have an existing CF Worker that runs on a schedule and writes to D1 and KV storage.
I would like to create a new Pages or Worker project that can utilize the KV values or D1 data.
To get this working locally, I need to write a script to pull all KV values from a namespace and then write them to the local KV storage or download a D1 backup and import it locally.  While totally possible, it can be pretty confusing when getting started to figure out how to do this.  Having a wrangler command or flag that could read from the remote stores and then write them to the local filesystem would be exceedingly useful.

Thanks for submitting this @code-poel. I can see this as a very useful command. I'm wondering how would you envision it as a flag?

Use of "flag" was the wrong choice.
Something like:
wrangler d1 import <source_database_id> <local_binding>
✅ Successfully imported DB '<database_name_from_source>'
[[d1_databases]]
binding = "DB"
database_name = "<database_name_from_source>"
database_id = "<source_database_id>"

Thanks for submitting this @code-poel. I can see this as a very useful command. I'm wondering how would you envision it as a flag?

@code-poel I think this functionality may exist now in Wrangler. Would this command do what you're looking for?
wrangler d1 migrations apply your-database --local
Based on the docs, this should setup your local DB using data from the existing your-database.
cc: @elithrar

It looks like this is existing functionality in Wrangler, so I'm going to close this for now. If the existing commands don't fully cover your use-case feel free to comment and we can re-open

Seems like there's been a bit of confusion here. Seeding and migrations are two different things.
Can this please be reopened?


Allow disabling ProGuard shrinking completely

Currently the only available ProGuard levels are all, platform and app. It would be nice to have a none level so people don't need to worry about potential bugs that could be introduced by ProGuard.
All what this none level does is simply adding an -dontshrink option to the app level config and then ProGuard should not remove any classes/methods anymore.
We cannot completely bypass the ProGuard though because we need it to backport Java 8 APIs (#154).

moe.proguard.minifyEnabled and moe.proguard.obfuscationEnabled options are added.
minifyEnabled is true  and obfuscationEnabled is false by default (which is the current behavior).
This can be configured globally:
moe {
    xcode.project 'xcode/ios.xcodeproj'
    xcode.mainTarget 'ios'
    xcode.testTarget 'ios-Test'

    proguard {
        minifyEnabled true
        obfuscationEnabled true
    }
}

or configured per-mode basis (e.g., only enable minification in release build, similar to what Android plugin allows us to do):
moeMainReleaseProGuard {
        minifyEnabled true
        obfuscationEnabled true
}


Add Amazon EKS documentation

Fix #302

First of all, thanks for your first contribution @ruzickap: absolutely appreciated and glad to see Capsule working also on EKS! 🙌🏻
@bsctl i was thinking we could create a new section (aka a new folder like use_cases named managed_kubernetes or cloud_installations) in the docs regarding installation on managed Kubernetes services: WDYT?

I put it to docs/operator/managed-kubernetes - let me know if it is a good place (or if you prefer different directory).

Fixed...


Preventing navigation?

How do I prevent user from navigating away from current page? Say, if he hasn't saved the form, and we'd like to display a dialog, is there a way to do that?

using push,  you could put navigation logic into an action that dispatches to a new route only when user has met page requirements. eg.
export function navigateCheck(data) {
  return (dispatch) => {
    if (data.meets.condition) {
       // navigate
       dispatch(push('/about'))
    } else {
       // throw error
       dispatch({ type: DIDNT_FILL_FORM })
    }
  }
}

@justrossthings Unfortunately you'd have to do that for every single navigation element on the page, many of which might come from other components which have no knowledge of the one which contains the form.
I think something deeper is required.

@dpwrussell exactly the reason and why I wouldn't want to do that. For now I abandoned redux-little-router for our project and went with router5 (great api), where preventing navigation is really good. (You can pass in promises, that'd mean you can display your own dialog and ask for confirmation) :)

(Looking at the Router5 API for this): Would a helper function on the component, which could be checked by <Link> elements to enable/disable navigation be the ideal solution?

I'm no expert on this, but what if the link doesn't trigger a route change? say we're trying to trigger on a button click After doing something (say after checking permissions), in that case, we're directly dispatching the action.
IMO, the way router5 is done is very different, it treats everything as side effect, when route changes, THEN it changes the URL using plugin, so it's really easy for router5 to do the preventing navigation (with promise as well), since it doesn't really do a redirect, it changes the redux store, before doing that, it checks if there's any handler, if handler says we can't, then it doesn't do the change of store, hence no change of url.
But (not sure if I'm correct), in case of redux-little-router, we make the change of URL, then we listen to the pop event, then we do the routing correctly? in this case, we'd have to check if there's a handler for canDeactivate (or something similar just before doing the redirect), then not actually do the redirect instantly.
I'd suggest: have a router instance which has a hooks object like so: {url: '/path/', canActivate: null} (components would pass their handler), before doing a dispatch, check if '/path' has a handler, then act accordingly, but not changing the URL immediately. Of course, everything needs to be with dispatchers, a Link component shouldn't directly provide a <a> element without using dispatcher of course.
Again, I'm no expert on this, so maybe there's a better way of doing this.

I am also not an expert on this, but I need this functionality and the best I could do was some middleware.
// Middleware to prevent route actions without confirmation when editing
export const routePrevent = store => next => action => {
  switch(action.type) {
    case PUSH:
    case REPLACE:
    case GO:
    case GO_BACK:
    case GO_FORWARD:
      if (isEditing(store.getState()) && !isNavconfirm(store.getState())) {
        store.dispatch(navConfirm(action.payload, action.type));
        return null;
      }
      break;
  }

  return next(action);
};

I then later do this "action replay":
dispatch({ type, payload });

Beware that right now this can cause issues because of #196.
Also note that it has serious limitations in that it does not intercept browser back/forward because these go directly to the history.
Ultimately, I think RLR will have to integrate with history.js more closely which is how I suspect that router5 does this, although I have not looked into it as yet, but definitely will for my next application!

I don't know if your navConfirm will be able to do async preventing, but a good example there :) router5 AFAIK, doesn't use history primarily, (it doesn't care about URL primarily), for router5, navigation info is just another data, which it makes use of, URL changing is the side effect which happens when those nav data changes. (meaning you can use router5 history without any URL at all)
That way, router5 can control preventing navigation very easily :)

@cyberhck I'm not entirely sure what you mean by "async preventing", but the way I have this working seems asynchronous to me. Basically if you trigger that middleware (which sits before RLR middleware) then you can not proceed until some specific state has been set. If another PUSH for example was dispatched in the meantime, it would also get stuck at this middleware and that would result in no change to the state (as we're still waiting for confirmation of navigation) and would not get to the next middleware, thus no action.

:D just to be clear, say I've got a dialog which is something like this:
const dialog = new DialogFactory().withTitle("Your changes aren't saved, are you sure you want to navigate away?").asWarning().build();
const result = dialog.show();
return result;

Say when user clicks on cancel, we reject the promise, in that case it shouldn't navigate away, it should work for network requests as well.
That's what I meant by async :)

@cyberhck I think that should work, but I do it by having a modal window that displays when navigation is attempted (and was prevented) determined by the navConfirm reducer containing the action which needs to be replayed. If they click "cancel", I remove the action stored in navConfirm which causes the modal to disappear. If they click "go", I grab the contents of navConfirm, then clear it, then use the contents I grabbed to replay the original action.
It's not ideal as I said, but it's the best I could do for now.

Thanks for your help! I might give it a try in a future project when I need something like this. But for now we've got a major app and we want as flexible and clean API as possible, so we're gonna go with router5.


Signal 11 (SIGSEGV) on asyncRead

Steps to Reproduce
I've got a query using anyOf with big list of elements (aprox. 11 000 elements) to check. The query runs perfectly fine synchronously but blocks my UI-Thread. Thats why I wanted to make it async, but when I try run the query asynchronously my app crashes.
Error:
Fatal signal 11 (SIGSEGV), code 2 (SEGV_ACCERR), fault addr 0x98572fe4 in tid 9700 (DartWorker), pid 6457

signal 11 (SIGSEGV), code 2 (SEGV_ACCERR), fault addr 0x98572fe4
Cause: stack pointer is close to top of stack; likely stack overflow.
    r0  b6d5da00  r1  8fa7fc18  r2  8fa7fc18  r3  b6d5da00
    r4  00000000  r5  b05d6aa8  r6  00000000  r7  00000000
    r8  b6d5d880  r9  b6d5da00  r10 8fa7fc88  r11 98573030
    ip  b6d5d880  sp  98573008  lr  aecb75d0  pc  aecb7508

Code sample
List<ExampleClass> requestResponseIds = [// 11 000 Elements]

// works fine
List<ExampleCollectionElement> result = isarDB.exampleCollectionElements.where().not().anyOf(requestResponseIds), (q, ExampleClass element) =>  q.idEqualTo(element.id)).findAll();

// CRASHES
List<ExampleCollectionElement> result = await isarDB.readAsync((isarDB) {
        return isarDB.exampleCollectionElements.where().not().anyOf(requestResponseIds), (q, ExampleClass element) =>  q.idEqualTo(element.id)).findAll();
      });

Details

Platform: Android
Flutter version: 3.0.0
Isar version: 4.0.0-dev.9

[x] I searched for similar issues already
[x] I filled the details section with the exact device model and version
[x] I am able to provide a reproducible example

This looks like a stack overflow caused by a huuuge query. anyOf is not very efficient and shouldn't be used with more than 10 values


change bazel-mirror to mirror.bazel

grep -v bazel-mirror:
do you mean to not use mirror to download ?
mirror links in workspace.bzl is marked as mirror.bazel , not bazel-mirror.
after this change , the download speed enhanced.

Can one of the admins verify this patch?

I signed it!

i just signed, wish to give my individual contributions to tensorflow.
i'm a software engineer now cross compiling tensorflow and packing it to my own C++ libs.

Agreement
Name
Date Signed
Manage

Google Individual CLA
ZhenLiu
Nov 21, 2017 00:37 PST
Edit Contact Information


Why are the regex matches case insensitive?

Doesn't the protocol specify the casing?

No, its case insensitive. The server (try public on at demo.nats.io:4222) will accept any case. Clients could be since server only sends CAPS, but original design is not case sensitive.


Bug fix serializing shader groups with "unsized arrays"

If asked the serialize the group before it's been optimized & jitted,
information about the concrete size of instance values of "unsized" arrays
will be in the SymOverrideInfo, not yet copied to the instance's copy
of the Symbol itself. So get it from the right place.

LGTM

Minor amendment -- I also needed to get the data offset from the instance override info. Added this to the review. Now we're cooking with fire!


Crashes when I go to another app

On Google Nexus 6P running Android 7.0 with the November 2016 security patch, whenever I switch to another app, RU Direct crashes.
Not really sure what's going on here. Any ideas?

Hey, not quite sure. I'm running Android 7.1.1 now and it seems to be working nominally when switching apps.
If you still have the problem, have you tried reinstalling or clearing the cache?

I'm on 7.0.
Yeah I just tried reinstalling and clearing the cache to no avail. Still
crashes.
On Wed, Dec 14, 2016 at 11:04 PM, James Paik<EMAIL_ADDRESS>wrote:

Hey, not quite sure. I'm running Android 7.1.1 now and it seems to be
working nominally when switching apps.
If you still have the problem, have you tried reinstalling or clearing the
cache?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/churichard/ru-direct/issues/9#issuecomment-267233452,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM5rczf90DMBCeWBBri78HKeeF95FNgdks5rILxqgaJpZM4LFY67
.

Hmm @churichard, do you have any ideas?

Thanks for the bug report @thatgeek95! I apologize for the delay in responding to you.
I looked into it and it seems like it's not a problem with RU Direct. One of the Android updates broke the app, perhaps due to our use of the Google Maps API. Also, it might be specific to the Nexus 5X and 6P.
If you're interested, here's a description of the error that's happening: https://code.google.com/p/android/issues/detail?id=225500
In the meantime, I believe the latest version of Android (7.1.1) fixed this issue. Could you try updating Android and see if that fixes your issue? Thanks!

I just got the update and it's working now.
Thanks!
On Dec 20, 2016 12:23, "Richard Chu"<EMAIL_ADDRESS>wrote:

Thanks for the bug report @thatgeek95 https://github.com/thatgeek95! I
apologize for the delay in responding to you.
I looked into it and it seems like it's not a problem with RU Direct. One
of the Android updates broke the app, perhaps due to our use of the Google
Maps API. Also, it might be specific to the Nexus 5X and 6P.
If you're interested, here's a description of the error that's happening:
https://code.google.com/p/android/issues/detail?id=225500
In the meantime, I believe the latest version of Android (7.1.1) fixed
this issue. Could you try updating Android and see if that fixes your
issue? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/churichard/ru-direct/issues/9#issuecomment-268303446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AM5rc1bxIGImcn92sTP_KmO_Y3Itlioqks5rKA8bgaJpZM4LFY67
.

Great! Thanks for using RU Direct :)


Unable to clearly see Show Invisible characters

I have Show Invisibles is turned on, however they're extremely hard to see.
Invisibles turn on: http://i.imgur.com/DCDLPp5.png
Invisibles turn off: http://i.imgur.com/5hYXwID.png

Seems like this is a mix between messed up property specificity and your syntax theme. What syntax theme are you using?

I believe it was Base16 Tomorrow Dark.
I didn't consider the syntax theme to be affecting this, I should have thought of that. :S

After applying the Atom Material UI Syntax theme, works fine, my bad :-/


initial docs setup

can we test Pages for these docs please? In theory they should just work. @SimonDanisch

continued in: https://github.com/MakieOrg/Tyler.jl/pull/2


When try to run with Speech2text example : AttributeError: module 'torchaudio' has no attribute 'legacy'

🐛 Bug

I try the speech to text example in openNMT
→ python preprocess.py -data_type audio -src_dir data/speech/an4_dataset -train_src data/speech/src-train.txt -train_tgt data/speech/tgt-train.txt -valid_src data/speech/src-val.txt -valid_tgt data/speech/tgt-val.txt -shard_size 300 -save_data data/speech/demo
the error is :
**[2020-03-02 20:21:17,427 INFO] Extracting features...
[2020-03-02 20:21:17,427 INFO]  * number of source features: 0.
[2020-03-02 20:21:17,427 INFO]  * number of target features: 0.
[2020-03-02 20:21:17,427 INFO] Building Fields object...
[2020-03-02 20:21:17,428 INFO] Building & saving training data...
[2020-03-02 20:21:17,436 INFO] Building shard 0.
0% 0/276 [00:00<?, ?it/s]
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
File "/usr/lib/python3.6/multiprocessing/pool.py", line 119, in worker
result = (True, func(*args, **kwds))
File "/content/OpenNMT-py/onmt/bin/preprocess.py", line 64, in process_one_shard
filter_pred=filter_pred
File "/content/OpenNMT-py/onmt/inputters/dataset_base.py", line 121, in init
for ex_dict in starmap(join_dicts, zip(*read_iters)):
File "/content/OpenNMT-py/onmt/inputters/audio_dataset.py", line 127, in read
spect = self.extract_features(audio_path)
File "/content/OpenNMT-py/onmt/inputters/audio_dataset.py", line 64, in extract_features
sound, sample_rate = torchaudio.legacy.load(audio_path)
AttributeError: module 'torchaudio' has no attribute 'legacy'
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "OpenNMT-py/preprocess.py", line 6, in
main()
File "/content/OpenNMT-py/onmt/bin/preprocess.py", line 293, in main
preprocess(opt)
File "/content/OpenNMT-py/onmt/bin/preprocess.py", line 273, in preprocess
'train', fields, src_reader, tgt_reader, align_reader, opt)
File "/content/OpenNMT-py/onmt/bin/preprocess.py", line 200, in build_save_dataset
for sub_counter in p.imap(func, shard_iter):
File "/usr/lib/python3.6/multiprocessing/pool.py", line 735, in next
raise value
AttributeError: module 'torchaudio' has no attribute 'legacy'**
there was a reply before to make sure if i installed the required torchaudio version specified in requirements.opt.txt. I tried to install it but the page is not found and i install it with "!pip install torchaudio" . the same error showing! :((
i am using google colab for runtime.

Hey, I would install a later version like for example:
v0.2.0
Still as legacy.

look into v0.2.0 legacy is only to load the files.
in line 64 where the error occurs, you could just change from torchaudio.legacy.load to torchaudio.load
and probably do a PR to correct that :)

yeeeees thank you so much. you solve the problem.
but i got this error :
[2020-03-02 21:37:40,822 INFO] Extracting features...
[2020-03-02 21:37:40,822 INFO]  * number of source features: 0.
[2020-03-02 21:37:40,823 INFO]  * number of target features: 0.
[2020-03-02 21:37:40,823 INFO] Building Fields object...
[2020-03-02 21:37:40,823 INFO] Building & saving training data...
[2020-03-02 21:37:40,831 INFO] Building shard 0.
0% 0/276 [00:00<?, ?it/s]
multiprocessing.pool.RemoteTraceback:
"""
Traceback (most recent call last):
File "/usr/lib/python3.6/multiprocessing/pool.py", line 119, in worker
result = (True, func(*args, **kwds))
File "/content/OpenNMT-py/onmt/bin/preprocess.py", line 64, in process_one_shard
filter_pred=filter_pred
File "/content/OpenNMT-py/onmt/inputters/dataset_base.py", line 121, in init
for ex_dict in starmap(join_dicts, zip(*read_iters)):
File "/content/OpenNMT-py/onmt/inputters/audio_dataset.py", line 127, in read
spect = self.extract_features(audio_path)
File "/content/OpenNMT-py/onmt/inputters/audio_dataset.py", line 71, in extract_features
% (audio_path, sample_rate, self.sample_rate)
AssertionError: Sample rate of OpenNMT-py/data/speech/an4_dataset/train/wav/1.wav != -sample_rate (48000 vs 16000)
"""
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "OpenNMT-py/preprocess.py", line 6, in
main()
File "/content/OpenNMT-py/onmt/bin/preprocess.py", line 293, in main
preprocess(opt)
File "/content/OpenNMT-py/onmt/bin/preprocess.py", line 273, in preprocess
'train', fields, src_reader, tgt_reader, align_reader, opt)
File "/content/OpenNMT-py/onmt/bin/preprocess.py", line 200, in build_save_dataset
for sub_counter in p.imap(func, shard_iter):
File "/usr/lib/python3.6/multiprocessing/pool.py", line 735, in next
raise value
AssertionError: Sample rate of OpenNMT-py/data/speech/an4_dataset/train/wav/1.wav != -sample_rate (48000 vs 16000)

Okey, so that is because the sample rate from your files are 48000 and they want 16000 so you have to resample the audio, this could be done in a couple of ways, using transform resample or using librosa
For simplicity reasons, I would covert all files using librosa to the desired sample rate 16000 as follows:
import librosa
target_sr = 16000
y, sr = librosa.load(audio_path, sr=None)
y_resample = librosa.core.resample(y, sr, target_sr)
librosa.output.write_wav(output_audio_path, y, target_sr)

However, this is out of the scope of the issues with torchaudio.

thank you soo much tomassosorio, you are genius


Error in training

I have followed all the instruction for downloading the dataset and configuring the developement env, however when running the following command:
python scripts/train.py --config-name train_bc.yaml data.pickle_fn=../assets/cloud-data-scooping/scooping_parsed_with_embeddings_moco_conv5.pkl
I have the following error:
Traceback (most recent call last):
  File "scripts/train.py", line 101, in main
    agent.train(data)
  File "/home/ai-ray/projects/toto_benchmark/toto_benchmark/agents/BaseAgent.py", line 46, in train
    self.compute_loss(sample)
  File "/home/ai-ray/projects/toto_benchmark/toto_benchmark/agents/BCAgent.py", line 17, in compute_loss
    output = self.forward(sample)
  File "/home/ai-ray/projects/toto_benchmark/toto_benchmark/agents/BCAgent.py", line 14, in forward
    return self.models['decoder'](sample['inputs'])
  File "/home/ai-ray/mambaforge/envs/toto-benchmark/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1110, in _call_impl
    return forward_call(*input, **kwargs)
  File "/home/ai-ray/projects/toto_benchmark/toto_benchmark/agents/BCAgent.py", line 97, in forward
    h = (observations - self.inp_mean) / self.inp_std
RuntimeError: The size of tensor a (7) must match the size of tensor b (2055) at non-singleton dimension 1

I noticed that the name of the pkl file with data parsed with moco is different (missing a _robocloud at the end of the name), could the format of the file have changed?

Hi,
Sorry for the confusion. This is due to a mismatch in the training code and the dataset. We have pushed a fix to scripts/train.py which should solve the issue. Please let me know if there are additional questions.
For context, the 'observations' key in the dataset contains only jointstates (dim 7) although scripts/train.py previously assumes the 'observations' key contain the concatenation of jointstates (dim 7) with image embeddings (dim 2048). The fix is to concatenate 'observations' with 'embeddings' for each trajectory in the dataset.

Thanks for the clarification, the training script is now working for the pouting dataset, while the scooping data the process is killed at some point (after loading the trajectory data) without any output... :-|
(toto-benchmark) ai-ray@mimas:~/projects/toto_benchmark/toto_benchmark$ /home/ai-ray/mambaforge/envs/toto-benchmark/lib/python3.8/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 6 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
python scripts/train.py --config-name train_bc.yaml data.pickle_fn=../assets/scooping_parsed_with_embeddings_moco_conv5.pkl
Model saved dir:  /home/ai-ray/projects/toto_benchmark/toto_benchmark/outputs/2023-08-06/15-16-17
default:
- override hydra/output: local
- override hydra/launcher: local
data:
  pickle_fn: ../assets/scooping_parsed_with_embeddings_moco_conv5.pkl
  subsample_period: 1
  in_dim: 2055
  out_dim: 7
  H: 50
  top_k: null
  images:
    cameras: []
    im_h: 480
    im_w: 640
    per_img_out: 2048
    crop: true
  noise: 0.0
  logs_folder: ../assets
agent:
  type: bcimage_pre
  vision_model: moco_conv5_robocloud
  vision_model_path: None
  description: NA
  hidden_dim: 128
training:
  lr: 0.001
  seed: 0
  epochs: 80
  device: cuda:0
  batch_size: 128
  save_every_x_epoch: 10
debug: true
saved_folder: /home/ai-ray/projects/toto_benchmark/toto_benchmark/outputs/2023-08-06/15-16-17

/home/ai-ray/projects/toto_benchmark/toto_benchmark ../assets/scooping_parsed_with_embeddings_moco_conv5.pkl
wandb: Currently logged in as: diego-dallalba (sano-science). Use `wandb login --relogin` to force relogin
wandb: wandb version 0.15.8 is available!  To upgrade, please run:
wandb:  $ pip install wandb --upgrade
wandb: Tracking run with wandb version 0.12.17
wandb: Run data is saved locally in /home/ai-ray/projects/toto_benchmark/toto_benchmark/outputs/2023-08-06/15-16-17/wandb/run-20230806_151618-1lw6is71
wandb: Run `wandb offline` to turn off syncing.
wandb: Syncing run fearless-water-19
wandb: ⭐ View project at https://wandb.ai/sano-science/toto-bc
wandb: 🚀 View run at https://wandb.ai/sano-science/toto-bc/runs/1lw6is71
Using 1309 number of successful trajs. Total trajs: 1895
Killed

Hi,
The process being killed is mostly because the run time memory needed by the process is too large. Terminating other processes before launching this experiment may help.


Breakpoints are outdated

1200px can no longer be considered an XL screen.
Look at these stats: http://gs.statcounter.com/screen-resolution-stats/desktop-tablet-console/worldwide/
It's very common to working with 1920px. Having the last breakpoint at 1140px isn't enough.
For convenience sake, we should either have another breakpoint, or shift all breakpoints up a level  (because I would rather not create my own breakpoints).

This might be duplicated to #26676.

This might be duplicated to #26676.


Update Swagger spec commit for queue

Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists

[ ] Added impacted package name to the issue description
[ ] Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
[ ] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.

As discussed with Emma, it's just commit ID change, the generated code has no change.


Call to a member function get_extra_permastruct() on null

Run wp import command : result
Run wp option update command : result
Start development server using wp server or php -S command : result
While deployment on heroku

https://github.com/feryardiant/wpdev/pull/38/commits/595869a66788701094235cba7cf5db4f78515b32 should fix this issue