Weed out empty features from the registry

It looks like the empty string is leaking in as a feature to all crates being
published on crates.io unintentionally. This means that each dependency edge
activates the feature "". This in turn confuses the resolution process quite a
bit, causing it to be far more recursive than it should be.
The empty feature, "", is weeded out during activation of features but it's
never explicitly activated. This means that each new dependency we see has one
requested feature (the empty one) with no activated features (as it doesn't have
any). This ends up causing us to recurse to attempt to reactivate the
dependency. This extreme recursion ended up blowing the stack on some smaller
crates and this commit fixes that.

r? @wycats
(rust_highfive has picked a reviewer for you, use r? to override)

I'm going to investigate why these empty features are leaking into the registry, but we have to deal with all existing listings so we're going to need this anyway.

r=me with a code comment explaining this is defending against bogus data in the registry

@bors: r=brson dffb5078f26236eb97c3942bce0ea139932a736e

:hourglass: Testing commit dffb507 with merge 5cf4a89...

crates.io is now fixed: https://github.com/rust-lang/crates.io/commit/e1d1c6c1f8ee2e4f076285706d92539229b4db40

:sunny: Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-64


Error unfreezing intermediate layers

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Training should run properly while updating parameters of transformer layers.
Current behaviour
Error
 File "~/axolotl/env/lib/python3.10/site-packages/deepspeed/runtime/zero/stage3.py", line 149, in __init__
[rank2]:     self.dtype = self.optimizer.param_groups[0]['params'][0].dtype
[rank2]: IndexError: list index out of range

Steps to reproduce
When I unfreeze embed_tokens or lm_head or do not freeze anything. The training runs as expected.
When I freeze the transformer layers, the error occurs.
Config yaml
base_model: ~/results/run1/checkpoint-2000
model_type: AutoModelForCausalLM
tokenizer_config: ~/tokenizer/final_tokenizer_hf
tokenizer_type: LlamaTokenizer
trust_remote_code: true
# Resize the model embeddings when new tokens are added to multiples of 32
# This is reported to improve training speed on some models
resize_token_embeddings_to_32x: true

load_in_8bit: false
load_in_4bit: false
strict: false

unfrozen_parameters:
  - transformer.blocks.[0-7].
  # - ^lm_head.weight$
  # - ^model.embed_tokens.weight$

model_config:
  output_router_logits: true

datasets:
  - path: json
    type: "completion"
    data_files: ~/data/data.jsonl
    ds_type: json
output_dir: ~/results/

sequence_len: 4096
sample_packing: true
pad_to_sequence_len: true
logging_steps: 1
warmup_steps: 10
gradient_accumulation_steps: 4
micro_batch_size: 8
num_epochs: 3
max_steps: 2000
eval_steps: 100
optimizer: adamw_hf
lr_scheduler: cosine
learning_rate: 0.0001

# wandb_project:
# wandb_key :
# wandb_entity:
# wandb_name:
# wandb_log_model:

train_on_inputs: false
group_by_length: false
bf16: auto
fp16:
tf32: false

gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true

save_total_limit: 1
save_steps: 100
debug:
deepspeed: ~/axolotl/deepspeed_configs/zero3_bf16_cpuoffload_all.json
weight_decay: 0.0
fsdp:
fsdp_config:

Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
3.10
axolotl branch-commit
main
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

transformer.blocks.[0-7]. doesn't match up with any llama models. It looks like you're using the llama tokenizer though.  There isn't enough information here for me to help without knowing the model architecture.

Thanks for reply @winglian .
I am using base model as llamav2. I tried with the below configuration as well. However, I received the same error as mentioned earlier.
unfrozen_parameters:
       model.layers.*


Jenkins test

Do not merge.

Test this please

Repoen

test this please

test this please

test this please

@khurtado @d-ylee I think you were only testing Jenkins with this PR. Can we close this out now?


Snapdragon flight issues

Running master 9386ab6, having issues with Altitude and Position modes.
Seeing jumps in altitude in Alt mode and inconsistant descent rates with throttle down to minimum in Position mode
https://logs.px4.io/plot_app?log=0d071130-a372-4812-96eb-724b51cc322e
https://logs.px4.io/plot_app?log=a644ce25-f0b8-4fee-8323-77730518c863
Also, there are a few instances of RTL ebing triggered from what looks like an RC signal loss but the log does not show an error making mention of this

will troubleshoot and tune vehicle once issue #9971 is addressed


Not adding headers to queueable mailables

Fixes #5
There is a bug in Laravel (https://github.com/laravel/framework/issues/17283) that prevents Mailable with callbacks to be serialized for queueing.
So when a Mailable implements ShouldQueue we don't add headers.
Also changed the check from MailableContract to Mailable since the applyDebugHeaders function expects a Mailable (that has a view property).

Doesn't this just remove the debug feature for queued mail?

Yes, because this feature is not available on queued Mailables.
This package could provide a modified HeloMailable to extend, but what is the point of debugging locally the content of enqueued Mailables?

Why has this not been merged yet? @mpociot


Dependency decompress-tar is a vulnerability

Hello, there is a vulnerability detected by Snyk regarding decompress-tar that is affecting this package.
https://security.snyk.io/package/npm/decompress-tar
Is there any chance to fix it or suggest a solution? Thanks

I am also running into this. If its okay with you, id be happy to help with this fix @kevva?


[Bug]: [Column Space] Consider container border width in column space calculation

Issue:
Increasing border width of containers doesn't affect the sizes of child widgets, leading widgets to get cut off at the edges. Highlights along the edges are also not visible.
Fix:
Consider container border width for column space calculation. Correct column space will fix both the visible issues.
https://user-images.githubusercontent.com/5424788/234034426-93d55f97-905b-4534-bdec-78d4d55fee94.mov

PR: https://github.com/appsmithorg/appsmith/pull/22738

@prsidhu Can we merge latest release and then verify this?


moodle: 3.8.1 -> 3.8.2

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/moodle/versions.
meta.description for moodle is: "Free and open-source learning management system (LMS) written in PHP"
meta.homepage for moodle is: "https://moodle.org/"
Updates performed:

Version update

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 3.8.2 with grep in /nix/store/8xn6jbgfsj3j1wcpns95rsp7dgyrkx3z-moodle-3.8.2

directory tree listing: https://gist.github.com/ec8821a879db64ef801a911361d6186d

du listing: https://gist.github.com/2fb9bba02505b6f9d21be62c3b40ade8

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)
1 package rebuild(s)
1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
moodle

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8xn6jbgfsj3j1wcpns95rsp7dgyrkx3z-moodle-3.8.2 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A moodle https://github.com/r-ryantm/nixpkgs/archive/e3e53adc35d1a45d3849d6246a3dc9c2ec296122.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8xn6jbgfsj3j1wcpns95rsp7dgyrkx3z-moodle-3.8.2
ls -la /nix/store/8xn6jbgfsj3j1wcpns95rsp7dgyrkx3z-moodle-3.8.2/bin

Security report (click to expand)

CVEs resolved by this update:
none
CVEs introduced by this update:
none
CVEs present in both versions:

CVE-2019-15536

cc @aanderse for testing.

@GrahamcOfBorg test moodle


Multi Control Plane: come up with labelling scheme for control plane selection

We need to have a way to select which control plane to use. This will likely be done by labels on namespace/pod. Something like istio.io/environment: my-control-plane.istio-system.
We need to

Come up with the label name to use
Determine what the value is (svc name? deployment name? some other identifier?)
Determine if what we reference is a stable identifier (my-pilot-deployment-123) or a label (pilot-canary)
Figure out how to configure webhooks to handle this (I think per-pod requires k8s 1.15+?)
Documentation, tests

cc @ostromart @costinm

TOC approved istio.io/rev

Done ^


disable publish profile input box

As discussed today, this input box shouldn't be editable since the folder button needs to be used to load a profile and  nothing actually happens when the text in this input box is changed.
without loaded profile:

with loaded profile:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.11%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
28153

Relevant Lines:
62380

💛  - Coveralls


Improve debugging messages

This is in preparation for the effective REST-Client to curb replacement

test this please

test this please


Align tabs with the bottom of screen

Is there any way to align the SmartTabLayout with the bottom of the screen?

Hi, @ankurchandraa
See #39


'view_tool_product' not found when I added a tool or clicked on view tools on product dashboard settings.

Discussed in https://github.com/DefectDojo/django-DefectDojo/discussions/6026

Originally posted by worapojc March 16, 2022
Hi all,
I've configured SonarQube in Tools Configuration.
API connection successful with message: You have access to 8 projects.
Tool Configuration successfully updated.

I tried to add SonarQube integration for the product via Settings -> Add Tools to import from SonarQube project.
However, it returns HTTP 500. Please see the stacktrace that I copied from uWSGI service.
How do I solve this issue?

django.urls.exceptions.NoReverseMatch: Reverse for 'view_tool_product' not found. 'view_tool_product' is not a valid view function or pattern name.
ERROR:django.request:Internal Server Error: /product/1/tool_product/all
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/django/core/handlers/exception.py", line 47, in inner
response = get_response(request)
File "/usr/local/lib/python3.8/site-packages/django/core/handlers/base.py", line 181, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/app/./dojo/authorization/authorization_decorators.py", line 30, in _wrapped
return func(request, *args, **kwargs)
File "/app/./dojo/tool_product/views.py", line 50, in all_tool_product
return render(request, 'dojo/view_tool_product_all.html', {
File "/usr/local/lib/python3.8/site-packages/django/shortcuts.py", line 19, in render
content = loader.render_to_string(template_name, context, request, using=using)
File "/usr/local/lib/python3.8/site-packages/django/template/loader.py", line 62, in render_to_string
return template.render(context, request)
File "/usr/local/lib/python3.8/site-packages/django/template/backends/django.py", line 61, in render
return self.template.render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 170, in render
return self._render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 162, in _render
return self.nodelist.render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
bit = node.render_annotated(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
return self.render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/loader_tags.py", line 150, in render
return compiled_parent._render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 162, in _render
return self.nodelist.render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
bit = node.render_annotated(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
return self.render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/loader_tags.py", line 62, in render
result = block.nodelist.render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
bit = node.render_annotated(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
return self.render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/defaulttags.py", line 315, in render
return nodelist.render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 938, in render
bit = node.render_annotated(context)
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
return self.render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/defaulttags.py", line 214, in render
nodelist.append(node.render_annotated(context))
File "/usr/local/lib/python3.8/site-packages/django/template/base.py", line 905, in render_annotated
return self.render(context)
File "/usr/local/lib/python3.8/site-packages/django/template/defaulttags.py", line 449, in render
url = reverse(view_name, args=args, kwargs=kwargs, current_app=current_app)
File "/usr/local/lib/python3.8/site-packages/django/urls/base.py", line 86, in reverse
return resolver._reverse_with_prefix(view, prefix, *args, **kwargs)
File "/usr/local/lib/python3.8/site-packages/django/urls/resolvers.py", line 698, in _reverse_with_prefix
raise NoReverseMatch(msg)

what version are you running?

latest, 2.8.0

merged for release 2.9.0


Html in props

I've created the ability for HTML as an option. Admittedly not the best way to do it (once you see the code).
Anyway the last test is failing because the HTML regexp isn't matching correctly. The tests you created matched, but not what you'd expect. The last test shows that.
Hint: The content of the a is actually also read as params themselves. (another reason why regexp isn't the right tool for this)
I'll let you see if you can get the tests to be all green again :)

Btw, don't worry about building the dist files. That just clutters the commit log :)

Btw2, I wanted to commit directly to your PR, but for some reason I could not.

 Once things settle down for us a bit, I might be able to take another stab at this. We're in the last stretch of our project atm and spare time is non existent


Valid XHTML

Make output validate to XHTML 1.0 Strict according to:
https://validator.w3.org/
Mostly some missing end tags, missing spaces and, perhaps more
controversial, using http instead of https to DTD's and xmlns, as per
the spec.

Thank you for your pull request! It is amazing how lenient modern browsers are with regards to such errors.
I am not sure about the use of https for the doctype. Wouldn't the use of http break https compatibility? As of my tests, this doesn't seem to be an issue. But in general, I think I would prefer to use
<!DOCTYPE html>
<html lang="en">

anyway, and not have any URLs at all in there.
Do you want to amend your pull request to do this, or would you like me to merge first, and add the above change myself?


Autocomplete in file editor attempts to show me options after I click space bar.

Fixed, will be seen in next release.


from aws_cdk import core ModuleNotFoundError: No module named 'aws_cdk'

Followed steps in the AWS Blog:  https://aws.amazon.com/blogs/database/part1-use-aws-kms-to-securely-manage-ethereum-accounts/
but ran into following error, when running 'cdk deploy'
from aws_cdk import core ModuleNotFoundError: No module named 'aws_cdk'

Hi @albert-vo-crypto ,
that error indicates that the aws_cdk sources are not available in your current Python environment. Can you please execute the pip install -r requirements.txt step again and make sure that your current Python environment is activated (Activating the virtualenv.


specify Xcode version in Jenkins jobs

Addresses #4620

This will need to be amended once we want to resume running jobs with non-default Swift toolchains again (such as when Xcode 9 comes out with a Swift 3 compilation mode) but for now this should be sufficient.

Do the release scripts need to be updated as well so that we don't accidentally cut a release using the 8.3 beta?

You're right @tgoyne, done in ee64c1f.


[23.05] thunderbirdPackages.thunderbird-115: 115.1.0 -> 115.1.1

https://www.thunderbird.net/en-US/thunderbird/115.1.1/releasenotes/
(cherry picked from commit 067cf755987629a10ff823b0f0b5de5ea8bfd46c)
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

/cc the master PR #249736


Describe true and false expressions

This is required to compile with core versions >= 3.2.0. It adds descriptions for query expressions which is part of the metrics feature. description() is a pure virtual method so if these are not present there will be a compile time error.

Shouldn't their descriptions correspond to the form that they're represented in the query strings (TRUEPREDICATE / FALSEPREDICATE)?

It looks like these types have now been duplicated in sync, object store, and Cocoa… would you be interested in moving them down to core at some point so we can eliminate this redundancy?

Sure, this is as good a time as any to move them down. I'll close this PR and make a new one removing them after the core changes.
I think simply "true" and "false" will read better when the query is printed out, but I'll add a core test using them to check this.

I'm not sure what you mean by "read better". Shouldn't the goal be to have the queries be displayed to the user in the same form that they'd write them? Or at least as close as possible?

Yes that is the goal. But I don't think users want to know the details about our implementation in "TrueExpression" Here's an example:
Query q0 = person->column<int64_t>(0) == 0;
Query and_true = q0.and_query(std::unique_ptr<realm::Expression>(new TrueExpression));
and_true.find_all();
...
// retrieving metrics about this query will produce the following description:
// queries->at(0).get_description() == "person.age is equal to 0 and true"

Could be debatable but I would prefer "true" to "TRUEPREDICATE" at the end there.
Reading it out like that either way makes the construction of a query containing a TrueExpression or FalseExpression seems a bit redundant to me and may not be necessary at all.

TRUEPREDICATE is the form that's used in queries as consumed by object store's query parser, Cocoa's NSPredicate queries, and sync's recently-introduced parser.
For the query you demonstrate, I think the user would much prefer to see person.age == 0 AND TRUEPREDICATE, because that's likely to be much closer to the query they wrote. Generating human-readable text like "is equal to" instead of the obvious == feels out of place.

Ok, good point. I'll use TRUEPREDICATE.
Regarding "is equal to" there are probably other operator descriptions that need to change so I'll leave that to another time when the requirements for query descriptions are clear. I'm not familiar with how the bindings construct user queries and we would have to reach some readable compromise that works for each binding.


[Bug/Model Request]: I cannot download any model

What happened?
I have been working the past month with Qdrant and all was going great. Suddenly, the past week, when I tried to download a model, like the base model BAAI/bge-small-en when adding elements to a collection I receive the next message:
2024-09-23 20:02:31.360 | ERROR    | fastembed.common.model_management:download_model:256 - Could not download model from url: https://storage.googleapis.com/qdrant-fastembed/BAAI-bge-small-en.tar.gz
I am using fastembed 3.6.0
What Python version are you on? e.g. python --version
<3.13,>=3.8.0
Version
0.2.7 (Latest)
What os are you seeing the problem on?
Windows
Relevant stack traces and/or logs
No response

Hey @eduardfossas, have you tried other models?
Some of the models are downloaded from our gcp storage, while the others are downloaded from HF Hub
Could you please try downloading other models?
E.g. BAAI/bge-small-en-v1.5

Hmm, that seemed to work, I think the problem is gcp storage. Thanks!

Is there any other traceback available for the models which are failing for you?
Have you maybe changed some of your firewall rules or made any other network related updates?

Hello @joein. Yes, the only thing I did was delete the cache folder in temp. Maybe that was the issue too.

Hey,
How to resolve this issue? It was all working fine but now when I try I get the same error - ValueError: Could not download model BAAI/bge-small-en from any source.

Hello, @aniketwattamwar. That's a good question. I think I did this on top of my python file and it solved it for me:
model = TextEmbedding(model_name="BAAI/bge-small-en-v1.5")

Thank you @eduardfossas
That worked for me too. A bit weird when it stopped working suddenly.
client.set_model("BAAI/bge-small-en-v1.5")


Inconsistent productivity in explosives recipes

Mod source
Factorio Mod Portal
Which mod are you having an issue with?

[X] pyalienlife
[X] pyalternativeenergy
[ ] pycoalprocessing
[ ] pyfusionenergy
[ ] pyhightech
[ ] pyindustry
[ ] pypetroleumhandling
[ ] pypostprocessing
[ ] pyrawores

Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[X] Balance
[ ] Pypostprocessing failure
[ ] Other

What is the problem?
Title. The first, worse explosives recipe can take productivity modules, the second cannot.

Steps to reproduce
No response
Additional context
No response
Log file
No response

... never mind, I hadn't updated to the latest version


chore(aws): handle NotAction cases in IAM policies

Context
Thanks to @Chan9390, we discovered that policies allowing invalid actions in NotAction statements grant Administrator access:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "Statement1",
            "Effect": "Allow",
            "NotAction": "prowler:action",
            "Resource": "*"
        }
    ]
}

And AWS does not have a validation yet to prevent this policies to be added.
Description
Handle NotAction cases to avoid false negatives as well as when the action is invalid in checks:

iam_policy_allows_privilege_escalation
iam_inline_policy_allows_privilege_escalation
iam_aws_attached_policy_no_administrative_privileges
iam_customer_attached_policy_no_administrative_privileges
iam_customer_unattached_policy_no_administrative_privileges
iam_inline_policy_no_administrative_privileges

Checklist

Are there new checks included in this PR? Yes / No

If so, do we need to update permissions for the provider? Please review this carefully.

[x] Review if the code is being covered by tests.
[x] Review if code is being documented following this specification https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
[x] Review if backport is needed.

License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sergargar Thanks for picking this up.
As this check is being added, there's a variation to this bypass using NotAction and NotResource.
Example:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "Statement1",
            "Effect": "Allow",
            "NotAction": "prowler:action",
            "NotResource": "arn:aws:s3:::calculator"
        }
    ]
}

The above policy grants all access to all resources in your account (like Admin access) even though the bucket calculator is not a resource in your account.

@sergargar Thanks for picking this up.
As this check is being added, there's a variation to this bypass using NotAction and NotResource.
Example:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "Statement1",
            "Effect": "Allow",
            "NotAction": "prowler:action",
            "NotResource": "arn:aws:s3:::calculator"
        }
    ]
}

The above policy grants all access to all resources in your account (like Admin access) even though the bucket calculator is not a resource in your account.

@sergargar Thanks for picking this up.
As this check is being added, there's a variation to this bypass using NotAction and NotResource.
Example:
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Sid": "Statement1",
            "Effect": "Allow",
            "NotAction": "prowler:action",
            "NotResource": "arn:aws:s3:::calculator"
        }
    ]
}

The above policy grants all access to all resources in your account (like Admin access) even though the bucket calculator is not a resource in your account.

Hi Chan9390Chan9390, thanks for letting me know this variation, I will include it to the PR too.


[CARBONDATA-4053] Fix alter table rename column failed when column name is "a"

Why is this PR needed?
Alter table rename column failed because incorrectly replace the content in tblproperties by new column name, which the content is not related to column name.
What changes were proposed in this PR?
Instead of calling replace method on property value directly, first filter out the properties which related to column name, then find the matched old column name, replace it with new name.
Does this PR introduce any user interface change?

No

Is any new testcase added?

Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4870/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3117/

LGTM.
Thanks for your contribution.

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3128/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4882/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4885/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3131/


Remove unused SolrCore constructor and tidy up constructor javadoc

I've been spelunking in the SolrCore and CoreContainer code for Solr-4735, and came across this. There's one unused constructor (with a misleading comment on it), and the javadoc for the other two constructors is incomplete, so here's a housekeeping patch tidying it up.
I think the javadoc comments on the remaining constructors is also inaccurate, though? The SolrCore doesn't register itself or deal with name clashes any more, that's all done in the CoreContainer.

torvalds.dev is analyzing the ticket

torvalds.dev is analyzing the ticket

The issue you're dealing with is related to the SolrCore class in the Solr project. The SolrCore class is a central part of Solr, representing a single index and handling the main operations on it.
From your description, it seems there are several tasks to be done:

Remove unused constructor: There is a constructor in the SolrCore class that is not being used. This constructor should be removed to clean up the code and avoid confusion.

Tidy up constructor Javadoc: The Javadoc comments for the constructors are incomplete or misleading. These should be updated to accurately reflect what the constructors do.

Update Javadoc comments on remaining constructors: You've noted that the Javadoc comments on the remaining constructors may be inaccurate, as the SolrCore no longer registers itself or deals with name clashes - this is now handled by the CoreContainer. The Javadoc comments should be updated to reflect this.

The relevant file for these tasks is:

solr/core/src/java/org/apache/solr/core/SolrCore.java

To address this issue, you should:

Open the SolrCore.java file and identify the unused constructor. Remove this constructor from the code.

Review the Javadoc comments for the remaining constructors. Update these comments to accurately describe what each constructor does.

Review the Javadoc comments for the SolrCore class and its methods. Update these comments to reflect the current functionality of the class, particularly noting that registration and name clash handling is done by the CoreContainer.

Test the Solr project to ensure that your changes have not introduced any errors.

Open a pull request for your changes, providing a detailed description of the changes you've made and why. This will allow other contributors to review your changes and provide feedback.

Remember to follow the project's contribution guidelines when making your changes.


Fix a couple of nits in pg/errors and edb/server

(context: https://github.com/edgedb/edgedb/pull/3103#pullrequestreview-798036972)


add new module shenyu-sdk. #3925

Codecov Report

Merging #4246 (db8ec0d) into master (8b1f860) will decrease coverage by 0.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4246      +/-   ##
============================================
- Coverage     69.58%   69.32%   -0.27%
+ Complexity     7363     7331      -32
============================================
  Files           992      992
  Lines         27885    27885
  Branches       2473     2473
============================================
- Hits          19404    19330      -74
- Misses         7003     7087      +84
+ Partials       1478     1468      -10

Impacted Files
Coverage Δ

...n/alibaba/dubbo/cache/AlibabaDubboConfigCache.java
47.12% <0.00%> (-31.04%)
:arrow_down:

.../client/server/consul/ShenyuConsulConfigWatch.java
60.41% <0.00%> (-25.00%)
:arrow_down:

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
75.00% <0.00%> (-6.25%)
:arrow_down:

...org/apache/shenyu/admin/model/dto/AuthPathDTO.java
58.82% <0.00%> (-5.89%)
:arrow_down:

...nyu/plugin/motan/cache/ApplicationConfigCache.java
52.00% <0.00%> (-5.00%)
:arrow_down:

...a/org/apache/shenyu/admin/model/entity/BaseDO.java
52.17% <0.00%> (-4.35%)
:arrow_down:

...che/shenyu/admin/model/vo/DashboardUserEditVO.java
60.86% <0.00%> (-4.35%)
:arrow_down:

...ache/shenyu/admin/model/dto/DataPermissionDTO.java
59.25% <0.00%> (-3.71%)
:arrow_down:

... and 24 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


The window has crashed (reason: 'crashed', code: '-1073741795')

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: <IP_ADDRESS>
OS Version: Win10 x64 18368.1734

Steps to Reproduce:

Start Code, either code --crash-reporter-directory c:\hold\codedump\ or code --disable-extensions
Feel sad because it crashed.

codeerr.zip

Closing per https://github.com/microsoft/vscode/issues/133864#issuecomment-929035988


feat(dmn/decision-table): add keyboard module adapter

DecisionTableKeyboardBindings is removed completely as it's no more required for the keyboard bindings to work properly.
Closes #1060

Rebased on top of master.


rustic with local backend always creates repository folder if it doesn't exist

I think this is an unwanted behavior of repoinfo, as it prompts for a password, print this error and create an empty folder:
$ rustic --repo ~/Desktop/non-existent repoinfo --json
enter repository password: [hidden]
error: No repository config file found. Is there a repo at local:/home/jack/Desktop/non-existent?

I think the correct order should be:

check if folder exists, error if not (do not create an empty folder)
check if repo config file exists, error if not
prompt for password

The option --only-files does not error, but still creates an empty foler

@AlphaJack Thanks a lot for reporting! Actually only the local backend is affected - there all commands (also read-only ones) currently do create the repo dir, if it doesn't exist.


Example with i18next

Hey @Vadorequest 👋
Thanks for creating this library! Can please provide an example how to integrate it with i18next and react-i18next? Optionally, without the usage of getInitialProps in custom _app, since I wouldn't want to opt-out of automatic static optimization!
Thanks in advance!

Hello @matepapp :)
There is already an example with Next.js. It doesn't feature i18next or react-i18next because I wanted to keep things simple.
But I've made a much more complete example with those 2 libs (+ Locize provider) at https://github.com/UnlyEd/next-right-now
It uses getInitialProps though, because SSG wasn't yet released at the time, but SSG support is on my roadmap :)

Yes, I've already checked next-right-now! It's an amazing template, but it was kinda "too much" for my use case. My goal is to use the NexJS provided automatic static optimization, not the static site generation (SSG), which is released about a week ago and the example with getInitialProps in _app.tsx unfortunately doesn't enable that.

The reason why we use _app:getInitialProps is because we universally detect the language. If you don't need SSR nor SSG then you could remove all the code in _app:getInitialProps and detect the language on the browser only. But in such case, you don't need universal-language-detector at all.
This lib is only useful if you need to detect the langage both on the server and on the browser. But I'm not sure I understand perfectly your use case.

@matepapp You should take a look at this discussion, surely you'll find a few things that helps :)
https://github.com/zeit/next.js/discussions/10651#discussioncomment-537

thanks @Vadorequest, I've figured it out that we can go with client-only language detection and simple use react-i18next. I think I can close this issue if you don't mind.


(WIP)fix(js-parser): support ts resolution-mode import

Summary
closes: #2115

Test Plan

@fireairforce Are you still interested in the PR?

@Conaclos i will update this later～

it seems i need to support https://tc39.es/proposal-import-attributes/ this feature for our parser

it seems i need to support https://tc39.es/proposal-import-attributes/ this feature for our parser, I will add a new pr to support this feature before this mr.

We already support import attributes.
Let me take a look at the current PR.

this mr is ready for review~


[BUG] CreateReceiveLinkException (Unauthorized access) - even though RBAC on topic subscription was configured

Library name and version
Azure.Messaging.ServiceBus 7.18.0
Describe the bug
I want to use RBAC to enable clients to listen to a ServiceBus Topic Subscription.
I've assigned the Azure Service Bus Data Receiver (and Sender) role to an Entra ID Group on the scope of the ServiceBus Topic Subscription. ("Development Team" is the name of the Entra ID Group - see picture)
I'm myself member of the Entra ID Group.

I'm registering the clients via Microsoft.Extensions.Azure 1.7.5.
services.AddAzureClients(clientsBuilder =>
{
    var subscriptionOptions = this.Configuration.GetSection("ServiceBus").Get<SubscriptionOptions>()!;

    clientsBuilder
        .AddServiceBusClientWithNamespace($"{subscriptionOptions.Name}.servicebus.windows.net")
        .ConfigureOptions(options =>
        {
            options.TransportType = ServiceBusTransportType.AmqpTcp;
        });

    clientsBuilder
        .AddClient<ServiceBusProcessor, ServiceBusProcessorOptions>((options, _, provider) =>
        {
            options.MaxConcurrentCalls = subscriptionOptions.MaxConcurrency;
            options.AutoCompleteMessages = false;
            options.PrefetchCount = subscriptionOptions.PrefetchCount;
            options.ReceiveMode = ServiceBusReceiveMode.PeekLock;

            return provider
                .GetRequiredService<ServiceBusClient>()
                .CreateProcessor(
                    subscriptionOptions.TopicName,
                    subscriptionOptions.SubscriptionName,
                    options);
        });

            clientsBuilder.UseCredential(
                new DefaultAzureCredential(
                    new DefaultAzureCredentialOptions
                    {
                        VisualStudioTenantId = "[redacted]",
                        Diagnostics =
                        {
                            IsAccountIdentifierLoggingEnabled = true,
                            IsLoggingEnabled = true
                        }
                    }));
});

Expected behavior
A local develpoment client aka "Visual Studio started process", is able to receive messages via DefaultAzureCredentials via VisualStudioCredentials.
Actual behavior
A token is successfully received:
DefaultAzureCredential.GetToken succeeded. Scopes: [ https://servicebus.azure.net/.default ] ParentRequestId: ExpiresOn: 2024-09-17T12:01:25.1849635+00:00
⚠ But right afterwards a CreateReceiveLinkException is thrown and message processing does not happen.
Microsoft.Azure.Amqp.AmqpException: Unauthorized access. 'Listen' claim(s) are required to perform this operation. Resource: 'sb://[redacted].servicebus.windows.net/[redacted]topic/subscriptions/[redacted]subscription'. TrackingId:70fbf78f5915496fba85866a3500aeb1_G28, SystemTracker:gateway10, Timestamp:2024-09-17T11:03:56
   at Microsoft.Azure.Amqp.ExceptionDispatcher.Throw(Exception exception)
   at Microsoft.Azure.Amqp.AsyncResult.End[TAsyncResult](IAsyncResult result)
   at Microsoft.Azure.Amqp.AmqpObject.OpenAsyncResult.End(IAsyncResult result)
   at Microsoft.Azure.Amqp.AmqpObject.EndOpen(IAsyncResult result)
   at Microsoft.Azure.Amqp.AmqpObject.<>c.<OpenAsync>b__53_1(IAsyncResult r)
   at System.Threading.Tasks.TaskFactory`1.FromAsyncCoreLogic(IAsyncResult iar, Func`2 endFunction, Action`1 endAction, Task`1 promise, Boolean requiresSynchronization)
--- End of stack trace from previous location ---
   at Azure.Messaging.ServiceBus.Amqp.AmqpConnectionScope.OpenAmqpObjectCoreAsync(AmqpObject target, String entityPath, Nullable`1 timeout, Nullable`1 cancellationToken)
   at Azure.Messaging.ServiceBus.Amqp.AmqpConnectionScope.OpenAmqpLinkAsync(AmqpLink link, String entityPath, CancellationToken cancellationToken)
   at Azure.Messaging.ServiceBus.Amqp.AmqpConnectionScope.OpenReceiverLinkAsync(String identifier, String entityPath, TimeSpan timeout, UInt32 prefetchCount, ServiceBusReceiveMode receiveMode, String sessionId, Boolean isSessionReceiver, CancellationToken cancellationToken)
   at Azure.Messaging.ServiceBus.Amqp.AmqpReceiver.OpenReceiverLinkAsync(TimeSpan timeout, UInt32 prefetchCount, ServiceBusReceiveMode receiveMode, String identifier, CancellationToken cancellationToken)

Reproduction Steps
See section "Describe the bug".
Environment
Visual Studio 17.11.0
λ dotnet --info
.NET SDK:
 Version:           8.0.400
 Commit:            36fe6dda56
 Workload version:  8.0.400-manifests.56cd0383
 MSBuild version:   17.11.3+0c8610977

Runtime environment:
 OS Name:     Windows
 OS Version:  10.0.22631
 OS Platform: Windows
 RID:         win-x64
 Base Path:   C:\Program Files\dotnet\sdk\8.0.400\

Hi @MarcusKohnert.  Thanks for reaching out and we regret that you're experiencing difficulties.  Unfortunately, the client has no insight nor influence over authorization; that is controlled entirely by the Service Bus service.  The maintainers of the Azure SDK are unable to assist with this issue.  We can only confirm that the link that you're opening is a receiving link for a subscription and the service is rejecting the auth.
To ensure that the Service Bus service team has visibility and can assist, your best path forward for would be to open an Azure support request.  If you'd prefer not to do so, the next best path would be to inquire on the Microsoft Q&A site, which is monitored by the service teams.
I'm going to close this out; if I've misunderstood what you're describing, please let us know in a comment and we'd be happy to assist as we're able.

Thanks very much for the update, @MarcusKohnert.   Hopefully, this will prove helpful for others who run into a similar issue in the future.


Export output is not immutable - tag re-ordering/auto generated ID's

Describe the bug
When using the export functionality of the provider, immediately re-running the export with no changes produces a different output for the same set of resources. Tag ordering is not respected and appears as "drift", and some resources (e.g. dynatrace_failure_detection_rules, dynatrace_process_monitoring_rule) have auto generated id's which change on each run.
This is important for checking existing configuration for drift against the known state. Just the tag ordering would be "OK" to deal with but the unique ID generated each time for the same resource is more challenging.
# output from first run
--resource "dynatrace_failure_detection_rules" "_52996642-a478-4a33-9ece-a12604324fca" {
name = "myfailuredetectionrule"
# output from second run
++resource "dynatrace_failure_detection_rules" "_76dc44b-0235-4ecc-b319-9caa8c15be1a" {
name = "myfailuredetectionrule"

To Reproduce
Steps to reproduce the behavior:

Export config.
Make commit in git repo
Re-run export
Observe new files (untracked changes) and re-ordering of tags.

Expected behavior
Export should provide immutable output.
Provider version - 1.26
Terraform version - 1.4.4
Platform - linux

Great! Thanks for the quick response :)


Implement the new API

This API aims to simplify usage and fix bugs (such as random_init being
set wrong) by removing as many arguments as possible from the API.
In the process, it makes using metaworld potentially much more
efficient.
However, this changes breaks the old API.
Prevent goal from being resampled on reset
Note that this should make the environments easier, since they're no
longer partially observable in a non-meta-learning sense.

In this PR, we spoke in detail about the random_init bug. Here is a furthered explanation of that bug, and how it affects all of the Metaworld ML benchmarks:
A typical Meta-rl Use case would be to

Sample task configurations from your task distribution.
Sample timesteps/trajectories from the sampled task configurations.
Once you have collected enough timesteps/trajectories from your task configurations [this is a hyperparameter] sample new tasks from your task distribution.

Before in our Meta Learning benchmarks, new task configurations would be sampled from the task distribution upon resetting your environment. This is bad for Meta-rl algorithms during train time because each new task that is sampled is effectively from a different MDP. This would lead Meta-RL algorithms to train on POMDPs, where the partially observable portion of the state was the task configuration of the environment being trained on. Furthermore during Meta adapt time, trajectories used for evaluation on new environments are supposed to be from the same task configuration, otherwise the same partial observability issues described previously happen here as well. It is well known that certain RL algorithms, particularly off-policy RL algorithms, struggle to solve POMDPs, so our update removes any biases against this class of algorithms.
In our most recent update, you manually sample task configurations and set your environments to use them by using the function “set_task”.


onLoad event

Is there a way to know when the new selected font has been loaded? In case of using a canvas for the rendering. Thanks!

Should FontFaceObserver be used?

This seems to work:
componentDidUpdate(prevProps, prevState) {
    if (prevState.activeFontFamily !== this.state.activeFontFamily) {
      const font = new FontFaceObserver(this.state.activeFontFamily);
      font.load().then(() => {
        console.log(`${this.state.activeFontFamily} has loaded`);
      }, () => {
        console.log(`${this.state.activeFontFamily} is not available`);
      });
    }
  }

it's not working for me lol


Add an option for context path

Hi,
it would be great, if this modul has an option to set the context path. For example, if i had the path example.com/stash/, I have to set the context path to /stash.

This update is now also pushed to the forge, closing this issue.

Thank you.

No problem, if you would not mind taking the time to rate this module on the forge. Any honest feedback I can get helps :)


DropTarget hover only fires when pointer hovers over the component, not the dragged item box

There is a line in docs which says:
hover(props, monitor, component): Optional. Called when an item is hovered over the component

But in my tests (with HTML5 backend) hover is only fired when mouse pointer hovers over the drop target component. I'd expect that any boundary of the item crossing drop target would trigger this event.
Looks like it is HTML5 API behavor, but is there any way to make hover behave as I described (and as described in docs)?
The use case I have is that I need to drag and drop relatively big items and dragging point is usually at item's header, so the user experience when moving such items up is OK, but moving down is a pain, because you often have to scroll the page to drop.

We have the same problem here. Is there a way ?

I need a solution on this as well.

@vladar @goldo @Gywem
have you found any solution?

@gaearon First, I'm sorry to bother you. Is there any solution for this situation?

@kafein  nope, juste using smaller elements to make it look nicer. Havent had time to try others things

@vladar I know it's an old thread but have you found a solution to this problem? Thx.

Anyone figured this out yet?

Hi there.. trying to figure this out as well.. any update?

any solution? Why it trigger only on mouse cursor?
Event onDragEnter must trigger on element, not mouse cursor
A dragged element enters the drop target
not A dragged element with MOUSE CURSOR enters the drop target


Transfer money to another user

[ ] Implementation of command
[ ] Check of sufficient balance and transfer of money


@conda-forge-admin, please add user @adambrazier

Additional comment:
No response

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added user @adambrazier in conda-forge/hop-client-feedstock#8.


Authentication failed Error on large files and no resume

rclone v1.33
Linux Fedora 23 64 bit
OneDrive
When filing an issue, please include the following information if
possible as well as a description of the problem.  Make sure you test
with the latest beta of rclone.
rclone copy local to remote
Log >>>
2016/10/23 22:06:24
Transferred:   210 MBytes (59.686 kBytes/s)
Errors:                 0
Checks:              1029
Transferred:            0
Elapsed time:    1h0m2.8s
Transferring:
 * ...dir/large_file.gz: 36% done. avg:   69.9, cur:    2.3 kByte/s. ETA: 45h28m38s

2016/10/23 22:07:24
Transferred:   210 MBytes (58.708 kBytes/s)
Errors:                 0
Checks:              1029
Transferred:            0
Elapsed time:    1h1m2.8s
Transferring:
 * ...dir/large_file.gz: 36% done. avg:   68.5, cur:    0.0 kByte/s. ETA: 2486h39m29s

2016/10/23 22:07:35 folder/dir/large_file.gz: Cancelling multipart upload
2016/10/23 22:07:37 remote: Saving new token in config file
2016/10/23 22:07:37 folder/dir/large_file.gz: Failed to copy: unauthenticated: Authentication failed
2016/10/23 22:07:37 folder/dir/large_file.gz: Removing failed copy
2016/10/23 22:07:37 folder/dir/large_file.gz: Failed to remove failed copy: invalidRequest: API not found
2016/10/23 22:07:37 folder/dir/next_file.gz: Size and modification time the same (differ by 0s, within tolerance 1s)
2016/10/23 22:07:37 folder/dir/next_file.gz: Unchanged skipping

I have a very slow and unstable internet connection. when I try to upload large files (>500MB ) I usually get  an Authentication Error after the file is being upload for a large period of time.
I guess this is because it takes so long the authentication tokens are invalid.
When this error occurs rclone reauthenticates but skip the file and does not resume the upload.
This is not only very frustrating (when it happens at 97%) but make it impossible to upload very large files (> 1,5G) since with my connection speed they will always eventually fail.
I'm not sure if onedrive (and other services) allows to re authenticate and continue the upload (or if it possible to somehow refresh the token before it happens) but it would be a great improvement to have.

Amazon Drive had the same problem which was fixed in 2ebeed67531263294542834ea8edc7bb14334b09
I can add the same fix to onedrive.
I should probably factor the logic out and stick it in oauthutil then use it in all the oauth based remotes...

I'm having the same issue with rclone 1.35 on OneDrive and large file uploads.

I've attempted to fix this here.  Please have a test and re-open the ticket if it doesn't work!
Thanks Nick
http://beta.rclone.org/v1.35-52-g7470255/ (uploaded in 15-30 mins)

I'm still seeing failures.
It seems like the token is being refreshed but the upload gets canceled -
ion time the same (differ by -759.707ms, within tolerance 1s)
2017/02/01 19:09:29 Pictures/872187382178.jpg: Unchanged skipping
2017/02/01 19:09:30 Documents/large_file.zip: Starting multipart upload
2017/02/01 19:09:31 Documents/large_file.zip: Uploading segment 0/1835489467 size 10485760
2017/02/01 19:11:39 Documents/large_file.zip: Uploading segment 10485760/1835489467 size 10485760
2017/02/01 19:13:49 Documents/large_file.zip: Uploading segment 20971520/1835489467 size 10485760
2017/02/01 19:16:04 Documents/large_file.zip: Uploading segment 31457280/1835489467 size 10485760
2017/02/01 19:18:15 Documents/large_file.zip: Uploading segment 41943040/1835489467 size 10485760
2017/02/01 19:20:26 Documents/large_file.zip: Uploading segment 52428800/1835489467 size 10485760
2017/02/01 19:22:34 Documents/large_file.zip: Uploading segment 62914560/1835489467 size 10485760
2017/02/01 19:24:42 Documents/large_file.zip: Uploading segment 73400320/1835489467 size 10485760
2017/02/01 19:26:50 Documents/large_file.zip: Uploading segment 83886080/1835489467 size 10485760
2017/02/01 19:28:58 Documents/large_file.zip: Uploading segment 94371840/1835489467 size 10485760
2017/02/01 19:31:06 Documents/large_file.zip: Uploading segment 104857600/1835489467 size 10485760
2017/02/01 19:33:15 Documents/large_file.zip: Uploading segment 115343360/1835489467 size 10485760
2017/02/01 19:35:23 Documents/large_file.zip: Uploading segment 125829120/1835489467 size 10485760
2017/02/01 19:37:31 Documents/large_file.zip: Uploading segment 136314880/1835489467 size 10485760
2017/02/01 19:39:43 Documents/large_file.zip: Uploading segment 146800640/1835489467 size 10485760
2017/02/01 19:41:52 Documents/large_file.zip: Uploading segment 157286400/1835489467 size 10485760
2017/02/01 19:44:01 Documents/large_file.zip: Uploading segment 167772160/1835489467 size 10485760
2017/02/01 19:46:12 Documents/large_file.zip: Uploading segment 178257920/1835489467 size 10485760
2017/02/01 19:48:25 Documents/large_file.zip: Uploading segment 188743680/1835489467 size 10485760
2017/02/01 19:50:38 Documents/large_file.zip: Uploading segment 199229440/1835489467 size 10485760
2017/02/01 19:52:48 Documents/large_file.zip: Uploading segment 209715200/1835489467 size 10485760
2017/02/01 19:54:59 Documents/large_file.zip: Uploading segment 220200960/1835489467 size 10485760
2017/02/01 19:57:14 Documents/large_file.zip: Uploading segment 230686720/1835489467 size 10485760
2017/02/01 19:59:36 Documents/large_file.zip: Uploading segment 241172480/1835489467 size 10485760
2017/02/01 20:01:42 One drive root 'backup/Private': Token expired - 1 uploads in progress - refreshing
2017/02/01 20:01:45 remote: Saved new token in config file
2017/02/01 20:01:57 One drive root 'backup/Private': Token refresh successful
2017/02/01 20:02:30 Documents/large_file.zip: Cancelling multipart upload
2017/02/01 20:02:31 Documents/folder/combo(27): Size and modification time the same (differ by 0s, within tolerance 1s)
2017/02/01 20:02:31 Documents/folder/combo(27): Unchanged skipping

I'm not sure what changed but I had at least one time where upload was successful after a token update -
2017/02/01 11:57:41 Pictures/IMG_20031012_112515.jpg: Unchanged skipping
2017/02/01 11:57:42 Pictures/large_video.mp4: Uploading segment 0/314967484 size 10485760
2017/02/01 11:59:50 Pictures/large_video.mp4: Uploading segment 10485760/314967484 size 10485760
2017/02/01 12:01:58 Pictures/large_video.mp4: Uploading segment 20971520/314967484 size 10485760
2017/02/01 12:04:05 Pictures/large_video.mp4: Uploading segment 31457280/314967484 size 10485760
2017/02/01 12:06:13 Pictures/large_video.mp4: Uploading segment 41943040/314967484 size 10485760
2017/02/01 12:08:22 Pictures/large_video.mp4: Uploading segment 52428800/314967484 size 10485760
2017/02/01 12:10:30 Pictures/large_video.mp4: Uploading segment 62914560/314967484 size 10485760
2017/02/01 12:12:38 Pictures/large_video.mp4: Uploading segment 73400320/314967484 size 10485760
2017/02/01 12:14:46 Pictures/large_video.mp4: Uploading segment 83886080/314967484 size 10485760
2017/02/01 12:16:54 Pictures/large_video.mp4: Uploading segment 94371840/314967484 size 10485760
2017/02/01 12:19:03 Pictures/large_video.mp4: Uploading segment 104857600/314967484 size 10485760
2017/02/01 12:21:11 Pictures/large_video.mp4: Uploading segment 115343360/314967484 size 10485760
2017/02/01 12:23:19 Pictures/large_video.mp4: Uploading segment 125829120/314967484 size 10485760
2017/02/01 12:25:27 Pictures/large_video.mp4: Uploading segment 136314880/314967484 size 10485760
2017/02/01 12:27:35 Pictures/large_video.mp4: Uploading segment 146800640/314967484 size 10485760
2017/02/01 12:29:44 Pictures/large_video.mp4: Uploading segment 157286400/314967484 size 10485760
2017/02/01 12:31:52 Pictures/large_video.mp4: Uploading segment 167772160/314967484 size 10485760
2017/02/01 12:34:00 Pictures/large_video.mp4: Uploading segment 178257920/314967484 size 10485760
2017/02/01 12:36:08 Pictures/large_video.mp4: Uploading segment 188743680/314967484 size 10485760
2017/02/01 12:38:16 Pictures/large_video.mp4: Uploading segment 199229440/314967484 size 10485760
2017/02/01 12:40:24 Pictures/large_video.mp4: Uploading segment 209715200/314967484 size 10485760
2017/02/01 12:42:32 Pictures/large_video.mp4: Uploading segment 220200960/314967484 size 10485760
2017/02/01 12:44:40 Pictures/large_video.mp4: Uploading segment 230686720/314967484 size 10485760
2017/02/01 12:46:48 Pictures/large_video.mp4: Uploading segment 241172480/314967484 size 10485760
2017/02/01 12:48:56 Pictures/large_video.mp4: Uploading segment 251658240/314967484 size 10485760
2017/02/01 12:48:57 remote: Saved new token in config file
2017/02/01 12:51:05 Pictures/large_video.mp4: Uploading segment 262144000/314967484 size 10485760
2017/02/01 12:53:13 Pictures/large_video.mp4: Uploading segment 272629760/314967484 size 10485760
2017/02/01 12:55:21 Pictures/large_video.mp4: Uploading segment 283115520/314967484 size 10485760
2017/02/01 12:57:29 Pictures/large_video.mp4: Uploading segment 293601280/314967484 size 10485760
2017/02/01 12:59:37 Pictures/large_video.mp4: Uploading segment 304087040/314967484 size 10485760
2017/02/01 13:01:45 Pictures/large_video.mp4: Uploading segment 314572800/314967484 size 394684
2017/02/01 13:01:52 Pictures/large_video.mp4: Copied (new)
2017/02/01 13:01:52 Pictures/IMG_20031109_032756.jpg: Size and modification time the same (differ by -135.876ms, within tolerance 1s)
2017/02/01 13:01:52 Pictures/IMG_20031109_032756.jpg: Unchanged skipping

OK I'll look at this some more...

Ok I think I figured it out.
It seems like if uploading a part started but token has expired during the upload one drive will reject the part since the token is expired this error will stop the upload from being retried and the multipart session will be destroyed.
I submited a pull request but its my first time writing go code so there might be some improvements.
Instead of only checking the error code I'm checking that the error explicitly mention the token is expired I guess this can be simplified by retrying on any 401 error but then if the auth has a more serious error it will take it longer to fail.
I also found a bug that upload will not be able to actually retried since after the first attempt the Reader index will be at the end of the buffer and it need to be reseted

@yonjah 's change has been merged now which should fix this issue - find it here:
https://beta.rclone.org/v1.36-13-gd1787b5/ (uploaded in 15-30 mins)
Thank you very much @yonjah for fixing this.


Add metadata to the .md files

It would be nice to add 'frontmatter' metadata (e.g. version and date) to the version details .md files if possible. (See the link to Gatsby docs).

Sure! Any proposal on what it should look like?
I agree version and publish date should be a must but we can add more stuff if needed.


Handle "native" dependencies

This was edited by @SeanTAllen:
This started as an idea to use vcpkg from @damon-kwok.

https://github.com/Microsoft/vcpkg
Microsoft's vcpkg provides cross-platform c/c++ library installation. It works well with pony ffi.

It has since expanded into a conversation for handling native dependencies.

I think corral's support for vcpkg only needs to include its lib file directory in the search path, so that users do not need to fill in the full path.

Corral doesn't have anything to do with c/c++ library installation. Rather than have an issue for this, I think it is important to first decide if and how we want to approach non-pony dependencies with corral.
@kulibali have you given any thought to non-pony dependencies and corral?

I haven't played with vcpkg any. I'm a bit hesitant to introduce an external dependency to corral. My tentative plan, which I swear I'm going to get around to any time now, is to introduce the ability to download binaries and put them in the PONY_PATH. The use case is merely to get the crypto and ssl libraries working on windows so that I can get ponyup working.

@kulibali any thoughts on how to do in a distro/OS dependent way?

The idea would be to have a section in corral.json like "libs": { "windows": { "bin": "foo.dll", "url": "https:foo.zip" }, "linux": {...} } and then corral would uncompress the archive, find the required bin file, and add the directory it's in to PONY_PATH.

There are many compilers and distro/OS, and the burden of precompilation can be heavy. Provide the source address, using CORRAL to call VC GCC clang in local compilation, it can minimize the burden, maximum compatibility. There are many libraries that offer a number of options that users may want to tap into the compilation process.

@kulibali I think "linux" isn't expansive enough given the desire folks might have to use a package manager etc.

There are many compilers and distro/OS, and the burden of precompilation can be heavy. Provide the source address, using CORRAL to call VC GCC clang in local compilation, it can minimize the burden, maximum compatibility. There are many libraries that offer a number of options that users may want to tap into the compilation process.

It's unclear to me what you are suggesting.

Can anyone comment on what Rust's cargo does for this?

Simply put, I don't think Corral needs to provide precompiled files for users to download. We can learn from the treatment of VCPKG. It simply provides the source code address and the script for the compilation process. Even so, this is a lot of work, so at this stage we can choose to use VCPKG directly. When I ran "VCPKG install openssl", I found the experience great and it worked well on non-Windows systems

What does " Corral needs to provide precompiled files for users to download" mean to you? I don't think anyone has suggested that Corral provides the libraries. Rather it can allow for them to be installed. Is that what you mean?

I saw that Cargo didn't do a good job of that. It just used the library that came with the system. But I have noticed that the Rust ecosystem thrives, for example if you want to use MongoDB, the MongoDB team provides the Rust driver, so FFI is always an alternative to the Rust. So FFI is more important for Pony.

I saw that Cargo didn't do a good job of that.

Didn't do a good job of what @damon-kwok ?

Corral needs to provide precompiled files for users to download"

I mean there's a lot of work involved in providing pre-compiled binaries.

I saw that Cargo didn't do a good job of that.

Cargo has provided no additional support for this

I saw that Cargo didn't do a good job of that.

Cargo has provided no additional support for this

What is "this"?

Caogo hasn't done anything, but can we do better

Corral needs to provide precompiled files for users to download"

I mean there's a lot of work involved in providing pre-compiled binaries.

You keep saying "provided". No one has suggested that we provide any precompiled binaries. Rather there is a question of "should we make it possible for people to use corral to install precompiled binaries".

We discussed this during the sync call today (July 7, 2020 if you want to refer to it once uploaded).
General thoughts:
After Theo mentioned how cargo handles (he will be detailing later), we think "that's eh" but we don't have better ideas.
We think that allowing the usage of tools like brew, apt etc to install packages would be very difficult. Many package managers don't allow you to select a version and for a specific release of code that uses a foreign library, that would be problematic. Supporting installation via package manager seems very unlikely.
Allowing for corral in some fashion to download and build libraries from source and then install them in a pony specific fashion however, seems doable and something we want to look into more as a first step.
What that means as a first step needs to be determined further.

Yes, I may have misunderstood the sentence:

The idea would be to have a section in corral.json like "libs": { "windows": { "bin": "foo.dll", "url": "https:foo.zip" }, "linux": {...} } and then corral would uncompress the archive, find the required bin file, and add the directory it's in to PONY_PATH.

Allowing for corral in some fashion to download and build libraries from source and then install them in a pony specific fashion however, seems doable and something we want to look into more as a first step.

This is the right approach. the first thing we need to do is to determine the format of the description file, which contains the platform-wide compilation process script.

It occurs to me that since we already have the pattern of including a Makefile and make.ps1 in library project to do things like testing, we could have Corral call that (perhaps with a special target thirdparty or something) if present, and then the Makefile would get and compile the external libs and put them in the directory that Corral is going to add to PONY_PATH.

I want to get away from using Makefiles. I'd like to roll all that functionality into corral.


Tye CLI not accessible in Terminal on M1 macOS

I install the latest CI-build of Tye on an M1 Mac, but when entering the command it cannot be found.
When running ./tyefrom the ~/.dotnet/toolsdirectory it works.
It seem it has been added to the $PATH It seems like ~ does not expand. (https://github.com/dotnet/sdk/issues/9415)
I have reinstalled the tools but no luck.
/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/share/dotnet:~/.dotnet/tools:/Library/Apple/usr/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands

robert@Roberts-MBP-2 tools % dotnet --list-sdks
3.0.103 [/usr/local/share/dotnet/sdk]
3.1.408 [/usr/local/share/dotnet/sdk]
5.0.202 [/usr/local/share/dotnet/sdk]

robert@Roberts-MBP-2 tools % ls -la
total 520
drwxr-xr-x   5 robert  staff     160 May  6 09:12 .
drwxr-xr-x  19 robert  staff     608 May  5 15:06 ..
drwxr-xr-x   5 robert  staff     160 May  6 09:12 .store
-rwxr--r--   1 robert  staff  165976 Feb 11 18:44 dotnet-format
-rwxr-xr-x   1 robert  staff   95244 May  6 09:12 tye

My workaround it to put this in ~/.zshrc:
export PATH=$HOME/.dotnet/tools:$PATH

@philliphoff did you see this when you were using tye on your M1?

To be honest, I don't recall.  That said, I do have this in my .zprofile:
# Add Tye to PATH.
export PATH="$PATH:/Users/<user>/.dotnet/tools"

I have to imagine that I added it myself, given the other items/comments in the file.  Anyway, I know I've had trouble in the past with using ~/ as part of paths in PATH.  Looking at my PATH, I see both ~/.dotnet/tools as well as the path I added via my .zprofile.  I'm not sure where ~/.dotnet/tools came from; I don't see another shell configuration file with that anywhere.


Fix packet reassembly

@Loghorn thanks for submitting!
I understand the changes, just curious as to what type of setup you were seeing the issues with? (USB adapter, peripheral used etc)

I found the issue with a USB adapter. While debugging I found that the packets were correct at first, then became misaligned, so I implemented this fix. However, after testing it, I found that the problem was that some packet from the USB were missing and this caused the actual misalignment (I suspect there is an issue with the USB controller, because using the same adapter in another port works fine).
Anyway, I thought that sending the PR with the fix was worth it, in case someone has a USB adapter that sends data in odd ways :smile:

@sandeepmistry I've seen this issue on a linux embedded device using an external USB Bluetooth dongle. The old reassembly code expected HCI events data to terminate in mid of packet or at the exact end of a packet. It's a weak assumption, since lower lever reassembly can cause 2 packets to be merged in a single HCI event data buffer. If it happens, the entire stream reassembly is broken forever. The hardware I've seen it happen is an RK3288 ARM device.

@Loghorn thanks!

@bragma were you using node-hci-socket is USB mode? By default on Linux is uses kernel mode, and does not use the fine @Loghorn modified.

@sandeepmistry yes I was forcing USB mode because I needed to test an external USB BT Dongle without kernel driver support.

@bragma ok, let us know if this change helps :)


Please make download links for SQL as Parameter

Hi guys,
can we put the link for the download source for SQL Server 2014 as a Parameter with Default value.
Here in my demolap for Azure Stack I don't have a big Internet Connection and a deployment takes along time, if I must download the files from the Internet. The template for SharePoint have a optional Source Parameter and I can but the source in my local Blob storage.
UPDATE
Please edit the SharePoint template also, because if I use my custom link on my local blob storage, it want a trusted Connection to the https URL on my blob storage. This means you can't deploy SharePoint if you use your own private blobstorage....
To do this you must for example by the DSC Config for SQL Server 2014 in the file xDownloadISO.psm1 insert a line befor line 50 with this content:
[System.Net.ServicePointManager]::ServerCertificateValidationCallback = {$true}
and after line line 51 a line with this content:
[System.Net.ServicePointManager]::ServerCertificateValidationCallback = null
more Information here
This will ignor the untrusted connection. I think the best way to make the DSC secure also, is to add a parameter that ask if you download source is untrusted.

@paule96 Thx for your feedback. Can you please submit a pull request with your proposed code. Thanks!

Inactive, closing issue. @paule96 if this issue is still active, please open an new issue and reference this one. Thanks.


json-api-client breaks serialization when working with associations

Detailed description
Given I have Items
PostItem and CategoryItem
PostItem has_one Category
I want to patch Post and unassign category relationship
$post = new PostItem();
$post->setId($postId);
$post->category()->associate(null);
$post->save(); // uses repository under the hood

I expect such payload to be generated by json-api-client
{"data":{"id":"1","type":"posts","relationships":{"category":{"data": null},"attributes":{}}}

Actual behaviour
{"data":{"id":"1","type":"posts","relationships":{"category":{"data":{"type":"categories","id":null}}},"attributes":{"category_id": null}}}

so 1 issue here
attributes are populated with category_id value , but post doesn't have it.
also 1 notice
category relashionship data can have {"data": null } object instead of {"data":{"type":"categories","id":null}
possible bug is in this line https://github.com/swisnl/json-api-client/blame/7a0005837dc49c1723b8a1cd57a98653198bf531/src/Relations/HasOneRelation.php#L37
I do not know why such implementation exists but seems it is not by jsonapi spec

Yeah this seems off-spec indeed. It should be null as per spec


How can I use Aedes as MQTT Borker?

Hello,
how can I use aedes as MQTT broker?
I installed aedes on Ubuntu, but I dont know how  and where can I create a Broker an how can I Use it? could you please help me and explain more how can I do it!
Best Regards
Mohsen

Aedes api has demo.you can try it.
https://github.com/mcollina/aedes

you can run aedes as your broker in node js simply with npm and then you can build some clients with any kind of mqtt client libs such as npm mqtt

@mohsenyaghoobi take a look at this sample project: https://github.com/sombriks/sample-mqtt


Support rendering openapi and swagger documents

Continuation of https://github.com/go-gitea/gitea/pull/25824
Fixes: #20852
Current status: working in iframe, but I am considering moving it to first-party code as the current security attributes are already essentially the same as first-party code.

@lunny feel free to push here of course :)

If we could pass the yaml/json into the iframe HTML, we could do away with allow-same-origin attribute on both iframe and render. I think this is the solution to strife for as it will be sufficiently secure.

Essentially we just need to encode the json/yaml into data-source here

To clarify, before the page is rendered, go would fetch the yaml or js from the file contents (up to some reasonable size limit to ensure that memory isn't fully consumed), set the contents as a template variable and then insert it into the attribute that you linked? And the iframe and such would still be used, but the allow-same-origin could be removed since it's not doing an additional HTTP call?
If yes, I think that's probably doable.

Essentially we just need to encode the json/yaml into data-source here

To clarify, before the page is rendered, go would fetch the yaml or js from the file contents (up to some reasonable size limit to ensure that memory isn't fully consumed), set the contents as a template variable and then insert it into the attribute that you linked? And the iframe and such would still be used, but the allow-same-origin could be removed since it's not doing an additional HTTP call?
If yes, I think that's probably doable.

Yes, with the yaml/json passed into the iframe HTML, we avoid having to deal with CORS because no more fetch request is done from the iframe.
BTW, If I remove the allow-same-origin now, I get this:

@wxiaoguang maybe you can help me with the backend part described in https://github.com/go-gitea/gitea/pull/26802#issuecomment-1698065682. This PR is otherwise ready and working but I would really like to eliminate this fetch request and the insecure iframe allow-same-origin sandbox attribute.

I guess I wouldn't have enough time to look into it soon (maybe I could try before 1.23 freezing).
Some of my thoughts:

Maybe it could use "postMessage" to communicate, then no CORS trick is needed.
Be careful about the changed renderer behavior to avoid XSS problems.

Maybe it could use "postMessage" to communicate, then no CORS trick is needed.

Hmm yes, postMessage from parent to child window could work. Still I would prefer the render variant I guess.


Upgrades to React 18 and fixes minor bugs

Will need to test this tomorrow with my local install. I have built everything and things seem to work. There are new files created that aren't commited in this PR:
kirki-packages/field-dimensions/dist/preview.css
kirki-packages/field-dimensions/dist/preview.css.map

Also, I have not commited changes to the dist files so I don't clutter this up until after testing.

@wprashed Hi, I am trying to get some feedback on this PR and/or figure out what the next steps are. Is there someone to contact at themum and/or are you guys still developing this? It seems like the<EMAIL_ADDRESS>is dead or unused at this point. Please advice. Thanks.


Changed background color of footer to full-width

Changed the background color to 100% width.

Great work!!
Kudos
Keep contributing and don't forget to star the repo it will help the other contributors as well.


[stable/prometheus] Add customized readiness/liveness probe config

Updated templates/server-deployment.yaml and templates/server-statefulset.yaml to use configurable initialDelaySeconds and timeoutSeconds in readinessProbe/livenessProbe
Updated chart version 9.1.3
Updated values.yaml

Signed-off-by: Tuan Anh Nguyen<EMAIL_ADDRESS>Is this a new chart
No
What this PR does / why we need it:
Prometheus server with a large dataset can take some time to start up (in our case up to 3 minutes), it is nice to have a configurable initialDelaySeconds for the readiness probe to increase the value accordingly.
The timeout values are not required to be configurable in our case, but I hope it might be useful for other to not have the 30 seconds hard-coded in the template.
Which issue this PR fixes
N/A
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

/retest

/test pull-charts-e2e


No output from proxy

This looks related to https://github.com/nidi3/raml-tester-proxy/issues/22.
The problem is, as I saw in the above issue that file:// urls are problematic, I used python -m SimpleHTTPServer to start a local server. Then I started the proxy with this server, and it loaded the RAML definitions (I saw that it reqeuested the included files), but it's still neither answering any requests  nor producing any log output. It just created an empty directory for the logs, nothing more.
Here's the full command line and output (note that these lines starting with <IP_ADDRESS> come from the Python server, not the raml-proxy):
$ raml-tester -rhttp://localhost:8000/topics/topics.raml -thttp://localhost:7770 -saaa -ftext
17:25:56.391 INFO  - g.n.ramlproxy.report.Reporter : Reporting in TEXT format into: aaa
<IP_ADDRESS> - - [27/Jul/2015 17:25:56] "GET /topics/topics.raml HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Jul/2015 17:25:57] "GET /topics/../include/resourceTypes/collection.yaml HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Jul/2015 17:25:57] "GET /topics/../include/resourceTypes/collection-item.yaml HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Jul/2015 17:25:57] "GET /topics/../include/resourceTypes/readonly-collection.yaml HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Jul/2015 17:25:57] "GET /topics/../include/resourceTypes/readonly-collection-item.yaml HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Jul/2015 17:25:57] "GET /topics/../include/resourceTypes/writeonly-collection.yaml HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Jul/2015 17:25:57] "GET /topics/../include/resourceTypes/writeonly-collection-item.yaml HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Jul/2015 17:25:57] "GET /topics/../include/traits/orderable.yaml HTTP/1.1" 200 -
<IP_ADDRESS> - - [27/Jul/2015 17:25:57] "GET /topics/../include/traits/pageable.yaml HTTP/1.1" 200 -
17:25:57.951 INFO  - g.nidi.ramlproxy.ProxyServlet : Proxy started

^C

I'm using version 0.0.4 from npm (https://github.com/nidi3/raml-tester-js).

I think the problem in #22 is a missing baseUri definition in the RAML. Could this also be your case?
Anyways, 0.0.4 is a very old release.
I'm going to release a new one based on raml-tester 0.8.2 which should log any occurring problems.

Ok, there's a new version 0.8.3, can you try with it?

Looks like fixed. I get responses from the proxy and I see the logs in the console. Thanks.


feat(RingTheory/TwoSidedIdeal): add lattice structure to two-sided-ideals

I didn't use Function.Injective.completeLattice is to avoid instance diamond between SetLike.instPartialOrder and CompleteLattice.instPartialOrder

I am busy until Wednesday, but I can have a look later.

I am busy until Wednesday, but I can have a look later.

No rush! Thank you very much!

I have a big question: why aren't we just pulling the entire CompleteLattice structure (aside from the LE, which comes via the SetLike instance) through the order isomorphism all at once? Is that not easily doable?

I have a big question: why aren't we just pulling the entire CompleteLattice structure (aside from the LE, which comes via the SetLike instance) through the order isomorphism all at once? Is that not easily doable?

Because pulling back the order of ringcon results in a diamond: the “smaller than” from the pulling back is not definitionally equal to that from setlike instance

Right, but I'm talking about leaving the existing order alone and pulling the rest back.

Sounds like we want a CompleteLattice.replacePartialOrder declaration marked as reducible for things like this. But that's for a separate PR, so I'll leave this alone.

I addressed the comment directed at Eric (I think satisfactorily), and given that there are two other approving reviews:
bors merge


Issues with zmq

I am using PUSH/PULL for sending data to multiple terminals at different ports. Here are the sender and receiver codes:
When the number of pull receivers increase the sender codes crash with the following errors:
SENDER SIDE:
def create_push_socket(self, ip, port):
  # print('PUB')
  context = zmq.Context()
  socket = context.socket(zmq.PUSH)
  socket.setsockopt(zmq.LINGER, 1000)
  socket.setsockopt(zmq.SNDTIMEO, 1000)
  socket.setsockopt(zmq.SNDHWM, 0)
  zmq_address = "tcp://{}:{}".format(ip, port)
  socket.connect(zmq_address)
  return socket
objectname=create_push_socket('<IP_ADDRESS>',7001)
objectname.send_json(str(data))

RECEIVER SIDE
def __init__(self):
  contextx = zmq.Context()
  self.subsocket = contextx.socket(zmq.PULL)
  self.subsocket.setsockopt(zmq.LINGER, 1000)
  self.subsocket.setsockopt(zmq.RCVTIMEO, 1000)
  self.subsocket.setsockopt(zmq.RCVHWM, 1000)
  self.subsocket.bind("tcp://<IP_ADDRESS>:7001")
  pass

x= json.loads(self.subsocket.recv_json())

Segmentation fault, core dumped.
Invalid Pointer
Resource Temporarily unavailable
Assertion failed
Exception in thread
double free or corruption out
Bad adress
Aborted (core dumped)

version :-
python =3.8.0
zmq=22.0.3
ubantu= 20.04
I am using UBUNTU 20.04 OS and tried libtcmalloc and many other things but unable to solve the error. When number of pull receivers are low then the frequency of crash decreases.

Do you have a complete example? This isn't enough information to reproduce an error. How has pyzmq been installed? Are there any additional processes or threads being used?

I am using PUSH/PULL for sending data to multiple terminals at different ports. Here are the sender and receiver codes:
When the number of pull receivers increase the sender codes crash with the following errors:
SENDER SIDE:
def create_push_socket(self, ip, port):
  # print('PUB')
  context = zmq.Context()
  socket = context.socket(zmq.PUSH)
  socket.setsockopt(zmq.LINGER, 1000)
  socket.setsockopt(zmq.SNDTIMEO, 1000)
  socket.setsockopt(zmq.SNDHWM, 0)
  zmq_address = "tcp://{}:{}".format(ip, port)
  socket.connect(zmq_address)
  return socket
objectname=create_push_socket('<IP_ADDRESS>',7001)
objectname.send_json(str(data))

RECEIVER SIDE
def __init__(self):
  contextx = zmq.Context()
  self.subsocket = contextx.socket(zmq.PULL)
  self.subsocket.setsockopt(zmq.LINGER, 1000)
  self.subsocket.setsockopt(zmq.RCVTIMEO, 1000)
  self.subsocket.setsockopt(zmq.RCVHWM, 1000)
  self.subsocket.bind("tcp://<IP_ADDRESS>:7001")
  pass

x= json.loads(self.subsocket.recv_json())

Segmentation fault, core dumped.
Invalid Pointer
Resource Temporarily unavailable
Assertion failed
Exception in thread
double free or corruption out
Bad adress
Aborted (core dumped)

version :- python =3.8.0 zmq=22.0.3 ubantu= 20.04
I am using UBUNTU 20.04 OS and tried libtcmalloc and many other things but unable to solve the error. When number of pull receivers are low then the frequency of crash decreases.

Hello, what are the meanings of the following please?
  socket.setsockopt(zmq.LINGER, 1000)
  socket.setsockopt(zmq.SNDTIMEO, 1000)
  socket.setsockopt(zmq.SNDHWM, 0)


Translated slug not always used in the page address

I have a multilingual site with 2 languages. I have the following setup
/en/services
/nl/diensten
the foldername is services so the translated slug for nl is diensten
The problem occurs when I am on /en/services and switch to NL. Than the url in the address bar says /nl/services instead of /nl/diensten
Also, that url is a valid url (which in my opinion shouldn't because it has the url /nl/diensten
Is this a bug?

Redirect default route seems to fix this, but I do not exactly understand it. Can someone elaborate?

It's really due to the way multilang is designed. Only one language is loaded at a time for performance reason.  The trade-off is that when in one language you really can't see the custom slugs of other languages. Check this thread for more details:
https://github.com/getgrav/grav/issues/1226


Add Singleton Module.

One way to define a singleton right now is this:
class Foo
  INSTANCE = Foo.new
end

Foo::INSTANCE

This will instantiate Foo if the instance is referred to, at the beginning of the program. No need for a mutex. The only drawback is that it will be instantiated before it's referred to, but I don't think that's a big problem...

It actually is for some usecases, especially around establishing external connections and such.

Initializing a singleton is at start is a problem.
subprogram.cr:
  require "giant_framework" # (rails with activerecord)
  # ActiveRecord.connection_pool is automatically established.
  # Not a big deal, except for Exceptions thrown if db connections fail.

  do_something_without_activerecord_but_lots_of_other_framework_dependencies

A command that would normally work now has extra dependencies and startup cost.  If the singleton isn't initialized on start and isn't referenced elsewhere the compiler may strip it out correct?

instance? in this module conditionally returns the singleton without instantiating a new object.  This is useful for cleanup routines.
Close db or other connections cleanly.
at_exit { Foo.instance?.try &.close }

There's already code in the tree that uses the singleton pattern.  See the most recent commit in this branch.

@asterite The mutex is single use and only exists for future thread compatibility.  I think new code going in to the tree should be thread safe or at least annotate threading issues.

We might accept this, but I need to review it with @waj

The thread safety alone makes it worthwile.

I left a comment. Please fix that, rebase, and we'll merge this. Thanks!

@asterite rebase complete.

Could you please add parentheses to enclose def arguments? Not only because it's the style used by the standard library, but also because we are going to remove that possibility.

I like the idea of having the Singleton module but I still wont use it everywhere. The SignalHandler for example instantiates anyway on every program at startup, so there is no need to delay its initialization.

@asterite parentheses added.

@waj The purpose of using the Singleton module in SignalHandler is not to delay startup but to a) document that this is a singleton, b) provide a standard interface to all singletons rather than custom interfaces for various singletons and c) aid in grepping for singletons.  a) b) and c) should make it easier to transition to actors if that is ever approved.

Shouldn't the SignalHandler use the Singleton.instance method to build the instance? Because it is overriden since it was not removed wrt base implementation.

But SignalHandler is an internal class and is not documented. Also, you don't need to document how the singleton is implemented. Now every access to the SignalHandler have to check if the @instance variable is nil before calling. That plus the unnecessary mutex probably adds a negligible overhead, but still... you know, I'd like to be obsessive about performance specially within the low level or runtime stuff.
I'd love to have actors too, but I don't think I'd use them for internals.

I like the idea of preparing for possible actors.
@waj - wouldn't you cache the instance in a variable in most accessing code?
@technorama - couldn't the check for non-nil instance be done before mutex'ing - if it's already set - no mutex is needed, otherwise it syncs and re-tests for that first possible race condition. (provided the whole instance data assign can be made atomic, so one doesn't return just a type-number and the actual instance pointer not being set yet...)
I don't know how the mutex is implemented to be honest - maybe it just relies on an atomic flag, so this thought is moot to begin with?
Don't mind me on this matter - just juggling some thoughts.

@waj There is no performance concern.  How often would a signal handler be added or removed?  At most once or twice per signal or maybe after forking.
Actors for internals standardizes failure cases and restart behavior.  It also documents what the component is, how it runs, what other actors it depends on the component (SignalChildHandler probably).  You can even make pretty diagrams of actors automatically by parsing the source code.

@ozra Atomic assign can't be used, only a mutex will work.  You could end up with multiple instantiations and the last atomic assign would "win".  There would still be other objects instantiated during the race period possibly with references to them.

@bcardiff I removed the old instance method.

@waj I think it's beneficial to have a single implementation of the singleton pattern rather than many different patterns scattered everywhere.  grep will help you identify Singletons but only if they use the same module and/or interface.  When thread safety becomes an issue you can more easily identify concurrency problems as singletons implicitly indicate a shared resource that should be scrutinized.

@waj If you'd like me to split Singleton in to a "instant" singleton (no mutex and no nil, created at startup) and "on demand" singleton (mutex, nil checking, created on demand) I can do that.
Either way I think it's better to have a simple controlled module(s) where bugs can be identified and fixed.  Not having a Singleton pattern puts us in the java space where everyone implemented their own singleton pattern often incorrectly when it came to thread safety.
https://stackoverflow.com/questions/1625118/java-double-checked-locking

@tecnorama - ah, yeah the idea was, iff atomic assign is possible for the entire instance:
# pseudo
if instance == nil  # if the synced assign is atomic - then non nil == fully ok val to return
  synchronize => instance ||= new  # sync is only used when instance is nil - to avoid race
end
return instance

Again, I like the Singleton module and I want it in the standard library. I just wont use it for internal runtime stuff. Just let it be for end users of the language. I'd probably even make the SignalHandler a module and use class variables (there is a mix of class and instance variables right now that I'm not sure if it was intentional).
Anyway, something much more important: the current implementation is broken. Well... actually Mutex is broken, because they lock forever when synchronizing from the same fiber. Maybe #1612 can be used to fix this? I don't think so... this might need some more work because we need it to play nice with fibers on a single thread before moving to multiple threads.
This example hangs forever and never print anything:
class Foo
  include Singleton

  def initialize
    sleep 1
  end
end

spawn { puts Foo.instance }
spawn { puts Foo.instance }

sleep 5

Maybe I should open a separate issue for this, but basically the Mutex#syncrhonize would need to try_lock and if it fails, the current fiber must be saved in a queue and reschedule while unlocking, plus some minor details that I'm probably omitting right now. Is there any other way around this problem?

2 solutions:

#1612 using a recursive mutex.
Implement Monitor like functionality from ruby.  I believe jhass has a working implementation in debot.

No, my Monitor there actually is just the convenience pairing of a Mutex and a ConditionVariable.

@waj I have your example working.  See FiberSafeMutex in my most recent commit.  Consider it a WIP.  I can leave it here when it's ready (it's not, needs documentation) or put it in a separate PR.

Hi there, I just wanted to let you know that I've put FiberSafeMutex (thanks @technorama!) on a shard here: https://github.com/gtramontina/fiber-safe-mutex.cr to be used/battle-proofed until this or #1612 get merged. I needed something like this as I have another shard I'm working on that is very IO (console) intensive and I was having all sorts of crazy output when moving the cursor around.

I'll close this for now. This deals with core concurrency details and we'd like to define those, mostly to have a consistent style in the whole implementation.

@technorama We'll probably final add a fiber-safe mutex, although it will be called just Mutex. The code is here. It's based on yours but with a few bug fixes, thanks to some specs. So thank you for the initial code :-)


Bundle build paths

Includes extra commit since that PR adds applications that could use the build paths also.
@johnsca, @wallyworld: This is what I've got going to solve https://github.com/juju/charm-tools/issues/513, along with https://github.com/knkski/rust-libjuju. Should probably get everyone on board before merging this, so bikeshed away.

I'm not particularly liking having the path to the charm source in the bundle, since it will remain after deploying and is specific to your environment.  For example, my directory structure is ~/juju-charms/{charms,bundles} so your relative paths wouldn't work for me.
We already have charm build environment variables defined for CHARM_BUILD_DIR, CHARM_LAYERS_DIR, and CHARM_INTERFACES_DIR.  What do you think about adding CHARM_CHARMS_DIR and having the juju-bundle plugin use those to determine automatically if any of the charms referenced in the bundle can be built and updated?  I had already felt like not including that var was something of an oversight, and it would be nice to be able to say charm build foo and just have it work, no matter what directory you currently happen to be in.
I would also prefer using the CHARM_BUILD_DIR var as well, instead of creating a temp dir, since that ensures that the charm is built into the same place that it would be when working with it individually, and things like in-place upgrades are more consistent.

@wallyworld: the intent would be that if there's charm source code at the specified location, it will be built and used

@johnsca: Good point about it remaining in the bundle - juju deploy will ignore the build attribute since it doesn't know about it, but the bundle plugin would currently prefer the local path to the charm store one. I think we could either have it only prefer building charms if it's deploying a local bundle, or add a --build flag, though.
Does having something like source: charm-redis-k8s vs build: ../charm-redis-k8s match up with what you're thinking, and have juju-bundle look at $CHARM_SOURCE_DIR/charm-redis-k8s to find the charm source (bikeshedding that I think CHARM_SOURCE_DIR is a little less vague than CHARM_CHARMS_DIR).
Good call on CHARM_BUILD_DIR, will update that.

+10 on CHARM_SOURCE_DIR; that's much better.  Also +1 to the source: field.  I mentioned during the demo the idea of using charm pull-source but then I realized the difficulty of dealing with resources etc. and I don't think it's really worth messing with.

Updated this PR with source: instead of build:, and updated https://github.com/knkski/rust-libjuju to look at CHARM_SOURCE_DIR for the charm sources, and CHARM_BUILD_DIR for the built charms


query db not up to date?

while the built db seem fine (see @iPr0ger new apis), and we are getting the new records regularly, not sure that the FE is actually queryong an up to date db.
see also #36

see #48 !


Not able to search with .  in table with search options

Not able to search with .  in table with search options
Specs
What version are you using?
<IP_ADDRESS>
What browser?
any
Expected Behavior
What did you expect to happen?
Able to search with . if the row present with 3.34
Actual Behavior
What actually happened?
Steps to Reproduce the Problem
Please detail your steps here

jsfiddle
If you provide a jsfiddle reproducing the issue, it'll be addressed much faster.
you can use this as base

@sumancholleti
Can you be a little bit more specific as to what the issue is? Are you attempting to search/filter a floating point integer (i.e: 10.75024)?
If so, two things come to mind: you may need to check the type prop on your column, or you may want to look into a format or filter function, referenced in the documentation.
I'm happy to help out, but please provide some more context, and/or reproduce the issue in a fiddle (if possible), per the issue template.

In this fiddle https://jsfiddle.net/aks9800/57a2a4ce/ i tried to search for 3.34 , nothing comes even though last column has values like 3.34

v2.16.3 should fix this.


[BUG] Erasure decoding fails with Original tree root differs from the tree root computed out of recovered data

Description
Erasure coding fails non-deterministically to decode the data. It seems that the probability of failure is high when block size is ~16KiB or greater. In unit tests it doesn't fail because block size is hardcoded to 1KiB.
To Reproduce
Steps to reproduce the behavior:

Checkout branch bug/ec-threading
Generate a random dataset ./generate-mb.sh. This will create a file test_file.bin.
Run nim c --threads:on -r tests/codex/rndtesterasure.nim

It will fail/succeed non-deterministically. So multiple execution of pt. 2 might be necessary.
From the investigation it seems like one of the blocks from the parity sequence is copied over to the datasequence when thread is spawned for decoding using decodeTask from asyncbackend.nim.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:

OS: [e.g. MacOs]
Version: [e.g. v0.1.2]
Arch [e.g. amd64]:

Bug reported in nim-lang
https://github.com/nim-lang/Nim/issues/23886

PR for nim-leopard
https://github.com/codex-storage/nim-leopard/pull/14


When will there be a new version that supports kibana 7.16.3

Support for kibana 7.16.3

Hi!
I've just added to release https://github.com/Karql/elastalert-kibana-plugin/releases/tag/1.4.1 😉
Regards

Thank you @Karql !


Changed varchar length TRIGGER_NAME from 80 to 200

After deploying quartz to a Sybase database the following error occured:
Error exec quartz initialisation com.sybase.jdbc4.jdbc.SybBatchUpdateException: JZ0BE: BatchUpdateException: Error occurred while executing batch statement: Column lengths of string type referencing and referenced columns don't match. referencing column = 'TRIGGER_NAME', referenced column = 'TRIGGER_NAME'.

After researching I found out that tables_sybase.sql is using TRIGGER_NAME varchar(80) instead of TRIGGER_NAME varchar(200). Length should be equivalent to tables_mysql.sql.
Thanks to @iDschepe figuring this out.

this will not be backwards compatible?


Update slack.php

Q
A

Bug fix?
Yes

New feature?
No

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

Do not forget to add notes about your changes to CHANGELOG.md

I fixed stage and branch not included in slack message.

Follow code standards.

I close this request, cause I found some problem with my code.