Help with controlling inverter directly

Hi, hoping to pick your wonderful brains again with a query about setting/reading inverter options via a direct request.
I'm using grott and home assistant and it's working brilliantly.  I know that GrottServer allows you to control the inverter, but at this point in time I would rather keep with the official growatt site if possibly.  I'm wondering if you have any bright ideas on how I can set and read the following item in the inverter settings:

I did resort to using Playwright to automate a browser session, which worked for a while but now just times out loading the page.  Feels like somehow they are blocking my requests.
I've had a look at the code for grottserver, but my Python isn't up to much unfortunately, so I'm struggling to understand exactly what it is doing.
Is there a way I can fire a request of some kind at the datalogger IP to read/write the setting?  Or does it rely on the open connection to Growatt (or grottserver) to send/read the inverter settings?
Thanks for your help.
(PS This is an SPH inverter)

Hi there,  i think so.
But struggling to get what is this parameter related to. Would it be to get back to grid once the SOC reaches 10%?  please confirm and I'll check and revert.
Cheers, Fernando

Hi @tabascoz
Yes, this is the SOC when the batteries will be, in effect, turned off and the load will be supplied by the Grid (or PV if available).
The reason for this is to automatically stop the battery when EV is charging - want that from the grid rather than draining house battery.

The request to the datalogger IP would need to be wrapped in some form of modbus/growatt wrapper that I really don't know enough about to be able to advise on.
I've been using grottserver for about a year now and have a series of curl requests to dynamically configure my AC charging etc overnight based on the predicted PV generation for the next day.
I'm half way through writing a python library for it which I'll then write a wrapper around so we can use it as a HomeAssistant integration, I just haven't had the time recently.
I'll happily share some stuff tomorrow on how my grottserver setup is working (not at my desk currently).
Unrelated, I've been having no end of problems with the datalogger from my system since the weekend after I had a power outage to do some electrical work. I think I'm one of the only people using the older style ShineLanLink box instead of a Wifi stick and I think something is interfering with the RF signal between them. I've got a wifi stick coming in the next couple of days that I'm hoping I can switch over to and it'll solve my problems.

Short answer: parameter 37. for ex:
curl -X PUT '192.168.0.xxx:5782/inverter?command=register&register=37&inverter=SERIALNM&value=10'
Would do the trick. However, some considerations. to use % values it's only possible if you have the inverter set to talk to the battery bank BMS (battery type set to lithium). I have it and tried with mine, the parameter in my inverter is exactly at 10% like you want, but I've tried to change it from Grott  and it didn't work.To be honest this is the one of the (rare) only parameters i never tried to change using Grott as it is ( from my implementation perspective) it a "fail safe" value. To be used  only if the automation, for any given reason, don't kick in.
I have an EV also and i do charge it from batteries. I am almost grid-free and I aim to not spend all the battery with EV charging.For that I have Home Assistant and Nodered doing the automation and I can control the parameters and solar production forecast to orchestrate solar utilization.
So you could do the same by changing the inverter mode from SBU to UTI and it would stop using batteries immediately.

@tabascoz Thanks - that looks like a request to GrottServer though, isn't it?  I'm not using grottserver at the moment (only grott), as for now I want to keep using the official website/app.  Might change that in the future though!
@muppet3000 Ahh, I had assumed that grottserver needed to do the modbus stuff so thought you had figured it out :)  Probably my lack of knowledge on how it all fits together!  I just assumed that was how grottserver sent those requests to the inverter.
Thinking about it - if I change a setting on the Growatt website, does that go "through" grott?  I wonder if I could put a call into grott to make it send the correct message (not sure if I can figure that out!) when I request it, rather than the website.

When you change the setting via the website yes it flows through grott, I don't understand enough about it's implementation but the grottserver spoofs the logic of the growatt servers.
There may be some specific logic that you could extract from that, however it wouldn't surprise me if there's some form of handshake between grott and whatever 'server' it's talking to, and you'd need to complete that as well.
Last time I looked at the grottserver discussion someone was working on a version of grott/grottserver that allowed data to be published to both the growatt servers AND grottserver which would help with the problem, but I have no idea where that has got to.

Yeah - you know I made the classic mistake of thinking it was you that wrote grottserver!  🤦
I probably opened this in the wrong place - appreciate your help and ideas though!  The HA bit that you did do is working great!

The request to the datalogger IP would need to be wrapped in some form of modbus/growatt wrapper that I really don't know enough about to be able to advise on. I've been using grottserver for about a year now and have a series of curl requests to dynamically configure my AC charging etc overnight based on the predicted PV generation for the next day. I'm half way through writing a python library for it which I'll then write a wrapper around so we can use it as a HomeAssistant integration, I just haven't had the time recently. I'll happily share some stuff tomorrow on how my grottserver setup is working (not at my desk currently).
Unrelated, I've been having no end of problems with the datalogger from my system since the weekend after I had a power outage to do some electrical work. I think I'm one of the only people using the older style ShineLanLink box instead of a Wifi stick and I think something is interfering with the RF signal between them. I've got a wifi stick coming in the next couple of days that I'm hoping I can switch over to and it'll solve my problems.

#1
thanks a lot for the general update regarding writing registers to the inverter cause I have finally been able to finish my DIY Hybrid system
#2
I was on the edge to look for such LAN Control Box you had been using which is based on 868 Mhz or so and control up to 8 inverters or so.
#3
Yes, I would love to be able to use what you have described to charge during off peak hours (here usually only during nights and surplus wind power from the north sea during night with low demand) in case the solar for cast is bad.
#4
Our system is now working with the Eastron SDM630 and 1 SPH 4600 with 4 more MiN 4600 along with a 14 kWh EVE battery inside an EEL V4 box with a JK inverter BMS which means a solid metal EEL solid metal with all the brackets, screws, manual and parts needed to use it as a rack box for brand inverters from sma , deye to growatt - and most important: this case fullfills the mandatory upright position of the LFP cells cause all the towers have been forbidden by EVE as EVE emphasize that the LFP cells was not designed to be laid flat with the fuse on the side instead of the top.
Therefore: here in germany I could get the EEL Box incl. JK 200 A BMS with up to 2 A balancing current for 500€ which is a good product with compression of the cells and 2 nice PCB bridges each supplying 8 cells with balance currents.
If you have to pay 200€ for the BMS alone you will have to pay a lot for the tiny bits and pieces from the terminals (10€) over terminal covers / protection and MCB for DC plus cables plus crimping lus lug nuts, the foam and the Epoxy sheets (over 40€) and many more bits and pieces like a precharge resistor and the right FTDI Adapter (8€) or Modbus Cable (6€). If you get the well packaged kit you will get a good full metal case (not cheap made cause it looks like made in germany) with all you need except  battery cables and LAN cable.
#5
Off topic but a WARNING:  We had bought first december 2023 a SEPLOS vertical tower first and had been preparing the built of the 16 EVE LF280K cells into that SEPLOS MASON 280 LA tower until we got a warning from EVE in March 2024 that in such cases the warranty for the cells would no longer exists cause the horizontal position of the cells would violate EVE's warranty. The hoizontal position will reduce the capacity due to the electrlytes no longer covering the full active material and lower cycle life. This hit us hard cause we had to relocate the inverter and the battery cause the footprint of the vertical battery is tiny especially below such SPH inverter on the wall (44 x 28 cm and 90 cm high). Everything had to be redesigned cause we did not had the depth nor the width at that point needed for a black rack battery which is over 41 cm deep and 70 cm long.
#6
I hope to see your "switch integration" coming soon cause right now I am the manual master doing the stuff via ShineWifi App or browser, I mean activationg AC charging and from when to when and what not.
Growatt did work quite stable so far which means I had no issues I got aware of. It is just working fine.
And in case there are issues these are others like a "longer Home Assistant" restart when grott addon had not been started already which seems to be one of the latest Addons or parts HA is starting. Only then I get again aware of the existence of the Grott Addon and Grott Integration working in the back ground.
#7
I am not sure if you have a clue about the SPH or not but I am looking for the data the Growatt inverter should get or read from the eastron SDM630 smart meter like the current load on each phase or consumption.
But I am not sure which sensor is delivering what.
I had hoped for a kind of sensor that is presenting the net LOAD before the growatt production.
Right now I can only get what I am importing from or exporting to the grid, but not really the current consumption.
I mention this cause the longer you are getting into the hybrid thing the more you get aware how lost you are or how far behind the data are lagging with the 1 to 5 minutes of the Growatt cloud being behind.
I am using VNC to have access via a PC to the JK BMS where I can see the W going in and out of the battery so I can see an instant reaction if I change the Growatt settings. Otherwise I would have to go up onto the roof to the inverter shed and check the values on the display. HA is far behind cause Grott is far behind cause Growatt wants that with the 1 to 5 minute average reporting they are using.
Therefore I have to connect the second RS-485 port of the SPH single phase series (which is called 485-2 behind the CAN port) to the same old laptop I am using to monitor the battery with the JK BMS Windows Software (you could achieve the same with a tablet and the JK BMS App for android, but I had a 10 year old 10 inch 4 GB laptop which is good for such basic tasks).
I need live data from the system and modbus plus ftdi adapter seems to be the only way to get access to growatt SPH inverter real time data.
#8
I guess I need to have to find a new way to get real time access to (only) the SPH inverter in Home Assistant .
That is my current challenge after I have gotten the JK BMS battery data via Bluetooth and the HomeAssistant addOn BT Monitor inside HA.

Thinking about it - if I change a setting on the Growatt website, does that go "through" grott? I wonder if I could put a call into grott to make it send the correct message (not sure if I can figure that out!) when I request it, rather than the website.

ATTENTION: this is the most important topic you always have to be aware of
From the moment you are using Grott server or the HA grott server add on your growatt settings are mostly relying on a working HA instance incl. Growatt. If you reboot and the reboot takes longer then be aware that the Grott Add On might start as the latest piece of code .
I am telling you this cause in case that HA reboot will take longer for whatever reason while you are working on the settings via Growatt Web Site or ShinePhone App then those settings will never reach the server. You will not even get real time data when accessing cause usually you will get data from the cache  of your system.
Cause to access the growatt cloud server data via web or app you need a fully running HA Server - or you have to make the changes directly on the Growatt SPH inverter with the few keys and tiny displays. Not everything can be changed but a lot of those.
I am writing just to give you a reminder and warning to be aware: Grott means HA must be running and if things via WEB or App do not work out as expected you need to check first WIFI, then internet connection and finally the whole HA setup.
Put a sticker on the inverter just to give you a visual reminder every time you come along the inverter.
Otherwise you will loose the memory about the architecture and in 2 years a case might happen as here where the HA reboot took about 40 minutes or so and Growatt cloud and app seemed to be not working right !
Was a long way to figure out what was going wrong - and that was one reason that we plan to switch from the Wifi stick to a modbus direct connection between HA server and the SPH inverter just to see the instant feedback from the server if you change the settings which I can cross check via VNC looking at the jk bms app on the old Laptop cause that is also Modbus connected to the laptop. And this way I can see the growatt SPH reporting to charge with 3257 Watts from the panel into the battery while the JK BMS is reporting to receive just 3000W.
And due to the reason of 10% difference (we are speaking about DC figures on both sides and the fact that JK and Growatt are reporting the same battery voltage (just 3 millivolt deviation) we believe that the JK BMS is undermeasuring cause based on JK the 14,3 kWh nominal capacity would only deliver 12,3 kWh from the very top 3,65V to the very bottom of 2,5V (both switches kick in when the first cell will reach these limits).
Here is a screenshot of such situation from yesterday.

trick

Would do the trick. However, some considerations. to use % values it's only possible if you have the inverter set to talk to the battery bank BMS (battery type set to lithium). I have it and tried with mine, the parameter in my inverter is exactly at 10% like you want, but I've tried to change it from Grott and it didn't work.To be honest this is the one of the (rare) only parameters i never tried to change using Grott as it is ( from my implementation perspective) it a "fail safe" value. To be used only if the automation, for any given reason, don't kick in.

Not sure if you can set the SOC below 10% cause via interface on the inverter, the web or app you can not go below 10%.
That was the reason to use a different trick to use these 10%.
I have a battery of 16 EVE LF280K cells with a JK BMS. To use these 10% - not able to change the growatt inverter settings - I have increased the battery cell size in the JK BMS from 280 Ah to 311 Ah.
So once the battery is fully charged (the 100% is set by the first cell that his the cell charging limit of 3,65V) the JK BMS is overreporting the real SOC and the only thing to remind is that the USEABLE SOC is from 100% to 10%.
Usually the battery runs out before the Growatt 10% are reached cause 1 cell will drop below 2,5V and kick the JK BMS to turn off the battery.
ONCE AGAIN: the SOC is wrong on the SPH display and JK BMS Apps - but in HA I convert the 90% reported by JK BMS back into the real figure which means just 10% less or real SOC in HA 81%.
And I use the kWh capacity remaining cause the most people have a better awareness for kWh than Ah which always needs the voltage of the battery to get a real impression what is left.


refactor: update to stable clap 3.0.0

compiling using clap 3.0.0 instead 3.0.0-beta.1, fix missing traits

Thanks for doing this! looks great 😄


My scripts to graphically set brightness and audio volume

I've made two shell scripts that use Zenity and 'Notify' to graphically set audio volume and brightness. Notify needs the packages 'notify-osd' and 'libnotify-bin'. The sound script also needs the package 'amixer'.
![picture audio]
(http://s1.postimg.org/amchxdlyn/Screenshot_Audio.png)
![picture of brightness]
(http://s29.postimg.org/9kx18gqon/Screenshot_Brightness.png)
Sound script:
#!/bin/bash
# Script to set the set sound volume on the Toshiba Chromebook CB30 that
# has been enriched w/ Linux by Crouton:
# (https://github.com/dnschneid/crouton).
# May work on other chromebooks too.
# This script NEEDS amixer, Zenity (dialog screens), notify-osd and
# libnotify-bin.
#  ||
#  ||
#  ||
#  \/
# There are 3 sorts "sound cards" that you can alter settings of on the Chromebook CB30 w. amixer.
# Use the command 'amixer -c1' to get a vague idea of what card -c0 is, for example.
# -c0    = the HDMI audio output
# -c1    = the analogue ALSA device (speakers, mini-jack out etc.)
# <null> = cras? (= chromium audio server?)
card="-c1"

###################
# START OF SCRIPT #
###################
# First, my amateurish way of getting some output from amixer that contains the current volume setting:
volume=`amixer $card get Master | grep Playback`

# Then cut the first 72 characters from that string because they are not useful:
volume=${volume:72}
# Now cut a "[" if it is there, then cut last 17 characters:
# Note: the "[" is a special character for sed. One must use the escape character "\[" for it.
volume=$( echo "$volume" | sed 's/\[//' )
volume=${volume::-17}
# , and finally cut the "%" if it is there
volume=$( echo "$volume" | sed 's/\%//' )

# Now correct in case the volume was already set to 100% because then too
# many characters have been cut in the previous step:
testval=$volume
if [ $volume == "10" ]
   then volume=100
fi

echo "The current volume setting is: $volume%"
value=$(zenity --scale --title="Audio" --text="Set sound volume." --value="$volume" --min-value="0" --max-value="100")
echo "New volume = $value%"

# amixer set Master $value
amixer $card set Master $value%

# If zero value then notify that old value is kept, else notify new value.
if [ -z "$value" ]
   then
   notify-send -t 2000  "Sound volume kept at $volume%."
   exit
   else
   notify-send -t 2000  "Sound volume is now set to $value%."
   exit
fi

exit

Brightness script:
#!/bin/bash
# Script to set the screen's brightness on the Toshiba Chromebook CB30 that
# has been enriched w/ Linux by Crouton:
# (https://github.com/dnschneid/crouton).
# May work on other chromebooks too.
# This script NEEDS Zenity (diolog screens), notify-osd, libnotify-bin
# and gksu.

current=`/usr/local/bin/brightness`
timeout=2000

echo -e "Usage: brightnesschromebook <percentage>"
# echo -e "Old brightness setting was: $current%"

# If no option is set, then ak for it,
# if no $1 then echo "Question", else set value.
if [ -z "$1" ]
   then
      echo "Old brightness setting was: $current%"
      echo "Type in percentage of brightness."
      value=$(zenity --scale --title="Set brightness" --text="Brightness is now $current%." --value="$current" --min-value="0" --max-value="100")
      /usr/local/bin/brightness $value
        if [ -z "$value" ]; then
           notify-send -t $timeout "Brightness" "is now set to $current%."
           echo "Brightness is now set to $current%."
           exit
           else
           notify-send -t $timeout "Brightness" "is now set to $value%."
          echo "Brightness is now set to $value%."
          exit
        fi
   else
      value=$1
      /usr/local/bin/brightness $1
      echo "Brightness has now been set to $1"
      notify-send -t $timeout "Brightness" "is now set to $value%."
      exit
fi

exit

Thanks for sharing!  How about using /usr/local/bin/volume?
Also, seems like you could combine the two scripts into one (substituting "Brightness" for "Volume")...

Just to confirm, is there no way to get this working against ChromeOS? Am I correct in assuming this is just for the crouton distro, so if my chroot only has the cli-extra target it won't work?


[Line chart] Bottom title bar display invalid

[Line chart] Bottom title bar display invalid between 0h07 and 5h07 titles, see image below:

Hi, may I ask you to share your code?

Please provide me a sample code to reproduce it, otherwise, it is gonna closed.

Unfortunately, I'm gonna close it,
reopen it with your sample code to reproduce.
Thanks.


after update

after newest update of vscode, all Extensions take so time to work.

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


incorrect minor ticks appearing with the 2.0.0 upgrades

In the current master version there are minor tick marks appearing that do not match the major tick marks, which are formatted using set_major_locator.
MWE:
import matplotlib.pyplot as plt
from anesthetic import read_chains, MCMCSamples, NestedSamples, make_1d_axes, make_2d_axes

ns1 = read_chains("/home/lthergt/Documents/Projects/AnestheticPrj/anesthetic/tests/example_data/pc")
params = ["x0", "x1", "x2"]
fig = plt.figure(figsize=(5, 5))
fig, axes = make_2d_axes(params, fig=fig);
ns1.plot_2d(axes);

How would we prefer handling this?

Set minor tick length to zero? (very easy)
This could be done in the spirit of "If you really want something as complicated as minor tick marks in a triangle plot, then you'll have to set them manually".

Try to match the minor tick mark handling to that of the major tick marks?
This would be more in line with our "match default matplotlib/pandas behaviour" philosophy...

Change the major tick mark handling to avoid the problem?
For example rotate tick labels by 45 degrees such that the default matplotlib tick labels potentially fit, and then we drop the set_major_locator. Other suggestions?

3 is also consistent with "match default matplotlib/pandas behaviour", i.e. don't mess around with the ticks beyond rotating them.
(fig._autofmt_xdate()](https://matplotlib.org/3.3.4/api/_as_gen/matplotlib.figure.Figure.html#matplotlib.figure.Figure.autofmt_xdate) could be the recommended way to rotate all the xtick labels (and indeed we could call this once at the end by default).


Process for authoritative 'getting started' guides

Per comments in maintainers meeting, SIG maintainers desire a more clear process for handling website 'getting started' docs updates. Suggested process is this -

SIG maintainers create a new website_docs directory at the root of their repo.
The structure of this directory should mirror the subdirectory structure appropriate to that language

For example, Java would maintain the contents of ./content/en/docs/java in their website_docs directory, and so forth.

Upon a release of the associated package, a member of that SIG should open a PR with the content of their website_docs directory applied to the appropriate location in the opentelemetry.io repository.

Alternately, they may open an issue for a comms SIG maintainer to perform this update.

cc @open-telemetry/docs-approvers @open-telemetry/docs-maintainers for discussion before 3/8 Maintainer's Meeting.

Edits(@chalin)
Renamed website-docs to website_docs in the text above, since that is what seems to be used across the language repos.
Here is a list of the code repos with an indication of their status (as of 2021/09/25):

Repo*
Has website_docs folder
Has docs-update GH Action
Note

opentelemetry-collector
~☑~
~☑~
Docs are back in this repo - #4042

opentelemetry-cpp
✖
✖
Docs in this repo. Doc update via documented process.

opentelemetry-dotnet
✖
✖
Docs in this repo. Doc update via documented process.

opentelemetry-erlang
✅
✅

opentelemetry-go
✅
❌
Setup as submodule in this repo by #690

opentelemetry-java
✅
✅
Setup as submodule in this repo by #739

opentelemetry-js
~☑~
~✖~
Docs are back in this repo - #722

opentelemetry-php
✅
✅

opentelemetry-python
✅
✅

opentelemetry-ruby
✅
❌
Setup as submodule in this repo by #765

opentelemetry-rust
✅
❌

opentelemetry-swift
✅
❌

*The repo link, is the link to the PR that created the website_docs folder.

What format would these docs be in?

Markdown. The only real requirement is that they have a block at the beginning like so, with appropriate frontmatter (see https://gohugo.io/content-management/front-matter/) -
---
title: "Automatic Instrumentation"
weight: 3
---

They can also use any other features available to the docs site, such as tabs by calling the appropriate blocks (as seen in the Erlang/Elixir docs) -
{{< tabs Erlang Elixir >}}

{{< tab >}}
$ rebar3 new release otel_getting_started
{{< /tab >}}

{{< tab >}}
$ mix new otel_getting_started
{{< /tab >}}

{{< /tabs >}}

How should links be handled?

Absolute links should be fine irregardless. Relative links should also be fine, as Hugo defaults to not canonifying relative links, and it tends to be kinda smart about it.. for example, in /content/en/docs/java/getting_started.md there's a link to [/docs/java/#releases-1]. Hugo will do the right thing for [../#releases-1] as well (the link it creates in both cases will be to <protocol>://<host>:<port>/docs/java/#releases-1)
The only thing I can see tripping people up is creating relative links to content outside of the website_docs directory.

I'm going through and making PR's mirroring the website docs to SIG repos today.

Superseded by #730, but I'll keep this open for now since I'm still updating the table with statuses.

Status table is complete. Closing in favor #730.


gcc: add 6.1.0

Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] OS X
[ ] Linux

[X] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

This is basically a copy of gcc/5 folder, version and checksums updated.
For now, this version is kept lowPrio.

All this gcc stuff has so much duplication...

Yes, unfortunately we got used to the copying approach for some packages.


Sub 1gwei TX Gasprice options or Mwei Options

Hi,
it's quite not user-friendly right now to make sub-1gwei Tx on Mycrypto.com, can we change that ?
Maybe a custom gasprice box ? or a Mwei/Kwei (in the future) option?

It's planned for the upcoming MyCrypto beta (v4), but it likely won't be added in v3

Hey @marczeller , MyCrypto functionality doesn't currently support this, but you can change this by following this gif (https://i.imgur.com/iuzTZYe.gifv), and instead of changing the 'max' field to 1000, change the 'min' field to 0.1 and the 'step' field to 0.1 . This will allow you to set sub-1gwei transactions. Its also important to note here that most miners don't accept sub-1gwei transactions, so you may be waiting for a little bit.

We are reducing the minimum to 0.1 GWEI on the release today. However, the experience is generally much better on https://beta.mycrypto.com/and gives you the control you are seeking. :)


OIDC Provider ARN not accepted as Federated Principal for iam-role-for-service-accounts-eks

Description
When using this module paired with the EKS Module, I am passing the OIDC Provider ARN  from the EKS module output module.eks.oidc_provider_arn to this module.
I am returning the following error from AWS:
│ Error: failed creating IAM Role (tutorialcluster): MalformedPolicyDocument: Federated principals must be valid domain names or SAML metadata ARNs
│       status code: 400, request id: 2a43ba14-04fb-4cfe-8192-14eb57df28fe
│
│   with module.iam_eks_role.aws_iam_role.this[0],
│   on .terraform/modules/iam_eks_role/modules/iam-role-for-service-accounts-eks/main.tf line 25, in resource "aws_iam_role" "this":
│   25: resource "aws_iam_role" "this" {
│
╵

It appears that in the dynamic statement block: https://github.com/terraform-aws-modules/terraform-aws-iam/blob/66c80ffbb5f063b0408e275d2a103fbacf634563/modules/iam-role-for-service-accounts-eks/main.tf#L4-L23
...It is unpacking the OIDC Providers map and using the OIDC provider ARN to specify a federated principal. I'm not sure how to proceed, since this ARN is generated by the EKS module. (Line 13 in the above block)
Versions

Terraform: 1.1.5

Provider(s):
provider registry.terraform.io/hashicorp/aws v3.74.0

provider registry.terraform.io/hashicorp/cloudinit v2.2.0
provider registry.terraform.io/hashicorp/hcp v0.22.0
provider registry.terraform.io/hashicorp/local v2.1.0
provider registry.terraform.io/hashicorp/null v3.1.0
provider registry.terraform.io/hashicorp/tls v3.1.0

Module: 4.13.2

Reproduction

Steps to reproduce the behavior:

Code Snippet to Reproduce

module "iam_eks_role" {
  source = "registry.terraform.io/terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks"
  role_name = lower(var.cluster_info.name)

  oidc_providers = {
    one =  {
      provider_arn = module.eks.oidc_provider_arn
      namespace_service_accounts = [ "default:tutorial" ]
    }
  }
}

Expected behavior

It should accept the OIDC Provider ARN I assume?
Actual behavior

Error message above.
Terminal Output Screenshot(s)

See above.
Additional context

None. Thanks!

do you have a full configuration reproduction? what EKS module version are you using and is the OIDC provider enabled on the cluster?

AFAICT yes, the OIDC Provider is enabled on the cluster. The EKS module sets enable_irsa = true which then creates the OIDC Provider:
https://github.com/terraform-aws-modules/terraform-aws-eks/blob/6fe818d0a350c6eb8b65cb461fe5e480597f2ffe/variables.tf#L244-L248
The cluster returns an OIDC Issuer URL:
aws eks describe-cluster --name tutorialCluster --query "cluster.identity.oidc.issuer"

"https://oidc.eks.us-east-1.amazonaws.com/id/<ID>"

As I've looked into this, I think this could be an issue with the EKS module, as the module.eks.oidc_provider_arn is returning an empty string when passed to the IAM role being created by this module. (Output as provider_arn in this snippet), and causing Principal.Federated to be empty as well.
Outputs:

consul_cert_data = <sensitive>
eks_cluster_host = "https://<ID>.gr7.us-east-1.eks.amazonaws.com"
eks_data = <sensitive>
provider_arn = ""
vault_data = <sensitive>

  # module.iam_eks_role.aws_iam_role.this[0] will be created
  + resource "aws_iam_role" "this" {

. . .
              + Statement = [
                  + {
                      + Action    = "sts:AssumeRoleWithWebIdentity"
                      + Condition = {
                          + StringEquals = {
                              + :sub = "system:serviceaccount:default"
                            }
                        }
                      + Effect    = "Allow"
                      + Principal = {
                          + Federated = ""
                        }
    }

. . .

it is hard to tell where your issue lies without seeing a reproduction of your configuration (EKS and IAM). I can tell you that these examples work however https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/examples/iam-role-for-service-accounts-eks/main.tf

Apologies, since it seems like the EKS module was returning the empty string, wasn't sure if you still needed the configuration information 😄
But here's how I have configured both modules (Including the version for EKS as you requested)
EKS
# Deploys Amazon EKS
module "eks" {
  # Full URL due to this issue: https://github.com/VladRassokhin/intellij-hcl/issues/365
  source                               = "registry.terraform.io/terraform-aws-modules/eks/aws"
  version                              = "18.3.0"
  cluster_name                   = var.cluster_info.name
  cluster_endpoint_private_access = true
  cluster_endpoint_public_access  = true

  cluster_addons = {
    coredns = {
      resolve_conflicts = "OVERWRITE"
    }
    kube-proxy = {}
    vpc-cni = {
      resolve_conflicts = "OVERWRITE"
    }
  }

  vpc_id = module.aws_vpc.vpc_id
  subnet_ids = setunion(
    module.aws_vpc.public_subnets,
    module.aws_vpc.private_subnets
  )

  # Node Groups
  eks_managed_node_group_defaults = {
    ami_type               = var.node_group_configuration.ami_type
    disk_size              = var.node_group_configuration.disk_size_gigs
    instance_types         = var.node_group_configuration.instance_types
    vpc_security_group_ids = [module.aws.aws_security_group_id, module.aws.aws_hashicups_sg]
  }

  eks_managed_node_groups = {
    blue = {}
    green = {
      min_size     = 2
      max_size     = 2
      desired_size = 2
    }
  }
  tags = {
    Environment = "dev"
  }

}

And iam-role-for-service-accounts-eks:
module "iam_eks_role" {
  source = "registry.terraform.io/terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks"
  role_name = lower(var.cluster_info.name)

  oidc_providers = {
    one =  {
      provider_arn = module.eks.oidc_provider_arn
      namespace_service_accounts = [ "default:tutorial" ] # this originally was set to "${var.namespace}:${var.service_account}", but exchanged those values for the current string.
    }
  }
}

I also have trace logs from terraform plan and apply. They contain sensitive data, so if there's a way I can securely send that to you, that would be great.

perfect, so now its clear. You are using v18.3.0 but the provider_arn was not added until v18.6.0 https://github.com/terraform-aws-modules/terraform-aws-eks/pull/1870
this is why the version is pinned to at minimum v18.6.0 in the examples https://github.com/terraform-aws-modules/terraform-aws-iam/blob/f1fecd9eb2dee781e63984d379f102eedc852600/examples/iam-role-for-service-accounts-eks/main.tf?rgh-link-date=2022-03-09T14%3A31%3A22Z#L219

Oh yikes! Thank you for your patience, and the quick follow-up. Changing that now 😸

I was wrong above - oidc_provider was added in v18.6.0, oidc_provider_arn should be there.
However, do try the latest version and let me know if there is any change

I bumped up to v18.6.0 and that populated the string for the federated principal, and the targeted apply now completes.
(From my output):
    "provider_arn": {
      "value": "arn:aws:iam::ACCT_ID:oidc-provider/oidc.eks.us-east-1.amazonaws.com/id/OIDC_ID",
      "type": "string"

I was wrong above - oidc_provider was added in v18.6.0, oidc_provider_arn should be there.

For some reason oidc_provider_arn is available when using 18.3, but it was returning an empty value. Moving to 18.6 seems to have resolved the issue. I can report that to the EKS module folks in any case.

Just wanted to provide a quick follow up; I bumped to 18.9.0 and was able to successfully map the IAM role to the Service Account I created in k8s. Thanks for the help!

awesome, glad it worked out!


Add Firestore Tests

The shared tests were added to. Update the tests to covers these additional tests.
https://github.com/GoogleCloudPlatform/google-cloud-common/pull/242
https://github.com/GoogleCloudPlatform/google-cloud-common/pull/245
https://github.com/GoogleCloudPlatform/google-cloud-common/pull/246

@quartzmo has taken this and is actively working on it.


OFM: Quartz does not display checkboxes for the '[?]' format

Describe the bug
ObsidianFlavoredMarkdown: Quartz does not display checkboxes for the '[?]' format
To Reproduce
Steps to reproduce the behavior:

Create checkbox:

[?] this is also a complete item (works with every character)

Expected behavior
It was expected that a checkbox would be displayed.
Screenshots and Source

You can help speed up fixing the problem by either

providing a simple reproduction
linking to your Quartz repository where the problem can be observed

Desktop (please complete the following information):

Quartz Version: 4.3.1(latest)
node Version: 22.8.0
Browser: chrome

This is not a valid usage afaik
You can try it on GitHub markdown.

This is not a valid usage afaik
You can try it on GitHub markdown.

https://quartz.jzhao.xyz/features/Obsidian-compatibility
https://quartz.jzhao.xyz/plugins/ObsidianFlavoredMarkdown

I don't think ? is valid. afaik only either [ ] or [x] works as checkbox?

[?] this does not work
[ ] this works

this is obsidian markdown but its def weird lol

this is obsidian markdown but its def weird lol

oh ok I have never used it but sure lmao

I added my own custom checkboxes by doing the following:

Add custom CSS for the custom checkboxes (on quartz/styles/custom.scss):

li:has(> * > span.custom-checkbox),
li:has(> span.custom-checkbox) {
  list-style-type: none;
  margin-left: -1.5rem;
}

Modify quartz/plugins/transformers/ofm.ts:

// Add the following to the Options interface:
export interface Options {
  // ... stuff goes here ...
  customCheckboxes: boolean
  customCheckboxMappings: Record<string, string>
 }

//add the following to the defaults:
const defaultOptions: Options = {
  // ... stuff goes here ...
  customCheckboxes: true,
  customCheckboxMappings: {
    "-": "⛔",
    ">": "🫸",
    "<": "🗓",
    "p": "👍",
    "c": "👎",
    "w": "😱",
    "!": "🤯",
    "f": "🔥",
    "s": "⭐",
    "m": "💰",
  }
}

// Add the following RegEx beneath the other regex definitions:
const customCheckboxRegex = /^(\s*)- \[(-|f|w|!|>|<|p|c|s|m)\]\s*(.*)$/gm

// Add the following as part of the `textTransform()` body
      if (opts.customCheckboxes) {
        if (src instanceof Buffer) {
          src = src.toString()
        }

        src = src.replace(customCheckboxRegex, (match, spaces, checkType, text) => {
          return "\n" + "\t".repeat((spaces?.length || 0) / 4) + "- " + (opts.customCheckboxMappings[checkType] || match) + " " + text + ""
        })
      }

I added my own custom checkboxes by doing the following:

Add custom CSS for the custom checkboxes (on quartz/styles/custom.scss):

li:has(> * > span.custom-checkbox),
li:has(> span.custom-checkbox) {
  list-style-type: none;
  margin-left: -1.5rem;
}

Modify quartz/plugins/transformers/ofm.ts:

// Add the following to the Options interface:
export interface Options {
  // ... stuff goes here ...
  customCheckboxes: boolean
  customCheckboxMappings: Record<string, string>
 }

//add the following to the defaults:
const defaultOptions: Options = {
  // ... stuff goes here ...
  customCheckboxes: true,
  customCheckboxMappings: {
    "-": "⛔",
    ">": "🫸",
    "<": "🗓",
    "p": "👍",
    "c": "👎",
    "w": "😱",
    "!": "🤯",
    "f": "🔥",
    "s": "⭐",
    "m": "💰",
  }
}

// Add the following RegEx beneath the other regex definitions:
const customCheckboxRegex = /^(\s*)- \[(-|f|w|!|>|<|p|c|s|m)\]\s*(.*)$/gm

// Add the following as part of the `textTransform()` body
      if (opts.customCheckboxes) {
        if (src instanceof Buffer) {
          src = src.toString()
        }

        src = src.replace(customCheckboxRegex, (match, spaces, checkType, text) => {
          return "\n" + "\t".repeat((spaces?.length || 0) / 4) + "- " + (opts.customCheckboxMappings[checkType] || match) + " " + text + ""
        })
      }

While this does not include the ? custom checkbox, you could easily add it to the list of checkboxes available. Just ensure to also include it in the Regex

Thanks for this, I'll keep it in mind with the parser rework.


CPLP-1016: Fix shared custom typography definitions bundling

Fix library bundling for custom MUI typography Typescript definitions in cx-portal-shared-components
Reduce cx-portal-shared-components bundle size by optimizing lodash imports

Ah great, thats the area which I expected to be the issue.
Looks good but I guess we need the code smell fixes again. @oyo am I right?

@jjeroch I already talked to @oyo about the code smells... They are all in code places that my PR didn't touch. They are appearing now because on Dec. 7 a new rule got added to Sonarcloud, and now it is complaining about that rule in the preexisting code base.

@oyo I tried that out, but it didn't work unfortunately because then we were getting hit by the next rule that said not to use normal functions either.
https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&pullRequest=15&id=catenax-ng_tx-portal-frontend&open=AYUFEDevRQMHHzxpbIyC

@oyo I tried that out, but it didn't work unfortunately, because then we were getting hit by the next rule, which said not to use normal functions either.
https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&pullRequest=15&id=catenax-ng_tx-portal-frontend&open=AYUFEDevRQMHHzxpbIyC

@bcasparraysono quite ironic they suggest this solution in the rule description and then that triggers another smell...

useCallback helped me to fix the code smell
const handleClick = useCallback(() => {}, [])

Please wait with merging, I noticed that I need to look into the portal code because now we got some Typescript errors.

OK, now the portal is compiling again


PyCon SK

Conference Name
PyconSK
URL
https://2022.pycon.sk/en/
Conference Dates
09 Sept 2022
Conference Type
in-person
Conference Location
No response
CFP URL
No response
CFP Dates
No response
Conference Description
The PyCon SK 2022 conference, which will be held in Bratislava, is an annual gathering of the community using and developing the open-source Python programming language. It is organized by volunteers from the SPy o.z., civic association dedicated to advancing and promoting Python and other Open Source technologies and ideas. Through PyCon, the SPy o.z. advances its mission of growing the Slovak (and also international) community of Python programmers and Open Source supporters.

Thank you for adding this event! \n We'll happily consider it for the next episode. \n\n The Issue autocloses but we'll be reviewing it at https://github.com/users/kjaymiller/projects/4/views/3


Wrong Request URI during Registration of UE in IMS

Hi @herlesupreeth
Can you help me on this. I've tried using CX and with FHOSS in my setup, both setup I'm encountering the wrong Request URI during registration using samsung device.  Sometimes samsung device able to register to the IMS but most of the time it is trying to register with this Request URI: sip:ims.mnc002.mcc515.3gppnetwork.org. I have not encountered the said issue and works perfectly using Vivo, Huawei, and Realme device.

wrong request URI.pcap.zip

Can you let me know which SIM card you are using? If you are using Sysmocom ISIM then you can program the domain and see if that fixes this. I have seen this issue on Samsung which takes the domain based on the PLMN of the major operator in the country the device was issued.

@herlesupreeth yes I'm using Sysmocom ISIM SIM cards. May I ask how can I program the domain?

you can use --ims-hdomain ims.mnc001.mcc001.3gppnetwork.org in pySim-prog.py to program domain

Hi @herlesupreeth
I've tried to add the domain when programming the SIM but still encountered the error. Can you confirm if I program the SIM card correctly. Thanks

Following is the command I usually use to program Sysmocom ISIMs
./pySim-prog.py -p 0 -x 001 -y 01 -s<PHONE_NUMBER>000000004 -i<PHONE_NUMBER>67896 -k 8baf473f2f8fd09487cccbd7097c6862 --op<PHONE_NUMBER>1111111111111111111111 -o 8E27B6AF0E692E750F32667A3B14605D -a 72273953 -n exp.zii --msisdn<PHONE_NUMBER>100 --epdgid epdg.epc.mnc001.mcc001.pub.3gppnetwork.org --pcscf pcscf.ims.mnc001.mcc001.3gppnetwork.org --ims-hdomain ims.mnc001.mcc001.3gppnetwork.org --impi<EMAIL_ADDRESS>--impu<EMAIL_ADDRESS>
Make sure to program IMPU, IMPI, PCSCF and IMS domain. This way ISIM details would be used by the phone. If even one is not programmed ISIM wont be activated

@herlesupreeth Thanks for the quick reply.  I will try again and feedback the soonest.

Hi @herlesupreeth
I've tried the given command but unfortunately the phone still trying to request to this URI sip:ims.mnc002.mcc515.3gppnetwork.org.
Here's my command:
./pySim-prog.py -p 0 -x 001 -y 01 -s<PHONE_NUMBER>000605744 -i<PHONE_NUMBER>56795 -k<PHONE_NUMBER>5566778899AABBCCDDEEFF -o 7ECC2F637BA2166146D6951A7DAC9AEB -a 44553079 -n TestNetwork --msisdn 9995 --epdgid epdg.epc.mnc001.mcc001.pub.3gppnetwork.org --pcscf pcscf.ims.mnc001.mcc001.3gppnetwork.org --ims-hdomain ims.mnc001.mcc001.3gppnetwork.org --impi<EMAIL_ADDRESS>--impu<EMAIL_ADDRESS>

Then, its the phone firmware settings its taking. Can you access Samsung IMS settings via the menu in CoIMS app? there you can override this value

I can't access the Samsung IMS settings. I can only access the Testing mode menu.

Then, unfortunately I dont have any other ways to fix this device issue

Thank you @herlesupreeth


Sign in - Offline message on password page is not friendly

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Expected Result:
Let's use the following message:
Looks like you're offline. Please check your connection and try again.
Actual Result:
API is offline is displayed which might be confusing for regular users.
Action Performed:

Launch the app
In Log in screen put email witch with has 2FA enabled
Proceed in password screen
Turn off internet connection and try to enter a password.

Workaround:
Unknown
Platform:
Where is this issue occurring?
Web ✔
iOS
Android
Desktop App
Mobile Web
Version Number: 1.0.56-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
View all open jobs on Upwork

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Issue reproducible today during KI retests

Hey @isagoico, would you mind reminding me what makes this issue be retested? I think it doesn't need to be because this isn't a regression but will be a new change. Please let me know if you disagree :)

For our weekly KI we retest all open issues that were raised by our team on regression runs, that's why it was retested. I agree with you that we can exclude this one from the restests, let me know if there are any change of plans

Ah, that makes sense. Thanks :)

Issue reproducible today during KI retests

Issue reproducible today during KI retests

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Triggered auto assignment to @roryabraham (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Posted. https://www.upwork.com/jobs/~017ce3cd40c288a83f
@roryabraham can you review @dklymenk 's proposal above?

@dklymenk Looks good to me 👍
Feel free to submit a PR as soon as you've been hired on Upwork

Hired @dklymenk in Upwork

Great. I will need a few more things from you:

What about the offline message? Do I use the one that is already in the app (used one the 1st step login form, where you enter the email)? Do I use 2 separate ones as suggested by the OP? Or do I use new message, but on both 1st and 2nd step forms?
I will need Spanish translations for the following strings:

"Incorrect login or password. Please try again."
"You have 2FA enabled on this account. Please sign in using your email or phone number."
"Invalid login or password. Please try again or reset your password."
" We were unable to change your password. This is likely due to an expired password reset link in an old password reset email. We have emailed you a new link so you can try again. Check your Inbox and your Spam folder; it should arrive in just a few minutes."
"You do not have access to this application. Please add your GitHub username for access."
"Your account has been locked after too many unsuccessful attempts. Please try again after 1 hour."
"Something went wrong. Please try again later."
and if the answer to my first question is to use the string from OP at least once, I will also need a translation for "Looks like you're offline. Please check your connection and try again."

I will need Spanish translations for the following strings:
Google translate.

"Incorrect login or password. Please try again."
Usuario o clave incorrectos. Por favor inténtalo de nuevo

You have 2FA enabled on this account. Please sign in using your email or phone number.
Tienes autenticación de 2 factores activada en esta cuenta. Por favor conéctate usando su email o número de teléfono

Invalid login or password. Please try again or reset your password.
Usuario o clave incorrectos. Por favor inténtalo de nuevo o resetea tu clave

We were unable to change your password. This is likely due to an expired password reset link in an old password reset email. We have emailed you a new link so you can try again. Check your Inbox and your Spam folder; it should arrive in just a few minutes.
No pudimos cambiar tu clave. Probablemente porque el enlace para resetear la clave ha expirado. Te hemos enviado un nuevo enlace. Chequea tu bandeja de entrada y tu carpeta de Spam

You do not have access to this application. Please add your GitHub username for access.
No tienes acceso a esta aplicación. Por favor agrega tu usuario de GitHub para acceder

Your account has been locked after too many unsuccessful attempts. Please try again after 1 hour.
Tu cuenta ha sido bloqueada tras varios intentos fallidos. Por favor inténtalo otra vez dentro de 1 hora

Something went wrong. Please try again later.
Ha ocurrido un error. Por favor inténtalo mas tarde

Looks like you're offline. Please check your connection and try again.
Parece que estás desconectado. Por favor chequea tu conexión e inténtalo otra vez

Hello, I submitted a PR #3769 for this issue.
FYI since I haven't gotten a response my question of whether or not replace the original offline message in code with new one or to use two different ones, I have replaced the original message with a new one.

Thanks @dklymenk, that seems like a good idea to me 👍🏼

@roryabraham to confirm... seems like a good idea to me 👍🏼 means I should hire @dklymenk in Upwork?

Hmmm @mallenexpensify I thought he was already hired? https://github.com/Expensify/Expensify.cash/issues/3195#issuecomment-865334226

D'oh, my bad. I think I forgot to assign the issue earlier so didn't see @dklymenk when I glanced earlier.  Assigned now

I've look into the code in the PR, it looks good, @dklymenk raised a concern that I'll investigate into, but I don't think it should affect this GH and PR, it will most likely be resolved internaly by us.

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@trjExpensify added you via External label for buddy check next week while I'm OOO, thanks

@mallenexpensify This has been done for a while now. Can we confirm that @dklymenk has been paid on Upwork then close this out?

Paid in Upwork, it was weird cuz it showed @dklymenk twice for being hired, but neither showed being paid yet. Sorry for the delay


[Feature] [Backport] Add materialized view metrics (#30735)

Fixes #issue
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[FE Incremental Coverage Report]
:disappointed: fail : 168 / 314 (53.50%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/http/rest/MetricsAction.java
0
23
00.00%
[84, 85, 86, 87, 88, 89, 92, 96, 100, 104, 126, 128, 129, 130, 131, 135, 137, 138, 148, 149, 150, 151, 152]

:large_blue_circle:
com/starrocks/statistic/ExternalFullStatisticsCollectJob.java
0
1
00.00%
[157]

:large_blue_circle:
com/starrocks/scheduler/TaskRunManager.java
0
7
00.00%
[264, 268, 270, 271, 272, 273, 275]

:large_blue_circle:
com/starrocks/metric/MetricRepo.java
0
4
00.00%
[894, 895, 899, 900]

:large_blue_circle:
com/starrocks/metric/MaterializedViewMetricsRegistry.java
14
44
31.82%
[65, 66, 67, 68, 69, 70, 72, 74, 76, 78, 80, 81, 82, 85, 86, 88, 89, 92, 93, 94, 95, 96, 97, 99, 100, 101, 102, 104, 106, 107]

:large_blue_circle:
com/starrocks/metric/MaterializedViewMetricsEntity.java
78
148
52.70%
[95, 145, 146, 147, 148, 150, 151, 153, 154, 163, 164, 165, 166, 168, 169, 171, 172, 173, 175, 185, 186, 187, 189, 190, 191, 194, 196, 197, 198, 199, 201, 211, 212, 213, 215, 216, 217, 220, 222, 223, 224, 225, 227, 237, 238, 239, 241, 242, 243, 245, 247, 248, 249, 250, 252, 262, 263, 264, 266, 267, 268, 270, 272, 274, 275, 277, 278, 279, 281, 290]

:large_blue_circle:
com/starrocks/sql/optimizer/validate/MVRewriteValidator.java
38
49
77.55%
[84, 91, 133, 134, 135, 138, 140, 143, 144, 146, 149]

:large_blue_circle:
com/starrocks/sql/optimizer/Optimizer.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/scheduler/PartitionBasedMvRefreshProcessor.java
21
21
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/MvUtils.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/statistic/FullStatisticsCollectJob.java
1
1
100.00%
[]

:large_blue_circle:
com/starrocks/statistic/StatisticsCollectJob.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/sql/optimizer/rule/transformation/materialization/rule/BaseMaterializedViewRewriteRule.java
4
4
100.00%
[]


Fixes issue where info logs would appear in error logs

Fixes #2639

Current coverage is 92.10% (diff: 100%)

Merging #2647 into master will decrease coverage by <.01%

@@             master      #2647   diff @@
==========================================
  Files           100        100
  Lines         12282      12282
  Methods        1522       1522
  Messages          0          0
  Branches       2020       2020
==========================================
- Hits          11313      11312     -1
- Misses          969        970     +1
  Partials          0          0

Powered by Codecov. Last update 28bd378...dd4c22b

lgtm


ReceiveMessageThread is still running after calling StopReceiveMessageThread method of communicator

Excuse me. I created a websocket client to communicate with a server. I'm trying to write a destroy method of my class. Please tell me how to solve this problem, thanks a lot.
This is my source code: https://github.com/ifloppy/LibKookBotPas/blob/main/libkookbotpas.pas#L106

My fault. I should use this first: FCommunicator.WriteMessage(wmtClose).Free;


use fakebroker to test gp-cli

Coverage increased (+2.3%) to 52.608% when pulling f4eae1d9c3d7bfda7c11394e2bf6476f538957fc on srl295:simple-fakebroker into 571389e73b767512fcbd7054d74b644b66ce3fc9 on IBM-Cloud:master.

It's not entirely a hack. It can definitely be refined, though.


Building exits prematurely when webextension-toolbox.js exists

Expected Behavior
If a webextension-toolbox.js file is present in the root directory of my project, with the code snippet provided by the readme, the webextention should build with all configurations for webpack made by the toolbox itself in addition to the rules, plugins, ect. pushed into their respective arrays by the code inside the snippets webpack() function
// This file is not going through babel transformation.
// So, we write it in vanilla JS
// (But you could use ES2015 features supported by your Node.js version)
module.exports = {
  webpack: (config, { dev, vendor }) => {
    // Perform customizations to webpack config

    // Important: return the modified config
    return config
  }
}

Current Behavior
The build processes starts and ends prematurely on success, throwing no errors, but not starting webpack; generating no files.
PS C:\Users\li6hu3\WebstormProjects\Shopping_Cart_Analyzer> yarn run build firefox
yarn run v1.7.0
$ webextension-toolbox build firefox
Done in 1.01s.
PS C:\Users\li6hu3\WebstormProjects\Shopping_Cart_Analyzer> yarn run dev firefox
yarn run v1.7.0
$ webextension-toolbox dev firefox
Done in 1.00s.
PS C:\Users\li6hu3\WebstormProjects\Shopping_Cart_Analyzer>

Steps to Reproduce (for bugs)

Generate new scaffold with yo web-extension
add webextension-toolbox.js file to root of project (beside files like package.json)
insert code snippet for the file provided by the README
(optional) push a e.g. webpack rule into config.module.rules (either way, the config should be passed in and out of the function)
build extension in dev or prod e.g. yarn run build chrome

Context
I need to add bootstrap to my extension which means I need to add a style and css loader and additionally wanted to define jQuery as a plugin via webpack.ProvidePlugin for convenience (although not necessary as bootstrap will require popperjs and query on its own)
Your Environment

Tech
Version

webextension-toolbox
1.0.0

node
10.2

OS
Windows 10 (1709/16299.461)

browser
-

etc
yarn 1.7.0, powershell

Hi @Linard11 ,
Do you experience this when you are using WSL Ubuntu/Debian Bash?

@balcsida I'm at work right now, so I have to test this on WSL and a real Debian Environment once I'm home. Only thing I can offer until then is git bash which did not work either

No worries. I will try to reproduce it based on your steps.
Will see if this is a Windows specific issue. If not, at least we can cross out something. 🙂

@balcsida hey, sorry to get to you so late. I just tested it with WSL and it worked without a hitch. So I guess this is a Windows specific issue.

@Linard11 I can also confirm that is a windows specific issue. and I guess that the issue is connected to using find-up module. check: https://github.com/sindresorhus/find-up/issues/23

Hey @Linard11 ,
No worries, I didn't had enough time to check it on my side.
Thanks for checking! 👍 🙂
Hey @bboydflo ,
Thanks for confirming!
I will ask @HaNdTriX to create a tag for Windows specific issues.
Until that time, I have to recommend you to use Ubuntu on WSL as a workaround.

Working with WSL instead of Powershell is per se not that big of a deal as I can just open a different terminal and use the same command, but WSL seems to have some weird write lock problem when using the development mode for hot-reloading. While running dev, Webstorm is unable to save changes I make, giving me a error promt:
Cannot Save File
Following erros cocured on attempt to save files:
Cannot save <path to file I try to save>
The life left unchanged.
Your changes were written to a <name of file>___jb_tmp___.

Hey @Linard11 ,
Could you please try with cloning/pulling changes from this repo and npm link to your project?
Thank you in advance!

Even with the most recent changes from the repo the issue persists, that the build process stops when webextension-toolbox.js exists

Thanks for trying out, will take a closer look then (how naive I was that this would be fixed with a simple dependency update 😆)
Completely OFF topic: Your avatar. Is it from bakemonogatari?

Yes


IPv6 Multicast Addressing

Problem
Group messaging requires nodes constructing their IPv6 multicast address for each group, and registering to listen for mutlicast messages to that address.
Proposed Solution
Implement IPv6 Multicast Addressing specification (spec reference TBD)

Reopening, Since PR #11368 added the functionality to build multicast address but is not in use in the actual stack.

Possibly finished? There seems to be a linked PR, but specifically for linux.


Possibility to create refillable droppers

Feature Request
It would be cool to have ability for creating refillable droppers.
Let's add something like that!

Added in the newest release


material UI issues

The current material UI has several issues on the narrow screen. With vertical device orientation on a phone with all options enabled (subtitles, playback, fullscreen, etc) the control widget does not fit the with and shows the overflow UI error. But even without overflow the play slider does not have enough width to be usable.
Also non-transparent controls cover significant part of the video frame.
It would be great to have an option to make video player control bar transparent and also move video play progress in its own row for the full widget width (similar to Android video player or Youtube).

@ekuleshov We're already targeting a restructure of the InheritedWidget Architecture and the restructure of the UI (will look similiar like actual YT on mobile. Be prepared :)

Fixed with v. 1.2.0. Please update your chewie and have a look here:
https://pub.dev/packages/chewie/changelog

regarding making the video player progress bar transparent:
Chewie is supporting out of the box a än options names: customControls.
With that you can build completely your own controls :).
But it seems a lot of people are not aware of this. I'll target the documentation again.
Closing this for now. Have fun with new default design :)

@Ahmadre it is a big improvement but it still has issues. E.g. placing video controls/options at the top and at the bottom is not justified. The bottom row is half empty anyways) and the top and bottom icons aren't aligned to each other (not on the same grid) and (seem to be not complying with the recommended material offsets)
I'm aware of the custom controls, but that would require to rewrite/clone existing Material implementation.
I may have to do that anyways, because current UI uses too excessive dimming when video controls are shown and large play button in the middle is obscuring large part of the frame when widget does not have a lot of screen real estate.

@Ahmadre thank you for the update. It is a big improvement but it still has issues. E.g. placing video controls/options at the top and at the bottom is not justified. The bottom row is half empty anyways) and the top and bottom icons aren't aligned to each other (not on the same grid) and (seem to be not complying with the recommended material offsets)
I'm aware of the custom controls, but that would require to rewrite/clone existing Material implementation.
I may have to do that anyways, because current UI uses too excessive dimming when video controls are shown and large play button in the middle is obscuring large part of the frame when widget does not have a lot of screen real estate.

PR's are welcome

PR's are welcome

Any UI-related PR will likely be subjective (and really driven by the individual needs of the apps). Unfortunately the current Chewie plugin structure does not provide a good way to customize UI other than providing your own, but then depending on the video_player plugin directly may make more sense. Basically the 3 existing UI variants don't share any common parts.
Generally, the video player UI has a well know set of controls + custom options (e.g. start, stop, pause, rewind buttons, progress indicator, time indicator, playback speed, menus etc). Then those controls could be arranged or rearranged according to Material or Cupertino UI guidelines.
So, to allow UI flexibility there need to be some common control builder (with decent defaults for Cupertino and Material) and another builder that would assemble the player UI overlay out of those controls.
This way one wouldn't have to rebuild an entire UI logic for the player UI in order to customize it to the app needs. Just replace the part that assembles UI from the pre-build controls.

PR's are welcome

Any UI-related PR will likely be subjective (and really driven by the individual needs of the apps). Unfortunately the current Chewie plugin structure does not provide a good way to customize UI other than providing your own, but then depending on the video_player plugin directly may make more sense. Basically the 3 existing UI variants don't share any common parts.
Generally, the video player UI has a well know set of controls + custom options (e.g. start, stop, pause, rewind buttons, progress indicator, time indicator, playback speed, menus etc). Then those controls could be arranged or rearranged according to Material or Cupertino UI guidelines.
So, to allow UI flexibility there need to be some common control builder (with decent defaults for Cupertino and Material) and another builder that would assemble the player UI overlay out of those controls.
This way one wouldn't have to rebuild an entire UI logic for the player UI in order to customize it to the app needs. Just replace the part that assembles UI from the pre-build controls.

Sure, I totally agree: If you open a PR and work on stuff you want to have in chewie, it's all welcome :) we can work on that, that we can have a great benefit for all 💪 appreciate every co-working


Sometimes the microcode execution gets stuck in Microbit

This situation usually occurs when I write programs that are quite large and have many Jacdac modules connected.
when I press reset, it should operate normally again.
Error Code is *^*980
https://user-images.githubusercontent.com/3880290/236616430-667cde8e-e099-4bb0-8cf3-873d82cc4587.mp4
https://user-images.githubusercontent.com/3880290/236616434-d68c474d-c8ed-443e-885a-f7b5734aaad6.mp4

@smfox10 Can you please share the MicroCode program - build it using the web browser and then paste the URL here.

https://microsoft.github.io/microcode/#H4sIAIThZmQAA5WQwa6CMBREfwkfPk2XShBvYzFYlNadippiUSOSUr7eWqoxceVqcpOZM+3sNVa7Ep3X0aqE4joEORJzeTcKTonRSizbsAHpVXAK7Z2kR8GoEgsBg0zjaB7gfBbg2DC2xqPJBGmeyZqXyAfZQ7OpYWjrTUka2mxC7T122ajL8v+ux3M9oFgLgjGvMm9NrUeShlCbGbu+fpfhNrMoQvXNIL8y3H8/GcmvDP3F8GPFGb5to2XH8nv5gTbvvQ8rt9VzV/+OXB998l9e6wnw35rhdpOhGoqLyAuo46DfxhqjB7xmV4HUAQAA


Daemon for automatic sync

It may also be useful to set up a command / flag that launches the background application and dealing with the sync of the data remotely.
hssh -d

or
hsshd

This makes sense, but it's worth implementing it as a Homebrew service instead of an independent daemon.

Please look issue #28 for a different approach


hooks.js missing documentation for runhook portalDetailsUpdated

The runhook portalDetailsUpdated is not documented in hooks.js.  This runhook is called when the portal details display is updated after you click on a portal.
// portalDetailsUpdated: called after the portals details display is updated.  Provides a data
//    object containing information about the displayed portal: the guid, a portal object, a
//    portalData object, and a portalDetails object.

You could certainly submit a pull request to update it, but it is documented:
// portalDetailsUpdated: fired after the details in the sidebar have
//              been (re-)rendered Provides data about the portal that
//              has been selected.

I searched and missed it.  Thanks.


[Java] ManagedIO

Managed transforms API for Java
Fixes #30830

Let's also add unit-testing using existing SchemaTransforms (we'll have to mock/override the set of transforms for a group or the pattern used to select the set of transforms for a group).

Also, please fix spotless/lint failures.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.55%. Comparing base (fc5df6f) to head (d4258cd).
 Consider uploading reports for the commit 02c04e6 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #30808       +/-   ##
=============================================
- Coverage     70.73%   68.55%    -2.18%
+ Complexity     4468     2985     -1483
=============================================
  Files          1256      352      -904
  Lines        140774    27871   -112903
  Branches       4306     3231     -1075
=============================================
- Hits          99581    19108    -80473
+ Misses        37714     7302    -30412
+ Partials       3479     1461     -2018

Flag
Coverage Δ

go
?

java
68.55% <ø> (-0.03%)
:arrow_down:

python
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Glob

Simple addition for convenience.
This could be used later so that a typical spark user can do something like dataframe = hdfs_json('hdfs://server:9000/data/*.json')

It is common, I think, to use directories alongside globstrings.  E.g.
/data/2015/

rather than
/data/2015/*/*.csv

Is this supported?  Does the logic within du spider within nested directories?
Does du add any significant cost?


Saving to empty directory field should result in relative file output

Problem
Saving to a file with an empty directory field specified does not raise an error yet it also doesn't explicitly define where the output is going to end up. This should become more predictable, like default to the images folder. It is currently unclear whether it already does so. We should enforce that behavior, or error out.
Proposal
Whenever a relative path is not os.path.isabs(path) is given in the directory field it should be relative to something static and artist-friendly, I'd recommend the workspace's image folder.

python         # run playblast, copy file to given directory         # get directory from inputs         if not use_default:             path = self.directory_path.text()         else:             # get directory from selected folder and given name             path = lib.default_output() # << here we create a default output when none is returned
`python
def default_output():
"""Generate outpath based on current scenename and set project"""
workspace = cmds.workspace(query=True, rootDirectory=True)
folder = cmds.workspace(fileRuleEntry="images")
scene = get_current_scenename() or "playblast"

# get current datetime
timestamp = datetime.datetime.today()
str_timestamp = timestamp.strftime("%Y-%m-%d_%H-%M-%S")
filename = "{}_{}".format(scene, str_timestamp)

return os.path.join(workspace, folder, filename)

`

The commented code does not solve the problem with relative paths, but does so only for a completely empty field.
I believe preserving a default for an empty field should be fine, but the empty field should return a default relative output so it resolves similar like any relative field as described here.
As such an empty field would resolve to a filename like scenename_timestamp which would finally get resolved using the default behavior for relative paths.


Hyperlink/URL is not correctly recognized and opened

Windows Terminal version
1.20.11381.0
Windows build number
10.0.22631.0
Other Software
No response
Steps to reproduce
$ cat https://login.microsoftonline.com/.
cat: 'https://login.microsoftonline.com/.': No such file or directory

$ cat https://login.microsoftonline.com/:
cat: 'https://login.microsoftonline.com/:': No such file or directory

Expected Behavior
https://login.microsoftonline.com/ should be recognized and opened.
Actual Behavior

In the terminal windows, https://login.microsoftonline.com/ is underlined, but in the pop-up tooltips,  https://login.microsoftonline.com/. and https://login.microsoftonline.com/: are shown.
After Ctrl + Click, https://login.microsoftonline.com/: is opened and results in an error:

Thanks for the suggestion! This is actually already being tracked by another issue on our repo - please refer to https://github.com/microsoft/terminal/issues/17323 for more discussion.
/dup #17323
This was also fixed in Windows Terminal v1.20.11781.0


Fix haddock building

There are two things that prevent cabal haddock all from building, both of which are fixed in this PR.

bors merge

bors retry


Include Windows and macOS Targets for CI

Description
We found that certain bugs appear in macOS but not in Linux, which was hard to spot since we only tested on Linux. For example, system time representation can differ across operating systems.
This PR fixes it by adding Windows and macOS CI jobs for each commit/PR.
Changes
The change wasn't straightforward because the build initially failed on Windows and macOS due to:

Compatibility issues with Windows for pprof dependency
A failed build script for the data-pdf crate on macOS, causing the entire workspace build to fail

This PR resolves the issues by:

Removing the dependency on pprof to fix the Windows build
Correcting the path of libpdfium in the build script for the data-pdf crate

Currently, we only run CI tests for macOS Intel because using macOS ARM requires payment for GitHub Actions. See more information in macOS runner pricing
For now, we've added support for macOS Intel and included a GitHub Actions workflow for macOS ARM. Just as a placeholder within the release job, which is not yet implemented, with a "FIXME".
It may be reasonable to run macOS ARM tests exclusively for release builds.
Other changes made include adding the logo to the README and including badges for CI and the license.

I've set up a new workflow to run under the following conditions:

Whenever there's a push to the main branch
Weekly (Should we switch to running monthly instead?)

This workflow runs tests on different platforms, including Linux, Windows, and macOS (ARM and Intel).


Text link not going to the correct page

I've just installed and got this working, but have a weird bug.
The first page i archived worked great.. i go to the index page and then click on the text link and it takes me to a nice HTML representation of the page...
Any subsequent links i archive, the text link takes me to the "Link Index" page, but in the iframe underneath is another copy of the same "Link Index" page...
https://imgur.com/a/UJqJDVc
Eg:
First link i archived, the text link (the title of the page) is linked to :
https://*****/ArchiveBox/output/archive/1552560659/linuxconfig.org/allow-ssh-root-login-on-ubuntu-18-04-bionic-beaver-linux.html
Any subsequent archived pages, the text links like this :
https://******/ArchiveBox/output/archive/1552562637/index.html

So, a bit more testing.. the problem seems to be that if i send it to a url with an index.html or index.php etc in the actual URL, it works great.. if the URL is just a folder.. then its not and it has this wierd behaviour..
good :
https://tylermade.net/2017/09/14/the-perfect-reverse-proxy-nginx-ssl-webui-management/index.php
bad:
https://tylermade.net/2017/09/14/the-perfect-reverse-proxy-nginx-ssl-webui-management/

Oh yeah I've seen this bug before, I think I know how to fix it.  Before I push anything though, do you mind confirming the git commit hash you're running so I can make sure you're on the latest master.

Is this what you're after? f0cf1772

Ok I think I fixed it in 61ec497.  Can you try pulling the latest master and giving it a try.

Hmm i did a "git pull" but the problem is still there and the interface is
still showing " Archive created using ArchiveBox
https://github.com/pirate/ArchiveBox version f0cf1772
https://github.com/pirate/ArchiveBox/commit/f0cf17722b2f047f1bb5d69c6a16736e09c0ea03
"
what have i done wrong here?
On Tue, Mar 19, 2019 at 10:11 PM Nick Sweeting<EMAIL_ADDRESS>wrote:

Ok I think I fixed it in 61ec497
https://github.com/pirate/ArchiveBox/commit/61ec4971e9f2007a1e20e2780b4e857659a3e38f.
Can you try pulling the latest master and giving it a try.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pirate/ArchiveBox/issues/176#issuecomment-474604614,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADsuWom_mNIyuKiQ0BlHe0nUULLiJowJks5vYWCGgaJpZM4bz7D5
.

Ah nevermind.. looks like i needed to add a link for it to refresh the
page...seems to be working now! thanks!
On Wed, Mar 20, 2019 at 12:43 PM Dan Medhurst<EMAIL_ADDRESS>wrote:

Hmm i did a "git pull" but the problem is still there and the interface is
still showing " Archive created using ArchiveBox
https://github.com/pirate/ArchiveBox version f0cf1772
https://github.com/pirate/ArchiveBox/commit/f0cf17722b2f047f1bb5d69c6a16736e09c0ea03
"
what have i done wrong here?
On Tue, Mar 19, 2019 at 10:11 PM Nick Sweeting<EMAIL_ADDRESS>wrote:

Ok I think I fixed it in 61ec497
https://github.com/pirate/ArchiveBox/commit/61ec4971e9f2007a1e20e2780b4e857659a3e38f.
Can you try pulling the latest master and giving it a try.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/pirate/ArchiveBox/issues/176#issuecomment-474604614,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADsuWom_mNIyuKiQ0BlHe0nUULLiJowJks5vYWCGgaJpZM4bz7D5
.


Correct image used when sharing links on socials

Ex.

This might have something to do with setting an og:image meta tag
socialsharepreview.com can help debug

Would be nice to specify an image per post without it being featured as the main thing at the top of the post...


Small documentation updates

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #36   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          11     11
  Lines         544    544
  Branches       85     85
=====================================
  Hits          544    544

Impacted Files
Coverage Δ

nox/sessions.py
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4ddf75...0fb4287. Read the comment docs.


[jest-resolve] Add support for packageFilter for custom resolvers

Summary
Forwards option packageFilter to resolve. This is useful in case a custom resolver wants to use it. The best example is #2702 (in particular, https://github.com/facebook/jest/issues/2702#issuecomment-671947783)
Fixes #2702
Test plan
Write a custom resolver like
module.exports = ( request, options ) => {
	return options.defaultResolver( request, {
		...options,
		...{
			packageFilter: ( pkg ) => {
				return {
					...pkg,
					main: pkg.module || pkg.main,
				};
			},
		},
	} );
};

Then, in any jest test, when importing package X, it will try to load it from the field module first, with fallback to main if module doesn't exist.

https://github.com/facebook/jest/releases/tag/v26.4.0


pass trimmedValue in case no handlerDescriptor

Closes #61831

Should the same be done here: https://github.com/Microsoft/vscode/blob/b767b7a806eb3434d1753d17655edbbe55840e9b/src/vs/workbench/browser/parts/quickopen/quickOpenController.ts#L392 ?

@chrmarti No,
That's the fix from last mistake.
if(handlerDescriptor) is true in case of special keys like term and task etc. Where we don't want to used trimmed value.

@bpasero thanks for pointing in right code.
I accidentally closed this PR (trying to revert last commit)
Here is new PR:  https://github.com/Microsoft/vscode/pull/71985
We are using regex LINE_COLON_PATTERN to get line and column number. I have added \s* pattern at the end of regex to ignore white-spaces.


Pass multiple value in sql_mode in session startup.

How do I pass multiple values in sql_mode in connection? I would like to set sql_mode = 'STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION' for my connection pool.
Thanks.

Hi! You would just run that query in the connection event on your pool:
var pool = myql.createPool(...);
pool.on('connection', function (conn) {
  // This will be invoked whenever a new connection is made
  conn.query('SET sql_mode = ?', ['STRICT_TRANS_TABLES,NO_ENGINE_SUBSTITUTION']);
});


ini-values are only added to CLI php.ini

Describe the bug
In a test we need to run the php-cgi SAPI. We've seen that the ini-values directive is only added to the CLI ini file. Ideally, all ini-values should be added to all available SAPIs. Thank you!
Version

[x] I have checked releases, and the bug exists in the latest patch version of v1 or v2.
[ ] v2
[ ] v1

Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems
Ubuntu Lastest
PHP versions
All php versions
To Reproduce
add a "ini-values" directive, it will be added to the cli/php.ini file, but not to the cgi/php.ini file
Expected behavior
ini-values should be added to all sapis
Screenshots/Logs

Additional context

Are you willing to submit a PR?

In the meantime I tried to change the CGI ini file in the actions themselves but it seems I don't have permissions to do so. Any workaround would be highly appreciated :D

@acasademont I will work on this today, as it will need testing extension setup if I change how ini files are handled.

@shivammathur maybe another "cgi-ini-values" property would be easier for you? Happy to help in any way I can, we're trying to move https://github.com/php-pm/php-pm repo to GH actions.

@acasademont I have added support to add ini directives mentioned in ini-values input to all installed SAPIs. Since php-cgi is installed on ubuntu-18.04 for the php versions you are using, it should now work for your use case.
Let me know if you face any issues.
I'm adding support to install SAPIs, that will be in next release.

@acasademont I have added support to add ini-values to all the installed SAPIs.
Since php-cgi is installed on ubuntu-18.04 for the php versions you are using, it should work for your use case.
Let me know if you face any issues.
I'm adding support to install SAPIs, that will be in next release.

@shivammathur thanks a lot! It worked like a charm :D Really appreciate it!

@shivammathur Should this also work with php-fpm when used via nginx, I have an app throwing memory limit exceeded error even though I have already set the memory limit using ini-values


[text] Chinese fonts are not vertically-aligned on Android

Row(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              '中文',
            ),
            Text(
              'ABCD',
            ),
            Text(
              '中文ABCD',
            ),
          ],
        ),

android:

ios is fine:

[✓] Flutter (Channel stable, v1.9.1+hotfix.6, on Mac OS X 10.14.5 18F132, locale zh-Hans-CN)
• Flutter version 1.9.1+hotfix.6 at /Users/imac/flutter
• Framework revision 68587a0916 (8 weeks ago), 2019-09-13 19:46:58 -0700
• Engine revision b863200c37
• Dart version 2.5.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
• Android SDK at /Users/imac/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.1, Build version 11A1027
    • CocoaPods version 1.7.1

[✓] Android Studio (version 3.5)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 36.0.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)

[✓] VS Code (version 1.40.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.6.0

[✓] Connected device (1 available)
    • EML AL00 • CLB7N18C14009706 • android-arm64 • Android 9 (API 28)

• No issues found!

The same problem.Is there a solution?

so.. any updates?

Same problem.

Set a specific height of TextStyle may help. In my case, 1.25 is good. And use a global TextTheme is recommended(the body attr).

Since the 3 blocks of text are separately laid out, they are only aligned after their internal layout. The chinese font and english font have different heights. When the framework is trying to align the separate widgets, it does not have detailed knowledge of the font metrics and instead just works with the rough size and baseline dimensions of the text. We could be misreporting the baseline or possibly, the framework is just aligning everything by the top edge, which would absolutely cause misalignment.
Here are some suggestions to work around this for now as we look into this further:

Use a single text widget. Try Text.rich which allows multiple TextSpans to create a complex paragraph. A single paragraph will be able to properly align text of multiple sizes.
Try StrutStyle. StrutStyle allows minimum text heights and can also be used to force differently sized text to same height.
Manually adjust to get things to align with existing properties such as height.

Since the 3 blocks of text are separately laid out, they are only aligned after their internal layout. The chinese font and english font have different heights. When the framework is trying to align the separate widgets, it does not have detailed knowledge of the font metrics and instead just works with the rough size and baseline dimensions of the text. We could be misreporting the baseline or possibly, the framework is just aligning everything by the top edge, which would absolutely cause misalignment.
Here are some suggestions to work around this for now as we look into this further:

Use a single text widget. Try Text.rich which allows multiple TextSpans to create a complex paragraph. A single paragraph will be able to properly align text of multiple sizes.
Try StrutStyle. StrutStyle allows minimum text heights and can also be used to force differently sized text to same height.
Manually adjust to get things to align with existing properties such as height.

But how to deal with this case .  测试test1234. By now they are not center align in a line. Should i split these into 3 TextSpan which contains chinese/english/num ?

Same problem.

Verified this on latest master and stable and see the text aligned properly.

Tested on Android 8.1.0 device.

master and stable flutter doctor -v
[✓] Flutter (Channel stable, 1.22.4, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-IN)
    • Flutter version 1.22.4 at /Users/dhs/documents/Fluttersdk/flutter
    • Framework revision 1aafb3a8b9 (11 days ago), 2020-11-13 09:59:28 -0800
    • Engine revision 2c956a31c0
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/dhs/Library/Android/sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 46.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.50.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.1

[✓] Connected device (3 available)
    • SM A260G (mobile)                   • 5200763ebcfa861f
      • android-arm • Android 8.1.0 (API 27)
    • sdk gphone x86 arm (mobile)         • emulator-5554
      • android-x86 • Android 11 (API 30) (emulator)
    • iPhone SE (2nd generation) (mobile) • 6C85835D-FBFD-4AB3-8DE8-B4FAD35E5367
      • ios         • com.apple.CoreSimulator.SimRuntime.iOS-14-0 (simulator)

• No issues found!

[✓] Flutter (Channel master, 1.24.0-8.0.pre.356, on Mac OS X 10.15.4 19E2269 darwin-x64, locale en-IN)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.0)
[✓] VS Code (version 1.50.1)
[✓] Connected device (6 available)

I am going ahead and closing this as fixed. If you disagree or think this should be kept open, please write in comments and I'll reopen.
Thanks.

so.. any updates? still  not vertically-aligned on Android

flutter doctor -v
[✓] Flutter (Channel beta, 2.1.0-12.2.pre, on Mac OS X 10.15.5 19F101
darwin-x64, locale zh-Hans-CN)
• Flutter version 2.1.0-12.2.pre at /Users/liuyanfeng/Library/flutter
• Framework revision 5bedb7b1d5 (3 weeks ago), 2021-03-17 17:06:30 -0700
• Engine revision 711ab3fda0
• Dart version 2.13.0 (build 2.13.0-116.0.dev)
• Pub download mirror https://pub.flutter-io.cn
• Flutter download mirror https://storage.flutter-io.cn

@lyf571321556 The problem you are reporting is actually a different problem than the problem reported in this issue. This issue specifically deals with misalignment between multiple text widgets.
Can you please file an issue for the different issue you are reporting here where the single chinese text has higher ascent form baseline than descent? Thank you!

@lyf571321556 The problem you are reporting is actually a different problem than the problem reported in this issue. This issue specifically deals with misalignment between multiple text widgets.
Can you please file an issue for the different issue you are reporting here where the single chinese text has higher ascent form baseline than descent? Thank you!

#79931

Verified this on latest master and stable and see the text aligned properly.

Tested on Android 8.1.0 device.
master and stable flutter doctor -v
I am going ahead and closing this as fixed. If you disagree or think this should be kept open, please write in comments and I'll reopen.
Thanks.

So how do you test this case? Can you provide any codes?
I'm still having the same issue on the latest stable channel.
I'm using separate Text widgets since they cannot be in one TextSpan. They are in different columns but with same vertical offsets, imagine it's a Table like widget.
They are not aligned vertically.

I think this issue is not fixed at all - why cannot they be aligned by default, instead we have to do extra work to fix it? I think it's engine related issue and the users should not pay extra attension to different languages when using Text or other text widgets.
Please reopen this issue and fix it.

@rockingdice Your use case should be implemented as:
Text.rich(
  TextSpan(
    children: <TextSpan>[
      TextSpan(text: '中文', style: TextStyle(...)),
      TextSpan(text: ' Lvl.7', style: TextStyle(...)),
    ]
  )
)

@GaryQian Did you mean to open the issue?


Fix indentation quirks for bzl filetype

Indentation for BUILD files is slightly different from indentation for python. For instance, in BUILD code like
py_library(
  name = "foo",
)

The close paren should not be indented at all.
We should configure an indentexpr specifically for BUILD files that reflects this and other slight style differences.

The default indent (GetPythonIndent) looks like this right now:
cc_binary(
        name = "hello-world",
        srcs = ["hello-world.cc"],
        deps = [
                ":hello-time",
                "//lib:hello-greet",
                ],
        )

Note that shiftwidth is set to 4, but the indent is 8 for some reason.
The indent from python-mode looks like this:
cc_binary(
    name = "hello-world",
    srcs = ["hello-world.cc"],
    deps = [
        ":hello-time",
        "//lib:hello-greet",
    ],
)

If you just borrow that indentexpr, you can already get a much superior indent.

Never mind. It's LGPL. 😞


Update prepare-release.yml to pull nv-codec-headers

Fixes NVEnc for Linux users, and not just the people using AUR.

LGTM

You need to make a similar PR to the nightly repo

Just want to say thanks for the patch @Killrmemz. It finally works for me OOTB with the latest nightly release (AppImage).

Ready for a release then :)

Oh great! Will test that since it was broken for me after upgrading to Ububtu 24.04


Change in Twilio sample app?

Following the documentation below, it appears as if the quickstart application has changed and no longer references the functions listed below.
Follow the Twilio documentation to create a sample quickstart application: "https://www.twilio.com/docs/voice/client/javascript/quickstart"
2. Use the code from section "Twilio - Client voice" below for the "client-voice" Twilio function
3. Use the code from section "Twilio - Capability token" below for the "capability-token" Twilio function
4. Note the URL for the Twilio "capability-token" function created above. In this sample, we will use "https://twilio-sample.twil.io/capability-token"
Can this be checked and the readme updated?

I'm having problems with this sample as well. The instructions for setting up the capability token seem to be incomplete. I've tried creating a new file functions\capability-token.js with the supplied code, and deploying the updated function, but Twilio is reporting this error in the console when the function is invoked:
{
    "message": "Required parameter \"options.applicationSid\" missing.",
    "name": "Error",
    "stack": "Error: Required parameter \"options.applicationSid\" missing.\n    at new OutgoingClientScope (/var/task/node_modules/twilio/lib/jwt/ClientCapability.js:64:11)\n    at Object.exports.handler (/var/task/handlers/ZN8f356296c1d3ed74f5ff5adb6f7d1ae7.js:26:25)\n    at Object.exports.handler (/var/task/node_modules/enigma-lambda/index.js:310:10)\n    at Runtime.exports.handler (/var/task/enigma.js:17:9)\n    at Runtime.handleOnce (/var/runtime/Runtime.js:66:25)"
}

Same issue. This sample is broken as is.

There is a variable missing in the .env file.
When you configure the OutgoingClientScope you need to populate the ApplicationSID:
capability.addScope(new ClientCapability.OutgoingClientScope({
applicationSid: context.TWIML_APP_SID,
clientName: identity,
}));
However the step by step never mentions to create this variable in the .env file.
Just add a variable in that file:
TWIML_APP_SID = <app_sid>
You can grab this <app_sid> from twilio:

go to https://www.twilio.com/console/voice/twiml/apps/
select your app in twilio
the <app_sid> will be the string under friendly name that starts with AP....

Save and deploy the twilio app again, after this, all should work as expected.


Problem with the installation

Download error on https://pypi.org/simple/: [Errno 104] Connection reset by peer -- Some packages may not be found!
No local packages or working download links found for protobuf==3.19.4
error: Could not find suitable distribution for Requirement.parse('protobuf==3.19.4')
I follow the tutorials from https://federatedscope.io/docs/installation/, but I am faced with this problem when execute "python setup.py install" How can I deal with it? Thanks a lot.

Hi, do you try to update your pip or change source of pip?
Please try the following command:
pip install -e . -i https://mirrors.aliyun.com/pypi/simple/ --trusted-host mirrors.aliyun.com

This makes for me! It seems like the source used is going wrong. And thank you for such a great work!


⚠ Empornium has degraded performance

In 9da4fe5, Empornium ($EMP) experienced degraded performance:

HTTP code: 503
Response time: 1281 ms

Resolved: Empornium performance has improved in 5a4e23d after 6 minutes.


Allow require to be aliased

Today, gpf.require.define is 'rewritten' for each resource. Add a level of indirection to allow users to alias gpf.require.define

Actually, I am not sure this provides enough value and there is a risk that users alias it to require. This would change the semantic of CommonJS files...


No sound/ incorrect Port Detection  Intel DG41RQ with ALC662

Hi,
Thanks for your wonderful work, I got the same problem as was in issue #80 . Tried my best to resolve it on my own. But couldn't (new to Macintosh). Any help would be wonderful
My specs:
CPU: Intel Xeon X5450 @3GHz
MoBo: Intel DG41RQ
RAM: 8GB @ DDR2 800MHz
Graphic: Gigabyte GT710
Audio Codec: ALC622
Audio Controller:  NM10/ICH7 Family High Definition Audio Controller
I am currently fiddling with layout 5. Tried all already.
I am getting device listed but incorrect mapping, also I am getting no sound from same.
I am getting error missing controlModInfo for @0u controller, but my controller should be in AppleHDA (using Vanilla One).
Attaching Screenshots for reference

I forgot to store debug log during this boot, if u want can attach it further on.

Was closed by mistake

Hi, your controller is supported, so it is not an issue. You are using an ancient version of AppleALC, please update to the recent one and try all the layouts. If it does not work, reach for codec requests on the forums, we do not make the resources here.


fix(oui-button): remove full height when setting full width

https://github.com/ovh-ux/ovh-ui-kit/pull/470/files#diff-fe8762169b6dc1cea54cc3628763fa7bL204
⚠ This is a breaking change but I mean ¯\(ツ)/¯

CDS Report yarn-build#1433.0 ✘

build & test

build ✘
test ✔


Add FLAG_ACTIVITY_NEW_TASK for wallet intent

Good morning,
I've been using your awesome lib to integrate it in a service which only has an ApplicationContext provided by Hilt. As this service will be used by a JetpackCompose app, I couldn't use the button provided by walletconnectkit. This small change was the only thing that prevented me to use the library, as android would not allow starting an activity outside of an activity context without FLAG_ACTIVITY_NEW_TASK being specified.

Hi @Crysis21. Thank you a lot for your contribution. I will review your PR tomorrow and deploy a new version of the library. Btw, we are working on better support for Jetpack Compose. I hope we can release a new version until next week.

Hi again @Crysis21. The new version is already available in maven central.