Unclear how to call updatePullRequest()

I'm running into CORS issues when trying to call updatePullRequest(). I can call getPullRequest() just fine, but calling updatePullRequest() is giving me the following errors:
PATCH <my pull request url> 401
Access to XMLHttpRequest at '<my pull request url>' from origin 'https://ni.gallerycdn.vsassets.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 35b914aa-bdf4-0523-9e15-5c1537733c0e
Version Independent ID: 5ca8376f-10e0-b29c-b93e-ba6e3679b226
Content: TFS/VersionControl/GitRestClient GitHttpClient2_2 API
Content Source: docs/extend/reference/client/api/TFS/VersionControl/GitRestClient/GitHttpClient2_2.md
Product: devops
Technology: devops-ecosystem
GitHub Login: @elbatk
Microsoft Alias: elbatk

Does your extension manifest have the vso.code_write scope? (not just vso.code)?

It didn't, and that was the cause of my CORS error. Thanks! But I've hit another block. I'm trying to change reviewer votes. I've tried passing in an object that only has a reviewers member (with reviewer objects copied from the pull request). I've also tried just updating the votes in the pull request object and passing the whole thing in. In both cases, I get the same error:
Parameter name: You can only update reviewers, descriptions, titles, merge status, and status.```
I found some posts that make me wonder if the error is misleading, and it's actually not possible to modify reviewers (votes) via `updatePullRequest`. https://developercommunity.visualstudio.com/content/problem/388569/rest-api-docs-and-and-error-message-suggest-pr-pat.html

Any help would be appreciated. The documentation could definitely benefit from some examples and caveats.

I was able to successfully reset a reviewer's vote with createPullRequestReviewer(), though, surprisingly, not createPullRequestReviewers(). I was hoping I could reset multiple in one batch call, but that doesn't seem to be supported.

Hi @m-akinc, Following up on this issue, it appears that your issues have been resolved. Please let me know if you have any further questions. I've created a user story on my backlog to capture updating this doc with some examples, so thank you for the feedback!

Setting the correct scope of the extension helped me to solve the CORS problem from 'https://gallerycdn.vsassets.io'


Settings menu item still showing on a non Pi MusicBox installation

Hello, I know this issue was originally closed, but I still seem to be showing the "Settings" link despite upgrading to the newest version using the pip upgrade just now. Is there any other step I could be missing?

I hit this issue too, when clicking on "settings", I get a page that says:
404: Not Found

I'd forgotten about this one, thanks for the reminder and will look to get it fixed in the next couple of days. If you wanted to edit the html file to remove the links it'd be line 16 in /usr/local/lib/python2.7/dist-packages/mopidy_musicbox_webclient/static/index.html (or wherever the installed files live on your system).

Fixed in https://github.com/woutervanwijk/Mopidy-MusicBox-Webclient/commit/0bd7eff8d60595c9ad8d62afbe88668a05758d12
There's a musicbox config option which controls if these navigation links are shown, it defaults to false.


Rename R.times to R.repeatWith

I don't always use times or repeat, but when I do, I can never remember which is which (repeat('x', 2))
Alternatively, deprecate times and have repeat take a function and just do R.repeat(R.always(10)) if you need to
Alternatively, don't change anything :)

I like the idea of R.repeat and R.repeatWith!

:+1:

Cool I'll submit a PR later tonight


Only first FOUR Region Playlists accessible by actions. Would love to see actions for more playlists!

I would love to be able to start more than the first four Region Playlists using actions.
Only the first four are exposed:

I want to use region playlists in a live situation and I need more than four of them. The  dropdown to select them from a list is exceptionally tiny and far too close to the [-] button that will delete the current playlist with no prompt!!

I tried calling _'S&M_PLAY_RGN_PLAYLIST5'  from in a ".lua" script but that didn't work (_S&M_PLAY_RGN_PLAYLIST1 to 4 does).
I would love to be able to access at least the first 20x playlists from nice big buttons on a button toolbar. It seems a lot of work has gone into the Region playlist functionality but the UI is to small to be useable in a live situation. No problem for me as long as more functionality is accessible from actions.
Is this likely to happen? Or is there a workaround I'm missing? I have a certain amount of coding ability and had a look at  "SnM_RegionPlaylist.h" and "SnM_RegionPlaylist.cpp". It looks like I need to call
void PlaylistPlay(int _playlistId, int _itemId); with a playlistId of more than 4 but I'm not sure how to!
Any help would be much appreciated!

Thanks cfillion. That worked perfectly. Thanks so much for the quick response. I bought you a coffee and donated towards SWS as well.
One  small thing I find unexpected /annoying is that empty region playlists get deleted on reopening the project.
If I'm making a playlist for 5 songs on a setlist and want to start with song 5 the logical thing is to add five playlists and edit the 5th. But when you restart the project then playlists 1-4 get deleted unless you have at least one region into them. This obviously means that the button that played playlist 5 now does nothing and your playlist 5 is now 1, and can't be reordered back to 5 (I'm aware of copy paste but that only copies to a new playlist not an existing one so is very limited).
Not a deal breaker but I'd be worried that I'd get distracted while working on a playlist and accidentally remove all of the regions  then all my buttons would be wrong the next time I went to the project!
Thanks again for your help!

Thanks! Empty region playlists are outright skipped when saving the project. Deleting those without warning seems a bit surprising so I've patched it in #1823.

Hi @cfillion sorry for pestering you,  I'm not sure if you saw my other issue https://github.com/reaper-oss/sws/issues/1826 with region playlists. Is there anything I could do ? I have a Céilí coming up on Monday and I haven't been able to get my regions to play back smoothly! :-/


JSON::ParserError when stubbing a non-json response body

Hi guys. We are trying to use webmock to stub a request from an external API that responds with a single 0 or 1 on the body. But when we tried to stub that, we received the following error:
MyClass#call_endpoint when response is zero return true
     Failure/Error: else JSON.parse(response.body)
     JSON::ParserError:
       A JSON text must at least contain two octets!

The code we are using to stub the request is the following:
before do
  stub_const('MyClass::BASE_URL', 'http://test.external-api.url')
  stub_request(:post, "http://test.external-api.url/endpoint").to_return(status: 200, body: mocked_response, headers: {})
end
context 'when response is zero' do
  let(:mocked_response) { '0' }

  it 'return true' do
    expect(described_class.call_endpoint(params)).to be_truthy
  end
end

Internally the service object that is being tested just verifies the response's body, and if it's 0 returns true, and otherwise returns false.
Is is actually possible with webmock to mock responses that are not objects or arrays coming from APIs? or this is still not yet supported? We may be stubbing it wrong, but we did search a lot and couldn't find an example on how to stub this kind of responses.
Thank you in advance!

@Glis are you sure that the error comes from WebMock?
Can you please run rspec with -b option to show the full backtrace?
There is no else JSON.parse(response.body) in WebMock's codebase.

Hey! thanks for the answer. We debbuged a lil bit more with the backtrace and we figured that some code in one of the wrappers we used did that JSON.parse. so...
My bad there. Feel free to delete this issue, sorry 🤦🏾

No worries, these things happen. I'm glad you managed to find the root cause.


Replaced url filtering with linq query, Replaced Click delegate with lambda expression

Minor cosmetic changes

Does LINQ somehow improve performance here?
I personally think the foreach loop is more readable in this case. Does anyone else have an opinion on this?

I think LINQ is slightly slower than foreach, although the difference in this case is negligible. The reason I did it was because to me it is more readable and it gets rid of the "parts" array (although obviously this could also be done with foreach). How it should be done is mostly down to personal preference :)


Create 2017-09-21-react-native-monthly-4.md

CC: @hramos @tenodi new article

Meant to land this yesterday
!

Failed to import because of the CC: in the description. Trying again.


chore(docus): upgrade Docus to 2.1

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[X] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Upgraded Docus to 2.1 using Bridge 😄
Checklist:

[ ] My change requires a change to the documentation.
[X] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes (if not applicable, please state why)

Thank you @Tahul!
Here is some issues I encountered while testing the PR:

[ ] title and description from meta are not displayed automatically in the page
[ ] Table of contents titles are shifted even though they have the same level
[ ] Prev and Next links at the bottom are not displayed anymore


App styled with Bootstrap3 .. except forms?

Hi!
It came to my attention that most forms in Cabot look a bit "alien" as they fail to apply Bootstrap3 theming as the rest of the app: Text inputs have nothing but style="width: 100%" for instance, no class="form-control". In Chromium, it shows best. There are multiple packages/ways to apply Bootstrap3 to Django forms, it seems. If someone made a pull request, are there some approaches that you would want more or less than others to be applied? Has this topic been considered for Cabot somewhere?
Best, Sebastian

This is notoriously a pain. Open to suggestions. Visual appearance hasn't been main priority but appreciate any systematic tweaks that improve UI!

Hi,
@hartwork pointed me to this issue; I would like to share my 2 cents on this topic:
I think the easiest way would be to use one of the Django libraries out there supporting a "better" form layout. Besides django-floppyforms and django-crispy-forms, there is django-tapeforms.
The usage / change of your code would be quite small; you'll need to add one Mixin to your forms and replace the {% include "cabotapp/_base_form.html" %} in your code with {% form form %} - the "form" template tag comes from the loaded "tapeforms" templatetag library.
See https://django-tapeforms.readthedocs.io/en/latest/usage.html for more details. Attention: to benefit from tapeforms in regards of styling for bootstrap you have to use Bootstrap optimized Mixin (https://django-tapeforms.readthedocs.io/en/latest/contrib.html#bootstrap-mixin)
Hope this helps you to move your project towards an improved UI. Thanks for sharing your work with the community!


any idea why my listtile always fetches before it reaches bottom of page? any way to change it?

is this the effect of infinite_scroll_pagination invisibleitemsthreshold? I kinda like how seamless it seems but I would like a way to only fetch the new page when I reach end of page? I am using pagedlistview.

Hi @HafizAlwi yes this is a feature that infinite_scroll_pagination already expose and it is called invisibleItemsThreshold and it means the number of remaining invisible items that should trigger a new fetch.
There is a default of 3 items, but I'm adding right now in riverpod_infinite_scroll's RiverPagedBuilder so you can change it as you need


exe wont launch on two systems

OpenBoardView.exe wont launch on the two systems below. After double clicking the exe, the hourglass icon appears for a brief moment then nothing happens.
Ist system: MSI AP1920 Windtop running Windows 7 Home Premium 64 bit OS, CPU Atom D525 , Integrated graphics Intel GMA 3150, Avira Antivirus running, Zone Alarm, DirectX 11
2nd system: MSI Wind U100 Netbook, WinXP Home Edition SP3, CPU Atom N270, Integrated Graphics Intel GMA 950, Avira Antivirus, Zone Alarm, DirectX 9.0c
All other board viewers run, including the TopTest/Landrex versions and NeoBoardViewer

1 what ver you trying to run? 2 works on win 10 and linux just fine, avira isnt a problem as i have it.

Just tried on an Asus 1201NL (Atom N270) with Windows 10 and it works, so it's not an issue with the CPU. But on this machine the GPU is an NVidia ION. It might be a software issue: broken DirectX 9 or graphics driver for example. You should try to update/reinstall both.

I also have a Windows 7 64bit machine that it won't open on. Intel Core 2 Duo With Intel Q35 Video Card. Dual Monitors. It runs on every other machine in the shop but mine. I have reinstalled Direct X done a SFC scan nothing else seems to have a problem. I wonder if some other software is causing a conflict.

@LarryOffley do you happen to have zone alarm? i think it has to be software. what kinds of antivirus do you have?

Avg but that is on machine that it does work on.
I have a lot of open source stuff might be a library conflict I don't know
yet.
Larry
On Jun 23, 2016 11:50 AM, "slayer200230"<EMAIL_ADDRESS>wrote:

@LarryOffley https://github.com/LarryOffley do you happen to have zone
alarm? i think it has to be software. what kinds of antivirus do you have?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chloridite/OpenBoardView/issues/22#issuecomment-228147933,
or mute the thread
https://github.com/notifications/unsubscribe/ATLr02T5Obg9yvOQU6kJhTvQQnNz2G56ks5qOtWMgaJpZM4I8HvR
.

Try this build out:
OpenBoardView-ErrorMessages.zip
Hopefully it'll show an error message rather than just silently exiting.

Having the error is very useful
Error:Failed to create direct 3D device.
Interesting I haven't had any other programs fail. I will try reinstalling
my video drivers anyways.
Larry Offley
On Jun 23, 2016 12:20 PM, "Charlie"<EMAIL_ADDRESS>wrote:
Try this build out:
OpenBoardView-ErrorMessages.zip
https://github.com/chloridite/OpenBoardView/files/330650/OpenBoardView-ErrorMessages.zip
Hopefully it'll show an error message rather than just silently exiting.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chloridite/OpenBoardView/issues/22#issuecomment-228156364,
or mute the thread
https://github.com/notifications/unsubscribe/ATLr0wnDxjfR6Pi9Qs0Ym-PSymdVVrKMks5qOtyTgaJpZM4I8HvR
.

Thanks charliebruce. On both systems the error message is "Failed to create Direct3D device".
DxDiag shows no problems via "test directdraw" and "test direct3D" on the N270 winxp system. DxDiag doesn't have a test option in win7.
I agree its probably a software issue. Because its occurring on two such different systems (xp and win7), it must be something they have in common. Like a missing .net framework. However both systems do have closely related crappy Intel integrated graphics GMA 3150 and 950. Openboardview might not play nice with these graphics. They have limited features and limited openGL implementation.

Mine is a Intel Q35 Chipset Video Card wonder if these older Intel cards are just missing a feature the program is using. Still checking if there is a newer driver. otherwise I'll throw a different card in the box

I suspect the graphics chip doesn't support all of the features the program wants. Try this build now and let me know what happens:
OpenBoardView-SoftwareFallback.zip

Fail to create accelerated blah blah falling back to hardware. Click ok and
it opens to Black box with Open Board Viewer at top.
If you want for testing I'll leave my machine like it is for a bit. You
caught me just before I was going to replace the video card with and old
nvidia 7600 just to get it to work on my work computer. (I don't usually
need much video on this machine)
On Thu, Jun 23, 2016 at 1:54 PM, Charlie<EMAIL_ADDRESS>wrote:

I suspect the graphics chip doesn't support all of the features the
program wants. Try this build now and let me know what happens:
OpenBoardView-SoftwareFallback.zip
https://github.com/chloridite/OpenBoardView/files/330794/OpenBoardView-SoftwareFallback.zip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chloridite/OpenBoardView/issues/22#issuecomment-228180678,
or mute the thread
https://github.com/notifications/unsubscribe/ATLr0_OsVbUx7XF2FN4sXUV4R4QXwn-Zks5qOvKDgaJpZM4I8HvR
.

Does the program work correctly after that warning though?  Ie you can open a board file, click things, zoom in and out?

no menu. just black with normal program boarder. no keys seem to do anything
On Thu, Jun 23, 2016 at 3:01 PM, Charlie<EMAIL_ADDRESS>wrote:

Does the program work correctly after that warning though? Ie you can open
a board file, click things, zoom in and out?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chloridite/OpenBoardView/issues/22#issuecomment-228198446,
or mute the thread
https://github.com/notifications/unsubscribe/ATLr0-nzmTLGqb27dGTC3dO6N34UlbLqks5qOwJRgaJpZM4I8HvR
.

I have identical experience to that described by LarryOffley.

I put a Nvidia 8400 card in and now it works perfect. Must just be the
older intel cards are missing support for a feature.
Love the program by the way. So much better than the other ones.
On Thu, Jun 23, 2016 at 6:14 PM, lerocm<EMAIL_ADDRESS>wrote:

I have identical experience to that described by LarryOffley.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chloridite/OpenBoardView/issues/22#issuecomment-228231368,
or mute the thread
https://github.com/notifications/unsubscribe/ATLr07qDj7DeYR-OaX9jCWnB7hQm1trFks5qOy95gaJpZM4I8HvR
.

Unfortunately the two systems I have don't allow for an external graphics card, only integrated graphics available. I should add, using the OpenBoardView_SoftwareFallback build, although you only get a black box with no menus or graphics, ctrl-o will bring up a file selection box and the selected file name is displayed in the top boarder of the box.

Out of interest, does this opengl port work?
(You'll need to unzip the installer and then run the setup program)

The program starts, but will not open eagle .brd files. I installed the DX files from MS.
64bit Win7homepremium, simple video card. Radeon 6450.
The 32bit program complains about a missing MSVCP140D.dll.

The 32bit program complains about a missing MSVCP140D.dll.

Sounds like it's missing a debugging lib.
Try this non-debugging build: OpenBoardView-glfw-port-win32.msi.zip
The opengl port is far from finished and being changed rather frequently, but I'm interested if it will play nicer (or maybe worse) with these graphics drivers.

Yes thank you, the non-debugging build: OpenBoardView-glfw-port-win32.msi.zip with inbuilt installer works fine for me.
One tip - In win7 and possibly win 8 and 10 you need to enable aero for opengl to work properly. I like using the Windows Classic theme with all bells and whistles turned off to speed things up, but this stuffs with opengl. Something to do with Vsync. Found this out years ago trying to run half life/counterstrike and other steam platform stuff.
I've attached a .brd file that should work with openboardview but throws up an error message when trying to open it. It opens with neoboardview and Top Test Boardview R4. I'd be grateful if someone could run an eye over the file and see if it can be easily modified to open. Otherwise no need to waste time on it. Thanks in advance.
Dell_Inspiron5150_LA1682_brd.zip

One tip - In win7 and possibly win 8 and 10 you need to enable aero for opengl to work properly.

Interesting, may add that to the README when the port lands - thanks!

a .brd file that should work with openboardview but throws up an error message when trying to open it. It opens with neoboardview and Top Test Boardview R4.

Would you mind starting a new issue for it? Sounds like this could affect some people.

I did not try Aero interface, but I'm getting a MSVCP140.dll missing error,  which does exist in some 12 places.

I did try Aero, no difference.

Try installing Microsoft Visual C++ Redist :
www.microsoft.com/en-us/download/details.aspx?id=48145
On 6 Jul 2016 14:17, "up-tick"<EMAIL_ADDRESS>wrote:

I did try Aero, no difference.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/OpenBoardView/OpenBoardView/issues/22#issuecomment-230767895,
or mute the thread
https://github.com/notifications/unsubscribe/ACDIev9L_UfY2hQG8Kq6It5xCTz68bSpks5qS6rQgaJpZM4I8HvR
.

I did, same deal. I run win7 in "test mode" "Build 7601"

Closing because Windows binary is built with MinGW as of R7.3 and we don't support Windows XP anymore.


[Feature/Identity] Add scrawfor99 to the feature/identity team

Description
Add scrawfor99 to the feature/identity team
Also update the PR template for this branch
Check List

[ ] ~New functionality includes testing.~ Not Required

[ ] ~All tests pass~ Not Required

[ ] ~New functionality has been documented.~ Not Required

[ ] ~New functionality has javadoc added~ Not Required

[X] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature/identity@7a687fd). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             feature/identity    #4658   +/-   ##
===================================================
  Coverage                    ?   70.59%
  Complexity                  ?    57579
===================================================
  Files                       ?     4656
  Lines                       ?   276992
  Branches                    ?    40511
===================================================
  Hits                        ?   195547
  Misses                      ?    65086
  Partials                    ?    16359

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scrawfor99 @cwperks @DarshitChanpura Could you review this change?

Gradle failures were random issue from :qa:mixed-cluster:v2.4.0#mixedClusterTest, I am going to merge this change as is and then seperately merge from main to check that CI is health

Note; this change was merged into the branch manually


Deprecate CertRevocationResult.ServerResults and replace it with CertRevocationResult.OCSPResults

What is not working as expected?
Since we will introduce CRL in CertRevocationResult to differentiate between CRLResults and OCSPResults, we may need to deprecate ServerResults to make it clearer.
This suggestion was originally mentioned here: https://github.com/notaryproject/notation-core-go/pull/214/files#r1721280510
What did you expect to happen?
No
How can we reproduce it?
No
Describe your environment
source code
What is the version of your notation-core-go Library?
v1.1.0-rc.1

Given this is deprecating a field of a struct, to avoid breaking change, we still need to fill the deprecated field while initializing Result. This should be done in the next major version of notation-core-go by directly renaming ServerResults to OCSPResults.


renderCard problem

I have created a component that encapsulates the swiper and its functionalities, currently I bring a list of elements from the backend and it shows them correctly, then when trying to bring a completely different list from the backend the renderCard method returns undefined.
Stack.js
  render() {
    const {cars, next, current, token, notLogged} = this.props;
    let actualIndex = 0;
    return (
      <View style={styles.container}>
        <Swiper
          key={cars.length}
          ref={(swiper) => {
            this.swiper = swiper;
          }}
          animateCardOpacity
          cards={cars}
          renderCard={(card) => {
            actualIndex = card ? card.id : actualIndex;
              return (
                <CarDetail car={card}>
                  <User user={card.user} token={token} notLogged={notLogged} />
                </CarDetail>
              );
          }}
          backgroundColor={Colors.white}
          onSwipedAll={() => next()}
          cardVerticalMargin={0}
          cardHorizontalMargin={0}
          verticalSwipe={false}
          cardIndex={current}
          stackSize={2}
          swipeAnimationDuration={700}
          swipeBackCard
          onSwiped={() => this._onFinishSwipe()}
        />
      </View>
    );
  }

Home.js
  _renderContent = (list, apiStatus, current, token, quick) => {
    const length = list.length;
    if (length && apiStatus && apiStatus.success) {
      return (
        <Stack
          cars={list}
          next={quick ? this._fetchQuickSearchList : this._fetchListCars}
          current={current}
          token={token}
          notLogged={this._notLogged}
        />
      );
    } else if (!length && apiStatus && apiStatus.success) {
      return <Empty refresh comeback={() => this._comeback()} />;
    } else {
      return null;
    }
  };

  render() {
    const {
      apiRequest,
      showList: {carsList, firstTime},
      quickSearch: {quickSearchList},
      token,
    } = this.props;
    const apiStatus = apiRequest[requestId.SHOW_CARS];
    const {quick} = this.state;
    let current = carsList.length - 10;
    const list = carsList.length ? carsList : quickSearchList;
    return (
      <>
        {(firstTime || quick) && apiStatus && apiStatus.loading && <Loader />}
        <Search
          quickSearch={() => this._quickSearch()}
          token={token}
          notLogged={this._notLogged}
        />
        {this._renderContent(list, apiStatus, current, token, quick)}
      </>
    );
  }

Has anyone faced such a problem? Thank you!

How did you fix it?

How did you fix it?

renderCard={(card) => (card && ) || null}
idk if that was ur problem but this is what i was looking for


chore(web) update import/export terminology

I got rid of the "backup" and "restore" terminology in favour of sticking with "export" and "import"
I will say it still feels quite awkward as export/import work well as the verbs but I feel there is a missing noun, for example "backup" or "snapshot"...  "Workspace export" feels like a bit of a mouthful and using just "workspace" doesnt quite feel right as you are not importing a "workspace" you are importing a fixed snapshot of a workspace.

bors merge


RDBMS 1.1.1

Fix models issues in Python 3

(message created by the CI based on PR content)

Codecov Report

Merging #2415 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2415   +/-   ##
=======================================
  Coverage   54.54%   54.54%
=======================================
  Files        5429     5429
  Lines      127628   127628
=======================================
  Hits        69615    69615
  Misses      58013    58013

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c48dd2...6cc90ad. Read the comment docs.


allow merging of unrelated git histories

Fixes https://github.com/openshift/aos-cd-jobs/issues/1599
@tbielawa @adambkaplan @jupierce @bparees

https://buildvm.openshift.eng.bos.redhat.com:8443/job/devex/job/devex%252Fjenkins-bump-version/24/console got past the failure point at least  .... still cooking

And it succeeded ...thanks everyone.


allow for terminal arrow navigation when in accessibility mode

This PR fixes #149882
In accessibility mode, using UpArrow and DownArrow navigates to commands

should instead add new keybindings for navigation mode actions with a context key for when in navigation mode


chore: rename TokenType GAT and trait to Token

Last few remaining breaking changes before 0.5.

this is a good rename


Enums are not autocompleted & gives error

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the SQLModel documentation, with the integrated search.
[X] I already searched in Google "How to X in SQLModel" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to SQLModel but to Pydantic.
[X] I already checked if it is not related to SQLModel but to SQLAlchemy.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
class EnumAccessStatus(Enum):
    PENDING = "pending"
    APPROVED = "approved"
    REJECTED = "rejected"
    REVOKED = "revoked"

class Temp(SQLModel):
    py_type: EnumAccessStatus
    access_status = Field(
        sa_column=Column(
            sqlAlchemyEnum(EnumAccessStatus)
        )
    )

Description

Create an instance of Temp class by Temp() and hit space between brackets to get autocompletion
Even If we add parameter by our self Temp(py_type=EnumAccessStatus.REJECTED, access_status=EnumAccessStatus.REJECTED) it throws "No parameter named access_status"

Operating System
Linux
Operating System Details
Ubuntu 21.10 64-bit
SQLModel Version
0.0.6
Python Version
3.10.2
Additional Context

As mentioned in python docs you have to inherit from both Enum and the value that will stted in orinal like str
    Pending= "pendding"````

It is still not working.


There is no WIN32 define, use _WIN32 which is defined by compiler

:)

I did not know that. I guess VS defines it anyway?


Image sizes wrong keys and wrong dimensions

Hi, I'm interested in this plugin but I'm finding that it's not assigning the proper keys to image sizes.
Notice in the attached image that the "full"/original file is listed under "medium-large" and that the "large" dimensions are incorrect (actual dims in url).
That "sizes" object is inside a 'acf gallery' inside a 'acf flexible content' field.

Same problem here. How to change the keys' "-" to "_"?


Refactor big files throughout the project

Will be done with https://github.com/0xSpaceShard/starknet-hardhat-plugin/issues/396


DELETE /billings/{id}

Path: /billings/{id}
Method: DELETE
Auth: admin
Parameters:

id={String}

Response:
{
  status: {
    proForma: Boolean,
    invoice: Boolean,
    receipt: Boolean,
    payed: Boolean
  },
  employer: CompanyRep,
  value: Number,
  invoiceNumber: String,
  emission: Date,
  notes: String
}

Notes:
id is an _id field of mongodb.
Status codes:

Code
Rule

404
Billing not found

200
Always

Tests:

No match

404 status code

All good

Returns found billing.

Billings have an ID field.


PinkMan doesn't work if you remove lock screen

https://github.com/RedMadRobot/PINkman/pull/24 - it is only half-fix @Zestxx
I suggest you always put setUnlockedDeviceRequired(false) instead of setUnlockedDeviceRequired(isDeviceSecure)
Why:
Steps for android 12

set android lock screen
install pinkman demo app (i used fork of this repo)
create pin in pinkman
remove android lock screen
launch pinkman demo app

Expected result - all works
Actual result - crash
It happens, because you generate key on locked device, This key becomes irrevocably lost, if user removes android lock screen.
Generated key also may become irrevocably lost, if user for example change android lock screen type from PIN to Graphical key. Or may be, if user just changes PIN's digits.

Yes we saw this issue month ago (we voted on it :) ). I thougt you know about this issue. But as we (android developers) all know google never hurry up with AOSP bug fixing. In most cases they completely ignore issues and do nothing. Issue has: Priority - P3 and Severity - S3. I think google will ignore it.

@Fi5t In general ok, thanks, but may be it will be better to put:
                    val isDeviceSecure = Build.VERSION.SDK_INT < Build.VERSION_CODES.S && isDeviceSecure()

instead of
                    val isDeviceSecure = if (Build.VERSION.SDK_INT == 31) {
                        false
                    } else {
                        isDeviceSecure()
                    }

Just released v1.3.1 with this fix. It will be published in 10-15 minutes


fiemap error

Getting the following error when source is Lustre and I request spare support (-S)
[2023-01-30T21:48:23] [1] [/home/harms/working/daos/mpifileutils/src/common/mfu_flist_copy.c:1853] ERROR: fiemap ioctl() failed for src '/soft/daos/mpifileutils/share/man/man1/dsync.1' (errno=22 Invalid argument)

I'm thinking this is because the structure initialization for the ioctl is bad. Running the following Lustre version:
harms@uan-0002:~/working/daos/tools> lfs --version
lfs <IP_ADDRESS>_rc2_cray_14_g2408acc

I don't know if Lustre is strict about maintaining format of ioctl calls between different releases.

This looks like it might be https://jira.whamcloud.com/browse/LU-16480 which fixes a bug in the FIEMAP handling. This needs a small client-side patch to fix.
That said, if this code is using FIEMAP for determining sparseness of a file, it might be better to use lseek(fd, SEEK_HOLE) since this also works for PFL files (otherwise Lustre will return EOPNOTSUPP for FIEMAP calls).
The SEEK_HOLE/SEEK_DATA functionality was added in 2.14, but is a client-only patch.


Over resource limits on Streamlit Cloud

Hey there :wave: Just wanted to let you know that your app on Streamlit Cloud deployed from this repo has gone over its resource limits. Access to the app is temporarily limited. Visit the app to see more details and possible solutions.

Hi, thank you for using the app and for reporting the issue!
The deployment has been restarted from scratch, so if you want you can use the app again now. However, please note that the app is running on a free subscription on Streamlit Cloud and is meant as a demo. If you want to run the app locally on a big dataset, you can download the source code from this repo and run it yourself. These are the steps you need to take:
git clone https://github.com/lucasimi/tda-mapper-python.git
cd tda-mapper-python
pip install -r app/requirements.txt
streamlit run app/streamlit_app.py

This should be documented more extensively in the readme as well.
As an alternative, you can run your experiments in a jupyter notebook as shown in the docs.


Foreign key issue deleting users

Start adding model specs for deletion with all foreign keys active
communities accounts
accounts statements
accounts transactions
communities households
communities invitations
communities meal_formulas
communities meals
communities people_groups
communities reservation_protocols
communities reservation_shared_guidelines
communities resources
communities wiki_pages
communities work_periods
households people_emergency_contacts
households people_pets
households people_vehicles
households signups
households users
meal_formulas meals
households accounts
people_groups work_jobs
meals assignments
meals invitations
meals meal_costs
meals reservation_resourcings
meals reservations
meals signups
meals work_shifts
reservation_protocols reservation_protocolings
reservation_shared_guidelines reservation_guideline_inclusions
resources reservation_guideline_inclusions
resources reservation_protocolings
resources reservation_resourcings
resources reservations
roles users_roles
statements accounts
statements transactions
users assignments
users meals
users reservations
users reservations
users users
users users_roles
users wiki_page_versions
users wiki_pages
users wiki_pages
users work_assignments
users work_shares
wiki_pages wiki_page_versions
work_periods work_jobs
work_jobs work_reminders
work_jobs work_shifts
work_shifts work_assignments
work_shifts work_reminder_deliveries
work_periods work_shares
work_reminders work_reminder_deliveries
For each group, create stuff with all associated stuff from all possible directions and try to delete and make sure deletes cleanly.
watch out for self references (users users)
Originally created by Tom Smyth at 2018-11-27 10:14, migrated from redmine-#9144

Description updated (diff)

By Tom Smyth at 2018-12-12 01:04

Status changed from New to Resolved

By Tom Smyth at 2018-12-18 15:10

Version set to 6.2

By Tom Smyth at 2018-12-16 23:05

Status changed from Resolved to Closed

By Tom Smyth at 2018-12-21 14:57


destroy for ciscoise_device_administration_authentication_rules fails if it's default rule

Prerequisites

[x] Have you tested the operation in the API directly?
[x] Do you have the latest Terraform provider version?

Describe the bug
Example code creates a new policy set first and then want to use "Internal Users" as ID store for Default Authentication Rule.
resource "ciscoise_device_administration_policy_set" "asa" {
  parameters {
    rank        = 0
    state       = "enabled"
    name        = "ASA Firewalls"
    description = "ASA Firewalls"
    condition {
      condition_type  = "ConditionAttributes"
      is_negate       = "false"
      dictionary_name = "DEVICE"
      attribute_name  = "Device Type"
      operator        = "startsWith"
      attribute_value = "All Device Types"
    }
    service_name = "Default Device Admin"
  }
}

locals {
  // "id:=05d9d6fd-f30b-45f2-900f-577948283817\\name:=ASA Firewalls"
  policy_set_asa = jsondecode(
    replace(
      replace(
        replace(
          replace(
            ciscoise_device_administration_policy_set.asa.id, "\\", "\", \"" # separator
          ), ":=", "\": \""                                                  # attribute: value
        ), "/^/", "{\""                                                      # start of string
      ), "/$/", "\"}"                                                        # end of string
    )
  )
}

output "policy_set_asa_id" {
  value = local.policy_set_asa.id
}

resource "ciscoise_device_administration_authentication_rules" "policy_set_asa_authc_rule_default" {
  parameters {
    policy_id            = local.policy_set_asa.id
    identity_source_name = "Internal Users"
    if_auth_fail         = "REJECT"
    if_process_fail      = "DROP"
    if_user_not_found    = "REJECT"
    rule {
      name    = "Default"
      state   = "enabled"
      default = "true"
    }
  }
}

Apply works as expected.
Destroy for the rule fails with this error:
╷
│ Error: Failure when executing DeleteDeviceAdminAuthenticationRuleByID
│
│ error with operation DeleteDeviceAdminAuthenticationRuleById
│ {
│   "code" : "400",
│   "message" : "Failed to handle API - Network Access Authentication Rule : Attempted to delete default Rule"
│ }
╵

Have to manually do this first:
terraform state rm ciscoise_device_administration_authentication_rules.policy_set_asa_authc_rule_default

And then run terraform destroy again to destroy the policy set.
Expected behavior
Destroy should not fail. It may be possible to skip deletion for the rule if default = true since destroy of policy set will remove it anyway.
Screenshots

Environment (please complete the following information):

ISE version and patch: 3.1 patch 3

terraform -version
Terraform v1.1.9
on darwin_amd64
+ provider registry.terraform.io/ciscoise/ciscoise v0.6.0-beta

OS version: macOS Big Sur

Additional context
N/A

Hey  @chetanph , there's a new version (v0.6.1-beta) of terraform-provider-ciscoise, try again with that version and let know us if works for you.

Hi @fmunozmiranda, this issue is cleared as well. Destroy worked fine without any errors. Appreciate your help!!

Happy to help @chetanph.


dotnet tool ib run script by default as powershell. Possible to configure?

I see that one can run build scripts with pwsh under windows using --pwsh
dotnet ib --pwsh test
Would it be possible to configure this so that the config can be stored in the repo of the project using ib?
I've encountered that powershell might not be able to load some PS  modules that works in pwsh which I use as my primary shell on my Windows box. So Import-Module XYZ does not work in the nnn.build.ps1 but it works from the pwsh shell I have.

Yeah, the pwsh variable could be set in the script starting it. 👍
Den tis 11 juni 2024 17:28Roman Kuzmin @.***> skrev:

For ib.cmd we have this convention, see
https://github.com/nightroman/Invoke-Build/tree/main/ib
ib.cmd invokes powershell by default or pwsh if the environment
environment pwsh is defined and points to the executable.
E.g. I use this because I prefer pwsh, too.
Would it be enough for your scenarios, if dotnet ib uses this convention
as well?
FWIW, I think it should, to be more aligned with ib.cmd. I'll probably do
this in any case.
—
Reply to this email directly, view it on GitHub
https://github.com/nightroman/Invoke-Build/issues/219#issuecomment-2161050208,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABD23NTXMQOE2OSPXFO26DZG4JRXAVCNFSM6AAAAABJEMHXR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGA2TAMRQHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

@da9l Please try v5.11.2

I'll try it tomorrow. Thanks!
Den tis 11 juni 2024 19:21Roman Kuzmin @.***> skrev:

@da9l https://github.com/da9l Please try v5.11.2
—
Reply to this email directly, view it on GitHub
https://github.com/nightroman/Invoke-Build/issues/219#issuecomment-2161262910,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABD23IH5ZGGHWW2DWBNR7LZG4WZXAVCNFSM6AAAAABJEMHXR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGI3DEOJRGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

All right, please let me know how it goes. Fixed in https://github.com/nightroman/Invoke-Build/commit/3facce8e949e185a7a9aff9a73d653e057ce7f21

I tried it and it works but I need to figure out where the CI:server's pwsh is installed. Might be trivial but using --pwsh is almost easier. Thanks for adding the option tho.

@da9l I believe you can just do this
$env:pwsh = 'pwsh'

or in cmd
set pwsh=pwsh

Ah, that's easy enough. I'll try it tomorrow.
On Wed, Jun 12, 2024 at 5:06 PM Roman Kuzmin @.***>
wrote:

@da9l https://github.com/da9l I believe you can just do this
$env:pwsh = 'pwsh'
or in cmd
set pwsh=pwsh
—
Reply to this email directly, view it on GitHub
https://github.com/nightroman/Invoke-Build/issues/219#issuecomment-2163278021,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABD23M35CKATXYF27GUHZTZHBPWNAVCNFSM6AAAAABJEMHXR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTGI3TQMBSGE
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
@.*** @.***>
twitter.com/8DH

Works as a charm! Thanks!


Flutter generates default.profraw files in the root directory of the app

Steps to Reproduce

Open a Flutter project
Run it in the iOS Simulator
Look into the root directory of the project

The file is locked and isn't released even after I stop the app and close the iOS Simulator.

Logs
$ flutter doctor -v
[✓] Flutter (Channel beta, v0.5.1, on Mac OS X 10.13.6 17G65, locale en-US)
    • Flutter version 0.5.1 at /Users/filiph/dev/flutter
    • Framework revision c7ea3ca377 (8 weeks ago), 2018-05-29 21:07:33 +0200
    • Engine revision 1ed25ca7b7
    • Dart version 2.0.0-dev.58.0.flutter-f981f09760

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/filiph/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.4.1, Build version 9F2000
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 26.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[!] IntelliJ IDEA Community Edition (version 2018.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.io/intellij-setup/#installing-the-plugins

[!] VS Code (version 1.22.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension not installed; install from
      https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[!] Connected devices
    ! No devices available

! Doctor found issues in 3 categories.

It looks like this has something to do with Xcode 9. Other open source projects had this problem before:
https://github.com/termux/termux-packages/issues/1672
Here's a sample fix: https://github.com/termux/termux-packages/commit/991e770d787f25be92a1051e5c1bc36fe037ecc3

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Clear config/deps folder when running in a virtual env

When running in a virtual environment, we should clear the deps folder during startup to avoid package collisions. This can occur when people migrate to a virtual environment.
Initial reported here: https://github.com/home-assistant/home-assistant-polymer/issues/1287

Actually, just not mounting it is better.


add dependency to turn on BUILD_SHARED_LIBS

Again, this is not new dependency. We got away with it because we never use some subroutines

I am putting a blocker tag on this until I can consult with @weiyuan-jiang about the GNU/bufrlib issue.


CB-5952. Handle SMM CM configs before version 7.1.1

waiting for @benyoka to make sure SMM operates as expected

although deployment failed for me with a different error, but the configuration part passed and it was set properly. I will merge this, if I would not do tomorrow e2e tests will fail on this anyway.I can revert changes if SMM functionally will be different for some reason


Use Terraform to configure trusted domains in Okta

Description
trusted domains are manually configured in okta atm. Use Terraform to configure it as part of the pipeline
Additional Context
https://registry.terraform.io/providers/okta/okta/latest/docs/resources/trusted_origin

Module written up, need to know which trusted domains go where.

This is blocked on the Okta terraform situation.

Unblocked now that the Okta TF situation is resolved.


git pull takes over a minute and 20% of CPU

When there is a new commit available to pull on a branch, git pull seems to be taking over a minute and is using a consistent ~20% CPU on all cores of my 4 core (8 virtual core) machine, for the duration. This same behavior is occurring for another user/computer.

a new commit

Are you sure it's only pulling ONE commit?
This repo has like<PHONE_NUMBER>3465 commits per second... so I wouldn't be surprised if it's just taking a while to parse all the deltas.

@EmpireJones If you do a keybase log send, and post the resulting ID here, I can take a look.

@dabura667 To clarify, I'm referring to a team repo. But yes, only one commit.
@strib be070d5ea27fde18b31af71c
Thanks!

Yeah, that should be the one.
Log sent, although I think that one might still be truncated.
Initializing Keybase... done.
Syncing with Keybase... done.
Counting and decrypting: 16 objects... done.
Reading and decrypting metadata: (100.00%) 16/16 objects... done.
Fetching and decrypting objects: (100.00%) 16/16 objects... done.

Thanks!  I don't see anything obviously unusual going on, other than all the data being read.  A few more questions:

Has this happened for more than one commit, or did it happen just the once (on multiple devices) with the same commit?
If it was just one commit, did the commit contain an unusual amount of data?  A few big binary files checked in or anything?  The output above says only 16 objects, so I guess it wasn't a lot of files.

Do you know anything about the origin of the repo?  Was it imported from a pre-existing repo with a big pre-existing history, or was it empty initially and has grown only via keybase git commits?

More than one commit. I've noticed it during 2-3 commits so far (which is every time for this repo), but didn't before that because I was working on a branch alone (nobody else commiting).
N/A as it was more than one commit, but it was just a handful of lines of code in 4 files
Yep, pulling again happens quickly.
It's a somewhat big repo, but the majority of it is text/code; I try to avoid checking in any large files (e.g. binary), although it might have some graphics. It was previously stored on BitBucket and then AWS CodeCommit. I didn't truncate the history when switching to keybase.

I wasn't able to do a git gc inside of the .kbfs_git/ folder. I am getting these errors:
First Run:
error: unable to create temporary file: Interrupted system call
fatal: unable to force loose object
error: failed to run repack

Additional runs:
Counting objects: 24304, done.
error: pack-objects died of signal 7
error: failed to run repack

The ./objects/pack/ folder currently has 79 files.
Running git gc in my local repo folder did not result in any performance improvements.

Ah sorry, try git gc -quiet, then you can probably avoid those system call errors.

If that doesn't work, I can try to get you a build with a working keybase-based gc next week.

Does that only need to be run from one machine? If so, it didn't seem to impact performance.
Thanks for continuing to assist with this!

I discovered a large file (~90mb) which was committed accidently by a team member. I'm working on getting that removed from history, which will likely resolve the issue. It appears that just using a branch with the commit removed does not fix the performance issue (perhaps because it's still in the pack files from the other branches).

Does that only need to be run from one machine? If so, it didn't seem to impact performance. It ran without errors though.

Yes, just from one machine.  Oh well -- is there only one pack file now in that objects/pack directory?

Does this sound accurate -- that a large file would impact the checkout performance of future commits?

My gut instinct is that it wouldn't be related, especially not after the first time you fetched it.
Is this a repo you'd be willing to share with me (by copying it from your .kbfs_git into a shared folder with me, not by giving me access to the original) for debugging purposes?  Totally reasonable if the answer is no, but that might speed things up a bit.

Yes, after doing a git gc --quiet, there is only one file. I was able to get that file down from ~102mb to ~15mb by removing remaining branches with the large file (locally and remotely), but that didn't seem to help at all, so it seems the large file was a red herring.
Sorry, I can't share the repo. Thanks again.

Not yet, but we're supposed to be working on it this week.  But it won't be any better than the regular git gc, so I'm not sure it will help in your case.  It's hard for me to know what's going on without a way to reproduce the issue myself.
Maybe now that you only have one pack file, you can send logs again and I can take a fresh look?

@strib Good news, I was able find an easily reproducible case of this on a relatively small repo with many commits.

Clone https://github.com/helm/helm
Add keybase as remote and push to keybase
Copy cloned ./helm folder to ./helm2
Make a minor change in ./helm, and push
Pull change from ./helm2

Thanks so much for the repro!  I've spent most of the day trying to figure this out, and I think I have a grasp of it now, though I'm not yet sure how to fix it.  I'm going to open up an internal issue for it, but I'll summarize it here as well (though it's going to get a bit technical):

Our git layer uses the awesome https://github.com/src-d/go-git library, and creates a storage layer on top of KBFS to pass to go-git.
go-git has to treat the repo with the storage layer as its "local" repo, and communicates with the other one via the remote git protocol.  Since Keybase doesn't (and can't) implement this remote protocol, the Keybase repo is always considered the "local" repo, which the local checkout on the client's local checkout is actually the "remote" repo for this purpose.
Because of this, when a client pulls from a Keybase repo, we actually turn that into a push from the Keybase repo into the client's local checkout.
A push first lists all the commits that are in use as references on the client's local checkout.
Then it tries to extrapolate, using it's "local" storage (i.e., KBFS) the COMPLETE list of commits and git objects that is implied by the initial list of commits.  This entails walking the entire git commit history that precedes each commit.
That would be pretty fast if you're using local storage, but it turns out that's pretty slow in KBFS, and that's where the time and CPU is used up.

What I think we want to happen in this case is one of two things:

Fetch the entire list of objects from the client's local checkout, rather than trying to get them from KBFS.  Unfortunately, this git remote protocol doesn't have a way to do this easily as far as I can tell, and we'd have to carve up go-git pretty badly to get around that.
Re-write go-git's push algorithm to only inspect objects that differ between the asked-for commit and the client's advertised references.  I started in on this a little bit today, but it's a pretty big change and seems to require some new machinery in go-git that I'm not prepared to work on right now.

I'll try to put some effort into the second option sometime in the next week or two.

Hey, any news on this thread? We are also experiencing the issue with git pull when there is at least one commit to pull, it takes several minutes to complete (~5 minutes). Whenever I do a push I see a message that says:
	keybase git gc ?? --?? ??```

But when I try it I get this:

```This may take several minutes...
▶ ERROR Getting object d66c??????????????????8bfa failed: object not found```

I have tried the above command a few times and I have gotten a an error on a different hash each time.

There's been some discussion of it here, but it looks like it's going to take a lot of work so we haven't been able to prioritize it yet: https://github.com/src-d/go-git/issues/909.  We're a small team that has a few other things going on right now.
Your "object not found" issue seems unrelated.  Please open a new issue for it, and run keybase log send to include a log so we can debug it.

Ah ok, thanks for the reply. I just thought it could somehow be related to the same issue. I just did another keybase git gc and it succeeded :)

@strib I see you're still pursuing this issue.
My pulls are always quick but fetching has become extremely slow for all machines. I've gc'd the KBFS repo, no change. If you think this issue is related then I'll just hold tight but otherwise I'm happy to send logs and create a new issue if necessary.

@soulofmischief probably related.  I'll be working on a fix this week I hope...

The next Keybase release should have significant performance improvements for fetches/pulls on repos with large histories.  In the helm example above, when pulling a single new commit, the time taken on my machine went from 3m48s to less than 5s.  (It's available in the unstable Linux nightly build now, see https://keybase.io/docs/linux-user-guide#nightly-builds if you're interested.)
Thanks for everyone's patience here.  I think our long national nightmare is almost over.


Fixed cast exception. Implemented proper logic for 1507 issue

This change is

PR is added to the queue for testing as 1. task. (4e01fb7)

Test 95006592 (4e01fb7) build started.

Review status: 0 of 3 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@yaronyg Tested locally with ThaliTest and ThaliTestApps. LGTM's are based on these results.
I'm going to merge after CI will be back and the build will be completed

Test 95006592 (4e01fb7) build started.

Test (Success) 95006592 build is completed (4e01fb7)
See https://github.com/ThaliTester/TestResults/tree/950065924e01fb7_Fixed_cast_exception__Implemented_proper_logic_for_1507_issue_evabishchevich/ for the logs

Test 950065924e01fb7(4e01fb7) has failed
See https://github.com/ThaliTester/TestResults/tree/950065924e01fb7_Fixed_cast_exception__Implemented_proper_logic_for_1507_issue_evabishchevich/ for the fail logs


Hamburger menu

Hi, I am interested to make it. Can you assign me?

@Chetan-khachane, any chance @debersole81 can help out developing this component together with you?

I am working on forked version.> Yes, I'm happy to. @Chetan-khachane, is there a branch that you're working in?


Issue handling the message from the browser

Hi, sorry for my english.
Sometimes the module can handle the request like so:

other times it splits the message in two parts and can't pass your if statement like so:
.
PS. This happens in the same process with the same postMessage the only thing that change is the time :smile:.

I had the same issue (with firefox), the issue is that sometimes (not sure if this is firefox specific or not) Firefox will send only the size of the payload, and in its next batch of stdout spamming will send the actual payload.
So if you try to read the size off stdout each time the readable event is emitted, you'll read a garbage size.
I created a simple library which addresses the issue, I know I should have submitted a PR here instead but this issue was more than a year old with no activity so I didn't :(
Someone can easily "steal" the code from there to patch this.


SMTP: Crashes when email address is invalid

Describe the bug
When sending an email with Swoosh.Adapters.SMTP, if the email address contains invalid characters, for example [], the adapter crashes with MatchError, rather than reporting an error tuple.
The match error is produced here:
https://github.com/gen-smtp/gen_smtp/blob/685fc92893297d8d726cae1029b9568ae79a0ead/src/mimemail.erl#L999
So maybe this is an issue with gen_smtp, or maybe :mimemail.encode expects valid data, so the adapter should call :smtp_util.parse_rfc5322_addresses on the addresses itself before encoding?
Steps to Reproduce the Bug or Issue
Working:
iex> email = Swoosh.Email.new() |><EMAIL_ADDRESS>|> Swoosh.Email.text_body("text body") |><EMAIL_ADDRESS>iex> Swoosh.Adapters.SMTP.Helpers.body(email, [])
"Content-Type: text/plain;\r\n\t charset=\"utf-8\"\r\nFrom<EMAIL_ADDRESS><EMAIL_ADDRESS>\r\nMIME-Version: 1.0\r\nDate: Fri, 7 Apr 2023 11:45:26 +0000\r\nMessage-ID: <fc0cf5f012037f29f3d111b7dc034fea@58ab8ec4cf1d>\r\n\r\ntext body"
iex> Swoosh.Adapters.SMTP.deliver(email, [])
{:error, :no_relay}

Broken:
iex> email = Swoosh.Email.new() |><EMAIL_ADDRESS>|> Swoosh.Email.text_body("text body") |><EMAIL_ADDRESS>iex> Swoosh.Adapters.SMTP.Helpers.body(email, [])
** (MatchError) no match of right hand side value: {:error, {1, :smtp_rfc5322_parse, ['syntax error before: ', ['"[foo]"']]}}
iex> Swoosh.Adapters.SMTP.deliver(email, [])
** (MatchError) no match of right hand side value: {:error, {1, :smtp_rfc5322_parse, ['syntax error before: ', ['"[foo]"']]}}

Expected behavior
An {:error, _} tuple is returned according to the @spec of deliver/2, rather than a MatchError.

We probably shouldn't do anything tricky to cope with this hard match in gen_smtp.
The code would be too brittle and hard to maintain.

Closing as not intending to cope with match failure from gen_smtp.

@princemaple I think it should be pointed out that gen_smtp itself does not crash when sending to an invalid address, this is caused by the way swoosh is using gen_smtp to validate the emails.

I'll take another look


[1914] Database restore workflow

Description
Download backup from Azure storage and restore it to the production environment
Review
See successful run: https://github.com/DFE-Digital/claim-additional-payments-for-teaching/actions/runs/9938477627/job/27450990068

 Claims migrate production


[SPARK-37548][INFRA][R][TESTS] Add Java17 SparkR daily test coverage

What changes were proposed in this pull request?
This PR aims to add Java 17 SparkR daily test coverage.
Why are the changes needed?
To support Java 17 for SparkR in Apache Spark 3.3.0.
I manually tested SparkR UT on Java 17 on MacBook Pro (16-inch, 2021) Apple Silicon M1 Max.
$ java -version
openjdk version "17.0.1" 2021-10-19 LTS
OpenJDK Runtime Environment Zulu17.30+15-CA (build 17.0.1+12-LTS)
OpenJDK 64-Bit Server VM Zulu17.30+15-CA (build 17.0.1+12-LTS, mixed mode, sharing)

$ build/sbt -Phive -Psparkr test:package

$ R/install-dev.sh

$ env SPARK_HOME=$PWD R/run-tests.sh
...
══ Skipped ═════════════════════════════════════════════════════════════════════
1. sparkJars tag in SparkContext (test_Windows.R:22:5) - Reason: This test is only for Windows, skipped

══ DONE ════════════════════════════════════════════════════════════════════════
...
+ popd
Tests passed.

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually review. This should be tested after merging.

cc @HyukjinKwon and @LuciferYang

cc @HyukjinKwon and @LuciferYang

Test build #145924 has started for PR 34808 at commit e073a9d.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50400/

Thank you, @HyukjinKwon ! Merged got master.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50400/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50400/

Test build #145924 has finished for PR 34808 at commit e073a9d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/145924/

LGTM +1

FYI, it passed.

https://github.com/apache/spark/runs/4422975410?check_suite_focus=true


fix: product card overflow

Related Issue
Closes: #620
Describe the changes you've made ✍

Changed the structure of Product Card (ProductsCard.jsx)
Removed an unnecessary div from Products.jsx
Modified Products.css

Screenshots (if any) 📸

Great PR @SteveSayantan , do wait a while  - it will take some time to review.


License requirement

Can you clearly specify the license requirement.
Do you only need one license for your whole tenant, or do you need to license every user. Yes with one license you have the feature, but are you also complaint.
The current line is open for interpretation.
Using this feature requires an Azure AD Premium P2 license. To find the right license for your requirements, see Comparing generally available features of the Free, Basic, and Premium editions.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6fe2fc28-2c44-e088-f079-067bafd1ae58
Version Independent ID: 6b987664-a403-4b79-4faa-eb4465c33a40
Content: Azure Active Directory Identity Protection
Content Source: articles/active-directory/identity-protection/overview.md
Service: active-directory
Sub-service: identity-protection
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@barkesteijn Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

Azure AD is licensed per user.

#please-close


fix custom fetch example init type in README.md

[x] I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested
Just bumped on an type issue with custom fetch when I tried to use the example in README.md
Additional context & links
https://microsoft.github.io/PowerBI-JavaScript/modules/_node_modules_typedoc_node_modules_typescript_lib_lib_dom_d_.html#fetch

Thank you for the contribution!

Cool looks like this is fixed on your side now with the stainlessbot / autogeneration, closing


Option to manually pass country

No results are found when trying this query (don't question the song ;) ):
https://itunes.apple.com/search?term="a touch of class my heart beats like a drum"&country=BE
However, this query returns the correct song (it's a German band)
https://itunes.apple.com/search?term="a touch of class my heart beats like a drum"&country=DE
Perhaps include a tag like --country to manually specify the country of the iTunes store to search?

Thanks for pull request #27!


ValueError: Object arrays cannot be loaded when allow_pickle=False

[485:486]svaing file: ./data/processed/TM1-100131_0.npy
[485:486]svaing file: ./data/processed/TM1-100131_512.npy
save file: ./data/processed/TM1-100132
audio mcep shape (36, 512)
[486:486]svaing file: ./data/processed/TM1-100132_0.npy
Traceback (most recent call last):
File "preprocess.py", line 200, in
generator.generate_stats()
File "/home/user/sources/StarGAN-Voice-Conversion/utility.py", line 158, in generate_stats
d = t.f.arr_0.item()
File "/home/user/.local/lib/python3.6/site-packages/numpy/lib/npyio.py", line 94, in getattribute
return object.getattribute(self, '_obj')[key]
File "/home/user/.local/lib/python3.6/site-packages/numpy/lib/npyio.py", line 262, in getitem
pickle_kwargs=self.pickle_kwargs)
File "/home/user/.local/lib/python3.6/site-packages/numpy/lib/format.py", line 722, in read_array
raise ValueError("Object arrays cannot be loaded when "
ValueError: Object arrays cannot be loaded when allow_pickle=False

conda install numpy=1.16.2

conda install numpy=1.16.2  is working

Ya, conda install numpy=1.16.2 this working. thank you  cnSchwarzer

hey admin @hujinsen  or @salisbury-espinosa you can close these issues. As this issue got solved.


Add TEM routine

After #7. Add modelling routine for TEMs (TDEMs):

Central loop
Loop-loop (already possible, model.loop)
Coincident loop

For the coincident loop there is the issue of zero offset.

They are possible, as such I am closing this issue. It might be good, however, to add more examples.


How to add this library with lvgl?

Hi,
First of all this not a bug.
i am facing issue while attaching your library with LVGL.
Sir if possible then please update the Readme in simpler words so that any one can understand.
Thanks
Shrikant Vaishnav

The README is well written in my opinion.
I think you'll have to be more precise about what problems you are facing or what kind of project setup you have.
The only minor issue being that the README is suggesting to manually install as submodule (for use in projects) in one section and recursive clone in another section (for examples) -  to me, it should always be up to the user how they install the app and introducing both terms (submodule / recursive clone) might be confusing to those who do not understand git submodules.
However, there's also https://github.com/Ryzee119/lvgl-sdl/tree/master/example which shows how to use it with just the file structure (regardless how you filled got those folders) with both, CMake and Makefiles.
My understanding is that you only have to run the init for this specific port (which is shown in the example which is referenced in the README):
https://github.com/Ryzee119/lvgl-sdl/blob/b4f4ac73a93b5327fff9f79cad94b7098c6087c9/example/main.c#L24-L28
(which is also the only exposed API from https://github.com/Ryzee119/lvgl-sdl/tree/master/lvgl_drv)

This library has somewhat long since superseded with upsteam lvgl's SDL port https://github.com/lvgl/lvgl/tree/master/src/drivers/sdl
As JFR pointed out we are targeting quite an old version here and I made this a long time ago. If you're developing something new you may want to explore lvgl v9.
In anycase I dont plan on updating the readme. Please provide error logs or something. If I was take a guess you are not pulling in the submodule correctly. but this is covered by the README already


Use None instead of NoReturn

Fixes #112

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (3103262) 100.00% compared to head (40f2466) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff            @@
##              main      #113   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           47        47
  Lines         2194      2194
  Branches       272       272
=========================================
  Hits          2194      2194

Impacted Files
Coverage Δ

dbt_checkpoint/generate_model_properties_file.py
100.00% <100.00%> (ø)

dbt_checkpoint/tracking.py
100.00% <100.00%> (ø)

dbt_checkpoint/unify_column_description.py
100.00% <100.00%> (ø)

dbt_checkpoint/utils.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Thanks for the review and merge!


Fixed issues when using rusty-tesseract from crates.io

I tried to use this crate from crates.io in one of my project but i got a "unresolved import rusty_tesseract" error:

In this PR i changed the name of the modul "rusty_tesseract" to "tesseract" to avoid name conflicts with the name of the project root.  I added a re-export for "ndarray" and made the moduls "error" and "tesseract" public.  I also fixed some warnings from the rust-compiler.

Looks great, thanks!


fix: old list widgets incorrect page size broke pagination controls

Description
Old list widgets have a legacy parentRowSpace value 40 which lead to incorrect calculation in the pageSize which was very high than it should be. This leads to the pagination not appearing when server-side pagination is disabled.
Note to Reviewer:
For some reason the parentRowSpace in the widget is 10 and in derived properties it is 40 (which is present in the DSL).
The solution for now is to hard-code the value of parentRowSpace as 10 in the derived properties.
Fixes #12438
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual
Cypress

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test=74a1789

/ok-to-test=74a1789

@ashit-rath LGTM, tested page size change too on the DP.


Gradle + Spring Boot + Spring Cloud Edgeware.RELEASE result in dependency error

Hi,
not sure whether this issue fits to this project, because I guess it's a problem with the "Edgeware.RELEASE" release itself.
I'm using Gradle 4.x and Spring Boot 1.5.9.
I've included the BOM of Spring Cloud via the "mavenBom" functionality of the "Spring Dependency Management Plugin" (basically the same setup that is mentioned on the Spring Cloud homepage).
There is only one dependency declared in my script via compile "org.springframework.boot:spring-boot-starter-web".
When I try to resolve this dependencies, Gradle will fail and complain about the missing dependency "org.springframework.boot:spring-boot-starter-web". For some unknown reason the Spring dependency management plugin will fail on using the mentioned Spring Boot version 1.5.9 during resolution.
As soon as I comment out the "mavenBom" line, the resolution works without a problem.
By the way: This is working properly when using the "Dalston.SR4" release.

To make sure I can reproduce this properly would you mind providing a project that reproduces the problem?

Argh ... seems this is completely my fault: The release is called "Edgware" not "Edgeware".
And trying to import a non existing bom doesn't throw an error but instead simply breaks the dependency resolution. :-/
Sorry for bothering you.

NP, lots of people assume it is "Edgeware" :)


The get_inputs_and_outputs_serialized doesn't work as intended

In my PR here, calling the get_inputs_and_outputs_serialized function doesn't give me all of the inputs but just 1 of them:
https://github.com/uwsampl/churchroad/blob/256d52a8a6d6931519795af4af9be3001fc6043e/src/lib.rs#L1880
https://github.com/uwsampl/churchroad/blob/256d52a8a6d6931519795af4af9be3001fc6043e/src/lib.rs#L624

Run cargo test compile_rewrite_rule --  --nocapture on my PR to see the print output. I'm probably not going to use it and will just add the inputs when I see it instead.

oh wait, the module does have just 1 input my bad

can you just delete this issue, it's not actually an issue.


Put default interface verifier behind an env var

Without setting this variable, we won't enable module interface verifier unless
explicitly asked to.

@swift-ci please test


Updated Set-DbaErrorLog

made some updates to the command and the tests. simplified output and names. updated help to be more accurate. required sqlinstance. added dbasize
note that the parameter validation did not work so i used the native

Simplified output

🤔 is there a way to modify the path or is that just sqlwmi?

The path for errorlog is changed by using Set-DbaStartupParameter, that is the only way to change it without going directly to the registry.

got all passes!


update from old missing CDN ui-bootstrap to an current

Requires setting the build to release in appveyor:

Additionally, this PR includes changing the nuspec file to auto-version, and I updated the auto assembly patching in my appveyor build. You can find that info here http://www.daveaglick.com/posts/deploying-a-public-nuget-package-from-scratch

Thanks @lukeschafer

:+1: @brucem :)


c3 time series scatter chart, time data in y axis.

C3 version: 0.4.10:
D3 version: 3.5.5:
Browser: Firefox 55.0.3:
Client OS: Windows 10:
Server OS: CentOS 6:

I am working on a C3 time series scatter chart.
http://jsfiddle.net/dewanshamsul/f81ymrpc/1/
I want to use time data in the y axis like the following:
http://jsfiddle.net/dewanshamsul/t6rtLofc/
But it is not working.
I tried to use
y: 'Time',
    yFormat: '%H:%M:%S',

axis: {
    y: {
        type: 'timeseries',
            tick : {
                    format: d3.time.format("%X",)
            },
    },

I saw one example in R where someone plotted time data in y axis so I was wondering whether it is supported or I am missing something?

How about rotating axis by axis: { rotated: true } option? like http://jsfiddle.net/f81ymrpc/2/

I am extremely sorry. Somehow I posted the wrong jsfiddle. Please check the updated fiddle now.
http://jsfiddle.net/dewanshamsul/t6rtLofc/
I have Date in x axis in the following format 2017-09-05
I have Time in y axis in the following format 13:30:45
Getting to plot the time in y axis is the main issue.

It seems like the thing I am asking for is not supported at this moment. So I have to convert the time either to timestamp or in other format which are supported.


Update Nuget package

Can you please update the NuGet package the last version is for 2016

I would also like an update to the NuGet package. I was trying to use this in a project, but need the new FramesToVideo method in order to do so.

@GlaceusFrost you can use direct source from this branch
https://github.com/it14118/MediaToolkit/tree/p2
it contains the FramesToVideo method

Yeah. That's my temporary work around. I had just already set my project up with the NuGet package, and would prefer to use NuGet rather than a downloaded copy.


pico brick after click on update kmk in the firmware tab

i accidentally click on the update kmk in the firmware tab now i cant press anything even after doing the flash nuke the coord finder just didnt output anything

yes the current kmk version has some changes that break pog, I am working on a way to lock to known working versions of kmk but this has been a bit difficult

so is there any stop gap solution currently

somehow after like a billion of flash nuke i got it to work again many thank for the project


Revisit CentOS 8

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area crawler

/area ci

/area utils

What this PR does / why we need it:
All I'm doing here is cleaning up the CentOS mirror list a little with comments and re-enabling CentOS 8. Believe it or not, CentOS 8 (though a dead OS) is on our support list internally.
Which issue(s) this PR fixes:

Fixes # N/A
Special notes for your reviewer:

Believe it or not, CentOS 8 (though a dead OS) is on our support list internally.

:skull:


OS X and Windows builds failing

The failures seem unrelated.
OS X: https://travis-ci.org/conda-forge/glpk-feedstock
Windows: https://ci.appveyor.com/project/conda-forge/glpk-feedstock/branch/master
There weren't any problems when #13 was merged.

I think the builds just need re-running.

Everything seems to be caught up now.


[10.x] Introduce Custom Validation Rules for Model and Model Fields with OnCreateRules and OnUpdateRules Attributes

Attributes
Allows the ability to add structured and machine-readable metadata information on declarations
Database fields have types to define the kind of data that can be stored in them and to ensure data integrity and consistency.  We usually do these types of setups in migrations. Different types represent different kinds of data, such as numbers, strings, dates, and more. By specifying the type of a field, the database can perform validation and enforce rules to make sure that only valid and appropriate data is stored in that field. This helps prevent errors, maintain data accuracy, and improve query performance. Additionally, field types play a role in optimizing the storage and retrieval of data in the database.
By indicating the field types within migrations, we are effectively ensuring adherence to data integrity standards as data is stored, however, migrations are only executed once. Enabling users to update and adapt validation rules within the model offers a valuable advantage in responding to evolving application requirements. This feature empowers developers to easily customize validation rules based on changing business needs, without the need to modify the database structure. By providing a dynamic and agile approach to validation, developers can ensure data integrity while maintaining the flexibility to accommodate new regulations and user demands. This capability enhances the efficiency and adaptability of the validation process, ultimately contributing to a more robust and responsive application.
Added:

Introduced a new validation improvement for Eloquent models.
Added the ability to define validation rules using custom attributes: OnCreateRules and OnUpdateRules.
Added the validateUsing method in the Model class to support custom validation rules.
Added property  protected array $rules;

Changed:

Updated the booted method in the Model class to automatically validate on creation and updating.
Added a new static call for method validateUsing inside __callStatic method to call the method dynamically and statically

Context:
This enhancement improves data validation for Eloquent models by allowing developers to define specific validation rules using custom attributes. The new attributes, OnCreateRules and OnUpdateRules, enable you to tailor validation rules for model creation and updates, respectively.
By using these attributes, developers can fine-tune validation for individual models, properties, or attributes, giving more control over data integrity. This enhancement helps streamline validation logic and promote better code organization.
Examples:

Validation on Creation:
use Illuminate\Database\Eloquent\Validations\OnCreateRules;

#[OnCreateRules(['name' => 'required', 'email' => 'required|email'])]
class User extends Model {
    // ...
}

Validation on Update:
use Illuminate\Database\Eloquent\Validations\OnUpdateRules;

#[OnUpdateRules(['email' => 'required|email'])]
class User extends Model {
    // ...
}

Applying both attributes to the Model:
use Illuminate\Database\Eloquent\Validations\OnUpdateRules;

#[OnUpdateRules(['email' => 'required|email'])]
#[OnCreateRules(['name' => 'required', 'email' => 'required|email'])]
class User extends Model {
    // ...
}

Using on model fields:
use Illuminate\Database\Eloquent\Validations\OnUpdateRules;

#[OnUpdateRules(['email' => 'required|email'])]
#[OnCreateRules(['name' => 'required', 'email' => 'required|email'])]
class User extends Model {
   #[OnUpdateRules([ 'required'])] --> this is also valid
    protected string $name;

    #[OnUpdateRules(['email' => 'required|email'])]  --> This is valid as long as the key matches the property
    #[OnCreateRules('required|email')] --> this is also valid
    protected string $email;
}

Custom Rules with Validation:
$product = Product::validateUsing(function ($rules) {
    $rules['price'] = 'numeric|min:0';
    return $rules;
})->create($data);

Automatic Validation on Creation and Updating:
protected static function booted()
{
    static::creating(function (self $model) {
        $model->getModelRules(useOnCreateRules: false);
        $model->getPropertyRules(useOnCreateRules: false);
        $model->validate();
    });
    static::updating(function (self $model) {
        $model->getModelRules();
        $model->getPropertyRules();
        $model->validate();
    });
}

Note:
This pull request is a work in progress and is being submitted for initial review and feedback. Further improvements and adjustments will be made based on the feedback received.
Please note that this does not enforce any developer to use this, this only start taking effect once the attributes are applied to the model or properties

@taylorotwell
Why are you closing PRs that add good features to the framework?
This PR is surely better than removing a few files and adding a few variables to the env! ( Slim skeleton )

@taylorotwell I still feel that we need this feature in laravel, this can be very useful for day-to-day use


App keeps freezing and shows 3% battery

When i open the app it freezes and 1-2 minutes later it shows 3% battery and freezes again i have 3060ti  ryzen 5 5500 it shouldnt be freezing

App also freezes for me, however it stays frozen for the entire time.
CPU: AMD Ryzen 7 3700X
OS: Windows 11 Pro 22H2 (build 22621.1485)

Yeah it just freezes for me

Let me try and reproduce and figure out what's going on

Also with Arctis 1 here (xbox edition) and when the dongle pluged-in app freezes instantly.


Extract AndroidStudioProvisioningPlugin from PerformanceTestPlugin

Fixes #27499
We want to reuse PerformanceTest AndroidStudio provisioning infrastructure in a new type of integration tests in CC project. These tests are going to test sync with AndroidStudio (and IDEA in future), so it need to obtain an IDE somehow.
This PR is extracting logic of AS provisioning from PerformanceTestPlugin to AndroidStudioProvisioningPlugin as is.
Also, AndroidStudioProvisioningPlugin is allowing to configure a version of AndroidStudio that will be provided.

@bot-gradle help

Currently, the following commands are supported:
@bot-gradle test <BuildTrigger1> <BuildTrigger2> ... <BuildTriggerN> [without PTS]
Add without PTS to run the build with full test coverage.

A trigger is a special build for this PR on TeamCity, common triggers are:

SanityCheck/CompileAll/QuickFeedbackLinux/QuickFeedback/PullRequestFeedback/ReadyForNightly/ReadyForRelease
Shortcuts: SC/CA/QFL/QF/PRF/RFN/RFR
Specific builds:

BD: BuildDistributions/BuildDocs so that you can preview the generated docs/distribution.
PT: PerformanceTest, all performance tests for Ready For Nightly stage.
APT: AllPerformanceTest, all performance tests, including slow performance tests.
AST: AllSmokeTestsPullRequestFeedback
AFT: AllFunctionalTestsPullRequestFeedback
ASB: AllSpecificBuildsPullRequestFeedback
ACC: AllConfigCacheTestsPullRequestFeedback
ACT: AllCrossVersionTestsReadyForNightly
AFTN: AllFunctionalTestsReadyForNightly
ACTR: AllCrossVersionTestsReadyForRelease
AFTR: AllFunctionalTestsReadyForRelease

@bot-gradle merge

queues this PR for testing and merges if all tests pass by:

Creating a merge commit from your PR branch HEAD and the target branch
Running a ReadyForNightly build against the merge commit
When it passes, fast-forward the target branch to this merge commit (i.e. merge the PR)

The merge commit is called a pre-tested commit, which means that it fully tests the integration
of your branch HEAD and latest master, instead of only testing your branch HEAD.
@bot-gradle squash

Squash the current pull request into a single commit. The squash message will come from the pull request body, with:

All Signed-off-by: lines kept.
All authors being Co-Authored-By:.

@bot-gradle cherrypick to <branch>

Cherrypicks the current PR to another branch.
A new PR will be created and a build will triggered automatically if there is no conflict.

@bot-gradle cancel

cancel a running pre-tested commit build or remove it from queue

@bot-gradle clean

clear the conversation history

@bot-gradle help

display this message

To run a command, simply submit a comment.  For detailed instructions see here.

@bot-gradle test PT

I've triggered the following builds for you. Click here to see all build failures.

AllPerformanceTestsReadyForNightly build

@bot-gradle merge

The merge queue build has started. Click here to see all failures if any.


(BKR-300) Always manage_etc_hosts in cloud-init

Some cloud-init configuration does not have manage_etc_host: true so the VM does not have a valid FQDN which is quite annoying because some services refuse to start without a valid FQDN.
This patch force cloud-init to manage /etc/host and thus set a valid fqdn.

Can one of the admins verify this patch?

This won't get exercised in our testing, so we're just going to hope for the best!


add additional eslint rules from the base ruleset

Closes: RHOAIENG-1735
Description

This PR intends to enforce the following rules with an error severity:
"no-else-return": ["error", { "allowElseIf": false }],
"no-param-reassign": [
      "error",
      { "props": true, "ignorePropertyModificationsFor": ["acc", "e"] }
    ],
"react/prop-types": "off",
    "array-callback-return": ["error", { "allowImplicit": true }],
    "prefer-template": "error",
    "no-lone-blocks": "error",
    "no-lonely-if": "error",
    "no-promise-executor-return": "error",
    "no-restricted-globals": [
      "error",
      {
        "name": "isFinite",
        "message": "Use Number.isFinite instead https://github.com/airbnb/javascript#standard-library--isfinite"
      },
      {
        "name": "isNaN",
        "message": "Use Number.isNaN instead https://github.com/airbnb/javascript#standard-library--isnan"
      }
    ],
    "no-sequences": "error",
    "no-undef-init": "error",
    "no-unneeded-ternary": ["error", { "defaultAssignment": false }],
    "no-useless-computed-key": "error",
    "no-useless-return": "error",
    "symbol-description": "error",
    "yoda": "error",
    "func-names": "warn"

How Has This Been Tested?

npm run test
Test Impact

Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/lgtm
/approve


forge build result in Solc Error:  "Unknown version provided"

``I'm on an M2 MacBook with macOS 13.3.1 (a) (22E772610a) installed.
After successfully compiling the contracts, I try to run forge build and this is the error I get:
[⠊] Compiling...
[⠑] Installing solc version 0.8.20
[⠘] Failed to install solc 0.8.20: Unknown version provided
Error:
Unknown version provided

I thank you for your time and attention.

this is a dup of #84

Closing as #84 is done also


Create endpoint /getoverridetargets

See #29
We may be able to get around this some other way, assuming this about listing methods can be overridden.
cc @DustinCampbell

see #20 for pointers


Merge release/0.12.0 into develop branch

This PR merges release/0.12.0 code into develop branch.

A new PR had to be created in order to merge this one as it involves merging two protected branches: https://github.com/input-output-hk/daedalus/pull/1155


HTML, JavaScript and Brain.js frames

Hi again!
Last one here, this is a suggestion, I saw that you removed the CSS logo which I forgot to remove :P along with this line I just restored: :---:|:---:|:---: on the markdown so the logos show up in frames for if you like it better that way or the current one.
Have a great day!
Best Regards!
Nico

That's great. Thanks.


[builder] CxG schema 5 / Census schema 2

Builder support for Census schema 2.0.0 / CELLxGENE schema 5.0.0
Fixes: #993
Fixes: #1022
Fixes: ##796
Primary changes:

Request H5ADs in schema 5.0.0 format
Update Census schema to 2.0.0, in turn is pinned to CxG schema 5.0.0
Update assay filter to incorporate new RNA seq assays
Update UBERON release to match schema 5.0.0, used to infer tissue_general value
Clarify the handling of multi-species datasets and how they are included/excluded from the Census. As part of this, tighten typing on ExperimentSpecification to require a species/organism to be specified (i.e., mandate that each Experiment is associated with a single organism).
Add new census_info/organisms table specified in Census schema 2.0.0 (#796)

NOTE to reviewers: this will not be landed until we have completed a full test build and validated the build against the prior Census build.

@pablo-gar - thanks for the assay term changes.
Question/open issue:  the Census schema also defines special handling for the normalized layer, for any "Smart-Seq" assays.  Can we add the definitive list of which EFO terms are considered a Smart-Seq assay?  Ideally this would be included in the Census schema (or referenced as you did with the assay filter terms).

@bkmartinjr - In regards to issue #993  there is this point:
Confirm no use of CL:0000003, aka native cell. These cells will now be marked as unknown in both obs.cell_type and obs.cell_type_ontology_term_id columns. See related task: https://github.com/chanzuckerberg/cellxgene-census/issues/1019

Once a test build is produced, are we to check this manually in the python interpreter by doing a count of CL:0000003 in obs.cell_type_ontology_term_id and native cell  in obs.cell_type and checking that the count is zero?
Or should this be captured in some type of of post build acceptance test where some sanity checks about the data are done?

@prathapsridharan re:

are we to check

This is entirely an upstream issue in the DP process, and the builder does not enforce (or check) for this level of metadata compliance with the CxG schema.  These checks for compliance with the CxG schema are the provenance of the schema validation toolkit used by Lattice, et al.
We could do this kind of checks, but it is redundant, and adds linkages across layers in the system that don't add much value IMHO.

@atarashansky - we have included your requested organisms info (#796) in Census schema 2.0.0.  Current content will be:
In [4]: census['census_info']['organisms'].read().concat().to_pandas().set_index('soma_joinid')
Out[4]:
            organism_ontology_term_id organism_label      organism
soma_joinid
0                      NCBITaxon:9606   Homo sapiens  homo_sapiens
1                     NCBITaxon:10090   Mus musculus  mus_musculus

Please feel free to leave comments on both the Schema MD file changes and the code.

Light QC on test build shows no issues
Checks

Verifying fidelity in data additions, in particular changes to obs and addition to census["census_info"]["organisms"].
Checking new assays added based on updated list of assays, and verifying the addition of expected datasets.
Validating the existence of  previously missing data due to fixed filter for multi-species.
Validating calculation of normalized layer for SMART-like technologies

See notebook
https://colab.research.google.com/drive/1kb2ZR0MPxVsWBgJlIgrtJrkGPx5wqxIk


[Refactor/State] Done as a searate key

[ ] $done --- make this cleaner by adding a d field in subscription
[ ] $done in state need to add the type (this is in general a good idea)
[ ] defaultSubscription has to put the whole object -- not half
[ ] cleanup general sloppyness

call it .d
_.d


Python CBC MIP - is there a way to set GAP limit parameter

Hello,
I am trying to set the GAP limit parameter using CBC solver. I can set the Time Limit parameter using:
solver = pywraplp.Solver('Solver',
pywraplp.Solver.CBC_MIXED_INTEGER_PROGRAMMING)
solver.SetTimeLimit(4000) ## set to 4 seconds
Instead of using TimeLimit, can I set a GAP limit?
Thanks

Seems now a duplicate of #644


Custom Marker not showing correct position when zooming in or out.

React Google Maps - 9.4.5
While zooming in or out custom marker are not located at their correct lat-lng position.

@therajsagar this library is unmaintained, please refer to new library @react-google-maps/api


JS/TS crashed

Type: Bug
I just opened VSC and the crash was reported.
 It looks like you may be using an old version of VS Code, the latest stable release is 1.77.3. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


test decimal vector

Closing because it has been untouched for a while, in case it's still relevant feel free to reopen and move it forward 👍


make sure that our contracts are zkEVM compatible

THEY ARE NOT - because our token lock uses selfdestruct, which is not implement in zkEVM
if I remove that, the contracts compile fine