propagates field_filter queries to  dataset container

Codecov Report

Merging #1400 into master will not change coverage.
The diff coverage is 40%.

@@           Coverage Diff           @@
##           master    #1400   +/-   ##
=======================================
  Coverage   60.56%   60.56%
=======================================
  Files         183      183
  Lines        3999     3999
  Branches      914      916    +2
=======================================
  Hits         2422     2422
  Misses       1577     1577

Impacted Files
Coverage Δ

wherehows-web/app/routes/datasets/dataset.ts
16.66% <ø> (ø)
:arrow_up:

wherehows-web/app/constants/dataset-compliance.ts
75.92% <ø> (+0.22%)
:arrow_up:

...mponents/datasets/containers/dataset-compliance.ts
37.03% <ø> (ø)
:arrow_up:

wherehows-web/app/controllers/datasets/dataset.ts
22.91% <100%> (-0.34%)
:arrow_down:

wherehows-web/app/components/dataset-compliance.ts
25.14% <20%> (-0.07%)
:arrow_down:

...hows-web/app/routes/datasets/dataset/compliance.ts
33.33% <33.33%> (-16.67%)
:arrow_down:

wherehows-web/app/constants/datasets/shared.ts
72.22% <40%> (-5.06%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37802e2...f3c6b8f. Read the comment docs.

Coverage remained the same at 22.752% when pulling f3c6b8fdaab489db46861d75ed459430253d4dfc on theseyi:compliance-query-propagation into 37802e280be928e41a3c01ea257382b331a4839c on linkedin:master.


Fix/order

Resolves https://github.com/vigour-io/case-parser/issues/3
Seems to work where I tested it but would be great another pair of eyes

Coverage increased (+1.9%) to 93.75% when pulling 320828cb73022545ecbce5eb99093372a68e1da7 on fix/order into 41b4fd148199ef969a10b48e979fc62600dfa0b8 on master.


App Service Environment for PowerApps

At the beggining of the article you have a link "App Service Environment for PowerApps". Can you explain the "for PowerApps" part? Is this just an error in the article?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e30dfd76-2a83-bd21-2153-85e32894014e
Version Independent ID: 9dca62e8-0aef-10eb-b2d3-2ab12087f90a
Content: Integrate your ILB App Service Environment with an application gateway
Content Source: articles/app-service/environment/integrate-with-application-gateway.md
Service: app-service
GitHub Login: @ccompy
Microsoft Alias: ccompy

Thanks for your feedback! We will investigate and update as appropriate.

Not sure how that got in there.  thanks for pointing it out.  Fix is forthcoming.

@ccompy You can comment in your PR with Fixes #6080 and GitHub will tie the issue and the PR together

#please-close

@JozoSlejko
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


[BEAM-9918] Support Tagged external PTransforms

Support user side direction of cross language or external transforms.
Often the runners have their own mechanism for interpretting a URN + Payload, but that payload may contain data to specify how to route the inputs and outputs. ExternalTagged permits users to provide local tags for the input PCollections and output PCollection types to assist with this routing.
Later changes may want to add variadic Options to External and ExternalTagged to support Artifact provisioning, and Environment setting, though preferablly without using the beam protos directly in the API. (Similarly for ParDo as well).

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @youngoli @robertwb
CC: @ananvay @tysonjh


Add back in OpenBMC updates

Put back in some OpenBMC changes that were lost
in the last few commits.
Signed-off-by: Matt Spinler<EMAIL_ADDRESS>

Verified that non-BMC changes from last few commits are intact.


Rename event-delivery.md to event-delivery.md.

Proposed changes

Merge timing

Related issues (optional)

Hi @feim9208, why did you want to rename this file?


Feature: getting job artifacts

Is it possible somehow download job artifacts besides switching to aiohttp and doing downloads outside of ujenkins module?
If not would it be possible to create new function to download these artifacts, similar to getting console output?

Hello! Thanks for feature request. So you want some interface like this?
Artefacts names could be get from builds.get_info()
{
  "artifacts" : [
    {
      "displayPath" : "test.txt",
      "fileName" : "test.txt",
      "relativePath" : "test.txt"
    }
  ],
}

with open('archive.tar.gz', 'wb') as f:
    content = client.builds.get_artifacts('job', 123, 'archive.tar.gz')
    f.write(content)

Thank you for the quick response!
currently I need only that first part of getting the content from the artifact. Only one small detail if it can be get_artifact as we are getting only one ;)

@robooo or it better to have same function like builds.save_artifacts('job', 123, 'archive.tar.gz', '/tmp/local_path/') ?
Because return binary content is not always good idea because of huge artifacts will be buffered in Python runtime which could be OOM killed by system, here better have possibility to read and save it by chunks.

@robooo please check https://github.com/pbelskiy/ujenkins#working-with-build-artifacts
I will release it in few days.

Thanks for quick implementation @pbelskiy !
looking good, probably found one minor wrong comment:
https://github.com/pbelskiy/ujenkins/blob/master/ujenkins/endpoints/builds.py#L100

Hi @pbelskiy, any new release soon?

@robooo sorry, I will release it on this weekend!

@robooo https://github.com/pbelskiy/ujenkins/releases/tag/v0.10.0


Cannot view text as the web shown the text has been viewed and deleted

It seems to be ok today. Not sure what happen back then.


Export key event state on pick/select

Hi Alex, another edge case here for you :-) Basically when I select something on screen, I'd like to also receive the key press state in the associated signals.js event pickingData parameter
At the moment I've done a hack on my own version to get the ctrlKey state:
At https://github.com/arose/ngl/blob/master/src/stage/picking-controls.js#L160
I stick in the line
pd.ctrlKey = e.ctrlKey;
just before pd is dispatched to the signals.clicked event
I'm wondering if there's a better or more general way to do it?

What about listening to keypresses globally and put the currently pressed key into you application state?

That could work yeah. A key down and up listener on my view that stores the current keystate for the view, and then I/we don't need to change ngl code.

Hey, decided to add alt/ctrl/meta/shiftKey to pickingData object, see ceede4ca4dd2d3dfc51ea9eb330aac6db421ca4f

Thanks Alex


Tutorial - angular 1 - Step 15 does not load

I cannot load Step 15. The headline changes, but the content stays the same like the referring page.

@westor21
Can your provide your .meteor/versions?
Also, does this works for you? http://socially-step15.meteor.com/parties
Thanks

Fixed in https://github.com/Urigo/angular-meteor/pull/935
@Urigo  please merge

Merged and deployed, thanks @westor21 and @dotansimha


Shell Command Injection

Due to the using of /bin/sh -c blablabla... it can execute an arbitrary command with forged 'input'.
i.e.
const qpdf = require('node-qpdf');
qpdf.decrypt('/the/path/of/filename.pdf; ls -al; rm -rf /', 'somepassword');

It could take a time to resolve this issue, but at least it should be documented(to avoid putting arbitrary path on a first argument).

If the first argument used path.resolve would that help mitigate injection?
const path = require('path');
const qpdf = require('node-qpdf');
const injectString = '/the/path/of/filename.pdf; ls -al; rm -rf /';
qpdf.decrypt(path.resolve(__dirname, injectString), 'somepassword');


Pinpoint 1.8.2 - MongoDB calls not intercepted

Created a sample application that connects to a local MongoDB instance, queries a collection, loops through the cursor and print each document.
Run the application by passing the options below.
-javaagent:/home/asgs/pinpoint-agent/pinpoint-bootstrap-1.8.2.jar -Dpinpoint.agentId=gowri-local-test1 -Dpinpoint.applicationName=gowri-local-test1

What did you do to trigger the bug?
We're not able to see MongoDB component on the remote Pinpoint Web server.
Expected behavior
We should be able to see the MongoDB as one of the external components that the application running the agent is connecting to
Logs
gowri-local-test1-pinpoint.log.zip
Additional context
Tried running the application with both mongodb-driver and mongo-java-driver (versions 3.5.0 and other versions below 3.9.0)

+1

Hello, @asgs @ychandu
I've created the plugin since after 3.0 has released.
Since, their recommendation on accessing Database and Collection was through below classes
import com.mongodb.client.MongoCollection
import com.mongodb.client.MongoDatabase

I didn't instrument the ones used in 2.x
com.mongodb.DB
com.mongodb.DBCollection

So, if you are using below classes to access DB and Collections, it won't be traced.
(I'm not sure I can work on this at the time being)
Two solutions.
You can you the APIs as Mongo Team recommended.
Or
little modification to Mongodb plugin (add DB,DBCollection to the plugin)
I'd love to guide your way if you are willing to upgrade the plugin and contribute :)

@RoySRose  you're right, tracing works when the 3.x classes are used. Let us know how we could update the plugin to trace the 2.x classes as well.

@asgs
I've looked into the library of Mongo-driver to check classes
com.mongodb.DB
com.mongodb.DBCollection

There are 2 parts that you need to instrument.

Connection part (getting MongoClient, DB, Collection)
Session part (CRUD)
You can assume what the classes are doing in Pinpoint-Mongodb-Plugin.

The bad news is, I thought it would need LITTLE modification.
I thought only 1. Connection part needs to be supplemented.
But after getting into the details. I found out the name of methods that manage CRUD is different from mongo-java-driver 3.x.
So, 2. Session part (CRUD) also need to be supplemented, too.
If you still are willing to proceed on this.
Please check out the codes in Pinpoint-Mongodb-Plugin.
and let me know if you have further questions.
Plugin dev guide may also help you if you got stuck on the way.

@RoySRose we're trying to make some changes related to the Connection Part and rebuild the plugin to test in the local environment. But running mvn -e clean package from the root of the pinpoint repository provided warnings on missing Environment variables for Java 6, 7, 8, and 9. Since only Java 8 is available, all four environment variables were set to the same Java 8 path. After rerunning the mvn command, this warning is now gone. But a compilation error is seen. It's not clear what the compilation error is or how to debug it further.
Also, if there is a way to just build the mongodb plugin, it would be much easier

Ignore the above, please. The environment variable set was incorrect.
Will let you know about the progress further, @RoySRose

@asgs

Also, if there is a way to just build the mongodb plugin, it would be much easier

You can build mongo plugin module and after that pinpoint-agent module

@RoySRose we've made some changes to the MongoDB plugin to trace the 2.x version of the classes you mentioned above. It appears to work, but with the following issues.

The MongoDB component shows up empty in the main view. In the timeline view, it's listed as UNKNOWN_DB
The name of the MongoDB database shows as unknown, too.

Thankfully, the call tree does show "MONGO-JSON" for now, so we could get the JSON query and the bind var values.
Please review the change and let us know what is missing here

Oh~:) great.
Still, there are things to take care of. But I think you're on the right track!
First. The reason for the unknowns.
You would probably need to add

driverGetDatabaseInterceptor
driverGetCollectionInterceptor

it's not separated for 3.0 and 3.7 is because they use identical data structure of storing database and collection.
and modify

MongoDriverConnectInterceptor2_X.java

check getting database part. It should be different from 3.x.
R session and cud session interceptors... I'm didn't look into it in details. But for now, I think you can pass.
Last. WriteContext should be modified for showing json query.
This needs to be modified to show with more details.
I think you got here very fast :)
Hope to hear more from you~

@RoySRose after instrumenting the right method to get the DB instance from the Mongo class, the Unknowns have now resolved appropriately.
I'm not sure what you mean by

WriteContext needs to be modified to show with more details

We're able to see the Mongo JSON along with the bind var values like below.

Are there more details that could be obtained?

Hello, @asgs
Wow, You've taken care of it very fast!!
I've fully looked into mongo-driver library, to answer your questions.
TLTR; modification of WriteContext is not necessary for the sample application.

I'll tell you why I've thought WriteContext needs to be modified.
I saw your sample application uses DBObject as below.
DBObject query = new BasicDBObject("zzz", "aaa");

I didn't implement any code to take care of DBObject interface in

WriteContext.parse()
WriteContext.writeValue() <-- needs of modification differs by cases
So, at first, I thought JSON wouldn't be properly shown in Pinpoint-Web
But, since BasicDBObject implements Bson interface. It was fine.

If there are any implementations of DBObject which doesn't implement Bson.
It will not be shown properly in the future. (I don't know if these kind of implementation exists in 3.x library)
By the way, what do you think about contributing your work?
I'll be happy to review your code and help the contribution

@RoySRose please review the PR https://github.com/naver/pinpoint/pull/5429

@RoySRose any update on the question above?

@asgs
About docker, I don't create the docker images since we don't have any snapshot jar available. 1.9.x docker image will be created after the release of 1.9.0.
About the compatibility. Officially, 1.8.x collector is not compatible with 1.9.x agent. But it may work since there aren't any significant changes in the communication between them.
To get the docker image of 1.9.x(collector). You can always create the image by yourself.
Or if you don't have much time.
You can wait for the release of 1.9.0

@RoySRose

When is the 1.9.0 planned for release?
Is there a build guide on Dockerization of Pinpoint?

@asgs

There isn't an exact plan yet.
There aren't any guide on dockerization on Pinpoint
But you can look at the example from here
https://github.com/naver/pinpoint-docker

@RoySRose the supported tags on that git repo lists versions upto 1.8.3. will building from master be equivalent to 1.9.0-SS?

@RoySRose got it. the term "supported tags" seems to be a bit misleading

@asgs
Really?!  Never thought it would be confusing.
How did you understand the term.
It may help me change the term

@RoySRose by "supported tags", I was assuming it meant that the master branch is the same as the last created tag (1.8.3) and 1.9.x is still WIP

Oh. master branch is WIP.(we don't have 1.9.x branch yet, it will be created after master becomes 1.10SS)
This may differ from open source projects to projects.


Volunteer Manager v1.5 [2024Q1]

Infrastructure

[x] Complete migration from <OLD_DataTable> to the new variants
[x] Create a canonical <Timeline> component in our Calendar library

[x] Migrate both <AvailabilityTimeline> and <ShiftTimeline> to this new component

[x] Create a new <ExpandableSection> component for manual collapse sections

[x] Enable saving expansion state in user settings

Admin
Dashboard

[x] Management of Del a Rie advice on a simple page

Events

[x] Dashboard: Display upcoming deadlines
[x] Dashboard: Merge recent change entries when made almost at the same time
[x] First aid: Enable scheduling when each first aider is around, with which skill set
[x] Hosts: Provide a FAQ library that can be surfaced in the portal
[x] Security: Overview of security personnel on site, with time schedules
[x] Shifts: Define the shifts for each of the volunteering teams

[x] Comprehensive overview of the shifts, their identity, demand and issue
[x] Manage the shift's basic properties, including excitement level
[x] Manage the shift's demand, be able to see cross-team demand in an overview
[x] Visualise the volunteers scheduled on shift in a dedicated overview

[x] Scheduling: Assign shifts to each of the volunteers

[x] Update shifts periodically, on focus change, and when invalidation happens
[x] Enable shifts to be created, deleted and updated, with strict overlap checking
[x] Enable shifts to be moved between different volunteers
[x] Double click dialog to assign any shift part of the selection
[x] Right click menu to fast assign most recent shifts

[x] Volunteers: Visualise the volunteer's scheduled shifts on their account page

Volunteers

[x] Enable the use of display names as opposed to real names
[x] Include the First Aid team in volunteer list exports

Registration

[x] Availability: Display a graph visualising their availability during the festival

Schedule Display
Nothing yet
Schedule Portal
Nothing yet
Statistics
Nothing yet
Welcome
Nothing yet

Closed per https://github.com/beverloo/volunteer-manager/releases/tag/release-v1.5.0


ImageDataGenerator is not shuffle during training when shuffle = True

Hi,
In the image.py, the on_epoch_end should be called after each epoch to make sure the data is shuffled for next epoch. But it's not called, that means the data only shuffle once at the beginning of the training.

I guess you talk about the keras.preprocessing.image.Iterator object returned by .flow.
The Iterator is a keras.utils.Sequence which implements the on_epoch_end callback.

Hi Dref360, thanks for your reply. I just print the index_array of each batch, it is actually shuffled.


escapes the igapi login params

fixes the bug where a password won't be accepted if it includes some special characters
updates the version number to 0.0.24

@liyicky remove your pry then we're ready :)


Whisper stalls on MP3

Running mlx_whisper against a .wav version of the same audio gets into detecting language and transcribing fairly quickly.  Doing the same with the original .mp3 just leads to the process hanging (so I ^C'd out):
mlx_whisper --model mlx-community/whisper-large-v3-mlx  ~/Documents/Story.mp3
Args: {'audio': ['/Users/jrp/Documents/Story.mp3'], 'model': 'mlx-community/whisper-large-v3-mlx', 'output_dir': '.', 'output_format': 'txt', 'verbose': True, 'task': 'transcribe', 'language': None, 'temperature': 0, 'best_of': 5, 'patience': None, 'length_penalty': None, 'suppress_tokens': '-1', 'initial_prompt': None, 'condition_on_previous_text': True, 'fp16': True, 'compression_ratio_threshold': 2.4, 'logprob_threshold': -1.0, 'no_speech_threshold': 0.6, 'word_timestamps': False, 'prepend_punctuations': '"\'“¿([{-', 'append_punctuations': '"\'.。,，!！?？:：”)]}、', 'highlight_words': False, 'max_line_width': None, 'max_line_count': None, 'max_words_per_line': None, 'hallucination_silence_threshold': None, 'clip_timestamps': '0'}
Fetching 4 files: 100%|█████████████████████████████████████████████| 4/4 [00:00<00:00, 66841.50it/s]
^CTraceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mlx/bin/mlx_whisper", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mlx/lib/python3.12/site-packages/mlx_whisper/cli.py", line 224, in main
    result = transcribe(
             ^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mlx/lib/python3.12/site-packages/mlx_whisper/transcribe.py", line 150, in transcribe
    mel = log_mel_spectrogram(audio, n_mels=model.dims.n_mels, padding=N_SAMPLES)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mlx/lib/python3.12/site-packages/mlx_whisper/audio.py", line 155, in log_mel_spectrogram
    audio = load_audio(audio)
            ^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mlx/lib/python3.12/site-packages/mlx_whisper/audio.py", line 57, in load_audio
    out = run(cmd, capture_output=True, check=True).stdout
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mlx/lib/python3.12/subprocess.py", line 550, in run
    stdout, stderr = process.communicate(input, timeout=timeout)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mlx/lib/python3.12/subprocess.py", line 1209, in communicate
    stdout, stderr = self._communicate(input, endtime, timeout)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mlx/lib/python3.12/subprocess.py", line 2108, in _communicate
    ready = selector.select(timeout)
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Caskroom/miniconda/base/envs/mlx/lib/python3.12/selectors.py", line 415, in select
    fd_event_list = self._selector.poll(timeout)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyboardInterrupt

I assume that this is a bug of some sort.
This version of whisper still results in a lot of stuttering (ie, repeated words or lines).  Not sure whether this is just covering silences or sound glitches, but it makes whisper almost unusable as you need to read everything through and play back to find out the problem.  (The bits that are transcribed in between are almost flawless.)

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

This version of whisper still results in a lot of stuttering

Can you elaborate? You see the stuttering even with the .wav file?

Yes.  I think that it is often referred to as just hallucination.  It ends up repeating phrases, then picks up the thread again for a bit, then repeats, ad nauseam.

I remember our discussion on this was not resolved. Part of the problem is it's not so simple to reproduce. Are you able to share a audio for which that happens?

I'm afraid that I can't, I'm sorry to say.

It turns out the mp3 problem is nothing to do with MP3, but that the file is in iCloud (and it doesn't seem to want to download):  "The operation couldn’t be completed. (NSFileProviderErrorDomain error -2005.)" which means nothing to me.

Ok.. so let's close this. We can keep #774 open. If we can find a repor hopefully we can find a fix.


Dart2JS: How to avoid interceptors for JS interop?

I have code that ~mostly looks like this:
@JS()
library js_interop;

import 'package:js/js.dart';

@JS('self')
external MyGlobals get myGlobals;

@JS()
@anonymous
abstract class MyGlobals {
  external List<String> get names;
  set names(List<String> names);
}

void main() {
  var names = myGlobals.names;
  if (names == null) {
    names = myGlobals.names = [];
  }
}

This fails, mostly mysteriously, with a NoSuchMethodError. While debugging the Dart2JS, I realized that this is going through an Interceptor. The code that is emitted looks something like this:
J.get$names$x = function(receiver) {
  return J.getInterceptor$x(receiver).get$names(receiver);
}

...

JavaScriptObject: {
  get$names: function(obj) {
    return obj.names;
  }
}

...

main: function() {
  var names;
  names = J.get$names$x(self.self);
}

Questions:

In my head, this would work perfectly fine if instead Dart2JS just emitted:

main: function() {
  var names;
  names = self.names;
}

... but I can't tell why it doesn't try to do that. Any pointers? I can point to my internal work.

[Low] Is there a way to avoid reading self.self in this case?

@rakudrama:

Can you avoid trying to define the top level scope, and use a getter/setter for each top-level variable?

Yeah. I could create a set of top-level setters and getters. I'll try that!

For example defining MyGlobals g = myGlobals

Do I need to write specifically that? Does final g = myGlobals do the same thing w/ inference?

A third problem you will have is that ... List<String> is not the right type

Ah. I was trying to avoid returning List<dynamic>, from your other request that we try and type the returns. If it is List<dynamic>, won't Dart2JS consider all native types live again?

Ping @rakudrama 🏓

The current native analysis ignores type parameters, so <dynamic> should not pull in any new types.

Thanks! That's enough information for me! Closing.


has_new_commits: don't try to set false result

As per investigation in #21, Actions evaluates the string false as
boolean true. The easiest workaround is to simply not bother setting
a false result. Actions will then interpret no result as false, which
is exactly what we want.

(Closing this PR because I want to switch it to use a different branch of my fork - and GH doesn't let me do that for an existing PR - I'll open a new one instead.)


Mitigate Let's Encrypt CA Change

Let's Encrypt issued certificates will no longer be trusted on some devices, notably Android versions prior to 7.1.1, after September 30, 2021. ODK-X will introduce the following changes/features to minimize the impact:

[ ] Trust Let's Encrypt's root public keys (ISRG Root X1, ISRG Root X2) in ODK-X Services

[ ] Allow ODK-X Services to trust user provided certificates

[ ] Allow users to bring their own certificate in the Sync Endpoint setup script

Links
https://docs.google.com/document/d/11KvB6XAkAp17bny4lPk4Uvobb5n6arbRT_iXArbfOns/edit
https://letsencrypt.org/2020/11/06/own-two-feet.html

This looks like a good plan to me! I think in the long run supporting custom trusted certs in a deployment's client apps is the right way to solve the full offline case. Another possible short-term stopgap is adding zerossl as an alternative ACME cert provider. Supposedly it works the same with certbot, and they are still using a traditional root CA. Their 90 day ACME certs are also free like letsencrypt's
https://news.ycombinator.com/item?id=25188614
https://zerossl.com/features/acme/

ZeroSSL is listed as one of the options in the Google doc linked above. Unfortunately though, adding ZeroSSL is not as simple as swapping Let's Encrypt's ACME URL for ZeroSSL's URL. ZeroSSL requires an account, that has to be created out of band, to request certificates. See https://zerossl.com/documentation/acme/

Ah, that make sense. Sorry I couldn't see the doc yesterday! The plan as it stands is definitely the best option then!

Update from Let's Encrypt on this situation: https://letsencrypt.org/2020/12/21/extending-android-compatibility.html
In short, they have found a workaround that will allow old devices to continue to trust Let's Encrypt issued certificates until early 2024.


Update to Jasmine 2.X

looks great, merging.  @ygy hopefully this makes it build nicer on ubuntu!

Unfortunately jasmine-maven-plugin 2.1 requires Maven 3.1.0+ but the Apache Jenkins server is only on Maven 3.0.4. This causes the build to fail with:
Waiting for Jenkins to finish collecting data[ERROR] Failed to execute goal com.github.searls:jasmine-maven-plugin:2.1:test (default) on project brooklyn-jsgui: The plugin com.github.searls:jasmine-maven-plugin:2.1 requires Maven version 3.1.0 -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.

maven 3.1.0 came out nearly 3 years ago so i think we put in a request for that version.
istr there were issues with old build on apache jenkins servers that they couldn't run the old jasmine plugin so not much sense in rolling back.  wdyt @sjcorbett @m4rkmckenna @ygy @aledsage ?

A request to upgrade would be sensible. In the meantime it would be good to have Jenkins able to publish snapshots. @m4rkmckenna is using Jasmine 2.x plausible?

@sjcorbett I havent been able to find a way ... ill have a fix for the above shortly.
What i find funny is apache maven 3.4 is being built with maven 3.0.5 :smile:

Opened #14 to address the above


1-setup.sh Not found

After I formatted my drive

I have the same issue form:
I7700K
1070
I got the same thing, when I tried it with VM in UNraid.

Yep same for me
I wish there is option to install to partition not full disk

Might switch from BTRFS as subsequent runs can lead to this.

@ChrisTitusTech When I was making my own installation scripts about a year ago, I was running into problems with automating the btrfs setup as well. I found that chaining all the file system creation, mounting, and subvolume creation commands together with &&'s solved my problems, so it might be worth a shot to try that. I think just having them on separate lines had one part or another starting before the previous part finished.
For clarity, this is the part from my scripts ($PN2 is the btrfs partition and $PN1 is the EFI partition for my script):
mkfs.vfat $PN1 &&
	mkfs.btrfs -f $PN2 &&
	mount $PN2 /mnt &&
	btrfs subvolume create /mnt/@ &&
	btrfs subvolume create /mnt/@home &&
	btrfs subvolume create /mnt/@var_log &&
	umount /mnt &&
	mount -o noatime,compress=zstd,space_cache=v1,discard=async,subvol=@ $PN2 /mnt &&
	mkdir -p /mnt/{boot/EFI,home,var/log,mnt/rpool} &&
	mount -o noatime,compress=zstd,space_cache=v1,discard=async,subvol=@home $PN2 /mnt/home &&
	mount -o noatime,compress=zstd,space_cache=v1,discard=async,subvol=@var_log $PN2 /mnt/var/log &&
	mount -o noatime,compress=zstd,space_cache=v1,discard=async $PN2 /mnt/mnt/rpool &&
	mount $PN1 /mnt/boot/EFI ||
	exit 1

They could be separate issues, but I do remember my problems arose specifically when I was running the script on what was already a btrfs setup previously.

I just sudo chmod +x all the files and it works for me.

I just sudo chmod +x all the files and it works for me.

Nop it's not working

same issue

I did chmod +x for every single file then running sudo bash archfi and it works for me

fixed with latest commit


RocketChat -> Matrix images are considered empty text

Environment (please complete the following information):

OS: Linux (Docker)
Matterbridge Docker image: 42wim/matterbridge:1.16.3

Describe the bug
RocketChat bridge defines the image message as empty text Text:"".
The gateway discards the empty message:
Debug logs excerpt
Rocketchat:   <= Message is &config.Message{Text:"", Channel:"#channel", [..]
Gateway:  ignoring empty message &config.Message{Text:"", Channel:"#channel", [..]

To Reproduce
Send an image in RocketChat.
Expected behavior
RocketChat should transmit the image to Matrix.

duplicate of #774

Duplicate of #774


How to properly handle errors on consumers?

My current setup is:

Rails 4 publisher
JRuby 9k consumer

hutch.yml (configuration):
mq_host: ...
mq_username: guest
mq_password: guest
mq_api_host: ...
channel_prefetch: 1
heartbeat: 150
require_paths:
  - foo.rb
error_handlers:
  - Logger
  - Sentry
error_acknowledgements:
  - Requeuer

Command: hutch --config config/hutch.yaml
I have a consumer executing a process that could raise some errors:
class Foo
  include Hutch::Consumer
  consume 'foo'

  def process(message)
    # process that handle message and could raise errors
  end
end

class Requeuer < Hutch::Acknowledgements::Base
  def handle(delivery_info, properties, broker, ex)
    broker.requeue delivery_info.delivery_tag
    true
  end
end

Hunting down the issue, I:

Started not handling the errors, but as discussed in #195, this could be dangerous considering the Thread pool nature of AMQP client.
Then I tried just capturing and requeue'ing the message, but this clashes with @broker.ack on Hutch::Worker#handle_message, sending an requeue and ack messages to RabbitMQ, broking the protocol.
Then I tried the code above, that requeue and raise the error, but ended with hutch shut down gracefully in the middle of processing.

Considering #165, acking manually seems to be the best option, taking into account that as said in #195, the library could not decided whether if the worker/consumer should crashes due an unhandled exception.
This issue is more a doubt about what is the correct way to handle the errors on consumers?

Consumers should handle their exceptions. I'm not sure if this answers your question but there isn't much Hutch-specific. If you need to inspect protocol method flow or message flow, use Wireshark and RabbitMQ tracing, respectively.

@michaelklishin Thanks for reply. My issue was not related to protocol itself, but the aspect of handling the errors without stopping worker.

Then perhaps I don't understand the question. Consumers are generally supposed to handle exceptions they can do something about.

I am also wondering how to best address this. If there is a syntax error in my code, I want the job to go back into the queue.
Consider this flow:

message is received by consumer (and currently acked)
There is a syntax error in the consumer code, we push a hotfix for this bug
I'd like the message to go back into the queue to be tried again, and be reprocessed once the deploy is pushed and the consumers are reconnected.

How would we handle this logic so failed jobs aren't lost forever?

#177 introduced configurable acknowledgement behavior.


pulsing opacity doesn't work

doing this won't do anything:
$('.elm').pulse({ opacity:'0.1'}, { duration:1000, pulses:3 });

I have a very weird problem where I do:
$foo.on('click.vote', 'img', function(){
          $(this).siblings('.bar').pulse({ opacity:.1 },{ duration:1000, pulses:3})
 })

and it will only pulsate while the mouse is moving on the image. As long as the mouse moves, pulse works. will not do anything while mouse isn't moving (after click of course).
Would you know anything of this?
Thanks


on:submit bug

Pressing the enter button (keyboard) on an input (this triggers the on:submit event in the form) does not cause "reactive" changes from the input, while clicking the submit button does.
Here's the demo / repo
Edit: Changed "clicking" to "pressing". Might have been a source of confusion.

which browser are you using. It works fine on chrome

I am using Chrome 47.0.2526.80 (64-bit) on OSX 10.11 (El Capitan)

Seems to work fine for me too. Please be more specific about

Steps necessary to reproduce the issue
What are you expecting
What is the actual behavior

Expected: The input (in the create form) will become blank when I submit the form.
Actual: The input only becomes blank when I click the click the "create" button. When I try to press the enter key, everything works except that the input is not blank.
Steps to reproduce:
1.) Click on the "create a new task" button
2.) Fill the input with characters (anything)
3.) Press the enter key.
4.) Repeat steps 1-2.
5.)) Click the "create" button

Thank you! Very much appreciated.


Add "Confirm to delete" feature while deleting lists

Prevents accidental deletes of lists

@zhakkarn Could you confirm if this one was fixed in the last PR?

@AndrewGHC, the last PR only addressed #137

I would be happy to help with this.

@ZackWard Awesome! Go ahead! You can ask help over here by commenting if you run into something!


Reduce posts font size using _variables.scss

Hi,
I'm trying to reduce the font size on my posts items using _variables.scss but it not applied properly. For me the font is too high.

Detailled Screenshot
I've used this settings to review the change, but nothing happen on my posts items. The font it's still the same size (too big for me)
/* type scale */
$type-size-1                : 0.50em !default;  // ~39.056px
$type-size-2                : 0.50em !default;  // ~31.248px
$type-size-3                : 0.50em !default;  // ~25.008px
$type-size-4                : 0.50em !default;  // ~20px
$type-size-5                : 0.50em !default;  // ~16px
$type-size-6                : 0.50em !default;  // ~12px
$type-size-7                : 0.50em !default;  // ~11px
$type-size-8                : 0.50em !default;  // ~10px

I've also tried to change $doc-font-size to 10
I've tried to :
bundle exec jekyll clean
bundle exec jekyll build
Without success yet. The font does not change in matters of size.
Maybe I made a minimal mistake :)
Thanks for your help.

[X] This is a question about using the theme.
[ ] This is a feature request.
[X] I have updated all gems with bundle update.
[X] I have tested locally with bundle exec jekyll build.
[ ] I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.

Environment informations

Minimal Mistakes version: 4.4.1
jekyll gem version:
Operating system: macOS

See these lines in _reset.scss. I'd leave the variable font sizes alone and instead adjust the sizes in the reset. The theme scales the font sizes up/down globally depending on the width of the screen.
html {
  /* apply a natural box layout model to all elements */
  box-sizing: border-box;
  background-color: $background-color;
  font-size: 16px;

  @include breakpoint($medium) {
    font-size: 18px;
  }

  @include breakpoint($large) {
    font-size: 20px;
  }

  @include breakpoint($x-large) {
    font-size: 22px;
  }
}

Hi @mmistakes ,
It's working, thanks a lot.

perfect!!!


Restore from backup

I have a backup of the tokens.xml file. I've tried to put it in the "shared_prefs" folder on my phone (factory resetted), but the app is still empty, without the takend I had before.
How could I restore the tokens? The file that I have are from Titanium Backup (which unfortunately is not working anymore!)
Thanks!

Checkout https://github.com/freeotp/freeotp-android/issues/20#issuecomment-326421230

Checkout #20 (comment)

Does that still work? #20 (another comment)

[...] At some time 5ced272 was merged, which disables backup of app. This kills all methods and tricks revealed in this thread. [...]


Mark the repo as deprecated

What
Suggest that people not to use it for new projects.
Why
People keep asking me why we're not using it for our new project :)
I understand that we've decided not to invest more in postcodeinfo, because it's probably more cost effective to use a commercial product than to pay people to maintain the software and running instances of it.
If that's the case we should probably make it official.
Who should review
@SteveMarshall or @kerin should probably check my explanation and understanding is correct

Can one of the admins verify this patch?

I think it probably is worth having something in https://github.com/ministryofjustice/technical-guidance - I'll raise something today or tomorrow

I think I lack write access that would allow me to merge myself. Could someone else merge please?


fixes for voici windows build

added 'Scripts' directory to empack config and some windows related tweaks to pack.py

looks good to me, once the CI is green I am happy to merge this

looks good to me. We might want to add windows to the ci to test this properly

Trung is looking into taking over your PR to enable Windows and MacOS CI


net: tcp: Zero Window Probe handling

A follow-up of issue #7818
Some implementations expect that after zero window size was sent, all data received on the sender side will be dropped. Whether this is a correct behavior is up to discuss here, the PR contains a possible solution for the issue.
Signed-off-by: Robert Lubos<EMAIL_ADDRESS>

Codecov Report

Merging #7867 into master will decrease coverage by <.01%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master    #7867      +/-   ##
==========================================
- Coverage   55.02%   55.02%   -0.01%
==========================================
  Files         483      483
  Lines       53969    53975       +6
  Branches    10501    10502       +1
==========================================
+ Hits        29695    29698       +3
- Misses      19986    19988       +2
- Partials     4288     4289       +1

Impacted Files
Coverage Δ

subsys/net/ip/tcp_internal.h
50% <ø> (ø)
:arrow_up:

subsys/net/ip/tcp.c
55.2% <61.53%> (-0.04%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b20350...ed921a5. Read the comment docs.

I'd like to extend my invitation (from https://github.com/zephyrproject-rtos/zephyr/issues/7818#issuecomment-391699986) to start by analyzing how this condition should be handled per RFCs, how it was intended to be handled in Zephyr IP stack, how it is actually handled, how that should be changed, and then it will be possible to come up with the code to achieve that. I started such analysis in https://github.com/zephyrproject-rtos/zephyr/issues/7876

@pfalcon Sorry for not being clear enough

you never mentioned that you were getting the following error on the console

Because I don't. I think we still have slight misunderstanding of what's hapening on my side.
So the communication, looks like this:

Server sends initial chunk of data, filling client's window.
Client replies with ACK indicating 0 window length.
Server sends Zero Window Probe with 1 byte of data (not sure why does it happen so sudden, but apparently this sever works like this).
In a meantime, before recieving ZWP, client consumes some data. So at the point of receiving ZWP window on client side is no longer 0, hence there is no error.

And now we have two outcomes:
Current behavior:
5. Client consumes the ZWP data, and replies with ACK with updated window length and indicating ZWP data was consumed.
6. Server ignores the ACK and keeps retransmiting ZWP.

Behavior in the patch:
5. Client is aware that it sent 0 window length, hence he treats packet received from server as ZWP. Client drops the data and replies with ACK with updated window lenght.
6. Server procees the ACK and resumes transmision.

I hope that now it will be clear on what I am observing.

I think we still have slight misunderstanding of what's hapening on my side.

Yes, as I wasn't able to reproduce your picture exactly (only "something similar", with completely different servers), I can never be sure.
Thanks for the itemized list. Let's see thru it. Items 1-5 are fully understandable, my ack on them.
Now the point 6 is problematic. Which clause of RFC 793 allows that behavior? The only case a peer can "ignore" an ACK is when it failed to receive it.

Behavior in the patch: 5. Client is aware that it sent 0 window length, hence he treats packet received from server as ZWP.

But as described in https://github.com/zephyrproject-rtos/zephyr/issues/7876#issuecomment-391745233 , there're no "ZWP" on the baseline TCP level. A "ZWP" packet is just: a) a packet which commonly has data length of 1; b) sent to a peer, when peer's receiver window was last advertised as 0 (while normally in such condition packets should not be sent). It's all just a normal TCP packet (segment) otherwise. Without keeping context information (and any context is very transient), it's not possible to tell a ZWP packet from normal 1-byte data packet.
Let me illustrate this last point in more detail, and show a technical issue with your patch. You store per-packet status in TCP context. That's not going to work, there're many packets, and only one TCP context which can't track them all with 1 bit. Suppose we sent a packet with window=0. At that point some data from rcv buf was consumed by the app, and it sent another packet, which thus will have window>0. But peer didn't see it yet! It sends ZWP, and when it arrives, zero-window flag was already reset on our side, so we can't treat ZWP packet specially, and likely back to square in our issues.

So, I'm sorry, but to me it look like:

You spotted a problem with a particular server.
You provide the most "low-hanging" explanation for what happens, and propose the most "low-hanging" solution for that particular case.

But there some problems there:

We don't know which server that exactly is. I can't reproduce https://github.com/zephyrproject-rtos/zephyr/issues/7818, for me those servers (few behind the same CNAME) behave differently. We should put the names for OS/IP stack whose behavior we work around, and have an exact server to stably reproduce against.
The explanation you give involves violation of RFC 793, and the solution you propose is quite adhoc and has technical issues.

So, IMHO we should not stop here, and again, look for putting names to peer(s) which behave like that, try to find other explanations to their behavior (besides "they expect us to track whether we send them zero window", which doesn't make sense), see if other IP stacks have workarounds like that (e.g. if Linux has that implemented exactly in this way, then sure, we can be as bad Linux here ;-) ).

look for putting names to peer(s) which behave like that
This is what nmap told me:

Nmap scan report for steelix.canonical.com (<IP_ADDRESS>)
Host is up (0.34s latency).
Not shown: 991 closed ports
PORT     STATE    SERVICE    VERSION
21/tcp   open     ftp        vsftpd 2.0.8 or later
22/tcp   open     ssh        OpenSSH 7.1p2 Ubuntu 2.IS.PATCHED.16.04.4 (Ubuntu Linux; protocol 2.0)
25/tcp   open     smtp       Postfix smtpd
80/tcp   open     http       Apache httpd 2.4.18 ((Ubuntu))
514/tcp  filtered shell
515/tcp  filtered printer
873/tcp  open     rsync      (protocol version 31)
5666/tcp open     tcpwrapped
9103/tcp open     jetdirect?
Aggressive OS guesses: Actiontec MI424WR-GEN3I WAP (99%), DD-WRT v24-sp2 (Linux 2.4.37) (98%), Linux 3.2 (98%), Microsoft Windows XP SP3 or Windows 7 or Windows Server 2012 (96%), Linux 4.4 (96%), Microsoft Windows XP SP3 (96%), BlueArc Titan 2100 NAS device (91%)
No exact OS matches for host (test conditions non-ideal).
Service Info: Host:  steelix.canonical.com; OS: Linux; CPE: cpe:/o:linux:linux_kernel

A lot of Microsoft in OS guesses. Any ideas on how to get more specific information?

see if other IP stacks have workarounds like that

I saw that LwIP is often referenced as a solid implementation, so I looked there. That's what I've found (maybe it's just me, but it resembles me something):
https://github.com/stm32duino/LwIP/blob/b0b8adb1c9e408ed0ef1687bcab4e53f30495678/src/core/tcp_in.c#L362

That's what I've found (maybe it's just me, but it resembles me something):
https://github.com/stm32duino/LwIP/blob/b0b8adb1c9e408ed0ef1687bcab4e53f30495678/src/core/tcp_in.c#L362

Good find, let me eyeball and ponder about it.

@rlubos :

I saw that LwIP is often referenced as a solid implementation, so I looked there. That's what I've found (maybe it's just me, but it resembles me something):
https://github.com/stm32duino/LwIP/blob/b0b8adb1c9e408ed0ef1687bcab4e53f30495678/src/core/tcp_in.c#L362

So, I wouldn't say that it's 100% conclusive that referenced code does the same as your patch. Let's first of all have a look of lwIP's definition of the release struct tcp_pcb members: https://github.com/yarrick/lwip/blob/master/src/include/lwip/tcp.h#L283 . So, it tracks separately the window which is actually available locally vs amount of that window which is "to announce" to a peer (likely, also which "has been announced"). In addition to that, it keeps also a seqno of the right edge of the announced window.
The code you reference was added in https://github.com/yarrick/lwip/commit/cceea73c3f32f433f3d6b5c8212a8ca1f06cddab .
And the commit message of that change says:

A zero-window probe is a data segment received when rcv_ann_wnd
is 0. This corrects a standards violation where LwIP would not
respond to a zero-window probe with its current ACK value (RCV.NXT)
when it has refused data, thus leading to the probing TCP closing
out the connection

So, I much more see that lwIP's change as the fix for "my" problem rather than yours. Specifically, before that change, when lwIP received a ZWP, while having zero window, it just dropped this packet. Whereas after the change, it will send an ACK (using an old ackno, as well, the window is zero).
Zephyr has the same problem, and we certainly need to fix it. So, I would like to propose that I submit a fix for this condition first. @rlubos, you'd need to rebase your patch on top of it then, and we can continue analyzing it (hopefully other folks will join). Hope this works for you.

Zephyr has the same problem, and we certainly need to fix it. So, I would like to propose that I submit a fix for this condition first.

4-line patch posted in https://github.com/zephyrproject-rtos/zephyr/pull/7952

Closing the PR as the issues described appears to happen due to Virtual Machine / Windows interaction (https://github.com/zephyrproject-rtos/zephyr/issues/7818#issuecomment-392449120). Closing for now, may return to it when a reproducible sample with actual server can be presented.


Add osx support

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy
[x] Ensured the license file is being packaged.

@conda-forge-admin , please rerender

Hi! This is the friendly automated conda-forge-webservice.
I rerendered the feedstock and it seems to be already up-to-date.

Hmm...
@conda-forge-admin, please rerender. :)

Hi! This is the friendly automated conda-forge-webservice.
I rerendered the feedstock and it seems to be already up-to-date.

I will merge that, if you have any suggestion please let me know  :)

Thanks @marcelotrevisani.
Sorry I've been slow. Am at a sprint this week.
No real suggestions from me. Generally this looks good. Thanks for getting working macOS builds for these. 😄

Hi @jakirkham , no problem at all! I know that you are very busy!
It was just to be sure that everything was ok. Thanks! :)


Debug Symbols for releases

I'm reporting the issue for v5-beta but I suppose it's also applicable for other versions. There are no debug symbols for releases which makes it harder to debug. It'd be great to have symbols given that it's very easy to create and publish them nowadays.

That would be nice! I had to download the specific tag now, and reference the code in my project to be able to debug

This was done as part of #2775.


Kinect header file missing

https://github.com/ExerciseCheck/exercisecheck/blob/519daf96342d6644ffcba371d5d184735d9a0a1e/src/kinect2.cc#L4
src/Kinect2.cc has a directive to include "kinect.h" which doesn't seem to be anywhere in the project.

I am not definitely sure, but believe that the Kinect.h is from the Kinect SDK (link: https://www.microsoft.com/en-us/download/details.aspx?id=44561).

Yes, this file is a part of the Kinect SDK 2.0. Once you install the SDK you may have to reboot the system (this is necessary to flush the paths)

Got it. Was having difficulties building it on my Linux box (trying the install without the SDK) but installation on Windows went without a hitch.


vscode lint not working

What Versions are you running?

Linting doesn't seem to be working
class influxdb::params {
$admin_enable            = false
$admin_bind_address      = '<IP_ADDRESS>:8083'
$domain_name             = undef
$http_enable             = true
$http_bind_address       = '<IP_ADDRESS>:8086'
}
What is Expected?
class influxdb::params {
  $admin_enable            = false
  $admin_bind_address      = '<IP_ADDRESS>:8083'
  $domain_name             = undef
  $http_enable             = true
  $http_bind_address       = '<IP_ADDRESS>:8086'
}

How Did You Get This To Happen? (Steps to Reproduce)
Installed vscode plugin, then installed puppet agent using brew cask and pdk as well.

Hi @lanox ,
Can you describe what doesn't seem to be working in a little more detail? e.g. what lint errors were you expecting?

Hi
Listing doesn’t seem to be aligning = or => or complaining.
Basically I think my lint is not working in vscode.

Puppet Lint doesn't seem to enforce indenting, unless it's consistent..  e.g.
class influxdb::params {
$admin_enable = false
$admin_bind_address = '<IP_ADDRESS>:8083'
$domain_name = undef
   $http_enable = true
$http_bind_address = '<IP_ADDRESS>:8086'
}

should show a lint error

Looks look it accepts 0,2,4,6.... space indenting.

Sorry I am out at the moment so I can’t test it,  so is that normal or a bug ?

This sounds like a bug in puppet-lint.

Raised https://github.com/rodjek/puppet-lint/issues/822 to track the issue.

@lanox You happy for me to close this issue as it's being tracked via puppet-lint?

for me, it complains about alignment of hash rockets in the "Problems" window but doesn't complain about regular equals signs.  Equals signs are probably a problem with puppet-lint.  For the hash rockets, should they be auto-aligning instead of just getting underlined and complaining?  Or is it not expected to auto correct such things as you type (or is that an option I haven't enabled)?

@br0ch0n Slightly different issue but....
The problems window only shows issues.  We can't do per-problem resolution because puppet-lint can only fix an entire document at a time.  To that end though, If you use the "Format Document" VS code command it will apply any fixes puppet-lint makes. (https://code.visualstudio.com/docs/editor/codebasics#_formatting)
Also means you can take advantage of the 'editor.formatOnSave' setting and automatically apply any puppet-lint fixes after you save a document :-)
We added that in 0.9.0 (https://github.com/lingua-pupuli/puppet-vscode/commit/97897aa27d6658b5f37a8d92a6a019a0b7fcb72a)

I'm closing this issue as it's being tracked in the puppet-lint project.


perf(utils): optimize parse stack trace regexp

Description

closes #6039

Check https://github.com/userquin/vitest-stacktrace-issue-6039
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
[ ] Ideally, include a test that fails without this PR but passes with it.
[ ] Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

[ ] Run the tests with pnpm test:ci.

Documentation

[ ] If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

[ ] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

We should add test case from #6039 that timeouts without this fix.

Added a test in the test/browser: rn we cannot test the timeout since we need to add PW/WDIO test, and we have only PW/WDIO tests using happy-dom to test the ui.
(check test/ui/test folder)

Seems like the current implementation breaks inline snapshots in the browser

Seems like the current implementation breaks inline snapshots in the browser

By current, I mean this PR. It works fine in main.

@userquin any luck fixing this issue? 🙏 🙏 🙏


Fix for upf build

The following fixes have been added to the build error in UPF

Add testgtpv1 building rules as well as stage-2.
Add m4/gcc4_visibility.m4 as same as stage-2.

Dear @tf-enya ,
Thank you for your contribute.
Since we have decided to merge our project of stage 2 and stage 3 to one repo free5gc. Can you please help us to reopen this PR on free5gc?
Many Thanks


Update readme to point at native http2 repo if node version is 8.8.1+

Those getting a memory leak warning can avoid it altogether by going here:
https://github.com/andreialecu/node-apn-http2
Those with 8.8.1+ should be directed to try that first I think.

We have a branch that uses the native HTTP/2 client, see https://github.com/node-apn/node-apn/tree/native-http2 and #610.


Release 2023.7

Adds jupyter packages back into core distribution.

Maybe just put jupyter (a metapackage itself) on it's own? that really ought to have worked (it's no different than numpy or whatever).

Oh, no we need to add all of the names into the digraph before looking at edges, as these are actually not connected by any of our plugins, unlike the other packages, which are dependencies of at least 1 plugin.

Oh, no we need to add all of the names into the digraph before looking at edges, as these are actually not connected by any of our plugins, unlike the other packages, which are dependencies of at least 1 plugin.

Oh yeah, that's right. Our DAG won't keep anything that's not connected to at least one other package. Should we modify the make_dag script to keep any packages that are listed in the given seed-env file, since we'll be the only ones modifying that? Or is there an easier way to handle?

Yeah I think that's what we need to do. Just sticking them in the DAG ought to be enough, because then we'll have a node with no-edges to traverse which should satisfy the rest of the code just fine. Feel free to make that change on this branch (otherwise we have to rebase this PR to get the updates).

Yeah I think that's what we need to do. Just sticking them in the DAG ought to be enough, because then we'll have a node with no-edges to traverse which should satisfy the rest of the code just fine. Feel free to make that change on this branch (otherwise we have to rebase this PR to get the updates).

@ebolyen check out the summary, I think that's what we want. For the jupyter packages I added, I just pulled what was in our last release environment file - but wondering if we can get away with fewer packages, depending on what people need? Is it just jupyter notebook we want people to have? Or any other jupyter extensions?

I'm not actually sure if these are all of the jupyter packages or not, hence the preference for jupyter=<ver> since that metapackage will be whatever is needed to do the usual thing.
But looks like it solved and built just fine!
We may need to test manually that jupyter notebook runs like we expect.

I'm not actually sure if these are all of the jupyter packages or not, hence the preference for jupyter=<ver> since that metapackage will be whatever is needed to do the usual thing.
But looks like it solved and built just fine! We may need to test manually that jupyter notebook runs like we expect.

I tested this out locally, and we actually need the notebook package in order for jupyter notebook to be available. When I added notebook=7.0.2 (latest release on conda-forge) to my local 2023.7 environment, it solved successfully and jupyter notebook worked as expected locally.
I'm going to remove all of the jupyter* packages from the seed environment file, and replace them with notebook=7.0.2 - that will pull in all of the required jupyter* packages for notebook specifically.

Turns out we have a max pin in the framework tests for notebook <7, so I tested locally and 6.5.5 solves and has expected behavior. Sad to re-run these all over again lol but this environment should solve this time around. It's really cool to see this iterative process in action though, and it's so easy to debug!


Incorrect Parsing of LDF Section "Signals"

Describe the bug
Initial Value is not parsed correctly for several types in the "Signals" Section
To Reproduce
Steps to reproduce the behavior:

Modify an LDF file to include the following signal definitions:
LinResponseError              :  1,                                0x00,            ETS_LVBMS, LIN_Master;
MCU_RTC_Time                  : 32,               {0xDE,0xAD,0xBE,0xEF},            ETS_LVBMS, LIN_Master;
Parse the LDF file using code similar to:

import ldfparser
import json
import os
def GetLDFJSON(filepath):
ldf = ldfparser.parseLDFtoDict(filepath)
return json.dumps(ldf);

Return JSON dump should not throw errors on hex values (it does currently)
Return JSON dump should correctly parse Hex Byte array and return as Hex String i.e. "init_value": "DEADBEEF",
See error

Expected behavior
Init values parsed to JSON correctly
Stacktrace/Code
If applicable, add stacktrace or code segments to help explain your problem.
Environment:

Windows 10
Python version  3.6.5
ldfparser version: 0.9.0

Additional context
Add any other context about the problem here.
ETS_MATSampleB.ldf.txt

Vector canalyzer uses the LDF without a problem.

I'm a moron I upgraded the wrong version of python and this issue was already taken care of.

I tested it with 0.9.0 and it seems to work fine, only in 0.8.0 and before it's an issue. Array types in general are very much experimental, the specification doesn't go into details for example about the initial value and encoding, but if you're just looking for the JSON conversion utility then it should work fine (#56 #57 #62 contributed to it recently).
Also I don't recommend sharing the full LDF unless you or the company is certain that it is not confidential information.

Yeah its working for me for now.
It's a non-production test only ldf I'm not worried.
On Wed, Aug 4, 2021 at 4:37 PM Balázs Eszes @.***>
wrote:

I tested it with 0.9.0 and it seems to work fine, only in 0.8.0 and before
it's an issue. Array types in general are very much experimental, the
specification doesn't go into details for example about the initial value
and encoding, but if you're just looking for the JSON conversion utility
then it should work fine (#56
https://github.com/c4deszes/ldfparser/pull/56 #57
https://github.com/c4deszes/ldfparser/pull/57 #62
https://github.com/c4deszes/ldfparser/pull/62 contributed to it
recently).
Also I don't recommend sharing the full LDF unless you or the company is
certain that it is not confidential information.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/c4deszes/ldfparser/issues/64#issuecomment-892991896,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACADNSQUYLO64JQBS5YHEO3T3GXKXANCNFSM5BR6PZIA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

--
Jonathan M. Kokott
Founder, Kokott Automation LLC
608.695.1812


Add text-decoration-none to pipeline steps.

There's currently a few bugs with the text-decoration on pipeline steps. Disabling text-decoration seems to fix it.
Bug 1 - Drag and dropping emoji from a pipeline steps shows an underline.
Bug 2 - Clicking on text pipeline steps seems to randomly show an underline.
Example error:

This is blocking us to completely switch to buildkit at our company, I'm so happy someone got around that!

Thanks for the PR! The underline, it hurts my eyes! And so does the hover color.
So it turns out it was lacking a :focus style, and it wasn't this part of the code. But the fix is live 🙌🏼
Thanks @KevinGrandon — when more of the build page UI is in this repo, you'll be able to get some PRs merged. Feel free to keep giving it a shot though, and don't be afraid to ping us in Slack before you do so if you want to check it's the right place to be looking in the code.


data-v-equal hangs page

Hello,
I have a little problem with data-v-equal
I have 2 inputs - password and confirm and I want the second to be the same as the first (pretty standart, right...)...
When you type in the password and there is nothing in confirm there is no problem but if you have any text in confirm and then type something in password or change the password value the whole page hangs. Something it bounces back and 'wakes up' but it takes a ton of time. You can see the same behaviour in the demo page: https://emretulek.github.io/jbvalidator/
Try filling something in 'equal - rePassword' than start typing in password and it hangs at some point.

Alright, when I use the CDN it works.
For some reason it didn't work when I downloaded it. I saw that the sizes are 1KB different but it still hanged...I'll use the CDN...

There may be an issue with the cache. The file sizes look the same to me (7.96kb), I could not see any difference.


feat: support log keep days

Codecov Report
Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.27%. Comparing base (dcb637b) to head (d996dec).

Files with missing lines
Patch %
Lines

log/logger.go
50.00%
2 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##              3.0     #346   +/-   ##
=======================================
  Coverage   69.26%   69.27%
=======================================
  Files          87       87
  Lines       10887    10895    +8
=======================================
+ Hits         7541     7547    +6
- Misses       2653     2655    +2
  Partials      693      693

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update SDK version from beta to GA for cosmosdbforpostgresql

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.

@senatol Azure.ResourceManager.CosmosDBForPostgreSql/1.0.0 is released


attempt to index local 'c'

Started getting
Error executing vim.schedule lua callback: Vim(lua):E5108: Error executing lua ...re/nvim/site/pack/packer/start/nvim-cmp/lua/cmp/core.lua:62: attempt to index local 'c' (a boolean value)
Error detected while processing CompleteChanged Autocommands for "*":
E5108: Error executing lua ...re/nvim/site/pack/packer/start/nvim-cmp/lua/cmp/core.lua:62: attempt to index local 'c' (a boolean value)

when typing anything and when completion menu pops up (have automatic completion set up).
Fixable by disabling
experimental.ghost_text = true

and started appearing after https://github.com/hrsh7th/nvim-cmp/commit/b6b15d5f6e46643462b5e62269e7babdab17331c got merged.

Setting hl_group as per #166 fixes the issue.

I've fixed it.

@hrsh7th, currently the tested commit (origin/main) 935b406 errors like this:
cmp:GHOST_TEXT: Error executing lua: .../nvim-data/lazy/nvim-cmp/lua/cmp/view/ghost_text_view.lua:40: attempt to index local 'c' (a boolean value)

Switching back to 'v0.0.1' fixes this.


sensor has gone crazy - sending reading even though light diode is not connected.

Hi
Yesterday I finally got my case and I set this up against my power meter. I start getting data, the data seems reasonable, all good.
This morning I have a look and the thing has gone wild! It is taking in readings at a lightning fast pace.

I thought maybe light was getting in from outside so I put some bluetac around it, still going nuts. I disconnected the light diode and readings are still coming through (thats weird :)). I have tried power cycling it, I double checked all the connections and I reflashed OTA.
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.69900 kWh with 3 decimals of accuracy
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.70900 kWh with 3 decimals of accuracy
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.72300 kWh with 3 decimals of accuracy
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.72500 kWh with 3 decimals of accuracy
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.73800 kWh with 3 decimals of accuracy
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.74100 kWh with 3 decimals of accuracy
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.74600 kWh with 3 decimals of accuracy
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.75900 kWh with 3 decimals of accuracy
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.76100 kWh with 3 decimals of accuracy
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.77100 kWh with 3 decimals of accuracy
[21:57:19][D][sensor:131]: 'House - Total energy': Sending state 24.78200 kWh with 3 decimals of accuracy

any ideas on what to do here? Or has my esp32 kicked the bucket?

At this point I don't really have a clue where the problem could be.

yeah, so... I think it might be hardware. I tried moving the esphome case around and it stopped spamming but now it reports nothing. If I squeeze the case it'll start spamming again. I have tried different power supplies and positions in the power box.
I am thinking I will get another esp32 and light diode and try again. Maybe I broke something. I'll report back when I get to it.

@jurgenweber Hi Please check if your photodiode is soldered to the right polarity, because I had similar issues  randomly (no readind, wild reading, correct reading) until I reversed polarity. Several of us reported this issue, the photodiode has the flat side oposite to the normal LED and this might caused the wrong orientation during the priduction process. Check issue #34 for more details.

@KixMan28 Cool! I gave the thread a read. Interesting.
After pulling mine out and checking it, yes. You are correct the polarity is incorrect. Mine is the wrong way around. Mine looks exactly like the photo here: https://github.com/klaasnicolaas/home-assistant-glow/issues/34#issuecomment-913155023
I will close this thread and follow up in #34


DEVX-757: Add multitenant routing kind

Description
Success pass:

Run OpenWhisk in standalone mode and create hello action there
make sure that env variables in env.list have the correct Api Host and API Token. The default ones are used
Run  the container:

./gradlew core:nodejs14MultitenantAction:distDocker
docker run --env-file env.list -p 8080:8080 --name=blue-velvet whisk/action-nodejs-v14-multitenant
curl -XGET localhost:8080/reallocateTo/guest1
curl -XPOST localhost:8080/web/api/v2/guest1/test/hello

You should see {"greeting":"Hello stranger!"}

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

To invoke with parameters
curl -XPOST "localhost:8080/web/api/v2/whisk.system/user274378/sampleJavaScript" -d '{"value":{"name":"X"}}' -H "Content-Type: application/json"


Provoke - Cleanse

Missing Scale Meter
Currently has no scaling meter and displays no additional heal on hit in stats.

Does it actually get more than one stack? According to https://www.d3planner.com/powers/46006/X1_Crusader_Provoke max stacks is 1, but it might be unused.

Yes i tested it yesterday and based on how many sorrounding me i got more or less the most common was 5-12 while the highest i had was close to 30. the number is shown in the corner of provoke while it's up and each new use overwrite's the old with new stacks.


Multiple Realm.Configuration doesn't migrate the database

Goals
Migrate the database using multiple configurations.
Expected Results
Remove a not used property of a table.
Actual Results
The database doesn't migrate.
Steps to Reproduce
Just create your Realm.Configuration on the very first step of your application, generally on the method func application(application, didFinishLaunchingWithOptions). Currently on my code, the migration is the very first action to run.
Code Sample

Give a Realm object, the property something: String exists on the previous version (2) of the database, but It was removed of the model on the current version (3) and it will be removed of the database on the next migration:
class Foo: Object {

  dynamic var id: Int = 0
  dynamic var bar: String = ""

//Property to be removed.
//dynamic var something: String? = ""

  convenience init(id: Int) {
    self.init()
  }

  override static func primaryKey() -> String? {
    return "id"
  }

}

There is a generic method for migration, like this:

let migrationBlock: MigrationBlock = { migration, oldSchemaVersion in

  //Other migrations...

  if schema < 3 {

    migration.enumerateObjects(ofType: Foo.className()) { _, newObject in
      newObject!["bar"] = ""
    }

    schema += 1

  }

}

On func application(application, didFinishLaunchingWithOptions):
let config = Realm.Configuration(
    schemaVersion: 3,
    migrationBlock: migrationBlock)

// Tell Realm to use this new configuration object for the default Realm
Realm.Configuration.defaultConfiguration = config

On another configuration:
do {

  let configuration = Realm.Configuration(
      schemaVersion: 3,
      migrationBlock: migrationBlock,
      objectTypes: [Foo.self])

  let realm: Realm = try Realm(configuration: configuration)
  //Does queries and other things.

} catch {
  print(error)
}

If you try to use it, simply using  try Realm(), the database will not migrated and returns error code 10:

The migration process is working, I have added a print() to check if the Realm migration is being invoked and it is.
Version of Realm and Tooling

Realm framework version: 2.8.3
Realm Object Server version: None
Xcode version: 8.3.3
iOS/OSX version: All versions
Dependency manager + version: Cocoapods
Thank you.

I assembled the code snippets you provided into a test app and was not able to reproduce the problem when doing the following:

Uncomment the something property of Foo.
Set the schema version to 2.
Run the app.
Comment out the something property once more.
Bump the schema version to 3.
Re-run the app.

You can see the complete code I tested with at https://gist.github.com/bdash/235e8638f813bf4684dfa7a9878b26cc.
Can you please share more information about what steps are necessary to reproduce the problem? Sharing self-contained code that I can run to reproduce the problem would optimal.
Can you please also share the complete error message you're seeing? The error message you shared has portions obscured, which makes it challenging to see what is amiss.

Also, in the code you provided your two different configurations appear to point to the same file, and have the same schema version numbers. Is that really the case?

@bdash I will check if my code is using Realm before the migration, but I don't believe that's happening.
The error there is everything that the console prints. Just three lines. :( Would be cool to Realm shows here the problem happened.
No, the previous version (2) contains the property something, the current version (3) doesn't. This is changing otherwise the migration could never work.

Probably this is a conflict between the methods didFinishLaunchingWithOptions and applicationDidBecomeActive.

@bdash Can this issue be related with any problem on Realm?

It sounds like you've found the cause of your problem. Can you clarify what questions, if any, still remain to be addressed?

I would like to know if this issue can be related with the Realm's migration structure.
It sounds like a clash of migrations running on the very first application process, interesting...

If you're opening the same Realm file from multiple places within your app you should be sure to do so using the same Realm.Configuration object. This will ensure that the appropriate migrations are performed, no matter which code path in your app happens to be hit first.
Beyond that, if you have any more questions please share code snippets that demonstrate what you're asking about.


upgrade @action/cache to 3.0.3 to fix stuck issue

Description:
@action/cache 3.0.3 fixs a download  stuck issue
checkout https://github.com/actions/toolkit/blob/main/packages/cache/RELEASES.md#303
Related issue:
https://github.com/actions/cache/issues/810
Check list:

[ ] Mark if documentation changes are required.
[ ] Mark if tests were added or updated to cover the changes.

Hello @islishude. Thank you for your pull request. Could you please use licensed too to regenerate licenses.

Could please fix a version in the title because the actual version is 3.0.4

Done

Thank you. We'll ping you when we release a new version of the action. For the testing you can use commit of the changes.


Is it possible to increase size of page from the bottom?

I'm trying to add spacing to the bottom of a PDF page however if I use the page.setHeight() command, it adds the spacing at the top. Is it possible to add to the bottom? Or somehow move the existing code to the top?
Code to add 30 pixels of spacing:
page.setHeight(page.getSize().height + 30)

Before:

After:

Hello @joelpoloney! You can use PDFPage.translateContent to shift everything up by 30 units after increasing the height by 30 units.

Hello @joelpoloney! You can use PDFPage.translateContent to shift everything up by 30 units after increasing the height by 30 units.

Thank you @Hopding!

Thank you @Hopding!


Add extra copy-project-relative-path replacing path separators for windows

https://github.com/s-shin/atom-copy-path/pull/7

looks good to me and it works ;)
i will close my PR then

ok, sorry for the disruption, it was just a weird error message but icouldt reproduce it
@s-shin ist works, looks good to merge :)

Thanks, will publish soon!


⚠ Bofrost.de has degraded performance

In c8c7633, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1059 ms

Resolved: Bofrost.de performance has improved in 50f1dea after 26 minutes.


Issue in pure Swift project with Cocoapods 1.0.0

When use use_frameworks! in a pure Swift project with Cocoapods 1.0.0, there is an issue:
/Users/xxx/Library/Developer/Xcode/DerivedData/xxx/Build/Products/Debug-iphoneos/NHNetworkTime/NHNetworkTime.framework/Headers/NHNetAssociation.h:16:9: error: 'CocoaAsyncSocket/GCDAsyncUdpSocket.h' file not found

I have no problem with Cocoapods 1.0.0 and Swift project use use_frameworks!. Do you call import NHNetworkTime in source file use NHNetworkClock?
Does anyone else has same issue?

Yes, of course.

@huynguyencong I found it something wrong because of upgrading to Cocoapods 1.0.0 and the cached wrong module file in DerivedData directory. I cleaned the files, and it works now.
Thanks.


Get CI tests workings

Fixes #324
CI is now working. So peoples PRs arnt blocked by failing CI.
We may revisit implementation here. But this should be okay for now :)

Thanks both updated as per your comments.

Thanks @danpaquin


Correct bug in description generation for write-only properties

Closes #434

Codecov Report

Merging #435 (acd08b5) into main (59b54d2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   95.23%   95.23%
=======================================
  Files          17       17
  Lines         252      252
=======================================
  Hits          240      240
  Misses         12       12

Flag
Coverage Δ

dotnet
95.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


notFoundHandler not called

node examples/error-handler.js

> curl localhost:4000/nonexisting
curl: (52) Empty reply from serve

Also a bit weird that the function has signature
    setNotFoundHandler(
      notFoundHandlerCallback: (
        res: HttpRequestBasic,
        req: HttpRequestBasic
      ) => HttpRequestBasic
    ): nanoexpressApp;

when every other method follows the node convention with request, response

Can you test, it is fixed?


add test for MerkleUtils (failing)

The new test fails. Isn't my understanding of the expected behavior of the merkleize function is incorrect. Based on the image below, the first element shall be hashed with itself first, that's why in the test I have:
 bytes32 chunk0 = keccak256(abi.encodePacked(chunks[0], chunks[0]));

But even if I change it to the following, the test still fail:
 bytes32 chunk0 = chunks[0];

Merkleization uses sha256 hashing function via sha256 evm precompile, keccak256 won't work. So, if you change it to sha256, the bytes32 chunk0 = chunks[0]; variant should work imo.
While it looks like the pubkey is being hashed onto itself, it is actually a recursive merkleization. Pubkey has 48bytes, which is padded to 64bytes and the two 32byte chunks are merkleized. SiImilar to this: https://github.com/NethermindEth/Taiko-Preconf-AVS/blob/master/SmartContracts/src/libraries/EIP4788.sol#L43

The new test passes now.


[FR]: Toy Datasets for Opik

Proposal summary
Would be nice to have some out-of-the box Toy datasets for users to play around and get started with the platform quicker. Something similar to load_iris in sklearn packages. To start, I was thinking of having a 15 question sample dataset for Machine Translation and ChatBots.
Not sure if the user should be expected to still add the dataset to their workspace or maybe users start out with the sample datasets already there and can just call get_dataset
I have the json file we could use for the MT Sample dataset.
french_phrases.json
Motivation
Improve the developer experience so they can run evaluations without needing their own dataset

Hey,
I think pandas has a few toy datasets that might be relevant or perhaps some HuggingFace datasets could be used for it as well for these use-cases.
We do have in our future roadmap some ideas around allowing users to make their datasets public that could solve this as well. For now I'll close as won't fix


Run in Custom Subnet with Statically Allocated IPs

this allows each service to know their own Public IP so they can present themselves as validators to other nodes on the network.

now resolves https://github.com/kurtosis-tech/kurtosis/issues/52


Add login and sign up pages

For the moment lets add very simple login and sign up pages.

@aryangupta-42 you can work on this.

closed via #16


dns/dyndns: Make regfish DynDNS work for IPv4 and IPv6

regfish requires 2 different URIs to update, depending on the IP family.
https://dyndns.regfish.de is for IPv4
https://dyndns6.regfish.de is for IPv6.
For reference: https://www.regfish.de/domains/dyndns/dokumentation

It seems kinda silly that it splits IPv4 and IPv6 domains, but if it fixes it it's good. Thanks!


SW-4772 Allow the implementer to determine if the options are shown

Current dependencies on/for this PR:

main

PR #468   👈

This stack of pull requests is managed by Graphite.

publish rc

publish rc

publish rc


Easy way to mount secrets etc when using --docker-run

See also #341.

#454 does a better job

Addressed in #610 with docs.


Postgres unable able to start with "waiting for WAL to become available at 0/B5002000" message

My local install is failing to restart.
The log keeps printing this message.
waiting for WAL to become available at 0/B5002000

The tenant and time status seems fine.
{
    "current_physical_size":<PHONE_NUMBER>,
    "has_in_progress_downloads": false,
    "id": "ca5fbf3053bc9ea10eb2f32949f78c91",
    "state": {
        "slug": "Active"
    }
}

{
    "ancestor_lsn": null,
    "ancestor_timeline_id": null,
    "current_logical_size": 814563328,
    "current_logical_size_non_incremental": null,
    "current_physical_size":<PHONE_NUMBER>,
    "disk_consistent_lsn": "0/B5480B40",
    "last_received_msg_lsn": null,
    "last_received_msg_ts": null,
    "last_record_lsn": "0/B5480B40",
    "latest_gc_cutoff_lsn": "0/4129838",
    "pg_version": 15,
    "prev_record_lsn": "0/0",
    "remote_consistent_lsn": "0/B5480B40",
    "state": "Active",
    "tenant_id": "ca5fbf3053bc9ea10eb2f32949f78c91",
    "timeline_dir_layer_file_size_sum": null,
    "timeline_id": "80ed3be9cbb1a738d90ff39e7e4ccaaa",
    "wal_source_connstr": null
}

I tried restarting everything, safekeepers, pageserver and postgres but still can not get it to work.

@mingfang do you have some way of reproducing this issue, or logs?

"wal_source_connstr": null

was a safekeeper running when this happened?

@koivunej
Thanks for looking into this.
This usually happens whenever I upgrade the entire stack.
My steps are
1-upgrade the three safekeepers one at a time
2-upgrade pageserver
3-attach tenant and timeline to pageserver
4-upgrade postgres
Not sure if that's the right sequence.
Perhaps I should take down the postgres before upgrading the pageserver.
The good news is I upgraded to the latest yesterday and the problem went away.
I'll try to repeat this several times to confirm if this doesn't come back.

I guess whatever the problem was, it no longer occurs. Closing.


Setup creds files

Going to leave this for now, since it's less about vagrant and more about linode's API


M5StackCoreS3 with BMI270

M5StackCoreS3 does not use MPU9250 but BMI270 I guess.
I found a driver https://github.com/qrasmont/bmi270 but it doesn't seem to work.
Did you manage to use BMI270 with MPU9250 driver ?

@xtox-io Unfortunatelly I was not able to get it running, yet.
@pedrominatel Do you have any hints on BMI270?

@playfulFence Could you check the Rust implementation?
BSP for M5Stack migt help works: https://components.espressif.com/components/espressif/m5stack_core_s3

@georgik I've been using the Bosch Sensortec APIs for the BMI160 with no issues in one of my projects with ESP-IDF.
For the BMI270, they have this library.
https://github.com/boschsensortec/BMI270_SensorAPI
I don't have a BMI270 for testing, only a BMI160.

@playfulFence Could you check the Rust implementation? BSP for M5Stack migt help works: https://components.espressif.com/components/espressif/m5stack_core_s3

Hi I checked but couldn't see any detail related to BMI270 in BSP repo.
Still investigating :)


Issue/3

Implemented Lic1 and associated test cases.
Helper methods are included for better readability of Lic1 code.
fixes #3

LGTM with one exception, when verifying that NUMPOINTS is a valid shouldn't number 0 be allowed? I.e. in LicAnalyzer.java on line 78: (n < 0) rather than (n < 1)? My reasoning is that the LIC can still evaluate no points and conclude that its requirements are not met.

As per the assignment instructions2 <= NUMPOINTS <= 100
Make sure to include the upper limit like so (n < 0 || n > 98)

As per the assignment instructions2 <= NUMPOINTS <= 100
Make sure to include the upper limit like so (n < 0 || n > 98)

Missed this myself, since this is the case my initial comment on this pull request probably cease to matter. Sorry.


Allow user to set annotations and loadBalancerIP property of service

No issue for this change.
In order to set a DNS label on the load balancer in the azure environment I need to be able to set service annotations
To support a public IP address for the load balancer in the Azure environment I need to be able to set the loadBalancerIP property.

Example stanza for values file:
service:
  annotations:
    # sets dns label for the load balancer. Azure will then automatically append a default subnet,
    # such as <location>.cloudapp.azure.com (where location is the region you selected), to the
    # name you provide, to create the fully qualified DNS name.
    service.beta.kubernetes.io/azure-dns-label-name: mydnslabel
  loadBalancerIP: xxx.xxx.xxx.xxx

Resolves https://github.com/stardog-union/helm-charts/issues/46

Looks good to me. Can you create an issue for the release notes? It can be as simple as the PR title, just so I can track what was updated. Thanks!

Done!


fix: extract the active cooldowns for items

Currently, the code searches for the cooldown using a regex on the description which doesn't hold the cooldown anymore. Right now, the cooldown is in an attribute called "cd".
E.g. https://i.imgur.com/EqLaxbu.jpg

Thanks! @dryancd took care of this just a minute ago along with some other changes that your PR helped us find. I'm going to close this because it's now fixed here: https://github.com/meraki-analytics/lolstaticdata/pull/37
We both really appreciate the PR because it helped us fix a bigger issue!


fix(#41): deep_link – function expression

Error appears: Safari Version 9.1.1 (11601.6.17)
"Strict mode does not allow function declarations in a lexically nested
statement."
changed deep_link function declaration to unnamed function expression

#41

have found error in chrome, temporarily solved by moving var deep_link = function() { … }  upper than $this.opts['active'] = $this.opts.deeplinking … (to line:86)


fix(Popover/Dropdown): use @touchstart.passive instead of @touchstart.prevent

🔗 Linked issue

Resolves #1512
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Change from prevent to passive ontouchstart event.
To fix the bug: [Violation] Added non-passive event listener to a scroll-blocking  event. Consider marking event handler as 'passive' to make the page more responsive. See
📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Thanks! 😊


[RFE] SL Micro 6 doesn't allow ssh with password for root user by default

We probably would like to add a small note on the release notes for Edge 3.1 about this.

Also look up all ssh references in the docs - we might have to adjust EIB definitions to user non-root users.

SL Micro 6 release notes are going to be updated to reflect those changes as well https://bugzilla.suse.com/show_bug.cgi?id=1230781


Tailscale Manifest

Description of the new feature/enhancement
The Tailscale Manifest (manifests/Tailscale/Tailscale/<IP_ADDRESS>.yaml) has a problem with the name:
Name: Tailscalehttps://pkgs.tailscale.com/stable/tailscale-ipn-setup-0.98-0.exe
The download link is pasted next to the name.

@tiernano  Would you fix that?

PR Created (https://github.com/microsoft/winget-pkgs/pull/1058)

Issue fixed (e2ca5bf)


v2.0.0 tag is missing

Was v2.0.0 actually released? If not what commit binaries from #3140 correspond to? I'm curious from reproducibility and packaging perspective.

https://github.com/cisco/openh264/releases/tag/v2.0.0


Fix FileNotFoundError in seup.py

Nonexistent README instead of README.md is referenced.

pip install git+https://github.com/serpapi/google-search-results-python.git
Collecting git+https://github.com/serpapi/google-search-results-python.git
  Cloning https://github.com/serpapi/google-search-results-python.git to /tmp/pip-req-build-cubg90st
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-cubg90st/setup.py", line 23, in <module>
        long_description=open('README').read()
      File "/home/fizz/.conda/lib/python3.6/codecs.py", line 897, in open
        file = builtins.open(filename, mode, buffering)
    FileNotFoundError: [Errno 2] No such file or directory: 'README'

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-req-build-cubg90st/

Thanks for the fix!


pnet macro import statement is showing as unresolved import

Cargo.toml has only one dependency:
[dependencies]
pnet = "0.28.0"

And here is the main.rs
use pnet::packet::icmp::echo_request::MutableEchoRequestPacket;
fn main() {
    println!("Hello, world!");
}

rust-analyzer can not resolve the import statement.

cargo build works.

This type seems to be created via an attribute, try enabling the rust-analyzer.experimental.procAttrMacros setting.

Disabling experimental diagnostics rust-analyzer.diagnostics.enableExperimental works for me. Enabling rust-analyzer.experimental.procAttrMacros does not help in my case.

Disabling experimental diagnostics rust-analyzer.diagnostics.enableExperimental works for me

That just hides the diagnostic and doesn't fix the actual problem.

This type seems to be created via an attribute, try enabling the rust-analyzer.experimental.procAttrMacros setting.

This worked for my vscode. Thank you. I guess not knowing that those are attribute macros (still new in Rust land) caused the trouble for me.


Allow initiative modifying cards

This allows cards that modify initiative (such as Kingsroad - see full list) to be implemented. The game now asks Player for a list of all cards in play that modify the initiative. The player determines this by looking for an initiative value on the card - plots inherently have one, it can be added to cards that modify initiative.
A similar approach can be taken for cards that modify the amount of gold collected at the start of the marshal phase, as well as cards that modify the reserve value. I do have a couple concerns that I'd like feedback on, which I'll detail as separate comments on the code.
As always, feel free to scrap if you don't like this direction.

I like the idea, but I might go a slightly different route with something like Player having getTotalInititive() and getTotalIncome(), which uses the same sort of logic that you're proposing.  It's probably better than the implementation I currently have for roseroad.

I can certainly add a method for getting the total. I think the list of cards will be needed in at least certain situations (plot Snowed Under which ignores initiative from the plot card but not other cards, plot Rains of Autumn which ignores gold derived from characters + locations). But it may not be necessary to use directly right now.
I did use the full list for the initiative calculation message to players. Let me know if you think that's too verbose and I'll remove.
Not sure you saw my review comments I made about how initiative was being set on cards, so I'll reproduce here:
I don't particularly like this approach of modifying the card (in the implementation for Kingsroad), but it worked as a proof-of-concept. It probably would be better if this value was in the database that the card info is pulled from. I know that the data is currently pulled from ThronesDB and stored locally.
It may make more sense to add an additional setup step (either in separate migrations file or in fetchdata.js) that augments the card data with additional metadata such as gold, initiative, reserve, etc modifiers. You might be able to read it from the text description from ThronesDB (often says things like "+1 Initiative") but that could get iffy. Thoughts?

I guess we could add more metadata but will that necessarily take effect when the card is added or removed from play? We still need logic to apply and remove the modifiers (in the case more of initiative as that is more fluid) to a player at the appropriate times. I think storing it with a player as two values that dynamically get updated when appropriate cards are played makes the most intuitive sense to me. It's easily referenceable and I think more easy to calculate the total initiative/gold values than wrapping it in methods. A little crude yes but why get fancy?

My original plan was to do it like how the plots do it.  Modify the values on the card or in the state when the card is registered(put into play) and restore the original value when it is unregistered(leaves play).
In your example, Snowed under would have a plotRevealed handler that sets both plots initiative to 0 on reveal and then in unregister it will restore both plots back to their initiative values.
So the getInitiative() method on the player would look something like(very not valid pseudocode):
return this.activePlot.card.initiative + allCards.sum(card.initiative)
This falls down a bit when multiple cards affect a plot's initiative(not sure if there are any situations where this happens) but it can be worked around
I'm ok with the modifier value being in the card's implementation, I've always wanted to keep the static data (from thronesdb) separate to the implementation of the card.
I think the full list of modifiers is unnecessary.  I've tried to keep chat messages to when interactions happen.  If the initiative/gold modifier is printed on the card, then that should be enough for players to see what's going on.  As a game engine we need to explain interactions so that the players know what's happening and when to correct things.  For example when text on a card is resolved automatically.
Am I making any sense? I feel like I'm rambling

Looks like this was ported in commit 7fd95eaffd10d0e6fa8864be81526ec616c9d13e. Closing!


Bump submodule zephyr-on-litex-vexriscv?

This repo is using zephyr-on-litex-vexriscv pinned at its very first commit.   There have been quite a few updates in that repo; do you want to bump the reference from here to a more recent commit?

The zephyr-on-litex-vexriscv submodule is now bumped and targets the most recent commit.


Push image to GHCR on release or master update

resolves #214
Signed-off-by: Peter Engelbert

I've created a new bot user, @oci-ghcr-bot, and added a personal access token under this repo's secrets. I think prior to merging this PR we just need somebody to add the handle to the opencontainers org.. Who can help w/ that? TOB members?


Associate/dissociate form "Via Vesting contract" option is disabled where it shouldn't be

In this case I have tokens in the vesting contract and none in my wallet.
The associate form shows the Via vesting contract appears to be disabled.

Intended: if you have tokens in the vesting contract the option should not be disabled.
The dissociate form has the same issue:

It is still possible to stake as the option is selected but if you select wallet you then can't select vesting without refresh

Not a bug, this is bad configuration on the FG environment :+1:


Update test_ida_features.py

Updated with f string for enhanced readability.

Checklist

[x] No CHANGELOG update needed

[ ] No new tests needed

[ ] No documentation update needed

Note that a lot of changes already have been proposed and reviewed in #1353. I suggest we hold onto updates to fstring until that PR is merged.