Resource framework / PROGMEM compression

@jmamma
https://github.com/siara-cc/Unishox_Arduino_Progmem_lib
We can use this to develop a resource management framework like ".big" files for a game

that's awesome. the decompressor uses up 3000bytes. how much do you think we'll save?

hard to tell, and perhaps it's more effective to concat shorter strings into a big chunk.
I'll give this a try later.

Total compressable object size: 15489

The key property to exploit is that we don't need everything decompressed at all time.
My idea is to allocate a pool to cache these values.
During the setup routine of a page, call the resource manager to pull relevant stuff into the pool.

shox doesn't work for binary data.
https://github.com/pfalcon/uzlib may be a better choice.

cool. we'll find something that works. the principle is sound.
Comes at a good time, I can't enable debug mode anymore.

== Initial comp branch size ==
Sketch uses 228562 bytes (90%) of program storage space. Maximum is 253952 bytes.
Global variables use 47314 bytes (83%) of dynamic memory, leaving 9517 bytes for local variables. Maximum is 56831 bytes.

== With uzlib ==
Sketch uses 231026 bytes (90%) of program storage space. Maximum is 253952 bytes.
Global variables use 51610 bytes (90%) of dynamic memory, leaving 5221 bytes for local variables. Maximum is 56831 bytes.
PROGMEM +2464
RAM +4296 (4096 buffer)

== Compression run result ==
 ┌─┐ C:\Users\Yatao\Documents\Arduino\hardware\MIDICtrl20_MegaCommand\resource                                                                                 comp ◇◇ ┆ Yatao
 └─╜ ╰▷ .\gen-resource.ps1
Compiling C:\Users\Yatao\Documents\Arduino\hardware\MIDICtrl20_MegaCommand\resource\fonts.cpp
compressed 3621 to 2871 raw bytes
Compiling C:\Users\Yatao\Documents\Arduino\hardware\MIDICtrl20_MegaCommand\resource\icons.cpp
compressed 1986 to 1385 raw bytes
Compiling C:\Users\Yatao\Documents\Arduino\hardware\MIDICtrl20_MegaCommand\resource\machine_names.cpp
compressed 5345 to 2947 raw bytes
Compiling C:\Users\Yatao\Documents\Arduino\hardware\MIDICtrl20_MegaCommand\resource\menu_options.cpp
compressed 738 to 399 raw bytes
Compiling C:\Users\Yatao\Documents\Arduino\hardware\MIDICtrl20_MegaCommand\resource\tuning.cpp
compressed 810 to 700 raw bytes

What do you think?

See #162
Current net gain is around 2KB.

https://github.com/google/brotli

Brotli destroys gzip:
-a----         4/11/2021   4:38 AM           2279 fonts.br
-a----         4/11/2021   4:10 AM           2871 fonts.z
-a----         4/11/2021   4:38 AM           1085 icons.br
-a----         4/11/2021   4:10 AM           1385 icons.z
-a----         4/11/2021   4:38 AM           1521 machine_names.br
-a----         4/11/2021   4:10 AM           2947 machine_names.z
-a----         4/11/2021   4:38 AM            314 menu_options.br
-a----         4/11/2021   4:10 AM            399 menu_options.z
-a----         4/11/2021   4:38 AM            501 tuning.br
-a----         4/11/2021   4:10 AM            700 tuning.z

 ┌─┐ C:\Users\Yatao\Documents\Arduino\hardware\MIDICtrl20_MegaCommand\resource                                                                                 comp ◇◇ ┆ Yatao
 └─╜ ╰▷ gci *.hex | Measure-Object -sum -Property Length

Count    : 5
Average  :
Sum      : 12500
Minimum  :
Property : Length

 ┌─┐ C:\Users\Yatao\Documents\Arduino\hardware\MIDICtrl20_MegaCommand\resource                                                                                 comp ◇◇ ┆ Yatao
 └─╜ ╰▷ gci *.z | Measure-Object -sum -Property Length

Count    : 5
Average  :
Sum      : 8302
Maximum  :
Minimum  :
Property : Length

 ┌─┐ C:\Users\Yatao\Documents\Arduino\hardware\MIDICtrl20_MegaCommand\resource                                                                                 comp ◇◇ ┆ Yatao
 └─╜ ╰▷ gci *.br | Measure-Object -sum -Property Length

Count    : 5
Average  :
Sum      : 5700
Maximum  :
Minimum  :
Property : Length

😱😱😱

net gain unknown, need to port brotli to avr

Decomposing icons.cpp:

About 'Elektrothic'
Can we trim this one down to digits only.

== With unpack ==
Sketch uses 228944 bytes (90%) of program storage space. Maximum is 253952 bytes.
Global variables use 47314 bytes (83%) of dynamic memory, leaving 9517 bytes for local variables. Maximum is 56831 bytes.
Low memory available, stability problems may occur.
PROGMEM +382
RAM +0 (hey)

Awfully low overhead.

About 'Elektrothic'
Can we trim this one down to digits only.

Yes. But we need to identify which bytes in the bitmap structure correspond to the numerals.

comp branch


TypeScript typings: fix incorrect undefined

const x = Map<string,string>();
x.set('y', 'bar').map((key, value) => 1)

In TypeScript 2 with strict null checking enabled and the current typings, the value parameter is inferred to be string | undefined because of these typings:
    map<M>(
      mapper: (value?: V, key?: K, iter?: /*this*/Iterable<K, V>) => M,
      context?: any
    ): /*this*/Iterable<K, M>;

I believe the ? is intended to mean "this parameter is optional". However, in practice it is equivalent to value: V | undefined, which is of course saying something very different. Parameters are already optional in TypeScript:
type x = (y: number) => number
const p: x = () => 1 // fine
const p: x = (y) => 1 // fine

By changing the typings to the following, value is correctly inferred as string.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Also fixed by https://github.com/facebook/immutable-js/pull/919

Is there some way to test these? Like adding a little bit of test code that exercises this specific type? We have a big backlog of pull requests of the form "tweak types a bit" and I just hesitate for the plan to be that I eyeball a bunch of them.

Closed by #919


Misleading error log for Dialog Title

I'm using a Dialog from Radix UI Themes inside a Web Component Shadow DOM, and it's working well, except for an error message related to the DialogTitle:
`DialogContent` requires a `DialogTitle` for the component to be accessible for screen reader users.

If you want to hide the `DialogTitle`, you can wrap it with our VisuallyHidden component.

For more information, see https://radix-ui.com/primitives/docs/components/dialog

Looking at the code, it's easy to see why this error is being logged, the check for title it looking in the document, but my title is in the Shadow DOM.
  React.useEffect(() => {
    if (titleId) {
      const hasTitle = document.getElementById(titleId);
      if (!hasTitle) console.error(MESSAGE);
    }
  }, [MESSAGE, titleId]);

I've tested my ARIA output and despite this error message my title is perfectly accessible based on the implementation of aria-labelby  within the Radix UI component.
I think the error message should be revised to a warning because document.getElementById doesn't guarantee a missing title in some scenarios.
Otherwise, I'm loving Radix UI, thanks for all your hard work!
Cheers.

Same scenario here

I'm facing the exact same issue.


Type check errors

Type check errors thrown by mypy when importing referencing
To reproduce this issue, create a test.py as below:
import referencing

Execute command:
mypy test.py

This issue is applicable on versions 0.31.0 and above.

⊙  echo 'import referencing' >foo.py && python3.12 -m venv venv && venv/bin/pip install --quiet referencing mypy && venv/bin/mypy foo.py                                                                                julian@Airm
Success: no issues found in 1 source file

The type checks was done on a lower mypy version (0.961) That was the reason for the error.


Fix the contact prompt

Contact prompt is empty presently, either ask for a link or some telegram handle.

@issuehuntfest has funded $30.00 to this issue. See it on IssueHunt

@anshumanv has submitted a pull request. See it on IssueHunt

@anshumanv has rewarded $21.00 to @anshumanv. See it on IssueHunt

:moneybag: Total deposit: $30.00
:tada: Repository reward(20%): $6.00
:wrench: Service fee(10%): $3.00


[SR-13503] [Sema] Special InsertExplicitCall for nominal callable types

Detect if a type mismatch we the source type is a callable nominal and has a callAsFunction that produces the destination type, so we can suggest making it an explicit call to it.

Resolves SR-13503.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please smoke test

Just organizing some old PRs, so closing this. It's linked to the ticket for future reference =]


chore: release 2.2.0

:robot: I have created a release *beep* *boop*
2.2.0 (2019-06-05)
Bug Fixes

Store large numbers as doubles (#683) (607b3c0)

Features

support apiEndpoint override in client constructor (368bc5c)
support apiEndpoint override in client constructor (#679) (8cbac6b)
Support host, ssl and FIRESTORE_EMULATOR_HOST for endpoint configuration (#680) (d15f29d)

I think there a bug in https://www.github.com/googleapis/nodejs-firestore/issues/680. I will verify it tomorrow but I think it doesn't split the port number correctly when the servicePath is used. I will remove the auto-release label.


feat: voter should not be able to vote on passed proposals (UI only)

Overview

disables input on passed questions
checks latest state before submitting vote
displays Dialog to reallocate votes

Issues:

https://algorandfoundation.atlassian.net/browse/ENG-211

Confirmed that a proposal that's already passed gets greyed out.


Int64Field tokenized

Hello,
I looked through the source code and saw that the Int64Field has the Parameter IsTokenized set on true.
I found that weird, because I thought only strings can be tokenized.
What does that mean for the integer?
And how does it affect the search?

Emre – It’s a really good question.  I’ve wondered the same thing before as well.  Your question prompted me to do a bit of digging and this is the conclusion I reached:
It seems that Lucene considers the step of converting an Int64Field into a Trie structure for indexing to be a form of tokenization.  While the approach does not use an Analyzer per se it is true that Lucene does greatly change the form of the number before putting that new representation into the index.  And non-tokenized fields are placed directly in the inverted index, which is not the case for numbers since what is placed in the inverted index is a trie structure corresponding to the number.  That trie structure often has 8 terms which are placed in the inverted index but the number of terms will very based on the numeric Field’s NumericPrecisionStep.
One piece of code that shines a bit of light onto this is here:
https://github.com/apache/lucenenet/blob/Lucene.Net_4_8_0_beta00015/src/Lucene.Net/Document/Field.cs#L168
-Ron
rclabo
From: Emre Rauhofer @.***
Sent: Thursday, December 9, 2021 7:57 AM
To: apache/lucenenet
Cc: Subscribed
Subject: [apache/lucenenet] Int64Field tokenized (Issue #569)
Hello,
I looked through the source code and saw that the Int64Field has the Parameter IsTokenized set on true.
I found that weird, because I thought only strings can be tokenized.
What does that mean for the integer?
And how does it affect the search?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/apache/lucenenet/issues/569 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABU7VWZD5FNZQV4BEU2KWD3UQCRRDANCNFSM5JWM3IOQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .   https://github.com/notifications/beacon/ABU7VW3ILM5SWS36PSPKELLUQCRRDA5CNFSM5JWM3IO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4QA3PNZA.gif

Thanks @rclabo.
In addition, there is a bit of info in the NumericUtils documentation that explains the storage a little more. However, Lucene is notably bad at keeping their documentation up to date, so this may be referring to previous versions of Lucene.


[REQUEST]: Scrape from Multiple Fritzbox Endpoints.

I have several Fritzboxes in my Network and want to Monitor them with just one running script :).

I would be happy if i'm able to make it working with several scripts (and multiple containers). But as soon as I start 2 container for my 2 Fritzboxes using the same prometeus server I see the two fritzboxes mixed up in the same dashboard :-(
Micha


Raw ACCESS_KEY in main.js

Hi.
I found raw-ACCESS_KEY in your code, and I thought publishing ACCESS_KEY without using whitelist or some means of verifying on your API-server can be security issue.
you should use dotenv or some and hide it, unless you have already dealt with this issue, to keep your software secure.

Thank you message.
This ACCESS_KEY is dummy.
I don't use this ACCESS_KEY in local.
( And, ACCESS_KEY generator command output sample. )
I think I must write of it to README. I going to fix it.
I going to guide to change ACCESS_KEY for developer on README.
And, Bot's server used .env system.
But, Moddable SDK can't use .env system.
I have some way for cleaning this problem.

Developing of HTTP Server Mode and Web UI for ACCESS_KEY setting.
Using ESP8266 Flash Storage.
... etc

Please expect.


I am suggesting a change to the whitelisting and blacklisting.

Issues with former code:

Any whited listed errors that didn't inherit from StandardError were not being rescued.

Suggested Solution:
Change the whitelist to be a whitelist of StandardError errors.
Change the blacklist to be a blacklist of not StandardError errors or Exception errors.

This is a natural followup to #94. I'll find some time to review it soon.
I'm not concerned about the coverage dropping by 0.2%.

I'm not sure yet if my changes are most optimal, let me explain. It is an exceptional case to rescue Exception class errors because of there implications ie. NoMemoryError, so they should be explicitly blacklisted. In my current changes that is well established. The next area is StandardError, I've went back forth it can be confusing to think about a blacklist and a whitelist being used at the same time.
I've come to the conclusion that in addition to my changes there needs to be user supplied Proc where they can decide whether Stoplight should care about an error.  This would provide a customizable interface for user and reduce code for additional use cases.
Thank you @tfausak for reviewing my PR.

A Proc would be a lot simpler. That might be the best way forward here.

Use RSpec's code as a battle tested choice for choosing which error to not rescue.
User can override whitelists and blacklist strategy and provide custom strategy using #with_error_handler
@tfausak That's for your time in reviewing this.

I think this will take an overhaul of the exception handling in Stoplight. The end goal here is to completely remove the whitelist and blacklist. Both will be replaced by this new Proc. I'll try to get a proof of concept together today.

Can you have a look at https://github.com/orgsync/stoplight/pull/97?


MACD errors

Version  0.10.1
ta.trend.MACD(df.close, window_slow = 26, window_fast = 12, window_sign = 9)  is outputing <ta.trend.MACD object at 0x000001C2823C7280>
ta.trend.macd(df.close, window_slow = 26, window_fast = 12, window_sign = 9)   is outputing TypeError: macd() got an unexpected keyword argument 'window_sign'
ta.trend.macd(df.close, window_slow = 26, window_fast = 12) output ok

AFAIU, it's not a bug, because ta.trend.macd(df.close, window_slow = 26, window_fast = 12) is a shorthand for ta.trend.MACD(df.close, window_slow = 26, window_fast = 12, window_sign = 9).macd()
you don't need a signal line to calculate .macd() hence parameter window_sign is not needed for it. it's needed only for ta.trend.macd_signal(...) and ta.trend.macd_diff().


Incompatible with Forgified Fabric?

I've been creating a modpack with the Forgified Fabric, and the Sinytra Connector, and I've had some mild success with a few other mods, but for some reason Origins TOTALLY hates this setup. I'm sure it's got to do with the fact that Origins hijacks your game right after the world loads, but... I really am not a coder, so I have no idea what could be wrong with it.
I've tried using the Fabric Version of Origins, as well as some older versions because I thought since Forgified Fabric, and Sinytra Connector force you to use the old Forge version, that maybe that was why... but no luck.
The crash report I get from Minecraft's Launcher is something like this:
The game crashed whilst rendering overlay
Error: java.lang.IllegalArgumentException: Failed to create model for minecraft:armor_stand
Exit Code: -1
Although interestingly enough, if I keep trying it the "armor_stand" gets replaced with other stuff like I got "husk", and "skeleton" a few times too.
I guess this is a pretty insane ask, especially because everyone making this mod must be so busy as-is, but I really as excited to use Origins, and... now I'm realizing it won't work at all...

Correction, and apology, I wasn't using the Caelus API (Forge/NeoForge) in my pack, that's my bad. BUT I'm not going to delete this because Caelus API should have been added automatically with the CurseForge Launcher, and it wasn't. So maybe that helps someone out there with the same issue.

I have now fixed the Caelus API dependency on CurseForge.


Replace log_gpu_memory with gpu_stats_callback

What does this PR do?

Replaces log_gpu_memory with gpu_stats_callback

Fixes #3333
TODO:
Update docs
Questions:

How should we test this?
Do we want to support log_gpu_memory=min_max functionality?
Should we call it device_stats_callback instead? In case we have cpu or tpu monitors in the future

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

hey @carmocca! Any chance you want to come back to this?

I can. Any idea on who to ask the questions written at the top?


Unknown distance query/find path

Hi!
I want to know if there is any way to create a query that, given two vertex 'a','b', returns to me if there is a path between then, regardless if they are connected directly or not.
Thanks to all! :D

https://github.com/mcollina/levelgraph/issues/134


How to run Apollo 8.0 with bridge

Hi! I'm trying to run Apollo on Carla as an agent via bridge, and I can successfully run Apollo 7.0 with Carla.
However, I want to run the latest version of Apollo(version 8.0), but I have some trouble during the trials.
So I want to ask if there are any formal instructions to run latest version of Apollo on Carla with the bridge.
For the reference, here are the descriptions on my trials.
1. Cloning Apollo from main repository instead of the modified one.
I do know that there are some modifications on Apollo side for bridging. So I changed the code manually following the commit logs(6 commits), after cloning the main repository.
There were no errors during the installation and I followed the instruction(running DreamView and Carla simulator), but after running bridge on a terminal and python carla_spawn_objects/carla_spawn_objects.py on another terminal, Segmentation fault occurs on the terminal running the bridge.
2. Cloning modified repository and pull modifications for bridging by changing remote origin.
I saw the issue here, and I also tried to apply the modifications by changing remote origin, which means 1) cloning main repository and 2) changing remote origin to git remote set-url origin https://github.com/guardstrikelab/carla_apollo_bridge.git and pull) There are no errors during the installation, but after following the instructions(run DreamView, run Carla, run bridge, run spawning), I could see the spawned ego vehicle on Carla, but there are no changes on DreamView UI (which means a black screen with a message 'Please send car initial position and map data.').

Apollo v8.0 has not been tested yet. We will try to update this repo to support Apollo v8.0 in the near future. Thanks for your trials and these useful feedback.

Thank you for the reply!

Apollo v8.0 has not been tested yet. We will try to update this repo to support Apollo v8.0 in the near future. Thanks for your trials and these useful feedback.

Hi, may I check if the version now support Apollo v8.0? If it does, is there any additional requirements or operations needed when setting up the bridge?
Thanks :D


python3Packages.hyppo: fix build

Description of changes
Fix build that's failing on hydra (https://hydra.nixos.org/build/174132218) because of missing dependency.
Also fix license and description.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

(Sorry messed up the commits and re-filed a different PR)


Fix default WS avatar is shown instead of the custom one

Details

The WS avatar in invoice room shows a default avatar instead of the custom one.
Fixed Issues

$ https://github.com/Expensify/App/issues/48358
PROPOSAL: https://github.com/Expensify/App/issues/48358#issuecomment-2322809432
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Prerequisite:
Workspace has custom avatar.

As user B, send an invoice to user A from a workspace that user A isn't a member of
As user A, opens the invoice room/report
Verify the WS avatar in LHN, header and message shows the custom avatar
As User B, changes the WS avatar
As user A, refresh or reopen the invoice room
Verify the WS avatar is updated

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/456cc896-e41c-448a-a1ac-f9e664d1613f

Android: mWeb Chrome

https://github.com/user-attachments/assets/d0cca412-4842-43ea-90af-8f4746090fc7

iOS: Native

https://github.com/user-attachments/assets/ea5573a5-c757-44d5-8c56-0106ee875112

iOS: mWeb Safari

https://github.com/user-attachments/assets/d43c6488-91e2-4b7f-975b-30e43f8db09f

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/b7982923-90f6-4fcf-b74b-23ca8bbcc132

MacOS: Desktop

https://github.com/user-attachments/assets/e84d4424-c725-42f2-8745-090c2c48a0b4

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.0.36-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Time fix

Fixed time continuity by passing a start time to SplineGenerator::parameterize.

@baylessj

Hi @Dr-Danimal, thanks for opening this! I have a couple of fixes for the tests that I'd like to add but I don't have write access. Could you please check the box on this PR to allow contributions by maintainers?

@baylessj The "Allow edits by maintainers" is checked, Is there somewhere else I need to give access?

Github needed me to clone the repo first to push to your branch for some reason, I couldn't just add it as a remote. All good now


Invalid or unreachable location

Yonaba,
I currently have a grid displaying, and a player can touch a square and it would calculate a path from the center square in the map to the square that the player touched. The funny thing is, sometimes I have troubles with the assert on line ~340? (I changed mine for debugging). I get the "Invalid or unreachable at [endx][endy]" error, but it is not displaying the correct endy value.
For example, if I click on grid[3][10], it might be valid and everything works great. If I then click on grid [3][11], it says unreachable at 3,10. The weird part is that depending on what device I am emulating the rows and columns are different, i.e. iphone 4 doesn't work for row 7 and sg3 doesn't work on col 7,10 or 14.
It is really strange. I have a video here:
http://screencast.com/t/IRZZqfvl5a
and here are some screenshots:
http://screencast.com/t/79v3PLgih6HF
http://screencast.com/t/E4CZN5na9
I don't know if you have any insights: I have been struggling on this issue and can't seem to find any answers online.
Thank you, you have always been so helpful

Hi, @bsherb53
I believe the problem should be related to the tile coordinates you are dealing with in your getPath function. How do you actually convert screen coordinates (when touching on the screen) to tile/grid coordinates ?

Here is the shortened version of my touch listener:
numRows = 11 -- the number of rows to display
numCols = 17 -- the number of columns to display
numGridHeight = display.contentHeight / numRows -- this tells me the # of pixels in each tile's height
numGridWidth  = display.contentWidth  / numCols -- this tells me the # of pixels in each tile's width
moveToCol = ( event.x - ( event.x % numGridWidth ) + numGridWidth ) / numGridWidth
moveToRow = ( event.y - ( event.y % numGridHeight) + numGridHeight) / numGridHeight
and here is my getPath()
-- find the path from point A to point B
function getPath(goToCol, goToRow)
-- Creates a pathfinder object using Jump Point Search algorithm
-- Creates a grid object
local grid = Grid(map)

-- Creates a pathfinder object using Jump Point Search
local myFinder = Pathfinder(grid, 'JPS', walkable)
myFinder:setMode("ORTHOGONAL")

-- Calculates the path, and its length
   -- 8,6 is the coordinates of the center of the screen, it will always be these variables.
local path, length = myFinder:getPath(8,6, goToCol, goToRow)
if path then
	--print(('Path found! Length: %.2f'):format(length))
	for node, count in path:iter() do
		--updateGrid(node.x, node.y)
		--print(('Step: %d |x: %d| y: %d'):format(count, node.x, node.y))
		--hero.xList[count] = node:getX()
		--hero.yList[count] = node:getY()
	end
	startx = goToCol
	starty = goToRow
else
	--print("No Path")
end
end

I do currently have all my files up to date in my repo
It is all in my main.lua file.
Thanks again for all your help

Ok. I did the old fashion thing... Put the program away, wait a couple weeks and come back. Sure enough it worked. I was not rounding each of my tiles in my 2D matrix to the nearest pixel. Once I did that. It fixed it right away.


Need to add architecture option for build

build-docker.sh needs similar option to the following commit
https://github.com/CMU-cabot/cabot/commit/c3f93f254c0c9a792aa0fe63d5550ee17ae31900

fixed by pull request https://github.com/CMU-cabot/cabot-drivers/pull/17


Run e2e tests in the CI

I noticed that npm run e2e is not running in the Github actions. We should add them.

#150 makes this more of a reality


Missing hive column type during ingestion

Affected module
Ingestion Framework
Describe the bug
Hive column type obtained by reflection is omitted when ingestion is started.
There is no syntax to compare types in sqlalchemy_type enum.

col type compare source code
hive col type source code

To Reproduce
Screenshots or steps to reproduce
Expected behavior
A clear and concise description of what you expected to happen.
Version:

OS: [e.g. iOS]
Python version:
OpenMetadata version: 0.8
OpenMetadata Ingestion package version: 0.8.4

Additional context
Add any other context about the problem here.

@joswlv thanks a lot for filing the ticket. We have a fix ready. Let us know if you want to give it a try , we can publish dev package into pypi

@harshach After seeing the PR, I made a custom build and tested it. That PR didn't solve the issue.

@joswlv Thanks for the review. Can you please provide some details on what types we are missing.

@ayush-shah lets prioritize this in Milestone 2 and get it merged in


draft: add client configuration to lib initialization

#10

The generated client has a bug: it ignores authentication settings. Therefore, we must set Authorisation in CamundaLibrary as default headers

This branch requires testing all tests also with Camunda instance with enabled authentication.

Test cases are good now. When we tested Bearer Token authentication, we need to cleanup the changes:

do not pass on API_KEY and its prefix each as dictionary. Pass them on as string.


Document publishing steps

@stefandevo would you be able to create a set of instructions for how this step gets published to bitrise?
That way, other team members can do it if required.

https://github.com/cake-build/bitrise-cake-step/wiki


syntax highlighting of markdown-embedded rust code blocks with multiple tags

Is Rust Analyzer responsible for syntax highlighting of Rust code blocks embedded in Markdown files in vscode?
It would be good to support multiple tags on fenced blocks. for example
```rust
// some rust code here
```

is correctly highlighted
but
```rust,no_run
// some rust code here
```

is not highlighted.
These extra tags are useful for things like this doctest macro

Is Rust Analyzer responsible for syntax highlighting of Rust code blocks embedded in Markdown files in vscode?

Not directly, but it does parse the markdown to change eg ``` into ```rust.

It would be good to support multiple tags on fenced blocks.

Indeed

Is Rust Analyzer responsible for syntax highlighting of Rust code blocks embedded in Markdown files in vscode?

Not directly, but it does parse the markdown to change eg ``` into ```rust.

in that case, where should I be posting this issue?

The problem is probably with rust-analyzer. It should turn ```rust,no_run into the ```rust that the editor expects I think.

I don't think we do anything at all for Markdown files. That would probably the responsibility of the Markdown plugin, which I would assume is built-in in VSCode.

I don't think we do anything at all for Markdown files.

Missed that last part. I though it was a problem with doc comments.

On the other hand, they might not want to add special handling for annotations that only become relevant when you're including the file in Rust documentation. Still, maybe they can offer a solution or workaround.

I think it would make sense to ignore the part after the , even if the language is not rust.

I'd suggest reporting an issue for VSCode, since the Markdown support is built-in.


Multiply by Rational instead of Divide prevents the application of a simplification

Description

(Optional) Provide a brief summary of the issue. You don't need to repeat the title.

Steps to Reproduce
const rules = [
  '\\sqrt{x^2} -> x',
  '\\sqrt[2]{x^2} -> x',
  'x^{\\frac{1}{3}} -> \\sqrt[3]{x}',
  '\\arcsin(\\sin(x)) -> x',
  '\\arccos(\\cos(x)) -> x',
  '\\arcsin{-1} -> -\\frac{3}{6}\\pi',
  '\\arcsin{-\\frac{\\sqrt{3}}{2}} -> -\\frac{2}{6}\\pi',
  '\\arcsin{-\\frac{1}{2}} -> -\\frac{1}{6}\\pi',
  '\\arcsin{0} -> 0',
  '\\arcsin{\\frac{1}{2}} -> \\frac{1}{6}\\pi',
  '\\arcsin{\\frac{\\sqrt{3}}{2}} -> \\frac{2}{6}\\pi',
  '\\arcsin{1} -> \\frac{3}{6}\\pi',
  '\\arccos{-1} -> \\frac{6}{6}\\pi',
  '\\arccos{-\\frac{\\sqrt{3}}{2}} -> \\frac{5}{6}\\pi',
  '\\arccos{-\\frac{1}{2}} -> \\frac{4}{6}\\pi',
  '\\arccos{0} -> \\frac{3}{6}\\pi',
  '\\arccos{\\frac{1}{2}} -> \\frac{2}{6}\\pi',
  '\\arccos{\\frac{\\sqrt{3}}{2}} -> \\frac{1}{6}\\pi',
  '\\arccos{1} -> 0',
]
console.log(ce.box(["Arccos", ["Divide",["Sqrt",3],2]]).simplify({rules: rules}).toLatex())
console.log(ce.box(["Arccos", ["Multiply",["Rational",1,2],["Sqrt",3]]]).simplify({rules: rules}).toLatex())

Expected Result
\frac{\pi}{6}
\frac{\pi}{6}

Actual Result
\frac{\pi}{6}
\arccos(\frac{\sqrt{3}}{2})

Actually I don't know exactly if this worked with 0.25. Either it worked or the division was never replaced with a multiply by rational.
Compute Engine version: 0.26.4

Are all those rules necessary for the problem to occur? Is this something specific about Arccos?

All these rules are missing. So, I add them.
For this specific problem to occur, only '\\arccos{\\frac{\\sqrt{3}}{2}} -> \\frac{1}{6}\\pi' is required. Though the simplification only applies, if divide was not replaced by rational.
console.log(ce.box(["Arccos", ["Divide",["Sqrt",3],2]]).simplify().toLatex())
console.log(ce.box(["Arccos", ["Multiply",["Rational",1,2],["Sqrt",3]]]).simplify().toLatex())

rules = [
  '\\arccos{\\frac{\\sqrt{3}}{2}} -> \\frac{1}{6}\\pi',
]

console.log(ce.box(["Arccos", ["Divide",["Sqrt",3],2]]).simplify({rules: rules}).toLatex())
console.log(ce.box(["Arccos", ["Multiply",["Rational",1,2],["Sqrt",3]]]).simplify({rules: rules}).toLatex())

produces
\arccos(\frac{\sqrt{3}}{2})
\arccos(\frac{\sqrt{3}}{2})
\frac{\pi}{6}
\arccos(\frac{\sqrt{3}}{2})

expected would be
\frac{\pi}{6}
\frac{\pi}{6}
\frac{\pi}{6}
\frac{\pi}{6}

as the simplification rule should be implemented and rational should not prevent it from beeing applied.

OK, so this has nothing to do with Arccos.
To clarify, the problem is that
const pat = ce.parse('\\frac{\\sqrt{3}}{2}');

console.info(ce.box(['Divide', ['Sqrt', 3], 2]).match(pat));
// -> {}, i.e. the expression matches the pattern

but
console.info(ce.box(['Multiply', ['Rational', 1, 2], ['Sqrt', 3]]).match(pat));
// null, i.e. the expression does not match the pattern

exactly .. and for some reason, divisions get sometimes rewritten as rationals


Does this work with a CMS?

Hi this looks to only work with static images placed in the folder structure, is there anyway that it can dynamically optimize images coming in from a CMS like Contentful?

I use it with keystone v4.x and it works pretty well

How lol? I am struggling to implement it ...
On Mon, Aug 26, 2019, 2:19 PM Radu Jinga<EMAIL_ADDRESS>wrote:

I use it with keystone v4.x and it works pretty well
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cyrilwanner/next-optimized-images/issues/104?email_source=notifications&email_token=ADLJIIN5RERCWCNX47N3ZS3QGPC6FA5CNFSM4IPKHQFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EGIQQ#issuecomment-524837954,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADLJIIO67V3A6I2I7IIVP33QGPC6FANCNFSM4IPKHQFA
.

Hi @skdigital
As you discovered yourself, it only works with images which are directly located in your frontend project because they get optimized during build time and not run time.
However, when you are using contentful, you can use their image api to do most of the manipulations: https://www.contentful.com/developers/docs/references/images-api/

@cyrilwanner with the advent of getStaticProps wouldn't this now be possible?

Not out of the box with the current version, but it is a planned feature for the next major version (https://github.com/cyrilwanner/next-optimized-images/issues/120) and will be supported soon.


Taker checks for offer sanity

First we check that the maker offer's creation timestamp is not outdated. We consider a creation timestamp that is older than 10 minutes as outdated, i.e. if we don't receive a new offer from the maker within 10 minutes the taker will consider the offer as outdated when taking.
Note: We currently trust the maker to send a sane creation_timestamp.
Furthermore, the oracle event id sent by the maker is checked for sanity.
The oracle event id is considered sane if it is within the interval: [25h,23h]
We choose 25h because we always ceil to the next full hour. We d
The maker cannot go back in time, as soon as the maker is past the full hour the nex
See tests for logic details.
If the taker's sanity check fails the offer will be removed on the taker side and an error is returned that indicates that the offer is outdated.
The taker does not start a contract setaup if the sanity check fails, i.e. the taker does not send any messages to the maker if the sanity check fails.

Note: This is a a bare minimum of checks. Additionally, I would propose:
An additional creation_timestamp for the taker - this goes towards refactoring the Order to be represented differently on each side. The taker should be able to record when the Order (which is actually an Offer...) was received. We could also store this separately within taker_cfd to reason about outdated. For now I just used the maker's creation_timestamp and assume it is sane. I think eventually it would be good to check both - the taker's receival timestamp would be another layer of validation for the taker to ensure that the maker is acting sane.

I'd love to reduce the size of cfd.rs a bit more. I might try to move the Order, MakerOffers to a separate file tomorrow including the related tests. Should be possible without too much hassle. Would you consider this an improvement?

bors r+


search should allow for filtering and faceting via taxon label

To add more details:
Currently the search query returns facets on taxon_label:
https://api.monarchinitiative.org/api/search/entity/ssh?taxon=NCBITaxon%3A9606&rows=20&start=0
@nathandunn needs facets on taxon CURIE as well

OR
have search query filter by taxon_label instead of strictly taxon CURIE.


PDOException on Install

Getting this error when I try to run the /install step:
2017/12/20 00:02:41 [error] 3805#3805: *1684 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught PDOException: could not find driver in /var/www/neid-cockpit/lib/MongoLite/Database.php:42
Stack trace:
#0 /var/www/neid-cockpit/lib/MongoLite/Database.php(42): PDO->__construct('sqlite:/var/www...', NULL, NULL, Array)
#1 /var/www/neid-cockpit/lib/MongoLite/Client.php(75): MongoLite\Database->__construct('/var/www/neid-c...', Array)
#2 /var/www/neid-cockpit/lib/MongoLite/Client.php(63): MongoLite\Client->selectDB('cockpit')
#3 /var/www/neid-cockpit/lib/MongoHybrid/MongoLite.php(27): MongoLite\Client->selectCollection('cockpit', 'webhooks')
#4 /var/www/neid-cockpit/lib/MongoHybrid/MongoLite.php(47): MongoHybrid\MongoLite->getCollection('webhooks')
#5 [internal function]: MongoHybrid\MongoLite->find('cockpit/webhook...')
#6 /var/www/neid-cockpit/lib/MongoHybrid/Client.php(420): call_user_func_array(Array, Array)
#7 /var/www/neid-cockpit/modules/Cockpit/webhooks.php(8): MongoHybrid\Client->__call('find', Array)
#8 /var/www/neid-cockpit/modules/Cockpit/bootstrap.php(475" while reading response header from upstream, client: <IP_ADDRESS>, server: brewcitydigital.com, request: "GET /neid-cockpit/install/ HTTP/1.1", upstream: "fastcgi://unix:/run/php/php7.0-fpm.sock:", host: "www.brewcitydigital.com"

Any help on this would be appreciated.

Found the fix...
Needed to install the proper version of sqllite
sudo apt-get install php7.0-sqlite3

then restart php
sudo systemctl restart php7.0-fpm

also see issue 166 for initial issue ... closing issue

I have the same issue on archlinux, but cant seem to fix it by installing this

i know this is a old post but i was searching online and wanted to post this for anybody else trying to troubleshoot cockpit on arch linux. use a aur helper such as yay and install cockpit-machines through there that just got mine working properly for the virtual machines section. you can also install the other modules this way as well.


modification in search option

In this project search option is not working. If we want to seach anything and get the result it will be better

@mandalriddhi plz create this issue according to the issue template that I have in the project(click on new issue and choose a template and write according to that)

@mandalriddhi closing this as a similar one is been assigned to you


CameraKitCameraScreen ignores laserColor and frameColor

Issue Description
laserColor and frameColor are ignored. The frame stays black and the laser stays white.
Steps to Reproduce / Code Snippets / Screenshots
Standard from the README (QR code). showFrame={true}

Environment

React Native Navigation version: N/A
React Native version: 0.61.2
Platform(s) (iOS, Android, or both?): Both
Device info (Simulator/Device? OS version? Debug/Release?): Device (iPhone 11 Pro, iOS 13.1.3)

Hi @RWOverdijk  I have checked native code in iOS that does not contain the laserColor property.


No shadow

There is no shadow like the picture you give

Shadow is cool, but this theme does not comes with shadow. I will take new screenshots without shadows and replace current ones. Thank you for your reminder.
Maybe it's slightly possible that I will add a variant with shadow in the furture.


Example of transformation of geomodel layer data from POZO

@andreabrambilla Shows code for transforming POZO data to low level format used for surfaces in intersection

I was expecting it to be much worse, this looks pretty straightforward. Should we consider adding also a wellbore path here? Just to see how painful it will be to make sure things are aligned. Or shall we leave that to a separate issue?

If we could get a wellbore path in whatever format they are using we could add that as well, I think that would be useful.

I wrote them a couple of days ago, waiting for an answer

This PR has been laying here forever. Should we just close it @HavardNJ?

Yes, I don't think there is need for it.


[Question] Is it possible to port this to iOS?

Is it possible to port this to iOS?

What do you mean? The code is not working? Is iOS supported by Julia?

I am closing this issue for now, because it looks like you are asking if we can port a whole project to another language.

Hey buddy, how're things going?
Thanks for the response!
I haven't tested the code, but I was just wondering out loud (maybe you had past experience, etc'). I'm an iOS developer but It's way out of my field. It could be fun to try to run these scripts in iOS tho.
Are you available for freelance work?

I am not interested, and the issue tracker of our project is not supposed to contain this kind of conversation. Please stop with the spam.


RPS decrease when most of the requests return connection timeout

I'm running boomer with 1 vCPU, 4Gb memory, rps set to 1000, run time 120 seconds.
In case most of the requests return connection timeout, after 120 seconds the total requests fired is only about 30% of 1000*120.
Seem like many requests are pending due to wait for timeout.

I can't address this issue unless you can provide the code of your tasks to reproduce it.


[NSE-320] Add build option to enable unsafe Arrow allocator

Within this patch, use "mvn -P arrow-unsafe ..."  to enable compile/package native SQL code with unsafe Arrow allocator.

@zhztheplayer rebase?

@github-actions ram-usage-test

@zhouyuan Rebased. Are we good to merge?


Train

Problem
The codebase did not support model training after the data has been preprocessed.
Solution
Implement model training, including Lasso, ANN, RF, and XGBoost. Basic evaluation metrics have been implemented as well. More sophisticated predictor processing e.g. specifying temporal predictors like DOY, daily sin/cos, etc. will be implemented in a future PR.
Tests
python main.py train --sites NZKop --models [lasso,rf] --predictors_paths train/predictors.txt

Hi Jeremy,
I'll have time to look at the code later tonight. I am sending a copy of
the preprocessed data on my end in case you want to have a look.
https://hkuhk-my.sharepoint.com/:f:/g/personal/yulunzho_hku_hk/EsJKSfO3PUFMiWdwsAOm1w4BNAx2ziaLftG7QT07uTD6PQ?e=RzIcmR
X.isna().any() - in my case, X should be a 2-dimentional dataframe, so the
result is not a bool but a series of bools.
Chris
On Tue, May 25, 2021 at 12:50 PM Jeremy Irvin @.***>
wrote:

@.**** commented on this pull request.
In models/base.py
https://github.com/stanfordmlgroup/methane-gapfill-ml/pull/3#discussion_r638451443
:

@@ -13,7 +15,12 @@ def init(self, cv=5, n_iter=20):

 def fit(self, X, y):
     """Train on a training set and select optimal hyperparameters."""

   # TODO: Impute missing predictors if necessary and set imputer here.

At this point, there should be no NaN values in y. All of the rows with
NaN y values (I.e. all of the rows with CH4 we're trying to gapfill) should
be filtered out by this point:
https://github.com/stanfordmlgroup/methane-gapfill-ml/blob/master/preprocess/preprocess.py#L60-L61
https://github.com/stanfordmlgroup/methane-gapfill-ml/blob/master/preprocess/preprocess.py#L83-L99
https://github.com/stanfordmlgroup/methane-gapfill-ml/blob/master/preprocess/preprocess.py#L105-L119
Are you seeing an error with NaN values in y?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stanfordmlgroup/methane-gapfill-ml/pull/3#discussion_r638451443,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABX4EUHSXM4LORWWS2F5B5DTPMUBZANCNFSM44IBNK3A
.

--
Yulun Zhou (Chris)
Assistant Professor in Urban Data Science
Faculty of Architecture, The University of Hong Kong
P: +852 3917-1785 | E: @.
A: 810 Knowles Building, Pokfulam, Hong Kong
Recent Publications
0) Vector-based Pedestrian Navigation in Cities
https://arxiv.org/abs/2103.07104?context=stat.AP - arxiv

Climate-Conscious Urban Growth Planning Mitigates Urban Warming:
Shenzhen as a Case Study https://pubs.acs.org/doi/10.1021/acs.est.9b01645 -
Environmental Science & Technology (Nature Index)
EMMA: Development of An Low-Cost, Real-Time Indoor Air Pollutant Sensor
Platform
https://www.sciencedirect.com/science/article/pii/S0269749118319584 -
Environmental Pollution
Evaluating and Characterizing Urban Vibrancy using Multi-Source Spatial
Big Data https://journals.sagepub.com/doi/abs/10.1177/2399808319828730 -
Environment and Planning B: Urban Analytics and City Science
SinoGrids: A Practice of Open Urban Data in China
https://www.tandfonline.com/doi/abs/10.1080/15230406.2015.1129914 -
Cartography and Geographic Information Science
Model Evaluation of High-resolution Urban Climate Simulation
https://www.geosci-model-dev-discuss.net/gmd-2018-220/ Geoscientific
Model Development

Sorry please use this link instead.
https://hkuhk-my.sharepoint.com/:f:/g/personal/yulunzho_hku_hk/EroNxhxdZwpAl1EVsgBhqzEB3sn0BLseJPf_TzHKfuqnAw?e=2bxbfB
On Tue, May 25, 2021 at 12:55 PM Yulun Zhou (Chris) @.***>
wrote:

Hi Jeremy,
I'll have time to look at the code later tonight. I am sending a copy of
the preprocessed data on my end in case you want to have a look.
https://hkuhk-my.sharepoint.com/:f:/g/personal/yulunzho_hku_hk/EsJKSfO3PUFMiWdwsAOm1w4BNAx2ziaLftG7QT07uTD6PQ?e=RzIcmR
X.isna().any() - in my case, X should be a 2-dimentional dataframe, so the
result is not a bool but a series of bools.
Chris
On Tue, May 25, 2021 at 12:50 PM Jeremy Irvin @.***>
wrote:

@.**** commented on this pull request.
In models/base.py
https://github.com/stanfordmlgroup/methane-gapfill-ml/pull/3#discussion_r638451443
:

@@ -13,7 +15,12 @@ def init(self, cv=5, n_iter=20):

 def fit(self, X, y):
     """Train on a training set and select optimal hyperparameters."""

   # TODO: Impute missing predictors if necessary and set imputer here.

At this point, there should be no NaN values in y. All of the rows with
NaN y values (I.e. all of the rows with CH4 we're trying to gapfill) should
be filtered out by this point:
https://github.com/stanfordmlgroup/methane-gapfill-ml/blob/master/preprocess/preprocess.py#L60-L61
https://github.com/stanfordmlgroup/methane-gapfill-ml/blob/master/preprocess/preprocess.py#L83-L99
https://github.com/stanfordmlgroup/methane-gapfill-ml/blob/master/preprocess/preprocess.py#L105-L119
Are you seeing an error with NaN values in y?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stanfordmlgroup/methane-gapfill-ml/pull/3#discussion_r638451443,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABX4EUHSXM4LORWWS2F5B5DTPMUBZANCNFSM44IBNK3A
.

--
Yulun Zhou (Chris)
Assistant Professor in Urban Data Science
Faculty of Architecture, The University of Hong Kong
P: +852 3917-1785 | E: @.
A: 810 Knowles Building, Pokfulam, Hong Kong
Recent Publications
0) Vector-based Pedestrian Navigation in Cities
https://arxiv.org/abs/2103.07104?context=stat.AP - arxiv

Climate-Conscious Urban Growth Planning Mitigates Urban Warming:
Shenzhen as a Case Study
https://pubs.acs.org/doi/10.1021/acs.est.9b01645 - Environmental
Science & Technology (Nature Index)
EMMA: Development of An Low-Cost, Real-Time Indoor Air Pollutant
Sensor Platform
https://www.sciencedirect.com/science/article/pii/S0269749118319584 -
Environmental Pollution
Evaluating and Characterizing Urban Vibrancy using Multi-Source
Spatial Big Data
https://journals.sagepub.com/doi/abs/10.1177/2399808319828730 -
Environment and Planning B: Urban Analytics and City Science
SinoGrids: A Practice of Open Urban Data in China
https://www.tandfonline.com/doi/abs/10.1080/15230406.2015.1129914 -
Cartography and Geographic Information Science
Model Evaluation of High-resolution Urban Climate Simulation
https://www.geosci-model-dev-discuss.net/gmd-2018-220/ Geoscientific
Model Development

--
Yulun Zhou (Chris)
Assistant Professor in Urban Data Science
Faculty of Architecture, The University of Hong Kong
P: +852 3917-1785 | E: @.
A: 810 Knowles Building, Pokfulam, Hong Kong
Recent Publications
0) Vector-based Pedestrian Navigation in Cities
https://arxiv.org/abs/2103.07104?context=stat.AP - arxiv

Climate-Conscious Urban Growth Planning Mitigates Urban Warming:
Shenzhen as a Case Study https://pubs.acs.org/doi/10.1021/acs.est.9b01645 -
Environmental Science & Technology (Nature Index)
EMMA: Development of An Low-Cost, Real-Time Indoor Air Pollutant Sensor
Platform
https://www.sciencedirect.com/science/article/pii/S0269749118319584 -
Environmental Pollution
Evaluating and Characterizing Urban Vibrancy using Multi-Source Spatial
Big Data https://journals.sagepub.com/doi/abs/10.1177/2399808319828730 -
Environment and Planning B: Urban Analytics and City Science
SinoGrids: A Practice of Open Urban Data in China
https://www.tandfonline.com/doi/abs/10.1080/15230406.2015.1129914 -
Cartography and Geographic Information Science
Model Evaluation of High-resolution Urban Climate Simulation
https://www.geosci-model-dev-discuss.net/gmd-2018-220/ Geoscientific
Model Development

Thanks for sharing the data - you're absolutely right! This uncovered a bug in the preprocessing that I'll push a fix for, along with your suggestion about the X.isna().any().any().

Is this good to go now @ylzhouchris ? I tested on my end with your data (rerunning preprocessing and modeling) and it seems to finish without error, but want to make sure you're not running into any errors still.

Hi J,
Four additional minors and we're good to go.
Chris
On Thu, May 27, 2021 at 8:37 AM Jeremy Irvin @.***>
wrote:

Is this good to go now @ylzhouchris https://github.com/ylzhouchris ? I
tested on my end with your data (rerunning preprocessing and modeling) and
it seems to finish without error, but want to make sure you're not running
into any errors still.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stanfordmlgroup/methane-gapfill-ml/pull/3#issuecomment-849213473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABX4EUAY7AHTKWA7MT3CNADTPWH4LANCNFSM44IBNK3A
.

--
Yulun Zhou (Chris)
Assistant Professor in Urban Data Science
Faculty of Architecture, The University of Hong Kong
P: +852 3917-1785 | E: @.
A: 810 Knowles Building, Pokfulam, Hong Kong
Recent Publications
0) Vector-based Pedestrian Navigation in Cities
https://arxiv.org/abs/2103.07104?context=stat.AP - arxiv

Climate-Conscious Urban Growth Planning Mitigates Urban Warming:
Shenzhen as a Case Study https://pubs.acs.org/doi/10.1021/acs.est.9b01645 -
Environmental Science & Technology (Nature Index)
EMMA: Development of An Low-Cost, Real-Time Indoor Air Pollutant Sensor
Platform
https://www.sciencedirect.com/science/article/pii/S0269749118319584 -
Environmental Pollution
Evaluating and Characterizing Urban Vibrancy using Multi-Source Spatial
Big Data https://journals.sagepub.com/doi/abs/10.1177/2399808319828730 -
Environment and Planning B: Urban Analytics and City Science
SinoGrids: A Practice of Open Urban Data in China
https://www.tandfonline.com/doi/abs/10.1080/15230406.2015.1129914 -
Cartography and Geographic Information Science
Model Evaluation of High-resolution Urban Climate Simulation
https://www.geosci-model-dev-discuss.net/gmd-2018-220/ Geoscientific
Model Development

I think we are good to proceed.
Chris

That sounds perfect.
On Mon, May 31, 2021 at 1:18 PM Jeremy Irvin @.***>
wrote:

@.**** commented on this pull request.
In train/train.py
https://github.com/stanfordmlgroup/methane-gapfill-ml/pull/3#discussion_r642215284
:

def train(
sites,
models,

   predictors

   predictors=None,

   predictors_paths=None,

   log_metrics=["pr2", "nmae"],

   inner_cv=5,

   n_iter=20,

   overwrite_existing_models=False

Ah this is a great point. I implemented a small fix which checks arguments
saved to file, and asks the user to specify overwrite_existing_models=True
if the supplied arguments are different than the ones saved to file. What
do you think @ylzhouchris https://github.com/ylzhouchris ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stanfordmlgroup/methane-gapfill-ml/pull/3#discussion_r642215284,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABX4EUAY3JOJPR6ZPALUVSDTQMLZ3ANCNFSM44IBNK3A
.

--
Yulun Zhou (Chris)
Assistant Professor in Urban Data Science
Faculty of Architecture, The University of Hong Kong
P: +852 3917-1785 | E: @.
A: 810 Knowles Building, Pokfulam, Hong Kong
Recent Publications
0) Vector-based Pedestrian Navigation in Cities
https://arxiv.org/abs/2103.07104?context=stat.AP - arxiv

Climate-Conscious Urban Growth Planning Mitigates Urban Warming:
Shenzhen as a Case Study https://pubs.acs.org/doi/10.1021/acs.est.9b01645 -
Environmental Science & Technology (Nature Index)
EMMA: Development of An Low-Cost, Real-Time Indoor Air Pollutant Sensor
Platform
https://www.sciencedirect.com/science/article/pii/S0269749118319584 -
Environmental Pollution
Evaluating and Characterizing Urban Vibrancy using Multi-Source Spatial
Big Data https://journals.sagepub.com/doi/abs/10.1177/2399808319828730 -
Environment and Planning B: Urban Analytics and City Science
SinoGrids: A Practice of Open Urban Data in China
https://www.tandfonline.com/doi/abs/10.1080/15230406.2015.1129914 -
Cartography and Geographic Information Science
Model Evaluation of High-resolution Urban Climate Simulation
https://www.geosci-model-dev-discuss.net/gmd-2018-220/ Geoscientific
Model Development


Update InputBuilder.cs

Left-Alt should not be Extended

If possible, remove the line entirely in your PR — there's no point in keeping it as a comment.


Support for SPM

PromiseKit now has SPM support. I think this library should add it as well. Especially now that SPM supports iOS.

yes it would be good to add support for SPM.

See PR #6

Hey! Still nothing?


CMake Lexer Treats Empty Comments as Errors

(Original issue 875 created by j3lamp on 2013-06-01T18:28:42.521727+00:00)
Empty comments, that is '#' followed by nothing are treated as errors when they should be comments.

(Original issue 875 last updated on 2014-01-09T16:36:36.424265+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by j3lamp on 2013-06-01T19:18:49.818750+00:00)
Fix provided in Pull request #206.

(Original comment by birkenfeld on 2014-01-09T16:36:36.441814+00:00)
And merged.


Allow user to change the keyboard layout from the web UI

Currently, users who want to use a different keyboard layout have to do a full reinstall. It would be better to have the backend simply store it as a setting that's configurable at runtime.
We should have a settings screen in the web UI that allows changes like this.

Obsolete as of #355


Add Storm Engine - game engine for Sea Dogs / Pirates of the Caribbean

Thanks for the addition.

How often do you automatically update auto generated content?
I need to do something else to get it on https://trilarion.github.io/opensourcegames/ ?

Sorry, I was changing the website part and that part is not updated currently. It will in a short time, you don't need to do anything.

Thanks!


Cross-domain script errors are not captured in safari

Description
Cross-domain script errors are not captured in safari, even with CORS settings.
Is there any workaround for this issue?
https://stackoverflow.com/questions/45844565/script-error-errors-in-window-onerror-in-safari-only

Hi @aki77,
As you've discovered this is due to a longstanding issue in Safari. There are some further related bug reports here:
https://bugs.webkit.org/show_bug.cgi?id=132945
https://bugs.webkit.org/show_bug.cgi?id=151548
Unfortunately there's no workaround for this that we are aware of.

Thank you for replying.

A description of the safari bug in the documentation would be helpful.
https://docs.bugsnag.com/platforms/javascript/cors/

The following workaround was implemented.
It is better than no error notification.
const BugsnagPluginAppleCrossOriginError: Plugin = {
  load(client): void {
    if (!window.navigator.vendor.toLowerCase().includes('apple')) {
      return
    }

    const prevOnError = window.onerror
    window.onerror = (messageOrEvent, url, lineNo, charNo, error) => {
      if (lineNo === 0 && typeof messageOrEvent === 'string' && /Script error\.?/.test(messageOrEvent)) {
        const handledState = { severity: 'error', unhandled: true, severityReason: { type: 'unhandledException' } }
        const event = client.Event.create(new Error(messageOrEvent), true, handledState, 'apple crossorigin onerror', 1)
        client._notify(event)
      }

      prevOnError?.apply(this, [messageOrEvent, url, lineNo, charNo, error])
    }
  },
}

Hi @aki77, thanks for the suggestion about adding it to the docs. We will give it some consideration and let you know.

Thanks!

Hi @aki77 , just wanted to let you know that the docs have now been updated regarding the Safari bug!

@Cga95 Thanks!


Xml highlighting not work

I used this to highlight it, but i get white font color.
{% highlight xml %} <uses-permission android:name="android.permission.SEND_SMS"/> {% endhighlight %}

You can use like that.


Trapcraft Compatibility

Trapcraft v2.4.3a
Guild & Commerce v1.2.7a
The magnetic chest is able to be opened by anyone. When opening it says "container.magnetic_chest" at the top of the inventory window.

This appears to be a desynchronization between the client and the server. As you helped me test, the contents of the chest do not appear to the unauthorized player even though the gui has opened.  I will work on resolving this desynchronization to improve overt behavior.


Error: Library cublas64_12.dll is not found or cannot be loaded

hi guys, have this error when start generate subtitle file
"Error: Library cublas64_12.dll is not found or cannot be loaded"
win 11 rtx 3090

Mismo error
Error transcribing file on line Library cublas64_12.dll is not found or cannot be loaded
win 11 rtx 4060 TI

Hi. Like #97, this is fixed in #99.
This problem is caused by an incompatible version of faster-whisper with CUDA versions below 12.0,

trying latest version of the web-ui ( removing venv folder and run install.bat again )

Or just

# After activating the venv
pip uninstall faster-whisper
pip install faster-whisper==0.10.1

Using the version of faster-whisper==0.10.1 solves this problem.

Thanks, working

Correcto, solucionado, gracias.


Add Additional Date Fields to Evaluation Queue Table

Overview
Current Evaluation Process Steps

The ECMPS UI calls the [camd-services]/evaluate endpoint.
The [camd-services]/evaluate endpoint creates a EVALUATION_SET row for the call and populates EVALUATION_QUEUE with a child row for the MP if the payload's submitMonPlan (misnamed) is true, and a row for each QAT, QCE, TEE, and EM in the payload.

EVAL_STATUS_CD in the EVALUATION_QUEUE rows are set to INQ.
STATUS_CD in the EVALUATION_QUEUE rows are set to the following:

For MP, QUEUED.
For QAT, QCE and TEE, PENDING if submitMonPlan (misnamed) is true, otherwise QUEUED.
For EM, PENDING if submitMonPlan (misnamed) is true or QAT, QCE or TEE are part of the evaluation set, otherwise QUEUED.

SUBMITTED_ON in the EVALUATION_QUEUE rows are set to the current time.
Other column values are initialized.

The "Evaluation Queue" Quartz job does the following:

Determine the capacity to start another evaluation and proceeds if the capacity and another 'QUEUED' EVALUATION_QUEUE row exists, and proceeds with additional steps if both are true.
Creates a Quartz job for the next EVALUATION_QUEUE row ordered by MPs, QAs and EMs and then by SUBMITTED_ON in each group.
The "Evaluation Queue" Quartz job does the following:

Sets the EVALUATION_QUEUE row's STATUS_CD to 'WIP'.
Performs the evaluation processing for each file type.

MP

Updates the MONITOR_PLAN EVAL_STATUS_CD to "WIP".
Performs the MP evaluation.
Updates the MONITOR_PLAN EVAL_STATUS_CD based on the Check Session for the MP.
Updates the STATUS_CD to "QUEUED" for any EVALUATION_QUEUE for the SUBMISSION_SET_ID with a PROCESS_CD of "QA".
If no EVALUATION_QUEUE for the SUBMISSION_SET_ID with a PROCESS_CD of "QA" existed, updates the STATUS_CD to "QUEUED" for any EVALUATION_QUEUE for the SUBMISSION_SET_ID with a PROCESS_CD of "EM" and a STATUS_CD of "PENDING".

QA (For one of QAT, QCE or TEE based on which one of testSumId, qaCertId or testExtensionExemption is populated)

Updates the TEST_SUMMARY, QA_CERT_EVENT or TEST_EXTENSION_EXEMPTION EVAL_STATUS_CD to "WIP".
Performs the QAT, QCE or TEE evaluation.
Updates the TEST_SUMMARY, QA_CERT_EVENT or TEST_EXTENSION_EXEMPTION EVAL_STATUS_CD based on the Check Session for the QAT, QCE or TEE.

EM

Resets EVAL_STATUS to "PENDING" in EVALUATION_QUEUE for the EM if an EM EVALUATION_QUEUE row exist for the MON_PLAN_ID and a prior reporting period.  No additional processing occurs.
Updates the EMISSION_EVALUATION EVAL_STATUS_CD to "WIP".
Performs the EM evaluation.
Updates the EMISSION_EVALUATION EVAL_STATUS_CD based on the Check Session for the EM.
Performs refreshes needed based on the evaluation occurring.
Updates the the EVALUATION_QUEUE EVAL_STATUS_CD to "QUEUED" for the EM EVALUATION_QUEUE row for the MP with the earliest reporting period.

Sets the EVALUATION_QUEUE row's STATUS_CD to 'COMPLETE'.

CAMDECMPSAUX Database Changes

Table
Column
Type
Update

EVALUATION_QUEUE
QUEUED_TIME
Timestamp w/o TZ
Renamed from SUBMITTED_ON

EVALUATION_QUEUE
STARTED_TIME
Timestamp w/o TZ
Add

EVALUATION_QUEUE
COMPLETED_TIME
Timestamp w/o TZ
Add

EVALUATION_QUEUE
NOTE
Timestamp w/o TZ
Add

EVALUATION_QUEUE
NOTE_TIME
varchar(1000)
Add

Notes

The NOTE and NOTE_TIME columns are populated when an issue occurred and the submission was not completed.

New Emission Process Steps

The ECMPS UI calls the [camd-services]/evaluate endpoint.
The [camd-services]/evaluate endpoint creates a EVALUATION_SET row for the call and populates EVALUATION_QUEUE with a child row for the MP if the payload's submitMonPlan (misnamed) is true, and a row for each QAT, QCE, TEE, and EM in the payload.

EVAL_STATUS_CD in the EVALUATION_QUEUE rows are set to INQ.
STATUS_CD in the EVALUATION_QUEUE rows are set to the following:

For MP, QUEUED.
For QAT, QCE and TEE, PENDING if submitMonPlan (misnamed) is true, otherwise QUEUED.
For EM, PENDING if submitMonPlan (misnamed) is true or QAT, QCE or TEE are part of the evaluation set, otherwise QUEUED.

QUEUED_TIME in the EVALUATION_QUEUE rows are set to the current time.
Other column values are initialized.

The "Evaluation Queue" Quartz job does the following:

Determine the capacity to start another evaluation and proceeds if the capacity and another 'QUEUED' EVALUATION_QUEUE row exists, and proceeds with additional steps if both are true.
Creates a Quartz job for the next EVALUATION_QUEUE row ordered by MPs, QAs and EMs and then by SUBMITTED_ON in each group.
The "Evaluation Queue" Quartz job does the following:

Sets the following EVALUATION_QUEUE row's values.

STATUS_CD to 'WIP'.
STARTED_TIME to the current time.

Performs the evaluation processing for each file type.

MP

Updates the MONITOR_PLAN EVAL_STATUS_CD to "WIP".
Performs the MP evaluation.
Updates the MONITOR_PLAN EVAL_STATUS_CD based on the Check Session for the MP.
Updates the STATUS_CD to "QUEUED" for any EVALUATION_QUEUE for the SUBMISSION_SET_ID with a PROCESS_CD of "QA".
If no EVALUATION_QUEUE for the SUBMISSION_SET_ID with a PROCESS_CD of "QA" existed, updates the STATUS_CD to "QUEUED" for any EVALUATION_QUEUE for the SUBMISSION_SET_ID with a PROCESS_CD of "EM" and a STATUS_CD of "PENDING".

QA (For one of QAT, QCE or TEE based on which one of testSumId, qaCertId or testExtensionExemption is populated)

Updates the TEST_SUMMARY, QA_CERT_EVENT or TEST_EXTENSION_EXEMPTION EVAL_STATUS_CD to "WIP".
Performs the QAT, QCE or TEE evaluation.
Updates the TEST_SUMMARY, QA_CERT_EVENT or TEST_EXTENSION_EXEMPTION EVAL_STATUS_CD based on the Check Session for the QAT, QCE or TEE.

EM

Resets EVAL_STATUS to "PENDING" in EVALUATION_QUEUE for the EM if an EM EVALUATION_QUEUE row exist for the MON_PLAN_ID and a prior reporting period.  No additional processing occurs.
Updates the EMISSION_EVALUATION EVAL_STATUS_CD to "WIP".
Performs the EM evaluation.
Updates the EMISSION_EVALUATION EVAL_STATUS_CD based on the Check Session for the EM.
Performs refreshes needed based on the evaluation occurring.
Updates the the EVALUATION_QUEUE EVAL_STATUS_CD to "QUEUED" for the EM EVALUATION_QUEUE row for the MP with the earliest reporting period.

If the evaluation completed successfully, sets the following EVALUATION_QUEUE row's values.

STATUS_CD to 'COMPLETE'
COMPLETED_TIME to the current time.

If the evaluation did not complete successfully, sets the following EVALUATION_QUEUE row's values.

NOTE with a description of the problem.
NOTE_TIME to the current time.

Acceptance Criteria

The EVALUATION_QUEUE QUEUED_TIME, STARTED_TIME and COMPLETED_TIME are updated, and NOTE and NOTE_TIME are null for any successfully evaluated file of the following:

MP
QAT
QCE
TEE
EM

The EVALUATION_QUEUE QUEUED_TIME, STARTED_TIME,  NOTE and NOTE_TIMEare updated, and COMPLETED_TIME is null for any unsuccessfully evaluated file of the following:

MP
QAT
QCE
TEE
EM

Evaluation Payload JSON Schema
For [camd-services]/evaluate endpoint
{
  "items": [
    {
      "monPlanId": "string",
      "submitMonPlan": true,
      "testSumIds": [
        "string"
      ],
      "qceIds": [
        "string"
      ],
      "teeIds": [
        "string"
      ],
      "emissionsReportingPeriods": [
        "string"
      ],
      "matsBulkFiles": [
        0
      ]
    }
  ],
  "userId": "string",
  "userEmail": "string"
}

Additional Description Changes

Add unique job and trigger naming to enable multiple instances of the Quartz job to run.
Remove the 5 second delay.

When attempting to run an evaluation, it fails with Critical Errors and the following error is shown in the generated report:

Evaluation is old or expired and error data is no longer available

Additionally, when selecting "Download Report", no errors are listed below the evaluation summary.
This behavior has been confirmed in the Dev, Test, and Perf environments

The QUEUED_TIME, STARTED_TIME and COMPLETED_TIME columns are updated, and NOTE and NOTE_TIME are null in the  EVALUATION_QUEUE table for evaluations of the following data types:

[ ] MP
[ ] QA
[ ] QCE
[ ] TEE
[ ] EM

The QUEUED_TIME, STARTED_TIME, NOTE and NOTE_TIME are updated, and COMPLETED_TIME is null in the EVALUATION_QUEUE table for evaluations of the following data types:

[ ] MP
[ ] QA
[ ] QCE
[ ] TEE
[ ] EM

@maxdiebold-erg The started_time and completed_time still have the incorrect time zone issue in the evaluation_queue table.

@lgiannini1 The time zone issues in the CAMDECMPSAUX.EVALUATION_QUEUE table have been fixed.

@lgiannini1 You can use the following steps to test the error flow (this example uses Barry 1, 2, CS0AAN):

Evaluate the MP without evaluating any QA or EM records.
Use the following query to re-run the evaluation with a process code that doesn't exist for the evaluation set:

UPDATE
    camdecmpsaux.evaluation_queue
SET
    eval_status_cd = 'INQ',
    status_cd = 'QUEUED',
    process_cd = 'QA'
WHERE
    evaluation_id = (
        SELECT
            eq.evaluation_id
        FROM
            camdecmpsaux.evaluation_queue eq
            JOIN camdecmpsaux.evaluation_set es USING (evaluation_set_id)
        WHERE
            es.fac_name = 'Barry'
            AND es.configuration = '1, 2, CS0AAN'
        ORDER BY
            eq.queued_time DESC
        LIMIT 1);

Verified the issue is fixed after tested on Cross unit 1.

On dev, The COMPLETED_TIME is null for failed evaluations, so it seems like something is different between the dev and test environments.

On dev, The COMPLETED_TIME is null for failed evaluations, so it seems like something is different between the dev and test environments.

Agreed!

@maxdiebold-erg Can you take a look and determine if this is a db deployment issue or something else?

I don't think there is an issue here. You can see in @ntknguyen's example that the completed_time is before the queued_time: this is due to the direct row manipulation in the method I recommended to force a failure. We could explicitly set completed_time to null when a failure occurs, but in the normal flow it will already be empty.

I don't think there is an issue here. You can see in @ntknguyen's example that the completed_time is before the started_time: this is due to the direct row manipulation in the method I recommended to force a failure. We could explicitly set completed_time to null when a failure occurs, but in the normal flow it will already be empty.

Thanks @maxdiebold-erg. @ntknguyen , let us know if you have additional questions or if you're ready to verify this ticket and update the status from "Ready for UAT," to "Ready for Deployment."


W505 not reported AND stripped

W505 does not trigger for a multiline docstring that is too long, the relevant noqa added for flake8 gets stripped off and it seems impossible to apply any noqa on multiline docstrings as a whole. This is the code I noticed it on after adding Ruff to the project. Either my ruff.toml is causing it to be skipped through some other matching rule, or I've hit a bug.
Minimal ruff.toml:
select = ["D", "E", "F", "RUF", "W"]
line-length = 85
[pycodestyle]
max-doc-length = 85

Code example:
from typing import Union

def somefunc(
    a: int, b: float, c: str,
    d: Union[list, dict], e: bool
) -> int:
    """
    This docstring will go out of bounds

    a: sxedc5rfvtgbyhnujmi8k,ol.p;/123456789/*-+.
       sxedc5rfvtgbyhnujmi8k,ol.p;/123456789/*-+.sxedc5rfvtgbyhnujmi8k,ol.p;/123456789/*-+hflqkehdb
    """

This happens both with and without --isolated, running only ruff . --fix
❯ ruff --version
ruff 0.0.287
In case I missed something, the full ruff config used is attached with a suffix to make GH accept the upload.
ruff.toml.txt
Temporary solution for me is to mark RUF100 as unfixable so it doesn't break flake8 runs upon re-adding the noqa directives, as I use flake8 plugins not (yet) implemented in Ruff, like rst-docstrings.

Hi!
The reason a violation for W505 is not raised there is covered in the documentation
https://github.com/astral-sh/ruff/blob/005e21a139ac2518887548a529688daaded15a54/crates/ruff/src/rules/pycodestyle/rules/doc_line_too_long.rs#L21-L25
The proper way to use noqa for a multiline docstring is discussed in #7011

The old code had the noqa: W505 behind the closing quotes on the docstring, which was stripped. And unless there is some special handling for the rST \link directive https://example.com``, it should definitely be seeing whitespace in the line. I'll edit the example to include said directive, as I can see this being somewhat faulty for an example

Yeah if W505 is not raised then the noqa comment will be removed.
It is not being raised because of the URL. If you replace the URL with "x"s then the violation is raised as you'd expect. We do not use comprehensive validation for a URL
https://github.com/astral-sh/ruff/blob/e6158706590fd31ac6388ddc17495480c7fd0265/crates/ruff/src/rules/pycodestyle/helpers.rs#L97

I think this is working as intended.


Traefik creates the root key in etcd but cannot access it after that

What version of Traefik are you using (traefik version)?
traefik:v1.1.2
traefik:v1.0.3
What is your environment & configuration (arguments, toml...)?
[etcd]
endpoint = "etcd:2379"
watch = true
prefix = "/traefik"

What did you do?
this is the script I used to create the etcd and traefik containers
docker stop `docker ps -a | grep traefik| awk '{print $1}'`;
docker stop `docker ps -a | grep etcd| awk '{print $1}'`;

docker rm `docker ps -a | grep traefik| awk '{print $1}'`;
docker rm `docker ps -a | grep etcd| awk '{print $1}'`;

docker run --name etcd -p 2379:2379 -p 4001:4001 -p 7001:7001 -p 2380:2380 -d -t elcolio/etcd -name etcd0 \
           --advertise-client-urls 'http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001' \
           --listen-client-urls 'http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4001' \
           --listen-peer-urls http://<IP_ADDRESS>:2380;

docker run \
        --link 'etcd:etcd' \
        --name traefik-config \
        -d \
        -v $PWD/traefik.toml:/etc/traefik/traefik.toml \
        traefik:v1.0.3 storeconfig --logLevel=DEBUG;

docker run \
        --link 'etcd:etcd' \
        --name traefik \
        -d \
        -p 8080:8080 \
        -p 80:80 \
        -v $PWD/traefik.toml:/etc/traefik/traefik.toml \
        traefik:v1.0.3 --logLevel=DEBUG;

docker logs traefik;

What did you expect to see?
Not the following errors:
time="2017-01-11T16:29:01Z" level=info msg="Preparing server http &{Network: Address::80 TLS:<nil> Redirect:<nil>}"
time="2017-01-11T16:29:01Z" level=info msg="Starting provider *provider.Etcd {\"Watch\":true,\"Filename\":\"\",\"Constraints\":null,\"Endpoint\":\"etcd:2379\",\"Prefix\":\"/traefik\",\"TLS\":null}"
time="2017-01-11T16:29:01Z" level=info msg="Starting server on :80"
time="2017-01-11T16:29:02Z" level=warning msg="Error getting key /traefik/alias Key not found in store, setting default /traefik"
time="2017-01-11T16:29:02Z" level=error msg="KV connection error: watchtree channel closed, retrying in 488.612134ms"
time="2017-01-11T16:29:02Z" level=error msg="Error getting keys /traefik/frontends/ Key not found in store "
time="2017-01-11T16:29:02Z" level=error msg="Error getting keys /traefik/backends/ Key not found in store "
time="2017-01-11T16:29:02Z" level=debug msg="Configuration received from provider etcd: {}"
time="2017-01-11T16:29:02Z" level=debug msg="Last etcd config received more than 2s, OK"
time="2017-01-11T16:29:02Z" level=info msg="Server configuration reloaded on :80"
time="2017-01-11T16:29:02Z" level=error msg="KV connection error: watchtree channel closed, retrying in 1.002422779s"
time="2017-01-11T16:29:03Z" level=error msg="KV connection error: watchtree channel closed, retrying in 1.467622501s"
time="2017-01-11T16:29:05Z" level=error msg="KV connection error: watchtree channel closed, retrying in 1.08614621s"
time="2017-01-11T16:29:06Z" level=error msg="KV connection error: watchtree channel closed, retrying in 1.562943601s"
time="2017-01-11T16:29:07Z" level=error msg="KV connection error: watchtree channel closed, retrying in 3.970210188s"
...

What did you see instead?
The default '/traefik' key is created in etcd, always.
But the following backends, frontends keys cannot be created.
NOTE: I'm trying to move from Vulcand and the etcd configuration is working with a Vulcand instance, I assume this means it's correctly set, maybe i'm wrong?

I have relative same issue
./traefik_darwin-amd64 storeconfig -c ~/Downloads/traefik.conf
This command fail with the error message
2017/08/20 09:28:18 Error running traefik: client: etcd cluster is unavailable or misconfigured
But when I look into etcd, the root "/traefik" has been created and the key "/traefik/accesslogsfile" with an empty value too. It's very strang, cause this key is not empty on my traefik.conf file and all other keys has been ignored...


Preflight of Tailwind take precedence on background-color of input field

Package
filament/forms
Package Version
v2.15.28
Laravel Version
v9.26.1
Livewire Version
v2.10.7
PHP Version
PHP 8.1
Problem description
I have something weird with Tailwind. First of all, all my classes are correctly generated and accessible.
In a button, I affect a background color.
But, the preflight of Tailwind :
button, [type='button'], [type='reset'], [type='submit'] {
    -webkit-appearance: button;
    background-color: transparent;
    background-image: none;
}

takes precedence on my bg-red-300 for example.
If I uncheck background-color: transparent;, it works.
You can find the code in this repository https://github.com/happytodev/filament-tailwind-color-picker
Adam (@awcodes) already knows about this bug as we discussed about it on Discord.
Expected behavior
I expect that the bg-{color}-{level} applies on the input field as background color and not the bg-transparent instead
Steps to reproduce
The quickest way is to install filament demo.
Then composer require happytodev/filament-tailwind-color-picker
The version of plugin is v0.1.3
After that edit postResource.php to add a Tailwind Color Picker field :
use HappyToDev\FilamentTailwindColorPicker\Forms\Components\TailwindColorPicker;
...

        TailwindColorPicker::make('textColor')
                ->setScope('text-'),

Load the admin and edit a post.
Select a color for the field, normally the color picker button must change the background color.
With this bug it did not.
Reproduction repository
https://github.com/happytodev/filament-tailwind-color-picker
Relevant log output
No response

Sorry, we had to roll this back, since it was causing too many issues. We will address this with v3 again,

No worries. I understand.

Should we leave this issue open or close it, @pxlrbt?

It's still an issue, so I'd say leave it open, until we fix it with V3.

maybe add a v3 label?

I think this will automatically be resolved in v3 with the new asset manager.
For v2 it was fixed but reverted because it broke a lot of plugins and it was easier to revert than make all the plugins update accordingly.

Alright cool! Thanks.


Config flow could not be loaded: {"message":"Invalid handler specified"}

When installing Skodaconnect via HACS, I immediately get an error message when trying to add the integration:
Config flow could not be loaded: {"message":"Invalid handler specified"}
Home Assistant 2023.10.1
Frontend 20231005.0 - latest

2023-10-10 08:35:28.195 ERROR (MainThread) [homeassistant.config_entries] Error occurred loading flow for integration skodaconnect: cannot import name 'Connection' from partially initialized module 'skodaconnect' (most likely due to a circular import) (/home/homeassistant/.homeassistant/skodaconnect/init.py)

Uninstalling completely and reinstalling via HACS made it kick back to life. Closing this.


Cleanup logging in tag helpers

@rynowak

am I correct this is the first of a few (how many?) PRs and that later ones will add logging where other tag helpers currently throw or no-op?

:shipit: when @rynowak is moderately pleased

:shipit:


Add resize main window option

Add option to define size of main window - it is just too small to get comfortable view of all information in large LTN bases

See comment on #53.


Add dim to pytorch_lightning.metrics.PSNR

🚀 Feature
Add dim to pytorch_lightning.metrics.PSNR so that users can specify the dimension (or dimensions) for the mean squared error reduction if PSNR computation.
Motivation
Suppose we have two image pairs
(pred_image_1, target_image_1)
(pred_image_2, target_image_2)

pytorch_lightning.metrics.PSNR computes the PSNR as
squared_error_1 = (pred_image_1 - target_image_1) ** 2
squared_error_2 = (pred_image_2 - target_image_2) ** 2
mean_squared_error = (squared_error_1 + squared_error_2) / (squared_error_1.numel() + squared_error_2.numel())
psnr = -10.0 * log(mean_squared_error)

If pred_image_1.numel() >> pred_image_2.numel(), the quality of pred_image_1 may bias the output pnsr.
It will be helpful if we can compute the psnrs of each image pair separately and average psnrs:
squared_error_1 = (pred_image_1 - target_image_1) ** 2
psnr_1 = -10.0 * log(squared_error_1.mean())
squared_error_2 = (pred_image_2 - target_image_2) ** 2
psnr_2 = -10.0 * log(squared_error_2.mean())
psnr = (psnr_1 + psnr_2) / 2

Pitch
Add dim to pytorch_lightning.metrics.PSNR:
class PSNR(Metric):
    def __init__(
        self,
        data_range: Optional[float] = None,
        base: float = 10.0,
        dim: Union[int, Sequence[int]] = (),  # New.
        reduction: str = 'elementwise_mean',  # Unused?
        compute_on_step: bool = True,
        dist_sync_on_step: bool = False,
        process_group: Optional[Any] = None,
    ):
        # ...

        self._dim = tuple(dim) if isinstance(dim, Sequence) else dim
        self.add_state("sum_psnr", default=torch.tensor(0.0), dist_reduce_fx="sum")
        self.add_state("total", default=torch.tensor(0), dist_reduce_fx="sum")
        # ...

    def update(self, preds: torch.Tensor, target: torch.Tensor):
        psnrs = compute_psnr(preds, target, dim=self._dim) # New.
        self.psnrs += psnrs.sum()
        self.total += psnrs.numel()

    def compute(self):
        return self.psnrs / self.total

preds_nchw = torch.rand([32, 3, 224, 224]
targets_nchw = torch.rand([32, 3, 224, 224]
metric = PSNR(dim=(1, 2, 3))
average_psnr_of_n_images = metric(preds_nchw, targets_nchw)

Alternatives
If the original behavior should be kept, maybe we can do
class PSNR(Metric):
    def __init__(
        self,
        data_range: Optional[float] = None,
        base: float = 10.0,
        dim: Optional[Union[int, Sequence[int]]] = None,  # `None` for original behavior
        reduction: str = 'elementwise_mean',  # Unused?
        compute_on_step: bool = True,
        dist_sync_on_step: bool = False,
        process_group: Optional[Any] = None,
    ):
        # ...

        self._dim = tuple(dim) if isinstance(dim, Sequence) else dim
        if self._dim is None:
            # Original behavior.
            self.add_state("sum_squared_error", default=torch.tensor(0.0), dist_reduce_fx="sum")
        else:
            self.add_state("sum_psnr", default=torch.tensor(0.0), dist_reduce_fx="sum")
        self.add_state("total", default=torch.tensor(0), dist_reduce_fx="sum")
        # ...

Hi @manipopopo,
Thanks for your suggestion. I think it is a good idea to add a dim argument to PSNR. Would you be up for sending a PR with the enhancement?

Hi @SkafteNicki , I’d be happy to. Maybe I can send a PR tomorrow.

@manipopopo sound good to me :]
Please ping me in your PR.