Error in service hardware_keyboard.dart

In our application, for production, we caught an error in the service
hardware_keyboard.dart:
Null check operator used on a null value
#0      KeyEventManager._convertRawEventAndStore (package:flutter/src/services/hardware_keyboard.dart:884)
#1      RawKeyboard.handleRawKeyEvent (package:flutter/src/services/raw_keyboard.dart:677)
#2      KeyEventManager.handleRawKeyMessage (package:flutter/src/services/hardware_keyboard.dart:818)
#3      BasicMessageChannel.setMessageHandler. (package:flutter/src/services/platform_channel.dart:73)
#4      BasicMessageChannel.setMessageHandler. (package:flutter/src/services/platform_channel.dart:72)
#5      _DefaultBinaryMessenger.setMessageHandler. (package:flutter/src/services/binding.dart:379)
#6      _DefaultBinaryMessenger.setMessageHandler. (package:flutter/src/services/binding.dart:376)
#7      _invoke2. (dart:ui/hooks.dart:205)
#8      _rootRun (dart:async/zone.dart:1428)
#9      _CustomZone.run (dart:async/zone.dart:1328)
#10     _CustomZone.runGuarded (dart:async/zone.dart:1236)
#11     _invoke2 (dart:ui/hooks.dart:204)
#12     _ChannelCallbackRecord.invoke (dart:ui/channel_buffers.dart:42)
#13     _Channel.push (dart:ui/channel_buffers.dart:132)
#14     ChannelBuffers.push (dart:ui/channel_buffers.dart:329)
#15     PlatformDispatcher._dispatchPlatformMessage (dart:ui/platform_dispatcher.dart:544)\n#16     _dispatchPlatformMessage (dart:ui/hooks.dart:92)
On device: SM-N976N
OS: Android 9(28)

@ne3Vubeki
Can you provide flutter doctor -v of production app ? Are there concrete steps to replicate this error ?

@ne3Vubeki Can you provide flutter doctor -v of production app ? Are there concrete steps to replicate this error ?

And here it is, take a look at the code, you have an obvious null safety error there. You are allowing assignment of null to a variable that cannot be null.

@ne3Vubeki Can you provide flutter doctor -v of production app ? Are there concrete steps to replicate this error ?

We do not have access to the application code and cannot reproduce it either. Errors are received from the application of the published application by the error collection system. We got another error in the same place, but on the device:
On device: SM-G977N
OS: Android 7.1.2(25)

@ne3Vubeki
Thanks for the details. Is there a way to know if app users are using Gboard app for input instead of default onscreen keyboard ? because it sounds similar to https://github.com/flutter/flutter/issues/90729

@ ne3Vubeki Спасибо за подробности. Есть ли способ узнать, используют ли пользователи приложения приложение Gboard для ввода вместо экранной клавиатуры по умолчанию? потому что это похоже на # 90729

Unfortunately, there is no way to find out, we just collect statistics to fix errors. Users who encountered this error did not contact us.

Thanks for the update. Will keep it open for further investigation as there doesn't seem to be any reproducible steps.
Also looks similar / related to : https://github.com/flutter/flutter/issues/90729

/cc @chinmaygarde

I see no null check on line 884 in the current version of the file https://github.com/flutter/flutter/blob/34dbee66de8b2ef176ec39d80c3eca5feb70572e/packages/flutter/lib/src/services/hardware_keyboard.dart#L884.
What is the version of the Flutter you are using? Using flutter doctor -v. If not available, I am going to assume this is fixed on master.
cc @dkwingsmt

Я не вижу нулевой проверки в строке 884 в текущей версии файла
https://github.com/flutter/flutter/blob/34dbee66de8b2ef176ec39d80c3eca5feb70572e/packages/flutter/lib/src/services/hardware_keyboard.dart#L884
.
Какую версию Flutter вы используете? Использование flutter doctor -v. Если он недоступен, я предполагаю, что это исправлено на мастере.
cc @dkwingsmt

Flutter version 2.5.3
you have it as line 902

This is occurring for me on Flutter version 2.5.3 - stable.
Stacktrace from production:
_CastError: Null check operator used on a null value
  File "hardware_keyboard.dart", line 884, in KeyEventManager._convertRawEventAndStore
  File "raw_keyboard.dart", line 677, in RawKeyboard.handleRawKeyEvent
  File "hardware_keyboard.dart", line 818, in KeyEventManager.handleRawKeyMessage
  File "platform_channel.dart", line 73, in BasicMessageChannel.setMessageHandler.<fn>
  File "platform_channel.dart", line 72, in BasicMessageChannel.setMessageHandler.<fn>
  File "binding.dart", line 379, in _DefaultBinaryMessenger.setMessageHandler.<fn>
  File "binding.dart", line 376, in _DefaultBinaryMessenger.setMessageHandler.<fn>
  File "hooks.dart", line 205, in _invoke2.<fn>
  File "zone.dart", line 1428, in _rootRun
  File "zone.dart", line 1328, in _CustomZone.run
  File "zone.dart", line 1236, in _CustomZone.runGuarded
  File "hooks.dart", line 204, in _invoke2
  File "channel_buffers.dart", line 42, in _ChannelCallbackRecord.invoke
  File "channel_buffers.dart", line 132, in _Channel.push
  File "channel_buffers.dart", line 329, in ChannelBuffers.push
  File "platform_dispatcher.dart", line 544, in PlatformDispatcher._dispatchPlatformMessage
  File "hooks.dart", line 92, in _dispatchPlatformMessage

As mentioned above, I think the issue occurs at https://github.com/flutter/flutter/blob/34dbee66de8b2ef176ec39d80c3eca5feb70572e/packages/flutter/lib/src/services/hardware_keyboard.dart#L902

flutter doctor -v
[✓] Flutter (Channel stable, 2.5.3, on macOS 12.0 21A344 darwin-arm)
• Flutter version 2.5.3 at
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 18116933e7 (7 weeks ago), 2021-10-15 10:46:35 -0700
• Engine revision d3ea636dc5
• Dart version 2.14.4
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at
• Platform android-31, build-tools 31.0.0
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS
• Xcode at /Applications/Xcode-beta.app/Contents/Developer
• Xcode 13.2, Build version 13C5081f
• CocoaPods version 1.11.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
[✓] VS Code (version 1.62.3)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.28.0
[✓] Connected device (2 available)
• sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 12 (API 31) (emulator)
• Chrome (web)                • chrome        • web-javascript • Google Chrome 96.0.4664.55
• No issues found!

Since all reports occurred on 2.5.3, it's highly likely that this issue has been fixed by https://github.com/flutter/flutter/pull/88967, which is applied to versions no earlier than 2.6.0. Let me know if this error occurs in later versions.


Use proper abbreviation

Hi @rylan-justice,  Please submit multiple typo fixes in a single PR as the CPU/GPU hours are wasted on CI. Hence, we do not encourage one liner grammatical changes as it is an expensive process. Thank you for your contribution!


Please add support for Gradle 6

Using the plugin version 1.4.1 with Gradle 6.2 fails with
Caused by: org.gradle.api.InvalidUserCodeException: Please use the ObjectFactory.listProperty() method to create a property of type List<T>.
        at org.gradle.api.internal.model.DefaultObjectFactory.property(DefaultObjectFactory.java:153)
        at org.gradle.api.model.ObjectFactory$property.call(Unknown Source)
        at com.devsoap.plugin.extensions.AddonExtension.<init>(AddonExtension.groovy:41)
        at com.devsoap.plugin.extensions.AddonExtension_Decorated.<init>(Unknown Source)

Seems to be working properly with Gradle 6.2.1 and Vaadin Gradle plugin 2.0.0.beta2. Thanks!


feat(ci): add mongosh integration testing

This is part of NODE-2940 (it doesn’t address Compass integration, because I don’t know what that would even look like given the many, many packages that make up Compass).

Add a mongosh integration test task to evergreen. This currently passes CI, but could fail if more breaking changes are being added. I’m doing my best to keep up with all driver changes, but we still have to adjust our code on a regular basis to changes being made to the master branch here – if you want to avoid this task failing occasionally, you can of course wait until the actual 4.0 release (or until all planned breaking changes are done).

I'm personally ok with going against master as we will find issues immediately rather than waiting for an official release. But I'm also willing to defer to other opinions.

I'm personally ok with going against master as we will find issues immediately rather than waiting for an official release. But I'm also willing to defer to other opinions.

Fwiw, the failure on its first waterfall run is because of such a breaking change that happened here since I opened the PR :) As mentioned, that will happen from time to time, but I’ll do my best to keep up to date with changes (and try to figure out if there’s a way to get evergreen notifications for failures of specific build variants).

Fwiw, the failure on its first waterfall run is because of such a breaking change that happened here since I opened the PR :) As mentioned, that will happen from time to time, but I’ll do my best to keep up to date with changes (and try to figure out if there’s a way to get evergreen notifications for failures of specific build variants).


Perf: Ingest performance

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR fixes a performance issue related to updating ExpectedPlayoutItems, that is done in updateExpectedPlayoutItemsOnRundown, called at the end of the ingest methods.

What is the current behavior? (You can also link to an open issue here)
getAllPiecesFromCache and getAllAdLibPiecesFromCache, performing findFetch on the cached collections, are executed for every Part, which makes the whole process extremely slow for long rundown because of the need for iterating over all the Pieces and AdlibPieces multiple times. O(m x n)

What is the new behavior (if this is a feature change)?
Pieces and AdLibPieces are fetched and grouped by their startPartId or partId. O(n)

In addition:

One occurrence of uncached database access is removed (merge error)
Context logging of is improved by passing a name to rundownPlaylistSyncFunction. As a side effect, it may lead to performance improvement under certain conditions, because before, anonymous functions passed to rundownPlaylistSyncFunction caused getFunctionName to do unnecessary work (including filesystem access).

Looks sensible so I'll merge. Does any of this need to go to NRK?

Already merged in NRK https://github.com/nrkno/tv-automation-server-core/pull/394


Change absolute URLs to APIs to use the xref syntax

There are several topics that are using absolute URLs to docs instead of using the API linking syntax, such as this topic:
https://github.com/dotnet/core-docs/blob/master/docs/standard/collections/index.md
The following topic shows an example of how to use the @ syntax:
https://raw.githubusercontent.com/dotnet/core-docs/master/api/index.md
What follows the @ symbol, it's the API UID. An explanation of the UID and how to use it can be found here: https://dotnet.github.io/docfx/spec/docfx_flavored_markdown.html#cross-reference
Right now, there is no easy way to find the UIDs. The best way to confirm what's the right one is by searching for the type in this repo: https://github.com/docascode/coreapi

@mairaw what is the status of this issue? Ongoing?

Let me check on this one @isaac2004. We also changed the guidance to use the xref syntax (<xref:UID> instead of @UID).

Oh that is what I assumed was being referred to :)

I think we might have some of these conversions left to do as well from @ to xref.
The first topics that got manually migrated were actually linking to the APIs with an absolute URL (https://docs.microsoft.com/dotnet/core/api/System.Collections.IEnumerable) as you can see in this commit:
https://github.com/dotnet/docs/commit/cfe65fcba1b3fdc09ffcac704a760d8ce29ea60b#diff-cca8a3e6c48b40ade7f58c2fb0edc73b
So that was what this issue was about. This might be finished already. Then I'd open a new one for the conversion from @ to xref.

@mairaw, since we're using the xref: syntax, should this issue be closed?

@rpetrusha I'll assign this to myself to finish. It's only 4 files left.

Oh no, I totally forgot about this one. Thanks for being great @mairaw!

We did too @isaac2004. No worries!


fakeClick method no longer works in Chrome 41

The fakeClick tab-under method works fine in versions of Chrome < 41.
In Chrome 41 (currently only available in Chrome Canary) focus switches to the new tab.

+1

Guys, I'll take care of it, there will be an update within a month.

Old => closing


Question: How is ModalPageHandler intended to be used?

What do I need to do?
I need to write a handler that intercepts the Gen. Jnl. Template lookup when opening a General Journal with multiple templates of the same type defined, then select a specific one and return with LookupOK.
What have  I tried?
I have the following method that is declared as [ModalPageHandler]:
    [ModalPageHandler]
    procedure SelectTemplateHandler(var zhePage: TestPage "General Journal Template List")
    var
        t : Variant;
    begin
        zhePage.GoToKey('GEN-SIM');
        t := zhePage.OK();
    end;

I only deducted, that OK could be the method I am looking for. But OK is not documented anywhere. Neither is Cancel (a method of the same object). It returns a DataType called TestAction, which is unknown to AL (and C/AL aswell btw.). What do I have to do with this?
When I do not catch the return value of OK, the compiler errors out saying I have to catch the return value.
The only way I got it compiling is by trapping the result inside a Variant (as shown above). This way the extension compiles, but the test fails with no error message and Result = Failed.
I have also tried the alternative signature of using NameOfValriable: Page; var Response: Action. But in this case I do not have a TestPage, but only a Page. And then I do not have GoToKey method that allows me to select a specific record.

Update: I have resolved this with some help from @johanhoffmann . OK is not a method but returns a TestAction object that has to be invoked by calling OK.Invoke();. Thanks Jan.
Please update the official documentation on these objects / data types. Thank you.

Tracking the docs update with this issue.


use bibtex in envelope.py

convert references in mne/connectivity/envelope.py to use footcite / footbibliography

I will work on this!


Error while reading line from the server. Again

Hello!
I saw this (https://github.com/predis/predis/issues/33) very similar issue, but such method doesn't work.
For example, this code throw such error -> Fatal error: Uncaught Predis\Connection\ConnectionException: Error while reading line from the server.
    $read_client = new Client([
      'scheme'   => 'tcp',
      'host'     => 'host.org',
      'port'     => '6379',
      'database' => '1',
      'password' => 'pass',
      'timeout'  => 10,
      'read_write_timeout'  => -1,
    ]);

    $read_client->set('library', 'predis');

    $data = $read_client->get('library');
    sleep(3);
    $data2 = $read_client->get('library');

I set 'read_write_timeout'  => -1, but it doesn't work.
=========================================================
I think the reason in this place \Predis\Connection\StreamConnection::assertParameters()

Please reopen issue i got a same prolem


Suggestion: plainJS example

Could you add a non-framework, plain javascript under /examples?

Let me play around with the library and I will submit something, @peckjon :+1:

No plans to add a plain js example on the main repo.


Issue on Windows phone

I have a customer who was having issues with the display of their site on their Windows phone.
You can see the issue here: https://generatepress.com/forums/topic/windows-phone-scale-issue/
They found that replacing this:
@media (max-width: 400px) {
    @-ms-viewport {
        width: 320px;
    }
}

With this:
@media (max-width: 400px) {
    @-ms-viewport {
        width: device-width;
    }
}

Fixes their issue.
Any reason for this? Am I safe to make this change?
Thanks!

Interesting. After reading that thread, I noticed you came across the same article I did. I had a GitHub ticket filed years ago, which is why I added 320px in the first place. haha.
Sure though, if device-width fixes it, I can get that added to Unsemantic itself.
:)

I guess my question is: What Windows phones are still "in the wild" that require an exact 320px to be set? I'm guessing maybe we could just remove that @-ms-viewport code entirely now, yeah?

Hmm, I wouldn't know - never used a Windows phone. Maybe someone here has one and can test it out?
I assume it should just work the same as any other phone these days - at least I would hope.
Maybe just adding device-width for now will work? I wonder if that will cause problems itself?
Thanks for responding so quickly :)

How about this solution?
    width: auto;
}```

It looks like it needs to be this (without the media query):
@-ms-viewport {
    width: device-width
}

HTML5 boilerplate had to do it too: https://github.com/h5bp/html5-boilerplate/issues/1047

Closing this, since Windows Phone has been discontinued.


Pull card: add tooltip of timestamp to age indicator

The age indicator is relative and coarse. Let's add a tooltip that gives
more specifics.
"opened at 20/12/2012, 03:00:00"

QA :seal:

Timestamp tooltip appears whenever hovering the age indicator :heavy_check_mark:

Steps Taken

Checked out branch and pulled
Ran /home/ifixit/ifixit_scripts/update-pulldasher-dev --run .
Verified tool tip behavior when hovering age indicator


Browsing haskell-miso.org with JS disabled

It would be great if haskell-miso.org worked the same with JS disabled. Which would also be a great showcase for the isomorphic feature.
It seems that the only thing not functioning correctly with JS disabled are the top navigation controls. Adding a href attribute and onclick="return false;" solves this, but maybe there is a more idiomatic way to do this?

Fantastic idea. So it seems if the user had js enabled that we'd like navigation to occur with the pushState API, and prevent the default behaviour of navigation by way of the href tag.  So in order to support this we'd need to put both a click handler with options that preventDefault behaviour from occurring, and a href attribute on the a tag. This will give correct behaviour under both scenarios.
a_ [ href "/about"
     , onClick defaultOptions { preventDefault = True } $ goAbout
     ] [ ]


Can't load OpenAPI schema with DRF 3.14 and drf-spectacular 0.24.2, python 3.915

With the above package versions I get the following error when I try to load /schema/
Any idea what's going on here?
<IP_ADDRESS> - - [08/Dec/2022 15:48:00] "GET /schema/ HTTP/1.1" 500 -
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/wsgi.py", line 132, in __call__
    response = self.get_response(request)
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/base.py", line 140, in get_response
    response = self._middleware_chain(request)
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/exception.py", line 57, in inner
    response = response_for_exception(request, exc)
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/exception.py", line 139, in response_for_exception
    response = handle_uncaught_exception(
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/exception.py", line 180, in handle_uncaught_exception
    return debug.technical_500_response(request, *exc_info)
  File "/usr/local/lib/python3.9/site-packages/django_extensions/management/technical_response.py", line 40, in null_technical_500_response
    raise exc_value.with_traceback(tb)
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/usr/local/lib/python3.9/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/views/decorators/csrf.py", line 54, in wrapped_view
    return view_func(*args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/django/views/generic/base.py", line 84, in view
    return self.dispatch(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/rest_framework/views.py", line 509, in dispatch
    response = self.handle_exception(exc)
  File "/usr/local/lib/python3.9/site-packages/rest_framework/views.py", line 469, in handle_exception
    self.raise_uncaught_exception(exc)
  File "/usr/local/lib/python3.9/site-packages/rest_framework/views.py", line 480, in raise_uncaught_exception
    raise exc
  File "/usr/local/lib/python3.9/site-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
  File "/usr/local/lib/python3.9/site-packages/drf_spectacular/views.py", line 82, in get
    return self._get_schema_response(request)
  File "/usr/local/lib/python3.9/site-packages/drf_spectacular/views.py", line 90, in _get_schema_response
    data=generator.get_schema(request=request, public=self.serve_public),
  File "/usr/local/lib/python3.9/site-packages/drf_spectacular/generators.py", line 268, in get_schema
    paths=self.parse(request, public),
  File "/usr/local/lib/python3.9/site-packages/drf_spectacular/generators.py", line 239, in parse
    operation = view.schema.get_operation(
  File "/usr/local/lib/python3.9/site-packages/drf_spectacular/utils.py", line 364, in get_operation
    return super().get_operation(path, path_regex, path_prefix, method, registry)
  File "/usr/local/lib/python3.9/site-packages/drf_spectacular/openapi.py", line 94, in get_operation
    operation['responses'] = self._get_response_bodies()
  File "/usr/local/lib/python3.9/site-packages/drf_standardized_errors/openapi.py", line 55, in _get_response_bodies
    serializer = self._get_error_response_serializer(status_code)
  File "/usr/local/lib/python3.9/site-packages/drf_standardized_errors/openapi.py", line 238, in _get_error_response_serializer
    return self._get_http400_serializer()
  File "/usr/local/lib/python3.9/site-packages/drf_standardized_errors/openapi.py", line 260, in _get_http400_serializer
    serializer = self._get_serializer_for_validation_error_response()
  File "/usr/local/lib/python3.9/site-packages/drf_standardized_errors/openapi.py", line 275, in _get_serializer_for_validation_error_response
    fields_with_error_codes = self._determine_fields_with_error_codes()
  File "/usr/local/lib/python3.9/site-packages/drf_standardized_errors/openapi.py", line 283, in _determine_fields_with_error_codes
    fields = get_flat_serializer_fields(serializer)
  File "/usr/local/lib/python3.9/site-packages/drf_standardized_errors/openapi_utils.py", line 77, in get_flat_serializer_fields
    name = get_prefix(prefix, field.field_name)
AttributeError: 'OpenApiTypes' object has no attribute 'field_name'

Thank you for reporting the issue @hamishfagg.
I was able to reproduce it by adding @extend_schema(request=OpenApiTypes.STR) to an update view. So, can you please confirm that similar code @extend_schema(request=OpenApiTypes....) is also causing the error for you?

Just released v0.12.4 which should fix this issue. If that's not the case, feel free to reopen the issue.

Thanks very much for this.
For future googlers I ran into another error after installing 0.12.4:
AssertionError: May not set both 'read_only' and 'write_only'
This was due to having model fields listed as write_only, as well as listed in a write_once mixin I'm using. Removing one of these listings for the fields solved this issue.


Escaping character examples shown incorrectly.

Under the Ignore or escape markdown section the examples are not correctly shown.
It reads:

"Enter \ to get \" instead of "Enter \\ to get \"
"Enter \ to get _" instead of "Enter \_ to get _"
"Enter # to get #" instead of "Enter \# to get #"
and so on.

This is probably an issue with how the markdown parser on the docs.microsoft.com site, as the file shows correctly when parsed by github's markdown parser in this repo

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fa622358-f5bb-1f5c-177a-081a37b6acef
Version Independent ID: 72f7fd16-a822-66c8-3a34-8905645ce5f2
Content: Markdown syntax for files, widgets, and wikis in Azure DevOps - Azure DevOps
Content Source: docs/project/wiki/markdown-guidance.md
Product: devops
Technology: devops-collab
GitHub Login: @chcomley
Microsoft Alias: chcomley

Hi @chao-master, Thanks so much for the heads up on this. I've updated the markdown so the code shows up properly. This update should be live within the next 3-4 hours, if not before. Thanks again!


Guance

What does this PR do?

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached
[ ] If the PR doesn't need to be tested during QA, please add a qa/skip-qa label.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Deleting document and its sub-collections from Firestore Flutter

Hello! I'm trying to delete a post and all its sub-collections. When using the code below, I'm only able to delete all the fields in the post, but NOT the sub-collections it has.
FirebaseFirestore.instance.collection('posts').doc(postId).get().then((doc) {
      if (doc.exists) {
        doc.reference.delete();
      }

What should I change to make it work? Thanks a lot!

Issues with Firebase plugins need to be reported in the FlutterFire repository; they are not part of this project.

Issues with Firebase plugins need to be reported in the FlutterFire repository; they are not part of this project.

Where can I find the FlutterFire repository? Thanks


Add ACS 4.17 support

@Pearl1594 You may wanna test / update the testdata to ensure that it hasn't changed in 4.17

Yes, was going to spend some time on that, hence was marked as a draft PR.

Hello, I've created a PR which fixes Icon type behavior in 4.17: https://github.com/apache/cloudstack-go/pull/45.

cc @shwstppr may need rework or latest api json for use to generate the bindings against 4.17.2

With the release of 4.18, do we want to just move forward with updating for that instead @rohityadavcloud ?

@mlsorensen cc @mlsorensen is it okay if merge this and add a release for 4.17 support and then work for 4.18 release?

Lgtm


tinyprog 1.0.23 has no py3 wheel

There are py2 and py3 wheels for the previous release:
https://pypi.org/project/tinyprog/1.0.21/#files
There's no py3 wheel for the current one though:
https://pypi.org/project/tinyprog/1.0.23/#files

I believe this is no longer relevant?

I believe this is no longer relevant?

Well, there's still no Python 3 wheel of tinyprog 1.0.23 :-)   And there's no non-development release of anything later either.
But if you're planning on doing a non-development release of 1.0.24 (or later) with Py2/Py3 versions that people can install directly (ie, without installing from git or explicitly requesting a development version), then yes this issue would then be no longer relevant / out of date.
Ewen

@ewenmcneill - I think we need to do some testing, but should try and get that release out ASAP....


Smart Collections FR: Pinecone Adapter

Would it be possible to have the option to store the embeddings in Pinecone?

Recorded response https://youtu.be/J5ARc_91fzs


ref #89483 The 'page' parameter has been removed from the history API methods

Codecov Report

Merging #211 (ceb3902) into master (3110960) will increase coverage by 0.03%.
The diff coverage is 57.14%.

:exclamation: Current head ceb3902 differs from pull request most recent head 4cb6c94. Consider uploading reports for the commit 4cb6c94 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
+ Coverage     31.37%   31.41%   +0.03%
+ Complexity     2652     2650       -2
============================================
  Files           115      115
  Lines          8015     8005      -10
============================================
  Hits           2515     2515
+ Misses         5500     5490      -10

Impacted Files
Coverage Δ

retailcrm/lib/RetailcrmHistory.php
54.78% <0.00%> (+0.10%)
:arrow_up:

retailcrm/lib/api/RetailcrmApiClientV5.php
4.80% <0.00%> (+0.03%)
:arrow_up:

retailcrm/lib/api/RetailcrmApiPaginatedRequest.php
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Loading big IFC model crashes application

Describe the bug 📝
I am trying to load a big IFC model with stats shown as below and my browser crashes when loading.

I can share my small application but it is simply creating a world and load model using IfcLoader.
I have tried loading same model to demo of web-ifc repository, and it can be successfully loaded there.
Unfortunately I cannot share IFC model due to privacy reasons, but I am hoping my shared stats might give you clue. I wonder is there hard limits what this repo can handle in terms of object count etc? Can you please help me here?
Reproduction ▶
No response
Steps to reproduce 🔢
No response
System Info 💻
System:
    OS: macOS 14.6.1
    CPU: (10) arm64 Apple M1 Pro
    Memory: 84.48 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.19.0 - ~/.nvm/versions/node/v18.19.0/bin/node
    npm: 10.2.3 - ~/.nvm/versions/node/v18.19.0/bin/npm
  Browsers:
    Chrome: 129.0.6668.101
    Edge: 130.0.2849.46
    Safari: 17.6

Used Package Manager 📦
npm
Error Trace/Logs 📃
No response
Validations ✅

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a repository issue and not a framework-specific issue. For example, if it's a THREE.js related bug, it should likely be reported to mrdoob/threejs instead.
[X] Check that this is a concrete bug. For Q&A join our Community.
[X] The provided reproduction is a minimal reproducible example of the bug.

Hi @onderilkesever how big is the file? To load big models fast we have a streaming system that we have tried successfully with files over 2GB

@onderilkesever I see. Not big indeed, but maybe it has a lot of geometry. Have you tried streaming?

@agviegas , I just tried streaming, and the application does not crash, but the displayed model is not complete(some pieces are missing).
Nevertheless, I am afraid migrating to streaming is going to be quite challenging for us as we already have bunch of custom use cases integrated. And having culler in place, we actually didnt have any performance problems without streaming until now. And I feel if we could render, three will not have problem rendering thanks to culler. So I would really appreciate your help finding the bottleneck here that could potentially understand why the browser crashes in the first place.

@onderilkesever I see. Are you trying to open the IFC file directly in the browser, or export it to fragment files and then open the .frag directly?

@agviegas I tried both loading via IfcLoader and FragmentsManager, both are crashing the browser/tab.

Hm, if just loading the .frag file (no IFC present whatsoever) crashes the memory, it means that it's too much for three.js to handle simultaneously with the current geometry system. I can come up with two options:

Split down the file and load only parts of it when exporting to .frag
Streaming (if you face any issues or have any problems, happy to guide you)

Thanks for the support here @agviegas ! Can you please help me how can I split it down when converting to frag? The only option I know is by filtering entities, but unfortunately most of the entities seems to be coming from single category.

@onderilkesever I guess you will need to customize our IFC-fragments converter a bit. In this loop you can add a counter to just convert a certain number of geometries (e.g. 1000 geometries). If you have questions in the process, let me know!

Thanks for your support here and offering your help for various solutions. I only have one thing that I cannot fully answer. How come demo of web ifc (https://thatopen.github.io/engine_web-ifc/demo/) can show the same model in the same pc but not when using "@thatopen/components" if that was only limitation on the three with the current geometry system?

@onderilkesever because the demo of web-ifc has a different geometry system. It merges all the geometries into a single mesh with multiple materials. This works well for some models but it has several problems:

The use of memory is proportional to the size of the model. So this means that depending on your machine, there are models that you will never be able to open with this.
Buffers are hard to edit and work with. Things like highlighting, hiding, etc are hard.
This system is impossible to manipulate (so we would never be able to build a modeller like clay)

In components we use instancedMeshes. They are way more flexible, easier to work with (highlighting, hiding, etc), allow us to load parts of the model (e.g. streaming), as well as opens the door for modelling in the future. Of course, there are models that benefit from the first system more, but in our experience the current system we have in fragments is the one that closes less doors.


You can't buckle while in a open airlock/door

Open a airlock
Go inside (and hope it doesn't crush you)
Spawn a chair next to/in the airlock
Try to buckle 🪑

Can't reproduce.


Update deploy-dynamics-365-app-for-outlook.md

Added the URL to navigate the My Apps page

made updates on my own branch and merged into mater.


Question regarding the reward of sales promotion training dataset

Hi,
In the sales promotion environment the reward is denoted by rew = (d_total_gmv - d_total_cost)/self.num_users which means the operator observes one single reward signal over all users. However, in the offline training dataset the reward is different for each user across 50 days. For example refer to the below user orders and reward graph

as per my understanding the reward should be same each day for the three users and gradually increase over 50 days with increase in sales. Could you kindly let me know how the reward in the training dataset was calculated.

Hi, the calculation of each user's reward is the same, which is the based on $gmv-cost$. However, as the platform policy should consider the overall/average incomes, the reward for each user is set as the average reward for simplicity.
Alternately, the datasets actions are made by a human operator (after data anonymization), and we retain the original reward in the dataset for researchers with specific needs.

Thank you for your reply. Could you kindly let me know how the original reward was calculated. I require it to recalculate the reward based on variations in user orders. Also, for the provided environment I noticed the val_initial_states = np.load(os.path.join(dir, f'test_initial_states_10000_people.npy')) is not reset which causes the self.states to take different values every time the environment is reset after initialization. As an effect even with a deterministic action the reward function grows every time the environment is reset. For example please refer to the below code and the reward graph

Could you let me know if this is a bug or if there is a reason behind the reward choice.

Thanks for reporting this issue. This environment is originally designed for online evaluation, and thus some code are tailored to evaluation but not for training. We have locally fixed this reset issue for training, while that branch has not committed. This will sooner come with the newer sales promotion environment with budget constraint.
Currently, you can revise this line with deepcopy() as a quick fix, i.e., "self.states = deepcopy(self.val_initial_states)" in https://github.com/polixir/NeoRL/blob/a4b6c578662a0566ac39bc6ed84236b853142e8f/neorl/neorl_envs/SalesPromotion/sales_promo/env/marketing.py#L439.
For "I require it to recalculate the reward based on variations in user orders", as mentioned above, the current sp_env does not support this calculation. You may need to use the raw order_number (the user network output) and gmv&cost data in https://github.com/polixir/NeoRL/blob/a4b6c578662a0566ac39bc6ed84236b853142e8f/neorl/neorl_envs/SalesPromotion/sales_promo/env/marketing.py#L161
and
https://github.com/polixir/NeoRL/blob/a4b6c578662a0566ac39bc6ed84236b853142e8f/neorl/neorl_envs/SalesPromotion/sales_promo/env/marketing.py#L426 respectively.


netopeera2

Hi MIchalvasco,
i am trying to build netopeera2 (git file ) on x86 64bit  architecture ,little endian & ubuntu operating system.
Doing arm cross compellation on it.
i am getting following errors.
-- Unable to learn libnetconf2 thread support, check skipped
-- Check if the system is big endian
-- Searching 16 bit integer
CMake Error at /usr/share/cmake-3.10/Modules/TestBigEndian.cmake:49 (message):
no suitable type found
Call Stack (most recent call first):
CMakeModules/UseCompat.cmake:20 (TEST_BIG_ENDIAN)
CMakeLists.txt:171 (use_compat)
-- Configuring incomplete, errors occurred!
listed below are CMakeErrro.log file
1 Determining size of unsigned short failed with the following output:
  2 Change Dir: /home/labadmin/rohit/netopeer2/build/CMakeFiles/CMakeTmp
  3
  4 Run Build Command:"/usr/bin/make" "cmTC_8b58f/fast"
  5 /usr/bin/make -f CMakeFiles/cmTC_8b58f.dir/build.make CMakeFiles/cmTC_8b58f.dir/build
  6 make[1]: Entering directory '/home/labadmin/rohit/netopeer2/build/CMakeFiles/CMakeTmp'
  7 Building C object CMakeFiles/cmTC_8b58f.dir/CMAKE_SIZEOF_UNSIGNED_SHORT.c.o
  8 /usr/bin/cc -D_GNU_SOURCE -D_POSIX_C_SOURCE=200809L -D__BSD_VISIBLE=1 -I/usr/local/include -I/home/labadmin/rohit/anji/libnetconf2/src   -o CMakeFiles/cm    TC_8b58f.dir/CMAKE_SIZEOF_UNSIGNED_SHORT.c.o   -c /home/labadmin/rohit/netopeer2/build/CMakeFiles/CheckTypeSize/CMAKE_SIZEOF_UNSIGNED_SHORT.c
  9 Linking C executable cmTC_8b58f
 10 /usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_8b58f.dir/link.txt --verbose=1
 11 /usr/bin/cc      -rdynamic CMakeFiles/cmTC_8b58f.dir/CMAKE_SIZEOF_UNSIGNED_SHORT.c.o  -o cmTC_8b58f -Wl,-rpath,/usr/local/lib /usr/lib/x86_64-linux-gnu/l    ibssl.so /usr/lib/x86_64-linux-gnu/libcrypto.so /usr/local/lib/libssh.so
 12 /usr/bin/ld: cannot find CMakeFiles/cmTC_8b58f.dir/CMAKE_SIZEOF_UNSIGNED_SHORT.c.o: No such file or directory
 13 collect2: error: ld returned 1 exit status
 14 CMakeFiles/cmTC_8b58f.dir/build.make:100: recipe for target 'cmTC_8b58f' failed
 15 make[1]: *** [cmTC_8b58f] Error 1
 16 make[1]: Leaving directory '/home/labadmin/rohit/netopeer2/build/CMakeFiles/CMakeTmp'
 17 Makefile:126: recipe for target 'cmTC_8b58f/fast' failed
 18 make: *** [cmTC_8b58f/fast] Error 2

Best Regards
Syam Kumar

I see, that was not helpful, unfortunately. Maybe try increasing verbosity of cmake or something, there must be some actual error, this just shows that an object failed to be build, does not print the reason why.

8 /usr/bin/cc -D_GNU_SOURCE -D_POSIX_C_SOURCE=200809L -D__BSD_VISIBLE=1 -I/usr/local/include -I/home/labadmin/rohit/anji/libnetconf2/src   -o CMakeFiles/cm    TC_8b58f.dir/CMAKE_SIZEOF_UNSIGNED_SHORT.c.o   -c /home/labadmin/rohit/netopeer2/build/CMakeFiles/CheckTypeSize/CMAKE_SIZEOF_UNSIGNED_SHORT.c

You're saying you're cross-compiling, yet this shows that the host's compiler is invoked, not the target one. I suggest using a proper tool for cross builds, such as Buildroot or Yocto. It is not just a matter of setting a correct $CC.


Typescript 'Image' missing 'source' property

<Image
source={{ uri: d.picUrl[0] }}
style={{ height: 200, width: 200, flex: 1 }}
/>

This is the error message:

Type '{ source: { uri: string; }; style: { height: number; width: number; flex: number; }; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes & Readonly & Readonly<{ children?: ReactNode; }>'.
Property 'source' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes & Readonly & Readonly<{ children?: ReactNode; }>'.ts(2322)

I just pushed a fix for this in master? Can you point your package.json to master and check if it works?

Fixed in 2.13.8


rgb_to_hex.cc

In this file, the variable names for rgb are switched around.

switched variables back to their original names


Atheros AR9271

Hi I'm not sure if I submitted this correctly. I'm trying to get my Alfa wireless adapter to work again. It doesn't work with the new nethunter updates. Thanks!

Was it working before the update?
What version did you update from and to which version?
AR9271 isn't listed in the readme under "supported chipsets", but its files are included right from v1 of this module.

I have Alfa AthrosAR9271how i use this on oneplus6 nethunter or termux please help.

It was working properly after I removed the Magisk ADB module. I think it changed the way my USB port behaved. Sorry for the delay...you know...COVID

Sweet, closing since it's working.


[CARBONDATA-2206]add documentation for lucene datamap

added documentation for lucene datamap
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[x] Any interfaces changed?
NA

[x] Any backward compatibility impacted?
NA

[x] Document update required?
YES

[x] Testing done
NA
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4490/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4175/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5343/

The word wrap is strange, better to write a paragraph and let the editor do the rest.

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4256/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4264/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5431/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4564/

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5597/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4436/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4438/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5599/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4692/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4447/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5608/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4701/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5699/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4776/

LGTM

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4806/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4809/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4989/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5964/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4990/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/5967/

SDV Build Success , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4993/

@chenliang613 please review and merge

LGTM

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/4846/


*Fix. bug fixes and performance improvements

Yes, that's ok

Yes, the husky changes are contemplated to be put into production.


[BUG] some eww commands creates extraneous new lines

Describe the bug
Some eww commands creates extraneous new lines even though they aren't supposed to output anything.
An extraneous new line is an unwanted newline character "\n" that gets printed on a blank like at the end of the command. This results in two double line character on the terminal "\n\n" creating blank space.
Reproducing the issue
(when daemon running)

Command
Extraneous new line?

eww open [window_name]
✓

eww close [window_name]
✓

eww kill
✓

eww daemon
✓

eww -d open [window_name]
✓

eww
✓

eww update "x=5"
✓

eww state
☓

eww -h
☓

(when daemon not running)

Command
Extraneous new line?

eww close [window_name]
☓

eww kill
☓

eww daemon
☓

eww -d open [window_name]
☓

eww
☓

eww update "x=5"
☓

eww state
☓

eww -h
☓

I believe there is a clear correlation between daemon running and new line characters getting printed.
Expected behavior
Don't print an extra line on commands that aren't supposed to output anything.
Additional context
End my suffering and fix this please.

Thanks a lot for this extremely well written and researched issue! Fixed now!


spaCy already installed: "Exception: Not all required packages are installed. To use this pipeline, you need to install the missing dependencies.
I am trying to get a running Rasa NLU in a Python Virtual Environment.  Below are the steps, I had to take to get to this error:
"Exception: Not all required packages are installed. To use this pipeline, you need to install the missing dependencies. Please install spacy"
First, as a sudo user, nothing works with spacy or rasa, on Mint, or Ubuntu 16.04, or this Kubuntu. On my two computers or the computers of two others.  All Linux.
spaCy seems to be the real problem and most of these added steps, are due to spaCy simply not installing globally or/and my .env file.
I took these steps to get to the above error:
I had nothing but errors unless I was root, and installing spaCy was a nightmare.  These are the basic steps.
(I also had to install wheel using pip and pip3 - as I was getting failures).
I also had to follow these instructions: https://stackoverflow.com/a/48680354
install dev libs
sudo apt-get install python-dev -y &&
sudo apt-get install python3-dev -y &&
sudo apt-get install libevent-dev -y &&
and
apt-get install python-dev -y &&
apt-get install python3-dev -y &&
apt-get install libevent-dev -y && \
[AS ROOT]
install new gcc
sudo apt-get update &&
sudo apt-get install build-essential software-properties-common -y &&
sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y &&
sudo apt-get update &&
sudo apt-get install gcc-snapshot -y &&
sudo apt-get update &&
sudo apt-get install gcc-6 g++-6 -y &&
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-6 60 --slave /usr/bin/g++ g++ /usr/bin/g++-6 &&
sudo apt-get install gcc-4.8 g++-4.8 -y &&
sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-4.8 60 --slave /usr/bin/g++ g++ /usr/bin/g++-4.8;
Then I followed these instructions.
Check version of Python
$ python3 -V
Verify and/or install build-essential python-dev git
$ sudo apt-get install build-essential python-dev git
Then Create a Virtual Environment and install spaCy per https://spacy.io/usage/#source-ubuntu for a Virtual Environment  :
cd into project folder (e.g. RasaBotRonan)
$python3 -m venv .env
$source .env/bin/activate
Install spaCy (as part of virtual Environment)
(https://spacy.io/usage/#source-ubuntu for Linux instructions *other OS instructions available)
$ git clone https://github.com/explosion/spaCy
$cd spaCy
$export PYTHONPATH=pwd
$pip install -r requirements.txt
$python setup.py build_ext --inplace
$python -m spacy download en
Next, I installed RASA per these instructions:
$ cd ..   <--- now in project folder root and spaCy is a folder inside this folder
$ git clone https://github.com/dtaivpp/python-chatbot.git
$ cd python-chatbot
$ pip3 install -r requirements.txt
Train the initial run:
$ python3 train_rasa_core.py
I was getting all kinds of errors which precipitated the above sequence of steps.  Finally the train_rase_core.py ran, and can run twice.
I tried $ python3 train_rasa_terminal.py
and got the following error:
Exception: Not all required packages are installed. To use this pipeline, you need to install the missing dependencies. Please install spacy
I tried fixing it with this:
$ pip install -U scikit-learn scipy sklearn-crfsuite
But that does not fix it.
I am running $python3 train_rasa_terminal.py from a directory "next to" spaCy
Below is my project directory structure:
RasaBotRonan
--.env
--spaCy
--python-chatbot
I can run python3 train_rasa_core from ../pythonchatbot/
Thank you. I really want to get Rasa up and running.

Thanks for creating this issue, @twhughes will get back to you about it soon.

Hi @davidkartuzinski.  It's a bit hard to debug from here but maybe I can ask a few questions first

what is the output of:
which python3
does it point to a directory in your project directory?  I just want to check that you've activated the virtual environment correctly.

what do you get when you try
python3 -c "import spacy"
with the virtual environment activated?  If this throws an error then it's an issue with the spacy installation.

You mentioned you tried to fix it with
pip install -U scikit-learn scipy sklearn-crfsuite
Did you not instead try?
pip install -U spacy

Thank you for your very fast answer.

The output of which python3 is /home/david/Projects/RasaBotRonan/.env/bin/python3
I used that command within my .env as the venv was activated.

I don't remember installing spaCy that way exactly.  But when I run the command now, from within the venv, I get:

/usr/lib/python3.6/importlib/_bootstrap.py:219: RuntimeWarning: numpy.dtype size changed, may indicate binary incompatibility   return f(*args, **kwds) /usr/lib/python3.6/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility   return f(*args, **kwds)

Yes, I did try to pip install -U spacy globally and separately within various venvs, and multiple times, on multiple computers and after wiping and reinstalling ubuntu twice on one of my computers..  Also, my coding partner did the same.  That command doesn't seem to work.

What i wrote above, was the only steps, on a clean install that worked for me.
====================
I tried to rerun: python3 train_rasa_core.py to verify that it was still working.  And at count Epocj 400/400, I get the following error (which I didn't get before):
Epoch 400/400
240/240 [==============================] - 0s 131us/step - loss: 0.0464 - acc: 0.9792 - val_loss: 0.0743 - val_acc: 0.9667
INFO:rasa_core.policies.keras_policy:Done fitting keras policy model
Time to train: 0:00:16.246945
INFO:rasa_core.agent:Model directory ./models/dialogue exists and contains old model files. All files will be overwritten.
Traceback (most recent call last):
  File "train_rasa_core.py", line 54, in <module>
    agent.persist(model_path)
  File "/home/david/Projects/RasaBotRonan/.env/lib/python3.6/site-packages/rasa_core/agent.py", line 330, in persist
    self._clear_model_directory(model_path)
  File "/home/david/Projects/RasaBotRonan/.env/lib/python3.6/site-packages/rasa_core/agent.py", line 320, in _clear_model_directory
    shutil.rmtree(model_path)
  File "/usr/lib/python3.6/shutil.py", line 480, in rmtree
    _rmtree_safe_fd(fd, path, onerror)
  File "/usr/lib/python3.6/shutil.py", line 438, in _rmtree_safe_fd
    onerror(os.unlink, fullname, sys.exc_info())
  File "/usr/lib/python3.6/shutil.py", line 436, in _rmtree_safe_fd
    os.unlink(name, dir_fd=topfd)
PermissionError: [Errno 13] Permission denied: 'domain.yml'

This is the fourth time on this install that I ran it with the default training data.  I don't know if this is a normal response.
I am willing to completely start again, but have found no tutorials, instructions, or step by step that actually is up to date or assumes a newer set-up. And a new programmer.  The only reason I started learning Python 6 months ago (thanks @JoeyFaulkner and @mkennedy) was so that I could use Rasa.  Luis and friends, didn't fit my requirements.
Again, thank you. Like I said, I can start all over again, note every step and take screencaps, but there does seem to be something wrong.
DK

Per this video, https://www.youtube.com/watch?v=NBTeNcPhHJs spaCy has an issue wih the english language.  Around minute 1:15 to 1:45.  FYI.

Ok
Based on the warning from step 2 it seems like that is not a spacy error but rather a numpy warning that can be safely ignored.  Also, the command I pasted there is just to check whether spacy is installed and can be imported.
The error you are getting now has to do with the python-chatbot repository that you are using and not rasa core itself.  Because we did not make this repository I do not know how to fix it.  Perhaps you should create an issue on that repository to ask him about the error, or try git pull from that directory to see if there were any recent changes that may have fixed any bugs.  Did you try running the commands in the repo of that repository for installing scipy? (under Installation Linux (tested on Ubuntu 18.04.1 LTS Minimal install))
just to get started and make sure everything is working correctly, I'd highly recommend that you instead follow the tutorial here https://rasa.com/docs/core/quickstart/#id1.  This is just a simple demonstration of rasa_core that we've made for beginners.  It will walk you through the few bare minimum components that you need.  If that is working then you can substitute your own training data and it should work.  The docs are also a good resource for installation.
Let me know if that makes sense or you have any more issues.
Tyler

Also, looking at that repo, it seems you need to train the NLU portion of rasa via python train_nlu.py before you can run train_rasa_core.py

Thank you for your answers.
I understand about he Numpy error. Makes sense.
Regarding the Repo, the author of that repo has been trying to help us for about a week to get it working which I why I came here.  I will make another effort to reinstall from that repo but I am certain that I ran train_nlu.py first which is where I got the error.
As to the start docs.  I started there months ago and those instructions have never worked for myself or anyone else I know.  In fact last night, I tried four more times.  In two more venv and I also installed anaconda and tried from there as well.
The “trial” on the QuickStart where you run in browser doesn’t work and never has for anyone I know.  The entire reason I am looking for other tutorials is because the docs don’t work as written.  At least for me and about five others over the months who have tried them.
I will post the new errors shortly.
Not being able to run the tutorials or the start docs are one of the main reasons I switched from Windows to Linux.  But that didn’t help at all.
I do appreciate it and I will post the errors next.
Thanks.

Also, did you change any of the filenames in the python-chatbot repository?  It looks like it's trying to clear a model directory but it's been given a domain file.

Okay. It seems we cannot use a venv to make this happen:
Following the instructions from Rasa Documentation: https://rasa.com/docs/core/installation/

mkdir RasaNoVenv
cd RasaNoVenv
pip3 install rasa_core
Apart from getting " Cache entry deserialization failed, entry ignored", after each entry, it does seem to install correctly afterwards.
pip3 install -U rasa_core
pip3 install rasa_nlu[tensorflow]
Now at Quickstart https://rasa.com/docs/core/quickstart/#quickstart
[In project top level directory] sudo nano stories.md, copy/paste:
`## happy path

greet

utter_greet

mood_great

utter_happy

sad path 1

greet

utter_greet

mood_unhappy

utter_cheer_up
utter_did_that_help

mood_affirm

utter_happy

sad path 2

greet

utter_greet

mood_unhappy

utter_cheer_up
utter_did_that_help

mood_deny

utter_goodbye

say goodbye

goodbye

utter_goodbye`

In project directory: sudo nano domain.yml, copy paste:
`intents:

greet
goodbye
mood_affirm
mood_deny
mood_great
mood_unhappy

actions:

utter_greet
utter_cheer_up
utter_did_that_help
utter_happy
utter_goodbye

templates:
utter_greet:

text: "Hey! How are you?"

utter_cheer_up:

text: "Here is something to cheer you up:"
image: "https://i.imgur.com/nGF1K8f.jpg"

utter_did_that_help:

text: "Did that help you?"

utter_happy:

text: "Great carry on!"

utter_goodbye:

text: "Bye"`

Now to train the dialogue model: $python3 -m rasa_core.train -d domain.yml -s stories.md -o models/dialogue
[Seems to work]

Final test, talking to the bot [from command line]:
$ python3 -m rasa_core.run -d models/dialogue
It WORKS!!!  NOT IN VENV.
===========================================================================
Now, I try the same thing in venv.

mkdir RasaInVenv

cd RasaInVenv

python3 -m venv .env

source .env/bin/activate [from Project Root]
[now activated (.env)$}

pip3 install rasa_core
[No Errors]

pip3 install -U rasa_core
[No Errors]

pip3 install rasa_nlu[tensorflow]
[no Errors]
Now at Quickstart https://rasa.com/docs/core/quickstart/#quickstart

[In project top level directory] sudo nano stories.md, copy/paste:
`## happy path

greet

utter_greet

mood_great

utter_happy

sad path 1

greet

utter_greet

mood_unhappy

utter_cheer_up
utter_did_that_help

mood_affirm

utter_happy

sad path 2

greet

utter_greet

mood_unhappy

utter_cheer_up
utter_did_that_help

mood_deny

utter_goodbye

say goodbye

goodbye

utter_goodbye`

In project directory: sudo nano domain.yml, copy paste:
`intents:

greet
goodbye
mood_affirm
mood_deny
mood_great
mood_unhappy

actions:

utter_greet
utter_cheer_up
utter_did_that_help
utter_happy
utter_goodbye

templates:
utter_greet:

text: "Hey! How are you?"

utter_cheer_up:

text: "Here is something to cheer you up:"
image: "https://i.imgur.com/nGF1K8f.jpg"

utter_did_that_help:

text: "Did that help you?"

utter_happy:

text: "Great carry on!"

utter_goodbye:

text: "Bye"`

Now to train the dialogue model: $python3 -m rasa_core.train -d domain.yml -s stories.md -o models/dialogue
[Still seems to work]
Final test IN A VENV, talking to the bot [from command line]:
$ python3 -m rasa_core.run -d models/dialogue
It WORKS!!!  *Also works now.

I AM TOTALLY CONFUSED.  I have tried this a million times to no satisfaction.
My only guess is that I copied the domain.yml and stories.md incorrectly.   I may have been copying the entire parts instead of JUST what is in between the """.
But your docs work now for me, on my Ubuntu 18.04 machine.  Both in and out of a VENV.
============================================================================
Thank you.
Thank you

I am now adding the nlu part.  Keeping the venv from the previous comment above:
11. $ sudo nano nlu.md
[from within the top level project directory]
`## intent:greet

hey
hello
hi
good morning
good evening
hey there

intent:goodbye

bye
goodbye
see you around
see you later

intent:mood_affirm

yes
indeed
of course
that sounds good
correct

intent:mood_deny

no
never
I don't think so
don't like that
no way
not really

intent:mood_great

perfect
very good
great
amazing
wonderful
I am feeling very good
I am great
I'm good

intent:mood_unhappy

sad
very sad
unhappy
bad
very bad
awful
terrible
not very good
extremly sad
so sad`

sudo nano nlu_config.yml [again from top level project directory]
language: en pipeline: tensorflow_embedding
[I already have Rasa NLU installed] so $python3 -m rasa_nlu.train -c nlu_config.yml --data nlu.md -o models --fixed_model_name nlu --project current --verbose
[ That worked.  It finished training.]
verify directory is created: $ ls models/current/nlu/
[All okay - its there]
Final test with NLU $python3 -m rasa_core.run -d models/dialogue -u models/current/nlu

It works!!!!!  Still thoroughly confused.  I don't know why it works now.  But your docs work in venv and I am assuming outside of a virtual environment as well.
Again thank you for your patience and help.
-DK

Cool, glad it worked!

Great!


Sell Orders not created during a pump.

I have noticed that when a pump starts when I first input the coin name the bot will keep producing the same message (waiting for coin to buy...)
Almost always, the coin ends up being bought almost instantly and at a fairly low price but no sell orders are created and the bot doesn't update further

no sell orders are created and the bot doesn't update further

What does the bot output when this happens?

It outputs only this line
Waiting for coin to buy...
it keeps outputting this multiple times (~100?)
then nothing further, no update once the buy order has been completed and no sell order issued

Okay I've added more logging now to the bot so if this happens again please send the log.txt file so we can see exactly what is happening.

I think its all from this:
waits until the buy order has been confirmed
while order['status'] != "FILLED":
print("Waiting for coin to buy...")
This function check value in dict order named status and nothing any more. Dict doest updated and we have infinite loop.

Good spot I'll query the order information and update the dictionary value to stop this loop.

Hmm it could be but I thought the order dictionary values automatically updated themselves with the order information after it had been fulfilled.

Need every time check that orders "FILLED" or "BUY" that now all orders selled.
https://github.com/sammchardy/python-binance/blob/f153d8651e91d67c0c125f3bb78d397edae0ab64/binance/client.py#L1674-L1713
Realize from another bot on github:
`def sell(self, symbol, quantity, orderId, sell_price, last_price):
    '''
    The specified limit will try to sell until it reaches.
    If not successful, the order will be canceled.
    '''

    buy_order = Orders.get_order(symbol, orderId)

    if buy_order['status'] == 'FILLED' and buy_order['side'] == 'BUY':
        #print('Buy order filled... Try sell...')
        self.logger.info('Buy order filled... Try sell...')
    else:
        time.sleep(self.WAIT_TIME_CHECK_BUY_SELL)
        if buy_order['status'] == 'FILLED' and buy_order['side'] == 'BUY':
            #print('Buy order filled after 0.1 second... Try sell...')
            self.logger.info('Buy order filled after 0.1 second... Try sell...')
        elif buy_order['status'] == 'PARTIALLY_FILLED' and buy_order['side'] == 'BUY':
            #print('Buy order partially filled... Try sell... Cancel remaining buy...')
            self.logger.info('Buy order partially filled... Try sell... Cancel remaining buy...')
            self.cancel(symbol, orderId)
        else:
            self.cancel(symbol, orderId)
            #print('Buy order fail (Not filled) Cancel order...')
            self.logger.warning('Buy order fail (Not filled) Cancel order...')
            self.order_id = 0
            return

    sell_order = Orders.sell_limit(symbol, quantity, sell_price)`

Why is it giving a lower purchase order than the instant coin price? Do you have the same problem?
Waiting for coin to buy...
This is because the order placed has a value lower than the current value. how can we fix this.  can not catch the price per second.

`
averagePrice = 0
for ticker in averagePrices:
if ticker["symbol"] == tradingPair:
averagePrice = ticker["wAvgPrice"]
if average price fails then get the current price of the trading pair (backup in case average price fails)
if averagePrice == 0: averagePrice = float(client.get_avg_price(symbol=`
It is necessary to buy at the current price of the trading pair, not the average price.

If you want to purchase the coin at a higher price increase your buyLimit parameter. The program buys at the average price to avoid pre-pumped coins, however it will buy the coin at the price UP TO whatever your buy limit parameter is set to. Eg if buyLimit is 1.5 then it will set limit order for the coin at a price 1.5 times the average price.


Godot 4 - Closing Running Game, still shows remote and local tabs

Details:

Issue description:
After closing the running game, the editor still thinks that is running:

Steps to reproduce:

create a simple scene
run game
close

Minimal reproduction project:
tt.zip

I'm unable to reproduce in current master (Linux). Can anyone confirm?

Can confirm this on windows. I will create a pr for this

Fixed by #48079.


Accessibility Issues in Edit Article Page

The below-mentioned issues are classified as critical, serious, and moderate.
Critical:

"aria-hidden='true' must not be present on the document body" 'helpUrl': Axe Rules | Deque University | Deque Systems

every form element has a label 'helpUrl': 'Axe Rules | Deque University | Deque Systems '

Serious:

The contrast between foreground and background colors should meet WCAG 2 AA contrast ratio thresholds. Elements must have sufficient color contrast.
'bgColor': None, 'contrastRatio': 0, 'expectedContrastRatio': '4.5:1', 'fgColor': '#212529' 'helpUrl': 'Axe Rules | Deque University | Deque Systems '

Document has a non-empty  element

Moderate:
Page doesn't have banner landmark, contentinfo landmark 'helpUrl': 'Axe Rules | Deque University | Deque Systems '

The accessibility tests run fine now in CI.


Update devfile tests with OCI-based registry

What type of PR is this?
/kind cleanup
What does this PR do / why we need it:
After moving to use OCI-based registry (https://github.com/openshift/odo/pull/4525), devfile tests should be using OCI-based registry as well.
Which issue(s) this PR fixes:
Related issues:
https://github.com/devfile/api/issues/367
https://github.com/openshift/odo/issues/4504
https://github.com/openshift/odo/pull/4525
PR acceptance criteria:

[x] Unit test

[x] Integration test

[ ] Documentation

[x] I have read the test guidelines

How to test changes / Special notes to the reviewer:
This PR is for changing test codes.

@mohammedzee1000 Looks like both:

https://registry.stage.devfile.io

and

https://registry.devfile.io

have the same content, why use different URLs?

@rnapoles-rh
I intentionally used two registries to test out different test cases against the official OCI-based registry vs. staging registry (contains the latest contents) and also to ensure the availability of the registries.
Here is the detail :

Official registry (https://registry.devfile.io) updated weekly vs. staging registry(https://registry.stage.devfile.io) updated with PR merges.
odo registry command test uses the official registry as it doesn't cause much overload on the public registry vs. odo catalog test uses the staging registry to avoid potential overload on the official registry.

@GeekArthur - please review. Thanks,

@mohammedzee1000 Looks like both:

https://registry.stage.devfile.io

and

https://registry.devfile.io

have the same content, why use different URLs?

@rnapoles-rh
I intentionally used two registries to test out different test cases against the official OCI-based registry vs. staging registry (contains the latest contents) and also to ensure the availability of both registries.
Here is the detail :

Official registry (https://registry.devfile.io) updated weekly vs. staging registry(https://registry.stage.devfile.io) updated with PR merges.
odo registry command test uses the official registry as it doesn't cause much overload on the public registry vs. odo catalog test uses the staging registry to avoid potential overload on the official registry.

So odo tests would fail if there is breaking changing in the staging registry? wouldn't that block us?

So odo tests would fail if there is breaking changing in the staging registry? wouldn't that block us?

Even I do feel the same. @josephca Currently the breaking changes in Official registry are bothering us more and now it seems like we need to deal with staging one as well, no?

So odo tests would fail if there is breaking changing in the staging registry? wouldn't that block us?

Even I do feel the same. @josephca Currently the breaking changes in devfile registry are bothering us more and now it seems like we need to deal with staging one as well, no?

@girishramnani @prietyc123 Thanks for your inputs.
After discussion with devfile service team, it would be sufficient to test only with staging server. In addition, they will try to get some telemetry data in the future to track usage patterns on the community registry. Therefore, it will be good to use the staging server for testing to avoid polluting the data.
That said, I will update the code to use the staging server only.

/retest

/retest

/assign @rnapoles-rh


Any Update on getting into the ServiceNow Store?

I know an Issue may not be the appropriate place to put this, but didn't know where else to ask it.
I'm really impressed with this plugin (the "Official" ServiceNow data source plugin for Grafana is pretty bare bones and a real pain to work with).  This plugin on the other hand looks incredible.  The biggest issue is that there's no way our ServiceNow team will let us install an app that isn't from the app store in our Production ServiceNow instance.
Are you relatively close to getting it into the Store?  If so, then I'm sure I can get it into our Dev ServiceNow instance and install the plugin in our Grafana environment for now to get a feel for it and start working on familiarizing myself with the plugin so that, when it does officially release in the SNOW Store, I can fast track getting it into our production instance.
Honestly, if this plugin works as good as it looks, you could charge for it.  The dashboards alone are worth money!

Hello @jHumeLPL,
I am pleased to announce our official release to the ServiceNow store!
You can find the ITOM Grafana Plugin in the store at this link: https://store.servicenow.com/sn_appstore_store.do#!/store/application/c9d5fc3a1bf08990ba4d15c61a4bcb03/1.8.0
I will proceed to close this issue now but do not hesitate to create a new issue if one arises.


Support for solaire-mode

solaire-mode looks pretty cool, but requires a specific set of faces to be defined:
solaire-default-face
solaire-minibuffer-face
solaire-linum-face
solaire-linum-highlight-face
solaire-hl-line-face
solaire-org-hide-face
solaire-mode-line-face
solaire-mode-line-inactive-face

I've been looking at this as well. It's pretty interesting. However, I'm not sure what the best faces would be. I've tried brightening up the minibuffer and I've tried the main window, but I'm not sure I like anything I've come up with yet.
PRs would be welcome!

Oh, I'm glad it's not just me! I tried briefly yesterday but couldn't make it satisfactory. I'll submit a PR if make something I'm happy with.

I've been working to get this to a satisfactory point for me, but I'm having trouble wrapping my head around how to create the faces outside of the theme itself (so I can test the colors out before I modify base16-theme.el to craft a PR). I'll keep working and get something soon-ish.

@bbenne10 I've got a use-package block in my dotfiles which sort of gives away how I do local dev:
https://github.com/belak/dotfiles/blob/master/emacs.d/README.org#base16-theme
The general idea is that I clone all packages I work on to ~/.emacs.d/site-lisp then add those dirs to the load-path and then require them, along with any other tweaks which need to be done.
One of the oddities is that all of the theme files are in the build dir, so that needs to be added to the custom-theme-load-path.

No progress, but mostly because I've forgotten. I might have some time this weekend to get around to it :P

No rush. Thanks for following up! I've been a bit busy myself as well, so I can understand.

After 6 months of nothing, I have gotten frustrated enough with another color scheme that I wanted to come back to this problem. (I would also be lying to say that its not bugging me simply because this is "assigned to me" but I've not done anything about it)
To simplify the below discussion, I will assume we're always discussing modifying the colors for non-file-backed buffers only. Base16's concepts are pretty strict and I would say that this applies to "editors", which traditionally means "editors editing files" so I feel this is a decent  assumption.
I see a few  complications for implementing this in such a way as to not look like crap. Base16's general scheme is REALLY narrowly defined. Solaire somewhat requires a bit of...tinting to make the non-file based buffers stand out from file-backed ones but at the same time not burn your retinas out. This is difficult to do when you're limited to 16 colors.
This is further complicated by the fact that the global base16 colorscheme uses the bottom-most color as the "background" which means that there's no way to go "darker" (or "lighter" in light themes). (there's no "base-01" to fall back to, essentially).
What I might propose is a way of slightly darkening a provided hex color (such a function can sort of be found here, though this operates at point and replaces the contents rather than evaluating to the color in question. but the basic functionality is there).
For instance, I have hacked solaire support onto the zerodark theme. It looks like this (ignore that I'm an idiot and mis-hit my dmenu-bind and so am searching for a project :P)
I feel this looks pretty decent and would port pretty well into base16 if we could add the additional colors to support it. A remaining question would then be "Is darkening like this the right answer for light themes?". I have no idea (I despise light themes in general, so it'd be hard for me to judge), but it's a good place to start.
HOWEVER, one might argue that this attacks the very idea of base16 (and can't REALLY be done portably between implementations of the base16 schemes, since using this at a shell without truecolor support would essentially be impossible). In that case, I don't think solaire-mode's goals are in line with the base16 project, and I don't think there's really a resolution to that problem.
So what does this mean practically? If there's no objection, I'll probably implement a basic "darken by 10%" function that takes a color and returns a darkened version and use that globally until someone comes along and complains. Once that happens, we can have a discussion about a more nuanced solution. Anyone have thoughts here?

That seems reasonable to me. I think stuff like that is fine as long as it's used sparingly and there's a good reason for it, both of which seem to fit this situation. The other option is a function to mix colors, which might be more flexible (if that's too complicated don't worry too much). Your proposed solution could also provide a better option for diff colors.
A few things to note: it's a little hard to put function calls into the theme itself so they might go well where we handle settings... And I'm not sure how to handle darkening when in the terminal... Might have to only enable it if you're using >= 256 colors. I'd be happy to help with the plumbing for that if you need it.

Okay! I've finally (FINALLY) found a day to sit down and work on this!
My first approach was to add solaire-mode faces that make some sense into base16-theme-define and adding a new defcustom for making them look distinct. I'm not sure this resolves the problem of running at a terminal though because we're looking at a specific color/key combo in base16-transform-color-key (and thus have already been passed the modified color map)
Another solution is to simply offer a function that can be called to MODIFY the already specified theme. In this case, we can fix the terminal colorscheme problem by lifting the issue to the user space
(require 'base16-theme)
(load-theme base16-gruvbox-dark-medium)
(if 'display-graphic-p
  (base16-inject-solaire-faces) ;; or something
)

This is, however, not in line with the rest of the customizations offered by this theme group already.
I have started pursuing this approach, as it solves most of the integration problems pretty nicely, even if it is inconsistent with existing code.
In this second approach, we simply use defface and do some mucking around with the color variables to assign custom colors. @belak: Thoughts?

Just an update: So I have a basic implementation of the color modification (i've yet to build the faces, but that's not going to be difficult, so I'm leaving it till last). I had, however, forgotten the case where the source color isn't a hexadecimal color but rather a built-in color name. There's a path forward for these cases (color-name-to-rgb in color.el, but divide by 65535.0 to scale between 0 and 1), but the hard part is detecting them as my current approach assumes that the input is either an rgb list ((1.0 0.25 0.75)) or a hexadecimal string to convert to an rgb list.
I'm implementing a regex based solution that should fix this issue, but it's taking a while...I'm definitely feeling the fact that elisp was born in 1985. I should have something to show this evening after dinner.

One thing I've been thinking about - and I don't know why I didn't think of this before - you can call base16-set-faces multiple times. Would it work to just call that multiple times in base16-theme-define with different values depending on the settings?

Oh! I didn't recognize that base16-set-faces could be called multiple times. That'll make integration with a defcustom much easier.


Increment version for identity releases

Increment package version after release of com.azure azure-identity

@g2vinay can we merge this PR?


configure is redundant in build instructions

README.md says you can build vorbis from master like this:
./autogen.sh
./configure
make

However, autogen.sh already runs configure at the end:
...
$srcdir/configure --enable-maintainer-mode "$@" && echo

This doesn't seem to be true, I had to run configure separately after running autogen.

autogen.sh used to look different: https://github.com/xiph/vorbis/commit/4729a15df74cd4d6fc487a43157bf9fb65d12218
This issue seems to be fixed now!


Accessibility: WCAG 2.1 Level A: [4.1.2 Name, Role, Value]

Ensures interactive controls are not nested as they are not always announced by screen readers or can cause focus problems for assistive technologies
Impact: serious
Violations WCAG 2.1 Level A: [4.1.2 Name, Role, Value]
(https://www.w3.org/WAI/WCAG21/Understanding/name-role-value.html)

@rnunez80 cannot reproduce using latest version, if you still encounter this issue please add a new comment with screenshot that shows the item in question failiing


[CAT-271] Remove DocExtraction and ModelGroupPredict Stuff from Docs

Summary

just make sure the codeship build is passing before you merge


spi: introduce Result abstraction

Fix #363

Ok, I think I reached a stable point in defining the design.
The proposal contained in this PR is to introduce an AbstractResult, that represent a result object that can be a success or a failure.
The success case will bring an object that represents the content of the computation,
while the failure case bring an object that represents the failure of the computation.
The simpler failure is the one that report a list of messages, it's used in the Result extension class that covers the majority of the cases.
If some other details are needed (e.g. a status that can differentiate a simple error from a fatal one, like DataFlowInitiateResult) it's enough to extend AbstractResult setting as failure an extension of the Failure class.
In this way things are extensible and pretty clear (at least to me :) ).
I put the result core classes here: https://github.com/BMW-InnovationLab/DataSpaceConnector/tree/abstract-result/spi/src/main/java/org/eclipse/dataspaceconnector/spi/result
Attention points:

This PR become quite big, so I'm not sure if this PR deserves to be merged eventually or instead we should introduce the AbstractResult/Result/Failure classes and then fix the duplication in some other PRs therefore
I found a case that can't fit well with this implementation, is the QueryResponse, that provides a successful state with errors attached. This is a different pattern and should be left as it is.

Ok, I think I reached a stable point in defining the design. The proposal contained in this PR is to introduce an AbstractResult, that represent a result object that can be a success or a failure. The success case will bring an object that represents the content of the computation, while the failure case bring an object that represents the failure of the computation. The simpler failure is the one that report a list of messages, it's used in the Result extension class that covers the majority of the cases. If some other details are needed (e.g. a status that can differentiate a simple error from a fatal one, like DataFlowInitiateResult) it's enough to extend AbstractResult setting as failure an extension of the Failure class. In this way things are extensible and pretty clear (at least to me :) ). I put the result core classes here: https://github.com/BMW-InnovationLab/DataSpaceConnector/tree/abstract-result/spi/src/main/java/org/eclipse/dataspaceconnector/spi/result

Hi @ndr-brt this looks really promising. I took a look at DataFlowInitiateResult and the case of distinguishing fatal and non-fatal errors. Given that this PR is quite large, and it may benefit others to see this, can you paste in a quick example of how client code would use DataFlowInitiateResult and distinguish between the three result case? I this it would also be worth documenting the fatal vs. non-fatal extension case this on the AbstractResult class itself in general terms.

Sure, the example is shown in the code of TransferProcessManagerImpl:
if (ResponseStatus.ERROR_RETRY == response.getFailure().status()) {
    monitor.severe("Error processing transfer request. Setting to retry: " + process.getId());
    process.transitionProvisioned();
    transferProcessStore.update(process);
    invokeForEach(l -> l.provisioned(process));
} else if (ResponseStatus.FATAL_ERROR == response.getFailure().status()) {
    monitor.severe(format("Fatal error processing transfer request: %s. Error details: %s", process.getId(), String.join(", ", response.getFailureMessages())));
    process.transitionError(response.getFailureMessages().stream().findFirst().orElse(""));
    transferProcessStore.update(process);
    invokeForEach(l -> l.error(process));
} else {
    if (process.getDataRequest().getTransferType().isFinite()) {
        process.transitionInProgress();
    } else {
        process.transitionStreaming();
    }
    transferProcessStore.update(process);
    invokeForEach(l -> l.inProgress(process));
}

I think that, with this design, will be up to those who'll need a particular failure to be handled in different ways to extend the AbstractResult and Failure classes to fit their needs. Or, if this case (the fatal/not fatal one) is generic enough we can provide an generic implementation too in the spi (I just noticed that DataFlowInitiateResult and TransferInitiateResult are pretty similar and also NegotiationResult is not that different)

Hi, @ndr-brt if you think this is ready to merge, do you want to let us know? My preference would be to get this in ASAP and we can always make subsequent changes in separate PRs


Example project won't fetch release.

Bare repo and running this from the Example folder:
mix do deps.get, firmware, firmware.burn
Getting:
Resolving Nerves artifacts...
Resolving kiosk_system_rpi3
=> Trying https://github.com/letoteteam/kiosk_system_rpi3/releases/download/v1.4.0/kiosk_system_rpi3-portable-1.4.0-4DEE659.tar.gz
Status 404 Not Found
=> Trying https://github.com/letoteteam/kiosk_system_rpi3/releases/download/v1.4.0/kiosk_system_rpi3-portable-1.4.0-4DEE659A35C76203D45AB87DFED9B396D1B098CC6DCA5CD322D4C5BFDAE4BB67.tar.gz
Status 404 Not Found
=> no_result
Cached nerves_toolchain_arm_unknown_linux_gnueabihf
Mac OS high sierra.

I need to change the kiosk_system reference to:

defp system("rpi3"), do: [{:kiosk_system_rpi3, "~> 1.0"}]


Webpack warning when importing in create-react-app generated project

import ReactMapboxGl, { Layer, Feature } from 'react-mapbox-gl'

./~/mapbox-gl/dist/mapbox-gl.js
Critical dependencies:
1:481-488 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
 @ ./~/mapbox-gl/dist/mapbox-gl.js 1:481-488

Yes that's an error thrown by mapbox-gl because react-mapbox-gl is using a bundled version of mapbox-gl which is the only way to use it with webpack see https://github.com/mapbox/mapbox-gl-js/blob/master/INSTALL.md#using-mapbox-with-other-module-systems


Updated keyboard to be more user centric

I've updated the keyboard to be more user centric.

Thanks @bloodf , this re-arrangement was very much needed!

@all-contributors please add @bloodf for ideas, design


[Bug] Windows Metrics Name -- "Swap" => "Virtual Memory"

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
OAP server (apache/skywalking)
What happened
Windows metrics that include swap are from 'virtual memory', but swap is not equal to virtual memory.
With MSINFO32.exe, we could see resources' current status, including physical memory and virtual memory and page file size.
As I know, [Virtual Memory] = [Physical Memroy] + [Swap].
And Zabbix Agent read swap number is page file.
What you expected to happen
Rename metrics:

memory_swap_free => memory_virtual_memory_free
memory_swap_total => memory_virtual_memory_total
memory_swap_percentage => memory_virtual_memory_percentage

(There is two 'memory' in each metry, so may have another better name.)
How to reproduce
remove document or table - ui_template_Windows-Service - in database, or using empty database.
Anything else
No response
Are you willing to submit a pull request to fix on your own?

[X] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

And Zabbix Agent read swap number is page file.

What does this mean?

And Zabbix Agent read swap number is page file.

What does this mean?

I found this problem is because the value in Zabbix Dashboard different from SkyWalking Monitor.
In Zabbix, the labels are 'Free swap space', 'Total swap space', 'Free swap space in %'


Can't deploy to Rinkeby or Run Test for test_can_pick_winner

I thought as first it is because vrf_coordinator adress, keyhash and the fee have changed. So i made the following changes.
  rinkeby:
    vrf_coordinator: "0x6168499c0cFfCaCD319c818142124B7A15E857ab"
    eth_usd_price_feed: "0x8A753747A1Fa494EC906cE90E9f37563A8AF630e"
    link_token: "0x01BE23585060835E02B77ef475b0Cc51aA1e0709"
    keyhash: "0xd89b2bf150e3b9e13446986e571fb9cab24b13cea0a43ea20a6049a85cc807cc"
    fee:<PHONE_NUMBER>00000000
    verfiy: True

But i still keep on getting this vague error when running the test :
brownie test -k test_can_pick_winner --network rinkeby -s
tests/test_lottery_integration.py::test_can_pick_winner RUNNING
Deployed lottery!
Fund contract!
tests/test_lottery_integration.py::test_can_pick_winner FAILED
tests/test_lottery_unit.py::test_can_pick_winner_correctly SKIPPED
======================================== FAILURES ========================================
__________________________________ test_can_pick_winner __________________________________
def test_can_pick_winner():
    if network.show_active() in LOCAL_BLOCKCHAIN_ENVIRONMENTS:
        pytest.skip()
    lottery = deploy_lottery()
    account = get_account()
    lottery.startLottery({"from": account})
    lottery.enter({"from": account, "value": lottery.getEntranceFee()})
    lottery.enter({"from": account, "value": lottery.getEntranceFee()})
    fund_with_link(lottery)

  lottery.endLottery({"from": account})

E       ValueError: Gas estimation failed: 'execution reverted'. This transaction will likely revert. If you wish to broadcast, you must set the gas limit manually.
tests/test_lottery_integration.py:21: ValueError
Any help would be very appreciated, thanks!

Ive tried setting a manual large gas fee as well :
lottery.endLottery({"from": account, "gas_limit": 100000000})
but now it throws me another error
'''
E       ValueError: Execution reverted during call: 'execution reverted'. This transaction will likely revert. If you wish to broadcast, include allow_revert:True as a transaction parameter.
tests/test_lottery_integration.py:21: ValueError
'''
Thanks for any help!

https://docs.chain.link/docs/vrf-contracts/v1/
My mistake was that i was using vrf v2 addresses but v1 is still available but on the link above. Thanks!


Change newsroom to statically built and trigger build/deploy with Sanity webhook

Set up webhook similar to newsletter triggering in Sanity,
that when a new news article (which should update newsroom) is published a workflow for building and deploying new web global is triggered.
Change newsrooms to statically build pages, remove ssr configurations.
Take back Algolia filters/hits and can remove the request to fetch newsarticles from sanity.

@meols Newsroom is back with Algolia..
Please test if publishing a news article is reflected immediately on the newsroom. ( If newsroom is already opened, it needs a refresh).
The newsroom page is revalidated similar to how the home page is revalidated for latest newsarticles


updated feedstock to version 0.0.25

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

import: 'pystem'
import: 'pystem'
+ pip check
pystem 0.0.25 requires numba, which is not installed.

import: 'pystem'
import: 'pystem'
+ pip check
pystem 0.0.25 requires numba, which is not installed.


ListObjectsAsync - IAsyncEnumerable, but not GetAsyncEnumerator()

I see that ListObjectsAsync returns a PagedAsyncEnumerable. Forgive me if I'm missing a subtlety of async (it would not be the first time). But it seems to not play very nicely with C# 8.0?
I think if the GetEnumerator method was instead called GetAsyncEnumerator, I could use await foreach? It'd be a good advantage since I think all the syntactic sugar means I can .Select() on that to abstract the underlying Data.Object for consumers of my API.
Edit: also, I tried to make a wrapper class to handle this. But so long as Google.Cloud.Storage.V1 was referenced, the System.Interactive.Async package conflicted: the IAsyncEnumerator type was defined both in that and the System.Runtime package. Is System.Interactive.Async no longer needed perhaps?
Ah, in fact, even if I refer to IAsyncEnumerator anywhere in my code, I get that conflict.

The IAsyncEnumerable<T> used in all of the released packages is the one from System.Interactive.Async 3.2. We are actively working on migrating this as part of a major version bump, tracked in #3519. It's a massive job though, partly as at the same time we're changing the code generator used for API-specific generation... which in turn involves changing how each API is configured.
We're making steady progress, and hoping for betas in late January / early February, hopefully with a GA in late February / early March. For more details, see the major version plan document
If you're massively eager to try this, the code in the next-major-version branch uses the new version of GAX (which is in the GAX master branch but not released on nuget.org yet). If you run ./build.sh Google.Cloud.Storage.V1 from the root of the next-major-version branch, you'll that will fetch GAX and build it locally, and you'll end up with a Google.Cloud.Storage.V1 build which will work with await foreach. But you may just want to wait for the releases :)
I'll close this issue now as it's already being tracked effectively in #3519.

Ah thats great thanks. I apologise I didnt find the existing issue.

Not a problem at all - it's not exactly obvious that the gRPC upgrade is related to async sequences (although that's actually why gRPC took a major version bump too).


feat(remotes): add remotes and configs

Closes # (issue)
No issues closed by this, but a complement of : https://github.com/evilmartians/lefthook/pull/343 /
https://github.com/evilmartians/lefthook/discussions/420
:zap: Summary
Evolution of remote configuration, enabling the integration of multiple configurations from one or more different repositories.
Example :
# lefthook.yml

remotes:
  - git_url: git@github.com:evilmartians/remote
    ref: v1.0.0
    configs:
      - examples/ruby-linter.yml
      - examples/test.yml
  - git_url : https://github.com:example/repository
    configs:
      - lefthooks/pre_commit.yml
      - lefthooks/post_merge.yml
  - git_url : https://github.com:example2/repository2
    ref: specific_branch
    configs:
      - example/pre-push.yml

I have retained the old functionality with a single remote and a single config, which is still operational (but deprecated).
I needed to add an exclusion of gocyclo for the TestLoad function (internal/config/load_test.go) because it was reporting excessively high complexity. However, it doesn't seem critical since it's an addition of a test for the new feature.
Additionally, I tried to add deprecation messages for those still using 'remote' and 'config,' but it breaks the tests. Do you have a solution to avoid this?
I hope this work suits you well; feel free to provide feedback if needed!
:ballot_box_with_check: Checklist

[x] Check locally
[x] Add tests
[x] Add documentation

Wow, that's an amazing work! Thank you a lot! I will take a look at the PR this week and come back with the feedback.


Evaluator keeps evaluating the same corrupt run

Example: run 2766675
An error message should be added to Run_evaluated to skip over the run
[02-07-2017 21:42:27] [ERROR] [Process Run] An error occured during API call: Problem validating uploaded description file: XML does not correspond to XSD schema.
org.openml.apiconnector.io.ApiException: Problem validating uploaded description file: XML does not correspond to XSD schema.
        at org.openml.apiconnector.io.HttpConnector.readHttpResponse(HttpConnector.java:110)
        at org.openml.apiconnector.io.HttpConnector.doApiRequest(HttpConnector.java:47)
        at org.openml.apiconnector.io.OpenmlConnector.runEvaluate(OpenmlConnector.java:864)
        at org.openml.webapplication.EvaluateRun.evaluate(EvaluateRun.java:219)
        at org.openml.webapplication.EvaluateRun.<init>(EvaluateRun.java:66)
        at org.openml.webapplication.Main.main(Main.java:94)
[02-07-2017 21:42:27] [INFO] [Evaluate Run] Downloading task 2766675

These faulty runs seem to come from Weka, from a specific user:
https://www.openml.org/u/1856/runs


Post user status

User statuses are now stored with posts. They will be displayed on post/:postID pages instead of the post creator's current status. When a user changes their status, their posts will not update the user status ID value.

LGTM!
Great work!


Update limitations page to warn users that naming a gateway with the same name as a container causes an error

What content needs to be created or modified?
The known limitations page
Describe the solution you'd like
Add a warning for users on the steps that lead to this error
Additional context

Bug filed: https://github.com/radius-project/radius/issues/7149

AB#11141

PR merged


API: Rebrand Docs to Universal API

The API approach in Slate Kit is Protocol Independent, but rephrase this as Universal APIs in the site docs and respective locations

Updated on website


Updated bento location with Parallels support

Chef has removed their previous Vagrant box repo, leaving an invalid link in settler. The new bento base boxes support the parallels provider. I made a few minor revisions to extend that support to settler.

Updated.


v7.6.1 is tagged as v.7.6.1 in Docker Hub

Release v7.6.1 (see https://github.com/zricethezav/gitleaks/releases) is tagged as v.7.6.1 (note the extra . after v) in Docker Hub (see https://hub.docker.com/r/zricethezav/gitleaks/tags)
cc @zricethezav

@ashokm thanks for pointing that out, pushing fix now

@ashokm https://hub.docker.com/layers/zricethezav/gitleaks/v7.6.1/images/sha256-66a8b46e267c4331b2902c7354ca6b31833603fbe35b9ab443c9b00d9ebee100?context=repo