Sending a event with a lot of custom payload fails with HTTP error status 404 Not Found

Describe the bug
Sending an event with a custom fragment that exeeds the mqtt limit so that it will be sent over SmartREST fails with
ERROR c8y_mapper_ext::converter: Mapping error: Failed with HTTP error status 404 Not Found
To Reproduce
Send the following event:
topic: tedge/events/recording
payload:
{"type":"recording","time":"2023-09-07T15:10:46Z","text":"New recording","recording":{"type":"recording","data":[{"p":69.954765,"s":[-2,-4,0,1]},{"p":69.857060,"s":[-2,-4,1,1]},{"p":69.783790,"s":[-2,-4,1,1]},{"p":69.686090,"s":[-2,-4,1,1]},{"p":69.612816,"s":[-2,-4,1,1]},{"p":69.515114,"s":[-2,-4,0,1]},{"p":69.441840,"s":[-2,-4,0,1]},{"p":69.344140,"s":[-2,-4,-1,1]},{"p":69.270870,"s":[-2,-4,-2,1]},{"p":69.173164,"s":[-2,-4,-4,1]},{"p":69.075460,"s":[-2,-4,-5,1]},{"p":68.977770,"s":[-2,-4,-6,1]},{"p":68.880066,"s":[-2,-4,-7,0]},{"p":68.782364,"s":[-2,-4,-9,0]},{"p":68.709090,"s":[-2,-5,-10,0]},{"p":68.586970,"s":[-2,-5,-11,-1]},{"p":68.513690,"s":[-2,-5,-12,-1]},{"p":68.415985,"s":[-1,-5,-13,-2]},{"p":68.318290,"s":[-1,-5,-13,-3]},{"p":68.245010,"s":[-1,-5,-14,-3]},{"p":68.122890,"s":[-1,-5,-13,-4]},{"p":68.049614,"s":[-1,-5,-13,-4]},{"p":67.927490,"s":[-1,-5,-12,-5]},{"p":67.854210,"s":[-1,-5,-12,-5]},{"p":67.756516,"s":[-1,-5,-11,-5]},{"p":67.683235,"s":[-1,-5,-10,-5]},{"p":67.609960,"s":[-1,-5,-9,-4]},{"p":67.512260,"s":[-1,-6,-8,-4]},{"p":67.438990,"s":[-1,-6,-7,-3]},{"p":67.365715,"s":[-1,-6,-6,-3]},{"p":67.292435,"s":[-1,-6,-5,-2]},{"p":67.219160,"s":[-1,-6,-4,-2]},{"p":67.145890,"s":[-1,-6,-4,-1]},{"p":67.072610,"s":[-1,-6,-3,-1]},{"p":66.974915,"s":[-1,-6,-3,0]},{"p":66.901634,"s":[-1,-6,-3,0]},{"p":66.828360,"s":[-1,-6,-3,0]},{"p":66.730660,"s":[-1,-6,-3,0]},{"p":66.632960,"s":[-1,-6,-4,0]},{"p":66.510830,"s":[0,-5,-4,0]},{"p":66.413130,"s":[0,-5,-5,-1]},{"p":66.315440,"s":[0,-5,-5,-1]},{"p":66.217735,"s":[0,-5,-6,-1]},{"p":66.120030,"s":[0,-5,-7,-1]},{"p":66.022330,"s":[1,-5,-8,-2]},{"p":65.924640,"s":[1,-5,-9,-2]},{"p":65.826935,"s":[1,-5,-10,-2]},{"p":65.729230,"s":[1,-5,-11,-2]},{"p":65.655960,"s":[1,-5,-12,-2]},{"p":65.558260,"s":[1,-5,-12,-2]},{"p":65.460556,"s":[1,-5,-13,-3]},{"p":65.387280,"s":[1,-5,-14,-3]},{"p":65.314010,"s":[1,-5,-14,-3]},{"p":65.240730,"s":[1,-5,-15,-3]},{"p":65.143036,"s":[1,-5,-15,-3]},{"p":65.069756,"s":[1,-5,-15,-3]},{"p":64.972050,"s":[1,-5,-14,-3]},{"p":64.898780,"s":[1,-5,-14,-3]},{"p":64.801080,"s":[1,-5,-13,-4]},{"p":64.727806,"s":[1,-5,-13,-4]},{"p":64.630104,"s":[1,-5,-12,-4]},{"p":64.532410,"s":[1,-5,-11,-4]},{"p":64.459130,"s":[1,-5,-10,-4]},{"p":64.337006,"s":[1,-5,-9,-3]},{"p":64.263730,"s":[1,-5,-8,-3]},{"p":64.190450,"s":[1,-5,-8,-2]},{"p":64.117180,"s":[1,-5,-8,-2]},{"p":64.043910,"s":[1,-5,-7,-1]},{"p":63.970630,"s":[1,-5,-7,-1]},{"p":63.872930,"s":[1,-5,-7,0]},{"p":63.799656,"s":[1,-5,-8,0]},{"p":63.726380,"s":[1,-5,-8,0]},{"p":63.653103,"s":[1,-5,-9,0]},{"p":63.555405,"s":[1,-5,-9,0]},{"p":63.482130,"s":[1,-5,-10,0]},{"p":63.384430,"s":[1,-5,-10,0]},{"p":63.311153,"s":[1,-5,-11,0]},{"p":63.213455,"s":[1,-5,-11,-1]},{"p":63.115753,"s":[1,-5,-12,-1]},{"p":62.993630,"s":[2,-5,-12,-2]},{"p":62.871502,"s":[2,-5,-12,-2]},{"p":62.798230,"s":[2,-5,-12,-2]},{"p":62.700527,"s":[2,-5,-12,-3]},{"p":62.602830,"s":[2,-4,-12,-3]},{"p":62.480700,"s":[2,-4,-11,-3]},{"p":62.383003,"s":[2,-4,-11,-3]},{"p":62.309727,"s":[2,-4,-11,-2]},{"p":62.212025,"s":[2,-5,-11,-2]},{"p":62.089900,"s":[2,-5,-10,-1]},{"p":62.016624,"s":[2,-5,-10,-1]},{"p":61.943350,"s":[2,-5,-10,0]},{"p":61.870075,"s":[2,-5,-10,0]},{"p":61.796800,"s":[2,-5,-10,0]},{"p":61.699100,"s":[2,-5,-10,0]},{"p":61.552550,"s":[2,-5,-9,1]},{"p":61.454850,"s":[2,-5,-9,1]},{"p":61.357150,"s":[2,-6,-9,0]},{"p":61.259450,"s":[2,-5,-9,0]},{"p":61.186172,"s":[2,-5,-8,0]},{"p":61.064050,"s":[3,-5,-8,0]},{"p":60.966350,"s":[2,-5,-8,0]},{"p":60.868650,"s":[2,-5,-7,0]},{"p":60.770950,"s":[2,-5,-7,0]},{"p":60.697674,"s":[2,-6,-7,0]},{"p":60.624397,"s":[2,-6,-7,0]},{"p":60.526700,"s":[2,-6,-7,1]},{"p":60.453423,"s":[1,-6,-7,1]},{"p":60.380146,"s":[1,-6,-7,1]},{"p":60.306873,"s":[1,-6,-8,1]},{"p":60.233597,"s":[1,-6,-8,1]},{"p":60.135900,"s":[0,-7,-8,1]},{"p":60.062622,"s":[0,-7,-8,1]},{"p":59.989346,"s":[0,-7,-8,1]},{"p":59.891647,"s":[0,-7,-7,0]},{"p":59.818370,"s":[0,-7,-7,0]},{"p":59.720673,"s":[0,-7,-6,-1]},{"p":59.622970,"s":[-1,-7,-5,-2]},{"p":59.549698,"s":[-1,-7,-4,-3]},{"p":59.451996,"s":[-1,-7,-3,-4]},{"p":59.354294,"s":[-1,-7,-2,-5]},{"p":59.256596,"s":[-1,-7,0,-6]},{"p":59.183320,"s":[-1,-7,1,-7]},{"p":59.110046,"s":[-1,-7,3,-7]},{"p":59.012344,"s":[-1,-7,4,-8]},{"p":58.890220,"s":[-2,-7,7,-9]},{"p":58.792520,"s":[-2,-7,9,-10]},{"p":58.719246,"s":[-2,-7,10,-11]},{"p":58.645970,"s":[-2,-7,12,-11]},{"p":58.572693,"s":[-2,-7,13,-12]},{"p":58.474995,"s":[-2,-7,15,-13]},{"p":58.401720,"s":[-2,-7,16,-14]},{"p":58.304020,"s":[-2,-7,18,-16]},{"p":58.230743,"s":[-2,-7,20,-17]},{"p":58.133040,"s":[-1,-6,22,-19]},{"p":58.010918,"s":[-1,-6,24,-20]},{"p":57.913220,"s":[0,-6,26,-22]},{"p":57.791092,"s":[0,-5,29,-24]},{"p":57.693394,"s":[1,-4,32,-26]},{"p":57.595690,"s":[1,-4,36,-28]},{"p":57.497993,"s":[2,-3,39,-30]},{"p":57.375866,"s":[2,-2,43,-32]},{"p":57.278168,"s":[3,0,47,-33]},{"p":57.180466,"s":[3,1,50,-34]},{"p":57.107193,"s":[4,2,55,-36]},{"p":56.985065,"s":[4,4,59,-37]},{"p":56.911790,"s":[5,6,63,-38]},{"p":56.814090,"s":[5,8,68,-39]},{"p":56.716390,"s":[6,11,71,-41]},{"p":56.618690,"s":[7,13,76,-42]},{"p":56.520990,"s":[8,16,81,-44]},{"p":56.447716,"s":[9,19,85,-46]},{"p":56.350014,"s":[10,23,90,-48]},{"p":56.252316,"s":[11,26,94,-50]},{"p":56.154613,"s":[12,29,99,-52]},{"p":56.032490,"s":[14,33,104,-55]},{"p":55.934788,"s":[16,37,110,-58]},{"p":55.837090,"s":[18,41,117,-60]},{"p":55.739388,"s":[19,44,123,-63]},{"p":55.641690,"s":[22,48,130,-66]},{"p":55.543987,"s":[24,53,137,-70]},{"p":55.421864,"s":[26,56,145,-73]},{"p":55.348587,"s":[28,61,153,-76]},{"p":55.275314,"s":[31,65,160,-80]},{"p":55.177612,"s":[33,70,168,-84]},{"p":55.079910,"s":[36,75,175,-88]},{"p":55.006638,"s":[39,79,183,-92]},{"p":54.908936,"s":[42,84,191,-97]},{"p":54.835663,"s":[44,89,198,-102]},{"p":54.737960,"s":[47,94,205,-107]},{"p":54.640263,"s":[50,99,211,-113]},{"p":54.566986,"s":[53,105,218,-120]},{"p":54.469284,"s":[56,110,225,-126]},{"p":54.347160,"s":[59,115,232,-134]},{"p":54.273884,"s":[62,121,239,-141]},{"p":54.176186,"s":[65,126,246,-149]},{"p":54.054060,"s":[69,131,255,-157]},{"p":53.956360,"s":[72,137,263,-165]},{"p":53.858658,"s":[76,142,272,-174]},{"p":53.760960,"s":[80,148,282,-182]},{"p":53.663258,"s":[83,153,291,-191]},{"p":53.565560,"s":[87,159,302,-200]},{"p":53.467857,"s":[90,165,313,-209]},{"p":53.394585,"s":[95,170,324,-218]},{"p":53.296883,"s":[99,175,336,-226]},{"p":53.223610,"s":[102,180,347,-236]},{"p":53.125908,"s":[107,186,359,-245]},{"p":53.052630,"s":[110,192,370,-255]},{"p":52.954933,"s":[115,196,381,-264]},{"p":52.881657,"s":[119,202,392,-274]},{"p":52.783960,"s":[123,206,402,-284]},{"p":52.710682,"s":[128,211,412,-294]},{"p":52.612984,"s":[132,216,422,-305]},{"p":52.515280,"s":[136,220,433,-315]},{"p":52.442005,"s":[141,224,443,-326]},{"p":52.344307,"s":[145,228,453,-337]},{"p":52.222183,"s":[150,233,463,-347]},{"p":52.124480,"s":[154,237,474,-358]},{"p":52.051205,"s":[159,242,485,-369]},{"p":51.953506,"s":[163,248,496,-380]},{"p":51.855804,"s":[168,252,507,-391]},{"p":51.782530,"s":[173,258,519,-401]},{"p":51.684830,"s":[177,264,531,-412]},{"p":51.587130,"s":[182,270,542,-423]},{"p":51.513855,"s":[186,277,553,-433]},{"p":51.440580,"s":[191,283,564,-444]},{"p":51.342880,"s":[196,290,575,-454]},{"p":51.196330,"s":[205,304,597,-476]},{"p":51.123055,"s":[209,311,607,-488]},{"p":51.025352,"s":[214,317,616,-499]},{"p":50.952080,"s":[220,324,626,-510]},{"p":50.854378,"s":[224,330,635,-522]},{"p":50.756680,"s":[229,337,645,-533]},{"p":50.683403,"s":[234,343,654,-546]},{"p":50.561280,"s":[239,349,663,-557]},{"p":50.463577,"s":[244,355,673,-569]},{"p":50.365880,"s":[249,360,683,-580]},{"p":50.268177,"s":[254,366,693,-592]},{"p":50.170480,"s":[259,371,703,-603]},{"p":50.072777,"s":[264,378,714,-616]},{"p":49.975080,"s":[270,384,725,-627]},{"p":49.877377,"s":[275,390,735,-638]},{"p":49.804100,"s":[280,397,746,-649]},{"p":49.730827,"s":[285,403,758,-660]},{"p":49.633125,"s":[290,411,769,-671]},{"p":49.559853,"s":[295,418,780,-682]},{"p":49.462150,"s":[300,425,790,-693]},{"p":49.388874,"s":[306,433,801,-704]},{"p":49.315600,"s":[311,440,811,-715]},{"p":49.193474,"s":[316,448,822,-726]},{"p":49.095776,"s":[321,455,831,-738]},{"p":49.022500,"s":[326,462,841,-749]},{"p":48.924800,"s":[332,469,851,-760]},{"p":48.827100,"s":[337,475,861,-771]},{"p":48.729400,"s":[343,482,872,-782]},{"p":48.656124,"s":[348,489,882,-794]},{"p":48.534000,"s":[353,495,893,-805]},{"p":48.436300,"s":[359,502,904,-815]},{"p":48.338600,"s":[364,508,915,-826]},{"p":48.240900,"s":[370,515,927,-836]},{"p":48.167620,"s":[376,522,940,-847]},{"p":48.069923,"s":[382,528,953,-857]},{"p":47.996647,"s":[388,536,965,-867]},{"p":47.923374,"s":[393,542,979,-877]},{"p":47.801247,"s":[399,549,992,-887]},{"p":47.727974,"s":[405,556,1007,-897]},{"p":47.654697,"s":[411,564,1020,-907]},{"p":47.581420,"s":[417,571,1034,-917]},{"p":47.483723,"s":[424,578,1048,-927]},{"p":47.410446,"s":[430,585,1061,-937]},{"p":47.288322,"s":[436,591,1075,-947]},{"p":47.215046,"s":[443,598,1088,-958]},{"p":47.117348,"s":[449,605,1101,-968]},{"p":47.019646,"s":[456,610,1114,-978]},{"p":46.921947,"s":[463,615,1126,-988]},{"p":46.824245,"s":[469,620,1138,-998]},{"p":46.726547,"s":[475,624,1152,-1008]},{"p":46.628845,"s":[481,629,1164,-1019]},{"p":46.531143,"s":[488,632,1177,-1029]},{"p":46.433445,"s":[495,635,1189,-1038]},{"p":46.335743,"s":[501,637,1202,-1047]},{"p":46.238045,"s":[507,639,1216,-1056]},{"p":46.140343,"s":[513,641,1229,-1066]},{"p":46.042645,"s":[520,642,1243,-1075]},{"p":45.969368,"s":[527,643,1256,-1084]},{"p":45.896095,"s":[532,643,1269,-1093]},{"p":45.798393,"s":[539,642,1283,-1101]},{"p":45.700695,"s":[545,642,1297,-1110]},{"p":45.627420,"s":[552,640,1310,-1120]},{"p":45.529716,"s":[559,638,1322,-1128]},{"p":45.432020,"s":[565,636,1335,-1138]},{"p":45.334316,"s":[572,633,1347,-1146]},{"p":45.236618,"s":[578,631,1360,-1155]},{"p":45.138916,"s":[586,627,1372,-1165]},{"p":45.041218,"s":[592,624,1384,-1174]},{"p":44.943516,"s":[600,621,1396,-1183]},{"p":44.870243,"s":[607,617,1408,-1191]},{"p":44.748116,"s":[614,615,1419,-1200]},{"p":44.674843,"s":[621,612,1432,-1209]},{"p":44.577140,"s":[628,610,1443,-1218]},{"p":44.455017,"s":[636,609,1455,-1226]},{"p":44.381740,"s":[644,607,1467,-1234]},{"p":44.284042,"s":[651,607,1478,-1242]},{"p":44.210766,"s":[658,607,1491,-1249]},{"p":44.137490,"s":[665,607,1502,-1258]},{"p":44.039790,"s":[673,608,1514,-1266]},{"p":43.942090,"s":[681,609,1525,-1273]},{"p":43.868816,"s":[688,611,1536,-1281]},{"p":43.795540,"s":[696,612,1547,-1288]},{"p":43.697838,"s":[703,614,1558,-1296]},{"p":43.624565,"s":[711,615,1568,-1303]},{"p":43.526863,"s":[719,616,1578,-1310]},{"p":43.453590,"s":[726,617,1587,-1318]},{"p":43.331463,"s":[734,618,1597,-1324]},{"p":43.233765,"s":[741,618,1606,-1332]},{"p":43.136063,"s":[749,618,1615,-1339]},{"p":43.038364,"s":[756,618,1624,-1345]},{"p":42.940662,"s":[764,618,1632,-1352]},{"p":42.867386,"s":[772,617,1640,-1358]},{"p":42.745262,"s":[779,617,1648,-1365]},{"p":42.647564,"s":[787,617,1656,-1371]},{"p":42.574287,"s":[794,616,1662,-1376]},{"p":42.476585,"s":[802,616,1670,-1383]},{"p":42.403313,"s":[810,616,1676,-1388]},{"p":42.305610,"s":[818,616,1681,-1394]},{"p":42.207912,"s":[826,615,1686,-1399]},{"p":42.134636,"s":[834,615,1690,-1405]},{"p":42.036938,"s":[842,614,1693,-1411]},{"p":41.963660,"s":[851,614,1694,-1417]},{"p":41.865960,"s":[859,613,1694,-1423]},{"p":41.792686,"s":[867,611,1692,-1428]},{"p":41.694984,"s":[875,609,1688,-1434]},{"p":41.621710,"s":[884,606,1683,-1439]},{"p":41.499584,"s":[892,603,1677,-1444]},{"p":41.377460,"s":[900,600,1668,-1450]},{"p":41.304184,"s":[909,596,1657,-1454]},{"p":41.206486,"s":[917,592,1646,-1459]},{"p":41.084360,"s":[926,588,1633,-1464]},{"p":40.986660,"s":[934,584,1619,-1468]},{"p":40.888958,"s":[942,580,1604,-1473]},{"p":40.815685,"s":[952,576,1588,-1476]},{"p":40.717983,"s":[960,573,1572,-1480]},{"p":40.620285,"s":[969,569,1556,-1484]},{"p":40.547010,"s":[977,566,1540,-1487]},{"p":40.449306,"s":[987,564,1525,-1491]},{"p":40.376034,"s":[996,561,1510,-1494]},{"p":40.302757,"s":[1005,559,1496,-1498]},{"p":40.205060,"s":[1015,558,1482,-1501]},{"p":40.107357,"s":[1024,556,1469,-1504]},{"p":40.034080,"s":[1034,554,1457,-1508]},{"p":39.936382,"s":[1044,552,1446,-1510]},{"p":39.838680,"s":[1053,550,1436,-1514]},{"p":39.765408,"s":[1063,548,1427,-1516]},{"p":39.667706,"s":[1073,545,1420,-1519]},{"p":39.570007,"s":[1083,543,1413,-1522]},{"p":39.472305,"s":[1093,540,1408,-1524]},{"p":39.374607,"s":[1103,537,1403,-1526]},{"p":39.252480,"s":[1113,533,1400,-1527]},{"p":39.179207,"s":[1123,530,1398,-1528]},{"p":39.057080,"s":[1133,526,1396,-1529]},{"p":38.983807,"s":[1143,522,1396,-1529]},{"p":38.886105,"s":[1153,518,1396,-1528]},{"p":38.788406,"s":[1163,514,1397,-1527]},{"p":38.690704,"s":[1173,511,1398,-1526]},{"p":38.617428,"s":[1183,508,1400,-1524]},{"p":38.544155,"s":[1193,505,1403,-1523]},{"p":38.446453,"s":[1204,502,1406,-1520]},{"p":38.348755,"s":[1215,499,1409,-1518]},{"p":38.275480,"s":[1225,497,1411,-1515]},{"p":38.202200,"s":[1235,494,1414,-1512]},{"p":38.104504,"s":[1245,492,1417,-1509]},{"p":38.006800,"s":[1256,489,1420,-1505]},{"p":37.909103,"s":[1266,487,1422,-1501]},{"p":37.835827,"s":[1277,484,1424,-1497]},{"p":37.738130,"s":[1288,481,1426,-1492]},{"p":37.640427,"s":[1298,477,1427,-1486]},{"p":37.518303,"s":[1309,473,1429,-1480]},{"p":37.420600,"s":[1319,469,1430,-1474]},{"p":37.322903,"s":[1330,465,1431,-1466]},{"p":37.225200,"s":[1341,461,1432,-1458]},{"p":37.127502,"s":[1351,456,1433,-1448]},{"p":37.029800,"s":[1362,452,1435,-1438]},{"p":36.956528,"s":[1373,447,1437,-1427]},{"p":36.883250,"s":[1384,444,1438,-1416]},{"p":36.785550,"s":[1396,440,1441,-1403]},{"p":36.687850,"s":[1407,437,1443,-1390]},{"p":36.614574,"s":[1418,433,1446,-1376]},{"p":36.516876,"s":[1430,431,1449,-1361]},{"p":36.419174,"s":[1441,429,1451,-1346]},{"p":36.345900,"s":[1453,427,1454,-1331]},{"p":36.248200,"s":[1465,426,1456,-1314]},{"p":36.174923,"s":[1476,425,1458,-1297]},{"p":36.077225,"s":[1488,424,1460,-1279]},{"p":35.979523,"s":[1500,423,1461,-1261]},{"p":35.881824,"s":[1511,422,1462,-1242]},{"p":35.784122,"s":[1524,421,1463,-1222]},{"p":35.686424,"s":[1535,420,1464,-1201]},{"p":35.588722,"s":[1547,418,1464,-1180]},{"p":35.491024,"s":[1559,417,1465,-1158]},{"p":35.393322,"s":[1571,415,1465,-1134]},{"p":35.320050,"s":[1583,413,1466,-1109]},{"p":35.222347,"s":[1595,411,1467,-1084]},{"p":35.124650,"s":[1607,409,1468,-1056]},{"p":35.051373,"s":[1619,408,1470,-1029]},{"p":34.953670,"s":[1631,407,1472,-1000]},{"p":34.880398,"s":[1644,406,1474,-969]},{"p":34.782696,"s":[1656,406,1476,-938]},{"p":34.709423,"s":[1668,406,1478,-907]},{"p":34.611720,"s":[1681,406,1481,-874]},{"p":34.538445,"s":[1693,407,1484,-841]},{"p":34.440746,"s":[1705,408,1486,-807]},{"p":34.343044,"s":[1718,409,1488,-773]},{"p":34.269770,"s":[1729,411,1489,-739]},{"p":34.172070,"s":[1741,412,1491,-704]},{"p":34.074370,"s":[1753,414,1493,-669]},{"p":33.976670,"s":[1765,415,1495,-634]},{"p":33.878970,"s":[1778,416,1497,-598]},{"p":33.756844,"s":[1789,417,1499,-562]},{"p":33.659145,"s":[1801,418,1501,-525]},{"p":33.561443,"s":[1813,419,1503,-488]},{"p":33.488170,"s":[1825,419,1507,-450]},{"p":33.390470,"s":[1838,419,1510,-413]},{"p":33.317192,"s":[1851,419,1514,-374]},{"p":33.195070,"s":[1864,419,1519,-335]},{"p":33.121790,"s":[1877,419,1524,-295]},{"p":33.048520,"s":[1890,420,1531,-256]},{"p":32.950817,"s":[1903,421,1537,-216]},{"p":32.853120,"s":[1917,422,1543,-175]},{"p":32.706566,"s":[1943,426,1556,-95]},{"p":32.633293,"s":[1957,428,1563,-56]},{"p":32.535590,"s":[1970,431,1569,-16]},{"p":32.437893,"s":[1983,434,1574,22]},{"p":32.364616,"s":[1996,437,1579,61]},{"p":32.242493,"s":[2009,440,1583,99]},{"p":32.144790,"s":[2021,444,1588,137]},{"p":32.047092,"s":[2034,448,1593,175]},{"p":31.949390,"s":[2046,450,1597,212]},{"p":31.851690,"s":[2059,454,1601,249]},{"p":31.753990,"s":[2071,456,1605,286]},{"p":31.656290,"s":[2084,458,1609,323]},{"p":31.558590,"s":[2096,460,1615,360]},{"p":31.460890,"s":[2109,461,1619,397]},{"p":31.363190,"s":[2121,462,1626,434]},{"p":31.289915,"s":[2135,463,1632,471]},{"p":31.216639,"s":[2148,463,1640,509]},{"p":31.143364,"s":[2162,464,1647,545]},{"p":31.070090,"s":[2175,465,1656,582]},{"p":30.972390,"s":[2189,466,1666,619]},{"p":30.874690,"s":[2204,467,1675,656]},{"p":30.801414,"s":[2217,469,1686,692]},{"p":30.703712,"s":[2231,471,1695,728]},{"p":30.606012,"s":[2244,473,1706,763]},{"p":30.508312,"s":[2258,476,1716,798]},{"p":30.410612,"s":[2271,479,1725,832]},{"p":30.312912,"s":[2285,482,1735,867]},{"p":30.215212,"s":[2298,486,1744,901]},{"p":30.117512,"s":[2310,489,1753,935]},{"p":30.019812,"s":[2323,493,1761,968]},{"p":29.922112,"s":[2335,496,1769,1002]},{"p":29.824411,"s":[2348,500,1776,1036]},{"p":29.726711,"s":[2361,503,1783,1070]},{"p":29.653437,"s":[2373,506,1790,1104]},{"p":29.531311,"s":[2385,510,1797,1138]},{"p":29.458036,"s":[2398,512,1802,1172]},{"p":29.384760,"s":[2412,515,1809,1206]},{"p":29.287060,"s":[2425,517,1815,1240]},{"p":29.213785,"s":[2438,520,1823,1273]},{"p":29.116085,"s":[2451,523,1829,1306]},{"p":29.042810,"s":[2464,526,1836,1339]},{"p":28.945110,"s":[2477,529,1844,1371]},{"p":28.847410,"s":[2491,533,1850,1402]},{"p":28.774134,"s":[2504,537,1858,1433]},{"p":28.676434,"s":[2517,542,1865,1464]},{"p":28.578733,"s":[2530,546,1872,1494]},{"p":28.481033,"s":[2543,552,1880,1524]},{"p":28.383333,"s":[2556,556,1887,1553]},{"p":28.285633,"s":[2569,562,1894,1582]},{"p":28.187933,"s":[2581,568,1901,1611]},{"p":28.090233,"s":[2594,572,1908,1640]},{"p":27.992533,"s":[2607,578,1916,1669]},{"p":27.894833,"s":[2619,582,1922,1699]},{"p":27.821558,"s":[2633,587,1929,1729]},{"p":27.723858,"s":[2646,591,1936,1759]},{"p":27.650581,"s":[2659,595,1943,1789]},{"p":27.552881,"s":[2672,600,1951,1819]},{"p":27.406332,"s":[2699,608,1965,1880]},{"p":27.333057,"s":[2713,611,1971,1909]},{"p":27.235357,"s":[2726,616,1978,1939]},{"p":27.137657,"s":[2740,621,1985,1968]},{"p":27.064380,"s":[2753,625,1992,1996]},{"p":26.966680,"s":[2767,631,1999,2024]},{"p":26.868980,"s":[2781,636,2005,2051]},{"p":26.771280,"s":[2794,641,2012,2077]},{"p":26.673580,"s":[2808,648,2019,2104]},{"p":26.575880,"s":[2821,653,2026,2129]},{"p":26.478180,"s":[2834,660,2034,2154]},{"p":26.380480,"s":[2848,665,2041,2179]},{"p":26.282780,"s":[2862,672,2050,2203]},{"p":26.185080,"s":[2875,678,2058,2228]},{"p":26.087380,"s":[2889,683,2066,2252]},{"p":26.014105,"s":[2903,689,2076,2277]},{"p":25.916405,"s":[2917,694,2085,2301]},{"p":25.818703,"s":[2932,700,2095,2325]},{"p":25.745428,"s":[2947,706,2106,2349]},{"p":25.672153,"s":[2962,710,2116,2372]},{"p":25.598879,"s":[2977,716,2127,2395]},{"p":25.501179,"s":[2993,721,2138,2417]},{"p":25.427902,"s":[3009,727,2149,2438]},{"p":25.330202,"s":[3024,733,2159,2459]},{"p":25.232502,"s":[3040,739,2169,2478]},{"p":25.134802,"s":[3056,747,2179,2496]},{"p":25.037102,"s":[3071,754,2187,2513]},{"p":24.963827,"s":[3087,762,2196,2529]},{"p":24.841702,"s":[3102,769,2203,2544]},{"p":24.744001,"s":[3117,779,2210,2560]},{"p":24.646301,"s":[3132,788,2216,2573]},{"p":24.548601,"s":[3146,796,2222,2586]},{"p":24.450901,"s":[3161,805,2227,2599]},{"p":24.377626,"s":[3176,813,2232,2612]},{"p":24.279926,"s":[3191,822,2237,2625]},{"p":24.206650,"s":[3206,830,2241,2639]},{"p":24.108950,"s":[3221,838,2246,2652]},{"p":24.011250,"s":[3236,845,2251,2665]},{"p":23.937975,"s":[3252,851,2256,2677]},{"p":23.864700,"s":[3267,858,2262,2690]},{"p":23.767000,"s":[3282,865,2268,2703]},{"p":23.693724,"s":[3298,871,2275,2714]},{"p":23.596024,"s":[3313,877,2283,2725]},{"p":23.522749,"s":[3329,882,2290,2736]},{"p":23.425049,"s":[3344,888,2298,2745]},{"p":23.327349,"s":[3359,893,2307,2754]},{"p":23.229649,"s":[3374,899,2316,2762]},{"p":23.131948,"s":[3389,905,2326,2769]},{"p":23.058674,"s":[3404,910,2335,2776]},{"p":22.912123,"s":[3419,915,2346,2781]},{"p":22.838848,"s":[3434,919,2357,2787]},{"p":22.741148,"s":[3448,923,2368,2792]},{"p":22.643448,"s":[3463,926,2380,2797]},{"p":22.545748,"s":[3477,928,2391,2802]},{"p":22.472471,"s":[3492,930,2404,2807]},{"p":22.374771,"s":[3507,930,2416,2813]},{"p":22.301497,"s":[3522,930,2429,2818]},{"p":22.203796,"s":[3537,929,2442,2823]},{"p":22.130522,"s":[3552,927,2455,2829]},{"p":22.032822,"s":[3567,925,2469,2833]},{"p":21.959545,"s":[3583,922,2482,2837]},{"p":21.886270,"s":[3598,918,2496,2840]},{"p":21.788570,"s":[3613,914,2510,2843]},{"p":21.715296,"s":[3628,910,2524,2845]},{"p":21.617596,"s":[3643,905,2537,2845]},{"p":21.519896,"s":[3657,901,2551,2845]},{"p":21.422195,"s":[3672,896,2566,2843]},{"p":21.324495,"s":[3686,892,2581,2840]},{"p":21.226795,"s":[3700,888,2596,2837]},{"p":21.129095,"s":[3714,884,2610,2833]},{"p":21.031395,"s":[3728,880,2625,2829]},{"p":20.933693,"s":[3742,876,2640,2825]},{"p":20.835993,"s":[3756,873,2655,2821]},{"p":20.738293,"s":[3770,869,2670,2817]},{"p":20.640593,"s":[3784,865,2684,2814]},{"p":20.567318,"s":[3798,862,2698,2811]},{"p":20.469618,"s":[3813,859,2711,2809]},{"p":20.396343,"s":[3827,857,2724,2807]},{"p":20.323067,"s":[3842,854,2738,2806]},{"p":20.225367,"s":[3856,852,2751,2805]},{"p":20.152092,"s":[3871,850,2763,2804]},{"p":20.078817,"s":[3885,849,2776,2802]},{"p":19.981117,"s":[3900,849,2788,2800]},{"p":19.907843,"s":[3914,849,2802,2798]},{"p":19.785717,"s":[3928,850,2815,2795]},{"p":19.712440,"s":[3941,852,2828,2791]},{"p":19.590317,"s":[3954,855,2841,2787]},{"p":19.517040,"s":[3968,859,2855,2781]},{"p":19.419340,"s":[3981,864,2870,2775]},{"p":19.321640,"s":[3993,870,2884,2768]},{"p":19.223940,"s":[4006,876,2898,2761]},{"p":19.126240,"s":[4019,884,2911,2756]},{"p":19.028540,"s":[4031,891,2924,2749]},{"p":18.930840,"s":[4046,900,2936,2744]},{"p":18.833140,"s":[4059,908,2947,2739]},{"p":18.735440,"s":[4073,918,2956,2735]},{"p":18.662165,"s":[4087,927,2965,2732]},{"p":18.564465,"s":[4101,936,2971,2730]},{"p":18.491188,"s":[4117,945,2978,2728]},{"p":18.417913,"s":[4132,954,2982,2727]},{"p":18.320213,"s":[4147,964,2986,2726]},{"p":18.246939,"s":[4163,973,2989,2725]},{"p":18.173664,"s":[4179,982,2992,2725]},{"p":18.075964,"s":[4195,992,2995,2724]},{"p":17.978264,"s":[4211,1001,2997,2723]},{"p":17.880562,"s":[4227,1011,3000,2722]},{"p":17.782862,"s":[4243,1022,3003,2719]},{"p":17.685162,"s":[4258,1033,3007,2716]},{"p":17.587461,"s":[4273,1045,3012,2713]},{"p":17.489761,"s":[4289,1058,3016,2708]},{"p":17.416487,"s":[4303,1072,3022,2703]},{"p":17.294361,"s":[4317,1087,3027,2696]},{"p":17.221087,"s":[4331,1102,3033,2689]},{"p":17.123386,"s":[4345,1118,3039,2683]},{"p":17.050112,"s":[4359,1134,3045,2675]},{"p":16.927986,"s":[4373,1151,3051,2667]},{"p":16.854712,"s":[4387,1168,3057,2659]},{"p":16.781435,"s":[4400,1185,3063,2650]},{"p":16.683735,"s":[4414,1203,3070,2643]},{"p":16.610460,"s":[4427,1221,3075,2634]},{"p":16.537186,"s":[4441,1239,3081,2626]},{"p":16.439486,"s":[4454,1256,3087,2617]},{"p":16.341785,"s":[4467,1275,3093,2607]},{"p":16.244085,"s":[4480,1293,3100,2598]},{"p":16.170809,"s":[4492,1313,3107,2589]},{"p":16.073109,"s":[4505,1331,3115,2579]},{"p":15.975409,"s":[4517,1352,3123,2569]},{"p":15.877708,"s":[4529,1373,3133,2558]},{"p":15.780008,"s":[4540,1395,3144,2546]},{"p":15.706734,"s":[4551,1417,3155,2534]},{"p":15.609034,"s":[4562,1441,3167,2523]},{"p":15.511333,"s":[4573,1465,3180,2511]},{"p":15.389208,"s":[4584,1489,3195,2500]},{"p":15.315932,"s":[4594,1514,3209,2488]},{"p":15.218232,"s":[4605,1538,3223,2478]},{"p":15.120532,"s":[4615,1563,3238,2469]},{"p":15.047257,"s":[4625,1589,3253,2460]},{"p":14.973982,"s":[4636,1613,3268,2453]},{"p":14.876282,"s":[4646,1638,3283,2446]},{"p":14.803006,"s":[4656,1662,3298,2440]},{"p":14.705306,"s":[4667,1686,3312,2436]},{"p":14.632031,"s":[4677,1710,3326,2431]},{"p":14.534331,"s":[4688,1733,3341,2428]},{"p":14.461056,"s":[4698,1756,3356,2425]},{"p":14.363356,"s":[4708,1779,3371,2422]},{"p":14.265655,"s":[4718,1803,3386,2419]},{"p":14.167955,"s":[4728,1827,3402,2416]},{"p":14.070255,"s":[4739,1851,3419,2413]},{"p":13.972555,"s":[4749,1875,3437,2409]},{"p":13.899280,"s":[4759,1900,3454,2404]},{"p":13.777155,"s":[4769,1925,3473,2400]},{"p":13.679455,"s":[4779,1950,3491,2396]},{"p":13.581754,"s":[4789,1976,3510,2392]},{"p":13.508479,"s":[4799,2001,3529,2387]},{"p":13.410779,"s":[4809,2027,3547,2383]},{"p":13.313079,"s":[4818,2052,3565,2380]},{"p":13.239803,"s":[4828,2077,3582,2376]},{"p":13.166529,"s":[4838,2101,3599,2374]},{"p":13.068829,"s":[4848,2125,3615,2371]},{"p":12.995553,"s":[4859,2148,3631,2370]},{"p":12.897853,"s":[4868,2171,3647,2368]},{"p":12.824577,"s":[4879,2193,3661,2366]},{"p":12.751303,"s":[4889,2215,3675,2365]},{"p":12.653603,"s":[4899,2237,3690,2364]},{"p":12.580327,"s":[4910,2259,3704,2363]},{"p":12.482627,"s":[4920,2281,3720,2361]},{"p":12.384927,"s":[4930,2304,3735,2359]},{"p":12.287227,"s":[4940,2326,3751,2356]},{"p":12.189527,"s":[4950,2350,3768,2353]},{"p":12.091826,"s":[4961,2373,3787,2349]},{"p":11.994126,"s":[4970,2396,3807,2343]},{"p":11.872001,"s":[4980,2421,3827,2337]},{"p":11.798725,"s":[4989,2444,3849,2331]},{"p":11.676600,"s":[4999,2468,3871,2324]},{"p":11.603325,"s":[5008,2492,3895,2318]},{"p":11.505625,"s":[5017,2516,3919,2311]},{"p":11.432350,"s":[5026,2539,3943,2304]},{"p":11.334650,"s":[5034,2562,3969,2297]},{"p":11.261374,"s":[5043,2584,3994,2290]},{"p":11.163674,"s":[5052,2605,4019,2284]},{"p":11.090399,"s":[5060,2626,4044,2278]},{"p":11.017124,"s":[5068,2646,4069,2273]},{"p":10.919424,"s":[5076,2667,4094,2268]},{"p":10.821724,"s":[5084,2686,4119,2263]},{"p":10.748448,"s":[5093,2707,4144,2259]},{"p":10.650748,"s":[5101,2727,4169,2254]},{"p":10.553048,"s":[5109,2748,4195,2249]},{"p":10.455348,"s":[5116,2769,4220,2244]},{"p":10.357648,"s":[5125,2790,4247,2238]},{"p":10.259948,"s":[5133,2811,4273,2232]},{"p":10.162248,"s":[5140,2833,4300,2225]},{"p":10.064548,"s":[5148,2855,4328,2218]},{"p":9.966846,"s":[5155,2876,4355,2210]},{"p":9.869146,"s":[5163,2898,4383,2202]},{"p":9.771446,"s":[5170,2919,4412,2194]},{"p":9.673746,"s":[5177,2940,4440,2186]},{"p":9.600471,"s":[5184,2959,4468,2179]},{"p":9.527196,"s":[5190,2978,4496,2171]},{"p":9.453921,"s":[5197,2996,4523,2163]},{"p":9.356220,"s":[5203,3014,4551,2157]},{"p":9.258520,"s":[5210,3031,4577,2151]},{"p":9.185246,"s":[5216,3046,4602,2146]},{"p":9.111970,"s":[5222,3062,4628,2141]},{"p":9.014270,"s":[5228,3078,4653,2137]},{"p":8.916570,"s":[5234,3094,4677,2133]},{"p":8.843295,"s":[5240,3109,4702,2128]},{"p":8.721169,"s":[5246,3125,4727,2125]},{"p":8.647894,"s":[5252,3141,4752,2120]},{"p":8.550194,"s":[5258,3157,4777,2116]},{"p":8.452494,"s":[5264,3175,4802,2111]},{"p":8.354794,"s":[5270,3191,4828,2105]},{"p":8.257093,"s":[5276,3208,4854,2099]},{"p":8.159393,"s":[5282,3225,4880,2092]},{"p":8.061693,"s":[5288,3242,4906,2086]},{"p":7.988418,"s":[5293,3258,4932,2079]},{"p":7.890718,"s":[5298,3275,4959,2072]},{"p":7.793017,"s":[5304,3291,4984,2066]},{"p":7.719742,"s":[5308,3307,5009,2059]},{"p":7.622042,"s":[5313,3323,5034,2054]},{"p":7.548767,"s":[5317,3337,5058,2048]},{"p":7.451067,"s":[5322,3353,5081,2042]},{"p":7.377792,"s":[5326,3368,5104,2038]},{"p":7.280092,"s":[5331,3383,5127,2033]},{"p":7.206816,"s":[5336,3398,5149,2029]},{"p":7.133541,"s":[5340,3413,5171,2024]},{"p":7.035841,"s":[5346,3430,5192,2020]},{"p":6.938141,"s":[5351,3448,5214,2014]},{"p":6.840441,"s":[5357,3466,5237,2008]},{"p":6.742741,"s":[5364,3485,5260,2002]},{"p":6.645041,"s":[5370,3505,5284,1994]},{"p":6.547340,"s":[5378,3527,5309,1986]},{"p":6.449640,"s":[5385,3549,5334,1977]},{"p":6.351940,"s":[5393,3572,5360,1967]},{"p":6.254240,"s":[5402,3595,5387,1958]},{"p":6.156539,"s":[5411,3619,5414,1947]},{"p":6.058839,"s":[5420,3643,5441,1938]},{"p":5.985564,"s":[5429,3668,5468,1927]},{"p":5.887864,"s":[5438,3692,5496,1917]},{"p":5.790164,"s":[5448,3716,5522,1909]},{"p":5.643613,"s":[5467,3764,5577,1893]},{"p":5.570338,"s":[5477,3788,5603,1885]},{"p":5.472638,"s":[5487,3813,5631,1878]},{"p":5.399363,"s":[5496,3838,5659,1873]},{"p":5.301662,"s":[5506,3864,5688,1867]},{"p":5.228387,"s":[5517,3889,5719,1862]},{"p":5.130687,"s":[5527,3916,5751,1856]},{"p":5.032987,"s":[5538,3944,5785,1849]},{"p":4.935287,"s":[5549,3972,5821,1844]},{"p":4.837587,"s":[5560,4001,5860,1837]},{"p":4.739886,"s":[5572,4031,5902,1830]},{"p":4.642186,"s":[5586,4061,5946,1822]},{"p":4.544486,"s":[5599,4092,5993,1815]},{"p":4.446786,"s":[5613,4124,6043,1806]},{"p":4.373511,"s":[5627,4157,6095,1798]},{"p":4.251386,"s":[5642,4190,6148,1790]},{"p":4.178110,"s":[5658,4223,6204,1782]},{"p":4.080410,"s":[5675,4256,6261,1775]},{"p":4.007135,"s":[5691,4290,6319,1768]},{"p":3.933860,"s":[5709,4324,6378,1760]},{"p":3.836160,"s":[5727,4358,6436,1755]},{"p":3.762885,"s":[5746,4392,6496,1748]},{"p":3.689609,"s":[5766,4427,6554,1743]},{"p":3.591909,"s":[5785,4463,6612,1737]},{"p":3.518634,"s":[5806,4499,6671,1730]},{"p":3.420934,"s":[5828,4537,6727,1723]},{"p":3.323234,"s":[5850,4575,6782,1715]},{"p":3.225534,"s":[5871,4614,6837,1705]},{"p":3.152258,"s":[5894,4654,6889,1693]},{"p":3.054558,"s":[5916,4696,6940,1677]},{"p":2.956858,"s":[5938,4738,6988,1658]},{"p":2.859158,"s":[5960,4782,7032,1635]},{"p":2.761457,"s":[5980,4827,7074,1604]},{"p":2.688182,"s":[6001,4872,7111,1569]},{"p":2.590482,"s":[6019,4918,7144,1526]},{"p":2.517207,"s":[6036,4964,7173,1475]},{"p":2.443932,"s":[6052,5010,7196,1416]},{"p":2.370657,"s":[6066,5056,7216,1348]},{"p":2.297382,"s":[6079,5103,7231,1272]},{"p":2.224107,"s":[6091,5148,7243,1189]},{"p":2.150831,"s":[6101,5192,7250,1098]},{"p":2.077556,"s":[6110,5235,7255,1001]},{"p":2.004281,"s":[6119,5278,7256,900]},{"p":1.931006,"s":[6128,5318,7255,794]},{"p":1.857731,"s":[6137,5358,7253,686]},{"p":1.784455,"s":[6145,5396,7249,577]},{"p":1.686755,"s":[6154,5432,7244,469]},{"p":1.613480,"s":[6163,5467,7240,364]},{"p":1.515780,"s":[6173,5500,7235,261]},{"p":1.442505,"s":[6185,5531,7230,166]},{"p":1.369230,"s":[6196,5561,7227,78]},{"p":1.271530,"s":[6209,5589,7223,-1]},{"p":1.198254,"s":[6222,5615,7221,-69]},{"p":1.100554,"s":[6236,5638,7218,-127]},{"p":1.027279,"s":[6252,5658,7216,-173]},{"p":0.954004,"s":[6267,5676,7214,-206]},{"p":0.880729,"s":[6283,5692,7211,-227]},{"p":0.734178,"s":[6317,5713,7204,-234]},{"p":0.660903,"s":[6333,5719,7200,-221]},{"p":0.587628,"s":[6351,5722,7193,-199]},{"p":0.465503,"s":[6388,5718,7177,-128]},{"p":0.392228,"s":[6406,5712,7167,-82]},{"p":0.294528,"s":[6425,5703,7157,-31]},{"p":0.221252,"s":[6445,5693,7145,25]},{"p":0.147977,"s":[6466,5679,7132,85]},{"p":0.050277,"s":[6486,5662,7118,148]}]}}

Expected behavior
The event should be sent successfull.
Environment (please complete the following information):

OS custom build yocto image
Hardware: industrial pc
System-Architecture:  Linux epc1522 5.4.193-rt74-pxc  x86_64  GNU/Linux
thin-edge.io version 0.12.0

Additional context
tedge-mapper-c8y.log

Thanks @bjoernsauer for spotting this one. I could reproduce it easily enough using the following snippet:
Run in a bash shell:
PAYLOAD=$(printf '{"type":"recording","time":"2023-09-07T15:10:46Z","text":"New recording","large":"%s"}' "$(printf -- 'x%.0s' {1..17000})")
mosquitto_pub -t 'tedge/events/recording' -m "$PAYLOAD"

The following error message appears under the tedge-mapper-c8y
Sep 08 02:34:23 lumber tedge-mapper[33512]: 2023-09-08T00:34:23.339859658Z ERROR c8y_mapper_ext::converter: Mapping error: Failed with HTTP error status 404 Not Found

The issue is in the external ID lookup as can be seen in these logs:
Sep 08 06:37:00 35b9a280fee9 tedge-mapper[357571]: 2023-09-08T06:37:00.787995388Z  INFO HTTP: recv Some((0, Request { method: GET, uri: https://albin.basic.stage.c8y.io/identity/externalIds/c8y_Serial/, version: HTTP/1.1, headers: {"authorization": "Bearer eyJ..."}, body: Body(Empty) }))
Sep 08 06:37:01 35b9a280fee9 tedge-mapper[357571]: 2023-09-08T06:37:01.522843392Z  INFO HTTP: send (0, Ok(Response { status: 404, version: HTTP/1.1, headers: {"date": "Fri, 08 Sep 2023 06:37:04 GMT", "content-length": "0", "connection": "keep-alive", "x-content-type-options": "nosniff", "cache-control": "no-cache, no-store, max-age=0, must-revalidate", "pragma": "no-cache", "expires": "0", "x-frame-options": "DENY", "allow": "DELETE,POST,GET,OPTIONS,HEAD"}, body: Body(Empty) }))

Where the device's external ID is missing on the requested URL https://albin.basic.stage.c8y.io/identity/externalIds/c8y_Serial/

QA has thoroughly checked the feature and here are the results:

[x] Test for ticket exists in the test suite.
tests/RobotFramework/tests/cumulocity/telemetry/thin-edge_device_telemetry.robot
[x] QA has tested the bug and could not reproduce it anymore.


[Suggestion] Some sticker has animation review apng, is it possible to download those?

For example :https://store.line.me/stickershop/product/28203489/en
better if download and convert to gif?

NVM i added it myself


Make SimpleReactiveDiscoveryClient react to config changes

This fixes issue #706 which I found is incorrectly marked as a duplicate.
It seems, at the time my reactive objects are created, the simpleReactiveDiscoveryClient does not yet have the properties set. With that change, it reacts to changes just like the kubernetes implementation already does.

@juri8 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

Can you add some tests that show this fixing an issue?

Ping RE: tests and signing CLA


Renaming some classes

In GitLab by @cmastalli on Jan 21, 2019, 18:32
Here I have a suggestion list for different classes:

StatePinocchio → StateRobot
Cost(Data/Model)Pinocchio → Cost(Data/Model)Robot
Cost(Data/Model)PlacementVelocity → Cost(Data/Model)Motion
Cost(Data/Model)Position6D → Cost(Data/Model)SE3
Cost(Data/Model)Force6D → Cost(Data/Model)Wrench
Cost(Data/Model)Sum → Cost(Data/Model)Manager
Action(Data/Model)LQR → Action(Data/Model)
DifferentialAction(Data/Model) → DifferentialAction(Data/Model)ABA

Additionally, I would like to use:

Dynamics instead of State
Semantic description (e.g DDPSolver instead of SolverDDP)

Please let me know your thoughts!
@nmansard @rbudhira

In GitLab by @nmansard on Jan 22, 2019, 10:50
StatePinocchio: should not change
CostBase
CostPosition6D -> CostFramePlacement
CostPlacementVel -> CostFrameVelocity
CostPosition3d   ->  CostFrameTranslation
CostForce6d  -> costWrench
In case of future work: costFrameVelocityLinear, costFrameRotation
ActionLQR should not change. We may want to introduce a ActionBase ... not done yet.
DiffAction -> DiffActionFullyActuated
State is not dynamics. No control in state

In GitLab by @proyan on Jan 28, 2019, 01:04
assigned to @rbudhira and unassigned @cmastalli

In GitLab by @proyan on Jan 28, 2019, 01:27
mentioned in merge request !68

In GitLab by @nmansard on Jan 29, 2019, 14:05
mentioned in commit 757f421c954f8aeb5b839105d1e71eef1a2843b3

In GitLab by @proyan on Jan 29, 2019, 14:26
Closed with !66

In GitLab by @proyan on Jan 29, 2019, 14:26
closed


Temp: Always report debug info on module not found error

Summary:
The TurboModule interop layer causes a surge in "module not found" exceptions: T154044825.
After D45102812, this exception should have included debug info. But, it didn't.
Problems
So, there are two problems:

No debug logs are getting printed.
In the TurboModule interop test group, global.RN$TurboInterop is false for some reason. This is very strange.

Changes

Always print the debug logs.
Add more flag-related debug information to the "module not found" debug logs. This will help us validate whether global.RN$TurboInterop is truely false.

Concerns

Always print the debug logs on Android.

Question: Won't this be really expensive?
This shouldn't be too expensive: There are about ~50 native module requires in Fb4a. So: (1) the exception message shouldn't grow to an unreasonable size, (2) we'll only use enough memory to store ~50 strings in the JS VM.
Changelog: [Internal]
Reviewed By: fkgozali
Differential Revision: D46195117

Merged in 169180100c6c9639375d37ff1736d9cefbaaa63b


How you preview the live activity UI on development?

It's a helpful and amazing demo!
but I don't see any preview code on this demo. I wanna know how to preview the activity widget use the PreviewProvider ? or you just run entire app to preview the UI?
struct live_activities_Previews: PreviewProvider {
    static var previews: some View {
        live_activitiesEntryView(context: !how to create this!)
            .previewContext(WidgetPreviewContext(family: .systemSmall))
    }
}

Thanks!

Hi. I haven't yet seen how to preview the live activities widget in Apple Developer Documentation.
So, I run the app to preview the UI.
Or you may preview the widget design first, then copy the code back to the Live Widget(s).

Hope help :)

Hi. I cannot find how to preview the live activities widget in Apple Developer Documentation. The thing is still in beta. So, I simply run the app to preview the UI.
Or you may preview the widget design first, then copy the code back to the Live Widget(s).
Hope help :) @Yggdrasilqh

Oh, that's a good idea!
thanks for your reply. have a good day!


Request to add new quest

Description of Problem or Question
Please add the following quest to the list:
https://github.com/Drake3/MOM/tree/master/Cabin_in_the_Woods
Thank you!
Valkyrie Version
Attach Save, Quest or Scenario
https://github.com/Drake3/MOM/tree/master/Cabin_in_the_Woods

Awesome, I'll get thos added for you asap

Hi @Drake3
The scenario has not been packaged, so I cant link it yet.
Inside the editor you will need to create a package from "Tools" > "Create Package".
Upload the .ini file and the .zip file to github (maybe just create a folder in your MoM repo) and send me the link.

Thanks for the information. I was pressing this button a lot, but it never creates anything at least not at a place where I can find it. The manual is kinda fishy about where the file should be located. I guess in the scenario directory, but there it does not show.  Any other tips what could have gone wrong?

It drops the file on the desktop for windows. Unsure on linux, @redwolf2 may know.

OMG. I got like 20 folders on the desktop.  Now try this one:
https://github.com/Drake3/MOM/tree/master/CabinInTheWoods

Adding the scenario appears to have broken the manifest. I've rolled back the change for now to try to fix that. May need to look into this more before adding the scenario as I am  ot sure if it's a wider issue.

Ok I have found out what the issue is.
Your quest.ini files default language is german, but the scenario only contains an english localisation file. The Scenario Explorer scans the localisation file to gather some information and is crashing because the german file its expecting to find is not present.

@Drake3 Can you please set your app language to English, then open the editor and create a new package.
Send me the link and I'll take a look to make sure the issue is corrected. If it's not I can talk you through the fix in the .ini files directly.

Ok, turns out if you build the package with the right language on, it doesnt fix the quest.ini. Manually changed the file and rebuild the package. Hope its fine now:
https://github.com/Drake3/MOM/tree/master/CabinInTheWoods

Did you change the default language in the quest.ini prior to creating the package or after?
It's just a different quest.ini is also contained within the scenarui.valkyrie file. I suspect it will be fine now but just want to check.

Hi @Drake3
The scenario is showing the Scenario Explorer now:

It also downloads and runs:

Just an early observation:
The Investigator icon does not get removed after you are told to place them.

If I do an update, is it sufficient if I just replace the files on github or do I need to ask one of you guys to do it?


componentize an "are you sure" element

Create a component that can be called to provide a popup encouraging users to double check before making a change.
Look to some forms for deleting data for help

We don't actually have any extra check being used. Keeping this up for now but better focus on other ideas

Closing for now because I don't see a need for this


Modified test: Xplat Debug only Recycler crash on exit

See these comments:
https://github.com/Microsoft/ChakraCore/pull/5622#issuecomment-415905651
https://github.com/Microsoft/ChakraCore/pull/5622#issuecomment-415908077
After implementing Object.fromEntries the AsmJS parameters out of memory test would crash on xplat debug builds when calling WScript.Quit(0) - this issue only repros on xplat debug builds and seemingly only with fatal errors for OOM disabled (which this test disabled).
Fixed the test for now by avoiding the use of WScript.Quit - as that's not what the test was actually meant to test but there is a bug here that should be looked into.
CC @MikeHolman

@MikeHolman Can you triage this bug?


fix: Log request_id in the grpc "Handled request" log message

fix: request_id is not logged in the "Handled request" log message (cerbos#1690)

Thanks for the PR. Please run make lint to fix the formatting issues reported by the check.

Thanks for the PR. Please run make lint to fix the formatting issues reported by the check.

Hey @charithe thanks for taking a look.  Not sure if make lint is working for some reason on my machine.  I think it's updated correctly now, can you approve the workflows again? Thanks!


Multiselect-clear element should not be rendered when canDeselect is set

Version

Vue version: 3

Description
I've setup the multiselect in single mode, with canDeselect set to FALSE.
When the item is selected, the "cross button" on the right side of the list still appears, and that's confusing.
I think this cross button should not be rendered, perhaps modifiing the v-if part and adding && canDeselect
Thanks for your feedback

Thanks @BKirev for the PR I've added it with tests in 1.5.0.

@adamberecz It's possible I'm doing something incorrect here, but this still isn't working with Vue3 and 1.5.0.
          <Multiselect
            v-if="hasAccess"
            v-model="selectedCustomerId"
            :options="customerIds"
            canDeselect="false" />

I've attempted with can-deselect="false" as well.

 Thank you. I appreciate the quick response.


Support TLA+ records

TLA+ records are a very attractive way to model network messages. Currently we use tuples, which are ok but makes the specification harder to understand.
This may be harder to support than it sounds due to #106.

Fixed on master. See d7c595f for example use.


Update Bubble Sort Readme

Added README for Bubble Sort #74

Hey kindly resolve Merge Conflicts before sending the Pull Request


Make License field a drop-down menu

When admins edit the "License" field, there should be a drop-down menu of options. Right now this field takes free text.
I am not sure if there is currently any validation on this field, but there should be. I believe ScholarSphere will not accept an incoming deposit if the license doesn't match an allowable license option. This is why the field is a drop-down in the regular ScholarSphere deposit workflow in RMD.
I suspect OA Button may be providing a wider range of options in this field than ScholarSphere allows, so we may need to think about mapping them (or updating ScholarSphere to allow other licenses).

We actually already have a mapping class for mapping the license format from OAB to our format.  We added this when we implemented the original ScholarSphere deposit version and permission checking (https://github.com/psu-libraries/researcher-metadata/pull/569).  We may want to review it, though, to see if anything has been added to OAB.

@anaelizabethenriquez Good catch. The information that gets submitted to ScholarSphere in the RMD's self-serve deposit workflow is represented by a different data model in RMD that gets populated by a combination of metadata from a publication record and direct user input. This model does have a validation on its license field, but the publication model in RMD currently does not.
Is there any way to know all of the possible license values that OA Button may report and whether or not that list is subject to change without notice?
If we add a validation to the license field on the publication model, then OA Button could break our automatic permissions checking for some publications simply by adding a new license value. If that's a possibility, then we may not want it to work that way. What we definitely could do, as you suggested, would be to make the license field a drop-down of known values in the Rails Admin edit view for publications. That would at least ensure that admins are entering valid data that will be accepted by ScholarSphere, but it would also still allow the field to be populated with whatever value OA Button provides.
When it comes time to do the ScholarSphere deposit in the DM-OA workflow, then I guess we have a choice - we could just allow ScholarSphere to do all of the metadata validation since it's the authority on those rules, or we could attempt to duplicate ScholarSphere's validations in RMD (as we've done with the self-serve workflow) to try to prevent invalid submissions in the first place.
I think I'd actually lean toward the former as long as ScholarSphere provides structured, machine-readable data in its error responses (I actually can't remember). That way, if we got a new license value from OA Button that we weren't expecting and that ScholarSphere won't accept, we could allow the deposit to be attempted, and allow ScholarSphere to tell us that the license isn't valid. Then we'd know that we need to do one or more of the following:

edit that license value to make it something that ScholarSphere will accept
create an automatic mapping from the new OAB license value to an existing one that ScholarSphere already accepts
actually update ScholarSphere to accept a totally new license value (and update our list of allowable license values in the RMD drop-downs)
perhaps totally reject the deposit if the license really isn't acceptable in ScholarSphere for some reason?

Thanks @ajkiessl @EricDurante !
If we need to review the license manually, it would be nice to take care of that during the "Review Permissions" step. So, could we just say that if the data coming from OAB doesn't fit into our current mapping, we leave the field blank, which would send it to the manual permissions review queue?

Is there any way to know all of the possible license values that OA Button may report and whether or not that list is subject to change without notice?

iirc I determined the mapping by finding all the unique license values in the "Data Download" here: https://shareyourpaper.org/permissions/about#api .  Not sure if this is all the permissions data in OAB.  It's only about 10,000 records.  I also programmatically tried to find all the unique licenses by sending a request for a subset of our publications in RMD.  I forget how many that was, and if there was anything that didn't overlap with the unique values from the "Data Download".  I think the only differences between the "Data Download" and API was that the "Data Download" returns their licenses in all-caps, but the API was all lowercase.

So, could we just say that if the data coming from OAB doesn't fit into our current mapping, we leave the field blank, which would send it to the manual permissions review queue?

That sounds good to me.  This would force us to evaluate that license and then potentially add it to our list of acceptable licenses.  We'd have to modify the current state of the mapper, though.  Right now it defaults to "All Rights Reserved" for these cases.

@ajkiessl Is this on QA? I'm not seeing it, but maybe I'm not looking in the right place.

@ajkiessl Never mind my comment above. We discussed this in standup. I had been looking at the old metadata fields, which will be removed (see #830). The drop-down is present in the new fields on the file record.


Checker tests should also check warnings

We need to also test warnings reported by the checker to avoid reporting false positive/negative warnings.

So basically we just need an annotation, like @checker_should_warn "true", which passes if:

There are no checker errors
There are 1 or more checker warnings

Right?

Sounds reasonable


Add link to "HTML Intro" from w3schools.com

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi,
Thanks for this pull request (PR).
Unfortunately, I am marking this PR invalid for hacktoberfest for the following reasons:

We don't generally accept PRs which just add a link to the "more information" section.
We avoid adding w3schools as a resource because they sometimes have incorrect or incomplete information.

Feel free to open another PR if you'd like 👍


avaiable->available typo fix (#664)

Description
Fixing typo
Fixes #664

May need to change the base branch, long story, but could pull this on the aims2 deployment.

All good from me, it's a was a trivial PR so figured why not help out - have at it as you like, as I have no repo/org perms over to you


[SPARK-46465][PYTHON][DOCS][FOLLOWUPS] Add Column.isNaN to API references

What changes were proposed in this pull request?
Add Column.isNaN to API references
Why are the changes needed?
it's missing in https://github.com/apache/spark/pull/44422
Does this PR introduce any user-facing change?
yes, document
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no

merged to master


⚠ Samsung has degraded performance

In e84cdb3, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2572 ms

Resolved: Samsung performance has improved in 99a6bf1.


Connection problem

When trying to connect (await controller.connect()), I get the following error message:
Connection to <IP_ADDRESS>:5220 failed with exception module 'socket' has no attribute 'TCP_USER_TIMEOUT'

I still can query informations with methods like get_devices, get_power_state and so on, but the control methods do not seem to have any effect.

What host OS are you running? We may need to add a check to see if TCP timeout is available as an option, and to only set it if is

I get this error message on MacOS (10.15.6) and on FreeBSD (12.1-RELEASE-p6).

This might be useful:

https://stackoverflow.com/questions/22515349/what-is-the-setsockopt-option-name-of-tcp-user-timeout-on-osx
https://www.manpagez.com/man/4/tcp/

I found some information that in MacOs and BSD TCP_USER_TIMEOUT can be replaced with TCP_CONNECTIONTIMEOUT, but this didn't prove to be true (dir(socket) reveals that it does not exist).
So I tried to patch the code, just commenting out the line in question. My script now runs without any error messages, but the control methods still seem to have no effect.
Is it necessary to register an application somehow with IntesisHome (like IFTTT does)?

V1.8.1 removes this code and sends keepalives instead to detect dead connections, please update issue if this is still a problem


Mercurial: remote: 'ssh' is not recognized as an internal or external command

Customer reported the above issue when hg pulled from private repo (hg pull ssh://hg@bitbucket.org/username/repo).    This could also happen for git fetch from private repo (error launching git: The system cannot find the path specified.).   This happens to few but not all customers.
The cause is the hg pull requires ssh.exe to be on the path and it wasn't.   It turned out that installing 64bit git (even though msi installation was successful) may not clean up the existing 32bit one entirely and left the below files.
D:\Program Files (x86)\git\cmd\git.exe
D:\Program Files (x86)\git\usr\bin\ngettext.exe

Our logic mistook the 32 bits installation and set all paths related to such,  This breaks any scenarios require tooling coming with git.
The fix is to re-order our check to prefer 64bit git (check that first) before 32bits one.  It might break the wise versa scenario - but highly unlikely for those outside Azure.

This could also happen for git fetch from private repo (error launching git: The system cannot find the path specified.)

Do you mean that git fetch from private repro is also broken? That seems hard to believe.

Yes, I tried it.  I think this only happens to few VMs and hence we have not heard much from.

But we have tests that do private repos. Why are they not broken on private stamps?

I understand the confusion now.  Installing 64bit git will remove those files.   However, on the VM where customer reported the issue, those 2 files were somehow left.  There was no warning/error in 64bit git installation.   The leftover caused the issue.   Moving customer to another VM solved the issue.  I believe this happened to few enough VMs - hence just one reported so far.


Update example offset in encrypt-data-using-camellia

Per https://github.com/fireeye/capa-rules/pull/106#issuecomment-683137923

b00m
thanks!


nexus is failing to get IP after reboot : IP_DROP_MEMBERSHIP failed: Can't assign requested address

nexus plugin installation is working, but after reboot (or restart of plugin) service is unavailable at http://<IP_ADDRESS>:8081/
Feb 16 10:33:09 nabla kernel: lo0: link state changed to UP
Feb 16 10:33:13 nabla 1 2022-02-16T10:33:13.300243+01:00 nabla.albandrieu.com avahi-daemon 90550 - - IP_DROP_MEMBERSHIP failed: Can't assign requested address
Feb 16 10:33:52 nabla 1 2022-02-16T10:33:52.549237+01:00 nabla.albandrieu.com ctld 1294 - - connect(2) failed for <IP_ADDRESS>: Connection refused
I'am using : version: TrueNAS-12.0-U8

Suspecting service not to start at boot time.
If you can access jail shell :
service nexus start

Hi @AlbanAndrieu and @micle546, thanks very much for reporting it.
I'll take a look on this in the upcoming days. will keep you posted.
Thanks.

Hi issue should be fixed by now, a fresh plugin install might be required, or apply the same steps on the commit referenced here.


Fix sorting of rarity and size

Size and rarity are currently sorted alphabetically because they are stored as strings in the database.
Either

Store them as number and do the necessary conversions when retrieving them and processing it in graphql
Do some MongoDB magic to do custom sorting

Since size is derived from the radius we can just sort by radius under the hood when sorting by size is requested.


[User Management] Create new user gives HTTP 422 Unprocessable Entity exception.

Bug Description
When a FidesOps user is creating a new user and clicks the "Save" button, the following toast error message is displayed:
utf-8' codec can't decode byte 0xd8 in position 4: invalid continuation byte
Via Chrome DevTools, you can see the API endpoint (http://<IP_ADDRESS>:8080/api/v1/user) POST is invoked resulting in a HTTP 422 Unprocessable Entity exception.
Steps to Reproduce

Login into FidesOps
Click User Management tab
Click Add New User button
Fill out the form
Click the Save button

Expected behavior
What should happen is that the /api/v1/user endpoint should return a HTTP 200. User should be redirected back to the User Management landing page and visual see the new created user.
Screenshots

Environment

Version:
OS:
Python Version:
Docker Version:

Additional context
Add any other context about the problem here.

Closed via #833


Large write returns without error, but not all data is written

I've created a repro case
https://github.com/marklam/Roundtrip3DArrayOfStructList/blob/partial-writes/ConsolePureHDFroundtrip/Program.fs
This test case (the branch named partial-writes) creates a 2D array of variable-length lists of structures. It writes 8000 but all entries after 596 are null on readback.

Version 2.1.1 contains a fix for your issue. The data were written to the wrong position in the file so it appeared as null in your sample program. It was a bit difficult to figure out the root cause but I think I found a suitable solution.

Looks good to me!
Thanks!


Default Oracle timeout 10 -> 60 sec

https://github.com/ansiblebit/oracle-java/issues/87

fixed on https://github.com/ansiblebit/oracle-java/releases/tag/6.22.0.
please report any new problems you may find.
thank you!


Update Teams-overview.md

Added Prerequisites section with reference links to hardware requirements and specifications of Teams.

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@dstrome can you look at this and see if it fits with the overall direction we want for the landing page?

Closing this PR due to age, inactivity, and conflicting files.
cc: @scanum


Gradle- Versioning of app and lib

It would be great for gradle to be able to know what version of the lib/app subprojects are.
The app/lib subproject should have independent versions, known to Gradle. Uses for versioning:

Appending to jars/ other compiled/bundled output
The versions should be available to the running code, for log output and display
The lib's version should be available to the app's code, if possible

Figured it out, see 'writeVersionConfig' in the build.gradle files


Is "sync: true" required (or should be explained) for Redis?

I love the gem, but it took me a while to figure out that I needed "sync: true" in order to send logger info to Redis. "Sync" is only mentioned once in the README by way an example for another device, so it took me a while to find it, and that was only by adding bunches of "puts foo.inspect" lines in redis.rb. I might be missing some overall pre-requisite knowledge but should this be made clearer in the documentation? Thanks!

The sync option is available for every device, and means that every log message will be immediately flushed to the output. The default behavior is to buffer messages. The option is not required for any device and should always default to false. If you're not seeing log messages written to Redis, you may not be waiting long enough (or writing enough log messages) for the buffer to flush.
If you're not writing tons of log messages and want to see them immediately, you probably want to set sync to true. Otherwise it's best to leave it at the default value of false.
You're right that the sync option should be better documented in the Readme. It's actually inherited from Ruby's built-in IO#sync option, so if you've worked with Ruby IO before, it's the same concept.

I created #45 primarily for the quick testers. I see your point about leaving sync to false for long-running processes, and maybe my suggestion would impact performance for something like Rails, so I'll understand if it's not included as the default in the examples. I also proposed a "logger.close" comment at the end of the example script so people with quick jobs had an easy way to find out how to flush.

FWIW, log rotation in a rails/unicorn environment also requires sync = true. Otherwise, the log file will not be re-opened.

@MichaelDoyle That's interesting. Can you reference any documentation stating this? I couldn't find any.
Also note that if you're using LogStashLogger with Rails, sync will be set to the value of config.autoflush_log. See Railtie source

See: https://github.com/defunkt/unicorn/blob/4e7cab9f1727eccd90780d1ceb14948e0ace36a6/lib/unicorn/util.rb#L12

I find that a bit surprising. I would expect that a flush could be forced before reopening the log file.
If you're using Rails, sync will apparently default to true via the autoflush_log setting. This might be undesirable for other output sources.
I think this deserves further research and documentation. Thanks for bringing this up!

I found some more information from https://unicorn.bogomips.org/TUNING.html:

On POSIX-compliant filesystems, it is safe for multiple threads or processes to append to one log file as long as all the processes are have them unbuffered (File#sync = true) or they are record(line)-buffered in userspace before any writes.

I was not aware of that.

Per #75, it turns out that Unix sockets also default to sync=true. Since Unix sockets are essentially files, this makes sense given the information above.

This is now documented in the Readme. Feel free to add any more comments if any new information arises concerning sync mode.


Naming convention sniffs over-zealous ?

The naming convention sniffs introduced in #500 seem to me to be a bit over-zealous.
The handbook doesn't mention anything about private properties needing to start with an underscore.
And to be quite fair, IMHO, that shouldn't become part of the standard either as that is an outdated PHP4 practice from when you couldn't indicate the visibility of a property.
Ref: https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#naming-conventions
Oh and there is a message error on line 113:
$error = 'Variable "%s" is not in valid camel caps format';

should probably read:
$error = 'Variable "%s" is not in valid snake_case format';

I agree, I don't think that needs to be part of the standard. We could remove that part of the sniff, or we could just disable those particular error messages by default (allowing those that want to use them to re-enable them).
@westonruter, what are your thoughts?

Disabling by default sounds good to me. But since it's all copied from the
Squiz standard removing them isn't going to hurt my feelings either :-)

Maybe we should just remove it, if for no other reason that that it would be added maintenance for something that we don't really use. So @westonruter, if you follow that rule and want to use this sniff and maintain it going forward, I'm fine with just disabling that part by default. Otherwise I'd prefer we remove it. Make sense?

:+1:

See https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/506


Switch back to Trace output for scenario reporting

Microsoft has deprecated Debug in favor of Trace

Looks good to me.


fix: Use correct window to get the devicePixelRatio

The roundOffsetsByDPR utility was using the global window keyword instead of the getWindow utility. This meant that applications that render to child windows would have blurry poppers since the device pixel ratio being used wouldn't be correct. Two cases where that could happen:

Parent window in another monitor
Parent window has a different zoom than the child window

@FezVrasta do you mind taking a look at the CI failures? I don't have enough understanding of the repo to know what action to take on those errors

@FezVrasta  @atomiks  would you be able to help with the errors I'm seeing in the checks? 🙏🙏

It seems to be a problem with CI itself but I'm not sure what's going on to be fair. @atomiks may have some ideas?

Don't know sorry, guess some packages/actions had some breaking changes not in semver or something :|
Probably can just merge and release regardless, @FezVrasta has to release locally though as Rolling Versions somehow can't release the v2.x branch.

https://github.com/floating-ui/floating-ui/releases/tag/v2.11.7


Remove term "bytes" from memory

Have references to the term "byte" replaced with a different terminology. It's misleading in almost every place it's used.
Possible alternatives:

Numbers (N, KN)
Words (W, KW)
Doubles (D, KD)
Values (V, KV)

True byte values can still be displayed, but they should be accurate, which, according to Garry, means they must be a multiple of 8.

number is the best term

'block' is a good one too.

Perhaps a poll could be done to see what users prefer most.

Superceded by #2636


translated in greek : basics/basics.md

Awesome!  Thank you @gemantzu
Do you have a twitter handle?

Same as my nickname here, i'm not very active atm though.


SAC_Bug

in sac.py
s = torch.tensor([t.s for t in self.replay_buffer]).float().to(device)
Traceback (most recent call last):
File "D:\PycharmProject\Deep-reinforcement-learning-with-pytorch-master\Char09 SAC\SAC.py", line 307, in
main()
File "D:\PycharmProject\Deep-reinforcement-learning-with-pytorch-master\Char09 SAC\SAC.py", line 293, in main
agent.update()
File "D:\PycharmProject\Deep-reinforcement-learning-with-pytorch-master\Char09 SAC\SAC.py", line 244, in update
Q_loss.backward(retain_graph = True)
File "C:\Users\lx\anaconda3\envs\torch\lib\site-packages\torch_tensor.py", line 363, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph, inputs=inputs)
File "C:\Users\lx\anaconda3\envs\torch\lib\site-packages\torch\autograd_init_.py", line 173, in backward
Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
RuntimeError: Found dtype Double but expected Float

How to deal with it?

1、change all the dtype to float
2、then i met the next bug,the picture is what i had done


Create CLI overview documentation topic in the user guide

Is your feature request related to a problem? Please describe.
Currently there is CLI content sprinkled throughout various topics, e.g. https://elyra.readthedocs.io/en/latest/user_guide/runtime-conf.html#id1 and https://elyra.readthedocs.io/en/latest/user_guide/runtime-image-conf.html, but there's no formal entry point, that introduces the CLI and common concepts.

I thought about that. Today the CLI has been documented when describing the "main topic" as one way to interface with the content (e.g. metadata) and I thought that was ok. With this, would we remove the CLI content from the topic and promote to its own section/set of documents?


iTunes Store country or region specification

Add an optional country or region code in the URL path, see #1503 for details.

Thanks for the PR,
It looks like the tests aren't running as expected though.
Not sure why it does this, but do you happen to have shields setup on your own Circle CI?
If so, could you remove it from your own and that should let the tests run as expected.

I've added a minor comment to have a look at. In addition to @RedSparr0w 's comment on fixing the build, could you also rename the pull request to "[itunes] my pull request title" so that CircleCI knows to run the tests for the itunes service next time the build runs (see https://github.com/badges/shields/blob/master/service-tests/README.md#pull-requests ).
Thanks

Are we going to address this as part of #1515? If so, let's close this to make sure we're not duplicating any work!

Closing for inactivity. If you're reading this and want this implemented, don't be discouraged. You can grab the commits from the pull request branch using git fetch origin pull/1515/head:pr-1515, address the comments, and reopen.


[Flink-Gelly] [example] added missing assumption to the pageRank example: this is a simplified version of the algorithm so pages must have at least one incoming and one outgoing link

Hi @samk3211! Thank you for spotting this :)
Can you please (1) close #881, (2) add this comment also to GSAPageRank as @andralungu (3) squash your commits to a single one?
Thank you!

I guess the only request that was not fulfilled for this PR was to squash the commits. Then it should be fine.

I've actually included this in #1000. Could you close this PR @samk3211? Thanks!

closed


Site not working today?

Got browser message "This site can’t be reached. The webpage at https://xordle.xyz/ might be temporarily down or it may have moved permanently to a new web address. ERR_FAILED"

use xordle.org, the .xyz domain got shut down


vm_loss config

Hi, can you let me know what is correct training config in stage 1 vm_loss?
Is it in StableDiffusionHead,

drop_prob = 0.1
noise_offset = 0.0
input_perturbation = 0.1
snr_gamma = 5.0
right?

Where can I see proper training config?
Thank you.

Hi @zheedong,
No. The recommendation is from the Hugginface team instead of us. We use the default configurations as follows:

drop_prob = None
noise_offset = 0.0
input_perturbation = 0.0
snr_gamma = None

The configuration can be modified, but we have not. So, the configuration is just the default.

Hi @zheedong,
Is it clear now or you need some more help?

Ah sorry for late.
No thank yo for your help.


Rename General screen to account

Fixes #1458
Short description
Renames the former General Screen to Account. With this, it also updates the components/routes/CSS etc.
Definition of Done

[x] Steps to manually test the change have been documented
[x] Acceptance criteria are met
[ ] Change has been manually tested by the reviewer (dApp)

Steps to manually test the change (dApp)

Go to the "general scree"
Verify that it has been renamed to Account
Routes are /account/, /account/raiden, /account/backup
Everything works as before

@taleldayekh did you check it locally to verify that it works properly?


modules: integration tests vs various OCI registry backends

https://github.com/cue-lang/cue/issues/2817 and #2840 both highlight the fact that in reality OCI implementations can vary. This is not really surprising, but for CUE modules users, we should try where possible to limit these surprises.
Introducing some form of integration tests vs various OCI registry backends will help to provide an early flag of a hopefully large subset of problems.
Creating this issue as a placeholder for such tests.

I think this should go in our existing end-to-end test suite in internal/e2e; we already cover Google Cloud, which needs a special step to set up the gcloud authentication. We could copy a similar mechanism for other registry services.
I suspect we'll need one testscript per service, even if over half of the testscript looks the same, because each service will need its own way to set up auth via a secret, and some may require a custom CUE_REGISTRY config due to e.g. repository name restrictions.

Closing as a dup of #2933


Use Broadcast channels

[x] Use tokio::sync::broadcast::channel() instead of flume::bounded, each topic gets a channel.
[x] Subscribing streams get owned copy of receiver(subscribed once) that can recv().await for new publishes.
[x] Publishing streams must ask for write() lock every time to perform send().
[x] Topic -> Channel mapping is performed by shared Arc<Mutex<HashMap>>, this is accessed every time a new subscriber is created or when a stream wants to publish.

NOTE: Subscribers can create Rx in case no publisher exists, then they shall wait for a publisher to access the Tx and forward publishes to all subscribed streams. I am not sure if broadcasts are the best solution, this is just my proposal

Change in plan, closing this in favor of


Mapping a value to the return rather than the entire object.

I would like to just persist the item.codeId to the ng-model for myObject.stateCode, hopefully this binding would also select the correct option in the drop down when the value already exists.   How do I set it up to do that?
Below is my current code.
<ui-select ng-model="myObject.stateCode" id="stateCode">
    <ui-select-match placeholder="Select a state...">{{$select.selected.codeDescription}}</ui-select-match>
    <ui-select-choices repeat="item in constants.states | filter: $select.search" value="{{$select.selected.codeId}}">

    </ui-select-choices>
</ui-select>

Hello ! Me too i've got the same problem, i have all of the latest versions ...
The ui select doesnt display the loaded value .
This is my UI Select code :+1:
[
Station

{{$select.selected.nom}}
				<ui-select-choices repeat="station.nom as station in stations  | filter: {nom: $select.search}">

				</ui-select-choices>
			</ui-select>

 ](url)


Query benchmarks - in scope for OmopSketch?

Whether incorporating something like this is in scope https://github.com/oxford-pharmacoepi/ServerBenchmark?

I dont think it is of the scope of OmopSketch, but we could implement it as part of the characterisation @cecicampanile and later see where it fits.
Unless @martaalcalde thinks that it fits well in OmopSketch

Happy if Cecilia implements this in the characterisation!


Can only download 360p from Youku

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.03.14
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log
I initially haven't been able to download Youku videos [error -6004: 客户端无权播放,201], but was able to do so after changing the code, as suggested in #28460
        # request basic data
        basic_data_params = {
            'vid': video_id,
            'ccode': '0532',
            'client_ip': '<IP_ADDRESS>',
            'utid': cna,
            'client_ts': time.time() / 1000,

However, videos are only downloading at 360p, even after setting the video resolution on the page to 720p, or manually setting the format (-f "best[height=720]")
I also checked available formats, and I'm getting this:
[youku] XNTEyMDEyMDU3Ng: Retrieving cna info
[youku] XNTEyMDEyMDU3Ng: Downloading JSON metadata
[info] Available formats for XNTEyMDEyMDU3Ng:
format code  extension  resolution note
0            mp4        640x360    109.91MiB
h3           mp4        960x540    193.10MiB
2            mp4        1280x720   318.00MiB (best)

Sample link: https://v.youku.com/v_show/id_XNTEyMDEyMDU3Ng
Please advise. Thank you in advance!

Hi, could you tell me how to change the code? Having the same issue and would appreciate knowing how to temporarily fix it like you have done. Thanks

Hi, could you tell me how to change the code? Having the same issue and would appreciate knowing how to temporarily fix it like you have done. Thanks

Hi! Just edit the youku.py file in the extractor subfolder of your youtube-dl. Find the part that I mentioned above, and change the code from 0590 to 0532.
Hope this helps!

Hi, could you tell me how to change the code? Having the same issue and would appreciate knowing how to temporarily fix it like you have done. Thanks

Hi! Just edit the youku.py file in the extractor subfolder of your youtube-dl. Find the part that I mentioned above, and change the code from 0590 to 0532.
Hope this helps!

Hello, thanks for the reply but I do not seem to have an extractor subfolder for youtube-dl. I just have the youtube-dl.exe file and the 3 ffmpeg files for audio in the same folder. I am using Windows, if that is any help.

Hi, could you tell me how to change the code? Having the same issue and would appreciate knowing how to temporarily fix it like you have done. Thanks

Hi! Just edit the youku.py file in the extractor subfolder of your youtube-dl. Find the part that I mentioned above, and change the code from 0590 to 0532.
Hope this helps!

Hello, thanks for the reply but I do not seem to have an extractor subfolder for youtube-dl. I just have the youtube-dl.exe file and the 3 ffmpeg files for audio in the same folder. I am using Windows, if that is any help.

Try looking here:
C:\Users[Your Username]\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\youtube_dl\extractor

Hi, could you tell me how to change the code? Having the same issue and would appreciate knowing how to temporarily fix it like you have done. Thanks

Hi! Just edit the youku.py file in the extractor subfolder of your youtube-dl. Find the part that I mentioned above, and change the code from 0590 to 0532.
Hope this helps!

Hello, thanks for the reply but I do not seem to have an extractor subfolder for youtube-dl. I just have the youtube-dl.exe file and the 3 ffmpeg files for audio in the same folder. I am using Windows, if that is any help.

Try looking here:
C:\Users[Your Username]\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.7_qbz5n2kfra8p0\LocalCache\local-packages\Python37\site-packages\youtube_dl\extractor

Unfortunately I do not see that folder in the specified directory. Not sure what else to try, sorry for the bother.

I'm encountering the same problem. If downloading with --all-formats, formats 0 (360p), 2 (720p) and 3 (1080p) result in the same 360p file, whereas format h3 yields a 540p file. This is with both direct video URLs as well as playlist URLs. I'm running youtube-dl with --cookies and a cookies.txt with an active Youku subscription.

https://github.com/ytdl-org/youtube-dl/issues/30424


Edit pages’ sticky footer hides critical parts of the UI

Issue Summary
You can't add new streamfield blocks at the bottom of a edit page on mobile, and this hides various parts of the UI at other screen sizes.
Steps to Reproduce

On a IOS device open a browser and go to an edit page in the admin.
Make sure the last field on that page is a streamfield. Containing a block.
Try to add a block below. You can't. The + button is behind the save buttons.

I expect the save buttons to go below the form/content.
I also wonder why the save buttons are always visible. They take up a lot op space. Up to 1/4 of the screen on smaller devices.
In this example the 'Add another' button - for a list stream field item - is also below the save buttons.

Technical details

Wagtail version: 2.1
Browser version: IOS Safari 11.4

StreamField front-end will be completely reworked in #4481 but keeping this issue open for now.

The problem is the fact that the save/preview buttons are blocking any content below it. The issue is probably not only with streamfields, but with all page content.
My suggestions resolve the issue:

Save/Preview buttons should not overlap, but just be at the bottom op the page
OR
There should be a bottom padding at the page so the content always can scroll above the Save/Preview buttons.

I think option 1 is best. Since the save buttons can take up to 1/4 of the screen. Which is a waste of space anyway.
I'm happy to submit a PR. But I think a decision has to be made first.

The problem is the fact that the save/preview buttons are blocking any content below it. The issue is probably not only with streamfields, but with all page content.
My suggestions resolve the issue:

Save/Preview buttons should not overlap, but just be at the bottom op the page
OR
There should be a bottom padding at the page so the content always can scroll above the Save/Preview buttons.

I think option 1 is best. Since the save buttons can take up to 1/4 of the screen. Which is a waste of space anyway.
I'm happy to submit a PR. But I think a decision has to be made first.

As you say this has nothing to do with StreamField and everything to do with the buttons overlapping with a quarter of the screen. I think option 1 is by far superior — any overlap is always annoying when you have so little screen space to start with.

My bad, this issue and a few others you've opened specifically called for StreamField issue and I did not think this further 😞
I've now removed the StreamField tag on the issue and would also be in favour of option 1.

@allcaps if you want to make a PR I’m happy to review it 🙂 Implementation-wise — would be best if we could achieve this by removing code, perhaps switching media queries around so the default layout is the mobile one and “up from mobile” gets the overlap added. I haven’t actually looked at the code so this might not be feasible exactly like that though.

@rifuso could you provide us with examples? I think it would be a pretty easy job and clear improvement for someone to make a PR to "un-sticky" this footer on mobile. For other screen sizes, we'll need to look at the actual issues.

With #5946 merged this is now fixed, and will be released in Wagtail 2.10 🙂 thank you to everyone involved!
There may be further UX improvements to do here, so there isn’t as much scrolling to save a page on mobile. Please open another issue to discuss this.


Revamped Preferences UI, tidied code

Nice work on Spotify Notifications, I've been using it for a while and found it very useful! (I don't know why Spotify still doesn't have native Mac notifications..)
Changes:
UI:
I replaced the strange combo boxes in the Preferences window with checkboxes, and organised the window better:

A small addition is the ability to skip the current song (hover on notification to show button), like with iTunes:

Code:
As for code, preferences are now updated and kept in sync via bindings, rather than manually calling methods/updating when the user clicks.
Code's a bit more concise/tidy by using dot-syntax; removing unnecessary @synthesize lines; defining a few shared keys for storing preferences in SharedKeys.h instead of repeating strings in code (with the possibility of mistakes); and marking code sections with #pragma mark - Section Name for easier navigation.
This uses #27, and solves #18, #23 and #53.

Edit: Critical problem I'm just fixing.

Nice work on Spotify Notifications, I've been using it for a while and found it very useful! (I don't know why Spotify still doesn't have native Mac notifications..)

Thanks! And yeah, I'm not sure why they have continued to ignore their OS X users who've requested the feature - especially when it shouldn't take more than a couple lines of code.

I replaced the strange combo boxes in the Preferences window with checkboxes, and organised the window better

Awesome! That actually makes a lot of sense, I'm not sure why I used dropdowns when I could have used checkboxes.

A small addition is the ability to skip the current song (hover on notification to show button), like with iTunes:

Super cool! Thanks for getting that implemented.

As for code, preferences are now updated and kept in sync via bindings, rather than manually calling methods/updating when the user clicks.

Code's a bit more concise/tidy by using dot-syntax; removing unnecessary @synthesize lines; defining a few shared keys for storing preferences in SharedKeys.h instead of repeating strings in code (with the possibility of mistakes); and marking code sections with #pragma mark - Section Name for easier navigation.

These changes look pretty great. If you haven't already realized, Objective-C isn't my strongest language and I probably miss a lot of best practices, so please feel free to fix anything that you think could be better.

I'm not sure if you're done with this pull request or still working on stuff, so let me know when these changes are complete and I'll do a review.
Also, if you have further changes that aren't related, multiple small pull requests are preferable to a single large one.

I have a commit or two to add – I'll leave another comment when I'm done.
I am sorry this turned into such a massive pull request with so many commits/such a long changelog! Only intended to make a UI change, but then looked over the code and felt like making a few tweaks.
I'll create separate pull-requests for less-related changes in future for sure.

Ready to merge this pull request with your approval. I'll leave changelog/version number to you.

Thanks @sebj!
Unfortunately I won't have time to look at this until this weekend, but I'll ping you after I take a look!

Can this get merged, please? :)

👍

@citruspi I would be interested in contributing to this project/adding new features, but this seems like a fairly significant changeset so I'd probably want to wait until it is merged.

@citruspi Is this getting merged at some point?

Lesson to everyone, don't fork someone's repo and then refactor most of it suddenly. : | FeelsBad for @citruspi now.

@sebj Which version of macOS did you develop and test this on?
I went to go cut the 0.6.0 release for #72  and I noticed some odd behavior on my macOS Sierra machine.
On macOS Sierra the notification has action buttons and doesn't disappear by itself - it needs to be closed manually. On macOS El Capitan, the notification doesn't have action buttons and disappears automatically.
The action buttons themselves are fine, but I suspect they're causing the notifications to stick around as opposed to disappearing automatically. If that's the case, it might make sense to put them behind a feature toggle.
El Capitan:

Sierra:

I think it depends whether Spotify Notifications is set to use "Banners" or "Alerts" in the Notifications pane of System Preferences. I initially could not recreate your Sierra – for me it behaved the same on Sierra as it did in El Capitan (hover to see buttons, notification automatically dismisses). I went to System Preferences, changed Spotify Notifications from "Banners" to "Alerts" style and now I get the same behaviour as you. It may be that Sierra changed the default alert style? I'm not sure exactly..

I might be able to shed some light on this (long time user, first time poster). The NSUserNotificationAlertStyle key in Spotify Notifications-Info.plist is set to alert, not banner (banner is the default, see: https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html).
That means that unless a user manually changes their Notification Center preferences for Spotify Notifications to 'Banners', they'll get the 'Alerts' style notification by default, which are persistent until dismissed, hence the additional 'Close' button they have. @citruspi, the action button on a 'Banners'-style notification only appears on mouseover. I can confirm it works correctly for me on Sierra.

@robinnorth There we go, thanks! Completely forgot about setting the value in the Info.plist.

@citruspi Merged @robinnorth's small PR in to fix this.

No problem, @sebj! Happy to be able to contribute (even if only in a small way) to a project that I use on a daily basis.

@robinnorth Thanks for the contribution, it's been included in the version 0.6.0 release.
Thanks for taking care of the pull request @sebj.


Merge Development

Do not merge: confirm if development should be merged to base at this point.

Not ready to merge dev right now - closing PR


feat: supports TTL for greptimedb data storage

What's changed?
The following PR of #2095. It adds TTL for auto-created database, 30 days by default.
Checklist

[x]  I have read the Contributing Guide
[x]  I have written the necessary doc or comment.
[ ]  I have added the necessary unit tests and all cases have passed.

Add or update API

[ ] I have added the necessary e2e tests and all cases have passed.

I missed the TTL option in the last PR, sorry for that. Please take a look, thank you. @zqr10159 @tomsun28


Time Series Insights single page webapp

Please provide more/complete documentation about the usage of the javascript how to aggretate, call patterns, and transformation of the compressed result, of the other options that are available but not shown in the example. Such as "getTimeseriesInstances". It is not clear to me how to get these other commands/possibilities to work. I have been trying, but can't get it to work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 691ee7f7-6ffa-1f2e-bc90-abaae2d6faec
Version Independent ID: f8a60b14-3a2c-9e16-77a9-365c50e0ca03
Content: Tutorial: Explore the Azure Time Series Insights JavaScript client library
Content Source: articles/time-series-insights/tutorial-explore-js-client-lib.md
Service: time-series-insights
GitHub Login: @ashannon7
Microsoft Alias: anshan

@AndertBos Thanks for the feedback on this item! I have assigned the issue to the content author to review further and update the document as appropriate.

@philmea Could you please check this and provide suggestions.

@TheGrungeByte could your team please investigate this issue? Thanks!

+Rahul
Thanks Phil.
Hi Rahul – Can you please take a look when you get back tomorrow?
Cheers,
Deepak
From: Phil Meadows<EMAIL_ADDRESS>Sent: Wednesday, January 2, 2019 10:12 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Deepak Palled<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Time Series Insights single page webapp (#21061)
@TheGrungeBytehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTheGrungeByte&data=02|01|deepak.palled%40microsoft.com|c56ad32f2e114495639d08d670ddc45d|72f988bf86f141af91ab2d7cd011db47|1|0|636820495119768932&sdata=3vebJvBWw%2FZ5oVMCtKDJoPe7uhMjEywIKSRVCb30qNY%3D&reserved=0 could your team please investigate this issue? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F21061%23issuecomment-450938532&data=02|01|deepak.palled%40microsoft.com|c56ad32f2e114495639d08d670ddc45d|72f988bf86f141af91ab2d7cd011db47|1|0|636820495119768932&sdata=qgs%2B8308U9%2BvUgeekpDFDzZ%2BPWu6qK6PmbhVzZVpDRY%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FApPxLALKmF04XXC9A3PjGuSmEEC-bn-Rks5u_PZmgaJpZM4Zbnu4&data=02|01|deepak.palled%40microsoft.com|c56ad32f2e114495639d08d670ddc45d|72f988bf86f141af91ab2d7cd011db47|1|0|636820495119778941&sdata=B5h%2FH58xHHWQwaM%2FpDKt66Z11RHt73RWXyBoWLoVdgE%3D&reserved=0.

@philmea - Should this still be assigned to you? If not, please email the CXP team/tag the original CXP person and have them reassign.

I recently published the first wave of rather complete documentation for the SDK, have updated the examples page to remove the need for authentication for standalone examples that don't use the platform, and have published an ever growing list of examples that illustrate SDK usage.  We will be expanding the documentation over the next couple weeks to cover a few more use cases.  Please let me know if you have specific questions about how to use the TSI SDK, or if something is unclear from the documentation


Copy relevant ADRs from hermes repository

Closes: #140

PR author checklist:

[ ] Added changelog entry, using unclog.
[ ] Added tests.
[ ] Linked to GitHub issue.
[ ] Updated code comments and documentation (e.g., docs/).
[ ] Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

[ ] Reviewed Files changed in the GitHub PR explorer.
[ ] Manually tested (in case integration/unit/mock tests are absent).

Thank you both, appreciate the super speedy turnover!
Now I can refer users/devs to module-related ADRs on this repo (instead of the hermes repo, which can be confusing).


MM-17059 Add line number to code blocks

Summary
This PR adds line number to code blocks.
Ticket Link
Fixes https://github.com/mattermost/mattermost-server/issues/11953
Screenshot

Thanks @PunitGr for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@PunitGr do we have control to do it like this UI:

Adding @hmhealey in case he has thoughts on implementation

@esethna Hey, it is doable but it is kinda hacky solution (and has more chances of breaking styles). I tried doing it but then it makes things more complex.
@hmhealey What would you suggest for this problem?

It definitely looks like we'd need something more complicate for this, but since this style of code block is fairly common elsewhere, I'm sure someone else has come up with a good way to do this. highlight.js is also a popular library, so it might have some support for adding line numbers built into it.

Hey @hmhealey, currently as per docs of highlight.js line numbers aren't supported.
https://highlightjs.readthedocs.io/en/latest/line-numbers.html

@hmhealey any thoughts on how to proceed with this one? I don't think we can take it as is, the line numbers should be styled differently and not be selectable

We could try this plugin for highlight.js or coming up with a component to do this ourselves. The plugin is probably easier to implement, but we may run into issues between it and our other styling

Hey @hmhealey, I could try using the plugin for this. Will update the PR soon. :)

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

@PunitGr how is this going, let us know if we can provide any more guidance

@esethna Sorry, I've been out vacationing recently. I'll look into it over the weekend. Cheers ;)

@esethna Here is the screenshot of the updated UI.
@hmhealey I tried the plugin but it didn't work that work. So, I found a solution for the problem :)

@esethna Sorry for the delay in update. Please let me know your comments on this one. Thanks 🙂

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-3578.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Looking great!
I found one bug where multiline code blocks that don't have a syntax type identified will show on a single line:
sdgsdfgdfsg
sdgsdfg
dsfgdsg

New commit detected. SpinWick will upgrade if the updated docker image is available.

Test server creation failed. See the logs for more information.

@PunitGr It looks like some of the unit tests are failing now which is preventing the test server from being updated. Could you fix those for us?

New commit detected. SpinWick will upgrade if the updated docker image is available.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Test server creation failed. See the logs for more information.

Test server creation failed. See the logs for more information.

@esethna Please check now. Fixed the changes that you requested for. :)

Thanks @PunitGr! Looks like the build failed, can you help take a look? If any questions, don't hesitate to let us know :)

@jasonblais @esethna The build failed because of failure in upload-s3-sha and upload-s3. I think I'm not authorised to perform this action. Can you guys please take a look.
Attaching a screenshot for reference.

@PunitGr re-running the checks now :+1:

@cpanato / @stylianosrigas wondering if you'd know why this branch gets an unauthorized error for upload-s3 step?

Because some permission issues. It is fixed for all new prs and for existing one need a branch update or open and close or trigger manually on circle ci.
For this i will close/open because im on phone

Test server destroyed

Creating a new SpinWick test server using Mattermost Cloud.

Test server creation failed. See the logs for more information.

Test server destroyed

Creating a new SpinWick test server using Mattermost Cloud.

Test server creation failed. See the logs for more information.

Test server destroyed

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-3578.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit be4b644e48da6169aa00ece5c41a50b496b125ff.
Access here: https://mattermost-webapp-pr-3578.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 8bf0eff791116d1402b8ca28a67663552e51fafb.
Access here: https://mattermost-webapp-pr-3578.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 191670e7c2317746c94971a35c563b2b7de9dc09.
Access here: https://mattermost-webapp-pr-3578.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

New commit detected. SpinWick will upgrade if the updated docker image is available.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Test server creation failed. See the logs for more information.

Test server creation failed. See the logs for more information.

Mattermost test server updated with git commit 018cc0c13c97dfedc55468b2f8272b7adc0b7401.
Access here: https://mattermost-webapp-pr-3578.test.mattermost.cloud

@PunitGr @esethna When I use a code block that has indenting, the indentations are kept when I don't assign a language to the markdown, but when I assign a language the indentations are lost. This feels like a deal breaker to me, because it makes the code way less readable.

Agree, we should fix that

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 054af0a1baa617ddb315f35e66ddac6fe25d3366.
Access here: https://mattermost-webapp-pr-3578.test.mattermost.cloud

For reference on the search results highlighting, this is how it currently looks on master

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit c8380993b95a87b496064a4e7dd5f71d168a4216.
Access here: https://mattermost-webapp-pr-3578.test.mattermost.cloud

New commit detected. SpinWick will upgrade if the updated docker image is available.

New commit detected. SpinWick will upgrade if the updated docker image is available.

@hmhealey Hey, fixed the issues you reported.

Hi @Willyfrog, I don't mind using the library. But the problem will still be the same because there is no support for vertical line with the line number.
Also, with the library we aren't sure that search is gonna work or not. For this case I would really like to avoid use of library because it will increase the chances of breaking any layout.

New commit detected. SpinWick will upgrade if the updated docker image is available.

Mattermost test server updated with git commit 2dad883c8d8bc77259497970d2c8b8e0b38c8977.
Access here: https://mattermost-webapp-pr-3578.test.mattermost.cloud

Test server destroyed

Thank you @PunitGr for adding this great improvement :tada:

Love this feature. Only issue is the line numbers get copied along with the code (for copy paste actions) so kinda useless for sharing code snippets. Workaround is to edit the block and then copy the code from the editor.

Server 5.19.0
Client 4.3.2
Desktop Gnome (Shell) on Ubuntu 18.04

@erik-alatest completely agree! Fix for it is currently scheduled for v5.21: https://mattermost.atlassian.net/browse/MM-22147

This is a nice feature! One additional tweak that would be even better would be the ability to customize the start number instead of being forced to start from 1. This would be handy when quoting code and referencing line numbers, so that the numbers in mattermost can be that same as the numbers in the real codebase.