Change offset to pixels

This commit:

Changes offset_in_pixels to u64. In my tests this also corresponds to the actual size of the padding
Add offset also for level = 0
Add width and height properties to the level
Expose the height, width, mpp_x and mpp_y of each level in the public API.

It is forked from the changes I made to make a read_region function work.

 The values should all be 0 for level 0, and will be incorrect if included in the for loop.

@Falcury Thanks for the "merge". Are you sure the offset isn't there in level 0? I checked with the isyntax_example.

The way I have it in my head is: level 0 has offset 0 (i.e. needs no initialization because already zero-initialized). Then each successive level has a higher offset (as calculated in terms of level 0 pixels) that follows the formula.
But, I also know I’ve gotten this stuff wrong in the past (multiple times)... I’ll run some tests tomorrow, including using your TIFF converter, and try to fix it if there are still errors!

Great, thanks! We use SlideScore, which uses the Philips SDK, as a sanity check I will look up some slides we annotated there and compare with isyntax -> tiff in the different levels to see if they align in the same way.
I think in the dwt in level 0, what they do is have offset = 3*(2^n - 1), which drops by a factor of 2^scale each step so that at the end (lowest level) you end up at 3 * (2^n - 1)/2^n = 3 * (1 - 2^{-n}) ~= 3, which is the minimal padding required to compute the dwt they use (3).

I think in the dwt in level 0, what they do is have offset = 3*(2^n - 1), which drops by a factor of 2^scale each step so that at the end (lowest level) you end up at 3 * (2^n - 1)/2^(n-1) ~5, which is around the minimal padding required to be able to compute their dwt.

Probably this gives 'approximately' correct results, but I'm almost certain that this is not fully correct. Philips' documentation on the file format also specifies the per level padding to be ((3 << level) - 2). I believe this refers to the encoding process, where level 0 is the base image and for each successive encoding step, padding is added to enable the wavelet transform to proceed correctly. For decoding, you have to 'think in reverse' as to what is going on and the actual offset for the decoded image ends up being ((3 << (level-1)) - 2).


Log Refactor

Per our discussion in Discord, he's a rough outline of my proposal
class RuneDrop(models.Model):
    TYPE_ENERGY = 1
    TYPE_FATAL = 2
    ...
    type = models.IntegerField(choices=TYPE_CHOICES)
    stars = models.IntegerField()
    ...

# i.e. grindstones (not crafted runes)
class RuneCraftDrop(models.Model):
    ...

class MonsterDrop(models.Model):
    monster = models.ForeignKey(Monster, on_delete=models.CASCADE)
    grade = models.IntegerField()
    ...

class ItemDrop(models.Model):
    DROP_COSTUME_POINT = 102
    DROP_UPGRADE_STONE = 103
    ...
    item = models.IntegerField(choices=DROP_CHOICES)
    quantity = models.IntegerField()

class LogEntry(models.Model):
    wizard_id = models.BigIntegerField()
    summoner = models.ForeignKey(Summoner, on_delete=models.SET_NULL, blank=True, null=True)
    timestamp = models.DateTimeField(blank=True, null=True)
    server = models.IntegerField(choices=Summoner.SERVER_CHOICES, null=True, blank=True)

    source = models.ForeignKey(Source)
    rune_drops = models.ManyToManyField(RuneDrop)
    rune_craft_drops = models.ManyToManyField(RuneCraftDrop)
    monster_drops = models.ManyToManyField(MonsterDrop)
    item_drops = models.ManyToManyField(ItemDrop)

class Source(models.Model):
    # this makes it easy to distinguish among "trivial" sources that don't need child objects
    CHOICES = {
        # rifts, raids, and world bosses might also be categorized generically as "dungeons"
        # even if the child objects are different (due to different fields)
        DUNGEON: 'dungeon',
        # this might need to be a Source if "slots available" mean something
        SHOP_REFRESH: 'shop_refresh',
        WISH: 'wish',
        # scroll/summon types
        ...
        # box types
        ...
        # or expanded as individual "craft types"
        RUNE_CRAFT: 'rune_craft',
    }
    type = models.IntegerField(choices=CHOICES)

# extra (often random) data fields stored on the child objects
class LevelSource(Source):
    battle_key = models.BigIntegerField(db_index=True, null=True, blank=True)
    level = models.ForeignKey(Level, on_delete=models.CASCADE, blank=True, null=True)  # Will replace the dungeon/stage/difficulty fields eventually
    success = models.NullBooleanField()  # Null value here is an incomplete record from a log that needs the start and result commands to fill in completely
    clear_time = models.DurationField(blank=True, null=True)

class RaidSource(Source):
    ...
class WorldBossSource(Source):
    ...

class WishSource(Source):
    wish_id = models.IntegerField()
    wish_sequence = models.IntegerField()
    crystal_used = models.BooleanField()

I assume you're done with this and it should be closed (but I didn't want to close it if there was anything left to harvest).


🔧 MAINTAIN: Fix typo

Cheers! Let me know if what I've written is all understandable, or requires any further clarification 😬

Thanks!


pdf_url error (probably just me)

Apologies if this is the wrong place for this - But I'm struggling with basic implementation.
In the code below, where is the pdf_url: option looking? Is there a best place in the application to store your pdf files?
<%= pdfjs_viewer pdf_url: "/sample.pdf", style: :minimal %>
I've been trying to resolve the following error for quite awhile without success:
PDF.js v1.7.225 (build: 17d135f) Message: Missing PDF "http://localhost:3000/sample.pdf".
I have a sample.pdf file in the root of my application.

@brendangillies where exactly is the sample.pdf in your application structure? For this to work, it should be in public/ and Rails needs to be configured in a way that it serves assets from public/.

You should check for permissions of the sample.pdf file. Also check the application logs, maybe they'll give you some information.
To answer Is there a best place in the application to store your pdf files?:
If you only have public accessible data, you can put them in public/<somewhere>. But if you need a permission check, you should put them in a seperate folder like <Rails.root>/uploads, and then use send_file to send it from your rails app. To speed up the file download, you can use mod_xsendfile (apache) or x-accel (nginx). See nginx tutorial and apache tutorial

Hi Yves,
Thank you very much for this information - I'm not sure why but for some
reason I assumed that the pdf would not come through the asset pipeline.
The application I'm working on will display confidential pdf information,
so I'll have to pursue the separate folder option you've described.
I am unable to try the proposed solution until later tonight (I live in
Western Canada) - I will let you know ASAP when I am able to successfully
implement.
Thanks again,
Best,
Brendan
On Mon, Oct 23, 2017 at 2:44 AM, Yves Siegrist<EMAIL_ADDRESS>wrote:

You should check for permissions of the sample.pdf file. Also check the
application logs, maybe they'll give you some information.
To answer Is there a best place in the application to store your pdf
files?:
If you only have public accessible data, you can put them in
public/. But if you need a permission check, you should put
them in a seperate folder like <Rails.root>/uploads, and then use
send_file
http://api.rubyonrails.org/classes/ActionController/DataStreaming.html#method-i-send_file
to send it from your rails app. To speed up the file download, you can use
mod_xsendfile (apache) or x-accel (nginx). See nginx tutorial
https://mattbrictson.com/accelerated-rails-downloads and apache tutorial
https://makandracards.com/makandra/990-speed-up-file-downloads-with-rails-apache-and-x-sendfile
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/senny/pdfjs_viewer-rails/issues/39#issuecomment-338589143,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APpkCIFrujfWvS7SGygi9tRhLAccvyjIks5svFHTgaJpZM4QBrH5
.

--
Brendan Gillies EIT
brendangillies.com
linkedin.com/in/brendangillies

@brendangillies please check my edit.. you probably didn't get an update via email.

Closing for the same reason as #40.
The question is mostly about Rails and not this gem. All that pdfjs_viewer-rails needs is a file that's accessible via a URL. For further details on how to implement something like this, please consult a Rails support forum or Stack Overflow.


Add link to the holiday experimental target

Link takes you to: https://microsoftsam.github.io/pxt-holidays/controller.html

This editor is published by you personally... add your logo instead of Microsoft

My logo!! I hadn't realized I had one..


[DRAFT] bgv: add bgv dialect definition

This is a very early draft, and collected a lot of inspiration from HECO, Zama, HECATE.
There's a few things commented and noted here:
Representing parameters:

I liked Zama's TFHE approach of having an unparametrized representation that could then be specialized via a pass to params.
The ciphertext itself IMO only needs to have the degree (e.g. is it encrypted with (1, s, s^2) or (1, s)) and the modulus level (which can be an index in the range of the chosen leveled moduli of the scheme). The rest of the ring parameters can be module level.

Unifying the relinearization operation and the "degree" of the ciphertext:

Galois automorphism: this is the slot rotation operation, and I could generalize the notion of degree above with whatever the ciphertext is encrypted against (e.g. (1, s) or (1, s^2) after applying the automorphism)). This could also generalize relinearization keys and galois keys.

The ciphertext itself IMO only needs to have the degree (e.g. is it encrypted with (1, s, s^2) or (1, s)) and the modulus level (which can be an index in the range of the chosen leveled moduli of the scheme). The rest of the ring parameters can be module level.

Just some super quick feedback (on a plane with poor wifi, so didn't look at the code yet) on the naming: I think "degree" might be confusing, as I usually understand that to mean the polymod degree n (4096, 8k, 16k, etc). Of course, the way you're using it also makes sense, and I think calling the number of polynomials in a Ciphertext it's "size" is equally confusing, just in the opposite direction (assuming batching where the number of slots is equal to n). Sorry for the not-so-helpful feedback ;)

The ciphertext itself IMO only needs to have the degree (e.g. is it encrypted with (1, s, s^2) or (1, s)) and the modulus level (which can be an index in the range of the chosen leveled moduli of the scheme). The rest of the ring parameters can be module level.

Just some super quick feedback (on a plane with poor wifi, so didn't look at the code yet) on the naming: I think "degree" might be confusing, as I usually understand that to mean the polymod degree n (4096, 8k, 16k, etc). Of course, the way you're using it also makes sense, and I think calling the number of polynomials in a Ciphertext it's "size" is equally confusing, just in the opposite direction (assuming batching where the number of slots is equal to n). Sorry for the not-so-helpful feedback ;)

If there are only the three options, I feel like an enum attr would be better than an integer. It could be called EncryptionType or RelinearizationPhase, or something like that.

Yes! Completely agree with this feedback about the terminology "degree".
To me, size would also be confusing in the case of the galois automorphism / rotation applied, since the "Size" is still 2 there, but the power of s is distinct. "Phase" directly would seem like the encoded plaintext result.

If there are only the three options, I feel like an enum attr would be better than an integer. It could be called EncryptionType or RelinearizationPhase, or something like that.

There's not only three options, but rather any amount, we could multiply twice without relinearization and get (1, s, s^2, s^3) for e.g., and can get any (1, s^i) depending on the rotation applied.

EncryptionType or RelinearizationPhase

These are good options, the canonical form is always (1, s). We could then have an optional attr (a tensor of monomials)  called KeyPhase?  OR we could consider it as a "basis" for the ciphertext - so it could be RelinearizationBasis or KeyBasis?

the canonical form is always (1, s). We could then have an optional attr (a tensor of monomials) called KeyPhase? OR we could consider it as a "basis" for the ciphertext - so it could be RelinearizationBasis or KeyBasis?

I really like the idea of a "KeyBasis", as this could also be used in multi-key settings! I also agree it should be optional, so we don't clutter up the textual representation and API.

Some quick updates:

I've placed the ciphertext "dimension" (number of polys / size) as a type attribute: this is because it can't really be inferred from ops, e.g. when it's a block argument, and it seems necessary to have when lowering to a specific sized tensor of polynomials

Perhaps a ring specialization also needs to occur for the same reason that poly requires a ring on its type? originally i thought it would be fine as a module level attribute, but it may need to be on the type to lower the type to the tensor of polys in that ring @j2kun @AlexanderViand-Intel

Relinearization now takes a from_basis and to_basis attributes describing the key basis transformation. I'm not totally convinced they need to be type attr's. It may if it follows the same block argument logic, but at the same time we can always assume it's relative to the original args (the block args are encrypted canonically)

Comments addressed!


file_system: limit thread_io target os

Signed-off-by: MuZhou233<EMAIL_ADDRESS>
What is changed and how it works?
Close #11698
Caused by #11667
What's Changed:

thread_io only support on linux now

Check List
Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)

Release note

/cc @Connor1996

/merge


Add ProphecyPHPDocRector rule

fixes #83

Thanks 👍 seems almost finished 🎉
Do you need help with PHPStan or can you handle it?

I've cherry picked your rule and fixed the PHPStan errors here:
https://github.com/rectorphp/rector-phpunit/pull/115

Thank you for the work :+1: :clap:

@TomasVotruba Thx for fixing the open issues 👍

👍


No type metadata for decorated properties with user defined types

Describe the bug
some ORM libraries e.g sequelize depend on decorated property metadata in order to resolve the model properties for it.
When using swc as a transformer they fail because swc transforms any type into a  "design:type": Object even for simple types e.g type a = string / type b = '123' | '456' etc...
Input code
type someType = string;
@decorator
function someDecorator(): string {
    return 'some decorator';
}

class Foo {
    @someDecorator()
    someProp: someType
}

console.log(returnType);

Config
{
  "jsc": {
    "parser": {
      "syntax": "typescript",
      "decorators": true
    },
    "transform": {
      "legacyDecorator": true,
      "decoratorMetadata": true
    },
    "target": "es2019"
  },
  "module": {
    "type": "commonjs"
  },
  "minify": false,
  "isModule": true
}

Playground link
https://play.swc.rs/?version=1.2.222&code=H4sIAAAAAAAAAyupLEhVKM7PTQ0BMWwVikuKMvPSrbkcUlKT84sSS%2FKLuNJK85JLMvPzwMpcYMIamlZQxQrVXApAUJRaUlqUp6AOUqUA161uzVXLxZWck1hcrOCWnw9V64BmFFgQJBZQlF9gBXcPWGt%2BXnF%2BTqpeTn66BsQKkIymNQDlWb%2BOuQAAAA%3D%3D&config=H4sIAAAAAAAAA02NSw7CMAxE7%2BJ1F8COrNn2EFbiVKnyk%2B1KRBV3J2lBsLM8b97ssIoFs0NFFuJxScuKTzCgrZJYDlVhAke2MGphAaO80WsCZcziC6fRirSgbY8vdUJ%2FtZkUHSr%2B2sgLaZ8huV2ud%2BivVNwWadjGdI9sSankVY4w5OAbGI9RujjI%2FKEP3xujmtUiyAAAAA%3D%3D
Expected behavior
same as tsc output:
__decorate([
    someDecorator(),
    __metadata("design:type", String)
], Foo.prototype, "someProp", void 0);

Actual behavior
_decorate([
    someDecorator(),
    __metadata("design:type", typeof someType === "undefined" ? Object : someType)
], Foo.prototype, "someProp", void 0);

Version
1.2.222
Additional context
The said example works properly when the type is inlined into the property, maybe there is a way to evaluate the type metadata in the same manner?

I'm using Nestjs 10 with swc/core 1.3.68 and the problem keeping. Unfortunately I can't use it in my project =/.

Closing as the stc is now abandoned. https://github.com/swc-project/swc/issues/571#issuecomment-1915966297


Use incremental compiler option by default

What are you changing?

Enable the incremental compiler option in tsc

Why?

Faster rebuilds

Hopefull this work without issues… 🤞


Add metrics naming convention for prometheus

Describe the proposal
Prometheus naming
Step 1: add base-units

Time: suffix with seconds, such as dubbo.rt.qps.seconds
Length: meters
Bytes: bytes
...

我修改了标题加上了 prometheus

可以区分下场景，比如dubbo.registry. , dubbo.thread.

可以区分下场景，比如dubbo.registry. , dubbo.thread.

dubbo.thread 这个使用在哪个场景？我补充到文档上

可以区分下场景，比如dubbo.registry. , dubbo.thread.

I change title "for prometheus".
我修改了标题加上了 prometheus

可以区分下场景，比如dubbo.registry. , dubbo.thread.

dubbo.thread 这个使用在哪个场景？我补充到文档上

不同场景下的一种区分，比如 provider, dubbo.provider,类似


Update home page design

See wireframes: https://projects.invisionapp.com/share/EQXC9CLKCR2#/screens/444274365
See Design Doc: https://docs.google.com/document/d/1fcr2DYo7OrX-qTdeUOTWKSS1rlq_47sehESmbvgUsrk/edit#heading=h.5ixukddz43wy

@hannahfrost Please put the embed code for the newsletter signup on this ticket. Thanks!

The code for the Mailchimp sign-up form is below. I've included the line of text "Sign up for our newsletter" in the form. This format should match the layout in the wireframes, but there are other form formatting options to try if need be.

Sign up for our newsletter


Styles with wrapper class

Hi,
I see there are more styles and few text fields which are hardcoded and not given option to overwrite.
Is there a possibility to wrap the styles in a class so that we can overwrite them in our code and it won't require change in rapidoc source code.
And also kindly let me know when the change related to operation method type block will be available. I can see it's currently available in beta version

I see there are more styles and few text fields which are hardcoded and not given option to overwrite.

That's on purpose. As as web-component we encapsulate styles not allow overrides. It helps in protection from style leaking from other components and allows you to have multiple RapiDoc webcomponent on the same page with its own styles.
If you want to target a specific section or component use css-parts
and if you still dont find a part that you can style, let me know and we can decide if we can expose it  for user-styling


fix: remove node: prefix

Fixes #248

Codecov Report
Patch coverage: 100.00% and no project coverage change

Comparison is base (3d4e1a4) 99.51% compared to head (277830e) 99.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   99.51%   99.51%
=======================================
  Files          58       58
  Lines        3470     3470
  Branches      839      839
=======================================
  Hits         3453     3453
  Misses          7        7
  Partials       10       10

Impacted Files
Coverage Δ

src/lib/errors/BaseError.ts
100.00% <100.00%> (ø)

src/lib/errors/CombinedError.ts
100.00% <100.00%> (ø)

src/lib/errors/CombinedPropertyError.ts
100.00% <100.00%> (ø)

src/lib/errors/ExpectedConstraintError.ts
100.00% <100.00%> (ø)

src/lib/errors/ExpectedValidationError.ts
100.00% <100.00%> (ø)

src/lib/errors/MissingPropertyError.ts
100.00% <100.00%> (ø)

...lib/errors/MultiplePossibilitiesConstraintError.ts
100.00% <100.00%> (ø)

src/lib/errors/UnknownEnumValueError.ts
100.00% <100.00%> (ø)

src/lib/errors/UnknownPropertyError.ts
100.00% <100.00%> (ø)

src/lib/errors/ValidationError.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Option to delay height change until after leave animation completes

For a fade-out-then-fade-in transition within a scrollable container it's preferable to keep the height as is until after the fade-out (leave) transition completes. Can this be an option in the props?
Give me a little direction and I can submit a PR.

Since this issue is ancient by now I would imagine this isn't directly relevant anymore, but an easy solution that just occurred to me is simply to delay the height animation in the CSS. See the added fade-wait-delay animation as an example.
By specifying a delay on the height transition, such as the .4s below, to match the duration of the leave transition I believe you can achieve what you were after.
.fade-wait-height {
  transition: height .6s ease-in-out .4s;
}


QuickReply

Hi!
How send QuickReply?
Thanks!

$a = new Message('This is text');
$a->addQuickReply(new QuickReply('One', 'Payload1'));
$a->addQuickReply(new QuickReply('Two', 'Payload2'));
$this->messenger->sendMessage($this->id, $a);


Implement workflows to automatically apply changes in terraform/environments/

User Story
As a Modernisation Platform engineer
I want to automate any changes or additions to files in terraform/environments/<application>
So that bespoke additions to customer environments are automatically applied
User Type(s)
Modernisation Platform Engineer
Modernisation Platform Customer
Value
At present, changes to add bespoke additions such as IAM users for SES or supplemental VPCs for SaaS products require manual intervention by a Modernisation Platform engineer. Creating an appropriate workflow action or trigger will remove this manual element.
Assumptions / Hypothesis / Questions / Unknowns
Definition of done

[ ] check existing workflows
[ ] create new workflow if required
[ ] another team member has reviewed
[ ] tests are green
[ ] UR test OR added to continual research plan

Reference
How to write good user stories

In an ideal world it would be good if this was in one workflow which does the following:
On PR:
Gets the lists of application folders
Checks if there are any changes to the folders
If there are run the plan for all environments
Trigger a deploy for development and test (skip if no changes)
On Merge:
Gets the lists of application folders
Checks if there are any changes to the folders
If there are then trigger deploy to all environments (skip if no changes)
Bonus points for being able to run it via workflow dispatch and pass in an application folder name
The aim of this is trying to avoid having another 30 workflow files in this repo.
NOTE: We do not currently use github environments in the MP repo so this will also need to be set up.

Moved to blocked awaiting a review of https://github.com/ministryofjustice/modernisation-platform/pull/4590


Firefox support

This extension doesn't appear to support Firefox, which is a significant problem for the project I'm currently using it for.
Any specific reason why?

Note that the official demo doesn't work in Firefox on OSX. I can provide a specific version and other information if needed.

So apparently using innerText as the README.md file suggests isn't supported by Firefox. However, innerHTML is, which fixes the entire problem with a 4-character change. So that's cool, I guess.

See also: this commit

And here's my source that innerText doesn't work in Firefox.

Yeah, indeed, using innerText is not Firefox compatible... Thanks for report! :+1:


Client side error

Calinou report us this error :
ERROR[main]: Client::handleCommand_ActiveObjectMessages: caught SerializationError: deSerializeString: couldn't read all chars

It's a client side error, maybe we can investigate ?

I closed, reported to the minetest core, it's client side, we can't do nothing...
https://github.com/minetest/minetest/issues/2941


UTC and local time are fighting against each other in the multi layout

this.chart = lines().legend(['pass', 'fail']).fill([PASS_FILL, FAIL_FILL]).labelTime('multi').curve('curveStep').stacked(true);
Chart showing 12AM instead of the day.
Data sample:
https://bricks.redsift.cloud/reusable/d3-rs-lines?scale=2&width=500&height=300&curve=curveStep&fillArea=true&labelTime=multi&fill=%2356d58e&fill=%23E06363&legend=pass&legend=fail&stacked=true&_datum=[{"l"%3A1490054400000%2C"v"%3A[242%2C1]}%2C{"l"%3A1490140800000%2C"v"%3A[180%2C0]}%2C{"l"%3A1490227200000%2C"v"%3A[213%2C0]}%2C{"l"%3A1490313600000%2C"v"%3A[135%2C0]}%2C{"l"%3A1490400000000%2C"v"%3A[60%2C0]}%2C{"l"%3A1490486400000%2C"v"%3A[44%2C0]}%2C{"l"%3A1490572800000%2C"v"%3A[251%2C0]}%2C{"l"%3A1490659200000%2C"v"%3A[183%2C0]}%2C{"l"%3A1490745600000%2C"v"%3A[208%2C0]}%2C{"l"%3A1490832000000%2C"v"%3A[0%2C0]}]

Should be fixed with multi-local in v 0.3.4

Confirmed fixed.

Actually, X axis is fine but tooltips are now misaligned.

Pushed a temp fix to align tooltips with 0.3.5, will refactor ahead of a v1.0 push

Tooltips misaligned again since BST started.


SparseTensor indices stored as tf.int32 instead of tf.int64

tf.SparseTensor  currently only accepts indices as tf.int64. Which mean memory of indices > values (tf.float32) in general. Would it make sense to have an option to store indices as tf.int32? This would be useful for storing large sparse matrices where the index values are < 2^32 as it would free up some RAM

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


SAK-50725 Tests & Quizzes: Calculated Question fails if the @ character exists in the text

https://sakaiproject.atlassian.net/browse/SAK-50725
Test & Quizzes fail when a calculated question contains an @ symbol in the question body used for something other than a global variable.

test added ✅ @ottenhoff


Change Line to Path

Thanks for the fix ;)

just so you see I did check it hahaha, thanks to you I will try to give you some feedback later on, but so far seems like a more concise way to draw, and I'm liking it actually


BibliographicReference "type" field should refer to the DLx type

Use the "referenceType" field for the type of reference instead

closed by f8897340d166a22b94be64ea34335b2b2290d0a3


nixos-generate-config: Add nixpkgs.hostPlatform to hardware-configuration.nix

Description of changes
Resolves #177664
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

@ofborg test installer

Shouldn't localSystem get deprecated too?

Kind of. It's bunched in with the other "legacy" options in the assertion the enforces the mutual exclusion of the old and new options.

Add a lib.warn to the deprecated items?

Not yet. The new options need to exist for some time to make it feasible for the ecosystem to start a migration. For now it's only a preview for flakes users and "typical" NixOS users. Deployment tools like NixOps and the numerous other ones can only switch when the new options are supported in all releases. Adding warnings will only upset people.

Add something to the release notes?

Ah yes, of course. Done.

The manual does not need changes yet, because the old way is fully supported. Changes can be made if and when it is decided later that this becomes the blessed way.

Sounds good, thanks for this!

@ofborg test installer

Tests are broken now: https://hydra.nixos.org/build/181556482/nixlog/1

What? I ran those tests on ofborg! I guess I'll fix them.

This should help with the channel blocker, although ofborg is broken and I can't run the tests locally.
https://github.com/NixOS/nixpkgs/pull/178958

Fix confirmed: https://hydra.nixos.org/build/181594825


key photo at dataset level

User story: (3.2) I want to see a key photo at the dataset level, so that I can get a glimpse of what I might expect to see in the dataset
Tasks

[ ] surface key photo
note: key photos are submitted at run level and will have to pick one to show at dataset level. Other times, the key photo is coming from EMPIAR (in which case we would only have 1 and will not have to select which to show)

Link to design:

Relates to https://github.com/chanzuckerberg/cryoet-data-portal/issues/56

key photo in All data page is not displaying dataset page https://github.com/chanzuckerberg/cryoet-data-portal/issues/137


Please update disclaimer

The wording on the disclaimer is out of date. Please change to the following:
"This software has been approved for release by the U.S. Geological Survey (USGS). Although the software has been subjected to rigorous review, the USGS reserves the right to update the software as needed pursuant to further analysis and review. No warranty, expressed or implied, is made by the USGS or the U.S. Government as to the functionality of the software and related material nor shall the fact of release constitute any such warranty. Furthermore, the software is released on condition that neither the USGS nor the U.S. Government shall be held liable for any damages resulting from its authorized or unauthorized use."
From: https://www2.usgs.gov/fsp/fsp_disclaimers.asp#5
On code.usgs.gov, this is being required for public repositories in a "DISCLAIMER.md" file.

Note: this is updated in the Dev branch 2.0 version. When that is released soon this will be closed.

closed by PR #165


Sonoff L1

Will I be able to control the color of the Sonoff L1 LED strip through the Home app using HAP-Node JS?

If there is an ESPxxxx inside, you probably can flash your own firmware onto it (check Tasmota or ESPEasy, maybe it is on supported devices list). If so, you won’t have bigger problems connecting it with HAP

Sent from Yahoo Mail for iPhone
On Wednesday, July 31, 2019, 11:12 AM, Shon Pogorelis<EMAIL_ADDRESS>wrote:
Will I be able to control the color of the Sonoff L1 LED strip through the Home app using HAP-Node JS?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

It is supported on Tasmota but will I be able to control the color of the LED’s through the Home app?

Yes sure. There is a light accessory and hue, saturation, brightness characteristics.

So all I need to do is put the SonoffMQTT_accessory.js file and it will automatically detect that the Sonoff L1 can change colors and show it in the Home app? Or I need a different file made for the Sonoff L1?

I would need to take a look at that file first.

nvm, I forgot that it’s a Sonoff basic specific file.
So there is no file for the Sonoff L1.
Can someone make me one?


Click events not working on Firefox

As reported by @xeroc:

I can't cancel my sell orders .. when clicking the X nothing happens
no javascript messages ..
no transaction produced ..
well here .. we go .. No i sold some MKR .. :disappointed:
works with chrome it seems
but not reliably .. sometimes I don't see a popup at all
Firefox ..
fairly recent

Cannot reproduce this error, but if it persists it could be because of the combination of these lines in orderrow.js
event.stopPropagation();```


mysql: MySQL is started in --skip-name-resolve mode; you must restart it without this switch for this grant to work

s/localhost/<IP_ADDRESS>


Upgrade markdown to 1.0.0.

...but we don't do it on the dartdoc site, though.
Sigh
On Thu, Nov 2, 2017 at 1:54 PM, István Soós<EMAIL_ADDRESS>wrote:

@isoos commented on this pull request.
In app/lib/shared/markdown.dart
https://github.com/dart-lang/pub-dartlang-dart/pull/512#discussion_r148656850
:

@@ -8,8 +8,10 @@ import 'package:path/path.dart' as p;

final Logger _logger = new Logger('pub.markdown');
-final List<m.BlockSyntax> _blockSyntaxes =
We do remove the InlineHtmlSyntax from the github extension set. Not sure
the reason, maybe to prevent HTML injection?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/pub-dartlang-dart/pull/512#discussion_r148656850,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCitE_i_SDMn6iBJM7HgIU5e0-xkw5ks5syiwYgaJpZM4QQUyA
.

...but we don't do it on the dartdoc site, though.

I'm all for consistency, but I'd prefer to be on the (HTML-)safe side on this one.

Yup. Let's go w/ this for now...
On Thu, Nov 2, 2017 at 2:01 PM, István Soós<EMAIL_ADDRESS>wrote:

...but we don't do it on the dartdoc site, though.
I'm all for consistency, but I'd prefer to be on the (HTML-)safe side on
this one.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/pub-dartlang-dart/pull/512#issuecomment-341556792,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCiv8NIsp2IlB6ksbMt4Ayp7YLvjPgks5syi2agaJpZM4QQUyA
.


mmxcp compression copy script validation

Describe the bug
Validate script from Dan as mentioned in below email:
I've created a test version of xcputil.sh for you and your team to checkout.  It is hardcoded to copy the compression attribute from the source files to the target files.
I'm interested to see if it functions well for you, and especially if you notice any performance degradation.
Dan
To: Deepak
From: April Date: 02/25/2022 01:52PM
Subject: mmxcp compression copy
Hi Deepak,
I opened User Story 291948 https://jazz07.rchland.ibm.com:21443/jazz/web/projects/GPFS#action=com.ibm.team.workitem.viewWorkItem&id=291948
to track the CSI request for mmxcp to compress the files after the copy.
Can you please confirm that you want us to switch directions and implement this user story for 5.1.4 ? That will be the only story we can deliver
(hopefully after design has been done) for the 2Q release.  If the design turns out to be really complex then it will go into 5.1.5 and nothing else
will be delivered for 5.1.4.
We should also work with you on the use case requirements so that we get a complete and accurate design.

New external to indicate that compressed files in --source will be re-compressed in --target.  Default is no.
Each file needs to be determined whether it is compressed or not, and only those that are will be re-compressed in --target.  Other option is to just
compress all of the files in --target after copy.  The all file option is probably easier to implement and less performance hit.  we could have a switch on the
external to indicate which kind and implement it in stages.  ??
Performance will be an issue and customers are willing to trade off time for mmxcp command to run for the function.
Would customer accept certain files not being compressed in the first implementation - I know there was some discussion on sparse files.

Please let us know what else - Thanks for your input.
April L. Brown
Spectrum Scale Test
DPE Scrum
<EMAIL_ADDRESS>(845) 433 - 8173, (T/L) 293 - 8173
============================================
How to Reproduce?
Please list the steps to help development teams reproduce the behavior
Expected behavior
Data Collection and Debugging
Environmental output
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Note : See labels for the labels

Currently no plan to work on this part. Will reopen if required


refresh_facts.rb does not expand aliases

After adding a new module to the control repo, we experienced failures from the code of https://github.com/choria-io/mcorpc-ruby-support :
yaml_facts.rb:35:in `rescue in block in load_facts_from_source' Failed to load yaml facts from /etc/puppetlabs/mcollective/generated-facts.yaml: Psych::BadAlias: Unknown alias: 1

The module provide two facts that contain a reference to the same object.  The generation of generated-facts.yaml detects this and produce an alias instead of outputing the same content twice.
But then, mcorpc-ruby-support cannot read this file because SafeYaml does not support alias expansion for safety reasons.
The script that build generated-facts.yaml should probably make sure no aliasing happen.

Nasty. Now that the ruby mco is gone we can probably make this script emit JSON which would make me much happier

From my findings digging this issue:

A quick & dirty workaround is to convert the yaml to json and then back to yaml (ugly);
There is not safe_dump method in Psych (the YAML module, bundled with Ruby if I recall correctly), so as of today, you cannot generate a YAML file that can be read with Psych.safe_load. I started hacking a safe_dump method, this involves quite a huge amount of code, so it's really not trivial.

So if the same could be done with JSON, maybe it would be the fastest cleanest way to proceed…

I see there is a :canonical option to dump, maybe that helps?
Go choria supports reading json or yaml - and anyway since this is run from cron not that frequently we can do the to json to yaml thing

I tried it but it does not solve the issue, we still have aliases…
non canonical:
---
a: &1
- 1
- 2
- 3
b: *1
canonical:
---
{
  ? "a"
  : &1 [
    ! "1",
    ! "2",
    ! "3",
  ],
  ? "b"
  : *1,
}

I just checked the choria code and feel like saving JSON to a filename that ends with "json" (at least not "yaml") and adjusting the hiera data to adjust the filename should be good.  I'll try to take some time for this.  Thanks!

Yeah json will work if you want to do that great, else we can do the hack I don’t mind

Busy day… switching to JSON is not as easy as I though, and we do have an ARM node with legacy mco server and legacy Puppet 5 in production that would be unhappy with such changes in the short term, so I am going the easy way with the hack solution.
For a long term solution, saving JSON indeed makes sense!

sweet, thank you


Fix compose import

Hey @arnaudgiuliani , the import generated when KOIN_USE_COMPOSE_VIEWMODEL is active is org.koin.compose.viewmodel.dsl.viewModel which is unresolved and throws an error Unresolved reference 'viewmodel'.
.Also from the warning when the above argument is inactive says the import should be from org.koin.core.module.dsl.*
@Deprecated("Moved ViewModel DSL package. Remove old imports and use org.koin.core.module.dsl.*

Potential fix for #171

Thanks @kibettheophilus

this is the case in Koin 4.0. To merge in KA 2.0 branch


This new add_or_get_nets is more robust against that but still correct.

Does not work


Implement frame layout

min-width: 90rem

max-width: 90rem

X just lives it's separate life

X just lives it's separate life

@meandrewandyou is there a design that makes you think it should behave otherwise?

X just lives it's separate life

@meandrewandyou is there a design that makes you think it should behave otherwise?

No, as far as there's no designs for different screen sizes. It's been said from user's POV

most users don't resize their screens and care too much about some element moving around - no design, not much we can do about it, and we've got limited time :smile:


list seems backward

I'm probably just misunderstanding, but when I enter:
pcf.port = [False, False, False, False, True, True, True, True] I would expect the four least significant bits to be low, and the highest four significant bits to be high.  I'm getting the opposite.  I've tried to reverse the list, but that doesn't seem to work either.  What am I misunderstanding?
Thanks very much,
Leonard Gabrielson

The list isn't backwards, while yes, it may appear to be backwards, there's another possibility, the board you have may have it labelled incorrectly. I checked, and on a low-cost module I have bought from eBay with a PCF8574T, its the Pins that are labelled backwards.

As depicted in the code, Python lists are least-significant index first, so the following makes sense:
x = [True, False]
x[0] == True
x[1] == False

The list needs to be "backwards" compared to how we read binary, since you need to be able to do:
pin = 3
pin3_value = pcf.port[pin]

The difference being that within Python we're talking about indexes and not bits.

As depicted in the code, Python lists are least-significant index first, so the following makes sense:
x = [True, False]
x[0] == True
x[1] == False

The list needs to be "backwards" compared to how we read binary, since you need to be able to do:
pin = 3
pin3_value = pcf.port[pin]

The difference being that within Python we're talking about indexes and not bits.


Ignore some html tags

Is it possible to have prism ignore an array of tags while it's doing the syntax?
I need this because I have a file-differences generator, which spawns the html à lá <tag> but relies on other html-tags for css, such as <strike>;
This is totally possible in my case, <tag<strike> class="hello"</strike>> (it means I removed class="hello" from <tag>), but I cannot seem to find a way for that to work with Prism - as it just straight up ignores my <strike> tag.
Am I just being way too crazy, or is this actually possible?

I think a plugin could probably be made for this.
The way I see it, it could use the same principle used by the PHP component, that is: replace all the desired tags by placeholders during highlighting and reinject them once it's done. But I'm pretty sure this would break somewhere (just like the PHP component does).


updating index and toc

Learn Build status updates of commit dc16c68:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

advocates/index.html.yml
:white_check_mark:Succeeded
View

advocates/toc.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Can't install/import on Windows

PS D:\vc\patterns-knowledge-graph\patterns-knowledge-graph-datasets\RDF> pip install pysparql-anything
Collecting pysparql-anything
  Downloading pysparql_anything-<IP_ADDRESS>-py3-none-any.whl (11 kB)
[etc etc]
Successfully installed Deprecated-1.2.14 pygithub-2.1.1 pyjnius-1.6.0 pyjwt-2.8.0 pynacl-1.5.0 pysparql-anything-<IP_ADDRESS> typing-extensions-4.7.1
WARNING: There was an error checking the latest version of pip.
PS D:\vc\patterns-knowledge-graph\patterns-knowledge-graph-datasets\RDF> ipython
In [1]: import pysparql_anything as cli
No SPARQL Anything jar has been found in the installation folder.
Downloading the latest SPARQL Anything jar, please wait...
Downloading SPARQL Anything v0.8.2: 100%|██████████████████████████████████████████████████████████████████████| 198M/198M [00:29<00:00, 7.11MiB/s]
The Download was successful!
The system is now ready for use!
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
~\AppData\Local\Continuum\anaconda3\lib\site-packages\pysparql_anything\engine.py in <module>
     10     jnius_config.set_classpath(get_path2jar())
---> 11     from jnius import autoclass, JavaException
     12 except ValueError:

~\AppData\Local\Continuum\anaconda3\lib\site-packages\jnius\__init__.py in <module>
     43 else:
---> 44     from .jnius import *  # noqa
     45     from .reflect import *  # noqa

ImportError: DLL load failed: The specified module could not be found.

During handling of the above exception, another exception occurred:

NameError                                 Traceback (most recent call last)
<ipython-input-1-1ac4a47f8b5f> in <module>
----> 1 import pysparql_anything as cli

~\AppData\Local\Continuum\anaconda3\lib\site-packages\pysparql_anything\__init__.py in <module>
     27     raise
     28 # Launches the JVM
---> 29 from pysparql_anything.sparql_anything import SparqlAnything

~\AppData\Local\Continuum\anaconda3\lib\site-packages\pysparql_anything\sparql_anything.py in <module>
      5
      6 import pysparql_anything.command as cmd
----> 7 from pysparql_anything.engine import Engine
      8
      9

~\AppData\Local\Continuum\anaconda3\lib\site-packages\pysparql_anything\engine.py in <module>
     15           + 'create a new VM for the  CLI.')
     16     raise
---> 17 except JavaException:  # Handles JVM exception for an incorrect path
     18     print('JVM exception occured: \n'
     19           + 'Check the jar has been dowloaded succesfully:\n'

NameError: name 'JavaException' is not defined

Fixed by upgrading from py 3.7 to 3.11.


Add file Command-Line Utility.

As a user of the uutils/coreutils package, I have noticed that it does not include a file command-line utility, which is a basic part of many other Unix-like operating systems, and could be useful to windows users too. The file utility is used to determine the type of a file based on its contents, and is an essential tool for working with various types of files.
Therefore, I propose that a file command-line utility be added to the uutils/coreutils package, along with appropriate documentation and testing. This would improve the usability and completeness of uutils/coreutils package itself , and make it more consistent with other Unix-like systems.
I have created a small implementation of the "file" utility myself, which I would be happy to contribute to the project. However, I believe that this is a basic utility that should be included as part of the uutils/coreutils package, and not left up to third-party contributions.
My implementation of file can be tracked here.

Yes you're right. I apologize for the mistake in my previous response. You are correct that the file command is not part of the GNU Core Utilities.
But it is still a standard tool that is typically installed on almost all Unix-based systems So won't this be a useful thing to add?

sure, happy to take in the uutils org next to https://github.com/uutils/findutils


Apparmor 1.30

AppArmor is going to GA in v1.30, including some API changes.
Note to reviewers:
This PR is based on https://github.com/kubernetes/website/pull/45471, which should be merged first. Only the second commit should be reviewed in this PR.
https://github.com/kubernetes/enhancements/issues/24
/sig node
/milestone v1.30

Hello @tallclair 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday March 12th 2024 18:00 PST. Thank you!

/milestone 1.30

Once this is rebased down to 1 commit, I recommend getting technical reviews (SIG Node, SIG Security).

Feedback addressed. Is @saschagrunert's LGTM sufficient for technical review, or do I need someone else?

Updated pod security standards, and security checklist.
@sftim - AppArmor config is a fairly niche knob, and most users shouldn't touch it. I'm not sure it makes sense in the top-level pods doc, and we don't (yet?) have a dedicated security context doc that I could find.  The security checklist reference seems like the most relevant bit.

LGTM from a content perspective.

I scrubbed the docs for other AppArmor references, and updated a few other content pages. PTAL.

AppArmor config is a fairly niche knob, and most users shouldn't touch it. I'm not sure it makes sense in the top-level pods doc, and we don't (yet?) have a dedicated security context doc that I could find. The security checklist reference seems like the most relevant bit.

We don't really tell people reading the Pods concept that they have the option to do more around securing their workloads. We should. It can be a direct link to the pages (AppArmor, seccomp, etc) or an indirect via a link to a new page that describes what integrations Kubernetes offers.
Anyway, no mention at all is too little.
A bigger revision to https://kubernetes.io/docs/concepts/workloads/pods/ would be great, but: it's too much to ask. The smaller ask is to add one sentence to https://kubernetes.io/docs/concepts/workloads/pods/ that mentions AppArmor. Maybe within https://kubernetes.io/docs/concepts/workloads/pods/#what-s-next?

Revising the Pod concept to link to https://k8s.io/docs/concepts/security/cloud-native-security/ is another way to ensure we link to AppArmor (feel free to pick this option).
We try to do some checks when things graduate to beta (or, if we missed it at beta, to stable). One of those checks is to make sure that if you only read the concepts section, you're likely to learn about the existence thing we're graduating. Cross-references like the one I'm advocating give readers the confidence that they won't need to brute-force their way through reading all the docs to know that they've covered the relevant details.

@sftim I agree, but is it OK if I open a separate PR for it, and we don't block this PR on adding the pods context?

I agree, but is it OK if I open a separate PR for it, and we don't block this PR on adding the pods context?

Sure. That works; happy to take your word on this.

/lgtm

Hello @tallclair :wave:! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday March 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.
The status of this enhancement is marked as at risk for docs freeze.
I do notice though that we have a lgtm, so this is really close!
@kubernetes/sig-docs-en-owners @saschagrunert @pjbgf Does this look ready for approval?
Thank you!

/approve

/milestone 1.30


"updated on" and "by" columns switched in ambulance/hospital equipment view

When viewing equipment of an (already created) ambulance or hospital, the column contents of "updated on" and "by" are switched:

I found the source of the error, and changed the code accordingly. However, I cannot verify that my change worked, because I can't add equipment or equipment sets to my ambulance or hospitals on localhost, due to the bug where a newly created ambulance/hospital does not have an equipment set, even when you select it #13.


[FLINK-33938][runtime-web] Correct implicit coercions in relational operators to adopt typescript 5.0

What is the purpose of the change
This pull request makes runtime-web frontend code compatible with TypeScript 5.0, which has a break change that implicit coercions in relational operators are forbidden.
Brief change log
In runtime-web

Correct implicit coercions in relational operators
otherwise, there is an incorrect way to determine NaN, and I correct it

Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
(Please pick either of the following options)

[x] This change is a trivial rework / code cleanup without any test coverage.

(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

These two modifications prevent the code from relying on implicit type conversions. LGTM.


Update Triton dependency logic

Reinstate PyTorch dependency on hashed version of triton (essentially reverts https://github.com/ROCm/builder/commit/e72594460667b62dfef87b582d46c324d9719da9): Tested successfully via http://rocm-ci.amd.com/job/rocm-pytorch-manylinux-wheel-builder/154
Do not add triton dependency for PyTorch versions older than 1.13: Tested successfully via http://rocm-ci.amd.com/job/rocm-pytorch-manylinux-wheel-builder/155

Test results of PyTorch2.0 and triton wheels generated from http://rocm-ci.amd.com/job/rocm-pytorch-manylinux-wheel-builder/154, installed in rocm/pytorch-private:manylinux-hipclang-13484:
[root@ed0329edef16 apex]# pip3 install -f https://compute-artifactory.amd.com/artifactory/compute-pytorch-rocm/compute-rocm-dkms-no-npi-hipclang/13484/ torch==2.0.1 torchvision==0.15.2
Looking in links: https://compute-artifactory.amd.com/artifactory/compute-pytorch-rocm/compute-rocm-dkms-no-npi-hipclang/13484/
Collecting torch==2.0.1
  Downloading https://compute-artifactory.amd.com/artifactory/compute-pytorch-rocm/compute-rocm-dkms-no-npi-hipclang/13484/torch-2.0.1%2Brocm6.1-cp39-cp39-linux_x86_64.whl (2095.9 MB)
...
Collecting pytorch-triton-rocm==2.0.2+f84c1f1e62 (from torch==2.0.1)
  Downloading https://compute-artifactory.amd.com/artifactory/compute-pytorch-rocm/compute-rocm-dkms-no-npi-hipclang/13484/pytorch_triton_rocm-2.0.2%2Bf84c1f1e62-cp39-cp39-linux_x86_64.whl (206.3 MB)
...

[root@ed0329edef16 pytorch-micro-benchmarking]# python3 micro_benchmarking_pytorch.py --network resnet50 --compile
INFO: running forward and backward for warmup.
/opt/python/cp39-cp39/lib/python3.9/site-packages/torch/_inductor/compile_fx.py:90: UserWarning: TensorFloat32 tensor cores for float32 matrix multiplication available but not enabled. Consider setting `torch.set_float32_matmul_precision('high')` for better performance.
  warnings.warn(
INFO: running the benchmark..
OK: finished running benchmark..
--------------------SUMMARY--------------------------
Microbenchmark for network : resnet50
Num devices: 1
Dtype: FP32
Mini batch size [img] : 64
Time per mini-batch : 0.11212306022644043
Throughput [img/sec] :<PHONE_NUMBER>338267


Lost my followers and contacts

My all contacts and followers gone. And its not for first time that the second one. Why that's always happening? Can you sort that error pls its very uncomfortable 😖

Ouch.
Use metadata.nostr.com

This happens to me when I use Iris.to.

You need to make sure you are connected to the same relays whne switching clients. Possibly Nostros coulnd't find any of your contacts on start and the moment you did any change the version was updated, anywayd there is always the possibility to recober an oldet version by connectiong back on Iris

This happened again without using Nostros or Iris.to. So some client or relay is doing this as well.

Still investigating this, it could be Nostur, a new macos nostr client. I am not sure how the list was restored, but my following list was cached in Nostrmo.


Merge upstream dropbox djinni

Hey, I created this PR with the upstream changes in the dropbox repo.

Hum, somehow this lost the commit history into one big commit 🙁
EDIT: The commit history is now fixed

Any news on this? 🙂


json MQTT payload problem

Hello, I have encountered a problem with using json as a string MQTT payload. The broker doesnt recognise the payload and in "-v debug" it shows as undefined, yet it triggers events that arent supposted to happen.
At first I thought it has to do with characters like { and " that json contains, but further inspection in config file it was all secured with \ so i really dont know what is happening here...

I hope this will be enough to identify the bug or my mistake, thanks you for your time!!

Should work in v0.7.7 if you start with --disable-json-parse.

just tested it, works flawlessly, many thanks!


[Feature Request] edit link bio

thanks for provide this code, I hope the future update you can add feature for delete link bio, add link bio and edit link bio

Hi. Features related to bio links have been added to Mobile class including add_bio_link(), remove_bio_link() and clear_bio_links(). Please take a look at the Readme for all the code. I'll add the update_bio_link() method soon.


Launch via browser_runner.sh

Launch via browser_runner.sh which allows specifying the url and config folder path

you can pass custom commands to the current image on run, so this is unnecessary but thanks!


Feature Request: Add commit message to cards (maybe via an optional argument)

I think it would be worthwhile to have an option to include the commit message in the card as well.

This is a good suggestion. You're saying you would want a new attribute to be able to put whatever you wanted in the body of the message?

That would be good also, the main thing I find missing from the cards is the commit message. Especially when there are a lot of cards flying around it's difficult to ascertain what is what just from the commit hash. Further extending it to allow other variables or even custom text in the body would be good also.

Do we have any updates on this feature request?

Do we have any updates on this feature request?

I forked the repository to see if I could figure it out but came up wildly short!
Few things that I would love to add would be the branch and commit message (or at least a portion of it).

I forked the repository to see if I could figure it out but came up wildly short!
Few things that I would love to add would be the branch and commit message (or at least a portion of it).


💡 [REQUEST] - Upgrade google-api-python-client

Summary
This package has a strong pin for google-api-python-client to be under its 2.0 release. But that means we can't benefit from updates for that package and that causes issues when importing slo-generator alongside other libraries that require a more recent google-api-python-client.
Could google-api-python-client be updated?
Basic Example
n/a
Screenshots
No response
Drawbacks
n/a
Unresolved questions
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @Lawouach, I agree this strong pin could prevent future updates. At the same time, it introduces stability and reproducibility into the SDLC.
@ocervell Do you recall a specific reason for this strong pin? Otherwise I will try removing it and confirm whether unit tests  complete successfully.

Fair point indeed.
I'm importing slo-generator as a library in one application which also use the GCP libraries. Right now, with slo-generator strict pinning, I cannot benefit from the client > 2.0 and since the 1.x branch isn't maintained any longer, I am worried about security patches I'm missing.
But I fully appreciate where you are coming from here.

@Lawouach I removed the strong pins entirely and unit tests complete successfully. Let me do a few more integration tests, especially with the Cloud Monitoring backend and exporter.

I really appreciate the effort on this!

I just confirmed there does not seem to be any conflict with the new package versions. I am able to query an App Engine Availability SLI with the Cloud Monitoring backend, then export the metrics to Cloud Monitoring and Pub/Sub with the two libraries that got updated too. So I'd say we are all set. I will move forward and merge the PR.

Great! This is much welcome. Will you be able to make a new release soon as well by chance?

I just released 2.5.0, mainly due to the support of OpenSearch. Two birds with one stone.

Fantastic. Thanks again!


new question about now() function for SQL quiz

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

thaaanks @jdwilkin4, really happy about it!


Getting total number of steps/test cases before suite is run

Summary

I am a long-time user of the fuubar-cucumber formatter. It breaks under Cucumber 2.4.0+.
Specifically, https://github.com/martinciu/fuubar-cucumber/blob/master/lib/cucumber/formatter/fuubar.rb#L28 calls features.step_count. But https://github.com/cucumber/cucumber-ruby/blob/master/lib/cucumber/formatter/legacy_api/adapter.rb#L77 passes features as nil, so this call fails.
I have tried and failed to figure out if new Cucumber knows in advance how many test steps it will be executing. Is there an equivalent in new Cucumber for features.step_count ?
(I know fuubar-cucumber is also using the legacy formatter API. I'm willing to re-work it with the modern API, but I need to solve this problem first to decide if it's even worth it.)
Expected Behavior

A way to determine the total number of test steps or test cases before the suite runs.
Current Behavior
features.step_count returns NoMethodError: undefined method 'step_count' for nil:NilClass
I can't find anything in Cucumber::Formatter::LegacyApi::RuntimeFacade to help answer this question.

Steps to Reproduce

# Gemfile
gem 'fuubar-cucumber'

cucumber features/ --format=fuubar

Context & Motivation

I love the insta-fail, progress-bar approach to cucumber output. I can't find any way to achieve this without fuubar-cucumber.

Hi Tyler, thanks for volunteering to help sort this out.
You're right that the design in Cucumber 2+ streams test cases straight out of the compiler and never assembled them into a list to count them first.
Although there was some design elegance to this, it's impractical. We were already buffering up the test cases for certain run configurations, like randomized runs.
I just merged #1082 which now means that we'll collect together the test cases and emit a test_run_starting event (in the new protocol) which contains that list of all test cases.
At this point you have a range of options about how to resurrect fuubar-cucumber's compatibility with our API: a quick-and-dirty solution might be to patch https://github.com/cucumber/cucumber-ruby/blob/master/lib/cucumber/formatter/legacy_api/adapter.rb to use that new event to fix the step_count attribute you're looking for. Alternatively, you could try mixing new and old protocols, listening to the new event in your existing code and using that to get the info you need. Finally (and this is obviously the best long-term) you'd go over to using the new API entirely.
There's an example [here] of mixing the two.


Bug in year suffixing

There seems to be a bug in the year suffixing when there are (at least?) two authors shared between two works and both are not the last authors.
Here is the source code for a minimum working example to reproduce the bug:
test.zip
Here are the contents of the .bib:
@article{cite1,
  title        = {Title1},
  author       = {A, NameA and B, NameB and D, NameD and E, NameE},
  year         = {2022},
  journal      = {JournalName},
}
@article{cite2,
  title        = {Title2},
  author       = {A, NameA and C, NameC and D, NameD and F, NameF},
  year         = {2022},
  journal      = {JournalName},
}

The years are displayed as "2000a" and "2000b" in the bibliography even though the set of authors differs between the two works. For the bug to occur, the authors B and C can be omitted, but E and F are necessary.

When there are more persons citing label becomes <first person surname> et al., <year>  and then you get:
A et~al., 2022
A et~al., 2022

So extra letters is added to recognize which of the cite refers to which bibliography entry. Without letters in the printed paper you will not know which reference was cited with A et~al., 2022.

I see. Are you sure that's the correct style? I would have expected that for an in-text citation, if the set of authors is different between two works, enough authors' names to make them distinct would be listed, i.e.,

A, B, et al. (2022)
A, C, et al. (2022)

rather than

A et al. (2022a)
A et al. (2022b)

Bibtex style is provided by publisher and many of the bibtex styles act the same forming in-text citation labels.
If you wish to change it you can add bibliography directly to tex file and edit these labels like:
....
\begin{document}
\cite{cite1}
\cite{cite2}

\begin{thebibliography}{2}
\newcommand{\enquote}[1]{``#1''}
\expandafter\ifx\csname natexlab\endcsname\relax\def\natexlab#1{#1}\fi

\bibitem[\protect\citeauthoryear{A, B, D, and E}{A, B, et~al.}{2022{\natexlab{a}}}]{cite1}
\textsc{A, NameA, NameB B, NameD D, and NameE E} (2022{\natexlab{a}}):
  \enquote{Title1,} \emph{JournalName}.

\bibitem[\protect\citeauthoryear{A, C, D, and F}{A, C,  et~al.}{2022{\natexlab{b}}}]{cite2}
\textsc{A, NameA, NameC C, NameD D, and NameF F} (2022{\natexlab{b}}):
  \enquote{Title2,} \emph{JournalName}.

\end{thebibliography}
\end{document}


[Feat]: Auto Commenting feature for PR Raised

Is your feature request related to a problem? Please describe.
Yes, the feature request is related to a problem. When contributors raise pull requests (PRs) in a project, it is crucial to provide immediate acknowledgment and feedback to encourage collaboration and maintain transparency. However, manually commenting on every PR can be time-consuming for maintainers, leading to delays and inconsistency in communication. This can result in contributors feeling undervalued or discouraged from further participation.
Describe the solution you'd like
This solution introduces a new GitHub Actions workflow that automatically comments on new and updated pull requests. This feature aims to streamline the contribution process by providing contributors with immediate feedback and guidance upon creating or updating their pull requests.
What problem is this feature trying to solve?
This feature aims to address the problem of delayed and inconsistent communication following the raising of PRs. By automatically commenting on PRs as soon as they are raised, it ensures that contributors receive immediate feedback and acknowledgment for their efforts. This fosters a positive and supportive environment for collaboration, encouraging continued participation and engagement from contributors.

Go ahead @Asymtode712

@ashutosh-rath02 All the PRs have been raised, just to ensure smooth working of all workflows just follow these below steps:
Step 1: Create a Personal Access Token (PAT) with repo Permission
1. Navigate to Settings:

Click on your profile picture in the upper-right corner of the page.
Select "Settings" from the dropdown menu.

2. Go to Developer Settings:

In the left sidebar, scroll down and click on "Developer settings."

3. Create a New Token:

Click on "Personal access tokens -> Token (classic)" in the left sidebar.
Click on the "Generate new token" button.

4. Configure the Token:

Token Description: Enter a descriptive name for the token (e.g., Repo Access Token).
Expiration: Set no expiration.
Select Scopes: Check the box next to repo to grant full control of private repositories.

5. Generate Token:

Scroll down and click on the "Generate token" button.
Important: Copy the token to a secure location. You will not be able to see it again once you navigate away from the page.

Step 2: Assign the Token to GITHUB_TOKEN Environment Variable
1.
Click on the "Settings" tab.

2. Go to Secrets:

In the left sidebar, click on "Secrets and variables" and then "Actions".

3. Create a New Secret:

Click on the "New repository secret" button.
Name: Enter GITHUB_TOKEN.
Value: Paste your generated token.
Click on the "Add secret" button.

Secret names must not start with GITHUB_

change it to this everywhere MY_SECRET_TOKEN

Hello @Asymtode712! Your issue #163 has been closed. Thank you for your contribution!


Remove all walkers

What is the problem you're trying to solve
We do have a number of walkers abstractions around (for network, images, etc.).
They may have seemed like a cute abstraction at the time, but they are more trouble than anything, because they just hide the fact that resources come and go - and by the time they call the handler, the corresponding resource may have disappeared - unless the caller does enforce locking around the walker, which defeats the purpose of a simple functional abstraction.
At this point, it feels like walkers are just over-engineering with no purpose: a pattern that does not deliver any concrete value, while making issues harder to debug.
Describe the solution you'd like
Remove all walkers.
They are useless.
While looking at concurrency issues again (#3501) it is clear they are part of the problem.
Additional context
No response

/label refactor


gcp should not be under raster

Vector datasets can have GCPs too!

I did not realize that! Fascinating. I should have picked up on that, but it's hard to tell with Dataset being so overloaded.


Release v1.12.0 prep

Description

Updates changelog for release
Update version numbers to 1.12.0

Validation

Smoke test locally

Related Issues

#711

Check List

[x] I confirm that my contribution is made under the terms of the Apache 2.0
license.
[ ] I have run pnpm checks to ensure code compiles and meets standards.
[ ] I have run pnpm test to check if all tests are passing.
[ ] I have covered new added functionality with unit tests if necessary.
[x] I have added an entry in the Changelog.md.

LGTM


Case sensitive AddQueriesToRequest parameters (500 error)

Premise
I configured an app to add query parameter PID from claims (using AddQueriesToRequest, and it works just fine)
Expected Behavior / New Feature
I expected Ocelot to ignore query parameters that already configured in AddQueriesToRequest section without any errors no matter what case is used
Actual Behavior / Motivation for New Feature
I tried to send a request to Ocelot with EXPLICIT PID query parameter and it works, but then I changed the case of EXPLICIT PID query parameter to pid (in lower case) I got 500 error.
I think it is not obvious behavior, I didn't even think at first it was because of Ocelot and not because of my app
Steps to Reproduce the Problem

Configure ocelot to add a query parameter to downstream service using AddQueriesToRequest
Send a request to Ocelot explicitly specifying the same parameter but in a different case (for example, if it configured as Upper case, use Lower case)
Receive 500 error from Ocelot

Specifications

Version: 13.4.1

Please, confirm this bug in the latest version 22.0.1 and reopen.
Attach more: config JSON, startup code, exception & error logs!


[MINOR][DOCS] Add note about Spark network security

What changes were proposed in this pull request?
In response to a recent question, this reiterates that network access to a Spark cluster should be disabled by default, and that access to its hosts and services from outside a private network should be added back explicitly.
Also, some minor touch-ups while I was at it.
How was this patch tested?
N/A

Test build #93892 has finished for PR 21947 at commit b5b14d0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93892/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/1582/
Test PASSed.

Test build #93902 has started for PR 21947 at commit a59672b.

Test build #93902 has finished for PR 21947 at commit a59672b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93902/
Test PASSed.

Test build #93929 has finished for PR 21947 at commit e6f5a3f.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93929/
Test FAILed.

Merged build finished. Test FAILed.


Feature: Offset

Hey there @andrelmlins ,
I've been working on a project lately and needed the offset functionality. So I just implemented it.

So, how I understand it, branch 'next' is there to target Vue 3.0, and the 'master' branch it there to target Vue 2.0. Right?

Very good, thanks for the contribution.
Yes, the next branch is for Vue 3.0.

Is there a reason which prevents us from merging this into the Vue 2.0 and Vue 3.0 branch. Because - to my knowledge - the implemented functionality does not depend on Vue Versions

The Vue 3.0 using<EMAIL_ADDRESS>The compile with<EMAIL_ADDRESS>was not working properly in Vue 2.0. I will go new tests to validate.

I thought you wanted to check the<EMAIL_ADDRESS>first. Because we could merge this pr into the branches 'next' and 'master' .

@andrelmlins Bump

Unfortunately we will need to keep the 2 versions, I will merge and generate a version for vue 2.0 and vue 3.0

Publish new version
Vue 2: 0.3.0 - latest
Vue 3: 1.1.0 - next
Thanks for the contribution


Sanitize content pasted from MS Word

We recently ran into an issue where content writers are pasting content from MS Word (in fact they always write their content in Word as they are worried of losing it, given the lack of autosave on the admin UI, it is how they have always done it, they are comfortable with Word etc. etc.), and MS Word specific tags are getting introduced:
eg:

Original request:

Goeie dag<o:p></o:p>

<u1:p></u1:p>

<u1:p> </u1:p><o:p></o:p>

Currently the Wagtail whitelister fails on these tags, a better solution might be to just strip them out using a library such as https://pypi.python.org/pypi/htmllaundry/?

Have you customised the whitelister rules at all (using the construct_whitelister_element_rules hook)? I can't see how this markup could possibly pass the default whitelister rules - if I try to replicate this by pasting this code into the rich text field's hidden text area, and saving the page, the invalid attributes/elements are stripped as expected:

Original request:

Goeie dag

No we haven't tried doing that, I don't actually know what happened
directly, but they somehow managed to pass it in without it getting
stripped out
On Wed, Sep 9, 2015 at 10:40 AM, Matt Westcott<EMAIL_ADDRESS>wrote:

Have you customised the whitelister rules at all (using the
construct_whitelister_element_rules hook)? I can't see how this markup
could possibly pass the default whitelister rules - if I try to replicate
this by pasting this code into the rich text field's hidden text area, and
saving the page, the invalid attributes/elements are stripped as expected:
Original request:Goeie dag

—
Reply to this email directly or view it on GitHub
https://github.com/torchbox/wagtail/issues/1669#issuecomment-138829506.

OK - will close this as unable to replicate, but please reopen if you're able to provide a set of steps that reproduces this.

So today I finally worked out it was the html comments causing all the issue as
they weren't getting stripped out.
I see https://github.com/torchbox/wagtail/pull/1821 fixes it


Introduce VLLM_VERBOSITY environment variable

Introduce VLLM_VERBOSITY environment variable and use info log level by default to reduce IO operations in production.
For dependencies use warning level.

Hi @zhuohan123!
Would you provide your thoughts on this? It is fine if this is not the implementation plan for logging.

+1 for this change, being able to change the log level via environment variable would be very useful.

Closing as it is superseded by #4273 and #4377.


5pm-2 Show page for personal schedules

This PR closes issue #174 .
A new page is created at the front-end side at addresses according to their id.
For example, this means that a schedule with an id of 2 will have a page at https://proj-ucsb-courses-search.herokuapp.com/schedule/2 .
On the page https://proj-ucsb-courses-search.herokuapp.com/schedule, the name of each schedule is a link to the show page.
The image below demonstrates these changes

Can you go back and make sure the package-lock.json is not committed?
This can be done by soft resetting to the last commit where the package-lock wasn't committed or making a new branch and putting your changes in again.


auth:login retrieves the token via the API instead of copy+paste

[ ] add a request endpoint that results in a unique id for the CLI
[ ] pass that as the url to prompt and/or open instead of the previous
[ ] test the token upon retrieval and continue

cli hits an endpoint that returns a unique id related to the request
cli hits another endpoint awaiting the result of the request
cli presents/prompts a url to authorize this request with a unique id
authorized endpoint approving the request results in a token being handed back to the cli


how to know the pipeline is empty?

const pipeline = redis.pipeline();
if (pipeline is empty) {

} else {
//pipeline is not empty
}

Now in the version 1.23.4, you can check if your pipeline is empty by:
const p = redis.pipeline();
if(p.length() > 0) { // NOT EMPTY}


Folders not showing up in file tree

I have just run a clean install of Windows 8.1 Pro N and installed Brackets Sprint 30 (no extensions yet) and opened my localhost www folder as the Project folder. In the www root I've installed Wordpress with the default themes and copied in some themes I'm working on from my Bitcasa drive. The strange part is that all files except the files copied from Bitcasa drive shows up. I can open them from the OS folder just fine and I've compared the folder permissions and owners and everything is set with the same permissions.
After deleting the "kristofferhellman" folder (in below screenshot) and creating it from the Brackets UI and then copy the files inside it they become visible. But the "paf" folder do not show up at all.

Steps I've taken to get this:

Installed Windows 8.1 Pro N
Installed Brackets Sprint 30
Opened a Project folder
Copied folder from Bitcasa into the Project folder
Copied folder from Bitcasa don't show in file tree in Brackets.

I have the same issue. The entire contents of the bower_components folder in my project is hidden, even after multiple restarts of Brackets and Windows.

I am experiencing the same issue with bower_components folder not being displayed in the tree view.

I found this in the brackets.json file for my user profile
"jwolfe.file-tree-exclude.list": [
"node_modules",
"bower_components",
".git",
"dist",
"vendor"
],
I removed the bower_components item from the list and refreshed the file tree and voila, it's back!

Thank you, tman26m. I remember now that I have the File Tree Exclude plugin installed, which also hides node_modules. Good to know where to make adjustments.

@isherwood  Thanks! Been looking fotr this! :)


java.util.NoSuchElementException: No value present when interacting with Pixelmon

When rightclicking a pokemon, it gives an exception.
World with claimmode 2
Pixelmon 4.2.5
Latest griefprevention built from source
http://pastebin.com/Ai88DJ7W

@i9hdkill Should entity interaction only be allowed in claims as well?

Also, your stack trace doesn't line up with latest source. In the stack trace, it complains about an optional on line 1228 but line 1228 in master is the following
https://github.com/MinecraftPortCentral/GriefPrevention/blob/master/src/me/ryanhamshire/griefprevention/event/PlayerEventHandler.java#L1228
Please rebuild your source (wipe out build folder) and test again.

Yeah, blocks are enough. Pixelmon/entities should be accessible.
Thanks will try that

@bloodmc Sry about that. Now it's definetely a fresh build:
http://pastebin.com/jqgdQutC

Just found this:
http://pixelmonmod.com/tracker.php?p=2&t=8498
Error when a pixelmon spawns. I think it's not a bug in griefprevention.


Make cpplint.py compatible with python 3

Commit af24c7162be from 2018 allegedly also did that but it dies
silently for me and others with python 3.7.
This commit fixes the incompatibilities and adds an excepthook so
you get an indication of what the issue is.
Fixes: https://github.com/nodejs/nan/issues/884

This results in <class 'TypeError'> write() argument must be str, not bytes <traceback object at 0x10179ecc8>. Running with Python 2, shows that it dies just before outputting this error message: Skipping input 'node_modules/node-gyp/gyp/data/win/large-pdb-shim.cc': Can't open for reading. Now, this is a str, not bytes, but apparently there could have been bytes written to stdout somewhere earlier. 2to3 did not seem to include any fix for this. This will be a minor pain to correctly fix, since toy languages do not have strong typing.

Are you saying it's failing for you locally with python 2? With what OS is that? Windows?

Python 3 on a not-proper-unix Mac. Anyway, latest cpplint from upstream seems to work for both 2 and 3, along with some new additions, let's just update. https://raw.githubusercontent.com/cpplint/cpplint/master/cpplint.py

That works for me too. Updated, PTAL.

Works for me with both Python2 and Python 3.


bug: keys ignore cond

Did you check docs and existing issues?

[X] I have read all the lazy.nvim docs
[X] I have searched the existing issues of lazy.nvim
[X] I have searched the exsiting issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.9.0-dev+820-ga0a112515
Operating system/version
Fedora 36
Describe the bug
The keybinds in keys are registered and trigger even if cond is false.
Steps To Reproduce
{
    'ggandor/leap.nvim',
    config= function() require'leap'.set_default_keymaps() end,
    keys = {
      {'s', function() require'leap'.leap{ target_windows= { vim.fn.win_getid() } } end}
    },
    cond=false
  },

Then:
:map s -> n  s           * <Lua 29: ~/.local/share/nvim/lazy/lazy.nvim/lua/lazy/core/handler/keys.lua:102>
And finally, s activates leap.nvim.
Expected Behavior
No maps are created, the plugin should not exist.
Repro
-- DO NOT change the paths and don't remove the colorscheme
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({ "git", "clone", "--filter=blob:none", "https://github.com/folke/lazy.nvim.git", lazypath, })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  -- add any other plugins here
  {
    'ggandor/leap.nvim',
    config= function() require'leap'.set_default_keymaps() end,
    keys = {
      {'s', function() require'leap'.leap{ target_windows= { vim.fn.win_getid() } } end}
    },
    cond=false
  },
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

That's not how keys and cond work.
cond is only evaluated when the plugin would be loaded. In this case that's when the keys handler kicks in.
The key handler will not load the plugin, but since the keys has a  rhs part it will still create that.

Could you please revisit this?
In the docs, it says "Useful to disable some plugins in vscode, or firenvim for example.".
However, disabling plugins in VSCode is my exact usecase, and cond does not quite do it for me.
If I define a bunch of plugins with keys, but then set cond to false, those mappings still exist, even though the plugin is not loaded. This obviously is not ideal.
I know this might be a little tricky to solve given the design of cond, but

could you eval cond before registering the keys
could you block the key mapping on press, when cond is false?

Thanks!

I tried using enabled, which worked better for fully disabling the plugin, but that design isn't ideal because the plugins would be removed if you ran LazyClean while inside VSCode.
Additionally, enabled isn't provided in lazy defaults (ref https://github.com/folke/lazy.nvim/issues/640), so I can't make all my plugins "opt in" by default using enabled.

Have a look at the vscode spec in lazyvim.
That should cover all your needs.

I was sceptical it would, but it does! Well done, many thanks. Your plugins + lazy + lazyvim are really coalescing and streamlining the ecosystem and legitimately solving my perpetual something-is-broken config!
I plan to recommend LazyVim directly from VSCode-Neovim, it truly offers first-class support and is the best implementation of conditionally loading plugins I've seen.
I will ask however, what usecase does the current design of cond solve? I can imagine very few instances where you want the lazy handlers to be enabled yet for the plugin to refuse loading.

Additionally, would you consider adding enabled to the defaults table? This would provide another way of making plugins opt-in instead of just the vscode spec. I could imagine this is useful for users who want all lazyvim plugins to be disabled out of the box, and also work for other situations like firenvim/shadowvim.

Yeah, I should probably revisit the implementation of cond. Will look into it tomorrow!
Then most of those hacks I did in LazyVim would no longer be needed :)

Awesome! Also related: https://github.com/folke/lazy.nvim/pull/581

Just pushed a new release. cond now behaves as enabled, but won't delete the plugin when doing clean


Lecture 11 checklist

[ ] each student has created at least two to five unit tests with matching PRs and code review
[ ] project has at least one of the following types of tests: Integration tests, Nonfunctional tests (e.g.: performance, capacity), [Optional] Property tests
[ ] code coverage of tests is increased by at least 20%.  List the "starting" and "ending" commits in the "Lecture 11 checklist" issue with the achieved percentage increase.

Starting commit: 09269c2
Ending commit: Work in progress

The BattleManager test can be considered an integration test since it verifies the interactions between the BattleManager and the IBattleEntity (Player/Enemy) components. It test how the BattleManager interacts with mock implementations of the Player and Enemy (mockPlayer, mockEnemy). By using these mocks, the test simulate interactions between the BattleManager, Player and Enemy. It also tests the battle loop, ensuring it correctly handles interactions between the BattleManager, Player and Enemy classes during a battle.

@Kiopp, @majo22wx, @Vencilo, @mowaab, and @CarlNord01
Please, mention the unit tests with matching PRs and code review in the comment (each one in a separate comment).
Due Data: Thursday May 30.

#111 Battle manager test. Integration test.

#116 Entity unit test.

#175 unit test

#176 unit tests UIManager

#177 #180 Item unit test

#178 #179 Weapon unit test


Availability from the Homebrew

Would be a great addition if both aarch64 and x86_64 versions would be available for Homebrew via courier hosted formula or core formula (which is JVM only right now).

@arixmkii Indeed. If anyone wants to update the formula for that, just feel free to send a PR for it.


RoutingMiddleware should sort paths

Connexion middleware sorts all available APIs from most specific to least because of starlettte's routing behavior
https://github.com/spec-first/connexion/blob/5d7eb0bdab9ed404e1d294dac6ed951af3be7952/connexion/middleware/main.py#L334
Similar sorting algorithms should be done within an api's routes in the RoutingMiddleware

This is a good suggestion. We already have the functionality available, just need to call it at the right place.


Bump slurm to v1.148

See https://github.com/stackhpc/ansible-slurm-appliance/releases/tag/v1.148

Superseded by #563


Integration with Amazon CloudWatch logs and metrics

Overview
The AWS X-Ray team had several requests from customers to gain deeper insights into their X-Ray traces and link those traces to relevant logs for quicker root cause analysis. We are announcing a suite of features that allow users of this SDK to more efficiently parse logging and trace data and view metrics on aggregations of segments. These features are designed to improve customers’ experience when using X-Ray and drive down their mean time to resolution.
The below features will be released in version 2.4.0 of the Java SDK. Supporting documentation and onboarding instructions will be released at that time as well. As always, we welcome any feedback on these new features!
Features
Segment-Level Metrics
This feature automatically generates metrics about X-Ray segments that you can view on your CloudWatch dashboard like any other metric. Metrics to be recorded for each segment are latency in milliseconds as well as throttle, fault, error, and OK rates. This feature requires the CloudWatch Agent to be enabled in your environment.
Trace ID Injection into Logs
The X-Ray recorder injects the current trace ID into each logging statement that happens while that trace is open. This makes logs easy to query if a trace that represents a problem with your application is known. Simply search for the problematic trace’s ID in a CloudWatch log group and all logging events relevant to that trace will be returned. This feature will be compatible with SLF4J and Log4J 2 logging frontends.
Log Group Correlation in Traces
AWS X-Ray uses the CloudWatch agent to automatically include the log group(s) that your application writes to in traces. The log groups will be specific to the environment they originated from and viewable in the “Raw Data” tab of trace view on the AWS X-Ray console. This feature requires the correct service plugin to be attached to your X-Ray recorder and for the CloudWatch Agent to be enabled in your environment

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@willarmiros I've added @chanchiem for review since we've been working together to author this.

Wondering, why is the MDC key also prepended to the value in the logger? Seems strange to me:
MDC.put(TRACE_ID_KEY, TRACE_ID_KEY + ": " + segment.getTraceId().toString());

Hi @mouse256,
This decision was made to easily query all logging messages that contain a trace ID. Since it is possible that logging events occurred while no segment was active, we wanted to provide a way to easily separate those log events from the ones that do include a trace ID.