[Regression] Title in FlexibleSpaceBar wrong alignment

Steps to reproduce
In a SliverAppBar, use FlexibleSpaceBar and his title properties, and center title.
Expected results
If centerTitle = true, then the title is centered

Was working years ago : https://stackoverflow.com/questions/51882320/flutter-how-to-vertically-center-the-appbar-sliver-tilte
Actual results

Unable to align left (by default) or center title, it’s shifted to the right
Code sample
Code sample
import 'package:flutter/material.dart';

void main() => runApp(new MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return new MaterialApp(
      title: 'Slive AppBar',
      theme: new ThemeData(
        primarySwatch: Colors.blue,
      ),
      debugShowCheckedModeBanner: false,
      home: new MyHomePage(title: 'Slive AppBar'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({super.key,required this.title}) ;

  final String title;

  @override
  _MyHomePageState createState() => new _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return new Scaffold(
        drawer: new Drawer(),
        body: new CustomScrollView(
          scrollDirection: Axis.vertical,
          slivers: <Widget>[
            new SliverAppBar(
              expandedHeight: 150.0,
              flexibleSpace: const FlexibleSpaceBar(
                title: const Text("US\$ 123.456.78"),
                centerTitle: true,
              ),
              backgroundColor: Colors.redAccent,
              pinned: true,
              actions: <Widget>[
                new IconButton(
                  icon: const Icon(Icons.add_circle),
                  tooltip: 'Balance',
                  onPressed: () {/* ... */},
                ),
              ],
            ),
          ],
        ));
  }
}

Screenshots or Video
No response
Logs
No response
Flutter Doctor output
Reproductible on dartPad
Doctor output
[√] Flutter (Channel stable, 3.19.2, on Microsoft Windows [version 10.0.22635.3209], locale fr-FR)
    • Flutter version 3.19.2 on channel stable at C:\src\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (11 days ago), 2024-02-27 16:51:22 -0500
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at C:\Users\quent\AppData\Local\Android\sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)
    • All Android licenses accepted.

[X] Chrome - develop for the web (Cannot find Chrome executable at .\Google\Chrome\Application\chrome.exe)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[X] Visual Studio - develop Windows apps
    X Visual Studio not installed; this is necessary to develop Windows apps.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2023.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-b2043.56-10550314)

[√] VS Code (version 1.87.1)
    • VS Code at C:\Users\quent\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.82.0

[√] Connected device (3 available)
    • SM G977N (mobile) • emulator-5554 • android-x64    • Android 9 (API 28)
    • Windows (desktop) • windows       • windows-x64    • Microsoft Windows [version 10.0.22635.3209]
    • Edge (web)        • edge          • web-javascript • Microsoft Edge 122.0.2365.66

[√] Network resources
    • All expected network resources are available.

It appears that this has been fixed on the master channel. See the screenshots below.
Per our triage policy, I'll be closing this issue since it has been fixed on the master channel. If you run into this issue on the master channel, kindly leave a comment below and I will reopen this issue.
Thank you

master
stable

flutter doctor -v
[✓] Flutter (Channel stable, 3.19.3, on macOS 14.3.1 23D60 darwin-arm64, locale en-GB)
    • Flutter version 3.19.3 on channel stable at /Users/nexus/dev/sdks/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ba39319843 (4 days ago), 2024-03-07 15:22:21 -0600
    • Engine revision 2e4ba9c6fb
    • Dart version 3.3.1
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Users/nexus/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode-15.2.0.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Users/nexus/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.5)
    • IntelliJ at /Users/nexus/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 77.2.2
    • Dart plugin version 232.10286

[✓] VS Code (version 1.87.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (5 available)
    • Pixel 7 (mobile)     • adb-28291FDH2001SA-5Lv71w._adb-tls-connect._tcp. • android-arm64  • Android 14 (API 34)
    • Nexus (mobile)       • 00008020-001875E83A38002E                        • ios            • iOS 17.3.1 21D61
    • Dean’s iPad (mobile) • 00008103-000825C811E3401E                        • ios            • iOS 17.3.1 21D61
    • macOS (desktop)      • macos                                            • darwin-arm64   • macOS 14.3.1 23D60 darwin-arm64
    • Chrome (web)         • chrome                                           • web-javascript • Google Chrome 122.0.6261.112

[✓] Network resources
    • All expected network resources are available.

• No issues found!

[!] Flutter (Channel master, 3.21.0-2.0.pre.72, on macOS 14.3.1 23D60 darwin-arm64, locale en-GB)
    • Flutter version 3.21.0-2.0.pre.72 on channel master at /Users/nexus/dev/sdks/flutters
    ! Warning: `flutter` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/nexus/dev/sdks/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/nexus/dev/sdks/flutters. Consider adding /Users/nexus/dev/sdks/flutters/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 087b15ae0d (7 hours ago), 2024-03-10 22:33:27 -0400
    • Engine revision d13999c0ca
    • Dart version 3.4.0 (build 3.4.0-220.0.dev)
    • DevTools version 2.33.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/nexus/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Users/nexus/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
    • Xcode at /Applications/Xcode-15.2.0.app/Contents/Developer
    • Build 15C500b
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2023.1)
    • Android Studio at /Users/nexus/Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.7+0-17.0.7b1000.6-10550314)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.5)
    • IntelliJ at /Users/nexus/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 77.2.2
    • Dart plugin version 232.10286

[✓] VS Code (version 1.87.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (6 available)
    • Pixel 7 (mobile)                • adb-28291FDH2001SA-5Lv71w._adb-tls-connect._tcp. • android-arm64  • Android 14 (API 34)
    • Nexus (mobile)                  • 00008020-001875E83A38002E                        • ios            • iOS 17.3.1 21D61
    • Dean’s iPad (mobile)            • 00008103-000825C811E3401E                        • ios            • iOS 17.3.1 21D61
    • macOS (desktop)                 • macos                                            • darwin-arm64   • macOS 14.3.1 23D60 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                            • darwin         • macOS 14.3.1 23D60 darwin-arm64
    • Chrome (web)                    • chrome                                           • web-javascript • Google Chrome 122.0.6261.112

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.


Android 13+ per-app language support

I would prefer to take advantage of the ability provided in the latest versions of the OS to change the languages of installed applications from a single interface.
Read more about it in the article "Change app language on your Android phone" of the official OS help.
Screenshot

The app currently supports English language only. Which language would you prefer to have instead?

Ukrainian, of course. 👋

Though my profile photo might suggest otherwise, I am not Ukrainian and do not speak Ukrainian. Would you kindly provide the translations?

I've never done technical translations on Github. Please tell me which file I need to take to translate the interface labels? Also, I know Russian and can translate the application into it.
Is Google's new approach compatible with the method you're using to switch app locales?

Thank you for your help!
Before we proceed, I will update the English text resources and set up a translation platform. Once this is done, I will let you know. The first additional language, Ukrainian, will not be added directly via GitHub, as GitHub is not very translator-friendly. After the app with the Ukrainian language is published and everything runs smoothly, we can discuss adding Russian as a direct contribution via GitHub.

@Korb I have set up the project on Weblate. You can log in with your GitHub account, if you prefer it that way. Weblate is new to me too, so I am still learning.
You can start translating app string resources here and metadata (app description, etc.) here.
Translations of previous changelog files are not necessary. If you have any issues, let me know and we'll try to figure them out.
Thanks in advance!

You can start translating app string resources here and metadata (app description, etc.) here.

Done.

Big thanks once again for your contribution! Your translations have been added and this request is implemented in release 2.0.3.
Unfortunately, since your GitHub and Weblate accounts are not connected, you are still not shown in the Contributors sidebar. However, I have added you to the app's README.

@Korb Perhaps you could connect the accounts and translate the latest changelog? Once the change is merged, you should appear as contributor.

translate the latest changelog?

Done.


inference when using llava-llama-2 [Usage]

Describe the issue
Issue:
Thanks for your great work!
I train my model based on your released lava-llama-2-13b with lora and deepspeed, but have troubles when performing inference.

The result checkpoint with lora and deepspeed does not have "config.json", so I guess the arg "—base_model" is needed, and I set it to "checkpoints/llava-llama-2-13b-chat-lightning-preview".
I notice that the keyword in the name of checkpoint is very important. For my own checkpoint, there is no “llava” or “lora” in the name. And the loading process turns to below in "builder.py":

# Load language model
if model_base is not None:
    # PEFT model
    from peft import PeftModel
    tokenizer = AutoTokenizer.from_pretrained(model_base, use_fast=False)
    ...

After 1) and 2), the image processor cannot be activated because there is no "llava" keyword in my checkpoint name, which is very weird.
Also, I try to modify the name to contain "llava" or "lora", but it returns to 1) and the error is like: no "config.json".

In a word, my question is: how to run the "run_llava.py"? Which args should I specify? Is it a bug for llama-2 inference? If so, hope you can release your solution.
Thanks for your great work again and I am looking forward to your reply!
Command:
python -u eval/run_llava.py \
--model-path result_pretrain_2/checkpoint-56534 \
--model-base checkpoints/llava-llama-2-13b-chat-lightning-preview \

Any news about this issue? @haotian-liu


--strip-comments not working

--strip-comments not working is not working for me for removing comments that don't fall into the excluded categories e.g. @license, etc.
Example usage: polymer-bundler src/components/my-app.js --strip-comments --out-dir ./t1/

More than an year later, js comments are still not being removed, as they were in previous polymer-cli versions.

This is definitely a regression. I tested it.
Last working version (comments being stripped<EMAIL_ADDRESS>First broken version<EMAIL_ADDRESS>

@marto55555 If you would've checked the changelog.md, you would've seen that the feature got removed in 1.9.8 becuse of some Polymer 3 issues. It's a known fact and removed on purpose (though not sure if temporarily or definitively). Try perhaps some alternatives.

Anyone found an alternative solution in the build process?

@derhuebiii I've reverted to version 1.9.7 and use that for building, since my projects are on Polymer 2. Not sure if that will do the job for you, though.


Update lindah.toml

Description
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
https://github.com/anoma/namada-testnets/pull/1430
https://github.com/anoma/namada-testnets/pull/1782
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[x] Only one toml is added in this PR
[x] The file being added is indeed a .toml file
[x] The toml being added is to the correct folder, and only to the correct folder
[x] The eth_hot_key and eth_cold_key are present
[x] The email, discord, elements telegram, and twitter fields are present and valid

Successfully validated transactions.toml file for commit hash 9a682de


React.isValidElement not smart enough to escape null and undefined values

Using Flow 0.54.0, it appears that React.isValidElement isn't smart enough to ensure that null and undefined values aren't escaped. Consider this code (https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoAlgWwA5wE4AuyYAhgM5gBKApiQMZFR5yZgDketDbA3KqgQCe2amAAKzbGQAqw0QF4wAb1RgAkHQAW6GABNOAOwD8ALipcCAOgBycXaNQBffnRjkKAWUEBhFrgPUBkTUAB4EgboUNPRWvjhwAUEAPBJwUrIiAHzKqmCG9nhgABQAlGbRDDZ2oipg6nQJZERKWjr6gY5gigTaZJbYkmR8qGqcBACueAbmMZbe2nqGllD4AKL0mkWti4EANMXUMNSYgQTlFlX2JV3ZKmpq6FDFFVboZABqJDDouqtHJ0EiodjqcStcxpNpgZxjAYHw6gj1I8Dv9Tv1BpYyCxqD10AYAOZdeTdPDjajgnGQsBJXToABuYGAmT4akREKm1LI2BI0yZ8IRjhKuWcjiAA):
// @flow

import * as React from 'react';

type PropsType = {
 	children?: React.Node
}

class MyComponent extends React.Component<PropsType> {
  render (): React.Node {
  	const {children} = this.props;

	return React.Children.forEach(children, (element: React.Node) => {
		if (React.isValidElement(element)) return null;

		// Flow throws an error on this line even though it's completely safe
		if (element.props.something === true) return <div />;

		return <span />;
    })
  }
}

Flow throws:
14:       	if (element.props.something === true) return <div />;
                       ^ property `props`. Property cannot be accessed on possibly null value
14:       	if (element.props.something === true) return <div />;
               ^ null

However, this is not a valid error since isValidElement will do a check for null values and return false in that case, so by the time Javascript reaches line 14 there is no way that element would be null. So the Flow type error is a false positive.

So really nobody ever cared to drop a comment on this? Is there some solution for this problem or we just have to monkeypatch it?

Well, I think it's possible to annotate this function so flow will know that it returns false  for null and undefined.

Will close this in favour of #6392 to consolidate any discussion and which covers the wider issue of React.isValidElement not supporting type refinement at all.


Colorimetric gamut clipping for out-of-gamut colors?

I noticed that when creating a cmsHTRANSFORM mapping from a wide gamut color space (e.g. BT.2020) to a narrow gamut color space (e.g. BT.709), out-of-gamut colors simply end up clipped per-channel:
#include <stdio.h>
#include <stdint.h>
#include <inttypes.h>

#include <lcms2.h>

int main()
{
    cmsCIExyY wp_d65 = { 0.31271, 0.32902, 1.0 };
    cmsCIExyYTRIPLE prim_bt2020 = {
        .Red   = {0.708, 0.292, 1.0},
        .Green = {0.170, 0.797, 1.0},
        .Blue  = {0.131, 0.046, 1.0},
    };

    cmsCIExyYTRIPLE prim_bt709 = {
        .Red   = {0.640, 0.330, 1.0},
        .Green = {0.300, 0.600, 1.0},
        .Blue  = {0.150, 0.060, 1.0},
    };

    cmsToneCurve *curves[3];
    curves[0] = curves[1] = curves[2] = cmsBuildGamma(NULL, 2.2);

    cmsHPROFILE bt2020, bt709;
    bt2020 = cmsCreateRGBProfile(&wp_d65, &prim_bt2020, curves);
    bt709 = cmsCreateRGBProfile(&wp_d65, &prim_bt709, curves);
    cmsFreeToneCurve(curves[0]);

    cmsHTRANSFORM trafo = cmsCreateTransform(bt2020, TYPE_RGB_16,
                                             bt709, TYPE_RGB_16,
                                             INTENT_RELATIVE_COLORIMETRIC,
                                             cmsFLAGS_NOCACHE | cmsFLAGS_NOOPTIMIZE);

    uint16_t src[3] = {31529, 7826, 7046};
    uint16_t dst[3];

    cmsDoTransform(trafo, src, dst, 1);
    printf("original: %"PRIu16" %"PRIu16" %"PRIu16"\n", src[0], src[1], src[2]);
    printf("transformed: %"PRIu16" %"PRIu16" %"PRIu16"\n", dst[0], dst[1], dst[2]);

    cmsDeleteTransform(trafo);
    cmsCloseProfile(bt2020);
    cmsCloseProfile(bt709);
}

$ gcc lcms.c -o lcms -llcms2 && ./lcms
original: 31529 7826 7046
transformed: 39374 0 5149

We can see clearly that this is a naive per-component clip, because performing the BT.2020->BT.709 conversion manually, I get 39374 NaN 5149 (where NaN is the result of applying the gamma 2.2 curve to the negative value -944). Simply clamping the out-of-range component like this significantly alters the subjective appearance of the color, in a way that is surely not done to minimize dE loss.
Computing the dE between the original (Lab 29.2328 62.6251 38.7994) and the transformed (Lab 31.7156 55.2905 40.6235) I get a dE 2000 of 3.842154. Manually desaturating the color (by reducing the LCh chromaticity until the color is within gamut - similar to what cmsDesaturateLab is doing) instead gives me Lab 29.2328 52.5482 32.5563, which differs by a dE 2000 of only 2.928193. We can see that in this case, LCh desaturation gives us an objectively closer result to the original color.
I was under the impression that LittleCMS will perform exactly this sort of colorimetric gamut clamping out of the box, but apparently this is not the case. Is there any way to get LittleCMS to do this for me?

Oh, it's worth pointing out that removing cmsFLAGS_NOOPTIMIZE actually affects the output (I thought it'd just affect performance?), giving me 39371 0 5023 (Lab: 31.7097 55.2785 40.8807) instead. This isn't a huge change though, just a minor deviation.

LittleCMS definitively can do gamut mapping. You got this behaviour because you are using the simplified built-in RGB matrix-shaper. Those profiles are basically intended for input.
If you want to see gamut mapping in action, use sRGB v4 Preference as output , for example and perceptual intent. You will see a huge difference.
Anyway, this is the ICC model. The "smartness" of gamut mapping relies on the profile, not on the CMM.

Ah, I understand. I guess it comes down to how well-made the profile is, at the end of the day, and whether or not it contains a good "perceptual mapping". That's unfortunate, especially when using relative colorimetric intent (which still produces badly-clipped colors even on that sRGB v4 profile), but I guess it's the way things are.

Actually this is a very complex topic. Since the destination gamut cannot reproduce the desired color, all neighboring  have to be moved to preserve smothness and gradients. This is perceptual intent and many times it involves art. Just clipping is a gamut mapping too.
A good book on this: Color Gamut Mapping by Ján Morovič


Optimization is very slow

Hi,
I think there is something wrong with the way BO runs at my machine. The BO process is very slow and gets slower with every iteration. I understand that some slowdown can be expected but not this much - from 3 sec to 5 mins.
Bayesian Optimization
----------------------------------------------------------------
 Step |   Time |      Value |   colsample_bytree |   subsample |
    5 | 00m05s |    0.79714 |             0.6500 |      0.9990 |
    6 | 00m06s |    0.79917 |             0.6500 |      0.6500 |
    7 | 00m03s |    0.79250 |             0.6500 |      0.8206 |
    8 | 05m13s |    0.79464 |             0.9990 |      0.9990 |

I tried some profiling and see that most of the time i spent here:

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    96854  207.735    0.002  214.026    0.002 basic.py:227(solve_triangular)

The CPU i working a lot during this time.
I have all requirements up to date and installed from pip (linux 64 bit)
Is it normal behaviour? If not, any idea how to solve it?

You control the training of the underlying Gaussian Process by passing **gp_params to the maximize method. The default behaviour included 25 rounds of pseudo-likelihood optimization, which happening internally within sklearn's GP.
Is this pattern consistent?  Increasing alpha usually helps, since it makes the process of inverting the covariance matrix more stable.

I'm also seeing this behavior, and increasing alpha doesn't do anything

I'm also seeing this behavior. Alpha doesn't change anything:
from bayes_opt import BayesianOptimization

def toOptimize(a=0):
    return - a * a

optimizer = BayesianOptimization(toOptimize,{'a': [-5,5]})
optimizer.maximize(n_iter=200)
print(optimizer.res)

Initialization
-----------------------------------------
 Step |   Time |      Value |         a |
    1 | 00m00s |  -22.89916 |   -4.7853 |
    2 | 00m00s |   -1.10813 |    1.0527 |
    3 | 00m00s |   -0.01665 |    0.1290 |
    4 | 00m00s |   -4.29761 |    2.0731 |
    5 | 00m00s |   -0.07172 |    0.2678 |
Bayesian Optimization
-----------------------------------------
 Step |   Time |      Value |         a |
    6 | 00m00s |  -25.00000 |    5.0000 |
    7 | 00m00s |   -0.49688 |   -0.7049 |
    8 | 00m01s |   -0.03670 |   -0.1916 |
    9 | 00m02s |   -0.00059 |   -0.0243 |
   10 | 00m03s |   -0.00044 |    0.0210 |

And it keeps getting slower with each iteration

me too! it gets too slow after a while..

Seeing same behaviour. Takes several seconds for each iteration even with a dummy target function.

In fact it is the slowest optimizer of all I have ever used. And the results are worse than the ones of the faster optimiz3rs on the same iteration count. So I personally stopped using it in production.

In fact it is the slowest optimizer of all I have ever used. And the results are worse than the ones of the faster optimiz3rs on the same iteration count. So I personally have never used it in production.

@KOLANICH what other optimiz3rs have you used? any of them do Bayesian optimization?

I resisted intervening here since the optimizer could be made faster by the user. However I decided to bite the bullet and make the changes. See #176

@KOLANICH what other optimizers have you used? any of them do Bayesian optimization?

Here is the list: https://gitlab.com/KOLANICH/UniOpt.py/tree/master/UniOpt/backends

I also see the same slow down behavior at around 400+ iterations with 10 parameters to being optimized. Now the 5 fold training of my model take much less than the calculation of Bayesian optimization.


Determine how to access tekton dashboard endpoints over https

Our doc suggests a couple of curl commands against the tekton dashboard to register the webhook.  This was written when the dashboard did not require credentials or supports https.  With the new version of the dashboard requiring https and authentication, determine how we handle those requirements and update the doc.

@jtmulvey thanks for helping with this.  Assigning to you for now.  Please reassign to whoever with the appropriate security expertise can help.

Please use openshift-tekton-dashboard.yaml attached to the https://github.com/tektoncd/dashboard/releases to get HTTPS access to the dashboard.

We're working to improve the clarity of the dashboard docs in this area.


queue: abort with success if there are no messages

When there are no messages, don't run the signing or fixup stages.

conflict on queue_consumer.yaml


Add theme: Monochrome

Add theme: Monochrome
This PR adds a new theme to the theme library.
Theme Details

Name: Monochrome
Description: There is no monochrome option in theme settings, so i created this theme.
Homepage: https://github.com/antonsizikov/zen-browser-monochrome-theme
Author: @antonsizikov

Thanks!


Handle app uninstall

Implements: https://github.com/open-services-group/peribolos-as-a-service/blob/fab17cbeb13e9ec6d95ffed4b7952089558583cd/architecture.md#user-unsubscribe
Depends on: https://github.com/open-services-group/peribolos-as-a-service/issues/4

Receive "install" webhook with "delete" action
Delete installation specific secret

/sig services

Is it possible to get the secret later and have access for creating a PR to clean up?


add RPC named params and finality flag. close #184

@frol see the page here: https://docs-pr-252.onrender.com/docs/api/rpc-params


Missing transit handler for tech.v3.dataset.Text class

Hi!
Title says it all. The following test passes and it shouldn't.
(deftest encode-text
  (let [dataset (tmd-io/->dataset [{:col "a"}] {:parser-fn :text})]
    (is (thrown-with-msg? Exception #"Not supported: class tech.v3.dataset.Text"
                          (tmd-transit/dataset->transit-str dataset)))))

Yep - good catch


Support for categories

An entry field, that is, a field where you associate entries worked fine by passing the title.
However, doing the same with a category fails and just gives me "X cannot be blank".
In case I am unclear, I have an entry where you can associate categories (Manufacturer). The importer cannot find a match on the manufacturer category even though it exists.
This time the category definitely exists, before I had the issue where it did not exist and threw this error (#39). Now there is now excuse other than categories are not supported yet.
In the readme it says

"Will connect Entries (also Structures), Categories, Users and Assets by searching for them"

This is currently not working for me.
My CSV is correctly formatted (checked on csvlint).

I'm sorry, my documentation fails here. You have to specify categories like Headcategory/Subcategory/Subsubcategory (example) if they're in a structure.

I will have a play when I next get the chance, thanks very much.

"Manufacturer is a required field"
This is the most common error I encounter. There is something wrong here.
Here are my categories

Here is my CSV
"model","price","Manufacturer","condition","specsBerthSleeps","specsMtplm","specsMiro","specInternalLengthFeet","internalLengthInches","year"
"Challenger 520","7995","Swift","Used","4","1550","1345","17","9","2006"

Clearly the manufacturer is defined.

The first entry imported never gives an error, even if there is one. I can only tell if there is an error by importing multiple items.

Is your manufacturer field set up to find "Swift" in the manufacturers pool? Try this for yourself. The first imported entry status might be a bug, I will look into it.

Here is the data pointer to the manufacturer pool.

I also tried referencing the categories group "All Manufacturers/Swift" and it's handle "manufacturers/Swift" but to no avail.

What is the "url" you have set for manufacturers?

The manufacturers categories don't have their own urls.

Ok, I should probably mention that so far there's no support for url-less categories. I will have to work on this :-)

Woop! Thanks bro, now it's working! :dancers:

Nice. I have just fixed the log never showing the first errors. Will look into url-less category importing soon.


Failure on Call input decoding

Before the mappings run we decode the call.input data parameters, and that's failing for a few subgraphs.

https://thegraph.com/hosted-service/subgraph/xenoliss/opensea-sales-indexer?selected=logs
https://thegraph.com/hosted-service/subgraph/suisuss/openseasubgraph?selected=logs
https://thegraph.com/hosted-service/subgraph/token-terminal/gitcoin-v1-ethereum?selected=logs

Example:
Subgraph failed with non-deterministic error: failed to process trigger: block #9212748 (0x2ca0…024f), transaction 4e6b6ba98b5249874882099903a988d23e50d2746cbccab9ae25e020106e69b5: Generating function inputs for the call Function { name: "issueBounty", inputs: [Param { name: "_issuer", kind: Address, internal_type: None }, Param { name: "_deadline", kind: Uint(256), internal_type: None }, Param { name: "_data", kind: String, internal_type: None }, Param { name: "_fulfillmentAmount", kind: Uint(256), internal_type: None }, Param { name: "_arbiter", kind: Address, internal_type: None }, Param { name: "_paysTokens", kind: Bool, internal_type: None }, Param { name: "_tokenContract", kind: Address, internal_type: None }], outputs: [Param { name: "", kind: Uint(256), internal_type: None }], constant: false, state_mutability: NonPayable } failed, raw input: 788acd7e00000000000001010101010101010101010101104080040080800000010000000001000000000000000000000000000000000000000000000000000100000001ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffdc0000000004000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000002000028001: Invalid data, retry_delay_s: 1800, attempt: 81

Source code: https://github.com/graphprotocol/graph-node/blob/657f059021c2c2b95f17d1afee0649f88ba58efa/chain/ethereum/src/data_source.rs#L606
Isolated gist: https://gist.github.com/otaviopace/05a6fc20af6ca267d932cffaf4e0bd98

Thank you very much for filing this for our visibility @otaviopace 🙏 🙏

Is there any action needed from stuck subgraph hosted-service deployers to get them back on track or will it be automatically fixed?


nixos/mbim-network: init

Motivation for this change
I'd like to control my Sierra Wireless MC7455 LTE modem in MBIM mode using mbim-network in a native, NixOS-configured way. This PR is loosely based on the configuration of the OpenVPN module which allows for multiple instances to be running.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Here's a dmesg snippet showing the kernel initializing the device:
[matt@routnerr-2:~]$ dmesg | grep cdc
[   10.425295] usbcore: registered new interface driver cdc_ncm
[   10.467144] usbcore: registered new interface driver cdc_wdm
[   10.525180] cdc_mbim 1-1.3:1.12: cdc-wdm0: USB WDM device
[   10.526210] cdc_mbim 1-1.3:1.12 wwan0: register 'cdc_mbim' at usb-0000:00:13.0-1.3, CDC MBIM, 46:56:cd:f5:dc:d6
[   10.526450] usbcore: registered new interface driver cdc_mbim
[   11.315462] cdc_mbim 1-1.3:1.12 wwp0s19u1u3i12: renamed from wwan0

My relevant Nix config for using this device with Project Fi (no authentication, using mbim-proxy by default):
services.mbim-network.devices."/dev/cdc-wdm0".apn = "h2g2";

Starting the systemd unit brings the device up and shows that an IP configuration can be fetched successfully, with a few anonymizations:
Jun 23 14:49:24 routnerr-2 systemd[1]: Starting mbim-network for '/dev/cdc-wdm0'...
Jun 23 14:49:24 routnerr-2 mbim-network[22404]: Loading profile at /nix/store/8352hirv32jh9miadvynq0vm3bkal1vn-mbim-network-dev-cdc-wdm0.conf...

Jun 23 14:49:28 routnerr-2 mbim-network[22404]: [/dev/cdc-wdm0] Subscriber ready status retrieved: Ready state: 'initialized' Subscriber ID: 'xxx' SIM ICCID: 'xxx' Ready info: 'none' Telephone numbers: (1) 'xxx' [/dev/cdc-wdm0] Session not closed: TRID: '4'
Jun 23 14:49:28 routnerr-2 mbim-network[22404]: Saving state at /tmp/mbim-network-state-cdc-wdm0... (TRID: 4)
Jun 23 14:49:28 routnerr-2 mbim-network[22404]: Querying registration state 'mbimcli -d /dev/cdc-wdm0 --query-registration-state --no-open=4 --no-close --device-open-proxy'...
Jun 23 14:49:28 routnerr-2 mbim-network[22404]: [/dev/cdc-wdm0] Registration status: Network error: 'unknown' Register state: 'home' Register mode: 'automatic' Available data classes: 'lte' Current cellular class: 'gsm' Provider ID: '310260' Provider name: 'Project Fi' Roaming text: 'unknown' Registration flags: 'packet-service-automatic-attach' [/dev/cdc-wdm0] Session not closed: TRID: '6'
Jun 23 14:49:28 routnerr-2 mbim-network[22404]: Saving state at /tmp/mbim-network-state-cdc-wdm0... (TRID: 6)
Jun 23 14:49:28 routnerr-2 mbim-network[22404]: Attaching to packet service with 'mbimcli -d /dev/cdc-wdm0 --attach-packet-service --no-open=6 --no-close --device-open-proxy'...
Jun 23 14:49:28 routnerr-2 mbim-network[22404]: Saving state at /tmp/mbim-network-state-cdc-wdm0... (TRID: 8)
Jun 23 14:49:28 routnerr-2 mbim-network[22404]: Starting network with 'mbimcli -d /dev/cdc-wdm0 --connect=apn='h2g2' --no-open=8 --no-close --device-open-proxy'...
Jun 23 14:49:28 routnerr-2 mbim-network[22404]: Network started successfully
Jun 23 14:49:28 routnerr-2 mbim-network[22404]: Saving state at /tmp/mbim-network-state-cdc-wdm0...

And stopping the systemd unit brings the device down and clears the transaction ID state:
Jun 23 14:56:31 routnerr-2 systemd[1]: Stopping mbim-network for '/dev/cdc-wdm0'...
Jun 23 14:56:32 routnerr-2 mbim-network[25473]: Loading profile at /nix/store/8352hirv32jh9miadvynq0vm3bkal1vn-mbim-network-dev-cdc-wdm0.conf...

Jun 23 14:56:32 routnerr-2 mbim-network[25473]:     Previous Transaction ID: 13
Jun 23 14:56:32 routnerr-2 mbim-network[25473]: Stopping network with 'mbimcli -d /dev/cdc-wdm0 --disconnect --no-open=13 --device-open-proxy'...
Jun 23 14:56:32 routnerr-2 mbim-network[25473]: Network stopped successfully
Jun 23 14:56:32 routnerr-2 mbim-network[25473]: Clearing state at /tmp/mbim-network-state-cdc-wdm0...
Jun 23 14:56:35 routnerr-2 systemd[1]: mbim-network-dev-cdc-wdm0.service: Succeeded.
Jun 23 14:56:35 routnerr-2 systemd[1]: Stopped mbim-network for '/dev/cdc-wdm0'.

I have a few open questions:

Unfortunately, I have absolutely no idea how to test this change with a NixOS test as it relies on the physical modem device attached to my router. Any suggestions?

Does this belong under services.mbim-network or maybe something like networking.mbim?

I don't intend to implement it in this initial PR, but how should I deal with IP address configuration via the MBIM out-of-band signaling (note the post-start systemd unit output above)? My particular modem only supports raw-ip mode rather than 802-3, so I can't use DHCP.

I'm considering parsing the output of the IP query command and plumbing that into the NixOS networking config in some way but have no idea how that should work. Suggestions appreciated! A hand-wavey hypothetical config:
services.mbim-network.devices."/dev/cdc-wdm0" = {
  apn = "h2g2";
  netdev = {
    # Specifies which device which will have the configuration applied, and which parts of the configuration.
    name = "wwp0s19u1u3i12";
    configure = [ "address" "gateway" "dns" "mtu" ];
  };
};

/cc @flokli per our conversation in #nixos-on-your-router.

/marvin opt-in

/status needs_review

@flokli updated, thanks.

@flokli @symphorien thank you both for the reviews, updated.
@flokli, no rush at all. I have a copy of this module in my own configs and am able to import and use it there already. Thank you for your help.

After a couple of conversations on IRC, I suspect I am going to take the NetworkManager/ModemManager approach for my modem rather than using this module.
Should I close this PR or should I leave it open for review/merge in case it's useful for others?

This is outside of my area of expertise, but the diff looks good enough to me and it looks like @flokli and @symphorien already gave more knowledgeable reviews. I'd be fine with getting this finished up & merged if you're using it, but if you don't plan to use (and therefore maintain) it yourself I think its better to close it. If you want to help out others, maybe add documentation on the approach you opted for instead.
/status needs_work

If you do decide to pursue this further, I'd like to pick up the "secrets in store" discussion one more time. Is it really true that the relevant username/password is generally public knowledge?

I'd be fine with getting this finished up & merged if you're using it, but if you don't plan to use (and therefore maintain) it yourself I think its better to close it.

Will do, thanks!

If you want to help out others, maybe add documentation on the approach you opted for instead.

Unfortunately I don't have it quite worked out yet, but it seems like something along the lines of this will make it so NM/MM only manage GSM interfaces:
    networking.networkmanager = {
      enable = false;
      dns = "none";
      unmanaged = ["*,except:type:gsm"];
    };

From there, I have to do some more tinkering with the CLIs. If there's a way to Nixify all of that, I'll be sure to write up a guide.


WIP: Update to<EMAIL_ADDRESS>

This is a WIP update to use a newer version of the matrix-sdk. Several notes:

I still need a solution for migrating keys from the sled store into sqlite, so this only works on new logins
This required bumping the MSRV to 1.70, so anyone still using 1.67 will need to update
The sqlite store is now stored under $XDG_DATA_HOME/iamb/profiles/$PROFILE/sqlite instead of under $XDG_CONFIG_HOME/iamb/profiles/$PROFILE/matrix like the sled store was, as discussed in #iamb-users:0x.badd.cafe a couple months back

I cross-compiled some ARM binaries for gamingjones223 in #iamb-users. I'm posting them here in case anyone else wants to try them out:

iamb-armv7-linux.gz
iamb-aarch64-linux.gz


Seed identification API for Nachet frontend - updated

The purpose is to implement a seed wiki component for Nachet that is sourced from a JSON API that can be fetched on demand. I have pasted an example snippet of what the JSON format could look like below. The JSON can be generated by scraping the seed identification directory provided by the CFIA  (figure 1). In regards to the pictures provided on the website, a link to the image can also be provided in the JSON as well. The JSON would idly contain all seed species, distinguished by their scientific name.

FIGURE 1
[
    {
      "family": "Malvaceae",

      "common_name": "Velvetleaf",

      "duration_of_life_cycle": "Annual",

      "seed_or_fruit_type": "Seed",

      "identification_features":
       {
        "seed_length": "3.0 - 4.0 mm",

        "seed_width": "2.3 - 3.6 mm",

        "shape": "Heart-shaped seed with unequal lobes and a conspicuous notch at hilum end",

        "surface_texture": "Seed dull with minute reticulations and scattered tubercles,concentrated at the hilum",

        "colour": "Seed greyish brown with a lighter-coloured pubescence",

        "other_features": "Flap-like tissue covering the hilum may be present"
       },

       "images": [
        "https://inspection.canada.ca/DAM/DAM-plants-vegetaux/STAGING/images-images/invasive_plants_seed_factsheet_abutilon_theophrasti_01cnsh_1476382781946_eng.jpg",
        "https://inspection.canada.ca/DAM/DAM-plants-vegetaux/STAGING/images-images/invasive_plants_seed_factsheet_abutilon_theophrasti_01cnsh_1476382781946_eng.jpg"
      ],

       "source": "https://inspection.canada.ca/plant-health/seeds/seed-testing-and-grading/seeds-identification/abutilon-theophrasti/eng/1472604373914/1472604374428"

    }
  ]

This is the starting page where the list of seeds can be found:
https://inspection.canada.ca/plant-health/seeds/seed-testing-and-grading/seeds-identification/eng/1333136604307/1333136685768

Also, can you add this section to the "similar_species" key? I would display the info before showing the images.

@RussellJimmies I've added it into the code, so now you'll have access to all the details regarding similar species as well as the source URLs.


Adding more features to CuratedLogIndexState

Supporting different last modified times in CuratedLogIndexState. This will help testing BlobStoreStats and BlobStoreCompactor
Also adding APIs to get valid data sizes, reloading the log and for verifying the sanity of the index.
Formatted and built

Looks good. Merging.


Added support for specifyng test annotations

This pull request adds support for specifyng test annotations in the values.yaml file.
I made this change to allow for the exclusion of certain security violations flagged by FairwindsOps/polaris in the test-connection.yaml file.
These annotations allow for specific security violations to be excluded from the tests.
Please review my changes and let me know if you have any feedback or comments.
Thank you for the review!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your<EMAIL_ADDRESS>seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


sample audio/video problem

Hello
i tried to test the sample and added pem/cert files and could launch it successfully. I do see the camera image of myself and if i open a 2nd browser it shows another box (which remains black). No audio , and seemingly no video transmission
Did i do anything wrong with setup?
Thank you

HI i had the same issue. Just change the "annouceIp" in webRTCTransport_options to the IP-adress of your machine.

hello , I have changed  the announceIp to my machine ip address , but still it has problem  ?

worker = await mediasoup.createWorker({
rtcMinPort: 2000,
rtcMaxPort: 2050,
})
thank you for answer this is my webRTC ports

but  , when my listenIP is <IP_ADDRESS>  it works correctly

then stick to <IP_ADDRESS>

all steps are done successfully , when replace the <IP_ADDRESS> with my ip  the below error happens :
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getUserMedia')

the browser does not have access camera or microphone of the computer
you will find plenty of help for this issue on the internet

I have searched a lot , the problem is not from camera permission ,
I created a simple js file and run it with live server in  address <IP_ADDRESS>:5000 , getLocalstream works fine
but when I change it to <IP_ADDRESS>:3000 , the error appears
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'getUserMedia')

thank you brother ,
the problem of my code resolved .
the problem was from camera permission

Hi
I implemented this code and there is no problem.
It works very well.
But I want to make a change in the code so that all connections are made on one port.
It means to use one transfer layer for all people.


hivemind: init at 1.0.4

Motivation for this change
A "simpler" version of overmind without the tmux dependency.
FYI. When searching the the issues I noticed that there was another, unrelated package called hivemind that has since been removed.
https://github.com/canndrew/nixpkgs/blob/42d7fa2c7160d513c9e043b9f6e1ba6b58b4deaa/pkgs/applications/altcoins/hivemind.nix
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build hivemind


Add support for custom font families and styling to watermarks

Closes https://github.com/tradingview/lightweight-charts/issues/437
Type of PR:
PR checklist:

[x] Addresses an existing issue: fixes https://github.com/tradingview/lightweight-charts/issues/437
[ ] Includes tests
[x] Documentation update

Overview of change:
Is there anything you'd like reviewers to focus on?

I am not sure how to fix the dts-changes build, any suggestions?

I am not sure how to fix the dts-changes build, any suggestions?

That's expected. That test means that we have some changes in public API so we need to carry about that and see that everything is public as expected. In your case this is expected so please don't worry about it.

Hey @meetmangukiya, do you have any updates here? I'm asking because we're going to prepare to 3.0 release soon and I think it'd be awesome to put it into that release as well. If you haven't enough time for it, please let me know and I think we'll finish it.

Hey @timocov sorry for the delay, even though its a small change, haven't been able to find the time to do it and would need some more time to get around this.

@meetmangukiya sure, no worries and no problem at all. Just to be sure - you're going to finish it but you need a bit time, right? (to avoid misunderstanding).

@timocov when is the release scheduled for?

We don't have specific date for it, but I hope it should be within 1-2 weeks.

Hey @meetmangukiya, any updates on this? As I said, we can finish it if you'd like (no pressure, just a reminder 🙂).

@timocov I pushed the changes. Not sure if I got the graphics test right. Also, don't think it will work because this PR introduces visual difference, not sure if it is above or below the tolerance threshold. Sorry for the delay.

Hey @meetmangukiya, thanks for update and no worries! I just added some changes ahead of yours, but nothing critical.

Not sure if I got the graphics test right.

You got them completely right!

Also, don't think it will work because this PR introduces visual difference, not sure if it is above or below the tolerance threshold

That's ok. That tests might be broken, they just help us see what's actually changed in visual part.

Merged. @meetmangukiya thank you for your contribution!


how to compile to epub or static site?

This is folders of text files, which is not ideal for navigation
Requesting an epub I can read offline, or at least a web page without the GitHub distractions.
I imagine I am not the first to think about this, so I'll refrain from suggesting anything more specific until I know your context.

What you propose sounds good. Ideally I would like to hots it in gitbook platform, but unfortunatley, I can only host one book for free. Therefore, the alternative would be to generate, automatically, epub / PDF documents processing markdown files. Idealy, this should be integrated in Github CI. Anyone is familiar with the best tool for that? (to save research time)
If you have any other idea, please feel free to comment.

Just added automatic EPUB generation using pandoc in Github actions. If you detect and issue please report.


Implement toBool, directoryExists, createDirectory

[x] tests and linter show no problems (npm t)
[x] tests are added/updated for bug fixes and new features
[x] code is properly formatted (npm run fmt)
[ ] description of changes is added in CHANGELOG.md
[ ] update .d.ts typings

Landed in https://github.com/metarhia/metautil/commit/f0a7f59ae8761aad9e395cd63ce709dc8f9c9e13 and https://github.com/metarhia/metautil/commit/dfb2f1763435986462fe42d03ca109425fd5c5a9


merge package template from arlac77/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template

Coverage remained the same at 69.388% when pulling c7830eb2788f86b81c852f5897c439e62fde74fa on template-sync-1 into 75b99790bf136e7c353170e7e61a48ba49667690 on master.

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   69.79%   69.79%
=======================================
  Files           2        2
  Lines          96       96
=======================================
  Hits           67       67
  Misses         29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75b9979...c7830eb. Read the comment docs.


waitForXPath('') is not working any more

 waitForXPath('')  is not working any more . I couldn't find the function inside page.js and FrameManager.js in the puppeteer node modules
Steps to reproduce
const assigneeNameXpath= await page.waitForXPath('//*[starts-with(@id,"assignee")]/text()');
Tell us about your environment:

Puppeteer version: "puppeteer": "^1.0.0",
Platform / OS version: Windows
URLs (if applicable):
Node.js version: 9

What steps will reproduce the problem?
Please include code that reproduces the issue.

try using the function wait for xpath

What is the expected result?
identify the element
What happens instead?
TypeError: page.waitForXPath is not a function
at Context. (test\tigerTiketCreation.js:64:51)
at

I have to update the version to 1.3 tfor xpath in my package .json


[BUG]: rio.Table column padding too wide since v0.7.5

Describe the bug
Following on from a conversation on Discord with @Aran-Fey yesterday, since v0.7.5 was released (which fixed rio.Table not resizing vertically when updated with new data) all rio.Tables now seem to use a much greater horizontal column padding to push the columns apart, sometimes to the edges of the browser window.
Expected Behavior
When building a rio.Table, a sensible horizontal padding between table columns should be chosen to not spread the table over the entire width of its container, as was the case in v0.7.4.
Steps to Reproduce
On Rio v0.7.4, create a project with the following __init__.py:
from __future__ import annotations

from pathlib import Path
from typing import *  # type: ignore    s

import rio

class RootPage(rio.Component):
    def build(self) -> rio.Component:
        return rio.Column(
            rio.Table(
                {f'Col{i}': [i+1, i+2, i+3] for i in range(10)},
                show_row_numbers=False
            ),
            spacing=2,
            width=60,
            margin_bottom=4,
            align_x=0.5,
            align_y=0,
        )

app = rio.App(
    name='Table_MWE',
    pages=[
        rio.Page(
            name="Home",
            page_url='',
            build=RootPage,
        )
    ]
)

Use rio run to visualise the built site. The table will sensibly space out its columns, as in the first screenshot (rio_mwe_074)
Update Rio to v0.75 or newer (I'm now on v0.7.7) and visualise the site with rio run. The columns of the table will now be pushed apart as in the second screenshot (rio_mwe_077), resulting in a stretched table that becomes difficult to read with longer string values in its fields.
Screenshots/Videos

Operating System
Linux
What browsers are you seeing the problem on?
Chrome
Browser version
124.0.6367.201
What device are you using?
Desktop
Additional context
No response

Thanks for the bug report. It's fixed in 0.7.8.


GEOMESA-1079 - VisibilityFilter's accept method should not assume second arg is a filter after gt version upgrade

Creates a Function instead of the filter

Signed-off-by: David Seapy<EMAIL_ADDRESS>

I didn't test it but looks good.

61ba534bd928ed8b7e34842070db29da1d7aa297


fix 1358 Solve the problem of dependency change status not being updated

What type of PR is this?

bug
What this PR does / why we need it:
Resource dependency status maintenance and improvement needs
Which issue(s) this PR fixes:

Fixes #1358
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Solve the problem that the resources have not changed but the dependencies have changed, but the resource dependencies in status maintenance have not changed.

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 47.465%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/engine/operation/graph/resource_node.go
0
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>9:
0.003%

Covered Lines:
10625

Relevant Lines:
22385

💛  - Coveralls


Engineering techfab.

About the PR

Implements engineering techfab.
Could probably balance the fact that autolathe has just random stuff in it after a discussion.
Why / Balance

Okay so. Engineering as it currently stands, is uncapable of fixing most basic equipment and if somethin needs to be fixed that isnt just a mere electronic, they pretty much require the help of science to just do basic job which they were hired for.
What I propose is making an engineer techfab and include basic circuits and tools that engineers would find essential to fix.
-Gives engineers somethin to do aka they can make more stuff and can fix the departemental equipment if there would be an explosion instead of a scientist doing it.
-The science would still do the neccesary upgrading because their protolathe would upgrade with science etc while engineers just ensure that the station is intact.
-It could be simply placed where the autolathe was in engineering.
-Could remove some stuff from autolathe to not make it as big of a mess and require engineering to make it instead of science being more of engineers than the engineers themselfs. (This change would require massive mapping so probably a PR after this would be merged [hopefully] to get rid of stuff from the autolathe itself)
Thats pretty much most reasons that I was able to think of as it currently stands.
The PR is a draft to ensure that anyone who comments, I would be able to read and reflect upon or perhaps be reminded that I forgot to add somethin that an engineer could probably need/not need or dare I even say, discuss the matter of adding a techfab for our engineers.
Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

This is just the autolathe and circuit imprinted with a couple of things cut out... can you not just go to sci?

This is just the autolathe and circuit imprinted with a couple of things cut out... can you not just go to sci?

Still, it’s better than nothing. In the future, it will be possible to add new items for printing, specifically for engineers

finally
science shouldn't produce things

finally
science shouldn't produce things

sci has to have at least one useful function...

finally
science shouldn't produce things

sci has to have at least one useful function...

science has lots of useful functions, what do you mean?

finally
science shouldn't produce things

sci has to have at least one useful function...

science has lots of useful functions, what do you mean?

He probably meant techfab, I hope

finally
science shouldn't produce things

sci has to have at least one useful function...

science has lots of useful functions, what do you mean?

He probably meant techfab, I hope

Erm, the point of this is to allow engineers to make basic stuff, not make science never make stuff, hence why i didnt include a circuit imprinter or protolathe circuit boards in there, to not allow engineers to just build it themselfs and just do the new stuff themselfs. Of course, I would also want autolathe to not be able to make these stuff because..... why can it? And even with the argument of ask someone, then you will have to ask engineers to make you a tool as an example if i were to make this PR full. Hell I even though about getting rid of some basic research like having to research microwave because.... why do you have to make a microwave when it is basic equipment that is neccesary for a job like chef?

I mean, if there is a need for interaction then this could be said that this would be part one and then i would make a second part where autolathe would loose the possibility of making tools and you got interaction right there, everyone needs to ask engineers for tools and scientist/engi is still there because they only get basic stuff and if they wanted an upgrade then they still need to talk to the scientists(nerds)

Member

If the interaction is the main thing regardin it, how about this.
Takin out tools from autolathe so that every single department that wants tools has to bother with engineering.
Getting rid of the circuit boards from the engi techfab so that they still have to bother with science even to just make the basic equipment of a department (or just let science fix it themselfs)
Get rid of circuits from autolathe and basicly make autolathe be a service/cargo techfab.
Another thing to point out is that i wouldnt be doing this solution in one PR just because there would be no way of obtaining tools without mapping the engi techfabs first.

The contents of the engie techfab seem to literally just be a bloat-removed autolathe as well as every static option in the circuit imprinter. I don't see how this necessary addresses engineering repairing when compared to just having an autolathe inside of the department.

this just seems to be a way to circumvent interaction with science for things that aren't really necessary (especially for things like the random machine boards)

If the interaction is the main thing regardin it, how about this. Takin out tools from autolathe so that every single department that wants tools has to bother with engineering. Getting rid of the circuit boards from the engi techfab so that they still have to bother with science even to just make the basic equipment of a department (or just let science fix it themselfs) Get rid of circuits from autolathe and basicly make autolathe be a service/cargo techfab. Another thing to point out is that i wouldnt be doing this solution in one PR just because there would be no way of obtaining tools without mapping the engi techfabs first.

Because with that logic, everyone has to bother science and not engineering, there is literly zero reason currently to bother with engineering besides
-There is a big hole in medical, go do somethin about it.
And thats it.
There is no other reason just because science doesnt have an EVA suits otherwise they would have done it themselfs (again)


Adjust maintainer contact lint

Closes https://github.com/ocaml/infrastructure/issues/152 by addressing
the subsequenst requests for tweaked behavior.
With this change in place, the lint will only fail if there is no email address
at all in the maintainer field AND no bug-tracker. We already issue a warning
when no bug-tracker is present, and since we currently make no distinction
between errors and warnings in our CI results, this check is made somewhat
redundant. However, once https://github.com/ocurrent/opam-repo-ci/issues/328 is
introduced, the distinction here will make a difference.

Thanks for the review :)


Ts 3371

Adding a record.config variable for globally disabling/enabling session ticket

Minor details, but

Can this be squashed into one commit?

Please update the Subject / Title of this PR accordingly.

Also, the branch has merge conflicts, so please rebase with current master.

Also, if the old default was "1", why did we change to "0" now?

oops. I will make the default back to 1

Also fix the merge conflicts and squash the commits down to one please :)

proxy.config.ssl.server.session_ticket.enable makes much more sense to me


[Event Request] Table 38 Purchase Header - procedure SetPurchaserCode()

  local procedure SetPurchaserCode(PurchaserCodeToCheck: Code[20]; var PurchaserCodeToAssign: Code[20])
    var
        UserSetupPurchaserCode: Code[20];
    begin

----------------------- ADD EVENT ----------------------
        IsHandled := false;
        OnBeforeSetPurchaserCode(Rec, PurchaserCodeToCheck, PurchaserCodeToAssign, IsHandled);
        if IsHandled then
            exit;
----------------------------------------------------------

        UserSetupPurchaserCode := GetUserSetupPurchaserCode;
        if PurchaserCodeToCheck <> '' then begin
            if SalespersonPurchaser.Get(PurchaserCodeToCheck) then
                if SalespersonPurchaser.VerifySalesPersonPurchaserPrivacyBlocked(SalespersonPurchaser) then begin
                    if UserSetupPurchaserCode = '' then
                        PurchaserCodeToAssign := ''
                end else
                    PurchaserCodeToAssign := PurchaserCodeToCheck;
        end else
            if UserSetupPurchaserCode = '' then
                PurchaserCodeToAssign := '';
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Do you ever actually "update this issue with information about availability"? I don't recall ever seeing such updates. Which CU(s) will this publisher be added in, please?


[aws-v2] Adding mvn parent for aws-v2

Codecov Report

Merging #63 (853fc0c) into main (d296832) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #63   +/-   ##
=========================================
  Coverage     40.61%   40.61%
  Complexity      145      145
=========================================
  Files            68       68
  Lines           783      783
  Branches         32       32
=========================================
  Hits            318      318
  Misses          432      432
  Partials         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d296832...853fc0c. Read the comment docs.


Experimenting with CI testing

I created this pull request so I can mess with getting the CI setup without using other pull requests

Looks I got the CI fixed to only test the last commit, and not all commits.

test this please

test this please

Testing with cvxopt and mosek in virtualenv's is now working.

another intentional master push: b1943eea84e6187849e0e553d2c8e647a1bd4a3f

test this please

test this please

@whoburg How do I re-open this?

It is so!

Thank you!

Sure thing! let me know when to close it :p

test this please

@whoburg @bqpd As best as I can tell there is definitely a bug inn jenkins. I submitted a bug report here:https://issues.jenkins-ci.org/browse/JENKINS-29963?jql=project %3D JENKINS AND status in (Open%2C "In Progress"%2C Reopened) AND component %3D 'ghprb-plugin'
The temporary solution is to make sure you build all pull requests twice.
The testing will also be 5 times faster once we find a way to not use .gpkit, at least in the testing.

Hmm, okay!

test this please

Ok, I think I was able to fix it so you do not have to build twice. The way the changes were getting computed was what was messing things up. So there is still a bug, but we do not need to build twice to avoid it.

I forgot I need to push something to do a real test. I may have spoken too soon.

I spoke too soon. Keep testing twice.

Haha, will do.
Unrelatedly, it'd be great to set up some python3 test...platforms?...at some point.

Yes we can setup python3 testing, and pypy if you want. But until we fix #315 that will increase the testing time by a factor of 4.

test this please

I setup a python3 environment on the Linux machine, and found that there are a lot of failures in the master branch. Let me know when you are ready to have python3 testing.

Will do!

@bqpd We still have the bug in Jenkins where it test the previous commit rather than the current one. @whoburg Does anyone in your group know java? I think I know where the bug is in the plugin, but I'm not proficient enough in java to fix it.

which plugin is the bug likely in? Should we contact the authors?

I have submitted the bug already, but not gotten any response.
https://issues.jenkins-ci.org/browse/JENKINS-29963?jql=project %3D JENKINS AND status in (Open%2C%20
"In%20Progress"%2C%20Reopened)%20AND%20component%20%3D%20%27ghprb-plugin%27
This is all people doing things on their own time. Bribery might work, and
I have found the best form of bribery is creating a pull request with the
fix.
The plugin repo is here:
https://github.com/janinko/ghprb
On Thu, 03 Sep 2015, 09:36 Warren Hoburg<EMAIL_ADDRESS>wrote:

which plugin is the bug likely in? Should we contact the authors?
—
Reply to this email directly or view it on GitHub
https://github.com/convexopt/gpkit/pull/342#issuecomment-137447774.

test this please

I've added an El Cap testing machine for you

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

Thanks @galbramc! @bqpd, any idea why we're getting PosyArray operator overloading issues? I saw one of the CI e-mails said numpy was not installed -- is that a possible cause?

on the ElCap tests?

yeah

retest this please

retest this please

retest this please

retest this please

@galbramc, watching the tests run in parallel is super cool! Thanks!

If you fix issue #315 it will be even more parallel

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

You have to first flip a switch in jenkins to tell it to reset the counts.  I'm on my way in to the office, but I can show you the switch when I get there.

Test this please

Test this please

test this please

test this please

test this please

hmm yeah, @galbramc I think we might want to revert pint for now - though thanks for finding that issue!

retest this please
I reverted pint back to version 0.6 on all the testing machines

retest this please
resetting the pylint counts

retest this please
resetting the pylint counts

retest this please
resetting the pylint counts

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

Can one of the admins verify this patch?

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

Test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please
just checking the counts

test this please

Test this please

test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

Test this please

Test this please

retest this please

Test this please

Test this please

Test this please

Test this please

Test this please

Test this please

test this please

test this please

Test this please

Test this please

test this please

test this please

test this please

test this please

test this please

test this please

Test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test gpkit please

test gpkit please

test gpkit please

test gpkit please

test gpkit please

test gpkit please

test gpkit please

test gpkit please

test gpkit please

test gpkit please

test models please

test models please

test gpkit please

test gpkit please

test gpkit please

test models please

test gpkit please

test gpkit please

test gpkit please

test this please

test this please

test models please

current error on windows10 cvxopt is documented here: https://github.com/cvxopt/cvxopt/issues/127#issuecomment-441868958
not sure what the right thing to do here is, since cvxopt just doesn't work with a pip install on the system Python right now.


[LLCView] Improve the credential type shown

Right now, the credential shown is hard coded to AzureCredential. We want to take advantage of the information in m4 to be more precise:

TokenCredentials (needs a AAD token)
KeyCredentials (needs a key in header)
Both

@timotheeguerin can help to provide guidance on what to read from m4 yaml to make a distinction in the supported type.

Closing as LLC View will be replaced with Swagger view.


Add artifactBundle to release process

It would be nice to have a artifactBundle zip be vended as part of the release. For me this would be specifically for usage in swift package manager. It could then be pulled down directly as a binary target and used directly from plugins without pulling in packages or dependencies.
It would be nice to have this option available for dependency collisions as well.
Technically I'm not entirely sure what this means. I am able to do this with SwiftLint by doing this:
        .binaryTarget(
            name: "SwiftLintBinary",
            url: "https://github.com/realm/SwiftLint/releases/download/0.50.3/SwiftLintBinary-macos.artifactbundle.zip",
            checksum: "abe7c0bb505d26c232b565c3b1b4a01a8d1a38d86846e788c4d02f0b1042a904"
        ),

Attempting to do the same with the 2.0.1 release results in an error about unknown extension of docset, which seems like it is just not picking up the right thing. Inspecting the SwiftLint zip it appears to have a single folder of the release name followed with the bin folder and binary

Sourcery-2.0.1.artifactbundle.zip
Until it is fixed, I'm attaching self-made artifactbundle for my own needs :)

+1


Add Contibuting.md file

Motivation
The project does not have a contributing.md file which needs to be added
Guidelines for documentation

Skim out the documentation instructions from readme.md and put them in contributing.md file.
Add instructions on how to

install python
setup virtual environment
install the software
run the command live

Also include instructions on recommended editor and associated extensions.

@rootCircle
if this issue is available I would like to work on it

Sure go ahead! Tell me if you need any help!


Can't seem to get the generic API to work

I'm trying to use the generic  API config setting and I get the following error:
[2/12/2018, 3:17:52 PM] [Toy Pod] ERROR in _checkStates() - ERROR in _determineDoorState() - An error occurred during the HTTP request: getaddrinfo ENOTFOUND <IP_ADDRESS>test <IP_ADDRESS>test:80
My api config is:
{
"accessory": "HttpGarageDoorController",
"name": "Toy Pod",
        "httpHost": "<IP_ADDRESS>",
        "httpPort": 80,
        "httpSsl": false,
        "httpStatusPollMilliseconds": 60000,
        "httpRequestTimeoutMilliseconds": 10000,
        "apiConfig":
        {
          "apiType": "Generic",

          "doorOpenMethod": "GET",
          "doorOpenUrl": "test/open",
          "doorOpenSuccessContent": "OK",

          "doorCloseMethod": "GET",
          "doorCloseUrl": "test/close",
          "doorCloseSuccessContent": "OK",

         "doorStateMethod": "GET",
         "doorStateUrl":"test/status"
        }
   },

The files are there and should return "OK". I tried putting a "/" in front  of the  "test/" in the Url fields but that generates a 404 error.
I'm trying to simply pass this to the server <IP_ADDRESS>
HB_Link?num=x&op=OPEN|CLOSE|STATUS
where x = 1, 2 or 3 and one of the op parameters. The PHP code works when called from a browser window. As that didn't work I tried  to hit the  files as per your example, but I get the above error. That error also is returned when I substitute my full Url requests.
The above entry is for one of my 3 doors. The doors show up accurately in the homebridge display.  The config.json file passes the lint test and my other devices are still working. Do you have any suggestions why I can't pass <IP_ADDRESS>/test/HB_Link&num=1&op=STATUS from the generic API?

I've been looking at this some more and discovered that you ca not use any further directory links. I moved my file up to the web root. Next step was to remove the .php. Now I  have the response working I just have to work out how to get the internals working to connect to my garage code. Here's a snippet of my current working config.json.
{
"accessory": "HttpGarageDoorController",
"name": "Dave's Pod",
        "httpHost": "homebridge.local",
        "httpPort": 80,
        "httpSsl": false,
        "httpStatusPollMilliseconds": 60000,
        "httpRequestTimeoutMilliseconds": 10000,
        "apiConfig":
        {
          "apiType": "Generic",

          "doorOpenMethod": "GET",
          "doorOpenUrl": "/hblink?num=1&op=open",
          "doorOpenSuccessContent": "OK",

          "doorCloseMethod": "GET",
          "doorCloseUrl": "/close",
          "doorCloseSuccessContent": "OK",

         "doorStateMethod": "GET",
         "doorStateUrl":"/status"
        }
   }

Looks like generic Api won't work for me as you can't pass any parameters into the web server. Not sure if this a node issue or the plugin not passing full URL data through. So far I can read the value of status, but as I can't take any actions on open and close. pretty much stuck.  It does look good in the homelink app though.
Cheers
Dave

Reopened as I closed by accident. Is it an issue with api or node?

The files are there and should return "OK". I tried putting a "/" in front of the "test/" in the Url fields but that generates a 404 error.

You do need the leading "/", then the 404 is coming from the web server.

I've been looking at this some more and discovered that you ca not use any further directory links. I moved my file up to the web root.

Shouldn't be necessary, whatever URL you configure, will be what is requested from the web server.

Looks like generic Api won't work for me as you can't pass any parameters into the web server.

Reviewing the code, I can see a bug where if OAuth signing is disabled, the query string isn't sent in the request.
Even if your web server isn't using OAuth, simply enable it in the config and then your parameters will be included in the requested URL.

I added back in all the authorization and HTTp header information. That seemed to fix it.. I can now send the parameters and get status back. I still have some work to do on my side for the final integration.
In summary, there is a bug with the code as it needs ALL the http header and authorization variables to be included. Nothing is optional as far as I can tell.
Thanks for the assistance!  Siri is now opening and closing my "garage doors". Well at least my test code.

Robboz4, can you branch your working code?
Sent with GitHawk

There’s no change to any code, only the values in the config.json file. My test code receives the requests. The status request gets a response back on the state of the door. The test code is a simple php file that uses echo to return the state. I still have to interface it to my-garage code
(https://github.com/robboz4/My-Garage). Do you want me to post the test code or my working config.json file?

@robboz4 Your working config.json file

Here it is:
config.json.zip


set initial state from localstorage

Hello,
I am struggling a bit in re-populating a store from localStorage(we use micro services and the data is passed from one app to another in localStorage ).
I looked at the examples here : https://github.com/reactql/example-auth but in my case unfortunately i can't use cookies.

I tried to call an action on componentWillMount() in the main component
I tried to change the initial state based on a if statement on SERVER global var
i tried to add the dispatch event in the entry/browser.js before the store variable is injected

But all are either ignored or i get message that the server side html is not valid.
I would really appreciate if anyone could point me in the right direction.
Cheers

Apologies for the generic response, but I've released a new v3.0 kit, which has been re-written from the ground up.
It bumps the ReactQL stack to Webpack 4, React 16.4, Apollo Client 2.0, and adds Styled Components, full SSR (even in development), and has been re-written in Typescript. It's leaner, faster and has been brought completely up-to-date.
If you're still using ReactQL (and I appreciate you may not be, given the time lag in my response), I'd recommend checking out the new kit to see if your issue has been answered. If not, please feel free to post a new issue at https://github.com/leebenson/reactql


Automatic update of PLaSK to 2024.08.23

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Installation failed with exit code -1978335187
2024-08-28 05:33:39.420 [FAIL] Installer failed security check. Url: https://get.plask.app/packages/PLaSK-2024.08.23-win64-py312.exe Result: 0x80004005
MSI (s) (98:4C) [05:33:25:184]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (98:4C) [05:33:25:184]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (98:4C) [05:33:25:184]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (98:4C) [05:33:25:184]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (98:4C) [05:33:25:184]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.
Property(S): OutOfDiskSpace = 0
Property(S): OutOfNoRbDiskSpace = 0
Property(S): PrimaryVolumeSpaceAvailable = 0
Property(S): PrimaryVolumeSpaceRequired = 0
Property(S): PrimaryVolumeSpaceRemaining = 0
MSI (s) (98:00) [05:33:25:965]: PROPERTY CHANGE: Adding OutOfDiskSpace property. Its value is '0'.
MSI (s) (98:00) [05:33:25:965]: PROPERTY CHANGE: Adding OutOfNoRbDiskSpace property. Its value is '0'.
MSI (s) (98:00) [05:33:25:965]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceAvailable property. Its value is '0'.
MSI (s) (98:00) [05:33:25:965]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRequired property. Its value is '0'.
MSI (s) (98:00) [05:33:25:965]: PROPERTY CHANGE: Adding PrimaryVolumeSpaceRemaining property. Its value is '0'.

Automated error analysis suggests -1978335187 may mean Installer failed security check. Another script should retry this every 18 hours.
Automated error analysis suggests 80004005 may mean Resource missing
(Automated response - build 891.)

/azp run

@wingetbot run

@wingetbot run

@wingetbot run

@wingetbot run

This package installs and launches normally in a Windows 10 VM.

This package installs and launches normally in a Windows 10 VM.

I didn't get file or disk stats. This package took about 12 minutes to download and install, (from 9:48:52 AM to 10:03:34 AM) but installed 287,200 files, so the VM tooks 113 minutes (to 11:54:11 AM) to find all changes.


Feature/keithley dmm6500

Hello everybody,
I have written a driver for the Keithley DMM6500 digital multimeter. Hope it is useful!

It looks like the Test on Linux failed because of the example notebook that I added. Apparently the test tries to execute the notebook again.

Hi, You need to disable the execution of the notebook as documented here https://qcodes.github.io/Qcodes/examples/writing_drivers/Creating-Instrument-Drivers.html#Documentation

Thanks for the hint, I fixed it now.

The mypy test in Linux fails because of an error in the following file:
qcodes_contrib_drivers/drivers/ZurichInstruments/ZIHDAWG8
I did not edit this file and I rebased my branch to the latest version of the master branch.

Should be fixed by https://github.com/QCoDeS/Qcodes_contrib_drivers/pull/60


how to integrate with redux dev tools ?

Actually it is not possible. It is something we should have in future.

@iusehooks Would be a great addition.  Great library thank you!


Use server 2019 image with visual studio 2019

@pascalberger I didn't write that the build is failing because of Visual Studio, but I wanted to test if our packages are still working with Server 2019 image which also provides Visual Studio 2019 because we need this for the SonarLint package. There we got the error
sonarlint-vs2019 v<IP_ADDRESS>64
sonarlint-vs2019 package files install completed. Performing other installation steps.
ERROR: Visual Studio is not installed or the specified version is not present

@pascalberger seems this was a temporary issue, now it is working without additional changes from myside. But wait it seems that this is still not working see other pipeline build
But maybee it make sense to change the image anyway independent the other PR.


Runtime Error : Falco Probe Loader(.ko) for falco 0.17.1 and kernel 4.14.146-120.181.amzn2.x86_64 results in run-time error

What happened: While trying to run Falco as a daemonset on kubernetes cluster there was a Run-time error caused by pre-compiled Falco Probe kernel object file for falco version 0.17.1 and kernel 4.14.146-120.181.amzn2.x86_64.
Falco version : **0.17.1**
kernel version : **4.14.146-120.181.amzn2**
Architecture : x86_64
ko_file : https://s3.amazonaws.com/download.draios.com/stable/sysdig-probe-binaries/falco-probe-0.17.1-x86_64-4.14.146-120.181.amzn2.x86_64-78c7dcf4ded9d7112216d1cd3af56c83.ko

$ kubectl logs -f falco-daemonset-45lvh
Mon Oct 28 22:37:15 2019: Falco initialized with configuration file /etc/falco/falco.yaml
Mon Oct 28 22:37:15 2019: Loading rules from file /etc/falco/falco_rules.yaml:
Mon Oct 28 22:37:15 2019: Loading rules from file /etc/falco/falco_rules.local.yaml:
Mon Oct 28 22:37:15 2019: Loading rules from file /etc/falco/k8s_audit_rules.yaml:
Mon Oct 28 22:37:15 2019: Unable to load the driver. Exiting.
Mon Oct 28 22:37:15 2019: Runtime error: error opening device /host/dev/falco0. Make sure you have root credentials and that the falco-probe module is loaded.. Exiting.

What you expected to happen: Falco container must run successfully without any errors.
Below is one of the successful outputs for Falco Version 0.17.1 and Kernel 4.14.146-119.123.amzn2.x86_64
Falco version : 0.17.1
kernel version : 4.14.146-119.123.amzn2.x86_64
Architecture : x86_64
ko_file : https://s3.amazonaws.com/download.draios.com/stable/sysdig-probe-binaries/falco-probe-0.17.1-x86_64-4.14.146-119.123.amzn2.x86_64-2a8e59358e4477733a8a706f1784f316.ko

kc$ kubectl logs falco-daemonset-7l4qd

Mon Oct 28 22:24:20 2019: Falco initialized with configuration file /etc/falco/falco.yaml
Mon Oct 28 22:24:20 2019: Loading rules from file /etc/falco/falco_rules.yaml:
Mon Oct 28 22:24:20 2019: Loading rules from file /etc/falco/falco_rules.local.yaml:
Mon Oct 28 22:24:20 2019: Loading rules from file /etc/falco/k8s_audit_rules.yaml:
Mon Oct 28 22:24:21 2019: Starting internal webserver, listening on port 8765

How to reproduce it (as minimally and precisely as possible):

Package Falco Docker container (falcosecurity/falco:0.17.1) with required falco probe kernel object file for kernel version 4.14.146-119.123.amzn2.x86_64 from S3 - sysdig-probe-binaries in /root/.sysdig directory. The specific file would be falco-probe
Run Falco as daemonset on kubernetes cluster with environment variable : SYSDIG_SKIP_LOAD="true" passed to falco docker container.

Anything else we need to know?:
Environment: Kubernetes

Falco version (use falco --version): 0.17.1
System info :

2019-10-28T23:23:13+0000: Falco initialized with configuration file /etc/falco/falco.yaml
2019-10-28T23:23:13+0000: Loading rules from file /etc/falco/falco_rules.yaml:
2019-10-28T23:23:13+0000: Loading rules from file /etc/falco/falco_rules.local.yaml:
2019-10-28T23:23:13+0000: Loading rules from file /etc/falco/k8s_audit_rules.yaml:
{
  "machine": "x86_64",
  "nodename": "falco-pod",
  "release": "4.14.146-120.181.amzn2.x86_64",
  "sysname": "Linux",
  "version": "#1 SMP Fri Oct 18 17:01:06 UTC 2019"

Cloud provider or hardware configuration: Kubernetes
OS (e.g: cat /etc/os-release):

PRETTY_NAME="Debian GNU/Linux bullseye/sid"
NAME="Debian GNU/Linux"
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Kernel (e.g. uname -a): Linux falco-pod 4.14.146-120.181.amzn2.x86_64 #1 SMP Fri Oct 18 17:01:06 UTC 2019 x86_64 GNU/Linux
Install tools (e.g. in kubernetes, rpm, deb, from source):
Others:

/triage support

For now I have built the ko files for Falco versions 0.17.0 , 0.17.1 and 0.18.0 for latest 2 kernel versions of Amazon Linux 2 OS . (https://falco-kernel-modules.s3-us-west-1.amazonaws.com/) . I have tested all these kernel modules with respective versions of Falco and everything is working fine.
Since we use Amazon Linux 2 AMI for running Kubernetes Clusters , we will be regularly building Falco KO files for latest 3 versions of Falco each time there is a newer kernel version.
I will work with @fntlnz to get these files uploaded to Falco S3 bucket so that others using Amazon Linux 2 OS can use the pre-compiled Falco Kernel Modules.
Closing this bug as https://falco-kernel-modules.s3-us-west-1.amazonaws.com/falco-probe-0.17.1-x86_64-4.14.146-120.181.amzn2.x86_64-78c7dcf4ded9d7112216d1cd3af56c83.ko is available.


0.17.1 container crash due to ostruct gem version lock

I updated the container to 0.17.1 and it crashes with this message:
/usr/local/bundle/gems/bundler-2.5.18/lib/bundler/runtime.rb:299:in `check_for_activated_spec!': You have already activated ostruct 0.6.0, but your Gemfile requires ostruct 0.5.5. Since ostruct is a default gem, you can either remove your dependency on it or try updating to a newer version of bundler that supports ostruct as a default gem. (Gem::LoadError)
	from /usr/local/bundle/gems/bundler-2.5.18/lib/bundler/runtime.rb:25:in `block in setup'
	from /usr/local/bundle/gems/bundler-2.5.18/lib/bundler/spec_set.rb:191:in `each'
	from /usr/local/bundle/gems/bundler-2.5.18/lib/bundler/spec_set.rb:191:in `each'
	from /usr/local/bundle/gems/bundler-2.5.18/lib/bundler/runtime.rb:24:in `map'
	from /usr/local/bundle/gems/bundler-2.5.18/lib/bundler/runtime.rb:24:in `setup'
	from /usr/local/bundle/gems/bundler-2.5.18/lib/bundler.rb:164:in `setup'
	from /usr/local/bundle/gems/bundler-2.5.18/lib/bundler/setup.rb:32:in `block in <top (required)>'
	from /usr/local/bundle/gems/bundler-2.5.18/lib/bundler/ui/shell.rb:159:in `with_level'
	from /usr/local/bundle/gems/bundler-2.5.18/lib/bundler/ui/shell.rb:111:in `silence'
	from /usr/local/bundle/gems/bundler-2.5.18/lib/bundler/setup.rb:32:in `<top (required)>'
	from <internal:/usr/local/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
	from <internal:/usr/local/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
	from /app/lib/onetime.rb:3:in `<top (required)>'
	from config.ru:22:in `require_relative'
	from config.ru:22:in `block in <main>'
	from /usr/local/bundle/gems/rack-2.2.9/lib/rack/builder.rb:125:in `instance_eval'
	from /usr/local/bundle/gems/rack-2.2.9/lib/rack/builder.rb:125:in `initialize'
	from config.ru:1:in `new'
	from config.ru:1:in `<main>'
	from /usr/local/bundle/gems/thin-1.8.2/lib/rack/adapter/loader.rb:33:in `eval'
	from /usr/local/bundle/gems/thin-1.8.2/lib/rack/adapter/loader.rb:33:in `load'
	from /usr/local/bundle/gems/thin-1.8.2/lib/thin/controllers/controller.rb:182:in `load_rackup_config'
	from /usr/local/bundle/gems/thin-1.8.2/lib/thin/controllers/controller.rb:72:in `start'
	from /usr/local/bundle/gems/thin-1.8.2/lib/thin/runner.rb:203:in `run_command'
	from /usr/local/bundle/gems/thin-1.8.2/lib/thin/runner.rb:159:in `run!'
	from /usr/local/bundle/gems/thin-1.8.2/bin/thin:6:in `<top (required)>'
	from /usr/local/bundle/bin/thin:25:in `load'
	from /usr/local/bundle/bin/thin:25:in `<main>'

Looked into Gemfile.lock:
https://github.com/onetimesecret/onetimesecret/blob/cc0776f6f3578b17fa63a1b3f36ba5eb383ce6f5/Gemfile.lock#L63
You specified ruby:3.3-slim-bookworm as the final base layer of the container, ostruct is updated to 0.6.0 in Ruby 3.3.
https://github.com/onetimesecret/onetimesecret/blob/cc0776f6f3578b17fa63a1b3f36ba5eb383ce6f5/Gemfile.lock#L223-L224
Did you forget updating your development environment? Or you may want to use 3.2 for base layer since the system requirement in README haven't include 3.3 yet.

Hey thanks for making this report.

Did you forget updating your development environment? Or you may want to use 3.2 for base layer since the system requirement in README haven't include 3.3 yet.

Doh, I did mean for the Docker image to go to 3.3. After I noticed I did indeed forget to update my dev environment.

@alemonmk Was there anything particular about how the container is running? I'm having trouble reproducing.
$ docker run -p 3000:3000 -d --name onetimesecret \
      -e REDIS_URL=$REDIS_URL \
      -e COLONEL=$COLONEL \
      -e HOST=$HOST \
      -e SSL=$SSL \
      -e RACK_ENV=$RACK_ENV \
      onetimesecret/onetimesecret:v0.17.1
Unable to find image 'onetimesecret/onetimesecret:v0.17.1' locally
v0.17.1: Pulling from onetimesecret/onetimesecret
Digest: sha256:24e25a7b4f24339d7c836927fac689f7e699051b68639bc43d24ed1716f442e9
Status: Downloaded newer image for onetimesecret/onetimesecret:v0.17.1
869dc04de6f87a9c9d8e8395c2b03fb09309137429c358abf7ca2a836597a8a4

Then the container logs:
2024-09-10 13:18:58 [Tue Sep 10 20:18:58 UTC 2024] INFO: Running entrypoint.sh...
2024-09-10 13:18:58 Skipping bundle install.
I(1725999596): ---  ONETIME cli v0.17.1 ()  ------------------------------
I(1725999596): Sysinfo: ruby-unix-linux-unknown (3.3.5) sync:false
I(1725999596): Config: /app/etc/config
I(1725999596): Redis (7.2.4): redis://host.docker.internal:6379/15
I(1725999596): Familia: 1.0.0-rc7
I(1725999596): Colonels<EMAIL_ADDRESS>I(1725999596): Authentication: {:enabled=>true, :signup=>true, :signin=>true, :autoverify=>false}
I(1725999596): Domains: {:enabled=>false, :default=>nil, :cluster=>{:type=>nil, :api_key=>nil, :cluster_ip=>"<CLUSTER_IP>", :cluster_name=>"<CLUSTER_NAME>", :vhost_target=>"<VHOST_TARGET>"}}
I(1725999596): Loaded locales: en, ar, bg, ca_ES, cn, cs, da_DK, de, el_GR, es, fr, fr_FR, he, hu, it_IT, nl, pl, pt_BR, pt_PT, ru, sl_SI, sv_SE, tr, uk, vi
I(1725999596): Limits: {:create_secret=>1000, :create_account=>10, :update_account=>10, :email_recipient=>50, :send_feedback=>10, :authenticate_session=>5, :homepage=>1000, :dashboard=>1000, :failed_passphrase=>5, :show_metadata=>1000, :show_secret=>1000, :burn_secret=>1000, :destroy_account=>2, :forgot_password_request=>2, :forgot_password_reset=>3, :generate_apikey=>10, :add_domain=>30, :remove_domain=>30, :list_domains=>100, :get_domain=>100, :verify_domain=>25}

Onetime console loaded (additional settings applied: true).
History not saved. Use 'exit' to quit.

onetime> OpenStruct::VERSION
⮑  "0.5.5"
onetime> Bundler::VERSION
⮑  "2.5.18"
onetime>
onetime>
^C
onetime> exit
#

Yeah it seem to run fine when I launch the container manually too.
Normally I run it with Nomad with image hosted on ghcr.io:
    task "onetimesecret" {
      driver = "docker"

      config {
        image        = "ghcr.io/onetimesecret/onetimesecret:v0.17.1"
        args         = ["thin", "-R", "config.ru", "-p", "${NOMAD_PORT_http}", "start"]
        cap_drop     = ["all"]
        ports        = ["http"]
        network_mode = "host"
        mount {
          type     = "bind"
          target   = "/app/etc/config"
          source   = "secrets/config"
          readonly = true
        }
      }

However aside from the crash message above I got nothing.
BTW I don't know what have Familia done but now I need to take out -@dangerous from redis ACL...

Thanks for the info.
I'll need to run some tests to see exactly which @dangerous category commands exactly are being used but it's probably keys or another of the ones that can be very slow.
I'd usually take a closer look and have a more specific answer but we're dealing with a DDoS on onetimesecret.com this week.

The Gemfile.lock is updated to ostruct 0.6.0 in release v0.17.2.

Hey @delano, it seems there's a critical commit that was not included in the latest release tag, without it Github action docker image push keeps failing.

Oh weird that those failures don't show up on the main Actions screen.

Thanks for pinging me. I'll push a fix now. Looks like I also forgot to increment the patch version.

Image push happens with v* tags, rel/0.17 tag has that commit so they are fine.
Tested new container and they are working fine, thank you.


[MOB-21377] added support for debug events generated by external systems

Description
This PR add support of Debug Events triggered by external system. Also, solves issue - MOB-21377

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

The logic here looks good. Just a question on how customers need to use simulate workflow. You're dispatching Optimize Notification event which triggers onPropositionsUpdate API callback to be called. Is our recommendation that customers implement this API for simulate purpose? Would you be able to add a page in the Github docs on what changes they need to make for simulate if they are already using updatePropostions + getPropositions in their app?

As in case of simulate we don't want to corrupt the existing cache, we need to provide an api to customers where they should listen to such type of Debug Events triggered by external system. Currently we have this onPropositionsUpdate api in our code and so i used the same. Do you think should add a new api like 'onSimulate' ? Or is it okay to use onPropositionUpdate ?

Raised another PR with debug event support and separate preview cache and thus closing this one.