Advanced confirming navigation with custom callback function

history.listenBefore assumes only string message or boolean as returning type. It would be handy if we can return a custom function that is passed down to the getUserConfirmation. That would give more control on how confirming dialog can behave:
history.listenBefore(location => {
  if (form.dirty) {
    return (cb) => {
      customDialog.show()
        .onConfirm(() => cb(true))
        .onCancel(() => cb(false))
    }
  } else {
    return true
  }
})

const history = createHistory({
  getUserConfirmation(messageOrFn, cb) {
    switch (typeof messageOrFn) {
      case 'string':
        cb(window.confirm(messageOrFn))
        break
      case 'function':
        const result = messageOrFn(cb)
        if (typeof result.then == 'function') {   // Promise
          result.then(cb).catch((err: Error) => {
            console.error('Error during routing confirmation callback: ', err, err.message)
            cb(false)
          })
        } else if (typeof result == 'boolean') {
          cb(result)
        } // else - cb should be called from inside messageOrFunction
        break;
    }
  }
})

In conjunction with react-router's routerWillLeave it should be very useful.

That's not true w/r/t the return type – check the signature on listenBefore hooks. Note this isn't recommended for confirming navigation, though, and is intentionally not exposed within the React Router API.

Can't understand what exactly is not true? Checking of string type is done right here: https://github.com/mjackson/history/blob/dbd56c44976960ba2361ba39a0f57687e3d3ea0a/modules/createHistory.js#L74
If returning type is not string getUserConfirmation is not called. I've checked this behaviour. Function is accepted, when I modify the condition this way:
if (getUserConfirmation && (typeof message === 'string' || typeof message === 'function')) {
  getUserConfirmation(message, (ok) => callback(ok !== false))
}

If it is not recommended than what is the recommended way to show custom confirmation dialogs for different cases, taking into account that getUserConfirmation is done once during react-router setup? For example in some cases I want to give three choises for the user instead of two: "Leave without saving", "Save and continue", "Cancel".
Why do we need such limitations?


Slip132: make x/tpub/prv classified as hash-class keys and add tests

Some tests for the slip132 lib to increase code coverage https://github.com/BP-WG/descriptor-wallet/issues/11.
I changed from_derivation_path and to_derivation_path because they didn't work with testnet paths.

Codecov Report

Merging #39 (6db9eec) into master (b1566e2) will increase coverage by 9.8%.
The diff coverage is 99.4%.

@@           Coverage Diff            @@
##           master     #39     +/-   ##
========================================
+ Coverage    31.1%   40.9%   +9.8%
========================================
  Files          45      45
  Lines        4745    5238    +493
========================================
+ Hits         1478    2144    +666
+ Misses       3267    3094    -173

Impacted Files
Coverage Δ

hd/src/standards.rs
0.0% <0.0%> (ø)

slip132/src/lib.rs
93.4% <99.8%> (+76.6%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1566e2...6db9eec. Read the comment docs.

I have to release a new 0.8 version today, so I created a PR with a non-breaking subset of your code #41. I am going to merge it - and we can continue discussion whether it is desirable to classify ordinary xpubs/tpubs as belonging to a specific Slip class here and than, if we decide to do so, merge that from this PR into v0.9

v0.10 is a new breaking version I am working on these days, so the parts of this PR which haven't got into #41 can be re-based onto the current master. @kaiwolfram are you still interested in working on this PR or should I do that by myself?


"Doljești", "Buhonca", "Buruienești" and "Rotunda" are listed in the drop-down menu

Description:
"Doljești", "Buhonca", "Buruienești" and "Rotunda" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Doljești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Doljești, NEAMȚ (Doljești)" and "Comuna Doljești, NEAMȚ".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Buhonca" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Buhonca, NEAMȚ (Doljești)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Buruienești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Buruienești, NEAMȚ (Doljești)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Type "Rotunda" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Rotunda, NEAMȚ (Doljești)".


Add create command & generate templates

Add create command

When I run command halva-cli create test Token, results in the following:
halva-cli create test Token                ✔  11801  09:08:50

Loaded templates: /Users/by-keks/workspace/projects/substrate/halva/build/main/src/templates
Error: I can't find action 'new' for generator 'test'.

      You can try:
      1. 'hygen init self' to initialize your project, and
      2. 'hygen generator new --name test' to build the generator you wanted.

      Check out the quickstart for more: http://www.hygen.io/quick-start

Hygen v6.0.4

Available actions:
(node:99189) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, scandir '/Users/by-keks/workspace/projects/substrate/halva/build/main/src/templates'
    at Object.readdirSync (fs.js:955:3)
    at availableActions (/Users/by-keks/workspace/projects/substrate/halva/node_modules/hygen/dist/help.js:12:10)
    at Object.printHelp (/Users/by-keks/workspace/projects/substrate/halva/node_modules/hygen/dist/help.js:44:20)
    at /Users/by-keks/workspace/projects/substrate/halva/node_modules/hygen/dist/index.js:60:20
    at Generator.throw (<anonymous>)
    at rejected (/Users/by-keks/workspace/projects/substrate/halva/node_modules/hygen/dist/index.js:25:65)
(node:99189) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:99189) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.


build(e2e): cypress test coverage

We've switched to using UI assets from the ui repository instead of using a duplicate copy of the UI source in the influxdb repo, see #21090. As such, all of the testing e2e testing setup is handled in the ui repo, which has undergone significant development since this PR was opened. So I am closing this PR out!


Build STRIPS-level PDDL blocks with good usability

STRIPS is a subset of classical PDDL, the goal is to create blocks which correspond to all the construct of this language.
The new block definition can live in the "/blocks" folder.

done


CRAN 2.0.2

Fix all the issues and submit fastai 2.1.5.
2.1.8 has a lot of bugs:

medical, read dcm
shap, fastinference
summary of the model

Done


Open-source live editor?

Hey there!
This is an awesome project and I'd love to contribute to/self-host the live editor. Would it be possible to open-source the code for that?
Thanks :)
Fouad

Hey! This is already a work in progress, and it will be open sourced soon, after implementing the basics.
Thanks for the input, we'll be happy to have your contribution!

+1

Hi guys, we just released a first version of the desktop mjml editor: https://github.com/mjmlio/mjml-app
Still a lot of work to do, it has actually those features:

create template from scratch / from a preset
edit with live reloading
preview in desktop + mobile
send a test email (with Mailjet API keys)
create a gist from template

Feedbacks are welcome :p

nice

Hi there! Any news about live editor?

We're not confident about open-source the live editor due to the infrastructure. We've open-sourced the desktop app which can be used as a base for a web editor.

ok, thank you

For those looking for a wysiwyg live editor, GrapesJS might be a good alternative. https://grapesjs.com/demo-mjml.html


[core-client] Fix issue with Storage bearer challenges

Packages impacted by this PR
@azure/core-client
Describe the problem that is addressed by this PR
When this logic was ported from a Storage-specific policy, it referenced a field in the challenge called resource_uri instead of the actual value which is resource_id.
You can see the working value in the storage/stable branch: https://github.com/Azure/azure-sdk-for-js/blob/f7fca7e84dfd0aced888ea5c0d109468a1e2a3a6/sdk/storage/storage-blob/src/policies/StorageBearerTokenChallengeAuthenticationPolicy.ts#L252
I suspect the reason for the confusion is because the documentation page that describes this feature incorrectly gives an example that has resource_uri even though the parameter description lists resource_id: https://learn.microsoft.com/en-us/rest/api/storageservices/authorize-with-azure-active-directory#sample-response-to-bearer-challenge
This wasn't caught previously as Storage had not migrated to CoreV2 and exercised this codepath.

API change check
API changes are not detected in this pull request.


Feature/sthakre/8470

Improve hazard type switch - impl

@SwatiTh I've checked this out locally, but it seems the disaster-tabs are still below each other, while I believe the figma-file @gulfaraz was referring to earlier, has them side-by-side? Can you link me to the figma-file you were provided?


update curation properties to match api

Noticed when I tried to create curations that the curation would be created but the promoted documents would always be empty. Come to find the Curation schema class defines the wrong properties. Updated the Elastic\EnterpriseSearch\AppSearch\Schema\Curation class to match the curation api.

Just signed the Contributor Agreement.

i was using 8.1 for both when I posted this. Just upgraded App Search to 8.2. Creating curations work still when using promoted instead of promotedDocIds.

We are still working to release enterprise-search-php v8. I'll update you soon. The latest stable release is 7.17.0.

This is still an issue in 7.17.0.
Property in the curation schema class.
https://github.com/elastic/enterprise-search-php/blob/master/src/AppSearch/Schema/Curation.php#L28
Api specifications in 7.17.0 for creating a curations.
https://www.elastic.co/guide/en/app-search/7.17/curations.html#curations-api-post-engine-curation-request-body
Dynamically using promoted instead of promotedDocIds works but I think for clarity it would be helpful to update.

@myleshyson ok, thanks for the information. Since the AppSearch\Schema\Curation file is generated from the API spec I need to understand and fix the issue in the code generator. I'll update you soon. Thanks again!

@myleshyson I just updated 7.17 branch with the fix for the API. This includes also other fixes in the client generator, like the usage of AdaptiveRelevanceSuggestionBase schema in Curation::$suggestion. Can you check? Thanks!

Hey @ezimuel yep it's looking good and working as expected. Thanks!

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@myleshyson thanks, I just released v7.17.1 with the fix.


[1.21.1 NeoForge] Accessories does not respect the #minecraft:freeze_immune_wearables tag

#minecraft:freeze_immune_wearables is a tag which determines whether an item should grant immunity to freezing when equipped. In vanilla, all pieces of leather armor use this tag. When an accessory has this tag, however, it does not grant immunity to freezing when equipped. In fact, it appears that there is no way (without mixins) to make an accessory grant immunity to freezing in powder snow (there is a method to allow standing on it, but it does not appear to grant immunity to freezing). I believe this is a bug because curios respected this tag in previous versions.

Pushed version 1.2.6 for 1.21.4 that add support for such


Use ShareLink for Recovery Phrase instead of copy/paste

Came up in testing (thanks @jsantell!) that it would be nice to send the recovery phrase to another app without leaving Subconscious.

We can changeout the Button for a ShareLink, there are examples of this pattern in the profile meta sheet for sharing the DID.

@gordonbrander it supports it!


redmine: add missing lib.mdDoc

Description of changes
Due to my mistake, after merging #171930 ; the new options did not have the right mdDoc marker, breaking NixOS manual builds.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

cc @winterqt — sorry and thank for the heads up.

nixos/redmine: ...

Done!


Update dashboard

Only access log is shown, no ModSecurity alerts.
Signed-off-by: Simon Rüegg<EMAIL_ADDRESS>

For what I understand you want the unique ID and the inbound anomaly score, instead of the alert message and its URI.  LGTM!


Update haml_lint & rubocop

Remove unused spec that was causing a false positive Rubocop offense

Coverage remained the same at 86.158% when pulling ce2d12993ac7047725778b10282f43bc8d3a86e6 on update-rubocop into 409890e2503c7498e2a54f59f9a479b1405f86bc on master.


Make App.all public

We'd like to do what #21 suggests directly in our app by simply checking which apps are installed.
Unfortunately the following won't work because .all isn't public:
let apps = App.all.filter(Karte.isInstalled)
if apps.count == 1 { … }

Btw, writing your own .all isn't event needed. You can simply use the CaseIterable protocol on the enum.

Ah, good point 👍 CaseIterable wasn't around yet when first writing this code.

fixed with 8cded8997540e9607ef526dfaeb35055a96494e8


Spaceship frequently throws UnauthorizedAccessError

I use Spaceship to programatically add external Testflight testers. But frequently I encounter Spaceship::Client::UnauthorizedAccessError, seemingly randomly. At one moment, adding a tester works fine, another moment it stops working (without any changes to code/iTunes connect accounts). Whenever Rollbar reports one of this issues, I can't reproduce the issue if I run this code manually through the Rails console. However, once I execute this code from the long running sidekiq process, I can reproduce the issue straight away. If I restart the Sidekiq process, the issue doesn't reappear for a while.
It seems some kind of session is timed out and not refreshed. Possibly related issue: https://github.com/fastlane/boarding/issues/136
Complete output when running fastlane, including the stack trace and command used
1 File "/app/vendor/bundle/ruby/2.4.0/gems/fastlane-2.54.2/spaceship/lib/spaceship/client.rb" line 685 in block in send_request
2 File "/app/vendor/bundle/ruby/2.4.0/gems/fastlane-2.54.2/spaceship/lib/spaceship/client.rb" line 520 in with_retry
3 File "/app/vendor/bundle/ruby/2.4.0/gems/fastlane-2.54.2/spaceship/lib/spaceship/client.rb" line 679 in send_request
4 File "/app/vendor/bundle/ruby/2.4.0/gems/fastlane-2.54.2/spaceship/lib/spaceship/client.rb" line 568 in request
5 File "/app/vendor/bundle/ruby/2.4.0/gems/fastlane-2.54.2/spaceship/lib/spaceship/test_flight/client.rb" line 133 in create_app_level_tester
6 File "/app/vendor/bundle/ruby/2.4.0/gems/fastlane-2.54.2/spaceship/lib/spaceship/test_flight/tester.rb" line 47 in create_app_level_tester
7 File "/app/app/jobs/testflight_external_tester_adder_job.rb", line 11 in perform

Environment
See this gist.
The code I use:
  spaceship = Spaceship::Tunes.login(Rails.application.secrets.itunes_connect_api[:username], Rails.application.secrets.itunes_connect_api[:password])
    spaceship.select_team

    app = Spaceship::Tunes::Application.find(Rails.application.config.itunes_connect_app_id)
    tester = Spaceship::TestFlight::Tester.create_app_level_tester(app_id: app.apple_id,
                                                                   first_name: customer.first_name,
                                                                   last_name: customer.last_name,
                                                                   email: customer.email)

    tester = Spaceship::Tunes::Tester::External.find_by_app(app.apple_id, customer.email)
    Spaceship::TestFlight::Group.add_tester_to_groups!(tester: tester, app: app, groups: %w[External])

    Rails.logger.info("Added #{customer.email} to TestFlight")

Hey @edwardmp - I just have a question that might help clarify something for me... Are you adding testers in a one-off manner? Or are testers being added after an IPA upload or some other longer-running action? Thanks! 🐙

One-off, that code above is what I literally run in an ActiveJob

Hmmm - thanks for the quick response @edwardmp! Sorry to keep grilling you, but I have one more question...  Also, is this happening in CI or on your local machine? I'm not sure I know what an ActiveJob is. Thanks again! 👍

@ohayon
Yes, the error will keep reappearing until (seemingly) I kill/restart the master process running this.
This happens on my Heroku dyno.
ActiveJob is just a Rails abstraction for an asynchronous task, not really relevant for this discussion.

Ohhh, interesting! Thats pretty cool that you have this running in Heroku! Aside from this issue, I would love to hear more about that.
Can you share the logs where you are seeing the UnauthorizedAccessError? Our could should be retrying the request a few times, but its possible something is wrong in there.

@ohayon what kind of logging do you wish to see aside from a stack trace?
Regarding our use case: we currently have an app we wish to test in a relatively small group (not public), but still large enough (few thousand testers) that we do not wish to add people manually to iTunes Connect. We already have all the needed data, that's why every time someone signs up for the pilot of our service I try to add it to TestFlight through Spaceship. Hope we can find out what happens here because currently it fails more often than it works which is not ideal for our process.

Very often those error will also happen due to server errors on Apple's side 😢

@KrauseFx that might explain some of it but not all imho. Often Rollbar would notify me of an UnauthorizedAccessError, I would then spin up a new heroku dyno (heroku run rails c) and run this job manually and it would work fine. Does seem this has to do something with some cookie expiring.

Unfortunately we had to stop using Spaceshipf for this use case since it didn't appear to work in the majority of the cases leading to inconsistency in our process.


raidboss: KR fix

e11s
only that line was translated 'lightning(번개)' into 'fire(화염)'

bozjan
typo

That was my fault :rofl:


feat: drain pod before delete node

What type of PR is this?

/kind feature
What does this PR do?

Which issue(s) does this PR fix?

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

/lgtm


Add support for ARM

Switch to multi-architecture container images
Add support for ARM architectures

See https://github.com/kubernetes-sigs/kubebuilder/issues/966 for inspiration.
Will resolve https://github.com/linkerd/linkerd2/pull/6378.

+1 on this


Control center not updated when navigating the playlist while playback is paused

As a user I might sometimes navigate the playlist when playback paused. I want the behavior to be just right.
Acceptance criteria

The behavior has been decided within the team.

Hint

Spotify resumes playback but Apple Music doesn't.

Tasks

Discuss how ExoPlayer behaves.
Discuss what should happen in this case (currently: control center is not updated).
Write decisions down.
Check if we can fix the current behavior on our side.

Has been fixed in #206. The issue was that we were unnecessarily removing and adding remote command backs with each metadata update. When transitioning between items this was preventing the control center from updating correctly with metadata associated with the new item.


Optimize API Calls by Enabling Conditional Request Based on User Setting

User description
In the current implementation,  we are always asking for improved code. But we may not be interested in the actual code suggestion rather just the text suggestion. So I added a new option to disable getting improved code.

Type
Enhancement

Description

This PR optimizes the API calls by enabling conditional requests based on user settings.
The 'existing code' and 'improved code' are now included in the PR code suggestions and YAML keys only if the user has enabled this feature.
This change reduces unnecessary API calls, improves performance, and reduces token usage.

Changes walkthrough
Relevant filesConfiguration changes

utils.pyConditional Inclusion of 'existing code' and 'improved code' in YAML
Keys

pr_agent/algo/utils.py

Modified the keys list in try_fix_yaml function to conditionally   include 'existing code:' and 'improved code:' based on the user   settings.

+6/-2

pr_code_suggestions_prompts.tomlConditional Inclusion of Improved Code in PR Code Suggestions Prompts

pr_agent/settings/pr_code_suggestions_prompts.toml

Updated the CodeSuggestion class to conditionally include   'existing_code' and 'improved_code' based on the user settings.

+4/-0

Enhancement

pr_code_suggestions.pyConditional Inclusion of Improved Code in PR Code Suggestions

pr_agent/tools/pr_code_suggestions.py

Added a new key 'include_improved_code' to the settings dictionary.

Modified _prepare_pr_code_suggestions and  push_inline_code_suggestions functions to conditionally include   'existing_code' and 'improved_code' based on the user settings.

+11/-7

 ✨ Usage guide:
Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.
When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:
/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:
[pr_description]
some_config1=...
some_config2=...

  Enabling\disabling automation

When you first install the app, the default mode for the describe tool is:

pr_commands = ["/describe --pr_description.add_original_user_description=true"
                         "--pr_description.keep_original_user_title=true", ...]

meaning the describe tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.

Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:

pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

type: the PR type.
summary: the PR summary.
walkthrough: the PR walkthrough.

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

  Custom labels
The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].
If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

Main topic:performance - pr_agent:The main topic of this PR is performance
New endpoint - pr_agent:A new endpoint was added in this PR
SQL query - pr_agent:A new SQL query was added in this PR
Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

  Utilizing extra instructions
The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.
Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
[pr_description]
extra_instructions="""
- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

  More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs 💎: Generate docstring for new components introduced in the PR.
/generate_labels 💎: Generate labels for the PR based on the PR's contents.
/analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

I removed this option, which existed, yesterday.
I don't see the use case.
You don't want to see the suggestion, don't open the collapsible.
There are also mistakes and inconsistencies in the implementation

Through extensive use of GPT-4 for my codebase, I have discovered that the suggested improvements are incorrect far more frequently than one might expect, even when the textual suggestions seem valid. Given this reality, it made little sense to waste time and resources reviewing incorrect code changes. To streamline the process and minimize unnecessary costs, I extended the existing include_improved_code option to exclude the request for improved code altogether.

@CodiumAI-Agent /review

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/e409ec76d671babb367af00604ae35fb64eca62e

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/e409ec76d671babb367af00604ae35fb64eca62e

@SubodhDahal

the 'review' feature already provides suggestions without "code". you can use it
the implementation you provided is wrong. The order of the 'ifs' is incorrect and inconsistent. print the actual prompt that is generated and you will see.
I don't like to add flags if I don't think it will be applicable to many people, and not specific ones. especially in a crucial place like the prompt.

I thank for for the contribution, but I am not going to merge it. If you are kin about this specific implementation, you can use it in your local hosting
thank you

I understand @mrT23. I am going to close the MR.


New Structure & Contents

new stucture and contents for new components of the blindnet devkit
see https://github.com/blindnet-io/blindnet.dev/issues/26#issuecomment-1191570419

See https://next.blindet.dev for review.
To suggest a change, click the "edit this page" link at the bottom, replace /edit/main/ with /edit/develop/ in the URL (e.g. https://github.com/blindnet-io/blindnet.dev/edit/develop/docs/index.mdx :arrow_right: https://github.com/blindnet-io/blindnet.dev/edit/develop/docs/index.mdx, and submit a PR to the develop branch... or just add a comment here :wink:

warning
This update will be discussed on Friday, September 9th during the Tech Talk and the following dedicated meeting with @Vuk-BN, and then directly merged (i.e. published to production) except if it received any formal objection.
Please eep your review and feedback short and efficient.
Another dedicated PR will be created afterwards for more in-depth review and feedback (this is why I created a reviewed branch and added versioning FYI :drum:).

I applied all suggestions and fixed the remaining ones, then squashed the commits in 212accb.
Thx @m4rk055 & @jboileau99

Clarifications added by @Vuk-BN and @milstan on what they expect for next week:

top priority for @milstan: add "glue" content everywhere (i.e. everything I can write without help from engineering: explain what a component does, why you should use it, etc. ; basically, answer the 5W questions in every section introduction)
top priority for @Vuk-BN: improve/fix the link between blindnet.io / marketing material and blindnet.dev / DevRel material (ensure we always use the same vocabulary for everything and deliver the same ideas without contradiction or never leads to contradictory interpretations)
lower priority (still high): make clear what developers can configure when using PC4W - to be linked with the storybook documentation @jboileau99 is working on, but still needs to be globally clarified in blindnet.dev itself
write content about PRIV / translate PRIV into documentation - to be first addressed when updating the PCE-configuration section in order to see if @milstan and I agree on how PRIV should be addressed in the docs

the configuration API is done from a developer perspective (developed and can be tested locally), but not from a DevRel one: as we don't have authentication yet, 1 PCE = 1 APP, so all people calling the configuration API would change the configuration for everyone else too => this can't be integrated into a ready to use tutorial/demo app
however, the PCE might be ready for 3rd party dev to run it locally - so I might still add this step to the tutorial

home's first section seems too buzzworthy :arrow_right: split bullet point / add more structure
fix menu in demo (overlapping)
make menu items in demo more straightforward (e.g. "make a privacy request" instead of "privacy")

Now merging this PR for immediate release on blindnet.dev discuted.
Further review by @blindnet-io/engineering will be conducted later on via .


Git Auth Problem

I recently had to change some configurations in my KubOS kernel and in the process of building it, I got ERROR 404: NOT FOUND when buidroot tried to compile and build kubos-1.20.0.tar.gz
It also threw a warning saying:
The unauthenticated git protocol running on port 9418  is no longer supported
I struggle for a while with this but it turns out it was due to the fact that buildroot on my VM was using git:// rather than https://
Issuing the following command seems to have fixed the issue but I imagine there is a better way to update this repo to prevent similar problems...
git config --global url."https://".insteadOf git://

Ah yes, it seems like git has changed their url schemes for git urls in the name of security
https://github.blog/2021-09-01-improving-git-protocol-security-github/
Other members of the discord have also had success authenticating over an ssh url (git@github.com:kubos/kubos.git) but that requires some setup if you havent used ssh auth before, so id agree that https is a better way to go.
Im not sure when ill have time to fix this, but ill review a pull request if you  have time to make one

The ssh authentication didn't work in the end on my side. (At least changing it in the kubos.mk).
I'm keen to find out why git config --global url."https://.insteadOf git:// works, but substituting the hardcoded link containing the git:// doesn't

AFAIK the git config --global url."https://".insteadOf git:// will swap out the url on the fly. Maybe your previous attempt was still cached somehow by buildroot and so maybe there was a local repo that still had a remote repo configured with a different URL?

Yeah probably, although the call changes to https:// when modified in the code, thus my confusion.
But I also saw buildroot loads multiple other dependencies with git:// calls. I'm planning to try out buildroot-2022.02.1 tomorrow, which should not use those git:// dependencies anymore

I'm planning to try out buildroot-2022.02.1 tomorrow, which should not use those git:// dependencies anymore

isnt that part of the kubos config and not buildroot itself? either way, it would be awesome to know how it goes with the new buildroot. i think i tried to use a newer-than-2019 one at some point and i guess some of the flags got deprecated and i didnt know what i was doing and sorta gave up

Partly, but according to the buildroot changelog, they only got rid of git:// dependencies with the 2022.02.1 version. So there's heaps of other links buildroot 2019 tries to call during the build process, that won't work unless you do git config --global url."https://".insteadOf git://

Buildroot uses wget on https addresses and this is probably why manually renaming git:// to https:// in kubos.mk is not able to locate the git branch. So you may want to use the git command  git config --global url."https://".insteadOf git:// to tell BR to identify it as a github branch rather than a download URL. Below ref is from the BR manual:
Source fetching tools:
In the official tree, most of the package sources are retrieved using wget from ftp, http or https locations. A few packages are only available through a version control system. Moreover, Buildroot is capable of downloading sources via other tools, like rsync or scp (refer to Chapter 20, Download infrastructure for more details).

wow that actually makes a ton of sense for why this is the behavior that there is.
Based on my limited experience with buildroot, I feel like I remember seeing some kind of flag or other variable to explicitly tell buildroot that this is a git repository, overriding the default handling for this url so we can make it https:// permanently and have buildroot still treat it as a git url (passing it to git) instead of assuming wget.
unfortunately the "refer to chapter 20" part of the docs that you linked appear to simply say TODO :/

These chapters might be relevant:

These chapters might be relevant:
Github Download
Generic Package Reference

ah it looks like the variable that may be useful is LIBFOO_SITE_METHOD (presumably replacing the name LIBFOO with whatever matches the place the git url is currently set. Would be interesting to see what this does with a value of git and a url that doesnt start with git:// per the instructions


Will it run on Mac using steamCMD and wine - uses a legitimate file of Among Us all contained on my computer

Sorry if this is the wrong place to ask, new to using GitHub

Just try it ! If it doesn't work, you might want to use a Windows VM. I recommend Parallels Desktop (which I use and works flawlessly with Among Us) or VMWare (which I heard great things of).

Gave it a try and it did not work haha, I've setup VMware and am just
waiting till my friends come on so i can see if it works. Thanks for your
support
On Sat, 7 Nov 2020 at 10:28, incognitomode<EMAIL_ADDRESS>wrote:

Just try it ! If it doesn't work, you might want to use a Windows VM. I
recommend Parallels Desktop (which I use and works flawlessly with Among
Us) or VMWare (which I heard great things of).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/denverquane/amonguscapture/issues/81#issuecomment-723428284,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARVEL44MPH2HVCZYMRTTYT3SOUOM5ANCNFSM4TNCPQSA
.

I had made an effort to try and run the capture on Wine before I started development on amonguscapture-gtk, and found that running it was extremely unreliable.
In order to get the capture to run, you need to install the .NET Core 3.1 runtime in your prefix. This should be all you need, but I started running into issues shortly after installation.
DirectX 11 should be supported on MacOS as of Wine 3.0, but YMMV under MacOS. You may need to try using MoltanVK to get it to work, with no guarantees.
If you happen to be able to get the game running reliably, it may be possible to write a ProcessMemoryMacos implementation, though I don't have access to a system running MacOS at this time.


Trouble running pepnovo using example script

Hi there, I just tried to run the example script for pepnovo searching and it crashed:
profile  ] Initializing profile LTQ XL low res
[ profile  ] 4 parameters have been updated
[  prprun  ] Preparing unode run for engine mzml2mgf_2_0_0 on file(s) ../example_data/BSA_simple_de_novo_search/BSA1.mzML
[ set_ios  ] Setting self.io["input"]
[   Info   ] Generated engine mzml2mgf_2_0_0 output file name: /fs/local/projects/ursgal/example_data/BSA_simple_de_novo_search/BSA1.mgf
[   Info   ] Skipping convert_to_mgf_and_update_rt_lookup() on file BSA1.mzML since it was previously executed with the same input file(s) and parameters.
[   Info   ] To re-run, use convert_to_mgf_and_update_rt_lookup( force=True )
[ dmpjson  ] Preparing json dump
[ dmpjson  ] Json dumped. Path: /fs/local/projects/ursgal/example_data/BSA_simple_de_novo_search/BSA1.mgf.u.json
[ profile  ] Initializing profile LTQ XL low res
[ profile  ] 4 parameters have been updated
[  prprun  ] Preparing unode run for engine pepnovo_3_1 on file(s) /fs/local/projects/ursgal/example_data/BSA_simple_de_novo_search/BSA1.mgf
[ set_ios  ] Setting self.io["input"]
[   Info   ] Generated engine pepnovo_3_1 output file name: /fs/local/projects/ursgal/example_data/BSA_simple_de_novo_search/pepnovo_3_1/BSA1_pepnovo_3_1.csv
[   Info   ] search_mgf() scheduled on input file BSA1.mgf
[   Info   ] Reason for run: parameter "precursor_mass_tolerance_plus" was not found in previous output params....
& Previous run was not completed, status launching
[ dmpjson  ] Preparing json dump
[ dmpjson  ] Json dumped. Path: /fs/local/projects/ursgal/example_data/BSA_simple_de_novo_search/pepnovo_3_1/BSA1_pepnovo_3_1.csv.u.json
    -\-     pepnovo_3_1 run initialized with BSA1.mgf (Wed Oct  3 14:43:34 2018)     -/-

[   run    ] Preparing engine
[   run    ] Starting engine
[ Citation ]
[  Please  ]
[  cite:   ] Ari M. Frank, Mikhail M. Savitski, Michael L. Nielsen, Roman A. Zubarev, and Pavel A. Pevzner (2007) De Novo Peptide Sequencing and Identification with Precision Mass Spectrometry, J. Proteome Res. 6:114-123.
[  -----   ]
[ Citation ]
[ PREFLGHT ] Executing preflight sequence ...
        [ WARNING ] precursor_mass_tolerance_plus and precursor_mass_tolerance_minus
        [ WARNING ] need to be combined for pyQms (use of symmetric tolerance window).
        [ WARNING ] The arithmetic mean is used.

[ prefligh ] Execution time 0.000 seconds
Traceback (most recent call last):
File "simple_de_novo_search.py", line 81, in
main()
File "simple_de_novo_search.py", line 69, in main
force=False
File "/fs/local/projects/ursgal/ursgal_env/lib/python3.6/site-packages/ursgal/ucontroller.py", line 1856, in search
force      = force,
File "/fs/local/projects/ursgal/ursgal_env/lib/python3.6/site-packages/ursgal/ucontroller.py", line 1766, in search_mgf
force, engine_name, answer
File "/fs/local/projects/ursgal/ursgal_env/lib/python3.6/site-packages/ursgal/ucontroller.py", line 2186, in run_unode_if_required
json_path = json_path,
File "/fs/local/projects/ursgal/ursgal_env/lib/python3.6/site-packages/ursgal/unode.py", line 1387, in run
report['execution'] = self._execute()
File "/fs/local/projects/ursgal/ursgal_env/lib/python3.6/site-packages/ursgal/wrappers/pepnovo_3_1.py", line 249, in _execute
'''.format( self.engine, os.path.relpath(self.exe), self.execute_return_code)
AssertionError:
pepnovo_3_1 crashed!
The executable
../ursgal_env/lib/python3.6/site-packages/ursgal/resources/linux/64bit/pepnovo_3_1/PepNovo_bin
terminated with Error code 1 .
Inspect the printouts above for possible causes and verify that all input files are valid.
Not sure what I did wrong. I adapted the example_script  "simple_de_novo_search.py" by commenting out novor but that was all.
If I try running the PepNovo from the command line it also fails :
Initializing models (this might take a few seconds)...
Warning: no peptide composition assigner was found (e.g., LTQ_COMP/IT_TRYP)!
This may cause problems when trying to run PepNovo!
Done.
Fragment tolerance : 0.5000
PM tolernace       : 2.5000
PTMs considered    : C+57

0 2442 BSA1.2442.2442.2Error: using an uninitialized peptide composition asssigner!
You might need to use an existing composition assigner.
Try adding the line: "#COMP_ASSIGNER  LTQ_COMP/IT_TRYP" to the main model file (model_name.txt)

I have never tried to run a de novo search this way before so apologies if I am doing something really stoopid.
Toby

Hi Toby,
quick question before looking closer into it: which OS are you using? I remember pepnovo not working on all systems ...

ah sorry for forgetting essential info. Linux Redhat 7, 64 bit

Alright, I tested it on CentOS 7.4 and it seems to work (except a small bug in the postflight/unify_csv that I fixed with #85).
Unfortunately, I don't have a Redhat 7 system to test it on.
One suggestion would be to download the original (http://proteomics.ucsd.edu/Software/PepNovo/) on your system and follow the instructions for installation. Might be a compiling issue.
Otherwise, I would suggest to use Novor - it's apparently faster and better anyway ;)

Yeah, I recompiled it locally and it now works so probably a Red Hat 7 issue.


Query: How to compile Netopeer2 with custom sysrepo.

Hi
I have added some changes in sysrepo client lib for my need. For testing, I'm using sysrepod  binary from build/ directory.
Now I want to compile and test netopeer2 using the above changes in client library.
What flags do I need to set for netopeer2 to compile with my sysrepo changes, not the installed sysrepo?
Thanks
Govind.

Hi,
obviously, the easiest way would be to install your modified sysrepo. But if you insist on having one sysrepo installed and compiling with another, you should be able to do that by defining SYSREPO_LIBRARIES and SYSREPO_INCLUDE_DIRS.
Regards,
Michal

Well It didn't worked, tried below ways.

export both Variables explicitly before cmake ...
also tried cmake -DSYSREPO_LIBRARIES=<libsysrepo.so directory Path> -DSYSREPO_INCLUDE_DIRS=<sysrepo/build/src/inc/> ..

both ways cmake finds sysrepo in the installed path.
Can you please point me in the correct direction? I am very new to cmake.

Hi,
okay, it seems to work for me when I use
cmake -DSYSREPO_INCLUDE_DIR=<path> -DSYSREPO_LIBRARY=<path> ..

I then see this path in CMake output.
Regards,
Michal


Use extensions from configuration for react native module resolution

Summary
Currently, react native files with extensions other than .js aren't imported when running jest in a react native environment. This is because of a hardcoded .js in the jest resolver. It should use the configuration's moduleFileExtensions.
Test plan
For a jest config of
module.exports = {
    globals: {
        "ts-jest": {
            tsConfigFile: "tsconfig.test.json",
        },
    },

    preset: "react-native",

    moduleFileExtensions: [
        "js",
        "jsx",
        "ts",
        "tsx",
    ],
};

a test of
import testEnvironment from "../__mocks__/testImport";

describe("Native test environment", () => {
    it("finds the native version of the dependency", () => {
        expect(testEnvironment).toBe("native");
    });
});

__mocks__/testImport
export default "web";

__mocks__/testImport.native
export default "native";

Without this PR (on master)
$ jest ./src/__tests__/nativeTestEnvironment.js
 FAIL  src/__tests__/nativeTestEnvironment.js
  Native test environment
    ✕ finds the native version of the dependency (7ms)

  ● Native test environment › finds the native version of the dependency

    expect(received).toBe(expected)

    Expected value to be (using ===):
      "native"
    Received:
      "web"

      at Object.<anonymous> (src/__tests__/nativeTestEnvironment.js:9:38)
      at tryCallTwo (node_modules/promise/lib/core.js:45:5)
      at doResolve (node_modules/promise/lib/core.js:200:13)
      at new Promise (node_modules/promise/lib/core.js:66:3)
      at tryCallOne (node_modules/promise/lib/core.js:37:12)
      at node_modules/promise/lib/core.js:123:15

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Snapshots:   0 total
Time:        1.972s, estimated 2s
Ran all test suites matching /.\/src\/__tests__\/nativeTestEnvironment.js/i.

With this PR's code
$ jest ./src/__tests__/nativeTestEnvironment.js
 PASS  src/__tests__/nativeTestEnvironment.js
  Native test environment
    ✓ finds the native version of the dependency (3ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        1.445s, estimated 2s
Ran all test suites matching /.\/src\/__tests__\/nativeTestEnvironment.js/i.

Codecov Report

Merging #4905 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4905      +/-   ##
==========================================
+ Coverage   59.75%   59.77%   +0.01%
==========================================
  Files         195      195
  Lines        6533     6536       +3
  Branches        4        3       -1
==========================================
+ Hits         3904     3907       +3
  Misses       2629     2629

Impacted Files
Coverage Δ

packages/jest-resolve/src/index.js
97.41% <100%> (+0.06%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38c2cf7...46bf52c. Read the comment docs.

Please add a test like @SimenB and @thymikee requested. Also, can you point me to the place in https://github.com/facebook/metro-bundler where the behavior matches what you are doing in this PR? Also cc @rafeca since we talked about this yesterday.

Added tests and updated code style, thanks for the feedback.
@cpojer I haven't looked at the source of metro-bundler before, but I think the matching behavior is in the dependency graph module resolution at https://github.com/facebook/metro-bundler/blob/c6b0134398bdd4ded4a7efbb08e44bcd4bf10b7a/packages/metro-bundler/src/node-haste/DependencyGraph/ModuleResolution.js#L440-L465

Thanks for making the changes to Jest. We are currently looking into plucking jest-resolve into Metro so we can get rid of the resolution logic there. Aligning the two is critical to make this work.


Feature/161

I think this can be closed, as we have fixed it in some other PR - at least the issue is closed.

What is with #151 ?

#157 was tested and closed now


Add Canadian Holidays

Here are the federal holidays for Canada.
List of Canadian Holidays

This is the official list of federal public holidays in Canada. However, these only apply to federal employees.
We should add support province specific as some provinces ignore some and rename others.
We should probably also translate these into Canadian French.
List of holidays by province.

Alberta (AB)
British Columbia (BC)
Manitoba (MB)
New Brunswick (NB)
Newfoundland and Labrador (NL)
Nova Scotia (NS)
Northwest Territories (NT)
Nunavut (NU)
Ontario (ON)
Prince Edward Island (PE)
Quebec (QC)
Yukon (YT)

Could you rebase your branch on our main branch? That way I can run the tests


Editor configuration does not works for bracket pair colorization

Both of two settings kinds didn't works:
'bracketPairColorization.enabled': 'false',
bracketPairColorization: {
	enabled: false
},

@kaisalmen , i guess the reason is in @codingame/monaco-vscode-configuration-service-override.
On monaco playground this option is working well

What are you doing with that settings? how do you provide them?

i am use import { createConfiguredEditor } from 'vscode/monaco'; and pass the settings though the createConfiguredEditor

bracketPairColorization is not part of the settings used by the editor itself (even if in the editor namespace`)
In monaco, there is a "hack" that makes global settings provided to an editor persisted globally, that hack is disabled when using monaco-vscode-api configuration service override. Instead, you can use the updateUserConfiguration function

Looks like file service needed for updateUserConfiguration call
tools.js:2 Uncaught (in promise) Error: unsupported
    at FileService.unsupported (tools.js:2:1)
    at Module.updateUserConfiguration (configuration.js:39:1)
    at eval (bootstrap.ts:32:1)

Here is my usage:
await monacoLsp.initServices({
	userServices: {
		...modelService.default(),
		...configurationService.default(monaco.Uri.file('./workspace')),
		...keybindingService.default(),
	},
});

await configurationService.updateUserConfiguration('"{ editor.bracketPairColorization.enabled": false }');

Can you share any example of correct overriding user configuration?

Ok, it works now :)

@BusinessDuck we also make user of updateUserConfiguration in the examples, e.g.:
https://github.com/TypeFox/monaco-languageclient/blob/main/packages/examples/src/langium/statemachineClient.ts#L80-L83

How to determine which settings are controlled by service?

How to determine which settings are controlled by service?

There is no matrix. Trial an error. Check how the setting is applied in vscode desktop app. Everything monaco-editor related should work, but names likely different.


merging example code from github.com/scalameta/example

scala.meta.internal.hosts.scalac.converters.ConvertException: unexpected tree during scala.reflect -> scala.meta conversion:
ModuleDef(Modifiers(),
  org.example.Hello,
  Template(List(Select(Ident(scala), TypeName("AnyRef"))),
  noSelfType, List(DefDef(Modifiers(), termNames.CONSTRUCTOR, List(), List(List()),
  TypeTree(), Block(List(Apply(Select(Super(This(TypeName("Hello")), typeNames.EMPTY), termNames.CONSTRUCTOR),
  List())), Literal(Constant(())))), DefDef(Modifiers(), TermName("v"), List(), List(), TypeTree(), Literal(Constant(42))))))
(PackageDef) package org.example {   object Hello extends scala.AnyRef { ...

Is this missing ModuleDef ? https://github.com/scalameta/scalameta/blob/8ebdeca7b5f5259e450a29b3588c588d700cf4f7/scalahost/src/main/scala/scala/meta/internal/hosts/scalac/converters/ToMtree.scala#L38

Yes, the converter is far from having feature-parity with the old one.
Also, I think that it'd make sense to have examples in a separate repository so that it's possible to bind them to a stable release (e.g. to 0.0.3 that I'm about to publish right now), and then evolve them independently of what's going on in scala.meta's SNAPSHOT. Wdyt?

Btw, tomorrow (and maybe the day after tomorrow) during my preparation for the Monday's workshop at Scala World, I'll be recreating the example repo with several realistic and up-to-date examples of using scala.meta. Do you maybe have any suggestions of what I could do there?

yep it can be a separate project. we can use git subtree merge to copy the source to the other repo. The advantage of having it here is to know as fast as possible when things break.

For Scala World you could do a project explorer
org.scalameta
├── (O) Conversions
├── (O) Exceptions
├── interactive
│   ├── (C) Api
│   └── (C) Context
├── internal
│   ├── ast
│   │   ├── (O) Exceptions
│   │   ├── (C) MergeTrees
│   │   └── package
│   ├── equality
│   │   ├── (C) Helpers
│   │   ├── (C) Normalizing
│   │   ├── (PO) package
│   │   ├── (C) Semantic
│   │   └── (C) Typechecking
// ...

https://github.com/metadoc/metadoc/tree/develop/compilerPlugin/src/main/scala/com.scalakata.metadoc.plugin

Here's the tutorial that I've been preparing for scala.world: https://github.com/scalameta/tutorial. Since it has such a peculiar structure (multiple branches = multiple guides) and a binding to the latest stable version of scala.meta (0.4.0), I don't see how we can merge it into this repo. Maybe we could keep it separate and organize a nightly build instead?

@MasseGuillaume ping

@xeno-by make sense. In this case we just need better code coverage for the tree converter.


docs: document proxy protocol using sequence diagram

This PR adds a new sequence diagram that
shows the message flows for create and start commands between the following:

proxy
shim
runtime
agent

Fixes: #104
Signed-off-by: Jose Carlos Venegas Munoz<EMAIL_ADDRESS>

Coverage remained the same at 74.257% when pulling 5b4501696db23aa1857282e4a812937af7e58737 on jcvenegas:proxy-protocol-sequence-diagram into c0805cc0d7a3cf5632159efbd00b412386006dd5 on clearcontainers:master.

This looks great! Just a few minor nits on first pass.

@jodh-intel  thanks for the comments, suggested changes applied.

hi @iphutch, could you please take a look to this PR?

Coverage increased (+0.3%) to 74.587% when pulling d254f32f65d2e0156d3f3d2db4db6214335bda3d on jcvenegas:proxy-protocol-sequence-diagram into c0805cc0d7a3cf5632159efbd00b412386006dd5 on clearcontainers:master.

Once @iphutch's comments are addressed,
lgtm

@iphutch thanks, changes requested were applied.

Coverage remained the same at 74.257% when pulling 6cddc87e6da35d23d72345133655257dbf8dee36 on jcvenegas:proxy-protocol-sequence-diagram into c0805cc0d7a3cf5632159efbd00b412386006dd5 on clearcontainers:master.

LGTM


Investigate integration with Segment for analitics

Review how odo does integrate with segment and create POC:
https://github.com/openshift/odo/blob/main/docs/dev/usage-data.adoc

Finished investigation and done demo. Nothing to do more right now


Questions about the exploitation of the CVE-2017-17053

Hello, I would like to ask you about the exploit of CVE-2017-17053.
I ran the exp for one night, but it still didn't stop, so I didn't analyze the exploit process through debugging.
I read the code of exp, and compared to PoC, the ccid_alloc function seems to play an important role. I guess it wants to reuse the ldt_struct structure by allocating sockets. But the size of ldt_struct is 0x10, and a heap chunk of size 0x40 will be allocated in sock_alloc, which seems to be unusable (Maybe I got it wrong). In addition, I have not seen the operation of writing malicious data to the chunk, so I want to know how the control flow is hijacked.
In summary, for CVE-2017-17053, I would like to ask:

When will the ldt_struct structure be reused?
When was the control flow hijacked?

Looking forward to your answer, thank you!

i have no idea about ur issue


Correction for raw affiliation Aeres University of Applied Sciences, Almere, The Netherlands; Behavior & Welfare Group, Department of Farm Animal Health, Faculty of Veterinary Medicine, Utrecht University, Utrecht, The Netherlands

Correction needed for raw affiliation Aeres University of Applied Sciences, Almere, The Netherlands; Behavior & Welfare Group, Department of Farm Animal Health, Faculty of Veterinary Medicine, Utrecht University, Utrecht, The Netherlands
raw_affiliation_name: Aeres University of Applied Sciences, Almere, The Netherlands; Behavior & Welfare Group, Department of Farm Animal Health, Faculty of Veterinary Medicine, Utrecht University, Utrecht, The Netherlands
new_rors: 03jnx2c74;04pp8hn57
previous_rors: 015d5s513;04pp8hn57
works_examples: W2903938400
contact: b96f966a4becdeee769ea5ed088bb7c4:2ad1930a7cf7f9e0 @ aeres.nl

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Height Textures not changing anything

Love the plugin so far. However when I put a height texture for the in the texture sets, it doesnt seem to make any visible changes regardless of what number I put as the height blend factor.
I've used textures downloaded from ambientcg and used the displacement file for the height. Everything is set as default and I've also used the same textures sets on a standard plane mesh with a standard material shader and they seemed to work just fine.
Am I doing something wrong?
Thankyou.

Hey @teezytoldme !
Thanks, I'm glad you enjoy it!
Right now, the height texture is used to determine how textures will blend together.
For example, a blending value of 10 would make my brick texture pop :

a blending value of 0 would make my brick texture almost invisible :

So the height helps to decide which texture to use depdending on the height of each.
I hope this helps!

thanks alot makes sense.

Sounds good! I'll close this issue, feel free to ask more questions in other issues 🙂


Backported Scope Setting from 1.7.1

cas-support-pac4j package has compatibility with the 1.4.x version of pac4j library. Backported the scope for the GitHubClient to add functionality.

Build Passed.
Deployment failed.
:grin:
You might want to stop auto deployments for pull requests. PR's won't have deployment tokens.
:grin:

I get the idea: allow users to customize the Github scope: no problem with that.
I always prefer to start with a PR targeting the master and then backport the change if it is really necessary.
Currently, the master is on 1.8.0-SNAPSHOT and the only maintained branch is the 1.7.x which will be used by the CAS server v4.1.0 (to be released soon).
So I won't accept a PR for the 1.4.x branch. The best way to proceed here is to create a CustomGithubClient in your code for CAS v4.0 and propose the changes for the master and the 1.7.x branch, so that you get your change when you'll upgrade your CAS server.
And you're absolutely right: PR should never been deployed -> https://github.com/pac4j/pac4j/issues/173

Around when is the v4.1.0 expected to be released?
I can afford to wait for the update if it is < 2 months.

Definitely less than 2 months and we'll do maintenance releases on 4.0.x as well so you can get the pac4j. If you want to post a PR to CAS, that'd be great. Target master and we'll backport it to 4.0.x

Less than two months is good.
As for a PR to CAS, well, I have not come across anything that is broken or needs extending yet. :smile:
Just to clarify, when 4.1.0 comes out, I update my cas-server-* dependencies version to 4.1.0 as well? and pac4j-oauth to latest release of 1.7.x, right?

yes, though 4.1 will likely be on pac4j 1.8.


improve: worker resiliency, hopefully.

one try/catch we didn't have before, around checker invocation.
one .catch() we didn't have before, around checker promise result.
watchdog timer which kicks the loop if it looks stale.

resolves #388 hopefully.

Restored because I need to try this branch on a production server.

@yanokwa i just pushed an update to the branch now, adding some additional sentry logging.


Delayed Stream is causing Dart process to hang

Windows 10
SDK 2.0.0-dev.40
When I run this test via command line, my process hangs until the Stream actually completes:
test('listen on delayed event', () async {
    var s = new Stream<Null>.fromFuture(
            new Future<Null>.delayed(const Duration(days: 1)))
        .listen(null);

    await s.cancel();
  });

This causes a timeout, for example with a Travis build.
If I lower the Duration to 5 seconds for example, then my terminal becomes responsive again after this 5 second interval.
Expected: since I cancel my subscription, the delayed Stream should be discarded and my process should just terminate.

Future's are not cancellable, that is, there is no way to cancel the underlying action.
If you want your code to work this way, you'll need to write something custom with Timer. But this will be weird anyway, since Streams are meant for repetitive actions, and a Future/standard Timer only fires once.
Just use a one-shot timer?


Mac Compatibility

Need to add ability to detect OS and use forward slash for default config and credential location

Used pathlib to determine path rather than hardcoding.


Crash Loop after loading template

Hello, I am trying to use the following glade template I modfied from /usr/lib/python3/.../nwg_hello/template.glade.  After moving the file to /etc/nwg-hello and adding the file name to nwg-hello.json.  the greeter crashes, reloads an empty grey screen with cursor, and crashes again looping.
The 2 error messages I see after it crashes are

Failed to create /etc/greetd.cache for shader cache (Permission denied)---disabling.
(EE) could not connect to wayland server attribute 'set_test' 51, in __init__^^^^^^^^^^^^^^^^^^^

nwg-hello.glade.zip
Note: I am using Hyprland to launch nwg-hello

As stated in the error message, the 'greetd' user has no access to the cache file. Check your greetd configuration.


dotnetcore: Version for package dotnet-codegen could not be resolved

I am sorry if I abuse this as a support forum. I am having trouble getting a project using a code generator to work under Linux (necessary for our build infrastructure).
I can compile the codegenerator project itself just fine, but when I try to build a project that uses that, I get
Version for package `dotnet-codegen` could not be resolved.
/home/anno/.nuget/packages/codegeneration.roslyn.buildtime/0.4.88/build/CodeGeneration.Roslyn.BuildTime.targets(47,5): warning MSB3073: The command "dotnet codegen --version" exited with code 1. [/home/anno/Workspace/lib-cs-immutable/src/ImmutableExt.Test/ImmutableExt.Test.csproj]
Version for package `dotnet-codegen` could not be resolved.
/home/anno/.nuget/packages/codegeneration.roslyn.buildtime/0.4.88/build/CodeGeneration.Roslyn.BuildTime.targets(59,5): warning MSB3073: The command "dotnet codegen<EMAIL_ADDRESS>exited with code 1. [/home/anno/Workspace/lib-cs-immutable/src/ImmutableExt.Test/ImmutableExt.Test.csproj]
/home/anno/.nuget/packages/codegeneration.roslyn.buildtime/0.4.88/build/CodeGeneration.Roslyn.BuildTime.targets(61,5): warning CGR1000: dotnet-codegen: Failed to generate the list of generated files. The tool didn't run succesfully. Please check https://github.com/AArnott/CodeGeneration.Roslyn for usage instructions. [/home/anno/Workspace/lib-cs-immutable/src/ImmutableExt.Test/ImmutableExt.Test.csproj]

... and the subsequent compilation failures because of the missing generated files, of course.
Installed sdks.
2.1.504 [/usr/share/dotnet/sdk]
2.2.104 [/usr/share/dotnet/sdk]

The dotnet-codegen.dll exists, trying to run it manually yields another error (though that may be fine):
$ dotnet /home/anno/.nuget/packages/dotnet-codegen/0.4.88/lib/netcoreapp2.0/dotnet-codegen.dll

Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'CodeGeneration.Roslyn, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=ec41cf4c17a5eaf3'. The system cannot find the file specified.

Aborted (core dumped)

I have tried targeting netcoreapp2.0, netcoreapp2.1 and netcoreapp2.2 - all with the same result. Any pointers on where to go from here?

@amis92 can you help?

Question 1: Have you followed README? Often-missed point is the <DotNetCliToolReference> element in https://github.com/AArnott/CodeGeneration.Roslyn#apply-code-generation
Question 2: If still not working: Can you check whether https://github.com/jaredthirsk/CodeGeneration.Roslyn.Walkthrough builds for you?
Question 3: If still not working: Can you provide output of your dotnet --info?

Closing because OP didn't follow up.


Commit every N seconds instead of every N blocks

I'm syncing an index on my laptop, and have had to ctrl-c it a few times, and in later stages of syncing, this can lose on average 2.5 minutes of work, since each block is taking 200-300ms to sync.
This makes me think that in fact, we should sync every N seconds instead of every N blocks. Maybe every 60 seconds, since that's likely to keep I/O bandwidth saturated, but will only lose on average 30 seconds of work if you have to stop and start the index.

Welcom


[proposal] Enhance org.osgi.service.url to support authentication

Currently there is no "OSGi-way" to support authentications. Similar to the URL StreamHandler there is only one static java.net.Authenticator.setDefault(...).
My proposal is to support a new service interface PasswordAuthenticationProvider that allows registration of handlers that can provide username/passwords:
package org.osgi.service.url.authentication;

import java.net.Authenticator;
import java.net.Authenticator.RequestorType;
import java.net.InetAddress;
import java.net.PasswordAuthentication;
import java.net.URL;

public interface PasswordAuthenticationProvider {

    /**
     * Called when password authorization is needed.
     *
     * @see {@link Authenticator}
     * @param requestingProtocol
     *            the protocol that's requesting the connection. Often this will
     *            be based on a URL, but in a future JDK it could be, for
     *            example, "SOCKS" for a password-protected SOCKS5 firewall.
     * @param requestingHost
     *            the hostname of the connection requiring authentication, or
     *            null if it's not available.
     * @param requestingSite
     *            the InetAddress of the site requesting authorization, or null
     *            if it's not available.
     * @param requestingPort
     *            an int indicating the port for the requested
     *            connection.
     * @param requestingPrompt
     *            the prompt string given by the requestor (realm for http
     *            requests)
     * @param requestingScheme
     *            the scheme of the requestor (the HTTP scheme for an HTTP
     *            firewall, for example).
     * @param requestingURL
     *            the URL that resulted in this request for authentication.
     * @param requestorType
     *            whether the requestor is a Proxy or a Server.
     * @return The PasswordAuthentication, or null if none is
     *         provided.
     */
    PasswordAuthentication getPasswordAuthentication(String requestingProtocol, String requestingHost, InetAddress requestingSite, int requestingPort,
            String requestingPrompt, String requestingScheme, URL requestingURL, RequestorType requestorType);

}

a framework supporting this can the set the default authenticatior collect all PasswordAuthenticationProviders and iterate over them:
import java.net.Authenticator;
import java.net.InetAddress;
import java.net.PasswordAuthentication;
import java.net.URL;
import java.util.ArrayList;
import java.util.Collection;

import org.osgi.service.url.authentication.PasswordAuthenticationProvider;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class AuthenticatorProxy extends Authenticator {

    private final Collection<PasswordAuthenticationProvider> authenticators = new CopyOnWriteArrayList<PasswordAuthenticationProvider>();

    public void start() {
        Authenticator.setDefault(this);
    }

    public void stop() {
        Authenticator.setDefault(null);
    }

    @Override
    protected PasswordAuthentication getPasswordAuthentication() {
        String protocol = getRequestingProtocol();
        String host = getRequestingHost();
        InetAddress site = getRequestingSite();
        int port = getRequestingPort();
        String prompt = getRequestingPrompt();
        String scheme = getRequestingScheme();
        URL url = getRequestingURL();
        RequestorType type = getRequestorType();
        for (PasswordAuthenticationProvider a : authenticators) {
            try {
                PasswordAuthentication auth = a.getPasswordAuthentication(protocol, host, site, port, prompt, scheme, url, type);
                if (auth != null) {
                    return auth;
                }
            } catch (RuntimeException e) {
               // ... send framework event ...
            }
        }
        return null;
    }

    public void addAuthenticator(PasswordAuthenticationProvider authenticator) {
            authenticators.add(authenticator);
    }

    public void removeAuthenticator(PasswordAuthenticationProvider authenticator) {
            authenticators.add(authenticator);
    }
}

I would not recommend we place this in the Core Framework.  Instead it should be a separate specification on top of Core.

I just found this close related to the URL Handlers Service Specification but a separate specification would be good as well.

The URL handlers have a unique issue because they are singletons and once set they cannot be unset, even by the framework itself without using deep reflection on the java.net package.  This is one reason that the URL handler stuff is a core service because a bundle being started/stopped would have a hard cooping with re-initializing the handlers.  That and the specification wants the bundle URLs to use a framework specific protocol which also requires the URL handlers.
java.net.Authenticator.setDefault(Authenticator) doesn't have the same issue.  It allows anyone to blow away the current one or set it to null (assuming they have permission).  I find that a bit odd, but it does mean this can be done on top of the framework instead of building it into all framework instances.

I find that a bit odd, but it does mean this can be done on top of the framework instead of building it into all framework instances.

That would be fine I think. In fact I have already one bundle providing that "service" and found it very useful so I think it could be useful to become officially supported. I even would contribute my current solution under whatever license is required to be suitable for an OSGi spec.

I even would contribute my current solution under whatever license is required to be suitable for an OSGi spec.

See https://github.com/osgi/osgi/blob/main/CONTRIBUTING.md#contribution-guidelines for the process about creating a new OSGi spec (or making a substantial update to an existing OSGi spec).

Still an issue, e.g P2/ECF currently "blows away" the authenticator so one has only the choice to hope no one else has already a need for it.


Simply touching view causes huge bounce on Android RN 0.59.0. Version 2.0.2

Current behaviour
When using gestures, the leftover velocity of the previous swipe seems to be applied when touching down on the tab view. Only in android, only on the recently stable release 0.59.0
Expected behaviour
After a gesture is complete, the next touch down should be isolated and not affect the view in any way.
Code sample
https://github.com/wizebin/TabViewVelocityIssue
Screenshots (if applicable)
Video showing the core of the issue:
https://streamable.com/ybyc1
What have you tried
Started on the react-native-gesture-handler docs, may try out some solutions myself
Your Environment

software
version

android
9

react-native
0.59.0

react-native-tab-view
2.0.3

react-native-gesture-handler
1.1.0

react-native-reanimated
1.0.0-alpha.12

node
11.0.0

npm
6.4.1

Some more information:
Manually tapping a tab will stop the second issue (where the view to the left will show up while scrolling) until another swipe has occurred

I am also facing similar issue in React Native 0.59 on android. Manually tapping a tab works first time but it doesn't work after that. Swipe still works though.


[8.x] Change newFactory Method Behavior

Now We can return a factory namespace or instance of a factory in newFactory method.
And I guess the method name can be better in new updates (Version 9.x), like getFactory.

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!


Fixes for Swarmpit

Swarmpit is not a container orchestrator, but rather a web ui for Docker Swarm clusters. I've fixed the placement of this and updated the description. 🐳

Hi @harrygulliford thank you for your contribution!


ErrorBoundary prop-type checking logs warning for missing intl

Bug Report
Description

ErrorBoundary prop-type checking logs warning for missing intl.
Warning: Failed prop type: The prop `intl.isRequired` is marked as required in `ApplicationErrorBoundary`, but its value is `undefined`.
    in ApplicationErrorBoundary (created by InjectIntl(ApplicationErrorBoundary))
    in InjectIntl(ApplicationErrorBoundary) (created by ApplicationBase)
    in IntlProvider (created by I18nProvider)
    in I18nProvider (created by Base)
    in Base (created by ApplicationBase)
    in ThemeContextProvider (created by ApplicationBase)
    in ThemeProvider (created by ApplicationBase)
    in div (created by ApplicationBase)
    in ApplicationBase (created by Context.Consumer)
    in AppSettingsProvider (created by Site)
    in Site (created by TerraDevSite)
    in TerraDevSite

Steps to Reproduce

Clone terra-application
Start site npm start and navigate to localhost:8080 or the raw demo page (http://localhost:8080/raw/application/terra-application/demo)
Observe the warning in the console

Additional Context / Screenshots

This may have something to do with terra-base lazy loading intl prior to the ErrorBoundary prop-type validation has completed.
Expected Behavior

The warning should not be logged to the console.
Possible Solution

--
Environment

Component Name and Version:
Browser Name and Version:
Node/npm Version: [e.g. Node 8/npm 5]
Webpack Version:
Operating System and version (desktop or mobile):

https://github.com/cerner/terra-application/blob/master/src/application-error-boundary/ApplicationErrorBoundary.jsx#L18
I think this should just be intl: intlShape, without the additional shape around it.


Python3 compatible

The python-sts module does not work with python3, since inheriting from an str seems to be slightly different from one version to another. Moreover, the iteritems is replaced by items.
One interesting thing would be to convert the CRLF to LF in every file. Have you ever thought about it?

Thanks!
Super-cool to see the PR, but I don't know if anybody here at ArenaNet still uses/maintains this code. I will try to find someone to check this out and land it if they like it.

I can always take a look if you want. ;)
—
Sent from Mailbox
On Mon, Jun 15, 2015 at 3:03 AM, Geoffrey R<EMAIL_ADDRESS>wrote:

The python-sts module does not work with python3, since inheriting from an str seems to be slightly different from one version to another. Moreover, the iteritems is replaced by items.
One interesting thing would be to convert the CRLF to LF in every file. Have you ever thought about it?
You can view, comment on, or merge this pull request online at:
https://github.com/arenanet/python-sts/pull/4
-- Commit Summary --

Python3 compatible
-- File Changes --
M sts/inetheaders.py (9)
M sts/inetmsg.py (2)
-- Patch Links --
https://github.com/arenanet/python-sts/pull/4.patch
https://github.com/arenanet/python-sts/pull/4.diff

Reply to this email directly or view it on GitHub:
https://github.com/arenanet/python-sts/pull/4

Are you guys working for arenanet btw?

@Ge0 Yes, I work for ArenaNet currently. @rstone is a former employee and the original author of this library.

Sounds cool!
Therefore I think you might tell me a few about that STS Protocol. Is it a standard one? Does any related RFC exist? I'm interested in this.

i've merged a new pull into master for python 3 compliance. The only delta was transitioning the Header object from being an instance of str to an instance of object and handling the copy construct init path

to answer your question, it's not really a standard. It's basically HTTP/1.1, but with a bunch of extensions that we rarely use, and hardly support ourselves.
request_one/request_none are basically the only paths we use regularly, and I highly doubt that we will ever publish a full protocol implementation spec for it.
If you're looking to use this outside of arenanet, I'd like to understand your use cases. It's not very common for this protocol to actually be a better choice than leveraging the millions of fully supported and well tested lines of code in HTTP implementations across every language.


Configure logging in the Pyrsia linux installer

Discovered in #244
We should configure logging in the apt-get installed version of Pyrsia, so that a user can somehow inspect the logs if necessary.
The release binary contains log (INFO and higher) but they are only printed if the RUST_LOG env variable is set to info

the script starting the Pyrsia node should set RUST_LOG=info
it could then redirect that output to a file?

Using stdout and stderr will give us the most flexibility.  When running in docker stdout and stderr can be view using the docker logs.  Same when the container is running in Kubernetes, kubectl logs.  Running natively in Ubuntu under systemctl the output will be sent to syslog and viewed with systemctl status or journalctl -u pyrsia.service

Great, then I think simply setting RUST_LOG=info is all we need to do. It will then print info logs and higher to stderr.

Ok, I will make sure that is set for the service

Added RUST_LOG=info to pyrsia-node docker image in PR #260


[Fix #12558] Fix an incorrect autocorrect for Style/MapToHash

Fixes #12558.
This PR fixes an incorrect autocorrect for Style/MapToHash when using map.to_h without receiver.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


Question: Is there an Integration with Thunderbird? Can I use Newsboat on a headless server?

Context: Over the years I have accumulated roughly 300 000 feed items in Mozilla Thunderbird. I have come to the conclusion that I should ideally fetch (RSS) feeds via a headless server, which would reduce my electricity usage. That also would offer the advantage that I can let that machine run 24/7. Thunderbird offers no CLI options for feeds, therefore I was looking for alternative CLI based tools. I was thinking about implementing following workflow: Use Newsboat to fetch and store feeds on the server, then sync the feed directory to my workstation (+ create backups) and look at it whenever desired with my RSS reader of choice.
Question 1: Does newsboat feature importer / exporter for Thunderbird feeds?
Question 2: Can I use Newsboat on a headless server?

I don't think Newsboat is the right application for this job.
Newsboat does not contain any integration for Thunderbird.
It does have integrations with some Newsreading Services but in those cases Newsboat is only acting as a client.

Can I use Newsboat on a headless server?

It is possible to run Newsboat on a headless server, but (as far as I know) you can only read/interact with it via the terminal interface.
One way to do that is to run Newsboat in a terminal multiplexer (e.g. tmux) and connect to it via ssh.

Thank you for the response :-)
Using a terminal multiplexer is an interesting idea. I will consider it, once I tackle this project.
Interacting with newsboat only via the terminal interface is fine for me, as long as I can set up the initial news feed, have newsboat in autostart and let it run in the background doing automated fetching. I personally prefer having a GUI for reading the feeds, but that's a separate problem and should be manageable, as long as the feed is stored in a format that is compatible with a feed reader with GUI.
Anyway, if you think Newsboat is the wrong tool for the job, maybe it is. I will look for another one. Thanks again :-)


installation of 7zip fails

Hi want to install git via scoop. scoop starts by downloading 7zip, but then fails consistently when it has to extract the msi contents. In fact, installing 7zip on its own produces the same error:
PS C:\Users\guillermo\Documents\Dev> scoop uninstall 7zip
uninstalling 7zip (9.20)
7zip was uninstalled
PS C:\Users\guillermo\Documents\Dev> scoop install 7zip
installing 7zip (9.20)
loading http://tcpdiag.dl.sourceforge.net/project/sevenzip/7-Zip/9.20/7z920-x64.msi from cache...
checking hash...ok
extracting...exit code was 1603
failed to extract files from C:\Users\guillermo\appdata\local\scoop\apps\7zip\9.20\7z920-x64.msi.
log file: ~\appdata\local\scoop\apps\7zip\9.20\msi.log

Log file:
=== Logging started: 24.02.2015  17:08:00 ===
The installer has encountered an unexpected error installing this package. This may indicate a problem with this package. The error code is 2203. The arguments are: C:\Users\guillermo\appdata\local\scoop\apps\7zip\9.20\_scoop_extract\7z920-x64.msi, -2147287008,
=== Logging stopped: 24.02.2015  17:08:00 ===

I'm running scoop as a regular user (RemoteSigned PS execution policy).

What version of powershell and .NET are you running?

Dev $ $PSVersionTable

Name                           Value
----                           -----
PSVersion                      3.0
WSManStackVersion              3.0
SerializationVersion           <IP_ADDRESS>
CLRVersion                     4.0.30319.18444
BuildVersion                   6.2.9200.16398
PSCompatibleVersions           {1.0, 2.0, 3.0}
PSRemotingProtocolVersion      2.2

It works again. Can't repro this any more, so closing. Thanks!


Wrong function definition for for the Python example.

In the section "What is the syntax for mounting storage?" the definition of the function dbutils.fs.mount() is wrong for Python. The function definition is correct for Scala, but not for Python.
Databricks Utilities FileSystem documentation for reference: https://learn.microsoft.com/en-us/azure/databricks/dev-tools/databricks-utils#--mount-command-dbutilsfsmount
Please fix this documentation. Thanks!
Best,
Adis

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 29d8b958-f62f-63ba-df25-53348ab5ea3c
Version Independent ID: 29d8b958-f62f-63ba-df25-53348ab5ea3c
Content: Mounting cloud object storage on Azure Databricks - Azure Databricks
Content Source: databricks/dbfs/mounts.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@adisaljusi
Thanks for your feedback! We will investigate and update as appropriate.

@adisaljusi
I've delegated this to @mssaperla , a content author, to review and share their valuable insights.

Thanks for providing feedback that helps improve our documentation.  We've created an internal work item (DOC-8885) to address your feedback. The timeline for resolution varies based on resourcing.


Add aria hints where labels were missing or unclear

While reading the source, I noticed several links that didn't seem to have descernible text. Running the site though webhint.io confirmed my hunch. In those cases, I've added the aria-label attribute, which will be used by screen reader software.
I scanned the home, releases, and crate detail pages. These changes are fairly complete, but not exhaustive. In fact, this is the first of what I hope will be several accessibility-related PRs I make to docs.rs!

Feedback has been answered. Much of this first round seemed to ignore the accessibility specification this PR aligns with, so I would encourage future reviewers to brush up on WCAG 2.0 ("Web Content Accessibility Guidelines") before sending critiques that we will ultimately have to proceed without adopting. Odds are, if I've included a change here, it's either a critical accessibility violation or the current markup is far outside accessibility best practices. In either case, it should be changed.
Critiques like "not sure it's very useful in here..." are opinions, and don't hold value in this case. Feedback that is based on evidence and increases compatibility with WCAG is fine (and encouraged, even). However, all unfounded feedback, which is published without a link to the specification we should uphold, will be ignored from this point forward.
By no means is this PR feature complete, but it does address the critical violations and best practices suggested by Webhint, which uses axe-core to scan for accessibility issues. It's a good first step towards making our shared tools accessible to all potential members of the Rust community.

 You do realize that we're humans and that by no means we know everything there is to know about everything and that we do it on our free time? I expressed my opinion, you're free to contest it by using arguments, no need to become rude like you just did.
I'll let @QuietMisdreavus handle this then, I'm clearly not contributing/reviewing on my free time to get insulted on a lack of knowledge.

I had a chat with @GuillaumeGomez about this: he hadn't quite interpreted things correctly. I've also talked to him about improving his review style, English isn't his native language and he tends to be terse because of this.
Your feedback and help is greatly appreciated, @secretfader, sorry about the initial hostile response here. ARIA is definitely something we should try to do well here, thanks for the pull request!

Oh, also, to clarify a bit:

However, all unfounded feedback, which is published without a link to the specification we should uphold, will be ignored from this point forward.

This is what kinda confused people: I'm reading it as you not accepting feedback that isn't founded in the spec (which is fine and good!), @GuillaumeGomez read it as you refusing to help with the review at all unless they read the spec.
Please try to work together on this: @GuillaumeGomez if you're not sure about spec stuff, ask questions about the spec (and maybe ask for spec links to be inserted in the PR itself, wherever necessary!). @secretfader please work with @GuillaumeGomez's questions here.
Let me know directly if y'all have issues, I can be reached on the Rust discord.

Thanks for the explanation, @Manishearth. I hoped this PR would be a simple change that enhanced accessibility, and never imagined it would become divisive.
Unfortunately, this is the kind of opposition I expect when advocating for accessibility. For context, I've had people deny accommodations for myself and others, even when I'm out in public with only one intact leg (and in a wheelchair). I'm fine with questions (like "can you elaborate on why this ARIA role is required"?), but dismissal or insinuation that a change is unnecessary is a bit more than I'm willing to tolerate. While we're on the topic of speech or concepts that are insulting, then denying disabled people the chance to use the same platforms as our abled counterparts should be unacceptable from any cultural perspective (though in some countries this discrimination is rampant and normal, a reality I reject and I hope we can all agree is worthy of disdain).
If questions are asked without hints of an expected answer, I'm happy to elaborate. I did my best to include links (both in comments and the original PR description) for reviewers who wish to do further research, and I encourage use of them.
If my words appear overly strong, it's that when speaking in technical circles, I've found that I (and frankly, all disabled advocates) must communicate with a firm and confident tone, or risk being completely ignored. Fully exhaustive responses with links are a survival tactic in a world that is actively hostile to people like me. The initial response I received was completely in line with the kinds of dismissive, marginalizing comments that people have directed at me in the past, so I treated it as such. (It is jarring to experience this the Rust community. I hope this thread underscores how and where we can continue to improve.)
If most anyone in this thread received the amount of harassment and judgement I deal with on a regular basis as a result of being disabled, I think you would also agree the content of my responses is justified. I've spent all available mental health resources on this thread, which will limit my role in future discussion. I'll now move on and let you discuss primarily amongst yourselves, with the understanding that these changes are minor but have potentially large impact for visually impaired users.

I wasn't against the PR, I suggested rewording because I thought it would be better. I never said that we shouldn't add aria-label which seemed like a great add.
I hope I made my position clear(er?) and I'll try not to comment here any further (I said I wouldn't but I still did...).

Again, to clarify, English isn't @GuillaumeGomez's first language, and they felt "Not sure it's very useful in here" was an okay way to say "can you explain why this is needed?"
there's no actual contention around the changes made in this PR, it's just a perception of contention due to a bit of a language barrier :smile:
Sorry the both of you had to deal with this, I'll try to help finish review here (I'm a bit familiar with wai-aria)

Looking at the webhint report you linked in the PR description, one of the search boxes it flagged was rustdoc's own one. I dug a little and found a nearly three-year-old issue discussing accessibility issues surrounding it. It hasn't received a comment in a year and a half though, so i'm not sure of the current situation. (This also means that existing docs on docs.rs before that's fixed upstream will not receive the fix, since we don't rebuild crates when we update rustc.)
I think the only hangup i have about the wording is that i'm not sure how a screen reader picks up the text, and what it adds around it. For example, you stating that the word "menu" is unnecessary for the platforms menu is not an assumption i would have made, since it only appears as a link in the HTML, or that the word "search" was unnecessary, since it was already an <input> element. Past that, my only suggestion would be to err on the plural side when describing things in the label. My personal assumption when writing menu text is that it's easier to use a plural word to describe something that's potentially plural than it is to use a singular word for it. There are usually more than one platform in the platforms menu, and more than one crate returned in a search, so it feels easier for me to state that.
Thanks so much for posting this! I hope you can feel up to providing more suggestions in the future. (I'm interested in updating our HTML to use HTML5 semantic elements, though i figure that's a more involved change.)


[Stack HCI] Upgrade Stack HCI CLI

Resolves: https://github.com/Azure/azure-cli/issues/21432
"We want to update our CLI based on the swagger. Currently, we have the cli commands for clusters resource, we would like to add for our other resources: arcsettings, extensions as well."

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

Stack HCI


Add the "C2C" Module in SLAlpha1 API Docs

Add the "C2C" modules in SLAlpha1 API Docs[1].
[1] http://dev.ballerina.io/swan-lake/learn/api-docs/ballerina/#/

This issue is casued by: https://github.com/ballerina-platform/module-ballerina-c2c/issues/72

This issue is casued by: https://github.com/ballerina-platform/module-ballerina-c2c/issues/72


How to query app version with javascript?

For debugging purposes (at least), I'd like to make a javascript call that would tell the app version the client is running. I can get the version of the updatable part of the app by reading chcp.json with XHR, but I've found no way of retrieving the actual app version loaded from the store.
I'd fancy something like chcp.getAppVersion() that would return something useful, maybe the version string specified in config.xml.
NB: Probably due to the directory structure used by chcp, the cordova-plugin-app-version plugin doesn't seem to work at all if chcp is enabled, so that won't help either. I tried this:
cordova create test
cd test
cordova platform add ios
cordova plugin add cordova-hot-code-push-plugin
cordova plugin add cordova-plugin-app-version
cordova build ios
cordova run ios --device --

The app just terminates immediately after launching.

To what version are you referring to:

version of the app, visible to everyone on the App Store?
version of the web content, displayed in the app?

Sorry for being unclear. I'm referring to version of the app. As I tried to say, I believe I can query the current version of the web content by requesting chcp.json.

Understood, thanks )
Looked at the cordova-plugin-app-version - he doesn't depend on the files structure, so it should not crash because of it. I think you are crashing, because of the missing chcp.json and chcp.manifest files in www folder of your project.
Correct steps should be:
cordova create test
cd test
cordova platform add ios
cordova plugin add cordova-hot-code-push-plugin
cordova plugin add cordova-plugin-app-version
cordova-hcp build
cordova build ios
cordova run ios --device --

From your steps above you've missed cordova-hcp build action, which creates chcp configuration files in www folder.

Thank you. You're correct, my analysis was utterly wrong. Both plugins work as expected.
You might want to make chcp spit an error (to where?) instead of crashing, when the required files are not present.

Yes, you are probably correct: need a better error handling. Thanks :)


DHT/Peer Exchange

Do you intend to continue your development of this to include DHT/Peer Exchange. The work you have done here has help me a lot in understanding BitTorrent in C#!

I would recommend looking into https://github.com/bizzehdee/System.Net.Torrent

@adamreed90  @cheatdeath  Can I replicate this project in C++ lanuage?

@adamreed90 I don't plan on doing any more work on this for the foreseeable future.
@iRajul Sure, if you want.

@cheatdeath  I want to do this for learning purpose. Can you please brief me little bit about this project's make process. Is it GUI or commandline tool. after that I will continue on my own.

If you download Xamarin Studio (https://www.xamarin.com/download) you should be able to open the project file (Research-BitTorrent.sln) in the IDE and then Build and Run. It's possible to build from the command line but more complicated – I've never used the command line tools.


Desktop and WasmJs targets

+++

++

@mahramane @JagadishaIncture Its added in our latest version v1.0.6

@mayur-ctn  please update Readme and also please addd some screenshots


Calculate breastfeeding duration distribution - Ethiopia

Produce breastfeeding duration distribution mu and beta from DHS using R script in the data processing folder.

[x] Determine the data source (e.g. STATcompiler, IPUMS DHS)
[x] Format data file and run R script
[x]  add to ethiopia.py script

Data processing script uses m4 variable, which the recode manual defines as the duration of breastfeeding of the child in months. DHS Ethiopia data file had m4 as a categorical variable.

(url)

Issue Closed: PR #156


Extensions are keeping stuck at "installing"status.

VSCode Version: Code 1.3.1 (e6b4afa53e9c0f54edef1673de9001e9f0f547ae, 2016-07-12T13:35:06.227Z)
OS Version: Windows_NT ia32 10.0.10586

Steps to Reproduce:

Choose extension option.
Select any extension.
Keep stuck at "installing"status.

Best Regards,

Are you behind a proxy?

I am coming across the same problem, I am behind a proxy. I have set my proxy settings as outlined here https://code.visualstudio.com/docs/setup/setup-overview#_proxy-server-support and just hangs at installing.

@nelsonc24 @rylan Can you try the latest insiders release?

I was able to fix the problem. It turned out that the instance that I working on did not have the .cmd extension set in the PATHEXT environment variable.

Same problem here.
Visual Studio Code
Version 1.12.2
Shell 1.6.6
Node 7.4.0
Rederer 56.0.2924.87


added the enable coordinator mirroring doc

closes: #ISSUE_Number

Change logs

Describe your change clearly, including what problem is being solved or what document is being added or updated.

Added a new topic describing the coordinator mirroring feature.
Contributor's checklist
Here are some reminders before you submit your pull request:

Make sure that your Pull Request has a clear title and commit message. You can take the Git commit template as a reference.
Sign the Contributor License Agreement as prompted for your first-time contribution (One-time setup).
Learn the code contribution and doc contribution guides for better collaboration.
Make sure that your changes deployment preview is successful.
List your communications in the GitHub Issues or Discussions (if has or needed).
Feel free to ask for the @cloudberrydb/doc team or other people to help review and approve.

Hi @EcaleD , thanks for your work!