Fix #11, #13 (longitude/latitude order) and #9 (polyline case)

This should fix issues #11 and #13 (both related to longitude/latitude order) and avoid the confusion created by the use of the Point namedtuple (see https://github.com/ustroetz/python-osrm/issues/13#issuecomment-406031194 for the wrong/current behavior).
This should also fix #9 by using the word polyline in lower case when building the url in the trip function.
I can split that PR in multiple ones if needed.

Thanks @mthh!


Fixed wrong layout config definition

It was fixed. Closing due to conflicts.
Thanks for your contribution!


Add stable diffusion unit test

Add a unit test for Stable Diffusion without using stable-diffusion model that needs HF token.
Midjourney model does not need the HF token and has the same structure.
We verified this by printing both models. The following is the structure:
  "_class_name": "StableDiffusionPipeline",
  "_diffusers_version": "0.7.2",
  "feature_extractor": [
    "transformers",
    "CLIPFeatureExtractor"
  ],
  "safety_checker": [
    "stable_diffusion",
    "StableDiffusionSafetyChecker"
  ],
  "scheduler": [
    "diffusers",
    "PNDMScheduler"
  ],
  "text_encoder": [
    "transformers",
    "CLIPTextModel"
  ],
  "tokenizer": [
    "transformers",
    "CLIPTokenizer"
  ],
  "unet": [
    "diffusers",
    "UNet2DConditionModel"
  ],
  "vae": [
    "diffusers",
    "AutoencoderKL"
  ]
}

@cmikeh2

You can set a manual seed, and the images should be the same,
generator = torch.Generator("cuda").manual_seed(1024)
image = pipe(prompt, guidance_scale=7.5, generator=generator).images[0]

https://huggingface.co/blog/stable_diffusion


Add a command based solution to fill in placeholders

Add a command based solution customize the setup

tokens & keys
coverage
user identity: name, repo name, username, email, php version, license, etc.
choose which setups to keep/delete

won't fix for now

won't fix for now


data.img preventing Migration Assistant transfers

Describe the bug
The data.img sparse bundle size (8.8TB reported on my Mac) prevented me from using Migration Assistant, which does not provide helpful errors. Understanding the context with #29, I am opening this ticket anyways. I appreciate the forward-thinking adoption of this image format, but clearly even Apple's backup and recovery tools are not yet ready to adopt this.
It was only after failing multiple times to migrate, even thinking of recursive disk space traps, that I identified data.img as the culprit. During use of Carbon Copy Cloner, which reported that it "Discovered" 9.2TB of files but then successfully saved ~400GB that I was able to use CCC's audit function to identify that it registered data.img as being 8.8TB in size.
Apple's migration tool provides notoriously little feedback, and I am opening (yet another) Radar about this. But OrbStack is claiming the juice is worth the squeeze to move forward with Apple's modern tools... when Apple's tools clearly aren't expecting this yet either.
To Reproduce

Use OrbStack as you normally would.
Attempt to migrate to a new Mac using Migration Assistant
Observe that Migration Assistant will calculate a total space requirement that fits on the new Mac
During file migration, the process will stop stating there is "not enough space" every time
Delete data.img from the source drive
Reattempt migration
Migration succeeds.

Expected behavior
I would be able to migrate from my old Mac, to my new (which has larger storage, not less), without finding and deleting data.img.
Diagnostic report (REQUIRED)
OrbStack info:
Version: 1.7.5
Commit: 82ec89be256fec62e3236f71eea94263bfcffe17 (v1.7.5)
System info:
macOS: 15.0.1 (24A348)
CPU: arm64, 11 cores
CPU model: Apple M3 Pro
Model: Mac15,6
Memory: 36 GiB
Full report: https://orbstack.dev/_admin/diag/orbstack-diagreport_2024-10-13T22-55-23.815864Z.zip

Screenshots and additional context (optional)
No response

We exclude the data image from Time Machine since Apple lets us. It doesn't look like there's a way to do similar for Migration Assistant. Going to keep this open in case we come up with anything, but for now, the ball's in Apple's court.

Should this at least be better documented/FAQ'd? I'm not expecting an alert in the application, obviously, but this only came to my attention because another tool pointed to the OrbStack file and then I found the legacy issue here on Github. In addition to this, it required non-standard tooling in order to actually backup data.img and restore it. I didn't find any solution to enable Migration Assistant besides deleting the file from the source machine.
If I had moved forward with just starting the second laptop from scratch and attempted to move the file, I would have been hit by similar messaging/failures in Finder that the file is too big for the destination. This is not just a Migration Assistant issue, really, the file is completely non-portable via the standard available tooling today.

Should this at least be better documented/FAQ'd?

Absolutely.

orbstack使用了自己的ssh，存储在：~/.orbstack/ssh
我删除了~/.orbstack/ 并重新安装， 解决了这个报错


Allow iteration of builtin arrays

E.g. the following should iterate through the array:
for (var i in [1, 2, 3]) {
  ...
}

Currently we get an error:
error: type 'int[3]' has no member function 'iterator'

Implemented in 29a1a4b82cb20c4d389f6fc74abed39b1b3bd88a.


Report user, group permissions

Please describe - or add feature - to report user, group permissions

Could you describe in detail how this feature (report user, group permission) should work?

This feature request aims to provide an intuitive view of permissions.
Example, /useradmin does this for group (or user) + repository paths.
This request is focused on a more simple groups - users - permissions & constraints report.
Proposed view

QUERIED
GROUPS
MEMBERS
PERMISSIONS

workflow-editors
workflow-users
workflow-administrators
/apps jcr:read ALLOW rep-glob=....

everyone
Screen Admins Group
...

...
....

Steps
For a given group,

Collect available "parent" & "child" groups
Collect paths & permissions
Collect users

Future
Graph view; e.g., https://observablehq.com/@d3/zoomable-icicle or https://observablehq.com/@d3/zoomable-sunburst
Add table of path contexts


Indexing bug in compute_npmi_at_n_during_training

I noticed that you have a minor indexing bug in the within-training NPMI calculation, so I changed it to match how you calculate compute_npmi_at_n.
Note that it assumes a sparse input. This is appropriate for my fork, but I couldn't tell at a glance if this was right for yours.

Ah, good catch, thanks!


[flash_ctrl/dv] Fix small bank erase bkdr bug & make info1 read-only by default

Hi,
This PR mainly came to fix small bug in bank erase back-door check.
The problem is that the back-door interface uses overall address instead of relative address. Each bank has its own back-door interface and so when the interface of bank1 is asked to read the overall address of bank1 starting address it reports an overflow error, since this address is larger then its defined range.
In addition, this PR is making info1 partition to be read-only by default and allowing bank erase to be sent only to data and 1st info partition.
Thanks!
Signed-off-by: Eitan Shapira<EMAIL_ADDRESS>

I saw the checks failed for some reason I couldn't understand. Can you please explain it?

close and re-open to trigger CI again.

Thanks! If it's all looking good to you, can you please merge this PR?


Problem adding models to a list

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
List tt() async {
List allCodeMeli = [];
for (var element in _list2) {
allCodeMeli.addAll(element.listCodeMeli);
}
return allCodeMeli;
}
Expected results
I fill a list through the text field and add that list to list 2 by a model, provided that none of the items of the first list are available in the models of the second list.
The problem is that in the first instance, the list is created and placed in the second list by a model, but if I want to put another list in the second list by the model, all the parameters of the list of models in the second list are changed to the current added value.
example :
step 1 : befor add item2 in the lis2 (item [1,2])
---print list 2--- > [{nameMarket: name, listCodeMeli: [1, 12], mobile: 1234, unique: unicode}]
step 2 : after add new item2 in the list2(item [66, 77]])
---print list2 ---- > [{nameMarket: name, listCodeMeli: [66, 77], mobile: 1234, unique: unicode},{nameMarket: name, listCodeMeli: [66, 77], mobile: 1234, unique: unicode}]
when the function
tt()
I disable it, everything works fine and the first list is placed in the second list with a new model, and the rest of the models in the second list do not change.
Actual results
--
Code sample
Code sample
import 'package:flutter/material.dart';

const Color darkBlue = Color.fromARGB(255, 18, 32, 47);

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData.dark().copyWith(
        scaffoldBackgroundColor: darkBlue,
      ),
      debugShowCheckedModeBanner: false,
      home: TextWidget()
    );
  }
}

class TextWidget extends StatefulWidget {
  const TextWidget({super.key});

  @override
  State<TextWidget> createState() => _TextWidgetState();
}

class _TextWidgetState extends State<TextWidget> {
  List<String> _list1 = [];
  late List<ModelFormatMarket> _list2;
  TextEditingController _controller = TextEditingController();
  @override
  void initState() {
    // TODO: implement initState
    super.initState();
    _list2 = [];
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: SizedBox(
        width: 400,
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: [
            Column(
              children: [
                TextField(
                  controller: _controller,
                ),
                ElevatedButton(
                    //<<---------add to list1
                    onPressed: () {
                      _list1.add(_controller.text);
                      print(_list1);
                    },
                    child: Text('add to list 1'),)
              ],
            ),
            Center(
              child: Column(
                children: [
                  ElevatedButton(
                      //-------> create model and add to list2

                      onPressed: () {
                        onTapBtnOk();
                      },
                      child: Text( 'add to list2'),),
                  ElevatedButton(
                      //----------->>> list1 clear
                      onPressed: () {
                        _list1.clear();
                      },
                      child: Text('del'),)
                ],
              ),
            ),
          ],
        ),
      ),
    );
  }

  List tt() async {
    List<String> allCodeMeli = [];
    for (var element in _list2) {
      allCodeMeli.addAll(element.listCodeMeli);
    }
    return allCodeMeli;
  }

  onTapBtnOk() async {
    //------> check item list 1 in the all items list2
    List list0 = await tt();

   List list =
       allCodeMeli.where((element) => list0 .contains(element)).toList();

    if (list .isNotEmpty) {
      _list2.add(ModelFormatMarket(
          nameMarket: 'name',
          unique: 'unicode',
          listCodeMeli: _list1,
          mobile: 1234));
         for(var e in _list2){
      print('==> ${e.toMap()}') ;
    }
    } else {
      print('codemeli exist in the list model');
    }
  }
}

class EntitiFormatMarket {
  final String unique;
  final String nameMarket;
  final List<String> listCodeMeli;
  final int mobile;
  const EntitiFormatMarket({
    required this.unique,
    required this.nameMarket,
    required this.listCodeMeli,
    required this.mobile,
  });

  @override
  bool get stringify => true;

}

class ModelFormatMarket extends EntitiFormatMarket {
  const ModelFormatMarket(
      {required super.nameMarket,
      required super.unique,
      required super.listCodeMeli,
      required super.mobile});

  ModelFormatMarket copyWith(
      {String? nameMarket,
      List<String>? listCodeMeli,
      int? mobile,
      String? unique}) {
    return ModelFormatMarket(
      unique: unique ?? this.unique,
      nameMarket: nameMarket ?? this.nameMarket,
      listCodeMeli: listCodeMeli ?? this.listCodeMeli,
      mobile: mobile ?? this.mobile,
    );
  }

  Map<String, dynamic> toMap() {
    return <String, dynamic>{
      'nameMarket': nameMarket,
      'listCodeMeli': listCodeMeli,
      'mobile': mobile,
      'unique': unique
    };
  }

  factory ModelFormatMarket.fromMap(Map<String, dynamic> map) {
    return ModelFormatMarket(
      unique: map['unique'] as String,
      nameMarket: map['nameMarket'] as String,
      listCodeMeli: List<String>.from(map['listCodeMeli'] as List),
      mobile: map['mobile'] as int,
    );
  }

}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[1]
[1, 2]
==> {nameMarket: name, listCodeMeli: [1, 2], mobile: 1234, unique: unicode}
[66]
[66, 77]
{nameMarket: name, listCodeMeli: [66, 77], mobile: 1234, unique: unicode}
==> {nameMarket: name, listCodeMeli: [66, 77], mobile: 1234, unique: unicode}
==> {nameMarket: name, listCodeMeli: [66, 77], mobile: 1234, unique: unicode}

Flutter Doctor output
Doctor output
Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.13.6, on Microsoft Windows [Version 10.0.19045.3570], locale fa-IR)
    • Flutter version 3.13.6 on channel stable at E:\SDK\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ead455963c (3 weeks ago), 2023-09-26 18:28:17 -0700
    • Engine revision a794cf2681
    • Dart version 3.1.3
    • DevTools version 2.25.0

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at E:\SDK\Android\Sdk
    • Platform android-33, build-tools 34.0.0
    • Java binary at: C:\Program Files\Android\Android Studio1\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.3.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.3.32922.545
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.3)
    • Android Studio at C:\Program Files\Android\Android Studio1
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = C:\Program Files\Android\Android Studio1
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[√] VS Code, 64-bit edition (version 1.83.1)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.74.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.3570]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 118.0.5993.71
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 118.0.2088.57

[☠] Network resources (the doctor check crashed)
    X Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know about this issue
      at https://github.com/flutter/flutter/issues.
    X Exception: Network resources exceeded maximum allowed duration of 0:04:30.000000
    •

! Doctor found issues in 1 category.
The Flutter CLI developer tool uses Google Analytics to report usage and diagnostic data
along with package dependencies, and crash reporting to send basic crash reports.
This data is used to help improve the Dart platform, Flutter framework, and related tools.

Telemetry is not sent on the very first run.
To disable reporting of telemetry, run this terminal command:

flutter --disable-telemetry.
If you opt out of telemetry, an opt-out event will be sent,
and then no further information will be sent.
This data is collected in accordance with the
Google Privacy Policy (https://policies.google.com/privacy).

Please note that analytics reporting was already disabled, and will continue to be dis

For help with your own code, consider using one of the resources listed at https://flutter.dev/community#community-grid.
Closing as this is not a Flutter bug; the code is behaving correctly as written since the array in question is being re-used.


make is_required optional

Summary

Checklist

[x] I have run nox and all the pipelines have passed.
[ ] I have made unittests according to the code I have added/modified/deleted.

Related issues

I see what you mean about the documentation changes. After looking over the discord docs again I think its best to keep it deserializing to false.

Pretty sure #924 already does this.

The description is changed but the Optional type hint isn't added

The description is changed but the Optional type hint isn't added

Not too sure I like having it be Optional without correctly documenting why. Will wait on @FasterSpeeding's opinion

Closed in favour of the changes in #924


Add Session Result class

Adds Session.Result class, which is a wrapper around the output tensors and the fetched outputs.  This allows querying results in the same style as fetch (from name, name and index, Output, and Operand).  The Output and Operand methods are also typesafe.  It's Iterable and AutoClosable (close closes the result tensors).  The run().get(0) usage works just fine still, so even though it's a breaking change, it should be pretty minor.
I also moved the getOutput (from name and from name and index) methods from Session to Graph and made them public.
I'd like to make feed typesafe as well, but was not able to find a good way to do it.

Hi @rnett , sorry for the delay, I've been a bit busy these days, but before I go through this one, I wanted to let you know that I was also planning to add something similar in the tensor type refactoring that is currently in progress, you can take a look at the TensorList and TensorMap utilities in the original draft here: https://github.com/karllessard/tensorflow-java/tree/tensor-ttype/tensorflow-core/tensorflow-core-api/src/main/java/org/tensorflow/util
The main purpose in my case was to support implicit casting of the tensor types in the list itself, hence why Session don't return a List anymore but an object. So we can do:
try (TFloat32 t = s.runner().fetch(x).run().single()) {
    // ...
}

instead of
try (TFloat32 t = (TFloat32)s.runner().fetch(x).run().get(0)) {
    // ...
}

So before I start reviewing, I don't know how critical having this PR merged is for you but we need to take into accounts our future needs if there is an agreement on what they are, either we can start that discussion now or either we wait until the type refactoring to be over, wdyt?

Looking at TensorMap/List, I think we'll still want a Result class, for get(Operand/Output) (with type safety + implicit casting) and for immutability.  I'd probably use TensorList and TensorMap instead of the List and Map I have currently.  What do you think about adding ImmutableTensorMap/List classes?  I'm not sure how much it would be used, but for this it would certainly be nice.
As for the timing, I think we'd be fine to merge this now and then refactor it a bit with the type system, but it doesn't matter to much either way.  I mostly wanted this so I could add proper extensions to the Kotlin API, which is waiting on the type system refactor anyways.

@rnett , I've pushed my unmerged-branch to a new branch in this repository: https://github.com/tensorflow/java/tree/type-refactor
Can you please rebase your work on it and target it in your PR so that we only the changes coming from your branch?

@karllessard your branch is a few commits behind master.  Are you planning on rebasing it?  If so I'll wait for you to do that before doing mine.

Oh sorry @rnett , looks like I've pushed the wrong version of my branch, you should be good now to rebase on it. Refreshing it had also the vicious effect of closing the PR that were targeting that branch, I've reopened this one but if you see other PRs that have been closed by mistake, please reopen them, thanks

@rnett the order swaps because we haven't run down all the non-determinism in the ops generator, so sometimes it emits things in a different order causing spurious changes in PRs.

Thanks for looking at this @rnett , I was eager to see such utility to simplify the manipulation of a group of tensors.
Before going to deep into the analysis of the current proposal, I would like to point out something important to consider. While TF Java has always been graph/session centric, it will gradually move towards to a more functional approach, like @tf.function does in Python. This is what the new ConcreteFunction is partially achieving and the core will continue to build up around it to improve the support of functions as the main API for building and executing graphs.
That being said, I think it is important for the solution we are choosing to manipulate a "bundle" of tensors to be fully compatible with the concept of functions. For example, in functions, tensors are not only bundled as a result of an execution but also to feed the underlying session. Right now everything is handled using HashMap but I'm sure that whatever utility we come up for returning the result of a session run should apply to the feeding as well.
If we do that, then the Result class should live outside Session and be renamed to something else. Again I did not went through the whole proposal yet but before doing it I would like to hear your thoughts about it, thanks!

Thanks for looking at this @rnett , I was eager to see such utility to simplify the manipulation of a group of tensors.
Before going to deep into the analysis of the current proposal, I would like to point out something important to consider. While TF Java has always been graph/session centric, it will gradually move towards to a more functional approach, like @tf.function does in Python. This is what the new ConcreteFunction is partially achieving and the core will continue to build up around it to improve the support of functions as the main API for building and executing graphs.
That being said, I think it is important for the solution we are choosing to manipulate a "bundle" of tensors to be fully compatible with the concept of functions. For example, in functions, tensors are not only bundled as a result of an execution but also to feed the underlying session. Right now everything is handled using HashMap but I'm sure that whatever utility we come up for returning the result of a session run should apply to the feeding as well.
If we do that, then the Result class should live outside Session and be renamed to something else. Again I did not went through the whole proposal yet but before doing it I would like to hear your thoughts about it, thanks!

@karllessard, I understand the desire for a bundle as inputs, when using ONNXRuntime which has a result object as the output recently I've been missing an equivalent object for inputs to clean those up easily. However for TF I think it might not be ideal. The session result object is helpful because it's an easy way to control the lifetime of a block of tensors which are expected to have the same lifetime, however the input tensors may have different lifetimes (e.g. I frequently have a long lived boolean tensor that sets the network into training mode, and often a long lived one for the current training epoch or learning rate). When the lifetimes of the tensors differ then an AutoCloseable container seems less relevant.
If we wanted to lean into dynamic code generation (which we probably don't due to having to update ASM to track new JDKs every 6 months) then we could make a type safe autocloseable container for the inputs and outputs on load of the ConcreteFunction and then it would expose getters and setters with the right names.

@karllessard, I understand the desire for a bundle as inputs, when using ONNXRuntime which has a result object as the output recently I've been missing an equivalent object for inputs to clean those up easily. However for TF I think it might not be ideal. The session result object is helpful because it's an easy way to control the lifetime of a block of tensors which are expected to have the same lifetime, however the input tensors may have different lifetimes (e.g. I frequently have a long lived boolean tensor that sets the network into training mode, and often a long lived one for the current training epoch or learning rate). When the lifetimes of the tensors differ then an AutoCloseable container seems less relevant.
If we wanted to lean into dynamic code generation (which we probably don't due to having to update ASM to track new JDKs every 6 months) then we could make a type safe autocloseable container for the inputs and outputs on load of the ConcreteFunction and then it would expose getters and setters with the right names.

@karllessard The Result class is a bit different that a generic tensor container in that it provides keyed and indexed access, as well as Operand/String -> Output mapping, which depends on the Graph instance.  If we do end up having tensor containers, I think they would be best used as the backing List/Map in Result, rather than replacing it.

@karllessard The Result class is a bit different that a generic tensor container in that it provides keyed and indexed access, as well as Operand/String -> Output mapping, which depends on the Graph instance.  If we do end up having tensor containers, I think they would be best used as the backing List/Map in Result, rather than replacing it.

Thanks @Craigacp and @rnett for your good feedbacks. My belief is that if we are about to improve the usability of our API, we should focus more on the functions than on the graph and sessions. @rnett to answer your question, yes, the goal of a ConcreteFunction is to mimic a little bit what Python does, i.e. convert easily a function that can be called eagerly or backed by a graph. Right now, only graph mode is supported by ConcreteFunction but nothing prevents a user to call directly the same method passed as the functionBuilder with an eager session to execute it eagerly. Though I would prefer to make the eager support more explicitly integrated with the function concept. Now should we use an annotation or not, like Python does, I guess it could work but I didn't tried to think how this would fit in the actual design.
Now for the differences in resource management between the inputs and outputs, I was also aware of this detail. For the sake of brainstorming, maybe reference count could be useful here. For example, when we pass a tensor to a bundle, we could just increase the reference count so the tensor gets only released once all references are released. Also, ConcreteFunction has already its way to release or not its resources (the graph and the session) depending on how it has been allocated... I don't have the complete paradigm in mind but we can continue to think about it if we all think that could be something useful, wdyt?

Thanks @Craigacp and @rnett for your good feedbacks. My belief is that if we are about to improve the usability of our API, we should focus more on the functions than on the graph and sessions. @rnett to answer your question, yes, the goal of a ConcreteFunction is to mimic a little bit what Python does, i.e. convert easily a function that can be called eagerly or backed by a graph. Right now, only graph mode is supported by ConcreteFunction but nothing prevents a user to call directly the same method passed as the functionBuilder with an eager session to execute it eagerly. Though I would prefer to make the eager support more explicitly integrated with the function concept. Now should we use an annotation or not, like Python does, I guess it could work but I didn't tried to think how this would fit in the actual design.
Now for the differences in resource management between the inputs and outputs, I was also aware of this detail. For the sake of brainstorming, maybe reference count could be useful here. For example, when we pass a tensor to a bundle, we could just increase the reference count so the tensor gets only released once all references are released. Also, ConcreteFunction has already its way to release or not its resources (the graph and the session) depending on how it has been allocated... I don't have the complete paradigm in mind but we can continue to think about it if we all think that could be something useful, wdyt?

I made #181 for the functional API discussion.  I don't think any of what we discussed here is blocking this PR?

I made #181 for the functional API discussion.  I don't think any of what we discussed here is blocking this PR?

I made #181 for the functional API discussion.  I don't think any of what we discussed here is blocking this PR?

I don't want to block the progress of the good work being done here, but I admit I would feel more comfortable adding all these new utilities if I could clearly understand how they would fit in an architecture that promotes the functional API. What about we continue the discussion in #181 a bit further before merging this one?

I made #181 for the functional API discussion.  I don't think any of what we discussed here is blocking this PR?

I don't want to block the progress of the good work being done here, but I admit I would feel more comfortable adding all these new utilities if I could clearly understand how they would fit in an architecture that promotes the functional API. What about we continue the discussion in #181 a bit further before merging this one?

I made #181 for the functional API discussion.  I don't think any of what we discussed here is blocking this PR?

I don't want to block the progress of the good work being done here, but I admit I would feel more comfortable adding all these new utilities if I could clearly understand how they would fit in an architecture that promotes the functional API. What about we continue the discussion in #181 a bit further before merging this one?

I made #181 for the functional API discussion.  I don't think any of what we discussed here is blocking this PR?

I don't want to block the progress of the good work being done here, but I admit I would feel more comfortable adding all these new utilities if I could clearly understand how they would fit in an architecture that promotes the functional API. What about we continue the discussion in #181 a bit further before merging this one?

Fine by me, although I think we'll want something similar (and nice to use) for Session regardless of what the functional API looks like.  There's always going to be someone who has to run things manually.

Fine by me, although I think we'll want something similar (and nice to use) for Session regardless of what the functional API looks like.  There's always going to be someone who has to run things manually.

@karllessard after the discussion and looking further at ConcreteFunction, I don't think we need to wait on this.  I do think ConcreteFunction could use a Result class that is essentially TensorMap which throws on missing keys, but that will differ from this enough that there's not much to be shared (the inner map for that will be String -> Tensor, for this it's Output -> Tensor, and we have indices).

@karllessard after the discussion and looking further at ConcreteFunction, I don't think we need to wait on this.  I do think ConcreteFunction could use a Result class that is essentially TensorMap which throws on missing keys, but that will differ from this enough that there's not much to be shared (the inner map for that will be String -> Tensor, for this it's Output -> Tensor, and we have indices).

Hi @rnett , I prefer to continue keeping that PR on hold for now, as #188 seems to slowly converges towards it but with some redesign. I'm sorry if the PRs are not merged as fast as you would hope but these are addressing important core aspects that requires greater attention and reflection from our end.

Hi @rnett , I prefer to continue keeping that PR on hold for now, as #188 seems to slowly converges towards it but with some redesign. I'm sorry if the PRs are not merged as fast as you would hope but these are addressing important core aspects that requires greater attention and reflection from our end.

No worries, I just wanted to make sure that something was indeed blocking it.

No worries, I just wanted to make sure that something was indeed blocking it.


Update Textfields on the Components Page

Change mdl-textfield__label  font-weight to: 400;
Lets make each text field 260px wide
Numeric with floating label seems like it's missing the floating label:

Seems like the multiple expanding element is missing. Can we add this one instead of the search icon, and move the search example onto another line like in the mock:
https://folio.googleplex.com/mdlmicrosite#%2F02 Components - 11Textfields.png

Spacing between the footer and the content should be 120px

Hi @santokii, could you please share the mock in public?

Superseded by #4479.


Add IPv6 support

This PR adds support for IPv6 (CF IPv6 addresses were already available, but unused). But also fixes the CIDR library from raising (ArgumentError) Argument must be a binary or IP tuple of the same protocol when connected through IPv6 but comparing with IPv4 CIDR ranges.
I've also added an additional CF IPv6 CIDR range.

Thanks!

@c-rack Excuse me for asking, when can a new release be expected? The last release 1.3.0 on hex was released on 24 February 2016 (more than 4 years ago) and is missing some of the improvements made since then (i.e. elixir compilation time warnings).


scheduler: fix remove node

Signed-off-by: runshenzhu<EMAIL_ADDRESS>

ping @aaronlehmann @stevvooe

[Current coverage][cc-pull] is 53.85%

Merging [#1039][cc-pull] into [master][cc-base-branch] will increase coverage by 0.02%

@@             master      #1039   diff @@
==========================================
  Files            75         75
  Lines         11660      11669     +9
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6276       6284     +8
- Misses         4480       4488     +8
+ Partials        904        897     -7

[][cc-pull]

Powered by Codecov. Last updated by [bd1c047...f0f41f4][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/bd1c04747f49a4e30e04acdcc5bdb233b712c238...f0f41f4b8d2f79f30c879ee797ec18a4d946b374
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1039?src=pr

LGTM
I think this was a carryover from before when we tracked the number of tasks in a separate variable. I think we used to set that variable to -1, guaranteeing this would become the first item. Using Remove is much cleaner anyway. Thanks for finding this.

LGTM


_scripts: Take care of posts in subdirectories

We could create subdirectories inside _post directory and add
posts inside those. Take care of those posts while creating
categories and tags.
Signed-off-by: Vijai Kumar K<EMAIL_ADDRESS>

It's duplicate #41


Add SetQueueAttributesV1 for JSON support

@andrew-womeldorf I rebased and now I'm getting some race condition-y/index out of bound errors in my tests.  How did you fix your issues in particular?  I couldn't see much from the github history with all the squashing and things.

Interesting. The tests still pass fine on feature-aws-json, but I can reproduce the error locally when I checkout this branch. Looking...

Something is happening, though. If I comment out the failing test entirely, then the next test in that file fails with a similar cause.

If I reset the utils.REQUEST_TRANSFORMER = utils.TransformRequest at the top of the test, everything passes like normal. I'm assuming some test isn't resetting that properly. Looking...


Execution

Description

Related Issue

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[ ] I have read the Code of Conduct
[ ] I have updated the documentation accordingly.
[ ] All commits are GPG signed

Hello @2lambda123! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file proof_pile_2/algebraic_stack/process_isabelle_proofsteps.py:

Line 13:1: E302 expected 2 blank lines, found 1
Line 22:13: E225 missing whitespace around operator
Line 24:15: E225 missing whitespace around operator
Line 28:1: W293 blank line contains whitespace
Line 66:1: E302 expected 2 blank lines, found 1
Line 69:80: E501 line too long (81 > 79 characters)
Line 76:1: E302 expected 2 blank lines, found 1
Line 85:1: W293 blank line contains whitespace
Line 93:80: E501 line too long (88 > 79 characters)
Line 114:1: E302 expected 2 blank lines, found 1
Line 114:80: E501 line too long (82 > 79 characters)
Line 118:55: E261 at least two spaces before inline comment
Line 118:80: E501 line too long (90 > 79 characters)
Line 146:80: E501 line too long (83 > 79 characters)
Line 156:80: E501 line too long (95 > 79 characters)
Line 157:80: E501 line too long (82 > 79 characters)
Line 161:80: E501 line too long (100 > 79 characters)
Line 166:80: E501 line too long (84 > 79 characters)


KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.17

This PR updates from Scala 2.12.15 to 2.12.16. Since its a binary compatible change there shouldn't be any problems.
Release notes can be found here https://github.com/scala/scala/releases/tag/v2.12.16
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@mdedetrich could you please re-run the tests (by pushing another commit or by rebasing from trunk & force pushing). It would be ideal if we have a clean test run (with known flaky failures) before we approve this.

@divijvaidya Done

cc: @ijuma (since you seem have performed scala upgrades in the past)
The test failures do not seem related to this code change to me.

I notice there's a regression:

Scala 2.12.16 contains a https://github.com/scala/bug/issues/12605 that was discovered after the artifacts were published. Only mixed compilation of Scala and Java source files together is affected, and only when the Scala code contains references to certain nested classes in the Java sources. The problem manifests as a compile-time type error. Follow link for details and workarounds. We'll fix the problem in Scala 2.12.17 which we expect to release in a few months.

Is there something you're looking for in 2.12.16?

Is there something you're looking for in 2.12.16?

So I already had a detailed look into this, it only occurs at compile time (see https://github.com/scala/bug/issues/12605#issuecomment-1151427077) which means that unless you get that specifically mentioned compile error there is no adverse effect. You can see the precise details with the linked ticket at https://github.com/scala/bug/issues/12605 but in summary Kafka is completely unaffected by this.

Yes, kafka is unaffacted by it now, but it could be affected in the future.

The fix for this has already been merged into Scala and it will be included in the 2.12.17 release which is being expedited. So while its theoritically possible Kafka could be effected by this change if you do write very specific Scala code that hits this bug, i.e.
public class C {
  public class I { public class J {} }
  public void t(I.J j) {}
}

Its highly unlikely this would happen before Scala 2.12.17 is released (current eta 2-3 months) and the appropriate version bump is put into Kafka

If there's a clear benefit for going with 2.12.16, we can go ahead though. Is there?

So according to the release notes this release of Scala mainly addressed JDK related issues, i.e.

This release improves compatibility with recent JDKs:

Use ASM 9.3, enabling JDK 19 support (https://github.com/scala/scala/pull/10000)
Make -target support JDK 8 through 19 (and deprecate 5 through 7) (https://github.com/scala/scala/pull/9916)
Fix codegen for MethodHandle.invoke (et al) under JDK 17 -release (https://github.com/scala/scala/pull/9930)
Deprecate AnyVal#formatted(formatString), to avoid conflict with JDK 15+ method (https://github.com/scala/scala/pull/9783)

So I would there is clear benefit for people that happen to be using newer JDK versions.

Can you also update bin/kafka-run-class.sh and bin/windows/kafka-run-class.bat?

@mimaison

Can you also update bin/kafka-run-class.sh and bin/windows/kafka-run-class.bat?

I just checked those files and it seems that this is not necessary because we are not updating the latest Scala series but the one behind it. Kafka supports Scala 2.13.x and 2.12.x with 2.13.x being the default which is the version being referenced in bin/kafka-run-class.sh/bin/windows/kafka-run-class.bat. This PR however only updates Scala 2.12.x (specifically 2.12.5 to 2.12.16)

Ah yes, you're right! My bad

@ijuma @mimaison Any chance of a review?

Scala 2.12.17 just came out so I have rebased the PR with the new Scala version. This also means that all of the qualms mentioned in https://github.com/apache/kafka/pull/12284#issuecomment-1158283064 aren't relevant anymore.

We upgrade to Scala 2.12.18 in https://github.com/apache/kafka/commit/dfaae317b82035323ba9c693b3ad7f02a6a58395. Closing this PR.


[Bug]: Run button not disabled in response pane

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When there is no query is added in the query input box, run button on top query page is getting disabled. But the same behaviour is not maintained for the run button in response pane.
Steps To Reproduce

Goto and postgres query
Delete the content inside query input
Observe run button in response pane

Public Sample App
No response
Environment
Production
Severity
Low (Cosmetic UI issues)
Issue video log
No response
Version
Appsmith v1.42.0-SNAPSHOT

Hello @albinAppsmith - I believe, I can fix this issue. Please assign it to me.

@Jai-Marothiya thank you, and go for it! :)

@rohan-arthur  - I tried to set up project but there is some issue in my system due to which I am not able to set up project.


(EventHubs) Address T1 doc staleness. (Broken/semantically incorrect links)

it's a duplication of https://github.com/Azure/azure-sdk-for-python/issues/13738, closing it now

closing the issue as currently we have no release plan for t1 servicebus and eventhub


[stable/elasticsearch] add optional additional anti affinities

What this PR does / why we need it:
Allows users to specify additional anti affinity topology keys and weights.
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

@simonswine @icereval @rendhalver @desaintmartin

Ping...


PDF Download of a form should include information about "required" or "optional" questions

Description
Added an isOptional line that describes whether the question is optional or not in the program preview pdf.
Release notes
Added an isOptional line that describes whether the question is optional or not in the program preview pdf.
Checklist
General
Read the full guidelines for PRs here

[x] Added the correct label: < feature | enhancement | bug | under-development | dependencies | infrastructure | ignore-for-release | database >
[x] Assigned to a specific person, civiform/developers, or a more specific round-robin list
[x] Added an additional reviewer from outside your organization as FYI (if the primary reviewer is in the same organization as you)
[x] Created unit and/or browser tests which fail without the change (if possible)
[x] Performed manual testing (Chrome and Firefox if it includes front-end changes)
[ ] Extended the README / documentation, if necessary

Issue(s) this completes
Fixes #7365

Could you share the PDF that gets generated with this change?

Could you share the PDF that gets generated with this change?

comprehensive-sample-program-2024-07-23T17_29_17.014702568.pdf

I'd like the formatting to match the other attributes below it

comprehensive-sample-program-2024-07-24T13_45_18.443239061.pdf


fix(metadata): add metadata.getOrCreateOwn 's optional targettKey for TS

Could you explain this a bit in the description please?

@RWOverdijk happy with the explanation, can it be merged?


Is it possible to redirect to a new site instead of closing and creating a new browser instance?

Steps to reproduce
Tell us about your environment:

Puppeteer version: v10.1.0
Platform / OS version: WIndows 10 21H1
URLs (if applicable):
Node.js version: v16.4.2

I'm interacting with a site that uses one-time download buttons with "keys" that will no longer work upon a new browser instance or upon a refresh of the browser. Is there any way to redirect to a site in that same browser instance instead of closing and making a new one?

Actually just realized I could use page.click instead, closing.


Add OSG 24 upgrade documentation

Assigning to @matyasselmeci so that I can focus on CHTC Ceph issues

Link check failures unrelated.


Use with UIViewController and UICollectionView

Here is my code and the error it gives me, any suggestions?
    override func viewDidLoad() {
        super.viewDidLoad()

        // Do any additional setup after loading the view.
        self.collectionView = myCollectionView // It is an IBOutlet

        featureHeight = 240
        collapsedHeight = 100
    }

 UICollectionViewController loadView] instantiated view controller with identifier "ShopViewController" from storyboard "Main", but didn't get a UICollectionView

on what line do you get that error?

In AppDelegate, where I am instantiating ViewControllers programatically.

@paulthorsteinson Hey there i got the same issue when i initialize my subclass of RPSlidingMenuViewController. MySubclass is done with XIB, collectionView is connected like in ur Demo, but i get the same issue as @RayanSaeed futhermore i tried many ways of initializing it, and changing outlets connections and so on... Please help

It appears this occurs when you try to use a UICollectionViewController, the the view outlet isn't connected to a UICollectionView
http://stackoverflow.com/questions/24989741/error-when-set-uicollectionviewcontroller-nib-but-didnt-get-a-uicollectionvie
http://stackoverflow.com/a/18284510/6804257
Here is a screenshot where I was getting this same error.  My "Photo Tour" is a subclass of UICollectionViewController, which it should not be.  I fixed by changing Photo Tour to be a UIViewController and UICollectionViewDelegate, as you can see I also wanted  map and button in the same view.

The app I am working on is still in development, but I just made a commit where I think I have fixed this error in my own project.
https://github.com/jfosterdavis/VirtualTourist/commit/599ab9229a9833b0c3291c9d8f693e4ed3a60328


RAIN-1216: Updated README.md file and added LOCALSETUP.md file for MD…

…MS service

Closing this PR as it changes are already done

Closing this PR as it changes are already done


Condense Location dropdown options

At the moment abbreviations and full state names show. (Eg. CA & California)

[x] Condense them so they only show the full state name.

[x] Fix the issue with "Unknown" (AngelList)

[x] Figure out how we want to handle AngelList's location as they show up like (Canada • United States • London • Remote)

"Figure out how we want to handle AngelList's location as they show up like (Canada • United States • London • Remote)" will be addressed in #49


move to apiextensions.k8s.io/v1 and admissionregistration.k8s.io/v1

We need to start using apiextensions.k8s.io/v1 instead of apiextensions.k8s.io/v1beta1, because v1beta1 will be gone in K8s 1.22.
Need to figure out what the upgrade implications are for existing CRDs.

I don't think there are upgrade implications. We'd have to raise our K8s version support floor to 1.16 though.

Either that, or we could get fancier with our make-deploy and detect supported APIs, using the beta or final CRD API version accordingly.

Similar issue for admissionregistration.k8s.io/v1beta1 objects like MutatingWebhookConfiguration. Not sure when v1 was introduced there, but it's certainly in 1.16 so that would still work as a support floor. That will require (minor) code changes. Fortunately that won't require an upgrade of our operator SDK version since we already use the 1.16 API. We do want to upgrade our operator SDK dependency but it's nice not to have this minor change depend on that.

Working on this at https://github.com/joel-bluedata/kubedirector/tree/apiver

One thing I'm pondering is whether to set x-kubernetes-preserve-unknown-fields in the CRD schemas, to preserve the old behavior where unknown fields are not dropped from incoming CRs. In v1 by default they are dropped and not stored in etcd (and in fact can't even get past kubectl input validation unless you use --validate=false).
There a good reasons to prevent/drop unknown fields, e.g. the discussion in https://kubernetes.io/blog/2019/06/20/crd-structural-schema/ so I probably will leave the new v1 default behavior in place.


Clang-tidy does not work with MSVC toolchain

I have some issues with Clang-tidy when I use this toolchain. Do you know what is going on?
https://github.com/cpp-best-practices/project_options/pull/34#issuecomment-1003503538
FAILED: CMakeFiles/main.dir/Debug/main.cpp.obj
"C:\Program Files\CMake\bin\cmake.exe" -E __run_co_compile --launcher=C:/tools/msys64/mingw64/bin/ccache.exe --tidy="C:/Program Files/LLVM/bin/clang-tidy.exe;-extra-arg=-Wno-unknown-warning-option;-extra-arg=-std=c++17;--extra-arg-before=--driver-mode=cl" --cppcheck="C:/Program Files/Cppcheck/cppcheck.exe;--suppress=missingInclude;--enable=all;--inline-suppr;--inconclusive;--std=c++17" --source=C:\project_options\test\main.cpp -- C:\PROGRA~1\MIB055~1\2022\COMMUN~1\VC\Tools\MSVC\1430~1.307\bin\Hostx64\x64\cl.exe  /nologo /TP -DFMT_LOCALE -DFMT_SHARED -DCMAKE_INTDIR=\"Debug\" -external:I "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\ATLMFC\include" -external:I "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\include" -external:I "C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\ucrt" -external:I "C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\shared" -external:I "C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\um" -external:I "C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt" -external:I "C:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\cppwinrt" -external:I C:\project_options\test\build\vcpkg_installed\x64-windows\include -external:I C:\project_options\test\build\vcpkg_installed\x64-windows\share\eigen3\..\..\include\eigen3 -external:W0 /DWIN32 /D_WINDOWS /EHsc /Zi /Ob0 /Od /RTC1 -MDd /diagnostics:column /W4 /w14242 /w14254 /w14263 /w14265 /w14287 /we4289 /w14296 /w14311 /w14545 /w14546 /w14547 /w14549 /w14555 /w14619 /w14640 /w14826 /w14905 /w14906 /w14928 /permissive- -std:c++17 /showIncludes /FoCMakeFiles\main.dir\Debug\main.cpp.obj /FdCMakeFiles\main.dir\Debug\ /FS -c C:\project_options\test\main.cpp
warning: unknown argument ignored in clang-cl: '-std=c++17' [clang-diagnostic-unknown-argument]
C:\project_options\test\main.cpp:2:10: error: 'fmt/core.h' file not found [clang-diagnostic-error]
#include <fmt/core.h>
         ^~~~~~~~~~~~
23598 warnings and 1 error generated.
Error while processing C:\project_options\test\main.cpp.
Suppressed 23597 warnings (23597 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
Found compiler error(s).
ninja: build stopped: subcommand failed.

Clang tidy is set here:
https://github.com/cpp-best-practices/project_options/blob/c88a46f951c75a8d43dc0b2282a81f49ceba20f7/src/StaticAnalyzers.cmake#L21

It looks like clang-tidy is being run with --driver-mode=cl so that it's using clang-cl as the driver. And that seems like a reasonable thing to do, since the build is using cl.exe as the compiler. I imagine that there's logic in whatever consumes CMAKE_CXX_CLANG_TIDY that makes this determination - probably using CMAKE_<LANG>_COMPILER_ID or CMAKE_<LANG>_COMPILER_FRONTEND_VARIANT that CMake sets when it's identifying the compiler.
But clang-cl complains that the -std=c++17 isn't known - and that's because that appears to be the clang not clang-cl option to the compiler. clang-cl would probably expect /std:c++17.
From the link you provided to the StaticAnalyzers.cmake, it's got this logic in the enable_clang_tidy macro:
    set(CMAKE_CXX_CLANG_TIDY ${CLANGTIDY} -extra-arg=-Wno-unknown-warning-option)
    if(${CMAKE_CXX_STANDARD})
      set(CMAKE_CXX_CLANG_TIDY ${CMAKE_CXX_CLANG_TIDY} -extra-arg=-std=c++${CMAKE_CXX_STANDARD})
    endif()
    if(WARNINGS_AS_ERRORS)
      list(APPEND CMAKE_CXX_CLANG_TIDY -warnings-as-errors=*)
    endif()

So it's explicitly adding clang-parameters to CMAKE_CXX_CLANG_TIDY, and not checking to see if the compiler expects clang or clang-cl style options. Since the CMAKE_CXX_CLANG_TIDY-consuming logic accommodates clang or clang-cl, then StaticAnalyzers.cmake should probably accommodate both, too.
That explains the warning: unknown argument ignored in clang-cl: '-std=c++17' warning. It's not clear why the header isn't found - is it protected with a check for C++17? I think getting the C++ standard set correctly might help, so addressing the warning first would probably help. Or at least be insightful.

Ah, it looks like the CMake compiler scripts set CMAKE_CXX_CLANG_TIDY_DRIVER_MODE to cl when the C++ front-end is MSVC-like. Perhaps StaticAnalyzers.cmake should check that to see what format options to specify?

Ah, it looks like the CMake compiler scripts set CMAKE_CXX_CLANG_TIDY_DRIVER_MODE to cl when the C++ front-end is MSVC-like. Perhaps StaticAnalyzers.cmake should check that to see what format options to specify?

Thank you. I think this was fixed in
https://github.com/cpp-best-practices/project_options/pull/54

There is one more warning that I get:
https://github.com/cpp-best-practices/project_options/pull/34#pullrequestreview-871497483
Could you take a look and see if you know the reason for it?


chore: Update webEOC Incident URL

Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Frontend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

Note - Cypress Tests failing as Dev Static isn't updated yet


samples: net: mqtt_publisher: fix printk invoked with an undefined argument

Printk is invoked with an undefined argument.

Codecov Report

Merging #14538 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14538      +/-   ##
==========================================
+ Coverage   51.99%   52.02%   +0.03%
==========================================
  Files         309      309
  Lines       45574    45574
  Branches    10555    10555
==========================================
+ Hits        23695    23711      +16
+ Misses      17069    17057      -12
+ Partials     4810     4806       -4

Impacted Files
Coverage Δ

subsys/testsuite/ztest/src/ztest.c
72.72% <0%> (+7.43%)
:arrow_up:

subsys/testsuite/ztest/include/ztest_assert.h
77.77% <0%> (+38.88%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc59d7...a1e131c. Read the comment docs.


Added PDLL to mpl_plugins (rewrite pattern for various dialects)

Added pdll linalg conversion code (compiles to pdl) that performs match and rewrite. Also modified the CMakeLists.txt to add test cases for linalg.
Todo

[x] Add pdll support for the tosa/torch test cases
[x] Remove build of pdll file from mmake, have ctest/filecheck build the file

oops my bad, messed up the merge, sorry spamming requests


Add some sort of generic team/product/site/whatever identifier grain

Related to https://github.com/hubblestack/hubble/pull/197
We should add something more generic that you can add to your config and it will be added to grains. We can even fall back to this in our splunkindex grain.

This is solved with the splunkindex grain


Optimized saving relations when order has not changed

if the order of the relations is the same, we don't need to update the sort_order on the pivot, which we currently do all the time
this saves an update statement for every relation item a model has

Closing as tests reveal a bug I'm not sure how to fix right now


Visual result

Hello, first of all thank you very much for the code and then I would like to ask how can I get this visualization result

Thank you for your interest of our paper. The visualization is based on the raw output of our model or the baseline. However, we have no plan to release the visualization code. You could try to implement it by yourself if you need to visualize your own model.


When will the code be available here?

looking forward to your great work be available

Code is available now


METRON-2278: "Metron on CentOS 6" Documentation is outdated

Problem
The installation instruction for installing Java8 on the MacOS while setting up the Vagrant Environment is incorrect/obsolete. Moreover, while installing ansible, the version number is provided with the '=' instead of '==', which results in the installation being failed.
Solution
Introduced the new way to install Java8 which works fine during the Vagrant Environment setup. Fixed the '=' to '==' for ansible too.
Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our Development Guidelines for the complete guide to follow for contributions.
Please refer also to our Build Verification Guidelines for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
For all changes:

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.
[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

For code changes:

[ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?

[ ] Have you included steps or a guide to how the change may be verified and tested manually?

[ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh

[ ] Have you written or updated unit tests and or integration tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

[ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

[ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using draw.io? See Metron Development Guidelines for instructions.

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that travis-ci is set up for your personal repository such that your branches are built there before submitting a pull request.

I've witnessed it. I can give it a non-binding +1. 👍

+1. Confirmed these updates by setting up my own computer from scratch and running into the same issues.

Good catch @subhashjha35, thanks for the fix!


message view: Top navbar covers lightbox in mobile view

I don't have the navbar, maybe a iOS/safari issue?
Unrelated, but the bottom controls and thumbnail is half covered with no way of scrolling down.

@zulipbot claim.


Update Readme and community_sharings.rst for 2.0 release

comments fixed, if we can make the contributors picture before others PR done, we need to update the file again. if not, we can skip update the contributors section later. @kvartet

comments fixed, if we can make the contributors picture before others PR done, we need to update the file again. if not, we can skip update the contributors section later. @kvartet

comments fixed, if we can make the contributors picture before others PR done, we need to update the file again. if not, we can skip update the contributors section later. @kvartet

Added.

comments fixed, if we can make the contributors picture before others PR done, we need to update the file again. if not, we can skip update the contributors section later. @kvartet

Added.


fix(ui-shell): keep side-nav-menu open when on focusout

Related Ticket(s)
[cwc-v2]: The cds-side-nav-menu collapses when click outside#10612
Description
Issue:

open side-nav-menu
click outside of the side-nav
see that the side-nav-menu closes

https://github.com/carbon-design-system/carbon-for-ibm-dotcom/assets/1007051/f096c227-0f15-417a-8c3f-745cd4e7781c
Changelog
Changed

only toggle the expanded for certain collapse modes so that the menu still collapses in mobile view when user focuses out
remove the updatedSideNavMenuForceCollapsedState() from firing whenever the expand toggles - not necessary to fire then

Thanks for this!


Flags -> LaneConnectionManager

Remove all lane connection logic from the Flags class and set up a framework in LaneConnectionManager that can support connection flags and other new features.
see #1392

I converted this to draft because this is a duplicate of my PR.
If you don't intend to merge this code please close the PR.

It could be merged, so closing it seems unnecessary until another merge makes it obsolete. But making it Draft is the right thing to do, since I think even if it were to be used, it shouldn't be merged until the LaneConnection class has been taken out of the API. It is an implementation detail that should not be made public.

This has been abandoned in favor of a different approach to displaced lane support that does not directly involve LaneConnectionManager


Use strongly-typed enum flags.

#339 might not be ideal because the "options" can be arbitrary ints, rather than combinations of the options that we actually enumerate. If that's a problem, maybe something like this would be better?

This PR follows the blog post above. I think the biggest annoyance with this implementation is that there's no contextual conversion to bool, so you can't write something like if (mOptions & Options::POSITIONS). My intermediate workaround is to require Options::NONE = 0 and compare directly to that.
I'm not entirely convinced whether this complication is worth it. @jslee02, what do you think?

Before creating a pull request

[x] Document new methods and classes
[ ] Format code with make format

Before merging a pull request

[x] Set version target by selecting a milestone on the right side
[ ] Summarize this change in CHANGELOG.md
[x] Add unit test(s) for this change

Just curious, can you implement something like the following to make that explicit boolean cast work?
https://stackoverflow.com/a/9883421

Outdated, to consider for later


Allow if .. then .. else at the top level

Since if is similar to for in its control-like nature and we allow
the latter, allow writing if at the top level without an extra
select, which is especially useful with the recent ability to do
conditional DDL.
edgedb> if user_id
....... then (select User filter .id = user_id)
....... else (insert User)

Typo in the commit message: conditional DML

Can you add one functional test?


Different performances speed on Keras and Tensorflow

Hello!
I am currently train a network in Keras, but when i look in nvidia-smi the Volatile Gpu Utils is around 50%. No matter how hard i try, i cannot pass that limit. On the other hand, using Tensorflow on the same model, with the same parameters and everything, i reach 100%. The problem is that in Tensorflow the training is faster with around 50%, so i don't think that those numbers are "errors" provided by nvidia-smi. What could be the problem?

@MerceaOtniel Is this still an issue? Could you check with recent version of TF and Keras, and let us know if the issue still persists. thanks!

I don't know if this is still an issue. I managed to run the code and work on the project using Tensorflow. It was not necessarily a problem, but it seemed odd because TF could use all my GPU and Keras was limited to 90% no matter what. It was more of a curiosity than an actual issue. I don't have the last version of TF, but i had Keras 2.2.4 when i obtained these results. The problem was not performance, but performance was poor due to the fact that Keras was unable to make use of the whole GPU. Right now i cannot install last version of TF to check. I will try in a week, if you have it already installed, then you can test it.

For now I will close the issue. If anyone face the same issue, please fill the template and provide a reproducible code. Thanks!


Remove support for Python 3.7, add Python 3.10 and 3.11

Description

This PR tries to add the support for Python 3.10 and 3.11, and drop the support for Python 3.7 since it'll reach the end of life on Jun 27.
This PR is moved from https://github.com/recommenders-team/recommenders/pull/1937, because of the sign-off requirement.

[ ] Update docs
[ ] Update Conda env script

Related Issues

https://github.com/microsoft/recommenders/issues/1919

References

Python endoflife.date

Checklist:

[X] I have followed the contribution guidelines and code style for this project.
[ ] I have added tests covering my contributions.
[ ] I have updated the documentation accordingly.
[X] This PR is being made to staging branch and not to main branch.

When using Python 3.11, some package requires numpy 1.19.4 which may not support Python 3.11.  See https://github.com/recommenders-team/recommenders/actions/runs/6079503723/job/16492093035

When using Python 3.11, some package requires numpy 1.19.4 which may not support Python 3.11. See https://github.com/recommenders-team/recommenders/actions/runs/6079503723/job/16492093035

I see two options:

Start with 3.8-3.10, and leave 3.11 to a future PR
Consider adding different numpy versions depending on the python version as we did with cornac:

    "cornac>=1.1.2,<1.15.2;python_version<='3.7'",
    "cornac>=1.15.2,<2;python_version>='3.8'",

What do you think @SimonYansenZhao?

When using Python 3.11, some package requires numpy 1.19.4 which may not support Python 3.11. See https://github.com/recommenders-team/recommenders/actions/runs/6079503723/job/16492093035

I see two options:

Start with 3.8-3.10, and leave 3.11 to a future PR
Consider adding different numpy versions depending on the python version as we did with cornac:

    "cornac>=1.1.2,<1.15.2;python_version<='3.7'",
    "cornac>=1.15.2,<2;python_version>='3.8'",

What do you think @SimonYansenZhao?

@miguelgfierro I tried option 2, but failed, see https://github.com/recommenders-team/recommenders/actions/runs/6079732708/job/16496793669?pr=1988
I'll try python 3.8 - 3.10 in this PR and leave 3.11 in another future PR.

Some notes from the test results:

Some dependencies require numpy of some old version which does not support Python 3.10+, so numpy needs to be compiled against Python 3.10+ to build its binary file during setup of recommenders.  We need to find out which dependences require old version of numpy.
scrapbook is very old and is not actively developed now.  Some code of scrapbook uses DataFrame.append() which is removed from pandas.  An alternative to scrapbook should be used, or we should bypass the code in scrapbook that uses DataFrame.append().

I asked ChatGPT how to replace papermill and scrapbook, and it looks that there is a dependency that we already have called nbconvert. This would be the code:
import nbformat
from nbconvert.preprocessors import ExecutePreprocessor

# Step 1: Prepare Your Jupyter Notebook

# Ensure your Jupyter Notebook is set up with parameters that can be modified and read.
# Use Markdown cells to specify parameters that need modification and code cells to set parameters that need to be read.

# Step 2: Modify Parameters Programmatically

# Load the Jupyter Notebook
notebook_path = "your_notebook.ipynb"
with open(notebook_path, "r") as notebook_file:
    notebook_content = nbformat.read(notebook_file, as_version=4)

# Define the parameters to modify
new_param1 = "New Value1"
new_param2 = "New Value2"

# Search for and replace parameter values in code cells
for cell in notebook_content.cells:
    if cell.cell_type == "code":
        cell.source = cell.source.replace("param1 = 'Default Value'", f"param1 = '{new_param1}'")
        cell.source = cell.source.replace("param2 = 'Default Value'", f"param2 = '{new_param2}'")

# Save the modified notebook
modified_notebook_path = "modified_notebook.ipynb"
with open(modified_notebook_path, "w", encoding="utf-8") as modified_notebook_file:
    nbformat.write(notebook_content, modified_notebook_file)

print("Parameters modified and saved to", modified_notebook_path)

# Step 3: Execute the Modified Notebook with nbconvert

# Load the modified notebook
with open(modified_notebook_path, "r") as modified_notebook_file:
    modified_notebook_content = nbformat.read(modified_notebook_file, as_version=4)

# Create an execution preprocessor
execute_preprocessor = ExecutePreprocessor(timeout=600, kernel_name="python3")

# Execute the notebook
executed_notebook, _ = execute_preprocessor.preprocess(modified_notebook_content, {"metadata": {"path": "./"}})

# Save the executed notebook
executed_notebook_path = "executed_notebook.ipynb"
with open(executed_notebook_path, "w", encoding="utf-8") as executed_notebook_file:
    nbformat.write(executed_notebook, executed_notebook_file)

print("Notebook execution complete. Results saved to", executed_notebook_path)

# Step 4: Read Parameters Programmatically

# Load the executed notebook
with open(executed_notebook_path, "r") as executed_notebook_file:
    executed_notebook_content = nbformat.read(executed_notebook_file, as_version=4)

# Extract parameter values from code cells
param3 = None
for cell in executed_notebook_content.cells:
    if cell.cell_type == "code":
        if "param3" in cell.source:
            # Extract param3 value from code cell
            exec(cell.source)
            break

# Now you can use param3 in your workflow
if param3 is not None:
    print("Value of param3:", param3)
else:
    print("param3 not found in the executed notebook.")

what do you think @SimonYansenZhao?

@SimonYansenZhao @anargyri I'm trying to replicate papermill https://github.com/miguelgfierro/pybase/pull/73 if I do the basic functionality, we can remove 2 deps, and will depend only on nbconvert, which is a library supported by Jupyter, and re. Still WIP.

@miguelgfierro I think using nbconvert is doable.  But now could you help me with the errors in the test result: https://github.com/recommenders-team/recommenders/actions/runs/6116241630/job/16601154561?pr=1988#step:3:2654
NameError: name 'XDeepFMModel' is not defined

And I find ploomber may be used to replace scrapbook.

scrapbook is very old and is not actively developed now.  The latest version was published in 2021.  Some code of scrapbook uses DataFrame.append() (See https://github.com/recommenders-team/recommenders/actions/runs/6108846153/job/16578689728?pr=1988#step:3:2639) which is removed from pandas since pandas 2.0.  So an alternative to scrapbook should be used, or we should bypass the code in scrapbook that uses DataFrame.append().

But you have pandas < 1.6 in setup.py, don't you? Or I am missing something?

3. scrapbook is very old and is not actively developed now.  The latest version was published in 2021.  Some code of scrapbook uses DataFrame.append() (See https://github.com/recommenders-team/recommenders/actions/runs/6108846153/job/16578689728?pr=1988#step:3:2639) which is removed from pandas since pandas 2.0.  So an alternative to scrapbook should be used, or we should bypass the code in scrapbook that uses DataFrame.append().

But you have pandas < 1.6 in setup.py, don't you? Or I am missing something?

@anargyri after I found pandas 2.0 didn't work for scrapbook, I tried to set pandas < 1.6 in setup.py to see if pandas < 1.6 would work.  Now scrapbook works with pandas < 1.6, but we cannot use pandas 2.0+ in the future if scrapbook won't upgrade.

I'm looking into this:

@miguelgfierro I think using nbconvert is doable. But now could you help me with the errors in the test result: https://github.com/recommenders-team/recommenders/actions/runs/6116241630/job/16601154561?pr=1988#step:3:2654

(recommenders) u@unicorn:~/MS/recommenders$ python --version
Python 3.9.16
(recommenders) u@unicorn:~/MS/recommenders$ pip list | grep pandas
pandas                       1.5.3
(recommenders) u@unicorn:~/MS/recommenders$ pytest tests/unit/recommenders/models/test_deeprec_model.py::test_xdeepfm_component_definition --disable-warnings
=========================================================================== test session starts ===========================================================================
platform linux -- Python 3.9.16, pytest-7.3.2, pluggy-1.0.0
rootdir: /home/u/MS/recommenders
configfile: pyproject.toml
plugins: typeguard-4.0.0, cov-4.1.0, hypothesis-6.79.1, mock-3.11.1, anyio-3.7.0
collected 1 item

tests/unit/recommenders/models/test_deeprec_model.py .                                                                                [100%]

===================================================================== 1 passed, 20 warnings in 3.70s ======================================================================

I looked at LightGBM https://github.com/microsoft/LightGBM, and they have support for Python 3.7. Wouldn't it be easier if we keep 3.7?
Thoughts @SimonYansenZhao @anargyri

@miguelgfierro I cannot replicate the error NameError: name 'XDeepFMModel' is not defined, which is why I am always waiting for the test results in DevOps.

@miguelgfierro @anargyri I find ./tools/generate_conda_file.py is out of sync with setup.py.  Is it still needed?
As discussed in https://github.com/recommenders-team/recommenders/pull/1988#discussion_r1321739341, I only dropped the support for Python 3.7 in this PR, and will create another PR for adding support for 3.10.

@miguelgfierro @anargyri I find ./tools/generate_conda_file.py is out of sync with setup.py. Is it still needed?

No, we can drop it


"assert len(arr) == framesize" throws an error

Hello,
I tried to run the command "python3 inference_video.py --exp=1 --video=video.mp4" on my own custom video, but I got the error :
<EMAIL_ADDRESS>in /shared/httpd/arXiv2020-RIFE $ python3 inference_video.py --exp=1 --video=video.mp4
video.mp4, 642.0 frames in total, 29.850746268656717FPS to 59.701492537313435FPS
The audio will be merged after interpolation process
  0%|                                                                                | 0/642.0 [00:00<?, ?it/s][W NNPACK.cpp:80] Could not initialize NNPACK! Reason: Unsupported hardware.
Unhandled exception in thread started by <function build_read_buffer at 0x7f465cec4950>
Traceback (most recent call last):
  File "/home/devilbox/.local/lib/python3.7/site-packages/skvideo/io/ffmpeg.py", line 271, in _read_frame_data
    assert len(arr) == framesize
AssertionError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "inference_video.py", line 130, in build_read_buffer
    for frame in videogen:
  File "/home/devilbox/.local/lib/python3.7/site-packages/skvideo/io/io.py", line 253, in vreader
    for frame in reader.nextFrame():
  File "/home/devilbox/.local/lib/python3.7/site-packages/skvideo/io/ffmpeg.py", line 297, in nextFrame
    yield self._readFrame()
  File "/home/devilbox/.local/lib/python3.7/site-packages/skvideo/io/ffmpeg.py", line 281, in _readFrame
    s = self._read_frame_data()
  File "/home/devilbox/.local/lib/python3.7/site-packages/skvideo/io/ffmpeg.py", line 275, in _read_frame_data
    raise RuntimeError("%s" % (err1,))
RuntimeError
Killed

Does anyone know the reason ? It seems to be about the "framesize", but I don't know what it is exactly :/
Thanks for your help

This error is caused because sk-video can not open your video successfully. Would you mind upload your video to Google drive and send it to me?

This error is caused because sk-video can not open your video successfully. Would you mind upload your video to Google drive and send it to me?

Yes sure : https://drive.google.com/file/d/1QQ506nmI4K8YG3Lwpf1hVq24feiCCPdu/view?usp=sharing

Yes sure : https://drive.google.com/file/d/1QQ506nmI4K8YG3Lwpf1hVq24feiCCPdu/view?usp=sharing

Same issue here.

Same issue here.


Language Placeholder Mismatch in "Reason If Reject" Field After Switching Language

Describe the bug
In the Enatega Single Vendor Admin Dashboard, a language inconsistency is observed in the "Reason If Reject" field when switching the language. After changing the language, the placeholder text associated with the "Reason If Reject" field, which is located alongside the "Cancel Order" tag, does not update to reflect the new language.
To Reproduce
Steps to reproduce the behavior:

Open the Enatega Single Vendor Admin Dashboard.
Log in with valid credentials.
Switch the language within the dashboard settings.
Navigate to an order that requires acceptance or rejection.
Observe the "Reason If Reject" field alongside the "Cancel Order" tag.

Expected behavior
After switching the language, the placeholder text in the "Reason If Reject" field should dynamically update to match the selected language, providing a seamless and consistent user experience.
Screenshots

Desktop:

Browser chrome

Additional context
This issue affects language consistency and may lead to potential miscommunication in rejection reasons.

Hi @Inshirah23,
The overall localization of this page has been successfully added and 'Reason is rejected' as well, thanks for spotting this issue, it was causing a bad inconsistency in language localization.
@ninjas-code-official/ninjas-code
@beKashif


Support for providing sense data for REQUEST SENSE

These changes extend Error() with two optional arguments for the Sense Key and the Additional Sense Code and extend CmdRequestSense to return the values set by the previous (failed) command.
Unsupported SCSI commands now return the correct SCSI sense data, which improves compatibility with initiators evaluating these data.
In theory the sense data are not optional, but the current code is not prepared for providing these data for each error. Any command that fails should set these values according to the SCSI specs.
This PR resolves issues https://github.com/akuker/RASCSI/issues/116,  https://github.com/akuker/RASCSI/issues/119 and https://github.com/akuker/RASCSI/issues/124.
@akuker I successfully tested these changes with my SCSI hardware. I also tried to run the robot tests, but had an issue with the test suite reporting "Authentication failed for user 'pi'", so that the test suite could not be run. Any idea what might be wrong here?

Commit 0135abf resolves issue #124.

Hi @uweseimet - The Robot tests expect the RaSCSI to be accessible through the network and to have the default username/password. I'm guessing your RaSCSI device has a different password set.

@akuker Ready for merging, successfully tested with my hardware after resolving the conflicts.

Hi @uweseimet - The Robot tests expect the RaSCSI to be accessible through the network and to have the default username/password. I'm guessing your RaSCSI device has a different password set.

After changing the password I could proceed. I had to install lsscsi (updated the Wiki accordingly), but now the tests fail because no SCSI devices (/dev/sd*) can be found.
--
Robot
Robot.Rascsi Cd-Rom Functionality :: Test the RaSCSI CD-ROM emulation funct...
MacOS formated ISO is mounted and correct size is reported :: Moun... bash: /sys/class/scsi_host/host0/scan: No such file or directory
After adding a USB stick /dev/sda and /dev/sdb are available, but the tests still fail:
--
Robot
Robot.Rascsi Cd-Rom Functionality :: Test the RaSCSI CD-ROM emulation funct...
MacOS formated ISO is mounted and correct size is reported :: Moun... | FAIL |
Unable to find device ID for SCSI ID 6: '' does not match '/dev/[\w\d]+'
Can it be that the tests expect a very specific device setup?

You'll need to download some specific files on your RaSCSI host.
In the /home/pi/images folder, you'll need the following:

Sim Tower (Download)[https://www.macintoshrepository.org/3915-simtower-cheats?ns=1] Download the .toast file and rename to .iso
Ubuntu 12.04.5 (Download)[http://old-releases.ubuntu.com/releases/12.04.5/ubuntu-12.04.5-server-amd64.iso
Marathon (Download)[https://macintoshgarden.org/sites/macintoshgarden.org/files/games/marathoncd.zip]

pi@rascsi:~/images $ sha1sum simtower.iso
ea6523a1b0c6d10181582b331912c21934bab317  simtower.iso
pi@rascsi:~/images $ sha1sum ubuntu-12.04.5-server-amd64.iso
7540ace2d6cdee264432f5ed987236d32edef798  ubuntu-12.04.5-server-amd64.iso
pi@rascsi:~/images $ sha1sum marathon.iso
3063489d009e9def138cd501f73239c0328a21a0  marathon.iso
pi@rascsi:~/images $ ls -al marathon.iso ubuntu-12.04.5-server-amd64.iso simtower.iso
-rw-r--r-- 1 www-data www-data  35895296 Jul 26  2020 marathon.iso
-rwxrwxr-x 1 pi       pi        16947200 Sep  9  2020 simtower.iso
-rwxrwxr-x 1 pi       pi       722468864 Sep  9  2020 ubuntu-12.04.5-server-amd64.iso
pi@rascsi:~/images $

Thank you for helping to clean up the crappy documentation. I never imagined someone would try to recreate my setup!

When you do get the robot tests running, note that the "Anex86 Hard Drive" always fails. I haven't taken the time to investigate, since I'm not aware of anyone using that functionality.
The first "Robot.Rascsi Cd-Rom Functionality" test also intermittently fails. It will usually pass the second time its run.

Thank you for providing setup details. Maybe the Wiki should be updated accordingly.
Talking about setups, do you see any issue with rasing the C++ level to c++-17 or, or even to c++-20? I'm using either current 32 bit versions of Ubuntu or Raspberry Pi OS, and it looks as if both levels work find with the compilers of these distributions. In case you agree to raise the level I will test the result on both environments, of course.

No objections to raising the c++ version! The official raspberry pi OS is based on a slightly older version of Debian. Not sure if it goes up to 20

OK! I am going to check which level the currrent official OS compiler supports.

When I ran the robot tests on these changes, a bunch of the cdrom tests fail. Does the CD-ROM functionality work on your end?

I can only run tests with hard disk and MO drives because currently I don't have a working CDROM setup on my retro hardware.
WIthout these changes the same tests run without any issues? If they do please provide the logfile of the failed tests, so that I can have a look at it.
You are sure that the tests are correct? Maybe the fail because of correct SCSI error codes being returned now?

I have set up my retro hardware for CD usage now and there are no issues with accessing data CDs.

@akuker Any news on this? I have not found any issues yet and tried 3 different operating systems. Have you already had the time to check whether the tests are correct?
By the way, I also tried to test with a Performa 630, but the hardware causes the Performa to hang when booting, see https://github.com/akuker/RASCSI/issues/132.

@uweseimet - Sorry, life has been busy this week. I haven't had a chance to test it, but if its working on a Performa 630 for you, I'll take that as good enough. I'll do my own testing before pushing it to the master branch.

Sounds good! Remember, the changes only affect the behavior in cases where an error (CHECK CONDITION) occured, i.e. the sense data returned by REQUEST SENSE after that. The behavior in the non-error case is unchanged.


InvalidArgumentError: 2 root error(s) found.   (0) Invalid argument:  indices[39,107] = 85525 is not in [0, 85525) 	 [[node model_5/embedding_8/embedding_lookup (defined at :2) ]] 	 [[model_5/embedding_8/embedding_lookup/_14]]   (1) Invalid argument:  indices[39,107] = 85525 is not in [0, 85525)  in  Colab .

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
TensorFlow version:
Python version:
Installed using virtualenv? pip? conda?:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

Describe the problem
InvalidArgumentError: 2 root error(s) found.
(0) Invalid argument:  indices[39,107] = 85525 is not in [0, 85525)
[[node model_5/embedding_8/embedding_lookup (defined at :2) ]]
[[model_5/embedding_8/embedding_lookup/_14]]
(1) Invalid argument:  indices[39,107] = 85525 is not in [0, 85525)
Provide the exact sequence of commands / steps that you executed before running into the problem
This is the Error message I got,
`nvalidArgumentError                      Traceback (most recent call last)
 in ()
1 model.compile(optimizer=optimizer, loss='categorical_crossentropy', metrics= ['accuracy'])
----> 2 a = model.fit( train_padded, y_train ,epochs=15, validation_data=(  test_padded  , y_test  ) , callbacks = learningrate_callback,   batch_size=128   )
8 frames
/usr/local/lib/python3.6/dist-packages/tensorflow/python/eager/execute.py in quick_execute(op_name, num_outputs, inputs, attrs, ctx, name)
58     ctx.ensure_initialized()
59     tensors = pywrap_tfe.TFE_Py_Execute(ctx._handle, device_name, op_name,
---> 60                                         inputs, attrs, num_outputs)
61   except core._NotOkStatusException as e:
62     if name is not None:
InvalidArgumentError: 2 root error(s) found.
(0) Invalid argument:  indices[39,107] = 85525 is not in [0, 85525)
[[node model_5/embedding_8/embedding_lookup (defined at :2) ]]
[[model_5/embedding_8/embedding_lookup/_14]]
(1) Invalid argument:  indices[39,107] = 85525 is not in [0, 85525)
[[node model_5/embedding_8/embedding_lookup (defined at :2) ]]
0 successful operations.
0 derived errors ignored. [Op:__inference_train_function_10924]
Errors may have originated from an input operation.
Input Source operations connected to node model_5/embedding_8/embedding_lookup:
model_5/embedding_8/embedding_lookup/10486 (defined at /usr/lib/python3.6/contextlib.py:81)
Input Source operations connected to node model_5/embedding_8/embedding_lookup:
model_5/embedding_8/embedding_lookup/10486 (defined at /usr/lib/python3.6/contextlib.py:81)
Function call stack:
train_function -> train_function`
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
Here's a part of the source code ,
`
input_tensor = tf.keras.Input(  shape = ( maxlength , )  )
embedd = tf.keras.layers.Embedding( input_dim = vocab     , output_dim = 300 , embedding_initalizer=  tf.keras.initializers.Constant(embedding_matrix) ,  input_length = maxlength  ) (input_tensor)
conv1d_1 = tf.keras.layers.Conv1D (  filters = 16 , kernel_size = 3 , strides = 1 , padding = 'valid'  , activation = 'relu', kernel_initializer = 'he_uniform' ) (embedd)
conv1d_2 =tf.keras.layers.Conv1D (  filters = 16 , kernel_size = 3 , strides = 1 , padding = 'valid'  , activation = 'relu', kernel_initializer = 'he_uniform' ) (embedd)
conv1d_3 = tf.keras.layers.Conv1D (  filters = 16 , kernel_size = 3 , strides = 1 , padding = 'valid'  , activation = 'relu', kernel_initializer = 'he_uniform' ) (embedd)
concat_1 = tf.keras.layers.concatenate(   [conv1d_1, conv1d_2 , conv1d_3 ] )
`
here embedding_matrix has a shape of (85525, 300) (unknown token included while tokenizing)
I'm trying to replicate the  Example at https://keras.io/examples/pretrained_word_embeddings/
with a different structure.

try this   tf.keras.layers.Embedding(input_dim = vocab+1,...)
input_dim: int > 0. Size of the vocabulary,
i.e. maximum integer index + 1.

@zoomself  Thanks for replying !!! I tried it , but still getting the error, Strangely the error disappears if I run it in tensorflow 2.1,
And I also went through similar issues,

https://github.com/tensorflow/tensorflow/issues/23698
https://stackoverflow.com/questions/59867929/invalidargumenterror-2-root-errors-found-incompatible-shapes-in-tensorflow-t

@SangamSwadiK,
I was able to run the example given on Keras without any issues. However, while running the sample code you have provided I'm facing an error stating NameError: name 'vocab' is not defined. Please find the gist of it here.
In order to expedite the trouble-shooting process, could you please provide the complete code to reproduce the issue reported here and also the TensorFlow version you are using. Thanks!

Closing this as I resolved the issue, The solution was to define a function
my_func (shape , dtype = None):
Line 1 ------
Line 2 ------
return embedding_matrix
Embedding layer changes to
embedd = tf.keras.layers.Embedding( input_dim = vocab , output_dim = 300 , embedding_initalizers = my_func , input_length = maxlength ) (input_tensor)
However, tf.keras.initializers.Constant(embedding_matrix) should have worked,
but Since I cannot provide the full code as this is a part of an assignment. I'm closing this .
Thanks @amahendrakar , @zoomself  for replying.

@SangamSwadiK Hello, could you please elaborate exactly how you did, am facing similar error and am not getting any clue to resolve it.

It can be resolved by changing the input_dim to vocabulary+1

Yes as @nilay121 suggested changing the input_dim works for the error...


Include SHA-256 hashes when running mops add for security

The main security concern that I've heard about Mops is that developers want a way to confirm that subsequent package downloads include the same source code. Vessel solves this with an optional sha256: tag after URLs, and this could be simplified in Mops using a dependency syntax such as base = "https://github.com/dfinity/motoko-base#moc-0.8.5:acbdef0123456789" or similar.
This would also give Mops a huge advantage over Vessel, since mops add (or mops add --hash) could automatically include the hash without having to manually copy/paste this for every dependency.

@rvanasa is this the case when you specify #branch and next time mops install might install another version of package? (new commits appeared in branch)

Yep!