Ensure that we set the State in a valid Entity retrieved

Like the title say.

Thanks for the hot patch.

@tomvlk No problem! :smirk:


Make core collections stronger & consistent

Suggestions:
Iterable

[ ]  bool contains(Object element) ➡  bool contains(T element)

You never want to write this:
class Dog {}
class Cat {}

void main() {
  var dogs = [ new Dog(); ]
  var cat = new Cat();
  ...
  print(dogs.contains(cat)); // <-- Will never be true.
}

I ran into this today when I had a Set that used to be Set<A>, got changed to Set<B>, but code was never updated the check it for a B instead of an A, yet static analysis reported everything was fine.
List

[ ] List.from(Iterable elements) ➡ List.from(Iterable<E> elements)

I'm not sure if this is blocked on #30355 or not.

[ ] List.unmodifiable(Iterable elements) ➡ List.unmodifiable(Iterable<E> elements)

This is a common way to lose reified type information 😢

[ ] bool remove(Object element) ➡ bool remove(T element)

Same issue as described above for Iterable#contains.
Map

[ ] Map.from(Map other) ➡ Map.from(Map<K, V> other)
[ ] Map.fromIterable(Iterable iterable, { K key(element), V value(element) }) ➡ Map.fromIterable(Iterable<E> iterable, { K key(E element), V value(E element) })
[ ] Map.unmodifiable(Map other) ➡  Map.unmodifiable(Map<K, V> other)
[ ] bool containsKey(Object key) ➡  bool containsKey(K key)
[ ] bool containsKey(Object value) ➡  bool containsValue(V value)

All of these are there for one reason or another.
In Dart, you can do
Set<Object> x = new Set<int>()..addAll([1, 2, 3]);
...
if (x.contains("string")) ...;`.

The assignment is valid due to covariant generics. The lookup is statically safe because of the static type of x. There are two ways to give this meaning at runtime - either throw or return false. We chose to return false because it makes the assignment more useful.
Most other languages, including Java and C#, do not have covariant generics.
The Java collections also accept Object for contains and remove. Maybe it's just because they can - If you know that an Object reference actually has a type compatible with the set, you can remove it without having to cast it first.
C# collections require contains and remove to have the element type, so that's also possible. The C# collections generally has a Cast method that makes it possible to use a List<int> as a List<Object> by adding runtime checks. That could be useful for Dart as well.
For a constructor like Set.from, it not requiring its arguments to have the correct type makes it possible to dynamically cast. Example: new List<num>.from(setOfObjects.where((e) => e is num)). You can't just use the toList method on the iterable because that would give you a List<Object>. These constructors are the escape hatches needed to actually change the type of a collection.
Again, a cast operation might do the same thing (including adding the required dynamic checks), so you could do setOfObjects.where((e) => e is num).cast<num>().toList().
So, there are reasons for these choices. If we change them back, we'll need to add some other feature to alleviate the pain.

We step on all of this in Vipunen too, when trying to type-check core libraries under the assumption that int et al are primitive types (non-nullable, incompatible with Object) and that C<dynamic> is forbidden.

Assuming that int is-not Object is going to break a lot of things since everything was designed under the assumption that everything is an object.
It's probably possible to have a type system with no greatest element, and generics that work with it, and in those cases, the assumption that Object is a supertype of everything, like in Set.remove, will be very visible. That said, we are not planning to move to such a type system, so that's not an argument for changing anything.

@lrhn:

All of these are there for one reason or another.

Sure, but it doesn't mean they should never change.

In Dart, you can do
Set<Object> x = new Set<int>()..addAll([1, 2, 3]);
...
if (x.contains("string")) ...;`.

The assignment is valid due to covariant generics. The lookup is statically safe because of the static type of x. There are two ways to give this meaning at runtime - either throw or return false. We chose to return false because it makes the assignment more useful.

It didn't make it more useful for me when I almost submitted a production bug. I imagine if you poll your users, almost nobody finds this a useful feature of Dart. In fact, it reminds me more of JavaScript or Python than C# (HashSet(T).Contains).

The Java collections also accept Object for contains and remove. Maybe it's just because they can - If you know that an Object reference actually has a type compatible with the set, you can remove it without having to cast it first.

Just because Java's aging standard library doesn't isn't a good enough reason IMO.

C# collections require contains and remove to have the element type, so that's also possible. The C# collections generally has a Cast method that makes it possible to use a List<int> as a List<Object> by adding runtime checks. That could be useful for Dart as well.

+1. Opt-in, almost nobody will actually need this, but +1 for allowing opt-in with a cast method.

For a constructor like Set.from, it not requiring its arguments to have the correct type makes it possible to dynamically cast. Example: new List<num>.from(setOfObjects.where((e) => e is num)).

Fair, but I'd like to see a specific set of methods/constructors specifically dealing with casting instead of it being the default. It's really confusing to our users that .from drops type information.

Again, a cast operation might do the same thing (including adding the required dynamic checks), so you could do setOfObjects.where((e) => e is num).cast<num>().toList().

I like this option.

List.from(Iterable elements) ➡ List.from(Iterable<E> elements)

I'm guessing these are unlikely to occur or should be broken up into individual requests.

The one that always annoys me is Map.fromIterable. Couldn't it use a generic at least ? The case here is annoying, if you include a ternary it's unreadable.
Map<String, Booking>.fromIterable(
        bookingList,
        key: (booking) => (booking as Booking).id,
      ),

@cedvdb It can't, actually. Constructors cannot be generic. (I wish they could, https://github.com/dart-lang/language/issues/647).
We could make fromIterable as static method instead of a constructor, but then the generics would be:
static Map<K, V> fromIterable<S, K, V>(Iterable<S> source, {K Function(S) key, V Function(S) value}) ...

It does mean that fromIterable sucks, and you shouldn't use it. These days, you should use a collection literal instead:
  {for (var value in source) key(source): value(source)}


⚠ Bofrost.de has degraded performance

In 5cdb641, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1381 ms

Resolved: Bofrost.de performance has improved in 295e7cc.


fix: update-notifier issue

This fixes Error: Cannot find module 'update-notifier' issue after global installation

Thanks for creating this. I was previously using your bash PTCL cli: https://github.com/ahmadawais/PTCL-CLI-Bash

@armujahid thanks for the PR. Was still working on this. Yes, that BASH CLI stopped working since I moved to VDSL so I thought this would be better. Did you try this one? All the options?

Yes It is working perfectly fine. I have tested these options (On VDSL Device: ZXHN H168N V2.2):

headless reboot -xr (Haven't tested non-headless reboot)
xDSL stats (in both headless or non-headless modes)
xDSL Screenshot


merge package from arlac77/npm-package-template

package.json

chore(package): update<EMAIL_ADDRESS>

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Enable portuguese

On the whole site, enable interfaces and translations for this new language.

done long time ago


New version?

Hi,
Just wondering what the sort of roadmap is for the next version?
(I'm wanting consul 0.6 ideally via a release version)
Thanks

+1 on this.

I am trying to tackle these issues for the 1.4 release. I don't think its too much work, but definitely looking for some help cleaning up the queue!

I don't suppose you'd cut a 1.3.2 in the mean time so we can get #234?

Let's see if we can knock out #217 and #235 first... any takers?

Just a quick recap - I'm waiting on #265 and #262 (to pin version) - then we're good to release. Thanks for the awesome work @legal90 and @Ginja!

Hey just wanted to check in on the status of the 1.4 Version release.  Trying to get our hands on that sweet sweet windows support :).  Awesome work thus far!

Released!


Perform Automated Link Checking Periodically

resolves #22489

The problem: we should do this checking within Prow, not within GitHub Actions.
As a project, Kubernetes has opted to use and manage Prow for executing checks as part of continuous integration.
Although this website uses Netlify (and a GitHub Action to trigger Netlify), I'm wary of switching more checks to GitHub, especially checks that run on every PR.

Perhaps we can get you an intro to the docs on how to use Prow? I'm afraid those docs aren't as good as GitHub Actions.
For historical context: Kubernetes and Prow are both older than GitHub Actions. Converting to GitHub Actions would not be for the faint of heart.

OK, I understand. We'd better avoid GitHub Actions then.
Hmm, I briefly explored the Prow documentation but I feel like it requires much more effort to familiarize myself with the library and golang. Prow itself seems interesting but I think I’ll pass this time since I'm not sure how long it takes to implement with my current skill set. Maybe I can try in the future after experimenting Prow by myself.


[5.5][CSBindings] Overload variable shouldn't be delayed by its application

Cherry-pick of https://github.com/apple/swift/pull/37835

Explanation:

When inference is determining bindings of a type variable that represents
an overload set (e.g. member or operator reference), let's not consider
it as delayed due to presence of ApplicableFunction constraint since
argument/result type inference depends on overload set but not vice versa.

Scope: Some single-statement closure expressions that have contextual type that doesn't explicitly specify generic parameters.

Main Branch PR: https://github.com/apple/swift/pull/37835

Resolves: rdar://78917861

Risk: Low

Reviewed By: @hborla

Testing: Regression tests added to the suite

Resolves: rdar://78917861
(cherry picked from commit 81ff342f4e1531e4e27a988467d23b67d08d048c)

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 011d2993631dabcd60b6dd1efd40a79bda2b1bf1

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - 011d2993631dabcd60b6dd1efd40a79bda2b1bf1

@swift-ci please clean test Linux platform


Add link to Pablo Donato's thesis in Showcase

Dear Federico,
I just finalized my PhD thesis manuscript written with your wonderful kaobookclass. Thus I propose to add it in the Showcase :)
Thank you for your nice work,
Pablo Donato

Hi Pablo,
That's amazing, congratulations! Happy to merge this.

Great! Thank you :)


Allow for the configuration of a cache_key_digest method

This will allow someone to use something other than #hash on an object (which will change per VM startup).
Documented in issues #146 and #52; as well as here. Demonstrated here on 2.1.2:
$ irb
~> Console extensions: wirble hirb ap rails2 rails3 pm interactive_editor
>> 'foo'.hash
=> -2698411427522052147
>> exit
$ irb
~> Console extensions: wirble hirb ap rails2 rails3 pm interactive_editor
>> 'foo'.hash
=><PHONE_NUMBER>237632663

This is especially handy when using something like Redis to cache values which should persist across server restarts and allow for multiple application instances to talk to the same  Redis server, or multiple applications sharing the same translation store.
Using something like Digest::MD5 takes double the time as Object#hash. However, the digest value remains consistent for the same raw value across multiple VMs.
I've done some benchmarks using different hashing algorithms and have uploaded the results here.
Props to @yellow5 for his help digging through with me!

I restored use of the USE_INSPECT_HASH constant on behalf of @evanmiller67.
The specs needed a minor tweak to be stabilized and should be good to go.

LGTM. Thanks @yellow5 for getting this across the line :)


Support slash commands

I support slash commands.
https://api.slack.com/slash-commands
This PR mainly offer parse HTTP requests of slash commands
In addition, it also provides a convenient wrapper for use with http.HandlerFunc.
Please see an example.
Example 1: It's a very easy way to write a bot. You only need to write command handling.
Example 2: It's a flexible way. This example only use parse method.
I wrote the test code with reference to the following test code.
https://github.com/nlopes/slack/blob/master/stars_test.go
Please point out that if there are strange points!

looks fine to me, I'm generally against implementing the handler in the library though. specifically because of requests like @Obaied's, the http handler is going to be different based on the needs of each user of the library. all that being said, I'm good with this PR as is if you add documentation to the handler that it will not be extended beyond providing a base example for people to work with.
My prefered implementation would just have two functions, and the SlashCommand struct:
SlashCommandParse(http.Request) (SlashCommand, error)
(t SlashCommand) ValidateToken(acceptableTokens ...string) (bool)

@james-lawrence Thank you for the review!
I understand. As you said, the needs of each user is different.
I fixed the function and example as you reviewed.
Please review again!

LGTM, thanks!

I just found this as I was doing some research on implementing slash command backend. I noticed that this function doesn't do the full signing key verification.
https://github.com/nlopes/slack/blob/master/security.go
Currently, I'm running into the problem of needing to run ParseForm and read the body (in order to do the verification, but it seems I can't do both?


Fix pyroma complaints

Relates to #48.
Pyroma thinks that the author and author_email fields should be present.
Also, zip_safe should be explicitly set. The default is True, so I've left it at that. I think it's ok for zip_safe = True, but I don't know what the effect of Numba is.

Pull Request Test Coverage Report for Build 62

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.6%

Totals

Change from base Build 61:
0.0%

Covered Lines:
1902

Relevant Lines:
2054

💛  - Coveralls

Zip_safe Should be fine as far as I know. I guess we'll find out if something goes wrong.


[BugFix][3.1] Fix bug insert overwrite auto list partition table result is null

Fixes #27190
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:disappointed: fail : 5 / 30 (16.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/ListPartitionInfo.java
0
4
00.00%
[141, 142, 169, 170]

:large_blue_circle:
com/starrocks/load/PartitionUtils.java
2
22
09.09%
[99, 100, 102, 103, 104, 105, 106, 107, 110, 111, 112, 113, 114, 115, 117, 118, 119, 120, 122, 123]

:large_blue_circle:
com/starrocks/load/InsertOverwriteJobRunner.java
3
4
75.00%
[368]


Bebop Usage of Trademarked Replit Logo

Hello Bebop Team,
I am writing on behalf of Replit about your use of a Replit logo. I came across your site (hxxps[://]bebop[.]sh/) and saw that you are using one of our logos. This logo is a registered trademark of Replit (U.S. Trademark Reg. No. 7318975), and we do not consent to your use. We do not believe you have malicious intent, so we request that you change the icon so it does not use our logo.
Thank you for your prompt attention in this matter!
Kind regards,
Ray Arayilakath
Trust & Safety @ Replit
Screenshot of Usage of the Replit Logo on hxxps[://]bebop[.]sh/

P.S. I would be willing to open a PR to change the icon to something more appropriate 👍

Slow day? We'll be sure to get rid of the Replit based demos and switch to StackBlitz.

Hello Andrew! Just to clarify, I noticed the Replit logo on your site and wanted to address it, as your demo is not hosted on Replit but is instead your own playground. I personally was confused when first clicking into it, hence why I wanted to raise it to your attention in a professional manner. Thanks for your understanding.


M52 rebasing

Did you really intend to send this pull request? As far as I can see, M52 is still a work in progress.

Did I do something wrong?
I know it is in progress, but this is the only way how we can sync with mrunal.
But why 26 commits?
I might have done something wrong

Did I do something wrong?
I know it is in progress, but this is the only way how we can sync with mrunal.

 See #3687, #3696 or #3746, for example, for pull requests for the next branch with more informative descriptions of what they are doing in the pull request messages.

But why 26 commits?

Something went wrong with your next branch. Your branch (ie. in your fork) is based on the latest master (b9a0b81a1d8be4d0a3c774f2612f82419a4a9d48), whereas the next branch in the crosswalk-project/crosswalk repository is based on a previous commit in master (87feec5d35047d0f2a9b150c43a6de30d7989266). This your pull request at the moment contains the delta between 87feec5d35047d0f2a9b150c43a6de30d7989266 and b9a0b81a1d8be4d0a3c774f2612f82419a4a9d48, followed by the next changes on top and finally the two commits you authored.
What you should do right now is save those 2 commits you created somewhere (as patches, in a separate branch or in any way you want), reset your next branch to the upstream one (git reset --hard origin/next), apply your 2 commits on top and either update this PR or create a new one.
I suggest creating a new one because you used your own next branch as the base for this pull request instead of creating a separate, topic branch only for this pull request. When you do this, whenever you push to your next branch any open pull requests originating from it will be automatically updated, which is not what you want.


Fix edge cache issue

fix the bug when vertex updated, but the edge cache associated with that vertex was not updated. Here we simply clear all edge cache when  any vertex changes.
add two test case for the fixing

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

have reformated code style

I have read the CLA Document and I hereby sign the CLA

recheck


Install bebop autonomy on ROS Melodic ubuntu 18.04

Hi!
Any plans to make this repo compatible with ROS Melodic running on Ubuntu 18.04?
Thanks!

Yes, we are really hoping to upgrade this package to work under Ubuntu 18.04.

See https://github.com/AutonomyLab/bebop_autonomy/pull/168 and https://github.com/AutonomyLab/parrot_arsdk/pull/9. These compile together on Ubuntu 16.04 and will be tested on the vehicles in a few hours. Will try making this compatible with ROS Melodic on Ubuntu 18.04 in my spare time this week.

PR #168 compiles with ROS Melodic using changes introduced in PR #164. Note: joy and joy_teleop (dependencies of bebop_tools package) are not yet released in ROS Melodic so they have to be built from their source repositories.

Waiting for parrot_arsdk binary to be released by ROS so that PR #168 can be merged.

I have the same problem, I have a mistake : "bebop_tools: Cannot locate rosdep definition for [joy_teleop]"
Can you tell me how get out of this problem ?
For tout information I want to install melodic ROS on Ubuntu 18.04 and then install bebop_autonomie

The joy_teleop binary package is not yet available for ROS Melodic but you can install it from source.
cd ~/bebop_ws/src
git clone https://github.com/ros-teleop/teleop_tools.git
cd ~/bebop_ws
catkin build

Hi! Is it possible to run it on Ubuntu 18.04 with ROS Melodic?

This hasnt been aktive for a long time, is bebop autonomy not installable on melodic?

Hi! Is it possible now to run it on Ubuntu 18.04 with ROS Melodic? I need gazebo 8 version, but I need this driver too ;)

Gazebo 8/9 is available also for the Kinetic Kame release of ROS. If you need to test your control algorithm with bebop_autonomy and Gazebo, you can think to use ROS Kinetic on Ubuntu 16.04. It is also possible to install the ROS distro on Ubuntu 18.04, but you have to manage manually all the steps.

Hi! Is it possible now to run it on Ubuntu 18.04 with ROS Melodic? I need gazebo 8 version, but I need this driver too ;)

Gazebo 8/9 is available also for the Kinetic Kame release of ROS. If you need to test your control algorithm with bebop_autonomy and Gazebo, you can think to use ROS Kinetic on Ubuntu 16.04. It is also possible to install the ROS distro on Ubuntu 18.04, but you have to manage manually all the steps. In the following a guide:
https://medium.com/@abhiksingla10/setting-up-ros-kinetic-and-gazebo-8-or-9-70f2231af21a

Does that also work to install kinetic on Ubuntu 18.04?

It should work! Try, and let us know!!

What will be the fate of bebop autonomy, now that ROS Kinetic is no longer supported?
Have anyone manage to install bebop autonomy on ROS Melodic on Ubuntu 18.04?

What will be the fate of bebop autonomy, now that ROS Kinetic is no longer supported?
Have anyone manage to install bebop autonomy on ROS Melodic on Ubuntu 18.04?

PLease, did you find an answer for that? or some other package for bebop suitable for ubuntu 18.04?

What will be the fate of bebop autonomy, now that ROS Kinetic is no longer supported?
Have anyone manage to install bebop autonomy on ROS Melodic on Ubuntu 18.04?

PLease, did you find an answer for that? or some other package for bebop suitable for ubuntu 18.04?

did anyone achieve anything?


Working without using memory

Hello,
I'd like to know if there is a way to stream the AFP byte by byte, without working in memory. I'm working with huge AFP files (more than 2Gb) and the swap memory is saturated, then java calls for oom-killer that kills random process. Is there any option to read and write files at the same time without loading it? Or is it a new feature I could ask for?
Thanks

Hi @DraGun64,
you don't have to load all AFP data into memory. Normally you would do something like this:
AfpInputStream in = ...
SF sf;
while((sf = in.readStructuredField()) != null) {
	switch(sf.getId()) {
	case SFName.BPG_VALUE:
		pages++;
		break;
	case SFName.BRS_VALUE:
		resources++;
		break;
	}
}

This will read one structured field at a time and the gc will take care of old objects. You can also have a look at filter chains afplib/org.afplib/src/test/java/org/afplib/io/AfpFilterChainTest.java

Hi @yan74 ,
Here's what I tried:
       AfpInputStream afpin = null;
       AfpOutputStream afpout = null;
       try {
           afpin = new AfpInputStream( new FileInputStream( fileIN ) );
           afpout = new AfpOutputStream( new FileOutputStream( fileOUT ) );

           SF sf;
           while ( ( sf = afpin.readStructuredField() ) != null ) {

               if ( sf instanceof BRS ) {
                   Tools.updateBRS( sf, c );
               }

               if ( sf instanceof ERS ) {
                   Tools.updateERS( sf, c );
               }

But is still loads the entire AFP into memory, without releasing it.
What I had before:
try ( AfpInputStream afpin = new AfpInputStream( new BufferedInputStream( new FileInputStream( fileIN ) ) );
                AfpOutputStream afpout = new AfpOutputStream( new BufferedOutputStream( new FileOutputStream( fileOUT ) ) ) ) {

            SF sf;
            while ( ( sf = afpin.readStructuredField() ) != null ) {

Does Tools.updateBRS( sf, c ) keep a reference to sf?

To be honest, I'm not the developer here.. My colleague is.
Here's the void:
public static void updateBRS( SF sf, char c ) {
        // System.out.println( "BRS : " + ( (BRS) sf ).getRSName() );
        if ( ( (BRS) sf ).getRSName() != null ) {
            // System.out.println( "BRS NEW : " + updateValue( ( (BRS) sf ).getRSName().toString(), 'A' ) );
            ( (BRS) sf ).setRSName( updateValue( ( (BRS) sf ).getRSName().toString(), c ) );
        }
    }

cette méthode modifie le nom s'il n'est pas null
une fois les modifications effectuées le fichier est réecrit

this method changes the name if it is not null
once the changes are made the file is rewritten

weird - this should not cause any OOM can you run your file with following code and see if AFPlib still eats all the memory?
try ( AfpInputStream afpin = new AfpInputStream( new BufferedInputStream( new FileInputStream( fileIN ) ) );
                AfpOutputStream afpout = new AfpOutputStream( new BufferedOutputStream( new FileOutputStream( fileOUT ) ) ) ) {

            SF sf;
            while ( ( sf = afpin.readStructuredField() ) != null ) {
               afpout.writeStructuredField(sf);
            }
}

I ran a test with a 2GB file using following code:
package org.afplib.samples;

import java.io.BufferedInputStream;
import java.io.BufferedOutputStream;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;

import org.afplib.base.SF;
import org.afplib.io.AfpInputStream;
import org.afplib.io.AfpOutputStream;

public class ReadAll {

	public static void main(String[] args) {
		try (AfpInputStream in = new AfpInputStream(new BufferedInputStream(new FileInputStream(args[0])));
				AfpOutputStream out = new AfpOutputStream(new BufferedOutputStream(new FileOutputStream(args[1])))) {

			SF sf;
			while((sf = in.readStructuredField()) != null) {
				out.writeStructuredField(sf);
			}
		} catch (IOException e) {
			e.printStackTrace();
		}
	}

}

visualvm shows that although heap size grows considerably in the beginning it uses less than 250MB in the long run:

Thanks a lot Yan, we'll try it on Monday and will get back to you.


zombie pacman.exe after update -Syu

I believe I've seen this since the first time I updated MSYS2 with pacman -Syu more than a year ago.
After some "system" updates, like the recent pacman mirrors update, there's a message to close the terminal without exiting the shell. If I do that, the task manager shows pacman.exe is still running.
As far as I can tell it does not close on its own ever. Running msys2 again opens the terminal with shell correctly, and the task manager still shows pacman.exe is running. Closing the terminal by exiting the shell (exit at the shell) also doesn't close pacman.exe .
Is this expected? if yes, what's the correct/best thing to do on such case? close mintty and then kill pacman.exe ?

It just happened again. Here's a log:
MSYS ~ $ ps
      PID    PPID    PGID     WINPID   TTY         UID    STIME COMMAND
     6012    5456    6012       5132  pty0      197609 12:52:46 /usr/bin/bash
     3512    6012    3512       2280  pty0      197609 12:53:39 /usr/bin/ps
     5456       1    5456       5456  ?         197609 12:52:46 /usr/bin/mintty

MSYS ~ $ pacman -Syu
:: Synchronizing package databases...
 mingw32 is up to date
 mingw64 is up to date
 msys is up to date
:: Starting core system upgrade...
warning: terminate other MSYS2 programs before proceeding
resolving dependencies...
looking for conflicting packages...

Packages (1) pacman-5.1.0-1

Total Download Size:    7.00 MiB
Total Installed Size:  34.52 MiB
Net Upgrade Size:       0.41 MiB

:: Proceed with installation? [Y/n]
:: Retrieving packages...
 pacman-5.1.0-1-x86_64      7.0 MiB   695K/s 00:10 [#####################] 100%
(1/1) checking keys in keyring                     [#####################] 100%
(1/1) checking package integrity                   [#####################] 100%
(1/1) loading package files                        [#####################] 100%
(1/1) checking for file conflicts                  [#####################] 100%
(1/1) checking available disk space                [#####################] 100%
:: Processing package changes...
(1/1) upgrading pacman                             [#####################] 100%
warning: terminate MSYS2 without returning to shell and check for updates again
warning: for example close your terminal window instead of calling exit

At this stage I did as instructed and closed the mintty window using the close button, and confirmed close at the warning that there are still running processes.
After closing mintty, the task manager shows pacman.exe is still running. I killed it manually, then ran MSYS2 again and repeated the update to get the other msys2 packages.
Was killing pacman.exe the right thing to do? Is it expected that it stays after closing mintty?

Just happened again with the update to pacman-5.1.0-4 .
@Alexpux would you mind commenting? is it expected? a bug? what's recommended to do?

There are nothing to do right now. Just leave as is.

So is it OK to kill pacman and possibly other msys2 processes after closing the terminal?


Add snapshot testing FAQs

Summary
There are a few common misconceptions around snapshot testing that always come out when engineers are approaching this technique for the first time.
The new "frequently asked questions" section aims to answer the most common ones, giving clarity to the engineers.
These questions have been collected during conferences, meetups and within issues and PRs.
Test plan

cd website
yarn
yarn start
go to http://localhost:8080/jest/docs/snapshot-testing.html#frequently-asked-questions

Codecov Report

Merging #3425 into master will increase coverage by 0.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3425      +/-   ##
==========================================
+ Coverage   64.04%   64.93%   +0.88%
==========================================
  Files         177      176       -1
  Lines        6570     6514      -56
  Branches        4        5       +1
==========================================
+ Hits         4208     4230      +22
+ Misses       2361     2283      -78
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-cli/src/watch.js
74.19% <0%> (-1.93%)
:arrow_down:

packages/jest-cli/src/generateEmptyCoverage.js
88.88% <0%> (-1.12%)
:arrow_down:

packages/jest-config/src/index.js
25% <0%> (-1.09%)
:arrow_down:

packages/jest-runtime/src/index.js
75% <0%> (-0.97%)
:arrow_down:

packages/jest-cli/src/TestNamePatternPrompt.js
94.33% <0%> (-0.49%)
:arrow_down:

packages/jest-jasmine2/src/reporter.js
85.29% <0%> (-0.43%)
:arrow_down:

packages/jest-cli/src/TestPathPatternPrompt.js
98.07% <0%> (-0.17%)
:arrow_down:

packages/jest-matchers/src/index.js
95.23% <0%> (-0.17%)
:arrow_down:

packages/jest-mock/src/index.js
91.81% <0%> (-0.04%)
:arrow_down:

packages/jest-haste-map/src/index.js
95.47% <0%> (ø)
:arrow_up:

... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0817d64...e7e74c9. Read the comment docs.

I made a few small adjustments but this is great, thanks for the help @MicheleBertoli.

Awesome, thanks @cpojer.


enhance and fix definition list

enable visual editor to accept more than one entry for a definition

published with 1.4.6


(maint) Allow PE puppet-agent installs on custom roles

Previously we installed puppet-agent on a host if there was the agent
role and no other role assigned to it. This prevents assigning a
puppet-agent node the "default" role to be used as the default test
target, or allow any other custom roles.
To allow assigning the "default" or custom roles to a puppet-agent node
we list the non-puppet-agnet roles we know how to generate installation answers
for and use that list to determine what nodes are puppet-agent or not.

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker_btc-intn/1114/
Test PASSed.

This, I think, is the solution to what we were talking about yesterday, @kevpl. Also, this is blocking module testing, @kevpl  and @anodelman.

@justinstoller the concept of a not_controller node was just introduced in a separate PR (https://github.com/puppetlabs/beaker/blob/master/lib/beaker/dsl/roles.rb#L102) that is probably appropriate to use here.

@anodelman we also want to exclude installing puppet-agent on PE when it is a frictionless role that not_controller doesn't include.

Passed locally on Debian 7 and Windows 2012r2!


Minor Emscripten changes

Shaves a bit off the .js and makes JPEG loading actually work... which adds ~150k to the .wasm.

Ooh nice! Thank you.


[SKY30-87] FE - Navigation to the data table + design tweaks

Overview
This PR adds "Marine Conservation Details" panel to the Data Tool.
In this PR:

Added a new "Marine Conservation Details" to the sidebar

Some tweaks required to the sidebar given that the button is stuck to the bottom

Added the container for the new "Details" panel

It will not unload the map component; instead it is displayed above it
Some tweaks may be needed in the future to z-index when the map tooltips are implemented
Currently the details panel will only show an existing static table
Implementation of the actual table will be addressed by SKY30-88; an existing table was used to ensure overflows can work correctly

New hook based with next-usequerystate to set up a base for the details/content settings

At the moment in only stores whether the details panel is open

Some tweaks to approximate the DataTool's visuals to the designs
New ui/button variants

including a new variant for the map's buttons

Screen Recording
https://github.com/Vizzuality/skytruth-30x30/assets/6273795/67cdbf88-e8e9-48d7-ae23-ecc40aac80e6
Testing instructions
N/A
Feature relevant tickets
SKY30-87 | FE - Navigation to the data table

Pinging @andresgnlez


2.5D / 3D - Is there a plan to support those?

Needed features would be:

Tilt map
Buildings heights
Heights to polygons
Load 3D objects from .OBJ (or other 3D format) files

Do you have a recommended solution at this point?
Thanks

@elemoine did some experiments with tilting in https://github.com/elemoine/ol3/tree/tilt.


Chapter 15 : ERR_CONNECTION_REFUSED when trying to log in with the credentials given

I am at the end of chapter 15, and I wanted to try to log in with the login and pw given. The screenshot is the error message that I am getting :

I looked it up but none of the things I tried worked :

clearing the cache
the internet connection is good
disabling the firewall
enabling the connection to websites not https

It feels like the deployed login page tries to reach my localhost dashboard?
Could someone help?
Here is the link to the dashboard : https://nextjs-dashboard-six-jet-53.vercel.app/

Issue resolved but I don't know how and why.
This can even be deleted.


Request for adding controlnet-zoe-depth-sdxl-1.0

Hi,
Could you please support controlnet-zoe-depth-sdxl-1.0?
I checked the supported weight but couldn't find this version of the Zoe Depth file.
Thanks a lot

Is that different to depth-zoe-xl-v1.0-controlnet.safetensors?

@fofr Actually, I shared the wrong link in the first message. This is the correct one. How can we make sure those are the same one?

They have different SHAs, I've now added https://huggingface.co/diffusers/controlnet-zoe-depth-sdxl-1.0 as controlnet-zoe-depth-sdxl-1.0.safetensors


Show progess status when using  "restore" command

Output of restic version
Any
Expected behavior
When we run "restic restore ...", we would like to see the same progress information as with "restic backup ...".
It's always useful to know when the restore will last: in few minutes, or couple or hours. How much data we're downloading, at what speed ...
Actual behavior
There's no progress information. Only one line that confirm the restore operation is done at the very end.

Thanks for your suggestion, this is tracked in #426. I'm going to close this issue as a duplicate.


[joss-review] memory requirement of example run

the first step of the analysis requires about 20 GB of RAM, it would be useful to specify it in the docs, I ran with 15 GB and the process was killed (probably for out of memory)
I'll also estimate memory requirement for the second step and add it here.

I've updated the "Test Dataset" docs under usage.rst with RAM requirements (b9af6b5).  When I ran the test dataset on a slurm system, I see the matrix construction step required ~17 GB of RAM according to the MaxRSS column in the slurm database and the power spectrum analysis required ~12 GB of RAM.  The requirement for the matrix construction being ~17 GB is probably why your job was killed with 15 GB of RAM but succeeded with 20 GB.

it seems like the docs website is not automatically updating:
https://bayeseor.readthedocs.io/en/latest/usage.html#running-the-power-spectrum-analysis
as you estimated the power spectrum requirement for power spectrum analysis, I think it would be a good idea to add that number in.
Do you also know how much GPU memory is needed?

Ah, yes.  I had to manually rebuild the docs (I haven't automated the docs building yet).  The documentation should be updated now.
Regarding GPU memory, I believe the routing we are using in MAGMA is capable of partial i/o so it should be capable of running on a wide range of hardware.


Space when a terminal tab has focus should move focus to the instance

Repro:

Create a terminal
Click the tab
Press space, the actual terminal should be focused

It's cmd+down on mac, just like in the explorer. Enter already works. Closing as it's already consistent


GPIO 16, PSRAM and Available IO Pin

Hi, I'm looking for a free GPIO pin on ESP-CAM to attach a button or PIR, etc.
I'm using the SD card so all the HS2 pins are busy.
I see some people using GPIO 16 (U2RXD ?) , but it appears to be the chip select for the PSRAM chip.  It is pulled up to 3.3v, and I think the high memory software must pull it down to enable the PSRAM chip when using the high memory.  It reads 2.9v, and I don't have an oscilloscope, so I think it is being used.
So I wondering if you know if 16 is being used?
My other idea is to re-use the U0RXD?  Not sure how hard that is.

Update:
So it seems gpio16 is used, but you can set the sd card interface to 4 bits or 1 bit.    If you set it to 1 bit, you free up gpio4, gpio12, and gpio13.  This should slow down the sd write time by 4 times.

sdmmc_host_t host = SDMMC_HOST_DEFAULT();
host.flags = SDMMC_HOST_FLAG_1BIT;
sdmmc_slot_config_t slot_config = SDMMC_SLOT_CONFIG_DEFAULT();
slot_config.width = 1;

But, when I do this, the speed does not change!  I can ground gpio4, without any trouble, but when I remove the 1 bit setup, grounding gpio4 leads to an error, but the 4 bit configuration does not improve the write speed.
So I'm set up for 4 bits, but it is not giving me any benefit .... which is annoying.


npm found 1 high severity vulnerability

Environment details

OS: Mac OS 10.14.4
Node.js version: 6.7.0
npm version: 6.7.0

Steps to reproduce

Tired running   npm init then after npm install node-sass -D
Then i get back the following message

updated 1 package and audited 550 packages in 9.339s
found 1 high severity vulnerability
run npm audit fix to fix them, or npm audit for details

So I run npm audit fix and alerted with this below

up to date in 0.772s
fixed 0 of 1 vulnerability in 550 scanned packages
1 vulnerability required manual review and could not be updated

So I run npm audit next prompted with this message:

Following these steps will guarantee the quickest resolution possible.
Thanks!

Closing as we're archiving this repository.


Update custom device info

Update https://docs.resin.io/hardware/meta-resin/ with info from https://github.com/resin-os/meta-resin/blob/master/contributing-device-support.md

Looking at both the pages @floion
1 - https://github.com/balena-os/meta-balena/blob/master/contributing-device-support.md
2 - https://www.balena.io/docs/reference/OS/meta-balena/
Would it make sense to pull/generate page 2 from page 1 instead? We can reformat page 1 to look presentable (it already looks good to me) and just pull that file as a partial (or even a complete file). A good example of what I mean is the

Check Supervisor API reference - https://www.balena.io/docs/reference/supervisor/supervisor-api/#http-api-reference
Being pulled from this file https://github.com/balena-io/balena-supervisor/edit/master/docs/API.md
Being fetched through this script https://github.com/balena-io/docs/blob/master/tools/fetch-external.sh
And this gets pulled every build time.

I think this would solve it?

@floion Pinging again about this, since this recently came up. Let me know what are thoughts on this ^^


fix(api-server): shutdown hook configuration is using wrong config key

Describe the bug
In the api-server constructor the evaluation for the activation / deactivation of the shutdown hook is based on the wrong configuration property so that it always is falling back to the default value and pre-configured value is not taken.

@petermetz: Can you please assign this issue onto my name as discussed yesterday

@m-courtin You got it, thank you for reporting!


Pixi React v8

Overview
This issue will track progress on version 8 of Pixi React. This new major version is a complete rewrite of the library and will support Pixi.js v8.
Thesis
The v7 codebase of Pixi React has served its purpose, but it has become burdensome to maintain. Especially with the release of Pixi.js v8 and the significant number of breaking changes it introduced, it makes more sense to rebuild this library from scratch than to continue supporting the legacy codebase.
For this complete rewrite, we'll take a new approach to the library's implementation by introducing a custom React Pixi pragma, an extend API, and reflecting all Pixi components as React components. This rewrite is heavily influenced by the prior art of @react-three/fiber, and I've been receiving significant help from @CodyJasonBennett and @krispya.
A new pragma
React allows custom reconcilers to tap into its re/rendering logic. React Pixi has been using a custom reconciler for some time, but the library provided custom components that used this reconciler to manage their own rendering lifecycle. These components need to be maintained, and their logic could require changes depending on how the core Pixi.js library changed.
With a new JSX pragma, we can eliminate the need for custom components. Instead, we reflect Pixi.js components directly into the pragma and proxy their JSX props back as Pixi.js component props. This allows us to expose all Pixi.js components now and in the future with no changes to React Pixi.
The extend API
To provide all components as a pragma would typically require us to import the entirety of Pixi.js into the Pixi React library, making tree shaking difficult and significantly increasing the build size for anybody trying to use Pixi.js v8. Instead, we're leveraging an extend API allowing users to import only the Pixi.js APIs they require, thus cutting down on bundle sizes.
The API will be available as both a Vanilla extend method and a useExtend React hook. An example of what this will look like:
import {
  Canvas,
  useExtend,
} from '@pixi/react'
import { Sprite } from 'pixi.js'

export function App() {
  useExtend({ Sprite })

  return (

      <Canvas>
        <sprite x={0} y={0} texture={texture} />
      </Canvas>

  )
}

Exposing all of Pixi.js
Combining the new pragma and the extend API, we can use the entirety of Pixi.js via JSX. Any properties that you would normally set directly on a Pixi.js component will be managed via JSX props, while the components will be exposed directly through their refs. This enables lots of creative use cases, e.g. defining Pixi.js Filters in JSX...
import {
  useEffect,
  useRef,
  useState,
} from 'react'

export function App() {
  const [filters, setFilters] = useState([])

  const filterRef = useRef(null)

  useEffect(() => {
    setFilters(previousState => {
      const filter = filterRef.current

      if (!previousState.includes(filter)) {
        return [
          ...previousState,
          filterRef.current,
        ]
      }

      return previousState
    })
  }, [])

  return (
    <>
      <blurFilter
        ref={filterRef}
        quality={10}
        strength={10} />
      <sprite
        filters={filters}
        texture={texture}
        x={0}
        y={0} />
    </>
  )
}

More intuitive support down the road
The BlurFilter implementation above is a great example of something I've already got an eye towards improving. I'd like to create an attach API similar to that of @react-three/fiber, allowing non-directly-rendered components (like filters, textures, etc) to be automatically attached to their parent components. I'd also like to add support for creating Text components with normal JSX text nodes.
In short, I'd like to make the library as intuitive as possible. I'll add basic documentation for React Pixi, but the hope is that most APIs will be best served by the core Pixi.js documentation.
Development process
I've been using the dev branch as a sort of test bed for this update. Every update that's pushed to the dev branch of the repo will be deployed to the dev tag on npm. That said, these builds are not stable. Many of them will be completely broken until we're in a more stable place with the update (hopefully soon!). I do not recommend installing from the dev tag. You have been warned.
Once we're ready for user feedback, I'll post to the Official Pixi.js Discord. Make sure to join and enable notifications if you want to know when new versions are ready for testing. 😁
### Tasks
- [x] Add support for event handlers
- [x] Create the `<Application />` component
- [x] Fix types for nested components
- [x] Fix types for `useExtend` hook
- [x] Restore the `useApp` hook
- [x] Restore the `useTick` hook
- [x] Add support for prefixed components
- [x] Update "Getting Started" documentation
- [x] Write documentation for the `<Application />` component
- [x] Write documentation for the `extend` function
- [x] Write documentation for the `useExtend` hook
- [x] Write documentation for the `useAsset` hook
- [ ] Write tests!
- [ ] https://github.com/pixijs/pixi-react/issues/494
- [ ] https://github.com/pixijs/pixi-react/issues/495
- [ ] https://github.com/pixijs/pixi-react/issues/499
- [ ] https://github.com/pixijs/pixi-react/issues/500

Thanks for your work on this @trezy!
I wonder how much the pixi/react API night change? I know the Pixi 8 API changes a bit, but I'm wondering if the next version of pixi/react is expected to have its own set of API changes on top of that?

@Nantris: Yeah, the new API for Pixi React will be subtly different from v7. For example, here's a basic application with v7 vs the same application with v8:
// Pixi React v7
import { Container, Sprite, Stage, Text } from '@pixi/react';

export const MyComponent = () => {
  return (
    <Stage options={{ background: 0xffffff }}>
      <Sprite
        anchor={{ x: 0.5, y: 0.5 }}
        image="https://pixijs.io/pixi-react/img/bunny.png"
        x={400}
        y={270} />

      <Container x={400} y={330}>
        <Text
          anchor={{ x: 0.5, y: 0.5 }}
          text="Hello World" />
      </Container>
    </Stage>
  );
};

// Pixi React v8
import { Container, Sprite, Text } from 'pixi.js'
import { useAsset, useExtend } from '@pixi/react';

export const MyComponent = () => {
  useExtend({ Container, Sprite, Text })

  const texture = useAsset({ src: 'https://pixijs.com/assets/bunny.png' })

  return (
    <application background={0xffffff} >
      {texture && (
        <sprite
          anchor={{ x: 0.5, y: 0.5 }}
          texture
          x={400}
          y={270} />
      )}

      <container x={400} y={330}>
        <text
          anchor={{ x: 0.5, y: 0.5 }}
          text={'Hello World'} />
      </container>
    </application>
  );
};

A few important differences to notice:

No more components to import
All Pixi components are now mapped directly to JSX components. The only difference is that their JSX counterparts start with lowercase, to match the JSX paradigm that capitalized components are custom components and lowercased components are built-ins.
useExtend
Because we don't import anything directly from Pixi React, we need to let Pixi React know which Pixi components are available. This allows developers to import only what they need from Pixi.js and avoid a bloated build. This hook just wraps the extend function (also exported from Pixi React v8), which is available if you'd rather declare your extends once at the root of your application.
useAsset
This new hook wraps the Asset.add/Asset.load API, making it easier to load and cache assets within a Pixi React application. It also makes it possible to use <sprite> components conditionally based on the loaded state of their texture, which is necessary since Pixi.Sprite doesn't like being created without a texture.
<application>, not <Stage>
We wrap our components with <application> component, not a <Stage> component. As with all JSX components in v8, <application> maps 1:1 with Pixi.Application, so you can set all the same properties on it that you would when creating a new Pixi app outside of React (e.g. new Pixi.Application({ background: 0xffffff })).
Direct property mappings
The sprite component uses the texture property, not the image property. As with the <application> component, all properties are mapped 1:1 with their non-JSX counterparts. Changing these properties also works as you would expect with any other JSX component.

More additions
Once released, this syntax will always work. However, I intend to add a couple of other features that will add even more utility to the library:

attachAPI
Similar to react-three-fiber, you'll eventually be able to create your dependent properties as child nodes. For example, the following component would handle creating a texture and setting it on the parent <sprite>:<sprite anchor={{ x: 0.5, y: 0.5 }} x={400} y={270}>
  <texture src={'https://pixijs.com/assets/bunny.png'} />
</sprite>

Text nodes
Similar to the API above, you'll eventually be able to create <text> components with a child text node, rather than setting the text property:<text anchor={{ x: 0.5, y: 0.5 }}>
  Hello World
</text>

Custom applications
Most Pixi applications are created with Pixi.Application, automatically creating the renderer, ticker, and a handful of other pieces that you don't need to think about. I'd like to make it easy to create your own custom Pixi applications, allowing developers to customise the application and manage the minutiae on their own.

Just wanted to drop in and say thank you for the hard work. I've been using the v8 beta and its such a huge improvement. Very excited for the release ❤

+1 to the above. Very excited to see this drop!

This is exactly the feature I wanted.
The points I found lacking in Pixi were documentation and React compatibility, and I had the same thought while using @react-three/fiber.
I’m very excited and if I can contribute in any way, I would love to!

Bug report: refs
I sadly don't have time to debug further, but I wanted to report anyway: refs are seemingly broken?
Application ref
const Issue = () => {
  const ref = useRef(new Application());

  return <Application ref={ref} onInit={(app) => {
     console.log(ref.current, app); // `app` is not the ref!
  }}/>
}

ref.current != appInOnInit
Given ref will not be used. It is overwritten in createRoot - createRoot always creates a new Application instance. It should use the given ref if available.

Elements (<container />, etc.) ref
const Issue = () => {
  const ref = useRef(new Container());

  const [state, setState] = useState(1); // cause re-renders somehow, and then inspect actual UIDs (see below)

  return <container ref={ref} />
}

I don't have an exact repro case here, but there are two problems:
-<container /> (and so far, every other element) re-creates a new instance of their respective Container / Sprite etc. class

They also either don't use the ref, or overwrite / re-create it
This seems to happen (not 100% sure) when re-rendering / re-mounting, so you need to trigger some state or tree changes.

You can verify this by inspecting the uids of the Pixi containers in the Application instance:

If you make a native Pixi app where you create two Containers, their UIDs should be incremental. app.stage should always be 2 IIRC.
If you do the same in @pixi/react and then do state updates,  container's UIDs are all over the place, and you can see them changing if you log them, too. UIDs only change if class instances are re-created.
I could also see that the ref I made had the correct UID, unchanged, but wasn't used.

Screenshot of a small debug utility

These UIDs should be 2,3,4, etc.
Code to reproduce this small menu
Note: Quick and dirty.
interface ContainerInfo {
  constructor: string;
  uid: Container["uid"];
  label: Container["label"];
  scale: { x: number; y: number };
  position: { x: number; y: number };
  eventMode: Container["eventMode"];
  cursor: Container["cursor"];
  interactiveChildren: Container["interactiveChildren"];
  visible: Container["visible"];
  alpha: Container["alpha"];
  children: ContainerInfo[];
}

const buildContainerInfo = (container: Container): ContainerInfo => {
  const children = container.children.map((child) => buildContainerInfo(child));

  return {
    constructor: container.constructor.name.startsWith("_")
      ? container.constructor.name.slice(1)
      : container.constructor.name,
    uid: container.uid,
    label: container.label,
    scale: { x: container.scale.x, y: container.scale.y },
    position: { x: container.x, y: container.y },
    eventMode: container.eventMode,
    cursor: container.cursor,
    interactiveChildren: container.interactiveChildren,
    visible: container.visible,
    alpha: container.alpha,
    children,
  };
};

const Debug = () => {
  const app = useApp();

  const [info, setInfo] = useState<ContainerInfo | null>(null);
  useTick(() => {
    debounce(() => {
      setInfo(buildContainerInfo(app.stage));
    }, 200)();
  });

  if (!info) return null;

  return (
    <>

        Stage{" "}

          {info.constructor} ({info.uid})

        {info.children.map((child) => (

            {child.label}

              {child.constructor} ({child.uid})

        ))}

    </>
  );
};

@nightgrey Please delete your comment and create a new issue with these details. Leaving it in the comments of this ticket will result in the issue being lost in the clutter.

@trezy Thank you so much for your work! Would you say this is stable enough to start making hobby projects with it already? I would really love the new v8 performance

@P3ntest Yup! I've been using it in hobby projects already. 😁

This looks super cool! Currently looking at this option as a replacement for our current setup with svg elements and react-spring. Any thoughts on how the new architecture would handle something like the react-spring library for elements that are reactive and dynamic, or if it would still be necessary in the first place? For example, react-three/fiber suggests that for rapidly changing values, you either use something like react-spring or their useFrame hook. Thanks!

This looks super cool! Currently looking at this option as a replacement for our current setup with svg elements and react-spring. Any thoughts on how the new architecture would handle something like the react-spring library for elements that are reactive and dynamic, or if it would still be necessary in the first place? For example, react-three/fiber suggests that for rapidly changing values, you either use something like react-spring or their useFrame hook. Thanks!

For what it's worth, I've used both pixi-react v7 and v8 in small games with a lot of animations, once with only regular React state, and once with MobX, and it worked just fine. Contrary to popular opinion, React is perfectly capable of handling 60 fps, although you might have to keep an eye on performance and optimize rerenders sometimes.

amazing work; I personally have lots of small issues; some easy to work around, some less: react contexts behave weirdly, useApplication cause a lot of un-necessary re-renders, some conflicts with three fiber, but it looks super promising ! thanks

@trezy Hey! Thanks for your great work! Should I use vanilla Pixi8 with react or better to use pixi v7 but with pixi-react ?

@bulbazavr1024 Personally I'm using the latest beta with Pixi v8 in my projects already.
That said, I'm planning to get a release candidate ready over my winter break. That's going to include dropping support for React 18 and below in favour of supporting React 19. That could be a deal breaker for some folx, so it's probably an important thing to keep in mind.

@trezy Thanks for your reply! Do you have any estimate time when we can expect stable release version ? Do you plan to make breaking changes that will break beta and release version ?
And do you know about performance improvement version 8 vs 7 ?


Nginx with ACME and custom security.acme.directory

Issue description
Nginx always gets its keys for ACME enabled virtual hosts from /var/lib/acme/$cert:
https://github.com/NixOS/nixpkgs/blob/1bb0ecde4f46ca061b55b42b15e51f24c8dc3e39/nixos/modules/services/web-servers/nginx/default.nix#L16-L17
When setting a custom security.acme.directory however, the ACME service writes certificates and keys to the custom location which nginx does not know about:
https://github.com/NixOS/nixpkgs/blob/1bb0ecde4f46ca061b55b42b15e51f24c8dc3e39/nixos/modules/security/acme.nix#L175
Nginx can not read keys and certificates.
Steps to reproduce
Create a nginx virtual host with enableACME option and set security.acme.directory to something else than /var/lib/acme.
Nginx will not be able to find keys and certificates.
Possible fixes
Use security.acme.config when creating nginx configuration (is this possible?) or add note to enableACME option documentation indicating the issue.

Resolved with https://github.com/NixOS/nixpkgs/pull/38362


overlap between what?

Hello,
I recently worked with a User VPN Configuration where the p2s vpn client address pool overlapped with another network in the configuration (bgp routing). Users could connect to the User VPN, but could not access anything in the network. After reconfiguring the user vpn address pool, users were able to access other devices in the vWAN.
I see that address pools must be distinct, but this could easily be understood to mean user vpn address pools.

Address pools must be distinct. There can be no overlap between address pools.

From my recent experience, I believe it also can't overlap with any other address ranges in the associated Virtual WAN.
I opened #101697 thinking the above requirement was referring to all other address ranges in the Virtual WAN, but now I'm not so sure that's what it is saying.
Thanks!

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3ae73c06-2c9b-586e-9bb1-7b0672b6b3bd
Version Independent ID: 18542d5c-85a5-640f-5791-d0e41f43c5fc
Content: About client address pools for P2S User VPN - Azure Virtual WAN
Content Source: articles/virtual-wan/about-client-address-pools.md
Service: virtual-wan
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@jonwbstr
Thanks for your feedback! We will investigate and update as appropriate.

I see the thread https://github.com/MicrosoftDocs/azure-docs/issues/101697 has the same feedback.
I shall close this now.


Remove redundant test

Codecov Report

Merging #142 (71fba93) into master (693ddef) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #142      +/-   ##
============================================
- Coverage     17.06%   16.75%   -0.32%
+ Complexity      364      357       -7
============================================
  Files           195      195
  Lines          8917     8917
  Branches        286      286
============================================
- Hits           1522     1494      -28
- Misses         7312     7341      +29
+ Partials         83       82       -1

Flag
Coverage Δ

java
31.33% <ø> (-0.69%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...mq/client/java/impl/producer/ProducerSettings.java
0.00% <0.00%> (-16.67%)
:arrow_down:

...ient/java/retry/ExponentialBackoffRetryPolicy.java
0.00% <0.00%> (-16.28%)
:arrow_down:

...cketmq/client/java/impl/producer/ProducerImpl.java
0.37% <0.00%> (-5.60%)
:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


fix: Conditionally import required hook

This change makes the library only import the hook it's going to need based on the remote scheme.
As it is currently implemented, an environment that uses a S3 remote fails if it doesn't have the ssh Airflow provider installed:
Traceback (most recent call last):
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow_dbt_python/hooks/dbt.py", line 126, in get_remote
    return self.remotes[(scheme, conn_id)]
KeyError: ('s3', None)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow_dbt_python/hooks/dbt.py", line 300, in dbt_directory
    project_dir, profiles_dir = self.prepare_directory(
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow_dbt_python/hooks/dbt.py", line 345, in prepare_directory
    project_dir_path = self.download_dbt_project(
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow_dbt_python/hooks/dbt.py", line 158, in download_dbt_project
    remote = self.get_remote(scheme, self.project_conn_id)
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow_dbt_python/hooks/dbt.py", line 128, in get_remote
    remote = get_remote(scheme, conn_id)
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow_dbt_python/hooks/remote.py", line 147, in get_remote
    from .git import DbtGitRemoteHook
  File "/usr/local/airflow/.local/lib/python3.10/site-packages/airflow_dbt_python/hooks/git.py", line 5, in <module>
    from airflow.providers.ssh.hooks.ssh import SSHHook
ModuleNotFoundError: No module named 'airflow.providers.ssh'

The same happens when the environment uses a remote that requires the SSH hook, and doesn't install the aws Airflow provider.

Nice, thanks for fixing this one. I'll put out a patch release with tag v1.0.1.
I keep introducing bugs around conditional imports as my dev environment tends to have everything, so I'm wondering if we can add some tests to the test matrix that run under a partial environment :thinking:

Glad to add more contributions to this great project! :)
Regarding how to improve coverage to avoid these issues moving forward, I think the CI matrix can be extended to include different extras being installed (being the current CI configuration what we would get when all extras are included).
With that, tests can be gated with pytest.importorskip, to not fail when an expected dependency is installed.
I'll try to implement a simple change to the CI that would have caught this issue.


[WIP] Adding travis file to check grammar

Note this also includes a script by Saulius, downloaded
from http://saulius-grazulis.lt/~saulius/scripts/
with the only modification of changing perl5 -> perl
Note: Grammar tests were added in #10
This fixes #52
Please follow the guidelines here to create a new pull request.
If your pull request requires discussion, make sure the OPTIMaDe developer list is alerted (for more info see the link above.)

@sauliusg The Makefile needs some fixes and I need your help here.
The .travis.yml file I added make the test run and "pass", but actually the tests are failing.
Here the issues I found.
High priority:

now tests are failing, still we get a zero error status - this should be fixed (both when the files are not found at the beginning:make tests
tests/makefiles/Makelocal-grammars:27: .grammars.d: No such file or directory
tests/makefiles/Makelocal-tests:41: tests/cases/.ebnf_numbers_001.d: No such file or directory
tests/makefiles/Makelocal-tests:41: tests/cases/.ebnf_numbers_002.d: No such file or directory
[...]

and when the later tests fail. (one way, if done in bash, is to use set -e at the top of the script (see e.g. this explanation and to make sure that, if you pipe in case of errors, still the error code of each line is the correct one: e.g. this is wrongls filename || echo "not found"

while this is okls filename || ( echo "not found" ; exit 1 )

I added a script that was missing as indicated in the commit message. Still, for some reason some files are not found, I don't know why

Lower priority:

is there any guarantee that the tools that we are downloading are always going to be there (grammatica, grammatiker, ...). Maybe it's better if we fork that project inside Materials-Consortia and we download the release from our fork, so we guarantee that the tests don't stop passing because the author removed his repo?

@sauliusg can you fix these issues and make another PR (or take my commit and work on it, as you wish)? Thanks!

make tests
tests/makefiles/Makelocal-grammars:27: .grammars.d: No such file or directory
tests/makefiles/Makelocal-tests:41: tests/cases/.ebnf_numbers_001.d: No such file or directory
tests/makefiles/Makelocal-tests:41: tests/cases/.ebnf_numbers_002.d: No such file or directory
[...]

Actually, these lines are not test failures, these are regular Make messages; and later Make wuild build the missing files himself. :)

Ok thanks for the clarification. Maybe it would be good do do a >/dev/null 2>&1 then?
In any case, the important point is to make sure that if the final state is not fully correct, the exit status is not zero.

This is superseded by #62


Twig replace now take an array parameter

The replace('%%', '%') is deprecated (since<EMAIL_ADDRESS>and is removed in<EMAIL_ADDRESS>Updating it by replace({ '%%': '%' }) fixes this :smile: .
https://stackoverflow.com/questions/33891023/deprecation-of-twig-filters-use-twig-simplefilter-instead

Thank you for reporting, I'll fix this within the next feww days :)

Is there any chance of this being merged into the main repo, please? Working with Symfony 4 this now presents an error using this bundle. A tagged release would also be welcome. Thanks!

Just merged the PR. Thank you for your patience. I'm sorry for almost abandoning this project, I just haven't had the time to do anything since I started studying for my BSc.
Could this issue be resolved?

@iainhallam Added a tagged release: https://github.com/thormeier/breadcrumb-bundle/tree/2.2.0

Hey! No need to excuse.
You are probably working on totally different stuff now (I have not been using Symfony since then).
You did your best at the time and it has been really useful. I'm really thankful for the work you did and lots of other persons probably are as well 😄
Thanks for closing this issue!


SPIKE: Turn on CSPM for AWS in Azure

Describe the Issue
As part of turning CSPM off in AWS, Investigate the process to turn on the AWS telemetry feed into Azure CSPM (Defender for Cloud)
Additional Context
To run through the procedure in AWS for turning this on from the enablement documentation
Acceptance Criteria

Learn the procedure for enabling this CSPM telemetry feed in Defender for Cloud CSPM
Discuss this process with Warren and run through any caveats
Prepare the final method in prep for the implementation tickets

.
.
.
.
.
.
.
.
.
.
.
Extra Template Info
Definition of Ready
These set of conditions will need to be met in order to bring a ticket into the sprint and start work. Protects the team from unclear requirements.
Issues (Task/Story/Spike) aligned to an EPIC and linked appropriately.
Assigned to the appropriate CPF MEMBER (and is not left blank in ZenHub) at the start of sprint (1st day of the sprint)
Acceptance has been defined for the issue and has been reviewed with CPF team and approved by the necessary approver.
Has been sized and estimated by the delivery team.
Detailed breakdown of the steps required to complete the story in the additional context
Any additional specifications have been documented, reviewed with CPF and approved by the necessary approver.
Acceptance Criteria
A set of pre-defined requirement that need to be met in order to mark the user story as “done”.
It should be testable with no room for interpretation
It should be either “pass” or “fail”
It should be clear enough for business stake holders to understand
As part of the user story, it should be written from the user perspective
A well written acceptance criteria is great for

managing expectations
defining scope
reducing ambiguity
establishing testing criteria for QA
Given (Pre-condition)
When (Action)
Then (Outcome)

Definition of Done
These set of conditions are met for work to be considered as complete on an issue.
All acceptance criteria(s) have been validated.
All the necessary documentation for the issue has been uploaded to Teams.
Functionality has been tested when applicable.
Functionality has been demonstrated to the relevant stakeholders (where applicable).
Story has been scheduled for a Sprint Demo/community update and impacted teams invited to the Demo.
Stories accepted by PO and documented for potential sharing with impacted users.

Documented = Captured in Community Update (CU) deck
Release notes = aspirational goal of providing a bulleted list of features and changes that our users can touch. Was going to store them in our Cloud Pathfinder repo. Can also display to users in the CU

Investigation completed for this in Sprint ending Dec. 16th - Investigated the process for turning on CSPM.  Will work with Warren to complete this process in next ticket for this.  Closing ticket


Update Microsoft.PolicyInsights .NET SDK

All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] Please open PR in Draft mode if it is:

Work in progress or not intended to be merged.
Encountering multiple pipeline failures and working on fixes.

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec
changes has been included above.
Swagger pull requests:
https://github.com/Azure/azure-rest-api-specs/pull/16250
https://github.com/Azure/azure-rest-api-specs/pull/12661
https://github.com/Azure/azure-rest-api-specs/pull/10798
[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:
Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

[ ] Include updated management metadata.
[ ] Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

If the check fails at the Verify Code Generation step, please ensure:

Do not modify any code in generated folders.
Do not selectively include/remove generated files in the PR.
Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

/azp run net - mgmt - ci

/azp run net - mgmt - ci

@Yao725 Can you please merge this PR? Thanks!

@Yao725 Can you please merge this PR? Thanks!

Hi @eladperets , the ci failed because of the code discrepancy between your PR and reference generation. Have you modified the generated code in Generated folder and why?

@Yao725 Can you please merge this PR? Thanks!

Hi @eladperets , the ci failed because of the code discrepancy between your PR and reference generation. Have you modified the generated code in Generated folder and why?

@Yao725  yes, I have modified it. The generated code has methods with weird names like NextLink1WithHttpMessagesAsync, which we renamed to something more meaningful. This already existed in previous versions of the SDK, but every time we re-generate it we need to manually rename these methods.
I tried to break down the PR to several commits to  make it easier to see. The first commit contains the raw output of autorest. You can see it changes some of the method names. The second commit reverts the method names to their old and more readable names. The rest of the changes include the new changes to the API and their tests.

@Yao725 Can you please merge this PR? Thanks!

Hi @eladperets , the ci failed because of the code discrepancy between your PR and reference generation. Have you modified the generated code in Generated folder and why?

@Yao725 yes, I have modified it. The generated code has methods with weird names like NextLink1WithHttpMessagesAsync, which we renamed to something more meaningful. This already existed in previous versions of the SDK, but every time we re-generate it we need to manually rename these methods.
I tried to break down the PR to several commits to make it easier to see. The first commit contains the raw output of autorest. You can see it changes some of the method names. The second commit reverts the method names to their old and more readable names. The rest of the changes include the new changes to the API and their tests.

@eladperets Yeah, that makes sense to me and I can merge it. But I think it is a more efficient way to implement renaming by using directive which could guarantee CI pass and avoid manually changing it each time. Maybe we can do it in track 2 SDK.

/check-enforcer override


Memory Leak - Ping Configuration

I am experiencing a memory leak related to the PingConfiguration struct. I am following the example in the Read-Me, sending a single ping, but after every ping, the PingConfiguration is not deallocated. Could be something I am doing wrong, but I think I am just following the basic example...

If I ping and address lets say 3 times, and then I go to the "View Memory Graph Hierarchy" I see at the top "SocketInfo(3)".
So no matter how many times I ping an address, SocketInfo shows that many items in it. Looks like the sockets are being created but not removed after the ping completes.

Please see my Pull Request, which contains a fix

This should be fixed in v1.1.14


seg fault -> cannot call set global volume more than once in the same program

Describe the bug
im trying to create 2 Soloud instances in the name scope and set the global volume to some value also 2 times.
after running the code i get segfault core dumped.
To Reproduce
Steps to reproduce the behavior:

get this code

    let mut sl = Soloud::default()?;
    sl.set_global_volume(3.0);

    let mut wav = audio::Wav::default();

    wav.load("noice.mp3")?;

    let mut sl2 = Soloud::default()?;
    sl2.set_global_volume(3.0);

    let mut wav2 = audio::Wav::default();
    wav2.load("bizwarn_minus_15.wav")?;

cargo run
the error is

Assertion 'm->state == STATE_PASSIVE' failed at ../pulseaudio/src/pulse/mainloop.c:808, function pa_mainloop_prepare(). Aborting.
[1]    723251 IOT instruction (core dumped)  cargo run -q --example simple

and also i get this error:
Assertion 's' failed at ../pulseaudio/src/pulse/stream.c:1708, function pa_stream_drain(). Aborting.
[1]    723328 IOT instruction (core dumped)

the error from the same code its kinda random.
Expected behavior
instantiate 2 Soloud objects and set the global volume.

       Fresh rule_202020 v0.1.0 (...)
    Finished dev [unoptimized + debuginfo] target(s) in 0.07s

Additional context
if i comment this line
    let mut sl = Soloud::default()?;
    sl.set_global_volume(3.0);

    let mut wav = audio::Wav::default();

    wav.load("noice.mp3")?;

    let mut sl2 = Soloud::default()?;
    // sl2.set_global_volume(3.0);              <--- this line

    let mut wav2 = audio::Wav::default();
    wav2.load("bizwarn_minus_15.wav")?;

the error is gone. meaning that i cannot set the global volume 2 times in the same program/application. this is what i noticed. is this right ?
if so, then why i cant ?
why
Q: why im making 2 instances of Soloud and set global volume everything ?
A: because im making a struct which looks like this
    #[derive(Debug)]
    pub struct MusicPlayer {
        player:  Soloud,
        wav:     Wav,
        playing: bool,
        handle:  Option<Handle>,
    }

and has this implementation
    impl MusicPlayer {
        pub fn new() -> Result<Self, SoloudError> {
            let mut sl = Soloud::default()?;
            sl.set_global_volume(2.0);

            let mut wav = Wav::default();
            Ok(Self {
                player: sl,
                wav,
                playing: false,
                handle: None,
            })
        }

        pub fn load_file<P: AsRef<std::path::Path>>(
            &mut self,
            path: P,
        ) -> Result<(), SoloudError> {
            self.wav.load(path)?;
            Ok(())
        }

        pub fn pause_playing(&mut self) {
            if let Some(handle) = self.handle {
                self.playing = false;

                self.player.set_pause(handle, true);
            }
        }

        pub fn continue_playing(&mut self) {
            if let Some(handle) = self.handle {
                self.playing = true;
                self.player.set_pause(handle, false);
            }
        }

        pub fn is_done_playing(&self) -> bool {
            self.player.voice_count() == 0
        }

        pub fn is_playing(&self) -> bool {
            self.player.voice_count() > 0
        }

        pub fn play_music(&mut self, wait: bool, timeout: Option<u64>) {
            self.playing = true;
            let handle = self.player.play(&self.wav);
            self.handle = Some(handle);
            if wait {
                // calls to play are non-blocking, so we put the thread to sleep
                while self.is_playing() {
                    if let Some(timeout) = timeout {
                        std::thread::sleep(std::time::Duration::from_millis(
                            timeout,
                        ));
                    }
                }
            }
        }
    }

and im creating 1 instance of Soloud and set the global volume everytime i call new because the programmer user can make only 1 instance of MusicPlayer in their program. and im making sure the volume its set at least once.

Unfortunately Rust doesn't have a concept of singleton or pre-main static initialization. Similarly you can't ensure that there is only 1 instance of MusicPlayer. I would suggest using smart pointers so basically all references to Soloud refer to the same instance:
use soloud::*;
use std::cell::RefCell;
use std::rc::Rc;

struct MyPlayer {
    sl: Rc<RefCell<Soloud>>,
    wav: Rc<RefCell<Wav>>,
}

impl MyPlayer {
    pub fn new(sl: Rc<RefCell<Soloud>>, wav: Rc<RefCell<Wav>>) -> Self {
        MyPlayer {sl, wav}
    }
    pub fn set_vol(&mut self, val: f32) {
        self.sl.borrow_mut().set_global_volume(val);
    }
    pub fn play(&self) {
        self.sl.borrow_mut().play(&*self.wav.borrow());
    }
    pub fn playing(&self) -> bool {
        self.sl.borrow().voice_count() > 0
    }
}

Then you can have multiple instances of MyPlayer and this won't hit the assert.

fn main() -> Result<(), Box<dyn std::error::Error>> {
    let mut sl = Soloud::default().unwrap();
    let sl = Rc::from(RefCell::from(sl));

    let mut wav = audio::Wav::default();
    wav.load("song.mp3")?;
    let wav = Rc::from(RefCell::from(wav));

    let s1 = MyPlayer::new(sl.clone(), wav.clone());
    s1.set_vol(3.0);

    let mut s2 = MyPlayer::new(sl, wav);
    s2.set_vol(1.0);

    s1.play();
    while s1.playing() {
        // calls to play are non-blocking, so we put the thread to sleep
        std::thread::sleep(std::time::Duration::from_millis(100));
    }

    Ok(())
}

Another thing you can do to ensure only one instance of MusicPlayer is the create a static variable INITIALIZED which would initialize only once, but even then, if a user tries to initialize another instance of MusicPlayer, you can either ignore it (which will hit the pulseaudio assert), or just panic or return an error.
lazy_static::lazy_static! {
    static ref INITIALIZED: AtomicBool = AtomicBool::new(false);
}

    pub fn new(sl: Rc<RefCell<Soloud>>, wav: Rc<RefCell<Wav>>) -> Self {
        if INITIALIZED.load(Ordering::Relaxed) {
            panic!("MusicPlayer already initialized!");
        } else {
            INITIALIZED.store(true, Ordering::Relaxed);
        }
        MyPlayer {sl, wav}
    }

thanks for reply.
actually, i've found something interesting the other night.
it was not the problem of calling set global volume 2 times in a row.
the problem was that i was making 2 instances of my struct with soloud object inside.
no matter if i loaded a wav file 2 times in a row, but the problem was having 2 structs at the same time with soloud.
so i think the solution to this is singleton.
and also your response is very interesting. thanks. i will try it and tell the results.

i just read your answers again this day on 11.07.2022 and im really impressed.
your answers are really good. both of them are really good. thanks a lot.


typo: schema.or

File https://github.com/kg-construct/use-cases/blob/master/inria-kg-vs-webapis.md contains a typo: schema.or should be schema.org

solved, thanks!


Investigate the difference in speedup between Llama3-8b and Mistral-7B-v0.1

🚀 Feature
Make Thunder +  Mistral-7B-v0.1 as fast as Thunder + Llama3-8b (comparing to Eager mode).
Motivation
Below are data for:

Llama3-8b:

Mistral-7B-v0.1:

Plot comparing them:

The main difference is that Mistral-7B-v0.1 fits into 1 GPU, but Llama3-8b not, so for Llama3-8b we use distributed training.

Llama-3-8b config:

    # https://huggingface.co/meta-llama/Meta-Llama-3-8B/blob/main/config.json
    dict(
        name="Llama-3-8B{}",
        hf_config=dict(org="meta-llama", name="Meta-Llama-3-8B{}"),
        block_size=8192,
        vocab_size=128000,
        padded_vocab_size=128256,
        n_layer=32,
        n_head=32,
        n_query_groups=8,
        rotary_percentage=1.0,
        parallel_residual=False,
        bias=False,
        norm_class_name="RMSNorm",
        mlp_class_name="LLaMAMLP",
        intermediate_size=14336,
        rope_base=500000
    )

Mistral-7B-v0.1 config:

    dict(
        name="Mistral-7B-{}v0.1",
        hf_config=dict(org="mistralai", name="Mistral-7B-{}v0.1"),
        padded_vocab_size=32000,
        block_size=4096,  # should be 32768 but sliding window attention is not implemented
        n_layer=32,
        n_query_groups=8,
        rotary_percentage=1.0,
        parallel_residual=False,
        bias=False,
        norm_class_name="RMSNorm",
        norm_eps=1e-05,
        mlp_class_name="LLaMAMLP",
        intermediate_size=14336,
    )

Reposting from Slack:
Here are the differences in their configs (the first values are for Mistral, and the second values are for Llama):
{'block_size': 4096,
 'padded_vocab_size': 32000,
 'rope_base': 10000,
 'sliding_window_layer_placing': 1,
 'sliding_window_size': 4096,
 'vocab_size': 32000

{'block_size': 8192,
 'padded_vocab_size': 128256,
 'rope_base': 500000,
 'sliding_window_layer_placing': None,
 'sliding_window_size': None,
 'vocab_size': 128000}

The main difference here is that Mistral config uses sliding window attention mask (sliding_window_layer_placing) so the "if self.apply_sliding_window_attention" codepath is taken. If attn_mask is not None probably a different kernel is chosen in cuDNN that could be less efficient compared to a kernel available in PyTorch.

@vedaanta's response:

On the above topic, cudnn does have performant kernels for sliding_window_attention on Hopper.
In the code path linked by Ivan, the mask is being materialized. And cudnn kernels today are much slower when reading from gmem before the softmax.
BUT
If thunder can somehow pass the sliding window size to cudnnex, it can just generate the mask on the fly and provide good speedup. (maybe a sliding_window_size in ltorch.sdpa just like the is_causal option)

Let's measure what speedup can be achieved by not materializing the mask and using the special attributes for implicit masking instead. We have a parametrized SDPA benchmark
https://github.com/Lightning-AI/lightning-thunder/blob/79e59d0c5c5f8aa8ef80eb31f3fe918466d64c1c/thunder/benchmarks/targets.py#L386
and its function definition is living here
https://github.com/Lightning-AI/lightning-thunder/blob/79e59d0c5c5f8aa8ef80eb31f3fe918466d64c1c/thunder/benchmarks/__init__.py#L2634-L2636
It's straightforward to change "torch.nn.functional" -> "thunder.torch" to benchmark only Thunder implementation. Then the sliding window length parameter needs to be passed to the cuDNN executor (here's an example usage https://github.com/NVIDIA/cudnn-frontend/blob/de355c7094af70467f2b264f531ab5c5f4401c42/test/python_fe/test_mhas.py#L677).


Functions and values missing/inconsistent in Python §1

I'm comparing the specs in
https://docs.sourceacademy.org/source_python_1.pdf
with the current implementation and find that the following declarations are missing/inconsistent:

undefined: Page 5: This should be removed from the specs, because it's JS-specific
NaN: Page 5: this should be math_nan and moved below
Infinity: Page 5: this should be math_inf and moved below
String(x): Page 6: should be str
math_PI: Page 6: More pythonic might be math_pi
math_E: Page 6: should be math_e
On page 6, we should not refer to https://262.ecma-international.org/9.0/#sec-math-object but to the Python math library. We should make sure that all functions are consistent with Python's math library.

all handled


[BUG] iconvert not working -- image rotation

Describe the bug
I've installed OpenImageIO & openColorIO as I want to bake-aces to my exr files. But when I try to run for example >
openimageio\iconvert.exe  --inplace --rotcw "G:\private_CGI\2018-05-15_Vray4\images\tmp\camTest\Aces_test_01_masterLayer_01 - Copy.exr"
I get the exact same image out. No rotation.
To Reproduce
.\vcpkg install opencolorio[tools]:x64-windows --recurse
.\vcpkg install openimageio[opencolorio,tools]:x64-windows --recurse
Expected behavior
Image to be rotated in place...
Evidence
No errror/etc
Platform information:
Windows 10x64
vcpkg manager
Can any1 suggest as to what I'm doing wrong here?

Did this adequately answer the question? Closing because I don't think there is a bug here, this is the expected behavior.


fix: session restoring, amount to string error

:tada: This PR is included in version 3.16.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


About side bar on github says Juce 7

When first opening the github page, the About description lists Juce 7 rather than 8.

Thanks for the catch!


Fix a problem with dependencies which prevents from running examples on MacOS

This PR updates some dependencies so that to be able to run examples  (at least on MacOS).
For instance, when trying to execute the simple example,  no shape is actually rendered (when executing cargo run --package simple) without this update (again, on a MacOS, x86_64)

The update to wgpu 23 is already ongoing in #735. Can you try running examples using that branch? Would be good to know if your issues go beyond the wgpu update.

The update to wgpu 23 is already ongoing in #735. Can you try running examples using that branch? Would be good to know if your issues go beyond the wgpu update.

Ooops... I did not see #735 PR. Sorry. It in fact fixes the same issue. So let me close this PR.

I'm confused as to why simple isn't rendering something and with_winit is ... that seems to be a bug that should be looked into separately from the update of wgpu?

Right, but the question is "Why is it failing in just the one example?" and going back, it seems to be failing for a while for me too. Is this due to an OS update or ... ?

Gotcha! Now I understand your question. I'll also dig more on my side.


test: tweak test data for the Text type

Please revert the changes to test class ordering. Additionally, could this logic be extended to other test classes or is it unique to TextTest?

Not sure what does it mean "to test class ordering".
Yeah, I suppose there is a couple of more test cases, which could use the similar data definition override instead of overriding every test - that's what I was talking about earlier. Still, all of the PRs now merged, so it's not very obvious on which tests this logic can be extended. Requires a local revert and closer look.

Not sure what does it mean "to test class ordering".

Ah, my wording was unclear. The test classes have been reordered e.g. QuotedNameArgumentTest and StringTest have both been moved to a different place. Please revert this reordering so the diff shows the changes more clearly unless there was a reason for the reordering.

Yeah, I suppose there is a couple of more test cases, which could use the similar data definition override instead of overriding every test - that's what I was talking about earlier. Still, all of the PRs now merged, so it's not very obvious on which tests this logic can be extended. Requires a local revert and closer look.

This looks to have been address in #75 so once the reordering has been addresses this LGTM :+1:

@larkee, oh, I got it. Reverted.


Vendor document number and Transaction type for creating invoices in IntAcct

Vendor document number: HP######
Transaction type "Contract Invoice Release"

We thinking the vendor document number: HP###### could be the Invoice Number (see image below)

@sks444 @frjo Designs for how the Invoice number should look for each user view:


Update search tests and lintings

This extends on @W0lfw00d's awesome search PR that was just merged.

Cleans up some linting issues
Create tests for new search endpoint
Include package description in search results
Cleans up the resolved search results structure

Coverage increased (+3.6%) to 100.0% when pulling 0d1d004d804ce1e8635f88f86e6a9fe17d17f54f on fix-linting-tests into<PHONE_NUMBER>ec904e1fc3b7f800c5e3c3e643468d on develop.


Fix relative ordering of comments and translator comments

The PO file format documentation indicates that "# " comments should appear before "#." comments (https://www.gnu.org/software/gettext/manual/html_node/PO-Files.html). Also the gettext source code calls message_print_comment() before message_print_comment_dot() when writing a PO file.

This PR includes a new unit test and also fixes existing tests to comply with this behaviour.

Codecov Report

Merging #126 (066fc3c) into master (bc4732a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   95.53%   95.53%
=======================================
  Files           1        1
  Lines         852      852
=======================================
  Hits          814      814
  Misses         38       38

Impacted Files
Coverage Δ

polib.py
95.53% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Add support for the xDai chain and the XDAI token

This is a feature request to include XDAI in BRD.
The xDai chain is a proof-of-stake layer-2 network on top of Ethereum, currently permissioned but moving toward permissionlessness. Its native token, the XDAI is backed 1:1 with the DAI stablecoin. XDAI can be turned into DAI and back through a token bridge contract operated by the xDai chain validators. This way, just like with DAI, every XDAI is also soft-pegged to the USD. This network is special because its native token is a stablecoin, and fees are also paid in this same token, doing away with the UX pain of needing ETH to transact DAI. The consensus mechanism also offers quick confirmations (5 sec block time) and low fees (sub-cent).
These make XDAI a good fit for everyday stablecoin payments and mass adoption while we wait for Ethereum to become scalable and for a native meta transaction standard to settle on.
Thanks for considering supporting it!
Homepage
Official forum
Block explorer
DeFi Pulse page

Thanks for the detailed request.  This is not currently a priority but we will take it into consideration.


Remap .env to .custom

Remap .env to .custom
The folder ~/.custom sems to be a more common convention than ~/.env (which could be misleading) hence this issue.

Realized in: 368e526c8a86c730b92b1ebc1a603794b9c68fa6


Fix race condition

Masterships calls Resign

Was this closed on purpose, or needs review?

I closed it on purpose.  I was trying to solve a race condition that rarely
occurs in the test.
I still can't find it, but I convinced myself that this was not the right
fix.
On Wed, Mar 25, 2020 at 2:50 PM Pavel Kalinnikov<EMAIL_ADDRESS>wrote:

Was this closed on purpose, or needs review?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/google/keytransparency/pull/1505#issuecomment-603883385,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABQOTWPSR2WWZL2IF55DYTRJIK2NANCNFSM4LTPYMKQ
.


[Bug]: open https link in mini app with inner safari browser

Telegram Application
Telegram for iOS
Describe the Bug
as a telegram mini app developer, I'm going to open a https link e.g. https://www.google.com/
but I will get jump into safari app and open this link, NOT open it in the telegram's inner safari browser
I have tried these functions blow, none of them works, can anyone who have the same issue and found any solutions?
const url = "https://www.google.com"
// 1. tried with telegram sdk
import {initUtils} from "@telegram-apps/sdk-react";
const utils = initUtils()
utils.openLink(url, {
tryInstantView: true,
tryBrowser: true
})
// 2. tried with telegram post event
const data = JSON.stringify({
url,
try_instant_view: true
});
window.TelegramWebviewProxy.postEvent('web_app_open_link', data);
// 3. tried with js methods
window.open(url, "_blank")
if use "_self" or "_parent", the website will open in the mini app's current page, which is not I want
To Reproduce
Steps to reproduce the behavior:

open any https links in mini app

Expected Behavior
open the page in the inner safari browser instead of safari app

tryBrowser is undocumented by Telegram, so we can't rely on this parameter. You also should specify not true, but the browser identifier.
Try using tryBrowser: 'safari'. Until then, I don't know any other possible way of avoid opening the link outside the Telegram application. I don't think there is any

thanks @heyqbnk for your reply ~
I'm using the react version SDK
"@telegram-apps/sdk-react": "^1.1.3",
as you says, I tried to set the tryBrowser to safari, it no works
then I tried install the js version SDK and tried like this:
import { openLink } from '@telegram-apps/sdk';

openLink('https://telegram.org', {
  tryBrowser: 'chrome',
  tryInstantView: true,
});

but 1. try tryBrowser has no param 'safari', even I set the tryBrowser to 'safari' it still open the link in the safari app, NOT the inner safari browser
I found that the ton wallet tg mini app can open the explorer url in the inner safari browser, after check the their html code, they are using:
在区块链浏览器中查看

however, as I tried to add this  to my demo mini app, the page still open in the safari app, not inner safari  quite amazing

I want to open the link in the internal Telegram browser
coz the link is a website dapp, can connect with other mini tg wallet apps
import {initUtils} from "@telegram-apps/sdk-react";
const utils = initUtils()
utils.openLink(url, {
    tryInstantView: true,
    tryBrowser: true
})

above code works well on android side, but on iOS side it can not open the link in the internal Telegram browser

I am not sure I can really help with this question. The problem is probably on the Telegram for iOS side. They should probably improve the openLink method to choose how to open the link exactly

Closing due to we have nothing to do here. Just waiting for this feature to be implemented by Telegram devs


Bugfix: kubernetes/client/init.py was not updated resulting in not exported models

fixes #101

Current coverage is 94.52% (diff: 100%)

Merging #103 into master will not change coverage

@@             master       #103   diff @@
==========================================
  Files             9          9
  Lines           658        658
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            622        622
  Misses           36         36
  Partials          0          0

Powered by Codecov. Last update daa0562...1d542e8

LGTM

Looks good (for https://github.com/kubernetes-incubator/client-python/issues/101). Thanks !