Receipt validation

I want to validate purchases made in my backend, and save the value there. Is there a way to do this using Gdx-pay?

Not really related to gdx-pay specifically, but weighing in here on the topic.  You can locally verify and/or submit the receipt to the app store verification end point.
If you are just interested in locally verifying, I suggest you write a binding that wraps a unique verification strategy for you app.  Having this strategy as part of an open source library makes it very easy to bypass verification on any app that uses the library.  The reason I suggest a native binding is the ease of accessing openssl, which makes your life a lot easier when verifying the payloads and containers.
You can also verify using the app store end point, by sending off the receipt to the app store api, and parsing the result.  This should only really be done on a server you are running, as you can't guarantee the connection between the app>appstore is trusted.  Although its possible and trivial to do it from the app, its not recommended you do so, but its up to you what level of protection you are willing to go to. Everything is crackable.

@Tom-Ski Thanks :)
Is there a way to get the receipt-object using gdx-pay? So that I can use it. Or do I need to look into platform specific stuff?

I'm not familiar with this project, but you can see the robovm gdx-pay backend accessing the receipt here:
https://github.com/libgdx/gdx-pay/blob/master/gdx-pay-iosrobovm-apple/src/main/java/com/badlogic/gdx/pay/ios/apple/PurchaseManageriOSApple.java#L383 where validation isn't implemented yet, as it states in the comments.
You can grab the receipt outside of gdx-pay by doing the same, just as these two lines show https://github.com/libgdx/gdx-pay/blob/master/gdx-pay-iosrobovm-apple/src/main/java/com/badlogic/gdx/pay/ios/apple/PurchaseManageriOSApple.java#L380-L381
As the receipt is ios only, I doubt there is a utility method to obtain it in a cross-platform friendly way, but I would advise you write your own platform specific code for this stuff anyway.

There is a sample for the purchase verification in gdx-pay:
https://github.com/libgdx/gdx-pay/blob/master/gdx-pay-server/src/com/badlogic/gdx/pay/server/impl/PurchaseVerifieriOSApple.java
It needs some cleanup & testing. However, that's the code that should go onto your server for purchase verification.

@noblemaster thanks man! Is there something similar for Android that you know of?

Yes, it's described here:
http://stackoverflow.com/questions/11115381/unable-to-get-the-subscription-information-from-google-play-android-developer-ap
Here is some code that I wrote. I should have integrated it into gdx-pay, just simply haven't found the time. Do you have time to adapt it to gdx-pay & submit a pull request?
/**
 * Server-side purchase verification for Google Play.
 *

 * Required JARs:
 *

 *
google-api-services-androidpublisher-v2-rev20141111-1.19.0.jar
 *
google-api-client-1.19.0.jar
 *
google-oauth-client-1.19.0.jar
 *
google-http-client-1.19.0.jar
 *
jsr305-1.3.9.jar
 *
google-http-client-jackson2-1.19.0.jar (when using Jackson 2)
 *
jackson-core-$2.1.3.jar
 *

 * Information:
 *

 *
Our credentials are here: https://console.developers.google.com/apis/credentials
 *
We use project "Google Play Android Developer" (stay the same for multiple projects)
 *

 * To obtain OAuth, refer to the following pages:
 *

 *
https://developers.google.com/android-publisher/authorization
 *
http://stackoverflow.com/questions/11115381/unable-to-get-the-subscription-information-from-google-play-android-developer-ap
 *

 *
 * @author noblemaster
 */
public class CashierVerifyGoogle implements Cashier.Verify {

  private static final HttpTransport HTTP_TRANSPORT = new NetHttpTransport();
  private static final JsonFactory JSON_FACTORY = new com.google.api.client.json.jackson2.JacksonFactory();

  /** The application name. Suggested format is "MyCompany-Application/1.0". */
  private String productName;
  /** The application package, e.g. "com.ageofconquest.app.user.aoc". */
  private String productPack;

  /** Client ID from Google Developer Console. */
  private String clientID;
  /** Client Secret from Google Developer Console. */
  private String clientSecret;
  /** The refresh-token: generate via our "OAuth20Printer.java"!. */
  private String refreshToken;

  public CashierVerifyGoogle(String productName, String productPack, String clientID, String clientSecret, String refreshToken) {
    this.productName = productName;
    this.productPack = productPack;

    // store connection-information
    this.clientID = clientID;
    this.clientSecret = clientSecret;
    this.refreshToken = refreshToken;
  }

  @Override
  public Market exchange() {
    return Market.GOOGLE;
  }

  @Override
  public void valid(Purchase purchase, String location) throws Failure {
    try {
      // obtain access-token (only temporary, so we need to refresh every time!)
      String accessToken = OAuth20.getAccessToken(OAuth20.PATH_GOOGLE, clientID, clientSecret, refreshToken);

      // purchase parameters
      String productId = purchase.getResourceExchange();
      String purchaseToken = purchase.getPurchaseDataSignature();

      // use AndroidPublisher to access our purchase-data!
      TokenResponse tokenResponse = new TokenResponse();
      tokenResponse.setAccessToken(accessToken);
      tokenResponse.setRefreshToken(refreshToken);
      tokenResponse.setExpiresInSeconds(3600L);
      tokenResponse.setScope("https://www.googleapis.com/auth/androidpublisher");
      tokenResponse.setTokenType("Bearer");

      HttpRequestInitializer credential =  new GoogleCredential.Builder().setTransport(HTTP_TRANSPORT)
                                                                         .setJsonFactory(JSON_FACTORY)
                                                                         .setClientSecrets(clientID, clientSecret)
                                                                         .build()
                                                                         .setFromTokenResponse(tokenResponse);
      AndroidPublisher publisher = new AndroidPublisher.Builder(HTTP_TRANSPORT, JSON_FACTORY, credential)
                                                       .setApplicationName(productName)
                                                       .build();

      // we use the publisher to obtain the purchase data (if valid, we should receive it!)
      AndroidPublisher.Purchases purchases = publisher.purchases();
      AndroidPublisher.Purchases.Products.Get purchasesGet = purchases.products().get(productPack, productId, purchaseToken);
      ProductPurchase productPurchase = purchasesGet.execute();

      // verify purchase
      if (productPurchase != null) {
        // log debug-info as needed!
        Log.d("GooglePlay purchase information successfully located/verified for purchase " + purchase + ".");
      }
      else {
        // error: not purchase found!
        throw new Failure("No purchase information located (i.e. 'null') originating from \"" + location + "\".");
      }
    }
    catch (Exception e) {
      // output & throw error
      boolean minimal = true;  // <-- mostly hackers: we just log the purchase info & IP and consider it done.
      if (minimal) {
        // no stacktrace
        Log.i("CashierVerifyGoogle: Error verifying purchase originating from \"" + location + "\" (" + purchase + ", purchaseText = \"" + purchase.getPurchaseText() + "\").");
      }
      else {
        // with stacktrace...
        Log.e("CashierVerifyGoogle: Error verifying purchase originating from \"" + location + "\" (" + purchase + ", purchaseText = \"" + purchase.getPurchaseText() + "\").", e);
      }
      throw Failure.e(e);
    }
  }
}

@noblemaster I'll look at it and see if I can get it to work. I'm not sure how to add it to Gdx-Pay, but would be great if it was in there for sure.

@noblemaster Might be a silly question, but the code you sent for iOS (i.e the code from Gdx-pay goes into my client yes? But the AndroidGooglePlay-code has to go in my server?
Or do I need to import gdx-pay to my server and use the iOS version there too? Unsure if what you sent for Gdx-pay is a sample I need to reproduce, or something I can use through gdx-pay.
Can't find a way to get "Transaction" using gdx-pay.

Both samples go onto the server! The Transaction object contains all the data needed for verification.

@noblemaster Thanks, then one last question. I need to send the Transaction-object from my client. But how do I get/create that object (or the receipt)?

You could send the Transaction object as JSON data to the server for example. It all depends how you implemented your server. Then simply re-create the Transaction object from the JSON data on the server.
The relevant parts for verification are the orderID and transactionDataSignature from the Transaction object.

@noblemaster Thanks, but I meant how do I get the Transaction object in my client? :) I can't find any gdx-pay function to do this, only "getInformation(identifier)", but that returns info aobut a product from what I can tell.

You receive it via PurchaseObserver.

@noblemaster Thanks a lot, got the transaction info now :) The transactionDataSignature is 'null', but I am assuming that is because I use the test "android.test.purchased" productId :)


Rename Istio-Manager to Pilot

A site wide renaming of Istio-Manager to pilot in all docs, diagrams, slides, etc.
TODO:

Istioctl has CLI options (--managerAPIAddress) whose default value is "istio-manager:..."
(fyi @ayj @esnible)
Installing Istio asks users to look for a service named istio-manager
(fyi @andraxylia @frankbu )

We cannot change the above two references until we change the install scripts in istio/istio and change istioctl CLI as well. Once we fix those two components in the next 0.1.6 release, we can update these two references as well.
Since this is a large patch, I suggest reviewing the individual commits

Also ran the link checker. It will fail because two links (pilot.html and pilot.md) won't exist until PR is merged.
- ./_site/docs/concepts/network-and-auth/auth.html
  *  External link https://istio.io/docs/concepts/traffic-management/pilot.html failed: 404 No error
- ./_site/docs/concepts/traffic-management/pilot.html
  *  External link https://github.com/istio/istio.github.io/edit/master/_docs/concepts/traffic-management/pilot.md failed: 404 No error

@rshriram the option has already been renamed to configAPIService. The config gen is not automated, so @ayj do you mind regenerating the docs from the CLI tool?

I can refresh CLI reference docs in a follow-up PR

first link should be relative, second one I wonder why it's showing like this - does this happen on any new page (seems like a bug, I guess the edit link should be aware of the branch/pr)

should we wait until we have a 0.1.6 before changing the docs ?
if we push this PR without having an alpha archive, things will start breaking for users following instruction about --configAPIservice for instance

Yes absolutely. Once 0.1.6 is out, we push this PR in.

we have a 0.1.6 now (to be confirmed as solid maybe before pushing this)


docs: use workaround for isServer

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Use cases and why

One use case

Another use case

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Tutorials seem to be fixed. This PR is no more needed.


Healthcheck plugin

Creates karyon2-admin-healthcheck-plugin package to handle health check strategy as configured in a karyon2 app.
It also makes karyon-admin container independent on any compile time karyon-core API - with a goal to support both karyon 1.x and karyon 2.x apps with a single admin container framework with potentially separate set of plugins for health check handler implementation.
Test added to validate and demonstrate the use of healthcheck plugin.
Example applications updated to directly use KaryonAdminWebModule as apposed to a BootStrapModule wrapper

NetflixOSS » karyon » karyon-pull-requests #6 SUCCESS
This pull request looks good

NetflixOSS » karyon » karyon-pull-requests #8 SUCCESS
This pull request looks good


display/hide a div upon editing

i was wondering if there is a simple solution to display a div in the page upon active editing and make it display:none again upon end of editing. maybe one of the classes does that and could be added to the div but i cant seem to find one

Hi @marcesh - the easiest way to do this would be to listen for the start and stop editor events and then apply a class or style to display/hide the element in question. For examples:
var editor = ContentTools.EditorApp.get();

editor.addEventListener('start', function (ev) {
    document.getElementById('some-elm').classsList.add('hide-me');
});

editor.addEventListener('stop', function (ev) {
    document.getElementById('some-elm').classsList.remove('hide-me');
});

We use above listeners to update innnerHTML before editing, because the data we actually want to edit is inside one of the dataset values.
Problem here is that on stop, we revert innerHTML to the original value, but thereafter ContentTools overwrites the value again.
editor.addEventListener('start', function (ev) {
    var elements = Array.prototype.slice.call(document.getElementsByTagName('x-trans'));
    elements.forEach(function(item, index) {
        item.innerHTML = item.dataset.plain;
    });
});
editor.addEventListener('revert', function (ev) {
    var elements = Array.prototype.slice.call(document.getElementsByTagName('x-trans'));
    elements.forEach(function(item, index) {
        item.innerHTML = item.dataset.value;
    });
});

So, start works okay, but stop then sets back the innerHTML value that was set on start. None of the events listed can be used to handle this?

@rvanlaak there are now 2 new events available against the editor (started and stopped) these complement the existing start/stop events by being trigger after editor has started or stopped. Not in the docs yet (new as of release 1.5.5) but thought you might find them useful.

Great @anthonyjb ! I think I was missing them while implementing https://github.com/php-translation/symfony-bundle/pull/104
... what happened over there, was that the editor was not able to retrieve the proper value (read: old value was returned). Can you confirm that this is "fixed" by the two new events before I try again? 👍

@rvanlaak when you say the old value was returned can you briefly describe the behaviour, looks like:

You set a dataset attribute against an element in the HTML (e.g data-value='some value').
Then when  you start the editor you change the innerHTML of the element to 'some value' (based on the data-value).
Where I get lost is what's going wrong on save/stop?

Yes, the first two are correct. So, it sets the value correctly, but I can't properly get back the data to send it for storage.


Column that is FK+PK has codegen error in 'getPrimaryConditionClause'

DBFlow Version: 4.0.2
Issue Kind (Bug, Question, Feature): bug
Please note if you are using Instant Run, there may be bugs where generated classes are not created. Ensure you are using
the apt or kapt plugins and that incremental compilation is off.
Description: When I try to update from 4.0.0-beta3 to current version. The name for the attempted reference FK+PK property does not match the declaration of the field at the top. In the field declaration the name is 'quizID_ID' which seems to be the name of the Column in the model + '_' + the name of the PK in the referenced table.
In the method with the syntax error getPrimaryConditionClause at the bottom, it try to refer to the field with 'quizID'.
Issue persists after 'Rebuild project'
ProspectQuizEntry_Table.java.zip

I'm seeing this, too, when migrating from 4.0.0-beta7. It occurs when using Kotlin data classes.

can you please send your model classes. that would help diagnose the issue.

OK, I'm sending it to the email address on your profile.
On Sat, Jun 3, 2017 at 10:07 AM, Andrew Grosner<EMAIL_ADDRESS>wrote:

can you please send your model classes. that would help diagnose the issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Raizlabs/DBFlow/issues/1302#issuecomment-305980673,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfQENZWqUGHOULxleh2cZUDrtuYzp8aks5sAXa9gaJpZM4Nlrx5
.

can you repro with 4.0.4? I compiled the classes and ran into no issues on 4.0.4. reopen if still happening.

Still seeing this in 4.0.5. I sent the model classes to the email address on your profile.

I agree, still occurs. Maybe depends on some other piece of the setup?
Sorry, this took me sometime to confirm, because it involves quite a few changes to make my code compatible with newer v ersions. I had to pull out a stash and add some more to it :)

@CapnSpellcheck I had some foreign key relationships that used the primary key type instead of the model in the join class. Changing to the models fixed it. For example: TableAmodel's PK is a variable tableaPK: String. TableBmodel's PK is a variable tablebPK: Int. TableAmodel_TableBmodel has variables tableaFK: String, tablebFK: Int. This causes the error. Changing TableA_TableB to have variables tableaFK: TableAmodel and tablebFK: TableBmodel works.

@josh-bartz Are tableaFK and tableFK also PK fields of TableA_TableB?
Not only do I not need the full model object, the column that is the FK is also  a PK column.
// pk col 1
    @PrimaryKey @NotNull lateinit var profileID: String
// pk col 2
    @PrimaryKey @NotNull @Index(indexGroups = intArrayOf(1))
        @ForeignKey(stubbedRelationship = true,
                    tableClass = ProspectQuiz::class,
                    onDelete = ForeignKeyAction.CASCADE)
        lateinit var quizID: String

@agrosner is this still a supported use case, or was it ever?

Yes, they're also primary keys. I don't need the full models, either, but
this makes the generated code work correctly.
On Thu, May 3, 2018 at 1:28 AM Julian<EMAIL_ADDRESS>wrote:

@josh-bartz https://github.com/josh-bartz Are tableaFK and tableFK also
PK fields of TableA_TableB?
Not only do I not need the full model object, the column that is the FK is
also a PK column.
// pk col 1
@PrimaryKey @NotNull lateinit var profileID: String
// pk col 2
@PrimaryKey @NotNull @Index(indexGroups = intArrayOf(1))
@ForeignKey(stubbedRelationship = true,
tableClass = ProspectQuiz::class,
onDelete = ForeignKeyAction.CASCADE)
lateinit var quizID: String
@agrosner https://github.com/agrosner is this still a supported use
case, or was it ever?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Raizlabs/DBFlow/issues/1302#issuecomment-386211979,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEXCHOWvUVIbhCgshgtabmINxFavoDtCks5turG2gaJpZM4Nlrx5
.

--
Josh Bartz
Software Engineer
406.540.1602 x 237
46°51’11.0272”N
114°00’43.6398”W
onXmaps.com https://www.onxmaps.com/
--
This e-mail message may contain confidential or legally privileged
information and is intended only for the use of the intended recipient(s).
onX is not responsible for errors or omissions in this message and denies
any responsibility for any damage arising from the use of e-mail. Any
opinion and other statement contained in this message and any attachment
are solely those of the author and do not necessarily represent those of
the company.


get_user_for_cookie not working for new Facebook login system

Some more changes are needed to make the get_user_from_cookie function work with the new Facebook OAuth2 login system.
Please see https://github.com/localpower/python-facebook-sdk/commit/4e20521b1efac61a83dc2c699ff10db76dd2a18a for the changes I had to make to get it to work.  (Those changes were pulled from https://gist.github.com/1190267)

It looks like you're not using an updated version of the code, since the changes you mention have all already been made. See https://github.com/pythonforfacebook/facebook-sdk/commit/a0b09635e8f7fbe4b1cb2253bd006282d43cd4ae and https://github.com/pythonforfacebook/facebook-sdk/commit/808b6dd3690f344dffb34d45305073583ce182c9.


treat warnings as errors in docs build

Proposed changes:

will be a lot of warnings to fix before this passes

Status (please check what you already did):

[ ] made PR ready for code review
[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog
[ ] reformat files using black (please check Readme for instructions)

assuming the build will pass, are we ready to merge this @erohmensing ?

yep, cleaned up the migration guide. I'll still continue to edit docs for little fixes until closing time but I can do that on another branch so we know that this is safely merged

Ok sounds great, will merge this one then :+1:


md-select set selected Value after options are initialize dont work

Bug, feature request, or proposal:
Bug
What is the expected behavior?
When options are initalize, it is not possible to change/set selectedValue afterwards.
For example when I get the selectedValue via http call
What is the current behavior?
md-select stays empty
What are the steps to reproduce?
 <md-select  placeholder="Rights" name="userRole" [(ngModel)]="selectedUserRole">
                 <md-option *ngFor="let role of userRoles" [value]="role.value">
                            {{ role.viewValue }}
                 </md-option>
</md-select>

userRoles = [
        {value: "FIRM_ADMIN", viewValue: 'Admin'},
        {value: "B2B_USER", viewValue: 'Standartuser'},
    ];

private getUserDetails(userId:number)
    {
        this.userRestService.getUserById(userId).subscribe
        (
            (response) =>
            {
                this.user = response;
                this.selectedUserRole = this.userRestService.getHighestUserRole(this.user);
            }
        );
    }

Which versions of Angular, Material, OS, TypeScript, browsers are affected?
    "@angular/material": "^2.0.0-beta.8",
    "@angular/core": ">=4.0.0-beta <5.0.0",

Have you tried adding a changeDetectorRef.markForCheck() call after you assign the value? Depending on how this call is made, it's possible that the value isn't picked up by Angular's change detection.

Unfortunately it doesn't work.
Here is the implementation with ChangeDetectionStrategy:
@Component({
    selector: 'app-user-administration-edit',
    templateUrl: './user-administration-edit.component.html',
    changeDetection: ChangeDetectionStrategy.OnPush,
    styleUrls: ['./user-administration-edit.component.scss']
})

...

    constructor(private router: Router, private route: ActivatedRoute, private userRestService:UserRestService, private ref: ChangeDetectorRef) { }

 private getUserDetails(userId:number)
    {
        this.userRestService.getUserById(userId).subscribe
        (
            (response) =>
            {
                this.user = response;
                this.selectedUserRole = this.userRestService.getHighestUserRole(this.user);
                this.ref.markForCheck();
            }
        );
    }

Sorry, I meant that you should use changeDetectorRef.detectChanges(). That being said, the select won't pick up the change properly with the current setup anyway. I'll see what I can do to sort it out. As a workaround, you can wrap the this.selectedUserRole = this.userRestService.getHighestUserRole(this.user); call in a setTimeout.

@crisbeto thank you for your help, but changeDetectorRef.detectChanges() and setTimeout had also no effect on md-select.


Build Demo Slot Component

With last git pull and merge, now on my branch I'm getting error stating invalid credentials. Anyone else seeing this or is it just my environment? @DeeJaeMann @dagaither @its-michaelroy

Asked @dagaither to take a look so we can add styling choices he already put into place in attendance record. Also having someone else do a once over to ensure logic is doing everything expected with no additional errors.


[traffic-gen-in-vm] Checkup: Move low-level VMI building logic to vmi package

Currently, the logic that builds the VMI-under-test's spec is located at checkup.go.
The above logic is in a lower level of abstraction than checkup.
Move the low-level logic to the vmi package, while keeping the high-level logic at checkup.
This will allow a follow-up PR to easily add the traffic generator VMI.
A follow-up PR could also un-export the entities of the vmi package.

Tested against an OpenShift Virtualization 4.14 cluster.


Add support for sorting floats

This implementation is ripped out of quickersort, almost verbatim.

Do you perhaps know whetether someone is using sort_floats in the real world? It'd be great to see a concrete situation where it is needed and how exactly it is used.
One thing I find unfortunate is that the function can sort a slice of floats only, and can't e.g. sort arbitrary types by a float key. Can we generalize it?

Sorting by key is possible. The difficult part is maintaining the invariant that a list item doesn't suddenly start claiming to be NaN after the NaN-moving pass is finished.

The following compares floats the same way and is more than 2x faster:
fn cmp_f64(a: f64, b: f64) -> std::cmp::Ordering {
    fn convert_f64(f: f64) -> u64 {
        let i = unsafe { std::mem::transmute::<f64, u64>(f) };
        let bit = 1 << 63;
        if i & bit == 0 {
            i | bit
        } else {
            !i
        }
    }
    convert_f64(a).cmp(&convert_f64(b))
}
let mut v = vec![0., -0., 7., 5., -3., 1./0., -1./0.];
pdqsort::sort_by(&mut v, |&a, &b| cmp_f64(a, b));
println!("{:?}", v);

Output: [-inf, -3, -0, 0, 5, 7, inf]
Perhaps we should just provide functions cmp_f64 and cmp_f32?

What does it do with NaNs? (there's more than one NaN bit pattern)

Never mind,

The IEEE-754 standard defines a NaN as a number with all ones in the exponent, and a non-zero significand. The highest-order bit in the significand specifies whether the NaN is a signaling or quiet one. The remaining bits of the significand form what is referred to as the payload of the NaN.

The exponent is right after the sign bit, and and the all-zero significand is infinity, so NaN will go after infinity.
Now that I know that, yeah let's use it.

NaNs have slightly different behavior...
let mut v = vec![0., -0., 7., 5., -3., 1./0., -1./0., std::f64::NAN, -std::f64::NAN];
pdqsort::sort_by(&mut v, |&a, &b| cmp_f64(a, b));
println!("{:?}", v);

Output: [NaN, -inf, -3, -0, 0, 5, 7, inf, NaN]
But if you want all NaNs to come last, you can slightly tweak the function:
fn cmp_f64(a: f64, b: f64) -> std::cmp::Ordering {
    fn convert_f64(f: f64) -> u64 {
        let u = unsafe { std::mem::transmute::<f64, u64>(f) };
        let sign = 1 << 63;
        let exp = sign - (1 << 52);
        if u & (sign - 1) > exp {
            !0
        } else if u & sign == 0 {
            u | sign
        } else {
            !u
        }
    }
    convert_f64(a).cmp(&convert_f64(b))
}
let mut v = vec![0., -0., 7., 5., -3., 1./0., -1./0., std::f64::NAN, -std::f64::NAN];
pdqsort::sort_by(&mut v, |&a, &b| cmp_f64(a, b));
println!("{:?}", v);

Output: [-inf, -3, -0, 0, 5, 7, inf, NaN, NaN]

Functions for comparing floats could definitely come in handy, but I feel like they should go into dedicated crates. Let me know if you disagree :)
By the way, I hope to deprecate this crate at some point in the (fairly distant) future. Soon we'll have pdqsort provided by libcore in nightly Rust... PR

Yeah, I figured out what it was doing. Doesn't seem like a big problem.

I don't disagree. Float stuff should probably go in a separate crate.

I'm closing this PR, but thanks for the effort!
It'd be great to see the contents of this PR in a separate crate. Comparing floats can definitely be a pain point in Rust. I'm wondering why we don't have something like f64::raw_cmp in libcore anyway...

https://crates.io/crates/float-ord


More efficient method for computing commutators of operators

What is the expected enhancement?
Need for a new efficient commutator routine which can be used to compute commutators of product of operators. Should also be integrated with q_eom.

PR #1354 willl close this


Maintining an order

What is the problem?
In both IndexedRowMatrix.computeSVD and IndexedRowMatrix.multiply indices are dropped before calling the methods from RowMatrix.
For the IndexedRowMatrix.multiply I have observed that ordering within partitions is preserved, but that it seems to get mixed up between partitions. For example, for:
part1Index1 part1Vector1
part1Index2 part1Vector2
part2Index1 part2Vector1
part2Index2 part2Vector2
I got:
part2Index1 part1Vector1
part2Index2 part1Vector2
part1Index1 part2Vector1
part1Index2 part2Vector2
You can find the more details here :
https://issues.apache.org/jira/browse/SPARK-8614
What changes were proposed in this pull request?
Instead of converting IndexedRowMatrix to RowMatrix and loosing index, we are keeping it IndexedRowMatrix and taking out index and row matrix and then multiplying the row with matrix and placing it at right index.
How was this patch tested?
With this changes all Ut's are passing for mllib module.
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

As noted above, please see http://spark.apache.org/contributing.html

As requested, I can comment here: the issue cited is indeed a problem, and is fixed in https://github.com/hl475/svd/pull/1


Consistent version of go

The theme's go.mod file uses 1.18.
The netlify.toml file we've been using uses 1.14.
What version should we be using?

@regisphilibert note also that the latest version is 1.23.

Assigning back to @regisphilibert for guidance on the newest version.

Information has been added to the readme

Thanks @AdamChlan
Can you share why we should not be using the most current version of go?

As we cannot commit to having this project work with every new version of Go or Hugo, we're sticking with the version we built it with. You can upgrade, we just can't garantee our work beyond that. See theme's hugo.yaml's module.minVersion for Hugo for example.

Thanks for sharing this @regisphilibert.  Is there a reason you chose that version of go? This will help us plan what our future needs may be.

No particular reason @maneesha.


Path parameters are missing from parameters object

Describe the bug
Path parameters are missing from parameters object in the resultant OpenAPI document.
To Reproduce
Steps to reproduce the behavior:

Go to applications.application.GetApplication operation id.
Inspect parameters object/path item.
See missing path parameters, application-id in this case:

Expected behavior
Path parameters should be defined in the parameters object.
Screenshots
See steps to reproduce above.

DeclarePathParametersOnPathItem needed to be set to false in the app service configuration.
@peombwa kindly confirm this is now working as expected.

Thanks for the fix!
Everything works as expected. I'll close the issue.


Devops pipeline powershell failing after Import Arcus.Scripting.LogicApps

Describe the bug
Since 23/05/2023 I am facing issues after importing the Arcus.Scripting.LogicApps powershell module. From the moment I import the module, no Powershell task is still working.
I am using a Hosted agent running on windows-latest and using the powershell@5 task in my YAML file.
To Reproduce
Steps to reproduce the behavior:
Take a DevOps Hosted agent running on windows-latest, use a powershell task to Import Arcus.Scripting.LogicApps and after that try to run a Powershell@5 task.
Expected behavior
Being able to run powershell scripts after Arcus.Scripting.LogicApps import
Additional context
Let me show you what happens and what I have spotted being an issue. I know that I have AzureRM and Az warnings but I am currently only using Az in this pipeline.

First off, I run a Powershell@5 task which outputs the value '1' for testing purposes. This works fine. Note that the Import-Module for Az.Accounts is automatically called and using folder path 2.12.2:

- task: AzurePowerShell@5   displayName: 'Powershell task before arcus import'   inputs:     azureSubscription: ${{ parameters.AzureSubscription }}     ScriptType: 'InlineScript'     Inline: 'Write-Output 1'     azurePowerShellVersion: 'LatestVersion'     pwsh: true   enabled: true

Then, I import the Arcus.Scripting.LogicApps module, which is successful:

- pwsh: Install-Module -Name Arcus.Scripting.LogicApps -Scope CurrentUser -Force   displayName: 'Installing Arcus.Scripting.LogicApps Powershell module'   enabled: true

After this, I try to run a Powershell@5 again but without success. Note how it now tries to import the Az.Accounts module from another path: 2.12.3:

- task: AzurePowerShell@5   displayName: 'Powershell task after arcus import'   inputs:     azureSubscription: ${{ parameters.AzureSubscription }}     ScriptType: 'InlineScript'     Inline: 'Write-Output 1'     azurePowerShellVersion: 'LatestVersion'     pwsh: true   enabled: true

After the Arcus.Scripting.LogicApps import the Powershell@5 task tries to load a different Az.Account version which then conflicts with the current version it looks like.

I can indeed replicate the issue when using Install-Module -Name Arcus.Scripting.LogicApps -Scope CurrentUser -Force.
The suggestion from @fgheysels solves the error, if you use this to install the module then the pipeline should work correctly:
Set-PSRepository -Name PSGallery -InstallationPolicy Trusted
Install-Module -Name Arcus.Scripting.LogicApps -AllowClobber

Can you re-produce the issue when you install the previous version of Arcus.Scripting instead ?

I searched through the entire codebase, the only reference I can find to Az.Accounts is in one of the test files here.

Can we reproduce this on other devops agents (linux for instance, or what if we do not use windows-latest but specify an actual version-nr instead )?

I will do some testing on the above. Update following soon.

@bramvanhautte , any update on this?


feat: adds @Decorator related sorting rules

Description
A rule to sort decorators exists here: https://github.com/ElsiKora/ESLint-Plugin-Sort-Decorators.
However, it doesn't benefit from the eslint-plugin-perfectionist options ecosystem (possibility to group elements, add custom groups, partition by comment, etc.).
Decorators order may sometimes matter (see section below), so giving users the option to keep that order in those cases is necessary.
Additionally, this implementation has some differences related to what we consider an accessor decorator to be (explained below as well).
Changes
This PR adds 5 new decorator-related rules:

sort-class-decorators
sort-property-decorators
sort-method-decorators
sort-parameter-decorators
sort-accessor-decorators

Options
All these rules have the same options: their logic is exactly the same, but applied on different elements.

type
order
ignoreCase
groups
customGroups
partitionByComment
matcher

partitionByNewLine was not added as I don't think there is a use case in separating decorators with a new line. This can be  easily added if necessary.
There is at the moment only one predefined group: unknown.
Errors
All rules have 2 errors each:

When two adjacent decorators do not belong to the same group and are unordered, with a more detailed error.
When two adjacent decorators belong to the same group but are unordered.

sort-accessor-decorators
Works on auto-accessors, not getters. Getters/setters are affected by sort-method-decorators.
⚠ Should this be included in recommended configs?
Decorators are evaluated from top to bottom. While unusual, decorator order may matter in some projects. Activating these rules without proper configuration CAN cause runtime errors.
At the moment, there are 2 other rules that may change behavior unexpectedly through sorting and that are present in recommended configs:

sort-maps
sort-sets

(If users depend on insertion order, although it is unusual).
I think that if we choose not to include this rule into recommended, then both of the above rules should not be included as well.
Remaining to do
sort-class-decorators

[x] Add tests
[x] Add documentation

sort-method-decorators

[x] Add tests
[x] Add documentation

sort-property-decorators

[x] Add tests
[x] Add documentation

sort-parameter-decorators

[x] Add tests
[x] Add documentation

sort-accessor-decorators

[x] Add tests
[x] Add documentation

What is the purpose of this pull request?

[x] New Feature
[x] Documentation update

Couldn't there be a conflict of precedence (at least from the user point of view) with decoratorNamePattern defined under sort-classes.customGroups?
Maybe something to pay attention in sort-classes and sort-xxx-decorators.

Couldn't there be a conflict of precedence (at least from the user point of view) with sort-classes.customGroups relying on a decoratorNamePattern?
Maybe something to pay attention in sort-classes and sort-xxx-decorators documentations.
By the way I ❤ these new rule proposals.

@OlivierZal This is fine: in sort-classes, decoratorNamePattern is used to target class members that have at least one decorator with the entered pattern. The order of decorators does not matter.

Got it.
Then config is important because unlike class members, order matters – like it matters for arrays, because decorators apply sequentially.

Got it.
Then config is important because unlike class members, order matters – like it matters for arrays, because decorators apply sequentially.

Yes, I mention it at the bottom of the PR, regarding whether the rules should be in recommended configs.

@hugop95, I know it's a draft. I've read your current tests: I've not found the other decorator syntaxes:
@a @b
something

and
@a @b something

Doesn't it worth to test them? Do you want to allow keeping the original syntax as an option? (not necessarily in the first version of these rules).

@OlivierZal
This implementation will not affect elements style-wise: decorators are permuted, so no whitespace/newline is added/removed.
However, it can still be interesting to ensure that this does not get broken, so I'll just edit a couple of tests to have an inline syntax and this should be enough.

@azat-io
Should we include this in recommended configs?
Decorators are evaluated from top to bottom. While unusual, decorator order may matter in some projects. Activating these rules without proper configuration CAN cause runtime errors.
At the moment, there are 2 other rules that may change behavior unexpectedly through sorting and that are present in recommended configs:

sort-maps
sort-sets

(If users depend on insertion order, although it is unusual).
I think that if we choose not to include this rule into recommended, then both of the above rules should not be included as well.

Other than that, I like everything. It's a very cool idea. But it would be nice to combine these rules into one.

Alright, I'll regroup that in one rule and add options to enable/disable it on methods, classes etc.

@azat-io Done. Do you think we should release this in a new major version (v4.0.0)? We could add some breaking changes as well in it:

https://github.com/azat-io/eslint-plugin-perfectionist/issues/309
Maybe remove the old customGroups API in sort-custom-classes ?

@hugop95 Okay, let's do it in the major version. We'll just have to think about the plan for this release and think about what other changes we want to have.

I have created a next branch, could you please direct your pull request to this branch?

@azat-io Done!

Awesome, thank you!

Great achievement @hugop95!

Great achievement @hugop95!

Thank you for the feedback ! Always appreciated.


chatglm-6b

Hi，Is the GLM model in chatglm-6b pretrained on this repo by just modifying some tricks (such as add rope embedding, use new tokenizer), or use the GLM-130b based repo which can use megatron model-parallel. Thanks.

I also want to know the solution about this topic


Improve Javadoc comments in TagAddCommand

Fixes #174

LGTM! Will take note for my javadocs as well!


ImportError: cannot import name '_citation' from 'envs.h2000_v90'

Hi, I am trying to work around with the environment by I always stumble on this error. I am using a MAC OS. Is that an issue with the compiled models? or I am missing something.

Hello Alex,
The .so executables have been compiled for Linux. I think that's why your OS cannot run them. I suggest using a Virtual Machine


prototype patterns

This is a prototype I made to see how hard it would be to use Resources as patterns. Could be a good starting point for that functionality. Do what you want with it!

Thanks for the commit! About the MIDI part, yeah that was my initial idea, to make a system where everything reads and writes to MIDI, but if custom resources work, that'd be a good generalization :D


Update korean pick right solution solves issue #14479

Hi,
This issue is in reference to good-first-issue #14479.  I removed the broken links and set them to refer to their own pages.  I understand this issue may be moot, but it was fun to tease through the site in Korean.  I hope it's helpful to you.

/assign @zacharysarah

/unassign
/assign gochist

Thanks for the pull request @jhbiggs.
It looks like you have included some changes to the English language documentation as well. I wonder if that was by mistake?

Whoops.  My rebasing skills have a little way to go.  I will take out the en commit.

@jhbiggs Thank you! Please resolve conflict.

Ok, done.  I took out the line whose link I had updated because it didn't appear at all in the English version.

@jhbiggs Thank you!
@kubernetes/sig-docs-ko-owners  The base branch of this PR is not our current team milestone branch, dev-1.15-ko.1 or dev-1.14-ko.6. But I think it can be merged to the master directly as it is a bug obviously.   If you agree, please give an approval.
/lgtm

/lgtm

/approve


Pass static analysis

Fix: #9

Great! thanks! Can I merge, already?

Yes please

GitHub had a hiccup and blocked request when trying to merge branches.
It suppose to work now so try again now


Discord's Invite link in README has expired

Create a new one and replace the old.

fixed by #1359


ReactDOM.hydrate is no longer supported in React 18

Hi Everyone!
On the execution of this line
import { renderReact } from 'hypernova-react';
.
.
.
renderReact('App', ReduxApp);

I am seeing the following error in the console.
Is this on hypernova's end or on my end?

Seems like a reasonable PR to use hydrateRoot when present, and fall back to hydrate? Luckily it still works, it just logs the warning.

@elitedeveloper I've created a fork to resolve this
You can try https://github.com/samiashi/hypernova-react


Update RSPM to 2022.11

The 2022.11 release is complete. @colearendt, free free to merge this when you're ready.

Closed in lieu of #304 and #310


Split downloading pretrained models from model runtime via auto classes

Proposed changes:

...

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

/modeltest
include:
 - dataset: ["financial-demo"]
   config: ["BERT + DIET(seq) + ResponseSelector(t2t)"]


Add 'last modified' to S3 object

As title, populates the LastModified metadata into the S3 object.
The immediate motivation for this stems from enabling finding "latest checkpoint" from a directory of multiple checkpoints. However, surely this can find other use as well.
Testing:
(metaflow_dev) MacBook-Pro-5:metaflow akyrola$  aws-vault exec mfdeveloper -- python
Python 3.9.7 | packaged by conda-forge | (default, Sep 14 2021, 01:18:03)
[Clang 11.1.0 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from metaflow import S3
>>> s3 = S3()
>>> info = s3.info_many(['s3://aapo-mf-test/mnist/t10k-labels-idx1-ubyte.gz', 's3://aapo-mf-test/mnist/train-labels-idx1-ubyte.gz'])
>>> info[0].last_modified, info[1].last_modified
(1632312604.0,<PHONE_NUMBER>.0)

>>> o = s3.get('s3://aapo-mf-test/mnist/t10k-labels-idx1-ubyte.gz')
>>> o.last_modified
1632312604.0
>>> oo = s3.get_many(['s3://aapo-mf-test/mnist/t10k-labels-idx1-ubyte.gz', 's3://aapo-mf-test/mnist/train-labels-idx1-ubyte.gz'])
>>> oo[0].last_modified, oo[1].last_modified
(1632312604.0,<PHONE_NUMBER>.0)
>>> i = s3.info('s3://aapo-mf-test/mnist/train-labels-idx1-ubyte.gz')
>>> i.last_modified
1632312562.0
>>> m = s3.get('s3://aapo-mf-test/mnist/train-labels-idx1-ubyte.gz', return_info=False)
>>> m.last_modified
>>>

@romain-intel  i have changed the PR to only contain the last_modified change. I believe the context in the PR description is sufficient?


Add Bukkit flavor, and version check

I wrote this little tidbit of code for another project, and added it into CardinalPGM. Your more than welcome to use it if you wish. It checks to make sure the user is using SportBukkit, and if they aren't it disables the plugin. If they are, it then goes on to check the version and if they aren't using SportBukkit 1.8 it will disable the plugin, and forward them to the wiki page to get more information about what CardinalPGM's current supported SportBukkit version might be.

We require SportBukkit 1_8_R1 now, as we use NMS.

@twizmwazin It was suggested by @CaptainElliott in my last pull request to not hard code that in, since other revisions might be added. Does NMS break every revision?

I guess we could keep the version updated

@CaptainElliott I am aware of NMS breaking sometimes, during each Minecraft update, but not every revision, please correct me if I am wrong in this observation. Feel free to pull this if you wish @twizmwazin

@ryanw-ny Let me know when you have checked this. When NMS changes, the Minecraft version string changes. For example, 1.8.3 (with new NMS) is 1_8_R2. Any versions supporting the same NMS will keep the same version string.

@twizmwazin I will test it as soon as I get home, and hard code that version in.


Binary file cannot be executed on MacOS

While running forge test --use ./bin/solc, I ran into this error
Error: ./bin/solc: cannot execute binary file

After some googling, it seems like it's because of non-compatible binary file. (I'm running it on Macbook M1 chip.)
# info on the binary
$ file ./bin/solc
./bin/solc: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0

# info on local machine
$uname -mp
x86_64 i386

I would be nice if the team can you provide binary file to execute solidity 0.8.18 on machines other than Linux, or some more detailed guide around how to build 0.8.18 locally.

Yea true.
@axic can you upload your macos binary here?

@antoncoding can you try this binary instead: https://output.circle-artifacts.com/output/job/f2a31866-e2c1-4dfa-a940-82c5db9cd012/artifacts/0/solc
this is directly from the Solidity OSX CI

It works! I did need to change the pragma to ^0.8.17 because this non-stable version is considered lower than 0.8.18.

@leonardoalt @antoncoding
Replacing above shared binary with ./bin/solc gives this error on forge test --use ./bin/solc
[⠊] Compiling...
Error:
"./bin/solc": Permission denied (os error 13)

@leonardoalt @antoncoding Replacing above shared binary in ./bin/solc throws this error on forge test --use ./bin/solc
[⠊] Compiling...
Error:
"./bin/solc": Permission denied (os error 13)

chmod 777 ./bin/solc

@leonardoalt @antoncoding Replacing above shared binary in ./bin/solc throws this error on forge test --use ./bin/solc
[⠊] Compiling...
Error:
"./bin/solc": Permission denied (os error 13)

chmod 777 ./bin/solc

Thanks, but how to bypass this

I have no idea. You have to tell your OSX to accept it somehow.

I have no idea. You have to tell your OSX to accept it somehow.

Found this - https://github.com/OptimizorClub/sqrt_foundry_template/issues/3#issuecomment-1298325657

system preference >> security and privacy
then you will see the solc.
just accpet it

Hi, I had this same issue and after I downloaded the solc version for my M1 mac and added the access permissions to the I get this error now.
When the parameter "appendCBOR" is set to false, the parameter "bytecodeHash" cannot be set to "ipfs". The parameter "bytecodeHash" should either be skipped, or set to "none".
Any idea?

Ok, I figured out. I had to add bytecode_hash = "none" to my foundry.toml file
[profile.default]
src = 'src'
out = 'out'
libs = ['lib']

remappings = [
    'forge-std=lib/forge-std/src/',
]

solc = '0.8.18'
cbor_metadata = false
bytecode_hash = "none"


Update product handles won't update existing images

ps. opening this here because I'm not really sure how we could best address it.
Currently the ProductUpdateHandler will always create new images. So if a product with one image is updated say ten times from Wombat it will have 10 images.
I believe we need to figure some way to avoid creating those new images on every product update. Or at least give some kind of option / configuration to do so. Not sure paperclip supports that out of the box. I'm wondering whether we should add a url column on the database so we could map the images by the url and update / create based on that field.

IIRC this only occurred if the query string wasn't being stripped from the url, and if the url was the same as an existing one then it wouldn't continue to create a new image.  I started stripping out query strings here because I ran into that problem before with them:
https://github.com/spree/spree_wombat/commit/ecddad9324c01b5d9e0fdd40607fe6a6149adf22

I probably missed something, but it seems to me that the payload doesn't go though the serializer to prevent any images from being uploaded/created when a product is updated via the update_product endpoint. And the proccess_images method seems to only have active record shenanigans going on.
Also, it still happens when I update my products. (but I'm using 2-3-stable).

hey guys I've put together this spec to exemplify the issue:
it "shouldnt create duplicated images" do
  message = Hub::Samples::Product.request
  message['product']['variants'][0].delete 'images'
  message['product']['images'][0]['url'] = 'https://avatars3.githubusercontent.com/u/56702'

  expect {
    handler = Handler::AddProductHandler.new message.to_json
    handler.process
  }.to change { Image.count }.by(1)

  # will a create a copy of the same image from same given url
  handler = Handler::UpdateProductHandler.new message.to_json
  handler.process

  expect {
    handler = Handler::UpdateProductHandler.new message.to_json
    handler.process
  }.not_to change { Image.count }.by(1)
end

Only way I can think of avoiding this is checking the url in advance and not call create there's an existing asset with the same url. I could be missing some feature on paperclip though. Also I'm not sure we should add a migration on this extension, could be too much overhead for users who don't need this.


Idea: mapToObject (or whatever name)

I've been doing a bunch of data transformations of this form:
const dataMapper = state => ({
    someProp: getSomePropFromState(state)
})

and was thinking a ramda function that produces these data mapper functions would be helpful. The  idea would be something like this:
R.mapToObject({
   someProp: getSomePropFromState
});

Which would return a function that, for each property, calls the provided function with any provided arguments and returns an object where each property equals the return value of the property's functions.
It's a bit similar to evolve, but doesn't require the input & output to match. I don't know if something like this already exists, or is doable with current ramda functions, but maybe it would be a useful addition to the library? If it is, I'd be interested in putting it together myself and opening a PR for it.

Yours sounds like it might be a good use-case for lenses. If Ramda's lenses don't offer everything you need, out of the box, I recommend that you take a look at the excellent partial.lenses library. partial.lenses is more or less developed with the express purpose of making it easy to work with state objects in an immutable and speedy way.
You can also drop by this gitter room to ask any questions you might have about partial.lenses or look for help writing lenses that solve specific problems.

@kurtmilam While I don't think I'll pull in another library for this just yet, I appreciate the link cuz that group has some other things that could be really useful (I'm a heavy user of Kefir, so the Kefir-related libs look really helpful).

I understand the desire to forego adding a new library. On the other hand, I think partial.lenses is worth a look if you're having to do a lot of work with complex data structures.
Regarding your initial question, have you taken a look at Ramda's applySpec? It may get you closer to what you're looking for.

@kurtmilam Actually applySpec is exactly what I'm looking for. Thanks!


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/24067

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/25969

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/26988

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/30666

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/34493


Fix masking progress

Type of Change

[X] Bug fix (non-breaking change, fixes # )
[ ] New feature (non-breaking change, adds functionality, fixes # )
[ ] Breaking change (effects multiple commands or functionality, fixes # )
[X] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Somewhere along the way things changed and the progress bar was not updating correctly.
This has to be fixed to see the batches being executed
Approach
Move the checks for the batch row counters and fix the loops
Commands to test
Invoke-DbaDbDataMasking

Thanks, bud!


ADBDEV-4874: gpbackup e2e test suite hangs

Commit 6f71685 introduced hang errors.
I found that tests sometimes freeze
ginkgo -r --keep-going --randomize-suites --randomize-all --no-color --poll-progress-after=0s -vv --timeout=3h --poll-progress-after=0s end_to_end -- --custom_backup_dir /home/gpbackup --ginkgo.focus 'runs gprestore with copy-queue-size and sends a SIGTERM to ensure cleanup functions successfully'

------------------------------
Signal handler tests
/home/src/gpbackup/end_to_end/signal_handler_test.go:14
  SIGTERM
  /home/src/gpbackup/end_to_end/signal_handler_test.go:249
    runs gprestore with copy-queue-size and sends a SIGTERM to ensure cleanup functions successfully
    /home/src/gpbackup/end_to_end/signal_handler_test.go:441
  > Enter [BeforeEach] Signal handler tests - /home/src/gpbackup/end_to_end/signal_handler_test.go:15 @ 01/23/24 12:53:04.392
  < Exit [BeforeEach] Signal handler tests - /home/src/gpbackup/end_to_end/signal_handler_test.go:15 @ 01/23/24 12:53:20.846 (16.454s)
  > Enter [It] runs gprestore with copy-queue-size and sends a SIGTERM to ensure cleanup functions successfully - /home/src/gpbackup/end_to_end/signal_handler_test.go:441 @ 01/23/24 12:53:20.846
  [FAILED] Timed out after 10.001s.
  Expected
      <string>: postgres  611875  611861  1 12:53 pts/0    00:00:00 /usr/local/bin/gpbackup_helper --restore-agent --toc-file /home/gpbackup/temp4144456127/demoDataDir1/backups/20240123/20240123125320/gpbackup_1_20240123125320_toc.yaml --oid-file /home/.data/6/dbfast2/demoDataDir1/gpbackup_1_20240123125320_oid_611663 --pipe-file /home/.data/6/dbfast2/demoDataDir1/gpbackup_1_20240123125320_pipe_611663 --data-file /home/gpbackup/temp4144456127/demoDataDir1/backups/20240123/20240123125320/gpbackup_1_20240123125320.gz --content 1 --compression-type gzip --single-data-file --copy-queue-size 5 --replication-file /home/.data/6/dbfast2/demoDataDir1/gpbackup_1_20240123125320_replicated_oid_611663\npostgres  611876  611864  1 12:53 pts/0    00:00:00 /usr/local/bin/gpbackup_helper --restore-agent --toc-file /home/gpbackup/temp4144456127/demoDataDir2/backups/20240123/20240123125320/gpbackup_2_20240123125320_toc.yaml --oid-file /home/.data/6/dbfast3/demoDataDir2/gpbackup_2_20240123125320_oid_611663 --pipe-file /home/.data/6/dbfast3/demoDataDir2/gpbackup_2_20240123125320_pipe_611663 --data-file /home/gpbackup/temp4144456127/demoDataDir2/backups/20240123/20240123125320/gpbackup_2_20240123125320.gz --content 2 --compression-type gzip --single-data-file --copy-queue-size 5 --replication-file /home/.data/6/dbfast3/demoDataDir2/gpbackup_2_20240123125320_replicated_oid_611663
  to equal
      <string>:
  In [It] at: /home/src/gpbackup/end_to_end/end_to_end_suite_test.go:286 @ 01/23/24 12:53:34.874
  < Exit [It] runs gprestore with copy-queue-size and sends a SIGTERM to ensure cleanup functions successfully - /home/src/gpbackup/end_to_end/signal_handler_test.go:441 @ 01/23/24 12:53:34.874 (14.029s)
  > Enter [AfterEach] Signal handler tests - /home/src/gpbackup/end_to_end/signal_handler_test.go:19 @ 01/23/24 12:53:34.874
  < Exit [AfterEach] Signal handler tests - /home/src/gpbackup/end_to_end/signal_handler_test.go:19 @ 01/23/24 12:53:34.9 (25ms)

  Attempt #1 Failed.  Retrying ↺ @ 01/23/24 12:53:34.9

  > Enter [BeforeEach] Signal handler tests - /home/src/gpbackup/end_to_end/signal_handler_test.go:15 @ 01/23/24 12:53:34.9

In the upstream they found another error described in the PR.
I applied upstream commit ab6458944aee9182931d1abd57f12c5bfc84836c.

Add description for each commit, why do you revert it.

 The main thing here is that the upstream decided to do this.

Partial reverts of three commits in one is bad idea.

Unfortunately it is so.

Can you fix the problem without reverting commits?

I tried, but it doesn't make sense anymore.

Merged through 80d2db4


[Discussion] 3D: Click to move

Discussion for http://godotrecipes.com/3d/click_to_move/

Precise, thanks!

It's nice that the Collision shape has that raycasting functionality.


Update OICR logo, remove BW folder by using css

Before while hovering over OICR:

After while hovering over OICR:

Let me know if there's a downside of removing the BW folder.

On the other hand, Nextflow looks a bit big and the bottom is a bit too out-of-place with the other logos?

It's an unrelated change.  My screenshot was production vs my branch (branched from develop)

@garyluu @agduncan94  no worries, I think I recall that this was an earlier change too. Nonetheless, could you maybe shrink it a little bit and move it up a tad?

Closing in favor of hotfix branch


Dropdown create

Hello,
Can you please help me as I am not able to create drop down by using database value as option.
I have tried using enum , but not worked for me, Please provide me correct syntax.
Thank you.

Example:
param_list :form, "freq", :string, :optional, "Frequency", ["daily", "monthly", "monthly"]

And now also:
Support for Enums (PR #108)
property_list :type, :string, :optional, "Type", ["info", "warning", "error"]


Add Tooltip PlacementRect example

Is this a totally new sample, an addition to an existing sample page, or a modification of an existing sample page?

[ ] New sample
[x] Addition to existing sample
[ ] Modification to existing sample

If this is an addition/modification to an existing sample page, which one?
ToolTipPage.xaml
Describe the sample

Add an example that uses the PlacementRect API. There's an example in the design doc, but it never made its way into the Controls Gallery.
Is your sample request related to a problem? Please describe it

Additional context

In addition, the existing offset tooltip sample is misleading. Also the code sample shows
<ToolTip Content="Offset ToolTip." HorizontalOffset="100" VerticalOffset="-80"/>

one of those offsets is always ignored (in this case, the horizontal offset). The sample code should be updated to remove the second offset.

I added the wrong link in the description, design doc link is supposed to be https://docs.microsoft.com/en-us/windows/uwp/design/controls-and-patterns/tooltips#placement


GitOps-2675: Upgrade go version to v1.19

Signed-off-by:  Yi Cai<EMAIL_ADDRESS>What type of PR is this?

/kind cleanup

What does this PR do / why we need it:
Upgrades to go v1.19 to match upstream Argo CD go version.
Have you updated the necessary documentation?

[ ] Documentation update is required by this PR.
[ ] Documentation has been updated.

Which issue(s) this PR fixes:
Fixes #?
GITOPS-2675
Test acceptance criteria:

[x] Unit Test
[x] E2E Test

/retest

/test unit

/test unit

/test v4.12-kuttl-sequential

/retest

/test v4.10-kuttl-sequential v4.11-kuttl-sequential v4.12-kuttl-sequential

/test ?

/test v4.8-e2e

/override v4.8-e2e

/override v4.8-e2e

/test v4.12-e2e

/retest

/retest

/retest

/retest

/test v4.12-kuttl-sequential

/test v4.12-e2e

/test v4.11-kuttl-sequential

/test v4.11-kuttl-sequential

/retest

/test v4.12-kuttl-sequential

/test v4.11-kuttl-sequential

/test v4.10-e2e

/test v4.12-kuttl-sequential

/retest

/test v4.11-kuttl-sequential

/retest

/retest

Merging the PR as an administrator as OpenShift CI blocks the merge automatically due to the known failing test.
FAIL: kuttl/harness/1-050_validate_sso_config (783.58s)
Team is working on identifying the above flaky test.


Reconcile dnsrecord when status is outdated

How to categorize this PR?

/area robustness quality
/kind bug
What this PR does / why we need it:
Fixes a regression introduced with #7906. Previously dnsrecords were always annotated with the gardener timestamp. As a result there may be records for which the timestamp is after the lastOperation.lastUpdateTime and the healthcheck introduced with #7906 will not pass until reconciliation is requested. If that is the case then we request a reconciliation of the dnsrecord.
Thanks for reporting @shafeeqes !
cc @timuthy
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:

NONE

Thank you!
/milestone v1.71


Json deserialize error: unknown field matches

when i search with meilisearch-java  sdk, i recieved errors as following:
com.meilisearch.sdk.exceptions.MeilisearchApiException: Json deserialize error: unknown field matches, expected one of q, offset, limit, attributesToRetrieve, attributesToCrop, cropLength, attributesToHighlight, showMatchesPosition, filter, sort, facets, highlightPreTag, highlightPostTag, cropMarker, matchingStrategy at line 1 column 88
my meilisearch version is :v0.29
my meilisearch-java version is: 0.8.0

@alallema is it resolved?
i'm getting same on implementation 'com.meilisearch.sdk:meilisearch-java:0.8.0'

Not yet. But it's normal if you use meilisearch-java:0.8.0 you can't, for the moment, use a version above Meilisearch v0.27.
The PR for the compatibility with v0.28. is still in progress here.

@alallema we are using V30, what do you suggest I do?
currently, I'll start integrating through APIs, will it be safe for me to use it or not?

@alallema we are using V30, what do you suggest I do?
If you want to use the v0.30.0 of Meilisearch you can't use this SDK. You can use this SDK with the v0.27.0 and soon (today normally) the v0.28.0 of Meilisearch`.
currently, I'll start integrating through APIs, will it be safe for me to use it or not?
What do you mean? If you use the v0.30.0 you can just request directly the API but no need of this SDK.

@alallema I've built it now with API as currently SDK not supporting V30
hope SDK will do in the future

hope SDK will do in the future
It will soon I hope I will working on it 💪


[version] Increment to 0.24.0

As titled

closing this because I forgot to merge the feature into main


How to work with mixed lua and C modules

Is there any recommend way to use luacov together with e.g. gcov to get a full picture of coverage between C and lua code?

I think luacov-coveralls supports merging reports with other tools supporting coveralls format, like cpp-coveralls for gcov.


Customizing MH Kernel for SMC in Binary Parameter Spaces

Hi Professor @nchopin and other contributors,
I am currently working on Bayesian inference using Sequential Monte Carlo (SMC) with tempering, specifically focusing on binary parameter spaces. The approach is similar to "Sequential Monte Carlo on large binary sampling spaces" by Christian Schäfer and Nicolas Chopin (Statistics and Computing 23, 2013: 163-184).
I have several questions regarding the customization of the Metropolis-Hastings (MH) Kernel for the move step in this context:

Is it feasible to specify a conditional binary distribution for the proposal within the MH Kernel?
Can the parameters of the aforementioned proposal distribution be updated or adapted using the particles from the previous stage?
Is it possible for the proposal to be sampled via Gibbs sampling, starting from the current sample in the particles?

I would appreciate any guidance that could assist in implementing these features effectively with the module

hi,
Yes, it's completely possible to implement any MCMC kernel, whether Gibbs (your point 3) or Metropolis (your point 1), using the current sample (your point 2). To do so, you may take inspiration from BinaryMetropolis, see here https://github.com/nchopin/particles/blob/b9dbaa8194b4661b32b06a75a6333904a77769e0/particles/binary_smc.py#L158, or its parent class, state_space_models.ArrayMetropolis.
Basically, what these classes do is to take as input an array representing N particles, and generates a new array of N particles, that correspond to applying N times the same MCMC kernel. One method of these classes is calibrate, and what it does is to calibrate the tuning parameters of your kernel based on the current particle sample.
Please have a look at these classes and their documentation. If you have questions, let me know, but since I'm currently on family holiday, I might need time to get back to you.

hi, Yes, it's completely possible to implement any MCMC kernel, whether Gibbs (your point 3) or Metropolis (your point 1), using the current sample (your point 2). To do so, you may take inspiration from BinaryMetropolis, see here
https://github.com/nchopin/particles/blob/b9dbaa8194b4661b32b06a75a6333904a77769e0/particles/binary_smc.py#L158
, or its parent class, state_space_models.ArrayMetropolis.
Basically, what these classes do is to take as input an array representing N particles, and generates a new array of N particles, that correspond to applying N times the same MCMC kernel. One method of these classes is calibrate, and what it does is to calibrate the tuning parameters of your kernel based on the current particle sample.
Please have a look at these classes and their documentation. If you have questions, let me know, but since I'm currently on family holiday, I might need time to get back to you.

Thank you. This seems like exactly what I need. I would take a look at the documentation.

Hi Professor @nchopin,
What is the best way to send information to an MCMC kernel? Should this be accomplished by using an additional entry in 'X.shared? For example, I want to pass a set of fixed coefficient values (constant for all Metropolis steps), which define the prior distributions, to the calibrate`  method of my MCMC kernel.

Hi,
are these "fixed" coefficients fixed from the start (i.e. not set according to the particle sample, at each time t)? In this case, you could simply treat them as attributes of the class that define your MCMC kernel, and set these attributes when you instantiate the class?
But otherwise, yes, X.shared is a dictionary that you can use to store any estimate computed from the particle sample. These estimates should be computed by method calibrate (this method is called at each iteration t, after the particles are generated and their weights are computed). For instance, for random walk Metropolis, method calibrate computes the covariance matrix of the weighted particle sample, and saved it in X.shared; then the method that actually generates the N new particles uses it to sample from the proposal (a Gaussian with the same cov matrix, multiplied by a scalar).
Let me know if this is not clear?
I should really improve the documentation regarding how MCMC kernels work, and in particular what is X.shared. I'm going to mark this issue as "enhancement" to remind me to do so when I'm back.

Hi, are these "fixed" coefficients fixed from the start (i.e. not set according to the particle sample, at each time t)? In this case, you could simply treat them as attributes of the class that define your MCMC kernel, and set these attributes when you instantiate the class? But otherwise, yes, X.shared is a dictionary that you can use to store any estimate computed from the particle sample. These estimates should be computed by method calibrate (this method is called at each iteration t, after the particles are generated and their weights are computed). For instance, for random walk Metropolis, method calibrate computes the covariance matrix of the weighted particle sample, and saved it in X.shared; then the method that actually generates the N new particles uses it to sample from the proposal (a Gaussian with the same cov matrix, multiplied by a scalar). Let me know if this is not clear? I should really improve the documentation regarding how MCMC kernels work, and in particular what is X.shared. I'm going to mark this issue as "enhancement" to remind me to do so when I'm back.

Thank you, Professor @nchopin, for the clear explanation.
I have a follow-up question regarding the tempering algorithm. Is there a storage and lookup mechanism within the algorithm that minimizes repeated evaluations of the forward model embedded in the likelihood function, especially when the same parameters are used across different stages of the algorithm? For example, in my simulations, evaluating the likelihood of my model for a given parameter realization requires running a computationally expensive forward model. However, different values of $\gamma_t$ for the same parameter realization do not necessitate a new evaluation of the forward model. I am curious if there is any built-in functionality in the algorithm to handle such cases.

The implementation makes sure you don't evaluate the likelihood function more than once for each (considered) parameter value. Basically, when a given parameter value theta is generated, its (log-)likelihood is computed immediately, and then stored in array X.llik.

Hello Professor @nchopin,
Thanks for your your assistance and clarification does far. I am happy to say I have been able to implement my model using your excellent particles package. On a related note, do you have any published/related work on combining multi-level Monte Carlo methods with the adaptive tempering SMC sampler? This would be useful, for example, in reducing the cost of problems with expensive forward model computations

Maybe check AJay Jasra's publication list, he and his-co-authors wrote several papers on how to combine SMC with multi-level Monte Carlo:
https://sites.google.com/site/ajayjasra0/home

Closing this and opening a new issue to remind me to improve documentation regarding MCMC kernels.


Release 2.8.1

@jmezach Possible to get it released - has: https://github.com/rr-wfm/MSBuild.Sdk.SqlProj/pull/598

Hmm, it looks like there's a problem with the versioning. I bumped the version number to 2.8.1, but somehow it still produces 2.8.0.

Oh, nevermind, fixed it now. Changed the wrong file apparently.

2.8.1 is up on NuGet.org now.


replace mdl with ampstart

replaces material design lite lib with ampstart
replaces h4 with h2 in docs (this was long overdue)
provide a rough styling of doc headers and title

@kul3r4 it has begun... PTAL

Could you provide how it should look like for "provide a rough styling of doc headers and title"? Otherwise I am not sure what to check.
I noticed that, on the main page, content has no margin top.

Everything needs to be restyled anyway so it doesn't really matter yet.

LGTM


--purge-with-truncate fails because of foreign key constraints

Hi, I am experiencing this with v2.0.0-beta.3...
# ./bin/console hautelook:fixtures:load -n --purge-with-truncate

  [Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException]
  An exception occurred while executing 'DELETE FROM fos_user':
  SQLSTATE[23000]: Integrity constraint violation: 1451 Cannot delete or update a parent row: a foreign key constraint fails (`some_database_name`.`some_table`, CONST
  RAINT `FK_C7440455D3564642` FOREIGN KEY (`createdBy`) REFERENCES `fos_user` (`id`))

Other tables are affected too.
I have a temporary fudge in place, basically drop the schema and run the Doctrine migrations, but it's not pretty.
Maybe I'm missing something, or something needs fiddling?
Happy to pitch in and try to help with a PR if it needs doing.

Hi, I believe https://github.com/theofidry/AliceDataFixtures/pull/32 can fix this issue.
I unfortunately didn't have the time to properly review it, and as I think there's a hole in the test suite regarding that peculiar part, a manual check is necessary.
So if you can help with the review (actually more the manual test) and fix the tests, then I could merge the PRs without further delay :)

I'll have a look at the PR over lunch, but anything more may have to wait until our next spike day as there are deadlines and things.

@theofidry Looking at that PR, assuming we don't want the disabling of foreign keys in this project, as I think we both agree that it would maybe belong in Doctrine\Common\DataFixtures\Purger\ORMPurger, not here, I don't think that PR actually changes anything.
I've also been playing with our cascading delete, but the purging with truncate still falls over the foreign keys, so I have dealt with the purge outside of here.
It does seem that the --purge-with-truncate option does not get through to \Fidry\AliceDataFixtures\Loader\PurgerLoader::load() though.
I doubt I'll be able to look at that today, because now we are doing our truncating outside of here, we just want to append, and are getting caught out by this...
./bin/console hautelook:fixtures:load -n --append --env=dev

  [LogicException]
  Cannot append loaded fixtures and at the same time purge the database. Choose one.

I think I'll close this issue and maybe have a look at that.


Failures when vcpkg install folly:x64-windows --head

We want to build latest Folly revision from github with latest MSVC compiler, I got command ‘vcpkg install folly:x64-windows --head’  from https://vcpkg.readthedocs.io/en/latest/maintainers/vcpkg_from_github/ to use latest revision from github https://github.com/facebook/folly.
My question is how I know what the revision it used? can I pass the revision that I want it build?
Also I noticed there is a failure when build folly, the issue in installing double-conversion:x64-windows which folly needed. See the failure like below, it says ‘file RENAME failed … because the file exist’, I double confirm the file doesn’t exsit. And there is no CMake folder under D:/VCPKG/src/packages/double-conversion_x64-windows/debug. I use the latest VCPKG revision '3457d89'
Starting package 6/12: double-conversion:x64-windows
Building package double-conversion:x64-windows from HEAD...
-- CURRENT_INSTALLED_DIR=D:/VCPKG/src/installed/x64-windows
-- DOWNLOADS=D:/VCPKG/src/downloads
-- CURRENT_PACKAGES_DIR=D:/VCPKG/src/packages/double-conversion_x64-windows
-- CURRENT_BUILDTREES_DIR=D:/VCPKG/src/buildtrees/double-conversion
-- CURRENT_PORT_DIR=D:/VCPKG/src/ports/double-conversion/.
-- Downloading https://github.com/google/double-conversion/archive/master.tar.gz...
-- Downloading https://github.com/google/double-conversion/archive/master.tar.gz... OK
-- Extracting source D:/VCPKG/src/downloads/google-double-conversion-master.tar.gz
-- Extracting done
-- Applying patch D:/VCPKG/src/ports/double-conversion/001-fix-arm.patch
-- Applying patch D:/VCPKG/src/ports/double-conversion/001-fix-arm.patch done
-- Configuring x64-windows-rel
-- Configuring x64-windows-rel done
-- Configuring x64-windows-dbg
-- Configuring x64-windows-dbg done
-- Build x64-windows-rel
-- Build x64-windows-rel done
-- Build x64-windows-dbg
-- Build x64-windows-dbg done
CMake Error at ports/double-conversion/portfile.cmake:26 (file):
file RENAME failed to rename
D:/VCPKG/src/packages/double-conversion_x64-windows/debug/CMake/double-conversionLibraryDepends-debug.cmake

to
D:/VCPKG/src/packages/double-conversion_x64-windows/debug/CMake/double-conversionTargets-debug.cmake

because: File exists
Call Stack (most recent call first):
scripts/ports.cmake:72 (include)
Error: Building package double-conversion:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: double-conversion:x64-windows
Vcpkg version: 0.0.94
Additionally, attach any relevant sections from the log files above.

Try install double-conversion without --head before folly vcpkg install double-conversion

Thanks for reporting this issue! There's a few pieces that actually contributed to this failure:

We shouldn't be propagating --head down to dependencies; I'm going to investigate this further and fix it.
double-conversion failed to build from --head; I've fixed this in the latest master.

I recommend @KindDragon's suggestion since that's our intended behavior.

Thank you @KindDragon and @ras0219-msft  for the quick response!
I have tried, it works, 3 sources need install before folly, list below:
vcpkg install double-conversion:x64-windows
vcpkg install gflags:x64-windows
vcpkg install glog:x64-windows
Is there is a way that I can I pass the revision from the github that I want it build? like vcpkg install folly:x64-windows ecd0fb3’ ☺

I've pushed a fix for 1. above, so you should now be able to simply run vcpkg install folly:x64-windows --head!
Now, as for specific revisions -- if you'd like to "pin" to a specific version for any reason, you should edit the port itself and specify your new ref. This is easy to do with vcpkg edit folly and then changing the vcpkg_from_github block to be something like:
vcpkg_from_github(
    OUT_SOURCE_PATH SOURCE_PATH
    REPO facebook/folly
    REF ecd0fb3....
    SHA512 000
    HEAD_REF master
)

(If you run the install command once, the error message will tell you the correct SHA512 to use).
This way, you'll have consistent, reliable behavior in the future. --head is really meant to temporarily tighten the loop between developers (so when the dev says "I fixed it in master!" you have something you can try ;)).
To discover the commit used after installing with --head, you can run vcpkg list folly --x-full-desc. The version listed will be the git sha1.

Cool! Thank you!
I will use --head, it's much simple than another way.


Composer Installation Error

Thank you very much for your good work
However when I try installing the library I get the following composer error:
[InvalidArgumentException]                                                                                Could not find a version of package agungsugiarto/codeigniter4-authentication-jwt matching your minimum-stability (stable). Require it with an explicit version constraint allowing its desired stability.
How best can I use this library?
Thank you

Hello @geraldokandonga, since this package is early on development you need few change on your file composer.json.
Reference

https://getcomposer.org/doc/04-schema.md#minimum-stability
https://github.com/agungsugiarto/codeigniter4-authentication-demo/blob/79a0d1a758d02195a5e1c8341b56d1bf1912a1ef/composer.json#L36-L37

Lovely that worked like a charm,
Second question is: How do i define the Auth Config to be used for this library?
Thank you in advance


Sweep: create constants instead of using string literals in loyalty-app-backend/user-service/src/main/java/com/ibm/codey/loyalty/accounts/UserEventResource.java

create constants instead of using string literals in loyalty-app-backend/user-service/src/main/java/com/ibm/codey/loyalty/accounts/UserEventResource.java

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: None)

[!TIP]
I can email you when I complete this pull request if you set up your email here!

Actions (click)

[ ] ↻ Restart Sweep

I am currently looking into this ticket! I will update the progress of the ticket in this comment. I am currently searching through your code, looking for relevant snippets.

Step 1: 🔎 Searching
I'm searching for relevant snippets in your repository. If this is your first time using Sweep, I'm indexing your repository. You can monitor the progress using the progress dashboard

🎉 Latest improvements to Sweep:

We just released a dashboard to track Sweep's progress on your issue in real-time, showing every stage of the process – from search to planning and coding.
Sweep uses OpenAI's latest Assistant API to plan code changes and modify code! This is 3x faster and significantly more reliable as it allows Sweep to edit code and validate the changes in tight iterations, the same way as a human would.
Try using the GitHub issues extension to create Sweep issues directly from your editor! GitHub Issues and Pull Requests.

💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request.
Join Our Discord


Comms selector is showing as Fuel Selector

Under communication actions, you can select "Fuel Selector". However, it is very clear that this was intended to be a COMMS selector as seen in the screenshots below.

Duplicate due to a github 404 issue


Hyperlink in from argument of Quote component

I expected to be able to provide a hyperlink in the from argument of a Quote component like this.

> :Quote from=Douglas Adams
> A common mistake that people make when trying to design something completely foolproof
> is to underestimate the ingenuity of complete fools.

Instead, the current behavior ignores the hyperlink and just takes in they hypertext.
Can the Quote component be enhanced so that its from argument can include a hyperlink?
If not, can another optional argument be added to the Quote component to pass in a hyperlink?
If neither, can the build process be improved to output a warning that I am using the from argument incorrectly?

Right now markdown components do not support rich markdown within their arguments. It is an interesting prospect to add that support, but if that doesn't work, then certainly it is possible to add an extra (optional) argument to Quote component.


docs(event_handler): add specific information about case-insensitive lookup of headers

Issue number: #3142
Summary
Slightly improved documentation about case-insensitive lookup of specific header values for REST API events.
Changes
As above, slight changes to docs only
User experience
Improved documentation
Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[ ] Changes have been tested
[x] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Thank you for the suggestion @leandrodamascena, I just accepted it 🙌

looks great, thank you so much @pgrzesik!
@leandrodamascena before we merge, we need to fix the docstring in the get_header_value function to signal that by default we make a case-insensitive lookup*

Hey @heitorlessa - https://github.com/aws-powertools/powertools-lambda-python/pull/3183/files#diff-201518b4cf27a31cff68870554e0b4e2d6de2fa18456d2ea85d04d156991600cR192

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (e555df1) 95.96% compared to head (933d3d9) 95.96%.
Report is 3 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3183   +/-   ##
========================================
  Coverage    95.96%   95.96%
========================================
  Files          195      195
  Lines         8381     8381
  Branches      1562     1562
========================================
  Hits          8043     8043
  Misses         276      276
  Partials        62       62

Files
Coverage Δ

...lambda_powertools/utilities/data_classes/common.py
100.00% <ø> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


PHOENIX-6241 ViewIndexId sequences collide with ones created on the p…

…re-4.15 version

During the upgrade, we disallow certain operations, which results in the query that returns an empty ResultSet from the sequence table(sequence table is not empty). I'm sure that scn and atomic flag upgradeRequired make things diff than the regular query connection. For this reason, I moved  merge view index id logic at the end of the upgradeSystemTables method. In addition, I also added a MergeViewIndexIdSequencesTool that can run it separately to catch up merge view index id logic later.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
6m 28s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
11m 57s
4.x passed

+1 :green_heart:
compile
0m 59s
4.x passed

+1 :green_heart:
checkstyle
1m  6s
4.x passed

+1 :green_heart:
javadoc
0m 48s
4.x passed

+0 :ok:
spotbugs
3m 14s
phoenix-core in 4.x has 950 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 32s
the patch passed

+1 :green_heart:
compile
0m 59s
the patch passed

+1 :green_heart:
javac
0m 59s
the patch passed

-1 :x:
checkstyle
1m  6s
phoenix-core: The patch generated 33 new + 2163 unchanged - 4 fixed = 2196 total (was 2167)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 47s
the patch passed

-1 :x:
spotbugs
3m 24s
phoenix-core generated 1 new + 950 unchanged - 0 fixed = 951 total (was 950)

_ Other Tests _

-1 :x:
unit
191m 49s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

232m 10s

Reason
Tests

FindBugs
module:phoenix-core

Possible null pointer dereference of cmdLine in org.apache.phoenix.util.MergeViewIndexIdSequencesTool.parseOptions(String[]) on exception path  Dereferenced at MergeViewIndexIdSequencesTool.java:cmdLine in org.apache.phoenix.util.MergeViewIndexIdSequencesTool.parseOptions(String[]) on exception path  Dereferenced at MergeViewIndexIdSequencesTool.java:[line 66]

Failed junit tests
phoenix.end2end.ViewTTLIT

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1004/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/1004

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux afbc0f0ba496 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 4f8eab9

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1004/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1004/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1004/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1004/1/testReport/

Max. process+thread count
6212 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1004/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ChinmaySKulkarni @gjacoby126 can you take a look, thanks!


Release 1.2.0

Interval between doses
Exempt status

Closing this pull request due to some change need to be made


Added test option

Regarding issue #149, I added a test property to the options. Set it to true to always show the banner on load (for testing purposes). I didn't update the documentation because that can easily be updated to the way you guys like it.
I followed how things are currently done in the code; however, there's some unnecessary assignment going on. You might as well assign the property in options straight to the variable in this code:
this.defaultOpts.bgColor = options.bgColor;
this.defaultOpts.color = options.color;
this.defaultOpts.lowerThan = options.lowerThan;
this.defaultOpts.languagePath = options.languagePath;
this.defaultOpts.test = options.test;

bkgColor = this.defaultOpts.bgColor;
txtColor = this.defaultOpts.color;
cssProp = this.defaultOpts.lowerThan;
languagePath = this.defaultOpts.languagePath;
test = this.defaultOpts.test;

I think the main intent was something like this though:
bkgColor = options.bgColor || this.defaultOpts.bgColor;
txtColor = options.color || this.defaultOpts.color;
cssProp = options.lowerThan || this.defaultOpts.lowerThan;
languagePath = options.languagePath != null ? options.languagePath : this.defaultOpts.languagePath;
test = options.test || this.defaultOpts.test;

Also, these variables are global. They're not private. I'm going to go through the code and clean it up.
Additionally, the code needs to be minified... I'm not sure what minifier you used so I didn't do it (it would be nice to have a build script)

+1. I'd like to be able to control which browsers we support more finely.

+1. "Test" might not be the best name for this; it's useful to be able to activate the popup according to criteria of my choosing. Maybe "manualActivate" or "forceActivate" instead?


added DEPLOY_TEMPEST variable to deploy.sh to allow users to deploy

tempest using the osad tempest plays
closes bug #253
(cherry picked from commit 0e88cab9abdc1a2e92b8e9cf83180c8e478402de)

:+1:

+1 - needs a rebase then can be merged.


⚠ Processors has degraded performance

In 1586386, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 141 ms

Resolved: Processors performance has improved in a9220cb.