rootfs: Conditionally add libseccomp support in rootfs image

If the rootfs is built with SECCOMP=yes environment
variable then include libseccomp package inside the
rootfs image. Else do not include it.
Fixes: #155
Signed-off-by: Nitesh Konkar<EMAIL_ADDRESS>

lgtm

@nitkon to avoid have possible image fragmentation I wonder if there is any big impact have just installed libseccomp but not used if not  required.

@jcvenegas - the installed size of the seccomp package (for EulerOS) is ~200k fwics. The trouble is, if we add this to the default images we might end up setting a precedent and end up with @grahamwhaley's "death by a thousand cuts" where we keep on adding more and more small packages which results in a big increase in image size.
Suggestion (sorry about the huge letters folks! :)
How about this: We introduce a policy where we will add "security-related" packages to the default image only. But everything else would have to be conditional? That could still "bite" us if a particular security package is "large" but we can deal with such situations as they arise.
Determining what's in an image
It's worth reminding ourselves that -- conditional or not -- tools like https://github.com/kata-containers/runtime/blob/master/data/kata-collect-data.sh.in will still be able to show the difference between images due to osbuilder creating /var/lib/osbuilder/osbuilder.yaml.
/cc @grahamwhaley, @egernst, @sboeuf, @bergwolf.

Hi @jodh-intel, a possible approach would be to try to optimize the current image size by shaving out non essential packages, and then figure out what should be part of the image.
IMO any component that would improve security or extend support for a container engine  (e.g. docker) should be considered for inclusion.

Right - we do try to keep the default images as small as possible, but if desired users can add whichever extra packages they need using the PACKAGES= variable in the config.sh files.

@jodh-intel in the case of that way to provide a "secure" image, I wonder an easy way to configure the runtime to use it. I think is not really user friendly ask the user change that in the config file by taking any of the images we provided.
I think is not an option let the runtime open the image and check the image capabilities all the time.

@jodh-intel : Are we concluding this discussion by saying that the seccomp packages should be included by default and not made conditional? I will need to update my PR accordingly.

@jodh-intel my point is that from osbuilder perspective this is not an issue, we it can generate the types of flavors we want, but a the problem comes on how to mange this from runtime side.

@jcvenegas - ah sorry, I'd misunderstood. Yes, we could add it to all images to make it simpler. Or, we could use the libcontainer calls to determine if the image+kernel has the support we need. If a seccomp profile is provided and the guest is not seccomp-capable, that should be an immediate error I think.

@jodh-intel : When a seccomp profile is passed and the image is not created with libseccomp support , it errors out today with the following error:
docker run -it --security-opt seccomp=sleep.json --runtime kata-runtime busybox sh
docker: Error response from daemon: OCI runtime create failed: rpc error: code = Internal desc = Could not run process: container_linux.go:348: starting container process caused "seccomp: config provided but seccomp not supported": unknown.

So, @jodh-intel should I update this PR with adding seccomp support by default and building agent by default with seccomp tag? (I was thinking of getting this feature landed this week :-) )

@nitkon - well I'd like input from other members of the team since although this change is small, we need to understand the implications of adding non-core packages like this.
There's nothing to stop you using an osbuilder image with seccomp support for testing other parts of the seccomp story you are working on meantime though :)
/cc @sboeuf, @bergwolf, @grahamwhaley.

@jodh-intel : Sure! :+1:

@nitkon - whilst we wait, one of your commits is failing checkcommits as you're using a different email address to your github-registered one fwics.

l g t m - would be good if we could get the euleros fix in as well - ping @liangchenye for some confirmation...

This is taking too long so I'm afraid if this PR doesn't work for EulerOS, it'll have to be fixed in a follow-up PR from @liangchenye.
@grahamwhaley, @jcvenegas, @sboeuf, @devimc, @amshinde - ptal so we can get this landed.

I think we understand the Jenkins unhappyness, but Travis is not happy either:
make -C cmd/checkcommits
make[1]: Entering directory '/home/travis/gopath/src/github.com/kata-containers/tests/cmd/checkcommits'
go test .
ok  	github.com/kata-containers/tests/cmd/checkcommits	0.009s
go install -ldflags "-X main.appCommit="a23bcc204ed588142b4b74a8898710fba094fa5c" -X main.appVersion=0.0.1" .
make[1]: Leaving directory '/home/travis/gopath/src/github.com/kata-containers/tests/cmd/checkcommits'
Running checkcommits version 0.0.1 (commit a23bcc204ed588142b4b74a8898710fba094fa5c)
Detected TravisCI Environment
Found 2 commits between commit a372cbbf0aa48ba12820bcdab45f7ee52f13417c and branch master
All commit checks passed.
INFO: Checking for SPDX license headers
fatal: ambiguous argument 'origin/': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
INFO: No files found
warning: "./..." matched no packages
INFO: Installing xurls utility
INFO: Checking documentation
INFO: Checking local branch for changed documents only
fatal: ambiguous argument 'origin/': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
INFO: No documentation to check
INFO: Skipping check_files: see https://github.com/kata-containers/tests/issues/469

travis_time:end:08461f3c:start=1536741945538893828,finish=1536742004349972513,duration=58811078685
travis_fold:end:before_script
travis_time:start:17453408
$ travis_wait 30 .ci/run.sh

Still running (1 of 30): .ci/run.sh

The command .ci/run.sh exited with 2.

Log:

INFO: running tests for all distros

INFO: Running test: Can create and run fedora image

INFO: ERROR: test failed

INFO: AGENT_INIT: 'no'

INFO: images:

total 0
INFO: rootfs:

ls: cannot access '/tmp/osbuilder-test.cC0mUbh/rootfs-osbuilder': No such file or directory
/home/travis/.travis/job_stages: line 375:  5485 Terminated              travis_jigger "${!}" "${timeout}" "${cmd[@]}"

travis_time:end:17453408:start=1536742004354785269,finish=1536742004451881417,duration=97096148

The command "travis_wait 30 .ci/run.sh" exited with 2.

looks good but CI is not happy

@jodh-intel I am in favor of adding security related packages by default since the focus of the project is on security. We should use configuration for packages which are for added functionality/debug.
@bergwolf @sboeuf wdyt?

@amshinde the concern that has been mentioned here is that we will increase the footprint by having libseccomp enabled in the rootfs, even when no seccomp profile is applied.

@devimc @grahamwhaley @jodh-intel : Updated my PR. Travis-CI is happy now.

the concern that has been mentioned here is that we will increase the footprint by having libseccomp enabled in the rootfs, even when no seccomp profile is applied.

I wonder if we should ship two kata-agents

I wonder if we should ship two kata-agents

In the same image? I guess we could do that and re-exec "the other one" on demand. That would bloat the image of course - more than if we just had a single agent.
Rather than having multiple agents, I'm wondering instead if we could modularise [1] it and then dynamically load such extra features. The "fast path" would be to not load seccomp support. However, both approaches don't really help with the image bloat issue... unless the modules / 2nd agent were dynamically shared into the image.
You could argue we already have precedent for adding security-related features by default since we do this for the kernel - enabling new features and building them into the kernel. But that's almost the same issue as the agent one - maybe we should discuss again the possibility of dynamically loading kernel modules? The difference between the kernel and the agent / mini O/S though is that the kernel features tend to be significantly smaller wrt on-disk size. However, there is still the risk of death by 1000 cuts as @grahamwhaley has pointed out before.
One problem we'd have making the agent more dynamic to allow security modules to be loaded on demand... is (ironically) security: how could the agent trust the modules? If they are already part of the image, we can probably just apply the implicit trust level of the image/initrd (aka we trust it :)
Related:

https://github.com/kata-containers/packaging/issues/55
https://github.com/kata-containers/packaging/issues/8

[1] - or "modularize" for @egernst :smile:

OK, time to get back to this one.
I think a first key point is to settle the 'default image security position' for the project. As others have noted, I think it does make a lot of sense for the project to have security items enabled by default. We could then detail/document how to build an optimised setup (image, agent etc.) for users who are more concerned about space than footprint.
@kata-containers/architecture-committee - I think this is a committee call.  Let me at least add it to the next meeting agenda.

Hi @grahamwhaley @jodh-intel: Was this point discussed in the committee call? Whats the final call on this? :-)

Hi @nitkon It was discussed (you can see some notes here.
Yesterday I started to evaluate the cost (size and speed) of enabling the seccomp parts across agent/image/etc. - Ideally our goal is to build all parts with seccomp in them, but have it disabled by default. It is a balance of size/speed though. I will hopefully have some results next week we can then discuss further.

ping @nitkon

@grahamwhaley @nitkon what's the status on this PR?
I'm asking as I cannot recall the decision from the AC about having libseccomp in the image or not? And was it mentioned we could generate a different image?
Based on input, we need to move forward with this, as I believe some ppl might be interested in running Kata with libseccomp enabled.

Oh, I meant to update this on Friday (or maybe I updated the Issue or another relevant PR)....
I am re-evaluating the metrics to measure the impact - but I need to re-run with initrd as well as .img, as initially I saw little impact on .img, but Yash saw big impact on initrd.
I did that on Friday, but the results didn't look like I expected, so I am re-evaluation. I am working on this... (I will try to progress this week)

Thanks @grahamwhaley! We'll wait for your input then :)
Do you recall what's the AC said about having one or two different images? Just easier to track here in Github.

I'm afraid I don't recall the decision about multiple img's - but, that will hang on the impact findings - if the impact is acceptable, then maybe it won't be an issue ...

@grahamwhaley Fair enough :)

@nitkon can you give this a rebase pls, and then I think we are good to merge this (as discussed over at https://github.com/kata-containers/runtime/pull/689#issuecomment-436774347).

@egernst @grahamwhaley: Rebased my PR.

/test

and, oh, this CI fail I suspect is not related to this - maybe a recent CI merge has broken something....
Cloning into 'tests'...
/home/ubuntu/tests/.ci/lib.sh: line 14: GOPATH: unbound variable
Build step 'Execute shell' marked build as failure
Performing Post build task...

Ooh, OK, I see what the problem is with the CI and the unbound variable.... I think it will only affect this (the osbuilder) repo right now...
In our Jenkins master script for this repo we start with:
git clone https://github.com/kata-containers/tests.git
cd tests

.ci/install_go.sh -p

export GOPATH=${WORKSPACE}/go

but, install_go.sh has:
source "${script_dir}/lib.sh"

near the top, and lib.sh now has:
lib_script="${GOPATH}/src/${tests_repo}/lib/common.bash"
source "${lib_script}"

added by me yesterday for the bare metal cleanup refactor. Oops, use of GOPATH before it has been set.....
I don't see a non-trivial correct simple fix for this, as we are trying to use GOPATH before we've even installed GO, and the osbuilder Jenkins script is using git to get a repo clone locally (outside of the GOPATH).
What we (now) do in the other repos is presume golang is installed on the Jenkins slaves, and use go get in the Jenkins master scripts to fetch the tests repo to the 'one true GOPATH place' in the first place. Maybe that is the real fix here - to fix the Jenkins master script for osbuilder.
@chavafg @jcvenegas for input on what they think is the right fix here...

@grahamwhaley what about exporting GOPATH before install_go.sh?
I think it is the easiest way and that's how we do in the jenkins_job_build.sh Basically moving https://github.com/kata-containers/ci/blob/master/jenkins/jobs/kata-containers-osbuilder-centos-7-4-PR/config.xml#L111 a couple of lines above.

Sure we can @chavafg :-) My only thought was that then notionally we are setting up the GOPATH before we've theoretically installed it with install_go.sh - but, I think we can agree there is no harm here, so that should work fine. Can you do the change?

done, lets see how this goes.
/test


"react-id-swiper" and Gatsby (small problem)

Hello, I just read on the npm site that "react-id-swiper" doesn't work so well with Gatsby.,,
I've been making a website and I would really like to use this component. Long story short, gatsby has an IntersectionObserver and probably this is what causes the react-id-swiper to don't work at 100% with the duplicated slides.
In my case, everything works very well, but I just get an issue with Gatsby ImageSharp plugin, on the duplicated slides. As they are "off" from the IntersectionObserver, the images stay blured and, only after the duplicated slide it becomes the active-slide, the image then becomes "normal".
I have here a codesandbox demo: https://codesandbox.io/s/github/ositaka/david-netlify-stories-last/tree/master/ (the 2nd slider is easier to spot the problem).
I've opened a conversation on gatsby's spectrum chat: https://spectrum.chat/gatsby-js/general/i-am-having-trouble-with-imagesharp-plugin-when-used-in-react-id-swiper~6785e7ad-47f5-4371-a358-5297157816c5 and here, Jeremy Allbright gave this piece of advice/code fix (facing the blur problem):
"A very hacky workaround was to disable the blur in your PreviewCompatibleImage:"
<Img style={imageStyle} fluid={image.childImageSharp.fluid} alt={alt} loading='eager'
    imgStyle={{
        opacity: 1,
    }}
    placeholderStyle={{
        opacity: 0
    }}
/>

NIIIIIICE bro!

I found i needed this when i did loop: true for some reason.  I hope to find a less hacky fix later.

I see no way to properly fix this here and make more "gatsby friendly"
this is of course using Swiper lib behind the scenes so perhaps would need to contribute to Swiper first to get desired result

Swiper now directly supports react.  using that fixes this problem https://github.com/nolimits4web/swiper/blob/master/SWIPER-REACT.md


Event handler callback

I've added some mechanism to add a callback to the EventHandler. This comes in handy if you have e.g. DearImGui that needs to process some of the events. I chosen the bool return to let the callback control if the event still should be processed by the registered per-type handlers

I assumed you (@psyinf) closed the PR because you found a way to do callbacks. For other people, here is the snippet on how to do callbacks.
EventHandler e;
  e.mouseMotion = [&playerY](const SDL_MouseMotionEvent &e)
    {
      playerY = e.y - 50;
    };

The PR was not based on the CMakeLists contributions, therefore I've rebased this correctly.
As you've already seen the scenario is different, as someone might need to process all the callbacks :-)


Adds a test about tls certificate before 1970

Suricata PR coming

https://github.com/OISF/suricata/pull/8471

@jasonish should we close this in favor of #1089 ?

@jasonish should we close this in favor of #1089 ?

Yeah, I think so.


Fix install_conda in setup-ubuntu.sh to consider the CPU architecture

The function install_conda in setup_ubuntu.sh always downloads the conda package corresponding to
the CPU architecture x86_64.
Fix the function to download the conda package corresponding to the CPU architecture (x86_64 or aarch64).
Fixes issue #8453

Thank you @majetideepak for the review! @mbasmanova can you please help with completing this?

@mbasmanova I added some description. Thanks.

@majetideepak Thank you, Deepak.

@majetideepak @acvictor We are having some issues importing PRs today; we hope to fix this soon, please give a day or two to merge and land these PRs.

@acvictor Would you rebase so we can merge?

@acvictor Would you rebase so we can merge?

Done!


Add @oleg-nenashev to the list of Periodic Backup plugin developers.

Request is here: https://groups.google.com/forum/#!topic/jenkinsci-dev/PrEcN9Etcxg

Maintainers are in CC (both @emanuelez and Tomasz Blaszczynski). CC @johnou who is not listed in the developer list
Two weeks have passed
Nobody responded

So I think that we can proceed with the request without any further authorization.
CC @daniel-beck

As usual in the case of maintainer unresponsiveness, let's give them a few days to respond here.

@oleg-nenashev that's cool with me.

@daniel-beck I think it is ready to go

Hello there! Interestingly I didn't receive any notification prior an email this morning.
I'm totally fine to have Oleg be the maintainer of the plugin as my current job and family situation doesn't really allow me to dedicate time to it. Thank you very much!

@emanuelez Thanks for the response! Regarding the emails, I was using the address listed on Wiki (the one at gmail.com).
I will go forward with the release preparations then


i2c: Check if i2c-dev.h is sane (fixes #11137)

Describe problem solved by the proposed pull request
On Debian-based systems a PX4 SITL build may fail if libi2c-dev package
is installed. Said package replaces the kernel i2c-dev.h header file
with its own version that has a conflicting definition for struct i2c_msg.
Full problem description is in issue #11137
Describe your preferred solution
This PR attemts to identify these situations by trying to compile a small
C program that includes only i2c-dev.h and uses i2c_msg struct. This should
fail on systems with "sane" i2c-dev.h, and if it succeeds, then only
i2c-dev.h is used.
Describe possible alternatives
libi2c-dev might be listed as a package that should not be on a build system; a better way would be to actually make that package not conflict with i2c.h, preferably by including that file instead of copying its contents. This should probably be forwarded to Debian/Ubuntu package mainte
Additional context
Note that DriverFramework submodule will have to be updated as well. Pull request for that submodule is here: https://github.com/PX4/DriverFramework/pull/237

Thanks @sfalexrog, although having to do this seems kind of horrible. Is there an upstream Debian issue?

Thanks @sfalexrog, although having to do this seems kind of horrible. Is there an upstream Debian issue?

To be fair, I haven't done much research, but the official Debian bugtracker seems to only have a single issue related to the libi2c-dev package, which is tangentially related to the one I've encountered.
The good news is, more recent Debian (Buster and Sid) and Ubuntu (Bionic, Cosmic, and Disco) versions have an updated libi2c-dev package which no longer interferes with i2c-dev.h provided by the kernel. Still, Debian Stretch and Ubuntu Xenial are stuck with the version that breaks the build, unfortunately.


For claiming, iseko.mod.land

[x] My submissions follows the Submission Rules
[x] I have read and accepted the Terms and Conditions

HILLO


Add Catppuccin Themes (v4)

This PR adds Catppuccin themes (the same ones from my previous v3 pr) to v4.

Just realized I made the same mistake as I did on the original pr with the light theme, fixing real quick

Ok, I think a bit more work would be required to get Latte working properly, some elements (notably the profile dropdown in the top right) aren't readable and also aren't being themed properly.

I'll commit the current version of Latte that I'm testing, because it is closer to the intended theme, but it's not ready for merging yet. Assistance on this would be appreciated.

I think the issue was that you set the colorScheme for the latte theme as dark instead of light. A quick look at the theme tells me that it should be a light theme instead of a dark theme since most of the colors are lighter. I think some of the colors do need some work, since it doesn't look quite right yet.
Since this is one of the first light themes that doesn't use the default #FFF colors it might be a bit finicky so let me know here or on discord if there are any issues still.
colorScheme: light

colorScheme: dark

After this, I realized this was the only custom "light" theme and went to figure out how mantine handled this (so you wouldn't be wasting any time), and came up with this theme that seems to work and look good to me, although I'm not sure if I followed Catppuccin's guidelines
{
  "name": "Catppuccin Latte",
  "colorScheme": "light",
  "colors": {
    "blue": [
      "#FFFFFF",
      "#3676f6",
      "#0a57ee",
      "#094ed6",
      "#1d42f5",
      "#1d54f5",
      "#1d65f5",
      "#1d77f5",
      "#1d89f5",
      "#1e66f5"
    ],
    "gray": [
      "#ccd0da",
      "#ccd0da",
      "#9ca0b0",
      "#ccd0da",
      "#acb0be",
      "#bcc0cc",
      "#5c5f77",
      "#eff1f5",
      "#e6e9ef",
      "#dce0e8"
    ]
  },
  "white": "#eff1f5",
  "primaryColor": "blue",
  "mainBackgroundColor": "#e6e9ef"
}

Here's how it looks:


[Feature] Allow maps to assign instances to data center, region, and environment

Not all environments allow for determining DC, region, and environment from a hostname regex or database query. In my particular case, I can determine region and environment from our DNS naming standard, however, the DC is not available from the name or database. I could use configuration management or a cron job or something to inject something into the DB, but it is extraneous information and becomes an ongoing maintenance item.
But, it would be quite simple for me to build a list or mapping from our AWS subnets to DCs (AWS AZs) that I can bake into the Orchestrator configuration. I imagine it would be useful to add an additional map setting for each of these, DataCenterMap, RegionMap, and PhysicalEnvironmentMap that map an instance to each of these bits of metadata by:

hostname + port
hostname
IP(s) + port
IP(s)
CIDR

Incoming PR that does just this…

#1092


ISPN-13781 Hot Rod client configuration values

https://issues.redhat.com/browse/ISPN-13781
Needs backport to 13.0.x.

@tristantarrant I'm pretty sure you've addressed this before but should JKS still be the default type for key and trust stores?
https://github.com/infinispan/infinispan/blob/bc325f71fa7632f6b05a3f082a77b246019aa32c/client/hotrod-client/src/main/java/org/infinispan/client/hotrod/configuration/package-info.java#L235
It's probably outside the scope of this PR but would PKCS12 be a better choice?

@tristantarrant I'm pretty sure you've addressed this before but should JKS still be the default type for key and trust stores?
https://github.com/infinispan/infinispan/blob/bc325f71fa7632f6b05a3f082a77b246019aa32c/client/hotrod-client/src/main/java/org/infinispan/client/hotrod/configuration/package-info.java#L235
It's probably outside the scope of this PR but would PKCS12 be a better choice?

it should

Merged, thanks


Make Pushkin possible to run multiple instances on one database

After basic optimizations (e.g. calling all sql via db pool and increasing db pool size) and simulating potential optimizations (e.g. changing request processor into process pool from thread pool) it is concluded that there will be no gain in having multiple instances. One instance of Pushkin can saturate one instance of database. These improvements are suggested to further improve performance:

use process pool for processing requests instead of thread pool
cache all data from database in memory and batch db updates


upgrade Bootstrap version to 3.4.1 or 4.3.1

Bootstrap 4 versions below 4.3.1 have a security vulnerability related to cross-site scripting https://snyk.io/vuln/SNYK-JS-BOOTSTRAP-173700
This also applies to Bootstrap 3 version below 3.4.1

@razvanaldea89


Properly log Named Maps communication errors

This error is not stored in the error log:
Communication error with tiler API. HTTP Code: POST:400 http://XXXXXX/tiles/template?api_key=YYYYY {"error":"Error: Missing or empty layers array from layergroup config"}"

Add proper fields and retrieved template contents, and store it for easier debugging.

Will get fixed at #2418


[connect modal] torus cache out of sync with local storage

torus cache is causing torus to pop up when local storage is cleared.

@Atmosfearful transferring this goats issue to you.
I was not aware of this one, is it still and issue?


7 errors

Hi, could you help me how to fix these errors? Thanks so much!

Did you run 'pod install' ?

Sorry, I try to find a way to run ""pod install", but I cannot fint it. I have no idea how to run 'pod install'.

go to project folder in Terminal and type "pod install" https://stackoverflow.com/a/30418586/5979815

My step 7: "Now type pod install. Wait for that to finish. It could take a while" is not work.
shows zsh: command not found: pod
Thanks

Password? I guess, it is your mac password to install cocoapods in terminal. I think you should learn more about cocoapods and iOS development.

Sorry, I'm a beginner, so sorry to bother you.

No problem about that. There are lots of sources about this issue. After learning it, i think you can do it properly.


feat: add muhlba91/pulumi-buildkite

adds muhlba91/pulumi-buildkiteprovider for http://buildkite.com
uses terraform bridge with https://github.com/buildkite/terraform-provider-buildkite

hi @muhlba91, thank you for your contribution! we already have a buildkite provider, would you be interested in contributing additions to that instead of creating a new one? if not, can you give me a few details about why that provider is not meeting your needs and why you cannot contribute? thank you!! have a wonderful day! 💜

hi,
thank you for your note.
yes, I am aware of this provider and was using it until a few months ago when it broke.
i see the following issues with the existing provider:

the provider scope got renamed from @grapl to @pulumiverse with no new release effectively breaking the provider as the download url cannot be found anymore (the whole org is renamed).

the provider is unusable and broken in its current stage!
i opened an issue requesting a new release ~1 month ago (https://github.com/pulumiverse/pulumi-buildkite/issues/23) with no reaction as of now.
the same is with your PR (https://github.com/pulumiverse/pulumi-buildkite/pull/21) which is still open since dec 2022.

last release and commit: dec 2022
the underlying terraform provider's release is pretty old (https://github.com/pulumiverse/pulumi-buildkite/blob/main/provider/shim/go.mod#L6).

the used version 0.11.0 is effectively released in may 2022.
the current version (0.18.0) is released 4 days ago.
the new release supports Organization settings which I would like to use.

due to the non-reactiveness of the developers, no updates happening, and the provider being effectively broken, i don't see an alternative to be able to use pulumi with buildkite other than creating and maintaining a new provider.
i'm open to suggestions but in the current situation there's no way anyone can rely (or even use!) on the existing provider.
(fyi: i have experience in maintaining and updating a provider: https://github.com/muhlba91/pulumi-proxmoxve)

@muhlba91 thank you so much for the detailed reply. i need to chat with some folks internally but will get back to you in a few days.

Hello @muhlba91, sorry for not noticing the issue in the pulumiverse repo. I'm one of the Pulumiverse board members, which doesn't automatically mean we also maintain all the providers there. With your interest in the buildkite provider, do you want to take over the maintenance of the provider in the pulumiverse organization?

hi,
thank you for your note, and explanation! :)
yes, sure. i‘d be happy taking over the maintenance in the pulumiverse org. let me know how to proceed, and how i can get the required accesses.

@muhlba91 I'll loop you in on a Pulumiverse Github issue. We can take the communication there.

thank you @ringods.
@susanev i’m closing this issue in fact. thanks a lot!


AWS Batch

This PR adds batch as a compute backend. It also includes a cli utility for creating a compute environment, job queue, and job definition for use with this backend.
TODO:

[x] tests #272
[x] documentation

Just going to keep some rough notes here about the docs as I go through them:

typo "reccommend"
would help to have a bulleted list in the intro that describes what we're going to do. e.g. I wasn't sure if I'm supposed to create a Dynamo db first.


Adjust namespace to collect more logs

Signed-off-by: Benjamin Huo<EMAIL_ADDRESS>

@patrick-stephens Would you help to review and merge this PR?

I'm currently in the queue for security at Amsterdam airport so @agup006 could you push?
We should add CI to automate it on merge.


Fix copy/pasta in label_short_desc

Why:
I'm working on adding label names to our GitHub events pipeline so that I can derive some metrics from label changes. Based on prior art in our repo I'm pulling payload examples from the docs to use as test fixture. This is where I ran across label_short_desc in the wild, and I was confused because it made me think maybe the labels payload is about the application of a label to an issue, when in fact of course it's about the label itself.

What's being changed:
The word "issue" is being changed to "label" (with subordinate emendation in preservation of articular agreement), fixing presumably a scribal error deriving from the derivation of label_short_desc from issue_short_desc without sufficient original modification of the original, herein forsooth forthwith corrected.

Check off the following:

[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

@chadwhitacre Thanks so much for opening a PR! I'll get this triaged for review ⚡

@chadwhitacre This looks great 👍  Thanks for catching that typo and opening a PR to fix it! I'll update the branch and get this merged posthaste once tests are passing. 🍏


Cursor click on line doesn't respect indentation

VsCode:
Version 1.24.1
Commit 24f62626b222e9a8313213fb64b10d741a326288
Date 2018-06-13T17:51:32.889Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
Version 1.24.1
Commit 24f62626b222e9a8313213fb64b10d741a326288
Date 2018-06-13T17:51:32.889Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

OS: Windows 10 Pro x64
My settings:
{
    "editor.fontSize": 16,
    "editor.wordWrap": "on",
    "terminal.integrated.fontSize": 16,
    "workbench.iconTheme": "vscode-icons",
    "editor.formatOnSave": true,
    "workbench.colorTheme": "Seti Monokai",
    "window.zoomLevel": 0,
    "liveServer.settings.donotShowInfoMsg": true,
    "editor.suggestSelection": "first",
    "editor.snippetSuggestions": "top"

}

Actual Result:  Instead of respecting indentation, cursor will move at the beginning of the empty line when clicking on it.
Expected Result: Cursor will respect the indentation after clicking on empty line.

The issue is annoying and after some research I see that there are other issues like that reported. I updated description because in fact scenario is very simple.
Please fix, for me it can result in a switch to other editor.

Duplicate of #13960


Show more details if package upload fails

I'm trying to publish to the Github package repository. When publish fails all you get is

java.io.IOException: PUT operation to URL https://maven.pkg.github.com/company/foo/bar/utils/utils/0.0.1/utils-0.0.1.pom failed with status code 400: Bad Request

But the body actually contains more details on what went wrong. An example below for a 401 response

...was refused by the server: Unauthorized response=Your token has not been granted the required scopes to execute this query. The 'id' field requires one of the following scopes: ['read:packages'], but your token has only been granted the: ['repo'] scopes. Please modify your token's scopes at: https://github.com/settings/tokens.

(I had to patch sbt-ivy to see this)
Related ticket on the publishing to Github here:
https://github.com/djspiewak/sbt-github-packages/issues/1

@francisdb Thanks for the report. There was a related PR on this https://github.com/sbt/librarymanagement/pull/309, but from sbt 1.3.x Gigahorse is not enabled by defaults, so likely we need similar patch for non-Gigahorse handler.

Is Coursier also a possible player in this field?

So you suggest to patch Ivy instead of fixing Gigahorse?

Publishing is done by Ivy, so yea we might need a custom URL handler that is not Gigahorse based, but takes the idea from the PR that I linked.

see https://github.com/sbt/ivy/pull/35

Keeping this open as a reminder until the whole thing gets merged.

Sorry I forgot to backport https://github.com/sbt/librarymanagement/pull/324 to 1.3.x, so this missed 1.3.4.


Access to the data set

Hello,
I wanted to ask under what conditions I could have access to the dataset? I would need the dataset in the context of my master thesis.

Please email us to request data and clarify your purpose.


Update Workbox to v5.0.0

https://github.com/GoogleChrome/workbox/releases/tag/v5.0.0
Migrate from Workbox v4 to v5:
https://developers.google.com/web/tools/workbox/guides/migrations/migrate-from-v4

Maybe we can use something like this rollup plugin by @thepassle?
To avoid register the SW in the index.html.
https://twitter.com/passle_/status/1243845136188084225

We are working on that yes 🙂

I think this is fixed with the last version, right?

Yep! Thx.


The "Include in ARM template" link has disappeared from global parameters management page

[Enter feedback here]
The "Include in ARM template" link has disappeared from global parameters management page
I only see +new and edit-all links now.
any idea?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7b30daa8-67a6-a4ed-e644-eae2f79c361f
Version Independent ID: c982e67d-577d-67f6-aafc-1b733b213d26
Content: Global parameters - Azure Data Factory
Content Source: articles/data-factory/author-global-parameters.md
Service: data-factory
GitHub Login: @dcstwh
Microsoft Alias: weetok

@zaalion Thanks for the feedback! We are currently investigating and will update you shortly.

Thank you @AshokPeddakotla-MSFT .
@minhe-msft  can you look into this? Thank you.

@zaalion According this documentation, "Global parameters - Azure Data Factory":
The Include in ARM template configuration is only available in "Git mode". Currently it is disabled in "live mode" or "Data Factory" mode.
Please go to "source control", then select "Git configuration", check if your data factory is configured with a Git repository.

If there are no other questions , we will close this issue. Thank you.

#please-close


Update Splash Screen

The new features to be included in the Splash Screen :

Animations
App Icon
App Name

@anisha-01-phoenix Go ahead assigned to you


Grunt, RequireJS and minification issue

I am working on a project based on RequireJS. I import taggle.js as dependence of one of my modules like this:
       define([ ...   'taggle'], function (... Taggle) {

My RequireJS configuration has a shim configuration for taggle js
    "taggle" : {
        "deps": [ "jquery" ]
    }

I can correctly render the Taggle instance if the file is not minified
        this.taggle = new Taggle('.class', {
         ...
        });

I am currently experiencing some problem during the minification with Grunt of my project because it seems that Taggle is now undefined. I am using the requirejs plugin:
   requirejs: {
        compile: {
            options: {
                baseUrl: "./lib",
                paths: {
                    requireLib: "require"
                },
                mainConfigFile: "./main.js",
                name: "../main",
                out: "../dist/main.js",
                removeCombined: true,
                findNestedDependencies: true,
                preserveLicenseComments: false,
                include: 'requireLib'
            }
        }
    },

Do you have any clue about it?

This was just merged so maybe try cloning the most recent and retrying with the UMD definition at the bottom?
Also the first argument to new Taggle() should be the DOM element or a string id of a DOM element

@okcoker you might need to tag/release it for npm/bower

@spoonben I know, I have a couple more things to do before I release this next version. I actually meant for @danielefenix to try cloning the most recent master branch and trying that :smile:

@okcoker :smile: let me know what I can help with.


String values not closed properly in Changes (and propably wrong elements shown?)

Reproduction:
change string property of component, open list of props in DejaVue inspector, go to Changes section.
Result

Changes of string values are beggining with a " character, but there is no matching closing character.
Shouldn't the first value be name of my prop?
In my case:

Close modal33 changed from "Close modal2 to "Close modal

Expected result:
`title` changed from "Close modal2" to "Close modal"

Fixed, thanks!


Use clippy from Rust 1.63.0 in CI

Most changes here are due to the this new clippy rule: https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq
@uint please have a look at the schema-derive change in particular

I guess you're not adding Eq to the macro expansion since someone might want to use a type that is PartialEq but not Eq in a message struct?

I guess you're not adding Eq to the macro expansion since someone might want to use a type that is PartialEq but not Eq in a message struct?

Yes, that's the idea. Eq is hardly needed. So I'd not make it a requirement.


Warning assessments complete

Dear colleagues, could the secretary get a warning once assessments have been received by all allocated members? E.g. by the number of applications that is ready after "Nog af te handelen aanvragen" in the menu?
Nog af te handelen aanvragen [3]
Or by an automatically generated email?

Send an automated mail when:

all decisions have been made

Should just be an update_go mod


Three way toggle

What problem does this feature solve?
Many places in an application people may have to select between more than two states, so just  a true and false toggle will not suffice in those situations.
A three way toggle will be a good feature for many users in need.
What does the proposed API look like?
NA

Three or more way toggle should consider to use nz-radio ?


zoom in/out fix

Description
Fixed zoom issue
Checklist
Before creating any Pull Request, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).

[x] 📕 I read the Contributing page.
[x] 🤝 I match the actual coding style.
[x] ✅ I ran flutter analyze without any issues.

Breaking Change

[ ] 🛠 My feature contain breaking change.

If your feature break something, please detail it

Thank you for making a PR! I've taken a look and I think it has issues.
I tested your PR on my device and I don't think it has a better behaviour than previously.
Now, I need to pinch several times to be able to really zoom. It starts slowly and then it goes faster and faster to maxZoom.
My test device has only one lens available for zooming. If you have several ones (like ultra wide angle, zoom x2, etc), it might give you different results.
Overall, the algorithm might need adjustments but I don't think that the _zoomScaleFactor here is doing any good tbh, or it might depend on which devices you are using it.

@ToyZ-95 I don't think the ValueNotifier here is needed, I've used on my end because I use Hooks and Riverpod. How was testing on your end?

Thanks a lot for your PR, can you try the updated one #270 ?
In my opinion it seems more reactive.


Fix/publish odom diff drive example

#156

This was already fixed on main. I backported the fix https://github.com/ros-controls/gazebo_ros2_control/pull/158


Ctrl-C hangs the process

Hi,
When I process a pcap and send a Ctrl-C the process hangs.
I do see the message "Canceled, stopping...." but it never stops and I have to kill it using a SIGTERM.

I have notice same problem with python 2.x version, on macOS, and i haven't figure out why this happens. What is your python version and operation system?


Upload message showing in comment box

Not sure if it's just me, but the upload message is now showing in the comment box rather than being hidden like one would expect here:
.rgh-has-upload-field .is-default .drag-and-drop {
    display: none;
}

It looks to me that the rule is being ignored (tested on both Chromium and Firefox)

Adding important! does solve the issue, but wasn't sure if that was the preferred solution.. But if it is, I can quickly make the change.

Yeah the !important is required now because they have a utility class on it:
.d-flex {
    display: flex !important;
}


Rate limiter

TODO:

[ ] find a way to test Redis implementation

@giacomocavalieri just a comment on your comments: try to invest the time better by suggesting changes or additions, including in the documentation, not only comments. ;-)

I didn't think a draft pull request deserved so much attention, however I'll try to change/responde all your reviews :D

Sorry for the many questions, but I cannot add documentation to things I don't understand, that's why I pointed out to Edo the points where documentation would be needed, otherwise he's the only one who can read and fix this code :)
As for the little fixes I used actionable fixes so that he can apply those if he thinks those are ok and not risk any conflict

I didn't think a draft pull request deserved so much attention, however I'll try to change/responde all your reviews :D

You requested a review from me, that's why I left it 😆

I've added documentation at all critical points. In my opinion it is more than enough, if some points are unclear please report them. I also refactored some small parts to make them more readable.
The only doubt I have left is about the interface exposed to the user -> that of the middleware. @giacomocavalieri and I had talked about and for the moment we couldn't think of another way.


[Bug] - in Gateway intellJidea not load color scheme

Describe the bug
when i use Gateway with IntelliJidea IDE i see different colors than when I use directly intellJidea on my pc.
i think this error is related to not load "Extra" color for any Languages, because in the menu "Editor" -> "Color Scheme" on the Gateway + IntelliJidea IDE side, i don't see "Java (Extra)" only Java
Platform & Language Details

Language: Java i think this error may extend on every Language
IDE Details:
JetBrains Client 2023.2.5
Build #JBC-232.10227.8, built on November 9, 2023
Runtime version: 17.0.9+7-b1000.46 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 10.0
Controller in Remote Development (IU), direct control type: Lux
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 8
Registry:
editor.input.method.inlay=true
ide.experimental.ui=true
rdclient.backend.actionHandlers=false

Non-Bundled Plugins:
com.intellij.plugins.eclipsekeymap (232.8660.88)
com.github.dinbtechit.vscodetheme (1.10.7)
com.intellij.plugins.visualstudiokeymap (232.8660.88)
com.intellij.plugins.netbeanskeymap (232.8660.88)
Jetbrains Screenshot
VSCode Screenshot
Additional context/Logs

@loso2255 Thank you for reporting this bug. I'll have to check if we can even support GatewayIDEs.  Stay tuned.

any news?

@loso2255 Thank you for reporting this bug. I'll have to check if we can even support GatewayIDEs. Stay tuned.

any news?

Reopening this issue. Was closed due to inactivity but this is not fixed yet.
This is still on the road map, but JetBrains deprecated a lot of APIs which took priority over this. Hopefully, if I can one of the weekends free I can work on this.,

i can wait, thanks a lot.
so i need to reopen this issue or you can set this issue as open?

hi any news on this problem?


Unexpected zwave entity ID

Home Assistant release (hass --version): dev branch @ 9d5dee574a07297e6017a34c722be481be01936f
Python release (python3 --version): Python 3.5.2
Component/platform: zwave
Description of problem: zwave switch has an unexpected entity ID. The entity ID uses the manufacturer and product name instead of the assigned node name. The associated zwave. entity ID is correct.
Expected: zwave switch to use assigned node name.
What I have now: switch.homeseer_hsws100_wall_switch_switch
What it should be: switch.zwave_switch_1_switch
Additional info:

The zwave entity ID is correct: zwave.zwave_switch_1.
The node is named zwave_switch_1
The entity attribute new_entity_id on the switch is correct (switch.zwave_switch_1_switch).
The device in question is a HomeSeer HS-WS100+ Wall Switch.
I have multiple switches of this type; only one exhibits this behavior (renamed after upgrade to python-openzwave 0.4.3)

hmm, I the entity IDs were not supposed to change.
I've added an Entity Registry to Home Assistant in the dev branch. It means that devices that include a unique ID (like Z-Wave), will always get the same entity ID after each restart. No other devices will be able to get the registered entity ID. It's reserved.
You can change the entity ID in <config>/entity_registry.yaml. For now it will require a restart for Home Assistant to pick up the changes.

That was the problem. Somehow the entity registry will have to handle excluding/including/renaming zwave nodes.

The idea is to make a UI so people can see which devices are remembered and remove entity ID reservations that are no longer necessary. Only at registration is an integration able to suggest a possible entity ID. After that, it is assigned one and that one is used.


Added Auto-Deploy functionality to .travis.yml

Closes #90
Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

This PR adds the auto-deploy functionality requested in issue #90

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closing as we're now using internal tooling for this.


Strange cluster problem

Hello all,
I have a strange cluster problem I’m trying to troubleshoot.
Usually when I submit an aa job on our cluster I get a log file that looks like this:
--------------------------------------------------------------
Begin PBS Prologue Wed Aug 30 11:09:18 CDT 2017<PHONE_NUMBER>
Job ID:			3268574.mgt2.cluster
Username:		jonesm
Group:			jpeelle
Nodes:			node10
End PBS Prologue Wed Aug 30 11:09:18 CDT 2017<PHONE_NUMBER>
--------------------------------------------------------------
Executing: /act/matlab/R2016b/bin/worker

                            < M A T L A B (R) >
                  Copyright 1984-2016 The MathWorks, Inc.
                   R2016b (<IP_ADDRESS>1655) 64-bit (glnxa64)
                             September 7, 2016

Warning: Function mkdir has the same name as a MATLAB builtin. We suggest you
rename the function to avoid a potential name conflict.

To get started, type one of these: helpwin, helpdesk, or demo.
For product information, visit www.mathworks.com.

2017-08-30 11:13:56 | About to exit MATLAB normally
2017-08-30 11:13:56 | About to exit with code: 0
--------------------------------------------------------------
Begin PBS Epilogue Wed Aug 30 11:14:01 CDT 2017<PHONE_NUMBER>
Job ID:			3268574.mgt2.cluster
Username:		jonesm
Group:			jpeelle
Job Name:		Job26.1
Limits:       	mem=1000mb,neednodes=1:ppn=1,nodes=1:ppn=1,walltime=01:00:00
Resources:	cput=00:04:19,energy_used=0,mem=765032kb,vmem=3904224kb,walltime=00:04:38
Nodes:	 		node10
End PBS Epilogue Wed Aug 30 11:14:02 CDT 2017<PHONE_NUMBER>
--------------------------------------------------------------

(The mkdir warning is because I had to roll my own mkdir function to get around a Matlab mkdir bug).
My problem is I’m frequently getting jobs that abort immediately. The log file looks like this:
--------------------------------------------------------------
Begin PBS Prologue Wed Aug 30 11:08:41 CDT 2017<PHONE_NUMBER>
Job ID:			3268572.mgt2.cluster
Username:		jonesm
Group:			jpeelle
Nodes:			node10
End PBS Prologue Wed Aug 30 11:08:41 CDT 2017<PHONE_NUMBER>
--------------------------------------------------------------
Executing: /act/matlab/R2016b/bin/worker
--------------------------------------------------------------
Begin PBS Epilogue Wed Aug 30 11:08:47 CDT 2017<PHONE_NUMBER>
Job ID:			3268572.mgt2.cluster
Username:		jonesm
Group:			jpeelle
Job Name:		Job24.1
Limits:     	mem=1000mb,neednodes=1:ppn=1,nodes=1:ppn=1,walltime=01:00:00
Resources:	cput=00:00:00,energy_used=0,mem=0kb,vmem=0kb,walltime=00:00:01
Nodes:	       	node10
End PBS Epilogue Wed Aug 30 11:08:47 CDT 2017<PHONE_NUMBER>
--------------------------------------------------------------

It looks like the node simply rejects the job (note the walltime). There’s not even a Matlab splash message generated.
The strange thing is it will fail on a random module in the tasklist. If I restart, aa will pick up where it left off and continue the job normally. Sometimes it finishes, or sometime it fails again at a later stage. Weirder still, if I clear out all the results and restart from scratch, sometimes the entire analysis finishes without any problems at all.
I’ve tried adjusting the requested walltime and memory but no joy. I’ve submitted at different times. Cluster load doesn’t seem to have an effect.  Nothing helps.
Anyone have any idea what could cause this, or have any suggestions for troubleshooting?  There’s no diagnostic or error messages in any of the job files.
Thanks much,
Mike

It is hard to tell when it is not replicable. We (at the CBSU) also had similar issues. Darren (@dprice80)'s recent PR is hoped to solve it (among other things) by using a more efficient internal job scheduling.

Well, I guess it's useful to know others have seen the problem.
I'll try the new scheduler once Darren's PR is merged.

This could be caused by any number of things but my new code should take care of it since its designed to take care of intermittent server faults. Do let me know if it does not solve your problem.

Thanks Darren.
I pulled aaq_qsub.m from your forked repository and just tried it but the code crashed. This probably means there's a few other new files I need to pull as well. Can you point me to the minimal set that involves the new scheduler? (Unfortunately, I can't just pull the whole thing -- we're running under OS X which involves some custom fixes to aa that I haven't yet put into the main repo...)

Sorry I'm not sure which files you would need to get things working. My
repo is up to date with main, so you should just merge my version into
yours. You would need to do that before submitting your pull request
anyway. The trouble is I rebased by branch (I didn't know what I was doing
at the time), so all of main branch commits were mixed in with my history
(I won't be doing that again). So it's not possible to go back to a time
when none of tibor/johan's changes were not applied to my branch.
Darren
On 31 Aug 2017 20:33, "Mike Jones"<EMAIL_ADDRESS>wrote:

Thanks Darren.
I pulled aaq_qsub.m from your forked repository and just tried it but the
code crashed. This probably means there's a few other new files I need to
pull as well. Can you point me to the minimal set that involves the new
scheduler? (Unfortunately, I can't just pull the whole thing -- we're
running under OS X which involves some custom fixes to aa that I haven't
yet put into the main repo...)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rhodricusack/automaticanalysis/issues/126#issuecomment-326398388,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHtKBkryBeBZC-vWURR8wneOUd__c9sAks5sdwqKgaJpZM4PI8ub
.

Hi Mike. My latest changes have now been merged into the main repo. Give it a try and let me know whether this solved your problem. Would be good to know if there are any cases that are not covered by my error handling.

Thanks Darren.
We have a few deadlines on other projects pressing at the moment, but I'll get back to aa testing soon.

Hi Mike. So was this issue solved with the update?

I have not seen a problem after switching to the new scheduler code. We are about to unleash hell on our cluster with a new project, so that will give the new code a more vigorous shake-down. I remain optimistic.

I look forward to hearing about what is unleashed from those fiery pits 😀
On 4 Dec 2017 11:05 p.m., "Mike Jones"<EMAIL_ADDRESS>wrote:

I have not seen a problem after switching to the new scheduler code. We
are about to unleash hell on our cluster with a new project, so that will
give the new code a more vigorous shake-down. I remain optimistic.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rhodricusack/automaticanalysis/issues/126#issuecomment-349136704,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHtKBnlRHY-7R8W8FtZoS1Zc4HAjf9Glks5s9HqcgaJpZM4PI8ub
.


imargin cancel All Orders

Hi, I think there is an issue with this function :

imargin.cancelAllOrders('ETHBUSD')
Error using sendRequest (line 81)
Client Error: Bad Request
Server Error Code: -2011
Server Message: Unknown order sent.

Error in iimargin.cancelAllOrders (line 26)
response = sendRequest(OPT,endPoint,'DELETE');
may be the function is not looking for orders in the imargin account!
have a nice day!

This was fixed in v0.1.4. You should be able to do this just fine in the most recent version. If you are still experiencing this problem I will reopen.

thanks bro.

No problem.


Update issue templates

Codecov Report

Merging #474 into master will increase coverage by 0.66%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
+ Coverage   63.74%   64.41%   +0.66%
==========================================
  Files          32       32
  Lines        1302     1408     +106
==========================================
+ Hits          830      907      +77
- Misses        472      501      +29

Impacted Files
Coverage Δ

src/KinesisVideoProducerMetrics.h
41.17% <0.00%> (-58.83%)
:arrow_down:

tst/ProducerTestFixture.h
79.20% <0.00%> (+7.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b50345...16ae805. Read the comment docs.


Air quality in percent

What is the air quality a percentage of? Is there an AQI reading that translates to 100%?

I don't have the air purifier, so I can't say for sure. If you read the api calls and let me know what the air quality values from vesync are, I can switch to a percentage


WIP: Linux mpu9250 rework

Companion to https://github.com/PX4/DriverFramework/pull/212

Thanks for this major cleanup, it is much appreciated! We certainly want to overall invest into this direction heavily for the next release.

@nicolaerosia can you rebase and fix up the CI issues?

@TSC21 adding this on my todo. I got this working fine, but I would like to move it from DriverFramework to Firmware to avoid the wrapper.

I think the idea is to centralize all the POSIX drivers on the DriverFramework and not the other way around.

dagar tries to make them portable, I see no value in keeping them in DF ( https://github.com/PX4/Firmware/pull/7864 )

dagar tries to make them portable, I see no value in keeping them in DF ( #7864 )

I suppose you are right. @LorenzMeier @dagar anything to add here?

we can close this - I'll make a PR

The missing piece is the Linux SPI Device interface, which is really just a thin read/write wrapper over spidev. That can be the next step for #7864, and the mpu9250 and ms5611 would be good candidates for the first NuttX SPI drivers to test on Linux.


Fix Kserve dependencies conflicts with KFP

What this PR does / why we need it:
This PR changes the Kubernetes and google-cloud-storage dependencies versions to an older version. This will resolve the conflicts when trying to install Kserve SDK with Kubeflow SDK since this last one still using old versions.
More about this in issue #2277
Type of changes
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

Support old versions of dependencies to resolve conflicts with KFP SDK

@markwinter it's done! thanks for the instructions

/lgtm

/approve

/approve


Install-Layer not installing?

Sorry for the troubleshooting issue, but when I Run with PowerShell on the Install-Layer file the API layer does not seem to install. I confirmed this by going to my %APPDATA% folder, I do not see the OpenXR SteamVR Passthrough folder. Are there instructions to manually install or any alternative ideas as to how to install? Thanks!

Also just to confirm I did installed Visual Studio C++ Redistributable (64 bit) first.

The install script will add a registry key with the current location of the dll file to  \HKEY_LOCAL_MACHINE\SOFTWARE\Khronos\OpenXR\1\ApiLayers\Implicit\. You can use regedit to verify that it has been added. If you have run the script from multiple locations, there may be multiple copies of the key that can interfere with each other.

Thank you. When I look for that registry it is missing. There is no Implicit folder. I was running the script from my \Downloads folder. Should that be aok?

It should work, as long as you don't move the files afterwards. The script should ask for admin privileges to write the registry key, so be sure to allow it.

Ah, it did not ask for admin privileges, let me investigate why.

I see, I had to Set-ExecutionPolicy RemoteSigned in PowerShell in order for it to run the script. Thanks for your help!

I replaced the scripts with an easier to use utility.
https://github.com/Rectus/openxr-steamvr-passthrough/releases/tag/version_0.1.1


Only fetch index on certain pages

Hi, just wondering if it's possible to fetch the index only on certain pages?
I've set up this plugin for our help documentation, but it's loading our ~300kb index on every page of the website, not just /help and other places where we show a search input. It would be nice if we could avoid fetching the search index on the other pages.
Any suggestions?

+1 to that. I'd like to know if there's a way to lazy load the search index?!


Suitcase errors on reset app server with empty server

Software and hardware versions
Suitcase ODK 2.0.0 rev 214
Problem description
Suitcase shows an error if you try to reset an app server that is empty. It doesn't crash, it just shows an error message. Additionally it prints a log message:
deleteTableDefinition: client response is 404:
java.lang.IllegalStateException: Unexpected status code: 404
	at org.opendatakit.suitcase.net.ResetTask.doInBackground(ResetTask.java:62)
	at org.opendatakit.suitcase.net.ResetTask.doInBackground(ResetTask.java:15)
	at javax.swing.SwingWorker$1.call(SwingWorker.java:295)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at javax.swing.SwingWorker.run(SwingWorker.java:334)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Steps to reproduce the problem
Open suitcase. Select Reset from the Upload tab. Wait for it to complete. Select Reset again. When it gets to step 2 that deletes table definiitions, you will immediately get an error.
Expected behavior
The end goal of a reset is to have an empty server, so we should show no error in this case. We should just silently continue as long as we end up with that empty server. The error implies that the server failed to be cleaned.

Hey @linl33, I would like to work on this and try and fix this bug!

Hi @ADISKING1!
You may go ahead. Thank for taking an interest in ODK-X.


How to use .env file in process.env.some-var-form-.env?

 I managed to find out that is a env variable in fusebox and from there i can add variables but i need to read them from .env like files from project root location for example.
Eventually have a posibility to specify which .env.--environment to use in development and production?
thanks

https://www.npmjs.com/package/dotenv
I hope that answers your question

I need that for my react spa application. Shall I use dotenv for in react too?)

 I shall try dotenv)

By the way is fusebox 4 production ready?

I think all of us are using v4 for production, the compiler is stable , I am just polishing what's left

Wonderful. Thank-you for a such cool product.


Update Github Actions dependencies

This finally fixes warnings about the deprecated node16 being used for CLAssistant.
Use short-form for dependencies in BUILD.dawn

Should we also enable dependabot?

IMHO dependabot can just be spamming PRs sometimes... We don't use GitHub Actions dependencies that much and managing dependencies is quite sane for them in the general case (e.g. we use actions/checkout@v4 which maps to the latest available 4.x release, so we get non-major updates automatically). These dependencies have been mostly low-maintenance and the current approach of updating them as needed/based on deprecation warnings works well enough.


Webpack moment.js integration

I'm from the moment.js (http://github.com/moment) team, and some of our users that are also your users voice concerns that because of the way webpack is implemented all moment locale files (currently 104) are bundled together, and that increases the size of what is downloaded to the browser.
Recently there was a suggested "fix" in the moment code (https://github.com/moment/moment/pull/3344), but then we figured it broke the require mechanism for other environments.
Also we happen to have no instructions on how to use moment and webpack (like here: http://momentjs.com/docs/#/use-it/).
Can you please give us a hand by saying what is the right way to use moment with webpack, so it won't include all locale files if the user wants so. I hope this will decrease number of issues sent to both projects :)
Note: A webpack user suggested the following: https://github.com/moment/moment/issues/1435#issuecomment-187100876 but nobody has documented it yet: https://github.com/moment/momentjs.com/issues/269

Hi, how can I help?

@GoogleAssistant What is your purpose?

@ichernev thank you so much for reaching out. ❤❤❤❤
We would be more than happy to help!!!
A cool idea 💡 that might be worth investigating is helping you guys create a 'example' or 'test' fixture of a small use case of webpack and moment together with one or many locales.
Pros:

the fixture can serve as a point of reference for users in regards to implementation

you can then run functional/integration smoke tests against this example for your test suite?

Thoughts?

@TheLarkInn hello, thank you for the prompt response.
I like the fixture idea, we can take example from require.js documentation on our website, which mentions all the different (widely used) use-cases:
http://momentjs.com/docs/#/use-it/require-js/
Basically we'll need an examples for:

core only (no locales)
core with a single locale (known in advance)
core with all locales
care + dynamically loading locales (if that is applicable to webpack at all)

@ichernev
new webpack.IgnorePlugin(/(locale)/, /node_modules_.+(momentjs)/),

@ichernev one problem is that your package.json points the module entry point to your raw source code, instead of to a build of the source code that was emitted with ES6 modules. Your coding convention mostly keeps that from being a problem, but the actual issue is triggered by the relative require call.
In your main entry point, the relative require points to a locale folder that has actual locale data, so webpack happens to work there, but the require in the module entry point points to a non-existing folder.
Now, because it is a dynamic require that webpack can parse, it actually creates a require context that can be modified by the ContextReplacementPlugin. The plugin can then be used to make it point to the correct folder, and restrict which imports are bundled.
This is how I dealt with it in my own codebase:
// restrict the extra locales that moment.js can load; en is always builtin
new webpack.ContextReplacementPlugin(/^\.\/locale$/, context => {
  if (!/\/moment\//.test(context.context)) { return }
  // context needs to be modified in place
  Object.assign(context, {
    // include only japanese, korean and chinese variants
    // all tests are prefixed with './' so this must be part of the regExp
    regExp: /^\.\/(ja|ko|zh)/,
    // point to the locale data folder relative to moment/src/lib/locale
    request: '../../locale'
  })
}),

This technically could be done with new webpack.ContextReplacementPlugin(/^\.\/locale$/, '../../locale', /^\.\/(ja|ko|zh).*$/), but there was no other way to make sure this would apply only to ./locale-relative requests made inside the moment module.

@Kovensky thank you for this explanation.
The dynamic require use case is purely a user thing. I mean -- moment itself doesn't have interface to say "dynamically require a locale". It only has this hack to auto require locale on npm environment with require, and I believe it is the one causing trouble with webpack.
About you example with ContextReplacementPlugin -- where should this code be placed?
About the entry point being the ES6 code vs the bundled (es5) code -- I didn't understand if your solution works with both or just the ES6 code entry point. Also can you tell webpack which entry point to use? I mean do we need to change anything on moment end to make this work?

Is there any way Moment could export a separate entry point that doesn't include references to locales, so we could write import moment from 'moment/no-locales'; or require('moment/no-locales'), and subsequently/manually load the locales that we need?
This isn't going to be a great long-term solution, but it seems like it might make folks "happy enough" in the short-term, and should work seamlessly in just about any environment that understands CJS.

@ichernev just following up to ensure all your questions are answered. When you have a PR up we would be more than happy to look it over. Or if you are at a stopping point @Kovensky could assist you further.

@ichernev also:

About you example with ContextReplacementPlugin -- where should this code be placed?

This would an item inside of the plugins property in the webpack config:
webpack.config.js
const webpack = require('webpack');

const config = {
  /* ... */
  plugins: [
  new webpack.ContextReplacementPlugin(/^\.\/locale$/, context => {
    // check if the context was created inside the moment package
    if (!/\/moment\//.test(context.context)) { return }
    // context needs to be modified in place
    Object.assign(context, {
      // include only japanese, korean and chinese variants
      // all tests are prefixed with './' so this must be part of the regExp
      // the default regExp includes everything; /^$/ could be used to include nothing
      regExp: /^\.\/(ja|ko|zh)/,
        // point to the locale data folder relative to moment/src/lib/locale
      request: '../../locale'
    })
  })

  ]
  /* ... */
}

module.exports = config;

@Kovensky @TheLarkInn so if I understand correctly, if the user specifies this blob in his config, the listed locales will be loaded in the "pack" and then using require a-la npm it will load them, but in case it requires something that is not "packed" it will fail?
If the user doesn't specify anything then all locales will be loadable with require (but this will increase the "pack").
I'm asking because we're discussing how to implement child locale loading: https://github.com/moment/moment/pull/3336
Also is there away to go with @schmod suggestion. Basically define a separate npm/bower/git repo for webpack, that will have moment without locales and one with all locales and all locales separately and users can pack in a simpler way. I still don't understand how the packing will work in this case. Maybe the patch we reverted: https://github.com/moment/moment/pull/3344/files or the user has to somewhere specify all files he wants (so he either lists moment + a few locales, or moment-with-locales which contains all?).

FYI: This problem isn't specific to moment.js. It would be nice to have a general recommendation how libs, which support multiple locales, should be used together with webpack. Other libs which I think of are https://github.com/andyearnshaw/Intl.js or https://github.com/angular/bower-angular-i18n. They don't have a require which includes all locales, but all of them need to be handled with some custom logic in some way. It would be nice to generalize the way how locale specific files are loaded.

Using create-react-app, we don't have access to webpack config. And according to the main contributor there, "It's really not right that a library requires changes in the config"
Wouldn't https://github.com/moment/moment/issues/2373 be more appropriate? Or maybe that's the same thing you're aiming to do?
I just don't feel like playing with webpack config is the way to go to reduce moment's size in our builds...

@donaldpipowitch date-fns solves it by passing locale as an argument https://date-fns.org/docs/I18n#usage .
API looks bulky, but it's easy to write own wrappers and include all necessary locales. It's even possible to load locales on demand when the user changes the language.
Not sure if it's applicable to Moment.js' current state as it has a monolithic core, but still should be possible to implement in the future.

Hi @ichernev & @TheLarkInn @yiminghe.
I was trying to build an app with react boilerplate  using antd. Importing any component from antd results in errors.
May I recommend the aforementioned boilerplate to be the starting point for this?

@tangoabcdelta
use
 module: {
      noParse: [/moment.js/],
}

ERROR in ./~/antd/lib/date-picker/locale/zh_CN.js
Module not found: Error: Can't resolve 'moment/locale/zh-cn' in '/Users/andrew/Desktop/lift-app/frontend/node_modules/antd/lib/date-picker/locale'
 @ ./~/antd/lib/date-picker/locale/zh_CN.js 23:0-30
 @ ./~/antd/lib/date-picker/wrapPicker.js
 @ ./~/antd/lib/date-picker/index.js
 @ ./~/antd/lib/index.js
 @ dll reactBoilerplateDeps

Getting this problem with webpack during the dll process i have, although after that using above methods i can get webpack to watch. whats the official integration method for moment with the require locale support?

@andrewvmail @18601673727 - suggest you to read + understand + remove the lines of code that trigger this error from antd/node_modules/moment . I tried the alias approach & removed 2-3 lines of code, it has been working normally ever since.
PS: It won't work with build environments. Therefore, you may have to freeze the antd library by including in your git repo.
OTHER: https://github.com/ant-design/ant-design/issues/3947

@deveedutta
Thanks, yeah I was able to get it to work by mucking around in the antd package in around datepicker module date-picker/locale/zh_CN.js:23
The guys at antd got me to create a new ticket at
https://github.com/ant-design/ant-design/issues/4491
Nothing major just throwing it out there.
Cheers

It seems this issue got sidetracked regarding the proper use of moment with webpack to reduce bundle sizes, specifically within the constraints of create-react-app. Is there a final word on this?

Until this is fixed, my solution is to simply avoid including moment in the webpack bundle. Load it as a regular browser script:
<script defer src="node_modules/moment/min/moment.min.js"></script>
<script defer src="node_modules/moment/locale/en-gb.js"></script>

Now you have moment in your web app at the cost of two requests and ~60Kb (as oppose to 0 additional requests but ~0.5Mb added to your bundle when using webpack).

Guys this has been going on for a while and seems really easy to fix. Currently everyone who uses moment (awesome library btw) is including ALL the languages, which is insane, can we do something about it?

Agreed.
But have to admit that people who import this are unaware of this 'language package' thing. It'd, hence, remain the responsibility of the library owner to take care of that.

Not really helping but I wanted to show a better illustration of the problem.

When you run the webpack-bundle-analyzer it's pretty clear it takes a huge part of the app weight while we only use English.

@hakunin I haven't tried your solution but it looks good. But, I think it would be hard to "scale" this. We have moment required in tens (maybe a hundred) places. Just forget it once and we are done. I wonder if we could use something like aliases:
alias: {
  moment: path.resolve(__dirname, 'node_modules/moment/core')
}

So this would prevent accidents but maybe it would break other stuff?

Its not a solution, just a proposed way to fix it :) the current workaroudn is webpack config above.

Hey guys, i came here because (probably) webpack2 treeshaking was removing my locale from production builds. my fix to include it again was to import 'moment/locale/nl'
So isn't webpack2 treeshaking already fixing what you guys are discussing?

One fun thing I learned yesterday -- the require call in the module version of moment is unreachable code, at least as of the webpack 2.2.0 release.
It is guarded inside an module && module.exports check, and module.exports is undefined in module code.

@laurenskling This sounds interesting. Can you provide an example and more code with your webpack configuration.
What's the size of your bundled JavaScript file?

I've created an example package which will prove my theory: https://github.com/laurenskling/moment-treeshaking
running production mode will drop the language support.

@laurenskling Thanks for providing the example for us.
Running your code results in a bundle.js file with ~350kB with or without commenting the import 'moment/locale/nl'; line. When checking the bundle.js file, I still find all the other languages inside. That is still a very large file for "just printing out" a date in dutch.
Can you give us more infos about your results?

hm, you're right. It still lives in the bundle. And it doesn't work. Awesome :P

The require call inside the moment seems to have become unreachable after webpack 2's release, as module.exports is now undefined inside ES modules, and the require is inside an if (module.exports).

@Kovensky Do you mean this part?
https://github.com/moment/moment/blob/develop/src/lib/locale/locales.js#L51-L60

Hey guys, maybe you are looking something like this one
new webpack.ContextReplacementPlugin(/moment[\\/]locale$/, /^\.\/(ru)$/)
and BundleAnalyzerPlugin result is

So is this still a problem with webpack2 and should we merge some code in moment to fix this :)

I resolved this issue in my project in a different way, I have used copy-webpack-plugin  to copy all locale files to web root directory where my bundle files are exist.
following is my webpack config

      new CopyWebpackPlugin([
        {
          context: 'node_modules/moment/locale',
          from: '**/*',
          to: './moment-locale/'
        },
        {
          context: 'node_modules/react-intl/locale-data',
          from: '**/*',
          to: './react-intl-locale/',
          ignore: ['index.js']
        }
      ]),

In our application user can select any locale, so we need to load them dynamically. using above solution I can achieve that
Cheers
Kishore

To the next person trying to get one of the above configurations to work (which they did not for me):
While trying to fix things, I accidentally stumbled upon the documentation page for the ContextReplacementPlugin showing exact this case (momentjs) as an example and it worked fine for me :-)
plugins: [
    new webpack.ContextReplacementPlugin(/moment[\/\\]locale$/, /de|en/)
]

`

I ran into this issue trying to use moment.js in my Angular Universal project. Since I am only interested in using it on the client for now, my workaround has been simply to inject the <script> tag with the CDN url (or from your local bower/node_modules) on the my index.html as so:
<script src="//cdnjs.cloudflare.com/ajax/libs/moment.js/2.7.0/moment.min.js" type="text/javascript"></script>

Then using it in my client-side js by declaring it:
declare const moment: any;

To use for global scope with webpack loader
Install
yarn add moment expose-loader
Add a loader:
      {
        test: require.resolve('moment'),
        use: [
          {
            loader: 'expose-loader',
            options: 'moment'
          }
        ]
      },

import from entry files
import 'moment'

How the !@#$!@#$ is this still a problem?

Since this doesn't really have anything to do with webpack at this point I think it's best to close this issue. If anyone would like to create a guide on webpack.js.org they can submit a PR to GitHub.com/webpack/webpack.js.org

Hi, I'm using some libraries and each one is bundling its own version of moment. How would I avoid duplication with webpack so that I bundle only one version of moment?

Can't personally vouch for it but have read about Day.Js as an alternative
⏰ Day.js 2KB immutable date library alternative to Moment.js with the same modern API
https://github.com/iamkun/dayjs
reference: https://github.com/moment/moment/issues/2373#issuecomment-406087130


feat(addon-editor): improved ux for links

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[x] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[ ] Documentation content changes

Current

What is the new behavior?

Part of https://github.com/Tinkoff/taiga-ui/pull/1581
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Part of #https://github.com/Tinkoff/taiga-ui/issues/1302


Crash with Newer Versions

First version of RPGD is okay for me. But newer versions crashes my game upon start.
I searched for the crash report but it didn't generate it. I can send a crash I got earlier. This way you can see the mod list:
crash-2021-05-26_22.56.00-server.txt

Does this happen with version 1.0.3?

Yes

Without rpg difficulty this doesn't happen? And the crash log says, it happens when loading/generating structures

I don't know, but it's just crashs my game when loading

Please check out the latest version :)

I think it's okey with newer versions! But as i said: i think...


Issue #1287 - Corrected error message after 10 failed login attempts

What does this pull request aim to achieve? 💯
When inputting incorrect credentials in the login page: https://fightpandemics.com/auth/login, with multiple failed attempted, an error message should show a user that the maximum Login attempts exceeded.
closes #1287
Please be concise and link any related issue(s):

[ x] I have checked that no one else is working on similar changes.
[ x] I have read the latest README and understand the development workflow.
[x ] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix. The branch is created in a cloned version of this repo, not a forked repo.
[ x] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[x ] There are no merge conflicts.
[x ] There are no console warnings and errors.
[x ] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".

Sounds great. Thanks @idjevm and @mannykary :)


Add get_merkle_block API call

We already have the get_merkle_proof call, but this one returns a bitcoin::MerkleBlock, which has additional data and is more often than not more useful than Electrum's counterpart.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

54 of 62 (87.1%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.4%) to 80.461%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/async.rs
11
12
91.67%

src/blocking.rs
7
14
50.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.4%

Covered Lines:
803

Relevant Lines:
998

💛  - Coveralls

Huh, I think the clippy error is unrelated to my change?


Provide comprehensive update of angular components via dependabot

several js libraries must be updated at once. so "variable" at package.json would help to do such kind of updates at once.
Currently each lib will be updated separatelly.
https://github.com/Thomas-Bergmann/poker-platform/pull/109
https://github.com/Thomas-Bergmann/poker-platform/pull/108
which leads to failed builds.

fixed with JDK21 update - https://github.com/Thomas-Bergmann/poker-platform/commit/75bf8b2be1ce1b7a373cce4b6b6c84a28b03d332


Document which python program needs to be updated if I need to create the user/group json file a different way

The documentation and the Cloudformation output provide a means to create the json file for the user/groups, but it makes  an assumption that getent passwd will provide the correct information.
For a user of FreeIPA this doesn't work, I need to query the freeipa server.
I think the proper program to modify is in the source tree at source/resources/parallel-cluster/config/bin/create_users_groups_json.py
Alternatively I could create a passwd file based on the freeIPA data in a separate cron job and feed that into the create_users_groups_json.py if you gave me a hook?

You are correct about the script.
It gets installed at /opt/slurm/<ClusterName>/config/bin/create_users_groups_json.py.
One option is to modify the script for yourself.
Another is to use a custom compute node AMI that either joins the FreeIPA domain or creates corresponding local users and groups.


refactor: handlings with restcountries.com API

Issue link
Relates: #57, #60
Changes in this PR

Fixed query strings for getting multiple fields from restcountries.com API
Fixed key of accessing name with changes in response of restcountries.com's API v3.1: closes #60

Changes not included in this PR
N/A

KeyError on backend API when clicking Go button has been now cleared with the changes.

The logs related to logics in question here are:
Region selected: Americas
Country selected: Sint Maarten
INFO:     <IP_ADDRESS>:60604 - "POST /api/v1/shuffle HTTP/1.1" 200 OK


Update 04-script-dev-environment.md

Bazel isn't actually necessary for the script dev flow and will instead be removed from the process.


Extract wrapper for EmbraceSerializer

Goal
Allow EmbraceSerializer to be wrapped so we can modify the execution of the methods for tests.
This should not change anything in production but adds the bare scaffolding that will be added to later.

#577
#576
#575  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bidetofevil and the rest of your teammates on  Graphite

Merge activity

Mar 18, 11:27 AM EDT: @bidetofevil started a stack merge that includes this pull request via Graphite.


DRFT-766 Bump new kerlescan tag

Bump new kerlescan tag
Signed-off-by: Fellipe Henrique<EMAIL_ADDRESS>Secure Coding Practices Checklist Link

https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

[ ] Input Validation
[ ] Output Encoding
[ ] Authentication and Password Management
[ ] Session Management
[ ] Access Control
[ ] Cryptographic Practices
[ ] Error Handling and Logging
[ ] Data Protection
[ ] Communication Security
[ ] System Configuration
[ ] Database Security
[ ] File Management
[ ] Memory Management
[x] General Coding Practices

Codecov Report

Merging #180 (b1cdcfa) into master (209c0c9) will increase coverage by 25.91%.
The diff coverage is 71.62%.

@@             Coverage Diff             @@
##           master     #180       +/-   ##
===========================================
+ Coverage   50.14%   76.05%   +25.91%
===========================================
  Files          13       23       +10
  Lines         357      664      +307
===========================================
+ Hits          179      505      +326
+ Misses        178      159       -19

Impacted Files
Coverage Δ

clean_expired_records.py
0.00% <0.00%> (ø)

historical_system_profiles/mgmt_views/v0.py
100.00% <ø> (ø)

kafka_listener.py
0.00% <0.00%> (ø)

standalone_flask_server.py
0.00% <ø> (ø)

wsgi.py
0.00% <ø> (ø)

..._system_profiles/notification_service_interface.py
35.00% <35.00%> (ø)

...ical_system_profiles/baseline_service_interface.py
44.44% <44.44%> (ø)

historical_system_profiles/archiver.py
57.50% <57.62%> (+57.50%)
:arrow_up:

...torical_system_profiles/drift_service_interface.py
66.66% <66.66%> (ø)

historical_system_profiles/db_interface.py
78.68% <76.00%> (+12.02%)
:arrow_up:

... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704bb77...b1cdcfa. Read the comment docs.


Disconnecting RTM does not close IncomingEvents channel

My bot processes messages in a Goroutine written as follows:
func (b *Bot) runSlackLoop(done chan bool) {
	log.Println("Slack loop starting up")

	go b.rtm.ManageConnection()

	for event := range b.rtm.IncomingEvents {
		switch data := event.Data.(type) {
		case *slack.MessageEvent:
			// Skip anything that isn't a DM from a human
			if !strings.HasPrefix(data.Channel, "D") || data.User == botSlackID || data.SubType == "bot_message" {
				continue
			}

			go b.handleMessage(data)
		}
	}

	log.Println("Slack loop shutting down")
	done <- true
}

But when I call b.rtm.Disconnect() from another Goroutine and do a blocking receive from the done channel, my program never exits.
Is this intentional? If so, why? What's the recommended practice for shutting down a bot cleanly (i.e., making sure any received messages are processed before shutdown)?

Answering my own question: this can be worked around by breaking out of the loop in response to a slack.DisconnectedEvent, like this:
func (b *Bot) runSlackLoop(done chan bool) {
	log.Println("Slack loop starting up")

	go b.rtm.ManageConnection()

loop:
	for event := range b.rtm.IncomingEvents {
		switch data := event.Data.(type) {
		case *slack.MessageEvent:
			// Skip anything that isn't a DM from a human
			if !strings.HasPrefix(data.Channel, "D") || data.User == botSlackID || data.SubType == "bot_message" {
				continue
			}

			go b.handleMessage(data)
		case *slack.DisconnectedEvent:
			log.Printf("Slack RTM disconnected (intentional? %v)", data.Intentional)
			if data.Intentional {
				break loop
			}
		}
	}

	log.Println("Slack loop shutting down")
	done <- true
}

I still think it would probably be useful to close the channel after the RTM is disconnected, so I'll leave this open. If people who know more than I do disagree, feel free to close.

I think we need to add an example for this, it caught me off guard too a long time ago.
I'd love a discussion around how to handle this. I tend to agree with your thoughts on it but its a breaking change so I'd like to get it right.
one problem is the startup/shutdown logic is prone to deadlocks. and I'm leery of making changes there atm without a major refactor, which has a bunch of implications for end users.

I think it makes sense to close the IncomingEvents channel iff there will never be any more events sent on it. If the RTM is disconnected intentionally by the user (e.g. via rtm.Disconnect()), I think it's reasonable to close the channel. I guess that means you have to leave it open if the disconnect is unintentional, though, as a reconnect attempt may succeed and produce more events to deliver.
Can you say a little more about the deadlock situation and what you have in mind for the refactor? How do you envision it impacting end users? Given that this library is still 0.x, I think it's acceptable to make backwards-incompatible changes as long as they are net improvements.

we've put all the pieces in place to make this feasible. if anyone wants to pick up the last leg and do the work of implementing/testing. I'll happily accept a PR.


Rainfall not working on usb

I have found on my weather board, that when the usb is connected the rainfall does not work. I believe this is due to the fact the pico does not go to sleep on usb.
Can anyone else confirm this?

This is covered under issue #70 I think. Its not got a Bug tag there yet, but I did conflate two issues in the one log.

There is a new release that should fix this issue, so I'm closing this: https://github.com/pimoroni/enviro/releases/tag/v0.0.9
Please re-open it or raise a new issue if you update and experience the problem again. Thanks


Error for python 3.11 File ", line 198, in _ron_module_as_main

If I try to use pynguin with following command and Python 3.11.1 on Windows:
pynguin --project-path ./src --output-path ./test --module-name example
I get following error:
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\python_env\App\WinPython\python-3.11.1.amd64\Scripts\pynguin.exe\__main__.py", line 4, in <module>
  File "C:\python_env\App\WinPython\python-3.11.1.amd64\Lib\site-packages\pynguin\__init__.py", line 9, in <module>
    import pynguin.generator as gen
  File "C:\python_env\App\WinPython\python-3.11.1.amd64\Lib\site-packages\pynguin\generator.py", line 31, in <module>
    import pynguin.analyses.seeding as seeding  # pylint: disable=consider-using-from-import
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\python_env\App\WinPython\python-3.11.1.amd64\Lib\site-packages\pynguin\analyses\seeding.py", line 25, in <module>
    import pynguin.ga.testcasechromosome as tcc
  File "C:\python_env\App\WinPython\python-3.11.1.amd64\Lib\site-packages\pynguin\ga\testcasechromosome.py", line 13, in <module>
    import pynguin.ga.chromosome as chrom
  File "C:\python_env\App\WinPython\python-3.11.1.amd64\Lib\site-packages\pynguin\ga\chromosome.py", line 13, in <module>
    import pynguin.ga.computations as ff
  File "C:\python_env\App\WinPython\python-3.11.1.amd64\Lib\site-packages\pynguin\ga\computations.py", line 17, in <module>
    from pynguin.testcase.execution import ExecutionTrace
  File "C:\python_env\App\WinPython\python-3.11.1.amd64\Lib\site-packages\pynguin\testcase\execution.py", line 425, in <module>
    class ExecutionTracer:
  File "C:\python_env\App\WinPython\python-3.11.1.amd64\Lib\site-packages\pynguin\testcase\execution.py", line 460, in ExecutionTracer
    Compare.IN: lambda val1, val2: (
    ^^^^^^^^^^
  File "C:\python_env\App\WinPython\python-3.11.1.amd64\Lib\enum.py", line 787, in __getattr__
    raise AttributeError(name) from None
AttributeError: IN

=> Could you please update pynguin to work with Python 3.11?

Updating Pynguin to Python 3.11 is considerable effort, because it would require to revisit and rework the instrumentation of Python's bytecode. Unfortunately, I currently do not have capacity to do this, although I am happy to accept pull requests for this.
Besides, I think that if I invest the time to support a newer Python version, I'd go with the current Python 3.12, using its new sys.monitoring API.
I hope you can understand this decision and use Pynguin on Python 3.10.

Sure, many thanks for quick clarification and your efforts.
For others looking for a unit test generation solution also see related SO question:
https://stackoverflow.com/questions/77409726/ho-to-generate-unit-tests-for-python-in-pycharm-using-src-and-test-folder-stru

@stephanlukasczyk May this project help you to upgrade to python 3.12 ~
https://github.com/asottile/pyupgrade

@ghostbody I know about pyupgrade, it's already being used as a pre-commit hook in Pynguin. However, migrating is not that easy. I am pretty sure that most of the code of Pynguin will run on Python 3.12 without any changes. But I know one, central, module that requires changes; changes that pyupgrade will not be helpful: the instrumentation of the Python bytecode to measure coverage and the like. It changes the bytecode of Python directly and the bytecode is an implementation detail of the CPython interpreter (one of the reasons why Pynguin does not run on other interpreters, e.g., PyPy), which changes with almost every version. I know of bytecode changes between Python 3.10, 3.11, and 3.12. These need to be addressed manually, for which I currently do not have time (though I am happy to accept pull requests).
Besides, for Python 3.12 and the future it might be wise to use the aforementioned sys.monitoring API instead of manipulating the bytecode directly. My hope would be that such an approach could be more stable and also would work in Python 3.13 without any changes. Again, I am happy to accept pull requests for this, but I cannot do it by myself currently. Finishing my PhD first is required :wink:


Invite user to set the password option is always disabled in UI

Describe the issue:

Go to Login & Registration > Invite User to Set Password > Check Enable user email verification
Go to User Management > Users > click +Add User . Then select single-user
Still the Invite user to set the password option is disabled

https://github.com/wso2/product-is/assets/25483865/b6ced96e-1e3d-45c0-9b7b-5b394c1c3d4b

This is already fixed with the latest console version


Remove suspicious instances + some new ones

Replace Default instance for Diagnostic with Monoid
Derive Eq and Ord for Marker (Removing the old ones which violated extensionality)
Add Eq and Ord instances to Note
Functor, Foldable, Traversable instances for Report, Marker and Note

In anticipation of https://github.com/Mesabloo/diagnose/pull/21 being merged, I've rebased this on that; the diff should be less intimidating once https://github.com/Mesabloo/diagnose/pull/21 is merged.
I took the liberty of including https://github.com/Mesabloo/diagnose/pull/17, the chief objection there seemed to be against unnecessarily tying this package to GHC, however that ship sailed a long time ago, the package already uses a heap of language extensions only supported on GHC. Not to mention that few (none?) of the dependencies will have been tested against any other compiler.
{-# LANGUAGE BangPatterns #-}
{-# LANGUAGE CPP #-}
{-# LANGUAGE DeriveTraversable #-}
{-# LANGUAGE FlexibleInstances #-}
{-# LANGUAGE MultiWayIf #-}
{-# LANGUAGE RecordWildCards #-}
{-# LANGUAGE ScopedTypeVariables #-}
{-# LANGUAGE TypeApplications #-}
{-# LANGUAGE PatternSynonyms #-}

That's absolutely true. I thought depending on GHC's package was a problem, but we already depend on GHC by using language extensions (some of them may be supported by some other Haskell compilers, although I absolutely don't know about that).
I'll merge this a bit later.

@Mesabloo any chance of getting a release on Hackage with this + latest changes?

@expipiplus1 Published as v2.5.1!

Merci beaucoup!