Flaky artifacts download on v0.183.0 with Espresso tests

Description
After updating to the latest saucectl in saucectl-run-action downloading artifacts became flaky - sometimes it downloads the artifacts as specified in config, usually it doesn't. We upload those artifacts to gh actions after finishing the test.
Config to reproduce

This is how we declare artifact download in config.yml:
artifacts:
  download:
    when: always
    match:
      - junit.xml
    directory: ./test-results/saucelabs-results/
  cleanup: true

And this is how we run our Espresso tests on real Android devices via Github Actions:
- name: Run tests
  uses: saucelabs/saucectl-run-action@v4
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
  with:
    timeout: 90m
    saucectl-version: v0.183.0

- name: Upload tests result
  if: ${{ (success() || failure()) }}
  uses: actions/upload-artifact@v4
  with:
    name: some_unique_name
    path: test-results/
    retention-days: 2
    overwrite: true

The following warning is issued by the upload-artifact step:
No files were found with the provided path: test-results/. No artifacts will be uploaded.

The interesting part is that sometimes results are downloaded - we run 6 jobs in parallel, some of them end up uploading results, most of them don't. They are not always the same jobs.
Desired behavior

After reverting saucectl to v0.182.0 everything goes back to normal - all test results are always downloaded and uploaded as expected. This is a regression strictly in v0.183.0 version.
Versions

saucectl-run-action@v4
saucectl v0.183.0
Ubuntu 20.04

After further investigation it turns out that download is not flaky, it's just that the junit.xml result is only downloaded if there was at least a single failure during testing - we use smartRetry for failed tests so the job itself was successful. Since we specify to always download test results it makes no sense that they are downloaded only if there was a failure during the run.

Addressed via https://github.com/saucelabs/saucectl/pull/943. Thank you for reporting this issue!


Missing integration contentNegotiator with urlManager

The contentNegotiator cannot process params generated by rules in urlManager using application configuration.
Example:
<?php

use yii\web\Response;

return [
    'bootstrap' => [
        'contentNegotiator' => [
            'class' => 'yii\filters\ContentNegotiator',
            'formats' => [
				'text/html' => Response::FORMAT_HTML,
            ],
            'languages' => [
				'en-US', 'fr','cs','ru','pl',
			],
        ],
    ],
    'components' => [
        'urlManager' => [
            'enablePrettyUrl' => true,
            'showScriptName' => true,
            'enableStrictParsing' => false,
			'suffix' => '.html',
            'rules' => [
				'<_lang:\w{2}(\-\w{2})?>/<controller:\w+>/<action:\w+>/item-<id:\d+>' => '<controller>/<action>',
				'<_lang:\w{2}(\-\w{2})?>/<controller:\w+>/<action:\w+>' => '<controller>/<action>',
				'<_lang:\w{2}(\-\w{2})?>/<controller:\w+>' => '<controller>/index',
				'<controller:\w+>/<action:\w+>/item-<id:\d+>' => '<controller>/<action>',
				'<controller:\w+>/<action:\w+>' => '<controller>/<action>',
				'<controller:\w+>' => '<controller>/index',
            ],
        ],
    ],
    'vendorPath' => dirname(dirname(__DIR__)) . '/vendor',
];

In fact, it should work in this way.
Moreover, I think that a good solution should be insert 'urlManager' in 'bootstrap' before 'contentNegotiator', but this also does not work.

bootstrap
public function bootstrap($app)
{
	$app->on($app::EVENT_BEFORE_ACTION, function($e){
		/* @var $app \yii\web\Application */
		$app = $e->sender;
		if (in_array($app->request->get('_lang'), ['en-US'])) {
			$app->language = $app->request->get('_lang');
		}
	});

@yurii-github Picking a language can be done by 'contentNegotiator'. Default it works when you define _lang param in url like this:
/index.php/site/index.html?_lang=ru

but it does not work when you use urlManager to determine _lang param
/index.php/ru/site/index.html

Right now I manually run second time negotiate method in main config:
    'on beforeAction' => function ($event) {
        Yii::createObject(Yii::$app->bootstrap['contentNegotiator'])->negotiate();
    },

i see, didn't know.
i made a dig and it looks like a bug. this negotiator uses $request object before it calls resolve() - this method sets _GET params from yii2 query param 'r'. same effect is when we call this resolve in Application::bootstrap()
also, it never hits  code in Request::getQueryParams() as it is never set, at least i cannot find its usage by string search
diff --git a/framework/filters/ContentNegotiator.php b/framework/filters/ContentNegotiator.php
index 9a34b0f..31f8b18 100644
--- a/framework/filters/ContentNegotiator.php
+++ b/framework/filters/ContentNegotiator.php
@@ -215,6 +215,7 @@ class ContentNegotiator extends ActionFilter implements BootstrapInterface
	  */
	 protected function negotiateLanguage($request)
	 {
+    	$request->resolve(); // resolves url, so _GET will be populated with params from yii2 query 'r' (urlManager)
		 if (!empty($this->languageParam) && ($language = $request->get($this->languageParam)) !== null) {
			 if (isset($this->languages[$language])) {
				 return $this->languages[$language];

diff --git a/framework/web/Request.php b/framework/web/Request.php
index 770fc27..3ba5756 100644
--- a/framework/web/Request.php
+++ b/framework/web/Request.php
@@ -457,7 +457,7 @@ class Request extends \yii\base\Request
	  */
	 public function getQueryParams()
	 {
-        if ($this->_queryParams === null) {
+        if ($this->_queryParams === null) { // always null? where is it set?
			 return $_GET;
		 }

Thanks for supporting me, @yurii-github
I think you need to invoke  $request->resolve(); method earlier, because ContentNegotiator use also $formatParam inside negotiateContentType method.

i made dummy test and it looks enough to put extra resolve in negotiateLanguage(), but probably  this resolve should be moved to yii\web\Application:: bootstrap() - so it will be triggered only once. side effects? i have no idea :)
heres how it checked several formats for me. looks legit
<?php
namespace yiiunit\framework\filters;

class ContentNegotiatorTest extends \yiiunit\TestCase
{

	public function pFormats()
	{
		return [
			// -  - - - - - - - - - - - - - - - - - - - negotiator - - -- - - - - - - - - - - - --| - - - app - - -
			//                 format                              | lang key  |      lang        |  expected lang
			[ ['text/html' => \yii\web\Response::FORMAT_HTML],        'de',    ['de' => 'GERMAN'],   'GERMAN' ],
			[ ['application/xml' => \yii\web\Response::FORMAT_HTML],  'de',    ['de' => 'GERMAN2'],   'GERMAN2' ]
		];
	}

	/**
	 * @dataProvider pFormats
	 */
	public function testBoostrapDeclaration($format, $lang_key, $lang, $app_language)
	{
		$request = $this->getMockBuilder('\yii\web\Request')
			->setMethods(['getScriptUrl','resolveRequestUri','getAcceptableLanguages', 'getAcceptableContentTypes'])
			->getMock();
		$request->expects($this->any())->method('getScriptUrl')->willReturn('/index.php');
		$request->expects($this->any())->method('resolveRequestUri')->willReturn("/$lang_key/controllerX/actionX?other-param1=value1");
		$request->expects($this->any())->method('getAcceptableLanguages')->willReturn([]);
		$request->expects($this->any())->method('getAcceptableContentTypes')->willReturn(['text/html'=> [], 'application/xml'=>[]]);

		$cfg = [
			'bootstrap' => [ [ 'class' => '\yii\filters\ContentNegotiator', 'formats' => $format, 'languages' => $lang ] ],
			'components' => [
				'request' => $request,
				'urlManager' => [
					'class' => '\yii\web\UrlManager',
					'enablePrettyUrl' => true,
					'showScriptName' => false,
					'enableStrictParsing' => false,
					'rules' => [ '<_lang:\w{2}>/<controller>/<action>' => '<controller>/<action>' ]
				]
			]
		];

		$this->mockWebApplication($cfg, '\yii\web\Application');
		$this->assertEquals($lang[$lang_key], \Yii::$app->language);
	}

}

hopefully some dev will notice this issue
have nice time

i did dummy test. looks like it is enough to put extra resolve in request, but probably best way is to put resolve in application::bootstrap()
<?php
namespace yiiunit\framework\filters;

class ContentNegotiatorTest extends \yiiunit\TestCase
{

	public function pFormats()
	{
		return [
			// -  - - - - - - - - - - - - - - - - - - - negotiator - - -- - - - - - - - - - - - --
			//                 format                              | lang key  |      lang
			[ ['text/html' => \yii\web\Response::FORMAT_HTML],        'de',    ['de' => 'GERMAN']],
			[ ['application/xml' => \yii\web\Response::FORMAT_XML],  'de',    ['de' => 'GERMAN2']]
		];
	}

	/**
	 * @dataProvider pFormats
	 */
	public function testBootstrapDeclaration($format, $lang_key, $lang)
	{
		$request = $this->getMockBuilder('\yii\web\Request')
			->setMethods(['getScriptUrl','resolveRequestUri','getAcceptableLanguages', 'getAcceptableContentTypes'])
			->getMock();
		$request->expects($this->any())->method('getScriptUrl')->willReturn('/index.php');
		$request->expects($this->any())->method('resolveRequestUri')->willReturn("/$lang_key/controllerX/actionX?other-param1=value1");
		$request->expects($this->any())->method('getAcceptableLanguages')->willReturn([]);
		$request->expects($this->any())->method('getAcceptableContentTypes')->willReturn($format);

		$cfg = [
			'bootstrap' => [ [ 'class' => '\yii\filters\ContentNegotiator', 'formats' => $format, 'languages' => $lang ] ],
			'components' => [
				'request' => $request,
				'urlManager' => [
					'class' => '\yii\web\UrlManager',
					'enablePrettyUrl' => true,
					'showScriptName' => false,
					'enableStrictParsing' => false,
					'rules' => [ '<_lang:\w{2}>/<controller>/<action>' => '<controller>/<action>' ]
				]
			]
		];

		$this->mockWebApplication($cfg, '\yii\web\Application');
		$this->assertEquals($lang[$lang_key], \Yii::$app->language);
	}

}

anyway, i have no idea about side effects

I am unsure about possible solution.
The most obvious whould be add Yii::$app->getRequest()->resolve() to the ContentNegotiator::bootstrap():
public function bootstrap($app)
    {
        $app->getRequest()->resolve();
        $this->negotiate();
    }

However this will cause UrlManager to parse URL twice, which will reduce performance.
Possible walk around will be creating a base controller class and moving ContentNegotiator from bootstrap to this controller filters:
class BaseController extends \yii\web\Controller
{
    public function behaviors()
    {
        return [
            [
                'class' => 'yii\filters\ContentNegotiator',
                ...
        ];
    }
}

class SiteController extends BaseController {...}

@maxlapko Seems like all you want to do is to use a locale in URL. As an alternative you could use our extension here instead: https://github.com/codemix/yii2-localeurls


Help test the Sidebar feature

Getting Started
1. Decide which Mattermost platform you'd like to test the Sidebar feature on:

Desktop App

Navigate to the Mattermost Apps download page and click on the link for the Desktop App that corresponds to your working environment
Install the file and start the Desktop App
Add the following server to test on:

Server Name: Community Testing
Server URL: https://community-testing.test.mattermost.cloud/
Click on "Create one now" to the right of "Don't have an account?" and sign up using a real email account you can verify your sign-up from
Check you email and verify your newly created account then log in to the server

You can test in the default Community team or you can create your own team by clicking on the Hamburger menu and selecting Create a Team

WebApp

Navigate to https://community-testing.test.mattermost.cloud/
Click on "Create one now" to the right of "Don't have an account?" and sign up using a real email account you can verify your sign-up from
Check you email and verify your newly created account then log in to the server
You can test in the default Community team or you can create your own team by clicking on the Hamburger menu and selecting Create a Team

2. Go to this link to find the spec file for the feature.

You'll notice there are 3 phases, viz: Phase 1, Phase 2 and GA Release.  All phases can be tested but please ensure you note which section you're testing if you find an issue or have a question.  You can note this in the feedback spreadsheet (see 3. below)

3. Open this spreadsheet, make a copy of it and then use your copy for reporting issues you find.

There are detailed instructions in this spreadsheet covering what to do if you find a bug or have a question.

You can also ask questions by posting a comment on this issue

Closing this issue as testing is complete.


Talker and listener example not doing anything

I have been trying to get ros2 on Android installed and did the steps outlined here https://github.com/esteve/ros2_java#android and the build process finished successfully. I got two .apk files in the install_isolated/ros2_listener_android/ dir, one debug and one unsigned release with a bunch of other files, similar for the the talker example. I didn't get any apk in the rclandroid directory just an .aar file in the share sub directory.
I then installed the listener and talker debug apk on the same device and ran them both at the same time in split screen mode. After clicking the start button I just get a toast message saying start button was pressed and nothing happens. After this I also tried it on two different android devices, with one running talker and one as listener connected over wifi and again nothing happened just the same toast messages for pressing start and stop button.
I think I am missing a few steps somewhere or doing something wrong. I would be glad for some possible solutions to get this working.

Made some small changes in the apps for split screen mode and got it working


gennodejs: 2.0.2-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository gennodejs to 2.0.2-1:

upstream repository: https://github.com/sloretz/gennodejs.git
release repository: https://github.com/sloretz/gennodejs-release.git
distro file: noetic/distribution.yaml
bloom version: 0.9.1
previous version for package: null

@chris-smith @IanTheEngineer Let me know if this is ok. This is a temporary release of gennodejs from a fork. If I understand correctly, once this PR is merged the 2.0.2 version number is used up. You'll need to use a higher version number when you make a real Noetic release.
context: RethinkRobotics-opensource/gennodejs#25

No problem - I'll leave a note in the issue about the version  number. Thanks.


Added Prettier configuration file and fixed the modal scrollbar issue

resolved #9

Sorry. Fixed the scrollbar issue here.
The vertical scrollbar was present on the wrong container, which also caused the copy button to not stick when scroll vertically.
Both of these are now fixed
Issue:

Solution:

@Yugveer06 Thanks for noticing the issue.


Updates for date range UX

Put the inputs in a row, preferably with the same size as other filters
Add a clear icon either inside or next to the inputs (preferably inside, if possible, like the clear icon for the stations dropdown)
Can we dynamically update the max date of start date and min date of end date based on the selected value of the other component?
Is it possible to set the value in onChange after user clicks on an actual date? Currently, a value is set right after selecting a year, which triggers a search.

Resolved in #42


python3Packages.intellifire4py: 0.7.3 -> 0.9.7

Motivation for this change
https://github.com/jeeftor/intellifire4py/blob/master/CHANGELOG
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 158946 run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.intellifire
python310Packages.intellifire4py
python39Packages.intellifire4py


Make the library compile on Rust 1.0.0-beta.

This commit fixes https://github.com/bjz/glfw-rs/issues/309. I put some TODO-comments near the changes to remind that they can be (mostly) reverted when or if the two features get stable.

Thanks!


Debug messages seen with default verbosity

I had docker instance created along with explicitly installed sql server and when trying to connect to docker instance using backward compat syntax I see these messages.
C:\Users\apdeshmukh\git\go-sqlcmd>.\sqlcmd.exe -Slocalhost:1435
NextBytes InitializeSecurityContext failed 8009030e
NextBytes InitializeSecurityContext failed 8009030e

@apoorvdeshmukh  this would be a driver bug in integratedauth\winsspi\winsspi.go


Main workbench container has wrong background color

I use the theme with zoom  -1 and get a vertical line that separates the sidebar from the editor (and many more places).
The actual culprit is the main workbench container that has the color #F3F3F3.
I can't find any ID that would target this one. So maybe you have some more insight and if not this should be reported in VSC.

I can't reproduce this issue but i think this is a visual glitch of VSC. I will close for now.


Update release in NPM

Hi there,
Would it be possible to push an update for the npm package? The current 2.2.0 version is missing the sortPropertiesBy feature.
Thanks :)

Published 2.2.1

Really appreciate it!!

On Aug 3, 2018, at 1:59 PM, Mohsen Azimi<EMAIL_ADDRESS>wrote:
Published 2.2.1
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


material-dropdown-select not showing error message when form model validation fails

For example if I have following markup

testModel = FormBuilder.controlGroup({
  "test1": ["", Validators.required]
});

setting empty field in model makes material-input field to show default error message "enter value" while dropdown will not show any kind of errors.

Can confirm. A simple setup also shows it:
<material-dropdown-select
  [options]="statusOptions"
  [(ngModel)]="statusValue"
  [required]="true"
  deselectLabel="Deselect"
  #status="ngForm"
  ngControl="status"
></material-dropdown-select>

{{status.valid}} {{status.errors}}

This shows that the status.valid is false and that there is a required validation error, but the select doesn't show anything.

Can confirm. A simple setup also shows it:
<material-dropdown-select
  [options]="statusOptions"
  [(ngModel)]="statusValue"
  [required]="true"
  deselectLabel="Deselect"
  #status="ngForm"
  ngControl="status"
></material-dropdown-select>

{{status.valid}} {{status.errors}}

This shows that the status.valid is false and that there is a required validation error, but the select doesn't show anything.


Multiline comments to one-line

Is that possible to convert multiline comments and PHPDocs with into one-line?
Only for comments with one line of useful information.
Example
Before:
/**
 * @Example
 */

After:
/** @Example */

Hi @zored
At the moment we do not have a rule/fixer to do that.
Could you elaborate or provide a use case for when you would want this to happen?

@SpacePossum, hi.
This rule would save 2 extra lines of code per each one-line comment block. Code will be more compact and easier to read.
For example, I have model objects with many properties that only have '@var' type definitions. And each property has getter with only '@return' annotation. They occupy 'N x 2 x 2' lines of code (where 'N' is number of properties).
Or '@inhertDoc' that occupies two extra lines of code.
Thanks for reply :)

I won't use such fixer personally, but the use case seems valid to me.

Currently using my own simple script for conversion.

I wouldn't use that fixer as well. but it's not blocking the fixer to become accepted.
Actually, I would use reverse fixer for methods/classes/properties, but one-line docblock for regular vars.
Would be great to see it that generic and configurable.

This code:
<?php
class Hi
{
    /** @return string */
    public function hello($string)
    {
        return $string;
    }
}

Fixes comment into:
    * @param mixed $string
/** @return string */

So existing code should be aware about this type of comments.
@keradus, yes, options for this rule will be great. I think that some users will prefer to use multiline one-liners because they are easier to modify.

Fixes comment into:

what is fixes comment into that invalid piece of code? PHP CS Fixer or your custom script? if first, we have very sad bug here.

@keradus PHP CS Fixer 2.1.2.
The good news is that this one-line format rarely used in method PHPDocs  😃

ok, let us move discussion about invalid phpdoc modification here: https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2654
here, let us focus only on multiline vs oneline docblock ;)

If anyone wants to pick this up, this is 'somewhat' included in the phpunit test annotation fixer, although it can be improved upon quite a bit.
https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/99aeaa2fa1063879ea5782b034eac48f2f6766d3/src/Fixer/PhpUnit/PhpUnitTestAnnotationFixer.php#L441-L477

I'd like to implement this since we format all of our properties with only the @var attribute this way.
-/**
- * @var string
- */
+/** @var string */
private $foo;

One thing that would be nice is knowing what the comment is commenting. We do method comments in multiple lines, even if there's only one meaningful line:
/**
 * @return string
 */
public function foo() { ... }

One could configure the comments of which declarations the fixer is allowed to fix:

classes (including traits and interfaces)
functions (including methods)
properties
variables

So we would need to look just far enough to recognize the next statement.
It's a pity that php-cs-fixer doesn't have a parse tree. That would make a lot of rules much simpler.

Wow, I completely missed that this already has a PR. Sorry.

fixed in https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3810


Validation fixes to match Specification V0.8

Many thanks for submitting your Pull Request :heart:!
Validation fixes to match specification Version0.8 - iterationParam, workflow startState, and workflow name are made optional
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):

@manick02 Thank you!!


Confetti 🎉 🎊

Changes

Add confetti service

Shoot confetti after successful export
Shoot confetti after successful update

Disable export button when palette has no colors

:tada: This PR is included in version 1.4.0-staging.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Feature request: folder mapping

I was using WebStorm for development and want to switch to VSC.
This is the last feature I need to complete the transition.
Currently, in WebStorm, I setup folder mapping to sync different locations of the files to a different site.
For example:
- scripts
- ui
  - src  // VSCode is opened here, because it doesn't work with multiple folders yet.
  - debug

is mapped to:
- root
  - unional
    - scripts (mapped to scripts)
    - core (mapped to ui/src)
    - debug (mapped to ui/debug)

The local folder structure is defined by the repository so I can't change it. 😢

Great feature request! 👍
I have implemented this in version 3.0 which is now available! :D
You have to define the list of mappings in a target (an example for SFTP):
{
    "deploy": {
        "targets": [
            {
                "type": "sftp",
                "name": "My SFTP folder",
                "description": "A SFTP folder",

                "mappings": [
                    {
                        "source": "ui/src",
                        "target": "core"
                    },
                    {
                        "source": "ui/debug",
                        "target": "debug"
                    }
                ],

                "dir": "/my_package_files",
                "host": "localhost", "port": 22,
                "user": "tester", "password": "password",
            }
        ]
    }
}

This works for:

FTP
HTTP
Local
Mail
Remote
SFTP
ZIP

Great. I am trying it with SFTP and it seems like it is very slow. Do you know what trick WebStorm does to make it so fast?

Nevermind. Seems like it is ok now. Will see how long it takes. 🌷

I optimized the deploying of files to (S)FTP since version 3.0.
In earlier version, a new connection was opened for each file. This was really slow.
Now there is only one connection opened for one operation. Even if you have 1000 of files or only one.
That makes it a lot faster.


Support wildcards in json:// and yaml:// so that values can be retrieved with slice

ref: #534
Proposal
Support wildcards in json:// and yaml:// so that values can be retrieved with slice.
Only when a wildcard ( * ) is used, the expanded values become a slice.

@k2tzumi If you don't mind, I'd like to hear your opinion.

If pattern matching with wildcards and . / (dot-dot-slash), there is a concern that directory traversal vulnerabilities may occur.
I have the impression that it would be difficult to use wild card matching because the order of appearance on the slice would be indefinite.
It seems to me that the goal of this PR should be more clearly defined.

Solution to prevent vars from being fat
Better Data Management Methods for Data Driven Testing

Thank you for your advice!

If pattern matching with wildcards and . / (dot-dot-slash), there is a concern that directory traversal vulnerabilities may occur.

Since we already allow dot-dot-slash, I thought it would be on the same level if wildcard was allowed?

because the order of appearance on the slice would be indefinite.

https://github.com/k1LoW/runn/pull/545/files#diff-29e5d1896212c61371d2eb62885b72355eb956d2b92da55ae85b11bcaa5212cfR66
It sorts the matched files. I think that this correspondence will at least fix the order.

It seems to me that the goal of this PR should be more clearly defined.

You are absolutely right.
Looking at #534,
I thought there was a request for one JSON file per application/json HTTP request, and one JSON file per application/json HTTP response.
I thought this PR might be a good idea since it is a feature enhancement and I can confirm that the modification will not affect existing implementations.
However, I have not thought deeply about this PR yet, so there may be other problems.

Some of the security concerns can now be suppressed by the scope.
Therefore, we are merging this feature.


At times chip-tool connecting to incorrect discriminator

At times , chip-tool connecting to incorrect discriminator , cmd is referring to device with 3840 but its connecting to device with 4000
% ./out/host/chip-tool pairing ble-wifi MYSSID MYPASSWD 87564321 20202021 3840
[1621036068978] [0x6dd0c2] CHIP: [DL] _Init
[1621036068978] [0x6dd0c2] CHIP: [IN] TransportMgr initialized
[1621036068978] [0x6dd0c2] CHIP: [IN] local node id is 0x000000000001b669
[1621036068978] [0x6dd0c2] CHIP: [ZCL] Using ZAP configuration...
[1621036068978] [0x6dd0c2] CHIP: [ZCL] deactivate report event
[1621036068978] [0x6dd0c6] CHIP: [DL] CHIP task running
[1621036068978] [0x6dd0c2] CHIP: [DMG] ICR moving to [Initialize]
[1621036068978] [0x6dd0c2] CHIP: [DL] Chip stack locking error at '../../third_party/connectedhomeip/src/system/SystemLayer.cpp:204'. Code is unsafe/racy
[1621036068978] [0x6dd0c2] CHIP: [BLE] NewConnection
[1621036068980] [0x6dd0c2] CHIP: [BLE] Assigned local session key ID 0
[1621036068981] [0x6dd0c2] CHIP: [DL] Chip stack locking error at '../../third_party/connectedhomeip/src/system/SystemLayer.cpp:204'. Code is unsafe/racy
[1621036068981] [0x6dd0c2] CHIP: [IN] Message appended to BLE send queue
[1621036068981] [0x6dd0c2] CHIP: [BLE] Sent PBKDF param request
[1621036069044] [0x6dd0c9] CHIP: [BLE] CBManagerState: ON
[1621036069270] [0x6dd0c9] CHIP: [BLE] Connecting to device with discriminator: 4000
[1621036070510] [0x6dd0cb] CHIP: [IN] BleConnectionComplete: endPoint 0x10d18b740
[1621036070510] [0x6dd0cb] CHIP: [DL] Chip stack locking error at '../../third_party/connectedhomeip/src/system/SystemLayer.cpp:204'. Code is unsafe/racy
[1621036085514] [0x6dd0c6] CHIP: [BLE] connect handshake timed out, closing ep 0x10d18b740
[1621036085514] [0x6dd0c6] CHIP: [IN] Failed to establish BLE connection: Ble Error 6021 (0x00001785): Connect handshake timed out
[1621036085514] [0x6dd0c6] CHIP: [IN] Clearing BLE pending packets.
[1621036085514] [0x6dd0c6] CHIP: [BLE] BtpEngine unsub failed
[1621036085514] [0x6dd0c6] CHIP: [BLE] Auto-closing end point's BLE connection.
[1621036098982] [0x6dd0c6] CHIP: [TOO] Pairing Failure: CHIP Error 4050 (0x00000FD2): Timeout
[1621036098982] [0x6dd0c6] CHIP: [BLE] PASESession timed out while waiting for a response from the peer. Expected message type was 33
[1621036098982] [0x6dd0c6] CHIP: [TOO] Secure Pairing Failed
[1621036098982] [0x6dd0c2] CHIP: [CTL] Shutting down the commissioner
[1621036098982] [0x6dd0c2] CHIP: [CTL] Shutting down the controller
[1621036098982] [0x6dd0c6] CHIP: [TOO] Pairing Failure: CHIP Error 4050 (0x00000FD2): Timeout
[1621036098983] [0x6dd0c2] CHIP: [DL] System Layer shutdown
[1621036098983] [0x6dd0c2] CHIP: [DL] Inet Layer shutdown
[1621036098983] [0x6dd0c2] CHIP: [DL] BLE layer shutdown
[1621036098985] [0x6dd0c2] CHIP: [DMG] ICR moving to [Uninitiali]

@cjandhyala : how did derive fabric-id as 87564321 ? Can you help me?
I don't see any documentation on how to use chip-tool. Thanks

We're in progress of reviewing older issues. Is this still an issue given how old the SDK this was tested against? Please re-open if so. Thanks!


PParrot BE critical path fixes

Original: Critical paths through npc_check, then through nop logic, then cache->cache path which was unnecessary because of cache miss poison logic.
Frequency: 400 MHz
Area: 1283284.900015
Median
IPC: 466
MIPS: 186.4
Power: 1.1842e+05 uW
EPI: 635.3 pJ
Multiply
IPC: 488
MIPS: 195.2
Power: 1.1769e+05 uW
EPI: 602.9 pJ
Towers
IPC: 505
MIPS: 202
Power: 1.2628e+05 uW
EPI: 625.1 pJ
Vvadd:
IPC: 453
MIPS: 181.2
Power: 1.1553e+05 uW

EPI: 637.6 pJ
———————————————
With fixes: critical path now through dcache->bypass paths->dispatch.  Additionally, a parameter (default off) is added to disable this load->use forwarding. Expect an IPC decrease if this parameter is enabled.
Frequency: 513 MHz
Area: 1287764.798082
Median
IPC: 454
Power: 1.1736e+05
MIPS: 232.9
EPI: 503.9
Multiply
IPC: 460
Power: 1.1724e+05
MIPS: 236.0
EPI: 496.8
Towers
IPC: 486
Power: 1.2545e+05
MIPS: 249.3
EPI: 503.2
Vvadd:
IPC: 443
Power: 1.1548e+05
MIPS: 227.3
EPI: 508.1
———————————————
Note: All results post-synthesis

@stdavids So we merge this and then announce to the BE teams that this branch is available from them to update from?

We have to create the new branch and redirect it manually first (I just did that). Now we can merge and announce the new branch (pparrot_blackcanary_becriticalpathfixes).

@stdavids @dpetrisko  Has this been merged?


Perform load testing with Locust

Resources:

https://towardsdatascience.com/performance-testing-an-ml-serving-api-with-locust-ecd98ab9b7f7
https://microsoft.github.io/PartsUnlimitedMRP/pandp/200.1x-PandP-LocustTest.html
https://github.com/https-deeplearning-ai/machine-learning-engineering-for-production-public/tree/main/course4/week2-ungraded-labs/C4_W2_Lab_3_Latency_Test_Compose

Need to calculate some metrics like QPI(Queries Per Inference)

Here's another wonderful resource: https://cloud.google.com/architecture/load-testing-and-monitoring-aiplatform-models.

Experiment #1 setup (TBD, WIP)

VM (Custom Spec) for GKE nodes: 2vCPU, 4GB RAM, 100GB Storage

the ONNX model size is 100MB

of Workers: 1 (using uvicorn)

of Replicas: 8

of Users: 100

Hatch Rate: 5

vs

VM (Custom Spec) for GKE nodes: 8vCPU, 16GB RAM, 100GB Storage

of Workers: 4 (using guicorn)

of Replicas: 2

of Users: 100

Hatch Rate: 5

vs

VM (Custom Spec) for GKE nodes: 16vCPU, 32GB RAM, 100GB Storage

of Workers: 8 (using guicorn)

of Replicas: 1

of Users: 100

Hatch Rate: 5

@deep-diver to specify the number of workers for uvicorn and gunicorn separately I guess that change needs to happen at Dockerfile level?
Also, it would be great to know the Locust setup you are following so that I can also take part.
Once the GKE clusters are created for each of the setup you mentioned we can distribute the workload. WDYT?

@sayakpaul
sure thing! I will create a PR for the Locust stuff (it has just few lines of code). Also, you are right. The change needs to happen at Dockerfile level for gunicorn setup.

Cool. For making sure we are following the setup for running the load-tests, I think this is going to be immensely helpful.

Cool. Maybe add a note on how to interpret them?

Or we could host the report as a GitHub Release artifact to have the repo structure clean and precise. WDYT?

We have performed extensive load-testing. See locust directory.


Removed the word link between Atlas and external link icon #416

Removed the word link between Atlas and external link icon from the map detail page.

@Moylena

@thansidwell  are you able to support this please?

@thansidwell  would you be able to help with this?

@AZBL @Moylena I don't see anywhere to view a preview of it. It is such a low-risk change I think we can just approve it without seeing it.


finetune coco caption got loss nan

hi, blip2 is very creative and impressive.
While i try to run official code with command "torchrun --nproc_per_node=8  train.py --cfg-path lavis/projects/blip2/train/caption_coco_ft.yaml",  i always get loss nan after one iteration with detail logs as below :
[INFO] Start training epoch 0, 4427 iters per inner epoch.
Train: data epoch: [0]  [   0/4427]  eta: 9:01:56  lr: 0.000000  loss: 1.9126  time: 7.3449  data: 0.0000  max mem: 26284
[INFO] Reducer buckets have been rebuilt in this iteration.
Train: data epoch: [0]  [  50/4427]  eta: 6:32:09  lr: 0.000001  loss: nan  time: 5.3553  data: 0.0000  max mem: 34957
Are there run-params in yaml file  that should be changed ?

Please see https://github.com/salesforce/LAVIS/commit/0e9a3ecfa5dc668761ce6c0e3cf827578e8593c4 for the fix.

Let us know how it goes. Feel welcome to reopen if issue persists.

hi, thanks for the updating, seems training works well with the fixed code,  so far it has run hundreds of iterations. will keep observe 😊

hi, blip2 is very creative and impressive. While i try to run official code with command "torchrun --nproc_per_node=8 train.py --cfg-path lavis/projects/blip2/train/caption_coco_ft.yaml", i always get loss nan after one iteration with detail logs as below : [INFO] Start training epoch 0, 4427 iters per inner epoch. Train: data epoch: [0] [ 0/4427] eta: 9:01:56 lr: 0.000000 loss: 1.9126 time: 7.3449 data: 0.0000 max mem: 26284 [INFO] Reducer buckets have been rebuilt in this iteration. Train: data epoch: [0] [ 50/4427] eta: 6:32:09 lr: 0.000001 loss: nan time: 5.3553 data: 0.0000 max mem: 34957 Are there run-params in yaml file that should be changed ?

Can I ask what notebook and/or tutorial you used for finetuning BLIP2?
I'm trying to do it on a custom dataset, but am having trouble finding a fine tuning notebook or set of instructions to fine tune BLIP2.

Hello, in this commit, the training code chose not to optimize the ViT image encoder part for finetuning, which is not the same as the finetuning setting in the paper, and leads to suboptimal result compared with the performance reported in the paper after finetuning (I experimented on VQA2.0 finetuning and got 70 v. 82 in the paper), while unfreezing ViT leads to the nan loss problem (following layer-wise learning-rate decay and other setting in paper). Freezing ViT do solve the problem but it corrupts the performance.
Could you provide the training setting used to finetune on VQA2.0 (e.g., the config file as for COCO Captions )

Fixed in 0e9a3ec.


Added Embu University

Am a student excited to use JetBrains products in my learning
https://embuni.ac.ke/

@kinare First stage of verification passed, official domain is embuni.ac.ke as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@kinare Thank you for your patience while waiting for a review and processing your request. Pull request merged.


playground examples not working with one click

Bug report
I take this error both in playground and playground_navigator2.After opening wolt_modal_sheet, I cannot select an element in the list with a single click.In the playground example, I cannot select it at all. In the playground_navigator2 example, I can select it with double click. I think the reason for this in playground is that pageListBuilder is called with every change, so it is rebuilt each time. https://github.com/woltapp/wolt_modal_sheet/blob/3da966e3ba1e94f53e45c7373c84ff74e30ff93c/playground/lib/home/pages/multi_page_path_name.dart#L32
I was going to look into how to fix this, but I didn't understand whether it was an undesirable behavior or whether it was done this way on purpose.
Steps to reproduce
Steps to reproduce the behavior:

Playground Example
Playground Nav 2 Example

Expected behavior
I think we should be able to select it with a click

Thanks for the report. It looks like 0.4.0 has issues. 0.3.0 should still be working. We are on it.

@AcarFurkan We found out the root cause, and we will release the hotfix tomorrow.

First of all, thank you for your attention so quickly :) I also found the reason why the error did not occur in the past but now. Actually, the _addPage method is called again in the else section and it calls _createIncomingWidgets again. I wanted to ask because I was curious. Why did we need to renew the _incomingPageWidgets in case the index did not change? What kind of case did you have to do this for? I would be very happy if you would like to answer. Thank you, it is a very nice and detailed repo :)
https://github.com/woltapp/wolt_modal_sheet/blob/3da966e3ba1e94f53e45c7373c84ff74e30ff93c/lib/src/content/wolt_modal_sheet_animated_switcher.dart#L194C1-L205C1

Thanks for checking the issue. Yes this is because of the lines you pointed.
WoltModalSheet has been an internal component at Wolt for around 3 years. We open sourced this component less than a year ago.  We are at a point that it takes significant time resources to make WoltModalSheetPage a widget rather than a data holder class.
Before 0.4.0, the state management through the decorator widget worked well as long as the same widgets are used for different states.
When the state changes, if the page content completely changes, these changes would not be reflected because the current page widgets are not re-created.
For example, this would not work (TaskItemHistoryDetailViewModel is injected through decorator).
      pageListBuilder: (context) {
        final viewModel = context.watch<TaskItemHistoryDetailViewModel>();
        final state = viewModel.state;

        return [
          SliverWoltModalSheetPage(
            mainContentSlivers: state.viewState.when(
              loading: () => const [
                SliverToBoxAdapter(
                  child: Center(
                    child: Padding(
                      padding: EdgeInsets.all(sp16),
                      child: LoadingIndicator(size: _loadingIndicatorSize),
                    ),
                  ),
                ),
              ],
              idle: () => TaskItemDetailModalContent.createSlivers(
                aggregatedItem: aggregatedTaskItemHistory,
                options: state.taskItemOptionsHistory.options,
              ),
              error: () => [
                SliverToBoxAdapter(
                  child: FullScreenErrorWidget(
                    error: state.error ?? ParsedError(error: Object()),
                    action: () => viewModel.onInit(
                      aggregatedTaskItemHistory,
                      selectedPastOrdersFilterSet,
                    ),
                  ),
                ),
              ],
            ),
          ),
        ];
      },

My change attempted to re-create current pages everytime the page state changed, but this ended up losing the states of the current widgets. We should have done better testing. Anyway, a hotfix is coming.
The best way to update the widgets according to state:

Use decorator to mount the ViewModel or ChangeNotifierProvider or BlocProvider or. your fav. state management state holder widget.
Expose value listenables from the ViewModel.
Wrap the page components with ValueListenableBuilder or ListenableBuilder.

This workaround would work.
    return WoltModalSheet.show(
      context: context,
      pageListBuilder: (context) {
        final viewModel = context.read<TaskItemHistoryDetailViewModel>();

        return [
          WoltModalSheetPage(
            child: ListenableBuilder(
              listenable: viewModel,
              builder: (context, _) {
                final state = viewModel.state;
                final viewState = state.viewState;

                return viewState.when(
                  loading: () => const Center(
                    child: Padding(
                      padding: EdgeInsets.all(sp16),
                      child: LoadingIndicator(size: _loadingIndicatorSize),
                    ),
                  ),
                  idle: () => TaskItemDetailModalContent(
                    aggregatedItem: aggregatedTaskItemHistory,
                    options: state.taskItemOptionsHistory.options,
                  ),
                  error: () => FullScreenErrorWidget(
                    error: state.error ?? ParsedError(error: Object()),
                    action: () => viewModel.onInit(
                      aggregatedTaskItemHistory,
                      selectedPastOrdersFilterSet,
                    ),
                  ),
                );
              },
            ),
          ),
        ];
      },
      decorator: (widget) => ViewModelProvider<TaskItemHistoryDetailViewModel>(
        builder: (_, model, __) => widget,
        onViewModelProvided: (viewModel) => viewModel.onInit(
          aggregatedTaskItemHistory,
          selectedPastOrdersFilterSet,
        ),
      ),
    )

I understand it better now, thank you very much :) Sometimes it can be very difficult to transfer projects to open source. While you can solve everything internally with your methods, it can be very difficult to open it up and make it work for everyone. But a more modular code will certainly emerge at the end of the day

@AcarFurkan If we had integration tests in place, we would have been in safer spot. Working on it. Closing this as we reverted the root cause.


Merge pull request #3125 from npoltorapavlo/DELIA-57822

DELIA-57822: JSON-RPC misuse

this merges rdkcentral#3125 partially due to conflicts. ota_5 and main have diverged too much


init() got an unexpected keyword argument 'bimamba'

Thanks for your great work. I have a question that when running the run_videomamba_pretraining.py or  videomamba.py directly, there is a line of code in create_block that reads 'mixer_cls = partial(Mamba, layer_idx=layer_idx, bimamba=bimamba, **ssm_cfg, **factory_kwargs)', but the initialization function of Mamba (from mamba_ssm.modules.mamba_simple import Mamba) does not have the ‘bimamba’ parameter.

Hi! Please install mamba by pip install -e mamba as shown here.


RollerShutterItem "No Response"

Hey, its me again.
Im super happy with your script it works like a charm.
But I have a problem concerning my shutters.
I configured them like openHab told me to, so
first group address: Up/Down
second group address: Stop
third group address: percentage
But I get the notification "No response" in HomeKit.
Whats wrong?
Thanks
curry

Do your shutters support open/close to a specific percentage? OpenHAB-HomeKit-Bridge will always send a value [0-100] to openHAB.
In my case the shutters only support UP or DOWN commands. I therefore created a simple rule for every shutter in openHAB to turn the percentage values into commands:
// Esszimmer
rule Rollershutter_Esszimmer_up
when
    Item Shutter_GF_Essen received command 0
then
    sendCommand(Shutter_GF_Essen, UP)
end

rule Rollershutter_Esszimmer_down
when
    Item Shutter_GF_Essen received command 100
then
    sendCommand(Shutter_GF_Essen, DOWN)
end

Okay, that works great!
Thanks for the great support


EntityWork#2

Required items, please complete
Change(s):

Diana and Manny modified a few detection yaml files to add mappings for better correlation with Defender detections.

Reason for Change(s):

To hopefully get better correlations with their equivalent Defender detections.

Version Updated:

Yes

Testing Completed:

No

Checked that the validations are passing and have addressed any issues that are present:

No

Hi @mmelndezlujn, thanks for raising this PR, we will review this PR by 2 Nov 2023.

Hi @mmelndezlujn, thanks for the raising this PR, this PR is under review.


[Bug] Incompatibility with Lithium and C2ME

Apart from C2ME, BetterEnd seems to be incompatible with Lithium. The log is as follows:
crash-2022-01-22_00.38.22-server.txt
With BetterEnd and C2ME enabled, the server crashes when the End is first loaded. Subsequent crashes happen when going through end portal to outer islands.
With C2ME disabled but Lithium still up, the server crashes randomly seemingly when generating chunks.
BetterEnd seems to conflict with mods that modify the chunk generation logic, the server launches without crashing with BetterEnd disabled.

Duplicate of #375


Broken by Sketch 3.9 with "Set Page's Stylesheet" selection loop.

CSSketch no longer functions with the Sketch 3.9 update. Attempting to assign a stylesheet to a sketch doc results in a selection loop:

Open a sketch doc. In this case the Keyboard.sketch example.
Select "Plugins" > "CSSketch" > "Set Page's Style"
Finder opens > Navigate to and select Keyboard.less stylesheet > Click "Choose"
After clicking the "Choose" button, it becomes disabled.
Reselect Keyboard.less  > Click "Choose"
GoTo # 4 and repeat infinitum.

I had this problem too

Hi, I have the same problem here. Sketch 3.9.1

+1 same problem. Sketch 3.9.1
@JohnCoates , I would love to help, but don't know where to start. Seems like the plugin fails to get the stylesheet URL. Or am I digging at the wrong place? Really appreciate your help here

Ok thats why nothing happened when i try to use this plugin  🎯

Daaaaamn! To good to be true...
Do you think you can do something @JohnCoates ?

+1

+1

+1 does not work in Sketch 3.9.1

Let's try to debug to see where the mismatch is... Don't just complain ;)

+1 any updates in this?

Having the same issue with Version 4.0.1.
Also console is showing this error, not sure if it is related:

Appreciate your help in solving this @JohnCoates

same here

I'm trying to debug this issue. It seems like the context argument of
(void)selectStylesheetWithContext:(NSDictionary *)context
Is always an empty dictionary. The dictionary should contain a document and a command property to make the connection between the css and the sketch file.
The strange thing is that the context does has value in the CSSSketch.js file but it gets lost when  its send to CSKMainController.selectStylesheetWithContext.
I'll try to fix the issue but I'm new with sketch plugin development so any hints or tips might come in handy.


Autofill with array of fields

I've searched the issues and I can't find one related. I'm using the autofill action to populate all the fields after an address lookup. If there are two fields I need to update to I need to dispatch an action for each field. Is there a way to dispatch one action which accepts an array?
Perhaps an array of objects which look like:
[
  ...
  {
    field: 'addressLine1',
    value: 'First line of address'
  }
...
]

What do you think?

In general, I don't think that fear of dispatching many successive actions is warranted. For example, I don't think that each one is going to cause a rerender, because the rerender happens on the next process tick. However, it certainly seems like you could wrap the redux-form reducer in an action batching higher order reducer with no modifications whatsoever to this library. If you choose to do that, I'd love to know how it goes.

Thanks for the quick reply. Your explanation makes sense and I agree perhaps my fear was unwarranted. I'll see how I get on!

Unfortunatley, using a batching reducer like @erikras suggested is not possible in the most common use-case of calling the redux-form bound action creators passed as props to one's form.
Instead, one has to resort to the less convenient (and less recommended) unbound versions, as well as wrap the form with a react-redux connect() to pass down the dispatch method of the store.
However, I do agree that multiple dispatches will not cause multiple renders in most cases, but they will cause multiple subscriber notifications.


Release/122.0.0

Explanation

References

Changelog

@metamask/package-a

: Your change here
: Your change here

@metamask/package-b

: Your change here
: Your change here

Checklist

[ ] I've updated the test suite for new or updated code as appropriate
[ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
[ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate

The ensure-blocking-pr-labels-absent check (which is new) hadn't run yet, so it was preventing this PR from being merged. I've added and removed a label which will force it to run and this PR should be good to merge now.


Request to help run the script on individual clusters in Datacenter

HI team,
could you please let me know the changes to be made to run this script to get information from an individual cluster in the datacenter,
I am not sure weather it is already available if so kindly share the information.

You basically have to modify the connection plugin to filter each data collection step to just that cluster.
Issue #169 has been open forever to finally implement filters better, but just lack the time to implement anything...


Name of RuleParameter is ignored if the type is recognized

Evaluating a rule twice with differently-named objects of the same type gives unexpected results.
Here's my test code:
using Newtonsoft.Json;
using RulesEngine.Models;
using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Dynamic;
using System.Linq;
using System.Threading.Tasks;
using Xunit;

namespace RulesEngine.UnitTest
{
  [ExcludeFromCodeCoverage]
  public class RunTwiceTest
  {
    [Fact]
    public async Task RunTwiceTest_ReturnsExpectedResults()
    {
      var workflow = new Workflow {
        WorkflowName = "RunTwiceWorkflow",
        Rules = new Rule[] {
            new Rule {
                RuleName = "RunTwiceRule",
                RuleExpressionType = RuleExpressionType.LambdaExpression,
                Expression = "test.blah == 1"
            }
        }
      };
      var reSettings = new ReSettings { };
      var engine = new RulesEngine(reSettings: reSettings);
      engine.AddOrUpdateWorkflow(workflow);

      const string json_pass = @"
      {
        ""test"": {
          ""blah"": 1
        },
      }
      ";
      const string json_fail = @"
      {
        ""SOME_OTHER_OBJECT_NAME"": {
          ""blah"": 1
        },
      }
      ";

      JsonSerializerSettings SerializerSettings = new JsonSerializerSettings {
        DateParseHandling = DateParseHandling.None
      };
      RuleParameter[] FromJson(string json)
      {
        var input = JsonConvert.DeserializeObject<ExpandoObject>(json, SerializerSettings) ?? throw new Exception("Failed to deserialize inputs.");
        var inputDictionary = input.ToDictionary(kvp => kvp.Key, kvp => kvp.Value);
        return inputDictionary.Where(kvp => kvp.Value != null).Cast<KeyValuePair<string, object>>().Select(kvp => new RuleParameter(kvp.Key, kvp.Value)).ToArray();
      }

      // Create two RuleParameter[]s
      // They both only contain one RuleParameter
      // inputs_pass contains a RuleParameter called "test"
      // inputs_fail contains a RuleParameter called "SOME_OTHER_OBJECT_NAME"
      var inputs_pass = FromJson(json_pass);
      var inputs_fail = FromJson(json_fail);
      Assert.Equal("test", inputs_pass.First().Name);
      Assert.Equal("SOME_OTHER_OBJECT_NAME", inputs_fail.First().Name);
      // So I would expect my rule (test.blah==1) to pass for input_pass
      // And to fail for inputs_fail.
      // It passes for both.
      var pass_results = await engine.ExecuteAllRulesAsync("RunTwiceWorkflow", inputs_pass);
      var fail_results = await engine.ExecuteAllRulesAsync("RunTwiceWorkflow", inputs_fail);
      Assert.True(pass_results.First().IsSuccess);
      Assert.False(fail_results.First().IsSuccess);
    }
  }
}

I've had a dig around, and it seems like the main problem is GetCompiledRulesKey in RulesEngine.cs.
private string GetCompiledRulesKey(string workflowName, RuleParameter[] ruleParams)
{
    var key = $"{workflowName}-" + string.Join("-", ruleParams.Select(c => c.Type.Name));
    return key;
}

At first glance, it looks like the engine plucks a rule out of the cache if the inputs are of the same type ... doesn't matter if they are the same name. Also, I'm guessing that if a rule takes multiple inputs of the same type, the order that they are supplied to the cached rule will be anyone's guess.
A quick fix might be to include the param name in that key calculation (perhaps sort the ruleParams by name beforehand?). At the moment I'm not sure what the side-effects would be. I do know that it fixes that test, although I would expect fail_results to then contain some kind of "Unknown identifier" message, but it instead contains this:
Exception while parsing expression `test.blah == 1` - The binary operator Equal is not defined for the types 'System.Object' and 'System.Int32'

Closing, fixed by this PR: https://github.com/microsoft/RulesEngine/pull/386


brutespray erroring out

I noticed the below err when tried running the script on my Mac. I tried both with ~/ and calling the file explicitly. I still get the same error. This is the system I am running on Darwin HQSML-1689616 19.6.0 Darwin Kernel Version 19.6.0: Thu Jun 18 20:49:00 PDT 2020; root:xnu-6153.141.1~1/RELEASE_X86_64 x86_64
 python3 /opt/brutespray/brutespray.py --file YJ-2020Q3-nmap_portknock-2020.10.07-17.15.47.gnmap -U ~/path/to/file/usernames.list -P ~/path/to/file/passwords.list --threads 10 --hosts 10 -c --output ../l00tz

 brutespray.py v1.6.8
 Created by: Shane Young/@x90skysn3k && Jacob Robles/@shellfail
 Inspired by: Leon Johnson/@sho-luv
 Credit to Medusa: JoMo-Kun / Foofus Networks<EMAIL_ADDRESS>
Starting to brute, please make sure to use the right amount of threads(-t) and parallel hosts(-T)...
Output will be written to the folder: ./../l00tz/ \

Brute-Forcing...
Process Process-1:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 315, in _bootstrap
    self.run()
  File<EMAIL_ADDRESS>line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/brutespray/brutespray.py", line 245, in brute
    if args.userlist is None and args.username is None:
NameError: name 'args' is not defined
Process Process-2:
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 315, in _bootstrap
    self.run()
  File<EMAIL_ADDRESS>line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/opt/brutespray/brutespray.py", line 245, in brute
    if args.userlist is None and args.username is None:
NameError: name 'args' is not defined

this has to do with the way MacOS handles multiprocessing, i pushed an update to the testing-1.6.9

Thank you! @x90skysn3k

no problem! closing issue


Bitfinex brokerage implementation

Implement Bitfinex cryptocurrency trading platform using API v1.1
Description
BitfinexBrokerage is a websocket based brokerage
Related Issue
#2392
Motivation and Context
Cryptocurrency trading is quite poor in Lean because of GDAX is very limited.
Requires Documentation Change
Current implementation requires changes in documentation for IDataDownloader as it supports new arguments values.
How Has This Been Tested?
I've tested it manually using simple algorithm to placing/update/cancel orders. Also unit tests covering new code created.
BitfinexBrokerageTests requires a valid apikey and apisecret to test it over production
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description or feature-<issue#>-<description>

@Adalyat awesome job man this is a little hidden gem in Lean right now, wondering what can that new bitfinex supported exchange do?
-Does it support Margin trading? can we short now?

Can we trade BTCETH? e.g. no USD default currency?

Thanks!

also please note following . SetWarmup behaves wrong when you have subscribed to the minute bars but have chosen some indicator on different resolution (Hour) . So  to make algo warm up for Tema i had to set WarmUp tp 9600 approximately.


Resolve Open-Redirect + iFrame Injection

This PR aims to resolve the possibility of iFrame Injection within the JavaDoc for this project. While it is a security concern, due to its low severity/impact, a simple PR can be all it takes to resolve it.

Hi! Any update? Is this valid?


Connect to remote BTCPayServer lnd instance

I followed the instructions to connect to a remote lnd instance but continuously got the following:
2021-05-16 13:18:35.399 [INF] LITD: Dialing lnd gRPC server at btcpay.xyz.xyz:443
2021-05-16 13:18:35.501 [INF] LITD: Listening for http_tls on: <IP_ADDRESS>:8443
2021-05-16 13:18:35.837 [WRN] GRPC: grpc: addrConn.createTransport failed to connect to {btcpay.litservices.app:443  <nil> 0 <nil>}. Err: connection error: desc = "transport: authentication handshake failed: x509: certificate signed by unknown authority". Reconnecting...
2021-05-16 13:18:35.837 [INF] SGNL: Received shutdown request.
error displaying startup info: error querying remote node : rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: x509: certificate signed by unknown authority"
2021-05-16 13:18:35.837 [INF] SGNL: Shutting down...

Expected behavior
It connects successfully.

Actual behavior
2021-05-16 13:18:35.837 [INF] SGNL: Received shutdown request.
error displaying startup info: error querying remote node : rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: x509: certificate signed by unknown authority"

System information

Running Lightning Terminal standalone on Mac version 11.2.3.

lnd-mode=remote

LiT v0.41-alpha from https://github.com/lightninglabs/lightning-terminal/releases

You need to supply lnd's TLS certificate to LiT.
I'm not sure where exactly this is located in a btcpayserver setup. But you have to supply it in this config option:
remote.lnd.tlscertpath=/some/folder/with/lnd/data/tls.cert

I did that. In btcpayserver-docker, it's normally located in /var/lib/docker/volumes/generated_bitcoin_lnd/_data/chains/mainnet (or something like that). I scp'd that into my local machine and supplied it via the conig option.
I still get that error. :\ I also downloaded the tls.key thinking I needed, for some reason. Still nothing.

Ah, I just saw this now: btcpay.litservices.app:443. This doesn't seem to be the correct RPC address of lnd. It should be something with port 10009. You might have to open that port specifically on the docker container. I believe the 443 is the REST proxy (or the nginx reverse proxy).

I DO believe BTCPayServer exposes the GRPC on port 443 (which is totally odd for me, too).

I wonder if it has anything to do with the docker-compose setup on btcpay-docker.  It definitely IS odd to listen on 443.

Ah, you're right. The nginx reverse proxy listens on that port. So probably that just uses its own certificate that you have to specify instead of lnd's?

Ah, you're right. The nginx reverse proxy listens on that port. So probably that just uses its own certificate that you have to specify instead of lnd's?

This sounds right. I'll hunt down that cert, give that a shot and get back to you. Thanks!

Going to close this now as there hasn't been any updates. Based on the last comment, it appears there isn't anything here fr us to do on our end. @AryanJ-NYC feel free to reply if you are still facing this issue.


Add support for Spotless code formatting plugin and remove Checkstyle Plugin

Done in https://github.com/opensearch-project/asynchronous-search/pull/669


[DEVOPS-203] Convert travis jobs

Needs changes to .travis.yaml to replace run this on macos as well and to require all Nix builds (and disable others).

[ ] comment out haddock and open an issue on stack2nix to support that
[ ] remove the line passing --test and use recent stack2nix to pass --test to it

i think the travis failure is from master, i'll rebase tonight

https://hydra.iohk.io/build/12189/nixlog/9
i can confirm the problem is still happening on master

@cleverca22 this needs to modify .travis.yaml to remove the test Nix base build and to require stack2nix build to pass.


Runtime error when calling freeze_transformer_layers

System Info
PyTorch version: 2.2.0.dev20230911+cu118
CUDA used to build PyTorch: 11.8
Python version: 3.8.10 (default, May 26 2023, 14:05:08)  [GCC 9.4.0] (64-bit runtime)
GPU models and configuration:
GPU 0: NVIDIA GeForce RTX 2080 Ti
GPU 1: NVIDIA GeForce RTX 2080 Ti
GPU 2: NVIDIA GeForce RTX 2080 Ti
GPU 3: NVIDIA GeForce RTX 2080 Ti
Information

[X] The official example scripts
[ ] My own modified scripts

🐛 Describe the bug
When setting --freeze_layers, freeze_transformer_layers in train_utils.py would get called. The problem is that the function requires 2 parameters.
def freeze_transformer_layers(model, num_layer):
But the call in finetuning.py only provides 1 parameter, num_layer.
            freeze_transformer_layers(train_config.num_freeze_layers)
Error logs

Expected behavior
--freeze_layers would work again by adding model to the freeze_transformer_layers call:
            freeze_transformer_layers(model, train_config.num_freeze_layers)

Any update on this? Is it okay if I open a PR? Thanks so much!

Hi! Thanks for bring this up and I think the change has been made to address this here


feat: add openedge support

Language Server support for OpenEdge
Based on the VSCode plugin, everything should be ok in this first version.

I'll do the modification beginning of next week.


GitHub Action - Meetings - Not Working

Bug Report
Steps to Reproduce:

https://github.com/finos/architecture-as-code/actions/workflows/meetings.yml
Look at job history - I can't find an instance of it actually passing.

Expected Result:
From reading the GH action this is meant to actually capture who is attending the meetings and send this information to FINOS for their metrics.
Actual Result:
It appears to fail when checking out the metrics from Finos.
@karlmoll - is this something that we should have working ASAP? Do we have any capability to manually upload these metrics to FINOS in the interim?

@TheJuanAndOnly99 @maoo ^^

Hi @Thels @karlmoll this action is deprecated and can be removed. We moved from a push to a pull approach. The meeting information is being processed and published on GitLab.

Fantastic - I'll remove the action as a part of this issue and then will close it out.


Add Jq Agent

The Jq Agent allows you to process incoming Events with jq the JSON processor.
This Agent is not enabled by default because jq can cause infinite loop and is not suitable for public service.  It's just too powerful. 😢

CI failed only with Ruby 2.3, but the version series already reached EOL more than half a year ago and I'd rather drop support for Ruby 2.3 than fixing the code.
@dsander What do you think?

@dsander Sure, thanks!

Updating the manual seemed out of scope of this PR, so I'll cherry-pick the commit shortly.


fsprovider-sample/src/extension.ts - Windows Defender throws virus warning

After cloning the repo windows defender throws an virus warning according to the following file:
fsprovider-sample/src/extension.ts
https://www.microsoft.com/en-us/wdsi/threats/malware-encyclopedia-description?name=Backdoor%3APHP%2FDirtelti.OD&threatid=2147761327

Possibly needs a simlar fix as that applied to issue #104049 in the vscode repo

closing as upstream issue


Calculus Tutorial 3 (W2D5)

Interactive Demo 1.1: Slope of a Line
https://github.com/NeuromatchAcademy/precourse/tree/main//tutorials/W0D4_Calculus/solutions/W0D4_Tutorial3_Solution_a4085ae8.py
Interactive Demo 1.2: Euler error for a single step
https://github.com/NeuromatchAcademy/precourse/tree/main//tutorials/W0D4_Calculus/solutions/W0D4_Tutorial3_Solution_5348a4df.py
Think 3.1: Simple Euler solution
https://github.com/NeuromatchAcademy/precourse/tree/main//tutorials/W0D4_Calculus/solutions/W0D4_Tutorial3_Solution_5bbd8b66.py
Think 6.1: Discuss the plots
https://github.com/NeuromatchAcademy/precourse/tree/main//tutorials/W0D4_Calculus/solutions/W0D4_Tutorial3_Solution_0f722767.py
Think 3.3: Oscillations
https://github.com/NeuromatchAcademy/precourse/tree/main//tutorials/W0D4_Calculus/solutions/W0D4_Tutorial3_Solution_df2aee4c.py

Links updated


Add Quickstart Guide to the dropdown menu

That dropdown is hardcoded on the index page I believe

Looks like this has been fixed:

So, I think this issue can be closed.


Orion-ld crashes when clicking the add button

Dear colleagues, pressing the add button in this application crashes orion-ld

This is last that is present in log of orion-ld after it crash

Therefore, the application made a request which resulted in a crash.

A check in mongo showed that the entity to which the request was addressed does not exist.

This issue is solved with last commit.


boost iostreams fails to build - missing lzma.h in lzma.cpp file

Not sure what to do about it.
I don't need compression part of iostreams, but not sure if there's a way to disable it.
This is my cppan.yml:
local_settings:
    use_shared_libs: false

    dependencies:
        pvt.cppan.demo.boost.filesystem: 1.65
        pvt.cppan.demo.boost.test: 1.65
        pvt.cppan.demo.boost.iostreams: 1.65
        pvt.cppan.demo.microsoft.gsl: master

# your project settings
shared_only: true

Added lzma dep, thanks.
Authors added lzma support, but only zlib+bzip dependencies were present in cppan.
Optional dependencies support is not present in cppan v1 (current) and will be available in cppan v2.

Thanks for quick fix :)


After disconnecting, thread remains

Each time I connect / disconnect, I see a new thread hanging, waiting forever in the disconnectStream method.
I do see a 'socket did disconnect, error: Error Domain=JFRWebSocket Code=1000 "continue frame before a binary or text frame"' logmessage, so it should be disconnected and stopped?
It seems to block on [self.writeQueue waitUntilAllOperationsAreFinished], which has 1 pending operation.
Does anyone have an idea how to resolve this?

Upon further investigation; dequeueWrite adds an operation to the writeQueue, but if the operation catches an error, it calls doWriteError, which in turn calls disconnectStream. This then waits for the queue to finish all operations, but it's called from the queue, so it's waiting for itself?

Changing the call to disconnectStream in doWriteError to:
dispatch_async(self.queue,^{     [self disconnectStream:error]; });
Fixes it, but I'd rather leave the real fix up to you


Code cleanup and maintenance

Alrighty! Unless there's more discussion around inline(always), I think this is ready to go?
BTW sorry for continually adding more commits, I've kinda been using this a dumping ground :grin:.

Yeah, seems good to go. Thank you!

Woohoo, thanks!


Ignore interfaces matching pattern

Hi!
I see it's possible to ignore interfaces based on name with
docker exec vnstat vnstat -i br-20f8582bfc70 --remove --force

It would be cool if we could ignore based on a pattern.
docker exec vnstat vnstat -i veth* --remove --force

My usecase is that I'm using this on a system with podman and would like to ignore interfaces matching veth* (ignoring all container created interfaces) as these names are not static and are dynamically created.

Looks like issue transfer is indeed possible.


No link here, but maybe we can track this down....

This link sounds interesting, but I didn't see an actual repo or even URL. Perhaps there is enough information to search for it?
https://worldindustrialreporter.com/a-low-cost-easy-to-build-ventilator-for-covid-19-treatment/?adsrc_=article2

Dr. Read,
This is in reference to a recent publication on the device: https://erj.ersjournals.com/content/early/2020/04/16/13993003.00846-2020.figures-only


add plugin.toml for dokku 0.4.0 plugn compatibility

This PR adds dokku 0.4.0 support by adding a plugin.toml file.

@michaelshobbs @michaelshobbs @michaelshobbs @michaelshobbs

@u2mejc you'll want to also:

link the pluginhook to docker-args-build, docker-args-deploy, docker-args-run
update the readme instructions


Key A/B and key change M/VFO programmable/ assignable to other keys

Hi guys!
What an incredible work when looking through all the issues and requests!
I tried to program change VFO key (the red Exit/A/B) to another key and tried the # key (for changing from channel to freq mode) to program with a numerous key as well. If I have looked well enough I see that these keys cannot be programmed. Is that right? Could these two keys be added to the programmable keys or would that be not possible or too complicated?
Thanks so much anyway!

Hi Steef,
The functions you describe are triggered by a short press.
All keys are configurable except arrows, but for long press action.
For the moment we do not propose to modify the essential functions of the keys (short press).
I imagine that it would be technically possible but it would take up a lot of space in the memory compared to the interest it presents, and users would risk making their radio unusable by changing the behavior of the EXIT key for example.
Thanks for your interest !

Hi reppad,
Thanks for your clear explanation. I understand. Just trying to 'make' 890 as much as possible same keys as K5...
There is however 1 other important keys that has no short push if i'm right: i cannot findbandwidth to be programmed.
Would bandwidth be possible to program on a longpress (eg number) key ?

Yes, you can't change the bandwidth with a long press.
It's something we can do quite easily, I'm renaming this issue accordingly so that I or anyone else interested can do it.
Thanks for the suggestion!

@SteefW, @jcalado made your wish come true 💪


[Phase Feature] Basic Creative Menu

Added all Blocks into the Item Bar. this needs to be revisited once more blocks are implemented but as of rightnow it works


enable integration tests for restart

enable integrations tests for container restart.  fixed bug where --running was not being honored.
Signed-off-by: Brent Baude<EMAIL_ADDRESS>

Did you forget to enable the test?

Did you forget to enable the test?

fixed

LGTM other than one nit

LGTM once the nit is picked.

fixed up and ready for merge

/lgtm


Add support for Video Layers Allocation (VLA) RTP Header extension

https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/docs/native-code/rtp-hdrext/video-layers-allocation00/README.md?q=video-layers-allocation&ss=chromium%2Fchromium%2Fsrc

@xnorpx  can we close since https://github.com/algesten/str0m/pull/412 ?

Fixad by @pthatcher closing.


Tech Debt: have unit tests use DuckDB test fixture

With a local athena equivalent db available, we should be able to use it instead of mocked pyathena cursors, which would be a better test of actual behavior (although we will catch that with regression tests).
We should make a fixture to handle spinup/teardown, and then use that fixture in each test that currently uses a mocked DB curosr.

completed via #154


Reconcileclusterid

Affiliated with Issue 47
TLDR:
ClusterID getting exported to Cloud Map & getting propagated to endpoints as an CLUSTER_ID attribute
Description of changes:

Added the ClusterProperty CRD (from new group about.k8s.io)
In serviceexport_controller.go, we now watch for changes in the ClusterProperty attribute, and when there is a change, we reconcile all endpoints. This works for adding and removing of a ClusterProperty object.

This can be tested by kubectl apply -f config/samples/about_v1alpha1_clusterproperty.yaml (& delete)

Notes:

This is a minimal PR. No error handling introduced yet. No errors will be thrown yet for no ClusterID being defined other than when the service is being exported. No unit tests in this PR either.
Adding / removing the ClusterProperty (id.k8s.io) will add/remove the CLUSTER_ID attribute in the endpoint
In suite_test.go, changes needed to be made to not include the clusterproperty CRD for testing. Special tests will need to be constructed to manually add the annotation to be allowed to use '.k8s.io' suffix.

Testing:

manual testing of the controller
make kind-integration-suite runs without error

Codecov Report

Merging #165 (87b0dbf) into main (24c96f3) will decrease coverage by 1.23%.
The diff coverage is 24.32%.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   74.05%   72.81%   -1.24%
==========================================
  Files          15       15
  Lines        1453     1490      +37
==========================================
+ Hits         1076     1085       +9
- Misses        300      326      +26
- Partials       77       79       +2

Impacted Files
Coverage Δ

...ntrollers/multicluster/serviceexport_controller.go
37.69% <24.32%> (-2.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c96f3...87b0dbf. Read the comment docs.


Generate filenames automatically based on the code

It would be great if the extension offered the possibility to name files automatically based on the source code (also with respect to the language used: python, javascript, lua, etc as they would have different styles: camelCase, snake_case, etc)

Hi @younes-io
Do you have an example of how you would like this to work? Regarding coding style. This could be achieved by updating the prompt to ask for x standard. If you have any improvements in prompts, I would be extremely grateful.

bump @younes-io
Could you provide me with a brief description of how you think this should work?

Sorry for the delay.. I was just wondering if it's possible for the extension (in case of a new file) to propose a few names for it based on the code.. maybe this isn't required by many users, but the other day, I just had this new python file with a few functions, and I didn't know how to name it x) sometimes it's a bit hard to come up with a suitable file name

Hi @younes-io
Sorry for the delay. I've tried to implement this feature and it's not that straightforward. The naming works well for services and providers. But for utilities it often gives very long/verbose names which aren't suitable.
Unfortunately, I don't think I can create a reliable implementation.

@arbs-io: No worries. Do you use any library/tool that constrains the LLM? (the likes of guidance or LMQL)

LMQL looks really interesting. Currently the dependency is on the openai api spécification. This works for local models with the right host service.
In vscode the internals are js. So only wasm for python compilation or wasm for native LLM. I've been working on the latter recently. If this is achievable then should open up a lot more compatibility.


Expose APIs in DDS to convert back and forth between file paths and dart URIs

Currently we have many different tools all making educated guesses about how to convert between the paths. Worse, the heuristics about how to convert a file path to a dart uri differ for external and external workflows so this is a constant source of bugs.
DWDS can provide a custom implementation of this API for google3 web apps.
Suggested APIs to add to DDS. The APIs should take a list of paths as round trips can be a bottleneck when DDS clients are running on a different machine than DDS.
List<String> filePathsToDartUris(List<String> paths)
List<String> dartUrisToFilePaths(List<String> uris)

cc: @bkonyi @grouma

@terry

Need to fix  routine String displayAsPackage(String sourceName) in DevTools memory_controller.dart when mechanism exist.

This is likely the root cause of many breakpoint robustness issues we are seeing. Currently both VSCode and IntelliJ depend on hacks and the analysis server to map back and forth between file uris and packages. This causes breakpoints to be set on the wrong packages reducing user trust in breakpoints. For example:
https://b/issues/183216584

This functionality will almost certainly need to live in the VM service proper as we'd always need access to package_config.json to do this in DDS, whereas the VM will always have this information. Closing in favor of #46631.


KOGITO-7797: [DMN Designer] Improving "Import Java Classes" button's tooltip message

After this request (https://github.com/kiegroup/kie-tools/issues/1179), I decided to improve the tooltip message of the Import Java Classes button when the mandatory prerequisites are missing.
AFTER:

BEFORE:

To enable that, I simply fixed a circular methods call, which in that case results in an infinite loop

Hi @yesamer I tried to see the new message, I managed to make it show on greenfield dmn-quarkus-example with Language Support for Java by Red Hat installed and no @KieActivator annotation present.
On non greenfiled project I wasn't able to do it in some cases:

Removed Java extension -> message was the old one An error occured...
Removed KieActivator -> proper message.

So, it looks ok to me.


gimme-aws-creds does not honor Nike OKTA App timeout

Expected Behavior
My OKTA app had an expiration of 1 hour.  I then went through the process to increase it to 4 hours.  Now when I login to my AWS web console through OKTA, my session doesn't expire for 4 hours.
However, when I run gimme-aws-creds and select the same OKTA app, the duration is still set to the default of 1 hour.  So, I run 'gimme-aws-creds --configure' and set the following:  'AWS Default Session Duration [3600]: 14400'.  14400 seconds = 4 hours.  And then i run gimme-aws-creds again and select my OKTA app, and it throws this error message:  "The requested session duration was too long for this role.  Falling back to 1 hour."
So, gimme-aws-creds is not honoring the OKTA app expiration.
Current Behavior
Can only set session duration to 1 hour.  Setting to anything above 1 hour will cause it to throw the error "The requested session duration was too long for this role.  Falling back to 1 hour.".
Possible Solution
gimme-aws-creds should honor the session duration in the OKTA app.
Steps to Reproduce (for bugs)
Complete steps here:  https://confluence.nike.com/display/NSL/Requesting+4+hour+OKTA+timeout
Went through L1 and L2 levels to get specific AWS web console app expiration set to 4 hours.
Then tried authenticating with the app with gimme-aws-creds to get a 4-hour lease, but it fails with the error "The requested session duration was too long for this role.  Falling back to 1 hour.".
All details - such as application name and so on - can be found in the confluence link.  I do not want to expose any sensitive information in this issue request.
Context
So this is for an aws test account.  When i develop in the test account, it is wasteful to have such a short timeout.  And when it happens, i must go through the whole gimme-aws-creds spiel just to continue.  And if i have some sort of service running locally, then i must kill it and restart it.  Every single hour.  And if we take into account the 15-minute developer randomization rule and getting pulled "out of the zone", I waste 15 minutes every hour just re-authenticating to AWS via cli.  That adds up to a lot of lost time and money for the company.  So I feel it makes sense to fix this issue to reduce developer friction.
Your Environment

App Version used:  gimme-aws-creds 1.1.4
Environment name and version: bash
Operating System and version: OSX Mojave 10.14.3

@epierce I recall you running into something like this before with this project, any recollection?

well, when i ran into the issue, i got the okta web console access updated to support a 4-hour lease.  after, i tried using gimme-aws-creds, and the reproduced issue i found is what i posted here.  i think this is the same thing.

I think i found the issue.  The duration for a saml role is set in the "Maximum CLI/API session duration" field for the role.  So this does not seem to be a bug with gimme-aws-creds; its just that the okta web console authentication has different duration rules than the boto saml authentication duration.  the roles i'm using all have a max of 1 hour.  If i want to change that, then i would have to change it in the role itself.

@jaguth is there a work around for this issue?


USB OTG FS controller support on STM32F413 broken

Describe the bug
USB OTG FS controller support on STM32F413 broken because of latest changes on clock configuration.
git bisect: first bad commit: [c959b58bf15659628d2b64b1b38f5a89348d4db4]
drivers/clock_control: stm32 common: enable PLL_P/Q and set PLL_P div
Introduced by PR #47102
To Reproduce
build & flash any USB device support sample for nucleo_f413zh board.
My workaround:
diff --git a/drivers/clock_control/clock_stm32_ll_common.c b/drivers/clock_control/clock_stm32_ll_common.c
index b7e778e89e7..37916dcbd80 100644
--- a/drivers/clock_control/clock_stm32_ll_common.c
+++ b/drivers/clock_control/clock_stm32_ll_common.c
@@ -474,6 +474,10 @@ static void set_up_plls(void)
        RCC_PLLQ_ENABLE();
 #endif

+#if STM32_PLL_Q_ENABLED
+       MODIFY_REG(RCC->PLLCFGR, RCC_PLLCFGR_PLLQ, pllq(STM32_PLL_Q_DIVISOR));
+#endif
+
        config_pll_sysclock();

        /* Enable PLL */

I think that I get it.
The guilty code should actually be the last version
#if defined(STM32_SRC_PLL_Q) & STM32_PLL_Q_ENABLED
	MODIFY_REG(RCC->PLLCFGR, RCC_PLLCFGR_PLLQ, pllq(STM32_PLL_Q_DIVISOR));
	RCC_PLLQ_ENABLE();
#endif

And STM32_SRC_PLL_Q is not defined on F4 devices.
We might need to define all PLL outputs for SoC that don't support them today (F4/F7).

@erwango Has someone from st time to add the clock source defines and add alternate clock source support for the affected series?
I won't be able to do so this week(and also don't have access to a board of these series), but if not I could send a PR that just fixes the condition in the meantime.

I won't be able to do so this week(and also don't have access to a board of these series), but if not I could send a PR that just fixes the condition in the meantime.

@FRASTM will have a look

Thanks!


WIP  Allowing for grouped (random) transformations of tensors/tensor-like objects [proof-of-concept]

Implements a POC solution to #1406 (+ #9). Some aspects are similar to #1315.
I propose a GroupTransform class that can take a tuple of inputs, and applied the same transformation to each.
In between two queries of GroupTransform, the random transformations are 'frozen' (i.e. their random parameters are stored as attributes so that they can be re-used as much as needed) and the same transform is applied to each input. This ensures that all the transformations match exactly. When GroupTransform is done, it resets the state of the transformations that are provided to it.
e.g.
t = transforms.GroupTransform( transforms.RandomOrder( [
                             transforms.GaussianBlur(kernel_size=3, reset_auto=False),
                             transforms.RandomCrop(size=10, reset_auto=False)]}) ], reset_auto=False ) )
img = torch.arange(1024, dtype=torch.float).view(1, 32, 32).expand(3, 32, 32).contiguous()
mask = img[:1]
imgs = (img, mask)
imgs_out = t(imgs)
torch.testing.assert_close(imgs_out[0][0], imgs_out[1][0], rtol=1e-6, atol=1e-6, check_stride=False)

The reset_auto=False keyword of the transforms basically means that those objects won't be responsible of resetting their state after applying a transform. This responsibility is taken by transforms.GroupTransform (if its own reset_auto is set to True).
## Advantages

Low risk of BC issues as far as i can tell
few -- if any -- code changes from the users in most cases. Only those that may need GroupTransform will need to care about reset_auto.

Objects of probable contention

I implemented a parent Transform class that inherits from nn.Module, and all transforms are now subclasses of it. This may not be ideal and it is totally open to discussion.
Transforms are now 'stateful', and store the parameters of the transform in between execution.
Many get_params methods, that were static, have now lost that attribute (but one can override the default behaviour which is to take the stored parameters by providing other kwargs).

TODOs:

custom functions, such as those proposed in #1406 for tensor-like objects, should still be implemented. This will be the predominant way of ensuring that the transforms are applied in a meaningful manner (e.g. interpolation mode for images vs boxes) to each of the inputs, depending on their types.
this code heavily relies on the reset_auto attribute, that ensures that random transformations are applied similarly to each input. One could think of a way to set this attribute value after creating the object using a .reset_auto_(mode=True) method, but for now I feel that this isn't a priority, though it might make things easier to code in the future.
For now, compatibility with torchscript has been overlooked.
I did not change the helpers as of now, as i would prioritise the discussions about the feasibility of this solution.
Some more tests may be necessary

Do we consider this still WIP or it's superseded by the work at https://github.com/pmeier/torchvision-datasets-rework/pull/1?

Do we consider this still WIP or it's superseded by the work at pmeier/torchvision-datasets-rework#1?

let's suspend this for now!


DRILL-6612: Query fails with AssertionError when joining persistent a…

…nd temporary tables
For details please see DRILL-6612

+1, LGTM.

@arina-ielchiieva, thanks for the review!


Difference between Flax and JAX Stax

Hi, excited to see this set of NN functionalities! Could anyone introduce the major differences between Flax and JAX stax? Thanks!

stax, flax, and haiku - all JAX
@DarrenZhang01 my understanding is as follows:

stax is an experimental mini-library built with JAX for functional neural networks. This explains why it's in google/jax/experimental. Note that it says: "each mini-library is meant to be an inspiration, but not a prescription"
flax, on the other hand, is a "proper" neural network library, which has it's own repo - google/flax - as well as a separate docs site - flax.readthedocs.io.

Then there's haiku that's developed by some of the engineers behind DeepMind's Sonnet. Both Sonnet for TensorFlow and haiku for JAX help the folks at DeepMind run their experiments at scale ("Many users have found Sonnet to be a productive programming model in TensorFlow; Haiku enables the same experience in JAX"). See this full list of benefits. "Haiku builds on the programming model and APIs of Sonnet, a neural network library with near universal adoption at DeepMind".

Yeah, the major difference is that stax is a powerful but lightweight demo and builds layers by composition using combinators in 'point-free style'.
Flax tries to provide all the tooling needed to build and train NN models on JAX, from small models all the way to large distributed training runs on thousands of devices.  It tries to follow a more pythonic style that uses variable names and assignment to specify the DAG flow of data through the network rather than relying on combinator alchemy that tends to result in "write-only" code.

Thanks for the explanation, @8bitmp3  and @levskaya ! @levskaya , what does it mean by "write-only" code?

I believe  "write-only code" is a way of saying it's hard to understand - i.e. only the person who wrote it can understand and maintain it.

I see. Thanks!


Add Optimistic network

Block Explorer URL: https://optimistic.etherscan.io
chainId:  10
Native token symbol: OP
OP transfer tx sample: https://optimistic.etherscan.io/tx/0xf11be189d967831bb8a76656882eeeac944a799bd222acbd556f2156fdc02db4

Please try again - it had not yet been activated in the billing tab.

Please try again - it had not yet been activated in the billing tab.

Yeah thanks, it seems we not get that error anymore
@aminlatifi we just another problem I think it's because of data of my test cases, I commented those two test cases about verifying optimistic donations and pushed to staging, we can check it together later to find out the problem

when I donate to a project on optimism network and op token,  by  confirming Metamask transaction, I receive this error

plz check @mohammadranjbarz @MohammadPCh

Block Explorer URL: https://optimistic.etherscan.io
chainId:  10
Native token symbol: OP
OP transfer tx sample: https://optimistic.etherscan.io/tx/0xf11be189d967831bb8a76656882eeeac944a799bd222acbd556f2156fdc02db4

There is a mistake here, Optimism native token is ETH not OP
That would have caused issues.

Please try again - it had not yet been activated in the billing tab.

Yeah thanks, it seems we not get that error anymore
@aminlatifi we just another problem I think it's because of data of my test cases, I commented those two test cases about verifying optimistic donations and pushed to staging, we can check it together later to find out the problem

I am looking in this

Pushed this, I hope this fix the problem
f116c8e30cc4f065a4391c35ec1c0ac829e06411

when I donate to a project on optimism network and op token, by confirming Metamask transaction, I receive this error. but it is ok on Eth token(pic 2)

plz check @mohammadranjbarz @MohammadPCh

Now the result is as below:
optimism-- OP :
Donation failed

optimism -- Eth:
status is pending in donation list

Are  these reported bug ready for testing? @aminlatifi

Are these reported bug ready for testing? @aminlatifi

@maryjaf Yes, please test it

@MoeNick @maryjaf There is only one ETH transfer to that project and it's correctly shown in the donation tab
https://optimistic.etherscan.io/address/0x3d4ed3163db57359acd1a3eca09d75ccd4d0981e

ETH donations are still pending and the problem has not been resolved.

OP:
txHash
0xa6f0bd3f8c63cadecabb0ac53ae080283310ea2776bc8fc18bdcb8cd9440b8f3
https://serve.giveth.io/admin/resources/Donation/records/16411/show
https://giveth-dapps-v2-git-add-opt-for-test-givethio.vercel.app/project/test-optimism10001
ETH:
txHash
0x68861df585a879dbe52d4111b82cf6fdbdf088e78d31fc2bea0bee347d61e847
https://serve.giveth.io/admin/resources/Donation/records/16409/show
https://giveth-dapps-v2-git-add-opt-for-test-givethio.vercel.app/project/test-optimism10001
@mohammadranjbarz

This is the error we get when requesting to infura for verifying OP tokens
  status = 403, error= {"code": 32002,"message":"rejected due to project ID settings"}, url="https://optimism-mainnet.infura.io/v3/infuraKey

I searched and found this
https://docs.infura.io/infura/networks/ethereum/how-to/secure-a-project/use-an-allowlist
But I didn't  try to change anything in infura panel as I thought it's better to just one person be responsible for maintaining these kind of things to prevent further misunderstandings.
@MoeNick  @aminlatifi  @mhmdksh  @geleeroyale

ETH and OP donations are still pending @aminlatifi

Thanks,
this problem has been resolved


mupx Verifying deployment: FAILED after upgrading to Meteor 1.4

I have "deployCheckWaitTime": 600 and still fail deployment after upgrading to Meteor 1.4!
[<IP_ADDRESS>] x Verifying deployment: FAILED

-----------------------------------STDERR-----------------------------------
package.json<EMAIL_ADDRESS>No description
npm WARN package.json<EMAIL_ADDRESS>No repository field.
npm WARN package.json<EMAIL_ADDRESS>No README data
npm WARN cannot run in wd<EMAIL_ADDRESS>node npm-rebuild.js (wd=/bundle/bundle/programs/server)
=> Starting meteor app on port:80

assert.js:93
  throw new assert.AssertionError({
        ^
AssertionError: "undefined" === "function"
    at wrapPathFunction (/bundle/bundle/programs/server/mini-files.js:77:10)
    at Object.<anonymous> (/bundle/bundle/programs/server/mini-files.js:108:24)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/bundle/bundle/programs/server/boot.js:9:13)
    at Module._compile (module.js:456:26)

=> Redeploying previous version of the app

-----------------------------------STDOUT-----------------------------------

https://github.com/arunoda/meteor-up/issues/1091

Migrated to kadirahq/mup and dockerImage abernix/meteord:base to make this work.

@demiters I am using abernix/meteord:base too with mupx to get deployment to work. I had to edit the start.sh file mupx uses.
but I am just wondering @arunoda when mupx will be updated to use a compatible base image with the new meteor?

I have some error after moving to kadirahq/mup:

Error response from daemon: No such container: app-frontend
docker: Error response from daemon: driver failed programming external connectivity on endpoint app (3199bf831abd2ad4f74706ceac6db4f6ebc8da7a68597c9deab75b3dfc92422b): Bind for <IP_ADDRESS>:80 failed: port is already allocated.


Update yieldmo.md

Upgrading the documentation for yieldmo to reflect the modules we've implemented/

confirmed in adapter


Support apple m1

Now Electron v11 support Apple M1 ARM cpu on OSX is it possible to upgrade Mattermost version in order to get a native version of them on M1?

not right now, we have a policy of staying one version behind the current version of electron, to try and be as stable as we can.
We are also looking into adding some native modules to help with notifications in windows, which would prevent us from moving from v9.3.3 until a patch is added to allow building of windowsRT modules.
As far as I know, previous versions of electron work using the new Rosetta and I haven't seen any reports of trouble or low performance, but let us know if you have any cases that it is happening.
Eventually we will, get to v11 (when v12 is released, if the mentioned bug is corrected), so I'm closing this issue, but feel free to reopen if there is anything I missed.

not right now, we have a policy of staying one version behind the current version of electron, to try and be as stable as we can.
We are also looking into adding some native modules to help with notifications in windows, which would prevent us from moving from v9.3.3 until a patch is added to allow building of windowsRT modules.
As far as I know, previous versions of electron work using the new Rosetta and I haven't seen any reports of trouble or low performance, but let us know if you have any cases that it is happening.
Eventually we will, get to v11 (when v12 is released, if the mentioned bug is corrected), so I'm closing this issue, but feel free to reopen if there is anything I missed.

I confirm Intel version work through Rosetta 2.
But it's always better to use native program.
Anyway, thank you for your response.

I confirm Intel version work through Rosetta 2.
But it's always better to use native program.
Anyway, thank you for your response.

I confirm Intel version work through Rosetta 2.
But it's always better to use native program.
Anyway, thank you for your response.

I agree and we'll get there :)

I confirm Intel version work through Rosetta 2.
But it's always better to use native program.
Anyway, thank you for your response.

I agree and we'll get there :)