Issue with LoadPoint and VW e-Golf

Describe the bug
I cannot produce a proper config where I can configure a loadpoint with a VW e-Golf vehicle. The command "evcc vehicle" gives the correct output:
SoC:            40%
Charge status:  C
Capacity:       36kWh
Range:          97km
Finish time:    2021-06-07 02:39:00 +0000 UTC
Climate active: false
Outside temp:   21.5°C
Target temp:    22.0°C

But when I start evcc using command "evcc" it prints:
FATAL 2021/06/06 20:13:54 invalid vehicle: golf

My config:
...
vehicles:
- type: vw
  title: golf
  capacity: 36
  user<EMAIL_ADDRESS>  password: XXX
  vin: XXX
...
loadpoints:
- title: Carport # display name for UI
  charger: wallbe # charger
  vehicle: golf
  mode: pv
  soc:
    min: 0 # immediately charge to 0% regardless of mode unless "off" (disabled)
    target: 100 # always charge to 100%
    estimate: true # set true to interpolate between api updates
  onDisconnect: # set defaults when vehicle disconnects
    mode: pv # switch back to pv mode
    targetSoC: 100 # charge to 100%
  phases: 2 # ev phases (default 3)
  enable: # pv mode enable behavior
    delay: 1m # threshold must be exceeded for this long
    threshold: 0 # minimum export power (W). If zero, export must exceed minimum charge power to enable
  disable: # pv mode disable behavior
    delay: 10m # threshold must be exceeded for this long
    threshold: 200 # maximum import power (W)
  guardduration: 15m # switch charger contactor not more often than this (default 10m)
  mincurrent: 6 # minimum charge current (default 6A)
  maxcurrent: 16 # maximum charge current (default 16A)

To Reproduce
Use the config like above
Expected behavior
I would expect when the "evcc vehicle" command is successful the "evcc" command should run without error.
EVCC details:
Show output of evcc -v:
evcc version 0.56 (cad5996)

Show output of evcc dump -c configfile:
```
[main  ] INFO 2021/06/06 20:29:30 evcc 0.56 (cad5996)
[main  ] INFO 2021/06/06 20:29:30 using config file /evcc/evcc.yaml
[mqtt  ] INFO 2021/06/06 20:29:30 connecting evcc-1336045532 at XXX:1883
[mqtt  ] DEBUG 2021/06/06 20:29:30 XXX:1883 connected
[main  ] FATAL 2021/06/06 20:29:32 invalid vehicle: golf
```

Show evcc configuration file evcc.yaml:
```
uri: <IP_ADDRESS>:7070 # uri for ui
interval: 10s # control cycle interval
sponsor token enables optional features (request at https://cloud.evcc.io)
sponsortoken:
log settings
log: debug
levels:
core: debug
lp-1: debug
lp-2: debug
meter definitions
name can be freely chosen and is used as reference when assigning meters to site and loadpoints
for examples see https://github.com/andig/evcc-config#meters
meters:

name: grid
type: modbus
uri: XXX:502
id: 71
name: pv
type: modbus
uri: XXX:1502
id: 71
name: battery
type: modbus
uri: XXX:1502
id: 71
power: 802:W
soc: 802:SoC

charger definitions
name can be freely chosen and is used as reference when assigning charger to vehicle
for examples see https://github.com/andig/evcc-config#chargers
chargers:

name: wallbe
type: wallbe # Wallbe charger
uri: XXX:502 # ModBus address

vehicle definitions
name can be freely chosen and is used as reference when assigning vehicle to loadpoint
for examples see https://github.com/andig/evcc-config#vehicles
vehicles:

type: vw
title: golf
capacity: 36
user<EMAIL_ADDRESS>password: XXX
vin: XXX

site describes the EVU connection, PV and home battery
site:
title: Home # display name for UI
meters:
grid: grid # grid meter
pv: pv # pv meter
battery: battery # battery meter
prioritySoC: 60 # give home battery priority up to this soc (0 to disable)
loadpoint describes the charger, charge meter and connected vehicle
loadpoints:

title: Carport # display name for UI
charger: wallbe # charger
vehicle: golf
mode: pv
soc:
min: 0 # immediately charge to 0% regardless of mode unless "off" (disabled)
target: 100 # always charge to 100%
estimate: true # set true to interpolate between api updates
onDisconnect: # set defaults when vehicle disconnects
mode: pv # switch back to pv mode
targetSoC: 100 # charge to 100%
phases: 2 # ev phases (default 3)
enable: # pv mode enable behavior
delay: 1m # threshold must be exceeded for this long
threshold: 0 # minimum export power (W). If zero, export must exceed minimum charge power to enable
disable: # pv mode disable behavior
delay: 10m # threshold must be exceeded for this long
threshold: 200 # maximum import power (W)
guardduration: 15m # switch charger contactor not more often than this (default 10m)
mincurrent: 6 # minimum charge current (default 6A)
maxcurrent: 16 # maximum charge current (default 16A)

mqtt message broker
mqtt:
broker: 192.168.1.XXX:1883
topic: evcc # root topic for publishing, set empty to disable
user: mqtt
password: XXX
influx database
influx:
url: http://localhost:8086
database: evcc
user:
password:
push messages
messaging:
events:
start: # charge start event
title: Charge started
msg: Started charging in "${mode}" mode
stop: # charge stop event
title: Charge finished
msg: Finished charging ${chargedEnergy:%.1fk}kWh in ${chargeDuration}.
connect: # vehicle connect event
title: Car connected
msg: "Car connected at ${pvPower:%.1fk}kW PV"
disconnect: # vehicle connected event
title: Car disconnected
msg: Car disconnected after ${connectedDuration}
services:
- type: pushover
app: # app id
recipients:
- # list of recipient ids
- type: telegram
token: # bot id
chats:
- # list of chat ids
- type: email
uri: smtp://:@:/?fromAddress=&toAddresses=

Show evcc log output with --log trace:

<- paste here

bitte name: golf


Fix warning in clog.c about ignoring return value of ‘write’

Dozens of warnings in clog.c:
[  2%] Linking CXX shared library libonnxruntime_providers_shared.so
/home/wtambellini/repos/onnxruntime/cmake/external/pytorch_cpuinfo/deps/clog/src/clog.c:112:4: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
    write(STDERR_FILENO, out_buffer, prefix_chars + format_chars + CLOG_SUFFIX_LENGTH);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/wtambellini/repos/onnxruntime/cmake/external/pytorch_cpuinfo/deps/clog/src/clog.c: In function ‘clog_vlog_error’:
/home/wtambellini/repos/onnxruntime/cmake/external/pytorch_cpuinfo/deps/clog/src/clog.c:188:4: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
    write(STDERR_FILENO, out_buffer, prefix_chars + format_chars + CLOG_SUFFIX_LENGTH);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/wtambellini/repos/onnxruntime/cmake/external/pytorch_cpuinfo/deps/clog/src/clog.c: In function ‘clog_vlog_warning’:
/home/wtambellini/repos/onnxruntime/cmake/external/pytorch_cpuinfo/deps/clog/src/clog.c:264:4: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
    write(STDERR_FILENO, out_buffer, prefix_chars + format_chars + CLOG_SUFFIX_LENGTH);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/wtambellini/repos/onnxruntime/cmake/external/pytorch_cpuinfo/deps/clog/src/clog.c: In function ‘clog_vlog_info’:
/home/wtambellini/repos/onnxruntime/cmake/external/pytorch_cpuinfo/deps/clog/src/clog.c:340:4: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result]
    write(STDOUT_FILENO, out_buffer, prefix_chars + format_chars + CLOG_SUFFIX_LENGTH);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
....

line 112
https://github.com/pytorch/cpuinfo/blob/728f3e909fa5c57e0123c4658e234f6b1941385d/deps/clog/src/clog.c#L112
write() indeed returns a size_t :
https://linux.die.net/man/2/write
Would you mind if I add a check ? eg:
ssize_t rv =  write(STDOUT_FILENO, out_buffer, prefix_chars + format_chars + CLOG_SUFFIX_LENGTH);
asert(rv != -1);

It would be good to suppress the warning, but assert is not the right way to do it. assert may crash the whole program because of failed logging write.

Hi @Maratyszcza
Sure, what about logging (warning ?error ?) if the rv == -1 ?

rv == -1 indicates that we've had an error during logging. I don't expect anything good attempting to log the error about the logging error. The best option IMO is to ignore the error, and silence the compiler warning about it.

Well, totally ignoring write() errors would make debugging even harder but nevermind.
So would you accept a PR if I add
target_compile_options(... "-Wno-unused-result")
to the main CMakeList.txt, only for gcc builds ?

Fixed in #129


allow full access doesn't show

For some reason after i made the project from scratch and use all the codes here allow full access is not in settings from the keyboard.

Is RequestsOpenAccess set to YES in your Info.plist?


openra: Fixed a typo and the website URL changed.

Just some small formal changes. I don't know anything about your package format, but you may want to use the install rules from the Makefile:
make prefix=$out install-all
make prefix=$out install-linux-shortcuts
make prefix=$out install-linux-mime
make prefix=$out install-linux-appdata
make prefix=$out install-man-page

Thanks for the fixes and your work on OpenRA! :beers:
I took the liberty to change the commit message according to our policy.


Fix installing outdated dependencies on init

checkProjectDependencies should be called before deppack's init.
Closes #1636.
Thanks @lydell.

try reducing the merge remote tracking branch commits in the future.


fix: address bug in update gallery script

Closes #5423
This change fixes a bug in the example gallery update script. It previously attempted to call fs.fmSync which does not exist rather than fs.rmSync as intended.
What did you change?
scripts/example-gallery-builder/update-example/index.js

How did you test and verify your work?
Applied this change and was able to successfully run yarn update-gallery-config which failed previously

Credit goes to @elycheea! 🥳


RedisStoreProxy support connection pool

How nothing happened?

@ktheory ktheory

Hi @tumayun: I have not had a chance to review this yet.
Could you please add a description to this Pull Request explaining what feature it's adding, and why it's useful?

Hi @ktheory
Redis supports connection pool.


There is no error message in the 'Clone and Rehydrate' dialog when the blob container contains a blob with a same name as the destination blob

Storage Explorer Version: 1.30.0-dev
Build Number: 20230531.3
Branch: main
Platform/OS: Windows 10/MacOS Ventura 13.4 (Apple M1 Pro)
Architecture: x64/arm64
How Found: From running test cases
Regression From: Previous release (1.29.2)
Steps to Reproduce

Expand one storage account -> Blob Containers.
Create a blob container -> Upload two blobs.
Change one blob's access tier to Archive.
Right click the archived blob -> Click 'Clone and Rehydrate...'.
Type another blob container name to 'Destination blob name' field.
Check whether there is an error message indicating the same name already exists.

Expected Experience
There is an error message.

Actual Experience
There is no error message.

Additional Context

This issue reproduces inconsistently, try to reproduce this issue on mac, it reproduces seven times out of ten.
We can't reproduce this issue on Linux.
Here is the log collected on mac:
2023-05-31_105813.zip

Verified this issue on the build 20230601.3. Fixed. So, we are going to close it.

This issue reproduces on 1.31.0 version and the main build 20230810.9. So, we are going to re-open it


Replace go-kit logger with std lib log package

Fixes #68

Thanks @meling . I'll have a look tomorrow evening on this.

Done as part of https://github.com/migueleliasweb/go-github-mock/pull/75

Thanks for the contribution!


Common code in netebpfext.sys should be refactor for reusability

The netebpfext.sys driver contains a lot of common code that makes writing eBPF extension drivers simpler.
This code should be refactored and be made available to other driver developers.
Possible options:

Export Driver
Static library
A git submodule

An export driver is probably the most useful as it would allow a single version of the code to be patched once if there was a bug.

List all files in https://github.com/microsoft/ntosebpfext/tree/main/ntosebpfext
Total LOC - 3371
Code that is specific to this extension - 435
$ pwd
/e/ntosebpfext/ntosebpfext
$ git ls-files | xargs cat | wc -l
3371
$ cat ntos_ebpf_ext_process.c  | wc -l
413
$ cat ntos_ebpf_ext_process.h  | wc -l
22

87% of this driver code is boiler plate.

FWIW, the XDP boilerplate that seems trivially submodule-able is in https://github.com/microsoft/xdp-for-windows/blob/main/src/xdp/ebpfextension.c. This was derived from the netebpfext codebase, but is subtly different.


🌐 Update Traditional Chinese translation for docs/zh-hant/docs/deployment/index.md

The reason for this update
The rendering issue was fixed in #12509, so I deleted the space before and after the asterisks around Traditional Chinese.

Thank you! @codingjenny :rocket:


Block domain stellarcenter.org

Domain: stellarcenter.org
Requested by @usser0134

.

@usser0134
Thank your ofr your help. I'm working on the  most recent scams minted and then trying to catch up a little with these older ones. Keep up the good work.
Plus when I review these older ones it usually leads to others quite easily.


Fixed KUBECONFIG path issue

Sorry. My bad. This line should be just removed

ok, I will remove it.

Thanks


fix bin entry

Overview
refers to older dist/question-and-answer-cli.js, should be dist/question-and-answer-exec.js

Work for this issue will begin begin on branch work-liquid-labs/question-and-answer/73.


.hydra folder not created , but why?

💡 Your Question
I don't know why but when I want to start training from the last checkpoint based on what is in here: https://github.com/Deci-AI/super-gradients/blob/b4eec926261e9e8f3032d8fb51977af33b85ec3c/src/super_gradients/common/environment/omegaconf_utils.py#L74
I get the error: File Error: does not include .hydra artifacts to resume the experiment.
two questions :

why not this thing not created when I started training?
is there any way that I can resume training without this folder included in the solution?
NOTE: I need the exact Python code to resume it not the CLI command

thanks a lot for developing the fastest Yolo model in history :)
Versions
No response

Hey @prankshtain , the hydra output directory is created when training with configs (otherwise it does not make much sense, since instantiated objects instead of configs can be passed too).
If you did train_with_configs, the .hydra directory should be under your <CHECKPOINTS_DIR>/<EXPERIMENT_NAME>.
Can you elaborate if what is the situation?

Hey @prankshtain
Thanks for opening an issue for SG. I'm gathering some feedback on SuperGradients and YOLO-NAS.
Would you be down for a quick call to chat about your experience?
If a call doesn't work for you, no worries. I've got a short survey you could fill out: https://bit.ly/sgyn-feedback.
I know you’re super busy, but your input will help us shape the direction of SuperGradients and make it as useful as possible for you.
I appreciate your time and feedback. Let me know what works for you.
Cheers,
Harpreet

Closing as stale


Detect DB downgrades

We should detect accidental downgrades and exit early, we'll fail to decode DB contents at some point anyway.

Wait, we do that, my debugging went into the wrong direction.
https://github.com/fedimint/fedimint/blob/a888a97f6e883eed2c8381093d623e00b7495d89/fedimint-core/src/db/mod.rs#L2020-L2024


Unable to register multiple Reference codecs in RedissonClient

In Redisson 3.15.2, getReferenceCodecProvider() was removed from RedissonObjectBuilder.java.
This breaks code that adds a reference codec with the RedissonObjectBuilder, for example:
redisson.getCommandExecutor().getObjectBuilder().getReferenceCodecProvider().registerCodec((Class) <MyClass.getClass(), myClassTypedCodec);
RedissonObjectBuilder now only allows registration of the single codec set on the Redisson Config object.
Is there an alternative way to add another reference codec?  We need to use JsonJacksonCodec by default for references, but have a sub class that needs to use TypedJsonJacksonCodec.

What is the 'it' that is defined as a parameter o f REntity annotation.
We are setting a default codec for all objects:
    Config config = Config.fromJSON(new File(redisConfigFilePath));
    config.setCodec(new JsonJacksonCodec(JsonUtil.getMapper()));

This works for all objects except where we have a map of references to maps of objects whose values need to use TypedJsonJacksonCodec.  For this we were registering a TypedJsonJacksonCodec for the specified class of the values of the secondary maps.
Are you saying use a subclass of TypedJsonJacksonCodec instead of JsonJacksonCodec as codec for all objects, even those that don't use 'type' instead of 'class'?  How would be new codec class be annotated to use 'class' for all objects except for the one that uses 'type'.

@padarlin
TypedJsonJacksonCodec doesn't have default constructor so it can't be used


test-branch/execute-job/wrong-comment-on-pr/b14073f6-2e3f-4394-bb46-23e0c113c79d

PR for testing e53afc820c7baba6177dcdb3c1aa664a048248c3

comment 1


Add reader sketch

Just an idea, there is a way to avoid channels and the like, but this introduces the least amount of changes while still riding the same broker implementation.

This does give convenience if you, say, want to use io.Copy, but I still wonder how applicable this is to our known use cases. For the chunked encoding, we could do just copy, but then we'd miss the heartbeats. For Server-Sent Events, I think pushes are definitely better than polling. It seems we'd end up having a lot more code without any cleaner usage. Perhaps you can spike the intended usage to demonstrate that it would be cleaner?

Yes I can add to this spike a short intended usage.
For the heartbeats was thinking of creating a KeepAliveReader of sort to abstract that part, which can accept the null byte (and we provide :keepalive in the case of an event-stream request).

I'll leave this open for now but I'm tempted to just close it :-)


Pull from a private Github repo

After a (little) bit of poking around, I can't find a way to have a self-hosted instance of rtd pull and build from a private Github repo. Is it currently possible? Have there been any discussions about implementing support for private repos?

I should point out I mean a self-hosted instance of rtd, not readthedocs.org

https://github.com/rtfd/readthedocs.org/blob/master/readthedocs/projects/forms.py#L63
It's done so the main site doesn't have people trying to do this, where it isn't possible for us to check it out. If you want to make this a setting or something, feel free and submit a pull request.


auro-card dev blueprint

General Support Request

After discussion about the card blueprint, developers decided to move towards a simpler solution. The blueprint needs to be edited to accommodate this request.
Requirements

[ ] Outline 4 slots: image, header, content, CTA
[ ] Anatomy
[ ] Variants
[ ] Spacing

Blueprint is done, but not yet on the doc site.
With the impending refactor of the component, we will need to create a new issue to rebuild the blueprint and publish to the doc site.


Please use category "Programming Languages" rather than "Language Packs"

Category "Language Packs" is for display language extensions (ex. German, Bulgarian). Extensions which contribute general programming language features (syntax highlighting, code completions) should use "Programming Languages"

Looks like the Marketplace is adding categories "Other" and "Language Packs" automatically. I would recommend adding the sections below to your package.json
"categories": [ "Programming Languages", "Snippets" ],

Thanks. Fixed in 2.6.5.


refactor(code): Rescan functionality

Signed-off-by: Harsh Thakur<EMAIL_ADDRESS>Pull Request template
Why is this PR required? What issue does it fix?:
This PR exposes the method which is used to sync etcd and ndm local state
What this PR does?:
Exposes rescan method which helps to sync etcd and ndm local state. It also ensures that the udev method being called is thread safe.
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
Tested it on a GKE cluster.
Any additional information for your reviewer? :
This is required for the gRPC PR.
Checklist:

[ ] Fixes #
[x] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Codecov Report

Merging #455 into master will decrease coverage by 0.03%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   43.48%   43.44%   -0.04%
==========================================
  Files          61       61
  Lines        2969     2974       +5
==========================================
+ Hits         1291     1292       +1
- Misses       1576     1579       +3
- Partials      102      103       +1

Impacted Files
Coverage Δ

cmd/ndm_daemonset/probe/eventhandler.go
12.24% <0.00%> (-0.13%)
:arrow_down:

cmd/ndm_daemonset/probe/udevprobe.go
62.75% <33.33%> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 017b755...691c712. Read the comment docs.


Document need to add analytics snippet

I'm unclear about whether I still need to add the analytics snippet to the footer of my page. Presumably I do, otherwise this plugin works like magic.

You do :) I'll document it.


GIF won't auto play on iOS after upgrading to 6.0

Describe the bug
GIFs won't auto play. Since SDWebImage 5.0, it introduced a new way to render animated images, as described here, and removed FLAnimatedImage support. And SDAnimatedImageView implemented its own setImage which is overridden in RNFastImage.
I don't know much about Objective-C, it's hard for me to submit a PR... We may have to use the new SDAnimatedImage subclass along with SDAnimatedImageView to make GIFs auto play. Or we can use SDWebImageFLPlugin with UIImageView to continue using FLAnimatedImage (but maybe won't benefit from SD's new improvements).
Expected behavior
GIFs auto play.
Dependency versions

React Native version: 0.59.9
React version: 16.8.6
React Native Fast Image version: 16.1.0

Same problem here

@tberman This is the issue.


Plan for rewrite cgrad in rust.

May be freezed due to being occupied with school classes.

Plan reopened.

Done with the task via rsgrad


GUI interface?

So, if people want to move to immich or other apps, this tool is really good to export photos. Unfortunately it's not graphical.
Could you introduce a little python-based GUI to automate in a few click all the required steps?
That would be huge for the general public

https://github.com/immich-app/immich/pull/9804
I started work on automating imports immich. But it's probably going to take some time for the team to approve it. I've been discussing with them on discord how we want it to function in the end.


Added Chart for TensorFlow Lite Support

Adds an initialy commit of the TFlite operation support. Focuses on purely general support,
future plans should generate tests per backend.

Nice, should we add a comment about static vs dynamic? (I think static shapes the checkmark means fully, but for dynamic it could mean partial - or am I thinking of backends already?)


Feature: Wallet estimated value

Is your feature request related to a problem? Please describe.
New DEX misses the Estimated Value displayed in old Dex Wallet page
Describe the solution you'd like
Add this information to new DEX

Merged into develop


"Delete all" in form builder is not working

"Delete all" in form builder is not working

tahnks @esuarezz fixed it :) if you find this lib useful please consider to leave a star at react-hook-form and support the lib :) thank you


ARROW-7403: [C++][JSON] Enable Rapidjson on Arm64 Neon

Rapidjson supports Arm64 Neon, but it's not enabled in Arrow now. We need to define macro RAPIDJSON_NEON to build Rapidjson with Neon support.

+1, merged.


Language Server - Locations

Finally starts introducing LSP4J into all this.

@heeheehee-kolmafia even though it's not ready yet (more commits incoming, on top of waiting for the transition to Gradle), I'd invite you to follow along, as this will end up modifying (although lightly) most classes in parsetree.
(The first "true" commit of this branch is the 6th one. I... I thought I had pulled from upstream/main before starting this PR... turns out I hadn't.)

This is where we need to start looking at doing two builds no? For dev build and regular build

Possibly. I talked to @fredg1 about this and we deemed that it didn't increase the jar size by that much with the exclusion of xtend (~1.2MB iirc, compared to 4.5 MB by default), and it's complicated to untangle these changes without duplicating the classes in question.
He also mentioned envisioning using the language server integration to help debug scripts during normal Mafia execution, which seems worthwhile to me. I think that's a broader discussion worth having (or at least mentioning!) in public.
(That said, it's a bit of a shame to require a 1.2MB jar increase for a handful of data classes that amount to a file location and, like, four ints.)

(You don't have to push every change as you make it! You can always amend commits, or squash them, or whatever once you've decided that's a unit of work you're happy sharing. Or work in a separate branch, then merge things into this one.)

(You don't have to push every change as you make it! You can always amend commits, or squash them, or whatever once you've decided that's a unit of work you're happy sharing. Or work in a separate branch, then merge things into this one.)

that's not really it.
I'm basing myself off of my working copy, at https://github.com/fredg1/kolmafia/pull/8.
However, due to the commit history change, it's harder to move the changes over...
I currently copy-pasted the Parser file over the Location branch, and have been pruning and cherry-picking the changes manually since yesterday

Have you considered rebasing that branch?

Have you considered rebasing that branch?

The commit history issue is specifically what prevents the rebasing, sadly

I ran
$ git rebase -X ours --onto e6f30ead08076fe164bbb7f964debf14038b3c9e f46a606f2b5a6609c7c67424423dd1375499bb6c Language-Server

and then pushed to https://github.com/heeheehee-kolmafia/kolmafia/commits/Language-Server

The rebase did some weird things, but that's broadly the kind of rebase I had in mind when I suggested it. You should be able to graft two disjoint histories together.

Attempt 2 with replacing refs seems to have worked better, although the code at the head of that repo is broken.
(And as noted elsewhere, you'll need to deal with merge conflicts in formatting. Now you can use Google Java Style and not have to deal with this by hand, hooray.)

Have you considered rebasing that branch?

The commit history issue is specifically what prevents the rebasing, sadly

The instructions I gave on the PR do work! I did it to multiple branches. And remember, this codebase is formed by grafting two completely unrelated repos

guess this just shows how uneducated I am about git...

guess this just shows how uneducated I am about git...

you could do something like
git replace --graft $YOUR_EARLIEST_COMMIT $PARENT_YOU_WANT_YOUR_COMMIT_TO_HAVE

Then you might need to do something like
git filter-repo --replace-refs update-no-add --force

But I think that requires installing an extra thing

why aren't the tests running?

Can you merge with head again? I made some changes to the github action in question to run gradle check instead of gradle test (to enforce formatting).

But that's so many meeeeerge confliiiiiicts ;-;

then cherry-pick e78a9f7771b1f0f6ab091e16efc517c4154a970a

@heeheehee-kolmafia I'm getting a weird issue when launching tests (which I do because I'm trying to generate a coverage report).
When calling gradlew from the command line, the tests 1,2,4,5,6,7,8 and 10 of CustomScriptTest fail (meaning tests 3, 9 and 11 pass).
However, when launching the tests from VScode, it's backwards. Tests 3, 9 and 11 fail, with the rest passing (there's also 8, which is test_evilometer, but I think I remember it having an issue since I applied spotless/pulled and merged from upstream)

Indeed, VScode seems to tell me that 3, 9 and 11 (get_player.js.out, test_location_id.ash.out and test_test.ash.out) use LFs, while all the others use CRLFs

Looking further, this instead seems to be because of the PrintStream that we are writing "Actual" to.
PrintStream.println(String) calls Writer.newline() or BufferedWriter.newline(), both of which add a line ending dependent on the current file system.

Do you have 163000fb44a4b89ccea836cb9635593177e2b17e?
Prior to that change, when checking out a repo, git would use your system's line endings, but with it, it will enforce LF for newlines across test/.
Simplest way to fix that is rm -rf test/root && git reset --hard

Do you have 163000f?
Prior to that change, when checking out a repo, git would use your system's line endings, but with it, it will enforce LF for newlines across test/.
Simplest way to fix that is rm -rf test/root && git reset --hard (but make sure you don't have any pending changes, e.g. by running git stash first)

That did it, thanks. I was wondering why most files still seemed to be using CRLF even though it was supposed to have been replaced.

AscensionHistoryRequestTest > parseAscensionHistory() FAILED
org.opentest4j.AssertionFailedError at AscensionHistoryRequestTest.java:38
Seriously, this test keeps failing

The main thing I'd like to see that's missing from this PR is testing.
And, I'd like to remind you that it takes time to work through a thousand-line diff sprinkled across 50 files, to make sure that all the code is correct, reasonably efficient, etc. I get that you're eager to move on to the next phase of this project, but you can't rush these things.
(If you want the review to go faster, then split out changes, or refactor the code such that the changes here are more uniform and therefore easier to review.)

Aren't you generalizing a bit? :(

I didn't make any general statements so no I'm not generalising. If you're saying "I'm only rude some of the time but not all of the time" the I would ask that you be rude none of the time instead.

@gausie Thanks for chiming in. I can take it from here.
@fredg1 In general, I find it helpful to take a step back to see how I'm coming across. You might find value in doing the same. I don't think you're being rude on purpose, but this is a pattern of behavior that has alienated several members of the development team.
As mentioned, the repeated complaints about the flaky tests are unhelpful and passive aggressive. We've already pointed out that we're aware of this issue and are trying to figure out how to address it more generally; doing so is all the more challenging because some of the failures only reproduce consistently on specific operating systems.
You've directly requested my input on a few occasions, and as I've mentioned, it's a big lift to review this PR due to its size, and quite frankly, it's not fun to pore over the code trying to understand what you're doing and why, especially if it changes frequently. I get that you want some direction to avoid wasting time on another effort of unclear benefit, but again, this process takes time, and it's not like I've forgotten about the PR for a week.
I've also mentioned before that it's often helpful to curate your changes before sending them out for review, such that they're small (or at least uniform), focused, and thoroughly tested, as this helps speed up the review process.
Regarding splitting Line / Token out of Parser: yes, I recognize the desire for compiler enforcement that they can only be instantiated by a Parser, but that's also problematic for testability (you can only indirectly measure behavior), not to mention that Parser.java is already incredibly unwieldy, and this change adds another 300 lines to a 4000-line file.

Have I not been somewhat successful at doing this for the latest commits? I tried, so knowing if it worked or not would help...

It's an improvement over the initial patches that you sent several months back, but this is still a commit with a delta of >1k lines of code across 60+ commits, with no tests.
For instance, that commit you just pushed to move Line / Token out of Parser? That's something that could easily be a standalone, unit-tested PR.

@heeheehee-kolmafia please see https://github.com/fredg1/kolmafia/pull/17 (did the notification from over there work? I don't know if it's just a reference or if it actually notifies the referenced user...)

This is the PR that will be used to convey the rest of the Location changes.
Notes:
1- Is it possible to remove Heeheehee's request for review? (where is he, btw? Haven't seen him in a while)
2- "why is there a 'makeZeroWidthLocation()'? Shouldn't that have been in https://github.com/kolmafia/kolmafia/pull/239 ?

There was a change at the last minute. I originally planned to have that value hold the location of the previous value seen, but... bad idea.
3- You're not actually testing the location of the VariableReference made in parseEvaluable/parsePostCall
This is because the value isn't accessible. The only thing I could do was show that its start was propagated into the following CompositeReference.

Why do we have Location makeZeroWidthLocation() instead of just having a Location makeLocation() overload that does that (with appropriate jsdoc)?

Why do we have Location makeZeroWidthLocation() instead of just having a Location makeLocation() overload that does that (with appropriate jsdoc)?

The contract of Position, Range and Location is that the empty constructor makes a new instance with none of the fields instantiated (still null).
I wanted to make sure there would be no association with this contract.

Why do we have Location makeZeroWidthLocation() instead of just having a Location makeLocation() overload that does that (with appropriate jsdoc)?

The contract of Position, Range and Location is that the empty constructor makes a new instance with none of the fields instantiated (still null). I wanted to make sure there would be no association with this contract.

This isn't convincing to me, but I'm glad at least that this is an intentional decision.

There are still loads more .getLocation() that can be removed

There are still loads more .getLocation() that can be removed

you mean?

Look at the diff for this PR and for each time the string .getLocation() appears ask yourself "does this need to be here or can I use the new Command overload. Unless my diff is stuck and hasn't updated, the answer is yes at least once.

Could you... please point out where? Because I really don't see it. :(

By well-tested, I mean tests that go beyond just exercising lines of code, but actually check that all the things that you're doing are happening correctly.
The test changes you've added in this change only exercise making Token extend Range (which means each Token now has a Position, among other things).
A partial list of what I'd like to see:

One PR that splits Line / Token / Comment into a separate file, adding tests for each of the public methods of those classes.
One PR that makes Token extend Range, with the tests you have today.
Some number of PRs that actually check that the Locations you're adding to these ParseTreeNodes are as expected. As mentioned, it would be easier to do so if those methods were more visible and returned well-defined values, but I do not think it's appropriate for them to be public methods of Parser.

Above are the changes requested by he3.  If I am told they have been addressed, I will make the "awaiting changes" status go away, one way or the other.
Alternatively I can close this without committing anything to main.
I just need to know what works for @fredg1

By well-tested, I mean tests that go beyond just exercising lines of code, but actually check that all the things that you're doing are happening correctly.
The test changes you've added in this change only exercise making Token extend Range (which means each Token now has a Position, among other things).
A partial list of what I'd like to see:

One PR that splits Line / Token / Comment into a separate file, adding tests for each of the public methods of those classes.
One PR that makes Token extend Range, with the tests you have today.
Some number of PRs that actually check that the Locations you're adding to these ParseTreeNodes are as expected. As mentioned, it would be easier to do so if those methods were more visible and returned well-defined values, but I do not think it's appropriate for them to be public methods of Parser.

Above are the changes requested by he3. If I am told they have been addressed, I will make the "awaiting changes" status go away, one way or the other.
Alternatively I can close this without committing anything to main.
I just need to know what works for @fredg1

Don't close this plz
I'm using this as the PR that encompasses the "final" location changes (i.e. all those that can't be committed on their own because they could result in NullPointerExceptions happening)

@gausie  please... :(

Never ever do that
On Sun, 21 Nov 2021, 18:43 Frederic Gagnon, @.***>
wrote:

@gausie https://github.com/gausie please... :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kolmafia/kolmafia/pull/49#issuecomment-974871341, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABL4LX6MQ2SQBNGUXUSUGDUNE4UVANCNFSM5E6TNGQA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@fredg1 I can just search for mergeLocations and find them easily. Here, for example:
https://github.com/kolmafia/kolmafia/pull/49/files#diff-b8bc17c4090ef5844289ff27770514ed82cd5bbe8b440d83f76d68a13e81b2d8R2499

@fredg1 I can just search for getLocation and find them easily. Here, for example:
https://github.com/kolmafia/kolmafia/pull/49/files#diff-b8bc17c4090ef5844289ff27770514ed82cd5bbe8b440d83f76d68a13e81b2d8R2499
EDIT: That's actually the only one for mergeLocations.

but... the overload requires both parameters to be Commands? And that example only has the first parameter as a Command?

@fredg1 I can just search for getLocation and find them easily. Here, for example:
https://github.com/kolmafia/kolmafia/pull/49/files#diff-b8bc17c4090ef5844289ff27770514ed82cd5bbe8b440d83f76d68a13e81b2d8R2499
EDIT: That's actually the only one for mergeLocations.

but... the overload requires both parameters to be Commands? And that example only has the first parameter as a Command?

I'm just surprised you wouldn't make a few more overloads for it I guess. But if you don't want to we can just look at merging this.

By well-tested, I mean tests that go beyond just exercising lines of code, but actually check that all the things that you're doing are happening correctly.
The test changes you've added in this change only exercise making Token extend Range (which means each Token now has a Position, among other things).
A partial list of what I'd like to see:

One PR that splits Line / Token / Comment into a separate file, adding tests for each of the public methods of those classes.
One PR that makes Token extend Range, with the tests you have today.
Some number of PRs that actually check that the Locations you're adding to these ParseTreeNodes are as expected. As mentioned, it would be easier to do so if those methods were more visible and returned well-defined values, but I do not think it's appropriate for them to be public methods of Parser.

The above are requested changes that I understand to be OBE so I will dismiss the review.


Implement redirect using JekyllRedirectFrom

It's generating bad redirects, hmm.
<meta http-equiv="refresh" content="0; url=http://<IP_ADDRESS>:4000/training-material/topics/transcriptomics/tutorials/scrna-preprocessing/tutorial.html">

not sure how to fix that

I am not sure to understand what you see here as bad redirect. I tried locally and it worked

This was written in the _site folder, if that's deployed, I think it will redirect to the user's computer?

I was wrong, this is ready to merge. I'm sorry


feat: add vuln assessment recurring scan arguments as variables

Closes #67

Test passed 👍🏽, changes has been made in the resource "azurerm_mssql_server_vulnerability_assessment" "this", recurring scans now has variables. This was done for the reason of not hardcoding in recurring scans, thus making it easier to make changes if need be.

@kov117 I'd recommend renaming the PR to something like feat: enable vulnerability assessment email notifications.
Always think of it from the POV of the user. My suggestion would translate to something like This feature allows you to enable vulnerability assessment email notifications.


Document null argument limitation with SceneTree.call_group()

3.x version of https://github.com/godotengine/godot/pull/53541.

Thanks!


Show "Debug Console" automatically when a new debugging session is started

VSCode Version: 1.9.0
OS Version: macOS 10.12.3

Steps to Reproduce:

Create workspace with a "Hello, World"-style app (language doesn't matter).
Add launch.json to the workspace.
Switch to any panel tab but "Debug Console".
Start debugging.

Expected behavior:
The "Debug Console" tab is shown automatically when the debugger is launched.
Actual behavior:
The currently active tab stays active.
This behavior is really annoying when using a launch configuration that combines "externalConsole": false with "preLaunchTask": "...". The "Output" window is shown when the preLaunchTask runs, so you have to go back to "Debug Console" manually every time you start debugging.

NVM, setting "internalConsoleOptions": "openOnSessionStart" results in the desired behavior.


Fix the contributing URL in Raycast Explorer

Description
The "Contribute" button in the Raycast Explorer is leading to a non-existent URL. It seems that part of the URL, specifically /src/, is missing.
Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

Could you rebase/merge the main branch? There was something failing on the CI.


Adding a GNU General Public License

Permissions of this strong copyleft license are conditioned on making available complete source code of licensed works and modifications, which include larger works using a licensed work, under the same license. Copyright and license notices must be preserved. Contributors provide an express grant of patent rights.

This work is licensed under a Creative Commons Attribution-NonCommercial 4.0 International License.

I put this badge on the readme and I will close this pull request


groups/chat: ~famhut-wolpyx cannot post

~famhut-wolpyx is attempting to chat in ~bollug-worlus/tlon/channels/chat/~bollug-worlus/urbit-core-dev and sees the following:
%chat: on-poke with mark %chat-action-0
%groups: on-peek on path /x/groups/~zod//fleet/~famhut-wolpyx/vessel
peek bad result
/app/groups/hoon:<[430 31].[430 51]>
/app/groups/hoon:<[430 5].[431 37]>
/app/groups/hoon:<[429 5].[431 37]>
/app/groups/hoon:<[191 14].[191 49]>
/app/groups/hoon:<[191 6].[191 49]>
/app/groups/hoon:<[191 5].[191 60]>
/app/groups/hoon:<[190 5].[191 60]>
/app/groups/hoon:<[182 3].[192 5]>
/app/groups/hoon:<[181 3].[192 5]>
/sys/vane/gall/hoon:<[1.457 26].[1.457 60]>

He has hard-refreshed several times, but has not left + rejoined.

Leaving the group and rejoining worked.


refactor(fs): group files by component

Description:
Group component related file in a directory named after the component.
Motivation and Context:
As part of the i18n support that I'm working on I need to store the message sources for each component alongside the component code to keep everything clean and tidy and easy to follow. This refactoring consolidates the component code so that each component lives in it's own directory.
How Has This Been Tested?
Ran all tests and manually tested app.
Types of changes:
Refactor
Checklist:

[x] My code follows the code style of this project.
[x] I have reviewed and updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes where needed.
[x] All new and existing tests passed.
[x] My commits have been squashed into a concise set of changes.

Coverage decreased (-0.1%) to 16.097% when pulling 2c00b00b1abfe400afd83eee121e98b1e37d9113 on mrfelton:refactor/group-components into 6975846f6b2d06eac3db86f47fc7506f6895a492 on LN-Zap:master.

utACK 22df496
@mrfelton can you rebase?

rebased @JimmyMow

Tested ACK f51586d


Make instance positions relative to center when using GPU instancing

Make instance positions relative to center when using GPU instancing, otherwise jittering will occur.

https://github.com/Geodan/i3dm.export/pull/58


Add clusters_client_config_dir to reactor-config

This new config is used to determine the location of osbs.conf file to
be used when communicating with worker clusters.
Signed-off-by: Luiz Carvalho<EMAIL_ADDRESS>

Updated release notes draft:

Add clusters_client_config_dir to reactor config


Add analytics logging to MosaicMLLogger

Add log_analytics function to MosaicMLLogger
This adds a log_analytics function to the MosaicMLLogger, which records these metrics about composer runs on the Mosaic platform:

fsdp_config

sharding_strategy
state_dict_type
activation_checkpointing
forward_prefetch
backward_prefetch
mixed_precision
device_mesh

autoresume
algorithms
cloud_providers

cloud_provider_data
cloud_provider_checkpoints

save_interval
loggers
precision
optimizer

By logging these fields from the MosaicMLLogger into a run's metadata, we can then parse the metadata in SQL and add these metrics into UC. This will enable anyone on the genai team to create dashboards / queries for analytical purposes and view the patterns in these metrics across runs on the platform. (see the genai_runs table for more info)
Output of the Quick Start Example

Added some tests and adjusted the way we display optimizers. If algorithms is similarly verbose I can do something similar for that as well 👍

@mvpatel2000 are you suggesting a new logger function log_analytics that broadcasts to all LoggerDestinations? not sure how useful that is. In foundry for example, we already log the full config to the ones where it makes sense (wandb, mlflow).

@mvpatel2000 @angel-ruiz7 @dakinggg is this one basically done? or are there still concerns?


Mkcloud job name

Let the caller of an openstack-mkcloud run set the build name.
This allows shorter and more specific names and thus helps with the overview in job listings (and RSS feeds).
Will give this a test run tomorrow (initial test yesterday was successful).

My understanding was that everything got pushed to Jenkins from git, not the other way around, so why is this an exception?

answer for all except aspiers (SCNR): All JJB jobs (the ones in yaml) are pushed from git to jenkins. The remaining jobs (these that are in xml) are only backups of the jobs in jenkins.
This will go into the commit message so that @aspiers also finds it :)

@aspiers
Added a description to the commits that fetch resp. delete the xml based jenkins jobs. The commits are no longer part of this PR as it is a different topic to backup the jobs from jenkins. They are already comitted to master.

I now take the liberty to merge this with only one +1000 :)
There is no other way to test this other than deploying it, and if it should be deployed, we need all parts, otherwise remaining parts will have the default "-no-name-" name.
Furthermore it makes sense to test this when not much happens (and thus not much can break) in jenkins - so many people being at the summit now is a good timeslot.
I will monitor it closely after the merge. If something fails for anybody - feel free to revert this PR entirely (without review, just revert).

This will go into the commit message so that @aspiers also finds it :)

I asked for it to go in the commit message not for my benefit, but so that other people could find it in years to come, when they are reading git history via git log, git blame etc. :stuck_out_tongue_closed_eyes:
But thanks for this great work!!


Fix typo: nodejs-prog-model-context.md

Issue #, if available:
context.function_version is undefined.
I guess this file was copied from python-prog-model-context.md and forgotten to change the variable name.
Description of changes:
- function_version
+ functionVersion

also need to fix following localized docs

https://docs.aws.amazon.com/ja_jp/lambda/latest/dg/nodejs-prog-model-context.html
https://docs.aws.amazon.com/fr_fr/lambda/latest/dg/nodejs-prog-model-context.html
and so on...


Fix animation of side menu

[x] Remove animation on side menu.
[x] The AlertBanner should not be under the header but hover it.
[x] Remove the text autocomplete from all label.
[x] The approved field should be more evident to comply with government requirements.
[x] The text for the confirm and unconfirm for single field is missing.
[x] The icon on confirmed field should change when overing hover them for something similar to this image but only with one check.

could not resolve the merging problem see pull request: 381 as a dev i want to fix some minor issue with the frontend design #387

could not resolve the merging problem see pull request: 381 as a dev i want to fix some minor issue with the frontend design #387


buildsystem: add example makefile for interop C with Lisp

shared library
static library
example run

This example code and Makefile show how to build static and shared libraries and how to interoperate between C and Lisp (with a handler case example). It is noteworthy that application startup is slow, because top-level forms of all dependencies must be replayed. It is also worth keeping in mind, that this to run requires:

newest cffi from repository
newest ecl from repository

Ah, also you may call strip on binaries, then they come down from 80MB to 23MB.

highly cool! Will merge, and we can iterate/change names/whatever. Thanks!


Issues importing Keras Model from python to Java due to Conv3DTranspose layer

Issue Description
I was attempting to import a model I had saved from Python using Keras into DL4J in Java.
Expected Behavior:
KerasModelImport.importKerasSequentialModelAndWeights would appropriately import my saved model which I previously wrote and saved in python without issues.
Encountered Behavior:
The method ended up throwing an error because it did not recognize the "Conv3DTranspose" layer. Conv3DTranspose is the python Keras name for a Transposed Convolution or Deconvolution layer.
Version Information

Deeplearning4j version: deeplearning4j-core:1.0.0-beta7
Platform information (OS, etc): Minecraft Windows 10 Home

Additional Information
https://gist.github.com/KhioneusNevula/c90d2c1684cd82a0f01f7cbce9e488a8 (crash report)

Hi, have you tried with version 1.0.0-M1.1 ?

No, I have not. Can you tell me how to do a gradle download for it?

@marquies Conv3DTranspose is not in the new release unfortunately, we will have to implement it. For now only a custom layer will work.  We'll get this in to the next release and have snapshots
@KhioneusNevula  just change your version to 1.0.0-M1.1

@agibsonccc There's an existing Deconvolution3D layer for DL4J. Is there any way to make a custom layer that just uses the Deconvolution3D layer's functionality? Deconvolution3D is I believe equivalent to Conv3DTranspose

@KhioneusNevula indeed there is.  Let me clarify something:
Generally if you need to implement a custom layer, you would do that with samediff. It has automatic differentiation and would allow you to just map ops line by line from an existing implementation.
In order to use the dl4j version,  when I say "implement" it basically means creating a KerasLayer. You can see those here:
https://github.com/eclipse/deeplearning4j/tree/master/deeplearning4j/deeplearning4j-modelimport/src/main/java/org/deeplearning4j/nn/modelimport/keras/layers/convolutional
We'll have to do something similar with this to make it work. It wouldn't be that bad to do, it will take a bit to properly test though. That's why I think we can get it in the next release pretty quick. If you would like to take a shot at this and supply a test case + help with feedback, I'd be happy to guide you through the process.

Thank you!

@KhioneusNevula  I'm taking a look at this, do you have a reproducer model for me so I can double check the results?

@agibsoncc I'm very new to using machine learning and GitHub so I'm not super familiar with what a "reproducer model" is.

@KhioneusNevula a reproducer in software (especially open source) helps a library author reproduce the conditions under which something isn't working properly.
A model is just a machine learning model, in this case an exact configuration + some weights you save.
This could be anything that you create in keras and call save(..) on.
Usually to go with that I would want a sample numpy array that you would put in to the model for predict(..) - the reason I want this specifically from the issue author is to ensure that everything is resolved as expected and the issue author gets what they need out of the fix.
Hopefully that makes sense!

Hi,
I am the issue author; I tried storing the model in various ways.
I used both json (I'll send as zip) and h5.
h5 file
json file with h5 weights file in zip folder

@KhioneusNevula yes I'm aware :) I was speaking in general terms so you understood that this was a standard practice for any library you probably report an issue to. I appreciate you getting back to me and I will take a look with this. Thanks!

@KhioneusNevula how exactly did you save your model? I keep getting errors when trying to load it. I'm using tf.keras 2.5.0.

I used keras 2.4.3 and called the "save" function on the model

@KhioneusNevula just confirming I was able to load the model with your given configuration. I just need to add a test for NCDHW format in addition to your test case which is channels last to ensure we cover all valid cases and we should be good to go. Thanks for the test case!

Thank you so much for your help!

@agibsonccc How would I access the changes you made?

@KhioneusNevula it should be available on snapshots https://deeplearning4j.konduit.ai/multi-project/explanation/snapshots


facilitators scripts to manage the containers

Thanks @albertocsm!
Can you please move the scripts to a separate sub-directory, for example /scripts/ (at the root level). They are not part of the Docker images, and should be clearly separated.
Btw I'm personally using docker-compose (formerly Fig) to run the containers.

@pesho done


Tweak ghcup upgrade

add --inplace flag
by default install into BIN_LOCATION

I'll try to remember to us -i the time after the next time I call it

I don't even understand the use case exactly...
Also @Franciman would that break anything?

As I understand it, the current default behaviour changes and I must provide -i to update the script inplace... or did I misunderstand? I'd obviously prefer that inplace was the default but I assume you have reasons why this is not good, and I am fine typing two extra characters.

Hi, thanks for noticing me, it won't break anything on vabal side.

my ghcup is in PATH too so maybe this doesn't affect me, I guess this might only matter if the script is called explicitly?

The default behavior now is:

upgrade into ${GHCUP_INSTALL_BASE_PREFIX:=$HOME}/.ghcup
if passed --inplace will upgrade at the location of where the script is at (wherever that is)
if invoked ghcup upgrade <some-dir> then will place it there

Is that too confusing?

ok thats' what I thought from reading the source code, the comments here confused me. I might move my script location to ~/.ghcup/bin just to make this easier to manage.


Add support for osu! API

We should use the new V2 API as documented here. https://osu.ppy.sh/docs/index.html as it's currently the recommended API.

A lot of what we require is not documented yet, we'll stick with the v1 API for now and upgrade later. Plus the v1 is much more portable.


Added new pipe: "ng2-order-pipe"

There seems to be some urls that need some fixing, could you please take a look and perhaps add the fixes to the PR?

See 194029216#L498.

@rolandjitsu The links seem to work right now


add feature to clear *.response file

@gschier

20+ GB size of all *.response file saved on C:\ & currently no buttons to clear it in Insomnia

?

Response files can be cleared out by clearing the response history of a given request.

Should this issue maybe be changed to "Add ability to clear ALL responses?"

Hi, I would like to work on this. :smile:


Fix navigating back after page reload

closes #685 LiveURL: https://smartfaq-fix-back-button.surge.sh

:tada: This PR is included in version 1.9.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Cluster install and logs of archived workflows

We are using argo-workflow in clustered mode, as the artifact database minio.
The argo-server, workflow-controller, ... are running in the namespace arg-workflows,
our workflow in another, let's say it is kondor-ci.
We have now the effect that when a workflow from namespace kondor-ci is archived and we
want to look at the logs they are missing.
Looking into the archived workflows in the json saved in the table argo_archived_workflows we see:
...
{
"name": "main-logs",
"s3": {
"key": "list-artifacts-k5qkb/list-artifacts-k5qkb-store-artifact-1-3396785658/main.log"
}
}
...
Looking into minio and into the my-bucket we see those artifacts are available and stored in minio,
but they don't appear in the workflow UI when we select an archived workflow and click on logs.
Also such an call
http//.../argo/artifacts-by-uid/b914c970-788a-4a2f-968c-d88f8c1c1ca1/list-artifacts-k5qkb-store-artifact-1-3396785658/main-logs
returns 500 internal server error with the message "artifact not found".
Looks like this is this part of the code:
func (a *ArtifactServer) returnArtifact(ctx context.Context, w http.ResponseWriter, r *http.Request, wf *wfv1.Workflow, nodeId, artifactName string, isInput bool) error {
kubeClient := auth.GetKubeClient(ctx)
var art *wfv1.Artifact
if isInput {
art = wf.Status.Nodes[nodeId].Inputs.GetArtifactByName(artifactName)
} else {
art = wf.Status.Nodes[nodeId].Outputs.GetArtifactByName(artifactName)
}
if art == nil {
--->		return fmt.Errorf("artifact not found")
}
The artifacts configuration in the configmap is (set for both namespaces: arg-workflows and kondor-ci):
default-v1: |
archiveLogs: true
s3:
bucket: my-bucket
endpoint: minio:9000
insecure: true
accessKeySecret:
name: my-minio-cred
key: accesskey
secretKeySecret:
name: my-minio-cred
key: secretkey
Looks to me like a bug in the API server which does not use the correct artifacts settings.

Tested against 3.2.4, looks like bug is resolved there, logs are visible in cluster mode.
Thanks !


@clerk/remix integration returns a 401 + redirect when viewing a website after the short lived token has expired

Preliminary Checks

[X] I have reviewed the documentation: https://clerk.com/docs

[X] I have searched for existing issues: https://github.com/clerk/javascript/issues

[X] I have not already reached out to Clerk support via email or Discord (if you have, no need to open an issue here)

[X] This issue is not a question, general help request, or anything other than a bug report directly related to Clerk. Please ask questions in our Discord community: https://clerk.com/discord.

Reproduction / Replay Link
https://github.com/AdiRishi/clerk-remix-401-demo
Publishable key
pk_live_Y2xlcmsubmFhbWRlby5vcmck
Description
Description
The  @clerk/remix integration seems to have behavior where when you visit a webpage with an expired short lived session token, the app will initially respond with a 401 code, then redirect the user back to the same page, finally loading with a 200.
Although this behavior won't be obvious to a user, for those of us trying to optimize the initial page load as much as possible, this creates a rather noticeable delay on the first page load (anywhere from 300ms to 1-2s).
Because the remix integration wraps the whole app, even content pages that need no auth will exhibit this behavior.
I personally feel like this is not really acceptable behavior. It should be possible to wrap your app in authentication and not have the first response always be a 401.
Looking forward to some feedback or advice on if this is a planned fix, or if there is no possible way to get around this.
Steps to reproduce
I've recorded examples from both my provided reproduction repository and one from the official clerk remix starter app found here.

Personal repository demo : https://app.replay.io/recording/401-redirect-demo-repro-repository--d6948cd7-211a-48e2-b3aa-4702f3abc03d
Official Remix demo : https://app.replay.io/recording/401-redirect-demo-remix-starter--8c1458e0-5999-490b-a889-aa4577b91496

Steps taken

Log in to the app
Close the browser tab with the webapp
Wait for the short lived token to expire. My guess is you should wait around 30s to 1m?
 My guess is the initial 401 response contains the now refreshed session token.
Environment
System:
  OS: macOS 14.1.1
  CPU: (8) arm64 Apple M1 Pro
  Memory: 575.31 MB / 32.00 GB
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node
  Yarn: 1.22.19 - ~/.nvm/versions/node/v18.17.0/bin/yarn
  npm: 10.2.1 - ~/.nvm/versions/node/v18.17.0/bin/npm
  pnpm: 8.10.5 - ~/.nvm/versions/node/v18.17.0/bin/pnpm
Browsers:
  Chrome: 119.0.6045.159
  Safari: 17.1
npmPackages:
  @clerk/remix: ^3.1.5 => 3.1.5
  @remix-run/css-bundle: ^2.3.0 => 2.3.0
  @remix-run/dev: ^2.3.0 => 2.3.0
  @remix-run/eslint-config: ^2.3.0 => 2.3.0
  @remix-run/node: ^2.3.0 => 2.3.0
  @remix-run/react: ^2.3.0 => 2.3.0
  @remix-run/serve: ^2.3.0 => 2.3.0
  @types/react: ^18.2.37 => 18.2.37
  @types/react-dom: ^18.2.15 => 18.2.15
  eslint: ^8.54.0 => 8.54.0
  isbot: ^3.7.1 => 3.7.1
  prettier: ^3.1.0 => 3.1.0
  react: ^18.2.0 => 18.2.0
  react-dom: ^18.2.0 => 18.2.0
  typescript: ^5.2.2 => 5.2.2

We definitely understand your frustration here, and have heard it from others as well. We are currently actively looking into ways that we can change this behavior and still have everything work correctly. We are hoping to have a modified version out in the next few months that does not include this redirect behavior 🙌
However, as it stands, this is not a bug and the library still works correctly, so we're going to close this issue. But appreciate your surfacing this and again hoping to have it fixed soon!

Hey @jescalan , really glad to hear that this is a fix actively being worked on 😄 . Happy to do some early testing if needed, so don't hesitate to reach out.
Just a note, given that this issue is actually being worked on, it feels like it would be a good idea to leave this open with maybe a feature-request tag or something? But I totally understand the need to keep the issue list lean so all good either way.

Hey @jescalan I wanted to follow up again on this issue. You mentioned the team was researching a way to not have this behaviour, has there been any progress in this matter?
This is still a really annoying side effect of using Clerk, one that causes much grief when we work hard on website performance. Would really love to know what is being done to solve this.

Hi there! So sorry for the slow response here @AdiRishi. There has been indeed, we have changed this mechanism in the latest beta of the remix SDK.

Details on the beta release
Upgrade guide for remix

Give it a shot and see if this does the trick for you.
Also note that the previous behavior (interstitial) was replaced by a new behavior (handshake) that runs faster and does not render an actual page in its redirect cycle, but will still redirect a short loop if it detects an expired session token. There isn't a way for us to remove the need to re-validate if there's an expired session token the way that clerk's auth is architected. This should pay off overall in your page render speed however, since your backend only needs to verify the token's signature, which is very fast (usually ~1ms or less), rather than making a database call to verify auth state, which is much slower. Happy to go into more detail on this if you're curious.

@jescalan Sorry for the super delayed response, I just got to updating the production sites that use Clerk to the latest version with Clerk Core 2. The update's working really well, flash is gone, super smooth experience 😄
Getting server responses under 100ms for my page loads, which is fantastic 🎉

Amazing, this is so great to hear! Thank you so much for the feedback here and for using Clerk 💖


Getting the error "Operation not permitted, rmdir" on Git Bash (Windows)

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version
6.4.2
Electron version
24.8.5
Operating system
Windows 11 22H2 (22621.2361)
Last known working Electron Forge version
6.4.2
Expected behavior
I expect electron-forge make --platform=win32 --overwrite --tmpdir=false to make a valid Windows app (bundled with Vite).
Actual behavior
The command fails on the "Copying files" step within "Packaging for x64 on win32" with the following error:
An unhandled rejection has occurred inside Forge:
Error: EPERM: operation not permitted, rmdir 'C:\Users\JUSTIN~1.FAR\AppData\Local\Temp\electron-packager\win32-x64\[PROJECT NAME]-win32-x64-MIJEjn\resources\app\node_modules\.cli-spinners-uvmGTKND'

Steps to reproduce
Using Git Bash and this forge.config.ts:
module.exports = {
  makers: [
    {
      name: '@electron-forge/maker-squirrel',
      config: {},
    },
  ],
};

Simply run rm -rf .vite && electron-forge make --platform=win32 --overwrite --tmpdir=false (the .vite folder occasionally fails to be removed as well and have been removing it with rm -rf - I am unsure what is causing this, however I am not running an elevated Git Bash prompt. I have simply been running the default VS Code Git Bash terminal available once Git Bash was installed with default settings)
Additional information
Output of the electron-forge make command with DEBUG=electron-forge:*:
> rm -rf .vite && electron-forge make --platform=win32 --overwrite --tmpdir=false

⠋ Checking your system
✔ Checking your system
[STARTED] Loading configuration
  electron-forge:project-resolver searching for project in: C:\Users\justin.farrell\Documents\[PROJECT NAME] +0ms
  electron-forge:project-resolver package.json with forge dependency found in C:\Users\justin.farrell\Documents\[PROJECT NAME]\package.json +6ms
[SUCCESS] Loading configuration
[STARTED] Resolving make targets
  electron-forge:require-search searching [
  '@electron-forge/maker-squirrel',
  'C:\\Users\\justin.farrell\\Documents\\[PROJECT NAME]\\@electron-forge\\maker-squirrel',
  'C:\\Users\\justin.farrell\\Documents\\[PROJECT NAME]\\node_modules\\@electron-forge\\maker-squirrel'
] relative to C:\Users\justin.farrell\Documents\[PROJECT NAME] +0ms
  electron-forge:require-search testing @electron-forge/maker-squirrel +2ms
[DATA] Making for the following targets: squirrel
[SUCCESS] Resolving make targets
[STARTED] Running package command
[STARTED] Preparing to package application
  electron-forge:project-resolver searching for project in: C:\Users\justin.farrell\Documents\[PROJECT NAME] +1s
  electron-forge:project-resolver package.json with forge dependency found in C:\Users\justin.farrell\Documents\[PROJECT NAME]\package.json +4ms
[SUCCESS] Preparing to package application
[STARTED] Running packaging hooks
[STARTED] Running generateAssets hook
[SUCCESS] Running generateAssets hook
[STARTED] Running prePackage hook
[SUCCESS] Running prePackage hook
[SUCCESS] Running packaging hooks
[STARTED] Packaging application
[DATA] Determining targets...
  electron-forge:packager packaging with options {
  asar: false,
  overwrite: true,
  ignore: [ /^\/out\//g ],
  quiet: true,
  dir: 'C:\\Users\\justin.farrell\\Documents\\[PROJECT NAME]',
  arch: 'x64',
  platform: 'win32',
  afterFinalizePackageTargets: [ [AsyncFunction (anonymous)] ],
  afterComplete: [ [AsyncFunction (anonymous)] ],
  afterCopy: [ [AsyncFunction (anonymous)] ],
  afterExtract: [ [AsyncFunction (anonymous)] ],
  afterPrune: [ [AsyncFunction (anonymous)] ],
  out: 'C:\\Users\\justin.farrell\\Documents\\[PROJECT NAME]\\out',
  electronVersion: '24.8.5'
} +0ms
  electron-forge:packager targets: [ { platform: 'win32', arch: 'x64' } ] +20ms
[STARTED] Packaging for x64 on win32
[STARTED] Copying files
[FAILED] EPERM: operation not permitted, rmdir 'C:\Users\JUSTIN~1.FAR\AppData\Local\Temp\electron-packager\win32-x64\[PROJECT NAME]-win32-x64-MIJEjn\resources\app\node_modules\.cli-spinners-uvmGTKND'
[FAILED] EPERM: operation not permitted, rmdir 'C:\Users\JUSTIN~1.FAR\AppData\Local\Temp\electron-packager\win32-x64\[PROJECT NAME]-win32-x64-MIJEjn\resources\app\node_modules\.cli-spinners-uvmGTKND'
[FAILED] EPERM: operation not permitted, rmdir 'C:\Users\JUSTIN~1.FAR\AppData\Local\Temp\electron-packager\win32-x64\[PROJECT NAME]-win32-x64-MIJEjn\resources\app\node_modules\.cli-spinners-uvmGTKND'
[FAILED] EPERM: operation not permitted, rmdir 'C:\Users\JUSTIN~1.FAR\AppData\Local\Temp\electron-packager\win32-x64\[PROJECT NAME]-win32-x64-MIJEjn\resources\app\node_modules\.cli-spinners-uvmGTKND'

An unhandled rejection has occurred inside Forge:
Error: EPERM: operation not permitted, rmdir 'C:\Users\JUSTIN~1.FAR\AppData\Local\Temp\electron-packager\win32-x64\[PROJECT NAME]-win32-x64-MIJEjn\resources\app\node_modules\.cli-spinners-uvmGTKND'

forge.config.ts:
module.exports = {
  makers: [
    {
      name: '@electron-forge/maker-squirrel',
      config: {},
    },
  ],
};

Hmm, it appears that what was causing this was an empty folder present in my node_modules titled ".cli-spinners-uvmGTKND". Once I deleted that, curiously it worked.


Outdated picture in Part 5 (AuReiNAND)

At "You can remove any extra files from the root of the SD card that are not in the image." section of Part 5 (AuReiNAND), the picture should be updated to latest version since rei folder change to aurei folder, etc.

Fixed


Added prefix edgex- in support-logging and config-seed log name

Two minor issues are fixed:

Replaced local variable bootTimeout by internal.BootTimeoutDefault in several microservices
Added prefix edgex- in support-logging and config-seed log name (issue #545)

@jduranf This looks good, thanks for the good work! I'm going to wait on merging this until #620 is merged because of the overlap with the sys-mgmt-agent. You may have a small conflict to resolve but I'd rather we do it here since there's some pressure to get 620 in. Thanks for your patience.

@tsconn23 don't worry, I will update this PR after #620 have been merged


Effect called multiple times if you subscribe to it

I have  an Effect:
@Effect()
  addTagToVideoEffect_ = this.appState_
    .ofType(TagActions.ADD_TAG_TO_VIDEO)
    .do(_=>console.log('TagActions.ADD_TAG_TO_VIDEO'))
    .map<AddTagToVideo>(action => action.payload)
    .switchMap((addTag: AddTagToVideo) => this.dtsiVideosService.addTagToVideo(addTag)
      .map((addTag: AddTagToVideo) => TagReducers.addTagToVideoComplete(addTag))
      .catch((err) =>Observable.throw(err))
    );

and in my view I am dispatching the TagActions.ADD_TAG_TO_VIDEO  and subscribing to it:
this.subscription = this.tagActions.addTagToVideoEffect_.subscribe(
      this.onAddTagSuccess,
      this.onAddTagError
    );

this.tagActions.addTagToVideo({videoId: this.videoId, tag: tag});

the .tagActions.addTagToVideoEffect_.subscribe results in having my effect called twice, is this a bug ? How can we get the results of the effects in the view without having the effect called twice ?

You should never subscribe to annotated effect, subscribe to the store instead.

I posted on stackoverflow . Could you show me how to subscribe to the store as I don't see how it could resolve the problem.

How to subscribe to the store? Inject it and do .subscribe() on it? You should never subscribe to an effect, not in the new(2.0.0) version anyway. I think you are misunderstanding how to use this lib, it's not a promise, it doesn't have any callbacks you can subscribe to. Pardon me if I'm wrong.
In the centerpiece of everything is the @ngrx/store, there are actions dispatched to the store, you can either "catch" these action in a reducer, or an effect(or both). When you catch an action in an effect(using ofType()), you can for example switchMap, this action to an async call, and then map the result to a different action, think REQUEST_SOMETHING_ACTION -> effect -> SUCCESS_SOMETHING_ACTION, this success action, which includes payload of your async call, will then be handled by a something reducer, filling it with data.
Then in your component, you can subscribe to this slice of state, by doing somethign along these lines
somethings$ = this._store.map(wholeStore => wholeStore.something)

you can then either subscribe to somethings$ in your component's class, or you can directly use it in the template with the async pipe
<pre>{{ somethings$ | async | json }}</pre>

Yes I know the ordinary flow, did you look at the stackoverflow link above where I try to illustrate my current frustration with adding to the store the ephemeral states of a component form. Like: Action: Pending then Success or Error and then after a second or two you have to reset the component form to Pristine in the store, otherwise you would re-open this component with a big green tick illustrating Success. I know that I can solve all this by adding it to the store these states but that's so much boilerplate Actions Effects Reducers for what needs to be done... If the subscription to the Effect was not generating a second call on my Service (stackoverflow) the problem would be solved. I do understand that this would bring a tight coupling between the component form and the Effect but this coupling in my case seems appropriate. Is there way to get those  this.onAddTagSuccess, this.onAddTagError in my view to fire without introducing those ephemeral state in the store ? I think that I wouldn't be the only one  appreciating it. Thank you for your feedback.

Can you post the view code that is calling the code that dispatches the action?

static ADD_TAG_TO_VIDEO = '(Action)[Tag] ADD_TAG_TO_VIDEO';
  addTagToVideo(obj: AddTagToVideo): void {
    this.store.dispatch({
      type: TagActions.ADD_TAG_TO_VIDEO,
      payload: obj
    });
  }

Not actually sure what happens when you subscribe to an effect. It might be similar to subscribing to a piece of state in the store: when you subscribe, it will immediately return the last emitted value. This is so your view can have immediate access to a value, rather than waiting for the next state change.
What you could try is a global event system, so your view can listen to specific events that you define. Then when your Effect finishes, it can fire the event. Here are two places that have examples of that:

http://stackoverflow.com/questions/34700438/global-events-in-angular-2
https://scotch.io/tutorials/angular-2-http-requests-with-observables#component-interaction-what-you-may-not-know

Alternatively, if you just need to prevent your addTagSuccess or addTagError functions from executing the first time, you might be able to just skip the first emitted value of your observable:
this.subscription = this.tagActions.addTagToVideoEffect_
  .skip(1)
  .subscribe(
    this.onAddTagSuccess,
    this.onAddTagError
  );

I have found a solution: stackoverflow


Synclist style

I'd have made this use WritePackedUInt32 too, but that'd break binary compat, so i didnt. That should be done at some point though. For now, these are only style changes.

:tada: This PR is included in version 3.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


CSFR Token issue when Phoenix.Html.Link.button/2 is rendered in a partial

I've noticed that when a (non Drab) button is rendered by Phoenix.Html.Link.button/2 in a partial, the CSFR token isn't anymore valid after poking some assignments in the main template. Maybe it is related to #67 because according to the Phoenix documentation the button is rendered by Phoenix using a regular HTML form.
This is the test code:
# main.html.drab
<button type="button" drab="click:update_assignments">Do Poke Assignment</button>
<%= inspect @foo %>

<%= render("_sub.html", assigns) %>

# _sub.html.eex
   <%= button("Do My Action", to: my_path(@conn, :my_action) ) %>

# Commander

defhandler poke_assignment(socket, sender) do
   poke socket, foo: 42
end

If the "Do My Action" button is clicked before pressing the "Do Poke Assignment" button it works well, but after poking a value and press the button again, it raise the exception:
invalid CSRF (Cross Site Request Forgery) token, make sure all requests include a valid '_csrf_token' param or 'x-csrf-token' header
Workaround seems to be difficult because its not clear for me how to access the CSFR token, as suggested in #67 to save and set back the token, because the 'form' whose belong is not explicit.
EDIT:
Fixed some errors in the problem description

It is related to #67, actually it is very similar.
Phoenix button/2 generates something like:
<button data-csrf="PjcXYRgmBAEKFDIHNz8wWy8TEx0vAAAAjxnVPjkYaBdURIY+JwFTUw==" data-method="post" data-to="/tests/live">...</button>

So when you rerender it, token changes and Phoenix complains about it.
As a workaround, you may get the token before:
 %{"dataset" => %{"csrf" => old_csrf}} = query_one! socket, "#a", "dataset"

and set it after poke:
set_data socket, "#a", csrf: old_csrf

The ideal would be if Drab could store those tokens itself... Lemme think about it.

What do you prefer, that I left this case open, as Drab has to be enhanced to circumvent this limitation, or I close it because there is a working workaround available?

Please leave it open.
I think it should be solved somehow before 1.0. This is because I want Drab to be as compatible with Phoenix as it is possible.
Also, Drab is targeted to the beginners as well. The idea is to make everything easier, and such workarounds are not helping at all :)
This is a rough plan for a solution:

drab.live.js detects all csrf tokens (in buttons and in hidden inputs in forms) and stores them internally (issue: what about buttons without an id?)
drab.live.js sends this information to server
after re-render the html, Drab.Live updates all elements with tokens with the saved ones; ideally it would be if it detects where to update (and not in the whole document)


integrate blurb with overview section

Some small css updates
Updated some logos (including intel's, which was broken)
Integrated the blurb down into the "Overview" section (fixed mismatched css in blurb).

Merging this to get 2.11.0 out! @melissamcewen @drwpow would still love review post-merge

Looks great to me!


Nothing happens on iOS

I have set this up to prompt to pick a file from an action sheet result. When the code calls CrossFilePicker.Current.PickFile(), nothing happens. It never returns from the awaiter. If I remove the entitelments.plist from the properties, I get the no entitlement found error so I know it is doing something. Just not displaying the popup. Any help would be appreciated. The same project works on Android.

There is a known issue with iOS 11. See PR# 68 at https://github.com/Studyxnet/FilePicker-Plugin-for-Xamarin-and-Windows/pull/68.

PR merged and moved over code to own repo to publish NuGet with this. Development will be continued there. NuGet beta with this code is here: https://www.nuget.org/packages/Xamarin.Plugin.FilePicker/1.4.0-beta


Move Array index methods to Indexable

Array#[](range : Range) and similar methods (including the ones added in #7338) should be valid for any Indexable. Most methods could be implemented directly in Indexable and only #[]?(start : Int, count : Int) needs to be abstract and implementation-specific.
Currently, only Array implement a full set of range methods, but most other including classes implement at least some method like #[](range : Range) or #[](start : Int, count : Int).
The only trouble are Tuple and StaticArray which can't create dynamically sized instances of subsets of themselves. So the question is, what type should Tuple#[](range : Range) return. Or should it be possible at all? If not, we can't add this to Indexable.
Instead we could consider adding a module (for example List) which inherits from Indexable and implements range methods and allows modifications using []=, << etc.

The problem with [] that returns several values is what type to return. For Array it's clear: Array. Should Deque return a Deque? What about Tuple and StaticArray as you mention?
That's why I don't think [](range) belongs in Indexable. Maybe another module... but I'm not sure if it will be a big win.

It's possible to return Tuple for Tuple#[range], but this means having potentially huge macro expands, with every possible subsets size of the instance pre-defined in it.

For Tuple I always thought about supporting [](range) in a built-in way, similar to how [](index) is magical. But I didn't find good use cases for that so it might not be worth it.

I've a use case:
def first_n_args(num : Int, *args)
  args[0..n]
end
puts first_n_args 2, 'a', 'b', 'c'

I'm using a similar logic for an interpreter, for now I use case/whens with case num; when 0 {...}; when 1 {...} etc, then another case/when to match this Tuple against others.
I don't think it's that necessary, but I like the idea of having #[] for all Indexables.

And what about String? We could include Indexable in it. This means having String#each, String#first and loads of new methods form Indexable

Ruby had each for String, I think. The problem is that a String is a collection of chars and bytes so it's not clear what should be iterated by default. Plus String already implement those tons of methods from Indexable.

Ruby no longer supports String#each since 1.9
I don't think it's wise to include Indexable(Char) because of Char::Reader, nor possible to include Indexable(Bytes) due to #[] methods clash.

I see a String as a collection of Char in an encoding, which only happens to be a collection of bytes for some encodings (e.g. ASCII). I'd expect a String#each to iterate each Char, similar to how String#[] gives me the Char at an index.

By comparing https://github.com/crystal-lang/crystal/blob/master/src/indexable.cr#L186 and https://github.com/crystal-lang/crystal/blob/master/src/string.cr#L3722, this means creating a new Char::Reader for each unsafe_fetch, if we use the actual String#at method.
It will be less efficient.

Tuple#first(n : Int) and Deque's one returns Array since Enumerable#first(n : Int) is defined, so it's reasonable that Indexable#[](range) returns Array.
IMHO, Indexable#[](start, count) should be defined in Indexable by using each method and it returns Array as default. Then we can implement these method by using [](start, count):

[](range)
first(n)
last(n)
skip
skip_while
take_while

When some classes require to change these methods result (e.g. Slice), we can override [](start, count).


Rebase on upstream/main

Rebase on
2024-01-08 - fe51573 -  (HEAD -> main, origin/main, origin/HEAD) Fix backward error in DDP when running reward model finetune in RLHF (#507) <Wang, Yi>

Opened by mistake


Static Blocks not shown

Current behavior
Vue Storefront is not able to display static blocks configured in magento using the Block.vue component since introduction of storefront-query-builder in v.1.12.0
Expected behavior
Display of static block content.
Steps to reproduce the issue

Configure Static BLock in Magento
Output in vsf with Block.vue component

Repository

Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Which Release Cycle state this refers to? Info for developer.
Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser:
OS:
Node:
Code Version:

Additional information

hey, there was similar issue https://github.com/DivanteLtd/vue-storefront/issues/4529 Please check if this can help you

@gibkigonzo Unfortunately #4529  didn't help. storefront-query-builder already runs on recent v1.0.1
Results of query triggered by storefront-query-builder shows two dozens of search results. Subsequent code always returns first element. Sort order of elements listed vary after arbitrary static block is resaved in magento admin panel.

Please try this fix https://github.com/DivanteLtd/vue-storefront/pull/4605 We still have old hash for storefront-query-builder thats why it fetched old version

@gibkigonzo This commit solved the issue I reported. Thank you for your fast response.


Marathi ITN

What does this PR do ?
This is a PR for marathi ITN support for Cardinal, Decimal, Date and Time categories.
 Use git commit -s to sign.
[x] Do all unittests finish successfully before sending PR?

pytest or (if your machine does not have GPU) pytest --cpu from the root folder (given you marked your test cases accordingly @pytest.mark.run_only_on('CPU')).
Sparrowhawk tests bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...

[x] If you are adding a new feature: Have you added test cases for both pytest and Sparrowhawk here.
[x] Have you added __init__.py for every folder and subfolder, including data folder which has .TSV files?
[x] Have you followed codeQL results and removed unused variables and imports (report is at the bottom of the PR in github review box) ?
[x] Have you added the correct license header Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. to all newly added Python files?
[x] If you copied nemo_text_processing/text_normalization/en/graph_utils.py your header's second line should be Copyright 2015 and onwards Google, Inc.. See an example here.
[x] Remove import guards (try import: ... except: ...) if not already done.
[x] If you added a new language or a new feature please update the NeMo documentation (lives in different repo).
[x] Have you added your language support to tools/text_processing_deployment/pynini_export.py.

PR Type:

[x] New Feature
[x] Documentation

@ekmb

Hi @ekmb Can you please check and approve on the PR? I have added a PR on the NeMo repo as well with added feature. Thanks.

@ChinmayPatil11 thank you for the PR!
Could you please address CodeQL errors.

@ChinmayPatil11 thank you for the PR!
Could you please address CodeQL errors.

Sure I will, thanks for the review. Meanwhile can you please remove the stale tag on the corresponding PR to NeMo repository? https://github.com/NVIDIA/NeMo/pull/8117
Thanks!

Hi @ekmb, can you please check on the review. I have done the required changes on my part. Thanks!

Hi @ekmb, can you please check on the review. I have done the required changes on my part. Thanks!

Hi @ChinmayPatil11 , could you please add pytests + sparrowhawk tests to the jenkins file? Examples:
https://github.com/NVIDIA/NeMo-text-processing/pull/134/files# [create cache files]
https://github.com/NVIDIA/NeMo-text-processing/blob/main/Jenkinsfile#L333 [run all pytests]
https://github.com/NVIDIA/NeMo-text-processing/blob/main/Jenkinsfile#L393 [run SH tests]
Thanks!

jenkins

jenkins

jenkins


ISPN-8555 Fix deadlock in CacheManagerTest

https://issues.jboss.org/browse/ISPN-8555
https://issues.jboss.org/browse/ISPN-8587
Backport of https://github.com/infinispan/infinispan/pull/5617
The main difference is that IntSet doesn't exist in 9.1, so I'm using Collections.unmodifiableSet() instead of backporting ImmutableIntSet.

Merged, thanks !


fix broken fragments by reverting to div elements

Fixes issues that were raise in https://github.com/the-hideout/tarkov-dev/pull/202

.deploy


No 'Access-Control-Allow-Origin' in HTTP GET method

Getting error on HTTP REST Apis.

[x] Feature Request

We are fetching data from REST APIS using GET method. We getting error as No 'Access-Control-Allow-Origin'
We want to get  thingsboard data from REST APis, but http GET method is not working and we are not able to send headers, but http PUT and POST method has been working fine
The error in details as :
Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:8888' is therefore not allowed access. The response had HTTP status code 401.
How we can achive and solve error. I have try to using lot of siltiuon also checked CORS on chrome browser.

I am following @zarzaid comment ,but not able to save thingsbaord.yml
"thingsboard.yml"
"thingsboard.yml" E212: Can't open file for writing

can you please help


SurveyInstance: list for user edit or view as appropriate

Use normal table, stuggling to see why data-grid is needed - not expecting 1,000's or responses.

Perhaps split into two tables: completed / expired,   not started/in progress


Intake Louis product for DevOps

[ ] versioned source and artefacts
[x] an internal product documentation exist
[x] a Project to manage this product has been created

https://github.com/orgs/ai-cfia/projects/2

[x] documented architecture with diagram
[ ] test plan
[ ] developer documentation
[ ] a continuous lint, test, build and deployment pipeline

[ ] an automated unit test suite
[ ] code is linted to standard
[ ] code builds to container
[ ] code deploys to cloud with publically available url

[ ] monitoring and reporting in place

[ ] of daily active users

won't do. Archived


The TextFiled Cursor Height can not fix height

I find Android Device, Flutter TextFiled Cursor Height can change  when inputting some characters ;
we find this because follow two function

When I replace the function judgment condition of android with that of IOS, it is fixed， follow two function change

Hi @1036711153, this is a known issue and is being tracked in https://github.com/flutter/flutter/issues/92080.
Feel free to share your findings in that thread so that it may be properly addressed.
Closing from here as duplicate.
Thank you


Create Chat.statusfilter which also performs basic rank impersonation filtering

separate Chat.statusfilter from Chat.nicknamefilter instead of just using forStatus for more flexibility going forward. Eliminating the duplicated code present in namefilter, nicknamefilter and statusfilter is out of scope, but would likely be beneficial as a followup
do basic rank impersonation filtering, which when coupled with a UI which better differentiates rank in the user card (eg. Zarel/Pokemon-Showdown-Client#1319) should help with abuse

Looks good to me!

It wasn't working when I actually tested - instead of replacing I do a test and return so 'your status contains a banned word' is reported, which I think is the behavior we want.


Add F# example? ( ･ω･)

Uses the most popular web framework for F# these days, Giraffe

@pkanal this should be good for final review